[Feature] Common Regex Patterns

Is your feature request related to a problem? Please describe.
Provide regex patterns for common use cases like:

[ ] URL
[ ] email
[ ] hashtags
[ ] hex color

Each pattern should be available in two versions:

validator - the goal of this pattern type is to validate that given string is a valid email, url, etc. This type of pattern should focus on RFC/standards compliance.
finder - the goal of this pattern type is to effectively find given types of patterns (e.g. emails, hashtags, etc) in a longer text. This pattern types aims to be 90% in order to improve efficiency.

Describe the solution you'd like
Patterns will be imported through ts-regex-builder/patterns import. See #72 for implementation of that part.
Whole library is and should remain tree-shakable, so that unused patterns (and features) are removed by bundlers in order to reduce bundle size.
Describe alternatives you've considered

Providing pattens in examples/docs - this is an extra step and potentially hard to discover
Do nothing - making correct version of certain patterns (e.g. URL) is hard, and we as the library providers can make user life easier here.

Checklist (for each pattern)

[ ] Implementation
[ ] Tests
[ ] API docs
[ ] README docs (if relevant)

CC: @PaulJPhilp

I have a candidate for the URL patterns in my repo: .  i am writing an article about using ts-regex-builder to build this regex.  The point I am trying to make in the article is that this library allows you to write regular expressions like normal hygienic software.  So, I break the URL pattern into sub-patterns (Scheme, Authority, ....). Can you take a look at what I've done before I put together a full PR and provide your feedback.

@PaulJPhilp awesome. Please send me some link to the code and I'll take a look.

Maciej:
Sorry for the delay.  I ran into a bug (bug report to follow).  Here is my repo with the partially completed URL pattern.  Please let me know your feedback.
https://github.com/PaulJPhilp/ts-regex-builder
Thank you,
Paul

@PaulJPhilp you're definitely going in the good directions. The difficulty of the task, imo lies in the fact that URL is a complex pattern built from different smaller patterns, and it's a tedious work to get all of these right.
I've lefts some comments on the last commit: https://github.com/PaulJPhilp/ts-regex-builder/commit/0fdbf6c2fe6f69ea70dfdbb26a9991d1ddf614d5#diff-350009127029ecbdcc6940f99827bae2f3ece87b095a287c48db47ace9ef363dR43
BTW Pls create PR next, time, as it's make review and discussion happen in one, well defined place.


Update typesafe:config to 1.4.2

Updates com.typesafe:config from 1.3.4 to 1.4.2.
GitHub Release Notes - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "com.typesafe", artifactId = "config" } ]

labels: library-update, early-semver-minor, semver-spec-minor, commit-count:1

Coverage decreased (-2.8%) to 91.975% when pulling ee9871f490355168e3c5c6b94dee51352c894008 on scala-steward:update/typesafe-1.4.2 into ca10c64b98af9973d1b830d6a180d8b2c8898d98 on iheartradio:master.

Superseded by #281.


RecyclerView

List done  GridView done,,,RecyclerView  is not !

Any hopes that you'll work on this?


EGRA text not displaying on some Android devices

Hi there, we are using the EGRA reading test in our survey. It appears and works great on some devices, but won't appear on others.  The question displays and we see the text custom-egra-test(type = 'reading', duration = 60) and the start button, but then the paragraph does not appear below (see below.
We are using SurveyCTO Collect v2.70, and I confirmed it works on other devices. (I've included the specs of the problematic device below.) Do you know how we can resolve this issue?

I think I resolved this - I redownloaded the plug-ins (timed-field-list, timed-grid-list, and button-to-advance) and attached them to the form, and that seemed to work.

Hi Anna,
I'm glad you managed to solve! One issue might be backward compatibility. We've just recently improved backward compatibility to include devices running Android as old as 5.1.1. Redownloading probably means that you're now running our improved field plug-ins version on an older Android device. Is that true?
Thanks for the feedback and for trying this beta version of our timed-grid-test field plug-in!


Why use as Conv2D use_bias=not batch_normalize in Convert Model

in   convert.py line 168 , why as batch_normalize on will set use_bias to False ?
conv_layer = (Conv2D(
filters, (size, size),
strides=(stride, stride),
kernel_regularizer=l2(weight_decay),
use_bias=not batch_normalize,
weights=conv_weights,
activation=act_fn,
padding=padding))(prev_layer)

BatchNorm layers will shift activations by their mean values, so there's no point in adding any constants anyways – setting use_bias=False saves time and memory here.

BatchNorm layers will shift activations by their mean values, so there's no point in adding any constants anyways – setting use_bias=False saves time and memory here.

impressive answer


Fix #23, Type Parameters of sealed Traits are now forwarded correctly to Case Classes

The solution is a bit tricky ...
I basicly simulate a pattern match and then extracts the type.
But at least it works.

Can you also add a test case that demonstrates that it works.

I added a test for it.
By the way ... when i call sbt test i get some compilation errors...

The compilation errors are because I removed import boopickle._ from the macro code, and it seems to be needed in some cases.


x/gravity: add events for jailing and slashing

Add missing events for when a validator is jailed and slashed
Some minor cleanup and error handling

This PR looks great. Reminds me that there is a lot of cleanup in the params. May of those vars aren't used anymore and are redundent.


[ECS] Fix correct merging of parameters caused by YamlFileLoader override

Built on #716
Shall fix the problem with merging of parent parameters.

@OndraM Shall be ready for the first test :) Could you review?
Also, add any other cases that are currently broken.

Merging so it can be tested

Wow, great, will try tommorow!


feat(setup): Change default wheel to only support cpu builds.

Closes #325
Pull Request
What does this PR do?
Closes #325
Notes:

Replace (issue) above ↑↑↑ with the issue this PR closes to automatically link the two.
This must be done when the PR is created.
Add multiple Closes #(issue) as needed.
If this PR is work towards but does not close an issue, simply tag the issue without mentioning Closes.

Description
Describe the changes proposed by this PR below to give the reviewer context below ↓↓↓

Current PrimeQA wheel packages gpu specific python dependencies. E.g faiss-gpu
This causes PrimeQA wheel installation on CPU only machine to fail.
Updated setup.py to build cpu friendly wheel by default and added extra target gpu which allow user to install gpu friendly package.

Request Review
Be sure to request a review from one or more reviewers (unless the PR is to an unprotected branch).
Versioning
When opening a PR to make changes to PrimeQA (i.e. primeqa/) master, be sure to increment the version following
semantic versioning.  The VERSION is stored here
and is incremented using bump2version {patch,minor,major} as described in the (development guide documentation)[development.html].

[X] Have you updated the VERSION?
[ ] Or does this PR not change the primeqa package or was not into master?

After pulling in changes from master to an existing PR, ensure the VERSION is updated appropriately.
This may require bumping the version again if it has been previously bumped.
If you're not quite ready yet to post a PR for review, feel free to open a draft PR.
Releases
After Merging
If merging into master and VERSION was updated, after this PR is merged:

[X] Create a release from the master with version equal to VERSION
[ ] Not merging to master or VERSION not updated

Checklist
Review the following and mark as completed:

[X] Tag an issue or issues this PR addresses.
[X] Added description of changes proposed.
[X] Review requested as appropriate.
[X] Version bumped as appropriate.
[ ] New classes, methods, and functions documented.
[X] Documentation for modified code is updated.
[ ] Built documentation to confirm it renders as expected (see here).
[ ] Code cleaned up and commented out code removed.
[ ] Tests added to ensure all functionalities tested at >= 60% unit test coverage (see here).
[ ] Code cleaned up and commented out code removed.
[ ] Release created as needed after merging.

@bhavani105 @avisil @franzmpub Let me know if this PR looks good. Like to get it merged asap to move to services related PR.


Make all Cards shadow same

I'm working on this

sure work on this

It is now done. You should probably check it

Thank You dennypradipta..if you like to work on more stuff contact us


Disable WebP

What is the easiest way to disable WebP?
The images on my home page are too small and look pixelated.
https://mrneilypops.xyz
Neil

you can change this line:
https://github.com/halfrost/Prometheus/blob/f59e41979571d9bd2ad58f9238f949196949699d/assets/js/index.js#L609
This code makes special logic, aiming at the home page image. You can make updatedUrl to any url.

I have changed that line to .webP_load === false but my front page image is still scaling to 300x169.
Is there another change I need to make?

If you are familiar with CSS, you can change these header-wrap header-wrap-home styles.


Allow enum flattening

This PR is aimed at allowing the use of #[flatten] in enum variants. It's not a very large change, but it does cause some code duplication, by redoing some of what format_variant does inside enum_def, so I'd like some ideas on how to mitigate that (maybe by changing format_variant to return variant_type?)
Fixes #96

I'm converting this to a draft because I found a massive bug while testing further. My tests only had the enum itself in the struct, but adding other fields didn't work

This feature requires changing all uses of interface to type in order to allow for type intersection (& operator)

I have changed all the tests to account for this and added a few tests for the flattening of enums.
Although all the tests are passing, I'm still not 100% sure I haven't broken anything

This feature requires changing all uses of interface to type in order to allow for type intersection (& operator)

I think this is fine. As far as I know, interfaces only additionally support declaration merging. I don't know for sure how common that pattern is, but I suspect not very often.

I have only ever seen declaration merging when I used the next-auth library (their examples had it to override some cookies and sessions) as well as people wanting to add to Window

Alright! So let's drop this for now, I think that's fine.
I've run a few sanity checks against serde-json, and the output of your flattened enums is consistant with it. Very nice!
Before this PR, I didn't even know it was possible to do that. Pretty awesome stuff.

Alright! So let's drop this for now, I think that's fine. I've run a few sanity checks against serde-json, and the output of your flattened enums is consistant with it. Very nice! Before this PR, I didn't even know it was possible to do that. Pretty awesome stuff.

Thanks! And I agree, altough everything I tested worked, I just don't trust all the string manipulation I was doing in there

Alright! So let's drop this for now, I think that's fine. I've run a few sanity checks against serde-json, and the output of your flattened enums is consistant with it. Very nice! Before this PR, I didn't even know it was possible to do that. Pretty awesome stuff.

Thanks! Btw. I think I got somewhat confused. Do you mean drop the PR or the declaration merging?

:D I meant declaration merging! Would love to support flattened enums, I think this effort is great!

Great, I might make a separate PR to change interfaces to types and simplify this one when it's ready

Awesome, take your time!

I also think we need to figure out some better way to identify flattened enum fields, I did a whole lot of string manipulation there that I'm not sure will be able to handle everyone's use cases

I 100% agree! Once you think this is ready, feel free to convert it back to a PR again, then I'll take an other look.
Let me know as well if you get stuck, I'd definetely be happy to help!

I think I figured it out. I created a new local branch to start from scratch and managed to get something working by converting all uses of flatten into type intersections.
This makes for slightly more redundant TS code but it seems to work. Example with the flatten test:
type Original = { b: { a: number, b: number, c: number, }, d: number, }

type New = { b: { c: number, } & { a: number, b: number, }, d: number, }
//              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ More verbose way to express the same type

This pretty much eliminated the string manipulation mess I was previously doing

@NyxCode should I close this PR and submit the new branch as a new one or transfer the code over here?

Btw the extra intersection can probably be solved by adding .replace(" } & { ", " "), which should generate the following:
type Original = { b: { a: number, b: number, c: number, }, d: number, }

type New = { b: { c: number, a: number, b: number, }, d: number, }
//                ^^^^^^^^^ Less verbose, but the fields will still be out of order (non-flattened fields always come before flattened ones)

I think I figured it out. I created a new local branch to start from scratch and managed to get something working by converting all uses of flatten into type intersections.
This makes for slightly more redundant TS code but it seems to work. Example with the flatten test:
type Original = { b: { a: number, b: number, c: number, }, d: number, }

type New = { b: { c: number, } & { a: number, b: number, }, d: number, }
//              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ More verbose way to express the same type

This pretty much eliminated the string manipulation mess I was previously doing

Awesome! Yeah, I don't see any issues with this whatsoever. The generated TS might be a bit more unintuitive that way, but I don't think anyone cares about that.

@NyxCode should I close this PR and submit the new branch as a new one or transfer the code over here?

Whatever you think is best! Generally, I think splitting a change like this into small PRs (doing required refactorings first, then implementing the feature) is a great idea.

The generated TS might be a bit more unintuitive that way, but I don't think anyone cares about that.

I managed to change that in the latest commit


sorting and indexing bam files

Hi. This is the first time I am using vardict.
I was wondering if the bam files need to be sorted and indexed before using vardict?
And what does "corr" stands for in this bam file? Thanks!
sample1_sorted.corr.bam

@gpuwarrior, hello!
Apologies for the late reply!
Yes, VarDict needs indexed BAM (and because the index is created from sorted BAM, it must be also sorted).
I can not tell what "corr" means in the BAM file, but I guess it is the version of the BAM file after applying some filters or recalculations.
I will close the issue but you can reopen it if needed.
Thank you!


How to set properties for a textframe

Sorry to bother you with such a basic question. My programming skills are a bit rusty. :)
I have following code :
# Add textframe
            left = Inches(1.0)
            top = Inches(4.0)
            width = Inches(6.0)
            height = Inches(6.0)

            txBox = slide.shapes.add_textbox(left, top, width, height)
            tf = txBox.textframe

            tf.text = data['Progress']

How can I make the textframe to autowrap the text and  give the textframe a black border ?

Hi all,
I also want to give a textframe a border, but I can't and I will appreciate some advice. I'm using the most recent version python-pptx (Version 0.6.19) and Python 3.8.5 and the solutions mentioned above (https://github.com/scanny/python-pptx/issues/59#issuecomment-29568123) did not work for me. As I can't reach SubElement anymore I tried to adapt the lines above with OxmlElement
    from pptx.oxml.xmlchemy import OxmlElement

    def _set_rgb_color(pr_elm, rgb):
        try:
            solidFill = pr_elm.solidFill
            solidFill.clear()
        except AttributeError:
            solidFill = OxmlElement(pr_elm, 'a:solidFill')
        srgbClr = OxmlElement(solidFill, 'a:srgbClr')
        srgbClr.set('val', rgb)

    def _set_shape_line_rgb_color(sp, rgb):
        pr_elm = OxmlElement(sp._element.spPr, 'a:ln')
        _set_rgb_color(pr_elm, rgb)

but I get this error and I don't know how to solve that:
File "main.py", line 14, in <module>
  tool.fill_report()
File "C:\hilti\hilti_icos\project\tool.py", line 60, in fill_report
  _set_shape_line_rgb_color(tf, 'DD4A0B')
File "C:\hilti\hilti_icos\project\tool.py", line 47, in _set_shape_line_rgb_color
  pr_elm = OxmlElement(sp._element.spPr, 'a:ln')
AttributeError: 'CT_TextBody' object has no attribute 'spPr'

Is there already another way to give the textframe a border? If not, can anyone help me to adapt the above-mentioned solution to my environment?
Many thanks in advance!

This issue is closed. Please post support questions on StackOverflow using the python-pptx tag and we'll see it.


Hide deploy page which «under construction»

https://turbostrapi.vercel.app/deploy

Thanks for pointing it out! I've removed the Deployment page for now 🙂


Adding load more feature for FAQs and enhancing FAQs content

@Trisha-tech
Here in the FAQs section, the content is visible properly and also only few FAQs are available, so i would like to add a button - load more, so that when user click it, few more FAQs will be loaded and continue.
I would like to work on these two things, could you please assign this to me

Hi, I'd like to work on this issue. Could I be assigned to it?


Added nose coverings on gaiters

About the PR
Added 2 pixels on the front of the left and right views of the red and black gaiter sprites so that they would properly cover the nose of their wearers. This is my first PR so if there are any errors or anything please contact me, thank you.
Why / Balance
https://github.com/space-wizards/space-station-14/issues/30848 As per this issue the side view of the old gaiters didn't cover humanoid noses correctly.
Media
Below are pictured the new gaiters as modeled by Urist McHands.

Requirements

[X] I have read and I am following the Pull Request Guidelines. I understand that not doing so may get my pr closed at maintainer’s discretion
[X] I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Changelog

:cl: - tweak: Gaiters now cover their wearers' noses.

Thank you for contributing! The only tweaks I’d suggest right now would probably to make it so that the gaiter doesn’t diagonally touch the eye on side view, as it looks a little weird that way, alongside perhaps making the front view consistent to this change as well?

Looks funky with a human that has the Schnozz nose, but to be fair the normal gaiter probably looks worse.


[UI] Remove successfully from snackbars across Meshery

Signed-off-by: Gaurav Chadha<EMAIL_ADDRESS>Remove successfully from snackbars across Meshery
Notes for Reviewers
This PR fixes #
Signed commits

[x] Yes, I signed my commits.

Codecov Report
Base: 12.57% // Head: 12.57% // No change to project coverage :thumbsup:

Coverage data is based on head (a758437) compared to base (2ac4fab).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6702   +/-   ##
=======================================
  Coverage   12.57%   12.57%
=======================================
  Files         115      115
  Lines       11192    11192
=======================================
  Hits         1407     1407
  Misses       9471     9471
  Partials      314      314

Flag
Coverage Δ

unittests
12.57% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

server/handlers/component_generation.go
0.00% <0.00%> (ø)

server/handlers/meshery_filter_handler.go
0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Expose Buffer underlying raw id

Hi. I have encountered a need to use the Buffer struct's underlying BufHandle as a raw i32.
Just to avoid the XY problem: I need to be able to format it as an i32 to pass it in a buffer-local set_keymap as right side of the keymap that invokes another plugin function. I can't use a callback instead of rhs for this because my plugin's functions rely on  state from a separate non-nvim thread that the plugin spawns on startup.
Since it is impossible to implement a non-conflicting From/Into because of this implementation:
impl<H: Into<BufHandle>> From<H> for Buffer {
    #[inline(always)]
    fn from(handle: H) -> Self {
        Self(handle.into())
    }
}

What I came up with so far is such method:
pub fn as_i32(&self) -> i32 {
    self.0
}

Yes, we could add a fn handle(&self) -> i32 method on Buffer, Window and TabPage. I'd merge a PR if you want to work on adding those.
P.S. all the handles are i32 because Neovim defines handle_T as an int, but are negative handles ever used?

Yes, we could add a fn handle(&self) -> i32 method on Buffer, Window and TabPage. I'd merge a PR if you want to work on adding those.

Ok, I will work on it then.

P.S. all the handles are i32 because Neovim defines handle_T as an int, but are negative handles ever used?

I haven't ever encountered negative handles but I think playing safe and just using i32 won't hurt.

Closed by #176.


Is IndelRealigner needed when calling somatic mutations

Hi,
Thanks for continuous efforts on updating Sentieon. I noted the example pipeline is kind of different from what I saw in the last year. If I remember correctly, previously, it is recommended to (1) realign the reads around indels (2) co-realignment of tumor and normal, and then run TNscope/TNhaplotyper/TNsnv. But now I see these steps are removed. My questions are:

Should I follow the up-to-date example script without indel realignment?
TNscope/TNhaplotyper/TNhaplotyper2/TNsnv, which one, from your experience, has the best performance and is recommended for mutation detection?
I see in the new example scripts, there are some filtering on mutations using BCFtools. Do I need to modify the parameters to make them suitable for different sequencing depth (My data is 30X WGS, tumor-normal paired)

Thanks in advance!
Best
Yang

Hi Yang,

Indel realignment is optional. For the sake of simplicity, we removed these steps from the example scripts.
We recommend TNscope and TNhaplotyper2. TNscope is more sensitive than the other callers but requires additional filters to remove false positives.
Yes, the filter should be modified accordingly. Also, you can try TNhaplotyper2 for the 30x WGS tumor-normal paired.

Please feel free to contact<EMAIL_ADDRESS>if you need more help.
Thanks,
Haodong

Hi Haodong,
Thanks for your reply! I'll take a try.
Best
Yang


Provision device with deltas enabled

Signed-off-by: Horia Delicoti<EMAIL_ADDRESS>Closes #139

You also need to add this variable to the Makefile, otherwise it will not be bridged.

@jviotti No need to add this the env var to Makefile because we have a for loop for all of them


Differently dataset object saved than it is loaded.

Describe the bug
Differently sized object is saved than it is loaded.
Steps to reproduce the bug
Hi, I save dataset in a following way:
        dataset = load_dataset("json",
                               data_files={
                                   "train": os.path.join(input_folder, f"{task_meta_type}_{task_type}_train.jsonl"),
                                   "test": os.path.join(input_folder, f"{task_meta_type}_{task_type}_test.jsonl")})
        print(os.path.join(output_folder, f"{task_meta_type}_{task_type}"))
        print(f"Length of train dataset: {len(dataset['train'])}")
        print(f"Length of test dataset: {len(dataset['test'])}")
        dataset.save_to_disk(os.path.join(output_folder, f"{task_meta_type}_{task_type}"))

this yields output
.data/hf_dataset/propaganda_zanr
Length of train dataset: 7642
Length of test dataset: 1000

Everything looks fine.
Then I load the dataset
from datasets import load_dataset

dataset_path = ".data/hf_dataset/propaganda_zanr"
dataset = load_dataset(dataset_path)

print(f"Length of train dataset: {len(dataset['train'])}")
print(f"Length of test dataset: {len(dataset['test'])}")

this prints
Generating train split: 1 examples [00:00, 72.10 examples/s]
Generating test split: 1 examples [00:00, 100.69 examples/s]
Length of train dataset: 1
Length of test dataset: 1

I dont' understand :(
Expected behavior
same object is loaded
Environment info
datasets==2.16.1

I see now, that I have to use load_from_disk, in order to load dataset properly, not load_dataset. Why is this behavior split? Why do we need both, load_dataset and load_from_disk?
Unless answered, I believe this might be helpful for other hf datasets newbies.
Anyway, made a load_dataset compatible dataset in a following way. I created a directory, and just copied jsonl there as train.jsonl/test.jsonl.
output_folder = os.path.join(args.output_folder, f"{task_meta_type}_{task_type}")
os.makedirs(output_folder, exist_ok=True)
file = f"{task_meta_type}_{task_type}_train.jsonl"
shutil.copy(os.path.join(input_folder, file),
            os.path.join(output_folder, "train.jsonl"))
# now test
file = f"{task_meta_type}_{task_type}_test.jsonl"
shutil.copy(os.path.join(input_folder, file),
            os.path.join(output_folder, "test.jsonl"))

Hi @MFajcik,
You can find information about save_to_disk/load_from_disk in our docs:

https://huggingface.co/docs/datasets/v2.16.1/en/process#save
https://huggingface.co/docs/datasets/v2.16.1/en/package_reference/main_classes#datasets.Dataset.save_to_disk
https://huggingface.co/docs/datasets/v2.16.1/en/package_reference/main_classes#datasets.Dataset.load_from_disk


add mod file and bump major version

continuation of module change from #52
since your release tags are v2+ simply adding a go.mod file will cause
v2.0.0+incompatible versions in consumers

the go authors suggest bumping the major version to resolve this:
https://github.com/golang/go/wiki/Modules#incrementing-the-major-version-when-first-adopting-modules-with-v2-packages

after merge you should tag this repo with v3.0.0

you could migrate to v2.1.0, but this could cause consumer
breakage
this uses the major branch paradigm, but you could leverage major
subdirectory instead:
https://github.com/golang/go/wiki/Modules#releasing-modules-v2-or-higher

Does the lack of a go.mod cause concrete problems in downstream dependencies?

While there is currently no breakage from the lack of a go.mod file, not having indirect dependencies tracked means that consumers have to track them directly:
module github.com/user/repo

go 1.12

require (
        github.com/google/btree v1.0.0 // indirect
        github.com/peterbourgon/diskv v2.0.1+incompatible
)

I'd appreciate having the mod file. Thanks.


Minor MLJ interface fix. Add MLJ interface test.

In support of #8.
The interface looks very good. Only caught one mistake with a missing type annotation, corrected in this PR.
This PR also adds a generic MLJ interface test, requiring that I add MLJTestIntegration to the test dependencies. You could keep this, although this adds MLJ (rather than MLJBase) as a test dependency, and is still a little experimental.
I've added some further comments at #8

Awesome, thanks!


Split SwiftSyntaxParser into a separate module

When SwiftSyntax is just being used to generate code and not to parse Swift source files, there is no reason that a compatible _InternalSwiftSyntaxParser.dylib needs to be present. We do, however, currently have the requirement of always needing a _InternalSwiftSyntaxParser.dylib because SyntaxParser lives inside the SwiftSyntax module and thus SwiftSyntax needs to link against _InternalSwiftSyntaxParser.dylib.
To lift the requirement, split SwiftSyntax into two modules: SwiftSyntax has no requirement on _InternalSwiftSyntaxParser.dylib. It only offers functionality to programatically generate SwiftSyntax trees and walk them. The new SwiftSyntaxParser module links against _InternalSwiftSyntaxParser.dylib and provides the ability to generate SwiftSyntax trees from source files.
To efficiently generate SwiftSyntax nodes from the parser, RawSyntax (and its child types) does depend on the layout of the C nodes (for example, TokenData stores CTriviaPieces as trailing trivia and only constructs the trivia’s Swift representation when requested). I don’t think it’s possible to eliminate that behaviour without eager translation and thus decided to include a copy of the C nodes inside the SwiftSyntax. When SwiftSyntax is used on its own, they are never used and thus their value is irrelevant. When a source file is parsed through SwiftSyntaxParser, it first verifies that the C node layouts match those defined in _InternalSwiftSyntaxParser.dylib, similar to how we currently compute the node hash. If the layouts are not compatible, we throw an error. We also verify that the files definingt these types match when invoking build-script (e.g. in CI).
rdar://81158771

@swift-ci Please test

Build failed
Swift Test OS X Platform
Git Sha - cdb0af2514a9d678360c79a964c9f5a00d02c88a

https://github.com/apple/swift-stress-tester/pull/163
@swift-ci Please test macOS

https://github.com/apple/swift/pull/39441
@swift-ci Please test

https://github.com/apple/swift-stress-tester/pull/163
https://github.com/apple/swift/pull/39441
@swift-ci Please test macOS

Build failed
Swift Test Linux Platform
Git Sha - cdb0af2514a9d678360c79a964c9f5a00d02c88a


[FLINK-19472] Implement a one input sorting DataInput

What is the purpose of the change
This is part of https://cwiki.apache.org/confluence/display/FLINK/FLIP-140%3A+Introduce+batch-style+execution+for+bounded+keyed+streams
Brief change log
Please look at each commit message which describes in detail what is happening.

Implements the sorting DataInput
Makes the StatusWatermarkValve use the DataOutput passed in DataInput#emitNext.
Optionally injects the sorted input in the OneInputStreamTask

Verifying this change
This change added tests and can be verified as follows:

Added unit tests in SortingDataInputTest
Added an IT tests with a higher number of incoming records to sort in SortingDataInputITCase
Added end to end test SortingBoundedInputITCase

Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): (yes / no)
The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no)
The serializers: (yes / no / don't know)
The runtime per-record code paths (performance sensitive): (yes / no / don't know)
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (yes / no / don't know)
The S3 file system connector: (yes / no / don't know)

Documentation

Does this pull request introduce a new feature? (yes / no)
If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

I run the benchmarks and the only significant difference (regression) is in the unalignedCheckpoint. There is a clear explanation though as my branch did not include the changes that resulted in performance improvement from the 1st Oct (FLINK-16972 & FLINK-19400). I can also rerun with rebased changes if you will.

I hope I addressed your comments @aljoscha @pnowojski Could you take another look?

I think there is no need @dawidwys to re run benchmarks. There was improvement with unaligned checkpoints that have been merged on Friday/Thursday, which is probably missing in your PR.

(I have no further comments. I didn't do the full review as @aljoscha was doing it already, hence I'm not giving my official +1 here ;) )


Elvis not repeating lines in Pelagic II

Known bug from N64, I think it applies to more NPC's other than Elvis but this is the most known:
If you shoot his gun in Pelagic II, he'll say the line over and over again. On the PC port, he'll only play the animation and show the subtitles, but won't say anything.
PC Port:
https://github.com/fgsfdsfgs/perfect_dark/assets/34986384/8ba03c19-0a73-4218-a3f2-97025e3d4942
1964 GEPD:
https://github.com/fgsfdsfgs/perfect_dark/assets/34986384/68a67104-587a-44ed-8bcd-82c7af4bf473

This is probably related to mp3's not repeating properly. This occurs on cutscenes as well if you quit while it plays and restart.

Somehow I didn't realize this would be necessary. Will fix shortly.

Should be fixed now.

Can confirm it's fixed.


3 seconds delay when max_open_connections is set

Describe the bug
When max_open_connections value is set, client delays request by 3 seconds.
Steps to reproduce

Create client with max_open_connections = 1  ( with 1 it's easier to notice, but I think the problem exists with any value )
Run some insert queries in parallel or sequentially
Notice that the delay is 3 seconds for each request

There seems to be no problem with selects.
Expected behaviour
Requests should be executed much faster
Code example
The code below runs two sequentual queries and logs response times.
const { createClient } = require('@clickhouse/client');

(async () => {
    const client = new createClient({
        host: 'http://localhost:8123',
        max_open_connections: 1,
    });

    await client.exec({
        query: 'DROP TABLE IF EXISTS test_table',
    });
    await client.exec({
        query: `CREATE TABLE test_table (user_id UInt64) ENGINE = MergeTree() PRIMARY KEY (user_id) FORMAT TabSeparated`,
    });

    console.log('table created');

    for (let i = 0; i < 2; ++i) {
        const start = performance.now();

        try {
            await client.insert({
                table: 'test_table',
                values: [
                    {
                        user_id: i,
                    }
                ],
                format: 'JSONEachRow',
            });

            console.log('insert success', i);
        } finally {
            const end = performance.now();

            console.log('request took', end - start, 'ms');
        }
    }

    const countResult = await client.query({
        query: 'SELECT count() as count FROM test_table',
    });
    const countJson = await countResult.json();

    console.log('finished, rows after insert:', countJson.data[0].count);
})();

Error log
Notice that each request takes 3 seconds
table created
insert success 0
request took 3008.7007999999914 ms
insert success 1
request took 3008.5150999999605 ms
finished, rows after insert: 2

Configuration
Environment

Client version: 0.0.16
Language version: nodejs v18.12.1
OS: Ubuntu 22.04

ClickHouse server

ClickHouse Server version: <IP_ADDRESS>-alpine
ClickHouse Server non-default settings, if any: None
CREATE TABLE statements for tables involved: Included in code example

Here is the docker compose file used to run clickhouse server
version: '3.7'

services:
  clickhouse:
    image: "clickhouse/clickhouse-server:<IP_ADDRESS>-alpine"
    restart: always
    ports:
      - "8123:8123"
      - "9000:9000"

Additional notes
I have example with axios client with roughly same setup which does not have this problem.
Axios version: 1.4.0
Logs ( notice much faster response time )
table created
insert success 0
request took 6.3756999999750406 ms
insert success 1
request took 3.766200000187382 ms
finished, rows after insert: 2

Here is the code
const http = require('http');

const axios = require('axios');

const axiosInstance = axios.create({
    httpAgent: new http.Agent({
        keepAlive: true,
        maxSockets: 1,
    }),
});

const baseRequestParams = {
    auth: {
        "username": "default",
        "password": "",
    },
    url: 'http://localhost:8123',
    method: 'post',
};

(async () => {
    await axiosInstance({
        ...baseRequestParams,
        "data": "DROP TABLE IF EXISTS test_table FORMAT TabSeparated",
    });

    await axiosInstance({
        ...baseRequestParams,
        "data": "CREATE TABLE test_table (user_id UInt64) ENGINE = MergeTree() PRIMARY KEY (user_id) FORMAT TabSeparated",
    });

    console.log('table created');

    for (let i = 0; i < 2; ++i) {
        const start = performance.now();

        try {
            await axiosInstance({
                ...baseRequestParams,
                "data": `INSERT INTO test_table  (user_id)  VALUES (${i})`,
            });

            console.log('insert success', i);
        } catch (error) {
            console.error('request error', error);
        } finally {
            const end = performance.now();

            console.log('request took', end - start, 'ms');
        }
    }

    const countResult = await axiosInstance({
        ...baseRequestParams,
        "data": "SELECT count() as c FROM test_table",
    });

    console.log('finished, rows after insert:', countResult.data);
})();

Sorry for the long response, and thank you very much for this report.
I think I finally found where the problem here is (it's a nasty one, though).
And it is especially noticeable when you are using only one connection.
What is happening here is that we have an incoming response stream for insert/exec, which is not consumed in the code, and that stream is holding the socket for as long as request_timeout allows. Then, the socket quietly times out (which is an issue on its own cause it's not logged properly), and the program continues as normal cause everything is fine - we received 200 OK, it's just the stream that was eventually destroyed.
However, likely, it will introduce a bit of a breaking change in exec - we need to understand whether we want to ignore the incoming stream and destroy it ASAP, releasing the socket, or we want to consume it in the code.
Additionally, it looks like this is also related to #150, and that's also caused by the underlying sockets timeout.

Great news, thank you!

@yamaskin, should be resolved in 0.1.0. In your scenario, please use command instead of exec on a new version.


Viability of mass content migrations

(Hello, thanks for the plugin!)
I'm developing a reasonably complex Craft website that uses one install to serve content to two domains.
Because of this, I have some entry structures with 1,000s of entries. I want to create a migration of content from one to the other.
This seems very difficult because I have to slowly load almost endless pages of entries and keep hitting that checkbox and then 'Create migration'.
Is there a better way to do this? Am I looking in the wrong place with this plugin?
Any suggestions appreciated!

Hi @iparr. For that many entries you might be better off trying something like the FeedMe plugin https://verbb.io/craft-plugins/feed-me/features

Thank you @dgrigg. I'm familiar with that useful plugin. I'm happy with the importing bit, but I'd need to generate my own custom feed for later consumption by FeedMe. Maybe I should look at ElementAPI. I wonder how much configuration is required to produce a bullet-proof feed that will be consumed effectively.
I guess I might just be looking for a shortcut. Perhaps a little lazily! Thanks for your help anyway.


CI always reports escape analysis results

Currently, CI always report results of escape analysis for main.go as shown in the attached image.
These escaping variables do not mean bugs or memory leaks. These information are just hints for performance optimizations.  In my opinion, reporting these results in CI seem confusing, since they are shown as failures. I think it is safe for us to disable escape checks in CI.

@SamYuan1990 do you have any comments?

It depends, some of memory leak is due to golang language itself. But it may also cause by bug or code in bad implementation.
Memory leak will cost more GC happens.
so I am agree it is not as failures, and as hints for performance optimizations.
here is a sample: https://dave.cheney.net/2014/06/07/five-things-that-make-go-fast
@yoheiueda could you please try to test with escape analysis sample function in a pr of this repo to see if we can cover escape analysis test by other CI processing or not?
if not, I think it is valuable. but I would like to follow team's final decision.

@SamYuan1990 Thank you for the reply.
I prepared a draft PR for discussion. #609
One thing I noticed is that the current test only reports escape checks in main.go only. I don't know why the other files are not checked.  Performance optimizations in main.go does not improve the overall performance in our case.
Another point is that the currently test results are filtered with grep, but the output of escapes check is printed in stderr, so I think we need to fix it like this https://github.com/confidential-containers/cloud-api-adaptor/pull/609/commits/0c75842d93b5b215ff9f3b78c97e40825b551979.

@SamYuan1990 Thank you for the reply.
I prepared a draft PR for discussion. #609
One thing I noticed is that the current test only reports escape checks in main.go. I don't know why the other files are not checked. Performance optimizations in main.go will not improve the overall performance in our case.
Another point is that the currently test results are filtered with grep, but the output of escapes check is printed in stderr, so I think we need to fix it like this 0c75842.

here is a good sample https://github.com/confidential-containers/cloud-api-adaptor/pull/609/files#r1104452743

@SamYuan1990
I still see escapes check results in main.go only in the Files changed page as described at https://github.com/confidential-containers/cloud-api-adaptor/pull/610#issuecomment-1429056174
There are more than 2,000 errors per cloud provider, and I think showing them in Files changed seems too excessive.

In my opinion, CAA is not a performance sensitive program for now, and fixing the potential escapes may lead to premature optimizations. It may degrade code readability and maintainability.
Escaped variables will not always degrades GC performance. In a typical case, GC performance becomes critical when long-lived objects are bloated. Short-lived objects, and a small amount of long-lived objects are not problems for memory management.
When the performance of CAA matters, then we will profile CAA, and identify hot functions and memory allocation sites. As you know, software usually has the 80-20 rule, so optimizing the hot 20% of a program will lead to a significant performance improvements.
For the resaons above, I don't think the 2,000+ errors in CI results is not helpful to improve the code quality. @SamYuan1990 what do you think?

In my opinion, CAA is not a performance sensitive program for now, and fixing the potential escapes may lead to premature optimizations. It may degrade code readability and maintainability.
Escaped variables will not always degrades GC performance. In a typical case, GC performance becomes critical when long-lived objects are bloated. Short-lived objects, and a small amount of long-lived objects are not problems for memory management.
When the performance of CAA matters, then we will profile CAA, and identify hot functions and memory allocation sites. As you know, software usually has the 80-20 rule, so optimizing the hot 20% of a program will lead to a significant performance improvements.
For the resaons above, I don't think the 2,000+ errors in CI results is helpful to improve the code quality. @SamYuan1990 what do you think?

well, I don't want to repeat myself too many times. but

I will follow team's decision.
No matter what decision is, 20-80 or ... is a balance between the advantages and disadvantages.
As initiator, I suppose my response here is to explain what it is.(The facts, as I don't want to have any discussion with any against style, or we force to do sth)

Here are the facts:

Some memory leak is due to golang implementation itself, for example big number packages or when we use []string as parameter input of a function. Hence for each line, we need to check it case by case, as some times it is not an error.
Memory leak test can help us find out some implementations which are not good, as it leak to memory. I am not sure if golang can been trusted as a memory safe coding language. Here I just want to point out a question, what's memory leak at security point of view?
CAA is not performance matters appliance, just when it is not used to CURD with pod in high frequency? hence even if pod auto scale is an edge case right? If all normal cases are good, we can trade off on edge cases.

As a summary, @yoheiueda
May I learn from this ticket, I suppose we don't have to close it in this week or this month before we figure out:

do we want to benefits from escaped checking?
is golang trusted as memory safe language?
CAA is performance matters or not? If there any case performance matter, what is that?
For this project, what's the trade off?

I suppose 2000 lines or 3000 lines... the number is not the key point.

How about keep the escape check in Makefile and disable it in CI git actions? So that developers can run/fix it by themselves. Then we can enable the escape check in future in CI? I talked with @SamYuan1990 , he agree with this. @yoheiueda thoughts?

How about keep the escape check in Makefile and disable it in CI git actions? So that developers can run/fix it by themselves. Then we can enable the escape check in future in CI? I talked with @SamYuan1990 , he agree with this.

@huoqifeng I agree. My PR was prepared in the direction. https://github.com/confidential-containers/cloud-api-adaptor/pull/609
I'll update the PR to show results for all files with the Makefile check.

How about keep the escape check in Makefile and disable it in CI git actions? So that developers can run/fix it by themselves. Then we can enable the escape check in future in CI? I talked with @SamYuan1990 , he agree with this. @yoheiueda thoughts?

I think this approach makes sense for the time being.
We do need to start focussing on the performance aspects especially w.r.t pod VM startup time as that's the one which is immediately visible to the end-user.
For reference linking the related issue here -  https://github.com/confidential-containers/cloud-api-adaptor/issues/343


Remove cookie with delete cookie.name is not working

In the documentation, we can delete a cookie similar to removing a property in a JavaScript object:

After trying, the cookie did not get deleted, and upon checking the 'Response Headers,' there was no 'Set-Cookie' present at all.

Here is my code:
import swagger from "@elysiajs/swagger";
import Elysia from "elysia";

const app = new Elysia();

app.use(swagger());

app.get("/", ({ cookie }) => {
    delete cookie.token;
});

app.listen(3000);

Yes, you are correct. I have resolved this issue by making modifications to the file compose.ts and adding the following lines:
const removeCookie = `\n
    console.log('remove cookie')
    if(c.set.cookie == undefined) c.set.cookie = {};
            cookieKeysBeforeHandler.filter(x => !(x in c.cookie)).forEach(x => {
                    c.set.cookie[x] = {value : '',maxAge: 0,expires: new Date(0)}
    })\n`

at line 464. Then, add the code before
return mapResponse( ....

so that it becomes
fnLiteral += removeCookie + `return mapResponse ....

You can test it by my fork until it gets merged.


Accept AST where field arguments are not given

Hey folks, long time no PR!
So I've spent the last week or so working with a tool called codegen. It parses your code for graphql queries, and bakes them into a typescript file as ASTs. There seems to be a quirk (I'm still debugging) in that if you have a schema with a field that has optional arguments, then there is no "arguments" field in the generated AST.
For example, imagine that we have a schema with optional arguments on collectionItems, and want to query it like this:
  query noArgs($skuId: ID) {
    sku(id: $skuId) {
      collectionItems {
        id
      }
    }
  }

Compare the AST generated by graphql-php:...

... to the one generated by codegen:
// AST generated by codegen
export const NoArgsDocument = {
  kind: "Document",
  definitions: [
    {
      kind: "OperationDefinition",
      operation: "query",
      name: { kind: "Name", value: "noArgs" },
      variableDefinitions: [
        {
          kind: "VariableDefinition",
          variable: {
            kind: "Variable",
            name: { kind: "Name", value: "skuId" },
          },
          type: { kind: "NamedType", name: { kind: "Name", value: "ID" } },
        },
      ],
      selectionSet: {
        kind: "SelectionSet",
        selections: [
          {
            kind: "Field",
            name: { kind: "Name", value: "sku" },
            arguments: [
              {
                kind: "Argument",
                name: { kind: "Name", value: "id" },
                value: {
                  kind: "Variable",
                  name: { kind: "Name", value: "skuId" },
                },
              },
            ],
            selectionSet: {
              kind: "SelectionSet",
              selections: [
                {
                  kind: "Field",
                  name: { kind: "Name", value: "collectionItems" },
                  // <--- no `arguments` property!
                  selectionSet: {
                    kind: "SelectionSet",
                    selections: [
                      { kind: "Field", name: { kind: "Name", value: "id" } },
                    ],
                  },
                },
              ],
            },
          },
        ],
      },
    },
  ],
} as unknown as DocumentNode<NoArgsQuery, NoArgsQueryVariables>;

See the difference? graphql-php inserts an arguments property on every field, whereas codegen only adds it if an argument is explicitly passed to the field in the query. The result is a runtime exception in Values.php:197.
I have no idea which approach is correct, but when I investigated the equivalent file in the upstream reference library, I found that they do a coalesce similar to what I'm proposing here, so hopefully that will simplify things:
https://github.com/graphql/graphql-js/blob/main/src/execution/values.ts#L161
Please let me know what you think.

Thanks, makes sense to me.

Great, thanks for the quick review. 👍


sm3: fix function names after the big ossl_ prefix addition.

[ ] documentation is added or updated
[x] tests are added or updated

FIPS checksum test failure is not relevant.

Merged.


Ignition segmentation fault when loading plugin in ROS 2 rolling

Hi, I'm loading differential drive and joints control plugins in a Gazebo Ignition simulation.
I'm using ROS 2 Rolling with this repo installed from debian packages.
Gazebo ignition crashes during startup with the following backtrace
[ign gazebo-1] #31   Object "/lib/x86_64-linux-gnu/libruby-3.0.so.3.0", at 0x7ff8514a0317, in
[ign gazebo-1] #30   Object "/lib/x86_64-linux-gnu/libruby-3.0.so.3.0", at 0x7ff85163530c, in rb_vm_exec
[ign gazebo-1] #29   Object "/lib/x86_64-linux-gnu/libruby-3.0.so.3.0", at 0x7ff85162fc96, in
[ign gazebo-1] #28   Object "/lib/x86_64-linux-gnu/libruby-3.0.so.3.0", at 0x7ff85162cfc5, in
[ign gazebo-1] #27   Object "/lib/x86_64-linux-gnu/libruby-3.0.so.3.0", at 0x7ff85162ac34, in
[ign gazebo-1] #26   Object "/lib/x86_64-linux-gnu/libruby-3.0.so.3.0", at 0x7ff851576a1e, in
[ign gazebo-1] #25   Object "/lib/x86_64-linux-gnu/libruby-3.0.so.3.0", at 0x7ff8514a19ac, in rb_protect
[ign gazebo-1] #24   Object "/lib/x86_64-linux-gnu/libruby-3.0.so.3.0", at 0x7ff851639c61, in rb_yield
[ign gazebo-1] #23   Object "/lib/x86_64-linux-gnu/libruby-3.0.so.3.0", at 0x7ff85163530c, in rb_vm_exec
[ign gazebo-1] #22   Object "/lib/x86_64-linux-gnu/libruby-3.0.so.3.0", at 0x7ff85162fc96, in
[ign gazebo-1] #21   Object "/lib/x86_64-linux-gnu/libruby-3.0.so.3.0", at 0x7ff85162cfc5, in
[ign gazebo-1] #20   Object "/lib/x86_64-linux-gnu/libruby-3.0.so.3.0", at 0x7ff85162ac34, in
[ign gazebo-1] #19   Object "/usr/lib/x86_64-linux-gnu/ruby/3.0.0/fiddle.so", at 0x7ff84d9ee44b, in
[ign gazebo-1] #18   Object "/lib/x86_64-linux-gnu/libruby-3.0.so.3.0", at 0x7ff8515f8088, in rb_nogvl
[ign gazebo-1] #17   Object "/usr/lib/x86_64-linux-gnu/ruby/3.0.0/fiddle.so", at 0x7ff84d9edd6b, in
[ign gazebo-1] #16   Object "/lib/x86_64-linux-gnu/libffi.so.8", at 0x7ff84d998492, in
[ign gazebo-1] #15   Object "/lib/x86_64-linux-gnu/libffi.so.8", at 0x7ff84d99be2d, in
[ign gazebo-1] #14   Object "/usr/lib/x86_64-linux-gnu/libignition-gazebo6-ign.so.6.13.0", at 0x7ff84cefda53, in runServer
[ign gazebo-1] #13   Object "/lib/x86_64-linux-gnu/libignition-gazebo6.so.6", at 0x7ff84cbca635, in
[ign gazebo-1] #12   Object "/lib/x86_64-linux-gnu/libignition-gazebo6.so.6", at 0x7ff84cbd891a, in ignition::gazebo::v6::SimulationRunner::Run(unsigned long)
[ign gazebo-1] #11   Object "/lib/x86_64-linux-gnu/libignition-gazebo6.so.6", at 0x7ff84cbd7fdd, in ignition::gazebo::v6::SimulationRunner::Step(ignition::gazebo::v6::UpdateInfo const&)
[ign gazebo-1] #10   Object "/lib/x86_64-linux-gnu/libignition-gazebo6.so.6", at 0x7ff84cbd3ef1, in ignition::gazebo::v6::SimulationRunner::UpdateSystems()
[ign gazebo-1] #9    Object "/usr/lib/x86_64-linux-gnu/ign-gazebo-6/plugins/libignition-gazebo-user-commands-system.so", at 0x7ff820dade80, in ignition::gazebo::v6::systems::UserCommands::PreUpdate(ignition::gazebo::v6::UpdateInfo const&, ignition::gazebo::v6::EntityComponentManager&)
[ign gazebo-1] #8    Object "/usr/lib/x86_64-linux-gnu/ign-gazebo-6/plugins/libignition-gazebo-user-commands-system.so", at 0x7ff820db1a79, in ignition::gazebo::v6::systems::CreateCommand::Execute()
[ign gazebo-1] #7    Object "/lib/x86_64-linux-gnu/libignition-gazebo6.so.6", at 0x7ff84cbac4cf, in ignition::gazebo::v6::SdfEntityCreator::CreateEntities(sdf::v12::Model const*)
[ign gazebo-1] #6    Object "/lib/x86_64-linux-gnu/libignition-gazebo6.so.6", at 0x7ff84cb89e43, in
[ign gazebo-1] #5    Object "/lib/x86_64-linux-gnu/libignition-gazebo6.so.6", at 0x7ff84cbdba38, in ignition::gazebo::v6::SimulationRunner::LoadPlugins(unsigned long, std::vector<sdf::v12::Plugin, std::allocator<sdf::v12::Plugin> > const&)
[ign gazebo-1] #4    Object "/lib/x86_64-linux-gnu/libignition-gazebo6.so.6", at 0x7ff84cbe8828, in ignition::gazebo::v6::SystemManager::LoadPlugin(unsigned long, sdf::v12::Plugin const&)
[ign gazebo-1] #3    Object "/lib/x86_64-linux-gnu/libignition-gazebo6.so.6", at 0x7ff84cbe83fa, in ignition::gazebo::v6::SystemManager::AddSystem(ignition::plugin::TemplatePluginPtr<ignition::plugin::SpecializedPlugin<ignition::gazebo::v6::System, ignition::gazebo::v6::ISystemConfigure, ignition::gazebo::v6::ISystemPreUpdate, ignition::gazebo::v6::ISystemUpdate, ignition::gazebo::v6::ISystemPostUpdate> > const&, unsigned long, std::shared_ptr<sdf::v12::Element const>)
[ign gazebo-1] #2    Object "/lib/x86_64-linux-gnu/libignition-gazebo6.so.6", at 0x7ff84cbe7f68, in ignition::gazebo::v6::SystemManager::AddSystemImpl(ignition::gazebo::v6::SystemInternal, std::shared_ptr<sdf::v12::Element const>)
[ign gazebo-1] #1    Object "/opt/ros/rolling/lib/libign_ros2_control-system.so", at 0x7ff8204afc5a, in ign_ros2_control::IgnitionROS2ControlPlugin::Configure(unsigned long const&, std::shared_ptr<sdf::v12::Element const> const&, ignition::gazebo::v6::EntityComponentManager&, ignition::gazebo::v6::EventManager&)
[ign gazebo-1] #0    Object "/opt/ros/rolling/lib/libign_hardware_plugins.so", at 0x7ff814e866a3, in ign_ros2_control::IgnitionSystem::initSim(std::shared_ptr<rclcpp::Node>&, std::map<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, unsigned long, std::less<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > >, std::allocator<std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const, unsigned long> > >&, hardware_interface::HardwareInfo const&, ignition::gazebo::v6::EntityComponentManager&, int&)
[ign gazebo-1] Segmentation fault (Address not mapped to object [(nil)])

Note that this problem seems to be fixed if I build from sources the  master branch

checking to see if this is still an issue? I just tested launching the cart examples that come with ros2 rolling's ign_ros2_control_demos package (0.6.1jammy.20230207) and things seem to be working.

@alsora any update?

Hi, sorry I didn't have time to test yet.
Will try to do it next week.
Anyhow, there was no issue using the master branch, so if you released a new rolling package, I would assume that it's fixed now.


Question regarding template assets

Just wanted to know if there any know issues with using this tool with html email templates, when trying to update an existing template?

just one at the moment:

#798

You can check the list itself though - we don't keep hidden secondary list anywhere: https://github.com/Accenture/sfmc-devtools/issues?q=is%3Aissue+is%3Aopen+asset+label%3Abug


feat: add support for database url

Specifying all database parameters takes more effort than just using a plain database connection string, hence this PR aims to provide a way to consume database URL instead of constructing the URL inside the script
Also did some other minor refactors to improve the script.
Thank you for your work

@luong-komorebi thank you for your contribution! 🙏 I will review and test these changes as soon as I can.


Add SSS Base score, remove SS Up

Refactor score naming convention (minor)
Scores look right to me so far.
Hopefully didnt miss anything

Thanks for the PR! Sorry, been pretty busy, will take a look within the next few days

Let me just go ahead and merge, I can fix up anything minor later.


Missing FileStatusIcon image in changelog

https://docs.silverstripe.org/en/4/changelogs/4.6.0/

Pull-request that was supposed to add it in
https://github.com/silverstripe/silverstripe-framework/pull/9522
Something went missing somewhere along the way

This may be a site wide problem https://docs.silverstripe.org/en/4/developer_guides/files/file_management/

Looks like the URL for this image is wrong. Should be https://raw.githubusercontent.com/silverstripe/silverstripe-framework/4/docs/en/04_Changelogs/_images/file-status-icons.png

This has been fixed in linked PR, closing now


bug: Distribute command is not blowing out at the correct location

Overview
I expect that if I provide argument blow_out_destination='source well' to a distribute command, the blow out will be done in the source well, but currently it continues to do it in the trash. API Level is 2.8.
Steps to reproduce
single_300.distribute(
        vol,
        src,
        [well.top(-1) for well in all_wells],
        new_tip="once",
        mix_before=(5, multi_300.max_volume),
        disposal_volume=20,
        blow_out_location="source well"
    )

Current behavior
Produces the following simulated logs:
Distributing 60.0 from A1 of bead-tubes on 7 to A1 of central-plate on 5
	Transferring 60.0 from A1 of bead-tubes on 7 to A1 of central-plate on 5
		Picking up tip from A1 of Opentrons 96 Tip Rack 300 �L on 8
		Mixing 5 times with a volume of 300.0 ul
			Aspirating 300.0 uL from A1 of bead-tubes on 7 at 120.0 uL/sec
			Dispensing 300.0 uL into A1 of bead-tubes on 7 at 120.0 uL/sec
			Aspirating 300.0 uL from A1 of bead-tubes on 7 at 120.0 uL/sec
			Dispensing 300.0 uL into A1 of bead-tubes on 7 at 120.0 uL/sec
			Aspirating 300.0 uL from A1 of bead-tubes on 7 at 120.0 uL/sec
			Dispensing 300.0 uL into A1 of bead-tubes on 7 at 120.0 uL/sec
			Aspirating 300.0 uL from A1 of bead-tubes on 7 at 120.0 uL/sec
			Dispensing 300.0 uL into A1 of bead-tubes on 7 at 120.0 uL/sec
			Aspirating 300.0 uL from A1 of bead-tubes on 7 at 120.0 uL/sec
			Dispensing 300.0 uL into A1 of bead-tubes on 7 at 120.0 uL/sec
		Aspirating 260.0 uL from A1 of bead-tubes on 7 at 120.0 uL/sec
		Dispensing 60.0 uL into A1 of central-plate on 5 at 120.0 uL/sec
		Dispensing 60.0 uL into B1 of central-plate on 5 at 120.0 uL/sec
		Dispensing 60.0 uL into C1 of central-plate on 5 at 120.0 uL/sec
		Dispensing 60.0 uL into D1 of central-plate on 5 at 120.0 uL/sec
		Blowing out at A1 of Opentrons Fixed Trash on 12

Blow out is being done at the trash even though the parameter instructed to do it at the source well.
Expected behavior
I would expect the last line to read Blowing out at A1 of bead-tubes on 7

Hey @danielpgp1012, sorry for taking so long to get back to you on this.
I think this is because one of the parameter names in misspelled. Try blowout_location=... instead of blow_out_location=....
(The API should raise errors for misspelled parameter names but because of a bug, it silently ignores them. That's issue #5106).

I'm marking this issue as closed now since I think that's the solution, but feel free to keep replying here if that turns out to not work.


Tuya devices not showing up in Home App

I have installed the Tuya Platform plugin, configured the IoT Dev platform and scan the QR code to Homekit, but no device is showing up in Home app.
I have double checked that all my devices were listed in the Dev Platform and I can see the bridge added in the Home app under Home settings. However, it is not showing up in Homebridge Log. Is there anything that I have missed out?

Same issue here ... cannot get tuya platform plugin  - on Hoobs (Hoobs certified plugin) to show any devices. There is no error shown.

Same issue

Same issue, can not see any devices. All parameters are properly configured, but I get no accessories on homebridge.
This is part of the log:
[2/13/2022, 12:20:24 AM] Homebridge v1.4.0 (HAP v0.10.0) (TuyaPlatform) is running on port 47848.
TuyaOpenAPI response: {"code":1106,"msg":"permission deny","success":false,"t":1644708025274} path = /v1.0/iot-01/associated-users/actions/authorized-login
TypeError: Cannot destructure property 'access_token' of 'res.result' as it is undefined.
    at TuyaSHOpenAPI._refreshAccessTokenIfNeed (/usr/local/lib/node_modules/homebridge-tuya-platform/lib/tuyashopenapi.js:49:11)
    at processTicksAndRejections (node:internal/process/task_queues:96:5)
    at TuyaSHOpenAPI.request (/usr/local/lib/node_modules/homebridge-tuya-platform/lib/tuyashopenapi.js:145:7)
    at TuyaSHOpenAPI.getDevices (/usr/local/lib/node_modules/homebridge-tuya-platform/lib/tuyashopenapi.js:63:15)
    at TuyaPlatform.initTuyaSDK (/usr/local/lib/node_modules/homebridge-tuya-platform/index.js:90:19)
Attention⚠ ⚠ ⚠ ! You get an error!
Failed to get device information. Please check if the config.json is correct.

Thanks in advance!

@maaper you have "permission deny" check here

I have installed the Tuya Platform plugin, configured the IoT Dev platform and scan the QR code to Homekit, but no device is showing up in Home app.
I have double checked that all my devices were listed in the Dev Platform and I can see the bridge added in the Home app under Home settings. However, it is not showing up in Homebridge Log. Is there anything that I have missed out?

When I configured this plugin through Homebridge and provided "US" as my country the plugin failed.  When I went back and configured my country as "1" it worked as expected.  Maybe this is the same issue for you.

same issue

Same issue. I tried the country code with 34 (Spain). No. problem in Hoobs, but no accessories detracted, neither in hoops or HomeKit

I just attempted to set this up myself and none of my lights are showing up. It even shows in the homebridge logs that the accessories were supposedly added, but they don't appear as accessories. It just keeps saying that every time I restart my homebridge server.

I'm with the same problem, the logs from tuya shows the device, and the changes of the device when I turn the light on/off, but it doesn't show in the home app.

I’ve given up on this plug-in, as clearly the devs have too.

I’ve given up on this plug-in, as clearly the devs have too.

Have you tried another plugin with success?

I have moved away from HB specifically because of the lack of Tuya support. Both the Tuya official and Tuya LAN plugins are terrible. I switched to Home Assistant and use the native HomeKit integration (in HA) to present my devices back to my apple ecosystem. I use this plugin specifically with HA - https://github.com/make-all/tuya-local

Hello
Same issue for me
I tried to use this plugin in Homebridge, but no accessory created.
I check and every information of the device is visible in the log, I can see :
Adding: Temperature Humidity Sensor (wsdcg / xxxxxxxxxxxxxx)
Adding: Multi-mode Gateway (wg2 / xxxxxxxxxxxxxx)

@onichan88 please, can you elaborate more on this? I think this is my issue. Where did you add the category details? thanks!

The main problem is that your device category maybe is not implemented in the code, or is newer and they have to add the accessory to the code. I have a ceiling fan with light, with device category 'fsd' and I had to add it by my own. Is like a 'fs' (ceiling fan without light, already coded) but with minor changes, but if you don't make that changes, it will not show in accessories nor homekit.

Hi @calamarzo in the main file, I added the "fsd" type, and in the file of ceiling fan I made some minor changes. I propose some changes to this github, still waiting acceptance. If you want to try, you cam use my github fork of this github. I also forked another github to use the ceiling fan locally and it worked!


Add wood walls and 8x2 ramp .glb files

I just add some wodden walls (holes, gate, wall conveyers) and the 8x2 ramp
Those are good approximations.

Very cool!
Which program did you use to model these? There seem to be a few unnecessary vertices here and there and the geometry sometimes seems to be disconnected.

If you are using Blender 2.8 I set the format to "glTF Binary (.glb)" and unchecked every checkbox except for Meshes->Normals.

I used Blender 2.8 bolean difference to punch a hole in these walls. I'm not very good at it and just figure out how to edit edges and vertices (check Build_Wall_Conveyor_8x4_04_C.glb)
About the UV and normals ... oups I did export them.

Thank you for your work!


Simple Fullcount game UX/UI draft (MVP)

design is here starting from the all sessions page

draft is ready and reviewed. will continue working in another issue.


ERROR [BlockService] daemon process blocks error, current transaction is aborted, commands ignored until end of transaction block

[Nest] 29  - 09/13/2024, 8:42:33 AM   ERROR [BlockService] daemon process blocks error, current transaction is aborted, commands ignored until end of transaction block
[Nest] 29  - 09/13/2024, 8:42:33 AM   ERROR [BlockService] daemon process blocks error, current transaction is aborted, commands ignored until end of transaction block
[Nest] 29  - 09/13/2024, 8:42:33 AM   ERROR [BlockService] daemon process blocks error, current transaction is aborted, commands ignored until end of transaction block
[Nest] 29  - 09/13/2024, 8:42:33 AM   ERROR [BlockService] daemon process blocks error, current transaction is aborted, commands ignored until end of transaction block
[Nest] 29  - 09/13/2024, 8:42:33 AM   ERROR [BlockService] daemon process blocks error, current transaction is aborted, commands ignored until end of transaction block
[Nest] 29  - 09/13/2024, 8:42:33 AM   ERROR [BlockService] daemon process blocks error, current transaction is aborted, commands ignored until end of transaction block
[Nest] 29  - 09/13/2024, 8:42:33 AM   ERROR [BlockService] daemon process blocks error, current transaction is aborted, commands ignored until end of transaction block
[Nest] 29  - 09/13/2024, 8:42:33 AM   ERROR [BlockService] daemon process blocks error, current transaction is aborted, commands ignored until end of transaction block
[Nest] 29  - 09/13/2024, 8:42:33 AM   ERROR [BlockService] daemon process blocks error, current transaction is aborted, commands ignored until end of transaction block
[Nest] 29  - 09/13/2024, 8:42:33 AM   ERROR [BlockService] daemon process blocks error, current transaction is aborted, commands ignored until end of transaction block```

tracker docker log show error

same

Wait node synced

Wait node synced

what`s that mean ?  It's been a long time, still that issue

And I find all postgresql tables be deleted, Is that normal? @opcatbugcloser

https://github.com/CATProtocol/cat-token-box/issues/134


Key-management features for validators

A lot of validators have different policies around how they store keys and sign messages. We could move some functionality out of the client.
Stash / Controller Key Management
We should have an HTML file or docker container with Polkadot JS that is "blessed" by Parity or W3F. This could be, for example, a tweet with the hash of this container. This would allow key generation and signing on an air-gapped or live-booted machine.
Session Key Management
Validators have different risk profiles. For example, some worry about availability and always want to be online. Others are more risk-averse and would rather be reported offline occasionally than equivocate. The validator's business logic should be able to handle this outside the client.
When a client needs to sign something, it should be able to make a call to another machine with the payload to sign. Then, that machine can implement whatever signing logic and key management it wants.
For example, the following setup should be possible. The validators would only send payloads that need to be signed. The signing machine could implement whatever logic or setup the validator prefers. It could be a dumb HSM that just acts as a signing oracle or MPC key storage and could also implement more complex logic (like not signing two blocks of the same height).

cc: @folsen

I agree about air gaped stash and controller key management.  We support Ed25519 keys for these to simplify adding support to Trezor, etc.

Validators have different risk profiles. For example, some worry about availability and always want to be online.

I disagree.  I think all cosmos slashings thus far come from their "session" private keys existing in more than one place.

The validator's business logic should be able to handle [keys] outside the client.

I disagree.  As much as possible, we should prevent validators' session private keys from ever existing outside the keystore.  https://github.com/paritytech/substrate/issues/3324#issuecomment-520066994
In particular, we eventually want SGX builds in which the enclave cannot import or export session private keys and the enclave signs any session public key for the session private keys in generates, so that any equivocations indicate an exploit of either substrate or SGX.
We sadly cannot absolutely prevent session secret keys existing elsewhere because networks launch in various states, but any features for importing or exporting secret key should be marked as dangerous.

When a client needs to sign something, it should be able to make a call to another machine with the payload to sign.

Yes, except any machine that acts as a dumb signing oracle might be better off running critical portions of substrate, like babe, grandpa, etc.  We can prevent many equivocations with slightly smarter signing oracles, but not all grandpa ones, so you're asking partially about running substrate piecemeal.  I'd allocate more resources to smarter sentry nodes that help with availability or whatever, but yes  this also makes sense.

I think all cosmos slashings thus far come from their "session" private keys existing in more than one place.

Well, in this proposed setup, the private keys do only exist in one place.

Right, we need an RPC call for import of keys, but their documentation should communicate our wish that keys only exist in one place with some warning that you'll get yourself slashed otherwise.
As I said in https://github.com/paritytech/substrate/issues/3324#issuecomment-520066994 the default workflow should be

an operator first sends an RPC request to generate a session key, or maybe a one part of a session key,
substrate creates the new key, stores the session key pair into the keystore, and return only the public keys to the operator, and
the operator signs the full session public key with their controller key and returns this session certificate via the RPC.

Any external signer programs should work roughly similarly

Closing in favor of https://github.com/paritytech/substrate/issues/4689


Adds support for MS Teams natively using webhooks

MS Teams is now natively integrated with Kubewatch. The configuration
can be provided for posting on to the MS Teams incoming webhook
connector.
The implementation is inspired from the MS Teams and Prometheus
alerts integration by https://github.com/bzon/prometheus-msteams
Fixes #134

Any reason this cant go on?

hi all. just noticed this usefull PR was never merged. Is there any chance some of you guys merge this ?
cc @tylerauerbeck (?)

@jbianquetti-nami @tylerauerbeck @aruiz14 @mkmik Please have a look at this PR, we would love MS Teams integration!

if @vaamarnath fixes the conflict I'll take a look at this. Thanks for the pointer.

I will resolve the conflicts and update the PR soon. Thanks for your patience!

@jbianquetti-nami PTAL. I have resolved the conflicts. Thanks!

Thanks for you review @jbianquetti-nami.
Please merge this whenever you got time @jbianquetti-nami @tylerauerbeck @aruiz14 @mkmik.


Reverse First K elements of Queue

Description
Given an integer k and a queue of integers, code will reverse the order of the first k elements of the queue, leaving the other elements in the same relative order.
Domain
Data Structure
Type of Contribution
Addition
Code of Conduct

[X] I follow Contributing Guidelines & Code of conduct of LearnCPP.

/assign

/assign


Upgrade lychee-action with required changes

Recent change to the actions added quotes to arguments, so we need to remove our own.
Replaces https://github.com/signalfx/splunk-otel-collector/pull/1023

Closing the PR because "*.md */**.md" part is being translated to the list of matching file and lychee doesn't pick all the files from the list for some reason. May be will take a look later


careless about function name when emqttd_pubsub handle getstats message.

mnesia:info(topic_subscriber, size)
should be
mnesia:table_info(topic_subscriber, size)}
maybe add erlang dialyzer check will be better.
extremely to see feature: KPI check on runtime
:+1:

BTW: how many nodes do you deploy ?
I saw the mnesia copy to all cluster nodes.....

Fix.  Dialyzer will be used to check in 0.7
emqttd1.x will adopt the architecture that copy Topic Tree in all clustered nodes.
2.x will slice and distribute subtree.


[DURACOM-153] fix validation to use the retrieved zip file on saf import

References

Fixes #8893
Blocks https://github.com/DSpace/dspace-angular/issues/1913

Description
I fixed the validation of the zip file to retrieve the zip correctly (attached file or remote URL).
Instructions for Reviewers
The validation was not working properly because each time it tried to retrieve the bitstream from an attached file. So it was not working in the case of a remote URL.
I fixed the code to correctly retrieve the zip file when we have to validate it.
Include guidance for how to test or review your PR.
Steps to reproduce the behavior:

Login as an Admin
Go to "Processes"
Create a new process "import"
Add the --add parameter
Add the --url parameter: https://github.com/DSpace-Labs/AIP-Files/releases/download/demo-entities-data/SAF-Import-Entities.zip
Add the --collection parameter specifying the UUID of a collection
Click "Save"

Checklist
This checklist provides a reminder of what we are going to look for when reviewing your PR. You need not complete this checklist prior to creating your PR (draft PRs are always welcome). If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!

[x] My PR is small in size (e.g. less than 1,000 lines of code, not including comments & integration tests). Exceptions may be made if previously agreed upon.
[x] My PR passes Checkstyle validation based on the Code Style Guide.
[x] My PR includes Javadoc for all new (or modified) public methods and classes. It also includes Javadoc for large or complex private methods.
[x] My PR passes all tests and includes new/updated Unit or Integration Tests based on the Code Testing Guide.
[ ] If my PR includes new libraries/dependencies (in any pom.xml), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
[ ] If my PR modifies REST API endpoints, I've opened a separate REST Contract PR related to this change.
[ ] If my PR includes new configurations, I've provided basic technical documentation in the PR itself.
[ ] If my PR fixes an issue ticket, I've linked them together.

Thank you @francescopioscognamiglio for finding time to quickly fix this! I'll get this tested today.


Event not being fired?

Hi, after showing the modal like this:
const modal = new Modal() // We create a Modal
.setCustomId('reminderModal')
.setTitle('What should I remind you about?')
.addComponents([
    new TextInputComponent() // We create a Text Input Component
        .setCustomId('reminderText')
        .setLabel('What to remind you about')
        .setStyle('LONG')
        .setMinLength(1)
        .setMaxLength(4000)
        .setPlaceholder('Call bob and talk about planning the event')
        .setRequired(true)
]);

showModal(modal, {
  client: client,
  interaction: interaction
})

The event doesn't seem to fire when the submit button is clicked, I have tried both in my event handler and in my index file, the event doesn't fire. Any ideas?

@OssieFromDK Did you manage to fix this issue?

@OssieFromDK Did you manage to fix this issue?

Yes, I had not initiliazed in the index :)


chromium is commented out in supportedDrivers

chromium is commented out in supportedDrivers array. Is this a bug or intentional ?
Thanks for your time.

That's intentional, as I plan on finishing Firefox first, before adding chromium support

Thanks !


Feature/performance regression testing

PR Type

Feature
Tests

Description

Introduced function speed_comparison_test, main use is as a developer aid to check that the effect on speed of code changes.
How Has This Been Tested?

Test to sense check the speed_comparison_test.
Adds a test_speed to test_solvers.py which runs the speed_comparison_test on each implemented solver and produces a dictionary of formatted results for inspection. Needs code to store it.
Does this PR introduce a breaking change?

(Write your answer here.)
Screenshots

(Write your answer here.)
Checklist before requesting a review

[x] I have made sure that my PR is not a duplicate.
[x] My code follows the style guidelines of this project.
[x] I have commented my code, particularly in hard-to-understand areas.
[x] I have performed a self-review of my code.
[x] I have made corresponding changes to the documentation.
[x] My changes generate no new warnings.
[x] I have added tests that prove my fix is effective or that my feature works.
[x] New and existing unit tests pass locally with my changes.
[x] Any dependent changes have been merged and published in downstream modules.

@db091756 There are some pre-commit failures. Merging main will deal with some of the doc build failures.


Cannot find name mapboxgl

Version: 0.40.1
Angular: 1.5.9
Installed both the directive and mapbox-gl from npm.  Added the .run(...) with access token to the end of the app.module('app',['mapboxgl-directive']) command.  Added the HTML to my controller files.  The error is being produced from the access token setting in the app.module().run() block of code as per the examples.  I have tons of other controls installed but this is the first that did not work.
angular.module('app', [             'agGrid',             'ui.router',             'ui.bootstrap',             'mapboxgl-directive'         ]).run([function () {             mapboxgl.accessToken = 'pk.eyJ1IjoibmFpbWlrYW4iLCJhIjoiY2lraXJkOXFjMDA0OXdhbTYzNTE0b2NtbiJ9.O64XgZQHNHcV2gwNLN2a0Q';         }])

Hi @ddelella!
Can you provide me an example? Thank you!

Same problem
angular 1.5.9
angular-mapboxgl-directive 0.41.0
mapbox-gl 0.41.0
@ddelella did you solve this?


[Feature] add build for bionic, focal, kinetic

Add other ubuntu-based builds

Available in release 2022-10-22.1


Version 49

This includes version 48

Use  instead of

HTTP:

Add HEAD request example

API Changes:

Refactor method and verb
Canonicalize string_view parameter types
Tidy up empty_body writer error
Refactor header status, reason, and target

Documentation preview:
http://vinniefalco.github.io/stage/beast/v49

Thanks


Converting to ONNX still depends on PyTorch

Is it possible to export to ONNX and run inference without depending on PyTorch?

Thank you for pointing it out. You need to change a processor to rely on NumPy, plus rewrite a bit of conversion script to use ONNX instead of PyTorch. We will do it shortly, but any contribution from your side that can accelerate it is welcome.

Do you know of any way of exporting the tokenizer into onnx as well, because right now it seems it is using torch as well through transformers. i.e. it's loaded using AutoTokenizer from transformers which relies on torch


more progress moving urls over

This pull request primarily focuses on updating URLs and repository references across multiple files to reflect a change from studiocms.xyz to studiocms.dev and from astrolicious to withstudiocms. The changes are consistent across different packages and configurations.
URL and Repository Updates:

packages/studiocms/README.md: Updated URLs and repository references to reflect the new domain and organization.
packages/studiocms/package.json: Changed the author URL, repository URL, and homepage to use studiocms.dev and withstudiocms. [1] [2]
Other package.json files: Similar updates were made in packages/studiocms_assets, packages/studiocms_auth, packages/studiocms_betaresources, packages/studiocms_blog, packages/studiocms_core, packages/studiocms_dashboard, packages/studiocms_devapps, packages/studiocms_frontend, packages/studiocms_imagehandler, packages/studiocms_renderers, and packages/studiocms_robotstxt to update author URLs, repository URLs, and homepages. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13] [14] [15] [16] [17] [18] [19] [20] [21] [22]
packages/studiocms_ui/README.md and package.json: Updated test URL and repository references. [1] [2] [3]

Configuration Updates:

playgrounds/node/astro.config.mts: Updated site URL, Sentry DSN, and project name.
playgrounds/node/sentry.client.config.js: Updated Sentry DSN.
playgrounds/node/studiocms.config.mjs: Commented out the htmlDefaultHead configuration.
playgrounds/ui/astro.config.mts: Updated site URL, Sentry DSN, and project name.

Thank you for submitting your Pull Request, the following links will become available for preview shortly:

StudioCMS Documentation

StudioCMS Demo (node-playground) (Also deployed with package changes)

StudioCMS Ui Demo (ui-playground)


Publish enterprise-operations

to our internal repository to simplify the development of Build Scans.

Your PR is queued. See the queue page for details.

I've triggered a build for you.


[#172] Add Semigroup and Monoid instances to Validation

Resolves #172.

[x] Removes liftA2 custom definition.
[x] Adds Semigroup and Monoid instances to Validation type.
[ ] Improves documentation for Validation module with use cases.

Checklist:
HLint

[ ] I've changed the exposed interface (add new reexports, remove reexports, rename reexported things, etc.).

[ ] I've updated hlint.dhall accordingly to my changes (add new rules for the new imports, remove old ones, when they are outdated, etc.).
[ ] I've generated the new .hlint.yaml file (see this instructions).

General

[x] I've updated the CHANGELOG with the short description of my latest changes.
[x] All new and existing tests pass.
[x] I keep the code style used in the files I've changed (see style-guide for more details).
[x] I've used the stylish-haskell file.
[x] My change requires the documentation updates.

[x] I've updated the documentation accordingly.

[ ] I've added the [ci skip] text to the docs-only related commit's name.

Yes, that make sense. I'll work on that. Thanks for your explanation!


Adding flag for no default fields on report

Per a user request adding a flag --no_default_fields to the c7n-org reports function for cleaner output.

I have tested and VOK that this code change works, pretty simple addition anyways :)

@kapilt  Ready for your review and blessing.  Thanks!

thanks for the pr, one minor re exposed cli flag style, else looks good.


Uncaught Error: The specified module could not be found./?~\AppData\Local\atom\app-1.21.0-bet...

[Enter steps to reproduce:]

...
...

Atom: 1.21.0-beta1 x64
Electron: 1.6.9
OS: Microsoft Windows 10 Pro
Thrown From: Atom Core
Stack Trace
Uncaught Error: The specified module could not be found.
\?\C:\Users\frellsen01\AppData\Local\atom\app-1.21.0-beta1\resources\app.asar.unpacked\node_modules\keyboard-layout\build\Release\keyboard-layout-manager.node
At ELECTRON_ASAR.js:173

Error: The specified module could not be found.
\\?\C:\Users\frellsen01\AppData\Local\atom\app-1.21.0-beta1\resources\app.asar.unpacked\node_modules\keyboard-layout\build\Release\keyboard-layout-manager.node
    at process.module.(anonymous function) [as dlopen] (ELECTRON_ASAR.js:173:20)
    at Object.Module._extensions..node (module.js:598:18)
    at Object.module.(anonymous function) [as .node] (ELECTRON_ASAR.js:187:18)
    at Module.load (module.js:488:32)
    at tryModuleLoad (module.js:447:12)
    at Function.Module._load (module.js:439:3)
    at Module.require (/app.asar/static/index.js:47:45)
    at require (internal/module.js:20:19)
    at customRequire (~/AppData/Local/atom/app-1.21.0-beta1/resources/app/static/<embedded>:96:26)
    at get_KeyboardLayoutManager (~/AppData/Local/atom/app-1.21.0-beta1/resources/app/node_modules/keyboard-layout/lib/keyboard-layout.js:7:65)
    at get_manager (~/AppData/Local/atom/app-1.21.0-beta1/resources/app/node_modules/keyboard-layout/lib/keyboard-layout.js:16:42)
    at getCurrentKeyboardLayout (~/AppData/Local/atom/app-1.21.0-beta1/resources/app/node_modules/keyboard-layout/lib/keyboard-layout.js:32:17)
    at Object.getCurrentKeymap (~/AppData/Local/atom/app-1.21.0-beta1/resources/app/node_modules/keyboard-layout/lib/keyboard-layout.js:22:31)
    at exports.keystrokeForKeyboardEvent (~/AppData/Local/atom/app-1.21.0-beta1/resources/app/node_modules/atom-keymap/lib/helpers.js:244:66)
    at KeymapManager.module.exports.KeymapManager.keystrokeForKeyboardEvent (~/AppData/Local/atom/app-1.21.0-beta1/resources/app/node_modules/atom-keymap/lib/keymap-manager.js:467:20)
    at KeymapManager.module.exports.KeymapManager.handleKeyboardEvent (~/AppData/Local/atom/app-1.21.0-beta1/resources/app/node_modules/atom-keymap/lib/keymap-manager.js:347:30)
    at WindowEventHandler.module.exports.WindowEventHandler.handleDocumentKeyEvent (~/AppData/Local/atom/app-1.21.0-beta1/resources/app/src/window-event-handler.js:100:42)
    at HTMLDocument.<anonymous> (~/AppData/Local/atom/app-1.21.0-beta1/resources/app/src/window-event-handler.js:3:65)

Commands

Non-Core Packages
language-cisco 1.4.0
language-tcl 0.1.2
language-tcltk 0.1.5
minimap 4.29.7
split-diff 1.5.1
text-pastry 0.6.1

Based on recent reports (e.g. https://github.com/atom/atom/issues/14461#issuecomment-331346393), this could be an issue with your anti-virus software.  If you don't have any anti-virus software running, can you try re-installing and see if that helps?

Reinstall helped. The installer Antivirus is Cylance.
/Kim
Den 22. sep. 2017 kl. 19.30 skrev Robert Sese<EMAIL_ADDRESS>Based on recent reports (e.g. #14461 (comment)
https://github.com/atom/atom/issues/14461#issuecomment-331346393), this
could be an issue with your anti-virus software. If you don't have any
anti-virus software running, can you try re-installing and see if that
helps?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/atom/atom/issues/15720#issuecomment-331510333, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AP674-b7yHn-0Xg4S93UCFVwEyHSsja8ks5sk-6dgaJpZM4PgW1B
.


[WIP - review required] ForceMatrix methods optimization

I made a very simple benchmark to time the methods called during prediction and noticed that build_force_matrix is suspiciously slow and scales very poorly. At plain sight it looks like O(N²), which doesn't make a lot of sense.

The main issue is that conversions from numpy to sympy are not performant at all, nor is sympy.Matrix mutation. Furthermore, I don't really see any upside for using sympy matrices in this part of the process which is mostly number-crunching, so I swapped some parts by equivalent numpy code to compare performance. I tried not to change the signature of any of the methods that I understand to be public.
Change log

First commit: speed up A matrix creation while still building the sympy.Matrix object at the end (which saves some time but still suffers from the terrible data-structure conversion performance).

Results:

Second commit: swap most operations with sympy.Matrix objects by operations with 2D numpy arrays.

Results:

Warning: I tested this with different examples using default parameters and didn't notice any changes in results, but I cannot confirm that everything is the same because I didn't go through all branches of the code with changes. This should be a good starting point if you want to optimize the solver, but please verify the logic and run as many tests as possible to make sure that I didn't break anything 💀.

The tests cover big parts of the logic. Do you know why it fails for py3.10 and py3.11 but seems to be running in 3.8 and 3.9? It probably has something to do with the dependencies of numpy and opencv. I will open a different PR soon to change the opencv dependencies, to headless.

The tests cover big parts of the logic. Do you know why it fails for py3.10 and py3.11 but seems to be running in 3.8 and 3.9? It probably has something to do with the dependencies of Numpy and OpenCV. I will open a different PR soon to change the OpenCV dependencies to headless, as no display is needed.

No idea, have you tried opening a PR that changes something trivial, just to see if the main branch source code fails the checks as well? I've been working in 3.10

Moreover, the pressure calculations follow a similar method in the pmatrix.py and use the general_matrix implementation to solve them. We should also tackle those two, probably in a different PR.

Sure, if I were you, I would consider if this really needs anything else than numpy for the algebra. Unless numpy is lacking a feature that you actually need, I would aim to refactor the code that uses other engines.

The tests cover big parts of the logic. Do you know why it fails for py3.10 and py3.11 but seems to be running in 3.8 and 3.9? It probably has something to do with the dependencies of Numpy and OpenCV. I will open a different PR soon to change the OpenCV dependencies to headless, as no display is needed.

No idea, have you tried opening a PR that changes something trivial, just to see if the main branch source code fails the checks as well? I've been working in 3.10

PR #22 should have fixed the import errors, and the tests should re-run the checks when you rebase.


Where selection for Netcdf raster slower than for in Memory raster with same dimensions

When I am doing a Where Selector it seems to be quite slow compared to other selection methods.
I expect that the Where selector is slower because it has to check the function for every element of the axis.
But in my case the selection takes 2 seconds while the selection function takes 30 nanoseconds and when I multiply it with the number of elements I get 10 microseconds.
This selection is much faster when I do it with random data that I generate compared to the selection on a netcdf based Raster.
When I construct a Raster with the same dimensions as ras but a random array the timing is similar to the fully random based Raster.
# Selection on random data
julia> r = Raster(rand(800,800, 289), (X(1:800), Y(1:800), Ti(DateTime(1995):Month(1):DateTime(2019))))
800×800×289 Raster{Float64,3} with dimensions:
  X Sampled{Int64} 1:800 ForwardOrdered Regular Points,
  Y Sampled{Int64} 1:800 ForwardOrdered Regular Points,
  Ti Sampled{DateTime} DateTime("1995-01-01T00:00:00"):Month(1):DateTime("2019-01-01T00:00:00") ForwardOrdered Regular Points
extent: Extent(X = (1, 800), Y = (1, 800), Ti = (DateTime("1995-01-01T00:00:00"), DateTime("2019-01-01T00:00:00")))
missingval: missing
parent:

julia> @btime r[Ti=Where(x->year(x)==1995)]
  29.809 ms (19 allocations: 58.60 MiB)
800×800×12 Raster{Float64,3} with dimensions:
  X Sampled{Int64} 1:800 ForwardOrdered Regular Points,
  Y Sampled{Int64} 1:800 ForwardOrdered Regular Points,
  Ti Sampled{DateTime} DateTime[1995-01-01T00:00:00, …, 1995-12-01T00:00:00] ForwardOrdered Irregular Points
extent: Extent(X = (1, 800), Y = (1, 800), Ti = (DateTime("1995-01-01T00:00:00"), DateTime("1995-12-01T00:00:00")))
missingval: missing
parent:

# results of a NetCDF backed raster
julia> @btime ras[Ti=Where(x->year(x)==1995)]
  1.994 s (643532 allocations: 240.25 MiB)
848×824×12 Raster{Union{Missing, Float32},3} with dimensions:
  Dim{:rlon} Sampled{Float64} -28.4029998779297:0.0550011811599821:18.18300056457514 ForwardOrdered Regular Points,
  Dim{:rlat} Sampled{Float64} -23.4029998779297:0.0550012159753107:21.863000869751005 ForwardOrdered Regular Points,
  Ti Sampled{DateTime} DateTime[1995-01-16T12:00:00, …, 1995-12-16T12:00:00] ForwardOrdered Irregular Points
extent: Extent(rlon = (-28.4029998779297, 18.18300056457514), rlat = (-23.4029998779297, 21.863000869751005), Ti = (DateTime("1995-01-16T12:00:00"), DateTime("1995-12-16T12:00:00")))
missingval: missing

# Results of a random array with the same dimensions as ras
ulia> ra = Raster(rand(size(ras)...), dims(ras))
848×824×288 Raster{Float64,3} with dimensions:
  Dim{:rlon} Sampled{Float64} -28.4029998779297:0.0550011811599821:18.18300056457514 ForwardOrdered Regular Points,
  Dim{:rlat} Sampled{Float64} -23.4029998779297:0.0550012159753107:21.863000869751005 ForwardOrdered Regular Points,
  Ti Sampled{DateTime} DateTime[1995-01-16T12:00:00, …, 2018-12-16T12:00:00] ForwardOrdered Irregular Points
extent: Extent(rlon = (-28.4029998779297, 18.18300056457514), rlat = (-23.4029998779297, 21.863000869751005), Ti = (DateTime("1995-01-16T12:00:00"), DateTime("2018-12-16T12:00:00")))
missingval: missing

julia> @btime ra[Ti=Where(x->year(x)==1995)]
  32.535 ms (19 allocations: 63.97 MiB)
848×824×12 Raster{Float64,3} with dimensions:
  Dim{:rlon} Sampled{Float64} -28.4029998779297:0.0550011811599821:18.18300056457514 ForwardOrdered Regular Points,
  Dim{:rlat} Sampled{Float64} -23.4029998779297:0.0550012159753107:21.863000869751005 ForwardOrdered Regular Points,
  Ti Sampled{DateTime} DateTime[1995-01-16T12:00:00, …, 1995-12-16T12:00:00] ForwardOrdered Irregular Points
extent: Extent(rlon = (-28.4029998779297, 18.18300056457514), rlat = (-23.4029998779297, 21.863000869751005), Ti = (DateTime("1995-01-16T12:00:00"), DateTime("1995-12-16T12:00:00")))
missingval: missing

[and 11 more slices...]

Is this still true? the files dont seem to be there anymore to test it.

The data was moved. I try to test it this week.

The location of the files have been moved.
The new position should be this:
path = "http://esgf1.dkrz.de/thredds/fileServer/cosmo-rea/reanalysis/EUR-6km/DWD/ECMWF-ERAINT/REA6/r1i1p1f1/COSMO/v1/mon/atmos/tas/v20230918/tas_EUR-6km_ECMWF-ERAINT_REA6_r1i1p1f1_COSMO_v1_mon_199501-199512.nc"

I will try it again in the next days.

I tested it again and these are the new timings:
julia> @btime c[Ti=Where(x->year(x)==1995)]; # YAXArrays with NetCDF backend
  71.301 ms (26373 allocations: 1.98 MiB)

julia> @btime r[Ti=Where(x->year(x)==1995)]; # Rasters with NCDatasets backend
  252.776 ms (6246 allocations: 232.31 MiB)

This might also be some difference between the backends.
This is with these package versions:
(Rasters) pkg> st
Project Rasters v0.11.1
Status `~/.julia/dev/Rasters/Project.toml`
  [79e6a3ab] Adapt v4.0.4
  [3da002f7] ColorTypes v0.11.5
  [1fbeeb36] CommonDataModel v0.3.6
  [187b0558] ConstructionBase v1.5.5
⌃ [0703355e] DimensionalData v0.27.2
⌅ [3c3547ce] DiskArrays v0.3.23
  [411431e0] Extents v0.1.2
  [1a297f60] FillArrays v1.11.0
  [4c728ea3] Flatten v0.4.3
  [68eda718] GeoFormatTypes v0.4.2
  [cf35fbd7] GeoInterface v1.3.4
  [e1d29d7a] Missings v1.2.0
  [30363a11] NetCDF v0.11.8
  [6fe1bfb0] OffsetArrays v1.14.0
  [92933f4c] ProgressMeter v1.10.0
  [3cdcf5f2] RecipesBase v1.3.4
  [189a3867] Reexport v1.2.2
  [efcf1570] Setfield v1.1.1
  [c21b50f5] YAXArrays v0.5.6
  [ade2ca70] Dates
  [a63ad114] Mmap

Ok this not just the time to load the data?
getindex is not lazy in Rasters like in YAXArrays, it moves data to memory. But view is lazy!

Ah yeah right. I forgot that. So this is a useless comparison. I will test the view but most likely this can be closed

It is kind of annoying that the lazy syntax is harder to write in julia generally.


System.ArgumentOutOfRangeException: The added or subtracted value results in an un-representable DateTime.

Describe the bug
OPC Publisher is reporting an exception when trying to publish messages to EdgeHub
[20:28:37 ERR] Exception while sending message to hub. Dropping message... System.ArgumentOutOfRangeException: The added or subtracted value results in an un-representable DateTime. Parameter name: t    at System.DateTime.op_Addition(DateTime d, TimeSpan t)    at OpcPublisher.HubCommunicationBase.MonitoredItemsProcessorAsync(CancellationToken ct) in D:\a\1\s\modules\src\Microsoft.Azure.IIoT.Modules.OpcUa.Publisher\src\HubCommunicationBase.cs:line 1752
This seems to be correlated with the message queue limit being reached?
[20:34:57 INF] The internal monitored item message queue is above its capacity of 250000. We have already lost 63260000 monitored item notifications:(
To Reproduce
Unsure
Expected behavior
A clear and concise description of what you expected to happen.
System Info:

OS: Ubuntu
IoT Edge <IP_ADDRESS>
OPC Publisher 2.5.2

Hi @jmbrunskill
this has been fixed in version 2.5.3. Therefore, I'm closing this issue.
Thanks!
Markus


Add scale parameter to topology graph initialisation

This kind of fixes #425 , where a user my want to use a different scale parameter or function than the default one

WEll, this is #187 so closing...