Avoid allocating space for empty slice initialization

In order to avoid unnecessarily allocating memory in the case where the
empty slice is never appended to, it's better to use the "var name
[]type" form than the "name := []type{}" form.
See:
https://github.com/golang/go/wiki/CodeReviewComments#declaring-empty-slices

lgtm, but I thought the := []type{} form was deliberately being used for readability.

I don't have a strong opinion on the var name []type vs name := []type{} but if we go for the former, there're missing lines:
> git grep -n ":= \[\].*{}" | grep -v Godeps
networking/networking.go:233:	nis := []netinfo.NetInfo{}
pkg/tar/tar.go:48:	dirhdrs := []*tar.Header{}
rkt/help.go:95:	subCommands := []*cobra.Command{}
rkt/image_list.go:202:	sortAciinfoFields := []string{}
rkt/pods.go:886:	hashes := []types.Hash{}
stage1/init/init.go:470:	fps := []networking.ForwardedPort{}
stage1/init/pod.go:315:	saPorts := []types.Port{}
stage1/init/pod.go:450:		appNames := []types.ACName{}
store/aciinfo.go:53:	aciinfos := []*ACIInfo{}
store/aciinfo.go:74:	aciinfos := []*ACIInfo{}
store/aciinfo.go:120:	aciinfos := []*ACIInfo{}
store/aciinfo_test.go:51:	aciinfos := []*ACIInfo{}
store/migrate_test.go:241:	aciinfos := []*ACIInfoV0_2{}
store/migrate_test.go:260:	aciinfos := []*ACIInfoV3{}
store/migrate_test.go:286:	remotes := []*RemoteV0_1{}
store/migrate_test.go:314:	remotes := []*RemoteV2_3{}
store/store.go:261:	aciInfos := []*ACIInfo{}
store/store.go:688:	aciInfos := []*ACIInfo{}

This would be a good start to make some guidelines (or clearly point to https://github.com/golang/go/wiki/CodeReviewComments as chosen one) for the project.
If it's optimization - for now, it's premature or even unnecessary, but if it's there because of clarity/consistency - I'm all for it.

Thanks @iaguis, my regex was a bit naive. I've changed the ones yours found.
@jellonek definitely not for any optimization. Just trying to follow recommended practices. I'd also be for adopting a general coding standards document.

Added to my TODO list, give me a couple of days to figure it out (would be
nice to have a generic coreos/* one)
On Mon, Oct 12, 2015 at 2:20 PM, Chris Kühl<EMAIL_ADDRESS>wrote:

Thanks @iaguis https://github.com/iaguis, my regex was a bit naive.
I've changed the ones yours found.
@jellonek https://github.com/jellonek definitely not for any
optimization. Just trying to follow recommended practices. I'd also be for
adopting a general coding standards document.
—
Reply to this email directly or view it on GitHub
https://github.com/coreos/rkt/pull/1562#issuecomment-147525816.

OK, I'm inclined to roll with this and defer to upstream.
See https://github.com/coreos/rkt/pull/1606/files for adding style guide reference
@blixtra please rebase to fix your commit message and then LGTM, thanks!

+1 for consistency!

LGTM


Add support for nested columns

Fixes #17

It is also important to use a label that is unique for each record type field column
See my PR on how it handle these issues with column names and their labels. https://github.com/apache/incubator-superset/pull/5655

Added the requested changes. I've tested this with Superset and it seems to be working fine. Can anyone please test as well?

@mxmzdlv thanks for this PR, appreciate it. I will test this PR with superset and BQ tables with nested columns on Sunday or early Monday (P.T.), and get back.

It works, I tested with Apache Superset and BQ. 🎉 thank you. @mxmzdlv


Documentation improvement

[See https://github.com/socketstream/socketstream/issues/513 as a precursor to this.]
I've created a feature/doc-updates branch. I think it was @RomanMinkin who did a tremendous effort in going through our docs and trying to get them in a better state. However, after having given them a good look over, I think we've over complicated the task by throwing an angular wrapper around the documentation section—it makes them difficult to maintain.
For example, I went to go work on the documentation this evening and spent way too long trying to figure things out when all I wanted to do was write.
I think we could work on trying to make the process simpler, and I appreciate @thepian's view about getting the community involved to that end. (It's probably a catch 22—need to make it easier first to get people to start helping.)
Here are some starting suggestions.

Lets swap out ngdocs for something that doesn't rely on Angular, and is a little more accessible and established, like JSDocs.
For authored docs, markdown is probably the best bet. There are techniques for converting .md files into HTML, and markdown is the flavor, too, of GitHub. That way we're not repeating our efforts, and the docs can exist in two places. (Good for when servers are down.)
Also, maybe we could all just divvy up some of the missing or incomplete topics and take a stab at authoring single pages—I've said I plan on working on the docs a lot, but the knowledge of how things work is in everyone's minds. If everyone takes a stab at a draft (it can be messy!), I can be editorial and clean and organize things. (I come from a pack of literary wolves and editors, as evidenced by all my verbose GitHub comments.)

Those are some initial thoughts. Please add you own ideas, and I'll work around the communities' needs.

Just to give everyone a quick "for example," I can't find anywhere that gives an installation guide for setting up SocketStream to do development work on the app itself. Fortunately, with a little trial and error I was able to figure it out on my own (npm link!). But there should be a 101 on this. I started writing it. Anyone want to modify it? Did I do it right?
# Developing on SocketStream

Fork SocketStream on Github.

Then install and link the forked SocketStream

	git clone git@github.com:[your-fork]/socketstream.git
	cd socketstream/
	npm link

Generate your app:

	socketstream new -m [app-name]

(Additional app generate options include `-c` if you prefer CoffeeScript, `-j` if you prefer Jade, and `-s` for Stylus or `-l` for Less if you prefer a CSS precompiler.)

Next, run the following commands:

	cd [app-name]
	npm install

And start your app:

	node app.js

[...more to come, details on pull requests, build process, etc., etc...]

I know @kulicuu said once he was going to get me running out the gate, but I finally got around to doing it on my own...all these years... ;)

Could you try to branch of next rather than master, I've put quite a bit of additional documentation in there.
I really do not feel like merging all those comments and converting them to JSDoc.
I expect that 0.4 topics will be complete within the next month, so that would mean that there is a release candidate for it then in the existing NG Docs format.

On NG vs JS docs.
NGDocs don't seem to fit that well with the Socketstream source structure, so the API docs generated are a bit odd, but mostly O.K.
I'm not that sure that JSDocs is an improvement. When I last worked with it (granted quite a long time ago) they generated quite unattractive output with at structure that wasn't terribly powerful. I recall them as a straight imitation of JavaDoc, which was cool when it came out, but hasn't really evolved in terms of usability.
For the examples/tutorials I can imagine we could do better. I assume you are not aiming to use JSDoc for this?

Hey guys, when I was adding ng-docs I also was looking for a better solution, but i did not find anything better at that tome. I was targeting two goals:

Make docs searchable with no back-end required
Internal SecketStream API support, since it's an open source project

So ng-docs to me is more like docs provider than docs generator.
Right now I would take a look at https://stripe.com/docs for 101/Guides and for API make sense to keep ng-docs. Here is a big difference between people who whats to use SS and who wants to contribute.

...forgot to add that I also bright ng-docs for automated change log generation https://github.com/socketstream/socketstream/blob/master/CHANGELOG.md

I just used bourbon.io ; it's quite nice, I wonder what they made it with

@thepian I'll delete the working docs branch and rebranch off of next—I haven't done anything significant yet—but I do plan on working with markdown.
This may be a useful tool for us: https://fiddle.md
We can take up considerations about JSDocs vs ngdocs vs something else at a later date; it's not the most important aspect of documentation, I agree.

updated docs branch: https://github.com/socketstream/socketstream/tree/feature/doc-updates-0.4

Great

Hey—so I set up a workspace on Hackpad for a collaborative place to edit docs-in-the-works.
Naturally, the best place to have the docs is still in .md files under the /docs folder committed in this github repo. But I wanted somewhere where it would be easy to edit stuff a little more on the fly and in a collaborative way. Hackpad is pretty awesome for this kind of stuff (it's better than Google Docs, but that's another topic).
It's private, so if you want an invite, just let me know your email (see mine over here: https://github.com/arxpoetica) and I can add you: https://socketstream.hackpad.com/

Thanks @arxpoetica. Yeah I markdown is still a great way to do docs.
Looking at the thread, I agree with @thepian that getting articles on SocketStream would have a big impact on growing the community. I'd like to assist but time is of short supply for the next 2 months at least (finishing client work and writing book).
Id also like to get the SocketStream Twitter account in more hands - I looked at Buffer to manage this but was wondering if there are any other tools that can do the same thing (teams accessing social media accounts), I also looked at Hootsuite. If anyone sees anything then please let me know.

I think the fundamental strategy should be

Keep a steady stream of improvements to Socketstream (at a manageable pace)
Satisfy one existing fronted dev community at a time

IMO streaming is a niche feature, so pitching to the converted is not the best use of time. Better to show the usefulness to people that are not used to it.
I'd like for instance to show really good support for Angular to that community, and then move on to another community.

http://samwize.com/2014/01/31/the-best-documentation-generator-for-node/


Cannot compare Vector{2,3,4}/Rect2 and Vector{2,3,4}i/Rect2i

Godot version
4.0.1.rc2
System information
Linux (Ubuntu 22.04), Vulkan, Radeon RX Vega 64 (eGPU)
Issue description
It is impossible to compare a Vector2 with it's equivalent Vector2i. Same for Vector3/Vector3i, Vector4/Vector4i and Rect2/Rect2i.

It should be possible to compare equivalent vectors, Vector2.ONE should be equal to Vector2i.ONE and vice-versa.
Steps to reproduce
extends Node

func _ready() -> void:
	# Vector2
	prints(Vector2.ONE == Vector2i.ONE)
	prints(Vector2.ONE != Vector2i.ONE)
	prints(Vector2.ONE > Vector2i.ONE)
	prints(Vector2.ONE >= Vector2i.ONE)
	prints(Vector2.ONE < Vector2i.ONE)
	prints(Vector2.ONE <= Vector2i.ONE)

	prints(Vector2i.ONE == Vector2.ONE)
	prints(Vector2i.ONE != Vector2.ONE)
	prints(Vector2i.ONE > Vector2.ONE)
	prints(Vector2i.ONE >= Vector2.ONE)
	prints(Vector2i.ONE < Vector2.ONE)
	prints(Vector2i.ONE <= Vector2.ONE)

	# Vector3
	prints(Vector3.ONE == Vector3i.ONE)
	prints(Vector3.ONE != Vector3i.ONE)
	prints(Vector3.ONE > Vector3i.ONE)
	prints(Vector3.ONE >= Vector3i.ONE)
	prints(Vector3.ONE < Vector3i.ONE)
	prints(Vector3.ONE <= Vector3i.ONE)

	prints(Vector3i.ONE == Vector3.ONE)
	prints(Vector3i.ONE != Vector3.ONE)
	prints(Vector3i.ONE > Vector3.ONE)
	prints(Vector3i.ONE >= Vector3.ONE)
	prints(Vector3i.ONE < Vector3.ONE)
	prints(Vector3i.ONE <= Vector3.ONE)

	# Vector4
	prints(Vector4.ONE == Vector4i.ONE)
	prints(Vector4.ONE != Vector4i.ONE)
	prints(Vector4.ONE > Vector4i.ONE)
	prints(Vector4.ONE >= Vector4i.ONE)
	prints(Vector4.ONE < Vector4i.ONE)
	prints(Vector4.ONE <= Vector4i.ONE)

	prints(Vector4i.ONE == Vector4.ONE)
	prints(Vector4i.ONE != Vector4.ONE)
	prints(Vector4i.ONE > Vector4.ONE)
	prints(Vector4i.ONE >= Vector4.ONE)
	prints(Vector4i.ONE < Vector4.ONE)
	prints(Vector4i.ONE <= Vector4.ONE)

	# Rect2
	prints(Rect2.ONE == Rect2i.ONE)
	prints(Rect2.ONE != Rect2i.ONE)

	prints(Rect2i.ONE == Rect2.ONE)
	prints(Rect2i.ONE != Rect2.ONE)

Minimal reproduction project
comparison-vector.zip

Note: labeling as bug since int and float can be compared this way.


fix: fix some msg left on buffer

sink start_send just set data to buffer, flush will try to write data to inner io
Remove write buffer on yamux stream, it will cause context confusion, and let the data be copied once more
yamux stream read must break on having read something
yamux control message send by unbound channel
secio after confirming that it can be sent, encrypt the data

codec write buffer left:
https://github.com/nervosnetwork/tentacle/blob/fix-message-delay/tentacle/src/substream.rs#L427
yamux read buffer left:
https://github.com/nervosnetwork/tentacle/blob/fix-message-delay/yamux/src/stream.rs#L302

Add some test cases?

There have been tests, and occasionally failed, but did not pay attention to it, thought it was a problem caused by poor ci machine


Add support for google analytics 4

According to Hugo documentation gtags are supported only with the non async code
https://gohugo.io/templates/internal/#google-analytics
Also another discussion
according to https://discourse.gohugo.io/t/how-to-make-site-updates-to-support-google-analytics-4/38271/2
Analytics will break soon in July 2023 for Google universal Analytics so everyone should migrate to analytics 4
Migrating after this change should be easy as changing the ID to GTAG

Right now my site is working referencing this branch and google analytics data is arriving with the new change just in case.
But it would be nice to be merged with the original code

@fcastello Thank you for the PR. I don't plan on maintaining this theme anymore. I would highly recommend you my newer theme https://github.com/rafed/BlogRa which I plan to maintain for a longer time. It's better and much more versatile.

Thanks @rafed I did see you new theme I will take some time to migrate it to it, but for now I had to make a quick fix. Thanks for merging it


Compare Dates

Hello @simolus3 , can you give me an example of how to compare dates with one of the isSmallerThan or isBiggerThan functions please?
I couldn't find a way to make it work here. =/
Thanks in advance.

Hi, if you want to compare the date to a value, you could use something like
select(todos)..where((entry) => entry.dueDate.isSmallerThanValue(DateTime.now()))

If you want to compare the date to lets say another column, you could use
select(appointments)..where((entry) => entry.startDate.isSmallerThan(entry.endDate))

Does that help?

It helped a lot, I was trying to put DateTime.now () in the isSmallerThan function, but from what I understand this function only compares if it's another date field. I honestly had not noticed the isSmallerThanValue function.
Thank you again.

Another question, how to use OR, AND and IN statements on Where clausule?

You can use the top-level and and or functions to compose boolean expressions. Similarly, there's a top level function isIn which you can use to generate IN clauses. To use LIKE, simply call the like method on a text column.

If not too much trouble can you provide an example of and, or and IN please? Like I had already figured out how it worked. And I thank you in advance.

Sure:
select(todos).where((e) {
  return and(
    e.category.equals(3),
    m.isIn(e.tag, ['Important', 'Work']),
  );
});

This would generate SELECT * FROM todos WHERE (category = 3) AND (tag IN ('Important', 'Work')) (as a prepared statement with variables, of course). or works similar.

Thanks so much, I really didn't realize it was like that.
Now I can make a better progress for my project.
And once again congratulations on Moor and the attention he has given.


Specific the engine pointer when EVP_CipherInit_ex

I found that when I wanted to use an engine by the option-engine XXX , it didn't work. Checking the code, I guess it missed the engine pointer when calling EVP_CipherInit_ex.

Checklist

[x] documentation is added or updated
[x] tests are added or updated

CLA: trivial

CLA: trivial

This needs to be included in the commit message, instead of Github comment.


[#6099] Remove low impact FxCop exclusions - Rule CA1801

Addresses #6099
#minor
Description
This PR removes the exclusions of the FxCop rule CA1801 (Review unused parameters).
Note: we updated obsolete methods and deprecated classes even though they shouldn't be part of the v5 release.
Detailed Changes

Removed cancellationToken parameter in:

FillLuisEventPropertiesAsync method of LuisRecognizer class.
FillQnAEventAsync method of QnAMaker class.
GetPropertyValueAsync, DeletePropertyValueAsync, and SetPropertyValueAsync methods of BotState class.

Removed ChannelId parameter of the MaxActionTitleLength method in Channel class.
Removed description parameter of one of the AssertReply methods in TestFlow class.
Removed exclusions in obsolete methods of AppCredentials class.
Removed multiplier parameter of the WithJitter method in TimeSpanExtensions class.
Removed deprecated parameter addJwtTokenRefresher in ConnectorClientEx class.
Removed customHeaders parameter in deprecated class OAuthClientOld.
Removed customHeaders parameter in FetchParticipantWithHttpMessagesAsync method of TeamsOperations class.
Removed offset parameter in Deserialize method of HeaderSerializer class.
Updated unit tests to the new signature of the methods.

Testing
This image shows the tests passing after the changes.

@ceciliaavila  Can you fix the merge conflicts so we can see the final changes to complete the PR review? Thanks!

@ceciliaavila Can you fix the merge conflicts so we can see the final changes to complete the PR review? Thanks!

Conflicts solved @LeeParrishMSFT. Thanks!


Add > sign to expand suggestions.

@rzhao271 Can > character adds to expand suggestions also? For example MyComponent> and ctrl+space to show suggestions list for <MyComponent></MyComponent>.  I think it's a useful shortcut to have because in self closed element there's a shortcut to expand (https://github.com/microsoft/vscode/issues/120203) and for custom elements there's not.

I'll reopen this issue and hopefully get to it by the next housekeeping iteration. I noticed that if > is added to the suggestion, it could also smooth the suggestions out a bit.


Bluetooth: Host: Add CONFIG_BT_BONDING_REQUIRED flag

Added configuration for accepting pairing requests only if both devices has bonding flag set in order to reject other devices at an early stage, thus leaving more chance for devices expected to bond.
With the CONFIG_BT_BONDING_REQUIRED flag the device only accept pairing requests if it has CONFIG_BT_BONMDABLE set and the device requesting pairing has Bonding_Flags field set to Bonding (0x01) in its AuthReq.
Note: When using bt_set_bondable(false) pairing requests will be
rejected when CONFIG_BT_BONDING_REQUIRED is set.
Signed-off-by: Martin Rieva<EMAIL_ADDRESS>

Just fixed the commit message line length.


update README to include support for 4 button scene keypads

Updating the README per #128.  I only made reference to the remotes that have been verified to work, though my assumption at this point is that -P02 and -P03 scene keypads would also work.
I also updated the description for the -L01 as that one looks like a standard 4 button, and not one of the scene keypads.

Thank you!


Add arguments to specify GET and PUT part size independently

Description of change

Introduce a new CLI flag --multipart-upload-threshold to specify the part size for multipart uploads during PUT operations.
Ensure that the object client interprets multipart-upload-threshold as the part size for initiating multipart uploads in PUT operations.

Relevant issues:  #762
Does this change impact existing behavior?

No, this flag is optional, for old CLI arguments, multipart-upload-threshold will be set as same part-size.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and I agree to the terms of the Developer Certificate of Origin (DCO).

@dannycjones
Oh, I kinda understand, we need to set part size for each put/get operation. So what we need to is changing the S3CrtClient, to make it holds these arguments? Or changing the obejct-client trait to make upper caller can change the part-size proactively?
And, should we deprecate the original part size now that we're providing per-request control?

Hey @crrow,

Oh, I kinda understand, we need to set part size for each put/get operation. So what we need to is changing the S3CrtClient, to make it holds these arguments? Or changing the obejct-client trait to make upper caller can change the part-size proactively?

I was chatting with @monthonk, we think the former makes sense where we modify the client to now have separate part sizes for GET and PUT. This can then be read when creating those requests. That's probably the best option to keep things simple.

should we deprecate the original part size now that we're providing per-request control?

One thing that would be nice to keep is the original part_size(usize) setter method alongside some new setters, to minimize breaking changes for now (since this is used by other projects like https://github.com/awslabs/s3-connector-for-pytorch).
Meanwhile, the inner fields on S3CrtClientInner can be replaced and I'd also recommend replacing the part_size() on ObjectClient with separate getters for GET and PUT methods respectively.

Hello @dannycjones, I've written it, have a check when you have a moment. Thank you!

Clippy is failing but all of those are our fault, we'll fix those.

Clippy is failing but all of those are our fault, we'll fix those.

hmm, weird, how did it pass previously

Clippy is failing but all of those are our fault, we'll fix those.

hmm, weird, how did it pass previously

We're running on the tip of Rust stable. We should pin it to a recent stable release and update it regularly instead - I plan to raise with the team since we get caught out like this sometimes.
In the meantime, I've pushed PR #956 which should unblock that check once merged.


The API version 2021-12-02 is not supported by Azurite

Issue Transfer
This issue has been transferred from the Azure SDK for .NET repository, #35396.
Please be aware that @tnlthanzeel is the author of the original issue and include them for any questions or replies.
Details
I have update the my visual studio to the latest version yesterday and suddenly the method var azResponse = await blobClient.DownloadToAsync(targetStream); stopped working.
i found  the below message in the exception
Azure.RequestFailedException
  HResult=0x80131500
  Message=The API version 2021-12-02 is not supported by Azurite. Please upgrade Azurite to latest version and retry. If you are using Azurite in Visual Studio, please check you have installed latest Visual Studio patch. Azurite command line parameter "--skipApiVersionCheck" or Visual Studio Code configuration "Skip Api Version Check" can skip this error.
RequestId:464b97a7-707a-4af6-8c25-8cce0e6b42f0
Time:2023-04-06T06:58:42.559Z
Status: 400 (The API version 2021-12-02 is not supported by Azurite. Please upgrade Azurite to latest version and retry. If you are using Azurite in Visual Studio, please check you have installed latest Visual Studio patch. Azurite command line parameter "--skipApiVersionCheck" or Visual Studio Code configuration "Skip Api Version Check" can skip this error. )
ErrorCode: InvalidHeaderValue

Headers:
Server: Azurite-Blob/3.20.1
x-ms-error-code: InvalidHeaderValue
x-ms-request-id: 464b97a7-707a-4af6-8c25-8cce0e6b42f0
Date: Thu, 06 Apr 2023 06:58:42 GMT
Connection: keep-alive
Keep-Alive: REDACTED
Transfer-Encoding: chunked
Content-Type: application/xml

  Source=Azure.Storage.Blobs
  StackTrace:
   at Azure.Storage.Blobs.BlobRestClient.<DownloadAsync>d__8.MoveNext()
   at Azure.Storage.Blobs.Specialized.BlobBaseClient.<StartDownloadAsync>d__66.MoveNext()
   at System.Threading.Tasks.ValueTask`1.get_Result()
   at Azure.Storage.Blobs.Specialized.BlobBaseClient.<DownloadStreamingInternal>d__65.MoveNext()
   at Azure.Storage.Blobs.PartitionedDownloader.<DownloadToAsync>d__9.MoveNext()
   at Azure.Storage.Blobs.Specialized.BlobBaseClient.<StagedDownloadAsync>d__94.MoveNext()
   at Azure.Storage.Blobs.Specialized.BlobBaseClient.<DownloadToAsync>d__92.MoveNext()
   at Azure.Storage.Blobs.Specialized.BlobBaseClient.<DownloadToAsync>d__84.MoveNext()
   at Azure.Storage.Blobs.Specialized.BlobBaseClient.<DownloadToAsync>d__80.MoveNext()
   at VPMS.FuncApp.Services.DocumentRespository.<DownloadDocument>d__3.MoveNext() in C:\Projects\vpms\vpms-legacy\VPMS.AzFunctionApps\VPMS.FuncApp\Services\DocumentRespository.cs:line 27

  This exception was originally thrown at this call stack:
    Azure.Storage.Blobs.BlobRestClient.DownloadAsync(string, string, int?, string, string, bool?, bool?, string, string, Azure.Storage.Blobs.Models.EncryptionAlgorithmTypeInternal?, System.DateTimeOffset?, System.DateTimeOffset?, string, string, string, System.Threading.CancellationToken)
    Azure.Storage.Blobs.Specialized.BlobBaseClient.StartDownloadAsync(Azure.HttpRange, Azure.Storage.Blobs.Models.BlobRequestConditions, Azure.Storage.DownloadTransferValidationOptions, long, bool, System.Threading.CancellationToken)
    System.Threading.Tasks.ValueTask<TResult>.Result.get()
    Azure.Storage.Blobs.Specialized.BlobBaseClient.DownloadStreamingInternal(Azure.HttpRange, Azure.Storage.Blobs.Models.BlobRequestConditions, Azure.Storage.DownloadTransferValidationOptions, System.IProgress<long>, string, bool, System.Threading.CancellationToken)
    Azure.Storage.Blobs.PartitionedDownloader.DownloadToAsync(System.IO.Stream, Azure.Storage.Blobs.Models.BlobRequestConditions, System.Threading.CancellationToken)
    Azure.Storage.Blobs.Specialized.BlobBaseClient.StagedDownloadAsync(System.IO.Stream, Azure.Storage.Blobs.Models.BlobRequestConditions, System.IProgress<long>, Azure.Storage.StorageTransferOptions, Azure.Storage.DownloadTransferValidationOptions, bool, System.Threading.CancellationToken)
    Azure.Storage.Blobs.Specialized.BlobBaseClient.DownloadToAsync(System.IO.Stream, Azure.Storage.Blobs.Models.BlobRequestConditions, Azure.Storage.StorageTransferOptions, System.Threading.CancellationToken)
    Azure.Storage.Blobs.Specialized.BlobBaseClient.DownloadToAsync(System.IO.Stream, System.Threading.CancellationToken)
    Azure.Storage.Blobs.Specialized.BlobBaseClient.DownloadToAsync(System.IO.Stream)
    VPMS.FuncApp.Services.DocumentRespository.DownloadDocument(string, string, System.IO.Stream) in DocumentRespository.cs

Expected behavior
The stram must be downloaded
Actual behavior
Throws error
HResult=0x80131500
Message=The API version 2021-12-02 is not supported by Azurite. Please upgrade Azurite to latest version and retry. If you are using Azurite in Visual Studio, please check you have installed latest Visual Studio patch. Azurite command line parameter "--skipApiVersionCheck" or Visual Studio Code configuration "Skip Api Version Check" can skip this error.
Reproduction Steps
public async Task<ResponseResult<Stream>> DownloadDocument(string containerName, string blobName, Stream targetStream)
    {
        try
        {
            var blobContainerClient = GetContainerAsync(containerName);

            var blobClient = blobContainerClient.GetBlobClient(blobName);

            var azResponse = await blobClient.DownloadToAsync(targetStream);

            if (azResponse.IsError) return new(new OperationFailedException("blob", JsonConvert.SerializeObject(azResponse)));

            return new(targetStream);
        }

        catch (Exception ex)
        {
            return new(new OperationFailedException("Blob", JsonConvert.SerializeObject(ex)));
        }
    }

Environment
visual studio enterprise: 17.5.3
azurite version: 3.20.1

@jsquire
2021-12-02 is support by Azurite 3.22.0 or later (you are using 3.20.1), see details in :
https://github.com/Azure/Azurite/blob/main/ChangeLog.md#202302-version-3220
Would you please upgrade to latest Azurite and try again?
Besides that, you can also suppress this error by run Azurite with parameter "--skipApiVersionCheck".

@blueww Thanks that fixed the issue for me. One gotcha is I had to purge the Azurite image from Docker Desktop for it to pull the latest. Just mentioning that in case anybody runs in to the same thing.

I have just come across this issue when testing locally with the more recent version of Visual Studio 2022, 17.5.5. The Azure version installed is 3.20.1.
Not sure how the Visual Studio team maintains dependencies updated, but I will resort to use the skipApiVersionCheck parameter for now.


Feature/update get nearest edge methods

This is how I envisioned writing a SpatialIndex class that can be passed in to the get_nearest_edge() and get_nearest_edges() functions. The functionality should be the same as before with a few optional additional parameters. Please see feature request #261 for details.
I have not yet added the option to return distances, as requested in #280 , since that would change the number of items returned by the function, which could cause problems for users who are relying on the current implementation. Happy to add this feature if desired.
It might also be a good idea to update the get_nearest_nodes() function similarly.
Lastly, on the current upstream / master implementation of the get_nearest_edges() function, I noticed on a test case that I received different outputs when using the methods kdtree, balltree and None. This seems like a potential problem and I'm happy to share the test script that gave these results. The implementation in this PR is simply a re-arrangement of the original implementation, so the outputs match those of the current upstream / master version.
Lmk your thoughts, thanks!

Coverage increased (+0.2%) to 93.5% when pulling a87295154373d1f0ab624fef748b3944cf8cff43 on juliamgomes:feature/update-get-nearest-edge-methods into 6cf890d139b11ed90b09a1e49284488ca55a515e on gboeing:master.

As far as returning distances for #280, could we extract the internals of KDTreeIndex.get_nearest_edges to another function and simply discard the distances for the function that returns only the node IDs?
https://github.com/dHannasch/osmnx/commit/e28b9782164b0c8e63024902ccb60e7ad7f1b0e3
It seems like that is in effect what the function does anyway, since cKDTree.query returns the distances which are then discarded. We could make a column of the existing GeoDataFrame point to those distances, and then still discard them when they are not wanted.

Thanks @juliamgomes.

Lastly, on the current upstream / master implementation of the get_nearest_edges() function, I noticed on a test case that I received different outputs when using the methods kdtree, balltree and None. This seems like a potential problem and I'm happy to share the test script that gave these results.

Can you provide more details on that? If you were working in lat-lng, I suppose we should expect different results between kdtree (since it's Euclidean) and balltree (since it's haversine).

I have not yet added the option to return distances, as requested in #280 , since that would change the number of items returned by the function, which could cause problems for users who are relying on the current implementation. Happy to add this feature if desired.

@juliamgomes we could handle this by adding a new argument return_distances=False, which if set to True would return the distances as well. But by default it would not return them so the behavior would remain consistent with the current implementation.

Cool @dHannasch I'll make that change tomorrow in the way that @gboeing suggested, by adding a new argument return_distanceas=False. Sorry for the late reply!
@gboeing to elaborate, I tried to test the original and modified function ox.get_nearest_edges() on 2 sample coordinates. The results between master and my modified function were consistent. But the results across the methods balltree, kdtree, and none were inconsistent, with nearest_edges_none = ox.get_nearest_edges(graph, X, Y) producing unexpected results. This is most likely a mistake on my part, but I'm including the visuals and sloppy debug script just in case.
Balltree (coordinates in yellow, nearest edge nodes in red):

Kdtree:

None:

import osmnx as ox
import matplotlib.pyplot as plt
import numpy as np

def debug_visualize(graph, X, Y, nearest_edges):
    nc = []
    for node in graph.nodes():
        color = "k"
        if node in list(np.array(nearest_edges).flatten()):
            color = "r"
        nc.extend(color)
    fig, ax = ox.plot_graph(graph, node_color=nc, node_size=30, node_zorder=3, show=False, close=False)
    ax.scatter(X, Y, c='y', s=60)
    plt.show()

def main():
    latitude = 37.765860
    longitude = -122.433310
    duboce_triangle = (latitude, longitude)

    philz_latitude = 37.780079
    philz_longitude = -122.420174
    philz = (philz_latitude, philz_longitude)

    graph = ox.graph_from_point(philz, distance=2000, network_type="drive")

    coordinates = [duboce_triangle, philz]
    Y = [coord[0] for coord in coordinates]
    X = [coord[1] for coord in coordinates]
    print("Y coordinates are latitude: {}\nX coordinates are longitude: {}\n".format(X, Y))

    nearest_edges_balltree = ox.get_nearest_edges(graph, X, Y, method='balltree')
    print("balltree:")
    for i in [0, 1]:
        for j in [0, 1]:
            print(graph.node[nearest_edges_balltree[i][j]])
    print()

    nearest_edges_kdtree = ox.get_nearest_edges(graph, X, Y, method='kdtree')
    print("kdtree")
    for i in [0, 1]:
        for j in [0, 1]:
            print(graph.node[nearest_edges_kdtree[i][j]])
    print()

    nearest_edges_none = ox.get_nearest_edges(graph, X, Y)
    print("haversine")
    for i in [0, 1]:
        for j in [0, 1]:
            print(graph.node[nearest_edges_none[i][j]])
    print()

    debug_visualize(graph, X, Y, nearest_edges_balltree)
    debug_visualize(graph, X, Y, nearest_edges_kdtree)
    debug_visualize(graph, X, Y, nearest_edges_none)

if __name__ == "__main__":
    main()


Fix CoM result download

Allow AnalysisResult to be tagged with include_in_download=False
When downloading, filter AnalysisResultSet to only include results that should be
downloaded
Fix AnalysisResult.__array__ to always coerce the raw data to np.ndarray

Contributor Checklist:

[x] I have added or updated my entry in the creators.json file
[ ] I have added a changelog entry for my contribution
[ ] I have added/updated documentation for all user-facing changes
[x] I have added/updated test cases

Looking good, confirmed to fix the bug on my system.
When looking at the data, I noticed that we need some sort of indication which layers or components are omitted from the result set. Before, there was an 1:1 matching between items in the drop-down and layers in the result. At least in Fiji I can't see any indication which layer is which.
Perhaps a zip file with individual files for each layer as discussed in #665 and a JSON file with metadata would be better? Maybe being able to encode all information to completely restore an AnalysisResultSet could be a good guiding principle for designing the download format?

When looking at the data, I noticed that we need some sort of indication which layers or components are omitted from the result set. Before, there was an 1:1 matching between items in the drop-down and layers in the result. At least in Fiji I can't see any indication which layer is which.

True.

Perhaps a zip file with individual files for each layer as discussed in #665 and a JSON file with metadata would be better?

I don't think it would be strictly better - a TIFF file you can directly open in DM/Fiji/GIMP/... - zipped, you first need to fiddle around with file management.  I would agree that it would be nice to have a zip w/ layers + parameters.json download format in addition.
Sadly, TIFF doesn't support layer names, or this would be a no-brainer... HDF5 is much better suited for this kind of application, IMHO:
In [2]: f = h5py.File("/home/alex/Downloads/results.h5", "r")

In [3]: f.keys()
Out[3]: <KeysViewHDF5 ['divergence', 'magnitude', 'x', 'y']>

Maybe being able to encode all information to completely restore an AnalysisResultSet could be a good guiding principle for designing the download format?

Yeah, see #687 - we should write analysis and dataset parameters into formats that support those.

Perhaps indicating in the GUI layer drop-down or in the result download dialogue which layers are included in download?

Sounds good. Could be done by serializing the "included with download" flag together with the result set, and querying that from the download modal.

This is now implemented, let me know if this works for you. Should be merge-able after rebuilding the client, feel free to take over the PR tomorrow.

Fix confirmed, many thanks! :-)


Large copy silently fails to copy all files

On a sample copy of 6000 files - 1000 didn't get copied.
In addition to better error checking (separate issue) - the question is why did files fail to copy.

On examining cloudwatch
Source arg =   s3:agha:AAAAAA.hard-filtered.vcf.gz.tbi
status code: 409, request id:   CVWGDGYN1Y65HW4C, host id:   WOx2z/KB0f4r+EEkyehKvKPlOX+UFLy3d5wAHvdIxOYjPJ5I8waJqD+k7zaS2R25DTtOBBzBR2g=
2023/11/27 23:22:13 ERROR : Attempt 1/3   failed with 1 errors and: OperationAborted: A conflicting conditional   operation is currently in progress against this resource. Please try again.
status code: 409, request id:   CVWGDGYN1Y65HW4C, host id:   WOx2z/KB0f4r+EEkyehKvKPlOX+UFLy3d5wAHvdIxOYjPJ5I8waJqD+k7zaS2R25DTtOBBzBR2g=
2023/11/27 23:22:13 ERROR :   AAAAAA.vcf.gz.tbi: Failed to copy:   OperationAborted: A conflicting conditional operation is currently in   progress against this resource. Please try again.
status code: 409, request id:   CVWK3NJN9W6D245M, host id:   nboQ8PgmbRbzB3i6iWJOHHqftguo4iim8dC3YSW5ANyQnRgdmvILcdXBvcXI0C+rWt1f07QEt9Q=
2023/11/27 23:22:13 ERROR : Attempt 2/3   failed with 1 errors and: OperationAborted: A conflicting conditional   operation is currently in progress against this resource. Please try again.
status code: 409, request id:   CVWK3NJN9W6D245M, host id:   nboQ8PgmbRbzB3i6iWJOHHqftguo4iim8dC3YSW5ANyQnRgdmvILcdXBvcXI0C+rWt1f07QEt9Q=
2023/11/27 23:22:13 ERROR :   AAAAAA.vcf.gz.tbi: Failed to copy:   OperationAborted: A conflicting conditional operation is currently in   progress against this resource. Please try again.
status code: 409, request id:   CVWK3HSXBYY0ERCJ, host id:   5h7LDLo9yYs1CIoWdX5S4M61P1P5XxstNiV1o9WqqlBF61L2mYAY71M/xLYyEtZwuj02xsDn8rQ=
2023/11/27 23:22:13 ERROR : Attempt 3/3   failed with 1 errors and: OperationAborted: A conflicting conditional   operation is currently in progress against this resource. Please try again.
status code: 409, request id:   CVWK3HSXBYY0ERCJ, host id:   5h7LDLo9yYs1CIoWdX5S4M61P1P5XxstNiV1o9WqqlBF61L2mYAY71M/xLYyEtZwuj02xsDn8rQ=
2023/11/27 23:22:13 ERROR :   AAAAAA.vcf.gz.tbi: Failed to copy:   OperationAborted: A conflicting conditional operation is currently in   progress against this resource. Please try again.
status code: 409, request id:   CVWK3HSXBYY0ERCJ, host id:   5h7LDLo9yYs1CIoWdX5S4M61P1P5XxstNiV1o9WqqlBF61L2mYAY71M/xLYyEtZwuj02xsDn8rQ=
2023/11/27 23:22:13 Failed to copy:   OperationAborted: A conflicting conditional operation is currently in   progress against this resource. Please try again.
Elapsed time:         1.2s
Errors:                 1 (retrying may help)
Transferred:   	            0 B / 0 B, -, 0 B/s, ETA -

Which leads to
https://forum.rclone.org/t/s3-409-error-from-concurrent-rclone-processes/33640

Given we already have checked the bucket existence ourselves - we will just add that flag to disable the rclone check


Dashboard enhancements

[ ] Change tooltip name for documents in supervisor view to "Documents & Transcripts"
[ ] Add tooltip messages for metrics in supervisor dash

On it!

Finished!


[FP]: memcache-asg-java-client incorrectly indentified as memcached

Package URl
<EMAIL_ADDRESS>CPE
cpe:2.3:a:memcached:memcached:<IP_ADDRESS>:::::::*
CVE
No response
ODC Integration
None
ODC Version
10.0.2
Description
https://github.com/advisories/GHSA-47qj-rqv2-98f2 is a vulnerability in the memcached server, however it is being matching on a memcached client published by a third party vendor. This is similar to #7207, but with a different CPE.

approved


This happens everytime I try to load the game

It seems that there might be an error with the Java Virtual Machine. Uninstall Java and reinstall from here. If that doesn't solve the problem, feel free to reply.

How much RAM do you have? It seems java could not allocate the requisite 2 gigs to run the JVM.

How much RAM do you have? It seems java could not allocate the requisite 2 gigs to run the JVM.

I was thinking this since it was talking about how it couldn't reserve enough memory. It could be some privilege error or you just don't have enough allocated RAM.

Yeah, I remember encountering this issue when testing the launcher on a VM with too little memory. I imagine this is the same issue.


Bump org.mock-server dependency set from 5.4.1 to 5.5.0

Thanks for the contribution @bbednarek! LGTM.


Memory leak

I have mentioned this in https://github.com/googlemaps/android-maps-compose/issues/26 , but it is already closed, so I am opening a new issue.
I am getting a leak if the map component is cleared and then the activity is destroyed.
Previously when implementing it through AndroidView, to get rid of the maps leak, I had to use:
DisposableEffect(lifecycle) {
        lifecycle.addObserver(lifecycleObserver)
        onDispose {
            lifecycle.removeObserver(lifecycleObserver)
            mapView.onDestroy()
            mapView.removeAllViews()
        }
    }

And
remember(mapView) {
        LifecycleEventObserver { _, event ->
            when (event) {
                Lifecycle.Event.ON_CREATE -> mapView.onCreate(Bundle())
                Lifecycle.Event.ON_START -> mapView.onStart()
                Lifecycle.Event.ON_RESUME -> mapView.onResume()
                Lifecycle.Event.ON_PAUSE -> mapView.onPause()
                Lifecycle.Event.ON_STOP -> mapView.onStop()
                Lifecycle.Event.ON_DESTROY -> {
                    //handled in onDispose
                }
                else -> throw IllegalStateException()
            }
        }
    }

The reason is that Lifecycle.Event.ON_DESTROY might not be called, and this way you would always dispose of the map view in onDispose, which will always be called.
Would you be able to add this? I did fork and update it and the big memory leak disappeared.
`1 APPLICATION LEAKS
References underlined with "~~~" are likely causes.
Learn more at https://squ.re/leaks.

56446 bytes retained by leaking objects
Signature: 34a030bd011ab1ccd655bbeac3fbc8465c53ce5f
┬───
│ GC Root: Thread object
│
├─ com.google.maps.api.android.lib6.gmm6.vector.n instance
│    Leaking: UNKNOWN
│    Retaining 3.5 MB in 26933 objects
│    Thread name: 'RenderDrive'
│    ↓ n.e
│        ~
├─ com.google.maps.api.android.lib6.gmm6.vector.p instance
│    Leaking: UNKNOWN
│    Retaining 3.5 MB in 26930 objects
│    ↓ p.f
│        ~
├─ com.google.maps.api.android.lib6.gmm6.api.ac instance
│    Leaking: UNKNOWN
│    Retaining 3.5 MB in 26929 objects
│    View not part of a window view hierarchy
│    View.mAttachInfo is null (view detached)
│    View.mWindowAttachCount = 1
│    mContext instance of ExampleApplication
│    ↓ ac.N
│         ~
├─ com.google.maps.api.android.lib6.impl.ax instance
│    Leaking: UNKNOWN
│    Retaining 20 B in 1 objects
│    a instance of ExampleApplication
│    b instance of ExampleActivity with mDestroyed = true
│    ↓ ax.b
│         ~
╰→ ExampleActivity instance`

Thanks for filling and opening a new issue. I'm not certain that your proposed workaround will fix this leak. MapView.onDestroy() is meant to be called on an activity/fragment onDestroy event, which as you mentioned, is not guaranteed to be called. So in theory the map should not leak memory even if onDestroy is not called.
Looking up existing issues on the Maps SDK issue tracker, it appears that this might be an issue on the Maps SDK itself and independent of Maps Compose. See https://issuetracker.google.com/issues/219068016

@arriolac it is true that it won't fix the very long-term google maps SDK issue, but that issue leaks a few kb of internal memory (can be fixed with weak references). That is a different leak.
However, this issue leaks multiple megabytes because nothing is being cleared. I have this tested in AS and also in production where this fix brought the average memory used down from 450MB to 140MB. I am using the same thing for camerax compose android view.
If you do call OnDispose and that removes the lifecycle before the activity is killed, the lifecycle onDestroy is never called even if activity onDestroy is called. There is a memory leak https://github.com/googlemaps/android-maps-compose/blob/e4e6796fc8d3cc7f3bd6b57db27d2dec79ba13a5/maps-compose/src/main/java/com/google/maps/android/compose/GoogleMap.kt#L170
That can happen often.
A similar issue that causes onDestroy not to be called because of the same lifecycle that here causes memory leaks is discussed here https://github.com/google/accompanist/issues/978
Might also be similar to https://github.com/android/camera-samples/pull/352 that google maps is keeping something on a separate process, which then causes a leak if stuff isn't cleared.

Can you provide some repro steps? Would be great if we can validate this in the sample app included in the repro and verify that your proposed fix addresses it.

@arriolac this is a pretty standard project, where there is a map, marker and clicking the marker goes to other screen, clicking back button goes back. Using compose navigation. Unfortunately, I can't share the big project where the leak is big, because it is private. I can add you these logs and create it in the sample to validate based on the lifecycle + you could add leakcanary and see the difference between this (will depend on the app data size, because it leaks it all) and the small google internal leak.
I can create it if you need it, but first I wanted to sent you logs from such an app lifecycle, so you can see that in this case ON_DESTROY is never called and memory keeps leaking (the previous screen is on backstack until the back button is pressed and it is re-created):
open screen A with map
2022-06-10 06:53:21.977 2289-2289/ D/AAA: ON_CREATE
2022-06-10 06:53:22.146 2289-2289/ D/AAA: ON_START
2022-06-10 06:53:22.146 2289-2289/ D/AAA: ON_RESUME
navigate to screen B
2022-06-10 06:53:48.368 2289-2289/ D/AAA: ON_PAUSE
2022-06-10 06:53:48.368 2289-2289/ D/AAA: ON_STOP
screen B create,start,resume
2022-06-10 06:53:49.245 2289-2289/ D/AAA: MapLifecycle: onDispose
press back to screen A (this will create a new mapview and if the old one wasn't disposed in onDispose, it leaks data)
2022-06-10 06:53:53.243 2289-2289/ D/AAA: ON_CREATE
2022-06-10 06:53:53.265 2289-2289/ D/AAA: ON_START
2022-06-10 06:53:54.004 2289-2289/ D/AAA: ON_RESUME

@arriolac does this help or would you want me to extend the sample project to show this problem?

@polivmi1 yes, that would be helpful.

@arriolac I have added a sample here https://github.com/polivmi1/android-maps-compose
It contains 2 screens using compose navigation.
Steps to reproduce the problem:

Open in profiler and memory
open basic map
click on marker
click on BACK button
repeat steps 3 and 4 multiple times seeing that memory is never cleaned
minimize the app to free the leaked objects

I am also attaching screenshots of the step 5 and 6:

Please let me know if you need more information. It should be clear from this, but you can also add the lifecycle logs and try with the fix I mentioned in the first comment.
Thanks for looking into it!

@arriolac is this in your queue or is there anything else I could add to help with it?

@polivmi1 you've been really helpful with the amount of information you've shared already. This is in my queue to look into.

I can confirm the memory leak and your proposed workaround does indeed fix the issue, however, I think the underlying lifecycle for the NavBackStackEntry should be receiving the ON_DESTROY event. Will raise this to the navigation compose team to see where the fix should be applied.

@arriolac is there an issuetracker discussion or a github issue with the navigation compose team that I could follow?

@polivmi1 supposedly adding a custom animation within a NavHost is not supported. Can you try removing the wrapping AnimatedVisibility to see if you still encounter a leak?

@arriolac what AnimatedVisibility do you mean? I don't use anything that would wrap it on that screen. I use AnimatedVisibility only for some elements on some other screens to animate a button for example. What I use for screen animation is https://google.github.io/accompanist/navigation-animation/ - AnimatedNavHost - is that the problem?

Ok I've confirmed that it is the intended behavior that the previous destination is not getting the DESTROYED event when navigating away from it. Your proposed workaround https://github.com/googlemaps/android-maps-compose/issues/138#issue-1263112472 should be put in place to resolve this @polivmi1. Would you like to make this contribution to the library?


Getting NetworkHelper: operation: query

Actual Behavior
Hi when executing a query through the extension i am getting the error
Error opening content and in the output terminal I get the error Getting NetworkHelper: operation: query
Expected Behavior
Getting the result of the query or at least an explanation why the query failed
Steps to Reproduce the Problem Or Description

Executing the query:

#import "./XFragment.gql"
query xs {
  xs {
    x {
      ...X
    }
    success
    message
  }
}

my Configuration:
{
  "projects": {
    "myproject": {
      "schemaPath": "schema.graphql",
      "extensions": {
        "endpoints": {
          "default": {
            "url": "http://localhost:3000/api",
            "Authorization": "Bearer mytoken"
          }
        }
      }
    }
  }
}

Specifications

GraphQL for VSCode Extension Version: 0.1.7
VSCode Version: 1.33.1
OS Name: Linux
OS Version: Ubutntu 16.04

Logs Of TS Server || GraphQL Language Service
NetworkHelper: operation: query

@mattharder91 You should get the GraphQL/network errors in the pane that is also supposed to show the result on success. Does that not happen in your case?
For example, if I run a query against a server that is not running, I get this error:

@mattharder91 I found a few edge cases where this had regressed, and was able to fully restore the error handling


[MOBILE] Mobile layout is offset in case DAO name is too big

An issue occurred with DAO testdao2.sputnikv2.testnet on mobile device Pixel 5. Android 12. Google Chrome
The current DAO has 58 characters in the title
STR:

Create new DAO with a title of at least 58 characters
Open My DAOs page

Expected result
Mobile layout is displayed according to design without offset
Actual result
Mobile layout is offset in case DAO name is too big

Verified on dev. Fixed


Android: First run (right after install) seems to ignore auto-download and auto-install

Hi, I've disabled auto-install and auto-download in config.xml.
But it seems to be ignored on first run (right after install).
App get stuck on update, and it has to be closed and reopened. On second and all others run, everything is fine.
I have preloader index.html page, which sets things up and redirects to an app.html page.
So basically I'm listening on deviceready event and do chcp update checks.
In my app, I was expecting console logs to be in following order:

Device is ready
Plugin configured successfully
update is ready

But actually on first run I see:

Device is ready
update is ready

   function onUpdateReady () {
      console.log('update is ready');
      //this should be called only after chcp.fetchUpdate(fetchUpdateCallback);
   }

    function onDeviceReady () {
        console.log('Device is ready');
        var options = {
          'auto-download': false,
          'auto-install': false
        };

        chcp.configure(options, configureCallback);
    }
    function configureCallback (error) {
        if (error) {
          console.log('Error during the configuration process');
          console.log(error.description);
          init();
        } else {
          console.log('Plugin configured successfully');
          // from this moment only we control when to download and install new releases
          chcp.fetchUpdate(fetchUpdateCallback);
        }
    }

    function fetchUpdateCallback (error, data) {
        if (error) {
            console.log('Failed to load the update with error code: ' + error.code);
            console.log(error.description);
            init();
            return;
        } else {
            console.log('Update is loaded, running the installation');
            chcp.installUpdate(installationCallback);
        }
    }

    function installationCallback (error) {
        if (error) {
            console.log('Failed to install the update with error code: ' + error.code);
            console.log(error.description);
        } else {
            console.log('Update installed!');
        }
        init();
    }

    function init () {
        window.document.location = 'mobile.html';
    }

    document.addEventListener('deviceready', onDeviceReady, false);
    document.addEventListener('chcp_updateIsReadyToInstall', onUpdateReady, false);

Hi,
Yes, that's sort of a bug. The reason is simple: when application is started for the very first time - it copies www folder from assets to the external storage. While doing so - it ignores any requests from the JS side. As soon as he finishes copying - requests are accepted.
So, if you are calling chcp.configure or chcp.fetchUpdate during that time - the requests are ignored. But on the next launches it doesn't need to copy anything, and that is why it's working.
If you know, that from the very beginning you don't need auto-updates and auto-installation - I'll suggest to disable them in the config.xml instead of JS. And for fetchUpdate - do as described in https://github.com/nordnet/cordova-hot-code-push/issues/63 .
In the future It will probably store those requests to execute after www installation.

@nikDemyankov thank you for the answer. I understand the complications, but actually I have disabled auto-download and auto-install in config.xml.
Fragment of config.xml
...
  <chcp>
    <auto-download enabled="false"/>
    <auto-install enabled="false"/>
    <config-file url="http://some.url"/>
    <local-development enabled="false"/>
  </chcp>
...

Thanks, will check it.

Should be fixed in v1.2.0. If not - reopen the issue.

+1
I'm using the 1.3.2 plugin version and I have this same problem and more, every update the size of my app double it. The app has 40mb, and the first run doubles the app size, taking 5min to do this, probably is about this copy to external storage approach.
The auto-download=false doesn't affect this first copy to external.
So, like you said @nikDemyankov, after that I can call the fetchUpdate to check and download new files.
After the download completed and app reloaded, the app size was increased +40mb, and I changed only one file. I tried to close the app and open again to see if some clean up happens, but no! :(
I'm testing in:
Google Nexus 3 - Android 4.3 - API 18 - Genymotion (Takes 5min to copy)
Sony Xperia Z1 - Android 5.1.1 - Smartphone (Takes 30s)
Libs:
Cordova CLI: 6.1.1
Gulp version:  CLI version 3.9.1
Gulp local:   Local version 3.9.1
Ionic Version: 1.3.0
Ionic CLI Version: 1.7.14
Ionic App Lib Version: 0.7.0
OS:
Node Version: v5.11.0

@diegodotta Plugin stores 2 versions on the external storage: the current working www folder (displayed to the user), and the previous one as a backup. On the next update it will replace backup version without increasing the size of the app.
auto-download=false controls only download process, not the inner storage logic.
If you have some large files in the app (audio, movies, etc.) and they are not gonna change very often - then I suggest to update them a bit differently.
Store large files in assets instead of www
Instead of putting them in www folder - put them in the assets folder and access them via other cordova plugin (for example, cordova-plugin-file). In that case you would not be able to update them via chcp plugin, but if they are not changing that often - it's not a problem. Plus, it will make updates to be installed much faster.
Download large files after update
Instead of bundling large files in the app - you can download them dynamically on the first app launch. Some games does that, when their size is quite big. Yes, user will have to wait for some time, but if the size of the loaded files are not that big - it should not take too long.
When loading is finished - you can store files on file system with the help of cordova-plugin-file. When new release is available - you can re-download these large files (if needed).
You should use chcp plugin mainly for updating html/css/js/images, but for heavy stuff, if possible, add some logic.

Nice idea!! This approach about download the content is knocking the door every new sprint! Maybe it's time to open the door! :dancer:

Maybe it is :) And it should not be too hard to implement.


Problems with webkit_server through Docker

I'm seeing the following error for tests that have :js
  1) creating move edits the move
     Failure/Error: visit new_move_path(as: user)
     Capybara::Webkit::ConnectionError:
       /box/gems/capybara-webkit-1.8.0/bin/webkit_server failed to start.
     # /box/gems/capybara-webkit-1.8.0/lib/capybara/webkit/connection.rb:87:in `parse_port'
     # /box/gems/capybara-webkit-1.8.0/lib/capybara/webkit/connection.rb:93:in `discover_port'
     # /box/gems/capybara-webkit-1.8.0/lib/capybara/webkit/connection.rb:74:in `start_server'
     # /box/gems/capybara-webkit-1.8.0/lib/capybara/webkit/connection.rb:31:in `initialize'
     # /box/gems/capybara-webkit-1.8.0/lib/capybara/webkit/driver.rb:14:in `new'
     # /box/gems/capybara-webkit-1.8.0/lib/capybara/webkit/driver.rb:14:in `initialize'
     # /box/gems/capybara-webkit-1.8.0/lib/capybara/webkit.rb:15:in `new'
     # /box/gems/capybara-webkit-1.8.0/lib/capybara/webkit.rb:15:in `block in <top (required)>'
     # /box/gems/capybara-2.6.2/lib/capybara/session.rb:84:in `driver'
     # /box/gems/capybara-2.6.2/lib/capybara/session.rb:70:in `initialize'
     # /box/gems/capybara-2.6.2/lib/capybara.rb:276:in `new'
     # /box/gems/capybara-2.6.2/lib/capybara.rb:276:in `current_session'
     # /box/gems/capybara-2.6.2/lib/capybara/dsl.rb:46:in `page'
     # /box/gems/capybara-2.6.2/lib/capybara/dsl.rb:51:in `block (2 levels) in <module:DSL>'
     # ./spec/features/credits/moves_spec.rb:24:in `block (2 levels) in <top (required)>'
     # ./spec/support/headless.rb:4:in `block (3 levels) in <top (required)>'
     # /box/gems/headless-2.2.3/lib/headless.rb:134:in `run'
     # ./spec/support/headless.rb:3:in `block (2 levels) in <top (required)>'
     # /box/gems/activesupport-<IP_ADDRESS>/lib/active_support/dependencies.rb:268:in `load'
     # /box/gems/activesupport-<IP_ADDRESS>/lib/active_support/dependencies.rb:268:in `block in load'
     # /box/gems/activesupport-<IP_ADDRESS>/lib/active_support/dependencies.rb:240:in `load_dependency'
     # /box/gems/activesupport-<IP_ADDRESS>/lib/active_support/dependencies.rb:268:in `load'
     # /box/gems/spring-commands-rspec-1.0.4/lib/spring/commands/rspec.rb:18:in `call'
     # -e:1:in `<main>'

The command I run is docker-compose run web bin/rspec spec/features.
Dockerfile:
FROM ruby:2.3.0

RUN apt-get update -qq && apt-get install -y build-essential

# for postgres
RUN apt-get install -y libpq-dev

# for nokogiri
RUN apt-get install -y libxml2-dev libxslt1-dev

# for capybara-webkit
RUN apt-get install -y libqt4-webkit libqt4-dev xvfb

# for a JS runtime
RUN apt-get install -y nodejs

RUN mkdir /app
WORKDIR /app
ENV BUNDLE_PATH /box
COPY . /app/

docker-compose.yml:
db:
  image: postgres:9.4
  ports:
    - "5432"
web:
  build: .
  command: bin/rails s -b <IP_ADDRESS> -p 3000
  volumes:
    - .:/app
  volumes_from:
    - box
  stdin_open: true
  ports:
    - "3000:3000"
  links:
    - db
box:
  image: busybox
  volumes:
    - /box

If I jump into the container with docker-compose run web bash and run web_server manually I see this
root@3f00491727e9:/app# /box/gems/capybara-webkit-1.8.0/bin/webkit_server
/box/gems/capybara-webkit-1.8.0/bin/webkit_server: error while loading shared libraries: libQt5WebKitWidgets.so.5: cannot open shared object file: No such file or directory

I have tried using headless as described here but that didn't work.
Any idea what I'm doing wrong?

I have now read through the installation instructions in the wiki but it didn't help. My Dockerfile now looks like
FROM ruby:2.3.0

RUN apt-get update -qq && apt-get install -y build-essential

# for postgres
RUN apt-get install -y libpq-dev

# for nokogiri
RUN apt-get install -y libxml2-dev libxslt1-dev

# for capybara-webkit
RUN apt-get install -y libqt5webkit5-dev gstreamer1.0-plugins-base gstreamer1.0-tools gstreamer1.0-x xvfb libqt4-webkit libqt4-dev

# for a JS runtime
RUN apt-get install -y nodejs

RUN mkdir /app
WORKDIR /app
ENV BUNDLE_PATH /box
COPY . /app/

Is it possible that you're providing vendored/compiled gems from the host system or a different Docker container? If the necessary libraries aren't present, capybara-webkit can't compile, so it looks like it was compiled when the libraries were available but then run in an environment where they weren't. How are you running bundle install in the Docker environment?

Yes I am installing gems into another container that runs busybox. This is to cache gems and make bundle install faster. So sounds like that might be the issue.
Any ideas how I would fix that?

I haven't worked with that particular Docker workflow, but you'll need to compile capybara-webkit on a host that has the linked libraries at the same locations as the host you're going to run the tests on.
This doesn't look like a bug in capybara-webkit, so I'm going to close this issue. Feel free to continue commenting if you have further questions or ideas.

I've spent lots of time trying to solve this issue.
Here's what I've found:

Instead of running rspec you should run xvfb-run -a rspec

It seems capybara needs a X Server, so that's for it. Make sure you have xvfb installed.
In case your docker base image is CentOs, you may need run one more step.

dbus-uuidgen > /var/lib/dbus/machine-id

You can do this either adding a RUN at your Dockerfile or running it before a test.


KeyError in /usr/local/lib/python2.7/dist-packages/oauth_tokens/base.py

KeyError at /usr/local/lib/python2.7/dist-packages/oauth_tokens/base.py in authorize:73:
log.debug('Response auth location: %s' % response.headers['location']) ...
I think better way is response.headers.get('location')

The application was completely rewritten. Try to upgrade to new version


Add MS447

@l-7777777 Please provide us with:

the school full name (it is unlikely to be called officially just "MS447")
the school official website URL
the school street address, including the city and the country
an URL of a page on the official website where the school offers an IT-related long-term (>1 year) course

@l-7777777 Please provide us with:

the school full name (it is unlikely to be called officially just "MS447")
the school official website URL
the school street address, including the city and the country
an URL of a page on the official website where the school offers an IT-related long-term (>1 year) course

The full name is The Math and Science Exploratory School.
The URL is ms447.org.
The address is 345 Dean St, Brooklyn, NY, NY, US 11217
It's a middle school, and so it doesn't have pages for specific courses. It does have a computer class, in which we are learning HTML.

The full name is The Math and Science Exploratory School.
The URL is ms447.org.
The address is 345 Dean St, Brooklyn, NY, NY, US 11217
It's a middle school, and so it doesn't have pages for specific courses. It does have a computer class, in which we are learning HTML.

@l-7777777 Thank you for the clarification. Pull request merged.

@l-7777777 Thank you for the clarification. Pull request merged.

It still doesn't let me apply, do I have to wait?

It still doesn't let me apply, do I have to wait?

Nevermind, I just had to wait a little while.

Nevermind, I just had to wait a little while.

@l-7777777

@philipto It still doesn't let me apply, do I have to wait?

Yes, you are quite right. Have a great coding time! :)

@l-7777777

@philipto It still doesn't let me apply, do I have to wait?

Yes, you are quite right. Have a great coding time! :)


Add stats/links for Hacktoberfest 🎃

This PR adds a button to the top of the dashboard during the month of October, linking to these search results. It also adds a hacktoberfest label count/link to each project's row in the table. Unrelated: I also removed some unnecessary apostrophes in the column titles.
Fixes #16 (with a little pumpkin or a ghost or something, as requested 😄)

YESSSSS


[PLT-5535] Timestamp links on desktop app should open in permalink view in the current window

Summary
Timestamp links on desktop app should open in permalink view in the current window
Ticket Link
Jira: https://mattermost.atlassian.net/browse/PLT-5535
Github: https://github.com/mattermost/mattermost-server/issues/5586

Setup Test Server label detected. Spinmint test server created if build succeeds (checks pass and no conflicts with base branch).

Spinmint test server created at: http://i-095e561c7be9d5f6d.spinmint.com:8065/pr161
Test Account 1: Email<EMAIL_ADDRESS>| Password: passwd
Test Account 2: Email<EMAIL_ADDRESS>| Password: passwd
Instance ID: i-095e561c7be9d5f6d

Spinmint test server destroyed

Thanks @cpanato!


[Tracking]: add more bundlers to benchmark page

What subject does this issue tracking?
Background
we only benchmark against webpack before but more and more users want to benchmark rspack with rollup | esbuild | vite, and even we don't want to start a benchmark game with other bundlers, but it did help users make choice about which bundler to choose. and there are already lots benchmark against rspack right now, some of them may not be familiar with rspack and use the wrong way to benchmark against rspack which made a bad reputation about rspack.
there are lots of things to consider to do a fair benchmark(You can't do benchmark right the first time).
bundler choices

webpack
vite
turbopack
rspack
parcel
rollup
esbuild

benchmark criteria

cold start time
hot start time
cold build time
hot build time
rebuild time
HMR time
build size
FCP time of build assets

benchmark machine
we should always benchmark in ci machine because local machin is very subjective and can't be reviewed, but bundler may have different performance on different machine(for example, since rspack|turbopack heavily relys on multi thread, it performance well on machines which have more threads)
### Tasks
- [ ] Add a draft title or issue reference here

Is it possible for different bundler teams to maintain a shared benchmark?

Is it possible for different bundler teams to maintain a shared benchmark?

yes, a neutral benchmark is more fair than benchmark owned by some bundler teams.

https://github.com/web-infra-dev/performance-compare


Reflections

Reflections can currently be done using scaled with -1 as one of the scale factors.  But to better match the 8th grade math education standards, it would be nice if it were called reflection.  This is similar to how we added a dilated function which matches the word used in the common core, and also always preserves similarity (which we don't care much about, but is important in the common core standards when talking about geometric transformations).  There are two possibilities for an API:
Choice 1:
reflectedX :: Picture -> Picture
reflectedY :: Picture -> Picture

Choice 2:
-- Second argument is the angle of the line across which to reflect the image.
reflected :: (Picture, Number) -> Picture

I prefer choice 1, on the basis that it's simpler, and that more complex transformations can be done by composing with rotation.  This is analogous to how we always rotate around the center, but rotations around other points can be accomplished by composing with translations.

I'm not sure if this is worth increasing the API surface area.  Just wanted to get the idea written down.

FWIW, here's my two cents.
Not to be contrarian, but I actually like the second choice much better.
First, reflectedX is a really ugly name, and it is not much shorter than reflected(,0),
and similarly for reflectedY vs. reflected(,90)
Second, the fact that students can change just the number to see reflections along other axes opens a lot
of possibilites for easy exploration. I'd really like having such a function, and the exercise
showing that the effect of an arbitrary reflected is equivalent to composing a single fixed reflection with a variable
rotation would be really useful for high school students.
On Sat, Oct 20, 2018 at 11:36:18AM -0700, Chris Smith wrote:

Reflections can currently be done using scaled with -1 as one of the scale factors.  But to better match the 8th grade math education standards, it would be nice if it were called reflection.  This is similar to how we added a dilated function which matches the word used in the common core, and also always preserves similarity (which we don't care much about, but is important in the common core standards when talking about geometric transformations).  There are two possibilities for an API:
Choice 1:
reflectedX :: Picture -> Picture
reflectedY :: Picture -> Picture

Choice 2:
-- Second argument is the angle of the line across which to reflect the image.
reflected :: (Picture, Number) -> Picture

I prefer choice 1, on the basis that it's simpler, and that more complex transformations can be done by composing with rotation.  This is analogous to how we always rotate around the center, but rotations around other points can be accomplished by composing with translations.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/google/codeworld/issues/757

Thanks for the feedback.  Don't worry about being contrarian!  One of the reasons I speculate out loud about these things is to get more thoughts about what is most useful.  There's also the perspective that having reflection about an arbitrary angle justifies the existence of the function a bit, because it's more than just a scaled with fixed arguments.

@alphalambda
I started trying to implement this last night, but realized I don't know what the argument should mean.  What you expect to get from, say, reflected( (1, 1), 0 )?  I could see two answers:

(-1, 1), because the point is reflected in the direction of the x axis.
(1, -1), because the point is reflected across the x axis.

May I suggest we at least document the fact that scaled can be used for reflection? I imagine the use case of a student who knows to search for "mirror" and "reflect" in the doc but not necessarily aware of the issue tracker.

Yes, that's a great idea.  If you send a pull request, I'll merge it, or I can try to get to it in the next couple days.

Surveying existing online tools, I see:

Specifying a reflection line using a pair of points.
Offering a choice of specific reflections across the X axis, Y axis, "the origin" (which means both), or the y=x line.

The former is common for interactive activities where students can drag the points and see the effects in real time.  It seems inappropriate here to ask a student who knows the direction they want to reflect in to invent points to represent it.  The latter is common for more symbolic exercises, but it seems too limiting for us as discussed above.
I had hoped to find some kind of standard for specifying reflections at an angle, but it doesn't look like anyone else does it that way.

Okay, wikipedia says: "Let a reflection about a line L through the origin which makes an angle θ with the x-axis be denoted as Ref(θ)."  So I'll go with that as enough authority here.  That means that reflectedPoint((1, 1), 0) = (1, -1).


Add tracking of SetTokenFactories

Add isValidFactory mapping
Add addFactory and removeFactory methods
Add associated unit tests

LGTM

Pull Request Test Coverage Report for Build 186

2 of 2 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.2%) to 90.816%

Totals

Change from base Build 185:
0.2%

Covered Lines:
58

Relevant Lines:
64

💛  - Coveralls


TODO: refactor out auto module detection handlings

The discussion has continued from https://github.com/JunoLab/Atom.jl/pull/192#issuecomment-536489355.
In short, we now have 3 alternatives to detect a file's module:

old way based on CodeTools:　https://github.com/JunoLab/Atom.jl/blob/9cf10173e4c5727451e43950872d6cdb3795c720/src/eval.jl#L13-L39
Revise-like approach:　https://github.com/JunoLab/Atom.jl/blob/9cf10173e4c5727451e43950872d6cdb3795c720/src/utils.jl#L175-L359
CSTParser-based approach:　https://github.com/JunoLab/Atom.jl/blob/9cf10173e4c5727451e43950872d6cdb3795c720/src/goto.jl#L185-L205

1 is being used for module handler, 2 and 3 are being used for the recent goto (and renamerefactor, in the future) handler.
The main purpose of this refactor is to implement a more robust module detection logic in the module handler by replacing 1. with something like a combination of 2. and 3.
Or at least, since 1. and 3. are kinda duplicated works, so we want to unify the logic. (and this will hopefully leads to less JIT compiles)
We may need to significantly refactor the frontend code as well -- it's old too.
@pfitzseb can you bundle the related issues here (link to an issue report if exists or just list the random confirmed cases), so that we can easily check if we could address them by this refactor ?
P.S. Feel free to edit this issue for the future reference. We want more structured information for this.

This commit adds naive tests for 2 and 3, including broken cases. I may move this into another PR though.

https://github.com/JunoLab/Atom.jl/pull/210 serves as a preparation for this.

A little interesting fact on this: both modulefiles(mod::Module) and CSTParser-based module traverse runs in almost the same amount of time:
I changed these lines into
const profile_id = Ref{Int}(0)

function _collecttoplevelitems(mod::Module)
  profile_id[] += 1
  return if profile_id[] % 2 === 0
    # Revise-like approach
    entrypath, paths = modulefiles(mod)
    __collecttoplevelitems(stripdotprefixes(string(mod)), [entrypath; paths])
  else # CSTParser-based approach
    entrypath, line = moduledefinition(mod)
    __collecttoplevelitems(stripdotprefixes(string(mod)), entrypath)
  end
end

and precompiled Atom module (to make sure modulefile works for Atom module), and then profiled globalgotoitems` like below
Juno.@profiler begin
  for i = 1:30
    Atom.globalgotoitems("SYMBOLSCACHE", Atom, nothing, "")
    Atom.clearsymbols()
  end
end

, which would cause both Revise-like module file finding and CSTParser-based module traverse in turn.
And the profiling yielded that almost most same amount of time were spent on entrypath, paths = modulefiles(mod) and __collecttoplevelitems(stripdotprefixes(string(mod)), entrypath) (CSTParser-based module traverse), which means both ways work differently but there is no much difference between their performances.

As for goto, obviously CSTParser-based module traverse is better since we have to call toplevelitems anyway even if Revise-like file revealing succeeded. But in reality they are only called once for each module, so this won't be a big deal anyway.


Issue 26: When making a request for user object with 'enterprise' field, null value causes a crash.

We should be allowing null, and supressing it as nil.

https://github.com/box/box-ios-content-sdk/issues/26

Verified that @RicoYao has signed the CLA. Thanks for the pull request!

@boxtcarpel please review. Thanks.

+2 LGTM
:floppy_disk:


inv_freq of RotaryPositionEmbedding is hard-coded to 10k

theta in inv_freq of RotaryPositionEmbedding is hard-coded to 10k
https://github.com/NVIDIA/TransformerEngine/blob/50e7a3da8f3e04a054c9c7212bd80f71c6814a25/transformer_engine/pytorch/attention.py#L1371-L1377

@sudhakarsingh27 Could you take a look at it?


False "unsafe server" flagging?

Modloader
Fabric
Minecraft Version
1.19.2
Modloader Version
14.9 / 0.62
No Chat Reports Version
1.19.2-v1.13.5
Modpack Info
No response
The latest.log File
No response
Bug Description
In this scenario i used MCC Island server.
Without the mod joining the server sends that "unsafe server" popup bullshit
With the mod I get message below

It doesn't sound quite right to me because of the popup, feel free to correct me.
Steps to Reproduce

Join play.mccisland.net with the mod
That's it

Other Information
No response

It all depends on server configuration. While it's not possible in vanilla, server can, in principle, demand players to send signed messages without making itself obliged to actually relay them. There is nothing NCR can do about that.

Could we at least force it to work on certain server?

Depends on what you mean by that. I don't see a point to make any adjustments here since server demanding signatures is inherently unsafe, whether it shows those signatures to most players or not. So this is not a "false warning".


[CL][Incentives] implement helper for counting balancer pool towards full range shares

Closes: #XXX
What is the purpose of the change
This PR implements prepareBalancerPoolAsFullRange, which adds the canonical Balancer pool for a given CL pool as a full range position to the CL pool's uptime accumulators. The second helper, which will be implemented next, will handle the logic for claiming rewards and distributing them to the LPs of the balancer pool.
Brief Changelog

Implement and test prepareBalancerPoolAsFullRange

Testing and Verifying

All new changes are tested in incentives_test.go or in the relevant test files (e.g. for helpers that were added)

Documentation and Release Note

Does this pull request introduce a new feature or user-facing behavior changes? (no)
Is a relevant changelog entry added to the Unreleased section in CHANGELOG.md? (no)
How is the feature or change documented? (not documented)

Converted to draft as I discovered an issue with how accumulators were being updated. Will reopen once fixed.

Looks like the original version of this PR actually handled the issue quite well – false alarm!

Added the cases suggested by @p0mvn – would like an ack prior to merging just to make sure they were all properly addressed


Improve the speed of load_file and save_file in Postgres

During testing, we found that the load speed of dataframe -> postgres to be fairly slow. We believe that there should be a faster native way to load data into postgres.
Acceptance criteria:

A notable speed improvement on postgres load and save numbers in the load and save file
detailed instructions for users to add any needed extensions to their database that would enable these features (e.g. s3 support)

We can use Postgres COPY. We can write a custom callable for method in to_sql and modify it to use Postgres COPY
References:
https://stackoverflow.com/a/64883481/6340775
https://towardsdatascience.com/upload-your-pandas-dataframe-to-your-database-10x-faster-eb6dc6609ddf
Can I go ahead with this approach?

In order to implement this feature, I ended up refactoring several parts of the code, so we can iterate and move forward in the next tickets related to load:

Add constants to represent file type and file location: #223
Add a module to handle file functions # 224
Add a module to handle path functions # 225
Add a module to handle database functions, extending to have a constant to represent databases #228

The following PRs are still being cleaned up and will soon be ready for review:
5. Add a module to handle load operations
6. Add a module to handle deletion
7. Refactor load file to use the new functions

Add a module to handle deletion: #246

And one last PR to wrap up this task...!

Today I learned that  psycopg copy_from does not parse correctly column values that have double quotes and commas inside them, raising:
psycopg2.errors.BadCopyFileFormat: extra data after last expected column

I am now using the method copy_expert and running into other edge cases while attempting to process the Github timeline dataset. I have the hope to find a configuration that will work for this dataset.

We split into two new tasks:

https://github.com/astronomer/astro-sdk/issues/431
https://github.com/astronomer/astro-sdk/issues/428


[Feature request] Support for More Detection Methods

Absolutely beautiful page! I really love the style!
However, I'm missing PING monitoring and database connection checks!

supports ping now
https://kener.ing/docs#h2ping-monitor


Edit API Endpoint - RATA Summary Data

Create API endpoint for Edit for RATA Summary Data:
Testing Reference Only:
Operating Level Code (Dropdown)
Average Gross Unit Load (Text)
Reference Method Code (Dropdown)
Mean CEM Value (Text)
Mean RATA Reference Value (Text)
Mean Difference (Text)
Standard Deviation Difference (Text)
Confidence Coefficient (Text)
T Value (Text)
APS Indicator (Radiobutton - Yes/No)
APS Code (Dropdown)
Relative Accuracy (Text)
Bias Adjustment Factor (Text)
CO2 or O2 Reference Method Code (Dropdown)
Stack Diameter (Text)
Stack Area (Text)
Number of Traverse Points (Text)
Calculated WAF (Text)

Test Passed


Warn when binary was compiled without optimizations

When switching between branches, it often happens that CMake changes the CMAKE_BUILD_TYPE to Debug, which makes the resulting binary very slow. I have not been able to figure out, yet, why this is the case. I guess that somehow the CMakeCache.txt file is invalidated by changing the branches, and that this leads CMake to ignore the configured build type.
I would like to avoid that anyone benchmarks a strobealign binary compiled without optimizations, so until we’ve solved this, I’d like to print a fat warning when the build type is Debug.

Ok to merge this?

yes! sorry forgot to thumbs up.


Can node_modules be cached if a Node.js version is supplied?

Description:
As I understand the documentation about caching both in this repo and in the upstream actions/cache repo, the reason node_modules is not recommended to cache is because dependencies can break across versions of Node.js.
If the Node.js version changing is the only reason not to cache node_modules can this action take into account the node-version-file (or maybe even the node-version)? If it doesn't exist, don't cache the node_modules directory. If it does exist, cache the node_modules directory but use the value as part of the primaryKey: https://github.com/actions/setup-node/blob/f099707f6e7a91b89cdebdeca599fc76cc8bf088/src/cache-restore.ts#L39
Maybe as like:
const primaryKey = `node-cache-${platform}-${nodeVersionFileHash}-${packageManager}-${fileHash}`;

If the Node.js version changes, the cache should be invalidated and everything rebuilt. Which seems to address the concern the actions/cache repo points out (as I understand it).
Justification:
The current caching strategy doesn't provide a noticeable improvement for non-trivial projects. It'll shave a couple seconds off of a multiple minute build due to needing to download all of the node_modules directory. Ideally, by caching node_modules when it appears safe to do so, the download of node_modules shouldn't need to happen as frequently and caching can save minutes.
Are you willing to submit a PR?

Yes!

Hello @joneshf. Thank you for your report. For now we're not planing to change caching behaviour for the setup-node action. If you need to cache different path, the recommended solution will be using the actions/cache action.
For now I'm going to close the feature request.

Understood. Thanks for the explanation.

For now we're not planing to change caching behaviour for the setup-node action.

May I know if that has changed and if not, what is the reason?
I offer to do the PR if it's a time problem :)

@dmitry-shibanov would also love to see this built in as an option to the actions/setup-node action, if there's any room for reconsideration for this feature request after a couple of years 👍


Rename UtilTests -> UtilTest.

The name of this class was not idiomatic. This commit fixes it.
I only noticed that the misnamed test class existed after I had already uploaded https://github.com/google/identity-credential/pull/68 :-(
If you merge this pull request, I can redo the commits from that pull request.
Alternatively (easier for me but slightly messier git history), if you merge that pull request, then I'll create a follow-up pull request that merges the two test classes. Up to you.

How about you update #68 so that it adds the new tests to the existing UtilTests class?
Then we can do the rename after it lands.

That seems like it would be exactly the same amount of work (maybe more) as merging this PR now and then changing the other commit to add them to the existing UtilTest.java, and it would lead to a more messy git history because then ALL of UtilTest.java would be touched by the rename commit. So, it seems strictly worse than the other two options. No?
How about you decide which of the two PRs you want to merge first, and then I redo the other on top of that one?

I was thinking a simple rename would be easier to view in the git history vs creation of a second class then moving the code.


Feat/35 implement regex matching

Changes:

In config:

added regexs
removed active_db

In db:

removed set_db() and get_db() and all references to it
added match_db() --> Function that matches item names with db using regex
added db_name parameter to all other functions in db

In cache:

Adjusted JOB_ID_PATTERN and normalize_name() to also work with the ZensusDB and RegioDB item names

In helloworld:

added db_name to logincheck()

In http_helper:

adjusted JOB_ID_PATTERN to be more specific
added db matching to get_data_from_endpoint()
added _get_db_from_user_input() for when matching fails

nb 0_Databases.ipynb might be obsolete?

I just noticed that my objection against the user input is not as strong as I thought because currently, we only use such endpoints in find. And I guess no-one is going to use the Find class in a script or to automate something, this will only be used in an interactive session to search something. Nevertheless, I think the best thing to do would be to specify the database in the Find class and pass it down to the load_data function the same we do it for logincheck etc. So you can either pass a database or if none is given we can try to get the number from the name.
I can implement this idea or leave it to you @PiaSchroeder . I can also fix the tests if you want

I fixed all the tests and updated the branch

I implemented a simple support in the Find class for setting the db parameter, so Find uses db_name to avoid asking the user, everything else should work as it was

Should be clearer now what is open and what not.


why 'babel-runtime' can't support 'regenerator' or 'Object.assign' etc. in v2.8.1

but the vue-cli with old version can support

I found that diff in .babelrc about 'presets'
older version is 'es2015' and the lasted version is 'env',
but installed babel-preset-es2015 and changed the .babelrc as older version, still not work.

I tried Object.assign in my project with the newest template and it did not show any error.
Are you sure that it is the problem of Object.assign?
Did you try install the dependency above and restart the dev server?

Hi.
I tried delete the 'node_modules' and installed all the package noce again, it works.
last but not least, thank you.


Link not working in How to Understand yVault ROI

URL:https://docs.yearn.finance/resources/guides/how-to-understand-yvault-roi
Why we can't use compound or linear interest formulas to estimate yVaults returns is not working

it's working


Freeze drf 3.7

Review

[x] Docs changed README.rst
[x] CHANGELOG.rst Updated
[ ] Delete your branch

superseeded by https://github.com/novafloss/django-formidable/pull/273


Revising remaining tasks

I guess the indentation issue is because of github preview, atomic tasks look good on my system. However, some tasks didn't have a good indentation and I assumed we are going to fix them later.
I dropped link generation tasks and tasks related to fake news score intentionally. I'll check the commits now to make sure I'm not changing anything else.

@swarooprm They're fine. I checked them and deleted files (e.g., files with scruple tasks) were .bak files.

@swarooprm They're fine. I checked them and deleted files (e.g., files with scruple tasks) were .bak files.

Thanks for confirming. The changes look good, but I have not verified all files yet, not able to load them all in github diff.

Thanks for confirming. The changes look good, but I have not verified all files yet, not able to load them all in github diff.

I think you can load the files in each commit separately.

Changes look reasonable to me, the categories look more consistent than before.


DRILL-7917: Update Kafka version to 2.8.0

DRILL-7917: Update Kafka version to 2.8.0
Description
NA
Documentation
NA
Testing
Checked that unit tests pass

@vvysotskyi
Does this PR address the Kafka issue relating to being able to query multiple topics?

@cgivre, no, this one only updates the Kafka version, work for that task is still in progress.

LGTM +1


How to get the color of the highlight?

I am trying to extract highlighted sentences from PDF, some are highlight in green, some red.
And I will need to extract regarding to different colors.
Could anyone help me with that?
I've got resolved highlight info, but I cannot find which part is about color.
{'AP': {'N': PDFObjRef:35},
'Border': [0, 0, 1],
'C': [1, 1, 0],
'CA': 1,
'CreationDate': b"D:20190722204110+01'00'",
'F': 4,
'M': b"D:20190722204110+01'00'",
'NM': b'faf6d63c-3e84-4506-99e2-85ec37a4396f',
'P': PDFObjRef:3,
'Popup': PDFObjRef:36,
'QuadPoints': [246.259,
766.084,
505.495,
766.084,
246.259,
756.073,
505.495,
756.073],
'Rect': [246.259, 756.073, 505.495, 766.084],
'Subj': b'\xfe\xff\x9a\xd8N\xae',
'Subtype': /'Highlight',
'T': b'yyy333',
'Type': /'Annot'}
Thanks a lot for your help!

Hi @pluieciel, thanks for your question. I'm not sure where to look for the color, but perhaps you can use the PDF Reference to find that out.
Let us know when you figured out how to do it. Perhaps we can include an example into our codebase that demonstrates how to extract highlights. This would help others enormously.

Hi @pietermarsman , thanks a lot for your help!!!
I have found the info in the 'PDF Reference' page 607.
So 'C' is the color, and 'C': [1, 1, 0], is in RGB means yellow.

And here is the code I based on to extract highlight:
https://github.com/0xabu/pdfannots


Example: pix2pix

I want to add pix2pix example. We can discuss any question, issue, etc. on here. I already have some work about pix2pix as a draft pr.
Related issue: #192
Related pr: #186

Hi us, thanks a lot for creating this issue so we can discuss your example!
We currently haven't properly documented our examples policy (we will be doing this in the coming weeks), so apologies for that. However, our policy is more or less that the flax repository should contain a few examples of using flax in different domains of ML, without become too biased towards a specific domain (e.g., vision or nlp). In this way, we aim to show the flexibility and usefulness of flax, without getting too much into domain-specific details. If someone implements an architecture that is more involved, then we recommend they put it in a separate repository and we will happily link to it from our examples page. (Although our examples currently aren't in this state exactly yet, we will be fleshing this out more soon.)
Now coming to your example, I think we would probably prefer to first have a base GAN implementation before we get into more specific architectures. However, I think it is great you implemented this, so what do you think about adding this example to a separate repository, so that we can link to it from our "examples" page?
Hope that makes sense, and let me know if you have any questions!

Hi @marcvanzee ,
Thank you for replying.
I understand your thought. I would like to add a separate repository. I had to stop working because of school exams but as soon as I finish I will continue to work on this project.
I'll write my questions here.

Hi @us, I want to close this issue so that we can keep GitHub issues for real open tickets. We should consider making a proper forum for Flax. For now I'll close this issue but feel free to comment more on it if you have more questions.


Functional: split cost in three cases

@PierreMartinon @joseph-gergaud
In the functional setting, split cost declaration into three cases:

[x] Mayer
[x] Lagrange
[ ] Bolza

That is Bolza is NOT instantiated by declaring two costs, one Mayer + one Lagrangian. The idea being that objective is used once to declare the cost. So that, when reused, the semantics is to replace the previous cost. For instance,
objective!(ocp, :mayer,  (t0, x0, tf, xf) -> xf[1], :max)
objective!(ocp, :lagrange, (x, u) -> 0.5u^2, :min)

does not define a Bolza problem (see also min / max issue!) but only (re)defines the problem to be a Lagrange one.
See also: this PR

Ok, I understand the motivation at the higher level, however for the solving it is more convenient to separate the final and running costs (well actually we need this for the direct method). Will you split the bolza cost into the mayer and lagrange parts at the functional level ?

I prefer not to split Bolza into Mayer + Lagrange (see explanation before). I understand it can be convenient internally to code it, but it is better if it's hidden for the user.


./jarvis.sh: line 584: _STT: command not found

Looks like your Jarvis is not properly set-up (you miss the STT engine for the hotword).
Just restart the wizard (and go till the end):
$> ./jarvis.sh -i

And let me know if that works

No answer from @Niunzag since 18 Nov 2016 => Closed


move tag v0.x when creating a new tag

To allow specifying:
      - name: Run release-plz
        uses<EMAIL_ADDRESS>
We should move the v0.x tag whenever we publish a version v0.x.y.
For example, when we publish v0.4.1, the v0.4 tag should point to v0.4.1 ref.

[ ] When done, update mdbook docs.

This should be done. testing on next release


Reorganise global modules and managers

The problem faced currently?
The global modules (routing, lets encrypt) and the managers (admin and syncman) are all over the place right now. The global modules need to be passed around everytime along with the modules object. This makes it difficult to navigate through the source code.
How can we solve it?
I suggest we make the following changes to simplify the project structure.

Move the Global modules to modules > global directory. Currently they are in the utils directory. This will get all the modules in a single modules directory while separating out global modules from the rest.
The reference of the modules should be stored and accesses from the modules object only. Right now we have to pass around the global modules separately. If the modules stores the global modules, it can be the source for all modules. We can have getters and setters in the modules object to interact with the global modules. Note: the global modules will always be created in server.New. They are just stored in the modules object.
Move the managers (admin, syncman) to a top level managers directory. This will be beside the module directory.
While we are at it, we can move the server directory outside of utils and move handlers inside server

If you want this feature to be implemented, give it a thumbs up reaction, so that we can determine which features are important to you.
👍

Done


Disable User-friendly data rendition on /helix-env.json

With https://github.com/adobe/helix-admin/pull/604 we will be generating /helix-env.json which will contain a merged (public) configuration from multiple sources.
I believe this may be the first time we are serving a json file through the pipeline that is not backed by a spreadsheet??
The problem
Currently the sidekick see that we are requesting something with a .json extension and assumes it's in the serialized spreadsheet format and tries to render it using the User-friendly data rendition. The result is an empty page.
Proposed solution
Disable User-friendly data rendition on the path /helix-env.json.

:tada: This issue has been resolved in version 6.8.0 :tada:
The release is available on:

GitHub release
v6.8.0

Your semantic-release bot :package::rocket:


W-12557202 - Support arbitrary response decoding in order to handle binary stream responses

This PR introduces a new HttpRequestOption decodeResponseAs which allows the caller to determine how the response stream should be decoded. Before this change responses were always decoded as utf-8 strings. This remains the default behavior but callers can now specify e.g. decodeResponseAs: 'base64' to have a binary response stream decoded into a base64 string that can then be manipulated as needed.

LGTM. Since we are referring to this prop internally as encoding, can we use that instead of decodeResponseAs?
That's also how got does it: https://github.com/sindresorhus/got/blob/main/documentation/2-options.md#encoding

Updated PR to use encoding instead of decodeResponseAs


Queen Mary's College

https://www.qmc.ac.uk
Emails are @student.qmc.ac.uk

@kblanks Pull request merged, thank you!