NTRs for Esan, Luhya, Maasai, Mende ethnic groups

Hello, we would like to request new terms for 4 of the ethnic groups currently not in HANCESTRO. These are ethnic groups that were sampled in the 1000 Genomes Project.

Esan
Luhya
Maasai
Mende

They would all be a subclass of Sub-Saharan African (http://purl.obolibrary.org/obo/HANCESTRO_0011).

@bonitalam We'd be happy to add these ancestral groups. Could you please provide definitions?

Great, thank you @daniwelter! Here are some definitions
Esan: The Esan people are one of the major ethnic groups in Edo State, Nigeria who speak the Esan language. (PMID:10146569)
Luhya: The Luhya are the second-largest ethnic group in Kenya and are comprised of subgroups that speak a common Bantu language. (PMID: 27813082)
Maasai: The Maasai are an indigenous African ethnic group of semi-nomadic people located in northern Tanzania and Kenya. (PMID:29868928)
Mende: The Mende people are one of the largest ethnic groups in Sierra Leone who speak a language of the Mande branch of the Niger-Congo family. (PMID:15761855)

@bonitalam Based on the definitions you provide, these sound like cultural ethnic groups rather than genetic populations. Would you be able to include a reference to the genetic population groups as well, please?

Sure, let me know if these would suffice:

PMID:28049708: Investigation of phased genomes/haplotypes from three of the populations - Esan, Maasai, and Mende
PMID:22373165: Rare variant density study of Luhya population (vs. six other populations studied in the 1000 Genomes Project)
PMID:26673965: Study of the FcγR variants in various African (including Luhya) and Caucasian individuals

@bonitalam The terms you requested have been created and are included in today's release of HANCESTRO (v2.4). They should propagate to all the usual channels in the coming days. Apologies for the delay in getting this completed.
Could you please let me know which project you intend to use these terms for? I'd like to update the documentation with usage examples.

No problem, thank you for creating these terms @daniwelter!
We are planning on switching to HANCESTRO to annotate the donors we have for the ENCODE project.
I also have another question, and I wasn't sure it was worth opening another issue for so I'll just ask it here. We were wondering how HANCESTRO would advise on annotating multi-ethnic donors? Currently, we just annotate using one term/identifier, and I think it makes sense to change to an array where multiple terms could be used. I assume it would be be difficult to manage making new terms for every potential ethnic combination as needed.

@bonitalam That's a really good question. Multi-faceted annotations are always tricky. If your primary goal is to capture the reported information as closely as possible, I would go down the array/multi-term annotation route. It is however worth remembering that individuals from a complex multi-ethnic background technically no longer fit the definition of each of their individual ancestral groups but rather represent a novel admixture of the component groups. Some admixed ancestral groups, such as Hispanic-Latin American are well-described but I don't think it would be possible or practical to explicitly describe every possible combination of admixture.
As an alternative solution, we created the term admixed ancestry (HANCESTRO:0306) for exactly this purpose. You could include this in lists of terms for multi-ethnic individuals to really highlight that reason behind the multi-term annotation. Would this suit your use case?

Thank you for the input @daniwelter and pointing to that "admixed ancestry" term! I definitely think your suggested approach of using a multi-term annotation route and designating "admixed ancestry" would work for our use case and makes the most sense. I greatly appreciate all your help.


Remember Show Pictures setting per sender

Checklist

[X] I have used the search function to see if someone else has already submitted the same feature request.
[X] I will describe the problem with as much detail as possible.
[X] This issue only contains a request for one single feature, not multiple (related) features.

App version
5.909
Problem you are trying to solve
I would like an option to tell K-9 Mail to save the show pictures setting per sender, like I can do in the Gmail app. I don't mind clicking the Show Pictures button for random emails, but it would be nice to have the option to "always show pictures" based on the sender.
Suggested solution
After clicking Show Pictures, change the button into Always Show pictures (not sure on the exact wording). Gmail says "always show pictures from this sender"
Screenshots / Drawings / Technical details
No response

Duplicate of #1035


[Feature]: Variable material and damage properties along a given direction

What are you trying to do and how would you want to do it differently?
The current material and damage models assume fixed values for parameters such as the elastic modulus, density, and/or critical stretch. However, we would like to implement a variable model in which these properties are assigned based on a given variable (in this case location-dependent).
As I understand the code right now, you can try to use the approach as shown in this example: examples/RVE/RVE_abaqus.yaml, which requires some pre-processing before setting up the input file on your end.
Is it something you currently cannot do? Is this related to an issue/problem?
No response
Implementation details
No response

I've just added the possibility to define Bulk_Modulus, Shear_Modulus, Young's_Modulus, Poisson's_Ratio or Critical_Value in the mesh input file. Those will override related values in the yaml input:
header: x y block_id volume Bulk_Modulus
-1.5 0 1 1.e-01 2.5e+3
-0.5 0 1 1.e-01 3.5e+3
...

Functions in values f.e.: Critical_Value: 10*t for time-dependent values will be discussed asap.

Awesome! Thank you so much @JTHesse for this fast turn around!!

Yes exactly, the calculated elastic material parameters will also be available as output variables, to make sure everything is as expected -> Test yaml

As the location-dependent variables are supported, I'm going to close this. The other feature will be continued here #159

There are several problems in the implementation that has been solved now.


[DIR-616] basics of fileInput component

I need your review
For this component, we have a wrapper, two buttons(left and right section of the input), a hidden input
I introduced the combinedRef which should combine the Refs
I would like to have a feedback on this structure

One issue I have is, that we should not have text in our design components that need to be translated. So in this current example, we would have to make the text "choose file" be passed by a prop.
Wouldn't it be possible to just style the input and not introduce any button? Like in this example.

@stefan-kracht I removed the new component
Just modified the original Input component to handle "type" attribute for "file"

Good job AAron. I was so fixated that this had to be a separate component, that I did not think about it being part of our Input-Component. This makes much more sense. I just made one tiny tiny tiny change to make the styles a bit more structures/readable.


fix(*): fix Mac build error

Description:
When building on Mac, the following errors are shown:
# github.com/docker/docker/pkg/term
../../go/pkg/mod/github.com/docker/docker@v1.4.2-0.20200203170920-46ec8731fbce/pkg/term/tc.go:13:28: undefined: unix.SYS_IOCTL
../../go/pkg/mod/github.com/docker/docker@v1.4.2-0.20200203170920-46ec8731fbce/pkg/term/tc.go:18:28: undefined: unix.SYS_IOCTL
../../go/pkg/mod/github.com/docker/docker@v1.4.2-0.20200203170920-46ec8731fbce/pkg/term/termios_bsd.go:24:31: undefined: unix.SYS_IOCTL
../../go/pkg/mod/github.com/docker/docker@v1.4.2-0.20200203170920-46ec8731fbce/pkg/term/termios_bsd.go:37:31: undefined: unix.SYS_IOCTL

This change is the result of running go get -u<EMAIL_ADDRESS>It looks like both the Docker and Ginkgo modules share a dependency on golang.org/x/sys.

Affected area:

New Functionality      [ ]
Documentation          [ ]
Install                [ ]
Control Plane          [ ]
CLI Tool               [ ]
Certificate Management [ ]
Networking             [ ]
Metrics                [ ]
SMI Policy             [ ]
Security               [ ]
Tests                  [ ]
CI System              [ ]
Performance            [ ]
Other                  [X]

Please answer the following questions with yes/no.

Does this change contain code from or inspired by another project? If so, did you notify the maintainers and provide attribution?
No

Codecov Report

Merging #2043 (4bf5cf4) into main (be9f434) will increase coverage by 0.85%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #2043      +/-   ##
==========================================
+ Coverage   56.26%   57.12%   +0.85%
==========================================
  Files         143      139       -4
  Lines        5792     5674     -118
==========================================
- Hits         3259     3241      -18
+ Misses       2530     2430     -100
  Partials        3        3

Impacted Files
Coverage Δ

pkg/endpoint/providers/azure/provider.go

pkg/endpoint/providers/azure/client.go

pkg/endpoint/providers/azure/vm.go

pkg/endpoint/providers/azure/vmss.go

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update be9f434...4bf5cf4. Read the comment docs.


New field type : source code

To allow people type source code in a better way in the forms, I have made a custom field, and I would like to register it to the list of available custom fields.
Preview

Links
Repo : https://github.com/gwenaelp/vfg-field-sourcecode
NPM : https://www.npmjs.com/package/vfg-field-sourcecode
At the moment, it highlights all files as ".vue" files. I'm looking for ideas to be able to load the good syntax according to what has been set up in the schemas (have that kind of line, but dynamic : https://github.com/gwenaelp/vfg-field-sourcecode/blob/master/src/components/field-sourcecode.vue#L8). I'm still looking for ideas for that, so if you have one, let me know!
More custom fields to come! =D

Thanks a lot ! You are the first custom field (as far as I know).
We are in the process of updating to the v3 so be aware some changes might be needed.

Looks good.
I added the documentation tag to this issue, your field should be added to the README under the "Public Custom Fields" section.


moved cluster init point

moved cluster init point

Codecov Report

Merging #854 (bf8829e) into master (85e0836) will decrease coverage by 0.08%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #854      +/-   ##
==========================================
- Coverage   80.66%   80.57%   -0.09%
==========================================
  Files         132      132
  Lines        4629     4629
  Branches      103      102       -1
==========================================
- Hits         3734     3730       -4
- Misses        895      899       +4

Impacted Files
Coverage Δ

...runtime/akka/actor/ClusterBakerActorProvider.scala
10.41% <100.00%> (-4.17%)
:arrow_down:

...rcontroller/controllers/ControllerOperations.scala
77.35% <0.00%> (-1.89%)
:arrow_down:

...e/akka/actor/process_index/ProcessIndexProto.scala
98.01% <0.00%> (-1.49%)
:arrow_down:

...pes/src/main/scala/com/ing/baker/types/Value.scala
70.58% <0.00%> (+1.17%)
:arrow_up:

...la/com/ing/bakery/baker/InteractionDiscovery.scala
87.23% <0.00%> (+2.12%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 85e0836...bf8829e. Read the comment docs.


macos-latest (macos-12) trufferuby-head (23.1.0-dev-b64cd1d4): native extentsion compiling with both OpenSSL 3.1 and 1.1 include directories.

We see an issue on the macos-latest trufferuby-head case on the GitHub Actions on ruby/openssl. The issue ticket is https://github.com/ruby/openssl/issues/650. I don't know where the issue comes from. But my guess is that the trufferuby-head was built with both OpenSSL 3.1 and 1.1 include directories unintentionally.

Steps to reproduce the behavior

Fork the repository: https://github.com/ruby/openssl.
Push an dummy empty commit to your repository.
Check the macos-latest truffleruby-head case on the GitHub Actions on the repository.

Expected vs. actual behavior
Expected: The case succeeds. There is no compiler warning.
Actual: The case fails. There is a compiler warning.
/Users/runner/.rubies/truffleruby-head/lib/sulong/native/bin/graalvm-native-clang -I. -I/Users/runner/.rubies/truffleruby-head/lib/cext/include -I/Users/runner/.rubies/truffleruby-head/lib/cext/include/ruby/backward -I/Users/runner/.rubies/truffleruby-head/lib/cext/include -I../../../../ext/openssl<EMAIL_ADDRESS>-DRUBY_EXTCONF_H=\"extconf.h\"  -D_DARWIN_C_SOURCE -DTRUFFLERUBY_ABI_VERSION=<IP_ADDRESS><EMAIL_ADDRESS>-fPIC   -Werror=implicit-function-declaration -Wno-int-conversion -Wno-int-to-pointer-cast -Wno-incompatible-pointer-types -Wno-format-invalid-specifier -Wno-format-extra-args -ferror-limit=500  -Werror  -o ossl.o -c ../../../../ext/openssl/ossl.c
In file included from ../../../../ext/openssl/ossl.c:10:
In file included from ../../../../ext/openssl/ossl.h:175:
../../../../ext/openssl/openssl_missing.h:195:11: error: 'TS_VERIFY_CTS_set_certs' macro redefined [-Werror,-Wmacro-redefined]
#  define TS_VERIFY_CTS_set_certs(ctx, crts) ((ctx)->certs=(crts))
          ^
/usr/local/Cellar/openssl@3/3.1.1_1/include/openssl/ts.h:426:11: note: previous definition is here
#  define TS_VERIFY_CTS_set_certs(ctx, cert) TS_VERIFY_CTX_set_certs(ctx,cert)
          ^

I suppose that the problem is both OpenSSL 1.1 include directory<EMAIL_ADDRESS>and OpenSSL 3.1 directory<EMAIL_ADDRESS>are specified in the command line. I assume the truffleruby-head was built with both the include directories.
Logs

https://github.com/ruby/openssl/actions/runs/5580792815/job/15113450849#step:8:91

I suspect that the following codes may cause this issue.
https://github.com/rbenv/ruby-build/blob/35e5d2a29df62213e930e9617894e0a8eed9da70/share/ruby-build/truffleruby-dev#L10
https://github.com/rbenv/ruby-build/blob/35e5d2a29df62213e930e9617894e0a8eed9da70/bin/ruby-build#L1154

Here is an temporary workaround for this issue in Ruby OpenSSL binding repository.
https://github.com/ruby/openssl/pull/652
diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
index 36609e2..4e5def4 100644
--- a/.github/workflows/test.yml
+++ b/.github/workflows/test.yml
@@ -51,6 +51,12 @@ jobs:
         run:  echo "RUBY_OPENSSL_EXTCFLAGS=-Werror" >> $GITHUB_ENV
         if: ${{ !matrix.skip-warnings }}

+      # A temporary workaround to pass the CI case.
+      # https://github.com/ruby/openssl/issues/650
+      - name: remove openssl 3 include directory.
+        run:  rm -rfv "$(brew --prefix openssl@3)/include"
+        if: matrix.os == 'macos-latest' && matrix.ruby == 'truffleruby-head'
+
       # Enable provider search path for OpenSSL 3.0 in MSYS2.
       # Remove when Ruby 3.2 build is updated
       - name: enable windows provider search path

IIRC use_homebrew_openssl has no effect on TruffleRuby, TruffleRuby has its own logic to find the system libssl:
https://github.com/oracle/truffleruby/blob/16db2e64472e5f4d88176ae122815b6b291c0947/lib/truffle/truffle/openssl-prefix.rb
So let's continue in https://github.com/ruby/openssl/issues/650


HV-551 SizeValidatorForCollection should not use generics.

On a side note, why does Hibernate Validator shade in com.googlecode.jtype:jtype instead of just depending on it? The shading breaks debugging, and stopped me from trying to figure out why isAssignable() is failing.

How is 'import com.googlecode.jtype.TypeUtils;' in ConstraintTree working? That class isn't present in 4.2.0.Final.

That's because we use the maven shade plugin to embed the jtype classes in HV (look here). HV-534 will fix that which is a good thing IMHO.

It should be assignable, according to the Java spec. After some digging around in JType to see what's going on, I happened to notice that it actually is assignable in version 0.1.2, and not assignable in 0.1.1. Here's a gist with my test code (https://gist.github.com/9e60db52c2f145fbbcc4). Using a 0.1.1 JType dependency will output false, but 0.1.2 will output true.
So I pulled HV, modified the shading plugin configuration to shade 0.1.2 instead of 0.1.1, rebuilt HV, and sure enough, SizeValidatorForCollection<?> works the way I expected it to initially. So the bug was actually in JType, not in HV.
I admit this is all a bit pedantic, but the one thing that's dead obvious is that the shading plugin made this type of debugging immensely more complicated than it needed to be. A simple  section would have let me bump to 0.1.2 had the JAR not been shaded. Oh well, now we know what's going on. :)

@emersonf nice work :-)
I think you guys convinced me that we should address HV-534](https://hibernate.onjira.com/browse/HV-534). At the same time we can upgrade the dependency.


nixosTests.nano: replace with script using GNU expect

Motivation for this change
cc @NeQuissimus
There was no real reason to have a NixOS test for nano, might as well use the right tool for the job. Not sure if the style I used here (seperate file with callPackage) is encouraged, would like some feedback on that. Should be a lot quicker, easier to run, and work on MacOS as well.
If this is merged I'd love to write some other tests for other popular TUI packages (htop and such)
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[ ] Fits CONTRIBUTING.md.

On macos 10.15
building '/nix/store/9wh82d4kmxz3x1kfvimkrfr69c302vxh-nano-test-expect.drv'...
/nix/store/vg05ysldddwcfxsp0yiw8xzsi4f0kfm4-expect-script/bin/expect-script: line 4: spawn: command not found
/nix/store/vg05ysldddwcfxsp0yiw8xzsi4f0kfm4-expect-script/bin/expect-script: line 5: expect: command not found
/nix/store/vg05ysldddwcfxsp0yiw8xzsi4f0kfm4-expect-script/bin/expect-script: line 8: send: command not found
/nix/store/vg05ysldddwcfxsp0yiw8xzsi4f0kfm4-expect-script/bin/expect-script: line 9: expect: command not found
/nix/store/vg05ysldddwcfxsp0yiw8xzsi4f0kfm4-expect-script/bin/expect-script: line 12: send: command not found
/nix/store/vg05ysldddwcfxsp0yiw8xzsi4f0kfm4-expect-script/bin/expect-script: line 13: expect: command not found
/nix/store/vg05ysldddwcfxsp0yiw8xzsi4f0kfm4-expect-script/bin/expect-script: line 16: send: command not found
/nix/store/vg05ysldddwcfxsp0yiw8xzsi4f0kfm4-expect-script/bin/expect-script: line 17: expect: command not found
/nix/store/vg05ysldddwcfxsp0yiw8xzsi4f0kfm4-expect-script/bin/expect-script: line 20: send: command not found
grep: /tmp/file.txt: No such file or directory

On macos 10.15
building '/nix/store/9wh82d4kmxz3x1kfvimkrfr69c302vxh-nano-test-expect.drv'...
/nix/store/vg05ysldddwcfxsp0yiw8xzsi4f0kfm4-expect-script/bin/expect-script: line 4: spawn: command not found
/nix/store/vg05ysldddwcfxsp0yiw8xzsi4f0kfm4-expect-script/bin/expect-script: line 5: expect: command not found
/nix/store/vg05ysldddwcfxsp0yiw8xzsi4f0kfm4-expect-script/bin/expect-script: line 8: send: command not found
/nix/store/vg05ysldddwcfxsp0yiw8xzsi4f0kfm4-expect-script/bin/expect-script: line 9: expect: command not found
/nix/store/vg05ysldddwcfxsp0yiw8xzsi4f0kfm4-expect-script/bin/expect-script: line 12: send: command not found
/nix/store/vg05ysldddwcfxsp0yiw8xzsi4f0kfm4-expect-script/bin/expect-script: line 13: expect: command not found
/nix/store/vg05ysldddwcfxsp0yiw8xzsi4f0kfm4-expect-script/bin/expect-script: line 16: send: command not found
/nix/store/vg05ysldddwcfxsp0yiw8xzsi4f0kfm4-expect-script/bin/expect-script: line 17: expect: command not found
/nix/store/vg05ysldddwcfxsp0yiw8xzsi4f0kfm4-expect-script/bin/expect-script: line 20: send: command not found
grep: /tmp/file.txt: No such file or directory

wait... what's happening here? Does macos not support shebangs?

https://stackoverflow.com/questions/67100831/macos-shebang-with-absolute-path-not-working/67101108#67101108

MacOS doesn't support shebangs pointing at scripts -- this causes an Exec format error...

stackoverflow.com/questions/67100831/macos-shebang-with-absolute-path-not-working/67101108#67101108

MacOS doesn't support shebangs pointing at scripts -- this causes an Exec format error...

I suppose I'll just sidestep the shebang issue by calling expect directly. Would you care to try again?

Result of nixpkgs-review pr 161707 run on aarch64-darwin 1

This broke the nixos:trunk-combined:tested job (or at least contributed to breaking it: #162317) at
https://github.com/NixOS/nixpkgs/blob/8725b29aa0ff69753d2daef5beb6abb454d29cfc/nixos/release-combined.nix#L101
18bd82edcc752d6a0e6cce1401ba0c81353a03ca removes that line. Since there doesn’t seem to be a way for Hydra aggregate jobs to refer to passthru.tests (due to the stripping performed by hydraJob), we’ll need to keep this in mind when converting some tests to this style.


Number of frames discrepancy for video Tiger1 in OTB100

The original groundtruth_rect.txt file for video Tiger1 contains 354 frames, but OTB100.json hosted on baidu pan contains only 349 frames for it. Is there an update to the original annotations?

Yes, the actual frames used in the original matlab toolkit version is 349 frames.

Thanks for the clarification!


Add documentation for key validation

This documents the difference between the
EVP_PKEY_XXX_check() calls for the default and fips providers.

Checklist

[x] documentation is added or updated
[ ] tests are added or updated

Merged to both, thanks.


What causes there to be no Cache-Control: no-cache header?

In a default WebAPI project, API controller response headers contain Cache-Control: no-cache. When I add an API controller to the MVC 5 Boilerplate template project there is no such response header. What bit of code or config is preventing this?

Specifically, my Startup.ConfigureContainer has the following:
var httpConfig = new HttpConfiguration();
httpConfig.MapHttpAttributeRoutes();
httpConfig.Routes.MapHttpRoute(
    name: "DefaultApi",
    routeTemplate: "api/{controller}/{id}",
    defaults: new { id = RouteParameter.Optional }
);

IContainer container = CreateContainer();
app.UseAutofacMiddleware(container);

// Register MVC Types
app.UseAutofacMvc();

httpConfig.DependencyResolver = new AutofacWebApiDependencyResolver(container);
app.UseWebApi(httpConfig);

And I'm comparing this setup against the VS 2015 template when selecting an API project.

Web API 2 and MVC 5 are different frameworks. The boilerplate MVC 5 template is not intended to be used for building API's.


Try to bind multiple event on the Container, it fails to react except the first event.

For Example :
// ----- Success to recieve event ----
var container = new createjs.Container();
container.addEventListener('goto', this.gotoHandler.bind(this));
container.addEventListener('hidetop', this.hideTopMenuHandler.bind(this));
container.addEventListener('showtop', this.showTopMenuHandler.bind(this));

// ----- Fails to recieve event except 'goto' ----
container.on('goto', this.gotoHandler, this);
container.on('hidetop', this.hideTopMenuHandler, this);
container.on('showtop', this.showTopMenuHandler, this);

Is there anything i'm doing wrong??

Your code looks fine, but I am unable to reproduce. Maybe take another look at your handlers and other code to see if you can identify a problem.
http://jsfiddle.net/7xnfqhg1/


Fixed GPT-125m

GPT-Neo on huggingface has is gpt-neo-125m , training scripts in biencoder/nli-msmacro listed it as gpt-neo-125M throwing errors while training - fixed it to say gpt-neo-125m

Nice! Can you leave the SGPT models with the capitalized M, since that's how they're named on the hub (e.g. SGPT-125M-mean-nli) - then we can merge it 👍

Done @Muennighoff ! Also, on a sidenote, is it possible to make public the wandb runs of your model training and share the link? I am trying to train some custom models and it would be helpful! Thank you!

Sure they're here: https://wandb.ai/muennighoff/sgpt?workspace=

Thank you, much appreciated!


Camera projection

Replaces the less accurate names for the same class from #2530.

Why on earth did you make a separate PR?

Why on earth did you make a separate PR?

Sorry that you feel sad, but my work is done solely by myself (and I started investigating before you sent your pr) through my thinking and isn't really related to your work.

Sorry, but the difference in content is beyond that of simple requests. For example, I cannot request changes for GameRenderer's camera depth field. Also many contributors tend to stay dormant after a request for change unfortunately, or may fail to fulfilling the request.

If you want to contribute, I believe you can keep your pr open but remove your somewhat inaccurate mapping for the camera projection/viewport or whatever this is called. The other two classes are perfectly fine, and I will approve those parts.


fix(version): update ngx-login-client to 0.6.21

@fabric8cd snapshot fabric8-ui is deployed and available for testing at https://fabric8-ui-fabric8-ui-pr-1578.int.rdu2c.fabric8.io


Is this still working?

Hello, the site seems to be down. Is this still operational?

@lmas

Hi, sorry but I have a lack of interest and free time to maintain this old beast so I decided to pull the plug for now.
The old python code hasn't been updated for years and it seems that I never manage to finish the big rewrite (using Go instead). The old code was also hogging the resources on my tiny server and possibly exposing a security hole or two.
Although I haven't decided 100% yet if I should give up making that rewrite...


feat(web-builder): define plugin

PR Details

Description
Add define plugin.
Types of changes

[ ] Docs change / refactoring / dependency upgrade
[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist

[ ] My code follows the code style of this project.
[ ] I have updated changeset
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.

冲突 resolve 一下哈


[improve][misc] Upgrade Jetty to 9.4.56.v20240826

Motivation
Jetty 9.4.56 contains minor improves over the currently used 9.4.54 version.
It's useful to keep Jetty updated although Jetty 9.x is already EoL. (issue to upgrade to newer Jetty version is tracked by #22939, that is postponed).
release notes:

https://github.com/jetty/jetty.project/releases/tag/jetty-9.4.56.v20240826
https://github.com/jetty/jetty.project/releases/tag/jetty-9.4.55.v20240627

Modifications

Upgrade Jetty to 9.4.56.v20240826

Documentation

[ ] doc
[ ] doc-required
[x] doc-not-needed
[ ] doc-complete

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 74.58%. Comparing base (bbc6224) to head (c699bf8).
Report is 637 commits behind head on master.

Additional details and impacted files

@@             Coverage Diff              @@
##             master   #23405      +/-   ##
============================================
+ Coverage     73.57%   74.58%   +1.01%
- Complexity    32624    34076    +1452
============================================
  Files          1877     1937      +60
  Lines        139502   145459    +5957
  Branches      15299    15898     +599
============================================
+ Hits         102638   108492    +5854
+ Misses        28908    28663     -245
- Partials       7956     8304     +348

Flag
Coverage Δ

inttests
27.77% <ø> (+3.19%)
:arrow_up:

systests
24.51% <ø> (+0.18%)
:arrow_up:

unittests
73.94% <ø> (+1.09%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.
see 616 files with indirect coverage changes


[Feat] Mark and exclude IoC which get an delete flag

Why
An IoC in Splunk has a long retention time, and if a user get today a IoC and tomorrow we know that this is a false positive we require a mechanism to exclude or delete the IoC at every search.
What
If an IoC get the delete flag exclude or delete the IoC.
Alternative we can run a search once a week to request all IoCs at TIE and check if the IoC have a delete flag and exist the IoC.
How
n/a

The current implementation with defaults in place, will actually not import non-malicious (severity==0). It will only import >= 1. There is no "deleted flag".
How

[] Refactor the current filtering in tie2index.py so that it is actually readable.
[] setup.xml: the severity should support ranges and validate them
[] keep compatible with current configuration, without adding new
[] document severity ranges in README and in setup.xml

We will also support ranges for confidence, then we have it all covered.


ta.volume.MFIIndicator not working

I am not getting any output for using ta.volume.MFIIndicator. I am getting <ta.volume.MFIIndicator object at 0x000002B30CE1BEC8> as output for that. All the inputs have been correct as for the same inputs, I am getting Chaikin Money FLow Values.

My guess is you didn't run the function. Please check with the following example.
df[f"{colprefix}volume_mfi"] = MFIIndicator(
            high=df[high],
            low=df[low],
            close=df[close],
            volume=df[volume],
            window=14,
            fillna=fillna,
        ).money_flow_index()

Don't know if  you still need it, but in case of other people come here to seek the answer, this is how I manage to work:
df['mfi'] = ta.volume.MFIIndicator(df.High,df.Low,df.Close, df.Volume, window=14).money_flow_index()
This code shows a accurate column with MFI values.


This is a dummy change - do not merge

Just testing webhooks

This is a new comment on the PR

test

test

niraj test comment

test

test


Google Web Fonts

Feature description
Allow user to choose from Google Web fonts. This would be really awesome and "fit" the "web" name. :)
options:

Allow user to add a URL for the Google Font they want (a little wonky)
Allow users to choose from 5-10 selected fonts.
Use 2 for default values and allow user to use a URL to add "custom" choices.

Screenshots / Draws
If applicable, add screenshots and/or draws to help explain your feature request

Yes you're right, and it will let to close https://github.com/isontheline/pro.webssh.net/issues/60 also

Wonderful.apologies for the duplication.

Some fonts will break the terminal columns alignment.
Does it matter?

@isontheline As long as there are monospaced font options that don't break anything, it is fine to have some that do. People can choose if that matters. See macOS terminal

You're right @mbierman
Thank you a lot for your feedback 🙏

Several Mono Nerd Fonts will be added soon :

https://github.com/ryanoasis/nerd-fonts/releases

I'm closing this issue.
Custom fonts can be imported by using an app on the App Store (iFont eg) :

Import the font on the device (must be MONO)
Use the font by creating a new theme inside WebSSH


inspect: requirements engineering

Requirements are to be added as notes to the To do column of the Inspector project (https://github.com/xqueries/xdb/projects/4).

General requirements of the tool:

The tool must be able to read a DB file and provide the details available via the file in a human friendly format.
The CLI is interactive for some commands which enables the CLI to be stateful. Find in depth explanation with specific commands that support this.
The commands that are supported will be in the scope of the data available in the DB file and the supporting engine implementation and will be explained in further requirements.
Auto-completion - auto completion for table names on Tab (or as supported by the CLI library).
Command - Help: Gives a basic explanation on how to use the CLI and on specific commands too.
Command - Overview: Gives a basic idea of the entire file; data on how much space is used, how many tables exist etc - detail in ticket.
Command - page: Usage - page numberOfPage. Gives cell level data on the page, detail in ticket.
Command - table: Usage - table TableName. Display table data as provided by engine.

Adding them to the epic #65 and closing this.


Point out BC in swiper

Hi,
i think it would be nice if you would point out breaking changes of the main Swiper if you upgrade your dependencies.
Cheers,
Toni

HI @MM-Psiiirus , I will add CHANGE LOG from next version. Thanks for your recommendation.


Orphan localities

This branch addresses the DeleteOrphanLocalities script. It is in response to Redmine Support #12199

I don't see any tests for this functionality. Are those hiding on a different branch?

Test has been added


syslog-ng v4.2 upgrade

This is an attempt to upgrade to syslog-ng v4.2 (upcoming version).
Test results (based on ghcr.io/axoflow/syslog-ng:nightly):
https://github.com/MrAnno/splunk-connect-for-syslog/actions/runs/4648012047/jobs/8225829844
TODO:

[x] $(format-json --cast)
[x] syslog-ng type-aware comparisons (check all filters)
[x] FAILED tests/test_beyondtrust.py::test_beyondtrust_parts - assert 2 == 1 (1 failed, 560 passed))

Depends on:

syslog-ng/syslog-ng#4415
syslog-ng/syslog-ng#4394
syslog-ng/syslog-ng#4401
syslog-ng/syslog-ng#4390
syslog-ng/syslog-ng#4410

@rjha-splunk SC4S is probably one of the biggest power users of syslog-ng :)
I've found quite a few syslog-ng v4 bugs during the upgrade.
The ci-main GitHub action finally passes on the upgraded image.
Do you happen to have any additional tests worth trying on the image ghcr.io/mranno/syslog-ng-splunk-connector:latest?
If there is any chance of finding any more bugs, I think it would be important to fix them before releasing syslog-ng v4.2.

In the meantime, Alpine-based images with the latest version of syslog-ng are available to test for anyone interested:
https://github.com/axoflow/syslog-ng-docker/pkgs/container/syslog-ng-splunk-connector

In the meantime, Alpine-based images with the latest version of syslog-ng are available to test for anyone interested:
https://github.com/axoflow/syslog-ng-docker/pkgs/container/syslog-ng-splunk-connector

Yes @MrAnno,
We will try these changes with Alpine based image (in this sprint) and are also planning to release beta version of SC4S.

@bparmar-splunk Sounds great, thank you.

@MrAnno,
We have few queries about this upgrade.
Could you please share your availability so that can connect and discuss along with @rjha-splunk ?

@mateuszpierzchala-splunk please review , test on 3.36 and merge in development

@mateuszpierzchala-splunk @rjha-splunk
FYI syslog-ng v4.2.0 has been released.


Is there any way to remove depth data of target's side?

Before opening a new issue, we wanted to provide you with some useful suggestions (Click "Preview" above for a better view):

Consider checking out SDK examples.
Have you looked in our documentations?
Is you question a frequently asked one?
Try searching our GitHub Issues (open and closed) for a similar issue.

All users are welcomed to report bugs, ask questions, suggest or request enhancements and generally feel free to open new issue, even if they haven't followed any of the suggestions above :)

Required Info

Camera Model
{ R200 / F200 / SR300 / ZR300 / D400 }

Firmware Version
(Open RealSense Viewer --> Click info)

Operating System & Version
{Win (8.1/10) / Linux (Ubuntu 14/16/17) / MacOS

Kernel Version (Linux Only)
(e.g. 4.14.13)

Platform
PC/Raspberry Pi/ NVIDIA Jetson / etc..

SDK Version
{ legacy / 2.. }

Language
{C/C#/labview/nodejs/opencv/pcl/python/unity }

Segment
{Robot/Smartphone/VR/AR/others }

Issue Description
<Describe your issue / question / feature request / etc..>
I'm developing example for reconstruct 3d pointcloud of target and I used ICP (point to plane). I worked well but I found some pointcloud of target's side make the output bad. It's maybe the background noise of realsense and I tried to apply removing outlier tool of Open3D but it didn't work.
Here's photo of my output

My question is 'Is there any tool to remove pointcloud of target's side?' In 2D image, I used morphology operation for erode... is there any tool like this?

Hi @hailsong   I considered your iage carefully  My understading of statistical outlier filtering is that it removes detached floating clumps of point cloud data that are separated from the main image.  Therefore it may not help if the points on an edge are untidy but firmly connected to the main body of the cloud.
Could you describe the method that you are usin to generate the Open3D cloud with RealSense please?

@MartyG-RealSense Hi! Thanks for responding.
Firstly, I got pointclouds through pipeline and cropped my ROI (in this case, the target was a person). I saved it in .ply file.

(pointcloud from realsense)

(cropped pointcloud data, I saved it to .ply file)
Than I opened .ply file through open3d.io.read_point_cloud and apply ICP Multiway registration.
And I found some noise of pointcloud and I guessed this is noise from background (or maybe motion blur?)

gray pointclouds are the trash pointcloud (it's on my nose) (and its color is from background. my labs wall is gray color.)

@MartyG-RealSense
I tried realsense's built-in filter RSM - threshold remove (?) to reduce this kind of noise.

I can reduce it but I lose some correct pointcloud data..

If you are creating the ply file in the RealSense Viewer and then opening it in Open3D, you could try setting the Depth Units option in the Viewer to 0.0001 instead of the default 0.001.  This will create a more zoomed-in view but can reduce depth noise significantly.
You can find the Depth Units option under the Controls sub-section of the Stereo Module options
In the case in the link below, I used a 0.0001 depth unit scale to create a textured point cloud in the Viewer's 3D mode that had much less noise than when using the default 0.001 scale.
https://github.com/IntelRealSense/librealsense/issues/8228

Your solution makes it better! but I still have some noise of it.

Under the Depth Controls section of the Advanced Controls options in the Viewer, does setting DS Second Peak Threshold to zero reduce the amount of loose dots on your image?

Hi @hailsong  Do you require further assistance with this case, please?   Thanks!

@MartyG-RealSense thanks a lot!

Is your problem solved now, please?  Thanks!

Case closed due to no further comments received.


Rename packages, repository please

Packages
@plainsheet/plain-bottom-sheet-core -> @plainsheet/core
@plainsheet/react-plain-bottom-sheet-> @plainsheet/react
Repository
plainsheet/plain-bottom-sheet -> plainsheet/plainsheet

Thank you for the issue! It helped me a lot to clean the clutter I've made.
Here are the new website and the repository links that address the issues.

the repo
the new website

Thank you for the issue! It helped me a lot to clean the clutter I've made.
Here are the new website and the repository links that address the issues.

the repo
the new website

Rename ReactPlainBottomSheet to PlainBottomSheet of @plainsheet/react

I wondered if it should be renamed Sheet because that would imply it could be positioned on any side of the screen.
So this is not just about the name but also the design decision.
Here are some things that should be considered.

The bundle size. Supporting all use cases for each position will make the package bloated.
Each use-case differs, so supporting an all-in-one module might be too complex and go against the Single Responsibility Principle.

But these are merely assumptions, so let me prototype first and see if I can extend the ReactPlainBottomSheet to Sheet.
As always, thank you for the great suggestions.

I wondered if it should be renamed Sheet because that would imply it could be positioned on any side of the screen. So this is not just about the name but also the design decision.
Here are some things that should be considered.

The bundle size. Supporting all use cases for each position will make the package bloated.
Each use-case differs, so supporting an all-in-one module might be too complex and goes against the Single Responsibility Principle.

But these are merely assumptions, so let me prototype first and see if I can extend the ReactPlainBottomSheet to Sheet.
As always, thank you for the great suggestions.

Then BottomSheet?

Sounds good, @manudeli. I've updated module names as you suggested
: PR


improvement lettuce plugin

Please answer these questions before submitting your issue.

Why do you submit this issue?
[ ] Feature or performance improvement

Requirement or improvement

Please describe about your requirements or improvement suggestions.
Lettuce plugin can only display command type, not specific key,like jetty plugin

Contribution is welcome. This should not be hard.

Contribution is welcome. This should not be hard.

ok,thank you,then i will don`t need submit a pull request


tests: Parameterize some tests in alerts_tests.py

SUMMARY
One of the best practices in making tests easier to maintain is to separate test data and test code using data driven testing. In Pytest specifically that can be achieved using test parameterization.
This PR addresses that issue for tests in alerts_tests.py.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TEST PLAN
In one terminal run docker-compose up
In another terminal ensure Python 3.7 is activate
Create and activate a virtual environment
In the root of the project run:
pip instal -r requirements/local.txt
pip install -r requirements/testing.txt
./scripts/tests/run.sh --module tests/alerts_tests.py
ADDITIONAL INFORMATION

[ ] Has associated issue:
[ ] Changes UI
[ ] Requires DB Migration.
[ ] Confirm DB Migration upgrade and downgrade tested.
[ ] Introduces new feature or API
[ ] Removes existing feature or API

Codecov Report

Merging #11313 into master will decrease coverage by 5.75%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #11313      +/-   ##
==========================================
- Coverage   65.61%   59.85%   -5.76%
==========================================
  Files         834      394     -440
  Lines       39565    24924   -14641
  Branches     3610        0    -3610
==========================================
- Hits        25961    14919   -11042
+ Misses      13495    10005    -3490
+ Partials      109        0     -109

Flag
Coverage Δ

#cypress
?

#javascript
?

#python
59.85% <ø> (-0.93%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

superset/db_engines/hive.py
0.00% <0.00%> (-85.72%)
:arrow_down:

superset/databases/commands/create.py
31.91% <0.00%> (-59.58%)
:arrow_down:

superset/db_engine_specs/hive.py
53.90% <0.00%> (-30.08%)
:arrow_down:

superset/views/database/mixins.py
59.64% <0.00%> (-22.81%)
:arrow_down:

superset/db_engine_specs/presto.py
69.76% <0.00%> (-12.32%)
:arrow_down:

superset/db_engine_specs/mysql.py
79.59% <0.00%> (-12.25%)
:arrow_down:

superset/databases/commands/update.py
85.71% <0.00%> (-8.17%)
:arrow_down:

superset/databases/dao.py
94.11% <0.00%> (-5.89%)
:arrow_down:

superset/databases/api.py
83.49% <0.00%> (-5.88%)
:arrow_down:

superset/views/database/validators.py
78.94% <0.00%> (-5.27%)
:arrow_down:

... and 461 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update afee008...d294a9a. Read the comment docs.

It also looks like you need to run black on the changed file to get a clean build.

Unrelated test is failing, I'd recommend rebasing.


Can we close 6868 port due to Poodle Vulnerability problem?

We got a security warning where 6868 port (used by Bosh Agent in the director VM) is affected by Poodle Vulnerability. So we want to confirm with Bosh community whether this port is still useful after director is deployed. To solve this security issue, we consider to set iptable to block inbound access to this port if it's no use, or is there a better way you guys could advise. Thanks.
CC @maximilien

Changes were made to bosh-agent some time ago to address this problem: https://github.com/cloudfoundry/bosh-agent/blob/master/httpsdispatcher/https_dispatcher.go (and https://github.com/cloudfoundry/bosh/commit/9ec67d528e051a4ccb4081be2ddb7d60c17d26a7)
I've also checked with https://github.com/jvehent/cipherscan to see which protocols are supported and SSLv3 is now shown.
$ ./cipherscan my-ip:6868
Warning: target is not a FQDN. SNI was disabled. Use a FQDN or '-servername <fqdn>'
...............

Thank you, we built the stemcell based on a pretty old bosh release, I will merge this change into our code, and rebuild bosh agent.


Develop

add defaults for all config vars
when in docker container run as user 1000:1000

Codecov Report
Base: 6.17% // Head: 6.91% // Increases project coverage by +0.73% :tada:

Coverage data is based on head (e5838d2) compared to base (f0b7b18).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff            @@
##           master      #4      +/-   ##
=========================================
+ Coverage    6.17%   6.91%   +0.73%
=========================================
  Files          14      14
  Lines         761     767       +6
=========================================
+ Hits           47      53       +6
  Misses        712     712
  Partials        2       2

Impacted Files
Coverage Δ

internal/app/v1/config.go
90.62% <100.00%> (+2.16%)
:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Use maven assembly plugin instead of shade plugin

Framework version: 1.0
Implementations: Jersey / Spring / Spring Boot / Spark

Since using maven shade plugin to create a fat jar is known to be problematic because it can overwrite files by mixing jars (https://product.hubspot.com/blog/the-fault-in-our-jars-why-we-stopped-building-fat-jars), we currently use with success a safer way to deploy lambdas with dependencies: a single zip with all jars in a lib folder (as documented in https://docs.aws.amazon.com/en_en/lambda/latest/dg/create-deployment-pkg-zip-java.html)
Example code of how we do it in maven:
    <plugin>
        <groupId>org.apache.maven.plugins</groupId>
        <artifactId>maven-jar-plugin</artifactId>
        <configuration>
            <finalName>${theapp.brandingToken}-${project.version}</finalName>
            <archive>
                <manifest>
                    <addClasspath>true</addClasspath>
                    <classpathPrefix>lib/</classpathPrefix>
                    <addDefaultImplementationEntries>true</addDefaultImplementationEntries>
                    <addDefaultSpecificationEntries>true</addDefaultSpecificationEntries>
                </manifest>
            </archive>
        </configuration>
    </plugin>

    <plugin>
        <groupId>org.apache.maven.plugins</groupId>
        <artifactId>maven-dependency-plugin</artifactId>
        <executions>
            <execution>
                <id>copy-dependencies</id>
                <phase>package</phase>
                <goals>
                    <goal>copy-dependencies</goal>
                </goals>
                <configuration>
                    <outputDirectory>${project.build.directory}/lib</outputDirectory>
                    <includeScope>runtime</includeScope>
                </configuration>
            </execution>
        </executions>
    </plugin>

    <!-- Assembler to produce ditribution zip -->
    <plugin>
        <artifactId>maven-assembly-plugin</artifactId>
        <executions>
            <execution>
                <id>zip-assembly</id>
                <phase>package</phase>
                <goals>
                    <goal>single</goal>
                </goals>
                <configuration>
                    <finalName>${theapp.brandingToken}-${project.version}</finalName>
                    <descriptors>
                        <descriptor>src/assembly/bin.xml</descriptor>
                    </descriptors>
                    <attach>false</attach>
                </configuration>
            </execution>
        </executions>
    </plugin>

And bin.xml file:
<assembly>
    <id>aws-lambda-package</id>
    <formats>
        <format>zip</format>
    </formats>
    <includeBaseDirectory>false</includeBaseDirectory>
    <fileSets>
        <fileSet>
            <directory>${project.build.directory}${file.separator}lib</directory>
            <outputDirectory>lib</outputDirectory>
            <useDefaultExcludes>true</useDefaultExcludes>
        </fileSet>
    </fileSets>
    <files>
        <file>
            <source>${project.build.directory}${file.separator}${theapp.brandingToken}-${project.version}.jar</source>
            <outputDirectory>lib</outputDirectory>
        </file>
    </files>
</assembly>

Thanks,
Eduardo

Thanks for the feedback @eduramiba - I've been wondering whether it's time to build a Lambda-specific maven plugin to package an application and slim down the output jar as much as possible. I'll keep this open and think it through. I'll definitely look into adding the assembly plugin as an alternative to our samples and archetypes.

Good to know this way to pack it. Thanks @eduramiba !

@eduramiba Thank you! How would you exclude the embedded tomcat in this case?

@Juchar I guess you can use the goal options, https://maven.apache.org/plugins/maven-dependency-plugin/copy-dependencies-mojo.html
But if your dependency has provided scope, it will not be copied as includeScope is runtime.

@eduramiba Ok, thank you.
I changed you approach a little bit and it is also working (you only need to configure the assembly plugin this way):
  ```
<plugin>
    <artifactId>maven-assembly-plugin</artifactId>
    <executions>
      <execution>
        <id>zip-assembly</id>
        <phase>package</phase>
        <goals>
          <goal>single</goal>
        </goals>
        <configuration>
          <finalName>${project.artifactId}</finalName>
          <descriptors>
            <descriptor>src/assembly/bin.xml</descriptor>
          </descriptors>
          <archive>
            <manifest>
              <addClasspath>true</addClasspath>
              <classpathPrefix>lib/</classpathPrefix>
              <addDefaultImplementationEntries>true</addDefaultImplementationEntries>
              <addDefaultSpecificationEntries>true</addDefaultSpecificationEntries>
            </manifest>
          </archive>
          <attach>false</attach>
        </configuration>
      </execution>
    </executions>
  </plugin>

And the `bin.xml`:

aws-lambda-package

zip

false

${project.build.directory}${file.separator}classes

org.springframework.boot:spring-boot-devtools
org.apache.tomcat.embed:*

false
lib

```

I've tried both the suggested examples provided.
The first results in my own code (Handler) to be added to it's own jar, and then along with the other dependecy jars, is put into "lib/" directly inside the zip.
lib/myHandler.jar
lib/dep1.jar
The second example puts all the dependencies in lib/ again, but at the root of the zip the directory structure;
eg:
com/company/Handler.class
lib/dep1.jar
Either way, I get
Class not found: com.company.Handler: java.lang.ClassNotFoundException
I've tried both ways to define the handler:
com.company.Handler
com.company.Handler::handleRequest

What am I missing?
Background
Using the maven shade plugin has been the only way that I could get the deployment to work, but after adding the bouncycastle dependency, I got error:
Error creating shaded jar: Invalid signature file digest for Manifest main attributes
There are suggestions to remove the signatures:
<configuration>
    <filters>
        <filter>
            <artifact>*:*</artifact>
            <excludes>
                <exclude>META-INF/*.SF</exclude>
                <exclude>META-INF/*.DSA</exclude>
                <exclude>META-INF/*.RSA</exclude>
            </excludes>
        </filter>
    </filters>
    <!-- Additional configuration. -->
</configuration>

but surely these will be rejected.
So my conclusion was to find a way to package all the dependency jars as is, hence the suggestions by earlier posts here.

Hi @eugenevd - I'm on the road right now but I'll try to replicate your issue with the Shade plugin and see if we can find a fix on Thursday. As for the assembly plugin questions, I'll let @eduramiba and @Juchar chime in since they clearly know more than me on the topic.

Hi @eugenevd - the assembly configuration I mention above will produce a zip file following these conventions.
For me it worked out of the box. Maybe you could show us the sam.yml, possibly your error is somewhere else?
This is the relevant part from mine:
AWSTemplateFormatVersion: '2010-09-09'
Transform: AWS::Serverless-2016-10-31
Description: My Description
Resources:
  MyServiceFunction:
    Type: AWS::Serverless::Function
    Properties:
      Handler: com.my.function.StreamLambdaHandler::handleRequest
      Runtime: java8
      CodeUri: target/my-function-aws-lambda-package.zip
      MemorySize: 768
      Policies: AWSLambdaBasicExecutionRole
      Timeout: 30
      Events:
        GetResource:
          Type: Api
          Properties:
            Path: /{proxy+}
            Method: GET

Outputs:
  MyFunctionAPI:
    Description: URL for application
    Value: !Sub 'https://${ServerlessRestApi}.execute-api.${AWS::Region}.amazonaws.com/Prod/entity'
    Export:
      Name: MyFunctionAPI

To illustrate my situation, I've forked this project to https://github.com/eugenevd/aws-serverless-java-container and used the springboot pet-store sample as a base.
Therein two branches, one each for each of the examples posted by @eduramiba (branch issue133-comment302648748) and @Juchar (branch issue133-comment399079415)
master contains no changes except for a readme file.
Branch: master
No changes, uses mvn-shade and works as expected (except the issues when adding signed jars like bouncy-castle)
Branch: issue133-comment302648748
This results in a ZIP file that has the dependency jars in lib/ and the handler code in a .jar also in lib/
The result is ClassNotFoundException
Branch: issue133-comment399079415
This results in a ZIP file that has the dependency jars still in lib/ but with the code (as .class files) in the root of the zip.
The result is still ClassNotFoundException
Comments
I've made sure in each case to update sam.yaml to point to the correct zip , as each branch produces a zip file with a different name (switching branches leave behind the zip from the previous build)
packagedeployrun.sh - executes all the steps as outlined by https://github.com/awslabs/aws-serverless-java-container/wiki#deploying-the-sample-applications
To double check, after a deployment, I downloaded the zip files uploaded to the bucket and compared their contents with the "mvn package" produced zip files. These were the same as expected.
--
@Juchar - you asked to see the sam.yaml - see each of those branches.
And yes, the link you posted to the convention is what I've worked with too without success.
@SAPessi No worries. Just to reiterate though; I'm trying to NOT use the shade plugin. If you have a signed dependency jar, these are invalidated when re-arranging that content the way shade does. Which is why I'm after what this issues' examples is about ...

@eugenevd Puh, I checked out the branch and created the zip. After having a look everything looks fine to me. I have to admit that I ran out of ideas, from my point of view it should just work out.

@Juchar So you're also getting errors? The examples posted here by yourself and @eduramiba ; is there a sample where they're working somewhere?

@eugenevd I did just package it, not deploy it. For my lambda in my project the configuration I provided here works fine.

I was hoping to find a working example that I can look at, to compare with, to see where it is that I'm going wrong...

Did you get this resolved?  I've got an issue where if I build it on my local machine, everything works.  But if I build it on CodeBuild, it doesn't work.

@eugenevd , I had a similar issue and solved it with the below settings:
pom.xml:
            <plugin>
                <groupId>org.apache.maven.plugins</groupId>
                <artifactId>maven-dependency-plugin</artifactId>
                <executions>
                    <execution>
                        <id>copy-dependencies</id>
                        <phase>package</phase>
                        <goals>
                            <goal>copy-dependencies</goal>
                        </goals>
                        <configuration>
                            <outputDirectory>${project.build.directory}/lib</outputDirectory>
                            <includeScope>runtime</includeScope>
                        </configuration>
                    </execution>
                </executions>
            </plugin>

            <!-- Assembler to produce ditribution zip -->
            <plugin>
                <artifactId>maven-assembly-plugin</artifactId>
                <executions>
                    <execution>
                        <id>zip-assembly</id>
                        <phase>package</phase>
                        <goals>
                            <goal>single</goal>
                        </goals>
                        <configuration>
                            <finalName>${theapp.brandingToken}-${project.version}</finalName>
                            <descriptors>
                                <descriptor>src/assembly/bin.xml</descriptor>
                            </descriptors>
                            <attach>false</attach>
                        </configuration>
                    </execution>
                </executions>
            </plugin>

bin.xml:
<assembly>
    <id>aws-lambda-package</id>
    <formats>
        <format>zip</format>
    </formats>
    <includeBaseDirectory>false</includeBaseDirectory>
    <fileSets>
        <fileSet>
            <directory>${project.build.directory}${file.separator}lib</directory>
            <outputDirectory>lib</outputDirectory>
            <useDefaultExcludes>true</useDefaultExcludes>
        </fileSet>
        <fileSet>
            <directory>${project.build.directory}${file.separator}classes</directory>
            <outputDirectory>/</outputDirectory>
        </fileSet>
    </fileSets>

</assembly>

This works for me using sam local start-api.
Two changes i made:
1, removed the jar plugin execution as the aws tutorial says we don't need a jar at all.
2, modified the assembly to copy the classes directory as a whole to the zip root.


cordova build process  / splash image expansion

Here are couple of changes that include:

Integration for Cordova build process
Ability to control assets from config.xml (that is used with the build process)
Unlimited platform support via config.xml
Portrait/Landscape Splash image support

Since the change aims to work with the Cordova build process we change the build order to generate images before Cordova builds the rest of the project.
change
hooks/after_prepare/cordova-icon.sh

to
hooks/before_build/cordova-icon.sh

Next, we want to declare the various icons and splash images that Cordova will pick up in the config.xml  file:
example (making sure that each icon/splash image contains width and height):
<platform name="android">
        <icon src="res/android/ldpi.png" density="ldpi" width="36" height="36" />
        <icon src="res/android/mdpi.png" density="mdpi" width="48" height="48" />
        <icon src="res/android/hdpi.png" density="hdpi" width="72" height="72" />
        <icon src="res/android/xhdpi.png" density="xhdpi" width="96" height="96" />
</platform>

More config information can be found here, Apache Cordova Documentation
Finally, after global installation of this project you will be able to run commands like, cordova build android, cordova run ios , etc. to generate icons and build the entire project(s).

Hi,
There is a separate repository for the splash-screens generation: https://github.com/AlexDisler/cordova-splash
Maybe some of your changes would be more relevant there?

Thank you, I will check out this project. Is the intention of both of the projects to eventually run as part of the Cordova build process (getting asset definition from config.xml rather than being hardcoded into the project itself)?
So should it be using config.xml (found in the following link) for file paths and image sizes, Apache Cordova Documentation?

Hey,
Thanks for this pull request.
I'm closing it for the reason given a year ago :clock1:
Something that is great with cordova-icon is that is does not require configuration. It just runs. By requiring to add stuff in config.xml, it adds complexity.
For now, the current behaviour will be kept, but feel free to open a discussion a this specific topic, which will allow me to see what other users think about it.


App returning nil images on iPhone with iOS 11

Hello @zhangao0086
My app works perfectly on the simulator but when i run it on the device, imagePicker returns nil. I am currently using version 3.8.0

@alishafqat do you always get nil?

My teammate also faced with this issue.

Same for me with iPad 2 on iOS 12.4.2. Works great on simulator, iphone x and iphone 5s with iOS 12. Any solution for this?


HTTPException: Deadline exceeded in jp_mobile_carriers.py

This exception happens occasionally:
HTTPException: Deadline exceeded while waiting for HTTP response from URL: http://dengon.docomo.ne.jp/inoticelist.cgi
For URL like this: http://google.org/personfinder/japan/results?role=seek&query=090xxxxxxx
We should handle the exception.

I'm looking into this bug. I think we can just add some try-catch around urllib2.urlopen inside the look_up_number function in jp_mobile_carriers.py (here and here).
My question is: Should we wrap the exception in our own customized exception and raise? Or should just we log about it and return? Current comments on the function say we should throw exception when failed to scrape, though.
Shall we decide on how to handle the exception?

We can either just throw the exception as is (as we currently do) or raise a customized exception. In either case, result.py should catch the exception and show a nicer error message, saying that we encountered an error connecting to our backend.


Feature/encryption nonce

Added encryption nonces and events.
API breaking changes:
TxnRegistryDetails has now been modified to be:
pub struct TxnRegistryDetails<AccountId, Index> {
    pub doubly_encrypted_call: Vec<u8>,
    pub user: AccountId,
    pub nonce: Index,
    pub weight: Weight,
    pub builder: AccountId,
    pub executor: AccountId,
    pub singly_encrypted_call: Option<Vec<u8>>,
    pub decrypted_call: Option<Vec<u8>>,
    pub doubly_encrypted_nonce: Option<Vec<u8>>,
    pub singly_encrypted_nonce: Option<Vec<u8>>,
}

please bump minor version

Done


[BUG] PasswordlessMySQLIT will fail in non-global environment

Describe the bug
Now we have PasswordlessMySQLIT to test our passwordless feature with MySQL,
but it will fail in non-global environment('UsGov,China').

Exception or Stack Trace
error link
 "error": {
      "code": "DeploymentFailed",
      "message": "At least one resource deployment operation failed. Please list deployment operations for details. Please see https://aka.ms/DeployOperations for usage details.",
      "details": [
        {
          "code": "ProvisioningDisabled",
          "message": "This subscription is restricted from provisioning MySQL servers in this region. Please choose a different region or open a support request with service and subscription limits (quotas) issue type."
        }
      ]

error link
com.microsoft.aad.msal4j.MsalServiceException: AADSTS900382: Confidential Client is not supported in Cross Cloud request.
Trace ID: f4a206fb-1178-43a4-910e-05b4f6a43900
Correlation ID: aaa45bf3-0bc1-4ba9-8801-56453e8bce52
Timestamp: 2022-10-12 09:02:45Z
	at com.microsoft.aad.msal4j.MsalServiceExceptionFactory.fromHttpResponse(MsalServiceExceptionFactory.java:45) ~[msal4j-1.13.1.jar:1.13.1]
	at com.microsoft.aad.msal4j.TokenRequestExecutor.createAuthenticationResultFromOauthHttpResponse(TokenRequestExecutor.java:103) ~[msal4j-1.13.1.jar:1.13.1]
	at com.microsoft.aad.msal4j.TokenRequestExecutor.executeTokenRequest(TokenRequestExecutor.java:34) ~[msal4j-1.13.1.jar:1.13.1]
	at com.microsoft.aad.msal4j.AbstractClientApplicationBase.acquireTokenCommon(AbstractClientApplicationBase.java:128) ~[msal4j-1.13.1.jar:1.13.1]
	at com.microsoft.aad.msal4j.AcquireTokenByAuthorizationGrantSupplier.execute(AcquireTokenByAuthorizationGrantSupplier.java:63) ~[msal4j-1.13.1.jar:1.13.1]
	at com.microsoft.aad.msal4j.AcquireTokenByClientCredentialSupplier.acquireTokenByClientCredential(AcquireTokenByClientCredentialSupplier.java:86) ~[msal4j-1.13.1.jar:1.13.1]
	at com.microsoft.aad.msal4j.AcquireTokenByClientCredentialSupplier.execute(AcquireTokenByClientCredentialSupplier.java:49) ~[msal4j-1.13.1.jar:1.13.1]
	at com.microsoft.aad.msal4j.AuthenticationResultSupplier.get(AuthenticationResultSupplier.java:71) [msal4j-1.13.1.jar:1.13.1]
	at com.microsoft.aad.msal4j.AuthenticationResultSupplier.get(AuthenticationResultSupplier.java:20) [msal4j-1.13.1.jar:1.13.1]
	at java.util.concurrent.CompletableFuture$AsyncSupply.run(CompletableFuture.java:1604) [na:1.8.0_345]
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) [na:1.8.0_345]
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624) [na:1.8.0_345]
	at java.lang.Thread.run(Thread.java:750) [na:1.8.0_345]

CheckList

[ ] The PasswordlessMySQLIT must be enabled before closing this issue.

To Reproduce
Steps to reproduce the behavior:
Code Snippet
Add the code snippet that causes the issue.
Expected behavior
A clear and concise description of what you expected to happen.
Screenshots
If applicable, add screenshots to help explain your problem.
Setup (please complete the following information):

OS: [e.g. iOS]
IDE: [e.g. IntelliJ]
Library/Libraries: [e.g. com.azure:azure-core:1.16.0 (groupId:artifactId:version)]
Java version: [e.g. 8]
App Server/Environment: [e.g. Tomcat, WildFly, Azure Function, Apache Spark, Databricks, IDE plugin or anything special]
Frameworks: [e.g. Spring Boot, Micronaut, Quarkus, etc]

If you suspect a dependency version mismatch (e.g. you see NoClassDefFoundError, NoSuchMethodError or similar), please check out Troubleshoot dependency version conflict article first. If it doesn't provide solution for the problem, please provide:

verbose dependency tree (mvn dependency:tree -Dverbose)
exception message, full stack trace, and any available logs

Additional context
Add any other context about the problem here.
Information Checklist
Kindly make sure that you have added all the following information above and checkoff the required fields otherwise we will treat the issuer as an incomplete report

[ ] Bug Description Added
[ ] Repro Steps Added
[ ] Setup information Added

The PasswordlessMySQLIT must be enabled before closing this issue.

As the table shows, for china region, chinanorth3 is the only region all ITs can provision resources except for MySQL,
For now, we need to disable PasswordlessMySQLIT in China Cloud.
This is PR is used to enable PasswordlessMySQLIT in https://github.com/Azure/azure-sdk-for-java/pull/31595/ Public Cloud.


SSMS Scripts 'migrate' fails due to encoding

What version of Flyway are you using?
$ ./flyway.cmd -v
Flyway 4.2.0 by Boxfuse

Which client are you using? (Command-line, Java API, Maven plugin, Gradle plugin, SBT plugin, ANT tasks)

flyway-commandline-4.2.0-windows-x64

What database are you using (type & version)?

Microsoft SQL Server Developer Edition (64-bit)
13.0.4202 SP1
Short: SQL 2016 Developer Edition

Additional software:

Microsoft SQL Server Management Studio 2017

Version: 14.0.17119.0

What operating system are you using?

Windows 10 Pro 64bit OS Build: 15063.483

What did you do?
(Please include the content causing the issue, any relevant configuration settings, and the command you ran)

In SSMS go to a database
1.1 Right Click -> Tasks
1.2 Generate scripts
1.3 create script for one table (to simplify problem): e.g. only data (but doesn't matter)
1.4 move generated script to flyway sql folder and take care of correct syntax and version number.
Open command line
2.1 execute: ./flyway.cmd migrate to import new migration file from generated script (see 1.3)

What did you expect to see?
Sucessfully imported the sql file which was generated by SSMS.
What did you see instead?
Error output:
Successfully validated 3 migrations (execution time 00:00.915s)
SQLServer does not support setting the schema for the current session. Default schema NOT changed to dbo
Current version of schema [dbo]: 2
Migrating schema [dbo] to version 2.1 - BASE-DATA 2008R2
ERROR: Migration of schema [dbo] to version 2.1 - BASE-DATA 2008R2 failed! Changes successfully rolled back.
ERROR:
Migration V2.1__BASE-DATA_2008R2.sql failed
-------------------------------------------
SQL State  : S0001
Error Code : 102
Message    : Falsche Syntax in der N▒he von "?".
Location   : C:/flyway/flyway-4.2.0/sql/V2.1__BASE-DATA_2008R2.sql (C:\flyway\flyway-4.2.0\sql\V2.1__BASE-DATA_2008R2.sql)
Line       : 1

Workaround

Open generated sql file with an editor (eg. VS Code / Sublime)
Change encoding from UTF-16 LE to UTF-8

Additional information
Unfortunately Microsoft is still lacking in giving an option for users to set an encoding for generating scripts.
Open Microsoft Issue
Is this possible for flyway to get around this problem e.g. change encoding on runtime of migrate command or just maybe to inform the user that he has to manually fix the encoding of the file?
Or is it possible to get migrate running with the usage of UTF-16 LE?

Well to solve this problem without changing anything in flyway I can use the flyway configuration.
flyway.encoding=UTF-16LE

so I need to inform the other developers that they create their migration scripts with UTF16-LE encoding.
I leave it to you if you want to close this issue as "not a bug" and maybe just implement a "better" error message when failing due to encoding problems.

Why don't you write a PowerShell script convert the encoding of the file to the target encoding?
I have a sample here for you
https://github.com/chucklu/Scripts/blob/master/Powershell/chuck.psm1
function Convert-EncodingToUTF8NoBOM {
  param(
    [Parameter(Mandatory = $false)]
    [string]
    $targetDir = '.',
    [Parameter(Mandatory = $false)]
    $extension = '*')
  $Utf8NoBomEncoding = New-Object System.Text.UTF8Encoding $False
  $files = Get-ChildItem -Path $targetDir -Filter $extension
  foreach ($file in $files)
  {
    #$file.FullName
    $fileContent = Get-Content -Path $file.FullName
    [System.IO.File]::WriteAllLines($file.FullName,$fileContent,$Utf8NoBomEncoding)
  }
}

It can be invoked like this
Save the following code as Powershell script file with extension .ps1, you can replace the path by yourself
Import-Module ".\chuck.psm1"
$extension = "*.sql"
Convert-EncodingToUTF8NoBOM "." "$extension"

If the versioning matters amongst a team and you need to change the encoding one may also use a text editor (Notepad++).

Open the file in the text editor.
Select 'Encoding' in the menu and then select the encoding type.
Save the file.


EditMonitor.vue changes not propagating

⚠ Please verify that this bug has NOT been raised before.

[X] I checked and didn't find similar issue

🛡 Security Policy

[X] I agree to have read this project Security Policy

📝 Describe your problem
adding a MongDB monitor (based on mysql PR)
after restarting app with node the new monitor doesn't show up in the lov.
untested patch.txt
🐻 Uptime-Kuma Version
1.19
💻 Operating System and Arch
Fedora 35 x86
🌐 Browser
Chrome Version 107.0.5304.107 (Official Build) (64-bit)
🐋 Docker Version
No response
🟩 NodeJS Version
16.14.0

npm run build is needed


Implement Donation Tier Cards

I would like to add Donation Tier Cards. This feature will allow users to easily choose their preferred donation level, providing clear options and benefits associated with each tier.
Currently, users may not have a clear understanding of the different ways they can contribute. By presenting donation tiers in a visually appealing card format, we can improve user engagement and encourage more donations.

I've already added the issue.


Token?

Is the "token" still called token on Slack? There is nothing called "token" in https://api.slack.com/web#auth. All I can do is register an app and generate api key/secret...with which the app fails with {"ok":false,"error":"invalid_auth"} no matter if the app was registered by owner or by admin user.

I think they still call it as "token".

Is your account owner for slack? (not admin user) I expect many issues are raised on this repository if Slack change the policy.

For anyone else who ends up here: Yes, you just use the test tokens, even though Slack tries to convince you never you use your test tokens for any real apps.

@kyletns 👍


Define MPI_ABI and remove MPI_ABI_VERSION

I'm opening this PR to discuss two somewhat separate but related concepts.
Define MPI_ABI macro

We need a way to perform conditional compilation under the ABI. This can be as trivial as #define MPI_ABI 1  if the implementation supports the ABI. This is what MPICH has implemented so far. This is also mpi4py is already taking advantage of. This PR the definition of MPI_ABI to the stubs mpi.h.
As this is primarily and so far about conditional compilation in C, this definition does not apply to Fortran.

Remove MPI_ABI_VERSION and MPI_ABI_VERSION

@hzhou has expressed his opposition to adding MPI_ABI_(SUB)VERSION to mpi.h as an unnecessary leakage of ABI details to the user.
@dalcinl has also expressed concerns about whether MPI_ABI_(SUB)VERSION is ultimately useful, as the each MPI standard implicitly defines the backward compatibility guarantees from the set of added and removed symbols from each MPI standard release.

Comment from @hzhou in favor of MPI_ABI and rejecting MPI_ABI_VERSION https://github.com/mpiwg-abi/header_and_stub_library/issues/28#issuecomment-2002585461.

okay i guess i'll update the latex tomorrow then

@jeffhammond I did not say it explicitly, but then MPI_ABI_get_version() should also be gone from your proposal.
However, I still think we need the MPI_Abi_is_supported(int *flag) query routine (or a slightly better name). If @hzhou objects, I can elaborate.

@jeffhammond I did not say it explicitly, but then MPI_ABI_get_version() should also be gone from your proposal.
However, I still think we need the MPI_Abi_is_supported(int *flag) query routine (or a slightly better name). If @hzhou objects, I can elaborate.

You need a runtime method to query the ABI (implementation)? I think that's fine. But maybe we can make it more general by returning a (registered) ABI enum (MPICH_ABI, OMPI_ABI, MPI_ABI)?

You need a runtime method to query the ABI (implementation)? I think that's fine.

Actually, just a boolean whether the ABI is supported or not. From there, with MPI_Get_version() and MPI_Get_library_version(), users should be able to perform any dispatch they need.

But maybe we can make it more general by returning a (registered) ABI enum (MPICH_ABI, OMPI_ABI, MPI_ABI)?

I would love to have something that. I feel a bit uncomfortable hardwiring in the MPI standard the name of concrete implementations, but practicality beats purity. Not to mention that this may not age well if a brand-new implementation ever appears. Well, a brand new implementation would probably follow just MPI_ABI rather than supporting the standard MPI_ABI and a new brew of their own. Then the standard could advice that MPICH_ABI and OMPI_ABI are the legacy ABIs in widespread use at the time the ABI was proposed. We would just need need to iron-out the exact names and the wording to propose this. BTW, we cannot reuse the name MPI_ABI because that was the macro advertising ABI support.

You need a runtime method to query the ABI (implementation)? I think that's fine.

Actually, just a boolean whether the ABI is supported or not. From there, with MPI_Get_version() and MPI_Get_library_version(), users should be able to perform any dispatch they need.

Okay, so why MPI_Get_library_version() couldn't tell you whether it is the MPI-ABI? BTW, what does supported in MPI_Abi_is_supported mean?

#include <mpi.h>
#ifdef MPI_ABI_VERSION && (MPI_ABI_VERSION >= 1)
#define MPI_ABI 1
#endif


How can I get a full stacktrace/message output with each failing test?

I'm using Testem and my config is simple for now
{
  "framework": "qunit",
  "test_page": "tests/index.html",
  "launch_in_ci": [
    "PhantomJS"
  ],
  "launch_in_dev": [
    "PhantomJS",
    "Chrome"
  ]
}

One thing I've noticed is that I don't get the full stacktrace /message output when phantomjs or chrome run my tests. Is this a language dep/test library specific feature? If not -how can I get this stack information w/ each test?
Thanks for such an amazing project!

Hi, is this still an issue? Are you trying to receive stracktraces in ci or dev mode? I dev they should be printed to your local console as usual.

Thanks for the reply!
If I'm using the broken phantomjs browser (headless) in dev I don't get a stacktrace. Do you know how to configure either testem/and or phantom to dump the stack to the console so I can see it?
Most of my pairing is pure terminal driven (tmux and vim) so only getting these in chrome doesn't help sadly.
Thanks for maintaining this great project!

I'm usually debugging phantomjs using the remote debugger.
$ ./node_modules/.bin/testem dev
$ phantomjs --remote-debugger-port=7777 --remote-debugger-autorun=true ./node_modules/testem/assets/assets/phantom.js http://localhost:7357/

Which allows to open http://localhost:7777 and have an inspector, but I guess this won't really help in your case.
Atm stacktraces aren't serialized and transmitted to the testem server, but it might be possible to implement this. A starting point could be here: https://github.com/airportyh/testem/blob/2e59012a595d20529538e7b7b6957511d2094e28/public/testem/testem_client.js#L169

Great feedback! When I get some bandwidth I'll take your start and look at what a PR might turn into!


fixing coverage by simplifying Annotated import logic

fix #2367

Do you think it's worth changing to depending on typing-extensions>=<IP_ADDRESS> going forward?
That should remove the need for all the custom implementations of get_args, and guarantees availability of Annotated.
I'm unsure if anyone's raised it, but could also prevent issues with type checkers who don't use typing-extensions (Pyright comes to mind here, but I'd have to check if it's an actual issue or not).

This is a change to the Annotated solution implemented in #2147, @JacobHayes are you happy with it?

Do you think it's worth changing to depending on typing-extensions>=<IP_ADDRESS> going forward?

I think that's a good idea @JacobHayes suggested it on the original PR, I'll see how easy this would be now.

Looks ready. @PrettyWood are you happy with this?
I ❤ negative PRs 😍.

@samuelcolvin We could maybe update docs/examples/schema_annotated.py but up to you.
Looks great!

It might be pretty tidy after dropping py 3.6 though, I think(?) the other two are more minor.

#2374


Add new SelectionMode extractAndLink

Please select if your request is either something new or an enhancement

[x] Enhancement of an existing Feature.
[ ] Request of a new feature.

Please select the area your request applies to. (Multiple selections are Possible. You can leave blank if you're not sure.)

[ ] Workspace - VSCode workspace, vaults, Intellisense/autocomplete, Dendron settings
[ ] Lookup - Dendron's Lookup Command
[ ] Views - Dendron Preview, Tree View, Side Panels in the UI
[ ] Schema - Dendron Schemas
[ ] Pod - Data import from / export to Dendron
[ ] Publish - External Site Publish
[ ] Markdown - Markdown features, such as syntax support and features

Is your feature request related to a problem? Please describe
There is a extract
commands:
    lookup:
        note:
            selectionMode: extract

Selection mode.
Which extract the content of the note, but doesn't leave any links from the note it was extracted.
Describe the solution you'd like
Add extractAndLink extraction mode which would leave a link behind to the newly extracted note, when extracting data out of the note.
Describe alternatives you've considered
Coming back to the note which was extracted and adding a link.

Have you tried setting leaveTrace to true in dendron.yml? https://wiki.dendron.so/notes/F9LWJEjscrGkxnYi2JNby/#leavetrace
commands:
    lookup:
        note:
            leaveTrace: true


How to support multiple level of expand

In my application i have Parent View, than Child , than Children of child.
How to make this using lib.

@paul-turner Any update ?

Sorry @ahmedsalemelzeiny, this is not possible with the current library and won't be a focus for us to implement in the near future. :(


Misaligned UI trying to unlock wallet without password

When trying to unlock a wallet without entering a password the UI breaks in a very ugly way. This would be a nice first issue to fix for anyone looking to contribute.
Expected outcome: The input field should stay where it is and not resize / move anywhere.
https://user-images.githubusercontent.com/10026790/166453320-456afe56-1023-4e51-a3f3-2ab45d56fc76.mov

I'll work on this one


Problems loading and saving second screen

Screen2SavingError.txt
I'm getting this error a lot when saving game information after adding a second screen. The screen image should have been loaded in the first place when selecting the game, as it was already there, but it shows as missing.
Only tested with VIC-20 games, don't know if that makes a difference.

Thanks for reporting, I think I have solved this already in the upcoming 1.2.0 release. How did you add the games to the game manager? Did you import them from an existing directory or did you use the scraper?
I found an issue where the game manager assumed that screenshots and covers had the names defined by the maxi game tool, if the files where named in a different way it could not rename the files when saving, thus saying that they are missing. I think this is the issue here.

Thanks for reporting, I think I have solved this already in the upcoming 1.2.0 release. How did you add the games to the game manager? Did you import them from an existing directory or did you use the scraper?
I found an issue where the game manager assumed that screenshots and covers had the names defined by the maxi game tool, if the files where named in a different way it could not rename the files when saving, thus saying that they are missing. I think this is the issue here.

I think this is solved in versino 1.2.0, please try it out.

I think this is solved in versino 1.2.0, please try it out.

Wow, that was fast. I'll try the new version. I did import them from a backup of the files on my stick.

Wow, that was fast. I'll try the new version. I did import them from a backup of the files on my stick.

Sadly the problem is still there. I select a game that doesn't have a second screenshot (even though it is there on disk), select an image for it (which has the exact name used by PCUAE already), then select another game, the application will ask me if I want to save the changes and that's when the error pops up.
Maybe it is trying to save over an existing image but it still has that file locked from failing to load it for some reason? The screenshot is there already in the screens folder of the game manager.

Sadly the problem is still there. I select a game that doesn't have a second screenshot (even though it is there on disk), select an image for it (which has the exact name used by PCUAE already), then select another game, the application will ask me if I want to save the changes and that's when the error pops up.
Maybe it is trying to save over an existing image but it still has that file locked from failing to load it for some reason? The screenshot is there already in the screens folder of the game manager.

Is it a specific screenshot or does it happen all the time? Can you perhaps attach a screenshot file  that fails here so I can have a look if there is some format problems?

Is it a specific screenshot or does it happen all the time? Can you perhaps attach a screenshot file  that fails here so I can have a look if there is some format problems?

It happens every time. But somehow not with all games.
I just found out that if I change the description text instead of adding the screenshot and then select another game, I get a pop-up telling me "The following information needs to be added before saving: Screenshot 2".

It happens every time. But somehow not with all games.
I just found out that if I change the description text instead of adding the screenshot and then select another game, I get a pop-up telling me "The following information needs to be added before saving: Screenshot 2".

I found the problem, it was nothing wrong with the png images. Some tsg files in PCU does not define two screenshots, the game manager did not handle this very well when a game was imported. I have fixed so that it's possible to add a second screenshot now for such games, included in version 1.2.1.

I found the problem, it was nothing wrong with the png images. Some tsg files in PCU does not define two screenshots, the game manager did not handle this very well when a game was imported. I have fixed so that it's possible to add a second screenshot now for such games, included in version 1.2.1.

Awesome! I can confirm that this is working perfectly now, good job!

Awesome! I can confirm that this is working perfectly now, good job!


Opendistro 1.9 crashes for certain instance types RPM/DEB/TAR

Overview
There is a bug for k-NN binary library for ODFE 1.9 for RPM/TAR/DEB artifacts. The library crashes ES on specific machines. For instance, ODFE 1.9 does not crash on m5 and c5 AWS instance types work, however, ODFE 1.9 crashes on m4 instance types.
This is may be due to the environment in which the binary library we distribute is compiled. Currently, we build the library using Github Actions runners. It is possible the binary is compiled to use optimized instructions available on the machine the Github runner uses, which is not available on certain instance types. The binary that we distribute should not contain optimized instructions in order to maximize compatibility.
Repro Steps

Launch AWS EC2 instance with type m4.xlarge
Following this link to install and start RPM or TAR or DEB: https://opendistro.github.io/for-elasticsearch-docs/docs/install/rpm/
Run the following commands:

curl -X PUT "https://localhost:9200/myindex" -u admin:admin --insecure -H 'Content-Type: application/json' -d'
{
  "settings" : {
    "number_of_shards" :   1,
    "number_of_replicas" : 0,
    "index": {
        "knn": true,
    }
  },
  "mappings": {
      "properties": {
        "my_vector": {
          "type": "knn_vector",
          "dimension": 2
        }
      }
  }
}
'

curl -X POST "https://localhost:9200/_bulk" -u admin:admin --insecure -H 'Content-Type: application/json' -d'
{ "create" : { "_index" : "myindex", "_id": "6" } } } }
{ "my_vector" : [1.5, 2.5]}
{ "create" : { "_index" : "myindex", "_id": "3" } } } }
{ "my_vector" : [1.5, 2.5]}
{ "create" : { "_index" : "myindex", "_id": "4" } } } }
{ "my_vector" : [1.5, 2.5]}
{ "create" : { "_index" : "myindex", "_id": "5" } } } }
{ "my_vector" : [1.5, 2.5]}
{ "create" : { "_index" : "myindex", "_id": "6" } } } }
{ "my_vector" : [1.5, 2.5]}
{ "create" : { "_index" : "myindex", "_id": "7" } } } }
{ "my_vector" : [1.5, 2.5]}
{ "create" : { "_index" : "myindex", "_id": "8" } } } }
{ "my_vector" : [1.5, 2.5]}
{ "create" : { "_index" : "myindex", "_id": "9" } } } }
{ "my_vector" : [1.5, 2.5]}
{ "create" : { "_index" : "myindex", "_id": "a" } } } }
{ "my_vector" : [1.5, 2.5]}
{ "create" : { "_index" : "myindex", "_id": "b" } } } }
{ "my_vector" : [1.5, 2.5]}
{ "create" : { "_index" : "myindex", "_id": "c" } } } }
{ "my_vector" : [1.5, 2.5]}
{ "create" : { "_index" : "myindex", "_id": "d" } } } }
{ "my_vector" : [1.5, 2.5]}
{ "create" : { "_index" : "myindex", "_id": "e" } } } }
{ "my_vector" : [1.5, 2.5]}
{ "create" : { "_index" : "myindex", "_id": "f" } } } }
{ "my_vector" : [1.5, 2.5]}
{ "create" : { "_index" : "myindex", "_id": "g" } } } }
{ "my_vector" : [1.5, 2.5]}
{ "create" : { "_index" : "myindex", "_id": "h" } } } }
{ "my_vector" : [1.5, 2.5]}

curl "https://localhost:9200/myindex/_flush" -u admin:admin --insecure

# The following message will be produced
curl: (7) Failed to connect to localhost port 9200: Connection refused

Work around
Currently, the best work around is to build/install the artifact from source following these steps:
git clone https://github.com/opendistro-for-elasticsearch/k-NN.git
cd k-NN
git checkout opendistro-1.9
cd jni
cmake .
make package

# The artifacts will be in this location: k-NN/jni/packages

Hi @jmazanec15,
Is it possible to turn off optimization during compilation?

Hi @vamshin,
Passing the -march=x86-64 flag during compilation should turn off optimization.
Unfortunately, when running cmake to build the library, it does not look like we can override setting of CMAKE_CXX_FLAGS_RELEASE in v1736 or SIMD_FLAGS in v206 with the cmake -D flag to change -march=native flag to -march=x86-64. I believe it is because they are normal variables as opposed to cached variables in CMake.
As a workaround, we could manually edit the CMakeLists file of NMSLIB from the Github Action that builds our library with a sed command in order to change -march=native to -march=x86-64. For example:
git submodule update --init -- jni/external/nmslib
sed -i 's/-march=native/-march=x86-64/g' external/nmslib/similarity_search/CMakeLists.txt
cmake .
make package

I am open to other suggestions.

To install from source on Amazon Linux 2 with RPM:
sudo yum install gcc-c++ cmake git rpm-build -y
export JAVA_HOME=/usr/share/elasticsearch/jdk
git clone https://github.com/opendistro-for-elasticsearch/k-NN.git
cd k-NN
git fetch
git checkout opendistro-1.9
cd jni
cmake .
make package

sudo yum remove opendistro-knnlib -y
sudo yum localinstall packages/opendistro-knnlib-<IP_ADDRESS>-0.1_linux.x86_64.rpm -y
sudo yum install opendistro-knn -y

To install from source on Ubuntu with DEB:
sudo apt install cmake g++ git rpm -y
export JAVA_HOME=/usr/share/elasticsearch/jdk
git clone https://github.com/opendistro-for-elasticsearch/k-NN.git
cd k-NN
git fetch
git checkout opendistro-1.9
cd jni
cmake .
make package

sudo apt remove opendistro-knnlib -y
sudo dpkg -i packages/opendistro-knnlib-<IP_ADDRESS>-0.1_linux.x86_64.deb
sudo apt install opendistro-knn -y


Literal syntax for maps

Most my Lisp experience has been with Clojure, so coming to LFE I find myself wanting a literal syntax for maps.
Clojure uses {:name "Clojure"} for maps, though I feel that would be confusing in LFE as we're used to {} being the tuple syntax for other languages on the BEAM.

There is a literal syntax for maps in LFE (which you can also use in pattern matching): #m(k1 v1 ...).


fix invalid example in use-force-rerender readme

[ ] Related issues linked using fixes #number
[ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
[X] Documentation added
[X] The linting passes

Hello there,
Thanks for your contribution.
But your code has a misspelling as well :)
This is your provided code:
const Component = () => {
  const forceRerender = useForceRerender();

  React.useEffect(() => void DataStore.subscribe(() => void useForceRerender()), []);

  return <>{DataStore.data}</>;
}

You have to change void useForceRerender() to void forceRerender().
I'll wait for you to fix this, then I'll merge it.
Thanks again.


Create LCM.cpp

Added lcm generator from two positive Integer.

Hi, sorry this is so simple to have its own template.


Issue 121 omit perf (WIP)

https://github.com/tjmehta/101/issues/121
Looking into taking care of this issue.
There are several test cases where omit takes certain arguments that are not demonstrated in the documentation.
Example:
omit('foo', 'bar') - support for a partial with variable number of omit key arguments, not demonstrated in documentation
Supporting many permutations of arguments in omit makes the function body more complicated.
Java's polymorphism feature (redefining the function body for different permutations of arguments) is a way another language gracefully handles avoiding this type of complexity.
What if we split omit into two modules, omit and omit-partial to reduce the complexity?
Alternatively, we could use a single module and try this:
var omit = require('101/omit');
var obj = {foo: 1, bar: 2};
omit(obj, ['foo']);
// the partial could be attached to omit directly as an object property.
var omitPartial = omit.partial(['foo'])(obj);

What if we split omit into two modules, omit and omit-partial to reduce the complexity?
So far a lot of 101's utils all support partial functionality out of the box. I would say that making this functions work w/ array methods should be the main supported use case.

It may be just me, but I find myself mostly using FP style when formatting arrays of data.
We may be able to use 101/curry to make supporting partial functionality easier, but that will not work well with supporting a varying number of arguments like omit('foo', 'bar', 'qux')(obj) it would work well with omit(['foo', 'bar', 'qux'])(obj)

already fixed #132


Duplicate definition of django-modeltranslation in requirements.txt

Describe the bug
Duplicate definition of django-modeltranslation in requirements.txt
To Reproduce
Steps to reproduce the behavior:
pip3 install -r requirements.txt
Expected behavior
Successful installation.
Error
ERROR: Cannot install django-modeltranslation==0.18.11 and django-modeltranslation==0.19.9 because these package versions have conflicting dependencies.

The conflict is caused by:
    The user requested django-modeltranslation==0.18.11
    The user requested django-modeltranslation==0.19.9

To fix this you could try to:
1. loosen the range of package versions you've specified
2. remove package versions to allow pip attempt to solve the dependency conflict

Possible fix
#django-modeltranslation==0.19.9
Desktop (please complete the following information):

OS: Ubuntu

@YassineLambarki Fixed, thank you!

@adilmohak
Bumping that library does not fix the problem.
I am surprised you don't see this error.
ERROR: Cannot install -r requirements/base.txt (line 11), -r requirements/base.txt (line 12), -r requirements/base.txt (line 13), -r requirements/base.txt (line 9) and django==4.0.8 because these package versions have conflicting dependencies.

The conflict is caused by:
    The user requested django==4.0.8
    django-model-utils 4.3.1 depends on Django>=3.2
    crispy-bootstrap5 0.7 depends on django>=3.2
    django-filter 23.5 depends on Django>=3.2
    django-modeltranslation 0.19.9 depends on Django>=4.2

To fix this you could try to:
1. loosen the range of package versions you've specified
2. remove package versions to allow pip attempt to solve the dependency conflict

ERROR: ResolutionImpossible: for help visit https://pip.pypa.io/en/latest/topics/dependency-resolution/#dealing-with-dependency-conflicts


Ncf 324

Fix for NCF-324: Don't reopen the HDF5 dataset in put/get_vara() when the variable has the same name as a coordinate.

Merged!


option "show_cursor" stopped working in version 1.9

In kivy version 1.8 I could do two things to hide the mouse cursor:

use Config.set('graphics', 'show_cursor', 0) # or set it in the kivy.ini
use pygame.mouse.set_cursor to load a "empty" mouse image.

Now in version 1.9 none of the solutions works.
When I revert back to kivy 1.8 my code works again and the cursor is hidden (I'm using option 2 as option 1 disables the touchscreen also)
Here's a small code example, the cursor is always shown.

__author__ = 'stas Zytkiewicz<EMAIL_ADDRESS>
from kivy.config import Config
Config.set('graphics', 'show_cursor', 0)
# I use fullscreen to check that the config setting really works
#Config.set('graphics', 'fullscreen', 1)

import kivy

kivy.require('1.0.7')

from kivy.app import App
from kivy.uix.button import Button
from kivy.uix.floatlayout import FloatLayout

class Screen(FloatLayout):
    def __init__(self):
        FloatLayout.__init__(self)

    def cbf(self, *args):
        print "Button Pressed..."

class TestApp(App):
    def __init__(self):
        App.__init__(self)

    def build(self):
        scr = Screen()
        but = Button(text='A button, press me !',
                     pos_hint={'center_x': 0.5, 'center_y': 0.5},
                     size_hint=(0.20, 0.2),
                     on_press=scr.cbf)
        scr.add_widget(but)
        return scr

if __name__ == '__main__':
    TA = TestApp()
    TA.run()

---
Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/22341874-option-show_cursor-stopped-working-in-version-1-9?utm_campaign=plugin&utm_content=tracker%2F42681&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F42681&utm_medium=issues&utm_source=github).