Allow 0 retries

Can we add a unit test for this?
Can you document what happens when you use 0 retries? I expect the job will not be retried regardless of the failure, including a mea culpa failure. Is that the case?

Also, I believe you will need to rework how "retries-remaining" is calculated since it will now be negative when max-retries = 0

@wyegelwel I added a new field instead of using 0 for max-retries: that's more clear to me.
Also added a unit test to verify the behavior

I think it is more clear once a user is aware of mea culpa reasons (and the flag). Retries == 0 is more discover-able and clients built on top don't need special logic for the 0 retries case.
I'm not sold either way. Anyone else have an opinion?

I like differentiating between user configured retries/attempts and cook triggered (mea culpa) retries.The latter we can configure it to be whatever value in cook configs and user can choose to disable or override.

I like differentiating between user configured retries/attempts and cook triggered (mea culpa) retries.The latter we can configure it to be whatever value in cook configs and user can choose to disable or override.

I think in this regard, renaming max-retries to something like "attempts" would be more informative. I'm not sure I care enough to fight for retries == 0 if you feel strongly in this direction. Please document this flag and explicitly note the 0 retries use case.

Also added documentation to scheduler-rest-api.asc


V1 validated submit cannot read submitted of undefined

when submitting a validated form that has a missing required field an action is fired "rrf/batch" which throws "cannot read property 'submitted' of undefined.
import React, { Component, PropTypes } from 'react';
import { connect } from 'react-redux';
import { bindActionCreators } from 'redux';
import { inviteManager } from '../actions';
import { getAuthAccount } from 'shared/auth';

import classnames from 'classnames';
import validator from 'validator';
import { Form, Field } from 'react-redux-form';
import { isValid } from 'react-redux-form/lib/form';

import '../styles/InviteManager.scss';

class InviteManagerForm extends Component {

  constructor(props) {
    super(props);
    this.handleSubmit = ::this.handleSubmit;
  }

  static get propTypes() {
    return {
      inviteManager: PropTypes.func.isRequired,
      account: PropTypes.object.isRequired,
    };
  }

  handleSubmit(data) {
    console.log(isValid(this.props.invites), data);
    return this.props.inviteManager(data, this.props.account.id);
  }

  render() {
    const fieldsetClasses = classnames(
      'form-group',
      {
        'has-danger': false,
      });
    const inputClasses = classnames(
      'form-control',
      'form-control-danger',
    );
    return (
      <Form ref="inviteManager" model="shared.unclaimed.inviteManager" className="invite-manager-form" onSubmit={this.handleSubmit} >
        <fieldset className={fieldsetClasses}>
          <Field model="shared.unclaimed.inviteManager.to"
                 className={fieldsetClasses}
                 validateOn="blur"
                 validators={{
                   required: (val) => val && val.length,
                   isEmail: validator.isEmail,
                 }}
          >
            Email Or Mobile Number
            <input type="text" className={inputClasses} />
          </Field>

        </fieldset>

        <fieldset className={fieldsetClasses}>
          <Field model="shared.unclaimed.inviteManager.message">
            Personal Message
            <textarea type="textarea" name="message" label="Personal Message" rows="10"
                      className={inputClasses}></textarea>
          </Field>
        </fieldset>
        <button type="submit" className="btn btn-primary pull-right">Send Invite</button>
      </Form>
    );
  }
}

export default connect(
  // State to send to the Component as props
  (state) => {
    return {
      invites: form(state.shared.unclaimed.inviteManager),
      account: getAuthAccount(state),
    };
  },
  // Dispatch functions to send to the Component as props
  (dispatch) => bindActionCreators({
    inviteManager,
  }, dispatch)
)(InviteManagerForm);

state tree

What beta version are you on, and how are you creating your store?

i manually build the source based on current v1 branch and this is how im creating the store
import { combineForms } from 'react-redux-form';

const initalState = {
  to: '',
  message: '',
};

export const inviteManager =  combineForms(initalState);

Okay, I fixed this; please compare your code to this gist: https://gist.github.com/davidkpiano/ec1d496eb1c67793ccfa5dbad7327ae2

@davidkpiano thanks for the help but i dont think that gist quite does it. how my reducers are structured is
import { combineForms } from 'react-redux-form';

const initalState = {
  to: '',
  message: '',
};

export const inviteManager = combineForms(initalState, 'shared.unclaimed');

which is imported into shared/unclaimed/reducers/index.js which does
import { combineReducers } from 'redux';

import { schedulePreviews } from './schedulePreviews';
import { inviteManager } from './inviteManager';

export default combineReducers({
  schedulePreviews,
  inviteManager,
});

your example duplicates the inviteManger key twice becoming shared.unclaimed.inviteManager.inviteManager.to
Btw thanks again so much for the time and help.

Yeah, I still have to document combineForms() but you shouldn't be using it as a single reducer - think of it as a combination of many reducers, similar to combineReducers():
const reducer = combineForms({
  foo: initialFooState, // < this represents the foo model reducer
  bar: initialBarState, // < this represents the bar model reducer
}, /* ... */);

So having combineReducers({ to: '', message: '' }, ...) makes no sense because to and message are part of the inviteManager reducer, and not their own reducer. Hopefully that makes sense.

@davidkpiano so if i understand correctly i could get away without using combine forms at all? and just doing form(state.shared.unclaimed.inviteManager) in my component?

Yes, you can do the same as v0.x:
const reducer = combineReducers({
  foo: modelReducer('path.to.foo', initialFooState),
  fooForm: formReducer('path.to.foo', initialFooState),
  bar: modelReducer('path.to.bar', initiaBarState),
  barForm: formReducer('path.to.bar', initialBarState),
});

Also I'm adding back the missing derived values (such as .valid, .touched, .pristine, etc.) in the next @beta version, so you won't even need the form() selector :)

So when doing that i get an action fired of rff/null not an issue the issue is rff/setSubmitFailed and rff/setFieldsValidity dont actually update anything?

How are you dispatching those actions?

By trying to submit a validated form without entering anything


Handle has one and accepts nil value for it

Now has_one associations will be taken into account when calling to_params in the parent model.
That allow us to save a parent model containing has_one associations.
For example:
class Person
  include Her::Model
  has_one :nick_name
  attributes :name
end

class NickName
  include Her::Model
  attributes :origin, :author, :created_at
end

p = Person.first
p.assign_attributes(name: 'José',
  nick_name_attributes: {origin: 'high_school', author: 'Big Guy', created_at: 18.years.ago})
p.save

Besides that nil value will be accepted:
p = Person.first
p.nick_name = nil
p.save

This feature is useful, is there any problem in this implementation in particular?

most of the code here is PRd in #262 which i've responded to the OP about. going to close this for now and wait for a few small changes before we try to merge it.
thanks for contributing!


Tooltips do not work

VS 15 Preview 5, VS 2017 RC: no tooltips for F# code at all (for C# code works OK).

Closing as dupe of #1598


DynamoDB table addConsumers bug

I have a single Lambda function that serves as the stream handler for two different DynamoDB tables. When I configure custom filter criteria with addConsumers the criteria are getting mixed up.
Say I have tableA, tableB and a lambda function lambdaFunction:
tableA.addConsumers(stack, {
    handlerA: {
      function: lambdaFunction,
      filters: [
        {
          dynamodb: {
            NewImage: {
              __edb_e__: {
                S:  'SomeEntityInTableA',
              },
            },
          },
        },
      ],
    },
  });

tableB.addConsumers(stack, {
    handlerB: {
      function: lambdaFunction,
      filters: [
        {
          dynamodb: {
            NewImage: {
              __edb_e__: {
                S:  'SomeEntityInTableB',
              },
            },
          },
        },
      ],
    },
  });

After deployment I get the filter criteria of table B applied to the event source mapping of table A, and no filter criteria for table B.
using SST v2.21.0
the issue is probably caused by: https://github.com/serverless-stack/sst/blob/c98db9a6683fd293bdfcf014fda7e79b44378690/packages/sst/src/constructs/Table.ts#L751

Ooh would appreciate a PR. Also if you could post this on #help on Discord, that'd help!

is anyone working on this? I can get started on it and have PR up if not!

Hi @Rohanr14 , there's my own PR already. But feel free to comment

I'm experiencing the same issue.

I'll check on the PR again. Sorry about that.


Fix mcs-api crds

Signed-off-by: Aswin Surayanarayanan<EMAIL_ADDRESS>

Can you add some detail in the PR outlining what you're fixing?

Closing in favour of https://github.com/submariner-io/submariner-operator/pull/848


Support flutter build module/aar/framework

I feel like there must be an existing bug but I can't find one.
One concrete solution/option to https://github.com/flutter/flutter/issues/25979
More or less https://github.com/flutter/flutter/issues/25323 and https://github.com/flutter/flutter/issues/24948
cc @dnfield

Anyone care to share their current best approach for generating easily embeddable aar/framework?
We started work on this about 2 weeks ago and we ended up with such convoluted structure that I am afraid it might break any moment now. On top of this we are seeing quite a lot of issues when using plugins that pull in additional dependencies, and we are going off on patching spree almost every day.
Right now our setup consist of separate subproject for each platform, with plenty of glue in form of Python scripts extracting bits and pieces from different build dirs and putting together contents for a podspec (iOS), or with dancing around dependencies problem using fat-aar (Android).
I appreciate the fact that we are still in the early days and easy embedding Flutter views in existing apps isn't the most chased/desired feature, but I have a feeling that we're not first ones trying to achieve that, and there might be some unheard success stories!

@vvarp  Please let me know if you come up with anything good. I am also curious when we will not be in the early days... and for enterprise it is a desired feature right?

#29328 would help this

Here's a sample of what Alibaba did to breakdowns our existing xcode_backend.sh to produce .frameworks
fwn_repo_path=$(pwd)
export FLUTTER_ROOT="${fwn_repo_path}/flutter"
export FLUTTER_APPLICATION_PATH="${fwn_repo_path}"
export FLUTTER_BUILD_MODE="${build_mode}"
export SOURCE_ROOT="${fwn_repo_path}/ios"
export ARCHS="armv7 arm64"
export SDKROOT="/Applications/Xcode.app/Contents/Developer/Platforms/iPhoneOS.platform/Developer/SDKs/iPhoneOS.sdk"
/bin/sh "$FLUTTER_ROOT/packages/flutter_tools/bin/xcode_backend.sh" build

# Call LC_LOAD_DYLIB, otherwise it crashes on iOS 9.
if [ "$build_mode" = "release" ];then
    echo "===注入LC_LOAD_DYLIB命令==="
    echo "Injecting LC_LOAD_DYLIB command..."
    sync_tools/insert_dylib /usr/lib/libSystem.B.dylib build/aot/App.framework/App
    rm -rf build/aot/App.framework/App
    cp build/aot/App.framework/App_patched build/aot/App.framework/App
    rm -rf build/aot/App.framework/App_patched
fi

cc @jonahwilliams

Note from @mehmetf, we should take care to cover outputting modules with fat binaries.

https://github.com/flutter/flutter/issues/22102 is an Android sub-bug

Although https://github.com/flutter/flutter/issues/22102 is a subset and useful on its own (such as using include_flutter.groovy and being able to access resources) but nevertheless, we'll necessarily solve it while doing this.

Based on @blasten's feedback, splitting Android and iOS work. iOS is in #36968
I think the remaining work for Android is continuing to monitor the flutter build aar command on master and to update the documentation for add-to-app.

flutter build aar is now available on 1.8.3, should we close this issue?

Yeah!


simbody-visualizer: libSimTKsimbody.so cannot be loaded?

So my application has linked libSimTKsimbody in order to actually link the final library. This means that, on booting the binary, the dynamic loader's going to go and load it:
ldd ./main
        linux-vdso.so.1 (0x00007ffc075e3000)
        libosimCommon.so => ../opensim-core/opensim-core-install/lib/libosimCommon.so (0x00007fb4eb068000)
        libosimAnalyses.so => ../opensim-core/opensim-core-install/lib/libosimAnalyses.so (0x00007fb4eaec1000)
        libosimSimulation.so => ../opensim-core/opensim-core-install/lib/libosimSimulation.so (0x00007fb4ea7e3000)
        libosimTools.so => ../opensim-core/opensim-core-install/lib/libosimTools.so (0x00007fb4ea5b9000)
        libosimActuators.so => ../opensim-core/opensim-core-install/lib/libosimActuators.so (0x00007fb4ea42e000)
        libSimTKcommon.so.3.7 => ../opensim-core/opensim-core-install/lib/libSimTKcommon.so.3.7 (0x00007fb4ea0dc000)
        libSimTKsimbody.so.3.7 => ../opensim-core/opensim-core-install/lib/libSimTKsimbody.so.3.7 (0x00007fb4e9c2d000)
        libstdc++.so.6 => /lib/x86_64-linux-gnu/libstdc++.so.6 (0x00007fb4e9a74000)
        libm.so.6 => /lib/x86_64-linux-gnu/libm.so.6 (0x00007fb4e98f1000)
        libgcc_s.so.1 => /lib/x86_64-linux-gnu/libgcc_s.so.1 (0x00007fb4e98d7000)
        libc.so.6 => /lib/x86_64-linux-gnu/libc.so.6 (0x00007fb4e9716000)
        libSimTKmath.so.3.7 => /home/adam/Desktop/opensim-derivative-perf/../opensim-core/opensim-core-install/lib/libSimTKmath.so.3.7 (0x00007fb4e92cd000)
        libblas.so.3 => /lib/x86_64-linux-gnu/libblas.so.3 (0x00007fb4e9260000)
        liblapack.so.3 => /lib/x86_64-linux-gnu/liblapack.so.3 (0x00007fb4e8bc6000)
        libpthread.so.0 => /lib/x86_64-linux-gnu/libpthread.so.0 (0x00007fb4e8ba5000)
        librt.so.1 => /lib/x86_64-linux-gnu/librt.so.1 (0x00007fb4e8b9b000)
        libdl.so.2 => /lib/x86_64-linux-gnu/libdl.so.2 (0x00007fb4e8b96000)
        /lib64/ld-linux-x86-64.so.2 (0x00007fb4eb4fb000)
        libosimLepton.so => /home/adam/Desktop/opensim-derivative-perf/../opensim-core/opensim-core-install/lib/libosimLepton.so (0x00007fb4e8b5a000)
        libgfortran.so.5 => /lib/x86_64-linux-gnu/libgfortran.so.5 (0x00007fb4e88ec000)
        libquadmath.so.0 => /lib/x86_64-linux-gnu/libquadmath.so.0 (0x00007fb4e88aa000)
        libz.so.1 => /lib/x86_64-linux-gnu/libz.so.1 (0x00007fb4e868c000)

So the dynamic loader can find it fine. However, at runtime, I'm getting:
simbody-visualizer: error while loading shared libraries: libSimTKsimbody.so.3.7: cannot open shared object file: No such file or directory

Which I'm guessing is because simbody is doing something cute, like loading the library at runtime using dlopen

Ah, even cuter: the runtime is dependent on the simbody-visualizer binary being on the PATH, which it is because there's some code somewhere putting OpenSim's libexec onto the PATH pre-fork+exec:
strace -f -- ./main
clone(child_stack=NULL, flags=CLONE_CHILD_CLEARTID|CLONE_CHILD_SETTID|SIGCHLD, child_tidptr=0x7fc201ac2790) = 19381
# ...
[pid 19381] execve("/home/adam/Desktop/opensim-derivative-perf/simbody-visualizer", ["simbody-visualizer", "4", "7"], 0x7fff2f9b9ab8 /* 49 vars */) = -1 ENOENT (No such file or directory)
# ...other path entries...
[pid 19381] execve("/home/adam/Desktop/opensim-core/opensim-core-install/libexec/simbody/simbody-visualizer", ["simbody-visualizer", "4", "7"], 0x7fff2f9b9ab8 /* 49 vars */) = 0

But the resulting exec fails because simbody-visualizer isn't aware of custom install paths, so it tries to load its libraries via the global library search path, which fails because it wasn't compiled with an rpath or given extra places to search. Solution is to give it a search path:
LD_LIBRARY_PATH=../opensim-core/opensim-core-install/lib ./main


Store#write method for InputStream and Reader

https://kazurayam.github.io/materialstore/api/com/kazurayam/materialstore/core/filesystem/Store.html
as of 0.12.5, The Store class does not support write() method for java.io.InputStream. Also it does not support write() method for java.io.Reader.
It should support it, shouldn't it?

I doubt it.
Steaming is not well fitting to the materialstore design.


reduce the default MaxBytes to 5mb

21MB blocks are very rare, and problematic, they tend to look like this on live production networks:

This PR reduces max_bytes default value to 5mb

PR checklist

[ ] Tests written/updated
[ ] Changelog entry added in .changelog (we use unclog to manage our changelog)
[ ] Updated relevant documentation (docs/ or spec/) and code comments

Hey can you pls open an issue to document the need for this, briefly? Thanks!
We can include this in v1 release. We'll need to:

document the rationale behind the 5MB choice;
ensure user teams get a chance to weigh in and we choose a sensible value that makes sense to them;
add a changelog entry.

Let's lock on a smaller value, eg. 2MB.

@faddat can you add complete context here -- an issue and a problem description therein? We need this to take decisions regarding the PR and maintain the code in the future. Let's avoid drive-by PRs pls.
Our team will handle the changelog.

@adizere very happy to.  Also, I'm totally open and okay with reducing the default max to 2mb.

@adizere tbh I'd rather not expound the whole issue, I think that Amulet has done that sufficiently well.

Let's lock on a smaller value, eg. 2MB.

There are transactions that are significantly larger than bank sends.  Some chains increase a contract size limit to 3MB of Wasm. This might be gzipped down to 50%, leading to a single tx of ~1.5MB leaving verly little safety margin. Atomically storing two of those would already increase the 2MB. The furture of Cosmos is hopefully more feature rich and includes gaming, NFTs stored on chain and do on and so forth. Now you can argue chains should find a good value individually. But I think a good default should be both safe and not affect 90% of users. Given that I think 4 MB is a very good value as long as there is not good reason to go lower.

Thanks for sharing Simon, that's super valuable perspective I wasn't aware of.

But I think a good default should be both safe and not affect 90% of users. Given that I think 4 MB is a very good value as long as there is not good reason to go lower.

Solid advice. We'll stick to 4mb then.

will add a changelog and update the docs before this can be merged


[All Hosts] (ui) update use of webview2 in browsers and shared runtime

Note to reviewers: The diagram won't preview in GitHub, but it was updated to remove the reference to IE.

Docs Build status updates of commit b7b473b:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/concepts/browsers-used-by-office-web-add-ins.md
:white_check_mark:Succeeded
View

docs/develop/configure-your-add-in-to-use-a-shared-runtime.md
:white_check_mark:Succeeded
View

docs/images/custom-functions-in-browser-runtime.png
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit 85541c7:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/concepts/browsers-used-by-office-web-add-ins.md
:white_check_mark:Succeeded
View

docs/develop/configure-your-add-in-to-use-a-shared-runtime.md
:white_check_mark:Succeeded
View

docs/images/custom-functions-in-browser-runtime.png
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


Bug: Axiom Logger SDK deprecated & throwing errors

Describe the bug
The current node SDK for Axiom has been deprecated and is now throwing errors when the logger function is called within our Nemo application.
Expected behaviour
A clear and concise description of what you expected to happen.
Once ingest function is called, the data should be displayed within the appropriate data-set.
Additional context
Internally we use Axiom as the logger for nemo (our bot). The main node SDK was deprecated a few months and ago and it is now causing run-time errors within the node application. Although axiom has release a replacement sdk -- Axiom js -- it's still prone to throwing errors and does not properly ingest data thus it's not stable yet.
We need to create a wrapper around axiom's api and replace all the instances of where the logger is being called within the nemo application. The API that the wrapper is replacing is specific for ingesting data. See docs here.
The wrapper should also accept a data-set name as an argument and a data object of any type as the second argument.
Testing & Contributions
Refer to the README for instructions on how to get started with a testing environment. Refer to contributing.md for instructions on how to contribute to the project.

resolved in #104


ANF-8872 Fix examples for integers

MSFT employees can try out our new experience at OpenAPI Hub  - one location for using our validation tools and finding your workflow.

updating existing version to fix swagger quality issue in s360
This is to address S360 findings, SDK will be generated based on upcoming 2020-11-01 api-version that will also contain same fixes where applicable.
@xccc-msft  This is in relation to the Window to Fix Broken  https://dev.azure.com/azure-sdk/internal/_wiki/wikis/internal.wiki/405/Window-to-Fix-Broken
Issues
https://msit.powerbi.com/groups/me/apps/7f17babe-3e24-447d-91de-796f85555eb4/reports/17c7b280-b27a-4f7f-b24f-f23f80e7ee3e/ReportSection766c23df8ea11acbcf28
Changelog
updating existing version to fix swagger quality issue in s360
Please ensure to add changelog with this PR by answering the following questions.

What's the purpose of the update?

[ ] new service onboarding
[ ] new API version
[ ] update existing version for new feature
[x] update existing version to fix swagger quality issue in s360
[x] Other, please clarify

When you are targeting to deploy new service/feature to public regions? Please provide date, or month to public if date is not available yet.
When you expect to publish swagger? Please provide date, or month to public if date is not available yet.
If it's an update to existing version,  please select SDKs of specific language and CLIs that require refresh after swagger is published.

[ ] SDK of .NET (need service team to ensure code readiness)
[ ] SDK of Python
[ ] SDK of Java
[ ] SDK of Js
[ ] SDK of Go
[ ] PowerShell
[ ] CLI
[ ] Terraform
[ ] No, no need to refresh for updates in this PR

Contribution checklist:

[x] I commit to follow the Breaking Change Policy of “no breaking changes
[x] I have reviewed the documentation for the workflow.
[x] Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist

[ ] Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.

Adding new API(s)
Adding a new API version
Adding a new service

[ ] Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

[ ] If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.

[ ] Removing API(s) in stable version
[ ] Removing properties in stable version
[ ] Removing API version(s) in stable version
[ ] Updating API in stable version with Breaking Change Validation errors
[ ] Updating API(s) in preview over 1 year

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.

@xccc-msft can we have this looked at

@xccc-msft can we have this looked at

@audunn We have to wait for breaking change reviewer's approval. I'm from SDK team.

@audunn We have to wait for breaking change reviewer's approval. I'm from SDK team.

@audunn We have to wait for breaking change reviewer's approval. I'm from SDK team.

updating existing version to fix swagger quality issue in s360
https://dev.azure.com/azure-sdk/internal/_wiki/wikis/internal.wiki/405/Window-to-Fix-Broken

@audunn We have to wait for breaking change reviewer's approval. I'm from SDK team.

updating existing version to fix swagger quality issue in s360
https://dev.azure.com/azure-sdk/internal/_wiki/wikis/internal.wiki/405/Window-to-Fix-Broken

@xccc-msft Does this not apply here?
updating existing version to fix swagger quality issue in s360
https://dev.azure.com/azure-sdk/internal/_wiki/wikis/internal.wiki/405/Window-to-Fix-Broken

@xccc-msft Does this not apply here, Window-to-Fix-Broken extended though February?
updating existing version to fix swagger quality issue in s360
https://dev.azure.com/azure-sdk/internal/_wiki/wikis/internal.wiki/405/Window-to-Fix-Broken

@akning-ms Could you please advise? Thanks.

@xccc-msft Does this not apply here, Window-to-Fix-Broken extended though February?
updating existing version to fix swagger quality issue in s360
https://dev.azure.com/azure-sdk/internal/_wiki/wikis/internal.wiki/405/Window-to-Fix-Broken

@akning-ms Could you please advise? Thanks.

Yes. if it is to fix S360 issue, breaking change review is not required by end of Feb.  I have helped put correct label in PR by check correct box in changelog section of first comment in PR.
And seems you are going to refresh SDK which based on your new api version 2020-11-01. not sure when it will be ready, if it is not soon, suggest refresh SDK in latest 2020-09-01 version

@xccc-msft Does this not apply here, Window-to-Fix-Broken extended though February?
updating existing version to fix swagger quality issue in s360
https://dev.azure.com/azure-sdk/internal/_wiki/wikis/internal.wiki/405/Window-to-Fix-Broken

@akning-ms Could you please advise? Thanks.

Yes. if it is to fix S360 issue, breaking change review is not required by end of Feb. I have helped put correct label in PR by check correct box in changelog section of first comment in PR.
And seems you are going to refresh SDK which based on your new api version 2020-11-01. not sure when it will be ready, if it is not soon, suggest refresh SDK in latest 2020-09-01 version

@akning-ms we expect refresh of SDK's in 2020-11-01  should be ready soon

@audunn Please feel free to let me know when this PR is ready to merge. Thanks.

@xccc-msft  Good to go, thanks.

@akning-ms I cannot merge as the CI tasks never stop here. Please help merge. Thanks.


Finalize combined e-stop circuit

Design a circuit for combined e-stop functionality
Successful completion ensures vehicle stop if either wired or wireless e-stop is activated

Wiring of wired e-stop should still be complete, status of wireless module is unknown. Roboclaws must be configured to take a non-latching stop signal. As far as I know, Greg knows how to do that. I'll consult him about how to configure them. If both e-stops are already mounted, confirming that they work should take about an hour.


Pick-2.0 add failure injection in inverted index writer

Proposed changes
Pick from #26121
Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall

run buildall

run buildall


Middleware is being executed on all resources

eg, /favicon is hitting the middleware edge lambda too, as well as all requests to the site.
This causes a 10-50ms latency and additional price penalty to each request.
We should read from the .next/server/middleware-manifest.json. One potential problem is that nextjs converts the matcher into a RegExp string... so we might have to read the config.matcher from the raw middleware.ts file.
Then we can create a new behavior w/ an exclusive edgeLambdas property.
eg:
 const middlewareBehavior = {
   ...serverBehavior,
   edgeLambas // move this out from the serverBehavior and put it here to isolate middleware requests
}

In the main Distribution:

additionalBehaviors: {
   ...
   [config.matcher[0]]: middlewareBehavior,
   [config.matcher[n]]: middlewareBehavior,
}

The default max cache behavior per distribution is 25. It should be easy to request a quota increase

On a second thought, if the runtime of Lambda@Edge is also node18, then this shouldn't be a problem... maybe it's even ideal if each server handler is executed close to the user's region.


Create data model

Create a data model

Create and run the necessary migration files.
Add foreign keys and indexes.

Thank you for kindly reviewing my PR 😄❄

thank you :)


feat: ✨ auto generate change log

👋, this is just a proposal to help you automatically generate (with few efforts) a change log for each release 😉.
The only thing you need to:

have clear labels
label PRs
have PRs with a clear title

The label / categories in the release.yml are proposals, fell free to add / remove change them.
An example of such change log: https://github.com/ovh/public-cloud-examples/releases

Thanks a lot


Add support only allow users to book single tickets for events

Related to https://github.com/opencollective/opencollective/issues/5086
Front-end PR: https://github.com/opencollective/opencollective-frontend/pull/8309

Closing as I am changing the approach as per; https://github.com/opencollective/opencollective/issues/5086#issuecomment-1285033330


MSUnmerged: NotMasterError renamed to NotPrimaryError

Impact of the bug
MSUnmerged
Describe the bug
This is a future bug. Currently we do not experience it, because we are still using old enough version of MongoDB such that the breaking change has not been introduced yet.
While working on some manual imports of few WMCore modules deployed with pypi I've stumbled on the following error: [1]. This is a change in behavior introduced  with pymongo version 4.0. The pymongo error NotMasterError has been deprecated and the new one to be used should be NotPrimaryError as recommended at [2]. This is a non-backward compatible change on pymongo side about which we need to pay attention, once we upgrade to pymongo version 4.0 and above. We are currently using  version 3.10.1: [3]. One thing needs to be mentioned though, as long as we are using the RPM based deployment we are  safe, but once we move to pypi packaging and deployment we need to have it fixed, because at
https://github.com/dmwm/WMCore/blob/8a6a17e54470cdae5be75209cd9ac3b94c6dbdbb/requirements.txt#L37
we are already using ~= as a requirement string, this immediately places us at the latest available version (currently 4.0.1) because it has no conflicts with any other module deployed.
[1]
In [1]: from WMCore.Micrrom WMCore.MicroService.MSUnmerged.MSUnmergedRSE import MSUnmergedRSE
---------------------------------------------------------------------------

ImportError                               Traceback (most recent call last)
<ipython-input-1-9daca6c75ccf> in <module>
----> 1 from WMCore.MicroService.MSUnmerged.MSUnmergedRSE import MSUnmergedRSE

~/WMCoreDev.d/WMCoreTest.venv3/lib64/python3.6/site-packages/WMCore/MicroService/MSUnmerged/MSUnmergedRSE.py in <module>
      4 """
      5
----> 6 from pymongo.errors  import NotMasterError
      7 # from pymongo.results import results as MongoResults
      8

ImportError: cannot import name 'NotMasterError'

[2]
https://pymongo.readthedocs.io/en/stable/changelog.html?highlight=3.10#breaking-changes-in-4-0
 * Removed pymongo.errors.NotMasterError. Use [pymongo.errors.NotPrimaryError](https://pymongo.readthedocs.io/en/stable/api/pymongo/errors.html#pymongo.errors.NotPrimaryError) instead.

[3]
https://github.com/cms-sw/cmsdist/blob/comp_gcc630/py3-pymongo.spec
How to reproduce it
In [1]: pymongo.version
Out[1]: '4.0.1'

In [2]: from WMCore.Micrrom WMCore.MicroService.MSUnmerged.MSUnmergedRSE import MSUnmergedRSE

Expected behavior
Safe import of modules depending on pymongo.
Additional context and error message
None

With the additional tests did today, I have figured out that we need to upgrade both the client and the server version both together. So the resolution of this issue needs  to be in coordination with whom ever is about to be upgrading the MongoDB as a service instance.
FYI @amaltaro @muhammadimranfarooqi @Panos512

Some  more findings. As confirmed also by Panos the database version on the server is already 5.03: [1]. So it seems the new  version is compatible with the old clients. I am about to proceed now with upgrading the client only.
[1]
In [4]: msUnmergedDB.command({'buildInfo':1})['version']
Out[4]: '5.0.3'

Todor, we might have to check other things as well, because our current MongoDB setup is somehow hybrid, like:

ms-output: uses MongoDB deployed with k8s in the CMSWEB cluster (which version?)
ms-unmerged: uses MongoDB AaS (according to Panos/you, on version 5.0.3
microservices in dev mode (our VMs): uses MongoDB built in cmsdist (current version is 3.2.10)

Given that we have not yet fully deprecated the VM-based tests, I think we should make sure that these changes will work for all of these 3 setups.

Hi @amaltaro Thanks for looking into is.
I am feeling pretty safe when it comes to those 3:

ms-output: uses MongoDB deployed with k8s in the CMSWEB cluster (which version?)

Yes, and those they still need to be migrated to MongoDB as a service. The Exception changed with the current issue  relates only to MongoDB as a service, because it has been deployed in a replicaset instead as a monolithic single database instance. So it is really unlikely to affect ms-output in any way.

ms-unmerged: uses MongoDB AaS (according to Panos/you, on version 5.0.3

Yes, and this one has been tested and the client v.s server versions do match in both ways (old pymongo client in combination with the latest server  && new pymongo client with the latest server) and are backwards compatible. It is only the change of the exception handling on the client side which is not.

microservices in dev mode (our VMs): uses MongoDB built in cmsdist (current version is 3.2.10)

Yes, again, it does require mongo 3.2.10 for our dev VM deployments, but honestly I do not see a use case where it can be a blocker, because it is a matter of a MSConfig change to make it use the MongoDB as a service instance and do not care about what is configured as a dependency in the rpm based deployment.

Yes, again, it does require mongo 3.2.10 for our dev VM deployments, but honestly I do not see a use case where it can be a blocker, because it is a matter of a MSConfig change to make it use the MongoDB as a service instance and do not care about what is configured as a dependency in the rpm based deployment.

Yes, it's definitely not a blocker, but something that we must cover not to leave broken pieces around.
Given that we have not yet completely deprecated the VM setup - even if it's not the most productive work - we should ensure that VM setup will manage to access MongoDB AaS and ensure that such tests don't affect our production services stability. With this change, we should also consider the testX cmsweb clusters as well.
For the record, this pymongo client no longer supports MongoDB 3.2, see:
https://pymongo.readthedocs.io/en/stable/changelog.html#changes-in-version-4-0

For the record, this pymongo client no longer supports MongoDB 3.2, see:

Yes this is correct. And this would break MSOutput in the VM based setup unless any of those happens:

We upgrade mongodb version of the rpm here:   https://github.com/cms-sw/cmsdist/blob/comp_gcc630/mongo.spec (but this would affect every other service/package depending on it)
We just set the default config for ms-output VM deployment to use MongoDB as a Service instead. Here:  https://github.com/dmwm/deployment/blob/master/reqmgr2ms/config-output.py

As I said before I'd bet for the later option, but looking at this file it has no Mongodb configuration parameters at all, unlike the K8 configs though: https://gitlab.cern.ch/cmsweb-k8s/services_config/-/blob/preprod/reqmgr2ms-output/config-output.py#L107-108 . It seems we have already abandoned this configuration file since a while now.

And as I started working on it I've found few more things need to be added and tested to MSOutput so that it could be redirected to MongoDB as a service. Like adding a username and password for the MongoDB as a service to Reqmgr2msSecrets and also adding the replicaset for the configuration similar to [1]. Here is a separate issue for his [2].
@amaltaro  lets merge this one and follow the MSOutput related changes in the dedicated issue.
[1]
https://gitlab.cern.ch/cmsweb-k8s/services_config/-/blob/preprod/reqmgr2ms-unmerged/config-unmerged.py#L98-102
data.mongoDBUrl = 'mongodb://%s:%s@%s' % (MONGODB_USER, MONGODB_PASSWORD, MONGODB_SERVER)
data.mongoDBPort = MONGODB_PORT
data.mongoDB = 'msUnmergedDBPreProd'
data.mongoDBReplicaset = 'cms-db'
data.mongoDBRetryCount = 3

[2]
https://github.com/dmwm/WMCore/issues/11020


Check for all possible query conflicts in initialization

Fixes #1320.
This should panic whenever a system is created that could possibly cause a conflict with some archetype. It does this by first checking if there are any conflicting accesses at all (basically test if any of the used types overlap) and then testing the conflicting queries with all possible combinations of components. This way the check should be relatively fast most of the time and get into exponential runtime only when necessary. Also this check is only performed once at startup, so performance is not too essential.
Some things that maybe should be changed:

I'm currently reusing the code (and variables) in SystemState::check_access in initialize and update. Maybe it would be better to split the two cases.
I'm also reusing the code in QueryAccess::get_access_filtered. This allows the method to be called with a real archetype or just a combination of components

This was a good idea, but I'm closing in favor of the FilteredAccess impl in #1525 (which is a smaller impl and uses bitsets)


Document usage instructions with popular module loaders (Webpack, Browserify, etc.)

It looks like the README used to have instructions on usage with Browserify, but it has been removed for reasons I don't understand: https://github.com/github/fetch/commit/01797bceb6e07d0a0b2090915c4cd0df52f7bb5d
It can be difficult to figure out how to use a global-attaching polyfill in Webpack or Browserify. Adding these instructions to the README would be very helpful. I'd be happy to contribute updated instructions if the PR would be accepted :)
Previous PRs:

Webpack instructions (closed for unknown reasons): https://github.com/github/fetch/pull/110
Browserify instructions (potentially still accurate, outside of module name): https://github.com/github/fetch/blob/4b9e44493cfcab97077dd2d7be6a8364292ea03a/README.md#using-with-npm-and-browserify

It can be difficult to figure out how to use a global-attaching polyfill in Webpack or Browserify.

With no JavaScript loaders it's as simple as:
<script src="fetch.js"></script>

(Replace fetch.js with the appropriate name of bundle file when all dependencies are concatenated as a single JS bundle.)
If the equivalent is difficult to achieve with Webpack or Browserify, we expect that users of these module loaders know how to load source files in their web pages. If they don't, that have a bigger problem than our lack of installation instructions.

@thomasboyt in regards to Webpack I wrote a small little post about how to use fetch: http://mts.io/2015/04/08/webpack-shims-polyfills/

@matiassingers :sparkles:


[Issue] Unable to use regsync with self-hosted quay syncing whole registry

Current Behavior
I don't get an output while trying to sync a self hosted quay registry to an Azure Container Registry. The same setup worked with an ACR to ACR sync.
The Sync between self-hosted quay and ACR currently only works with type: image and repository, but it would me very convenient to just define a registry and not every single repository.
My provided quay user has access to self-hosted-quay.company.com/xyz and everything below that
Am I doing something wrong?
Expected Behavior
I should be able to define my config like this:
version: 1
  sync:
    - source: self-hosted-quay.company.com
      target: my-acr.azurecr.io
      type: registry
      interval: 1m

and it should sync the whole available registry of this user to my specified target registry.
As im running regsync as a kubernetes container with the server option, the docker config is used from the /home/appuser path.
Steps To Reproduce
Use the config above.
Version
Docker Container Version: 0.7.0
Environment

Kubernetes (Azure Linux Nodes)
Source Registry: self-hosted quay
Target Registry: ACR

additional infos
quay version: https://github.com/quay/quay/releases Quay v3.11.0

Does the source registry implement the _catalog API? You can test that with regctl repo ls registry.example.org (replacing with your source registry).

Hi,
I tested it with an ACR and the self-hosted quay. The ACR outputs all repos, but the self-hosted quay just replies with an empty list, even though the robot account has access to a lot of repos.

That API is a prerequisite for the type: registry to work. It is fairly common for it to not be supported, though in this case, it probably indicates an access issue with Quay.

sorry, i'm still waiting for a response

sorry, i'm still waiting for a response

From me or your registry operator?

sorry, i'm still waiting for a response

From me or your registry operator?

from the registry operator, sorry for the unclear communication


Add a way to reclaim all escrow shares

Because the web wallet converts from ROSE when determining how many tokens to withdraw, it is possible to be left with a delegation that is worth an infinitesimally small amount of ROSE.
The web wallet badly needs a way to reclaim all shares, that actually fully reclaims everything.

This is actually duplicate of #492 :wink:


Upgrades Disappearing on Reload

I am playing with a friend of mine and whenever I leave and then join back onto the server all of my upgrades are completely wiped out. Whenever I rebuy them they are at the original prices and they are also applied to my friend at whatever level he is at. I left and came back and rebought the back muscles upgrade twice and it took me from level 0 to level 2 and him from level 2 to level 4. I have attached the config files for the server which are the same as my client settings. Feel free to message me if you need any other info or comment on here as I will try to come back later. Also I played some more since I started writing this post and not all of the upgrades seemed to go to him to when I bought them. I bought Midas Touch and that didn't go to him along with some others I bought at the same time that I don't remember. This was after another relog and nothing I bought after the relog went to him so I think It might have just stopped transferring them to him completely. Also just for clarity his upgrades stayed the whole time. He was also the host too. We were the only two in there at the time so I don't know if the issue would've happened with someone else. That might be something we check later.
config.txt

I need logs to know if there's something wrong when purchasing an upgrade and/or saving the upgrades when disconnecting.


Adding three small features

Hi.
I would like to propose three small modifications, in order to address the issue https://github.com/mkaz/termgraph/issues/60.
The major change is that now, the normalize() function basically uses the sum of each row of values in data, instead of the max_dat. This protects the case where max_dat < width against bad bar plots.
I also changed int() to round() to make sure that the bars (almost) add up to 100 when the data is expressed in percentage. Otherwise, the bars would not line up nicely.
Please let me know what you think of the changes.
Kind regards
Ehsan

Thanks for the contribution!
I updated recently in 0.4.2 to fix the issue with max < width, do you think this change is still necessary?
The int() to round() seems like a good change.
It is difficult to see your change with all of the linting changes, can you setup black formatter and run that on your change first, it should auto format and match the style of mine.
Installation: python -m pip install black
Run: black termgraph/termgraphy.py
Or run as a module if the above doesn't work: python -m black termgraph/termgraphy.py
You can also setup your Editor to auto format, instructions here, depends on what editor you use.


Possible internal comment published live

Good day team.
The section "Add the third-party data governance label to all fields in the schema" feature the following comment in bracket:
"add link to docs by Jordan".
That sounds like an internal comment. Mind to check it out?

Issue in ./help/rtcdp/partner-data/prospecting.md

Thanks for reporting this. The comment was addressed. Closing this issue.


Export to PDF does not show formatting

The extra formatting does not appear when one does an Export to PDF.
/**
 * Test
 */

package net.gwizlabs.test;

public class Test {
  private int x;
}

Looks like this in reading mode:

Doing CMD+P Export to PDF while in reading mode shows

This seems can not be implemented.
The functionality export to pdf seems only care about static page elements. I'm not sure if it's indeed, I get this result from tests of mine.
While line number or highlight lines have to be added dynamically. Because you can only know the style of the specific code block after it have been mounted to document and only if you know that style you can make additional components display correctly.


docs: add installation doc (minikube support)

add installation doc:

support install kstone on minikube(Mac OS X and Linux amd64)

@tangcong
Done

@tangcong
You are right, It's ingress-nginx in v1.20.0. I've fixed this in doc.


安装kmod-bonding出错

通过opkg安装kmod-bonding出错，加--force-depends依然无用
Multiple packages (libgcc1 and libgcc1) providing same name marked HOLD or PREFER. Using latest.
Unknown package 'kmod-bonding'.

Collected errors:
 * pkg_hash_check_unresolved: cannot find dependency kernel (= 6.6.36~f492dffe00c0a7786964bab6d7e76015-r1) for kmod-tls
 * pkg_hash_fetch_best_installation_candidate: Packages for kmod-tls found, but incompatible with the architectures configured
 * pkg_hash_check_unresolved: cannot find dependency kernel (= 6.6.36~f492dffe00c0a7786964bab6d7e76015-r1) for kmod-bonding
 * pkg_hash_fetch_best_installation_candidate: Packages for kmod-bonding found, but incompatible with the architectures configured
 * opkg_install_cmd: Cannot install package kmod-bonding.

如果要重新编译固件的话怎么自己把这个包添加进去？望大佬指点

没事了，自己改了一下.config就好了，修改CONFIG_PACKAGE_kmod-bonding=y就可以在编译时添加进这个包了


new function in riot-api

Someone with privilges could add following code:
//Returns the challenger ladder.
public function getChallenger() {
	$call = 'league/challenger?type=RANKED_SOLO_5x5';
	//add API URL to the call
	$call = self::API_URL_2_5 . $call;
	return $this->request($call, true);
}
    //Returns the master ladder.
public function getMaster() {
	$call = 'league/master?type=RANKED_SOLO_5x5';
	//add API URL to the call
	$call = self::API_URL_2_5 . $call;
	return $this->request($call, true);
}

the challenger ladder already exists, but the master ladder was not impl.

You can submit a pull request, it's the easiest way to get code integrated
into the repo
On Fri, Dec 9, 2016 at 7:16 AM, toalt<EMAIL_ADDRESS>wrote:

Someone with privilges could add following code:
//Returns the challenger ladder.
public function getChallenger() {
$call = 'league/challenger?type=RANKED_SOLO_5x5';
//add API URL to the call
$call = self::API_URL_2_5 . $call;
return $this->request($call, true);
}
//Returns the master ladder.
public function getMaster() {
$call = 'league/master?type=RANKED_SOLO_5x5';
//add API URL to the call
$call = self::API_URL_2_5 . $call;
return $this->request($call, true);
}
the challenger ladder already exists, but the master ladder was not impl.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/kevinohashi/php-riot-api/issues/60, or mute the
thread
https://github.com/notifications/unsubscribe-auth/ABJcgj2EHlmfLj6nA1ZAYA-NaR1XgeRJks5rGUaUgaJpZM4LI4Vf
.


Implement Investor Approval detail page component

Done implementing the component, and it seems to work on Businees approval detail also.


Training faster-rcnn use resnet

when i used resnet trained faster-rcnn it had a good trained result but the test is poor.
cmd : bash example/rcnn/script/resnet_voc07.sh 0
After trained, i test the dataset that used trained  i found that the result is error, all of the result is wrong.
who can help me ?
Or, tell me your idea!
thanks !

This issue is closed due to lack of activity in the last 90 days. Feel free to reopen if this is still an active issue. Thanks!


Add a new hpylori project VM

I am marking this PR as a draft since @EngyNasr would like to clarify the project's storage requirements with Rolf.
Xref: https://github.com/usegalaxy-eu/issues/issues/612

~ resource "aws_route53_record" "usegalaxy_eu_forwardmail_validation_txt" {
id              = "Z1C7L7XFF9613J__TXT"
~ ttl             = 10 -> 3600
# (5 unchanged attributes hidden)
}

Should be fine, we just need to keep this in mind

@engy you do not need to check the requirements with Rolf, just check the number of samples we want to process and estimate the produced output based on the samples you already processed.


Fixed git synchronization

Fixed synchronization with remote git repo.
Resolve #1569
Motivation and context
Currently it doesn't work
How has this been tested?
Manual testing
Checklist

[x] I submit my changes into the develop branch
[x] I have added description of my changes into CHANGELOG file
[ ] I have updated the documentation accordingly
[ ] I have added tests to cover my changes
[x] I have linked related issues (read github docs)
[ ] I have increased versions of npm packages if it is necessary (cvat-canvas,
cvat-core, cvat-data and cvat-ui)

License

[x] I submit my code changes under the same MIT License that covers the project.
Feel free to contact the maintainers if that's a concern.
[x] I have updated the license header for each file (see an example below)

# Copyright (C) 2020 Intel Corporation
#
# SPDX-License-Identifier: MIT

Pull Request Test Coverage Report for Build 5250

1 of 8 (12.5%)  changed or added relevant lines in 1 file are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage decreased (-0.02%) to 65.613%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

cvat/apps/git/git.py
1
8
12.5%

Files with Coverage Reduction
New Missed Lines
%

cvat/apps/engine/media_extractors.py
1
77.42%

Totals

Change from base Build 5240:
-0.02%

Covered Lines:
10845

Relevant Lines:
16133

💛  - Coveralls


Support https://www.tumblr.com/username format

Tumblr is starting to use tumblr.com/username for blogs, in addition to username.tumblr.com, and some blogs (flagged ones, I guess?) are now only displaying the former when you're viewing the blog.
Since I'm usually adding a blog by copy-pasting the address from Tumblr to TumblThree, it would be convenient if we could add blogs with their tumblr.com/username, which doesn't seem to supported so far. If it's causing an issue with the inner working of TumblThree, it could even just be a conversion: when we press "Add blog", it's converted back into username.tumblr.com.

Yes, we already saw that Tumblr changed a few things recently. We'll change it, so that TumblThree is able to recognize the new format, although internally and for displaying we probably will still use the former format.

The issue has been fixed and closed. You can still comment. Feel free to ask for reopening the issue if needed.


Fix #1506, Align Table Name reporting in CFE_TBL_Register()

Checklist

[x] I reviewed the Contributing Guide.
[x] I signed and emailed the appropriate Contributor License Agreement to<EMAIL_ADDRESS>and copied<EMAIL_ADDRESS>
Describe the contribution

Fixes #1506

Updates/standardizes use of TblName in syslog reports in CFE_TBL_Register().

Testing performed
Only GitHub actions.
Expected behavior changes
No impact on behavior.
Contributor Info
Avi Weiss @thnkslprpt

Rebased to main (due to https://github.com/nasa/cFE/pull/2387), change-set is much smaller now.
Most of the original changes are no longer relevant, or no longer possible (without creating additional variables which is less simple than just leaving things as-is...).


error with reject database

10:29:16.745-!!|PROC| 10:29:16.621-|DatabaseError|E[00-002-00032] <class
10:29:16.745-!!|PROC|   'mysql.connector.errors.DatabaseError'>: 1030 (HY000): Got error 168 "Unknown
10:29:16.745-!!|PROC|   (generic) error from engine" from storage engine InnoDB
10:29:16.746-!!|PROC|    Command: DROP TABLE reject_full_v07288_db
10:29:16.747-!!|PROC|   path: /home/external/acarmona/.apero/acarmona_at_clusterdb
10:29:16.747-!!|PROC|   Function: apero.base.drs_db.py.Database.execute()
10:29:16.914-|PROC| ***************************************************************************
10:29:16.947-@!|PROC| W[40-003-00005]: Recipe apero_processing has NOT been successfully completed
10:29:16.993-**|PROC| ***************************************************************************
It was solved not updating the reject database.  Ideas?

No idea with "Unknown (generic) error from engine"
Can you access the reject database via mysql?
Seems to be a problem removing the table (the command that was used was "DROP TABLE reject_full_v07288_db")
Did you try again?

Hello Neil,
I did launch the reduction without updating the reject database.
Launched again and same problem.
As this is the reduction of a new run, I will just go on until i am up to date on
the reduction without updating the reject database :-)
Andres

On 4 Mar 2024, at 15:49, Neil Cook @.***> wrote:
No idea with "Unknown (generic) error from engine"
Can you access the reject database via mysql?
Seems to be a problem removing the table (the command that was used was "DROP TABLE reject_full_v07288_db")
Did you try again?
—
Reply to this email directly, view it on GitHub https://github.com/njcuk9999/apero-drs/issues/749#issuecomment-1976755093, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJO43RTVDRP23ZOJB6O6JD3YWSCZLAVCNFSM6AAAAABEE6JOQOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNZWG42TKMBZGM.
You are receiving this because you authored the thread.

Okay but we should fix the problem at some point.
Once you are ready to try, I need you to:

Try to access the reject database from mysql
Backup the table (there are mysql commands to duplicate the table) then try dropping the table in mysql

If both of those work I'm not sure what could cause this. If there is an error in any of these maybe the error can help us.

@andrescarmona given your email about running out of space for the mysql database, this issue may be directly linked to that!

I hope, I can not run APERO at all now..

APERO went back to operations. The solution was:

liberate disk space, we moved from 94% to 77%
reboot the database server

the actualisation of the reject database worked too.


RestApiOperationRunner handling of 204 | No Content responses

Today, RestApiOperationRunner.SerializeResponseContentAsync will throw if there is no MediaType on the ContentType response header. When the response is 204 or No Content, there will not be a ContentType|MediaType available. I'm curious the SK teams thoughts on whether the behavior should be updated in this scenario to not throw and support 204 responses or if this is the expected behavior and design with OpenAPI plugins.
Example yaml:
paths:
  /resources/{id}:
    get:
      operationId: getResource
      summary: Get the details of a resource
      parameters:
      - in: path
        name: id
        schema:
            type: string
        required: true
        description: The ID of the resource.
      responses:
        "200":
          description: OK
          content:
            application/json:
              schema:
                $ref: '#/components/schemas/ResourceResponse'
components:
  schemas:
    ResourceResponse:
      type: object
      properties:
        resources:
          type: string
          items:
            type: string
          description: The list of resources.

Function execution with API giving a 204 response
Expected:
Empty string is returned
Actual:
Exception thrown - Microsoft.SemanticKernel.Kernelexception - No media type available.

Related - https://github.com/microsoft/semantic-kernel/issues/2648


Docs.MS Release Updates for azure-synapse-artifacts

Update docs metadata and targeting for release of azure-synapse-artifacts

Docs Build status updates of commit b112700:
:warning: Validation status: warnings

File
Status
Preview URL
Details

docs-ref-services/preview/synapse-artifacts-readme.md
:warning:Warning
View (azure-node-preview)
Details

<EMAIL_ADDRESS>:warning:Warning
View (azure-node-latest)
Details

<EMAIL_ADDRESS>:warning:Warning
View (azure-node-latest)
Details

<EMAIL_ADDRESS>:warning:Warning
View (azure-node-latest)
Details

<EMAIL_ADDRESS>:warning:Warning
View (azure-node-latest)
Details

<EMAIL_ADDRESS>:warning:Warning
View (azure-node-latest)
Details

<EMAIL_ADDRESS>:warning:Warning
View (azure-node-latest)
Details

docs-ref-services/preview/synapse-artifacts-readme.md

Line 0, Column 0: [Warning-h1-missing] H1 is required. Use a single hash (#) followed by a space to create your top-level heading.
Line 9, Column 16: [Warning-ms-prod-technology-invalid] Invalid value for 'ms.technology': 'azure' is not valid with 'ms.prod' value 'azure'.
Line 55, Column 1: [Warning-duplicate-alt-text] Alt text 'Impressions' is duplicated. Within an article, alt text must be unique.
Line 75, Column 1: [Warning-duplicate-alt-text] Alt text 'Impressions' is duplicated. Within an article, alt text must be unique.
Line 2, Column 1: [Suggestion-description-missing] Missing required attribute: 'description'.

<EMAIL_ADDRESS>
Line 5, Column 31: [Warning-xref-not-found] Cross reference not found: 'DataLakeServiceClient.undeleteFileSystem'.

<EMAIL_ADDRESS>
Line 5, Column 41: [Warning-xref-not-found] Cross reference not found: 'DataLakeServiceClient.renameFileSystem'.

<EMAIL_ADDRESS>
Line 5, Column 41: [Warning-xref-not-found] Cross reference not found: 'DataLakeServiceClient.undeleteFileSystem'.

<EMAIL_ADDRESS>
Line 5, Column 31: [Warning-xref-not-found] Cross reference not found: 'DataLakeServiceClient.renameFileSystem'.

<EMAIL_ADDRESS>
Line 6, Column 1: [Warning-xref-not-found] Cross reference not found: 'KnownGeoReplicationStatusType'.

<EMAIL_ADDRESS>
Line 5, Column 31: [Warning-xref-not-found] Cross reference not found: 'BlobServiceClient.renameContainer'.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


Add support for versions like 1.0.0-beta2 & 1.0.0-beta.2

Proposed change

Adds support for versions like these 1.0.0-beta2 & 1.0.0-beta.2
Type of change

[ ] Dependency upgrade
[ ] Bugfix (non-breaking change which fixes an issue)
[x] New feature (which adds functionalit)
[ ] Breaking change (fix/feature causing existing functionality to break)
[ ] Code quality improvements to existing code or addition of tests

Additional information

This PR fixes or closes issue: fixes #
This PR is related to issue:
Link to documentation pull request:

Checklist

[x] The code change is tested and works locally.
[x] Local tests pass.
[x] There is no commented out code in this PR.
[x] The code has been formatted using Black (make black)
[x] Tests have been added to verify that the new code works.

🚀

🚀


Build it as a docker image

This will help shorten the setup process.
Also currently I'm getting some errors during dependency installation as following
/usr/bin/ld: cannot find -lz

collect2: error: ld returned 1 exit status

error: command 'x86_64-linux-gnu-gcc' failed with exit status 1

the GCC version I'm using is gcc (Debian 4.9.2-10) 4.9.2

OK, the build issue resolved when I use Python3. Still would be great to package it as a docker image.

@zhenyulin were you able to create a working docker image?

@zhenyulin I'm running into the same issue on the dependencies, could you share further what you did to get it working?

@kylelee715 I fixed my issue running installation with Python3, hth

@zhenyulin please submit your dockerfile in a PR!

I'm not a very experienced pythonista, but I think this is written for python 2.x, not python 3. This one-liner Dockerfile successfully builds and runs:
FROM python:2-onbuild


Style issue with ansi characters

Greetings.
I'm sure someone who enjoys css more than me has a better fix for the following, but when I have a terminal app (mcedit is a good example) that brings up a dialog with ansi characters in it the padding seems to blow out.

I can fix it with
.xterm-rows div {
    height: 16px;
}

but I imagine it's not the best fix (breaks scaling)

Hi @swynter-ladbrokes. Thanks for reporting this. Could you please provide me with some steps to reproduce this? How do you use xterm with mcedit?

Hi @parisk
I've put together the smallest possible demo I can
https://github.com/freman/goterm/
For your convenience I've prebuilt some binaries
https://github.com/freman/goterm/releases/tag/0.0.1
I'm assuming of course you have OSX or Linux available with mcedit installed.

Thanks. Downloaded goterm successfully, but I do not have mcedit installed and I am not sure what this is exactly actually.
Can you provide me with installation instructions and how to use it in order to reproduce your error?
Thanks!

mcedit is part of Midnight Commander - and I'm probably about the only person who uses it but I imagine those ansi characters come up in other places so it's as good an example as any
Depending on your platform

apt-get install mc
yum install mc
emerge mc
brew install mc

mcedit file.txt
Type a character, then press F10 (or escape twice) to bring up the save and exit dialog.

Hey @parisk, I stopped being lazy and here's a concise example without any external dependancies
<!DOCTYPE html>

	<title>Xterm</title>

	<link rel="stylesheet" href="/xterm.js/src/xterm.css" />
	<link rel="stylesheet" href="/xterm.js/addons/fullscreen/fullscreen.css" />

Sorry for the delay on this @swynter-ladbrokes, but finally I found the time to take this over and opened a PR that seems to be fixing this issue: #56.
Can you please checkout the branch issue/54 and let me know if it works for you?

I'll try to take a look today (I understand how it is to be flat out)

Hey @parisk, issue/54 fixes my issue perfectly.


Updated Buffer to fix deprecation.

Hi!
I've noticed that the Buffer usage is deprecated, so I've fixed it. Please consider merging, any comments welcome. thanks.

Thanks for contrinution


Implement work-queue in operator

[Fail] IngressWithTLSAuth Create Required Auth [It] Should response HTTP
/home/tamal/go/src/github.com/appscode/voyager/test/e2e/ingress_tlsauth.go:194

[Fail] IngressTCP Proxy Protocol With version 2 [It] Should test decoded proxy-protocol header
/home/tamal/go/src/github.com/appscode/voyager/test/e2e/ingress_tcp.go:328

Ran 83 of 90 Specs in 2602.112 seconds
FAIL! -- 81 Passed | 2 Failed | 0 Pending | 7 Skipped --- FAIL: TestE2E (2603.02s)

I retried the failed tests and those passed.

I re-run all the tests using the informer version of the haproxy-controller that is included in the HAProxy container. All tests passed.


Fix broken tests

This will fix the tests which are broken, but I still think that the algorithms should be an instance member, as opposed to static.

Making SignatureAlgorithms, HashAlgorithms and CanonicalizationAlgorithms instance members of SignedXml, made sense, and it also had the side effect of fixing the issues with the tests.

Since the X509Certificate elements should only contain X509 certificates, there is no point in putting anything other than the keys starting with BEGIN CERTIFICATE (and it is also unsafe).
Public keys like RSA, DSA etc should not go into the X509Certificate element. They should go in their respective elements inside the KeyValue element. If you want we can add support for that too.
With this commit all the tests are passing.

Here is a theoretical untested function for extracting public keys and their respective types:
var crypto = require("crypto");

const EXTRACT_PUBLIC_KEYS = new RegExp(
 "-----BEGIN [A-Z\x20]*PUBLIC[A-Z\x20]*-----([^-]*)-----END [A-Z\x20]*-----",
    "g"
);

function getPublicKeysFromPem(pem) {
  const publicKeys = [];
  let match;

  while ((match = EXTRACT_PUBLIC_KEYS.exec(pem)) !== null) {
    const key = crypto.createPublicKey(match[0]);
    if (!key.asymmetricKeyType) {continue;}
    publicKeys.push([key,key.asymmetricKeyType]);
  }

  return publicKeys;
}

And then in getKeyInfoContent:
  let rsaKeyValue = '';
  let dsaKeyValue = '';
  let ecKeyValue = '';
  let publicKeys = utils.getPublicKeysFromPem(publicCert);
  publicKeys.forEach(([key,type]) => {
    switch (type) {
      case "rsa": {
        const {n: modulus, e: exponent} = key.export({format: 'jwk'});
        rsaKeyValue += `<${prefix}RSAKeyValue><${prefix}Modulus>${modulus}</${prefix}Modulus><${prefix}Exponent>${exponent}</${prefix}Exponent></${prefix}RSAKeyValue>`;
        break;
      }
      case "dsa": {
        const {p: p, q: q, g: g, y: y} = key.export({format: 'jwk'});
        dsaKeyValue += `<${prefix}DSAKeyValue><${prefix}P>${p}</${prefix}P><${prefix}Q>${q}</${prefix}Q><${prefix}G>${g}</${prefix}G><${prefix}Y>${y}</${prefix}Y></${prefix}DSAKeyValue>`;
        break;
      }
      case "ec": {
        const {crv: crv, x: x, y: y} = key.export({format: 'jwk'});
        ecKeyValue += `<${prefix}ECKeyValue><${prefix}NamedCurve URI="urn:oid:${crv}"/><${prefix}PublicKey><${prefix}X>${x}</${prefix}X><${prefix}Y>${y}</${prefix}Y></${prefix}PublicKey></${prefix}ECKeyValue>`;
        break;
      }
    }});

However, this does not fall into the scope of this PR so I do not want to work on this any further right now.


apm update /usr/lib64/libstdc++.so.6: version `GLIBCXX_3.4.20' not found

my os is openSUSE 13.2 Gnome 3.14.0
Linux mycomputename 3.16.7-13-desktop #1 SMP PREEMPT Wed Mar 18 17:31:15 UTC 2015 (ba2afab) x86_64 x86_64 x86_64 GNU/Linux.
when i run apm update
apm update

/usr/share/atom/resources/app/apm/node_modules/asar-require/node_modules/asar/node_modules/chromium-pickle/node_modules/bindings/bindings.js:83
        throw e
              ^
Error: /usr/lib64/libstdc++.so.6: version `GLIBCXX_3.4.20' not found (required by /usr/share/atom/resources/app/apm/node_modules/asar-require/node_modules/asar/node_modules/chromium-pickle/build/Release/pickle.node)
    at Module.load (module.js:356:32)
    at Function.Module._load (module.js:312:12)
    at Module.require (module.js:364:17)
    at require (module.js:380:17)
    at bindings (/usr/share/atom/resources/app/apm/node_modules/asar-require/node_modules/asar/node_modules/chromium-pickle/node_modules/bindings/bindings.js:76:44)
    at Object.<anonymous> (/usr/share/atom/resources/app/apm/node_modules/asar-require/node_modules/asar/node_modules/chromium-pickle/lib/main.js:1:99)
    at Module._compile (module.js:456:26)
    at Object.Module._extensions..js (module.js:474:10)
    at Module.load (module.js:356:32)
    at Function.Module._load (module.js:312:12)

I think I update my glibc will be problem....
how to fix this?
my glibcxx
 strings /usr/lib/libstdc++.so.6 | grep GLIBCXX
GLIBCXX_3.4
GLIBCXX_3.4.1
GLIBCXX_3.4.2
GLIBCXX_3.4.3
GLIBCXX_3.4.4
GLIBCXX_3.4.5
GLIBCXX_3.4.6
GLIBCXX_3.4.7
GLIBCXX_3.4.8
GLIBCXX_3.4.9
GLIBCXX_3.4.10
GLIBCXX_3.4.11
GLIBCXX_3.4.12
GLIBCXX_3.4.13
GLIBCXX_3.4.14
GLIBCXX_3.4.15
GLIBCXX_3.4.16
GLIBCXX_3.4.17
GLIBCXX_3.4.18
GLIBCXX_3.4.19
GLIBCXX_DEBUG_MESSAGE_LENGTH

非常抱歉，我又忘记告诉你们我用的哪个版本的atom了。
Soory, I forget tell you something.
atom --version
0.193.0

/cc @zcbenz

@kevinsawicki The Linux build machine uses a relatively new distribution which has a newer libc version which is not available on openSUSE 13.2.
I think I should remove the dependency of chromium-pickle in asar so we don't relay on native modules when using apm.

I think I should remove the dependency of chromium-pickle in asar so we don't relay on native modules when using apm.

Sounds good :+1:

+1

Fixed by https://github.com/atom/asar/pull/28.

waiting release!坐等发布！

+1 on this issue on CentOS 7.1.1503

@guhcampos This should be fixed in the latest release, what version of atom are you using?

@Otterpocket Version 0.194.0!
Thanks for the info. Let me know if you need help testing.

@guhcampos This issue is fixed in 0.195.0 and 0.196.0, try installing a newer package https://github.com/atom/atom/releases

Confirmed working alright on 0.196.0 running on CentOS 7.1.1503, RPM install.
Sorry for the confusion. I keep my box updated via Yum and forgot I had installed atom with "localinstall"


All credentials have parameterless ctor

closes #43959

API change check
APIView has identified API level changes in this PR and created following API reviews.
Azure.Identity


Code Server asks for GIthub Sign in every time I push

OS/Web Information

Web Browser: Brave 1.26.74 Chromium: 91.0.4472.124
Local OS: Windows 10
Remote OS: Ubuntu server 20.0 LTS
Remote Architecture: Amd64
code-server --version:  code-server 3.3.1

Steps to Reproduce

Made a change to file
Staged the change
Added a commit
( I used --global when setting user.email and user.name)

Expected
It should push the changes without asking for the username and password.
Actual
It always asks for the username and password. Signing in from Github also doesn't work. It just shows the forbidden error.
Logs
Jul 27 05:39:30 codegrity-server code-server[110469]: info  Using config file ~/.config/code-server/config.yaml
Jul 27 05:39:30 codegrity-server code-server[110469]: info  Using user-data-dir /var/lib/code-server
Jul 27 05:39:30 codegrity-server code-server[110469]: info  code-server 3.3.1 521ac7d91f1d1107fa100898969e7b902740414a
Jul 27 05:39:30 codegrity-server code-server[110469]: info  HTTP server listening on http://<IP_ADDRESS>:8080
Jul 27 05:39:30 codegrity-server code-server[110469]: info      - Using password from $PASSWORD
Jul 27 05:39:30 codegrity-server code-server[110469]: info      - To disable use `--auth none`
Jul 27 05:39:30 codegrity-server code-server[110469]: info    - Not serving HTTPS
Jul 27 07:12:16 codegrity-server code-server[110469]: (node:110469) MaxListenersExceededWarning: Possible EventEmitter >
Jul 27 07:12:16 codegrity-server code-server[110469]: (Use `node --trace-warnings ...` to show where the warning was cr>
Jul 27 07:12:38 codegrity-server code-server[110469]: (node:110469) MaxListenersExceededWarning: Possible EventEmitter >
~

Screenshot

Notes
This issue can be reproduced in VS Code: No

Really sorry, this was an issue with github. For some reason I got logged into code-server's terminal as root and cloned the repo as root. To work with this I used the --system arg while setting up credentials. Cloning it as a user fixed it.


Various cleanup to ProxyState

Moving policies to separate PolicyStore. All member variables are now private.
Making a clearer separation between findXXX methods which now belong to ProxyState, and fetchXXX, which belong to DemandProxyState and build on the findXXX versions.
Adding hostname to Workload and adding support for finding workloads by hostname.

@nmittler: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

test_ztunnel
41a6cd130160134ab4900b7554d1eee312cf35eb
link
true
/test test

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@nmittler: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

test_ztunnel
9dd401d5e47334cbea2457fbcd3df5d7501c482c
link
true
/test test

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


Appsync cannot be installed/Missing firmware?

Device Model
Ipad 9th gen A13 Bionic Chip
iOS Version
16.6
Bootstrap Version
1.2.8
Serotonin Version
1.2.1
What happened

Cant download app sync
Log output
Depends Firmware

Acknowledgement of README and FAQ

[X] I have read both the README and the FAQ.

AppSync isn't supported on your version. Install .ipa files through TrollStore.


Remove Chinese translations

This is due to the inactivity of the contributors that might lead to unwanted partial and/or out-of-date translations.

As sad as I am to see this language removed, I must admit that the missing Chinese translations are blocking our workflow. There are many PQs that are many weeks old and are otherwise fully translated.
If @WingLim is busy with other things, that is fine. We are in no way interested in forcing anyone to work on a project even though they have largely moved on.
If would be very happy to add Chinese translations again as soon as the translations are catching up again! The git history will preserve the existing work.


Touch control

Touch control so you could spin it by swiping.

Nice idea! I've attached it to drag enhancement. #78

I'm also looking for a solution for drag rotate menu.
https://codepen.io/xgqfrms/pen/MMeNxr


Backport "Generalize warnings for top-level calls to Any or AnyRef methods" to LTS

Backports #20312 to the LTS branch.
PR submitted by the release tooling.
[skip ci]

No regressions detected in the community build up to lts-20279.
Reference


[BUG]: 'type "geography(Point)" does not exist' when using push:pg

What version of drizzle-orm are you using?
0.28.6
What version of drizzle-kit are you using?
0.19.13
Describe the Bug
drizzle-kit push:pg does not complete when using a custom type and trying to push the schema to a postgres with postgis installed (using docker); it stops with the following error:
error: type "geography(Point)" does not exist
I've created a minimal reproduction:
https://codesandbox.io/p/sandbox/wandering-brook-vwwtj2
Expected behavior
The push command should complete without error. I can manually alter the table and add a column with the geography(Point) data type, so the database setup seems to be ok.
Environment & setup
Locally (Fedora) and on codesandbox

I'm experiencing this same issue

I'm experiencing this same issue

Experiencing exactly the same!

Just got some help from discord, it seems that you have to manually remove the quotes around "geography(Point)" in the generated migration sql

Now there's official support for the point type:
https://orm.drizzle.team/learn/guides/postgis-geometry-point

For now it looks like this is limited to "geometry" type right ?  But "geography" type is not supported, or do I misanderstand something ?

Now there's official support for the point type:
https://orm.drizzle.team/learn/guides/postgis-geometry-point

@mauriciabad For now it looks like this is limited to "geometry" type right ?  But "geography" type is not supported, or do I misanderstand something ?

I started a PR to implement geography point : #3021

Another downside is that adding CREATE EXTENSION IF NOT EXISTS postgis; breaks drizzle-kit push:pg because it adds some new tables that drizzle is not aware of and tries to remove, read more about it here.

Just a heads-up that this is now resolved by adding a config option to exclude the PostGIS tables: https://orm.drizzle.team/docs/drizzle-config-file#extensionsfilters
Looks like #3021 for Geography is still pending however.

+1

+1

Bump this. A new version has been released but this issue wasn't resolved


Lattice ECP5: primitive instantiation sometimes yields 'cells_not_processed'

Context: using Yosys toolchain on MSYS2, with VHDL source files, using Yosys GHDL plugin. Tried on Linux as well with the latest toolchain built from git, same result.
The exact same primitive instantiation ('ODDRX1F') in the exact same source file, but in two different projects, works in one project, but yields a  'cells_not_processed' attribute in another (again, the source file instantiating it is the same, but there are different source files otherwise).
In Yosys report, this can be seen as 'ODDRX1F' appearing in all uppercase in the cells list when it's correctly processed (first project), and as 'oddrx1f' in all lowercase when it's not processed correctly (second project). I looked at the JSON output, and the difference is this:
First project where it's OK (just pasting the part with a difference):

"ODDRX1F": {
"attributes": {
"blackbox": "00000000000000000000000000000001",
"src": "D:\Programs\msys64\mingw64\bin\../share/yosys/ecp5/cells_bb.v:250.1-255.10"
},

Second project where it's  not:

"ODDRX1F": {
"attributes": {
"blackbox": "00000000000000000000000000000001",
"cells_not_processed": "00000000000000000000000000000001",
"src": "D:\Programs\msys64\mingw64\bin\../share/yosys/ecp5/cells_bb.v:250.1-255.10"
},

So as one can see, the only difference seems to be the  "cells_not_processed" attribute in the case which fails.
Another difference in the JSON files is that in the second case, there is an additional cell (in all lowercase) like this:

oddrx1f": {
"attributes": {
"blackbox": "00000000000000000000000000000001"
},

The instantiation is again in the same source file (a SDRAM controller), and it is like so:

SDRAM_Clock: ODDRX1F
port map (SCLK => Clock, RST => Reset, D0 => '0', D1 => '1', Q => SDRAM_CLK);

Thanks for any pointers. I do not see why this would be treated in a different way in both projects while the instantiation is exactly the same in the same source file.
I encountered a similar issue with another primitive: DP16KD.

This all comes from a case sensitivity issue. This is discussed in here: https://github.com/ghdl/ghdl-yosys-plugin/issues/155
So anyone interested in working with the Lattice ECP5 in VHDL can read this, and more generally using VHDL and blacboxes with Yosys.


What event fires, when i want to know if user has leave the Dragobject, DragLeave doesn´t fires

What event fires, when i want to know if user has leave the Dragobject, DragLeave doesn´t fires

@reinhardmueller It's maybe necessary to attach on PreviewDragLeave event...


Performance issue related to many trigger processes stord in the db f…

…ixed

This change is

Codecov Report

Merging #591 into master will decrease coverage by -0.04%.
The diff coverage is 0%.

@@             Coverage Diff             @@
##             master    #591      +/-   ##
===========================================
- Coverage     58.14%   58.1%   -0.04%
+ Complexity    18683   18682       -1
===========================================
  Files          1932    1932
  Lines         99432   99497      +65
  Branches      10101   10106       +5
===========================================
- Hits          57818   57817       -1
- Misses        38539   38604      +65
- Partials       3075    3076       +1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5553c47...074ab4d. Read the comment docs.

Reviewed 1 of 2 files at r1, 7 of 7 files at r2.
Review status: all files reviewed at latest revision, all discussions resolved, some commit checks failed.

Comments from Reviewable


API Fix: exact match record name by default

Problem was:
When I search /api/plugins/netbox-dns/records/?zone_id=1&type=PTR&name=11 I don't want to match the reverse record for 111.
The same applies forward:
When I search /api/plugins/netbox-dns/records/?zone_id=1&type=A&name=foo I don't want to match the A record for foobar.domain.tld.
By removing the icontains filter, the default Netbox filters are applied, which means an exact match by default.
When you want back the old behaviour you can query like this:
/api/plugins/netbox-dns/records/?zone_id=1&type=A&name__ic=foo

Created new PR #125 based off the develop branch


Tracking Issue: MVP no_std Bevy

This is a tracking issue for progress on a no_std compatible subset of Bevy. The tasks are ordered roughly in sequence (bevy_app can't be no_std until bevy_ecs is for example).
Core Tasks
These tasks must be completed for a no_std Bevy to become usable at all.

[x] Turn on lints encouraging the use of core and alloc instead of std
#15281
[X] bevy_ptr
[x] bevy_utils
#15463

[x] Provide an appropriate Instant type which can be controlled by the user in no_std contexts, or avoid its use
[x] Move web-time into wasm32-only dependencies (doesn't need to exist outside web anyway!)
[x] Make thread_local optional

[ ] bevy_tasks
#15464

[ ] Replace async-executor with a no_std compatible executor
Can just be a direct copy of the existing Local/Executor using no_std compatible types from a crate like spin
[ ] Add std/alloc features

[x] bevy_macro_utils
#15465

[x] Update derive_label to use Box from alloc
(requires wrapping the quoted impl in a const _: () = { ... } so that extern crate alloc wont conflict with the outer namespace)

[ ] bevy_ecs

[ ] Replace petgraph's GraphMap
#15519
A direct copy does work since the biggest issue is the complex trait network petgraph uses and their reliance on the std feature of indexmap, which we don't need.
[ ] Replace petgraph's TarjanScc
#15519
A direct copy is also possible here.
[x] Replace thiserror with a no_std compatible alternative.
#15774
[ ] Add std/alloc features

[ ] bevy_app

[x] Replace thiserror with a no_std compatible alternative.
#15779
[ ] Add std/alloc features

[ ] bevy_internal / bevy

[ ] Thread std / alloc features from sub-crates through to the final bevy crate.
Will require making most extra Bevy crates optional behind a std feature. However, as more crates are made no_std these can be moved out from that feature gate.

[x] Update CI to ensure no_std compatibility is preserved
#15843

Bonus Features
These tasks aren't strictly required, but should be completed to close the gap between no_std and std Bevy. The more functionality we can provide in no_std, the more the community can develop for it.

[ ] bevy_animation

[x] Replace thiserror with a no_std compatible alternative.
#15780
[ ] Replace petgraph with a no_std compatible alternative.
Currently only using the DiGraph type with no edge data and only a single node type AnimationGraphNode (and a serializable alternate SerializedAnimationGraphNode).

[ ] bevy_asset
Reliance on filesystem operations will make this interesting, but a lot of the asset functionality exists outside of files and folders (processing, etc.).

[x] Replace thiserror with a no_std compatible alternative.
#15778

[ ] bevy_color

[x] Replace thiserror with a no_std compatible alternative.
#15777

[ ] bevy_core
[ ] bevy_derive
[ ] bevy_diagnostic
[ ] bevy_hierarchy
[ ] bevy_image
#15771
[ ] bevy_input

[x] Replace thiserror with a no_std compatible alternative.
#15770

[ ] bevy_log
[ ] bevy_math
#15810

[x] Replace thiserror with a no_std compatible alternative.
#15769

[ ] bevy_mesh
#15768
[x] bevy_mikktspace
#15528
[ ] bevy_reflect

[x] Replace thiserror with a no_std compatible alternative.
#15766

[ ] bevy_remote
Might be able to work over serial?
[ ] bevy_state
[ ] bevy_time

[x] Replace thiserror with a no_std compatible alternative.
#15759

[ ] bevy_transform

[x] Replace thiserror with a no_std compatible alternative.
#15761

Not Planned
These crates can't be ported to no_std because they are highly platform specific. If you see something on this list that could be ported, please let me know!

bevy_a11y
bevy_audio
bevy_core_pipeline
#15775
bevy_dev_tools
bevy_dylib
bevy_encase_derive
bevy_gilrs
#15773
bevy_gizmos
bevy_gltf
#15772
bevy_pbr
#15767
bevy_render
#15765
bevy_scene
#15764
bevy_sprite
#15763
bevy_text
#15762
bevy_ui
#15760
bevy_window
bevy_winit

General Notes
thiserror
thiserror is currently not available in a no_std form due to its use of the ::std::error::Error path for Error (which it continues to use for MSRV backwards compatibility). There is a PR to add no_std support to thiserror which preserves that MSRV requirement, but it's unclear if/when that will be merged and released.
One alternative is to link against the PR instead of the published version of thiserror:
thiserror = {
  git = "https://github.com/quartiq/thiserror",
  rev = "515bd36da54dbc346250026ddc349c88851e4bb1",
  default-features = false,
}

Another alternative is to switch to using derive_more. This would require adding explicit calls to derive(From, Display) as well, which adds to the noise. Additionally, it isn't already in the dependency tree, so its inclusion may be contentious.
Due to delays in thiserror's no_std support, we have decided to use derive_more.
Platform Support
Being no_std is necessary for certain platforms, but it is not always sufficient. Below is a table of platforms that I have tested:

Name
Target
Builds
Notes

UEFI
x86_64-unknown-uefi
Runs
Boots on emulated and real hardware, supported by the uefi crate.

GameBoy Advance
thumbv4t-none-eabi
Partially
The platform does not support all atomic operations (e.g., CAS), which Bevy directly and transiently relies on. Moving from tracing to log, and using portable_atomics is sufficient to make this platform compile.

Nintendo Switch
aarch64-nintendo-switch-freestanding
Compiles
I cannot test the binary produced by cargo nx on real hardware or an emulator to confirm it actually works.

PlayStation One
mipsel-sony-psx
Partially
The platform does not support all atomic operations (e.g., CAS), which Bevy directly and transiently relies on. Moving from tracing to log, and using portable_atomics is sufficient to make this platform compile.

MSP430
msp430-none-elf
No
This platform is 16-bit, which breaks too many assumptions made by dependencies like zerocopy.

Playdate
thumbv7em-none-eabihf
Runs
Runs but requires a patch to fixedbitset to disabled SIMD. Could potentially be fixed from within Bevy without the patch though.

I have a prototype of no_std compatible Bevy available on this branch. It's not being actively maintained, as it is a proof of concept for upstream no_std support (use at your own risk, etc.). However, if anyone has a particular platform they'd like to use Bevy on, please feel free to test using this branch and let me know what kind of compatibility you have. In general:

You must be able to compile a Rust project for this platform. (I hope this goes without saying!)
You must have alloc and core available.
Your platform must support Atomic CAS (hoping to relax this in the future!)
Only the bevy_app, bevy_ecs, bevy_utils, and bevy_tasks are compatible in this branch, and must be imported directly (e.g., you can't use bevy;,  instead use bevy_app;). Additionally, you must disable default features for no_std compatibility.
Your platform must be 32-bit or higher due to safety concerns in bevy_ecs. For further information, see #4736.

Looks like there is some effort to make thiserror support #![no_std] in https://github.com/dtolnay/thiserror/pull/304. Looks like it's on hold until the author responds, though.

Yeah that's where I got the (temporary) fix from:
thiserror = {
  git = "https://github.com/quartiq/thiserror",
  rev = "515bd36da54dbc346250026ddc349c88851e4bb1",
  default-features = false,
}

I'm hoping the PR is merged sooner rather than later, but there's a similar issue with petgraph where there does exist a no_std compatible version, but it's waiting in the wings.
In both cases we have options for how to proceed. Either waiting for those crates to get updated, replacing them with something equivalent, or developing a replacement based on these prior efforts.

After some discussion on the Discord, I'm going to open PRs to replace thiserror with derive_more for at least bevy_ecs and bevy_app in the near-term. A quick experiment on bevy_ecs made the change look pretty minor, and the crate does offer more functionality than thiserror does on its own.

Can cargo-deny work on "our" dependencies only? If so, please add a line for thiserror, since derive-more tackles everything we need.

Can cargo-deny work on "our" dependencies only? If so, please add a line for thiserror, since derive-more tackles everything we need.

Unfortunately no. Currently cargo deny treats direct and transitive dependencies identically. We could make a CI job that uses a crate like toml to check if thiserror is present in the dependency table for each Cargo.toml in the crates folder. I suspect we would want to do something like this anyway as a part of a broader no_std CI task.
In the interim, if a user adds thiserror back into Bevy inadvertently we at least have derive_more in-tree ready to go to fix it.

I got @bushrat011899's no_std branch's bevy_app + bevy_ecs working on the Playdate Simulator!
The one change I had to make to get it to run was disabling fixedbitset's simd support. For whatever reason, vec![SimdBlock::NONE; 1] was causing a segmentation fault when SimdBlock was avx2::Block. I solved this by pulling down fixedbitset, commenting out all of the simd support, and overriding the dependency in my cargo.toml.
My Playdate won't arrive until December so it's currently unknown if it will run on hardware.
Link to discussion on discord:
https://discord.com/channels/691052431525675048/691052431974465548/1302002362432487486

Can you open an issue upstream to feature flag the SIMD support?

I believe there's an existing issue around runtime-detection of SIMD features that is likely related to this error the Playdate exposes.

heydocode (not sure of their GitHub handle!) suggested using the Embassy crate as a part of offering multi threading and Async execution to Bevy. This is a good suggestion that I'm making note of here for future follow-up.

Yeah, to avoid confusion, this is my GitHub account.

@Niashi24 thanks for testing! Care to publish a minimal hello-world repository so we can replicate and test on hardware? Thank you!

@CarlosMendonca Here you go, hope this helps! https://github.com/Niashi24/bitset-simd-min
I do want to emphasize that this is running on the Playdate Simulator on my computer, not the actual Playdate hardware. From what I understand running it on the simulator means that the game is actually running on the hardware that runs the simulator, i.e. my computer.
It's possible that it could just be a fault with the simulator. I can't test it on the actual Playdate hardware since I don't have one (mine won't arrive until Christmas).
The crash occurred running the simulator on both Windows and Linux (running through WSL2). My processor does have support for avx2.

Hello, I just notice that "thiserror" 2.0 now support no_std.
https://github.com/dtolnay/thiserror/releases/tag/2.0.0

Hello, I just notice that "thiserror" 2.0 now support no_std.
https://github.com/dtolnay/thiserror/releases/tag/2.0.0

We have already switched off of it, and we don't see value in switching back. See the working group for no_std on the bevy discord for more info.

The core of AccessKit (that is, the accesskit crate) is no-std compatible since 0.17.0.

The core of AccessKit (that is, the accesskit crate) is no-std compatible since 0.17.0.

That's awesome to hear, thanks for pointing it out! I've updated the roadmap to include bevy_a11y, since AccessKit was my only real concern here.

@bushrat011899 You might also want to update the section on bevy_window, since a feature is probably not needed anymore here?
Having bevy_a11y run on as much devices as possible is important for us. We are aware that game consoles don't ship with an accessibility layer, but we still want developers to be able to rely on AccessKit to create their own assistive technologies. For this purpose, the accesskit_consumer crate, which contains the logic needed by platform adapters, also supports no-std as of its latest version.

I think the thiserror note can be updated now that it supports no_std.

I think the thiserror note can be updated now that it supports no_std.

Agreed! I've added a little preface note indicating that the below information was written prior to version 2 of thiserror.


Removed fastlane code/examples

Also refactored a bit.

Will submit new PR to opensource repo instead of merging to master.


[ALLUXIO-3166] Move journal non-integration tests.

https://alluxio.atlassian.net/browse/ALLUXIO-3166
Moves non-integration journal tests out of the integration test module.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/19396/Failed Tests: 1org.alluxio:alluxio-tests: 1alluxio.server.ft.ZookeeperFailureIntegrationTest.zkFailure
Test FAILed.

Jenkins, test this please.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/19397/
Test PASSed.


fix: make configureLogger accept Log instance instead of Logger

Related: https://github.com/apify/apify-conductor/pull/103

Let's see what happens 😄

damn, failed to ship to NPM, and I kinda know why, the versions are taken from dist/package.json that is outdated, only the root one has correct  version. will ship it manually now and try to deal with this tomorrow.

publishing should be hopefully fixed, let's see on the next PR, there is already one waiting for review


Incorrect test error message when test failed.

We need to update our test and swap actual and expected results.

Documentation: https://nodejs.org/api/assert.html#assert_assert_equal_actual_expected_message
Current implementation:
assert.equal(5, getAverage(5, 5));
should be:
assert.equal(getAverage(5, 5), 5);
We need to update ALL out tests.
Thank you @OlgaVoronko for the report :+1:

The assertions were corrected, PR#7 is open.

done #7


rar multipart (*.part1.rar, *.part2.rar) support?

Hi,
I have a lot of multipart .rar archives that follow the pattern from the title
<name>.part1.rar
<name>.part2.rar
<name>.part<x>.rar

but when I execute a command like this:
arc.exe -overwrite unarchive "R:\melodies.part1.rar" "R:\melodies"
I only get the message:
scanning source archive: scanning tarball's file listing: rardecode: archive continues in next volume
and no extraction is done...
I'm on Windows, using arc v3.2

rardecode documentation says "NewReader only supports single volume archives. Multi-volume archives must use OpenReader. "
Rar.Extract may use OpenReader iff sourceArchive.(interface {Name()string}) with that Name(), and that file exists, but this seems to be an ugly hack.
Or use it when it encounters this error...

For anyone interested in proposing an implementation for this, it looks like this 7-zip Go package does something similar, for reference: https://github.com/bodgit/sevenzip/blob/46c5197162c784318b98b9a3f80289a9aa1ca51a/reader.go#L149-L155
(Please submit a proposal before going to all the work to implement it, just in case the implementation isn't a good fit or approach for this project it would make more sense to not spend all that time, probably. Thanks!)


Remove reference to MyGet

Currently, a lot of the code base includes references to MyGet.  While we use this as the default alternative feed for pre-release package versions, it isn't the only one.  i.e. a user might want to use Azure Artifacts, or GitHub Package Repository.  We should update reference to MyGet and instead call it something else, like Secondary Package Repository, or something else, that isn't as long 😄

As I mentioned on the stream yesterday, DevSource (I think perhaps I said DevPackages) could perhaps be appropriate.
Or maybe one of the following:

NightlySource
RollingSource
BuildSource (Probably not this one).
UnstableSource (Could perhaps be wrong due to also stable releases could end up there).
SourceOfWorms 😆

@devlead suggests

ProductionSource
StableSource

For the NuGet equivalent