Provide validation failure cause when creating route with actuator endpoint

Is your feature request related to a problem? Please describe.
In short, we provide users a tool to setup routes across multiple instances of SCGs.
We get the route configurations and use the actuator endpoint to setup the routes in running SCG instances.
User may configure a big amount of routes, but since the POST /route endpoint only returns an empty 400 response with no body we are not able to provide any hint on what went wrong when some route cannot be configured.
Describe the solution you'd like
I see in the code two validations are applied (hasValidFilterDefinitions and hasValidPredicateDefinitions), but they are not used in any other way.
https://github.com/spring-cloud/spring-cloud-gateway/blob/a81bb187c8506e6412d81136bc061cf15e0ec0e2/spring-cloud-gateway-server/src/main/java/org/springframework/cloud/gateway/actuate/AbstractGatewayControllerEndpoint.java#L141-L152
The response is just returned empty: https://github.com/spring-cloud/spring-cloud-gateway/blob/a81bb187c8506e6412d81136bc061cf15e0ec0e2/spring-cloud-gateway-server/src/main/java/org/springframework/cloud/gateway/actuate/AbstractGatewayControllerEndpoint.java#L138
If only the call could provide a springboot error response with something like "invalid filter definition" or "Invalid predicate definition" would be great. Adding the list of invalid elements would help, but I not sure is this could leak internal information.
Describe alternatives you've considered
no comments
Additional context
Add any other context or screenshots about the feature request here.

As @abelsromero described in the previous comment, the AbstractGatewayConotrollerEndpoint.save(..) builds a reactive ResponseEntity but it doesn't contain any error message when a validateRouteDefinition returns false (FilterDefinition or PredicateDefinition name given by the client is not available). The only meaningful result is a 400 Bad Request header.
I have thought about raising an exception and leave the  default handler org.springframework.boot.autoconfigure.web.reactive.error.DefaultErrorWebExceptionHandler map the exception to a proper message like the next sample:
{
    "timestamp": "2021-07-22T14:41:47.394+00:00",
    "path": "/actuator/gateway/routes/user-namespace-test-gateway-mapping-0",
    "status": 400,
    "error": "Bad Request",
    "message": "Invalid Filter defintion",
    "requestId": "c43eae40-7, L:/0:0:0:0:0:0:0:1:8080 - R:/0:0:0:0:0:0:0:1:51123"
}

However, I saw that the message is cleanup. This cleanup is defined by the ErrorAttributeOptions for all the requests, which makes sense because we don't want to expose message information globally. I got the next response
{
    "timestamp": "2021-07-22T14:41:47.394+00:00",
    "path": "/actuator/gateway/routes/user-namespace-test-gateway-mapping-0",
    "status": 400,
    "error": "Bad Request",
    "message": "",
    "requestId": "c43eae40-7, L:/0:0:0:0:0:0:0:1:8080 - R:/0:0:0:0:0:0:0:1:51123"
}

So, it seems that the exception approach is not fine for this.
An alternative option could be to write a similar map of values to get the expected non-empty message above.
Before starting to implement the approach, I would like to get some feedback from @spencergibb. May I ask you if you can shed some light on the format of this message, please?


pane 4 display missing an arrow

Switch to a trigram model and change the text to "about as old as and about as tall as". Rebuild the dictionary.
In pane 2, click on "as tall". The pane 4 display is missing the arrow.

Done.

Click on "and about as" and the level 2 node "as tall as" is missing the big right bracket. This is a bug.

Verified fixed.


Bug: When I edit an opportunity A, I cannot use A's { name } again.

When editing an opportunity, the front-end pulls that opportunity's data. This includes the "name" property. I get a 400 "name already exists" error when I try to submit the form with the same name.
For example:

I go to edit opportunity A
I add a tag to opportunity A
I submit the form
400 "error name already exists with this partner"

We can solve this one of two ways:

Fix the API
Submit ONLY modified fields on the front-end

Going to fix this client-side for now. We can fix this server side later if we want.


Report build phase events with number of tasks and projects to configure to TAPI

With this PR progress bar could be implemented in IDE.
We now forward BuildPhaseStartEvent and BuildPhaseFinishEvent when listening to OperationType.BUILD_PHASE. These events are the same events that are used for the Gradle progress bar.
The Gradle progress bar logic for the phase and number of items to executed is something like (from BuildStatusRenderer):
if (event is BuildPhaseStartEvent) {
    if (event.getDescriptor().getBuildPhase() == "CONFIGURE_ROOT_BUILD") {
        progressBarSize = event.getDescriptor().getBuildItemsCount()
        currentProgress = 0
        currentPhase = Phase.Configuring
    } else if (event.getDescriptor().getBuildPhase() == "CONFIGURE_BUILD" && currentPhase == Phase.Configuring) {
        progressBarSize += event.getDescriptor().getBuildItemsCount()
    } else if (event.getDescriptor().getBuildPhase() == "RUN_MAIN_TASKS") {
        progressBarSize = event.getDescriptor().getBuildItemsCount()
        currentProgress = 0
        currentPhase = Phase.Building
    } else if (event.getDescriptor().getBuildPhase() == "RUN_WORK" && currentPhase == Phase.Building) {
        progressBarSize += event.getDescriptor().getBuildItemsCount()
    }
}

IDE can then listen to OperationType.PROJECT_CONFIGURATION finish events to get progress of configuration phase and OperationType.TASK finish events for progress of build phase.
Some notes:

Gradle's progress bar first shows "Initialization" (is always 0%), then "Configurating" that goes from 0 to 100% and then Executing that goes from 0 to 100%.
Gradle ignores all events before the certain phase. So for example before "CONFIGURE_ROOT_BUILD" comes it ignores all project configuration finish events and task finish events. The same goes for build phase. Before "RUN_MAIN_TASKS" it ignores all task finish events.

Fixes https://github.com/gradle/gradle/issues/17334

@bot-gradle test this

OK, I've already triggered the following builds for you:

PullRequestFeedback build

@donat I created a separate listener BuildPhaseOperationListener.java for these events as I mentioned on Slack. That is because with a mapper I get test failures for TAPI current -> Gradle current like:
Failure: Assertion failed:

assert descriptor.parent == null || running.containsKey(descriptor.parent)
       |          |      |       |  |       |           |          |
       |          |      false   |  |       false       |          Configure build
       |          Configure build|  |                   Load projects
       Load projects             |  [Run build:Run build started, Load projects:Load projects started]
                                 false

Cause  : null
Daemons (potentially used): [] - /tmp/test-distribution13818162199348847413/rootDir/build/daemon/distributions-full
Cross version test failure with target version 7.6
[com.gradle.enterprise.testdistribution] Test was part of session 98 and ran on a remote executor named 'gradle-enterprise-test-distribution-agent-764d56f677-cld8v' on host 'gradle-enterprise-test-distribution-agent-764d56f677-cld8v'.

assert descriptor.parent == null || running.containsKey(descriptor.parent)
       |          |      |       |  |       |           |          |
       |          |      false   |  |       false       |          Configure build
       |          Configure build|  |                   Load projects
       Load projects             |  [Run build:Run build started, Load projects:Load projects started]
                                 false
Assertion failed:

assert descriptor.parent == null || running.containsKey(descriptor.parent)
       |          |      |       |  |       |           |          |
       |          |      false   |  |       false       |          Configure build
       |          Configure build|  |                   Load projects
       Load projects             |  [Run build:Run build started, Load projects:Load projects started]
                                 false

	at app//org.gradle.integtests.tooling.fixture.ProgressEvents.assertHasZeroOrMoreTrees(ProgressEvents.groovy:122)
	at app//org.gradle.integtests.tooling.fixture.ProgressEvents.operations(ProgressEvents.groovy:314)
	at app//org.gradle.integtests.tooling.fixture.ProgressEvents.operation(ProgressEvents.groovy:298)
	at org.gradle.integtests.tooling.r25.TaskProgressCrossVersionSpec.task operations have a build operation as parent iff build listener is attached [TAPI current -> Gradle current](TaskProgressCrossVersionSpec.groovy:323)

Do you maybe know how to workaround that? Also cc @adammurdoch

@bot-gradle test this

OK, I've already triggered the following builds for you:

PullRequestFeedback build

OK, I've already triggered the following builds for you:

QuickFeedbackLinux build

@bot-gradle test this

OK, I've already triggered the following builds for you:

PullRequestFeedback build

@bot-gradle test QFL

OK, I've already triggered the following builds for you:

QuickFeedbackLinux build

Donat I created a separate listener BuildPhaseOperationListener.java for these events as I mentioned on Slack. That is because with a mapper I get test failures for TAPI current -> Gradle current, that basically says that "parent of an event should run but it doesn't", like:...
Do you maybe know how to workaround that?

Regarding this, I was able to use BuildOperationMapper and not duplicate methods, but I had to report these events for GENERIC and BUILD_PHASE type.

@bot-gradle test this

@bot-gradle test this

OK, I've already triggered the following builds for you:

PullRequestFeedback build

@bot-gradle test this

OK, I've already triggered the following builds for you:

PullRequestFeedback build

@bot-gradle test and merge

OK, I've already triggered a build for you.

Pre-tested commit build failed.

@bot-gradle test this

OK, I've already triggered the following builds for you:

PullRequestFeedback build

Pre-tested commit build failed.

@bot-gradle test and merge

OK, I've already triggered a build for you.


[release-4.10] Bug 2064901: fix(associations): modifies association return values to allows image…

… skipping
Signed-off-by: Jennifer Power<EMAIL_ADDRESS>Description
This PR fixes a bug with the continue-on-error flag. This will allow for missing images provided in the mapping when associating catalog image layers. With --continue-on-error specified, a warning will be logged for notification.
Type of change
Please delete options that are not relevant.

[X] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

How Has This Been Tested?

[X] Unit test added
[X] Manual testing

Checklist:

[X] My code follows the style guidelines of this project
[X] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[X] I have added tests that prove my fix is effective or that my feature works
[X] New and existing unit tests pass locally with my changes
[ ] Any dependent changes have been merged and published in downstream modules

/bugzilla refresh

@soltysh PTAL (priority 3). Thanks!

/bugzilla refresh

/bugzilla refresh

/bugzilla refresh

/lgtm

/retest

/label cherry-pick-approved


added clip to read_sysex

This fixes the following error for me:
Traceback (most recent call last):
...
    self.mid = MidiFile(filename)
  File ".../site-packages/mido/midifiles/midifiles.py", line 316, in __init__
    self._load(file)
  File ".../site-packages/mido/midifiles/midifiles.py", line 353, in _load
    clip=self.clip))
  File ".../site-packages/mido/midifiles/midifiles.py", line 218, in read_track
    msg = read_sysex(infile, delta)
  File ".../site-packages/mido/midifiles/midifiles.py", line 152, in read_sysex
    return Message('sysex', data=data, time=delta)
  File ".../site-packages/mido/messages/messages.py", line 88, in __init__
    check_msgdict(msgdict)
  File ".../site-packages/mido/messages/checks.py", line 99, in check_msgdict
    check_value(name, value)
  File ".../site-packages/mido/messages/checks.py", line 86, in check_value
    _CHECKS[name](value)
  File ".../site-packages/mido/messages/checks.py", line 37, in check_data
    check_data_byte(byte)
  File ".../site-packages/mido/messages/checks.py", line 58, in check_data_byte
    raise ValueError('data byte must be in range 0..127')
ValueError: data byte must be in range 0..127

I found the similar issue 63.
I think cliping should be done before creating the Message.

Hi there,
Would this fix my issue (#230 ) ?
Thanks

@cameronmantell As far as I can see, you are calling read_sysex as well.
Then this should fix your issue too!

@omit66 I can confirm that your code worked!
I replaced the original mido library with your repo using the command below:
pip install --upgrade https://github.com/omit66/mido/tarball/master
I can now read the midi file that was giving me issues before by using the clip functionality.
Thank you!

@olemb if you could take a look at this PR as well, it'd be great! I've hit this same error, and it'd be great to have a fix!

We somehow overlooked this when adding the clip option. Thanks for the fix!


Fix CI badge on README

Codecov Report

Merging #8 (dcb869b) into 1.x (7bebe27) will decrease coverage by 1.06%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##                1.x       #8      +/-   ##
============================================
- Coverage     70.76%   69.69%   -1.07%
  Complexity       56       56
============================================
  Files             2        2
  Lines           171      198      +27
============================================
+ Hits            121      138      +17
- Misses           50       60      +10

Impacted Files
Coverage Δ

src/OneDriveAdapter.php
69.38% <0.00%> (-1.21%)
:arrow_down:

src/OneDriveMetadata.php
100.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Regression on nightly: The assembled list of ParameterSymbols is invalid. Missing parameters.

CrateDB version
crate/crate:nightly-5.7.0-2024-01-26-00-02
CrateDB setup information
Standard Docker.
Problem description
Similar to GH-10897, the error message is:
(crate.client.exceptions.ProgrammingError)
IllegalStateException[The assembled list of ParameterSymbols is invalid. Missing parameters.]
[SQL: SELECT params.key AS params_key, params.value AS params_value, params.run_uuid AS params_run_uuid
FROM params
WHERE
  params.run_uuid = ? AND
  params.key = ? AND
  params.value IS NULL
LIMIT ?]
[parameters: ('ebda073e99424d038db20200dd37a06d', 'blahmetric', 1)]
(Background on this error at: https://sqlalche.me/e/20/f405)

-- https://github.com/crate-workbench/mlflow-cratedb/actions/runs/7701685602/job/20989123294#step:6:799
It does not happen on all occasions, just in a very specific constellation, like demontrated within the reproducer gist. The error only happens when all conditions are satisfied, i.e. the statements MUST HAVE / USE / CONTAIN:

DDL: A primary key constraint
QUERY: Parameters for querying
WHERE: A parameterized LIMIT clause
WHERE: An IS NULL clause fragment on any column
WHERE: At least one other parameterized query clause on any column

Steps to Reproduce
On mlflow-cratedb, invoke this test case:
pytest -vvv -k test_log_null_param

Derived from that test case, there is also a standalone reproducer gist.
Actual Result
The test case test_log_null_param of mlflow-cratedb started failing.
Expected Result
The test case continues working, and doesn't break.
Evaluation / Regression
With crate/crate:5.6.1, and subsequent nightly releases, everything was fine. Then, four days ago, that changed.

Hi @amotl sorry for the trouble I think https://github.com/crate/crate/pull/15468 should fix the problem, please help double check.

Hi. It looks like the issue is resolved already. When re-running a corresponding CI job that failed previously, it now signals success again. Thanks!
-- https://github.com/crate-workbench/mlflow-cratedb/actions/runs/7701685602


Release 3.0.17

Welcome to Clear Containers 3.0.17 release!
Thi release the clear containers image was updated to the latest agent version. The agent include changes to  support to online vCPUs and  Linux capabilities. Now it has NoNewPrivileges in the api. Finally, the  agent now is the subreaper of all processes.
Changes

versions: image: Update base os to version 20640
build: Don't install git hooks when running under a CI

Shortlog
b0926d4 versions: agent: image: update agent
66f41d6 versions: image: Update base os to version 20640
1c45133 build: Don't install git hooks when running under a CI
Compatibility with Docker
Clear Containers 3.0.17 is compatible with Docker v17.12-ce
OCI Runtime Specification
Clear Containers 3.0.17 support the OCI Runtime Specification v1.0.0-rc5
Clear Linux Containers image
Clear Containers 3.0.17 requires at least Clear Linux containers image 20640
Clear Linux Containers Kernel
Clear Containers 3.0.17 requires at least Clear Linux Containers  kernel v4.9.60-84.container
Installation

BC-Linux

Centos

Clear Linux

Fedora

SLES

Ubuntu

Developers

Issues & limitations
Docker swarm support
See issue #771 for more
Networking
Adding networks dynamically
Resource management
docker run --cpus=
See issue #341 for more information.
docker run --kernel-memory=
See issue #388 for more information.
shm
cgroup constraints
Capabilities
See issue #51 for more information.
sysctl
tmpfs
Other
checkpoint and restore
docker stats
See issue #200 for more information.
runtime commands
ps command
See issue #95 for more information.
events command
See issue #379 for more information.
update command
See issue #380 for more information.
Networking
Support for joining an existing VM network
docker --net=host
docker run --link
Host resource sharing
docker --device
docker -v /dev/...
docker run --privileged
Other
Annotations
runtime commands
init command
spec command
Host rdmsr warnings
More information Limitations

Once the "FIXME" line in the Changes section is removed...
lgtm

@grahamwhaley  any idea about the jenkins errror.
09:19:21 FATAL: Unable to produce a script file

@jcvenegas, @grahamwhaley - I think I found out why:
java.io.IOException: No space left on device

Yep, that would have been my guess. The high level view of the error is that the Jenkins slave service cannot create the script it needs to run.
I'm pretty sure the root cause will be docker eating up disk space with images and items we no longer need (the build servers have sufficient, but limited, storage space). Last time this happened I found and ran a magic 'docker purge old images' type command - I'll go dig that up and put it at the start or end of our Jenkins config command script so we do a 'cleanse cycle' on each build.

OK, it was slightly more complex than that...
We had run out of disk space, but there was more than one reason:

we had a dangling fio test. They create quite a large test file. I suspect this may have been dangling as it was the thing that first hit the out of disk space problem.
We clean up those test normally here: https://github.com/clearcontainers/tests/blob/master/metrics/storage/fio_job.sh#L233

we had a bunch of dangling mounts. I suspect those were left over from a recent dangling mount bug we fixed - I've unmounted them.

we had a bunch of install-asset.xxxx files in /tmp. Unclear exactly how they end up there, but @jcvenegas - the trap EXIT code here: https://github.com/clearcontainers/tests/blob/master/.ci/install_asset.sh#L27
looks a little strange to me - we have two 'cleanup' functions and two 'trap EXIT' registrations - feels wrong. Should that be combined into a single catch and cleanup func?

We have diskspace back now, but there is still a bunch in the overlay2 area - I suspect that is linked to our images. The images we have installed all look pretty valid and current, and I'm holding off the docker system prune and related calls just yet, as they will I think nuke all our downloaded images that we use for each run, so would only get us a short term fix, and then the next run would download them all again. I will note, adding osbuilder into the mix for image download/create looks like it cost us another ~1Gb image to store ;-)
I'll kick this build again to test it - and we'll have to keep an eye on this. I think we will hit disk issues again, and then we'll have to get smarter again.

The rebuild worked btw.

@grahamwhaley I'll send a fix for install_assets.sh


Multi-argument options and conversion

This issue derives from this Stack Overflow question. In that question, the user creates an option that takes two arguments. He can apply a convert operation, but it only applies to the option; it isn't argument-specific. So he can't convert two arguments in different ways.
The workaround provided by the answer is to use a hidden index and a sequence of functions to allow the single function to behave differently for different arguments. But it only works "by accident"; that is, it only works so long as argparse converts arguments in-order and only once per argument.
It might be better to have a more robust solution to this problem. Perhaps convert could take multiple functions, and if you provide such, it applies them to the arguments in-order.

I agree, if an array of functions is passed to convert it should apply them to corresponding arguments. Similar idea is used with argname property already.

Implemented on master branch.


Update Model in DG

Not sure if its an issue but the * filtered in the ModelClassDiagram.png should it be on the right side like before?

Edited

Codecov Report

Merging #141 (088a510) into master (b18e7ef) will increase coverage by 0.98%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master     #141      +/-   ##
============================================
+ Coverage     70.14%   71.13%   +0.98%
- Complexity      547      584      +37
============================================
  Files            88       91       +3
  Lines          1782     1822      +40
  Branches        223      233      +10
============================================
+ Hits           1250     1296      +46
+ Misses          446      443       -3
+ Partials         86       83       -3

Impacted Files
Coverage Δ

...ess/model/person/ModContainsKeywordsPredicate.java
100.00% <0.00%> (ø)

...ss/model/person/NameContainsKeywordsPredicate.java

...del/person/ModTakingContainsKeywordsPredicate.java
100.00% <0.00%> (ø)

...odel/person/ModTakenContainsKeywordsPredicate.java
100.00% <0.00%> (ø)

...n/java/seedu/address/model/util/ModComparator.java
100.00% <0.00%> (ø)

...model/person/DetailsContainsKeywordsPredicate.java
80.00% <0.00%> (ø)

...c/main/java/seedu/address/model/person/Person.java
94.31% <0.00%> (+0.06%)
:arrow_up:

...a/seedu/address/logic/parser/ModCommandParser.java
95.69% <0.00%> (+6.67%)
:arrow_up:

...a/seedu/address/logic/commands/ModFindCommand.java
100.00% <0.00%> (+11.11%)
:arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


New release

Hi there!
I see the changes have been made for the comments bug, but there has not been a release yet. Would it be possible for you to release the new version?
Best
t

I think it will be within 1~2 days.
If you want to use the latest version, try the following. amondnet/vercel-action@master
name: deploy website
on: [pull_request]
jobs:
  deploy:
    runs-on: ubuntu-latest
    steps:
      - uses: actions/checkout@v2
      - uses: amondnet/vercel-action@master
        with:
          vercel-token: ${{ secrets.VERCEL_TOKEN }} # Required
          github-token: ${{ secrets.GITHUB_TOKEN }} #Optional
          vercel-args: '--prod' #Optional
          vercel-org-id: ${{ secrets.ORG_ID}}  #Required
          vercel-project-id: ${{ secrets.PROJECT_ID}} #Required
          working-directory: ./sub-directory

https://github.com/amondnet/vercel-action/releases/tag/v19.0.1%2B2


Change ordering of update in product discounted price task

I want to merge this change because it changes ordering when updating product prices to update the newest first.
ℹ This is a port of https://github.com/saleor/saleor/pull/12669

Impact

[ ] New migrations
[ ] New/Updated API fields or mutations
[ ] Deprecated API fields or mutations
[ ] Removed API types, fields, or mutations
[ ] Documentation needs to be updated

Pull Request Checklist

[ ] Privileged queries and mutations are guarded by proper permission checks
[ ] Database queries are optimized and the number of queries is constant
[ ] Database migration files are up to date
[ ] The changes are tested
[ ] GraphQL schema and type definitions are up to date
[ ] Changes are mentioned in the changelog

Task linked: CLOUD-2788 High memory usage when bulk updating product prices


Not picking up ME sales

Txn IDs for testing:
3poy494S99cQumQ7b7vitzgeh1PirVhCgxHgn1KkivRWJMUqXoWyLrnXwBeSyQoMUzsTRFJLrRQwHKWymv5oKZ1Y
4DP7nozRC7GBF5av2nVsz8AZ1brr9RErznuxyEHEfpDVjtAJs9hXnsHYsz6NoiWd6zcy7HoFbFvMWm7M5y4YsMt7
2RBY52vtWE5v8enniqCRPw8CaMAYik2A2mBUizrvEPt9xMkYwaSU7rnnMeREo1PchjVEtEZH2zmDCnGR4hH2gQ5x
Using the test endpoint, these all return no NFT sale found or no transaction found.

Hmm, this seems to be related to https://github.com/milktoastlab/SolanaNFTBot/issues/55 where Candy machine v2 changed the way it processes royalties which renders the parsing transaction logic useless. Have you tried the latest version? You will have to update the environment variable.

Yes, the version I was building from was 5 days old from when I opened this issue. You're right that this is related to how ME handles royalties. I submitted #59 - a PR to address
The code breaks when it sees only 1 transfer of SOL, expecting there to be multiple transfers (to the seller, and to the creator for royalties)

Hrmm that's a bug. The latest version shouldn't rely on parsing the transaction anymore. New sales should get picked up by hitting MagicEden's API instead. Is that not working for you? Have you turned it on by setting the new MagicEden Env vars?

My ME variables are set and I'll add that it is not picking up sales from the Hot Heads collection. I have to remove the block that was in the PR, then hit the test endpoint with the transaction ID in order to get it to work. Unless I've configured it wrong somehow?

Interesting. What was your environment variable?
I can see the sales activity by hitting the API using hot_heads as the value.
https://api-mainnet.magiceden.dev/v2/collections/hot_heads/activities?offset=0&limit=100

ME discord channel env var is my target channel ID
ME api base url I've left unchanged
ME collection key is hot_heads

XD


Fail if you are not using a callback

Conversation.php, on line 137 or something like that, should be:
if (isset($callback)) {
  $callback($this->current_text, $tokens);
}

You assume there is a callback. No insanity-test, I know it is a blunder, just informing.

BTW, I reduced all your code and classes to about 10 lines. I really dont get your idea with the overkill. But thank you for the inspiration.

Hello David,
Thank you for pointing that out. I fixed it by checking that it's not null.
The code may appear overkill, indeed, as you could even reduce it to one class if that's what you seek. However, it was created based on this Bing AI client, which is meant to provide constant backward compatibility and flexibility when implementing new features - as everything tends to move fast and become multimodal.
README.md contains the bare minimum with main examples, which, in my opinion, are not overkill. In contrast, the example file is here to demonstrate a backward-compatible console implementation. Feel free to avoid it.
Best regards

BTW, I reduced all your code and classes to about 10 lines. I really dont get your idea with the overkill. But thank you for the inspiration.

Could you please gist a copy of your code? Would be nice to use, if it's still working.
Thanks.


Select doesn't have same height as inputs

What was the issue after all? Theme override?

yes right, theme override...


Why i cant use your api, it seems not work, also in your libra wallet POC. May I know when can I use it ?

Why i cant use your api, it seems not work, also in your libra wallet POC. May I know when can I use it ?

Hi @sliverRing, Libra testnet has upgraded and big breaking changes, so we're in process of fixing it, you can follow on this issue https://github.com/kulapio/libra-core/issues/11

Ok, thanks for your great work, do you have time frame for fixing this issue?


UI improved wildlife conservation forum

fixes: issue #917
Implemented UI/UX improvements for the Wildlife Conservation Forum.

@LinukaAr
Your pull request has been successfully merged! Don't stop here—continue contributing by addressing more issues and aiming to become a top contributor. You can also contribute in my another Repository BuddyTrail which is also under Hacktoberfest
Great contribution to HACKTOBERFEST'24! 🎉


Add logging line to measurement

This is a very natural thing to log; that a measurement started.
@QCoDeS/core

@astafan8 It's not completely clear where the completion logging should happen, but probably in the dataset as the dataset is marked complete. Exceptions are already caught by the logging.


Basic walkthrough and associated test script

There should be a relatively simple walkthrough that guides users through the experience of kicking the tires on federation-v2 by deploying a very simple application. Other attributes of this:

Should be possible to do using just minikube (ie, no cloud provider required)
Should cover installing federation and adding new clusters into a federation
There should be a test script that exercises the walkthrough and ensures that the walkthrough 'works'.

Should be possible to do using just minikube (ie, no cloud provider required)
Should cover installing federation and adding new clusters into a federation
There should be a test script that exercises the walkthrough and ensures that the walkthrough 'works'.

I think the first 2 bullet points are more-or-less already covered by #84 depending on what you mean by a simple application. I think the 3rd bullet point is what still needs to be done.

@pmorie
What does your walkthrough means for a script?
From my understanding, below kubectl command line is enough to deploy a simple federation resource.
kubectl apply -f example/sample1/federatednamespace.yaml
kubectl apply -f example/sample1/federateddeployment.yaml

I think a script is suggested because the existing walkthrough is not sufficient.  A revised walkthrough would ideally include something like the following:

apply yaml to create a namespace and resources in that namespace that comprise a web service (i.e. create a non-federated microservice)
federate the application with kubefed federate ns --contents  (e.g. #741)
check the propagation status of the deployment with kubectl get federateddeployment -n <ns> myns (e.g. #843)
check that the web service is healthy (e.g. via curl) on the clusters
adjust the propagation (e.g. remove one cluster) and check the propagation status and check with curl
change an override (e.g. have the message the web service returns be configured via configmap, adjust the value in the configmap with an override, and check that the message the service returns on the cluster has changed)


Add basic gameserver validation on update.

Addresses issue #530.

ping review

Coming back to this - we may want to hold off on this, as @aLekSer is working on bringing a status subresource to GameServers, which will likely tear our approaches asunder.

Hello @markmandel . I think this PR could be pulled to master first and then I will apply it to GS Status PR (which is currently in draft state).
Note that I paused GS status subresource development, it makes E2E tests flaky and there are not so many gains out of separating them for now.

Happy to do that -- in which case,  @jeremyje I had an alternative approach that I proposed a while back - have you had a chance to take a look?

Any objection to me closing this? Seems like it's way behind the , and we'll likely move GameServer to have subresource support before 1.0, which will break things in this yet again.
If I don't hear any objections in 4 days, I'll go ahead and close this to clean things up.

Closing for cleanup.


Support Alibaba Cloud OSS with ObjectStore

Which issue does this PR close?
Closes #566
Rationale for this change
See #566
What changes are included in this PR?

update object_store version to "0.5.2"
support oss:// url in FeatureBasedObjectStoreProvider

Are there any user-facing changes?
None

Thanks @r4ntix for providing OSS support here.


Add details to lock bot message

React Boilerplate
Before opening a pull request, please ensure:

[x] You have followed our contributing guidelines
[x] Double-check your branch is based on dev and targets dev
[x] Pull request has tests (we are going for 100% coverage!)
[x] Code is well-commented, linted and follows project conventions
[x] Documentation is updated (if necessary)
[x] Internal code generators and templates are updated (if necessary)
[x Description explains the issue/use-case resolved and auto-closes related issues

I've seen a few people post issues without using the template who are then confused to see them locked (cf. #2471). I updated the lock bot message to hopefully remove a little bit of confusion.

Coverage remained the same at 100.0% when pulling 3245bd919bc75ba04d6d4bdbcb2d7ce0e1a859f4 on auto-lock-bot-message-update into 26e5bfa280821b73ad1ca868969d316c23808eff on dev.


add '--output text' to AWS CLI calls in aliases that provide env vars

At least on MacOSX, when running aws-ssh, it fails because the IP address provided by aws-ip is wrapped in double quotes.  The call looks like:
ssh -i xyz.pem<EMAIL_ADDRESS>This PR simply removed the quotes from the the $instanceIp var so the ssh call looks like:
ssh -i xyz.pem<EMAIL_ADDRESS>

I handled this a slightly different way. See PR #133
Either way seems fine!

In the setup video we tell people to set their default output to text, so I don't think this PR should be needed.

@jph00 I respectfully disagree.  Telling someone how to satisfy a prerequisite in a video is not as reliable as establishing an environment that satisfies the prerequisite, and in a way that only applies to the context of the operation. I don't think this PR is strictly needed, but I think it is an improvement.


check computed property names in overloads

Fixes #17345
Fixes #52329

@typescript-bot test this
@typescript-bot test top100
@typescript-bot user test this
@typescript-bot perf test this faster

Results are a little old, so, rerunning:
@typescript-bot test this
@typescript-bot test top100
@typescript-bot user test this
@typescript-bot run dt
@typescript-bot perf test this

@gabritto I've seen that above DT change listed on two unrelated PRs now; is there something wrong with the DT runner diff?


WIP: Hiding code blocks (via Custom Views?)

Continuing this thread with @josevalim from the forums, I'd like to propose the ability to hide code blocks from view.
My use-case here is playbooks, where once written, the code takes backseat to operational Markdown instruction, Kino input configuration, and rich outputs. Between Apps and Custom view, there is not quite a way to focus a Livebook like this today.

Approach
The easiest way (discuss: is there a better way?) to accomplish this looks to be the addition of a new option in Custom Views to hide code blocks.
This PR serves as a starting point around the discussion for that UX: adding a [data-js-hide-code] flag inline with other view options, and naively making the [data-type="code"] [data-p-language] code editor @hidden when it is present (aka when the menu item is toggled off).

Problems
Assuming this is an avenue worth investigating, this naive implementation immediately highlights a few UX issues around where and how various UI elements anchored to the code editor appear.
Simple and rich outputs still look good:

However, key contextual elements reliant on hover state become inaccessible in various ways:

The Evaluation Button

The Block Settings

The Section Insertion

Additionally, the Evaluation Status, meant to be shown in the bottom-right of the editor, floats up and over previous section content or the block settings (if forced to be visible) in awkward ways:

Solution
I'm not an adept frontend or UX designer, so my 2 cents shouldn't go too far, and I'm not up to the task of implementing this. But in my mind, a satisfactory solution would be if, when code blocks are set to be hidden:

Forcing the Evaluation Button to be permanently visible, and perhaps a hair larger
Floating the Evaluation Status immediately to the right of the button
Hovering in Section Insertion as normal, inline with the button, in the center
Having Block Settings appear on on the right as normal, on hover over output or this button row in general

Other thoughts
Open to thoughts and other completely different ideas for implementation!
A nice-to-have might be to have a way to exit hide-code mode, or have an individual temporary override toggle per code block cell, right there—either in the Evaluation Button dropdown, or in the Block Settings on the right as a new element.

If this toggle were moved into the Block Settings, it might make sense to always leave that as an option, for temporarily hiding the code editor in any context. How this would interact with a Custom View option merits more consideration, and we could perhaps redirect this effort to simply focus on per-cell hiding behaviour. However, my use-case does want a really easy, single-button, holistic control over hiding code blocks. But maybe we start smaller?

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

One approach I can think of is allow a view where code cells are collapsed similarly to the Setup cell. So there is still a visual indicator of cell being present and hovering over to evaluate and perform actions works, but the code itself is not shown. We would then show the code when entering insert mode, similarly to markdown cells. What do you think?

@christhekeele I'm wondering if a custom view like that would be better for the playbooks use case than a Liveboook app. Let me explain why.
For the playbooks use case, do you think the notebook's execution would need to be paused based on the value of a Kino input? For example, if a certain Kino input is blank, the notebook asks the user to fill in the input and pauses the execution until the input is filled in.
Livebook has Kino.Interrupt!/2 for that need. However, it behaves differently in a Livebook app than in a notebook. In an app, there's no way to skip an interrupted cell unless the interrupt functions stop being called (like in a conditional). But in a notebook, it's possible to "skip" an interrupted cell by just clicking "evaluate" in another cell below the interrupted cell.
What occurred to me is that maybe a "don't show code custom view" could be trying to mimic too much the behavior of a deployed Livebook app in a way that, depending on the use case, it may not make sense to have a custom view for that.
But I can see how the other solution for the use case (using a Livebook app) may require more work for the app developer because now they'd need to use Kino.Markdown for the text parts of the notebook/app instead of just a regular Markdown cell.

@jonatanklosko One approach I can think of is allow a view where code cells are collapsed similarly to the Setup cell. So there is still a visual indicator of cell being present and hovering over to evaluate and perform actions works, but the code itself is not shown. We would then show the code when entering insert mode, similarly to markdown cells. What do you think?

I honestly would quite like that DX when developing Livebooks, playbook-goals aside!

@hugobarauna What occurred to me is that maybe a "don't show code custom view" could be trying to mimic too much the behavior of a deployed Livebook app.

I do feel a little similarly.

But I can see how the other solution for the use case (using a Livebook app) may require more work for the app developer because now they'd need to use Kino.Markdown for the text parts of the notebook/app instead of just a regular Markdown cell.

This is really the main thing I want to avoid; though José had some ideas in the Elixir Forum thread about maybe making the editing experience of a Kino.Markdown more comparable to that of a Livebook.Cell.Markdown. There are challenges there because Kino.Markdown can be much more dynamic than a static markdown cell.
My other idea was to allow rendering of Livebook.Cell.Markdown in Apps, configurable with a toggle when publishing. This works towards a future where Apps can be published alongside their own static usage documentation, with navigable sections to break up the form interactions and app outputs, since the static markdown can be known ahead of time.
I started playing around with a PR for that but realized it would take more effort and refactoring, and wanted to get a discussion started. But perhaps it is the better path towards self-documenting playbooks?

I believe the biggest question we need to answer is: do you want to allow the users to see/change the code or they should never even see it? If they can change the code, add new code cells, etc, then the solution belongs to custom views. If they should never change the code, then the solution belongs within apps.

So with that said, doing something like "Collapse code cells" could work out, and we treat them as the setup one, as proposed by @jonatanklosko. Are you happy with that, @christhekeele and @hugobarauna?

@josevalim to clarify the difference from setup cell would be that focusing the cell would keep the code collapsed, only entering insert mode would show the code. (I mean, we can do either, but for @christhekeele use case we probably don't want to expand the code when someone clicks "Evaluate" and focuses the cell)

Could we instead make it so clicking on it makes the code appears but we skip them when using navigation?

If we want to distinguish click I would make it more explicit, perhaps a pencil icon like the markdown cell, or some button in the collapsed placeholder, like "Collapsed cell [Edit]".

for @christhekeele use case we probably don't want to expand the code when someone clicks "Evaluate" and focuses the cell

If we want to distinguish click I would make it more explicit, perhaps a pencil icon like the markdown cell, or some button in the collapsed placeholder, like "Collapsed cell [Edit]".

Yep, evaluating without expanding would be my preferred UX for developer-oriented playbooks. A separate control for that would be perfect.

Are you happy with that, @christhekeele and @hugobarauna?

Personally, @hugobarauna has convinced me that there's still value to be had in getting markdown into apps for non-developer-oriented playbooks. I know you touched on some ideas there in the forum thread, but that's another discussion/PR/issue at this point.
But what we've discussed here sounds like exactly what I want for my playbooks today, I am happy with the proposed UX for Livebook code hiding controls here!

I'm happy with the final idea as well.
I understood the solution would be a new custom view where:

code cells are collapsed by default
navigating through cells doesn't open a collapsed code cell
to open/edit a collapsed code cell, the user can click a a button/icon

maybe the i keyboard shortcut for "Switch to insert mode" code also open the collapsed code cell, like in a markdown cell

Closing in favour of #2889.


egctl: implement config all command

xref: #915

Codecov Report

Merging #1060 (fc6750c) into main (7419603) will increase coverage by 0.14%.
The diff coverage is 0.00%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@            Coverage Diff             @@
##             main    #1060      +/-   ##
==========================================
+ Coverage   64.61%   64.75%   +0.14%
==========================================
  Files          67       67
  Lines        8726     8730       +4
==========================================
+ Hits         5638     5653      +15
+ Misses       2717     2703      -14
- Partials      371      374       +3

Impacted Files
Coverage Δ

internal/status/status.go
0.00% <0.00%> (ø)

internal/provider/kubernetes/helpers.go
83.78% <0.00%> (-1.36%)
:arrow_down:

internal/provider/kubernetes/controller.go
50.33% <0.00%> (+0.33%)
:arrow_up:

internal/cmd/server.go
17.55% <0.00%> (+10.58%)
:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

shouldnt the title be egctl config envoy-proxy all <instance_name>

thanks @zirain this looks like a great start, hoping you can add some test cases since the current diff coverage for this PR is 0%


Add godep dependency golang.org/x/sys/unix

Fix #7
I've tried this in a brand new GOPATH.
Both "godep restore + godep build" and "go build" work.
@derekwaynecarr @eparis We don't have enough reviewer for this repo yet, are you ok with this PR? If so, I'll manually merge it. :)
/cc @dchen1107

Tested PR, was able to build.
Thanks!

@derekwaynecarr Thanks for reporting the issue and verifying this PR.
Manually merged.


Bitpacking introduction

adds bitpacking, memsize still needs to be swapped over to use the packed array of arrays. Speed is variable, still multiple times faster than FOLCA and ShapedSlp but could likely be faster through minimizing unpack() usage in RanAccV2.

Closing since we ended up going a different direction with the implementation. The new direction definitely used code from this PR :wink:


Include beam_netvars.lua to fix issue with Wiremod update

This fix will stop ACF missiles from breaking entirely for servers using the Github version of Wiremod (and, likely soon, the workshop version) due to removing support for beam_netvars.lua in this update.
Fixes #128
In the future, it may be a better alternative to remove the dependency on beam_netvars.lua but for now, this will fix it.

Wouldn't it be a better idea to just get rid of beam_netvars.lua entirely? It's already doing pretty much the same thing as any [Get/Set]NW* function while only being used on two files.

Yeah, that's the better way to do it, this is a quick fix I'm using on my server because at least right now I can't be bothered to go through and remove the dependency on the beam_netvars file. If someone else wants to create a different PR to do that I'll close this one and let them fix it more properly.


chore: remove replace directive from composer.json

Two packages with the same replace directives (e.g. plugin-quota and plugin-show-folder-size) cannot coexist according to composer.
whalehub@pdh:/opt/mailcow/data/web/roundcube# composer update --no-dev
Loading composer repositories with package information
Updating dependencies
Your requirements could not be resolved to an installable set of packages.

  Problem 1
    - Root composer.json requires jfcherng-roundcube/show-folder-size ~0.7.12 -> satisfiable by jfcherng-roundcube/show-folder-size[0.7.12].
    - Only one of these can be installed: symfony/polyfill-php70[v1.10.0, ..., v1.20.0], jfcherng-roundcube/quota[0.0.19], jfcherng-roundcube/show-folder-size[0.7.12]. [jfcherng-roundcube/quota, jfcherng-roundcube/show-folder-size] replace symfony/polyfill-php70 and thus cannot coexist with it.
    - Root composer.json requires jfcherng-roundcube/quota ~0.0.19 -> satisfiable by jfcherng-roundcube/quota[0.0.19].

Running update with --no-dev does not mean require-dev is ignored, it just means the packages will not be installed. If dev requirements are blocking the update you have to resolve those problems.

Thanks!


ao2mo from scalar integral to complex GHF orbitals

As mentioned in #697, a integral transformation for scalar integrals to complex GHF orbitals is desired, this implementation is based on modifying the r_ao2mo.c and retains a similar structure with that and I put all the functions in a new file called nrr_ao2mo.c and add a corresponding nrr_ao2mo.py in pyscf/ao2mo directory. The nrr_ao2mo.py also deals with scalar integral transform to spinor basis so that it also speeds up the spinor integral transformation.
Since PySCF is now in the process of releasing 2.1.0, this PR can wait until the 2.1.0 release finalizes and does not go into this 2.1.0, but I would like to put it here so that people can have a look at it and have some useful suggestion on how the interface should look like.  @sunqm @fishjojo

@fishjojo Hi Xing, I think this PR is ready to merge, but I seemed to have messed up the commit history when merge the master branch from my side and the authors of a bunch of commits get polluted. Should I close this pr and start a new one or it does not matter?
Best,
Xubo

@xubwa You can rebase your branch

@fishjojo @sunqm It's ready to be reviewed now.

Pleas add a small test to run the nrr_outcore.general function


Possible mistake?

Shouldn't the sentence
First, add the new method to the implementation:
be
First, add the new method to the interface:

Document details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: e3753657-9f0f-4e68-abde-5f461099cb6e
Version Independent ID: f7bd9eb0-1653-15fd-5f0e-dc0ee5c3bf88
Content: Safely update interfaces using default interface methods in C#
Content Source: docs/csharp/tutorials/default-interface-methods-versions.md
Product: dotnet-csharp
Technology: csharp-fundamentals
GitHub Login: @BillWagner
Microsoft Alias: wiwagn

Thanks for pointing this out @stirlingstout
I've opened #18957 to clarify this sentence.


support Storm 0.10

Storm has released 0.10 with bug fixes and new features including

added authentication and authorization
added external connectors, redis, jdbc, hive and flux

I already have a working branch to support the basic usage of Storm 0.10 over Gearpump (not including the above 2 features).
The question is how we plan to support Storm 0.9 and 0.10, and future versions.
It's possible to provide two external Storm modules and one facade in one Gearpump version. Users would need to specify which version of Storm application they want to run on submit

I'm using Storm 0.9.4 and Storm 0.10 is compatibility with 0.9.X ?

Not exactly. Storm-kafka has introduced some breaking changes

Seems Storm Kafka Spout 0.9.X and 0.10.X using difference argument to control start point .  -.-

@manuzhang
Sorry, I don't get your point. Does our code have dependencies on storm-kafka module? If not, why there is compatibility concern?

we have an integration test case StormKafkaTopology that depends on storm-kafka module.

For integration test, I think you can define two different test, with one using storm-kafka 0.9, the other using storm-kakfa0.10, right?
Besides the integration test, do you think there are other blockers for us to support storm-0.1 user jobs?

You are right. We can maintain compatibility for both versions.

storm 0.10 feature list

[ ] basic functionality (storm topology, drpc, multi-lang)
[ ] integration test
[ ] 0.9 compatibility
[ ] storm-kafka (spout / bolt)
[ ] storm-hdfs (bolt)
[ ] storm-hive (bolt)
[ ] storm-hbase (bolt)
[ ] storm-redis (bolt)
[ ] storm-jdbc (bolt)
[ ] flux
[ ] security
[ ] (stretch goal) StreamCQL

Note: unable to verify storm-eventhubs which requires access to Microsoft Azure


html-pdf: Evaluation - ReferenceError: Can't find variable:Package

Hi,
I'm using html-pdf as part of Meteor project this is sample code I use
my function accept html as parameter process it in pdf create and send back base64String of newly generated pdf
....
pdf.create(html, {
    format: 'letter',
    border: { top: '0.6in', right: '0.6in', bottom: '0.6in', left: '0.6in' },
}).toFile(`./tmp/${fileName}`, function (error, response) {
    if (error) {
        console.log(error);
    } else {
        const file = fs.readFileSync(response.filename);
        base64String = new Buffer(file).toString('base64');
        fs.unlink(response.filename);
        return base64String;
    }
});
...

this fails with
I20170929-15:18:26.186(2)? [Error: html-pdf: Received the exit code '1'
I20170929-15:18:26.191(2)? html-pdf: Evaluation - ReferenceError: Can't find variable: Package

any idea what I did wrong there?

That's a javascript error you have in your html file.
The module cancels the rendering if there's an error when executing the js in phantomjs.

@marcbachmann thanks, so you suggest to paste plain html without JS?


Suggestion for Improving the CAGR Calculation in Your Package

Dear
I hope this email finds you well. I have been using your [package name] and find it incredibly useful for my work. However, I encountered an issue with the cagr function that I believe could be improved.
Currently, the calculation of years in the cagr function is performed as follows:
years = (returns.index[-1] - returns.index[0]).days / periods
This method assumes that the periods parameter represents the number of days in a year (e.g., 252 for trading days), but it doesn't account for cases where the number of returns may not span the entire period or if there are missing days in the time series. This can lead to inaccurate results, especially in time series with irregular data points.
I suggest modifying the calculation of years to:
years = len(returns) / periods
This approach uses the length of the returns series to calculate the total number of periods, which provides a more accurate estimation of the years, especially when dealing with incomplete data.
Here's the revised version of the cagr function:
def cagr(returns, rf=0.0, compounded=True, periods=252):
"""
Calculates the communicative annualized growth return (CAGR%) of access returns
If rf is non-zero, you must specify periods.
In this case, rf is assumed to be expressed in yearly (annualized) terms
"""
total = _utils._prepare_returns(returns, rf)
if compounded:
    total = comp(total)
else:
    total = _np.sum(total)

years = len(returns) / periods

res = abs(total + 1.0) ** (1.0 / years) - 1

if isinstance(returns, _pd.DataFrame):
    res = _pd.Series(res)
    res.index = returns.columns

return res

I believe this adjustment will enhance the accuracy and robustness of the CAGR calculation in various scenarios.
Thank you for your time and for maintaining such a valuable package. I look forward to your thoughts on this suggestion.
Best regards,
yuxue wang
<EMAIL_ADDRESS>

Awesome!
Then, out of sudden this happend;
Traceback (most recent call last):
  File "/home/alca/projects/backtrader-quant-main/backtest_cpp_mssql.py", line 103, in backtest
    quantstats.reports.html(returns, output=html_filepath, title=f'{current_date}_{startdate}_to_{enddate}_1m')
  File "/home/alca/projects/.bt/lib/python3.12/site-packages/quantstats/reports.py", line 124, in html
    mtrx = metrics(
           ^^^^^^^^
  File "/home/alca/projects/.bt/lib/python3.12/site-packages/quantstats/reports.py", line 839, in metrics
    metrics["CAGR﹪%"] = _stats.cagr(df, rf, compounded) * pct
                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/alca/projects/.bt/lib/python3.12/site-packages/quantstats/stats.py", line 531, in cagr
    res = abs(total + 1.0) ** (1.0 / years) - 1
                               ~~~~^~~~~~~
ZeroDivisionError: float division by zero

Your fix is just my lifesaver right now, over spend another couple hours figure this out. Many thanks! <3

Has this issue been fixed? I am still seeing incorrect CAGRs due to my data being weekly data and quantstats recognizing only daily data.

Check out https://github.com/Lumiwealth/quantstats_lumi, which is being updated regularly. We are a fork of this library that is being maintained by Lumiwealth


Adapting partial code(file name start with T) to the sonar cloud rule

Codecov Report

Merging #2271 into dev will decrease coverage by 0.01%.
The diff coverage is 48.93%.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1fe5b31...448d42c. Read the comment docs.


Mouse cursor / tooltip

From https://github.com/krzychu124/Cities-Skylines-Traffic-Manager-President-Edition/issues/692#issuecomment-585299284:

We can change cursor to any sprite texture we want and then set offset from center (current OnToolUpdate() code would need a little refactor). I've seen somewhere in code that attaching tool-tip to cursor is also possible.

Speed limtis tool
Show small verison of the speed that user has selected from speed limits palette.
Parking restrictions
Nothing yet, these seem intuitive enough.
Lane arrows
Nothing yet, likely a UI makeover in near future.
Lane connectors
Not sure yet.
Traffic lights
Nothing yet; entire traffic lights stuff needs massive refactor.
Vehicle restrictions
Tooltip: Icon names (eg. "Buses" or "Trucks" etc)?
Junction restrictions
Tooltip: Icon names
Priority signs
Tooltip: Icon names
Notes:
For tooltip stuff, a mod option on general tab "Show icon names in mouse tooltip" (or something like that) so user can turn them off. It's really only helpful for new users.

Whilst wading through ILSpy, noticed this:

ColossalFramework.CursorInfo

Still not seen anything about attaching tooltip to cursor, but will post here if I spot it in my travels.


Warnings should not mask Errors

I am using syntastic with 'signs' enabled, and differentiate warnings and errors by sign color (traditional yellow and red).
When a syntax check finds multiple warnings and errors for a single line, a sign is only displayed for the last item. I've found that if the check finds an error, and then a warning, a sign is displayed for the warning instead of for, in my opinion, the more important error.
I have created a simplistic workaround for this issue, which I've pasted below. In essence, when processing signs, if an error is found, no further signs are processed. Note that I have little experience with vimscript; this may be/is a poor solution, though it does seem to solve the issue.
(The below code is based on git commit: d14b53e903...)
function s:SignErrors()
    if s:BufHasErrorsOrWarningsToDisplay()
        let lnum = 0
        let hasError = 0
        for i in b:syntastic_loclist
            if i['bufnr'] != bufnr("")
                continue
            endif

            if i['lnum'] == lnum
                if hasError
                    continue
                endif
            else
                let lnum = i['lnum']
                let hasError = 0
            endif

            let sign_type = 'SyntasticError'
            if i['type'] == 'W'
                let sign_type = 'SyntasticWarning'
            else
                let hasError = 1
            endif

            exec "sign place ". s:next_sign_id ." line=". i['lnum'] ." name=". sign_type ." file=". expand("%:p")
            call add(s:BufSignIds(), s:next_sign_id)
            let s:next_sign_id += 1
        endfor
    endif
endfunction

Good point - ill make a fix for this.

Hey I have pushed a fix for this. I have also fixed the similar case where the cursor is on a line a warning and an error the warning could be echoed.
Just post here if there are any more issues with this :)


Add clarification: Mapping Tester is not applicable to Trade Desk CRM

Proposed changes

It appears that our The Trade Desk Destination is compatible solely with our Engage platform, and it is one of the few destinations that involves bulk batching. From my understanding, Mapping Tester won't be applicable for this destination, as it's handled through our Bulk Batching process, which does not produce event payloads in a directly observable format - therefore, it won't be feasible to inspect request/response logs in the UI.
Merge timing
ASAP once approved
Related issues (optional)
https://segment.atlassian.net/browse/KCS-1749

Closing this out as the engineer has submitted another PR for the doc changes - https://github.com/segmentio/segment-docs/pull/7283


Update mail_handler_patch.rb

Fix issue #144 - incorrect issue and project ids usage

Just a note: compared the changes, all changes are included in https://github.com/jfqd/redmine_helpdesk/pull/126 as well.

Thanks for pointing this out.


OTA update does not download the second chunk

I found the follwing code:
inline void Firmware_Shared_Attribute_Received(const Shared_Attribute_Data& data) {
  ...
  if (strncmp_P(FW_STATE_DOWNLOADING, m_fwState, strlen(FW_STATE_DOWNLOADING) == 0)) {
            currChunk++;
      }
  ...
}

But I can't find the code like below:
m_fwState = FW_STATE_DOWNLOADING;

currChunk will never accumulate!

This problem is already seen in another post #86


Remove consumer.listTopics() method in case when too many topics in kafka causes the FullGC in Overlord

When there are too many topics in kafka cluster, the method consumer.listTopics() will leads to Full GC in Overlord.

Dumb question why do we even need to list all topics if the user supply the input topic? Can this operation be removed.

@elloooooo am wondering how big the topic list you guys had to see this issue in practice thanks!

@b-slim Someone used to create  20000+ topics at one of our kafka clusters which supports creating topic when needed. Actually his code has bugs.

@elloooooo thanks for the quick fix! The Travis fail looks legit. Would you please fix it?
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.2:testCompile (default-testCompile) on project druid-sql: Compilation failure: Compilation failure:
[ERROR] /home/travis/build/apache/incubator-druid/sql/src/test/java/org/apache/druid/sql/calcite/util/CalciteTests.java:[588,9] incompatible types: java.lang.String cannot be converted to org.apache.druid.discovery.NodeType
[ERROR] /home/travis/build/apache/incubator-druid/sql/src/test/java/org/apache/druid/sql/calcite/util/CalciteTests.java:[585,49] cannot find symbol
[ERROR]   symbol: constructor (org.apache.druid.java.util.http.client.HttpClient,org.apache.druid.discovery.DruidNodeDiscoveryProvider,java.lang.String,java.lang.String,org.apache.druid.curator.discovery.ServerDiscoverySelector)

@elloooooo NVM. Looks like it's caused by the bug which #6466 fixes.

Would you please check the CI failure?
Tests run: 89, Failures: 17, Errors: 8, Skipped: 0, Time elapsed: 57.429 sec <<< FAILURE! - in org.apache.druid.indexing.kafka.supervisor.KafkaSupervisorTest
testResetNoTasks[numThreads = 1](org.apache.druid.indexing.kafka.supervisor.KafkaSupervisorTest)  Time elapsed: 0.155 sec  <<< FAILURE!
java.lang.AssertionError:
  Unexpected method call IndexerMetadataStorageCoordinator.getDataSourceMetadata("testDS"):

@jihoonson I can't figure it out why the travis-ci failed.
Actually, there is no error like this in my local test.

Running org.apache.druid.curator.announcement.AnnouncerTest
No output has been received in the last 10m0s, this potentially indicates a stalled build or something wrong with the build itself.

Could you give me some suggestions？

Hmm, they got stuck again but I restarted them again.

I suspect a race problem of KafkaSupervisorTest. All tests in KafkaSupervisorTest basically executes the below code.
    supervisor.start();
    supervisor.runInternal();
    verifyAll();

However, supervisor.start() also internally calls supervisor.runInternal(). If this method is called twice or more, it can cause the unexpected method call errors reported above. This is not related to this PR anyway.
I left one question. Please take a look.


AttributeError: module 'PIL.Image' has no attribute 'ANTIALIAS'

Pillow=>10.0 seems to have removed attribute "Image".
Downgrading to Pillow==9.5.0 seems to fix the bug

Its depriciated nowdays. In one project i was doing with PIL i found that; LANCZOS instead of ANTIALIAS works in my case and for my use case correct one would be PIL.Image.Resampling.LANCZOS instead of ANTIALIAS. Not sure how would it affect this project but you can give it a try

I'll try this out in a few days
On Sat, Jan 27, 2024, 5:10 PM GPTdomaine @.***> wrote:

Its depriciated nowdays. In one project i was doing with PIL i found that;
LANCZOS instead of ANTIALIAS works in my case and for my use case correct
one would be PIL.Image.Resampling.LANCZOS instead of ANTIALIAS. Not sure
how would it affect this project but you can give it a try
—
Reply to this email directly, view it on GitHub
https://github.com/nadermx/backgroundremover/issues/121#issuecomment-1913087209,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABYACXGXGNTPFVCBH7UKVHDYQTAALAVCNFSM6AAAAABCAAFOC2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMJTGA4DOMRQHE
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

closed in https://github.com/nadermx/backgroundremover/commit/ecd561b61f18bbdcbac48b4929a12bb6508a9d8f


todo file is not taken in to account if cop is in the configuration

When regenerating the todo file, if there is a configuration in .rubocop.yml is duplicated and when running rubocop having a cop in both .rubocop.yml and .rubocop_todo.yml the cop only exclude the ones in .rubocop.yml. This affect Rails/SkipsModelValidations. I didn't try it with other cops.

Steps to reproduce the problem & Actual behavior
.rubocop.yml:
Rails/SkipsModelValidations:
  Exclude:
    - 'src/api/db/migrate/*'
    - 'src/api/app/jobs/*'
    - 'src/api/spec/models/bs_request_action_spec.rb'
    - 'src/api/spec/models/review_spec.rb'

I move the offenses from src/api/app/jobs/* to the file src/api/lib/tasks/project_log_rotate_manually.rake. If I regenerate the todo file, all this is added:
    - 'src/api/db/migrate/*'
    - 'src/api/app/jobs/*'
    - 'src/api/lib/tasks/project_log_rotate_manually.rake'
    - 'src/api/spec/models/bs_request_action_spec.rb'
    - 'src/api/spec/models/review_spec.rb'

That's mean that the configuration in .rubocop.yml is somehow taken into account, but it is also being added to the .todo file. There are currently no even offenses in src/api/app/jobs/*, it appears because it is in .rubocop.yml.
Also if with this you run rubocop, I get the following offense:
src/api/lib/tasks/project_log_rotate_manually.rake:26:83: C: Rails/SkipsModelValidations: Avoid using update_all because it skips validations.
  Event::Base.where(project_logged: false).where(["created_at < ?", oldest_date]).update_all(project_logged: true)

So it seems that the todo file is ignored if there is already a configuration in .rubocop.yml. This affect Rails/SkipsModelValidations. I didn't try it with other cops.
Expected behavior

When regenerating the todo file, if there is a configuration in .rubocop.yml, it is taking into account, in the way that only new offenses are excluded in the todo file.

When running rubocop having a cop in both .rubocop.yml and .rubocop_todo.yml the cop exclude the files that appear in both files.

RuboCop version
$ rubocop -V
0.51.0 (using Parser <IP_ADDRESS>, running on ruby 2.4.2 x86_64-linux-gnu)

It happens also for other cops, for example  Style/DateTime so it seems unrelated from the cop.

I think this is important and shouldn't be closed (not sure if it still happen in the current master version but it would be worthwhile to doble check)


Don't create log file when -f option is set and the --log option not is set

In latest version 0.13.3 the log file is created even when running with the -f option. I think that this is a good idea only if the user set the --log option, because when you run the app in forenground is because you have a daemon controler (like systemd) that collect the log and write the logfile is redundant in this case.

That's a fair point. Adjusted behavior in https://github.com/agersant/polaris/commit/7a73ae7cc0656956b13917e5458b117161401b4d
On Linux:

Running without -f emits a log file
Running with -f and no --log option does not emit a log file
Running with -f and --log option emits a log file

On Windows:

Running with UI feature (polaris.exe in releases) emits a log file
Running without UI feature (polaris-cli.exe in releases) and no --log option does not emit a log file
Running without UI feature (polaris-cli.exe in releases) and --log option emits a log file

That's a fair point. Adjusted behavior in https://github.com/agersant/polaris/commit/7a73ae7cc0656956b13917e5458b117161401b4d
On Linux:

Running without -f emits a log file
Running with -f and no --log option does not emit a log file
Running with -f and --log option emits a log file

On Windows:

Running with UI feature (polaris.exe in releases) emits a log file
Running without UI feature (polaris-cli.exe in releases) and no --log option does not emit a log file
Running without UI feature (polaris-cli.exe in releases) and --log option emits a log file


offsetX and offsetY should be a float

According to the spec (https://developer.mozilla.org/en-US/docs/Web/API/MouseEvent/offsetY) offsetX and offsetY are a float.
They are currently parsed as int so events which contain a float offset are ignored because the decoder fails.
Took me quite a while to figure out why the drop and dragover events were missing in some cases :)
Something else I noticed when I was tracking this down is that you should also call preventDefault on the dragenter event (for example IE11 requires this before it will fire the dragover and drop event). The spec (https://developer.mozilla.org/en-US/docs/Web/Events/dragenter) states that it will cancel the current target as a drop target if you do not call preventDefault so it makes sense to call it.

Yes, I've been trying not to use offsetX and offsetY at all, since they are relative to the target node, and not the droppable, which makes the numbers wrong when an event has bubbled down to the droppable. However, there is no easy way to get the coordinates without calling functions, which you can't do in a decoder. I guess it's possible to traverse up to the document, calculating stuff using a recursive decoder though.
But yes, decoding using float would be better, I'm just curious when you would get non-integer values.
With regards to dragenter, that's something I've missed that you need to prevent default. They don't do it in the example, and that would also mean that you need to catch that event in order to be able to prevent the default.
However, I see no harm in preventing default on that event. It should also stop propagation so that you only get dragenter for the topmost draggable I suppose.
I'll have a look at it tomorrow!

I’m currently not using the position, I managed to make it work by defining dedicated drop zones and using the dropId to arrange highlighting etc (I’m building some kind of kanban board).
I ran into the float values by accident. In FF, Chrome and Edge I get nice integers, but IE11 decided that the offsetY should be a float... Probably some weird layout thing in IE11.
Thanks, for taking a look!

I think my commit closed this automatically, please verify that it is fixed!

IE11 is fixed in 3.1.2, thanks.
Google Chrome is still broken though (was introduced in 3.1.1), but this is already handled in #13.


Fix the register page text while checking responsive

Hii, @swapnilsparsh,
I would like to work on this issue


adding Coursier dependency resolution

[X] I've read the CONTRIBUTING guidelines

[disclaimer]
before merging make sure we default back to Ivy.
Here is the last bit on integrating the Coursier LM implementation to sbt/sbt.
This PR will be used to trigger the community build as well, possibly before merging.
cc. @eed3si9n @alexarchambault

A validation involving this pull request is in progress...

A validation involving this pull request is in progress...

The validator has checked the following projects, tested using dbuild, projects built on top of each other.

Project
Reference
Commit

sbt
pull/4430/head
sbt/sbt@bf90f35e5e9f07ec6d5ca4318d52e6b2f1f93e37

zinc
develop
sbt/zinc@c8e1f5335552bae9a7623d92866a233598fad9fc

io
pull/200/head
sbt/io@21742bf69841f8407ed449815be73bfa15a49f8e

librarymanagement
pull/270/head
sbt/librarymanagement@abc6d6927156970ab858285a71e7ad269be2f5cf

util
develop
sbt/util@cd679591d068c9863919feea4f363070c74f2774

:x: The result is: FAILED
(restart)

A validation involving this pull request is in progress...

The validator has checked the following projects, tested using dbuild, projects built on top of each other.

Project
Reference
Commit

sbt
pull/4430/head
sbt/sbt@bf90f35e5e9f07ec6d5ca4318d52e6b2f1f93e37

zinc
develop
sbt/zinc@c8e1f5335552bae9a7623d92866a233598fad9fc

io
pull/200/head
sbt/io@21742bf69841f8407ed449815be73bfa15a49f8e

librarymanagement
pull/270/head
sbt/librarymanagement@abc6d6927156970ab858285a71e7ad269be2f5cf

util
develop
sbt/util@cd679591d068c9863919feea4f363070c74f2774

:x: The result is: FAILED
(restart)

A validation involving this pull request is in progress...

The validator has checked the following projects, tested using dbuild, projects built on top of each other.

Project
Reference
Commit

sbt
pull/4430/head
sbt/sbt@8a8e33ba63250fed4884e7c5dfedeb23375bdd5a

zinc
develop
sbt/zinc@c8e1f5335552bae9a7623d92866a233598fad9fc

io
pull/200/head
sbt/io@21742bf69841f8407ed449815be73bfa15a49f8e

librarymanagement
pull/270/head
sbt/librarymanagement@abc6d6927156970ab858285a71e7ad269be2f5cf

util
develop
sbt/util@cd679591d068c9863919feea4f363070c74f2774

:x: The result is: FAILED
(restart)

despite the failre we obtained:
[info] Project sbt210-io-------------------: SUCCESS (project rebuilt ok)
[info] Project sbt210-util-----------------: SUCCESS (project rebuilt ok)
[info] Project sbt210-zinc-----------------: SUCCESS (project rebuilt ok)
[info] Project sbt211-io-------------------: SUCCESS (project rebuilt ok)
[info] Project sbt211-librarymanagement----: SUCCESS (project rebuilt ok)
[info] Project sbt211-util-----------------: SUCCESS (project rebuilt ok)
[info] Project sbt211-zinc-----------------: SUCCESS (project rebuilt ok)
[info] Project sbt212----------------------: SUCCESS (project rebuilt ok)
[info] Project sbt212-io-------------------: SUCCESS (project rebuilt ok)
[info] Project sbt212-librarymanagement----: SUCCESS (project rebuilt ok)
[info] Project sbt212-util-----------------: SUCCESS (project rebuilt ok)
[info] Project sbt212-util-interface-------: SUCCESS (project rebuilt ok)
[info] Project sbt212-zinc-----------------: SUCCESS (project rebuilt ok)

https://jenkins.scala-sbt.org:8592/job/sbt-validator/1133/console
Should be good enough to proceed, isn't is? :smile:

The validator has checked the following projects, tested using dbuild, projects built on top of each other.

Project
Reference
Commit

sbt
pull/4430/head
sbt/sbt@8a8e33ba63250fed4884e7c5dfedeb23375bdd5a

zinc
develop
sbt/zinc@c8e1f5335552bae9a7623d92866a233598fad9fc

io
develop
sbt/io@e6529c010c32a93b66f96a027068b7cf160099a0

librarymanagement
pull/270/head
sbt/librarymanagement@abc6d6927156970ab858285a71e7ad269be2f5cf

util
develop
sbt/util@cd679591d068c9863919feea4f363070c74f2774

:white_check_mark: The result is: SUCCESS
The binaries are at https://dl.bintray.com/sbt/maven-snapshots
The new sbt version is: 1.3.0-bin-20181025T102644
(restart)

A validation involving this pull request is in progress...

This is a fantastic step! Thanks @andreaTP!

The validator has checked the following projects, tested using dbuild, projects built on top of each other.

Project
Reference
Commit

sbt
pull/4430/head
sbt/sbt@8a8e33ba63250fed4884e7c5dfedeb23375bdd5a

zinc
develop
sbt/zinc@c8e1f5335552bae9a7623d92866a233598fad9fc

io
develop
sbt/io@e6529c010c32a93b66f96a027068b7cf160099a0

librarymanagement
pull/270/head
sbt/librarymanagement@789a4cc09c1d357e98325eacebc22ac1e54fd495

util
develop
sbt/util@cd679591d068c9863919feea4f363070c74f2774

:white_check_mark: The result is: SUCCESS
The binaries are at https://dl.bintray.com/sbt/maven-snapshots
The new sbt version is: 1.3.0-bin-20181025T151651
(restart)

A validation involving this pull request is in progress...

The validator has checked the following projects, tested using dbuild, projects built on top of each other.

Project
Reference
Commit

sbt
pull/4430/head
sbt/sbt@1ad89a43406c206496f38156af70dea174750171

zinc
develop
sbt/zinc@c8e1f5335552bae9a7623d92866a233598fad9fc

io
develop
sbt/io@e6529c010c32a93b66f96a027068b7cf160099a0

librarymanagement
pull/270/head
sbt/librarymanagement@abc6d6927156970ab858285a71e7ad269be2f5cf

util
develop
sbt/util@cd679591d068c9863919feea4f363070c74f2774

:white_check_mark: The result is: SUCCESS
The binaries are at https://dl.bintray.com/sbt/maven-snapshots
The new sbt version is: 1.3.0-bin-20181026T084504
(restart)

to go ahead I will need a release of LM ( M1 or something) comprehending the coursier PR.

@eed3si9n talking about:

[info] [error] (b / publish) java.lang.IllegalStateException: Ivy file not found in cache for org.example#b_2.12;0.1.0-SNAPSHOT!

this error appear because we are still using Ivy to publish, looks like Ivy expect to have fetched by itself dependencies, i.e. you will overcome it by re-resolving packages with Ivy once.

A validation involving this pull request is in progress...

The validator has checked the following projects, tested using dbuild, projects built on top of each other.

Project
Reference
Commit

sbt
pull/4430/head
sbt/sbt@f4add1bb953946a28f084cfe52644576d477fe01

zinc
develop
sbt/zinc@28c35225b81333e6005440741c680b85d21133b6

io
develop
sbt/io@e6529c010c32a93b66f96a027068b7cf160099a0

librarymanagement
develop
sbt/librarymanagement@92f8b75557f9a29edf1cc7a6c9606f0b7446c60c

util
develop
sbt/util@cd679591d068c9863919feea4f363070c74f2774

:white_check_mark: The result is: SUCCESS
The binaries are at https://dl.bintray.com/sbt/maven-snapshots
The new sbt version is: 1.3.0-bin-20181030T091902
(restart)

I mentioned this on Gitter, but I'll repeat here.
Coursier plugin seems to generate ivy.xml in:

https://github.com/coursier/sbt-coursier/blob/master/modules/sbt-coursier/src/main/scala/coursier/CoursierPlugin.scala

  def makeIvyXmlBefore[T](
    task: TaskKey[T],
    shadedConfigOpt: Option[(String, String)]
  ): Setting[Task[T]] =
    task := task.dependsOn(Def.task {
      val currentProject = {
        val proj = coursierProject.value
        val publications = coursierPublications.value
        proj.copy(publications = publications)
      }
      IvyXml.writeFiles(currentProject, shadedConfigOpt, ivySbt.value, streams.value.log)
    }).value

https://github.com/coursier/sbt-coursier/blob/master/modules/sbt-coursier/src/main/scala/coursier/IvyXml.scala

FYI, I'm currently refactoring sbt-coursier so that:

it offers a module with implementations for sbt/librarymanagement,
it offers an sbt plugin, sbt-lm-coursier, setting dependencyResolution, that should be compatible almost as-is with the current sbt-coursier, passing the scripted tests of sbt-coursier too,
if possible, sbt-lm-coursier should shade coursier itself.

The first two points started fine in https://github.com/coursier/sbt-coursier/pull/5, currently splitting that in clean commits in https://github.com/coursier/sbt-coursier/pull/6 and subsequent PRs.
If all goes well, I'll probably rename the former sbt-coursier to sbt-coursier-legacy, and the new sbt-lm-coursier to sbt-coursier.
Then, I guess we can check if sbt-lm-coursier passes tests under sbt/src/sbt-test/dependency-management in sbt. If it does, then I guess we could consider including it as is in sbt, so that coursier is used by default in it. (Also, its DependencyResolution implem could be used here-or-there in sbt instead of the Ivy one.)

^ I think that provides a clear path towards the use of coursier by sbt. Opinions?

This all aims at finishing the prior work of @leonardehrenfried and @andreaTP.

@alexarchambault your effort is pretty much appreciated, but currently the blocker to have a proper implementation is that the logic for generating the POM file for publishing is pretty hard to replicate ( talking about this: https://github.com/coursier/sbt-coursier/blob/22595d07affff833f42755cb157ca91322267274/modules/sbt-coursier/src/main/scala/coursier/Tasks.scala#L237 ) cc. @eed3si9n

Closing this in favor of https://github.com/sbt/sbt/pull/4614


No messages in /map or /visualization_marker_Array

Hi,
After the assigning the correct scan topic name in the launch file and providing the tf between Odom and base_footprint, I ran the build_map_w_params launch file, then after echoing the topic /map, I get the message.
no messages received and simulated time is active.
Is /clock being published?
What might be the problem?
Regards

Please try to view the map topic on rviz instead of echoing it.
On Fri, Jun 15, 2018 at 3:55 PM BalasubramanyamEvani <
<EMAIL_ADDRESS>wrote:

Hi,
After the assigning the correct scan topic name in the launch file and
providing the tf between Odom and base_footprint, I ran the
buil_map_w_params launch file, then after echoing the topic /map, I get the
message.
no messages received and simulated time is active.
Is /clock being published?
What might be the problem?
Regards
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/sauravag/slam_karto_g2o/issues/3, or mute the thread
https://github.com/notifications/unsubscribe-auth/ADDohlMGI1e5JvJ8e50Y6mEKrLq7SLK0ks5t9B9NgaJpZM4UqI34
.

--
Regards
Saurav

My bad, I was not using --clock argument while playing the bag file. Now it works. Very nice package was thinking of implementing something like this when I saw your blog.
Thanks.

Thanks! glad its working out for you


zoom error

Hello,
When I put a picture in the background, and I'm moving in, the zoom is not done from the center of my image.
Any ideas?
Thank you

The bug is near to this, I think:
var newSize, oldSize;
oldSize = viewportSize * oldScale;
newSize = viewportSize * newScale;

return val + ((oldSize - newSize) / 2);

Please post a demo. It's hard to determine what you're talking about. Also, when pointing to a line of code, please use line numbers.

Ok sorry, line 1777 and the code is :
var lc = null;

var backgroundImage = new Image();
backgroundImage.src = 'google_maps.jpg';

lc = LC.init(document.getElementById('map'), {
    imageURLPrefix: 'lib/literallycanvas/images/',
    tools: [
        LC.tools.Pencil,
        LC.tools.Eraser,
        LC.tools.Line,
        LC.tools.Rectangle,
        LC.tools.Ellipse,
        LC.tools.Text,
        LC.tools.Polygon,
        LC.tools.Pan
    ],
    imageSize: {
        width: 2448,
        height: 3241
    },
    backgroundShapes: [
        LC.createShape(
            'Image', {
                x: 0,
                y: 0,
                image: backgroundImage,
                scale: 1
            }
        )
    ],
    secondaryColor: 'transparent',
    backgroundColor: '#FFFFFF'
});

Try to move the map and zoom on the map. You will see, the zoom doesn't zoom on the center of the viewport.

did you find something ?

Haven't yet had a chance to look, sorry

Hello,
Some news ?
Thanks

Still haven't looked at it. This is a free time project for me.
You are always free to dig into the source code. I know this is response is a trope in the OSS community but there is honestly no guarantee of timeliness for this project.

I just spend a couple hours looking into this and got nowhere.
The truth is that the internal coordinate system is crap, and that is my fault. #322 would fix this, and it's slated for the next major release (0.5). That probably won't come for a few months assuming I keep up the work-on-it-in-my-free-time schedule.

Hello,
Thank you for watching this.

Fixed by #421.


tf version?

hello,what's the tensorflow version of this project?

tf 1.14

Thanks a lot, I  got it.


[Pledge] Multi-Wallet Missing Redirect

@goatsOnDrugs
The wallet I added to my pledge does not redirect to it. This is not a latency issue - I gave it some time.
This wallet should redirect to this wallet since it accepted the push request from the latter (shimond.klima's) pledge.
I see the former as a wallet on the latter's page (note that it's not "pending"), but the former doesn't redirect to the latter:

Note that I created the pledge for the former after accepting the push request from shimond.klima.
This should not be allowed, or at a minimum redirect should still happen.

@ShimonD-KlimaDAO looks like the PR attached to this ticket is ready for retest


Feature/650 category browser - PART 1

The first part contains the network call to categories endpoint, parsing and displaying the categories list.
Some improvement and new libraries are added within this PR:
RxJava : Reactive programming
Dagger : Dependency injection
Enabling data binding to migrate to MVVM
Upgrading dependencies.

I guess we should update Travis to follow up with android upgrade, no ?

Requesting reviews from @herau @itchix and @jinqian who have experience with the codebase, and/or with Android good practises.


bug: Not managed by LazyExtras

Did you check docs and existing issues?

[X] I have read all the LazyVim docs
[X] I have searched the existing issues of LazyVim
[X] I have searched the existing issues of plugins related to this issue

Neovim version (nvim -v)
0.9.5
Operating system/version
MacOS 14.4.1
Describe the bug
I am getting these message about Luasnip and mini-comment not being managed by LazyExtras:

Yet my config has no mention of luasnip or mini-comment:

I also tried removing everything in my plugins folder to see if that fixed the message, but I still get the "not managed by LazyExtras" message.
Steps To Reproduce

Open LazyExtras
Observe the "not managed by LazyExtras" message next to Luasnip and mini-comment

Expected Behavior
Need to manage Luasnip and mini-comment in LazyExtras
Repro
-- DO NOT change the paths and don't remove the colorscheme
local root = vim.fn.fnamemodify("./.repro", ":p")

-- set stdpaths to use .repro
for _, name in ipairs({ "config", "data", "state", "cache" }) do
  vim.env[("XDG_%s_HOME"):format(name:upper())] = root .. "/" .. name
end

-- bootstrap lazy
local lazypath = root .. "/plugins/lazy.nvim"
if not vim.loop.fs_stat(lazypath) then
  vim.fn.system({ "git", "clone", "--filter=blob:none", "https://github.com/folke/lazy.nvim.git", lazypath, })
end
vim.opt.runtimepath:prepend(lazypath)

-- install plugins
local plugins = {
  "folke/tokyonight.nvim",
  "folke/LazyVim",
  -- add any other plugins here
}
require("lazy").setup(plugins, {
  root = root .. "/plugins",
})

vim.cmd.colorscheme("tokyonight")
-- add anything else here

You probably import those Extras in your /lua/config/lazy.lua file. Remove those imports from that file and then enable them via the LazyExtras UI.

Ohh. It's because of your Neovim version. You're on 0.9.5 and that's why those are enabled by default.

That was it! Updgrading nvim to the latest version solved it. Thanks

I'm seeing this issue as well, but I'm running v0.10.0.

Yet no mention of telescope in my config.

That's normal. Telescope was moved to Extras recently and is being imported during the parsing phase. That's why you see this.


How do you pass form errors into a child component

I have a child Vue 3 component that provides the form for a submit action, if there are validation errors, I don't know how to get those errors from the parent down into the form provided by the child so I can show them in the form.

In both the parent and child define a prop called errors. The errors prop must be an empty object by default in the parent passed on to the child.

I use something like this :

I have a Form component to which I pass the current Inertia useForm object

<Form @submit.prevent="submit" :form="form">
  <Input name="lastname" ... />
</Form>

The Form component receives the form props and exposes it

And then my Input component creates a computed value which searches for a parent with the exposed form property (which should exists, because it's supposed to be used inside of the Form component)

<template>

    <input type="text" ... />
    <Error v-if="form?.errors" :error="form.errors[name]" />

</template>

You can just use errors as a regular Vue prop and pass that into the child components:

<template>

        <ChildComponent :errors="errors" />

</template>

However, you can also just use Inertia's form helper, it gives you access to form.errors that you can use inside the child component.
@justageek make sure to close the issue once this is resolved.

Hi there,
Thanks for reporting the problem you are encountering, but it looks like this is a question that may be better suited for a support channel. We only use this issue tracker for reporting bugs with the library itself. If you have a question on how to use the functionality provided by this repository, you can try one of the following channels:

Laracasts Forums
Laravel.io Forums
StackOverflow
Discord
Larachat
IRC

However, this issue will not be locked, and everyone is free to discuss solutions to your problem!


Design Decisions Regarding None-Types For Parameter Validation(s) Steps

Goal
Determine design pattern for parameters of None type in the _assert_sample_and_rtype function (and possibly other functions)
Context
From TPM:

One uncertainty I had was the default behavior for the _assert_sample_and_rtype function generally. Is it a better pattern to not have a skip_if_none param and just instead have _assert_sample_and_rtype be able to handle these scenarios (latent_admissions v. observation_process, None or not None) internally?

From GVY:

That's a good question. I could be useful to post this as an issue/question. Right now, we have the NullRV class which somewhat deals with the None cases. Perhaps we could simply remove the option to skip checks as it should always be an instance of RandomVariable.

Code:
see here for example usage
_assert_sample_and_rtype(latent_infections, skip_if_none=False)
_assert_sample_and_rtype(observation_process, skip_if_none=False)

see here for the _assert_sample_and_rtype
Out of scope

Complete redefinition of _assert_sample_and_rtype

Closing since the relevant validation patterns have now changed.


Add libzstd-dev to NVC dependencies

The master branch will soon require libzstd-dev to build. Also added bison and tcl-dev which are optional dependencies at the moment but might become required at some point.

Want to add yourself to the list of Authors at the top of the file?

Sure.


Wrong Alignment

The following snippet will be rendered with wrong alignment:
- Item 1
- [ ] todo
- Item 2

1. Item 1
2. [x] todo
3. Item 2

With this extension enabled:

With this extension disabled:

Github:

Item 1
[ ] todo
Item 2

Item 1
[x] todo
Item 2

all of the padding-left and margin-left should be removed from the CSS... I've tried creating a style sheet & injecting it into the preview overriding them to either initial !important or unset !important & neither of those renders correctly either
The only way I can get rendering that looks right is by having webview dev tools open & turning off the CSS that this extension injects... I've disabled this extension until there's a fix (I could submit a PR)


Communities add Discord very active this days

https://discord.gg/xjSbJM

Looks good! Send me a PR


Flux points issue  : dat file and plots are not generated after the recent fix

Although the enrico_sed command now runs successfully for numenergybins>0 there is no dat file or resulting plots in the "spectrum" folder as there used to be. The countsplot and resplot are however present. Please note that I also incorporated the changes #128 suggested by @mireianievas yesterday.
myanalysis.txt
PG155+113_PowerLaw2_model.txt

This is a known issue, I will have a look into it. In the meanwhile, running a single enrico_plot_sed generates those plots and text files.

I think this can be marked as closed.


PlutoUI Clock does not work in the version 0.12.21

I have found this is an duplicate issue of #85. Fixed it now :)


config: remove LGTM regex

@Mini256  Could you please take a look?

/hold

/hold cancel

/lgtm

/lgtm cancel

/lgtm

/merge

Sorry about the wrong sample in the document.

Sorry about the wrong sample in the document. @hi-rustin

It's OK. There's no need be sorry. 😆


parser option for image paths

Some markdown editors use a slightly different paths for images (and probably other content). E.g. QOwnNotes adds the prefix 'file://' for every path to an image. In order to make Markor compatible with it, it would be great if you would support a config option for such prefixes, see https://github.com/gsantner/markor/issues/463 This would enable compatibility with Nextcloud Notes and one of the most used desktop client for it. Thanks for considering this feature request!

@schiessle, the mapping of links to resolved links is done by the link resolver. DocxConverter has one implemented that will map a link based on defined page URL and site URL to resolve page relative link addresses and site relative (ones staring with /).
You can implement a custom link resolver that will handle any requirements with a few lines of code. I deliberately left this out because link resolution is highly implementation specific.
I provided the DocxLink Resolver as a sample which can be used as is or customized.
CustomLinkResolverSample.java

@schiessle, the mapping of links to resolved links is done by the link resolver. DocxConverter has one implemented that will map a link based on defined page URL and site URL to resolve page relative link addresses and site relative (ones staring with /).
You can implement a custom link resolver that will handle any requirements with a few lines of code. I deliberately left this out because link resolution is highly implementation specific.
I provided the DocxLink Resolver as a sample which can be used as is or customized.
CustomLinkResolverSample.java

broken link: now https://github.com/vsch/flexmark-java/blob/master/flexmark-java-samples/src/com/vladsch/flexmark/java/samples/CustomLinkResolverSample.java

@rosscallister-rit, thanks. Fixed.
There will be a lot of these as the library is refactored for 0.60. I did not find any tools to help identify broken links in github comments. I might have to throw something together, just have to find the time.


After refund, redirect to refund index page #6355

Issue Reference
#6355
Description
Redirection after creating a refund to refund index page.

@papnoisanjeev
Not working, it is giving an exception if the admin is trying to create a refund before shipping, please find the screenshot Here


[Bug Report] Number input Setter and change event not getting triggered on keyboard inputs. it only happens on focus blur or using the control buttons

Element UI version
2.15.10
OS/Browsers version
macOS Ventura / Chrome, firefox & safari
Vue version
2.7.13
Reproduction Link
https://codepen.io/Albert-Kurian/pen/LYrRVRO?editors=1111
Steps to reproduce
Type in a number into the element number input field using keyboard and then type in a number into the native number input field
What is Expected?
The value setter should get called and change event should be fired.
What is actually happening?
setter was not getting called and change handler was not triggered for element number input until the field lose focus, or the control buttons are used. but native input field updates the value with every key press.

The alternative approach would be to watch the value of "num" and trigger the "handleChange" event accordingly.


Fix typo in optional callbacks

There were some typos:
@optional_callbacks connection: 0, error_happend: 3, error_happend: 4
instead of
@optional_callbacks connection: 0, error_happened: 3, error_happened: 4

Thank you! 👍


Fine-tuning stable-diffusion-xl-1024-v1-0 ModuleNotFoundError: No module named 'stability_sdk.finetune'

Hello, I am following the following document for finetuning stable-diffusion-xl-1024-v1-0
https://next.platform.stability.ai/docs/features/fine-tuning
in the imports
from stability_sdk.finetune import (
create_model, delete_model, get_model, list_models, resubmit_model, update_model,
FineTuneMode, FineTuneParameters, FineTuneStatus
)
I get the error:
ModuleNotFoundError: No module named 'stability_sdk.finetune'
Can anyone please help me with the fix?

Have you figured that out @abdul7235 ?
Facing the exact same issue here.

No, I could not figure it out. I switeched to replicate. They provide a variety of generative models.
Here is the link: https://replicate.com/


Add a test for pyright development versions into the optional workflow

See discussion at https://github.com/microsoft/pyright/issues/6044#issuecomment-1741322364
Instructions for testing stubs against unreleased pyright:

Check out the latest "main" branch of https://github.com/Microsoft/pyright.
Make sure you're using node 16 (which is the version our build system assumes).
From the root directory, execute npm i to install all dependencies.
From the packages/pyright directory, execute npm run build.
To invoke the newly-built version of the pyright cli, execute node pyright/packages/pyright/index.js . Alternatively, you can install the newly-built version globally in your environment using npm install . -g, then invoke it using pyright.

@twoertwein do you want to see if this can be done?

I'm sure it can be done, but I don't think the added complexity and CI runtime are worth it: pyright has frequent releases and fixes all reported bugs pretty much immediately.

I wasn't sure either.


Implement locale selector in React page explorer

This PR implements a locale switcher in the react page explorer.

To simplify the implementation of this PR, I've removed the filter when browsing the root page. It now instead displays the language next to each page:

The selector still appears when you navigate into a page

Rebased on top of https://github.com/wagtail/wagtail/pull/6488

Thanks @allcaps!
Rebased on master


Custom Lint Module

Lets try to put custom Lint to test if we can prevent developers to use certain classes/methods, enforce usage of some and maybe enforce certain dependency rule.

It should work with Kotlin