Possibly Doesn't Build

Let me start by saying that I'm not a full-time Go developer (or even a part-time Go developer), so it's entirely possible that what I'm about to say is 100% off-base.

I installed the Go tools using the .msi available from the official download page. * I configured my GOPATH.
I pulled down the source into the /src subfolder under my GOPATH.
I navigated to that folder in a terminal then executed: glide install
I executed: go build

I received a fountain of errors that seem like some kind of type-confusion.
The full output is:
# github.com/kubernetes-incubator/custom-metrics-apiserver/pkg/apiserver/installer
pkg\apiserver\installer\cmhandlers.go:148:111: cannot use restfulListResource(lister, nil, reqScope, false, a.minRequestTimeout) (type "github.com/kubernetes-incubator/custom-metrics-apiserver/vendor/github.com/emicklei/go-restful".RouteFunction) as type "github.com/kubernetes-incubator/custom-metrics-apiserver/vendor/k8s.io/apiserver/vendor/github.com/emicklei/go-restful".RouteFunction in argument to metrics.InstrumentRouteFunc
pkg\apiserver\installer\cmhandlers.go:151:46: cannot use rootScopedHandler (type "github.com/kubernetes-incubator/custom-metrics-apiserver/vendor/k8s.io/apiserver/vendor/github.com/emicklei/go-restful".RouteFunction) as type "github.com/kubernetes-incubator/custom-metrics-apiserver/vendor/github.com/emicklei/go-restful".RouteFunction in argument to ws.GET(rootScopedPath).To
pkg\apiserver\installer\cmhandlers.go:173:124: cannot use restfulListResource(lister, nil, reqScope, false, a.minRequestTimeout) (type "github.com/kubernetes-incubator/custom-metrics-apiserver/vendor/github.com/emicklei/go-restful".RouteFunction) as type "github.com/kubernetes-incubator/custom-metrics-apiserver/vendor/k8s.io/apiserver/vendor/github.com/emicklei/go-restful".RouteFunction in argument to metrics.InstrumentRouteFunc
pkg\apiserver\installer\cmhandlers.go:174:46: cannot use namespacedHandler (type "github.com/kubernetes-incubator/custom-metrics-apiserver/vendor/k8s.io/apiserver/vendor/github.com/emicklei/go-restful".RouteFunction) as type "github.com/kubernetes-incubator/custom-metrics-apiserver/vendor/github.com/emicklei/go-restful".RouteFunction in argument to ws.GET(namespacedPath).To
pkg\apiserver\installer\cmhandlers.go:197:132: cannot use restfulListResource(lister, nil, reqScope, false, a.minRequestTimeout) (type "github.com/kubernetes-incubator/custom-metrics-apiserver/vendor/github.com/emicklei/go-restful".RouteFunction) as type "github.com/kubernetes-incubator/custom-metrics-apiserver/vendor/k8s.io/apiserver/vendor/github.com/emicklei/go-restful".RouteFunction in argument to metrics.InstrumentRouteFunc
pkg\apiserver\installer\cmhandlers.go:198:60: cannot use namespaceSpecificHandler (type "github.com/kubernetes-incubator/custom-metrics-apiserver/vendor/k8s.io/apiserver/vendor/github.com/emicklei/go-restful".RouteFunction) as type "github.com/kubernetes-incubator/custom-metrics-apiserver/vendor/github.com/emicklei/go-restful".RouteFunction in argument to ws.GET(namespaceSpecificPath).To
pkg\apiserver\installer\emhandlers.go:127:110: cannot use restfulListResource(lister, nil, reqScope, false, a.minRequestTimeout) (type "github.com/kubernetes-incubator/custom-metrics-apiserver/vendor/github.com/emicklei/go-restful".RouteFunction) as type "github.com/kubernetes-incubator/custom-metrics-apiserver/vendor/k8s.io/apiserver/vendor/github.com/emicklei/go-restful".RouteFunction in argument to metrics.InstrumentRouteFunc
pkg\apiserver\installer\emhandlers.go:129:54: cannot use externalMetricHandler (type "github.com/kubernetes-incubator/custom-metrics-apiserver/vendor/k8s.io/apiserver/vendor/github.com/emicklei/go-restful".RouteFunction) as type "github.com/kubernetes-incubator/custom-metrics-apiserver/vendor/github.com/emicklei/go-restful".RouteFunction in argument to ws.GET(externalMetricPath).To
pkg\apiserver\installer\installer.go:79:41: cannot use ws (type *"github.com/kubernetes-incubator/custom-metrics-apiserver/vendor/github.com/emicklei/go-restful".WebService) as type *"github.com/kubernetes-incubator/custom-metrics-apiserver/vendor/k8s.io/apiserver/vendor/github.com/emicklei/go-restful".WebService in argument to versionDiscoveryHandler.AddToWebService
# github.com/kubernetes-incubator/custom-metrics-apiserver/vendor/k8s.io/apiserver/pkg/server/routes
vendor\k8s.io\apiserver\pkg\server\routes\openapi.go:38:91: cannot use c.RegisteredWebServices() (type []*"github.com/kubernetes-incubator/custom-metrics-apiserver/vendor/k8s.io/apiserver/vendor/github.com/emicklei/go-restful".WebService) as type []*"github.com/kubernetes-incubator/custom-metrics-apiserver/vendor/github.com/emicklei/go-restful".WebService in argument to handler.BuildAndRegisterOpenAPIService
vendor\k8s.io\apiserver\pkg\server\routes\openapi.go:42:97: cannot use c.RegisteredWebServices() (type []*"github.com/kubernetes-incubator/custom-metrics-apiserver/vendor/k8s.io/apiserver/vendor/github.com/emicklei/go-restful".WebService) as type []*"github.com/kubernetes-incubator/custom-metrics-apiserver/vendor/github.com/emicklei/go-restful".WebService in argument to handler.BuildAndRegisterOpenAPIVersionedService

Again--I'm a total novice here, so I might be way off base.

You always need to glide install -v to strip nested vendor directories.  Otherwise you'll hit lots of issues.  If you just run make, it's set up with proper Makefile dependencies, so it'll make sure your vendor directory is set up.


fix wallet avatar dropdown on mobile

🟡 Heimdall Review Status

Requirement
Status
More Info

Reviews

🟡
0/1

Denominator calculation

Show calculation

1 if user is bot
0

1 if user is external
0

From .codeflow.yml

1

Additional review requirements

Show calculation

Max
0

0

From CODEOWNERS

0

Global minimum
0

Max

1

1

1 if commit is unverified
0

Sum
1


Question: How to load and pass JSON for facebook greeting screen c#?

Hi,
What's the way to implement greeting screen of FB messenger c# for the bot?

For the moment you may have to make a call directly to Facebook to do this particular operation.  Setting it is not part of the Message API, it's a separate direct call.  The API for that call is reference here:
https://developers.facebook.com/docs/messenger-platform/thread-settings/greeting-text
We're looking at ways we can expose this sort of setup settings in the Bot Framework API.

Thanks for the reply @jameslew
But I am confused, when do i make this API call. As when i add my bot in FB messenger, I dont know for some reason my code in ActivityType.conversationUpdate or relationupdate does not get triggered.
More so FB does not trigger anything on adding the bot. It only does so when I message the bot.
What am I missing here.

You need to make the curl request separately. It does not have anything to do with your bot code.T his is only one time task. You can open cmd or terminal and run that code with your fb page access token and your customised greeting text. for some cases you might need to install curl before you can run this command.

Thanks for the reply.
See my bot is not yet approved. Still in development.
So you are saying that I just make the curl request independently and whenever next time a user adds my bot...it will show the greeting screen?

Yes, currently you'll need to make the separate curl call (albeit it doesn't have to be curl, you could make an http call within your bot's startup code to set the settings).


Support CPU Pinning

Summary
Support CPU Pinning

support enable / disable CPU manager in host page and see status in detail page
support enable CPU Pinning in create VM page.
support toggle CPU Pinning in edit VM page
filter out un-migratable VM when do VM migration

Note. wait for backend PR merge : https://github.com/harvester/harvester/pull/6190
PR Checklist

Is this a multi-tenancy feature/bug?

[ ] Yes, the relevant RBAC changes are at:

Do we need to backport changes to the old Rancher UI, such as RKE1?

[ ] Yes, the relevant PR is at:

Are backend engineers aware of UI changes?

[x] Yes, the backend owner is: @brandboat

Related Issue # https://github.com/harvester/harvester/issues/6056
Screenshot/Video

Enable / disable CPU manager in host page
https://github.com/user-attachments/assets/39ac62ef-0956-4fab-ae66-f01b2430da40

Enable CPU pinning when VM create, disable it afterward

Hint user to turn on CPU manager if no node enabled CPU Manager

https://github.com/user-attachments/assets/2a204edc-1211-46a2-9111-4811bd653bd7

Filter out un-migratable node (harvster-node-0 is not enable CPU manager)

https://github.com/user-attachments/assets/5d097064-717a-4570-8f5a-33973219b51c

@mergify backport release-harvester-v1.4


Add plugins scenarios with input params

Provide examples of scenarios with input params for plugins commands.

Scenario example added here: https://github.com/madcore-ai/cli/blob/master/tests/scenarios/k8s.sh


Copying clip brushes does not render it visually

Copying an invisible clip brush (shows up as either white or yellowish semi-transparent cubes) makes that copy invisible. It can still be selected and works properly ingame, but it cannot be seen in the editor, even after saving and loading the map again all the copies will be invisible. Meanwhile, in vanilla old bspguy you can see them just fine.
EDIT: This is the case with COPIES of those clip brushes. The first original brush model will always display fine. As a workaround I have to right click>copy the original, move it and change it to whatever I need where I need it, and then right click>paste in place/origin  afterwards, so the invisible copy ends up being what the original was, taking its place, and the original ends up being what the copy was supposed to be in the first place. Which is annoying and shouldn't be working like this.

nope. The semi-transparent triggers are now completely solid in color, but the invisible copies of triggers are still invisible


Implement compile action within the plugin

Let's make it possible to run compilation of EO files by the plugin.
As first iteration the action should just trigger eo-maven-plugin steps.
let this action be available via menu item.

@mximp 2 puzzles #28, #29 are still not solved.


Hello, why are STL files published as a single piece instead of separate top and bottom?

Hello, why are STL files published as a single piece instead of separate top and bottom? Thanks.

The problem is too long, you can open it again if necessary


Give UC docs virtual environment a better name

Here are the current README instructions:
python -m venv venv
. ./venv/bin/activate

We should give the virtual environment a better name.  Something like uc_docs_venv or whatever is conventional.
We should also add more instructions on how to use the virtual environment at a later date, how to update it, etc.

I can pick this issue

@asingamaneni - sorry, someone already grabbed this one: https://github.com/unitycatalog/unitycatalog/pull/117
I should have assigned them on this issue, my fault.

Oh, actually I can't assign them cause @arslanaka hasn't commented here yet.

Thanks @arslanaka - assigned this one to you!


Feature Request: Enhance repo/env with Granular Service-Based Environment Variable Validation

Currently, the repo/env package enforces validation of all required environment variables for the different services involved (Clerk, Stripe, Resend, etc.), which means that all applications or packages using repo/env must define all environment variables, regardless of whether they need them or not. I have seen an issue suggesting the creation of a symlink to a file at the project root, which I believe is a very good solution to improve the development experience. However, this approach would still leave some issues unresolved.
Proposed Solution
I propose a more granular solution that allows grouping environment variables by service. The idea is to use boolean flag variables to enable or disable specific services at the application level. By default, services would be disabled. Each app would first set the flag variable of the required service to true and then define the necessary variables for that service. The repo/env package would evaluate which services are active and would configure the validation schema accordingly.
This approach would:

Allow each application to activate only the services it requires through the corresponding flags.
Ensure each application only defines the environment variables relevant to the active services.

Next Steps
If this proposal is of interest, I am willing to create a PR with the necessary changes to implement it.

Hey @enolcasielles cool idea! Definitely open to checking out a PR that implements this.

Feature added on PR #252

I’d suggest something like this. This approach remains compatible with previous versions. If the ENABLE_SERVICES_FLAGS environment variable is not defined, everything works as it did before. Alternatively, we could modify this behavior and make flag variables mandatory. I’d like to hear your thoughts on which approach is better, @haydenbleasel.
In any case, when this behavior is enabled, the functionality is straightforward: all variables are divided into services. The user must specify which services a single app needs to use. Once a service is enabled, all related variables are checked.
The commit also includes a sample env.example file.

Working on it here: https://github.com/haydenbleasel/next-forge/pull/332


fixes break that was introduced

Fixes breakage with the test here https://github.com/containers/ai-lab-recipes/actions/runs/9417989188
Initially thought we were in the clear after my initial PR merged

local build results
e3c6246e
Successfully built llama-cpp-python
Installing collected packages: websockets, uvloop, ujson, typing-extensions, sniffio, shellingham, PyYAML, python-multipart, python-dotenv, pygments, orjson, numpy, mdurl, MarkupSafe, idna, httptools, h11, dnspython, diskcache, click, certifi, annotated-types, uvicorn, pydantic-core, markdown-it-py, jinja2, httpcore, email_validator, anyio, watchfiles, starlette, rich, pydantic, llama-cpp-python, httpx, typer, starlette-context, sse-starlette, pydantic-settings, fastapi-cli, fastapi
Successfully installed MarkupSafe-2.1.5 PyYAML-6.0.1 annotated-types-0.7.0 anyio-4.4.0 certifi-2024.6.2 click-8.1.7 diskcache-5.6.3 dnspython-2.6.1 email_validator-2.1.1 fastapi-0.111.0 fastapi-cli-0.0.4 h11-0.14.0 httpcore-1.0.5 httptools-0.6.1 httpx-0.27.0 idna-3.7 jinja2-3.1.4 llama-cpp-python-0.2.76 markdown-it-py-3.0.0 mdurl-0.1.2 numpy-1.26.4 orjson-3.10.3 pydantic-2.7.3 pydantic-core-2.18.4 pydantic-settings-2.3.1 pygments-2.18.0 python-dotenv-1.0.1 python-multipart-0.0.9 rich-13.7.1 shellingham-1.5.4 sniffio-1.3.1 sse-starlette-2.1.0 starlette-0.37.2 starlette-context-0.3.6 typer-0.12.3 typing-extensions-4.12.1 ujson-5.10.0 uvicorn-0.30.1 uvloop-0.19.0 watchfiles-0.22.0 websockets-12.0
STEP 11/11: ENTRYPOINT [ "sh", "run.sh" ]
COMMIT ghcr.io/containers/llamacpp-python-vulkan:latest
Getting image source signatures
Copying blob 9804fe384688 skipped: already exists
Copying blob e590a5edc3d7 skipped: already exists
Copying blob 3114cc9e3199 skipped: already exists
Copying blob cd147c2a3b94 skipped: already exists
Copying blob c3ce4592529b done   |
Copying config a7e892a00b done   |
Writing manifest to image destination
--> a7e892a00baf
Successfully tagged ghcr.io/containers/llamacpp-python-vulkan:latest
a7e892a00baf596b2928313fdc46b019a19407001ea867b430142da522a429e0

Ill fix the tests here when i get time.

Issue resulted from the fact that Vulkan and Cuda both work with GPUs but the tests were running for CPU only tests for vulkan which resulted in failure.


getCollection for v2

https://github.com/rancher/rancher/issues/8744
rancher-auth-service uses v2 client.Identity. getResource has been modified but getCollection should be changed too.

LGTM


Camera driver

Reopened and closed due to missing comment.
Reason for closure is there are alot of changes in the branch that will need to be adjusted ,


Simplify the FS backed PR

Embeds: https://github.com/microsoft/TypeScript-Website/pull/754
Key commit: https://github.com/microsoft/TypeScript-Website/pull/757/commits/fb2bed52cdf9549886eaf8fd477f255f1cdeaaec

I'm gonna merge this, I sent a PR to yarn to fix CI


Remove upperCase in group header factory snippet

The property upperCase in sap.m.GroupHeaderListItem is deprecated as of 1.40.10. Removing it to avoid encouraging use of it.

Done.


[RESOLVED] S100-Santiago has been restarted (uptime < 10m)

Problem started at 21:00:58 on 2023.07.23
Problem name: S100-Santiago has been restarted (uptime < 10m)
Host: S100-Santiago
Severity: Warning
Operational data: 00:00:13
Original problem ID: 32935
Event details in Zabbix: http://<IP_ADDRESS>/tr_events.php?triggerid=23522&eventid=32935

Problem has been resolved in 10m 4s at 21:11:02 on 2023.07.23
Problem name: S100-Santiago has been restarted (uptime < 10m)
Host: S100-Santiago
Severity: Warning
Original problem ID: 32935


Support rewrite multiple COUNT(DISTINCT expr)

Is your feature request related to a problem or challenge? Please describe what you are trying to do.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
(This section helps Arrow developers understand the context and why for this feature, in addition to  the what)
Describe the solution you'd like
A clear and concise description of what you want to happen.
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.

I'm going to leverage the group by grouping set to rewrite this.  Looks like Presto/Trino also take this approach.
SparkSQL and Calcite have implement this optimizations but they use different approach.

https://github.com/apache/arrow-datafusion/issues/5608

I'm going to add a configure flag to enable the rewrite.

https://issues.apache.org/jira/browse/CALCITE-732


Issue with the JARs created by the Keycloakify bundler

Hello,
As pointed out here "https://docs.keycloakify.dev/build-options#keycloakify.bundler" we should create an issue, if we need to use the legacy mvn bundler. This was the case.
Our use case & issue:
When using the keycloakify build, we need to unpack the generated JARs in the process to add to some additional files and perform some renaming. After using the keycloakify bundler, the JAR files could not be unpacked by using either JAR or unzip -- the errors are added at the bottom.
This is apparently due to the format of the created archive. See the thread here for an explanation: https://stackoverflow.com/questions/47208272/android-zipinputstream-only-deflated-entries-can-have-ext-descriptor
Workaround:
Using mvn as the bundler works fine.

This was the error, when using JAR:
java.util.zip.ZipException: only DEFLATED entries can have EXT descriptor
at java.base/java.util.zip.ZipInputStream.readLOC(ZipInputStream.java:313)
at java.base/java.util.zip.ZipInputStream.getNextEntry(ZipInputStream.java:125)
at jdk.jartool/sun.tools.jar.Main.extract(Main.java:1360)
at jdk.jartool/sun.tools.jar.Main.run(Main.java:409)
at jdk.jartool/sun.tools.jar.Main.main(Main.java:1680)
This was the error, when using unzip:
error: invalid zip file with overlapped components (possible zip bomb)

@dyeske61283 anyway tofind out which jar entry caused the error? Can't reproduce the unzip issue. Can you try unzip again with the zip bomb detection disabled? UNZIP_DISABLE_ZIPBOMB_DETECTION=true unzip -t bla.jar

Quite certain this is related to #330 #331

@lordvlad The unzip did work for me as well on my local machine (MacOS), but not inside a node:18.12.1 docker image (which should be debian-based in our build pipeline). I will disable the detection and try it again.
In regards to the JAR entries: Sadly, starting the JAR executable in verbose mode does not reveal any additional info.

@dyeske61283 can you try using the branch from #339?

@dyeske61283 I just released, you can test with latest. No need to checkout the branch.
@lordvlad next time, if you want to enable pepole to test, just release a candidate updating the package.json version to X.Y.Z-rc.U, this will publish on npm a version that pepole won't get with "latest" but that will be available if they specify the ecact version number.

@lordvlad @garronej  Thank you for your help, I will make sure to test that.
I just now realized, that I should have mentioned, that we are on version 6.13.2. Therefor, I will need to resolve the breaking changes from 6 to 7 first.
I will do that over the next few days and check again.

Okay 👍🏻
It's worth it. V7 is a major improvement in many ways but yeah. There are breaking changes 😕

@garronej can this be closed? wdyt?


Issue with the Canary Instances and max_in_flight

Issue with the Canary Instances and max_in_flight section under - https://docs-pcf-staging.cfapps.io/runtimes/pks/1-2/understanding-upgrades.html. Currently, the documentation states that max in flight impacts upgrade which is not the case. It impacts only cluster creation and resizes.
@carlo-colombo - From our slack conversation earlier.

Thanks, @outofmem0ry. Could you be more specific about the changes you'd like to see in the documentation? For instance, would the following revised language be more accurate?

The max_in_flight variable limits how many instances of a component can restart simultaneously when a cluster is created or resized.
This variable defaults to 1 and can be configured in the PKS API tab of the PKS tile.
Because the value is set to 1, only one component restarts at a time.

Also, because this topic is specific to upgrading PKS, and max_in_flight does not affect upgrades, maybe we should remove the information about max_in_flight from this topic and place it somewhere else?

The description in the docs it's generic to bosh and not specific to pks, our implementation make tha parameter only working for cluster creation and resizing, while for upgrade we want rolling upgrade. Also PKS does not allow to configure the canary value of deployed clusters and it's alway equal to 1.
I think that the actions (creation and resize) when the max in flight is taken in consideration should be added to the description of the field https://docs-pcf-staging.cfapps.io/runtimes/pks/1-2/installing-pks-gcp.html#pks-api

@bentarnoff You have touched upon a good point here. It makes sense to remove it from the upgrade section and add it to the link Carlo pointed to.


Validation: Exists - Weird behaviour

In my request object I have a rule with 'shop_id' => 'required|exists:shops,id'.
This works fine with legit values, and with incorrect numeric IDs like<PHONE_NUMBER>3. However, when I submit a value like 2d34234, it passes the validation and saves an ID of 2 to the database, 33werwerw34234 saves 33 etc.
Likewise, the ID 123123123d34234 fails.
I'm assuming this isn't intended behaviour?

I think the behavior is normal. You should also add the integer rule to get the behavior you want. In the current form when it reaches the exists rule it will run the query for the id which will only take integer values from the string.

OK thanks, I assumed it would just have been a direct match.
So using the example in the docs: 'email' => 'exists:staff,email', does this suddenly not only take integer values and start doing direct matches?

@SteveEdson no. Your id field accepts integer values, in the example the email field accepts text.

@danieliancu yes, so does the validator first check what the column type is, and then start filtering the input then? Or is there a coded exception for id fields? Am I making sense?

@SteveEdson aha I see what you mean. I don't know, I'll look that up. I think this is done at the database level though.

@SteveEdson I don't know what database you use, but in MySQL this is expected behavior, you can test it yourself with simple SQL.
select * from users where id=1
select * from users where id='1'
select * from users where id='1a'

will all give the row where id=1

Yeah MySQL. Fair enough, I never knew about that quirk, thanks for the help!


Now supported in codespaces

waitFor and workspaceFolder are now supported in Codespaces.

Just opened https://github.com/devcontainers/devcontainers.github.io/pull/53 for the site


Choose a new font

We are currently using Syne for the font of the website. Choose a better font for the website in a new pull request

Hello, can I pick this up?

Hello @3n1k0 yes you can I will assign you


Auto generate documents with typedoc

If possible, I will sumbit a PR to use typedoc to automatically generate documentation once we have migrated to typescript. Then maybe we can use a github page to host the documents. So people can easily see the apis provided by the lib.
Discussion is more than welcome 👏

We may not migrate to typescript for this repo (for a variety of reasons), however if you notice #39 we are adding typings (and just finalizing the details). Is typedoc capable for supporting just typings also or no?

@TheLarkInn TypeDoc should be able to document from typings. Let me know if you would like any help with this.
FYI, as a maintainer of typedoc, I'm looking into whether tapable would be helpful for our plugin system.


Update the project for github migration

Update URL
Add README.md/License/Contributing info to be up to spec.

LG


Change log level to warn when truncating messages on notification integrations

We currently use debug and then show the original message, but this seems like something worn noting even when debug logging is not turned on.

Maybe we could warn about truncation, but the full message should never show in warn

I agree that having the non-truncated message in the logs would be too noisy. It might be worth having a counter reporting how many times notifications were truncated (otherwise nobody will notice)?


Track 'Ace'

Vendor Site - https://github.com/ajaxorg/ace
Example Sites:
https://ace.c9.io/
https://projectfluent.org/play/
Category - Rich text editors (?)
Detection - html/css class named ace_content

Hey @John4266 , added thanks!!!


New features should be drawn on top

There isn't a straightforward solution here. Re-arranging the styling order in https://github.com/mapbox/gl-draw/blob/dev-pages/src/theme/style.js works fine enough.


AOT_SECTION_TYPE_SIGNATURE

what's AOT_SECTION_TYPE_SIGNATURE?
as the loader seems to reject it, i guess it's something not used anymore. right?

Yes but not so correct, in fact it isn't used yet and is just reserved for future use. One scenario I can image is that maybe in the future developer can append signature into the AOT file and provide the signature check callback function to the aot loader, and when aot loader finds there is signature section, it can call the callback with file buffer and size to check.

ok. thank you for explanation.


[Document] Want to make Neat UI for videos in DOCS

want to make cooler UI to show videos in DOCS

@sanketshinde3001 pr welcome!

@zhoushaw I'll complete it by EOD.


Prefer return nothing over bare return

I thought this was already the BlueStyle guidance, but i don't see it.
Which is preferred?
(a)
function maybe_do_thing()
    # code
    return
end

or
(b)
function maybe_do_thing()
    # code
    return nothing
end

If we are agreed on option (b) already we should write it down and i'll add it to the to-do list in https://github.com/domluna/JuliaFormatter.jl/issues/283

Personally I prefer the explicit style of option b.

I would go as far as saying if a return statement is used a value should be explicitly returned even if that value is nothing


Update custom SQL results to match new table view header

Follow-on from #147 - the custom SQL results page should more closely match the design of the table view, which now looks like this:

Custom SQL results now look like this:


Upload files queue broke while remove a file before is uploaded

Hi there!
First thing first, awesome plugin!
But sadly i found an issue, when we get a files queue and cancel one the file before his upload start, or if his upload fail, the next file to be uploaded never start.
I think the easiest way to reproduce this issue it's to upload something like 5 files on a filepond with maxParallelUploads to 1 (the bug exist also without this, but it more easy to test it like this).
While the first files upload, remove one of the waiting ones (else than the last one) and the upload queue will stop when it arrive to his "ghost".
Hope the description is enough to help you to reproduce the issue and fix it!
Thanks!

Should be fixed in version 4.4.3

This problem still exists in version 4.4.11 when cancelling an active upload with multiple concurrent uploads. If there are 2 concurrent uploads, cancelling one will only "block" that upload "slot", the other upload slot still begins uploading the next file in line when it finishes, while cancelling both will leave all pending uploads in the "waiting" stage.

@tobias7an will run some tests

@tobias7an I can't reproduce this, do you have a custom server.process implementation, and if so, are you calling the abort method?


Provision for parameters in dependent implementation

The current implementation does not allow for more parameters to be added to the object being upload (for eg, deleteAfter, deleteAt etc). See additional parameters here
By having a method in the adapter, any dependent implementation (like my package sausin/laravel-ovh) can add these additional parameters, if required, by overriding the new getData method without having to change the base implementation of write, or writeStream methods

If this change is okay, it would be awesome if you could please add a new release so another merged PR allowing configuration of segmentSize would be available :smiley:

The original author hasn't created a new release for some time. That's why I created my fork with the most recent updates. If the author continues to be unresponsive, consider to use the fork instead.

@mzur Thanks for the info! I've created the pull request :+1:

Thank you.
I am picking this project back up now.
@mzur If you like, I can give you write access to this repository so you can help maintain the project?

@chrisnharvey Yes, sure. I'll merge the current differences between our repos then.

@mzur Awesome! I've given you access to the repo.


Improve releases wording

Describe the problem
This isn't a bug nor a feature request per se, but if you take releases texts like on the last release for example (3.5.3), it comes like that:
[Changes of this release]
Changes since v3.5.2:
[Changes of release 3.5.2]
Changes since v3.5.1:
[Changes of release 3.5.1]
And so on.
Describe the solution
I can be completely wrong (as English isn't my native language), but with this wording, one would expect in the block under "Changes since v3.5.2" the changes that happened between the release 3.5.2 and the current one, not the changes between 3.5.1 and 3.5.2.
Likewise, when come the text "Changes since v3.5.1", we could expect all the changes between 3.5.1 and current release, 3.5.3, and it'd be cumulative, not the changes between 3.5.0 and 3.5.1.
The current wording bring confusion imho and should be improved (by using "changes in release vx.y.z for example instead, or just by not bringing changes from previous older releases in this text), but I don't know where this is set.

Thank you for your comment.
I have made the appropriate changes on all the release notes.

It's easier to have the complete info when it is located in one release note.


Guidance on not linking to social media is inconsistent with GOV.UK

Related documentation
Help users to contact a department or service team
Suggestion
The current guidance contains the following:

If you have social media channels:

list these channels last
do not include a link to the social media sites you’re using - read more about this in GOV.UK’s external linking policy
tell users not to share personal information with you

The example given is:

You can use Twitter to get general help. We cannot discuss specific cases or individual applications, so please do not give any personal details.
Twitter: @GOVUK

I don't think omitting links to social media is the best thing for the user, because:

it means they need to memorise the handle to search for it on the social media platform, which may be more difficult for those with short-term memory issues
it increases friction, especially for users of assistive technology
it increases the risk of the user finding the wrong profile if they misremember the handle, make a typo or the search results aren't as expected - this could mean they find fraudulent profiles instead

The guidance implies that linking to social media profiles is forbidden by the GOV.UK external link policy, but almost every ministerial department on GOV.UK links to social media on their homepage, for example for MOD:

Hi @matteason,
Thanks for raising this. I'm not familiar enough with how government departments use social media as a whole but my thoughts would be that anything published on the social media channel should also be visible on GOV.UK pages.
I've started a conversation with my team about this and we'll see what improvements we can feed into the guidance.

Hi @matteason,
Thanks for raising this. I'm not familiar enough with how government departments use social media as a whole but my thoughts would be that anything published on the social media channel should also be visible on GOV.UK pages.
I've started a conversation with my team about this and we'll see what improvements we can feed into the guidance.

Thanks @CharlotteDowns. This is in the context of using social media as a contact/support channel so it's not necessarily about informational content that should hopefully also be included on GOV.UK - for example DVLA reply to enquiries on Twitter as a matter of course. In my mind, not linking to the account is akin to not making an email address a link - it's fine but not ideal and it's more error-prone


Update README.md

Pull Request type

[ ] Bugfix
[ ] Feature
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes (Please run ./gradlew generateLock saveLock to refresh dependencies)
[ ] WHOSUSING.md
[x ] Other (please describe):

Changes in this PR
Added client SDKs
Describe the new behavior from this PR, and why it's needed
Issue #
Alternatives considered
Describe alternative implementation you have considered

@CherishSantoshi please resolve the comments above and we are good to merge.

This is done @apanicker-nflx and @aravindanr

@CherishSantoshi There are no changes here, is this intentional?

Yes, moved all changes to RELATED.md as suggested by @aravindanr in the first comment.
Raised another PR for the same - https://github.com/CherishSantoshi/conductor/pull/2
Have I missed anything?

The new PR uses your fork as the base and does not attempt to push to upstream.

Sorry about that. Closing this PR.
The update can be found in a new PR - https://github.com/Netflix/conductor/pull/2952


Pro hexagon not following commands

I have a couple of plus and pros
the pros when using the service light.on in an automation are not setting the color. the brightness works ok.
I've tried RGB and collar name but it is not changing out of whichever mode it is in.
do you have any idea why this is?
the plus do respond as expected to the service call

Are you able to share the automation you're using for the pros?


Locus page should update entity parameters in URL string when entities are clicked

Clicking an entity (eg. gene, variant, leadVariant, disease) does not currently affect the URL string. It probably should in the future, so that selections within a window can be shared.

Done on graphql branch.


Searchbar searchhistory

Layout change, back to 3 cards, added main top nav bar, with back button,  new search and search history dropdown

Should be all good to be merged.


Support for Elasticache Redis Cluster enabled

Hi,
By any chance, is there any plan to support , e.g: Lettuce Redis cluster client?
Looking at the current API LettuceBasedProxyManager only take a non clustered Redis client.
Thank you!

Hello @lindahm
Feel free to prepare pull-request with desired functionality.

Hi, lettuce cluster supported, this pr https://github.com/bucket4j/bucket4j/pull/338 🙂


Fix Micrometer JSON serialization error

What does this PR do?
Fixes #1759.
I noticed that the error only happened after trying to write zero metrics, which only happened in CI, but never managed to reproduce locally in the same way as the CI did.

:broken_heart: Tests Failed

the below badges are clickable and redirect to their specific view in the CI or DOCS

Expand to view the summary

Build stats

Build Cause: Pull request #1764 opened

Start Time: 2021-04-15T15:52:49.874+0000

Duration: 33 min 44 sec

Commit: 941cde16a9f1f43ed1fe4b5838b697b199947c0b

Test stats :test_tube:

Test
Results

Failed
1

Passed
1871

Skipped
18

Total
1890

Trends :test_tube:

Test errors
Expand to view the tests failures
Tests / Smoke Tests 01 / co.elastic.apm.agent.rabbitmq.RabbitMQ4xPluginIT – co.elastic.apm.agent.rabbitmq.RabbitMQ4xPluginIT

Expand to view the error details
 Container startup failed

Expand to view the stacktrace
 org.testcontainers.containers.ContainerLaunchException: Container startup failed
Caused by: org.rnorth.ducttape.RetryCountExceededException: Retry limit hit with exception
Caused by: org.testcontainers.containers.ContainerLaunchException: Could not create/start container
Caused by: org.testcontainers.containers.ContainerLaunchException: Timed out waiting for log output matching '.*Server startup complete.*'

Steps errors
Expand to view the steps failures

Shell Script

Took 19 min 3 sec . View more details on here
Description: ./scripts/jenkins/smoketests-01.sh

Log output
Expand to view the last 100 lines of log output

[2021-04-15T16:25:23.986Z] [ERROR] Please refer to /var/lib/jenkins/workspace/_java_apm-agent-java-mbp_PR-1764/src/github.com/elastic/apm-agent-java/integration-tests/application-server-integration-tests/target/failsafe-reports for the individual test results.
[2021-04-15T16:25:23.986Z] [ERROR] Please refer to dump files (if any exist) [date].dump, [date]-jvmRun[N].dump and [date].dumpstream.
[2021-04-15T16:25:23.987Z] [ERROR] org.apache.maven.surefire.booter.SurefireBooterForkException: The forked VM terminated without properly saying goodbye. VM crash or System.exit called?
[2021-04-15T16:25:23.987Z] [ERROR] Command was /bin/sh -c cd /var/lib/jenkins/workspace/_java_apm-agent-java-mbp_PR-1764/src/github.com/elastic/apm-agent-java/integration-tests/application-server-integration-tests && /var/lib/jenkins/.java/oracle-11.0.6+8-linux/bin/java -javaagent:/var/lib/jenkins/workspace/_java_apm-agent-java-mbp_PR-1764/src/github.com/elastic/apm-agent-java/.m2/org/jacoco/org.jacoco.agent/0.8.5/org.jacoco.agent-0.8.5-runtime.jar=destfile=/var/lib/jenkins/workspace/_java_apm-agent-java-mbp_PR-1764/src/github.com/elastic/apm-agent-java/integration-tests/application-server-integration-tests/target/jacoco.exec -jar /var/lib/jenkins/workspace/_java_apm-agent-java-mbp_PR-1764/src/github.com/elastic/apm-agent-java/integration-tests/application-server-integration-tests/target/surefire/surefirebooter4601765297314738317.jar /var/lib/jenkins/workspace/_java_apm-agent-java-mbp_PR-1764/src/github.com/elastic/apm-agent-java/integration-tests/application-server-integration-tests/target/surefire 2021-04-15T16-06-29_854-jvmRun1 surefire16900222359144251480tmp surefire_128463559841953170276tmp
[2021-04-15T16:25:23.987Z] [ERROR] Error occurred in starting fork, check output in log
[2021-04-15T16:25:23.987Z] [ERROR] Process Exit Code: 143
[2021-04-15T16:25:23.987Z] [ERROR] Crashed tests:
[2021-04-15T16:25:23.987Z] [ERROR] co.elastic.apm.servlet.WildFlyIT
[2021-04-15T16:25:23.987Z] [ERROR] 	at org.apache.maven.plugin.surefire.booterclient.ForkStarter.fork(ForkStarter.java:669)
[2021-04-15T16:25:23.987Z] [ERROR] 	at org.apache.maven.plugin.surefire.booterclient.ForkStarter.run(ForkStarter.java:282)
[2021-04-15T16:25:23.987Z] [ERROR] 	at org.apache.maven.plugin.surefire.booterclient.ForkStarter.run(ForkStarter.java:245)
[2021-04-15T16:25:23.987Z] [ERROR] 	at org.apache.maven.plugin.surefire.AbstractSurefireMojo.executeProvider(AbstractSurefireMojo.java:1183)
[2021-04-15T16:25:23.987Z] [ERROR] 	at org.apache.maven.plugin.surefire.AbstractSurefireMojo.executeAfterPreconditionsChecked(AbstractSurefireMojo.java:1011)
[2021-04-15T16:25:23.987Z] [ERROR] 	at org.apache.maven.plugin.surefire.AbstractSurefireMojo.execute(AbstractSurefireMojo.java:857)
[2021-04-15T16:25:23.987Z] [ERROR] 	at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:137)
[2021-04-15T16:25:23.987Z] [ERROR] 	at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:210)
[2021-04-15T16:25:23.987Z] [ERROR] 	at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:156)
[2021-04-15T16:25:23.987Z] [ERROR] 	at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:148)
[2021-04-15T16:25:23.987Z] [ERROR] 	at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:117)
[2021-04-15T16:25:23.987Z] [ERROR] 	at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:81)
[2021-04-15T16:25:23.987Z] [ERROR] 	at org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build(SingleThreadedBuilder.java:56)
[2021-04-15T16:25:23.987Z] [ERROR] 	at org.apache.maven.lifecycle.internal.LifecycleStarter.execute(LifecycleStarter.java:128)
[2021-04-15T16:25:23.987Z] [ERROR] 	at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:305)
[2021-04-15T16:25:23.987Z] [ERROR] 	at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:192)
[2021-04-15T16:25:23.987Z] [ERROR] 	at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:105)
[2021-04-15T16:25:23.987Z] [ERROR] 	at org.apache.maven.cli.MavenCli.execute(MavenCli.java:957)
[2021-04-15T16:25:23.987Z] [ERROR] 	at org.apache.maven.cli.MavenCli.doMain(MavenCli.java:289)
[2021-04-15T16:25:23.987Z] [ERROR] 	at org.apache.maven.cli.MavenCli.main(MavenCli.java:193)
[2021-04-15T16:25:23.987Z] [ERROR] 	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
[2021-04-15T16:25:23.987Z] [ERROR] 	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
[2021-04-15T16:25:23.987Z] [ERROR] 	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
[2021-04-15T16:25:23.987Z] [ERROR] 	at java.base/java.lang.reflect.Method.invoke(Method.java:566)
[2021-04-15T16:25:23.987Z] [ERROR] 	at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced(Launcher.java:282)
[2021-04-15T16:25:23.987Z] [ERROR] 	at org.codehaus.plexus.classworlds.launcher.Launcher.launch(Launcher.java:225)
[2021-04-15T16:25:23.987Z] [ERROR] 	at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode(Launcher.java:406)
[2021-04-15T16:25:23.987Z] [ERROR] 	at org.codehaus.plexus.classworlds.launcher.Launcher.main(Launcher.java:347)
[2021-04-15T16:25:23.987Z] [ERROR] 	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
[2021-04-15T16:25:23.987Z] [ERROR] 	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
[2021-04-15T16:25:23.987Z] [ERROR] 	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
[2021-04-15T16:25:23.987Z] [ERROR] 	at java.base/java.lang.reflect.Method.invoke(Method.java:566)
[2021-04-15T16:25:23.987Z] [ERROR] 	at org.apache.maven.wrapper.BootstrapMainStarter.start(BootstrapMainStarter.java:39)
[2021-04-15T16:25:23.987Z] [ERROR] 	at org.apache.maven.wrapper.WrapperExecutor.execute(WrapperExecutor.java:122)
[2021-04-15T16:25:23.987Z] [ERROR] 	at org.apache.maven.wrapper.MavenWrapperMain.main(MavenWrapperMain.java:55)
[2021-04-15T16:25:23.987Z] [ERROR] -> [Help 1]
[2021-04-15T16:25:23.987Z] [ERROR]
[2021-04-15T16:25:23.987Z] [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[2021-04-15T16:25:23.987Z] [ERROR] Re-run Maven using the -X switch to enable full debug logging.
[2021-04-15T16:25:23.987Z] [ERROR]
[2021-04-15T16:25:23.987Z] [ERROR] For more information about the errors and possible solutions, please read the following articles:
[2021-04-15T16:25:23.987Z] [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException
[2021-04-15T16:25:23.987Z] [ERROR]
[2021-04-15T16:25:23.987Z] [ERROR] After correcting the problems, you can resume the build with the command
[2021-04-15T16:25:23.988Z] [ERROR]   mvn <args> -rf :application-server-integration-tests
[2021-04-15T16:25:24.313Z] script returned exit code 143
[2021-04-15T16:25:25.472Z] Post stage
[2021-04-15T16:25:25.527Z] Recording test results
[2021-04-15T16:25:26.946Z] [Checks API] No suitable checks publisher found.
[2021-04-15T16:25:27.014Z] Running in /var/lib/jenkins/workspace/_java_apm-agent-java-mbp_PR-1764/src/github.com/elastic/apm-agent-java
[2021-04-15T16:25:27.071Z] [INFO] Codecov: Getting branch ref...
[2021-04-15T16:25:27.225Z] Masking supported pattern matches of $GITHUB_TOKEN
[2021-04-15T16:25:27.491Z] [INFO] Codecov: Sending data...
[2021-04-15T16:25:28.063Z] + curl -sSLo codecov.sh https://codecov.io/bash
[2021-04-15T16:25:28.466Z] + bash codecov.sh
[2021-04-15T16:25:28.466Z]
[2021-04-15T16:25:28.466Z]   _____          _
[2021-04-15T16:25:28.466Z]  / ____|        | |
[2021-04-15T16:25:28.466Z] | |     ___   __| | ___  ___ _____   __
[2021-04-15T16:25:28.466Z] | |    / _ \ / _` |/ _ \/ __/ _ \ \ / /
[2021-04-15T16:25:28.466Z] | |___| (_) | (_| |  __/ (_| (_) \ V /
[2021-04-15T16:25:28.466Z]  \_____\___/ \__,_|\___|\___\___/ \_/
[2021-04-15T16:25:28.466Z]                               Bash-1.0.1
[2021-04-15T16:25:28.466Z]
[2021-04-15T16:25:28.466Z]
[2021-04-15T16:25:28.466Z] ==> git version 2.17.1 found
[2021-04-15T16:25:28.466Z] ==> curl 7.58.0 (x86_64-pc-linux-gnu) libcurl/7.58.0 OpenSSL/1.1.1 zlib/1.2.11 libidn2/2.0.4 libpsl/0.19.1 (+libidn2/2.0.4) nghttp2/1.30.0 librtmp/2.3
[2021-04-15T16:25:28.466Z] Release-Date: 2018-01-24
[2021-04-15T16:25:28.466Z] Protocols: dict file ftp ftps gopher http https imap imaps ldap ldaps pop3 pop3s rtmp rtsp smb smbs smtp smtps telnet tftp
[2021-04-15T16:25:28.466Z] Features: AsynchDNS IDN IPv6 Largefile GSS-API Kerberos SPNEGO NTLM NTLM_WB SSL libz TLS-SRP HTTP2 UnixSockets HTTPS-proxy PSL
[2021-04-15T16:25:28.466Z] ==> Jenkins CI detected.
[2021-04-15T16:25:28.466Z]     project root: .
[2021-04-15T16:25:28.466Z] --> token set from env
[2021-04-15T16:25:28.466Z]     Yaml not found, that's ok! Learn more at http://docs.codecov.io/docs/codecov-yaml
[2021-04-15T16:25:28.467Z] ==> Running gcov in . (disable via -X gcov)
[2021-04-15T16:25:28.732Z] ==> Python coveragepy not found
[2021-04-15T16:25:28.732Z] ==> Searching for coverage reports in:
[2021-04-15T16:25:28.732Z]     + .
[2021-04-15T16:25:29.314Z] --> No coverage report found.
[2021-04-15T16:25:29.314Z]     Please visit http://docs.codecov.io/docs/supported-languages
[2021-04-15T16:25:29.765Z] Failed in branch Smoke Tests 02
[2021-04-15T16:25:30.137Z] Stage "Integration Tests" skipped due to earlier failure(s)
[2021-04-15T16:25:30.266Z] Stage "Stable" skipped due to earlier failure(s)
[2021-04-15T16:25:30.406Z] Stage "AfterRelease" skipped due to earlier failure(s)
[2021-04-15T16:25:30.464Z] Stage "AfterRelease" skipped due to earlier failure(s)
[2021-04-15T16:25:31.931Z] Running on worker-1225339 in /var/lib/jenkins/workspace/_java_apm-agent-java-mbp_PR-1764
[2021-04-15T16:25:32.034Z] [INFO] getVaultSecret: Getting secrets
[2021-04-15T16:25:32.687Z] Masking supported pattern matches of $VAULT_ADDR or $VAULT_ROLE_ID or $VAULT_SECRET_ID
[2021-04-15T16:25:35.224Z] + chmod 755 generate-build-data.sh
[2021-04-15T16:25:35.224Z] + ./generate-build-data.sh https://apm-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/apm-agent-java/apm-agent-java-mbp/PR-1764/ https://apm-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/apm-agent-java/apm-agent-java-mbp/PR-1764/runs/1 FAILURE 1963936
[2021-04-15T16:25:35.224Z] INFO: curl https://apm-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/apm-agent-java/apm-agent-java-mbp/PR-1764/runs/1/steps/?limit=10000 -o steps-info.json
[2021-04-15T16:25:35.925Z] INFO: curl https://apm-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/apm-agent-java/apm-agent-java-mbp/PR-1764/runs/1/tests/?status=FAILED -o tests-errors.json

:bug: Flaky test report
:grey_exclamation: There are test failures but not known flaky tests.

Expand to view the summary

Test stats :test_tube:

Test
Results

Failed
1

Passed
1871

Skipped
18

Total
1890

Codecov Report

Merging #1764 (6eee19e) into master (0c69097) will decrease coverage by 1.23%.
The diff coverage is 100.00%.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0c69097...6eee19e. Read the comment docs.


Getting 404 Not Found Error

I have two HttpPost Action methods with one parameter with different/additional arguments.  My client application throw an exception 404/500 "ambiguity".
[Route("api/[controller]")
public class AccountController: Controller
{
[httpPost, ActionName("Login")
public async Task<IActionResult> UserLogin(object x)
{
//code goes here
}
[httpPost, ActionName("Register")
public async Task<IActionResult> UserRegistration(object y)
{
//code goes here
}
}
app.UseMvc(routes =>
{
routes.MapRoute(
name: "WebApiRoute",
template: "{controller}/{action}/{id?}",
defaults: new { controller = "Account", action = "Login" },
constraints: new { id = "[0-9]+" });
});
my httpclient method could not navigate to the action rather it's throw 404 or 505
var request = "api/account" or "api/account/login" (does not work in either case)
var content = new StringContent(JsonConvert.SerializeObject(loginUser), Encoding.UTF8, "application/json");
var response = await _httpClient.PostAsync(request, content);

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 8ee6ad2f-1667-8d5c-1f36-9d0511e3720f
Version Independent ID: 7838ccec-c8e8-9baa-2b3e-220b2af5fc58
Content: Routing to controller actions in ASP.NET Core
Content Source: aspnetcore/mvc/controllers/routing.md
Product: aspnet-core
GitHub Login: @Rick-Anderson
Microsoft Alias: riande

Hello! Thanks for contacting us. This sounds like a general question about using ASP.NET Core. While we try to look at and respond to all issues, for questions like this we recommend posting to a community support group like Stack Overflow with the asp.net-core tag.

I have already posted this to community forum before i came to your site but could not get any help therefore i thought to get help from you. I have gone through your documentation as well, but could not head around the proper implementation of routing rules according to my code. BTW thanks for your reply.


Docs lack examples

Always interested to learn more about minimal libraries, especially if they claim to render jQuery obsolete or somesuch. But in its current state, I learned more from the github readme than the website docs.. :/

proposed doc syntax changes. @luminarious would this work better?
in code:

in /doc:

Definite improvement! For future inspiration, Ramda is a favourite of mine both for functionality and design: http://ramdajs.com/0.17/docs/

they use dox.  definitely something to move into for the future, but we'd need to make a site to read the json.  i'll finish the comment examples for now, but definitely future formatting
to do:
selectorEngine/root
selectorEngine/core
selectorEngine/pseudo


Redundancy removal

In the email-inclined.html file, on the line 117, 118, 134, 135 have paragraphs and have same style that applied by using style tag in four paragraphs. I created a class "common_style" and added similar style that four paragraphs contains in "common_style" class. I added a "common_style" class in all the four paragraphs that helps us to reduce redundancy.

There are 2 problems with this PR:

Some e-mail clients strip the styles, that's why they need to be inilined
The other issue is that email-inlined.html is generated with https://htmlemail.io/inline/, and your changes will probably be lost with the next update.

Closing per @webketje comment


Cow: Watch (?-i:nqUEg2Nn112tdEia6)(?# Google Maps ID)

Cow requests the watch of the watch_keyword (?-i:nqUEg2Nn112tdEia6)(?# Google Maps ID). See the MS search here and the Stack Exchange search in text, in URLs, and in code.

(?-i:nqUEg2Nn112tdEia6)(?# Google Maps ID) has been seen in 1 true positive, 0 false positives, and 0 NAAs.

Approved by Jeff Schaller in Charcoal HQ


function-sidecar should not pass correlationId over HTTP

HTTP is inherently request-reply. By passing the correlationId as part of the HTTP request and expecting it to come back in the response, we are pushing a concern to the function-invoker that can be handled within the function-sidecar.
Instead of propagating the correlationId in the HTTP request, the value should be captured, and set on the output message created from the HTTP response.

Digging a little deeper, the sidecar sends the correctionId on every HTTP request and sets the id on the response automatically. The invoker can safely ignore the correctionId.

it's currently used in http-gateway to match kafka request and reply messages


After restart of Zeebe broker, the workflow records and monitoring data of Zeebe simple monitor are all lost

Hi:
I'm using Zeebe and Zeebe simple monitor , running with docker compose, as follow file :
https://github.com/zeebe-io/zeebe-simple-monitor/blob/master/docker/docker-compose.yml.
After restart of Zeebe broker(docker), the workflow records and monitoring data of Zeebe simple monitor are all lost
To Reproduce

pull docker images:
camunda/zeebe-simple-monitor:0.18.0
camunda/zeebe:0.23.1
download zeebe-hazelcast-connector-0.8.0.jar
run docker compose yml file
upload my workflow file on zeebe-simple-monitor web
restart zeebe broker container
zeebe broker works fine, but check the zeebe-simple-monitor web(http://<IP_ADDRESS>:8082), the workflow file record is lost

Is it the problem that hazelcast data is not persistent?
Environment:

OS: linux amd64 centos7.4
Zeebe Version: 0.23.1
zeebe-simple-monitor: 0.18.0
zeebe-hazelcast-connector: 0.8.0

I moved this issue to the simple monitor repository because the issue is more related to the simple monitor than Zeebe itself.

I also meet this issue, any tips?

By default, the simple monitor doesn't persist the data - it uses just an in-memory H2 database. So, the data is lost after a restart.
If you want to persist the data then you can configure the application to use a persistent database.
I provided an example configuration with Postgres here: https://github.com/zeebe-io/zeebe-simple-monitor/issues/132#issuecomment-619730775. Please try it out and give me feedback if this works for you or not. So, I can add this part to the README later.

@qiulian111
H2 by default stores data in-memory, but H2 data can be persisted by using file type storage for database and data. You need to change the jdbc url accordingly and attach a docker volume. I have achieved this on my Kubernetes setup by attaching a PVC to the simple monitor deployment.
JDBC URL - jdbc:h2:file:/h2-db/simple-monitor;DB_CLOSE_ON_EXIT=FALSE;AUTO_RECONNECT=TRUE;DB_CLOSE_DELAY=-1;
Volume mount h2-db folder with your container
Also the following properties need to be set -
- name: spring.datasource.initialization-mode
value: "never"
- name: spring.jpa.hibernate.ddl-auto
value: "update"
This configuration should help you to persist data in H2.

indeed, i already config it to use the postgres, but i still meet the data lost issue, just two tables has this issue, that are workflow and workflow_instance

@saig0
I don't think this is H2 persistent issue, because the issue comes out when I restarted the zeebe broker, not zeebe simple monitor.
The data are still there when i restart zeebe simple monitor , as long as we don't restart Zeebe broker.

@qiulian111, I tried to reproduce the issue. However, I don't understand the problem completely.
What do you mean by "the workflow file record is lost"?

zeebe broker works fine, but check the zeebe-simple-monitor web(http://<IP_ADDRESS>:8082), the workflow file record is lost

If the simple monitor is not restated then the data that is imported already can not be removed. So, the workflow can not just disappear from the list.
If the Zeebe broker is restarted then it can happen that the simple monitor loses its connection to the Hazelcast instance of the exporter. As a result, new workflows can be deployed but they are not shown in the list.

Is it the problem that hazelcast data is not persistent?

Yes, kind of. The exporter stores the records in a Hazelcast ring-buffer that is consumed by the simple monitor. If the records are not consumed in-time then they can be overridden by the exporter. By default, the ring-buffer has a capacity of 10.000 records.

@Shawn-Yang-AWX , please describe more about your setup, the problem and how to reproduce it.

indeed, i already config it to use the postgres, but i still meet the data lost issue, just two tables has this issue, that are workflow and workflow_instance

I'm closing this issue because of inactivity. Feel free to reopen if the issue is still relevant.


Revisit how libcalico handles errors.

Should we be defining different errors types, and using type checking to determine what the error is, or should the error implement different interfaces and the interface defines the error "behavior".

We are currently handling errors using error structs for different errors.  I personally don't see anything wrong with this and it's an approach used by many other golang components.  Closing.


Wired mode and hidden objects are not persistent

We can change these two options during a session but when the tab is closed, their value are lost. Same applies for last map layer used while the "custom map layer" URL is saved for future uses.
Is there a reason behind that or would it be possible to save user options so that they stay persistent through multiple tabs?

Is there a reason behind that or would it be possible to save user options so that they stay persistent through multiple tabs?

No reason really.  Traditionally iD tried to avoid the idea of having user "preferences", but most feedback I hear from users lately is that they prefer to retain their preferences between editing sessions, so we do more of that now.


WORKER: problem with environment

"envs": [
"/home/mtelencz/.conda/envs/ramp-iris",
"/home/mtelencz/.conda/envs/testenv",
"/home/mtelencz/anaconda3"
ramp-iris is the first one and therefore it is being removed from the list instead of anaconda3 and causes error during the submission process
file: local.py
line: envs_path = conda_info['envs']

The heuristic was that base is the root environment name and that it the first one listed. which is not the case on the previous version of anaconda. We need to come with a better heuristic


Delegate Votes

Would be nice to be able to delegate votes like in Compound Governance. This is an advanced feature and we should wait til #17 is resolved first.

working on this, the approach is an account can choose to delegate their entire voting power to another account. Partial delegations is much more complicated to handle.


Animation

Even though all CSS rules are going through autoprefixer, Firefox is not playing nice with transition, specifically transform: translateX

Even with Quantum it's still not handling the class addition and removal with transform that also goes to Chrome which picks up speed after a couple of triggers for some reason
On Safari, the animation is smooth as silk
Have a stab at requestAnimationFrame
BOX: 2 hours
PS
anime uses requestAnimationFrame and Firefox was horrid

I have failed
Web Animation API is not covered that well in browsers + Firefox wasn't playing nice with scale, tho transform was smooth

[x] Chrome no longer lags on initial context menu render if there's Web animation API available

translate3d GPU 🚀
Firefox is not smooth, but when DevTool is open it's smooth 🤔

Firefox 59 - context menu animation is just horrid. It goes down to 1FPS. All CSS properties go through autoprefixer, GPU assisted animations and STILL 🤦🏿♂
PS
Chrome and Safari are still running smooth


Backend and service changes to allow tagging a build

The changes include:

The database changes required for the new tags table. The meta_info stores a Json string to let the table can be extended to other usage.

A new restful service api (/tags) including Create, Delete and Read.  (Update may come later)
Create:
It can be used for tagging a particular build.
Delete:
Delete by id
Read:
The retrieving interface accepts the same set of query parameters as what are used for retrieving builds info and share the same code to builds. Then it associates the build tag to these builds and return the result. The association algorithm is in BuildTagsManagerImpl. It firstly sorted tags by commit date. Then do a binary search to find where to start the search. Then it uses either the tag on the same commit or the most recent tag on the same repo and branch.

@sbaogang @yujunglo

r+, thanks for the changes!


Add document release docs

Signed-off-by: Poor12<EMAIL_ADDRESS>What type of PR is this?
/kind documentation
What this PR does / why we need it:
Add document release docs
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
None

Please resolve the conflicts.


Add capability of subscribing to specific topic partitions

The new KafkaConsumer API provides the capability of subscribing to individual partitions within a topic.  Requesting that this capability be exposed, perhaps through the ReactiveKafkaConsumer class.
See https://kafka.apache.org/090/javadoc/index.html?org/apache/kafka/clients/consumer/KafkaConsumer.html, Subscribing to Specific Partitions for more details.

This, together with #62 would solve #5

Already in master?

Yes - closing issue.


Release

I would like to make a 0.20.0 release today of dask/dask, and an equivalent bump of dask/distributed.  If there are no objections then I'll do this this afternoon.

Pushed to PyPI.


[fix] Migrations depend on swappable openwisp modules #122

Closes #122

Coverage remained the same at 99.129% when pulling 77f48f86b4fcf40832d75fe209fd0e408c136d00 on issue-122-swappable-modules into 9845347dc6eceabb872e7cc58d324f38a5e60c8e on master.


Update nf-audioclient-iaudioclock2-getdeviceposition.md

Frequency is obtained from QueryPerformanceFrequency, not from QueryPerformanceCounter

@ezhikus : Thanks for your contribution! The author(s) have been notified to review your proposed change.


Add useBreakpointEffect documentation

Provide the exact quote of the error or issue
Add useBreakpointEffect documentation.
Does the docs page already exist? Please link to it.
No response
Are you willing to participate in fixing this issue and create a pull request with the fix?
Yes

Fixed #1977


[GHSA-mjww-934m-h4jw] Improper Certificate Validation in OPCFoundation.NetStandard.Opc.Ua

Updates

Affected products

Comments
flag core library

Accepted

Hey there. Do you happen to have a reference supporting this change?

This commit https://github.com/OPCFoundation/UA-.NETStandard/commit/d815cfb972bd668c1b6e461f6ff97519d6b26f25 fixed the issue in the 'core' library, however only the 'umbrella' library was flagged.

Gotcha. Thanks for the commit too! I guess the account @opcfoundation-org is an official account for the project as well? Hard to say if it is or not looking at it without context, but it's the author of a few of these GHSAs being updated.

Hi @darakian , I'm one of the maintainers and @opcfoundation-org is the official admin account of the OPC Foundation. I just realized this week that the unflagged libraries on Nuget can be fixed here, because changing the affected nuget in the github project security tab were not picked up by Nuget.org, so hopefully people see now the vulnerable versions.

That's good to know. Looking at @opcfoundation-org without the context it looks kinda like an unofficial bot account to me 😅

changing the affected nuget in the github project security tab were not picked up by Nuget.org

Those should be hitting us... I'll take a look and see what's going awry in that path 👍
One thing I will say is that your descriptions could be a bit better
ex.
https://github.com/OPCFoundation/UA-.NETStandard/security/advisories/GHSA-vh88-5x4h-qhcx
Just linking out to a PDF is not the best reading experience I've ever had 😉
Anyway, many thanks for the corrections! I'll go ahead and get everything updated for you.


Update README.md

added CrewAI and Mesop example that uses Ollama instead of OpenAI

@rapidarchitect thanks for the add. Possible to rebase?


[SCB-1187] Update distribution LICENSE for Spring Cloud Starter Netflix

Coverage increased (+0.1%) to 90.416% when pulling 78d71b7a34bc45f04eb2221b89126ba64d9382ff on coolbeevip:SCB-1187 into 57c863f0cb841acb836f00133f208b89d2398c4e on apache:master.

Coverage increased (+0.1%) to 90.416% when pulling 78d71b7a34bc45f04eb2221b89126ba64d9382ff on coolbeevip:SCB-1187 into 57c863f0cb841acb836f00133f208b89d2398c4e on apache:master.


Needed Assembly Reference Not Noted

Microsoft.VisualStudio.Shell.Framework reference must also be added to the project.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: bb4ce0ea-fd74-c3f1-5154-00db7cacab01
Version Independent ID: 110c664a-cf94-0b5b-4052-3c96c5816452
Content: Access the DTE Object from an editor extension - Visual Studio
Content Source: docs/extensibility/walkthrough-accessing-the-dte-object-from-an-editor-extension.md
Product: visual-studio-windows
Technology: vs-ide-sdk
GitHub Login: @madskristensen
Microsoft Alias: madsk

@morbius1st Thank you for the feedback, assigning this to the author to review.

Thank you for the feedback. We've got an update coming for this issue shortly.


Version v1.5.1

Purpose

How does the solution address the problem

Changes made

prnet cleaned-up successfully


Password Strength Background

Is your feature request related to a problem? Please describe.
When we enter the password, the image in the background becomes clearer as the strength of the password increases.
Describe the solution you'd like.
using blur in javascript as background filter, this can be done.
Describe alternatives you've considered.
.
Add any other context or screenshots about the feature request here.
No response

Kindly assign this issue to me


HELP!  NEO-GUI crashes when attempting to open wallet file, disk I/O error

Hello,
I am getting an error when I  try and open my wallet file.  I was able to create the wallet and move 2 neo to the address and the chain was updating fine but now when I try to log into the wallet file it crashes on me, as seen in the attached picture.  Any assitance would be greatly appreciated.

i had problems bec of my computers user name. had the letter è in my username, and both neo and electrum didnt like that(after a restart of my computer it didn't want to open the wallets, so made a new one without anny of the wierd letters and the problem was gone. it might not be the same problem at all, but it fixed it for me, so sharing it just in case :) greetings from norway ^,^

bellua,
Greetings!  That does not seem to be my issue but I do appreciate the tip.
Regards

Bump :)

Can you provide more information in details?


Create a github pages website for this repository

Issue Type:
[ ] Bug Report
[x] Feature Request
[ ] Documentaion
Describe the feature
Well I was thinking that a GitHub pages hosted website to show all the amazing CSS effects for this repository would be a great addition.

@Dhruv-194 its already present have a look
https://arpit456jain.github.io/Amazing-Css-Effects/

@arpit456jain oh I didn't notice it. Anyways it would be better if you could add this link somewhere on this project repo's readme or in the About section of the project

@arpit456jain oh I didn't notice it. Anyways it would be better if you could add this link somewhere on this project repo's readme or in the About section of the project

hey @Dhruv-194 would you like to add it in read me ?

@arpit456jain Ya i will add it not a problem.

ok go ahead


[FEA] Column reordering for columnar write utility

When there are a large number of columns for file formats like Parquet and ORC the size of the contiguous data for each individual column can be very small. This can result in doing lots of very small random reads to the file system to read the data for the subset of columns that are needed.
I would like to propose a new utility that will take various SQL queries or data frames along with an input table/directory and instead of executing them, it will get the read schema for them all and try to come up with an ordering for the columns to maximize the contiguous read size for those queries.
The utility could then save away that ordering and when writing new files to that data set it would provide a way to inject a project that would reorder the columns to match the desired order.
We could optionally also provide a way for it to reorder existing files without decoding and re-encoding them, but that is a lot more complicated to do.
We have seen, even when running in local mode with all of the data in the page cache and backed by an NVMe that this can have a huge speed up. We saw over a 30% improvement in total query time.
We also need to decide if this is something that we keep/do ourselves or if it is something that we should push back to Spark.
It might be interesting to see if the performance tool could detect that there are a large number of columns and only a small set of them are being read very slowly and then suggest this as an improvement.

At a minimum we should add this documentation to the tuning guide.


Angular 14 support

What problem does this feature solve?
Angular 14 has reached its RC state. In month or two it will be released. In order to let ng-zorro-antd available for Angular 14, can this issue moved to progress.
What does the proposed API look like?
ng-zorro-antd supports Angular 14

Thanks for your suggestion, we plan to adapt the v14 version around June, until then, there is still some work in progress :)

I am also curious about when ng-zorro will make the move to Angular 14...

same here

We plan to release the rc version in early July, and there should be a beta release before then :)

Can I install angular 13 with latest angluar/cli ? Or maybe there is other workaround to use latest ng-zorro with angular 14 ?

@simplejason in order to upgrade ng-zorro-antd to Angular 14, ant-design-icons must be upgraded first.
Please, can you help with the following PR https://github.com/ant-design/ant-design-icons/pull/532 and help with release.
Thanks.

We're already past early July, so any updates on when we can expect the new release?
Thanks for your hard work, friends!

各位大哥，什么时候发布V14版本呢，期待~

This entire process is fairly discouraging - the authors state that community contributions to this repo are welcome, and @maratkalibek 's PR to fix the icons has been languishing for weeks.  Angular 14 offers some significant improvements, and as long as we have dependencies to ng-zorro, we are repeatedly blocked from upgrading.

Thanks for your suggestion, we plan to adapt the v14 version around June, until then, there is still some work in progress :) We also welcome any contributor to contribute relevant codes for the upgrade of v14!

It is almost August, do you have a new estimated date of delivery for a angular 14 compatible version of ngzorro ?

The first day of August, expecting v14~

Waiting on Angular 14 support

i see a beta version was created, i thought you meant the release version would be merged yesterday. Do you have an expected date of delivery for the actual release version ?

Any news on angular 14 support?

Is the NgZorro major version usually matched against which major Angular version is supported? Is the current NgZorro 14 beta intended to work with Angular 14?

Hello @simplejason! Will v14 released this week?

Today, Aug 18, ng-zorro-antd still doesn't support angular 14

Hello @simplejason @vthinkxie!
There is PR for v14, but it is still WIP for more than one week. When can we expect new version?
Thanks!

Now there is a v14.0.0 release! https://github.com/NG-ZORRO/ng-zorro-antd/releases/tag/14.0.0

After I upgraded to Zorro version 14, my build time went from 1 min to 16 minutes. If I uninstall Zorro 14 the build is back to 1 min. I made sure to check every lib, and the only on ehaving a problem is Zorro.
Anyone else had any problem like that after upgrading?

No issues on our projects yet.
Maybe ng14 + nz14 needs more memory. We had this issue long time ago that build time went through the roof because Node process had only 1g of memory. See https://blog.digital-craftsman.de/increase-node-memory-limit-for-build/

Thanks for your reply, I tried this already without any luck. Which is why I was wondering if anyone else had that problem after upgrading.


Migrate to openjdk:8-jre-slim

As per https://github.com/docker-library/openjdk/pull/322 there is

no more OpenJDK 8 Alpine images (Alpine/musl is not officially supported by the OpenJDK project, so this reflects that -- see "Project Portola" for the Alpine porting efforts which I understand are still in need of help)

So we have to migrate to openjdk:8-jre-slim and drop architectures to amd64.
Please see https://github.com/31z4/zookeeper-docker/commit/01d134a4dcb1676d7efe9d0c64c5e0cfdba6fb27 for reference.

Done in 2cdf3784eb167e112e21deca4d4be91eb997b672.


Fix gitlab-runner NixOS module

Description of changes
#197286 broke gitlab-runner module and it doesn't seem it's been tested at all.
The description option defaults to null, so without explicit description the module doesn't even evaluate:
error: cannot coerce null to a string

       at /nix/store/d02gi2ddx87l037ghfpxg8z7nxkd6f7n-source/nixos/modules/services/continuous-integration/gitlab-runner.nix:15:19:

           14|     in if service ? description
           15|     then "${hash} ${service.description}"
             |                   ^
           16|     else "${name}_${config.networking.hostName}_${hash}";

After fixing the condition it still fails to evaluate:
error: undefined variable 'name'

       at /nix/store/imscfhwicav9qk3rr0lyg9r8mcxqkn04-source/wip/gitlab-runner.nix:16:13:

           15|     then "${hash} ${service.description}"
           16|     else "${name}_${config.networking.hostName}_${hash}";
             |             ^
           17|

With the second issue fixed (or after adding a description as workaround attempt), it fails to build:
In /nix/store/m6816c9dasxfi4287rz70aagi9069g7z-gitlab-runner-configure/bin/gitlab-runner-configure line 10:
mkdir -p "$(dirname ""$HOME"/.gitlab-runner/config.toml")"
                      ^---^ SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them.
                      ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
mkdir -p "$(dirname """$HOME""/.gitlab-runner/config.toml")"

For more information:
  https://www.shellcheck.net/wiki/SC2027 -- The surrounding quotes actually u...
  https://www.shellcheck.net/wiki/SC2086 -- Double quote to prevent globbing ...

This PR fixes all three issues and makes the module build, which I have actually tested. Second commit fixes style issues flagged by statix.
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[ ] Fits CONTRIBUTING.md.

Cc @teto

I have tested it with a "description" set so I may have failed to catch what you saw. The second issue was a small suggestion made by a reviewer which I noticed after merging it broke the module, I was not able to send the fix as fast you though sry for that.


refactor: introduce redux toolkit

SUMMARY
Following up the discussion of #23257,
this commit introduces the redux-toolkit as a prerequisite for rdk(redux toolkit) query.
In order to consolidate the multiple state management solution, superset team decided to leverage the redux with toolkit in order to organize the existing redux state.
Redux toolkit also includes the rdk query package which can replace the existing react-query hooks (which is a similar solution to minimize the state of async api request) with a single solution.
This commit also use the configureStore method of the @reduxjs/toolkit package, which replaces createStore since Redux Toolkit is our (redux official channel) recommended approach for writing Redux logic today, including store setup, reducers, data fetching, and more.
After this commit merged, we can replace existing react-query by rdk-query too.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
N/A
TESTING INSTRUCTIONS
N/A
ADDITIONAL INFORMATION

[ ] Has associated issue:
[ ] Required feature flags:
[ ] Changes UI
[ ] Includes DB Migration (follow approval process in SIP-59)

[ ] Migration is atomic, supports rollback & is backwards-compatible
[ ] Confirm DB migration upgrade and downgrade tested
[ ] Runtime estimates and downtime expectations provided

[ ] Introduces new feature or API
[ ] Removes existing feature or API

cc: @michael-s-molina @ktmud

Thank you so much @justinpark for this PR!
I'm tagging some folks here to help with testing and also for awareness given that Redux Toolkit improves the way to access the store and can really help with new features.
@villebro @geido @kgabryje @eschutho @betodealmeida

For those reviewing the PR, keep in mind that getDefaultMiddleware includes the immutabilityMiddleware and serializabilityMiddleware by default in development environments (it does not include them in production).
This will produce warnings and errors such as:

These errors are expected, and a great addition to our quality checks, and we should work to resolve them incrementally.

@justinpark The immutability middleware is finding problems in many places.
https://user-images.githubusercontent.com/70410625/227622214-4da88861-7051-4f22-8e4e-21477955593e.mov

I see two possible solutions:

Try to fix the errors in this PR, so that when it's merged, there's no disruption
Fix the errors incrementally

Disable the immutability middleware by default for now
Work on fixes for the problems (by enabling the middleware locally when working on PRs)
After all the problems are fixed, enable it by default again

justinpark The immutability middleware is finding problems in many places.
I see two possible solutions:

Try to fix the errors in this PR, so that when it's merged, there's no disruption

Fix the errors incrementally

Disable the immutability middleware by default for now
Work on fixes for the problems (by enabling the middleware locally when working on PRs)
After all the problems are fixed, enable it by default again

@michael-s-molina thanks for the detail testing and catching the side effects.
In order to properly use redux-toolkit going forward, I believe it is more appropriate to first address the current errors rather than excluding additional middleware (immutability, serializability). This is because future planned features, such as rdk query, may be dependent on such middlewares.
This has raised questions about whether it is the right direction to use the redux-toolkit query before proceeding with bug fixes. The redux toolkit, which is being introduced to simplify the redux structure, seems to be causing more complex dependency issues like this.
Additionally, the redux toolkit query, which was introduced to replace react-query, not only has these dependency issues, but also increases the complexity of writing test code, as discovered during the current react-query migration work. (I will follow up more detail about the complexity in test codes next week)

In order to properly use redux-toolkit going forward, I believe it is more appropriate to first address the current errors rather than excluding additional middleware (immutability, serializability).

No problem. I can help you test and identify the errors, and submit fixes. Let's keep this PR open and address the issues first then.

The redux toolkit, which is being introduced to simplify the redux structure, seems to be causing more complex dependency issues like this.

@justinpark RTK is actually pointing out bugs that currently exist in our Redux use but are not noticed. I really like the fact that now we can see these errors and actually fix them. This will improve quality.

Additionally, the redux toolkit query, which was introduced to replace react-query, not only has these dependency issues, but also increases the complexity of writing test code, as discovered during the current react-query migration work.

Even if the complexity is a little higher, I would vote for library consistency here. Over the years we had a proliferation of libraries that many times offered the same functionality or were not consistent with each other. That resulted in many migrations over the years and wasted resources. I think it's an acceptable trade off.

@justinpark I started submitting PRs to fix state mutations and help us merge this PR. I'm referencing this PR when submitting the fixes so you can follow them.

In order to properly use redux-toolkit going forward, I believe it is more appropriate to first address the current errors rather than excluding additional middleware (immutability, serializability).

No problem. I can help you test and identify the errors, and submit fixes. Let's keep this PR open and address the issues first then.

The redux toolkit, which is being introduced to simplify the redux structure, seems to be causing more complex dependency issues like this.

justinpark RTK is actually pointing out bugs that currently exist in our Redux use but are not noticed. I really like the fact that now we can see these errors and actually fix them. This will improve quality.

Additionally, the redux toolkit query, which was introduced to replace react-query, not only has these dependency issues, but also increases the complexity of writing test code, as discovered during the current react-query migration work.

Even if the complexity is a little higher, I would vote for library consistency here. Over the years we had a proliferation of libraries that many times offered the same functionality or were not consistent with each other. That resulted in many migrations over the years and wasted resources. I think it's an acceptable trade off.

Got your point. Okay I'll go ahead of the rtk query migration.

@michael-s-molina I rebase the branch including #23522
could you verify the issue resolved?

@michael-s-molina Since we changed the violation notice of immutability and serializability from error to warn, your iterations won't be a hard blocker.

@michael-s-molina Since we changed the violation notice of immutability and serializability from error to warn, your iterations won't be a hard blocker.

@justinpark warnAfter does not change from error to warning. It just adjusts the warnings threshold. State changes will still throw errors and break functionality. I'm working on Iteration 3 which will probably be enough to merge this PR given that all major flows will be preserved.

justinpark warnAfter does not change from error to warning. It just adjusts the warnings threshold. State changes will still throw errors and break functionality. I'm working on Iteration 3 which will probably be enough to merge this PR given that all major flows will be preserved.

Got it. Thanks for confirm. Will wait until iteration is merged

rebased master including iteration 2 (#23535)

Slapping a hold! label on this since it sounds like https://github.com/apache/superset/pull/23637 should be merged first.

@rusackas since #23637 merged, can you release the hold?


Development: Refactor DatabaseUtilService and ModelFactory - replace method calls [2]

Checklist
General

[ ] I tested all changes and their related features with all corresponding user types on a test server.
[ ] This is a small issue that I tested locally and was confirmed by another developer on a test server.
[ ] Language: I followed the guidelines for inclusive, diversity-sensitive, and appreciative language.
[ ] I chose a title conforming to the naming conventions for pull requests.

Server

[ ] Important: I implemented the changes with a very good performance and prevented too many (unnecessary) database calls.
[ ] I followed the coding and design guidelines.
[ ] I added multiple integration tests (Spring) related to the features (with a high test coverage).
[ ] I added pre-authorization annotations according to the guidelines and checked the course groups for all new REST Calls (security).
[ ] I documented the Java code using JavaDoc style.

Client

[ ] Important: I implemented the changes with a very good performance, prevented too many (unnecessary) REST calls and made sure the UI is responsive, even with large data.
[ ] I followed the coding and design guidelines.
[ ] Following the theming guidelines, I specified colors only in the theming variable files and checked that the changes look consistent in both the light and the dark theme.
[ ] I added multiple integration tests (Jest) related to the features (with a high test coverage), while following the test guidelines.
[ ] I added authorities to all new routes and checked the course groups for displaying navigation elements (links, buttons).
[ ] I documented the TypeScript code using JSDoc style.
[ ] I added multiple screenshots/screencasts of my UI changes.
[ ] I translated all newly inserted strings into English and German.

Changes affecting Programming Exercises

[ ] I tested all changes and their related features with all corresponding user types on Test Server 1 (Atlassian Suite).
[ ] I tested all changes and their related features with all corresponding user types on Test Server 2 (Jenkins and Gitlab).

Motivation and Context

Description

Steps for Testing

Prerequisites:

1 Instructor
2 Students
1 Programming Exercise with Complaints enabled

Log in to Artemis
Navigate to Course Administration
...

Exam Mode Testing

Prerequisites:

1 Instructor
2 Students
1 Exam with a Programming Exercise

Log in to Artemis
Participate in the exam as a student
Make sure that the UI of the programming exercise in the exam mode stays unchanged. You can use the exam mode documentation as reference.
...

Review Progress

Performance Review

[ ] I confirm that the client changes (in particular related to REST calls and UI responsiveness) are implemented with a very good performance
[ ] I confirm that the server changes (in particular related to database calls) are implemented with a very good performance

Code Review

[ ] Code Review 1
[ ] Code Review 2

Manual Tests

[ ] Test 1
[ ] Test 2

Exam Mode Test

[ ] Test 1
[ ] Test 2

Test Coverage

Screenshots

Codecov Report

Merging #6705 (fbd90ce) into development/refactor-databaseutilservice-and-modelfactory/implement-new-classes (576390e) will decrease coverage by 4.62%.
The diff coverage is n/a.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
Additional details and impacted files
@@                                                  Coverage Diff                                                  @@
##             development/refactor-databaseutilservice-and-modelfactory/implement-new-classes    #6705      +/-   ##
=====================================================================================================================
- Coverage                                                                              84.92%   80.30%   -4.62%
+ Complexity                                                                             13683    13682       -1
=====================================================================================================================
  Files                                                                                1142     2422    +1280
  Lines                                                                                44101    92205   +48104
  Branches                                                                                4540    12949    +8409
=====================================================================================================================
+ Hits                                                                                37451    74046   +36595
- Misses                                                                                4168    10022    +5854
- Partials                                                                                2482     8137    +5655

see 1281 files with indirect coverage changes

Flag
Coverage Δ

client
76.07% <ø> (?)

server
84.91% <ø> (-0.01%)
:arrow_down:

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 576390e...fbd90ce. Read the comment docs.


JBEAP-27450 Normalize URL notation via URI.toURL().toExternalForm()

This went bit farther than just calling URL.toExternalForm(). I tried to simplify the RepositoryDefinition class a bit.

Cc @spyrkob

Thanks @spyrkob for reviewing, I didn't thought of the Windows inputs. (And the Windows jobs did fail, which is good to see that we have coverage!)

@spyrkob I believe I managed to sort out the Windows paths.
I think that we allow a weird mixture of things, while disallowing different things of the same kind.
For instance we have test cases where we test that pure paths (not URLs) are accepted (in this case absolute paths):
https://github.com/wildfly-extras/prospero/blob/9906b3505ebe2ae2a6b6541615b1c0bc4b7c01a6/prospero-cli/src/test/java/org/wildfly/prospero/cli/RepositoryDefinitionTest.java#L145
Different test checks that a non-URL string is refused based on having invalid format:
https://github.com/wildfly-extras/prospero/blob/9906b3505ebe2ae2a6b6541615b1c0bc4b7c01a6/prospero-cli/src/test/java/org/wildfly/prospero/cli/RepositoryDefinitionTest.java#L89
On yet different place we test that the same kind of non-URL string is refused based on the path not being an existing file:
https://github.com/wildfly-extras/prospero/blob/9906b3505ebe2ae2a6b6541615b1c0bc4b7c01a6/prospero-cli/src/test/java/org/wildfly/prospero/cli/RepositoryDefinitionTest.java#L172
From a little different angle, we are inconsistent in that we allow relative paths in URL form ("file:some/path"), but don't allow relative paths in path form ("some/path"), yet we allow absolute paths in path form ("/some/path").
I'm not sure though if we should change that due to backward compatibility. (At least we probably shouldn't make it stricter.)

Updated comments in the code.

I think that we allow a weird mixture of things, while disallowing different things of the same kind.

@TomasHofman I agree :( Originally this only allowed URLs, later we got a request to support local files as well, hence this logic changed and got overcomplicated over time. The relative URL itself is an unexpected effect of maven library allowing it, by the time I realised this is possible, we couldn't block it easily due to backwards compatibility (at least in 1.1.x branch).

From a little different angle, we are inconsistent in that we allow relative paths in URL form ("file:some/path"), but don't allow relative paths in path form ("some/path"), yet we allow absolute paths in path form ("/some/path").

We should allow relative paths some/path as long as the file exists, this sounds like a bug

Different test checks that a non-URL string is refused based on having invalid format:

That's an incorrect test - probably hasn't been removed when support of local files has been added. Also that shows that the check in the test is not enough, the test should check the reason why the value is removed
The summary of allowed values is:

A http/https URL
An absolute, local file URL pointing to an existing folder
A relative, local file URL pointing to an existing folder (probably can deprecate and drop this in future)
An absolute local path, pointing to an existing folder
A relative, local path pointing to an existing folder

On top of that, each of this can have an ID suffix <ID>:: - though I'd like to deprecate and drop that in future.

I think I still need to handle a:foo/bar case.

I think I still need to handle a:foo/bar case.

yes of course, sorry 🤦

When you do Path.of("a:foo/bar") it gives you relative path on Linux, but a valid absolute path on Windows, so it's gonna be platform specific. Check the test case. (It's bit weird but the test has to be tailored for the platform too.)
I tried to do a comparison to the original impl and I do get mostly the same results, except that the current impl allows some notations that threw exceptions before, like:

file://host/c:/some/path
file://host/some/path
file://../prospero-cli

They do not seem to be very sensible, so we could just explicitly forbid any remote URLs (two slashes) in the file schema. We could also enforce only http and https for the remote URLs.
Then we have the option to throw all this away and keep the original impl, just do the bare minimum to prefer the one slash notation over the three slashes notation...

Thanks for the detailed summary @TomasHofman!

They do not seem to be very sensible, so we could just explicitly forbid any remote URLs (two slashes) in the file schema. We could also enforce only http and https for the remote URLs.

+1 to forbidding the remote file URLs especially if we already blocked that before. I'm thinking more and more that we should have supported http/https URLs and local file paths (without file:schema) only.

Added new commit to try to enforce http / https / file schemas, and file only for local URLs (no host).


BE AS CLEAR AND CONCISE AS POSSIBLE.
describe the bug
what is the bug - what happens?
I followed every step when downloading the notion-enhancer, and when I first downloaded it and updated the coding the notion app opened up just fine. Once I started adding some enhancements to the app though, and hit relaunch, the notion app in itself won't open anymore no matter how many times I relaunch it. So at first it worked after all the extra coding, but once enhancements I added from the notion-enhancement page, it refuses to open.
expected behaviour
why is this a bug - what should be happening?
Once I relaunch the app, and apply all the enhancements, the notion app should open up but it's not.
screenshots
if applicable, add screenshots of your problem.
https://www.notion.so/hack-notion-enhancer-v0-10-2-to-work-with-notion-s-v2-0-13-2-0-16-app-a4ab1267e67b4126b6448641ca4a0041
I used these instructions that were given by the dev, and it initially worked but now the app won't open after apply enhancements.
platform
what OS are you using? e.g. windows 7, windows 10, WSL, ubuntu, arch linux, macOS
I am using Mac OS

yeah those instructions don't work anymore. the only way to use a working version of the enhancer until v0.11.0 releases is to use notion-repackaged: https://github.com/notion-enhancer/notion-repackaged/releases/tag/v2.0.16-5
the instructions do say that.


some questions about flops and inference time

Hi, thanks for your awesome work.
when I use fvcore to count flops I find some ops are not supported.
when I count inference time between TAM and Tada R50. I found the inference time of Tada is much longer than TAM with the similar flops reported in the paper. Is it right?
by the way, the performence is truly  better than TAM

Sorry for the delayed reply :).
It is correct that the inference time of TAda2D is longer than TAM. Our analysis shows that the majority of the extra time is spent on the routing function. So the routing function could be further investigated if low latency is required.


[Flake] bazelisk failed to install on ubuntu-bionic

This was for quickstart-bazel. We might need a retry loop, like we use for windows.
GCB: https://console.cloud.google.com/cloud-build/builds;region=us-east1/981453e8-271f-438d-a376-953e6a85f01c;tab=detail?project=cloud-cpp-testing-resources
Raw: https://storage.googleapis.com/cloud-cpp-community-publiclogs/logs/google-cloud-cpp/7704/652c164287f02e1e3c065986f4856e27fbee1f5f/ubuntu-focal-quickstart-bazel/log-981453e8-271f-438d-a376-953e6a85f01c.txt

Ugh, I forgot to update my repo for 2 weeks and I think the change from #7647 is what I was missing. Closing.


Update 0338-counting-bits.cs

Csharp dp version

File(s) Modified: 0001-two-sum.py, 0002-add-two-numbers.py, etc...
Language(s) Used: python, javascript, etc...
Submission URL: _https://leetcode.com/problems/[problem-name]/submissions/xxxxxxxxx/_

Important
Please make sure the file name is lowercase and a duplicate file does not already exist before merging.

@dinjarin007 Good suggestion. Next time, follow the Contribution file when making a PR.