improve fcs error reporting in FSharp.Literate.

We cannot see the "real" error, because FSharp.Formatting is swallowing it...
For the FsLab issue:
The root cause seems to be in https://github.com/tpetricek/FSharp.Formatting/blob/master/src/FSharp.Literate/Evaluator.fs#L130 which pretty much expects all libraries to be available near FSharp.Literate.dll. As it is searching for compile-time assemblies, I'm now wondering why it is actually working on windows. I think we will know more when we have the exact error message...
While I'm looking for the exact error this can already run through the CI build in the mean time...

Ok thats the message after this patch:
Error:
System.Exception: FSI failed:
        Error:

/home/matthid/projects/FsLab.Templates/input.fsx(1,1): error FS0078: Unable to find the file 'FSharpVSPowerTools.Core.dll' in any of
 /usr/lib64/mono/4.5
 /home/matthid/projects/FsLab.Templates/packages/FSharp.Formatting/lib/net40
 /home/matthid/projects/FsLab.Templates
 /home/matthid/projects/FsLab.Templates/packages/FAKE/tools/

        Out:  ---> System.Exception: Evaluation failed ---> Microsoft.FSharp.Compiler.Build+FileNameNotResolved: Exception of type 'Microsoft.FSharp.Compiler.Build+FileNameNotResolved' was thrown.
  at Microsoft.FSharp.Compiler.Build+TcConfig.ResolveLibWithDirectories (Microsoft.FSharp.Compiler.CcuLoadFailureAction ccuLoadFaulureAction, Microsoft.FSharp.Compiler.AssemblyReference r) [0x00000] in <filename unknown>:0
  at Microsoft.FSharp.Compiler.Build+TcImports.TryResolveAssemblyReference (Microsoft.FSharp.Compiler.AssemblyReference assemblyReference, Microsoft.FSharp.Compiler.ResolveAssemblyReferenceMode mode) [0x00000] in <filename unknown>:0
  at Microsoft.FSharp.Compiler.Build.tryFile@4408 (Microsoft.FSharp.Compiler.TcImports tcImports, range m, System.String speculativeFileName) [0x00000] in <filename unknown>:0
  at Microsoft.FSharp.Compiler.Build+TcImports.ImplicitLoadIfAllowed (range m, System.String assemblyName, Boolean lookupOnly) [0x00000] in <filename unknown>:0
  at Microsoft.FSharp.Compiler.Build+TcImports.FindCcuInfo (range m, System.String assemblyName, Boolean lookupOnly) [0x00000] in <filename unknown>:0
...

It's not like super nice but definitely better than before. But still: I have no idea why it is working on windows :(.

But yes after looking at this, bundling as proposed in #303 would help here as well...

@tpetricek : I'm giving up on the FsLab/FCS issue, I guess there is code somewhere in FCS to consider currently loaded assemblies when resolving (compile) assemblies, but I couldn't find it. Maybe this is even just another FCS issue?
We can work around this particular issue within FSharp.Formatting quite easily by just adding additional "#I" and "#r" statements not only for the currently executing, but for all assemblies we need.
Or we consider this as by design (IE tell users of FSharp.Formatting that we expect our dependencies to live in the same folder as "FSharp.Formatting.dll").

Ah! Thanks a lot for looking into this, I think I now understand what's going on (looks like I did break something with a recent change :-( ...)
I basically added the broken piece of code to avoid dependency on FSharp.Compiler.Interactive.Settings.dll which was major source of pain... So, I changed the code to initialize dummy fsi object, but that introduced this new issue.
I think the safest option is just to eval some ugly inlined string with the definition of fsi object at the beginning.
BTW: I used this to get better error info: http://fssnip.net/qF

Well, this was definitely my mistake - after fixing this (I'll send a PR), we won't need to have all the libraries in the same folder, so perhaps that also reduces the urgency of #303 - but I think the discussion there is still valid and it is probably a good direction (but we can perhaps wait a bit more to see if other people have any thoughts on that...)

to avoid dependency on FSharp.Compiler.Interactive.Settings.dll

This is really a PIA, that's one of the reason why I have extracted the scripting use case in https://github.com/matthid/Yaaf.FSharp.Scripting for a scripting API with all those little bugfixes like nice error messages (this PR) or fixing the FSharp.Compiler.Interactive.Settings.dll thing.
Currently we have those fixes spread out in several locations:

https://github.com/tpetricek/FSharp.Formatting/blob/master/src/FSharp.Literate/Evaluator.fs#L127
https://github.com/fsharp/FAKE/blob/master/src/app/FakeLib/FSIHelper.fs#L122

To show two examples :)

we won't need to have all the libraries in the same folder

Ah, so we don't actually need to load ourself into the interactive we are hosting? That should definitely fix this as well :)
However I still feel like we should add this (or something similar), because it will give people using FSharp.Literate exactly the error message they would get when running in FSI.exe (and it will simplify our lives at well when people report errors or when we encounter them)

BTW: I used this to get better error info: http://fssnip.net/qF

Oo never noticed this, thanks!

but we can perhaps wait a bit more to see if other people have any thoughts on that...

Yes to get feedback was exactly the intention of #303 ...

Yaaf.FSharp.Scripting looks very nice! I would probably prefer to avoid another DLL dependency, but if we could import something like that as a few source files via Paket, that might be nice (and I suspect FAKE could do the same).
The way I understand the F# Compiler Interactive Service thing is that:

FsiEvaluationSession.GetDefaultConfiguration(new InteractiveSettings(), false) where InteractiveSettings is your type - this gives you fsi object, but it requires FSharp.Compiler.Interactive.Settings.dll.

FsiEvaluationSession.GetDefaultConfiguration() this does not give you fsi object and does not require F.C.I.S.dll (FAKE does this and as a result you cannot just #load "FsLab.fsx" in a FAKE script, because FsLab calls fsi.AddPrinter...). I did a workaround (part 1 & part 2) for this.

FsiEvaluationSession.GetDefaultConfiguration() and then EvalInteraction("let fsi = ...") like what we are doing here is a way to get fsi object without requiring F.C.I.S.dll. (But we need to do it without having to reference ourselves - I thought that was clever, but it breaks things. Basically, having the implementation in a big string is probably OK.)

Having all the tweaks in some file that we could reference via Paket would be nice (and we could send PR to FAKE to use it too.) It would be nice to add (3) to FAKE too - I could then get rid of my dirty workarounds for (2)...

Very nice idea! I will try to refactor the features in easy to include source files!

FsiEvaluationSession.GetDefaultConfiguration(new InteractiveSettings(), false) where InteractiveSettings is your type - this gives you fsi object, but it requires FSharp.Compiler.Interactive.Settings.dll.

Actually I experienced the reverse when working these things out in the past: https://github.com/fsharp/FSharp.Compiler.Service/blob/89d936ca760b790f7741a0bab9122002a792810c/src/fsharp/fsi/fsi.fs#L2705 The useauxlib parameter means adding a reference to F.C.I.S.dll. It's definitely hard, confusing and impossible to get it perfectly right, I learned that the hard way :)

But we need to do it without having to reference ourselves - I thought that was clever, but it breaks things.

The funny thing is we could do this in Yaaf.FSharp.Scripting.dll but only when it's a separate dll without and additional references :). Not when it's included via source files.

FsiEvaluationSession.GetDefaultConfiguration()

https://github.com/fsharp/FSharp.Compiler.Service/blob/master/src/fsharp/fsi/fsi.fs#L2855 it literally uses (obj, false)
But FAKE uses FsiEvaluationSession.Create( directly: https://github.com/fsharp/FAKE/blob/master/src/app/FakeLib/FSIHelper.fs#L122
Bah I hope at least of that is correct :) . I'll report back once I have refactored the files.

Uh, I think some of my "magic" is not working when using as script file :(

FsiEvaluationSession.GetDefaultConfiguration(new InteractiveSettings(), false)

Did you mean true here? Then everything makes sense now...
So you are saying that we cannot make the fsi object work properly with false (ie no F.S.I.S.dll reference) but we can hook in our own implementation to not fail immediately (even when scripts now produce potentially different output)?
Ok done, I re-used this PR (the title is still true).
This is my magic string by the way: https://github.com/matthid/Yaaf.FSharp.Scripting/blob/develop/src/source/Yaaf.FSharp.Scripting/YaafFSharpScripting.fs#L316.
But now after re-reading your post it probably doesn't really matter what implementation we use (any dummy implementation would probably do the same)...

Added another simplification.

OK finally everything seems to work as it should. A lot of commits but actually only a very few amount of changes to review (details in the edited start comment).

I wanted to be sure that relative paths are still handled correctly, so I added a test for that and... everything worked perfectly :-)
In fact, I think it is actually even redirecting the work to the fsi object (which is doing a few unexpected things in FsLab - like showing charts - but that's okay - this is the right thing to do :-))

Thanks for the testing and the release!

everything worked perfectly :-)

That was exactly the intention: Make F# scripting work as easily as possible without the need to care about all this FCS nuances/bugs/argument stuff.
But something (which looks related to this change) is broken now :( , looking into it...

wanted to be sure that relative paths are still handled correctly,

After noticing this I'm also wondering why FsiEvaluator is not used by default? I have planned to enable it for all my projects (now, after this has been merged & released). At least we could enable it in ProjectScaffold so you can use those "enable script output" features out-of-the-box?

In fact, I think it is actually even redirecting the work to the fsi object (which is doing a few unexpected things in FsLab - like showing charts - but that's okay - this is the right thing to do :-))

Thanks for this, I did some testing myself but I wasn't sure if everything works as it should when some advanced stuff is done with it :)
Everything is done with reflection so it may be a bit slow, but I don't think anyone is calling the fsi object like crazy anyway (only for initial setup).
Btw FAKE does now also contain this, so you may be able to remove some workarounds you mentioned above (please report if something breaks)

I think we could enable it for ProjectScaffold - can you send a PR there? We initially thought it was a bit experimental and perhaps we don't want to run things on people's machine when building docs :-) but I think it is mature and people expect this now...

Yeah, but first I'll need figure out why something broke with the update...


add merge cell selection to apply legend changes to all cells (including already existing)

Thanks a lot for this plugin, very useful !
Selection.append no longer merges entering nodes into the update selection.  Without merging the entering nodes with the existing ones,  a change in the legend config (e.g. setting a different orientation) will have no effect if we call the legend again (against the same main group selection).
This PR. makes sure selections are merged and hence config changes are properly applied.

P.S.
Also included a way to pass label format as strings
legend.labelFormat('0.1%')

Thanks for putting this together!


Fix/windows run scripts

Hello !
I made some changes in the package.json to call the script commands because I couldn't get them to work with Git bash for Windows.
You can see these errors in the screenshots below.
Impossible to run each of the scripts due to files being called with the "./" prefix :

I also made some changes to the create-distribution.js file, which I couldn't get to work either.
As you can see, the variable currentFilePath = path.dirname returned the wrong value with two iterations of my "C:" folder :

Also, once I'd corrected the path, I kept getting the same ENOENT error because the "/dist" folder didn't exist :

Then, as another command was called by the "./node_modules" prefix, I was unable to launch the script as I had done with the package.json scripts :

And here's the screenshot after the modifications :

Thank you for your work !

Hey,
Thanks for looking into this. I'll take a look at the PR in more detail in a few hours. At a glance it looks promising :)

All merged in, thanks for your help.


Add optional bounces property on ScrollView

Motivation
It's a natural to have bounces animation in iOS/Android scroll view.
This PR adds an optional property of bounces. By default, it's false.

Test plan

yarn run lint
yarn run flow
yarn run test

Any way to get this moving again ?

Hey, I just released a new alpha 2.0.0-alpha.0 of the library. It's rewritten using react-native-gesture-handler and react-native-reanimated addresses a many platform specific bugs and performance problems. It's gone through a major refactor and there will be conflicts with your PR.
Please try the new version and see if it addresses your issue. If not, please open a new PR with the change.


Unable to run any plugins, Run action disabled

I have just installed the plugin, as the idea seams really promissing to me. The idea.log confirms the plugin is loaded:

2017-12-11 14:08:22,099 [   2640]   INFO - llij.ide.plugins.PluginManager - Loaded custom plugins: .... LivePlugin (0.6.0 beta), ...

The plugin menu can be seen, but both the Run menu action and the Run icon are disabled (gray).

My IntelliJ version information is:

IntelliJ IDEA 2017.3.1 (Ultimate Edition)
Build #IU-173.3942.15, built on December 6, 2017
JRE: 1.8.0_152-release-1024-b8 amd64
JVM: OpenJDK 64-Bit Server VM by JetBrains s.r.o
Windows 10 10.0

Thanks a lot reporting this.
I think it might be an issue with windows vs unix paths. Will try to fix it later today.

Thanks for quick response.
Some more messages from the log, probably not relevant:

2017-12-11 14:08:27,514 [   8055]   INFO -                     LivePlugin - Enabled junit panel output for integration tests
2017-12-11 14:08:32,435 [  12976]   WARN - openapi.wm.impl.ToolWindowImpl - ToolWindow icons should be 13x13. Please fix ToolWindow (ID:  Plugins) or icon jar:file:/D:/Users/Ondra/.IntelliJIdea2017.3/config/plugins/LivePlugin/lib/LivePlugin.jar!/liveplugin/plugin-toolwindow-icon.png

Run actions should be enabled in version 0.6.1.
(The toolwindow icon is not related but should also be fixed now.)

I confirm it is working fine now. Many thanks for the quick fix.


ci: enable mypy

We have typechecker enabled in CI, but mypy was not installed.
Added mypy and available type info for PyMySQL and requests.
Modified a few constanst to satisfy type requirements.

I guess this should be rebased to fix linter


Add requestType to buildURL.

This allows for other types of find queries to be handled correctly,
e.g. store.find('person', {name: 'Ben'});.
Added an acceptance test for this, but it turns out that 2 pagination tests were failing because of changes to the handling of find queries. This patch fixes those, too, so all tests are now passing in canary.
Ember-data now uses a new buildURL signature
Sorry for the delay on this!

Hi @TigerDX thanks you for the new PR.
So this is working against current v1.0.0-beta.16.1 requirement? or shall we now require beta.17?
No problem in doing so, just want to clear that up (we actually prefer staying close to latest beta so we can release right away when ED hits 1.0)

@holandes22 This change does not break v1.0.0-beta.16.1 compatibility, and now passes when using ember try ember-data-canary, so the choice is yours!
I'm currently bumping an existing app up to the latest ember-data, and the adapter seems to be working so far with this patch.


Bioconda

Any chance you’d add this to bioconda? I use it in a few pipelines and it would help with installs if I could use bioconda.
Thanks for considering!
Mitchell

It's coming https://github.com/bioconda/bioconda-recipes/pull/52800!

Thanks so much!


Add tests for scripts enabling VS Code extension GitHub action tests

This is about scripts in .github/scripts folder.

Closing.


Possible memory leak in OpenGL backend

Last week we have upgraded from silx 0.10.0 to silx 0.12.0.
Since then our application crashes after plotting for a while.
In our scenario there is a time-series plotted at approximately 1Hz. Each second, an extra sample is added to the time series.
The crash happens after some 45 minutes.
So the length of the final time-series being plot is ~2700 samples.
Since the time series is growing by 1 sample everyting, the total number of sampled that were plotted is approximately: 3643650 (3643650=sum(np.arange(2700))
This is the stack trace provided:
2020-03-12 17:44:33,966                   misc.py:88   : ERROR  : pid=31125: Bug: uncaught RuntimeError:
Traceback (most recent call last):
  File "/usr/local/lib/python3.5/dist-packages/silx/gui/_glutils/OpenGLWidget.py", line 239, in paintGL
    parent.paintGL()
  File "/usr/local/lib/python3.5/dist-packages/silx/gui/plot/backends/BackendOpenGL.py", line 419, in paintGL
    self._paintFBOGL()
  File "/usr/local/lib/python3.5/dist-packages/silx/gui/plot/backends/BackendOpenGL.py", line 369, in _paintFBOGL
    self._renderPlotAreaGL()
  File "/usr/local/lib/python3.5/dist-packages/silx/gui/plot/backends/BackendOpenGL.py", line 676, in _renderPlotAreaGL
    self._renderItems(overlay=False)
  File "/usr/local/lib/python3.5/dist-packages/silx/gui/plot/backends/BackendOpenGL.py", line 459, in _renderItems
    isXLog, isYLog)
  File "/usr/local/lib/python3.5/dist-packages/silx/gui/plot/backends/glutils/GLPlotCurve.py", line 1237, in render
    self.lines.render(matrix)
  File "/usr/local/lib/python3.5/dist-packages/silx/gui/plot/backends/glutils/GLPlotCurve.py", line 419, in render
    program.use()
  File "/usr/local/lib/python3.5/dist-packages/silx/gui/_glutils/Program.py", line 158, in use
    self._attrib0)
  File "/usr/local/lib/python3.5/dist-packages/silx/gui/_glutils/Program.py", line 91, in _compileGL
    raise RuntimeError(gl.glGetProgramInfoLog(program))
RuntimeError
libpng warning: Out of memory
libpng error: insufficient memory
QImage: out of memory, returning null image
QImage: out of memory, returning null image
terminate called after throwing an instance of 'std::bad_alloc'
  what():  std::bad_alloc

Do you have any idea what could be causing this?

Sounds weird.
There has been a few changes in the PlotWidget but there has been not much changes in the way the OpenGL backend works.
The error from libpng and QImage sounds funny. Did you try to grab the widget content?
I'm looking at what can go wrong in silx.

@UUSim Was silx the only change? I mean, no change of Qt binding or version?

I was about to ask the same question.
Looking at it, some refactoring of the PlotWidget also affected the OpenGL backend.

That might be related to PR #2539.

From a quick test, _compileGL in silx.gui._glutils.Program.py is called way to often.

We have not changed Qt binding and or version.
We are using Debian Stretch, and use debian packages for all our dependencies. Only silx is installed via pip.
These are our versions:
Qt: 5.7.1
PyQt: 5.7
Python: 3.5.3

Early patch that avoid calling _compileGL all the time and seems to avoid memory leak:
silx/gui/_glutils/OpenGLWidget.py
@@ -270,6 +270,8 @@ class OpenGLWidget(qt.QWidget):
         layout.setContentsMargins(0, 0, 0, 0)
         self.setLayout(layout)

+        self.__context = None
+
         _check = isOpenGLAvailable(version=version, runtimeCheck=False)
         if _OpenGLWidget is None or not _check:
             _logger.error('OpenGL-based widget disabled: %s', _check.error)
@@ -357,7 +359,9 @@ class OpenGLWidget(qt.QWidget):
         if self.__openGLWidget is None:
             return None
         else:
-            return self.__openGLWidget.context()
+            if self.__context is None or not self.__context.isValid():
+                self.__context = self.__openGLWidget.context()
+            return self.__context

The wrapping object around the context returned by PyQt5 is a new one each time... and it is used in silx as a key in WeakKeyDictionary to manage resources... pretty bad.
I'm checking a bit more, but that's probably the root of the issue.

Yes, it looks like that's it.
PySide2 behaves differently, asking the context always returns the same python object (which is nice).
And I guess I did that at the time I was developing with PySide2 as default.

Can you just check that your changes still allow to dock and undock plots using OpenGL, without releasing resources (an image for example). Maybe it was related somehow, i don't remember.

This change doesn't change the behavior regarding dock widgets (though it does not behave nicely by default at least on my PC: missing redraw + issue when dock is not within the main window).

This is terrific!
We will still have to wait for a new pip release where this merge is included, and then we can upgrade to 0.13.0 (for now we have rolled back to 0.10.0).
Thanks for your support, and keep up the good work.

@UUSim Just in case, we produce unofficial Debian 9 packages on our nightly builds:
http://www.silx.org/pub/debian/

There is also a richer repo with weekly builds for Debian 9, 10 and Ubuntu 20.04: http://www.silx.org/pub/linux-repo/ that we set up recently.

And wheels from the weekly builds: https://silx.gitlab-pages.esrf.fr/bob/silx/


Difference in PSQL containers between new project & eShopLite when deployed

On eShopLite app sample, when running aspire generate, on the aspire-output for the catalogDb project it generates two files:

kustomization.yml
postgres-server-yml

However, in my test solution, it generates different things:

deployment.yml
kustomization.yml
service.yml

All this because when deploying my solution I get a ServiceSocketException: Name or service not known error while starting the DbManager project. On the eShopLite project, when starting the services on k8s it apears that they start on a specific order (maybe because of the database) while on my solution they all start at the same time.
Here's the files for both the scenarios. Check the difference between the catalog on both manifests. The only difference on my setups is the aspire version because in eShopLite I can't call AddNodeApp or AddNpmApp
eShopLite->manifest.json:
{
  "resources": {
    "catalog": {
      "type": "postgres.server.v0"
    },
    "catalogdb": {
      "type": "postgres.database.v0",
      "parent": "catalog"
    },
    "basketcache": {
      "type": "redis.v0"
    },
    "catalogservice": {
      "type": "project.v0",
      "path": "..\\eShopLite.CatalogService\\eShopLite.CatalogService.csproj",
      "env": {
        "OTEL_DOTNET_EXPERIMENTAL_OTLP_EMIT_EXCEPTION_LOG_ATTRIBUTES": "true",
        "OTEL_DOTNET_EXPERIMENTAL_OTLP_EMIT_EVENT_LOG_ATTRIBUTES": "true",
        "ConnectionStrings__catalogdb": "{catalogdb.connectionString}"
      },
      "bindings": {
        "http": {
          "scheme": "http",
          "protocol": "tcp",
          "transport": "http"
        },
        "https": {
          "scheme": "https",
          "protocol": "tcp",
          "transport": "http"
        }
      }
    },
    "basketservice": {
      "type": "project.v0",
      "path": "..\\eShopLite.BasketService\\eShopLite.BasketService.csproj",
      "env": {
        "OTEL_DOTNET_EXPERIMENTAL_OTLP_EMIT_EXCEPTION_LOG_ATTRIBUTES": "true",
        "OTEL_DOTNET_EXPERIMENTAL_OTLP_EMIT_EVENT_LOG_ATTRIBUTES": "true",
        "ConnectionStrings__basketcache": "{basketcache.connectionString}"
      },
      "bindings": {
        "http": {
          "scheme": "http",
          "protocol": "tcp",
          "transport": "http2"
        },
        "https": {
          "scheme": "https",
          "protocol": "tcp",
          "transport": "http2"
        }
      }
    },
    "frontend": {
      "type": "project.v0",
      "path": "..\\eShopLite.Frontend\\eShopLite.Frontend.csproj",
      "env": {
        "OTEL_DOTNET_EXPERIMENTAL_OTLP_EMIT_EXCEPTION_LOG_ATTRIBUTES": "true",
        "OTEL_DOTNET_EXPERIMENTAL_OTLP_EMIT_EVENT_LOG_ATTRIBUTES": "true",
        "services__basketservice__0": "{basketservice.bindings.http.url}",
        "services__basketservice__1": "{basketservice.bindings.https.url}",
        "services__catalogservice__0": "{catalogservice.bindings.http.url}",
        "services__catalogservice__1": "{catalogservice.bindings.https.url}"
      },
      "bindings": {
        "http": {
          "scheme": "http",
          "protocol": "tcp",
          "transport": "http"
        },
        "https": {
          "scheme": "https",
          "protocol": "tcp",
          "transport": "http"
        }
      }
    },
    "catalogdbmanager": {
      "type": "project.v0",
      "path": "..\\eShopLite.CatalogDbManager\\eShopLite.CatalogDbManager.csproj",
      "env": {
        "OTEL_DOTNET_EXPERIMENTAL_OTLP_EMIT_EXCEPTION_LOG_ATTRIBUTES": "true",
        "OTEL_DOTNET_EXPERIMENTAL_OTLP_EMIT_EVENT_LOG_ATTRIBUTES": "true",
        "ConnectionStrings__catalogdb": "{catalogdb.connectionString}"
      },
      "bindings": {
        "http": {
          "scheme": "http",
          "protocol": "tcp",
          "transport": "http"
        },
        "https": {
          "scheme": "https",
          "protocol": "tcp",
          "transport": "http"
        }
      }
    }
  }
}

My Solution -> manifest.json:
{
  "resources": {
    "catalog": {
      "type": "container.v0",
      "image": "postgres:latest",
      "env": {
        "POSTGRES_HOST_AUTH_METHOD": "scram-sha-256",
        "POSTGRES_INITDB_ARGS": "--auth-host=scram-sha-256 --auth-local=scram-sha-256",
        "POSTGRES_PASSWORD": "{catalog.inputs.password}"
      },
      "bindings": {
        "tcp": {
          "scheme": "tcp",
          "protocol": "tcp",
          "transport": "tcp",
          "containerPort": 5432
        }
      },
      "connectionString": "Host={catalog.bindings.tcp.host};Port={catalog.bindings.tcp.port};Username=postgres;Password={catalog.inputs.password};",
      "inputs": {
        "password": {
          "type": "string",
          "secret": true,
          "default": {
            "generate": {
              "minLength": 10
            }
          }
        }
      }
    },
    "catalogdb": {
      "type": "postgres.database.v0",
      "parent": "catalog"
    }
  }
}

Aye there is a reason for the difference in generated files
 "catalog": {
      "type": "postgres.server.v0"
    },

This is the non abstract postgres server type - that has a dedicated template
Where as you are using the AddPostrgesContainer version it seems, which produces a container.v0 aspire component not a postgres.server.v0 component
 "catalog": {
      "type": "container.v0",
      "image": "postgres:latest",
      "env": {
        "POSTGRES_HOST_AUTH_METHOD": "scram-sha-256",
        "POSTGRES_INITDB_ARGS": "--auth-host=scram-sha-256 --auth-local=scram-sha-256",
        "POSTGRES_PASSWORD": "{catalog.inputs.password}"
      },
      "bindings": {
        "tcp": {
          "scheme": "tcp",
          "protocol": "tcp",
          "transport": "tcp",
          "containerPort": 5432
        }
      },
      "connectionString": "Host={catalog.bindings.tcp.host};Port={catalog.bindings.tcp.port};Username=postgres;Password={catalog.inputs.password};",
      "inputs": {
        "password": {
          "type": "string",
          "secret": true,
          "default": {
            "generate": {
              "minLength": 10
            }
          }
        }
      }
    },

The two aspire methods are for different things and are treated differently because of this via aspirate, as the do different things in aspire preview 2.
The non container variant, uses a postgres template to deploy a server
The container variant includes inputs for generating secrets, as well as a connectionString property

Can you share your program.cs to confirm?
You should find two extension methods for adding postgres - if you want to have the same as the eShopLite, then you need to use the other postgres method

Found it.
Connection strings for containers were being processed incorrectly
Added a preview two manifest and as well as tests for it to the tests project
fixed in version 0.1.23-preview going out in a few.

Solved it but a new issue is happening: https://github.com/prom3theu5/aspirational-manifests/issues/92!


replace JS and CSS aliases in custom html doesn't work

The replace method returns the modified string and not modifies it internally. Should be html = html.replace(CSS_REPLACE, args.css.alias)

Thanks @borisirota. Fixed in 7.2.1


research Web Test Runner

Justin recommended Web Test Runner very highly.  We should investigate and see how much effort it would be to incorporate.

@zhawkins Is working through this now as part of the AT epic 🎉

Closing this in favor of: https://github.com/patternfly/patternfly-elements/issues/1425


Multisig. Multisig discovery when onboarding - broke the app state

Description
https://github.com/user-attachments/assets/e311bbd8-c561-4f99-b5ef-78e095ba703b
Steps to Reproduce

Delete all data
Restart the app
Add wallet with multisig

Expected Behavior
All multisigs were added, user has no problem
Actual Behavior
Broken app state

Environment
https://github.com/novasamatech/nova-spektr/commit/9761c24c9fc3b3e4612dc41a53c44680cff488c5

Status verification: ✅


Troubleshoot now.sh deployment

Last week, it was possible to deploy into the /web folder and then deploy the frontend onto now.sh.

cd web
now --public --npm

This week, it's stopped working.
now.sh is using npm to install dependencies, build the application, and then run the application. I think that's where we should start.

From /web directory, try the following:

npm install
npm build
npm start

If that works, then move to 2.
If that doesn't work, checkout a pull request from a week ago or so until you find when it did work.

If that works, then let's see if we can deploy to now.

now --public --npm

Once those both work, then we can close this issue.

Installing + running with npm is working, but deploying to now is not.

It looks like it's to do with where our lingui message files are saved.

This is now fixed. We can deploy to now.sh again (but we won't be able to send emails, tant pis).


Converging lines meeting at the same point

Is there a way to making multiple lines meeting at the same point to converge
This is what it looks like at the moment:

This is what I am hoping to achieve:

Hi @loperxo, thank you for the comment.
You have to add an element for the point.
For example: https://jsfiddle.net/7k49uLse/

No reply came, then this abandoned issue is closed.


[Outlook] (manifest) update 2 overviews for JSON manifest awareness

This is a very minimalist update of two articles to make them compatible with the fact that there is now a JSON-formatted manifest (in preview).
More extensive updates of one or both of these should be done too with the aim of not duplicating manifest documentation between the Outlook docs and the overall Office Add-in docs.

Learn Build status updates of commit c19ac0c:
:warning: Validation status: warnings

File
Status
Preview URL
Details

docs/outlook/manifests.md
:warning:Warning
View
Details

docs/outlook/testing-and-tips.md
:white_check_mark:Succeeded
View

docs/outlook/manifests.md

Line 12, Column 105: [Warning: file-not-found - See documentation] Invalid file link: 'json-manifest-overview.md'.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Learn Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel

Learn Build status updates of commit 3f5a76e:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/outlook/manifests.md
:white_check_mark:Succeeded
View

docs/outlook/testing-and-tips.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel


[UI] Rework Project Grid View Pages.  I will update/replace the project grid.  Incorporate the side banner tools.

Fix UI Layout for all Project Views.  Use the mock-up example that I provided earlier.
The page title should be aligned at the top left of the Grid Views.
Drop the drop shadow and underlined text.
Drop the white background.
Make sure that the grid view fits within the space provided below the User Name Banner.
Comment:
The User Name Banner takes up a lot of page real estate and really does not serve a purpose for all pages except for the Dashboard.  Can we use that area for the Page View Titles Instead?  It may work better.  Thoughts suggestions??

Name banner obliviously a bug, as projects views will look like the mock up you approved

Grid view has been updated.  We still need to address the name banner bug.

Completed


⚠ Bofrost.be has degraded performance

In d70d771, Bofrost.be (https://www.bofrost.be) experienced degraded performance:

HTTP code: 200
Response time: 1132 ms

Resolved: Bofrost.be performance has improved in 699a569.


Feature #115/probability tech data charging power

Closes #115

Didn't we also want to seperate AC and DC charging? Or did you do this by assigning slow chagring to AC (3.7,11,22 kW) and fast charging to DC (50,150,350)? Because 50kW is normally not fast charging.

Further test in debugger mode showed, that distribution of technical_parameters works like expected. Also Code went through 4 bigger simulations (1.5 Mio Vehicle) without problems.


Tab out of select field

This is a bug with #92.
Steps

Click to open field - so it shows the input field for searching.
Press TAB
ui-select is still active field.

Problem
Step 3 should be that the next tabbable input should be focussed.
Fix
I think the fix for this is to do with the tabindex attribute. Currently we have 2 inputs, the tabindex="-1" input used for searching (search input) and the other one we use for detecting tab order (tab input) has class .ui-select-offscreen.
The solution I think is as follows:

Click to open field - Triggers a focus for the 'search input' field.
The 'search input' field has it's tabindex attribute set to that of the 'tab input'
The 'tab input' field should have it's tabindex attribute set to -1.
4 On 'search input' blur (item selected/tab out etc) return the tabindex to what they originally were.

Hi - this is still broken. Any updates?

It seems like this still is broken on 18.0?

Any news here. Still an issue

Based on https://github.com/angular-ui/ui-select/issues/1544
I use this to focus out when tab key is pressed in multiple ui-select :
    angular.module('myModule')
        .directive('uiSelectCloseOnTab', uiSelectCloseOnTab);

    function uiSelectCloseOnTab() {
        return {
            require: 'uiSelect',
            link: function(scope, element, attrs, $select) {
				var that = this;
                var searchInput = element.querySelectorAll('input.ui-select-search');
                if(searchInput.length !== 1) throw Error("bla");

                searchInput.on('keydown', {select: $select}, function(event) {
                    if(event.keyCode == 9) {
                        event.data.select.close();
                        event.data.select.setFocus();
                    }
                });
			}
        };
    }


Changing CSS in referenced RCL doesn't show up in app without clean/build

In a hybrid app if you change the CSS in the Razor Class Library (RCL) then those changes don't show up in the app (at least on Windows). If you clean and rebuild then it shows up.
It appears that something isn't copying/overwriting the static file assets during build even though they are newer.

cc @danroth27


KAFKA-14868:Remove some forgotten metrics when the replicaManager is closed

In the ReplicaManager class, IsrExpandsPerSec, IsrShrinksPerSec, and FailedIsrUpdatesPerSec are all removed by omission.
I removed these metrics from here when it is shutdown, and added related unit tests to check to prevent forgetting to remove metrics when new metrics are added in the future.
The change has successfully passed the unit test, and when omitting to remove the metric, the unit test fails.

@hudeqi please feel free to cherry-pick this commit: divijvaidya@e6db8ea into this PR.
It introduces the unit test which fails before the removeMetrics() and passes after that.
Edit: This was in response to your deleted comment. If you have another solution to write the unit test here, please feel free to use that.

Sorry, I tried my best to write this unit test according to this method, but since newGauge has a return value, there is no way to use doAnswer. It seems that KafkaMetricsGroup must be changed? @divijvaidya

Hello, thank you for your submission, I have learned a lot, and I was not familiar with the use of mockito :)
I have merged your commit into this final commit. @divijvaidya

I am glad that you learnt some out of this PR. Happy to help!
As next steps, in this PR, we need to ensure that the build passes to begin with. It is currently failing.
[2023-04-01T10:04:20.522Z] [Error] /home/jenkins/workspace/Kafka_kafka-pr_PR-13471/core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala:347:5: ambiguous reference to overloaded definition,

[2023-04-01T10:04:20.522Z] both method doReturn in class Mockito of type (x$1: Any, x$2: Object*)org.mockito.stubbing.Stubber

[2023-04-01T10:04:20.522Z] and  method doReturn in class Mockito of type (x$1: Any)org.mockito.stubbing.Stubber

[2023-04-01T10:04:20.522Z] match argument types (Seq[java.io.File])

Could you please try running :core:compileTestScala locally, fix the problems and ensure that it passes? Feel free to let me know if you need help in fixing this.

I am glad that you learnt some out of this PR. Happy to help!
As next steps, in this PR, we need to ensure that the build passes to begin with. It is currently failing.
[2023-04-01T10:04:20.522Z] [Error] /home/jenkins/workspace/Kafka_kafka-pr_PR-13471/core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala:347:5: ambiguous reference to overloaded definition,

[2023-04-01T10:04:20.522Z] both method doReturn in class Mockito of type (x$1: Any, x$2: Object*)org.mockito.stubbing.Stubber

[2023-04-01T10:04:20.522Z] and  method doReturn in class Mockito of type (x$1: Any)org.mockito.stubbing.Stubber

[2023-04-01T10:04:20.522Z] match argument types (Seq[java.io.File])

Could you please try running ./gradlew :core:compileTestScala locally, fix the problems and ensure that it passes? Feel free to let me know if you need help in fixing this.

Very strange, I successfully compiled locally, and this unit test is also OK

I try to pass in two parameters to see if it can pass the CI test.
It is also successful in my local environment, gradle version is 8.0.2, java 17, scala 2.13 @divijvaidya

Hi, could you help to review this pr? @showuon

Do other committers have time to review this PR?

Hello, are you still reviewing this PR? @dajac


Enhance corpus statistics -- GL corpus_stats.txt

Add Grammar Learner input parses statistics (replace "links" stats in corpus_stats.txt)

number of unique connectors,
total number of connectors,
number of unique disjuncts,
total number of disjuncts.

Further improvements (need discussion):

unique & total germ links (need clarification)
unique & total seeds (~ word - disjunct pairs)

Now, it looks like here is what we want - I have edited spec and I think we can assume "link" == "germ link" in context of parses:
Number of sentences:\t
Average sentence length:\t
Number of unique words:\t
Total words count:\t
Average per-word counts:\t
Number of unique links:\t
Total links count:\t
Average per-link count:\t
Number of unique seeds:\t
Total seeds count:\t
Average per-seed count:\t
Number of unique connectors:\t
Total connectors count:\t
Average per-connector count:\t
Number of unique disjuncts:\t
Total disjuncts count:\t
Average per-disjunct count:\t


MacOS Build Error

Required Info

Camera Model
{ R200 / F200 / SR300 / ZR300 / D400 }

Firmware Version
(Open RealSense Viewer --> Click info)

Operating System & Version
MacOS

Kernel Version (Linux Only)
(e.g. 4.14.13)

Platform
Mac

SDK Version
l<IP_ADDRESS> }

Language
{C/C#/labview/nodejs/opencv/pcl/python/unity }

Segment
{Robot/Smartphone/VR/AR/others }

Issue Description
MacOS compile shows an error as below.
The homebrew libusb 1.0.22 is installed and properly linked.
[ 62%] Building CXX object CMakeFiles/realsense2.dir/third-party/easyloggingpp/src/easylogging++.cc.o
1 warning generated.
[ 62%] Linking CXX shared library librealsense2.dylib
Undefined symbols for architecture x86_64:
  "_libusb_get_port_number", referenced from:
      perc::Device::GetUsbConnectionDescriptor() in libtm.a(Device.cpp.o)
  "_libusb_get_port_numbers", referenced from:
      librealsense::platform::get_usb_descriptors(libusb_device*) in enumerator-libusb.cpp.o
      librealsense::platform::get_usb_descriptors(libusb_device*) in libuvc.cpp.o
      perc::UsbPlugListener::EnumerateDevices() in libtm.a(UsbPlugListener.cpp.o)
      perc::Device::GetUsbConnectionDescriptor() in libtm.a(Device.cpp.o)
ld: symbol(s) not found for architecture x86_64
clang: error: linker command failed with exit code 1 (use -v to see invocation)
make[2]: *** [librealsense<IP_ADDRESS>.dylib] Error 1
make[1]: *** [CMakeFiles/realsense2.dir/all] Error 2
make: *** [all] Error 2

Another user who had the same undefined symbol error on MacOS offered the advice in the link below:
https://github.com/IntelRealSense/librealsense/issues/2685#issuecomment-436498519

Another user who had the same undefined symbol error on MacOS offered the advice in the link below:
#2685 (comment)

It's compilation of one cpp, but the error happens in
make -j2  after successful cmake
cmake .. -DBUILD_EXAMPLES=true -DBUILD_WITH_OPENMP=false -DHWM_OVER_XU=false -DBUILD_WITH_TM2=false

If it is tripping up over libusb, I suspect that -DHWM_OVER_XU=false might be the cause.  Are you able to build successfully if that flag is left out of the build command?

@iPsych have you been able to resolve the issue?

@iPsych Did you try the workaround below described in https://github.com/IntelRealSense/librealsense/blob/master/doc/installation_osx.md ? Looking forward to your update. Thanks!
Note: On some Mac systems you might encounter ld: library not found for -lusb-1.0 error (either in the terminal during make or in XCode) This can be worked-around by setting environment variable: /bin/launchctl setenv LIBRARY_PATH /usr/local/lib

@RealSenseCustomerSupport @ElnazTaqizadeh
Yes, After re-install libusb using homebrew, and set the env variable using /bin/launchctl setenv LIBRARY_PATH /usr/local/lib, it resolves the issue.

@iPsych Does this mean you are able to build the latest 2.30.0 SDK on macOS Catalina? And does it also provide full T265 support? Asking this because T265 support is still officially not supported on macOS.

@neilyoung No, I am staying High-Sierra, since Mojave and Catalina have a lot of stability problems in my projects. I am using D435.

@iPsych OK, not a thing. I think I'm going to give it a try, nevertheless. Thanks.

@neilyoung could you report back when you try the build on Catalina?

@seanngpack Sure

@iPsych Glad to hear the issue resolved. Close it accordingly. Thanks!

@seanngpack Sorry, was not even able to generate a Makefile...:( Since it is not my priority I'm not pursuing this any further. At least the gist here is nonsense from first to last on Catalina :)
https://github.com/IntelRealSense/librealsense/blob/master/doc/installation_osx.md

@seanngpack OK, meanwhile I could build on macOS Catalina. https://github.com/IntelRealSense/librealsense/issues/5258


move config off into it's own internal package

this should be done.  anything else wrong open a new issue.


Add Android UserLocation heading direction when in "native" render mode v10

New Feature
In v8, rendering the UserLocation in native mode with compass enabled gave a pretty smooth and accurate indication of which way the user was facing. In v10, the native Android UserLocation doesn't have a compass indicator at all, and the "normal" (non-native) UserLocation indicator's heading direction is inaccurate and choppy.
Please add heading direction back to the native Android UserLocation indicator.
Why
This feature will allow Android users to quickly see which direction they are facing without the confusion that comes from "normal" rendering mode inaccuracy and choppiness.

Please provide a component to reproduce the issue. Android user location component should be much better now.


tehAnswer/fix/malformed_events

This change is

@tehanswer can we close it for now?

Review status: 0 of 3 files reviewed at latest revision, all discussions resolved.

Comments from Reviewable


Surface wave effects via the Craik-Leibovich or wave-averaged Navier-Stokes formulation

Eventually, we will need to represent the effects of surface waves in Oceananigans.jl.
The best way to do that is to introduce a term that models the 'wave-averaged' effects of surface waves on near-surface motions. I propose that we use the Lagrangian-mean interpretation for our velocity field in adding this term, rather than an Eulerian-mean interpretation. The Lagrangian-mean interpretation has the advantage of

Avoiding "accidental" initialization of large near-inertial oscillations due to initial conditions that are out of equilibrium with the surface wave field (eg the initial conditions in McWilliams et al 1997);

Requiring the least modification of physics, since we have to only introduce two terms (or just one for steady surface wave fields) to the momentum equations (as opposed to two terms in the momentum equations and one term in the tracer equations in the Eulerian-mean formulation);

Arguably using the Lagrangian-mean interpretation means we can avoid modifying our subgrid turbulence closure, since surface wave terms do not affect the turbulent kinetic energy balance;

The pressure field retains its original interpretation.

The surface wave field interacts with interior dynamics through its Stokes drift field, which is generally prescribed to boundary layer LES. To implement the surface wave term in the Lagrangian-mean formulation, we require gradients of the Stokes drift velocity associated with the surface wave field.
To start the best way to implement this, at least to start, is through functions. This might look something like
u_stokes(x, y, z, t) = U * exp(2*k*z)

model = Model(stokes_drift=StokesDrift(u=u_stokes), ... )

In this pattern, we have to take gradients of the function u_stokes either numerically or analytically (?)
Alternatively, we can ask users to supply the gradients of the Stokes drift of the surface wave field, though this is a bit more complicated and requires more inputs if the Stokes drift varies along coordinates other than z.
We can either call the new field model.stokes_drift or model.surface_waves.
We can validate our implementation by reproducing results in McWilliams et al (1997), Polton and Belcher (2007), and Skyllingstad and Denbo (1995).
cc @johncmarshall54

Another verification experiment we can consider is
https://journals.ametsoc.org/doi/full/10.1175/1520-0485(2004)034<0720%3ALESOTO>2.0.CO%3B2
cc @ali-ramadhan

If we want to require specification of gradients of the surface wave field, we can use
uz_stokes(x, y, z, t) = 2k * U * exp(2k*z)

model = Model(surface_waves=SurfaceWavesStokesDrift(uz=uz_stokes, ...)

We should also probably use SurfaceWavesStokesDrift regardless to be explicit that the Stokes drift field is associated with surface waves.
Perhaps model.surface_waves is also preferred for this reason.

@glwagner Has this been resolved with PRs #519 and #571?

Yes.


refactor: define clear type for compiler option in ts-jest config

Test plan

Added missing e2e tests for ttypescript support
Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information
N.A.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 94.156%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
1166

Relevant Lines:
1193

💛  - Coveralls


ENH: Adding authors in pdf output

Preprocessing tex to show author names in the desired pdf output files.
Steps as of now :-
 replace "% Pygments definitions" with  "    \\author{Thomas J. Sargent and John Stachurski}"+"\n"+"    % Pygments definitions"

this is now an option in conf.py as jupyter_pdf_author


fix copy paste issue in pilot codeowners

cc @howardjohn

@rshriram: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

integ-new-install-k8s-presubmit-tests-master
04529263299964741d6f76e2f4da0ecde359b770
link
/test integ-new-install-k8s-presubmit-tests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rshriram: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

integ-new-install-k8s-presubmit-tests-master
04529263299964741d6f76e2f4da0ecde359b770
link
/test integ-new-install-k8s-presubmit-tests-master

integ-mixer-k8s-presubmit-tests-master
04529263299964741d6f76e2f4da0ecde359b770
link
/test integ-mixer-k8s-presubmit-tests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


feat: change inline to bold

Updates the docs to follow the NGINX style guide:

Use bold to reference files, flags, commands (outside direct CLI instructions) instead of inline code
Sentence case for titles instead of Title Case

This PR does two quite different things in the same commit. Are we sure about that?

I will avoid unrelated changes in a long PR like this one going forward.


Entity not available

Hi,
thanks for your work!! Really appreciated.
I tried latest version (as of commit 0d3193203d9b94901eaca8483942ddc945f33986) in HA but tapo switch is not available.
The stack trace from HA registry is:
Error while setting up tapo_p100_control platform for switch

Traceback (most recent call last):
  File "/usr/src/homeassistant/homeassistant/helpers/entity_platform.py", line 249, in _async_setup_platform
    await asyncio.shield(task)
  File "/usr/local/lib/python3.9/concurrent/futures/thread.py", line 52, in run
    result = self.fn(*self.args, **self.kwargs)
  File "/config/custom_components/tapo_p100_control/switch.py", line 44, in setup_platform
    add_entities([P100Plug(p100)])
  File "/config/custom_components/tapo_p100_control/switch.py", line 53, in __init__
    self.update()
  File "/config/custom_components/tapo_p100_control/switch.py", line 88, in update
    encodedName = data["result"]["nickname"]
TypeError: string indices must be integers

I ended up restoring the conversion from json to make it work:
diff --git a/tapo_p100_control/switch.py b/tapo_p100_control/switch.py
index 686fafe..ba4a959 100644
--- a/tapo_p100_control/switch.py
+++ b/tapo_p100_control/switch.py
@@ -84,6 +84,7 @@ class P100Plug(SwitchEntity):
         self._p100.login()

         data = self._p100.getDeviceInfo()
+        data = json.loads(data)

         encodedName = data["result"]["nickname"]
         name = b64decode(encodedName)

With the patch applied to tapo switch work as expected.
Marco

Can you give more info on the issue before you fixed it?

I get the same error with the newest version and newest version of HASS installed as VM (.ova) on a Synology NAS.

Hey, looks like a similar issue here, on the latest version, for lights and switch
Traceback (most recent call last):
  File "/usr/src/homeassistant/homeassistant/helpers/entity_platform.py", line 249, in _async_setup_platform
    await asyncio.shield(task)
  File "/usr/local/lib/python3.9/concurrent/futures/thread.py", line 58, in run
    result = self.fn(*self.args, **self.kwargs)
  File "/config/custom_components/tapo_p100_control/light.py", line 46, in setup_platform
    add_entities([L1510Bulb(l530)])
  File "/config/custom_components/tapo_p100_control/light.py", line 56, in __init__
    self.update()
  File "/config/custom_components/tapo_p100_control/light.py", line 100, in update
    self._l530.handshake()
  File "/usr/local/lib/python3.9/site-packages/PyP100/PyP100.py", line 124, in handshake
    encryptedKey = r.json()["result"]["key"]
KeyError: 'result'```

Logger: homeassistant.components.switch
Source: custom_components/tapo_p100_control/switch.py:83
Integration: Switch (documentation, issues)
First occurred: 17:18:34 (1 occurrences)
Last logged: 17:18:34
Error while setting up tapo_p100_control platform for switch
Traceback (most recent call last):
File "/usr/src/homeassistant/homeassistant/helpers/entity_platform.py", line 249, in _async_setup_platform
await asyncio.shield(task)
File "/usr/local/lib/python3.9/concurrent/futures/thread.py", line 58, in run
result = self.fn(*self.args, **self.kwargs)
File "/config/custom_components/tapo_p100_control/switch.py", line 44, in setup_platform
add_entities([P100Plug(p100)])
File "/config/custom_components/tapo_p100_control/switch.py", line 53, in init
self.update()
File "/config/custom_components/tapo_p100_control/switch.py", line 83, in update
self._p100.handshake()
File "/usr/local/lib/python3.9/site-packages/PyP100/PyP100.py", line 124, in handshake
encryptedKey = r.json()["result"]["key"]
KeyError: 'result'

<img width="639" alt="Screenshot 2022-04-11 at 5 24 57 pm" src="https://user-images.githubusercontent.com/6993121/162786405-2cfc8b45-2777-44f4-a7c6-c028a543c3da.png">

This solved the problem for me:
https://github.com/fishbigger/HomeAssistant-Tapo-P100-Control/issues/57#issuecomment-1097873717


Quote plus newline breaks xsv fmt

First off, love this tool, thanks for putting it together and maintaining it. I had an issue parsing a csv file and I'm wondering if there is a solution. I broke down the issue into a simple example.
I'm inputting a pipe delimited formatted file sample.csv into xsv fmt with this command:
xsv fmt -d "|" sample.csv
sample.csv is:
"ColA"|"ColB"
"sample"|"A
B"
"sample"|"A "B"
A"

The error yielded is:
CSV error: record 3 (line: 5, byte: 45): found record with 1 fields, but the previous record has 2 fields
It looks like the quotes plus the newline breaks xsv's parsing. I tried looking into the xsv input command for something that may help but didn't find anything. I'm not an expert on CSV, but I wonder whether this is a solvable problem? Or whether there is no real way to resolve this ambiguity.
Thanks!

I think the error is pretty much telling you the problem. Your last record:
"sample"|"A "B"
A"

Is malformed. You can't use quotes inside of a field without escaping them. The standard way to do this is to double them:
"sample"|"A ""B""
A"

xsv should have no issues with new lines inside of CSV fields.

Thanks! It looks like this is an issue with Microsoft SQL Server exporting invalid CSVs.

Ah. Maybe look for an option to escape quotes?

Looks like there is none for this version of SQL Server, sadly. Ended up trying a different method of exporting data. No problem with xsv though, so I'll close this!


removed unused code and files

This PR tidies up all the unused code and files.
All was done via safe delete and runs cleanly but please have a spot check

@JamesSmartCell builds are all running fine and I was able to play around with it on the emulator looking for things like images and labels to see if they are intact (all good from what I have seen)
the labels that were removed are only the ones that were never used in the first place, if a label id is used it would have stayed intact, therefore referencing wouldn't have changed as the ones that were implemented can still be referenced.
Perhaps you would like to try it out on your phone first? From my angle it looks good, perhaps @colourful-land could also give it a spin.

@JamesSmartCell let's merge this ASAP, please have a try on your phone then merge, it should work fine.

We'll push it through after the release tonight.


"Docker::Error::NotFoundError: No such image" when trying to pull large images.

Cookbook version
2.15.6
Chef-client version
12
Platform Details
Hosting on AWS
OS: Amazon Linux 2016.09
Scenario:
I'm trying to pull a large image (~10 GB) from AWS ECR. However, after a minute or two, it will fail saying that the image doesn't exist.
Note: Before you say anything about the size of the image, yes, I know it's an incredibly large image or that it almost defeats the purpose of using Docker, etc, etc.
Steps to Reproduce:

Find a large docker image.
Try pulling it down with:

docker_image 'http://some/repo/here' do
    repo 'http://some/repo/here'
    tag "latest"
    action :pull
end

It's that simple. If the image is large, then it will fail every time. I haven't played with the different sizes to find out at what point it's breaking. I have played with the read_timeout and write_timeout options, setting it to 3600 (more than enough time to pull 10 GB) but that didn't work either.
Expected Result:
Docker should pull down the image.
Actual Result:
An error is produced saying that the image does not exist.
[2017-05-15T17:45:37+00:00] ERROR: Running exception handlers
[2017-05-15T17:45:37+00:00] ERROR: Exception handlers complete
[2017-05-15T17:45:37+00:00] FATAL: Stacktrace dumped to /var/chef/runs/a5726df5-8f11-439e-9828-ede14636d1f6/local-mode-cache/cache/chef-stacktrace.out
[2017-05-15T17:45:37+00:00] FATAL: Please provide the contents of the stacktrace.out file if you file a bug report
[2017-05-15T17:45:37+00:00] ERROR: docker_image[**********.dkr.ecr.us-west-2.amazonaws.com/imagename] (addrgeo::default line 4) had an error: Docker::Error::NotFoundError: No such image: **********.dkr.ecr.us-west-2.amazonaws.com/imagename:latest
[2017-05-15T17:45:37+00:00] FATAL: Chef::Exceptions::ChildConvergeError: Chef run process exited unsuccessfully (exit code 1)

i dont use AWS ECR but my guess is that chef docker isnt properly logged
into the registry
On Mon, May 15, 2017 at 2:51 PM, Clint<EMAIL_ADDRESS>wrote:

Cookbook version
2.15.6
Chef-client version
12
Platform Details
Hosting on AWS
OS: Amazon Linux 2016.09
Scenario:
I'm trying to pull a large image (~10 GB) from AWS ECR. However, after a
minute or two, it will fail saying that the image doesn't exist.
Note: Before you say anything about the size of the image, yes, I know
it's an incredibly large image or that it almost defeats the purpose of
using Docker, etc, etc.
Steps to Reproduce:

Find a large docker image.
Try pulling it down with:

repo '427615184843.dkr.ecr.us-west-2.amazonaws.com/imagename'
tag "#{node[:imagename][:version]}"
read_timeout 600
write_timeout 600
action :pull

end```
It's that simple. If the image is large, then it will fail every time. I haven't played with the different sizes to find out at what point it's breaking. I have played with the read_timeout and write_timeout options, setting it to 3600 (more than enough time to pull 10 GB) but that didn't work either.
Expected Result:
Docker should pull down the image.
Actual Result:
An error is produced saying that the image does not exist.
[2017-05-15T17:45:37+00:00] ERROR: Exception handlers complete
[2017-05-15T17:45:37+00:00] FATAL: Stacktrace dumped to /var/chef/runs/a5726df5-8f11-439e-9828-ede14636d1f6/local-mode-cache/cache/chef-stacktrace.out
[2017-05-15T17:45:37+00:00] FATAL: Please provide the contents of the stacktrace.out file if you file a bug report
[2017-05-15T17:45:37+00:00] ERROR: docker_image[**********.dkr.ecr.us-west-2.amazonaws.com/imagename] (addrgeo::default line 4) had an error: Docker::Error::NotFoundError: No such image: **********.dkr.ecr.us-west-2.amazonaws.com/imagename:latest
[2017-05-15T17:45:37+00:00 <http://dkr.ecr.us-west-2.amazonaws.com/imagename:latest%5B2017-05-15T17:45:37+00:00>] FATAL: Chef::Exceptions::ChildConvergeError: Chef run process exited unsuccessfully (exit code 1)```

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<https://github.com/chef-cookbooks/docker/issues/858>, or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABKpSGkWH0kLeu7JtGsISojFjo4SPkHqks5r6MjhgaJpZM4Nbvgk>
.

@chasebolt - I have confirmed that it is logged in properly. I can pull small images just fine. For example, I pulled busybox, re-tagged it, pushed to AWS with a different tag. I can pull that image from the same repo just fine.

you verified the busybox pull via chef and not cli correct?

just double checking as chef and cli work 100% independently of each other. so while cli may work that doesnt guarantee chef will.

not sure if this applies to you https://github.com/chef-cookbooks/docker/issues/826

@chasebolt - yes, I did verify with Chef.

I've seen this on pulls from the public hub and from our internal registry.  The "no such image" is a false error that I've seen thrown on multiple errors.  From my chair when an image fails to pull for any reason the real error is swallowed and "no such image" is thrown.
I haven't dug into the mechanics of it as whenever I've seen this it's been a symptom of another problem, so I've focused my efforts on fixing that.  Based on my experience I'd say this is a timeout getting falsely reported as no such image.  Check out the read_timeout and write_timeout parameters on the docker_image resource.

@CVTJNII - The first thing I did was up the read_timeout and write_timeout. I had them up to 3600 and it was still failing. I'm with you though - I'm pretty sure this is a timeout issue that isn't handled properly.

if you want to get into some debugging you can run this before your chef run and watch the docker api calls to see where it fails/timeout.
https://gist.github.com/chasebolt/3e58bc05203a6fcf5d71

Thanks @chasebolt! I'll give that a shot.

After running the script that @chasebolt linked, I can confirm that it's a timeout issue. The download starts, but fails consistently after a period of time and throws the Docker::Error::NotFoundError: No such image error.

Somehow I missed this last night after hastily giving it another go. Turns out this is user error - I was running out of storage on disk. However, the error that is being thrown needs to be fixed...
The Docker API is throwing:
{"errorDetail":{"message":"write /var/lib/docker/tmp/GetImageBlob934167277: no space left on device"},"error":"write /var/lib/docker/tmp/GetImageBlob934167277: no space left on device"}

Chef is throwing:
Docker::Error::NotFoundError: No such image

thanks for the followup!


fix(mat-line): fix layout bug (#19809)

use flex: auto instead of width: 100% to allow .mat-list-text element to take up the available space

stackblitz demonstrating issue
Before

After

Seems okay at first glance, but we'll have to see if this causes any visual diffs inside Google (this process can be pretty slow)
Can you expand on the commit message? Saying "fix layout bug" doesn't really provide enough information about what this change does and why. The format would be something like
fix(material/list): use flexbox to size mat-line elements

<explanation here about why `flex: auto` is better than `width: 100%`>

@jelbourn thanks. I updated the commit message.


Today button inconsistent close of date picker

Hi,
When using the today button in the date(time) picker, I noticed that there is some inconsistant behaviour on whether or not it closes the date(time) picker. Sometimes it does and sometimes it doesn't.
I would like to have it closed every time I click the today button, if possible.
Next to that, when using the custom Now button as explained in #10, there is no way I can let it close the date(time) picker as far as i know, this would be a great enhancement.
Regards,
Kevin

Unfortunately, there isn't an easy way to instruct the widget to close from the properties. The today button won't close the menu if the time matches the previous value's time. This allows users to click the today button, then click the time from the menu. I didn't really expect much use for the today button with datetimes, so let me know if you have a better idea on how you would expect this to work.
Meanwhile, I've made this JavaScript action to close the menu and re-focus the input. You should be able to simply add in your nanoflow for the button.

ToggleAdvancedDatePickerFromCustomContent.mpk.zip

" I didn't really expect much use for the today button with datetimes"
That is indeed what I meant in #10; a Now button would make more sense to me.
Thanks for the javascript action, will try and implement it soon!


gromacs._parse_gmx_energy has hard-coded path to out.edr file

Funcition _parse_gmx_energy in drivers/gromacs is reading energy data from hard-coded out.edr file:
@requires_package("panedr")
def _parse_gmx_energy(edr_path: str) -> dict[str, unit.Quantity]:
    """Parse an `.edr` file written by `gmx energy`."""
    import panedr

    parsed_energies = panedr.edr_to_df("out.edr").to_dict("index")[0.0]
    parsed_energies.pop("Time")

It should be solved by passing *edr_path* to **panedr.edr_to_df**

Heh, nice find. Was probably never a problem since that variable is only ever set to "out.edr" in my usage. It wouldn't surprise me if there's other similar cases in the codebase.


[material-ios] Updated the binding to v72.2.0

Updated to https://github.com/material-components/material-components-ios/releases/tag/v72.1.0

VS bug #747237

Version 72 Installed and ran fine with Visual Gallery locally
Only thing I had to change was the call to SetShadowElevation now takes an nfloat opposed to a double

Yeah, they changed the type of all things elevated to CGFloat or our nfloat.

LOL, another update :)


Remove obsolete reference to 00-POD6-CONTROL

Remove obsolete reference to 00-POD6-CONTROL in https://github.com/Raku/doc/blob/master/CONTRIBUTING.md#adding-a-new-language-document

Looks like the reference in the docs was originally added in 00c3f5ce400e97c56a1f6dc34b14b45d0055f230 by @tbrowder;  the file it referred to was removed in 1470182c59262b6db62c4cb540852fc247985d7f


Dataset increased from EMNLP paper

Hi,
Thank you for your dataset. I just wanted to say that this dataset is slightly different from the one described in your paper.
Probably it's because you have been adding newer articles, but it would be nice to state this information in the README file.
I was trying to reproduce the experiments and, for comparability, it would be nice to be able to do this on the same exact data.

EMNLP
GitHub

total size
34737
37554

train (media)
22,969
26,590

validation (media)
5,098
2,356

test (media)
1,200
1,300

train (random)
26,828
27,978

validation (random)
6,709
6,996

test (random)
1,200
1,300

Left
...

Center
...

Right
...

Best,
Martino

Hi Martino, I have the same question. I wonder if you have received any response from the author?
Best,
Zihao


Another site to grab resources from

https://github.com/jivoi/awesome-osint

I think the links in that project are just taken from the handbook you mention in Issue #24

You know....that very well could be. Didn't cross check.


Don't use unnecessary polymorphism (from #1618)

&str is isomorphic to T: AsRef<str>, but does not generate redundant monomorphisations of the same function.
This is a spin-off from #1618.

Honza, why?
do you have any indication that the rust compiler will generate worse code with those classes?
If the only caller is &str, I expect the compiler to be able to figure this out on its own.
there is a big advantage in using AsRef<str>, ToString, and friends: other callers that have other types don't have to convert explicitly, if there is an implicit conversion.
It is true that it is not needed when the only caller is of a certain type, but if it doesn't generate worse code, this is exactly the kind of stuff that computers should worry about, not humans.

@glommer, I may be wrong but I think the rationale here is that monomorphization slows down compile time? But then it's probably anecdotical in comparison to the amount of monomorphization that's already happening, so maybe @honzasp can explain why he thinks that's a necessary change.

The issue is not that the compiler generates worse code, the issue is that the compiler has to generate a copy of the function for every type that you happen to use. In these cases it is probably negligible, but I saw big functions with ~50 lines of code being monomorphised twice just to abstract away a .to_string().
The costs of this are increased size of generated code, slower compilation, bigger files, more confusing debugging (one function in source corresponds to N independent functions in the generated code). None of this is very important in this particular case, but it might if this pattern grows unchecked.
This is just a bad habit.

By this logic, we should replace all &T function parameters with impl AsRef<T>, which I think we all agree would be ridiculous.

By this logic, we should replace all &T function parameters with impl AsRef, which I think we all agree would be ridiculous.
This is a bad faith argument and is only true if impl AsRef is isomorphic to &T, which is not true for AsRef<Path> the, is not isomorphic to &Path for instance.

This is not just a bad faith argument. It is also adversarial for no reason, by arguing the extreme case to demonstrate the underlying rule. Code is written by humans (for now), so common sense plays a role. The extreme case doesn't matter.
Conversely you should ask yourself why, even in the presence of this pattern, you don't see things like impl AsRef<T> for every T. And the reason for that is that in practice, there are a couple of types for which deref to others very commonly. String, Path, etc. A function taking AsRef<Path> can take a PathBuf, a Path, a String, a &str, and it is very common in practice to have one or the other from calling contexts.
I am happy to merge this so life can move on, but this is a pattern that I happen to like (when used reasonably, for types like Path and String). I would argue that it is almost crucial for public APIs (which those are not, which is why I am ok bending), and I think you are optimizing for the wrong thing here.

This is a bad faith argument

Not sure what you mean by this fashionable expression, but the technical term for this type of argument is reductio ad absurdum ("if these arguments for AsRef<str> make sense, then we should be using AsRef<T> much more often, which is clearly absurd")

is only true if impl AsRef is isomorphic to &T, which is not true for AsRef the, is not isomorphic to &Path for instance.

impl AsRef<Path> is isomorphic to &Path, because the only meaningful thing that you can do with such value is to convert it to &Path.

Conversely you should ask yourself why, even in the presence of this pattern, you don't see things like impl AsRef<T> for every T.

Yes, this is exactly what I'm asking :) One could use exactly the same arguments for using, say, impl AsRef<Policies> instead of &Policies, because it makes it convenient to pass &Policies, Arc<Policies> or Box<Policies>. We don't do this, and perform the conversion in the caller (which in most cases is just a single &) instead of generating a new copy of the callee for every combination of types that we happen to use. What is so different about str and Path?

I would argue that it is almost crucial for public APIs

Maybe, but the pattern here is that the polymorphic public function simply converts the arguments and calls the monomorphic function that performs the actual work, precisely to avoid needless copies of functions.
https://doc.rust-lang.org/src/std/fs.rs.html#2174-2176
There is even a crate that abstracts this pattern
https://github.com/llogiq/momo

I think you are optimizing for the wrong thing here.

The target/ directory on my computer takes 35 GB, so compilation size (and speed) do bother me :) Again, any performace/code size/compilation speed implications are trivial in this PR, but they could quickly get meaningful if we started to use this pattern more heavily.
What I am always optimizing for is clarity and simplicity. Which of these two snippets is more clear and simple?
// before
    pub fn new<N, T>(name: N, tag: T) -> Self
    where
        N: ToString,
        T: ToString,

// after
    pub fn new(name: String, tag: String) -> Self

(Note that this PR reduced the number of lines, so the code without AsRef<> is simpler and shorter.)


Appstudio update test-component-pac-gmhz

Pipelines as Code configuration proposal

Pipelines as Code CI/test-component-pac-gmhz-on-pull-request has successfully validated your commit.

StatusDurationName

✅ Succeeded
6 seconds
init

✅ Succeeded
22 seconds
clone-repository

✅ Succeeded
53 seconds
build-container

✅ Succeeded
11 seconds
inspect-image

✅ Succeeded
13 seconds
deprecated-base-image-check

✅ Succeeded
13 seconds
clair-scan

✅ Succeeded
34 seconds
clamav-scan

✅ Succeeded
8 seconds
sbom-json-check

✅ Succeeded
11 seconds
optional-label-check

✅ Succeeded
11 seconds
label-check

✅ Succeeded
6 seconds
show-summary

✅ Succeeded
4 seconds
show-sbom

Pipelines as Code CI/test-component-pac-gmhz-on-pull-request has successfully validated your commit.

StatusDurationName

✅ Succeeded
6 seconds
init

✅ Succeeded
15 seconds
clone-repository

✅ Succeeded
25 seconds
build-container

✅ Succeeded
13 seconds
deprecated-base-image-check

✅ Succeeded
14 seconds
inspect-image

✅ Succeeded
8 seconds
clair-scan

✅ Succeeded
34 seconds
clamav-scan

✅ Succeeded
9 seconds
sbom-json-check

✅ Succeeded
7 seconds
optional-label-check

✅ Succeeded
6 seconds
label-check

✅ Succeeded
5 seconds
show-sbom

✅ Succeeded
6 seconds
show-summary

Pipelines as Code CI/test-component-pac-gmhz-on-pull-request has successfully validated your commit.

StatusDurationName

✅ Succeeded
6 seconds
init

✅ Succeeded
15 seconds
clone-repository

✅ Succeeded
25 seconds
build-container

✅ Succeeded
13 seconds
deprecated-base-image-check

✅ Succeeded
14 seconds
inspect-image

✅ Succeeded
34 seconds
clamav-scan

✅ Succeeded
8 seconds
clair-scan

✅ Succeeded
9 seconds
sbom-json-check

✅ Succeeded
6 seconds
label-check

✅ Succeeded
7 seconds
optional-label-check

✅ Succeeded
5 seconds
show-sbom

✅ Succeeded
6 seconds
show-summary


POC using yarn workspaces

https://github.com/bfanger/nextjs.shared-ui/tree/yarn-workspaces-poc

Cool! I was planing to try it out with Yarn as well.


Fixing song command in private chats

Yes, I already checked it on my bot. It's working.

if /song command to download songs, why does it pass: in private chat. there is no relationship with /song and /play command.
maybe I'm wrong


Rank nodes in graphs by layer index

Never mind: graphs seem to be behaving now, so I'm not going to complicate the implementation with this explicitly.


OPA - After clicking Enable in the Dashboard I do not get redirected to the OPA Overview

What kind of request is this:
Bug
Steps to reproduce (least amount of steps as possible):

Install Rancher (Used for testing: v2.4-head commit d0a55f080)

dashboard index points to https://releases.rancher.com/dashboard/latest/index.html

Create a cluster (Cloud or Custom)
Navigate to Try Dashboard
Click OPA Gatekeeper from the Left Menu in the Cluster section.
I see the button getting in non-clickable status then to clickable

Result:
I do not get the page refreshed or my browser redirected to the OPA Gatekeeper Overview page, After enabling I had to refresh to be able to see it
Here just after clicking the button is disabled and then enabled:

Refreshing the page:

Environment information

Rancher version:

2.4-head (05/28/2020) d0a55f080

Installation option: Single

I also not get redirected to the OPA Gatekeeper Description page (where the Customize and Enable buttons are located) when I Disable OPA.

I believe there are a couple issues happening here. One of them is UI related, the others I do not believe to be UI related.
First the errors are not showing when the enable action fails. Currently there is a timeout of 300 seconds that the UI waits for the app to get the condition Deployed: True, if that fails the button should error and you should see a message about the failure. That is not happening. I will issue a fix to ensure the ui displays the error.
I believe there are some backend issues here as well. On v2.4.5-rc7 I was able to reproduce this easily. The backend never seems to send the condition update through the websockets, on master this is happening fine. When I run the release-2.4 dashboard UI branch locally against a master-head backend I do not see the issues and gatekeeper is enabled fine.  There must be some change in master that isn't in 2.4. @prachidamle should probably investigate this why these messages are not being sent. @deniseschannon I am not sure how Steve is being put into 2.4 Rancher release so it may be resolved when those get synced.

This is not going to be relevant anymore, deploying an app is not going to bring you into it.


Problem with model "Lossy Gear" and approach to a solution

Reported by Christian.Bertsch on 6 Oct 2008 14:31 UTC
(This ticket was rejected by the spamfilter previously and is now added by Dietmar Winkler (dietmarw) again.)
For the decision what side of the gear is he driving one, the implementation within the Modelica library uses the cut torque  tau_A as described in the paper  Pelchen C., Schweiger C., and Otter M.: "Modeling and Simulating the Efficiency of Gearboxes and of Planetary Gearboxes,"
Instead tau_A - tau_bf,A should be used.
The difference plays a role only in cases where the driving side is not obvious (see attachment).
An example is given, where this leads to a not convergent solution.
The error occurs with MODELICA Standard library 2.2.2 within Dymola 6.1; in the code of Modelica Standard Library 3.0 the problem still exists.

Migrated-From: https://trac.modelica.org/Modelica/ticket/108

Comment by dietmarw on 9 Jan 2009 05:53 UTC
Could this be fixed for [milestone:MSL3.0.1 3.0.1 release]?

Comment by dietmarw on 21 Jan 2009 10:01 UTC
Martin Otter wrote::
I had a detailed look at it last week. This is a tricky issue. In certain rare cases, the LossyGear model will be stuck (chattering) because of a bug in the model. With a correct model, this would not occur. So clearly, this must be fixed. However, this is too "hot" for me now. If this is fixed, a large amount of tests have to be carried out with all models that directly or indirectly use it in order to make sure to not newly break something else. So, this bug will be shifted to the next release of MSL.

Modified by otter on 21 Jun 2009 08:50 UTC

Comment by dietmarw on 11 Sep 2009 22:20 UTC
Christian Bertsch and Max Westenkirchner have worked on a corrected version of LossyGear.
See:

[attachment:CB_package.mo CB_package.mo] for the changed implementation my_Lossy_gear and some testcases
[attachment:Lossy-Gear-Bug_Solution.pdf Lossy-Gear-Bug_Solution.pdf] for a detailed documentation of the new implementation

Comment by dietmarw on 25 Nov 2009 11:53 UTC
Milestone MSL3.1.1 deleted

Comment by otter on 25 Aug 2010 07:59 UTC
Fixed in 049ad87389eac3f98e2eb868d4dbc312070802d2
according to the proposal


[MLS Spec change] Sub-group branching requires fresh key packages for each member (#624)

Description of the changes
Adds a validation step for validation in the sub-group branching process. I don't think we're doing this at the moment.
Link to the exact changes
https://github.com/mlswg/mls-protocol/pull/624

I filed #1095 to actually implement this feature and remove this from the spec changes.


Feature Request: Incremental backup feature in kubegres

Hello All,
First of all, thank you so much for this wonderful project. I have a feature request :)
I was not able to find anywhere in documentation if does Kubegres provide incremental backup facility(just the way it is available in PostgreSQL). If not, can we please have this feature added as it would be quite helpful
Regards,
Ninad

Thank you for your suggestion and your kind feedback about Kubegres.
Could you please provide more details about how you would see the incremental backup working if you had to do it manually?
For example, which binary would you use and the options you would pass to it?

Hello @alex-arica ,
I am not much from Postgres DB background, but below links I believe could help to provide better information about how in general Postgres DB backup is been taken with example.

https://stackoverflow.com/questions/5529603/best-method-for-postgresql-incremental-backup

2)https://mkyong.com/database/postgresql-point-in-time-recovery-incremental-backup/#:~:text=PostgreSQL “Point-in-time,or may be archive backup.&text=This mechanism use the history,since last database full backup.
Hope that helps!
Regards,
Ninad

Thank you for those 2 links.
As per the PostgreSql documentation page that you shared, you can configure incremental backup using WAL archiving by modifying PostgreSql configuration file postgres.conf (you set a value for archive_command in that file) and by running the SQL commands SELECT pg_start_backup and SELECT pg_stop_backup.
Kubegres allows you to override postgres.conf, as explained here:
https://www.kubegres.io/doc/override-default-configs.html
Please let me know if that helps.

Hello Alex-arica,
Thanks for the details. Let me check if this serve my purpose and come back
Regards,
Ninad

Hello @alex-arica ,
Could you confirm if Kubegres uses the db-dump mechanism which is based on the pg_dump utility of postgres?
Regards,
Ninad

Yes by default Kubegres uses the db-dump mechanism which is based on the pg_dump, as per the script here:
https://github.com/reactive-tech/kubegres/blob/main/controllers/spec/template/yaml/BaseConfigMapTemplate.yaml#L113

okay, that's great. Then I guess we can close this issue since this already has what I was looking for


Switch to scala 3 + java 17

Scala 3 has several improvements over the currently used scala version. Even more, in the mid-term I expect that we will run into several problems if we stick to scala 2.
We may consider using this version change to also switch to the latest java LTS which is currently java 17.
For a full switch, we depend on updates of the following tools to support scala 3

[x] Scoverage
[ ] Scapegoat

We should also consider using this change for a new, actually the first public, release.
Therefore it might make sense to solve #17 before.

JDK has been upgraded to version 17 now in #60

scoverage has been updated :heavy_check_mark:

Now, gradle-scoverage supports scoverage 2 (and thus Scala 3) as well: https://github.com/scoverage/gradle-scoverage/pull/192

@t1b00 thanks for the hint, we'll consider your repo when we discuss a switch to Scala 3 again


Use a block allocator in the std::map

MS VC doesn't seem to be conforming to (1) https://en.cppreference.com/w/cpp/container/map


Cleaning up getTableName() for segment metadata

Removing unnecessary calls to segmentMetadata.getTableName()
After this change, only 3 places will call segmentMetadata.getTableName():

From upload API, derive table name from segment metadata that is being uploaded
ZKMetadataUtil.updateSegmentMetadata() - updating segment zk metadata from segment metadata during segment upload
ColumnarToStarTreeConverter provides table name to generator config from segment metadata.

Codecov Report

Merging #4289 into master will decrease coverage by 0.18%.
The diff coverage is 84.48%.

@@             Coverage Diff             @@
##             master   #4289      +/-   ##
===========================================
- Coverage     67.29%   67.1%   -0.19%
  Complexity       20      20
===========================================
  Files          1040    1040
  Lines         51662   51655       -7
  Branches       7238    7238
===========================================
- Hits          34767   34665     -102
- Misses        14507   14630     +123
+ Partials       2388    2360      -28

Impacted Files
Coverage Δ
Complexity Δ

...re/segment/virtualcolumn/VirtualColumnContext.java
100% <ø> (+8.33%)
0 <0> (ø)
:arrow_down:

...helix/core/sharding/BucketizedSegmentStrategy.java
0% <0%> (ø)
0 <0> (ø)
:arrow_down:

.../pinot/controller/api/upload/SegmentValidator.java
65.38% <100%> (-0.66%)
0 <0> (ø)

...indexsegment/immutable/ImmutableSegmentLoader.java
92.15% <100%> (-0.16%)
0 <0> (ø)

.../core/indexsegment/mutable/MutableSegmentImpl.java
81.04% <100%> (ø)
0 <0> (ø)
:arrow_down:

...apache/pinot/controller/api/upload/ZKOperator.java
72.52% <100%> (-0.3%)
0 <0> (ø)

.../sharding/BalanceNumSegmentAssignmentStrategy.java
90.62% <100%> (-0.29%)
0 <0> (ø)

...harding/ReplicaGroupSegmentAssignmentStrategy.java
100% <100%> (ø)
0 <0> (ø)
:arrow_down:

...ntroller/helix/core/PinotHelixResourceManager.java
63.07% <100%> (-0.13%)
0 <0> (ø)

...pache/pinot/minion/executor/PurgeTaskExecutor.java
69.56% <100%> (ø)
0 <0> (ø)
:arrow_down:

... and 44 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7566790...25628d1. Read the comment docs.

Can you add more descriptions? The only time when you call SegmentMetadata.getTableName() is during segment push?

Can you add more descriptions? The only time when you call SegmentMetadata.getTableName() is during segment push?

I have updated the commit message.

is required.
and 3.  is required for backward compatibility (writing table.name to segment zk metadata or segment metadata). We can remove them when we decide to remove tableName completely from the segment metadata.

Can we mark segmentMetadata.getTableName() with @ deprecated?
minor suggestions, other than that lgtm

As we discussed offline, I will deprecate tableName from segment zk metadata, not from segment metadata.

#4468


add affiliations to founders pics

professor at HMS, JKU, Utah, ...

link to labs (e.g. gehlenborglab)

christian introduces jekyll to stefan


nginx/pkg/config: delete unuseful variable

nginx/pkg/config: delete unuseful variable

This change is

Coverage remained the same at 47.073% when pulling f4da971b86f379b857cfad77f70781418c2f5eb6 on caiyixiang:del_unuse_var into f9663a8d949ee1b92ac02cf35c9794e4b2a1a091 on kubernetes:master.

/lgtm

@caiyixiang thanks!


fix debug

It seems I didn't get this quite right previously. This should give us what we want.

We should update the PR description to clarify what was broken, and what we're fixing here (we'll want this in the changelog as well).
I think we could call this something like "disable debug output in non-debug environments", something like that.


RFP - ossia-score

Checklist

[X] The package I am requesting does not already exist on https://community.chocolatey.org/packages;
[X] There is no open issue for this package;
[x] The issue title starts with 'RFP - ';
[X] The download URL is public and not locked behind a paywall / login;

Package Details
Source code: https://github.com/ossia/score
Software project URL: https://ossia.io/
Direct download URL for the software / installer: https://github.com/ossia/score/releases/download/v3.1.11/ossia.score-3.1.11-win64.exe
Release Notes: https://github.com/ossia/score/releases/tag/v3.1.11
Software summary / short description:
An interactive sequencer for the intermedia arts
Package Expectations

Recommended: Windows 10. Must be at least Windows 7 with all system updates installed.
score and libossia use Bonjour for the OSCQuery automatic discovery feature. This means that on Windows, you must install the Bonjour Print Services for this to work.

That is indeed the package but the URL here is  https://github.com/ossia/score/releases/download/v3.1.11/ossia.score-3.1.11-win64.exe which is a direct URL. Not sure what the issue is??

As this package exists, I'm going to close this issue.

@pauby someone else (outside of the development team) submitted the package to chocolatey but it got rejected (https://community.chocolatey.org/packages/ossia-score) - what can we do, as actual developers of the software, to take over the maintainership of the package and submit it so that it is actually available?

@jcelerier The normal triage process should be followed.


Incorrect result for $transclude.isSlotFilled(name)

Note: for support questions, please use one of these channels: https://github.com/angular/angular.js/blob/master/CONTRIBUTING.md#question. This repository's issues are reserved for feature requests and bug reports.
Do you want to request a feature or report a bug?
This is, IMHO, a bug
What is the current behavior?
When a region is removed through a "ng-if" directive, this region is still recognized as filled for the parent element.
If the current behavior is a bug, please provide the steps to reproduce and if possible a minimal demo of the problem via https://plnkr.co or similar (template: http://plnkr.co/edit/tpl:yBpEi4).
http://codepen.io/anon/pen/KNOELg?editors=1010
The second h1 should not be drawn.
What is the expected behavior?
Comments are not parts of the regions as they do not fill the region tag name criteria. In such conditions, the $transclude.isSlotFilled() function should return false.
If the current behavior is the intended behavior, then we need some method to check again if the region is filled with actual content.
What is the motivation / use case for changing the behavior?
You should be able to encapsulate a region with your own markup, shall it be with awesome eye candies, but then not use that eye candy when it's not useful at all.
Which versions of Angular, and which browser / OS are affected by this issue? Did this work in previous versions of Angular? Please also test with the latest stable and snapshot (https://code.angularjs.org/snapshot/) versions.
This is using the multi-slot transclusion feature so this bug is only relevant for Angular 1.5+ This has been tested against 1.5.8 (codepen demo above) and 1.6.1 (my own project as I write this bug report)
Other information (e.g. stacktraces, related issues, suggestions how to fix)
If this require a new compilation pass to check if the transcluded region is empty or not, we should be given a new function for this check as not everyone would accept such expensive checks.
A possible start of a solution is provided as a second version of the component. The interval and cache is required because an infinite digest loop because of the transclusions if the region does not exists.
This solution is as I give it :

EXPENSIVE as a missing region will run the check every digest loop.
INACCURATE as a change to the scope within the digest loop would make any test of the correction fail.
DEPRECATED as it uses $$ functions.

This is definitely not a bug. isSlotFilled() retrns whether or not the user provided any content for the slot. What exactly the content was, what directives it has on it (e.g. ngIf with falsy condition) and what these directives do (e.g. remove the element from the DOM) is irrelevant.
IMO, it is bad design to (or at least not "the Angular way ™") to let the DOM content drive your component's behavior. The model should be the source of truth; if your component needs to change it's behavior based on some condition, that condition should be passed directly (as an expression) to the component and not have the component infer the condition based on the DOM state.

I am going to leave this open to see what others think, but this works as expected imo.

The model should be the source of truth; if your component needs to change it's behavior based on some condition, that condition should be passed directly (as an expression) to the component and not have the component infer the condition based on the DOM state.
It is as it's the model that adds or removes my region. What I gave on this codepen was a minimalist example, but I have more complex elements that relies on this optional transclusion.

One for instance is a border layout. It has 4 optional north, east, west and south regions, plus the default content as its center.
This element, as I designed it, includes some margins that would be unwanted if one region would exist but have no element.
An other would be a list. You might want to let the container element display its message when no element are to be displayed, right when a ng-repeat displays no element. Repeating the default message multiple times over the application is not a solution.

In all the cases you mentioned, you are trying to turn the DOM into your component's input (it doesn't matter whether the DOM is a result of another directive or hard-coded - the result is the same). This is not a good practice imo and not a usecase we should support.
Actually, I think you are trying to use transclusion's fallback content for something it wasn't designed for. If you want to have custom behavior (e.g. displaying a default message or styling/hiding a part of the UI) based on some condition, then your presentational components should get that condition as an input (instead of trying to infer it based on the transcluded content).
(Again, this is just my opinion and others might disagree.

@gkalpak : While I may understand your point, I can't give myself a reason why optional and/or fallback transclusion exists if relying on the DOM is forbidden.
I have a special case where I have a list from 4 different sources and I have not to display the container of that list if all 4 sources are empty. I find it hard to make my condition with 4 filtered sources.

I've found a "better", but still not ideal, way to identify if my region is present but it has consequences like my other workaround.
It breaks AngularJS compatibility with IE9-10.
It doubles all tested transclusions as the transclusion system only work with duplications (I have no trouble with it but one might call a service as his controller initialises).
My workaround component is available at this place : https://pastebin.ubuntu.com/23770996/ (sorry for the pastebin, I can't access gist.github.com from my place).
It is efficient at what it does, using mutation observers to lower the number of checks done.
This comes to the conclusion that, unlike the current "isSlotFilled" function, that evaluation is required to run the check and this step cannot be synchronous (which makes it harder to use than "isSlotFilled").
Since the strategy to transclusion only works through duplication and compilation of a "frozen template", and we (at least I) want the evaluation to be on a different level than the injection point, we might not find a more suitable solution except including it inside the transclusion function. This last idea could give even worst results.
As I said, if it costs performances to even include it in the framework, I don't want it in the framework. You may tag it as a "wont-fix" then close it. I would still advice this case in some sort of documentation.

I can't give myself a reason why optional and/or fallback transclusion exists if relying on the DOM is forbidden.

I am not sure why you think optional transclusion is in some way related to DOM access :smiley:
(As I am sure you understand already) the purpose of optional transclusion is to be able to omit certain "optional" parts of a component (e.g. an optional footer in a modal component) and the main purpose of fallback content (afaik) is to avoid boilerplate when you want to use a specific template most of the time, but still be able to overwrite it in some occasions.
What we are debating here is how/when Angular determines if transcluded content has been provided or not. The current implementation determines that, based on the presence or absence of content in the initial HTML template (and correctly so imo). This allows Angular to make its decision at compile time and is more static. What you are proposing (i.e. basing the decision on the (dynamic) state of the HTML after the initial content has been compiled and linked) is inherently less performant, would complicate things and also affect the relative order of operations (e.g. you first need to compile/link the content and then decide whether we need to insert/compile/link the fallback content).

I am not saying there are no valid usecases for it, nor am I claiming that the current implementation covers every possible usecase one might desire. I am just saying that it is sufficiently efficient, covers a reasonable amount of common usecases and aligns well with "the Angular way".
I do understand that there might be some less common usecases that the current implementation doesn't serve well, in which case you need to implement custom solutions (and yes...if necessary access the DOM 😛 - it is not forbidden btw; it is just discouraged (most of the time)).

In a nutshell, I believe the current implementation is reasonable, supports most common usecases and we should stick to that. For more advanced and rare usecases (such as yours), one would have to implement a custom solution.
I don't think it is more helpful than confusing to mention such usecases in the docs, but if you can come up with a way to improve the documentation of optional slots/fallback content/isSlotFilled(), you are more than welcome to submit a PR.
(Closing as won't fix.)