Redirect 307 and 308 are changing from POST to GET and that's not allowed

Oliver, I can see in the code that OHHTTStubs is not preserving the method type (i.e. POST vs GET) in
https://github.com/AliSoftware/OHHTTPStubs/blob/master/OHHTTPStubs/Sources/OHHTTPStubs.m:427
OHHTTPStubs.m creates an immutable request object without respect to whether the original request method was a POST or a GET. This goes against HTTP1.1 for the 307 and against RFC 7538 for the 308. In the case of 307 or 308 we need to preserve the request method in the redirect.
I'll post a pull request to fix this.

Oh, nice catch! Thx!
I'll wait for your PR to do the release I was planning to do soon (it's been ages since I did a release and some fixes already in master are still waiting for release for a while). Let me know when you find time to do that PR so I can know if it's worth waiting for your for the release or not 😉

I've actually made the change, but I will need some help to add a test case for each of these redirects. I'll go ahead and post the PR so you can review the change just the same.

:+1:
I think we have a "WIP" GitHub label don't hesitate to use it on the PR if there are some tasks still to do / tests still to add before merging

It seems like it would be rudimentary to add a label to a PR or Bug. I can see the categories on the right hand side of the web page, but it's immutable. I can't add any label. @AliSoftware can you please intervene?

@mikelupo I've invited you as a collaborator so as soon as you accept the invitation you should have the rights to add labels now 👍  (tbh I was surprised that I didn't invite you as an official collaborator on the repo before 😉 )

@AliSoftware  It's mutable now. I can add a label, but we don't currently have a WIP label. Shall I create one?

Oh yeah sure I think it will always be useful to have 👍


CB-8748 EnvironmentUser should be able to navigate the UI without err…

…or messages
See detailed description in the commit message.

http://ci-cloudbreak.eng.hortonworks.com/job/cloudbreak-real-ums-test/1008/


fix version bug

What problem does this PR solve?
fix version bug, from SHAPSHOT to SNAPSHOT

/run-all-tests

/run-all-tests

/merge


Updated winUI version in Settings.UI project

Summary of the Pull Request
What is this about?
Updated WinUI to the september pre-release released yesterday. Validated that the update fixes #6022
PR Checklist

[X] Applies to #6022
[X] CLA signed. If not, go over here and sign the CLA
[X] Tests added/passed

Info on Pull Request
What does this include?
Validation Steps Performed
How does someone test & validate?

@arjunbalgovind can you confirm with @crutkas before submitting that we want this for .23?

If tested I am ok


Revert "Merge pull request #5014 from alphagov/dependabot/npm_and_yar…

…n/nanoid…"
This reverts commit eac2bcb4f010f8803a4f9aca9c6434da7b5f5442, reversing changes made to 982b06da4fa67820d75e00cbb465a0f4915bcdd7.
Bumping the nanoid major version is causing the paas-admin tests to fail, so we're holding this until we get time to investigate it further: https://concourse.build.ci.cloudpipeline.digital/teams/main/pipelines/paas-admin/jobs/tag-releases/builds/2785

🚨⚠ Please do not merge this pull request via the GitHub UI ⚠🚨

Closing as the same test is failing on this revert branch, I think the issue is somewhere with the test and I will look into it


AIA Formatting_Results Page_1

Describe the bug - Décrivez le bogue
Results page
Section 1 - "On this page"
The sections that could be found on the page are listed, I would like them to be labelled appropriately.
To Reproduce - Pour reproduire
Steps to reproduce the behavior - Étape pour reproduire le comportement:

Complete an AIA
Navigate to the Results page
Scroll down to "On this page"

Expected behavior
Label the sections
Section 1: Impact Level Result
Section 2: Requirements Specific to Impact Level
Section 3: Mitigations Measures
Section 4: Questions and Answers
Subsection 4.1: Project Details
Subsection 4.2: Impact Questions and Answers
Subsection 4.3: Mitigation Questions and Answers

Hi @rimrk , I'm not clear what is being asked here. Are you asking for sections titles to be preceded with "Section #:", e.g. Section 1, Section 2, etc. ?

Hi @MrDeshaies yes! I am asking for a mini table of contents to the page.


Update test data

I created a new dataset called test_logic_NGS which merges the same patients from the old test_logic dataset with existing NGS data. Same number of patients and diagnoses, but I added new "normal" (non-tumor) samples for 2 of the patients, so now each of them has a tumor-control pair for the NGS data. One patient has only mutation (.maf) data, the other both mutation (.maf) and CNA (.seg).
I also renamed the clinical files to avoid the annoying PMCXXXXXX codes in the filename, and updated the configuration accordingly.
IMPORTANT QUESTION: do we need the files in config/cbioportal_db_info? I know these are needed for cBioportal to run without connecting to an outside database, but I wonder if this is the best place to store them (they only depend on the installed cBioportal version, not on the specific test dataset). I can update the pull request accordingly, or create a new one if it's better

Looks good. I think it is good to leave the cbioportal_db_info files here, because it enables us to test the entire pipeline.

OK, we'll leave them there then :)


ci: Add Acceptance tests to GitHub action workflow

Description

Adds the acceptance tests make testacc run to the workflow run in all
the commits and branches, but omitting the pull_request trigger due to
the GitHub Actions limitations on forks.
Motivation and Context

Run the acceptance tests in tests in GH Actions.

that's a good point, I actually had the trigger first to both Unit and Acceptance to run on both push and pull_request triggers but the Action secrets have a limitation which is described in https://github.com/elastic/terraform-provider-ec/settings/secrets.
Secrets are environment variables that are encrypted and only exposed to selected actions. Anyone with collaborator access to this repository can use these secrets in a workflow.

Secrets are not passed to workflows that are triggered by a pull request from a fork. Learn more.


(feat) Add options to hide term buffers and retry last target on failure

This PR introduces 3 new features:

Option to hide buffers from yeet.select_target entries.

New term buffer option can now be hidden from the yeet.select_target list.
I didn't create one option for tmux as entries are only shown when tmux is running.

Option to create a new tmux window (in the same session) in yeet.select_target

Currently yeet only allows to create tmux panes but no windows.

Option to retry last used target in case of failure. (ex. channel was closed)

I usually use tmux panes with yeet, but then I close the pane. So when I run yeet.execute I have to re-select again the same option to open a tmux pane.
Works with term buffers, tmux panes, tmux windows.

This is my first time contributing to an nvim plugin, so please let me know if I missed any guidelines. Also if needed, I can split this pull request into smaller ones.
Things to do:

~update readme.md~
~update docs (help file)~
Write tests

Thanks for the PR. I'm a little crowded at the moment, but will check it out some day.
I had pane/window creation for tmux as a config option at some point as a WIP. Didn't like it the way I did it and threw it to the void. Did not cross my mind to provide it as two separate entries...

This works, I will move some bits around after I get my own local ongoing stuff cleaned up to commits. Thanks for contributing!

And this is a great PR, there was zero confusion about what was the intentions. Splitting to separate prs per feature is of course cleaner, but these are concise changes and you have good commit hygiene with the messages, so it's fine.


Overwriting and customizing resolvers

Is it possible to overwrite and/or customize resolvers similar to what Amplify CLI allows (https://docs.amplify.aws/cli/graphql-transformer/resolvers) using this project? I did notice the @mapped directive but is that for a slightly different use case? The documentation for that directive was a bit sparse so my understanding can well be a bit off here 🙂

any updates on this? would love to to be able to overwrite or customize the resolvers that amplify CLI generates

Things have been really busy for me lately so apologies in getting back to this so late. Have an idea in the works for this.

This PR will add support for creating custom none resolvers. Next will be adding in support for overwriting
https://github.com/kcwinner/cdk-appsync-transformer/pull/284

Here is what I've done for overriding mapping templates. You can specify the request and/or response
https://github.com/kcwinner/cdk-appsync-transformer/pull/285


Improve example: metaclasses

Support more features
Refactor
Move to separate repo

see https://github.com/blockspacer/flex_typeclass_plugin


The last touch input pointer is never activated

Version

Phaser Version: 3.80.1 and earlier

Description
The Input Manager seems to use one fewer touch pointer than its pointersTotal.
Example Test Code
See https://codepen.io/samme/pen/VwdeZEL.
The game config has activePointers: 4. The Input Manager has 4 touch pointers (IDs 1 to 4). This is correct.
Put 4 fingertips on the game canvas. Only 3 touch pointers activate.

Nice find!
Thank you for submitting this issue. We have fixed this and the fix has been pushed to the master branch. It will be part of the next release. If you get time to build and test it for yourself we would appreciate that.


Consider other template engines

One of the reasons the migration from the old base16 repos was so painful was because of the language switch. This is largely due to using language-specific template languages.
How possible would it be to use something like mustache which is very simple and has good bindings for most languages? Are there any other template languages which would be a better fit?
This would make it possible to build tooling in other languages without relying on the builder staying the same. It would also go a long way to splitting templates out into a separate repo (or repos) so not all the templates need to be maintained in a monolithic repo.
This idea was born out of a frustration that some features of the old builder useful for package maintainers were removed. One of the nice things about the old builder was that it was easier to script- you could (as an example) tell it to generate all emacs templates. This could then be published in a new repo as a package for emacs. That is also (somewhat) a separate issue, but this was one of the simple ideas I came up with which might help deal with that, so when there are disagreements, the base16 ecosystem (if you can call it that) doesn't get fragmented further.

tl;dr: come talk in #126

One of the reasons the migration from the old base16 repos was so painful was because of the language switch. This is largely due to using language-specific template languages.

Agreed. The language-specific template language is hassle. Not quite a problem, but we want to improve this. We would love to share templates and schemes easily. We would love to see them purely language agnostic.

How possible would it be to use something like mustache which is very simple and has good bindings for most languages?

I never use Mustache. Can we run code in it? How its handle? The main problem with templating engine is to deal with template like smartftp:
<%- base["00"]["hex"].match(/.{2}/g).reverse().join('') %>

An alternative would be to move all the logic from here to the builder. It is pain the original project nor b16b took.

Are there any other template languages which would be a better fit?

@alexbooker started with nunjucks. He tried swig too. Finally, we move to ejs (Alex did all the job!). For reference see #67

One of the nice things about the old builder was that it was easier to script- you could (as an example) tell it to generate all emacs templates.

We talk a lot about this with Alex and we agreed that the builder MUST print to stdout to follow the unix way. The generation of a group of template wasn't abandoned, but we decide that it belongs to a separate project (schemer is the result of the same way of thinking).

Alright, I'll drop this in favor of #126.


install<EMAIL_ADDRESS>on mac.   doesn't work.

Following https://docs.starrocks.io/en-us/main/developers/development-environment/ide-setup
atwong@Alberts-MBP ~ % brew tap-new $USER/local-tap
brew extract --version='0.13.0' thrift $USER/local-tap
brew install<EMAIL_ADDRESS>Warning: tap-new is a developer command, so Homebrew's
developer mode has been automatically turned on.
To turn developer mode off, run:
  brew developer off

Initialized empty Git repository in /opt/homebrew/Library/Taps/atwong/homebrew-local-tap/.git/
[main (root-commit) 8ff3604] Create atwong/local-tap tap
 3 files changed, 90 insertions(+)
 create mode 100644 .github/workflows/publish.yml
 create mode 100644 .github/workflows/tests.yml
 create mode 100644 README.md
==> Created atwong/local-tap
/opt/homebrew/Library/Taps/atwong/homebrew-local-tap

When a pull request making changes to a formula (or formulae) becomes green
(all checks passed), then you can publish the built bottles.
To do so, label your PR as `pr-pull` and the workflow will be triggered.
==> Searching repository history
Error: Could not find thrift! The formula or version may not have existed.
Warning: No remote 'origin' in /opt/homebrew/Library/Taps/atwong/homebrew-local-tap, skipping update!
==> Auto-updated Homebrew!
==> Updated Homebrew from e37650d12 to 4.0.22 (9d01e1dea).
Running `brew update --auto-update`...
Updated 5 taps (weaveworks/tap, homebrew/cask-versions, minio/stable, homebrew/core and homebrew/cask).
==> New Formulae
core-lightning  git-tools       jsign           lowdown<EMAIL_ADDRESS>==> New Casks
apple-hewlett-packard-printer-drivers    mumu-x
devpod                                   rode-connect
grs-bluewallet

You have 14 outdated formulae and 2 outdated casks installed.

The 4.0.0 release notes are available on the Homebrew Blog:
  https://brew.sh/blog/4.0.0
The 4.0.22 changelog can be found at:
  https://github.com/Homebrew/brew/releases/tag/4.0.22
Warning: No available formula with the name<EMAIL_ADDRESS>Did you mean<EMAIL_ADDRESS>==> Searching for similarly named formulae and casks...
==> Formulae
<EMAIL_ADDRESS>
To install<EMAIL_ADDRESS>run:
  brew install<EMAIL_ADDRESS>atwong@Alberts-MBP ~ % thrift -version
zsh: command not found: thrift

Creating a new brew.  https://github.com/Homebrew/homebrew-core/pull/133476

Homebrew won't accept older versions of product.  I made my own homebrew at https://github.com/alberttwong/homebrew-thrift
brew install<EMAIL_ADDRESS>


Match class selects title and description when search filed is set only to title.

I would like to search only by title and use match-class to highlight but description field get also highlighted.
Code from precessResults function:
if (scope.matchClass) {
formattedText = findMatchString(text, str);
formattedDesc = findMatchString(description, str);
}
Solution would be to check search fields there:
if (scope.matchClass) {
for (s = 0; s < searchFields.length; s++) {
if (searchFields[s] === scope.titleField)
formattedText = findMatchString(text, str);
if (searchFields[s] === scope.descriptionField)
formattedDesc = findMatchString(description, str);
}
}

I guess the easiest solution would be to change your css like this
.angucomplete-description .highlight {
color: #000; // your default text color
}


Default values in Record don't work as expected

Hi everybody,
I'm using the most current ROC (build from Nix flake).
This should work:
something = \foo, { firstBar ? Both, secondBar } ->
    when firstBar is
        Start -> Str.concat secondBar foo
        End -> Str.concat foo secondBar
        Both ->
            foo
            |> something { firstBar: Start, secondBar }
            |> something { firstBar: End, secondBar }
expect
    x = something "aaa" { secondBar: "bbb" }
    x == "bbbaaabbb"

But it doesn't:
# This 2nd argument to something has an unexpected type:
#
# 30│      x = something "aaa" { secondBar: "bbb" }
#                              ^^^^^^^^^^^^^^^^^^^^
#
# The argument is a record of type:
#
#     { … }
#
# But something needs its 2nd argument to be:
#
#     { firstBar : [
#         Both,
#         End,
#         Start,
#     ], … }
#
# Tip: Looks like the firstBar field is missing.

Thank you.

Thanks for reporting this @rudolfvesely, I think this should work.
As a workaround you can add this type annotation to fix it:
something : Str, { firstBar ? [Both, End, Start], secondBar : Str } -> Str

Note for future investigator, this version does work:
something = \foo, { firstBar ? Both, secondBar } ->
    when firstBar is
        Start -> Str.concat secondBar foo
        End -> Str.concat foo secondBar
        Both ->
            Str.concat foo secondBar

expect
    x = something "aaa" { secondBar: "bbb" }
    x == "aaabbb"

something : Str, { firstBar ? [Both, End, Start], secondBar : Str } -> Str

Thank you @Anton-4 , that works:
something : Str, { firstBar ? [Both, End, Start], secondBar : Str } -> Str
something = \foo, { firstBar ? Both, secondBar } ->
    when firstBar is
        Start -> Str.concat secondBar foo
        End -> Str.concat foo secondBar
        Both ->
            foo
            |> something { firstBar: Start, secondBar }
            |> something { firstBar: End, secondBar }
expect
    x = something "aaa" { secondBar: "bbb" }
    x == "bbbaaabbb"

But this doesn't even with the signature:
something : Str, { firstBar ? [Both, End, Start], secondBar : Str } -> Str
something = \foo, takethis ->
    { firstBar ? Both, secondBar } = takethis
    when firstBar is
        Start -> Str.concat secondBar foo
        End -> Str.concat foo secondBar
        Both ->
            foo
            |> something { takethis & firstBar: Start }
            |> something { takethis & firstBar: End }
expect
    x = something "aaa" { secondBar: "bbb" }
    x == "bbbaaabbb"

# Something is off with this record update:
# 37│              |> something { takethis & firstBar: Start }
#                               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
#
# This takethis value is a:
#
#     { firstBar ? […], … }
#
# But this update needs it to be compatible with:
#
#     { firstBar : […], … }

Likely cause


Final energy demand per sector [%] scales to 1% instead of 100%

The 'Final energy demand per sector [%]' chart scales to 1% instead of to 100%. See screenshot below for a blank NL scenario:

The underlying queries are set as factors. The input should be adjusted so that they are recognised properly as percentages, which can be achieved by multiplying them with 100 - which is also done for similar charts, such as the renewability of final demand or renewable electricity.

The queries used in the 'Final energy demand per sector [%]' chart are also used as input for the percentage bars of the demand sidebar items.
Multiplying the queries with 100 therefore has the effect that the percentage bars of the demand sidebar items would be 100 times too large - even though the chart would be fixed.
The updated chart:

The resulting sidebar:

@antw would it be difficult for you to have the sidebar percentage bars register the input value as 100 times lower? If this is too much effort, I can simply create separate queries for this chart and not change anything else.

If this is already on a branch, I think you can change that here:
https://github.com/quintel/etmodel/blob/a600c0fa1fb068a6f6bf0ea85038c6db3f36d40a/app/assets/javascripts/lib/views/sidebar_view.coffee#L76
-      percentage = Math.round(result * 100)
+      percentage = Math.round(result)


feat: add changelog action

feat: add changelog action

LGTM, I took the liberty to fix two small issues that were causing the actions to fail 🙂


Render get account better than a JSON output.

@abourget open for help on this?  I'd think for a non-verbose printing, we could present the account data that is available on eostoolkit:
EOS ####.####    RAM #### unit used #### unit owned
CPU ####.#### EOS (###.##% used)    NET ####.#### EOS (###.##% used)    REFUNDING ####.#### EOS
(optional)
TOKENS ####.#### EOS, ####.#### {TOKEN} ...

The most precise output for that is cleos's.. if you want to implement something like that, it'd be great. Permissions in hierarchy, all the types of permissions on a line, with their weights..
the right format for units (the rounding on cleos is solid too, with significant number of decimals)... proper differences for staked and delegated bandwidths.
We could keep the --json output for refs and precision (precise rather than rounded numbers).
What do you think?

Sounds like the right idea, I will replicate what cleos pops out.
I think keeping the json makes sense, and if we want to support output
other formats (yaml?) later on that will be easy enough
On Wed, Aug 22, 2018, 2:09 AM Alexandre Bourget<EMAIL_ADDRESS>wrote:

The most precise output for that is cleos's.. if you want to implement
something like that, it'd be great. Permissions in hierarchy, all the types
of permissions on a line, with their weights..
the right format for units (the rounding on cleos is solid too, with
significant number of decimals)... proper differences for staked and
delegated bandwidths.
We could keep the --json output for refs and precision (precise rather
than rounded numbers).
What do you think?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/eoscanada/eosc/issues/12#issuecomment-414922513, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ADp5cwito_3YS_HjU1tqBmCK0peJ1Hmaks5uTPWWgaJpZM4WATq7
.

@abourget Going to leverage columnize since that's already in the project, you were the one that added it so I'm assuming you're happy with it :)

These are all just noted differences between the new output and what the json shows, not necessarily all important
-not noted if it's a privileged account or not
-doesn't display last_code_update (not sure when that is valuable though?
-does not display created timestamp
-displays things like RAM, and Net in KiB/MiB whereas most explorers use KB and MB (even eosquery does - so we're displaying two different things)
-doesn't display if there is a current refund request
-doesn't show any proxy info (whether it's regd as one, or if it's proxying to one)
-doesn't show vote weight (which I'd really like to see :slightly_smiling_face: )

@joshkauffman Thanks for the delta list... I agree that some things are missing/should be there, I just tried to replicate the formatting and information found in cleos.  @abourget I can add some of these items to #18 if it makes sense?

@joshkauffman regarding the KiB vs KB, both KiB and KB are 1024 bytes, versus kB being 1000 bytes.  Looking at eosquery I'm seeing that they use KB, which means we should be displaying the same numbers.  Are you seeing discrepancies?


Unit test "framework" is weak

There, I said it. :) It's much better than no tests, but we really should
be using SimpleTest.

Feeling out the server environment (e.g. ability to write files, detect
auto-compression) needs to be easier to run on first "install". Maybe /min/
setup/ could run a little suite.

For now it seems reasonable to require devs running units to have
SimpleTest be in the include_path, but maybe there's a way to link this in
with svn without adding it all to our repo.

Original issue reported on code.google.com by<EMAIL_ADDRESS>on 29 Jun 2009 at 2:03

If no cache path is set, the setup should sniff with Solar_Dir, test
read/write, and
suggest using that directory.

Original comment by<EMAIL_ADDRESS>on 9 Sep 2009 at 1:09


Strange clipping behaviour with Rainbow v 2.3.3 running on RackPro v 2.0.3b standalone

I have been testing Rainbow v2 for a while now and I have come across this strange clipping behavior.
I must tell that this issue does not happen every time I load the patch but sometimes( thats why I took a video of the issue happening )
So I have included a patch which replicates the problem. Just press run on the clock in the patch then you would see …..
I hope it helps
https://user-images.githubusercontent.com/96023496/146681637-4357e7be-7f1b-4170-8c3f-53f61996cd55.mov
Pollybow3.vcv.zip
Runing on Macbook Air M1 macosx 11.2.3 (20D91) VCV Rack v2.0.3b

Yeah I see what you mean. I stripped your patch down so it only includes what's necessary to produce the intermittent -1200v negative output on poly channel 4.
I'm using v2.3.3, which is in the library, can you update to this version and let me know if it's still occurs on your end. Thanks.
I'm bust next week so it may take some time to fix.

Hey Steve ,
I mislabelled the issue rainbow v2.3.2(I have edited it with the correct one )
Actually I am also using version 2.3.3
Sent from my iPhone

On 19 Dec 2021, at 18:36, Steve Russell @.***> wrote:

Yeah I see what you mean. I stripped your patch down so it only includes what's necessary to produce the intermittent -1200v negative output on poly channel 4.
I'm using v2.3.3, which is in the library, can you update to this version and let me know if it's still occurs on your end. Thanks.
I'm bust next week so it may take some time to fix.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.
You are receiving this because you authored the thread.

Here's a Mac test build, let me know how it sounds.
https://github.com/SteveRussell33/Prism/suites/4706253212/artifacts/128968800

https://user-images.githubusercontent.com/96023496/146690397-4e0f5203-a285-436b-a87f-f2e1cba4f440.mov
Unfortunately the bug still there ....

I don't get this bug on Windows any more. Are you sure you installed this correctly?

I just unzipped the file and dragged only
Prism-2.3.4-3a45dbe-mac.vcvplugin file into racks plugins folder( I did not
drag the Prism Folder )
in the video I have posted github Pollybow2.3.4.mov  you can see I touch
the info and the version of prism looks 2.3.4-3a45dbe I don't know if I
made a wrong install but as I mentioned before I am not a developer, so if
you tell me how to install correctly I would be happy checking the bug
again.
Sent from my iPhone
On 20 Dec 2021, at 02:08, Steve Russell @.***> wrote:

I don't get this bug on Windows any more. Are you sure you installed this
correctly?
—
Reply to this email directly, view it on GitHub
https://github.com/SteveRussell33/Prism/issues/6#issuecomment-997506467,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AW4THSBZ6FGHSH7V6DWNB4DURZ6ZHANCNFSM5KMAYG7Q
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you authored the thread.Message ID:
@.***>

I edited my comment as I saw that you had the correct version installed, so no worries there.
I still don't get why it doesn't work on your end, even a couple of testers here report the same thing:
https://community.vcvrack.com/t/prism-need-mac-linux-users-to-test-a-patch/15649

If you haven't already, please read the posts in the community thread, I can't reproduce this anymore, therefore I think the bug is elsewhere. It may be something to do with your patch.

Thanks Steve,
I have been following the thread on the community forum. It is great that the bug does not happen on windows but how ever as mentioned in the thread as well it still happens on mac
As you have mentioned Audio module might be causing the bug I have done some tests with v2.3.4 without the audio module in the patch (even I did not connect audio to the record module)
In my experience the bug still happens weather there is the audio module or not (check out the video)
https://user-images.githubusercontent.com/96023496/146820182-e58d46ea-e231-4250-9e1e-4b71cfbb8973.mov
cheers

Does it happen if you add the Audio module, select a device, exit Rack, then relaunch Rack so it loads the autosaved patch?
Or if you save the patch with an Audio module and device selected and reload the patch?
The effect only happens if the Audio module is not initialised properly, this is a bug in that module I believe. Others have picked up on this.

Hey Steve ,
I have done exactly what you have instructed and I can confirm that the bug does not happen after inserting audio module and picking a device ( still continues without quiting rack ) then relaunching rack with autosave....
Rack 2.0.4 is out now , I will keep testing with the new update as well
cheers

Hi,
Thanks for reporting that, I and others, after much testing, are of the opinion that there is a fault with the initialisation of the Audio module. Your patch is a really good example that picks that up, it's just that it happens to use the Rainbow module.
I'm happy that there's no bug in Rainbow so I'm going to close this issue. If you have any problems open another issue or if the same problem happens, maybe in some other way, I'll repopen this issue.
Have a good one!


Link to pretrained model

Hello, the link to the pretrained model "https://drive.google.com/drive/folders/1DVU8cIN3H_7P7EMtxzeOB5BdHxUmJUd9?usp=sharing" isn't working, can you provide another link?

Hello, we are still working on this project. Unfortunately, this repository has a very old version of the model and we do not have the pretrained model anymore. We will update this repository later on. Sorry for the inconvenience.


allowed caller to select servicetype

in order to make use of Cupra-Connect-Services

this should allow an optional selection of the target service, as it isn't possible to authenticate with the default VW weconnect  API using an cupra-accoutn


Implement protection against XSS attacks

Jodit Version:  3.4.xxxxx
Browser:  Chrome
OS:  Windows
Is React App:  True
Code
When embedding the script in WYSIWYG, it will work fine when you click on the preview
In my implementation, I did a great job by removing the

Just deny script tag https://xdsoft.net/jodit/docs/classes/config.Config.html#cleanHTML
Jodit.make('#editor', {
   cleanHTML: {
        denyTags: 'script,img'
   }
})


Small issue: CognitoEventUserPoolsMigrateUser request/response fields are not named

Other Cognito event structs look like:
type CognitoEventUserPoolsPostAuthentication struct {
	CognitoEventUserPoolsHeader
	Request  CognitoEventUserPoolsPostAuthenticationRequest  `json:"request"`
	Response CognitoEventUserPoolsPostAuthenticationResponse `json:"response"`
}

But CognitoEventUserPoolsMigrateUser is defined as:
type CognitoEventUserPoolsMigrateUser struct {
	CognitoEventUserPoolsHeader
	CognitoEventUserPoolsMigrateUserRequest  `json:"request"`
	CognitoEventUserPoolsMigrateUserResponse `json:"response"`
}

So instead of event.Response.UserAttributes you have to do either event.UserAttributes or event.CognitoEventUserPoolsMigrateUserResponse.UserAttributes which both look a bit weird to me and is a bit inconsistent with the other event definitions?
Is this intentional or just a miss?
My suggestion is to change the definition to:
type CognitoEventUserPoolsMigrateUser struct {
	CognitoEventUserPoolsHeader
	Request CognitoEventUserPoolsMigrateUserRequest  `json:"request"`
	Response CognitoEventUserPoolsMigrateUserResponse `json:"response"`
}

Encountered this recently, hopefully the aws team modifies this it was rather confusing...


Add GitHub and Heroku guidnace

https://github.com/nhsuk/nhsapp-frontend/issues/201

First draft

We probably need to reference this page on the prototyping page?

Users who have tried adding a repo to the NHS Digital org have faced these problems (which we could mention in the guidance):

Navigating to your prototype in the terminal
Creating a personal access token (classic)


[Docs]: update CLI final screen summary screenshot for nicer ones

What type of suggestions?
Missing Information
What page is concerned?
No response
What is the issue?
Update CLI final screen summary screenshots for ones without the black box for nicer visual (I can change them without sensitive data).
Code of Conduct

[X] I agree to follow this project's Code of Conduct

done


Error on docker image unable to initialize embedded filesystem

Hello,
When i run docker run -p 3000:3000 slashbaseide/slashbase
I have an error and the container stops
Running Slashbase IDE at http://localhost:3000
Type 'help' for more info on cli.
2022/12/23 02:13:50 unable to initialize embedded filesystem: no ID found in the file
2022/12/23 02:13:50 using local filesystem for static assets
slashbase >

Thanks for pointing this issue out. The docker image is fixed. Please try again now. It should work.
I'm closing this issue.


Logout Dialog customization

Hi,
one of the ToriOS testers has said (on multiple occasions) that the logout dialog saying 'Exit JWM' is confusing, since we are building an OS using JWM, rather than one called JWM :)
Would it be easy to implement a way to customize this?
I am thinking something like:
<Exit label="Logout" confirm="true" message="Logout?" icon="system-logout.svg"/>

I know I could disable confirmation, but that is also problematic...  Or I could make my own script and run jwm -exit.
If you think this is too much of a fringe use case I will simply make my own dialog as a wrapper.

I like to put the exit command under its own sub menu:
<RootMenu>
  <!-- other stuff here -->
  <Menu label="Exit">
    <Exit label="Exit" confirm="false"/>
  </Menu>
</RootMenu>

That way, the user has to click both exit labels (or press right-arrow; enter) in order to exit.
So it's basically a little added safety, but without the confirmation dialog.

@yetanothergeek that is a good point.
I'll bring that up and see what they think!

Sounds reasonable.  I was thinking it might also be nice to allow using the dialog for other things, such as messages from a script, etc.

That is exciting sounding!!
I am already thinking of ways I could use that!
Shutdown & Reboot dialog
Notifications
there are so many more possibilities!!!

Also one could use oblogout which enables icon themes and shows buttons like suspend, hibernate and so on. Use jwm --exit as exit command.

I have this for system shutdown/restart. I use a right click menu for favourite apps, left click menu for system  settings, middle click desktops.
<RootMenu  height="20" onroot="1">
<!-- entries -->
	 <Restart icon="/home/adrian/bin/pixmaps/blue.png" label="restart jwm" />
<Menu icon="/home/adrian/bin/pixmaps/marker1.png"  label="Exit">
	 <Exit icon="~/bin/pixmaps/marker2.png" label="Logout" confirm="false" />
        <Program icon="/home/adrian/bin/pixmaps/marker2.png" label="Restart">dbus-send --system --print-reply --dest="org.freedesktop.ConsoleKit" /org/freedesktop/ConsoleKit/Manager org.freedesktop.ConsoleKit.Manager.Restart</Program>
      <Program icon="/home/adrian/bin/pixmaps/marker-exit.png" label="Shutdown">dbus-send --system --print-reply --dest="org.freedesktop.ConsoleKit" /org/freedesktop/ConsoleKit/Manager org.freedesktop.ConsoleKit.Manager.Stop</Program>
</Menu>


Add: OBS Gyeongin TV

Channel Name
OBS Gyeongin TV
Alternative Names (optional)
OBS경인TV
Network (optional)
No response
Owners (optional)
No response
Country
KR
Subdivision (optional)
No response
City (optional)
Bucheon
Broadcast Area
c/KR
Languages
kor
Categories (optional)
general
NSFW
FALSE
Launched (optional)
No response
Closed (optional)
No response
Replaced By (optional)
No response
Website (optional)
about:blank
Logo
https://www.obsnews.co.kr/image/logo/snslogo_20210106043927.png
Notes
No response

Already in the database: https://iptv-org.github.io/channels/kr/HLQSDTV


Update parallel for Jupyter notebooks in maskfactory

New update to ipython moved IPython.parallel to ipyparallel: https://github.com/ipython/ipyparallel

Please change to ensure backwards compatibility.


Revert "bump version"

Reverts maidsafe/crust#264

r? @inetic
(maidsafe_highfive has picked a reviewer for you, use r? to override)

attempt reopen


Questions about the Indigo service

From the docs, it seems like Ketcher 2.0 requires a running service. However, the download link leads nowhere. Also, the "download ketcher" link on your website doesn't provide this service, yet the source seems to indicate that such a service is needed.
So my questions concerning the service are:

Does Ketcher 2.0 still require a service?
Can I access the source, or is it only available as standalone Docker package?

Thanks!

Dear @Doidel,
Thank  you so much for your questions and your interest in Kecher.
The list of features provided by Ketcher can  be found by the link. Unfortunately, some of them are required a running indigo service as you mentioned above. The link to  Indigo API can be provided as an additional  query parameter, for example: ...?api_path={link-to-indigo-service}.
As we received multiple requests about providing Ketcher as a standalone solution we have already include it into  our roadmap. Please follow us and you will  see it in the one of the upcoming releases.
Regarding your second question, please find the link to  Indigo Service repository bellow:
GitHub repository
Please contact us if you  have any additional questions.
Best regards,
Ketcher development team

Got it, thanks for all the info!


fix(deps): update icr.io/ext/logdna-agent docker tag to v3.8.7-20230911.d56198292a9583c4

This PR contains the following updates:

Package
Update
Change

icr.io/ext/logdna-agent
patch
3.8.6-20230710.4ca2845bb7441ee4 -> 3.8.7-20230911.d56198292a9583c4

Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.

[ ] If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

Edited/Blocked Notification
Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.
You can manually request rebase by checking the rebase/retry box above.
⚠ Warning: custom changes will be lost.

/run pipeline

/run pipeline

:tada: This PR is included in version 1.7.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Add JuMP extension

This extends JuMP and allows a user in JuMP to differentiate an external function using Enzyme. I still should reduce the allocations. Feedback is very welcome.
Use case:
using Ipopt
using JuMP
using Enzyme

# Rosenbrock
rosenbrock(x...) = (1 - x[1])^2 + 100 * (x[2] - x[1]^2)^2

model = Model(Ipopt.Optimizer)
op_rosenbrock =  model[:op_rosenbrock] = add_nonlinear_operator(model, 2, rosenbrock; name=:op_rosenbrock)
@variable(model, x[1:2])

@objective(model, Min, op_rosenbrock(x[1],x[2]))

optimize!(model)

Since we're using the memory, I added the batched mode to get the Hessian in one go.

This should be closed. We're discussing it over in https://github.com/jump-dev/JuMP.jl/pull/3712.


standalone kafkareader no print

hi, chris, this time i run a standalone kafkareader connecting to a remote kafka cluster. no error reported, but no print after i put into messages into the "test" topic by kafka-console-consumer.sh. i changed the %x to %s, still no print.

package main
import (
"flag"
"path/filepath"
"strings"
"os"
"github.com/chrislusf/gleam/flow"
"github.com/chrislusf/gleam/gio"
"github.com/chrislusf/gleam/plugins/kafka"
)
var (
brokers = flag.String("brokers", "beta-hbase02:9092,beta-hbase03:9092,beta-hbase04:9092", "a list of comma separated broker:port")
topic   = flag.String("topic", "test", "the topic name")
group   = flag.String("group", filepath.Base(os.Args[0]), "the consumer group name")
timeout = flag.Int("timeout", 30, "the number of seconds for timeout connections")
)
func main() {
gio.Init()
flag.Parse()

brokerList := strings.Split(*brokers, ",")

k := kafka.New(brokerList, *topic, *group)
k.TimeoutSeconds = *timeout

f := flow.New("kafka " + *topic).Read(k).Printlnf("%x")

f.Run()

}

k is like this:

k = {*github.com/chrislusf/gleam/plugins/kafka.KafkaSource | 0xc0000dc7d0}
Brokers = {[]string} len:3, cap:3
0 = {string} "beta-hbase02:9092"
1 = {string} "beta-hbase03:9092"
2 = {string} "beta-hbase04:9092"
Group = {string} "___go_build_gocrawler_gleamtest_standalone_kafkareader"
Topic = {string} "test"
TimeoutSeconds = {int} 16
prefix = {string} "test"

try to add some actual work between read and println.

added a Map between read and println, still no print, debug with break point set in the 1st line of capitalize, no stop after new msgs sent into the topic.

Capitalize  = gio.RegisterMapper(capitalize)

)
func main() {
gio.Init()
flag.Parse()

brokerList := strings.Split(*brokers, ",")

k := kafka.New(brokerList, *topic, *group)
k.TimeoutSeconds = *timeout

f := flow.New("kafka " + *topic).Read(k).Map("capitalize", Capitalize).Printlnf("%x")

f.Run()

}
func capitalize(row []interface{}) error {
line := gio.ToString(row[0])
gio.Emit(strings.ToUpper(line))
return nil
}

i tried connect to a not existing topic, the topic appear after gleam app is started, but nothing active detected in the gleam app, here is the summary after app is stopped:

step:testgleam.list0
output : d0
shard:0 time:306.505µs completed 285
step:testgleam.Read.Map1
input  : d0
shard:0 time:306.505µs completed 285
output : d1
shard:0 time:1m16.258485573s processed 0
step:capitalize.Map2
input  : d1
shard:0 time:1m16.258495764s processed 0
output : d2
shard:0 time:1m16.258422547s processed 0

BTW, default partition num in the remote kafka cluster is 12

hi, chris, i am from China Shenzhen, highly interested to adopt gleam as replacement of flink for simple but performance greedy streaming app. my number is<PHONE_NUMBER>8(both mobile and weixin), can we communicate via mobile or weixin directly?

qq:179351273

or if there is a QQ group for gleam discussion, pls. share the id

connect to some real kafka topic. There are some buffers. If not much traffic, the data are buffered.

great! after connect to a real topic in production, it is working now. how to control the buffer, i would like each new msg is dealt by the Map ASAP without buffering.


Whats the best way to mutate request and response?

its not clear from the docs or readme whats the best way to mutate response in response_handler. can someone please guide me or add this in README. thanks

@tanweerdev it depends on what your API is using and what compatibility issue the gate should fix.
For example, if you had just name parameter and then started using first_name and last_name then the gate should map those back. In request gate, you want to read conn params and change them so that:

add something like [first_name, last_name] = String.split(name, " ") and then write that to first_name and last_name and then write that back to conn.
remove old field name;

For the response gate you would match on connection routes and for those that are returning first_name and last_name separately you would take response body, decode it, do reverse operation (create new name = first_name <> " " <> last_name) and write it back to response body.
It's very hard to give you anything better than very abstract ideas because every gate is unique.


Add fast, persistent scratch space on a per user basis

There is often a need for a fast, persistent scratch space when working with and compiling large projects (such as Pytorch). At the moment, users can add an ephemeral scratch space per user by modifying one of the profiles in the profile section of the nebari-config.yaml (this might also require adding a fast custom storage space using the helm_extension):

Example of modified `profile`
  - display_name: Medium Instance
    description: Stable environment with 4 cpu / 16 GB ram
    kubespawner_override:
      cpu_limit: 4
      cpu_guarantee: 3
      mem_limit: 16G
      mem_guarantee: 10G
      extra_pod_config:
        volumes:
        - name: scratch-volume
          ephemeral:
            volumeClaimTemplate:
              spec:
                accessModes: [ "ReadWriteOnce" ]
                # defined in local helm chart: custom-premium-sc
                storageClassName: "premium-rwo-immediate"
                resources:
                  requests:
                    storage: 200Gi
      extra_container_config:
        - name: "scratch-volume"
          mountPath: "/scratch"

I am opening this issue to explore other possible options.

Implement the solution that is being discussed in #1549

This would mean realigning with Z2JH and giving each user who launches a JupyterLab server their own persistent storage volume (as detailed in this comment). The size and type of storage volume attached is something that we could allow Nebari administrators to set in their nebari-config.yaml.
Pros:

Aligns with Z2JH - folks coming from vanilla JupyterHub might be more familiar with this setup
Users don't have to worry about one user taking up all of the space in the single storage volume (which is currently a possibility).

Cons:

This would likely increase the cost of running a cluster as each user would have their own storage volume and if there are infrequent users, you would still be paying for their storage volume.

Create a special user group (with an associated server profile) that includes an scratch persistent volume.

This solution is a compromise between what we currently have and the solution proposed above (1.).
Pros:

Depending on the number of users in this new group and the size/type of storage attached, this might not be that much more of an additional cost. That said, as the number of users in this group increases and the size of storage volume increases, the potential cost savings would quickly evaporate.

Cons:

In order to limit which users can launch this specific type of server profile, we might also need to invest some development effort in making sure these profiles are visible to other users.

Set up a new server profile per user and attach whichever additional storage each of those users might need.

As far as I am aware, this solution does not require any additional development and only requires bespoke modification to the nebari-config.yaml (similar to the example of the attached ephemeral storage above).
Pros:

No Nebari development is required.

Cons:

This solution is only tenable for small groups of users (under 10). As the number of users increases, the harder it will be to manage the large list of server profiles.
Users will need to be sure to launch their own server profile otherwise they would be attached to their colleague's scratch space.

(2) sound difficult since you cannot have a scratch persistent volume that is shared (requires nfs and will be slow). Basically I don't think this approach will work at all.
(3) absolutely a zero development required approach
(1) to me sounds like the most correct option. Also opens up the ability to have certain users use this feature with others using the shared storage.
I'm in favor of (1) and I don't think it is too much development. I do think that it does make backups more difficult.

As a quick way to add persistent, per user PVCs, you can add the following the kubespawner_override section of a profile:
profiles:
  jupyterlab:
  - display_name: Small Instance
    description: Stable environment with 2 cpu / 8 GB ram
    kubespawner_override:
       ...
      storage_pvc_ensure: true
      storage_class: premium-rwo-immediate # custom storageClass with `volumeBindingMode: Immediate`
      storage_capacity: 200Gi
      extra_pod_config:
        volumes:
        - name: persistent-scratch
          persistent_volume_claim:
          claim-name: "{username}-scratch-pvc"
      extra_container_config:
        volumeMounts:
        - name: persistent-scratch
          mountPath: "/scratch"


Update fs2-core, fs2-io to 3.1.0

Updates

co.fs2:fs2-core
co.fs2:fs2-io

from 2.5.9 to 3.1.0.
GitHub Release Notes - Changelog - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "co.fs2" } ]

labels: library-update, semver-major

Superseded by #244.


CHANGELOG: add release notes for 0.1.0

This PR introduces a CHANGELOG file. Also added the notes that went to the 0.1.0 release.

An opinion: we should just close it. If we want to follow Habitat's change log, then you can notice that it does not have an entry for the first released version. Which makes sense, because there is no previous release on top of which the current release has improvements. So let's add the CHANGELOG when we actually release 0.2.0.

@krnowak Agree with that. Closing. 👍


[N05] Improper use of solhint-disable

solhint-disable will disable a feature of solhint until it is re-enabled with solhint-enable
or until the end of the file. Using solhint-disable with an unmatched solhint-enable
creates code that is prone to errors when updating it in the future.
In PR #9041, both the ExchangeBRLProxy and StableTokenBRLProxy contracts use solhint- disable without a following solhint-enable. Consider matching each instance of
solhint-disable with solhint-enable or instead use solhint-disable-next-line to
ensure clean, developer friendly code.

Agreed that solhint-disable-next-line would be better. That said, the current risk of these unmatched solhint-disableds causing problems is minimal - these contracts exist solely to create new named proxies, and are meant to have exactly the code of the original Proxy contract, so they inherit from it and add nothing new, and we don't expect ever modifying them to add anything new.
As this same issue appears in many other *Proxy contracts throughout the code base, most of which were not in scope for this audit, for consistency we will leave this unfixed for now, but added #9272 to fix this for all Proxies in the near future.


Funder loses payment if Keep creation fails

If a signing group fails to be established, payment for the keep is not returned even though one could assume that the signing group tried to play unfairly. The signing group might intentionally try to cause this scenario to interfere with the system.

[ ] ensure that a keep group is always established or otherwise the funder is refunded the fee for the keep

One possible option is to seize signer bonds after the timeout, return payment to the customer from seized bonds and then return partial signer bonds to signers.

@pdyraga If the keep creation fails we should get a TX revert.
What might fails is the signer setup and return of the pub key.
At any time after createNewKeep is called we can seise Signer bonds, right?

@pdyraga If the keep creation fails we should get a TX revert.

Yes, this is how it works.

What might fails is the signer setup and return of the pub key.

Yes, key is submitted once generated and there is a fixed timeout for that

At any time after createNewKeep is called we can seise Signer bonds, right?

Yes. Any time after creating new keep and before closing it or seizing bonds (seizing bonds closes keep).


i get bug error, which means i won't see my favorite game models...

Game name: (Yarisci Arazi)
Engine version: 2.5.0a0
Platform: StandaloneWinPlayer
File name: unity default resources
Error message: Error during reading of asset type Mesh
Inner message: System.OverflowException: Array dimensions exceeded supported range.
at uTinyRipper.AssetReader.ReadAssetArrayT
at uTinyRipper.Classes.Mesh.Read(AssetReader reader)
at uTinyRipper.SerializedFile.ReadAsset(AssetReader reader, AssetInfo assetInfo, Int64 offset, Int32 size)
Stack trace:    at uTinyRipper.SerializedFile.ReadAsset(AssetReader reader, AssetInfo assetInfo, Int64 offset, Int32 size)
at uTinyRipper.SerializedFile.ReadAsset(AssetReader reader, ObjectInfo& info)
at uTinyRipper.SerializedFile.ReadData(Stream stream)
at uTinyRipper.GameProcessorContext.ReadFile(SerializedFile file)
at uTinyRipper.GameProcessorContext.ReadFile(SerializedFile file)
at uTinyRipper.GameProcessorContext.ReadFile(SerializedFile file)
at uTinyRipper.GameProcessorContext.ReadSerializedFiles()
at uTinyRipper.GameStructureProcessor.ProcessSchemes(GameCollection fileCollection)
at uTinyRipper.GameStructure.Load(List1 pathes, LayoutInfo layinfo)    at uTinyRipper.GameStructure.Load(IEnumerable1 pathes, LayoutInfo layinfo)
at uTinyRipperGUI.MainWindow.LoadFiles(Object data)

Hello
uTinyRipper has been abandoned, but AssetRipper is actively being developed with the intent to recover Unity games as best as possible. I encourage you to help out if you're able and willing. Code contributions can be submitted via pull requests.
Development Progress
These are some of the notable things I've implemented since taking over development.

2020 - 6 support
APK, XAPK, and IPA reading with SharpZipLib
Dummy shaders (so everything isn't pink when you open the project)
IL2Cpp support via an integration of Cpp2IL
Better game platform support
Full script decompilation with the ILSpy decompiler
Cross-platform support
Multiple configuration options
Numerous performance improvements
Support for all asset types
Lightmap Recovery
High-quality 3D model export with SharpGltf
Prefab Outlining
Hybrid Script Export

This is not (at all) a comprehensive list. There are so many other things that could not be included here. They have all been made possible with the support of my generous sponsors.
Future Plans
This is a list of notable improvements planned for the future.

Mesh preview
Scene preview
Child State Machines
Dynamic Zip File Loading
Primary Content Extraction

Sponsorship
If you like the work I've done and want to see it continue, please consider sponsoring me. It really helps with development, more than you know.

GitHub Sponsors
Patreon
Paypal

A Patreon subscription gives access to AssetRipper Premium, which has additional features:

Static Mesh Separation
Asset Deduplication
User Defined Package Export


direct reply when using the reply

Instead of just replying with a username, why not make this more useful for quieting slack down a bit.
Seems like the reply method is more of a holdover from chat clients w/o the DM functionality. send and reply are almost identical otherwise. Is this useful to anyone else? Open to other suggestions on how to make this happen.

Is the idea here that if I do something that ends up triggering msg.reply somewhere I will get a DM instead of an @evan wherever the original message was sent?
I think that seems a bit weird since I can already DM the bot if I want it to reply via DM.

That is the desired behavior in this PR. The idea is to mimic some of what the built-in Slackbot does by replying in a user-only visible way, giving us the ability to hide actions needing to be taken by the requesting user. OAuth is a good example of this kind of action. Checkout the google hangout integration and how it works. This kind of behavior would allow us to mimic some of that in Hubot-backed robots.

I don't think we're going to merge this as is. In almost all cases people expect a reply to go back to the same channel as the original message. In the cases where you'd like to reply directly to the user that's still possible (although it will need some work in the script).
And, there's nothing stopping you applying this patch to your hubot yourself if you'd like it work this way in your team (yay for open source!)
If I'm missing a reason for this to be the default case please let me know!

The official hubot documentation states:
"With it, you can send a message back to the room the res came from, emote a message to a room (If the given adapter supports it), or reply to the person that sent the message."
This indicates that reply should reply to the PERSON, not the channel. The script I'm working on will respond with sensitive information that other participants in the channel shouldn't see. Ideally, these would come as "whispers" (ala IRC or slack's slash -command api); messages in the channel that only the user can see. But since it seems slack doesn't support this, a dm would be most appropriate. ... I'm still trying to figure out how to send a dm, but the Hubot documentation indicates to me that reply is supposed to.


Alpha/Opacity in Rofi

Is there any way to pass alpha settings to Rofi due to it's '--opacity' capability being removed?
Rofi currently relies on argb for alpha and I'd like to work out how to do this whilst running wal

This would need to be implemented in wal.

This will be possible once https://github.com/dylanaraps/pywal/pull/142 is merged. You'll be able to define your own rofi variables by overwriting the default template file.

This will be really easy in the next pywal version as pywal now supports user templates.
Example:

Make a file called colors-rofi.Xresources in ~/.config/wal/templates.
Set the Xresources for rofi to your liking.

You can use wal color variables.

Run wal
wal will use your new file instead of the built-in one.

Example File with opacity:
#define BG #CC{background.strip}
#define HI #CC{color1.strip}
#define FG {color15}
#define TX {color15}

! State:           bg, fg, bg2,  hlbg, hlfg
rofi.color-normal: BG, FG, BG,   HI,   TX
rofi.color-active: BG, FG, BG,   HI,   TX
rofi.color-urgent: BG, HI, BG,   HI,   FG
rofi.color-window: BG, BG, BG


Repository fails to build following instructions

I'm submitting a ...  (check one with "x")
[X] bug report => search github for a similar issue or PR before submitting
[ ] feature request
[ ] support request => Please do not submit support request here

Current behavior
Trying to build the repository, I run into a problem with webpack:
><EMAIL_ADDRESS>start /Users/achimha/Downloads/ngx-datatable
> webpack-dev-server

Invalid configuration object. Webpack has been initialised using a configuration object that does not match the API schema.
 - configuration.module.rules[2].loaders should be one of these:
   non-empty string | function | object { loader?, options?, query? } | function | [non-empty string | function | object { loader?, options?, query? }]
   Details:

Is this because you're expecting a certain version of webpack? Opening this as a bug because I believe a git clone followed by npm init should work on a pristine system.
Expected behavior

Reproduction of the problem
git clone https://github.com/swimlane/ngx-datatable
cd ngx-datatable
npm init
npm start

Please tell us about your environment:
OS X 10.12
NPM fetches webpack 2.2.0 and webpack-dev-server 2.2.0.

Table version: 0.7.x
6.0.0

Angular version: 2.0.x
2.4.5

Browser: [all | Chrome XX | Firefox XX | IE XX | Safari XX | Mobile Chrome XX | Android X.X Web Browser | iOS XX Safari | iOS XX UIWebView | iOS XX WKWebView ]
all

Language: [all | TypeScript X.X | ES6/7 | ES5]

I faced same error today.

Fixed.

Sorry to turn this into a support ticket. With the latest code the text extract plugin doesn't cause the failure but it still fails to build, with the scss files. I suppose the webpack rules are not correct there.
ERROR in ./src/themes/material.scss
Module build failed: Error
    at /foo/ngx-datatable/node_modules/webpack/lib/NormalModule.js:141:35

The error occurs for all scss files.

delete all the node_modules and reinstall.

True, thank you!


METRON-412 Limit Profiler to Numeric Types Via Type System

METRON-412
A ProfileMeasurement value must now be a Number not just any Object.  This more accurately reflects the requirements of a value, which must be numeric.  This was previously only checked at run-time, but with these changes it is now enforced at compile-time.
In addition, changed the Serializer from a simple container of two static methods, to an "interface plus implementation" that can be optionally swapped-out with a different implementation, should that be needed.  I imagine that someone may want to support BigInteger or something else like that in the future.
Depends on existing pull requests.

[ ] #242

Opened METRON-415 in lieu of this PR.  This will provide greater flexibility for users of the Profiler.


How can you move a PiVPN installation to a new machine?

I have PiVPN installed on a odroid SBC unit, and I want to install PiVPN on a new RPI unit but use all of the current certificates and settings I have.  What would the process be to install PiVPN on the new unit and what files would I need to copy over?

Just SCP your entire /etc/openvpn folder to the new Pi after setting up PiVPN

ok, I do this. But "pivpn -l" return only the server ...

Did you copy all of the sub directories as well?

Closing this as there is already an issue opened for this and we might implement a backup script.
#179
for further  discussion take it to subreddit.
https://www.reddit.com/r/pivpn/


Remove .script! hack

This replaces #1786, which removes the .script! hack that was used for extension-less executable files. We now detect shebang before looking at the filename, so this is not necessary.
/cc @arfon @pchaigno

:+1:


docker/build.sh fails if UID is not 1000

On a system when UID is not 1000 (i.e. a second user was created and that account was used to run build), the build will fail.
Run docker/build.sh and you will get the following error
ERROR: Could not install packages due to an EnvironmentError: [Errno 13] Permission denied: '/.local'
Check the permissions.

To workaround the problem, modify tools/model_downloader/model_downloader.sh so that user is root
$SOURCE_DIR/docker/run.sh --user root ...

Fixed in v0.6.0-beta


Cap scaling increase/decrease by X% of existing parallelism

While testing I almost increased parallelism by an order of magnitude more than intended when I had a typo in my command. We should put some guardrails in place to limit just how much we can scale in one shot.
Relates to #1292.

Hi @billonahill,
This feature is very interesting. Actually I have done something similar thing on Apache Storm, to adjust the parallelism of a bolt according to its instantaneous workload. If you are interested, we may have discussion for more details.
Thanks.

@wangli1426 this ticket is related to a user manually issuing a parallelism change using the heron update command. Are you referring to auto-scaling functionality, where component parallelism is dynamically adjusted based on current load? I'd be interested in learning the approach used to algorithmically determine that a component should be scaled up or down. This is something we plan to tackle.

Hi @billonahill,
Yes, I was referring to the auto-scaling functionalities, which consists of two parts: (1) the mechanism achieving scaling operators and (2) the algorithm to determine the optimal parallelism of the operators.
For (1), to support scaling of stateful operators, we model the operator state as key-value pairs. And the scaling is done by re-partitioning the operator state. I will send you our paper about run-time operator scaling if you are interested. I am wondering how you plan to deal with operator state when scaling up or down. Will you store the operator state to a persistent store before scaling? Will you consider live scaling without deactivating the current topology?
For (2), we have a paper that utilizes the Query Theory to determine the optimal parallelism of each operator given the user-defined tuple processing latency constraint. The first step of the algorithm is to reason about the minimal parallelism of each operator to avoid being the performance bottleneck. This is can be easily computed by $\lambda/u$, where $\lambda$ and $u$ is the arrival rate and the operator currently processing rate respectively.
I have implemented the auto-scaling functionality based on Storm. And I am willing to make contributions to Heron on this feature.
Thanks.
Li

@wangli1426 - this is definitely interesting. @billonahill and @avflor - can you please take a look at this proposal?

@kramasamy Sure, I can definitely read the paper an provide feedback.
@wangli1426 Thanks for pointing us to the paper.

@avflor You are welcome.

Thanks @wangli1426. For (1) we currently do not provide guarantees about local state during scaling events. This is something we'd like to tackle though as a general effort to provide stateful durability. It would be useful during scaling but also during routine failures.
For (2) we'll certainly check out that paper. Let's move further discussion on that topic to #1389, which tracks the auto-scalding algorithmic work.

Hi @billonahill @kramasamy @avflor,
I proposed a new operator for live scaling in #1499, please review.
Thanks.


sumneko_lua is deprecated, use lua_ls instead

After updating plugins today (PackerSync) I get the following error when I launch neovim:
sumneko_lua is deprecated, use lua_ls instead. See :h deprecated
This function will be removed in lspconfig version 0.2.0
stack traceback:
        .../site/pack/packer/start/nvim-lspconfig/lua/lspconfig.lua:41: in function '__index'

However, a simple renaming of sumneko_lua to lua_ls in my init.lua did not do the trick
lua_ls = {
  Lua = {
    workspace = { checkThirdParty = false },
    telemetry = { enable = false },
  },
},

This now results in
[mason-lspconfig.nvim] Server "lua_ls" is not a valid entry in ensure_installed. Make sure to only provide lspconfig server names.

Mason lists lua-language-server as installed.
This would seem to be related to this renaming.
The renamed repo links here for install instructions, but I'm not sure why I'm supposed to do a full brew install here, since I didn't use brew to set up the LSP under the old name.
Is this an issue with things being slightly out of sync, since this rename just popped up in the nightlies?
At this point, I've uninstalled lua-language-server in Mason and commented out the above block in init.lua to make the error go away.
I'm on macOS, NVIM v0.8.3.

Maybe I need to wait for this mason-lspconfig PR?

I think I just need to wait for this mason-lspconfig PR?

Yes, now we just need to wait it

My biggest pet peeve with nvim configs currently is that I don't know how to pin versions (upgrade/rollback command) and avoid these deprecation warnings (ignore command). Is there a way to manage this comfortably or are you stopping your day to day work to fix these warnings yourself, as a vim user? This would be a deal-breaker for me if I constantly get disturbed by randomly appearing warnings/deprecations and I have to fiddle around my config.

My biggest pet peeve with nvim configs currently is that I don't know how to pin versions (upgrade/rollback command) and avoid these deprecation warnings (ignore command). I've tried to remove this warning now for an hour straight without success. Is there a way to manage this comfortably or are you stopping your day to day work to fix these warnings yourself, as a vim user? This would be a deal-breaker for me if I constantly get disturbed by randomly appearing warnings/deprecations and I have to fiddle around my config.

pin version, this feature should be provided by your packag manager

If it helps, in my case, I ran into this issue due to PackerSync updating to at least one nightly. Not sure where it defaults to nightlies (I'm running pretty much the default init.lua from this repo still) and this might be an edge case where this kind of aggressive nightlies would not have otherwise triggered an out of sync update so quickly.
I had gotten some kind of 'plugin table is nil' error when running PackerStatus and stumbled across  PackerSync which did fix the nil error.

I've tried to remove this warning now for an hour straight without success. Is there a way to manage this comfortably or are you stopping your day to day work to fix these warnings yourself, as a vim user?

If you're referring to this specific sumneko_lua is deprecated warning, I commented out the sumneko_lua block. under local servers = { in init.lua and then also ran :Mason in vim and under the LSP list, went to the line with lua-language-server and hit X to uninstall it for now.
This gets rid of the warning on startup.
Just need to re-add it later when the PR is merged (if you care about Lua LSP support).

I've tried to remove this warning now for an hour straight without success. Is there a way to manage this comfortably or are you stopping your day to day work to fix these warnings yourself, as a vim user?

If you're referring to this specific sumneko_lua is deprecated warning, I commented out the sumneko_lua block under local servers = { in init.lua and then also ran :Mason in vim and under the LSP list, went to the line with lua-language-server and hit X to uninstall it for now.
This gets rid of the warning on startup.
Just need to re-add it later when the PR is merged (if you care about Lua LSP support).

Thanks. This worked.

pin version, this feature should be provided by your packag manager

I don't know which package caused this (nvim-lspconfig wasn't it) - I'm actually curious what the workflow is once something pops up as a warning: fix it continuously, pin all versions so nothing complains, use some package I don't know of that fixes it.

@tomsiwik I use lazy.nvim and just restore with R key and it will restore to the stable commits. You should also add the lock file to be tracked by git. Then you can make a stable tags for your dotfiles and when something goes wrong you need to either revert a few commits in your dotfiles or revert to the stable tag in your dotfile.

FYI: PR from williamboman/mason-lspconfig.nvim has been merged.

FYI: PR from williamboman/mason-lspconfig.nvim has been merged.

I can confirm that updating plugins (:PackerUpdate) and reactivating the lua-language-server LSP in Mason with init.lua now containing this made the deprecation notice go away:
lua_ls = {
  Lua = {
    workspace = { checkThirdParty = false },
    telemetry = { enable = false },
  },
},


Services with type:LoadBalancer are ignored

Start with;
kpng kube to-local to-nft -v=2

Create a daemonset and a service of type:Loadbalancer with mserver-daemonset.yaml.txt;
vm-001 $ kubectl apply -f mserver-daemonset.yaml
daemonset.apps/mserver created
service/mserver created
vm-001 $ kubectl get svc mserver
NAME      TYPE           CLUSTER-IP     EXTERNAL-IP   PORT(S)                         AGE
mserver   LoadBalancer   <IP_ADDRESS>   <pending>     5001:31238/TCP,5003:30029/TCP   23s
vm-001 $ kubectl get endpoints mserver
NAME      ENDPOINTS                     AGE
mserver   <IP_ADDRESS>:5003,<IP_ADDRESS>:5001   33s
vm-001 $ mconnect -address mserver.default.svc.xcluster:5001 -nconn 100
Failed connects; 100
Failed reads; 0

Access does not work.
Create another service and a deployment works mserver-deployment.yaml.txt;
vm-001 $ kubectl apply -f mserver-deployment.yaml
deployment.apps/mserver-deployment created
service/mserver-deployment created
vm-001 $ kubectl get svc mserver-deployment
NAME                 TYPE        CLUSTER-IP    EXTERNAL-IP   PORT(S)             AGE
mserver-deployment   ClusterIP   <IP_ADDRESS>   <none>        5001/TCP,5003/TCP   24s
vm-001 $ mconnect -address mserver-deployment.default.svc.xcluster:5001 -nconn 100
Failed connects; 0
Failed reads; 0
mserver-deployment-654bbdc6dc-7dchg 23
mserver-deployment-654bbdc6dc-gmd4w 30
mserver-deployment-654bbdc6dc-gk7fd 27
mserver-deployment-654bbdc6dc-9vnf5 20

There are no log printouts from kpng about the first svc but for the second there are.
vm-001 ~ # print-state
I0401 07:09:08.373495    8404 client.go:168] connecting to <IP_ADDRESS>:12090
# ------------------------------------------------------------------------
# 2021-04-01 07:09:08.381685827 +0000 UTC m=+0.029198421
#
&{Namespace:"default" Name:"kubernetes" Type:"ClusterIP" IPs:{ClusterIP:"<IP_ADDRESS>" ExternalIPs:{}} Ports:{Name:"https" Protocol:TCP Port:443 TargetPort:6443} [IPs:{V4:"<IP_ADDRESS>"}]}
&{Namespace:"default" Name:"mserver" Type:"LoadBalancer" IPs:{ClusterIP:"<IP_ADDRESS>" ExternalIPs:{}} Ports:{Name:"mconnect" Protocol:TCP Port:5001 NodePort:31238 TargetPort:5001} Ports:{Name:"ctraffic" Protocol:TCP Port:5003 NodePort:30029 TargetPort:5003} [IPs:{V4:"<IP_ADDRESS>"}]}
&{Namespace:"default" Name:"mserver-deployment" Type:"ClusterIP" IPs:{ClusterIP:"<IP_ADDRESS>" ExternalIPs:{}} Ports:{Name:"mconnect" Protocol:TCP Port:5001 TargetPort:5001} Ports:{Name:"ctraffic" Protocol:TCP Port:5003 TargetPort:5003} [IPs:{V4:"<IP_ADDRESS>"} IPs:{V4:"<IP_ADDRESS>"} IPs:{V4:"<IP_ADDRESS>"} IPs:{V4:"<IP_ADDRESS>"}]}

Note that svc mconnect is there.

The fix should be easy, as it seems you solve the doubt I had here ;) https://github.com/kubernetes-sigs/kpng/blob/3f607da46c7d5068a1573096bf4dce024dcbe5f7/backends/nft/nft.go#L148


Update windows watcher to send a single rename event with both the old and new path

Here's the fix for #44 .
A general comment for you to consider in the future, could we avoid heap allocation by using an optional instead?  This would also allow us to leverage the copy constructor here.

could we avoid heap allocation by using an optional instead? This would also allow us to leverage the copy constructor here.

Something like that sounds nice. However, we can't avoid a heap allocation unless we make the event structure non-recursive. (Need some indirection in that case.)
It's recursive because:

Currently, the only possible associated event is a renamed-to event. In the future, we may store other kinds of associated events there. Ownership changes are a good candidate. This kind of structure allows more room for future changes if needed, although admittedly the intended use of associated events may be a bit less obvious to the user than I’d like.

It was meant to give us some room for future changes.
That might not be necessary, and we can probably just store a bare event lookalike with just the path/path-type/event-type/event-time in an optional or something similar.

This can go out in a patch release soon.
Our Conan friends tend to be really on top of updates, so if that's something you use then this should be available there some time shortly after.


GHC 9.12

It's just landed in GHCup: https://github.com/haskell/ghcup-metadata/pull/270

Oh, I guess, it's only the vaniala channel...


Call show_data for nested Combined/recipe plots

What's the correct approach to call the show_data function for a combined plot that's nested inside another recipe plot?
I've tried the following:
# assume that ParentPlot is a recipe that creates one plot of the type NestedPlot
# which itself is just a recipe for a primitive scatter plot

function show_data(inspector::DataInspector, pp::ParentPlot, idx, np::NestedPlot)
    return Makie.show_data(inspector, np, idx)
end

function show_data(inspector::DataInspector, plot::NestedPlot, idx, ::Scatter)
    # actual show_data functionality for the scatter plot
    return true
end

How can I achieve what I'm trying to do?

Let's say your plot structure is
ParentPlot
> NestedPlot
   > PrimitivePlot

Makie's pick methods can only find primitive plots like scatter, lines etc. (All the ones in MakieCore.) So DataInspector triggers off of some PrimitivePlot but it moves up the tree completely before trying to call show_data. So it goes

show_data(inspector, ::ParentPlot, primitive_idx, ::PrimitivePlot)
show_data(inspector, ::NestedPlot, primitive_idx, ::PrimitivePlot)
show_data(inspector, ::PrimitivePlot, primitive_idx)

continuing to the next step if show_data from the previous step returns false and stopping if it returns true. The second plot passed is always the primitive plot because that's the context for the given index.
You only need to worry about ParentPlot if that should do something different from NestedPlot (or PrimitivePlot if NestedPlot has no show_data method). So you probably just need to implement the second function you listed.

Thank you very much for the explanation, @ffreyer. My thinking was that Makie goes from "top to bottom" but as you pointed out, it goes recursively from "bottom to top". Got it working now. :)


_Layout file for Identity not scaffolded

From @josejmoran on September 16, 2018 23:7
When I scaffold the UI for Identity everything works fine. But the file: Areas/Identity/Pages/Account/Manage/_Layout.cshtml include a line referencing a file that I look for it in the directory it says it should be but is not generated when I scaffold.
@{
Layout = "/Areas/Identity/Pages/_Layout.cshtml";
}
If I comment the line I get an error, which means Identity is using this file. It seems it did not get generated when I scaffold the Identity files. Where is this file located?
Copied from original issue: aspnet/Identity#1967

Just noticed this using the 2.2 release version

@blowdart  It seems the best solution is to change the reference in "Areas/Identity/Pages/Account/Manage/_Layout.cshtml" to:
@{
    Layout = "/Views/Shared/_Layout.cshtml";
}

This way you also retain the links in the main app navbar when viewing the account management pages, this is what i ended up doing here: https://github.com/aspnet/Scaffolding/issues/931#issuecomment-448570373
This should be clearly documented somewhere, if the missing _Layout file existed it would be much easier to see that the main layout file can be substituted by simply comparing the files and observing that they are the more or less the same. Instead i had to poke around and resort to the browser dev tools to see what was going on.

@HaoK - do you know if this is already fixes?

@javiercn can you remind me again why the layouts/scaffolder are the way they are?

@haok can you be more specific? The manage pages have a nested layout if that’s what you are referring to.

This problem was fixed. Thanks.
On Fri, Nov 8, 2019 at 2:25 AM Hao Kung<EMAIL_ADDRESS>wrote:

@javiercn https://github.com/javiercn can you remind me again why the
layouts/scaffolder are the way they are?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/aspnet/Scaffolding/issues/884?email_source=notifications&email_token=AADZ67DR6OOAMT7BEEYOBNTQSUIAFA5CNFSM4FW553V2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEDO7IOQ#issuecomment-551416890,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AADZ67E2R4GVMYAIHG25LBTQSUIAFANCNFSM4FW553VQ
.

--
Regards,
Jose J. Moran
336-347-8688

This problem was fixed. Thanks.
On Fri, Nov 8, 2019 at 3:41 AM Javier Calvarro Nelson <
<EMAIL_ADDRESS>wrote:

@HaoK https://github.com/HaoK can you be more specific? The manage
pages have a nested layout if that’s what you are referring to.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/aspnet/Scaffolding/issues/884?email_source=notifications&email_token=AADZ67HXAVP2P75SJFRTVRLQSUQ4BA5CNFSM4FW553V2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEDPENNA#issuecomment-551438004,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AADZ67BN6JXD6AUCGRYP5QDQSUQ4BANCNFSM4FW553VQ
.

--
Regards,
Jose J. Moran
336-347-8688


[improvement](truncate table) truncate skip empty partition

Proposed changes
Issue Number: close #xxx

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall

run buildall

run buildall

run buildall

run p0

run buildall


GitHub Actions: Test on Python 3.10

"3.10" must be quoted in yaml docs.
https://dev.to/hugovk/the-python-3-1-problem-85g

Thanks for the pull request!


HDFS-16551. CryptoInputStream#close() should be syncronized

Description of PR
How was this patch tested?
For code changes:

[ ] Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
[ ] Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
[ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
[ ] If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
12m 27s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s

The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ branch-3.2 Compile Tests _

-1 :x:
mvninstall
14m 33s
/branch-mvninstall-root.txt
root in branch-3.2 failed.

-1 :x:
compile
2m 46s
/branch-compile-root.txt
root in branch-3.2 failed.

+1 :green_heart:
checkstyle
0m 49s

branch-3.2 passed

+1 :green_heart:
mvnsite
1m 25s

branch-3.2 passed

+1 :green_heart:
javadoc
1m 15s

branch-3.2 passed

+1 :green_heart:
spotbugs
2m 23s

branch-3.2 passed

-1 :x:
shadedclient
6m 53s

branch has errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 56s

the patch passed

-1 :x:
compile
2m 40s
/patch-compile-root.txt
root in the patch failed.

-1 :x:
javac
2m 40s
/patch-compile-root.txt
root in the patch failed.

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
0m 40s

the patch passed

+1 :green_heart:
mvnsite
1m 11s

the patch passed

+1 :green_heart:
javadoc
1m  2s

the patch passed

+1 :green_heart:
spotbugs
2m  7s

the patch passed

-1 :x:
shadedclient
7m  3s

patch has errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
16m 21s

hadoop-common in the patch passed.

+1 :green_heart:
asflicense
0m 44s

The patch does not generate ASF License warnings.

73m 54s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4227/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/4227

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell

uname
Linux 3d8c338e391d 4.15.0-65-generic #74-Ubuntu SMP Tue Sep 17 17:06:04 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
branch-3.2 / 784173ffdd3ec127651222d5c39a7100f9734fdb

Default Java
Private Build-1.8.0_312-8u312-b07-0ubuntu1~18.04-b07

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4227/1/testReport/

Max. process+thread count
1261 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4227/1/console

versions
git=2.17.1 maven=3.6.0 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

In fact we should cherrypick it to all active branches.

Thanks @jojochuang, failures not related to the changes done.
Also, i dont see any issue with the branch also. I can compile locally successfully. Issue is something related to build environment.
Separate PR to be raised for branch 2.10? Or same can be cherry-picked?

I was able to cherrypick the commit to branch-2.10 without conflicts so you're all done. Thanks!


refactor(all): adapt latest changes in dev

Pull Request
📖 Description
Adapt the changes in latest dev of the core, will either need to update the dependencies to dev or wait until we release the the version. Possibly this Sunday (~3 days)

@jwx @Vheissu with the latest release alpha 14, this should be good to go


Excessive logging when using k8s client

In some scenarios (for example when waiting for pods to be available) there are a lot of unnecessary logs which cannot be discarded since there is no support for discarding logs for the k8s module.  The culprit I am referring to is here: https://github.com/gruntwork-io/terratest/blob/f4f2459dafaf57deaed2d91952e76ae5ffded9e6/modules/k8s/client.go#L42
To give you an example, when our team is testing our elastic cluster, we first wait for all the replicas to be available
k8s.WaitUntilPodAvailable(t, options, esOperatorPodName, retries, sleep)
k8s.WaitUntilPodAvailable(t, options, esClusterPodName, retries, sleep)
k8s.WaitUntilPodAvailable(t, options, esKibanaPodName, retries, sleep)
I propose a change (see below output) where this 'configuring Kubernetes client using config file /root/.kube/config with context ' message is only logged when the kubectl options are created, or alternatively that we can have some kind of options for loglevel to avoid these kind of messages. I know it seems trivial, but we have a lot of parallel tests that run and in some scenarios we can have thousands of these, making it hard to see what is going on in our tests.
...
TestElasticCluster 2022-01-14T13:44:54Z retry.go:91: Wait for pod elasticsearch-es-default-0 to be provisioned.
TestElasticCluster 2022-01-14T13:44:54Z client.go:42: Configuring Kubernetes client using config file /root/.kube/config with context
TestElasticCluster 2022-01-14T13:44:54Z retry.go:103: Wait for pod elasticsearch-es-default-0 to be provisioned. returned an error: Pod elasticsearch-es-default-0 is not available. Sleeping for 5s and will try again.
TestElasticCluster 2022-01-14T13:44:59Z retry.go:91: Wait for pod elasticsearch-es-default-0 to be provisioned.
TestElasticCluster 2022-01-14T13:44:59Z client.go:42: Configuring Kubernetes client using config file /root/.kube/config with context
TestElasticCluster 2022-01-14T13:44:59Z retry.go:103: Wait for pod elasticsearch-es-default-0 to be provisioned. returned an error: Pod elasticsearch-es-default-0 is not available. Sleeping for 5s and will try again.
TestElasticCluster 2022-01-14T13:45:04Z retry.go:91: Wait for pod elasticsearch-es-default-0 to be provisioned.
TestElasticCluster 2022-01-14T13:45:04Z client.go:42: Configuring Kubernetes client using config file /root/.kube/config with context
TestElasticCluster 2022-01-14T13:45:04Z retry.go:103: Wait for pod elasticsearch-es-default-0 to be provisioned. returned an error: Pod elasticsearch-es-default-0 is not available. Sleeping for 5s and will try again.
TestElasticCluster 2022-01-14T13:45:09Z retry.go:91: Wait for pod elasticsearch-es-default-0 to be provisioned.
TestElasticCluster 2022-01-14T13:45:09Z client.go:42: Configuring Kubernetes client using config file /root/.kube/config with context
TestElasticCluster 2022-01-14T13:45:09Z retry.go:103: Wait for pod elasticsearch-es-default-0 to be provisioned. returned an error: Pod elasticsearch-es-default-0 is not available. Sleeping for 5s and will try again.
....

I also encountered this problem in the Apache APISIX Ingress controller project[1], a large number of useless logs make it difficult for us to get useful information from it

https://github.com/apache/apisix-ingress-controller/

Any news on this issue?


Main loop optimization

I believe this should reduce loop cycle time.  This may even be applicable to the RC.read(), as well.

hi @SquirtleSquadLeader thanks for the PR! Have you been able to benchmark test this optimization? This is something I'd like to dig in to before I merge, I'll try to find time for it soon 😁


Toyota: improve response to acceleration requests

Toyotas seem reluctant to apply acceleration requests immediately if this bit is set, even if you request a static acceleration of 1.0 m/s/s. There are still issues with the controller lowering or even making acceleration negative if we overshoot the plan while starting which diminishes this improvement, but this actually does make the car respond better to acceleration requests.
Here are two examples with the change showing the worse possible scenario for the car; as soon as we take off we lower the requested acceleration which normally would have the car let off the gas quite a bit, however it continues on to reach the target, albeit with a little bit of slowing that you can feel.

Routes with latest changes for my reference:
f15e3c37c118e841|2022-06-30--00-51-03--0
f15e3c37c118e841|2022-06-30--00-59-09--0
f15e3c37c118e841|2022-06-30--01-01-57--0

@HaraldSchafer Are we okay with Toyota overshooting the planner's request with this PR? When starting, nearly every time it will overshoot not only the start, but throughout accelerating. We don't exactly request what the stock system does from a start, so it releases the brakes super quickly rather than ramping off them to avoid overshoot.
We might need some manual profile to fix this, but it might be different per cars (hybrids might get moving faster coasting from a stop like mine).

Closing as this bit isn't a great way to generically improve starting accuracy (overshoots acceleration at all speed, and can be dangerous if pitch is wrong)


modal scales?

From a musician perspective, would be useful being able to generate modal scales starting from each degree of a parent scale.
So "dorian" e.g. would be generated as "major.mode(2)", "aeolian" would be "major.mode(6)", "lydian augmented" would be melodicminor.mode(3), and so on...
In this way with the usual 4 parent jazz scales (major, melodic minor, harmonic minor, harmonic major) we could have almost all the scales used in jazz.
Synonims could be used anyway, so that e.g. "aeolian b5" is the same as "locrian #2"
( melodicminor.mode(6) )
Could be used also for synthetic scales (e.g. messiaen modes)

Sounds like a really interesting idea! Feel free to come up with some way of doing it, and I'd be glad to incorporate it :)

I think it's quite easy.
I don't know the implications in terms of your code architecture, but it's simply a matter of counting the notes of a same scale, but starting from another degree.
The output would be tha same scale array, just with the note position shifted; e.g. for major scale:
C Major (= C major mode (1)) : C, D, E, F, G, A, B
D Dorian (= C major mode (2)) : D, E, F, G, A, B, C
E Phrygian (= C major mode (3)) : E, F, G, A, B, C, D
F Lydian (= C major mode (4)) : F, G, A, B, C, D, E
G Mixolydian (= C major mode (5)) : G, A, B, C, D, E, F
A Aeolian (= C major mode (6)) :  A, B, C, D, E, F, G
B Locrian (= C major mode (7)) :  B, C, D, E, F, G, A
If you talk about mode 1, 2, etc.. any scale has its modes.
If you talk about mode names, not all of them have one
The most common are the major scale ones
Other "parent" scales commonly used are the Melodic Minor and Harmonic Minor
I'll be happy to help if I can, in any way...

yes I know of the diatonic modals and modes, and I think that your suggestion is quite good. However I'm wondering: should the scale object have an internal state of which mode it is in? Or maybe it would be simpler to just have the .mode function return a brand new scale.
What I mean is, should we internally represent 3. mode of C major as "phrygian E" or should it be "third inversion of C major, which is called E Phrygian"? I could accept both, although I think i prefer the simpler one with less internal state.
Right now I have very little time for these projects and I mainly just maintain it, so if you want to, you're very welcome to code up the solution. The codebase should be fairly simple and I'm always open to answer questions about it.

Sorry, I misunderstood your question, so I took the liberty to explain.
If "scale" is an object type, the method scaleXY.mode(n) should return a similar new object, that himself would have the mode(x) method, so that e.g.:
Major.mode(6) returns an Aeolian scale object, and Aeolian.mode(3) gives back a Major scale.
About the naming... there isn't a clear nomencalture for all the modes, so I'd stay away, and give the programmer the task of using appropriate variable names.
I'll have a peek to the code, although I'm not sure I can do modifications without messing up... :)

Yes, that seems like the right way to go :) Feel free to ask any questions to the code if you want to have a stab at it!

I took a stab at implementing this - let me know what you think: [https://github.com/saebekassebil/teoria/pull/126]


fix: prevent exception raised when serviceId is missing from calendar file

Summary:
Summarize the changes in the pull request including how it relates to any issues (include the #number, or link them).
Expected behavior:
Explain and/or show screenshots for how you expect the pull request to work in your testing (in case other devices exhibit different behavior).
Please make sure these boxes are checked before submitting your pull request - thanks!

[ ] Run the unit tests with gradle test to make sure you didn't break anything
[ ] Add or update any needed documentation to the repo
[ ] Format the title like "feat: [new feature short description]". Title must follow the Conventional Commit Specification(https://www.conventionalcommits.org/en/v1.0.0/).
[ ] Linked all relevant issues
[ ] Include screenshot(s) showing how this pull request works and fixes the issue(s)

Based on internal discussion, next steps are:

Update logic so this rule only triggers on feeds that only have calendar_dates.txt when -all- calendars are expired rather than any

@davidgamez I'm a bit surprised by the results of the acceptance tests! I'd still expect around 71 feeds to return this warning because their calendar_dates.date fields are all expired. Here's a few examples:
ca-alberta-lethbridge-transit-gtfs-765: https://storage.googleapis.com/storage/v1/b/mdb-latest/o/ca-alberta-lethbridge-transit-gtfs-765.zip?alt=media
ca-ontario-go-transit-gtfs-727: https://storage.googleapis.com/storage/v1/b/mdb-latest/o/ca-ontario-go-transit-gtfs-727.zip?alt=media
Full original list of expired feeds is here. I didn't check them all to see if the producer actually made changes that would've impacted the re-run of the acceptance tests.

@davidgamez I took a quick look at the acceptance test results and this logic looks good to me.
When we run these analytics before each new release, this can be my list to clean up/check for replacements for feeds in the Mobility Database.
From a QA perspective, so long as we can run https://gtfs.pro/files/uran/improved-gtfs-dft-gtfs.zip successfully, this change can be passed.


Is it possible to train Casanovo using EThcD spectra?

I have over 20,000 EThcD spectra as training data, and I used Casanovo to train a new model (with max_epochs = 100, val_check_interval = 50000, nbeams = 10, and n_peaks = 150). However, on a test set of over 10,000 EThcD spectra, the peptide recall was only 0.6%.
With the same amount of data and parameter settings, the peptide recall reached over 20% when using HCD spectra. I would like to ask: how can I modify my training or prediction strategies to make Casanovo achieve sequencing accuracy comparable to that of HCD spectra?

Though we have not tried training Casanovo on this kind of data, I don't see any reason why it shouldn't be able to learn from EThcD spectra.  If you want to share your training and validation set, we can see if we can reproduce your results and potentially suggest alternative training strategies.
You can email the files<EMAIL_ADDRESS>if they are too large to upload to github.

Can you include some additional details, such as the Casanovo version you're using and the log produced during training, to get some more information whether everything is working correctly?
Although if you've got a similar set-up working for HCD data, I agree with Bill that there shouldn't be anything special about EThcD data that should make training fail in that setting.
Note though that you're using a relatively small training dataset, which could result in two issues:

The dataset is too small to learn relevant patterns for more complex EThcD spectra.
You're entirely overfitting to a small training dataset, with 100 epochs, and performance doesn't generalize to the test set.

The training and validation log produced during training might give us some more insights into whether any of these issues are occurring.


Issue when comparing GridIndex with tuples

The following output makes little sense:
>>> from gridkit import GridIndex
>>> index = GridIndex([(1,1), (2,2)])
>>> index == (3,4)
<function _normal_op.<locals>.<lambda> at 0x7367f596f490>

I expected a False, since (3,4) is not in 'index' as a cell-id.
This is caused by the following line:
https://github.com/tmillenaar/GridKit/blob/65cf067ce8ee36b598b0b03ab243eb92f06ddd94/gridkit/index.py#L105
Here we return op without evaluating. It would make more sense to return op(left, right) but also that is tricky when viewed from a tuple perspective, for it would return a GridIndex with binary values instead of a simple boolean.
Suggestion:
Maybe first try to convert the left and right to a GridIndex? Do this in a try-catch block such that input that does not match the format is treated by numpy but if it does match the expected GridIndex format we convert it and compare the GridIndex objects for matching x,y combinations.

Resolved by this PR:
https://github.com/tmillenaar/GridKit/pull/96


fix input.cpp: bypass possible null deref error

This commit works around a "possible null dereference" error emitted
by Serac builds with<EMAIL_ADDRESS>build_type=Release" by guarding the
dereference in question with a conditional that only passes control to
the statement dereferencing the potentially null iterator if that
iterator is, in fact, non-null.
Resolves #443.
This warning seems kind of silly because another enclosing conditional ensures the dereferenced iterator is non-null, but the fix is straightforward.

Codecov Report

Merging #446 (d5b7a53) into develop (564ce44) will decrease coverage by 0.10%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop     #446      +/-   ##
===========================================
- Coverage    92.40%   92.30%   -0.11%
===========================================
  Files           48       48
  Lines         2423     2430       +7
===========================================
+ Hits          2239     2243       +4
- Misses         184      187       +3

Impacted Files
Coverage Δ

src/serac/infrastructure/input.cpp
93.29% <100.00%> (-1.62%)
:arrow_down:

src/serac/infrastructure/input.hpp
100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 564ce44...d5b7a53. Read the comment docs.

Closing as this has been merged into https://github.com/LLNL/serac/pull/447.