[SPARK-33166][DOC] Provide Search Function in Spark docs site

What changes were proposed in this pull request?
In the last few releases, our Spark documentation  https://spark.apache.org/docs/latest/ becomes richer. It would nice to provide a search function to make our users find contents faster.
DocSearch is entirely free and automated.  This PR will use it to provides search function.
The screenshots show below:

Why are the changes needed?
Let the users of Spark documentation could find the needed information effectively.
Does this PR introduce any user-facing change?
Yes
How was this patch tested?
build on my machine and look on brower.

Test build #130766 has started for PR 30292 at commit 3607e23.

Test build #130766 has finished for PR 30292 at commit 3607e23.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/130766/
Test PASSed.

Test build #130768 has started for PR 30292 at commit cae8dd1.

Nice, it's shorter than I thought. Can you show the screenshots too?

Test build #130768 has finished for PR 30292 at commit cae8dd1.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/130768/
Test PASSed.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35375/

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35377/

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35375/

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/35375/
Test PASSed.

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35377/

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/35377/
Test PASSed.

Nice, it's shorter than I thought. Can you show the screenshots too?

I uploaded the screenshots.

cc @gengliangwang and @gatorsmile

@sarutak and @srowen too

Test build #130829 has started for PR 30292 at commit 3a6bf0b.

Test build #130829 has finished for PR 30292 at commit 3a6bf0b.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/130829/
Test PASSed.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35438/

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35438/

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/35438/
Test PASSed.

The loupe icon and the first one or two characters of the search text overlaps. Can we adjust somehow?

The loupe icon and the first one or two characters of the search text overlaps. Can we adjust somehow?

What browser are you using?

What browser are you using?

I tried Chrome/Safari/Firefox on macOS.

What browser are you using?

I tried with Chrome/Safari/Firefox on macOS.

Which browser did you use to find your screenshots?

Which browser did you use to find your screenshots?

It's Safari.

After moving to another page by searching with this feature, the search box hides.
This screenshot is also took with Safari.

Test build #130863 has started for PR 30292 at commit 5949977.

Test build #130863 has finished for PR 30292 at commit 5949977.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/130863/
Test PASSed.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35470/

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35470/

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/35470/
Test PASSed.

Test build #130876 has started for PR 30292 at commit 9c9d639.

Test build #130876 has finished for PR 30292 at commit 9c9d639.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/130876/
Test PASSed.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35482/

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35482/

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/35482/
Test PASSed.

@sarutak I cannot reproduce the two problems you mentioned on my Safari browser. It seems the css style is different. Could you pull and build with Jekyll again?

@beliefer I found the first issue isn't in the latest change. The second issue seems that we move to the online Spark document rather than local document.
Before move:

After move:

Is this intended?

@sarutak Because this PR not merged and publish to the online Spark document.

@sarutak Because this PR not merged and not publish to the online Spark document.
Yes. But even if this is published the search results consistently refers to the latest release at the time point.
Imagine that this feature is merged to 3.1 and then 3.2 is released in the future, and someone still uses Spark 3.1.
In that case, even though the user uses this feature for 3.1, one moves to the document for 3.2 right?

@sarutak Because this PR not merged and not publish to the online Spark document.

Yes. But even if this is published, the search results consistently refer to the latest release at the time point.
Imagine that this feature is merged to 3.1 and then 3.2 is released in the future, and someone still uses Spark 3.1.
In that case, even though the user uses this feature for 3.1, the search result refer to the document for 3.2 right?

If so, we should apply different id from docsearch when we release a new spark version.

If so, we should apply different id from docsearch when we ready release a new spark version. @gatorsmile

Sounds good if we can do it.

@beliefer Thanks for the work!
I just tried the PR in my local setup. The element "Documentation" is wired to me. It is always with the same URL as the first search result. Also, I thought the rectangle outside the "Documentation" is an input text box.

I just try removing the style from dosearch.css and it looks fine:

If so, we should apply different id from docsearch when we ready release a new spark version. @gatorsmile

Yes. This is true. We need to apply different ID for each new version.

Test build #131005 has started for PR 30292 at commit 7120c5b.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35612/

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35612/

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/35612/
Test FAILed.

retest this please.

Test build #131016 has started for PR 30292 at commit 7120c5b.

Test build #131016 has finished for PR 30292 at commit 7120c5b.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/131016/
Test PASSed.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35622/

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35622/

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/35622/
Test FAILed.

Test build #131005 has finished for PR 30292 at commit 7120c5b.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/131005/
Test PASSed.

@gengliangwang I resolved the issue you said.

Seems good to me.

Thanks, merging to master

@gengliangwang @sarutak @gatorsmile @maropu @HyukjinKwon Thanks for your help!


v2: Added ability to do context-aware PerformRequest

Small patch that adds PerformRequestC func which is usual PerformRequest that passes ctx to the HTTP client.
No API breakage or breakage of pre-1.7 builds.

Bump. Are you OK with this @olivere?

@utrack v2 is rather old, so I'm not pushing too aggressively for that. There has also been some work recently to switch from golang.org/x/net/context to context, so this has to be done for v2 as well. We introduce context in v2 as well, of course, but all other service interfaces have to be switched as well, not just PerformRequest.
I won't have time to look into it this week. Maybe next weekend.

Actually, v2 has no context-related code at all atm :)
I've used net/context for backwards compatibility, but it can be swapped in favour of vanilla context, of course.

Yes. The PR mentioned above does exactly that. The "context" package is now available for 2 Go releases, and the majority of libraries are switching to it. I want elastic to do that as well.
However, the services need to be capable of using the PerformRequestC, which they are not with your change. Your change actually only add context.Context to PerformRequest. If you're not sure what I mean, see this highlighted fragment from v3. It has to be done for all services in v2.

Oh, I see. I'll add support for other services then, thanks.

@utrack Yes, that'd be very helpful. However, keep in mind that I won't be able to merge this week as I'm out of the office. Sorry.

@olivere Bump

@utrack I'm sorry, I was on vacation last week and v2 is not my primary focus, so I updated 5.x first (and work on 6.x already). Please bear with me... it's just a matter of time. Your PR is very welcome, but I want to test it first.

@utrack Please do not add code that pushes v2 into a different direction than v5. It might be useful, but it's hard enough to keep 3 versions of a codebase. It's even harder when they slightly differ.

Sorry for that, we've got the bug in production just yesterday. Without last two commits when ES cluster goes down - healthcheck waits for response indefinitely, blocking every other hc goroutine, leaking them and breaking the client. @olivere

@utrack Now, that's a bug I'd like to see fixed. But I think we should address that in a separate issue/PR. Once you got the time, can you send a reproducible step-by-step/code snippet? It should also impact v3 and v5 then.

OK @olivere, I'll try to create a reproducible case in a separate PR then :)
Reverted last two commits.

Thanks for your support on getting context into v2. Even one of my projects will benefit from this :-)


Add CORS

What does this PR do?
Add CORS with this package
Todos

[ ] Test

No idea if this is working properly 🎉

👍


Phase 5 - Retrospective

After the main goal/KPI is achieved, complete a Retrospective answering:

What went well?
What could have gone better?
What will I do next time?

 Phase 5 - Retrospective

completed 12.14.2023, in main README.md file.


Add field for Metadata API: About

https://dini-ag-kim.github.io/amb/draft/#about

I think it is pending until we implement the solution for querying subject fast


Add a workaround for EmptyEndpointException with HealthCheckedEndpoint

Motivation:
Even if an EndopintGroup resolves the initial endpoints,
EndpointSelector could continue to return a null endpoint.
See https://github.com/line/armeria/pull/3978 the details.
The bug has been fixed in Armeria but some users whou use Armeria 1.13.4
could see EmptyEndpointException and difficult to apply a workaround.
Because a HealthCheckedEndpoint is created a CentralDogma client
internally.
Modifications:

Wait for the initial endpoints before returns a new client.

Result:

You no longer see EmptyEndpointException with CentralDogma client.

The changes was reviewed at https://github.com/line/centraldogma/pull/667

Let me merge this PR if the CI builds pass.


set_fee_asset

When I updated library, set_fee_asset was broken, so I can't use my own asset in fee.

Please definde broken. Can you provide a simple code example that shows that behavior?

I've already written to you, so now there is no problems.


Percent signs in URLs double-encoding?

I kinda thought we fixed this but maybe it slipped somehow?
Niklink:

URL encoding issue similar to #147
the link https://hsmusic.wiki/media/misc/archive/Skaia%20Voyages.mp3 gets turned into https://hsmusic.wiki/media/misc/archive/Skaia%2520Voyages.mp3 because it thinks the % is a special character itself so it turns it into %25

Me:

good catch, ty! this is due to a recent change https://github.com/hsmusic/hsmusic-wiki/commit/84081cc3b5287f925ffeeb94ae730e4c143b5f59
i believe encodeURI for the href case is because additional files may contain spaces, but the appropriate place for this kind of detection is in the url key & args -> url string templater, right here: https://github.com/hsmusic/hsmusic-wiki/blob/54509b203a2119fa66c09bef6da4a2fccf8219e8/src/util/urls.js#L88-L95

Need to see if this is still happening in data-steps also.
Some tracks this affects:

https://hsmusic.wiki/track/where-making-this-hapen/
https://hsmusic.wiki/track/skaia-voyages/
https://hsmusic.wiki/track/sea-of-derse/

Dupe of #162.


ISSUE

Issue Type: Bug
XHR failed
VS Code version: Code 1.69.2 (3b889b090b5ad5793f524b5d1d39fda662b96a2a, 2022-07-18T17:05:44.765Z)
OS version: Windows_NT ia32 6.1.7601
Restricted Mode: No

Thanks for reaching VS Marketplace, please share error message or screenshot to investigate better.
-VS Marketplace Team

Closing the issue since there has been no updates on the information requested. If the issue still persists, please feel free to reopen or create a new issue.
Regards,
VS Marketplace Team


Repeat quest didn't pick support for a while

Preparation

[X] I tested the latest release
[X] I looked at other issues (even the closed ones)
[X] I read the Troubleshooting Guide

FGO server
NA, JP
FGA build number
1483
Describe the bug
It usually happens when FGA tried to repeat the same quest, and when the screen changes to support selection it just does the thing in the video.
Video
This is happening consecutively
https://user-images.githubusercontent.com/89583975/131235557-a5809859-c161-4a7b-b9ba-293af243a57c.mp4
Device model
Redmi Note 4
Android version
Android 7
Screen size
No response
RAM
No response

Did you change any of the Fine-Tune settings?

Nope, i did not

Im having the same issue but i also found that rotating the phone causes FGA to restart the recognition process again wich exits the loop (i also havent changed anything in the settings) and that it also fixes itself after waiting for about 4 minutes inside the loop in at least in my case.
my own version of the post for reference:
FGO server
NA, JP
FGA build number
1488
Describe the bug
The exact same one as listed above.
Video
https://user-images.githubusercontent.com/81212715/132327445-8d03ae8e-5711-426b-833e-1bc6c5c30edb.mp4
Device model
Galaxy A12 (SM-A125M)
Android version
Android 10
Screen size
1600x720
RAM
4gb

Hey, thanks for the temporary fix.
Also, do you just wait it out for 4 minutes each time you tried to farm something?

Are the debug mode rectangles making the matching fail? I can only see that as the difference when you rotate the screen. 🤔
Debug mode rectangles interfering with matching has happened before on Quest rewards screens. I don't have the link to that issue though.

It... worked? I swear it didn't worked before.
Anyway, thank you everyone for the help


Add object.{lt, le, gt, gt}

Is this code required? If the __lt__ attribute is not present, < will not work anyway right?

Yes, < will not work but, if I run RustPython I get different error from the python:
RustPython:
>>>>> a = object()
>>>>> a < 1
Traceback (most recent call last):
  File <stdin>, line 0, in <module>
TypeError: Unsupported method: __lt__

Python3.7.2:
>>> a = object()
>>> a < 1
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
TypeError: '<' not supported between instances of 'object' and 'int'

Looks like error from RustPython not so clear. @windelbouwman what do you think?

I am unsure what is the proper location to implement this. We might also choose to update the existing error message in Rustpython. We already raise the correct exception type, so the message should be expanded, right? I would look in the vm.rs file for the existing error and add proper type name information like in cpython.

We already raise the correct exception type, so the message should be expanded, right?

Yes.

I would look in the vm.rs file for the existing error and add proper type name information like in cpython.

The unsupported method error thorws on 251 line in vm.rs. Can you please tell me how I can expand the error?

The proper error message appears already to be implemented here: https://github.com/RustPython/RustPython/blob/master/vm/src/vm.rs#L554
The correct function to take a look at is call_or_unsupported. This function will first try the normal  method (__add__), then the reverse method (__radd__ for example).
Take a look at the _lt method (https://github.com/RustPython/RustPython/blob/master/vm/src/vm.rs#L604). Maybe we could call here call_or_unsupported as well?

Looks like some work done in #433. Maybe I can add erros the same way?

Looks like some work done in #433. Maybe I can add erros the same way?

Yep! The objobject comparison methods should return NotImplemented:
class MyClass:
    pass

assert MyClass().__le__(MyClass()) == NotImplemented
assert MyClass().__lt__(MyClass()) == NotImplemented
assert MyClass().__ge__(MyClass()) == NotImplemented
assert MyClass().__gt__(MyClass()) == NotImplemented

And VirtualMachine::{_le, _lt, _ge, _gt} should use call_or_unsupported. This page documents the appropriate fallbacks to use.

@OddCoincidence I added the methods to object but when I run tests/snippets/builtin_max.py got error:
thread 'main' panicked at 'Inner error getting inner boolean', vm/src/obj/objbool.rs:60:9

What I'm doing wrong? Can you help me please

Sounds like the same bug I fixed in: https://github.com/RustPython/RustPython/pull/441
builtin_max should use vm._gt rather than calling __gt__ itself.

@cthulahoops You are right! Thank you! Should we change all calling __gt__ to vm._gt and another simular methods?

Thats probably better. The magic methods should be used sparingly, preferably in wrapper methods.


Errors when variable name is in Object.getOwnPropertyNames(Object.prototype)

The following list of variable names:
[ 'constructor', 'toString', 'toLocaleString', 'valueOf', 'hasOwnProperty', 'isPrototypeOf', 'propertyIsEnumerable', 'defineGetter', 'lookupGetter', 'defineSetter', 'lookupSetter', 'proto' ]
(e.g. constructor = 123)
will cause coffeescope to error because if not @symbols[name] will never evaluate to, since the above listed properties are always on @symbols, an instance of Object. One workaround would be to prefix all the keys, e.g. if not @symbols['somePrefix_' + name] which seems pretty hacky. Cleaner solution seem to be using a Map polyfill (e.g. require('core-js/es6/map') from https://github.com/zloirock/core-js )

Good catch. Fixed in 0.3.1


IOS download document problem

Hi, I try to download file in ios but I can't see file. in Andriod everthing OK.
my versions:
"react-native": "^0.68.2",
"react-native-blob-util": "^0.16.0",
this my download function
async function handleDownload(val) {       try {         const fileExtension = val.workorderDocumentUrl.split('.')[1];         const fileName = /${val.workorderDocumentName}.${fileExtension}`;
    const {workorderDocumentGuid, workorderDocumentName} = val;

    const configOptions = Platform.select({
      ios: {
        fileCache: true,
        path: ReactNativeBlobUtil.fs.dirs.DocumentDir + fileName,
        notification: true,
        IOSDownloadTask: true,
      },
      android: {
        fileCache: false,
        addAndroidDownloads: {
          useDownloadManager: true,
          notification: true,
          path: ReactNativeBlobUtil.fs.dirs.DownloadDir + fileName,
          description: 'Downloading...',
        },
      },
    });
    if (Platform.OS === 'ios') {
      ReactNativeBlobUtil.config(configOptions)
        .fetch(
          'GET',
          `${store.baseUrl}/docs?guid=${workorderDocumentGuid}`,
          {
            'accept-version': 'v3',
            'inavitas-tenant': store.tenant,
          },
        )
        .progress((received, total) => {
          console.log('PROGRESS', received, total);
        })
        .then(res => {
          setTimeout(() => {
            var filePath = res.path();
            ReactNativeBlobUtil.ios.presentPreview('file://' + filePath);
            console.log('RESIOS', res);
            //ReactNativeBlobUtil.ios.openDocument(res.data);
          }, 300);
          // the temp file path
          console.log('The file saved to ', res.path());
          setSuccessDownload(true);
          console.log('DIRS', ReactNativeBlobUtil.fs.dirs);
        })
        .catch(err => console.log('download Err', err));
    } else {
      ReactNativeBlobUtil.config(configOptions)
        .fetch(
          'GET',
          `${store.baseUrl}/docs?guid=${workorderDocumentGuid}`,
          {
            'accept-version': 'v3',
            'inavitas-tenant': store.tenant,
          },
        )
        .then(res => {
          ReactNativeBlobUtil.android.actionViewIntent(res.path());
          // the temp file path
          console.log('The file saved to ', res.path());
          setSuccessDownload(true);
          console.log('DIRS', ReactNativeBlobUtil.fs.dirs);
        })
        .catch(err => console.log('download Err', err));
    }
  } catch (err) {
    console.log(err);
  }
}`

Here is my debug console, I can see directory && process

On iOS you won't be able to see the files in the Files app unless you share them

For iOS, you can use react-native-share once you download the file to save it to files.
  .then((res) => {
        // the temp file path
        console.log('The file saved to ', res.path());
        // in iOS, we want to save our files by opening up the saveToFiles bottom sheet action.
        // whereas in android, the download manager is handling the download for us.
        if (Platform.OS === 'ios') {
          const filePath = res.path();
          let options = {
            type: 'application/pdf',
            url: filePath,
            saveToFiles: true,
          };
          Share.open(options)
            .then((resp) => console.log(resp))
            .catch((err) => console.log(err));
        }
      })

or use this
ReactNativeBlobUtil.ios.previewDocument(file.path());

@Saad-Bashar hello! I tried to do as you suggested. the files began to appear in the recent ios folder. but they don't open properly

here is my code
const downloadFile = async (file: IFile) => {
const isGranted = await getPermissionDownloadImage();
if (!isGranted) {
  toast.current?.show("Отсутствует разрешение на загрузку документов");
  return;
}

const url = `${ConnectionStore.api}longreads/file/${file.id}`;
const headers = { Authorization: `Bearer ${keycloak.token}` };
await ReactNativeBlobUtil.config({
  fileCache: true,
  path: `${RNFS[IS_IOS ? "DocumentDirectoryPath" : "DownloadDirectoryPath"]}/${file.fileName}.${file.extension}`,
})
  .fetch("GET", url, headers)
  .progress(() => {
    setIsLoading((prev) => [...prev, file.id]);
  })
  .then((res) => {
    if (IS_IOS) {
      const filePath = res.path();
      const options = {
        type: `application/${file.extension}`,
        url: filePath,
        saveToFiles: true,
      };
      Share.open(options)
        .then(() => changeDownloadState(file.id))
        .catch(() => changeDownloadState(file.id, false));
    } else {
      changeDownloadState(file.id);
    }
  })
  .catch(() => {
    changeDownloadState(file.id, false);
  })
  .finally(() => setIsLoading((prev) => prev.filter((item) => item !== file.id)));

};
would you help me?

@Saad-Bashar i had the same problem, appending .pdf to the path fixes the problem for me
path: ${dirs.DocumentDir}/${fileName}.pdf,
LOG  The file saved to  /Users/xx/Library/Developer/CoreSimulator/Devices/FEBCC312-3D3A-4C60-A008-49A488000139/data/Containers/Data/Application/6DE346D7-CC55-4E21-B9F5-1D9766E977EB/Documents/Resources-1701931717558
LOG  The file saved to  /Users/xx/Library/Developer/CoreSimulator/Devices/FEBCC312-3D3A-4C60-A008-49A488000139/data/Containers/Data/Application/6DE346D7-CC55-4E21-B9F5-1D9766E977EB/Documents/Resources-1701931752795.pdf

Is there an update on this? I tried downloading the file xlsx in iOS, but it always returns the path simulator.

Is there an update on this? I tried downloading the file xlsx in iOS, but it always returns the path simulator.

I don't know if this is the right solution, but I managed to solve the problem using react-native-share
Share.open({
url: urlPath,
saveToFiles: true,
})
urlPath is url returned by ReactNativeBlobUtil

Is there an update on this? I tried downloading the file xlsx in iOS, but it always returns the path simulator.

I don't know if this is the right solution, but I managed to solve the problem using react-native-share
Share.open({ url: urlPath, saveToFiles: true, }) urlPath is url returned by ReactNativeBlobUtil

Thank you for your response,
I fixed the issue in iOS. I'm not sure why it didn't download, but I am using the react native file viewer to open it and it's working. The user will need to download a manual.

For iOS, you can use react-native-share once you download the file to save it to files.
  .then((res) => {
        // the temp file path
        console.log('The file saved to ', res.path());
        // in iOS, we want to save our files by opening up the saveToFiles bottom sheet action.
        // whereas in android, the download manager is handling the download for us.
        if (Platform.OS === 'ios') {
          const filePath = res.path();
          let options = {
            type: 'application/pdf',
            url: filePath,
            saveToFiles: true,
          };
          Share.open(options)
            .then((resp) => console.log(resp))
            .catch((err) => console.log(err));
        }
      })

The only way I've made it worked was using this approach.

For iOS, you can use react-native-share once you download the file to save it to files.
  .then((res) => {
        // the temp file path
        console.log('The file saved to ', res.path());
        // in iOS, we want to save our files by opening up the saveToFiles bottom sheet action.
        // whereas in android, the download manager is handling the download for us.
        if (Platform.OS === 'ios') {
          const filePath = res.path();
          let options = {
            type: 'application/pdf',
            url: filePath,
            saveToFiles: true,
          };
          Share.open(options)
            .then((resp) => console.log(resp))
            .catch((err) => console.log(err));
        }
      })

or use this
ReactNativeBlobUtil.ios.previewDocument(file.path());

I've tried this too but it didn't work for me.
Thank you @Saad-Bashar !


Better error handling?

I have noticed that all failures of communicating with the api return the same exception as the following. I get this same error message if the bot token is invalid, or the parameters are missing, or any other issue. is it possible to provide better error handling?
wrong number of arguments (1 for 2)
/app/vendor/bundle/ruby/2.0.0/gems/telegrammer-0.5.0/lib/telegrammer.rb:48:in `initialize'
/app/vendor/bundle/ruby/2.0.0/gems/telegrammer-0.5.0/lib/telegrammer/api_response.rb:18:in `exception'
/app/vendor/bundle/ruby/2.0.0/gems/telegrammer-0.5.0/lib/telegrammer/api_response.rb:18:in `fail'
/app/vendor/bundle/ruby/2.0.0/gems/telegrammer-0.5.0/lib/telegrammer/api_response.rb:18:in `initialize'
/app/vendor/bundle/ruby/2.0.0/gems/telegrammer-0.5.0/lib/telegrammer/bot.rb:469:in `new'
/app/vendor/bundle/ruby/2.0.0/gems/telegrammer-0.5.0/lib/telegrammer/bot.rb:469:in `api_request'
/app/vendor/bundle/ruby/2.0.0/gems/telegrammer-0.5.0/lib/telegrammer/bot.rb:488:in `send_something'
/app/vendor/bundle/ruby/2.0.0/gems/telegrammer-0.5.0/lib/telegrammer/bot.rb:198:in `send_photo'
/app/app/models/message.rb:47:in `send_photo'
/app/app/models/message.rb:31:in `dispatch_message'
/app/app/workers/delivery_worker.rb:15:in `perform'

You're totally right. There was a little bug raising the exceptions. It's now fixing, and I'm in the process to release 0.5.1 with that fixed.
Thanks for reporting this bug! :)

great thanks! looking forward to it.


[TouchableHighlight] activeOpacity not working

Description
The activeOpacity of the TouchableHighlight component is not working. By default it's 0.85 hence the black underlayColor should not be full black.
nd even if I add the prop activeOpacity and set it to a custom value, nothing change, the underlay color is still full black.

Reproduction
<TouchableHighlight onPress={() => {}} underlayColor={/* whatever */}>
  <Text>PRESS ME</Text>
</TouchableHighlight>

Solution
A weird thing I noticed: if I use a custom component in the TouchableHighlight with a View for its root and I forward the native props with setNativeProps to this View, the activeOpacity works fine. It doesn't work if I directly use a View in the TouchableHighlight children.
Additional Information

React Native version: 0.41.0-rc.0
Platform: iOS
Operating System: macOS

Confirmed, I was just trying to change activeOpacity yesterday and noticed the same thing.

Closing this issue because it has been inactive for a while. If you think it should still be opened let us know why.

@hramos I've run in to the same problem. Apparantly, activeOpacity  only works if underlayColor is explicitly declared. Any idea why?

@hramos This should be reopened. The issue has 13 upvotes and is still not working on the latest React Native. Can you reconsider?

@Kerumen I've reopened the issue. If people are still running into this, I highly suggest submitting a PR with a fix. Otherwise the issue may get closed again after a period of inactivity.

+1  I am seeing the same issue.

+1 Same issue

+1

+1

+1

+1

Let's use reactions on the original post instead of adding a comment with a +1. That way interested parties can track actual progress on a solution without having to dig through multiple +1 comments. Thanks!

seeing the same issue...
Version: 0.46.2

This issue can be fixed by setting a background colour on the child component of TouchableHightlight. For example, this will result in the black overlay:
<TouchableHighlight>
	<View>
		<Text>Testing</Text>
	</View>
</TouchableHighlight>

However this would work as expected:
<TouchableHighlight>
	<View style={backgroundColor: "#fefefefe"}>
		<Text>Testing</Text>
	</View>
</TouchableHighlight>

Come to think of it this is logical.
TouchableHightlight works by adding an underlay below the component, and then by altering the opacity of the component so that the underlay shows through. However if the component background is transparent, then the underlay is fully visible through it and thus the whole component is black (or whatever value is set in underlayColor).
Perhaps it's actually the doc that should be changed to make that clear?

Issue has not been fixed yet, right?

+1

@Droppers I just had it and I have the latest version so, yes. Not yet!
I just used RGBA, this worked for me:
underlayColor="rgba(253,138,94,0.2)"

+1 to prevent it from closing due to inactivity for a while. Can be reproduced with v0.47.1

Here's an easy way around it:
const green = '#8BC34A';
const greenUnderlay = '#A7DB6B';  // lighter shade of green

<TouchableHighlight
    style={{ backgroundColor: green }}
    underlayColor={greenUnderlay}
    ... />

@adamtysonsmith, that should be an opaque color (RGB) that does not allow for transparency. Opting for RGBA solves it.

I also resolved this using underlayColor prop on TouchableHighlight
<TouchableHighlight underlayColor="rgba(0, 0, 0, 0)" />

@BoBao77's solution worked for me!

It does, however that's a workaround. The underlaying bug should still be fixed.

Still broken for me in "react-native": "0.55.4",. I'd submit a PR but sorry, I'm still learning how the "guts" work so I don't know the actual fix :) The underlayColor={'rgba(45,103,173,0.2)'} technique seems to be the briefest workaround so far...
That option works so well I wonder why two separate props are required here to control this behavior. Wouldn't it make sense to just deprecate activeOpacity and document this alternate usage as "standard"? It wouldn't break anything, since it isn't working anyway...


Set Account Base Currency from Brokerage in Live Mode

Description

Added a new property: IBrokerage.AccountBaseCurrency
All brokerage implementations now set IBrokerage.AccountBaseCurrency after a successful connection
In BrokerageSetupHandler.Setup() the USD account currency check has been removed and the algorithm account currency is set equal to the brokerage account base currency
The brokerage.Connect() method is now called before algorithm.Initialize()
CashBook.ToString() now returns the correct account currency symbol, instead of the hardcoded $ sign

Related Issue
#110
Motivation and Context

Enable users with non-USD accounts to use their brokerage account base currency

Requires Documentation Change
No.
How Has This Been Tested?

Tested locally and in cloud with all brokerages

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] Refactor (non-breaking change which improves implementation)
[ ] Performance (non-breaking change which improves performance. Please add associated performance test and results)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Non-functional change (xml comments/documentation/etc)

Checklist:

[x] My code follows the code style of this project.
[x] I have read the CONTRIBUTING document.
[x] All new and existing tests passed.

Nice! Are we missing to update Bitfinex too?

Bitfinex was left with the default base currency of USD intentionally because there is no single (and enforced) base currency like CoinbasePro.
They seem to accept deposits in any of these currencies: USD, EUR, GBP, JPY, CNH
https://support.bitfinex.com/hc/en-us/articles/115004405873-A-Beginner-s-Guide-to-Bitfinex#h_01EJ0VD5GP4AA9XYZKA1RD42QQ


Freeipa dl scale rebase 2

Updates:

Fix bug in AWS environment creation where FreeIPA instance count wasn't being passed properly
Add support for passing FreeIPA instance count to Azure env creation
Add support for passing FreeIPA instance count to GCP env creation

Replaced by https://github.com/cloudera-labs/cloudera.cloud/pull/30


Adds translation for Italian

I'd like to contribute an Italian translation in Crowdin. Can you set up a new locale for this?
Thank you for the great project!

Sure thing! Here you are: https://crowdin.com/project/excalidraw/it#


Merge main into dev

We need to stage the release-related changes (such as auth next changes) in dev branch.

Preview is available here:http://soroban-docs-pr305.previews.kube001.services.stellar-ops.com/


fix the streamlit with updated dictionary keys

When querying a surf report on streamlit, we get error which is because of the change in the forecast keys and streamlit_helper not reflecting the changes.
The code ensures the streamlit_helper keys match the new forecast keys.

Summary by Sourcery
Update streamlit_helper to align with new forecast dictionary keys, fixing errors in surf report queries.
Bug Fixes:

Fix the streamlit_helper to use updated dictionary keys for surf report forecasts, resolving errors when querying reports.

@balugans Nice work! Looks good to me 👍
If you'd like to create an issue for the missing streamlit-folium dependency, please feel free to do so!
Thanks for you contribution

@all-contributors please add @balugans for bug fix

@balugans Nice work! Looks good to me 👍
If you'd like to create an issue for the missing streamlit-folium dependency, please feel free to do so!
Thanks for you contribution

Sure will do. i will open the issue


Is it possible to specify which metadata go to the S3 store?

Question
Is it possible to specify which metadata attributes are sent to the S3 store and which are not?
I'm getting the following error:

response code: 500, response text: s3store: unable to create multipart upload: MetadataTooLarge: Your metadata headers exceed the maximum allowed metadata size.

I wish to be able to disable sending metadata to the S3 store, or to specify which metadata attributes get sent to the S3 store. I still want to be able to receive the full metadata in the http hook.
Is any of this possible? Or is there another way to get all the metadata in the http hook without triggering a MetadataTooLarge error on the S3 store?
Setup details
Please provide following details, if applicable to your situation:

Operating System: Linux
Used tusd version: v1.10.1
Used tusd data storage: OCI Object Storage (s3-compatible)
Used tusd configuration: -s3-bucket [...] -s3-endpoint [...] --hooks-enabled-events pre-create,pre-finish --hooks-http [...] -hooks-http-forward-headers Authorization -behind-proxy
Used tus client library: tus-js-client 3.1.1

No right now, but in the next major release it will be. v2 will ship with https://github.com/tus/tusd/pull/962, where meta data can be customized (or filtered) in the pre-create hook.

This is possible now since tusd v2. See https://tus.io/blog/2023/09/20/tusd-200 for more details.


Documentation and tests of build/taggingPromotion

Documentation and tests of build/taggingPromotion

Great job!
From: Elio Marcolino<EMAIL_ADDRESS>Reply-To: JFrogDev/artifactory-user-plugins<EMAIL_ADDRESS>Date: Thursday, July 20, 2017 at 1:28 PM
To: JFrogDev/artifactory-user-plugins<EMAIL_ADDRESS>Cc: Subscribed<EMAIL_ADDRESS>Subject: [JFrogDev/artifactory-user-plugins] Documentation and tests of build/taggingPromotion (#102)
Documentation and tests of build/taggingPromotion
You can view, comment on, or merge this pull request online at:
https://github.com/JFrogDev/artifactory-user-plugins/pull/102
Commit Summary
Tests and documentation of build/taggingPromotion
Fixing documentation
File Changes
M build/taggingPromotion/README.md (34)
D build/taggingPromotion/TaggingPromotionTest.groovy (19)
A build/taggingPromotion/test/TaggingPromotionTest.groovy (174)
A build/taggingPromotion/test/build.json (30)
Patch Links:
https://github.com/JFrogDev/artifactory-user-plugins/pull/102.patch
https://github.com/JFrogDev/artifactory-user-plugins/pull/102.diff
—You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.
--
https://www.jfrog.com/support-service/another-hop-forward-jfrog-universal-solution-giant-leap-c-community/


Migrate Workspace.clean to the diagnostics system

Made Workspace.clean non-throwing and accept a DiagnosticsEngine.
While doing so, I found it quite useful to define a wrap method on DiagnosticsEngine that allows us to wrap a throwing function into a Optional returning function, feeding the engine on error. It’s a more generally useful version of LoadableResult.load(diagnostics:), so took the liberty to remove that function.

@swift-ci please smoke test

Failure looks related

@swift-ci please smoke test

@swift-ci please smoke test


Create a minimal install assuming that Grafana already exists in the managed cluster.

Describe the behavior changes introduced in this PR
This change introduces a parallel set of Helm charts to only deploy the GrafanaDashboard assets required for Pelorus assuming that the user is in a managed environment like OpenShift Dedicated and Grafana cannot be installed via this chart due to security restrictions.
Linked Issues?
related to #127
Testing Instructions
Please include any additional commands or pointers in addition to our standard PR testing process.
I updated the install documentation describing how the minimal install process works.  This is simply the first step towards getting Pelorus working in OpenShift Dedicated.  Next, I will be looking into the exporters so that they will work with Gitlab.
@redhat-cop/mdt

No longer needed as the helm chart refactor fixed my issue on OSD.


Parse html with langchain-beautifulsoup

Uses langchain beautifulsoup transformer to parse HTML files.
Can specify which tags to exclude and include when parsing.
Writes parsed data to disk in md-format.

Same as to what Nikolay is doing in the filter branch, extracted it into its own file such that there is no overlap when merging.
Nice thing about beautifulsoup transformer is that it is easy to specify which tags to include and exclude.


Updated Itrash homepage

Changes to a cask
Editing an existing cask

[x] Commit message includes cask’s name (and new version, if applicable).
[x] brew cask audit --download itrash is error-free.
[x] brew cask style --fix itrash left no offenses.

Thank you for the contribution. It was merged directly as acbba9709917acd7c686512e1e0c67db4429b1e2 to keep commit history cleaner. Your contribution is still credited to you.


Fix CPUSAGE compatibility with ODX 2.0

@andlaus could you release a new version once this is fixed

all good now. merging, thanks!

release done...


chore(main): release 0.5.0

:robot: I have created a release beep boop
0.5.0 (2024-08-29)
Features

postgres support (#22) (a8a4ca0)

This PR was generated with Release Please. See documentation.

:robot: Created releases:

v0.5.0
:sunflower:


[Question]:  Can this functional code of deepdoc be extracted separately?

Describe your problem
Can this functional code of deepdoc be extracted separately?

We will provide an API for this soon.
BTW, could you specify the input and output requirement?


Project navigator file filtering

Description

This pull request adds the ability to search files and folders in the navigator area. The following features were added:

Typing in the "Filter" textfield now searches through files and folders.
When a folder matches the filter, all of its content appears.
When searching, all of the folders get expanded.
The state of the folders that were expanded by the user before searching gets saved, so that when they finish searching, everything returns back to place.
When searching, the characters/words in the file and folder names that match the search get bold.
When there are no search results a label "No Filter Results" appears.
The search, just like in Xcode, is case-insensitive.

Related Issues

#1139

Checklist

[x] I read and understood the contributing guide as well as the code of conduct
[x] The issues this PR addresses are related to each other
[x] My changes generate no new warnings
[x] My code builds and runs on my machine
[x] My changes are all related to the related issue above
[x] I documented my code

Screenshots
(From description list)

Typing in the "Filter" textfield now searches through files and folders.

https://github.com/user-attachments/assets/ef7a9806-c578-4077-933f-34c334a31ac2

When a folder matches the filter, all of its content appears.
When searching, all of the folders get expanded.
When searching, the characters/words in the file and folder names that match the search get bold.

https://github.com/user-attachments/assets/ef94d63a-b1d2-46ab-8c4c-2f5462fb08d9

The state of the folders that were expanded by the user before searching gets saved, so that when they finish searching, everything returns back to place.

https://github.com/user-attachments/assets/6085403e-18b5-4eeb-a929-62f84f095657

When there are no search results a label "No Filter Results" appears.
The search, just like in Xcode, is case-insensitive.

https://github.com/user-attachments/assets/65546fb5-baf1-473e-bc44-f2f1eac02d91

Wow this looks awesome! I should have time to review very soon. Excited for this!

@allcontributors add @LeonardoLarranaga for code


Possible error when calculating pixel distance

I'm guessing this is an error, but I'm not 100% sure so please review this carefully.
The important fix is taking the absolute values when declaring dist_x and dist_y. The change on the lines declaring y is just to remove the now unecessary max() calls.

This is not a bug but a design choice: the distance vector $d$ must be signed in order for the $d^T \Omega^{-1} d$ operation to represent an anisotropic distance. Note that the covariance matrix $\Omega$ is by construction strictly positive definite, so $d^T \Omega^{-1}d$ will in theory always be strictly positive. I have however observed in practice that due to numerical precision, some near zero values may get slightly negative, which can become a dramatic issue because of the exponential. This is extremely rare but I kept it just in case.

Ok thanks for clarifying this and clarifying about using the first frame.
Jamy Lafenetre @.***>于2023年12月13日 周三00:27写道：

This is not a bug but a design choice: the distance vector $d$ must be
signed in order for the $d^T \Omega^{-1} d$ operation to represent an
anisotropic distance. Note that the covariance matrix $\Omega$ is by
construction strictly positive definite, so $d^T \Omega^{-1}d$ will in
theory always be strictly positive. I have however observed in practice
that due to numerical precision, some near zero values may get slightly
negative, which can become a dramatic issue because of the exponential.
This is extremely rare but I kept it just in case.
—
Reply to this email directly, view it on GitHub
https://github.com/Jamy-L/Handheld-Multi-Frame-Super-Resolution/pull/34#issuecomment-1852381535,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ALTS3X2Q2E45SWGDB7HQN5LYJCAVXAVCNFSM6AAAAABARS2EICVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNJSGM4DCNJTGU
.
You are receiving this because you authored the thread.Message ID:
@.***
com>


Support for Loading Animation when filters are updated

Enter your suggestions in details:
Currently, when filters are applied (in the leaderboard and contributor activity timeline), it takes a while for results to be updated, there is no visual feedback indicating that the page is loading.
Add a loading animation when filters are applied.
Suggested package:
https://www.npmjs.com/package/next-nprogress-bar

Hi @rithviknishad , I tried doing this but filters are being applied dynamically via routing. So I'm unable to get proper understanding as to at what point I need to apply this progress bar. Can you suggest please?
A video of what I've done in this, using next-nprogress-bar
https://github.com/coronasafe/leaderboard/assets/59362723/d95f9385-277d-48aa-a7f6-2858a0ab4908

Closing as all pages are not static site generation


remove static width for slider units

Part of #2781

Removing static widths is always great. This is the difference before and after:
Before:

After:

Before:

After:

I appreciate the idea, but I don't think it really works out.

It means sliders are not consistently positioned. This is a ugly annoyance in most cases...

... but really hurts the ability to quickly compare the relative positions in share groups:

This happens when the width of the value changes:

I think fixed widths are a must unless these issues can be resolved.

@antw I was already thinking this would happen but I couldn't produce this. Thanks for doing this.


Day summary message formatting

have a fixed structure returned from the backend, force gpt to follow a specific structure

Please mention this issue in your PR, so that we can see them(issue + PR) linked together :)  @mdmohsin7


Update index.html

Link to my profile.

@i-m-ishika  contribute here https://github.com/Ishaan28malik/Get-Dev-Resources


issue in  perform Protractor testing in md-option

I have the code in angular which is
<md-input-container>
  <label>Country </label>
    <md-select name="country" ng-model="country"required >
     <md-optgroup label="Select Country">
      <md-option ng-repeat="item in countryList"  ng-value="item" >
                 {{item.countryName}}
         </md-option>
       </md-optgroup>
     </md-select>
</md-input-container>

and in have used the code in Protractor as following
 element(by.model("country")).click();
 browser.sleep(2000);
 element.all(by.repeater("item in countryList").row('1')).click();

and I am always getting the game error as

Failed: element not visible

in the code the element(by.model("country")).click() is working fine but not selecting the md-option inside the  popup window. Please help.

Please keep GitHub issues for bug reports / feature requests. Better avenues for troubleshooting / questions are stack overflow, gitter, mailing list, etc.

@donroyco Sorry for asking Question in Github.  I  have open this issue only because no one responding to this question. https://stackoverflow.com/questions/49049211/how-to-perform-protractor-testing-in-md-option


Problem consultation

I want to know if this abnormal error is related to an input error in prompt? Why is text_tokens displayed as empty? How should we solve this problem? Waiting for your answer, good luck！

I want to know the reason for this error and how to solve it?

I want to know if this is due to a missing pkl file or other issues. How should I solve this problem


How to get pivot point of a complexe body ?

Hello, not sure if is the right place to ask a question, I apologize if it is not the case.
First some context, I use matter.js in a graphical library I write (https://github.com/DzzD/TIGLDemo) wich is not intended to run into a web browser, it is intended to be used in Titanium mobile application wich embed its own JavaScript engine (I said that because everything related to webbrowser are useless in my case and even if it is possible to compile matter.js without that I would love that).

Anyway here is my (simple) question, how to I find the pivot point of a body ?
Let me be more precise, for rendering my engine needs posx, posy, pivotx, pivoty, rotation, this is easy with rectangle/circle & standard sprite as I set the pivot to width/2 and height/2 but I cant figure how to do with more complexe body ? what should I set as the pivot point ?
Thanks

The body.position is the point the body rotates about, which is the centre of mass by default (in world space). The angle about that point is body.angle. Does that help?

The body.position is the point the body rotates about, which is the centre of mass by default (in world space). The angle about that point is body.angle. Does that help?

Yes I understand that the body.position is  also the center of rotation, but it seems that the vertices are translated (by minus the center of mass) after creation and I dont know how much they are translate except for simple cases : rectangle, circle

Yes I understand that the body.position is  also the center of rotation, but it seems that the vertices are translated (by minus the center of mass) after creation and I dont know how much they are translate except for simple cases : rectangle, circle

How are you creating the bodies?
If it's using Bodies.fromVertices then the vertices are translated such that their centre of mass is now at the point body.position. You can find that offset using the bounds after creation e.g. Vector.sub(body.position, body.bounds.min) if the vertices were about (0, 0) originally.

How are you creating the bodies?
If it's using Bodies.fromVertices then the vertices are translated such that their centre of mass is now at the point body.position. You can find that offset using the bounds after creation e.g. Vector.sub(body.position, body.bounds.min) if the vertices were about (0, 0) originally.

Ok I think this is probably what I am looking for. but is that true even if no vertices was set to 0,0 when created the body ? does that means that the center of mass is always the body's bounds center ?
For now I only create body from rectangle or circle as I did not know how to properly center/set pivot to them.
Let say I have those vertices :
200, 100
200, 200
100, 200
And that I create a body at position 0,0.
The mass center is (500/3, 500/3) = 166, 166
Vertices will be translate to satisfy the fact that center of mass must be at 0,0 (body position) so they will be translated by -166, 166 wich does not seems to corespond to min bounds limits wich is 100, 100.

Ok I think this is probably what I am looking for. but is that true even if no vertices was set to 0,0 when created the body ? does that means that the center of mass is always the body's bounds center ?
For now I only create body from rectangle or circle as I did not know how to properly center/set pivot to them.
Let say I have those vertices :
200, 100
200, 200
100, 200
And that I create a body at position 0,0.
The mass center is (500/3, 500/3) = 166, 166
Vertices will be translate to satisfy the fact that center of mass must be at 0,0 (body position) so they will be translated by -166, 166 wich does not seems to corespond to min bounds limits wich is 100, 100.

Ah the key for that working is that the bounding box of your original input vertices was aligned to be bottom-right of the origin (0, 0), which is how a lot of tools will export.
But in the general case, if the original bounds have some other offset, then you will need to account for that by first finding the original bounds of the input vertices (e.g. Bounds.create can help) then subtract the same point on both bounds to find the translation vector relative to the original.
I realise though it's not obvious that this is the case, so I'll think of ways to document or return that vector.

Thanks, this should works, but as you suggested an helper method/properties would be welcome


Bug in ray reflection on spheres with DiffuseBRDF

I open this issue in an attempt to resolve a bug that has been present since the beginning of PR #6 and has inevitably propagated to PR #8, #10, and #11. In all the images displayed in these PRs, please note that the diffuse spheres actually reflect other nearby objects. The reflection in question is not as sharp as it should be for a SphereBRDF, which suggests a bug in the Sphere or BRDF class. I am providing an image below that clearly demonstrates this phenomenon:

A situation where this issue was already clearly noticeable is the following:
Originally posted by @matteopicciolini in https://github.com/matteopicciolini/ray_tracing/issues/10#issuecomment-1565585561

After 3 days of intense debugging, I have resolved the issue.
A brief account of these challenging three days:
Firstly, the bug does not only apply to Spheres but to all the child classes of Shape. After thoroughly inspecting the Sphere class multiple times, I couldn't find any errors. In fact, in the image provided in the description of this PR, there are strange blue shadows on the checkered sphere, most likely due to an error in the BRDF class or one of its child classes. Nonetheless, the DiffusiveBRDF class seemed to have no issues, both in tests and logical steps.
I suspected that the culprit could be the PCG class, as it might have been generating correlated random numbers due to some bug. However, even after using the Java Random number generator, the output image still exhibited the same error.
I then traced the path of a dozen incident rays on the diffuse sphere and observed through Gnuplot that they indeed showed a preferred scattering direction. Thus, I rechecked the DiffusiveBRDF class, again and again...
The bug:
The DiffusiveBRDF class uses the scatterRay method to determine the direction of the outgoing ray. In a diffuse material, the direction should be randomly selected, but to do so, two additional vectors along with the surface normal at that point, forming an orthonormal basis, need to be found. This operation is not directly handled by DiffusiveBRDF but by ONB, a class called within DiffusiveBRDF.
ONB is precisely the critical class that caused the bug in this issue. In fact, for it to work, this class requires a normalized object of type Normal as input. However, the code never performs the normalization, neither before calling ONB nor inside the constructor of ONB. Nevertheless, all the tests were successfully executed because the input Normal vectors are normalized using normalize method before calling ONB! The fact that the surface normal is not normalized causes ONB to output vectors with a preferred direction, resulting in the error that led to this issue.
Below, I present the corrected image as described in the issue.


Dalstone Release

is there any expected date for Dalstone M1 ?

Updated milestones here https://github.com/spring-cloud/spring-cloud-release/milestones?with_issues=no


Small error in the wiki

https://github.com/tkaitchuck/aHash/wiki/How-aHash-is-resists-DOS-attacks

So there is know way to 'cancel' out the differential by any way short of guessing or knowing the key for the upper portion of the state.

(emphasis mine)
Should this have been "no" or something else?

Yup. Fixed.

Yup. Fixed.


REACT:Import Text From Doc or txt file📄

Implementing something similar to this on the current React Webpage

https://smaranjitghose.github.io/doc2pen/

I would like to work on this issue.

I would like to work on this issue.

I would like to work on this issue.

Deadline: within next 4 days
Do it only for importing text from .txt files. Leave .doc files for now

I would like to work on this issue.

Deadline: within next 4 days
Do it only for importing text from .txt files. Leave .doc files for now

@smaranjitghose I'd like to work on it, kindly assign if it's available.

@smaranjitghose I'd like to work on it, kindly assign if it's available.

Implementing something similar to this on the current React Webpage

https://smaranjitghose.github.io/doc2pen/

@smaranjitghose may I know where is the code for doc2pen.smaranjitghose.codes/ which I can use as reference. As I couldn't find any branch for it?

Implementing something similar to this on the current React Webpage

https://smaranjitghose.github.io/doc2pen/

@smaranjitghose may I know where is the code for doc2pen.smaranjitghose.codes/ which I can use as reference. As I couldn't find any branch for it?

Implementing something similar to this on the current React Webpage

https://smaranjitghose.github.io/doc2pen/

@smaranjitghose may I know where is the code for doc2pen.smaranjitghose.codes/ which I can use as reference. As I couldn't find any branch for it?

We have it on the base branch. However, feel free to go ahead with the work without that reference. When the issue was raised, the react version was not developed into what we have now

Implementing something similar to this on the current React Webpage

https://smaranjitghose.github.io/doc2pen/

@smaranjitghose may I know where is the code for doc2pen.smaranjitghose.codes/ which I can use as reference. As I couldn't find any branch for it?

We have it on the base branch. However, feel free to go ahead with the work without that reference. When the issue was raised, the react version was not developed into what we have now

@smaranjitghose please review my pull request #449


fix(ios): fix Time.h patch not being applied

Summary
The path to Time.h is currently hard-coded and does not take into
consideration the --project-directory flag when running pod install.
Changelog
[iOS] [Fixed] - Fix Time.h patch not being applied when running pod install --project-directory=ios
Test Plan
git clone https://github.com/microsoft/react-native-test-app.git
cd react-native-test-app
npm run set-react-version main
yarn
cd example
pod install --project-directory=ios
../scripts/xcodebuild.sh ios/Example.xcworkspace build

@lunaleaps, @kelset: Please also backport this to 0.67 as it is a regression.


Csf/mask conv

add mask conv

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.caishaofan seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


Make a thunderbird version

I think it's pretty cool if it is also available for thunderbird...

You don't open links in Firefox?

I see what you are suggesting here, but the links in the mail are hard to view because of the redirection thing -- it is harder to, for example, search mails.

I think you misunderstood what this add-on is doing, links in a document are not actually changed. Only when a request to a URL is made, are hidden/encoded URLs extracted from the original URL and the request to that one made instead. So I don't think it would help for your use case.

@sblask Thanks, I see. It's good to know!


Restrict characters allowed in option admin names

Currently waiting for a discussion at the governance committee meeting.
Building on #4862, restrict option admin names to a-z, A-Z,0-9, hyphens, and dashes.
Existing option admin names would be unaffected.
The goal is to make it easier to write code that processes these admin names. For example, writing SQL to target option_1 is much easier then option "alpha" #1.

It would be nice to have a way to audit and alter all the admin names for the question options.  Because initially, the admin names are the verbose human typed sentence, the vast majority of them will be "not great" for use as CSV column names.
It would be nice if we could clean up all the admin names before moving forward with using the API and data export.  Changing the admin names would certainly be something that would break any existing automations that expected certain column names; however, it would be best to get that pain over early and all at once.

@inghamn I agree that the initial admin names aren't great for use as CSV column names or values in the JSON export, but as you noted, we didn't want to break any existing integrations.
As a workaround: While the admin names for an existing question option can't be changed, you can change the admin name by removing and re-adding the option.

The character restriction makes perfect sense, I don't see any problems with the character restriction.
You are correct in identifying that the people coming up with the questions are not the people who would be able to provide a good column label for integrations.  It is my experience that column label problems are revealed much later when attempting integrations.


Undefined behavior?

I am trying to understand what happens when I hash an 8 byte message.
As far as I can tell, kh_lpu64ec_l3 accesses memory outside my message.  Is that correct?  If yes, then that is undefined behavior and can lead to an IllegalAccess exception.
If I have no need for cryptographic properties, what is the reason for the elaborate "final byte" processing?  What harm would come from padding with all zeros or all ones or any other constant?

Well, you are not correct. In case of 8-byte message kh_lpu64ec_l3() is called with argument MsgLen - 8, which is zero, and MsgLen+8. Msg3 = Msg + MsgLen - 3; puts the read pointer to the last 3 bytes of message, that are read, and then shifted into inexistence by m >> ( 24 - ml8 ). While this looks unreasonable, it's a micro-optimization.
"Final byte" inserted by komihash improves statistical quality. It is similar to a final bit in SHA-256 algorithm, for example.

Aleksey,
Thank you for the quick reply and explanation.
/john
On Sun, Jun 26, 2022 at 11:10 PM Aleksey Vaneev @.***>
wrote:

Well, you are not correct. In case of 8-byte message kh_lpu64ec_l3() is
called with argument MsgLen - 8, which is zero, and MsgLen+8. Msg3 = Msg

MsgLen - 3; puts the read pointer to the last 3 bytes of message, that
are read, and then shifted into inexistence by m >> ( 24 - ml8 ). While
this looks unreasonable, it's a micro-optimization.

"Final byte" inserted by komihash improves statistical quality. It is
similar to a final bit in SHA-256 algorithm, for example.
—
Reply to this email directly, view it on GitHub
https://github.com/avaneev/komihash/issues/7#issuecomment-1166785363,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAJ6DGYH64A76XXPHWMPCT3VRELQ3ANCNFSM5Z4SJUNQ
.
You are receiving this because you authored the thread.Message ID:
@.***>

--
John Yates
505 Tremont St, #803
Boston, MA 02116


Unable to run make with nginx-1.23.2

Dear Team,
I am using an Ubuntu machine to  compile the module and get a strange error at line  1502
Can you please advise how to proceed?
https://github.com/chobits/ngx_http_proxy_connect_module/blob/3930c7e43895ed6578845d9a31f400b949914a67/ngx_http_proxy_connect_module.c#L1502
make
make -f objs/Makefile
make[1]: Entering directory '/home/user/nginx/nginx-1.23.2'
cc -c -pipe  -O -W -Wall -Wpointer-arith -Wno-unused-parameter -Werror -g   -I src/core -I src/event -I src/event/modules -I src/os/unix -I objs -I src/http -I src/http/modules
-o objs/addon/ngx_http_proxy_connect_module/ngx_http_proxy_connect_module.o
../ngx_http_proxy_connect_module/ngx_http_proxy_connect_module.c
../ngx_http_proxy_connect_module/ngx_http_proxy_connect_module.c: In function 'ngx_http_proxy_connect_handler':
../ngx_http_proxy_connect_module/ngx_http_proxy_connect_module.c:1502:30: error: 'ngx_http_request_t' {aka 'struct ngx_http_request_s'} has no member named 'connect_host'; did you mean 'connection'?
1502 |             url.url.len = r->connect_host.len;
|                              ^~~~~~~~~~~~
|                              connection
../ngx_http_proxy_connect_module/ngx_http_proxy_connect_module.c:1503:31: error: 'ngx_http_request_t' {aka 'struct ngx_http_request_s'} has no member named 'connect_host'; did you mean 'connection'?
1503 |             url.url.data = r->connect_host.data;
|                               ^~~~~~~~~~~~
|                               connection
../ngx_http_proxy_connect_module/ngx_http_proxy_connect_module.c:1507:26: error: 'ngx_http_request_t' {aka 'struct ngx_http_request_s'} has no member named 'connect_host'; did you mean 'connection'?
1507 |         url.url.len = r->connect_host.len;
|                          ^~~~~~~~~~~~
|                          connection
../ngx_http_proxy_connect_module/ngx_http_proxy_connect_module.c:1508:27: error: 'ngx_http_request_t' {aka 'struct ngx_http_request_s'} has no member named 'connect_host'; did you mean 'connection'?
1508 |         url.url.data = r->connect_host.data;
|                           ^~~~~~~~~~~~
|                           connection
../ngx_http_proxy_connect_module/ngx_http_proxy_connect_module.c:1511:27: error: 'ngx_http_request_t' {aka 'struct ngx_http_request_s'} has no member named 'connect_port_n'; did you mean 'connection'?
1511 |     url.default_port = r->connect_port_n;
|                           ^~~~~~~~~~~~~~
|                           connection
../ngx_http_proxy_connect_module/ngx_http_proxy_connect_module.c:1556:55: error: 'ngx_http_request_t' {aka 'struct ngx_http_request_s'} has no member named 'connect_port_n'; did you mean 'connection'?
1556 |     u->resolved->port = (in_port_t) (url.no_port ? r->connect_port_n : url.port);
|                                                       ^~~~~~~~~~~~~~
|                                                       connection
In file included from src/core/ngx_core.h:60,
from ../ngx_http_proxy_connect_module/ngx_http_proxy_connect_module.c:7:
../ngx_http_proxy_connect_module/ngx_http_proxy_connect_module.c:1592:27: error: 'ngx_http_request_t' {aka 'struct ngx_http_request_s'} has no member named 'connect_host'; did you mean 'connection'?
1592 |                       &r->connect_host);
|                           ^~~~~~~~~~~~
src/core/ngx_log.h:86:67: note: in definition of macro 'ngx_log_error'
86 |     if ((log)->log_level >= level) ngx_log_error_core(level, log, VA_ARGS)
|                                                                   ^~~~~~~~~~~
../ngx_http_proxy_connect_module/ngx_http_proxy_connect_module.c: In function 'ngx_http_proxy_connect_allow_handler':
../ngx_http_proxy_connect_module/ngx_http_proxy_connect_module.c:1668:41: error: 'ngx_http_request_t' {aka 'struct ngx_http_request_s'} has no member named 'connect_port_n'; did you mean 'connection'?
1668 |             if ((ports[i][1] == 0 && r->connect_port_n == ports[i][0])
|                                         ^~~~~~~~~~~~~~
|                                         connection
../ngx_http_proxy_connect_module/ngx_http_proxy_connect_module.c:1669:39: error: 'ngx_http_request_t' {aka 'struct ngx_http_request_s'} has no member named 'connect_port_n'; did you mean 'connection'?
1669 |                 || (ports[i][0] <= r->connect_port_n && r->connect_port_n <= ports[i][1]))
|                                       ^~~~~~~~~~~~~~
|                                       connection
../ngx_http_proxy_connect_module/ngx_http_proxy_connect_module.c:1669:60: error: 'ngx_http_request_t' {aka 'struct ngx_http_request_s'} has no member named 'connect_port_n'; did you mean 'connection'?
1669 |                 || (ports[i][0] <= r->connect_port_n && r->connect_port_n <= ports[i][1]))
|                                                            ^~~~~~~~~~~~~~
|                                                            connection
../ngx_http_proxy_connect_module/ngx_http_proxy_connect_module.c:1677:16: error: 'ngx_http_request_t' {aka 'struct ngx_http_request_s'} has no member named 'connect_port_n'; did you mean 'connection'?
1677 |         if (r->connect_port_n == 443 || r->connect_port_n == 563) {
|                ^~~~~~~~~~~~~~
|                connection
../ngx_http_proxy_connect_module/ngx_http_proxy_connect_module.c:1677:44: error: 'ngx_http_request_t' {aka 'struct ngx_http_request_s'} has no member named 'connect_port_n'; did you mean 'connection'?
1677 |         if (r->connect_port_n == 443 || r->connect_port_n == 563) {
|                                            ^~~~~~~~~~~~~~
|                                            connection
make[1]: *** [objs/Makefile:1204: objs/addon/ngx_http_proxy_connect_module/ngx_http_proxy_connect_module.o] Error 1
make[1]: Leaving directory '/home/user/nginx/nginx-1.23.2'
make: *** [Makefile:10: build] Error 2

Tested with previous version. nginx-1.22.1 works fine.

The compilation error from your issue means that the proxy connect patch had not been patched, so there is no connect_host field in r structure.

ngx_http_request_s'} has no member named 'connect_host'; did you mean 'connection'?
1502 | url.url.len = r->connect_host.len;

Did you forget to patch on nginx-1.23.2?

I got same compilation error when I compiled 1.23.2 without the patch .
If I patched it, then it worked and passed t/ test cases.

Im closing this issue, feel free to reopen if u still have .


[FRONTEND][BACKEND] Add the noinline annotation for triton.jit

Introducing the noinline Parameter for Triton JIT Decorator
We're excited to introduce a new parameter, noinline, that can be added to the jit decorator in Triton. This parameter allows developers to specify that a particular Triton function should not be inlined into its callers. In this post, we'll dive into the syntax, purpose, and implementation details of this new feature.
Syntax
To use the noinline parameter, simply add noinline=True to the jit decorator for the function that you don't want to be inlined. Here's an example:
@triton.jit(noinline=True)
def device_fn(x, y, Z):
    z = x + y
    tl.store(Z, z)

def test_noinline():
    @triton.jit
    def kernel(X, Y, Z):
        x = tl.load(X)
        y = tl.load(Y)
        device_fn(x, y, Z)

In this example, the device_fn function is decorated with @triton.jit(noinline=True), indicating that it should not be inlined into its caller, kernel.
Purpose
The noinline parameter serves several key purposes:

Reducing code size: By preventing inlining, we can reduce the size of the compiled code.
Facilitating debugging: Keeping functions separate can make it easier to debug the code.
Avoiding common subexpression elimination (CSE) in certain cases: CSE can sometimes be avoided by using the noinline parameter to reduce register pressure.
Enabling dynamic linking: This parameter makes it possible to dynamically link Triton functions.

Implementation
The implementation of the noinline parameter involves significant changes to three analysis modules in Triton: Allocation, Membar, and AxisInfo. Prior to this update, these modules assumed that all Triton functions had been inlined into the root kernel function. With the introduction of non-inlined functions, we've had to rework these assumptions and make corresponding changes to the analyses.
Call Graph and Limitations

To address the changes, we build a call graph and perform all the analyses on the call graph instead of a single function. The call graph is constructed by traversing the call edges and storing them in an edge map. Roots are extracted by checking nodes with no incoming edges.
The call graph has certain limitations:

It does not support recursive function calls, although this could be implemented in the future.
It does not support dynamic function calls, where the function name is unknown at compilation time.

Allocation

In Triton, shared memory allocation is achieved through two operations: triton_gpu.convert_layout and triton_gpu.alloc_tensor. The convert_layout operation allocates an internal tensor, which we refer to as a scratch buffer, while the alloc_tensor operation returns an allocated tensor and is thus known as an explicit buffer.
To accommodate the introduction of function calls, we are introducing a third type of buffer called a virtual buffer. Similar to scratch buffers, virtual buffers are allocated internally within the scope of a function call, and the buffers allocated by the called functions remain invisible to subsequent operations in the calling function. However, virtual buffers are distinct from scratch buffers in that the call operation itself does not allocate memory—instead, it specifies the total amount of memory required by all the child functions being called. The actual allocation of buffers is performed by individual operations within these child functions. For example, when invoking edge e1, no memory is allocated, but the total amount of memory needed by function B is reserved. Notably, the amount of shared memory used by function B remains fixed across its call sites due to the consideration of dynamic control flows within each function.
An additional challenge to address is the calculation of shared memory offsets for functions within a call graph. While we can assume a shared memory offset starting at 0 for a single root function, this is not the case with a call graph, where we must determine each function's starting offset based on the call path. Although each function has a fixed memory consumption, the starting offset may vary. For instance, in Figure 2, the starting offset of function C through edges e1->e2 differs from that through edges e2->e4. To handle this, we accumulate the starting offset at each call site and pass it as an argument to the called function. Additionally, we amend both the function declaration and call sites by appending an offset variable.
Membar

The membar pass is dependent on the allocation analysis. Once the offset and size of each buffer are known, we conduct a post-order traversal of the call graph and analyze each function on an individual basis. Unlike previous analyses, we now return buffers that remain unsynchronized at the end of functions, allowing the calling function to perform synchronization in cases of overlap.
AxisInfo

The AxisInfo analysis operates differently from both membar and allocation, as it traverses the call graph in topological order. This is necessary because function arguments may contain axis information that will be utilized by callee functions. As we do not implement optimizations like function cloning, each function has a single code base, and the axis information for an argument is determined as a conservative result of all axis information passed by the calling functions.

Thank you! Very excited about this new feature.

Hi @Jokeren thank you a lot for this PR. If I may, the post is really good and useful for people like me with very incomplete understanding of the backend. Do you plan to store it (and similar if any) in a doc somewhere ?

Thank you. Certainly, as requested, we can consider creating ASCII art that is integrated into the code.
Additionally, if you notice that it enhances the performance of your code (for example, with 'stream-k'), we could potentially create a tutorial on the topic. Currently, we've observed that it helps circumvent certain instruction scheduling challenges and improves performance by approximately 2% to 5%.


pico: revert using nano.specs

I added this to avoid bloat from exception related stuff in libstdc++, but there's a problem.

newlib-nano is usually built with -Os, this results in disabling the optimised memcpy/memset/... implementations.
The fallback implementation just copy/fill bytes. Very small, but not fast.
RP2040 has an optimised memcpy/memset in the bootrom so these aren't used in the end. RP2350 does not... so they do.
GCC tries to be smart and optimises anything that looks like a memcpy to a memcpy (similar for memset), but if you were copying words it makes it 4x slower.

So, this goes back to the default but tries to keep most of the space savings by avoiding the default terminate handler.
For a somewhat extreme performance comparison, this is 15 -> 10ms on my 3d engine (rasterise time).
Size comparison:
logo before (with nano.specs)
  text    data     bss     dec     hex filename
282432       0  319696  602128   93010 examples/logo/logo.elf

logo without nano.specs
  text    data     bss     dec     hex filename
313484       0  320524  634008   9ac98 examples/logo/logo.elf

(ouch, +31k)
logo after (without nano.specs, overridden terminate handler)
  text    data     bss     dec     hex filename
288736       0  320516  609252   94be4 examples/logo/logo.elf

(just +6.3k)
(32blit-stm32 has a similar problem, which we can fix there by rebuilding our custom newlib with -O2 (+3k on logo, +2.4k on firmware))

I am reminded of this video which I need to watch again - https://www.youtube.com/watch?v=bY2FlayomlE
Judging by your findings here, I should probably not be using https://github.com/pimoroni/pimoroni-pico/blob/main/micropython/modules/micropython-disable-exceptions.cmake in MicroPython builds 😬

It does seem to depend on the toolchain (I got the fast memcpy when I tried the default ubuntu toolchain, but not with the default arch one), but yeah...
The only way to be sure is digging in the disassembly:

I need to see if there's any huge wins on stm32 stuff as we've been using the slow copies since adding the PIC stdlibs, maybe even before that :thinking:


Caching NPM modules

Note
Issues in this repo are for tracking bugs, feature requests and questions for the tasks in this repo
For a list:
https://github.com/Microsoft/azure-pipelines-tasks/tree/master/Tasks
If you have an issue or request for the Azure Pipelines service, use developer community instead:
https://developercommunity.visualstudio.com/spaces/21/index.html )
Required Information
Entering this information will route you directly to the right team and expedite traction.
Question, Bug, or Feature?
Type: Question
Enter Task Name: Cache@2
list here (V# not needed):
https://github.com/Microsoft/azure-pipelines-tasks/tree/master/Tasks
Environment

Server - Azure Pipelines or TFS on-premises?

Azure Pipelines

Agent - Hosted or Private:

windows-2019

Issue Description
I'm attempting to add Cache@2 to our pipeline, and everything appears to be succeeding as far as I can tell (both the Cache task and post-job:Cache task); however, either the cache is not saving anything or it's not being used.
Here's the relevant configuration:
pool:
  name: Azure Pipelines
variables:
  npm_config_cache: '$(Pipeline.Workspace)/.npm'

steps:
- task: NodeTool@0
  displayName: 'Use Node 12.x'
  inputs:
    versionSpec: 12.x

- task: Cache@2
  displayName: 'Cache npm'
  inputs:
    key: 'npm | "$(Agent.OS)" | $(System.DefaultWorkingDirectory)/WebGui/package-lock.json'
    path: '$(npm_config_cache)'
    restoreKeys: |
     npm | "$(Agent.OS)"
     npm

- task: Npm@1
  displayName: 'npm ci'
  inputs:
    command: ci
    workingDir: WebGui
    verbose: false

Is there something obvious I'm missing in terms of ordering, or another setting?
The cache hits and downloads 129.6mb of data (although looking locally at my application node_modules folder, it's at 373mb), but the npm ci (or npm install) task takes about the same amount of time prior to the cache step being added: around 5 minutes
Task logs
[Enable debug logging and please provide the zip file containing all the logs for a speedy resolution]
Troubleshooting
Checkout how to troubleshoot failures and collect debug logs: https://docs.microsoft.com/en-us/vsts/build-release/actions/troubleshooting
Error logs
[Insert error from the logs here for a quick overview]

Perhaps this snippet in the documentation?
https://docs.microsoft.com/en-us/azure/devops/pipelines/release/caching?view=azure-devops#nodejsnpm
Tip
Because npm ci deletes the node_modules folder to ensure that a consistent, repeatable set of modules is used, you should avoid caching node_modules when calling npm ci.
Or, this stackoverflow question:
https://stackoverflow.com/questions/55230628/is-there-a-way-to-speedup-npm-ci-using-cache

Thanks @selangley-wa !
Assuming I'm reading it correctly, I think the note is more referring to not caching the application's node_module folder, opposed to a central .npm cache folder (otherwise you'd think the example above it would use npm i opposed to npm ci)
I'm going to close this issue out:  a few days ago we needed to move our build to an internal pool, and so the caching hasn't been as big of an issue since we have a smaller set of known servers that eventually have the modules cached over time

Yes, you are right @jayoungers. You are not caching node_modules.
This also may be applicable with its discussion of getting the cache keys right:
https://stackoverflow.com/questions/59487604/caching-npm-dependencies-in-azure-pipeline-for-in-built-windows-latest-image

I have exactly the same issue with caching npm-cache folder, either by using default %AppData%\npm-cache or setting npm_config_cache environment variable. It seems like Cache@2 task is working as designed. but there is problem with populating npm cache folder.
It downloads to cache only certain packages and it is reproducible every time (the same amount of packages are downloaded).
On my machine, locally cache is populated 100% with every dependency from package.json. On windows-2019 not.


Issue 176 many one

Description
Many particles implemented for the case where the boundary condition is not a function of x. I think implementing the x dependence should be a separate issue so that other parts of the code can be worked on.
Fixes #176
Type of change
Please delete options that are not relevant.

[x] New feature (non-breaking change which adds functionality)

Key checklist:

[x] No style issues: $ flake8
[x] All tests pass: $ python run-tests.py --unit
[x] The documentation builds: $ cd docs and then $ make clean; make html

You can run all three at once, using $ python run-tests.py --quick.
Further checks:

[x] Code is commented, particularly in hard-to-understand areas
[x] Tests added that prove fix is effective or that feature works
[] Any dependent changes have been merged and published in downstream modules

Codecov Report

Merging #211 into master will decrease coverage by <.01%.
The diff coverage is 98.56%.

@@            Coverage Diff             @@
##           master     #211      +/-   ##
==========================================
- Coverage   97.76%   97.76%   -0.01%
==========================================
  Files          44       44
  Lines        1838     1923      +85
==========================================
+ Hits         1797     1880      +83
- Misses         41       43       +2

Impacted Files
Coverage Δ

pybamm/expression_tree/binary_operators.py
99.16% <ø> (ø)
:arrow_up:

pybamm/meshes/meshes.py
100% <100%> (ø)
:arrow_up:

pybamm/parameters/parameter_values.py
100% <100%> (ø)
:arrow_up:

pybamm/geometry/geometry.py
100% <100%> (ø)
:arrow_up:

pybamm/discretisations/discretisation.py
100% <100%> (ø)
:arrow_up:

pybamm/expression_tree/broadcasts.py
100% <100%> (ø)
:arrow_up:

pybamm/expression_tree/concatenations.py
100% <100%> (ø)
:arrow_up:

pybamm/spatial_methods/finite_volume.py
98.7% <97.53%> (-1.3%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 10f0fee...4753caa. Read the comment docs.

@martinjrobins would be great to get your input on this


New flow MVP

Just had a look and noticed a few journey/flow blocking issues

Shades not working
When nano is chosen, doesn’t prompt for multi-item question
pH range when multi-item is mixed - returns service error
When multi-item and I choose Items in sequence it is returning system error
Couldn’t complete the multi-item task due to the above system error
Not able to submit product yet, accept and submit isn’t implemented I think.

A few minor issues spotted

When re-visit the completed task, it doesn’t retain the selected value for the below questions

Shades information

Internal reference

Does the product has  Nanomaterials yes/no

What is the product contained in

CMRs

Uploaded ingredients file

When notification is chosen single item and I revisit it pre-selects multi-item yes and with count 1, expected to pre-select “No, this is a single product”

When nothing chooses on multi-item no validation and on the task list page, product task is completed but shows product details can’t start yet

Back link isn't working on enter product name page, expected to return to summary page

View draft link is returning system error when product details aren't entered yet. I suggest this link should only be visible when certain details are entered.

Spotted a few more issues
I create the product as a single item and complete product details and, When I click created product(first task) and select as multi-item, then I see multi-item is showing as completed. I can submit the notification with empty items.
No backlink on the task list page.
In the multi-item count label, the text should read as item( Darren suggested wording in slack)
On the task list page, the component section to read as Item instead of component


[FEATURE] I Will Add Email Password Authentication

Description
I will add email Password Authentication
Screenshots
No response

@flyingsonu122 Please assign the task.

do your work, everything will be taken care off

@flyingsonu122  I am done with adding the Email Auth functionality, and is working the exact way it should work. But due to some reason I again forked and clone your repo, and now i cant see home page where songs play will appear.

@flyingsonu122 please check discord DM. I have some queries and doubts. It would be Hard to all here. So I have DMd you on discord


Decision: Postcolonization issues

Forum Post
In essence, postcolonization is good because it guides north american countries to assume something of a proper shape, but causes major issues in africa - countries there form and secede before their respective regions are even colonized fully, causing bordergore and allowing the player to (for example) lose a single kongo state on secession but then colonize and keep the rest.
Postcolonization in Africa must be moved post 1900, once it's complete.
Another example where it affects europe, with coutries like LIP seceding for no good reason. On CK2 games where there is no Germany (and may not be any german culture) having LIP declare independence is silly.

The postcol decisions are at player's discretion. It's up to them to decide when should Africa be split up.

Fully agree. However, the North America part of the postcol decision is what shapes USA, Canada etc towards historical form, and enabling that post 1900s makes little difference (too late). Is there any chance to separate these by continents - the american ones into Manifest Destiny decision ideally selectable early, dropping european and leaving only africa in postcol to be used post 1900s?

The Americas decision is the one at game start, allowed to be chosen only until you reach 1837. By choosing it, the player says they are not against some historical railroading.
The Africa decision is separate, available since 1880s to game end, but you aren't given the option if you refuse the Americas one.
There's no "European" postcol decision. You may be thinking about the event that redistributes some Middle Eastern cores (Cyprus, Crete, Palestine, etc.). It is needed because otherwise Iraq would lay cores on all of Northern Arabia

Ahah, found the bug then, probably. American decision sets der_postcolonialism flag.
In events/postcolonial.txt Congo for example checks for this flag and then secedes immediately in 1826. It should be checking for der_postcolonialism2 flag which is set by the second decision. Same goes for South Africa, Oranje etc.
To be perfectly hones, I've ran about 10? 15? megacampaigns in the last year and not once had I ever seen the second decision making me wonder does it even show up? This is the first I've seen it and only by checking the files, huh.

Closing issue as this was addressed already by @IohannesIohannium.


Fix(CIV-677): Fixed all responses being recorded as anonymous responses while using new sign up flow.

What?
All the responses to any consultation created by users using the new authentication flow are being recorded as anonymous responses even when the user is verified and has marked the response as a public response.
Why?
Responses created by verified users and marked as public response should be recorded as a shared response.
How?
When a user submits a response, the response visibility is set to shared or anonymous based on two parameters:

If the user is verified or not
If the user has set response visibility to public or not

After that, it is checked if the user is authenticated or not. If the user is not authenticated, the response object is stored in local storage and an auth modal is shown to the user. After the user completes the authentication step, the response object is obtained from local storage, and an API request to create a response is made.
Now, as we are checking for authentication after we have set the visibility of the response, the status of user verification is always undefined, therefore response is always set to anonymous.
After this fix, only the status of response visibility set by the user is recorded in the response object initially, and the response visibility is reset after checking the authentication status and completing the authentication if required.
Testing?
Tested for the following scenarios:

New Auth flow - Verified User - Public Response
New Auth flow - Verified User - Private Response
New Auth flow - UnVerified User - Public Response
New Auth flow - UnVerified User - Private Response
Old Auth flow - Verified User - Public Response
Old Auth flow - Verified User - Private Response
Old Auth flow - UnVerified User - Public Response
Old Auth flow - UnVerified User - Private Response

Anything Else?
Currently, the logic for creating a response is present at multiple places resulting in a very bad developer experience and code duplicity. This should be resolved by creating a more streamlined flow.

After that, it is checked if the user is authenticated or not. If the user is not authenticated, the response object is stored in local storage and an auth modal is shown to the user. After the user completes the authentication step, the response object is obtained from local storage, and an API request to create a response is made.

Now, as we are checking for authentication after we have set the visibility of the response, the status of user verification is always undefined, therefore response is always set to anonymous.

After this fix, only the status of response visibility set by the user is recorded in the response object initially, and the response visibility is reset after checking the authentication status and completing the authentication if required.

Can we add some comments so that it's clear to someone reading just the code? One-liner comments should be enough

Done


Updated EncryptOptions queryType to be a String

Allows for support for future new options and is inline with algorithm
also not being an enum.
JAVA-4643
JAVA-4644

Updated the javadoc and manually merged.


using checked add issue #369

couple of places for mint using "+" has been replaced with checked_add to avoid overflow issues

It is a minor note, but I believe that having human readable PR names makes discovery easier. It is hard to get what this PR is about, without manually searching for issue. I mean, now it is easy, since context is fresh, but in 1 months time going through some git history will require couple extra steps to understand what was the purpose of this PR.

https://github.com/Sovereign-Labs/sovereign-sdk/issues/369


pdn: Remove deprecated -pin_direction flag in doc define_pdn_grid example.

pr-merge check has failed. What the best way to proceed in that case? Updating documentation launch the build (which fails pretty often) whereas it is not necessary (build fails often). I don't know any way to relaunch the checks. I'll rebase and force push now it is approved to relaunch them.

Checks pass now.


Module not found: Error: Cannot resolve module 'oauth'

I'm building a project which is a fork of electron-react-boilerplate.
I have added the github4 module to the packages.json file and ran npm i but when I start the server with npm run hot-server I have the following error :
ERROR in ./~/github4/test/oauth.js
Module not found: Error: Cannot resolve module 'oauth' in /home/zedtux/Developments/grrn/node_modules/github4/test
 @ ./~/github4/test/oauth.js 19:13-29

Of course, adding the oauth module to the package.json file solve the issue .. but it should be included as a dependency, shouldn't be ?

Awesome !


runtime: linux-riscv64-jsing failing with "signal: segmentation fault" during bootstrapping

2021-02-17T01:29:54-2f0da6d/linux-riscv64-jsing
2021-02-17T00:04:02-70c37ee/linux-riscv64-jsing
2021-02-16T22:18:37-8482559/linux-riscv64-jsing
2021-01-19T19:43:25-5f4716e/linux-riscv64-jsing
CC @4a6f656c

Superficially similar to #44332 , although hard to be sure since we don't get a backtrace. Why is that?

Looks like https://golang.org/cl/292894 fixed this
/cc @4a6f656c


Fixes issue with file uploading

The problem is that there is an invalid argument for Guzzle's post method. Bot can't upload files to users using form_params, so this fix makes bot to use multipart key.

I've finally tested it and it works perfectly!
Thanks so much @Livich 👍


TextField and other button gesture conflict

TextField have default text, when I tap TextField and focus on, keyboard appear, now DO NOT input any things, try to press RaisedButton want to execute send action but not affect.
contrary the TextField get the gesture and show text selection "paste / select all"
tested device: iPhone 6 plus / iPhone XS
requirements:
1、TextField must have default value: TextEditingController(text: 'mmm...initialize text');
2、TextField on focus don't input any thing
3、tap any other button, the issue appear

flutter doctor
[✓] Flutter (Channel beta, v1.7.8+hotfix.4, on Mac OS X 10.14.6 18G87, locale zh-Hans-CN)
    • Flutter version 1.7.8+hotfix.4 at /Users/development/flutter
    • Framework revision 20e59316b8 (3 weeks ago), 2019-07-18 20:04:33 -0700
    • Engine revision fee001c93f
    • Dart version 2.4.0

The problem is like this, when initializing you assign the value to the controller and trigger the TextField input event that accidentally happens to repeat it somewhere several times. TextField will understand it's a long press event. To resolve and avoid this problem, I recommend that you initialize aCtrl in the beginning and assign it to the initState function like this: aCtrl.text = 'mmm ... initialize text';
Hope it helps you !!!

Thanks for the respond. I have used your code but still have the problem.

fixed on Channel beta, v1.8.3