[EN+ DatetimeV2] 2-digit years in month-of-year construction not recognized

Describe the bug
"I was born in April of 87" returns "XXXX-04" (incorrect)
"I was born in April of 1987" returns "1987-04" (correct)
This affects other languages as well when 2-digit years are used, e.g. ES: "Nací en abril del 87"
Note: The month-of-year construction may not be a common business use case, though, since the day of the month is usually required when eliciting a date from the user.
To Reproduce

Run SimpleConsole for en-us
Type "I was born in April of 87"
The returned timex will be "XXXX-04"

Expected behavior
Returned timex should be "1987-04"
Sample input/output
I was born in April of 87
I found the following entities (2):
{
"Text": "87",
"Start": 23,
"End": 24,
"TypeName": "number",
"Resolution": {
"subtype": "integer",
"value": "87"
}
}
{
"Text": "april",
"Start": 14,
"End": 18,
"TypeName": "datetimeV2.daterange",
"Resolution": {
"values": [
{
"timex": "XXXX-04",
"type": "daterange",
"start": "2021-04-01",
"end": "2021-05-01"
},
{
"timex": "XXXX-04",
"type": "daterange",
"start": "2022-04-01",
"end": "2022-05-01"
}
]
}
}
Platform (please complete the following information):

Platform: .NET
Environment: console app
Version of package: 1.7.0

working on this


PLAT-2052 Creating a opslevel.yml file and bronzing

@mckaysalisbury is this work something you were thinking about adding to the repo/tool or using the extension for?
I would gladly help with getting the tool to a place where you need it/help with examples on how it may be used for your implementation use case


[BUG] Latest Istio version can't be deployed using the operator on OCP clusters

Is this the right place to submit this?

[X] This is not a question about how to use the sail-operator

Bug Description
Since profiles was changed upstream few weeks ago we can't deploy the latest Istio version on OCP cluster because we use profile=openshift in the operator to set everything to be able to run on OCP cluster. If we try to deploy a Istio or IstioCNI resource we are going to get this error:
failed to install helm chart cni: execution error at (cni/templates/zzz_profile.yaml:26:3):unknown profile openshift
Operator Version
master branch
Link to Gist with Logs
No response
Additional Information
No response

Will be fixed by https://github.com/istio/istio/pull/53574

This is now fixed.


Course Availability Warnings Out of Date

In some cases, when selecting a course, a warning will appear stating that it is not offered in a specific quarter, but then it will show past and current offerings for that quarter.

I'm gonna go ahead and deprecate this feature because the way we fetch quarters is significantly different now and uses the PISA API directly rather than our DB. This has enabled us with more accurate quarter offering data that might change compared to the static data we had in our database


Cursor does not change to default in disabled options

I am using select 3.5.3, and I notice that cursor does not change to default cursor when hovering on a disabled option.
My browser is chrome  44.0.2403.155.
It is reproducible at demo page (Disabled Options): http://select2.github.io/select2/

At this point it's probably not something that's going to be fixed in a future 3.x release, though it was fixed in 4.0.0.
Here's some CSS you can use to fix the issue
.select2-disabled .select2-result-label {
  cursor: default;
}


Add NATS as supported backend

This adds NATS as a supported backend. Since NATS has native support for storing KV in the bus it would be nice to store app configs there and be able to retrieve them with Viper. The plan is to add support in Viper after acceptance here.

@hooksie1 thank you for the contribution!
Can you please rebase your PR to resolve the conflicts? Thanks!

@sagikazarmark ok should be good now, thanks!


NEW - Add PrefixedSetting class

Codecov Report

Merging #11 into master will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff          @@
##           master    #11   +/-   ##
=====================================
  Coverage     100%   100%
=====================================
  Files           2      2
  Lines          71     79    +8
=====================================
+ Hits           71     79    +8

Impacted Files
Coverage Δ

pkgsettings/pkgsettings.py
100% <100%> (ø)
:arrow_up:

pkgsettings/__init__.py
100% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 16a3148...139ee5f. Read the comment docs.

Could you please add some info on the new class to the documentation? It would be nice to see some example use case in the docs so people are aware of the possibilities

@mattiassluis I added a doc paragraph to explain the PrefixedSettings to the README.rst file.

LGTM


Hardcoded SQL outside of Drivers

We came across some hardcode SQL outside of the Drivers. Specifically, the following is causing us issues:
https://github.com/boylesoftware/x2node-dbos/blob/master/lib/filter-builder.js#L389
SELECT TRUE FROM ... is not valid syntax in SQLite. It should probably be updated to SELECT 1 FROM ... so that it plays nice with more databases, or it should be moved to the driver classes so the syntax can be defined by database.

Good point. Will be moved to the drivers.

Cool. Do you guys know when you think it will be completed?

Done. Replaced TRUE with 1 to improve SQL compatibility.


improve documentation and add more examples and fix

Overview
Improve documentation
Changes

add more examples on ifs, squote, dquote
fix YAML sample description following the previous changes introduced by @dj4ngo

@dj4ngo please review the update and merge if everything work fine for you!


Multi-DC fabio

I'm building DC (aka Availability Zone) fault-tolerant setup with fabio, consul and ECS on AWS. I'm using active-active setup with separate consul cluster (3 nodes each) per DC.
In this setup I have multiple fabio instances behind ELB and services are running in both DC's at the same time. ELB uses round robin to spread load across fabio instances and it uses fabio http port for healthcheck.
The problem here is that in case of DC outage I can't be sure all services are running in each DC, so I would like fabio to be multi-DC aware and spread load across DC's, so I would have my service available even if it's not running in some DC.
I've implemented proof-of-concept in my fork (https://github.com/LibertyGlobal/fabio), it's hardcoded and ugly but it works. Idea is to create multiple goroutines with blocking query for each consul DC and when blocking query is over to query rest of datacenters and create config.
I can make a better version of that if I know that it can be accepted to upstream. @magiconair are you interested in such feature in fabio or I'm doing it wrong?

This sounds like a cool feature and I think someone requested something similar before. One approach I can think of is to build a combined routing table from multiple consul instances but make fabio prefer local services. Then you could decide whether to load balance across AZs or use this for fault tolerance. Might even be useful to have a weight parameter in there like send N% of traffic to other AZs.

Are prepared queries of any help here? https://www.consul.io/docs/agent/http/query.html
Just throwing a suggestion.

@dsolsona I think that goes in the right direction.

For load balancing, @ptqa 's solution of retrieving all services from all datacenters and combining them seems the only reliable way. For failover setups, prepared queries would work nicely, although the query has to be created beforehand in consul by either fabio or the user.
The reason for this split is that prepared queries only ever give services in non-local DC's when there are no healthy instances in their local DC. So there is no way to have prepared queries give back all the services in all DCs.
Conversely, it'll be hard to use any native consul methods to determine specific nearness of services in the combined list of multi-DC services. They can be sorted on nearness, probably, but then "manual" filtering on DC would need to happen and this could get ugly with more than 2 DCs.
The weight parameter is hard for the latter reason, but an optional switch between no multi-DC awareness, failover, and loadbalancing should be relatively easy.
I'll try to update the current POC to incorporate both idea.

One of the things I have in the works is splitting the registry into a kv and multiple discovery modules. This would allow you to configure multiple consul discovery instances (and kubernetes, docker, ...) all at the same time and the combination of them generates the routing table. I think this should solve this problem. @madeddie feel free to improve the POC but be aware that it might not get merged. In any case it could serve as a good basis for the discussion.

Your solution is the better solution by far, but I can use the practice :)

FYI in case folks don't watch every commit that rolls into Consul's code base, something very close to what you were looking for, @madeddie, was added to Consul not long ago: https://github.com/hashicorp/consul/commit/2b2464403f93134a05eb5946e0b223199d364aa8

Indeed.

That actually doesn't change anything I described :) Prepared queries don't show containers in all DCs, they show non-local-DC containers only when the local-DC containers are all unhealthy. Unless that's changed too, in which case I'd be very interested :D

Just to say that use case happens even if you don't have multiple datacenters.
AFAIK in a "consul datacenter" every agent must able to talk with eachother using the mesh protocol.
So, if you have multiple isolated VLANs with different webapps in each VLAN, you have to run a distinct "consul datacenter" in each VLAN.
I'd like a single fabio instance to be able to route trafic to the relevant VLANs. But for that it needs to discover the healthy services in the different "datacenters".

The feature will be very useful for us too!

We're currently doing something very similar with consul-template and HAProxy.  We let consul-template loop over all services in all DCs and enumerate them all as server lines under backend sections.  The services that are pulled from DCs NOT matching the local DC are added as backup under the backend block.  This is in effect a combination of a few of the above suggestions listing all services and having a weight attribute.

@leprechau I've been looking at doing something similar with HAProxy. How did you go about configuring this?

@leprechau Thanks for the info. How did you get around fabio not supporting multi-datacenters?

@leprechau But fabio is unable to detect services in another dc, so services would only be able to find other services within their own dc when using fabio? If so, that makes sense. I've been experimenting today and decided to stick with services only talking to their local services, using public domains to access other services if needed.

For those looking to use HAProxy, 1.8 added the ability to dynamically change backend destinations based on DNS SRV records. Might simplify writing out config files via consul-template

Is fabio now supported?

I'd like something similar but different. I'd like to have a single consul cluster but to have multiple nomad clusters (and/or nomad datacenters and regions) to separate work loads. If I point fabio at the consul cluster I'd get all jobs from all nomad clusters. The only solution I can think of is to abuse -registry.consul.tagprefix and give the different nomad clusters different prefixes.


why do i get this error?

Maybe.java:48: warning: [rawtypes] found raw type: Maybe
if (obj instanceof Maybe maybe) {
^
missing type arguments for generic class Maybe
where T is a type-variable:
T extends Object declared in class Maybe
1 warning
Grading terminated.

Maybe is a generic type...
Read this article

Maybe is a generic type, hence in this case, you will need to put Maybe etc.

Agreed, I think you need a type parameter
Maybe<Your Type> the types are String, Integer, etc... depending on your code

Any generic types need to have their type specified if not you will encounter the raw type error not just for Maybe

You need to specify the type arguments for Maybe as it is a raw type, hope this helps!

'Maybe' itself is a generic type. I think you will need to mention the type for it to run!

Maybe; it's especially important in Generics

note that it's a generic type, clearly stating the type is needed! try Maybe<?> maybe

should be comparing a against any typing with a Maybe wrapped around it, too make sure instanceof is used correctly.

Did all of these work?
If it did, great job @Nam3less-0! Also, as a courtesy, you might want to close this issue to help declutter the forum, thanks!


When clicking feature, make @id a hyper link and highlight the featur…

I like the popup when clicking on a line, I had an idea and tinkered with it until I found a way to make the id tag a clickable link, and to also visibly highlight the selected object. I did the highlighting by creating a new, empty, geojson layer and copying the clicked objects into it.

If you don't like it for any reason or find a better way to do it, that's great too! I just wanted to share what I had come up with. Thank you!

Ooooo! I really like this! I should have some time later this week to tinker and get this merged.
I was clicking around last week and thinking "why isn't this id a link??"


changelog and documentation improvements

@kirbles19 please review:

https://github.com/demisto/demisto-py/blob/docs-improvement/README.md
https://github.com/demisto/demisto-py/blob/docs-improvement/CHANGELOG.md

@glicht All done. I structured the README a bit, see if it looks okay.


Off by 1 meter?

I reviewed this capability and am seeing a 1 meter difference when converting from DD to MGRS. I compared against geotrans and ESRI outputs and note a 1 meter difference.

Hi, @apiszcz .  A new maintainer here!  Thanks for catching this!  Could you provide some specific examples?

I have seen this behavior. Passing mgrs.forward([0, 0]) I return 31NAA6602100000 which is actually 00.0000000°, -000.0000040°.

Thank you @jbaruch76 .  Increasing the precision of this library is a top priority and I'm open to any help you can provide!
You can run tests using NGA's GEOTRANS testing data by running CHECK_GEOTRANS=true npm test after running cd test; node setup.js;
Thank you!!

Have been playing around with this a bit. Unfortunately most of the math is going above my head. I did find however that it seems to be related to the accuracy number. I removed this if statement and just set result to what is in the else statement. https://github.com/proj4js/mgrs/blob/master/mgrs.js#L264. I then started to get the results I was expecting. The hardcoded results in the test don't match what I find using this online converter. http://www.earthpoint.us/Convert.aspx When I change the tests to match what I find here, they pass. What is the point of the accuracy number?

I have seen this behavior. Passing mgrs.forward([0, 0]) I return 31NAA6602100000 which is actually 00.0000000°, -000.0000040°.

I have seen this behavior. Passing mgrs.forward([0, 0]) I return 31NAA6602100000 which is actually 00.0000000°, -000.0000040°.

This should be 0, 0 according to http://www.earthpoint.us/Convert.aspx

$ echo 31NAA6602100000 | GeoConvert -g -p 2
0.0000045 0.0000005

$ echo 31NAA6602100000 | GeoConvert -g -p 2
0.0000045 0.0000005

Where did you get this GeoConvert tool? Is that what I should use to confirm results rather than http://www.earthpoint.us/Convert.aspx ?

With another converter i see 0.0 0.00000398
On Thu, Sep 26, 2019 at 8:41 AM jbaruch76<EMAIL_ADDRESS>wrote:

I have seen this behavior. Passing mgrs.forward([0, 0]) I return
31NAA6602100000 which is actually 00.0000000°, -000.0000040°.

This should be 0, 0 according to http://www.earthpoint.us/Convert.aspx
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/proj4js/mgrs/issues/27?email_source=notifications&email_token=AAK5KTNBNVBZRICJ2NFXYBDQLSUZJA5CNFSM4D5COZC2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD7VNOQA#issuecomment-535484224,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAK5KTIZBKVOXGNMDW4CB2DQLSUZJANCNFSM4D5COZCQ
.

@jbaruch76 , I don't believe I answered your question about the accuracy number.  The accuracy number tells us the size of the MGRS grid squares that we use to locate the point.  In other words, a low accuracy might have accuracy within 100km whereas a higher accuracy can locate the point within 1 meter.  I hope that helps.
I'm definitely open to pull requests if people want to make the code a little more human readable and fix bugs in https://github.com/proj4js/mgrs/blob/master/mgrs.js :-)

@DanielJDufour I'd be glad to help. I currently have a coordinate model that I use to convert between D.D, DM.M, DMS.S, and MGRS.
The problem I'm getting is that my base coordinates are stored in D.D (for more precision I actually store the decimal separate from the whole number portion).
However, the accuracy I obtain from this library gives me 1 meter off. Here is an example:
      const [lng, lat] = mgrs.toPoint('11S PA 22');
      console.log('[lng, lat]', [lng, lat]);
      console.log(mgrs.forward([lng, lat]));

Result:
[lng, lat] (2) [-115.66320557831847, 36.31755889123601]
coordinate.ts?0deb:56 11SPA2000120001

I really appreciate this library and will gladly contribute if I can help. I understand that the result is actually a 1m x 1m box, perhaps I should be using bbox instead?

Hello,
I've got the same issue and I think that I understand why it happened.
The code in master solve the problem in the private method LLtoUTM  because it use Math.trunc for northing and easting instead of Math.round. (there is an  explanation about it in Wikipedia
But the code that published to npm is from branch build from 2014 and not include this fix.

Hello,
I've got the same issue and I think that I understand why it happened.
The code in master solve the problem in the private method LLtoUTM  because it use Math.trunc for northing and easting instead of Math.round. (there is an  explanation about it in Wikipedia
But the code that published to npm is from branch build from 2014 and not include this fix.

Guess the solution for now is just to pull this project and use what's in master instead of npm. Thanks.

Guess the solution for now is just to pull this project and use what's in master instead of npm. Thanks.

@DanielJDufour Given this comment about what's on master being right and what's published on npm containing the off by 1 error, can we just publish that to npm or do you have other concerns?

Would be appreciated if you could publish this fix to NPM.
Thanks!

Hello. I got a prerelease branch out.  Could you npm install mgrs@next? And let me know if that version works for you? Once I get confirmation, I'll publish the new version. Thank you!
And have a great weekend!

Thanks for the quick reply!
It works fine for me after updating. (https://spatialillusions.com/unitgenerator2/ temporary url)
First I run toPoint(mgrs) to normalise all input, and then forward(point) to get MGRS for all types of input, and after I get back the same as I input, or what the user expect
Input "42SUF1234" now gives back "42SUF1200034000" instead of "42SUF1200134001" or something similar.
Great work!

@spatialillusions , I believe the credit for that fix goes to the original library authors (@ahocevar and @calvinmetcalf ).  I just published a new version :-)
I also promoted the prelease version to a major version, so running npm install mgrs will now install version 2.0.0.
Thanks for your interest and please do let me know if you encounter any more bugs.


Error when adding column and using beforeColumn

I tried to show the created_at column as the first column in the index view as such:
$this->crud->addColumn('created_at', [
        'label' => 'Transaction Timestamp',
])->beforeColumn('account_id');

The following error is thrown:
ErrorException in Columns.php line 92:
array_splice() expects parameter 2 to be long, string given

I'm sending a pull request shortly to fix the issue

Duplicate of #475. Closing due to pending PR #472


[BUG] Slide names in report do not correspond to correct images

Description
After tile extraction, the PDF report displays images and slide names, but they do not match at all. The images are displayed in the correct order that tile extraction was performed. However, the slide names are semi-random, and there is no correlation between the images and names.
To Reproduce

P.extract_tiles(tile_px=299, tile_um=302,
  filters={"source": ["Sinai2021"]},
   skip_missing_roi=False,
  grayspace_fraction=0.7,
   qc='both',
   dry_run=True)

Expected behavior
Images and names to correspond in the exported PDF after tile extraction.
Additional context
I cannot share the slides or names in a public setting. I will reach out to you personally.

I can confirm this happens when dry_run=False as well.
Upon further inspection, it looks a simple fix. It seems on the PDF that the left-column and right-column names just have to be switched, which should fix everything.


Must the button to make md-sidenav visible be contained in md-sidenav-layout?

Bug, feature request, or proposal:
Bug: button to make md-sidenav visible has to be contained in md-sidenav-layout
What is the expected behavior?
md-sidenav made visible from component outside md-sidenav-layout
What is the current behavior?
md-sidenav is inert
What are the steps to reproduce?
non-working md-sidenav:
http://plnkr.co/edit/HUylyrN05AYtx77LzaTZ?p=preview
Move md-sidenav-layout to top and it works
What is the use-case or motivation for changing an existing behavior?
Need to know if md-sidenav-layout must enclose the button that makes it visible.
Which versions of Angular, Material, OS, browsers are affected?
angular-cli: 1.0.0-beta.16
node: 6.4.0
os: darwin x64
material: 2.0.0-alpha.9-3

You just need to have something in that main content area for some reason, and it works just like you would expect, see: http://plnkr.co/edit/rygo7bBAVAKt7x4Kk8yF?p=preview


Bearer header

Why do you suggest to put the jwt in the custom http header "x-zumo-auth"? Wouldn't you prefer to use the authorization bearer header?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: d4518495-4e07-ce2e-4045-5a50b7922b55
Version Independent ID: 034d1ba0-a737-21ab-3717-ed8798ac5fe1
Content: Advanced usage of authentication and authorization - Azure App Service
Content Source: articles/app-service/app-service-authentication-how-to.md
Service: app-service
GitHub Login: @cephalin
Microsoft Alias: cephalin

@cveld
Thanks for your feedback! We will investigate and update as appropriate.

@cveld This is where the app service platform will be looking at by default, which is why the doc suggests to place the jwt in the x-zumo header.
We will now proceed to close this thread. If there are further questions regarding this matter, please tag me in your reply. We will gladly continue the discussion and we will reopen the issue.

@BryanTrach-MSFT maybe you can explain the origin of the name? "aZUre MObile"? And maybe you can explain the preference for such a custom header. Wouldn't it be more logical to add bearer handling to Easy Auth as well?

@BryanTrach-MSFT  X-ZUMO-AUTH doesn't work if the provider is AAD and the target is Azure Function api. But Authorization header works.


VS Code + WSL: Command 'Preview AsyncAPI' resulted in an error

Describe the bug
When using from within WSL on Windows 10, I get the following error:

How to Reproduce
Steps to reproduce the issue:

in VS Code, open a project from inside WSL that contains an AsyncAPI spec
in VS Code, open the AsyncAPI spec document
in VS Code, open the command palette and select "Preview AsyncAPI"

Expected behavior
I expect the preview to show a preview of the AsyncAPI spec document

try to install node, then use  AsyncAPI Preview

node is part of the VSCode environment:
Version: 1.59.1
Commit: 3866c3553be8b268c8a7f8c0482c0c0177aa8bfa
Date: 2021-08-19T11:56:46.957Z
Electron: 13.1.7
Chrome: 91.0.4472.124
Node.js: 14.16.0
V8: 9.1.269.36-electron.0
OS: Windows_NT x64 10.0.18363

having same issue.
Version: 1.60.2 (user setup)
Commit: 7f6ab5485bbc008386c4386d08766667e155244e
Date: 2021-09-22T12:00:31.514Z
Electron: 13.1.8
Chrome: 91.0.4472.164
Node.js: 14.16.0
V8: 9.1.269.39-electron.0
OS: Windows_NT x64 10.0.18363

Please follow instructions in #3
Tl;dr You should have installed v12.16+ < Node.js and v6.13.7+ < npm on your computer.

@voborgus - the implication is that the extension will use a version of Node other than the version provided by VS Code, but I don't think that's the case. In fact, I use nodenv to manage multiple installs, have tried setting both my project and the extension to use v12.16.3, and have had the same results. #3 makes no mention of the versions of VS Code at play, like the three comments above do.
What am I missing? How do I tell an extension to use a different version of Node than the one embedded in VS Code?
Also, @asyncapi/generator v1.18.18 is out (see: https://github.com/asyncapi/vs-asyncapi-preview/pull/61). I'm wondering if the fix ultimately is to have this upgraded to be compatible with the version of Node included in more recent versions of VS Code.

I have the same issue.
Checking the logs it looks like it is because of some incompatibility with newer npm versions:
[2021-11-19 18:11:59.659] [exthost] [error] Activating extension ivangsa.asyncapi-preview failed due to an error: [2021-11-19 18:11:59.659] [exthost] [error] Error: The programmatic API was removed in npm v8.0.0 	at Object.<anonymous> (C:\Program Files\nodejs\node_modules\npm\index.js:4:9) 	at Module.s._compile (c:\Program Files\Microsoft VS Code\resources\app\out\vs\loader.js:4:1315) 	at Object.Module._extensions..js (internal/modules/cjs/loader.js:1155:10) 	at Module.load (internal/modules/cjs/loader.js:982:32) 	at Module._load (internal/modules/cjs/loader.js:823:14) 	at Function.f._load (electron/js2c/asar_bundle.js:5:12913) 	at Function.i._load (c:\Program Files\Microsoft VS Code\resources\app\out\vs\workbench\services\extensions\node\extensionHostProcess.js:113:28495) 	at Function.b._load (c:\Program Files\Microsoft VS Code\resources\app\out\vs\workbench\services\extensions\node\extensionHostProcess.js:113:25083) 	at Function.d._load (c:\Program Files\Microsoft VS Code\resources\app\out\vs\workbench\services\extensions\node\extensionHostProcess.js:103:60224) 	at Module.require (internal/modules/cjs/loader.js:1006:19) 	at v (c:\Program Files\Microsoft VS Code\resources\app\out\vs\loader.js:4:698) 	at c:\Users\user\.vscode\extensions\ivangsa.asyncapi-preview-0.1.1\node_modules\global-npm\index.js:29:15 	at Object.<anonymous> (c:\Users\user\.vscode\extensions\ivangsa.asyncapi-preview-0.1.1\node_modules\global-npm\index.js:41:3) 	at Module.s._compile (c:\Program Files\Microsoft VS Code\resources\app\out\vs\loader.js:4:1315) 	at Object.Module._extensions..js (internal/modules/cjs/loader.js:1155:10) 	at Module.load (internal/modules/cjs/loader.js:982:32) 	at Module._load (internal/modules/cjs/loader.js:823:14) 	at Function.f._load (electron/js2c/asar_bundle.js:5:12913) 	at Function.i._load (c:\Program Files\Microsoft VS Code\resources\app\out\vs\workbench\services\extensions\node\extensionHostProcess.js:113:28495) 	at Function.b._load (c:\Program Files\Microsoft VS Code\resources\app\out\vs\workbench\services\extensions\node\extensionHostProcess.js:113:25083) 	at Function.d._load (c:\Program Files\Microsoft VS Code\resources\app\out\vs\workbench\services\extensions\node\extensionHostProcess.js:103:60224) 	at Module.require (internal/modules/cjs/loader.js:1006:19) 	at v (c:\Program Files\Microsoft VS Code\resources\app\out\vs\loader.js:4:698) 	at Object.<anonymous> (c:\Users\user\.vscode\extensions\ivangsa.asyncapi-preview-0.1.1\node_modules\npmi\npmi.js:1:76) 	at Module.s._compile (c:\Program Files\Microsoft VS Code\resources\app\out\vs\loader.js:4:1315) 	at Object.Module._extensions..js (internal/modules/cjs/loader.js:1155:10) 	at Module.load (internal/modules/cjs/loader.js:982:32) 	at Module._load (internal/modules/cjs/loader.js:823:14) 	at Function.f._load (electron/js2c/asar_bundle.js:5:12913) 	at Function.i._load (c:\Program Files\Microsoft VS Code\resources\app\out\vs\workbench\services\extensions\node\extensionHostProcess.js:113:28495) 	at Function.b._load (c:\Program Files\Microsoft VS Code\resources\app\out\vs\workbench\services\extensions\node\extensionHostProcess.js:113:25083) 	at Function.d._load (c:\Program Files\Microsoft VS Code\resources\app\out\vs\workbench\services\extensions\node\extensionHostProcess.js:103:60224) 	at Module.require (internal/modules/cjs/loader.js:1006:19) 	at v (c:\Program Files\Microsoft VS Code\resources\app\out\vs\loader.js:4:698) 	at Object.<anonymous> (c:\Users\user\.vscode\extensions\ivangsa.asyncapi-preview-0.1.1\node_modules\@asyncapi\generator\lib\generator.js:14:14) 	at Module.s._compile (c:\Program Files\Microsoft VS Code\resources\app\out\vs\loader.js:4:1315) 	at Object.Module._extensions..js (internal/modules/cjs/loader.js:1155:10) 	at Module.load (internal/modules/cjs/loader.js:982:32) 	at Module._load (internal/modules/cjs/loader.js:823:14) 	at Function.f._load (electron/js2c/asar_bundle.js:5:12913) 	at Function.i._load (c:\Program Files\Microsoft VS Code\resources\app\out\vs\workbench\services\extensions\node\extensionHostProcess.js:113:28495) 	at Function.b._load (c:\Program Files\Microsoft VS Code\resources\app\out\vs\workbench\services\extensions\node\extensionHostProcess.js:113:25083) 	at Function.d._load (c:\Program Files\Microsoft VS Code\resources\app\out\vs\workbench\services\extensions\node\extensionHostProcess.js:103:60224) 	at Module.require (internal/modules/cjs/loader.js:1006:19) 	at v (c:\Program Files\Microsoft VS Code\resources\app\out\vs\loader.js:4:698) 	at Object.<anonymous> (c:\Users\user\.vscode\extensions\ivangsa.asyncapi-preview-0.1.1\out\PreviewServer.js:20:27) 	at Module.s._compile (c:\Program Files\Microsoft VS Code\resources\app\out\vs\loader.js:4:1315) 	at Object.Module._extensions..js (internal/modules/cjs/loader.js:1155:10) 	at Module.load (internal/modules/cjs/loader.js:982:32) 	at Module._load (internal/modules/cjs/loader.js:823:14) 	at Function.f._load (electron/js2c/asar_bundle.js:5:12913) 	at Function.i._load (c:\Program Files\Microsoft VS Code\resources\app\out\vs\workbench\services\extensions\node\extensionHostProcess.js:113:28495) 	at Function.b._load (c:\Program Files\Microsoft VS Code\resources\app\out\vs\workbench\services\extensions\node\extensionHostProcess.js:113:25083) 	at Function.d._load (c:\Program Files\Microsoft VS Code\resources\app\out\vs\workbench\services\extensions\node\extensionHostProcess.js:103:60224) 	at Module.require (internal/modules/cjs/loader.js:1006:19) 	at v (c:\Program Files\Microsoft VS Code\resources\app\out\vs\loader.js:4:698) 	at Object.<anonymous> (c:\Users\user\.vscode\extensions\ivangsa.asyncapi-preview-0.1.1\out\extension.js:16:25) 	at Module.s._compile (c:\Program Files\Microsoft VS Code\resources\app\out\vs\loader.js:4:1315) 	at Object.Module._extensions..js (internal/modules/cjs/loader.js:1155:10) 	at Module.load (internal/modules/cjs/loader.js:982:32) 	at Module._load (internal/modules/cjs/loader.js:823:14) 	at Function.f._load (electron/js2c/asar_bundle.js:5:12913) 	at Function.i._load (c:\Program Files\Microsoft VS Code\resources\app\out\vs\workbench\services\extensions\node\extensionHostProcess.js:113:28495) 	at Function.b._load (c:\Program Files\Microsoft VS Code\resources\app\out\vs\workbench\services\extensions\node\extensionHostProcess.js:113:25083) 	at Function.d._load (c:\Program Files\Microsoft VS Code\resources\app\out\vs\workbench\services\extensions\node\extensionHostProcess.js:103:60224) 	at Module.require (internal/modules/cjs/loader.js:1006:19) 	at v (c:\Program Files\Microsoft VS Code\resources\app\out\vs\loader.js:4:698) 	at Object.<anonymous> (c:\Users\user\.vscode\extensions\ivangsa.asyncapi-preview-0.1.1\out\index.js:4:19) 	at Module.s._compile (c:\Program Files\Microsoft VS Code\resources\app\out\vs\loader.js:4:1315) 	at Object.Module._extensions..js (internal/modules/cjs/loader.js:1155:10) 	at Module.load (internal/modules/cjs/loader.js:982:32) 	at Module._load (internal/modules/cjs/loader.js:823:14) 	at Function.f._load (electron/js2c/asar_bundle.js:5:12913) 	at Function.i._load (c:\Program Files\Microsoft VS Code\resources\app\out\vs\workbench\services\extensions\node\extensionHostProcess.js:113:28495) 	at Function.b._load (c:\Program Files\Microsoft VS Code\resources\app\out\vs\workbench\services\extensions\node\extensionHostProcess.js:113:25083) 	at Function.d._load (c:\Program Files\Microsoft VS Code\resources\app\out\vs\workbench\services\extensions\node\extensionHostProcess.js:103:60224) 	at Module.require (internal/modules/cjs/loader.js:1006:19) 	at require (internal/modules/cjs/helpers.js:88:18) 	at Function.r [as __$__nodeRequire] (c:\Program Files\Microsoft VS Code\resources\app\out\vs\loader.js:5:101) 	at w._loadCommonJSModule (c:\Program Files\Microsoft VS Code\resources\app\out\vs\workbench\services\extensions\node\extensionHostProcess.js:113:26492) 	at w._doActivateExtension (c:\Program Files\Microsoft VS Code\resources\app\out\vs\workbench\services\extensions\node\extensionHostProcess.js:99:12722) 	at w._activateExtension (c:\Program Files\Microsoft VS Code\resources\app\out\vs\workbench\services\extensions\node\extensionHostProcess.js:99:11695) 	at processTicksAndRejections (internal/process/task_queues.js:93:5) 	at async Promise.all (index 0)
I have node 17.0.1 and npm 8.1.0 installed. It looks like the extension does not use the VS code supplied node version (which is 14.16 and should have npm 6.14.1).
I tried to manually downgrade the npm version but still got the same error. So I am not 100% sure how the extension finds node and npm. Updating the asyncapi/generator as @davidlday  suggested may solve the problem as it looks from the stacktrace the problem is caused by the generator dependency.

I have same problem on Intel Mac
Command 'Preview AsyncAPI' resulted in an error (command 'asyncapi.preview' not found)

Facing same issue, Native Ubuntu 20.04.

Hi @davidlday
AsyncAPI vscode extension has been reworked using the latest @asyncapi/asyncapi-react which is also de component used on  AsyncAPI Studio
It has also been relocated but it will autocatically upgrade itself if you already have it installed
https://marketplace.visualstudio.com/items?itemName=asyncapi.asyncapi-preview
I'm closing this issue as it should be fixed now.. but please recreate it if this issue still persist.
Thanks for your patience


[WIP] kaggle dog

Forum links

Job d2l-zh/PR-807/3 is complete.
Check the results at http://preview.d2l.ai/d2l-zh/PR-807/

numref, cite check done

Job d2l-zh/PR-807/5 is complete.
Check the results at http://preview.d2l.ai/d2l-zh/PR-807/

Job d2l-zh/PR-807/6 is complete.
Check the results at http://preview.d2l.ai/d2l-zh/PR-807/

Job d2l-zh/PR-807/7 is complete.
Check the results at http://preview.d2l.ai/d2l-zh/PR-807/


Clarification of behaviour when enable.auto.commit is set to false

the behaviour for enable.auto.commit set to false was missing. adding the same to the doc
Thanks for contributing to Logstash! If you haven't already signed our CLA, here's a handy link: https://www.elastic.co/contributor-agreement/

@robbavey , @karenzone I have modified the docs. Hope I understood the feedback correctly. Please take a look.

@karenzone I'm happy with the change from a technical perspective, if you are OK with it from a doc/formatting side, we can merge this change.

@karenzone I have modified as per your suggestion. Please take a look.


fix(doc): remove redundant '/build' entry in project structure

Tiny doc fix contribution.

Thanks


Add integer warning checks

Add clang warning checks
This PR will simpify or perhap make the CBMC proof tighter.
Before I proceed to fix the warnings (later become error because we use Werror), let me know if this is a good idea.
Please see the CI for error

The errors in ML-KEM are shown up in CI

Hi @cothan, could you start working through the first set of warnings to give us a sense of the scope of changes?

@hanno-becker , sure. It's seem like we need to do manual casting in : https://github.com/pq-code-package/mlkem-c-aarch64/pull/248/commits/b7e25bdc67fe1f6488b6474b8766f444daa293a4

Thanks @rod-chapman for the comamds, I check locally with the commit: https://github.com/pq-code-package/mlkem-c-aarch64/pull/248/commits/96fabd933745f5c16472d2e0e0902abdab2f1890
KYBER_K=2 ./run-cbmc-proofs.py --summarize -j8
KYBER_K=3 ./run-cbmc-proofs.py --summarize -j8
KYBER_K=4 ./run-cbmc-proofs.py --summarize -j8

are return success.

it's seem like the last part that I don't know how to cast is:
mlkem/verify.c:68:9: warning: conversion to ‘int16_t’ {aka ‘short int’} from ‘int’ may change the sign of the result [-Wsign-conversion]
   68 |   *r ^= b & ((*r) ^ v);
      |         ^

in
void cmov_int16(int16_t *r, int16_t v, uint16_t b) {
// CBMC issues false alarms here for the implicit conversions between
// uint16_t and int, so disable "conversion-check" here for now.
// Revisit this when proof of this unit with contracts is attempted.
#pragma CPROVER check push
#pragma CPROVER check disable "conversion"
  b = -b;
  *r ^= b & ((*r) ^ v);
#pragma CPROVER check pop
}

@cothan Perhaps wait a bit, I'm not convinced yet we want this change, and I don't want you to invest too much.

I think we should stick to warning switches that are common to both recent versions of gcc and clang.


logging: Report stack_info on logging.exception calls.

The exception trace only goes from where the exception was thrown up
to where the logging.exception call is; any context as to where
that was called from is lost, unless stack_info is passed as well.
Having the stack is particularly useful for Sentry exceptions, which
gain the full stack trace.
Add stack_info=True on all logging.exception calls with a
non-trivial stack; we omit wsgi.py.

Great, merged, thanks @alexmv!


Custom Dockerfile syntax is not supported?

What happened?
I'm trying to use @pulumi/docker-build provider to build this Dockerfile:
# syntax=docker.io/docker/dockerfile:1.7-labs
FROM public.ecr.aws/docker/library/node:22-alpine AS base

WORKDIR /app
COPY --parents ./package.json ./package-lock.json ./apps/*/package.json ./packages/*/package.json ./

However when I run pulumi up I get this error:
Diagnostics:
  docker-build:index:Image (dev-api-app):
    error: docker-build:index:Image resource 'dev-api-app': property dockerfile.location value {<nil>} has a problem: dockerfile parse error on line 7: unknown flag: parents

My attempts to provide synax through build arguments failed as well - same error:
buildArgs: {
        ...buildArgs,
        BUILDKIT_SYNTAX: 'docker.io/docker/dockerfile:1.11.1-labs',
      },

Is there a way to support custom docker syntax and specifically COPY --parents flag?
Example
See above
Output of pulumi about
CLI
Version      3.133.0
Go Version   go1.23.1
Go Compiler  gc

Plugins
KIND      NAME    VERSION
language  nodejs  unknown

Host
OS       darwin
Version  15.1
Arch     arm64

This project is written in nodejs: executable='/opt/homebrew/bin/node' version='v22.6.0'

Additional context
No response
Contributing
Vote on this issue by adding a 👍 reaction.
To contribute a fix for this issue, leave a comment (and link to your pull request, if you've opened one already).

@akramarev as part of our validation checks we attempt to parse the Dockerfile for syntactic correctness, and it does seem we only understand the built-in syntax. At first glance I'm not sure how to best support this. At a minimum we could try to detect exotic syntax and disable this validation in those cases.

I hear you @blampe. There are not that many docker parser directives, so it shouldn't be a problem to detect them and disable additional validation.
But out of curiosity (and without looking into the code), why does @pulumi/docker-build provider validate the syntax additionally, why not just delegate it to BuildKit entirely?

But out of curiosity (and without looking into the code), why does @pulumi/docker-build provider validate the syntax additionally, why not just delegate it to BuildKit entirely?

Good question @akramarev. Many of our users essentially use previews as a CI gate: a pull request can merge if its preview succeeds, and after it merges run the update.
The more we can validate upfront during the preview, the less likely you are to get unexpected results during your update. There are alternative and arguably better ways to accomplish this, but the workflow I'm describing is an overwhelmingly common pattern.

I just stumbled upon this as well. In my case, I was able to do workaround, as I just used INCLUDE+ directive from dockerfile-plus repo, so within my Pulumi pipeline, I just generated new file with all those directives to be replaced with actual included file contents. If I would be using more complex syntax like OP, there probably would've been quite bigger task to creating workaround.
@blampe Interesting that you mention that the reason for custom parsing is extra caution: I thought that build_on_preview was supposed to handle that? Basically, if build works in preview, then it very likely will work in up as well. 🤔 But I probably suggest on adding new optional argument, something like skip_dockerfile_verification which is false by default. Thus, you would still get extra safety of verifying Dockerfiles in Pulumi, but developers who for one reason or another want to disable the check, can do so by using this argument, without needing to build possibly very complex workarounds. Especially since the actual Docker BuildKit will do the final validation of the syntax anyway. WDYT?

@blampe Interesting that you mention that the reason for custom parsing is extra caution: I thought that build_on_preview was supposed to handle that? Basically, if build works in preview, then it very likely will work in up as well. 🤔

@stazz build_on_preview is a very heavy operation, and we should still be able to detect syntax errors for users who prefer not to build on preview.
https://github.com/pulumi/pulumi-docker-build/pull/346 disables the validation in cases where a custom syntax is being used.

I'll have a fix for this released soon -- hoping to include https://github.com/pulumi/pulumi-docker-build/pull/235 as part of that.

Released in v0.0.8.


some doc error and data missing

in trainer script , the  class was predictor
also
gbdt sample data is missing which is dna/*  in the angel

maybe we can use sample_multiclass_classification_data.txt to replace.

and i got

when i train

Z class users.
👾


Fix input range init

Please check if the PR fulfills these requirements

[x] The commit message follows our guidelines: https://github.com/angular/angular.js/blob/master/CONTRIBUTING.md#commit-message-format
[x] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)

Other information:
This PR fixes 1 bigger and 2 smaller issues:

correctly initialize with interpolated min / max values

The interpolation directive only sets the actual element attribute value after
a digest passed. That means previously the min/max values on input range were
not set when the first $render happened, so the browser would not adjust
the input value according to min/max. This meant the range input and model would
not be initialzed as expected.
With this change, input range will set the actual element attribute value during its own
linking phase, as it is already available on the attrs argument passed to the link fn.
Fixes #14982

correctly sets the range value when min > max. Chrome and IE don't set this correctly in all cases.

removes interpolation from an ng-maxlength attribute in a test (interpolation in an attribute that expects an expression is discouraged)

@gkalpak Travis finally green, you may review this again :>

LGTM

Will this fix be back-ported to older angular versions?

@icorne - which versions did you have in mind? We have no plans to backport it further back than 1.5.x

I'm having trouble figuring out where this was merged into. I'm working on 1.5.x, so that's what I'm interested in. I've tried upgrading from 1.5.5 to 1.5.9 but I still get the issue.

Ahah! Right. OK, it didn't make it into 1.5.9, since that was primarily a security release. It will be in 1.5.10.

This is already included in 1.5.9 (2e7121b), but support for input[range] is opt-in on 1.5.x in order to avoid a breaking change (see 07b8761 and the docs).

Oops! I am so confused with all the rebasing we did last week that I forgot that we actually did put this in 1.5.9 :-) Thanks @gkalpak


expand allocation sinking to arrays

Currently allocation sinking can only handle objects allocated by AllocateObject and AllocateUninitializedContext.
We should expand it to the all array types (including typed arrays) when all loads/stores can be fully forwarded (e.g. length is a constant  and indices of accesses are constants as well).
Areas where this is expected to help:

fully eliminating temporary matrices and vectors (vector_math)
removing dead CreateArray instructions left behind after folding fully constant string interpolations.

/cc @mkustermann @alexmarkov

I saw this problem on ParticleSystem benchmark, after it was updated to use current version of package:vector_math. We should also make sure that load forwarding works across typed data allocation.
I'd like to try this out.


auto Scroll

@rechsteiner
Is there a way to scroll automatically in the parchment? For example after 3 seconds the scroll is automatically inserted.
Thanks.

Yes, you can select items programatically using select(index:,animated:). E.g:
pagingViewController.select(index: 2, animated: true)


Adding node dependency to support arm64

Unfortunately this breaks linux compatibility. Googling will probably reveal a way to make npm conditionally install the correct package. However, I will close this until we figure out a more general way.


Add streaming KZG

Description
Add streaming KZG used in Gemini.
I need help to fix the test for the poseidon:  https://github.com/arkworks-rs/poly-commit/blob/master/src/lib.rs#L1290

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

[x] Targeted PR against correct branch (master)
[ ] Linked to Github issue with discussion and accepted design OR have an explanation in the PR that describes this work.
[x] Wrote unit tests
[ ] Updated relevant documentation in the code
[ ] Added a relevant changelog entry to the Pending section in CHANGELOG.md
[x] Re-reviewed Files changed in the Github PR explorer

looks good to me modulo the quadratic time question.


Add setting for auto-pull-on-backup

When setting is enabled, the remote repo will be pulled at the start of each backup session, to enable the local repo to stay in sync with remote changes.
This feature is specially useful when the remote repo is being frequently updated (e.g. when using a mobile app such as gitJournal to update documents from your phone). In these cases, currently, the local repo cannot be pushed until a manual pull is performed.

@denolehov hi, could you please take a look at this PR?
Thanks!

@denolehov hi, could you please take a look at this PR?
Thanks!

Hey, sorry for not responding 😢
Looks good! Could you please change the commit message to feat: add setting for auto-pull on backup? I am using semantic releases and want to minimize manual work when releasing :) thanks!

Hey, sorry for not responding 😢
Looks good! Could you please change the commit message to feat: add setting for auto-pull on backup? I am using semantic releases and want to minimize manual work when releasing :) thanks!

@denolehov I changed the PR name, is there a way to change the commit message?

@amitkot yes you can amend your commit locally and then push force to your fork
In your case:
git commit --amend --message="feat: add setting for auto-pull on backup"
git push --force

@Larandar done

Sorry I made a mistake it seems, you are in windows, right? it seems like you committed with a quote at the start and end of the commit. Can you try: (no =)
git commit --amend --message "feat: add setting for auto-pull on backup"

@Larandar I'm on a Mac, but I guess my shell (Xonsh) passed the quote marks on to git. Ran it again and it should be fixed now.

@Larandar so what do you say? Can we merge this?
Thanks!

Sorry for the lack of activity on my side. Merged this PR :) Thank you for contributing!

The problem on this pull request is, that you first pull and then commit. If you have unstaged changes in a file, that has changed on the remote. You can't pull. In addition, I changed the settings behavior to the recommended way. I already implemented this at my fork. See https://github.com/Vinzent03/obsidian-git/commit/80fc3e6be1751c3e5e0437b6bc3ecd4a6e31bf3b
Is a revert okay?


[Bug] lodash/path-style auto fix produces code that isn't semantically equivalent

The plugin auto fixes:
_.set(foo, [bar.a, bar.b], qux);

to
 _.set(foo, `${bar.a}${bar.b}`, qux);

There should be a .:
 _.set(foo, `${bar.a}.${bar.b}`, qux);

Just ran into this as well :/


[stable/ambassador] Ambassador/0.74

What this PR does / why we need it:
Bumps Ambassador to version 0.74.0.
Special notes for your reviewer:
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

[x] DCO signed
[x] Chart Version bumped
[x] Variables are documented in the README.md
[x] Title of the PR starts with chart name (e.g. [stable/chart])

/ok-to-test

/lgtm


fix readme example

see title

Coverage remained the same at 94.656% when pulling fd4e7c84b15bd5bac03daa9e0b4e86d77c3f6e3d on fapian:fix-readme-example into 5104836ae536ee5bc9d13ba4b6feededb91e508c on yoshuawuyts:master.

Ohey, yeah good catch. Thanks!


Docs unclear about Github token permissions

Is there an existing issue for this?

[X] I have searched the existing issues

Description of the bug

Unclear which permissions are needed by the Github token.
Unclear if the GITHUB_TOKEN provided by default in Github Actions is enough.

Steps To Reproduce
N/A
Expected behavior
Give clarity on the unanswered questions on this page: https://git-cliff.org/docs/integration/github#authentication
Screenshots / Logs
No response
Software information
N/A
Additional context
No response

Ah okay I see it now, in the tip callout.

Follow this guide for creating an access token. It can be either a classic or fine-grained token without permissions.

I would suggest making it stand out more. Perhaps by giving it its own little sub-section in the Authentication section.
And this question is still unanswered:

Unclear if the GITHUB_TOKEN provided by default in Github Actions is enough.


Outputs garbage sometimes, but not when using the pre-processed image or a different language

I haven't reported this as a bug because OCR is never perfect, but I observed some strange results. Often the recognition works if I used the preprocessed image generated by tesseract or select a different language.
First example: input.pgm.zip
$ tesseract input.pgm stdout -l deu
Warning: Invalid resolution 0 dpi. Using 70 instead.
Estimating resolution as 268
VT CN
war er der beste Cutman der Branche.

Running the recognition agains the saved pre-processed image tessinput.tif saved using tessedit_write_images true results in:
$ tesseract tessinput.tif stdout -l deu
Page 1
Als ich ihn kennen lernte,
war er der beste Cutman der Branche.

Also interesting is the result when the language is set to English.
$ tesseract input.pgm stdout -l eng
Warning: Invalid resolution 0 dpi. Using 70 instead.
Estimating resolution as 268
Als ich ihn kennen lernie,
war er der beste Cuitman der Branche.

Second example: input2.pgm.zip
$ tesseract input2.pgm stdout -l deu
Warning: Invalid resolution 0 dpi. Using 70 instead.
Estimating resolution as 224
SN

$ tesseract tessinput.tif stdout -l deu
Page 1
Empty page!!
Empty page!!

$ tesseract input.pgm stdout -l eng
Warning: Invalid resolution 0 dpi. Using 70 instead.
Estimating resolution as 224
Lassen Sie mal sehen.

These are examples using German language recognition, but it happens with English too, but less frequently. It's also worth mentioning that the generated pre-processed file is identical to the input when using tessinput.tif in the examples above. It almost looks like the pre-processed file is (often) not used for the recognition process.
Tesseract Version: 4.1.1
Platform: Linux 5.8.1-arch1-1 x86_64 GNU/Linux

No it's not. I still get the same results. The docs say "If the resulting tessinput.tif file looks problematic, try some of these image processing operations before passing the image to Tesseract." But the tessinput.tif looks fine. Also this doesn't explain why the results of  tesseract input.pgm stdout -l deu  and tesseract tessinput.tif stdout -l deu are different.

Read the whole docs.


Posted comments should appear at the top of comment list

From KP:
[ ] Posted comment on a channel page, and the comment is down below.

@tzarebczan While trying to debug this issue, I found that the comment_list call invoked right after the comment_create call doesn't have the latest comment, but when I exit the channel page and go back then it's there. I was also able to sometimes get it to show up with a 10 second delay, but this exiting and going back is less than 10 seconds.


Use version numbers in $OPENSSL and $GNUTLS variables; add OpenSSL 3.0 and 3.1

Start using version numbers in $OPENSSL and $GNUTLS variables, e.g. $OPENSSL_1, $OPENSSL_1_1 and $OPENSSL_1_1_1 are OpenSSL 1.1.1a. This will allow all.sh to reference these versions.
Keep the old names $OPENSSL_NEXT etc. pointing to the same versions for backward compatibility: we don't want to break all.sh in branches of mbedtls we care about (development, mbedtls-2.28, as well as open pull requests to these branches and other work in progress). We won't change what these non-numbered variables point to, we'll gradually migrate away from them.
Remove GnuTLS 3.3.8 which was GNUTLS_LEGACY and replace GnuTLS 3.4.10 with 3.4.6 which has all the features we need and one less bugfix). See also 3.x, 2.28 removing the use of GNUTLS_LEGACY.
Add OpenSSL 3.0 (long-time support branch) and 3.1 (latest release at this time) so that we can test with modern versions of OpenSSL. (Newer GnuTLS may follow later.)
Test runs

46a206feb6a0ab89e70c87599dcc642ee4f05f8d on development: https://jenkins-mbedtls.oss.arm.com/job/mbedtls-release-ci-testing/530/ → (a previous run almost passed but glitched during result analysis)
46a206feb6a0ab89e70c87599dcc642ee4f05f8d on mbedtls-2.28: https://jenkins-mbedtls.oss.arm.com/job/mbedtls-release-ci-testing/529/ → PASS
46a206feb6a0ab89e70c87599dcc642ee4f05f8d on https://github.com/Mbed-TLS/mbedtls/pull/8122 : https://mbedtls.trustedfirmware.org/job/mbedtls-release-ci-testing/51/ → PASS
20fcf5d6e3d007c7fb57b9696be9c2dae64f6af1 on development: https://mbedtls.trustedfirmware.org/job/mbedtls-release-ci-testing/55/ →

@gilles-peskine-arm This has had two approvals for a month. Is anything blocking this from being merged (like, more test runs needed) or was it simply forgotten because the labels not up to date?

@mpg Thanks for the ping! It does look like this slipped through the cracks due to not having the “approved” label. Though we did pause merging while the release was imminent.
Since there was some merging in a Docker file, even without a conflict, I've kicked off a test job on each CI. If those pass, we can merge.


Still randomly crashes windows 10 x64

Description

Step to reproduce

Installed using every way
Run as with gui or without, admin and without admin rights
Got complete system crash error

Output
Share what your terminal says when you run the script (as well as what you would expect).

Environment

OS      Windows 10 64
Windows / Linux / MacOS / other

Installation type
Conda / pip / other       Tried them all

RAM available
XGo    32 gb, also tried with different ram sticks.

Hardware spec
GPU / CPU / etc ...  intel i9 9900, gtx 1080, multiple clean drivers up to current tried.

Additional context

Can you elaborate more on the crash output message as well as the tasks that you are attempting to run when it randomly crashes?


Automated stress tests

@martint, @electrum, @dain  Can you share your experience with a stress testing. What do you think needs to be tested:

what data and queries?
what workload (concurrency)?
how long it should be executed to catch production-like issues?
how much hardware do we need?
how can this be automated?
what needs to be verified (memory leaks, garbage collection, correctness)?

Are there any companies that would participate in this to get the "real" data and queries, or even hardware?
I was thinking about spinning a cluster(s) on AWS and the run the above frequently (like once a week). It would be good do it from the beginning, because now we have no many such tests and hence it should be easily automated. Then we could iteratively improve it.

I can share a bit about the testing environment we do to test our connector (at Varada), focusing on things that have a potential to be used standalone.
But first, to your point @martint I see two ways to go IMHO:

Identify testing code that organizations can adapt / release under Apache license to Presto, and add that to a regression that runs nightly / pre-release, moving the maintenance to the Presto maintainers.
Identify tests that orgnanizations do that can not be released (due to reasons you mentioned) but can run them and pre-qualify releases.
The second model as I see it is not very sustainable for release testing: organizational priorities and availability to that pre-qualify testing can change with time; no visibility into what is done by each organization makes it hard to achieve high standards of coverage; no reproducibility out of internal environment makes triage and solving bugs hard, especially for intermittent bugs or performance degradations. So a one way to enable this direction can be to open a new issue that focuses on and improves just the automated failure reporting tool - building a tool that is easy to integrate and allows any external testing framework to report as much as possible on failures in a standartized way.

There are some of things we do in QA that might have a potential to be released in one way or another to run as part of Presto (ignoring for now how much effort each would take).
Interesting to hear your takes what would be useful?

TPC-DS data at scales 10, 1000 (1TB) and 10000 (10TB) in Parquets on S3, and will add more scale as we go. Compatible with the presto-benchto TPC-DS queries. We run those queries against S3 through our connector in various cluster configurations, but I believe this can be adapted to test presto-hive as well.

Geospatial data at few scale factors - we have a dataset that represents ride sharing in San Francisco (about 5B rows of 25M rides, anonymous data we can share based on open source data, Parquet file format on S3). The test runs a set of interesting / complex queries on the data - some of them use geofences, some of them JOINs, some of them are more classic BI. Even without the queries, this is a good dataset for testing.

"Matrix" test - a test the randomly generates data and queries, loads the data both to PostgreSQL and to Presto, runs the queries against both and compares results between the databases. To catch correctness errors / random rare bugs. Some of the framework (the random data generation part) is very standalone, some requires some work to decouple. That said, the type of queries we generate might be biased to catch bugs in our code, so not that useful. If someone wants to take on a project of building generic queries to generate we can try to partner. It might also find bugs in Postgres :-)

"Performance" test - a test that uses a flattened TPC-DS table of ~10B rows / ~30 columns and a set of simple queries. Runs every night in same environment(s), and all the hisotric results for each query are collected. Catches various performance degradations - both major ones (today is 50% worse than yesterday) but also gradual trends.

Tableau framework - Tableau have open sourced a testing framework (https://github.com/tableau/connector-plugin-sdk/tree/master/tdvt) with an MIT license, and it can be used to catch BI related regressions. It relies by itself on using Tableau to generate queries, which is not open source, is not a good fit for automated testing, and for sure can't be added to Apache Presto release testing. Our approach is to decouple the tests from the framework - put verification data in Parquet/CSV files on S3, and build a JSON file that describes all the SQL queries (±700) the framework generates and the expected result for each one. This is collected by running TDVT and recording its interaction to the JSON. Our internal code uses the JSON as input to run, but I kinda guess this approach can be adapted to other verification frameworks that just run a SQL and compare the results. Note that this requires some maintenance - each time Tableau release a new version of the verification we update the JSON file.


[Enhancement] Icon: New icons for contact profile

[x] BLOCKER: Need icon font export from Design. Contact @xtinesun for status. #915
[x] Need at least the following added to icon library:

[x]  expand
[ ]  reset password
[x]  grant offer
[x]

In design

Request sent to Design: https://kajabi.slack.com/archives/C01A424HY8Y/p1634569150073600

Note: reset password was accidentally ommitted from this PR but will be in the next one


linefeed bug with sourcemaps

I found a bug in windows platform.
linefeed: process.platform === 'win32' ? 'crlf': 'lf',

@floridoo

What's the output of
npm ls node-sass

@xzyfer
--<EMAIL_ADDRESS>`--<EMAIL_ADDRESS>

I read the code using @sindresorhus plugin  detect-newline to do this. @floridoo gulp-sourcemaps

Please supply the gulp config you're using. It's not clear to me if you're using node-sass sourcemaps (which would be a bug in LibSass) or gulp-sourcemaps (which would be a bug in that plugin).

Having read through https://github.com/floridoo/gulp-sourcemaps/issues/209, this appears to be a bug in another library.


Client Ip

How can I access the client's IP address on the client object in aedes event hooks @mcollina ?

you'll need to get it from client.stream I think. It would be nice to document it.

it was client.connection.stream.remoteAddress in mosca if I remember, however in aedes there's no client.connection and I couldn't find it out inside client.stream :(

it's https://github.com/mcollina/aedes/blob/master/lib/client.js#L22.
We can rename that to stream, it might actually be better.

it is client.conn.remoteAddress 👍


Convert To Number ignores precision if it is ${0}

BuiltIn.Convert To Number accepts optional precision. The precision is ignored if it is number 0. Luckily string '0' is handled correctly, and normal data passed to keywords is passed as strings, so this isn't too severe.
*** Test Cases ***
This works
    ${num} =    Convert To Number    3.14    precision=0
    Should Be Equal    ${num}    ${3}
This fails
    ${num} =    Convert To Number    3.14    precision=${0}
    Should Be Equal    ${num}    ${3}

I have seen convert to number  0.90  precision  2  does not give 0.90 instead gives 0.9


All requests are returning 404.

Why would all requests return a 404 response?

Show us your routes file.

Route::group([
  'before' => 'useragent',
  'after' => 'session.cookie.remove'
], function() {
  Route::api([
    'version' => ['v1'],
    'namespace' => 'Api\V1'
  ], function() {
    Route::group([ 'before' => 'oauth' ], function () {
      Route::resource('assessments', 'AssessmentsController', [ 'only' => [ 'show' ] ]);
    });
  });

  Route::api([
    'version' => ['v2'],
    'namespace' => 'Api\V2'
  ], function() {
    Route::group([ 'before' => 'oauth' ], function () {
      Route::resource('assessments', 'AssessmentsController', [ 'only' => [ 'show' ] ]);
    });
  });
});

It looks like when it gets to the Illuminate Router and calls "dispatchToRoute" it has a valid route. However, When it calls $route->run($request), it returns an exception which in turn results in a 404.

Is that not your controller returning a 404?
—
Sent from Mailbox
On Tue, Mar 17, 2015 at 4:49 AM, Geoff Lancaster<EMAIL_ADDRESS>wrote:

It looks like when it gets to the Illuminate Router and calls "dispatchToRoute" it has a valid route. However, When it calls $route->run($request), it returns an exception which in turn results in a 404.
Reply to this email directly or view it on GitHub:
https://github.com/dingo/api/issues/381#issuecomment-82104001

It does look like it's instantiating my controller but for some reason it's
not getting to the action.
On Tue, Mar 17, 2015 at 2:17 AM, Bradley Weston<EMAIL_ADDRESS>wrote:

Is that not your controller returning a 404?
—
Sent from Mailbox
On Tue, Mar 17, 2015 at 4:49 AM, Geoff Lancaster<EMAIL_ADDRESS>
wrote:

It looks like when it gets to the Illuminate Router and calls
"dispatchToRoute" it has a valid route. However, When it calls
$route->run($request), it returns an exception which in turn results in a

Reply to this email directly or view it on GitHub:
https://github.com/dingo/api/issues/381#issuecomment-82104001

—
Reply to this email directly or view it on GitHub
https://github.com/dingo/api/issues/381#issuecomment-82173175.

I have also removed the domain from the config and added it to the parent group. Since I am using a subdomain, I was unsure if that was causing the issue with it being in the config versus the route file.
Route::group([
  'before' => 'useragent',
  'after' => 'session.cookie.remove',
  'domain' => '{apisubdomain}.bsxinsight.com'
], function() {
  Route::api([
    'version' => ['v1'],
    'namespace' => 'Api\V1'
  ], function() {
    Route::group([ 'before' => 'oauth' ], function () {
      Route::resource('assessments', 'AssessmentsController', [ 'only' => [ 'show' ] ]);
    });
  });

  Route::api([
    'version' => ['v2'],
    'namespace' => 'Api\V2'
  ], function() {
    Route::group([ 'before' => 'oauth' ], function () {
      Route::resource('assessments', 'AssessmentsController', [ 'only' => [ 'show' ] ]);
    });
  });
});

Add a dd as the first thing inside the show method see if it gets called.

Also try without any filters.

I have added the dd, it does not get called. Removing the filters does not change anything.

You have sent the headers for the version to use?

Accept: application/vnd.{vendor}.v2+json

Any other thoughts on this?

After continuing to dig through this, the request is able to find the correct route via Illuminate...\Router::dispatchToRoute().
However, when it tries to fire the event 'router.matched' a 404 is immediately returned and the route is not run.

Commenting out the ControllerReviser listening to that event gets me a step further. Still getting the 404 though.

Can you dump your code anywhere? Or arrange a join.me for me to assist you?
—
Sent from Mailbox
On Thu, Mar 19, 2015 at 3:18 PM, Geoff Lancaster<EMAIL_ADDRESS>wrote:

Commenting out the ControllerReviser listening to that event gets me a step further. Still getting the 404 though.
Reply to this email directly or view it on GitHub:
https://github.com/dingo/api/issues/381#issuecomment-83623653

This issue was resolved by adding the Dingo ControllerTrait to my classes. The docs are not clear that this step is required. They make it seem like using the response builder is optional.

I'm going to update the wiki and submit a pull request ASAP.

@jasonlewis I believe the controller trait provides getProperties method which means that all API classes must use the ControllerTrait. The API Documentation makes this sound optional but in fact breaks if not used.

Hey guys, I have the same error. I'm new to Lumen. Kindly take a look on my files and let me now what I'm missing. Thanks.
# app/Api/BaseApiController.php
<?php namespace App\Api;

use Dingo\Api\Routing\ControllerTrait;
use Laravel\Lumen\Routing\Controller as BaseController;

class BaseApiController extends BaseController {
    use ControllerTrait;

    protected function setupLayout()
	{
		if ( ! is_null($this->layout))
		{
			$this->layout = View::make($this->layout);
		}
	}
}

# app/Api/AuthController.php
<?php namespace App\Api;

class AuthController extends BaseApiController
{
    public function index()
    {
    	return ['foo' => 'bar'];
    }
}

# app/Http/routes.php
<?php

$app->get('/', function() use ($app) {
    return $app->welcome();
});

$api = $app['Dingo\Api\Routing\Router'];

$api->version('v1', function ($api) {

    $api->get('auth', 'App\Api\AuthController@index');
});


added variables

Scalr runs executed
Summary

Runs triggered - 1 (click to review)
Successful - 1 (click to review)

Workspaces report
Workspace A
Run mode: Plan Only
Status: Planned and finished ✅
Run overview

Resources to update: 2

scalr_environment.test

name: test_environment

scalr_workspace.test

name: test_workspace

Outputs to update: 2

environment_name: test-environment -> test_environment
workspace_name: test-workspace -> test_ workspace

Scalr runs executed
Summary

Runs triggered - 2 (click to review)
Successful - 1 (click to review)
Failed - 1 (click to review)

Workspaces report
Workspace A

[!WARNING]
Plan contains destructive changes

Run ID: run-1234567
Run mode: Plan Only
Status: Planned and finished ✅
Planned changes

Resources to delete: 1

scalr_environment.test

id: env-123456 -> null
name: test-environment -> null

Workspace B

[!CAUTION]
Run policies failed

Failed policies: 2

forbid_environments_detetion: Production environment "test-prod-environment" cannot be deleted!

Run ID: run-1234567
Run mode: Plan & Apply
Status: Failed ⛔
Planned changes

Resources to delete: 1

scalr_environment.test

id: env-123456 -> null
name: test-prod-environment -> null

Scalr runs report
Summary

Runs triggered - 1 (click to review)
Failed - 1 (click to review)

Workspaces report
Workspace C
Run ID: run-1234567
Run mode: Plan & Apply
Status: Failed ⛔

[!CAUTION]
Plan failed

Errors

Missing variable input
Unresolved module version constraint

/scalr plan ws-1234567

/scalr plan ws-1234567

/scalr plan

⛔ Scalr apply report
Scalr finished execution of runs in all workspaces that are affected by a commit (fc68455). The cumulative and per-workspace report you can find below.
Summary

Runs triggered - 2 (click to review)
Failed - 1 (click to review)
Applied - 1 (click to review)
Overall commit status: Failed ⛔

Per-workspace report
Run ID: run-1234567
Workspace: Workspace-C
Environment: Environment-A
Run mode: Plan & Apply
Status: Failed ⛔
Tags: prod, service-a
Duration: 3m 15s

[!CAUTION]
Apply failed

Errors
  1. making Read request on Azure KeyVault Secret test-secret1: keyvault.BaseClient#GetSecret: Failure responding to request: StatusCode=403 -- Original Error: autorest/azure: Service returned an error. Status=403 Code="Forbidden" Message="Caller is not authorized to perform action on resource.
If role assignments, deny assignments or role definitions were changed recently, please observe propagation time.
Caller: appid=a77dff73-d787-4ac5-a2d7-c65e22142c2e;oid=d4d335d1-0263-431b-af4b-d181b1edec9d;iss=https://sts.windows.net/174d4acd-35d2-408e-96f7-f3b8eb3698f9/
Action: \'Microsoft.KeyVault/vaults/secrets/getSecret/action\'
Resource: \'/subscriptions/cb00b027-8cfc-42e3-abf8-b55c0635d684/resourcegroups/test-rg-name/providers/microsoft.keyvault/vaults/test-vault-name/secrets/test-secret1\'
Assignment: (not found)
DenyAssignmentId: null
DecisionReason: \'DeniedWithNoValidRBAC\'
Vault: test-vault-name;location=westeurope
" InnerError={"code":"ForbiddenByRbac"},
  2. making Read request on Azure KeyVault Secret test-secret2: keyvault.BaseClient#GetSecret: Failure responding to request: StatusCode=403 -- Original Error: autorest/azure: Service returned an error. Status=403 Code="Forbidden" Message="Caller is not authorized to perform action on resource.
If role assignments, deny assignments or role definitions were changed recently, please observe propagation time.
Caller: appid=a77dff73-d787-4ac5-a2d7-c65e22142c2e;oid=d4d335d1-0263-431b-af4b-d181b1edec9d;iss=https://sts.windows.net/174d4acd-35d2-408e-96f7-f3b8eb3698f9/
Action: \'Microsoft.KeyVault/vaults/secrets/getSecret/action\'
Resource: \'/subscriptions/cb00b027-8cfc-42e3-abf8-b55c0635d684/resourcegroups/test-rg-name/providers/microsoft.keyvault/vaults/test-vault-name/secrets/test-secret2\'
Assignment: (not found)
DenyAssignmentId: null
DecisionReason: \'DeniedWithNoValidRBAC\'
Vault: test-vault-name;location=westeurope
" InnerError={"code":"ForbiddenByRbac"},
  3. making Read request on Azure KeyVault Secret test-secret3: keyvault.BaseClient#GetSecret: Failure responding to request: StatusCode=403 -- Original Error: autorest/azure: Service returned an error. Status=403 Code="Forbidden" Message="Caller is not authorized to perform action on resource.
If role assignments, deny assignments or role definitions were changed recently, please observe propagation time.
Caller: appid=a77dff73-d787-4ac5-a2d7-c65e22142c2e;oid=d4d335d1-0263-431b-af4b-d181b1edec9d;iss=https://sts.windows.net/174d4acd-35d2-408e-96f7-f3b8eb3698f9/
Action: \'Microsoft.KeyVault/vaults/secrets/getSecret/action\'
Resource: \'/subscriptions/cb00b027-8cfc-42e3-abf8-b55c0635d684/resourcegroups/test-rg-name/providers/microsoft.keyvault/vaults/test-vault-name/secrets/test-secret3\'
Assignment: (not found)
DenyAssignmentId: null
DecisionReason: \'DeniedWithNoValidRBAC\'
Vault: test-vault-name;location=westeurope
" InnerError={"code":"ForbiddenByRbac"},
  4. making Read request on Azure KeyVault Secret test-secret4: keyvault.BaseClient#GetSecret: Failure responding to request: StatusCode=403 -- Original Error: autorest/azure: Service returned an error. Status=403 Code="Forbidden" Message="Caller is not authorized to perform action on resource.
If role assignments, deny assignments or role definitions were changed recently, please observe propagation time.
Caller: appid=a77dff73-d787-4ac5-a2d7-c65e22142c2e;oid=d4d335d1-0263-431b-af4b-d181b1edec9d;iss=https://sts.windows.net/174d4acd-35d2-408e-96f7-f3b8eb3698f9/
Action: \'Microsoft.KeyVault/vaults/secrets/getSecret/action\'
Resource: \'/subscriptions/cb00b027-8cfc-42e3-abf8-b55c0635d684/resourcegroups/test-rg-name/providers/microsoft.keyvault/vaults/test-vault-name/secrets/test-secret4\'
Assignment: (not found)
DenyAssignmentId: null
DecisionReason: \'DeniedWithNoValidRBAC\'
Vault: test-vault-name;location=westeurope
" InnerError={"code":"ForbiddenByRbac"}

Run ID: run-1234567
Workspace: Workspace-C
Environment: Environment-A
Run mode: Plan & Apply
Status: Applied ✅
Tags: prod, service-b
Duration: 5m 39s

Planned changes: ➕  1 ✏ 2 ➖  3
Planned changes: ✅  1 🔄 2 ❌ 3


Link to change gravatar confusing for users without gravatar account

When I click on the link on my profile I am redirected to https://en.gravatar.com/profiles/no-such-user

This is because I do not have a gravatar account.
It would be much better if users without a gravatar account saw No image found. To add an image Create a Gravatar account with your login email and it linked to the gravatar homepage.

I'd be happy to help with this, @nlhkabu. Should be pretty straightforward and within the scope of my (limited) HTML/CSS experience 😁 .
Are there tests for things like this? Should I add one as part of the change? As I mentioned in #2154, I'm not sure how to add tests that log the user in before inspecting the page.

We don't currently have a lot of tests for the front end code. That's largely because I'm not very good at front end and I don't really have a strong opinion/grasp on how best to test it. Given that, I'm going to assume there isn't any tests for this. If that's the case then you don't need to write one when you fix this bug (although if you do write one, that would be cool too!).


Bug in Excel output

For the first spreadsheet generated (-DESeq_by_gene.xlsx), there is a problem with the column headers being offset by one column. Only happens with TempO-Seq data I believe - the cause is that there is an additional column added for probe name, which makes the "grouped" columns at the very top become out of sync compared to where they are supposed to be. Not a huge deal but should be cleaned up at some point for clarity.

Not sure if you are also working on this code... if so, sorry. We will have to figure it out later (or, this commit might just get over written at some point which is fine too).
I think I have fixed this, but I'm not quite sure why it came on in the first place. At some point I must have added a column.
The column numbers for starting columns are hard-coded, which leads to the difficulty.
My concern is that the headers will now be offset the opposite way for RNASeq data. I can't recall if the column was also added for that analysis type or not. We need some test data sets to establish these kind of things. Good enough for now since we are mostly looking at TempOSeq data at the moment.


Go: Statements, expressions and comments

Need to finish draft for the following:
I) Key concepts:

Statements
Expressions
operators

Note:
All drafts should follow following template:
1) Key concepts
2) Potential interview questions (2-5) with answers and explanation
3) A few practice questions (5-10)

Finished draft for statements n expressions.


luci-proto-mbim: Add MBIM support

Based on luci-proto-qmi
Tested with Sierra Wireless MC7455
Signed-off-by: Howard Chu<EMAIL_ADDRESS>

Should be used in conjunction with https://github.com/openwrt/openwrt/pull/3317

Tested-By: Lech Perczak<EMAIL_ADDRESS>Together with https://github.com/openwrt/openwrt/pull/2759
One suggestion: please add selection of static/DHCP configuration for IP settings, as supported in the mentioned PR - a lot if not the most of MBIM modems use static configuration acquired through MBIM control interface itself - like my Sierra EM7455.
I'd really like to see this merged.

From what I can see, DHCP is never needed. My referenced PR` only reads the IP config from MBIM. https://github.com/openwrt/openwrt/pull/3317

Agreed, IIRC ModemManager also does not use DHCP when setting up MBIM connection. I have yet to see modem not providing configuration through MBIM natively.
CC @sch-m

Fwiw, I used to work on the modem/radio drivers for Android, and we never used DHCP. https://github.com/xdandroid/hardware_xdandroid-ril/commits/gingerbread (DHCP was only used for wifi.)

And yeah, should use https://github.com/openwrt/openwrt/pull/2759 instead of 3317.

On my previous build, this plugin was working 100% fine. After I rebased to current master, LuCI keeps deleting device name with every configration edit, and also consistently deletes and replaces "accept_ra" flag for IPv6. You might like to check this, and look at luci-proto-qmi if something changed recently.

Seems related to 96ee6dc8d6c9796ab67de6f313a068a4bd3bb20f I guess I have to rebase...

@Leo-PL please try again with these updates.

Issue with device overwriting is fixed, however, every update I still get this applied:
uci del dhcp.wan.ra_flags
uci add_list dhcp.wan.ra_flags='none'

That doesn't appear to have anything to do with this PR at all.
luci> git grep ra_flags
modules/luci-mod-network/htdocs/luci-static/resources/view/network/interfaces.js:                                       so = ss.taboption('ipv6-ra', cbiRichListValue, 'ra_flags', _('<abbr title="Router Advertisement">RA</abbr> Flags'),
modules/luci-mod-network/htdocs/luci-static/resources/view/network/interfaces.js:                                               var flags = L.toArray(uci.get('dhcp', section_id, 'ra_flags'));
modules/luci-mod-network/htdocs/luci-static/resources/view/network/interfaces.js:                                               uci.set('dhcp', section_id, 'ra_flags', [ 'none' ]);
luci>

Acknowledged. I'll try to test with other protocols as well.

I found one thing that might come in handy, and which luci-proto-qmi also lacks, at least as of 19.07.x. If you uncheck "Use peer DNS" option, more "generic" protocols show a list to enter custom DNS servers. It's handy to have those if using MBIM as sole WAN interface. MBIM protocol handler itself understands standard list dns entries in /etc/config/network, hidden in 'standard options'.

mark

@hyc since openwrt#4405 was merged, maybe it is good idea to resurrect this. I've made some improvements myself, pushed them to https://github.com/Leo-PL/luci/tree/proto-mbim. Minor adjustment will be needed to configure DHCP and DHCPv6 separately, as this was split before merging upstream.

@Leo-PL great! Maybe opening a new PR can push this change faster.

Yeah, could be, although I need to focus on one thing at a time, and I'd like to be fair with @hyc as well. Struggling with ZTE MF28D Ethernet support right now.

@Leo-PL don't worry about me, as long as something gets merged to make this all work, that's all that matters.

I think it'll be easier if I open new one. I'll likely squash the commits, keeping you as main author, and add needed fixes - this is suitable for adding new package, after all.

Ah, during this whole refactoring I forgot about one more thing: restore a way to enable DHCP-only mode. I made some adjustments to protocol handler itself and will open another PR soon. Update for luci-proto-mbim will follow.

Sounds good.

Created: https://github.com/openwrt/openwrt/pull/12521
Now time for LuCI module.

@hyc can we close this?

Let me know if you want to re-open this.


Adding a metric to track the number of bytes saved by compaction

Also provides a platform for aggregating more metrics in the future.

Codecov Report

Merging #735 into master will decrease coverage by <.01%.
The diff coverage is 46.66%.

@@             Coverage Diff              @@
##             master     #735      +/-   ##
============================================
- Coverage     65.66%   65.65%   -0.01%
  Complexity     3809     3809
============================================
  Files           330      331       +1
  Lines         25246    25265      +19
  Branches       3161     3162       +1
============================================
+ Hits          16578    16588      +10
- Misses         7784     7791       +7
- Partials        884      886       +2

Impacted Files
Coverage Δ
Complexity Δ

...a/com.github.ambry/store/IndexReadPerformance.java
0% <0%> (ø)
0 <0> (ø)
:arrow_down:

...ain/java/com.github.ambry/store/DumpIndexTool.java
0% <0%> (ø)
0 <0> (ø)
:arrow_down:

...main/java/com.github.ambry/store/DumpDataTool.java
0% <0%> (ø)
0 <0> (ø)
:arrow_down:

...ava/com.github.ambry/store/CompactionVerifier.java
0% <0%> (ø)
0 <0> (ø)
:arrow_down:

.../java/com.github.ambry/store/BlobIndexMetrics.java
0% <0%> (ø)
0 <0> (ø)
:arrow_down:

.../com.github.ambry/store/IndexWritePerformance.java
0% <0%> (ø)
0 <0> (ø)
:arrow_down:

.../com.github.ambry.store/StorageManagerMetrics.java
91.89% <100%> (+0.22%)
6 <1> (ø)
:arrow_down:

...ava/com.github.ambry.store/BlobStoreCompactor.java
93.43% <100%> (+0.07%)
119 <0> (+1)
:arrow_up:

...main/java/com.github.ambry.store/StoreMetrics.java
91.83% <100%> (+0.08%)
5 <1> (ø)
:arrow_down:

...com.github.ambry.store/AggregatedStoreMetrics.java
100% <100%> (ø)
1 <1> (?)

... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0435af6...6bc77d0. Read the comment docs.

@pnarayanan comment addressed


AG Grid: "Cannot convert undefined or null to object"

Under certain circumstances - which I can't manage to reproduce in a minimum example - I get a JavaScript error when updating an AG Grid:
TypeError: Cannot convert undefined or null to object
    at Function.entries (<anonymous>)
    at a.evaluate_formatters (measure:1762:51)
    at a.evaluate_formatters (measure:1766:26)
    at a.evaluate_formatters (measure:1766:26)
    at a.evaluate_formatters (measure:1766:26)
    at a.grid_change (measure:1782:18)
    at a.updated (measure:1891:18)
    at He (vue.js:2:11397)
    at Yt (vue.js:2:25339)
    at vue.js:2:26012

I suspect it it caused by the condition if (typeof def == "object") in aggrid.js, which is true for null. But Object.entries(def) fails for def == null. So it should be if (typeof def == "object" && def !== null).
A very similar line is in chartjp.js.

@falkoschindler this would be a good example where tests might help. I have the behavior if None values are part of the data to be sent to aggrid and therefore i keep avoing None values for the time being.

@WolfgangFahl I agree that tests would help. But as mentioned above, I didn't manage to reproduce the issue in a minimum example. The problem occurred in a larger user interface and I just noticed that line in aggrid.js. When handling the null case, the problem was gone.

I have the behavior if None values are part of the data to be sent to aggrid and therefore i keep avoing None values for the time being.

Sorry, I don't get what you are saying.
Since I don't seem to be able to commit to this repository directly, I created PR https://github.com/elimintz/justpy/pull/450 fixing this line.


[storage] new internal API: get_epoch_change_ledger_info()

Motivation
in state-sync get_ledger_info() (now renamed to get_epoch_change_ledger_info() as well) calls storage.get_ledger_info(version) with version always being at an epoch boundary. This provides a new straightforward API to do what it does today (and make it more efficient.)
Have you read the Contributing Guidelines on pull requests?
(Write your answer here.)
Test Plan
(Share your test plan here. If you changed code, please provide us with clear instructions for verifying that your changes work.)
Related PRs
(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/libra/website, and link to your PR here.)

@bors-libra r+

:pushpin: Commit b9f7a03 has been approved by lightmark

:hourglass: Testing commit b9f7a03a73970e9769bb6d1a9eeaae00f6a82f05 with merge 0d90eb25eaba0595f829b58464cdf68fdd953dc8...

:sunny: Test successful - checks-actions_land_blocking_test, checks-circle_commit_workflow
Approved by: lightmark
Pushing 0d90eb25eaba0595f829b58464cdf68fdd953dc8 to master...


Resizing the cropper window

I really like the component :) . I am dealing with large images ( 2500x3500) and when I open it I have to scroll down to make a cropping.
Is there a way to fit it in the screen without loosing the original resolution of the crops ?

Hi @Yashar78 , I've added size option, you can tweak the size value now to increase or decrease the crop window as necessary.
cropped_pic = st_cropperjs(pic=pic, btn_text="Detect!", size=0.5, key="foo")


Include resources needed by tests in sdist

While attempting to package pylatexenc using as a source the pypi-distributed sdist (ie. pylatexenc-2.1.tar.gz), a couple of tests (TestLatexNodes2Text.test_input, TestLatexEncode.test_all) seem to be erroring.
Digging a bit, it seems the cause is that the non-py files in the test/ folder were not included in the .tar.gz distributable, and they are needed by the tests - this PR is a suggestion for including them in the resulting file, in the hopes of being able to run the full test suite accordingly using solely the sdist in future releases:

test/uni_chars_test_previous.txt
test/test_input_1.tex
test/dummy/readme.txt

Thanks for the PR, merged.

Thanks for accepting the suggestion and the quick merging! :)


Making sure to use python3

On my debian install I had to use python3 because python by default was 2.7 version.

Lovely, thanks!


*Fixed #25 - Better image upload response status check

Fixes #25

@xdan I forgot to bump the versions and make the latest tag. Could you do it for me?

Done!) 03.04.2018, 15:09, "Dániel Sebestyén" notifications@github.com:@xdan I forgot to bump the versions and make the latest tag. Could you do it for me?—You are receiving this because you were mentioned.Reply to this email directly, view it on GitHub, or mute the thread.   -- C уважением,Чупурнов Валерийhttp://xdan.ru

Thx :beer:


Update grabl automation yaml syntax

What is the goal of this PR?
Recently we added the support for background monitor script. Therefore we change the foreground job script from script to command.

Superseded by https://github.com/graknlabs/bazel-distribution/commit/9ee5a014721343e7ce0c01056e9326b3ee3862b1


Haskell.nix

add haskell.nix infrastructure

Awesome! I wanted to get this ASAP so we can get CI set up. Will take a look tomorrow, thanks!

Awesome! I wanted to get this ASAP so we can get CI set up. Will take a look tomorrow, thanks!

Is there a reason to not use nixpkgs.haskellPackages? For what it worth, I've been able to run the example using this shell: nix-shell --pure -p "haskellPackages.ghcWithPackages (p: [p.base p.sdl2 p.gl p.containers p.inline-c p.inline-c-cpp p.StateVar p.managed p.cabal-install ])" -p libGL -p SDL2 -p pkgconfig -p gcc

Is there a reason to not use nixpkgs.haskellPackages? For what it worth, I've been able to run the example using this shell: nix-shell --pure -p "haskellPackages.ghcWithPackages (p: [p.base p.sdl2 p.gl p.containers p.inline-c p.inline-c-cpp p.StateVar p.managed p.cabal-install ])" -p libGL -p SDL2 -p pkgconfig -p gcc

@TristanCacqueray I'm in favour of using Haskell.nix - I find it a much more reasonable way to do things (e.g., letting Cabal do the solving, rather than using LTS or some arbitrary package set). This PR does work, but we just had to do some tweaking to get it to work on Darwin.
Btw, you might want to come join us at #dear-imgui.hs:ocharles.org.uk on Matrix if you want to see the "live stream" :)

@TristanCacqueray I'm in favour of using Haskell.nix - I find it a much more reasonable way to do things (e.g., letting Cabal do the solving, rather than using LTS or some arbitrary package set). This PR does work, but we just had to do some tweaking to get it to work on Darwin.
Btw, you might want to come join us at #dear-imgui.hs:ocharles.org.uk on Matrix if you want to see the "live stream" :)

Alright, thank you for the explanation.

Alright, thank you for the explanation.


add support for invokestatic of an InterfaceMethodref

fix for BCEL issue 333

May you add a test that verifies the new behavior?

Sure; might not get to it for a few days.
From: Gary Gregory<EMAIL_ADDRESS>Sent: Saturday, February 15, 2020 1:51 PM
To: apache/commons-bcel
Cc: Mark Roberts; Author
Subject: Re: [apache/commons-bcel] add support for invokestatic of an
InterfaceMethodref (#39)
May you add a test that verifies the new behavior?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/apache/commons-bcel/pull/39?email_source=notifications&email_token=ACODEK7MQM5ZHFIAW6LD52DRDBPSNA5CNFSM4KV4LAM2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEL3XYQY#issuecomment-586644547,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ACODEK5QJB2S5M4WKSHZRNTRDBPSNANCNFSM4KV4LAMQ
.[image: Image removed by sender.]


Crashes the moment a controller connected

On Windows 11, game crashes the moment a controller is connected. If I launch the game with controller already connected, white screen appears then closes. If a controller is connected midway through the menu and gameplay, crashes.
Testing on Xbox Series X controller with the official USB adapter, and Dualshock 4 with the 8bitdo adapter, and connecting the controller directly to USB. Both displays same behaviour. So only works with keyboard. All settings are kept at default. VC redistributable to latest. Any help?

I'm having exactly this issue on Windows 11 using a Dualsense.

I'm having exactly this issue on Windows 11 using a Dualsense.

We debugged the crash on this user's machine, it was a mutex lock in the safetyhook library when applying these particular hooks:

AllowUncompressedBGM (calls safetyhook::create_mid)
FixPegasusClopping (calls safetyhook::create_inline)
PreventDESTSaveCorruption (safetyhook::create_mid)
FixFullPedalChecks (safetyhook::create_inline)

After disabling those hooks it crashes in ReplaceGameUpdateLoop which also sets up a hook, that's about as far as we were able to get today.
The crash was the std::scoped_lock in allocator.cpp of safetyhook:
std::shared_ptr<Allocator> Allocator::global() {
    static std::weak_ptr<Allocator> global_allocator{};
    static std::mutex global_allocator_mutex{};

    std::scoped_lock lock{global_allocator_mutex}; // crash

    if (auto allocator = global_allocator.lock()) {
        return allocator;
    }

Possibly related - these both mention trap_threads which I don't think we saw in the call stacks at any point:

https://github.com/cursey/safetyhook/issues/79
https://github.com/cursey/safetyhook/issues/70

We tried to record a trace with TTD.exe but it errored out. I hope to grab a memory dump next time I'm able to debug on that machine

Are they running with the latest VC redist installed? There was a pretty recent change around the std::mutex constructor which caused issues when an older redist was used, the _DISABLE_CONSTEXPR_MUTEX_CONSTRUCTOR build define is meant to work around that but I'm not sure if it's being applied to all our libraries properly.

I'm on the latest VC redist. Have uninstalled and reinstalled. Still crashing.

Does changing ControllerHotPlug = false in INI make any difference? Maybe an issue with that since you mentioned it crashing if you connected during gameplay, would need to connect controller before launching with that though

Changing ControllerHotPlug to false launches the game without crashes, but it can't detect my controllers. In the controller settings, just shows USB device and default USB device. Doesnt detect my buttons when trying to change button assignment.

I think I know what's wrong. This USB Device detected by the game refers to a wireless USB dongle for a mini keyboard/mouse (https://aliexpress.com/i/1005002288164838.html). When I removed that, my controllers are able to connect without crashes, even with ControllerHotPlug on true.
While I can now play the game with my controller, it is a hassle to remove the USB dongle everytime. Any way around this?

solved this. If I disabled HID game controller in Device Manager for the USB dongle, everything works flawlessly.
Though I now have another issue where my Xbox Series controller connected through the official xbox dongle would turn off mid way through a race. Turning it on would turn it off again. Doesn't happen when using other controllers wirelessly, and certainly doesn't happen in other games.

Are they running with the latest VC redist installed? There was a pretty recent change around the std::mutex constructor which caused issues when an older redist was used, the _DISABLE_CONSTEXPR_MUTEX_CONSTRUCTOR build define is meant to work around that but I'm not sure if it's being applied to all our libraries properly.

We opened the debugger again and the mutex was not crashing at all anymore - to my knowledge the C++ DLLs were already on the latest version so not entirely sure what went wrong there or what might have changed in between the last debugging session and this one
Instead it was crashing on Game::DInput_EnumJoysticksCallback when trying to pass a particular input device to the game - it was a Mayflash Wii sensor bar, unplugging fixed that and everything is fine now


Removes deprecated 'id' option in 'spo site set'. Closes #1536

Removes deprecated 'id' option in 'spo site set'. Closes #1536

Coverage remained the same at 100.0% when pulling c726ba13921c2aa844189cb88389f3cc5bad0942 on waldekmastykarz:remove-site-set-id into fe516654e3e2c29dde00a53a00187f392d2097f1 on pnp:v3.

Merged manually


presetController semms to not expand macros in files listed in the "include" section

Brief Issue Summary
When including other preset files depending on a macro, they are not expanded by the presetController, e.g. when I have in the preset
{
    "version": 9,
    "cmakeMinimumRequired": {
        "major": 3,
        "minor": 30,
        "patch": 0
    },
    "include": [
        "CMake${hostSystemName}Presets.json"
    ]
}

the presetController prints:
[presetController] Included presets file C:\Repositories\my-repo\CMake${hostSystemName}Presets.json cannot be found

The configure presets from the platform dependent preset are not shown in the ide. When I do cmake --list-presets those configuration presets are listed. According to the documentation version 9 should be able to expand macros, see https://cmake.org/cmake/help/latest/manual/cmake-presets.7.html#includes or https://discourse.cmake.org/t/presets-conditional-config/3864/11
When I explicitly change the include to "CMakeWindowsPresets.json" the configure presets are shown in the ide.
CMake Tools Diagnostics
{
  "os": "win32",
  "vscodeVersion": "1.96.2",
  "cmtVersion": "1.19.52",
  "configurations": [
    {
      "folder": "c:\\Repositories\\my-repo",
      "cmakeVersion": "3.31.2",
      "configured": true,
      "generator": "Ninja",
      "usesPresets": true,
      "compilers": {
        "C": "C:/Program Files (x86)/rtools44/x86_64-w64-mingw32.static.posix/bin/gcc.exe",
        "CXX": "C:/Program Files (x86)/rtools44/x86_64-w64-mingw32.static.posix/bin/g++.exe"
      }
    }
  ],
  "cpptoolsIntegration": {
    "isReady": false,
    "hasCodeModel": false,
    "activeBuildType": "",
    "buildTypesSeen": [],
    "requests": [],
    "responses": [],
    "partialMatches": [],
    "targetCount": 0,
    "executablesCount": 0,
    "librariesCount": 0,
    "targets": []
  },
  "settings": [
    {
      "communicationMode": "automatic",
      "useCMakePresets": "auto",
      "configureOnOpen": true
    }
  ]
}

Debug Log
[presetController] Reading presets file C:\Repositories\my-repo\CMakePresets.json
[presetController] Reading and validating the presets "file C:\Repositories\my-repo\CMakePresets.json"
[presetController] Successfully validated C:\Repositories\my-repo\CMakePresets.json against presets schema
[presetController] Included presets file C:\Repositories\my-repo\CMake${hostSystemName}Presets.json cannot be found
[presetController] Expanding presets file C:\Repositories\my-repo\CMakePresets.json
[presetController] Successfully expanded presets file C:\Repositories\my-repo\CMakePresets.json

Additional Information
No response

@maximiliank This is only supported currently in the pre-release version. Could you please switch to that and confirm that it's working as expected?

@gcampbell-msft thank you for your quick reply. I just tried the pre release version and confirm that it works as expected.