Bun runtime fails<EMAIL_ADDRESS>- defaults to it without warning when node isn't installed

Describe the Bug
I recently had an issue with React-Mail closing without any error when running with bun (installed on WSL), see reproduction here: https://github.com/codeScourge/react-email. I was able to workaround by downgrading to<EMAIL_ADDRESS>The error seemed to be fixed by installing Node in WSL, as proposed by gabrielmfern:

I think I've figured it out. When running on WSL you might have not installed Node at all, in that case, it seems like it fails the same you mentioned. It also fails the same way when running with bun --bun dev while having Node installed. So it seems like bun falls back to running with its runtime if Node isn't installed, so basically it runs bun --bun dev. Haven't checked on their code and I couldn't find anything related to this on their docs.

Which package is affected (leave empty if unsure)
No response
Link to the code that reproduces this issue
https://github.com/codeScourge/react-email
To Reproduce
https://github.com/codeScourge/react-email, see ReadME
Expected Behavior
it should start a dev server
What's your node version? (if relevant)
No response

Bun doesn't contain all the dependencies required to run next. For example: bun -b email dev
and bun -b email build relies on TextDecoderStream which isn't supported in bun yet

Thinking a bit more about this, this isn't exactly an issue on our side. The behavior of Bun defaulting to itself is mostly fine, but the regarding about what the problem is here is that Bun does not support to be used as a runtime for React Email at all.
Sorry for the confusion in asking for you to open this, closing it as not planned for now.


Add construction examples to docstrings of ClassicallyControlledOperation

Description of the issue
The docs should give a couple of concrete examples of construction, since conditions is not immediately clear on seeing operation.with_classical_controls(*conditions)
https://github.com/quantumlib/Cirq/blob/90679d27e0967c0a7fe59848e789a5d6ba49b66d/cirq-core/cirq/ops/classically_controlled_operation.py#L37-L48
Cirq version
0.14.0.dev

Hi @tanujkhattar .
I'd like to work on this issue. Could you please assign it to me?


pub install fails if there is an existing secondary "packages" that's a broken symlink

To repro:

Make a package with a "web" directory.
Make a broken "packages" symlink in web:

cd web
ln -s packages /bad/path

Run pub install.

I'll have to investigate, but this may be blocked on http://code.google.com/p/dart/issues/detail?id=4775.

This issue has been moved to dart-lang/pub#429.


Atom parsing: MWFeedItem 'link' is null

Just tried an example app, iOS 8.4 simulator, Xcode 7, URL is http://highaltitudehacks.com/atom.xml.
I noticed that in case of Atom parsing - 'link' property of MWFeedItem is null.
Why is that? Any ideas how to fix that?
Best

#96 provide solution how to fix it.
Thanks @nmdias


fix(table): hover on rows

Describe pull-request
Tabel rows were missing hover color on its rows when mode-variant was used.
Solving issue
Fixes: CDEP-2047
How to test

Go to the preview link below
Hover over table rows, the background color should change
Select mode-variant, hover background color on rows should be present
Select the "Multiselect" story, and select one of the rows - it should change the background color as long as it is selected. Also, the background color of it should change on hover.
Do the same test for light and dark mode

Suggested test steps

[ ] Browser testing (Chrome, Safari, Firefox)
[ ] Keyboard operability
[ ] Interactive elements have labels.
[x] Storybook controls
[ ] Design/controls/props is aligned with other components
[x] Dark/light mode and variants
[ ] Input fields – values should be displayed properly
[ ] Events

Additional context

In light mode: The hover color is usually one step darker than the regular state of the row. The selected state is one step darker than the hover.
In dark mode: The hover color is usually one step brighter than the regular state of the row. The selected state is one step brighter than the hover.

Tested in browsers: Chrome, Edge, Safari, Firefox; light and dark modes:
The background color for “Inherit from parent” and “Primary” is the same. - looks fine
Hover (and other applied styles) are presented on interaction. - looks fine


Adding labels to denote PR state.

State machine for https://github.com/kubernetes/kubernetes/issues/31260
In order to figure out whose court a PR is in, we currently only use the last IssueComment on the PR.
Future work:

Also switch state based on push and reviewComment additions.
Creating the relevant labels in the repository.
Turn up the state machine in contrib.

This change is

/ack
I'm reviewing it ;-)

Reviewed 10 of 11 files at r1, 1 of 1 files at r2.
Review status: all files reviewed at latest revision, 10 unresolved discussions.

mungegithub/github/testing/github.go, line 129 [r2] (raw file):

// User returns a github user with the necessary details filled in.
func User(name string) *github.User {

Is this used? Can't find it

mungegithub/mungers/fsm/changes-needed.go, line 33 [r1] (raw file):
Previously, grodrigues3 wrote…
> this is only for PRs right?  maybe add a check to verify that the object is not an issue

That's a very good point, but it shouldn't be addressed here. (checking) It's addressed where it should, before we start the FSM.

mungegithub/mungers/fsm/needs-review.go, line 39 [r2] (raw file):

// this state, or proceed to the next.
func (nr *NeedsReview) Process(obj *github.MungeObject) (State, error) {
	var reviewerActionNeeded bool

nit: not a huge fan of these early initialization

mungegithub/mungers/fsm/needs-review.go, line 70 [r2] (raw file):

}

func (nr *NeedsReview) checkLGTM(obj *github.MungeObject) bool {

not super useful :-)

mungegithub/mungers/fsm/needs-review.go, line 75 [r2] (raw file):

// assigneeActionNeeded returns true if we are waiting on an action from the reviewer.
func isReviewerActionNeeded(obj *github.MungeObject) (bool, error) {

What about the date of the last push? Doesn't it matter? Otherwise, how do you get out of this state

mungegithub/mungers/fsm/needs-review.go, line 96 [r2] (raw file):

}

func getLastReviewerComment(obj *github.MungeObject, comments []*githubapi.IssueComment) *githubapi.IssueComment {

A couple of "technical" points, not "business":

You can return time.Time, considering you don't care about the actual issue
Make a better matcher, and use the LastComment() method (that only returns the time.Time)

mungegithub/mungers/fsm/prereview.go, line 42 [r2] (raw file):

// this state, or proceed to the next.
func (p *PreReview) Process(obj *githubhelper.MungeObject) (State, error) {
	success := true

Can you simplify the condition? I initially thought that each "check" function had a side-effect (and NEEDED to be executed). But they don't, so you could just make that a big test.n

mungegithub/mungers/fsm/states.go, line 32 [r2] (raw file):

// ComputeState can be used to compute the state of each PR.
func ComputeState(obj *github.MungeObject) error {
	if !obj.IsPR() {

Cool, that answers Garrett's concern

mungegithub/mungers/fsm/states.go, line 38 [r2] (raw file):

	// Every PR starts in the pre-review state.
	var currentState State = &PreReview{}
	var err error

can you narrow the scope of err

Comments from Reviewable

Reviewed 2 of 2 files at r3.
Review status: all files reviewed at latest revision, 10 unresolved discussions.

Comments from Reviewable

Review status: all files reviewed at latest revision, 9 unresolved discussions.

mungegithub/mungers/fsm/changes-needed.go, line 33 [r1] (raw file):
Previously, foxish (Anirudh Ramanathan) wrote…
> That check is performed before the state machine is invoked.

Done.

mungegithub/mungers/fsm/end.go, line 27 [r1] (raw file):
Previously, foxish (Anirudh Ramanathan) wrote…
> Fixed.

Done.

mungegithub/mungers/fsm/needs-review.go, line 39 [r2] (raw file):
Previously, apelisse (Antoine Pelisse) wrote…
> nit: not a huge fan of these early initialization

Done.

mungegithub/mungers/fsm/needs-review.go, line 70 [r2] (raw file):
Previously, apelisse (Antoine Pelisse) wrote…
> not super useful :-)

The plan is to later have the nagging code being invoked from within the check functions.

mungegithub/mungers/fsm/needs-review.go, line 75 [r2] (raw file):
Previously, apelisse (Antoine Pelisse) wrote…
> What about the date of the last push? Doesn't it matter? Otherwise, how do you get out of this state

Will add that check. We can get last commit date, but probably not the last push event right?

mungegithub/mungers/fsm/states.go, line 38 [r2] (raw file):
Previously, apelisse (Antoine Pelisse) wrote…
> can you narrow the scope of `err`

Done.

Comments from Reviewable

mungegithub/mungers/fsm/needs-review.go, line 75 [r2] (raw file):
Previously, foxish (Anirudh Ramanathan) wrote…
> Will add that check. We can get last commit date, but probably not the last push event right?

Yep, date of last commit is good enough

Comments from Reviewable

Reviewed 1 of 1 files at r4.
Review status: 7 of 9 files reviewed at latest revision, 7 unresolved discussions.

Comments from Reviewable

recomputing cla status...

if the state machine was active for this PR, who's action would be required :) @apelisse @foxish

@grodrigues3 Mine. Should have a new set of changes for review by tomorrow, and then I can hand off the rest, such as pinging based on the state. The work that remains here is to consider the github push events to decide whose court it is in.

Review status: 5 of 8 files reviewed at latest revision, 7 unresolved discussions.

mungegithub/mungers/fsm/needs-review.go, line 75 at r2 (raw file):
Previously, apelisse (Antoine Pelisse) wrote…
> Yep, date of last commit is good enough

Done.

mungegithub/mungers/fsm/needs-review.go, line 96 at r2 (raw file):
Previously, apelisse (Antoine Pelisse) wrote…
> A couple of "technical" points, not "business":
> - You can return time.Time, considering you don't care about the actual issue
> - Make a better matcher, and use the LastComment() method (that only returns the time.Time)

Done.

mungegithub/mungers/fsm/prereview.go, line 42 at r2 (raw file):
Previously, apelisse (Antoine Pelisse) wrote…
> Can you simplify the condition? I initially thought that each "check" function had a side-effect (and NEEDED to be executed). But they don't, so you could just make that a big test.n

It is going to accommodate the pinger in the follow-up PRs, which is why we had the check* functions this way I think.

Comments from Reviewable

@apelisse @grodrigues3 PTAL

Review status: 5 of 8 files reviewed at latest revision, 6 unresolved discussions.

mungegithub/mungers/fsm/needs-review.go, line 96 at r2 (raw file):
Previously, foxish (Anirudh Ramanathan) wrote…
> Done.

Not really but whatever ;-)

mungegithub/mungers/fsm/needs-review.go, line 51 at r6 (raw file):

	}

	reviewerActionNeeded, err := isReviewerActionNeeded(obj)

Cool xD

Comments from Reviewable

LGTM for me,
I want to see that move forward, thanks Foxish!

ping @grodrigues3

/lgtm


About paper content

Hello, I have read your paper, and I understand that you control the actions based on the expression coefficients of FLAME. However, from my understanding, these coefficients do not include descriptions of jaw/lip movements. Could you please explain what controls these particular actions?

The expression code we use includes expression coefficients and jaw pose. But of course it is still hard to control extremely slight motions, which are not well tracked.


DRAFT: Add New (Optional) Non-Differential Quorum Algorithm

There are problems with Geode's current quorum algorithm. In particular, split-brains are possible if locators are started at the same time, or if they are started during a network partition (and can't reach other locators).
This (draft) PR introduces an alternative quorum maintenance algorithm, activated by a new optional configuration parameter quorum-absolute-locator-count. When it's configured to a value greater-than-zero, two things are done differently:

when a locator is starting or restarting, and it might potentially become the coordinator, it can become the coordinator only if it has communicated with quorum-absolute-locator-count locators (including itself).

when a coordinator is considering whether a view change might result in a loss of quorum, rather than basing that decision on the change in membership weight between the current view and the prospective one, the locator count in the prospective view is compared to quorum-absolute-locator-count. If the locator count is below the threshold then it's treated as lost quorum, with all the usual processing that happens in that event.

The ability to switch between the legacy quorum algorithm and this new one is accomplished via a new policy object. GMSJoinLeave has a reference to a Quorum object. Legacy behavior is captured in the DifferentialQuorum implementation, and the new algorithm is embodied in the AbsoluteQuorum implementation. GMSJoinLeave delegates to the Quorum object in the GMSJoinLeave.isLostQuorum() method. (That method used to be called isNetworkPartition() but it was renamed since quorum can be lost due to reasons other than a network partition.)
In the legacy quorum algorithm, no quorum checking is done at cluster startup (when a coordinator is chosen). The new algorithm has to operate there. As a result GMSJoinLeave.findCoordinator() was modified to delegate to the Quorum object (so that the new algorithm can prevent cluster formation if too few locators are currently reachable).
This PR is very drafty so be kind.
Checklist:

[ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?

[ ] Has your PR been rebased against the latest commit within the target branch (typically develop)?

[ ] Is your initial contribution a single, squashed commit?

[ ] Does gradlew build run cleanly?

[ ] Have you written or updated unit tests to verify your changes?

[ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?

this PR appears to be abandoned, can it be closed?

Closing this out due to age.


Update readme

Goal
update read me

@mehrdadmms, Could you please share the production URL and commercial name for the project?

prod url: https://impact.pokt.network/
Name: Retroactive POKT Goods Funding
description:
POKT’s experimental first round of retroactive grants is open to projects & individuals for contributions that delivered impact to the POKT ecosystem.


Graph Theory Lesson

Depth First Search
Breadth First Search
Minimum Spanning Tree
Dijkstra's
All Pairs Shortest Path (Floyd-Warshall)
Max Flow?


how to query str type attribute like

u have query float attribute, int, double, ....
can not find query string attribute
how to get the string : MDC_ECG_INTERPRETATION_STATEMENT here ???

could u give a demo to QueryStringAttribute
the interface is C string ,  why not modify the interface to  string &

You use GetText():
Andrew
Get Outlook for iOShttps://aka.ms/o0ukef

From: eigen2017<EMAIL_ADDRESS>Sent: Friday, March 23, 2018 4:17:12 AM
To: leethomason/tinyxml2
Cc: Subscribed
Subject: Re: [leethomason/tinyxml2] how to query str type attribute like  (#665)
could u give a demo to QueryStringAttribute
the interface is C string , why not modify the interface to string &
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHubhttps://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fleethomason%2Ftinyxml2%2Fissues%2F665%23issuecomment-375539882&data=02|01||cc82017ebcbe4192e3e508d59074f639|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|636573754369455327&sdata=VedVXLk8KpS%2Fr9y8RCHK7nfW6KUhDDPVN3x9jb3KqJE%3D&reserved=0, or mute the threadhttps://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAHnYs6sCJtoFIG0FEiVFNg_WCMkAvxWkks5thHdIgaJpZM4S4Joj&data=02|01||cc82017ebcbe4192e3e508d59074f639|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|636573754369455327&sdata=q3pcGwHbVgOM0waLDRnXFZ0exEp3RYgldo2e2%2FAUWLg%3D&reserved=0.

Oops. That was wrong. Sorry.
Get Outlook for iOShttps://aka.ms/o0ukef

From: eigen2017<EMAIL_ADDRESS>Sent: Friday, March 23, 2018 4:17:12 AM
To: leethomason/tinyxml2
Cc: Subscribed
Subject: Re: [leethomason/tinyxml2] how to query str type attribute like  (#665)
could u give a demo to QueryStringAttribute
the interface is C string , why not modify the interface to string &
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHubhttps://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fleethomason%2Ftinyxml2%2Fissues%2F665%23issuecomment-375539882&data=02|01||cc82017ebcbe4192e3e508d59074f639|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|636573754369455327&sdata=VedVXLk8KpS%2Fr9y8RCHK7nfW6KUhDDPVN3x9jb3KqJE%3D&reserved=0, or mute the threadhttps://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAHnYs6sCJtoFIG0FEiVFNg_WCMkAvxWkks5thHdIgaJpZM4S4Joj&data=02|01||cc82017ebcbe4192e3e508d59074f639|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|636573754369455327&sdata=q3pcGwHbVgOM0waLDRnXFZ0exEp3RYgldo2e2%2FAUWLg%3D&reserved=0.

XMLElement * pNodeComponentCode = pNodeComponent->FirstChildElement("code");
if (pNodeComponentCode == NULL)
{
continue;
}
    string pNodeComponentCodeStr = pNodeComponentCode->Attribute("code");

Yep. 😀
Sent from my iPhone
On 23 Mar 2018, at 05:42, eigen2017 <notifications<EMAIL_ADDRESS>wrote:
XMLElement * pNodeComponentCode = pNodeComponent->FirstChildElement("code");
if (pNodeComponentCode == NULL)
{
continue;
}
string pNodeComponentCodeStr = pNodeComponentCode->Attribute("code");

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHubhttps://eur02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fleethomason%2Ftinyxml2%2Fissues%2F665%23issuecomment-375551339&data=02|01||05830f4151f2413831d808d59080ea46|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|636573805709094148&sdata=KCFHWtHHyz6ZpDIjS%2F1CbV09JUPWUBQc3qL1XqOEraU%3D&reserved=0, or mute the threadhttps://eur02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAHnYs4HLdKuA_0RzaWINvmK6BJsb7NFnks5thItZgaJpZM4S4Joj&data=02|01||05830f4151f2413831d808d59080ea46|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|636573805709094148&sdata=sajm4l7hJ%2FKtMDkkoqHxnIYd51QZzix0Dkn2G4jZ6U4%3D&reserved=0.

I don't think that is quite right. I dont think an attribute is condiered a child element. This is how I verify the existence of an attribute and then read the string value:
// We need to get the assistant
const XMLAttribute *pAttrAssistant = const_cast<const XMLElement*>(pStudent)->FindAttribute("Assistant");
if (pAttrAssistant != nullptr)
{
	LPCTSTR szAssistant = CA2CT(pAttrAssistant->Value(), CP_UTF8);
	// Do whatever ...
}
else
{
	// TODO: Throw exception if Assistant attribute missing
}

Yes, XMLElement::Attribute() is the correct way to query. It is returned as a const char* since TinyXML-2 doesn't use STL, it has no string class.


Getting Started

Hi, is there any document about how to get started with OpenSearch. Specifically, how can I deploy, thanks.

Hello @ruanwenjun try looking at the dev guide https://github.com/opensearch-project/OpenSearch/blob/main/DEVELOPER_GUIDE.md
There will be a packaged build soon, but for now you must build OpenSearch and OpenSearch Dashboards yourself.

You can assign to me, or just close this as we've fixed this in #549 thx!

@jkowall Cool


[FEATURE] Add checkbox/notifications option to user to choose get notified about events and more

Detailed description
We can add in registration time, or in setting to enable it, like a toggle button
all notifications, event notifications etc so users could decide to receive updates and promotions.
Context
User need to have an option to decide if they want to be notified so it will not be a spam for them and they will have unsubscribe from notifications option.
Possible implementation
In registration add checkbox

and in settings add toggle buttons
Additional information
No response
Code of Conduct

[X] I agree to follow this project's Code of Conduct

Hey there I am new to open source and would like to contribute to this feature. It'd be a great help if you could direct me to the folder wherein this need to be implemented and describe the feature a bit further.

step one:
https://dev.thecyberhub.org/#/register

Currently, when users register they check the "I agree to all statements included in Terms of Use " need to add another check box like in the image

@Happyashbunny you can start from step one :)
step two:
https://dev.thecyberhub.org/#/dashboard/settings/profile
@kabir0x23 in which tab, do you want to add the toggle button so users can turn on / off the option to get updates?

@ArkadiK94 Thank you for assigning me. I am on it.

@ArkadiK94 I've made a PR #636 please lemme know, if any further changes are to be made.

@Happyashbunny Thanks for your contribution, I will check it shortly and let you know.

@Happyashbunny I reopened this issue for the step two.

@kabir0x23 in which tab, do you want to add the toggle button so users can turn on / off the option to get updates?

@kabir0x23

@kabir0x23 in which tab, do you want to add the toggle button so users can turn on / off the option to get updates?

@kabir0x23

hi
We can do this in two side, events section and settings > notifications section as well

@Happyashbunny would you like to work on this as well?

@ArkadiK94  Sure, I'd be happy to work on this as well. Lemme know what I'm supposed to do.

@kabir0x23 do you have an idea of how to display this section?

@kabir0x23 do you have an idea of how to display this section in settings?

yes, link this
we can do in new iisse

@kabir0x23 I am closing this issue because I created a new one for next step


Add roadmap

Adds a roadmap page and links to it from the home page. Content has already been reviewed and approved.

You can preview this change here:
Built with commit f5a725dcb76914430764559770e6355ef8feb0c0
https://deploy-preview-341--govuk-design-system-preview.netlify.com


Updat DeltaModel

This PR updates the DeltaModel from waymax. From this PR, you can select the one of dynamics models, bicycle model or delta model and differnt action spaces called DeltaAction which consists of dx, dy, and dyaw. Here's how it works:

In c++ side, if you set useDeltaModel as True and ControlMode::DELTA, GPUDrive runs with DeltaAction.
In python side, set use_delta_model=True and use_waymax_model=False' from pygpudrive/env/config.py`, it changes the action space and dynamcis model.
Last three dimension of expertTrajectroies are DeltaAction. If u turn off the DeltaModel, it fills with zero.
For testing, run pytest for testing test_delta_model.py and run python algorithms/il/data_generation_delta.py for getting videos how DeltaModel moves.

Also, moved the codes of BicycleModel in python side from dc/il branch.

Can you also run clang-format once you have the final commit in ?


Negative min/max or rhs in Symbolic

Edit: This is actually a minor bug rather than a major issue. I apologize for the false positive.
Symbolic is agnostic to div/mod implementation of backends.

Even though Variable() constructor doesn't allow negative min/max, still there are
some bugs in div and mod implementation.
Floor division

Two kinds of floor divisions:

round towards zero (C) -21//5 => -4.2 => -4
round towards negative infinity (Python) -21//5 => -4.2 => -5

As mod depends on floor division, two mod operations as well.

A div expression: lhs//rhs

These two only differ if one of lhs or rhs operand to div is negative.

ShapeTracker doesn't use negative rhs values for div and mod.
But lhs's min/max can be negative because of negative values in strides.
Or by using operations like a-10 or a*-1 which clearly produce negative
min/max.

So symbolic's output is currently not agnostic to the div implementation of
a backend (or any program that evaluates the rendered expression).

Symbolic should be able to produce output for both kinds of implementations and
let backends choose which one it wants. Another option is to select one implementation
in symbolic and let backends match/convert their implementation to symbolic's.

Yet another option is to make sure users of symbolic never pass negative lhs to div or mod.

Conflicting tests!

First test expects C like div and second test expects Python like.
7//-2 equals -4 in Python and -3 in C

https://github.com/tinygrad/tinygrad/blob/9746f6d09412241adb6ce9b64e06cbd0a46e8689/test/unit/test_symbolic.py#L110-L111

-90//11 equals -9 in Python and -8 in C

https://github.com/tinygrad/tinygrad/blob/9746f6d09412241adb6ce9b64e06cbd0a46e8689/test/unit/test_symbolic.py#L207-L208

Questions

What are the exact requirements of the symbolic library?
Constraints on min, max and rhs?
Which kind of div and mod do each of the backends implement?

#1345 fixes this issue as well as the "infinite recursion in mod if negative variables" issue.

no symbolic anymore


VW MQB: Start documenting FtS cars

At present, CARS.md and the comma website promise full Stop-and-Go support for all VW MQB. This isn't really true. At the lower end, some of them only support Follow-to-Stop. Those will only stay at standstill for 3 seconds, and then disengage and start rolling.
As a general rule, if you have an automatic transmission and an electric parking brake, you should have Stop-and-Go. If you have a handbrake, you'll have Follow-to-Stop at best. The only known exception is MQB-A0 (VW Polo and cousins) on which we've found the ABS/ESP happily does Stop-and-Go for openpilot even though the stock ACC radar doesn't make full use of it. Vehicles with manual transmissions only allow openpilot ACC control down to about 10mph.
Worldwide brand and model packaging for Stop-and-Go is complex. Volkswagen Golf is by-far the worst offender due to the number of sub-models and high sales volume. Starting there, and I'll come back to add more later once I figure out a better systematic way to validate brand and model support.

[x] pending merge of #28264

GTM!

⚠ This PR makes changes to CARS.md ⚠
🔀 Column Changes

Make
Model
Supported Package
ACC
No ACC accel below
No ALC below
Steering Torque
Resume from stop
Hardware Needed
Video

Volkswagen
Golf 2015-20
Adaptive Cruise Control (ACC) & Lane Assist
openpilot available1,9
0 mph
0 mph

 ➡
View- 1 harness box- 1 J533 connector- 1 long OBD-C cable- 1 mount- 1 right angle OBD-C cable (1.5 ft)- 1 USB-C couplerBuy Here

Volkswagen
Golf Alltrack 2015-19
Adaptive Cruise Control (ACC) & Lane Assist
openpilot available1,9
0 mph
0 mph

 ➡
View- 1 harness box- 1 J533 connector- 1 long OBD-C cable- 1 mount- 1 right angle OBD-C cable (1.5 ft)- 1 USB-C couplerBuy Here

Volkswagen
Golf GTI 2015-21
Adaptive Cruise Control (ACC) & Lane Assist
openpilot available1,9
0 mph
0 mph

 ➡
View- 1 harness box- 1 J533 connector- 1 long OBD-C cable- 1 mount- 1 right angle OBD-C cable (1.5 ft)- 1 USB-C couplerBuy Here

📖 Detail Sentence Changes

Sentence for Volkswagen Golf 2015-20 changed!- openpilot upgrades your Volkswagen Golf with automated lane centering at all speeds, and adaptive cruise control that automatically resumes from a stop. Traffic light and stop sign handling is also available in Experimental mode.
+ openpilot upgrades your Volkswagen Golf with automated lane centering at all speeds, and adaptive cruise control. Traffic light and stop sign handling is also available in Experimental mode.

Sentence for Volkswagen Golf Alltrack 2015-19 changed!- openpilot upgrades your Volkswagen Golf Alltrack with automated lane centering at all speeds, and adaptive cruise control that automatically resumes from a stop. Traffic light and stop sign handling is also available in Experimental mode.
+ openpilot upgrades your Volkswagen Golf Alltrack with automated lane centering at all speeds, and adaptive cruise control. Traffic light and stop sign handling is also available in Experimental mode.

Sentence for Volkswagen Golf GTI 2015-21 changed!- openpilot upgrades your Volkswagen Golf GTI with automated lane centering at all speeds, and adaptive cruise control that automatically resumes from a stop. Traffic light and stop sign handling is also available in Experimental mode.
+ openpilot upgrades your Volkswagen Golf GTI with automated lane centering at all speeds, and adaptive cruise control. Traffic light and stop sign handling is also available in Experimental mode.


Debian repository contains unneeded "linuxconfig"

Does this issue occur when all extensions are disabled?: Yes

VS Code Version: Any
OS Version: Any

Steps to Reproduce:

Install vscode apt repository
A package linuxconfig is available on the system (but not installed)

Issue #70611 was closed as vscode doesn't depends on linuxconfig, however it is not a problem of dependencies. The problem is that packages unrelated to vscode are present in the repo.
$ apt-cache policy linuxconfig
linuxconfig:
  Installed: (none)
  Candidate: (none)
  Version table:
     1.0 500
        500 https://packages.microsoft.com/repos/vscode stable/main amd64 Packages

$ curl -s https://packages.microsoft.com/repos/vscode/dists/stable/main/binary-amd64/Packages | grep linuxconfig
Package: linuxconfig
Maintainer: linuxconfig.org
Filename: pool/main/l/linuxconfig/linuxconfig_1.0_amd64.deb
Description: Print linuxconfig.org on the screen

The package itself is present at https://packages.microsoft.com/repos/vscode/pool/main/l/linuxconfig/linuxconfig_1.0_amd64.deb

Removed.
Verification steps:

Navigate to https://packages.microsoft.com/repos/vscode/pool/main/l/linuxconfig
Confirm you get a 404 error


ui_level nodes marked as not properly configured when using projects

Describe the bug
I`m using projects. Mainly to transfer my flow from my development laptop to my "live" server.
After a push/pull all my ui_level nodes on the destination machine are marked as not properly configured

The edit panel don`t show errors and a simple "done" fix the "error"
Not a big deal but little bit annoying if you have to do this with many nodes all over again.
Environment and versions (please complete the following information):

OS: Windows 10
Browser Chrome latest
Node-RED version 1.0.3
Dashboard version 2.19.3
ui-level version 0.1.24

Additional context
Add any other context about the problem here.

Tried to find the reason but no luck so far. I leave the issue open for a while, maybe some bright ideas pop up at some day..

No problem I can work with it.
Perhaps you have a config property marked as required which is not saved correctly and default to a acceptable value as soon as the config dialog opens or some "legacy" ;) properties.


how to change the code to crawl data from following website

http://fund.jrj.com.cn/archives,001644,jjjz.shtml
Hello,
I want to crawl the data from this website, could you help explain how to do it?
is there any example available?

First of all, you have to understand the basic principles of WebSpider.

make the best of Google.


Feat/support 4844

[x] Use patched ethers-rs to support blob tx.
[x] Read sidecar from beacon url
[x] Parse/decode blob data from sidecar response
[x] Pass tx blob list to guest.
[ ] Update public input to support tx blob hash.
[ ] Check blob validness in guest

Closed due to dup https://github.com/taikoxyz/raiko/pull/35.


Add extra request options

I want to make POST requests using jsdom.env, so this pr adds the ability to define extra request options in config.request.
I can add tests if you want, I just need to know where to put those tests.

A good place to place a test case for this would be test/jsdom/env.js. Here is an example from that file:
exports["explicit config.url, valid"] = t => {
  const html = "<title>Example URL</title>Example!";
  const responseText = "<!DOCTYPE html>" + html;

  const server = http.createServer((req, res) => {
    res.writeHead(200, { "Content-Length": responseText.length });
    res.end(responseText);
    server.close();
  }).listen(8976);

  env({
    url: "http://localhost:8976/",
    done(err, window) {
      t.ifError(err);
      t.equal(serializeDocument(window.document), responseText);
      t.equal(window.location.href, "http://localhost:8976/");
      t.equal(window.location.origin, "http://localhost:8976");
      t.done();
    }
  });
};

This creates a temporary node http server. You could add tests such as t.equal(req.method, 'POST") (see https://nodejs.org/api/http.html#http_http_incomingmessage)

Ok, added a test and updated the README.

Whoops. My bad. Fixed.

I don't really understand this PR. If you want all the flexibility of request, you should just use request:
request({ ... lots of options ... }, function (error, response, body) {
  jsdom.jsdom(body, jsdomOptions);
});

This also has the advantage of making it clear that you're using request, instead of having to read the jsdom documentation which refers you to the request documentation.


Bugfix: read zarr from s3

This pull request resolves #13
Description of Changes

ome-zarr expects a fully-qualified URI and does not accept AbstractFileSystem object. So we use fs.unstrip_protocol to recover the fully-qualified URI that BioImage has stripped the protocol from.

Additional changes

Improved docstring for Reader
Added detail UnsupportedFileFormatError error message

Testing

Added a test against a public S3 bucket to this repo (it passes on my machine).
Created a new project with the following dependencies and ran the following integration test (this used to error).

from bioio import BioImage
path = "s3://allencell/aics/nuc_morph_data/data_for_analysis/baseline_colonies/20200323_09_small/raw.ome.zarr"
image = BioImage(path)
print(image.get_image_dask_data())

# Dependencies
"bioio-ome-zarr @ git+https://github.com/pgarrison/bioio-ome-zarr.git@bugfix/read-zarr-from-s3",
"bioimage>=0.1.3",
"bioio>=1.0.1",

Test failures are auth problems, not related to this change I believe. I created #16 to track that.

Closing in favor of #17


Homepage showing 3 crowded Spotlight Articles from 720px to 767px width.

From 720px to 767px width, the homepage is showing 3 crowded looking articles per row under Spotlighlight Articles.
At 768px plus width, it only shows 2 articles per row, and at 719px and less width it only shows one, so I think this is unintentional.

also note in the screenshot here the "n" is being cut off in the title of the first article, "Demonstration" mid-letter.


Rewrite API tests to mock downloads, simplify test behavior

This PR simplifies the behavior in test_api to not require downloading any files from a remote server. Instead, we mock requests.get and requests.post to mimic the expected behavior, allowing us to still test functions like download_git_lfs_file without needing to actually download anything.
In the new test_load_pretrained_weights and test_load_survey, we don't actually need the data for anything, so we can just check that the mocked data was saved to the right filenames. In test_predict_sdss_default_rcf we do actually need the data to make predictions, so we just update the paths to use the $BLISS_HOME/data paths instead of the temporary directory.

@zhixiangteoh  I made a few more changes, including mocking generate and predict_sdss. Can you take another look and make sure everything still looks good?
test_api now runs in 35s on both CPU and GPU :grinning:

Lot of new changes! I restructured many of the API tests to actually test functional behavior instead of just sanity checking that the code runs. Tests now run in <2 minutes on both the CPU and GPU, with better code coverage and better test behavior! :grinning:
Major changes:
test_api.py

test_api.test_generate now mocks SimulatedDataset instead of generate. So it now actually runs all of generation, including creating and writing files appropriately, and checks that the correct files were written.
test_api.test_train mocks the trainer itself to no-op trainer.fit and trainer.test, and to load a fake checkpoint for purposes of saving the best model.
test_api.test_train_on_cached_data actually does a full training run, no mocking. I removed test_train from test_end_to_end so this is the only place we actually do training now.

Minor changes
test_end_to_end.py

Deleted test_end_to_end since train and generate are being tested elsewhere in more depth. I moved predict to its own file, test_predict.

test_cached_dataset.py

Renamed test_cached_dataset to test_generate, and removed the training test (since that's covered by test_api.test_train_on_cached_data) but changed the fixture to a test case since it's actually checking some good stuff.

test_sdss.py, test_simulate.py

Small changes in test_sdss and test_simulate to mock downloads, and use cached data in data/tests when possible

test_catalogs.py

Minor restructuring to group similar tests into classes for readability


Zoom is not working

I am trying to set the zoom on a map, but having no luck. Seems like it should be straight forward, but I've tried the following three iterations (separately, not all at once) without any success:
{% google_map src="_data/google-maps" zoom="10" %}
   url: "http://google.fr"
   zoom: 10
   location:
     latitude: 48.8587741
     longitude: 2.2074741

   url: "http://google.fr"
   location:
     latitude: 48.8587741
     longitude: 2.2074741
     zoom: 10

Hi,
yes, looks like something changed in GoogleMaps API and zoom doesn't work anymore :)
I'll take a look and try to fix it.

You're amazing, thanks for the quick response. I forked it myself to poke around , so let me know if you need any help.

It also might be useful to show in the readme the correct usage of the zoom option in yml, because it isn't clear if it should be nested under 'location' or not.

should be fixed now in 2.1.2
regarding usage: right now it's only possible to set zoom level as an attribute on google_map tag, e.g.
{% google_map  zoom="10" %}

see https://ayastreb.me/jekyll-maps/#examples
it is not possible to set zoom level from yml data-files.


Add support for idwiki (Indonesian Wikipedia) and add UI localization for id (Indonesian)

@googlebot I signed it!

demo in https://wikiloopid.herokuapp.com/


websocket: adds check for data frame

Ticket
Redmine ticket: https://redmine.openinfosecfoundation.org/issues/7051

Merged in #1901, thanks!


Project NorthStarAzure - Cohort 2 - Standardizing names

Relevant information

For Azure StorageSync, standardizing the names in the golden metrics and summary files

Checklist

[X] I've read the guidelines and understand the acceptance criteria.
[X] The value of the attribute marked as identifier will be unique and valid.
[X] I've confirmed that my entity type wasn't already defined. If it is I'm providing an explanation above.

Pulled the wrong files - will open a new request


The gap between pockets in satchel gridinv needs to be thinner

Description

As a continuation of #25147, I was intending to make the space smaller but couldn't do it on the PR since it would break. There’s definitely some way to fix it, but i couldn’t figure it out…
Screenshots

what the cane doin

what the cane doin

thats the bug


Read code descriptions with a screen reader

good morning
I'm a blind user and I use Visual Studio Code to write my own HTML and Python projects
Visual Studio Code has a great feature which is information and description about any code that has been written
The information about any code can be shown by placing the mouse pointer over it

But the blind user cannot place the mouse pointer over the code
For this, can you add a quick shortcut that reads the description of the code
So that the blind user selects the code that he wants his description
After that, he presses on a specific shortcut, and the hint containing the description of the code will be shown
Thank you

@joyceerhl

@MesterPerfect thanks for using VS Code and for opening this issue.
What you are searching for should already be possible. Just press Ctrl + K, Ctrl + I - that is a chord, so first press the first part then the second. This should open the hover and move focus to it so the screen readers reads the content.
Try it out and let us know how this works for you.
We are also looking forward to more feedback. Thanks!

not working for me
I already used shortcut ctrl+k and ctrl+i but nothing happened
thanks @isidorn

Is the cursor on the right location? Can you share the content of the html file that you are tying this on and your cursor location? So I can try to reproduce on my machine. Thanks

Is the cursor on the right location? Can you share the content of the html file that you are tying this on and your cursor location? So I can try to reproduce on my machine. Thanks

I am a blind user
I can't move cursor
So I need a way to read code description using keyboard

@MesterPerfect I understand that, but I meant the editor cursor. That one moves where your keyboard focus is. You can move it using up / down / left / right.
So can you share your HTML file and the position of your keyboard cursor when you do this so I try to repro.
Thank you!

@isidorn
ok I moved cursor to line 3 where the  tag is located
After that I press shortcut ctrl+i because shortcut ctrl+k does nothing

@MesterPerfect you need to press ctrl + k, and the ctrl+i. It is a key chord, they need to be pressed one after the other.

@isidorn
This really works
Thank you

Glad to hear. Let me close this issue then.
And you can customise that keyboard shortcut if you do not like. Just open keyboard preference and search for command "editor show hover"


fixed cstyle issues

signed off by kn-neelalohitha<EMAIL_ADDRESS>

Hi @kn-neelalohitha , rebase your branch with the latest changes. It is conflicting with the existing ones.

Sorry to say that this issue has been fixed with changes from PR#100. Hence, closing this PR.


DM-33534: Add production-tools to data-int

Thank a lot @rra, that's super helpful. It's much nicer with that boilerplate code removed. Pushed a new commit with all the changes.

Thanks @rra!


addListener/removeListeners stubs for RN 0.65+ compatibility

Summary
This PR adds addListener and removeListeners functions to StripeSdkModule to appease React Native 0.65+ builds.
Motivation
Without this change we get a warning that is mentioned in issue #1032. Motivation to make this change can be found in the commit comments here.
Testing

[x] I tested this manually
[ ] I added automated tests

Documentation
Select one:

[ ] I have added relevant documentation for my changes.
[x] This PR does not result in any developer-facing changes.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Thanks for this! But it has been addressed in the most recent version already :) https://github.com/stripe/stripe-react-native/blob/master/android/src/main/java/com/reactnativestripesdk/StripeSdkModule.kt#L849-L856


it´s not possible to send raw hex codes

If raw hex codes are sent to the tcp-serial instance from another tcp instance, for example the "generic tcp and udp requests instance", the data is misinterpreted. Why is socket.setEncoding('latin1'); used in line 237? Is this Encoding necassary on TCP Server receive side? Should it not be only on the TCP Client send side? Removing line 237 fixes the issue.

latin1 encoding is unfiltered ASCII. By default, internal strings are UTF-8 and will wrap any binary bytes over x7F which corrupts the binary data.

The module is bi-directional and sends any response from the serial device back to the TCP client. When I put the module together, sending binary would not work without latin1.

in my understanding only the data reveived from the tcp client and send to the serial device is encoded in latin1. The data send from the serial device to the tcp client is not encoded and that works fine. Are java script string not utf16 by default? Bytes above x7F should be no problem.

Any UTF encoding I tried added extra characters for bytes over x7F. Some of those upper bytes are used as extension characters in UTF-16, so they also get 'escaped' in the data stream. latin1 was the only one I found that leaves the stream untouched.

This is exactly what the latin1 encoding does on my setup. I send x81x01x04x07x24xFF to the tcp-Serial module the output of the usb to serial adapter is xC2x81x01x04x07x24xC3xBF. If the line 237 socket.setEncoding('latin1'); is removed the result is x81x01x04x07x24xFF. If i´m using an hardware tcp to serial converter the result is also correct. Can you explain me why the encoding ist necassary and only in one direction?

The encoding should be both directions and it is intended to tell javascript to leave it alone. Somewhere in the chain, bytes are being re-encoded to UTF-16. (UTF8 and UTF16 both encode bytes over x7F the same)
The generic-tcp-udp module would alter the hex codes if latin1 wasn't used. So it was also added to the tcp-serial module.
Looking over the docs for the net.socket again, that encoding step is not needed there since it will transmit the buffer unchanged. Setting the incoming encoding tells the socket to convert from latin1 to a UTF-16 string.
I will submit an update soon. Thanks for your comments.

@arichterras Can we close this?

Yes it´s fixed. Thanks!


ARM should be removed

arm64 support is currently something that we do not test at all and dont really want to spend the cycles owning.
We should remove this and let the community fork/maintain an arm compatible version if it is of interest.

I was the driver of removing this, but thinking out loud if we should keep the Sonobuoy build, but take away the E2E testing ability (since it's broken upstream).
We could fix the systemd_logs plugin to work, as well as allow other developers to still build their own plugins if desired.

attn @lubinsz

take away the E2E testing ability (since it's broken upstream).

Is that 100% accurate? I think in the past you mentioned how the tests themselves use images which may not have ARM counterparts, but I'm assuming that some of the tests work? The conformance image itself is made for arm https://github.com/kubernetes/kubernetes/tree/9c5cf3ccf77225fd38772a5a9162d6dc7f818d20/cluster/images/conformance. And with the new ability to change the registry for images it seems like you could even be pointing them to a registry which has custom built arm versions.
My biggest concern about arm w.r.t. sonobuoy is that currently we are not really testing it and dont feel like we have a lot of signal on it if it were to be malfunctioning.

I think it was mentioned today at a sig-arch meeting that arm actually is being test upstream but on testgrid there is just a stale listing: https://testgrid.k8s.io/conformance-arm#Summary
@dims I think you mentioned on the call that you know it was being used and could pass conformance, is that right? Should we be looking in another place?

There's some sort of reporting problem we need to dig into @johnSchnake

I think there will be a quorum of interested and capable parties to look at this support assembling at next week's Linaro Connect in Bangkok. I will be certain to bring this up there as well as to report back any concrete results.

From Slack (via @dims):

fyi, CI for Kind on ARM64 - http://status.openlabtesting.org/builds?job_name=kind-integration-test-arm64 (cc @bentheelder) - courtesy of @Kevin_Zheng and team

So it seems to be running and capable of getting green. Not sure why the testgrid implementation wasn't fixed, but probably just had to do with who was doing the work and what options they personally had? I thought testgrid was the one, true CI we cared about? Maybe I'm just wrong on that front.

https://testgrid.k8s.io/conformance-arm#Summary

note that this is not exactly upstream, we receive some limited results on testgrid from some CI @lubinsz runs

OK; at the end of the day it still just seems like ARM for sonobuoy should stick around. Closing.


Replace ArrayBuffer.transfer for ArrayBuffer.detach

Remove ArrayBuffer.transfer feature and replace it with a test function to only detach the ArrayBuffer.

This change is

This change should fix #2733 (as it removes the broken test, as well as the code that was causing the leak).


cayley-client 0.3.0

hspec-2.3.2 (Simon Hengel<EMAIL_ADDRESS>@sol) is out of bounds for:

[ ] cayley-client-0.3.0 (>=2.1.10 && < 2.2). Michel Boucey<EMAIL_ADDRESS>@MichelBoucey. @MichelBoucey. Used by: test-suite

Revision on Hackage is done: hspec >=2.1.10 && <2.4

Thanks for the quick response!

Thank you too.


Console UI style but with Keyboard

Hey Bro , after update to 1.17 - input with keyboard don't work with :
FirstControlDevice = 1
UseDynamicFEngSwitching = 0
1 & 0 values - permanently enables UI from Consoles for MW , CA , PS and works with keyboard at 1.16 very well ( and lower versions ) . But not in 1.17 ... Why You change it :(
I really love this feature , looks very cool ... it's just dream . And I hate PC's UI ( Enter , Back etc with separately quads )
What about create & add new PC's icons ( that aero_ does ) for Console UI style ?

honestly, fair
the PC prompts in Carbon and ProStreet look horrible compared to their console counterparts
MW looks somewhat alright as it's a similar style to the rest of the UI, but the rest (especially Carbon) are just no

Use 1.16 in the meantime.
1.17 was targeted at Pro Street controller disconnection. No new features otherwise, so you're not missing out on anything.

fixed in: https://github.com/xan1242/NFS-XtendedInput/commit/e6a1749d0bba1c0c3d2b5aec623b76aa1ba4594e


refactor: Make acting_user a mandatory kwarg.

This make acting_user a mandatory keyword argument for functions in zerver/lib/actions.py.
https://github.com/zulip/zulip/issues/14808#issuecomment-663700003.

@timabbott can you please review it?
This is the last batch of migrations, with this we can start updating others mentioned in https://github.com/zulip/zulip/issues/14808#issuecomment-663700003.

Merged, thanks @shanukun!


Update HtmlAnchor.cs

this way if the href is # it shouldn't try to resolve the url.

This repository is read-only as mentioned in the readme.


Using two package managers

I noticed we're using two package managers from here, then I confirmed looking at the source code

what about we only leave npm and remove the yarn.lock file ?

yarn.lock has been remove from functions/ on the api-bootstrap branch.

cool, I'll do the same on the client side so


Notification Modal "Locking" scroll

What happened?
Notification Modal can be closed by

clicking the navbar icon again
clicking on the "X" icon in the modal
clicking outside the modal

sometimes, closing the modal doesn't release the "y-scroll" lock
i.e
open modal
close modal
can't scroll
Please reproduce in steps
see above
Expected Behavior
able to scroll
What browsers are you seeing the problem on?
Desktop Chrome
At which address did you encounter bug?
No response
Are you logged in?
None
Which wallet you are using?
No response
At which chain did you encounter bug?
No response
Screenshots

Relevant log output
No response
Payment link for reward
https://kodadot.xyz/ksm/transfer/?target=1cAsKZYNRb8dkSCpn4eVkEn6ycNZTGoDo5dGDgB8J1UUWK8
Code of Conduct

[X] I agree to follow this project's Code of Conduct

#6669, #6667


Handler Example: use ERC-20 token to pay for gas

It is one of the interesting use cases where gas can be paid from ERC-20 account.
Handler that needs to be overwritten:

deduct_caller from PreExecution: https://bluealloy.github.io/revm/crates/revm/handler.html#preexecutionhandler
reimburse_caller and reward_beneficiary from post execution: https://bluealloy.github.io/revm/crates/revm/handler.html#postexecutionhandler
validation check for Account here: validate_tx_against_state https://bluealloy.github.io/revm/crates/revm/handler.html#validationhandler.

can i take on this ?

@royvardhan has amazing amount of progress here: https://github.com/royvardhan/revm/pull/1 it needs to be ported to new handler on main

@royvardhan has amazing amount of progress here: royvardhan#1 it needs to be ported to new handler on main

Working on the new handler example


⚠ Avatar API Endpoint has degraded performance

In 380139e, Avatar API Endpoint (https://avatar.roblox.com/v1/avatar-rules) experienced degraded performance:

HTTP code: 200
Response time: 5558 ms

Resolved: Avatar API Endpoint performance has improved in 4b61846 after 2 minutes.


Add a switch (--copy) for the user to specify they want copies instead of hard links

This may be desirable because we are now modifying the EXIF tags sometimes. This would ensure that you can keep the originals completely unchanged.


Convert XMLUtils module to java inter-ops

Purpose

$title.

Fixes #
Approach

Describe how you are implementing the solutions along with the design details.

Samples

Provide high-level details about the samples related to this feature.

Remarks

List any other known issues, related PRs, TODO items, or any other notes related to the PR.

Check List

[ ] Read the Contributing Guide
[ ] Required Balo version update
[ ] Updated Change Log
[ ] Checked Tooling Support (#)
[ ] Added necessary tests

[ ] Unit Tests
[ ] Spec Conformance Tests
[ ] Integration Tests
[ ] Ballerina By Example Tests

[ ] Increased Test Coverage
[ ] Added necessary documentation

[ ] API documentation
[ ] Module documentation in Module.md files
[ ] Ballerina By Examples

Codecov Report

Merging #19969 into ballerina-1.0.x will not change coverage.
The diff coverage is n/a.

@@               Coverage Diff                @@
##           ballerina-1.0.x   #19969   +/-   ##
================================================
  Coverage            20.51%   20.51%
================================================
  Files                   52       52
  Lines                 1394     1394
  Branches               216      216
================================================
  Hits                   286      286
  Misses                1095     1095
  Partials                13       13

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0f26458...fb4dfc7. Read the comment docs.


Division by zero in hybrid.reference.HybridizedPopulationAnnealing

Here's an observation from a user. He gets what looks like division by zero.
`from dimod import BinaryQuadraticModel
import hybrid
bqm = ...
main = hybrid.reference.HybridizedPopulationAnnealing(num_reads=200, num_iter=20, num_sweeps=1000)
Solve the problem
init_state = hybrid.State.from_sample(hybrid.utils.min_sample(bqm), bqm)
solution = main.run(init_state).result().samples.first
print(solution)
`

Sorry, I could not yet figure out how to put the BQM into the code above. (it's big and overwhelmed my screen buffers)

MCVE boils down to:
import dimod, hybrid

bqm = dimod.BQM({0: -1, 1: 0.01}, {}, 0, 'BINARY')
workflow = hybrid.PopulationAnnealing(num_reads=1, num_iter=2, num_sweeps=1)
workflow.run(hybrid.State.from_problem(bqm)).result()

It fails with:
/home/radomir/work/dwave-hybrid/hybrid/reference/pa.py:65: RuntimeWarning: overflow encountered in exp
  w = np.exp(-beta * ss.record.energy)
/home/radomir/work/dwave-hybrid/hybrid/reference/pa.py:66: RuntimeWarning: invalid value encountered in true_divide
  p = w / sum(w)
Traceback (most recent call last):
...
    idx = self.random.choice(len(ss), len(ss), p=p)
  File "mtrand.pyx", line 928, in numpy.random.mtrand.RandomState.choice
ValueError: probabilities contain NaN


test: Fix ENV.cxx11

ENV.cxx11 in a test block fails on Linux with
Error: ibex: failed
An exception occurred within a child process:
NoMethodError: undefined method `non_apple_gcc_version'

See for example brew test ibex on Linux.

[x] Have you followed the guidelines in our Contributing document?
[x] Have you checked to ensure there aren't other open Pull Requests for the same change?
[x] Have you added an explanation of what your changes do and why you'd like us to include them?
[ ] Have you written new tests for your changes? Here's an example.

[x] Have you successfully run brew tests with your changes locally?

Thanks for the review, Steven.

Nice work @sjackman!


Add support for .css/.js files not in the root of the source tree.

When the js/css files are located inside a subfolder in the source tree folder, the 2nd param sent to the convert module calls should point to the subfolder and not the source tree folder itself. Otherwise, convert can't find the source files and bails out with errors like:
Error: ENOENT, no such file or directory '.../tmp/caching-writer-dest-dir_0hegfH.tmp/app.css.map'
The PR fixes this.

 Sorry it took several months for me to notice it :(


[SC-931] Update connectors on mainnet

Codecov Report
Patch has no changes to coverable lines.
:loudspeaker: Thoughts on this report? Let us know!.


Parallelize SS solution

This PR implements a parallelized solution to the model's steady state using dask.

Note that some of the test data needed to be updated.  The parallelized solution produces the same results for the SS, but because several tests (test_inner_loop(), test_SS_fsolve(), test_SS_fsolve_reform, and test_SS_fsolve_reform_baselinespending()) only solve for one iteration of the solution algorithm (i.e., they do not solve until convergence), starting values matter.  In the serial solution method, starting values for the problem for the type j agents where taken from the solution for type j-1 agents.  This can't be done when solving for the j types in parallel.  Thus the results after one iteration are different in the parallelized method.

@jdebacker said:

In the serial solution method, starting values for the problem for the type j agents where taken from the solution for type j-1 agents. This can't be done when solving for the j types in parallel. Thus the results after one iteration are different in the parallelized method.

What if you did something like this:

solve for agent J=1 in serial
solve for agents J={2: 2 + num_workers} using the results from J=1 as the starting values
solve for agents J={2 + num_workers + 1: 2 + 2 * num_workers + 1} using the results from j = 2 + num_workers
repeat until done

Then, you could still run the solver in parallel, and maybe have better starting values.
Does that make sense?

@hdoupe Your algorithm makes sense.  Let me think about whether/how to implement.  What I've found in some other work is that using the j-1 solution as starting values is generally not as good as using the j values from the prior iteration through the steady state.  The only issue is getting the best guess at starting values for each j in the first iteration through the  SS/TPI solution algorithms.  I intend to think more about the best way to find good starting values in another PR.

Ok, I see. That makes sense. Thanks for the explanation.


Update to react-router v1.0.0?

When we can get an update version of this?

:+1:

Hi, I prepared pull request https://github.com/goatslacker/iso/pull/29

update to v2?

v1 as topic says


Feature/reservoir collect button

Description

Modified the CollectButton to use Reservoir whenever an address is available instead of linking out externally
Added logic to fetch floor prices from Reservoir to display pricing on the CollectButton
Enhance readme with required env variables for local development

Deploy Notes

[ ] Need to add environment variables

NEXT_PUBLIC_RESERVOIR_API_URL=https://onchainsummer.xyz/api/reservoir
RESERVOIR_API_KEY=X (Reservoir will sponsor an API key for onchainsummer, we'll coordinate with the BASE team to deliver the key)
ALLOWED_API_DOMAINS=https://onchainsummer.xyz

Screenshots (if appropriate)

exciting @pedromcunha ! could you rebase

exciting @pedromcunha ! could you rebase

Alright, should now be rebased.

thanks @pedromcunha! just aligning internally

We plan to merge this! @lauchness @ximxim would be great to get a review

This is pretty neat
Code LGTM - but I'm noticing the CollectDialog seems to be in an infinite loading state

@pedromcunha any ideas what's up there?

This is pretty neat
Code LGTM - but I'm noticing the CollectDialog seems to be in an infinite loading state
@pedromcunha any ideas what's up there?

Are you running this locally? Need to make sure you've set the required env variables I added above. If you have, do you mind checking the console for any errors?

This is pretty neat
Code LGTM - but I'm noticing the CollectDialog seems to be in an infinite loading state
@pedromcunha any ideas what's up there?

Are you running this locally? Need to make sure you've set the required env variables I added above. If you have, do you mind checking the console for any errors?

Alright I believe I fixed this. I think you were on the wrong chain/not connected. Added some logic/ux to handle this. Thanks for catching it! Let me know if it works for you now with the latest version.

Review Error for ximxim @ 2023-08-18 17:02:09 UTC
User failed mfa authentication, see go/mfa-help

Review Error for ximxim @ 2023-08-18 18:50:00 UTC
User failed mfa authentication, see go/mfa-help

will hold until monday I think

Review Error for lauchness @ 2023-08-22 16:21:01 UTC
User failed mfa authentication, public email is not set on your github profile. see go/mfa-help

Review Error for lauchness @ 2023-08-22 16:21:01 UTC User failed mfa authentication, public email is not set on your github profile. see go/mfa-help

Odd, can't reproduce this locally, even with all env variables removed. Do you have any info on the error produced by visiting the page?

Review Error for lauchness @ 2023-08-22 16:21:01 UTC User failed mfa authentication, public email is not set on your github profile. see go/mfa-help

Odd, can't reproduce this locally, even with all env variables removed. Do you have any info on the error produced by visiting the page?

The only error is that something happened during the server components rendering

Review Error for lauchness @ 2023-08-22 16:21:01 UTC User failed mfa authentication, public email is not set on your github profile. see go/mfa-help

Odd, can't reproduce this locally, even with all env variables removed. Do you have any info on the error produced by visiting the page?

The only error is that something happened during the server components rendering

Right, do you see anything else in the vercel logs?

Review Error for lauchness @ 2023-08-22 16:21:01 UTC User failed mfa authentication, public email is not set on your github profile. see go/mfa-help

Odd, can't reproduce this locally, even with all env variables removed. Do you have any info on the error produced by visiting the page?

The only error is that something happened during the server components rendering

Fixed the crash, but seems like maybe the env variables are configured incorrectly on the preview link (this is because we haven't deployed to production yet. The reservoir base url (NEXT_PUBLIC_RESERVOIR_API_URL) is mapping to https://onchainsummer.xyz/api/reservoir which is not available in production yet. You can avoid configuring this all together and just configure it on production, it's only important for scaling.


Feature Request: Support privileged containers

We need to run additional code with privileged permission (touching the file system mount logic) and thus would like to have this as an option in the cluster spec.

Hi @andyndang
Which fil system you want to modify? if the case it's on the pod file system, why you will need to do it? The design it's about not doing that kind of thing to keep the immutability of the pods and containers, also, for security reasons that shouldn't be allow unless the app it's designed like that, in this case, PostgreSQL it's allow to create/delete/modify files in it's own mount path, and the rest of the file system it's kept immutable.
Please, provide more feedback about why you need this, thank you!
I'm turning this into a discussion, because isn't an issue, yet, if turn out to be one, we create a ticket from there.
Regards!


v0.18.9

v0.18.9 - 2020-06-13
Fixed

mongo: RevokeAccessToken attempted to delete the access token twice from the datastore leading to fosite.ErrNotFound always being returned.
mongo: RevokeRefreshToken attempted to delete the refresh token twice from the datastore leading to fosite.ErrNotFound always being returned.

Fixes #39.
Fixes #40.

Pull Request Test Coverage Report for Build 268

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 31.034%

Totals

Change from base Build 264:
0.0%

Covered Lines:
108

Relevant Lines:
348

💛  - Coveralls


Fix unit tests

npm run test

@tschaffter I'll take this ticket; always down for more tests :-)

@vpchung It would be nice to have the existing tests working so we can extend them when we have time. At this early stage of the app we should spend most of our effort on the development of the features.

Sounds like a plan. I'll just have it on my radar for now!


Improving Navbar Design

Is your feature request related to a problem? Please describe.
Navbar is invisible and not alighned properly.
Describe the solution you'd like
It can be aligned properly.
Describe alternatives you've considered
Can use glassmorphism to make it look better along with responsiveness.
Additional context
Assign me this issue under GSSoC'23
Code of Conduct

[X] I agree to follow this project's Code of Conduct

hyyy.....please alllow me to do this task?

@ShreyaDhiman24 please assign me this task.... I want to do this