[Roadmap][Move] Standard library and Libra Framework changes

This issue tracks a set of changes that we would like to make to the Move standard library before launch.

[x] On-chain governance with capabilities
[x] Scripts, etc. for Association operations
[x] Core module and script updates for mainnet
[x] New resource/module naming convention
[x] Adopt signer/move_to in core modules and scripts

The signer/move_to feature was adopted in #3819. We're continuing to clean up uses of the old Transaction::Sender and move_to_sender in a series of subsequent PRs.

We have decided to defer implementing polymorphic event streams until a later release. I have removed that item from the list here.

The new naming convention has been adopted now. The last change was #4535

I am retitling this issue to reflect our latest thinking about the distinction between Libra-specific Move modules and standard modules that apply to any application of Move. We plan to refer to the former modules as the "Libra Framework".

Support for on-chain governance with capabilities was substantially completed with role-based permissions in #4501, with some follow-up work in #4637

We've made a number of changes to update the core modules and scripts to mainnet behavior, most recently the changes for minting (#4772, #4791). There might still be some small changes but that item is now substantially done.

We're done with scripts to support operations for the Libra Assocation. That completes the planned work for this issue.
There are still some late-breaking changes going in, e.g., https://github.com/libra/libra/pull/4972. Hopefully that is the last one, but it's possible that there may be more due to things we don't know about yet. I'm going to go ahead and consider this issue done, since we've completed all the planned work here.


feat(rust-sdk): release 0.11.10

It has been a while, releasing 0.11.10, with included breaking changes to the rust sdk api

We'll handle this using the actual release process Closing here for now


Update failed on the SimPad V2

My SimPad Control Panel version is 0.163 and when I click update it does nothing. My Firmware Version is 20200110 and as I check for updates it says it has failed to update. I also put it in Boot mode but has not been recognized on the control panel.

非常感谢您的来信该邮件已成功接收至手柄的邮箱您的建议及意见会经过阅读后成为优秀的参考选项To customers:I passed the postgraduate exam! Everything will return to normal in a few days!

非常感谢您的来信该邮件已成功接收至手柄的邮箱您的建议及意见会经过阅读后成为优秀的参考选项To customers:I passed the postgraduate exam! Everything will return to normal in a few days!


missing entrypoint? ibis.bigquery results in AttributeError

https://github.com/ibis-project/ibis-bigquery/pull/32#issuecomment-824717370

Closing as a duplicate of #34


Small fixes.

Fixed a bug regarding the error message for addTG, and made small change to ParserUtil for abstraction purposes.

Codecov Report

Merging #182 into master will decrease coverage by 5.05%.
The diff coverage is 60.00%.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3acf709...f831c8a. Read the comment docs.


Can't create connectors

Describe the bug
When I try to create a new connector it gives me an error with the message "Invalid configuration" although it was working before.
I use docker-compose with these configurations
`version: '2'
services:
kafka-ui:
image: provectuslabs/kafka-ui:master
container_name: kafka-ui
ports:
- "9090:8080"
restart: always
depends_on:
- zookeeper
- kafka
- schema-registry
- ksqldb
- kafka-connect-01
environment:
KAFKA_CLUSTERS_0_NAME: local
KAFKA_CLUSTERS_0_BOOTSTRAPSERVERS: 'PLAINTEXT://kafka:29092'
KAFKA_CLUSTERS_0_ZOOKEEPER: zookeeper:2181
KAFKA_CLUSTERS_0_JMXPORT: 9997
KAFKA_CLUSTERS_0_SCHEMAREGISTRY: http://schema-registry:8081
KAFKA_CLUSTERS_0_KAFKACONNECT_0_NAME: first
KAFKA_CLUSTERS_0_KAFKACONNECT_0_ADDRESS: http://kafka-connect-01:8083
KAFKA_CLUSTERS_0_KSQLDBSERVER: ksqldb:8088
zookeeper:
image: confluentinc/cp-zookeeper:6.2.0
container_name: zookeeper
environment:
ZOOKEEPER_CLIENT_PORT: 2181
ZOOKEEPER_TICK_TIME: 2000
kafka:
image: confluentinc/cp-kafka:6.2.0
container_name: kafka
depends_on:
- zookeeper
links:
- zookeeper
ports:
# "-._,-'"-.,-'"-._,-'"-.,-'"-._,-'"-.,-'"-._,-'"-.,-'"-._,-     # An important note about accessing Kafka from clients on other machines:      # -----------------------------------------------------------------------     #     # The config used here exposes port 9092 for _external_ connections to the broker     # i.e. those from _outside_ the docker network. This could be from the host machine     # running docker, or maybe further afield if you've got a more complicated setup.      # If the latter is true, you will need to change the value 'localhost' in      # KAFKA_ADVERTISED_LISTENERS to one that is resolvable to the docker host from those      # remote clients     #     # For connections _internal_ to the docker network, such as from other services     # and components, use kafka:29092.     #     # See https://rmoff.net/2018/08/02/kafka-listeners-explained/ for details     # "-.,-'"-._,-'"-.,-'"-._,-'"-.,-'"-._,-'"-.,-'"-._,-'"-._,-
#
- 9092:9092
environment:
KAFKA_BROKER_ID: 1
KAFKA_ZOOKEEPER_CONNECT: zookeeper:2181
KAFKA_LISTENER_SECURITY_PROTOCOL_MAP: PLAINTEXT:PLAINTEXT,PLAINTEXT_HOST:PLAINTEXT
KAFKA_INTER_BROKER_LISTENER_NAME: PLAINTEXT
KAFKA_ADVERTISED_LISTENERS: PLAINTEXT://kafka:29092,PLAINTEXT_HOST://localhost:9092
KAFKA_AUTO_CREATE_TOPICS_ENABLE: "true"
KAFKA_OFFSETS_TOPIC_REPLICATION_FACTOR: 1
KAFKA_TRANSACTION_STATE_LOG_MIN_ISR: 1
KAFKA_TRANSACTION_STATE_LOG_REPLICATION_FACTOR: 1
# -v-v-v-v-v-v-v-v-v-v-v-v-v-v-v-v-v-v-v-v-v-v-v-v-v-v-v-v-v-v-v-v-v-v-v
# Useful settings for development/laptop use - modify as needed for Prod
# This one makes ksqlDB feel a bit more responsive when queries start running
KAFKA_GROUP_INITIAL_REBALANCE_DELAY_MS: 100
command:
- bash
- -c
- |
echo '<IP_ADDRESS> kafka' >> /etc/hosts
/etc/confluent/docker/run
sleep infinity
schema-registry:
image: confluentinc/cp-schema-registry:6.2.0
container_name: schema-registry
depends_on:
- zookeeper
- kafka
links:
- zookeeper
- kafka
ports:
- 8081:8081
environment:
SCHEMA_REGISTRY_HOST_NAME: schema-registry
SCHEMA_REGISTRY_KAFKASTORE_CONNECTION_URL: zookeeper:2181
kafka-connect-01:
image: confluentinc/cp-kafka-connect:6.2.0
container_name: kafka-connect-01
depends_on:
- kafka
- schema-registry
links:
- schema-registry
- kafka
ports:
- 8083:8083
environment:
CONNECT_BOOTSTRAP_SERVERS: "kafka:29092"
CONNECT_REST_ADVERTISED_HOST_NAME: "kafka-connect-01"
CONNECT_REST_PORT: 8083
CONNECT_GROUP_ID: kafka-connect-01
CONNECT_CONFIG_STORAGE_TOPIC: _kafka-connect-01-configs
CONNECT_OFFSET_STORAGE_TOPIC: _kafka-connect-01-offsets
CONNECT_STATUS_STORAGE_TOPIC: _kafka-connect-01-status
CONNECT_KEY_CONVERTER: io.confluent.connect.avro.AvroConverter
CONNECT_KEY_CONVERTER_SCHEMA_REGISTRY_URL: 'http://schema-registry:8081'
CONNECT_VALUE_CONVERTER: io.confluent.connect.avro.AvroConverter
CONNECT_VALUE_CONVERTER_SCHEMA_REGISTRY_URL: 'http://schema-registry:8081'
CONNECT_LOG4J_ROOT_LOGLEVEL: "INFO"
CONNECT_LOG4J_LOGGERS: "org.apache.kafka.connect.runtime.rest=WARN,org.reflections=ERROR"
CONNECT_LOG4J_APPENDER_STDOUT_LAYOUT_CONVERSIONPATTERN: "[%d] %p %X{connector.context}%m (%c:%L)%n"
CONNECT_CONFIG_STORAGE_REPLICATION_FACTOR: "1"
CONNECT_OFFSET_STORAGE_REPLICATION_FACTOR: "1"
CONNECT_STATUS_STORAGE_REPLICATION_FACTOR: "1"
# If you want to use the Confluent Hub installer to d/l component, but make them available
# when running this offline, spin up the stack once and then run :
#   docker cp kafka-connect-01:/usr/share/confluent-hub-components ./connectors
#   mv ./connectors/confluent-hub-components/* ./connectors
#   rm -rf ./connectors/confluent-hub-components
#CONNECT_PLUGIN_PATH: '/usr/share/java,/usr/share/confluent-hub-components/,/connectors/'
#volumes:
#  - $PWD/connectors:/connectors
# In the command section, $ are replaced with $$ to avoid the error 'Invalid interpolation format for "command" option'
command:
- bash
- -c
- |
# Nasty hack for ECS
echo '<IP_ADDRESS> kafka-connect-01' >> /etc/hosts
#
echo "Installing connector plugins"
confluent-hub install --no-prompt debezium/debezium-connector-mysql:1.6.0
confluent-hub install --no-prompt confluentinc/kafka-connect-datagen:0.5.0
confluent-hub install --no-prompt confluentinc/kafka-connect-elasticsearch:11.1.1
#
echo "Launching Kafka Connect worker"
/etc/confluent/docker/run &
#
echo "Waiting for Kafka Connect to start listening on localhost ⏳"
while : ; do
curl_status=$$(curl -s -o /dev/null -w %{http_code} http://localhost:8083/connectors)
echo -e $$(date) " Kafka Connect listener HTTP state: " $$curl_status " (waiting for 200)"
if [ $$curl_status -eq 200 ] ; then
break
fi
sleep 5
done
    echo -e "\n--\n+> Creating Data Generator source"
    curl -s -X PUT -H  "Content-Type:application/json" http://localhost:8083/connectors/source-datagen-01/config \
        -d '{
        "connector.class": "io.confluent.kafka.connect.datagen.DatagenConnector",
        "key.converter": "org.apache.kafka.connect.storage.StringConverter",
        "kafka.topic": "ratings",
        "max.interval":750,
        "quickstart": "ratings",
        "tasks.max": 1
    }'
    sleep infinity

ksqldb:
image: confluentinc/ksqldb-server:latest
hostname: ksqldb
container_name: ksqldb
links:
- schema-registry
- kafka-connect-01
- kafka
depends_on:
- kafka
- kafka-connect-01
ports:
- "8088:8088"
environment:
KSQL_LISTENERS: http://<IP_ADDRESS>:8088
KSQL_BOOTSTRAP_SERVERS: kafka:29092
KSQL_KSQL_LOGGING_PROCESSING_STREAM_AUTO_CREATE: "true"
KSQL_KSQL_LOGGING_PROCESSING_TOPIC_AUTO_CREATE: "true"
KSQL_KSQL_CONNECT_URL: http://kafka-connect-01:8083
KSQL_KSQL_SCHEMA_REGISTRY_URL: http://schema-registry:8081
KSQL_KSQL_SERVICE_ID: confluent_rmoff_01
KSQL_KSQL_HIDDEN_TOPICS: '^_.*'
`
Steps to Reproduce
just try to add any connector
Expected behavior
A connector to be created
Screenshots

The error I receive:
{ 	"code":4002, 	"message":"Invalid configuration", 	"timestamp":1657100078494, 	"requestId":"af5b2b2a-19", 	"fieldsErrors":null, 	"stackTrace":"com.provectus.kafka.ui.exception.ValidationException: Invalid configuration 	at com.provectus.kafka.ui.client.RetryingKafkaConnectClient.lambda$withBadRequestErrorHandling$3(RetryingKafkaConnectClient.java:68) 	Suppressed: The stacktrace has been enhanced by Reactor, refer to additional information below:  	Error has been observed at the following site(s): 	*__checkpoint ⇢ Handler com.provectus.kafka.ui.controller.KafkaConnectController#createConnector(String, String, Mono, ServerWebExchange) [DispatcherHandler] 	*__checkpoint ⇢ com.provectus.kafka.ui.config.ReadOnlyModeFilter [DefaultWebFilterChain] 	*__checkpoint ⇢ com.provectus.kafka.ui.config.CustomWebFilter [DefaultWebFilterChain] 	*__checkpoint ⇢ org.springframework.security.web.server.authorization.AuthorizationWebFilter [DefaultWebFilterChain] 	*__checkpoint ⇢ org.springframework.security.web.server.authorization.ExceptionTranslationWebFilter [DefaultWebFilterChain] 	*__checkpoint ⇢ org.springframework.security.web.server.authentication.logout.LogoutWebFilter [DefaultWebFilterChain] 	*__checkpoint ⇢ org.springframework.security.web.server.savedrequest.ServerRequestCacheWebFilter [DefaultWebFilterChain] 	*__checkpoint ⇢ org.springframework.security.web.server.context.SecurityContextServerWebExchangeWebFilter [DefaultWebFilterChain] 	*__checkpoint ⇢ org.springframework.security.web.server.context.ReactorContextWebFilter [DefaultWebFilterChain] 	*__checkpoint ⇢ org.springframework.security.web.server.header.HttpHeaderWriterWebFilter [DefaultWebFilterChain] 	*__checkpoint ⇢ org.springframework.security.config.web.server.ServerHttpSecurity$ServerWebExchangeReactorContextWebFilter [DefaultWebFilterChain] 	*__checkpoint ⇢ org.springframework.security.web.server.WebFilterChainProxy [DefaultWebFilterChain] 	*__checkpoint ⇢ org.springframework.boot.actuate.metrics.web.reactive.server.MetricsWebFilter [DefaultWebFilterChain] 	*__checkpoint ⇢ HTTP POST \"/api/clusters/local/connects/first/connectors\" [ExceptionHandlingWebHandler] 	Original Stack Trace: 		at com.provectus.kafka.ui.client.RetryingKafkaConnectClient.lambda$withBadRequestErrorHandling$3(RetryingKafkaConnectClient.java:68) 		at reactor.core.publisher.Mono.lambda$onErrorResume$32(Mono.java:3809) 		at reactor.core.publisher.FluxOnErrorResume$ResumeSubscriber.onError(FluxOnErrorResume.java:94) 		at reactor.core.publisher.FluxOnErrorResume$ResumeSubscriber.onError(FluxOnErrorResume.java:106) 		at reactor.core.publisher.Operators.error(Operators.java:198) 		at reactor.core.publisher.MonoError.subscribe(MonoError.java:53) 		at reactor.core.publisher.Mono.subscribe(Mono.java:4400) 		at reactor.core.publisher.FluxOnErrorResume$ResumeSubscriber.onError(FluxOnErrorResume.java:103) 		at reactor.core.publisher.SerializedSubscriber.onError(SerializedSubscriber.java:124) 		at reactor.core.publisher.FluxRetryWhen$RetryWhenMainSubscriber.whenError(FluxRetryWhen.java:225) 		at reactor.core.publisher.FluxRetryWhen$RetryWhenOtherSubscriber.onError(FluxRetryWhen.java:274) 		at reactor.core.publisher.FluxConcatMap$ConcatMapImmediate.drain(FluxConcatMap.java:415) 		at reactor.core.publisher.FluxConcatMap$ConcatMapImmediate.onNext(FluxConcatMap.java:251) 		at reactor.core.publisher.EmitterProcessor.drain(EmitterProcessor.java:491) 		at reactor.core.publisher.EmitterProcessor.tryEmitNext(EmitterProcessor.java:299) 		at reactor.core.publisher.SinkManySerialized.tryEmitNext(SinkManySerialized.java:100) 		at reactor.core.publisher.InternalManySink.emitNext(InternalManySink.java:27) 		at reactor.core.publisher.FluxRetryWhen$RetryWhenMainSubscriber.onError(FluxRetryWhen.java:190) 		at reactor.core.publisher.MonoFlatMap$FlatMapMain.secondError(MonoFlatMap.java:192) 		at reactor.core.publisher.MonoFlatMap$FlatMapInner.onError(MonoFlatMap.java:259) 		at reactor.core.publisher.Operators$MultiSubscriptionSubscriber.onError(Operators.java:2063) 		at reactor.core.publisher.MonoFlatMap$FlatMapMain.onError(MonoFlatMap.java:172) 		at reactor.core.publisher.FluxOnErrorResume$ResumeSubscriber.onError(FluxOnErrorResume.java:106) 		at reactor.core.publisher.MonoIgnoreThen$ThenIgnoreMain.onError(MonoIgnoreThen.java:278) 		at reactor.core.publisher.MonoIgnoreThen$ThenIgnoreMain.subscribeNext(MonoIgnoreThen.java:231) 		at reactor.core.publisher.MonoIgnoreThen$ThenIgnoreMain.onComplete(MonoIgnoreThen.java:203) 		at reactor.core.publisher.Operators$MultiSubscriptionSubscriber.onComplete(Operators.java:2058) 		at reactor.core.publisher.MonoIgnoreElements$IgnoreElementsSubscriber.onComplete(MonoIgnoreElements.java:89) 		at reactor.core.publisher.FluxMapFuseable$MapFuseableSubscriber.onComplete(FluxMapFuseable.java:150) 		at reactor.core.publisher.FluxMap$MapSubscriber.onComplete(FluxMap.java:142) 		at reactor.core.publisher.FluxPeek$PeekSubscriber.onComplete(FluxPeek.java:260) 		at reactor.core.publisher.FluxMap$MapSubscriber.onComplete(FluxMap.java:142) 		at reactor.core.publisher.Operators.complete(Operators.java:137) 		at reactor.netty.channel.FluxReceive.startReceiver(FluxReceive.java:176) 		at reactor.netty.channel.FluxReceive.subscribe(FluxReceive.java:143) 		at reactor.core.publisher.InternalFluxOperator.subscribe(InternalFluxOperator.java:62) 		at reactor.netty.ByteBufFlux.subscribe(ByteBufFlux.java:340) 		at reactor.core.publisher.Mono.subscribe(Mono.java:4400) 		at reactor.core.publisher.MonoIgnoreThen$ThenIgnoreMain.subscribeNext(MonoIgnoreThen.java:263) 		at reactor.core.publisher.MonoIgnoreThen.subscribe(MonoIgnoreThen.java:51) 		at reactor.core.publisher.Mono.subscribe(Mono.java:4400) 		at reactor.core.publisher.FluxOnErrorResume$ResumeSubscriber.onError(FluxOnErrorResume.java:103) 		at reactor.core.publisher.MonoFlatMap$FlatMapMain.secondError(MonoFlatMap.java:192) 		at reactor.core.publisher.MonoFlatMap$FlatMapInner.onError(MonoFlatMap.java:259) 		at reactor.core.publisher.MonoIgnoreThen$ThenIgnoreMain.onError(MonoIgnoreThen.java:278) 		at reactor.core.publisher.MonoIgnoreThen$ThenIgnoreMain.subscribeNext(MonoIgnoreThen.java:231) 		at reactor.core.publisher.MonoIgnoreThen$ThenIgnoreMain.onComplete(MonoIgnoreThen.java:203) 		at reactor.core.publisher.Operators$MultiSubscriptionSubscriber.onComplete(Operators.java:2058) 		at reactor.core.publisher.MonoIgnoreElements$IgnoreElementsSubscriber.onComplete(MonoIgnoreElements.java:89) 		at reactor.core.publisher.FluxMapFuseable$MapFuseableSubscriber.onComplete(FluxMapFuseable.java:150) 		at reactor.core.publisher.FluxMap$MapSubscriber.onComplete(FluxMap.java:142) 		at reactor.core.publisher.FluxPeek$PeekSubscriber.onComplete(FluxPeek.java:260) 		at reactor.core.publisher.FluxMap$MapSubscriber.onComplete(FluxMap.java:142) 		at reactor.core.publisher.Operators.complete(Operators.java:137) 		at reactor.netty.channel.FluxReceive.startReceiver(FluxReceive.java:176) 		at reactor.netty.channel.FluxReceive.subscribe(FluxReceive.java:143) 		at reactor.core.publisher.InternalFluxOperator.subscribe(InternalFluxOperator.java:62) 		at reactor.netty.ByteBufFlux.subscribe(ByteBufFlux.java:340) 		at reactor.core.publisher.Mono.subscribe(Mono.java:4400) 		at reactor.core.publisher.MonoIgnoreThen$ThenIgnoreMain.subscribeNext(MonoIgnoreThen.java:263) 		at reactor.core.publisher.MonoIgnoreThen.subscribe(MonoIgnoreThen.java:51) 		at reactor.core.publisher.MonoFlatMap$FlatMapMain.onNext(MonoFlatMap.java:157) 		at reactor.core.publisher.FluxMap$MapSubscriber.onNext(FluxMap.java:120) 		at reactor.core.publisher.FluxOnErrorResume$ResumeSubscriber.onNext(FluxOnErrorResume.java:79) 		at reactor.core.publisher.FluxDefaultIfEmpty$DefaultIfEmptySubscriber.onNext(FluxDefaultIfEmpty.java:101) 		at reactor.core.publisher.FluxMapFuseable$MapFuseableSubscriber.onNext(FluxMapFuseable.java:127) 		at reactor.core.publisher.FluxContextWrite$ContextWriteSubscriber.onNext(FluxContextWrite.java:107) 		at reactor.core.publisher.FluxMapFuseable$MapFuseableConditionalSubscriber.onNext(FluxMapFuseable.java:295) 		at reactor.core.publisher.FluxFilterFuseable$FilterFuseableConditionalSubscriber.onNext(FluxFilterFuseable.java:337) 		at reactor.core.publisher.Operators$MonoSubscriber.complete(Operators.java:1816) 		at reactor.core.publisher.MonoCollect$CollectSubscriber.onComplete(MonoCollect.java:159) 		at reactor.core.publisher.FluxMap$MapSubscriber.onComplete(FluxMap.java:142) 		at reactor.core.publisher.FluxPeek$PeekSubscriber.onComplete(FluxPeek.java:260) 		at reactor.core.publisher.FluxMap$MapSubscriber.onComplete(FluxMap.java:142) 		at reactor.netty.channel.FluxReceive.onInboundComplete(FluxReceive.java:400) 		at reactor.netty.channel.ChannelOperations.onInboundComplete(ChannelOperations.java:419) 		at reactor.netty.channel.ChannelOperations.terminate(ChannelOperations.java:473) 		at reactor.netty.http.client.HttpClientOperations.onInboundNext(HttpClientOperations.java:703) 		at reactor.netty.channel.ChannelOperationsHandler.channelRead(ChannelOperationsHandler.java:93) 		at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:379) 		at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:365) 		at io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:357) 		at io.netty.handler.codec.MessageToMessageDecoder.channelRead(MessageToMessageDecoder.java:103) 		at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:379) 		at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:365) 		at io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:357) 		at io.netty.channel.CombinedChannelDuplexHandler$DelegatingChannelHandlerContext.fireChannelRead(CombinedChannelDuplexHandler.java:436) 		at io.netty.handler.codec.ByteToMessageDecoder.fireChannelRead(ByteToMessageDecoder.java:327) 		at io.netty.handler.codec.ByteToMessageDecoder.channelRead(ByteToMessageDecoder.java:299) 		at io.netty.channel.CombinedChannelDuplexHandler.channelRead(CombinedChannelDuplexHandler.java:251) 		at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:379) 		at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:365) 		at io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:357) 		at io.netty.channel.DefaultChannelPipeline$HeadContext.channelRead(DefaultChannelPipeline.java:1410) 		at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:379) 		at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:365) 		at io.netty.channel.DefaultChannelPipeline.fireChannelRead(DefaultChannelPipeline.java:919) 		at io.netty.channel.epoll.AbstractEpollStreamChannel$EpollStreamUnsafe.epollInReady(AbstractEpollStreamChannel.java:800) 		at io.netty.channel.epoll.EpollEventLoop.processReady(EpollEventLoop.java:487) 		at io.netty.channel.epoll.EpollEventLoop.run(EpollEventLoop.java:385) 		at io.netty.util.concurrent.SingleThreadEventExecutor$4.run(SingleThreadEventExecutor.java:986) 		at io.netty.util.internal.ThreadExecutorMap$2.run(ThreadExecutorMap.java:74) 		at io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30) 		at java.base/java.lang.Thread.run(Thread.java:830) 		" }

Hi, that's the response we get from kafka-connect itself. Have you tried checking kafka-connect-01 container logs?

Same problem here. it show me message "Connector with name .. already exists" but I don't have any connector yet.

Same problem here. it show me message "Connector with name .. already exists" but I don't have any connector yet.

I had the same problem when I took the latest tag, after which I upgraded to the master tag and got the same error like in this issue =((

Hi, that's the response we get from kafka-connect itself. Have you tried checking kafka-connect-01 container logs?

Indeed, the problem was with a plugin I was trying to install, somehow the container no longer has apt package controller ` command: - bash - -c - | apt install software-properties-common apt-add-repository universe apt update apt install maven -y --force-yes apt install git git --version git clone https://github.com/ElectricFiras/kafka-connect-field-and-time-partitioner.git
    cd kafka-connect-field-and-time-partitioner
    mvn package

`
I used volumes to copy it from my machine instead, and it worked

can you give location for volume?

Same problem here. it show me message "Connector with name .. already exists" but I don't have any connector yet.

Sorry, that's not related. The original issue was about invalid configuration error.

Hi, that's the response we get from kafka-connect itself. Have you tried checking kafka-connect-01 container logs?

Indeed, the problem was with a plugin I was trying to install, somehow the container no longer has apt package controller ` command: - bash - -c - | apt install software-properties-common apt-add-repository universe apt update apt install maven -y --force-yes apt install git git --version git clone https://github.com/ElectricFiras/kafka-connect-field-and-time-partitioner.git
    cd kafka-connect-field-and-time-partitioner
    mvn package

`
I used volumes to copy it from my machine instead, and it worked

can you give location for volume?

it's something in docker-compose to copy files from the server into the docker container so it depends on your configuration

If anyone still has any problems, please open up a separate issue(-s). Thanks :)

Same proble. It show me message "Connector with name .. already exists" but I don't have any connector yet.


Scale Down Quality Loss

Hi everyone,
I am having troubles with quality when down-scaling images with PIXI.
Here is a  demonstration of the issue.
Right one is original image, and left one is 0.3 scaled image. The problem is that the scaled image has lost quality by a lot.
Can anyone confirm whether it is a bug or not?

Got the answer here: http://www.html5gamedevs.com/topic/24558-down-scaling-quality-loss/?_fromLogin=1


cli: Note '--version' output as API

Consider our command line version output part of our API via a function comment.  The output from version is tested too to ensure no breaking changes occur accidentally.
The 'regex' crate is imported to support the test.  Though its heavy to bring it in for a test, 'regex' is a commonly used tool, and the crate itself is somewhat official, coming from rust's github organization repository.
Note: updated for new test

print_version() was updated to write to a stream to support testing.  Should we follow this method with other commands?
It will allow testing output via unit test's etc.

Merged.


The requested URL returned error: 404

Hi, I tying to trigger workflow but not in the main branch and it wont work. I used Argument (ref:) with name of branch but always get 404 error. Am I doing something wrong?

The only thing that comes to mind is the private key you are connecting with does not have access to that repository or that the workflow path is incorrect. "workflows/test3.yml/dispatches" doesn't seem like a proper path.

I was running into this error myself despite using the same setup in other repositories fine - turns out that it's expecting that a workflow exists before the API calls will start working. I manually triggered a workflow run, and then this action started working

@IvanKravchenko773 Did you find a solution? I am facing the same exact error too :(

@AshwinNmbr no, but I think it just cant work if yml file is not in main branch.

I managed to fix it by giving token in the args

Hi everyone, I'm having the exact same problem: I'm trying to execute a workflow in an organization repo (where I'm the owner) but I cannot make it work. I'm specifying both the token and the workflow file name (and also owner and repository path like organization_name/repo_name).
@AshwinNmbr what do you mean by "giving PAT in the args"? The github_token?

In my case I had a repo with master branch and the other with main branch, so I had to specify "ref" in order to make it work

does anyone know which specific permissions are needed by the PAT?  Is it possible to grant these permissions to the OOTB GITHUB_TOKEN?

I had the same problem, api failed 404
So i made sure that the demo worked here
And then I added my specific action jobs to the called action
It looks like the sleep commands solved it
   steps:       - name: Setting Up Integration Tests         run: |           echo "Wait for NCTL"           sleep 10s

Had the same issue was forgot to add the user to the repo

For people who are as dumb as I - if you're doing this in a repo you've created in an organisation, the owner is the organisation, not yourself 💀

I encountered this error today and after a few hours of scratching my head I realised I was setting an environment variable named API_URL in a previous job step, which was picked up by this action here. 🤦
Not that this is a bug, but using such general environment variable names with parameter expansion in public facing scripts is bound to lead to mishaps like this.

does anyone know which specific permissions are needed by the PAT? Is it possible to grant these permissions to the OOTB GITHUB_TOKEN?

Did you find an answer to either (or both!) of these questions?  The README is light (read: absent) of any details about the scopes needed on the PAT.

I'm looking into the fine-grained permissions for this action.. The APIs that I see used with the github_token input, and their permissions, are:

repos/${INPUT_OWNER}/${INPUT_REPO}/actions/workflows/${INPUT_WORKFLOW_FILE_NAME}/runs

Needs "Actions" repository permissions (read)

repos/${INPUT_OWNER}/${INPUT_REPO}/actions/workflows/${INPUT_WORKFLOW_FILE_NAME}/dispatches

Needs "Actions" repository permissions (write)

repos/${INPUT_OWNER}/${INPUT_REPO}/actions/runs/$last_workflow_id

Needs "Actions" repository permissions (read)

In summary it looks like "Actions: Read and write" should be sufficient. I'll be validating this.
As far as the OOTB GITHUB_TOKEN, I understand that it is not possible to use because anything done using the Github Actions GITHUB_TOKEN is blocked from triggering further Github Actions.

Any relationship to #96 here?


Add description on using comments instead of labels in GOVERNANCE.md

Signed-off-by: Johannes Kristan<EMAIL_ADDRESS>Description
Add a description on who to use comments instead of labels

LGTM


buttons have no margin by default

Before opening an issue

Search for duplicate or closed issues
Read the contributing guidelines

When asking general "how to" questions:

Please do not open an issue here

When reporting a bug, include:

Operating system and version (Windows, Mac OS X, Android, iOS, Win10 Mobile)
Browser and version (Chrome, Firefox, Safari, IE, MS Edge, Opera 15+, Android Browser)
Reduced test cases and potential fixes using CodePen or JS Bin

When suggesting a feature, include:

As much detail as possible for what we should add and why it's important to CoreUI Vue library
Relevant links to prior art, screenshots, or live demos whenever possible

<EMAIL_ADDRESS>.btn {
margin: $btn-margin-all;
<EMAIL_ADDRESS>// Buttons
//
// scss-docs-start buttons
// For each of Bootstrap's buttons, define text, background, and border color.
$btn-margin-all:   3px;
http://ssmaker.ru/5ea5accc/

<EMAIL_ADDRESS>.btn {
margin: $btn-margin-all;
<EMAIL_ADDRESS>// Buttons
//
// scss-docs-start buttons
// For each of Bootstrap's buttons, define text, background, and border color.
$btn-margin-all:   3px;
http://ssmaker.ru/5ea5accc/


Tests run out memory

Laravel Version: 5.8.30
PHP Version: 7.3.4
Database Driver & Version: MySQL 5.7

Description:
After upgrading from 5.8.29 to 5.8.30, one of my tests cause php to run out of memory. After downgrading back to 5.8.29, the tests run fine. I'm using phpunit for the tests.
After further research, this appears to be linked to a single test testing Artisan commands. The particular test that fails stalls out and hangs for a good while in 5.8.30, whereas it was a fast test in 5.8.29.
Steps To Reproduce:
It's linked to a single Artisan command test that is specific to my app, so I'm not sure how someone else could reproduce it. I can say that other tests involving that command still run fine and pass with flying colors, so I'm not sure how I can help you reproduce this.

We won't be able to help you without a reproducible example.
Please create a fresh Laravel installation and add code from your application until the issue appears.


It's possible to create custom apps?

I need to include Joplin as app and I want to know how to do it. Thanks.

yes.  several community members have already done so.    There's lots of examples of "SmartApps" in that folder.  And the discord channel has a dedicated "devs" channel if you need help.


Fix VS2022 warnings

Visual Studio (at least version 2022) set to high warning level wants types to match better. Static cast would do, like in this PR. Alternatively size_t could be replaced with Bvh::IndexType. I am not sure what would be the best fix, but at least this works.

I had to fix this in other builders as well, together with some other, smaller conversion warnings. See commit 1252818bb6b0c8055d99184c439f245fef5df11a. If that does not solve your issue, please re-open.


Add buttons to copy commit SHAs in revision section

Also add anywhere else on the Patch Detail page as needed.

Demo:
https://github.com/user-attachments/assets/3e554106-ce4f-47bf-ba1c-1419f3516fa1


Create e2e tests for DNS health checks

Why
If the DNS Health checks malfunction (as seen in #703), the issue might not be caught as they're only tested in integration tests
How
Write e2e test cases to verify the DNS health checks are functioning correctly

I think this is pretty high priority as e2e is a very good way to test this type of functionality. I will bump this to the top of the backlog

This issue is stale because it has been open for 60 days with no activity.

This issue is stale because it has been open for 60 days with no activity.

This issue was closed because it has been inactive for 30 days since being marked as stale.


feat: add suspend to jobset api

Fixes #9
Add suspend to JobSet.

@ahg-g or @danielvegamyhre this is ready for review when you get a chance.

Thank you for the reviews! I’m going to work on this next week. Had Kubecon but I’m interested in getting this working!

Thank you for the reviews! I’m going to work on this next week. Had Kubecon but I’m interested in getting this working!

Thanks, that sounds great!

/ok-to-test

@ahg-g and @danielvegamyhre this is ready for another review

/label tide/merge-method-squash
/lgtm
/approve


Error running java.util.TimerTask

Environment

CLI: 7.1.2
Cross-platform modules: none
Android Runtime: 6.0.0
iOS Runtime (if applicable): not applicable
Plugin(s): none

Describe the bug
I'm trying to extend the abstract class java.util.TimerTask with no success (I wonder if it's even possible), here's what I tried:
// my-timer-task.ts
@NativeClass()
class MyTimerTask extends java.util.TimerTask {
	constructor() {
		super();
	}

	public run() {
		console.log('MyTimerTask run called');
	}
}

export { MyTimerTask };

// index.andorid.ts
import { MyTimerTask } from './my-timer-task';

export class MyPlugin extends MyPluginCommon {
	public test() {
			try {
				const timer: java.util.Timer = new java.util.Timer();
				timer.schedule(new MyTimerTask(), 0, 1000);
			} catch (e) {
				console.log('Error', e);
			}
		}
	}
}

And I get this error:
java.lang.Exception: Failed resolving constructor for class 'java.util.TimerTask_0_95_23_MyTimerTask' with 0 parameters. Check the number and type of arguments.
Primitive types need to be manually wrapped in their respective Object wrappers.
If you are creating an instance of an inner class, make sure to always provide reference to the outer `this` as the first argument.

I have also tried these variants of the timer implementation:
// global.__native(this)
class MyTimerTask extends java.util.TimerTask {
	constructor() {
		super();
		global.__native(this);
	}

	public run() {
		console.log('MyTimerTask run called');
	}
}

// extend function
const MyTimerTask = (java as any).util.TimerTask.extend({
 	run() {
		console.log('MyTimerTask run called');
 	},
});
const myTimerTask = new MyTimerTask();

// implementation parameter
const myTimerTask = new java.util.TimerTask({
 	run() {
		console.log('MyTimerTask run called');
 	},
});

// NativeClass & implementation parameter with re-defining the TimerTask definition
declare module java {
	export module util {
		export abstract class TimerTask extends java.lang.Object implements java.lang.Runnable {
			public static class: java.lang.Class<java.util.TimerTask>;
			public cancel(): boolean;
			public scheduledExecutionTime(): number;
			public run(): void;
			// public constructor();
			public constructor(params: any);
		}
	}
}

@NativeClass()
class MyTimerTask extends java.util.TimerTask {
	constructor() {
		super({
			run: () => this.run()
		});
	}

	public run() {
		console.log('MyTimerTask run called');
	}
}

I have also considered creating the class in Java and using it in naivescript, but I don't know if it'll work and I prefer writing the implementation in naivescript.
To Reproduce
Generate a new plugin using the seed, try any of the above examples on android emulator.
Expected behavior
A MyTimerTask instance is created and it's run function is called in interval by the Timer.
Sample project
Will add one if necessary.
Additional context
I know there are other ways to have code execute in interval, but this is just a simplification of a wider scenario where a java library requires a TimerTask as a parameter and can't really be worked around.

Found the generated java class in the demo-app test-plugins/apps/demo-angular/platforms/android/app/src/main/java/com/tns/gen/java/util folder (i'm using the plugin seed),
here's the content:
/* AUTO-GENERATED FILE. DO NOT MODIFY.
 * This class was automatically generated by the
 * static binding generator from the resources it found.
 * Please do not modify by hand.
 */
package com.tns.gen.java.util;

public class MyTimerTask extends java.util.TimerTask
    implements com.tns.NativeScriptHashCodeProvider {
  protected MyTimerTask() {
    super();
    com.tns.Runtime.initInstance(this);
  }

  public void run() {
    java.lang.Object[] args = new java.lang.Object[0];
    com.tns.Runtime.callJSMethod(this, "run", void.class, args);
  }

  public int hashCode__super() {
    return super.hashCode();
  }

  public boolean equals__super(java.lang.Object other) {
    return super.equals(other);
  }
}

I was able to work around the problem by adding a java class to the demo folder which extends TimerTask and extending the derived class in TS, java class content:
// This file is not in the "gen" folder so we can keep it between builds
package com.tns.avif;

public class BaseTimerTask extends java.util.TimerTask {
  public BaseTimerTask() {
    super();
  }

  public void run() {
  }
}

It would seem the the auto generated constructor "protected" modifier is the culprit, and there is no way to change it from the TS side that I can find.

When extending classes in typescript you need to return global.__native(this); in the constructor
// my-timer-task.ts
@NativeClass()
class MyTimerTask extends java.util.TimerTask {
	constructor() {
		super();
		return global.__native(this);
	}

	public run() {
		console.log('MyTimerTask run called');
	}
}


About concatenation VS addition

In the paper they say: "The input to the mel spectrogram generator is m ⊙ sˆ, yˆ, the flow step t, and noisy speech st. yˆ is first converted to character embedding sequence. Then, m ⊙ sˆ, st, y˜ are all stacked to form a tensor with a shape of
(2 · D + E) × T, followed by a linear layer to output a tensor with a shape of D × T. In your code I found this line: https://github.com/lucidrains/e2-tts-pytorch/blob/9d5fc1b4fe6e0fecd0e5e43681be0c6d2d1732ec/e2_tts_pytorch/e2_tts.py#L796
Do I understand it right: they talk about concatenation and you do addition? I wasn't able to find where dimension would be (2 · D + E) × T in your code.

@juliakorovsky yes that's right, they brought this design over from voicebox
think this is one of those details that matters very little

i can add the concat way for completeness sake, let's leave the issue open.


Fix Linux issues

Now that graphics are working on Linux, fix the following Linux specific issues:

Add native file browser (DONE)
Make the mouse behave (DONE)
Fix Keypad Enter key (DONE)

The Linux version is now fully playable


minimal prefix length

Similar to https://github.com/lifepillar/vim-mucomplete/blob/03bcd4a7dfe0a2f6d432e8ce936d35273a15209d/doc/mucomplete.txt#L646 how about optionally configuring the minimal prefix length when autocompletion is to kick in? When doing :q or :wa, autocompletion is rather distracting than needed.

Great plugin, by the way, thank you very much

Created #10


Build steam as part of ansible script

This may have been solved, investigate:
http://askubuntu.com/questions/506909/how-can-i-accept-the-lience-agreement-for-steam-prior-to-apt-get-install/677867#677867

https://github.com/JBKahn/provisioning-local/pull/14


Added background to CommandKeyChord

Summary of the Pull Request
Adds a background to key chord border in the CommandPalette Screen. This prevents certain accent colors from rendering the KeyChords unreadable.
Before (where the text is unreadble);

After (from this PR):

See #15228 for more details

While this is an acceptable solution, why can't we make the border and text within black, similar to how "Close pane" turns from white to black when being hovered?

This was the approach that was suggested here https://github.com/microsoft/terminal/issues/15228#issuecomment-1524066487

Note
Walkthrough

Probably the easiest way to do this would be to just add a .Background() to this border:
https://github.com/microsoft/terminal/blob/ca5834e922e7b8438a8a3cb4bd07aca22a897e9d/src/cascadia/TerminalApp/CommandPalette.xaml#L73-L79
and use like, the CommandPalette background there, so that it appears transparent, but actually isn't.
(this was an off the cuff suggestion during triage, and we all thought it was a good idea)

I can definitely take a look at coloring the borders and text black instead, like a good idea as well 👍

It's a ✅ for me as well, but I'll wait a little bit just in case you happen to have time to check if it can be done with the color change, just because I think it would look better / more consistent. But I'd definitely also approve it without such a change.

Not sure if I can find a clean approach in changing colors based on the theme. This is good to merge 👍 as is

Thanks for the contribution! :smile:


feat(tools): lint rule: no-missing-package-exports

What I did

add a linting rule 'no-missing-package-exports'
add analyzer and lint step to the generator
update the generator CLI banner graphic
update the generator test and element templates
exit with code 1 when encountering expected errors

Testing Instructions

npm run new -- -n pf-jazz-hands --overwrite
npm start

Notes to Reviewers
closes #2415

Is it possible to test the no-missing-package-exports rule to make sure that it's working as expected or is that occurring during the generator analyze part of the process?  fwiw I was able to create the new components & overwrite them no problem w/ this branch

yes, you can test this by deleting an arbitrary element entry in the "exports" map in elements/package.json, then
npx eslint elements/package.json


Panals & icons[TVDB]

Can you please add an option to detect Panels & icons on the TVDB website?
https://www.thetvdb.com/series/spitting-image-2020
Thanks

No. They don't present these images over their API.


feat(world): clean up worldgen files before generating new ones [N-05]

this kinda mucks with world-modules not using a separated codegen dir (https://github.com/latticexyz/mud/issues/1607)
closing for now


pdf:pagecount is not working with 0.2.7

Hi,
I've updated my version of 'xhtml2pdf' from 0.2.6 to 0.2.7 with pip (so the dependencies should be up-to-date), and now the tag <pdf:pagecount> (or <pdf:pagecount />) makes all the content of the surrounding tag disappear. If <pdf:pagecount> is a direct child of <div id="footer_content">, all the footer disappears. If I add a surrounding <div> tag, only this last one disappears.
Notes:

<pdf:pagenumber> (and <pdf:pagenumber />) still works fine.
I've "updated" to 0.2.6 and it works again (versions of the other libs did not changed when I rolled back).

Have a good day!

What's the status of this issue? Was is closed by merging #628?

Fixed in version 0.2.9.
Thx !


See the react-test-renderer

We have the componet json render that need tranform a react component in json bug now i found the react-test-renderer a react oficial lib that todo this. so we need see this lib

I could look, but deep down, deep down, we're going to waste a lot of time with this for the same result and this in a non-advised way that is using a package made for testing in production


IoT Blob storage list error

After successful connection to blob storage on an IoT Edge device (Raspberry Pi), get error when trying to expand the Blob Containers.   The details are attached.   Seems like the error is associated with the accountName; however, I've verified that it is correct.
MSASE-error.txt
Using version Azure Storage Explorer version 1.19.0

@tickledblue3 yes, this typically means either your name or key is wrong. Please double verify the correctness of those values.
Additionally, we have seen issues when trying to use the latest (at the time) versions of Storage Explorer with blobs IoT. Sometimes they can be a bit behind on API versioning. Feel free to try some older versions to see if those work: https://github.com/microsoft/AzureStorageExplorer/releases
In the meantime, we will forward this issue to the blobs IoT team and see if they can chime in with any additional help.

@tickledblue3  You are right, this is a regression from a very early version. There are multiple changes that lead to it being broken. We recently discovered the root cause when investigation #4099 and we are trying to address it asap, hopefully in our next release 1.21.0.

We will close this issue and track the progress of addressing all blob edge related issues in #4099 since it is the earliest one.

FYI version 1.17.0 can connect and list blob containers and their contents on the Edge device. The error in #4099 is however indeed present in that version.


[Issue-548] Chocolatey package include binaries in package

Perfect, thank you!

It looks like this is the wrong thing to do. I just got this email:
User tunisiano<EMAIL_ADDRESS>sends the following message to the maintainers of Package 'synctrayzor'.
Hello,
can you update this package ?
The package sent contains the installers, it shouldn't.
Have a nice day.

It looks like this is the wrong thing to do. I just got this email:
User tunisiano<EMAIL_ADDRESS>sends the following message to the maintainers of Package 'synctrayzor'.
Hello,
can you update this package ?
The package sent contains the installers, it shouldn't.
Have a nice day.

Unfortunately the build for 1.1.27 includes the installers, which means I cannot publish a Chocolatey package for 1.1.27.

Unfortunately the build for 1.1.27 includes the installers, which means I cannot publish a Chocolatey package for 1.1.27.

It looks like this is the wrong thing to do. I just got this email:

He is wrong. Read the "include the software installer" section here:
https://docs.chocolatey.org/en-us/create/create-packages#including-the-software-installer-in-the-package

It looks like this is the wrong thing to do. I just got this email:

He is wrong. Read the "include the software installer" section here:
https://docs.chocolatey.org/en-us/create/create-packages#including-the-software-installer-in-the-package

OK, thanks. I'll punt 1.1.27, see what they say

OK, thanks. I'll punt 1.1.27, see what they say

Whoops, this is kind of awkward, I should have tested this more.
It seems like the .Net install that synctrayzor does is not completely silent, so it is timing out the verifier test waiting for the dotnet install that needs the finish button clicked.
You could either make the .Net install completely silent, or you could install .Net from Chocolatey as a dependency so it won't be required during the SyncTrayzor install.
For the depedency, use <dependency id="dotnetfx" version="4.7.2" /> in the .nuspec, right next to the chocolatey depedency.

Whoops, this is kind of awkward, I should have tested this more.
It seems like the .Net install that synctrayzor does is not completely silent, so it is timing out the verifier test waiting for the dotnet install that needs the finish button clicked.
You could either make the .Net install completely silent, or you could install .Net from Chocolatey as a dependency so it won't be required during the SyncTrayzor install.
For the depedency, use <dependency id="dotnetfx" version="4.7.2" /> in the .nuspec, right next to the chocolatey depedency.


invalid syntax at ConvTasNet

My environment:

Ubuntu 14.04
Python 3.7.7

When I tried ConvTasNet, I got an error at Stage3 below:
Stage 3: Training
  File "train.py", line 50
    model = ConvTasNet(**conf['filterbank'], **conf['masknet'])
                                           ^
SyntaxError: invalid syntax

Basically the code should be ok because I hadn't changed any codes of train.py.
Does anyone have any idea of solution?

I found my python path was wrong. It specified python 2.7.
After modifying the path, it worked.

Thanks for reporting the bug and finding the solution !


Form elements do not have associated labels

Is it possible that the drawer example "Navbar menu for desktop + sidebar drawer for mobile" is adapted so that it gets at Lighthouse 100 in accessibility? Right now ~10 points are deducted for "Form elements do not have associated labels" and I haven't managed to fix the problem for several hours.
I tried to fix the problem with different labels like the following:
<label htmlFor="my-drawer-3" className="opacity-0 hidden">
  Navigationbar
</label

But as soon as I make it hidden or invisible, the points are deducted again.

The examples on the site (like Navbar menu for desktop + sidebar drawer for mobile) are valid and won't cause accessibility warnings because it has a checkbox and it has labels with for attribute to point them.
I see that you're using htmlFor instead of for If it's not a react project, use for.
If it's a react project, react should convert htmlFor into standard for in the result code.
If the problem still exists, please share your code so I can see the issue.


Audio codec in json output should be acodec=unknown instead of acodec=none in case it is not known just like formats_table

DO NOT REMOVE OR SKIP THE ISSUE TEMPLATE

[X] I understand that I will be blocked if I intentionally remove or skip any mandatory* field

Checklist

[X] I'm reporting a bug unrelated to a specific site
[X] I've verified that I'm running yt-dlp version 2023.10.13 (update instructions) or later (specify commit)
[X] I've checked that all provided URLs are playable in a browser with the same IP and same login details
[X] I've checked that all URLs and arguments with special characters are properly quoted or escaped
[X] I've searched known issues and the bugtracker for similar issues including closed ones. DO NOT post duplicates
[X] I've read the guidelines for opening an issue

Provide a description that is worded well enough to be understood

yt-dlp -F -vU https://www.facebook.com/Meta/videos/pianovision/849872283528846/

ID                EXT RESOLUTION │  FILESIZE   TBR PROTO │ VCODEC          VBR ACODEC     ABR ASR MORE INFO
──────────────────────────────────────────────────────────────────────────────────────────────────────────────────────
1295232904502199a m4a audio only │ ~ 1.18MiB   65k https │ audio only          mp4a.40.5  65k 48k DASH audio, m4a_dash
sd                mp4 unknown    │                 https │ unknown             unknown
hd                mp4 unknown    │                 https │ unknown             unknown
294778846713754v  mp4 512x288    │ ~ 1.61MiB   89k https │ vp<IP_ADDRESS>   89k video only         DASH video, mp4_dash
2140417979632807v mp4 640x360    │ ~ 3.31MiB  183k https │ vp<IP_ADDRESS>  183k video only         DASH video, mp4_dash
222785340643010v  mp4 960x540    │ ~ 5.76MiB  318k https │ vp<IP_ADDRESS>  318k video only         DASH video, mp4_dash
232295126260478v  mp4 1280x720   │ ~11.41MiB  629k https │ vp<IP_ADDRESS>  629k video only         DASH video, mp4_dash
1020265372626674v mp4 1600x900   │ ~22.13MiB 1221k https │ vp<IP_ADDRESS> 1221k video only         DASH video, mp4_dash
996929814908095v  mp4 1920x1080  │ ~39.43MiB 2175k https │ vp<IP_ADDRESS> 2175k video only         DASH video, mp4_dash

As we can see here 2nd (sd) and 3rd (hd) format is a video with audio, but acodec and vcodec are not known so it is showing unknown here, but when we run same command -J option to print as json it outputs acodec=none , it should be "unknown" in case it is not known not "none". having none imply that is does not contain audio.

yt-dlp -J https://www.facebook.com/Meta/videos/pianovision/849872283528846/

{
  ........
  "formats": [
    { ... },
    {
      "format_id": "sd",
      "quality": -3,
      "url": "...",
      "http_headers": { ... },
      "ext": "mp4",
      "protocol": "https",
      "resolution": null,
      "dynamic_range": "SDR",
      "aspect_ratio": null,
      "video_ext": "mp4",
      "audio_ext": "none",
      "vbr": null,
      "abr": null,
      "tbr": null,
      "format": "sd - unknown"
    },
    {
      "format_id": "hd",
      "quality": -2,
      "url": "...",
      "http_headers": { ... },
      "ext": "mp4",
      "protocol": "https",
      "resolution": null,
      "dynamic_range": "SDR",
      "aspect_ratio": null,
      "video_ext": "mp4",
      "audio_ext": "none",
      "vbr": null,
      "abr": null,
      "tbr": null,
      "format": "hd - unknown"
    },
    ...

This problem is not only with Facebook, but with Instagram too. I have not checked other platforms but it can be with many other platform's too.
Provide verbose output that clearly demonstrates the problem

[X] Run your yt-dlp command with -vU flag added (yt-dlp -vU <your command line>)
[ ] If using API, add 'verbose': True to YoutubeDL params instead
[X] Copy the WHOLE output (starting with [debug] Command-line config) and insert it below

Complete Verbose Output
[debug] Command-line config: ['-F', '-vU', 'https://www.facebook.com/Meta/videos/pianovision/849872283528846/']
[debug] Encodings: locale cp65001, fs utf-8, pref cp65001, out utf-8, error utf-8, screen utf-8
[debug] yt-dlp version<EMAIL_ADDRESS>[b634ba742] (pip)
[debug] Python 3.10.1 (CPython AMD64 64bit) - Windows-10-10.0.23435-SP0 (OpenSSL 1.1.1l  24 Aug 2021)
[debug] exe versions: ffmpeg 2023-09-07-git-9c9f48e7f2-full_build-www.gyan.dev (setts), ffprobe 2023-09-07-git-9c9f48e7f2-full_build-www.gyan.dev
[debug] Optional libraries: Cryptodome-3.15.0, brotli-1.0.9, certifi-2022.06.15, mutagen-1.45.1, sqlite3-3.35.5, websockets-10.3
[debug] Proxy map: {}
[debug] Loaded 1890 extractors
[debug] Fetching release info: https://api.github.com/repos/yt-dlp/yt-dlp/releases/latest
Available version<EMAIL_ADDRESS>Current version<EMAIL_ADDRESS>yt-dlp is up to date<EMAIL_ADDRESS>[facebook] Extracting URL: https://www.facebook.com/Meta/videos/pianovision/849872283528846/
[facebook]<PHONE_NUMBER>28846: Downloading webpage
[debug] Formats sorted by: hasvid, ie_pref, lang, quality, res, fps, hdr:12(7), vcodec:vp9.2(10), channels, acodec, size, br, asr, proto, vext, aext, hasaud, source, id
[info] Available formats for<PHONE_NUMBER>28846:
ID                EXT RESOLUTION │  FILESIZE   TBR PROTO │ VCODEC          VBR ACODEC     ABR ASR MORE INFO
──────────────────────────────────────────────────────────────────────────────────────────────────────────────────────
1295232904502199a m4a audio only │ ~ 1.18MiB   65k https │ audio only          mp4a.40.5  65k 48k DASH audio, m4a_dash
sd                mp4 unknown    │                 https │ unknown             unknown
hd                mp4 unknown    │                 https │ unknown             unknown
294778846713754v  mp4 512x288    │ ~ 1.61MiB   89k https │ vp<IP_ADDRESS>   89k video only         DASH video, mp4_dash
2140417979632807v mp4 640x360    │ ~ 3.31MiB  183k https │ vp<IP_ADDRESS>  183k video only         DASH video, mp4_dash
222785340643010v  mp4 960x540    │ ~ 5.76MiB  318k https │ vp<IP_ADDRESS>  318k video only         DASH video, mp4_dash
232295126260478v  mp4 1280x720   │ ~11.41MiB  629k https │ vp<IP_ADDRESS>  629k video only         DASH video, mp4_dash
1020265372626674v mp4 1600x900   │ ~22.13MiB 1221k https │ vp<IP_ADDRESS> 1221k video only         DASH video, mp4_dash
996929814908095v  mp4 1920x1080  │ ~39.43MiB 2175k https │ vp<IP_ADDRESS> 2175k video only         DASH video, mp4_dash

The acodec field will be null (JSON) / None (Python) or simply not present at all if there is audio but the codec is unknown. It is 'none' (string) when there is no audio

@bashonly thank you for clarification,
I got confused audio_ext with acodec, now I can see that acodec is not present in JSON at all as you said.


no exit code?

Is there a reason that golint doesn't have a non-zero exit code when issues are discovered? That would make it easier for CI builds to halt if golint flags issues.

Don't use golint in a CI. Read the README, and see previous issues.


Minor typo: builtin -> built-in

Describe the bug
The adjective "builtin" should be written "built-in".
Steps to reproduce

Go to https://github.com/search?q=repo%3Abeeware%2Fbeeware builtin&type=code

Expected behavior
built-in
Screenshots
No response
Environment
docs
Logs
No response
Additional context
No response

Thanks for the report - I've fixed this as part of #276.


In development, raise ems refresh failures

When an ems fails refreshing, a comment goes to the log. But in development, this causes me issues and I always comment out this rescue block.
I want to see errors as they occur. Otherwise a failure sneaks by and shows itself in strange ways. Does this work for others? @dclarizio @Fryguy @blomquisg @gmcculloug
/cc @jrafanie @brandondunne @AparnaKarve (not sure if you care)

I'd prefer we use Activesupport notifications or similar so we can subscribe to things like this in dev mode.  I can imagine other things we'd like to yell at us on STDERR in dev mode.

I'm not sure about this...maybe test, but I'm not sure about development mode.
In test, I did the following to get very similar results without sneaking code into the main code line: https://github.com/ManageIQ/manageiq/pull/2010/files#diff-2495f7f6a6549d7bdd74a120fed64fb6R29
Would like to hear others opinions.

Maybe something like expect(configuration_manager.last_refresh_error).to be_nil will be good enough.
When I'm modifying code (and even introduce a syntax error), I run it and it eats the exception. I'd rather see an exception raised.

The syntax error one surprises me...are we rescuing the literal Exception class somewhere?  If so, we probably should not do that.

Nah, if there is a bug in the provider code, just as well to catch it.
When I comment out that rescue block, it displays the errors. Maybe syntax error is too strong. calling a method that doesn't exist. or calling a method on nil.

guess not. oh well


Use clearer error message for source decode error

See #504.

Old error:
SyntaxError: char decode failed (line 0)
	/tmp/test.js:0
	duk_lexer.c:314

New error:
SyntaxError: utf8 decode failed (line 0)
	/tmp/test.js:0
	duk_lexer.c:314

Old error:
SyntaxError: char decode failed (line 0)
	/tmp/test.js:0
	duk_lexer.c:314

New error:
SyntaxError: utf8 decode failed (line 0)
	/tmp/test.js:0
	duk_lexer.c:314

I like this, it would have saved me a lot of confusion back when I first encountered this error due to extended characters (Win-1252).

I like this, it would have saved me a lot of confusion back when I first encountered this error due to extended characters (Win-1252).


Integrate ENS Proxy

https://github.com/oceanprotocol/ens-proxy

This could be added to the ENS PR that is already open: https://github.com/oceanprotocol/market/pull/1410


Duplicate likely nodes added when loop axis split unevenly

1:> This PR handles duplicate likely nodes added when loop axis is split into non-divisible factors.
2:> The scenario is covered in the test case.

@tqchen , @zhiics, @MarisaKirisame

Gentle reminder : @tqchen, @zhiics, @MarisaKirisame

@zhiics : Thanks for your comment! It is handled now.

@yzhliu can you take a look? Thanks.

@MarisaKirisame : Thanks for your comment! It is handled now.

@zhiics , @MarisaKirisame : Thanks for your review!
@yzhliu : Welcome for review!

@yzhliu: Gentle reminder!

Thanks @ANSHUMAN87 @MarisaKirisame @yzhliu


Sitemap.xml bug

Sitemap.xml is generated without the domain in the URL.
Needs to be fixed, does not work well with search spiders.
Example:
http://blog.appernetic.io/sitemap.xml

One need to have the full domain in the baseurl settings.


Command 'go mod tidy' fails to include plugin due to an ambigious import

Trying to run command
env XCADDY_GO_BUILD_FLAGS="-modcacherw" \
    ${RECIPE_SYSROOT_NATIVE}${bindir}/xcaddy build ${SRCREV} \
    --with<EMAIL_ADDRESS>
fails due to an error message
| 2022/08/16 06:27:51 [INFO] exec (timeout=0s): /work/yocto/build/tmp/work/armv8a-poky-linux/caddy/2.5.2-r0/recipe-sysroot-native/usr/bin/go mod tidy -modcacherw
| go: downloading github.com/google/go-cmp v0.5.7
| go: downloading github.com/smallstep/assert v0.0.0-20200723003110-82e2b9b3b262
| go: downloading github.com/stretchr/testify v1.7.1
| go: downloading gopkg.in/yaml.v2 v2.4.0
| go: downloading go.uber.org/goleak v1.1.12
| go: downloading github.com/golang/mock v1.6.0
| go: downloading github.com/onsi/gomega v1.13.0
| go: downloading gopkg.in/check.v1 v1.0.0-20201130134442-10cb98267c6c
| go: downloading golang.org/x/sync v0.0.0-20210220032951-036812b2e83c
| go: downloading github.com/benbjohnson/clock v1.1.0
| go: downloading github.com/aws/aws-sdk-go v1.37.0
| go: downloading cloud.google.com/go/kms v1.4.0
| go: downloading github.com/googleapis/gax-go/v2 v2.1.1
| go: downloading google.golang.org/api v0.70.0
| go: downloading github.com/chzyer/test v0.0.0-20180213035817-a1ea475d72b1
| go: downloading github.com/cockroachdb/apd v1.1.0
| go: downloading github.com/gofrs/uuid v4.0.0+incompatible
| go: downloading github.com/go-stack/stack v1.8.0
| go: downloading github.com/jackc/pgmock v0.0.0-20210724152146-4ad1a8207f65
| go: downloading github.com/lib/pq v1.10.2
| go: downloading github.com/chzyer/logex v1.1.10
| go: downloading gotest.tools v2.2.0+incompatible
| go: downloading cloud.google.com/go v0.100.2
| go: downloading github.com/googleapis/gax-go v2.0.2+incompatible
| go: downloading github.com/pmezard/go-difflib v1.0.0
| go: downloading github.com/OneOfOne/xxhash v1.2.2
| go: downloading github.com/spaolacci/murmur3 v1.1.0
| go: downloading github.com/kr/pretty v0.3.0
| go: downloading github.com/davecgh/go-spew v1.1.1
| go: downloading github.com/rogpeppe/go-internal v1.8.0
| go: downloading github.com/kr/text v0.2.0
| go: downloading cloud.google.com/go/iam v0.1.0
| go: downloading github.com/jmespath/go-jmespath v0.4.0
| go: downloading golang.org/x/oauth2 v0.0.0-20211104180415-d3ed0bb246c8
| go: downloading cloud.google.com/go/compute v1.3.0
| go: downloading go.opencensus.io v0.23.0
| go: downloading google.golang.org/appengine v1.6.7
| go: downloading github.com/golang/groupcache v0.0.0-20210331224755-41bb18bfe9da
| go: downloading github.com/Masterminds/sprig v2.22.0+incompatible
| go: downloading github.com/Masterminds/semver v1.5.0
| go: downloading github.com/cpuguy83/go-md2man v1.0.10
| go: downloading github.com/jackc/pgproto3 v1.1.0
| go: downloading github.com/jackc/chunkreader v1.0.0
| caddy imports
|       github.com/greenpau/caddy-security imports
|       github.com/caddyserver/caddy/v2/modules/caddyhttp imports
|       github.com/google/cel-go/parser imports
|       github.com/antlr/antlr4/runtime/Go/antlr loaded from<EMAIL_ADDRESS>|       but go 1.16 would fail to locate it:
|       ambiguous import: found package github.com/antlr/antlr4/runtime/Go/antlr in multiple modules:
|       github.com/antlr/antlr4 v0.0.0-20200503195918-621b933c7a7f<EMAIL_ADDRESS>|       github.com/antlr/antlr4/runtime/Go/antlr v0.0.0-20220816024939-bc8df83d7b9d<EMAIL_ADDRESS>|
| To proceed despite packages unresolved in go 1.16:
|       go mod tidy -e
| If reproducibility with go 1.16 is not needed:
|       go mod tidy -compat=1.17
| For other options, see:
|       https://golang.org/doc/modules/pruning
| 2022/08/16 06:27:59 [INFO] Cleaning up temporary folder: /tmp/buildenv_2022-08-16-0627.2744968765
| 2022/08/16 06:27:59 [FATAL] exit status 1

This seems to be related to a known issue related to go compiler 1.17. My environment is using go version 1.17.8.

I tried building the same plugin with more recent version 1.1.14 and received the same error.

The xcaddy does not support passing arguments to go mod tidy, which could resolve this issue for me so I could pass the -compat=1.17 to the command. The other solution that comes to mind would be to upgrade to go 1.18 but for me that will be a bit more extra work than enforcing the compatibility.

Please use Go 1.18 or 1.19. At this point, we can't support Go 1.17 anymore.

Does this still happen if you use Go 1.18+ @akeskimo ?

I can try. It will require backporting recipes from the next release branch. I can comment on the issue whether it helps or not.

I'm certain it will work. We've seen this before. For example:
https://caddy.community/t/building-caddy-2-5-2-with-cgiv2-fails/16663/6

I backported the go version to 1.19 and I was able our frontend with the plugin enabled. Thanks a lot!

That's great, thanks @akeskimo !


[Bug] Regression in authentication code

Expected Behaviour

API tokens should be obtained per installation for reading beyond the 50 requests per hour limit, and for writing back to the repos where Derek is operational
Current Behaviour

The API token is not being created correctly and Derek has been broken and not operating since deploying 0.9.15 with #155
Possible Solution

Test the code change in #155 thoroughly (end to end) and fix any issues.
Steps to Reproduce (for bugs)

Deploy 0.9.15
Create a release and see no release notes
See the rate limit printed as N/50 not N/5000
Try to add a label and see it fail

Context

This will block all future PRs until fixed or reverted.
With 0.9.15

When reverting to previous version:

@Waterdrips please take a look?
cc @martindekov

apps --> app in the new url  (I put apps, should have been app)
PR opened that fixes this, tested in new derek installation.

Thank you for the quick turn-around on this Alistair 💪

/close
Forgot to link the close to the PR.


update discardable size before delete files in ranges

When using DeleteFilesInRanges of RocksDB, it would drop all SST within the ranges directly. So in this case, compaction can't be performed so that Titan knows nothing about the deleted files.
To fix this issue, scan the properties of the to be deleted files before DeleteFilesInRange and update related blob files' discardable size to make Titan trigger GC.

Codecov Report

Merging #43 into master will decrease coverage by 0.61%.
The diff coverage is 82.5%.

@@            Coverage Diff             @@
##           master      #43      +/-   ##
==========================================
- Coverage   84.14%   83.52%   -0.62%
==========================================
  Files          43       43
  Lines        2579     2659      +80
==========================================
+ Hits         2170     2221      +51
- Misses        409      438      +29


Let's ship the webpack 4 documentation

Merge the next branch.

We should definitely merge soon but whoever does please tag master with the latest v3 version so we can easily grab the last stable v3 docs if version switching (via a dropdown or something) is ever added.

Is there any place where next branch is deployed, so that one could take a look at it without checking out the repo and starting the page locally?

@Hypnosphi Not yet, I have been thinking about setting a Netlify account just for that

@montogeek

Not yet, I have been thinking about setting a Netlify account just for that

I highly recommend this. The workflow is amazing. This might also solve your versioned docs problem, since you can deploy branches (v1, v2, v3) with deterministic urls

Hey all! Where do we stand on this?

Can contributors help unblock any pieces.
Do we have any remaining questions unanswered? (We don't have to get it perfect, as long as we have something, and we create issues, then contributors will jump in and assist here)

Let me know how I can help.

@TheLarkInn What you think about versioning the website?

Looks like a tree shaking guide is still conflicting. Does anyone want to grab those conflicts?

@TheLarkInn Already resolved it a couple of days ago. #1923
Rebased again.

Did a branch sync also via UI.

GitHub rate limit causing errors in CI.

Finally 🎆

This review comment still applies:
https://github.com/webpack/webpack.js.org/pull/1856#discussion_r173507062

@edmorley would you be willing to create a separate issue for this and tie it to this PR so we have visibility and linkage?

Sure - filed #1947 :-)

I understand that documentation is for version 4 will be released after version 5? Keep it up!


[DOC] Explain how to include in Shiny apps or an RMarkdown file

For example, we can write something like in http://christophergandrud.github.io/networkD3/
We can also include some live rendering examples in the documentation via RMarkdown
See also https://github.com/process-analytics/bpmn-visualization-R/issues/23#issuecomment-909364915 for a working example with our package

For this one, we need to generate the documentation in the HTML format or provided examples with the R format, so this will be managed after the MVP.
The shinny apps integration will be first documented in the README of the repository.


mockup init: no such file or directory

Running completium-cli v0.3.17 on WSL. When calling mockup init for the first time or after a reset, completium-cli throws a warning and fails to create the mockup directory.
lgaroche@home:~$ rm ~/.completium -R
lgaroche@home:~$ completium-cli init
Completium initialized successfully!
lgaroche@home:~$ completium-cli mockup init
endpoint 'mockup' for network mockup set.
(node:13716) [DEP0147] DeprecationWarning: In future versions of Node.js, fs.rmdir(path, { recursive: true }) will be removed. Use fs.rm(path, { recursive: true }) instead
(Use `node --trace-deprecation ...` to show where the warning was created)
ENOENT: no such file or directory, stat '/home/lgaroche/.completium/mockup'
lgaroche@home:~$ mkdir ~/.completium/mockup
lgaroche@home:~$ completium-cli mockup init
endpoint 'mockup' for network mockup set.
(node:13762) [DEP0147] DeprecationWarning: In future versions of Node.js, fs.rmdir(path, { recursive: true }) will be removed. Use fs.rm(path, { recursive: true }) instead
(Use `node --trace-deprecation ...` to show where the warning was created)
Created mockup client base dir in /home/lgaroche/.completium/mockup
Tezos address added: tz1KqTpEZ7Yob7QbPE4Hy4Wo8fHG8LhKxZSx
Tezos address added: tz1gjaF81ZRRvdzjobyfVNsAeSC6PScjfQwN
...

thank you @lgaroche !
as a patch you can rm the directory /home/lgaroche/.completium/mockup, create it back with mkdir, and then completium-cli mockup init


added resources (closes #43)

Thank you so much!!! One minor typo: the last author of the textbook is "Davis".


[k8s-keystone-auth]Policy rule matching is flawed and The authorization process needs to be optimized

Is this a BUG REPORT or FEATURE REQUEST?:
/kind bug
What happened:

When the namespace in the authorization request is nil, getAllowed(nsDef, ns) will always pass the verification.
When the kubernetes cluster turns on anonymous authentication, the authentication will always pass, but the authorization request will not include the extra field, and keystone-auth will still perform authorization verification for such requests.

What you expected to happen:

the policy rules like exampe/daemonsets:* will pass the request which its namespace is nil like namespace  , resource: daemonsets , verb: list, so the client will get all of daemonsets in the cluster.
Every authenticated request will go through a complete authorization, which is not necessary

Can you provide the full policy definition in your test for us to reproduce? and the actual and expected result?

Can you provide the full policy definition in your test for us to reproduce? and the actual and expected result?

Policy rule like
"resource_permissions": [
          {
            "testns/![ 'podTemplates', 'pods', 'replicaSets', 'replicationControllers', 'resourceQuotas', 'secrets', 'selfSubjectAccessReviews', 'serviceAccounts', 'services', 'statefulSets']": ["*"]
          }
]

Open apiserver anonymous authentication，make sure authentication always success.
Then send request like:
curl -k -s -v -XGET  -H "Accept: application/json;as=Table;v=v1beta1;g=meta.k8s.io, application/json" -H "User-Agent: kubectl/v1.16.6 (linux/amd64) kubernetes/8f01573"  'https://<IP_ADDRESS>:6443/apis/apps/v1/daemonsets?limit=500'
Actually we only want daemonsets under testns to be accessible, but we cloud get all of daemonsets in k8s cluster.


Search for service provider using  context class loader as a fallback

We are using a custom class loader for loading our application classes, but delegate loading SLF4j to standard classloaders.
Because of this SLF4J cannot load our custom ServiceProvider.
A simple fix for such situations is to perform a fallback search for service providers using context class loader.
The solution provided here would fix the issue.
I could provide an implementation if necessary.

@daniel-jasinski If you wish the provider to be loaded by your custom class loader, why don't you have org.slf4j.LoggerFactory be loaded by your customer class loader or more generally have LoggerFactory and the provider be reachable by the same class loader?

In our setup only our classes are loaded by our classloader, third-party classes are loaded by standard class loaders. When those classes request the LoggerProvider, they cannot see our provider.

@daniel-jasinski What is the parent child relationship between the various class loaders?  What is the delegation model?
Also note that SLF4J was created in order to avoid the pitfalls  of Jakarta Commons Logging in particular its class loader problems.
In any case, my previous comments stands.

The relationship is similar to "child-first", we load "our" classes using our classloader and delegate all other classes to the parent.
The mechanism of SLF4J would work well if we were using one of the standard providers, but we are using a custom one that is loaded by our loader and all other classes (SLF4J and its other users) are loaded by the parent.
At the moment we have a bit of a workaround/hack. We analyzed which "non-our" classes use SL4FJ and we load them and all of the SLF$J classes using our loader. The code is very simple but conceptually it is ugly (to say the least) and not robust.

@ceki in our use case, we would also highly appreciate the solution with context service loader in org.slf4j.LoggerFactory#findServiceProviders
This would allow us to use the slf4j 2.x in an OSGi environment.


fix(Imports): :ambulance:

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Warning: This coverage report may be inaccurate.
This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

For more information on this, see Tracking coverage changes with pull request builds.
To avoid this issue with future PRs, see these Recommended CI Configurations.
For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

0 of 1 (0.0%)  changed or added relevant line in 1 file are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage increased (+0.2%) to 79.274%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/core/common/import-handler.core.ts
0
1
0.0%

Files with Coverage Reduction
New Missed Lines
%

src/core/common/import-handler.core.ts
1
24.49%

Totals

Change from base Build<PHONE_NUMBER>:
0.2%

Covered Lines:
1877

Relevant Lines:
2294

💛  - Coveralls


updated argocd to 2.4.0 version to fix SSL issue

Updated ArgoCD to 2.4.0 and tested with local deployment of the cluster. Seemed to work just fine, but later synced agains main branch and revert back to 2.2.5. I didn't fork the repo so I think that behavior is expected and the change is OK.

@karikolehmainen if you guys tested this, we can merge the PR I guess?


add parameter SkippedStorageAccountNames

Where the V2 is needed?

Where the V2 is needed?

it is used in scanning azure resource usage pipeline, pipeline is always stuck when scanning the storage account which has many files can not cleaned up, e.g. storage account for storing history marketplace image, storage account for storing logs.

Where the V2 is needed?

it is used in scanning azure resource usage pipeline, pipeline is always stuck when scanning the storage account which has many files which are not cleaned up, e.g.


NumPy ndarray expression with broadcast is slower when not use local variable.

Numba 0.51.2
Here is the code, f1() is 24x faster than f2().
import numpy as np
from numba import njit
x = np.random.randn(1, 1000)
y = np.random.randn(100, 1)

@njit
def f1(x, y):
    a = np.sin(x**2)
    b = np.cos(y**2)
    return a + b

@njit
def f2(x, y):
    return np.sin(x**2) + np.cos(y**2)

f1(x, y)
f2(x, y)

%timeit f1(x, y)
%timeit f2(x, y)

and here is the result:
75.4 µs ± 2.57 µs per loop (mean ± std. dev. of 7 runs, 10000 loops each)
1.81 ms ± 102 µs per loop (mean ± std. dev. of 7 runs, 1000 loops each)

@ruoyu0088 thanks for submitting this to the Numba issue tracker. I can confirm I am able to reproduce the timings on my local machine.
In [2]: %timeit f1(x,y)
101 µs ± 1.59 µs per loop (mean ± std. dev. of 7 runs, 10000 loops each)

In [3]: %timeit f2(x,y)
1.55 ms ± 31.5 µs per loop (mean ± std. dev. of 7 runs, 1000 loops each)

@ruoyu0088 so, this is a very interesting little issue you stumbled upon. We discussed this in the triage meeting yesterday and came to the following conclusions:
This is probably the result of how the array expressions are handled. In the fast example, you broadcast at the very end. Whereas in the slow example, broadcasting happens as a part of the main loop and so more work is done. So, even though the first one probably creates additional arrays (a and b) in memory it is faster overall.
Below you will find the control flow graphs for the two functions:
SVGOUTPUT1.pdf
SVGOUTPUT2.pdf
As you can see, the IR for the slow example is less, because there are less loops and such.
Lastly, I also looked at how numexpr (an alternative array expression compiler) fairs in this case:
In [1]: import numpy as np

In [2]: import numexpr as ne

In [3]: x = np.random.randn(1, 1000)

In [4]: y = np.random.randn(100, 1)

In [5]: %timeit ne.evaluate("sin(x**2)") + ne.evaluate("cos(y**2)")
85.8 µs ± 7.84 µs per loop (mean ± std. dev. of 7 runs, 10000 loops each)

In [6]: %timeit ne.evaluate("sin(x**2) + cos(y**2)")
196 µs ± 13.1 µs per loop (mean ± std. dev. of 7 runs, 10000 loops each)

As you can see the slower example is also slower here, but only by 2x, not, 24x.
Numba could probably be optimized if instead of generating ufuncs for array expressions we would generate loops. This would give LLVM more optimization opportunities and the assumption is that Numba may perform better in this case. However it appears as though, this will require a significant change to the Numba internals and how array expressions are compiled.

@esc Thanks for reply, does Numba generate loops similar as the following code, so it doesn't create any intermediate arrays?
def f2(x, y):
	out = ... # create an array with broadcasted shape
	for x_, y_, out_ in np.iter((x, y, out)):
		r = np.sin(x_**2) + np.cos(y_**2)
		out_.itemset(r)
	return out

From the document of numexpr, it splits arrays into small chunks, so it is something between f1() and f2(). It create small intermediate arrays, and generate loops to do the calculation.

@ruoyu0088 from what I understand, I think that is correct, in the sense that  Numba tries to avoid generating temporaries, but I'm really not too well versed in that part of Numba yet, so perhaps someone else could give you a  more definitive answer.  If you want to know I would suggest using inspect_cfg to look at the LLVM IR that Numba generates for the two variants of f2 that you have and see how they compare.

@ruoyu0088 in this case, the function f2 defined above is approximately what Numba did in the "slow" function in the OP.


Charset

Add it?

This would add a medium amount of machines and craftable devices to the bronze age.

I wouldn't mind adding Charset.


Disable mounting /opt/hook from host if stack.hook.enabled is set to false

This ensures that whatever pre-built Kernel image had been baked into the NGINX Docker image is served.
Description
Due to missing device drivers in the vanilla Hook Linux Kernel we had to build our own. To avoid having to host an additional HTTP(S) server that serves the resulting Kernel image and Ramdisk we had decided to directly bake those files into the NGINX Docker Image and overriden the stack.image value accordingly.
By setting stack.hook.enabled we can disable the init container that pulls files from a 3rd party HTTP(S) server. However this doesn't work, as an empty /opt/hook directory from the host is still mounted into the target Pod.
This MR changes this behavior. When stack.hook.enabled is set to false only the Kernel files already in the Hook Docker Image are served instead.
Why is this needed
No corresponding issue has been created.
How Has This Been Tested?

Create custom Hook Docker image with our own Kernel image and Ramdisk.
Install Tinkerbell via the stack Helm chart with the code change of this MR applied.
Enjoy booting into a customized Hook Linux with customized Kernel.

How are existing users impacted? What migration steps/scripts do we need?

Users wo have stack.hook.enabled set to false and expect files from the /opt/hook host directory will be impacted due to changed semantics.

Checklist:
I have:

[ ] updated the documentation and/or roadmap (if required)
[ ] added unit or e2e tests
[ ] provided instructions on how to upgrade

Hey @pckbls, thanks for this! Mind signing the commit, the DCO check has failed? ref: https://github.com/src-d/guide/blob/master/developer-community/fix-DCO.md

Thank you for your response and sorry for the delay. Signed my commit!


[LicensePage] A Scrollbar cannot be painted without a ScrollPosition

Is there an existing issue for this?

[X] I have searched the existing issues
[X] I have read the guide to filing a bug

Steps to reproduce

Use LicensePage from flutter/material.dart
Click on any license displayed on the screen
Scroll the page

Expected results
Screen should scroll without any error
Actual results
Screen scrolls with some errors in console
Code sample
Code sample
class LicensePage1 extends StatelessWidget {
  const LicensePage1();

  @override
  Widget build(BuildContext context) {
    return LicensePage(
      applicationName: 'MyApp',
      applicationIcon: Image.asset(
        'assets/images/test.png',
        height: 56,
        width: 66.2,
      ),
      applicationLegalese: 'Copyright ©My company.',
    );
  }
}

Screenshots or Video

Screenshots / Video demonstration
[Upload media here]

Logs
Logs
Restarted application in 227ms.
══╡ EXCEPTION CAUGHT BY ANIMATION LIBRARY ╞═════════════════════════════════════════════════════════
The following assertion was thrown while notifying status listeners for AnimationController:
The Scrollbar's ScrollController has no ScrollPosition attached.
A Scrollbar cannot be painted without a ScrollPosition.
The Scrollbar attempted to use the PrimaryScrollController. This ScrollController should be
associated with the ScrollView that the Scrollbar is being applied to.A ScrollView with an
Axis.vertical ScrollDirection on mobile platforms will automatically use the PrimaryScrollController
if the user has not provided a ScrollController. To use the PrimaryScrollController explicitly, set
ScrollView.primary to true for the Scrollable widget.
When the exception was thrown, this was the stack:
http://<IP_ADDRESS>:56789/dart-sdk/lib/_internal/js_dev_runtime/private/ddc_runtime/errors.dart 266:49      throw_
http://<IP_ADDRESS>:56789/packages/flutter/src/widgets/scrollbar.dart 1597:9                                <fn>
http://<IP_ADDRESS>:56789/packages/flutter/src/widgets/scrollbar.dart 1621:14                               [_debugCheckHasValidScrollPosition]
http://<IP_ADDRESS>:56789/packages/flutter/src/widgets/scrollbar.dart 1564:14                               [_validateInteractions]
http://<IP_ADDRESS>:56789/packages/flutter/src/animation/listener_helpers.dart 240:19                       notifyStatusListeners
http://<IP_ADDRESS>:56789/packages/flutter/src/animation/animation_controller.dart 822:7                    [_checkStatusChanged]
http://<IP_ADDRESS>:56789/packages/flutter/src/animation/animation_controller.dart 756:5                    [_startSimulation]
http://<IP_ADDRESS>:56789/packages/flutter/src/animation/animation_controller.dart 619:12                   [_animateToInternal]
http://<IP_ADDRESS>:56789/packages/flutter/src/animation/animation_controller.dart 467:12                   forward
http://<IP_ADDRESS>:56789/packages/flutter/src/widgets/scrollbar.dart 1973:37                               [_handleScrollNotification]
http://<IP_ADDRESS>:56789/packages/flutter/src/widgets/notification_listener.dart 130:22                    onNotification
http://<IP_ADDRESS>:56789/packages/flutter/src/widgets/framework.dart 3170:18                               dispatchNotification
http://<IP_ADDRESS>:56789/packages/flutter/src/widgets/framework.dart 3173:13                               dispatchNotification
http://<IP_ADDRESS>:56789/packages/flutter/src/widgets/framework.dart 4534:24                               dispatchNotification
http://<IP_ADDRESS>:56789/packages/flutter/src/widgets/notification_listener.dart 60:13                     dispatch
http://<IP_ADDRESS>:56789/packages/flutter/src/widgets/scroll_activity.dart 467:116                         dispatchScrollUpdateNotification
http://<IP_ADDRESS>:56789/packages/flutter/src/widgets/scroll_position.dart 912:5                           didUpdateScrollPositionBy
http://<IP_ADDRESS>:56789/packages/flutter/src/widgets/scroll_position.dart 282:9                           setPixels
http://<IP_ADDRESS>:56789/packages/flutter/src/widgets/scroll_position_with_single_context.dart 78:18       setPixels
http://<IP_ADDRESS>:56789/packages/flutter/src/widgets/scroll_position_with_single_context.dart 122:5       applyUserOffset
http://<IP_ADDRESS>:56789/packages/flutter/src/widgets/scroll_activity.dart 387:14                          update
http://<IP_ADDRESS>:56789/packages/flutter/src/widgets/scrollable.dart 719:12                               [_handleDragUpdate]
http://<IP_ADDRESS>:56789/packages/flutter/src/gestures/monodrag.dart 483:46                                <fn>
http://<IP_ADDRESS>:56789/packages/flutter/src/gestures/recognizer.dart 253:24                              invokeCallback
http://<IP_ADDRESS>:56789/packages/flutter/src/gestures/monodrag.dart 483:7                                 [_checkUpdate]
http://<IP_ADDRESS>:56789/packages/flutter/src/gestures/monodrag.dart 330:9                                 handleEvent
http://<IP_ADDRESS>:56789/packages/flutter/src/gestures/pointer_router.dart 98:12                           [_dispatch]
http://<IP_ADDRESS>:56789/packages/flutter/src/gestures/pointer_router.dart 143:9                           <fn>
http://<IP_ADDRESS>:56789/dart-sdk/lib/_internal/js_dev_runtime/private/linked_hash_map.dart 21:13          forEach
http://<IP_ADDRESS>:56789/packages/flutter/src/gestures/pointer_router.dart 141:17                          [_dispatchEventToRoutes]
http://<IP_ADDRESS>:56789/packages/flutter/src/gestures/pointer_router.dart 127:7                           route
http://<IP_ADDRESS>:56789/packages/flutter/src/gestures/binding.dart 460:19                                 handleEvent
http://<IP_ADDRESS>:56789/packages/flutter/src/gestures/binding.dart 440:14                                 dispatchEvent
http://<IP_ADDRESS>:56789/packages/flutter/src/rendering/binding.dart 336:11                                dispatchEvent
http://<IP_ADDRESS>:56789/packages/flutter/src/gestures/binding.dart 395:7                                  [_handlePointerEventImmediately]
http://<IP_ADDRESS>:56789/packages/flutter/src/gestures/binding.dart 357:5                                  handlePointerEvent
http://<IP_ADDRESS>:56789/packages/flutter/src/gestures/binding.dart 314:7                                  [_flushPointerEventQueue]
http://<IP_ADDRESS>:56789/packages/flutter/src/gestures/binding.dart 295:7                                  [_handlePointerDataPacket]
http://<IP_ADDRESS>:56789/lib/_engine/engine/platform_dispatcher.dart 1183:13                               invoke1
http://<IP_ADDRESS>:56789/lib/_engine/engine/platform_dispatcher.dart 243:5                                 invokeOnPointerDataPacket
http://<IP_ADDRESS>:56789/lib/_engine/engine/pointer_binding.dart 156:39                                    [_onPointerData]
http://<IP_ADDRESS>:56789/lib/_engine/engine/pointer_binding.dart 667:16                                    <fn>
http://<IP_ADDRESS>:56789/lib/_engine/engine/pointer_binding.dart 620:14                                    <fn>
http://<IP_ADDRESS>:56789/lib/_engine/engine/pointer_binding.dart 303:16                                    loggedHandler
http://<IP_ADDRESS>:56789/lib/_engine/engine/pointer_binding.dart 188:80                                    <fn>
http://<IP_ADDRESS>:56789/dart-sdk/lib/_internal/js_dev_runtime/private/ddc_runtime/operations.dart 367:37  _checkAndCall
http://<IP_ADDRESS>:56789/dart-sdk/lib/_internal/js_dev_runtime/private/ddc_runtime/operations.dart 372:39  dcall
The AnimationController notifying status listeners was:
  AnimationController#43127(▶ 0.000)
════════════════════════════════════════════════════════════════════════════════════════════════════
Another exception was thrown: The Scrollbar's ScrollController has no ScrollPosition attached.
Another exception was thrown: The Scrollbar's ScrollController has no ScrollPosition attached.

Flutter Doctor output
Doctor output
Flutter version 3.7.10

Hi @karthikk9828
Which platform are you testing on? I check this issue on web but can't see the exception.
Also, I see you are using old flutter version 3.7.10. Please retry on the latest stable/master channel to see if the issue still persists or not. Thanks!

flutter doctor -v (stable and master)
[✓] Flutter (Channel stable, 3.10.1, on macOS 13.0.1 22A400 darwin-x64, locale en-VN)
    • Flutter version 3.10.1 on channel stable at /Users/huynq/Documents/GitHub/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision d3d8effc68 (26 hours ago), 2023-05-16 17:59:05 -0700
    • Engine revision b4fb11214d
    • Dart version 3.0.1
    • DevTools version 2.23.1

[✓] Android toolchain - develop for Android devices (Android SDK version 32.0.0)
    • Android SDK at /Users/huynq/Library/Android/sdk
    • Platform android-33, build-tools 32.0.0
    • ANDROID_HOME = /Users/huynq/Library/Android/sdk
    • Java binary at: /Applications/Android Studio.app/Contents/jbr/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 17.0.6+0-17.0.6b802.4-9586694)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 14.3)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Build 14E222b
    • CocoaPods version 1.11.3

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2022.2)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 17.0.6+0-17.0.6b802.4-9586694)

[✓] VS Code (version 1.78.1)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.64.0

[✓] Connected device (3 available)
    • RMX2001 (mobile) • EUYTFEUSQSRGDA6D • android-arm64  • Android 11 (API 30)
    • macOS (desktop)  • macos            • darwin-x64     • macOS 13.0.1 22A400 darwin-x64
    • Chrome (web)     • chrome           • web-javascript • Google Chrome 113.0.5672.126

[✓] Network resources
    • All expected network resources are available.

• No issues found!

[!] Flutter (Channel master, 3.11.0-12.0.pre.27, on macOS 13.0.1 22A400 darwin-x64, locale en-VN)
    • Flutter version 3.11.0-12.0.pre.27 on channel master at /Users/huynq/Documents/GitHub/flutter_master
    ! Warning: `flutter` on your path resolves to /Users/huynq/Documents/GitHub/flutter/bin/flutter, which is not inside your current Flutter SDK checkout at /Users/huynq/Documents/GitHub/flutter_master. Consider adding /Users/huynq/Documents/GitHub/flutter_master/bin to the front of your path.
    ! Warning: `dart` on your path resolves to /Users/huynq/Documents/GitHub/flutter/bin/dart, which is not inside your current Flutter SDK checkout at /Users/huynq/Documents/GitHub/flutter_master. Consider adding /Users/huynq/Documents/GitHub/flutter_master/bin to the front of your path.
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 90cf8d1dd4 (80 minutes ago), 2023-05-23 21:51:25 -0400
    • Engine revision aba9dc4640
    • Dart version 3.1.0 (build 3.1.0-139.0.dev)
    • DevTools version 2.23.1
    • If those were intentional, you can disregard the above warnings; however it is recommended to use "git" directly to perform update checks and upgrades.

[✓] Android toolchain - develop for Android devices (Android SDK version 32.0.0)
    • Android SDK at /Users/huynq/Library/Android/sdk
    • Platform android-33, build-tools 32.0.0
    • ANDROID_HOME = /Users/huynq/Library/Android/sdk
    • Java binary at: /Applications/Android Studio.app/Contents/jbr/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 17.0.6+0-17.0.6b802.4-9586694)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 14.3)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Build 14E222b
    • CocoaPods version 1.11.3

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2022.2)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 17.0.6+0-17.0.6b802.4-9586694)

[✓] VS Code (version 1.78.1)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.64.0

[✓] Connected device (2 available)
    • macOS (desktop) • macos  • darwin-x64     • macOS 13.0.1 22A400 darwin-x64
    • Chrome (web)    • chrome • web-javascript • Google Chrome 113.0.5672.126

[✓] Network resources
    • All expected network resources are available.

! Doctor found issues in 1 category.

I am testing it on Web, Flutter 3.7.10

I also checked this on Flutter 3.7.12 but it works as well. Please try below complete sample code to see if it works or not on your end.

Sample code
import 'package:flutter/material.dart';

void main() {
  runApp(
    MaterialApp(
      theme: ThemeData(useMaterial3: true),
      home: const MyApp(),
    ),
  );
}

class MyApp extends StatelessWidget {
  const MyApp({super.key});

  @override
  Widget build(BuildContext context) {
    return const Scaffold(
      body: Center(
        child: LicensePage1(),
      ),
    );
  }
}

class LicensePage1 extends StatelessWidget {
  const LicensePage1({super.key});

  @override
  Widget build(BuildContext context) {
    return LicensePage(
      applicationName: 'MyApp',
      applicationIcon: Image.asset(
        'assets/vegeta.png',
        height: 56,
        width: 66.2,
      ),
      applicationLegalese: 'Copyright ©My company.',
    );
  }
}

@huycozy
The error occurs when you click on a license on this page and then scroll the license detail page. I tried the code you shared and I can still see the error. Please check this recording
https://github.com/flutter/flutter/assets/44114533/dfee5049-a605-49a8-af07-7af9541762fd

I can see it on mobile mode as your demo. But the issue doesn't appear on the latest master channel. Please try it and confirm:
flutter channel master
flutter upgrade


Fixes long path handling by GitUnite

Previously, long file paths were not handled and ended up with the (cryptic) error that the specified path was too long (even though the original path is not too long).
This is particularly useful with repositories containes node_modules for instance.
This fix is using the "hidden" property FullPath which can handle longer file paths.
This is what you find the most used workaround on the internet. One such example : http://stackoverflow.com/a/9589335

Thanks, I will check this out. Is this an issue you ran into personally?

Yes, we use npm to build our front end at work and, before npm 3, it could create some deep folder hierarchy. Those are bot committed but they are present in the folder where I aam checking the casing. This is done on an integration server to be sure we don't commit miscased file paths anymore

This pull request has been merged into the pending PR #9  and would like your feedback @GMouron on the new PR.
Thanks for your patience.


[CSM] Fix busybox support for cws-instrumentation

What does this PR do?

This PR runs cws-instrumentation health on the target container after copying the cws-instrumentation binary. The goal of running this command is to make sure that the binary was copied properly and that our admission controller can now safely override the user kubectl exec command.
Motivation

With this PR, we introduced a fix that leveraged the --totals option of tar to ensure that cws-instrumentation was properly copied to the target container. Unfortunately, --totals isn't available on all versions of tar (namely not in the busybox implementation of tar), meaning that this fix only partially fixed the issue. This new approach should support all environments since we rely on cws-instrumentation itself to tell us if it was properly copied to the target directory.
Possible Drawbacks / Trade-offs

This is a less efficient version of the previous fix, but the only way afaik to check if the binary was properly copied without relying on additional shell or tooling dependencies.
Describe how to test/QA your changes

Same as the original PR. You can also try to exec into a busybox container to ensure that they are now properly supported.

/merge

/merge


Handle static methods in the collect HOC

https://reactjs.org/docs/higher-order-components.html#static-methods-must-be-copied-over
Use https://github.com/mridgway/hoist-non-react-statics, say the React docs. react-redux uses this

And remove the brag about "I don't have any dependencies" :(


Exclude "msgpack/" resources from "parent_first"

Resources under msgpack/ have been included in "parent_first", but actually, the existing msgpack-core does not contain any resource under msgpack/, then the Embulk packages does not include any resource under msgpack/.
It's no longer needed. Let's remove it.

Thanks!


Use the new jargon for kinds of compositions in docs, code and tests

As explained in https://github.com/Starcounter/starcounter-include/issues/86
Includes a cleanup of README.md

All fixed, pls check