Add ut of compatible

As title.

API changes have been detected in com.azure.spring:spring-cloud-azure-autoconfigure. You can review API changes here


Can't close Scene light once opened

Steps to reproduce

Expand View Controls, Lighting
Click on the Scene Light
Set Scene Light position
Try and close Scene Light

Expected result
There should be an on/off switch for the scene light so that I can close it.
Actual result
There is no way of switching off the Scene Light. A GUI restart is required to get rid of it.
Environment and GUI version
W10
OpenSim-543e2ecd-2018-05-27-win64.exe

what do you mean by "close"? The scene light is always there you just get to move it with the triad and if you pick off the triad, it gets deselected. Can you clarify what is the functionality you're asking for? Thx

It isn't clear that just clicking somewhere in the visualizer will 'deselect' and close the scene light triad- especially when left- or right- click-and-hold to rotate or translate the scene doesn't cause the triad to close. You are now also introducing an issue when Users want the scene light triad visible while they are manipulating the model or scene; the triad will now close whenever a wayward click is made.
The Scene light triad should have an on/off, view toggle, open/close...whatever you want to call it.... in the View Controls.

@jimmyDunne The use case for this is to use the button to select the scene light and move it until happy with it then click elsewhere to deselect. This is exactly what you do when selecting Markers or PathPoints to move. It may make sense to change the label on the button to "select Scene Light".
There can't be an on/off button because it would give the incorrect implication that selection can stay on. If you select something else it will be deselected. There's no way more than one object can be selected in the visualizer.

Then you need to change the title in the View Controls dialog to 'Select Scene Light'.

Sure, will do. Thanks @jimmyDunne


tour: [REPLACE WITH SHORT DESCRIPTION]

Context: https://tour.golang.org/basics/2
Change the title above to describe your issue and add your feedback here, including code if necessary

Looks like you opened an empty issue by mistake, so I'm closing here.


localization example doesn't work

On https://lit.dev/docs/libraries/localization/#example as of 2021-06-15, the language picker doesn't affect the greeting message.  Only the English message is shown, not Chinese nor Spanish.

The Service Worker messages in the screenshot happened when I checked "Update on reload" in the Application tab.  Apparently, it doesn't like that setting since it seemed to go into an infinite update service worker loop.  I get the same behaviour when loading without that option.

Thanks for filing this. Turns out this is a combination of 1) Playground not doing full module specifier canonicalization (see https://github.com/PolymerLabs/playground-elements/issues/104) and 2) @lit/localize recently becoming sensitive to this problem (change was in https://github.com/lit/lit/pull/1831).
The problem is that two different code paths are importing the @lit/localize module through two different URLs:
https://unpkg.com/@lit/localize?module and https://unpkg.com/@lit/localize@0.10.2?module. Even though one redirects to the other, the browser will consider them separate modules. We'll be updating Playground soon to make sure the same URL is always used so that this doesn't happen.
Here's a simple modification to the example that works.
I'm working on the Playground issue, will keep this open until it's fixed.

FYI @aomarks that was a localhost link, should be to lit.dev.

FYI @aomarks that was a localhost link, should be to lit.dev.

Oops, thanks, fixed.

Here's a simple modification to the example that works.

Just to confirm, this change works for me, too.
Thanks!

This is now fixed!


review accessibility of linked image tile

see https://webaim.org/blog/alt-text-and-linked-images/
comment from article:

Title is intended to provide supplementary information. If title is necessary for accessibility, then it is therefor NOT supplementary.

and
see https://usability.yale.edu/web-accessibility/articles/images

Image links should describe the purpose of the link, and must never describe the image.

and
https://usability.yale.edu/web-accessibility/articles/links

Image Links
In general, content editors should avoid using images as links. If an image functions as a link, the image must have alt text that conveys the location and purpose of the link. The alt text should not describe the image. Treat image links as links, not as images.

also:

https://www.w3.org/TR/WCAG20-TECHS/G196
consider what should happen if a title is provided for both the link and the image

oof
https://www.powermapper.com/tests/screen-readers/labelling/a-img-null-alt/
if you have a link and an image inside the link but the image has a null alt tag it causes problems in 135 screen reader / browser combinations

https://www.powermapper.com/tests/screen-readers/labelling/a-img-alt/
when image is inside a link, the alt text should declare that it represents a link:

example ouput from screenreader:
"link graphic, this is a link alt"
or
"This is a link alt, graphic link"

https://www.w3.org/TR/WCAG20-TECHS/H30.html
W3 example

if the link contains text then the alt should be null:

  Current routes at Boulders Climbing Gym

some examples have the link text go before the image tag:

Woodend Music Festival Program

consider adding longdesc attribute? https://www.w3.org/TR/WCAG20-TECHS/H45.html
this is a link to a location with additional description, does not contain the description itself

Long Description: Line graph of the number of subscribers

Long description ends.

or

wait nvm longdesc is deprecated - https://developer.mozilla.org/en-US/docs/Web/API/HTMLImageElement/longDesc

maybe https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Attributes/aria-details
?

maybe remove img_alt and replace with alt_text
then add an img_desc
img_desc would be for either:

descriptions too long for typical alt text (>100 char)
description for an image when the image is being used as a link

issue^: no way to enforce that linked image's alt text indicates that it is a link
maybe just need to rely on documentation to guide this

how do img_desc and caption interact with each other
where should img_desc be displayed?

idea:
maybe a link underneath the caption
"Detailed Description"?  "Detailed Figure Description"?
then img_desc would be a link to a location with additional information
problem:  in a tile grid we would have a bunch of links with the exact same name

footnotes could be useful here because they provide a back link but i don't want to force the use of footnotes
would be handy if it also worked for footnotes though?  test this

leaning towards appending the img_desc link to caption
both inside


Add a hosting guide for external services (Heroku, opeNode, Amazon EC2, etc)

Many users  are using services that only host the game itself (e.g. Blue Fang Solutions). Some of these users are likely having difficulty finding a way to host the bot.
Assuming that it is allowed by the aforementioned services, writing a guide to help these users find hosting would make the bot more accessible.

Closing out feature requests to keep this tracker to bugs-only. This does not mean that this feature is a "won't-add". Further discussion is being moved to the Discord.


Rerolls?

Hey,
I was wondering if there was an option I didn't find, or maybe a plan to add reroll supports?
Something like:
/roll 4d6r<2
Which would roll 4d6 and reroll all 1s and 2s.
And maybe something like /roll 4d6r1r4 to reroll 1s and 4s ?
Thanks!

I'm not sure there's a good way to allow chaining (i.e. r1r4) as the parsing is currently done via regex,  but I'd be happy to weigh in further if you all want to take a swing - my guess is that it would resemble keep in demarkation of which rolls are discarded?
The roll tests should be pretty simple, although I'd image the formatting would also need to change - feel free to give it a go though!

If you add some contribution guidelines, I might be willing to give implementation a shot.

Not promising anything as I know jack about Go, but I'm looking at this now for what it's worth.
Seems to me the most common use case is for rolling stats and then rerolling any 1s (I've seen folks reroll 2s as well). I'm unsure if we need to parse a set number (1), an above/below number (<2), or both; since different folks will have different requirements. Once I get further in and know it works I'll send a pull request.


Added S Pattern in java file

Java Pattern file.

@im-shubham I'm closing the PR as it is not fulfilling the requirement...you can send a PR again after maintaining all the steps and eligibility criteria for a valid PR...


TablePagination can we manually set start and end numbers of a page?

Well as per title: can we manually set the start and end numbers of a page? Currently pagination uses rowsPerPage and Page property to calculate the numbers to be displayed.
However in some use cases the rowsPerPage might be dependent on the actual page/data displayed. (IE when each rows can be of different height, it might make sense to dynamically calculate the actual slice of the data that is displayed, and thus dynamically "set" the rows per page).
Currently when this happens, the actual index (x - y of z) becomes incorrect: consider the use case where the first 8 rows can be displayed on a page, and rows 8 & 9 can only be displayed as 2. Then if we go to the second page, the pagination widget will display "3-4 of 10".
This problem becomes even worse when there are only 10 elements: it allows you to click "past" the end.

[x] This is not a v0.x issue.
[x] I have searched the issues of this repository and believe that this is not a duplicate.

Expected Behavior 🤔

We should be able to manually overwrite the "start & end" numbers of the pagination widget.
Current Behavior 😯

Currently you can't manually give the start & end numbers, and only the rowsPerPage, which is not useful if rowsPerPage is dynamic based on the page.
Examples 🌈

Context 🔦

@pulli23 For custom use cases like this one, you can use labelDisplayedRows property to override the start & end numbers and the ActionsComponent property to change the action buttons.


Catalog Evaluation - in All shops context view (Multistore)

Is this part of Stats module intended to be used in All shops context with Multistore?
Currently it shows rows with information regarding all shops but it's impossible to decipher which number is for which shop.

Could we have header on this table (when Multistore = ON) that display the shop name and if possible could we have the number be a link to this product in this shop context (if this is at all possible?) This will speed the information addition greatly!
Also when in All shops context the number of images is the sum of all images of all shops (even if the images are the same). I one switches to certain shop context this number is correct per shop.

Indeed, I've never noticed this mess in multistore context.


zscroll: init at 1.0

I'm quite new to nix, and this is my first attempt at a package. I tested it, and it built and worked correctly.

Oops, I see that I accidentally left ${name} in there, making the url invalid. I will fix this.

Please don't forget to squash commits and properly name as is said in CONTRIBUTING.md

@jagajaga Okay, I'll do that. Thank you.


prisma-mode: init at 2021-12-07

Motivation for this change
Emacs major mode for Prisma with LSP support.
https://github.com/pimeys/emacs-prisma-mode/
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[ ] Fits CONTRIBUTING.md.

I pushed the merge button too early accidentally (on mobile).
The checks should have passed first.

oh no :(
installed this from my fork already, so works... hopefully the tests don't break!


New update makes Chrome forget last save location

Since the last update (3.0.3) if you have the extension enabled and attempt to save something in a folder that isn't the default save location specified in Chrome, then attempt to save something else, Chrome will bring up the save window in the default save location every time.

Fixed in the 3.0.4 version pushed to the Chrome Extensions page on July 1st, thanks for the quick fix!


More extensive installation instructions

Hi Carlos,
Please review it carefully, I may have made some silly mistakes. Also the instructions regarding virtual environments are not entirely consistent yet.
Things that are still missing:

If you are a new voseq user, how can you start with an empty database?
Will the cronjobs work on commands that need to be executed from the virtual environment?
How can you install future updates? just by using git pull?
What about automated backups for the postgresql database; maybe recommend setting up this with crontabs as well https://wiki.postgresql.org/wiki/Automated_Backup_on_Linux ? (On my current voseq servers I use automysqlbackup, and use crontab to synchronize the backups daily with a dropbox account)

Coverage remained the same at 96.93% when pulling 17b1552019787c6f45778c9fe77867c1da99ba64 on cdoorenweerd:master into b1340dc9c32e8d3ee78137a4133a773e0d330e8a on carlosp420:master.

thanks @cdoorenweerd. It's looking good!


Required coverage of L2_addWithCondition

Required coverage for the snippet: 83%
SnippetInputChecker: 92,31% coverage with 6 inputs
Some runs for EvoSuite: 84,62% coverage with 5 input

These are the tests generated by EvoSuite (run-01-30sec):
(String) null, (String) null
(String) null, ""
 "", (String) null
("", "ab")
\QuPH?gm,!6Uo<q?E+", "tcs<@u+>}~-o (O)Q"

These do not cover the following branch:
else if ((a + b).equals("ab") && a.equals("a")) {
    return 2;

Which is correctly detected by the evaluation in the coverage report.
Is the snippet's required coverage wrong?

Fixed 6ff0f2d


Content appears to be frozen inside Animated component

For some reason, updates to state and props don't seem to reach the contents of Animated.ScrollView. I can't reliably reproduce it, but it appears to be related to this issue: https://github.com/kmagiera/react-native-reanimated/issues/27
As the issue only occurs together with that one.
Ideas?

To add to this, I noticed that content inside Animated.View used old state. That is, the state had updated, and logs showed that this was all looking good, but the actual state rendered was the one previous. I hope that makes sense...

Having the same issue with the example, ImagePreview. I changed state but it does not re-render.
Do we have to send an event?

https://github.com/kmagiera/react-native-reanimated/pull/22
This commits makes this error. I'm trying to figure out what's the problem

For anyone who stumbles on this being on 1.0.0-alpha.3; This behaviour can also be caused (I believe; tbh I didn't dig too deep) by forceUpdate being called higher up in your component tree, which react-navigation-fluid-transitions does for instance.


split tests/unit/map2/map_delodd.cpp and tests/unit/map2/map_insdelfind.cpp

Compilation of this files with g++ 4.9 with -O3 flag takes over 3 GB of memory on my ubuntu 14.04 notebook 8GB, so if -j 2 option is specified and this files are compiled simultaneously (and it happens quite often) it causes out of memory error in best case, but ussualy it just freezes my pc. It would be very nice to split these files, if possible.

all map and set test have been splitted up in dev branch.


Allow querying for new and removed components

It should be possible to detect when components are added and removed to/from entities.
Would be useful for #431 and #425.

Duplicate of #724.


Could you please share some details about the Medical Performance?

Thank you very much for open-sourcing such an excellent project. I am very interested in the experimental results of your Medical Performance, specifically the table.
Could you please share the specific hyperparameters for Task-tuned 7b/13b? It would be very helpful for me.
Additionally, I'm also interested in how to evaluate the performance of ChatGPT. Could you share the prompts used during testing? I would also like to know how to perform out-of-domain testing with ChatGPT. Intuitively, I'm unable to fine-tune ChatGPT, which makes it difficult to differentiate between in-domain and out-of-domain.
Lastly, I believe there might be some minor issues in the table. The "Human (pass)" percentage for MedQA-USMLE (OOD) should be 60%, and for MedMCQA (ID) it should be 50%.
Thank you for your contributions to the community, and I look forward to your response.

Hi，
Please refer to these two scripts: https://github.com/OptimalScale/LMFlow/blob/main/scripts/run_finetune_with_lora.sh and https://github.com/OptimalScale/LMFlow/blob/main/scripts/run_finetune.sh.
You might want to set num_epochs to 3 and try 1e-4, 2e-5 as the learning rate.
Here are the prompts for ChatGPT.
if args.dataset == "pubmedqa":
      with open(args.dataset_path, encoding='utf-8') as f:
            json_data = json.load(f)
            for line in json_data:
                #tokens = tokenizer.tokenize(line["context"])
                tokens_not_tokenize = line["context"]
                q = "Context: " + line["context"] + "\n Question: " +  line["question"].strip() + "\nA) yes\nB) no\nC) maybe"
                questions.append(q)
                answers.append(line["final_decision"])
    elif args.dataset == "medmcqa":
      with open(args.dataset_path, encoding='utf-8') as f:
            json_data = json.load(f)
            for line in json_data:
                q = "Question: " + line["question"] + " (A) " + line["opa"] + \
                        " (B) " + line["opb"] +  " (C) " + line["opc"] +  " (D) " + line["opd"] + "."

                questions.append(q)
                answers.append(line["answer"])

As for the pass rate and expert rate, thank you so much for pointing out! We have

Hi， Please refer to these two scripts: https://github.com/OptimalScale/LMFlow/blob/main/scripts/run_finetune_with_lora.sh and https://github.com/OptimalScale/LMFlow/blob/main/scripts/run_finetune.sh. You might want to set num_epochs to 3 and try 1e-4, 2e-5 as the learning rate. Here are the prompts for ChatGPT. The ID and OOD are mainly designed for other models instead of ChatGPT.
    if args.dataset == "pubmedqa":
      with open(args.dataset_path, encoding='utf-8') as f:
            json_data = json.load(f)
            for line in json_data:
                #tokens = tokenizer.tokenize(line["context"])
                tokens_not_tokenize = line["context"]
                q = "Context: " + line["context"] + "\n Question: " +  line["question"].strip() + "\nA) yes\nB) no\nC) maybe"
                questions.append(q)
                answers.append(line["final_decision"])
    elif args.dataset == "medmcqa":
      with open(args.dataset_path, encoding='utf-8') as f:
            json_data = json.load(f)
            for line in json_data:
                q = "Question: " + line["question"] + " (A) " + line["opa"] + \
                        " (B) " + line["opb"] +  " (C) " + line["opc"] +  " (D) " + line["opd"] + "."

                questions.append(q)
                answers.append(line["answer"])

    if args.dataset == "pubmedqa":
        args.dataset_path = "./dataset/medical_dataset/PubMedQA/pqa_labeled_1000.json"
        args.direct_answer_trigger = "\nTherefore, among A through C, the answer is"
        args.dataset_size = 1000
    elif args.dataset == "medmcqa":
        args.dataset_path = "./dataset/medical_dataset/MedMCQA/medmcqa_valid_4183.json"
        args.direct_answer_trigger = "\nTherefore, the answer (A or B or C or D) is"
        args.dataset_size = 4183
    elif args.dataset == "usmle":
        args.dataset_path = "./dataset/medical_dataset/MedQA-USMLE/usmle_test_1273.json"
        args.direct_answer_trigger = "\nTherefore, the answer (A or B or C or D) is"
        args.dataset_size = 1273

As for the pass rate and expert rate, thank you so much for pointing out! We have

Thank you for your selfless sharing. I'll try to reproduce and report back when I get results. 🙏

Hi,
We do not use examples/benchmarking.py. Basically, it just queries the openai API with the question and the prompt structure is shown here.

Hi， Please refer to these two scripts: https://github.com/OptimalScale/LMFlow/blob/main/scripts/run_finetune_with_lora.sh and https://github.com/OptimalScale/LMFlow/blob/main/scripts/run_finetune.sh. You might want to set num_epochs to 3 and try 1e-4, 2e-5 as the learning rate. Here are the prompts for ChatGPT. The ID and OOD are mainly designed for other models instead of ChatGPT.
    if args.dataset == "pubmedqa":
      with open(args.dataset_path, encoding='utf-8') as f:
            json_data = json.load(f)
            for line in json_data:
                #tokens = tokenizer.tokenize(line["context"])
                tokens_not_tokenize = line["context"]
                q = "Context: " + line["context"] + "\n Question: " +  line["question"].strip() + "\nA) yes\nB) no\nC) maybe"
                questions.append(q)
                answers.append(line["final_decision"])
    elif args.dataset == "medmcqa":
      with open(args.dataset_path, encoding='utf-8') as f:
            json_data = json.load(f)
            for line in json_data:
                q = "Question: " + line["question"] + " (A) " + line["opa"] + \
                        " (B) " + line["opb"] +  " (C) " + line["opc"] +  " (D) " + line["opd"] + "."

                questions.append(q)
                answers.append(line["answer"])

    if args.dataset == "pubmedqa":
        args.dataset_path = "./dataset/medical_dataset/PubMedQA/pqa_labeled_1000.json"
        args.direct_answer_trigger = "\nTherefore, among A through C, the answer is"
        args.dataset_size = 1000
    elif args.dataset == "medmcqa":
        args.dataset_path = "./dataset/medical_dataset/MedMCQA/medmcqa_valid_4183.json"
        args.direct_answer_trigger = "\nTherefore, the answer (A or B or C or D) is"
        args.dataset_size = 4183
    elif args.dataset == "usmle":
        args.dataset_path = "./dataset/medical_dataset/MedQA-USMLE/usmle_test_1273.json"
        args.direct_answer_trigger = "\nTherefore, the answer (A or B or C or D) is"
        args.dataset_size = 1273

As for the pass rate and expert rate, thank you so much for pointing out! We have

This issue has been marked as stale because it has not had recent activity. If you think this still needs to be addressed please feel free to reopen this issue. Thanks

Hey can anybody share the script for Medical Performannce benchmark for gpt3.5 and 4 ? I was facing some issues regarding regex and extraction of answer.


Meeting: Sept 11th, 2024

Time: 17:00 (Irish Summer Time)
Zoom Link: https://zoom.us/j/91426197903?pwd=cjNGcjgzWmRqZ1YyRW9PM3FFNFVFUT09
Agenda:

PRs:

#249

Issue review

see comments below for issue list

Enhancement review

AOB:

Prep for dev branch merge into main

Attendees:

Nick Denny
Bruno Pedro
Kevin Swiber
Frank Kilcommins

Activities:

Reviewed #249 from and merged into dev branch.
Discussed process for patch releasing (while not maintaining an MD version per patch version)
Kevin will create create some issues to start collecting tooling support and we'll prep a PR into the tools repo


Quick fix to the count(*) problem

This PR is a quick fix to #212 that we retain at least one column from an Aggregate's child plan to survive the PruneColumns physical optimization.

Thanks @jianqiao for the quick fix and the TODO note.


Added ime to CHAOSS

Thanks for the PR @ofonime1
Good work on the sign-off. :slightly_smiling_face:
Can you give the doc link with comment access so that the mentors can comment maybe?

HI Venu,
Just seeing this message, Doc link updated and thank you for letting me
know.
Regards,
Brown ime
On Wed, 8 Jul 2020, 6:09 pm Venu Vardhan Reddy Tekula, <
<EMAIL_ADDRESS>wrote:

Thanks for the PR @ofonime1 https://github.com/ofonime1
Good work on the sign-off. 🙂
Can you give the doc link with comment access so that the mentors can
comment maybe?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/chaoss/governance/pull/223#issuecomment-655644983,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AOQ3GM36H6D7VV2ZRAJXSX3R2SR6LANCNFSM4OUVZ6JA
.


Fix background color

Pull Request Description

Fix #10393

Use correct background color

Also use more opaque color for right panel to match Figma more closely

Note that the right panel is white on Figma - in the original PR implementing the new design it was decided to not use white because it was too bright compared to everything else.

Important Notes
None
Screenshots
Before:

After:

Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:

[x] The documentation has been updated, if necessary.
[x] Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
[x] All code follows the
Scala,
Java,
TypeScript,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.
[x] Unit tests have been written where possible.

I am not an designer but wouldn't it be better to make Asset Panel the same colour as bg and just make a vertical line between dashboard and the panel to mark those are different zones. Right now it has a 3rd colour which doesn't occur anywhere else in dashboard. @MrFlashAccount wdyt?

With new Asset Panel color the Versions and Sessions buttons are invisible... the same when you want to update description.
When you open panel it slides from the left nicely from the right.. When you close the content disappear and you see the blank panel slowly fading. How hard would it be to implement sliding to the right with content in it (so it looks like true side panel)?

@PabloBuchu This panel needs a stronger shadow to match the current design, making it the same color isn't necessary

Searchbar/User "cloud" should have #fff bg

Searchbar/User "cloud" should have #fff bg

not sure about this. i think it would be more consistent to switch to an outline to match with the assets table search bar. @MrFlashAccount thoughts?


expose streaming flags in java with jni

Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Codecov Report

Merging #849 (425b9d6) into develop (571a3ec) will decrease coverage by 50.43%.
The diff coverage is 0.00%.

:exclamation: Current head 425b9d6 differs from pull request most recent head 7968958. Consider uploading reports for the commit 7968958 to get more accurate results

@@             Coverage Diff              @@
##           develop     #849       +/-   ##
============================================
- Coverage    69.47%   19.04%   -50.44%
============================================
  Files           32       51       +19
  Lines         1661     6254     +4593
============================================
+ Hits          1154     1191       +37
- Misses         507     5063     +4556

Impacted Files
Coverage Δ

samples/kvs_gstreamer_audio_video_sample.cpp
0.00% <0.00%> (ø)

samples/kvs_gstreamer_multistream_sample.cpp
0.00% <0.00%> (ø)

samples/kvs_gstreamer_sample.cpp
0.00% <0.00%> (ø)

...mazonaws/kinesis/video/producer/jni/Parameters.cpp
0.00% <0.00%> (ø)

src/gstreamer/gstkvssink.cpp
0.00% <ø> (ø)

src/DefaultDeviceInfoProvider.cpp
56.81% <0.00%> (-5.35%)
:arrow_down:

tst/main.cpp
90.47% <0.00%> (-4.77%)
:arrow_down:

src/DefaultCallbackProvider.cpp
57.36% <0.00%> (-0.51%)
:arrow_down:

src/StreamDefinition.h
100.00% <0.00%> (ø)

src/StreamDefinition.cpp
93.82% <0.00%> (ø)

... and 26 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9d54bfb...7968958. Read the comment docs.


Feature Request - Hidden values

I was wondering if there's any way to read some of the values in the game that aren't visible. For example, how many weeds a player has pulled out so far, or how many fish or bugs they have caught. This would make it a lot simpler for completionists (who don't feel like cheating a badge in) to gauge how close they are to their goal!

You could use NLSE to check the values

NLSE was last updated 3 years ago and is not equipped to be able to use the new garden_plus.dat files.

That's odd. I used it a few weeks ago with no issues. Maybe you have the pre-installed update version of ACNL.

Indeed, the editor has access to these values. I can add some code to show them easily.

That'd be amazing! Thank you!

Oh, yeah! Silly me. Really appreciated, man!


trivy: 0.26.0 -> 0.27.0

Description of changes

Bump trivy to 0.27.0
Things done

Built on platform(s)

[X] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[X] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[X] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[X] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[X] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[X] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 170410 run on x86_64-linux 1

1 package built:

trivy

@ofborg eval


API routes are incorrect

As a user, I want API requests to go the right place so that when I want to view posts, they actually show up.
Expected Behavior
When getting posts, the endpoint to call should be /api/posts/{id}.
Current Behavior
When getting posts using the API, the route is incorrect and it tries to request from /api/api/posts/{id}.
Possible Solution
Update the route so that it points to the correct endpoint.
Steps to Reproduce

Create a post in the frontend
Try and open it
Observe that it does not work

I can reproduce. I approve.

Same here. Approved

I approve.


Fixed the description of the attaching data disks upper limit.

Fixed the description of the attaching data disks upper limit of the VMware hypervisor.

Would you mind updating the new administration docs?
The relevant section should be in https://github.com/apache/cloudstack-docs-admin/blob/master/source/storage.rst

Thank you.
I did so.


[aes/doc] Mention possibility of implementing GCM with Ibex and bitmanip

The documentation of AES currently only mentions the block cipher modes fully implemented in hardware (ECB, CBC, CTR, OFB, CFB). GCM isn't mentioned but it can be implemented by doing GHASH on Ibex using bitmanip. We should reflect that in the documentation. Also it might be worth pointing to our GCM implementation part for the crypto library.

estimate 1

Triaging meeting: Since this is a documentation task, it is ok to move post M2.5.


fix: Updates to Java SDK

:tada: This PR is included in version 0.0.10 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


#2 Effect type is now generic.

Still relying on cats.effect.IO for internal use.

Still need to update the documentation (README file)


config: add option to enable placement rules

Signed-off-by: disksing<EMAIL_ADDRESS>What problem does this PR solve?
Add an option to turn on/off placement rules feature.
What is changed and how it works?
Add configuration and make sure it is always disabled before the full feature get merged.

Codecov Report

Merging #1835 into master will increase coverage by 0.04%.
The diff coverage is 38.46%.

@@            Coverage Diff             @@
##           master    #1835      +/-   ##
==========================================
+ Coverage   77.93%   77.98%   +0.04%
==========================================
  Files         168      168
  Lines       17004    17014      +10
==========================================
+ Hits        13252    13268      +16
+ Misses       2658     2656       -2
+ Partials     1094     1090       -4

Impacted Files
Coverage Δ

server/config/option.go
90.61% <0%> (-1.33%)
:arrow_down:

server/cluster.go
84.7% <0%> (-0.22%)
:arrow_down:

server/config/config.go
82.95% <100%> (+0.04%)
:arrow_up:

pkg/mock/mockoption/mockoption.go
90.47% <33.33%> (-2.12%)
:arrow_down:

pkg/btree/btree.go
86.14% <0%> (-0.81%)
:arrow_down:

client/client.go
69.03% <0%> (+0.43%)
:arrow_up:

server/handler.go
53.65% <0%> (+0.48%)
:arrow_up:

server/grpc_service.go
57.7% <0%> (+0.65%)
:arrow_up:

server/schedule/operator/operator.go
85% <0%> (+0.88%)
:arrow_up:

server/region_syncer/client.go
85.52% <0%> (+7.89%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 92a4c01...94e39fb. Read the comment docs.


Bot crashes when opening multiple instances

hi, im currently developing a telegram bot with this library, and when i start it from multiple terminals it says the following:
2022/03/13 13:26:12 telegram unknown: Conflict: terminated by other getUpdates request; make sure that only one bot instance is running (409)
2022/03/13 13:26:15 telegram unknown: Conflict: terminated by other getUpdates request; make sure that only one bot instance is running (409)
some os info:
im running arch linux (64 bit), and my go version is "go version go1.17.7 linux/amd64"
i think this issue happens because of an auto-update feature, is there a way to temporarily disable it?
edit: i tried to launch the program without a poller and it says, panic: telebot: can't start without a poller

Simple, the bot is already running somewhere else. It does not depend on the telebot library, but from telegram apis.


Taints and Tolerations

The listed sample.yaml don't work anymore, because the Windows nodes use taints now, so this is needed:
  tolerations:
  - key: "sku"
    operator: "Equal"
    value: "windows"
    effect: "NoSchedule"

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 6de70aec-9ebe-5655-6657-5c171de374b1
Version Independent ID: c9eb35c8-8703-511b-987b-e2a441be2e47
Content: Run Windows Server container in Azure Kubernetes Service cluster - Azure Kubernetes Service
Content Source: articles/aks/windows-container-cli.md
Service: container-service
GitHub Login: @mlearned
Microsoft Alias: mlearned

@NitroAMD Thanks for the feedback. We are investigating the issue and will update you shortly.

@NitroAMD
Thanks for the feedback! I have assigned the issue to the content author to investigate further and update the document as appropriate.

We don't taint the nodes per default, but recommend customers to apply some sort of filtering of nodes, beyond just nodeselectors.

Thanks for your feedback! The sample on this page still works as expected, so I'm closing this issue. Please feel free to comment or open another issue if you have any other concerns.
#please-close


Remove Discord.Discord 1.0.9162

See https://github.com/microsoft/winget-pkgs/issues/172175
Checklist for Pull Requests

[x] Have you signed the Contributor License Agreement?
[x] Is there a linked Issue?

Manifests

[x] Have you checked that there aren't other open pull requests for the same manifest update/change?
[x] This PR only modifies one (1) manifest
[x] Have you validated your manifest locally with winget validate --manifest <path>?

[x] Does your manifest conform to the 1.6 schema?

Note: <path> is the directory's name containing the manifest you're submitting.

Microsoft Reviewers: Open in CodeFlow

@stephengillie I don't think a package that doesn't want to adhere to winget's (and also Windows') logic shouldn't be included in the list. There's not reason in trying to be listed in a package manager that you actually don't support.

Close with reason: Application should stay in repo;

@ stephengillie I think a package that doesn't want to adhere to winget's (and also Windows') logic shouldn't be included in the list. There's not reason in trying to be listed in a package manager that you actually don't support. Whoever wants to use Discord (or any other Squirrel-app for that matter) can use their supported methods of installing and updating.

That's a valid opinion. These should probably be voiced in Issues, to help the community come to a consensus before acting. Were this approved, it might have generated more PRs to readd, creating more work for moderators in the end.


Automotive Skill updates for Speech Support, Images and VA Dispatch integration

Description

Speak property now set for a higher quality speech experience
New images for setting validation cards
Cut-down LU model for use by dispatch
Updated skill deployment with steps required to add VA prior to deployment
Skill Mode required a different approach for resolving image resources than the existing "local-mode" which can use HttpContext meaning images "just work" in local-mode. Developer will need to ensure image assets are on CDN/HTTP location and provide location via skillconfiguratuion entry.
Updated Skill constructor signature to move ServiceManager (not used by Skill invocation) to end and move skillMode from end to align better.

Testing Steps

Run Unit Tests to validate internal skill changes
Follow Deploying the Virtual Assistant with the Automotive Skill in docs to configure VA skill ahead of VA deployment

Checklist

[x] I have commented my code, particularly in hard-to-understand areas
[x ] I have added or updated the appropriate unit tests
[x] I have updated related documentation

If this contains changes that needs to be replicated between the Enterprise Template <-> Virtual Assistant

[ ] A duplicate issue is filed to track future  work.

If you have updated responses or .lu files:

[ ] All languages have been updated   (No localisation in this skill at this time)
[ ] You have tested deployment with your new models

OK – feel free to add to the repo with your PR. Thanks!
From: Marion Zepf<EMAIL_ADDRESS>Sent: 31 January 2019 19:07
To: Microsoft/AI<EMAIL_ADDRESS>Cc: Darren Jefford<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: Re: [Microsoft/AI] Automotive Skill updates for Speech Support, Images and VA Dispatch integration (#637)
@outofthecave commented on this pull request.

In solutions/Virtual-Assistant/src/csharp/skills/automotiveskill/automotiveskill/Dialogs/VehicleSettings/Resources/available_settings.jsonhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMicrosoft%2FAI%2Fpull%2F637%23discussion_r252799700&data=02|01|darrenj%40microsoft.com|729730af532948bf8e6208d687af4d0e|72f988bf86f141af91ab2d7cd011db47|1|0|636845584313921367&sdata=LkPDi%2BNPgch1iF3MSnYDt8OMSsgD2ocIbix0u58OGxU%3D&reserved=0:

@@ -1,7 +1,7 @@

[
{
 "canonicalName": "Front Left Air Delivery Mode Control",

"categories": [ "Climate Control" ],

"category": "Climate Control",

Well, I wrote a 19-line Python script to convert it: https://vsogd.visualstudio.com/_git/GM IPA PoC?path=%2FSrc%2FIPABot%2FDialogs%2FVehicle%2Fyaml_to_json.py&version=GBvehicle-settings-originalhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fvsogd.visualstudio.com%2F_git%2FGM%2520IPA%2520PoC%3Fpath%3D%252FSrc%252FIPABot%252FDialogs%252FVehicle%252Fyaml_to_json.py%26version%3DGBvehicle-settings-original&data=02|01|darrenj%40microsoft.com|729730af532948bf8e6208d687af4d0e|72f988bf86f141af91ab2d7cd011db47|1|0|636845584313921367&sdata=RSxLbx%2FhYncxC%2B4ru5rvkmdNWa7sNjuj37tFKG7dU2Q%3D&reserved=0, but any converter will do. I tried to preserve the order of the properties in each JSON object, to make it easier to read for people who are used to our YAML files (i.e. mostly myself).
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMicrosoft%2FAI%2Fpull%2F637%23discussion_r252799700&data=02|01|darrenj%40microsoft.com|729730af532948bf8e6208d687af4d0e|72f988bf86f141af91ab2d7cd011db47|1|0|636845584313931375&sdata=C6EyPWm%2ByeH%2BY4d%2BKPvcgOfTCRxuNlUZL3P9R37C6m0%3D&reserved=0, or mute the threadhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAf93oP5Rr8KLkgnEmCTe5awF5AB_WpLeks5vIz7dgaJpZM4aWJ_X&data=02|01|darrenj%40microsoft.com|729730af532948bf8e6208d687af4d0e|72f988bf86f141af91ab2d7cd011db47|1|0|636845584313941384&sdata=eU5Zqt3%2BrXxW%2Fwl2q0qtj7glWWT77zFjTZ1ursZeoeM%3D&reserved=0.


How to add legend box

Legends are created automatically by gramm. Otherwise you need to get the axes handles after the draw() call, they are stored as a property of the gramm object.


semantic_nerfw_configurability

Fixes an issue currently with the semantic nerf vis, where currently all dataparsers pass in colours as a list of tuples, whereas the typing was enforced to be a tensor. Changes the type of colors in Semantics class to match that of classes, and convert to tensor within semantic nerf before indexing.
Currently the nerfacto model  does not pass any gradients from the seg head into any weights used for rgb rendering, from local experimentation I found that passing gradients through to these parameters improves the segmentation performance significantly, while only causing a very minor regression in the rgb metrics ( from 27.2 to 27.1 PSNR). Hence, adding this is a configrable option during training. Due to this - scaling segmentation loss also becomes more important and hence exposing this as an additional hyper-parameter as well

trying this, updated from main, I see this runtime error, which may be from main and not this changeset:
│ D:\code\nerfstudio\nerfstudio\data\pixel_samplers.py:100 in <dictcomp>                           │
│                                                                                │
│    97 │   │                                                                                │
│    98 │   │   c, y, x = (i.flatten() for i in torch.split(indices, 1, dim=-1))                   │
│    99 │   │   collated_batch = {                                                                 │
│ ❱ 100 │   │   │   key: value[c, y, x] for key, value in batch.items() if key != "image_idx" an   │
│   101 │   │   }                                                                                │
│   102 │   │                                                                                │
│   103 │   │   assert collated_batch["image"].shape == (num_rays_per_batch, 3), collated_batch[   │
╰──────────────────────────────────────────────────────────────────────────────────────────────────╯
RuntimeError: indices should be either on cpu or on the same device as the indexed tensor (cpu)

Applying the recommended fix for #1465 and commenting out semantic_nerfw.py:223 allows the model to train.

Hmm @machenmusik i don't see either of those issues while training locally.
Since colors are a List I'm not sure the given fix will work for my case.
And I do not see the mask issue raised when training locally. Do you have a branch / command I can use to reproduce locally?

Also the mask changes cause my training times to go down around 10x, and runs successfully when I revert all the changes made

To be clear, you are saying that in your configuration, you can revert https://github.com/nerfstudio-project/nerfstudio/pull/1467/commits/d3c9c829ba950dd179764cf510ac9d3094f934ba and it doesn't throw errors while training semantic-nerfw (as well as being 10x faster), correct?

d3c9c82

Yes reverting this commit does not lead to training errors for me. I think the semantic issues you are facing are due to us using different dataparsers. I am using the minimal_dataparser. I will make the required changes to fix this.

To be clear, you are saying that in your configuration, you can revert d3c9c82 and it doesn't throw errors while training semantic-nerfw (as well as being 10x faster), correct? Do you also need to revert the constructor change to avoid the log message? I am not sure the other changes should be reverted, particularly the semantics output option which kills the viewer for me when selected.

Yes reverting the given commit causes a 10x speedup and still runs fine.
I think the issue was the mismatch between the friends-dataparser and the minimal-dataparser. To be consistent with before Ive just changed the minimal dataparser to match the correct type

Thanks for making changes; unfortunately, I am getting this error at runtime
│    97 │   │                                                                                │
│    98 │   │   c, y, x = (i.flatten() for i in torch.split(indices, 1, dim=-1))                   │
│    99 │   │   collated_batch = {                                                                 │
│ ❱ 100 │   │   │   key: value[c, y, x] for key, value in batch.items() if key != "image_idx" an   │
│   101 │   │   }                                                                                │
│   102 │   │                                                                                │
│   103 │   │   assert collated_batch["image"].shape == (num_rays_per_batch, 3), collated_batch[   │
╰──────────────────────────────────────────────────────────────────────────────────────────────────╯
RuntimeError: indices should be either on cpu or on the same device as the indexed tensor (cpu)

`

raise ValueError("mask")
Command - ns-train semantic-nerfw --data data/friends/ELR-apartment/ --vis tensorboard friends-data
I cannot reproduce -

with your suggestion on line 92 -
    ret = func(*args, **kwargs)
  File "/home/nikhil/nerfstudio-main/nerfstudio/pipelines/base_pipeline.py", line 255, in get_train_loss_dict
    ray_bundle, batch = self.datamanager.next_train(step)
  File "/home/nikhil/nerfstudio-main/nerfstudio/data/datamanagers/base_datamanager.py", line 427, in next_train
    batch = self.train_pixel_sampler.sample(image_batch)
  File "/home/nikhil/nerfstudio-main/nerfstudio/data/pixel_samplers.py", line 198, in sample
    pixel_batch = self.collate_image_dataset_batch(
  File "/home/nikhil/nerfstudio-main/nerfstudio/data/pixel_samplers.py", line 92, in collate_image_dataset_batch
    raise ValueError("mask")
ValueError: mask

without -
Step (% Done)       Train Iter (time)    ETA (time)           Train Rays / Sec
-----------------------------------------------------------------------------------
110 (0.37%)         29.405 ms            14 m, 38 s           139.34 K
120 (0.40%)         29.227 ms            14 m, 33 s           140.18 K
130 (0.43%)         29.089 ms            14 m, 28 s           140.84 K
140 (0.47%)         29.422 ms            14 m, 38 s           139.26 K
150 (0.50%)         29.720 ms            14 m, 47 s           137.91 K
160 (0.53%)         29.744 ms            14 m, 47 s           137.82 K
170 (0.57%)         29.364 ms            14 m, 35 s           139.57 K
180 (0.60%)         29.364 ms            14 m, 35 s           139.59 K
190 (0.63%)         29.662 ms            14 m, 44 s           138.21 K
200 (0.67%)         29.975 ms            14 m, 53 s           136.75 K

@machenmusik are you able to run this command on the main branch? If not, then I say we merge this PR, and open an issue and debug separately

Agreed, although I am a little concerned that the reference dataset for semantic-nerfw at the moment doesn't seem to work with it anymore... was trying to ensure that semantic-nerfw has not inadvertenttly changed here to support only your datasets (which I am not sure are available to others).
If someone else can quickly confirm that friends dataset also fails for them with simple ns-train against main / 0.1.18, as it does for me, yes let's track that as separate issue and merge this.

Agreed, although I am a little concerned that the reference dataset for semantic-nerfw at the moment doesn't seem to work with it anymore... was trying to ensure that semantic-nerfw has not inadvertently changed here to support only your datasets (which I am not sure are available to others).
If someone else can quickly confirm that friends dataset also fails for them with simple ns-train against main / 0.1.18, as it does for me, yes let's track that as separate issue and merge this.

I'm a bit lost, does semantic nerf-w fail for you both on this branch and main?
Friends data trains successfully for me as shown above.

Yes, fails on both.  I notice that I am not providing friends-data on command line, and that I was doing Monica apartment... will try ELR-apartment later to confirm.  Since it works on your end, I think we should merge here and file separate issue.

Thanks @nikmo33 for working through issues!

Thanks @nikmo33 for working through issues!

I do not think we should be making separate logic changes as part of this same PR after the it has already gotten an approval. These defeats the purpose of CI, as these changes have not been reviewed by any of the approvers. Please open a separate PR for this kind of issue on the future, especially since it totally unrelated to the PR already approved. Thanks.

Understood.  IMO, one challenge is that most approvers are on Linux, and so Windows coverage lags.


feat: support config_path mirror for containerd

Description

Related Issue

Motivation and Context

Screenshots (if appropriate)

@yxxhero @hyy0322


[QUESTION] How and why do you split your operations folder into manifests and releases?

Hey Marco, I've watched your DevOps Porto meetup and was trying to understand how to setup a cluster managed like this.
But I'm not understanding why do you split the operations folder into manifests and releases. I've only noticed that manifests run after the releases.. Could you explain that?
Thanks,
Serpa

Hey @serpa-dystematic !
I split the operations folder basically in two Kustomizations, because some resources (Gateway, Prometheus, etc.) are dependent on some CRDs to exist and which are only created when their Helm Releases are installed. If I'd put everything in the same Kustomization it'd fail.
Then I create a dependency in operations-manifests Kustomization to the operations-releases Kustomizations which install the Helm Releases that created the needed CRD and afterwards the dependent custom resources. It should have a health probe to guarantee that the helm releases were already installed, btw. One of these days I'll add it :)
Hope it helped.

So it's just a matter of dependencies and order, perfect!
That helped, thanks a lot! 🙌


IncorrectFee error - need to impl komodo rules for tx fee including interest calc

when syncing with kmd main net there are errors IncorrectFee.
f.e. for tx:
2022-10-14T09:50:14.892825Z  INFO {zebrad="3be5fb7" net="Main"}:sync:try_to_sync:obtain_tips: zebra_consensus::transaction: tx=89d02a53ac972abed9a66eb1a2d84779d5c76248c859d7bdd7f40e84c9eedcc3 value_balance=Ok(ValueBalance { transparent: Amount<zebra_chain::amount::NegativeAllowed>(-8753732), sprout: Amount<zebra_chain::amount::NegativeAllowed>(0), sapling: Amount<zebra_chain::amount::NegativeAllowed>(0), orchard: Amount<zebra_chain::amount::NegativeAllowed>(0) })

The balance is negative because of interest not calculated yet. It must be calculated to fix this rule

waiting for interest calc to implement

see main repo


Attempt to run integration tests on Travis

I am just testing what prevents Travis from running integration tests.

This pull request didn't trigger Jenkins as its author isn't in the whitelist.
An organization member must perform one of the following:

To have this branch tested by Jenkins, use the "ok to test" command.
To have a one time test done, use the "test this please" command.

Those commands are simple Github comments of the format: "jenkins: COMMAND"

https://travis-ci.org/lxc/lxd/jobs/170737084#L180
github.com/lxc/lxd/lxd
# github.com/lxc/lxd/lxd
lxd/nsexec.go:28:10: fatal error: 'linux/sched.h' file not found
#include <linux/sched.h>
         ^
1 error generated.
make: *** [default] Error 2

I give up. What's going on?

Travis is running a crazy old version of Ubuntu which doesn't have any of the bits we need to run a proper testsuite. Even if that wasn't the case, travis performance is terrible and it'd potentially take 1h+ to run through a test whereas Jenkins gets us through 24 full testsuite runs in less than 20min.

Travis says to use Docker - https://github.com/travis-ci/travis-ci/issues/6469
Why not LXC? =)


Javascript for sign up page an the sign up and  sign in page.

The javascript for the signup page is not completed yet.


What is the license?

I am using this (Thank you!) and I would like to make changes and share the source.
What license is this under?
Cheers

Hi Azza,
I've added the MIT license to the project. Feel free to use however you like.


Maintenance Fixing Build Errors and Add Support for Python 3.7 & 3.8

This PR fixes the Travis build errors for python 3.5 and 3.6 by fixing sphinx errors/warnings.
Also included are fixed typos/spelling errors in README and doc-strings, and adding support for Python 3.7 and 3.8.

Also related to this PR, I wanted to bring up Python 2 support. Are there plans to drop it, or do you plan to support it indefinitely?
If dropping it is planned, I would be happy to get started on that with this PR.


Make the RPM spec compatible with downstream packages

- What I did
I edited the RPM spec to provide docker so it's a drop-in replacement for downstream packages.
Related issue: docker#26059
- How I did it
I used rpmrebuild to test the package as I got an unexpected error trying to do a full build:
error: %changelog not in descending chronological order
- How to verify it
You should be able to do this on Fedora and CentOS without conflicts:
dnf/yum install atomic kubernetes-node
- Description for the changelog
Provide docker to be compatible with downstream packages
- A picture of a cute animal (not mandatory but encouraged)

Signed-off-by: David Osztertag

So it seems this could be inconvenient: The older versions conflict with docker so they would first have to be uninstalled to be able to install the new version. But I think it's worth it in the next major release otherwise the upstream package breaks the entire ecosystem.
Maybe there is an RPM work around that I don't know about. Any ideas?

ping @mlaventure @tiborvass @kencochrane ptal

I don't know much about the RPM inner workings, maybe @tianon does?
Also, depending on when we switched to docker-engine for the package, it may not be a good idea to break the compatibility just yet.

@mlaventure, the name of the package will still be docker-engine but it will also provide docker so all the tools that depend on it can work with the upstream package too. This is a major reason to not use the upstream package as it is now. The thing that breaks is easy upgrade from 1.12 to 1.13.

The upgrade should be seamless, right?  The current package would have to be removed for this package to be installed, so rpm or yum or dnf or whatever should be able to figure out that this package replaces the existing one, right?
Regardless, it sounds like Provides implies Conflicts, so I'm +1 on this change. :+1:

I am also not an expert at the inner workings of RPM. I defer to @tianon, if he feels it is good. I trust him :)

I think GitHub needs to add :sweat_smile: to the list of available reactions for a comment. :sweat_smile: :innocent:

@tianon, that's the thing. You would have to do:
yum remove docker-engine && yum install docker-engine

Nothing is lost of course but a simple yum upgrade won't work unless there is a workaround.
Why did it have to conflict with docker in the first place?

I have in idea: In a minor release - say 1.12.2 - we remove the conflict.
Then the upgrade to 1.13 will be seamless. There is nothing I can think of for <1.12 to 1.13.

Ah, that's kind of frustrating.  IIRC, it had to conflict with docker originally to ensure that they couldn't be installed concurrently (since they do conflict both in installed binaries and in runtime functionality).
IMO your workaround to do the conflict removal in one release and add provides in a future release makes sense, although I'm not sure whether just adding it to a minor bump of 1.12 would be sufficient (or even acceptable this late in the RCs) -- we'd still need to document the workaround for users going from further back too.  I think we're probably back in @thaJeztah territory (or at least he'll likely know who to loop in for whether that's tenable). :smile:

Not as frustrating as not being able to use a lot of things requiring docker. :smile:
With provides the upstream package would replace (upgrade) the downstream package.
Which is fine in my opinion, since the upstream repo is 3rd-party. Community repos do this too.
That brings up another small problem: The different systemd unit files...
This systemd drop-in makes the upstream and downstream packages interchangeable:
[Service]
EnvironmentFile=-/etc/sysconfig/docker
EnvironmentFile=-/etc/sysconfig/docker-network
EnvironmentFile=-/etc/sysconfig/docker-storage

ExecStart=
ExecStart=/usr/bin/docker daemon \
    $OPTIONS \
    $DOCKER_NETWORK_OPTIONS \
    $DOCKER_STORAGE_OPTIONS

But I don't think they have to be 100% compatible. This is just something to note.
Frustrating, indeed...

It's too late for 1.12.2, work is in progress on building and testing the GA binaries, so unless there's a major issue discovered before that, the 1.12.2 release will go out the door later today.
I do like this though, so we should think of the most seamless approach possible (doing e.g. the 1.13.0 -> 1.13.1 trick could work)
w.r.t. the unit file, I don't think we should adopt that; we've recommend users to use drop-in files, instead of environment files (which was advised to us by (IIRC) the systemd maintainers as best-practice). Unfortunately, it looks like just about any distro now ignores those best-practices :smile:

Should I rebase the PR to only remove the conflict?

@oszi yes please, it never hurts to have the PR in a mergeable state

@oszi oh! I misunderstood, I thought you meant "merge conflict"
Let's wait for @andrewhsu to have a look as well, to see what he thinks

i'll have a look

BTW I couldn't find the spec file for docker-engine-selinux, it may need similar changes.

I have a concern...I'd like to make sure this scenario does not quietly succeed in installing docker as well as docker-engine:
$ dnf install -y atomic # installs docker-1.10 as a dependency
$ dnf install -y docker-engine-1.12.3

Because do not want two docker packages installed at the same time.
Can you test to make sure?

The selinux spec file is here:
https://github.com/docker/docker/blob/master/hack/make/.build-rpm/docker-engine-selinux.spec

The situation got a bit more complicated...
On CentOS 7 and Fedora 25 there are multiple packages: docker-latest, docker, docker-common.
Obviously the stable and latest versions use different directories and binaries by default.
Also since F25 the docker package provides docker-engine for similar reasons.
Thus I had to edit and rebase the PR.
Here's how you can test it out, for instance in oszi/toolbox:fc25:
dnf install atomic skopeo rpmrebuild
# Install the upstream repo (which doesn't support releasever=25 yet so force 24)
dnf download docker-engine-1.12.3-1.fc24.x86_64
# Change the specs in an editor according to the updated changes
rpmrebuild -e -p -n docker-engine-1.12.3-1.fc24.x86_64.rpm
dnf install --allowerasing rpmbuild/RPMS/x86_64/docker-engine-1.12.3-1.fc24.x86_64.rpm
# Test with a dependent app
skopeo inspect docker://oszi/toolbox:fc25

Note that the seamless upgrade (without allowerasing) issue we discussed above remains.

ping @oszi @andrewhsu what's the status on this one; is this still doable?

Well, it's as doable as before but backward compatibility still breaks and there are too many quirks.
It's better to run docker-engine in a system container if you want upstream...
So I think this should be closed. :crying_cat_face:

Let me close this for now, but happy to reopen if we can come up with a solution!


fix DOS against SentPacketHandler when ACKing too many packets

An attacker could send ACK frames and never raise the LowestAcked value. Then we have to iterate over all packets between LowestAcked and LargestAcked in SentPacketHandler.ReceivedAcked.
This attack would only be limited (after implementing #186) when the number of randomly skipped packets gets larger than 255 (the maximum number of AckRanges in an ACK), and since we might skip one packet out of 1000, this is not an effective measure to mitigate this attack.
Ignoring all ACKed packets below the SentPacketHandler.LargestInOrderAcked might be a good idea for performance reasons in the case of a non-malicious client, but probably is not a suitable DOS mitigation, since by not ACKing a packet with low packet number (e.g. packet 1), an attacker could prevent this value from increasing (fast enough).
What I'd suggest is to introduce a maximum value for AckFrame.LargestAcked - AckFrame.LowestAcked, around O(5000) or so.

FFR: We decided to change the SentPacketHandler to keep all sent packets in a list and limit their number to ~500. This way we have ca (500+255) / (255 * 2 + 20) = 1.4 operations per byte of data, instead of the 5000 / (255*2+20) = 9.4 of the above proposal.


revert: hack-zeroslash

The package cannot be published because it contains a prohibited word, and I think the cleanest solution is just to revert the change (see #78 for more details).
This PR reverts:

cafd3fcd8966f48b879d853b65aa0a2b17c74436
a61ddcfdf376a31cf579c1d51849050adcc210da
96dedf93c167fb11badf8bd24fc91834890edc32

It's unfortunate this happened, but I do agree that not publishing is the correct action here. Thank you very much for all your contributions regardless!


Compile errors with Zahak-NNUE

Hi Amanj,
I’m following you NNUE branch with interest.
Up to yesterday it compiled fine, however with your latest commit 4b880b7, I get these errors on compiling:
engine/nn.go:6:22: cannot use [98304]float32{...} (type [98304]float32) as type []float32 in assignment
engine/nn.go:9840:21: cannot use [128]float32{...} (type [128]float32) as type []float32 in assignment
engine/nn.go:9856:22: cannot use [128]float32{...} (type [128]float32) as type []float32 in assignment
make: *** [Makefile:11: netgen] Error 2
Also I believe you need a “mkdir -p bin” in your Makefile under “dist: net gen” for the multiple Platform compiles as the bin folder doesn’t exist after a make clean.
I plan to run a cutechess tournament on my RPi 4 between your Zahak and Zahak-NNUE engines.
Al.

Thanks for having interest in the branch... it is still very early work in progress, the branch doesn't still outplay my latest stable release. I believe I should have a bug somewhere, which I am currently trying to figure it out
I expect to break the Makefile a few times before I get to something that works, for now (if you really want to build the branch), simply delete engine/nn.go file, it will be auto-generated when you run make build
But the included default.nn is a very experimental too, it will be very weak, most likely weaker than Zahak 5.0 too.
And, to compile the branch, you need gccgo installed, as this compiler enables AVX instructions and further optimizations than regular go compiler

Thanks for gccgo recommendation, I’d never heard of it.
However I now get these errors after installing gccgo v8.3.0 and trying your build:
Al@RPi4-SSD:~/Engine-Source/zahak-nnue $ make clean
go clean ./...
rm -rf bin
rm engine/nn.go    <<<<< I included this in the clean:
Al@RPi4-SSD:~/Engine-Source/zahak-nnue $ make build -j5
go run -ldflags "-X 'main.netPath=default.nn'" netgen/nn.go
mkdir -p bin
#go build -ldflags "-X 'main.version=e99e11f31b4cb856138867e1cdb8aeca8ed7ac7a'" -o bin ./...
go build -compiler gccgo -gccgoflags -O3 -o bin ./...
github.com/amanjpro/zahak/engine
engine/cache.go:32:27: error: expected ‘;’ or newline after top level declaration
const MOVE_MASK uint64 = 0b1111111111111111111111111111 // move << 0, 28 bits
^
engine/cache.go:33:27: error: expected ‘;’ or newline after top level declaration
const EVAL_MASK uint64 = 0b1111111111111111             // eval << 28, 16 bits
^
engine/cache.go:34:28: error: expected ‘;’ or newline after top level declaration
const DEPTH_MASK uint64 = 0b1111111                     // depth << 44, 7 bits
^
engine/cache.go:35:27: error: expected ‘;’ or newline after top level declaration
const TYPE_MASK uint64 = 0b111                          // type << 51, 3 bits
^
engine/cache.go:36:26: error: expected ‘;’ or newline after top level declaration
const AGE_MASK uint64 = 0b1111111111                    // age << 54, 10 bits
^
engine/movegen.go:1078:20: error: shift count not unsigned integer
var b = uint64(1 << sq)
^
make: *** [Makefile:16: build] Error 2
Al@RPi4-SSD:~/Engine-Source/zahak-nnue $
—————
I can still compile via “make dist -j5” but nothing works with build

Thanks for gccgo recommendation, I’d never heard of it.
However I now get these errors after installing gccgo v8.3.0 and trying your build:
Al@RPi4-SSD:~/Engine-Source/zahak-nnue $ make clean
go clean ./...
rm -rf bin
rm engine/nn.go    <<<<< I included this in the clean:
Al@RPi4-SSD:~/Engine-Source/zahak-nnue $ make build -j5
go run -ldflags "-X 'main.netPath=default.nn'" netgen/nn.go
mkdir -p bin
#go build -ldflags "-X 'main.version=e99e11f31b4cb856138867e1cdb8aeca8ed7ac7a'" -o bin ./...
go build -compiler gccgo -gccgoflags -O3 -o bin ./...
engine/cache.go:32:27: error: expected ‘;’ or newline after top level declaration
const MOVE_MASK uint64 = 0b1111111111111111111111111111 // move << 0, 28 bits
^
engine/cache.go:33:27: error: expected ‘;’ or newline after top level declaration
const EVAL_MASK uint64 = 0b1111111111111111             // eval << 28, 16 bits
^
engine/cache.go:34:28: error: expected ‘;’ or newline after top level declaration
const DEPTH_MASK uint64 = 0b1111111                     // depth << 44, 7 bits
^
engine/cache.go:35:27: error: expected ‘;’ or newline after top level declaration
const TYPE_MASK uint64 = 0b111                          // type << 51, 3 bits
^
engine/cache.go:36:26: error: expected ‘;’ or newline after top level declaration
const AGE_MASK uint64 = 0b1111111111                    // age << 54, 10 bits
^
engine/movegen.go:1078:20: error: shift count not unsigned integer
var b = uint64(1 << sq)
^
make: *** [Makefile:16: build] Error 2
Al@RPi4-SSD:~/Engine-Source/zahak-nnue $
—————
I can still compile via “make dist -j5” but nothing works with build

Incidentally, your current NNUE is not as weak as you think:
in a cutechess tournament with TC settings of 20 50 where each game took between 1-2 minutes, a 722 game tournament produced the following results:
Rank Name              Rating   Δ     +    -         #     Σ        Σ%      W    L    D   W%    =%   OppR
1 Zahak-v6.2         2794   0.0   25   25   722  523.0  72.4  472  148  102  65.4  14.1  2626
2 ZahakNN-v6.2   2626 167.4  25   25   722  199.0  27.6  148  472  102  20.5  14.1  2794
However in a shorter 64 game tournament of TC settings of 120 40 where each game took 10-18 mins, it faired much better:
Rank Name               Rating   Δ     +    -      #       Σ     Σ%     W    L    D   W%    =%   OppR
1 Zahak-v6.2         2802    0.0   77   77    64   37.0  57.8   32   22   10  50.0  15.6  2748
2 ZahakNN-v6.2   2748  55.0   77   77    64   27.0  42.2   22   32   10  34.4  15.6  2802
I tried to base the Elo on a estimated rating of @2800 for Zahak v6.2, but at least it shows the Elo difference.
So the NN version is much closer at slower time controls (55 Elo weaker rather than 167.4 Elo weaker)
I appreciate we need a stronger NN file, I’m also hoping you can produce a few of different strengths to provide us with levels.
Al.

Even with a stronger net (a net that is actually very close to Bit-Genie's net, that is a 3000 elo engine), my NNUE branch cannot beat Zahak 6.2 (even after I use the much faster gccgo compiler)
So, there must be an issue somewhere in my probing code.
As for the gccgo compiler issue, you are using a very old compiler, which couldn't parse binary literals, you probably want to upgrade it to the latest

Thanks for the update, however that is the latest version on the Raspberry Pi. Normally with other compilers if I need a later version I download the source and build it myself, but I cannot find anyway of the doing that with gccgo.

hi, i'm not into GO but normally i succeed in using a Makefile .. yours is OK, i even used make dist   to get a linux amd64 binary but what about that gccgo thingy ?  I found it in my Synaptic and installed it, but how to change your Makefile into gccgo ?  I tried replacing "go" with "gccgo" in the Makefile, but i get errors .. it seems gccgo has another syntax ?!  I found https://golang.org/doc/install/gccgo and i read "Using gccgo" but it gave me no clue .. i'd like to compile your go source into AVX / BMI code while my newest laptop has it ..

Hi,
Once you have gccgo installed (on the RPi it’s  sudo apt install gccgo) you just need to change the
dist: netgen     in the Makefile to
dist: netgen build
& then run the make via make dist
the build part uses the earlier build: reference in the Makefile to use gccgo

Good news, I finally got NNUE work, it is currenlty around +90 against 6.2... Once I cleanup the code a bit, I will also provide a better Makefile
You can still compile with normal go-compiler, it will just be slower (weaker), but probably this won't matter if you want it on DGT Pi

Great, I’ll wait for you to add the code to your GitHub …

i managed to tackle my issue : you're talking about https://github.com/amanjpro/zahak/tree/nnue .. indeed, there i find a Makefile which has some gccgo commands .. however, at first i encountered problems with the golang versions on my Xubuntu 20.04 : i had 1.13.8 and also 1.16.2 installed !?  And go version showed 1.13 but your code warnings show i need 1.16.2 to be used .. then i found the tool gvm by https://otzarri.net/install-multiple-versions-of-golang-on-ubuntu/ and thus i made 1.16.2 default, and so zahak-nnue (from your ZIP) compiled OK !  And it runs in CuteChess with the default.nn !
can AVX(2) be compiled ?  (i adjusted the Makefile)

can AVX(2) be compiled ? (i adjusted the Makefile)

With GCC go, it is automatically activated when it is supported, go-compiler doesn't do that

Is this still an issue? can we close it?

closing is OK with me


hi, where can i find the images

Github does not allow large files to be uploaded, we use OneDrive to share this dataset, And you can find the URL in Readme.


Remove GOPATH/GOBIN env var set dependency for the install_custom_golanci_lint function

What does this PR do?
This PR removes the need for GOPATH/GOBIN env var definition in the install_custom_golanci_lint function.

Motivation
In the current state if you neither have GOPATH nor GOBIN defined the function will fail with
Not able to install custom golangci-lint binary. golangci-lint won't work as expected

This imo not the best behaviour as from the go documentation:
If GOBIN is set, binaries are installed to that directory. If GOPATH is set, binaries are installed to the bin subdirectory of the first directory in the GOPATH list. Otherwise, binaries are installed to the bin subdirectory of the default GOPATH ($HOME/go or %USERPROFILE%\go).

IMO we should use $HOME/go if neither GOPATH nor GOBIN is defined.

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

/merge


#24 in addition to "/" also "." can be used as tag separator

related to #24

in addition to "/" also "." can be used as tag separator (see #24)
not yet implemented: autocompletion using "."

I'll review on next weekend.

@aisbergde do you mind if I commit changes to your branch?

а почему бы нет? I think, this should or could work?

Any idea when this will be merged? I would be interested in this feature as well. Thanks!

any chance to get this request merged?


Options for datasource configuration (yaml)

New grafana allows administrators to use conf/provisioning/datasources/something_here.yaml mechanism to provide datasources through configuration  tools (e.g. ansible).
I'm trying to construct a valid yaml to describe a proper configuration, but it's hard. Could you add example into documentation somewhere, please?
My current best efforts:
apiVersion: 1

datasources:
  - name: ClickHouse
    type: vertamedia-clickhouse-datasource
    access: proxy
    basicAuth: true
    url: http://<IP_ADDRESS>:8123

Things I don't know how to set up:
defaultDatabase:
User:
Password: (both for basicAuth mode).
Thanks!

Thank you!


Add a list for projects using sacred

A list like that should help users to discover common usage patterns and
demonstrate how many cool projects sacred has enabled.

@yuvalatzmon I hope you don't mind linking your repo here. I believe projects like yours could be very valuable to other so it is good to collect them.

Thank you, of course!
On Tue, Feb 26, 2019 at 3:17 PM Rüdiger Busche<EMAIL_ADDRESS>wrote:

@yuvalatzmon https://github.com/yuvalatzmon I hope you don't mind
linking your repo here. I believe projects like yours could be very
valuable to other so it is good to collect them.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/IDSIA/sacred/pull/424#issuecomment-467433781, or mute
the thread
https://github.com/notifications/unsubscribe-auth/APwwM78zL-iz2BOyzUmM4gIQZneJ3jpdks5vRTPigaJpZM4bSJYU
.


Fixing the buttons section in footer

The buttons in the footer takes user directly to the top of the page not to the required section . I would like to fix it . Kindly assign this task to me under GSSoC'24 .It would be a great opportunity to contribute in open source community.

Assigned!

@anuragverma108 Could you please clarify whether the reviews button is to be added or not as there is no such reviews section in the page and also in navbar

Replace it with Contact.

@anuragverma108 I have generated PR kindly review it.....


Example 7 is just wrong...

This whole example should be modified to be simpler because it does not work.
Here is where things start to break down:
Add-DistributionGroupMember -Identity $group -Members $members -BypassSecurityGroupManagerCheck:$true
There is no -Members in Add-DistributionGroupMember.  There is -Member, but it only allows individual items and does not seem to allow arrays.
Cannot process argument transformation on parameter 'Member'. Cannot convert the "System.Collections.ArrayList" value
of type "System.Collections.ArrayList" to type "Microsoft.Exchange.Configuration.Tasks.RecipientWithAdUserGroupIdParame
ter`1[Microsoft.Exchange.Configuration.Tasks.RecipientIdParameter]".
+ CategoryInfo          : InvalidData: (:) [Add-DistributionGroupMember], ParameterBindin...mationException
+ FullyQualifiedErrorId : ParameterArgumentTransformationError,Add-DistributionGroupMember
+ PSComputerName        : outlook.office365.com

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: c0a9c45b-34dd-c1c8-89f0-84f3d968eac4
Version Independent ID: ec9c910c-25f2-f36a-8f75-ce052f0e8be6
Content: Set-CalendarProcessing (exchange)
Content Source: exchange/exchange-ps/exchange/mailboxes/Set-CalendarProcessing.md
Service: exchange-powershell
GitHub Login: @chrisda
Microsoft Alias: chrisda

@officedocsbot assign @yogkumgit

@chrisda Please merge the PR #5169 Thanks

@dariomws  Thank you very much for the contribution and updating the documentation with PR. @serafing Hope this update is helpful for you. Thanks for taking out some time to open the issue. Appreciate and encourage you to do the same in future also.


N seems off for most languages in the table

In most other languages splitN instead splits the original string N amount of times

When passing 2, i'd thus expect two separators to be consumed - ie, Python's results. However, every other language in your table only consumes 1 separator.
It seems to me like Python and JavaScript are the only ones doing the intuitive thing to me, they just disagree about what to do with the remainder of the string.
(obviously another mental model could be, "2 means i want 2 parts", but in that case, #2 means it should be a red x, and JS could be green because it gives you two parts)

You are right - all languages do N-1 splits, but return N items, whereas JS does N splits and returns N items. I will update the text.

Ok, updated in fe267ad2904f55c801be96c86ec5ed90bf259a12. I have also added some more motivation text to explain why the other behaviour is often preferable.

Note: additional fix in 4de0a77a7b8c74db0df777b1d4d62eede01b0531. I misunderstood Java's behaviour in my previous patch.


Package request: nvim-treesitter/norg-meta

Project description

The tree-sitter norg-meta is already available, I was wondering how/if we could also make available as a nvim-treesitter grammar as we did for the normal norg grammar file? I tried to workout how to do this and am still unsure.

Metadata

homepage URL: https://github.com/nvim-neorg/tree-sitter-norg-meta
source URL: https://github.com/nvim-neorg/tree-sitter-norg-meta
license: mit
platforms: unix, linux, darwin

Add a :+1: reaction to issues you find important.

Found this thread:  https://discourse.nixos.org/t/which-treesitter-grammars-end-up-on-nvim-treesitter-generated-nix/38497


Anyone know where candy_cost values can be found?

Can't seem to find candy_cost in any of the logged responses.
I'm trying to set up a script to rename pokemon with their iv values && the number of evolutions possible. Was hoping this value would be sent with one of the responses: https://github.com/AeonLucid/POGOProtos/blob/3682394bf5c10ac5ebdfcb06cd7f0f7479afc7a5/src/POGOProtos/Settings/Master/PokemonUpgradeSettings.proto#L7

It's possible that the app only sends a DownloadItemTemplates request on login, or that there are internal templates in the app which the server does not have new versions of.

candy_to_evolve is also a field in PokemonSettings which can be part of the DownloadItemTemplates response.

Might just never get sent - I mitm'ed from the fresh start and didn't log any of these values in the response. I guess it's not too hard to create a map for the ones I really care about.


⚠ Bofrost.fr has degraded performance

In 707b9fe, Bofrost.fr (https://www.bofrost.fr) experienced degraded performance:

HTTP code: 200
Response time: 1459 ms

Resolved: Bofrost.fr performance has improved in 7aa77a9 after 6 minutes.


Add rest crud to ducks

Coverage decreased (-2.06%) to 93.182% when pulling a78442a8da0cf58ca0cf22618c932e335fb7c087 on with-crud-ducks into 50882b2b6ac8ab5aac7cf9fdd4478d9ef79f72e3 on master.


Broken CLI

I have installed the 1.27.1 ubuntu snap and cli options are not working at all, atom --help, atom --wait etc. do nothing at all.

Hi @memeplex, the Snap image for Atom is maintained and distributed by Snapcraft and isn't supported by the Atom team.  You should file this issue over at the repo that manages this project:
https://github.com/snapcrafters/atom
Thanks!

Ok, thanks, I confirm the .deb provided by the atom team doesn't show the problem.


fixed UI issues

fixes #607
fixes #608

fixes search box miss alignment
fixes language switcher alignment

#608 still occurs in mobile view.


Pass all RPC span contexts to handlers

Description
This PR follows f8c0e55 and wires up the rest of our RPC calls to their handlers
Why is this needed
This further improves our otel tracing visibility
How Has This Been Tested?

light testing with evans

How are existing users impacted? What migration steps/scripts do we need?
N/A
Checklist:
I have:

[ ] updated the documentation and/or roadmap (if required)
[ ] added unit or e2e tests
[ ] provided instructions on how to upgrade

@jacobweinstock if you had cleared the review request for Manny, Mergify would have merged it.


CosmosClient.CreateDatabaseStreamAsync throws ArgumentException in ValidateResource() call instead of returning ResponseMessage with correct error-code

We are continuously addressing and improving the SDK, if possible, make sure the problem persist in the latest SDK version.

Describe the bug
CosmosClient.CreateDatabaseStreamAsync throws ArgumentException in ValidateResource() call instead of returning ResponseMessage with correct error-code.  This breaks the exception-less contract.
To Reproduce
Create a database name with space at the end.
Expected behavior
ResponseMessage with BadRequest statusCode.
Actual behavior
System.ArgumentException: The resource name can't end with space.
at Microsoft.Azure.Cosmos.DocumentClient.ValidateResource(String resourceId)
at Microsoft.Azure.Cosmos.CosmosClient.CreateDatabaseStreamAsync(DatabaseProperties databaseProperties, Nullable`1 throughput, RequestOptions requestOptions, CancellationToken cancellationToken)
Environment summary
Azure CosmosDB Compute
Additional context
ComputeDebug
| where ActivityId == "f97db752-2f65-4037-b81d-c78c889b2f73"

@sivethe What kind ResponseMessage should it be, if there is no actual network call?
Stream APIs contract of not throwing exceptions is related to the actual network operation or service response. But if the invoked method has wrong parameters, those are surfaced as exceptions.
For example, calling CreateDatabaseStreamAsync with a null parameter:
https://github.com/Azure/azure-cosmos-dotnet-v3/blob/0a1f95e43d83d47fdddcf2ae1d8d14a599599101/Microsoft.Azure.Cosmos/src/CosmosClient.cs#L763

or passing id as null:
https://github.com/Azure/azure-cosmos-dotnet-v3/blob/0a1f95e43d83d47fdddcf2ae1d8d14a599599101/Microsoft.Azure.Cosmos/src/CosmosClient.cs#L460

The referenced exception is just another validation taken place.

@ealsur :  I had an offline chat with Kiran and we decided to fix this in our layer.  We can close this bug


feat(FN-2069): recompile css files for table width fix

Introduction :pencil2:
The CSS needs recompiling after changes are made. The table fix in #3463 missed this step :(
Resolution :heavy_check_mark:
Recompile CSS for TFM UI with npm run build command.
Miscellaneous :heavy_plus_sign:
Double checked the table width fix is included by searching for table.utilisation-report-reconciliation-table{table-layout:fixed;width:calc(100% - 1px)} within the compiled CSS (present). Recompiled the CSS for the latest version of main merged in.

FF jobs hanging?? Updating branch to latest main to retrigger

Note to self: Merged in latest main locally and recompiled the CSS, no file differences so should be safe to merge as is


IGAPP-1172: Restore scroll position poi deselection

Note: On native the restore of the listScrollPosition only works if BottomActionSheet is fullscreen, because you basically can not scroll if you are not at highest snapPosition(fullscreen)
We could create an issue for this. Last one was closed due to missing template
https://github.com/gorhom/react-native-bottom-sheet/issues/917
Tested on Chrome(web), android(native) & ios(Simulator)

Nice! Tested on Firefox and simulated iOS. One small thing: on iOS, I am returned to the actual scroll point I was at whereas in the browser, I am returned to a different scroll point where the selected POI is at the top of the view. I don't think it's an important difference though.

Yes i used two different technologies for web & native.
Web -> scrollTo elementID which is super nice and only possible in DOM
native: scrollTo scrollPosition, since we would have to track onLayout all the coordinates of all PoiListItems which is very resource intense in some case like munich (150+ pois)

Tested in safari. When you select the poi via the map, the scroll position will "falesly" be restored to the position of the selected poi. But that sth. I am really not mad about.
Tested on android emulator. When deselecting the poi via the map the scroll position is not restored. I think this could be easily fixed, right?

@sarahsporck you can not restore the scroll position when selecting on the map because you basically didn't scroll to it on the list so how should you know the scroll position. I think the restore of the position should only happen if you select it  on the list. So i'm gonna change that in the web app i think.

I think the restore of the position should only happen if you selected it on the list even for web when you scroll by elementId. So i adjusted it to only scroll if you selected the poi from the list.

Jep. As stated, in web it really doesn't bother me. It is just a small inconsistency.
And in native 2. seems to prevent restoring either way, so that's also fine then.

As I mentioned in the description the scrolling inside of the bottom Sheet is only enabled at it's highest snappoint which is fullscreen (in our case) , so if you snap it down to a lower point and deselect the poi scrolling does not work. I could investigate some time to patch the library or create an issue (at least)

Ahh okay. I missed that comment. Either way, nice work. Thank you for investigating that. 👍🏼


fix: Path error while setting up shifu demos in local system

What type of PR is this?
/kind documentation
What this PR does / why we need it:
Adding an instruction in order to hit the right directory to make shifu tutorials work without throwing incorrect path errors.
Which issue(s) this PR fixes:

Fixes https://github.com/Edgenesis/shifu/issues/597

What type of PR is this?
/kind documentation
What this PR does / why we need it:
Adding an instruction in order to hit the right directory to make shifu tutorials work without throwing incorrect path errors.
Which issue(s) this PR fixes:
Fixes Edgenesis/shifu#597

I have mentioned the directory name as shifudemos instead of testdir, it will automatically be fixed once the second part of this issue is solved: https://github.com/Edgenesis/shifu/issues/597

Hi @SuperAayush , thank you for this PR, in order to merge this in we need to adjust https://github.com/Edgenesis/shifu/blob/main/test/scripts/shifu-demo-install.sh#L34 too, do you mind creating a PR in https://github.com/Edgenesis/shifu for this?

Hi @SuperAayush , thank you for this PR, in order to merge this in we need to adjust https://github.com/Edgenesis/shifu/blob/main/test/scripts/shifu-demo-install.sh#L34 too, do you mind creating a PR in https://github.com/Edgenesis/shifu for this?

Hi @tomqin93, I have asked the same question by commenting on the issue here:
https://github.com/Edgenesis/shifu/issues/597#issuecomment-1553013455
The PR is ready can you look at that comment and let me know how to proceed?

@SuperAayush added 1 minor comment, the rest looks good

Thank you for the review, resolved the issue!!

Hi @SuperAayush , thank you for this PR, in order to merge this in we need to adjust https://github.com/Edgenesis/shifu/blob/main/test/scripts/shifu-demo-install.sh#L34 too, do you mind creating a PR in https://github.com/Edgenesis/shifu for this?

For this I have made a PR, please review it once you find time: https://github.com/Edgenesis/shifu/pull/604
Thank you!!

Thanks @SuperAayush , will merge this in after we release v0.19.0 on Monday


📖 doc: fix readme typo

@Shubhamkashyap1601 Thank you for your contribution, if interested, you can view your  contribution score here https://docs.google.com/spreadsheets/d/1ukyXgi_jRPeXj7EAST0IrnPfLOQ6xDBkcyAJY9N-Yb4/edit#gid=1117970540


CVAT 2.3 doesnt reliably count event "Changed Label"

My actions before raising this issue

[ X] Read/searched the docs
[X ] Searched past issues

Steps to Reproduce (for bugs)
Start labelling a task, sometimes Changed Label will be recorded in Kibana, sometimes it won't (all other events are counted reliably).
Context
Trying to pay our annotators, we have a 'per change' rate, and without this information it's going to need to be guess work.
I'm assuming the fix will be to switch to 2.4 and use the new Grafana dashboard, but wanted to leave this here in case anyone else hits the same problem, or if there were a way to better warn against the use of 2.3 for the Kibana analytics.

In fact here are the logs after I change label.

vs. delete object

I don't know what causes the difference between label changes that are recorded, and those that aren't. But they're recorded a very small fraction of the time.

@GeorgePearse
Hi, 2.3 is too outdated and in the latest versions analytics is completely redesigned with a different stack. https://opencv.github.io/cvat/docs/administration/advanced/analytics/
Unfortunately we don't have the resources to support old versions, please consider upgrading.

Looks like changeLabel and set of other logs are not counted but exists even if our develop branch and the latest releases.

Any update on when this is likely to be resolved? Can't really get more annotations completed until it is. Thanks a lot!

Should be fixed in the latest release


Create file generate file resource from scheme

Can we generate / set defaults from the schema

I believe we could do this. @cmh2166 can you suggest some defaults for us to put in maps/DepositFile.json?

related to #379

See the defaults added to the MAP. this doesn't cover all required fields, but the ones in which we can make a default: https://github.com/sul-dlss-labs/taco/blob/file-defaults/maps/DepositFile.json


M2 Planning: Re-organize code and document the organization for future maintainers

Milestone 2 incudes cleanup, documentation, and unit testing of the code.  With Milestone 1 successfully demo'd, it's clear that some code should be rearranged a bit, and unit tests written for the rearranged code.
Terminology: APID refers to API D(escription|efinition|ocument) in the (potentially) multi-document sense.  An "OAS document" (probably small-d) refers to a single discrete element (file or network resource) within an OAS APID.  Documentation should use "OAS APID" in most places, as there are other APID formats.
APID interface

We may want to avoid the "API description" vs "API definition" debate and go with "APID" (e.g. oascomply.apid in place of oascomply.apidescription), particularly in code so we don't have to change it to align with any future consensus
Document loading and caching should be factored out into its own module, instead of being attached to apidescription.  This probably includes support for argparse-based CLI options, the structure of which is a bit unusual but seems to work, and is shared between the oascomply and oas30-schema tools (albeit with different option names)
Clearly define the external interface for oascomply as a library, which should center on the APID concept

Naming Conventions and coding style

Document and be consistent about naming.  I seem to have settled into a "camelCase everything, including acronyms" approach as it keeps things distinct from various libraries using almost-but-not-quite-the-same names with all-caps acronyms (e.g. rfc3986.URIReference, jschon.URI, rdflib.URIRef)
Determine and document what things can and should be abbreviated (Pointer vs Ptr, Relative vs Rel, etc.), balancing readability and name length (RelativeJsonPointerTemplate is really quite long, and RelativeJsonPointerTemplateEvaluationError is ridiculous - RelJsonPtrTemplateEvalError is probably clear enough an actually fits on a line)
Consider an auto-formatter like black.  It will irritate me but probably be better in the long run.
Decide what to do with type hinting.  It seems kind of nice for interface documentation, but probably not more than that

Error handling

Define and document a base exception class and error management philosophy
It should be entirely possible to determine how to handle an error from the exception type, without examining its message at all; exception classes should define properties to access the relevant structured data
Ideally, exception class constructors would not take a message, but create one from its arguments (although allowing part of the message to be passed directly is fine as long as it is purely for human consumption)
Error structures from libraries should be encapsulated like any other aspect of library usage; however, raw access to library errors and data structures should be available in the API and should be logged if verbosity is turned all of the way up

Document construction and access

Need to decide whether and how much to encapsulate the usage of jschon's suite of JSON tools (JSON, JSONPointer, RelativeJSONPointer, and JSONPatch)
Subclassing is not sufficient to prevent leakage via exception classes
It's unclear if the OasJson class is the right approach; an alternative might be giving an extension of jschon.JSONSchema the notion of a schema root independent of a document root

URIs (and IRIs), [Relative] JSON Pointers, and Templates of all of these things

Put the basic encapsulation of and user-friendly facade for the rfc3987 in its own module (which could be its own package)
Put OAS-style URL templating in its own module
If encapsulating jschon's JSON Pointer classes, put those in their own module
Keep [R]JP Templates in their own module
Put the JSON Pointer IRI-fragment-specific extensions in their own module, and decide whether .fragment should a a pointer instance or stay a string and have the pointer instance be .ptr or similar
Decide whether making all of these things comparable to str is really the right idea

JSON Schema functionality

Code that specifically extends jschon (potentially relying on unmerged upstream PRs that might change direction) to support OAS-related functionality should get its own module
The jschon-based implementation of the OAS dialects should get its own module, probably including the OAS-defined formats (although maybe they get a separate module)
Implementation of JSON Schema-defined formats for jschon should get its own module (which could potentially be contributed upstream if we wanted, although our correctness vs performance balance may not be ideal for general use)
The old oastype4jschon module is not used and should either be removed or updated; as the vocabulary is still annotation-only, it's unclear if there's a use for an implementation module (other than to allow the vocabulary to be used in $vocabulary with a true value, which might be reason enough given how trivial it is to support)
The framework for driving actions through annotations should be extracted from apidescription and probably generalized somewhat, in order to support future extensibility through additional annotation-driven actions

RDF Graph functionality

The code that creates rdfs:labels based on oastype should be isolated and made easy to extend and/or override; it is one of the few places where understanding of the OAS structure appears in code, and therefore needs to be kept clearly separate from the generic code
The annotation processing patterns, particularly around RJP Templates, can probably be condensed further.  There may be a boundary to draw between annotation processing and graph construction that is not currently in the right place (see also the "framework for driving actions through annotations" comment in the previous section)
The toml serialization should go in its own module; decide how aware of OAS it should be
Need to figure out what, if any, graph construction should be handled by RDFS/OWL inferencing

more tbd...

Some updates:

A lot of what was in oascomply.apidescription and oascomply.oas30dialect is being moved into a more comprehensive set of jschon extensions in a new oascomply.oasjson
oas30dialect is now just the dialect/vocabulary/keyword support
Much of the rest of oascomply.apidescription will move into an oascomply.cli library containing code that is not needed if using oascomply as a library
oascomply.apidescription will probably be just the basic flow control for carrying out the parsing/vaidating/linting process, including registering and running extensions
I'm probably not going to do too much more with the URI/IRI/JSONPointer things, as they work well enough and are separate enough to be easily improved later
I'm still not sure what to do about type hints - I like them on interfaces, but getting the tools to be useful seems like a time sink perhaps best deferred for a future contributor who knows more about them
Error handling improvement still needs to be done.

The above code organization changes are making the code a lot more testable and readable.


Cow: Watch novelvox.com

Cow requests the watch of the watch_keyword novelvox\.com. See the MS search here and the Stack Exchange search in text, in URLs, and in code.

novelvox\.com has been seen in 1 true positive, 0 false positives, and 0 NAAs.

Approved by Jeff Schaller in Charcoal HQ