Site with an own theme

Connected to #6. Not probably ready for merge, but I'm happy to receive feedback. It's very simple and bare bones, but hey, at least it has Lokki logo ;) Live demo is at http://kauhsa.github.io/lokki.
Small checklist of things I want to do within this PR:

[x] Fix header on mobile devices
Use SASS version of Bootstrap and make changes to font-family etc. by overriding Bootstrap variables (not sure if feasible with GitHub Pages) Scratch this, I don't think we can't have the convinient stuff that helps us to do it easily with Jekyll with GH Pages and without them it's probably a pain

Looks great. Is there any interest in making a web app front end in the future?

Ok, changed looks a bit and it looks a bit better on mobile.


I have problems with Instagram guys

Great library, everything works, but there are problems with site rights...
How to use scraper without getting blocked? I’ll buy secret information?)

You scrape with accounts or without?
What issue do you have?


UD Browser show hash rather than domain address

Bug...
Just been asked why the browser resolves the homepage under the domain name, but if you change to a different page it shows the https://cloudflare... link. He was asking if it's possible to make the additional pages read as yourdomain.crypto/page2 for example?

@incryptin Thanks for reporting, but this is the websites repo not the browser repo. Please add your issue to the browser repo


⚡ Improved Backend Error Message

PR Summary

📝 Better Error Messages for Backend: Enjoy clearer and more professional error messages, helping you debug with ease!

Types of Changes
What types of changes does your code introduce to this project? Please mark with
an x the applicable boxes.

[ ] Bugfix (non-breaking change that addresses an issue)

[x] New feature (non-breaking change that adds functionality)

[ ] Breaking change (fix or feature that may cause existing functionality to
break)

[ ] Documentation update

[x] Refactoring (code optimization or restructuring)

[ ] Other (please specify): __________

Testing and Publishing
Please indicate the status of the following:

[x] These changes have been thoroughly tested.

[x] Code is properly formatted using command deno fmt

Thanks for the review 😄


Errno 113: No route to host

I've followed the guide here and managed to get Mosquitto setup and functioning. I've installed the Frigate addon but cannot seem to get it to start correctly.
Frigate Log

Frigate.yml

Looks like your mqtt host is wrong.

Correct you are. I had manually misconfigured mqtt in hassos. Thanks for the help and sorry for the inaccurate issue.


Staging changes

Type: Bug
I created a new react-native project and set up some basic folder/file structures and npm i nativewind and tailwindcss and then I used npx tailwindcss init and now whenever I try and git add . then git commit -m"message" it says that the changes aren't committed
VS Code version: Code 1.84.1 (2b35e1e6d88f1ce073683991d1eff5284a32690f, 2023-11-06T12:35:59.022Z)
OS version: Windows_NT x64 10.0.19045
Modes:

System Info

Item
Value

CPUs
Intel(R) Core(TM) i7-7500U CPU @ 2.70GHz (4 x 2904)

GPU Status
2d_canvas: enabledcanvas_oop_rasterization: enabled_ondirect_rendering_display_compositor: disabled_off_okgpu_compositing: enabledmultiple_raster_threads: enabled_onopengl: enabled_onrasterization: enabledraw_draw: disabled_off_okvideo_decode: enabledvideo_encode: enabledvulkan: disabled_offwebgl: enabledwebgl2: enabledwebgpu: enabled

Load (avg)
undefined

Memory (System)
15.88GB (7.64GB free)

Process Argv
--crash-reporter-id 19a4decf-f40f-46a7-acdd-706b76653f89

Screen Reader
no

VM
0%

Extensions (27)

Extension
Author (truncated)
Version

npm-intellisense
chr
1.4.5

path-intellisense
chr
2.8.5

dscodegpt
Dan
2.2.1

vscode-eslint
dba
2.4.2

es7-react-js-snippets
dsz
4.4.3

vscode-npm-script
eg2
0.3.29

fira-code-nerd-font
ent
0.0.3

vscode-graphql-syntax
Gra
1.2.2

search-node-modules
jas
1.3.0

vscode-codemetrics
kis
1.26.1

vscode-azurefunctions
ms-
1.13.1

vscode-azureresourcegroups
ms-
0.7.5

azure-account
ms-
0.11.6

vsliveshare
ms-
1.0.5892

vscode-react-native
msj
1.12.1

vscode-for-node-js-development-pack
nod
2.0.1

material-icon-theme
PKi
4.31.0

vscode-rapidapi-client
Rap
1.10.2

vscode-services
rap
1.0.2

LiveServer
rit
5.7.9

es7-react-js-snippets
rod
1.9.3

code-settings-sync
Sha
3.4.3

vscode-zipexplorer
sle
0.3.1

open-in-browser
tec
2.0.0

nodejs-extension-pack
wad
0.1.9

vscode-import-cost
wix
3.3.0

JavaScriptSnippets
xab
1.8.0

(1 theme extensions excluded)

A/B Experiments
vsliv368cf:30146710
vsreu685:30147344
python383:30185418
vspor879:30202332
vspor708:30202333
vspor363:30204092
vswsl492cf:30256860
vslsvsres303:30308271
vserr242:30382549
pythontb:30283811
vsjup518:30340749
pythonptprofiler:30281270
vshan820:30294714
vstes263:30335439
vscoreces:30445986
vscod805cf:30301675
binariesv615:30325510
bridge0708:30335490
bridge0723:30353136
vsaa593:30376534
pythonvs932:30410667
py29gd2263:30880072
38873714:30881509
vsclangdf:30486550
c4g48928:30535728
dsvsc012:30540252
pynewext54:30695312
azure-dev_surveyone:30548225
3biah626:30602489
f6dab269:30613381
a9j8j154:30646983
showlangstatbar:30737416
pythonfmttext:30731395
fixshowwlkth:30771522
showindicator:30805244
pythongtdpath:30769146
i26e3531:30792625
welcomedialog:30882109
pythonnosmt12:30797651
pythonidxpt:30866567
pythonnoceb:30805159
synctok:30869157
dsvsc013:30795093
dsvsc014:30804076
dsvsc015:30845448
pythontestfixt:30871694
pythonregdiag2:30871582
pythonmypyd1:30879173
pythoncet00cf:30874137
pythontbext0:30879054
dsvsc016cf:30880770
aa_t_chat:30882232

/gifPlease

Thanks for reporting this issue! Unfortunately, it's hard for us to understand what issue you're seeing. Please help us out by providing a screen recording showing exactly what isn't working as expected. While we can work with most standard formats, .gif files are preferred as they are displayed inline on GitHub. You may find https://gifcap.dev helpful as a browser-based gif recording tool.
If the issue depends on keyboard input, you can help us by enabling screencast mode for the recording (Developer: Toggle Screencast Mode in the command palette). Lastly, please attach this file via the GitHub web interface as emailed responses will strip files out from the issue.
Happy coding!

Is it possible to get more people to help me on this issue?

@lszomoru

@lwalker107, thanks for the recording. One thing that I have observed in the recording is that: 1) the Commit button is disabled, 2) there is a continuous progress bar in the Source Control view, and 3) there is a COMMIT_EDITMSG file opened (second tab from the right).
What I suspect is happening here, is that you clicked the Commit button without entering a commit message. This flow is described here. You can disable this flow by toggling the git.useEditorAsCommitInput setting.
Can you try the following to get yourself unblocked:

Close the COMMIT_EDITMSG tab
Reload VS Code
Enter a commit message
Click on the Commit button

This issue has been closed automatically because it needs more information and has not had recent activity. See also our issue reporting guidelines.
Happy Coding!


🐞 Tabs animate incorrectly

Description
Currently the tab and tab content animates in the wrong way.
What currently happens
When new file is opened, the new tab itself fades in while sliding in a few pixels from the left (this is expected)
When tab is closed, the tab fades out in place and the tab content fades out (both are not expected)
What should happen
The only animation that should take place is when a new tab is opened, the tab itself fades in while sliding a little to the right as it does now. All animations on tab closed should be removed.
Screenshots
https://user-images.githubusercontent.com/806104/220394988-d3d6e736-14b5-49f6-902b-7cb34e030900.mp4

Can this be closed? Is this addressed by #1081 ?

I just tested again and noticed there is one thing that is still incorrect. When closing a tab, the background of the new active tab fades in. We need to fix this before we can close this.
https://user-images.githubusercontent.com/806104/222829987-ef23bc31-3d5e-40dc-999f-6e44bee6e2ed.mp4
Notice the background of the newly active tab fading in.

@maxkel would you be able to take a look at this?

Yes, I will look into this.
I have just one more question. If you close a tab with other tabs to the right. The behavior that the tabs to the right adjust their position with an animation like shown in the video below is intended, right?
https://user-images.githubusercontent.com/46418077/222920063-3cf69980-7d6c-4140-b807-9c9f1eeabc61.mov

@maxkel Correct, we want to keep that animation of the tabs to the right animating their position, but we don't want the closed tab to fade out and we don't want the background of the newly selected tab to fade in.


(book) Update the graphql_scalar! example to be generic

This is now basically a requirement due to GraphQLObject derive
being generic.
Closes #358.

Codecov Report

Merging #359 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #359   +/-   ##
=======================================
  Coverage   86.16%   86.16%
=======================================
  Files         106      106
  Lines       15599    15599
=======================================
  Hits        13441    13441
  Misses       2158     2158

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 43fcc63...0c70a6b. Read the comment docs.


Controlplane and windows binaries download

Fixes: https://github.com/kubernetes-sigs/sig-windows-dev-tools/issues/147
Refactoring to simplify the process of downloading the binaries in the environment, right now it ONLY support the latest of each minor version, so for example, settings kubernetes_version on variables.yaml X will give Y:
1.24 - v1.24.0-alpha.1.646+8a259641532d12 (still not release)
1.23 - v1.23.2-rc.0.56+3426f6ceaf92ad (latest release)
1.22 - v1.22.6-rc.0.55+487eef699dc8ad
1.21 - v1.21.9-rc.0.55+80b625cdfb1b5a

A kubernetes SHA has is not available, this way we can guarantee that node binaries versions are the same as the API components.
Guessing the version from SHA can be troublesome and give a mismatch version from API components. Forcing the user to change on different places.
The variables.yaml was simplified, and a flag download the binaries or build from source, checking the downloaded repository with the hash of the latest patch version of the minor set.
# Kubernetes version, pick major and minor, patch will be the latest released.
kubernetes_version: "1.24"

# if this options is used BINARIES will be downloaded instead of building from zero
build_from_source: "false"

## Linux settings
k8s_linux_kubelet_nodeip: "<IP_ADDRESS>"
linux_ram: 4096
linux_cpus: 4

## Windows settings
windows_node_ip: "<IP_ADDRESS>"
windows_ram: 6048
windows_cpus: 4

## CHOOSE YOUR CNI ($)
# cni: "calico" || "antrea"
cni: "antrea"

with 1.22
vagrant@controlplane:~$ kubectl get nodes -o wide
NAME           STATUS   ROLES                  AGE   VERSION                          INTERNAL-IP   EXTERNAL-IP   OS-IMAGE                                  KERNEL-VERSION     CONTAINER-RUNTIME
controlplane   Ready    control-plane,master   27m   v1.22.6-rc.0.55+487eef699dc8ad   <IP_ADDRESS>   <none>        Ubuntu 20.04.3 LTS                        5.4.0-81-generic   containerd://1.5.5
winw1          Ready    <none>                 19m   v1.22.6-rc.0.55+487eef699dc8ad   <IP_ADDRESS>   <none>        Windows Server 2019 Standard Evaluation   10.0.17763.737     containerd://1.5.5

/lgtm
/approve


Check if the syntax variable is not "falsey"

Closes #532.
As of at least build 3200 of Sublime Text, the get method of the sublime.Settings object may apparently randomly return 0 instead of None.
I don't personally experience this error, so it is hard for me to see if this helps. Ping @kerma, @evandrocoan.

Coverage increased (+0.02%) to 26.789% when pulling be181903fbe1a423efb09b875b70f2af3a4910fa on bugfix/less-strict-syntax-is-none-check into 977beeea9c38dd69859986a4f3d262161a92f010 on master.

I would wait until I figure out how to reproduce it.


Move to react-router-redux

Thanks for putting this starter app together for this killer stack. I see that redux-router's page recommends using react-router-redux for a more stable redux router.  Any plans to convert this 3ree app to use that?
I started working on it myself, but was stuck on the server-side routing wire-up on the server side. Some suggestions here.

+1

Yea. It's been on my to-do list and I have free time now so I'll take a look into it shortly.

Great, thanks @GordyD. I just got it working today, and my server and client code is below.  I'm still climbing the learning curve on the tech in this stack so you can probably improve.  Plus I've modified some of the original code to play around with it.
# server/app.js
import React from 'react';
import ReactDOMServer from 'react-dom/server';
import thunkMiddleware from 'redux-thunk';
import { createStore, compose, combineReducers, applyMiddleware } from 'redux';
import { Provider } from 'react-redux';

import * as eventService from './api/service/event';
import * as itemService from './api/service/item';

import myApp from '../universal/reducers';
import routes from '../universal/routes';

import { Router, Route, match, RouterContext } from 'react-router';
import { routeReducer, syncHistory } from 'react-router-redux'
import createMemoryHistory from 'history/lib/createMemoryHistory';

import Promise from 'bluebird';

export function handleRender(req, res) {
  Promise.join(
    itemService.getItems(),
    eventService.getEvents(),
    function (initialItems, initialEvents) {
      var initialState = {
        myApp: {
          userId: 'baseUser',
          events: initialEvents,
          items: initialItems
        }
      };

      const reducer = combineReducers({
        routing: routeReducer,
        myApp
      });

      const history = createMemoryHistory();
      const historyMiddleware = syncHistory(history);

      // Create a new Redux store instance
      const store = compose(
        applyMiddleware(thunkMiddleware),
        applyMiddleware(historyMiddleware),
      )(createStore)(reducer, initialState);

      // Wire up routing based upon routes
      store.dispatch(match(
        { routes: routes, location: req.originalUrl, history: history },
        (error, redirectLocation, renderProps) => {

        if (error)  {
          console.log('Error', error);
          res.status(400);
          res.send(error);
          return;
        }

        if (redirectLocation) {
          res.redirect(redirectLocation);
          return;
        }

        // Render the component to a string
        const html = ReactDOMServer.renderToString(

            <Provider store={store}>
              <RouterContext {...renderProps} />
            </Provider>

        );

        // Send the rendered page back to the client with the initial state
        res.render('index', { html: html, initialState: JSON.stringify(store.getState()) });
      }));

    }
  );
}

# client/app.js
import ReactDOM from 'react-dom';
import React from 'react';

import { createStore, applyMiddleware, compose, combineReducers } from 'redux';
import thunkMiddleware from 'redux-thunk';
import createLogger from 'redux-logger';
import { Provider } from 'react-redux';

import { Router, Route, browserHistory  } from 'react-router';
import { syncHistory, routeReducer } from 'react-router-redux'

import { getOrSetUserId } from './UserId';
import { setupRealtime } from './Realtime';

import DevTools from '../universal/containers/DevTools';

import routes from '../universal/routes';
import myApp from '../universal/reducers';
import * as actions from '../universal/actions/PulseActions';

import '../style/pure.css';
import '../style/main.css';
import '../style/spinner.css';

// Grab the state from a global injected into server-generated HTML
let initialState = window.__INITIAL_STATE__;

const loggerMiddleware = createLogger({
  level: 'info',
  collapsed: true,
});

const reducer = combineReducers({
  routing: routeReducer,
  myApp
});

const reduxRouterMiddleware = syncHistory(browserHistory);

// Create a new Redux store instance
const store = compose(
  applyMiddleware(thunkMiddleware, loggerMiddleware),
  applyMiddleware(reduxRouterMiddleware),
  DevTools.instrument()
)(createStore)(reducer, initialState);

ReactDOM.render(

    <Provider store={store}>
      <Router history={browserHistory}>
        {routes}
      </Router>
    </Provider>

,
  document.getElementById('app')
);

// Now that we have rendered...
setupRealtime(store, actions);

// lets mutate state and set UserID as key from local storage
store.dispatch(actions.setUserId(getOrSetUserId()));

Oh nice. I've just created a PR here with the changes that follow a similar approach in addition to some other simplifications to improve readability of code and conform to redux standard approaches.

I also added in DevTools too ;)

Sounds great, I do have an error related to DevTools in that code FYI, but it seems benign.
Glad you're able to spend time on this project; I can see 3ree as my choice stack going forward.
Side note, I wish there was an easy way to merge in your changes to my own project.  Easy, as in updating an npm package easy :). Prob means building a framework around it in some fashion.

It's been merged in.
What is the error?
As for an easy way to merge in  or update your codebase with 3ree - that is certainly food for thought. I'll think about potential paths for this to be possible.
Thanks your support on this task!

@GordyD @snobear I was able to run this PR (Prior to Merge) and no errors related to DevTools and all worked as expected. @GordyD thank you for jumping in on this so fast!

Sorry, to clarify on my comment:

Sounds great, I do have an error related to DevTools in that code FYI, but it seems benign.

I was referring to the code I had posted, and not your PR at the time.

@snobear I do see a benign error related to DevTools now that I inspected after running npm start and posted it in the issues... do you see the same thing?


Audit for arith_offset intrinsic

Description of changes:
This PR adds support for the arith_offset intrinsic (used by wrapping_offset) by using the already-implemented codegen_offset function.
The documentation for wrapping_offset defines it as a more permissive version of offset which allows the computed offset to go out-of-bounds. Currently, we don't check in codegen_offset that the computed offset is within bounds to avoid spurious failures, so its definition should work for both.
Resolved issues:
Part of #1163
Call-outs:

Testing:

How is this change tested? Adds 6 tests.

Is this a refactor change? No.

Checklist

[x] Each commit message has a non-empty body, explaining why the change was made
[x] Methods or procedures are documented
[x] Regression or unit tests are included, or existing tests cover the modified code
[x] My PR is restricted to a single feature or bugfix

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.

Thanks @tedinski , you're right that we should be tracking this.
I created #1233 and extended the comment to both link that issue and clarify that it's only concerning offset. If we had to add that check at some point, it would be enough to add a flag to check for this property in codegen_offset.


Update dependencies

Please, update dependencies (openapi-spec-validator) https://github.com/manchenkoff/openapi3-parser/blob/master/Pipfile#L14
OpenAPI file may contain required list of names of properties, which do not exists in properties list...
openapi-spec-validator-0.4.0 -> error
openapi-spec-validator-0.5.5 -> OK
Your tool require < 0.5 version of openapi-spec-validator
P.S. Also IMHO it's a good idea to replace Pipfile* to pyproject.toml (use poetry)
Related issue: https://github.com/getlago/lago-openapi/issues/22

Bumped to openapi-spec-validator-0.5.5


Add PowerShell friendly CLI

ITNOA
Description of the new feature/enhancement
As you can know PowerShell is great Scripting Language for Automation and Administration of system. and it is built for Object-oriented scripting.
Kubernetes API, on the other hand, is also completely object-oriented, so I think it is very good for kubectl to get compatible with PowerShell and make native PowerShell Cmdlet.
In this area we can see below command instead of Linux legacy CLI style like kubectl get node

Get-Node

And all of them is object and we can work with them in OOP area with modern and great and consistent experience in PowerShell World.
Proposed technical implementation details (optional)
I think PowerShell has many guideline and documentation about writing and designing great Cmdlet and modules that winget-cli teams have to follow it for example
Windows PowerShell Cmdlet Concepts
Writing a Windows PowerShell Module
PowerShell Script Module Design: Building Tools to Automate the Process
Powershell: DSL design patterns
VMWare PowerCLI is an example for similar large scale software that use PowerShell for CLI.

All of the autocomplete functionality (and cli bits) for kubectl is provided through the Go library Cobra.
It doesn't look like this is something Cobra provides yet https://github.com/spf13/cobra/blob/master/shell_completions.md#powershell-completions - or would it need to be separate entirely?
QOL improvements for Powershell users are certainly something we'd consider merging if a PR surfaced.
Might be worth tagging @JamesWTruher.
cc @marckhouzam

IIUC this is something different than command completion.  I'm not very familiar with PowerShell but it may be an improvement than could possibly be generic enough to be done on Cobra so that it would be available to many clis.  Having something working in kubectl or another project would be a good proof that such a feature works well.
Someone would need to step up and do the work however.

@eddiezane It is very beyond than just auto complete, it is about new culture of CLI.

Thanks for explaining!
I'd recommend opening this in Cobra if you want to get the ball rolling.
/close


Added contributor page on the website

##Description
Added contributor page on the webiste.
##Issue code
#205
##Changes
#Added contributor page
##Added profile and profile link
Screenshot/video
https://github.com/Vikash-8090-Yadav/SaL--dApp/assets/83147410/4fb48d23-474a-4e8b-963d-e9bd837da003

Hey please cnfrm it's dynamic or not ?

@Vikash-8090-Yadav  yes it is dynamic


Clarify ingress helm install hint

Description
Added guidance for adding the correct helm chart repository. This is a follow up PR for closed #275.
Issue reference
We strive to have all PRs being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #274
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list:

[N.A.] The quickstart code compiles correctly
[X] You've tested new builds of the quickstart if you changed quickstart code
[X] You've updated the quickstart's README if necessary

Hi @pruthvidhodda ,
as promised reopened PR.
Just realized that my vscode markdown auto fix did some additional changes, should I revert them back or can we keep them?

Thanks for opening a new PR.

Just realized that my vscode markdown auto fix did some additional changes, should I revert them back or can we keep them?

It's okay, we can keep them


Generate-Pch leaves copied  Pch as read only and can't be recreated

Hi,
I can't reproduce the conditions in which this has began to happen but suddenly the generated PCH has its  permissions to write only after being generated. I have modified Copy-Item in Generate-Pch with -Force to avoid this problem but the cause is still unknown

Hello @webez,
Can you provide more information on this issue? We've unable to reproduce it. Consider enabling "Verbose mode" and check the detailed log.

Hi,
I am sorry for the lack of information related with this problem. I myself was unabale to reproduce it consistently and the "Verbose mode" does not give any hint about it (I have used it a lot to find the other problem with great results).
That's why as a precaution I have added -Force to Copy-Item

I've hit this problem as well on 7.2.0 and believe I have a repro.
Perforce keeps files as read-only until they are checked out for modification so the majority of code files are in a read-only state. When it copies a read-only stdafx.h to stdafx.h.hpp, the new file is also read-only.
In my case, the PCH has errors so it failed to compile and ended with:
4 errors generated.
Skipping project. Reason: cannot create PCH.

The read-only stdafx.h.hpp was not deleted. Next time I run tidy, it shows:
Copy-Item : Access to the path 'C:\stuff\stdafx.h.hpp' is denied.

That could be, because I am also using Perforce

@bjehlert Thank you for the additional information, it was very helpful. We are currently working on a fix for the issue.

Pleased to inform you that Clang Power Tools 7.2.1, just released, has fixed this issue.
Thank you for providing us with the feedback required.


Missing Chat.csproJ

Please provide us with the following information:

This issue is for a: (mark with an x)
- [ ] bug report -> please search issues before submitting
- [ ] feature request
- [x ] documentation issue or request
- [ ] regression (a behavior that used to work and stopped in a new release)

Minimal steps to reproduce

cloned repository using Visual studios and followed steps in https://docs.microsoft.com/en-us/azure/communication-services/samples/chat-hero-sample till I got to step asking to open Chat.csproj.

Any log messages given by the failure

None

Expected/desired behavior

Chat.csproj should be in the chat folder, but it is not there

OS and Version?

Windows 7, 8 or 10. Linux (which distribution). macOS (Yosemite? El Capitan? Sierra?)

Versions

Mention any other details that might be useful

Thanks! We'll be in touch soon.

Did anyone resolve issue with misssing Chat.csproj file

Someone had reached out to me and noticed me of what happened to the code thank your for fallowing up.
Get Outlook for iOShttps://aka.ms/o0ukef

From: Itai @.>
Sent: Wednesday, April 6, 2022 2:30:29 PM
To: Azure-Samples/communication-services-web-chat-hero @.>
Cc: Kirchner, Wilfried (kirchnwi) @.>; Author @.>
Subject: Re: [Azure-Samples/communication-services-web-chat-hero] Missing Chat.csproJ (Issue #41)
Did anyone resolve issue with misssing Chat.csproj file
—
Reply to this email directly, view it on GitHubhttps://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FAzure-Samples%2Fcommunication-services-web-chat-hero%2Fissues%2F41%23issuecomment-1090596626&data=04|01|kirchnwi%40mail.uc.edu|abc98032b164495b51bd08da17fb8743|f5222e6c5fc648eb8f0373db18203b63|1|0|637848666331128674|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000&sdata=tGFEO%2Ft7mA50S2aM09p1v7ZvF%2BW2hDnkFAe4LzFQrj4%3D&reserved=0, or unsubscribehttps://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAV5KIVT4R2KXZ26JJTRTFXDVDXJ4LANCNFSM5PPI7TCQ&data=04|01|kirchnwi%40mail.uc.edu|abc98032b164495b51bd08da17fb8743|f5222e6c5fc648eb8f0373db18203b63|1|0|637848666331128674|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000&sdata=j5R6qwKX9s4OHQFcpR8tE442TalUmQ1uGPKGyDpgkrI%3D&reserved=0.
You are receiving this because you authored the thread.Message ID: @.***>

@PorterNan This is still an issue, the documentation at https://docs.microsoft.com/en-us/azure/communication-services/samples/chat-hero-sample is stale as it still refers to Chat.csproj.

@itaimanyati The .csproj file is no longer needed anymore since we are using purely typescript+nodejs. you can run the sample following these steps - https://github.com/Azure-Samples/communication-services-web-chat-hero#local-run
Visual Studio Code is one of the recommended IDEs to run our project, while you can still use Visual Studio to edit our code and run those commands above to get our project running

@itaimanyati The .csproj file is no longer needed anymore since we are using purely typescript+nodejs. you can run the sample following these steps - https://github.com/Azure-Samples/communication-services-web-chat-hero#local-run
Visual Studio Code is one of the recommended IDEs to run our project, while you can still use Visual Studio to edit our code and run those commands above to get our project running

Thank you @PorterNan . I am still required to use C# on the project that I am working. Anyone with a workaround on this

@itaimanyati  I was wondering if you could share more about your scenario?
In the past we had built this sample using c# as a backend and using typescript/js/react in the front-end. Since the UI Library is geared to help the front-end visual needs of a communications experience we decided to simplify our overall sample by using one language (typescript) across the frontend AND backend.
If you can share more about what you need from c# we can look into further supporting your needs.

Closing this issue due to inactivity


Don't inline functions with the "use strict" directive.

Discovered during resolution of pull request #2279
This is really a separate bug, but its interaction with that change caused a known failure, forcing us to roll it back temporarily.

So is this just don't inline functions with the use strict directive who's parent scope isn't also use strict?

Why the parent scope? I'd think it would be "don't inline a strict function into a non-strict scope".

We could specifically try to determine whether the enclosing scope is non-strict, but is it worth doing that?
It adds complication to the logic which could be a source of bugs for very little benefit, since functions with an explicit "use strict" are rare.
Am I wrong in thinking that they are rare?

@concavelenz says we never output the "use strict" in functions anyway, so this really shouldn't be a problem.
Preventing inlining would have fixed the failure I'm encountering related to PR #2279, but it seems it's not the right solution.


Braking change introduced by minor version 0.3.13

https://docs.rs/socket2/0.3.12/socket2/struct.Domain.html
https://docs.rs/socket2/0.3.13/socket2/struct.Domain.html
functions missing
socket2::Domain::ipv4()
socket2::Domain::ipv6()

There are also breaking changes on
https://docs.rs/socket2/0.3.12/socket2/struct.Protocol.html
https://docs.rs/socket2/0.3.12/socket2/struct.Type.html

Getting all these building actix:
error[E0599]: no function or associated item named `ipv4` found for struct `socket2::Domain` in the current scope
   --> /Users/joshuakoudys/.cargo/registry/src/github.com-1ecc6299db9ec823/actix-server-1.0.3/src/builder.rs:491:43
    |
491 |         net::SocketAddr::V4(_) => Domain::ipv4(),
    |                                           ^^^^ function or associated item not found in `socket2::Domain`

error[E0599]: no function or associated item named `ipv6` found for struct `socket2::Domain` in the current scope
   --> /Users/joshuakoudys/.cargo/registry/src/github.com-1ecc6299db9ec823/actix-server-1.0.3/src/builder.rs:492:43
    |
492 |         net::SocketAddr::V6(_) => Domain::ipv6(),
    |                                           ^^^^ function or associated item not found in `socket2::Domain`

error[E0599]: no function or associated item named `stream` found for struct `socket2::Type` in the current scope
   --> /Users/joshuakoudys/.cargo/registry/src/github.com-1ecc6299db9ec823/actix-server-1.0.3/src/builder.rs:494:44
    |
494 |     let socket = Socket::new(domain, Type::stream(), Some(Protocol::tcp()))?;
    |                                            ^^^^^^ function or associated item not found in `socket2::Type`

error[E0599]: no function or associated item named `tcp` found for struct `socket2::Protocol` in the current scope
   --> /Users/joshuakoudys/.cargo/registry/src/github.com-1ecc6299db9ec823/actix-server-1.0.3/src/builder.rs:494:69
    |
494 |     let socket = Socket::new(domain, Type::stream(), Some(Protocol::tcp()))?;
    |                                                                     ^^^ function or associated item not found in `socket2::Protocol`

error: aborting due to 4 previous errors

@stjepang there are still breaking changes on
docs.rs/socket2/0.3.12/socket2/struct.Protocol.html
docs.rs/socket2/0.3.12/socket2/struct.Type.html
that were not fixed in #96


pytest plugin to allow simple CI for datasets on github

A very lightweight pytest plugin could make CI for datasets on github as simple as adding a .travis.yml like
language: python
python: "3.6"
cache: pip
before_cache: rm -f $HOME/.cache/pip/log/debug.log
install: pip install pycldf pytest
script: pytest --cldf-metadata=PATH/TO/METADATA.json test.py

and a test.py like
def test_valid(cldf_dataset):
    assert cldf_dataset.validate()

I ended up putting this into a separate (minimal) python package - https://github.com/cldf/pytest-cldf
The first example is zgraggenmadang, with .travis.yml and test.py.
While this may still seem overly complex (cldf validate ... could be called directly from .travis.yml without any python code run by pytest, after all), I think it's worth it, because additional validators can be easily passed into Dataset.validate to provide extended validation.


Enable combining data from multiple sources (i.e. cases from one, tested from another)

As pointed out in #386 we currently use a single source with a fallback on another one if needed.
But different sources may provide different data for the same region or even different quality of data over time.
It'd be great to be able to have something like:
{
  "region": "WA, USA",
  "sources": {
    "sourceA": {},
    "sourceB": {},
    "datasets": {
      "cases": [{"from": null, "to": null, "order": ["sourceA", "sourceB"]}],
      "testing": [{"from": null, "to": null, "order": ["sourceB"]}],
      "recovered": [
        {
          "from": null,
          "to": "2020-3-11",
          "order": ["sourceA"]
        },
        {
          "from": "2020-3-12",
          "to": null,
          "order": ["sourceB"]
        }
      ]
    }
  }
}

We already can use different sources for different time ranges, generally when we add a new source, it only starts at the date we added it (unless it's a timeseries).

@lazd any update on this one?

@zbraniecki unfortunately no, this isn't something we've looked at yet. We should take a look at doing this in the new architecture here https://github.com/covidatlas/li

This is implemented in Li.  I didn't see this issue and so didn't implement it per the above spec, but the reporting is clear (at least to me!), and we can easily determine the provenance of data.  See, eg, https://github.com/covidatlas/li/blob/master/docs/reports.md#combining-data-sources.  I'm closing this issue, but if you see any obvious improvements we can make to the Li reports let me know, or submit a PR.  Cheers! jz


scale bar title text formatting

Hi again,
I've got a quick question this time on formatting the scalabar title text. I know that there is titleFontSize argument, but it seems to only modify the font size of the scale as you can see in the attachment. Any idea as to what I might be missing and how I could change the font size of the title text and may be make it bold ?
Thank you again for this wonderful library !
from vtkplotter import Sphere
s = Sphere().addElevationScalars(lowPoint=(0,0,0), highPoint=(1,1,1))
s.addScalarBar(title='Test Title',titleFontSize=30).show(axes=1)

thanks for spotting the bug :) it will be fixed in the next release.
meanwhile you can use this hack:
from vtkplotter import *

s = Sphere().addElevationScalars(lowPoint=(0,0,0), highPoint=(1,1,1))
s.addScalarBar(title='Test Title', titleFontSize=15)

vp = show(s, axes=1, interactive=False)
vp.scalarbars[0].GetTitleTextProperty().SetFontSize(20)
show(interactive=True)

Thanks a lot for the hack ! didn't know it was a bug though !
All the best !!


doesn't work after migrating androidx

Don't know why, but my project stop working and needed to migrate to androidX. After doing that, I've never get react-native-contacts library work again. I get some errors when compiling about annotations, so I modified in ContactManager.java, ContactsProvider.java and ReacNativeContacts.java the following lines:
//import android.support.annotation.NonNull;
//import android.support.v4.app.ActivityCompat;
import androidx.annotation.NonNull;
import androidx.core.app.ActivityCompat;
After doing that, the project build succesfully again. The problem is that now the library doesn't work anymore.
I am having a warning and the contacts aren't shown anymore. By the way, I accepted permissions like always.
The warning says:
..\node_modules\react-native\Libraries\ReactNative\YellowBox.js:82 Possible Unhandled Promise Rejection (id: 0):
ReferenceError: Contacts is not defined
ReferenceError: Contacts is not defined
at ContactList.loadContacts (blob:http://localhost:8081/953d4653-098a-4666-8732-a1f273a5e2bd:148459:11)
at ContactList.proxiedMethod (blob:http://localhost:8081/953d4653-098a-4666-8732-a1f273a5e2bd:34873:32)
at blob:http://localhost:8081/953d4653-098a-4666-8732-a1f273a5e2bd:148442:22
at tryCallOne (blob:http://localhost:8081/953d4653-098a-4666-8732-a1f273a5e2bd:13487:14)
at blob:http://localhost:8081/953d4653-098a-4666-8732-a1f273a5e2bd:13588:17
at blob:http://localhost:8081/953d4653-098a-4666-8732-a1f273a5e2bd:14908:21
at _callTimer (blob:http://localhost:8081/953d4653-098a-4666-8732-a1f273a5e2bd:14797:9)
at _callImmediatesPass (blob:http://localhost:8081/953d4653-098a-4666-8732-a1f273a5e2bd:14833:9)
at Object.callImmediates (blob:http://localhost:8081/953d4653-098a-4666-8732-a1f273a5e2bd:15052:14)
at MessageQueue.__callImmediates (blob:http://localhost:8081/953d4653-098a-4666-8732-a1f273a5e2bd:2339:18)
Do you have any idea how can I fix this??
Thanks in advance for your help
Regards
Juan Pablo Ochoa

please follow https://medium.com/@yathousen/the-day-google-decided-to-shake-the-react-native-community-4ba5cdd33388 and report back

Thanks a lot @morenoh149 . I followed all the steps and compiles fine. But I am still having the same error with contacts library
..\node_modules\react-native\Libraries\ReactNative\YellowBox.js:82 Possible Unhandled Promise Rejection (id: 0):
ReferenceError: Contacts is not defined
ReferenceError: Contacts is not defined
at ContactList.loadContacts (blob:http://localhost:8081/953d4653-098a-4666-8732-a1f273a5e2bd:148459:11)
at ContactList.proxiedMethod (blob:http://localhost:8081/953d4653-098a-4666-8732-a1f273a5e2bd:34873:32)
at blob:http://localhost:8081/953d4653-098a-4666-8732-a1f273a5e2bd:148442:22
at tryCallOne (blob:http://localhost:8081/953d4653-098a-4666-8732-a1f273a5e2bd:13487:14)
at blob:http://localhost:8081/953d4653-098a-4666-8732-a1f273a5e2bd:13588:17
at blob:http://localhost:8081/953d4653-098a-4666-8732-a1f273a5e2bd:14908:21
at _callTimer (blob:http://localhost:8081/953d4653-098a-4666-8732-a1f273a5e2bd:14797:9)
at _callImmediatesPass (blob:http://localhost:8081/953d4653-098a-4666-8732-a1f273a5e2bd:14833:9)
at Object.callImmediates (blob:http://localhost:8081/953d4653-098a-4666-8732-a1f273a5e2bd:15052:14)
at MessageQueue.__callImmediates (blob:http://localhost:8081/953d4653-098a-4666-8732-a1f273a5e2bd:2339:18)
any other suggestion?
thanks in advance for your help.

Any ideas here?

@elie222 what do you mean? As far as I can tell this project has been updated to androidx and this issue should actually be closed. Please share your error in a new issue. Upgrade to androidx was done in https://github.com/rt2zz/react-native-contacts/pull/398


Add ORAS Support

The Gatecheck Bundle could be uploaded with ORAS to any OCI Container registry using the export command.
https://oras.land/
Proposed syntax
gatecheck export registry <IMAGE>:<TAG> <FILE>

Handling Authentication
Will probably need an option to pass a registry config --registry-config <FILE>
An option to do insecure to skip SSL
--insecure
--registry-user
--registry-password
--registry-password-stdin

Out of scope


Client crashes on Android 13

Device: Redmi Note 10 Pro
OS: 20-20230929-NIGHTLY-sweet
Client starts normally, but crashes immediately without throwing any error as soon as I toggle the tunnel on. No logs are saved even if enabled.

Also have this problem on Nokia G50 updated to Adnroid 13


Websocket implementation

Fixed a few more things in both repos. If all good, I can merge em @omangbaheti


RemoteSSHCommand

Hi
"RemoteSSHForMasterFailover": true,
"RemoteSSHCommand": "ssh {hostname}",
"RemoteSSHCommandUseSudo": true,
These three parameters are in the case of delay from the library, will copy the delayed binlog to the new main library for import, can you elaborate?
Like mha, it can give the new owner an unsynchronized relaylog to prevent losing some data.

Hi,
Sorry, these are leftovers from an unsuccessful attempt at MHA-like synching of relay logs. This was one of the PRs involved; but later most of the code was purged. I should delete these variables, too.

Removed in https://github.com/github/orchestrator/pull/894/commits/1c37be35a9b20cd23249632a5badb8e3b845b09e

Closed as no further action is needed.


Secrets are now managed by native OS credential store.

Resolves #1464

Please try to break this :)
Bot secrets are now stored by your OS in your native credential store:
Windows: Credential Manager
Mac: Keychain
Linux: Secret Service API / libsecret

NOTE #1: Due to the fact that we now use keytar which is a native node addon, it has to be built properly for Electron when launching and running the app, and must be built for Node when running the tests (Jest environment).
I couldn't figure out a way to have it easily built for both environments, so if you decide to flip back and forth between running tests and launching the app, then you will need to use the scripts in the root/package.json file:

rebuild:keytar:electron: use when you want to run the app
rebuild:keytar:node: use when you want to run the tests

Let me know if you think this process could be improved or better documented.

NOTE #2: The library used to rebuild keytar for Electron, electron-rebuild, does not play nicely with Lerna monorepos, and so keytar had to be added as a dependency to the root package.json file. This should not have any adverse effects other than there being an extra line in the file. I opened an issue against electron-rebuild and it can be found here.

This looks good. I think we should consider code that removes the store bot secrets from the server.json with this rollout.
@cwhitten - thoughts?

@justinwilaby bot secrets are currently stored in bots.json via the BotInfo type, unless you are talking about something else. This PR has code that removes that property from those entries.

I think we need to do that before we can submit for the security & privacy reviews. @tonyanziano what do you think?

I thought that removing the property would be sufficient, and that further writes to bots.json would then omit the property, but that doesn't seem to be the case after testing it just now.
I can add some code that purges any secrets from bots.json before loading / writing.


[Github] phpstan.neon.dist: remove references to non-existant exclude-files

1. Why is this change necessary?
latest PHPStan release errors on non-existant exclude-files
2. What does this change do, exactly?
fixes the phpstan config
3. Describe each step to reproduce the issue or behaviour.
run phptan 1.11.9 on the codebase
4. Please link to the relevant issues (if any).
5. Checklist

[ ] I have rebased my changes to remove merge conflicts
[ ] I have written tests and verified that they fail without my change
[ ] I have created a changelog file with all necessary information about my changes
[ ] I have written or adjusted the documentation according to my changes
[ ] This change has comments for package types, values, functions, and non-obvious lines of code
[ ] I have read the contribution requirements and fulfil them.

Imported from Github. Please see: https://github.com/shopware/shopware/pull/3826

[public] Shopware automated response: This issue is linked to the internal issue: NEXT-37517
[created from NEXT-37517, comment 514323]


Fix bug with breakdown

Bug:
breakdown was broken because we were using dataframe instead of pivot table for dist_bar viz
Before:
https://github.com/airbnb/superset/issues/2299
After:

@ascott @mistercrunch

i pulled this branch down and tested locally. definitely fixes the issue with adding a breakdown, but creates an issue when there are more than one series specified:

piggy backing off vera's work here. thanks for getting me started on this!
pushed 2 commits:

fix horizontal scrolling for dist_bar charts only (the class names changed in explore v2)
don't string-ify the x axis label

it works now for a single series, multi-series and breakdowns.


[WIP] Release/3.2.0

This release will contain a complete re-write of the command parser (currently in PR on my fork).  This will change how commands are used in the sim.
There will be more information forthcoming on command changes as we get closer to the release date.  TL;DR every command will require a space between the command and its arguments.
ex: fh270 will become fh 270.
This release is targeted to be completed on 12/20/2016.

view a list of current, finished changes in the release/3.2.0 CHANGELOG.
play around with the current state of v3.2.0 on our release environment
see what else we're planning to include (subject to change) milestone v3.2.0

If you find a bug or figured out a way to break something, please log an issue on my fork.  If you have any questions about upcoming changes, please log them here.

I am not sure if this is the right place to post issues related to the above stated release environment
https://atc-release.herokuapp.com/
I have tested EDDM, EDDT and EDDF as well as EGLL departures:
Although clearing departing planes with
id taxi
id caf
id to
I get a "no altitude assigned" message.
It works as expected at KSFO. I did not test other airports.
Is the functionality in any way limited in the environment?
Or have I encountered a bug?

Shouldn't cvs sort this altitude not assigned out?
On 13 Dec 2016, 21:33 +0000, P@nther <EMAIL_ADDRESS>wrote:

I am not sure if this is the right place to post issues related to the above stated release environment
https://atc-release.herokuapp.com/
I have tested EDDM, EDDT and EDDF as well as EGLL departures:
Although clearing departing planes with
id taxi
id caf
id to
I get a "no altitude assigned" message.
It works as expected at KSFO. I did not test other airports.
Is the functionality in any way limited in the environment?
Or have I encountered a bug?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub (https://github.com/zlsa/atc/pull/755#issuecomment-266868726), or mute the thread (https://github.com/notifications/unsubscribe-auth/ASgmWPxLTM036VfY1zb8eDZdS3jX-hDvks5rHw9GgaJpZM4LKjsM).

@erikquinn everything merged fine locally and tests pass.  :shipit:


No longer able to download massive batches (21,000+ images)

Specs: Windows 11, Grabber version 7.9.0 x64, amd ryzen 3600, amd radeon 589x 8gb, 16gb of ram
Problem:
I'm trying download massive batches(60,000+ images) of my favortie franchises only for it to stop and "finish" once it reaches 21,000 images. This happens with gelbooru(I only use gelbooru due its massive database, so idk if this happens with other sources). I had no problem doing this with the older versions.
Attempted Fixes:

Rollback to older version - I tried rolling back, but the previous versions are too buggy, it doesn't load or process gelbooru images and it crashes when going to the download page
Re-download - It just skips all existing files and still stops at 21,000, not bothering downloading the rest
Clean Re-Install and restarting computer - Tried it, doesn't work

Screenshot of log:

Gelbooru does this from time to time, its normal.


email recive issue

hi im using fine uploader
and when user upload images and fill the form im get email
but from some users i dont get email about the uploaded that they did!
here is the form in my website http://www.picapic.co.il/חלוק-רחצה-עם-תמונה.html
i think its problem with user browser or user OS
how can i monitor it and check it?

Hi why you close it???

You deleted the template
You didn't read the contributing instructions, especially the part related to asking for support.
You didn't provide any information necessary to troubleshoot your issue.


Turned the check of the scroll at the bottom from  …

checking equal to checking a range to make it work with fractions.
For #6580

[x] Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
[x] Title summarizes what is changing
[x] Has a news entry file (remember to thank yourself!)
[ ] Appropriate comments and documentation strings in the code
[ ] Has sufficient logging.
[ ] Has telemetry for enhancements.
[ ] Unit tests & system/integration tests are added/updated
[ ] Test plan is updated as appropriate
[ ] package-lock.json has been regenerated by running npm install (if dependencies have changed)
[ ] The wiki is updated with any design decisions/details.

Codecov Report

Merging #7259 into release will decrease coverage by 0.44%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           release    #7259      +/-   ##
===========================================
- Coverage    58.48%   58.03%   -0.45%
===========================================
  Files          485      485
  Lines        21437    21437
  Branches      3462     3457       -5
===========================================
- Hits         12537    12441      -96
- Misses        8122     8211      +89
- Partials       778      785       +7

Impacted Files
Coverage Δ

src/client/testing/serviceRegistry.ts
48.64% <0%> (-46.85%)
:arrow_down:

src/client/testing/codeLenses/main.ts
44.44% <0%> (-33.34%)
:arrow_down:

...t/datascience/jupyter/jupyterDataRateLimitError.ts
66.66% <0%> (-33.34%)
:arrow_down:

src/client/formatters/serviceRegistry.ts
75% <0%> (-25%)
:arrow_down:

src/client/api.ts
62.5% <0%> (-25%)
:arrow_down:

src/client/common/utils/platform.ts
64.7% <0%> (-23.53%)
:arrow_down:

src/client/common/utils/icons.ts
83.33% <0%> (-16.67%)
:arrow_down:

src/client/datascience/cellFactory.ts
75.86% <0%> (-13.8%)
:arrow_down:

src/client/common/logger.ts
68.55% <0%> (-6.92%)
:arrow_down:

src/client/providers/providerUtilities.ts
83.33% <0%> (-5.56%)
:arrow_down:

... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8773f63...d1e9ac1. Read the comment docs.


fix(*): and new typings and remove deprecated properties

Deploy preview for clashofclans-js ready!
✅ Preview
https://clashofclans-npjy075zt-csuvajit.vercel.app
Built with commit 6a136574c6e77a8dc90e16c02084c70fa11b86ea.
This pull request is being automatically deployed with vercel-action


Ryzen 2400G (Raven Ridge) iGPU model.

Description
When running neofetch on the desktop APU AMD Ryzen 2400G with Vega 11 integrated gpu, the gpu name is wrongly reported as Vega 8 mobile.
Neofetch version
3.4.0
Screenshot

Config file
https://pastebin.com/6pp4teLk
Verbose log
https://pastebin.com/LaRGH6kf

Version 3.4.0 is pretty old, have you tried a more recent version?
This is the output on my system.
5.0.0
CPU: AMD Ryzen 5 2400G (8) @ 3.600GHz
GPU: AMD ATI Radeon Vega Series

git-master
CPU: AMD Ryzen 5 2400G (8) @ 3.600GHz
GPU: AMD ATI Radeon Vega Series / Radeon Vega Mobile Series

@arisinfenix Gotta admit I've installed the version from the repositiories. There is no information about the Ubuntu repo being out of date in this article: https://github.com/dylanaraps/neofetch/wiki/Installation (while there is a note about debian stretch) . If it's the version problem, the problem is with the package in the repo being outdated (3.4 vs 5.0 is a MASSIVE gap) or the article being outdated.

Shouldn't be a problem with neofetch version (since virtually we still use lspci to gather data between 3.4.0 and 5.0.0).
This means your PCI database is outdated.
See this for information.

@konimex "sudo update-pciids" fixed the issue for neofetch. Thank you:)


option to set time-format via env variable of config file

Output of helm version:
version.BuildInfo{Version:"v3.9.0", GitCommit:"7ceeda6c585217a19a1131663d8cd1f7d641b2a7", GitTreeState:"clean", GoVersion:"go1.17.5"}

Output of kubectl version:
N/A
Cloud Provider/Platform (AKS, GKE, Minikube etc.):
N/A/

The helm list command allows to provide --time-format flag to control how date is rendered, for example:
helm list --time-format "2006-01-02"

It would be nice if one can set the default format in some config file, e.g. under ls ~/.config/helm/ or at least as environmental variable.

@RafalSkolasinski Do you mins providing the use case for this.

Just convenience when working a lot with with helm from terminal. Usual output is too wide and lines gets wrapped which make the output harder to read.
I could create an alias, true, but I'd prefer to be able to just set it once somewhere and keep using helm list as usual.

This ask is quite similar to guy’s .gitconfig file, where you can set things like what signing key you use with the signoff flag, or what email address/name you use when authoring commits.
For example: https://github.com/bacongobbler/dotfiles/blob/main/gitconfig
commands like aws configure would be good inspiration for this.
I’m in favour of this request.

Thanks for the feedback @bacongobbler

@RafalSkolasinski This was discussed at the developer call today and it was agreed that this could be implemented.
It was suggested to implement it as a env variable which should only be CLI visible and not as part of the SDK package. It was also suggested that we look to provide configuration file settings as raised by @bacongobbler  in https://github.com/helm/helm/issues/11028#issuecomment-1149389317.  https://github.com/helm/helm/issues/11036 has been raised to track this effort.

@RafalSkolasinski Do you fell like pushing a PR for this?


Benchmark: Brython vs Transcrypt

re: Benchmark request #459

would it be possible to have extended Benchmark: Brython vs Transcrypt, i.e.:

https://brythonista.wordpress.com/2015/03/28/comparing-the-speed-of-cpython-brython-skulpt-and-pypy-js/

Benchmarks can't show the full picture, but if you want to try this at home, save that benchmark code locally, then:
pip install transcrypt
transcrypt bench_str.py

Then make some html with this body (note type="module", so use ES6 supporting browser):

Setting id to terminal is a transcrypt feature that will show anything that was printed in the DOM element with that id. Otherwise, it goes to the console.
Finally, serve it, so modules can be loaded:
python -m http.server 8005

@Andrei-Pozolotin @fzzylogic requesting https://github.com/skulpt/skulpt to be included in this benchmark as it, Brython and Transcrypt are all in this article.
https://pythontips.com/2019/05/22/running-python-in-the-browser/
Also thanks for the work, we might need a benchmark that is comprehensive, which compares:

native Python

CPython
Python compilers including Cython and Nutika
JITs including PyPy and Numba

native JS equivalents in the browser
Python-to-JS compilers

Transcrypt
Brython
Skulpt

Since there are many aspects that determine the useability of a compiler/interpreter, I try to stay away from direct comparison with other browser Pythons.
Having said that, code generated by Transcrypt is quite compact and runs as fast as JavaScript by good approximation.
The figures referred to by the link below give some impression.

Note that Transcrypt avoids constructs that cannot be made to perform in the browser. This means that Transcrypt and CPython are playing in different leagues. Transcrypt makes it possible for Python programmers to take a lot of their skills to the browser, but it is in no way a replacement for CPython. The two should be regarded as complementary.

http://www.transcrypt.org/docs/html/philosophy_directions.html#why-are-certain-python-constructions-supported-as-a-local-or-global-option-rather-than-by-default

In my experience, Brython is about 30 times slower than CPython. Transcrypt is not much different from pure Javascript if you don't use slow compiler options such as kwargs, tconv, keycheck, etc. So, I believe that Transcrypt can be over 30 times faster than Brython. Even if you use all the slow options, I think that Transcrypt is still a lot faster than Brython because Transcrypt is developed focusing on speed while Brython is focusing on compatibility to CPtyhon.
If you are developing web pages whose speed is not crucial, Brython can be a good choice because you can use standard Python expressions and libraries without big limitations. Also, keep in mind that web pages are cached in server, in client, and in proxy. So, if your web page is static or non-interactive html, you don't have to worry too much about speed of Brython.
But if you are developing an application whose speed is crucial, choosing Transcrypt is inevitable.

Closing since there have been no further comments for some time.


An error message shows if the URL is blank or begins/ends with spaces

Steps to reproduce:
Fill in a valid URL and then remove it
OR
Add spaces at the beginning or at the end of the URL
Result:
In the above three cases, it's not necessary to display an error message

Fill in a valid URL and then remove it.  (In this case, I think the error message should be displayed)。 @guangbochen  @DoNotSayYes

Fill in a valid URL and then remove it. (In this case, I think the error message should be displayed)。 @guangbochen @DoNotSayYes

Fill in a valid URL and then remove it. just like users are not typing in anything at all, what is the necessity of showing this error message? @WuJun2016

@DoNotSayYes
After clicking the create/edit button, an error message will be displayed , but it will not be hidden until the next click.
Does it make sense?

Validated


Remove Issue from Finding

This can be handled by the core.

Warnings

:warning:

It looks like you're editing the un-versioned copy of our website. This affects only users on the 'next' version of detekt, and it's correct only if you intend to document a future change or feature. If you intended to make a change also for the current version of detekt, please make sure you edit the equivalent file inside website/versioned_docs/ as well.

Messages

:book:

Thank you very much for making our website better :heart:!

  Generated by :no_entry_sign: dangerJS against<PHONE_NUMBER>c35371a9bd96a1192fac9c176aaeb5

@detekt/maintainers could I get a review here? I know that the diff seems scary but the changes in all the rule files is really simple. Just remove the Issue from the CodeSmell. Also, if you find it difficult to review just tell me. I could split this up in two PRs. One with the change but keeping the CodeSmell constructor as @Deprecated and another just removing that deprecation constructor and all their usages. But I'm not sure if that would help to speed up the reviews or just slow them down.
Also I created this chain of PRs that they can be reviewed too. They are "draft" because they doesn't depend directly on main, but they are ready to review (also these ones are smaller): #6874, #6877, #6878, #6883 and #6884


Fix remaining lints

Okay, that was a slog. Maybe someone can look into that AtomicBool thing in interop, but I ran out of steam after this, and I'm neither familiar with that code nor with AtomicBool.

(Also fixing these being a slog is a pretty good reason to maintain them through CI. I just hope there's not too much churn.)


docs: import from hosted docs website

Demo: https://github.com/adamdecaf/ach/tree/docs-from-hosted/docs

Codecov Report

Merging #734 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #734   +/-   ##
=======================================
  Coverage   93.13%   93.13%
=======================================
  Files          65       65
  Lines        5796     5796
=======================================
  Hits         5398     5398
  Misses        239      239
  Partials      159      159


[Question] Int8 Gemm's perf degraded in real models.

I have encountered a problem that whe benchmark the https://github.com/NVIDIA/TensorRT-LLM/blob/a65dba7aaf7e2d8bb0120eea8f8f04deff145d6a/cpp/tensorrt_llm/kernels/cutlass_kernels/int8_gemm/int8_gemm_template.h#L62-L63 Int8 cutlass kernel seperately, the kernel really beats the fp16 gemm kernel.
But when it comes to real model, the int8 gemm kernel's perf degraded a lot. (I did use gemmprofilerplugin).
Two pictures from the nsight:
Int8 Gemm (above: seperate kernels, below: in real models)
int8 in benchmark:

int8 in models:

Device: A100 SXM-80GB
For 16, 6144, 4096; 14us -> 24us, almost doubbled. The config is exactly the same as the nsight shows.

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 15 days."

!


Page keeps reloading when loading trace from localhost URL

As I mentioned in https://github.com/rust-lang/rustc-perf/pull/1967#issuecomment-2351902875, the page keeps reloading when trying to load a trace from a localhost URL. This only happens when isLocalhostTraceUrl is set to true.
Although this is a bit of an edge case because we’re modifying some URLs to allow CSP and embedding Perfetto within a project, I wanted to go ahead and report it anyway.

Just a note to others: I looked at this issue, I think we should add some additional metadata to the open_trace_in_ui flow to distinguish these traces from other POSTs from localhost.


Fix system translating AppBar position by its size

The hack removed in #104 uncovered an issue where in some circumstances, the system will reposition our AppBar window by its height exactly.
This fixes the issue by adjusting the SetWindowPos message sent by the system only in these cases when we did not initiate the position move.

This doesn't fully address the issue. For now it seems best to bring back the hack.


[FLINK-21640]Job fails to be submitted in tenant scenario

Modify the "high-availability.zookeeper.path.root" permissions.

in my pc， they were successful

@tillrohrmann @wangyang0918 can u review and merge the PR? thx

@zentol can u review and merge the PR? thx

As discussed in the JIRA ticket, we decided not to apply the changes.


The error of an empty custom domain doesn’t disappear after switching from the ‘Other:’ domain to ‘Azure’ domain

Storage Explorer Version: 1.17.0
Build Number: 20210220.4
Branch: main
Platform/OS: Windows 10/ Linux Ubuntu16.04 / MacOS Catalina
Architecture: ia32/x64
Regression From: Not a regression
Steps to Reproduce

Launch Storage Explorer -> Open connect dialog.
Click 'Storage account ->  Account name and key'.
Focus on 'Storage domain:' in the dialog -> Select 'Other:' -> Delete the default domain.(An error displays)
Switch to 'Azure' -> Check whether the error disappears.

Expected Experience
The error disappears.
Actual Experience
The error still shows.

Additional Context
This issue also reproduces when switching to 'Azure China'/ 'Azure Germany'/ 'Us Government'.

Verified this issue on build rel/1.18.0 20210223.2. Fixed.

Hi @craxal This issue reproduces again on the build main/20210601.8. So we re-open it.


Flow raises error when looping over object properties, when object can be multiple types

Accessing property dynamically inside a loop over Object.keys(obj) raises an error, when obj can be multiple types:
  let copy = {};
  for (let key of Object.keys(obj)) {
    copy[key] = obj[key];
  }

See following example on flow try: https://flowtype.org/try/#0PQKgBAAgZgNg9gdzCYAoVMCmAXMcBGAVgIxgC8YA3qmGFHHAFxgDk+AhgE4sA0NYHTszbsAXi1QBfdFlwFCAJnJV+7ZsT618zBVPRQArgDsAxtgCWcI2BNwADgE8wACnkBKFbVk37TipUkAbn56ThdvAGtMJzgoMAB5IkwzADoohwBnVyI3D2paWltHAG10gF1leVLosuDaaVpOHANOayKHYOlUduySN2Ce+QV+oA
Using the following instead of Object.keys(...) directly works, but I find it quite cumbersome:
function _keys<T: string>(obj: any): Array<T> {
    return Object.keys(obj);
}

I notice that if you declare the type of the copy function, then everything type-checks ok.
The cause of this boils down to Flow having two different ways of thinking about objects. One is "typed, skinny objects", like {a: string}, where we know the allowed keys and the type of each value. A completely separate view treats an object as a dictionary mapping string keys to mixed values. When you give untyped object literals like in your example, Flow defaults to thinking of them as typed, skinny objects. But to use Object.keys and other dictionary-like methods, it needs to be told to think of them as dictionary-like Objects.

This error is now expected. You must explicit annotate the empty object to make it work.


Added slew rate function and removed some requested functions in README.md

Tried to Add a slew rate function
Removed Wheat stone bridge function from the readme.MD file
Removed Slew Rate function from the readme.MD file

Beautiful! Thank you!


Add missing controller to Devise RBI

Type of Change

[ ] Add RBI for a new gem
[X] Modify RBI for an existing gem
[ ] Other:

Changes

Gem name: Devise
Gem version: 4.9.4
Gem source: https://github.com/heartcombo/devise/blob/v4.9.4/app/controllers/devise/omniauth_callbacks_controller.rb
Gem API doc: https://rubydoc.info/github/heartcombo/devise/Devise/OmniauthCallbacksController
Tapioca version: 0.14.3
Sorbet version: 0.5.11414

closes https://github.com/Shopify/rbi-central/issues/248

I have signed the CLA!


Sync downstream devel with upstream devel branch

Sync the upstream changes from ceph/ceph-csi:devel into the devel branch.
The most important recent changes that we want included are:

This contains fix for  https://bugzilla.redhat.com/show_bug.cgi?id=2165941

/assign @nixpanic

/lgtm


Added documentation on README.md about the blackList property

PR Checklist
Please check if your PR fulfills the following requirements:

[x] The commit message follows our guidelines: https://github.com/ngneat/until-destroy/blob/master/CONTRIBUTING.md#commit
[ ] Tests for the changes have been added (for bug fixes / features)
[x] Docs have been added / updated (for bug fixes / features)

PR Type
What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[x] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

There is nothing on the readme (or wiki) that references the blackList property. I found it by looking at the source code.  I needed this property so UntilDestroyed wouldn't unsubscribe to global(?) subscriptions that are injected in the component
Issue Number: N/A
What is the new behavior?
I added a section on the documentation with an example.
Does this PR introduce a breaking change?
[ ] Yes
[x] No

Other information
N/A

Hey, @arturovt  and @NetanelBasal, let me know if what I did is ok. I'm happy to modify!


[Question]: Running ollama

What is your question?
After reading the documentation, I am still not clear how to get ollama working.
I've tried running this:  fabric --pattern explain_code --model codellama:latest Error: Client error '401 Unauthorized' for url 'https://api.openai.com/v1/models' For more information check: https://developer.mozilla.org/en-US/docs/Web/HTTP/Status/401

OK i think this was an error. I fixed the code. Can you try again? git pull then pipx upgrade fabric and let me know if it works

I just did a pull and pipx upgrade and still have the same error

What happens if you fabric --listmodels

@xssdoctor My PR #315 fixed some OLLAMA issues for Windows. @danielmiessler asked for you to look it over and approve it - I tested it on Linux, MacOS and Windows (both native and WSL) as well.

What happens if you fabric --listmodels
Here's what I got:

fabric --remoteOllamaServer http://<IP_ADDRESS>:11434 --listmodels
OpenAI API key not set. Skipping GPT models.
OpenAI API key not set. Skipping GPT models.
GPT Models:

Local Models:

Claude Models:
claude-3-opus-20240229
claude-3-sonnet-20240229
claude-3-haiku-20240307
claude-2.1

Can you apply my fix from #315 to installer/client/cli/utils.py and see if that fixes it?

@ksylvan Thanks for your help. I can now see the ollama models with your fix.
`fabric --remoteOllamaServer http://<IP_ADDRESS>:11434 --listmodels
OpenAI API key not set. Skipping GPT models.
OpenAI API key not set. Skipping GPT models.
GPT Models:
Local Models:
qwen:14b
qwen:72b
qwen:7b
qwen:latest`
However, when I execute this command:
pbpaste | fabric --pattern summarize
I see:
OpenAI API key not set. Skipping GPT models. Error: Connection error. Connection error.
What am I doing wrong?

I believe you need to set the model with the -m parameter (or set a new default model).
On Apr 6, 2024 at 10:09 PM -0400, MondyLab @.***>, wrote:

@ksylvan Thanks for your help. I can now see the ollama models with your fix.
fabric --remoteOllamaServer http://<IP_ADDRESS>:11434 --listmodels OpenAI API key not set. Skipping GPT models. OpenAI API key not set. Skipping GPT models. GPT Models: Local Models: qwen:14b qwen:72b qwen:7b qwen:latest
However, when I execute this command:
pbpaste | fabric --pattern summarize
I see:
OpenAI API key not set. Skipping GPT models. Error: Connection error. Connection error.
What am I doing wrong?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.Message ID: @.***>

@snafu4 You're the best! Thanks! Works like a charm.

@xssdoctor @danielmiessler please merge #315 - it fixes all cases where people are trying to use  --remoteOllamaServer

ok done. let me know if it works for all of you

Still same error. I've done a clean install with latest commits, both in WSL and native windows.
curl http://localhost:11434 Ollama is running
 fabric --remoteOllamaServer http://localhost:11434 --listmodels Error: Client error '401 Unauthorized' for url 'https://api.openai.com/v1/models' For more information check: https://developer.mozilla.org/en-US/docs/Web/HTTP/Status/401
Is there any config file where I need to add something ?

If you're running on 11434 you don't have to use that flag. Just run fabric -m with your ollama model.
Also remember to pipe upgrade fabric every time you git pull

I did a fresh install om MacOS
ollama list NAME                    ID              SIZE    MODIFIED codellama:7b-code       fc84f39375bc    3.8 GB  2 months ago codellama:7b-instruct   8fdf8f752f6e    3.8 GB  2 months ago codellama:latest        8fdf8f752f6e    3.8 GB  4 weeks ago llama2:latest           78e26419b446    3.8 GB  2 months ago llava:latest            8dd30f6b0cb1    4.7 GB  2 months ago mistral:latest          61e88e884507    4.1 GB  2 months ago
fabric --listmodels Error: Client error '401 Unauthorized' for url 'https://api.openai.com/v1/models' For more information check: https://developer.mozilla.org/en-US/docs/Web/HTTP/Status/401

on native windows i got
 fabric --listmodels Error: Client error '404 Not Found' for url 'http://localhost:11434/v1/models' For more information check: https://developer.mozilla.org/en-US/docs/Web/HTTP/Status/404
`Invoke-WebRequest -Uri http://localhost:11434
StatusCode        : 200
StatusDescription : OK
Content           : Ollama is running
RawContent        : HTTP/1.1 200 OK
Content-Length: 17
Content-Type: text/plain; charset=utf-8
Date: Sun, 07 Apr 2024 11:10:57 GMT`

ok, question. is there a chance you have an incorrect api key in your .config/fabric/.env? its ok to have no key, but if there is a key that is incorrect you could get that error

Solved: there was a dummy key in .env file. Thanks a lot !

I can confirm it works now on Windows, WSL, and Mac

I’ve confirmed the latest pull with the latest merges works on Linux, Mac, Windows, and WSL with Ollama

Great!

I did a fresh install om MacOS ollama list NAME ID SIZE MODIFIED codellama:7b-code fc84f39375bc 3.8 GB 2 months ago codellama:7b-instruct 8fdf8f752f6e 3.8 GB 2 months ago codellama:latest 8fdf8f752f6e 3.8 GB 4 weeks ago llama2:latest 78e26419b446 3.8 GB 2 months ago llava:latest 8dd30f6b0cb1 4.7 GB 2 months ago mistral:latest 61e88e884507 4.1 GB 2 months ago
fabric --listmodels Error: Client error '401 Unauthorized' for url 'https://api.openai.com/v1/models' For more information check: https://developer.mozilla.org/en-US/docs/Web/HTTP/Status/401

I have cleaned out the directories I know about, uninstalled and reinstalled fabric but still get this. I feel like I am missing the correct file to delete/remake or edit but I guess I don't know where it is. I'm running on ubuntu.

I did a fresh install om MacOS ollama list NAME ID SIZE MODIFIED codellama:7b-code fc84f39375bc 3.8 GB 2 months ago codellama:7b-instruct 8fdf8f752f6e 3.8 GB 2 months ago codellama:latest 8fdf8f752f6e 3.8 GB 4 weeks ago llama2:latest 78e26419b446 3.8 GB 2 months ago llava:latest 8dd30f6b0cb1 4.7 GB 2 months ago mistral:latest 61e88e884507 4.1 GB 2 months ago
fabric --listmodels Error: Client error '401 Unauthorized' for url 'https://api.openai.com/v1/models' For more information check: https://developer.mozilla.org/en-US/docs/Web/HTTP/Status/401

I have cleaned out the directories I know about, uninstalled and reinstalled fabric but still get this. I feel like I am missing the correct file to delete/remake or edit but I guess I don't know where it is. I'm running on ubuntu.

I found it. Working now.


Rustfmt stability

With any luck, Rustfmt 1.0 will happen very soon. The Rust community takes promises of stability very seriously, and Rustfmt (due to being a tool as well as a library) has some interesting constraints on stability. Users should be able to update Rustfmt without hurting their workflow. Where it is used in scripts or on CI, updating Rustfmt should not cause operational errors or unexpected failure.
Some changes would clearly be non-breaking (e.g., performance improvements) or clearly breaking (e.g., removing an API function or changing formatting in violation of the specification). However, there is a large grey area of changes (e.g., changing unspecified formatting) that must be addressed so that Rustfmt can evolve without hurting users.
The goal is for formatting to only ever change when a user deliberately upgrades Rustfmt. For a project using Rustfmt, the version of Rustfmt (and thus the exact formatting) can be controlled by some artifact which can be checked-in to version control; thus all project developers and continuous integration will have the same formatting (until Rustfmt is explicitly upgraded).
I propose two possible solutions: versioning is handled by Rustfmt (by formatting according to the rules of previous versions), or versioning is handled by Cargo (by treating Rustfmt as a dev dependency).
Edit: Rendered

I suspect that anybody worried about rustfmt changes breaking their CI should be equally worried about updates to rustc and cargo. Since all three come from the same source (rustup), it seems reasonable to expect people to pin them all in the same way.

QUESTION - how do we distinguish API breaking changes from major formatting changes?

I feel like major formatting changes probably are API breaking changes, since a formatting change implies new configurable options to tweak, and if the new options can't be set to mimic the previous behaviour then they can't default to that behaviour, which means the API has changed in an incompatible way.

QUESTION - could there be incompatabilites with the toolchain (e.g., Rustfmt at the version specified can't handle a Rust feature used in the project)?

I guess, if (for example) a new syntax feature like async/await or impl Trait was added to Rust and nobody got around to teaching rustfmt about it during the nightly and beta phases. I feel like that should be avoided anyway, though, regardless of the documented compatibility guarantees.

QUESTION - how do we handle RLS integration?

RLS comes from the same place as cargo and rustfmt, so it's presumably built from the same source and should always be compatible with the standalone command.

I suspect that anybody worried about rustfmt changes breaking their CI should be equally worried about updates to rustc and cargo.

For projects using unstable features definitely. Otherwise, not worrying about this is the point of the whole stability thing.

"Worrying" is a relative concept. Rust's tolerance for incompatible changes is not quite zero, and stable-channel breakage does occur occasionally. As a concrete example, I recently encountered a project that broke because the standard library added a trait implementation.
While that project was easy to fix manually, rustfmt breaking is even easier to fix, since you can just run cargo fmt and commit the result without having to think. If anything, people should be more worried about rustc and cargo changes than rustfmt.

I don't think we need to rev rustfmt's major version if formatting changes somewhat. With respect to formatting alone (ignoring API changes and similar), I would suggest the following versioning scheme:

Micro version: changed for minor bugfixes, with little to no impact on the formatting of code other than in unusual corner cases addressed by such bugfixes.
Minor version: changed when introducing formatting of new language constructs that didn't previously exist, or when changing formatting in non-trivial ways. (For instance, if we came up with a new heuristic for one of the heuristic-driven bits of formatting.)
Major version: should likely never change due to formatting alone, only if some API break occurred.

I think the largest pain-point here is for contributors to projects using rustfmt as a CI step (diesel being one example of a project doing this).
In this case, the user has to make sure they're using the exact same version of rustfmt as is running on CI or else they'll have to manually apply the formatting changes. When contributing to multiple projects with differing rustfmt versions this is quite annoying.
Anything that can be done to make this case easier would be great.

I can't think of any way to remove the hassle of "my rustfmt doesn't match CI" other than forcing rustfmt to support a --ruleset or --version or --edition argument and just guaranteeing that rustfmt --ruleset 1 will always produce the same source code edits on any input in all future rustfmt versions, maybe modulo bugfixes, and let each repo have a .rustfmtrc file specifying the default ruleset.

the user has to make sure they're using the exact same version of rustfmt as is running on CI or else they'll have to manually apply the formatting changes. When contributing to multiple projects with differing rustfmt versions this is quite annoying.

@Diggsey is this really annoying? I've faired quite well with cargo +stable fmt. (Assuming I can easily see which toolchain is used on CI when running rustfmt). I imagine that if this was a seamless experience (using internal versioning), the most obvious pain point for contributors would go away.

I suspect that anybody worried about rustfmt changes breaking their CI should be equally worried about updates to rustc and cargo. Since all three come from the same source (rustup), it seems reasonable to expect people to pin them all in the same way

rustc and cargo have very strong backwards compatibility guarantees and we should have them for rustfmt too.

I feel like major formatting changes probably are API breaking changes...

I was referring to changes to formatting which don't add or change configuration options, i.e., affect users using the default options

While that project was easy to fix manually, rustfmt breaking is even easier to fix, since you can just run cargo fmt and commit the result without having to think. If anything, people should be more worried about rustc and cargo changes than rustfmt.

This is true, however, the case we're trying to avoid is that a PR fails its CI because the Rust version (and thus Rustfmt version) got bumped, we'd like some kind of pinning or back compat guarantee which means users have to opt in to breakage.

I don't think we need to rev rustfmt's major version if formatting changes somewhat. With respect to formatting alone (ignoring API changes and similar), I would suggest the following versioning scheme

This is ignorning the CI use case in the motivation. Consider CI under this proposal: the repo is formatted using rustfmt 1.0, the CI checks each PR is formatted correctly using rustfmt 1.0. A Rust release happens and that bumps rustfmt to 1.1 which changes its formatting algorithm. The next PR to run is still using rustfmt 1.0 and now fails the CI, this innocent contributor has to format the entire repo for their PR to pass CI. Similarly, if someone downloads the repo and runs the CI locally with rustfmt 1.1, they'll see that the repo is failing tests.

is this really annoying?

We're hearing from multiple users that this is very annoying. I think it can be addressed with either pinning or internal versioning though.

So if we assume that rustfmt's version number is effectively identical to rustc's version number (much like cargo's is, these days), we can talk about the CI use-case in terms of "how much formatting churn should rustfmt allow from version to version?":

To clarify, you don't need different versions of rustfmt, in fact I'm not even considering that case. The case I'm considering is just a regular 6-weekly update, say from version 1.29 to 1.30 (Rust and Rustfmt versions).
So just like rustc there aren't API breaking changes, but there are other important facets of stability. For example, imagine if from 1.29 and 1.30 we swapped the meaning of true and false - no API is changing, but a whole lot of code would start failing tests. Likewise if we let formatting change between 1.29 and 1.30, then a whole bunch of tests would fail, and I propose that that is not acceptable as a backwards compatibility consideration.

Some

This is basically what I am proposing, except that the 6-monthly breaking release would actually have a major version number change.

Thank you @nrc for writing up the RFC!
I would rather manage stability externally, as doing it internally seems to add a considerable complexity to the code (e.g. gating formatting fixes based on versioning - what happens when we decide to revert the change after the later version?).
I would like to propose supporting different level of stability in different channels: rustfmt on stable channel should be as stable as possible, whereas rustfmt on nightly channel may introduce breaking formatting changes in minor version updates.
I would suggest the following version scheme after 1.0:

Major version: API breaking changes and/or formatting changes. On stable rustfmt, any formatting changes should only be introduced through major version update.
Minor version: formatting changes, critical bug fixes like panicking on certain kind of code and/or supporting a new syntax. On stable rustfmt, we have no minor version update.
Micro version: critical bug fixes and/or supporting a new syntax. No formatting changes should be introduced with micro version updates.

E.g. rustfmt-stable 1.0.13 and rustfmt-nightly 1.2.1.
We should only bump the major version once a few years or so (maybe when the new epoch is introduced?). We do not support stability between major versions (no LTS release). We do not support stability between minor versions (e.g. rustfmt-nightly 1.3.0 does not support rustfmt-nightly 1.2.0).
The benefit of the above scheme is that

Users can easily benefit the stability support of rustfmt in the stable channel with ease, as users need not specify rustfmt version
Maintainers can keep updating rustfmt incrementally in the nightly channel

The downside I am aware of is that

Formatting changes that comes with major version updates may be quite large
Users using stable channel cannot benefit from formatting fixes without major version releases (though AFAICT we are opted to sacrifice this in favor of stability)
Users using nightly channel cannot benefit from stability guarantee
Backporting could be rough

@rfcbot fcp merge
Summary: The RFC proposes handling versioning internally to Rustfmt and having users opt-in to breaking formatting changes (similar to how the editions will work for Rust). This means running Rustfmt on a project in CI versus locally should have the same results no matter which version of formatting is used.

@rfcbot reviewed

I've raised my concerns on the internals announcement (https://internals.rust-lang.org/t/2018-edition-end-of-week-post-2018-08-04/8123/2?u=gnzlbg). They can be summarized in: if rustfmt isn't currently good enough for the rust-lang and rust-lang-nursery crates, why should it be good enough for users?
rustfmt is a great tool, but it still feels beta quality at best:

it cannot really format macros (playground
it cannot check that code is properly formatted: that is, if you all cargo fmt --all and then call cargo fmt --all -- --check, the first command can succeed, formatting all your code, but the checking command does still fail (https://github.com/rust-lang-nursery/rustfmt/issues/2787_
it cannot format some of the rust-lang-nursery crates without breaking their build, or breaking their tests (or both): https://github.com/rust-lang-nursery/rustfmt/blob/master/.travis.yml#L36

I use rustfmt every day, and on CI, yet I still need to format a lot of code manually (and cargo fmt --all -- --check can return succeed both for the automatically formatted code, and then also when I manually format it to fix issues like with macros - this doesn't feel idempotent).
I would rate the experience of using rustfmt for 1) formatting code, and 2) verifying that code is properly formatted as frustrating.
And I ask myself the question: if rustfmt isn't good enough for rust-lang/rust, the rust-lang-nursery crates, etc. why should the current version be "good enough" for users?
Because to me a rustfmt 1.0 release means that the tool is good enough to do its job, but I'd bet that if we tried using it on rust-lang/rust on CI to reject improperly formatted PRs and format the whole codebase, we would turn the RUSTFMT builds to allow in less than a week, and probably remove them in less than a month because of the amount of frustration that this would generate due to all current issues with rustfmt.
If we can't dogfood it, doing a 1.0 release that "sells" it to users just feels wrong and will just generate comparisons between how bad rustfmt is when compared to gofmt or clang-format.

I don't think it not being dogfooded in rustc or servo means anything relevant.
Rustc and servo are huge. Moving them to rustfmt is a nontrivial process if you want to review the code, and it will also break all the PRs in flight.
The reason servo hasn't rustfmted yet isn't that rustfmt isn't ready, it's that we haven't really decided what defaults we want and that's low priority. I brought this up once on the mailing list.
It's used on most of the other small crates.

@rfcbot reviewed

@rfcbot reviewed

A rustfmt 1.0 release conveys that the tool is good enough for end users, but I'd bet that if we tried using it on rust-lang/rust to format the whole code base and then on CI to reject improperly formatted PRs we would turn the enforcement off in a week because of the amount of frustration that this would generate due to all current issues with rustfmt.

Note that it is possible to automate the reformatting process (without introducing new commits or other such things). As deployed, this is currently only done when requested rather than as soon as errors are found. The logic we use to do this starts here though there are some parts "hidden" in dependent crates (namely git-work-area) which makes the operation performant even on gigantic repositories. I don't know what kind of work it would take to implement this in bors (and that tool doesn't support Github…yet). It does assume the formatting tool is idempotent though.

This is jumping in a little late, but I want to make an argument for externally-managed versions for a couple of reasons:
Minor formatting changes are pretty common (both in rustfmt but in other tools too)
I've used a couple of different auto-formatters before (mostly YAPF and Black for Python, gofmt, and a little bit of clang-format), and I've found that minor formatting changes happen fairly regularly. For the Python auto-formatters (possibly because they're new), there are probably minor formatting changes every two months or so. Go, for both 1.10 and 1.11 made formatting changes to go fmt.
Looking at the Rustfmt repo and looking at the issues tagged with "poor-formatting", and assuming closing those issues means making formatting changes, it looks like Rustfmt also makes minor formatting changes at least once a month.
If I understand the current proposal correctly, that means that either rustfmt would have to release major versions pretty regularly and handle a lot of complexity about choosing the right "format version" internally, or it would have to batch formatting fixes together at a much slower cadence than their actually fixed. Neither one of those seems that nice to me.
For CI, I think pinning a rustc version is ok
I agree with @Screwtapello that in-practice, I think that rustfmt is going to be mostly tied to the version distrusted through rustup (which is linked to the rustc version). At least, that's how my CI works for Rust and how my CI works for go.
Right now, for both Rust and Go, I only run rustfmt for a fixed language version (e.g. 1.25 or the 2018-08-01, and not stable or nightly). I then opt-in to formatting changes by upgrading my rustc version that I run rustfmt with.  I think this model works great, and I'm not sure why

if we let formatting change between 1.29 and 1.30, then a whole bunch of tests would fail

should be true (if the "test" is just that cargo fmt --check fails), when it's so easy to automatically fix the tests on upgrades.
(In Python, we just directly pin yapf==0.22.0 or whatever in our development environment, which also works great).


resolve deps for go_repo to subrepo targets rather than its install

Previously we would add installs for go_repo. This means when we resolve deps we would add the install target as a dep when we could use the subrepo target directly. Using the subrepo target directly is more efficient since we need to build less and if we are using remote execution the data transfer is smaller.

Nice, I think this makes sense. I was trying to figure out if we also wanted to do something in updater.reallyresolveimport but IIUC this prevents the installs ever being added to the graph which will achieve what we want.

yea Its not ideal that the logic for what gets resolved lies in the readModules method and maybe a refactor is required but this was the most targeted solution.


[fix bug 1184024] Replace choicefield with modelchoicefield in profiles.

@glogiotatidis r?

r+wc code looks good but i haven't tried this locally.


[INTEGRATION] [Airflow] Support for S3 Operators in marquez_airflow

Need support for S3 operator and extractor in marquez_airflow to run a DAG.

S3 Operators are already supported as listed here. Closing this


Remove v1alpha1

Remove the old API and all code related to the conversion. Searched for
all instances of "v1a1" and "v1alpha1" and removed them. Looked for
obsolete annotations like "managedBy" and "subnamespaceOf" and removed
those too.
Tested: all unit, integration and e2e tests pass
Fixes #1177

/assign @yiqigao217
/cc @GinnyJI
/cc @rjbez17

lgtm just 1 question:
Do we want to make it back to crd:triviaVersions so there's no per-version schema, or you prefer leave it as is in case we have another api version in the future? See line CRD_OPTIONS ?= "crd:trivialVersions=false" in makefile.

We'll definitely have v1beta1 and then v1 one day so we should leave this as-is.

/lgtm


Gamify msgarchive

msgarchive is way too stalky right now, it should be redone
Privacy:

stop indefinite tracking, reset tracked user if it has stayed the same for some hours
->maybe global "how long has this user been tracked for in total today" stats for users, to impose additional tracking limit
wipe cache frequently, this means abt hourly or less
maybe even add upper limit for °msgarchive calls per tracked user (meaning a given users msgs can only be looked up a limited number of times per day). Alternatively count number of displays per tracked msg and yeet them at a limit

Gamification:

Every user on the server gets one "tracking ticket" per day [Can they be stacked?]
1 tracking ticket can be used to call °settarget once, after that the tracked user stays the same until a) another user overwrites it or b) the privacy rules described above kick in and reset the tracking

the °msgarchive can only be enabled again when all of the above has been implemented

Fuck this


Submit note rework

Why am I doing this work at this time?

The upload button will be disabled and changes the text to "uploading..."
Hide the delete box when the user is not the author

I will be back wait a sec

I fix the problem now muhahaha