params being ignored

Pretty sure this is an issue with my config, but I need some help. I have added a bit of documentation to some of my endpoints, but none of the parameters seem to be getting added to the openapi spec created when I run the generator. Here is an example of an endpoint's documentation:
getDailyHistoricalData:
    summary: "Get Daily Historical Data"
    description: "Returns at least 60 days worth of historical data on the requested security"
    requestBody:
      description: "None"
    queryParams:
      - name: "identifier"
        required: true
        description: "Identifier of the security to query daily data on"
        schema:
          type: "string"

The summary and description are the the only things making it through to the generated json file. This is the command I am using: serverless openapi generate -o '../docs/historical.json' -f json
Any idea why I am not getting the queryParams or the requestBody. Here is what the output for that endpoint looks like:
"/daily": {
      "get": {
        "operationId": "getDailyHistoricalData",
        "summary": "Get Daily Historical Data",
        "description": "Returns at least 60 days worth of historical data on the requested security",
        "responses": {}
      }
    }

thanks

I was looking through the code and I found the problem. In the getOperationFromConfig, in the DefinitionGenerator class, for requestBody and parameters you check if the operationObject has the two, but it should really be checking whether documentationConfig has those two. Here is what you have:
    if (operationObj.requestBody) {
      operationObj.requestBody = this.getRequestBodiesFromConfig(documentationConfig);
    }

    if (operationObj.parameters) {
      operationObj.parameters = this.getParametersFromConfig(documentationConfig);
    }

It should be
    if (documentationConfig.requestBody) {
         operationObj.requestBody = this.getRequestBodiesFromConfig(documentationConfig);
    }
    if (documentationConfig.parameters) {
        operationObj.parameters = this.getParametersFromConfig(documentationConfig);
    }

Is this something you can fix soon?

Unfortunately, this project is dead and broken. PR #27 fixes this, but was rejected because the maintainers don't use this plugin anymore. You could patch your local plugin with the changes in #27 and things should be working again, although that might not be a convenient solution for everyone.

Thanks for letting me know the project is dead. I ended up forming it and fixing it myself. I also added support for x-code-samples. Problem is that I couldn’t figure out how publish to npm with a different name and get it to work with serverless, so I ended up just building the project and hosting the built files as a separate repo that I point to in my package.json


Avatar transition

I signed it!

In order to be able to accept this, you need to sign the correct CLA.
To do so, you'll need to select the "Any other Google project" option.

Squashed and released. Thanks for the contribution.


Gemfiles use HTTPS

This PR changes the additional Gemfiles' gem lines to use git-with-HTTPS instead of the simpler-but-warning-generating github: annotation.

@mikker branch: 'master' is the default, too.

You're on a roll! ❤💜💙💛💚


extracted libraries (DLL etc) not deleted properly on exit

see https://bitbucket.org/xerial/sqlite-jdbc/issues/202/jdbc-driver-extracts-a-new-dll-library-on#comment-None - firstly, http://bugs.java.com/view_bug.do?bug_id=6357433 - but since we have                 if(writer != null) {                     writer.close();                 } and it ain't closed, maybe it's due to the fact that the DLL has been loaded and is not unloaded? ( https://web.archive.org/web/20140704120535/http://www.codethesis.com/blog/unload-java-jni-dll as the possible solution in that case )
Anyway, to allow a manual workaround: maybe keep "extractedLibFile" somewhere, so that the API user can actually know what is the lib (DLL) that has been extracted, to allow later cleanup for it (external script or whatever).

I had the same Problem with tons of sqlite.dll's in my tmp dir.
I tried to delete the dll's via an Runtime shutdownHook but the dll's can not be delete.
Yes I think its because the dll is attached to the current running process.
Now I removed the uuid from the extrected dll name and test if the dll is already there -> use it / otherwise copy and use it.
So there will be one dll for each version only without any deletion.

This is a duplicate of #80 and is an issue on Windows. *NIX should allow deleting the shared library without a problem, AFAIK.


tabulate laser data

work in progress

waiting for #454 to be approved before the tests will make sense

I can't check if the image generated by your test is the same as laser_aligned_sensor_debug.png because I'm not running the tests on the lab server!

It should be in analyze/tests/tmp/ wherever you run the tests!


updated courses directory

I added seperate directory for courses instead of it being just a directory-less file.

Same over here, let's split up packages when it reaches uncomfortable sizes.
Will correct md file. thanks.


Code of Conduct question on Instructor Training form should be required

The question I agree to abide by The Carpentries' Code of Conduct on the Instructor Training form should be required and should include a question on the left column of the form so the question doesn't get lost on the form.

I've made the question required, but the way the text is displayed is handled by Django, so we'd have to manually change the display for this question. I don't know quite how to do this, though I believe it should be possible.
For some other checkboxes on the page the text position makes more sense - perhaps it would actually be better (it's certainly easier) to move this question to a position in the order where it won't be as easily overlooked (i.e. not right after a large text box)


Registrar NameServers and DomainStatus should be a []string?

Hello @likexian!
Thank you for this library, it is very useful.
Will you consider a MR that converts DomainStatus and NameServers to []string{} instead of a comma separated string list?
Thanks

Well, thanks to @llonchj , i will think of it.


Add Drag All to Hotbar module support

Add support for the Drag All to Hotbar module. I raised this with them first and they indicated that this issue has to be addressed on your module, as it does not allow for any drag and drop events. See Custom Hotbar Support #3

Thanks, I did not know that this module existed. I'll look into it and talk to the author if needed.


Refreshing the page gives 404

It seems that the app uses routing that changes the URL (history API) but it's not reflected on the server and just show 404 page from netlify.

True! Same for me!


remove mongo_id from tables

I rule and have completed some work on Case Manager that's ready for review!
Don't merge until EOM, but this drops the mongo id tables, thereby nuking our last vestige of mongo.
This pull request makes the following changes:

remove mongo_id columns

no view changes
It relates to the following issue #s:

Bumps #2072

For reviewer:

Adjust the title to explain what it does for the notification email to the listserv.
Tag this PR:

feature if it contains a feature, fix, or similar. This is anything that contains a user-facing fix in some way, such as frontend changes, alterations to backend behavior, or bug fixes.
dependencies if it contains library upgrades or similar. This is anything that upgrades any dependency, such as a Gemfile update or npm package upgrade.

If it contains neither, no need to tag this PR.

Codecov Report

Merging #2254 (5223747) into main (ef017c8) will not change coverage.
The diff coverage is n/a.

:exclamation: Current head 5223747 differs from pull request most recent head 73aabce. Consider uploading reports for the commit 73aabce to get more accurate results

@@           Coverage Diff           @@
##             main    #2254   +/-   ##
=======================================
  Coverage   96.23%   96.23%
=======================================
  Files          79       79
  Lines        1648     1648
=======================================
  Hits         1586     1586
  Misses         62       62

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ef017c8...73aabce. Read the comment docs.


pxc container's livenessProbe can not be changed by PerconaXtraDBCluster's livenessProbes

As the title.

readinessProbes is also the case.

Hey folks. I was able to reproduce it.
I changed it in cr.yaml:
pxc:
...
    readinessProbes:
      timeoutSeconds: 16
      periodSeconds: 31

    livenessProbes:
      timeoutSeconds: 6
      periodSeconds: 11

I see it is properly set in the custom resource in k8s.
But it is not reflected in the container.
    livenessProbe:
      exec:
        command:
        - /var/lib/mysql/liveness-check.sh
      failureThreshold: 3
      initialDelaySeconds: 300
      periodSeconds: 10
      successThreshold: 1
      timeoutSeconds: 5

At the same time I see env variables are set:
   - name: LIVENESS_CHECK_TIMEOUT
      value: "6"
    - name: READINESS_CHECK_TIMEOUT
      value: "16"

@egegunes @hors any thoughts before I create a JIRA bug?

@spron-in @hulucc it was fixed under https://perconadev.atlassian.net/browse/K8SPXC-1345 and will be available in the next release.

Awesome! Thanks @hors !

Thank you @hors ! When we restore a foreign backup onto a pxc-operator managed cluster the inability to adjust the readiness probes gave a very slim window where we could connect into the pxc container of the pod and get the grants restored before the failing probe took out the container. I discovered this issue attempting to lengthen the timeout.
It would be beneficial if the operator could detect and possibly remediate the condition where the grants required by the operator are not present in the database; however I do not know if that is already possible by some existing mechanism I have not yet discovered. Is it possible to use a prestop hook on the restore job I wonder?


allow other masking for Embedding

Even we do not mask zero, we may has other mask from previous layer. Return None directly is not very rigorous.

no one needs this feature?


Synchronous ROS planning scene methods

Closes #95
What type of change is this?

[ ] Bug fix in a backwards-compatible manner.
[ ] New feature in a backwards-compatible manner.
[ ] Breaking change: bug fix or new feature that involve incompatible API changes.
[x] Other (e.g. doc update, configuration, etc)

Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

[x] I added a line to the CHANGELOG.rst file in the Unreleased section under the most fitting heading (e.g. Added, Changed, Removed).
[x] I ran all tests on my computer and it's all green (i.e. invoke test).
[x] I ran lint on my computer and there are no errors (i.e. invoke lint).
[ ] I added new functions/classes and made them available on a second-level import, e.g. compas_fab.robots.Configuration.
[ ] I have added tests that prove my fix is effective or that my feature works.
[ ] I have added necessary documentation (if appropriate)

Removing the advertising of topics and the initialization of the planner seems to really expose the problem with Twisted as the integration tests consistently fail for commit 066071b.  However, they pass on my machine.  Not sure what to do about this...

In the stack trace, twisted errors out on a file called _legacy.py or similar. Could it be that twisted itself has changed and we cannot reproduce because we have slightly older versions of it locally?

I use Twisted version 20.3.0 locally, and that's what seems to be appearing in the logs for the integration tests.

I just created a new conda environment as is done in the install script (major difference being python 3.8 rather than 3.6) and ran the tests again, and they still pass locally.

I checked what this legacy file is but it's only the logging system,so, unrelated.
One option to try to replicate would be to run the tests in an ubuntu docker container.

I've done this in a Debian container and I don't get the same errors.


any plan to update the plugin for new json for apple?

I saw that for ios 13+ apple has changed the json for apple-app-site-association
https://developer.apple.com/documentation/safariservices/supporting_associated_domains_in_your_app#3001215
Any plans to update the plugin?

Hello.
Actually, I'm not sure. We have not use this plugin in months, and we are not active working on it right now. But we are open for PR.
Note that we cant event test the PR but if the community approve the PR we will merge it without problem.
I hope this solve your question.
Thanks


Deadlock in ASAN leak detection on exit

Describe the bug
Running sanitycheck with address sanitizer (ASAN) enabled could lead to deadlock on native_posix_64 board. The deadlock occurs during program exit and if the leak sanitizer (LSAN) functionality is disabled the deadlock does not occur.
Note that the problem does not occur on native_posix board as LSAN is not supported on i386.
To Reproduce
Based on PR https://github.com/zephyrproject-rtos/zephyr/pull/19093
Steps to reproduce the behavior:

sanitycheck -N -p native_posix_64 --enable-asan --enable-lsan
wait for deadlock

Expected behavior
No deadlock occurs
Impact
LSAN functionality can not be used in CI run
Environment

OS: Linux
Toolchain: Host (gcc (Ubuntu 7.4.0-1ubuntu1~18.04.1) 7.4.0)
Version: PR https://github.com/zephyrproject-rtos/zephyr/pull/19093 with as base c1ea45280bffc4a43037a56893a6644bc6520e46

Note that deadlock is also seen in CI runs
Additional context
GDB Debug info:
(gdb) i th
  Id   Target Id                                                Frame
* 1    Thread 0x7f32e9966780 (LWP 24999) "zephyr.exe"           0x00007f32e88b9eee in ?? () from /usr/lib/x86_64-linux-gnu/libasan.so.4
  2    Thread 0x7f32e42fe700 (LWP 25002) "zephyr.exe" (Exiting) 0x00007f32e88b9eee in ?? () from /usr/lib/x86_64-linux-gnu/libasan.so.4
  3    Thread 0x7f32e3afd700 (LWP 25003) "zephyr.exe" (Exiting) 0x00007f32e88b9eee in ?? () from /usr/lib/x86_64-linux-gnu/libasan.so.4
  4    Thread 0x7f32e32fc700 (LWP 25004) "zephyr.exe" (Exiting) 0x00007f32e88b9eee in ?? () from /usr/lib/x86_64-linux-gnu/libasan.so.4
  5    Thread 0x7f32e4aff700 (LWP 25005) "zephyr.exe" (Exiting) 0x00007f32e88b9eee in ?? () from /usr/lib/x86_64-linux-gnu/libasan.so.4
  6    Thread 0x7f32e2afb700 (LWP 25006) "zephyr.exe" (Exiting) 0x00007f32e88b9eee in ?? () from /usr/lib/x86_64-linux-gnu/libasan.so.4
  7    Thread 0x7f32e22fa700 (LWP 25007) "zephyr.exe" (Exiting) 0x00007f32e88b9eee in ?? () from /usr/lib/x86_64-linux-gnu/libasan.so.4
  8    Thread 0x7f32e1af9700 (LWP 25008) "zephyr.exe" (Exiting) 0x00007f32e88b9eee in ?? () from /usr/lib/x86_64-linux-gnu/libasan.so.4
  9    Thread 0x7f32e12f8700 (LWP 25009) "zephyr.exe" (Exiting) 0x00007f32e88b9eee in ?? () from /usr/lib/x86_64-linux-gnu/libasan.so.4
  10   Thread 0x7f32e0af7700 (LWP 25010) "zephyr.exe" (Exiting) 0x00007f32e88b9eee in ?? () from /usr/lib/x86_64-linux-gnu/libasan.so.4
  11   Thread 0x7f32e02f6700 (LWP 25011) "zephyr.exe" (Exiting) 0x00007f32e88b9eee in ?? () from /usr/lib/x86_64-linux-gnu/libasan.so.4
  12   Thread 0x7f32dfaf5700 (LWP 25012) "zephyr.exe" (Exiting) 0x00007f32e88b9eee in ?? () from /usr/lib/x86_64-linux-gnu/libasan.so.4
  13   Thread 0x7f32df2f4700 (LWP 25013) "zephyr.exe" (Exiting) 0x00007f32e88b9eee in ?? () from /usr/lib/x86_64-linux-gnu/libasan.so.4
  14   Thread 0x7f32deaf3700 (LWP 25014) "zephyr.exe" (Exiting) 0x00007f32e88b9eee in ?? () from /usr/lib/x86_64-linux-gnu/libasan.so.4
  15   Thread 0x7f32de2f2700 (LWP 25015) "zephyr.exe" (Exiting) 0x00007f32e88b9eee in ?? () from /usr/lib/x86_64-linux-gnu/libasan.so.4
  16   Thread 0x7f32ddaf1700 (LWP 25016) "zephyr.exe" (Exiting) 0x00007f32e88b9eee in ?? () from /usr/lib/x86_64-linux-gnu/libasan.so.4
(gdb) bt
#0  0x00007f32e88b9eee in ?? () from /usr/lib/x86_64-linux-gnu/libasan.so.4
#1  0x00007f32e88c842c in ?? () from /usr/lib/x86_64-linux-gnu/libasan.so.4
#2  0x00007f32e88c8758 in ?? () from /usr/lib/x86_64-linux-gnu/libasan.so.4
#3  0x00007f32e7e51615 in __cxa_finalize (d=0x7f32e8b0f420) at cxa_finalize.c:83
#4  0x00007f32e87dce03 in ?? () from /usr/lib/x86_64-linux-gnu/libasan.so.4
#5  0x00007ffe29e7ceb0 in ?? ()
#6  0x00007f32e9787b73 in _dl_fini () at dl-fini.c:138
Backtrace stopped: frame did not save the PC
(gdb)

Deadlock does not occur when using LLVM/CLANG instead of GCC.
Tested with PR #19093 + PR #19589 with as base c1ea452.
Test cmd: ZEPHYR_TOOLCHAIN_VARIANT=llvm sanitycheck -N -p native_posix_64 --enable-asan --enable-lsan

@vanwinkeljan Which particular sample/test is crashing?

@vanwinkeljan Which particular sample/test is crashing?

Unfortunately it is a moving target and it is not always the same test that hangs.
In my last runs it was tests/net/traffic_class/net.traffic_class.rx_5_tx_7
Before you look further in to this issue I would like to try with static linked lib ASAN, this is the main difference between llvm and gcc (assuming it is not a plain bug in the GCC LSAN implementation).

Running sanitycheck with static linked GCC libasan still result in a deadlock but results in a more useful stack trace
(gdb) attach 21872
Attaching to program: sanity-out/native_posix_64/tests/bluetooth/gatt/bluetooth.gatt/zephyr/zephyr.exe, process 21872
[New LWP 21875]
[New LWP 21876]
[New LWP 21877]
[New LWP 21882]
[Thread debugging using libthread_db enabled]
Using host libthread_db library "/lib/x86_64-linux-gnu/libthread_db.so.1".
0x0000564af2a4264e in __sanitizer::BlockingMutex::Lock() ()
(gdb) bt
#0  0x0000564af2a4264e in __sanitizer::BlockingMutex::Lock() ()
#1  0x0000564af2a5c53c in __lsan::CheckForLeaks() [clone .part.29] ()
#2  0x0000564af2a5c868 in __lsan::DoLeakCheck() ()
#3  0x00007fe4c3a04615 in __cxa_finalize (d=0x564af2ce28a0) at cxa_finalize.c:83
#4  0x0000564af2976673 in __do_global_dtors_aux ()
#5  0x00007ffc54d5caa0 in ?? ()
#6  0x00007fe4c49a3b73 in _dl_fini () at dl-fini.c:138
Backtrace stopped: frame did not save the PC
(gdb) i th
  Id   Target Id                                                Frame
* 1    Thread 0x7fe4c4b82780 (LWP 21872) "zephyr.exe"           0x0000564af2a4264e in __sanitizer::BlockingMutex::Lock() ()
  2    Thread 0x7fe4c02fe700 (LWP 21875) "zephyr.exe" (Exiting) 0x0000564af2a4264e in __sanitizer::BlockingMutex::Lock() ()
  3    Thread 0x7fe4bfafd700 (LWP 21876) "zephyr.exe" (Exiting) 0x0000564af2a4264e in __sanitizer::BlockingMutex::Lock() ()
  4    Thread 0x7fe4c0aff700 (LWP 21877) "zephyr.exe" (Exiting) 0x0000564af2a4264e in __sanitizer::BlockingMutex::Lock() ()
  5    Thread 0x7fe4bf2fc700 (LWP 21882) "zephyr.exe" (Exiting) 0x0000564af2a4264e in __sanitizer::BlockingMutex::Lock() ()
(gdb) thread 2
[Switching to thread 2 (Thread 0x7fe4c02fe700 (LWP 21875))]
#0  0x0000564af2a4264e in __sanitizer::BlockingMutex::Lock() ()
(gdb) bt
#0  0x0000564af2a4264e in __sanitizer::BlockingMutex::Lock() ()
#1  0x0000564af2a57c55 in __sanitizer::ThreadRegistry::FinishThread(unsigned int) ()
#2  0x0000564af2a40d97 in __asan::AsanThread::Destroy() ()
#3  0x00007fe4c3fd0408 in __nptl_deallocate_tsd () at pthread_create.c:300
#4  0x00007fe4c3fd181b in __nptl_deallocate_tsd () at ../sysdeps/nptl/futex-internal.h:200
#5  start_thread (arg=0x7fe4c02fe700) at pthread_create.c:473
#6  0x00007fe4c3ae288f in clone () at ../sysdeps/unix/sysv/linux/x86_64/clone.S:95

Tested with static linking against gcc-9 (Ubuntu 9.2.1-9ubuntu2~18.04.1) 9.2.1 20191008 and issue still occurs. Looks like a bug in the GCC ASAN implementation, only short term workaround I see is to shutdown threads before calling exit.

Alternative solution to this issue would be to change the compiler to llvm if ASAN is enabled.

Alternative solution to this issue would be to change the compiler to llvm if ASAN is enabled.

We cannot add this kind of dependencies. We could add a note in the Kconfig option warning people about deadlocks with gcc and ASAN, but not prevent people from using it or force them to use something else.

@aescolar A workaround for this problem could be to disable at exit leak checking for GCC with the code snippet below, this still leaves the option to the user to enable it by setting it in the ASAN_OPTIONS environment variable ASAN_OPTIONS="leak_check_at_exit=1".
Code Snippet:
const char *__asan_default_options() {
       return
#if defined(CONFIG_64BIT) && defined(__GNUC__) && !defined(__clang__)
               /* Running leak detection at exit could lead to a deadlock on
                * 64-bit boards if GCC is used.
                * https://github.com/zephyrproject-rtos/zephyr/issues/20122
                * */
               "leak_check_at_exit=0:"
#endif
               "";
}

Looks like running  __lsan_do_leak_check in the ON_EXIT native task handler does not deadlock LSAN (at least locally for me).

Possibly related GCC bug https://gcc.gnu.org/bugzilla/show_bug.cgi?id=88791


Proper use of Bounding Box

Currently the bounding box is not very much in "use" cause one can still draw outside the bounding box. In reality since voxelart is similar to pixel art and the bounding box should serve as a canvas (like in 2D). It would be nice if bounding box was the only "drawable" portion, not only will it be a good usability improvement, it would also optimize/improve most internal features eg the exporter and #210.

At most I would replace it with an infinite floor where you can draw voxels, I use box wall currently to take height to my project because i can not draw on Y axis (instead of clicking so much on a tower of voxels)

That will be a disaster if we implement the face tool, so i think it wrong

The best solution is to set a reasonable size as the default bounding box eg 126,  you can then expand it (currently supported)  to fit your needs.

Why face tool is a disaster? How can I expand the bouncing box?

In simple term the max size supported  by voxelshop is the max size of an Integer. If we made the ground that size, using the face to fill the ground like in MV will probably crash on most computers. There is an arrow button below the bounding box button,  clicking on the button will show the input for changing the bounding box size,  I wonder why such an important function was hidden behind a button.

this limit comes from Java?
Something that really worries me is VS performance, I tested those days Magica Voxel and I really can build complex voxel art more faster than in VS (more faster, but the result is less efficient for games)
In Voxel Shop a simple project of 400 voxels begins slowing down the program on my computer (i7-4720HQ, nvidia GTX 970M, SSD rom, 16 Gb ram DDR4)
I use PHPStorm commonly (based on Intellij IDEA, built in Java too)
Some years ago they have several performance problems but finally they solve this (I did not followed their development so I do not know how)
Intellij IDEA is open source so probably you can learn something from their repo (how they manage large files or how they manage program task or if they are using some libraries for performance)
Android Studio (by Google) is based on Intellij IDEA too

Yeah the limit is from java. Magicavoxel will be faster than voxelshop due to fact that most of it current limitations were due to performance consideration e.g it 126 max size and it was written in c++ (although that doesn't matter much). It's true that VS begins to get slow when working with large models and even Magicavoxel that am running via wine tends to perform better but i think that's due to multiple reasons and i wish simlu  would be able to look into this.

I'm a little lost with performance I do not know how to improve this part, it requires more deep knowledges, but sure with all our help @simlu will find the way to solve this

No no no, the issue does not come from Java. There are two parts here:
(1) Data structure
(2) Rendering
Why you are currently experiencing slowness is bc of rendering. I'm using a software renderer to be compatible easily with all os.
The next step then is to change the data structure. That is important for undo / redo operations and for really large objects...

Im planning to address rendering first.

Sounds nice @simlu

Nice to hear, but the limit i was talking about was Integer.MAX_VALUE.

Yeah, that's an implementation detail and not the reason why it's slow. In general you are right, but it's not the limiting factor here.

Nooooo,  am not saying that's why it's  slow, am just saying making the default ground size that amount will be unrealistic and will probably cause more issues.

There is an implicit limit ~pow(MAX_INT, 1/3)

Im not opposed to an infinite ground... Not sure how it would display.

Never saw that :D.. Infinite ground? Are you not bothered about performance?

Well, by infinite I meant ~pow(MAX_INT, 1/3)

not infinte, but if it follows the camera movement? like side-scrolling games

anyway, I do not know that I can change their size, with this option bounding box is more than done to go
A infinite floor does not needs attention at this moment

I'm reworking milestones atm around performance improvements. Closing this as it went way off of topic. Created a new issue here: https://github.com/simlu/voxelshop/issues/216


Add Hacktoberfest label to repo

Add Hacktoberfest tag at the top of your repo October 1, 2020 and create hacktoberfest label in issues.

👍🏻 will make some issues this month that would be good to tag


pull request for e2e test at 01/10/2017 21:26:14

:white_check_mark: Validation status: passed
For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


[QUEUES] Fix formatting

في الأربعاء، ١٢ يوليو ٢٠٢٣ ٥:٥٢ م Maddy @.***> كتب:

Closed #9827 https://github.com/cloudflare/cloudflare-docs/pull/9827.
—
Reply to this email directly, view it on GitHub
https://github.com/cloudflare/cloudflare-docs/pull/9827#event-9800509166,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AWV6NCTVSX45P6VWI6IWVBTXP22ZFANCNFSM6AAAAAA2HTCDCM
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***
com>


Portal direction pairing option

Will need some help with setting the option up more properly. I just added it to the randomizer settings menu. It is incompatible with fixed shop, and so if one is on, the other must be off.
Also this PR contains https://github.com/silent-destroyer/tunic-randomizer/pull/65

Found it fails sometimes, drafting until I can find a sufficient way to deal with those failures.

It now works, but also the option is still messy, and idk what to do with it


Bugfix: Readme example sigsegv

When the requested server is completely non-responsive, and err!=nil,
res will be nil. The references to StatusCode and Body.Close() will
cause a SIGSEGV. If err!=nil, don’t reference res.
12:21:45:~/gowork/src/play/apistatus$ ./apistatus
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x10 pc=0x2357]

goroutine 20 [running]:
panic(0x2150e0, 0xc42000c0e0)
	/usr/local/go/src/runtime/panic.go:500 +0x1a1
main.pinger(0xc420074ae0, 0x25f58e, 0x26)
	/Users/adam/gowork/src/play/apistatus/apistatus.go:51 +0x57
created by main.main
	/Users/adam/gowork/src/play/apistatus/apistatus.go:19 +0x99

Hi @adambrakhane - thanks for pointing this issue out.  I agree it needs to be fixed.
Thanks for contributing to this open source project and Thank You!


Add additional configuration for SSL keystores

When connecting to a secure MQ Channel, a personal SSL certificate (private key) may be required to establish TLS.
This should be supported in some way.
I suggest providing two JKS files (as paths on the local filesystem), each with their respective password as well, to serve as "TrustStore" and "KeyStore". Those will be optional in the configuration, so the change will be backward compatible.
I am providing a pull request with my implementation.

Please have a look at #45

I did not take fully into account what is written in the README.md when describing my issue first. Sorry for that, please let me elaborate:
Yes, in fact TLS mutual auth. will work if one adds a personal certificate to a workers JVM.
But - I think it is not much of an unusual case running multiple different connectors on a worker.
This bears several problems:

Sharing a single private key is not always desirable
Having multiple different private keys in the same JVM keystore cannot work afaik (how is the correct key selected for a specific connection?)
A JKS type keystore password must exactly match the private key encryption password, otherwise decryption fails

Also, the PR must include a statement of acceptance of the Contributor License Agreement (see CLA.md).

Thanks for the PR. Merged.


feat: support deepseek

The DeepSeek API reduces costs through disk caching, and DeepSeek-Coder-V2-0724 achieves GPT-4-Turbo-0409 level code capabilities with excellent math and reasoning skills.

LGTM!


tutorial download pirate DRM content with this extension

THIS TOOL IS TO PIRATE DOWNLOAD content with drm
Here I leave the steps in a very supportive way and zero selfishness
they will need these tools
(just google them and you will find them easy)

Bento4-SDK-1-6-0-637.x86_64-microsoft-win32
Widevine L3 Decryptor plugin
N_m3u8DL-CLI_v2.9.7_with_ffmpeg_and_SimpleG

Steps

install Widevine L3 Decryptor on chrome 88 (does not work on later versions) or microsoft edge
to install the extension enable developer mode in the extensions section and simply drag the folder
open the video you want to get
for example an HBO MAX USA movie
before starting to play the movie you want to hack, press f12 on your browser.
Inside there go to the console tab and you will get 3 keys that the Widevine L3 Decryptor will give you.
Those 3 keys are for decrypting DRM-encrypted content.
Now go to the network tab and filter on the shipda, in the search line type
mpd
copy the address that comes out and paste it in
N_m3u8DL-CLI_v2.9.7.exe
and you give enter
now select the video resolution or audio quality you need
press enter and it will start downloading in the download folder
then copy the video and rename it for example to
hbomaxvideo.mp4
and go and paste it in the folder
Bento4-SDK-1-6-0-637.x86_64-microsoft-win32 \ bin
then there you open a cmd console for example with shift right click open terminal console
and copy the following

mp4decrypt.exe --key 1: 9c97a0eaed18f201c4386d3a04d57ed4 --show-progress hbomaxvideo.mp4 c: \ Bento4-SDK-1-6-0-637.x86_64-microsoft-win32 \ bin \ video_decrypted.mp4
(video / audio format extension may vary)
and the number
9c97a0eaed18f201c4386d3a04d57ed4
It is the key that the Widevine L3 Decryptor gives you, that key is essential to HACK the movie and REMOVE THE DRM.
You will have to try, one of the keys is for the video, another for the audio and another for the subtitle

and now the most important thing, enjoy the DEENCRYPTED content, totally HACKED

@yolanda123a This is not possible anymore. There are no software, apps, browser hacks, tricks, methods to download DRM protected videos. we are doomed forever.
If you have a working solution to find the content decryption keys, then tell me.

If it helps, I wrote a package for decrypting here:
https://github.com/89z/format/blob/master/dash/decrypt.go


911 display information on geopmap

What does this PR do?

Resolve #911

Steps to test

Run locally, navigate to http://localhost:3000/rewards-distribution
hover mouse over countries, daily rewards and paid producers and see popup

Here's a preview


Hash not being cleared after silent refresh in Firefox

In Firefox, when the token is refreshed by silent refresh, it adds a # automatically in the url and it's not removed from the url.
It only happens in Firefox, I don't have the issue in Chrome.
I even tried to add clearHashAfterLogin: true but it doesn't seem to do anything, the hash is not removed.
I'm using angular-oauth2-oidc(v4.0.2) with Keycloak (4.2.1.Final).
I use the default routing configuration in Angular, so my URLs don't contain any hash.
My auth.config.ts
export const authConfig: AuthConfig = {
  // Url of the Identity Provider
  issuer: 'http://keycloak.local/auth/realms/helloworld',
  requireHttps: false,
  // URL of the SPA to redirect the user to after login
  redirectUri: window.location.origin + '/index.html',
  // URL for silent refresh
  silentRefreshRedirectUri: window.location.origin + '/silent-refresh.html',
  // Timeout before silent refresh is fired, 0.4 => fired when access token expiration time reaches 40%
  timeoutFactor: 0.5,
  showDebugInformation: true,
  // The SPA's id. The SPA is registerd with this id at the auth-server
  clientId: 'my-app',
  scope: 'openid profile email',
};

My app.component.ts
export class AppComponent {
  title = 'app';

  constructor(private oauthService: OAuthService) {
    this.configureWithNewConfigApi();
  }

  private configureWithNewConfigApi() {
    this.oauthService.configure(authConfig);
    this.oauthService.tokenValidationHandler = new JwksValidationHandler();
    this.oauthService.loadDiscoveryDocumentAndLogin();
    this.oauthService.setupAutomaticSilentRefresh();
}

Could you try doing:
this.oauthService.events.subscribe(event => {
  if (event instanceof OAuthErrorEvent) {
    console.error(event);
  } else {
    console.warn(event);
  }
});

and then check if the same (order of) events pop up in Chrome and Firefox ("Preserve logs").
Also, at some point we had similar issues in different browsers, and we just chained this to the discovery loading and login promise chain, at the end:
this.oauthService
  .loadDiscoveryDocumentAnd....()
  // etc
  .then(() => { location.hash = ''; return Promise.resolve(); });

Which I think doesn't hurt (but is a hack/workaround, of course).

Wait, what? I didn't read your original post correctly and had not seen that the silent refresh is causing this. Can you verify/confirm that merely commenting out the setupAutomaticSilentRefresh() will make the problem go away?
If it doesn't, perhaps you could elaborate a bit more about that part? The reason it's confusing to me is that the silent refresh should only do URL-based stuff to the iframe, the location of the top frame (your app) shouldn't be touched. You can see this in the listener for the iframe posting a message which sends the hash in a custom manner to tryLogin (grabbing it from the posted message.
I'm also somewhat confused about the stream of events, because it seems as if there is no output from the ...AndLogin(...) part of your routines. Bit lost why that would be the case.
One final other note, you could try using the slightly different flow I suggested in #359, that doesn't use the convenience overloads but chains all parts itself, allowing you to add some debug statements to find out what's going on in your scenario.

Commenting out the setupAutomaticSilentRefresh() makes the problem goes away.
Actually, as soon as this.authService.silentRefresh() is called, the hash appears.
I tried your flow and it didn't work as expected. this.authService.hasValidAccessToken() always returns true. And even if I remove the condition, since this.authService.silentRefresh() is called, the hash appears.

Actually it doesn't work even with a new fresh project.

That's somewhat good news! Could you please create a StackBllitz example or GitHub repo with the repro? That makes it a lot easier to help.
In addition (or possibly as an alternative) you could have a look at this minimal repro, clone it, and check if that reproduces your problem as well?
Let us know what you find.

Sadly, your repo gives me the same result.
I tried Firefox, Chrome and Edge, only Chrome works fine.

Huh weird, not sure how I can further help then. I've checkout out ca0bbab ran ng serve and opened http://localhost:4200 in a fresh Firefox Private Browsing window. It redirects me to the IdentityServer3 where I log (max/geheim) in and give consent, then I go back to the app and the hash fragment is cleared.
I've also tried this with network throttling, same deal: just works.
I'm using Windows 10 and these versions:

Firefox 61.0.2 (64 bit), no addons
Node 10.8.0
npm 6.3.0
the node_modules tree is pinned using the package-lock so you should have the same

In Edge I also get a cleared hash.
Perhaps there's something in your local setup that's affecting this. Perhaps the above helps you debug what is. If it doesn't, then the only reasonable path for root cause analysis left is using an unminified build of the library and debug it with the Firefox dev tools to see why it's not clearing.
Good luck!

I have to apologize, for not reading your problem description carefully enough...
I thought the hash fragment wasn't being cleared, and that you were worried about the tokens remaining visible in the URL bar. After running your docker image I finally realized that you were talking about the hash itself. Sorry for the confusion!
I actually can reproduce what you mention, I too get the hash in Firefox when clicking 'force silent refresh'.
You're running into this issue because this oauth library uses this code to clear the hash:
location.hash = '';

You can try that yourself, it behaves differently between Chrome and Firefox. Open up a simple site, type in #blahblah at the end of the URL, and then execute location.hash = '' in your devtools. Chrome will clear the hashbang character too, Firefox leaves it.
There is a modern solution to this which can also be polyfilled of course. Place it both in your login chain as well as after your silent refreshes (see lines A/B/C below):
import { Injectable } from '@angular/core';
import { OAuthService, OAuthErrorEvent } from 'angular-oauth2-oidc';
import { filter } from 'rxjs/operators';

@Injectable()
export class AuthService {

  // A!
  private clearHash() {
    // By @AndyE from https://stackoverflow.com/a/5298684/419956
    history.pushState('', document.title, window.location.pathname + window.location.search);
  }

  constructor(private oauthService: OAuthService) {
    // Useful for debugging:
    this.oauthService.events.subscribe(event => {
      if (event instanceof OAuthErrorEvent) {
        console.error(event);
      } else {
        console.warn(event);
      }
    });

    this.oauthService.events
      .pipe(filter(e => e.type === 'silently_refreshed'))
      .subscribe(e => this.clearHash()); // B!

    // login chain
    this.oauthService.loadDiscoveryDocument()
      .then(() => this.oauthService.tryLogin())
      .then(tryLoginResult => {
        if (this.oauthService.hasValidAccessToken()) {
          return tryLoginResult;
        }

        return this.oauthService.silentRefresh()
          .catch(result => {
            const errorResponsesRequiringUserInteraction = [
              'interaction_required',
              'login_required',
              'account_selection_required',
              'consent_required',
            ];

            if (result && result.reason && errorResponsesRequiringUserInteraction.indexOf(result.reason.error) >= 0) {
              this.oauthService.initImplicitFlow();
              return Promise.resolve();
            }

            return Promise.reject(result);
          });
      })
      .then(() => this.clearHash()); // C!
  }
}

I'm not sure about this library's claimed browser support, but from linked SO post it seems it might be good to use the history based solution too.

Your fix works but it has a drawback. It adds a new state in the history each time a silent refresh is triggered.
I'm on a page and the silent refresh is triggered. If I want to go back to the previous page, I'm not going to be on the previous page. It will take me back to the current page with the hash.

Then I think your only other quick option left is living with the fact that Firefox (and friends) will have a hash in the URL after silent refreshes.
The more involved fix could perhaps be to make the library not reset the location.hash to empty string if the fragment wasn't retrieved from the URL in the first place. Then again, that would only solve things for silent refreshes, not for the initial tryLogin call that would use a fragment too.

Could you take a look at oidc-client-js (https://github.com/IdentityModel/oidc-client-js) ?
I don't have the issue with it. However, I don't understand how it handles the silent refresh (JS is not really my thing... Otherwise I would have already done it).

😄 Hmm, no sorry, I'm not very familiar with the other library, you will have to investigate yourself or with help of a colleague, friend, or (possibly paid) trainer to see how it works. (I also think the GitHub issues list for angular-oauth2-oidc is not really the place to discuss how another library works...)

Yes, I understand. Thank you for your help :smile:

@shambarick I've posted a workaround to this in #493.  In short, you can side-step the issue by turning off clearHashAfterLogin after processing your initial login.


validation: Add config validation mode. (#499)

This adds a --mode command-line flag. --mode=serve is the default and can be omitted; in that mode Envoy runs as it always has.
With --mode=validate Envoy checks that the configuration file in --config-file is valid, then exits. "Valid" means that it performs the JSON schema check as usual, but also initializes as much of its internal state as possible, exiting with any errors as it would under --mode=serve. When initialization is complete, instead of listening for traffic, Envoy prints an "OK" message to stderr and exits, returning success.
In validation mode, to the extent possible, Envoy avoids interfering with its environment. For example, the hot-restart process is skipped, so validation can safely be run on the same machine as a serving Envoy.  Validation mode also doesn't send any upstream traffic or open any listeners.
It does attempt to read any files referenced in the config, like certs and private keys, so validation will fail if those files aren't located at the expected paths. A future "lite validation" mode, that mocks out the filesystem as well as the network, is not yet implemented as of this patch.

@mattklein123: As we talked about a while ago, this ended up having a fair number of tentacles mocking out different parts of the class structure. Comments on how you'd organize it differently are more than welcome.
Remember I'm still reasonably new to the language, so if anything's surprising in here, there's no subtle genius, just wrongness. :)

Nit: why --mode=validate instead of --test or --dry-run?

Thanks @rlazarus ! @htuch and @junr03 can you take a first pass?

I'm wondering whether it would have been better to set a global dry_run flag and condition on the existing code paths for server initialization rather than create the bifurcated initialization in this PR? I feel it's going to be an ongoing maintenance issue to keep the two in sync. But, I haven't explored this other alternative, so please let me know what your thoughts are.

FWIW, @rlazarus and I discussed this a while back and decided to go with the "mock" solution. The general thinking was that plumbing a dry_run param through the code would make the primary server logic harder to read and more complicated and the flag would have to go into a lot of places since this testing is doing semantic testing, not just JSON validation. In some sense, it's doing mocking without using gmock. I agree with @htuch that in some sense this is ugly, but on the other hand I think we need to choose between 3 ugly options: 1) Do this. 2) plumb dry_run through a ton of places. 3) Actually use gmock and the test mocks in prod code. I still think #1 is the least ugly, but let's discuss tomorrow if we need to all get on the same page.

One other random thought for discussion tomorrow. Assuming we keep this approach, I think it would be good to switch the ExampleConfig test over from gmock to use these "mocks." This will help us get better test coverage:
https://github.com/lyft/envoy/tree/master/test/config_test
Eventually also probably the router test tool that @hennna wrote.

What's the strategy the maintenance ? I haven't looked into the code (so feel free to say "go look st the code :)" ). If I were to introduce a new feature, is there a structure in place that can be followed to keep adding more stuff to the validation logic ?
How is RDS, CDS and SDS validated ? (I am going totally by the PR description. )
On a side note, it seems that all you want to accomplish here is to ensure that Envoy initializes without perturbing the environment. From that perspective, reads of any form are okay right (from files, dns, etc). It's the writes that complicate things (pushing stats, and making requests). Rather than validating from inside Envoy, why can't you validate externally observable behavior (e.g. expect connection to foo.bar.com with so and so headers) using an external sink/request gen ? (This is not same as using gmock in prod code). You could emulate the external environment without Envoy knowing about it (like the nginx perl tests?). Not sure if this covers the use cases you are looking for.

@rlazarus @htuch was there any offline conversation about this? Is it ready for wider review? I also need to sync with @junr03 tomorrow on whether this meets our internal needs / what might be missing (somewhat related to questions from @rshriram). In general I think if we convert example config tests away from mocks and to this stuff I'm more comfortable (haven't looked at whether that was done yet or not).

@mattklein123 I need to give this another pass with a broad "it's probably the cleanest way we have to handle this" notion in mind. Will try make this happen today.

@rlazarus can we move this PR forward? Would like to try to get it merged or close for now.

@mattklein123 Yes -- I've already been working with @htuch today to get it out the door ASAP.

@rlazarus can you quickly merge master and re-push?

This is a general problem with death tests too, the lines tested don't get counted because the coverage data is never flushed.  I found some discussion of possible solutions online but none of them seemed to work.

I don't think gcov has support for this, but lcov does http://ltp.sourceforge.net/coverage/lcov/geninfo.1.php. We probably want to switch to lcov anyway for clang coverage support, I've filed https://github.com/lyft/envoy/issues/1000 to track. This is slightly different to the issue that @dnoe reports, which is more an issue in gtest I think.

@htuch Assuming Travis smiles upon this, it's ready for another look. Nits more than welcome.

@junr03 If you have any further comments from the Lyft side please let us know. Based on Matt's high-level approval and the current state of the code, I'll merge tomorrow otherwise once @rlazarus has addressed the last few comments. Thanks.

@rlazarus Can you improve the coverage here so bazel.coverage passes again?

Frustrating: Merging master seems to have taken us from just above the code coverage setpoint to just below. I'll see if I can effectively cover the NOT_IMPLEMENTED lines with a death test, because there's not much else to do.

Right -- that's what @htuch and I are looking at, I pushed that commit so he could patch it in.

If it helps I found reference to manually calling __gcov_flush although at the time I was investigating the signal handler code wasn't in place yet.  It might be possible to easily integrate __gcov_flush call now that the custom signal handlers are installed.

@rlazarus Looks like some minor bit rot to fix.


Expand env vars in Pipfile

Documentation says it's possible to use environment variables in source urls (https://docs.pipenv.org/advanced/#injecting-credentials-into-pipfiles-via-environment-variables), but it doesn't seem to be the case at the moment. Here's a fix that works for me.

Yeah I think it’s still an open issue :-/
On Tue, Apr 17, 2018 at 6:09 AM Dan Ryan<EMAIL_ADDRESS>wrote:

@jtratner https://github.com/jtratner @uranusjr
https://github.com/uranusjr I feel like ther was some issue with
expanding environment variables everywhere - do you guys remember anything
about that?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/pypa/pipenv/pull/1986#issuecomment-381985128, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ABhjq7Ha6zXYRBbDdNxWGGJ0arP9OFZlks5tpemOgaJpZM4TTYaw
.

Closing this in favor of integrated version that takes advantage of new functionality, thanks for the PR though and sorry for the delayed feedback!


Update for 0.59.0 final

All included patches only affect documentation and the testsuite; thus do not require a new RC.

BFID: numba_yaml_425

BFID: numba_yaml_426

BFID: numba_yaml_426

This passed.


Cleanups and examples

Add codeql scan
Use newer isort (5)
Add usage example
Add conventional venv to .gitignore

Codecov Report

Merging #6 into master will decrease coverage by 0.08%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master       #6      +/-   ##
==========================================
- Coverage   96.69%   96.61%   -0.09%
==========================================
  Files          15       15
  Lines         242      236       -6
  Branches       13       13
==========================================
- Hits          234      228       -6
  Misses          5        5
  Partials        3        3

Impacted Files
Coverage Δ

laituri_tests/test_docker_v1.py
91.04% <0.00%> (-0.63%)
:arrow_down:

laituri/utils/retry.py
100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aa4e752...46c955f. Read the comment docs.


Migrate to fluent

Fluent seems to be a much superior translation system than the current implementation via vm. However, our fluent plugin won't support Deno, despite the demand.
I suggest to:

Take the code in https://github.com/dcdunkan/grammy-fluent
Refactor it in a way that resembles the code style and spirit of this repo
Maybe bring back any missing features in case they exist
Release this as i18n 2.0

As a result, we would get Deno support, a better translation system, and a reactivation of this project.
@dcdunkan has offered to assist in this, but prefers not to become the maintainer of i18n.
This is a suggestion by me, who does not actually use the plugin, so take it with a grain of salt.
@EdJoPaTo @HeeroML @dcdunkan (and @roj1512 because I know you like the fork) how much time are each one of you willing to spend on this, irrespective of whether or not you'd be the main person in charge? If it's just about who is responsible, I don't mind taking that role and then in turn pinging you guys if something needs to be fixed that exceeds my knowlege of this plugin :)

I will happily review PRs and so on!
I don't have that much time currently and I don't actively work on any projects using either Telegram bots or fluent currently. I only maintain my existing ones. Therefore I sadly don't have much personal interest in getting this advanced at the moment (besides wanting to see Deno for all the things :sparkles: and wanting to get this i18n / fluent mess sorted out as I dislike seeing the current state of it)

@ngdangtu-vn would you want to work on this?

@ngdangtu-vn would you want to work on this?

Thanks for the offer, and sorry for being late. Where should I start because dcdunkan already seem to work on it :D

How many hours requirement for me to be the maintainer?

Then sign me in. I will do a review on #20 later on today.


Youtube PlayList Data Fetch

Fetching Video data from ReactPlay youtube Playlist.

@Abhishek-90 don't commit the yarn lock file

Delete yarn.lock file


cleanup: remaining statsig-js references

🚀 Deployed on https://670020460c21d77ac54deb6e--cozy-fox-0defec.netlify.app


How to access Dynamo DB Amplify generated table names for transaction based queries in AppSync

Note: If your question is regarding the AWS Amplify Console service, please log it in the
AWS Amplify Console repository

Which Category is your question related to?
API GraphQL
Amplify CLI Version
5.3.1
You can use amplify -v to check the amplify cli version on your system
What AWS Services are you utilizing?
AppSync, Dynamo DB
Provide additional details e.g. code snippets
AppSync supports Dynamo DB transaction based queries and mutation[1]. The syntax demands the table names to be specified in the request mapping template as shown below:
{
    "version": "2018-05-29",
    "operation": "TransactWriteItems",
    "transactItems": [
       {
           "table": "<table-name>",
           "operation": "PutItem",
           "key": {
              "id": $util.dynamodb.toDynamoDBJson($ctx.args.input.id)
           },
           "attributeValues": $util.dynamodb.toMapValuesJson($context.args.input),
       }
    ]
}

However, when using the Amplify CLI to create GraphQL API, Amplify generates the Dynamo DB table names randomly such as [resource-name]-[random-string]-[env-name]. so currently there is no way to access the table name in the custom resolver mapping template[2] that I know of. Is there a way to access the table names within the resolver mapping template?
[1] https://docs.aws.amazon.com/appsync/latest/devguide/tutorial-dynamodb-transact.html
[2] https://docs.amplify.aws/cli/graphql-transformer/resolvers

Hello @rosmu,
For the table-name the middle [random-string] you should be able to use the AppSync GraphQL API ID.
Closing as question has been answered. Should you have any issues please comment below to reopen.

Could you show us the example in VTL templating language how to access the API ID, and environment name and the model name? that will give us an idea on how to implement the same.

Hey @rosmu :wave: just wanted to follow-up here and see if the workaround noted above worked for you?

Closing due to inactivity


Is it possible to identify multiple fingers?

For example, if finger 1 is scanned do something, and if finger 2 is scanned, do something else?

BTW, the sample here
http://developer.android.com/samples/FingerprintDialog/index.html
doesn't work like the reop here.

Hi,
It's not possible. Registered fingerprints are treated equally.

Why ? It could be cool...
For example, I could set that each would do something else.
I could even make a gesture if the fingerprint sensor supports it... :(

Because each registered fingerprint can unlock device for the account who registered the fingerprint equally. At least for now, these are treated as equally.
Maybe in the future, there is a change that identify multiple fingerprints. But current Android M doesn't support it.

Can you please consider adding it?
It could even be cool as non-secure feature, so that for the foreground app, you could choose to have events for what happens for each type of finger.
It could also perform tasks via the lock screen itself : call a specific person, open Google,...

@AndroidDeveloperLB Actually it's possible (through hidden API). See FingerprintManager.java#258 .

Cool, but using it might break in future releases.

I am sorry for reopen this thread, I got a problem that I have to identify which fingerprint (registered) is scanned? For now I don't know is android support, or how to implement using hidden API? Can anyone give me an idea?

@dientm Using reflection.

@mariotaku: thank for your reply but actually I dont have to much experience with android. Can you show me some example of reflection in android?

@dientm https://code.tutsplus.com/tutorials/learn-java-for-android-development-reflection-basics--mobile-3203

@dientm  u did this multiuser fingerprint authentication?

I am also looking for this solution.

OK I wrote a suggestion about this here:
https://issuetracker.google.com/issues/112066297

I am closing this issue/PR, as it has been migrated to the new repo linked above in the comments. Thank you!

Thanks. Sadly it was closed to open a new one, so made it here:
https://issuetracker.google.com/issues/140661939


Dynamically showing/hiding labels in response to mouse events

I set up mouse enter and leave events to dynamically show labels when the user mouses over the annotation:
    enter({ chart, element }) {
      if ('label' in element.options && element.options.label) {
        element.options.label.enabled = true;
        chart.draw();
      }
    },
    leave({ chart, element }) {
      if ('label' in element.options && element.options.label) {
        element.options.label.enabled = false;
        chart.draw();
      }
    },

This was based off of the old horizontal-line.html sample.
This worked fine until chartjs-plugin-annotation 1.2.0 - specifically, #547. If I'm understanding correctly, the changes in #547 cause labelVisible to be precalculated so that it no longer responds to changes in enabled.
I tried fixing this by calling chart.update() instead of chart.draw(), but things still didn't work. I think the code is using its options proxy and context to retrieve the original annotation options object, instead of the dynamically updated element options, but I'm not sure that I fully understand how contexts and options proxies work.
I can directly access the original chart options, but that feels ugly (if using TypeScript, due to its optional properties, and if annotations are in an array instead of keyed by unique ID):
        chart.options.plugins.annotation.annotations[0].label.enabled = true;

Is dynamically updating element options supported? What's the proper way to do it?
Thank you.

@joshkel there is a sample which is addressing your use case, which is directly access the original chart options:
https://www.chartjs.org/chartjs-plugin-annotation/latest/samples/line/labelVisibility.html
The label is precalculated in order to enable the the animation.
In my opinion the proper way should be to change the original options and invoke the chart.update.

The element options are the ones resolved at update and get overwritten in update. Animations might update those too. So it's essentially view state of the element and in that sense your approach seems reasonable.
I'd rather have things working without the need to call update from a event hook, because it can be an expensive call.

@joshkel I have prepared a codepen https://codepen.io/stockinail/pen/abyrGav
Leveraging on context persistence, you can store the status hovered in the context and define enabled option as scriptable.
label: {
 backgroundColor: 'red',
 content: 'Test Label',
 enabled: (ctx) => ctx.hovered,
},
enter(context) {
 context.hovered = true;
 context.chart.update();
},
leave(context) {
 context.hovered = false;
 context.chart.update();
},

This is the way used also in other plugins (see Datalabels).
Of course I agree with @kurkle about the usage of update() which can be expensive but I don't see another way now.
I'm playing with animations configuration in order to enable the usage of labelVisible property. Maybe I can find another way to do it, without invoking  update(). Maybe using specific transitions (showLabel and hideLabel).

@kurkle I see a potential issue. intersects method is not considering the borderWidth. That means when you are hovering a line with a borderWidth >1, the event is fired only when the mouse is hover the center of the line. Before opening an issue, I'd like to so some additional tests.

I'll consider this a bug. In a related note, chart.js allows plugins to set args.changed, so the chart can re-render automatically after processing the event completely. This is important when there are many plugins that require re-draws. It gets slow and messy if every plugin does the draw (or update!) in their event handlers.
So I think these handles should be allowed to set/return a flag indicating a redraw should be done.


Fix input device processing

As discussed in #97 this fixes the input device processing not processing more than one "read" even when the callback indicates there is more data to be processed.

Awesome! Thank you very much!


Refactored AABB to use 2 vectors, added docs

Description
This is a refactor of the old implementation for AABB collision detection.
Fixes #5
Type of change

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[x] This change requires a documentation update

Checklist:

[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[ ] I have added tests that prove my fix is effective or that my feature works

As I said before, looks great. Thanks for your contribution! :)


Implement RFC 5228

Because apparently it obsoletes RFC 3028.
https://tools.ietf.org/html/rfc5228

This is pretty much done.


Cell Styling

Hello!
I was taking a look at the OpenXML format for styling at cell level or even at Table level. Nothing too powerful but at least allow a minimal amount of formatting (font styling / bgColor). I believe that this can increase the bundle size but not in a big scale. My question is more, What is the bundle size / minimum feature proportion to consider such a change?
Maybe we can define the feature:
Add solid background color.
Add font styling such as italic/bold/under
Add font alignment center/right(default)/left
I am doing a bit on work about this but I want to know if I should consider PR 😄

I think I'll err to the answer I've previously given, that features like these would be lovely. I think they should come in some kind of plugin structure, so consumers can still get a minimal bundle if they don't need anything else.

I totally agree with the vision and actually I quite like the job that has been done here (it's impossible to get a non overkilling xlsx exporter library). Is there a roadmap to achieve a plugin hierarchy? Some proposal? I would love to contribute more to this.

Not at all. It's not something I have personally pursued, so it would have to be a community effort 🙂

I see and understand your position regarding the smallest possible library.  I think it might be shortsighted since without styling, formulae, multiple sheets or charts there is no reason to use this over a plain csv file.
a simple solution: make a standard add-on syntax like this (add col definition to sheet object) cols:[{width:150},{width:75}] and an article about how you would add a handler to the code.  it is OK to make us work for it, but as it stands I don't see any reason to use zipcelx.

@jphardman Reason is simple: MS Excel sucks at importing CSV. That's why we adopt zipcelx in my previous company.

@egeriis I think I'll err to the answer I've previously given, that features like these would be lovely. I think they should come in some kind of plugin structure [...]

I totally agree with it. The question is: how to make zipcelx modular. Because right now, we just return strings.
Maybe instead of strings, we should use DOM Methods. This way we can add hooks for plugins.
I.E:
export generatorNumberCell (index, value, rowIndex) => (`<c r="${generatorCellNumber(index, rowIndex)}"><v>${value}</v></c>`);

const generatorNumberCell = (index, value, rowIndex) => (`<c r="${generatorCellNumber(index, rowIndex)}"><v>${value}</v></c>`);

Become

const generatorNumberCell = (index, value, rowIndex) => {
	const cell = document.createElement(c);
	c.addAttribute('r', generatorNumberCell(index, rowIndex));

	const cellValue = document.createElement(v);
	v.innerText = value;

	cell.appendChild(cellValue);
}

And then we can call cell hooks and pass to them the new Element.
I.E:
const cell = generatorNumberCell(a, b, c);

plugins.cell.forEach(plugin => plugin(cell));

⚠ Please note that this is not a pure and functionnal way of doing things... so this could easily leads to unexpected problems.
What do you think ?

I gave it a thought for quite some time and never came with a proper solution for a plugin system were you could hook your functions (like adding color to cells, formulas etc etc). Your idea could be a first iteration at least @doliG


Opacity of planes in model is not changed

🐛 on Dev
Steps to reproduce:

Login
select modelling app
Expected: I believe the expected behavior should be that you see the existing plane behind the other.
Actual: Sometimes the plane is visible behind the other plane but othertimes it is not. Was unable affect any change on opacity by clicking on other planes.

Timestamp: 0:00
Video: Loom (https://www.loom.com/share/798beb0969694cbba7b960be522ac35d?sid=fa379deb-5af7-4db1-993c-b1164f22fd8c)
Bug report:
https://app.qawolf.com/zoo/bug-reports/aced5dfc-6b04-424e-ab62-a29a88134635
Affected workflows:
• Validate Variable Name Availability & Remove Variables - https://app.qawolf.com/zoo/workflows/clweyy8kp065v79e089d01kjz
• Inactive for 2 mins - Stream Idle Mode - https://app.qawolf.com/zoo/workflows/clyd2erpw04auw63k2nrf9w4u
If you are aware of this bug you can set the priority to low which will prevent it from causing a run failure.

I can't remember if I asked you about this @mlfarrell?
The video basically shows that sometimes the XY plane is not visible behind XZ

And sometimes it is

I think this is more of a problem for the QA wolf people than it is us because they rely on screenshots much more than we do.
But obviously we should fix it if we think it's bad for users.

OIT for planes is a known issue in engine somewhere.  I'll ref this issue from that or create one if not already.


readinessProbe missing -k for curl

Chart version:
Latest on master has the issue, but originally found on 7.16.3
https://github.com/elastic/helm-charts/blob/main/elasticsearch/templates/statefulset.yaml
a11730e
Kubernetes version:
v1.21.11+31d53a1
Kubernetes provider: E.g. GKE (Google Kubernetes Engine)
OpenShift
Helm Version:
3.3.4
helm get release output
e.g. helm get elasticsearch (replace elasticsearch with the name of your helm release)
Be careful to obfuscate every secrets (credentials, token, public IP, ...) that could be visible in the output before copy-pasting.
If you find some secrets in plain text in helm get release output you should use Kubernetes Secrets to managed them is a secure way (see Security Example).

Output of helm get release

Describe the bug:
Line 292 of the readinessProbe doesn't include -k so it fails if security is enabled.
https://github.com/elastic/helm-charts/blame/8565b30cde0c373bbd2812079c2114bfcf8ed524/elasticsearch/templates/statefulset.yaml#L292
Steps to reproduce:

Deploy chart with security enabled (https)
readiness probes fail

Expected behavior:
readiness probes succeed when security (https) is enabled.
Provide logs and/or server output (if relevant):
Be careful to obfuscate every secrets (credentials, token, public IP, ...) that could be visible in the output before copy-pasting
Readiness probe failed: Waiting for elasticsearch cluster to become ready (request params: "wait_for_status=green&timeout=1s" ) Cluster is not yet ready (request params: "wait_for_status=green&timeout=1s" )

Any additional context:
See https://github.com/elastic/helm-charts/pull/638 for changes that broke it.

On further review, I think -k is being passed in correctly. My use-case is still failing, but due to some other reason.


DragScroll and mousewheelScroll function and arrow keysScroll

Maybe this 3 things are something for a nice addon like localScroll.
You build a very nice scroll engine that could be useful to build addons like

a dragScroll function:
To scroll an element or the window you can mousedown (like a drag) and scroll via the mousedown/drag.

mousewheelScroll:
You can use the mousewheel to scroll any axis you choose...

You can scroll via the arrow keys.
I build a quick thing for this:
jQuery(document).keydown(function(e){
switch( e.keyCode ) {
case 32:
jQuery('.page').scrollTo('+=100px', 10);
break;
case 37:
jQuery('.page').scrollTo('-=20px', 10);
break;
case 38:
jQuery('.page').scrollTo('-=20px', 10);
break;
case 39:
jQuery('.page').scrollTo('+=20px', 10);
break;
case 40:
jQuery('.page').scrollTo('+=20px', 10);
break;
}
});

Whould be nice if you think about these improvements...

Hi, the commit history is all broken. I'm not sure how did you arrange the commits but it's all conflicted. I'd need you to first fix that.
Another point is, if you have an idea for a plugin that depends on scrollTo, the right way to go would be to make it on your Github account and publish it. It doesn't belong within the scrollTo codebase.


Add json files with default data

Add for:

auth
authtoken
employees
categories

Use those files with loaddata, after database cleaning process

Added and published. Reminder: Data are just for development purpose, no real data.


Adding information to the README.md file

Adding information about the types of tools used in developing this tutorial application.

a test comment


Warning! It is target for the newest version

The $(TargetFrameworkVersion) for FFImageLoading.Svg.Platform.dll (v9.0) is greater than the $(TargetFrameworkVersion) for your project (v8.1). You need to increase the $(TargetFrameworkVersion) for your project.

If you were targeting Android or Xamarin.Forms, try upgrading the Target Framework in project properties to API Level 28 (Android 9.0).
This shouldn't on if you had an iOS project.
Note: Upgrading target framework shouldn't affect your app on lower versions of Android, i.e. on Android 8.1 and below your apps works exactly like before; but it does affect your app a bit on newer versions. You'll be telling Android 9.0 that your app is compatible with the latest Android OS, so Android will act accordingly (such as disabling backward compatibility, enforcing new API behaviors, etc.) when running your app.


Can't create e-cash string

I'm able to redeem ecash, but the wallet doesn't respond when I try to create ecash strings.
Upon closing the wallet and reopening it, I get a "draft" entry in the wallet with the following audit trail:
[{"status":"DRAFT","mintBalanceToSendFrom":{"mintUrl":"https://mint.minibits.cash/Bitcoin","balances":{"sat":8979,"undefined":5}},"createdAt":"2024-08-25T20:34:10.548Z"}]

There si likely still some ecash selection issue when preparing the tx (despite recent attempt ti fix)
To fix, please send your whole balance to yourself - as an ecash. Send it to your wallet address or just copy / paste to receive.
This will make the mint to swap your ecash for non problematic notes combibation.

Thanks, it works now :)


Setup password

Based on edk2-platforms UserAuthFeaturePkg, but using EFI variables directly instead of through an SMM handler, which we can't add from within EDK2.
Fixes https://github.com/Dasharo/dasharo-issues/issues/120

This is ready for review now


APIGOV-20072 - when in offline usage reporting mode do not require connectivity to platform

added some documentation on the usage reporting for traceability
do not require central config, except env ID, when offline
do not attempt platform health checks in offline
sample nothing and when validating log events do not check all fields are set as most are not needed
skip retrieving amplify auth token for events not being sampled
fix tests affected by checking of usage reporting offline setting

@vivekschauhan - if you have time to take a look, please


Vulnerability warnings due to outdated package-lock.json

Used the exercism download --exercise=dnd-character --track=javascript command to get the dnd-character exercise.
After executing npm i I got a counter of vulnerabilities at several thousands.
NPM Audit shows it is all about a single library somewhere deep in the dependencies that was fixed  already.
This particular lock file should be regenerated.
And isn't there any planned/automated audit checks to prevent an accumulation of issues like this?

These are automated and come in regularly.
https://github.com/exercism/javascript/blob/master/scripts/sync syncs the package.json. However, we  (iirc) do NOT provide a package-lock.json for the exercise-level. That means that the initial install (the one you do when you pull the exercise) might not actually have the fixes until you run the audit.
In short: you'll see the warnings unless you run audit fix, or when ⬆ upstream is fixed.

This should be fixed by https://github.com/exercism/javascript/pull/702.

It still leaves the issue with npm and locks.

No package versions update were needed to remove the warning - it was addressed in patch versions of related packages already.
It was enough to manually remove lock file and node_modules, then reinstall to clear the warning.
Just checked. 15834 high severity vulnerabilities still reported on fresh install.
If you have another housekeeping routine to update package-lock.json files - that will actually remove the issue.

Created https://github.com/exercism/javascript/issues/703


\Arduino\libraries\TFT_eWidget\src/TFT_eWidget.h:19:26: fatal error: LittleFS.h: No such file or directory compilation terminated.

Probably i make a mistake, but others have the knowhow ^_^
Used HW: esp32 (Wemos D1 R32)
Used platform: Arduino IDE
test: Analogue_meters.ino
ERROR:
In file included from C:\Users\qx\OneDrive\Documents\Arduino\libraries\TFT_eSPI\examples\GUI Widgets\Meters\Analogue_meters\Analogue_meters.ino:18:0:
C:\Users\qx\OneDrive\Documents\Arduino\libraries\TFT_eWidget\src/TFT_eWidget.h:19:26: fatal error: LittleFS.h: No such file or directory
compilation terminated.
Solution:
Change TFT_eWidget.h
// LittleFS is required for touch calibration in TFT_eSPI sketches
#if defined (ESP8266) || defined (ESP32)
#include <pgmspace.h>
#include <FS.h>
///////////new: ********************
#if defined (ESP8266)
#include <LittleFS.h>
#elif defined (ESP32)
#include <LITTLEFS.h>
#endif
///////////End of new**************
#endif

You can add the LittleFS lib from lorol
[env:NodeMCU]
...
lib_deps =
	...
<EMAIL_ADDRESS>

I had a similar issue using TFT_eWidget with ESP32 on PlatformIO
My ESP32 framework was out of date, I did an update as follows;
pio platform update espressif32
Which solved my issue.
This thread helped me:
Thanks Valeros :-)


chore(v2): Fix more linter warnings

Motivation
Fix more linter warnings.
152 warnings -> 51 warnings.
Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
Most of the changes are type-only, so check CI status.
For slight regex tweaks, I commented below on how they are already covered by existing tests.
Related PRs
(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/docusaurus, and link to your PR here.)

Thanks for the cleanup :)
LGTM


[0.5pt] Add footer - group task

Create footer according to the wireframe:

The header is implemented.
You can find the related pull request at the link.


PacReq: QtScrcpy

Types
-git (Compiled off of the latest commit of the package)
URL
https://github.com/barry-ran/QtScrcpy
https://aur.archlinux.org/packages/qtscrcpy
Building guide
https://github.com/barry-ran/QtScrcpy#build
https://aur.archlinux.org/cgit/aur.git/tree/PKGBUILD?h=qtscrcpy
Additional context
No response

There is now a pre-compiled binary for Ubuntu on the github repo's releases page. There is also a release on dev branch of their Github Actions apparently.
Pacstall could just pull that, pack it, and install it on Ubuntu-based systems, maybe Debian-based systems as well? It only requires android-tools, qt5-multimedia, qt5-x11extras according to the AUR page.

There is now a pre-compiled binary for Ubuntu on the github repo's releases page. There is also a release on dev branch of their Github Actions apparently.
Pacstall could just pull that, pack it, and install it on Ubuntu-based systems, maybe Debian-based systems as well? It only requires android-tools, qt5-multimedia, qt5-x11extras according to the AUR page.

Sorry fo replying this on 2024. I will review it first the deb package and which dependences it will be added as important for qtscrcpy-deb.


Clear unstarred repos

If tags have been added to a repo but then the repo is unstarred, it will still count/show in the sidebar.

One way to do it I think would be to use the github API to grab the actual list of starred repo (cannot relying on the DOM) then cross reference it with the list of tags we have in the model and clear the model accordingly.

The API is paginated making this a bit harder