Ability to support multiple hostnames and DNS zones

Is your request related to a new offering from AWS?
Is this functionality available in the AWS provider for Terraform? See CHANGELOG.md, too.

Yes ✅: please list the AWS provider version which introduced this functionality

Is your request related to a problem? Please describe.

I cannot select more zone_id when I want to support more than one DNS name with totally different hostnames. In order to create CloudFront distribution that uses 2 totally different domains at the same time (example: example.com and example.co) and I need to use a single SSL certificate that whitelists 2 different hostnames. In such cases, each domain has to have a separate DNS zone.
Describe the solution you'd like.

Ability to enter domains and zones together via a single variable, so you can easily distinguish when you need to create DNS records in separate DNS zones.
Describe alternatives you've considered.

N/A
Additional context

We are having the same need, would be great to genera an ACM certificate with multiple domains so we don't have to create multiple CloudFront distributions.

@rapides can you try #137 and see if that works for you? Thanks!

I have the same issue

Issue still perists

Issue still perists

https://github.com/terraform-aws-modules/terraform-aws-acm/pull/137#pullrequestreview-1662067778 - my review is still relevant and someone can take it further and work on improvements.

Hi @amontalban, do you intend to resume #137? Otherwise I think I could make requested changes.

Issue still perists, I don't know the code in here at all, so I am not sure, it makes sense for me to work on this, but @amontalban maybe you could create a new PR based on #137?

Issue still persists, waiting for https://github.com/terraform-aws-modules/terraform-aws-acm/pull/149

Issue still persists, waiting for https://github.com/terraform-aws-modules/terraform-aws-acm/pull/149

Issue still persists, waiting for https://github.com/terraform-aws-modules/terraform-aws-acm/pull/149

Issue still persists, waiting for https://github.com/terraform-aws-modules/terraform-aws-acm/pull/149

Issue still persists, waiting for https://github.com/terraform-aws-modules/terraform-aws-acm/pull/149

@phuhl  it's your turn to check it out and open an issue if you see something wrong. I'm sorry it took so long to get this one reviewed and merged.

Thank you for putting the work in :)


[SPARK-16311][SQL] Metadata refresh should work on temporary views

What changes were proposed in this pull request?
This patch fixes the bug that the refresh command does not work on temporary views. This patch is based on https://github.com/apache/spark/pull/13989, but removes the public Dataset.refresh() API as well as improved test coverage.
Note that I actually think the public refresh() API is very useful. We can in the future implement it by also invalidating the lazy vals in QueryExecution (or alternatively just create a new QueryExecution).
How was this patch tested?
Re-enabled a previously ignored test, and added a new test suite for Hive testing behavior of temporary views against MetastoreRelation.

Test build #61599 has started for PR 14009 at commit 1225cfc.

Test build #61600 has started for PR 14009 at commit 0c47cca.

LGTM except a minor comment.

Test build #61599 has finished for PR 14009 at commit 1225cfc.

This patch passes all tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
class HiveMetadataCacheSuite extends QueryTest with SQLTestUtils with TestHiveSingleton

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/61599/
Test PASSed.

Test build #61600 has finished for PR 14009 at commit 0c47cca.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/61600/
Test PASSed.

LGTM except for a minor styling issue.

Thanks - I fixed the two comments. Going to merge it in master/2.0.

Test build #61773 has started for PR 14009 at commit b131175.

Test build #61773 has finished for PR 14009 at commit b131175.

This patch fails to build.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/61773/
Test FAILed.

Hi, @rxin .
It seems this causes build failure.
https://amplab.cs.berkeley.edu/jenkins/job/spark-master-compile-maven-hadoop-2.7/2094/console

Thank you for fast fix!


Add a place and something interesting about you.

If this is your first pull request, please read this article: How To Create a Pull Request on GitHub
Step 1
Fork the repo by pressing the "Fork" button on the top right side of the
repository and clone your forked repository.
Step 2
In your forked repository, edit "index.html" and add your place's picture, place's name and a short dscription about it. Also add something interesting about yourself and a picture of yours. Please read the simple instructions (comments) carefully, while editing the html file.

In index.html, start copying from the line with div class="col-1-of-3" till the end of the div (also        marked in the file), in order to add content in it.
Go to img/places/ folder and add your Place Pic in the naming format, place[no.].jpg, like, place1.jpg,    place2.jpg and so on and mention the path, in the img tag.
Add the Name of your Place, in place of Place Demo, inside the span tag.
Add a short description about your place, in place of the random text, inside the p tag.
For the About Contributors section, add an image of yours in img/contributors/ folder, in the naming            format, contributor[no.].jpg, like contributor1.jpg, contributor2.jpg and so on and mention the path, in the img tag, like you did for the places.
In the figcaption tag, mention your name.
In the h3 tag, give a tile about yourself.
In the p tag, write something interesting about yourself, alongwith some social media links, for people to      find you.
That's it!

Step 3
Commit your changes and submit a pull request! After your pull request gets accepted, you will be able to see your very own profile on the HacktoberExplor !!
Step 4
Please star the repo, if you like this fun little Hacktoberfest project :heart:

I am interested


iOS Wrapper abstraction

Some information, such as handler types (u32, i32) or callback definitions, is only useful within vcx and the client code that uses them doesn't need to know the specifics. So I think hiding it from the client code will improve maintainability.
Signed-off-by: kukgini<EMAIL_ADDRESS>

Codecov Report

Merging #398 (0d2d9bb) into ci/experiment-ios (336530e) will decrease coverage by 43.86%.
The diff coverage is n/a.

@@                  Coverage Diff                   @@
##           ci/experiment-ios     #398       +/-   ##
======================================================
- Coverage              66.38%   22.51%   -43.87%
======================================================
  Files                    153       18      -135
  Lines                  14454     1128    -13326
  Branches                2858      284     -2574
======================================================
- Hits                    9595      254     -9341
+ Misses                  2535      799     -1736
+ Partials                2324       75     -2249

Flag
Coverage Δ

integration-aries-vcx
?

unittests-agency-client
22.51% <ø> (ø)

unittests-aries-vcx
?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

agency_client/src/agency_client.rs
0.00% <0.00%> (-9.10%)
:arrow_down:

agency_client/src/get_message.rs
0.00% <0.00%> (-3.25%)
:arrow_down:

agency_client/src/payload.rs
0.00% <0.00%> (ø)

aries_vcx/src/messages/discovery/disclose.rs

...ries_vcx/src/handlers/out_of_band/sender/sender.rs

aries_vcx/src/libindy/utils/anoncreds.rs

aries_vcx/src/handlers/mod.rs

aries_vcx/src/handlers/connection/pairwise_info.rs

...rc/handlers/connection/inviter/states/responded.rs

aries_vcx/src/messages/status.rs

... and 128 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 336530e...0d2d9bb. Read the comment docs.

I will close this PR and try again to fix the DCO issue.


Rewrite span as composite aggregation.

Description
1.rewrite span as composite aggregation instead of DateHistogram or Histogram aggregation.
2.fix issue #385.
Issues Resolved
[List any issues this PR will resolve]
Check List

[x] New functionality includes testing.

[x] All tests pass, including unit test, integration test and doctest

[ ] New functionality has been documented.

[ ] New functionality has javadoc added
[ ] New functionality has user manual doc added

[x] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Codecov Report

Merging #386 (f7a2728) into main (10092fb) will decrease coverage by 33.60%.
The diff coverage is n/a.

@@              Coverage Diff              @@
##               main     #386       +/-   ##
=============================================
- Coverage     96.52%   62.91%   -33.61%
=============================================
  Files           266       10      -256
  Lines          7192      658     -6534
  Branches        540      118      -422
=============================================
- Hits           6942      414     -6528
+ Misses          196      191        -5
+ Partials         54       53        -1

Flag
Coverage Δ

query-workbench
62.91% <ø> (ø)

sql-engine
?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

...ge/script/aggregation/AggregationQueryBuilder.java

...ript/aggregation/dsl/BucketAggregationBuilder.java

...earch/storage/script/filter/lucene/RangeQuery.java

...h/sql/expression/aggregation/StdDevAggregator.java

...rg/opensearch/sql/ppl/domain/PPLQueryResponse.java

...logical/OpenSearchLogicalPlanOptimizerFactory.java

...g/opensearch/sql/data/model/AbstractExprValue.java

...pensearch/sql/planner/physical/WindowOperator.java

...h/planner/logical/rule/MergeFilterAndRelation.java

...rch/sql/data/utils/NullsLastExprValueOrdering.java

... and 244 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 10092fb...f7a2728. Read the comment docs.


Bug Builder with clearing quarry card.

Issue description:
Builder with a clearing quarry card was quarrying with a single chest on top powered by 180rf with ledstone fluxducts, the chest became full: when suddenly my base was quite literately filled with about 1000 silver fish. they kept spawning at a pace that seemed like the time it would take for the builder to break a block with the power that was supplied. the silverfish spawned out of the builder block.
went in to peaceful mode, the silverfish continued trying to spawn, when going back in to normal they continued, clearing the storage chest of items fixed the issue.
my assumption is that the builder was going to break a block that had a silverfish inside, when it had no inventory space inside the chest it just repeatedly probed the block spawning silverfish somehow.
later the builder was replaced by ballistic magma when put mine blocks 25000 blocks away after mining some blocks
Steps to reproduce:
none, it quite literally filled my base and every cobble stone block with silverfish.
Versions:

Minecraft: 1.12.2
Forge: <IP_ADDRESS>18
CompatLayer (only if on Minecraft 1.10 or 1.11):
McJtyLib:1.12-2.6.5
RFTools:  1.12-7.30,

Single player instance of lost souls.
pack: Forever stranded lost souls v. <IP_ADDRESS>-b3

I don't think this is related to the builder. I tried attaching a builder to a full chest and having it try to quarry a monster egg, but this didn't happen to me. Also, I checked the builder's code, and the way that it breaks blocks looks like it will never produce a silverfish. I'm guessing that it's a coincidence that your base started to fill up with them while the builder was running. Can you provide any other information to help me reproduce this issue?
Also, what's ballistic magma?

a side note that shouldn't really matter is that it was in the nether, and i dont think the block that is broken is a "monster egg"

a side note that shouldn't really matter is that it was in the nether, it was basaltic magma from primal core, i read it wrong ;) however the blocks that are broken in the pack do not "contain monster eggs" they are nether blocks. they do not spawn from the block like monster eggs would. i do not know what mod adds it, my guess is primal core, nether ex or cyclic. seeing how silverfish from monster egg spawns on the block broken and not the breaker.serched for the mods that added add the hellfish and silverfish in the nether. and came across this:  "NEVER quarry nether when you're using nether ore mod if you don't tweak the hellfish config, it will break your server. " so apparently someone else has had the same issue.

Okay, there are two bugs here.
The first bug is that the builder would pass the wrong position to fireBlockHarvesting, so things that are supposed to happen to the block being quarried in HarvestDropsEvent would instead happen to the builder block itself. This explains silverfish spawning around the builder at all (Cyclic), and it getting turned into basaltic magma (PrimalCore). Coincidentally, I fixed this in RFTools 7.32 (via commit 3ea70c4) two days before you opened this issue.
The other bug is that if the builder's inventory fills up, fireBlockHarvesting will be called multiple times on the same block. This explains why the silverfish would keep spawning when the inventory was full (it would repeatedly call the event, see it doesn't have room for the drops, then not break the block). This one isn't fixed yet.
If you update to 7.32 now, you'll still get masses of silverfish if your inventory fills up while on an infested ore block, but they'll spawn at said block rather than at the builder. You also won't have to worry about the builder turning into basaltic magma anymore.

i suggest adding a single inventory space to the builder that if chest is full it will put it in that and if that is full it will stop the builder, and that will push to chest if chest is emptied.

Why did you close this? It's not fixed yet.
Your fix does seem like a reasonable idea. I'll see what I can do.

Hmm hold it. This doesn't sound like a good solution.  Can't this be solved without that extra inventory in the builder? That's a rather clumsy solut2

So here's the current sequence of events:

We make a list of drops for the block we're working on, via block.getDrops and firing HarvestDropsEvent
We check whether there's room to hold all of the drops we just found
If there is room, we add them to the inventory and then call clearOrDirtBlock. If there's not room, we leave the block there and just call waitOrSkip.

The problem is that HarvestDropsEvent (and potentially getDrops) can have side effects. The expectation is that the block will be immediately dropped and removed after calling these. We violate this expectation when we call them but then leave the block around. This problem is compounded when we repeatedly retry the same block, causing these to be called very rapidly on the same block.
There are two solutions for this that I can think of:

When the inventory fills up, keep breaking blocks, and just put their drops in the world as entities instead of putting them in anything.
When the inventory fills up, force the builder to pause regardless of its settings. Keep track of the items that we couldn't insert (but don't expose them as inventory). Once the inventory has room again, put said items in it and resume work.

Solution 2 is what I was originally thinking of. Let me know whether you're okay with this, or if you know of a better way to fix this.

if you break the builder in solution 2 you it would void the blocks no?  or would you keep them saved?

solution 1 would break servers.

Re solution 1, yeah I kind of figured that, I just listed it for completeness.
Re solution 2, I'd make breaking the builder drop the saved drops along with itself.

there would have to be a limit, if it continued to run for 1million blocks and someone broke the builder

There is a limit:

When the inventory fills up, force the builder to pause regardless of its settings

So only 1 block's worth of drops could ever be inside of it at a time.

ah yes,  as long as its not a drawer with a few million items it should be fine


Issue for adding Fast Reactor Hexagonal Bowing Models

Adding hexagonal assembly thermal mechanical model input files, mesh and documentation. Three model input files are included:

Single assembly bowing, with linear thermal gradient
Single assembly bowing, with constant thermal gradient
Assembly bowing into symmetric sector with linear thermal gradient

The models use the Tensor Mechanics, Reactor, and Contact modules to simulate the core bowing of 3D hexagonal assemblies within fast reactors for radial core expansion estimation due to thermal gradients.

Closing as addressed by #146


Expand entity type range.

Checklist

[X ] I am running the latest version of the card - v2.0.4
[X ] I checked if there isn't another feature request opened with the same request
[X ] I checked that the feature is not already available in the dev branch

Is your feature request related to a problem? Please describe.
Yes, I believe. I could have sworn that I used to be able to use a switch entity with a suitable transform: "return x === 'on' ? 1 : 0;" to show a switch on the graph but now it always displays as N/A in the states legend and doesn't show up on the plot.
Describe the solution you'd like
Can we please use arbitrary entity types provided they have a 'state' property so we don't have to create template sensor/binary_sensor entities for the sole purpose of graphing?
Describe alternatives you've considered
I'm using a template binary sensor now which works but is not very elegant as it loads the HA server unnecessarily even when I'm not viewing the graph.
Additional context
Nothing to declare.

Did you disable history for this entity or the whole switch domain? That would be the only reason that I can think of.

At one point I think I did. I'll close this.


Merge master branch to prTesting1_202005171932 branch

Docs Build status updates of commit efe3475:
:clock10: Pending: waiting for processors (9 builds ahead of you)
:warning: Docs Build is busy, currently there are 9 builds ahead of this one, for more information you can view the Build queue graph on the Docs Portal.

Docs Build status updates of commit efe3475:
:warning: Validation status: warnings

File
Status
Preview URL
Details

split/updateTestCon1.md
:warning:Warning

Details

split/updateTestCon1.md

[Warning] Missing attribute: author. Add the current author's GitHub ID.
[Warning] Missing attribute: title. Add a title string to show in search engine results.
Line 0: [Warning] Markdown content is not allowed before H1.
Line 1: [Suggestion] H1 is required. Use a single hash (#) followed by a space to create your top-level heading. NOTE: This Suggestion will become a Warning on 04/01/2020.

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Cannot remove date

The old date still gets passed to the server after the user deleted the field.
I suspect this is due to the hijacking of the datetime picker, which introduced two inputs for one datetime. And after the user deletes the date, the hidden field is not updated.

Fixed in #5.


[NEED HELP] Setup Github Actions for automated release in NPM, GitHub

[NEED HELP] Setup Github Actions for automated release in NPM, GitHub
Hi,
I am trying to make this pkg ready as soon as possible, but I am tired to fix GitHub-actions to automate the release process.
Using release-it cli, it is working manually (from my local-machine). Except committing. Because, somehow it wasn't committing using the conventional-commits. So, git-hooks from husky/lint-staged fails.
If anyone can help me figure this out or want to contribute in this issue, please let me know.
Feel free to ask or DM me instead.
~/@mahabubx7

I am starting on my own ... 😢


bug: Telescope Transparency Issue

Neovim version (nvim -v)
0.11.0
Terminal / multiplexer
WSL 2.0 Ubuntu
Describe the bug
Hey I'm new to neovim, so I'm not sure if it's a color-scheme issue or a skill issue. I'm using a mixture of theprimeagen's config and kickstart.nvim for context.
I'm having some trouble getting the transparency setting to work with telescope. It works great on my regular setup and netrw, but whenever I open telescope, it changes to the regular dark background.
Any advice or suggestions is much appreciated, thanks!

Repro
function ColorMyPencils(color)
	color = color or "rose-pine"
	vim.cmd.colorscheme(color)

	vim.api.nvim_set_hl(0, "Normal", { bg = "none" })
	vim.api.nvim_set_hl(0, "NormalFloat", { bg = "none" })

	vim.api.nvim_create_autocmd("TextYankPost", {
		desc = "Highlight when yanking (copying) text",
		group = vim.api.nvim_create_augroup("kickstart-highlight-yank", { clear = true }),
		callback = function()
			vim.highlight.on_yank()
		end,
	})
end

return {
	{
		"rose-pine/neovim",
		name = "rose-pine",
		config = function()
			require("rose-pine").setup({

				enable = {
					terminal = true,
				},
				styles = {
					italic = true,
					bold = true,
					transparancey = true,
				},
				highlight_groups = {
					TelescopeBackground = { bg = "none" },
					TelescopeBorder = { fg = "highlight_high", bg = "none" },
					TelescopeNormal = { bg = "none" },
					TelescopePromptNormal = { bg = "none" },
					TelescopeResultsNormal = { fg = "subtle", bg = "none" },
					TelescopeSelection = { fg = "text", bg = "none" },
					TelescopeSelectionCaret = { fg = "rose", bg = "rose" },
					CurSearch = { fg = "base", bg = "rose", inherit = false },
					Search = { bg = "rose", blend = 20, inherit = false },
				},
			})
		end,
	},
}

Hmm can't reproduce this on my system but you shouldn't need the ColorMyPencils or any other setting of backgrounds to "none"—looks like you have a typo though as it should be "transparency".

Welp that will definitely do it haha thanks for the help and the lovely theme!

Okay wait, second question, I've figured out that if I add vim.opt.cursorline = false to ColorMyPencils() and call it form within netrw, I can remove the cursor background line, but everytime I reopen netrw it comes back. Do you know of a way to edit that setting permanently?

Pretty sure there's an autocmd event that is for the filetype of netrw or similar which you could then set vim.opt.cursorline = false if you want to only disable the cursorline while in netrw. Otherwise simply move that setting out of the function and it will apply always.

Okay cool I have a current fix of just setting it by using BufWinEnter as the event and it seems to be working fine! Thanks for the help again!

Sorry, I'm just all over the place lol. I couldn't find the netrw specific event, but I tried using the BufWinEnter event and it worked, but only when opening vim for the first time. For more context, I have vim.opt.cursorline = false already set in my options file, so there isn't a cursor line in whenever I'm in a file, but for whatever reason it's there for netrw, so I'm just kinda lost as to how that even happens lol.

You might have a plugin that is enabling the cursorline. Either way not an issue with this theme so we can keep this closed.


Styling "Book Nic" CTA

Added a couple instances of "Book Nic" links on the Speaking page. These need to be styled!
I'm thinking something similar to the CTA on https://www.lindaedgecombe.com/speaking-topics/ But not in red.
I have one set against the light blue/grey, and one set against the dark. I'd like them to be nice and visible. Centered. Rounded corners.
 ;)

No. A button does some thing. A link goes somewhere. And this goes to my contact form! It should look different than the link so it grabs attention. But it should not look like a button, because you interact with a button differently than the link. One uses the spacebar. One uses the return key. But you know that!


Build workspace with wasm32-unknown-emscripten during CI

There have been several issues which blocked deploying the playground upstream from drift in the wasm32-unknown-emscripten build.

GH-412
GH-324
GH-301
GH-283
GH-246
GH-596

The only blocker to doing this is a deploy of rustyline with this PR included: https://github.com/kkawakam/rustyline/pull/285. It looks like @gwenn is actively working on a release. Thank you 🙏

Blocked because waiting on upstream

rustyline 5.0.5 is released that includes the blocking PR

rustyline builds under wasm32-unknown-unknown but not wasm32-unknown-emscripten because emscripten is also cfg(unix).
Patched build here:
https://github.com/lopopolo/rustyline/tree/emscripten-cfg-unix


Feature: App Launcher - service type detection needed in URL assembly logic

Current Behavior
When launching an application through the App Launcher with a NodePort service, the extension uses Rancher's proxy URL format:
/k8s/clusters/[cluster-id]/api/v1/namespaces/[namespace]/services/http:[service-name]:80/proxy/
This causes issues with applications that expect to be served from the root path (/).
Desired Behavior
App Launcher should detect the service type (NodePort, LoadBalancer, ClusterIP) and adjust the launch URL accordingly:

For NodePort services: Use http://[node-ip]:[nodePort]
For proxy URLs: Keep current behavior
For Ingress: Keep current behavior

Using the Rancher demo application (monachus/rancher-demo):

Direct NodePort access works: http://rancher-demo.cweiser.com:30021
Current proxy URL fails: https://rancher.cweiser.com/k8s/clusters/c-m-xds5xzdt/api/v1/namespaces/cweiser/services/http:scale-np-service:80/proxy/

@chase-weiser88 @dcharles525 you might be able to collab on this alongside the minor release for the Rancher 2.10 updates

@krumware @chase-weiser88 yeah I can take a look at this for the minor release.


[🔔 Request SVG]: GCP services

Title
GCP
SVG URL
https://cloud.google.com/icons/files/google-cloud-icons.zip
SVG Dark Mode URL (optional)
No response
Product URL
https://cloud.google.com/icons?hl=en
Category
Google
Checklist

[X] I have permission to use this logo.
[X] The .svg URL I have provided is optimized for web use.
[X] The .svg size is less than 20kb.

could be done for aws and azure services too ig as they list their assets publicly


enable different linewidths/colors for edges

It would be cool to visualize the relative length of the corresponding sequence intervals for edges by altering the linewidth or the color of the plotted edges. This might depend on #42 .

From this GitHub branch: with D3ARG.draw(variable_edge_width=True), the visualizer scales the stroke width of the edges based on the fraction of sequence that contains the edge. This branch has merged edges as discussed in #42 (except in the cases of "diamonds", where there is a recombination event followed by a coalescent event of the same two lineages). Is this along the lines for what you were thinking?

Awesome @kitchensjn !
This is exactly what I was thinking about. I think this is a great way to quickly visualize the overall importance of edges for the sample. I will have to reschedule some appointments next week to try this feature.


NIFI-8523 Update secure ftp processors to make configurable which algorithms, ciphers and message authentication codes are allowed to be used by the SSH Client.

Thank you for submitting a contribution to Apache NiFi.
Please provide a short description of the PR here:
Description of PR
Allows users to configure which algorithms, message authentication codes and ciphers to allow GetSFTP, PutSFTP, FetchSFTP and ListSFTP to use when establishing an SSH connection.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:

[X] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message? Yes

[X] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. Yes

[X] Has your PR been rebased against the latest commit within the target branch (typically main)? Yes

[X] Is your initial contribution a single, squashed commit? Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not squash or use --force when pushing to allow for clean monitoring of changes. Yes

For code changes:

[X] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
[X] Have you written or updated unit tests to verify your changes?
[X] Have you verified that the full build is successful on JDK 8?
[X] Have you verified that the full build is successful on JDK 11?
[X] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0? N/A
[X] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly? N/A
[X] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly? N/A
[X] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?

For documentation related changes:

[X] Have you ensured that format looks appropriate for the output in which it is rendered? N/A

Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI for build issues and submit an update to your PR as soon as possible.

Thanks for the updates, especially the Variable Registry.
LGTM

When attempting to verify the most recent updates at runtime, the ListSFTP worked as expected with the default blank values for the new properties.  However, when specifying a value for Ciphers Allowed, NiFi marked the processor as invalid with the following message:
'Ciphers Allowed' validated against 'aes256-cbc' is invalid because 'Ciphers Allowed' is not supported or has no Validator associated with it.
It appears that recent updates to remove the default values also removed any kind of validator, but I missed that detail last time around.  Based on previous comments and support for Expression Language, it seems like using StandardValidators.NON_EMPTY_EL_VALIDATOR would be a good option.

When attempting to verify the most recent updates at runtime, the ListSFTP worked as expected with the default blank values for the new properties. However, when specifying a value for Ciphers Allowed, NiFi marked the processor as invalid with the following message:
'Ciphers Allowed' validated against 'aes256-cbc' is invalid because 'Ciphers Allowed' is not supported or has no Validator associated with it.
It appears that recent updates to remove the default values also removed any kind of validator, but I missed that detail last time around. Based on previous comments and support for Expression Language, it seems like using StandardValidators.NON_EMPTY_EL_VALIDATOR would be a good option.

Good catch but NON_EMPTY_EL_VALIDATOR ensures that EL is present. It's supported but not required Going with NON_BLANK_VALIDATOR.

When attempting to verify the most recent updates at runtime, the ListSFTP worked as expected with the default blank values for the new properties. However, when specifying a value for Ciphers Allowed, NiFi marked the processor as invalid with the following message:
'Ciphers Allowed' validated against 'aes256-cbc' is invalid because 'Ciphers Allowed' is not supported or has no Validator associated with it.
It appears that recent updates to remove the default values also removed any kind of validator, but I missed that detail last time around. Based on previous comments and support for Expression Language, it seems like using StandardValidators.NON_EMPTY_EL_VALIDATOR would be a good option.

Good catch but NON_EMPTY_EL_VALIDATOR ensures that EL is present. It's supported but not required Going with NON_BLANK_VALIDATOR.

Thanks for the update, that sounds good, I will take another look at verifying the changes.


Update init.sh

This change is

let's see whether integration test pass

I'd rather just declare bash requirement in the invocation

You know what? https://github.com/KostyaSha/yet-another-docker-plugin/pull/100/files#diff-61fa5bf6562d5796625d9d2be676c327R1

:sadpanda:

Current coverage is 32.45% (diff: 100%)

Merging #109 into master will not change coverage

@@             master       #109   diff @@
==========================================
  Files            36         36
  Lines          1436       1436
  Methods           0          0
  Messages          0          0
  Branches        184        184
==========================================
  Hits            466        466
  Misses          913        913
  Partials         57         57

Powered by Codecov. Last update ebd1ed1...319c80a


web: adjust line-height

Hello @yuindustries,
Please review the following commits I made in branch nicks/lineheight:
ddfa0450fc8903e92209388d41fcbb5ae9ef5e0f (2019-06-05 18:39:48 -0400)
web: adjust line-height

The line-height was creating weird spacing between the | in the logs...so i adjusted it a bit.
what do you think? don't feel strongly about it, just thought it felt slightly nicer:
before:

ya, thinking about this a bit more, i agree. will think a bit about how to do this better.


[Templating] Investigate error messages in the chrome/firefox dev console for SPAs

On firefox and chrome, the React and Angular SPA produce a series of error during development.
We need to figure out what's happening in there.

@mkArtakMSFT we've discussed this issue before. The problem is in JavaScript services, where I don't have any context. @SteveSandersonMS was on vacation the last time it was brought up, perhaps we can discuss it with him now.

I thought the problem was that the dev servers (Angular CLI / create-react-app) emit code that tells the client to make a WebSocket connection back to the dev server. Since we're proxying to the dev server, the WebSocket connection actually goes to the ASP.NET Core host application (which is good and correct), but then somehow we're failing to proxy that WebSocket connection properly.
So my guess is someone needs to debug the proxying code to see why we're not letting the browser and the Angular/React dev server talk to each other in the way they expect.

The error message does contain the clue "Invalid host/origin header", so maybe it's something like: the proxy code needs to rewrite the origin header so that the Angular/React dev server believes the request is coming directly to it, and not from some other origin.

@ryanbrandenburg please reevaluate this as this seems to be really bad. We should try to fix this as early as possible but the current M costing is a bit heavy.

This seems to only happen when the app isn't published (because when we publish and are thus in Production it doesn't use webpack-dev-server).

That's fine, We don't want to see these exceptions during Development because they are unwanted noise. That's what we want to fix here.

The Invalid Host/Origin thing is a separate, Firefox-only problem that can be solved by doing this. That said disabling the host check is dangerous, so it's unclear if we want that fix. The websocket connection problem doesn't seem solvable by re-writing the host/origin headers because even when we set --disableHostCheck=true we still get the get the warnings.

This comment says that this warning doesn't indicate a problem and can be ignored, but that's in the context of it only happening 5% of the time (as opposed to 100%). If we still care about resolving this given that and the fact that HotLoading still works (as long as you fix the Firefox Origin thing) then what I need to proceed is a call with @SteveSandersonMS so we can figure out how to diagnose and proceed. I talked with some people in the server room and they didn't have ideas.

Filed https://github.com/aspnet/AspNetCore/issues/9400 to handle the one dependency update to avoid many errors

The SPA approach seems to be having ASP.NET Core in charge, with HTTP traffic always coming to ASP.NET Core who will proxy to the SPA's dev server.
Have you people considered the opposite approach?  On startup, ASP.NET Core could still launch the start/serve scripts of the SPA but it can then tell the browser to direct traffic to the SPA dev server, and its the dev server the one that will proxy API requests to the ASP.NET Core process.
All the major web frameworks support the proxy option (they all end up using the webpack dev server) and it seems to me proxying API requests is simpler/faster than proxying the hot reload web sockets...

https://facebook.github.io/create-react-app/docs/proxying-api-requests-in-development
https://cli.vuejs.org/config/#devserver-proxy
https://angular.io/guide/build#proxying-to-a-backend-server

The main challenge I see is to make sure the port configured for ASP.NET Core in development is correctly passed into the devProxy setting, which in the case of angular/reach seems to be static json files.  It could be set when the template is first created, but the ports for IISExpress and Kestrel are different... Not sure if react/angular allow those settings to be in a regular .js file (Vue does), because then you can setup an env variable from .NET which is then read on that file as part of the npm start/serve command. Otherwise you could modify those json config files before running the npm script (which isnt great tbh)
Maybe this was already considered by the team and discarded in favour of the current approach, but if not it might be worth exploring.

@SteveSandersonMS Do you have any thoughts? We could do the proxying in the templates, but I feel thats a big departure from the way things work today.

I would hope we could fix the proxying. Then it would not be necessary to completely reverse how everything works.

I totally understand. Might be no harm keeping it in mind in case you find more issues with the proxying and/or it turns out easier to invert the proxy than to fix those issues

The websocket connection problem doesn't seem solvable by re-writing the host/origin headers because even when we set --disableHostCheck=true we still get the get the warnings.

I don't follow how it's possible to still get the warnings if the proxying is being done correctly. How can the browser even distinguish between having a direct connection to the SPA's dev server versus a reverse-proxy to it? If the reverse proxying is being done well enough then the browser shouldn't be able to know there's a difference.
I'd recommend trying to rewrite the origin header and seeing whether that does help. If there are still problems, look at network traces to determine what's different between having the reverse proxy versus loading the site directly in the Angular/React dev server.

It's possible also that moving to newer versions of the libraries may fix it (if the problem is nothing to do with our code and instead is just purely a bug in sock.js or Webpack). There was a workaround applied in Webpack in https://github.com/webpack/webpack-dev-server/pull/1608/files.

Yeah, sounds like this is exactly what @ryanbrandenburg was referring to. It seems that have been merged a while ago already. @ryanbrandenburg can you please check what dependencies we should pick up to get this fix and see whether this issue is resolved?

Given that this has no functionality impact, and this will be resolved when impacted SPA frameworks will pick up the Webpack workaround and we'll update our dependencies, we'll just wait.

Have we waited long enough or should I continue using the browser - asp.net - vue dev stack in favor of getting these errors? About to start a new SPA project..


support inspect-manifest for CycloneDx 1.4

A CycloneDx component can have a list of components, those are dumped to extra_data as nestedComponents. Furthermore, these lists of components are recursively parsed and treated as normal package.
The Component may have multiple URLs in externalReferences. The first URL of the reference is added to the applicable package_data URL, while the rest are dumped in extra_data as externalReferences.

fixes https://github.com/nexB/scancode.io/issues/583
Signed-off-by: Keshav Priyadarshi<EMAIL_ADDRESS>

@kpriyadarshi I ran a inspect_manifest pipeline from your branch and it worked great!
INFO "GET /project/add/ HTTP/1.1" 200 35090
INFO Fetching "https://raw.githubusercontent.com/keshav-space/scancode.io/import_cyclonedx/scanpipe/tests/data/cyclonedx/asgiref-3.3.0.bom.json" using fetch_http
INFO Run[e650ea41-ba7a-4e61-85a5-5abfd6f316a7] Enter `execute_pipeline_task` Run.pk/Task.id=e650ea41-ba7a-4e61-85a5-5abfd6f316a7
INFO Run[e650ea41-ba7a-4e61-85a5-5abfd6f316a7] Run pipeline: "inspect_manifest" on project: "cyclonedx-test-asgiref-3.3.0"
INFO 2023-02-01 16:39:52.46 Pipeline [inspect_manifest] starting
INFO 2023-02-01 16:39:52.46 Step [get_manifest_inputs] starting
INFO 2023-02-01 16:39:52.46 Step [get_manifest_inputs] completed in 0.00 seconds
INFO 2023-02-01 16:39:52.46 Step [create_packages_from_manifest] starting
INFO 2023-02-01 16:39:52.46 `cyclonedx` input detected for /home/ayansinha/nexB/main_repos/gh-cli-repos/scancode.io/var/projects/cyclonedx-test-asgiref-330-9e28864f/input/asgiref-3.3.0.bom.json
INFO 2023-02-01 16:39:52.52 Step [create_packages_from_manifest] completed in 0.05 seconds
INFO 2023-02-01 16:39:52.52 Pipeline completed
INFO Run[e650ea41-ba7a-4e61-85a5-5abfd6f316a7] Update Run instance with exitcode, output, and end_date
INFO "POST /project/add/ HTTP/1.1" 302 0
INFO "GET /project/9e28864f-d580-4e10-8ec0-bb515c5d66d5/ HTTP/1.1" 200 19754
INFO "GET /project/9e28864f-d580-4e10-8ec0-bb515c5d66d5/charts/ HTTP/1.1" 200 4491
INFO "GET /project/9e28864f-d580-4e10-8ec0-bb515c5d66d5/packages/ HTTP/1.1" 200 8867
INFO "GET /project/9e28864f-d580-4e10-8ec0-bb515c5d66d5/packages/30/ HTTP/1.1" 200 22602
INFO "GET /project/add/ HTTP/1.1" 200 35090

The license_expression also seems to work fine:
License expression

    bsd-new AND bsd-new

Declared license

    BSD-3-Clause AND BSD-3-Clause

I'll check with some more complicated cyclonedx boms, and let you know!


[BUG] An error occurred (404) when calling the HeadObject operation: Not Found

Describe the bug
I only changed the content of the prompt and edited the chatbot, then retried some questions, but it occasionally shows new bugs that I haven't seen before. It feels like the chatbot isn't as stable as usual. I’ve posted a screenshot of the bug below. Thank you.

Please do not ignore the template and provide details with reproduction steps. thank you

Please do not ignore the template and provide details with reproduction steps. thank you

Thanks for the quick response. it works well in general, however, after some unit tests with the same files uploaded and minor prompt changes, this error pops out which never happened before. I have been using this knowledge database for past 4 months and it seems not stable as usual at least from my personal user experience perspective


French translations

I have added french translation which we could add to the package

I have added french translation which we could add to the package

You can add french translation refer to https://github.com/wuzhendev/flutter-cupertino-date-picker#add-more-language, or send to me


Reconcile Android/iOS on Dart entrypoint defaults when creating engine

Make Android and iOS uniform in needing to specify and defaults of

The entrypoint function
Library
Bundle

We'll need to chat about the specifics of this. I'm not in favor of passing nulls to methods for defaults, which apparently iOS is doing. Also, I'm not convinced that parity between these 2 platforms should supersede what would otherwise be a better API surface. Let's keep in mind that we will soon be on many more platforms, and unless we're going to try to impose Android and iOS API surfaces onto those platforms, this may be a losing proposition in general.

I'm not specifically rooting for specifically using null everywhere but some degree of defaulting via some other constructor would be nice.

I can only think of 2 common reasons for defaults:

A developer doesn't really know how something works, so a default allows the developer to move forward without a deeper understanding.

Something must be done many times and a default reduces the tediousness.

I don't think either of these situations exist here.
For new developers who don't really understand what these different API pieces mean, they're almost certainly using FlutterActivity or FlutterFragment, which have defaults. Those have defaults because they're on the edges of the system. Any developer who is starting up a FlutterEngine needs to understand what they're doing, so a default doesn't save anything on that front.
As far as repetition, there are maybe 2 or 3 FlutterEngines in a substantial app. There will only be 1 FlutterEngine in the average app. So there isn't any highly repetitive work here that needs to be shortened.
So I still don't think we should be adding API surface to codify defaults within the central components of the Android API. I think there is probably no meaningful upside, but with an expanding API surface there is always an opportunity to regret baking in defaults later.
At best, I'd like to see numerous requests for these defaults from real customers before we seriously consider adding them.

It's a bit of both 1 and 2, plus a bit of 3. what meaningful choice is the developer really making here outside of defaults.
Since we'd want to push users to use FlutterEngines even in simple cases, they're not really on the edges of the system. We're taxing them with learning about assets and bundles but in the end, I'm not sure we're really letting them make use of this new knowledge. When would they choose a different asset or bundle location?

Tentatively assigning Matt. I think you recently mentioned looking at this.

@xster can you define the definition of done for this ticket? I've done some work on the Android API, but I'm not sure what this ticket is really looking for.

I can't really recall what was already done or not :S. I think we can say this one's done if Android and iOS both have defaults for starting VM entrypoints or neither have defaults.

By "default" do you mean a factory method that creates a DartyEntrypoint configured for main and the standard apple bundle path? If so, it exists on Android. I don't know if it exists on iOS. Should I assign this to Aaron?

Oh ya, great! Defaults exist for both the intent builder and the dart entrypoint constructors. I think this is done on Android.
For iOS, minor but having special meaning for nil on runWithEntrypoint:(NSString*)entrypoint is a bit non-ideal. Perhaps we can have a [FlutterEngine runDefaultEntrypoint]. But @gaaclarke can decide when he's back.

We're unable to put the module in the run arguments since it will adversely affect app startup time, please see comment: https://github.com/flutter/engine/pull/12370#discussion_r328369135

@gaaclarke based on your last comment, should this be closed as "won't do"? Or is there still work that needs to be done?

Here is where I ended up with this issue:

Android does not yet support loading different modules, so we can't reconcile anything there.
Android was proposing putting modules next to entry point specification, that would hurt their ability to do warm up, so we shouldn't do that.
I added convenience methods to help with the construction of engines on iOS, as per xster's request, to make it as easy as android.

I have no further planned work.

Ok. Should we close this as done?

sgtm


[SelectableText] add user custom selectionGestureDetectorBuilder

Use case
we need one future for SelectableText， control display selection.
i think, custom TextSelectionGestureDetectorBuilder  can slove this future.

Proposal

_selectionGestureDetectorBuilder.buildGestureDetector(
behavior: HitTestBehavior.translucent,
child: child,
),
like this:
void onSingleLongTapStart(LongPressStartDetails details) {
if (delegate.selectionEnabled) {
renderEditable.selectPositionAt(
from: details.globalPosition,
cause: SelectionChangedCause.longPress,
);
}
}

Hello @yunhe-lin. I am not sure what you're proposing exactly here. What is the use case for this feature? Could you explain it in a bit more detail?


Allow customization of remapped output path

It would be great if we could optionally change the path of the remapped output.
Would be nice also to be able to delete the original, unremapped coverage.

It's reasonable. We'll try to implement as fast as possible.

I second this and I'm going one step further... Use the settings from Jest configuration. For instance, I have this:
"coverageDirectory": "build/coverage/",
"coverageReporters": [
    "html",
    "text-summary"
],

I'd expect to have my coverage on the folder specified and only html coverage generated and a text summary after running the tests. Currently a "remapped" folder is used and also a coverage.json and lcov.info files are also generated.
Hopefully this gets implemented soon :)

@Igmat Any progress on this?

@rfgamaral, I'm very sorry - but right now I very busy with my main work and can't spent a lot of time to this one. I'll definitely will go trough all issues in this repo later, may be in two week or month. Sorry for such a big delay...

@Igmat It's understandable, we all have day jobs :) Thanks for replying back.

Coverage is no longer handled by ts-jest (see #200)
If this issue isn't addressed AND if you think the fix needs to be in ts-jest, feel free to either open a new issue or leave a comment here to reopen this.


The md.audio doesn't work with a local file

Discussed in https://github.com/marimo-team/marimo/discussions/623

Originally posted by MrOneTwo January 22, 2024
I'm loading a sound file, that the notebook generates, like so:
SAMPLES_FILE = "samples.bin"

data_unpacked = np.asarray(
    [d[0] for d in struct.iter_unpack("<H", Path(SAMPLES_FILE).read_bytes())]
)

# The microphone that recorded the samples has a certain bit depth for each sample.
# Convert to signed 16bit samples.
_data_float = data_unpacked / 8192.0
soundwave = _data_float * np.iinfo(np.int16).max

SAMPLE_RATE = 32000
BYTES_PER_SAMPLE = 2

with wave.open(str(Path(SAMPLES_FILE).with_suffix(".wav")), "w") as f:
    f.setnchannels(1)
    f.setsampwidth(BYTES_PER_SAMPLE)
    f.setframerate(SAMPLE_RATE)
    f.writeframes(data_unpacked.astype(np.int16))

mo.vstack(
    [
        mo.md("Example sound file:"),
        mo.audio(src="samples.wav"),
    ]
)

#with open(str(Path(SAMPLES_FILE).with_suffix(".wav")), "rb") as _p:
#    mo.audio(src=_p)

The notebook can access the samples.bin, but it fails to embed an audio player with samples.wav. If I change to the App view I see, in the inspect panel, that samples.wav has 404'ed. Is it that Marimo's serve doesn't serve that file?
I have also tried the second approach, using file context. Also, doesn't work. It doesn't even show the audio player with that code, so I might be doing something wrong there.

I am encountering the same issue where I create a local file then try to load it and the output audio player doesn't get rendered

I circumvented this issue by creating an audio HTML tag on the fly using a data URL, might be useful to some while the bug gets debugged:
import tempfile
import base64

# Create a temporary file and get its path
with tempfile.NamedTemporaryFile(
    delete=True, dir=".", suffix=".mp3"
) as temp_file:
    temp_file_path = temp_file.name

    temp_file_path = temp_file_path.split("/")[-1]
    print(temp_file_path)

    # store audio stream in temporary file
    response.stream_to_file(temp_file_path)

    with open(temp_file_path, "rb") as file:
        # output = mo.audio(src=file)
        mp3_data = file.read()
        mp3_base64 = base64.b64encode(mp3_data).decode("utf-8")
        output = mo.Html(
            f"""
            <audio controls>
                <source src="data:audio/mp3;base64,{mp3_base64}" type="audio/mp3">
            </audio>
            """
        )

output


How to use a custom function in the extended function "Select" of IQueryable

How to use a custom function in the extended function "Select" of IQueryable

Duplicate of https://github.com/dotnet/efcore/issues/28914


pull request for e2e test at 12/12/2016 16:56:03

:white_check_mark: Validation status: passed
For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Expose Garbage Collection / Total Block Annihilation of Object Stores

We saw a user in #users channel have a good use case around this.
He was unable to run pachd / pipelines because he ran out of disk space. The symptom was pods stuck in 'pulling' state and upon describing reported no nodes available to schedule pods. This was because the disk was full and k8s couldn't schedule any more pods.
He had a 40GB disk. Pachyderm images could account for a few gigs.
However, he had some big files. And he was running pachctl delete-file between launches while trying to get this working.
It would be helpful to have something like pachctl garbage-collect-blocks. The local use case is obvious - delete the local files. Not sure what happens when you're connected to a real object store. We know that S3 rate limits, and since there could be quite a lot of data there, this could take a long time. Maybe after you enter the command you see a prompt like:
$ pachctl garbage-collect-blocks
There are 34.GB of block data that can be garbage collected. This task may take a while. Do you want to proceed? Y/n

As well as reporting some percentage value so the user gets some feedback about the progress.

I don't think I agree with this approach to garbage collection.
Garbage collection should be something that happens transparently when things are deleted, not something that the user has to initiate for themselves.
This issue also doesn't contain much in the way of details about what the semantics of pachctl garbage-collect-blocks would be. The local use case isn't so obvious to me. Does it just delete all local blocks regardless of if they're referenced or not or only unreferenced blocks?
I'm going to close this because we already have #626 and that has more details. Feel free to weigh in on that one.


Fix for ignored settings_bundle settings

Fixes #41

Going to work on fixing the build via #53 and then will get this in

thanks @winkelsdorf!

You're welcome and thanks for accepting the PR @amorde!


Run code quality metrics in CI

Code quality metrics, such as test coverage, should be gathered by CI run. We should also configure CodeClimate for this repository while we're at it.

Duplicate of #121. Closing.


Broken image

Image is broken under architecture

Document details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 0e4f4c7c-f268-b75b-2486-5c4418e5b24e
Version Independent ID: 5d28faa1-20bc-1727-05ab-0b18eba1ba7c
Content: Data warehousing and analytics - Azure Architecture Center
Content Source: docs/example-scenario/data/data-warehouse.yml
Service: architecture-center
Sub-service: example-scenario
GitHub Login: @alexbuckgit
Microsoft Alias: pnp

Thanks for reporting - this issue is under review. This is a Microsoft Internal DevOps Bug ID # 372868

Thanks for opening this issue - this has been updated and will publish today.


Non-Az module commands?

I see Set-AsrVaultSettings, Get-ASRJob, New-ASRFabric, etc.
Aren't these outdated commands?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 32d3f437-872e-7927-2652-6d2606a3342a
Version Independent ID: 06a7db7e-4ce0-00d0-37fa-968833b121c3
Content: Disaster recovery for Azure VMs using Azure PowerShell and Azure Site Recovery - Azure Site Recovery
Content Source: articles/site-recovery/azure-to-azure-powershell.md
Service: site-recovery
GitHub Login: @sujayt
Microsoft Alias: sutalasi

Thanks for your comment. We are actively investigating and will get back to you shortly. Thanks for your patience.

@dcbrown16 The mentioned commands are aliases of original commands and they aren't outdated yet.
Assigning @sujayt to review the document and update accordingly

#assign:davidsmatlak

@sujayt I'll review the document and update aliases with Az module cmdlet names. When I submit the PR I'll send you a request to review the changes.

I submitted the fix for this issue and when it merges, this issue will automatically close.


[flash_ctrl] Add SVA for rma entry flow

The rma entry flow programs each word with random data and reads it back for consistency.
This flow isn't easily checked by DV since each word is random.  It is better to add an assertion check for this to make sure it never fires.

@TimEwins

Fixed through #10452


add build caching to reduce startup time

Starting up 10+ services takes forever! Would be great to implement a caching system like skaffold to reduce startup times.

Hmmmm...everything should already be cached?
When I start up Tilt, all the docker builds should be cached and it will attach to the running pods.
Can you be more specific? Would it be possible to point to a particular repo, and what part of starting it feels slow to you?

Ok so turns out I just needed to restart my docker for mac kubernetes and it is caching now. However it still is kinda slow if you have a lot of services.
I have only configured the 2 smallest services we have to test tilt out. This is the log of one of them:
Building with BuildOrder: BuildOrder{ *engine.LiveUpdateBuildAndDeployer *engine.DockerComposeBuildAndDeployer *engine.ImageBuildAndDeployer *engine.LocalTargetBuildAndDeployer }
Trying to build and deploy with *engine.LiveUpdateBuildAndDeployer
falling back to next update method because: In-place build does not support initial deploy
Trying to build and deploy with *engine.DockerComposeBuildAndDeployer
falling back to next update method because: DockerComposeBuildAndDeployer requires exactly one dcTarget (got 0)
Trying to build and deploy with *engine.ImageBuildAndDeployer
STEP 1/3 — Building Dockerfile: [bothive/dashboard]
Building Dockerfile:
  FROM node:10.14.2

  ENV PATH node_modules/.bin:$PATH
  COPY . .
  RUN rm -rf package-lock.json
  RUN rm -rf node_modules
  RUN npm i
  EXPOSE 3000

  CMD ["npm", "run", "start:tilt"]

  │ Tarring context…
  │ Building image
    ╎ copy /context /
    ╎ copy /context / done | 22.269s
    ╎ [1/5] FROM docker.io/library/node:10.14.2
    ╎ [cached] [2/5] COPY . .
    ╎ [cached] [3/5] RUN rm -rf package-lock.json
    ╎ [cached] [4/5] RUN rm -rf node_modules
    ╎ [cached] [5/5] RUN npm i
    ╎ exporting to image
    ╎ exporting to image done | 429ms

STEP 2/3 — Pushing bothive/dashboard:tilt-284ca99fcca6c929
    ╎ Skipping push

STEP 3/3 — Deploying
  │ Injecting images into Kubernetes YAML
  │ Applying via kubectl:
  │    dashboard:deployment

  │ Step 1 - 119.709s
  │ Step 2 - 0.000s
  │ Step 3 - 1.970s
  │ Done in: 121.679s

What I notice is that tarring the context and copying it takes a long time in addition to the actual build.
And this is my tiltfile (very messy but just followed the node.js tutorial untill it worked):
k8s_yaml([
    'config/tilt/kubernetes/deployments/services/frontend/dashboard.yml',
    'config/tilt/kubernetes/deployments/services/frontend/intent-manager.yml',
])

update_settings(max_parallel_builds=2)

docker_build('bothive/dashboard', 'frontend/dashboard', dockerfile="frontend/dashboard/dockerfile-local", live_update=[
    fall_back_on(['frontend/dashboard/package.json', 'frontend/dashboard/package-lock.json']),
    sync('frontend/dashboard', '/'),
  ])
docker_build('bothive/intent-manager', 'frontend/intentManager', dockerfile="frontend/intentManager/dockerfile-local", live_update=[
    fall_back_on(['frontend/intentManager/package.json', 'frontend/intentManager/package-lock.json']),
    sync('frontend/intentManager', '/'),
  ])

k8s_resource('dashboard', port_forwards='3000')
k8s_resource('intent-manager', port_forwards='4000')

I've seen you guys have merged some pull requests related to running parallel builds today. Can I use it already or is it not yet released?

ooh interesting. thanks for the context.
The parallel builds stuff should be in the next release. We're just doing a final QA pass on it.
The build context taking a long time to tar + send is interesting. Let me see do some research and maybe ask the Skaffold folks for their advice on this. I think all the toolmakers in this space (us + Skaffold + others) want the image build tooling to get a lot better, rather than everyone building their own caching logic. So I wonder if there's any movement towards a caching protocol that doesn't require the whole tarball.
As an aside, we've been talking about some tooling on how to alert you when docker for mac's kubernetes is slow and needs to be reset, which we think will apply to a lot of people.

Hey @brechtvalcke, have you gotten to try Tilt with the new parallel update functionality? Is it reducing your pain at all? Note that we set the default to 3 simultaneous updates, but you can pump it up as far as you want (until it fries your CPU).

Hi,
Yes I tried and it worked fine. 7 concurrent builds are possible on our
machine's and it doesn't fry our CPU :p.
Thank you for the quick implementation!
Met vriendelijke groeten
Brecht Valcke
Co-founder
Tel: +32 498 81 85 87 <+32498818587>
Email<EMAIL_ADDRESS>[image: Bothive logo] https://www.bothive.be/
[image: like us on Facebook] https://www.facebook.com/bothivechatbots [image:
Visit our Linked in] https://www.linkedin.com/company/14017546 [image:
Follow us on twitter] https://twitter.com/bothive2 [image: Visit our
Instagram] https://www.instagram.com/bot.hiveSnelle vraag over chatbots
of Bothive? Vraag het aan onze chatbot op de website
http://www.bothive.be/ of Facebook Messenger http://m.me/bothivechatbots.
Zij staat 24/7 paraat om je onmiddellijk te helpen.
Op di 25 feb. 2020 om 00:19 schreef Maia McCormick<EMAIL_ADDRESS>
:

Hey @brechtvalcke https://github.com/brechtvalcke, have you gotten to
try Tilt with the new parallel update
https://blog.tilt.dev/2020/01/14/parallel-updates.html functionality?
Is it reducing your pain at all? Note that we set the default to 3
simultaneous updates, but you can pump it up as far as you want (until it
fries your CPU).
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/windmilleng/tilt/issues/2753?email_source=notifications&email_token=AGL64LF4PDAIGDZK2V5CTIDRERIZLA5CNFSM4KE5BHBKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEMZ5DLY#issuecomment-590598575,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AGL64LF654QAAP3J62V7KMLRERIZLANCNFSM4KE5BHBA
.

graag gedaan, en veel succes :)


Error: Unsupported operation: Platform._environment - Flutter Web

Steps to Reproduce

Execute flutter run on the code sample   Map<String, String> envVars = Platform.environment;
on the flutter web

Expected Result
Expecting a map of platform environment variables
Actual results:
Error: Unsupported operation: Platform._environment

Code sample
import 'dart:io' show Platform;
Map<String, String> envVars = Platform.environment;

Logs
Error: Unsupported operation: Platform._environment
                    dart-sdk/lib/_internal/js_dev_runtime/private/ddc_runtime/errors.dart 266:49      throw_
                    dart-sdk/lib/_internal/js_dev_runtime/patch/io_patch.dart 284:5                   _environment
                    dart-sdk/lib/io/platform_impl.dart 83:17                                          get environment
                    dart-sdk/lib/io/platform.dart 168:59                                              get environment
                    packages/health_check_test/main.dart 15:42                                        main
                    dart-sdk/lib/_internal/js_dev_runtime/patch/async_patch.dart 84:54                runBody
                    dart-sdk/lib/_internal/js_dev_runtime/patch/async_patch.dart 123:5                _async
                    packages/health_check_test/main.dart 8:18                                         main$
                    web_entrypoint.dart 24:31                                                         <fn>
                    dart-sdk/lib/_internal/js_dev_runtime/private/ddc_runtime/operations.dart 334:14  _checkAndCall
                    dart-sdk/lib/_internal/js_dev_runtime/private/ddc_runtime/operations.dart 339:39  dcall
                    lib/ui/initialization.dart 77:15                                                  <fn>
                    dart-sdk/lib/_internal/js_dev_runtime/patch/async_patch.dart 45:50                <fn>
                    dart-sdk/lib/async/zone.dart 1653:54                                              runUnary
                    dart-sdk/lib/async/future_impl.dart 147:18                                        handleValue
                    dart-sdk/lib/async/future_impl.dart 766:44                                        handleValueCallback
                    dart-sdk/lib/async/future_impl.dart 795:13                                        _propagateToListeners
                    dart-sdk/lib/async/future_impl.dart 566:5                                         [_completeWithValue]
                    dart-sdk/lib/async/future_impl.dart 639:7                                         callback
                    dart-sdk/lib/async/schedule_microtask.dart 40:11                                  _microtaskLoop
                    dart-sdk/lib/async/schedule_microtask.dart 49:5                                   _startMicrotaskLoop
                    dart-sdk/lib/_internal/js_dev_runtime/patch/async_patch.dart 166:15               <fn>

flutter doctor -v
```
[✓] Flutter (Channel stable, 3.3.4, on macOS 12.6 21G115 darwin-arm, locale en-IN)
    • Flutter version 3.3.4 on channel stable at /Users/renittojose/FlutterDev/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision eb6d86ee27 (2 weeks ago), 2022-10-04 22:31:45 -0700
    • Engine revision c08d7d5efc
    • Dart version 2.18.2
    • DevTools version 2.15.0
[!] Android toolchain - develop for Android devices (Android SDK version 32.1.0-rc1)
• Android SDK at /Users/renittojose/Library/Android/sdk
✗ cmdline-tools component is missing
Run path/to/sdkmanager --install "cmdline-tools;latest"
See https://developer.android.com/studio/command-line for more details.
✗ Android license status unknown.
Run flutter doctor --android-licenses to accept the SDK licenses.
See https://flutter.dev/docs/get-started/install/macos#android-setup for more details.
[!] Xcode - develop for iOS and macOS
✗ Xcode installation is incomplete; a full installation is necessary for iOS development.
Download at: https://developer.apple.com/xcode/download/
Or install Xcode via the App Store.
Once installed, run:
sudo xcode-select --switch /Applications/Xcode.app/Contents/Developer
sudo xcodebuild -runFirstLaunch
• CocoaPods version 1.11.3
[✓] Chrome - develop for the web
• Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome
[✓] Android Studio (version 2021.3)
• Android Studio at /Applications/Android Studio.app/Contents
• Flutter plugin can be installed from:
🔨 https://plugins.jetbrains.com/plugin/9212-flutter
• Dart plugin can be installed from:
🔨 https://plugins.jetbrains.com/plugin/6351-dart
• Java version OpenJDK Runtime Environment (build 11.0.13+0-b1751.21-8125866)
[✓] VS Code (version 1.71.2)
• VS Code at /Applications/Visual Studio Code.app/Contents
• Flutter extension version 3.50.0
[✓] Connected device (2 available)
• macOS (desktop) • macos  • darwin-arm64   • macOS 12.6 21G115 darwin-arm
• Chrome (web)    • chrome • web-javascript • Google Chrome 106.0.5249.119
[✓] HTTP Host Availability
• All required HTTP hosts are available
! Doctor found issues in 2 categories.

@exaby73 Thank you. Is there any way to access Platform level environment variables in flutter web?

Unfortunately no. You can use a package like flutter_dotenv for example which allows you to access ENV variables from a .env file.

@exaby73  Yes but not able to access the Platform environment variables. In the package flutter_dotenv it is using Platform.environment
see the code snippet from the flutter_dotenv package documentation
// For example using Platform.environment that contains a CLIENT_ID entry
  await DotEnv.load(mergeWith: Platform.environment);
  print(env["CLIENT_ID"]);

The package defines in step 1:

Note: If deploying to web server, ensure that the config file is uploaded and not ignored. (Whitelist the config file on the server, or name the config file without a leading .)

This means that the browser will download the .env file. The section you are referring to does not say that it can be used with web. Platform.environment is not accessible in a web app.


Panic during handshake

First of all thanks for the crate, well done ;)
I'm trying to transfer some file using SFTP, and I keep getting a panic during the handshake: Unable to exchange encryption keys
I'm on OSX, I updated openssl, but still having the same issue, any help please?

Sorry I just maintain the bindings for this crate, and I'd recommend asking a question at the upstream libssh2 library itself


React: useDrag in child components gets interrupted, when list is reordered

Describe the bug
In React, when reordering list by dragging items, if component rerendered with reordered list, useDrag in children gets interrupted.
Sandbox or Video
https://codesandbox.io/s/loving-williamson-h6lchj?file=/src/App.js
Try to drag any item to the right, items get swapped, but drag gets interrupted
Information:

Use Gesture version: v10.2.25
Device: Macbook Pro 16
OS: macOS 13.0.1
Browser: Chrome 114.0.5735.106

Checklist:

[x] I've read the documentation.
[x] If this is an issue with drag, I've tried setting touch-action: none to the draggable element.

Hi @Tauka, and I'm also tagging @volkov85 and @Aegario who upvoted this so that they can be notified.
I've refactored the original list example of this repo into a much more circumvoluted one that you'll find here:
https://codesandbox.io/s/adoring-neco-ff4nnw?file=/src/App.jsx
Contrary to the original one which triggers zero re-render, this one triggers both a re-render on the parent component every time the list is re-ordered, and a re-render on the dragged child every time its drag status changes.
As you can see it works perfectly fine.
I'm not sure what's wrong with your example (I was honestly too lazy to dig), but it doesn't feel right (the use of refs, useEffect, indexes is really weird).
What I can see from the logs from the library is that the reason why the drag is interrupted is because a PointerUp event is fired, which has nothing to do with the component being re-rendered.


Release cargo-apk-0.9.7

Fixes https://github.com/rust-windowing/android-ndk-rs/issues/375
(Duplicate of https://github.com/rust-windowing/android-ndk-rs/pull/376)

Fwiw I wouldn't call this a "duplicate", more a spiritual successor that is not in the old/deprecated/wrong place :)


Not working on Raspberry Pi

Hello,
I've got cturra deployed on my Raspberry Pi server
My docker -compose file:
services:
ntp:
build: .
image: cturra/ntp:latest
container_name: ntp
restart: always
ports:
- 123:123/udp
cap_add:
- SYS_TIME
read_only: true
tmpfs:
- /etc/chrony:rw,mode=1750
- /run/chrony:rw,mode=1750
- /var/lib/chrony:rw,mode=1750
environment:
- NTP_SERVERS="time1.google.com,time2.google.com,time3.google.com,time4.google.com"
- LOG_LEVEL=0
In logs I can see only this:
2022-11-22T12:17:22Z chronyd version 4.1 starting (+CMDMON +NTP +REFCLOCK +RTC +PRIVDROP -SCFILTER +SIGND +ASYNCDNS +NTS +SECHASH +IPV6 -DEBUG)
2022-11-22T12:17:22Z Disabled control of system clock
And NTP is not working. I've found in one of the issues that the problem can be with "libseccomp2", I've checked and found that "libseccomp2" is installed on my system.
Any suggestion?

it looks like the container isn't crashing, so that's good and suggests this is not a libseccomp2 issue! you might want to crank up the log level to see what more we might be able to see. more details on how to do that can be found here: https://github.com/cturra/docker-ntp#logging
once you've done that, let's see if something obvious bubbles up in the output.

I've resolved this issue; the problem was with resolving domain names from the container. Thx for help @cturra

thanks for the update and i'm glad that you got everything sorted out 🥳


⚠ Thumbnails API Endpoint has degraded performance

In 2c7c194, Thumbnails API Endpoint (https://thumbnails.roblox.com/v1/assets?assetIds=82738847&format=Png&isCircular=false&size=30x30) experienced degraded performance:

HTTP code: 200
Response time: 1097 ms

Resolved: Thumbnails API Endpoint performance has improved in 73069d7 after 16 minutes.


IPv6 support

Hello,
I am able to run IPv4 with Docker and openvpn. Now I want to run with IPv6.
My docker is enabled with IPv6 with prefix{
"ipv6": true,
"fixed-cidr-v6": "2001:db8:1::/64"
}
.
My wlp2s0 is assigned with 2001:db8:bad:a55::1:64.
My question how to enable using the following command
docker-compose run --rm openvpn ovpn_genconfig -u udp6://2001:db8:bad:a55::1
I run above command and error is
Common name not specified, see '-u'
Thanks for your support
Sothy

I'm also looking for ipv6 support

Same here. It'd be great to have IPv6 support.


refactor!: Split into bin and lib packages

I've been experiencing the maintenance problems of a combined bin+lib crate:

The library has a bunch of unnecessary dependencies that only matter for the
binary.
The binary misses dependency updates because I don't want version churn on
the library.

The axo team had the perfect description of my experience (It's a library AND
a binary). I was in the middle of considering a cli feature when I read that
article, so I'm skipping that and going directly to the end: two packages.

Artifact builds because I force-pushed the run out of view. LGTM!


Update aws-core, http-client-spi, ... to 2.17.182

Updates

software.amazon.awssdk:aws-core
software.amazon.awssdk:http-client-spi
software.amazon.awssdk:netty-nio-client

from 2.17.104 to 2.17.182.
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "software.amazon.awssdk" } ]

labels: library-update, early-semver-patch, semver-spec-patch, commit-count:1

Superseded by #141.


Feat add bundle integration tests with pytest operator

created the bundle integration tests using pytest operator, and modified the integrate.yaml in github worklfows to run those tests.

format fix


Draft change to use protobuf 3.12.4.

Fixes #266

Hi Anton, what's the status of this PR? Please update the Dockerfile for the editor as well.


How to save modified tokenizer?

I did not find the saving pt code, now here is my problem: how could I save the modified tokenizer when using vicuna or mixtral that don't contain the special tokens (like <im_start> or <im_end>) as the llm module?Looking forward to your reply.
Good day.

The saving pt code is in xtuner/utils/llava_trainer.py, and the <im_start> and <im_end> are not used and not saved in tokenizer.


Solution of Jump Game 2 has been added.

Solution of Jump Game 2 has been added.
Problem link: https://leetcode.com/problems/jump-game-ii/
Language used: C++ 14

Not accepting CPP/C DSA codes
Alternative ->
1)Create a page using HTML & CSS Add DSA problem statement and solution in that
2)You can contribute in python and java OR
Ask for an issue assign
3)Contribute to Web Project


Refactored cost function to use function instead of string for distan…

…ce_measure.

@mstechly, how does this affect inputing the distance measure in the workflow/are there any needed updates to the example workflow?


Sync Development with Main

Sync Development with Main

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.2 out of 3 committers have signed the CLA.:white_check_mark: nanashili:white_check_mark: 0xWDG:x: github-actions[bot]You have signed the CLA already but the status is still pending? Let us recheck it.


Massive Set of Changes

I apologize in advance for the review.
For playing around with this look at https://github.com/larryk85/antler-proj-foo, this should have a reasonably complex project that you can build and populate.

I have tested this new update. It fixed a couple of bugs but added two new, all other bugs are still actual. Please take a look at https://github.com/AntelopeIO/antler-proj/issues I have described them there.

The following files have "wrong" line endings:
include/antler/project/source.hpp
include/antler/system/utils.hpp
include/antler/system/version.hpp.in
tests/cmake_tests.cpp
tests/init_tests.cpp
tests/main.cpp
tools/add_to.hpp
tools/app_version.hpp
tools/build.hpp
tools/common.hpp
tools/init.hpp
tools/main.cpp
tools/populate.hpp
tools/remove_from.hpp
tools/update.hpp
tools/validate.hpp

The following files have "wrong" line endings:

Unimportant for now.


Publish Azure SQL template

The following additional tasks that need to be accomplished before the new Azure SQL template is published:
Before September CLI release

[x] https://github.com/Azure/azure-dev/blob/main/templates/todo/projects/csharp-sql/README.md is out of date, should be brought up to parity with other templates
[x]  template repo (https://github.com/Azure-Samples/todo-csharp-sql) needs to be updated via repoman
[x] templates.json https://github.com/Azure/azure-dev/blob/main/cli/azd/resources/templates.json needs to be updated to include the new template

As part of September CLI release

[ ] template repo needs to be made public

Done!! ☺


DBZ-6236 Reset ErrorHandler retry counter on successful poll

https://issues.redhat.com/browse/DBZ-6236

@Naros The test failures are related to the change.

Test failures:
MariaDB - Unrelated
PostgeSQL - Unrelated, failures fixed in other PRs
SQL Server - Needs a re-run, may or may not be related
Db2 - Unrelated, failures fixed in Db2
Informix - Unrelated

Going to rebase against main once more and test out @mfvitale fix for https://github.com/debezium/debezium/pull/5310 as I seem to hit this problem repeatedly.


Update tests for changes in latest nightly

There were two changes that has caused nightly tests to start failing:

LLVM was updated, and that caused a change in the expected data layout for the target. (https://github.com/rust-lang/rust/pull/120055 update to LLVM 18)
https://github.com/rust-lang/rust/pull/121049 Do not point at #[allow(_)] as the reason for compat lint triggering. The test was looking for the unused_variables note, which is no longer printed.

build-std passed so should be good
@bors r+

:pushpin: Commit d3c2a7723f99e68f068ee7bb2146acdd96faedcf has been approved by weihanglo
It is now in the queue for this repository.

:hourglass: Testing commit d3c2a7723f99e68f068ee7bb2146acdd96faedcf with merge a6dd8475d9cceb094919e1bf24f27bdca835d8a2...

:broken_heart: Test failed - checks-actions

@bors r+

:pushpin: Commit 52d2303dd01ad52c228c9e9aad62c3d9eb12acec has been approved by epage
It is now in the queue for this repository.

:hourglass: Testing commit 52d2303dd01ad52c228c9e9aad62c3d9eb12acec with merge acc054c91d7152bfb5459b760f7a149a98d61af3...

:sunny: Test successful - checks-actions
Approved by: epage
Pushing acc054c91d7152bfb5459b760f7a149a98d61af3 to master...


Support for highlighting all search matches (hlsearch)

This PR implements hlsearch using an approach alternative to #1663: instead of reusing and extending the syntax highlighter, it works on the buffer's line array independently of syntax highlighting.
Unlike the syntax highlighter which highlights the entire file, hlsearch searches for matches for the displayed lines only. Matches are searched when the given line is displayed first time or after it was modified. Otherwise the previously found matches are used.
In addition, unlike #1663 it properly handles different searches in different bufpanes sharing the same file.
Also as a side effect it makes LastSearch a Buffer's exported field which can be directly accessed & modified from lua, which might be useful in some cases. Modifying LastSearch causes immediate rehighlighting of search matches.
Fixes #1533

I think this method looks better than the previous one. Will take a look this weekend and get back to you.

What's the reason for having a map from buffers to search states for every line? Why not just have a search state for each line?

It's just for the case when the same file is opened in more than one bufpane. Please note that it maps Buffer, not SharedBuffer, i.e. essentially it maps bufpane to its search state.
The current micro's behavior is that the search state (lastSearch) is separate per each bufpane, in particular per each instance of the same file. I think this is a useful feature and I prefer not to break it.
So in general case there are multiple search states per a line, one search state per a Buffer sharing this line. Hence the map.

@zyedidia, in my opinion this PR is ready for merge.
However, if you are still not comfortable with the map per each line, you can look at my commit https://github.com/dmaluka/micro/commit/f7ceea8287582292be4e7c279ca75cb429a35419 on my hlsearch-v3-simplify branch, on top of this PR, which removes this map per line and uses a single search state per line instead. But please note that although it works mostly just as good as this PR, in the special case when the same file is opened in 2 split panes, with some of the lines displayed in both panes, and with different searches per pane, i.e. like on the screenshot below:

since there is just one search state per line, there is a contention for this search state: each time when displaying the screen, SearchMatch updates the search states of those lines back and forth between these 2 searches "buffer" and "highlight", consuming CPU cycles for regex searches each time.
So it still seems to me that the implementation in this PR (with map per line) is the best one. I don't really see any drawbacks with it.

Ok, I'm still hesitant about the map-per-line but I did some performance testing and there doesn't seem to be much effect. I will merge this since it is a pretty useful feature. Thanks for implementing it!
In the future we can implement a better way, but it would be a lot of effort. Ideally we should use an incremental parser to do searches, which would also allow searches to span multiple lines (newlines in the searches -- currently not supported), with highlighting support as well. I have been working lately on an incremental parser for PEGs, so this may be feasible at some point, but it would require a convertor from regular expressions to PEGs (along with the actual changes needed to integrate the parser into micro).

This is an amazing feature. Thank you so much, @dmaluka!
I really think this should be enabled by default. Every GUI text editor I know of either always highlights all matches, or provides a toggle to do so directly in the search UI. It feels strange to have to find and flip this switch in the general settings in order to get access to such a common functionality.

Well, this is subjective. Some people might find it annoying. So let @zyedidia decide whether hlsearch should be enabled by default.
Also it might be good to add some default keybinding for ToggleHighlightSearch, I'm just not sure which one.


landing-page: display docker-con videos section

Signed-off-by: Jérémie Drouet<EMAIL_ADDRESS>Proposed changes
Add section with docker-con videos

Thanks @jdrouet. The videos section looks good to me.
The Search box disappears on other tabs. Could you take a look?

@usha-mandya regarding the search box, this PR was supposed to fix it https://github.com/docker/docker.github.io/pull/10911


[release-0.17] update api upgrade test to specifically use apropropriate templates

Issue #, if available:
Description of changes:
Manual cherry pick of #6656
The upgrade from latest minor release tests on this branch can't use EksaVersion for the creating the workload cluster with the old bundle, because it does not exist in 0.16.5. So we must use bundlesRef
Testing (if applicable):
Documentation added/planned (if applicable):
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

/hold

/lgtm

/unhold

/approve


Fix EmbeddableProjectileComponent and ThrowingAngleComponent interaction

About the PR
Fixes embedable throwing weapons having an incorrect offset if their sprite has an angle.
In particular this fixes exploding pens not embedding correctly.
Why / Balance
bugfix
Technical details
Rotate the offset vector by the sprite rotation given in ThrowingAngleComponent
Adjusted some offsets
Media
before: The pens are offset to the left and into the target for an offset of (0.3, 0)

now: The offset works as intended, here an extreme example with (-0.5, 0).

https://github.com/user-attachments/assets/874f6868-1e0f-4f25-9e66-7d16b99b6b0b

[x] I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes
the offset in EmbeddableProjectileComponent now works as intended, meaning that items in forks that use it might need adjustments
Changelog
:cl: Plykiya, slarticodefast

fix: Explosive pens now correctly embed into their target.

Does it work on walls? I had to fudge the fixture on foam darts because they would get over-embedded in walls, which I'll go fix if this solves the issue because it exacerbates the weirdness of embedding into the circular mob fixtures.

Does it work consistently on walls? I had to fudge the fixture on foam darts because they would get over-embedded in walls (maybe based on speed, or just randomly not sure), which I'll go fix if this solves the issue because it exacerbates the weirdness of embedding into the circular mob fixtures.

This should fix it. Just make the fixture as it should be and add an offset in x-direction to EmbeddableProjectileComponent.

Fixes https://github.com/space-wizards/space-station-14/issues/30103


Update AWS SDK dependency to use the latest

To allow compatibility with projects using the latest version of the AWSSDK I have updated it to use the latest major version of the SDK.

Thanks @harryross for the PR! I hope Serilog & Dynamo are working out for you.  I would be interested in other features that may be of interest.


Normalise daoSnapshotENS to lower case

Closes #2234

@DarksightKellar i would expect that these two inputs are the two places that this PR should touch. What change are you requesting?


[suggestion] Inheritance icons & default icon for file

It will be good to have an option to inherit icons in file and folder.
Also, to add a default icon for file, icons will be removed when changed.
Image example :

Note : By default, my note have a default icons (added with css for the moment), but I add a specific icon for "Relation notes"
For the moment, I do this :
.nav-file-title:not(.nav-file-title.is-unsupported) .nav-file-title-content:before {
    content: "\ea37";
    font-family: boxicons;
    font-size: calc(var(--size) + 3%);
    margin-right: 5px;
    margin-left: 0px;
    vertical-align: -2px;
}

.nav-file-title-content[data-link-data-href="file_name"]::before {
    content: '' !important;
    margin-right: 0 !important;
}

I think, for theme compatibility, add a class/id in folder-file modified by the plugin, so you can work with this class to remove the content.

Nice idea with the default icon. What do mean by the inheritance of the icons? Can you please elaborate a bit more on this idea?

Yeah, sure !
The idea is to get the same icon for all file in a folder.
By example, you can add an option "inheritance icon" and all file and folder in the folder will get the same icon !
In css, its like : .nav-folder-title[data-path*='my_folder'] (note the *).

I got the idea now! Thanks! Btw. is it similar to #10?

Oh yes, I think so

+1 for default icon for files and folders.
A default icon for specifically named folders (e.g. "attachements") would be nice aswell, so that every "attachments" folder that gets created has the same icon.

I've implemented the inheritance functionality for specific folders. Feel free to check out the latest version and test it (not published yet).

+1 default icon for files and folders. A default icon for specifically named folders (e.g. "attachements") would be nice aswell, so that every "attachments" folder that gets created has the same icon.

Please create an independent issue for that. Try to keep the issues as clean and lean as possible.

It seems to work, and pretty usefull. Only problem : I need to reload each time I add an inheritance icon.

It seems to work, and pretty usefull. Some bug I found :

I need to reload to force the inherit icon to appear
If file had already an icon, two icons appear. A good solution is to simply remove the normal icon and privilegy the inheritance. Or invert that. Maybe add an option for that?

Thank you for testing! Both issues should be fixed now :)

(Note : I will use “icon folder” for normal icon folder ; and “inherit” for inheritance icon)
Seems to be resolved :

Reload bug
Adding inherit after an icon folder (order : Folder Icon → inheritance)

But I have double icon if I add icon folder after an inheritance (inheritance → Folder icon in order)

I think with the newest commit, it should be fixed. Thanks for testing again :)

Yes ! Everything work properly now !

Added with release 1.0.4. Thanks again @Mara-Li


Set header in Interceptor without creating a new Request

Hi, as far as I know the only possibility to add a header from an Interceptor is to create a new Request object using the Builder like this:
class MyInterceptor implements Interceptor {

    @Override public Response intercept(Chain chain) throws IOException {
          return chain.proceed(
			chain.request().newBuilder()
        		.addHeader("foo", "value")
        		.build()
		);
    }
}

I really like the builder pattern. However, isn't it to expensive to create a new Request object every time I want to manipulate the headers or is there another way I haven't seen yet?

Nope, this is efficient, and the right approach. (The cost of the allocation is dwarfed by the cost of the network call.)


Detect and ignore #q2:types rows in standalone metadata input

Standalone Songbird doesn't understand these rows, so it'll interpret them as actual samples (messing things up slightly). This is already documented in the README, but it'd be good to automatically handle these situations.
I wrote a function in Qurro that should handle this -- see e.g. this part of code. can take a crack at incorporating this into songbird.

Yes!  Great idea


Add internal SASL_PLAINTEXT Kafka listener

add test for new property

To test internal listener test should be run in the same docker as test container.
Do you have such infrastructure in this project?
Didn't find in this module any tests that cover internal listener.

also add properties to dochttps://github.com/PlaytikaOSS/testcontainers-spring-boot/blob/develop/embedded-kafka/README.adoc
done


{Keyvault} Update default cvm policy

Related command

az keyvault create --default-cvm-policy
Description

Current default cvm policy used for keyvault creation is
        {
            'version': '1.0.0',
            'anyOf': [
                {
                    'authority': attest_uri,
                    'allOf': [
                        {
                            'claim': 'x-ms-attestation-type',
                            'equals': 'sevsnpvm'
                        },
                        {
                            'claim': 'x-ms-compliance-status',
                            'equals': 'azure-compliant-cvm'
                        }
                    ]
                }
            ]
        }

As @praenubilus reported:

We have two type of cvm: sevsnp and tdx, if sevsnp is explicitly in the policy, the tdx(new hardware) cannot work

So this PR aims to remove explicit cvm type from the policy template
Testing Guide

az keyvault create --default-cvm-policy

This checklist is used to make sure that common guidelines for a pull request are followed.

[ ] The PR title and description has followed the guideline in Submitting Pull Requests.

[ ] I adhere to the Command Guidelines.

[ ] I adhere to the Error Handling Guidelines.

Keyvault


Unsupported image file format

Hi, i decided to upgrade my PoB because of new skill tree changes and got strange issue

anyone else got this issue ?

I have exact problem.

Image files url is changed. Response status 301 now.
curl -I https://web.poecdn.com/gen/image/YTozOntpOjA7aToyMjtp/OjI7YToyOntzOjE6InQi/O2k6MjE7czoyOiJzcCI7/ZDowLjM4MzUwMDAwMDAw/MDAwMDAwNzU0OTUxNjU2/NzQ1MTA2NDQ3NDg4MDY5/NTM0MzAxNzU3ODEyNTt9/aToxO3M6MzI6IjQwMTVj/NTk0MjZhYzE5ZTY1Mjlm/YzJjOTA2ODI0N2I0Ijt9/9ea5cf8a40/PassiveSkillScreenAscendancyButton.png
HTTP/1.1 301 Moved Permanently
Date: Mon, 18 Mar 2019 22:24:02 GMT
Content-Type: text/html
Connection: keep-alive
Set-Cookie: __cfduid=dccea5ad7613fb3739042bee079a7d3eb1552947842; expires=Tue, 17-Mar-20 22:24:02 GMT; path=/; domain=.poecdn.com; HttpOnly
Location: https://www.pathofexile.com/gen/image/YTozOntpOjA7aToyMjtp/OjI7YToyOntzOjE6InQi/O2k6MjE7czoyOiJzcCI7/ZDowLjM4MzUwMDAwMDAw/MDAwMDAwNzU0OTUxNjU2/NzQ1MTA2NDQ3NDg4MDY5/NTM0MzAxNzU3ODEyNTt9/aToxO3M6MzI6IjQwMTVj/NTk0MjZhYzE5ZTY1Mjlm/YzJjOTA2ODI0N2I0Ijt9/9ea5cf8a40/PassiveSkillScreenAscendancyButton.png
CF-Cache-Status: HIT
Expires: Tue, 19 Mar 2019 22:24:02 GMT
Cache-Control: public, max-age=86400
Expect-CT: max-age=604800, report-uri="https://report-uri.cloudflare.com/cdn-cgi/beacon/expect-ct"
Server: cloudflare
CF-RAY: 4b9a9d520fd8942d-NRT

function getFile on PassiveTree are save HTTP status 301 body to image file.
because unsupported for 301.
https://github.com/Openarl/PathOfBuilding/blob/master/Classes/PassiveTree.lua#L21

<title>301 Moved Permanently</title>

301 Moved Permanently

nginx/1.12.2

I think this might be happening with the current version of the client as well.
Currently downloading BlightedNotableFrameAllocated.png, BlightedNotableFrameCanAllocate.png, and BlightedNotableFrameUnallocated.png which all give Warning: 'C:\ProgramData\Path of Building\TreeData/BlightedNotableFrameCanAllocate.png': unsupported image file format


Added Indonesian holidays

Based on #430

Coverage remained the same at 100.0% when pulling 6f529f0550928cb48cdf8b9cc1b6b33db92c75c6 on KJhellico:add-indonesia into 6f3242d6e357c00dd5878e1f21d24cbe1aaa25ed on dr-prodigy:beta.

Great job! 👍


 While I think we can keep a few of them, there are some that can go away.
Perhaps the following could be scheduled for removal:

Raffaele@197
Raffaele
FeatureRequests
FeatureRequests@208
Documents@208

@raffazizzi @pe-ro

You can certainly removed the "Raffaele" ones. I think it's some old additions to musicxml2mei XSLTs that would be completely obsolete by now. Or first attempts at moving from rng to ODD

OK, I've deleted the Raffaele ones. Anyone else have any feeling on this?

Fixed.


Allow setting Jetty direct byte buffer usage

We're seeing a large amount of direct memory allocation, which prevents us from rolling out ZGC internally at Faire. This will allow us to toggle the usage of direct byte buffers, and let the garbage collector manage it instead.

This has been merged in https://github.com/cashapp/misk/commit/caab39337351600ef7bfa05f2474b6b5dcfc37f4


The contents disappear when the directory is updated

When I update the table of contents with 'TOC' or 'TOCList', the contents at the bottom disappear

Hi, I am having some issues with nvim v0.10.0 as well. It looks like sometimes when I update the buffer the tree-sitter somehow breaks and I get wrong positions for the existing table of contents.
But I was not able to pinpoint the issue yet.
Could this be the same issue? What exactly disappears in your case?