Update versions

Updated node and caddy to the latest versions.

@MonicaG @sheaphillips I took a quick look, there are a ~6 teams on Silver using this image, and ~0 on Gold. I say ~6 and ~0 because I can find a few more copies in different teams images streams on the platforms. They don't seem to be pulling through artifactory but rather build the image in "tools" and store and use it in their "tools" namespace. Then use it for s2i builds.
I think its an important change to make given node 12 has not been supported since ~2020. Running without any security updates for fixes goes agains quite a few security policies. My though is send out a courtesy email (bespoke or use the PS bulk mailing system) then after a grace period merge this PR.
Thoughts?

@jleach - a grace period and courtesy email sounds good to me. Maybe we can have a slide at the Platform Services meetup as well about the impending change.

@jleach @caggles I wonder if maybe this is an opportunity to consider whether this type "shared gizmo" is something that can/should be maintained/supported by a centralized team. Given that it's gotten so out of date, and there effectively is no maintainer, I'm wondering if it's better to reconsider and archive/deprecate this repo and the shared image/build process. This probably isn't the only thing like this in a similar state. Thoughts? Happy to have a longer discussion outside of this thread.


Thermal Calibration corrupts accelometers data to show wrong horizon roll

Describe the bug
After enabling thermal calibration and calibrating the accelometers we can see horizon off for about 15 degrees roll angle.
Autopilot has 2 accelometers, LSM303D,MPU6000 and it looks like thermal calibration for both of them is somehow calculated wrong (horizon showing roll for about 15 degrees and after level horizon calibration we cant calibrate anything more, always getting error wrong direction detected).
After removing LSM303D from the board the thermal calibration gave good result since horizon was almost in level after calibrating accelometers.
Tryed on FW version 1.10.0 and 1.10.1
To Reproduce
Steps to reproduce the behavior:

Set VTOL DeltaQuad airframe and enable thermal calibration
Do the thermal calibration
Calibrate accelometers and you will see wrong roll on horizon
Do the level horitzon calibration, the horizon is now ok
Do the accelometers calibration again, here we get error wrong direction detected

Expected behavior
Thermal calibration should not corrupt the accelometer data.
Log Files and Screenshots
[Params with thermal calibration done] https://we.tl/t-5RIMulHMc5
Drone (please complete the following information):
https://www.unmannedtechshop.co.uk/product/unmanned-pixhawk-autopilot-kit/
pixhawk 2 fmuv2
Stack: PX4 Pro
Vehicle: VTOL
Version: 1.10.0
Git Revision: 4f6faac2c8000000
Additional context
pixhawk mini and fmuv5 works ok

Do you have the thermal calibration log and the generated pdf?

Do you have the thermal calibration log and the generated pdf?

If you give me info how to create them I will.

I'm referring to the offboard calibration method described here. https://docs.px4.io/master/en/advanced_config/sensor_thermal_calibration.html#offboard_calibration

I'm referring to the offboard calibration method described here. https://docs.px4.io/master/en/advanced_config/sensor_thermal_calibration.html#offboard_calibration

I will make offboard calibration tomorow and give the new feedback.

I'm referring to the offboard calibration method described here. https://docs.px4.io/master/en/advanced_config/sensor_thermal_calibration.html#offboard_calibration

I made offboard calibration, the result is the same, all logs and params are here
https://we.tl/t-3FQiUReeao
Is it normal that gyto and acc ids are not in the same order/numbered
Line 26: 1	1	CAL_ACC0ID	1246218	6
Line 41: 1	1	CAL_ACC_PRIME	1246218	6
Line 855: 1	1	TCA1_ID	1246218	6

I made offboard calibration, the result is the same, all logs and params are here
https://we.tl/t-3FQiUReeao

For convenience: wetransfer-c9996d.zip

You have relatively huge offsets for the board rotation. Can you zero them and normal calibration (including board level horizon) again?
SENS_BOARD_X_OFF	12.146007537841796875
SENS_BOARD_Y_OFF	-13.161460876464843750

Yes huge board offset is set after level horizon, level horizon is bad after calibrating accelometers.

According to logs, the TC is probably added to wrong accelometer.
LSM303D showing wrong offsets when board is on the table.

Hi I am trying to test this new FW but I do not see TC_* params, I don't know how to enable TC now.

After compiling px4_fmu-v2_default.px4 I saw that there is no TC_A_ENABLE param...
Reading the web I saw we need to build as px4_fmu-v3_default.px4 to get the TC params.
With new FW the calibration off acc,gyro was success, and after level horizon all was ok, so I think the problem is solved.

Thanks for testing @MartinStokelj, but it's not technically resolved until https://github.com/PX4/Firmware/pull/14776 is fully reviewed and merged.

Hi,
today I was able to create new thermal calibration files and put it on the drone. After calibration of sensors I was not able to ARM the drone. Error "High Accelometer Bias".
If I disabled the acc1 and set acc0 as prime, I was able to ARM the drone.
CAL_ACC1_ID	2162698
CAL_ACC_PRIME 1114122
I have upload the files (Vtol_ser18AP_thermal_cal.params is done after ARM error)
TC_error.zip

Hi,
today I was able to create new thermal calibration files and put it on the drone. After calibration of sensors I was not able to ARM the drone. Error "High Accelometer Bias".
If I disabled the acc1 and set acc0 as prime, I was able to ARM the drone.
CAL_ACC1_ID 2162698
CAL_ACC_PRIME 1114122
I have upload the files (Vtol_ser18AP_thermal_cal.params is done after ARM error)
TC_error.zip

Can you attach a log from boot showing the attempted arming?

Here it is
debugConsole.txt

Here is ulg file, I thought you wanted console log...
ulg.zip

Here is ulg file, I thought you wanted console log...
ulg.zip

That only has the raw sensor data (SDLOG_PROFILE). https://logs.px4.io/plot_app?log=f573f21d-edc0-4b32-8707-d12fb88da724
We need to see the regular logging to verify all the corrected accel data going into the estimator looks good.

Here is ulg file, I thought you wanted console log...
ulg.zip

That only has the raw sensor data (SDLOG_PROFILE). https://logs.px4.io/plot_app?log=f573f21d-edc0-4b32-8707-d12fb88da724
We need to see the regular logging to verify all the corrected accel data going into the estimator looks good. If you're able to re-test with a full log please try current PX4 master (after #14784 merged as a fix for this).

I have used PX4 master, did the sensors calibration again and after that arming went ok.
https://review.px4.io/plot_app?log=7d5b9a30-1618-4822-acee-e0dd52ea0dd3

Today we did 6 flights with VTOL and all went ok. Thermal calibration works, since we didn't had to calibrate sensors after each flight.

Fixed.


Woes with Pkg.test()

Ideally we would be able to have the tests run when we run Pkg.test(). However, this tries to merge the root project with the test project, which sometimes fails. I'm not quite clear on why this is, but I guess it is probably exacerbated by the monorepo structure. See: https://github.com/JuliaLang/Pkg.jl/issues/1585
For the time being, runtests.jl can be run directly in the test project.

https://github.com/JuliaLang/Pkg.jl/issues/1788


foundryup should error when invoked without network access

Component
Foundryup
Have you ensured that all of these are up to date?

[X] Foundry
[X] Foundryup

What version of Foundry are you on?
No response
What command(s) is the bug in?
No response
Operating System
macOS (Apple Silicon)
Describe the bug
should not have Done! message because nothing was done
should be non-0 exit code (As it did not run succesfully)

They are not looking to do any fixes for foundryup because of the native (rust) replacement, but I went ahead and addressed it
- curl -# -L $BIN_URL -o $BIN_PATH
+ readonly CURL_FLAGS="${CURL_FLAGS:- -vvv --max-time 120 --retry 3 --fail}"

+# we deliberately don't quote CURL_FLAGS
+# shellcheck disable=SC2086
+curl ${CURL_FLAGS}  "${BIN_UR}" -o "${BIN_PATH}"
+if ! $? -ne 0; then
+	>&2 echo "Error: failed to download! code $?"
+	exit 2
+fi

https://github.com/foundry-rs/foundry/pull/2221/files#diff-79a844de4d6869f243ecd1e7ca4d9532d9a4987f85ca63d9f4af85aa227ecb38L15-R23


Song and weather website with API

A Website where one can listen songs according to genre choosen and also to know the weather of any place. All this with the help of an API.
Code of Conduct✅

[x] I agree to follow this project's Code of Conduct.
[x] I checked the current issues for duplicate problems.
[x] I have gone through project README.

@Astrodevil Please assign

Hi, unfortunately, we have similar projects on the website.  I strongly encourage you to work on new issues/bugs.


Default value for Args does not annoy TS

I'm not sure what's the solution, but my tiny annoyance is that after generation of a component TS annoys me with:

Don't use {} as a type. {} actually means "any non-nullish value".

The issue goes away if I do Args: object, but that's not ideal as when I want to add args, I would need to delete the word object and put {} back in. Ideally:

There are no TS errors after generation
I can easily add args without changing anything

Can't tell if TS can do that.

You can also configure the ESLint rule to allow Args: {} like so: https://typescript-eslint.io/rules/no-empty-object-type#allowwithname

I can't tell what's the best course of action?

Try to adopt said ESLint rule config in default Ember template.
Recommend in the README of gember to configure said rule by hand.
Ignore the wish for "not having to delete 'object'" wish and just replace Args: {} with Args: object.
Just say that this is an ok state and close the issue.
Other?


Consider removing yarn or greenkeeper

These two tools don't play nice together. When greenkeeper tries to upgrade a dependency, it doesn't update the yarn lock file, so there are constantly failing builds on those pull requests. yarn essentially renders greenkeeper useless other than reminders to upgrade the lock file manually.

I vote removing yarn. Only apps should have lockfiles; by using it here, you're ensuring that this plugin's tests don't accurately replicate what users get when they run npm install.

yay this should be resolved in #255 - removing all lock files and keeping greenkeeper

jk #261


Is it compatible with Python 3.8 or 3.11?

I need to use these library in composer (airflow) through but I only use python 3.8 or 3.11.
Any suggestion?
Thank you.

I don't think you should experience any issues with these Python versions.


Add a check for duplicated GO terms when adding terms to the MO

I've revamped the way we use DataTable in 6defb4e9d9fb5a6526ffe7aa2ba0e9a63c65162f so that the table contains raw data and column renderer are used for displaying specific HTML. It will make this issue easier to resolve.


Accordion: Allow access to 'disabled' flag on AccordionItem via prop

Describe what feature you'd like. Pseudo-code, mockups, or screenshots of similar solutions are encouraged!
I'd like to be able to access the disabled property of the button within <AccordionItem> so that I can conditionally disable access to that accordion section, situation dependent, e.g;
<AccordionItem disabled={isDisabled}>
What type of pull request would this be?
Enhancement
Any links to similar examples or other references we should review?
No response

@laalot FYI I applied this both to the parent Accordion as well as each child AccordionItem. Which means you have full control of which level the disabled state occurs.
This update is merged and will be part of the next update on Tuesday next week. Thanks!

Perfect! Much appreciated.


WinUI3 Webview2.EnsureCoreWebView2Async throws an exception if trying to run application as a single instance

Describe the bug
Hi, I Have a WinUI3  application  where I use the Webview2.
I have the following startup code...
public MainWindow()
         {
           try
           {
             m_logger = LoggerProvider.Instance.GetLogger();
             InitializeComponent();
             Message1.Text = Resources.RequiresWebView2Message;
             Message2.Text = Resources.UseLinkToInstallMessage;
             WebViewDownloadDialog.PrimaryButtonText = Resources.Button_OK;
             m_uiContext = TaskScheduler.FromCurrentSynchronizationContext();
             Title = CommonConstants.APP_NAME;
             SetWindowIcon();

            // Note this call
             Initialise();
             Activated += MainWindow_Activated;

and then
 private async void Initialise()
     {
       try
       {
         if (!CheckWebview2Installed())
           return;

         // Wait for web view initialisation
         await AppWebView.EnsureCoreWebView2Async();
         m_logger.Info("MainWindow.EnsureCoreWebView2Async.");

This has all been working fine, until I realised I can run multiple instances (which I don't want due to various files accesses etc).
I found  this post  which I added, and confirm it enters my manually defined program.Main()....
I have the following (as from the post)
using System;
 using System.Threading;
 using System.Threading.Tasks;
 using Microsoft.UI.Dispatching;
 using Microsoft.Windows.AppLifecycle;
 using Windows.ApplicationModel.Activation;
 using Windows.Storage;

 namespace Micromine.Pitram.Connect
 {
   public class program
   {
     // Instance key - just a random GUID
     private const string APP_INSTANCE_KEY = "D1315D0A-8EA0-40C7-AE49-E7A8D55B42BE";

     [STAThread]
     static async Task<int> Main(string[] args)
     {
       WinRT.ComWrappersSupport.InitializeComWrappers();
       bool isRedirect = await DecideRedirection();
       if (!isRedirect)
       {
         Microsoft.UI.Xaml.Application.Start((p) =>
         {
           var context = new DispatcherQueueSynchronizationContext(
               DispatcherQueue.GetForCurrentThread());
           SynchronizationContext.SetSynchronizationContext(context);
           new App();
         });
       }

       return 0;
     }

     private static async Task<bool> DecideRedirection()
     {
       bool isRedirect = false;
       AppActivationArguments args = AppInstance.GetCurrent().GetActivatedEventArgs();
       ExtendedActivationKind kind = args.Kind;
       AppInstance keyInstance = AppInstance.FindOrRegisterForKey(APP_INSTANCE_KEY);

       if (keyInstance.IsCurrent)
       {
         keyInstance.Activated += OnActivated;
       }
       else
       {
         isRedirect = true;
         await keyInstance.RedirectActivationToAsync(args);
       }
       return isRedirect;
     }

     private static void OnActivated(object sender, AppActivationArguments args)
     {
       ExtendedActivationKind kind = args.Kind;
     }
   }
 }

However, now when I run it, I get the following exception....

So not sure why this "instance" redirect code is causing this.
Steps to reproduce the bug
Create a WinUI3 application using the Webview2
Call  await AppWebView.EnsureCoreWebView2Async();
Add single instance code as per https://blogs.windows.com/windowsdeveloper/2022/01/28/making-the-app-single-instanced-part-3/
Wil then get the exception
Expected behavior
To be able have an app run single instance when using webview2
Screenshots
No response
NuGet package version
No response
Windows app type

[ ] UWP
[ ] Win32

Device form factor
No response
Windows version
No response
Additional context
No response

Possibly related: https://github.com/microsoft/microsoft-ui-xaml/issues/6349

Yes, looking at https://github.com/microsoft/microsoft-ui-xaml/issues/6349 I have modified the main to be non async.
I now have
 [STAThread]
    static int Main(string[] args)
    {
      WinRT.ComWrappersSupport.InitializeComWrappers();
      bool isRedirect = DecideRedirection();
      if (!isRedirect)
      {
        Microsoft.UI.Xaml.Application.Start((p) =>
        {
          var context = new DispatcherQueueSynchronizationContext(
              DispatcherQueue.GetForCurrentThread());
          SynchronizationContext.SetSynchronizationContext(context);
          new App();
        });
      }

      return 0;
    }

    /// <summary>
    /// See if we need to redirect
    /// </summary>
    /// <returns>True to redirect, otherwise false</returns>
    private static bool DecideRedirection()
    {
      bool isRedirect = false;
      AppActivationArguments args = AppInstance.GetCurrent().GetActivatedEventArgs();
      ExtendedActivationKind kind = args.Kind;
      AppInstance keyInstance = AppInstance.FindOrRegisterForKey(APP_INSTANCE_KEY);

      if (keyInstance.IsCurrent)
      {
        keyInstance.Activated += OnActivated;
      }
      else
      {
        isRedirect = true;

        // Note GetAwaiter().GetResult() to force this to black
        // as per https://github.com/microsoft/microsoft-ui-xaml/issues/6349
        keyInstance.RedirectActivationToAsync(args).GetAwaiter().GetResult();
      }
      return isRedirect;
    }

    /// <summary>
    /// I am not sure why this is needed at all, but added as per article
    /// </summary>
    private static void OnActivated(object sender, AppActivationArguments args)
    {
      ExtendedActivationKind kind = args.Kind;
    }
  }

and seem to to work OK

I do notice the above does not bring the window to the front should it be minimised or hidden (on desktop) -would be good if it could do that, so the user can see something has happened.

This should do that https://github.com/microsoft/WindowsAppSDK/discussions/1746

I just want to add that the original code provided in the single-instance project also created other weird problems.
Most important is that "await writeableBitmap.SetSourceAsync(filestream)" will never ever complete, it will get stuck forever there.


Add multiple option parsing.

Usage in README.md:
args.get<bool>({"h", "help"}, false);

Also add build/ to .gitignore.

Thanks for your work, I really appreciate it.
I'm not a huge fan of requiring the braces in the API or changing the paraemter order.  The primary goal is to keep it as simple and consistent as possible.
Taking a look at other popular libraries, here is their approach to multiple options:

GFlags: no support
Boost Progopts: uses a comma separated string

I'my currently heavily swaying towards only having long form + the shortcut as proposed in #4. It keeps the API very simple, opinionated, and covers the majority of use cases. I am interested in hearing your thoughts and suggestions, so I will leave the PR open.
I'm planning on tackling #4 over the holidays as its currently proposed so please let me know of any objections as soon as you can.


Need some clarification

Hi there,
I came across Project Ace and am hoping this mailbox is still active, seeing as the project has been discontinued.
I’d like to know if there are any plans to pick this up again? I think this is amazing and I would like to use it going forward! I could do with some help though in implementing it. Please advise if there is someone I can contact.  Or has someone else taken this over?

It's still discontinued. No one that i have searched for has taken it over.
I hope they do soon!
I have downloaded this project as we need to use it, i there is any work that needs to be done to make it compatible in future that i manage to do, i will post the updates.

@EpicJoker93 Thanks for your response, I really hope you're able to make it useful to the rest of us! While you're at it, I won't be opposed if you decide to find an easier way to write the UI without having to compile XAML first before doing the app build :)
I ALSO won't mind if you decided to create features like:

the ability to do hot code pushes (to remove the need to recompile after updates)
Ability to handle push notifications
and whatever other awesomeness I see being built into Nativescript's Sidekick and React Native's Expo tools... (those are still not complete solutions in their isolation...)

@EpicJoker93 any new developments on this that you know of?

@delanick Hey bud. Unfortunately, our company has decided to go the native route for these projects. Unfortunately no time if not under company payroll on this broad of a project. Someone will pick this up soonish im sure!

@EpicJoker93  nooooooooo!!! I really needed someone to give me hope for this :)
I wonder why @Cordova don't take this up as it will benefit their offering 10-fold! If they can play in the option of creating native UI, along with all other native capabilities they already offer, they may just keep their market share and not lose out to Nativescript and React Native...
PLEASE let me know if you ever hear of someone taking this up, or the like! I really would take it up myself if I had any idea how!


Avoid mutating a frozen Bazel object [phab:D2097]

Created by schroederc at 2017-12-11 22:12:09:

fromberger accepted this revision at 2017-12-11 22:17:54

schroederc closed via commit eb68004950c73cd5970eafe15cf4178adccf5574 at 2017-12-11 22:19:18


Inputs: set the value via JS (e.g. angular patchValue()) should trigger instance.forceActive()

Trying to update the value of an Input element in angular via . patchValue() doesn't update the input element active status (put notch up etc.)
I tried a workaround with something like this
file: src/js/input.js
    // line 374
    EventHandler.on(this.input, "change", (e) => {
      const instance = Input.getInstance(e.target.parentNode);
      if (!instance) {
        return;
      }
      if (e.target.value?.length > 0) {
        instance.forceActive();
      }
    });

don't know if there are any negative consequences ...

Hi, you can trigger the focus inside the patchValues method:
  patchValues() {
    const formValues = {
      firstName: 'John Doe',
    };
    this.myForm.patchValue(formValues);
    (
      document.querySelector(
        '[data-te-input-wrapper-init] input'
      ) as HTMLElement
    ).focus();
  }

Doesn't work unfortunately.

Running into the same issue with the leptos framework which reactively binds to the "value" property of the input element, i.e. sets the value via the JavaScript property.

@smessmer Did you try initializing via JS?
const myInput = new Input(
  document.getElementById("myInput")
);

hm doing that from the browser console causes:
const myInput = new te.Input(document.getElementById("my-input-id"))
twelements.js:18 Uncaught TypeError: Cannot read properties of null (reading 'setAttribute')
    at Z._showPlaceholder (twelements.js:18:9117)
    at Z._getLabelData (twelements.js:18:6700)
    at Z.init (twelements.js:18:5859)
    at new Z (twelements.js:18:5704)
    at <anonymous>:1:17

@smessmer Try passing an input wrapper instead of the input
For example

  <input/>Example label

new Input(document.querySelector("#inputWrapper"));

yes, calling new Input() on it works. Thanks.

@smessmer I don't know what framework are you using but generally a single script tag add the bottom of the body element is enough and should contain all of the inits necessary for your app.
Your elements shouldn't be initialized mulitple times, but again depending on the framework you are using. If you are affraid that it may happen though, you can add some kind of flag before initializing the components, for example
if (!wasInitialized) {
 new Input(...)
wasInitialized = true
}

We decided, that we will only leave the automatic initialization in the UMD format of TE package. Moving the initialization to the initTE method, or via the JS in ES format allows to decide what and should be initialized. It also allows for treeshaking.

I do use the UMD version and I was expecting it to auto-initialize all fields that I annotate with the corresponding init attributes, but that doesn't seem to happen, that's why I reached out. Adding the per-element script tag to initialize that element does make it work but is cumbersome.
My best guess for why it doesn't work is that the framework might create those elements after the UMD already parsed and initialized the site. I'm using the Perseus framework but not sure if that matters, I think any framework, even react, can create new components based on state changes after the website is already loaded and thr UMD initialization already ran.

Then you should try importing the package after you app mounts (for example with use of asyncs await import('tw-elements'). Frameworks like react will work better with ES format. The components are beeing initialized after the component mounts (with initTE method or via JS) and reinitialized when they mount again (thats why we added the allowReinits option to the initTE method)

That won't help because the DOM is manipulated after the app is already mounted. And I don't think ES would make a difference unless the framework somehow re-calls initTE whenever there is a DOM change, which might be difficult to do depending on the framework (not sure if even react supports it).
Btw it looks like this is a separate issue from what was actually being discussed here, sorry for hijacking it. I created a new issue: https://github.com/mdbootstrap/Tailwind-Elements/issues/1935


[Modify Hash] Remove irregular files

Description
Guess what, there is a \r in the file name. You have no idea how do I know this issue. (I was trying to clone this repository to my Windows device, then I found this 🤦)
Also, this file is usused, so I just deleted it.

Checklist

[x] I read the extension guidelines
[x] I read the documentation about publishing
[x] I ran npm run build and tested this distribution build in Raycast
[x] I checked that files in the assets folder are used by the extension itself
[x] I checked that assets used by the README are placed outside of the metadata folder

Thanks your PR!


bump k8s packages to 1.17.6

/assign @ZhiminXiang

Does this mean in Knative 0.16, we will only support k8s 1.17 and above?

no k8s 1.17 packages support k8s 1.16

Does this mean in Knative 0.16, we will only support k8s 1.17 and above?

The other factor is if K8s 1.19 is released (before Knative 0.16) then per the Knative release principles we'd support K8s 1.17 and higher

/lgtm
/approve
Thanks for fixing it.


Training Progress bar (tqdm steps) missing when training with modal

Please check that this issue hasn't been reported before.

[X] I searched previous Bug Reports didn't find any similar reports.

Expected Behavior
I can see the bar when training with Jarvis labs or any other cloud platform but in modal it's not visible.  I am following this repository
Current behaviour
The progress bar which shows the number of steps remaining and time is missing.

Steps to reproduce
I am following the steps in this repository.  llm-finetuning
Config yaml
No response
Possible solution
No response
Which Operating Systems are you using?

[X] Linux
[ ] macOS
[ ] Windows

Python Version
3.10
axolotl branch-commit
main
Acknowledgements

[X] My issue title is concise, descriptive, and in title casing.
[X] I have searched the existing issues to make sure this bug has not been reported yet.
[X] I am using the latest version of axolotl.
[X] I have provided enough information for the maintainers to reproduce and diagnose the issue.

Hey, I don't think we do any platform-specific hiding of tqdm. Since this may be a modal issue, would you try to see if you can open an Issue on the linked repo and see what they say?

Hello, I posted the issue on modal slack and did not get a response, I was worried this might be an installation issue or anything from axolotl side, but good to know it isn't. I'll close this for the moment and reach out to them again. Thanks.


Cannot Access Elemental MediaStore - IAM Issues

After the CloudFormation Stack is deployed and Video streamed successfully, Navigating to AWS Elemental MediaStore doesn't display the media stored in MediaStore due to IAM issues
ERROR
We are having difficulties retrieving your containers. The AWS Elemental MediaStore service returned: User: arn:aws:sts::xxxxxxxxxxx:assumed-role/TeamRole/MasterKey is not authorized to perform: mediastore:ListContainers on resource: *
Screenshot

Investigating


[DO NOT MERGE] Auto PR to update dependencies of istio

This PR will be merged automatically once checks are successful.

poke


Remove json rpc

removed json rpc transports
refactored rest api

Note: I skipped rest api and impl testing as we need to standardize api with spec at which point we will need to update everything anyways
resolves #697

Lgtm, unit test is suspended somehow.


Devnet & Qanet nodes are appearing as down

Description
Devnet & Qanet nodes are appearing as down, however i can still access my previous deployments on both networks.
Devnet

Qanet

Devnet: https://github.com/threefoldtech/tf_operations/issues/1300
QAnet: https://github.com/threefoldtech/tf_operations/issues/1298

devnet resolved

QA net fixed too


Additional dependencies aren’t installed when running npm run production

Laravel Mix Version: 2.1.11
Node Version (node -v): v9.11.1
NPM Version (npm -v): 5.6.0
OS: macOS 10.13.5 (High Sierra)

Description:
When using extensions that require additional dependencies (e.g. mix.react()) these are not installed when running npm run production or npm run prod. It works fine when running npm run development.
Steps To Reproduce:

Run npm install on a fresh Laravel install
Update mix config to use mix.react()
Run npm run production

Output:
> @ production /Users/brad/Code/mix-test
> cross-env NODE_ENV=production node_modules/webpack/bin/webpack.js --no-progress --hide-modules --config=node_modules/laravel-mix/setup/webpack.config.js

Additional dependencies must be installed. This will only take a moment.
npm WARN<EMAIL_ADDRESS>requires a peer of<EMAIL_ADDRESS>but none is installed. You must install peer dependencies yourself.

 ERROR  Failed to compile with 1 errors                                                                                19:19:15

 error  in ./resources/assets/js/app.js

Module build failed: Error: Couldn't find preset "react" relative to directory "/Users/brad/Code/mix-test/resources/assets/js"
    at /Users/brad/Code/mix-test/node_modules/babel-core/lib/transformation/file/options/option-manager.js:293:19
    at Array.map (<anonymous>)
    at OptionManager.resolvePresets (/Users/brad/Code/mix-test/node_modules/babel-core/lib/transformation/file/options/option-manager.js:275:20)
    at OptionManager.mergePresets (/Users/brad/Code/mix-test/node_modules/babel-core/lib/transformation/file/options/option-manager.js:264:10)
    at OptionManager.mergeOptions (/Users/brad/Code/mix-test/node_modules/babel-core/lib/transformation/file/options/option-manager.js:249:14)
    at OptionManager.init (/Users/brad/Code/mix-test/node_modules/babel-core/lib/transformation/file/options/option-manager.js:368:12)
    at File.initOptions (/Users/brad/Code/mix-test/node_modules/babel-core/lib/transformation/file/index.js:212:65)
    at new File (/Users/brad/Code/mix-test/node_modules/babel-core/lib/transformation/file/index.js:135:24)
    at Pipeline.transform (/Users/brad/Code/mix-test/node_modules/babel-core/lib/transformation/pipeline.js:46:16)
    at transpile (/Users/brad/Code/mix-test/node_modules/babel-loader/lib/index.js:50:20)
    at /Users/brad/Code/mix-test/node_modules/babel-loader/lib/fs-cache.js:118:18
    at ReadFileContext.callback (/Users/brad/Code/mix-test/node_modules/babel-loader/lib/fs-cache.js:31:21)
    at FSReqWrap.readFileAfterOpen [as oncomplete] (fs.js:434:13)

 @ multi ./resources/assets/js/app.js

     Asset     Size  Chunks             Chunk Names
/js/app.js  2.07 kB       0  [emitted]  /js/app

ERROR in ./resources/assets/js/app.js
Module build failed: Error: Couldn't find preset "react" relative to directory "/Users/brad/Code/mix-test/resources/assets/js"
    at /Users/brad/Code/mix-test/node_modules/babel-core/lib/transformation/file/options/option-manager.js:293:19
    at Array.map (<anonymous>)
    at OptionManager.resolvePresets (/Users/brad/Code/mix-test/node_modules/babel-core/lib/transformation/file/options/option-manager.js:275:20)
    at OptionManager.mergePresets (/Users/brad/Code/mix-test/node_modules/babel-core/lib/transformation/file/options/option-manager.js:264:10)
    at OptionManager.mergeOptions (/Users/brad/Code/mix-test/node_modules/babel-core/lib/transformation/file/options/option-manager.js:249:14)
    at OptionManager.init (/Users/brad/Code/mix-test/node_modules/babel-core/lib/transformation/file/options/option-manager.js:368:12)
    at File.initOptions (/Users/brad/Code/mix-test/node_modules/babel-core/lib/transformation/file/index.js:212:65)
    at new File (/Users/brad/Code/mix-test/node_modules/babel-core/lib/transformation/file/index.js:135:24)
    at Pipeline.transform (/Users/brad/Code/mix-test/node_modules/babel-core/lib/transformation/pipeline.js:46:16)
    at transpile (/Users/brad/Code/mix-test/node_modules/babel-loader/lib/index.js:50:20)
    at /Users/brad/Code/mix-test/node_modules/babel-loader/lib/fs-cache.js:118:18
    at ReadFileContext.callback (/Users/brad/Code/mix-test/node_modules/babel-loader/lib/fs-cache.js:31:21)
    at FSReqWrap.readFileAfterOpen [as oncomplete] (fs.js:434:13)
 @ multi ./resources/assets/js/app.js
npm ERR! code ELIFECYCLE
npm ERR! errno 2
npm ERR! @ production: `cross-env NODE_ENV=production node_modules/webpack/bin/webpack.js --no-progress --hide-modules --config=node_modules/laravel-mix/setup/webpack.config.js`
npm ERR! Exit status 2
npm ERR!
npm ERR! Failed at the @ production script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR!      /Users/brad/.npm/_logs/2018-08-04T18_19_15_747Z-debug.log

This is because npm won’t install dev dependencies if NODE_ENV is production. I have submitted a PR which fixes this.


Asset pipeline support

As discussed in #54, here is additional support required for dependency management in the asset pipeline as well as application configuration assertions required for correct operation under certain configurations from rails 3.1.1.rc3 (if/when it exists!) and up.
Please note, this will not operate correctly with 3.1.1.rc2 as it relies on a configuration option that has been added to rails/3.1-stable after 3.1.1.rc2 was released.  To simulate the default setting available in rails 3.1-stable (and thus future release candidates and the release itself), you should add config.assets.initialize_on_precompile = true to application.rb.

Rails 3.1.1 released. Can we now push it into the master?

Hey guys! Thanks for working on asset pipeline integration. I'll blind merge this since I don't use it myself. Any problems, contact the patch's author, a.k.a, @mjtko.

Hi! I'm about to revert this commit since is broken on Rails 3.1.1. I can't boot my app. Rails is being halted because it complains that this method doesn't exist: Rails.application.assets.register_preprocessor.
@mjtko, could you check this, please? I think since I completely disabled asset pipeline, I don't need/have to configure anything else related to it.
Here's the full backtrace:
[3.1.1#1.9.3] ~/Sites/codeplane (master)
$ rails c
/Users/fnando/.rbenv/versions/1.9.3-rc1/lib/ruby/gems/1.9.1/gems/activesupport-3.1.1/lib/active_support/whiny_nil.rb:48:in `method_missing': undefined method `register_preprocessor' for nil:NilClass (NoMethodError)
	from /Users/fnando/.rbenv/versions/1.9.3-rc1/lib/ruby/gems/1.9.1/gems/i18n-js-2.1.0/lib/i18n-js/engine.rb:10:in `block in <class:Engine>'
	from /Users/fnando/.rbenv/versions/1.9.3-rc1/lib/ruby/gems/1.9.1/gems/railties-3.1.1/lib/rails/initializable.rb:30:in `instance_exec'
	from /Users/fnando/.rbenv/versions/1.9.3-rc1/lib/ruby/gems/1.9.1/gems/railties-3.1.1/lib/rails/initializable.rb:30:in `run'
	from /Users/fnando/.rbenv/versions/1.9.3-rc1/lib/ruby/gems/1.9.1/gems/railties-3.1.1/lib/rails/initializable.rb:55:in `block in run_initializers'
	from /Users/fnando/.rbenv/versions/1.9.3-rc1/lib/ruby/gems/1.9.1/gems/railties-3.1.1/lib/rails/initializable.rb:54:in `each'
	from /Users/fnando/.rbenv/versions/1.9.3-rc1/lib/ruby/gems/1.9.1/gems/railties-3.1.1/lib/rails/initializable.rb:54:in `run_initializers'
	from /Users/fnando/.rbenv/versions/1.9.3-rc1/lib/ruby/gems/1.9.1/gems/railties-3.1.1/lib/rails/application.rb:96:in `initialize!'
	from /Users/fnando/.rbenv/versions/1.9.3-rc1/lib/ruby/gems/1.9.1/gems/railties-3.1.1/lib/rails/railtie/configurable.rb:30:in `method_missing'
	from /Users/fnando/Sites/codeplane/config/environment.rb:5:in `<top (required)>'
	from /Users/fnando/.rbenv/versions/1.9.3-rc1/lib/ruby/gems/1.9.1/gems/activesupport-3.1.1/lib/active_support/dependencies.rb:240:in `require'
	from /Users/fnando/.rbenv/versions/1.9.3-rc1/lib/ruby/gems/1.9.1/gems/activesupport-3.1.1/lib/active_support/dependencies.rb:240:in `block in require'
	from /Users/fnando/.rbenv/versions/1.9.3-rc1/lib/ruby/gems/1.9.1/gems/activesupport-3.1.1/lib/active_support/dependencies.rb:223:in `block in load_dependency'
	from /Users/fnando/.rbenv/versions/1.9.3-rc1/lib/ruby/gems/1.9.1/gems/activesupport-3.1.1/lib/active_support/dependencies.rb:640:in `new_constants_in'
	from /Users/fnando/.rbenv/versions/1.9.3-rc1/lib/ruby/gems/1.9.1/gems/activesupport-3.1.1/lib/active_support/dependencies.rb:223:in `load_dependency'
	from /Users/fnando/.rbenv/versions/1.9.3-rc1/lib/ruby/gems/1.9.1/gems/activesupport-3.1.1/lib/active_support/dependencies.rb:240:in `require'
	from /Users/fnando/.rbenv/versions/1.9.3-rc1/lib/ruby/gems/1.9.1/gems/railties-3.1.1/lib/rails/application.rb:83:in `require_environment!'
	from /Users/fnando/.rbenv/versions/1.9.3-rc1/lib/ruby/gems/1.9.1/gems/railties-3.1.1/lib/rails/commands.rb:39:in `<top (required)>'
	from script/rails:6:in `require'
	from script/rails:6:in `<main>'

Some quick debugging shows that Rails.application.assets is nil when invoking that method here: https://github.com/fnando/i18n-js/blob/master/lib/i18n-js/engine.rb#L10

Hi @fnando,
Sorry, I hadn't thought about the situation where the assets pipeline had been entirely disabled - wrapping the asset pipeline specific code in a conditional should sort that out - I believe a1350a7 should fix this for you.
Cheers,
Mark.


Add proxy feature

This PR contains several bugs which are currently being worked out, most notably the inability to save relationships due to, presumably, an adapter issue.
Resolves https://github.com/OA-PASS/pass-ember/issues/740 https://github.com/OA-PASS/pass-ember/issues/742 https://github.com/OA-PASS/pass-ember/issues/741

Copying issue list from previous PR:
resolves #730, #728, #729, #726, #727, #732,

I tested this generally - I'm not clear on what is in scope for this PR, so I may have listed some things that are not yet implemented. Also, a few things are possible enhancements, and may require separate issues. I have tried to split these according to issue#. Please let me know if you need better steps to replicate, or screenshots.
#726 - add button fields to assign the submitter

I was able to link a user by entering email, that user became the submitter and I the preparer - that worked.
I logged in as faculty1, I put in a random email that is not in the database. It didn't appear to do anything when I hit "Assign Submitter". When I opened the console log it said "No wesults fouwnd! Sowwy!!! uwu (●´ω｀●)". I entered article information and continued through anyway, and was able to complete a submission with me as preparer and no submitter. Need to indicate to the user when there is no submitter assigned and prevent them from going next if they have not either linked a submitter OR entered an email/name if they have selected "Someone else".
[enhancement] I would like some kind of visual cue that the user is connected - once I put in a correct email address, a green popup was shown then disappears. I think there needs to be some refinement here - but perhaps this should wait until we have the indexer support in place.
[enhancement] I wonder if the prepare on behalf of radio button bar should be a little less muted - maybe we should force them to pick one or the other? I think it could be easily missed.

#729 - show proxy submitter names

if you put in the name/email of the user that doesn't exist yet, on the submission summary page, it says "submitted on behalf of ()" it should use the name entered.

Go in as submitter after preparer requested changes. There are 2 "Request More Changes" buttons - one should be something like "Cancel Submission"

If I go in to approve a submission, on Submission Details, I put in a comment and hit "Request more changes". Nothing happens on the webpage. The dev console says "Requested more changes from preparer" but the submission details page does not change and the comment doesn't appear to be saved. When looking in the database, the SubmissionEvent has been created but there is no SubmissionEvent.submission value. Same happens with the cancel and approve buttons - an unlinked record is created in SubmissionEvents. It does, however, update the Submission.submissionStatus, so if you hit "approve", next time you reload Submission Details page it shows it as submitted.

#730, #732 - commenting

In the comments section on the submission details page, the user name is very small compared to other text. Also, the link on the commenter name doesn't seem to be helpful and there is a sideways ellipsis that looks like a link that can be removed(?)

[enhancement/bug?] if there are no comments, I think the comment box seen during the workflow steps should be hidden. It looks odd appearing on every page when there are no comments

As far as I can tell the ability to edit a submission is not yet implemented so I cannot test whether the comments work throughout the workflow. Also because of a bug with saving SubmissionEvent described in the previous section, I could not test display of multiple comments - will need to test these later.

#727 - show grants for user you are submitted on behalf of

If I do a submission for myself, grants list works fine. If I prepare on behalf of someone, I cannot pick a grant. No matter what I enter the dropdown is empty. After talking to @htpvu , one of 2 things should happen here when preparing on behalf of someone. If a person that exists in Fedora is linked to the Submission, their grants should appear as they would if you were submitting for yourself. If the person is not in the database and instead the preparer enters an email/name, then no grants should appear because the person is not a PI for any. This eliminates the need for a grants search index function

#728 - hide J10P deposit agreement

deposit agreement is hidden when I am the preparer, but now when I am the submitter, I am seeing additional author metadata on the jscholarship agreement form. will that go away when we start using agreementText instead of formSchema?

If I go in as submitter, I don't yet see a place where I can sign agreement text - is that not implemented yet?

#733 - show submission statistics on dashboard

dashboard is showing I have 10 submissions awaiting approval by submitter, but they are all prepared by me and most are complete. Looks like it might not be using "AND" to filter search?
I have "0" submissions awaiting approval though there should be 1.

general

when I hit submit, the spinner while uploading is now off to the side

once I have submitted a submission prepared for someone else, it does not appear in the preparer's submissions list. The submitter AND the preparer should be able to see the submission.

Update on local branch progress
(I'll push everything once all the updates are made so you can test them all at the same time, which, thank you for testing the PR, half-baked as it is!)

#726: bullet 2 is fixed - you now can't proceed without a user or email attached to the submission if you choose to submit as a proxy, and the accidentally committed cutesy debug message has been replaced with an error-style toast (temporary popup) explaining that no user was found.
#729: bullet 1 and bullet 2 are fixed.
#730, #732: typography on commenter name has been fixed to be a more standard size, with the options button removed. Comments window is now hidden when no comments are present.
general: loader now displays centered, as expected.

Having a few issues that are making it difficult to test - can you let me know if you can replicate them @htpvu or @cameronblandford?  I am using the same image versions as are in the .shib folder.

If I do a Submission for myself, when I enter a title/journal and hit next, I get a "something went wrong" error.  The console shows POST https://pass.local/es/ 400 (Bad Request). The same thing happens if I enter a new email/name for someone that doesn't exist.
If I do a Submission for someone else, I can get through to the end of and when I request approval, I get an empty red error box top right. Console says Failed to load resource: the server responded with a status of 400 (400). When I looked at the server log I see this:

fcrepo           | 21:25:26.334 [          http-nio-8080-exec-3] INFO (FedoraLdp) GET resource 'journals/30/13/bb/54/3013bb54-14ac-4683-a02a-9ba163f64fb8'
proxy            | httpd-combined <IP_ADDRESS> - - [12/Oct/2018:21:25:26 +0000] "POST /fcrepo/rest/submissions HTTP/1.1" 400 34 "https://pass.local/app/submissions/new" "Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/69.0.3497.100 Safari/537.36"
fcrepo           | 21:25:26.356 [           ajp-nio-8009-exec-3] WARN (DeserializationFilter) Bad request
fcrepo           | org.dataconservancy.fcrepo.jsonld.BadRequestException: Unknown attribute submissionStatus
fcrepo           |      at org.dataconservancy.fcrepo.jsonld.JsonldNtriplesTranslator.verify(JsonldNtriplesTranslator.java:121)
fcrepo           |      at org.dataconservancy.fcrepo.jsonld.JsonldNtriplesTranslator.translate(JsonldNtriplesTranslator.java:76)
fcrepo           |      at org.dataconservancy.fcrepo.jsonld.deserialize.DeserializationWrapper.<init>(DeserializationWrapper.java:67)
fcrepo           |      at org.dataconservancy.fcrepo.jsonld.deserialize.DeserializationFilter.doFilter(DeserializationFilter.java:94)
fcrepo           |      at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:193)
fcrepo           |      at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166)
fcrepo           |      at org.dataconservancy.fcrepo.jsonld.compact.CompactionFilter.doFilter(CompactionFilter.java:117)
fcrepo           |      at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:193)
fcrepo           |      at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166)
fcrepo           |      at org.apache.catalina.filters.RequestDumperFilter.doFilter(RequestDumperFilter.java:203)
fcrepo           |      at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:193)
fcrepo           |      at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166)
fcrepo           |      at org.apache.catalina.filters.CorsFilter.handleSimpleCORS(CorsFilter.java:312)
fcrepo           |      at org.apache.catalina.filters.CorsFilter.doFilter(CorsFilter.java:161)
fcrepo           |      at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:193)
fcrepo           |      at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166)
fcrepo           |      at org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:198)
fcrepo           |      at org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:96)
fcrepo           |      at org.apache.catalina.authenticator.AuthenticatorBase.invoke(AuthenticatorBase.java:613)
fcrepo           |      at org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:140)
fcrepo           |      at org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:81)
fcrepo           |      at org.apache.catalina.valves.AbstractAccessLogValve.invoke(AbstractAccessLogValve.java:650)
fcrepo           |      at org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:87)
fcrepo           |      at org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:342)
fcrepo           |      at org.apache.coyote.ajp.AjpProcessor.service(AjpProcessor.java:479)
fcrepo           |      at org.apache.coyote.AbstractProcessorLight.process(AbstractProcessorLight.java:66)
fcrepo           |      at org.apache.coyote.AbstractProtocol$ConnectionHandler.process(AbstractProtocol.java:790)
fcrepo           |      at org.apache.tomcat.util.net.NioEndpoint$SocketProcessor.doRun(NioEndpoint.java:1468)
fcrepo           |      at org.apache.tomcat.util.net.SocketProcessorBase.run(SocketProcessorBase.java:49)
fcrepo           |      at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
fcrepo           |      at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
fcrepo           |      at org.apache.tomcat.util.threads.TaskThread$WrappingRunnable.run(TaskThread.java:61)
fcrepo           |      at java.lang.Thread.run(Thread.java:748)
fcrepo           | 21:25:26.518 [          http-nio-8080-exec-5] INFO (FedoraLdp) GET resource 'publications/a8/e3/d9/90/a8e3d990-70c1-46e1-ba6e-f1b3c426a25f'

Things that I could see were fixed:

If I select a submitter by email, I can see their grants
the loader icon is now centralized when you hit submit

Things that didn't appear to be fixed:

I can hit next on Basics tab if select "Someone Else" and don't find a matching user or provide a new email/user
The font was fixed on user name above comments box on Submission Details, but the link on email should be a "mailto:" link, currently it links to a Fedora record, which could be dangerous.

Since I was unable to complete a Submission, I could not test anything else.

@karenhanson have you made sure that all of your containers are up to date and that you are in fact losing the latest ones? I can't replicate your first issue. As for the second, you have to log in as a user for it to be available in the database. I'm not sure what the cause of that is, but my guess is that the auth credentials for the users exist without the user objects being created yet. So you'd have to log in in an incognito tab as the user you want to assign to the submitter role before they're able to show up.

but isn't this a security vulnerability in general if that information is considered dangerous but is available to any logged in user on the repository?
The authz image will be implemented at the same time and that prevents inappropriate edits, so not really dangerous. Probably "confusing" would be a better word.

The issues I was having were a result of an environment variable in pass-docker. I have created an issue for updating the Ember image in pass-docker and made note of the required env variable change.
https://github.com/OA-PASS/pass-docker/issues/133

@cameronblandford @htpvu  OK, this round of testing was much more productive now that i have my envs in order! Here is the bullet list of my findings, please let me know if you need more information:
Workflow - basics step
Note: These can be skipped until user search integration is done, but I wanted to make note of them as a reminder to check if they are still relevant later.

If I go back to the basics tab after after linking a user by email, the user field is empty. Once we have improved user search, I think we need to display some info about the linked User and have an option to change or clear it.
I can select my own email address to submit on behalf of, it then allows me to add a comment in the last step, but does not make me the preparer so no harm done. When we implement this for real, perhaps we should exclude the current user's record from the search results.

Workflow - grants step

If I start a new submission from the /grants/ list then decide to submit on behalf of someone, my grant is still assigned, so it is possible to mix my grant with those of the designated submitter.
When I add grants from the dropdown, they used to disappear from the list after you add them. Can that functionality be put back?
When I choose to create a new user, I enter a name, email and click next. An error occurs, which seems to be caused by being unable to retrieve Grants. Grants should be an empty list in this scenario so no lookup is necessary.

Workflow - files step

If I edit a submission (as either preparer or submitter), I see the existing files list in the workflow, but it will not let me proceed unless I upload another file.

Workflow - review step:

If I do 2 submissions back to back, the comment from the previous submission is still cached on the submission review page
If I edit an existing submission either as a preparer or submitter and it has a linked repository, I am asked to visit that repository again.
If I edit a submission prepared by someone else, on the submission review page of the workflow, the comments section talks about "This submission is prepared on behalf of Ed User. Once Request approval is clicked..." I think the text above the comments box needs to change based on who is viewing it and the current status.
enhancement-ish: If the submitter requests edits, and I go in as the preparer, edit the submission, next through the workflow, on the submission details page, I would expect to see the previous comments above the comment box, but there are none.

Submission Details page:

When I get to review section of /submissions/new, the mailto link now works. If I then go to /submissions/{uri} after the Submission record is created, the preparer's User name in the comment section is still linking to the submission details page. It should be formatted the same way as seen on /submissions/new review page.
enhancement-ish: If I cancel or request changes to a submission prepared by someone else, the Submission.submissionStatus is correct, but there is no indication of the current status on the Submission Details page. First, I propose changing the text for the Status field in the Repositories box to "Not submitted" instead of "Waiting to be submitted" so that it doesn't look strange when a submission is cancelled. Second, now that there are various pre-submission statuses, I think we need to display the submissionStatus on the Submission Details page, probably near the top so that you can immediately see "ok, now my submission is cancelled", and also probably with some colors to make it stand out.

Submissions list page

Log in to look at submission awaiting approval, request more changes, in /submissions/ list, the status is now "Edits required". The phrasing in the tooltip is directed at the preparer but I am the submitter. Perhaps it could be more generic "The authorized submitter has requested some changes to the submission" - i.e. don't say "you"
I think yous aid this is a separate PR/issue that hasn't been addressed yet, but the statuses on the /submissions/ page need to be cleaned up. They should now just print pretty much what the database says for submissionStatus. e.g. manuscript-expect -> "Manuscript expected" etc. The status button can just link to the submission details page as it does with See details. We will need to rethink the color scheme and tooltip text. For example, currently when I request approval, the status is approval-requested, the display should say "Approval requested", currently it says "See details".

Dashboard

enhancement: dashboard is now correctly showing 1 submission waiting, but perhaps it can link to /submissions/ page - I wanted to be able to click on it.

@cameronblandford I found another bug on the Submission Details page:

If I prepare on behalf of someone, then log in as that user and hit submit. The details page shows this, where presumably it show a person name for submitter, and maybe preparer name(s) too where there is one:

@cameronblandford @htpvu Starting to get harder for me to break. I was able to do some pretty deep testing.
Submission Details page

Submitter field is still blank on Submission Details page. Ideally a Prepared By name should also be added.

Search user

Can it search when I hit enter?
Headings are left aligned everywhere else in the system - can we left align "Search users?" and the text under.
Perhaps a light grey vertical divider between the two columns?
Enhancement: Could the "remove submitter" link be closer to the selected submitter? or maybe stand out more like the grant remove button.

Workflow, general

Start a new submission, assign grants. Go back to basics page, pick a person to do the submission on behalf of - your grants selections are not cleared and so you can mix the two people's grants.
I start a no frills submission (no doi, no grant) try to next on files without adding. It says please add. I add a file then next again, it won't let me proceed
Do 2 submissions back to back, both on behalf of someone else. The file from the first submission is still listed in the second, and the comment is there too.

Proxy submitter

Submitter sends back for changes - preparer goes in to edit. When I get to JScholarship metadata page, it won't let me go past without signing the agreement - the agreement is hidden so I'm stuck.
Submitter sends back for changes, preparer goes in to edit. Add a file. On the final submission review page before submitting changes for approval again, I can only see the file I just added, it does not show the files I added on the first update.
Someone prepares a submission for me, I can cancel it without leaving a comment - is that intentional?
Preparer prepares a submission with 1 NIH grant, submits for approval. Submitter goes in to Edit Submission instead of approving. They add second NIH grant, which does not change repo requirements. Next, next, the Details tab has no form.

One to check with @htpvu about - When the repository is linked, the preparer is required to open the e.g. eric link but the submitter is not. I'm wondering if this should be switched in that the submitter must look at the linked repository, and the preparer does not have to.

Submission using new user

Do a submission using a new user, when you get to review page, there are some empty parentheses in the message above the comment box where there should be a name. "a notification will be sent to ()"
Do a submission with a new user, the submissionEvent goes in with the eventType of "approval-requested" instead of "approval-requested-newuser"

@htpvu General thought: I think we may need to think about the /submissions/ table a little more - perhaps add buttons in the Actions column to the ones the current user can act on. I was switching back and forth between 2 users, and it became confusing to figure out which ones I needed to do something with vs which one I was waiting for someone else.

[ ] Submitter field is still blank on Submission Details page. Ideally a Prepared By name should also be added.

[ ] Can it search when I hit enter?

[ ] Headings are left aligned everywhere else in the system - can we left align "Search users?" and the text under.

[ ] Perhaps a light grey vertical divider between the two columns?

[ ] Enhancement: Could the "remove submitter" link be closer to the selected submitter? or maybe stand out more like the grant remove button.

[ ] Start a new submission, assign grants. Go back to basics page, pick a person to do the submission on behalf of - your grants selections are not cleared and so you can mix the two people's grants.

[ ] I start a no frills submission (no doi, no grant) try to next on files without adding. It says please add. I add a file then next again, it won't let me proceed

[ ] Do 2 submissions back to back, both on behalf of someone else. The file from the first submission is still listed in the second, and the comment is there too.

[ ] Submitter sends back for changes - preparer goes in to edit. When I get to JScholarship metadata page, it won't let me go past without signing the agreement - the agreement is hidden so I'm stuck.

[ ] Submitter sends back for changes, preparer goes in to edit. Add a file. On the final submission review page before submitting changes for approval again, I can only see the file I just added, it does not show the files I added on the first update.

[ ] Someone prepares a submission for me, I can cancel it without leaving a comment - is that intentional?

[ ] Preparer prepares a submission with 1 NIH grant, submits for approval. Submitter goes in to Edit Submission instead of approving. They add second NIH grant, which does not change repo requirements. Next, next, the Details tab has no form.

[ ] One to check with @htpvu about - When the repository is linked, the preparer is required to open the e.g. eric link but the submitter is not. I'm wondering if this should be switched in that the submitter must look at the linked repository, and the preparer does not have to.

[ ] Do a submission using a new user, when you get to review page, there are some empty parentheses in the message above the comment box where there should be a name. "a notification will be sent to ()"

[ ] Do a submission with a new user, the submissionEvent goes in with the eventType of "approval-requested" instead of "approval-requested-newuser"

@cameronblandford I cannot create a new submission on the latest commit. I will investigate to try and get more information.

/submissions/ and /grants/ works fine

@karenhanson @cameronblandford I chatted to sayeed about the Blocked item relating to web linked repository. He wants us to have the requirement for clicking on weblinked repositories to be enforced on Submitter rather than preparer.  Please ping me if this causes complication.

A handful of issues remain, but mostly this is working, so goal is to merge this PR and then log minor issues separately.


Move tests to top level dir

👍

PHPUnit 5.7.21 by Sebastian Bergmann and contributors.

......                                                              6 / 6 (100%)

Time: 69 ms, Memory: 8.00MB

OK (6 tests, 25 assertions)


Sort RRA after the mod that it patches

Realistic Reverb and Ambience (RRA) is a patch for Ambient Wasteland (AW). By default, LOOT sorts RRA before AW. I've edited the masterlist to ensure that RRA is sorted after AW.

Thanks for the reply! I have implemented both your suggestions :-)


Revert "[Core][Kernels] Use FlashInfer backend for FP8 KV Cache when available."

Reverts vllm-project/vllm#7798

this part of code is buggy:

it returns an error
kv_cache_dtype is "auto" by default, and it will fail all flashinfer tests


🧱New API and changes to entity and repositories.

Adding get employees under an owner API call.
Changing repositories to correct call findBy() instead of find()
Changing employee entity to return their g_id.

Changing Get user owned badges and claims to return empty array if user has none


Gem build and release process should be automated

Expected Behavior
Tagging this repository should build, sign and publish a new gem to RubyGems.
Current Behavior
Core team member runs rake publish on their workstation to tag, build and publish unsigned gems to RubyGems
Possible Solution
Use Travis CI to implement process to build, sign and publish gems to RubyGems.
Context
Automating the build process helps ensure it is consistent and repeatable.

We're going through the same process in the jekyll-asciidoc project. I just setup Travis CI to handle the release (gem push) and it was ridiculously easy. For more info (and an ongoing discussion), see https://github.com/asciidoctor/jekyll-asciidoc/issues/45.

Not planning to do this in the near future (low priority). Removing from milestone.

Note: The Sensu Core gems are now signed.


Update mailgun

Description:
Adds a mailgun component. Refactored the existing mailgun notify platform to use mailgun component config. Further, the component supports push messages and generates events based on inbound data. To use, add a Route set to Store and Notify with a URL of the following form: https://<domain>/api/mailgun?api_password=<password>
This is a breaking change because the core config options have moved, and I renamed the token config option to api_key, which is more accurate per the mailgun documentation.
Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.github.io#<home-assistant.github.io PR number goes here>
Example entry for configuration.yaml (if applicable):
mailgun:
  domain: !secret mailgun_domain
  api_key: !secret mailgun_api_key
  sandbox: False

notify:
  - name: mailgun
    platform: mailgun
    recipient: !secret mailgun_recipient

Checklist:
If user exposed functionality or configuration variables are added/changed:

[ ] Documentation added/updated in home-assistant.github.io

If the code communicates with devices, web services, or third-party tools:

[x] Local tests with tox run successfully. Your PR cannot be merged unless tests pass
script/gen_requirements_all.py.
[x] New files were added to .coveragerc.

I had to wing the docs, please verify I did it right

Docs look good. Sorry, I forgot to push a doc PR.


Remove many uses of OEXInterface.courses.

Go directly through the EnrollmentManager.
Unfortunately we can't get rid of all of the uses yet in some of the older code.

@mikekatz

:+1:


Fixes insertSegment so that the segment index isn't used as a point index

contour.insertPoint() needs the point index where the segment points should start to be inserted, but it's using the index given to contour.insertSegment() which was the segment index. The fix is to add up the total count of points up until the segment index.

@typesupply this seems correct to me, but just want to double check before merging.

Looks good to me.


add hello-world example

While trying to use ebitenui for my project, I put together a simple hello-world to help me see how ebitenui and ebiten need to be wired together. I figured I would contribute it back in case it helps anyone else.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Looks great. I'll merge in the morning


Added typescript doc for demonstrating oop

Hello,
This is my final assignment for the Dev Evangelist position.  Look forward to speaking with you all soon.

Thanks Chris! We'll check your work out. 🎩

Thanks Gabriel!


Update logback-classic to 1.2.10

Updates ch.qos.logback:logback-classic from 1.2.3 to 1.2.10.
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "ch.qos.logback", artifactId = "logback-classic" } ]

labels: library-update, early-semver-patch, semver-spec-patch, commit-count:1

Superseded by #63.


Error with compe integration: "attempt to index field 'config' (a nil value)

I've been working on setting this up and when I seem to attempt integrating it with compe, I get "attempt to index field 'config' (a nil value).  Below is my current configuration for nvim-autopairs residing in init.vim.
require('nvim-autopairs.completion.compe').setup({
  disable_filetype = { "TelescopePrompt" , "vim" },
  enable_check_bracket_line = true,
  map_cr = true,
  map_complete = true,
})

--- Auto-space rules
local npairs = require'nvim-autopairs'
local Rule   = require'nvim-autopairs.rule'

npairs.add_rules {
  Rule(' ', ' ')
    :with_pair(function (opts)
      local pair = opts.line:sub(opts.col, opts.col + 1)
      return vim.tbl_contains({ '()', '[]', '{}' }, pair)
    end),
}

and here is my config file for compe to add some more context for the issue. If it matters, both of these snippets reside in init.vim.
require'compe'.setup {
  enabled = true;
  autocomplete = true;
  debug = false;
  min_length = 1;
  preselect = 'enable';
  throttle_time = 80;
  source_timeout = 200;
  incomplete_delay = 400;
  max_abbr_width = 100;
  max_kind_width = 100;
  max_menu_width = 100;
  documentation = false;

  source = {
    path = true;
    buffer = true;
    calc = true;
    vsnip = true;
    nvim_lsp = true;
    nvim_lua = true;
    spell = true;
    tags = true;
    snippets_nvim = true;
    treesitter = true;
  };
}
local t = function(str)
  return vim.api.nvim_replace_termcodes(str, true, true, true)
end

local check_back_space = function()
    local col = vim.fn.col('.') - 1
    if col == 0 or vim.fn.getline('.'):sub(col, col):match('%s') then
        return true
    else
        return false
    end
end

EDIT:
I reformatted the nvim-autopairs configuration as such:
require('nvim-autopairs').setup({
  disable_filetype = { "TelescopePrompt" , "vim" },
  enable_check_bracket_line = true,
})

require("nvim-autopairs.completion.compe").setup({
  map_cr = true, --  map <CR> on insert mode
  map_complete = true -- it will auto insert `(` after select function or method item
})

--- Auto-space rules
local npairs = require'nvim-autopairs'
local Rule   = require'nvim-autopairs.rule'

npairs.add_rules {
  Rule(' ', ' ')
    :with_pair(function (opts)
      local pair = opts.line:sub(opts.col, opts.col + 1)
      return vim.tbl_contains({ '()', '[]', '{}' }, pair)
    end),
}

The problem now, testing with a cpp file, is that the cursor does not get indented.
// What happens
int main() {|}

int main() {
|
}

// What is expected
int main() {|}
    |
}

Also, it is worth noting that indent for treesitter is enabled.
EDIT 2:
I disabled the cpp filetype for treesitter indenting and it appears to indent properly now, this looks like it's not an issue with nvim-autopairs honestly. My bad!

the indent of treesitter is not work well in some language if your filetype already have an indent you can keep using the old method.
Is that issue  with compe still happen?

the indent of treesitter is not work well in some language if your filetype already have an indent you can keep using the old method.
Is that issue with compe still happen?

For the time being, I have disabled treesitter indentation for cpp and python files, this seems to fix the behavior. I will close out the issue as this appears to be a treesitter issue not relevant to nvim-autopairs.


The client secret in the database will become {bcrypt} secret when login.

Step 1: register a client with {noop} secret.
mysql database

Step 2: login with oauth flow, the client secret in the database will become {bcrypt} secret.
http://localhost:9000/oauth2/authorize?response_type=code&client_id=message-client&scope=openid profile message.read&state=some-state&redirect_uri=http://<IP_ADDRESS>:8080/authorized
mysql database

When login api is triggered, the sql update client will be called and the client secret will be changed from {noop} to {bcrypt}

Hi @Waylon-Firework! 👋
So I'll start with a little bit of a primer as to the feature that you're coming across here. Similar to the password upgrades that Spring Security users have come to know for end user accounts, this provides the same mechanisms for upgrading the security of the OAuth client credentials themselves. The framework uses the current encoding and strength, if applicable, to determine if the source secret that we have just confirmed is correct is in need of being upgraded. Upgraded in this context may mean changing the underlying encoding entirely or increasing the strength of the current algorithm. The way that this is triggered is by the current configured implementation of PasswordEncoder in use for your application.
Based upon what you have presented here so far, this leads me to know that the presently available PasswordEncoder in your app is the BcryptPasswordEncoder implementation. As such, the provider is interpreting that you want to upgrade the secret by changing the encoding type from noop to bcrypt with strength 10.
If you don't want for this to happen, in what I hope is your demo/testing app, then you just need to configure your application with the NoOpPasswordEncoder implementation. The NoOpPasswordEncoder implementation is for testing purposes as stated by the documentation here as it provides no secure storage of the credentials when it is at rest in the database. When this encoder encounters your secret, it will perform no actions as the encoding of the stored secret matches the current configured encoding type.

Thank you @shanman190 .
I added the {noop} password encoder and it works as expected.
But I feel that this update behavior should not be the default. Because it makes our key a secret. We will have to find its original value from the sql backup. Wouldn't it be better if it could be turned on with a configuration?

Anyway, it does come in handy for users who need to upgrade their security. However, it happened too suddenly. 😄

Would you mind expressing how this feature in particular is causing you an issue?
From an authentication standpoint, the same secret will still be used to authenticate and would result in a successful authentication.

@shanman190 Sure.
We have some external customers, we generate client_id, client_secret and limit scope for them. Customers can log in to our system, and they can see the client secret we generated for them from the page. Of course, to view it, they need to verify the email verification code.
Currently, the client secret stored in the database becomes a {bcrypt} secret when we upgrade the spring authorization server version. This prevents them from viewing the original client secret.

@shanman190
We also have a requirement, we hope that client secret password encoder and user's password encoder can be configured separately. Because the user's password requires {bcript}

So the password encoder can be configured separately for just for the OAuth piece presently via:
https://github.com/spring-projects/spring-authorization-server/blob/e5fcbe422be1a73240ac7d8b40f165651fb01ab8/oauth2-authorization-server/src/main/java/org/springframework/security/oauth2/server/authorization/config/annotation/web/configurers/OAuth2ClientAuthenticationConfigurer.java#L128
https://github.com/spring-projects/spring-authorization-server/blob/e5fcbe422be1a73240ac7d8b40f165651fb01ab8/oauth2-authorization-server/src/main/java/org/springframework/security/oauth2/server/authorization/config/annotation/web/configurers/OAuth2AuthorizationServerConfigurer.java#L157
Personally for the other part, the use case really sounds more like the OIDC Dynamic Client registration flow which provides back the client secret on the response itself. This enables secure storage without compromising on the feature of being able to show the user the secret one time.
https://docs.spring.io/spring-authorization-server/docs/current/reference/html/protocol-endpoints.html#oidc-client-registration-endpoint

Thank you @shanman190 . That's great.
And for the client secret, when we go to register a google api, they will also give us a page that can be used to view the secret. I think I need to store them somewhere else. Because we really didn't expect that this would be adjusted for automatic updates.


Import of lxml from local directory fails

  File "podcastAnalyzer.py", line 7, in <module>
    import lxml.etree
ImportError: dlopen(/Users/Josh/Google Drive/Academics/Projects/podcast-parakeet/lxml/etree.so, 2): no suitable image found.  Did find:
	/Users/Josh/Google Drive/Academics/Projects/podcast-parakeet/lxml/etree.so: unknown file type, first eight bytes: 0x7F 0x45 0x4C 0x46 0x02 0x01 0x01 0x00

Current work around is removing the lxml directory temporarily.

I'm willing to look into this issue.
For clarification, removing the lxml directory is a successful workaround for Josh because he already has it installed as a dependency.

Thank you. I'll look into using the xml module instead as I believe that is part of the standard library.

From my analysis, since the lxml module was compiled on my laptop, it is only compatible for my architecture. The compiled files won't function properly on your OSX or on most other computers. For example, on my other laptop, the error I'm receiving is:
Traceback (most recent call last):
  File "./podcastAnalyzer.py", line 7, in <module>
    from lxml import etree
ImportError: /home/jleung/Downloads/podcast-parakeet/lxml/etree.so: wrong ELF class: ELFCLASS64

Therefore, it seems like this prepackaging of the executables is not a good solution.
Some alternate options might be creating a setup.py or using a Docker image. @CtrlShiftGo, thoughts?

Thanks for investigating this issue.
A setup.py seems like the best solution for the time being as there are not many libraries that are required for this tool to function.

Since we're no longer distributing portions of the lxml library with the script this issue has been resolved.


spicy build error referring to pythran header: xsimd_scalar.hpp: error: '__exp10f' was not declared in this scope; did you mean 'exp10'?

Building scipy on 10.6 revealed an apparent problem with pythran headers: __exp10f is undefined.
In file included from /opt/local/Library/Frameworks/Python.framework/Versions/3.11/lib/python3.11/site-packages/pythran/xsimd/xsimd.hpp:55,
                 from /opt/local/Library/Frameworks/Python.framework/Versions/3.11/lib/python3.11/site-packages/pythran/pythonic/include/numpy/exp.hpp:8,
                 from scipy/interpolate/_rbfinterp_pythran.cpp:26:
/opt/local/Library/Frameworks/Python.framework/Versions/3.11/lib/python3.11/site-packages/pythran/xsimd/arch/xsimd_scalar.hpp: In function 'float xsimd::exp10(const float&)':
/opt/local/Library/Frameworks/Python.framework/Versions/3.11/lib/python3.11/site-packages/pythran/xsimd/arch/xsimd_scalar.hpp:474:16: error: '__exp10f' was not declared in this scope; did you mean 'exp10'?
  474 |         return __exp10f(x);
      |                ^~~~~~~~
      |                exp10
/opt/local/Library/Frameworks/Python.framework/Versions/3.11/lib/python3.11/site-packages/pythran/xsimd/arch/xsimd_scalar.hpp: In function 'double xsimd::exp10(const double&)':
/opt/local/Library/Frameworks/Python.framework/Versions/3.11/lib/python3.11/site-packages/pythran/xsimd/arch/xsimd_scalar.hpp:478:16: error: '__exp10' was not declared in this scope; did you mean 'exp10'?
  478 |         return __exp10(x);
      |                ^~~~~~~
      |                exp10
error: Command "/opt/local/bin/g++-mp-13 -fno-common -dynamic -DNDEBUG -g -fwrapv -O3 -Wall -pipe -Os -isysroot/ -isystem/opt/local/include/LegacySupport -I/opt/local/libexec/boost/1.81/include -I/opt/local/include -DENABLE_PYTHON_MODULE -D__PYTHRAN__=3 -DPYTHRAN_BLAS_NONE -I/opt/local/Library/Frameworks/Python.framework/Versions/3.11/lib/python3.11/site-packages/pythran -I/opt/local/Library/Frameworks/Python.framework/Versions/3.11/lib/python3.11/site-packages/numpy/core/include -I/opt/local/Library/Frameworks/Python.framework/Versions/3.11/lib/python3.11/site-packages/numpy/core/include -Ibuild/src.macosx-10.6-ppc-3.11/numpy/distutils/include -I/opt/local/Library/Frameworks/Python.framework/Versions/3.11/include/python3.11 -c scipy/interpolate/_rbfinterp_pythran.cpp -o build/temp.macosx-10.6-ppc-3.11/scipy/interpolate/_rbfinterp_pythran.o -MMD -MF build/temp.macosx-10.6-ppc-3.11/scipy/interpolate/_rbfinterp_pythran.o.d -std=c++11 -fno-math-errno -Wno-unused-function -D_GLIBCXX_USE_CXX11_ABI=0 -isysroot/" failed with exit status 1

Possible fix will be to define it, when it is not available, like: https://trac.macports.org/attachment/ticket/15527/qtpfsgui-1.9.2-exp10f.patch
Alternatively, GCC has it as a builtin: https://gcc.gnu.org/onlinedocs/gcc-13.2.0/gcc/Other-Builtins.html

Apparently there are no exp10 and exp10f until 10.9: https://lists.llvm.org/pipermail/llvm-commits/Week-of-Mon-20131216/199358.html
They also may be missing on some non-Apple systems.

Apparently this works:
#if defined(__APPLE__)
#ifndef exp10f
#define exp10f( x ) exp( x * log (10))
#endif
#endif

Is it appropriate?


invitations: Invited at column shows UTC instead of local time.

The middle column here is showing the time in UTC rather than the local time:

The fix is two fold:

The backend should return a timestamp (see datetime_to_timestamp function in timestamp.py)
The frontend (settings_invites.js) should put that into an appropraite function from timerender.js.

This should be applied to both do_get_user_invites and do_resend_user_invite_email in actions.py.

@zulipbot claim

@zulipbot claim

How to get to the screen shown in screenshot above?

@sarvesh211999 it is the invitation tab in the settings for an admin.

@sarvesh211999 I already claimed it 4 days back!!!

So how I am gonna test in local side.??
On Sat, Dec 9, 2017 at 1:44 AM, Mohd Ali Rizwi<EMAIL_ADDRESS>wrote:

@sarvesh211999 https://github.com/sarvesh211999 it is the invitation
tab in the settings for an admin.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/zulip/zulip/issues/7664#issuecomment-350361151, or mute
the thread
https://github.com/notifications/unsubscribe-auth/Adia8Cbr578v5w-Kbn1IQ4Qoj9VtWrjVks5s-ZiXgaJpZM4Q1xag
.

@sarvesh211999 it seems @skapil is working on this issue, you can work on some other good first issue

@rishig should we close this ticket as it's been merged!!

Thanks for the heads up!
@skapil for future, you can add "Fixes #XXXX" to the commit that fixes the issue, and it will automatically close the issue :).


Timeout generic callbacks used in destructors and inflight request cancelation

Destructors may be called from Python's garbage collector, disallowing us to disable the GIL for that operation. When that occurs, there might be a deadlock as other threads have the GIL, such as the progress thread when a Python's listener callback is invoked and executed in that thread.

I wonder if it is also a good idea to explicitly release the gil when dropping the C++ shared_ptr attributes of UCXX python cdef classes. I think something like:
diff --git a/python/ucxx/_lib/libucxx.pyx b/python/ucxx/_lib/libucxx.pyx
index 3e26bfb..ef8b4be 100644
--- a/python/ucxx/_lib/libucxx.pyx
+++ b/python/ucxx/_lib/libucxx.pyx
@@ -862,6 +862,10 @@ cdef class UCXEndpoint():
         bint _enable_python_future
         dict _close_cb_data

+    def __dealloc__(self):
+        with nogil:
+            self._endpoint = <shared_ptr[Endpoint]>nullptr;
+
     def __init__(
             self,
             uintptr_t shared_ptr_endpoint,

(For example) Makes sure that (if this is the last reference to the Endpoint) ~Endpoint runs with the GIL released.
WDYT?
I think this change is worthwhile anyway so I can propose in a separate PR.

I wonder if it is also a good idea to explicitly release the gil when dropping the C++ shared_ptr attributes of UCXX python cdef classes. I think something like:
diff --git a/python/ucxx/_lib/libucxx.pyx b/python/ucxx/_lib/libucxx.pyx
index 3e26bfb..ef8b4be 100644
--- a/python/ucxx/_lib/libucxx.pyx
+++ b/python/ucxx/_lib/libucxx.pyx
@@ -862,6 +862,10 @@ cdef class UCXEndpoint():
         bint _enable_python_future
         dict _close_cb_data

+    def __dealloc__(self):
+        with nogil:
+            self._endpoint = <shared_ptr[Endpoint]>nullptr;
+
     def __init__(
             self,
             uintptr_t shared_ptr_endpoint,

(For example) Makes sure that (if this is the last reference to the Endpoint) ~Endpoint runs with the GIL released.
WDYT?
I think this change is worthwhile anyway so I can propose in a separate PR.

Sorry, I missed this reply earlier. I think this is a great idea, it might actually do what we were attempting of releasing the GIL at destruction time, and __dealloc__  didn't occur to me before so thanks for thinking of that! I agree a separate PR is probably good, if you want to do it please feel free to submit it, otherwise I can work on it next week as well. :slightly_smiling_face:

I agree a separate PR is probably good, if you want to do it please feel free to submit it, otherwise I can work on it next week as well.

https://github.com/rapidsai/ucxx/pull/132

/merge

Thanks for the review @wence- !


manim reders "broken" images

As I installed manim through Windows (Direct) section in the documentation and ran manimgl example_scenes.py OpeningManimExample in the terminal, what manim rendered was a mess, as shown below:

Going through the Quick Start section gives a similar result:

I am on Windows 11 and Python 3.10.11.

Yes Bro Same Problem 😭

Just reinstalled windows. The problem consists.

Just reinstalled windows. The problem consists.

Just reinstalled windows. The problem consists.

Also these are not errors of windows, this is a mess in the ManimGL library

Just reinstalled windows. The problem consists.

Just reinstalled windows. The problem consists.

Also these are not errors of windows, this is a mess in the ManimGL library

Well, I thought TeX was working properly so it must have been the stuff that renders the images and I dont know :(

Just tried the cummunity edition, it works perfectly @mathsvisualization

The issue is likely caused by the update on August 19, 2024. The specific problematic commit ID is 24b160f. You can try using git reset --hard f9b9cf69fdea86f1d591613131ef7d0d18728300 to resolve this problem.

can you contact me on instagram?
@maths.visualization

https://github.com/3b1b/manim/issues/2165#issuecomment-2354800132

I've since made a change that (I believe) addresses this. Can you let me know whether the most recent commits to this repo contain the same issue on your machine?

I've since made a change that (I believe) addresses this. Can you let me know whether the most recent commits to this repo contain the same issue on your machine?

I seems that manimgl 1.6.1 requires manimpango <0.5.0, >=0.4.0; while manim 0.18.1 requires manimpango <1.0.0, >=0.5.0, so there's no way installing an appropriate version of manimpango.
The bunch of Chinese basically means manimgl cannot be recognized as a cmdlet, a function, a script or an executable file.
Thank you, Grant @3b1b

Do you have any idea why it's listed for <0.5.0? When I run it with later versions of ManimPango it seems fine.

Do you have any idea why it's listed for <0.5.0? When I run it with later versions of ManimPango it seems fine.

Thanks for providing this information. After upgrading to the latest manimpango(which pip reported as incompatible with manimgl), the previous render problem is gone. I suppose someone should update the requirements.txt or whatever.

Do you have any idea why it's listed for <0.5.0? When I run it with later versions of ManimPango it seems fine.

Thanks for providing this information. After upgrading to the latest manimpango(which pip reported as incompatible with manimgl), the previous render problem is gone. I suppose someone should update the requirements.txt or whatever.

Yes that fixed the problem. Thank you for your work @CoderXL1 @3b1b , manim now works perfectly on my device. Let me close this issue.


Improve the layout on a phone

On my iPhone, the site works, but I can only see the code window, I have to scroll down to see the output. So people might not realize there is an image output.

https://github.com/lfortran/lcompilers_frontend/blob/4bea658bb41da37c85ae635fee28512809114638/pages/index.js#L59-L67
It seems we might need a useEffect() to accomplish this. We previous had this useEffect as shown above.
Also, I came across this https://stackoverflow.com/questions/59494037/how-to-detect-the-device-on-react-ssr-app-with-next-js. It seems useful.

This is how it looks like on my iPhone now:

So I think the issue is fixed. Thanks a lot @Shaikh-Ubaid for fixing it!


Early exit on error in loadPayments

This fixes a red box on mobile (dev).
When adding the debug logging, it should have been done only on
no error.

cc @buoyad who added this debug logging

Forgot to mention how I ran into this: just trying to link an already linked account on mobile.

that empty account stuff should be fixed, so feel free to remove anything you added in frontend trying to help figure that out.

Okay, removed that logging code


Modify Background Video Playback to Pause on Last Frame

Description
The background video on the homepage is intended to welcome users when they first visit the site. Currently, the video loops after it finishes playing, which disrupts the user experience. We need to modify this functionality so that the video pauses on the last frame instead of looping.
Steps to Reproduce

Open the homepage of the application in a web browser.
Observe the background video playback when the page loads.
Notice that the video continues in a loop after it finishes playing.

Expected Behavior

The background video should play automatically when the homepage loads.
Once the video reaches the end, it should pause on the last frame instead of hiding.
Users should remain engaged with the final scene of the video, enhancing their welcoming experience.

https://github.com/user-attachments/assets/8cccbe6f-e9eb-4bf5-8f0e-ab4af1b8fa30

@IkkiOcean assigned


Drop python 3.5 support

@tohanss You need to edit tox.ini, it still lists py35 as a runtime environment.
Don't bother adding py38, we'll most likely switch all unit tests over to GitHub actions in the near future. At least the mac build, which is dreadfully slow on Travis.


setup.py doesn't find all packages

Hi, cool project, I'm looking forward to exploring it more.
I just found a problem with "setup.py" early on. It's only finding the teether folder, not sub folders (like teether/cfg). I fixed it by changing this in setup.py:
"packages=setuptools.find_packages(),"
previously it just had:
packages=['teether']
it's a quick fix, I could write up a PR if needed.

here was the exact issue:
Traceback (most recent call last):   File "bin/extract_contract_code.py", line 5, in <module>     from teether.cfg.cfg import CFG   File "/home/vmuser/checkout/teether/venv/lib/python3.6/site-packages/teether-0.1-py3.6.egg/teether/__init__.py", line 1, in <module> ImportError: cannot import name 'cfg'
After a using a new virtual environment and running python3 setup.py install

Thanks for reporting, fix should be in commit d7b7fd1


Support protocol deep linking on Linux

Support protocol deep linking on Linux by adding MimeType entry into Mattermost.desktop file. http://archive.is/8C3zb
We'll need to confirm whether electron-builder adds it for .deb packages as well.
Note: This PR added support for Windows and Mac: https://github.com/mattermost/desktop/pull/616

Well, the following worked for me:
diff --git a/resources/linux/create_desktop_file.sh b/resources/linux/create_desktop_file.sh
index 2c1cd3b..aa1159e 100755
--- a/resources/linux/create_desktop_file.sh
+++ b/resources/linux/create_desktop_file.sh
@@ -14,5 +14,6 @@ Terminal=false
 Type=Application
 Icon=${FULL_PATH}/icon.svg
 Categories=Network;InstantMessaging;
+MimeType=x-scheme-handler/mattermost;
 EOS
 chmod +x Mattermost.desktop
diff --git a/src/main.js b/src/main.js
index eca0ec9..6b1b57c 100644
--- a/src/main.js
+++ b/src/main.js
@@ -180,7 +180,7 @@ const trayImages = (() => {
 if (app.makeSingleInstance((commandLine/*, workingDirectory*/) => {
   // Protocol handler for win32
   // argv: An array of the second instance’s (command line / deep linked) arguments
-  if (process.platform === 'win32') {
+  if (process.platform === 'win32' || process.platform === 'linux') {
     // Keep only command line / deep linked arguments
     if (Array.isArray(commandLine.slice(1)) && commandLine.slice(1).length > 0) {
       setDeeplinkingUrl(commandLine.slice(1)[0]);
@@ -423,7 +423,7 @@ app.on('ready', () => {
   }

   // Protocol handler for win32
-  if (process.platform === 'win32') {
+  if (process.platform === 'win32' || process.platform === 'linux') {
     // Keep only command line / deep linked argument. Make sure it's not squirrel command
     const tmpArgs = process.argv.slice(1);
     if (

Jira ticket for tracking: https://mattermost.atlassian.net/browse/MM-14092.

Hey @dunkla,
Would you be open to providing a PR with this changes? Would appreciate this.

This works now :)
One note: Firefox won't always treat our deep links correctly if you put them in the address bar, but clicking on them works fine.


Use client's returned audio/video as stream source

Here's an idea: right now the audio returned from a client can be sent to a supported camera to implement 2-way audio. This is certainly a super cool feature, but playing audio on a camera is only useful in very specific applications (mostly doorbells).
It would be even cooler if both audio and video received from the client could be used as a source of a different stream. And be later consumed by other clients, transcoded, etc. Not sure how feasible this is, but it seems to be an elegant generic solution that could have lots of applications.
For instance, one could implement a "video-call"-like system between two users, Alice using her phone and Bob sitting on his living-room. Alice receives video/audio from the living-room camera, and her own video/audio is cast to Bob's living-room TV.
It could even be useful for 2-way audio when further transcoding/processing is required (eg #26).
Just an idea to consider...
PS. Thanks a lot for this awesome project!

mmm is very good idea!!!

Well, you can create "Incoming source" and watch it like any other camera
https://github.com/AlexxIT/go2rtc#incoming-sources
Incoming source can be just browser page.

Theoretically "Stream to camera" should support any source, not only ffmpeg. But I have not test it.
https://github.com/AlexxIT/go2rtc#stream-to-camera

Thanks for the response, this is interesting. So I guess one could create a web client that displays camera A and sends back its own recorded video/audio to go2rtc as an "incoming" camera B (to watch it elsewhere). Maybe the included webrtc.html client could be modified to achieve this.


LoginActivity window has been leaked

02-04 01:26:14.564 2471-2471/com.zulip.android.dev E/WindowManager: android.view.WindowLeaked: Activity com.zulip.android.activities.LoginActivity has leaked window com.android.internal.policy.PhoneWindow$DecorView{706e3e6 V.E...... R......D 0,0-729,232} that was originally added here
                                                                        at android.view.ViewRootImpl.<init>(ViewRootImpl.java:368)
                                                                        at android.view.WindowManagerGlobal.addView(WindowManagerGlobal.java:299)
                                                                        at android.view.WindowManagerImpl.addView(WindowManagerImpl.java:85)
                                                                        at android.app.Dialog.show(Dialog.java:319)
                                                                        at com.zulip.android.activities.LoginActivity.onClick(LoginActivity.java:541)
                                                                        at java.lang.reflect.Method.invoke(Native Method)
                                                                        at android.support.v7.app.AppCompatViewInflater$DeclaredOnClickListener.onClick(AppCompatViewInflater.java:288)
                                                                        at android.view.View.performClick(View.java:5198)
                                                                        at android.view.View$PerformClick.run(View.java:21147)
                                                                        at android.os.Handler.handleCallback(Handler.java:739)
                                                                        at android.os.Handler.dispatchMessage(Handler.java:95)
                                                                        at android.os.Looper.loop(Looper.java:148)
                                                                        at android.app.ActivityThread.main(ActivityThread.java:5417)
                                                                        at java.lang.reflect.Method.invoke(Native Method)
                                                                        at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:726)
                                                                        at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:616)

On the branch https://github.com/sam1301/zulip-android/tree/use-server-ids

@kunall17 Can I work on this issue?

@harshitagupta30 sure go ahead 👍

@kunall17 The leak in the LoginActivity is due to not closing the dialog box when we've exited the activity. The issue is in Sam1301's local branch and I couldn't reproduce it in master branch. But to avoid this issue we can call dailogbox.dismiss() method on Activity's onDestroy method.
So can I make changes on master branch?

The issue is in Sam1301's local branch

There was no change in the LoginActivity nor in ZulipActivity, so it is not possible that this problem persist in her branch only!
And i remember i got this in some other branch as well, send a PR for this I'll debug!

@kunall17 can this be closed? @harshitagupta30 thanks for submitting pr #391 that addresses this issue. I saw that you included "Issue#365" in the commit message. The way we prefer to add issue number in the commit messages is by including "Fixes #365" as the last line of commit messages(I guess you missed the space after "Issue"). That way issue is auto-closed once that commit gets merged. See the commit message guideline for more details on this.
Thanks!


Optimization bailouts on Angular 10

Hi everyone!
I have this message: module depends on '@ctrl/ngx-codemirror'. CommonJS or AMD dependencies can cause optimization bailouts.
Angular version: 10.0.8
Can you help me?
Thanks

codemirror itself isn't tree shakeable


Duplicate variants and molecular profiles

This PR was created to prevent duplicate names on variants and molecular profiles. However, we're still seeing duplicates. Here are the duplicate variants (only looked at accepted or submitted) we are seeing:
{
  "ERBB2 A775_G776insYVMA": [2658, 4483],
  "ERBB2 L755P": [1304, 4490],
  "BRAF V600D": [11, 3452],
  "BRAF V600R": [16, 991]
}

Thanks for the report! There is some additional context in #864 but we had to temporarily remove that validation. I've now reworked it and added it back.
That being said, looking at the timestamps it would appear that most of these were created prior to that validation existing anyways. The additional validation will not do anything to resolve these automatically, a curator or editor will need to go in and propose edits to the EIDs to move them so that the Variants can be deprecated.
I see you've flagged some of these, and I will bring these up in the slack channel to try and draw some curator attention to them as well.