Doesn't work on macOS

Describe the bug
A clear and concise description of what the bug is.

  You can now view your Streamlit app in your browser.

  Local URL: http://localhost:8502
  Network URL: http://<IP_ADDRESS>:8502

  For better performance, install the Watchdog module:

  $ xcode-select --install
  $ pip install watchdog

2024-05-21 17:20:42.020 Uncaught app exception
Traceback (most recent call last):
  File "/Users/rogaha/development/nextron/ai-agents/auto-gen/lib/python3.11/site-packages/streamlit/runtime/scriptrunner/script_runner.py", line 600, in _run_script
    exec(code, module.__dict__)
  File "/Users/rogaha/development/nextron/ai-agents/auto-gen/lib/python3.11/site-packages/pyrobbot/app/app.py", line 17, in <module>
    run_app()
  File "/Users/rogaha/development/nextron/ai-agents/auto-gen/lib/python3.11/site-packages/pyrobbot/app/app.py", line 13, in run_app
    ).render()
      ^^^^^^^^
  File "/Users/rogaha/development/nextron/ai-agents/auto-gen/lib/python3.11/site-packages/pyrobbot/app/multipage.py", line 708, in render
    return super().render(**kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/rogaha/development/nextron/ai-agents/auto-gen/lib/python3.11/site-packages/pyrobbot/app/multipage.py", line 465, in render
    self.handle_ui_page_selection(**kwargs)
  File "/Users/rogaha/development/nextron/ai-agents/auto-gen/lib/python3.11/site-packages/pyrobbot/app/multipage.py", line 602, in handle_ui_page_selection
    new_configs = self.selected_page.chat_obj.configs.model_validate(
                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/rogaha/development/nextron/ai-agents/auto-gen/lib/python3.11/site-packages/pydantic/main.py", line 551, in model_validate
    return cls.__pydantic_validator__.validate_python(
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
pydantic_core._pydantic_core.ValidationError: 1 validation error for VoiceChatConfigs
ai_instructions
  Input should be a valid tuple [type=tuple_type, input_value="('You answer correctly.'...citly asked to do so.')", input_type=str]
    For further information visit https://errors.pydantic.dev/2.7/v/tuple_type

To Reproduce
Steps to reproduce the behavior:

pip uninstall git+https://github.com/paulovcmedeiros/pyRobBot.git
run: rob

Expected behavior
Open the streamlit application locally.
Screenshots
If applicable, add screenshots to help explain your problem.
Desktop (please complete the following information):

OS: [e.g. iOS]
Browser [e.g. chrome, safari]
Version [e.g. 22]

Smartphone (please complete the following information):

Device: [e.g. iPhone6]
OS: [e.g. iOS8.1]
Browser [e.g. stock browser, safari]
Version [e.g. 22]

Additional context
Add any other context about the problem here.

Same on windows 11


none codec stream calls recursive infinite loop

I tried decoding the following movie:
$ ffmpeg -i test.mov
*** snip ***
Duration: 00:26:21.54, start: 0.000000, bitrate: 7754 kb/s
    Stream #0:0(eng): Video: h264 (Main) (avc1 / 0x31637661), yuv420p(tv, bt709), 864x486, 5524 kb/s, 23.98 fps, 23.98 tbr, 23976 tbn, 47952 tbc (default)
    Metadata:
      creation_time   : 2017-03-15T06:06:10.000000Z
      handler_name    : Apple Alias Data Handler
      encoder         : H.264
    Stream #0:1(eng): Data: none (tmcd / 0x64636D74) (default)
    Metadata:
      creation_time   : 2017-03-15T06:06:10.000000Z
      handler_name    : Apple Alias Data Handler
      timecode        : 00:59:40:00
    Stream #0:2(eng): Audio: pcm_s24be (in24 / 0x34326E69), 48000 Hz, stereo, s32 (24 bit), 2304 kb/s (default)
    Metadata:
      creation_time   : 2017-03-15T06:06:15.000000Z
      handler_name    : Apple Alias Data Handler

In this case, the following code gets segmentation fault.
In [1]: import av

In [2]: container = av.open("test.mov")

In [3]: container.streams[0]
Out[3]: <av.VideoStream #0 h264, yuv420p 864x486 at 0x7fc588459828>

In [4]: container.streams[2]
Out[4]: <av.AudioStream #2 pcm_s24be at 48000Hz, stereo, s32 at 0x7fc588459ba8>

In [5]: container.streams[1]
Out[5]: Segmentation fault (core dumped)

At __getattr__ function in Stream class (av/stream.pyx), codec is not set, so it becomes a recursive infinite loop.
    def __getattr__(self, name):
        try:
            return getattr(self.codec_context, name)
        except AttributeError:
            try:
                return getattr(self.codec, name) # <----  this line calls self.__getattr__("codec") many times
            except AttributeError:
                raise AttributeError(name)

Hi, My Merge Request #240 correct this issue!

Hi,
I tried your code and fixed a little bit. Please merge my pull request.
https://github.com/mgoacolou/PyAV/pull/1
It will fix this problem. Thank you very much!

#240 fixed this problem, so I close this issue.


Could I use a normal ISO instead of netboot mini.iso to speed up installation?

How to speed up the installation process?
Could I use a normal ISO instead of netboot mini.iso to speed up installation?
Thanks.

Yes

Yes

Could you show an example?
Which ISO can I use to speed up the process?
Thank you.

@orange888 Have a look at https://github.com/core-process/linux-unattended-installation/issues/3. Does it help?


Stadium (match day DLC) event not working when parking AI is enabled

I have this issue where people don't go to stadium event when parking AI is enabled.
When the parking AI option is disabled, the event is working properly and hundreds of people go there.
I've made a test with varsity sports stadiums and oddly they are working right with parking AI, so it must be something related to the match day stadium specifically.
It would be nice if someone can test it in his own game before i include savegames\logs etc
just to be sure it's only me and not an universal issue.

I can say that in my current city, the match day stadium from the DLC works just fine with parking AI enabled in the Alpha version.

Maybe it is a mod conflict.
Could you both drag and drop your output_log.txt (or, if using TMPE v11 ALPHA, the TMPE.log) on to a comment to upload here and I'll see if I can spot any mods that might need investigation?

As Requested,
TMPE.log

Hello!
I've made some tests without other mods to avoid conflicts (only TMPE installed) and the problem is still there, however, i've noticed that if i put the stadium on walkable distance, the event works and all cims go there on foot.
If i put the stadium in a distance only reachable by car, nobody goes there (in vanilla they do by car).
So it must be something cars and\or their pathfinding related.

Sounds like it might be that visiting an event by car includes an attempt to park, and there is a bug in the parking feature when it is disabled. Send a bus there, while waiting for a resolution.


correct method for adding users to groups?

I'd like to add users to groups in my IoC, specifically user@domain to gcp-data-engineers
where in the fast foundation fabric stages should I do this?
I've had a hunt about the docs and code and am probably missing it, if you could point me in the right direction that would be awesome!

In our AWS platform we manage our users/groups in our IaC
here I was just thinking of managing the binding of users to groups, not the creation of them
Just checking it wasn't something you'd already done that I was missing :)
I'll implement in my stages
Ta

The group resource in the provider is fragile, @juliocc and @sruffilli have more context, but we typically don't like using it. And customers use sync anyway...


ARK server update stopping after one try

Having this problem consistently with either update or force-update -- any ideas? I can run it again and again but it just downloads a little bit more each time:
steamuser@steamvm:/storage$ ./arkserver force-update
[  OK  ] Update ark-server: Updating arkserver
Redirecting stderr to '/home/steamuser/Steam/logs/stderr.txt'
[  0%] Checking for available updates...
[----] Verifying installation...
Steam Console Client (c) Valve Corporation
-- type 'quit' to exit --
Loading Steam API...OK.

Connecting anonymously to Steam Public...Logged in OK
Waiting for license info...OK
 Update state (0x3) reconfiguring, progress: 0.00 (0 / 0)
 Update state (0x61) downloading, progress: 0.27 (79322774 /<PHONE_NUMBER>7)
Error! App '376030' state is 0x402 after update job.
CWorkThreadPool::~CWorkThreadPool: work complete queue not empty, 8 items discarded.
CWorkThreadPool::~CWorkThreadPool: work processing queue not empty: 386 items discarded.
steamuser@steamvm:/storage

This is a big with steamCMD I reccomend a Google around for this one to see it you find anything. Validation may possibly resolve this though. Let me know if you find anything :-)

Nope -- been googling about it for months now. :P  Nobody seems to have anything but questions.  I have my own script that validates as well -- doesn't fix the problem.  I eventually had to make script that just re-runs the same command over and over again if the previous one fails, just to get it to work, however, this constant stop/restart method means an update takes HOURS, sometimes days, instead of 30min or so for people who don't have this problem:
$updateArkCmd

while [ $? -ne 0 ]
do
	$updateArkCmd
done

Could be an issue with your server maybe the dependencies required for steamcmd are damaged. It's worth trying on a fresh install

I could do with finding out a list of error codes for SteamCMD e.g  0x402 This may help figure out the issues such as this. Then I could write error handling in a bit better

I've been googleing this. The vast majority of people getting this error just need to restart the process until it works. Could be due to some packet loss. You'd better re-run a "validate" after such a painful download though.
Closing this, feel free to re-open if needed.
Have a nice admin time !


nil assertion: yield in ecr template embedded in def macro

Crystal fails to compile the following example with a Nil assertion failed exception. It compiles if render is a def, but fails once it's a def macro:
# render.cr
require "ecr/macros"

macro def render(&block) : String
  String.build { |%str| embed_ecr "template.ecr", "%str" }
end

render { "contents" }

# template.ecr
<%= yield %>

Nil assertion failed
*raise<String>:NoReturn +70 [0]
*Nil#not_nil!<Nil>:NoReturn +13 [0]
*Crystal::ASTNode+@Crystal::ASTNode#accept<Crystal::ASTNode+, Crystal::TypeVisitor>:Nil +115108 [0]

Reduced:
macro def foo : String
  yield
end

foo do
end

It seems macro def doesn't work with blocks.
Does it work if you make it a regular method? Blocks are always inlined so each call to a method with a block results in a new instantiation. That should work for now unless you need to defer the block's contents until the semantic phase is finished.

Yes it works, but I would like to generate a render_layout method per class, so children of Artanis::Application can each have their own layout, just like they have their own call method.
I'm troubled with your "each call to a method with a block results in a new instantiation". What do you mean? That each call from different places will generate a new method? I guess that would be pretty bad, yes. All I need the block for it to be able to yield in the layout template.
I realize that Ruby spoiled me a lot with ERB templates (load/parse/cache/render at runtime), and I think the design translates poorly for Crystal/ECR templates (at compile time) — thought that design would work for mustache/liquid templates. I may just stick to list the ECR templates and generate a method for each. Maybe it would fit better with Crystal.

This is now fixed in master, though you'll have to define render like this:
macro def render(&block) : String
  {% begin %}
    String.build { |%str| embed_ecr "template.ecr", "%str" }
  {% end %}
end

(and the String return type there is not needed, but can be left)


installation issue

INFO - building SkillEntry objects for all skills
INFO - Downloading skill: https://github.com/tomascardososerra/fallback-chatgpt3-skill
INFO - Reading from manifest.yml
WARNING - Invalid value type manifest.yml for fallback-chatgpt3-skill: <class 'list'>
INFO - Problem performing action. Restoring skill to previous state...
INFO - invalidating skills cache
SkillRequirementsException: 'list' object has no attribute 'get'

removed manifest file. It wasn't needed anyway. Thanks!


Initial pull request

Hi,
I'm just getting started with github and I'd like to make this small pull request to get my feet wet. I've been using your py-earth package at work and I find it very useful. Over time I'd like to contribute more to this project.
The only changes are to cleanup .gitignore, which had a bunch of duplicate line entries, and to use the dict get() method to provide a default value for missing keys.
Question: how do I run the unit tests?
Thanks,
-Arnaldo

Much appreciated, and welcome!  I just merged your changes.  I usually run unit tests by:
>nosetests -s -v .

from within the repository.  There is currently one unit test that is broken in master, but it is nothing to worry about.
If you're looking to contribute more and there's any way I can facilitate, do let me know.
-Jason


Cache feed.clj and all-jars.clj

The data feeds from clojars are only updated hourly, so it is of no benefit to request them for every incoming request. Clojars also now provides a gzipped version of all-jars.clj, which is 350KB vs 3.9MB for the uncompressed version.
I'd be happy to provide a PR to cache these (and request the compressed version of all-jars) if you like.

@tobias thanks for the info, a PR would be wonderful!

Fixed in #14 and shipped!


mpi4py required to run model's probabilities method

If you do not have mpi4py installed, the following will fail:
import pygsti
from pygsti.modelpacks import smq1Q_XYI
target_model = smq1Q_XYI.target_model()
target_model.probabilities(())
The traceback yields ModuleNotFoundError: No module named 'mpi4py' from line 254 in pyGSTi/pygsti/objects/distlayout.py.  The quick solution is to comment out line 254, but this disables mpi4py support for those who are using it.  A better solution would be to gracefully skip the import statement if mpi4py is not available, though there may be a solution superior to that as well.

Version 0.9.10 contains the fix for this issue.


Two vSphere on one site

I have two vSphere on one site, after run script i saw next message:
ERROR: Problem while config file parsing: While reading from '/opt/scripts/netbox-sync/settings.ini' [line 231]: section 'source/DC-SRG' already exists
May i can use script with two vSphere on one  site?

Hi, you have to simply give it a different name as it is a different vCenter.
[source/DC-SRG2] for example

Hi!
I thought about it, but the script will create a new site (DC-SRG2).
Second vSphere has the same site as the first and the servers are located there too

Hi,
you need to use and set this option:
https://github.com/bb-Ricardo/netbox-sync/blob/1337df6139129685c0a0a5c3ffad3defbfd26ddd/settings-example.ini#L145-L153

Hi It's great )) Thanks


[BEAM-1443] Preserve window duplication on window assignment.

Be sure to do all of the following to help us incorporate your contribution
quickly and easily:

[ ] Make sure the PR title is formatted like:
[BEAM-<Jira issue #>] Description of pull request
[ ] Make sure tests pass via mvn clean verify. (Even better, enable
Travis-CI on your fork and ensure the whole test matrix passes).
[ ] Replace <Jira issue #> in the title with the actual Jira issue
number, if there is one.
[ ] If this contribution is large, please file an Apache
Individual Contributor License Agreement.

R: @charlesccychen

Thanks!

Thanks, LGTM.

Thanks. This exposed the bug fixed at https://github.com/apache/beam/pull/1965 , so I'll wait for that before merging.

retest this please

Changes Unknown when pulling 01a6f9d49f12a17562b42f449d30fe4c57783603 on robertwb:window-explode into ** on apache:master**.


device.wvd

What is this file? where do i get it?

It's used to decrypt Spotify DRM, you can get this file using this guide: https://cdm-project.com/How-To/Dumping-L3-from-Android


Fix msaa sync

Description
This PR fixes synchronization errors produced by validation layers in 'msaa' sample.
This sample has few buttons/checkboxes so there are few combinations of states which application can produce.
With this fixes all combinations work (don't produce validation errors).
Notes:
Tested on:
VulkanSDK: <IP_ADDRESS>
Driver Version: 5<IP_ADDRESS>
Windows 10
Nvidia Quadro P600
Intel i7-8750H
32 GB RAM
General Checklist:
Please ensure the following points are checked:

[x] My code follows the coding style
[x] I have reviewed file licenses
[x] I have updated the header Copyright to reflect the current year (CI build will fail if Copyright is out of date)
[x] I have commented any added functions (in line with Doxygen)
[x] I have commented any code that could be hard to understand
[x] My changes do not add any new compiler warnings
[x] My changes do not add any new validation layer errors or warnings
[x] I have used existing framework/helper functions where possible
[ ] My changes build on Windows, Linux, macOS and Android. Otherwise I have documented any exceptions
[x] My changes do not add any regressions
[ ] I have tested every sample to ensure everything runs correctly
[x] This PR describes the scope and expected impact of the changes I am making

Sample Checklist
If your PR contains a new or modified sample, these further checks must be carried out in addition to the General Checklist:

[x] I have tested the sample on at least one compliant Vulkan implementation
[x] If the sample is vendor-specific, I have tagged it appropriately
[x] I have stated on what implementation the sample has been tested so that others can test on different implementations and platforms
[x] Any dependent assets have been merged and published in downstream modules
[x] For new samples, I have added a paragraph with a summary to the appropriate chapter in the samples readme

Hi @Michal-Masiukiewicz-Mobica, looks like the copyright header is stale.  Can you update to 2023?  Thx

Hi @marty-johnson59
It seems like this CI check is related to some other change as CI complains about files which I have not modified:
Run python3 /usr/local/bin/check_copyright_headers.py $TARGET_BRANCH Outdated copyright: app/CMakeLists.txt 	 Copyright (c) 2019-2022 app/apps/CMakeLists.txt 	 Copyright (c) 2020-2022
Do you know which other commit could modify this files?

My other review has the same errors:
https://github.com/KhronosGroup/Vulkan-Samples/pull/635

Rebased PR so it would take into account recent changes in repo. This should fix CI.


[AutoPR hybriddatamanager/resource-manager] chore: jsonfmt hybriddatamanager

Created to sync https://github.com/Azure/azure-rest-api-specs/pull/6083

This PR has been merged into https://github.com/Azure/azure-sdk-for-python/pull/5937


Lighthouse no 'theme-color' meta tag

name: Lighthouse no 'theme-color' meta tag
about: seo.js file

Bug report

What is the current behavior?
When you run lighthouse it says that there is no 'theme-color' meta tag but if you view the seo.js file there is a meta section with theme included in it

If the current behavior is a bug, please provide the steps to reproduce.

What is the expected behavior?
meta theme-color ie

Other relevant information:

Node.js version:
NPM/Yarn version
Operating System:
Additional tools:

We have PR #193 which will fix this issue.

ok thanks! sorry late reply alot going on


find day on given date

Calculator Functions
I want to create a calculator which will find day on a given date
for example := if  I want to find day on 5 may 1999
then it will result Wednesday.
Contribution Event
GSSOC22
Code of Conduct

[X] I follow Contributing Guidelines & Code of conduct of this project.

/assign

/assign

Duplicate issue. #149


Electron v12, context isolation

https://www.electronjs.org/docs/tutorial/context-isolation
https://www.electronjs.org/docs/api/context-bridge
window.xxx operations in the preload script will need to be replaced with contextBridge. Probably a complex development task as window (document global) is used extensively in the preload script to implement the desired functionality in EPUB (X)HTML content documents (i.e. TTS, media overlays, ReadiumCSS, annotations / highlights, click events, hyperlinking interception, clipboard management (DRM), etc.)

Filed in Thorium too: https://github.com/edrlab/thorium-reader/issues/1343

Filed in Thorium too: https://github.com/edrlab/thorium-reader/issues/1343

We are now on Electron v14, and we explicitly set contextIsolation to false in the webPreferences of all the BrowserWindow and webview objects that Thorium and navigator create. Consequently, we do not have to use the contextBridge API. I am therefore closing this issue.


Not able to go back to the first page after opening many pages

This is a (multiple allowed):

[x] bug

[ ] enhancement

[ ] feature-discussion (RFC)

Framework7 Version: Framework7 1.4.0

Platform and Target: Cordova

What you did
I created multiple pages, let's say 3 for now.
index.html (page1) -> results.html (page2) -> user.html(page3)
Expected Behavior
Page 2 should go back to page 1
Actual Behavior
I'm able to go to all of the pages, go back from page 3 to page 2, and then when I hit the back button from the navbar of page 2 it doesn't go back to page 1.
I tried to use Router API, but whenever I access page 3 and go back to page 2, going back to page 1 is not possible.
P.S if I don't open page 3, page 2 can go back to page 1

Could you share a Gist demonstrating the problem?

Does the problem occur with the latest F7? (you said your using 1.4)

I've created a Gist containing the html files for the 3 pages.

The Javascript files, contains Ajax requests to show data on the results page.
To move to the user page and send more data, I'm using href="user.html?firstname=name&..."
and then get the data by url_query in user.html.
I didn't use any router API to navigate within these pages, so it has the original settings for navigating back in pages.
Regarding the latest version, I used Phonegap to download the template automatically I thought it was the latest one.
I also attached a video showing you the actual behavior:

And I tried to update to the latest F7 just now, and still no luck.
(I copied the JS files from the dist folder after downloading the latest version and replaced the old ones I had) is this the right way to use the latest version?

should work but i would recommend copying the css as well

Copying the CSS will result in losing the previous styling I made.
Isn't there anything else I need to do?

I also tried it, but still not working.

I've the same problem but it's not very often.
Don't know when and why

It's in the boilerplate too if you enable push state.

Closing this issue as there was no support yet, and seems like I'm gonna have to search for an alternative way to make that back button works.
Thanks anyways.

You have wrong HTML layout, all modals (popup, etc.) should be direct children of body of app root element

Whoa give us a chance, saying you've had no support is wrong as I responded requesting more information almost immediately
Please remember that other than @nolimits4web when he's given donations are completely unpaid for the time we spend maintaining Framework7 and as such can't always give in-depth responses as quick as you might like

I didn't mean it this way, and I truly appreciate what you're doing guys, and I'm not even allowed to judge!
My point is that I have to figure out a solution asap, and I don't have the right to bother you and ask you for it, so I decided to look around hopefully I might be able to fix it.
And regarding @nolimits4web 's message, can you explain it please? I'm new here, I haven't build mobile apps before, this is my first time using F7, and I adore how it makes it easier for us to make a stunning mobile app.
The popup, and the login screen are in the index file, right after the closing tag of the page-content, where shall I put them?
And how is that affecting the back navigation after going to the third page?
Sorry again.

Pop up and login screen are inside of "pages" div as I see in you file, they should be inside of body

Thank you so much! It's not an issue at all, it was my bad!
Sorry again and thank you so so much!!!!!!!!!!!
It's working perfectly!

And why is the bug in the kitchen sink too?
I can't be the layout

@J05HI i can't see such bug in kitchen sink. How to replicate it?

@nolimits4web
Only with push state and navigation with browser back button.

I can make a video


[feat] -n and -p Flags revisit

Summary

We are removing -n flag (Project Name) since it has become deprecated
We are making -p flag (Project Path) optional, and defining default value as "."

Need to fix tests!


What's the best way for a total n00b to start with this library?

I'm having trouble getting a HelloDatastore project working.
Here's what I did:
$ git clone https://github.com/GoogleCloudPlatform/gcloud-java.git
$ cd gcloud-java
$ sudo apt-get install maven
$ mvn install
$ export CLASSPATH=~/gcdjavasample/gcloud-java/target/gcloud-java-0.0.3.jar

Here's the file I'm trying to run (HelloDatastore.java):
import com.google.gcloud.datastore.DatastoreService;
import com.google.gcloud.datastore.DatastoreServiceFactory;
import com.google.gcloud.datastore.DatastoreServiceOptions;
import com.google.gcloud.datastore.Entity;
import com.google.gcloud.datastore.Key;
import com.google.gcloud.datastore.KeyFactory;

public class HelloDatastore {
  private static final String DATASET = "gcloud-datastore-demo";

  public static void main(String[] args) {
    DatastoreServiceOptions options = DatastoreServiceOptions.builder().dataset(DATASET).build();
    DatastoreService datastore = DatastoreServiceFactory.getDefault(options);
    KeyFactory keyFactory = datastore.newKeyFactory().kind("Person");
    Key key = keyFactory.newKey("Jimmy");

    System.out.println("Trying to get the entity by its key!");

    Entity entity = datastore.get(key);

    if (entity == null) {
      System.out.println("Entity not found! Creating it!");
      entity = Entity.builder(key)
          .set("name", "John Doe")
          .set("age", 30)
          .set("updated", false)
          .build();
      datastore.put(entity);
    } else {
      System.out.println("Entity found! Updating it!");
      boolean updated = entity.getBoolean("updated");
      if (!updated) {
        String[] name = entity.getString("name").split(" ");
        entity = Entity.builder(entity)
            .set("name", name[0])
            .set("last_name", name[1])
            .set("updated", true)
            .remove("old_property")
            .set("new_property", 1.1)
            .build();
        datastore.update(entity);
      }
    }

    System.out.println("Done!");
  }
}

I can get it to compile just fine, then I run into problems running the class. Apparently I need Guava? And google-auth-library-java ? And google-api-java-client ?
What exactly is the best way to get this so that I can run... java HelloDatastore and I'll see some stuff happening.... ?

When using maven one's artifact does not include/bundle all its dependencies.
There are various ways to deal with it but the most recommended way for someone that consumes
a maven artifact[s] is to make its code using maven (http://maven.apache.org/guides/getting-started/maven-in-five-minutes.html) and adding gcloud-java as a dependency as such:

com.google.gcloud
gcloud-java
0.0.3

For latest versions one could use: http://search.maven.org/#search|ga|1|gcloud-java
If you want to run your code (not as a test via "mvn test") you have various options. here are some references:
http://www.vineetmanohar.com/2009/11/3-ways-to-run-java-main-from-maven/
http://mojo.codehaus.org/exec-maven-plugin/examples/example-exec-for-java-programs.html
There are other options such as using ant and ivy (http://ant.apache.org/ivy/history/2.2.0/tutorial/start.html) or using tools or various maven plugins to bundle all jars (latter is not recommended).

@jgeewax let me know what you want to do about this one?

Is there any value is having a "starter-project" template (not the expense report example -- but one that is just a blank template) ?

I think little value. All 3 main IDEs have an option for creating a "starter" maven project and an easy way to add dependencies. Yes, we could create a simple "hello gcloud java" simple project with maven, ant and gradle config files (already configured to pull gcloud-java) (we could also provide project configuration for all 3 main IDEs but I am not sure that is a great idea, especially when configuration may differ between IDEs versions) but I think one could also clone the "expense report" project (when available) and trim the unnecessary files. In any case, I don't object the idea (but not sure where exactly to put it - see: https://maven.apache.org/guides/introduction/introduction-to-the-standard-directory-layout.html -- as I don't think we need to create another gitHub project for it).

My worry is that someone starting like I did with the guide you pointed me to will hit the same ridiculous bug that I hit... A starter project is one way of solving that problem. Do you have ideas for others?

Right, issue #36 could have been avoided by using a pom.xml template that specify Java source/target versions (but this is not great as one, for example, may want to use java 1.8 or later when they come).
Also, other maven related issues could appear when using such an old maven version.
However I just realized we could use maven-enforcer-plugin (http://maven.apache.org/enforcer/maven-enforcer-plugin/usage.html) in the pom template to specify minimum Java and Maven requirements (which will probably solve most of the configuration issues) so maybe not a bad idea after all (alternative would be just document it). Leaving this open so we can take action on it but unassigned it, to allow other to pick it up until I get to it.

Great so the deliverable here is... to somehow use the maven-enforcer plugin to require specific versions?

Yes, though we could do that only in (1) our own pom file for anyone accessing our code via its source/gitHub (2) in the template/simple project that would have its own pom enforcing it.
Probably best would have been if we could someone provide such enforcement on the maven artifact (so anyone that adds us as a dependency would need to confirm to it) but I am not aware of a way to do that (or if that is even possible).

After fix #78  it should be obvious if minimum requirements are not met


Handle Chrome m66+'s change of reporting a deviceorientation rotationRate

Now in degrees rather than radians. Fixes #18.

@dustinkerstein ping for review, not a fan of the UA parsing but not sure what other indicators we have here. Thinking of browsers that report Chrome in UA, but those should have the same deviceorientation unit change. Seems safe but need to give it more thought/testing.

Note that Chrome 66 just fixed a bug to follow the spec, other browsers did it right.
So this logic seems wrong:
if (this.isIOS || this.isFirefoxAndroid || this.isChromeUsingDegrees) {
     this.gyroscope.multiplyScalar(Math.PI / 180);
   }

and should be vice versa, something simple like this:
if (! this.isChromeUsingDegrees) {
     this.gyroscope.multiplyScalar(Math.PI / 180);
   }

(don't know about Edge, though)

@1jj I agree with you, but hesitant for devices that could have changed behaviour when they're not covered by these conditionals. Before releasing a new version, will be doing a full test on devices with possibly that change if there's no breakage


[backport] cfg.mappings could be null when many-to-one mapping is involved

Below is thrown when reopen a data mapper step which contains many-to-one mapping in Syndesis.
atlasmap-main.js:96 TypeError: Cannot read property 'updateMappedFieldsFromDocuments' of null
    at Function.e.deserializeFieldMapping (VM164 atlasmap-vendor.js:4321)
    at Function.e.deserializeMappings (VM164 atlasmap-vendor.js:4235)
    at Function.e.deserializeMappingServiceJSON (VM164 atlasmap-vendor.js:4098)
    at e.reset (VM165 atlasmap-main.js:94)
    at e.ngOnInit (VM165 atlasmap-main.js:73)
    at VM164 atlasmap-vendor.js:14735
    at VM164 atlasmap-vendor.js:14736
    at Fl (VM164 atlasmap-vendor.js:14814)
    at ro (VM164 atlasmap-vendor.js:15169)
    at Object.updateDirectives (VM165 atlasmap-main.js:150)

I don't see this on current upstream, seems to have been fixed. We have to identify the fix and backport to 1.40.x so that potential Syndesis patch release can consume it.

I can't seem to reproduce this error with the latest atlasmap-1.40.x branch.  I think I remember seeing this error in the console a while back - do you have the exact many-to-one mapping ?

ATM it reproduces only in Syndesis, when I open a data mapper step.

A similar step would be to

put a many-to-one mapping
close the browser window
open new window
but standalone even fails to load target document, so it hits another issue...

I think we can do this to make a quick fix
  static deserializeMappingServiceJSON(json: any, mappingDefinition: MappingDefinition, cfg: ConfigModel): void {
    if (!cfg.mappings) {
      cfg.mappings = mappingDefinition;
    }

but it's kinda bug of redundant arguments, for longer term we should remove an argument mappingDefinition here and enforce it to work on cfg.mappings anyway. Current codebase can't handle multiple MappingDefinition for sure and will need bigger refactoring.

To be safer
  static deserializeMappingServiceJSON(json: any, mappingDefinition: MappingDefinition, cfg: ConfigModel): void {
    if (!cfg.mappings) {
      cfg.mappings = mappingDefinition ? mappingDefinition : new MappingDefinition;
    }

backport complete
https://github.com/atlasmap/atlasmap/pull/1149


Add Result type to river_pod

Hi!
I found the Result type created inside the marvel example was really useful and was surprised it wasn't in riverpod. Compared to dartz's Either Result seems more practical and user friendly for typical apps so I'm curious why it wasn't included? I also think it complements AsyncValue's usage nicely.
The current alternative was just to copy the Result implementation myself into my own models. I feel like if it were included in riverpod though it would encourage better practices around Futures and encourage users to look more towards functional solutions.

I didn't include it in riverpod mainly because it's not used by any provider
AsyncValue is depended on by FutureProvider/StreamProvider, but Result is purely a bonus.

I didn't include it in riverpod mainly because it's not used by any provider
AsyncValue is depended on by FutureProvider/StreamProvider, but Result is purely a bonus.

At first I wondered if there were enough special union/sealed classes to warrant another library for just these types but I couldn't find many others.
In any case, I can see how Result isn't necessary to library and might be more clutter than anything. Personally I'd still like to see it in the library solely for the value it adds to writing cleaner code. Feel free to close this or leave open for further comments/votes from others
Thanks Remi!

At first I wondered if there were enough special union/sealed classes to warrant another library for just these types but I couldn't find many others.
In any case, I can see how Result isn't necessary to library and might be more clutter than anything. Personally I'd still like to see it in the library solely for the value it adds to writing cleaner code. Feel free to close this or leave open for further comments/votes from others
Thanks Remi!

Maybe at least include it as an example.  Oh wait, it already is, yes?

Maybe at least include it as an example.  Oh wait, it already is, yes?

Meh, I've personally changed my own opinion on this. Closing as there's already an implementation in the example and I feel like that's good enough.


sbt classloaders should not return null from java.lang.ClassLoader#getResources

this breaks general contract of the method
in particular i'm having an issue with NullLoader returning null at https://github.com/hazelcast/hazelcast/blob/db8721eab91961d61ef4957682e71ce9dc3fdcf7/hazelcast/src/main/java/com/hazelcast/util/ServiceLoader.java#L169
using sbt 0.13.5-RC5

Just hit the same issue, also with hazelcast.
@OlegYch Did you find a workaround?


Pets are staying in place after logoff

After I logoff the pet I have floating behind me becomes a floating head and doesn't disappear when I log off, i know have logged back in and the pet is floating there separate from me  and there are now 2 of them?

If you use protocollib this problem won't occur anymore

Protocollib is installed, is there anything else?

Make sure that in the config useProtocollib is true, after that this error won't occur anymore.


[Bug]: wav file path output by create_custom_dataset function in recipes/WSJ0Mix/prepare_data.py

Describe the bug
All wav file paths in the csv file output by the create_custom_dataset function in recipes/WSJ0Mix/prepare_data.py are the paths of the mixture directory.
Expected behaviour
The paths to the source1 and source2 directories are output to a csv file.
To Reproduce
from prepare_data import create_custom_dataset

create_custom_dataset(
        '/root/speechbrain/recipes/WSJ0Mix/temp_data',
        '/root/speechbrain/recipes/WSJ0Mix/data'
        )

### Versions

speechbrain version is 0.5.13
I installed it with the `git clone` command.

### Relevant log output

```shell
ID,duration,mix_wav,mix_wav_format,mix_wav_opts,s1_wav,s1_wav_format,s1_wav_opts,s2_wav,s2_wav_format,s2_wav_opts,noise_wav,noise_wav_format,noise_wav_opts
0,1.0,/root/speechbrain/recipes/WSJ0Mix/temp_data/train/mixture/00000013_S00000001[B003M001]-N00000013[B019M013]_Mix.wav,wav,,/root/speechbrain/recipes/WSJ0Mix/temp_data/train/source1/00000009_S00000001[B003M001]-N00000009[B019M009]_Mix.wav,wav,,/root/speechbrain/recipes/WSJ0Mix/temp_data/train/source2/00000002_S00000001[B003M001]-N00000002[B019M002]_Mix.wav,wav,,,,
1,1.0,/root/speechbrain/recipes/WSJ0Mix/temp_data/train/mixture/00000018_S00000001[B003M001]-N00000018[B019M018]_Mix.wav,wav,,/root/speechbrain/recipes/WSJ0Mix/temp_data/train/source1/00000020_S00000001[B003M001]-N00000020[B019M020]_Mix.wav,wav,,/root/speechbrain/recipes/WSJ0Mix/temp_data/train/source2/00000010_S00000001[B003M001]-N00000010[B019M010]_Mix.wav,wav,,,,
2,1.0,/root/speechbrain/recipes/WSJ0Mix/temp_data/train/mixture/00000010_S00000001[B003M001]-N00000010[B019M010]_Mix.wav,wav,,/root/speechbrain/recipes/WSJ0Mix/temp_data/train/source1/00000019_S00000001[B003M001]-N00000019[B019M019]_Mix.wav,wav,,/root/speechbrain/recipes/WSJ0Mix/temp_data/train/source2/00000009_S00000001[B003M001]-N00000009[B019M009]_Mix.wav,wav,,,,
3,1.0,/root/speechbrain/recipes/WSJ0Mix/temp_data/train/mixture/00000009_S00000001[B003M001]-N00000009[B019M009]_Mix.wav,wav,,/root/speechbrain/recipes/WSJ0Mix/temp_data/train/source1/00000014_S00000001[B003M001]-N00000014[B019M014]_Mix.wav,wav,,/root/speechbrain/recipes/WSJ0Mix/temp_data/train/source2/00000018_S00000001[B003M001]-N00000018[B019M018]_Mix.wav,wav,,,,
4,1.0,/root/speechbrain/recipes/WSJ0Mix/temp_data/train/mixture/00000005_S00000001[B003M001]-N00000005[B019M005]_Mix.wav,wav,,/root/speechbrain/recipes/WSJ0Mix/temp_data/train/source1/00000004_S00000001[B003M001]-N00000004[B019M004]_Mix.wav,wav,,/root/speechbrain/recipes/WSJ0Mix/temp_data/train/source2/00000015_S00000001[B003M001]-N00000015[B019M015]_Mix.wav,wav,,,,
5,1.0,/root/speechbrain/recipes/WSJ0Mix/temp_data/train/mixture/00000007_S00000001[B003M001]-N00000007[B019M007]_Mix.wav,wav,,/root/speechbrain/recipes/WSJ0Mix/temp_data/train/source1/00000005_S00000001[B003M001]-N00000005[B019M005]_Mix.wav,wav,,/root/speechbrain/recipes/WSJ0Mix/temp_data/train/source2/00000007_S00000001[B003M001]-N00000007[B019M007]_Mix.wav,wav,,,,
6,1.0,/root/speechbrain/recipes/WSJ0Mix/temp_data/train/mixture/00000008_S00000001[B003M001]-N00000008[B019M008]_Mix.wav,wav,,/root/speechbrain/recipes/WSJ0Mix/temp_data/train/source1/00000013_S00000001[B003M001]-N00000013[B019M013]_Mix.wav,wav,,/root/speechbrain/recipes/WSJ0Mix/temp_data/train/source2/00000012_S00000001[B003M001]-N00000012[B019M012]_Mix.wav,wav,,,,
7,1.0,/root/speechbrain/recipes/WSJ0Mix/temp_data/train/mixture/00000001_S00000001[B003M001]-N00000001[B019M001]_Mix.wav,wav,,/root/speechbrain/recipes/WSJ0Mix/temp_data/train/source1/00000008_S00000001[B003M001]-N00000008[B019M008]_Mix.wav,wav,,/root/speechbrain/recipes/WSJ0Mix/temp_data/train/source2/00000013_S00000001[B003M001]-N00000013[B019M013]_Mix.wav,wav,,,,
8,1.0,/root/speechbrain/recipes/WSJ0Mix/temp_data/train/mixture/00000019_S00000001[B003M001]-N00000019[B019M019]_Mix.wav,wav,,/root/speechbrain/recipes/WSJ0Mix/temp_data/train/source1/00000001_S00000001[B003M001]-N00000001[B019M001]_Mix.wav,wav,,/root/speechbrain/recipes/WSJ0Mix/temp_data/train/source2/00000014_S00000001[B003M001]-N00000014[B019M014]_Mix.wav,wav,,,,
9,1.0,/root/speechbrain/recipes/WSJ0Mix/temp_data/train/mixture/00000011_S00000001[B003M001]-N00000011[B019M011]_Mix.wav,wav,,/root/speechbrain/recipes/WSJ0Mix/temp_data/train/source1/00000012_S00000001[B003M001]-N00000012[B019M012]_Mix.wav,wav,,/root/speechbrain/recipes/WSJ0Mix/temp_data/train/source2/00000011_S00000001[B003M001]-N00000011[B019M011]_Mix.wav,wav,,,,

Additional context
No response

Hello @cemildemir19, could you please take a look at it? Thanks!

I found a bug where mix data and reference data did not match.
To fix the first bug as well, I propose to modify the code as follows
def create_custom_dataset(
    datapath,
    savepath,
    dataset_name="custom",
    set_types=["train", "valid", "test"],
    folder_names={
        "source1": "source1",
        "source2": "source2",
        "mixture": "mixture",
    },
):
    """
    This function creates the csv file for a custom source separation dataset
    """

    for set_type in set_types:
        mix_path = os.path.join(datapath, set_type, folder_names["mixture"])
        s1_path = os.path.join(datapath, set_type, folder_names["source1"])
        s2_path = os.path.join(datapath, set_type, folder_names["source2"])

        mix_files = os.listdir(mix_path)
        s1_files = os.listdir(s1_path)
        s2_files = os.listdir(s2_path)
        mix_files = sorted(mix_files)
        s1_files = sorted(s1_files)
        s2_files = sorted(s2_files)

        mix_fl_paths = [os.path.join(mix_path, fl) for fl in mix_files]
        s1_fl_paths = [os.path.join(s1_path, fl) for fl in s1_files]
        s2_fl_paths = [os.path.join(s2_path, fl) for fl in s2_files]

Hello @ycemsubakan , any ideas on that, please?

Sorry the lack of response. Will take a look.


Fix pzmap grid (matplotlib angle_helper)

CI runs started to fail today with:
Traceback (most recent call last):
959  File "pvtol-nested.py", line 169, in <module>
960    P, Z = pzmap(T, plot=True, grid=True)
961  File "/home/travis/build/python-control/python-control/control/pzmap.py", line 106, in pzmap
962    ax, fig = sgrid()
963  File "/home/travis/build/python-control/python-control/control/grid.py", line 82, in sgrid
964    ax.axis["wnxneg"] = axis = ax.new_floating_axis(0, 180)
965  File "/home/travis/miniconda/envs/test-environment/lib/python3.6/site-packages/mpl_toolkits/axisartist/axislines.py", line 575, in new_floating_axis
966    axes=self)
967  File "/home/travis/miniconda/envs/test-environment/lib/python3.6/site-packages/mpl_toolkits/axisartist/grid_helper_curvelinear.py", line 350, in new_floating_axis
968    axisline = AxisArtist(axes, _helper)
969  File "/home/travis/miniconda/envs/test-environment/lib/python3.6/site-packages/mpl_toolkits/axisartist/axis_artist.py", line 746, in __init__
970    self._init_line()
971  File "/home/travis/miniconda/envs/test-environment/lib/python3.6/site-packages/mpl_toolkits/axisartist/axis_artist.py", line 887, in _init_line
972    self._axis_artist_helper.get_line(self.axes),
973  File "/home/travis/miniconda/envs/test-environment/lib/python3.6/site-packages/mpl_toolkits/axisartist/grid_helper_curvelinear.py", line 270, in get_line
974    self.update_lim(axes)
975  File "/home/travis/miniconda/envs/test-environment/lib/python3.6/site-packages/mpl_toolkits/axisartist/grid_helper_curvelinear.py", line 101, in update_lim
976    self.grid_helper.update_lim(axes)
977  File "/home/travis/miniconda/envs/test-environment/lib/python3.6/site-packages/mpl_toolkits/axisartist/axislines.py", line 327, in update_lim
978    self._update(x1, x2, y1, y2)
979  File "/home/travis/miniconda/envs/test-environment/lib/python3.6/site-packages/mpl_toolkits/axisartist/grid_helper_curvelinear.py", line 319, in _update
980    self._update_grid(x1, y1, x2, y2)
981  File "/home/travis/miniconda/envs/test-environment/lib/python3.6/site-packages/mpl_toolkits/axisartist/grid_helper_curvelinear.py", line 367, in _update_grid
982    self.grid_info = self.grid_finder.get_grid_info(x1, y1, x2, y2)
983  File "/home/travis/miniconda/envs/test-environment/lib/python3.6/site-packages/mpl_toolkits/axisartist/grid_finder.py", line 104, in get_grid_info
984    extremes = self.extreme_finder(self.inv_transform_xy, x1, y1, x2, y2)
985  File "/home/travis/build/python-control/python-control/control/grid.py", line 44, in __call__
986    self._adjust_extremes(lon_min, lon_max, lat_min, lat_max)
987AttributeError: 'ModifiedExtremeFinderCycle' object has no attribute '_adjust_extremes'

Apparently Matplotlib removed the private function _adjust_extremes between 3.2 and 3.3 (I could not find the commit yet. Clicking blame on github doesn't work. Their git history is weird).
The specific branch of pzmap and this portion of grid.py are not covered by the unit tests. Hence it was not discovered until now, when conda updated matplotlib and it fails in the pvtol-nested.pyexample.

Coverage decreased (-10.7%) to 73.487% when pulling df0051c2849bc7accf772ee80faeb752b0478002 on bnavigator:fix-mpl-grid into 08d5e6ce2dfb99aee9d3d51d5689fac24cca7baa on python-control:master.

Added unit tests. Two fixtures editsdefaults and mplcleanup written for #438 are made especially for the use case here, so I pulled them from there. That should be relative benign when merging.
Found a copy and paste error in the pzmap defaults handling

Look at that increased coverage :)
Found another config/"defaults" handling bug in pzmap through the tests.


chore: add taraxa_devs account for devnet and testnet

Purpose

How does the solution address the problem

Changes made

prnet cleaned-up successfully


M1 Pro 14 inch

Does lora can be run on M1 Pro MacBook? 14gb gpu

Yup! It is largely hardware-agnostic.


gradle\wrapper\gradle-wrapper.jar needs to be checked in to project

Acceptance Criteria:

add gradle\wrapper\gradle-wrapper.jar to project
make sure gradlew runs after pulling a clean copy of the project

Steps to Reproduce:

pull master
run ./gradlew
Expect:
Gradle runs and builds the project
Actual:
Error: Could not find or load main class org.gradle.wrapper.GradleWrapperMain

Environment:
Win10Ent cmd.exe (but I don't expect it's windows-specific)

fixed


Allow extra options to be passed to jsdom.env

Fixes #29 for me

So sorry for not seeing this pull request until now. Thanks for the contribution!


RFC: ESLint support

Willing to make a PR for eslint support. Will this be welcome?

Most welcome :)

I think its better to keep this open until i get around to doing this


Add scala_doc rule

Closes https://github.com/bazelbuild/rules_scala/issues/230.
Summary
This PR adds a basic implementation of scala_doc.
I hesitate to recommend using it widely yet since I haven't figured out if there are weird edge cases. Would it be better to somehow designate this as experimental or something?
I did not automatically compress outputted scaladoc, instead I think you could use pkg_tar.
Performance
For an internal target, scaladoc takes ~17sec to scaladoc for "324 documentable templates".
Comparatively, cats-core takes ~32sec to scaladoc for "771 documentable templates":
sbt:cats> coreJVM/doc
[info] Main Scala API documentation to /Users/long/oss/cats/core/.jvm/target/scala-2.12/api...
model contains 771 documentable templates
[info] Main Scala API documentation successful.
[success] Total time: 32 s, completed May 29, 2019 2:01:16 PM

... which seems to makes sense to me.
To wit, I've added a note in the markdown documentation that users may want to mark scala_doc targets as manually built but YMMV.
Testing

Added a simple test target that also pulls in kind-projector and passes that along via aspect as a compiler plugin to scaladoc.
Ran this against an internal scala_doc target.

For your convenience, a link to view scala_doc.md.

This is great, thanks @long-stripe !
One question: is there an easy way to combine this with a bazel query to find all the scala_libraries in a repo and build one giant documentation build? It might be impractical, but many folks might want to build one build of the docs per repo.
I guess some bazel query with kind of scala_library might do it. If we could add that to the documentation, it might help people.

@johnynek I do seem to remember running a query that found all targets of a kind of rule, so that certainly sounds plausible! Would be nice to throw up in the docs as a way to build a big scala_doc target.

@johnynek is scaladoc-ing external/3rd party dependencies (e.g. cats-core) something users would want to do?
As far as I can tell most of the time it's about the user's library code so srcs is what we're looking for here. If we pulled in source jars indiscriminately I could imagine this exploding into a truly gigantic ball of documentation... or am I misunderstanding?

@long-stripe if you return a type in your code, it is a bit of a bummer if you can't see anything about that type in the generated docs. We can certainly merge without that feature, but I think the ability to build the full documentation fully linked would be nice.

@long-stripe question: have you tried a build of the internal target pointing at this rule defined remotely? sometimes we shake out bugs with the remote repositories.

@johnynek

Yeah that would be nice - I am not sure how it works out in the greater Scala ecosystem. How does http://circe.github.io/circe/api/io/circe/Decoder$.html#Result[A]=Either[io.circe.DecodingFailure,A], for example, link back to scala.util.Either? And it doesn't seem to be consistent for other projects... hmm.

I have not tried that. I assume when you say remotely you mean on CI? I've been testing by pointing to a local rules_scala with native.local_repository. I wouldn't expect there to be problems given that I'm reusing some already defined targets like scala_compiler and I'm not doing anything that weird...

I'm in favor of merging and iterating rather than trying to imagine all outcomes. Let's get using this from the main repo, and see if we hit any issues.

Same - would rather land this, possibly marked as experimental, and iterate.

Oof- this doesn't work on Windows, probably because of platform differences like classpaths being defined with ; or something.
https://travis-ci.org/bazelbuild/rules_scala/jobs/538958622#L326

the windows build failed, but it often does and the original contributor hasn't had time to diagnose.

actually, I was wrong, you are right. This is a new failure related to scaladoc.
@long-stripe do you think you could take a stab at making it work? There are a few places where we have to do things like that now.

@johnynek yeah I think that should be fixed prior to merging. Do you have an example of switching per-platform behavior?

Pushed a few more changes, again testing against an internal target:

We now properly collect all src_files and compile_jars for deps up the propagation graph and not just one level in from the rule's deps.
Turned off warnings since my bet is that scala_doc targets will tend to be larger collations, warnings will surely obscure actual showstopper errors and don't get in the way of scaladoc generation. It's better to have the warnings generated by regular bazel builds on the scala_library calls anyhow.
Turns out we needed to propagate scalacopts for more complex source files! Duh.

(I'll look into fixing Windows builds tomorrow)

@johnynek looks like the classpath thing was it for Windows builds... would appreciate a re-review since I added new behavior in https://github.com/bazelbuild/rules_scala/pull/760/commits/48fc3d4f63219b90fe30afaaf1eea2bb41dc5c50, its intended purpose is to collect all src_files and compile_jars along the dependency graph.

looks great to me. Let's merge and iterate.
I'm a bit dubious of hardwiring the -nowarn vs making it the default scalacopts, but I do see your argument that you should be dealing with code warnings in your scala_library targets, not here.


Bump dev dependencies for template

Updated libraries

Library
Current
Latest
Major?
Reason

autoprefixer
6.7.2
7.1.2
Yes
Drop support for node 0.12 ⇗

babel-loader
6.2.10
7.1.1
Yes
Drop support for node < 4, webpack 1 ⇗

chalk
1.1.3
2.0.1
Yes
API changes, Drop support for node < 4 ⇗

cross-env
4.0.0
5.0.1
Yes
Scripts using quotes or escape sequences will see a difference in behavior. ⇗

eslint-friendly-formatter
2.0.7
3.0.0
Yes
Make relative paths the default again in err reports ⇗

eslint-plugin-html
2.0.0
3.1.0
Yes
lint script tags separately, fix custom formatters support ⇗

karma-spec-reporter
0.0.30
0.0.31
No
allow prefix overrides on win32 ⇗

lolex
1.5.2
2.0.0
Yes
New install() signature ⇗

opn
4.0.2
5.1.0
Yes
Drop support for node < 4 ⇗

optimize-css-assets-webpack-plugin
1.3.0
2.0.0
Yes
Move cssnano dependency to peerDependencies ⇗

sw-precache-webpack-plugin
0.9.1
0.11.4
Maybe
API changes, internal refactoring, webpack 3 compatibility⇗

Not updated due to peer dependency

Library
Current
Latest
Major?
Reason
Peer dependency
PR

eslint
3.19.0
4.2.0
Yes
New rules in recommended, more strict ⇗
eslint-config-airbnb-base
airbnb/javascript#1447

chai
3.5.0
4.0.2
Yes
API changes, Drop support for node < 4 ⇗
karma-sinon-chai
kmees/karma-sinon-chai#48

extract-text-webpack-plugin
2.1.2
3.0.0
Yes
Drop support for node < 4.3.0, webpack < 3.1.0 ⇗
webpack
NA

Added cssnano to devDependencies as it is needed for optimize-css-assets-webpack-plugin now as peer dependency.
Although vue-loader and webpack have been updated, I have not bumped their versions as there are significant changes and should be tackled in a different PR.
This PR is a clone of vuejs-templates/webpack#790 with some changes:

eslint-plugin-html has been updated to v3.1.0 instead of 3.0.0
lolex has been updated to v2.0.0
sw-precache-webpack-plugin has been updated to v0.11.4
extract-text-webpack-plugin has a major version update available but was not updated due to webpack 3 peer dependency.

👍


Introduce visualization

Checklist
Thank you for contributing to QuantumToolbox.jl! Please make sure you have finished the following tasks before opening the PR.

[x] Please read Contributing to QuantumToolbox.jl.
[x] Any code changes were done in a way that does not break public API.
[x] Appropriate tests were added and tested locally by running: make test.
[x] Any code changes should be julia formatted by running: make format.
[x] All documents (in docs/ folder) related to code changes were updated and able to build locally by running: make docs.
[x] (If necessary) the CHANGELOG.md should be updated (regarding to the code changes) and built by running: make changelog.

Request for a review after you have completed all the tasks. If you have not finished them all, you can also open a Draft Pull Request to let the others know this on-going work.
Description
Most of the things are done in PR #292, this PR will focus on the CI pipeline config setup for CairoMakie extension.
Related issues or PRs
PR #292
close #86

Weird, everything run on my local PC is fine.

There are also the commits of the previous PR.

There are also the commits of the previous PR.

Because they are not merged to main yet.


Show 'Add Razor Page...' in the menu in Razor Pages web application

I wanted to add a razor page in an area of a Razor web pages application, but the top menu item says 'Controller..'. Since this is a Razor Pages web application, we should show 'Razor Page...' as the default option.

@seancpeters, is this something to be moved to Scaffoling repo?

It's a scaffolding-related issue, but the required change would be to Visual Studio - not a change in the aspnet/scaffolding repo.

@seancpeters, @pranavkm, do you know where this should be moved to?

@ToddGrun do you know who should own this?

you can create a VS issue using report a project/Provide a suggestion

We will route it to the Scaffolding crew from there.

@kichalla - can you report this via VS so we can close this issue?

Sure, I created an issue now using VS feedback:
https://visualstudio.uservoice.com/forums/121579-visual-studio-ide/suggestions/34785640-show-razor-page-in-add-menu-for-a-razor-pag


Fixed links to architecture.md and principles.md

Recently, architecture.md and principles.md were moved into a subdirectory architecture and links to them are now broken.
This PR fixes links to these two documents in the kubernetes.github.io repo.

This change is

@ianchakeres Please rebase your branch so that it picks up 99fbc2b. That will fix the deploy/netlify failure. Thanks.

@steveperry-53 I rebased. PTAL and let me know if you'd like anything else changed.

Cool!
/lgtm

@ianchakeres Sorry, looks like there's a merge conflict w/ docs/concepts/overview/what-is-kubernetes.md now.

@chenopis - I rebased and fixed the merge conflict. PTAL

/lgtm


mouse got captured when drag Transform

System: Windows 7, Nvidia GT 610

OK, seems this is a problem in Godot (#11893). I submitted a PR so it should be fixed in 3.1. I also added a workaround in this project so the mouse pointer is released when dropping the node (it is just dropped at the center of the GraphEdit, still a bit annoying).

thanks for reporting the issue

Hmm I'm afraid that problem is back, but not sure which widget type causes it...

Didn't notice the problem for a while... Let's close it for now.


Building full VTK using emscripten?

There is an emscripten-built VTK in docker kitware/itk-js-vtk, and seems it disabled rendering part of VTK.
I have been trying to build VTK using emscripten with rendering backend enabled, but no luck with executing web app.
VTK can be successfully built, but when I try to use vtkRenderWindow, there errors occur. I found that vtk keeps trying to use OpenGL functions that are not existing in OpenGLES, such as glDrawBuffer.
There is a  emscripten-EGL example
https://github.com/EJShim/emscripten_EGL/blob/master/ref.cpp
that uses EGL and X11 to display OpenGL Code in web. (gles3.0, webgl2.0)
So I built vtk using VTK_OPENGL_HAS_EGL=ON flag and tried to use vtkEGLRenderWindow
but the app still trying to call glDrawBuffer()  in vtkOpenGLRenderWindow class and results error.
I know I can simply use vtk.js , but I think there also might be a way to use c++ vtk to render WebGL.

VTK does need further patches to support rendering via Emscription.

Are there any new developments in this regard? @EJShim Have you tried compiling?

We are waiting for a contribution which is supposed to happen soon.

Haven't tried yet. I think if VTK does support GLES rendering such as android, it should also be possible rendering on web. I don't know which part of VTK should be updated: Raw VTK source code or CMake script.

Updates to the kitware/itk-js-vtk Docker image are coming via #339 . We will add an example after the next release.

@thewtex I tried to run Cone example, but having error when running, saying "wasm streaming compile failed: TypeError: Failed to execute 'compile' on 'WebAssembly': Incorrect response MIME type. Expected 'application/wasm'."
Thank you for your work anyway!

@thewtex Is there a reason why antialiasing is disabled for SDL2OpenGLRenderWindow? I can see  SDL_GL_SetAttribute(SDL_GL_MULTISAMPLEBUFFERS, 0); from renderwindow, and renderWindow->SetMultiSamples(0) in the example code.

You should be able to set MultiSamples to 8 and it should work. SDL will be left as non multisampled which should be fine as the rendering all happens in a framebuffer which can be multisampled and then gets blitted into the SDL window

renderWindow->SetMultiSamples(8)  does not change anything. I found antialias:false setting somewhere in emscripten output.js. var EGL={errorCode:12288,defaultDisplayInitialized:false,currentContext:0,currentReadSurface:0,currentDrawSurface:0,contextAttributes:{alpha:false,depth:false,stencil:false,antialias:false}
If I force to set {antialias:true} here, I get error saying
[.WebGL-0x7f866b50ce00]GL ERROR :GL_INVALID_OPERATION : glBlitFramebufferCHROMIUM: destination framebuffer is multisampled

If I compile below (only using gl and SDL) code and set antialias:true in webglContext, antialiasing can be enabled
`
#include
#include <emscripten.h>
#include <SDL.h>
#include
#define GL_GLEXT_PROTOTYPES 1
#include <SDL_opengles2.h>
// Shader sources
const GLchar* vertexSource =
"attribute vec4 position;                     \n"
"void main()                                  \n"
"{                                            \n"
"  gl_Position = vec4(position.xyz, 1.0);     \n"
"}                                            \n";
const GLchar* fragmentSource =
"precision mediump float;\n"
"void main()                                  \n"
"{                                            \n"
"  gl_FragColor[0] = gl_FragCoord.x/640.0;    \n"
"  gl_FragColor[1] = gl_FragCoord.y/480.0;    \n"
"  gl_FragColor[2] = 0.5;                     \n"
"}                                            \n";
//Global Things...
SDL_Window *window;
GLfloat vertices[] = {0.0f, 0.5f, 0.5f, -0.5f, -0.5f, -0.5f};
// an example of something we will control from the javascript side
bool background_is_black = true;
// the function called by the javascript code
extern "C" void EMSCRIPTEN_KEEPALIVE toggle_background_color() {
background_is_black = !background_is_black;
}
extern "C" void EMSCRIPTEN_KEEPALIVE resize_window(){
std::cout << "resize " << std::endl;
}
// std::function<void()> loop{}
void main_loop() {
// move a vertex
const uint32_t milliseconds_since_start = SDL_GetTicks();
const uint32_t milliseconds_per_loop = 3000;
vertices[0] = ( milliseconds_since_start % milliseconds_per_loop ) / float(milliseconds_per_loop) - 0.5f;
glBufferData(GL_ARRAY_BUFFER, sizeof(vertices), vertices, GL_STATIC_DRAW);
// Clear the screen
if( background_is_black )
    glClearColor(0.0f, 0.0f, 0.0f, 1.0f);
else
    glClearColor(0.9f, 0.0f, 0.0f, 1.0f);
glClear(GL_COLOR_BUFFER_BIT);

// Draw a triangle from the 3 vertices
glDrawArrays(GL_TRIANGLES, 0, 3);

SDL_GL_SwapWindow(window);

}
int main()
{
SDL_CreateWindowAndRenderer(1000, 1000, 0, &window, nullptr);
SDL_GL_SetAttribute(SDL_GL_CONTEXT_MAJOR_VERSION, 3);
SDL_GL_SetAttribute(SDL_GL_CONTEXT_MINOR_VERSION, 0);
SDL_GL_SetAttribute(SDL_GL_MULTISAMPLEBUFFERS, 1);
SDL_GL_SetAttribute(SDL_GL_MULTISAMPLESAMPLES, 2);

// Create a Vertex Buffer Object and copy the vertex data to it
GLuint vbo;
glGenBuffers(1, &vbo);

glBindBuffer(GL_ARRAY_BUFFER, vbo);
glBufferData(GL_ARRAY_BUFFER, sizeof(vertices), vertices, GL_STATIC_DRAW);

// Create and compile the vertex shader
GLuint vertexShader = glCreateShader(GL_VERTEX_SHADER);
glShaderSource(vertexShader, 1, &vertexSource, nullptr);
glCompileShader(vertexShader);

// Create and compile the fragment shader
GLuint fragmentShader = glCreateShader(GL_FRAGMENT_SHADER);
glShaderSource(fragmentShader, 1, &fragmentSource, nullptr);
glCompileShader(fragmentShader);

// Link the vertex and fragment shader into a shader program
GLuint shaderProgram = glCreateProgram();
glAttachShader(shaderProgram, vertexShader);
glAttachShader(shaderProgram, fragmentShader);
glLinkProgram(shaderProgram);
glUseProgram(shaderProgram);

// Specify the layout of the vertex data
GLint posAttrib = glGetAttribLocation(shaderProgram, "position");
glEnableVertexAttribArray(posAttrib);
glVertexAttribPointer(posAttrib, 2, GL_FLOAT, GL_FALSE, 0, 0);

emscripten_set_main_loop(main_loop, 0, true);

return EXIT_SUCCESS;

}
`

I looked into it and SetMultiSample(8) doesn't work right now as the framebuffer is trying to use multisampled textures and gles 3.0 (and webgl2) doesn't support them. It does support multisampled renderbuffers so we can pretty easily modify the framebuffer creation to use renderbuffers instead of textures for multisampled gles. I'll give it a shot tomorrow.

OK I have it working with multisamples on both firefox/chrome. It required a couple changes but I'll try to get them merged soon.

@martinken Another problem occurs when I try to volume rendering using SDL2OpenGLRenderWindow.
it says :
Cone.js:2178 ERROR: In ../Rendering/OpenGL2/vtkShaderProgram.cxx, line 453

vtkShaderProgram (0xb4c220): ERROR: 0:498: '<=' : wrong operand types - no operation '<=' exists that takes a left-hand operand of type 'highp float' and a right operand of type 'const int' (or there is no acceptable conversion)

ERROR: In ../Rendering/VolumeOpenGL2/vtkOpenGLGPUVolumeRayCastMapper.cxx, line 2664

vtkOpenGLGPUVolumeRayCastMapper (0xb17f58): Shader failed to compile

[.WebGL-0x7fe7c15f9c00]GL ERROR :GL_INVALID_OPERATION : glTexImage3D: invalid internalformat/format/type combination GL_RGB/GL_RGB/GL_FLOAT

[.WebGL-0x7fe7c15f9c00]GL ERROR :GL_INVALID_OPERATION : glTexSubImage3D: level 0 does not exist

Can it also be resolved too? I am guessing currently VTK does not support volume rendering for GLES

Volume rendering doesn't work last I checked. I think it is all shader code issues due to some webgl glsl compilers being strict/bad. The first error is an easy fix and I fixed a few of them already.  But there are other issues. I think they can all be fixed and Sankhesh is going to take a look at some of them in a bit.

OK the multisample stuff is merged and should be working. Volume rendering is still an issue, feel free to open an issue on that. I just don't want this issue to be too broad. Thanks!

@martinken Thank you for your work! I can see the antialiasing issue is resolved. But I found another problem occurs when I run this example.
I removed renderWindow->SetMultiSamples(0);  from the example code and the renderwindow goes somehow wrong..

Thanks, should be fixed in master now

Seems like it is almost fully supported now in VTK.9.x


added support for UWP

Hey !
I added support for the Universal Windows Platform, tested on my Lumia 950xl.
It's my first pull request, hope this is well done :)

New commit, every your comments are fixed.
Hey, no problem, comments are there for good reason ;)
Sure, you can add me on the organization, I'll do fixes and improvements for the future, with PRs, indeed ;)

More one commit ;)

@tontonrally Can you mail me on<EMAIL_ADDRESS>I added you to the org, would be cool if you could provide a small demo for UWP if that isn't too hard for you :) or extend the current example


RefreshingOAuth2CredentialsInterceptor.TIMEOUT should be final

https://github.com/GoogleCloudPlatform/cloud-bigtable-client/blob/9f2e7206e3198cf3a1992dd8195925573fa64a09/bigtable-client-core-parent/bigtable-client-core/src/main/java/com/google/cloud/bigtable/grpc/io/RefreshingOAuth2CredentialsInterceptor.java#L58
Constants should be final, otherwise someone can easily write:
RefreshingOAuth2CredentialsInterceptor.TIMEOUT = Duration.ZERO;

We originally intended that users ought to be able to modify this themselves.  We need a better way to do that.  Ideally, this timeout would be passed to the Credentials object somehome.

I'd strongly discourage the use of public static mutable fields, especially if it's being named like a CONSTANT (when it's non-final).

ack.


ADDED PRIVACY POLICY PAGE

Fixes:  #1074
Description
Resolved the issue by creating a separate privacy policy page as requested. The footer link has been updated to redirect users to this newly created page, ensuring easy access to privacy information.

Type of PR

[X] Bug fix
[X] Feature enhancement
[X] Documentation update
[ ] Other (specify): _______________

Screenshots / videos (if applicable)
screen-capture (1).webm
Checklist:

[X] I have made this change from my own.
[X] I have taken help from some online resources.
[X] My code follows the style guidelines of this project.
[X] I have performed a self-review of my own code.
[X] I have commented my code, particularly in hard-to-understand areas.
[X] I have made corresponding changes to the documentation.
[X] My changes generate no new warnings.
[X] I have tested the changes thoroughly before submitting this pull request.
[X] I have provided relevant issue numbers and screenshots after making the changes.

@PriyaGhosal please review this once and add level according to it maybe 3 as i made a separate page!!

@PriyaGhosal please check it once and if suitable merge it and assign me #1076  so that i can start work on tht too

@snehhhcodes Please see the conflicts . Resolve the conflicts . Ensure you pull all the latest changes before pushing your feature/bug fixes to the main branch.

@snehhhcodes Are you working on it

@snehhhcodes Are you working on it

yes m working on it

@PriyaGhosal can you check it now

@PriyaGhosal UPDATED!!


Update Stable Diffusion examples

What does this PR do?

This PR replaces CompVis/stable-diffusion-v1-4 by runwayml/stable-diffusion-v1-5 in the documentation and in examples.
Before submitting

[ ] This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
[ ] Did you make sure to update the documentation with your changes?
[ ] Did you write any new necessary tests?

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.


Update sbt-mima-plugin to 0.5.0

Updates com.typesafe:sbt-mima-plugin from 0.4.0 to 0.5.0.
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention @scala-steward in the comments below.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [{ groupId = "com.typesafe", artifactId = "sbt-mima-plugin" }]

labels: semver-minor

Codecov Report

Merging #17 into master will not change coverage.
The diff coverage is n/a.

@@         Coverage Diff          @@
##           master   #17   +/-   ##
====================================
  Coverage       0%    0%
====================================
  Files           1     1
  Lines          66    66
====================================
  Misses         66    66

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 05a222d...3faaab0. Read the comment docs.


Add onrelativetimeupdated getter

This adds the onRelativeTimeUpdated field. This is similar to the on properties that are available on all html classes. It's useful for:

Checking support of an element. The presence of the property can be checked to determine the version/featureset of the element (const supportsUpdated = 'onRelativeTimeUpdated' in el)
Allows React to map to the prop

:wave: Hello and thanks for pinging us! This issue or PR has been added to our inbox and a Design Infrastructure first responder will review it soon.

:art: If this is a PR that includes a visual change, please make sure to add screenshots in the description or deploy this code to a lab machine with instructions for how to test.
:fast_forward: If this is a PR that includes changes to an interaction, please include a video recording in the description.
:warning: If this is urgent, please visit us in #primer on Slack and tag the first responders listed in the channel topic.


stage-1 almost complete except special characters

Looks good to me! Albeit, my CSS knowledge is pretty minimal. I think it's pretty nice and readable. Your HTML looks pretty good though!


Ability to filter by canceled or not canceled

⚠ Please check that this feature request hasn't been suggested before.

[X] I searched previous Ideas in Discussions didn't find any similar feature requests.
[X] I searched previous Issues didn't find any similar feature requests.
[X] I am only requesting a single feature. Multiple changes should be split into individual requests, with links between them.
[X] I believe my requested feature will be generally applicable to other users, not just me: it is not uniquely tied to my personal workflow.

🔖 Feature description
It doesn't seem possible to use in tasks search...
(not done) and (not canceled)
I prefer to ignore canceled stuff because I've decided to. I don't want to set the status to canceled then done so each task doesn't show up in my master task list.
✔ Solution
Duplicate the logic for "done" and apply it to canceled or not canceled.
❓ Alternatives
No response
📝 Additional Context
    (not done) AND (not canceled) AND (due after yesterday) AND (due before in two weeks)

The error message is:
    couldn't parse sub-expression 'not canceled'```

Good news: this is already possible, via status.type searches
status.type is not cancelled

Also, if you read the docs for 'not done' you will see it excludes CANCELLED tasks anyway, so you don't need to separately filter out cancelled tasks:
https://publish.obsidian.md/tasks/Queries/Filters#Status


[ REFACTOR ] combine qiskit "How-Tos" into a single "Simulate using the Qiskit reference primitives" page

As part of the qiskit docs file migration we have moved the following "how to" guides to the Test section:

(How To) Compute circuit output probabilities with Sampler primitive
(How To) Compute an expectation value with Estimator primitive

we should combine these how-tos into a single page titled "Simulate using Qiskit reference primitives"

Once @Eric-Arellano has finished converting to .mdx in #170, I will combine these into a single ipynb


When the user is trying to view the mini cart then Product Quantity Looks like as a minus value

Bagisto Version: Master
Steps To reproduce--
1. Login as a customer
2. Add some items into the cart.
3. Try to view the product quantity in the mini cart.
Actual result: When the user is trying to view the mini cart then Product Quantity Looks like a minus value. Please find the screenshot Here.
Expected result: In the mini cart the quantity of the product should  be like :  Quantity:1

@jitendra-webkul
Now, this enhancement is done. so I am closing this enhancement.
And I have attached a screenshot Here, for future reference


Add support for backticks

Fixes #8

A few tests are failing, but I'm not sure how to get them to pass.  Perhaps someone with better RegExp skills can help out?

Sorry, I just don't have the time to dig into this. I really wish I did... Maybe someone from the https://github.com/eslint/eslint/issues/3090 could help.

Closing for lack of activity and ESLint chose to go with their own code.


Fix exception when mulitple folder levels have to be created

When anonymizing a folder structure such as:
a/b/c/1.png
a/b/c/2.png
a/b/d/1.png
into a folder a_anon so that the resulting structure looks like this:
a_anon/b/c/1.png
a_anon/b/c/2.png
a_anon/b/d/1.png
an exception about the folder a_anon/b/c not existing is thrown. This simple fix makes sure that all parent directories are created if necessary.

Thanks for the fix :)


Report table fixes

I already reviewed this one, no?

@dorsha not sure why other ones are not empty commits because they already exist in master. Last commit is new


Add sample parameter

It would be useful to allow for sample designation at runtime or through the config to selectively ignore samples in input directory

fixed by: 2cd71c98baf27e20f3c45dff69e4658ca9dd52f6


Send a notice to a room/all rooms when a bridge loses connection to discord

please make this configurable...
I'd rather not have my server send out 10k notices at once

Yes, I had that in mind :)

This would be extremely helpful to those of us that do not use discord at all and will always be left to wonder why nobody from the discord side ever replied to our messages. Perhaps with a note that all messages sent during this time will never reach the other side even after the connection is re-established (btw is there an issue for this? I couldn't find one).


After wiring up all the modules the system does not work

I wired up and flashed all the modules without any errors.
I installed the joystickcommander package and followed the steps with no errors.
When I run the ./joystickcommand, the command window initializes and when I press start button, the values of steering, brake and throttle are displayed and when the left stick is toggled, the steering value updates, but after a second, program closes by giving disable controls message and there is no change in the steering wheel position of the car even when the values are updated.
I built the can-gateway module by stacking 2 CAN shields and connecting one of them to Kvaser converter and then to laptop (Modified CS pin of one of the shields to pin 10 --> Connected to Kvaser converter, did not change the resistor)
Connected the steering module as given in GitHub.
Powered all the modules through the laptop itself.
Connected the joystick to the laptop.
Should there be a control can bus separately or can I just use the laptop as control can bus?
This is my current connection:
STEERING --> CAN GATEWAY --> OBD CAN
LAPTOP (CONTROL CAN) --> KVASER --> CAN GATEWAY
ALL MODULES POWERED THROUGH ARDUINO connected to LAPTOP
I don't have a physical control can bus. I am assuming my laptop will function as a control can bus.
No non-e power source.
Please let me know where I am wrong.

Please see answer here: https://github.com/PolySync/oscc/issues/201


regular CPU spike

Hi,
thanks a lot for the script. I use it :)
Buuut I noticed (and hunted down) regular CPU spikes caused by fseventd (and mdstore).
Turns out it was the "endless loop" in your script using tail on /dev/null that caused them.
I replaced the tail... and the wait $! with sleep 36500d and thats much better.
Granted: If I won't reboot my laptop in 100 years I have a problem. But I can live with that ;)
Voilà. I thought, maybe you wanna know :)
Thanks again anyways!!
PS: I picked the solution from here:
https://superuser.com/questions/681954/is-there-a-command-in-linux-which-waits-till-it-will-be-terminated
I was sure that sleep will be efficient.... maybe read is the same... did not try this one.

Hi @Tormen thanks for sharing the info and btw it's pretty strange the problem you had.

Hi @freedev , yeah I know. I used your tail based implementation because I thought it's save.
But I am 100% certain that the above was the cause and hte solution, as I had shutdown one by one all user programs, then all launchAgents and launchDaemons (from the user and finally form the system...) and in the end it was only this init script and little snitch daemon...
And it was really like clockwork: Every few seconds spike of fseventd (together with mdstore) because of the mdstore I had thought of Mail or spotlight or something...
But the moment I stoped the launchDaemon, bam the spikes stopped and vice-versa.
PS: For the record: I am using MacOS Catalina 10.15.4 (19E266).

Honestly I haven't the time to double check the problem in my env. And I still use the original version of the script every day. When you can, I'm just curios to see you your version.


Tons of warnings there, but these three are the straightforward ones. I can share the log (or you can run it yourself, -DCMAKE_CXX_CLANG_TIDY=clang-tidy-17 is the only CMake flag necessary), but, unfortunately, I won't have time to look into the remaining issues.


[Compute] az identity federated-credential: Add subgroup to support managing federated identity credentials of existing user assigned identities

Related command

create FIC:
az identity federated-credential create --name myFicName --identity-name myIdentityName --resource-group myResourceGroup --issuer myIssuer --subject mySubject --audiences myAudiences
update FIC:
az identity federated-credential update --name myFicName --identity-name myIdentityName --resource-group myResourceGroup --issuer myIssuer --subject mySubject --audiences myAudiences
read FIC:
az identity federated-credential show --name myFicName --identity-name myIdentityName --resource-group myResourceGroup
read all FICs associated with the user-assigned identity:
az identity federated-credential list --identity-name myIdentityName --resource-group myResourceGroup
delete FIC:
az identity federated-credential delete --name myFicName --identity-name myIdentityName --resource-group myResourceGroup
Description

In az identity group, add subgroup az identity federated-credential to support managing federated identity credentials of existing user assigned identities
Close #23152
Testing Guide

History Notes

[Compute] az identity federated-credential: Add subgroup to support managing federated identity credentials of existing user assigned identities

This checklist is used to make sure that common guidelines for a pull request are followed.

[x] The PR title and description has followed the guideline in Submitting Pull Requests.

[x] I adhere to the Command Guidelines.

[x] I adhere to the Error Handling Guidelines.

Compute


Replace all remaining manual Serialize implementations by derives

#68 did the bulk of this, replacing Serialize implementations in ruma_event!. There's still a few events declared without ruma_event! that implement Serialize manually though. These should also be updated to use #[derive(Deserialize)] + #[serde(rename = "…", tag = "type")].

Done in #72


[Fix] Localization in ExposureSubmission UI Tests

Description

This small PR fixes an issue that occurs when the UI tests are executed with other languages than German.
Checklist

[x] Test your changes as thoroughly as possible before you commit them. Preferably, automate your test by unit/integration tests.
[x] Set a speaking title. Format: {task_name} (closes #{issue_number}). For example: Use logger (closes # 41)
[x] Make sure that your PR is not introducing unnecessary reformatting (e.g., introduced by on-save hooks in your IDE)

Thanks for the change! Looks good.


input/output error on kernel 5.12

hey
just updated my manjaro kernel from 5.11 to 512 and noticed my ipman service has failed; checked and took input/output error on line 79 of the binary file on /usr/bin/ipman,
peace.

Fixed on linux 5.12.7


Does torchtune support multi-node training?

Does torchtune support multi-node training? For example, in a SLURM environment?
If so, would it be possible to get an example config?

Hi @tginart - at the moment, torchtune does not support multi-node training out-of-the-box. Up until now, we've made the conscious choice to focus on single node training as it's much easier to hack on single node rather than a multi node setup. That said, with the size of models increasing we are planning on adding multi-node in the coming months.
If you just want to get a very, very basic multi-node setup running, it actually shouldn't be too hard. We wrap around torchrun which supports multi-node and then you'd probably want to add something like tensor-parallel so that everything isn't abhorrently slow.
Just curious - what's your use case here? Large models, faster training, more data? Do you already have access to a multi-node setup running w/ SLURM? Or are you considering one?

Hi @joecummings
Current use-case is just faster fine-tuning over larger datasets.
I do have access to multi-node SLURM already, and have trained using other frameworks. For various reasons I've used torchtune recently for some small models on single node and was just wondering if it has multi-node.
What file should I take a look at?

Ah in that case, I'd recommend two things:

Instead of utilizing tune run, which we artificially constrain to 1 node for now, tune cp the recipe and config you want and then launch directly with torchrun. e.g. torchrun --nnodes 2 --nproc-per-node 8 full_finetune_distributed.py --config llama3_2/3B_full.yaml. This alone should enable you to run fine-tuning over larger datasets w/ FSDP (Just make sure you modify the sharding strategy to be HYBRID. You can do that by modifying the fsdp_kwargs here to include an item for "sharding_strategy": ShardingStrategy. HYBRID_SHARD.
Add a very basic tensor parallel configuration. Right now, we just use FSDP for distributed training which will likely be very slow on multinode b/c it will all-gather anything needed for backprop. Tensor parallel should actually achieve the speed up you need. TP is not quite as basic as step number 1. For simplicity sake, I'd recommend modifying our shard_model code to do something like the following pseudocode:

from torch.distributed.device_mesh import init_device_mesh
from torch.distributed.tensor.parallel import parallelize_module

def shard_model(...):
...
	mesh_2d = init_device_mesh("cuda", mesh_shape=(2, 8), mesh_dim_names=("dp", "tp"))

	# Parallelize input and output first
	parallelize_module(
		model,
		mesh_2d["tp"],
		{
			"token_embeddings": PARALLEL_STRATEGY,
			"output": PARALLEL_STRATEGY,
		}
	)

	# Iterate over layers and parallelize
	for layer in model.layers.items():
		layer_plan = {
			"attention.wq": PARALLEL_STRATEGY,
			"attention.wk": PARALLEL_STRATEGY,
			...
		}
		parallelize_module(model, mesh_2d["tp"], layer_plan)

	# Shard the model normally but using the mesh_2d["dp"] object

Torchtitan has a great example of this FSDP + TP work here.

I am using LSF to launch a torchrun --nnodes 2 --nproc-per-node 8 full_finetune_distributed.py full error trace attached full_trace.txt 8B_full_distributed.txt

Can you take a look at how TorchTitan launches multinode training? The key part I think that was missing in the above pseudo-code is that you need to specify a rendezvous backend. You can read more about that here

is it something that you guys are thinking to fix/implemenent?

I think this is what you suggested as first try, but still
full_trace.txt
torchrun  \
    --nproc_per_node \$GPU_PER_HOST \
    --nnodes \$NUM_HOSTS \
    --rdzv-backend c10d \
    --rdzv_endpoint \$MASTER_ADDR:\$MASTER_PORT \
    src/full_finetune_distributed.py --config \
    config_files/8B_full_distributed.yaml \
    optimizer_in_bwd=False

training.shard_model(
                model=model,
                shard_conditions=fsdp_shard_conditions,
                cpu_offload=fsdp_cpu_offload,
                reshard_after_forward=reshard_after_forward,
                sharding_strategy=ShardingStrategy.HYBRID_SHARD,
            )

modified shard_model
def shard_model(
    model: TransformerDecoder,
    shard_conditions: List[Callable[[str, nn.Module], bool]],
    *,
    cpu_offload: bool,
    reshard_after_forward: bool = True,
    sharding_strategy: ShardingStrategy = ShardingStrategy.FULL_SHARD,
) -> None:
    fsdp_kwargs = {
        "reshard_after_forward": reshard_after_forward,
        "sharding_strategy": sharding_strategy,
    }
    if cpu_offload:
        fsdp_kwargs["offload_policy"] = CPUOffloadPolicy()

    num_layers_sharded = 0
    for n, m in reversed(list(model.named_modules())):
        if any([shard_condition(n, m) for shard_condition in shard_conditions]):
            fully_shard(m, **fsdp_kwargs)
            num_layers_sharded += 1

    if num_layers_sharded == 0:
        raise ValueError(
            "No layer modules were sharded. Please check if shard conditions are working as expected."
        )

    fully_shard(model, **fsdp_kwargs)

in the end i am managed to get it to run with mpirun, but i get the follwoing error
[rank3]:   File "/software/isg/users/fg12/envs/virtualenvs/mlflow-torchtune-31tjdLhK-py3.11/lib/python3.11/site-packages/torch/distributed/_composable/contract.py", line 125, in wrapper
[rank3]:     updated = func(inp_module, *args, **kwargs)
[rank3]:               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[rank3]: TypeError: fully_shard() got an unexpected keyword argument 'sharding_strategy'

@fabiogeraci Ahh! I see in FSDP2, they remap HYBRID_SHARD to reshard_after_forward=True. Give that a go :)

would you mind to explain, please?

how would from 1D mesh to 2d mesh?

mesh_2d = init_device_mesh("cuda", mesh_shape=(2, 8), mesh_dim_names=("dp", "tp"))

This will create a 2 D mesh with 2 nodes and 8 GPUs per node.

Add a very basic tensor parallel configuration. Right now, we just use FSDP for distributed training which will likely be very slow on multinode b/c it will all-gather everything needed for backprop. Tensor parallel should actually achieve the speed up you need. TP is not quite as basic as step number 1. For simplicity sake, I'd recommend modifying our shard_model code to do something like the following pseudocode:

Hi Joe @joecummings, I was checking torchtitan for multi-node practice as you suggested. I found they seem to use a pure FSDP approach with a 64 GPU setting: here.
So I try to understand the bottleneck of FSDP under multi-node tuning. Is the all-gather happend every layer across all workers so may be bounded by communication? Is that a mistake that torchtitan use pure FSDP with 64 gpus? And I also wonder will tp contribute in this case if I am doing small models like llama7b.
Thanks!

mesh_2d = init_device_mesh("cuda", mesh_shape=(2, 8), mesh_dim_names=("dp", "tp"))

This will create a 2 D mesh with 2 nodes and 8 GPUs per node.

I implemented your suggestion, massive improvement in speed on multi nodes multi gpus set up via opemnmpi. I had to tweack shard_model.
May I ask why torchtune does not support multi node multi gpu, out of the box?

Hi Joe @joecummings, I was checking torchtitan for multi-node practice as you suggested. I found they seem to use a pure FSDP approach with a 64 GPU setting: here.
So I try to understand the bottleneck of FSDP under multi-node tuning. Is the all-gather happend every layer across all workers so may be bounded by communication? Is that a mistake that torchtitan use pure FSDP with 64 gpus? And I also wonder will tp contribute in this case if I am doing small models like llama7b.
Thanks!

Great questions! I'd really recommend reading through this issue on PyTorch where @awgu discusses why multi-node FSDP is usually slower than single node. The TL;DR is that communication can take longer between different nodes and since FSDP needs all-gather for parameters and reduce-scatter for gradient reduction, this can be a bottleneck in training.
It's probably not a mistake that torchtitan uses only FSDP for that specific config b/c it's the smallest model and my guess is that they're just trying to show that it's possible. If you look at the torchtitan configs for their larger models, you'll see that they use TP.
If you have good interconnect speed between nodes, FSDP will work faster. Regardless, TP + a "hybrid shard" will likely be faster than FSDP in a multi-node setup b/c it's not as communication bound.
Hope this explanation helps!

I implemented your suggestion, massive improvement in speed on multi nodes multi gpus set up via opemnmpi. I had to tweack shard_model.
May I ask why torchtune does not support multi node multi gpu, out of the box?

That's awesome! Would love to take a peak at your code if you want to post a gist so other users can see how you did it.
We actually do plan to support multi node OOTB sometime soon The biggest reason we haven't so far is just due to our own bandwidth constraints. We're a small-ish team and there's lots of new models and techniques coming out every day! We wanted to be sure that we provided a great single node experience before tackling multi node, but like I mentioned, we'll probably have a canonical example in torchtune soon.

openmpi script, launch cli
mpirun \
    -np $TOTAL_NUM_GPUS \
    -H \$MPI_HOST_STRING \
    -x PATH \
    -bind-to none \
    -map-by slot \
    --mca pml ob1 --mca btl ^openib \
    --display-allocation \
    --display-map \
    python3 src/full_finetune_distributed.py \
    --config config_files/8B_full_distributed.yaml \
    optimizer_in_bwd=False

full_finetune_distributed.py
if int(os.environ.get("NUM_NODES")) > 1:
            from torch.distributed._tensor import init_device_mesh
            mesh_2d = init_device_mesh("cuda",
                                       mesh_shape=(int(os.environ.get("NUM_NODES")),
                                                   int(os.environ['WORLD_SIZE']) // 2),
                                                   mesh_dim_names=("dp", "tp"))
        else:
            mesh_2d = None

        training.shard_model(
            model=model,
            shard_conditions=fsdp_shard_conditions,
            cpu_offload=fsdp_cpu_offload,
            reshard_after_forward=reshard_after_forward,
            mesh=mesh_2d,
        )

_distributed.py
def shard_model(
    model: TransformerDecoder,
    shard_conditions: List[Callable[[str, nn.Module], bool]],
    *,
    cpu_offload: bool,
    reshard_after_forward: bool = True,
    mesh: Optional[DeviceMesh] = None # <-- Add this line
) -> None:
if mesh is not None: # <-- Add this line
        fsdp_kwargs["mesh"] = mesh # <-- Add this line

would i be able to make PR with this code ;)


Inject config from properties file

This decouples the projects slightly and makes it possible to override settings on a per-project basis.
Also removes some config duplication between k9mail / k9mail-library.

Personally I don't know what advantages we get by having two projects, except for forcing isolation of form and function and (in general) reducing the need for an Android VM when testing core code.
I assume it's mainly forks that benefit from this sort of thing - not that many of them do much more than a re-skin anyway.

@philipwhiuk: @jberkel is using the k9mail library in SMS Backup+.

Forcing isolation and a clean separation of concerns is a huge win! Previously the network and UI code were completely mixed up, now they are loosely coupled with a clear direction of the  dependency from UI -> networking code.
With the current setup you can maintain and develop/iterate on these components in isolation. Thinking of it, there are probably a few more parts which could be separated from K9.
And as @cketti mentioned, I do use the K9 email code as a general purpose IMAP library in an application which is not an really an email client. Previously this was not possible because the code made lots of assumptions on how it was supposed to be used.


Packaging

Hey,
Added a few things:

images are written on disks only if there is a match, otherwise everything is done in memory
made it easily installable for pip
Factored a few things
added a few ideas to do in the readme

Peace,

Thank you. I will check it out as soon as possible


Update Dockerfile

Pre-req suggest java 1.8, but the Dockerfile contains a jre 11 causing an unsupported class version error. hence raising this PR
Exception in thread "main" java.lang.UnsupportedClassVersionError: io/opentelemetry/example/javagent/Application has been compiled by a more recent version of the Java Runtime (class file version 62.0), this version of the Java Runtime only recognizes class file versions up to 55.0

hi @vishnujanardhanan, thx for reporting this! I think a better fix may be to make sure that the example code targets Java-8 or Java-11, so that it can run in (at least one of) those two popular releases. I have sent an alternative PR #44


arm64 build failure: could not find system library 'openssl' required by the 'openssl-sys' crate

https://github.com/servicer-labs/servicer/actions/runs/6064765510/job/16453515976#step:4:724
A package update introduced a dependency on openssl-sys. This fails to build on the Github action for an arm64 release.
   Compiling openssl-sys v0.9.92
   Compiling futures-util v0.3.28
error: failed to run custom build command for `openssl-sys v0.9.92`

Caused by:
  process didn't exit successfully: `/target/release/build/openssl-sys-39820fd7b4b38d98/build-script-main` (exit status: 101)

--- stderr
  Package openssl was not found in the pkg-config search path.
  Perhaps you should add the directory containing `openssl.pc'
  to the PKG_CONFIG_PATH environment variable
  No package 'openssl' found

  --- stderr
  thread 'main' panicked at '

  Could not find directory of OpenSSL installation, and this `-sys` crate cannot
  proceed without this knowledge. If OpenSSL is installed and this crate had
  trouble finding it,  you can set the `OPENSSL_DIR` environment variable for the
  compilation process.

  Make sure you also have the development packages of openssl installed.
  For example, `libssl-dev` on Ubuntu or `openssl-devel` on Fedora.

  If you're in a situation where you think the directory *should* be found
  automatically, please open a bug at https://github.com/sfackler/rust-openssl
  and include information about your system as well as this message.

  $HOST = x86_64-unknown-linux-gnu
  $TARGET = aarch64-unknown-linux-gnu
  openssl-sys = 0.9.92

Fixed by uninstalling checker crate. This one was mistakenly installed.


Editor crashes when creating fetch connection query

Duplicates

[X] I have searched the existing issues

Latest version

[X] I have tested the latest version

Current behavior 😯
Editor crashes when creating a fetch connection query.
https://user-images.githubusercontent.com/10789765/191089930-d26cc8fb-37f4-44e5-a91e-ee62a85c628a.mov
Expected behavior 🤔
Editor should not crash when creating a fetch connection query.
Steps to reproduce 🕹
Steps:

Create new app
Create Fetch connection
Start creating query from connection
Application crashes

Context 🔦
No response
Your environment 🌎
No response

Duplicate to #1001

@apedroferreira Can you confirm this is a duplicate to https://github.com/mui/mui-toolpad/issues/1001? As far as I understand, in https://github.com/mui/mui-toolpad/issues/1001 the editor doesn't crash, it's just showing an error in the node.js console.

@apedroferreira Can you confirm this is a duplicate to #1001? As far as I understand, in #1001 the editor doesn't crash, it's just showing an error in the node.js console.

yep, seems to be caused by the same bug - same error message


Change private to protected

Questions
Answers

Description?
Since latest changes on the develop branch, https://github.com/PrestaShop/PrestaShop/pull/17215 the method is not compatible anymore.

Type?
bug fix

BC breaks?
no

Deprecations?
no

Fixed ticket?
Fixes https://github.com/PrestaShop/PrestaShop/issues/20372

No QA needed ? @PierreRambaud

No QA needed. If this breaks something we have SERIOUS problems

Thank you @PierreRambaud

This actually should be fixed in the core https://github.com/PrestaShop/PrestaShop/pull/20381
So this PR can be closed

Ah damn, already merged 😅 Doesn't matter..


[bazel] Unbreak building //sw/device/tests:all

:all is real notation: //foo/... is all subpackages, while //foo:all is all targets in that package. The former implies the latter. :)