load_template hook doesn't work for include/extends

Includes like this one always go to disk, without hitting the load_template plugin hook:
<footer class="ft">{% block footer %}{% include "_footer.html" %}{% endblock %}</footer>

To fix this I think I need to move the load_template implementation into a Jinja template loader.
I'm not sure I'll be able to keep the Templates considered comment working though:
https://github.com/simonw/datasette/blob/a2a709072059c6b3da365df9a332ca744c2079e9/datasette/app.py#L745-L750

It should be easy enough to show a comment that says which original template names were considered, but I may not be able to show which one was actually used (or which ones came from plugins).

Example from the Jinja docs: https://jinja.palletsprojects.com/en/2.11.x/api/#jinja2.BaseLoader
from jinja2 import BaseLoader, TemplateNotFound
from os.path import join, exists, getmtime

class MyLoader(BaseLoader):

    def __init__(self, path):
        self.path = path

    def get_source(self, environment, template):
        path = join(self.path, template)
        if not exists(path):
            raise TemplateNotFound(template)
        mtime = getmtime(path)
        with file(path) as f:
            source = f.read().decode('utf-8')
        return source, path, lambda: mtime == getmtime(path)

Also available: jinja2.FunctionLoader(load_func) which lets me pass it a function like this one:
>>> def load_template(name):
...     if name == 'index.html':
...         return '...'
...
>>> loader = FunctionLoader(load_template)

Just one catch: I need to be able to load templates asynchronously, because they live in the database. Let's hope Jinja has a mechanism for that!

It looks like Jinja does not have a mechanism for asynchronous template loading - the loader API is synchronous.
One option may be to figure out which templates are needed (including inherited templates and includes) before rendering the template. Then async load those templates from the database into a DictLoader, then pass that DictLoader to Jinja.

How can we tell what template Jinja will need to render?
One approach that could work:

Set up a dummy template loader which records the name of the template that was requested
Load the template
Now we know the list of templates that were requested. Async load those
The dummy template loader can now return the ones we have loaded. Load the template again.
Did it request any more templates? If so, load those, and repeat.
Keep on with this loop until a template load (which might even have to be a render) fails to request any templates that we have not yet loaded.
Render the template.

This is GROSS. It feels like a huge waste of CPU, and it could lead to very weird behaviour if any template variables have side effects.

Here's an alternative that would definitely work and would be a lot simpler, at the cost of a fair amount of RAM:

Before rendering the template, load ALL of the most-recent-versions of the templates that are stored in the DB. Use those to populate a DictLoader.
Render the template.

This does mean loading template bodies that we won't use. Provided an instance has less than 100 templates I imagine this will work just fine.

The ideal solution is for Jinja to offer async template loading. I'll file a feature request, then I'll implement the second option above (async load all templates from the DB before each render).

... no wait, my comments above assume that I'm just building the datasette-edit-templates plugin. Does this work as a general solution for all of Datasette? I don't think it does.
This may mean I need to delay the whole feature.

There's one other option: in datasette-edit-templates I could maybe use asyncio.get_event_loop().run_in_executor(...) to load the templates asynchronously within the Jinja template loader mechanism.

Filed a feature request here: https://github.com/pallets/jinja/issues/1304

I'm pretty sure that run_in_executor() workaround won't work. https://github.com/django/asgiref/blob/7becc9daca2628c46af1cb7e46b4c47c1ea27adf/asgiref/sync.py#L83 for example says "You cannot use AsyncToSync in the same thread as an async event loop".

Sadly I'm going to bump load_template from Datasette 0.51 - I don't think I should block the release on resolving this issue.

There might be a way to save this. Async template loading can't be supported, but what if you could define a load_template() hook which returned a sync function that returned templates...
Then the datasette-edit-templates plugin could reply to load_template by loading all DB templates into memory and returning a load_template sync function that looked up the values in those already-loaded templates.
It could even maintain an in-memory cache that gets updated when a template is edited.
If I do this, I could remove the ability to return an async function from load_template() but add that in the future should Jinja implement a mechanism for async template loading.

I'll try getting that to work. If I can't get it to work I'll drop the plugin hook for the moment.

I tried using a FunctionLoader and got this error on startup:
  File "/Users/simon/Dropbox/Development/datasette/datasette/app.py", line 989, in __init__
    for filepath in self.ds.jinja_env.list_templates()
  File "/Users/simon/.local/share/virtualenvs/datasette-edit-templates-agoZyE3x/lib/python3.8/site-packages/jinja2/environment.py", line 810, in list_templates
    names = self.loader.list_templates()
  File "/Users/simon/.local/share/virtualenvs/datasette-edit-templates-agoZyE3x/lib/python3.8/site-packages/jinja2/loaders.py", line 434, in list_templates
    found.update(loader.list_templates())
  File "/Users/simon/.local/share/virtualenvs/datasette-edit-templates-agoZyE3x/lib/python3.8/site-packages/jinja2/loaders.py", line 99, in list_templates
    raise TypeError("this loader cannot iterate over all templates")
TypeError: this loader cannot iterate over all templates

So if I'm going to define a custom Jinja loader I'll need to teach plugins to answer the "list templates" query.

Maybe I should ditch this hook entirely in favour of the existing prepare_jinja2_environment hook. Could that add new template loaders?

https://github.com/simonw/datasette/blob/a2a709072059c6b3da365df9a332ca744c2079e9/datasette/app.py#L310-L318
So yeah that plugin hook can probably modify the list of loaders available to the Environment.

Yeah I'm going to remove the load_template plugin hook and see if it's possible to build the edit templates extension against prepare_jinja2_environment instead.

Here's the proof of concept FunctionLoader that showed me that this wasn't going to work:
diff --git a/datasette/app.py b/datasette/app.py
index 4b28e71..b076be7 100644
--- a/datasette/app.py
+++ b/datasette/app.py
@@ -21,7 +21,7 @@ from pathlib import Path
 from markupsafe import Markup
 from itsdangerous import URLSafeSerializer
 import jinja2
-from jinja2 import ChoiceLoader, Environment, FileSystemLoader, PrefixLoader
+from jinja2 import ChoiceLoader, Environment, FileSystemLoader, FunctionLoader, PrefixLoader
 from jinja2.environment import Template
 from jinja2.exceptions import TemplateNotFound
 import uvicorn
@@ -300,6 +300,7 @@ class Datasette:
         template_paths.append(default_templates)
         template_loader = ChoiceLoader(
             [
+                FunctionLoader(self._load_template_from_plugins),
                 FileSystemLoader(template_paths),
                 # Support {% extends "default:table.html" %}:
                 PrefixLoader(
@@ -322,6 +323,17 @@ class Datasette:
         self._root_token = secrets.token_hex(32)
         self.client = DatasetteClient(self)

+    def _load_template_from_plugins(self, template):
+        # "If auto reloading is enabled it’s called to check if the template changed"
+        uptodatefunc = lambda: True
+        source = pm.hook.load_template(
+            template=template,
+            datasette=self,
+        )
+        if source is None:
+            return None
+        return source, template, uptodatefunc
+
     @property
     def urls(self):
         return Urls(self)
@@ -719,35 +731,7 @@ class Datasette:
         else:
             if isinstance(templates, str):
                 templates = [templates]
-
-            # Give plugins first chance at loading the template
-            break_outer = False
-            plugin_template_source = None
-            plugin_template_name = None
-            template_name = None
-            for template_name in templates:
-                if break_outer:
-                    break
-                plugin_template_source = pm.hook.load_template(
-                    template=template_name,
-                    request=request,
-                    datasette=self,
-                )
-                plugin_template_source = await await_me_maybe(plugin_template_source)
-                if plugin_template_source:
-                    break_outer = True
-                    plugin_template_name = template_name
-                    break
-            if plugin_template_source is not None:
-                template = self.jinja_env.from_string(plugin_template_source)
-            else:
-                template = self.jinja_env.select_template(templates)
-            for template_name in templates:
-                from_plugin = template_name == plugin_template_name
-                used = from_plugin or template_name == template.name
-                templates_considered.append(
-                    {"name": template_name, "used": used, "from_plugin": from_plugin}
-                )
+            template = self.jinja_env.select_template(templates)
         body_scripts = []
         # pylint: disable=no-member
         for extra_script in pm.hook.extra_body_script(
diff --git a/datasette/hookspecs.py b/datasette/hookspecs.py
index ca84b35..7804def 100644
--- a/datasette/hookspecs.py
+++ b/datasette/hookspecs.py
@@ -50,7 +50,7 @@ def extra_template_vars(

 @hookspec(firstresult=True)
-def load_template(template, request, datasette):
+def load_template(template, datasette):
     "Load the specified template, returning the template code as a string"

diff --git a/docs/plugin_hooks.rst b/docs/plugin_hooks.rst
index 3c57b6a..8f2704e 100644
--- a/docs/plugin_hooks.rst
+++ b/docs/plugin_hooks.rst
@@ -273,15 +273,12 @@ Example: `datasette-cluster-map <https://github.com/simonw/datasette-cluster-map

 .. _plugin_hook_load_template:

-load_template(template, request, datasette)
--------------------------------------------
+load_template(template, datasette)
+----------------------------------

 ``template`` - string
     The template that is being rendered, e.g. ``database.html``

-``request`` - object or None
-    The current HTTP :ref:`internals_request`. This can be ``None`` if the request object is not available.
-
 ``datasette`` - :ref:`internals_datasette`
     You can use this to access plugin configuration options via ``datasette.plugin_config(your_plugin_name)``

Here's the datasette-edit-templates plugin WIP I had before removing the hook: https://github.com/simonw/datasette-edit-templates/tree/82855c2612b84bc09c48fca885f831633a0d1552


tensorboard

hi, i did install tensorboard to monitor the progress. This seems to cause issues, when saving the checkpoint. It crashes at iteration 7000

Hello, it should be fixed now.


Login instructions

Add instructions / rules of the login. The users can only register with a Uniandes domain. No special characters in the name,

Added!


Lists don't work

I have some lists I made on my Twitter account. Whenever I try to run a get command in the tweets from members in a list I can't seem to get it to retweet those tweets.

I want to get this working so that I don't have to edit the code to edit the users I can just edit the list members from Twitter.com

The gist of the issue I'm actually having is that I do not know how to get the tweets out of the list. I know it's made an array of the tweets in the list and that's part of the data variable but beyond that I am not sure what is happening. In the original program, they got the tweet id from data.statuses[x].id_str but that does not apply to any of the list endpoints I have tried to use.
I'm currently looking at lists/:id/tweets to see how it returns the json and judging from the default response i think i need to change it to data[x].id
worth a shot

Looking at the lists/statuses endpoint. The response doesn't have a keyword at the top like data: or statuses:. I haven't been able to figure that out but I'm thinking that there is no keyword that it's a mistake. Because the other endpoint had data: at the top and data is the name of the data stream that gets returned I think the default syntax is data[x].id_str. Another assumption to test later.

Please see Issue #4 for more information about why lists don't work. This was never sending tweets in the first place.


Question about changelogithub dep

Hello!
Such a great project!
I have a question. Is changelogithub dep supposed to be a direct dependency for this lib?
Actual release had bloated my project deps a bit 😄
Thank you!

No, it shouldn't be 🤔

Hopefully, fixed in https://github.com/tinylibs/tinyspy/releases/tag/v1.0.2

Thank you, I'll close the issue


The scheme will help as you proceed

This is a developers scheme, it's helps guide through your studies about being a developer.

That's a wonderful and exceptional idea 💡

Spam


Confusing error message when specifying non-existent version

The following interaction is confusing:
$ rustup run 1.8 rustc test.rs
error: toolchain '1.8' is not installed
$ rustup install 1.8
error: toolchain '1.8' is not installed
$ rustup install 1.8.0
info: syncing channel updates for '1.8.0-x86_64-unknown-linux-gnu'

  1.8.0-x86_64-unknown-linux-gnu unchanged - rustc 1.8.0 (db2939409 2016-04-11)

The second error should say that 1.8 isn't even a thing, not that it's not installed. The first probably should as well. Bonus points for suggesting 1.8.0, especially if it's installed as is the case here.

Dupe of #301


Brainstorm dataset generation

Hi,
Thanks for your contribution to the sysnthetic data generation. I have investigated your released code. I have a question about the raw task definition for different dataset. Whether the template of raw task is the same for different dataset such as 'brainstorm' and 'rewrite'?
Look forward to your response. Thanks.
Best regards
Chunlin

Hello, the raw task in different datasets are different. However, the template is the same as below:
{
    "raw_task_name": "...",
     "task_name": "...",
     "config_filename": "...",
     "reason": "...",
     "children": [...]
}


win-1 is out disk space on C:\ drive, Quarantined: Not enough free disk space on c:. 2324.1mib < 7260.9mib.

Type of Request
bug
Infrastructure Environment
LUCI, Github, Cocoon scheduler, Autosubmit, etc...
What is happening?
win-1 is out disk space for temp, Quarantined: Not enough free disk space on c:. 2324.1mib < 7260.9mib.

Steps to reproduce
Step 1:
Step 2:
..
Step n:
Expected results
I expect to see X when Y is finished.

Removing some logs folders but still not enough, need to delete more to free disk space.

This ticket duplicate ticket with https://github.com/flutter/flutter/issues/144158.  I able removing some old apps on machine to free disk space on C:\ drive.


Makes driver loading more resilient

Prevents molecule execution failure when a driver fails to load. New code will display the loading failure but continue to load the other drivers.

@decentral1se Not at this moment. If it fails to load we will see. FYI I am planning to redo the driver loading as I discovered that current implementation can cause other failures but for the moment this should be a enough. The concept should remain the same: "failure to load a driver should be ignored, mainly because drivers are going to be external / outside our control" and we do not want to break the tool when one driver is broker, one that probably we do not even use.

@gabrielecerami In tests we can easily check that foo is in reported drivers. Current change is  minimal stuff that we can do to avoid case where user does "pip install molecule-my-broken-driver" and the entire tools becomes impossible to use. In fact this is what happened to me while writing a driver.

Where's the test for this :) ?

Yeah, good point. Let's get one of those. You can use the pytest caplog fixture to easily make sure that logging errors were outputted as expected.


Correct curator version in bom

fixes #162

Does this mean every time we change pom.xml like in https://github.com/palantir/spark/pull/131 we also need to change this BOM?
Sounds like we need a check that they're matching, or to source both versions from one list

This is a maven limitation that we're trying to workaround here. Don't
think there's a nice way or i don't know enough maven to know. This would
only be necessary for the versions that hadoop profile overrides but yes
they need to stay in sync.
On Tue, 18 Apr 2017, 20:58 Andrew Ash<EMAIL_ADDRESS>wrote:

Does this mean every time we change pom.xml like in #131
https://github.com/palantir/spark/pull/131 we also need to change this
BOM?
Sounds like we need a check that they're matching, or to source both
versions from one list
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/palantir/spark/pull/165#issuecomment-294961593, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAfQVI34b1yv5tA8rsQ5-Y1FmVl6gqqgks5rxRXggaJpZM4NArLD
.


dbt-run hook passes even though underlying SQL produces error

I created a model with bad SQL to test if dbt run would fail as expected. When running pre-commit hooks with a final hook of dbt-run, it passes even though the compiled SQL produces an error. With verbose: true, I see the following:
dbt parse................................................................Passed
dbt docs generate........................................................Passed
Replace script table names...............................................Passed
Remove script semicolon..................................................Passed
Check the script has not table name......................................Passed
Check the script has existing refs and sources...........................Passed
Check the script does not contain a semicolon............................Passed
dbt run..................................................................Passed
- hook id: dbt-run
- duration: 10.58s

Executing cmd: `dbt run -m commit_test_sql`
Sending project to dbt cloud
Created invocation id ee49e747-7205-46b8-8e3e-534fc59c990e
Waiting for response
Streaming invocation logs
21:53:08 Running dbt...
21:53:10 Found 264 models, 130 data tests, 978 sources, 9 metrics, 1122 macros, 1 semantic model
21:53:10
21:53:10 Found 264 models, 130 data tests, 978 sources, 9 metrics, 1122 macros, 1 semantic model
21:53:11 Concurrency: 4 threads (target='default')
21:53:11
21:53:11 1 of 1 START sql view model dbt_eschranz_base.commit_test_sql .................. [RUN]
21:53:12
21:53:12 Finished running 1 view model in 0 hours 0 minutes and 2.12 seconds (2.12s).
21:53:13
21:53:13 Completed with 1 error, 0 partial successs, and 0 warnings:
21:53:13
21:53:13
21:53:13 Done. PASS=0 WARN=0 ERROR=1 SKIP=0 TOTAL=1
Downloading artifacts
Invocation has finished

To Reproduce
Steps to reproduce the behavior:

Create .pre-commit-config.yaml

repos:
- repo: https://github.com/dbt-checkpoint/dbt-checkpoint
  rev: v2.0.4
  hooks:
  - id: dbt-run
    files: ^models/
    args: ["--cmd-flags", "++empty", "--"]
    verbose: true

Run pre-commit install in virtual env
Create model with bad SQL

select 1+'-1' as col

Commit code to branch

Expected behavior
pre-commit should fail if dbt run fails
Version:
dbt-checkpoint 2.0.4
dbt Cloud (versionless)
dbt CLI 0.38.15

Just testing this out...
When using dbt Cloud CLI (such as OP is using) - the exit code is 0.
$ dbt run

Created invocation id 148ecadc-ea61-454a-8242-ebc445acc353
07:20:57 Running dbt...
07:20:58 Unable to do partial parsing because a project config has changed
07:20:59 Found 1 model, 468 macros
07:20:59
07:20:59 Concurrency: 4 threads (target='default')
07:20:59
07:20:59 Found 1 model, 468 macros
07:21:00 1 of 1 START sql table model dbt_jyeo.foo ...................................... [RUN]
07:21:00 1 of 1 ERROR creating sql table model dbt_jyeo.foo ............................. [ERROR in 0.25s]
07:21:00
07:21:00 Finished running 1 table model in 0 hours 0 minutes and 1.29 seconds (1.29s).
07:21:00
07:21:00 Completed with 1 error, 0 partial successs, and 0 warnings:
07:21:00
07:21:00   Database Error in model foo (models/foo.sql)
  002003 (42S02): SQL compilation error:
  Object 'THIS_DOESNT_EXISTSSSSS' does not exist or not authorized.
  compiled code at target/run/my_dbt_project/models/foo.sql
07:21:00
07:21:00 Done. PASS=0 WARN=0 ERROR=1 SKIP=0 TOTAL=1

Invocation has finished

$ echo $?
0

But when using dbt-core CLI - the exit code is 1.
$ dbt run
07:19:14  Running with dbt=1.9.0-b4
07:19:15  Registered adapter: snowflake=1.9.0-b1
07:19:16  Found 1 model, 584 macros
07:19:16
07:19:16  Concurrency: 1 threads (target='sf')
07:19:16
07:19:19  1 of 1 START sql table model dbt_jyeo.foo ...................................... [RUN]
07:19:20  1 of 1 ERROR creating sql table model dbt_jyeo.foo ............................. [ERROR in 0.70s]
07:19:20
07:19:20  Finished running 1 table model in 0 hours 0 minutes and 4.14 seconds (4.14s).
07:19:20
07:19:20  Completed with 1 error, 0 partial successs, and 0 warnings:
07:19:20
07:19:20    Database Error in model foo (models/foo.sql)
  002003 (42S02): SQL compilation error:
  Object 'THIS_DOESNT_EXISTSSSSS' does not exist or not authorized.
  compiled code at target/run/my_dbt_project/models/foo.sql
07:19:20
07:19:20  Done. PASS=0 WARN=0 ERROR=1 SKIP=0 TOTAL=1

$ echo $?
1

I've also seen similar behavior for dbt-parse when a source isn't properly listed in sources.yaml

Yeah it's basically just dependent on the exit code of the dbt ... command.


Error: "This ist greater than your available balance"

I tried to send the maximum amount and got the error (see screenshot). Then I tried to send 200 MI and got the same error. Sending 100 MI worked.
I assume that this is due to the fact that the balance was on several addresses.

simmilar to #620

Ups

see #620


chore(release): v0.8.0 🎉

:robot: I have created a release *beep* *boop*
0.8.0 (2022-12-18)
Features

local: support executing local dynamodb instances w/ custom endpoint env var (32514a4)

Bug Fixes

cicd: upgrade cicd to support please release (15de39d)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/ehmpathy/simple-dynamodb-client/releases/tag/v0.8.0 :sunflower:


Handle ctrl+left click as right click on macos

Discussion started here: https://discord.com/channels/616186924390023171/1202575785614123049
Note that we should research first whether apps actually do that. I did not find an app yet that even has different behavior for left and right clicks so i'm basing this off of https://support.apple.com/en-us/guide/mac-help/mh35853/mac.
So please, if anybody knows about apps, please post them here, thanks. (The more "apple native" the better)

We can check for modifiers here https://github.com/tauri-apps/tray-icon/blob/13cabcd5184e7721c42c2c1262af5e0468146003/src/platform_impl/macos/mod.rs#L325-L329
and fire right click event instead of left.


Set auto_updates to true on some Casks

These are all the ones I have installed locally that are missing these flags (and I verified them all).

Thank you. On this list, only three are missing appcast: doxie, java, zoomus.
None of them seems to have a Sparkle appcast, though, so we’ll have to find out where their appcasts reside using other methods later.

None of them seems to have a Sparkle appcast, though, so we’ll have to find out where their appcasts reside using other methods later.

Yeh, none of them use Sparkle (as far as I can tell) but their own custom updaters.


virtcontainers: revert apply devices constraints

Due to issue https://github.com/kata-containers/runtime/issues/677
commit 137769a694136ef744fcb22ba389910fe1c1d951 must be reverted
This reverts commit 137769a694136ef744fcb22ba389910fe1c1d951.
fixes #685
Signed-off-by: Julio Montes<EMAIL_ADDRESS>

lgtm


GH-53 Naming

Resolves #53

A few things around frame start/end and drawing in general that are messy. TGA loading and buffer management is a bit bad, but it's easier to fix later after merging this refactor.


Remove StateUpdate in favor of CommitEffect

Issues:
Resolves #30
Description of changes:
As mentioned in #30 there are a bunch of downsides to the way that StateUpdate works currently. Upon further evaluation, the API of StateUpdate is not desirable to keep by simply merging it with ProvisionalState. It makes more sense to expose the raw ProposalInfo objects that were committed to (or not committed to) so that developers can use that metadata downstream. For example, if a commit has proposals from multiple authors, it is very helpful to know specifically where each proposal that was committed to originated.
We also had a pattern of having a StateUpdate with "active" set to true or false that was somewhat overloaded and did not make sense from an idiomatic Rust perspective. The boolean is now replaced by a CommitEffect enum at the top level to let the caller know that a commit resulted in the local client being removed from the group, the group being reinitialized, or a new epoch.
Call-outs:
This is a breaking change so versions were bumped up accordingly. I tried to adapt the uniffi wrappers the best that I could, but they are already lacking in details enough that it proved to be difficult. If we are really going to support uniffi long term in this main repo we should address missing APIs.
Testing:
All existing tests were adjusted, except for one that was removed due to it not really being necessary after the changes.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT license.

Codecov Report
Attention: Patch coverage is 75.45455% with 27 lines in your changes missing coverage. Please review.

Project coverage is 89.94%. Comparing base (834f4b4) to head (b1b932e).

Files
Patch %
Lines

mls-rs/src/group/message_processor.rs
59.25%
11 Missing :warning:

mls-rs/src/group/mod.rs
85.71%
7 Missing :warning:

mls-rs/src/group/state.rs
57.14%
6 Missing :warning:

mls-rs-uniffi/src/lib.rs
88.88%
2 Missing :warning:

mls-rs/src/client.rs
50.00%
1 Missing :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #175      +/-   ##
==========================================
+ Coverage   89.62%   89.94%   +0.32%
==========================================
  Files         175      175
  Lines       31599    31082     -517
==========================================
- Hits        28320    27957     -363
+ Misses       3279     3125     -154

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


4.0.110 checkout.js is not found

Description
Please provide a short description of the issue here, along with:

[X] A link to your page with the issue, if possible

Steps to reproduce
Install paypal-checkout using npm (latest 4.0.110 version)
It will try to fetch https://www.paypalobjects.com/api/checkout.4.0.110.js
But this link returns 404
Affected browsers

[X] Chrome
[X] Safari
[X] Firefox
[X] Edge

Thanks @MrBlaise, good catch. Seems like this file failed to upload to the CDN properly. I've kicked it off again, should be up very soon.

Thanks it loads correctly now! :)


Improve Settings pages UI

Description:
Improve Settings pages UI.
Type of change:

[ ] Bug fix
[ ] New feature
[X] Fix/new infrastructure

Background context of the changes:
Improve UI.
The ticket this PR closes:
Put a link to the ticket on Jira we're closing using this pull request.

Where should the reviewer start?
All four settings pages.
Insert screenshots / video of test results (for all relevant platforms)

Great job !!
Regardless of what I have already written:

Try to put the Title of each page, e.g. Location Settings, in the same horizontal line as the back button.
Take a look at what I did on the Create Notification page, I managed to put them in the same line.
Try to do that on each of the 3 pages.

In the labels above the entries, there is a little inconsistency in the naming. For example: Select destination and Enter Address. I think it would be better to use "title case" for each of the labels

Try to limit the size of the UPDATE LOCATION button because it spreads on the entire screen from left to right.

Other than that it looks very good.


TypeError: Brainly is not a constructor

TypeError: Brainly is not a constructor
    at Object.<anonymous> (C:\Users\Administrator\Documents\Github\ngentotwa\plugins\brainly.js:2:15)

2 in


Dock icon / mini-player only works on desktop workspace

If I'm in fullscreen on any of my apps (tested safari, airmail, and terminal) the icon highlights, but the mini-player doesn't open. If I go back to the desktop, the mini-player works great.

Fixed at last!


wikipedia corpus

Great job!
Could you share your Wikipedia corpus for retrieval?
I'm curious about the data amount and the method for calculating top-n recall metrics.

me too

Sure! The retrieval corpus (Wikipedia) can be downloaded using this command wget https://dl.fbaipublicfiles.com/dpr/wikipedia_split/psgs_w100.tsv.gz.
The dataset used in our work is also available here. The recall metrics measures the fraction of samples where the correct answer to the query is mentioned in the top-k retrieved documents.
Please let us know if you have any further questions!

Thanks a lot. Another point of interest is why different datasets use different retrieval methods. In my opinion, BM25 and DPR can represent sparse retrieval and dense retrieval, respectively. What is the purpose of using other retrieval methods, such as Contriever and DTR?

Thanks for bringing this up! We actually follow previous works to set up the retrieval process in each benchmark. For example, Self-RAG used Contriever for PopQA and TriviaQA, In-Context RALM used DPR for NQ, ALCE used GTR for ASQA, and FLARE used BM25 for 2WikiMultiHopQA. This provides diverse retrieval environments that help validate the flexibility and generalizability of our method.
Though our InstructRAG is agnostic to the choice of retrievers, I think it’s possible to further improve the RAG performance by enhancing the retrieval process with more advanced retrievers, which could help reduce noise in the retrieved documents.

Thanks for your reply. I have another question regarding vanilla SFT. When I try to reproduce the results of vanilla SFT on PopQA dataset, I get an accuracy of 44.3, which is significantly different from what was reported in the paper. Could you clarify if there are any specific settings related to vanilla SFT that I might be missing? Additionally, I noticed that if the answer appears in the LLM's reply, it is considered a positive result. However, it seems that if the LLM generates a longer response, it is more likely to achieve a higher score.

That’s a bit unusual, and I’d suggest checking if there’s any misalignment in your training or evaluation process. For your reference, the training details for vanilla SFT are provided in Appendix B, and we did not apply any specific tricks during its training. This training script is configured for training InstructRAG-FT but can be straightforwardly adapted for training vanilla SFT. The only caveat is to ensure that your environment aligns with the configurations specified in our repository, as differences in library versions (e.g., transformers, PyTorch) can lead to non-trivial discrepancies. If you still encounter difficulties reproducing vanilla SFT, feel free to reach out, and we’ll be happy to assist!
Yes, your understanding of the evaluation metrics is correct. We actually discussed these limitations in both Section 3.4 and Section 5. While such pattern-matching based metrics are standard for question-answering tasks, they rely solely on lexical similarity and fail to capture semantic meaning. Moreover, these metrics can suffer from the length bias, as longer responses tend to achieve higher accuracy. To address these shortcomings, we recommend validating the model using the LLM-as-a-judge evaluation over the pattern-matching based evaluation, which allows the judge to consider semantic equivalence and is expected to yield a more fair evaluation (see our Table 5).

Thank you for your prompt feedback. I followed the training details for vanilla SFT provided in Appendix B. However, I haven't found the construction process of the LLM's output. There are multiple answers provided for one question in the PopQA dataset. Therefore, I would like to know the output format of the training data.

I downloaded your model from Huggingface and ran eval.sh unchanged, only achieving an accuracy of 47.1%?

I downloaded your model from Huggingface and ran eval.sh unchanged, only achieving an accuracy of 47.1%?

@kfchenhn I just tested the model hosted on our HF repo, and it works well for me.

You can follow setup.sh to configure the environment. Feel free to let us know or open a new issue if you need further assistance!

I downloaded your model from Huggingface and ran eval.sh unchanged, only achieving an accuracy of 47.1%?

@kfchenhn I just tested the model hosted on our HF repo, and it works well for me.

You can follow [setup.sh](https://github.com/weizhepei/InstructRAG/blob/main/setup.sh) to configure the environment. Feel free to let us know or open a new issue if you need further assistance!

The code, model, and environment I used are exactly the same as those in your repo, but I still cannot achieve the same results as you. I suggest you check whether the online and offline content is consistent

Thanks for the suggestion. I’ve double checked both the online model weights and the offline copies, and they are indeed consistent. I guess this difference might be due to the discrepancy in our hardware configurations?


Create a set of 'Find element' examples

Cases:

complex css queries (find by attribute, css with escaped symbols, css with space)
complex queries with tables (iterate over rows, find row by table cell property, data aggregation from table cells)
xpath selectors

Closed in favor #4543


improve logs system

Title: [Persona name] should (not) be able to [action]
Currently:
[What happens now in the regression]
Expected:
[What the correct behavior should be]
STEPS TO REPRODUCE:
[If needed, add steps to reproduce]
REFERENCE:
[Link or attach screenshot(s) to story if relevant]
Possible fixes:
(If you can, link to the line of code that might be responsible for the problem)
Related issues
https://github.com/particle4dev/dicoapp-e/issues/69
Related Merge Requests

/label ~bug

this bug is resolved in this merge request. Closed!
https://github.com/KomodoPlatform/dicoapp-e/pull/30


1.15.2 Support?

Hello! Does the plugin run halfway ok on 1.15.2?
Is there already a release for the new version support planned? :)

https://github.com/Brettflan/WorldBorder/commit/4551e278c1e8462a8185c43fc9d926ba38de5cff


Clarify if IoT Hub supports X509 auth over WebSockets

I read in this article:

Web socket variants of AMQP and MQTT aren't supported with X.509 CA certificates in IoT Hub.

I've not been able to find this limitation in the product docs:
https://docs.microsoft.com/en-us/azure/iot-hub/iot-hub-mqtt-support
https://docs.microsoft.com/en-us/azure/iot-hub/iot-hub-amqp-support

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: c75be638-b3f3-b73d-fb10-34c91bb0edcd
Version Independent ID: e4225e21-3462-b35c-21b5-df43fd253b5d
Content: Attestation, authentication, provisioning - Azure Example Scenarios
Content Source: docs/example-scenario/iot/attestation-provisioning.yml
Service: architecture-center
Sub-service: example-scenario
GitHub Login: @wamachine
Microsoft Alias: pnp

Thanks for reporting - this issue is under review. This is a Microsoft Internal DevOps Bug ID # 502436

found it, X509 CA certs over HTTP is only available in Preview
https://docs.microsoft.com/en-us/azure/iot-hub/iot-hub-devguide-protocols

AMQP/MQTT/HTTPS over WebSockets is supported by IoT Hub for X.509 thumbprint authentication, but not GA for CA authentication. See: Azure IoT Hub communication protocols and ports | Microsoft Docs


Revert "Default itemType & currencyCode to empty string"

Reverts dooboolab/react-native-iap#74

do not pull request to master branch


Run jobs in parallel

Jobs which aren't scheduled to run after other jobs could be run in parallel to improve performance.
But... performance isn't really a problem right now, and it would make the logs pretty crazy. We'd probably need to split up logs to be in a different location per job.

Bumping priority since I'm working on #44.

Reverting this because of occasional DNS errors when running parallel jobs. It could be this issue: https://github.com/nodejs/node-v0.x-archive/issues/5545
Or it could be an OS or DNS server limitation.


Documentation is obsolete and not up-to-date.

Question
I'm experimenting with TestScheduler.  For example, if I browse to the bottom and look at "Extension Methods", when I click on Schedule(), that takes me to a 404. If I click on the Extensions class, it says it's part of a ReactiveTests namespace that doesn't seem to exist. I don't even see it in your source repo.
This is frustrating, and also means a lot of example code such as at http://introtorx.com doesn't work. I don't have time to dig through changesets and figure out if this existed at one time and was removed, if I'm barking up the wrong tree, etc.

I have a task in progress to improve/update the copy that was cloned to https://www.reactiveui.net/reactive-extensions: reactiveui/website#441.

Closing as a duplicate of https://github.com/dotnet/reactive/issues/836. Action items can be discussed over there, including possible community contributions.


feat: HTTP server for dead job management

Add dead job management handler with endpoints for dead job management:

/dead-jobs: JSON/HTML response with content negotiation. Response is paginated.
/resurrect-jobs: Move specified dead jobs to jobs_queue table.
/clear-jobs: Remove specified dead jobs from dead_jobs table.

Start a HTTP server on specified job manager port when worker is run.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

157 of 184 (85.33%)  changed or added relevant lines in 4 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.07%) to 87.691%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

internal/workermanager/worker_manager.go
14
16
87.5%

pkg/worker/pgq/pgq_utils.go
23
27
85.19%

pkg/worker/dead_jobs_handler.go
72
79
91.14%

pkg/worker/pgq/pgq_processor.go
48
62
77.42%

Totals

Change from base Build<PHONE_NUMBER>:
-0.07%

Covered Lines:
5956

Relevant Lines:
6792

💛  - Coveralls


Learning rate

Hi, thanks for this repo! I am trying to run the MLP in example code, and in MLP_METR-LA.py the optimizer is adam. However when I run it the learning rate seems to be reduced to a half after every few epochs. Could you please help me with that? Where can I customize my learning rate? Thanks very much!
example_training_log.txt

Thanks so much for the prompt response! You repo is extremely clear to use and your reply is also very helpful.


Mekanism Purification Chamber wiki/code issue

Hi,
in the wiki it says:
//InputStack, OutputStack
mods.mekanism.Purification.addRecipe(<minecraft:mossy_cobblestone>, <minecraft:cobblestone>);
//OutputStack
mods.mekanism.Purification.removeRecipe(<Mekanism:Clump:1>);```

However it's actually //InputStack, InputGas, OutputStack

Which doesn't really make sense because you can only pump oxygen into the machine anyways.

Example:

````mods.mekanism.Purification.addRecipe(<creepgamingmod:PoorOreIron>, <Mekanism:Clump:0>);````

throws an error

````mods.mekanism.Purification.addRecipe(<creepgamingmod:PoorOreIron>, <gas:oxygen>, <Mekanism:Clump:0>);````

works fine.

Someone without modding background would have probably thought the recipe is bugged and wouldn't have figured it out, it should be changed :)

The wiki is free to edit. :)

I have a github account not a wiki account. I'm not gonna edit there. Also mind explaining why you can specify a gas when it only accepts oxygen in the first place? @Yulife

A wiki account is easy to make. I can edit it now but for future reference please make an account there so you can easily edit it :) I don't know if it only accepts oxygen, is it hardcoded into Mekanism?

Yup, it's hardcoded in. See https://github.com/aidancbrady/Mekanism/blob/42ce42aee23f9c73f0bd06ba3175354142805d47/src/main/java/mekanism/common/recipe/machines/PurificationRecipe.java#L17

I did not only post it here because it's simply a wiki error, as I outlined in my first post, I don't think you can pump anything else into it, hence it would be easier to remove the gas input variable. Possibly the other processing machines are hardcoded too?


Some way of expanding displayed values of large lists and dictionaries

At the moment, the values of lists and dictionaries aren't shown directly, just text of the form "List of N items".
We can't always display the full JME representation, because it might fill the screen. Maybe a truncated string could be shown, and clicking on it would launch a pop-up with the full string.

Hello first time contributor here. Would it be okay if I can take a try at this?

@moisesjsanchez thanks for offering to help! Please have a look at our guide on contributing code to Numbas.
Let me know when you've got something I can look at, or if you need help.

Hi, could I help with this issue? I'm also a first-time contributor.

Hi could I also take a look at this? I'm a first-time contributor as well.


Consider revising Endpoint trait to be based on the request type

Currently, the structure of the Endpoint trait results in this function signature for requests in ruma-client:
/// Makes a request to a Matrix API endpoint.
pub(crate) fn request<E>(
    self,
    request: <E as Endpoint>::Request,
) -> impl Future<Item = E::Response, Error = Error>
where
    E: Endpoint;

This has to be called with a turbofish because E can't be inferred from the request type, because the compiler can't be sure that there is a unique mapping from each request type to one endpoint. (Multiple endpoints could have the same request type.)
If Endpoint were defined in terms of the request type's relationship to the metadata and response, there would be no need for a unit struct to implement Endpoint, inference would work, and the API would be a bit less verbose to use.
Before committing to this change, we should verify that it works for the server-side use case once ruma is using ruma-client-api.

Amusingly, I just noticed that withoutboats suggested this API 2 years ago: https://www.reddit.com/r/rust/comments/6amj9g/generic_implementation_of_a_trait_with_associated/dhfzy86/

Before committing to this change, we should verify that it works for the server-side use case once ruma is using ruma-client-api.

Changed my mind on this. I really don't see how having a useless endpoint struct with two associated types has any value over a request with an associated response.


Make use of user provided template for block rendering (fixes #149)

Q
A

Bug fix?
yes

New feature?
no

BC breaks?
no

Deprecations?
no

Related tickets
fixes #149

License
MIT

Thanks a lot!


Select all, add value defaults to cursor position 0

Mask: 1111
User selects all
User presses 3
Cursor position will be moved back to 0 instead of position 1.
Only tested in React at the moment, I'll have a look at this later if I get a second before I leave.

Removed react since it's an issue with the adjustCaretPosition call.
  it('places the caret in front of entered value when select all and replace happens', () => {
    expect(adjustCaretPosition({
      'previousConformedInput': '3333',
      'conformToMaskResults': {
        'output': '2___',
        'meta': {
          'input': '2',
          'mask': '1111',
          'guide': true
        }
      },
      'currentCaretPosition': 1
    })).to.equal(1)
  })

Test case for it.

I found a way to tweak the adjustCaretPosition algorithm to make it work for this. You can change this line to
if (isAddition || isPaste) {

And it'll fix this bug.
But, what if the user goes from 3333 to 23__. That is, they selected the first 3 digits and replaced them with 2? With the fix above, the caret would actually go to position 2, but we want it in position 1.
I'll see if I can come up with a fix this weekend.

This is definitely a difficult problem to solve. The main reason text-mask works well is because you rely on the onChange event only and not anything else. I assume a solution is possible with the current set of information provided, I'm just wondering if more information needs to be collected to make the cursor position stuff easier/simpler/etc?
However anything more may compromise the compatibility with mobile (especially Samsung phones, they are the god damn worst)


[hi] Update content/hi/docs/setup/production-environment/container-runtimes.md

Added  content/hi/docs/setup/production-environment/container-runtimes.md file
follow -up to #31987

/retitle [hi] Update content/hi/docs/setup/production-environment/container-runtimes.md

There is already a content/hi/docs/setup/production-environment/container-runtimes.md - did you want to open a PR to update the existing file @ashish-jaiswar ?

Yes @sftim, This PR resolves #31987
container-runtimes.md was merged with #31857 to dev-1.22-hi.1 without finalizing the content with a plan to cover remaining things in a further PR(s)

Hi @anubha-v-ardhan, I have rebased the PR but the bot still shows PR needs rebase. Can you suggest me how to rebase PR.

/retest

@ashish-jaiswar Looks like the rebase was unsuccessfull as ashish-jaiswar:dev-1.22-hi.1 is still 25 commits behind kubernetes:dev-1.22-hi.1.
Can you try rebasing again against kubernetes:dev-1.22-hi.1.
Feel free to take this conversation on Slack if you're facing any problems or have any confusions

Hi @anubha-v-ardhan  again I will open PR. I am closing this PR due to unwanted commits.

@ashish-jaiswar Any update on the new PR?

@anubha-v-ardhan I have created new PR. please review and approve the changes.

/remove-area blog release-eng
/remove-kind support
/remove-language de en es fr id it ja ko pl pt ru uk vi zh
/remove-sig release


Overrides URL for ResourceController client if provided

Like #95, this one is to properly use override URL for ResourceController, if provided. With this running locally, it is verified that the cluster would be able to provision worker VMs.

/label acknowledge-critical-fixes-only

/retitle OCPBUGS-47476: Overrides URL for ResourceController client if provided

/jira refresh

/lgtm

/hold
I think we should update minimal client as well right https://github.com/openshift/machine-api-provider-powervs/blob/main/pkg/client/powervs_client.go#L246-L248


CONTRIBUTING.md: change current OS X releases from current to example

This way we won’t have to keep changing the document every year.

Thank you for the contribution. It needed some fixes, so they were made in cafcd7cf7922022ea607c5811c63d45863c7ed36. Your contribution is still included (and still credited to you), with the appropriate modifications. Please feel free to ask about any of the changes.


undefined symbol: lua_pcall

Sytem: lsb_relealse -a   Ubuntu 14.01
lua -v  5.2.3
luarocks 2.2
Installed using luarocks, no error during compilation. Calling the script (example of TCP server) from documentation produce the following error error.
/home/user/torch/install/lib/lua/5.1/socket/core.so: undefined symbol: lua_pcall stack traceback:
[C]: in ?
[C]: in function 'require'
/home/user/torch/install/share/lua/5.1/socket.lua:12: in main chunk
[C]: in function 'require'
sertcp.lua:2: in main chunk
[C]: in ?

Thanks

lua -v 5.2.3
[...]
/home/user/torch/install/lib/lua/5.1/socket/core.so: [...]

The "5.1" in the path name indicates that luasocket has been compiled for Lua 5.1. So you can't use it with Lua 5.2.

Thanks. sifflejoe
From the torch interpreter
print(_VERSION)   Lua 5.1
From Lua native interpreter
print(_VERSION)  Lua 5.1
My quick solution was to use torch interpreter in order to run the socket script .
I guess the definitive solution is recompile torch with Lua 5.2. ??

I don't think that would work. Torch is built on LuaJIT.

Thanks Ignacio
I will keep the easy way (using th interpreter) :).
I guess we can close this issue, unless there are more suggestions.


Add support for Windows Subsystem for Linux

With the Windows 10 Creators Update, the Windows Subsystem for Linux now allows for Windows commands to be called from the Linux environment (https://blogs.msdn.microsoft.com/commandline/2017/04/11/windows-10-creators-update-whats-new-in-bashwsl-windows-console/).
This PR adds support for WSL by using the Windows logic and calling cmd.exe while in WSL, instead of xdg-open, which doesn't work. Cheers! 👋

I'm willing to add this if you open an issue on https://github.com/Microsoft/BashOnWindows about adding support for xdg-open, so it can eventually just work.

@sindresorhus I'm pretty sure that it's less an issue of WSL not supporting xdg-open, but that xdg-open doesn't support WSL. The xdg-open script mostly depends on using commands from the various desktop environments, which WSL wouldn't have. The generic opener in xdg-open is based on using Linux binary names (such as https://github.com/sindresorhus/opn/blob/master/xdg-open#L825 for browsers), so it wouldn't be able to launch a Windows program.
I think that delegating the launching the start command with cmd.exe via the interop makes more sense, since then it'll use the default programs that a user has registered in Windows, versus trying to guess the proper executable to use.

You're probably right about xdg-open. I guess I'm just tired of always having to be forced to add workarounds for Windows.

@sindresorhus Sorry for the delay; I've refactored the PR to use the is-wsl module now.


feat(plugins/gcpaudit): introduce optional UseAsync field in gcpaudit plugin

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind feature

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area plugins

What this PR does / why we need it:
Which issue(s) this PR fixes:

Fixes #
Special notes for your reviewer:

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: SKosier
Once this PR has been reviewed and has the lgtm label, please assign ahmedameenaim for approval. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

plugins/gcpaudit/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

LGTM label has been added.  Git tree hash: 28e6af086d30390bb647b91c18f6804970faa238

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: leogr, SKosier
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

plugins/gcpaudit/OWNERS [leogr]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


Add compose setting export

Codecov Report

Merging #31 into feature-settings will decrease coverage by 0.19%.
The diff coverage is 4%.

@@                 Coverage Diff                 @@
##           feature-settings      #31     +/-   ##
===================================================
- Coverage              43.1%   42.91%   -0.2%
===================================================
  Files                   402      402
  Lines                 27088    26901    -187
===================================================
- Hits                  11676    11544    -132
+ Misses                13605    13566     -39
+ Partials               1807     1791     -16

Impacted Files
Coverage Δ

compose/commands/exporter.go
2.1% <4%> (+0.11%)
:arrow_up:

compose/service/record.go
54.97% <0%> (-8.99%)
:arrow_down:

compose/service/notification.go
4.76% <0%> (-2.24%)
:arrow_down:

system/service/user.go
37.9% <0%> (-1.78%)
:arrow_down:

compose/service/system_user.go
13.63% <0%> (+2.52%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 919377e...6c346e9. Read the comment docs.


Compare Gatsby and GitHub heading ID generation

In many of our document files, we are using a table of contents pattern with links manually added to an "On this page" section that point to anchor tags we manually create and add inline to heading lines. Right now, this works as expected both on GitHub and in our Gatsby implementation. Users come to a table of contents, click a link, and the browser viewport moves to the target.
As an example, look at the chunk of the "Reusable services list" page to see how we are using this pattern for the "Messaging Common service" heading:
## On this page
- [Messaging Common service](#messaging-common-service)
- [Backup Container](#backup-container)
- [BC Address Geocoder](#bc-address-geocoder)
- [Common Document Generation service](#dgen)
- [Common Hosted Email service](#common-hosted-email-service)
- [Common Services Get Token](#common-services-get-token)
- [Fathom](#fathom)
- [go-crond](#go-crond)
- [Matomo OpenShift](#matomo-openshift)
- [OWASP ZAP Security Vulnerability Scanning](#owasp-zap)
- [SonarQube in Private Cloud PaaS](#sq-private-cloud)
- [SonarQube on OpenShift](#sq-openshift)
- [WeasyPrint HTML to PDF/PNG](#weasyprint)

## Messaging Common service
The Common Messaging service (CMSG) is an API for sending messages to internal and external users through SMTP and SMS. You can access the CMSG programmatically through the CMSG-MESSAGING-API. For more information, see the following resources:
* [GitHub repository](https://github.com/bcgov/nr-messaging-service-showcase)
* [About the Messaging Common Service](https://developer.gov.bc.ca/Community-Contributed-Content/About-the-Messaging-Common-Service)
* [Messaging Service Developer Guide](https://developer.gov.bc.ca/Community-Contributed-Content/Messaging-Service-Developer-Guide)

In the snippet above, you can see we are linking to #messaging-common-service and that we have created an anchor tag that the link is hypothetically pointing to:
However, both GitHub and our Gatsby implementation auto-generate IDs for headings. You can see this functionality by hovering over the headings in GitHub, causing a link icon to appear. You can use this to copy the link target, or click it to move the browser to that location and then copy the URL from the browser bar.

On GitHub, the extra  tags don't cause any extra cruft in the heading IDs, but Gatsby's remark processor parses these  tags into the generated IDs, causing weird output like below: #messaging-common-servicea-namemessaging-common-servicea

Since we are not gaining any functionality by adding these anchor tags manually, I am inclined to move away from using this pattern.
First, do some research and report back in this thread on any edge cases we might need to be aware of if we are going to be linking to auto-generated heading IDs from manually generated table of contents lists. For instance, do headings with special characters have rules that differ in GitHub and Gatsby? With a weird heading with special characters like "What is Keycloak @ BCGov !?", is the expected target the same in both GitHub and Gatsby?

Our Gatsby implementation is using the official Gatsby plugin gatsby-remark-autolink-headers to generate heading IDs in Markdown source documents. Under the hood, that plugin is using github-slugger, which aims to match the GitHub heading ID generation functionality 1:1.
I've tested a handful of cases to see how special characters are treated, and I can confirm Gatsby and GitHub are generating identical IDs in these cases:

!? How do we deal with speci@l c#aracters??? becomes #-how-do-we-deal-with-specil-caracters
Some under_scores and da-shes for no good reason? becomes #some-under_scores-and-da-shes-for-no-good-reason
Very special characters like á,é,í,ó,ú,Á,É,Í,Ó,Ú,Ñ,ñ becomes #very-special-characters-like-áéíóúáéíóúññ

As such, we have no reason to be adding anchor tags manually to headings in our documentation.
I'm going to do the following to resolve this issue:

[ ] Remove all existing manual  anchor tags in our Markdown documents, except in cases where they are being used for something other than a heading (I don't believe there are any edge cases like this, but I will take care to keep them in place if they are genuinely useful).
[ ] Updated the Tech Docs Writing Guide document to include guidance on this topic or change existing guidance.


⚠ Bofrost.it has degraded performance

In 7dff674, Bofrost.it (https://www.bofrost.it) experienced degraded performance:

HTTP code: 200
Response time: 3201 ms

Resolved: Bofrost.it performance has improved in 67f4aab after 8 minutes.


update preview after each event

Update the preview after each event, or event_page. This allows the live preview on bluesky-webclient to work.

Any ideas why the tests were failing?


About the version of ShapeNet

Hi!
For 3D  model, there is ShapeNetCore v1 , ShapeNetCore v2 and ShapeNetSem in the website of ShapeNet. I download the ShapeNetCore v2 for the 3D model. However, I find it may be different from the 3D model from your model(I compare the corresponding model.obj in https://github.com/nywang16/Pixel2Mesh/tree/master/data_generation and ShapeNetCore v2 ).
I wonder which version is your shapenet 3D model which matches with the rendering image in 3D-R2N2.
Can someone help me? Thanks very much!

Hi! We using ShapeNetCore v1 data.

Hi,
Do you know how to download the dataset and unzip it from the link below?
https://drive.google.com/open?id=131dH36qXCabym1JjSmEpSQZg4dmZVQid


Update README.md

Make the code more beginner friendly.

Codecov Report

Merging #77 into master will decrease coverage by 4.42%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master      #77      +/-   ##
==========================================
- Coverage   77.14%   72.72%   -4.43%
==========================================
  Files         293      293
  Lines       14862    14862
==========================================
- Hits        11465    10808     -657
- Misses       3397     4054     +657

Impacted Files
Coverage Δ

SpiceSharp/Attributes/ConnectedAttribute.cs
0% <0%> (-100%)
:arrow_down:

SpiceSharp/Attributes/VoltageDriverAttribute.cs
0% <0%> (-100%)
:arrow_down:

...nsient/IntegrationMethods/FixedEuler/FixedEuler.cs
0% <0%> (-100%)
:arrow_down:

...tegrationMethods/Spice/Gear/GearStateDerivative.cs
0% <0%> (-95.66%)
:arrow_down:

SpiceSharp/Circuits/Validator.cs
0% <0%> (-94.27%)
:arrow_down:

SpiceSharp/Components/Waveforms/Pwl.cs
0% <0%> (-90.59%)
:arrow_down:

...ionMethods/FixedEuler/FixedEulerStateDerivative.cs
0% <0%> (-82.36%)
:arrow_down:

...ns/Transient/IntegrationMethods/Spice/Gear/Gear.cs
0% <0%> (-79.6%)
:arrow_down:

SpiceSharp/Attributes/PinAttribute.cs
0% <0%> (-71.43%)
:arrow_down:

...p/Algebra/Solve/Markowitz/MarkowitzEntireMatrix.cs
29.23% <0%> (-58.47%)
:arrow_down:

... and 24 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8c0dd3a...b9f2f57. Read the comment docs.


Add webhook for slackbot notification of TravisCI jobs

changed as requested; ready to merge.

@csantanapr -- please merge.  encrypted URL to final version.


NoTileLeftBehind should return 404s

NoTileLeftBehind is intended to bypass caches. It does for local caches, but it inherits the default rendering behavior, which is to return a 200 HTTP response. This means that empty tiles (not intended to be cached) are treated as cacheable by downstream requestors.

Makes sense

I just realized a slight problem with this: NoTileLeftBehind includes a tile attribute which is intended to pass through whatever value is intended to be displayed.  This behavior is potentially useful (Proxy-provided tiles which have max-age=0 or no-cache Cache-Control headers).
After #236 (which was the fundamental problem I was trying to address with this), it may make sense to revert to the original behavior (return 200s) and add Cache-Control: no-cache to discourage downstream caches from treating it as a complete response.
In other words, bounds checks (hard errors) should be treated differently from intermittent errors (which may return content, even if it's not intended to last), the status quo prior to this PR.
Thoughts?

I think the answer for this one depends on what we decide to do in #236.

After letting this soak in for a while, I'm really of the opinion that this PR is wrong.  #238 reverts it, #239 adds Cache-Control: no-cache headers to match the intent of NoTileLeftBehind.
#236 can remain as a separate question.  I'm also hoping to submit some patches to the Proxy provider to respect the intent of upstream providers.


Add option to change main background color

In the app version, it'd be nice to change the background from purple to something else, even by e.g. adding a hex code to a config file

In the web version, it can be forced by injecting some simple css
body {
  background: #000c;
}

I will look into it. Maybe I will even add it to the settings menu on the app. Is there a specific color you would like?

Thanks.
At the moment I decided to use #000c which is a dark gray.
I use dark mode on the websites that support it. You could even add a simple dark mode toggle to the settings app.


Fixes timer example using timer_idx_t etc.

Not totally sure I completely understand hardware timers yet but with these changes it does compile and upload! Otherwise it complains about mismatched types int vs timer_idx_t etc.  😄

Disregard for now. I needed to make these changes when running the sample inside PlatformIO. Ran the code with plain esp-idf + make just now, and everything works as-is on master. Will continue to investigate thanks!


Fix All General & Admin Dashboard Bugs

Fix All General & Admin Dashboard Bugs
Make sure that everything matches the Figma

/cib all admin general bugs

Branch 190-all-admin-general-bugs created!


pub.dartlang.org OAuth actions should issue the correct error response

Currently the OAuth actions mostly return 403 errors. It should instead return 401 along with a "WWW-Authenticate" header, as per http://tools.ietf.org/html/draft-ietf-oauth-v2-bearer-22#section-3.

This issue has been moved to dart-lang/pub#248.


seems that deleted channels aren't deleted in channels.json

it seems that deleted channels aren't deleted in channels.json and appears again after container restart
(I hope I don't annoy you with all these issues)

nah it's just a good thing, if anything this is more annoying to you users lol


Remove version 2<IP_ADDRESS> of RemoteDesktopManagerFree

This PR removes version 2<IP_ADDRESS> of Remote Desktop Manager Free by Devolutions. RDM Free has been discontinued since October 2022, it should not be used anymore since it will require a free license which cannot be generated anymore. Please see the official blog regarding this: https://blog.devolutions.net/2022/10/news-remote-desktop-manager-is-changing-for-the-better/
Microsoft Reviewers: Open in CodeFlow

URL: https://cdn.devolutions.net/download/Setup.RemoteDesktopManagerFree.2<IP_ADDRESS>.msi
Status Code: 200
(Automated message - build 738)

Hi @rbstp,
This manifest has the highest version number for this package. Is it available from another location? (This might be in error if the version is switching from semantic to string, or string to semantic.)
(Automated response - build 740.)

URL: https://cdn.devolutions.net/download/Setup.RemoteDesktopManagerFree.2<IP_ADDRESS>.msi
Status Code: 200
(Automated message - build 743)

URL: https://cdn.devolutions.net/download/Setup.RemoteDesktopManagerFree.2<IP_ADDRESS>.msi
Status Code: 200
(Automated message - build 745)

This PR removes version 2<IP_ADDRESS> of Remote Desktop Manager Free by Devolutions. RDM Free has been discontinued since October 2022, it should not be used anymore since it will require a free license which cannot be generated anymore. Please see the official blog regarding this: https://blog.devolutions.net/2022/10/news-remote-desktop-manager-is-changing-for-the-better/

The blog post describes how the free and enterprise versions are reciving a unified installer, not that the product is being discontinued.

Remote Desktop Manager Free and Remote Desktop Manager Enterprise are now part of a SINGLE download instead of 2!

URL: https://cdn.devolutions.net/download/Setup.RemoteDesktopManagerFree.2<IP_ADDRESS>.msi
Status Code: 200
(Automated message - build 745)

The URL https://cdn.devolutions.net/download/Setup.RemoteDesktopManagerFree.2<IP_ADDRESS>.msi has been remove,  well as all other mentions of the RDMFree installer on our CDN.

URL: https://cdn.devolutions.net/download/Setup.RemoteDesktopManagerFree.2<IP_ADDRESS>.msi
Response status code does not indicate success: 404 (Not Found).
(Automated message - build 762)

URL: https://cdn.devolutions.net/download/Setup.RemoteDesktopManagerFree.2<IP_ADDRESS>.msi Response status code does not indicate success: 404 (Not Found).
(Automated message - build 762)

The URL was removed, so the installer is not accessible anymore. This PR is to remove the manifest for that version.

URL: https://cdn.devolutions.net/download/Setup.RemoteDesktopManagerFree.2<IP_ADDRESS>.msi Response status code does not indicate success: 404 (Not Found).
(Automated message - build 762)

The URL was removed, so the installer is not accessible anymore. This PR is to remove the manifest for that version.

Sorry for the delay - I had opened this and others a couple of hours ago, with the intent of approving, and had my automation run on them. Then a distraction occurred, and I'm just now back to this PR.

Hi @rbstp,
This manifest has the highest version number for this package. Is it available from another location? (This might be in error if the version is switching from semantic to string, or string to semantic.)
(Automated response - build 762.)


DiskInterface::Stat() needs to deal with inconvenient mtimes

DiskInterface::Stat() today returns the mtime of existing files, 0 for missing files, and -1 on error.
Unfortunately stat(2)'s mtime is a time_t which can legitimately be 0 or negative (on ubuntu, for example, it's a signed long) so DiskInterface::Stat() needs to either be respecified (to return missing/error info in a different param) or else needs to fudge its returned value to avoid having to rewrite callers.

Due to the work of letting failing stat() calls abort the build, it's now feasible to abort on mtimes <= 0. Maybe we should just do that.

@nico assuming your comment of 6min ago is a "yes" to my Aug 25, 2014 comment above, then SGTM.

I've been working on this nonstop for the last half year, these things take time! :-P

Enough people ended up needing support for inputs with mtime 0 that we added support for that in #1120


Signout from Fragment or non-activity class

Hi There,
I am trying to use this sign out method just to be able to add an OnCompleteListener to the sign out process But it asks for a FragmentActivity and i am calling it from inside a fragment (this fragment is called by an AppCompatAcivity).. Here is the code
 AuthUI.getInstance() .signOut(getActivity()) // this is the issue
                        .addOnCompleteListener(new OnCompleteListener<Void>() {
                            public void onComplete(@NonNull Task<Void> task) {
                                // user is now signed out

                            }
                        });

All what i need is one of the following:

How to pass the correct context knowing that i am calling this method inside a Fragment (this fragment is called by an AppCompatActivity)
is there any other method to have an OnCompleteListener to the sign out process from inside a fragment or a non-activity class ?

Thanks in advance

AppCompatActvity actually extends FragmentActivity so everything should compile just fine. Is something not working?

@samtstern @kidokimo This is fixed in FUI v3.1.1. Enjoy!


Audit and make documentation for command JSON.CLEAR consistent

The documentation of the command [JSON.CLEAR](https://dicedb.io/commands/jsonclear/) present in the docs could have become stale. We need your help to ensure that the documentation is complete, correct, and consistent.  Completing this issue will give you much-needed exposure to how the command is implemented and the different parameters it accepts. Hence, this is a great way to build a good understanding of the project and its functionality. While still making a significant contribution. Here's what you need to do:

Go through the documentation of the command and run all the examples, making sure they all work as expected
If the same command is present in Redis, then the expected output of the DiceDB command is the same as the Redis output
If the command is not in Redis, then as per your judgment, raise an issue with this template or fix the documentation and raise a pull request.
The documentation should contain the following sections in the following order

short and concise introduction paragraph about the command covering what it does
Syntax
Parameters: List all the parameters the command accepts, and ignore the section if there are no parameters
Return values: List all possible return values and under what condition
Behaviour: Describe the behavior of the command, what it does, how it does it, some internal specifics if any
Errors: List all possible errors the command can throw and under what condition
Examples: List all possible examples of the command and the expected output. Assume CLI implementation

Note: The title of the sections should be the exact strings mentioned above, like "Examples", "Return values", etc.
Note: The description of the command in Frontmatter of the command.md file is the first paragraph (introduction) of the command.
Go through the DiceDB/dice repository and explore the command implementation

to understand all possible return values
to understand all possible error values and conditions
to understand different parameters the command accepts

Please use the documentation of the SET command as the reference point and structure the
documentation of this command in a very similar way, including the following points

if you see any "Conclusion" section, remove it
the headers (h1, h2, h3) should be appropriately used
the CLI prompt should be <IP_ADDRESS>:7379> and not anything else
Use markdown tables for parameters and return values (ref SET command documentation)
wrap any command or paramter in backticks (`) to highlight them
the section header should be capitalize as used in the SET command documentation

If you find any inconsistencies, please fix the documentation and raise the PR.
The core idea of this exercise is to ensure that the documentation is consistent, correct, and complete.
Make sure you comment on the other issues you created (if any) as a comment on this issue and also any PR (if any) that you created.
Thank you for picking this up and contributing to the DiceDB. It means a ton.

can I pick this ?

Actually just pushed a PR for this one here:
https://github.com/DiceDB/dice/pull/887

@nm123github assigned, thanks for contributing.


Consistent naming of transaction_id

resolves #1531

Replaced occurrences of txid with transaction_id in the data models (this only occurred under the fulfills key of the inputs)

Updated schema validation
Updated database schema
Updated database queries

Replaced all occurrences of tx_id with transaction_id in the api documentation
Replaced all occurrences of tx_id with transaction_id in the http api arguments
Replaced all occurrences of tx_id with transaction_id in the events api and documentation
Fixed tests

Codecov Report

Merging #1532 into master will increase coverage by 0.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #1532      +/-   ##
==========================================
+ Coverage   98.39%   98.41%   +0.01%
==========================================
  Files          58       58
  Lines        2812     2784      -28
==========================================
- Hits         2767     2740      -27
+ Misses         45       44       -1

Fixed the inputs section in the data models documentation.


Fix for the s-shaped 3d trajectory

Text from original issue in gitlab:
_

The 3-D curves returned by Planner::plan may return very tiny S-curves. This happens (as far as we remember) when the z-change between two steps is much (no idea how much) bigger than the xy-change. Those small s-curves lead to stuttering when executed by the trajectory follower (i.e. it drives forward, stops, drives backward, stops, drives forward again (to follow the S).
A fix exists but that fix just sets z=0 for all trajectory steps. This fix works because the trajectory follower (at the time of writing) ignores the z-axsis anyway.
This bug needs to be implemented and fixed :-)

_
As IS:

To Be:

Solution:
The spline points are offset by the posWorld and start then projected on the actual plane of the trav patch.

Going up an incline produces some discontinuities

The usage of correct state pose for the next curve solves the small curves going up the incline

On inclines the project along the plane normal results in a small offset to the goalPose. This needs to be checked next:

Intersecting a line through the trajectory point with the trav node plane solves the position offset issue


Let's see if we can re-enable s390x again

Previously it had issues downloading from hex.pm

Interestingly enough, re-enabling s390x now shows a discrepancy in the new fast_pbkdf2 module on s390x:
[2024-01-16T17:51:39.919Z]   module 'couch_passwords_tests'
[2024-01-16T17:51:39.919Z]     PBKDF2
[2024-01-16T17:51:39.919Z]       couch_passwords_tests:20: pbkdf2_test_ (Iterations: 1, length: 20)...*failed*
[2024-01-16T17:51:39.919Z] in function couch_passwords_tests:'-pbkdf2_test_/0-fun-1-'/0 (test/eunit/couch_passwords_tests.erl, line 22)
[2024-01-16T17:51:39.919Z] in call from eunit_test:run_testfun/1 (eunit_test.erl, line 71)
[2024-01-16T17:51:39.919Z] in call from eunit_proc:run_test/1 (eunit_proc.erl, line 531)
[2024-01-16T17:51:39.920Z] in call from eunit_proc:with_timeout/3 (eunit_proc.erl, line 356)
[2024-01-16T17:51:39.920Z] in call from eunit_proc:handle_test/2 (eunit_proc.erl, line 514)
[2024-01-16T17:51:39.920Z] in call from eunit_proc:tests_inorder/3 (eunit_proc.erl, line 456)
[2024-01-16T17:51:39.920Z] in call from eunit_proc:with_timeout/3 (eunit_proc.erl, line 346)
[2024-01-16T17:51:39.920Z] in call from eunit_proc:run_group/2 (eunit_proc.erl, line 570)
[2024-01-16T17:51:39.920Z] **error:{assertEqual,[{module,couch_passwords_tests},
[2024-01-16T17:51:39.920Z]               {line,22},
[2024-01-16T17:51:39.920Z]               {expression,"couch_passwords : pbkdf2 ( << \"password\" >> , << \"salt\" >> , 1 , 20 )"},
[2024-01-16T17:51:39.920Z]               {expected,<<"0c60c80f961f0e71f3a9b524af6012062fe037a6">>},
[2024-01-16T17:51:39.920Z]               {value,<<"f35fbe4aae65fbc6f43df01e6bb6c86f9f75db74">>}]}
[2024-01-16T17:51:39.920Z]   output:<<"">>
[2024-01-16T17:51:39.920Z]
[2024-01-16T17:51:39.920Z]       couch_passwords_tests:26: pbkdf2_test_ (Iterations: 2, length: 20)...*failed*

@nickva I will get someone from my team to look into it as well - tx!

Thank you, @rposts. It might endianness related.
Since last time we ran the CI worker we included this library: https://github.com/esl/fast_pbkdf2/blob/main/c_src/fast_pbkdf2.c I wonder if it just make an implicit assumption that it's handling little endian data always.

Could this and this be the reason?

That looks plausible, thanks for taking a look, @big-r81

@nickva The issue in fast_pbkdf2 is endianness related. With a few changes in it, couch_passwords_tests passed on an s390x system. I am working on adding the changes via PR to fast_pbkdf2. Thank you.

@nickva @big-r81 The issue with fast_pbkdf2 has been resolved via PR.
Wanted to know how those changes are picked up here? Is fast_pbkdf2 is updated on regular basis?

Hey @namrata-ibm, you update the files from upstream like here.

and we should wait until https://github.com/esl/fast_pbkdf2/pull/13 is merged.

Fast-PBKDF2 all merged and new release created: https://hex.pm/packages/fast_pbkdf2/1.0.6, thanks for the contributions :)

I noticed one successful run on s390x!

I'll restart it to see a get a few more successful run.

This looks good. Thanks @namrata-ibm and @NelsonVides for your support.

There were 4 successful CI runs in row, so it looks quite promising. I'll merge the PR.


Add CLI query to return Counterparty for a given client identifier

Using the gRPC query added in https://github.com/cosmos/ibc-go/issues/7116, add a CLI query that returns the Counterparty associated with a given client identifier.

@crodriguezvega I would like to work on it

@vishal-kanna Let's get the gRPC issue done first and then I can assign this one as well to you. :)


[Bug]: When the query result set is 0000-00-00 00:00:00, download the result set as 0001-01-01 00:00:00:00

ODC version
odc424
OB version

What happened?

What did you expect to happen?
Download result set is 0000-00-00 00:00:00
How can we reproduce it (as minimally and precisely as possible)?
DROP table t0;
create table t0(c0 datetime);
insert into t0 values(0);
select * from t0;
2. Download result set
Anything else we need to know?
No response
Cloud
No response

After https://github.com/oceanbase/odc/pull/2455 , user could control zeroDateBehavior himself~


[Fix object_detection_node.launch file]

Time estimate: 5 hours
Deadline:  22.jan
Description of task:
The launch file includes different transformations. This needs to be reduced to a single correct one

Closing, as all of the transforms will have to be changed on Beluga Mk2 V2.0.


UI consistency changes

fixes #111
@tarkah thanks for letting me contribute! Let me know if there's anything you'd like to see changed.

Thanks for this! It looks great. Do you mind adding an entry to the CHANGELOG before I merge this?

Should be good to go. Let me know if you'd like me to squash the commits into a single commit.

No worries, I squash before merging. Thanks for the contribution!


chore: add get_packaget_dir macro

Stack:

#2395
#2394 ⬅

⚠ Part of a stack created by spr. Do not merge manually using the UI - doing so may have unexpected results.

This change is

✓ Commit merged in pull request #2395


one should be able to add skills without adding proficiency . It consumes lot more space with proficiency levels.

Is your feature request related to a problem? Please describe.

Describe the solution you'd like

Describe alternatives you've considered

Additional context

@sagarrastogi29  You should be able to add a skill without having to provide the Level or Proficiency just fine, when you drag the slider down to Disable. Does this not work for you? A screenshot of your current setup would really help me zero in on the issue.

It Works . Thanks for the resolution
On Wed, Nov 23, 2022 at 5:08 PM Amruth Pillai @.***>
wrote:

@sagarrastogi29 https://github.com/sagarrastogi29 You should be able to
add a skill without having to provide the Level or Proficiency just fine,
when you drag the slider down to Disable. Does this not work for you? A
screenshot of your current setup would really help me zero in on the issue.
[image: Screenshot 2022-11-23 at 12 36 49 PM]
https://user-images.githubusercontent.com/1134738/203537253-557862f7-87f3-412c-adff-0709f4b1721e.png
—
Reply to this email directly, view it on GitHub
https://github.com/AmruthPillai/Reactive-Resume/issues/1088#issuecomment-1324922187,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/A4IDJP47QYI3JHDOHIA3Z5LWJX62FANCNFSM6AAAAAASEC644M
.
You are receiving this because you were mentioned.Message ID:
@.***>

--
Best Regards,
Sagar Rastogi
Contact: +91<PHONE_NUMBER>
https://api.whatsapp.com/send?phone=918791569539&text=Hey Sagar!
https://www.linkedin.com/in/sagar-sap-cpi/


Exported XAML with Card Control from Figma, breaking in UWP

Current behavior
Application crashes on startup on UWP head.
Expected behavior
Load the Card Control in UWP Window.
How to reproduce it (as minimally and precisely as possible)
Created a empty project with Material and Uno.Toolkit.
Opened the UNO Template in Figma and created a blank page. Dragged a Card Control onto it.
Exported the XAML and copied it into my project in VS.

Environment

Nuget Package:
Package Version(s):
Affected platform(s):

Windows

Visual Studio:
2022 Preview
FinChoice.Mobi.zip

Related backport PR for stable 1.1 : https://github.com/unoplatform/Uno.Themes/pull/696


modeladmin: Breadcrumbs visual bugs

Issue Summary
In modeladmin's inspect views, the breadcrumbs are not aligned correctly (relative to the ones in the page explorer).
On desktop:

On mobile:

Steps to Reproduce

Create a model
Create the corresponding ModelAdmin register it.
Set inspect_view_enabled to True on that ModelAdmin
Navigate to the ModelAdmin index page.
Click Inspect on one of the instances.

I have confirmed that this issue can be reproduced as described on a fresh Wagtail project: yes

Technical details

Python version: 3.9.1
Django version: 3.1.7
Wagtail version: 2.12.3
Browser version: chrome 89

This was fixed with the new sidebar rework in 3.0 but in 4.0 these breadcrumbs will be removed.


chore(options): add new options.

Signed-off-by: Bo-Yi Wu<EMAIL_ADDRESS>

Codecov Report

Merging #7 (a90081c) into main (7cb6615) will decrease coverage by 2.18%.
The diff coverage is 93.93%.

@@            Coverage Diff             @@
##             main       #7      +/-   ##
==========================================
- Coverage   85.24%   83.06%   -2.19%
==========================================
  Files           1        2       +1
  Lines         122      124       +2
==========================================
- Hits          104      103       -1
- Misses         12       14       +2
- Partials        6        7       +1

Impacted Files
Coverage Δ

options.go
87.50% <87.50%> (ø)

nsq.go
82.40% <100.00%> (-2.84%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7cb6615...a90081c. Read the comment docs.


Added channel update events

Pull Request Etiquette

[x] I have checked the PRs for upcoming features/bug fixes.
[x] I have read the code of conduct.

Changes

[x] Internal code
[ ] Library interface (affecting end-user code)
[ ] Documentation
[ ] Other: _____

Closes : NaN
Description
Also added a grade check which checks if the event class is a data class or an open class and if it is not it will throw an error

Codecov Report
Base: 3.77% // Head: 3.67% // Decreases project coverage by -0.09% :warning:

Coverage data is based on head (28a394a) compared to base (3d37452).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##             master     #50      +/-   ##
===========================================
- Coverage      3.77%   3.67%   -0.10%
  Complexity       39      39
===========================================
  Files           240     247       +7
  Lines          4004    4109     +105
  Branches        423     430       +7
===========================================
  Hits            151     151
- Misses         3829    3934     +105
  Partials         24      24

Impacted Files
Coverage Δ

.../github/ydwk/ydwk/entities/channel/GuildChannel.kt
0.00% <ø> (ø)

...ydwk/entities/channel/guild/GenericGuildChannel.kt
0.00% <ø> (ø)

...ities/channel/guild/message/GuildMessageChannel.kt
0.00% <0.00%> (ø)

...main/kotlin/io/github/ydwk/ydwk/evm/event/Event.kt
100.00% <ø> (ø)

...ydwk/ydwk/evm/event/events/ban/GuildBanAddEvent.kt
0.00% <0.00%> (ø)

...dwk/evm/event/events/channel/ChannelCreateEvent.kt
0.00% <0.00%> (ø)

...dwk/evm/event/events/channel/ChannelDeleteEvent.kt
0.00% <0.00%> (ø)

...ageChannelDefaultAutoArchiveDurationUpdateEvent.kt
0.00% <0.00%> (ø)

.../message/MessageChannelLastMessageIdUpdateEvent.kt
0.00% <0.00%> (ø)

...ssage/MessageChannelLastPinTimestampUpdateEvent.kt
0.00% <0.00%> (ø)

... and 31 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Keyboard toolbar in the terminal

Hey,
I’ve noticed that when editing a file , there is a toolbar with arrow keys and other buttons. However, this disappears when typing into the terminal. I think it’ll be useful to have a similar toolbar with keys that are not available on the on-screen keyboard. Up and down arrows are particularly useful when going through previous terminal commands. A control key will also be useful to evoke various commands in combination with letter keys.

Thank you for your suggestion. I will implement this in a future update.

This feature is now available.


Test for mungegithub.

Another test for mungegithub.

Added the cla:human-approved label which should prevent the bot spamming.

testing cla-status.

I signed it!

Closing this PR as mungegithub bot for this repo is working (see #19).


vue-cli-plugin-electron-builder

Hey there! I'm trying to use some Node.js modules in a Web Worker in an Electron app written in Vue. The problem is when I want to import or require those Node.js modules (including things like serialport and stuff) I get an error and I can't use any of them. I've read it here and there and I know it is something known, but I can't really figure out what's going on cause I have very little experience with both Electron and Webpack. By the way, any help will be really appreciated!
Used Vue plugin Github page: https://github.com/nklayman/vue-cli-plugin-electron-builder
Link to another issue trying to explain this: #75

Hi - Electron doesn't expose Node modules in Workers. There's nothing a plugin or build tool can do to address this, it's a limitation of Electron itself.

Per the electron docs, https://www.electronjs.org/docs/tutorial/multithreading#multi-threaded-nodejs, node is actually available in workers with the nodeIntegrationInWorker flag set true. I'm running into similar issues as @MehrdadKhnzd . Maybe we can re-open?

I'm experiencing the same issue, but I'm unsure if this is a problem with the vue-cli-plugin-electron-builder package, or this one.
Even with the nodeIntegrationInWorker flag enabled, this plugin seems to ignore it.
The whole discussion about worker_threads is completely irrelevant to WebWorkers imho.

@MehrdadKhnzd - Here is a very nasty hack to make it work in Electron (since the native require method is always available when nodeIntegrationInWorker is enabled):
        const r = global['req' + 'uire'];

        const fs   = r('fs'),
              path = r('path');

// You can now use fs.existsSync() inside the worker.
console.log(fs.existsSync('hello-world.txt'));

The whole point of this 'hack' is to trick Webpack into thinking you're not actually using the require function, so it'll stay away trying to 'transpile' your code.... Its disguisting to use, but at least it works...for now.

Thanks for the hack, @haroldiedema.
This issue should be re-opened for sure, but the above does work.


Serialise np.ndarrays.

These are fairly common and they end up in DataFrames when reading
arrays from parquet files through pd.read_parquet (among other
things).
Merge after https://github.com/widgetti/ipyaggrid/pull/25

@maartenbreddels , I fixed the merge conflict if you can have a look.

Could this be merged please?

I wonder if we should consider binary serialization btw?
Is aggrid good at showing large amounts of data?

I wonder if we should consider binary serialization btw?

I'm happy to look into this in a separate PR. I was looking into the benefits of using a binary serialisation protocol in general for communicating data between the front-end and the back-end to speed up initialisation of the grid but I think that would be significant shift that is not needed for my current user case.
If you're talking about binary serialisation just for the case of numpy arrays, I wouldn't be too pressed for the time being as I don't necessarily expect them to be much larger than my normal array columns and we don't use binary serialisation for those either.

Is aggrid good at showing large amounts of data?

It's certainly good at handling DataFrames with many rows (maybe hundreds of thousands) from my experience. I have not tried it with extremely long columns though. I can try that if you like.

we could also explore using arrow format, which is supported on the frontend as well.
But it's a larger endeavor, lets merge this first.


Add CONTRIBUTING.md

CONTRIBUTING.md is a must read file for a new contributor in any repository before starting to work.

Add general good practices while starting to work with this specific project.
Add standard Github workflow commands in the CONTRIBUTING.md (opening issues, get assigned, fork, create clone, add, commit, creating PRs).
It will provide new potential project contributors with a short guide to how they can help with your project.

Kindly assign me this issue under hacktoberfest. I would like to work on it.🚀

Added.


procps doesn't work with CentOS 5

The apply_sysctl function isn't defined in /etc/rc.d/init.d/functions for CentOS 5

fixed in #26


Complex_layout_scroll_perf__timeline_summary worst_frame_build_time_millis regressed

20ms -> 56ms after https://github.com/flutter/flutter/commit/8e2ca93f52d82d22df8b987cef74238ac53b4b28
Similar regressions for complex_layout_semantics_perf initialSemanticsTreeCreation

@goderbauer : any idea on what's causing the regression?

The problem is those benchmarks are skewed by whether a major GC occurs before or after the benchmark starts timing. With the removed code, it is more likely a GC will occur after the benchmark starts. The simplest fix is to force a GC before starting each of these benchmarks.

What @jacob314 said is probably the issue. If it is blocking anything feel free to revert the PR. As soon as I can I will try to force a GC with the mechanism provided by https://github.com/dart-lang/sdk/issues/34618 before those benchmarks to see if that fixes things.

Forcing a GC is blocked on me not understanding how I am supposed to call it: https://github.com/goderbauer/flutter/commit/ee2afb2c5a343384b9eb12d3f32701a7842f6f5a

I still think this is a wrong way to fix this benchmark. Users are not going to have GC invoked before benchmark run - so the number you are measuring is too idealized and does not reflect real world performance. You will see 20ms in the testing environment, but users might see 56ms.
Imagine you have a function f() and you want to have how fast it works. An important thing to realize  here is that if f() performs any sort of allocation then f()'s performance is not a single number but a distribution of possible outcomes - depending on the state of the memory management infrastructure (e.g. amount of live data in the heap).
I have been thinking about this benchmark and I came to realize that because it is based on the timeline recording you actually know exactly how many GCs were triggered and what type they were. I think the right approach for this benchmark is to simply report measurements with GC time excluded - this would be pure best case performance. You can also report time with GC included - that would give you some sort of "worst case" approximation. The real performance would be somewhere in between.

Naively subtracting GC time from the event time is giving me negative numbers (code is in https://github.com/goderbauer/flutter/commit/7dedfcf32517def7e066d9251cb31e672305e359):
{
  "success": true,
  "data": {
    "initialSemanticsTreeCreation": 98,
    "initialSemanticsTreeCreationExcludingGc": -89,
    "gc": 187
  },
  "benchmarkScoreKeys": [
    "initialSemanticsTreeCreation"
  ]
}

@mraleph Which GC events do I need to subtract to make this correct?

@goderbauer you need to exclude those GC events that are nested within "initialSemanticsTreeCreation" time line event.

I'm not sure I agree that removing the GC times is the right approach. The problem isn't the GCs per se, the problem is that the GC environment is variable at the start of this benchmark, such that sometimes we're almost due for a GC, and sometimes we're not, unrelated to things this benchmark does. I think triggering a GC immediately prior is exactly the right solution to that problem.
I definitely don't want to just exclude GC times from the benchmark.

For the record: https://github.com/flutter/flutter/pull/23289 implements the approach were we force a GC before two of the benchmarks that are known to be GC sensitive.


Users can query for files in a project

Need
As a user of the query service, I want to an easy way to tell which files belong to which projects.
Approach

[ ] Create a projects_files join table
[ ] update the ETL job

Duplicate ticket.


MAX4 and Magyar Mozi TV in musor.tv

Hi @freearhey ,
I hope it's enough.
Thanks

Thanks @freearhey @BellezaEmporium,
I can ask when it is expected that the XMLs will be downloadable again?


Not working with large-v3

Hi, If I try to use large-v3 whisper model (which seems better than v2) it will always throw an error no matter what song I choose.
[UltraSinger] Mute audio parts with no singing Traceback (most recent call last):   File "C:\Programas\UltraSinger\src\UltraSinger.py", line 708, in <module>     main(sys.argv[1:])   File "C:\Programas\UltraSinger\src\UltraSinger.py", line 579, in main     run()   File "C:\Programas\UltraSinger\src\UltraSinger.py", line 150, in run     TranscribeAudio(process_data)   File "C:\Programas\UltraSinger\src\UltraSinger.py", line 356, in TranscribeAudio     transcription_result = transcribe_audio(process_data.process_data_paths.cache_folder_path,   File "C:\Programas\UltraSinger\src\UltraSinger.py", line 475, in transcribe_audio     transcription_config = f"{settings.transcriber}_{settings.whisper_model.value}_{settings.pytorch_device}_{whisper_align_model_string}_{settings.whisper_batch_size}_{settings.whisper_compute_type}_{settings.language}" AttributeError: 'str' object has no attribute 'value'
Arguments:
UltraSinger.py -i <link> -o C:\Downloads\ --whisper large-v3 --disable_karaoke True

Can you provide the whole output?

Hi, If I try to use large-v3 whisper model (which seems better than v2) it will always throw an error no matter what song I choose.
[UltraSinger] Mute audio parts with no singing Traceback (most recent call last): File "C:\Programas\UltraSinger\src\UltraSinger.py", line 708, in <module> main(sys.argv[1:]) File "C:\Programas\UltraSinger\src\UltraSinger.py", line 579, in main run() File "C:\Programas\UltraSinger\src\UltraSinger.py", line 150, in run TranscribeAudio(process_data) File "C:\Programas\UltraSinger\src\UltraSinger.py", line 356, in TranscribeAudio transcription_result = transcribe_audio(process_data.process_data_paths.cache_folder_path, File "C:\Programas\UltraSinger\src\UltraSinger.py", line 475, in transcribe_audio transcription_config = f"{settings.transcriber}_{settings.whisper_model.value}_{settings.pytorch_device}_{whisper_align_model_string}_{settings.whisper_batch_size}_{settings.whisper_compute_type}_{settings.language}" AttributeError: 'str' object has no attribute 'value'
Arguments:
UltraSinger.py -i <link> -o C:\Downloads\ --whisper large-v3 --disable_karaoke True

Can you provide the entire output? Or the song link?

Pull request #200 will fix the issue, please take a look if you'd like to fix before commit. It's just adding one line, and changing one value

@rakuri255 Alternatively, Pull request #196 also addresses this. I have created a separate PR just in case you wanted to go for a quick fix. Might be in some others as well. One of the OQL was to check against the class to see if the model is a valid one and prompt the user if it was not in the class. Within that code, the setting is set as WhisperModel(arg).

Sorry for the bug. We need a unit test to make sure it doesn't break again.
I tested v3 at release and it is partly better but mostly much worse than v2. There was also a discussion online somewhere where it was said that it is not usable for vocals.
But I'm looking forward to your test results!


RHEL 8.2: image build test failure

While working on osbuild/osbuild-composer#535, I ran into an error on RHEL 8.2 with image tests.

Jenkins link (click on the log artifacts)

When the tests try to run on RHEL 8.2, the following shows up in stderr:
Machine and scope registration turned off, --slice= and --property= settings will have no effect.
Machine and scope registration turned off, --slice= and --property= settings will have no effect.
execv(/run/osbuild/lib/runners/org.osbuild.fedora31) failed: No such file or directory

You only see this on RHEL8.2 but not on any other machine?

This is really weird, I tried to build an rpm from the current master and run the manifest[1] from fedora_31-x86_64-ext4_filesystem-boot test case. It builds the build pipeline and then it fails with the execv error, see the log[2]. Then, I tried to build the samples/base.json and it worked.
I tried to substitute the runner for ls to see what's inside that container and I got:
Directory /run/osbuild/osbuild-buildroot-mna97kdu doesn't look like it has an OS tree. Refusing.

The /run/osbuild/osbuild-buildroot didn't contain anything apart from /var. I investigated why the buildroot failed to mount /var and I found that the reader is just an empty directory.
So far I have tried only rhel8.2.
[1]: manifest
[2]: log

I've just reproduce it with samples/base-qcow2.json.

We have the cause! When osbuild rpm is built on rhel, it does this thing:
mangling shebang in /usr/lib/osbuild/runners/org.osbuild.fedora30 from /usr/bin/python3 to #!/usr/libexec/platform-python

It's fine in the build pipeline because we use rhel buildroot for it and that has /usr/libexec/platform-python. However, in the second pipeline, it isn't fine because fedora doesn't have the platform-python binary.

We have the cause!

Thanks! That made it much easier for me to find :) PR is attached.