WinAppDriver is unable to work with windows opened other than main application window

Hello guys.
My application opens different windows on clicking some button controls.Now  WAD is able to work on application window which opens up after starting my application's .exe file but as soon as I click on button control to open another window of same application,WAD is not able to identify that window.This happens even when any Warning/Error alert gets opened up.
Why WAD is not able to identify newly opened application window/alert window though these windows opens up in same process's hierarchy path of which I have specified in app desired capability.
My process ID remains same even after opening these windows.
Can you guys help me out in resolving this?
Thanks and regards,
Pranoday

Hi @Pranodayd,
You can enumerate all top level windows belonging to an active Windows Application Driver session through the WindowHandles attribute as shown in the example below:
https://github.com/Microsoft/WinAppDriver/blob/v1.0/Tests/WebDriverAPI/Window.cs#L120
Once you enumerate them, you can switch the active session to any of it and interact with one of them at a time.
If you don't see the newly opened window you mentioned above in the enumerated top level windows, it may not have the same process id with your active session. The best way to verify this is to use inspect tool to identify the process id of the current active window and the newly created ones. You can also dump the page source of the currently active window through the session PageSource attribute as shown in the example below:
https://github.com/Microsoft/WinAppDriver/blob/v1.0/Tests/WebDriverAPI/Source.cs#L39

Another way is to take the desktop session object and find your target windows, but this is time consuming!

how we can get the desktop session? thanks in advance

how we can get the desktop session?

Hi @gclouds and @samkhayal,
Please find the information on how to get the desktop session below:
https://github.com/microsoft/WinAppDriver/wiki/Frequently-Asked-Questions/a8c02cfac47b4bf0c12c571b6010c403dcfe5e7f#when-and-how-to-create-a-desktop-session
DesiredCapabilities appCapabilities = new DesiredCapabilities();
appCapabilities.SetCapability("app", "Root");
DesktopSession = new WindowsDriver<WindowsElement>(new Uri("http://<IP_ADDRESS>:4723"), appCapabilities);

Feel free to provide a feedback/issue on how we can make the information organized better.

Can you use Window Handles to navigate from a desktop app to an internet explorer window after clicking a link in the desktop app?

desktop session object and find your target windows
Hello Pankaj -- Can you explain how can i find the target window using desktop session object. My application after login closes and opens a new window. In appium i can see replacing session id...

Just reached same problem, it was bloody appium server that I moved to other desktop that was main issue. Took my 2 hours to figure it out why it stopped working suddenly. I guess it's time to start using WindowsHandles..

thank you

thank you


[azservicebus] Receiver indefinitely "stuck" after a long idle period

Bug Report
After a long period of inactivity, a receiver will stop receiving new messages. A "long period" is sometime more than 8 hours and less than 13 days, but exactly how long is unknown.
(The problem was originally brought up in this comment)
This is very straightforward to demonstrate if you are willing to wait and setup a dedicated service bus instance.  It occurs frequently with infrastructure used for QA, since that will often not receive any activity over weekends and holidays.
SDK Versions Used
I have seen this behavior across many versions of the azure-sdk-for-go, but the most recent test was conducted using these versions:
github.com/Azure/azure-sdk-for-go/sdk/azcore v1.1.0
github.com/Azure/azure-sdk-for-go/sdk/azidentity v1.1.0
github.com/Azure/azure-sdk-for-go/sdk/messaging/azservicebus v1.0.1

About the most recent time this was reproduced
We most recently reproduced this by running a small golang app in an AKS cluster using a managed identity assigned by aad-pod-identity.
In this test, we setup a dedicated azure service bus + managed identity (terraform below) and let the app run. After 13 days, we came back to it . No errors had been emitted, just the regular startup message for the app. I then entered a message into the bus. The receiver in the app did not pickup the message after waiting 30 minutes. We deleted the pod running the app and allowed it to be recreated by the deployment. The replacement pod immediately picked up the message.
Workaround
We can work around this issue by polling for messages using a 10 minute timeout and restarting in a loop. Our workaround looks like this and is known to work for weeks without an issue.
rcvrCtxForSdkWorkaround, canceller := context.WithTimeout(ctx, 10*time.Minute)
messages, err := azsbReceiver.ReceiveMessages(rcvrCtxForSdkWorkaround, 1, nil)
canceller()
if err != nil && !errors.Is(err, context.DeadlineExceeded) {
	r.logger.Info(EvtNameErrRetrievingMsgs, map[string]string{
		"error": err.Error(),
	})
	continue
}
// This just means that the context was closed before any messages
// were picked up. This could have been the context (master or)
// rcvrCtxForSdkWorkaround, so a loop is required.
if len(messages) == 0 {
	continue
}

The terraform for the test bus
The terraform below was used to setup the test bus and assign the app identity access to it.
resource "azurerm_servicebus_namespace" "ns" {
  name                = "fixturens${local.deploy_token}"
  location            = local.location
  resource_group_name = data.azurerm_resource_group.rg.name
  sku                 = "Standard"
  tags                = local.standard_tags
}

resource "azurerm_servicebus_queue" "test" {
  name                                 = "test"
  namespace_id                         = azurerm_servicebus_namespace.ns.id
  dead_lettering_on_message_expiration = false
  enable_partitioning                  = false
  default_message_ttl                  = "PT48H"
}

resource "azurerm_role_assignment" "full_access_ra" {
  for_each     = local.authorized_authorized_principal_ids_as_map
  scope        = azurerm_servicebus_queue.test.id
  principal_id = each.value
  role_definition_name = "Azure Service Bus Data Owner"
}

Hi @tkent, thank you for filing this issue. I know it's frustrating to deal with a bug, so I appreciate you working with me on this.
We have tests for these kinds of scenarios but clearly, since you're seeing a bug, I'm missing something. I'll see what I'm mising there.

@richardpark-msft  - Hey, I appreciate you looking into it. Frustrating, yes, but it would be much more frustrating if we didn't have a work around or we filed an issue that gets dismissed/ignored.
Priority wise, since we have a work around it's not high on our list. That said, I'd imagine others don't want to have to go through the learning process on this one.

Hey @tkent , I added in a client-side idle timer that does something similar to what you outlined above. It recycles the link if nothing is received for 5 minutes, under the covers.  It was released in azservicebus 1.1.2
Closing this now as we've formally implemented something similar to your workaround :).
This should help combat a situation I've been worried about for a bit. If the server idles out our link or detaches it and we miss it then our link will still look alive during these quiet times, even if it's never going to work. We now close out the link and attempt to recreate it, which will force a reconciling between the service and client.

Reopening as there's still work for this.

Hello @tkent 🙂
Are you still using the same workaround?
Have you perhaps tried the same solution but with a shorter timeout duration? If yes, have you noticed any differences?

@rokf , are you seeing this issue as well?

👋  @rokf - I am still using this work around. The workaround has been stable for the past several months, so we haven't touched it. I picked 10 minutes arbitrarily and we've not tried a lower time (though I'm sure that would work).
However... @richardpark-msft it's important to note that just last Wednesday (01/18), we might have experienced the issue in our prod environment. We had a situation where we again we stopped receiving messages and had no errors emitted from the SDK. This time, unlike others, our Azure Service Bus UserError metric started climbing, indicating some interaction with the bus. Restarting the app caused messages to start being picked up again.
We're adding more debugging to try to figure out what on earth happened, but that may have been this same problem showing up after 6+ months with the work around. The lack of visibility into the problem makes it very hard to tell.

@tkent Thank you 👍
@richardpark-msft yes, it seems so. We've had similar problems in the past with the previous SDK (messages not being read). Things were looking good for a while with the new SDK (this one) since we've migrated. Last week something started happening (see graphs below).
The version that we're using is:
github.com/Azure/azure-sdk-for-go/sdk/messaging/azservicebus v1.1.3

Restarting indeed works - the messages get picked up immediately.

We're planning to set up alerts on the production Service Bus namespaces to catch messages that are stuck and we'll try to put additional logs into the client for the time being.
We're also looking into the possibility to introduce some kind of periodic queue connection health checks.

@tkent are you perhaps recreating the receiver (https://pkg.go.dev/github.com/Azure/azure-sdk-for-go/sdk/messaging/azservicebus#Client.NewReceiverForQueue) and/or client (https://pkg.go.dev/github.com/Azure/azure-sdk-for-go/sdk/messaging/azservicebus#NewClient) before every https://pkg.go.dev/github.com/Azure/azure-sdk-for-go/sdk/messaging/azservicebus#Receiver.ReceiveMessages call?

@rokf  - We are not, we keep the same receiver for the lifetime of the application execution.
It may be helpful to know that the service using this workaround doesn't processing many messages yet. In our highest volume environment, a given instance will receive less than 500 messages a day and our peak messages per second is like 2-3. We wouldn't have seen any intermitted issues that come up during even moderate load yet.

We are also experiencing same problems since the 14.1.2023. This can be seen in the graph below which shows active connections. The spikes back up indicate that we have restarted containers.
Must also mention that our traffic isn't really high and most of the times the receivers are idling.

@richardpark-msft Do you perhaps have some more info on this?

@alesbrelih, can you generate a log for your failures? I'm working on a few fixes - the first one that should come out in the next release will introduce a timeout when we close links, which can hang indefinitely in some situations.
https://github.com/Azure/azure-sdk-for-go/blob/main/sdk/messaging/azservicebus/README.md#troubleshooting

@richardpark-msft
I've checked logs and here are the results.
Stuck consumer:
[azsb.Receiver] Received 0/10 messages
[azsb.Conn] No close needed for cancellation
[azsb.Receiver] Received 0/10 messages
[azsb.Conn] No close needed for cancellation
[azsb.Receiver] [Rx9Ea3fu0qH3bAwVzdWlwRSw462mfoUI60nRTVwpZ6Vrn4-ArS-3qw] Message releaser starting...
[azsb.Receiver] [Rx9Ea3fu0qH3bAwVzdWlwRSw462mfoUI60nRTVwpZ6Vrn4-ArS-3qw] Message releaser pausing. Released 0 messages
[azsb.Receiver] Received 0/10 messages
[azsb.Receiver] [_-ywyRZ5M9boovToMfH9g27-frlI2dzeBlDIWwk0FrYUDpdune7AeA] Message releaser starting...
[azsb.Receiver] Asking for 10 credits
[azsb.Receiver] [_-ywyRZ5M9boovToMfH9g27-frlI2dzeBlDIWwk0FrYUDpdune7AeA] Message releaser pausing. Released 0 messages
[azsb.Receiver] No additional credits needed, still have 10 credits active
[azsb.Receiver] Received 0/10 messages
[azsb.Receiver] Asking for 10 credits
[azsb.Receiver] No additional credits needed, still have 10 credits active
[azsb.Conn] No close needed for cancellation
[azsb.Conn] No close needed for cancellation
[azsb.Receiver] [VJvcP9DFGERBZZBaxEMs_9z-fQ4A4XwF7oyhc5KThd1z6niYMPsALA] Message releaser starting...
[azsb.Receiver] [VJvcP9DFGERBZZBaxEMs_9z-fQ4A4XwF7oyhc5KThd1z6niYMPsALA] Message releaser pausing. Released 0 messages
[azsb.Receiver] Asking for 10 credits
[azsb.Receiver] [nZybya7rmta1Tc7-S2a8JyRHknmi9PjJpwKqjhGqfeKmQd60HJvYsg] Message releaser starting...
[azsb.Receiver] No additional credits needed, still have 10 credits active
[azsb.Receiver] [nZybya7rmta1Tc7-S2a8JyRHknmi9PjJpwKqjhGqfeKmQd60HJvYsg] Message releaser pausing. Released 0 messages
[azsb.Receiver] Asking for 10 credits
[azsb.Receiver] No additional credits needed, still have 10 credits active
[azsb.Receiver] Received 0/10 messages
[azsb.Conn] No close needed for cancellation
[azsb.Receiver] Received 0/10 messages
[azsb.Receiver] Received 0/10 messages
[azsb.Conn] No close needed for cancellation
[azsb.Receiver] Received 0/10 messages
[azsb.Conn] No close needed for cancellation
[azsb.Receiver] [_-ywyRZ5M9boovToMfH9g27-frlI2dzeBlDIWwk0FrYUDpdune7AeA] Message releaser starting...
[azsb.Receiver] [_-ywyRZ5M9boovToMfH9g27-frlI2dzeBlDIWwk0FrYUDpdune7AeA] Message releaser pausing. Released 0 messages
[azsb.Receiver] Asking for 10 credits
[azsb.Receiver] No additional credits needed, still have 10 credits active
[azsb.Receiver] [VJvcP9DFGERBZZBaxEMs_9z-fQ4A4XwF7oyhc5KThd1z6niYMPsALA] Message releaser starting...
[azsb.Receiver] [nZybya7rmta1Tc7-S2a8JyRHknmi9PjJpwKqjhGqfeKmQd60HJvYsg] Message releaser starting...
[azsb.Conn] No close needed for cancellation
[azsb.Receiver] [Rx9Ea3fu0qH3bAwVzdWlwRSw462mfoUI60nRTVwpZ6Vrn4-ArS-3qw] Message releaser starting...
[azsb.Receiver] [Rx9Ea3fu0qH3bAwVzdWlwRSw462mfoUI60nRTVwpZ6Vrn4-ArS-3qw] Message releaser pausing. Released 0 messages
[azsb.Receiver] [nZybya7rmta1Tc7-S2a8JyRHknmi9PjJpwKqjhGqfeKmQd60HJvYsg] Message releaser pausing. Released 0 messages
[azsb.Receiver] Asking for 10 credits
[azsb.Receiver] No additional credits needed, still have 10 credits active
[azsb.Receiver] [VJvcP9DFGERBZZBaxEMs_9z-fQ4A4XwF7oyhc5KThd1z6niYMPsALA] Message releaser pausing. Released 0 messages
[azsb.Receiver] Asking for 10 credits
[azsb.Receiver] Asking for 10 credits
[azsb.Receiver] No additional credits needed, still have 10 credits active
[azsb.Receiver] No additional credits needed, still have 10 credits active

If I compare logs of the broken consumer with a working one, I'm missing refreshing/negotiate claims [Auth] logs 🤔 The last time the Auth refresh happened it was 2 days ago, and since then there is no mention of it. Even though it says it will expire in 15 minutes.
It is also accompanied with context deadline exceeded logs that are not present before this:
2023-01-30T21:21:24.773171761Z [azsb.Auth] (mock-queue/$DeadLetterQueue/$management) refreshing claim
2023-01-30T21:21:24.773198251Z [azsb.Auth] (mock-queue/$DeadLetterQueue) refreshing claim
2023-01-30T21:21:24.773201858Z [azsb.Auth] (mock-queue/$DeadLetterQueue) negotiate claim, token expires on 2023-01-30T21:36:24Z
2023-01-30T21:21:24.773203671Z [azsb.Auth] (mock-queue/$DeadLetterQueue/$management) negotiate claim, token expires on 2023-01-30T21:36:24Z
2023-01-30T21:22:11.244252046Z [azsb.Auth] (mock-queue) negotiate claim, failed: context deadline exceeded
2023-01-30T21:22:11.244282373Z [azsb.Receiver] (receiveMessages.getlinks) Retry attempt 0 was cancelled, stopping: context deadline exceeded
2023-01-30T21:22:11.244288625Z [azsb.Auth] (mock-queue) refreshing claim
2023-01-30T21:22:11.244313101Z [azsb.Auth] (mock-queue) negotiate claim, token expires on 2023-01-30T21:37:11Z
2023-01-30T21:22:11.244317740Z [azsb.Auth] (mock-queue/$DeadLetterQueue) negotiate claim, failed: context deadline exceeded
2023-01-30T21:22:11.244321717Z [azsb.Receiver] (receiveMessages.getlinks) Retry attempt 0 was cancelled, stopping: context deadline exceeded
2023-01-30T21:22:11.244326336Z [azsb.Auth] (mock-queue) negotiate claim, failed: context deadline exceeded
2023-01-30T21:22:11.244329682Z [azsb.Auth] (mock-queue/$DeadLetterQueue) refreshing claim
2023-01-30T21:22:11.244332768Z [azsb.Auth] (mock-queue/$DeadLetterQueue) negotiate claim, token expires on 2023-01-30T21:37:11Z
2023-01-30T21:22:11.244344831Z [azsb.Auth] (mock-queue/$DeadLetterQueue) negotiate claim, failed: context deadline exceeded
2023-01-30T21:22:11.244346664Z [azsb.Receiver] (receiveMessages.getlinks) Retry attempt 0 was cancelled, stopping: context deadline exceeded
2023-01-30T21:22:11.244349379Z [azsb.Auth] (mock-queue/$DeadLetterQueue) refreshing claim
2023-01-30T21:22:11.244362454Z [azsb.Auth] (mock-queue/$DeadLetterQueue) negotiate claim, token expires on 2023-01-30T21:37:11Z
2023-01-30T21:22:11.244365319Z [azsb.Receiver] (receiveMessages.getlinks) Retry attempt 0 was cancelled, stopping: context deadline exceeded
2023-01-30T21:22:11.244367303Z [azsb.Auth] (mock-queue) refreshing claim
2023-01-30T21:22:11.244369016Z [azsb.Auth] (mock-queue) negotiate claim, token expires on 2023-01-30T21:37:11Z
2023-01-30T21:22:24.233462503Z [azsb.Receiver] Received 0/10 messages
2023-01-30T21:22:24.233494573Z [azsb.Conn] No close needed for cancellation
2023-01-30T21:22:24.233499503Z [azsb.Receiver] Received 0/10 messages
2023-01-30T21:22:24.233501857Z [azsb.Conn] No close needed for cancellation
2023-01-30T21:22:24.233503480Z [azsb.Receiver] Received 0/10 messages

If you need more data or something specific please let me know.

@richardpark-msft Hey Richard, we've noticed that a new version has been released - https://github.com/Azure/azure-sdk-for-go/tree/sdk/messaging/azservicebus/v1.2.0. Do you suggest that we switch to that version?

@richardpark-msft Richard Park (DEVDIV) FTE Hey Richard, we've noticed that a new version has been released - https://github.com/Azure/azure-sdk-for-go/tree/sdk/messaging/azservicebus/v1.2.0. Do you suggest that we switch to that version?

I always do, but I'm a bit biased. :) I'm still working on adding some resiliency to see if we can help more with a part of this situation. From what I can tell we're getting into a situation where the link hasn't re-issued credits (which tell Service Bus to send us more messages). I have a fix in the works for that, but I'm still going over ramifications for it.
The bug fix I added for this release was to make it so our internal Close() function would time out - prior to this it could actually hang for a long time and if it was cancelled it could leave things in an inconsistent state. This can affect things even if you aren't specifically calling Close() since we will close things internally during network recovery.
So yes, definitely recommend. There are some additional logging messages now that show if the code path is being triggered and is remediating the issue (note, these are always subject to change in the future):
Connection reset for recovery instead of link. Link closing has timed out.
Connection closed instead. Link closing has timed out.

If your client was stuck or seems to disappear during the recovery process this could be the root cause.

We are still having issues with this.
Is this something that is still being worked on?

There's been several fixes in this area, can you give me more details @alesbrelih?
Specifically, there have also been some changes on the service-side, and we have been working on the go-amqp stack as well to improve reliability.
I'd need internal logs from your situation as well. See here on how to enable them:
https://github.com/Azure/azure-sdk-for-go/blob/main/sdk/messaging/azservicebus/README.md#logging

@alesbrelih, sorry I missed that you've provided details above. I'm following up on a fix that was made on the service-side that matches what you were seeing, in that you have valid credits on the link but no messages are being returned. I'll post back here when I have details.

@richardpark-msft

I'm following up on a fix that was made on the service-side that matches what you were seeing, in that you have valid credits on the link but no messages are being returned.

That's a very useful insight. I think that explains what we saw a few times and means I can stop chasing it.

Can this issue affect Senders as well?
We have some code that opens a client, sends a message and then closes the client. This isn't performant and can take a couple of seconds before the message is sent to ASB. We'd like to reduce the time it takes to send the message using long living clients (senders), just as for the readers, and I was wondering if we can do more harm than good in the current situation?

@rokf, the approach you have is basically eating the cost of starting up a TCP connection each time. You can improve this a few ways:

Use a single azservicebus.Client instance. The Client owns the expensive part (the TCP connection) so keeping that around and using it when creating your Senders will make things faster.
If you want you can also go further and use a single Sender instance as well - this'll have the same effect but also cache the link, which does have some startup cost as well.

Now, in either case, it's possible for the connection to have to restart if you idle out, so there might still be some initialization cost based on network conditions, etc... But the tactics above are the easiest ways to avoid having to eat the startup cost on every send.

Hi all, just want to update with some info.
There have been a lot of fixes in the latest package release to improve reliability/resilience to azservicebus<EMAIL_ADDRESS>In this release, we incorporated the GA version of go-amqp (the underlying protocol stack for this package). A lot of the work that went into this was around deadlocks and race conditions within the library that could cause it to become unresponsive. In addition there have been service-side fixes related to messages not being delivered, despite being available.
Every release brings improvements but this one hits at the core of the stack and should yield improvements in overall reliability, especially in some potential corner cases with connection/link recovery.
I'd encourage all the people involved in this thread to upgrade.

Thank you Richard, we'll update ASAP 👍

@richardpark-msft. I will roll out the new library version in our lower envs and let it run for a bit. However, I'm not going to roll it out to anywhere in our "live paths". While validation of this type of thing isn't nearly as useful without real traffic, the work around I have in place is stable and I don't want to introduce risk there.
In the original description, I included some terraform and a description of how reproduce the issue. Has this library been tested against that use case or some comparable one?

@richardpark-msft. I will roll out the new library version in our lower envs and let it run for a bit. However, I'm not going to roll it out to anywhere in our "live paths". While validation of this type of thing isn't nearly as useful without real traffic, the work around I have in place is stable and I don't want to introduce risk there.

Appreciate all the testing you've done and your workaround is harmless. It should work just fine either way. It would be interesting, in production code, if you still see your workaround trigger - at that point we'd want to involve the service team to see if there's something interesting happening there, instead of just focusing on the client SDK.

In the original description, I included some terraform and a description of how reproduce the issue. Has this library been tested against that use case or some comparable one?

We run three different kinds of tests: unit, live/integration and long-term.
We've added a lot of tests in all three areas based on feedback from you (and others) to see if we could get to the bottom of it. We definitely found and fixed bugs, but I never replicated the ease of your scenario despite trying a lot of variations.
However, I do have your scenario covered here: https://github.com/Azure/azure-sdk-for-go/blob/main/sdk/messaging/azservicebus/internal/stress/tests/infinite_send_and_receive.go. We generally run these tests for a week to give them space to fail and we have a few other tricks using chaos-mesh to try to induce failures earlier.
(another one inspired by some bugs: https://github.com/Azure/azure-sdk-for-go/blob/main/sdk/messaging/azservicebus/internal/stress/tests/mostly_idle_receiver.go)


deps: update djs to v14

Please describe the changes this PR makes and why it should be merged:
This PR includes updating peer deps of djs to v14, thus making Dokdo compatible w/ discord.js v14.
Status

[x] Code changes have been tested.

Semantic versioning classification:

[ ] This PR includes new feature, methods or parameters
[x] This PR includes breaking changes (feature, methods, parameters removed or renamed)
[ ] This PR only includes non-code(typo, documentation etc.) changes

:wave: Thanks for contributing Dokdo!

looks like lock file needs a update (djsv14)


Code review

Since I've digged through the code anyway I've prepared some code review. Don't feel obliged to incorporate this. These are just suggestions.

It's great! Thank you for that


Login fix

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.0 out of 2 committers have signed the CLA.:x: MennaHG:x: Lama-Khaled-IsmailYou have signed the CLA already but the status is still pending? Let us recheck it.


Restoring SavedModel in //tensorflow/c:c_api_test fails

System information

Have I written custom code (as opposed to using a stock example script provided in TensorFlow): No
OS Platform and Distribution (e.g., Linux Ubuntu 16.04): Linux Ubuntu 16.04
TensorFlow installed from (source or binary): source
TensorFlow version: 'v1.2.1-0-gb4957ff', '1.2.1'
Python version: 2.7.12
Bazel version: 0.4.5
CUDA/cuDNN version: No GPU
GPU model and memory: No GPU
Exact command to reproduce: bazel test //tensorflow/c:c_api_test

The problem:
While executing c_api_test from c module on a big endian machine, it fails while restoring SavedModel(tensorflow/cc/saved_model/testdata/half_plus_two/00000123). There is a warning displayed Reading a bundle with different endianness from the reader.
Similarly, other tests from cc, java module which read this SavedModel from testdata also fail due to endianness mismatch.
What would be appropriate way to handle this failure on big endian?
Is there a way to convert the above SavedModel to Big Endian while reading it in the tests?
Test Logs:
[ RUN      ] CAPI.SavedModel
2017-06-29 09:04:33.999662: I tensorflow/cc/saved_model/loader.cc:226] Loading SavedModel from: <HOME>/.cache/bazel/_bazel_test/24685d064c07f7346b48c2d13ec3ad69/execroot/tensorflow/bazel-out/local-opt/bin/tensorflow/c/c_api_test.runfiles/org_tensorflow/tensorflow/cc/saved_model/testdata/half_plus_two/00000123
2017-06-29 09:04:34.039733: I tensorflow/cc/saved_model/loader.cc:145] Restoring SavedModel bundle.
2017-06-29 09:04:34.079006: W tensorflow/core/framework/op_kernel.cc:1158] Unimplemented: Reading a bundle with different endianness from the reader
2017-06-29 09:04:34.079311: W tensorflow/core/framework/op_kernel.cc:1158] Unimplemented: Reading a bundle with different endianness from the reader
2017-06-29 09:04:34.079363: W tensorflow/core/framework/op_kernel.cc:1158] Unimplemented: Reading a bundle with different endianness from the reader
2017-06-29 09:04:34.079708: I tensorflow/cc/saved_model/loader.cc:274] Loading SavedModel: fail. Took 136931 microseconds.
tensorflow/c/c_api_test.cc:1198: Failure
      Expected: TF_OK
      Which is: 0
To be equal to: TF_GetCode(s)
      Which is: 12
Reading a bundle with different endianness from the reader
         [[Node: save/RestoreV2 = RestoreV2[_output_shapes=[[]], dtypes=[DT_FLOAT], _device="/job:localhost/replica:0/task:0/cpu:0"](_arg_save/Const_0_1, save/RestoreV2/tensor_names, save/RestoreV2/shape_and_slices)]]

There's a suggestion of a workaround for Endianness conversion in #2619. Also some discussion of how to set and handle the IS_LITTLE_ENDIAN flag.
I think we're in the unfortunate situation of not being able to test big-endian code. We're happy to accept patches that add big-endian support.

@cy89 Thanks for your reply. I have checked the flag used to detect underlying platform.
The flag kLittleEndian declared here  can be used to check for big endian However, the c_api_test  fails on the SavedModel from test data which is in raw format and we are not sure about an appropriate way to convert this raw data suitable for big endian.

Further analysis on this test shows that there is a check for endianness.  In case of BIG endian, test fails with "Unimplemented: Reading a bundle with different endianness from the reader".
I tried to bypass this check and allowed the execution further for this test however it gives wrong output.
The tensor bundle write/read seems to be working for big endian so now suspecting that the test data for big endian systems can be uploaded separately. But not sure how to generate the test data.
Can you please confirm this understanding is correct? Also, could you let us know the steps which will generate test data.
@aselle @poxvoculi Could you please provide your inputs on this?

@asimshankar: Do you know who's in a position to fix c_api_test.cc?

I think the larger question raised by this is what our position should be regarding serialization formats. Regenerating the testdata would make this test pass, but we'd still have issues where say a SavedModel produced by a little endian machine will be unreadable on a big endian machine and vice-versa. Similarly, any tensors sent over RPCs across between machines with different architectures would likely fail.
A more principled fix would be something that perhaps includes the encoding format in the serialization and translates if necessary when deserializing. Something like that, I believe, would be the right way to go about ensuring TensorFlow is big-endian friendly.
That said, for specifically this test, you could regenerate a saved model in big-endian format in the testdata directory by running https://github.com/tensorflow/tensorflow/blob/master/tensorflow/examples/saved_model/saved_model_half_plus_two.py , committing the output and changing c_api_test.cc to use one path or the other based on the architecture it's running on.
Unassigning myself as both changes outlined above is not something that I, or anyone else on the TensorFlow team (I think), will be getting to in the near future. But we'd be happy to accept PRs.

@asimshankar: Model serialization is outside my area of expertise, but I saw this related issue last week: #11908  Why is model save/restore sensitive to endianness?  Are we not saving in protobuf format?

@poxvoculi : I'm not entirely sure about the history behind this as it predates my involvement in the project. Perhaps @zffchen78 has some historical knowledge?
But looking at the code, when we write out a tensor to disk (see tensor_bundle.cc), it seems we're dumping the raw contents of the TensorBuffer, which will be in the endianness of the architecture it was on. Even when we dump to a proto (Tensor::AsProtoTensorContent), the memory buffer is being used as-is). And in neither do we make a note of the endianness of the host when writing it out.
In other words, it doesn't look like we use the endian-safe routines in coding.cc for tensor content.

@asimshankar @poxvoculi Thank you for your inputs.
We could use the script saved_model_half_plus_two.py (referred in previous comment) to regenerate a saved model testdata in big-endian format (specifically s390x).  With the changes in source code test/BUILD files, now below tests are passing:
//tensorflow/c:c_api_test
//tensorflow/cc/saved_model:loader_test
//tensorflow/java:SavedModelBundleTest
//tensorflow/contrib/session_bundle:bundle_shim_py_test
//tensorflow/contrib/session_bundle:bundle_shim_test

On further execution of test modules like tensorflow/contrib, tensorflow/tools I found that there are few tests which are failing with same reason. i.e. testdata in little endian format.
//tensorflow/python/feature_column:feature_column_test
//tensorflow/tools/tfprof/internal:tfprof_show_test
//tensorflow/tools/tfprof/internal:tfprof_stats_test
//tensorflow/tools/tfprof/internal:tfprof_tensor_test
//tensorflow/contrib/session_bundle:session_bundle_py_test
//tensorflow/contrib/session_bundle:session_bundle_test

We could also generate partial testdata for session bundle by executing script https://github.com/tensorflow/tensorflow/blob/v1.2.1/tensorflow/contrib/session_bundle/example/export_half_plus_two.py used by session_bundle tests.
Now,  we need to generate testdata used by below modules as well:

tensorflow/session_bundle/testdata/half_plus_two_ckpt_v2
https://github.com/tensorflow/tensorflow/tree/v1.2.1/tensorflow/contrib/session_bundle/testdata/half_plus_two_ckpt_v2/00000123
tensorflow/python/feature_column
https://github.com/tensorflow/tensorflow/tree/v1.2.1/tensorflow/python/feature_column/testdata
 tensorflow/tools/tfprof/internal/testdata
https://github.com/tensorflow/tensorflow/tree/v1.2.1/tensorflow/tools/tfprof/internal/testdata

I tried to search for scripts/commands that could generate this testdata however didn't get much information. Am I missing something here?
Could you please provide us pointers?

@lilao can you provide guidance on session_bundle/testdata?
@ispirmustafa can you provide guidance on feature_column_test?
@panyx0718 can you advise on tprof/internal/testdata?

tprof/internal/testdata is a tiny model in python/profiler/model_analyzer_test.py. However, there is no script to automatically regenerate the data. And regenerating the data would require change of test results (due to time/memory dynamics).
The tests don't affect save/restore model. So, it should be safe to disable in your environment.

Same here, there is no script for feature_column_test and you can disable feature_column tests for your environment.

While we can skip tests/update testdata, this does mean that the serialized tensors will only be usable on the architecture that created it, which is a sad situation to be in.
@namrata-ibm : Would you have the bandwidth to contribute a more principled fix where we could record the endinaness of the creator in the checkpoint and do the conversion if necessary when we load the checkpoint?

@asimshankar, agree with you that this needs a better fix. However right now some other functionality needs attention on BE. Focusing on that first to make v1.2.1 available for BE and then consider this.
For now, skipping these tests for BE and accordingly raising a PR.
@asimshankar , @poxvoculi , @panyx0718 , @ispirmustafa  Thank you for your guidance.

Looks liked fixed by #16540.
This issue can be closed

I'm still facing an error in loading a model on s390x from a protobuf file is still there. I think #41652 is related to his issue.
CC @Nayana-ibm @asimshankar


Mwpw 136481 cls header

Describe your specific features or fixes
Resolves: MWPW-136481
Test URLs:

Before: https://main--express--adobecom.hlx.page/express/learn/blog?martech=off
After: https://mwpw-136481-cls-header--express--adobecom.hlx.page/express/learn/blog?martech=off

Just to be sure -- we are not gonna support brand header at all anymore? This change will remove it from the  regardless metadata theme.

Just to be sure -- we are not gonna support brand header at all anymore? This change will remove it from the
regardless metadata theme.

that's precisely why I wanted your feedback, thanks @qiyundai  !
I've added support back.

Codecov Report

Merging #279 (3101d13) into stage (3f1f924) will decrease coverage by 0.19%.
Report is 65 commits behind head on stage.
The diff coverage is n/a.

@@            Coverage Diff             @@
##            stage     #279      +/-   ##
==========================================
- Coverage   47.54%   47.35%   -0.19%
==========================================
  Files          30       31       +1
  Lines        9196     9315     +119
==========================================
+ Hits         4372     4411      +39
- Misses       4824     4904      +80

see 5 files with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


[Regression in master] docker service create can pull the image but then somehow miss it

Description
On master 7efc286, docker service create can pull the image but then somehow miss it and fails to create the tasks.
The issue does not happen in 1.13.1.
So it should be a recent regression.

Steps to reproduce the issue:
Start a daemon with a clean /var/lib/docker, and then initialize the swarm (just 1 node is enough).
Make sure we have no image here:
$ docker images -a
REPOSITORY          TAG                 IMAGE ID            CREATED             SIZE

Then start a service from the official nginx image:
$ docker service create nginx
ft3zwm8z6m01qy1frzpmkph2y

Describe the results you received:
The service does not start up:
$ docker service ps --no-trunc ft3zwm
ID                         NAME              IMAGE                                                                                NODE  DESIRED STATE  CURRENT STATE            ERROR                                                                                PORTS
trq6yyk68onclmdszzyjvimy9  stoic_bose.1      nginx:latest@sha256:f2d384a6ca8ada733df555be3edc427f2e5f285ebf468aae940843de8cf74645  ws01  Ready          Rejected 1 second ago    "No such image: nginx:latest@sha256:f2d384a6ca8ada733df555be3edc427f2e5f285ebf468aae940843de8cf74645"
cbb6n3lcdjul7hv2fiwjxmui7   \_ stoic_bose.1  nginx:latest@sha256:f2d384a6ca8ada733df555be3edc427f2e5f285ebf468aae940843de8cf74645  ws01  Shutdown       Rejected 6 seconds ago   "No such image: nginx:latest@sha256:f2d384a6ca8ada733df555be3edc427f2e5f285ebf468aae940843de8cf74645"
lninoixrdqrkori00i6vjb950   \_ stoic_bose.1  nginx:latest@sha256:f2d384a6ca8ada733df555be3edc427f2e5f285ebf468aae940843de8cf74645  ws01  Shutdown       Rejected 11 seconds ago  "No such image: nginx:latest@sha256:f2d384a6ca8ada733df555be3edc427f2e5f285ebf468aae940843de8cf74645"
oo28behb3qg5d4603pu9nvvqd   \_ stoic_bose.1  nginx:latest@sha256:f2d384a6ca8ada733df555be3edc427f2e5f285ebf468aae940843de8cf74645  ws01  Shutdown       Rejected 16 seconds ago  "No such image: nginx:latest@sha256:f2d384a6ca8ada733df555be3edc427f2e5f285ebf468aae940843de8cf74645"
ygb6ur4yc923xq0g07mhs7dzd   \_ stoic_bose.1  nginx:latest@sha256:f2d384a6ca8ada733df555be3edc427f2e5f285ebf468aae940843de8cf74645  ws01  Shutdown       Rejected 21 seconds ago  "No such image: nginx:latest@sha256:f2d384a6ca8ada733df555be3edc427f2e5f285ebf468aae940843de8cf74645"

The image with the corresponding digest seems successfully pulled, but somehow missed during creating the task container.
$ docker images --digests -a
REPOSITORY          TAG                 DIGEST                                                                    IMAGE ID            CREATED             SIZE
nginx               latest              sha256:f2d384a6ca8ada733df555be3edc427f2e5f285ebf468aae940843de8cf74645   cc1b61406712        2 weeks ago         182MB

Describe the results you expected:
The service should start up successfully
Additional information you deem important (e.g. issue happens only occasionally):
Output of docker version:
Client:
 Version:      1.14.0-dev
 API version:  1.27
 Go version:   go1.7.5
 Git commit:   7efc286
 Built:        Fri Feb 10 08:08:48 2017
 OS/Arch:      linux/amd64

Server:
 Version:      1.14.0-dev
 API version:  1.27 (minimum version 1.12)
 Go version:   go1.7.5
 Git commit:   7efc286
 Built:        Fri Feb 10 08:08:48 2017
 OS/Arch:      linux/amd64
 Experimental: true

Output of docker info:
Containers: 0
 Running: 0
 Paused: 0
 Stopped: 0
Images: 1
Server Version: 1.14.0-dev
Storage Driver: overlay2
 Backing Filesystem: extfs
 Supports d_type: true
 Native Overlay Diff: true
Logging Driver: json-file
Cgroup Driver: cgroupfs
Plugins:
 Volume: local
 Network: bridge host ipvlan macvlan null overlay
Swarm: active
 NodeID: bmw34auwnsqqomj227vnuoci1
 Is Manager: true
 ClusterID: qht5pl6dx7axm4sk2301fm836
 Managers: 1
 Nodes: 1
 Orchestration:
  Task History Retention Limit: 5
 Raft:
  Snapshot Interval: 10000
  Number of Old Snapshots to Retain: 0
  Heartbeat Tick: 1
  Election Tick: 3
 Dispatcher:
  Heartbeat Period: 5 seconds
 CA Configuration:
  Expiry Duration: 3 months
 Node Address: <IP_ADDRESS>
 Manager Addresses:
  <IP_ADDRESS>:2377
Runtimes: runc
Default Runtime: runc
Init Binary: docker-init
containerd version: 78fb8f45890a601e0fd9051cf9f9f74923e950fd
runc version: 51371867a01c467f08af739783b8beafc154c4d7
init version: 949e6fa
Security Options:
 apparmor
 seccomp
  Profile: default
Kernel Version: 4.8.0-37-generic
Operating System: Ubuntu 16.10
OSType: linux
Architecture: x86_64
CPUs: 4
Total Memory: 14.69GiB
Name: ws01
ID: SN3T:CNK6:JKQD:54CY:XKF2:BRX3:CIRU:DQBT:6DVZ:VWQ2:Q5ET:F23L
Docker Root Dir: /var/lib/docker
Debug Mode (client): false
Debug Mode (server): true
 File Descriptors: 29
 Goroutines: 122
 System Time: 2017-02-10T08:56:37.960924349Z
 EventsListeners: 0
Registry: https://index.docker.io/v1/
WARNING: No swap limit support
Experimental: true
Insecure Registries:
 <IP_ADDRESS>/8
Live Restore Enabled: false

Additional environment details (AWS, VirtualBox, physical, etc.):

@AkihiroSuda possibly the issue that https://github.com/docker/docker/pull/30889 is fixing?

Seems so, thank you for the information :sweat_smile:

Please verify if it's the same issue, but it looked similar (based on your description)

Yes, same issue, and I confirmed the PR above works for me.


How it's different from razak17/tailwind-fold.nvim?

Hi, I am trying to understand how this plugin is different from https://github.com/razak17/tailwind-fold.nvim since this one is newer but doesn't provide clear instructions on how it works for example with TailwindCSS.

Do I need to set conceallevel=2 to make it work?
Do I need to set concealcursor to empty?
Does it work automatically with TailwindCSS in ts/tsx without further configuration?
Looks like it doesn't use treesitter or tailwindcss to determine Tailwind classes right?
Can I set minimum characters/classes variable after this plugin is automatically folding like in razak plugin?

Maybe it's better to contribute together?

Hi thanks I didn't know about this alternative. I started this project on a whim and didn't really search for alternatives.
Treesitter integration is something I'm currently working on so this difference won't remain for long.
The conceallevel=2 is still required since both plugins seem to use a similar approach.
And I'm not using .tsx files so i don't know if the given pattern works for them. But you can write any pattern for any filetype and it can be concealed.
This also seems to be the biggest difference. My focus is currently to make this plugin more universal so that it can be used for all kinds of inline folds not just tailwind.


Add translations for EndpointSlices for Bahasa Indonesia

Hi!
I've added the Bahasa Indonesia translation for EndpointSlices.
This PR addresses https://github.com/kubernetes/website/issues/20111.

/cc
/cc @phanama

Thank you for the feedback @wahyuoi @sftim. Let me know if there's any!

nice, 🎉
please squash your commits into 1 @evanap, then it's good to merge

You can assign me to merge this once it’s lgtm on your side. Thanks @evanap 🎉 And thank you for your thorough review @wahyuoi

I'm putting some reviews in a moment @irvifa @wahyuoi

Folks, I've updated the page with your reviews and suggestions. Thank you for the reviews and suggestions! Let me know if it still need more improvements. @wahyuoi @sftim @phanama @irvifa

@evanap don't forget to squash the commits into one commit

Other than echoing the comment about squashing, I've no feedback to add here. I don't speak bahasa Indonesia myself.

Alright, folks. Commits squashed. Thank you! @wahyuoi @sftim @irvifa @phanama

Looks good! Requesting lgtm labels @girikuncoro @irvifa
/assign @girikuncoro
/assign @irvifa

/lgtm

Beautiful translation, thank you so much for your contribution @evanap! 🎉 this EndpointSlice is new feature in Kubernetes, translating/reading this page is a great learning. Feel free to translate other pages when you get time :)
/lgtm
/approve

Thanks everyone! I've encountered the EndpointSlice resource before but never get to understand it until now. This work is sure is helpful in understanding it.
I'll be taking another page to translate. Again, thank you for the collaboration!


New bug in ZDEMO_EXCEL29

Dear Team,,
I found a new bug when I try to run the demo program: ZDEMO_EXCEL29 with a Macro-enabled Workbook.
There is an ABAP Dump in line 64: lv_file = lo_excel_writer->write_file( lo_excel ).
when I debug I found: the first row the table LO_WORKSHEET->SHEET_CONTENT, the cell_row value is 0.

test macro workbook.zip
you can take this test macro workbook to run the demo program: ZDEMO_EXCEL29, the you will get the ABAP Dump error.
Thanks.

The "test macro workbook" is missing, could you attach it please?

is missing, could yo

Hi Sandraros,
I have attached the file, could you try again?
Thanks.
test macro workbook.zip

I have attached the file, could you try again?
Thank you. I will analyze it this evening.

Analysis is over: in your Excel file, in /xl/worksheets/sheet1.xml there is an hyperlink which spans over several cells:
<hyperlinks>
  <hyperlink ref="C4" r:id="rId1" tooltip="NPR TRAINING DOCUMENT.doc" xr:uid="{00000000-0004-0000-0200-000000000000}"/>
  <hyperlink ref="C5:C8" r:id="rId2" tooltip="NPR TRAINING DOCUMENT.doc" display="DOC" xr:uid="{00000000-0004-0000-0200-000002000000}"/>
</hyperlinks>

The method LOAD_WORKSHEET_HYPERLINKS of ZCL_EXCEL_READER_2007 handles hyperlinks over one cell only, as you can see here https://github.com/sapmentors/abap2xlsx/blob/master/src/zcl_excel_reader_2007.clas.abap#L3456-L3471, the method convert_columnrow2column_a_row receives I_COLUMNROW = 'C5:C8' and returns E_ROW = 0:
      zcl_excel_common=>convert_columnrow2column_a_row( EXPORTING
                                                          i_columnrow = ls_hyperlink-ref
                                                        IMPORTING
                                                          e_row       = lv_row
                                                          e_column    = lv_column ).
      io_worksheet->get_cell( EXPORTING
                                ip_column     = lv_column
                                 ip_row       = lv_row
                               IMPORTING
                                 ep_value     = lv_value ).
      io_worksheet->set_cell( ip_column     = lv_column
                              ip_row        = lv_row
                              ip_value      = lv_value
                              ip_hyperlink  = lo_hyperlink ).

Solution to be proposed. Back soon...

NB: this problem is not related to XLSM file and ZDEMO_EXCEL29. It may happen even with a simple XLSX file that can be used with ZDEMO_EXCEL37 to reproduce the issue. Example of minimal XLSX file:
test fix 687.zip

The fix above solves the ABAP dump, which was due to a same hyperlink assigned to a range of cells. Note that after the fix, I could see other issues concerning the Excel file provided, like the hyperlink is not underlined and color is not blue, and the VBA button is not rendered (please create separate issues if you want them to be resolved).


Change in date format from dd/mm/yyyy to yyyy-mm-dd in filter

Expected behaviour
Tell us what should happen.
In my project, filter is used to show the bookings between from and to dates, for that date picker is used to get the from and to date, while choosing the date in datepicker, it is in this format "dd/mm/yyyy" after filtering the records the format should be displayed in same format like this "dd/mm/yyyy"
Actual behaviour
Tell us what happens instead.
But the format displayed is "yyyy-mm-dd"
Datepicker version used
bootstrap-datepicker-rails (<IP_ADDRESS>)
Example code
in _filter_form.html.haml:
= form_for @linguist_filter_form, url: "/account/linguists/filter", method: :post, html: { class: 'form-inline' } do |f|
.form-group
= f.label :with_bookings_from_date, "With bookings from", class: 'sr-only'
.input-group.date#with_bookings_from_date{ data: { behaviour: 'linguist-datepicker' } }
= f.text_field :with_bookings_from_date, value: @linguist_filter_form.with_bookings_from_date, placeholder: 'With bookings from', class: 'form-control', onkeydown: "event.preventDefault()"
%span.input-group-addon
%span.glyphicon.glyphicon-calendar
.form-group
= f.label :with_bookings_to_date, "With bookings to", class: 'sr-only'
.input-group.date#with_bookings_to_date{ data: { behaviour: 'linguist-datepicker' } }
= f.text_field :with_bookings_to_date, value: @linguist_filter_form.with_bookings_to_date, placeholder: 'With bookings to', class: 'form-control', onkeydown: "event.preventDefault()"
%span.input-group-addon
%span.glyphicon.glyphicon-calendar
in linguists.js:
var linguist_datetime_picker = {
initialize: function() {
$("[data-behaviour~='linguist-datetimepicker']").datetimepicker({
useCurrent: false,
locale: 'en-gb',
keepInvalid: true,
showClear: true,
widgetPositioning: {
horizontal: 'auto',
vertical: 'bottom'
}
});
$("[data-behaviour~='linguist-datepicker']").datetimepicker({
dateFormat: 'dd/mm/yyyy',
useCurrent: false,
locale: 'en-gb',
keepInvalid: true,
showClear: true
});
}
};
I also tried these, but nothing worked
value: @linguist_filter_form.with_bookings_to_date.to_fs
value: @linguist_filter_form.with_bookings_to_date.strftime('%d/%m/%Y')
value: @linguist_filter_form.with_bookings_from_date.nil? ? nil : @linguist_filter_form.with_bookings_from_date.strftime('%d/%m/%Y')
= f.text_field :with_bookings_to_date, value: @linguist_filter_form.with_bookings_to_date, placeholder: 'With bookings to', class: 'form-control', data: { date_format: 'DD/MM/YYYY'}
Jsfiddle example to reproduce the problem.

![Screenshot 2023-10-12 at 4 35 44 PM](https://github.com/uxsolutions/bootstrap-da

tepicker/assets/96114251/8bccd675-c908-4fd1-a3a6-d36c5dee2ca6)

In this data-date-format is DD/MM/YYYY and value is 02/10/2023, but it is showing as 2023-10-02


Simulated/Unsimulated is unnecessary

Refactor the class tree the following way:
Tile -> Space
Tile -> Air
Tile -> Wall
Move Simulated code into Tile, special tiles that handle things differently can override the standard behavior if needed.
Space having access to onCreate onDelete doesn't matter as they can be overridden. And it's a non instance class anyway.

Done.


Inherit docstrings from super-classes

Feature request
For example, the ImportArguments [1] class has lots of fields/methods that it inherits from the superclass [2], but users would have to navigate to the superclass to find them. All properties and methods should be displayed on classes.
This may be supported with autodoc show_inheritance.
[1] https://hipscat-import.readthedocs.io/en/stable/autoapi/hipscat_import/catalog/arguments/index.html
[2] https://hipscat-import.readthedocs.io/en/stable/autoapi/hipscat_import/runtime_arguments/index.html
Before submitting
Please check the following:

[x] I have described the purpose of the suggested change, specifying what I need the enhancement to accomplish, i.e. what problem it solves.
[x] I have included any relevant links, screenshots, environment information, and data relevant to implementing the requested feature, as well as pseudocode for how I want to access the new functionality.
[x] If I have ideas for how the new feature could be implemented, I have provided explanations and/or pseudocode and/or task lists for the steps.

Addressed in https://github.com/astronomy-commons/hipscat-import/pull/310


parameterize the sorting algorithm in resolveCollisions()

I'm new to  d3-sankey and d3.js in general, thanks for this software,  it's just amazingly powerful.
One feature is missing in sankey : the ability to customize the sorting algorithm used in resolveCollisions().
I'm building a diagram where I need vertical nodes to be sorted by name instead of "ascendingBreadth". I modified the source code by putting my own sorting function and it works like a charm; but it would be much better if the sorting function could be passed as a parameter to sankey().

@damil  , could you provide me an example of where and how you did this? I need to sort alphabetically (A higher than B, higher than C, etc.).

In function resolveCollisions(), like this :
    function resolveCollisions() {
      nodesByDepth.forEach(function(nodes) {
        var node,
            dy,
            y = y0,
            n = nodes.length,
            i;

        // Push any overlapping nodes down.
        // ORIG : nodes.sort(ascendingBreadth);
        // MODIFIED LINE BELOW :
        nodes.sort(function(a, b){return a.name < b.name ? -1 : a.name > b.name ? 1 : 0;});

I just ran into a situation where disabling/altering the sorting would be super useful

You can now use sankey.nodeSort(null) to disable reorder of nodes within the columns and preserve the input order.


Added Cursor functionality

For this to be merged as an example, it should be using the argon-aframe components and entities, include


Fix CopyPlugin and Improve documentation

Hi!
I guess this PR fixes #9 #11 #13
I'm using this very well to place a "images" directory under resources with just mix.imagemin('images'); as configuration.

Will be this merged soon? Thanks

@CupOfTea696 Merge this please :)

You can run npm i CupOfTea696/laravel-mix-imagemin#pull/15/head on local computer to apply this PR.


Defer assignment of Docker gcr.io secret

With the ':=' assignment in the Makefile, the SECRET was
evaluated at the start, regardless of whether it was needed
or not to complete the recipe.
This causes an issue if you don't have the necessary
docker-credential-gcr tool which is expected to be there
for Jenkins.
This change defers the evaluation by using '=' instead and
avoids confusing error messaages when building locallly.
Signed-off-by: John Schnake<EMAIL_ADDRESS>

Codecov Report

Merging #674 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #674   +/-   ##
=======================================
  Coverage   30.53%   30.53%
=======================================
  Files          57       57
  Lines        3134     3134
=======================================
  Hits          957      957
  Misses       2086     2086
  Partials       91       91

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 922fd03...d3c8547. Read the comment docs.


Make variants sale resolver use DB replica instead of writer DB

Make variants sale resolver use DB replica instead of writer DB

Impact

[ ] New migrations
[ ] New/Updated API fields or mutations
[ ] Deprecated API fields or mutations
[ ] Removed API types, fields, or mutations
[ ] Documentation needs to be updated

Pull Request Checklist

[ ] Privileged queries and mutations are guarded by proper permission checks
[ ] Database queries are optimized and the number of queries is constant
[ ] Database migration files are up to date
[ ] The changes are tested
[ ] GraphQL schema and type definitions are up to date
[ ] Changes are mentioned in the changelog

Task linked: CLOUD-2398 Use replica for read only query


Create adminhtml layout and templates

adminhtml layout and template directories aren't created. I also think it's important to show the module structure that is created. Although I agree with it some people might argue what the perfect  structure is.

Nice. I reckon it might be better with an actual real module name instead of vendor/namespace in the example structure. What do you think?

Yeah agreed, I did have AydinHassan/Parrot as an example. I'll put that back in

Updated

Only just noticed you'd fixed the unlinks, if you can squash these commits I'll get this merged!

Squashed!

Thanks!


LLT linear solver using eigen3

As given in #3074, implemented LLT linear solver in linalg using eigen3 for Dense Matrices to solve linear systems of the form (Ax=b) with a method to precompute the cholesky factor i.e. the lower triangular matrix L and a triangular solve method to solve the linear system given L and b as the input.

This is a great initiative, but we mostly want this solver to be part of linalg.
@lambday can you comment a bit

closing...


c++ lookup references result window doesn't show

as said in title, the result show in *Rtags* buffer which stay background. is this related to pop up window manager?  plus I already run +cc/reload-compile-db.

Could this be related to #768?
Could you try running (delete-file (locate-library "rtags.elc")), then restart Emacs and see if the issue is resolved?

@hlissner it seems strange, after I restart emacs(I don't do anything else), it works again. but then i delete rtags library in /usr/local/share/emacs/site-lisp.

I was the reporter of #768. The issue resurfaced for me as well (this seems to be the exact same issue). Last time doing (delete-file (locate-library "rtags.elc")) did not resolve the issue, but this time it did.
I'm on Arch Linux with Emacs 26.1, and the rtags-git AUR package installed, which installs the file /usr/share/emacs/site-lisp/rtags/rtags.elc which seems to be the culprit. There must be some kind of conflict between the elpa version and the AUR version, although I'm not sure what it is.
--- /usr/share/emacs/site-lisp/rtags/rtags.el   2018-08-07 20:09:41.000000000 -0700
+++ /home/benj/.emacs.d/.local/packages/elpa/rtags-20180814.1713/rtags.el       2018-08-27 20:59:19.708648059 -0700
@@ -5,6 +5,7 @@
 ;; Author: Jan Erik Hanssen<EMAIL_ADDRESS> ;;         Anders Bakken<EMAIL_ADDRESS> ;; URL: http://rtags.net
+;; Package-Version: 20180814.1713
 ;; Version: 2.10

 ;; This file is not part of GNU Emacs.
@@ -1480,7 +1481,8 @@
            (completing-read prompt collection predicate require-match default-value hist)))

         ((eq rtags-completing-read-behavior 'default-when-empty)
-         (setq prompt (replace-regexp-in-string "^\\(.*\\): " (concat "\\1 (default: " default-value "): ") prompt))
+         (when (> (length default-value) 0)
+           (setq prompt (replace-regexp-in-string "^\\(.*\\): " (concat "\\1 (default: " default-value "): ") prompt)))
          (let ((ret (if (fboundp 'completing-read-default)
                         (completing-read-default prompt collection predicate nil nil hist)
                       (completing-read prompt collection predicate nil nil hist))))

Haven't tried it, but I'd guess this would go away if you didn't install the packaged elisp from rtags-git. Looks like you could get that by adding the parameter -DRTAGS_NO_ELISP_FILES=1 to the cmake line in the PKGBUILD. I'll try this and report back.

Sorry for the late followup. This should be resolved by now so I'll consider this issue resolved. Let me know if that isn't the case and I will reopen it.


[NEW ALGORITHM] Bit Manipulation - Count Set Bits

Issue will be closed if:

You mention more than one algorithm. You can create a separate issue for each algorithm once the current one is completed.
You propose an algorithm that is already present or has been mentioned in a previous issue.
You create a new issue without completing your previous issue.

Note: These actions will be taken seriously. Failure to follow the guidelines may result in the immediate closure of your issue.

Name:
[Count the Number of Set Bits]
About:
This algorithm, also known as Hamming Weight or Population Count, counts the number of 1-bits in the binary representation of a given integer.
Bitwise operations are used to efficiently count the set bits in O(number of set bits) time complexity, making it an effective solution for applications that require frequent bit-level manipulation, such as cryptography, network address manipulation, and compression.

Labels:
new algorithm, gssoc-ext, hacktoberfest, level1

Assignees:

[x] Contributor in GSSoC-ext
[x] Want to work on it

Kindly assign me this issue so that I can start working on it ..

assigned


Add 'on_raw_member_screening_reject' event, rename previous event

Summary
Followup to 659966ee528cf36d87b66c3cf9b4967e318063d0 and #107.
This PR adds an on_raw_member_screening_reject that'll always fire regardless of the members intent; the previously added on_member_screening_decline is also renamed to on_member_screening_reject.
Checklist

[x] If code changes were made then they have been tested

[x] I have updated the documentation to reflect the changes
[x] I have formatted the code properly by running black .

[ ] This PR fixes an issue
[x] This PR adds something new (e.g. new method or parameters)
[ ] This PR is a breaking change (e.g. methods or parameters removed/renamed)
[ ] This PR is not a code change (e.g. documentation, README, ...)

Looks good. Is it ready for merge?

Looks good. Is it ready for merge?

Pretty much, I want to wait for the requested review though since he was the one who suggested the changes to the previous commit.

Thanks for taking a look!

Only question I have is what is the rationale for the rename? Nice to include context like that in commits / PRs.

That's a good question, I probably should've clarified that somewhere.
The primary reason is that the requests sent by clients contain a rejection_reason field (seemingly unused), as seen here:

The entire membership screening system is still subject to change, eventually bots could get access to those fields (or similar ones).

Cool, works for me!


[modelcars] add role to build image

I've got this working locally but need to make sure it works in the CI

thanks Drew, looks good :)
minor comments, you need to regenerate the auto-generate files (I need to update the doc ...)
./run_toolbox.py repo generate_toolbox_related_files

and remove the PVC variable
with that fixed, good to merge from my POV


Wire protocol errors

This PR changes the failFundingFlow method to accept an error, which will
only be sent to the remote the peer if it is among the errors found in
ReservationErrors or ErrorCode. This is done to ensure we don't send
errors that contain information we don't want to leak.
Fixes #661.

Updated the PR description to note that this fixes #661.


When will you support the A320?

I already sent a few a320 liveries. I'm curious when will you guys support the aircraft. If you guys support it, then I would make more liveries for the a320!!

And whoever made the B787-8 map, can you draw the outlines?

And whoever made the B787-8 map, can you draw the outlines?

It's a map made in blender, the creator of the aircraft made it have no outlines

ohhh ok


Mono-4.6: Error: Trust failure

http://image.prntscr.com/image/a5d7feff4e694235a333adc788b34fd6.png
http://image.prntscr.com/image/bae05282680e4e36bf6cb5bf07da51ab.png
I am running using Mono-4.6 runtimes
https://www.dropbox.com/s/mtc6u726ey644o7/mono-portable46.zip?dl=0
Log:
http://pastebin.com/raw/sCkPiQ2s

 System.Net.ServicePointManager.ServerCertificateValidationCallback = delegate { return true; };
add this code to top of your connection code


Add Molmo backbone

@yawenzzzz I fixed the issue with CLIP model for other variants and added test, can you take another look? thanks!


License

License statement.

https://github.com/google/play-services-plugins/tree/master/oss-licenses-plugin
maybe use this one.


No source code for quickreplace CLI program

Hello,
It seems that there is no source code for the quickreplace program.
Could you upload the quickreplace 's code, please?

Yeah, I realized that as well.

I was looking for the example too...
Created it here in this gist: https://gist.github.com/ericdouglas/9212a94b675f7ec9ebccb07eb2eee4d8


documentation request: .env

Can you provide an example of what to put in the .env file?

I found some good parallel documentation here: https://devcenter.heroku.com/articles/config-vars
So, I can see the likely structure of the .env file, along with a reminder to add .env to .gitignore

Closed by 3687e1b124653f8b77b4b76d6558feb8b8715d62. Reference to tests.py to see all supported formats.

Thanks for this!  It helped me choose django-dotenv over alternatives because of the support for bash-compatible files.  Would be nice to have some examples in the README though.

@merwok PRs are welcome :)


Resolve more jsdoc value references as types

Make detection of require calls smarter.
When the reference is not to the result of a require call, use the type of the value instead. This is similar to pre-3.7 behaviour.

Fixes #33106

I mean, we need something, but a value fallback is probably a backward way of looking at "in JS, we wish that more values had associated types".

Right - which, generally, probably means binding way more assignments as aliases, if possible.


Add dev fund donation button

@langerhans @rnicoll @patricklodder Thoughts?

Leaving this open for now as the other things that actually add new things. We want to get the other stuff merged first. Thanks for the suggestion tho!

As we're getting towards 1.10, thought I should ping people to come back and ponder this. I'm nervous it sends the wrong message, but certainly we could put the donation address in docs more. Happy to merge if others are.
Also happy to handle rebaseing this on 1.10 myself rather than asking for everything to be closed and reopened.

I'd prefer to not implement this because I'm not comfortable with making donations to us a feature.. Plus it just gives just another incentive for someone to publish this as for example an apt package and redirect the button target.

Thanks for the work @whitj00 , but I think yes, it sends the wrong message unfortunately, however well meaning.


Speed up reading of turn costs

Currently we have this method in TurnCostStorage:
public double get(DecimalEncodedValue turnCostEnc, int fromEdge, int viaNode, int toEdge)

but it has two issues:

It creates a new IntsRef object on every call, even though all it returns is a double
It traverses the whole turn cost table for the given viaNode: For every node we store a list of entries TC_FROM|TC_TO|TC_FLAGS|TC_NEXT and calling the get method above traverses all of them and returns the first match. However, in practice we are typically only interested in the turn costs at a given node for a fixed fromEdge (or toEdge) and it would be better if we were able to skip the entries for other from/to edges right away.

Related: #269, #1945

I'm was investigating how to store the graph more compact and found something that improves the situation for wayGeometry. This is still in its early shape but basically uses a "vint" (see Lucene) with delta encoding like described in #234. To make this more effective the whole graph structure would need a change so that the "edge rows" would not need to be of same length. And this new graph storage (basically a persistent linked list that avoids duplicating edge information) would also allow a more efficient turn cost storage as 1. only the turn cost needs to be stored (no additional node id info) and 2. it would likely need only one byte per tc info. So we would want this if we start storing and reading turn costs for every junction.

It creates a new IntsRef object on every call, even though all it returns is a double

The funny or sad thing here is that the JVM seems to heavily optimize these things and for the wayGeometry work I found it did not make a difference if I reused or created the byte array. But here it could make a difference when we call it for every node in the algorithm and not only for the location lookup.

Here: e97235c6b6a3c85bfd9585339f19f02f54136c61, b6d75785b0b53d4ac80a66133fc91765b74b6058, d4301f2a65d4b2ae1e67b965751588c056aa70da, a12096a87a10ecaea6dad735d7fc43756415d40f I copied the turn costs (for only one vehicle) to some int[] arrays and this lead to a significant reduction of CH preparation time. I take this as a proof that the turn cost reading is 'slow' for some reason. I was still looping over all turn cost entries of a given node, so the question is why it is still slow.

TurnCostStorage uses a byte[] array instead of an int[] array. However we tried changing to int[] in this branch: 2b19704492f63ecbcab7c9d72621abce18322054 and this did not really help much.

The creation of the IntsRef object. Or even the associated int[] array. For the turn costs we only need to read one int, maybe we should try what happens if we just pass it along without using the int[] array at all?

Any other ideas?

I created a new branch less_new_intsrefs that creates only one IntsRef per request, but I fear this won't change the speed.
The main problem might be that we use a linked list at the moment in TurnCostStorage:
int nextTurnCostIndex = turnCosts.getInt(turnCostPtr + TC_NEXT);

to add turn costs at any time while import where the other edge information is not yet available.
And you implemented the turn cost access in a way where the values of one node are adjacent:
for (int i = turnCostNodes[viaNode]; i < turnCostNodes[viaNode + 1]; i++) {

This avoids one call of turnCosts.getInt per turn cost entry.
We could try to find a way to compact our current format on e.g. graph.freeze() and use e.g. negative values as indication to hop to a different index or something similar.
I even think this "linked list" versus "frozen" list could even help us to improve the speed for the base graph, see the effort in #2085.

Oh I did not realize yet that the linked list is not sorted yet (its not like I did it where all turn cost entries of one node are adjacent to each other. But doesn't this mean all we need to do is sort the turn cost array inside TurnCostStorage, just like I did it with the int[] arrays? Looping through the linked list is most likely aster when the entries are next to each other.

Yes, let's try this :) (see the commit)

Nice! Should we also remove TC_NEXT? The next entry should always be the one with index+1 after the sorting anyway?

It does not look like this change alone speeds up anything.

Nice! Should we also remove TC_NEXT? The next entry should always be the one with index+1 after the sorting anyway?

Yeah, will try to make the bytesPerEntry dynamic, but this is a bit tricky (and so I did not try this and hoped for the best) as we then have a different reading mechanism before and after freeze.

Does it have to be dynamic? Can we not just store the turn cost entries in some temporary storage/array/etc and only write to the 'real' TurnCostStorage in optimize()?

Ah, did not thought about this. Will try :)
The problem why I did not thought about this is that this increases our heap usage for the import and switching to MMAP won't decrease it. But 1. for turn costs the memory usage is very low at the moment and 2. for CH etc we already have heavy heap usage (that is currently not intended to move off-heap).

Here I changed the prepare graph to use the weighting instead of the sorted turn costs: https://github.com/graphhopper/graphhopper/tree/prepare_graph_tcs
Let's see how big the difference was (I remember something like 25%) and maybe try to rebase your branch to this to get a direct comparison?

Update again: Apparently the improvement of the edge-based CH preparation is very small for larger (Germany or larger) OSM extracts so I removed it again here: 841cb9ee6e600f2c726ec018667c9b5319983f7b

I also changed the turn cost DataAccess to use integers here: b4750c14041e2fbe5221b295f5747d1c85bb8d28

the improvement of the edge-based CH preparation is very small

For a planet-wide import we saw that removing the optimization increases the preparation time by around 10% from around 28h to 31h (for the car profile).


Symbolset

Hi Lars
I update README.md and add a new script that creates 3 symbolset files that allows us the ability to add OpenCPN raster symbol in mapfile.  The new script generate_symbolset.py create symbolset and symbols files directories in ./resources/symbols directory.

symbols-day.map
symbols-dark.map
symbols-dusk.map

    python generate_symbolset.py [day|dusk|dark] [output_directory]

Hi Simon,
It going to be interesting to see how the raster symbols looks compared to the vector ones.


MRecordRTC demo not working on Firefox and Chrome

Referring to the demo here.
On Firefox, the page alerts a {} and no video preview is available. There are no console errors. Only output to console is statistics about the number of watchers, forks, and followers (unrelated).
In Chrome, there's a preview (and audio can be heard), however, the save button is not available on stopping the recording (or ever) and the console logs the following error:

Uncaught TypeError: Cannot read property 'sampleRate' of undefined

I've also got this error in my very minimalistic test of creating an MRecordRTC.
In my own test, I fixed this with:
recorder.sampleRate = 44100;

It seems that this is not being given a default value as it is in RecordRTC. But Firefox doesn't save anything at all (Chrome works as expected). I can copy the URL from stopRecording into another tab, and the recording is there and correct.
Perhaps of note is that recorder.writeToDisk() results in an error:
TypeError: indexedDB is undefined

I think it's because the prefixed version is no longer supported in Firefox and you aren't using the non-prefixed version (simply indexedDB ). As a result, this is probably unrelated.
This is using the version downloaded via NPM on Windows 8.1 using the current stable version of Firefox (40.0.2).

I did some experimentation and digging into how you created the download mechanism. It seems that the underlying URL doesn't work (?). Going to the URL directly just doesn't load anything at all. Like, the network tab doesn't even recognize visiting a page and we're still on the new tab page.
I think the URL is wrong. If I copy the URL that stopRecording gets and set the anchor's href to that, then the downloading works. Not sure why.

All three issues should be fixed in this commit: https://github.com/muaz-khan/RecordRTC/commit/ffcce50c527a631e8a393be50849e165cf233cea

The main issues seem fixed, but Firefox is still unable to save the recording. Verified against the demo with FF 40.0.3 on Win 8.1.

Firefox save-as dialog issue is fixed in this commit: https://github.com/muaz-khan/RecordRTC/commit/52b97aed96ee5b3ad57cfa4297c6ac109bcb2450

Confirmed as fixed.


Pkg: Research visual regression testing

To enhance the standalone component test framework, we should include a visual regression test to easily identify when existing components have unexpectedly changed.
Basic reqs should include standalone testing and full CSS testing to ensure everything works individually but also ensure, more important, that other library additions are not introducing problems.
Look at:

https://github.com/Huddle/PhantomCSS
https://github.com/gemini-testing/gemini

Maybe later on based on resources we have as stand alone project


Show Outside Temperature

This is not an issue, but a feature request.
Is it possible to display the outside temperature in homeassistant via your component?
My evohome controller has a sensor outside which displays the outside temperature on the controller (in the upper left corner of the evotouch)
It would be great if you can implement it in the future.
Best Regards,
Donald.

I can certainly show a temperature.  In fact, I will probably end up showing a temperature in the HA component (see issue #12). I am not happy about it, though...

The honeywell api, as currently documented, does not expose this information.  Either for locations with a weather sensor (like yours), or for those who don't, but still get the 'outside' temperature displayed in the UI.

So, all I could do is poll another web api for that data.  I could even poll the same web api as does the EvoTouch.  Why should l though? HA does a good enough job of that already.

So you can’t pull the outside temperature out of the controller, local and remote.
Hmmmz


Feat/register with flow bjartek

I created a pr for my changes to your code here @highskore but just merge it in when you want. just for clarity.


APP: crash when attempting to mount dragon

Uncaught TypeError: Cannot read property 'getObjectByName' of undefined

Should be fixed now: https://webaverse.com/preview/46

Should be fixed now: https://webaverse.com/preview/46


gridftp

Hello,
We are trying to use a small subset of CMIP6 data from ESGF server.
They expose their NetCDF files in different ways
from pyesgf.search import SearchConnection
server='https://esgf-data.dkrz.de/esg-search'
conn = SearchConnection(server, distrib=True)
source_id='CMCC-CM2-HR4'
activity_id='OMIP'
experiment_id='omip2'
variable_id='vmo'
ctx = conn.new_context(
    project='CMIP6',
    source_id=source_id,
    experiment_id=experiment_id,
    variable=variable_id,
    frequency='mon',
)
result = ctx.search()[0]
files = result.file_context().search()
files[35].urls

Which gives
defaultdict(list,
            {'HTTPServer': [('http://esgf-node2.cmcc.it/thredds/fileServer/esg_dataroot/CMIP6/OMIP/CMCC/CMCC-CM2-HR4/omip2/r1i1p1f1/Omon/vmo/gn/v20200226/vmo_Omon_CMCC-CM2-HR4_omip2_r1i1p1f1_gn_200801-201812.nc',
               'application/netcdf')],
             'GridFTP': [('gsiftp://esgf-node2.cmcc.it:2811//esg_dataroot/CMIP6/OMIP/CMCC/CMCC-CM2-HR4/omip2/r1i1p1f1/Omon/vmo/gn/v20200226/vmo_Omon_CMCC-CM2-HR4_omip2_r1i1p1f1_gn_200801-201812.nc',
               'application/gridftp')],
             'OPENDAP': [('http://esgf-node2.cmcc.it/thredds/dodsC/esg_dataroot/CMIP6/OMIP/CMCC/CMCC-CM2-HR4/omip2/r1i1p1f1/Omon/vmo/gn/v20200226/vmo_Omon_CMCC-CM2-HR4_omip2_r1i1p1f1_gn_200801-201812.nc.html',
               'application/opendap-html')],
             'Globus': [('globus:4101e3a0-b7df-11eb-a16a-5fad80e6400b/esg_dataroot/CMIP6/OMIP/CMCC/CMCC-CM2-HR4/omip2/r1i1p1f1/Omon/vmo/gn/v20200226/vmo_Omon_CMCC-CM2-HR4_omip2_r1i1p1f1_gn_200801-201812.nc',
               'Globus')]})

We just need small subset of netcdf file, and I would like to make kerchunk catalogue of it.  I can use the HTTPServer link to transform it to kerchunk catalogue, but just out of curiosity, can it also handle 'ftp' or 'open dap' or 'gridftp' ?

yes, fsspec handles FTP, but it is generally a terrible protocol and I wouldn't expect it to work well
I don't know anything about gridftp
the opendap URL is HTML information from which you can construct an HTTP link to fetch parts of the target file. I don't think there's enough information there to be able to make a kerchunk reference set without scanning the target netcdf file. This effectively implements the "lazy" part of what kerchunk offers. I think this is backed by a server, unlike kerchunk, whose output is server independent.

I agree with Tina that being able to support GridFTP would be very nice. GridFTP is well known is some projects (such as Large Hadron Collider or ESGF) and it is a part of the few high- performance data transfer tools.

I have had a brief look around, and I can find one example of a python gridftp client, which is very old. Presumably, an fsspec backend could be built for it, and that would enable kerchunk and other remote access from python. However, most of what I find seems to refer specifically to Globus, as opposed to general gridftp, in which case presumably https://globus-sdk-python.readthedocs.io/en/stable/ provides everything needed (it looks very complicated!). In any case, the fsspec backend would require development, sorry.
Is anyone using IPFS or other similar technologies? IPFS does already have an fsspec implementation (ipfsspec).


My Article not Likeable anymore

hi when i try to like article getting problem
Type error: Argument 1 passed to Cog\Likeable\Services\LikeableService::addLikeTo()

Hello, @imsidz.
You haven't provided full debug, but I suppose that addLikeTo method receiving null or User instance without implemented \Cog\Likeable\Contracts\Likeable interface.
Could you provide more information? Does your user model implements Likeable interface?

i am trying to add likeable to movies model
here is model
<?php

namespace App;

use Ghanem\Rating\Traits\Ratingable as Rating;
use Nicolaslopezj\Searchable\SearchableTrait;
use Illuminate\Database\Eloquent\Model;
use Cog\Likeable\Contracts\Likeable as LikeableContract;
use Cog\Likeable\Traits\Likeable;

class Movie extends Model
{

    use Likeable;
    use SearchableTrait;
    use Rating;

here is controller
public function movielike($movie){
    	$movie = Movie::where('slug', $movie)->firstorfail();
        $movie->like();
        /**
        $user = Auth::user();
        $reward = 5;
        $currentreward = $user->reward;
        $user->reward = $currentreward + $reward;
        $user->save();
        **/
        return Redirect::back()->with('status', 'like Success');
    }

i think i am using same like documentation

@imsidz you've forgot to implement contract for Movie model.
<?php

namespace App;

use Ghanem\Rating\Traits\Ratingable as Rating;
use Nicolaslopezj\Searchable\SearchableTrait;
use Illuminate\Database\Eloquent\Model;
use Cog\Likeable\Contracts\Likeable as LikeableContract;
use Cog\Likeable\Traits\Likeable;

class Movie extends Model implements LikeableContract
{

    use Likeable;
    use SearchableTrait;
    use Rating;

Ohh Lol I Really Sorry For that its working fine after implements
thank you for making this dependency its more help full
hope you can rating system or reward system
thanks anyway

Glad it's working!
We have rating system and awards packages but they are not open source yet. Maybe in near future :wink:


Improve safety and UX of setPath script

The script will not work as expected if it is not run inside of the ./build directory. It should be improved or check for this case and exit if in an unexpected state.
Similarly, the script should check for root access and exit if not run as an elevated user.

Closed due to anticipated changes to deployment process.


Unable to connect via Connect-SnipeitPS

Context
After updating to the current version of the module, unable to log into the API
Your Environment

SnipitPS Module version used: 1.10.213
Operating System and PowerShell version: Windows 10, PS 5.1.19041.1320
Snipe It version: v5.3.5 - build 6558
SnipeIT is setup to use SAML Authentication, but otherwise everything is configured according to SnipeIT Documentation Best Practices

Current Behavior
Unable to log into SnipeIT API using Connect-SnipeitPS
Connect-SnipeitPS -url $url -apiKey $secret -Verbose
VERBOSE: Testing connection to https://dns_name.
VERBOSE: [ConvertTo-GetParameter] Making HTTP get parameter string out of a hashtable
VERBOSE: [Invoke-SnipeitMethod] Invoking method Get to URI
VERBOSE: GET https://dns_name/api/v1/statuslabels?limit=1 with 0-byte payload
VERBOSE: [Invoke-SnipeitMethod] Failed to get an answer from the server
VERBOSE: [Invoke-SnipeitMethod] Status code: Unauthorized
VERBOSE: System.Net.HttpWebResponse
VERBOSE: Status:
VERBOSE: Messages:
VERBOSE: [Invoke-SnipeitMethod] Function ended
VERBOSE: Connection to https://dns_name tested succesfully.

There's line "Status code: Unauthorized"  , I would start by rechecking api-key stored in $secret variable.

And yes, Connect-SnipeitPS should return error in cases like this. I'll write a fix for that.

There's line "Status code: Unauthorized" , I would start by rechecking api-key stored in $secret variable.

I've re-generated my API Token a couple of times and still meet the error. Has it changed how the API Token should be generated? I was using the instructions from here - https://snipe-it.readme.io/reference/generating-api-tokens

I only know that way to genarate api keys. In what group user account that generated api key is?  (look at your.site/admin/groups)
Connection check is making request to site/api/v1/statuslabels, maybe that could fail if  user does not belong to group with access to view status labels?

To test if this is permission issue, you can try try to run following commands:
Get-SnipeitStatus  -url $url -apiKey $secret -verbose

and then
Get-SnipeitAsset  -url $url -apiKey $secret -verbose

if just first command fails , your api user does not have right permissions. If both fails your api key is wrong or corrupted.

No activity, closing this

If anyone comes accross this same issue, it was a issue with my Apache Site Config. In my  i had AllowOverride None, I changed it to AllowOverride All and did a restart of Apache2 and the issue was fixed


Added impl of ToTokens for tuples

I find myself frequently wanting to quote! { … #tuple … }.
This PR implements ToTokens for (A) to (A, B, C, D, E, F, G, H, I, J).

Ugh, acted to soon. Guess I can close this already. 🤦🏻♂
https://github.com/dtolnay/quote/issues/54#issuecomment-359147428


Feature/2021 prefrosh

There's two main changes here:
One is to move prefrosh images from the database to a folder on the server. This makes your life easier when you realize "oh shit, I forgot to rotate this one prefrosh's image". The downside is that they have to be stored somewhere. Pretty sure I did it right, but I'm def looking for feedback on that part. That's going to require a config change on the server, but it shouldn't be too hard.
The other is reflecting the changes we made to bucketing. Namely: drop 000 bucket and use a single +1 dummy vote. Plus now there's a button do all that automatically, so you don't have to do the averages yourself.
The code's pretty messy, but rotation is coming soon, so, better messy than absent, I guess.

Changes that would need to be run against the DB:

add the prefrosh records (but we have to do that anyways)
alter the schema of rotation_prefrosh as per the commit (no records in there to mess up though)
drop the 000 bucket from the rotation_buckets table

DK and I talked about where to store the images last year and we decided it didn't really make a big difference, so I went with the database route since it was easier. I don't have a strong preference either way as long as it still works.
It doesn't look like you've changed the setup script (stored in scripts/rotation_setup.py), so you should do that and test it. Apart from that everything you've written looks reasonable.
I like the button to compute buckets, definitely an improvement from how I did it last year.

It looks like you will need to modify scripts/rotation_setup.py as it still assumes the use of the 000 bucket and it still tries to add the image into the database.

Alright, updated rotation_scripts.py.
Sid reminded me that I have to update config.py on the server, to add a media folder. Any thoughts on where to put it? I'm not super familiar with the layout, nor can I investigate too much. It seems ruddweb has a homedir, that might work?

Alright, updated rotation_scripts.py.
Sid reminded me that I have to update config.py on the server, to add a media folder. Any thoughts on where to put it? I'm not super familiar with the layout, nor can I investigate too much. It seems ruddweb has a homedir, that might work?

I think that's a good place to put it.

Yeah other than the magic constant it looks good

Alright, changes made.
I guess the deployment plan is:

PR goes through; website code is updated.
Make the schema change to ruddweb; I can safely drop the table because it's empty. (I'll do it in a transaction though to avoid accidents.)
Add media folder attribute to config.py, and make the corresponding folders.
Move prefrosh pictures into said folder.
Run rotation.py to get the prefrosh names/images in the DB.
Ask Gene, Rupesh, or an IMSS rep to look it over and make sure it's all working.
Clear any changes that happened during testing.

Sound good?


NeoForge port or Sinytra Connector support?

The feature
Do you plan on porting this mod to NeoForge or making it compatible with Sinytra Connector? If not, why?
Checklist

[X] I checked the issues(both open and closed) and could not find a duplicate of my feature

Duplicate of #477

Its sad to see that a neoforge version isn't being planned, i know that the first guy who suggested a neoforge port was being extremely rude, and i can understand closing the first issue made due to that, but i dont think thats a valid reason to write off the rest of the neoforge port suggestions that people have been making, especially since this mod is pretty vital to being part of the optifine replacement that minecraft still needs. Would be great if this issue could be opened back up and this one made the new main issue so discussion could continue. Please reconsider, CIT devs, thank you very much for reading.

If I wanted to develop a neoforge version I would've done so already.
Neat part about licenses and open source projects is that you can make it yourself if you want it that bad.
Just like when people spam about versions, this has become a nuisance as well. Locking this


Improve UI loading bar

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 44.62%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
737

Relevant Lines:
1528

💛  - Coveralls


Make the app DPI aware

Currently, if a monitor with high DPI is used, UI scaling is enabled by default in Windows.
This blurs the whole app or it can break its control positions.
Additionally, update Win SDK, to support DPI awareness per monitor v2.

Support for 120dpi (125%) is ready.
Try to fix some txtboxes for 144dpi (150%)

Done!


"LOGIN_FIELD" changes the "User create" endpoint

First thanks for this library, it is super easy for beginners.
I use the default django User model (username, email, password required). When I set "LOGIN_FIELD" to "email" the user creation doesn't work anymore because djoser doesn't accept a "username" field, which is obviously required in the default django User model.
Probably, I'm somewhere wrong...
Update 1
For testing I set "USER_ID_FIELD": "username",. This changes the fields in djoser's UserCreateSerializer  to ('email', 'email', 'username', 'password'). Nevertheless, /users/ does not accept "username" in POST requests

Facing the same issue.

Even though username is sent in the request body, the response says username is required

I didn't try it on the default user model. It didn't change my endpoint when I used the custom user model, but I do receive the above error while accessing endpoints. I resolved it by generating a username in the custom user manager.

I second this bug.


Feature/20 cookie banner styling

This PR aims to apply basic GOV.UK stylings to the Civic cookie banner. This is primarily limited to typography and buttons.

Looks good 👍.
It's also worth us updating the fill colour of the button that toggles visibility of the UI. We can use the same colours — resting and hover — as the search form button on this GOV.UK page.

Good should - have made some changes


Add link metadata

Description
#24

Looks like a good set of changes, but unit tests failed:
https://github.com/hhio618/arklib/actions/runs/3066154097

Superceded by #30


compile under noetic

I wanted to work with ibeo_lux under ROS noetic and recognized that the code requires to be build at least with c++14.
I in the ibeo_lux CMakeList.txt to change the compile options to:
add_definitions(-std=c++14 -Wall -Wextra -DBUILD_ROS)
In order to make this code build under noetic I also changed the compile options for ibeo_core in CMakeList.txt to:
add_compile_options(-std=c++14)
I generated also an issue for ibeo_core.
It would be nice if someone can take take of this to enable working under noetic. :-)
Regards
Bernd

Hi @ace-at-git, thanks for sharing your findings!
Feel free to open a PR if you like, this driver is no longer actively maintained, but small changes like the ones you mention are easy to review and merge.


Ignore later NIX_PATH entries completely and lazily

Previously, duplicate NIX_PATH were all traversed and imported,
influencing which channels are listed as discovered, even though in normal use
you could only access the first duplicate.
This change cleans this up, making sure that only the first NIX_PATH
entry is discovered as a potential channel. This is also how the
standard <path> expression works.
This notably also removes some potentially confusing trace lines with --arg debugVerbosity 1

[x] I have created a test to cover the new behavior.
[ ] I have written and updated relevant documentation, including updating this
pull request template if necessary. Note that we try to follow the
Divio documentation of documentation.

I'm also just thinking that channel discovery should be revamped in a different way. Instead of looking at NIX_PATH, we should look at the root channels channels.json file (which specifies the channels it depends on), import all those channels via NIX_PATH directly, and do that recursively. This should also allow ensuring that only the channels declared in channels.json can be accessed.

Not relevant anymore with #47


[ODS-5362] Use dotnet --list-runtimes to ensure that dotnet is installed

Add Get-DotnetRuntimes function that returns current dotnet runtimes in a table
Update Test-PostgreSQLBinariesInstalled to check if psql command is available
Update Install-NuGetCli to check if mono command is available
Update Get-AncestorItemPath to be more unix-friendly, removed searching for windows slashes
Update Test-DotNetCore to use Get-DotnetRuntimes to test for required dotnet runtimes

@AxelMarquez I have no idea why these tests would fail with PowerShell changes. Can you help us understand what might be going wrong? Feel free to pull in someone else from the team if it makes sense to do so.

The build issues also affected main, they are now fixed, please merge main into your branch to bring the fix.

Rather, please rebase from main so that there is no merge commit.


Allow different icons per platform

Adds props "ios", "android" & "macos" to specify an icon for each platform. "name" can still be used for all platforms, or as a fallback.
Usage:
<Icon android={"md-eye"} ios={"ios-eye"} size={20} color={"white"} />

Hi,
Thanks for your PR. Couldn't this be solved by Platform.select?

Closing due to inactivity.


cannot download pdf

error code
Downloading metadata and eText information...
Traceback (most recent call last):
File "downloader.py", line 217, in
main(sys.argv[1])
File "downloader.py", line 88, in main
pageInfo = pageInfo[0]['pdfPlayerPageInfoTOList']
KeyError: 0

I also encountered the same problem :(
any fix to this?

Hi, what type of URL do your books have? This downloader (at the moment) only works on certain books, an only on books that have numerical IDs.

This is the link(X assumes any value):
http://view.ebookplus.pearsoncmg.com/ebook/launcheText.do?
bookID::114833
globalBookID::CM30238178
userID::XXXXXX
sessionID::ST-184XXX-Ir0FkMRbOWKXXXXXXXXX
smsUserID::ffffffffXXXXa6868d46f25f1ce7XXXX
uid::201X0X0XXXXXXX::
ubd::201X0X0XXXXXXX
ubsd::201X0X0XXXXXXX
hsid::XXXXX6c67cd6a7XXX2130d55e534XXXX

The script should work for that book type, and as of the latest commit, you only need the bookId to download the book. Go ahead and give it a try, and let me know if there are any issues, but otherwise this issue will be closed for now.


question 53

I wonder if the answer
fixed term -- as long as funding is available
makes sense
Maybe the two fixed term answer should just be
fixed term
alternatively, this could change to
fixed term -- funded by project funds

see https://github.com/softwaresaved/international-survey/issues/195

I think swapping from "fixed term -- as long as funding is available" to "fixed term -- funded by project funds" is a good proposition.  I think the german translation already does that

Yes,  the German translation already does that.


Experiment/event hub for node #2

[ ] I have added automatic tests where applicable
[ ] The PR title is suitable as a release note
[ ] The PR contains a description of what has been changed
[ ] The description contains manual test instructions

Changes

Test

Closing this, and continuing discussions in #90


jasypt-spring-boot-starter causes error when trying to deploy to weblogic 12c

Hi,
I'm building a spring boot war file and trying to deploy it on weblogic 12c and it throws following error.
Unable to access the selected application.
Message icon - Error String index out of range: 4513
Message icon - Error String index out of range: 4513
Message icon - Error String index out of range: 4513
I'm using:
spring-boot-starter-parent : 1.5.21.RELEASE
jasypt-spring-boot-starter : 2.0.0
weblogic : 12c
This my application.properties

Can't tell without more detailed stack trace and/or a sample app. Any more details?

closing due to inactivity. re-open if you're still having issues


Ignoring a certain error by matching a regexp

I'm working on a kernel driver. The kernel has a specific build system and provides linux/module.h. This file is not present in the include path, so when one tries to compile the file with gcc, the linter complains:
 linux/module.h: No such file or directory

I know that this one will work in the real build, so I'd like the linter to ignore any include errors of linux/module.h. Is it possible?

This is not a linter-gcc issue. An error like that can be easily suppressed by creating an empty file, or copying the correct file to that location.


Add signal handler to log signals in SupportedServerStartable

It looks like @rajinisivaram hasn't signed our Contributor License Agreement, yet.

The purpose of a CLA is to ensure that the guardian of a project's outputs has the necessary ownership or grants of rights over all contributions to allow them to distribute under the chosen licence.
Wikipedia

You can read and sign our full Contributor License Agreement here.
Once you've signed reply with [clabot:check] to prove it.
Appreciation of efforts,
clabot

[clabot:check]

@confluentinc It looks like @rajinisivaram just signed our Contributor License Agreement. :+1:
Always at your service,
clabot


Activated setPsram() support for Sprites

This PR makes sprite.setPsram() work as expected (see #30 )
Other changes in createSprite():

removed macros:
#if defined(ESP32) && defined(CONFIG_SPIRAM_SUPPORT)

used heap_caps_calloc instead of calloc to force memory type

Thank you for your help, Merge


restart if lost pid

add pid arg to starter.sh.
monitor the pid, restart it if lost pid in 5 time

unlike warn + WARN_RUN, the live,

only watch the pid
just start if pid lost
except stop to stop, ie. after start

version 2013-03-03