cmake-presets attribute toolset gets ignored when generator attribute is empty

Brief Issue Summary
In our project we are using Visual Studio generators in order to generate cmake project with VS2017 compilers (V141 toolset). In other words, across the team we have different versions of Visual Studio ranging from 2017 to 2022 with only one common denominator and that is target Visual C++ toolset. In our case it is V141 which are VS2017 compilers. So users normally generate their solutions by omitting -G flag and just providing -T v141 and -A x64 flags. Cmake will handle the rest and find compatible Visual Studio.
Now I have a configure-presets that inherit this:
{
  "name": "MSVC_x64",
  "hidden": true,
  "description": "Default MSVC 141 x64 preset",
  "toolset": {
    "value": "v141",
    "strategy": "set"
  },
  "architecture": "x64"
}

This works great when cmake configure is executed from console (cmd.exe). CMake correctly identifies that my generator is VS2022 since its the only Visual Studio I have installed on my PC. I can see from cmake logs that proper version of C/C++ compilers is selected (V141 toolset).
Now when I configure the same preset from VSCode via cmake tools extension, no matter what always the latest C/C++ compilers are taken from VS2022 (V143 toolset). Even if I put some random string garbage for toolset value, cmake cmake tools would still configure with VS2022 compilers.
Only if I provide specific generator to CMakePresets.json file, in my case "Visual Studio 17 2022", toolset attribute starts working and cmake project with correct compilers gets generated. This looks like a bug to me since cmake itself can handle that by no issue. Or am I missing something?
CMake Tools Diagnostics
{
  "os": "win32",
  "vscodeVersion": "1.95.1",
  "cmtVersion": "1.19.52",
  "configurations": [
    {
      "folder": "d:\\eSmart\\_P-eSmart\\trunk",
      "cmakeVersion": "3.30.3",
      "configured": true,
      "generator": "",
      "usesPresets": true,
      "compilers": {}
    }
  ],
  "cpptoolsIntegration": {
    "isReady": true,
    "hasCodeModel": true,
    "activeBuildType": "Debug",
    "buildTypesSeen": [
      "Debug",
      "Release",
      "MinSizeRel",
      "RelWithDebInfo"
    ],
    "requests": [],
    "responses": [],
    "partialMatches": [],
    "targetCount": 632,
    "executablesCount": 91,
    "librariesCount": 220,
    "targets": []
  },
  "settings": [
    {
      "communicationMode": "automatic",
      "useCMakePresets": "auto",
      "configureOnOpen": false
    }
  ]
}

Debug Log
No response
Additional Information
No response

Hi @m1lhaus , thanks for reporting issue here!
We try to reproduce your issue on our side with cmake tools extension v1.19.52 + cmake version 3.29.5-msvc4, however we get the same result when cmake configure is executed from console (cmd.exe) and from VSCode via cmake tools extension, C/C++ compilers are taken from VS2022 (V143 toolset). Please see the test result as below:
cmake configure is executed from console (cmd.exe)

cmake configure is executed from  VSCode via cmake tools extension

As you said above, after added "generator": "Visual Studio 17 2022" to CMakePresets.json file, C/C++ compilers are taken from V141 toolset.

Hello @Amy-Li03, well I get different result:

In both cases I am executing my only preset. See code snippet bellow. Also I am bit skeptical about how you are running it from the console. I can't see you explicitly calling a preset.
This would be my dummy code I can share
{
  "version": 9,
  "cmakeMinimumRequired": {
    "major": 3,
    "minor": 30,
    "patch": 0
  },
  "configurePresets": [
    {
      "name": "Base",
      "hidden": true
    },
    {
      "name": "MSVC_x64",
      "hidden": true,
      "description": "Default MSVC 141 x64 preset",
      "toolset": {
        "value": "v141",
        "strategy": "set"
      },
      "architecture": "x64"
    },
    {
      "name": "MQB_MEB",
      "hidden": true,
      "description": "Base MQB_MEB preset"
    },
    {
      "name": "ALL",
      "hidden": true,
      "description": "Base ALL preset"
    },
    {
      "name": "ALL_MQB_MEB",
      "description": "Base ${presetName} preset",
      "inherits": ["Base", "MSVC_x64", "ALL", "MQB_MEB"],
      "binaryDir": "${sourceDir}/000_bin_preset/build"
    }
  ]
}

Hi @m1lhaus , thanks for your quick response!
After using command: cmake --preset ALL_MQB_MEB, C/C++ compilers are taken from V141 toolset when cmake configure is executed from console.

@gcampbell-msft I can repro customer's issue: when generator attribute is empty, C/C++ compilers are taken from V141 toolset when cmake configure is executed from console(cmake --preset ALL_MQB_MEB), but they are taken from VS2022 (V143 toolset) when cmake configure is executed from VSCode via cmake tools extension.
I'm not sure if this is a feature request or a bug?

@m1lhaus Yes, this does seem to be a bug based on the command-line behavior and the CMake Presets spec. The only time this wouldn't be a bug would be if you're using a presets version prior to v3, but even then, we would require the generator field, so therefore this is definitely a bug and we will mark/treat it as such.
Thanks!


Add documentation on how to modify the bindings, from OCaml to wasm/js

Important note: if more than 5 parameters, a bytecode symbol must be defined in bindings.js, calling the "native" symbol, like here

Other important note: when a Rust function uses parallelism and we add a new parameter, we need to add the correspondig value in worker-spec


[OTHER]

What would you like to share?
I have looked into the readme section of the repository and i happen to figure out that some of the code block aren't aligned as they should apppear.

As in above image we can see the align of the code blocks of 4 isn't aligned properly.
Additional information
No response
👀 Have you checked if this issue has been raised before?

[X] I checked and didn't find similar issue

🏢 Have you read the Contributing Guidelines?

[X] I have read and understood the rules in the Contributing Guidelines

Are you willing to work on this issue ?
Yes I am willing to submit a PR!

Keep in mind this won't count for hacktoberfest

@Dun-sin sure, please asign me

@Dun-sin sure, please asign me

Ok, thanks for wanting to contribute, Make sure you follow the rules 👉🏽here👈🏽, else your PR will not be accepted and will be closed. Good Luck


[Bug]: IFC files with spatial reference systems (and/or georeferenced)

What happened?
Hi,
I am using the library to convert an IFC file which has a spatial reference system & georeferenced to fragments group. The resulting fragments group seems to be appearing at the correct place but with the wrong orientation. But I cannot find any documentation regarding this support. So I wonder, is this a bug that supposed to be working? Can you please share what is coming from the library and what is not so that we can understand what we should be doing to support IFC files with spatial reference systems and/or georeferenced?
Thanks
Version
0.0.56
What browsers are you seeing the problem on?
Chrome
Relevant log output
No response
Anything else?
No response

Hi @agviegas & @beachtom,
I created one small reproducible example that hopefully will help us. Here is the small project -> https://drive.google.com/file/d/1A6CWnooy9Yp_eVC9H3nNO_V8UU75umT6/view?usp=sharing
The imports you see on the file are referring two files that I already shared above
import ifcPath from './assets/HQ.ifc';
import ifcPath2 from './assets/HQ_georeferenced.ifc';

Georef -> https://drive.google.com/file/d/1R-mR17RH20AJ-2E6djFOUUxg9THLSPui/view?usp=drive_link
Without georef -> https://drive.google.com/file/d/13QEY3arAjrYe49Wfp5P6uGv5nQrIstlM/view?usp=sharing
Those two files are basically the same, but their only difference is georeferencing information(IfcProjectedCrs & IfcProjectedCrs).
Try loading one or another by commenting out either lines 50 OR 51. You will realise one of the models will not appear on scene origin. Can you please help me understand which library is causing this difference and how?
I am looking forward to hearing back.
Thanks!

Hey @onderilkesever I think we alredy discussed this here. By default, web-ifc (our core IFC library) positions the model according to the IFC spatial structure. When using COORDINATE_TO_ORIGIN, the library takes the first vertex of the first geometry that it finds and brings it to the origin (0, 0, 0) to prevent nummerical stability issues. This generates a coordinationMatrix that you can use to align multiple models together. Of course, if COORDINATE_TO_ORIGIN=false, then models that were aligned in the authoring app and correctly exported should be aligned automatically.
As for this specific case, I believe the cause behind the difference in the rotation is the orientation of the IFCGEOMETRICREPRESENTATIONCONTEXT, which you can see in the screenshot below.

Closing this as I believe the library is working as expected, but feel free to ping me and I'll be happy to solve any remaining questions/doubts.


Mutually dependent classes not (really/always) working

How to define mutually dependent classes with the IJava kernel?
When I put them in the same code cell, it doesn't work. And when I put them in different cells, it doesn't always work, and needs multiple executions.
For example, the following code won't execute (compile) when put in a single cell (also not when switching the order of the class definitions):
class C {
    D d;

    C() { d = new D(this); }
}

class D {
    C c;

    D(C c) { this.c = c; }
}

You get an error message for class C:
 Unresolved dependencies:
   - class D

If you put them in separate cells, then executing the first cell (with class C) gives an error message:
Unresolved dependencies:
   - class D

Now, the second cell (with class D) can be executed without errors. And after that, also the first cell will execute, and both classes seem to work as expected.
You can also first execute class D, giving rise to the error message
Unresolved dependencies:
   - class C

after which class C executes, and then also class D executes.
Unfortunately, in my case the class definitions are a bit more involved, and this approach does not work.
Any suggestions for a workaround?
In a jshell this works, though you get a notification stating:
|  created class C, however, it cannot be referenced until class D is declared

I had hoped that IJava would behave similarly.

How to define mutually dependent classes with the IJava kernel?

I find this annoying too, There is a workaround though. Define empty classes first and then add their methods.


Discord JS Install not working

I keep getting this i cant find anything about it.
it happens when i want to install discord.js in cmd
npm ERR! code EISDIR
npm ERR! errno -4068
npm ERR! syscall read
npm ERR! EISDIR: illegal operation on a directory, read
npm ERR!      C:\Users\PRIVATE\AppData\Roaming\npm-cache_logs\2017-07-16T18_57_49_970Z-debug.log

That's an npm error, not a discord.js error, and is out of scope of our issue tracker.


Add comment not to use 'latest' in docs

Description
Add a comment to the docs explaining to the user not to use latest' as per request from @ciberkleid in #2977.
Hey @ciberkleid there's a few reasons we keep latest out of sync and only for development.
From @joshrosso  in #2977
Without going into all of them, the primary limitation is how our hosted-harbor instance caches the :latest tag at the CDN level. It leads to non-deterministic resolution of :latest as it can resolve to different underlying images depending on the region of the world you are in. For this reason and a few others, we highly recommend not using latest for resolving the TCE package reposioty.
From @ciberkleid in #2977
I would turn this into a documentation request... I think it would be helpful if the docs were explicit about discouraging the use of latest and providing info on where to verify what the latest version is. If other users are like me, the question will come up in their minds when they come to that section of the docs (point 2 above), so it would be good to have the answer there and save the user the doubt and discovery effort.
Location

Additional Context

@ciberkleid
Hi Cora
The version is kept dynamically up to date in multiple locations in the doc. Is the ask here to add a note in each of these locations to not use latest -as I think this could get clunky ?
The version (dynamic) appears in these topics:
Work with Packages
https://tanzucommunityedition.io/docs/latest/package-management/
Installing a Package in the Getting Started guide
https://tanzucommunityedition.io/docs/latest/getting-started/#installing-a-package
Tanzu Community Edition Installation in the Getting Started guide for Windows, Mac, and Linux
https://tanzucommunityedition.io/docs/latest/getting-started/#tanzu-community-edition-installation

Moving to icebox until we get follow-up. Thanks!

Hi, sorry... this got lost in my inbox :(
Yeah, I think it's very common to assume you can use latest and if we
cannot ensure that the image tagged latest is safe for use, then we
should make a concerted effort to be really clear about it.
On Fri, Mar 4, 2022 at 3:24 PM joshrosso @.***> wrote:

Moving to icebox until we get follow-up. Thanks!
—
Reply to this email directly, view it on GitHub
https://github.com/vmware-tanzu/community-edition/issues/2977#issuecomment-1059497242,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAZFAZ27T5XLFY7IHR4OJBLU6JWRBANCNFSM5NGSRSHQ
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you were mentioned.Message ID:
@.***>

Thanks @ciberkleid!
Would you be interested in making the contribution to our docs?
For now, we'll leave this as help wanted in hopes it'll get picked up from someone.
Thanks!


No artifact recieved after update 0.3.0

Hello Maester community! I have a question/problem with artifacts. After updating to the latest version 0.3.0 i no longer recieve an artifact after running Maester as an action.
I am using the given Maester as an Action script, with the modification of adding "mail_userid" and "mail_recipient".
jobs:
  run-maester-tests:
    name: Run Maester Tests
    runs-on: ubuntu-latest
    steps:
    - name: Run Maester action
      uses: maester365/maester@main
      with:
        client_id: ${{ secrets.AZURE_CLIENT_ID }}
        tenant_id: ${{ secrets.AZURE_TENANT_ID }}
        include_public_tests: false # Optional
        pester_verbosity: 'None' # Optional - 'None', 'Normal', 'Detailed', 'Diagnostic'
        mail_userid: 'example.userid'
        mail_recipients<EMAIL_ADDRESS>
From the run logs, the parameter "artifact_upload" returns "true", but when looking through the summary there is no artifact.
I have attempted adding the "artifact_upload" parameter and manually setting it to "true" without any results. I have also tried to remove "mail_userid" and "mail_recipients" but still no artifact.
If anyone has any tips or info that could explain this issue to me i would be very grateful. If this does not qualify as an issue, i can post it in the Discussions forum instead.

Do you see the .html file being created?

I compared my latest Maester run with a previous one which did produce an artifact, and the "actions/upload-artifact@v4" is skipped completely. However, right before displaying how many tests were run, passed and failed, it does seem like the .html is being created.
🔥 Maester test report generated at test-results/test-results.html

Tests Passed ✅: 74, Failed ❌: 39, Skipped ⚫: 22

Script execution Complete

@f-bader Could this be an issue with Github Action not uploading the artifact?

Will check if there is a fail or something that prevents this. Should not happen

Could this be related to https://github.com/actions/upload-artifact/releases/tag/v4.4.0

We will no longer include hidden files and folders by default in the upload-artifact action of this version. This reduces the risk that credentials are accidentally uploaded into artifacts. Customers who need to continue to upload these files can use a new option, include-hidden-files, to continue to do so.

This does seem like it could be whats causing this issue.
I am not well versed in testing and contributing to open source projects, but i assume an edited version of the "action.yml" file that looks like following could fix the issue.
- name: Archive Maester Html Report
      uses: actions/upload-artifact@v4
      include-hidden-files: true # Upload artifact to action summary
      if: ${{ inputs.artifact_upload == true }}
      with:
        name: maester-test-results-${{ env.NOW }}
        path: test-results


FR: Test grouping or references across testing subtrees

I wanted to see if what people thought of some sort of grouping item for tests or some way to have tests that reference an item from another test item subtree.
Specifically, this is for grouping tests into suites, e.g.
* TestClass
  * testMethod1
  * testMethod2
* Integration Tests
  * <reference to TestClass>
* End-to-end Tests
  * <reference to TestClass>

Currently, I implement these as dummy vscode.TestItem's and if you run the reference item I start a second test run to actually run the test and just mark the reference item as pass/failed based off the inner test run.
However, this strategy does have some odd interactions with the testing UI, for example the test history peek view has a lot of extra items and using the 'Run all' buttons does end up running the same tests multiple times (I'm working on de-duping that logic internally).
I tried seeing if I could tweak the include filter before creating the test run but it seems the list of included test items is capture before the request is created so modifying the include isn't applied when the test run is created.
I have also considered use a tag for the suite's grouping but its less discoverable, although that does simplify things a good bit.

This is a functional goal of test tags, it sounds like you want an additional different visualization of them.

After thinking about it more, I think I am going to convert my suite's into tags.
Could the hover text for a vscode.TestItem include the list of tags that are on the item?

:slightly_frowning_face: In the last 60 days, this feature request has received less than 20 community upvotes and we closed it. Still a big Thank You to you for taking the time to create this issue! To learn more about how we handle feature requests, please see our documentation.
Happy Coding!


Update model to ixr10e

@cfernanz should that be done for all textprotos?

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Warning: This coverage report may be inaccurate.
This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

For more information on this, see Tracking coverage changes with pull request builds.
To avoid this issue with future PRs, see these Recommended CI Configurations.
For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 55.5%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
1983

Relevant Lines:
3573

💛  - Coveralls

@cfernanz should that be done for all textprotos? edit: cc @alexmasi

Yes it should be done for all protos assuming ixr10e is the intended FP test compliant model from Nokia. If ixr10 passes some FP tests and ixr10e passes others then there needs to be a larger discussion here.

assuming ixr10e is the intended FP test compliant model from Nokia.

yes, that's correct

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Warning: This coverage report may be inaccurate.
This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

For more information on this, see Tracking coverage changes with pull request builds.
To avoid this issue with future PRs, see these Recommended CI Configurations.
For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 55.5%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
1983

Relevant Lines:
3573

💛  - Coveralls

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 55.5%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
1983

Relevant Lines:
3573

💛  - Coveralls

Thanks Marc, Alex and Sergey!
updated model to ixr10e for all textproto

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 55.5%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
1983

Relevant Lines:
3573

💛  - Coveralls

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 55.5%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
1983

Relevant Lines:
3573

💛  - Coveralls

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 55.5%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
1983

Relevant Lines:
3573

💛  - Coveralls

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 55.5%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
1983

Relevant Lines:
3573

💛  - Coveralls

@cfernanz some of the files have 2 DUTs and thus need two lines changed to the new model name

Pull Request Functional Test Report for #3099 / 089f35a5290e7972bc1a9e1636d5f95e45bf7d80
No tests identified for validation.
Help

Thanks Alex. Updated textproto with 2 duts

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Warning: This coverage report may be inaccurate.
This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

For more information on this, see Tracking coverage changes with pull request builds.
To avoid this issue with future PRs, see these Recommended CI Configurations.
For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 55.5%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
1983

Relevant Lines:
3573

💛  - Coveralls

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Warning: This coverage report may be inaccurate.
This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

For more information on this, see Tracking coverage changes with pull request builds.
To avoid this issue with future PRs, see these Recommended CI Configurations.
For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 55.5%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
1983

Relevant Lines:
3573

💛  - Coveralls

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 55.5%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
1983

Relevant Lines:
3573

💛  - Coveralls

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 55.5%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
1983

Relevant Lines:
3573

💛  - Coveralls


Improve isImage() check

Pull Request Etiquette

[x] I have checked the PRs for upcoming features/bug fixes.
[x] I have read the contributing guidelines.

Changes

[x] Internal code
[ ] Library interface (affecting end-user code)
[x] Documentation
[ ] Other: _____

Closes Issue: #1071
Description
Improve isImage() check by using image pattern.

I would make that pattern a constant of the Message interface or at least not make it a local variable, since it never changes. That way it wouldn't need to be compiled for every call and users may utilise it, too.

You can make it static final, there's no need to create a pattern for each instance.

This will not work (reliably) if the attachment has had its file extension changed.

A way around this would be to check width > -1 (or height, I guess. JDA returns -1 if the attachment is not an image, assuming JDA pulls this information straight from the Message object itself), along with a file extension check (or if you're feeling super confident, parse the image contents and detect file type).
Lastly, there are more image types out there than what the regex supports, unless this is only intended to support images that Discord can embed.

As already stated, a regex would be a really slow solution to this problem. Also, the width and height should still be checked (in addition to whatever is used to separate images from video) to ensure that the image is actually being shown.

We should consider adding Attachment#getFileExtension() and use that in this PR
Attachment#isImage()should first check if there are width / height values before doing the additional extension check.
The extension check should not use Regex.

Why would you all firstly check for width and height and not just the extension check? Isn't it kinda useless?

Because as per the discord docs, width and height properties exist for attachments that are images. Checking those properties first would be a "less expensive" operation and then the extension check would serve as an extra step to ensure it's an image and not a video (although, I'm not sure if Discord sends width/height properties for videos so even the extension check might be useless here?)

The extension check is not useless because extensions don't determine the file format, just how it's displayed by Discord.
I.e. if you do not check the extension, someone could upload a raw text file with a .jpg extension and this method would return true.
From what I understand, even with the extension check it's not 100% safe yet, since someone still could upload a video with an image extension. But it seems like the reasonably closest we can get.

You can send a txt file disguised as a jpg/png/whatever and Discord will not send width/height properties for it (they will be null, or in JDA's case, -1), so this is not a problem.
However, I have just checked to see if the width/height properties exist for videos, and they do.
So the width/height check just checks if the attachment is a video/image, and the extension check would serve to filter out videos. Though, it is worth mentioning that videos disguised as images by changing the extension, will still have width/height properties. End result is that this proposed check will still return a false positive in this case.

This is really confusing and I have no idea of reliable check.

At the end of the day, we can only provide as much security as we are given. We can ensure it is at least something that is visually displayable via the width and height checks, and we can attempt to provider a further restriction by using file extension checking, but at the end of the day, if it really really matters

@caneleex looks like you deleted your branch, I assume you don't intend to continue working on this PR then? In that case could you close it so someone else can give it a shot.
Thank you for your contributions.

I think that this PR doesn't solve the reliability of the check and someone could've done it better; so yeah, I will close the PR and let someone other try to solve it. I also think this isn't very easy to fix as obviously there is no 100% reliable fix.


Cow: Watch talktostopandshopo.boats

Cow requests the watch of the watch_keyword talktostopandshopo\.boats. See the MS search here and the Stack Exchange search in text, in URLs, and in code.

talktostopandshopo\.boats has been seen in 1 true positive, 0 false positives, and 0 NAAs.

Approved by Dragonrage in Charcoal HQ


Image component not working electron macOS

Summary
I create a basic image component which I wanted to view on the electron app app. however the image doesn't show but shows up when I run it on web, android and iOS.
Environment
Expo CLI 4.3.4 environment info:
System:
OS: macOS 10.15.7
Shell: 5.7.1 - /bin/zsh
Binaries:
Node: 14.16.0 - /usr/local/bin/node
Yarn: 1.22.5 - ~/.yarn/bin/yarn
npm: 7.8.0 - /usr/local/bin/npm
Watchman: 4.9.0 - /usr/local/bin/watchman
Managers:
CocoaPods: 1.10.1 - /usr/local/bin/pod
SDKs:
iOS SDK:
Platforms: iOS 14.4, DriverKit 20.2, macOS 11.1, tvOS 14.3, watchOS 7.2
Android SDK:
API Levels: 23, 28, 29
Build Tools: 23.0.1, 28.0.3, 29.0.2, 29.0.3
System Images: android-28 | Google Play Intel x86 Atom, android-29 | Google Play Intel x86 Atom
IDEs:
Android Studio: 4.1 AI-201.87<IP_ADDRESS>99119
Xcode: 12.4/12D4e - /usr/bin/xcodebuild
npmPackages:
@expo/webpack-config: ^0.12.65 => 0.12.65
expo: ~40.0.0 => 40.0.1
react: 16.13.1 => 16.13.1
react-dom: 16.13.1 => 16.13.1
react-native: https://github.com/expo/react-native/archive/sdk-40.0.1.tar.gz => 0.63.2
react-native-web: ~0.13.12 => 0.13.18
npmGlobalPackages:
expo-cli: 4.0.17
Expo Workflow: managed
Please specify your device/emulator/simulator platform, model and version
macos 10.15.7
Error output
there's no error output, picture doesn't show.
Reproducible demo or steps to reproduce from a blank project
import { StatusBar } from "expo-status-bar";
import React from "react";
import { Text, Image, View, ImageBackground } from "react-native";
import { SafeAreaProvider } from "react-native-safe-area-context";

import useCachedResources from "./hooks/useCachedResources";
import useColorScheme from "./hooks/useColorScheme";
import Navigation from "./navigation";

export default function App() {
  return (
    <View style={{ justifyContent: "center", alignItems: "center" }}>
      <Text>Image</Text>
      <View style={{ borderWidth: 1, flex: 1 }}>
        <Image
          source={require("./trust.png")}
          style={{ resizeMode: "cover", width: 200, height: 40 }}
        />
        <ImageBackground
          source={require("./lover.jpg")}
          style={{ width: 200, height: 40 }}
        />
      </View>
    </View>
  );
}

instead of require("./trust.png")  i replace with import trust from './trust.png' then call
<Image
source={trust}
style={{ resizeMode: "cover", width: 200, height: 40 }}
/>
also changing the package.json work for me
{
"scripts": {
"start": "expo start",
"android": "expo start --android",
"ios": "expo start --ios",
"web": "expo start --web",
"eject": "expo eject",
"customize": "yarn expo-electron customize",
"desktop": "yarn expo-electron start"
},
"dependencies": {
"@expo/electron-adapter": "^0.0.55",
"@expo/webpack-config": "0.12.16",
"@expo-google-fonts/inter": "^0.1.0",
"@react-native-community/masked-view": "0.1.10",
"@react-navigation/native": "^5.9.4",
"@react-navigation/stack": "^5.14.5",
"electron": "^6.0.12",
"expo": "~41.0.1",
"expo-app-loading": "^1.0.3",
"expo-font": "^9.1.0",
"expo-linear-gradient": "^9.1.0",
"expo-status-bar": "~1.0.4",
"react": "16.13.1",
"react-dom": "16.13.1",
"react-native": "https://github.com/expo/react-native/archive/sdk-41.0.0.tar.gz",
"react-native-elements": "^3.4.1",
"react-native-gesture-handler": "~1.10.2",
"react-native-reanimated": "~2.1.0",
"react-native-safe-area-context": "3.2.0",
"react-native-screens": "~3.0.0",
"react-native-web": "~0.13.12",
"react-responsive": "^8.2.0",
"tailwind-rn": "^3.0.1"
},
"devDependencies": {
"@babel/core": "7.9.0",
"@types/react": "~16.9.41",
"@types/react-dom": "~16.9.8",
"@types/react-native": "~0.62.13",
"typescript": "3.8.3"
},
"private": true
}


segfault on cygwin

benchmark compiles as is on cygwin, but generates a segment fault while trying to perform the jit benchmark. gdb was no help, but I observed that the compilation warned about redefining PAGESIZE from 65536 to 4096. The attached included patch compensates for this, and allows the benchmark to execute successfully giving these result on my laptop with "Intel(R) Core(TM) i7-7700HQ CPU @ 2.80GHz, 2808 Mhz, 4 Core(s), 8 Logical Processor(s)".
$ ./benchmark
jit: 2.447226 ns/call
plt: 2.003026 ns/call
ind: 1.725051 ns/call

benchmark.c.patch
--- a/benchmark.c
+++ b/benchmark.c
@@ -9,9 +9,11 @@
 #include <unistd.h>
 #include <sys/mman.h>

-#define PAGESIZE           4096
-#define PAGEMASK           (~0xfff)
-#define SAFETY_MARGIN      (1024 * PAGESIZE)
+#if !defined(PAGESIZE)
+    #define PAGESIZE       4096
+#endif
+#define PAGEMASK           (~(PAGESIZE-1))
+#define SAFETY_MARGIN      (1024 * 1024 * 4)
 #define BENCHMARK_SECONDS  2
 #define BENCHMARK_SAMPLES  4

(Note: one blank line at end of patch.)

Thanks! My README isn't specific enough since it says "any POSIX system"
on x86-64 which technically includes Cygwin. However, it's more precise
to say: requires POSIX.1-2001, x86-64, System V ABI. Since Cygwin
(mostly) follows the Windows x64 ABI, it doesn't fulfill the last
requirement. The fact that it works at all is luck.
The main issue is that the JIT compiled function doesn't set up shadow
space, but fortunately the callee doesn't try to use its shadow space.
It works, but it's fragile.
Thanks for sharing your benchmarks, especially since they show the
opposite results of my article. I dug into this and the reason is that,
for Cygwin's toolchain, the (equivalent of the) PLT stub is what's being
passed to the JIT compiler, so it ends up going through the PLT. Why
it's so much worse than the PLT benchmark, I can't explain, but it
definitely won't be better. I fixed this in 5dfdb73, and the JIT
compiler is passed the same function used for the indirect call
benchmark. With this change, the benchmark results are what you'd
expect. The change has no effect on the Linux systems I tested because
empty == empty_sym.


Pin pyyaml at 5.4.1

With pyyaml 6.0,  yank analyze fails:

(openmm) mjw@ubu:~/workspace/yank-examples/examples/hydration/phenol/explicit_1$ yank analyze --store=experiments
Traceback (most recent call last):
  File "/home/mjw/miniconda3/envs/openmm/bin/yank", line 10, in <module>
    sys.exit(main())
  File "/home/mjw/miniconda3/envs/openmm/lib/python3.9/site-packages/yank/cli.py", line 73, in main
    dispatched = getattr(commands, command).dispatch(command_args)
  File "/home/mjw/miniconda3/envs/openmm/lib/python3.9/site-packages/yank/commands/analyze.py", line 148, in dispatch
    single_run()
  File "/home/mjw/miniconda3/envs/openmm/lib/python3.9/site-packages/mpiplus/mpiplus.py", line 271, in _wrapper
    return run_single_node(rank, task, *args, **kwargs)
  File "/home/mjw/miniconda3/envs/openmm/lib/python3.9/site-packages/mpiplus/mpiplus.py", line 220, in run_single_node
    result = task(*args, **kwargs)
  File "/home/mjw/miniconda3/envs/openmm/lib/python3.9/site-packages/yank/commands/analyze.py", line 143, in single_run
    output = analyze.analyze_directory(args['--store'], **analyzer_kwargs)
  File "/home/mjw/miniconda3/envs/openmm/lib/python3.9/site-packages/yank/analyze.py", line 782, in analyze_directory
    auto_experiment_analyzer = ExperimentAnalyzer(source_directory, **analyzer_kwargs)
  File "/home/mjw/miniconda3/envs/openmm/lib/python3.9/site-packages/yank/analyze.py", line 299, in __init__
    analysis = yaml.load(f)
TypeError: load() missing 1 required positional argument: 'Loader'
Exception ignored in: <function ExperimentAnalyzer.__del__ at 0x7f8bdf6b5d30>
Traceback (most recent call last):
  File "/home/mjw/miniconda3/envs/openmm/lib/python3.9/site-packages/yank/analyze.py", line 336, in __del__
    for phase, analyzer in self.analyzers.items():
AttributeError: 'ExperimentAnalyzer' object has no attribute 'analyzers'

See also:
https://github.com/yaml/pyyaml/issues/576

This one may be much more difficult to address if the pyyaml API changed, so I suggest we should indeed pin pyyaml <6 for now.

You might want a repodata patch too.
https://github.com/conda-forge/conda-forge-repodata-patches-feedstock


Add delegated credentials, as seen in #26

This WIP for #26

thanks @armfazh for the review! This is still WIP and has still some todos, so there is lots of errors. I'll assign you and @bwesterb once it is ready for review ;)

This is still WIP and has still some todos, so there is lots of errors.

Yes, we are iterating in this codebase, and happy to review as many times as needed.

Yes, we are iterating in this codebase, and happy to review as many times as needed.

Oh, perfect! Every now and then when I finish a task of the issue, I'll mark it for review ;) Thanks so much!

this should probably be rebased on the cf branch, because right now the diff is enormous

@thomwiggers the idea to have a separate branch is to be able to integrate to golang (which won't integrate probable the KEM TLS exp): that is why it differs from the cf branch.

@bwesterb @armfazh @chris-wood ready for review as a first version. I might add some refactors and other ideas in the mean time; but should we good now. Sorry for opening and closing it as a draft but I had some conflicts with go1.15

@bwesterb @armfazh Please, review until commit 8946da6ec17c41733afe60689ce2e340d22fda2b
I'll add some more refactors, and some more functionality for the client; but I wanted you to check the overall work until that point ;)

@Lekensteyn @chris-wood @thomwiggers @bwesterb @armfazh Please, review this again. Thank you!

@thomwiggers client authentication added as well ;)

@thomwiggers @bwesterb @chris-wood all merge conflicts are fixed and this branch is in line with the cf one. I squashed all commits into one as well.

Hi @cjpatton ! Thanks for this! I'll only solve this week the small comments, as any large change will likely break the code of kem-tls needed for Friday. Thanks!

Hi @cjpatton ! Thanks for this! I'll only solve this week the small comments, as any large change will likely break the code of kem-tls needed for Friday. Thanks!

Rebased.

Rebased.

Merging as-is, with existing approvals. Note that future changes to crypto/tls and crypto/x509 will need approval from the respective codeowners.


[DEVHAS-377] update push.yaml for all deployment environments

What does this PR do?:

This is a coordinated fix to separate out our stage and prod environments.  We need to update the script so the commit hash gets updated on all overlays.
Relies on https://github.com/redhat-appstudio/infra-deployments/pull/1890 to be merged before we can merge this PR
Which issue(s)/story(ies) does this PR fixes:

https://issues.redhat.com/browse/DEVHAS-377
PR acceptance criteria:

[ ] Unit/Functional tests

[ ] Documentation

[ ] Client Impact

How to test changes / Special notes to the reviewer:

/retest

/retest


Checksums per Branch

After switching branches, you can get the following status although the remote side has not changed at all. It's just different between branches.

It's incorrect and confusing as mentioned in #2086 and #2869. Time to address this problem.
Today, there's only one set of checksums. This is not sufficient to consistently track the state of the repo with all its branches. I have come to the conclusion that we must manage the checksums by branch. This will allow abapGit to track the last known state of each branch and therefore correctly determine if the remote side has changed.
I therefore propose the following change:
INTERFACE zif_abapgit_persistence.

  TYPES: BEGIN OF ty_local_checksum,
           branch_name     TYPE string,  "<<<INSERT
           item  TYPE zif_abapgit_definitions=>ty_item,
           files TYPE zif_abapgit_definitions=>ty_file_signatures_tt,
         END OF ty_local_checksum.

All code dealing with checksums will need to include "branch_name", which is an easy change (7 lines of code).
Existing repos will not have the correct state for each branch. We could assume that the current checksums belong to the current branch and migrate them accordingly. But how do we want to deal with other branches?

if checksums are missing they will be just derived from the current state (indirectly assuming there were no changes to local since infinity), the same logic would do.
P.S. I'd probably suggest considering a bit further step - storing commit history, to see also where am I compared to the remote master. Though it is more difficult of course.

Well, I think this needs an overhaul, is the local checksum local or? Currently its sometimes the remote 🤷♂
To me, the local checksum is the state of the local files during the previous pull, ie. this can be used to determine if local manual changes will be overwritten. There is not enough information in abapGit to determine the status correctly as currently shown to users.

From my point of view, the checksums represent the local state(not branch or git, but local) after the previous pull, that way it is possible to determine if the last write to the local object was by a developer or by abapGit. This is used to give warnings to the developer if abapgit will overwrite local changes.
However, it has evolved into being used to determine if there are changes on local vs remote.
My suggestion,

keep the checksums, only for warnings for overwrite
change the local vs remote comparison, so there are the below possibilities,

State,

File match
File differ
File exists only locally
File exists only remotely
Note that these 4 states can be very easily determined, it gives less information, but I think its okay.

This simplified state model would certainly make things much easier. It actually does not require persisting checksums at all. it's just a comparison between local and remote files.
However, I'm not convinced that this is the way to go. Being able to tell if a change was local or remote is a key capability today. Quite often I have a mix of local and remote changes and the current local/remote state really helps to identify what I want to push or what I could pull. I'm pretty sure others would miss this capability, too.

looking at command line git, there is no easy way(that I know of) to find if there is a remote change, it does not show on git status
even if we have additional checksums per branch, I think its difficult to get the correct status. it needs to know at least the full remote history, which we do not(currently) have in memory


Encoding sniffing algorithm

In PowerShell Core project we want use the library as portable parser.
Currently we have a Issue about requesting sites with broken encoding. Recent PowerShell Core code and .Net Core don't support full HTML5 standard.
Do you plan to implement the "Encoding sniffing algorithm" and related encoding point from the doc?
It would be greatly simplified and accelerated our work.

I think that one is implemented, see TextSource. Besides that part AngleSharp also takes the correct precedence in terms of encoding via content-type, stream (BOM), meta tag etc. Also the three encoding states (tentative, certain, irrelevant) are respected.
Nevertheless, as encoding is quite a beast and AngleSharp uses .NET Standard 1.0 we are limited in terms of, e.g., punycode or some other (esoteric?) variants that appear in the spec. I would still guess it does a decent job in most (all relevant?) edge cases.

@FlorianRappl Thanks for clarify! I am trying to lean the API.


Auto comment on opened PR and merged or closed PR

Issue number: #70
I have updated the code for closed PR and have used GitHub tokens but it is recommended to get a Personal access token for task like this. Other than that I think everything looks good here

Hi @MohanRamSridhar,
Thank you for your contribution! Your changes for auto-commenting on opened and merged/closed PRs look good so far. I appreciate your note about using GitHub tokens and the recommendation to get a Personal Access Token for tasks like this.
I'll review the changes in detail and provide any specific feedback if needed. In the meantime, please make sure that your updates align with our [CONTRIBUTING.md](link to CONTRIBUTING.md) guidelines.
Thanks again for your hard work and contribution! 😊
Best regards,
Sanika Chavan
[https://www.linkedin.com/in/sanika-chavan-52457b236]


Mechanism of nanopolish event alignment

Hi guys, I am new to nanopolish, and wondering how nanopolish does the event alignment between the reference genome and the detected current signal events.
I have gone through the blog https://simpsonlab.github.io/2015/04/08/eventalign/, and the supplementary material https://static-content.springer.com/esm/art%3A10.1038%2Fnmeth.3444/MediaObjects/41592_2015_BFnmeth3444_MOESM60_ESM.pdf, but I am still unsure how a profile HMM is used for event alignments. I believe that the hidden states should be the k-mers in reference genome, but how could we find the corresponding nanopore read event? I am quite confused on this part. The problem may sounds silly thought ......
If I want to suspect the mechanism from the source code, which part of code should I have a look? Thanks a lot in advance for answering my questions, great appreciation, really being stuck for so long on the mechanism part.

Hi,
You are correct that the hidden states are the k-mers of the reference sequence. The input into the HMM is a sequence of events (e_1, e_2, ..., e_n). We use dynamic programming (the viterbi or forward algorithm) to determine the best alignment of these events to k-mers. This would be a good place in the code to start:
https://github.com/jts/nanopolish/blob/master/src/nanopolish_raw_loader.cpp#L381
(nanopolish actually uses two HMMs, this is the simpler one that is used when loading the reads. There is a more complicated HMM here that is used during consensus/variant calling: https://github.com/jts/nanopolish/blob/master/src/hmm/nanopolish_profile_hmm_r9.inl#L266).
I hope that helps,
Jared


Bug: Can't use files cwd together with a vim.fn.stdpath

RTFM Checklist

[X] I have searched exisiting issues / discussions
[ ] I have read the Wiki including the Advanced section
[ ] I have read man fzf / I am well versed in shell fzf

Operating system
Arch Linux
Shell
ZSH
Neovim version (nvim --version)
NVIM 0.10.1
Fzf version (fzf --version)
0.54
Output of :lua print(os.getenv('FZF_DEFAULT_OPTS'))
Nil
Is the problem reproducible with mini.sh?

[ ] My issue is reproducible with mini.sh
[ ] My issue IS NOT reproducible with mini.sh
[X] I have not tested with mini.sh (not relevant, requires LSP, Windows, etc)

Fzf-lua configuration
config = function()
      -- calling `setup` is optional for customization
      require('fzf-lua').setup {
        'fzf-native',
        defaults = {
          git_icons = false,
          file_icons = false,
          color_icons = false,
        },
      }
      require('fzf-lua').register_ui_select()
      vim.keymap.set('n', '<leader>sf', require('fzf-lua').files, { desc = '[S]earch [F]iles' })
      vim.keymap.set('n', '<leader>sg', require('fzf-lua').live_grep, { desc = '[S]earch by [G]rep' })
      vim.keymap.set('n', '<leader>sd', require('fzf-lua').diagnostics_document, { desc = '[S]earch [D]iagnostics' })
      vim.keymap.set('n', '<leader>sr', require('fzf-lua').resume, { desc = '[S]earch [R]esume' })
      vim.keymap.set('n', '<leader><leader>', require('fzf-lua').buffers, { desc = '[S]earch [B]uffers' })
      vim.keymap.set('n', '<leader>sw', require('fzf-lua').grep_cword, { desc = '[S]earch [W]ord' })
      vim.keymap.set('n', '<leader>s.', require('fzf-lua').oldfiles, { desc = '[S]earch Recent Files' })
      -- vim.keymap.set('n', '<leader>sn', require('fzf-lua').files { cwd = vim.fn.stdpath 'config' }, { desc = '[S]earch [N]eovim files' })
    end,

Describe the bug / steps to reproduce
The line
vim.keymap.set('n', '<leader>sn', require('fzf-lua').files { cwd = vim.fn.stdpath 'config' }, { desc = '[S]earch [N]eovim files' })

Crashes NeoVim at start with the following error:

The same concept works if I try:
:lua require('fzf-lua').files { cwd = vim.fn.stdpath 'config' }

Couldn't find something related to this and it's a bit frustrating as anything else worked perfectly.

That’s not a bug with fzf-lua, it’s an issue with your confit/distribution, the error isnt in fzf-lua (from the screenshot you posted), as you also noted yourself running the below directly works.
:lua require('fzf-lua').files { cwd = vim.fn.stdpath 'config' }

Btw, this is not how you define a keymap (read :help vim.keymap.set):

This is wrong and why you have the error

vim.keymap.set('n', '<leader>sn', require('fzf-lua').files { cwd = vim.fn.stdpath 'config' },
  { desc = '[S]earch [N]eovim files' })

Do this and it will work:

```lua
vim.keymap.set('n', '<leader>sn', function() require('fzf-lua').files { cwd = vim.fn.stdpath 'config' } end,
 { desc = '[S]earch [N]eovim files' })


vsync

Steps to Reproduce

...
...
...

Logs

Hi @theswerd, it looks like you forgot to fill in any details on this issue. I'm going to close it, but please feel free to file another one.


Core -> General Improvements: Refactor public API

To expose only the pieces used by clients, which includes the API and Admin


StackExchange nuget package Build Error

StackExchange nuget package was pulling the latest version which requires the whole project to target 4.6 on build server. Instead of updating projects to be 4.6 chnaged dependency to earlier version so it is .NET 4.5 compatible and buils on the build server without extra configuration.

Note that other projects are moving to 4.6 so we'll need to do the same - not necessarily immediately but before long


ISPN-6438 Configure client SSL with properties

Looks good. This also needs adding to the docs and possibly an "secure jcache" example. Once https://github.com/infinispan/infinispan/pull/4219 is done we can provide one.

We should probably also support "injecting" a pre-built SSLContext

A few more properties, to enable authentication as well as encryption please:
authenticationEnabled (a boolean)
saslMechanism (a string, should support multiple values which could be comma-separated)
callbackHandler (an instance of javax.security.auth.callback.CallbackHandler)
serverName (a string)
clientSubject (an instance of javax.security.auth.Subject)
saslProperties (a map<String, String>, need to think how to represent this as a string, an instance would be fine)

@tristantarrant Authentication properties have been added.

@tristantarrant +1 to both comments, they're both included now.

Pushed, thanks


Menu option, 'copy path to clipboard' is aware of VIM clipboard option

VIM noob here, so code might not be optimal.
My setup is as follows.
NVIM v0.5.0-95-g2e14dffbb, Linux Mint 19.2.
I have this in init.vim
set clipboard=unnamedplus

This enables me to share clipboard between VIM and X clipboard.
The problem is that the menu option in NERDTree copies the file path to the "* register.
This means I can't access the value in the X clipboard.

Looks good. Thanks.


pkg/expect: ExpectFunc, LineCount

ExpectFunc to make expect more extensible. LineCount to be
able to check 'no output' command.

/cc @heyitsanthony
Thanks.

lgtm

thanks. merging in greens.


Enhance simulateConsumeItem to apply inflicted status effects gained from consumption

Is there an existing issue for this?

[X] I have searched the existing issues

Describe the feature
With the 1.20.5 mojang mappings provided through paper, I extracted data from the net.minecraft.world.food.Foods class and stored them as json. Together with the already existing data found in resources/potion this should make it possible to simulate the status effects from all item consumption.

This is the data I extracted. I mixed paperweight with MetaMiner.
food_properties.json


Should room name be limited to 255 bytes?

Link to problem area: https://spec.matrix.org/v1.1/client-server-api/#mroomname
Issue
The spec says the name field in the m.room.name event must not exceed 255 bytes. Synapse, Dendrite, and Conduit do not enforce this over the C-S API. Is the spec wrong or are the servers wrong?

Hm, the horse may have bolted by this point. I'd probably vote to remove the requirement (and later add it in a MSC, if we think it's required). Events are obviously limited to 65k, and any sensible client should be trimming excessive names anyway.


Multiple improvements, view comment

Add hotkey for capture and translate

Uses python module 'keyboard'
Example: Set hotkey to 'Enter' such that pressing enter can both advance the VN and capture
User is able to set the hotkey in settings by pressing button and press desired hotkey

Instead of reading Setting.json everytime the screen is captured, cached settings in memory is read to reduce read from hard drive
Auto copy resource and user_manual from source through .spec file; Removed redundant files from copy_after_compiling
Fix typo
Add files to .gitignore

Notice that capture_UI.getTextAndTranslate() is called in hotkeyPoll() instead of being called directly by hotkeyCallback().
Since hotkeyCallback() is invoked by keyboard module hotkey, I think hotkeyCallback() would be called in separate thread from main thread. It seems that if hotkeyCallback() which is in another thread calls capture_UI.getTextAndTranslate(), which tries to create tkinter.messagebox() in case of error, tkinter would mistaken that there is no instances of tkinter running, hence try to create another instance of tkinter. Tkinter does not like running two instances simultaneously, hence throws RuntimeError.
This is solved by creating hotkeyPoll(), which is executed in main thread every 100ms and invoke capture_UI.getTextAndTranslate(), if hotkey was pressed in previous 100ms. This will cause tkinter.messagebox() to run in main thread instead of in separate thread, hence prevent creating another instance of tkinter and prevent RuntimeError.

Please wait, found a bug that cause error when pressing hotkey after saving settings

Sounds awesome, gonna check first before merging

Caught 2 bugs and fixed

fix crash if no hotkey set when saving settings
caching setting when saving

Please wait, don't merge yet.
To make the hotkey function useful, a time delay has to be implemented as text won't instantly appear in VN

Please wait, don't merge yet.
To make the hotkey function useful, a time delay has to be implemented as text won't instantly appear in VN

No worry, I'm still checking out the thing, and about that hotkeypoll, I think we can keep it as it is if there is no other solution for now

Added the time delay for hotkey, which can be customized in settings

Edit: About the time delay, are you trying to make it so that the app will capture simultaneously as the user is playing the game?

Yes

Yes
Great thinking bro these are some great improvements

The file looks good to me, I'm gonna merge it now


Removed switch to disable the cache

This PR removes the switch to disable the cache. Once we switch to Symfony, we don't have a choice but to maintain a cache directory, because Symfony operates on a compiled container and router and therefore requires a cache.
Related to #618.
Preparation for #895.

Thank you, @derrabus!


breaking change: include sanitized hostname in offline registry path

Description
Include the hostname in the image path for  offline image pushes.  Requires an update to zarf agent as well.
converts localhost:5000/zarf-game:multi-tile-dark -> <IP_ADDRESS>:45001/localhost.5000/zarf-game:multi-tile-dark on push and <IP_ADDRESS>:31999/localhost.5000/zarf-game:multi-tile-dark on pull via the Zarf Agent
Fixes #561
Type of change

[x] Bug fix (non-breaking change which fixes an issue)
[x] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Closing in favor of #666


Label is not color highlighting when user is interacting with an input field

Detailed description
According to our carbon components spec, the labels should highlight when the user has focused on an input field.
I believe this was injected by the a11y fix.  I believe this fix injected the issue because the css no longer finds the label field since it's been reordered: https://github.com/IBM/carbon-components-react/commit/f02c1f9a7ecb92bb42028b34b8b95bb09ac2e425

Is this a feature request (new component, new icon), a bug, or a general issue?

bug

Is this issue related to a specific component?

Select

What did you expect to happen? What happened instead? What would you like to see changed?

expected label to highlight

What browser are you working in?

Chrome

What version of the Carbon Design System are you using?

6.18.4

What offering/product do you work on? Any pressing ship or release dates we should be aware of?

Steps to reproduce the issue
Simply interact with the Select widget in this storybook.  The label should be highlighted red as you interact.
http://react.carbondesignsystem.com/?selectedKind=Select&selectedStory=invalid&full=0&addons=1&stories=1&panelRight=0&addonPanel=storybook%2Factions%2Factions-panel

Step one
Step two
Step three
etc.

Additional information

Screenshots or code
Notes

Ah, this explains the reasoning why the label/input order was switched with v9. Will need to fix this in carbon-components also.

Let's continue the discussion in carbon-design-system/carbon-components#1052 for now. Can re-open as needed.


Use Makefile instead of shell scripts

Done for Drone part.
@KtorZ: Could you move coverage from coverage.sh to the Makefile?


Process GPX files after Waze import

Currently there is no information about i.e. distance when Waze files have been read. Reimport will add this data, but this can already be done during import.

Duplicate of #78


[SPARK-39490][K8S] Support ipFamilyPolicy and ipFamilies in Driver Service

What changes were proposed in this pull request?
This PR aims to support iFamilyPolicy and ipFamilies K8s Service feature in Spark Driver Service in order to support IPv6-only environment. After this PR, we can control ipFamilyPolicy and ipFamilies.
$ kubectl get svc spark-xxx-driver-svc -oyaml
apiVersion: v1
kind: Service
metadata:
  ...
spec:
  clusterIP: None
  ipFamilyPolicy: SingleStack
  ipFamilies:
  - IPv4
...

Why are the changes needed?
K8s IPv4/IPv6 dual-stack Feature reached Stable stage at v1.23.

https://kubernetes.io/docs/concepts/services-networking/dual-stack/

v1.16 [alpha]
v1.21 [beta]
v1.23 [stable]

According to EKS milestone, K8s v1.23 will be GA on August.

Kubernetes version
Upstream release
Amazon EKS release
Amazon EKS end of support

1.20
December 8, 2020
May 18, 2021
September 2022

1.21
April 8, 2021
July 19, 2021
February 2023

1.22
August 4, 2021
April 4, 2022
May 2023

1.23
December 7, 2021
August 2022
October 2023

Note that

EKS started IPv6 since January 2022.
Docker Desktop supports IPv6 only on Linux.
Minikube doesn't support IPv6 yet unfortunately.

Does this PR introduce any user-facing change?
Yes, this is a new feature.
How was this patch tested?
Pass the CIs with newly added test cases.

cc @dbtsai and @viirya

Thank you so much. Yes, it does, @viirya .
Merged to master (The first commit passed CI tests and the second commit is only renaming a test case)


Temporary mail records

Requirements

[x] You have completed your website.
[x] The website is reachable.
[x] The CNAME record doesn't contain https:// or /.
[x] There is sufficient information at the owner field.
[x] Your website is not hosting on the following due to SSL issues: Vercel, Netlify

Description

Link to Website

This is just for few days so I can transfer my mails to another mailboxes and change my emails

Can I use this subdomain as backup for my subdomain. Can merge this later will add other records

Do you still support ns records

@andrewstech Are any of these files valid? The record names is what throwing me off.

Do you still support ns records

Nope

@andrewstech Are any of these files valid? The record names is what throwing me off.

Looks good to me


Parse JSON error

I init your xLog in the application onCreate() with XLog.init(LogLevel.ALL);, but when I run my project it fail to print json string, only give me this error com.elvishew.xlog.formatter.FormatException: Parse JSON error. It's works well using android.util.Log to print the json string, don't know anything wrong, any help?

@chowaikong It is mostly because the string you tried to print is not a JSON, can you check if what you print is realy a JSON string?

But why can Gson parses the JSON string?

@chowaikong Is it possile you paste the JSON string here, or send to<EMAIL_ADDRESS>so I can take a further look?

Please check your email.

@chowaikong In my side, I call XLog.json(the_json_you_sent_me), and the formatted JSON is successfully printed, so I don't know how you got the error.
Can you print the full error stack of FormatException to see what the exception actually is?
Also, you can take a look at the DefaultJsonFormatter, the formatting code is very simple.
  try {
      if (json.startsWith("{")) {
        JSONObject jsonObject = new JSONObject(json);
        formattedString = jsonObject.toString(JSON_INDENT);
      } else if (json.startsWith("[")) {
        JSONArray jsonArray = new JSONArray(json);
        formattedString = jsonArray.toString(JSON_INDENT);
      } else {
        throw new FormatException("JSON should start with { or [, but found " + json);
      }
    } catch (Exception e) {
      throw new FormatException("Parse JSON error. JSON string:" + json, e);
    }

This code snippet seems hardly to be wrong.

Sorry for the delay, m.elvishew.xlog.formatter.FormatException: Parse JSON error. is the only exception I encounter, but I can tell you some detail of my project's build environment, I'm using OkHttp for the network job, with HttpLoggingInterceptor to print the network log, hope it helps.

@chowaikong I understand, I need the root cause exception of the FormatException, can you help to pointing it out using below codes:
try {
  XLog.json(Your JSON string);
} catch (Exception e) {
  android.util.Log.i("ERROR", "The exception is: ", e);
}

And use logcat or Android Studio to see the printed ERROR log?
For example, I use below codes to test:
try {
  XLog.json("{abc}");
} catch (Exception e) {
  android.util.Log.i("ERROR", "The exception is: ", e);
}

and got below ERROR log
I/ERROR   (  957): The exception is:
I/ERROR   (  957): com.elvishew.xlog.formatter.FormatException: Parse JSON error. JSON string:{abc}
I/ERROR   (  957): 	at com.elvishew.xlog.formatter.message.json.DefaultJsonFormatter.format(DefaultJsonFormatter.java:48)
I/ERROR   (  957): 	at com.elvishew.xlog.formatter.message.json.DefaultJsonFormatter.format(DefaultJsonFormatter.java:27)
I/ERROR   (  957): 	at com.elvishew.xlog.Logger.json(Logger.java:388)
I/ERROR   (  957): 	at com.elvishew.xlog.XLog.json(XLog.java:648)
I/ERROR   (  957): 	at com.elvishew.xlogsample.MainActivity$5.onClick(MainActivity.java:122)
I/ERROR   (  957): 	at android.view.View.performClick(View.java:4764)
I/ERROR   (  957): 	at android.view.View$PerformClick.run(View.java:19833)
I/ERROR   (  957): 	at android.os.Handler.handleCallback(Handler.java:739)
I/ERROR   (  957): 	at android.os.Handler.dispatchMessage(Handler.java:95)
I/ERROR   (  957): 	at android.os.Looper.loop(Looper.java:135)
I/ERROR   (  957): 	at android.app.ActivityThread.main(ActivityThread.java:5292)
I/ERROR   (  957): 	at java.lang.reflect.Method.invoke(Native Method)
I/ERROR   (  957): 	at java.lang.reflect.Method.invoke(Method.java:372)
I/ERROR   (  957): 	at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:908)
I/ERROR   (  957): 	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:703)
I/ERROR   (  957): Caused by: org.json.JSONException: Expected ':' after abc at character 5 of {abc}
I/ERROR   (  957): 	at org.json.JSONTokener.syntaxError(JSONTokener.java:450)
I/ERROR   (  957): 	at org.json.JSONTokener.readObject(JSONTokener.java:379)
I/ERROR   (  957): 	at org.json.JSONTokener.nextValue(JSONTokener.java:100)
I/ERROR   (  957): 	at org.json.JSONObject.<init>(JSONObject.java:156)
I/ERROR   (  957): 	at org.json.JSONObject.<init>(JSONObject.java:173)
I/ERROR   (  957): 	at com.elvishew.xlog.formatter.message.json.DefaultJsonFormatter.format(DefaultJsonFormatter.java:39)
I/ERROR   (  957): 	... 14 more

So I can figure out the root exception is
I/ERROR   (  957): Caused by: org.json.JSONException: Expected ':' after abc at character 5 of {abc}
I/ERROR   (  957): 	at org.json.JSONTokener.syntaxError(JSONTokener.java:450)
...

Thank you

I have try the code below:
try {
    XLog.json(json);
    } catch (Exception e) {
    Log.e("HttpLoggingInterceptor", e.toString());
}

And still the same exception, no further information.

@chowaikong
android.util.Log.i("ERROR", "The exception is: ", e); is different from Log.e("HttpLoggingInterceptor", e.toString());, the latter one will not print the root cause.
Can you try Log.e("HttpLoggingInterceptor", "The exception is: ", e);  instead?

Right, now the exception maybe meet your requirement.
Caused by: com.elvishew.xlog.formatter.FormatException: JSON should start with { or [, but found <-- END HTTP (9015-byte body)
                                                                       at com.elvishew.xlog.formatter.message.json.DefaultJsonFormatter.format(DefaultJsonFormatter.java:45)
                                                                       at com.elvishew.xlog.formatter.message.json.DefaultJsonFormatter.format(DefaultJsonFormatter.java:27)
                                                                       at com.elvishew.xlog.Logger.json(Logger.java:382)
                                                                       at com.elvishew.xlog.XLog.json(XLog.java:630)

@chowaikong
This error com.elvishew.xlog.formatter.FormatException: JSON should start with { or [, but found  is not the same with that one com.elvishew.xlog.formatter.FormatException: Parse JSON error  you mentioned in the very beginning, I think they are two different exceptions.
From the exception found <-- END HTTP (9015-byte body) you pasted,  I wonder if your JSON string contains some comments(like "<--")? Since JSON string should not contain any comment, so the exception thrown.

<-- END HTTP (9015-byte body) is the ending of a http request, XLog is printing every lines of the response content according to the logcat.

As a comparison, I try KLog too, this lib prints json string just normally fine. And I think the json string printing method is quite similar between two libraries.

@chowaikong I check KLog's JSON parser, it is the same as xLog's, the only difference between these two is, KLog catch the JSONException(mostly because the message is not a JSON) and leave the message not formatted, but xLog will throw an FormatException if the message is not a JSON when you call XLog.json.
I notice you may using the okhttp with HttpLoggingInterceptor and try to implement your own logger, the logger will automatically print many messages during requesting. But except the response data, all the other messages are not a JSON, so you can not just call XLog.json to print all of them.
If you are still using xLog, and want to format the JSON response data, try below codes when printing the okhttp log
try {
  XLog.json(message)
} catch (Exception e) {
  XLog.d(message)
}

Hope this can help you.

OK, thanks.


Implement explicit multipole borehole resistance for double u-tube

Add in borehole resistance calculation using Claesson and Javed (2019) for double u-tubes.
@MassimoCimmino Do you have any comments on this or how it differs from what you already have in the package? I see that you mention Cimmino (2016) in the MultipleUTube class.
Due date: February 28, 2021

Johan Claesson & Saqib Javed (2019) Explicit multipole formulas and thermal network models for calculating thermal resistances of double U-pipe borehole heat exchangers, Science and Technology for the Built Environment, 25:8, 980-992, DOI: https://doi.org/10.1080/23744731.2019.1620565
Cimmino, M. (2016). Fluid and borehole wall temperature profiles in vertical geothermal boreholes with multiple U-tubes. Renewable Energy, 96, 137–147. https://doi.org/10.1016/j.renene.2016.04.067

The borehole resistances are calculated using the "full" multipole method of Claesson and Hellström (2011). The method is implemented in the multipole function of the pipes module. It allows for arbitrary multipole order, number of pipes and positions.
The Claesson and Javed (2019) has limited advantages (in the context of pygfunction) when compared to the more general Claesson and Hellström (2011) method. It should be faster when it applies - that is for symmetrical cases and for orders 0 and 1 - and it is easier to implement. The calculated resistances are the same.
The resistances are only evaluated at initialization of the pipe objects and the overall time save should be minimal when the g-function calculation and the simulation itself are taken into account. There might be potential for some time savings during simulations thanks to the equivalent two-pipe geometries proposed in the paper, which should reduce the size of the systems of equations handled by the pipe classes.
Do you see any use for the implementation of the explicit formulas?

Claesson, J., & Hellström, G. (2011). Multipole method to calculate borehole thermal resistances in a borehole heat exchanger. HVAC&R Research, 17(6), 895-911. DOI: 10.1080/10789669.2011.609927

Okay thanks, that sounds good.
Double u-tube functionality is a request that has been made for the GHE design tool we are working on. (Not yet open source but I do plan to do that as soon as practical.) Moving forward I plan to depend heavily on pygfunction.
I don't see any need for the explicit formulas. I will be studying what you have and doing a verification process; may bolster an example or create a new one.


236 | Lowest Common Ancestor of Binary Tree | Python

Title - 236 | Lowest Common Ancestor of Binary Tree | Python
What will change -
Type of Issue -
Please add/delete options that are not relevant.

[x] Adding New Code

Programming Language
Please add/delete options that are not relevant.

[x] Python

Self Check

Ask for issue assignment and wait to get assigned to it before making Pull Request.
Add your file in the proper folder
Clean Code and Documentation for better readability
Add Title and Description of the program in the file

:star2: Star it :fork_and_knife:Fork it :handshake: Contribute to it!
Discord server ✉ - https://discord.gg/CXksGdn
Happy Coding,

Please assign it to me !
Thanks

Hello I am a third year from IIT Kharagpur, having good experience in competitive programming. Please assign it to me.

[x] Assigned to @AbhJ

236.LowestCommonAncestorofBinaryTree.py
please accept my pull request


Fix WebsocketSecure connections on Android

Closes #589

Codecov Report
Base: 67.01% // Head: 67.01% // Decreases project coverage by -0.00% :warning:

Coverage data is based on head (a3eee10) compared to base (add674b).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #658      +/-   ##
==========================================
- Coverage   67.01%   67.01%   -0.01%
==========================================
  Files          85       85
  Lines       12428    12429       +1
==========================================
  Hits         8329     8329
- Misses       4099     4100       +1

Impacted Files
Coverage Δ

client/client-lib/src/api.rs
83.38% <100.00%> (+0.05%)
:arrow_up:

fedimint/src/lib.rs
81.81% <0.00%> (-0.34%)
:arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Move the configurations into the package and add a runner function

The PR moves the configuration JSON files into the package directory so that these files are distributed as part of the package.
A convenience function run_benchmarks was added to dpbench so that import dpbench; dpbench.run_benchmarks() can be used to run the available benchmarks using default configurations.

Merging after local testing.


fill_form() doesn't work with  - but fill() does

Hi,
I have a input element like this:
<input type="tel" name="number" class="cc_number" placeholder="Credit card number" autocomplete="off" maxlength="16" id="number">

I'm calling fill_form on it, and passing a dict like:
cc_details = {
    'number': '23424234234234234',
    'name': 'Joe blogs',
    ...
}

All other fields (e.g. with type="text") get set correctly, however the type="tel" field does not.
However, calling .fill('number', '23424234234234234') does work.
Is there some way of adding type="tel" support into fill_form as well?
Cheers,
Victor

This is working in the latest version


QAPopUp.js - New Extension

Quick and cool extension to show a popup menu.

reminds me of smt https://github.com/TurboWarp/extensions/pull/818 :trollface:

reminds me of smt #818 :trollface:

Is this already in Turbowarp? I haven’t been in there for a while and thought I should contrib a bunch of extensions I made

reminds me of smt #818 :trollface:

Is this already in Turbowarp? I haven’t been in there for a while and thought I should contrib a bunch of extensions I made

Just checked, it’s still open
Yours is a lot better than mine, so simply a skill issue on my behalf 😭

I just fixed the file for you, checks are passing now.

I've been looking for a extension like this, thanks!

@yuri-kiss Heya! Looking to revamp this and get it on turbowarp soon. :)

@yuri-kiss Heya! Looking to revamp this and get it on turbowarp soon. :)

Nice


no such file or directory    node_modules/uuid/uuid.js'

./node_modules/uuid/uuid.js
Module build failed: Error: ENOENT: no such file or directory, open '/Users/fei/Desktop/NAS/myDapp/nas/xiang/node_modules/uuid/uuid.js'
what 's wrong?

i made it


Error when installing

Minikube v1.27.0 running Kubernetes v1.25.0 on containerd 1.6.8
Installing with kubectl apply -f ./yaml returned this:
namespace/clustersecret created
serviceaccount/clustersecret-account created
clusterrole.rbac.authorization.k8s.io/clustersecret-role-cluster created
role.rbac.authorization.k8s.io/clustersecret-role-namespaced created
clusterrolebinding.rbac.authorization.k8s.io/clustersecret-rolebinding-cluster created
rolebinding.rbac.authorization.k8s.io/clustersecret-rolebinding-namespaced created
customresourcedefinition.apiextensions.k8s.io/clustersecrets.clustersecret.io created
Error from server (BadRequest): error when creating "yaml/02_deployment.yaml": Deployment in version "v1" cannot be handled as a Deployment: strict decoding error: unknown field "spec.matchLabels"

This error persisted until I ran this version of the deployment manifest, with the offending "spec.matchLabels" removed:
apiVersion: apps/v1
kind: Deployment
metadata:
  name: clustersecret
  namespace: clustersecret
  labels:
    app: clustersecret
spec:
    selector:
      matchLabels:
        app: clustersecret
    template:
      metadata:
        labels:
          app: clustersecret
      spec:
        serviceAccountName: clustersecret-account
        # imagePullSecrets:
        # - name: regcred
        containers:
        - name: clustersecret
          image: flag5/clustersecret:0.0.8-beta
          # imagePullPolicy: Always
          # Uncomment next lines for debug:
          # command:
          #   - "kopf"
          #   - "run"
          #   - "-A"
          #   - "/src/handlers.py"
          #   - "--verbose"

The operator works after this, and new ClusterSecrets are cloned. I wonder if it's a bug, or am I missing something?

No you did it right.  There is a matchLabels too much in there.
spec:
    matchLabels:  <-- should be removed
    selector:
      matchLabels:
        app: clustersecret

why not making a pull request? Had the same issue and can confirm after deleting machLabels it works :)


Apple Event timed out..

I have tried 2-3 times this dmg I need to share with someone and all the time I bump on this:
hdiutil: resize: completed successfully Mounting disk image... Device name:     /dev/disk7 Searching for mounted interstitial disk image using /dev/disk7s... Mount dir:       /Volumes/dmg.ke2T6f Copying background file 'easyred2_1324780.jpg'... Running AppleScript to make Finder stuff pretty: /usr/bin/osascript "/var/folders/57/69z69th12597j72xkrz7cn0w0000gn/T/createdmg.tmp.XXXXXXXXXX.F0nuhm1U" "dmg.ke2T6f" /var/folders/57/69z69th12597j72xkrz7cn0w0000gn/T/createdmg.tmp.XXXXXXXXXX.F0nuhm1U:395:407: execution error: Finder got an error: AppleEvent timed out. (-1712) Failed running AppleScript Unmounting disk image... "disk7" ejected.
Could it be cause of the size of the app which is 12.5GB?
Thanks in advance for looking at this!

Okay, this time seems it was permissions.. Full Disk Access.
You might want to update the script someday to include this on first run or something checking this with if/error etc.
We need to get the bundle Identifier first, for an app it would be like:
mdls -name kMDItemCFBundleIdentifier -r /Applications/Safari.app[/code] It will give you something like: com.apple.Safari%`
Replace /Applications/Safari.app with the create-dmg path
like so mdls -name kMDItemCFBundleIdentifier -r /usr/local/Cellar/create-dmg/1.2.1./bin/create-dmg
This will suddenly give (null)%
But if you get it from the path and drag and drop it to the System Settings > Security & Privacy > Privacy > Full Disk Access panel it will be added
Doing the above, keeps the Apple Event from timeout.
Again thanks so much for making this tool. Hopefully that update will help others that using it on latest Apple systems. :)

Alternative solution via Terminal (doesn't work on Big Sur, which I am testing it right now)
sudo sqlite3 "/Library/Application Support/com.apple.TCC/TCC.db"
INSERT INTO access (service, client, client_type, allowed, prompt_count) VALUES ('kTCCServiceSystemPolicyAllFiles', '/usr/local/bin/create-dmg', 0, 1, 1);

We experience the same issue our our self hosted arm64 github runner.


[Bug]: Websocket demo not working

Describe the bug
I ran the code in https://microsoft.github.io/autogen/docs/notebooks/agentchat_websockets/ without HTML i.e. the first 2 blocks and the agent keeps on producing this
ConnectionClosedOK                        Traceback (most recent call last)
Cell In[14], line 63
     60 websocket.send("Check out the weather in Paris and write a poem about it.")
     62 while True:
---> 63     message = websocket.recv()
     64     message = message.decode("utf-8") if isinstance(message, bytes) else message
     66     print(message, end="", flush=True)

File ~/Desktop/multi-agent-assistant-poc/env/lib/python3.11/site-packages/websockets/sync/connection.py:201, in Connection.recv(self, timeout)
    199     return self.recv_messages.get(timeout)
    200 except EOFError:
--> 201     raise self.protocol.close_exc from self.recv_events_exc
    202 except RuntimeError:
    203     raise RuntimeError(
    204         "cannot call recv while another thread "
    205         "is already running recv or recv_streaming"
    206     ) from None

ConnectionClosedOK: received 1000 (OK); then sent 1000 (OK)

Steps to reproduce
from datetime import datetime

def on_connect(iostream: IOWebsockets) -> None:
    print(f" - on_connect(): Connected to client using IOWebsockets {iostream}", flush=True)

    print(" - on_connect(): Receiving message from client.", flush=True)

    # 1. Receive Initial Message
    initial_msg = iostream.input()

    # 2. Instantiate ConversableAgent
    agent = autogen.ConversableAgent(
        name="chatbot",
        system_message="Complete a task given to you and reply TERMINATE when the task is done. If asked about the weather, use tool 'weather_forecast(city)' to get the weather forecast for a city.",
        llm_config= <MY CONFIGURATION>,
                    "stream": True},
    )

    # 3. Define UserProxyAgent
    user_proxy = autogen.UserProxyAgent(
        name="user_proxy",
        system_message="A proxy for the user.",
        is_termination_msg=lambda x: x.get("content", "") and x.get("content", "").rstrip().endswith("TERMINATE"),
        human_input_mode="NEVER",
        max_consecutive_auto_reply=10,
        code_execution_config=False,
    )

    # 4. Define Agent-specific Functions
    def weather_forecast(city: str) -> str:
        return f"The weather forecast for {city} at {datetime.now()} is sunny."

    autogen.register_function(
        weather_forecast, caller=agent, executor=user_proxy, description="Weather forecast for a city"
    )

    # 5. Initiate conversation
    print(
        f" - on_connect(): Initiating chat with agent {agent} using message '{initial_msg}'",
        flush=True,
    )
    user_proxy.initiate_chat(  # noqa: F704
        agent,
        message=initial_msg,
    )

with IOWebsockets.run_server_in_thread(on_connect=on_connect, port=8765) as uri:
    print(f" - test_setup() with websocket server running on {uri}.", flush=True)

    with ws_connect(uri) as websocket:
        print(f" - Connected to server on {uri}", flush=True)

        print(" - Sending message to server.", flush=True)
        # websocket.send("2+2=?")
        websocket.send("Check out the weather in Paris and write a poem about it.")

        while True:
            message = websocket.recv()
            message = message.decode("utf-8") if isinstance(message, bytes) else message

            print(message, end="", flush=True)

            if "TERMINATE" in message:
                print()
                print(" - Received TERMINATE message. Exiting.", flush=True)
                break

Model Used
gpt-35-turbo-0125
Expected Behavior
No response
Screenshots and logs
No response
Additional Information
No response

Is it solved?


pull request for e2e test at 12/20/2016 10:26:20

:white_check_mark: Validation status: passed
For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Add /datastore/ in emulator URI path.

Fixes #1707.

LGTM.

@tseaver Care to weigh in before I merge?

LGTM


Dead Rising Deluxe Remaster .msg.23 file

Hello, can you update the tool for Dead Rising Deluxe Remaster?
The tool doesn't work in the language file of this game. I uploaded some sample files.
https://gofile.io/d/vO0qLr

https://github.com/dtlnor/REMSG_Converter/releases/tag/1.2.0 try this

Yeah, that worked. Thank you very much.
And thank you for making such beautiful tools.


Infinite loop in HLS Session is Jellyfin item doesn't exist

This actually happens if there is any error on the "get stream item" path in an HLS session

Should be fixed in default HLS mode in #902 - not yet handler in the alternative HLS mode


SDK get failure at creating private key  for  X509

OS and version used:
Ubuntu 16.04.2

Python runtime used:
$ python --version
Python 2.7.12

SDK version used:
$ ~/azure-iot-sdk-python$ git log
commit 5c31ec154440f84f6660a40a48e5e1c2f0356eef
Merge: 9da390f 8b53cd7
Author: Azure IoT Builder<EMAIL_ADDRESS>Date:   Wed Jan 17 22:39:24 2018 +0000
Merge commit '8b53cd7d20a9b080670a4aeee0074f88d1dcbf58' into HEAD

$ openssl version
OpenSSL 1.0.2g  1 Mar 2016
Description of the issue:

It has happened in every times. Below is the reproduce steps:
$ cd azure-iot-sdk-python/build_all/linux/
$ ./setup.sh
$ ./build.sh
$ ls -l azure-iot-sdk-python/device/samples/
合計 3968
-rwxrwxr-x 1 guest guest 3976472  1月 19 10:21 iothub_client.so
-rw-rw-r-- 1 guest guest    2847  1月 18 10:57 iothub_client_args.py
-rw-rw-r-- 1 guest guest    2501  1月 18 11:39 iothub_client_args.pyc
-rw-rw-r-- 1 guest guest    7407  1月 18 10:57 iothub_client_cert.py
-rw-rw-r-- 1 guest guest    3726  1月 18 10:57 iothub_client_prov_args.py
-rw-rw-r-- 1 guest guest    4327  1月 18 10:57 iothub_client_prov_hsm_sample.py
-rwxrwxr-x 1 guest guest   10828  1月 18 10:57 iothub_client_sample.py
-rwxrwxr-x 1 guest guest    8974  1月 18 10:57 iothub_client_sample_class.py
-rw-rw-r-- 1 guest guest   14121  1月 18 15:55 iothub_client_sample_x509.py
-rw-rw-r-- 1 guest guest    8663  1月 18 10:57 iothub_client_shared_transport_sample.py
-rw-rw-r-- 1 guest guest    2570  1月 18 10:57 readme.md

Configure a IoTHub and registered a certificate for test.
Modified below values in ~/azure-iot-sdk-python/device/samples/iothub_client_sample_x509.py
PROTOCOL = IoTHubTransportProvider.MQTT
CONNECTION_STRING = "[Device Connection String]"
X509_CERTIFICATE = (
"-----BEGIN CERTIFICATE-----"
"YYYYYYYYYYYYYYYYYY"
:
:
"YYYYYYYYYYYYYYYYYY"
"-----END CERTIFICATE-----"
)
X509_PRIVATEKEY = (
"-----BEGIN RSA PRIVATE KEY-----"
"XXXXXXXXXXXXXXXXXXXXXX"
:
:
"XXXXXXXXXXXXXXXXXXXXXX"
"-----END RSA PRIVATE KEY-----"
)

$ python ~/azure-iot-sdk-python/device/samples/iothub_client_sample_x509.py
Code sample exhibiting the issue:

There is no changed anythings except, protocol, connection string, certificate, privatekey in the program
iothub_client_sample_x509.py.
Console log of the issue:

Python 2.7.12 (default, Nov 20 2017, 18:23:56)
[GCC 5.4.0 20160609]
IoT Hub for Python SDK Version: 1.2.0
Starting the IoT Hub Python sample...
Protocol MQTT
Connection string=HostName=fufufu.azure-devices.net;DeviceId=fufufu001;x509=true
IoTHubClient sending 5 messages
Error: Time:Fri Jan 19 15:11:55 2018 File:/home/guest/azure-iot-sdk-python/c/c-utility/src/x509_openssl.c Func:log_ERR_get_error Line:21 cannot create RSA* privatekey
Error: Time:Fri Jan 19 15:11:55 2018 File:/home/guest/azure-iot-sdk-python/c/c-utility/src/x509_openssl.c Func:log_ERR_get_error Line:28   [0] error:0906D06C:PEM routines:PEM_read_bio:no start line
Error: Time:Fri Jan 19 15:11:55 2018 File:/home/guest/azure-iot-sdk-python/c/c-utility/src/x509_openssl.c Func:x509_openssl_add_credentials Line:255 failure loading private key cert
Error: Time:Fri Jan 19 15:11:55 2018 File:/home/guest/azure-iot-sdk-python/c/c-utility/src/tlsio_openssl.c Func:log_ERR_get_error Line:420 unable to use x509 authentication
Error: Time:Fri Jan 19 15:11:55 2018 File:/home/guest/azure-iot-sdk-python/c/c-utility/src/tlsio_openssl.c Func:tlsio_openssl_open Line:1239 Failed creating the OpenSSL instance.
Error: Time:Fri Jan 19 15:11:55 2018 File:/home/guest/azure-iot-sdk-python/c/umqtt/src/mqtt_client.c Func:mqtt_client_connect Line:980 Error: io_open failed
Error: Time:Fri Jan 19 15:11:55 2018 File:/home/guest/azure-iot-sdk-python/c/iothub_client/src/iothubtransport_mqtt_common.c Func:SendMqttConnectMsg Line:1784 failure connecting to address fufufu.azure-devices.net.
IoTHubClient.send_event_async accepted message [0] for transmission to IoT Hub.
IoTHubClient.send_event_async accepted message [1] for transmission to IoT Hub.
IoTHubClient.send_event_async accepted message [2] for transmission to IoT Hub.
IoTHubClient.send_event_async accepted message [3] for transmission to IoT Hub.
IoTHubClient.send_event_async accepted message [4] for transmission to IoT Hub.
IoTHubClient waiting for commands, press Ctrl-C to exit
Send status: BUSY
Error: Time:Fri Jan 19 15:11:56 2018 File:/home/guest/azure-iot-sdk-python/c/c-utility/src/x509_openssl.c Func:log_ERR_get_error Line:21 cannot create RSA* privatekey
Error: Time:Fri Jan 19 15:11:56 2018 File:/home/guest/azure-iot-sdk-python/c/c-utility/src/x509_openssl.c Func:log_ERR_get_error Line:28   [0] error:0906D06C:PEM routines:PEM_read_bio:no start line
Error: Time:Fri Jan 19 15:11:56 2018 File:/home/guest/azure-iot-sdk-python/c/c-utility/src/x509_openssl.c Func:x509_openssl_add_credentials Line:255 failure loading private key cert
Error: Time:Fri Jan 19 15:11:56 2018 File:/home/guest/azure-iot-sdk-python/c/c-utility/src/tlsio_openssl.c Func:log_ERR_get_error Line:420 unable to use x509 authentication
Error: Time:Fri Jan 19 15:11:56 2018 File:/home/guest/azure-iot-sdk-python/c/c-utility/src/tlsio_openssl.c Func:tlsio_openssl_open Line:1239 Failed creating the OpenSSL instance.
Error: Time:Fri Jan 19 15:11:56 2018 File:/home/quest/azure-iot-sdk-python/c/umqtt/src/mqtt_client.c Func:mqtt_client_connect Line:980 Error: io_open failed
Error: Time:Fri Jan 19 15:11:56 2018 File:/home/guest/azure-iot-sdk-python/c/iothub_client/src/iothubtransport_mqtt_common.c Func:SendMqttConnectMsg Line:1784 failure connecting to address fufufu.azure-devices.net.
Error: Time:Fri Jan 19 15:11:58 2018 File:/home/guest/azure-iot-sdk-python/c/c-utility/src/x509_openssl.c Func:log_ERR_get_error Line:21 cannot create RSA* privatekey
Error: Time:Fri Jan 19 15:11:58 2018 File:/home/guest/azure-iot-sdk-python/c/c-utility/src/x509_openssl.c Func:log_ERR_get_error Line:28   [0] error:0906D06C:PEM routines:PEM_read_bio:no start line
Error: Time:Fri Jan 19 15:11:58 2018 File:/home/guest/azure-iot-sdk-python/c/c-utility/src/x509_openssl.c Func:x509_openssl_add_credentials Line:255 failure loading private key cert
Error: Time:Fri Jan 19 15:11:58 2018 File:/home/guest/azure-iot-sdk-python/c/c-utility/src/tlsio_openssl.c Func:log_ERR_get_error Line:420 unable to use x509 authentication
Error: Time:Fri Jan 19 15:11:58 2018 File:/home/guest/azure-iot-sdk-python/c/c-utility/src/tlsio_openssl.c Func:tlsio_openssl_open Line:1239 Failed creating the OpenSSL instance.
Error: Time:Fri Jan 19 15:11:58 2018 File:/home/guest/azure-iot-sdk-python/c/umqtt/src/mqtt_client.c Func:mqtt_client_connect Line:980 Error: io_open failed
Error: Time:Fri Jan 19 15:11:58 2018 File:/home/guest/azure-iot-sdk-python/c/iothub_client/src/iothubtransport_mqtt_common.c Func:SendMqttConnectMsg Line:1784 failure connecting to address fufufu.azure-devices.net.

@robertarm thank you for your contribution to our open-sourced project!  Please help us improve by filling out this 2-minute customer satisfaction survey


target = target.resize(image.size)  AttributeError: 'list' object has no attribute 'resize'

fcos_core/data/transforms/transforms.py line 61, in call  report "AttributeError: 'list' object has no attribute 'resize'". When I change it to "target = F.resize(target, size),  it reported " TypeError: img should be PIL Image. Got <class 'list'>" . Can you help me?

I found that this error may be related to the version of torchvision. what is your version of torchvision

Hi, we use torchvision == 0.21, as illustrated in INSTALL.  The published code should be able to run directly without other modifications.

Thanks a lot! Installing the version as illustrated in INSTALL, there is no problem.

Hi, we use torchvision == 0.21, as illustrated in INSTALL. The published code should be able to run directly without other modifications.


Fix for groups: get start index by group name/ value.

Not thoroughly tested though but works well for my use case.

Thanks a lot @alexandrnikitin for your changes! Just reformat the code and merged into master branch.


Not wrapping content

As per question on Stackoverflow Flexbox shrinks the content. Expected outcome was that, lets say, if just three categories only could be fitted in first, then, next items should appear in next line.

Any help would be appreciated. Thank you.

Umm, if you set the flex_wrap attribute as wrap, the content will be wrapped if a new view doesn't fit in the current line.
But could you try setting the flexShrink in the FlexboxLayout.LayoutParams to 0 for each child view to see how it goes?
It will prevent each child from being shrank at all.

Also what version of the FlexboxLayout are you using?

I am using 0.2.2 version of Flexbox.

Thanks.
Could you confirm also the first question?

But could you try setting the flexShrink in the FlexboxLayout.LayoutParams to 0 for each child view to see how it goes?
It will prevent each child from being shrank at all.

Plus, let me ask you another question.
From looking at the image you pasted, the labels seems neither being wrapped nor shrank. (It looks like the labels seem to fit in the first line)
Could you paste another screenshot with adding another label so that labels would be wrapped (or shrank)?

Hi, any updates on this one?
Is the issue still persistent?

Hello @thagikura I was able to solve the issue but I am not able to reproduce it.You can close the issue. Still if i encounter in future, I will definitely let you know. Thanks for your guidance.

Ok, thanks for the update.


UI: badge size

Badges in README.md aren't displayed appropriately; they're too big.

Hi @johnnychen94  This is fixed in the latest version, please give it a try 😄

@kezhenxu94 wow! Looks like you made a lot of changes since then, and I like the current design of repo page.

@johnnychen94 I hope you enjoy it and the notifications page which is newly added, feel free to give feedback 😄


"Label" button does not allow multiple annotators

Describe the bug
Completing a task in Label mode removes that task from Label mode for all other users.
To Reproduce
Steps to reproduce the behavior:

Spin up a fresh label studio instance in docker. Create a user and login.
set up a project with the following label config:

<View>
  <View>
    <Paragraphs name="dialogue" value="$dialogueField"
     layout="dialogue" savetextresult="yes" nameKey="nameKey" textKey="textKey"/>
  </View>
  <View >
    <ParagraphLabels name="actions" toName="dialogue">
      <label value="Label A" alias="a"/>
      <label value="Label B" alias="b"/>
      <label value="Label C" alias="c"/>
    </ParagraphLabels>
  </View>
</View>

import tasks using the following json:

[
    {
        "dialogueField": [{
            "nameKey": "speaker a",
            "textKey": "Boris Johnson has promised football groups that the government will consider using what he called “a legislative bomb” to stop English clubs joining a breakaway European Super League, as official efforts to thwart the plan were stepped up."

        },
        {
            "nameKey": "speaker b",
            "textKey": "The prime minister and Oliver Dowden, the sports and culture secretary, held a meeting with the heads of the Football Association and Premier League, as well as representatives of fans’ groups from Liverpool, Manchester United and Tottenham Hotspur, three of the clubs involved."

        }
        ]
    },
    {
        "dialogueField": [{
            "nameKey": "speaker a",
            "textKey": "At one point, according to sources, Johnson told the event: 'We should drop a legislative bomb to stop it – and we should do it now.'"

        },
        {
            "nameKey": "speaker b",
            "textKey": "Plans to legislate would seemingly pass through parliament easily, with Labour saying it would support a law on the issue."

        }
        ]
    }

]

Click "Label"
Annotate the task and hit submit
Log out.
Create a new user and log in.
Go to the project you created in step 2 and click "Label"
Observe the fact you are on the second task, with no way to get to the first.

Expected behaviour
Completing a task as a user should not remove it from other users' task lists. I'd expect the tasks listed in the Label interface to be controlled by the filters  on the active tab.
Screenshots
If applicable, add screenshots to help explain your problem.
Environment (please complete the following information):

OS: [e.g. iOS]
Label Studio Version: latest at time of writing.

Additional context
Add any other context about the problem here.

After some discussions in the slack channel, apparently this is by design and the behaviour I describe in "expected behaviour" is in the roadmap 👍 . Closing the bug

@tClelford Could you put a link to the slack message here please?

Of course! https://label-studio.slack.com/archives/CQ8LYPPJS/p1619031651456900?thread_ts=1618849026.301100&cid=CQ8LYPPJS


✨ Support JSON access a->b

/// JSON access (postgres)  eg: data->'tags'
JsonAccess {
    left: Box<Expr>,
    operator: JsonOperator,
    right: Box<Expr>,
},

There are a few json accessors supported by SQL parser, each should be reviewed

limited initial support, there appears to be a bug in the parser
a->'b' = 'c'
should be interpreted as a['b'] = 'c', but is interpreted as a['b' = 'c'], limiting it's use at the moment


added an endpoint for task assignment

closes #764

added an endpoint that can be used to assign tasks to the user, the user can hit this endpoint and a task will get assigned to them if it is available
We can remove the assignTask middleware when this PR gets merged

Hey @vinayak-trivedi , please assign this issue to me!


Disposables in setupMode in official plugins are unused

monaco-editor version: 0.27.0
Browser: N/A
OS: N/A
Playground code that reproduces the issue: N/A
In monaco-css, monaco-html, monaco-json, and monaco-typescript, there is a function named setupMode. This function sets up editor features, then returns a disposable, which combines a number of collected disposables. However, where setupMode is used in contribution.monaco.ts, the return value is unused.
I’m wondering if if the disposables are supposed to be used or if the return value, and therefor the array of disposables should be removed.

We've never implemented the ability to "unload" a language, so the disposables are never called.

Is this something that’s planned? Otherwise I’m going to remove the disposable logic from monaco-yaml

There's no plans to add unloading a language.


fix: change working from activate to deposit

Pull Request Test Coverage Report for Build 737

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 16.642%

Totals

Change from base Build 735:
0.0%

Covered Lines:
193

Relevant Lines:
949

💛  - Coveralls