Preserve flag for signature

If signature should preserve or not

@gcacace saving bitmap in Parcelable was crashing so i want to disable for my usecase


mistyped pattern name in css syntax

It's trivial but it should be fixed.

@phynalle Good catch! We have a script that take the grammar from https://github.com/atom/language-css/blob/master/grammars/css.cson. So the fix needs to be made in that repo. Can you make the PR (or file an issue) there?

I created https://github.com/atom/language-css/issues/133


iOS11 can not scan the code !!!

The same string,using same other web site created, iOS 11 can,using qrcode is not!

The string is vcard,which like this:
BEGIN:VCARD
VERSION:3.0
FN:San Zhang
TEL:(+86)13912345678
TITLE:Director of Strategy
TEL;WORK;VOICE:(+86)755-88888888-6302
<EMAIL_ADDRESS>END:VCARD


Add hfs kyber nist round three

Okay. This is ready for review. I got rid of all the .unwrap() calls except for the two located in the "generate" method:
    /// Generate a new private key.
    fn generate(&mut self, _rng: &mut dyn Random) {
        // Oqs uses their own random generator
        let kemalg = kem::Kem::new(kem::Algorithm::Kyber1024).unwrap();
        let (pk, sk) = kemalg.keypair().unwrap();
        self.alg = kemalg;
        self.pubkey = pk;
        self.privkey = sk;
    }

Should I change the function signature or keep it as is?

Note that until https://github.com/open-quantum-safe/liboqs/issues/909 and https://github.com/cloudflare/circl/issues/213 are resolved we should NOT merge this pull-request; The issue is that the liboqs Kyber is not compatible with Cloudflare's Golang Circl library's Kyber. I want them to be compatible because I'm using them both in my software. Obviously they should be compatible, but alas they are not.
That having been said, please do review this PR! I will make requested corrections and maintain this branch until the above compatibility issues are resolved. Thanks and cheers!

As Thom pointed out, the current Rust crate implements Round 2 Kyber, whereas Circl has been updated to Round 3 Kyber.  You'll have to wait for a release of libels or use an older version of Circl. https://github.com/katzenpost/noise/issues/9#issuecomment-778034278

As Thom pointed out, the current Rust crate implements Round 2 Kyber, whereas Circl has been updated to Round 3 Kyber. You'll have to wait for a release of libels or use an older version of Circl. katzenpost/noise#9 (comment)
Note that it is quite possible there will be more breaking changes to Kyber in the future.

@bwesterb I'm hoping that the maintainer of snow @mcginty will allow us to just use the main branch of the oqs rust crate for the time being until he releases a new version number.

I've confirmed that this branch can interoperate with the Katzenpost fork of Go noise:
https://github.com/katzenpost/noise

As Thom pointed out, the current Rust crate implements Round 2 Kyber, whereas Circl has been updated to Round 3 Kyber. You'll have to wait for a release of libels or use an older version of Circl. katzenpost/noise#9 (comment)
Note that it is quite possible there will be more breaking changes to Kyber in the future.

@bwesterb I'm hoping that the maintainer of snow @mcginty will allow us to just use the main branch of the oqs rust crate for the time being until a new version of the oqs crate is released. Or better yet, a specific commit id from the main branch that way it won't just break unexpectedly one day.

Given that Kyber support is still an experiment hidden behind a non-default feature flag, this seems fine.

@mcginty Alright I've made the corrections you specified but now I'm wondering if you can help me figure out why the build fails:
user@computer:~/code/snow$ cargo build --features nist3_kyber1024
warning: panic message contains braces
   --> src/params/patterns.rs:580:48
    |
580 |         "handshake messages contain one of the {{'e1', 'ekem1'}} tokens, but not the other",
    |                                                ^^             ^^
    |
    = note: `#[warn(non_fmt_panic)]` on by default
    = note: this message is not used as a format string, but will be in a future Rust edition
help: add a "{}" format string to use the message literally
    |
580 |         "{}", "handshake messages contain one of the {{'e1', 'ekem1'}} tokens, but not the other",
    |         ^^^^^

warning: 1 warning emitted

    Finished dev [unoptimized + debuginfo] target(s) in 0.16s

@mcginty Alright I've made the corrections you specified but now I'm wondering if you can help me figure out why the build fails:
user@computer:~/code/snow$ cargo build --features nist3_kyber1024
warning: panic message contains braces
   --> src/params/patterns.rs:580:48
    |
580 |         "handshake messages contain one of the {{'e1', 'ekem1'}} tokens, but not the other",
    |                                                ^^             ^^
    |
    = note: `#[warn(non_fmt_panic)]` on by default
    = note: this message is not used as a format string, but will be in a future Rust edition
help: add a "{}" format string to use the message literally
    |
580 |         "{}", "handshake messages contain one of the {{'e1', 'ekem1'}} tokens, but not the other",
    |         ^^^^^

warning: 1 warning emitted

    Finished dev [unoptimized + debuginfo] target(s) in 0.16s

That's a benign warning - your build is failing on windows because of liboqs (I imagine it was failing before your change as well - I just enabled Windows CI a few hours ago):
https://github.com/mcginty/snow/pull/106/checks?check_run_id=1897933780#step:4:661

The current issue the CI failures are seeing is due to bindgen. There's an issue similar to it here. Maybe we could try pointing it at the runner's clang installation in the environment variable?

The current issue the CI failures are seeing is due to bindgen. There's an issue similar to it here. Maybe we could try pointing it at the runner's clang installation in the environment variable?

I have no idea how to do that.

Closing, since it's aged long enough.


Online-841 Adds support for Financial Assistance Request denied email

Pre-Flight checklist

[x] Screenshots and design review for any changes that affect layout or styling

[x] Desktop screenshots

[x] Testing

[x] Code is tested
[x] Changes have been manually tested

What are the relevant tickets?
Fixes https://github.com/mitodl/mitxonline/issues/841
What's this PR do?
Adds support for an admin to add custom email content while denying a financial assistance request.
Also, Data in the modal is reduced as we are showing info on the listing.
How should this be manually tested?

Submit a financial assistance request.
Visit the flexible pricing in the staff dashboard.
Deny a request.
Modal will ask for the Email body and Email subject and both are required fields.
Add the email subject and body and click ok.
Email with the provided contents will be sent to the user.

Screenshots (if appropriate)

Codecov Report

Merging #851 (f72cd81) into main (4e21d58) will increase coverage by 0.17%.
The diff coverage is 63.63%.

@@            Coverage Diff             @@
##             main     #851      +/-   ##
==========================================
+ Coverage   85.16%   85.34%   +0.17%
==========================================
  Files         132      132
  Lines        5932     5949      +17
  Branches      981      982       +1
==========================================
+ Hits         5052     5077      +25
+ Misses        722      713       -9
- Partials      158      159       +1

Impacted Files
Coverage Δ

flexiblepricing/mail_api.py
72.22% <33.33%> (+34.29%)
:arrow_up:

flexiblepricing/tasks.py
92.30% <50.00%> (+1.00%)
:arrow_up:

flexiblepricing/views/v0/__init__.py
92.15% <100.00%> (+1.24%)
:arrow_up:

ecommerce/discounts.py
77.19% <0.00%> (-1.76%)
:arrow_down:

ecommerce/views/v0/__init__.py
86.55% <0.00%> (+0.42%)
:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Change default parameters

Some of the defaults turned out to be suboptimal.
Heres a list of things I intend to change:

OpenMMSimulation(;temp): 310 Kelvin
Iso(;opt): NesterovRegularized
Iso(;minibatch): this is difficult, it depends..., but 0 is certainly no good choice.
CUDA default for Iso and OpenMMSimulation if CUDA is available.

randx0 for OpenMM will be delegated to laggedtrajectory

implemented in  c5f09af

autoplot is not enabled by default anymore, but can be set simply by passing an Int to the autoplot kwarg of Iso
7ece9d1


ADS: List Items specs

Task/Issue URL:
Description
Steps to test this PR
Feature 1

[ ]
[ ]

UI changes

Before
After

!(Upload before screenshot)
(Upload after screenshot)

Current dependencies on/for this PR:

develop

PR #2510

PR #2519
PR #2521   👈

This comment was auto-generated by Graphite.


dnu restore using old version of Newtonsoft.Json.Dll

When doing a dnu restore I get the following error:
System.MissingMethodException: Method not found: 'Newtonsoft.Json.Linq.JValue Newtonsoft.Json.Linq.JValue.CreateNull()'.
Reading up on this I've found that older versions of Newtonsoft.Json do not have the method CreateNull().
I had v<IP_ADDRESS> in my GAC, which I have removed and added v<IP_ADDRESS>.  This did not help.
I found a couple of old versions in Native Image directories in my GAC, which I have removed, still no help.
Searching my machine finds a lot of copies of this.  So, how can I find out where it's getting the bad one from and either remove it or tell it to use a different one?

Many thanks, process explorer found the dodgy version and once deleted it now works.


Fix 3.0.4 issue if requirements not set

What does this PR do?
3.0.4 introduced a slight issue that if galaxy isn't used, the tmp_dep_dir variable is never set and so the openshift-applier role always crashes.  My fix just skips the affected task, but the surrounding logic looks like it would be ok (unnecessary round trip of the ANSIBLE_ROLES_PATH env variable, but not a big deal).
How should this be tested?
cp -r openshift-applier/roles . # current directory has a valid playbook
ansible-playbook -i hosts.yaml playbook.yaml
Is there a relevant Issue open for this?
Didn't open an issue.
Who would you like to review this?
cc: @redhat-cop/openshift-applier @oybed

Thank you for submitting this PR and finding this issue.
The pre/post steps shouldn't really execute unless they are defined in the inventory, and the only way to pull in pre/post steps right now are through a galaxy_requirements and/or galaxy_sources - so from that perspective this issue shouldn't really happen. Is this a problem perhaps when running in a bit of a modified environment - for example if/when a set of roles are copied into the openshift-applier directory (or otherwise coping the openshift-applier role into another set of roles) as part of executing the playbook? Reading the testing steps, this seems to perhaps be the case.
Just trying to understand how this issue is reproduced.


Adjusting background image creates strange bugs.

I'm having a bug where the health bar of damaged ships is cut up. Like this:
http://i.imgur.com/3wDzwcF.png
The anchor icons for construction reappeared after I constructed some ships, but they vanished completely after changing the background of the flash object through the settings.
Verniy's name is spelled wrong. Comes out as Vernyj

Thanks for reporting~
The HP bars are fixed on 51d749aff81f25ac9d9cded386cba5564206d1ed
About the construction icons, did you refresh the game screen? If so, you'll also need to refresh the panel as well. The recommended procedure is:

Refresh game (but do not click the "Start game anyway")
Close admiral panel
Reopen admiral panel
Go to KC3 Kai tab to activate the game

Verniy's name has also been fixed on d73213f430128b95c9d13c7b0b917c516ccceef5
Thanks again~


update readme.md

Hello.
Please update readme.md install_path based with docker image.
Refer to https://hub.docker.com/r/sonatype/nexus3,
installation of Nexus is to /opt/sonatype/nexus.
A persistent directory is /nexus-data.
Thanks,

@Hokwang Thanks, I will update the readme as soon as possible.

@Hokwang Sorry, I didn't found the place where needs to modify for the two directory. It seems that the two paths aren't  mentioned or are already changed in the docker container creating scripts.
Please just tell me the exact place where should be updated. Thanks!


Bypass OpenAI server overload

When loading ontologies into CurateGPT the insertion of the data into chromaDB is very often interrupted because of a server overload on the API side.
openai.error.ServiceUnavailableError: The server is overloaded or not ready yet.
Implementing the exponential_backoff_request helped me to bypass this by trying again with an additional small sleep every time it would fail.
Its not a fancy solution but it can get the job done.
Additionally, when playing around for me it helped adding less sleep (from 60 to 10s) if the doc length reaches more than 3000000 chars.
Also a batch size of 1000 worked better than a batch size of 100 for me. Having smaller batch sizes than 100 mostly ended in this:
requests.exceptions.ConnectionError: ('Connection aborted.', RemoteDisconnected('Remote end closed connection without response'))
This was all pretty experimental and it might also depend on other factors.
@cmungall
@justaddcoffee

+1 I ran into this issue that @iQuxLE mentions above:

openai.error.ServiceUnavailableError: The server is overloaded or not ready yet.

a fix here would help me a lot, as I can't seem to get make all to complete b/c of this issue

Hi Carlo @iQuxLE!
It looks like the .idea changes are still a part of the diff - ideally a PR only has a single concern, see the monarch/bbop best practice doc https://berkeleybop.github.io/best_practice
If it's too much of a hassle to change we can merge and then delete later but I prefer to keep the history clear

@iQuxLE could you remove the .idea/ per @cmungall's comment above?
Also on this ticket, @iQuxLE is observing a different error from OpenAI now when retrieving LLM embeddings - a 500 server error. Possibly we could catch this error too when we are doing the exponential backoff

Hi @justaddcoffee and @cmungall,
It seemed to be fairly complicated. Sorry took me some time. I hope its as wished now, I did not try to close, I think this happened automatically.


Fixed build errors on ArchLinux

I fixed some errors that prevented me from compiling and running the examples on 64-bit Arch Linux.

Can this be closed? As it is already now using vulkan-hpp


JAXB Gradle plugin implementation

Adds XJC task for jaxb in shema project.
Also, in a few projects, adds non-java resources from src/main/java to build folder [gradle] as they are excluded by default.

Thanks a lot for doing this work!


completeFunctionParens adds unnecessary parentheses for cached properties

Environment data

Language Server version: 2022.4.2
OS and version: darwin x64
Python version (and distribution if applicable, e.g. Anaconda): 3.10.4 | packaged by conda-forge | (main, Mar 24 2022, 17:43:32) [Clang 12.0.1 ]
python.analysis.indexing: null
python.analysis.typeCheckingMode: basic

Expected behaviour
Completions for class methods with functools @cached_property decorators should not add parentheses, even when "python.analysis.completeFunctionParens": true. The completions behave properly (i.e. do not add parentheses) for methods with the @property decorator, so this would provide consistent, identical behaviour for  @property and @cached_property.
Actual behaviour
When "python.analysis.completeFunctionParens": true, parentheses are added to completions for class methods which have the a @cached_property decorator. This will usually cause a TypeError if the parentheses are not manually removed.
Code Snippet / Additional information
#!/usr/bin/env python3
# -*- coding: utf-8 -*-
from functools import cached_property

class C:
    @cached_property
    def x_cached(self):
        return 'x'

    @property
    def x_property(self):
        return 'x'

c = C()

c.x_cached() # current incorrect completion for @cached_property - this completion will cause a TypeError when run
c.x_cached   # suggested correct completion - this will run correctly and be consistent with @property

c.x_property # current correct completion for @property

This is another case where we should replace the internal call isPropertyClass(x) with isMaybeDescriptor(x, false) so we treat all descriptors (regardless of whether they're properties) the same.

Closing as this is behaving properly in our latest releases.
As a side note, the semantic highlighting is also correct now. x_cached is now colored as a property instead of as a function.


/lib/misc.zsh:3: parse error near `then'

I just pulled the latest master<PHONE_NUMBER>b, and I am getting a
/Users/marchi/.oh-my-zsh/lib/misc.zsh:3: parse error near `then'

I did a git pull manually. Did I need to do something else?

if [[ -e "$d/url-quote-magic" ]]; then
There must be a space follow magic"

Ah, thanks, that fixes it. Should I PR?

Please NOTE this is fixed in #4002 already! no need to submit your own PR.

Okay, closing this one then. Thanks!!


feature request: manually call setupMedia and assign canvas Element by object refs

is that possible to add a property something like 'autosetup' to control Whether call this.setupMedia() on mounted or not?

autosetup: {
      type: Boolean,
      default: true
    },

so that we can give user to show some guide ui before the browser pop up the permission request on page load.

i want to integration something like opencv or face detect api that required to setup a canvas element .

    /**
     * get canvas
     */
    getCanvas() {
      let video = this.$refs.video;
      if (!this.ctx) {
        let canvas = document.createElement("canvas");
        canvas.height = video.videoHeight;
        canvas.width = video.videoWidth;
        this.canvas = canvas;
        this.ctx = canvas.getContext("2d");
      }
      const { ctx, canvas } = this;
      ctx.drawImage(video, 0, 0, canvas.width, canvas.height);
      return canvas;
    }

so is that possible to add a property something like 'canvasEl'
canvasEl: {
      type: Object,
      default: null
    },

so change code into something like this:
if(this.$refs.canvasEl !==null){
	let canvas = this.$refs.canvasEl
}

i created a PR for this, maybe it could be helpful.
https://github.com/VinceG/vue-web-cam/pull/62


Modify list parameters handling in tx build

Modify list parameters handling to remove useless OpCodes and reduce fees.

Coverage: 80.972% (-0.03%) from 81.0% when pulling ad3f136a5fbbc7acafa044d67475ae305f64e864 on NeoDashboard:master into bcb1ef1aa7d4c414d19bce83d048a62acc4fb30a on CityOfZion:master.

Do you still want to continue on this?


Java SDK WIP

This is an initial PR for the development of Java SDK.
You can continue from here.

This PR is closed for now and work on it will resume soon.
Thanks @SnirX 🙏🏽 🥇


Problem after creating new panel

Package
filament/filament
Package Version
v3.0.0-beta7
Laravel Version
v10
Livewire Version
v3
PHP Version
v8.2
Problem description
After generate new panel using docs if you switch to new panel then try to logout from new app.
Also happens before login, switch to new panel using url.
This can be fixed after putting ->login() inside newPanelServiceProvider configuration. so, suggest to auto put ->login() while generating/create new panel
Expected behavior
No error
Steps to reproduce
Generate new panel, logout from existing panel and navigate new panel using url (without login)
If you clone this project then

install and serve
navigate to {url}/agent

If you go to {url}/app then it's working because I put ->login() inside configuration, but if you try /agent then this problem came
Reproduction repository
https://github.com/valpuia/filament-v3
Relevant log output
Filament\Http\Middleware\Authenticate::redirectTo(): Return value must be of type string, null returned

This is designed behavior.

How to solve this problem ?


Merging latest fixes in Master branch

The changes include

Windows caching fix for file paths.
Correcting mode value in stat_nova.
adding more details in result of oval scanner.

Wow, I had no idea we've been building docker images for every PR for the last dozen years.
That cent7dev.dockerfile is failing because of a missing pip repository? I have to assume it was a transient error. The link is broken...
https://hub.docker.com/repository/registry-1.docker.io/hubblestack/cent7dev/builds/033cfc9f-03c3-40ae-8ea0-4d24319209fa

There's no way that webhook has worked since like 2016 or worse. I don't understand why it's blocking PRs suddenly starting today... I deleted the webhook here and on dockerhub.

Can I merge the PR if it is not an issue?

Indeed. I recommended an admin merge in Slack. I don't understand why there's no way for admin's to clear a spurious check-block.


Connector plugin has godocs

Description
This will be as simple as copying over the README and reformatting it for godocs, the putting it in a doc.go in the plugin.connector package.
We will not support the current markdown version of the docs.
AC:

[ ] Godoc has same content as current PLUGIN_README, converted into godoc format
[ ] Godoc has been viewed using local server and formatting looks good
[ ] The CONTRIBUTING plugin section is updated to link to the public godocs.
[ ] TW has reviewed it

Closing, since we defer any godoc updates until we have formal doc updates that we can link to


Integration error

This is a weird one as it hasn’t actually stopped working.. all is good, but every now and then, I get this notification:

Any ideas?

+1, my Home Assistant is running very slow with the add-on enabled and loses connection a lot. When I disable the add-on, everything runs smoothly again.

+1

@fuatakgun Could you look into this?

Folks, let's be mindful for a minute and explain to me how I can look at this?
There is a bug template to be used and you are just dismissing it and expecting me to find the problem with no information.
Please follow the bug template and create a new issue


Support for common CSS units

Added support for common CSS units like em, rem, vh, etc.

Thanks for this! Looks good 👍


fix(storage): fix base compaction constraint

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
as title, I've observed that l0 is heavily stacked in the q20 benchmark, and I've made a fix by loosening the constraints.

Checklist

[ ] I have written necessary rustdoc comments
[ ] I have added necessary unit tests and integration tests
[ ] I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features #7934).
[ ] My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
[ ] All checks passed in ./risedev check (or alias, ./risedev c)
[ ] My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)

[ ] My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

[ ] My PR contains user-facing changes.

Click here for Documentation
Types of user-facing changes
Please keep the types that apply to your changes, and remove the others.

Installation and deployment
Connector (sources & sinks)
SQL commands, functions, and operators
RisingWave cluster configuration changes
Other (please specify in the release note below)

Release note

before

after

LGTM

related to https://github.com/risingwavelabs/risingwave/issues/11057


Selected Preset Feedback

Great work on the PTZ module already - love the thoroughness of the variables and feedback states.
Is it possible to include feedback for the recalled preset? Ie, if you have a bank of 10 presets, you’d be able to see at a glance camera X is sitting on Y position. This would help when operating multiple cameras.
Thanks for your work!

I only have access to this camera for a few more days (Canon sent it to me for development) but it does look like the property p:=1 is in the info when on preset 1, for example. However, if you move the camera manually after recalling a preset, that doesn't change. So, we could track it like "last preset used", but can't necessarily guarantee that it would still be in that position.
Your thoughts about that?

I think that would still be valuable. I've had camera assistants chasing 3 or 4 cameras and it would give them a visual cue when they flick back over to a camera to see at a glance at what position they are in (assuming they're not making further manual adjustments after recalling as you mention). I'm guessing there's no way to cancel out the feedback if any manual adjustment is made? Would that have to happen on the Canon side of things?
Also - I notice you have Preview Tally feedback in there – does the N300 have a green tally lamp? I've only been able to find the red one in the native IP interface. Do you have future use case for Preview Tally, or is that an N500 thing?

One more thing (sorry for the jump around, just while it's top of mind!) – is it possible to add a Toggle power ON/OFF? I can think of instances where a single push to toggle would help reduce number of button real estate rather than having separate buttons for ON and OFF, and would avoid having to use the latch function. On that note, I don't seem to be getting feedback for the Standby vs Idle?

The problem with canceling out the feedback is that the module can poll the camera on an interval for the latest data (and it really should, for the best use of the module), and any time it polls, it will receive that (potentially incorrect) value again. So canceling it out would not be effective except between update cycles.

Ok, you'll know much better than me... Is it possible to implement the last Preset feedback scenario?

Yes, I've already coded it, testing it here in a few minutes.
Also coded the power toggle.

And I did find a bug related to the power state feedback, so I think that will work on the next version I push.

Amazing! will check that out.
Is there a way to automate the green preview tally into the module instance settings? I can see how to do that using Triggers, but takes a bit of back and forth if changing inputs (ie the module turns on the tally when switching to program, but doesn't alternate red/green when cutting between program/preview).  Ideally the tally in the module's instance would account for when a camera is utilized in a Key or Supersource...though I appreciate that this becomes a much bigger matrix!

Any chance of implementing a "White Balance Calibration" command (ie to lock a custom WB while in the A or B modes?)

I think that tally logic depends on the other modules or programs determining the tally. But I can add a toggle between pvw and pgm lights on the camera. I can't see the front of the camera right now, it's offsite. So we will have to do some testing here to see if sending the preview tally on command automatically turns off the red, or if we also have to send a red off first.

pvw/pgm tally toggle added. will need your help testing.
white balance calibration with dropdown of a, b added.

It looks like if you have the camera in manual wb for example and run the wb calibrate on a for example, it will switch to A mode and then run that. just fyi.

Ok, I've added these to the repo. If you're running your own dev version, just clone this to the module-local-dev folder. Otherwise I'll add it to the beta builds later and ping you when that's done.

Thanks Joseph, nice work on this!

@davidjoshuaford it's in the latest betas now too. Building now.


Comment handling

Hi, this is very nice crate!
I want to use this to create the formatter of a language.
Is there any recommendation to handle comment?
I understand comment can be inserted to parser definition like below:
Expression: [Comment] Factor [Comment] { Op [Comment] Multiplication [Comment] }

But this is very complicated.
If the adjacent comment tokens are automatically captured to terminal tokens like below, it may be usefull.
pub struct Token<'t> {
    pub token_type: TerminalIndex,
    pub location: Location,
    pub comments: Vec<Token<'t>>,
    /* private fields */
}

Hi @dalance
If you want to handle comments in your grammar processing and not just skip them, there is currently no support from parol.
You have to formulate your grammar to include comments and to tie them to the correct syntactical element.
I used the same method in parol_ls language server which also provides formatting support.
I know this is cumbersome but it provides you the exact association between comments and grammar elements with AST types nicely generated similar to the one you mentioned above.

Thank you for your suggestion.
I'll try to add comment to my grammar definition.

Yeah  👍
There is no general assumption one can make about where the comments belong to. To the element below? To the element left of the comment?
Maybe one can define some tricky extension in the parol grammar to support this in a future version.
I think it's worth thinking about it because it might be a problem many users face somehow (including me 😉).


Limit the bot to only work in the given Discord

At the moment Discord shows "Add bot to your server" button. It shouldn't be possible to add this bot to any other server.

Readme will need to be updated to ensure bot isn't being invited to other servers, Default Authorization Link should be set to 'None'


Remote process picker does not work (attach to Docker container scenario)

Environment data
MacOS BigSur 11.4
.NET SDK 5.0.301
VS Code 1.57.0
C# extension 1.23.12
Docker extension 1.13.0
Docker Desktop for Mac version 3.3.3
OmniSharp log
Steps to reproduce

Create new web API project: dotnet new webapi --no-https
Open application folder in VS Code
When prompted, add "required build files" to workspace
Run Docker: add Docker files to workspace command. Select ".NET ASP.NET Core", Linux, port 5000, yes to optional Docker Compose files
Change first line of the Dockerfile so that it reads FROM mcr.microsoft.com/dotnet/aspnet:5.0-focal AS base (note the image tag is 5.0-focal, not just 5.0
Right-click Dockerfile and choose "build image"
Switch to Docker view (whale icon), right-click the application image (expand to see the "latest" tag), and choose "Run"
Open .vscode/launch.json and add the following debug configuration

{
    "name": "Docker .NET Core Attach",
    "type": "docker",
    "request": "attach",
    "platform": "netCore",
    "processId": "${command:pickRemoteProcess}"
}

Make the added debug configuration active and execute it. Select "Individual Containers" group, then the running application container. When prompted, allow debugger to be copied to the application container.

Expected  behavior
After the debugger is copied to the application container, the user should be prompted to select the process to attach to.
Actual behavior
An error message that says "No process with the specified id is currently running"
Additional information
When Docker extension resolves the debug configuration, it will return the following:
{
  "name": "Docker .NET Core Attach",
  "justMyCode": false,
  "platform": "netCore",
  "processId": "${command:pickRemoteProcess}",
  "processName": undefined,
  "request": "attach",
  "type": "coreclr",
  "sourceFileMap": {
    "/src": "${workspaceFolder}"
  },
  "pipeTransport": {
    "debuggerPath": "/remote_debugger/vsdbg",
    "pipeCwd": "${workspaceFolder}",
    "pipeProgram": "docker",
    "quoteArgs":  false,
    "pipeArgs": [
      "exec",
      "-i",
      "application_container_name"
    ]
  }
}

(application_container_name is the name of the running application container)
This used to work until recently--the user would be prompted to select the process to attach to. I suspect https://github.com/OmniSharp/omnisharp-vscode/pull/4509 might have broken this scenario.
FWIIW, the following launch configuration works as expected (assuming debugger bits have been already copied into the container):
       {
            "name": "Manual Docker attach",
            "type": "coreclr",
            "justMyCode": false,
            "processId": "",
            "request": "attach",
            "sourceFileMap": {
                "/src": "${workspaceFolder}"
            },
            "pipeTransport": {
                "pipeCwd": "${workspaceFolder}",
                "pipeProgram": "docker",
                "pipeArgs": [
                    "exec",
                    "-i",
                    "application_container_name"
                ],
                "debuggerPath": "/remote_debugger/vsdbg",
                "quoteArgs": false
            }
        }

(leveraging the new functionality that prompts the user to select a process when processId is left empty)

CC @WardenGnaw

Running:
{
  "name": "Docker .NET Core Attach",
  "justMyCode": false,
  "platform": "netCore",
  "processId": "${command:pickRemoteProcess}",
  "processName": undefined,
  "request": "attach",
  "type": "coreclr",
  "sourceFileMap": {
    "/src": "${workspaceFolder}"
  },
  "pipeTransport": {
    "debuggerPath": "/remote_debugger/vsdbg",
    "pipeCwd": "${workspaceFolder}",
    "pipeProgram": "docker",
    "quoteArgs":  false,
    "pipeArgs": [
      "exec",
      "-i",
      "application_container_name"
    ]
  }
}

Not seeing this repro on macOS M1 BigSur 11.2.1 or Windows x64. I was able to see the Select the process to attach to dialog.

@WardenGnaw correct, when ${command:pickRemoteProcess} is used directly in launch.json, it works, but when it is used as part of return value from DebugConfigurationProvider.resolveDebugConfiguration() (debug configuration provider for Docker, implemented by the Docker extension), the command picker is NOT invoked as expected.

The idea of https://github.com/OmniSharp/omnisharp-vscode/pull/4509 was to have multiple outputs since VS Code commands are only able to have a single output. We needed processId and arch to support debugging on Apple M1.
The idea now is that ${command:pickRemoteProcess} will return "" and if processId and processName are falsy, the process picker should run.

(please take the following with a grain of salt--I am not super familiar with how VS Code debugging works)
I think the problem is that, in the scenario described by the repro steps, is the Docker extension that "resolves" the debug configuration, not the Omnisharp extension. Since the logic to fill the processId via the picker was moved to the Omnisharp debug configuration resolution, and ${command:pickRemoteProcess} is just a stub returning nothing, the logic to show the picker is now bypassed and the final configuration does not have the processId filled.

I took a quick look at the flow in vscode-docker.
This might be that VS Code is happy with the resolution but the debug type changed and I dont think they call resolveDebugConfiguration again for the different type.
@isidorn @weinand Can you confirm this flow for VS Code?
We can bring back the listRemoteProcess command, but it will not be able to detect the architecture type and it will always use the x86_64 debugger which would fail the Apple M1 docker running arm64 containers.

For the Docker extension use case the extension can inspect the image and add the arch property accordingly for arm64 images. Just restoring access to the process picker would unblock our scenario.

This might be that VS Code is happy with the resolution but the debug type changed and I don't think they call resolveDebugConfiguration again for the different type.

Yes, that is my understanding as well (and it is in line with the observed behavior).

The one possible VS Code issue here is that vscode-docker returns the configuration in resolveDebugConfiguration and since it returned the type coreclr it should invoke the C# Extensions resolveDebugConfigurationWithSubstitutedVariables.
If that is not how VS Code team expects it to work. we can bring back the command as listRemoteDockerProcesses.

So @WardenGnaw what would be the plan here? Do you want to pursue the route of making VS Code re-resolve the debug configuration if type changes? Restore the listRemoterDockerProcess command? Something else?
This bug is kind of important for Docker extension to resolve, because all of our Docker Compose debugging functionality is based on attaching the debugger to running container...

Ideally they should fix the issue that resolveDebugConfigurationWithSubstitutedVariables is not being called for the configuration which has type: 'coreclr'.
It looks like this issue has been here for a while: https://github.com/microsoft/vscode/issues/110889

Ideally, yes, but https://github.com/microsoft/vscode/issues/110889 is a new functionality, which may take a while for VS Code core to discuss and implement.
For our customers that are suffering from this regression today, can we get back access to the process picker please?

Created a PR for the temporary workaround.

So @WardenGnaw just to make sure I understand the implications: when new OmniSharp release ships, the following configuration should work (changing pickRemoteProcess to pickRemoteDockerProcess):
{
    "name": "Docker .NET Core Attach",
    "type": "docker",
    "request": "attach",
    "platform": "netCore",
    "processId": "${command:pickRemoteDockerProcess}"
}

Yep. That is exactly the launch.json configuration I used for testing and got a process listing.

Here is the vsix of the omnisharp-vscode extension with the ${command:pickRemoteDockerProcess} supported.
csharp-1.23.13-pickDockerProcess.zip

@WardenGnaw sorry for the slow response, I was on vacation.
If there is an issue with VS Code can you please write a gist of the discussion here so I do not have to read and compile the whole conversation :) Thanks

@isidorn I think the underlying issue is https://github.com/microsoft/vscode/issues/110889

@isidorn Sorry the thread grew longer then when I pinged you.
The core issue is that the docker extension is using a omnisharp extension's command and we changed the functionality of it. The change on our end was to create a "command" that can return multiple configuration fields, and we did this by checking to see if they field was unset or empty for attach in resolveDebugConfigurationWithSubstitutedVariables.
The problem is that VS Code only calls docker's resolveDebugConfiguration and when they return a configuration that is coreclr, it never call's omnisharp's resolveDebugConfigurationWithSubstitutedVariables. Code
@weinand Yep. https://github.com/microsoft/vscode/issues/110889 would fix this issue.

@WardenGnaw Thanks for clarification. Then let's continue the discussion in microsoft/vscode#110889

The original scenario was addressed with the change that @WardenGnaw made, so closing this issue (the more general issue https://github.com/microsoft/vscode/issues/110889 remains)

So @WardenGnaw just to make sure I understand the implications: when new OmniSharp release ships, the following configuration should work (changing pickRemoteProcess to pickRemoteDockerProcess):
{
    "name": "Docker .NET Core Attach",
    "type": "docker",
    "request": "attach",
    "platform": "netCore",
    "processId": "${command:pickRemoteDockerProcess}"
}

What I used:
{
"name": "Docker .NET Core Attach",
"type": "docker",
"request": "attach",
"platform": "netCore",
"processId": "${command:pickRemoteDockerProcess}",
"sourceFileMap": {
"/app": "${workspaceFolder}/src"
}
},


Updates README to correct typos in commands

Bumping this - I was going to make the same PR until I saw this :)

@matthewpoer were you able to get this working? I am having a couple of issues with Pango + Cairo, I've opened up issue #5 and I'd really appreciate it if you could have a look :)

Sure thing. It was a bit of a bear so happy to knowledge-share. I threw together this gist outlineing my SLS config and the layer for Weasyprint, and a layer for fonts which I found to be necessary if you actually want to read the output (otherwise you get a full document of un-rendered glyphs)
https://gist.github.com/matthewpoer/626d967eb276773a8ac69fa6498b8667

@matthewpoer were you able to get this working? I am having a couple of issues with Pango + Cairo, I've opened up issue #5 and I'd really appreciate it if you could have a look :)

Sure thing. It was a bit of a bear so happy to knowledge-share. I threw together this gist outlineing my SLS config and the layer for Weasyprint, and a layer for fonts which I found to be necessary if you actually want to read the output (otherwise you get a full document of un-rendered glyphs)
https://gist.github.com/matthewpoer/626d967eb276773a8ac69fa6498b8667

Incredible - thanks so much for this!


docker version directory added

@ranjithamca  As discussed we'll not carry the  burden of maintaining this, instead use the docker image.
Lets sunset this.


TypeError: _log() got an unexpected keyword argument 'exception'

ERROR: callback
Traceback (most recent call last):
  File "/usr/local/lib/python2.7/dist-packages/guild/plugins/python_util.py", line 144, in wrapper
    cb(wrapped_bound, *args, **kw)
  File "/usr/local/lib/python2.7/dist-packages/guild/plugins/tensorflow_util.py", line 46, in _handle_summary
    self.log("reading summary values", exception=True)
  File "/usr/local/lib/python2.7/dist-packages/guild/plugin.py", line 73, in log
    log("plugin '%s' %s" % (self.name, msg), *args, **kw)
  File "/usr/lib/python2.7/logging/__init__.py", line 1611, in exception
    error(msg, *args, **kwargs)
  File "/usr/lib/python2.7/logging/__init__.py", line 1603, in error
    root.error(msg, *args, **kwargs)
  File "/usr/lib/python2.7/logging/__init__.py", line 1193, in error
    self._log(ERROR, msg, args, **kwargs)
TypeError: _log() got an unexpected keyword argument 'exception'

Using /guild-examples/mnist2 exactly as instructed in the README.md

this error manifests itself if you don't pip install psutil as i've documented in this pull request:
https://github.com/guildai/guild-python/pull/3

@gar1t  is this still an issue?  do we need to run pip install psutil?  if not, please close

This has been resolved in 0.3.0.


have to_json and as_json return amount and currency json

Why
Fixes #76
What

as_json should return a hash of attributes (amount, currency) to be serialized, not a string
from_json is missing to assign attributes from a JSON object

DO NOT MERGE... until background jobs can handle the new format

this is ready to merge now since https://github.com/Shopify/shopify/pull/151350
@bdewater @sunblaze  let me know if you see any other objections. Will run tests in core before merging

https://buildkite.com/shopify/shopify-branches/builds/487461#1596f5db-450d-44ed-b569-1a7e2f7ddcbf no go...

😮

this is the new default behaviour in v1.0, with an option to fallback to the legacy behaviour


If re-implementing CoreShapes, please do List differently

Being able to use an inherance feature from an alternate as List.cshtml to call the corresponding CoreShape base  List.
Anyway we should be able to add alternates for CoreShapes without adding ShapeTables in code.

Can you elaborate? What are the pain point and the proposed solution?

Bertrand, do you have a list of standard questions, I know this one a lot.
Well, there are no aternates for all those lists generated everywhere in Orchard, From your own old blogs the solution to offer different templates according the context of the list is not obvious: adding alternaates on the fly, adding a Shapetable to the Theme, rewiting the code from the CoreShape List class in List.cshtml (and some code on internet is no more sync with last changes).
For some lists I need a Bootstrape raw/col implementation rather than the default ul/li an it is tricky to find how to do it. I found a way for List of itemss using the same taxonomy term, but for tags no way (seems that the search view of Tag/HomeController can't be relocated under my theme...).
This is an Orchard 1 Pb.
Hope it will be easier to select various implementations for list in Orchard 2.
A fallback feature on Shapes could be nice.

So is the problem that it is hard to override the shape and that it doesn't offer alternates out of the box?

In the actual implementation the items in the list could be anything, and in many orchard Display Drivers code the list are created without any differentiator which could be used to have adapted  layouts

In the actual implementation the items in the list could be anything

Yes. Are you saying that's a problem?

in many orchard Display Drivers code the list are created without any differentiator which could be used to have adapted layouts

Yes, it would be the responsibility of the driver producing the list shape to add alternates that make sense. Do you have specific examples?

tags lists

and yes anything could be a problem, maybe different kind of List could help.

OK, what kind of problem that adding ad-hoc alternates wouldn't solve, and what alternates would you like to see for tags? I agree it would be useful to add a list_tags alternate at least for this one.

Related to #90

Even if #90 has been close, the discussion on the more general point it opens, continues on the 'Close Side of Orchard 2'.


Fixed midflameheight to use ceiling instead (test OK).

does this imply the top flamelay could be only partial?

@zmoon Can you further clarify?   I just wanted to move it to the upper layer if there is a partial flamelays.  Maybe the 2nd ceiling isn't necessary?

@zmoon   FYI.  Wei-Ting just tested this new formulation, and the WAF results are looking really good against the Massman example figures in his paper.

I thought that originally you wanted to ensure that flamelays were all full-flame layers.

@zmoon Ah, yes I see what you are saying considering my previous thoughts.  You are right, and I changed to
flamelays = floor(FLAMEH/MODRES) + 1
MIDFLAMEPOINT = max(ceiling(flamelays/2.0),2)
I change in latest commit, and this formulation seems to give best answer for midflameheight and layer.

@zmoon Can we now merge this with Main?  Thanks!


[Infiniband] Fix unbinding of physical functions when configuring Infiniband virtual functions

This PR fixes a bug in the config daemon that unbinds physical functions instead of virtual functions when configuring Infiniband virtual functions.

Apologies, I meant to open this as a PR on a longer-lived feature branch in our fork for internal tracking! I'll close this for now.


fix: #3 Crash with Lithium's Sleeping Block Entities

This change is not tested, but it is plausible that this fixes the issue https://github.com/SpaceWalkerRS/block-event-separator/issues/3

Tested, works perfectly. Thanks for looking into it, and for the fix!


clean utf code

This pull request cleans the code related to UTF, mainly utf.d.
Summary of changes:

The UTF code only seems to be used by the frontend, so the extern(c++) type modifiers and the file utf.h were dropped.
Some functions that, once updated, would only wrap over the existing ones in phobos were deleted and their invocations were changed to call the phobos ones directly

utf_codeLengthChar
utf_codeLengthWchar
utf_encodeChar
utf_encodeWchar

The function isUniAlpha was changed from a manual binary search to a simple return c in alphaSet;. The alphaSet is a std.uni.CodepointSet (a trie), built from the existing list of acceptable code points.

Warning / TODO: This function says "Use table from C99 Appendix D.", but the list of code points matches neither the C99 Annex D nor the C11 Annex D. Please clarify which code points should be accepted, according to which logic / standard, and if the comment is meant to be interpreted as an aspirational TODO.

The functions utf_decodeChar and utf_decodeWchar were not changed to use Phobos decoding code because it doesn't seem to be possible to recover enough information from the UTFException to differentiate between the existing error cases/messages.

No phobos imports please.

@yebblies I didn't know that using the standard library wasn't allowed in DMD. What's the rationale? So, do I just drop all the changes in this pull request? :(

Right now we are focusing on ensuring ddmd matches c++ dmd in performance and features.  Bringing in phobos is at the very least going to hurt compile times.  This PR doesn't add anything that makes that worthwhile.
There is still plenty of refactoring and cleanup work that could be done in here (eg removing redundant __gshared and static, using D strings) but adding dependencies is a problem.

What's allowed to be thread-local, and what should be __gshared? (In general). I had assumed that nothing thread-local was welcome, due to the use of the -vtls flag.

You assumed correctly, but immutable variables are implicitly shared.  I suspect a lot of constant strings and arrays could be made immutable.

I reverted the actual code changes. Now the pull request only includes clean-ups like making things immutable, local, not extern(C++) and so on. Also, utf.h and references to that file were removed.

LGTM.

Auto-merge toggled on


Add "In Classpaths only" checkbox on the "Open Resource" dialog

If you look at the "Files changed" tab, you'll notice you're using a different indent in some places (tabs instead of spaces).

OK, fixed.


Swap #if blocks around in uid.c so target platform gets checked before host

This avoids the case where a UEFI build on FreeBSD tries to call the system
issetugid function instead of returning 0 as it should do.
CLA: trivial

Merged to 1.1.1 and master. Thanks.


Add filter class charts on deep result screen

For convenience, this currently includes the commit of #51 since those are a bit dependent on each other. Will rebase once #51 is merged.


resolution changes have huge impact

Bit of a rant here.  When the competition rules were announced, they stated that the resolution would be 84x84 for submissions and that was fixed and not changing.  Also, a time limit was set.  To decide halfway through the competition to change such a fundamental parameter is unfair.  Huge amounts of time have gone into training at 84x84, along with a lot of testing and other aspects of the code.  Similarly, the time constraint was a consideration right from the start.  Now that the basic aspects of the code are working, the second half of the competition time was planned to be spent exploring interesting avenues using that basic code.  Instead, a tremendous amount of time and resources will have to be used to redo that initial work at various resolutions.  Furthermore, this benefits groups with large computing resources and budgets.  At 256x256, the network training needed for the existing code is very hard to do with our machines.  I understand that we may get $500 for Amazon AWS, but that funding was going to be used to explore interesting new areas rather than just re-training at higher resolution.  Furthermore, at 256x256, we will burn through that $500. pretty quick.
Unhappy here...........

Agree, it was starting to get interesting. Dont want to go back at this stage. It is best to stick to earlier setup.

Can you elaborate more why do you think resolution can have a huge impact?
From my point of view if the frames have enough information increasing the resolution won't give any advantage. The question is if 84x84 is enough for playing, I believe it is because I have played myself on that resolution and it seems enough.

We thought that allowing for more resolutions would only increase possibilities for people entering the competition and that 84x84 would still be a good resolution to use, therefore not changing anyone's plans. However, we overlooked that this would be unfair to anyone who had invested time in 84x84 that would now want to have explored the other options. We had not intended this change affects those that have already been engaging with the competition and are therefore going to remove this from the evaluation script. You can still use multiple resolutions for training, but evaluation will require 84x84.
The time increase will remain. This should have very minimal effect as very few entries come even close to the time limit. It also allows for a wider variety of approaches to be entered. Lastly, it potentially helps those that have access to less resources compared to the resolution change which primarily helped those with access to more resources.
Please be aware that in our rules the final evaluation (In November not for AWS) may include extra variations on the tests (resources permitting, we will run them more than once with minor variations to get a more robust score) and therefore the final score may not be identical with the score on the current leaderboard.

Thanks for responding, appreciate your understanding, sounds good.


chore: :wrench: add JamesNZL/flow-toggl-plugin

Wrote a plugin to interface with Toggl Track.
Cheers for the amazing launcher, I've switched over after using PowerToys Run for a fair while and have been very pleased with the configurability, performance, and developer support.
Repository link: https://github.com/JamesNZL/flow-toggl-plugin
Let me know if you need anything else, cheers again!

@Garulf Shall we approve?

Sorry I wanted to do a test run before approving. Are you able to test?

Nope. AFK today.


Fix ClassCastException for unsupported TypedImperativeAggregate functions

Signed-off-by: sperlingxx<EMAIL_ADDRESS>Fixes #3253
The ClassCastException occurred during overriding the buffer types of TypedImperativeAggregate functions. The code for overriding assumed that  TypedImperativeAggreagte must be wrapped by TypedImperativeAggExprMeta. But there are exceptions: for  TypedImperativeAggreagte without GPU implementation , they are wrapped by RuleNotFoundExprMeta.

build


[Feature request] - Log player connections

Is your feature request related to a problem? Please describe.
If a player is logged from the server and server admins want to ban him and they only know his in game name. We should know his steamID too.. Therefor a new schema is needed that will hold players name+steamid
Describe the solution you'd like
Schema PlayerConnection with time, name and steamid

squadjs does that for us, doesn't it?


Filter OnClick Status

On click status of the filters dropdown have to be without the white stroke.
Private Zenhub Image

This is due to accessiblity. There should be a visual way to identified when a button is active


Using pipdeptree in tox with tox-uv gives ModuleNotFoundError for pip

A bit of a corner case. I'm experimenting with tox-uv to use uv within tox.
A bit cleaned up (see full one:
[testenv:dependencies-graph]
description = Generate a graph out of the dependencies of the package
skip_install = false
deps =
    pipdeptree>=2.5.1
    graphviz  # optional dependency of pipdeptree
commands =
    - pipdeptree --packages nens-meta --mermaid

When running the tox-with-uv version, I get this traceback:
Traceback (most recent call last):
  File "/Users/reinout/nens/nens-meta/.tox/dependencies-graph/.venv/bin/pipdeptree", line 5, in <module>
    from pipdeptree.__main__ import main
  File "/Users/reinout/nens/nens-meta/.tox/dependencies-graph/.venv/lib/python3.12/site-packages/pipdeptree/__main__.py", line 10, in <module>
    from pipdeptree._models import PackageDAG
  File "/Users/reinout/nens/nens-meta/.tox/dependencies-graph/.venv/lib/python3.12/site-packages/pipdeptree/_models/__init__.py", line 3, in <module>
    from .dag import PackageDAG, ReversedPackageDAG
  File "/Users/reinout/nens/nens-meta/.tox/dependencies-graph/.venv/lib/python3.12/site-packages/pipdeptree/_models/dag.py", line 12, in <module>
    from .package import DistPackage, ReqPackage, pep503_normalize
  File "/Users/reinout/nens/nens-meta/.tox/dependencies-graph/.venv/lib/python3.12/site-packages/pipdeptree/_models/package.py", line 10, in <module>
    from pip._vendor.pkg_resources import Requirement  # noqa: PLC2701
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
ModuleNotFoundError: No module named 'pip'

When I investigate the virtualenv created by tox-uv, the pipdeptree-2.16.1.dist-info/METADATA contains the proper Requires-Dist: pip>=23.3.1; extra == 'test', so pipdeptree's dependency list is fine. My guess is that uv doesn't install pip itself as it mimicks pip. It only doesn't need to mimick "old stuff" like the _vendor.pkg_resources. Which is probably OK. There's a PR here to move away from pkg_resources (#175).
Workaround: if I add pip as an explicit dependency in this tox environment's deps = list it does work.
I'm not sure if it is an issue here (which probably means #175) or with tox-uv (or uv), ignoring a "pip" dependency.

That's expected 😊 after all, the name of this project is pipdeptree, so is expecting to have pip in the env. You can achieve via tox-uv that by setting uv_seed = true in your tox config.

The uv_seed = true indeed works perfectly.


BUG- Addlicense exclude path

Describe the bug
Scorecard would like to exclude license check https://github.com/ossf/scorecard/pull/766/checks?check_run_id=3176959693 for certain files.
The licensecheck has a PR to address this https://github.com/google/addlicense/pull/70 but does not seem to have any traction on merging the issue

@inferno-chromium  We have 2 options.

Get someone in Google to merge this PR.
Fork the repo and fix it by ourselves.

cc @laurentsimon

I asked on the PR.

PR reviewed, left a few comments


[Subtask]: Fix spacing of account switcher button

Fix spacing of account switcher based of QA feedback, horizontal spacing should 8px between the three elements.

Blocked because this appears to already be the case?


[Issue #3][Milestone #1] Database connection

Desgined user endpoints to get and post login data
Created Database file and set up connection to fetch and store data

Review Wed/feb2

Reviewed web/2


HBASE-22791 Fixed order of asserts in TestZKMulti

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
191
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
hbaseanti
0
Patch does not have any anti-patterns.

+1
@author
0
The patch does not contain any @author tags.

+1
test4tests
0
The patch appears to include 1 new or modified test files.

_ master Compile Tests _

-1
mvninstall
206
root in master failed.

+1
compile
20
master passed

+1
checkstyle
14
master passed

+1
shadedjars
377
branch has no errors when building our shaded downstream artifacts.

+1
javadoc
16
master passed

0
spotbugs
42
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
40
master passed

_ Patch Compile Tests _

-1
mvninstall
171
root in the patch failed.

+1
compile
20
the patch passed

+1
javac
20
the patch passed

+1
checkstyle
13
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedjars
371
patch has no errors when building our shaded downstream artifacts.

-1
hadoopcheck
114
The patch causes 10 errors with Hadoop v2.8.5.

-1
hadoopcheck
237
The patch causes 10 errors with Hadoop v2.9.2.

-1
hadoopcheck
361
The patch causes 10 errors with Hadoop v3.1.2.

+1
javadoc
16
the patch passed

+1
findbugs
48
the patch passed

_ Other Tests _

+1
unit
53
hbase-zookeeper in the patch passed.

+1
asflicense
11
The patch does not generate ASF License warnings.

2017

Subsystem
Report/Notes

Docker
Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-453/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/453

Optional Tests
dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile

uname
Linux 4ee52c65d955 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux

Build tool
maven

Personality
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-453/out/precommit/personality/provided.sh

git revision
master / abb60faa6c

Default Java
1.8.0_181

mvninstall
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-453/1/artifact/out/branch-mvninstall-root.txt

mvninstall
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-453/1/artifact/out/patch-mvninstall-root.txt

hadoopcheck
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-453/1/artifact/out/patch-javac-2.8.5.txt

hadoopcheck
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-453/1/artifact/out/patch-javac-2.9.2.txt

hadoopcheck
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-453/1/artifact/out/patch-javac-3.1.2.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-453/1/testReport/

Max. process+thread count
324 (vs. ulimit of 10000)

modules
C: hbase-zookeeper U: hbase-zookeeper

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-453/1/console

versions
git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
59
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
hbaseanti
0
Patch does not have any anti-patterns.

+1
@author
0
The patch does not contain any @author tags.

+1
test4tests
0
The patch appears to include 1 new or modified test files.

_ master Compile Tests _

-1
mvninstall
182
root in master failed.

+1
compile
19
master passed

+1
checkstyle
14
master passed

+1
shadedjars
367
branch has no errors when building our shaded downstream artifacts.

+1
javadoc
15
master passed

0
spotbugs
41
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
38
master passed

_ Patch Compile Tests _

-1
mvninstall
184
root in the patch failed.

+1
compile
19
the patch passed

+1
javac
19
the patch passed

+1
checkstyle
13
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedjars
360
patch has no errors when building our shaded downstream artifacts.

-1
hadoopcheck
110
The patch causes 10 errors with Hadoop v2.8.5.

-1
hadoopcheck
222
The patch causes 10 errors with Hadoop v2.9.2.

-1
hadoopcheck
335
The patch causes 10 errors with Hadoop v3.1.2.

+1
javadoc
15
the patch passed

+1
findbugs
48
the patch passed

_ Other Tests _

+1
unit
51
hbase-zookeeper in the patch passed.

+1
asflicense
11
The patch does not generate ASF License warnings.

1819

Subsystem
Report/Notes

Docker
Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-453/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/453

Optional Tests
dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile

uname
Linux 4d8e4a9b30a9 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux

Build tool
maven

Personality
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-453/out/precommit/personality/provided.sh

git revision
master / d0e5ea1b87

Default Java
1.8.0_181

mvninstall
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-453/2/artifact/out/branch-mvninstall-root.txt

mvninstall
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-453/2/artifact/out/patch-mvninstall-root.txt

hadoopcheck
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-453/2/artifact/out/patch-javac-2.8.5.txt

hadoopcheck
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-453/2/artifact/out/patch-javac-2.9.2.txt

hadoopcheck
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-453/2/artifact/out/patch-javac-3.1.2.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-453/2/testReport/

Max. process+thread count
271 (vs. ulimit of 10000)

modules
C: hbase-zookeeper U: hbase-zookeeper

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-453/2/console

versions
git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
61
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
hbaseanti
0
Patch does not have any anti-patterns.

+1
@author
0
The patch does not contain any @author tags.

+1
test4tests
0
The patch appears to include 1 new or modified test files.

_ master Compile Tests _

-1
mvninstall
158
root in master failed.

+1
compile
18
master passed

+1
checkstyle
12
master passed

+1
shadedjars
340
branch has no errors when building our shaded downstream artifacts.

+1
javadoc
15
master passed

0
spotbugs
39
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
37
master passed

_ Patch Compile Tests _

-1
mvninstall
163
root in the patch failed.

+1
compile
19
the patch passed

+1
javac
19
the patch passed

+1
checkstyle
13
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedjars
339
patch has no errors when building our shaded downstream artifacts.

-1
hadoopcheck
113
The patch causes 10 errors with Hadoop v2.8.5.

-1
hadoopcheck
228
The patch causes 10 errors with Hadoop v2.9.2.

-1
hadoopcheck
346
The patch causes 10 errors with Hadoop v3.1.2.

+1
javadoc
15
the patch passed

+1
findbugs
48
the patch passed

_ Other Tests _

+1
unit
52
hbase-zookeeper in the patch passed.

+1
asflicense
11
The patch does not generate ASF License warnings.

1729

Subsystem
Report/Notes

Docker
Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-453/3/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/453

Optional Tests
dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile

uname
Linux 471d6629bd29 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux

Build tool
maven

Personality
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-453/out/precommit/personality/provided.sh

git revision
master / d0e5ea1b87

Default Java
1.8.0_181

mvninstall
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-453/3/artifact/out/branch-mvninstall-root.txt

mvninstall
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-453/3/artifact/out/patch-mvninstall-root.txt

hadoopcheck
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-453/3/artifact/out/patch-javac-2.8.5.txt

hadoopcheck
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-453/3/artifact/out/patch-javac-2.9.2.txt

hadoopcheck
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-453/3/artifact/out/patch-javac-3.1.2.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-453/3/testReport/

Max. process+thread count
308 (vs. ulimit of 10000)

modules
C: hbase-zookeeper U: hbase-zookeeper

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-453/3/console

versions
git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
56
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
hbaseanti
0
Patch does not have any anti-patterns.

+1
@author
0
The patch does not contain any @author tags.

+1
test4tests
0
The patch appears to include 1 new or modified test files.

_ master Compile Tests _

+1
mvninstall
297
master passed

+1
compile
17
master passed

+1
checkstyle
12
master passed

+1
shadedjars
266
branch has no errors when building our shaded downstream artifacts.

+1
javadoc
13
master passed

0
spotbugs
32
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
31
master passed

_ Patch Compile Tests _

+1
mvninstall
283
the patch passed

+1
compile
17
the patch passed

+1
javac
17
the patch passed

+1
checkstyle
11
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedjars
263
patch has no errors when building our shaded downstream artifacts.

+1
hadoopcheck
877
Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.

+1
javadoc
18
the patch passed

+1
findbugs
39
the patch passed

_ Other Tests _

+1
unit
49
hbase-zookeeper in the patch passed.

+1
asflicense
12
The patch does not generate ASF License warnings.

2615

Subsystem
Report/Notes

Docker
Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-453/4/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/453

Optional Tests
dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile

uname
Linux 98dc89d2aa31 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux

Build tool
maven

Personality
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-453/out/precommit/personality/provided.sh

git revision
master / ff96485396

Default Java
1.8.0_181

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-453/4/testReport/

Max. process+thread count
294 (vs. ulimit of 10000)

modules
C: hbase-zookeeper U: hbase-zookeeper

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-453/4/console

versions
git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
234
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
hbaseanti
0
Patch does not have any anti-patterns.

+1
@author
0
The patch does not contain any @author tags.

+1
test4tests
0
The patch appears to include 1 new or modified test files.

_ master Compile Tests _

+1
mvninstall
364
master passed

+1
compile
18
master passed

+1
checkstyle
11
master passed

+1
shadedjars
291
branch has no errors when building our shaded downstream artifacts.

+1
javadoc
13
master passed

0
spotbugs
34
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
32
master passed

_ Patch Compile Tests _

-1
mvninstall
12
root in the patch failed.

+1
compile
16
the patch passed

+1
javac
16
the patch passed

+1
checkstyle
13
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedjars
293
patch has no errors when building our shaded downstream artifacts.

-1
hadoopcheck
10
The patch causes 7 errors with Hadoop v2.8.5.

-1
hadoopcheck
20
The patch causes 7 errors with Hadoop v2.9.2.

-1
hadoopcheck
30
The patch causes 7 errors with Hadoop v3.1.2.

+1
javadoc
16
the patch passed

+1
findbugs
43
the patch passed

_ Other Tests _

+1
unit
48
hbase-zookeeper in the patch passed.

+1
asflicense
14
The patch does not generate ASF License warnings.

1522

Subsystem
Report/Notes

Docker
Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-453/5/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/453

Optional Tests
dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile

uname
Linux e6d9f92c28fe 4.4.0-139-generic #165-Ubuntu SMP Wed Oct 24 10:58:50 UTC 2018 x86_64 GNU/Linux

Build tool
maven

Personality
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-453/out/precommit/personality/provided.sh

git revision
master / f6ece8d8e3

Default Java
1.8.0_181

mvninstall
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-453/5/artifact/out/patch-mvninstall-root.txt

hadoopcheck
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-453/5/artifact/out/patch-javac-2.8.5.txt

hadoopcheck
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-453/5/artifact/out/patch-javac-2.9.2.txt

hadoopcheck
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-453/5/artifact/out/patch-javac-3.1.2.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-453/5/testReport/

Max. process+thread count
332 (vs. ulimit of 10000)

modules
C: hbase-zookeeper U: hbase-zookeeper

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-453/5/console

versions
git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
246
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
hbaseanti
0
Patch does not have any anti-patterns.

+1
@author
0
The patch does not contain any @author tags.

+1
test4tests
0
The patch appears to include 1 new or modified test files.

_ master Compile Tests _

-1
mvninstall
420
root in master failed.

+1
compile
16
master passed

+1
checkstyle
14
master passed

+1
shadedjars
294
branch has no errors when building our shaded downstream artifacts.

+1
javadoc
17
master passed

0
spotbugs
58
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
55
master passed

_ Patch Compile Tests _

-1
mvninstall
319
root in the patch failed.

+1
compile
16
the patch passed

+1
javac
16
the patch passed

+1
checkstyle
13
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedjars
280
patch has no errors when building our shaded downstream artifacts.

-1
hadoopcheck
254
The patch causes 10 errors with Hadoop v2.8.5.

-1
hadoopcheck
528
The patch causes 10 errors with Hadoop v2.9.2.

-1
hadoopcheck
814
The patch causes 10 errors with Hadoop v3.1.2.

+1
javadoc
13
the patch passed

+1
findbugs
39
the patch passed

_ Other Tests _

+1
unit
45
hbase-zookeeper in the patch passed.

+1
asflicense
11
The patch does not generate ASF License warnings.

2678

Subsystem
Report/Notes

Docker
Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-453/6/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/453

Optional Tests
dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile

uname
Linux c166a9c20fee 4.4.0-137-generic #163-Ubuntu SMP Mon Sep 24 13:14:43 UTC 2018 x86_64 GNU/Linux

Build tool
maven

Personality
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-453/out/precommit/personality/provided.sh

git revision
master / f6ece8d8e3

Default Java
1.8.0_181

mvninstall
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-453/6/artifact/out/branch-mvninstall-root.txt

mvninstall
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-453/6/artifact/out/patch-mvninstall-root.txt

hadoopcheck
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-453/6/artifact/out/patch-javac-2.8.5.txt

hadoopcheck
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-453/6/artifact/out/patch-javac-2.9.2.txt

hadoopcheck
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-453/6/artifact/out/patch-javac-3.1.2.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-453/6/testReport/

Max. process+thread count
288 (vs. ulimit of 10000)

modules
C: hbase-zookeeper U: hbase-zookeeper

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-453/6/console

versions
git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
67
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
hbaseanti
0
Patch does not have any anti-patterns.

+1
@author
0
The patch does not contain any @author tags.

+1
test4tests
0
The patch appears to include 1 new or modified test files.

_ master Compile Tests _

+1
mvninstall
386
master passed

+1
compile
19
master passed

+1
checkstyle
13
master passed

+1
shadedjars
350
branch has no errors when building our shaded downstream artifacts.

+1
javadoc
14
master passed

0
spotbugs
38
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
36
master passed

_ Patch Compile Tests _

+1
mvninstall
359
the patch passed

+1
compile
21
the patch passed

+1
javac
21
the patch passed

+1
checkstyle
11
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedjars
334
patch has no errors when building our shaded downstream artifacts.

+1
hadoopcheck
1192
Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.

+1
javadoc
15
the patch passed

+1
findbugs
47
the patch passed

_ Other Tests _

+1
unit
52
hbase-zookeeper in the patch passed.

+1
asflicense
11
The patch does not generate ASF License warnings.

3394

Subsystem
Report/Notes

Docker
Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-453/7/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/453

Optional Tests
dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile

uname
Linux bdf71cc8b0a0 4.4.0-143-generic #169-Ubuntu SMP Thu Feb 7 07:56:38 UTC 2019 x86_64 GNU/Linux

Build tool
maven

Personality
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-453/out/precommit/personality/provided.sh

git revision
master / 66a2fc5d25

Default Java
1.8.0_181

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-453/7/testReport/

Max. process+thread count
336 (vs. ulimit of 10000)

modules
C: hbase-zookeeper U: hbase-zookeeper

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-453/7/console

versions
git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
0
Docker mode activated.

-1
patch
9
https://github.com/apache/hbase/pull/453 does not apply to master. Rebase required? Wrong Branch? See https://yetus.apache.org/documentation/in-progress/precommit-patchnames for help.

Subsystem
Report/Notes

GITHUB PR
https://github.com/apache/hbase/pull/453

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-453/8/console

versions
git=2.7.4

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.


Support for grouping search

The group_by_field search parameter should be supported as per docs here: https://milvus.io/docs/single-vector-search.md#Grouping-search

fixed by https://github.com/milvus-io/milvus-sdk-csharp/pull/84


Can I use DataMemberAttribute when run on IL2CPP?

Hi. Thanks for the very nice lib.
I'd like to use DataMemberAttribute when run on Unity(IL2CPP) but UniversalCodeGenerator is not working for me.
[DataContract]
public class Sample
{
	[DataMember(Name = "sample_id")]
	public string Id;
}

var sample = new Sample(){ Id = "id_001"}

// StandardResolver
Debug.Log( Utf8Json.JsonSerializer.ToJsonString<Sample>( sample, Utf8Json.Resolvers.StandardResolver.Default ) );
// {"sample_id":"id_001"}

// Use Generated Resolver Test
// Utf8Json.UniversalCodeGenerator.exe -d "..\src\Shared\Request,..\src\Shared\Response" -o "Utf8JsonGenerated.cs"
Debug.Log( Utf8Json.JsonSerializer.ToJsonString<Sample>( sample, Utf8Json.Resolvers.GeneratedResolver.Instance ) );
//{"Id":"id_001"}

Is there any settings I need to change ?

Thank you, I've fixed it and upload new UniversalCodeGenerator on releases page, please try it.
https://github.com/neuecc/Utf8Json/releases/tag/v1.3.1

Thank you, it works now! Closing this.


value and label in one span element making it difficult for styling

Hi everyone! I am using slider, and because value and label are currently in one span tag...it is difficult to perform css on them such as spacing and making them both on the same line.

Closed by #277 I believe! 🎉


C#: Add precision tags to UnsafeDeserialization[UntrustedInput].ql

Query run on LGTM.com shows no results on my set of sample projects for UnsafeDeserializationUntrustedInput.ql, and the query UnsafeDeserialization.ql is disabled by default.
@jf205 : In addition to the change not change, could you also take a look at the qhelp for these two queries (not actually modified on this PR)? Thanks.

Both UnsafeDeserializationUntrustedInput.qhelp and UnsafeDeserialization.qhelp have the same text for the overview section---is that intended?

Yes, it is intended.


Unable to create "HauserParabolicSmoother" planner

Hi everyone,
I am a new user of prpy. Actually, I am current using fetchpy package to control the real fetch robot. The fetchpy extensively uses prpy library.
When I called "robot.arm.PlanToConfiguration(goal, execute=True)" and "robot.ExecuatePath(traj)" in which "traj" is an OpenRAVE trajectory representing an un-timed path, I got the same error from the 'retimer.py' file of prpy:
/home/yuchen/projects/src/prpy/src/prpy/base/robot.pyc in ExecutePath(self, path, **kwargs)
393
394         with Timer() as timer:
--> 395             traj = self.PostProcessPath(path, **kwargs)
396         SetTrajectoryTags(traj, {Tags.POSTPROCESS_TIME: timer.get_duration()}, append=True)
397
/home/yuchen/projects/src/prpy/src/prpy/base/robot.pyc in PostProcessPath(self, path, constrained, smooth, default_timelimit, shortcut_options, smoothing_options, retiming_options, affine_retiming_options, **kwargs)
370                     logger.debug('Smoothing an unconstrained path.')
371                     traj = self.smoother.RetimeTrajectory(
--> 372                         cloned_robot, shortcut_path, **smoothing_options)
373
374         # Copy the trajectory into the output environment.
/home/yuchen/projects/src/prpy/src/prpy/planning/base.pyc in call(self, instance, robot, *args, **kw_args)
107         with robot.GetEnv():
108             # Perform the actual planning operation.
--> 109             traj = self.func(instance, robot, *args, **kw_args)
110
111             # Tag the trajectory with the planner and planning method
/home/yuchen/projects/src/prpy/src/prpy/planning/retimer.pyc in RetimeTrajectory(self, robot, path, options, **kw_args)
161           new_options['time_limit'] = kw_args['timelimit']
162         return super(HauserParabolicSmoother, self).RetimeTrajectory(
--> 163             robot, path, options=new_options, **kw_args)
164
165 class OpenRAVEAffineRetimer(Planner):
/home/yuchen/projects/src/prpy/src/prpy/planning/base.pyc in call(self, instance, robot, *args, **kw_args)
107         with robot.GetEnv():
108             # Perform the actual planning operation.
--> 109             traj = self.func(instance, robot, *args, **kw_args)
110
111             # Tag the trajectory with the planner and planning method
/home/yuchen/projects/src/prpy/src/prpy/planning/retimer.pyc in RetimeTrajectory(self, robot, path, options, **kw_args)
105             if planner is None:
106                 raise UnsupportedPlanningError(
--> 107                     'Unable to create "{:s}" planner.'.format(self.algorithm))
108             planner.InitPlan(None, params_str)
109
UnsupportedPlanningError: Unable to create "HauserParabolicSmoother" planner.
Does anyone know how to solve this? Thank you very much!
Best,
Yuchen

The HauserParabolicSmoother needs another plugin


Incorrect height of root with grid thumbnail

Hi, height of root counts only first image added. If you add second (and so on)image with larger height it will overflow.

Thank you
Radim Smicka

Please see the entry on Grid layout in the docs, especially the note.

Make sure that each item is the same height. FilePond currently calculates the height of the first item in the list and then uses that as the base height for each item. You can set the item height using styleItemPanelAspectRatio, imageCropAspectRatio, or by setting a fixed imagePreviewHeight.

@rikschennink I'm having the same issue.  Seems like it should just compute the max height of all the items in the list and use that instead of just using the height from the first one.

@rikschennink I'm having the same issue.  Seems like it should just compute the max height of all the items in the list and use that instead of just using the height from the first one.

@rikschennink I'm having the same issue. Seems like it should just compute the max height of all the items in the list and use that instead of just using the height from the first one.

It isn't

@rikschennink I'm having the same issue. Seems like it should just compute the max height of all the items in the list and use that instead of just using the height from the first one.

It isn't

@rikschennink that's a bigger issue on my side... especially if the first item has an error:

any suggestions or temporary workaround?

@stunaz see this reply https://github.com/pqina/filepond/issues/317#issuecomment-492194409

@rikschennink well it is not an issue with the height per se. I understand that I can set the height from the 1st item.. But its a little different when I have error, it will take the 44px of red error (as first item).

@stunaz have you set styleItemPanelAspectRatio ?

Thanks a lot @rikschennink .... that is way better:


Istio metrics override doesn't work for overlapping tag names

Bug Description
We are using the custom metrics feature in Istio and configure it via the Telemetry resource. It works fine for
apiVersion: telemetry.istio.io/v1alpha1
kind: Telemetry
metadata:
  name: mesh-default
spec:
  metrics:
    - overrides:
        - tagOverrides:
            tenant:
              operation: UPSERT
              value: request.headers["test-tenant"]
      providers:
        - name: prometheus

It doesn't work (meaning istio_requests_total doesn't hold the custom metrics) for
apiVersion: telemetry.istio.io/v1alpha1
kind: Telemetry
metadata:
  name: mesh-default
spec:
  metrics:
    - overrides:
        - tagOverrides:
            cc_tenant:
              operation: UPSERT
              value: request.headers["test-cloud-tenant"]
            tenant:
              operation: UPSERT
              value: request.headers["test-tenant"]
      providers:
        - name: prometheus

Interestingly, it works for (pay attention to the first tagOverride name (tenant_cc instead of cc_tenant).
apiVersion: telemetry.istio.io/v1alpha1
kind: Telemetry
metadata:
  name: mesh-default
spec:
  metrics:
    - overrides:
        - tagOverrides:
            tenant_cc:
              operation: UPSERT
              value: request.headers["test-cloud-tenant"]
            tenant:
              operation: UPSERT
              value: request.headers["test-tenant"]
      providers:
        - name: prometheus

The extraStatTags are configured via IstioOperator:
  meshConfig:
    defaultConfig:
      extraStatTags:
        - tenant
        - cc_tenant

Version
$ istioctl version
client version: 1.16.1
control plane version: 1.16.1
data plane version: 1.16.1 (16 proxies)

$ kubectl version --short
Client Version: v1.25.5
Kustomize Version: v4.5.7
Server Version: v1.24.10

Additional Information
Curling some istio pods that would produce those metrics shows an interesting thing:
curl -v <istio_host> -H "test-tenant: test123" -H "test-cloud-tenant: helloworld"

produces
tenant___test123___istio_requests_total{response_code="200",...,tenant="helloworld",cc_tenant="helloworld"} 1

So tenant gets the value of cc_tenant and furthermore the problem occurs that no istio_requests_total metric is produced.

can you check the output of istioctl pc b <you_pod_name>?
BTW, you need restart the deploy/pod after change extraStatTags.

Yes, I tested the changes in the exact same order:

updating extraStatTags
updating telemetry resource
restarting pods

The relevant parts from istioctl pc b should be those under statsConfig.statsTags:
                {
                    "tagName": "tenant",
                    "regex": "(tenant=\\.=(.*?);\\.;)"
                },
                {
                    "tagName": "cc_tenant",
                    "regex": "(cc_tenant=\\.=(.*?);\\.;)"
                },

Let me know if you need more output

this seems a limit of istio implement:
can you retry with changing tenant to abc_tenant

Yeah, this works as well...


[1909] Ship sandbox and production logs to Logit.io

Context
Logs in lower environment are already in Logit and validated. We can now ship sandbox and production.
Changes proposed in this pull request
Enable via terraform
Guidance to review
Compare with previous environment
Run deploy-plan against sandbox and production

 Remove PII from Logit.io logs


js-interop: Specify behaviour of .toString() on non-Dart objects

JS-interop should specify how Dart handles the .toString() method for non-Dart objects.
This would ensure some consistency between development and deployment.

Excellent question. Ideally, I would like dart:core Object.toString to call JS obj.toString() for JS objects. That way we're behaving "like JS".
We also need to specify the behavior of all of the dart:core Object members (including runtimeType).
As #35952 notes, JavaScript itself does not support .toString() on some objects that don't inherit from Object.prototype, for example Object.create(null).toString(). I'm hesitant to try do different things for JS objects than JS would do. However toString() is very common and developers generally don't expect it to throw (despite the lack of guarantees in Dart or JS), so it may be worth addressing. I'll think more about that part & try to gather some user feedback.


Neon animations on NPM are not converted to modules

Description
When using the paper-menu-button it fails to build in webpack as it relies on neon-animation and tries to pull in the below:
import '../neon-animation/animations/fade-in-animation.js';
import '../neon-animation/animations/fade-out-animation.js';
but they still are .HTML files in npm
Versions

Polymer: v3.0

This issue was moved to Polymer/polymer-modulizer#184


analyzing data from github api tutorial

Describe your changes
A tutorial that pulls information in JSON format from Github REST API and uses DuckDB/JupySQL to query this information
Issue ticket number and link
Closes #182
Checklist before requesting a review

[x] I have performed a self-review of my code
[x] I have added thorough tests (when necessary).
[x] I have added the right documentation in the docstring and changelog (when needed)

:books: Documentation preview :books:: https://jupysql--239.org.readthedocs.build/en/239/

Just moved it into the correct section I believe


SkipUnchangedFiles doesn't work on Linux

On Windows and MacOS File.Copy preserves LastWriteTime, but it is not the case on Linux.
For this reason SkipUnchangedFiles=true doesn't really work on Linux, because we use LastWriteTime to check if file has changed or not. Linux doesn't preserve LastWriteTime, so it will always differ for original file and copy.
https://github.com/Microsoft/msbuild/pull/3997/files#diff-4826624e1418003ab55be4305eadddadR568

Do you know if the timestamp is really not preserved, or if it's preserved incorrectly? This could be a symptom of https://github.com/dotnet/corefx/issues/31379, which is fixed for 3.0. If that's the case, I'd rather not take an MSBuild fix since it'll be inefficient after getting the runtime fix.

Do you know if the timestamp is really not preserved, or if it's preserved incorrectly? This could be a symptom of dotnet/corefx#31379, which is fixed for 3.0. If that's the case, I'd rather not take an MSBuild fix since it'll be inefficient after getting the runtime fix.

I've opened this ticket, because CI pipeline for msbuild reports that SkipUnchangedFiles doesn't work on Linux (See the workaround that is necessary in this test https://github.com/Microsoft/msbuild/blob/95862314f14733dd0086b1747264c40e6989f2cf/src/Tasks.UnitTests/Copy_Tests.cs#L568)
I wrote a netcore2.1 app to reproduce it and run it on Win10, real Ubuntu18.04 and Ubuntu18.04/WSL.
So it seems that File.Copy and SetLastWriteTime work differently on Win10, real Ubuntu18.04 and Ubuntu18.04/WSL.

Win10 -> File.Copy preserves timestamp and SetLastWriteTime doesn't loose precision
Ubuntu18.04 -> File.Copy preserves timestamp and SetLastWriteTime looses precision (it is rounded to seconds dotnet/corefx#31379)
Ubuntu18.04/WSL ->  File.Copy doesn't preserve timestamps (very small difference in number of ticks) and SetLastWriteTime looses precision (rounded to seconds)

From these results we see that only on Ubuntu18.04/WSL timestamps are not preserved for copies. Therefore we can conclude that the actual issue here is that WSL has a bug and CI pipeline for msbuild doesn't run on real Linux, but it rather runs on Linux/WSL.
TestApp:
    class Program
    {
        static void Main(string[] args)
        {
            var files = new[] { "some_file.0", "some_file.1", "some_file.2", "some_file.3" };
            foreach (var f in files)
                File.Delete(f);

            File.WriteAllText(files[0], "");
            Thread.Sleep(2000);
            File.Copy(files[0], files[1], true);
            Thread.Sleep(2000);
            File.Copy(files[1], files[2], true);
            File.WriteAllText(files[3], "");
            File.SetCreationTimeUtc(files[3], File.GetCreationTimeUtc(files[0]));
            File.SetLastWriteTimeUtc(files[3], File.GetLastWriteTimeUtc(files[0]));

            var creationTimes = files.Select(f => File.GetCreationTimeUtc(f)).ToArray();
            var writeTimes = files.Select(f => File.GetLastWriteTimeUtc(f)).ToArray();

            Console.WriteLine($" file_name\t cration_time\t\t last_write_time\t");

            for (var i = 0; i < files.Length; i++)
            {
                Console.WriteLine($" {files[i]}\t {creationTimes[i].Ticks}\t {writeTimes[i].Ticks}\t");
            }
        }
    }

Win10
file_name       creation_time            last_write_time
 some_file.0<PHONE_NUMBER>84239034<PHONE_NUMBER>96795794
 some_file.1<PHONE_NUMBER>04280965<PHONE_NUMBER>96795794
 some_file.2<PHONE_NUMBER>24320285<PHONE_NUMBER>96795794
 some_file.3<PHONE_NUMBER>84239034<PHONE_NUMBER>96795794

Ubuntu18.04
file_name	 creation_time		 last_write_time
 some_file.0<PHONE_NUMBER>52480010<PHONE_NUMBER>52480010
 some_file.1<PHONE_NUMBER>52480010<PHONE_NUMBER>52480010
 some_file.2<PHONE_NUMBER>52480010<PHONE_NUMBER>52480010
 some_file.3<PHONE_NUMBER>50000000<PHONE_NUMBER>50000000

Ubuntu18.04/WSL
file_name       creation_time            last_write_time
 some_file.0<PHONE_NUMBER>84019239<PHONE_NUMBER>84019239
 some_file.1<PHONE_NUMBER>84019230<PHONE_NUMBER>84019230
 some_file.2<PHONE_NUMBER>84019230<PHONE_NUMBER>84019230
 some_file.3<PHONE_NUMBER>80000000<PHONE_NUMBER>80000000