Web support

Ask your Question
Are there plans to support web? It would be awesome to have a universal date picker that also works on web.

Hey,
That sounds like a nice idea. I know the community picker supports Windows, but I don't see any plan to support the web anytime soon... We could still build it directly in this project, but at the same time I'm wondering if showing a date/time picker in a modal is a nice UX on the web 🤔

we need the picker working on web ++

we need the picker working on web ++

PRs, ideas, and suggestions are welcome!

I agree a modal might not be the best UX on web. But if it is, react-native-web supports modals now. Perhaps a native input with a simple date picker could be a good start for web, or some sort of popover using react-native-popover-view. Whatever feels simplest.

Here is an example of a nice modal picker on web: https://material-ui.com/components/pickers/ Could just fall back to that on web for now?

I'd go for a native solution like this one https://codepen.io/getify/pen/LYZbaGj?editors=1111, which looks native on the web both on desktop and mobile

That's true. It doesn't have as much browser support, but I think the native input makes sense.

I'd go for a native solution like this one https://codepen.io/getify/pen/LYZbaGj?editors=1111, which looks native on the web both on desktop and mobile

The native support is not there for browsers like Safari (it  control falls back to text-only on such browsers) so I wouldn't go that route until all browsers have caught up.
I am now using react-datepicker in my web solution which is not terrible, maybe you can just wrap that to add web support for now: https://www.npmjs.com/package/react-datepicker
It can run in inline mode as well as in portal mode (modal-like), there are a few tricks to get it working properly but not too bad and now that it works it looks quite good compared to the other things i've tried. I can share that code if you're interested.

Yeah that'd be great, I had some trouble with it when I tried it. Don't love the design but it's simple.

I'll just sum it up here. This is for an Expo Web app which will then work on the mobile as well as web.
Import this at the top of your main form:
import {DateTimePickerModal as MobileDateTimePickerModal} from "react-native-modal-datetime-picker"; import ReactDatePicker from "react-datepicker"; import "ReactDatePicker_CSSHelper";
The above CSS helper import is to get around the general silliness with regards to import/require and discrepancies between what works on the mobile vs the web app. Add the following two files to your project with the contents as below:
File 1: filename must be "ReactDatePicker_CSSHelper.js":
import * as css from "react-datepicker/dist/react-datepicker.css"; export default css;
File 2: filename must be "ReactDatePicker_CSSHelper.native.js":
export default undefined;
The state stuff at the top of your main form:
const initialState = { model: new <your data model here e.g. as defined in schema.graphql or just your own class, your class must include a field called date1, mine is of type AWSDateTime>({ }), ...<whatever else you want to initialize in the initial state>... };
The state stuff declared at the top inside the function() {...} block:
 const [formState, updateFormState] = useState(initialState);   const [isMobileDatePickerVisible_date1, setMobileDatePickerVisibility_date1] = useState(false);
Add these functions to your main form inside the function() {...} block:
`  function setFormState_model(key, value) {
updateFormState({...formState, model: {...formState.model, [key]: value } });
}
const WebDatePicker_date1_CustomTimeInput = ({ date, value, onChange }) => (
<ReactDatePicker
selected={formState.model.date1!=undefined ? new Date(formState.model.date1) : new Date()}
onChange={selectedDati => { setFormState_model("date1", selectedDati.toISOString()) }}
showTimeSelect
showTimeSelectOnly
timeIntervals={1}
timeCaption="Time"
dateFormat="HH:mm"
timeFormat="HH:mm"
/>
);
const showMobileDatePicker_date1 = () => {
setMobileDatePickerVisibility_date1(true);
};
const hideMobileDatePicker_date1 = () => {
setMobileDatePickerVisibility_date1(false);
};
const handleMobileDatePickerConfirm_date1 = date => {
setFormState_model("date1", date.toLocaleString());
hideMobileDatePicker_date1();
};
function _DateTimePicker_date1()
{
if(Platform.OS === "ios" || Platform.OS === "android") {
return(

<MobileDateTimePickerModal
isVisible={isMobileDatePickerVisible_date1}
onConfirm={handleMobileDatePickerConfirm_date1}
onCancel={hideMobileDatePicker_date1}
mode={"datetime"}
is24Hour={true}
date={formState.model.date1!=undefined ? new Date(formState.model.date1) : new Date()}
value={formState.model.date1}
/>
Label for date1
<Input
disabled={true}
onTouchEnd={()=>{showMobileDatePicker_date1(); console.log({touchEnd:"touchEnd"});}}
placeholder="Placeholder text for date1"
value={formState.model.date1}
style={globalStyles.detailsLabel}
/>

);
} else {
return(

Label for date1

<ReactDatePicker
portalId="root-portal"
selected={ formState.model.date1!=undefined ? new Date(formState.model.date1) : new Date() }
onChange={ selectedDati => { setFormState_model("date1", selectedDati.toISOString()); } }
peekNextMonth
showMonthDropdown
showYearDropdown
dropdownMode="select"
todayButton="Today"
timeIntervals={1}
customTimeInput={<WebDatePicker_date1_CustomTimeInput/>}
showTimeInput
dateFormat="yyyy/MM/dd HH:mm"
/>

);
}
}
`
In your main form's return statement:
 return (       <View>           <ScrollView>                   {_DateTimePicker_date1()}           </ScrollView>       </View>   );
@mmazzarolo I'm pretty sure the above could easily be pulled into react-native-modal-datetime-picker to provide Expo Web support.

Very happy we're having this discussion 💥
Let me ask you all a question: why do you feel adding support for the web to this component would be a good idea?
Since those examples aren't using a modal (it's more of a popover, right?), wouldn't it make more sense if the support was added to the community datetimepicker instead -- which already supports a similar solution for Windows?
To clarify: I'm not against adding support for it here 👍 I'm just wondering if it's the right approach or not, given that  what this modal datetimepicker is doing is just wrapping the community picker and expose it into a unified modal-UI.

I hear you, i think maybe it does not belong inside either of these because they are both based on native - and the react-datepicker is not native.
Actually i think it would make most sense to create a new component based on the code i sent earlier which then uses react- atove-modal-datetimepicker for mobile and react-datepicker for the web.
The purpose of such a component would simply be to provide a reasonable out-of-the-box component that people can use in an Expo Web / React Native Web app which works from the mobile as well as from the web. Because currently there is nothing even close to decent and cross-browser out there that does both, at least none that i could find. What do you think?

i think maybe it does not belong inside either of these because they are both based on native

I don't see this as the main problem in all honesty. I think the "native" word in the react-native ecosystem is more scoped to the platform where the code itself run... meaning for the web it will be JS, which is fine.
My concern here is just that react-native-modal-datetimepicker is focused on showing the content on a modal... and the more I think about it, the more I think the approach on the web is leaning toward a popover-like style (which would be totally out-of-scope in this repo).
I feel that react-native-datetimepicker might suit better this use case. That said, I'm pretty sure the maintainers there are quite busy nowadays, so this is something that should be kickstarted by how's interested in it (while still pinging the maintainers beforehand).
Just my 2 cents.

Ok, but i mean the true web native control for picking a date is the <input ... type="date" ...> as per https://developer.mozilla.org/en-US/docs/Web/HTML/Element/input/date - which is not supported by all modern browsers. So react-datepicker is not the actual native thing. But maybe that doesn't matter that much.
But anyway i just thought i would share my code as i struggled a bit to get it working. I don't have the time right now to do a separate wrapper for it but i think it would work well, so if anyone else wants to run with it please feel free.

My concern here is just that react-native-modal-datetimepicker is focused on showing the content on a modal.

I've come to agree with this.
I have tried a number of web date pickers in the past few days. Materials UI's has been the best one to use on web for a number of reasons.

great developer experience, easy to use, and the API is very similar to this package
the design is great
perhaps most importantly, the moral behavior on web feels very consistent with the modal behavior on other devices when used with this library.

I understand the motivation to use a native HTML date picker to stay closer to the browser's api. That said, I think such a picker belongs in @react-native-community's picker. (Turns out the HTML picker has terrible browser support so I maybe still wouldn't use it there, but in principle, that's where it should belong.
This library is a modal date time picker, and it should have a modal experience on all platforms IMO. The material UI one is very smooth, lightweight, and has a design that's consistent with this modal picker.

Just wanted to put this out there as of Oct 22 Safari now supports the date, time, and date-time picker. So they are fully supported across all browsers except IE. I am using the web-native date pickers and think it's the way to go. However, I would agree that maybe it doesn't belong in this repo.

Relevant package: https://github.com/web-ridge/react-native-paper-dates

First of all, Hello everyone. How can I print the time I selected in the text component?
I just want to print the clock.

Hey @nigranac ! This is not the right place to discuss your issue :) Please ask on Stackoverflow, thanks!

Hi all, I want to disable the specified date. I saw all the properties but couldn't see the solution. How I can do that? Please help me. Thank you


The IP address configured for the host-only network is not within the allowed ranges.

oah-bes-vm: Clearing any previously set network interfaces...
The IP address configured for the host-only network is not within the
allowed ranges. Please update the address used to be within the allowed
ranges and run the command again.
Address: <IP_ADDRESS>
Ranges:
Valid ranges can be modified in the /etc/vbox/networks.conf file. For
more information including valid format see:
https://www.virtualbox.org/manual/ch06.html#network_hostonly

https://www.virtualbox.org/manual/ch06.html#network_hostonly
Update /etc/vbox/networks.conf file with the desired range.
The range should be prefixed with asterisk(*)


fix default value

When not in character mode, all shell input ends with a newline, which
among other things breaks the handling of default values in
Question#evaluate_response.
This commit removes the newline and changes Question#evaluate_response
to interpret an empty string as no entry.

This is probably not the "right" fix, but I thought it would be a good basis to improve ...

Definitely not the right fix. Discussion continues at https://github.com/peter-murach/tty/issues/17.


The view function for 'flask_saml2_sp.acs' did not return a valid response.

I'm using flask_saml2 library for my SP and as an IDP I'm using Wordpress with miniorange plugin.
SP correctly redirects to IDP login, but after a successful login into wordpress the request is being made to my SP URL /saml/acs, but I get the following error.
<IP_ADDRESS> - - [11/Feb/2022 04:57:37] "POST /saml/acs/ HTTP/1.1" 500 -
Traceback (most recent call last):
  File "/root/sp/venv/lib/python3.8/site-packages/flask/app.py", line 2091, in __call__
    return self.wsgi_app(environ, start_response)
  File "/root/sp/venv/lib/python3.8/site-packages/flask/app.py", line 2076, in wsgi_app
    response = self.handle_exception(e)
  File "/root/sp/venv/lib/python3.8/site-packages/flask/app.py", line 2073, in wsgi_app
    response = self.full_dispatch_request()
  File "/root/sp/venv/lib/python3.8/site-packages/flask/app.py", line 1519, in full_dispatch_request
    return self.finalize_request(rv)
  File "/root/sp/venv/lib/python3.8/site-packages/flask/app.py", line 1538, in finalize_request
    response = self.make_response(rv)
  File "/root/sp/venv/lib/python3.8/site-packages/flask/app.py", line 1701, in make_response
    raise TypeError(
TypeError: The view function for 'flask_saml2_sp.acs' did not return a valid response. The function either returned None or ended without a return statement.

Can somebody point me to the relevant peace of code? Where can I find this view/function?

This was fixed by configuring the correct URLs on the SP side.

Hi, I have the same error and I don´t know how to solve it.
Can you explain me your solution with more detail please?

@Gonzalopachecotena honestly I don't remember, but I would recommend you double triple check the URLs in the saml configuration on the SP side.


Blog Post: Avoiding flaky tests.

Capture some thoughts from our efforts a few sprints back to squash various server-side flaky tests.

Awesome blog post :+1:


Development docker, pre-commit and eslint updates & refactoring

This PR:

makes a few local docker dev tweaks (enables hot reloading, and pins docker-compose project name to allow for better git worktree use)
tweaks the JSON schema generation hook, so that it only runs when models actually change (cf. #785)
updates ESLint and babel, and refactors the config so that it can be used as a pre-commit hook

Closes #800.

Going to merge this so we can get some other stuff in, but think at least @jdbocarsly will want to quickly look over this

Edit: actually, it seems eslint isn't running locally for me when I change .vue or .js files (and presumably others). It is simply skipping them, and if I force it to run with pre-commit run --all-files, then it passes even when it shouldn't. I think it is not correctly detecting the files it should, but I can't figure out why.

My final commits seem to fix this, going to merge and keep an eye on it.


Request Access Button Missing for Private Tools in UI2

Bug Report
The Request Access button is not present on the private tools page of the new UI.
Steps to reproduce the behaviour
Note how on https://dockstore.org:9000/containers/registry.hub.docker.com/broadinstitute/pcawg_broad_wgs_variant_callers/pcawg-broad-wgs-variant-caller in the old UI, there is a Request Access on Docker Hub button at the top right of the page.
If you navigate to the same tool https://dockstore.org/containers/registry.hub.docker.com%2Fbroadinstitute%2Fpcawg_broad_wgs_variant_callers%2Fpcawg-broad-wgs-variant-caller in the new UI, there is no Request Access on Docker Hub button.

Back on staging.dockstore.org


Fix class name for PHP7 compatibility

Hello,
I renamed the class String, Float, Int and Bool to be compatible with PHP7 (reserved keywords)
There is no code changes to be expected if you already use
/** @MongoDB\Field(type="string") */

instead of
/** @MongoDB\String */

in the annotations of an entity.
Thanks,
Yoann

Thanks for the PR. It seems you've created this against my fork instead of the original at doctrine/mongodb-odm. Regardless, this was adressed in doctrine/mongodb-odm#1205 (which does not import the string, bool, int and float annotation classes in PHP 7) and doctrine/mongodb-odm#1318 (which deprecates all type annotations in favor of @Field(type=...).

Oups, sorry for that.
I well use the original repository but I had the problem in classes String, Int, Float and Bool, used by annotations.
I did some research and I came on your repository, thinking he had solved the problem. But the problem was well annotations... :s
Thank you very much !


Train Chest pickup and spawn not correctly updating the item

BkCommonLib version: b597
TrainCarts version: b504
Spigot version: b1573-j

Problem or bug:
In Survival

Train Chest does not become empty after placing down a train.
Train Chest does not stop players from picking up a train after it has a train in it.
Pick-up and drop-off does not correctly update the item name, unlike creating a chest with a command (Expected Traincarts Chest (Empty), Traincarts Chest (TrainName), got Traincarts Chest)

Oh I never intended for the chest item to be used in survival mode, I can see the complaints in that case. Should behavior be different when in survival vs creative mode? Or perhaps it needs a different command for a 'survival' chest?

@Wortho27 see above.

@bergerkiller

TCCoaster Version: Last Build
TrainCarts v1.14.4-v2-SNAPSHOT (build:552)
BkcommonLib v1.14.4-v2-SNAPSHOT (build:657)
Bugs:
https://streamable.com/18oga
https://streamable.com/wqc92
https://streamable.com/xrgbu

The name (point 3) is a little difficult to do, because the original saved train name that a train on the track represents isnt kept around. I could use the name of the train, but idk how useful that is. ('train12')
I guess being able to lock a chest so it cannot pick up another train when clicking can be useful also in creative. I could make it a tag set when giving the chest item, which is also set when giving a survival chest in the future.
When I got time Ill look at implementing something basic for survival use. Only thing is, it feels weird to require commands to obtain such an item. Normally this is done through a crafting recipe. If there's a better way to do this, I'm open for suggestions.

I... think this has been implemented using the TrainNameFormat property and it... should be working... so let's just close this shall we.


WIP: Implement Pascals Triangle

Following the official tests
We can't test negative or no rows because the function declares u32 in its signature.

Ok. I'm happy with the implementation, so it's time to hear about all the dumb mistakes I made in it.
As for position, I think this can go fairly early. The weirdest part of it is returning a Vec of Vecs, and that's not that weird. The meat of this problem is just math, all of which I cribbed from Wikipedia.
Other implementations of this I've seen use the values from the previous row to calculate the current row, which means handling out-of-bounds vec indexes. We'll want to take that into account when determining position.

Oh, and all of the number casting. That is kinda weird, if you're used to a language that is more forgiving with numeric types.

API question:
PascalsTriangle::new(3).rows()

or
PascalsTriangle::with_rows(3)

or
PascalsTriangle::rows(3)

I don't think I would mind any of the three proposed APIs.
I would place no later than Roman numerals. Probably no earlier than, say... Hamming.


fix button style in home page which pollute other place

Please always provide the GitHub issue(s) your PR is for, as well as test URLs where your change can be observed (before and after):
Fix #
Test URLs:

Before: https://main--zemax--hlxsites.hlx.page/
After: https://issue-88--zemax--hlxsites.hlx.page/

close this PR first to see if generic style can work here


Tag promoting image with its major and minor version

Description
Tag promoting image with its major and minor version.
Add two additional boolean parameters to enable promoting staging images with its major or minor version tag.
E.g.: for example new 1.3.3 docker image will have options to label with 1 ({major} version), 1.3  ({major}.{minor} version) and latest when promoting from staging.
Issues Resolved
#1621
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Codecov Report

Merging #2127 (3fe032b) into main (4e6dc30) will decrease coverage by 0.02%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main    #2127      +/-   ##
============================================
- Coverage     94.24%   94.21%   -0.03%
  Complexity       25       25
============================================
  Files           203      204       +1
  Lines          3907     3943      +36
  Branches         29       29
============================================
+ Hits           3682     3715      +33
- Misses          219      222       +3
  Partials          6        6

Impacted Files
Coverage Δ

...ests/jenkins/jobs/CopyContainer_docker_Jenkinsfile
100.00% <ø> (ø)

src/run_sign.py
91.66% <0.00%> (-3.79%)
:arrow_down:

src/manifests/component_manifest.py
92.00% <0.00%> (-3.24%)
:arrow_down:

src/manifests/input_manifest.py
96.55% <0.00%> (-0.68%)
:arrow_down:

src/ci_workflow/ci_args.py
100.00% <0.00%> (ø)

src/test_workflow/test_args.py
100.00% <0.00%> (ø)

src/build_workflow/build_args.py
100.00% <0.00%> (ø)

src/sign_workflow/sign_args.py
100.00% <0.00%> (ø)

src/sign_workflow/sign_artifacts.py
98.07% <0.00%> (+0.03%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4e6dc30...3fe032b. Read the comment docs.

We will hold this PR until updates on this PR #2128

@peterzhuamazon @zelinh @prudhvigodithi Whats the next step on this PR?

The docker-copy code, should be able to copy the images across registries (DockerHub and ECR). This job can be leveraged to push the images with required major, minor versions.
@bbarani @peterzhuamazon @zelinh

The docker-copy code, should be able to copy the images across registries (DockerHub and ECR). This job can be leveraged to push the images with required major, minor versions. This issue #1621 should not be a blocker moving forward 👍 @bbarani @peterzhuamazon @zelinh

Agree. I would discuss with @peterzhuamazon tomorrow on how we could design for specifically docker promotion with major or latest tag.

After discussing with @peterzhuamazon, I will close this PR for now since we think the issue resolved here could also be executed with the new copy container workflow.
https://github.com/opensearch-project/opensearch-build/blob/main/jenkins/docker/docker-copy.jenkinsfile


Add preferHanging configuration for expressions

Closes #73.
This will be a nice change.

Code is about 150ms slower on checker.ts. Overall, it's at 1140ms from 772ms a few weeks ago.
Not to worry though, I have some ideas to make this faster, but doing that is low priority at the moment... (ex. in the printer, look ahead conditions should only be jumped back to if necessary).


How do I use proxy with SEOstats?

I didn't find any documentation on some basic stuff that I need to setup when using SEOstats on live server.
For example:

How do I set proxy server IP on SEO stat?
How to change user-agent when SEO stat makes request.

Looking at the source code. It seem all those parameters are hard coded. What is the workaround?

I join to the question

Not sure why I didn't get email notification! sigh!

Closed by merging @tholu's PR (#129)


pull request for e2e test at 01/26/2017 07:15:06

:white_check_mark: Validation status: passed
For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


MavenDependencyResolver findfile

Currently the findfile implementation loops through the entire list of files in a directory and filters files that are not directories and match the filename pom.xml.
Current code:
private File findfile(File file) {
    File[] files = file.listFiles();
    if (files != null) {
        for (File f : files) {
            if (!f.isDirectory() && MavenWorkspace.DEPENDENCY_FILE_NAME.equalsIgnoreCase(f.getName())) {
                return f;
            }
        }
    }
    throw new NoDependencyFileFoundException("Could not find pom.xml in project root", new FileNotFoundException());
}

Because you already now the name of the file, there is not much value in scanning through the entire directory. It might be more efficient and faster to do the following in getDependencyDocument
try {
    return Files.newBufferedReader(Paths.get(projectRoot, "pom.xml"));
} catch (NoSuchFileException e) {
    throw new NoDependencyFileFoundException("Reader could not load pom file", e);
} catch (IOException e) {
    throw new UncheckedIOException(e);
}

Some of the code in findfile was not fully covered by tests according to SonarCloud. So we might see an increase in coverage. If not, we can see if we need to add tests for the exception scenarios.


perf: generate differential flamegraph

We have continuous integration on the performance benchmark. When a regression occurs, we can download flame-graphs to investigate the problem. However, it's not intuitive to compare two flamegraphs and often leads to confusing results. For example, in #12959 we even reversed the results before and after the regression! 😅
It will be better if we can automate to find the diff of two flamegraphs. Some references that might be helpful:

https://www.brendangregg.com/blog/2014-11-09/differential-flame-graphs.html
https://github.com/brendangregg/FlameGraph/blob/master/difffolded.pl

I think there may be a low-hanging fruit: just provide the stackcollapsed file together with the svg. Then we can manually diff them.

Another use case is for the memory flame graph to track how allocation grows over time.


HWKAPM-632 Fix NPE on server when validating a business txn config fr…

…om the UI

@pavolloffay could you review please?

@pavolloffay Thanks!


EOS-18888: hare_setup.py is redundant and must be removed

Solution : hare_setup.py was copied as is into hare_mp/main.py. We don't need to maintain duplicated code,
so that hare_setup.py is removed and all other components (like Provisioner) start using hare_mp/main.py (and thus hare_setup executable) instead.
Signed-off-by: Supriya Chavan<EMAIL_ADDRESS>

Can one of the admins verify this patch?


Google Cloud Deployment Fails when Installing the GRID Drivers

With the update to IsaacSim 4.2 and new IsaacLab release I tried to use IsaacAutomator to deploy instances on GPC. My previous deployments with Isaac 4.1 have worked and my AWS deployment with Isaac 4.2 works, so I have reason to believe that Google changed something on their hypervisor because I have issues trying to install Nvidia Drivers, so this problem extends beyond IsaacAutomator. The Ansible roles must be reviewed for GCP as not only it no longer install the drivers reliably, there are some infinite loops not accounted for.
Here is the command I used for to deploy:
./deploy-gcp --ngc-api-key NGC-KEY --project PROJECT-ID --deployment-name test-gcp-issacsim --isaac --isaac-gpu-count 1 --isaac-instance-type g2-standard-32 --isaac-image nvcr.io/nvidia/isaac-sim:4.2.0 --vnc-password 123456 --zone us-west1-a --oige no --isaaclab v1.3.0
Error message:
TASK [nvidia : GCP / Install GRID driver] *********************************************************************************************fatal: [<IP_ADDRESS>]: FAILED! => {"changed": true, "cmd": "/tmp/nvidia_driver.run --x-module-path=/usr/lib/xorg/modules/drivers --run-nvidia-xconfig  --disable-nouveau --no-questions --silent", "delta": "0:00:13.559158", "end": "2024-11-28 21:26:31.862749", "msg": "non-zero return code", "rc": 1, "start": "2024-11-28 21:26:18.303591", "stderr": "\nERROR: An error occurred while performing the step: \"Building kernel modules\". See /var/log/nvidia-installer.log for details.\n\n\nERROR: An error occurred while performing the step: \"Checking to see whether the nvidia kernel module was successfully built\". See /var/log/nvidia-installer.log for details.\n\n\nERROR: The nvidia kernel module was not created.\n\n\nERROR: Installation has failed.  Please see the file '/var/log/nvidia-installer.log' for details.  You may find suggestions on fixing installation problems in the README available on the Linux driver download page at www.nvidia.com.", "stderr_lines": ["", "ERROR: An error occurred while performing the step: \"Building kernel modules\". See /var/log/nvidia-installer.log for details.", "", "", "ERROR: An error occurred while performing the step: \"Checking to see whether the nvidia kernel module was successfully built\". See /var/log/nvidia-installer.log for details.", "", "", "ERROR: The nvidia kernel module was not created.", "", "", "ERROR: Installation has failed.  Please see the file '/var/log/nvidia-installer.log' for details.  You may find suggestions on fixing installation problems in the README available on the Linux driver download page at www.nvidia.com."], "stdout": "Verifying
archive integrity... OK\nUncompressing NVIDIA Accelerated Graphics Driver for Linux-x86_64 535.129.03........................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................", "stdout_lines": ["Verifying archive integrity... OK", "Uncompressing NVIDIA Accelerated Graphics Driver for Linux-x86_64 535.129.03........................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................"]}

PLAY RECAP ****************************************************************************************************************************<IP_ADDRESS>              : ok=34   changed=25   unreachable=0    failed=1    skipped=23   rescued=0    ignored=0

This issue is mostly related to Ansible trying to install the Nvidia Drivers on the GCP in a way that is no longer supported:
Inside: src/ansible/roles/nvidia/tasks we find the file nvidia-driver.gcp.yml
The TASK: name: GCP / Install GRID driver
is running the following command
./nvidia_driver.run --x-module-path=/usr/lib/xorg/modules/drivers --run-nvidia-xconfig --disable-nouveau --no-questions --silent
When logging into the instance and running the command described above I obtain the following error:
ubuntu@isaac-test-gcp-issacsim:/tmp$ sudo ./nvidia_driver.run --x-module-path=/usr/lib/xorg/modules/drivers --ru
n-nvidia-xconfig --disable-nouveau --no-questions --silent
Verifying archive integrity... OK
Uncompressing NVIDIA Accelerated Graphics Driver for Linux-x86_64 535.129.03........................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................

WARNING: One or more modprobe configuration files to disable Nouveau are already present at:
         /usr/lib/modprobe.d/nvidia-installer-disable-nouveau.conf,
         /etc/modprobe.d/nvidia-installer-disable-nouveau.conf.  Please be sure you have rebooted your system
         since these files were written.  If you have rebooted, then Nouveau may be enabled for other reasons,
         such as being included in the system initial ramdisk or in your X configuration file.  Please consult
         the NVIDIA driver README and your Linux distribution's documentation for details on how to correctly
         disable the Nouveau kernel driver.

ERROR: An error occurred while performing the step: "Building kernel modules". See
       /var/log/nvidia-installer.log for details.

ERROR: An error occurred while performing the step: "Checking to see whether the nvidia kernel module was
       successfully built". See /var/log/nvidia-installer.log for details.

ERROR: The nvidia kernel module was not created.

ERROR: Installation has failed.  Please see the file '/var/log/nvidia-installer.log' for details.  You may find
       suggestions on fixing installation problems in the README available on the Linux driver download page at
       www.nvidia.com.

When following the installation instructions on GCP docs to fix the Ansible role: https://cloud.google.com/compute/docs/gpus/install-grid-drivers#debianubuntu
It install the drivers but the It is still unable to complete the setup, other issues arise one of them being an infinite loop in the autorun.yml
xset is unable to open the display and it keeps waiting for it.

I dont think I can do a PR so I will post the solution:
In the Isaac Sim docs the recommended way is to run the script found here:
https://github.com/GoogleCloudPlatform/compute-gpu-installation/blob/main/linux/install_gpu_driver.py
https://docs.omniverse.nvidia.com/isaacsim/latest/installation/install_advanced_cloud_setup_gcp.html
So to fix the Ansible it is required just some minor changes:
the config.py line 35 needs to include the following
# gcp driver
# @see https://cloud.google.com/compute/docs/gpus/grid-drivers-table
c["gcp_driver_url"] = (
    # "https://storage.googleapis.com/nvidia-drivers-us-public/GRID/vGPU16.2/NVIDIA-Linux-x86_64-535.129.03-grid.run"
    "https://raw.githubusercontent.com/GoogleCloudPlatform/compute-gpu-installation/main/linux/install_gpu_driver.py"
)

At the nvidia-driver.gcp.yml from Line 35 below I commented the code that is no longer necessary, GRID drives are no longer necessary and dont work at all. So we should just run the install script as recommended in Isaac Sim docs and on the GCP docs.
# #######################################################
# This method doesnt work anymore on the Google Cloud
# download driver
# - name: GCP / Download GRID driver
#   get_url:
#     url: "{{ gcp_driver_url }}"
#     dest: /tmp/nvidia_driver.run
#     mode: 0755

# - name: GCP / Install GRID driver
#   shell: "/tmp/nvidia_driver.run \
#     --x-module-path=/usr/lib/xorg/modules/drivers \
#     --run-nvidia-xconfig  \
#     --disable-nouveau \
#     --no-questions \
#     --silent"

# #######################################################

- name: GCP / Download script to install GPU driver
  get_url:
    url: "{{ gcp_driver_url }}"
    dest: /tmp/install_gpu_driver.py
    mode: 0755

- name: GCP / Install gpu driver
  shell: "python3 /tmp/install_gpu_driver.py"

# #######################################################
- name: GCP / Enable persistent mode for the driver
  shell: nvidia-smi -pm ENABLED
# #######################################################
# The following commands need to be double checked
# - name: GCP / Copy gridd.conf
#   copy: >
#     src=/etc/nvidia/gridd.conf.template
#     dest=/etc/nvidia/gridd.conf
#     remote_src=true
#     force=no

# - name: GCP / Update GRID config [1]
#   lineinfile:
#     path: /etc/nvidia/gridd.conf
#     line: "{{ item }}"
#     state: present
#   with_items:
#     - "IgnoreSP=FALSE"
#     - "EnableUI=TRUE"

# - name: GCP / Update GRID config [2]
#   lineinfile:
#     path: /etc/nvidia/gridd.conf
#     regexp: "^FeatureType=(.*)$"
#     line: '# FeatureType=\1'
#     state: present
#     backrefs: yes

Additionally I would like to comment that it is necessary to add some logic to double check and allow for multiple driver versions and the Terraform code might need improvements

@renanmb Thank you so much for reporting and solving this! I will include it asap.


[BugFix] publish version return tablet version even though it's transaction have finished

What type of PR is this：

[x] BugFix
[ ] Feature
[x] Enhancement
[ ] Refactor
[ ] UT
[ ] Doc
[ ] Tool

Which issues of this PR fixes ：
Fixes #16370
Problem Summary(Required) ：
If FE miss the last finish_publish_version req return by BE, and then retry send publish_version req to BE, BE wouldn't return the tablet's version back to FE if transaction has finished. So FE have to wait for tablet infos report by BE, and then this transaction can be visible. Reliable on tablet infos report by BE to make transaction visible can be very slow.
So we can let BE returns the tablet's version back to FE if transaction has finished, to make transaction be visible more quickly.
Checklist:

[x] I have added test cases for my bug fix or my new feature
[ ] This pr will affect users' behaviors
[ ] This pr needs user documentation (for new or modified features or behaviors)

[ ] I have added documentation for my new feature or new function

Bugfix cherry-pick branch check:

[x] I have checked the version labels which the pr will be auto backported to target branch

[x] 2.5
[x] 2.4
[x] 2.3
[x] 2.2

@Mergifyio backport branch-2.5

@Mergifyio backport branch-2.4

@Mergifyio backport branch-2.3


Shared arguments across subcommands

Is something like this possible, with shared arguments across subcommands?

@GregorySchwartz: Not easily with the current API.  I think what this package would be missing is something like the :. type from the postgresql-simple package with an instance of the form:
instance (ParseRecord a, ParseRecord b) => ParseRecord (a :. b)

… because if you had that then you could do something like:
data UniqueOptions = SumPayments { user :: Text } | ListUsersSeen | SumQueries

data SharedOptions = SharedOptions{ start :: Text, end :: Text }

main :: IO ()
main = do
    (uniqueOptions :. sharedOptions) <- getRecord "Example"

    …

I haven't thought through all of the details for that, though


Wrong PostScript syntax highlighting

Describe the bug
See the issue: https://github.com/multiformats/multicodec/issues/278 It is supposed to be a PostScript code but there are some unusual things with the syntax highlighting.
Expected behaviour
The comment that says % discard header line should be same colours of other comments, and words such as pop and if should not have different colours in different parts of the program; they should be consistent.

I am guessing that it might be confused by the use of the currentfile operator. However, in this case the currentfile is inside of a {} block, and therefore is not executed right away and does not access the data inside of the {} block.

Linguist doesn't directly control syntax highlighting. As listed in https://github.com/github/linguist/tree/master/vendor the PostScript grammar is taken from https://github.com/Alhadis/Atom-PostScript. You should take this issue there.

OK, I will post the issue on Alhadis/Atom-PostScript instead. Thank you for telling me that; somehow I had forgotten about that list, but now I know better.


Use the Stable Horde async api

The Stable horde has recently disabled the 'sync' api. Since that's what we were using, this has left
the stable horde support of the plugin broken.
This PR moves the stable horde back-end support to the 'async' end-point, which is currently the recommended way of using the api.
Additionally; Not all samplers work on stable horde for img2img, removed the ones that don't work.

This looks great - glad you're on top of this! I'd suggest two small changes:

Either remove request_timeout() or use it when creating the range for how long to keep checking the check endpoint. (And set the timeout on all actual requests to something smaller, like 5-10 seconds?)
Add an error_key to all calls to handle_error. I'm using that for analytics now, in addition to some special handling in te UI

Good suggestions. Updated the MR.

Great. I will test this out when I have a chance in a few hours, and hopefully release it tonight.


Mount volumes read only

Thanks for the PR @J0WI, I'll have a look at it later on.

LGTM but could you update the https://github.com/docker/docker-bench-security/blob/master/README.md#building-docker-bench-for-security section as well?

Please sign your commits following these rules:
https://github.com/moby/moby/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:
$ git clone -b "ro" git@github.com:J0WI/docker-bench-security.git somewhere
$ cd somewhere
$ git rebase -i HEAD~842357816184
editor opens
change each 'pick' to 'edit'
save the file and quit
$ git commit --amend -s --no-edit
$ git rebase --continue # and repeat the amend for each commit
$ git push -f

Amending updates the existing PR. You DO NOT need to open a new one.

Thanks!


PSA: Add documentation to spec on assert and assume extern functions

This PR adds assert and assume extern functions to the psa.p4 include file: https://github.com/p4lang/p4-spec/pull/1171
They should also be described in the text of the PSA specification.

PR merged.


Rename acrylic resources

Describe the bug

With #3498 we added and updated acrylic resources. Now it's time to change the names of these resources to better align with other new colors/brushes that are being checked in.
I would like to see the following changes:

Current resource name
New name

SystemControlBaseAcrylicBrush
AcrylicBackgroundFillColorBaseBrush

SystemControlTransientBackgroundBrush
AcrylicBackgroundFillColorDefaultBrush

SystemControlTransientAcrylicElementBrush
AcrylicInAppFillColorDefaultBrush

SystemControlTransientBackgroundInverseBrush
AcrylicBackgroundFillColorDefaultInverseBrush

Control styles that use the old names (in particular SystemControlTransientBackgroundBrush and SystemControlTransientAcrylicElementBrush) will also need to be updated.
Additional context

Copied from internal task

@chingucoding FYI, just in case you would be interested in tackling this work.

Sure, I'll work on this.

Is this for the main branch, or for the Design Tokens one?


refactor(router): remove deprecated feature and related old code

Signed-off-by: knight42<EMAIL_ADDRESS>Commit Message: refactor(router): remove dprecated runtime feature and related old code.
Additional Description: It has been 6 monthes since envoy.reloadable_features.preserve_query_string_in_path_redirects was introduced, and this runtime feature is deprecated now.
Risk Level: N/A
Testing: N/A
Docs Changes: N/A
Release Notes: Runtime feature envoy.reloadable_features.preserve_query_string_in_path_redirects is removed now.
Platform Specific Features: N/A
[Optional Runtime guard:]
Fixes #14648
[Optional Deprecated:]

/cc @mattklein123 PTAL

/cc @mattklein123 PTAL

/retest

/retest

I'm confused but I think the coverage issue is legitimate. Can you take a look? You can look at the coverage report through CI and also compare it to the main branch coverage: https://storage.googleapis.com/envoy-postsubmit/master/coverage/index.html
/wait

I'm confused but I think the coverage issue is legitimate. Can you take a look? You can look at the coverage report through CI and also compare it to the main branch coverage: https://storage.googleapis.com/envoy-postsubmit/master/coverage/index.html
/wait

I am confused as well.. The presubmit job failed because: (link)
Per-extension coverage failed:
Code coverage for source/extensions/transport_sockets/tap is lower than limit of 96.6 (95.7)

I cannot think of the reason why the coverage of source/extensions/transport_sockets/tap should be affected by this PR. I will take a closer look later.

I am confused as well.. The presubmit job failed because: (link)
Per-extension coverage failed:
Code coverage for source/extensions/transport_sockets/tap is lower than limit of 96.6 (95.7)

I cannot think of the reason why the coverage of source/extensions/transport_sockets/tap should be affected by this PR. I will take a closer look later.


Multiple styles of notifications

Is there a way to have different styles of notifications running concurrently?
Maybe using hints?
string:wired-name:centered:
(
  name: "centered",
  params: NotificationBlock(( ... ))
)

string:wired-style:top-right:
(
  name: "top-right",
  params: NotificationBlock(( ... ))
)

This is an interesting idea.  Maybe it can be worked into render_criteria.  I will look into it.

Here's an example of what I've been trying to accomplish.
https://gist.github.com/lukelex/d6fb76294ca48787169e21bb7f7d921e
The only thing missing is being able to position each type of notification independently.

I'm thinking the best way to enable this is probably by allowing multiple root blocks, and spawning a window for each of them that should draw.  It does clutter a few things for a smallish use case but seems intuitive.

I've just pushed a commit to master that allows for this.  It was a pretty big undertaking and I'm expecting it to be buggy, so please try it out!

Thanks for closing it. It works as I needed to, for now.
Completely forgot to follow up on this 😅


FIX: [CI / Adaptation Prompt] Fix CI on transformers main

What does this PR do?
https://github.com/huggingface/transformers/pull/29109 changed the output shape of cos / sin generated by the rotary embedding, by considering the case of batched inference. This PR fixes it
cc @pacman100 @BenjaminBossan

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.


writeToDisk option used by webpack-dev-middleware isn't supported

Operating System: Win10
Node Version: 10
NPM Version: 6
webpack Version: 4
karma-webpack Version: 4.0.0-rc.6

Expected Behavior
writetodisk option should instructs webpack-dev-middleware to write files to the configured location on disk as specified in webpack config file.
Actual Behavior
karma-webpack ignores output path specified in webpack configuration and overrides it to the following path:
https://github.com/webpack-contrib/karma-webpack/blob/11cb4fb2af12271bade16915066be47cbc2e85d7/src/karma-webpack.js#L93-L98
Code
// karma.conf.js
webpack: {
  output: {
    // output path is ignored by karma-webpack
    path: path.join(__dirname, './dist'),
  },
},
webpackMiddleware: {
  // https://github.com/webpack/webpack-dev-middleware#writetodisk
  writeToDisk: true
},

How Do We Reproduce?
See karma.conf.js above.

As karma is now deprecated and coming up on EOL, we are no longer planning on any significant enhancements to this project and are instead going to focus on security updates, stability, and a migration path forward as karma's lifecycle comes to an end.
Thank you for supporting and using this project!


Animatable checkbox: Animations for state changes

Pop animation when check or uncheck? somthing like
But can be better transition.

Or somthing like https://dribbble.com/shots/2182807-Checkbox

We can create an CheckBoxAnimationType which will contains pop, squeeze animations or dedicated animations like your dribble link. It follows the current logic of IBanimatable: AnimationType, TransitionAnimationType...
The implementation will be more complex but definitely more scalable and customisable.

@tbaranes That's a good idea, I think we can start with some animations we already have like pop, squeeze, morph, and wobble.

Project with animated checkbox
https://github.com/Marxon13/M13Checkbox


Dart analyzer (strong mode) allows wrong type for assert argument

The assert statement expects either bool argument or function with no arguments, returning bool.
The following code demonstrates the problem:
foo()  {
  return 1;
}

main() {
  assert (foo);
}

Dart analyzer  (strong mode) does not find any issue in this code.
There is no boolean conversion for strict mode, so I believe some issue should be reported for this code.

issue #26002 is also actual for strong mode.
The code
bool foo(x) {
  return false;
}

main() {
  assert (foo);
}

does not cause any issues with Dart analyzer (strong mode)

Looks like a bug. If you try to assing foo to a variable of type ()->bool, you do get a warning, so the type check is missing for assert.

assert now only accepts a bool, not a function. This bug is obsolete.


Service role key for createServerComponentSupabaseClient isn't working

I am trying to use
export const createServerClient = () =>   createServerComponentSupabaseClient({     supabaseUrl: "my sb url;     supabaseKey: "sb service role key";     headers,     cookies,   });
But seems like sb client created by this function still use anon key, so that I got Postgresql permission issue.
Does anyone get the same issue? Any solution to work around?

Actually, reopening to track that we need to improve the docs around this, as this seems to come up every once in a while.

I've opened a PR with documentation for this https://github.com/supabase/supabase/pull/15806, I will close this ticket out once the PR has been merged.

This has now been documented in the Troubleshooting section of our GitHub Discussions. https://github.com/orgs/supabase/discussions/15860


Avoid using Template argument deduction for Vector

CTAD may not be supported by older C++ runtimes e.g. (gcc-7).
Seeing this error with -Werror on SLES builds :
../../../src/onnx/parse_resize.cpp:323:47: error: 'vector' may not intend to support class template argument deduction [-Werror,-Wctad-maybe-unsupported]
            auto vvv_ind = std::vector(n_dim, std::vector(2, std::vector<size_t>(out_elements)));
                                              ^
/usr/lib64/gcc/x86_64-suse-linux/7/../../../../include/c++/7/bits/stl_vector.h:216:11: note: add a deduction guide to suppress this warning
    class vector : protected _Vector_base<_Tp, _Alloc>
          ^
../../../src/onnx/parse_resize.cpp:323:28: error: 'vector' may not intend to support class template argument deduction [-Werror,-Wctad-maybe-unsupported]
            auto vvv_ind = std::vector(n_dim, std::vector(2, std::vector<size_t>(out_elements)));
                           ^
/usr/lib64/gcc/x86_64-suse-linux/7/../../../../include/c++/7/bits/stl_vector.h:216:11: note: add a deduction guide to suppress this warning
    class vector : protected _Vector_base<_Tp, _Alloc>
          ^

but there may be more than one such instance of code

I've enabled -Werror to catch those in CI.

compiler (gcc 7.x) has an upgrade for SLES

SLES docker had gcc 7.5. I am not sure when it is due for an upgrade in QA or DevOps' docker. But I agree that it should be upgraded, it is old.

SLES docker had gcc 7.5. I am not sure when it is due for an upgrade in QA or DevOps' docker. But I agree that it should be upgraded, it is old.

I think gcc 7.x supports CTAD. This warning might be worth ignoring, as an alternative.

I am not sure when it is due for an upgrade in QA or DevOps' docker. But I agree that it should be upgraded, it is old.

We need to support the C++ runtime that applications are using which will be the C++ runtime used by the distro, in the case for sles its gcc 7. If we do upgrade the version it needs to use the one provided by the distro that is binary compatible with gcc 7 runtime. I do know rhel provides newer gcc versions, but I dont know about sles.

I think gcc 7.x supports CTAD.

It does, but the C++ runtime doesn't provide the deduction guidelines.

This warning might be worth ignoring, as an alternative.

We shouldn't ignore this warning, This is useful in diagnosing hard to figure out bugs due to a simple typo:
template<class It>
bool is_palindrome(It first, It last) {
    return std::equal(
        first, last,
        // Typo, should be std::make_reverse_iterator
        std::reverse_iterator(last),
        std::reverse_iterator(first)
    );
}

In general for container and container-like types(like std::tuple) it best to avoid ctad as well since it breaks generic code.


cmd/compile: "go build" makes computer lag, almost hang.

What version of Go are you using (go version)?
go version go1.9.3 linux/amd64
Does this issue reproduce with the latest release?
yes
What did you do?
a.go:
package main

import (
	"fmt"
)

func main() {
	fmt.Println("Hello, playground")
	const k uint64 = 1 << 30
	_ = []int{k:1}
}}

go build a.go
What did you expect to see?
produce a binary in one second.
What did you see instead?
computer becomes lagging, almost hanging.
I must press CTRL-C for several times to stop the building.

I can reproduce the issue with go version go1.9.3 linux/amd64 when replacing the final }} with } to make the code syntactically valid.

The hang may be caused by my computer (8G memory) has not enough memory.
If I change the slice element type to byte, it fails to compile with the following error:
./a.go:10:15: prepwrite: bad off=1073741824 siz=1 s="".statictmp_1

You are trying to create a slice of<PHONE_NUMBER> integers. Which would mean you are trying to get<PHONE_NUMBER> * 8 bytes = 8TB of memory approximately.

Yes. But I think the hang should occur at run time, instead of compile time.

The second issue you reported (the fact that with byte the compiler just prints
./a.go:10:15: prepwrite: bad off=1073741824 siz=1 s="".statictmp_1

) looks more serious.
I suspect it would do the same thing with int64 on a machine with enough memory.

I changed the issue title to highlight the actual crash you reported here, since I believe is more interesting that your machine getting slow on the int64 array.

I think it is to do with the way the slice is being initialized. []int{k:1} creates a slice of 0,0,...1. But if you change the code to make([]int, k) everything works fine. Frankly, I have never seen syntax like this - []int{k:1}.

FTR: foo := []T{n:1} makes foo with n+1 elements in contrast to foo := make([]t, n).
Note to the compiler guys: I guess the compiler tries to be nice wrt to initialization time and puts the images for composite literals in the text and/or data segments - triggering this issue. If that's the case I think the solution would be to detect when the composite literal is very sparse/mostly zero-values and perform instead a run time all-zero value creation and initialization of the non zero-valued items only all in code.

/cc @griesemer @mdempsky @josharian

@cznic Yes, the compiler could probably be a bit smarter here - on the other hand, perhaps one shouldn't write code like this. But I agree that the compiler shouldn't just appear to be hanging.
To summarize:

$ go tool compile x.go
x.go:4:22: prepwrite: bad off=1073741824 siz=1 s="".statictmp_0
for x.go:

package p

func f() {
	_ = []byte{1 << 30: 0}
}

$ go tool compile x.go
x.go:4:21: prepwrite: bad off=8589934592 siz=8 s="".statictmp_0
for x.go (same as above, but int instead of byte):

package p

func f() {
	_ = []int{1 << 30: 0}
}

There's no issue with:

package p

var X = []int{1 << 30: 0}

Not urgent. Moving to 1.12.

Related to #27447


Add tls options in TriggerAuth metadata

Hi team,
This PR will fix the issue #3565
Checklist

[x] When introducing a new scaler, I agree with the scaling governance policy
[x] I have verified that my change is according to the deprecations & breaking changes policy
[x] Tests have been added
[x] Changelog has been updated and is aligned with our changelog requirements
[x] A PR is opened to update the documentation on https://github.com/kedacore/keda-docs/pull/1133
[x] Commits are signed with Developer Certificate of Origin (DCO - learn more)

Hi @dttung2905
(Not pressure at all) Is this ready to review? I haven't done it yet because I have seen the WIP prefix but maybe it's ready and you are expecting the review

Hi @JorTurFer , my bad on the misleading title. Yes, please help to give me some early feedback on my PR 😛

/run-e2e

/run-e2e

/run-e2e

/run-e2e pulsar

/run-e2e

@dttung2905 please let us know when is this ready for a review.

Hi @zroubalik , its ready for review :pray:

/run-e2e

/run-e2e


Update user agent for selected language

VSCode Version: 1.30.2
OS Version: Windows 10 (Version 1809)

Steps to Reproduce:

Type "誤解" with Japanese IME.
It is displayed in Chinese shapes.

Does this issue occur when all extensions are disabled?: Yes (No extensions are installed)
The default system language is English, but I have also added Japanese (with supplemental fonts) in the language settings. Chinese ARE NOT added, because I do not understand it.
I have tested it with VS Code, Notepad++, and Notepad. The font is set to "Consola" for all of them. Notepad++ and Notepad display correct Japanese Kanji, but VS Code displays wrong letters (Chinese version of the same letter). See the first letter "誤" in the screenshot below. It looks different.

I believe this is due to Han Unification and also affects other regional character differences such as Chinese Traditional, Korean, and Vietnamese.  Currently, with the UI set to English, only the Chinese Simplified variant can be displayed.
This is probably only an issue for bilingual users, because installing the Japanese language pack and then switching the UI to that language will cause the correct characters to be displayed.
VS Code doesn't seem to look at the system language settings, and adding Japanese as a second language, without switching the the UI language, doesn't affect the character display.  I also tried uninstalling the language pack and changing the local setting to "ja," but that also had no effect.
In HTML, this could be fixed with a lang attribute, as is done on the Wikipedia page:
直

I posted this wrong time ago. Anyways, at some time after posting this, I circumvented this by adding "Meiryo" to the font list. I don't remember how exactly I did this, but my setting is like this.

Now the text looks correctly like this:

I always encounter this problem in lots of OSes and products, Linux, Windows, Android, Google... They all prioritise Chinese over Japanese when the UI language is English.

This is likely fixed via https://github.com/microsoft/vscode/issues/79579

While this will reduce the number of use cases that expose the issue, I don't think it really fixes it because it limits the user to a specific type of font.  Specifically, a font that defaults to Japanese versions of unified characters, or doesn't contain any other versions.
Ideally, people could use any font that supports Japanese versions of the character, and, in cases where there are multiple versions of the same glyph for different languages, VS Code would display the correct glyph based on the user's language settings.
For example, I would like to use the Hanazono fonts because they have complete coverage of CJK Unicode, but there is no way to see the Japanese versions of the characters in Visual Studio Code without changing the UI language to Japanese.  However, in full Visual Studio, Microsoft Word, and Notepad, the same font displays the Japanese versions correctly.  That's because the Japanese versions of the glyph exist in the font, they are just not being selected for display by VS Code.

Actually, I'm not sure if #79579 will have any effect on this issue since we are talking about the Editor font with the UI language in English.
If I understand correctly, #79579 is referring to the UI font when Japanese is selected as the UI language.
I think users will still have to manually add Meiryo and/or Yu Gothic to this setting in order to use the properties of those fonts to avoid the issue that we are discussing:
"editor.fontFamily": "Yu Gothic, Meiryo, Consolas, 'Courier New', monospace"

@octref May I have your suggestion and expertise on this topic ?

Thanks for taking the time to look into this.  Yes, it's possible to specify multiple fonts, so the user can add a CJK font of their choice to the font stack, but it is not possible to select which language mode that font should use without changing the UI language.
Manually adding a font that bakes-in Japanese as the default is probably a work-around most users can accept, but it limits the fonts that can be used quite a bit.
That said, I understand the inability to select language mode for CJK fonts outside of changing the UI language is a very niche issue that doesn't affect a lot of people.  So I fully understand if it's not a priority to fix it now or in the foreseeable future, or if you think it would be better fixed within Electron or as part of an extension.
Thanks again.

I think this is a Chrome issue, and probably impossible to fix:

Namely, when you don't specify a lang attribute and no specific CJK fallback, Chrome does its best to guess, and prioritize the Chinese font before Japanese ones.

It is possible to choose which version to display in Chrome, but it's easy to miss because Chrome maintains its own language list within the "Advanced" part of the browser settings rather than looking at OS settings.
To change characters to Japanese form in Chrome:

Go to Settings
Expand Advanced
Select Languages
Click the arrow icon to the right of English
Click Add languages
Check Japanese in the language list.
Click Add

Now refresh this page and look at this post.  You will see that the form of these characters changes:
誤直
Opera works similarly, and it seems Chromium Edge might as well.
I think one way to support it in VS Code would be to add a setting that lets the user input a list of comma-separated languages.  I've not worked with Electron, but ses.setUserAgent looks promising.
Another way might be to allow the user to type a value that will be added as a lang attribute to editor and console windows.

@dbaeumer fyi. the ask is to use setUserAgent to customize language precedences, so Japanese can come before Chinese

This is not translation related. Assigning to @bpasero and @alexandrudima.

@dbaeumer IMHO this is somewhat related to nls... I think it appears when the user configures the display language of VS Code, this information is not further configured onto Electron using the setUserAgent call.
Configuring the accepted language to Electron influences the following:

xhr requests done via Chromium's networks stack (the Accept-Language header)
apparently, (I was not aware of this) font face selection when Chromium is doing font rendering

I don't think this is an editor specific issue, because font face selection is the same in all input boxes in the workbench, so the <input> in the search viewlet, or the terminal will suffer from the same.

Up for grab.

There are the font-variant property in CSS which controls alternate glyphs.
Maybe allowing users to configure this property in appropriate place is enough.
https://developer.mozilla.org/ja/docs/Web/CSS/font-variant

Doesn't seem to repro anymore. Maybe this get fixed with latest Electron/Chrome update?
Can someone confirm that in https://code.visualstudio.com/insiders/?

I checked that I have the latest released update, and it does not seem to have been fixed.
My guess would be that you have Meiryo or another similar font in your Editor:Font Family setting.  The Meiryo font only contains Japanese forms, so it will never show the Chinese form.
However, if you remove Meiryo, or specifically specify any font that supports both Japanese and Chinese, like the Hanazono fonts, you will then see the Chinese form unless the UI language is Japanese.
Using Meiryo or other similar Japanese-only fonts was the work-around suggested earlier, but of course this means many other fonts can't be used.

We closed this issue because we don't plan to address it in the foreseeable future. If you disagree and feel that this issue is crucial: we are happy to listen and to reconsider.
If you wonder what we are up to, please see our roadmap and issue reporting guidelines.
Thanks for your understanding, and happy coding!

This is still an issue. As explained, if the chosen font supports all the CJK languages, then it will just do chinese if the  vscode display language is not set to japanese.


'str' object has no attribute 'decode' in shorten_word from filter_utiles.py

hi,
am trying to convert your code to python 3.7, would you provide a version of shorten_word from filter_utils.py for python 3 since decode() is not supported for str please.

It sounds great that you're trying to convert the code to Python 3. You can see this StackOverflow answer on how you'd do it in Python 3.
It'd be awesome if you submit a PR with your Python 3 version!


Rename for Data Relay in README and docs

This PR converts use of "cloud" to name or describe the block to use "data relay". This PR includes changes to the README and landr docs.

@balena-ci I self-certify!


fix: removed unhandled metadata from extension data

Description
Removes some unhandled metadata in the extension data for one of the tokens.
Motivation and context

Related issue

Types of changes

[ ] Patch (bug fixes, typos, mistakes; non-breaking change which fixes an issue)
[ ] Minor (add a new token, changing a value; non-breaking change which adds functionality)
[ ] Major (deleting a token, changing token value type; fix or feature that would cause existing functionality to change)

Checklist:

[ ] I have signed the Adobe Open Source CLA.
[ ] I updated the token in all applicable sets. This applies if updating, adding, or deleting a token that has data across different sets (for example, if the value differs across color themes.)

@mrcjhicks Hi, since the spectrum colors are live in Figma, we need to remove the full token from the data set and sync with the figma libraries. If we change the metadata here, it will appear as a change in figma and confuse the designers. Sorry. I will start the process with them.

I think the token itself is supposed to be deprecated, so it can probably wait until that gets resolved.


Single digit multiplication with addition

The unsigned single digit multiplication algorithm can perform one addition for free, so I should probably expose that. I'm unsure about the semantics of the signed version, however, and whether it depends on the representation used. Given a path via the magnitude, it's possible to expose some kind of arcane incrementMagnitudeBy: parameter but I'm not thrilled by it.
// extension NBKDoubleWidth where High == High.Magnitude

mutating func multiply(by other: Digit, add carry: Digit)
func multiplied(by other: Digit, adding carry: Digit) -> Self

mutating func multiplyReportingOverflow(by other: Digit, add carry: Digit) -> Bool
func multipliedReportingOverflow(by other: Digit, adding carry: Digit) -> PVO<Self>

mutating func multiplyFullWidth(by other: Digit, add carry: Digit) -> Digit
func multipliedFullWidth(by other: Digit, adding carry: Digit) -> HL<Digit, Magnitude>

On a side note: I’m adding algorithms like these as free generic functions, so I’m not chained to any particular model.


Skip invalid data instead of exiting completely v2

Hello guys!
I was about to make a pull request exactly the same as #41, so I read the discussion and modified the existing code of @basememara, but following other approach to arrive to the same goal.
(I am kind of newbie to this PR staff, I think this is the proper way of modifying an existing PR, otherwise tell me please how to proceed)
The main change of this PR is done in https://github.com/JohnSundell/Unbox/pull/46/commits/fb9539b096a5f8521ddd2542d4766da2aa4189f4, the other changes are to separate public API from logic, update tests and more.
Check it please.

Hi @acecilia, thx for kick starting this again. Nice touches, like the shortened names and removing the unnecessary returns in the maps.
Also, I see you removed the allowInvalidElements parameter. So am I correct in understanding that it is skipping invalid data by just inferring it instead of an explicit parameter? So to return an empty result if something fails you'd do let items2: [Model]? = Unbox(data), and to just skip invalid and return what's good you'd do let items: [Model] = Unbox(data)?
If that's the case, I think that's really clean; leveraging inference over extra parameters 👍. Maybe too much to imply, but I still think it's really elegant. What do you think @JohnSundell?

Yes @basememara , that's the idea

Hey @acecilia and @basememara! Thank you so much for your work on this, and I'm sorry I've been super slow with responding - have been traveling and working like crazy this month :) Will take a look at this over the weekend, promise! 👍

Not so sure about modifying the behavior of unboxing an array, since it can have side effects. For example; if my program depends on complete backend data (in the form of an array), then with this change there would be no way to express that (right?). I think the approach with an explicit parameter both makes the programmer's intent more clear, and also makes the API more expressive. What do you guys think @acecilia, @basememara?

I believe I see @JohnSundell's concern, you don't want to "break" any existing API's. Actually breaking an API would be better, what we're discussing here is changing the implicit behavior.
Everyone doing let items: [Model] = Unbox(data) all of a sudden get data returned with this update, whereas before they were getting all or nothing. This can cause dangerous issues with those already using the API as it was understood before. Because of this, I'm agreeing with John about the explicit parameter or at least another API call for this.

Just an extra comment, if getting data back was that dangerous before for someone, they should've used UnboxOrThrow. Still though, changing implicit behavior is never good unless everyone using it is notified or some kind of compiler warning.

I still like @acecilia's implementation because it's not invasive on the source code. So instead, the explicit parameter can stay on the surface while retaining previous behavior, maybe something like from this:
    static func unbox<T: Unboxable>(dictionaries: [UnboxableDictionary], context: Any? = nil) -> [T]? {
        return try? Unboxer.unboxOrThrow(dictionaries, context: context)
    }

    static func unbox<T: Unboxable>(dictionaries: [UnboxableDictionary], context: Any? = nil) -> [T] {
        return dictionaries.flatMap { unbox($0, context: context) }
    }

To this:
    static func unbox<T: Unboxable>(dictionaries: [UnboxableDictionary], context: Any? = nil, allowInvalidElements: Bool = false) -> [T]? {
        return allowInvalidElements
             ? dictionaries.flatMap { unbox($0, context: context) }
             : try? Unboxer.unboxOrThrow(dictionaries, context: context)
    }

It's the best of both worlds: least changes to source code and backwards-compatibility. Juggling/forking multiple PR's against each other wasn't so obvious like @acecilia mentioned, so sorry but I updated it on the other pull request with this change: https://github.com/JohnSundell/Unbox/pull/41
However, there's one catch so far that we'll need to iron out, it has to be used like below as of now blagggghhh, but maybe a good milestone to start from tho:
let items: [Model] = Unbox(data, allowInvalidElements: true) ?? []

@basememara I do not really see the problem, before this PR, doing let items: [Model] = Unbox(data) was causing a compile error:

So it is not changing the behavior. To get an unwrapped array the developer has to unwrap it after using the Unbox() function.
And if someone is doing if let items: [Model] = Unbox(data) {} I think that still works the same as before with this PR: only gets into the if when all the elements in the array are properly unboxed (compiler still calls the Unbox() function with an optional return parameter, not changing the behavior)
Right?  I understand that adding a parameter is easier to follow, but if we are returning an array with failable elements there is no sense to return an optional (in case we finally implement an Unbox() function with a parameter and returning an optional value), and I think using it this way makes sense.

Hmmm you're right! This never worked before: let items: [Model] = Unbox(data)
@JohnSundell can you elaborate on your concern? @acecilia's change wouldn't break any previous behaviors and the inference seems more concise.

Sorry if my first comment wasn't very clear - indeed I meant arrays of dictionaries when I said "backend data". While I really like using type inference to also infer behavior, I feel like in this case it can become a bit ambigious. There are really four cases here;

I want only a complete array, and it's required - if an element failed to unbox - fail the whole process.
I want only a complete array, and it's optional - if an element failed to unbox - return nil.
I'm fine with a partial array, if an element failed to unbox - skip it.

The forth case can only occur if the array is nested in another structure;

I'm fine with a partial array, as long as it's an array, and if an element failed to unbox - skip it.

I took the liberty of writing an implementation myself (V3) :) that uses an explicit parameter (that defaults to false to be consistent with the current behavior) - and has less impact on the code base thanks to the use of an Array extension; what do you guys think? https://github.com/JohnSundell/Unbox/pull/50

Perfect, like it

@acecilia Awesome :) Thanks so much to both you and @basememara for your work on this 🙇

I really like it too, nice to use an array extension to put that logic. Glad we can help, thx for an awesome library and being open to our suggestions :)

@basememara Of course, your awesome suggestions is what made this happen! 👍

And if you have any other improvement suggestions or changes you'd like to make, please keep the PRs coming! 🚀


Fixing issue when using "traditional" path notation

Relation issues: #194, #188 and PR #193

@danrot can you verify that this fixes the issues?
I guess it would be good to have a test case to catch such a regression in the future.

@lsmith77 Yeah, fixes the issue :-) Thenks @emulienfou for fixing!


tls flag

The --tls command line option is missing from version 1.0.0 and 1.0.1.
Console error message when the --tls option is set:

Incorrect Usage. flag provided but not defined: -tls

The flag was present in version 0.5.0. It should be added back or the documentation (README.md) changed accordingly.

Duplicate of #583
Attention to the order of the arguments:

INVALID

# INVALID
./lego run --tls ":80" -m foo@barcom

VALID

# VALID
./lego --tls ":80" -m foo@barcom run


Scope api in a Csv object

Dependencies

[ ] #26

Checklist

[ ] Implement.
[ ] Test.
[ ] Refactor.
[ ] Update Work in progress section in changelog.

Useless for the moment.


addon metrics-server is enabled but kubectl top pods fails with: "Metrics API not available"

Summary

addon metrics-server is enabled but kubectl top pods fails with: "Metrics API not available"
What Should Happen Instead?

kubectl top pods should show the top summary for pods
Reproduction Steps

microk8s enable metrics-server
kubectl top pods
Introspection Report
may be available on request
n9  Report tarball is at /var/snap/microk8s/5650/inspection-report-20230901_185652.tar.gz
Can you suggest a fix?
do not yet
Are you interested in contributing with a fix?
yes

Sep 05 08:41:09 node3 microk8s.daemon-kubelite[24517]: E0905 08:41:09.698781   24517 available_controller.go:460] v1beta1.metrics.k8s.io failed with: failing or missing response from https://<IP_ADDRESS>:443/apis/metrics.k8s.io/v1beta1: Get "https://<IP_ADDRESS>:443/apis/metrics.k8s.io/v1beta1": dial tcp <IP_ADDRESS>:443: connect: connection refused
Sep 05 08:41:09 node3 microk8s.daemon-kubelite[24517]: W0905 08:41:09.702665   24517 handler_proxy.go:93] no RequestInfo found in the context
Sep 05 08:41:09 node3 microk8s.daemon-kubelite[24517]: E0905 08:41:09.702872   24517 controller.go:143] Error updating APIService "v1beta1.metrics.k8s.io" with err: failed to download v1beta1.metrics.k8s.io: failed to retrieve openAPI spec, http error: ResponseCode: 503, Body: service unavailable
Sep 05 08:41:09 node3 microk8s.daemon-kubelite[24517]: , Header: map[Content-Type:[text/plain; charset=utf-8] X-Content-Type-Options:[nosniff]]
Sep 05 08:41:10 node3 systemd[1]: run-containerd-runc-k8s.io-4c270781caea950e384f4c8f1dd83bb21dc540b00e99d6eb91249cd579d1d89a-runc.q6g7Fd.mount: Deactivated successfully.

Hi @karawitan, sorry for the delay.
This typically means that kube-apiserver cannot reach the metrics-server service/pod to return the metrics.
Is there an http proxy in the environment? Can you try curl https://<IP_ADDRESS>:443/ -v from the node where microk8s (the kube-apiserver) is running?


SignatureDoesNotMatch

I've not changed any of my code, so maybe Amazon has changed something, anyway now I get the error code SignatureDoesNotMatch whenever I make a request via createProdAdvClient. :/
Not sure if this library is maintained anymore, judging by the lack of response to other issues.
Is anyone alive out there? :(

I had the same issue with this library, this is a quick fix.
In lib/aws.js replace
    for(var n in keys) {
      var key = keys[n]
      sorted[key] = query[key]
    }

with
    for (var i=0; i<keys.length; i++) {
      var key = keys[i];
      sorted[key] = query[key];
    }


Error: 404

Unexpected server response: 404
I'm running v4 Lavalink, and wrote exact certification, but code says it cannot connect to lavalink.

Unexpected server response: 404
I'm running v4 Lavalink, and wrote exact certification, but code says it cannot connect to lavalink.

Update shoukaku with "npm i github:Deivu/Shoukaku" (Make sure u have git installed in ur server)

Ah shoukaku package on npm is still v3?

Oh no I think that's right sorry guys

I lock the npm version with the same version what lavalink considers as stable, until lavalink says v4 api is stable, shoukaku's v4 support will not be released in the stable channel

I see, thank you so much all guys


switched to lerna

This supersedes #283
Sets up lerna and makes lodestar the only package

I would move eslint to root to enforce style on all packages.
Reference implementation: https://github.com/typescript-eslint/typescript-eslint
We can do this is subsequent PR


Some inventory commands teleport the mouse on Mac OS X

The move single item (default ctrl + click), move all of type (default ctrl + shift + click), move forward / back (default w/s + click), drop item (default alt/option + click) and possibly a few more shortcuts teleport the mouse vertically across the center of the minecraft window when you use them.  This doesn't happen in windows, only mac (I haven't tested on linux).

Confirmed this is still happening (v1.59-dev-152 on Yosimite 10.10.2)

I don't think there's much anything I can do about it, I've checked a few times and all it's doing is recording the current location and then re-setting it because there's a minor glitch when trying to suppress mouse events.
Since it's setting it to the same coordinates that LWJGL told us it was at, any mismatch is almost certainly in their code.


Review bot

Is your feature request related to a problem?
Sometimes it happens that PRs are open without any requested reviewer
Describe the solution you would like
I would like to see some sort of bot or github action that will asign randomly (pseudo-random, or based on some metric).
It just need to check that PR author != requested reviewer
Describe alternatives you have considered
The alternative is that people who open PRs will ask for a review.
People that are good candidates for making reviews (in alphabetical order):

@kkukelka
@roiLeo
@vikiival

I also believe that @prachi00 is pretty familiar with the codebase already (as she is leading the payout chart)
Screeenshots

ht/ to @yangwao for the idea

@vikiival
https://docs.github.com/en/organizations/organizing-members-into-teams/managing-code-review-settings-for-your-team#about-auto-assignment
wouldnt something like this work?

@vikiival docs.github.com/en/organizations/organizing-members-into-teams/managing-code-review-settings-for-your-team#about-auto-assignment wouldnt something like this work?

you are sweet! I remembered that I've seen it somewhere already as native but could not find it lol 🫣😅
Thank you will look on it!

Let's go with round robin and then let's see!

The round robin algorithm chooses reviewers based on who's received the least recent review request, focusing on alternating between all members of the team regardless of the number of outstanding reviews they currently have.

The load balance algorithm chooses reviewers based on each member's total number of recent review requests and considers the number of outstanding reviews for each member. The load balance algorithm tries to ensure that each team member reviews an equal number of pull requests in any 30 day period.

okay it's up https://github.com/orgs/kodadot/teams/code-review-guild/members just wait to accept invites :)

okay it's up

Perfect!

maybe now as probably need add this team

oh, that's.. when team of reviewers is requested and then it's load balanced.

hmm https://github.blog/changelog/2021-09-29-new-code-review-assignment-settings-and-team-filtering-improvements/

So we need still something like gh action which adds kodadot guild as a reviewer on opened PR :)

yeah technically speaking it does work...but requires trigger but on last link I posted should be working without it

should be working without it

Worst case we will convince it :)

atlesat i know it was paid service by pullpanda https://pullpanda.com/assigner that what's under hood by GH

learning https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/about-code-owners

oooh, maybe permissions were issues all time from start lol

yas

cherry on top

🍒 🍒 🍒 🍒 🍒 🍒


Add kill-port as a dependency and use it to stop server

On desktop app quit kill the backend server port
Testing done
Yes

I check whether this assumption (that only the quit happens when quitting the app, and not the windows-all-closed) would happen on Linux too and indeed it does! So the fix for this issue should be adding the on('quit' and kill the server process in there.


[Bug] windows tvm compile onnx modlel error

[10:50:54] D:\a\package\package\tvm\src\node\reflection.cc:109: AttributeError: Op object has no attributed span
Stack trace not available when DMLC_LOG_STACK_TRACE is disabled at compile time.
operating system:
windows 10 21h2

No possible action from our side.


feat : Add positive and negative trait impl tests for SIMD types #130

Hey, this is my first open-source contribution. I have added the tests as instructed to the best of my knowledge. Please do suggest changes to it if you find something wrong.

@jswrenn , I have made the changes and all the CLI checks are passing. Can you please review it once.

@joshlf, it seems that the merge did not happen.

@joshlf, it seems that the merge did not happen.

This is failing due to an unrelated error: https://github.com/rust-lang/miri/issues/3125. I'll merge manually.


Add Reminders in React

Fixes #2247
https://user-images.githubusercontent.com/8245654/114980981-e8112a00-9eaa-11eb-8b77-c1b12c946391.mp4
If reminder created in Django, it will appear as "untitled reminder" in react
https://user-images.githubusercontent.com/8245654/114981056-024b0800-9eab-11eb-9dbf-63f034438df8.mp4

@frjo Going the requirements of the feature and it seems that we can skip the suggested assign field for now. As not sure how it will be used. Currently, we have an action field that helps to pick the reminder purpose. So, for now, we can replicate the Reminder feature from Django in React app + new fields like Title, description added to both + some other improvements. Sounds ok?

@frjo Now we have title and description for a reminder, Do you add this information in reminder e-mail?

@vimal1083 It would be good to have the new info in email as well.

@frjo We can deploy it to test.

@frjo yeah, updated in React

Codecov Report

Merging #2334 (fab687c) into main (3a4baac) will decrease coverage by 0.03%.
The diff coverage is 69.64%.

@@            Coverage Diff             @@
##             main    #2334      +/-   ##
==========================================
- Coverage   81.84%   81.81%   -0.04%
==========================================
  Files         614      617       +3
  Lines       22126    22180      +54
==========================================
+ Hits        18110    18147      +37
- Misses       4016     4033      +17

Impacted Files
Coverage Δ

hypha/apply/api/v1/reminder/serializers.py
61.53% <61.53%> (ø)

hypha/apply/api/v1/reminder/views.py
65.38% <65.38%> (ø)

hypha/apply/funds/models/reminders.py
89.18% <66.66%> (-7.24%)
:arrow_down:

hypha/apply/api/v1/urls.py
100.00% <100.00%> (ø)

hypha/apply/funds/forms.py
87.87% <100.00%> (ø)

.../apply/funds/migrations/0088_auto_20210423_1257.py
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3a4baac...fab687c. Read the comment docs.


V/OCT latency when using external envelope.

I'm seeing very long (~35ms) latency when using The Centre purely as an oscillator, triggering via an external envelope.
My setup is as follows:

NiftyCASE MIDI interface taking MIDI input from an external keyboard
The Centre, with a simple patch (same effect with either wavetable or VCO) using V/OCT1 input to control pitch (from MIDI CV1) and sending output to VOUT1
PipSlope triggering a short-attack short-delay gated envelope from MIDI GATE1 (so effectively 'on' when a key is pressed)
VOUT1 going via a 2hp VCA modulated using the output of PipSlope

The effect is that the note is 'on' precisely when I press the key, but the pitch changes are always noticeably late. I've attached a .wav file (in a zip file) showing the effect.
3-Audio_0001_2021-10-10_124957.zip
If I use the internal envelope generator/VCA (e.g. using the 'Simple Preset WTO + ENV + VCA' patch from the discord) with MIDI CV1 into V/OCT1 and MIDI GATE1 into CVY1 I don't hear the problem (which might imply that the CVY inputs have the same latency response as the V/OCT ones).
Ideally I wouldn't be able to hear any delayed note change when using The Centre as an oscillator with an external envelope: that's my main use case, really: I'm interested in the oscillator editing capabilities but less on constructing complex internal patches using the internal envelopes. It is possible to delay external envelopes by a certain amount but that requires extra modules and I'd rather not have to go down that route if I can help it.

I've just had a play and can confirm that setting 'Exp CV Scan' to On helps things a lot. It's still not quite perfect: with notes spaced far apart there seems to be almost a fast slide between them, but things are a lot better. I couldn't detect any difference when I fiddled with any of the other three parameters. I'll do some more checking later on.

I am experiencing similar problems, but with a different midi to cv interface. (Erica Synths) I wonder how fast the midi to cv conversion is, trying a voltage meter on my converter does show a noticable short delay as the voltage ramps up, but some of this delay may be due to the meter display lag. I'll try it with an oscilloscope and report back.

@duddie: OK, I've tried all of these. I couldn't tell any difference between 1, 2, and 3 (they all sound pretty good, with an audible but tiny latency), or between 4 and 5 (which both exhibit the original problem).
One thing I did notice is that if I do a test with the pitch bend wheel on my keyboard, I only get the semitones (and the same happens if I put e.g. Maths channel 3 into V/OCT and turn the knob slowly). Is the V/OCT input quantising the signal? Can that be turned off, if we want properly swoopy patches, and could that be interfering with this latency issue?
@thegreenalien: my MIDI interface doesn't have a glide feature; the issue I was having wasn't to do with a slow change in V/OCT level, it was because The Centre is reacting late to an instantaneous change in V/OCT level. When I use other (digital) oscillator modules (e.g. Plaits, or a Disting) in the same way, there's no latency.

Yes, The Centre quantises everything because of this issue. It's a hardware limitation that I mentioned earlier - very noisy ADC. So the solution is to accept that the pitch control will be gliding and shaking before it stabilises because of the noise.
Other solution that in my opinion is better is to add Frequency Fine / Frequency Coarse control to WTO/VCO like LFO and use CV input.
Maybe let's have proper discussion about it

This is interesting. I havent played with external envelopes with the Centre yet. I am going to give this a try.
I will try this out with my  Expert Sleepers FH-2 as my MIDI input to CV out, an Joranalogue Contour 1 for envelope, and i too have a 2HP VCA.

Okay, so in 'The Centre' version 0.73.38 i couldnt discern a noticeable difference in lag when I tried this.
Was this corrected in version 0.73.38?
Midi keyboard into FH-2 via USB
FH-2 pitch into the centre (simple patch, 1x WTO into outs) via V/OCT 1
FH-2 gate into Joranalogue Contour 1, Fast attack, semi-fast decay envelope trigger
Joranalogue Envelope out into 2hp VCA CV input
The Centre Audio out into 2hp VCA CV input.

No, there are two problems:

This chip adds a lot of noise when the driver for LCD does updates. The ADC (analog to digital converters) are very noisy at this time. Since the update takes like 11 ms I have to alternate reading ADC and Screen updates. That's the lag introduced there. I can make a version with ability to turn off screen and test it but that is not a solution. The better solution is to interleave screen updates into a slices, but it's a bigger rework that I can do maybe next month (unless this is a bigger problem and needs urgent action)
Those ADCs are noisy anyway by themselves so I am applying certain 1-pole filtering there and it adds this particular glide. This would not be a problem if the screen updates were not delaying it. So if I can fix screen updating mechanism I should eliminate rest of the lag.

@rockstarartist: your setup sounds functionally identical to mine, but I was definitely seeing a lag with that that I didn't see when I put the MIDI pitch into different oscillator modules: I don't have a Mordax (on my xmas list...) so I don't have a trace, but I put the audio clip of the effect on the issue.
The new settings that made it much better for me were added in 0.74.11 (with the third 'Settings' item in the system menu), so if you're before that version I guess you're just not seeing the problem at all. @duddie, could the latency be hardware-specific? I know you said you weren't very impressed with the noisy ADC: could some hardware produce worse delays?
In fact, having experimented with some of the internal envelopes, I can still detect a little latency even if it's using its own envelope to trigger from (i.e. taking a gate input on CVY1 to trigger an internal envelope for an oscillator coming in on V/OCT1).

Ah interesting, so you are saying, given two or more WTO modules in the centre, reading from the same pitch source you are getting that variance as shown in your audio file? I was only testing with one WTO module. I'll give it a try tonight. I am on a later version now though, so I am guessing my experience will be different if there have been corrections already in place.


Fix for TRANSFER transactions

This changeset proposes a change that fixes and closes #2. There was an error made writing the code that serializes a transaction. As a result, it always sets the operation to CREATE instead of allowing
it to be set to TRANSFER.
@NikitaLos originally filed the bug but we fixed it before noticing his issue.
Additionally, a fix for #3 has been applied, by applying an @Ignore to the failing test, so the build will pass for now.
In my case, I was missing Jadler (so I filed #11), and this consequently fixes and closes #11 as well.
To sum up:

[x] Fixes and closes #11 (Jadler test dependency missing)
[x] Fixes and closes #3 (mvn clean install failing due to failing tests)
[x] Fixes and closes #2 (Transaction operation issue)

@sgammon - Thanks for fixing all those open issues!
Before we can merge this pull request, we need you or your organization to agree to one of our contributor agreements. One of the big concerns for people using and developing open source software is that someone who contributed to the code might claim the code infringes on their copyright or patent. To guard against this, we ask all our contributors to sign a Contributor License Agreement. This gives us the right to use the code contributed and any patents the contribution relies on. It also gives us and our users comfort that they won't be sued for using open source software. We know it's a hassle, but it makes the project more reliable in the long run. Thank you for your understanding and your contribution!
If you are contributing on behalf of yourself (and not on behalf of your employer or another organization you are part of) then you should:

Go to: https://www.bigchaindb.com/cla/
Read the Individual Contributor Agreement
Fill in the form "For Individuals"
Check the box to agree
Click the SEND button

If you're contributing as an employee, and/or you want all employees of your employing organization to be covered by our contributor agreement, then someone in your organization with the authority to enter agreements on behalf of all employees must do the following:

Go to: https://www.bigchaindb.com/cla/
Read the Entity Contributor Agreement
Fill in the form "For Organizations”
Check the box to agree
Click the SEND button

We will email you (or your employer) with further instructions.

@sgammon Another contributor made a pull request to add the ability to make TRANSFER transactions, and apparently they made some additional changes that you didn't make. Please take a look at what they wrote in the comments about pull request https://github.com/bigchaindb/java-bigchaindb-driver/pull/13#issuecomment-413129409 .

@ttmc I have changes in my branch that fix the issues mentioned by @NikitaLos, but, I didn't push them because I figured they were too much to propose. glad he is fixing them, I'm happy to add those changes to this PR if that is preferred

@ttmc @innoprenuer I have signed the CLA, as Bloombox LLC (organization CLA)

@sgammon I got the email about you (or your employer) agreeing to the Entity CLA, and I sent an email with the last step (to copy a block of text to the comments on this pull request).

hey there @ttmc, I responded to the email. and here is the requested text :)
This is to confirm that I agreed to and accepted the BigchainDB Entity Contributor Agreement at https://www.bigchaindb.com/cla/ and to represent and warrant that I have authority to do so.

deEYFdl45wXiDgoq9yKovBE7M8bGCALnQs6gUfJPGaWggEQrh9197GL0hB43H7d

by the way @ttmc, I fixed the other issues w/serialization mentioned by @NikitaLos in a PR that supersedes this one (at #14)

@sgammon Thanks, the process to agree to the CLA is complete.
@innoprenuer The CLA is no longer a blocker to merging PRs by @sgammon

I was able to fix CI with a few changes. comments will be in #14

@sgammon Thanks for contributing. I got caught up today but will review it asap and merge it.


Document health check buildpack usage on Paketo web site

Describe the Enhancement
There is no documentation on paketo.io/docs for using the Health Checker buildpack. Add documentation for usage with pack, Spring Boot build tools, docker run and Docker Compose.
Motivation
It helps to know how to use the buildpack 😀

any update on this?
I'm trying to use healtcheck in a spring boot app but I didn't find any official resource that describe how to do it.
This is my gradle configuration
buildpacks = listOf(
    "gcr.io/paketo-buildpacks/java:latest",
    "gcr.io/paketo-buildpacks/health-checker:latest",
)
environment = mapOf(
    "BP_HEALTH_CHECKER_ENABLED" to "true"
)

Docker compose
healthcheck:
    test: [ "CMD", "/cnb/process/health-check" ]
    interval: 3s
    retries: 10
    start_period: 10s
    timeout: 180s

but then I get this error in the healtcheck logs of my container

{
   "Start": "2024-10-25T19:50:37.999496253Z",
   "End": "2024-10-25T19:50:38.06885967Z",
   "ExitCode": -1,
   "Output": "OCI runtime exec failed: exec failed: unable to start container process: exec: \"/cnb/process/health-check\": stat /cnb/process/health-check: no such file or directory: unknown"
},

There is really no documentation on how to do it properly

There are instructions https://stackoverflow.com/a/75899112/1585136, but I do still want to add this to the Paketo documentation. I apologize, but haven't gotten time to do it.


Creating entity POJO ?

Hello
I wanted to know if there is a way to create Java entity pojo class using tables or views?
Thanks

@shortduck sorry, but no way doing this in DBeaver.


Scope support

this PR is only for checking the system test, changes are needed here! not for review yet!

this PR is ready for review!

/describe