Actor-critic model with LSTM layers runs out of GPU memory eventhough it shouldn't.

Custom code
Windows 10
TensorFlow version: 2.3.1
Python version: 3.7.9
CUDA/cuDNN version: 10.1 / 7.6.5
GPU model and memory: GTX 1660 6GB

Networks with LSTM layers run out of memory, using only batch at a time. Creating smaller layers don't help.By my calculations they should easily fit into the memory.
Source code to recreate the issue is the following (in a few places it uses bogus values, it was only created to test if there are issues with the fit function):
`
import os
import numpy as np
import tensorflow as tf
from tensorflow.keras.layers     import LSTM, Dense, Dropout, Input, concatenate, Lambda
from tensorflow.keras            import activations
from tensorflow.keras.optimizers import Adam
from tensorflow.keras.models     import Model
import tensorflow.keras.backend as K
physical_devices = tf.config.experimental.list_physical_devices('GPU')
tf.config.experimental.set_memory_growth(physical_devices[0], enable=True)
delta = Input(shape=[1])
input_vision = Input(shape=(2* 5+1,2* 5+1))
first_branch = LSTM(1024)(input_vision)#Input layer of the 1. branch
first_branch = Dropout(0.2)(first_branch)       #Dropout for the input layer
first_branch = Dense(512, activation=activations.relu)(first_branch)       #First layer of the 1. branch
first_branch = Dropout(0.2)(first_branch)
first_branch = Dense(256, activation=activations.relu)(first_branch)       #Second layer of the 1. branch
first_branch = Dropout(0.2)(first_branch)
first_branch = Model(inputs=input_vision, outputs=first_branch)      #The output of the first branch
input_memory  = Input(shape=(100,3))
second_branch = LSTM(1024)(input_memory)       #Input layer of the 2. branch
second_branch = Dropout(0.2)(second_branch)     #Dropout for the input layer
second_branch = Dense(512, activation=activations.relu)(second_branch)     #Second layer of the 2. branch
second_branch = Dropout(0.2)(second_branch)     #Dropout for the first layer
second_branch = Dense(256, activation=activations.relu)(second_branch)     #Third layer of the 2. branch
second_branch = Dropout(0.2)(second_branch)     #Dropout for the first layer
second_branch = Model(inputs=input_memory, outputs=second_branch)    #The output of the first branch
input_task   = Input(shape=(5, 6) )
third_branch = LSTM(1024)(input_task)    #Input layer of the 3. branch
third_branch = Dropout(0.2)(third_branch)       #Dropout for the input layer
third_branch = Dense(512, activation=activations.relu)(third_branch) #Second layer of the 3. branch
third_branch = Dropout(0.2)(third_branch)       #Dropout for the first layer
third_branch = Dense(256, activation=activations.relu)(third_branch) #Third layer of the 3. branch
third_branch = Dropout(0.2)(third_branch)       #Dropout for the first layer
third_branch = Model(inputs=input_task, outputs=third_branch)#The output of the first branch
#Combine all 3 branches into one:
#combined = tf.keras.backend.expand_dims(combined, axis=-1)
combined = concatenate([first_branch.output, second_branch.output, third_branch.output])
combined = Lambda(lambda x: tf.keras.backend.expand_dims(x, axis=-1))(combined)
#Main branch:
main = LSTM(1024)(combined)       #The 1. layer of the main branch
main = Dropout(0.2)(main)
main = Dense(512, activation=activations.relu)(main)  #The 2. layer of the main branch
main = Dropout(0.2)(main)
main = Dense(256, activation=activations.relu)(main)  #The 3. layer of the main branch
main = Dropout(0.2)(main)
#------------------------------------------------These are the outputs of the  models------------------------------------------------
#This is the output of the critic model. The input is one because we just want the value of 1 action, which was taken by the actor.
values = Dense(1, activation=activations.linear)(main)
#This is the output of the actor model. We get the probabilities of each action, that is why softmax needed.
probabilities = Dense(32, activation=activations.softmax)(main)
#This is the policy network needed to connect the actor and the critic:
#y_true is an action that the actor took, and y_pred the probability of that action
def custom_logLikelihood(y_true, y_pred):
out     = K.clip(y_pred, 1e-8, 1-1e-8) #Clip the prediction so it can not be 0 or 1.
log_lik = y_true * K.log(out)
 return K.sum(-log_lik * delta)

#------------------------------------------------These are the  models------------------------------------------------
actor = Model(inputs=[first_branch.input, second_branch.input, third_branch.input, delta], outputs=probabilities)
actor.compile(loss=custom_logLikelihood, optimizer=Adam(lr=0.0001), experimental_run_tf_function=False)
tf.config.experimental_run_functions_eagerly(True)
critic = Model(inputs=[first_branch.input, second_branch.input, third_branch.input], outputs=values)
critic.compile(loss="mse", optimizer=Adam(lr=0.0005))
prev_state_vis=np.random.randint(0, 20, size=(11,11))
prev_state_mem=np.random.randint(0, 20, size=(100,3))
prev_state_task=np.random.randint(0, 20, size=(5,6))
curr_state_vis=np.random.randint(0, 20, size=(11,11))
curr_state_mem=np.random.randint(0, 20, size=(100,3))
curr_state_task=np.random.randint(0, 20, size=(5,6))
prev_state_v = prev_state_vis[np.newaxis, :]
prev_state_m = prev_state_mem[np.newaxis, :]
prev_state_t = prev_state_task[np.newaxis, :]
curr_state_v = curr_state_vis[np.newaxis, :]
curr_state_m = curr_state_mem[np.newaxis, :]
curr_state_t = curr_state_task[np.newaxis, :]
critic_value_prev = critic.predict_on_batch([prev_state_v,
prev_state_m,
prev_state_t])
critic_value_curr = critic.predict_on_batch([curr_state_v,
curr_state_m,
curr_state_t])
target  = 10 + 0.99 * critic_value_curr * (1-int(0))
d   = target - critic_value_prev
actions = np.zeros([1, 32])
actions[np.arange(1), 0] = 1.0
for i in range(0,500*100):
print(i)
actor.fit(x=[prev_state_v, prev_state_m, prev_state_t, d], y=actions, verbose=0)
critic.fit(x=[prev_state_v, prev_state_m, prev_state_t], y=target, verbose=0)
`

I have tried in colab with TF version 2.3. Please, find the gist here.You are also seeing the same behavior?
Thanks!

The fit of the actor and critic is in the for loop, and for me fails after about 30 iterations.

I have tried in colab with TF version 2.3. Please, find the gist here.You are also seeing the same behavior?
Thanks!

I have tried in colab with TF version 2.3. Please, find the gist here.You are also seeing the same behavior?
Thanks!

The fit of the actor and critic is in the for loop and for me fails after about 30 iterations.

@mbalazs98
Please, share the log of the error if any.Also, try setting hard limit on GPU as shown in this guide.Thanks!

@mbalazs98
Please, share the log of the error if any.Also, try setting hard limit on GPU as shown in this guide.Thanks!

I forgot to mention that I already tried hard limiting the memory usage, it didn't help. The error message is the following:
InternalError: Failed to call ThenRnnBackward with model config: [rnn_mode, rnn_input_mode, rnn_direction_mode]: 2, 0, 0 , [num_layers, input_size, num_units, dir_count, max_seq_length, batch_size, cell_num_units]: [1, 1, 1024, 1, 768, 1, 1024]  [Op:CudnnRNNBackprop]

@mbalazs98
Can you please refer similar issue #41444, #37942 and see if it helps you. Thanks!

@mbalazs98
Can you please refer similar issue #41444, #37942 and see if it helps you. Thanks!

#41444 doesn't seem to be the issue, since that is windows related and this code fails on colab also. I tried every suggestion already given in #37942 but the results didn't change. Also, I think that it is not related to the batches since these networks are given only one batch in an iteration.

@mbalazs98 model.fit manages its own tf.function and runs training in graph mode for faster computations. When you run model.fit in a for-loop and provide numpy inputs (which is considered as different input signature each iteration in for-loop), each graph is traced separately and there will be n number of models in the memory and consume lot of memory. You can garbage collect and clear the memory or provide tensor inputs which is considered same input signature (in your-case) and the same graph model is used for all those iterations.
So, I converted inputs to Tensors and provided as inputs. The code runs upto 130 iterations and throws different error. Can you please check whether there is any issue in data or in critic.fit(x=[prev_state_v, prev_state_m, prev_state_t], y=target, verbose=0). Please check the gist here. Thanks!

@mbalazs98 model.fit manages its own tf.function and runs training in graph mode for faster computations. When you run model.fit in a for-loop and provide numpy inputs (which is considered as different input signature each iteration in for-loop), each graph is traced separately and there will be n number of models in the memory and consume lot of memory. You can garbage collect and clear the memory or provide tensor inputs which is considered same input signature (in your-case) and the same graph model is used for all those iterations.
So, I converted inputs to Tensors and provided as inputs. The code runs upto 130 iterations and throws different error. Can you please check whether there is any issue in data or in critic.fit(x=[prev_state_v, prev_state_m, prev_state_t], y=target, verbose=0). Please check the gist here. Thanks!

The error is slightly different, but as I see it is still related to memory, and it is definitely not expected. It fails the same way without fitting the critic network, so it shouldn't be related to that either.

Could you provide us with a memory profile?
Cf https://github.com/tensorflow/profiler
https://www.tensorflow.org/guide/profiler
What's the minimum batch size that you can run this model with?

Could you provide us with a memory profile?
Cf https://github.com/tensorflow/profiler
https://www.tensorflow.org/guide/profiler
What's the minimum batch size that you can run this model with?

Unfortunately the model crashes before it can log anything. It fails with a batch size of 1, so that can't be decreased.

I realised that the error is probably related to the custom likelihood function. When compiling the actor network 'experimental_run_tf_function' was set as false and 'tf.config.experimental_run_functions_eagerly' was set as true, otherwise tf gives the following error:
TypeError: An op outside of the function building code is being passed
a "Graph" tensor. It is possible to have Graph tensors
leak out of the function building context by including a
tf.init_scope in your function building code.
For example, the following function will fail:
@tf.function
def has_init_scope():
my_constant = tf.constant(1.)
with tf.init_scope():
added = my_constant * 2
The graph tensor has name: input_7:0
Could I be right about this? If yes, how could this be solved?

@mbalazs98 model.fit manages its own tf.function and runs training in graph mode for faster computations. When you run model.fit in a for-loop and provide numpy inputs (which is considered as different input signature each iteration in for-loop), each graph is traced separately and there will be n number of models in the memory and consume lot of memory. You can garbage collect and clear the memory or provide tensor inputs which is considered same input signature (in your-case) and the same graph model is used for all those iterations.
So, I converted inputs to Tensors and provided as inputs. The code runs upto 130 iterations and throws different error. Can you please check whether there is any issue in data or in critic.fit(x=[prev_state_v, prev_state_m, prev_state_t], y=target, verbose=0). Please check the gist here. Thanks!

Hi folks, sorry if this is out of protocol but what @jvishnuvardhan is talking about happens to me constantly and seems to cover 90% of the problems with running a model in a loop bugs (since before TF2.0). The pandas Series and Dataframe objects, along with the numpy arrays seem to get 'stuck' in memory during a loop. Even deleting the model object from my loop or creating it in my loop causes the same memory growth.
The only known solution that's completely solved it has been disabling eager execution, which, and someone please correct me if I'm wrong, forces tensorflow to treat everything as a tensor instead?
Hopefully someone who knows what they're talking about can look into this but disabling eager execution pretty much solves all memory accumulation errors in a TF loop.

@mbalazs98 model.fit manages its own tf.function and runs training in graph mode for faster computations. When you run model.fit in a for-loop and provide numpy inputs (which is considered as different input signature each iteration in for-loop), each graph is traced separately and there will be n number of models in the memory and consume lot of memory. You can garbage collect and clear the memory or provide tensor inputs which is considered same input signature (in your-case) and the same graph model is used for all those iterations.
So, I converted inputs to Tensors and provided as inputs. The code runs upto 130 iterations and throws different error. Can you please check whether there is any issue in data or in critic.fit(x=[prev_state_v, prev_state_m, prev_state_t], y=target, verbose=0). Please check the gist here. Thanks!

Hi folks, sorry if this is out of protocol but what @jvishnuvardhan is talking about happens to me constantly and seems to cover 90% of the problems with running a model in a loop bugs (since before TF2.0). The pandas Series and Dataframe objects, along with the numpy arrays seem to get 'stuck' in memory during a loop. Even deleting the model object from my loop or creating it in my loop causes the same memory growth.
The only known solution that's completely solved it has been disabling eager execution, which, and someone please correct me if I'm wrong, forces tensorflow to treat everything as a tensor instead?
Hopefully someone who knows what they're talking about can look into this but disabling eager execution pretty much solves all memory accumulation errors in a TF loop.

@mbalazs98 Is this still an issue for you? Can you please check with recent TF versions (TF2.7 and tf-nightly`) and let us know whether issue is still persisting.
Please note that Keras development moved to another repository to focus entirely on only keras. Could you please repost this issue on keras-team/keras repo. Thanks!


Add basic callback scheduling

Current coverage is 82.40%

Merging #3 into master will decrease coverage by -13.86% as of cf15553

@@            master     #3   diff @@
=====================================
  Files            2      3     +1
  Stmts          107    125    +18
  Branches         0      0
  Methods
=====================================
  Hit            103    103
  Partial          0      0
- Missed           4     22    +18

Review entire Coverage Diff as of cf15553

Powered by Codecov. Updated on successful CI builds.


MGLOfflineStorage.Shared.AddPack can't use

In MGLOfflineStorage.Shared.AddPack first param is OfflineRegion type. It seems to me need MGLTilePyramidOfflineRegion?

Hi @sergsel , sorry for the late response.
Please check Mapbox team's example to see how to download offline map: Offline Pack
Sample code when using this binding library:
var fromZoomLevel = Math.Min (10, MapView.ZoomLevel);
var toZommLevel = Math.Max (16, MapView.ZoomLevel);
var region = new MGLTilePyramidOfflineRegion (MapView.StyleURL, MapView.VisibleCoordinateBounds, fromZoomLevel, toZommLevel);
var userInfo = new NSDictionary ("name", mapName);
var context = NSKeyedArchiver.ArchivedDataWithRootObject (userInfo);
var sharedStorage = MGLOfflineStorage.SharedOfflineStorage ();
sharedStorage.AddPackForRegion (region, context, (pack, error) => {
	if (error != null) {
		this.ShowAlert (NSBundle.MainBundle.LocalizedString ("map_caching_download_failed_title", ""), error.LocalizedDescription);
	} else {
		CurrentActions |= MapAction.DownloadingMap;
		this.ShowLoadingIndicator ();
		pack.Resume ();
	}
});

Is it fixed now, @sergsel ?


SSL verification is Failed - [BRIEF DESCRIPTION]

App Id: daaxdtohx0ws6
Region: us-east-2
Step: SSL verification
Status: Failed

Note: Do not include information that is sensitive in nature such as your domain name, company etc.

Issue/question
I am implementing a domain name I recently purchased from route53, though I have had issues with amplify console integration.
Error message
Error message: The status of this certificate request is "Failed". One or more domain names have failed DNS validation. Please check your domain name validation routes and try re-adding the custom domain to your app. Learn more: https://docs.aws.amazon.com/amplify/latest/userguide/custom-domains.html#custom-domain-troubleshoot-guide
Additional information
I've recently added the name services which was my last roadblock, now I am failing ssl.

Hi @IsaacTrevino , Did you check if the name servers on your domain match the name servers that the Amplify app created?

For whoever runs into this issue, it started working automatically after some time.


Add missing task events

The list of handled events doesn't contain update (as well as timeout) so setTaskListeners overwrites listeners for these events and they are gone. This is a major issue with master right now.
I guess that could also be the cause for #101.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

@jangalinski - I believe the build is failing because of #113?

hm. I guessed that the PR branch was built already? Does it build locally on your side?

No, I spent a bunch of time debugging my application before I found that it broke because of these missing event types so I just added them and made the PR. Sorry, should have tried building it first. I didn't know these events are missing on older versions of Camunda.


Microsoft.Search RP Supports New 2024-06-01-Preview API

ARM (Control Plane) API Specification Update Pull Request

[!TIP]
Overwhelmed by all this guidance? See the Getting help section at the bottom of this PR description.

PR review workflow diagram
Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

Purpose of this PR
What's the purpose of this PR? Check the specific option that applies. This is mandatory!

[ ] New resource provider.
[x] New API version for an existing resource provider. (If API spec is not defined in TypeSpec, the PR should have been created in adherence to OpenAPI specs PR creation guidance).
[ ] Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
[ ] Update existing version to fix OpenAPI spec quality issues in S360.
[ ] Other, please clarify:

edit this with your clarification

Due diligence checklist
To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:

[ ] I confirm this PR is modifying Azure Resource Manager (ARM) related specifications, and not data plane related specifications.
[ ] I have reviewed following Resource Provider guidelines, including
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.

Additional information

 Viewing API changes
For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.

Suppressing failures
If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
suppressions guide to get approval.

Getting help

First, please carefully read through this PR description, from top to bottom. Please fill out the Purpose of this PR and Due diligence checklist.
To understand what you must do next to merge this PR, see the Next Steps to Merge comment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.
For guidance on fixing this PR CI check failures, see the hyperlinks provided in given failure
and https://aka.ms/ci-fix.
For help with ARM review (PR workflow diagram Step 2), see https://aka.ms/azsdk/pr-arm-review.
If the PR CI checks appear to be stuck in queued state, please add a comment with contents /azp run.
This should result in a new comment denoting a PR validation pipeline has started and the checks should be updated after few minutes.
If the help provided by the previous points is not enough, post to https://aka.ms/azsdk/support/specreview-channel and link to this PR.

/azsp run

Awaiting review for ARM reviewer. Current position #46. ETA: 5 days

Current position # 45. ETA: 5 days

Current position # 37. ETA: 4 days

Received guidance from Razvan around updating our common types: We asked if it was possible to return null SystemData or omit from response while the implementation is complete. His suggestion: Don't upgrade common types until implementation is ready, as this can provide inaccurate data and some confusion (or not great experience). His suggestion was to upgrade to common type that does not use new system data properly (Such as v3). Unfortunately, we are trying to use v5 to make use of -> NSP definition, UserAssignedIdentity definition, and Resource definition which is only accessible in v5>=.
We will be reverting back to our previous common types and definitions.

Current position # 28. ETA: 3 days


react-navigation deep linking

Description
I used react-navigation for my CRNA navigator. I have a one question about deep linking. I need to eject to use it or any other way to make it work?
Expected Behavior
react-navigation deep linking
Observed Behavior
no idea.
Error text goes here!

Environment
Please run these commands in the project folder and fill in their results:

npm ls react-native-scripts<EMAIL_ADDRESS>npm ls react-native<EMAIL_ADDRESS>npm ls expo<EMAIL_ADDRESS>node -v: v6.10.2
npm -v: 3.10.10
yarn --version: 0.20.3
watchman version: 4.7.0

Also specify:

Operating system: OS X 10.11.6
Phone/emulator/simulator & version: Asus Zenfone 5

Deep linking works right now, but it's not fully documented yet and might change. I believe you can use the API as documented in the React Native docs without doing any of the native-side configuration. But I could be horribly wrong.
cc @terribleben @jesseruder


Error in installing qiskit-aqua from source

Information

Qiskit Aqua version: master
Python version: Python 3.9.2
Operating system:macOS BigSur 11.2.3

What is the current behavior?
Following the instruction from https://qiskit.org/documentation/contributing_to_qiskit.html#install-install-from-source-label
I got error in installing qiskit-aqua
Steps to reproduce the problem

git clone https://github.com/Qiskit/qiskit-aqua.git (OK)
cd qiskit-aqua (OK)
pip install -r requirements-dev.txt (OK)
pip install -e .

ERROR: Could not find a version that satisfies the requirement scipy<=1.4.1,>=1.4 (from qiskit-aqua)
ERROR: No matching distribution found for scipy<=1.4.1,>=1.4
What is the expected behavior?
I expect to install qiskit-aqua
Suggested solutions
The file requirements.txt and constraints.txt are not compatible.

With fixes https://github.com/Qiskit/qiskit-aqua/pull/1557 now is working fine.


Can't fill in password - modal closes when password field takes focus

OS version: Ubuntu 18.04
Browser version: Firefox 64.0
Extension version: 1.18.0

🐛 Describe the bug
I can't login because every time the password field takes the focus, the modal window closes.
Expected behaviour
I should be able to type or copy-paste my password, then click "Log in"
Steps to reproduce
Steps to reproduce the behaviour:

Install the add-on
Click the  button
Fill in the e-mail field
Click the password field or press Tab

Other details or context
I tried to focus the password field by clicking it or using keyboard "Tab", but it doesn't solve the problem.

Hey @Spone!
Could you try login with the new release? (version 1.34.0 and up)
We revamped the login process to allow login from the toggl.com website.

Yes it's fixed! Thanks!


Cargo buffers stdout even with TERM=dumb

Problem

Even with TERM=dumb, cargo buffers stderr stdout, meaning I do not see things printed to stdout without a trailing \n.
For Miri, we use cargo rustc set up RUSTC_WRAPPER such that we can intercept the call that builds a binary, to instead run it with Miri.  Unfortunately, if the application prints to stdout, that output is buffered by Cargo.  This is a problem in particular when running a test suite, because it means I cannot see which test is taking long when the test suite just stops.
Possible Solution(s)

When Cargo prints no progress bar, it should leave stdout of the running application entirely unmodified, and not introduce any additional line buffering.
Notes
Output of cargo version: cargo 1.34.0-nightly (245818076 2019-01-27)

This is likely related to cargo capturing JSON from the compiler.

It is unrelated to JSON which uses a separate code path (only if --message-format=json is used). It is buffered so that when multiple compilers are running at the same time that their output doesn't interleave with one another.  It's not a perfect solution, but it's a tricky problem (rustc on Windows uses a global lock to accomplish this).
I'm not sure I understand the issue.  Is miri sending information without a trailing \n?

Miri runs an arbitrary program, and that program sends information without a trailing \n. Specifically, it is running the libtest harness (without concurrency), which uses that to show the name of the currently running test -- very useful when working with Miri and a test takes 5min and I want to know which test is slow.

Python has  an "unbuffered" option - python -u. Perhaps cargo can do this as well.
https://docs.python.org/3/using/cmdline.html#cmdoption-u

FWIW Miri these days uses target.runner to control what happens when the executable is run, so we no longer have this problem.

Without a use case needing this anymore, I'm going to go ahead and close this.  If there is a reason for us to re-evaluate this, let us know!


Migrate CI to GitHub Actions

Closes #2684.
This migrates the CI from Travis to GitHub Actions.
In Travis, Java 16 was also tested: in this new CI workflow I only added the LTS versions: 8, 11, 17. I think this should generally be sufficient unless there is anything specific about Java 16 that is relevant for Vavr.
The automatic deploy to the Maven repository would still need to be added (not having access to this repository I cannot set up the required secrets for it).
I also had to fix a small error in Javadoc generation.

Thanks for the contribution - this is already done hence closing. I'm still catching up with what happened during last years, so, unfortunately, some work might be doubled :(


TypeError: Cannot read property '0' of undefined

@JacobPlaysGames What version and branch of the bot are you running? can you identify the commit for me?

Seems to be anything after commit f6b1679

Hah, I ended up fixing this but didn't close the issue. Can you update to latest and confirm the fix? :)

Same issue as of commit c8df9bb

You reopened it, is it not resolved on more recent commits?

It is not resolved on the most recent commit. My bad. Accidentally closed it.

I'll debug and try to come up with a proper fix then


how to lockdown chilipie?

Hey folks, i´m just trying to lockdown my chilipie somehow:
My problem is, that the rpi i´m running has a fullfeatured keyboard on it and i think that some people will try to get into the system instead just using the webpage i show them.
So i have to disable the autologin on ctrl-alt-f2 and f3, and if possible also disable alt-f4 to make the system save.
I know that there are some more shortcuts, but i hope they will not be tried ;)
So, any idea or tip how i can achive this?
Thanks,
Tobias

You should start by changing the password to something not default, removing the pi user from sudoers, and indeed remove the auto-logins. Then you'd want to look into disabling as many system-wide shortcuts as possible, and see which Chromium switches would make it harder to exit (look into --kiosk for example).
That said, you may have a hard time plugging every hole from a determined attacker. This is not the primary use case for chilipie-kiosk, but you're of course welcome to try hardening it for this use case.
Please report back! :)


Fixing flake8 E402 errors.

python -m flake8 --ignore=E501 .
./plugins/modules/certificate_request.py:278:1: E402 module level import not at top of file
from ansible.module_utils.basic import AnsibleModule
^

./plugins/modules/certificate_request.py:279:1: E402 module level import not at top of file
from ansible_collections.fedora.system_roles.plugins.module_utils.certificate.providers.init import PROVIDERS
^
2     E402 module level import not at top of file

Why haven't we seen these errors before?  Travis CI does flake checks.

Why haven't we seen these errors before? Travis CI does flake checks.

I'm not sure why flake8 behaves this way, but due to the collection conversion, some import statements get longer and cause E501 errors. At the time, E402 is not reported.
+ python -m flake8 .
./plugins/modules/certificate_request.py:279:89: E501 line too long (113 > 88 characters)
from ansible_collections.fedora.system_roles.plugins.module_utils.certificate.providers.__init__ import PROVIDERS

So, I put --ignore=E501 to python -m flake8 ., then the error E402 has started. Even in the source certificate repo, python -m flake8 --ignore=E501 . reports E402.
$ pwd
/home/nhosoi/linux-system-roles/certificate
$ python -m flake8 .
$ python -m flake8 --ignore=E501 .
./library/certificate_request.py:278:1: E402 module level import not at top of file
from ansible.module_utils.basic import AnsibleModule
^
./library/certificate_request.py:279:1: E402 module level import not at top of file
from ansible.module_utils.certificate.providers import PROVIDERS
^
2     E402 module level import not at top of file

Ok I see.  Yes, we should ignore E501 due to the extra line length due to the conversion.
However, E402 should already be excluded - from tox.ini:
[flake8]
show_source = true
max-line-length = 88
ignore = E402,W503

Indeed, it was my mistake... I guess if I set --ignore through RUN_FLAKE8_EXTRA_ARGS, the ignore in [flake8] in tox.ini is overridden... :p.
Closing this PR.


Are you using one-time resize or multiple time resize?

For example, if I want to upscale from 8x8 to 128x128, which one is the right way?

resize => conv => conv => conv => conv
resize,conv => resize,conv => resize,conv => resize,conv

@colah PTAL

We did multiple resize and convs, but I don't think any detailed examination of the benefits of each has been done.
One reason to do multiple resizes and convs is that it allows you to do more work where you can integrate global context.

Please see also our other paper exploring large image models: https://arxiv.org/pdf/1610.09585.pdf


Remove Endpoints - /email-branding/

User Story - Business Need

In the effort to clean up our code we need to investigate and remove unused endpoints. This ticket is to take a look at the endpoints under /email-branding/ and remove the ones marked for removal. You can view the table of endpoints here.
User Story(ies)
As an engineer
I want to clean up and reduce our codebase
So that it is easier to maintain and upgrade in the future.
Additional Info and Resources

Endpoint Table
Endpoint Spreadsheet

Engineering Checklist

[ ] Investigate the endpoints starting with /email-branding/ to make sure they aren't being used
[ ] Remove tests associate with those endpoints
[ ] Remove the code associated with those endpoints (if possible). Make sure not to remove any code used by other parts of the application.

Acceptance Criteria

When the designated code and tests have been removed, the application retains full functionality.

QA Considerations

[ ] The QA Regression Suite passes
[ ] The Cypress regression passes

Potential Dependencies

Make sure the removal of these endpoints doesn't affect the work Strike is doing.

Hey team! Please add your planning poker estimate with Zenhub @EvanParish @justaskdavidb2 @k-macmillan @kalbfled @ldraney

Hey team! Please add your planning poker estimate with Zenhub @cris-oddball @jakehova

@k-macmillan please remember to update the details of this ticket

The team will use this as a learning ticket to plan/point the rest of the relevant tickets. Please heavily document what all you end up removing, etc.

Closing/no longer relevant.


[hotfix] Add support for Flink 1.20 and drop 1.16

The PR drops support for Flink 1.16 and adds 1.20 snapshot

Thanks for taking a look


feature: Course Enrollment and Purchase Tracking

It’s frustrating not being able to track how many users have enrolled in or purchased courses. Without this data, it’s hard to measure course success or improve content and marketing strategies.
Description:
I would like a simple dashboard that shows how many users have enrolled in or bought each course. It should also track revenue for paid courses and display engagement metrics, such as user progress and course completion rates.

I guess these metrics will be provided to Harkirat by Appx platform but wont be visible to us.


Failing test:  MediaSourceUpdateTest

On a fresh Islandora install the following MediaSourceUpdateTest is failing:

vagrant@islandora8:/var/www/html/drupal/web$ ../vendor/bin/phpunit -c core/phpunit.xml modules/contrib/islandora/tests/src/Functional/MediaSourceUpdateTest.php
PHPUnit 9.5.18 #StandWithUkraine

Warning:       Your XML configuration validates against a deprecated schema.
Suggestion:    Migrate your XML configuration using "--migrate-configuration"!

Testing Drupal\Tests\islandora\Functional\MediaSourceUpdateTest
F                                                                   1 / 1 (100%)

Time: 00:36.114, Memory: 10.00 MB

There was 1 failure:

1) Drupal\Tests\islandora\Functional\MediaSourceUpdateTest::testMediaSourceUpdate
Expected 204, received 500
Failed asserting that false is true.

HTML output:

ID #5 ([Previous](http://localhost:8000/sites/simpletest/browser_output/Drupal_Tests_islandora_Functional_MediaSourceUpdateTest-4-34842439.html) | [Next](http://localhost:8000/sites/simpletest/browser_output/Drupal_Tests_islandora_Functional_MediaSourceUpdateTest-6-34842439.html))
Called from GuzzleHttp\Promise\FulfilledPromise::GuzzleHttp\Promise\{closure}() line 41
PUT request to: http://localhost:8000/media/1/source
[Skip to main content](http://localhost:8000/sites/simpletest/browser_output/Drupal_Tests_islandora_Functional_MediaSourceUpdateTest-5-34842439.html#main-content)
A client error happened
Headers:
array (
  'Date' => 'Wed, 09 Mar 2022 18:23:27 GMT',
  'Server' => 'Apache/2.4.41 (Ubuntu)',
  'X-Powered-By' => 'PHP/7.4.28',
  'X-Drupal-Assertion-0' => 'a%3A3%3A%7Bi%3A0%3BO%3A25%3A%22Drupal%5CCore%5CRender%5CMarkup%22%3A1%3A%7Bs%3A9%3A%22%00%2A%00string%22%3Bs%3A155%3A%22The%20%22Symfony%5CComponent%5CHttpFoundation%5CFile%5CMimeType%5CMimeTypeGuesser%22%20class%20is%20deprecated%20since%20Symfony%204.3%2C%20use%20%22Symfony%5CComponent%5CMime%5CMimeTypes%22%20instead.%22%3B%7Di%3A1%3Bs%3A24%3A%22User%20deprecated%20function%22%3Bi%3A2%3Ba%3A3%3A%7Bs%3A8%3A%22function%22%3Bs%3A9%3A%22include%28%29%22%3Bs%3A4%3A%22file%22%3Bs%3A85%3A%22%2Fvar%2Fwww%2Fhtml%2Fdrupal%2Fvendor%2Fsymfony%2Fhttp-foundation%2FFile%2FMimeType%2FMimeTypeGuesser.php%22%3Bs%3A4%3A%22line%22%3Bi%3A18%3B%7D%7D',
  'X-Drupal-Assertion-1' => 'a%3A3%3A%7Bi%3A0%3BO%3A25%3A%22Drupal%5CCore%5CRender%5CMarkup%22%3A1%3A%7Bs%3A9%3A%22%00%2A%00string%22%3Bs%3A181%3A%22The%20%22Symfony%5CComponent%5CHttpFoundation%5CFile%5CMimeType%5CFileBinaryMimeTypeGuesser%22%20class%20is%20deprecated%20since%20Symfony%204.3%2C%20use%20%22Symfony%5CComponent%5CMime%5CFileBinaryMimeTypeGuesser%22%20instead.%22%3B%7Di%3A1%3Bs%3A24%3A%22User%20deprecated%20function%22%3Bi%3A2%3Ba%3A3%3A%7Bs%3A8%3A%22function%22%3Bs%3A9%3A%22include%28%29%22%3Bs%3A4%3A%22file%22%3Bs%3A95%3A%22%2Fvar%2Fwww%2Fhtml%2Fdrupal%2Fvendor%2Fsymfony%2Fhttp-foundation%2FFile%2FMimeType%2FFileBinaryMimeTypeGuesser.php%22%3Bs%3A4%3A%22line%22%3Bi%3A18%3B%7D%7D',
  'X-Drupal-Assertion-2' => 'a%3A3%3A%7Bi%3A0%3BO%3A25%3A%22Drupal%5CCore%5CRender%5CMarkup%22%3A1%3A%7Bs%3A9%3A%22%00%2A%00string%22%3Bs%3A177%3A%22The%20%22Symfony%5CComponent%5CHttpFoundation%5CFile%5CMimeType%5CFileinfoMimeTypeGuesser%22%20class%20is%20deprecated%20since%20Symfony%204.3%2C%20use%20%22Symfony%5CComponent%5CMime%5CFileinfoMimeTypeGuesser%22%20instead.%22%3B%7Di%3A1%3Bs%3A24%3A%22User%20deprecated%20function%22%3Bi%3A2%3Ba%3A3%3A%7Bs%3A8%3A%22function%22%3Bs%3A9%3A%22include%28%29%22%3Bs%3A4%3A%22file%22%3Bs%3A93%3A%22%2Fvar%2Fwww%2Fhtml%2Fdrupal%2Fvendor%2Fsymfony%2Fhttp-foundation%2FFile%2FMimeType%2FFileinfoMimeTypeGuesser.php%22%3Bs%3A4%3A%22line%22%3Bi%3A18%3B%7D%7D',
  'Cache-Control' => 'must-revalidate, no-cache, private',
  'X-Drupal-Dynamic-Cache' => 'UNCACHEABLE',
  'X-UA-Compatible' => 'IE=edge',
  'Content-language' => 'en',
  'X-Content-Type-Options' => 'nosniff',
  'X-Frame-Options' => 'SAMEORIGIN',
  'Permissions-Policy' => 'interest-cohort=()',
  'X-Drupal-Cache-Tags' => '4xx-response config:block_list http_response rendered',
  'X-Drupal-Cache-Contexts' => 'languages:language_interface theme url.query_args:_wrapper_format user.permissions',
  'X-Drupal-Cache-Max-Age' => '0 (Uncacheable)',
  'Expires' => 'Sun, 19 Nov 1978 05:00:00 GMT',
  'X-Generator' => 'Drupal 9 (https://www.drupal.org)',
  'Content-Length' => '5253',
  'Connection' => 'close',
  'Content-Type' => 'text/html; charset=UTF-8',
)

Last HTML output:

ID #12 ([Previous](http://localhost:8000/sites/simpletest/browser_output/Drupal_Tests_islandora_Functional_MediaSourceUpdateTest-11-34745505.html) | [Next](http://localhost:8000/sites/simpletest/browser_output/Drupal_Tests_islandora_Functional_MediaSourceUpdateTest-13-34745505.html))
Called from GuzzleHttp\Promise\FulfilledPromise::GuzzleHttp\Promise\{closure}() line 41
PUT request to: http://localhost:8000/media/1/source
The website encountered an unexpected error. Please try again later.
Symfony\Component\HttpKernel\Exception\HttpException: SQLSTATE[42000]: Syntax error or access violation: 1064 You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'WHERE "fid" = '1'' at line 2: UPDATE "test34745505filehash" SET WHERE "fid" = :db_condition_placeholder_0; Array ( [:db_condition_placeholder_0] => 1 ) in Drupal\islandora\Controller\MediaSourceController->put() (line 127 of modules/contrib/islandora/src/Controller/MediaSourceController.php).
call_user_func_array(Array, Array) (Line: 123)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber{closure}() (Line: 564)
Drupal\Core\Render\Renderer->executeInRenderContext(Object, Object) (Line: 124)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->wrapControllerExecutionInRenderContext(Array, Array) (Line: 97)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber{closure}() (Line: 158)
Symfony\Component\HttpKernel\HttpKernel->handleRaw(Object, 1) (Line: 80)
Symfony\Component\HttpKernel\HttpKernel->handle(Object, 1, 1) (Line: 58)
Drupal\Core\StackMiddleware\Session->handle(Object, 1, 1) (Line: 48)
Drupal\Core\StackMiddleware\KernelPreHandle->handle(Object, 1, 1) (Line: 106)
Drupal\page_cache\StackMiddleware\PageCache->pass(Object, 1, 1) (Line: 85)
Drupal\page_cache\StackMiddleware\PageCache->handle(Object, 1, 1) (Line: 48)
Drupal\Core\StackMiddleware\ReverseProxyMiddleware->handle(Object, 1, 1) (Line: 51)
Drupal\Core\StackMiddleware\NegotiationMiddleware->handle(Object, 1, 1) (Line: 23)
Stack\StackedHttpKernel->handle(Object, 1, 1) (Line: 709)
Drupal\Core\DrupalKernel->handle(Object) (Line: 19)
Headers:
array (
'Date' => 'Wed, 09 Mar 2022 19:27:21 GMT',
'Server' => 'Apache/2.4.41 (Ubuntu)',
'X-Powered-By' => 'PHP/7.4.28',
'X-Drupal-Assertion-0' => 'a%3A3%3A%7Bi%3A0%3BO%3A25%3A%22Drupal%5CCore%5CRender%5CMarkup%22%3A1%3A%7Bs%3A9%3A%22%00%2A%00string%22%3Bs%3A155%3A%22The%20%22Symfony%5CComponent%5CHttpFoundation%5CFile%5CMimeType%5CMimeTypeGuesser%22%20class%20is%20deprecated%20since%20Symfony%204.3%2C%20use%20%22Symfony%5CComponent%5CMime%5CMimeTypes%22%20instead.%22%3B%7Di%3A1%3Bs%3A24%3A%22User%20deprecated%20function%22%3Bi%3A2%3Ba%3A3%3A%7Bs%3A8%3A%22function%22%3Bs%3A9%3A%22include%28%29%22%3Bs%3A4%3A%22file%22%3Bs%3A85%3A%22%2Fvar%2Fwww%2Fhtml%2Fdrupal%2Fvendor%2Fsymfony%2Fhttp-foundation%2FFile%2FMimeType%2FMimeTypeGuesser.php%22%3Bs%3A4%3A%22line%22%3Bi%3A18%3B%7D%7D',
'X-Drupal-Assertion-1' => 'a%3A3%3A%7Bi%3A0%3BO%3A25%3A%22Drupal%5CCore%5CRender%5CMarkup%22%3A1%3A%7Bs%3A9%3A%22%00%2A%00string%22%3Bs%3A181%3A%22The%20%22Symfony%5CComponent%5CHttpFoundation%5CFile%5CMimeType%5CFileBinaryMimeTypeGuesser%22%20class%20is%20deprecated%20since%20Symfony%204.3%2C%20use%20%22Symfony%5CComponent%5CMime%5CFileBinaryMimeTypeGuesser%22%20instead.%22%3B%7Di%3A1%3Bs%3A24%3A%22User%20deprecated%20function%22%3Bi%3A2%3Ba%3A3%3A%7Bs%3A8%3A%22function%22%3Bs%3A9%3A%22include%28%29%22%3Bs%3A4%3A%22file%22%3Bs%3A95%3A%22%2Fvar%2Fwww%2Fhtml%2Fdrupal%2Fvendor%2Fsymfony%2Fhttp-foundation%2FFile%2FMimeType%2FFileBinaryMimeTypeGuesser.php%22%3Bs%3A4%3A%22line%22%3Bi%3A18%3B%7D%7D',
'X-Drupal-Assertion-2' => 'a%3A3%3A%7Bi%3A0%3BO%3A25%3A%22Drupal%5CCore%5CRender%5CMarkup%22%3A1%3A%7Bs%3A9%3A%22%00%2A%00string%22%3Bs%3A177%3A%22The%20%22Symfony%5CComponent%5CHttpFoundation%5CFile%5CMimeType%5CFileinfoMimeTypeGuesser%22%20class%20is%20deprecated%20since%20Symfony%204.3%2C%20use%20%22Symfony%5CComponent%5CMime%5CFileinfoMimeTypeGuesser%22%20instead.%22%3B%7Di%3A1%3Bs%3A24%3A%22User%20deprecated%20function%22%3Bi%3A2%3Ba%3A3%3A%7Bs%3A8%3A%22function%22%3Bs%3A9%3A%22include%28%29%22%3Bs%3A4%3A%22file%22%3Bs%3A93%3A%22%2Fvar%2Fwww%2Fhtml%2Fdrupal%2Fvendor%2Fsymfony%2Fhttp-foundation%2FFile%2FMimeType%2FFileinfoMimeTypeGuesser.php%22%3Bs%3A4%3A%22line%22%3Bi%3A18%3B%7D%7D',
'Cache-Control' => 'must-revalidate, no-cache, private',
'X-UA-Compatible' => 'IE=edge',
'Content-language' => 'en',
'X-Content-Type-Options' => 'nosniff',
'X-Frame-Options' => 'SAMEORIGIN',
'Permissions-Policy' => 'interest-cohort=()',
'Expires' => 'Sun, 19 Nov 1978 05:00:00 GMT',
'X-Generator' => 'Drupal 9 (https://www.drupal.org)',
'Content-Length' => '2094',
'Connection' => 'close',
'Content-Type' => 'text/html; charset=UTF-8',
)

Issue is with FIleHash, fixed in the 2.x branch. Fix is in this PR https://github.com/Islandora/islandora/pull/862

Issue is with FIleHash, fixed in the 2.x branch. Fix is in this PR https://github.com/Islandora/islandora/pull/862


[FP]: all projects containing yaml in their name are incorrectly matched against yaml_project

Package URl
<EMAIL_ADDRESS>CPE
cpe:2.3:a:yaml_project:yaml:0.62.2:::::::*
CVE
CVE-2022-3064
ODC Integration
{"label"=>"Maven Plugin"}
ODC Version
7.4.4
Description
This looks like yet another example of a package that contain an underscore character. Could it be the case that this underscore is incorrectly treated as a wildcard character or something? There have been quite a few cases in the last few weeks all related to cpe containing an underscore.

Duplicate of #5233 and  #5234, will be fixed by next-release and can be avoided already by using the hostedSuppressions as an additional suppressionFile (https://jeremylong.github.io/DependencyCheck/suppressions/publishedSuppressions.xml)


TextEncoder interface:    Latest Opera and Firefox already support it.

TextEncoder interface:
http://encoding.spec.whatwg.org/#interface-textencoder
Latest Opera and Firefox already support it.

This issue was imported from Google Moderator
Moderator votes: +6
Issue added by Kornel on 2014-02-18
To vote this issue up or down, simply include +1 or -1 in your comment.

Duplicate of #1195.


Compressed file types to scan

Hi team,
About this option :
--scan-zip    Scan also .zip extension files. This option may slow down scanning.
Could it be updated to  cover .tar, .gz, .tgz and .bz files ?
Unix users are using the scanner as well.

Overlapping #https://github.com/logpresso/CVE-2021-44228-Scanner/issues/171

I'll consider this issue only if I have more time and everybody wants it.

I too want it and even would implement it, but I won't have the time to do so in the next few days.

Due to https://stackoverflow.com/questions/15521966/zipinputstream-getnextentry-returns-null-on-some-zip-files issue, I decided to use commons-compress and support tar format.


Version high-low part of SQL SERVER

These should probably be ignored as they are incorrectly highlighted as been configured.
Discussed in https://github.com/trimble-oss/dba-dash/discussions/786

Originally posted by acappelletti December  3, 2023
I don't understood this two columns?

Alen

The configuration tab highlights when the defaults have been changed but it might be better to offer advice around settings that should be configured.  e.g. MAXDOP, cost threshold, backup compression, backup checksum, max server memory


refactor: deprecate react-transition-group over tailwind animations

Resolves #1071.

Sorry, just changed base! Was doing multiple things at once.


Distributed Data Parallel mode support

Created a Trainer class for better flexibility;
Added support of  Distributed Data Parallel mode;
Updated readme adding information about the multi-task model;

Nice, thank you @Ingvarstep


Parameters with default value should be allowed anywhere

Have code like this
function foo(one = 1, two, three) {

}

which is valid ES6 syntax (http://www.ecma-international.org/ecma-262/6.0/index.html#sec-functions-and-classes). TypeScript flags such a signature as error because it treats default values like optional parameters.

@jrieken Correct me if I'm wrong, but I think you can only elide arguments at the end of the argument list, right? You can't do this for example:
foo(, 2, 3);

unsure about that, but you can all foo(undefined, 2, 3)

The initialization is considered a marker for optionality, and ? is prohibited. no non-optional members are allowed after an optional one. doing this would be a large breaking change, unless we only treat them as optional if they fall at the end, which would be a convoluted rule.
Unless we have a proposal for how to make this work, i would be inclined to mark it as won't fix.

@jrieken Yes, I just wanted to make sure that was the only way to pass undefined.
@mhegazy I discussed this with @ahejlsberg and we think it is reasonable to only treat them as optional at the end (the one that you are saying is a convoluted rule).

doing this would be a large breaking change

How is making a prior error a non-error a breaking change?

@RyanCavanaugh That is a good question.

I do not think it is a breaking change.


Fuzzy dedup

Why are these changes needed?
Provide fuzzy dedup implementation for Python, Spark and Ray
Related issue number (if any).
#152
#79

@cmadam The documentation looks really good! Thank you. I found one wrong link to the utils folder, and I changed it manually (without a change request). Sorry that it meant a full ci/cd test! If I find other problems, I will make a change request and won't change myself.

@cmadam Thank you for the notebook. Looks good. Two comments:

Your notebook is using the Ray runtime. To be consistent with other notebooks, can you please change it to use the Python runtime? (now that we have it because of your work on this PR)
In the cell before setting up the parameters, can you briefly (in a few sentences) describe what some of the key parameters are?

@cmadam Thank you for the notebook. Looks good. Two comments:

Your notebook is using the Ray runtime. To be consistent with other notebooks, can you please change it to use the Python runtime? (now that we have it because of your work on this PR)
In the cell before setting up the parameters, can you briefly (in a few sentences) describe what some of the key parameters are?

@shahrokhDaijavad : I am going to add documentation of the parameters that are used in the example notebook. Regarding the runtime, let me double-check with @touma-I, as my understanding was that he asked me to provide a notebook based on the ray runtime, not python.

Thanks, @cmadam. Sure. Maybe @touma-I wants this one with ray runtime as an example of how we can use ray.

Wow! @cmadam This is outstanding! Three notebooks for the three runtimes.


Added the contributors at the bottom of readme file

@yashlamba @yashugarg  Sir I added the contributors at the bottom of the readme file i.e., #182  . Please review it and let me know .

Can you please check the updated version of readme file @yashugarg Sir?

@yashlamba @yashugarg Can you please check it now I made the requested changes in the pr

@apoorvdwi Can you please check this one?


(Alpha) V2: Gas fee estimate for trade different than Metamask

When a user previews a trade on V2 using Metamask, the gas fee estimate given is significantly different than the gas fee given by the Metamask extension when signing the trade.

visit https://app.shapeshift.com/dashboard
connect metamask
preview trade ETH/ERC-20-ETH/ERC-20
take note of the gas fee estimate
click "confirm and trade"
see the fee that Metamask is having you use to sign the TX

A/C:

The estimated gas fee should be much closer to the actual gas fee that Metamask pulls when completing a trade on V2.
Update and extend any tests associated with this flow

@SS-FOX-McCloud - any concerns to bounty this one out? Seems like it should be a straightforward fix for a new contributor.

Hey, I just took a look at this issue. Is there any chance that the problem is with the gas value sent by the API? I haven't checked the API that Metamask uses yet, but it might be sending a different value.

Hey @armr-dev - I just saw your comment on the other GH issue I had approved you for work on.  I didn't realize someone had already submitted a PR for that since I didn't approve their work.  Anyways, I appreciate you bringing that up.
Would you want to pick this one up instead?  Happy to have you dive in and see if you can figure out a fix and if the fix is more complex than originally expected, I am very willing to make sure we can get more FOX heading your way ;)
Thanks for the interest in ShapeShift and the great communication so far.

Hey! I already took a look at this one. It does look complex, but that won't keep me from trying 😎.
I will be working on this one and will keep you updated on the progress.

@armr-dev - awesome, can you apply for the bounty on gitcoin here and i will approve you?
https://gitcoin.co/issue/shapeshift/web/526/100027238
Also - on Monday the rest of the team will be around, and we can happily answer any questions in our discord
https://discord.gg/shapeshift

@armr-dev - awesome, can you apply for the bounty on gitcoin here and i will approve you?
https://gitcoin.co/issue/shapeshift/web/526/100027238
Also - on Monday the rest of the team will be around, and we can happily answer any questions in our discord
https://discord.gg/shapeshift

Done! I'll join the Discord server. Ty! 😊

Adding some more info from @pastaghost on where to look,
Okay, it looks like the problem has something to do with two different sources being used for the fee estimates being displayed vs the fee estimates passed to hdwallet-metamask. In one of those cases, the gas estimate is coming from lib/packages/swapper/src/swappers/zrx/ZrxExecuteQuote/ZrxExecuteQuoteTx.ts:130-158. In the second, the gas estimate is coming from lib/packages/swapper/src/swappers/zrx/getZrxQuote/getZrxQuote.ts:97-100. You'll see that in getZrxQuote.ts, the gas estimate is for some reason being multiplied by 1.5 where it isn't in the other case. I did play around with this a few weeks ago, and unfortunately it wasn't just a matter of removing/adding the factor of 1.5 in either place, but that brought the gas fee estimates into much closer agreement.

Hello,
I am a software engineer with 6 years of experience in JS/TS and React. I am interested in dipping my toes into web3 development. This looks like something that might be a good place to start.
I have already applied on gitcoin. Thanks!

I have the fix for this issue, even though the culprit is not in this repo ;) Let me know if I can send a PR. I applied to gitcoin also.

@Neurone - Will approve you now.  Yea, just saw your comment in gitcoin and looking at the screenshots, makes sense! That MaxPriorityFee is way off.   Anyways, will approve you now and yea, the PR is probably in lib.
TY.

The bug is in the hdwallet library. It seems safe to disclose it but, just to be extra sure, I already sent an inquiry to the security team following the responsible disclosure program, I used the ticket form via zendesk. As soon as they give me green light I'll publish the PR.

Appreciate the caution.  (CC @reidrankin please see above)

@Neurone - confirmed with our Security workstream that you are fine to publish.

Sent the PR, I summarize also here the problem.
Metamask and other web3 libraries (i.e. geth console, web3.js, etc.) use transaction.gas property for transaction's gas limit, instead of the canonical transaction.gasLimit as mentioned in the yellow paper. This implies Metamask does not read any value for gas limit from the JSON object, and so it chooses one on its own. This behavior leads to inconsistencies between clients and the wallet, and this is why the price changes when Metamask asks the user to sign the tx.

fixed in https://github.com/shapeshift/hdwallet/pull/389 - will need to up hd wallet version in web

@Neurone - thank you for the fix! I just merged if.  you can submit work on gitcoin if you like and I can get the bounty paid out.  If you are willing to also bump the hd wallet version in web and open a PR that would be awesome!

@0xdef1cafe the latest published shapeshift/hdwallet is still 1.18.4, currently about two months old. We cannot change the reference in the package.json until the new library is deployed on npmjs.com.
Side note: there is also some misalignment about the tagging on that repo; the last tag was v1.16.2, created in September. Maybe it's an occasion to fix that also.

comment above still valid as of writing, requires new hdwallet version to publish, likely to come week of 2/21

@0xdef1cafe - to check with highlander on the release of HD wallet

@Neurone hdwallet finally got released - are you interested in picking this back up?

 -<EMAIL_ADDRESS> -<EMAIL_ADDRESS> -<EMAIL_ADDRESS> -<EMAIL_ADDRESS> -<EMAIL_ADDRESS> -<EMAIL_ADDRESS> -<EMAIL_ADDRESS> -<EMAIL_ADDRESS> -<EMAIL_ADDRESS> -<EMAIL_ADDRESS> -<EMAIL_ADDRESS> -<EMAIL_ADDRESS> -<EMAIL_ADDRESS> -<EMAIL_ADDRESS> -<EMAIL_ADDRESS> -<EMAIL_ADDRESS> -<EMAIL_ADDRESS>lerna success published 17 packages``` version 1.19.0 is published :shipit: should be gtg @Neurone

@Neurone hdwallet finally got released - are you interested in picking this back up?

Sure, no problem. It should be just a matter of an upgrade in package.json. I can send a PR for that.


Vendor advertisements visible through walls

Description

stand inside the range of a vendor but where it is not visible to you
wait for it to advertise
its visible

this maybe applies to normal chat as well??? i cant tell
Screenshots

Additional context

I've also encountered this bug for the message when you impale a monkey on a spike.

Pretty sure advertisingcomp goes through normal chat

Yes, vending machines use IChatManager.EntitySay(), just like every other chat command. So I'm pretty sure this also happens with normal chat, and the issue should probably be renamed.


Consistently place the exclusive value columns before the inclusive value columns

This change takes a bit of time to get used to, but in the end it reduces the number of cases where a developer incorrectly reports an Inc Ct count value as an Exc Ct value due to misreading the columns of the current view.
This error occurred many times when I started using PerfView.

Codecov Report

Merging #479 into master will decrease coverage by 0.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #479      +/-   ##
==========================================
- Coverage   17.57%   17.56%   -0.02%
==========================================
  Files         216      216
  Lines      123230   123220      -10
  Branches    11885    11882       -3
==========================================
- Hits        21660    21644      -16
- Misses     100707   100717      +10
+ Partials      863      859       -4

Flag
Coverage Δ

#2017
17.56% <100%> (-0.02%)
:arrow_down:

#Debug
17.56% <100%> (-0.02%)
:arrow_down:

#Release
?

Impacted Files
Coverage Δ

src/PerfView/StackViewer/StackWindow.xaml.cs
26.05% <ø> (-0.17%)
:arrow_down:

src/PerfView/StackViewer/PerfDataGrid.xaml
100% <100%> (ø)
:arrow_up:

src/PerfView/StackViewer/PerfDataGrid.xaml.cs
31.34% <0%> (-2.69%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 99a0c89...73a173e. Read the comment docs.

Closing for now.  Please re-open once feedback has been solicited per @vancem's request.  Thanks.


Fix issue 971: tweak patterns for regex and double-quoted strings f…

…or performance, avoiding slow back-tracking
Ported from https://bitbucket.org/birkenfeld/pygments-main/pull-requests/660

No, it still looks for '/' as the start...


Runs - not displaying runs after unchecking option

pluto runs
1- all options checked
2- go to page 2
3- uncheck Show Errors
Expected: Warnings displayed
Actual: nothing displayed
Oct16 showing blank.pdf

Fixed as part of reset to page 1 on filter change

Fix verified


what does system.ExtrinsicFailed mean?

I write a custom module, when I test sending tx with javascript, it always reports the following error,
{"ApplyExtrinsic":1} :system.ExtrinsicFailed [{"module":8,"error":0},{"weight":10000,"class":0,"paysFee":true}]
No other error info attached,  what does this message mean?
However, simple transfer extrinsic of module balance works without problem.
Any suggestion would be appreciated.

It means your module function returned Err rather than Ok. Can you share the code of the function you are calling?
Take a look at your terminal where you are running the node. You may see a more clear error message there.

Please feel free to reopen if there are follow up questions or join our Substrate Technical channel here: https://riot.im/app/#/room/!HzySYSaIhtyWrwiwEV:matrix.org


Cut a release

We've merged a bunch of changes so sometime soon we should cut a new release.

I'll pull down the latest and test with an actual client, then push out a beta release by the end of this week.

Good plan!

I'm testing master as well with several projects that uses it (except Omniauth that we don't use it), for now I only found an issue #975

Testing master I found failing some tests in a project because I don't have the new field allow_password_change, it was introduced here. What do I have to do? Shouldn't it check if recoverable is enabled?

@MaicolBen it probably should check if recoverable is enabled, that's a good point. Can you find a precedent in Devise or our codebase for how to check for a module being enabled?

Yeah, it's possible, I made a PR #995

While we're waiting for a release to be cut (which would be really great), is there any way to use what's in master on github in a project? Pointing to here in the gemfile still makes it use 0.1.42 code

@Blitzkev You can doing gem 'devise_token_auth', github: 'lynndylanhurley/devise_token_auth'
@lynndylanhurley Any ETA in testing and publishing the release? If we are following semver, this should be 0.2.0 because we have some new features merged in master

@Blitzkev The following is working for me:
gem "devise_token_auth", git: "https://github.com/lynndylanhurley/devise_token_auth", ref: "dc9456d99c2ea6f96323a95c87c1fee8f6cc857b"

Thanks for your patience all and @ethagnawl thanks for the workaround!

Just pushed v0.1.43.beta1. I'll do extensive testing over the next couple of days and push v0.1.43 later this week.
In the meantime please pull down the beta and test.
Thanks!!

Thanks @lynndylanhurley! can you take a look at #995, because it will break for the projects that update the gem. I would like #989 merged, but that's only for our projects.

Would appreciate this merged also:
https://github.com/lynndylanhurley/devise_token_auth/pull/1021

It was done, it's v0.1.43


cross compiling for windows fails

Using env GOOS=windows GOARCH=amd64 CGO_ENABLED=1 CC=x86_64-w64-mingw32-gcc CXX=x86_64-w64-mingw32-g++ go build -ldflags "-H windowsgui" fails with:
# github.com/mattn/go-gtk/pango
In file included from /usr/lib64/glib-2.0/include/glibconfig.h:9:0,
                 from /usr/include/glib-2.0/glib/gtypes.h:32,
                 from /usr/include/glib-2.0/glib/galloca.h:32,
                 from /usr/include/glib-2.0/glib.h:30,
                 from /usr/include/pango-1.0/pango/pango-coverage.h:25,
                 from /usr/include/pango-1.0/pango/pango-font.h:25,
                 from /usr/include/pango-1.0/pango/pango-attributes.h:25,
                 from /usr/include/pango-1.0/pango/pango.h:25,
                 from ./pango.go.h:7,
                 from ../github.com/mattn/go-gtk/pango/pango.go:5:
/usr/include/glib-2.0/glib/gtypes.h: In function '_GLIB_CHECKED_ADD_U64':
/usr/include/glib-2.0/glib/gmacros.h:232:53: error: size of array '_GStaticAssertCompileTimeAssertion_0' is negative
 #define G_STATIC_ASSERT(expr) typedef char G_PASTE (_GStaticAssertCompileTimeAssertion_, __COUNTER__)[(expr) ? 1 : -1] G_GNUC_UNUSED
                                                     ^
/usr/include/glib-2.0/glib/gmacros.h:229:47: note: in definition of macro 'G_PASTE_ARGS'
 #define G_PASTE_ARGS(identifier1,identifier2) identifier1 ## identifier2
                                               ^~~~~~~~~~~
/usr/include/glib-2.0/glib/gmacros.h:232:44: note: in expansion of macro 'G_PASTE'
 #define G_STATIC_ASSERT(expr) typedef char G_PASTE (_GStaticAssertCompileTimeAssertion_, __COUNTER__)[(expr) ? 1 : -1] G_GNUC_UNUSED
                                            ^~~~~~~
/usr/include/glib-2.0/glib/gtypes.h:423:3: note: in expansion of macro 'G_STATIC_ASSERT'
   G_STATIC_ASSERT(sizeof (unsigned long long) == sizeof (guint64));
   ^~~~~~~~~~~~~~~
# github.com/mattn/go-gtk/glib
In file included from /usr/lib64/glib-2.0/include/glibconfig.h:9:0,
                 from /usr/include/glib-2.0/glib/gtypes.h:32,
                 from /usr/include/glib-2.0/glib/galloca.h:32,
                 from /usr/include/glib-2.0/glib.h:30,
                 from ./glib.go.h:4,
                 from ../github.com/mattn/go-gtk/glib/glib.go:5:
/usr/include/glib-2.0/glib/gtypes.h: In function '_GLIB_CHECKED_ADD_U64':
/usr/include/glib-2.0/glib/gmacros.h:232:53: error: size of array '_GStaticAssertCompileTimeAssertion_0' is negative
 #define G_STATIC_ASSERT(expr) typedef char G_PASTE (_GStaticAssertCompileTimeAssertion_, __COUNTER__)[(expr) ? 1 : -1] G_GNUC_UNUSED
                                                     ^
/usr/include/glib-2.0/glib/gmacros.h:229:47: note: in definition of macro 'G_PASTE_ARGS'
 #define G_PASTE_ARGS(identifier1,identifier2) identifier1 ## identifier2
                                               ^~~~~~~~~~~
/usr/include/glib-2.0/glib/gmacros.h:232:44: note: in expansion of macro 'G_PASTE'
 #define G_STATIC_ASSERT(expr) typedef char G_PASTE (_GStaticAssertCompileTimeAssertion_, __COUNTER__)[(expr) ? 1 : -1] G_GNUC_UNUSED
                                            ^~~~~~~
/usr/include/glib-2.0/glib/gtypes.h:423:3: note: in expansion of macro 'G_STATIC_ASSERT'
   G_STATIC_ASSERT(sizeof (unsigned long long) == sizeof (guint64));
   ^~~~~~~~~~~~~~~

AFAICK, your cross C compiler look header files on host OS.

Which headers would those be? Kernel headers are installed

Same problem on ubuntu 16.04 lts:
/usr/include/glib-2.0/glib/gtypes.h: In function '_GLIB_CHECKED_ADD_U64':
/usr/include/glib-2.0/glib/gmacros.h:232:53: error: size of array '_GStaticAssertCompileTimeAssertion_0' is negative

@rawsh Have you managed it ? I am also stuck in same situation

@arpitjindal97 I have not


Add 4byte.directory

They have a decent API, see e.g. https://www.4byte.directory/api/v1/signatures/?hex_signature=0x144f2f94
They currently list 75,659 signatures while the Parity contract lists 240 (according to https://etherscan.io/address/0x44691B39d1a75dC4E0A0346CBB15E310e6ED1E86#readContract)

We should probably consider doing this sometime, although we'd likely have to scrape the data given our usage (see bottom of page here).
GitHub project page: https://github.com/pipermerriam/ethereum-function-signature-registry

We should probably consider doing this sometime, although we'd likely have to scrape the data given our usage (see bottom of page here).
GitHub project page: https://github.com/pipermerriam/ethereum-function-signature-registry


Changelog Is Not Being Maintained

Functional impact
Does the bug result in any actual functional issue, if so, what?
No, nothing functional is impacted by this issue. It is simply a documentation issue.
Minimal repro steps
What is the smallest, simplest set of steps to reproduce the issue. If needed, provide a project that demonstrates the issue.

View the CHANGELOG.md file.
Notice that nothing has been updated in 3 years, so it is apparently not possible to view changes from release to release.

Expected result
What would you expect to happen if there wasn't a bug
The changelog and roadmaps should be updated with every release.
Actual result
The changelog is being ignored.
Further technical details
None.

Updated now, and I'll try to keep this fresh as new releases come out.  Thanks for calling it out!


Log more info

This will help debugging. I believe console.log is not enough. We need to be able to see it via heroku logs command

I think Heroku shows console.log logs


How to use cross compiling for Android?

I decided to give a new try to this project, however, how is it possible to use cross compiling if the required CMake version for corrosion is 3.12 but Android's max available CMake is 3.10.2?

Oh, I haven't heard of this issue. Can you expand on this? Is there any reason you can't use a newer CMake that doesn't come with the Android SDK?

Check out the documentation for the Android NDK for using a newer CMake version: https://developer.android.com/studio/projects/install-ndk#vanilla_cmake
Let me know if that helps.

I was working on improving the cross-compilation for Android experience last night, btw. I added some code to select the correct Rust target-triple when cross-compiling for Android - I'll try to merge that in soon.
I'm hitting an issue - if you are building an executable with Cargo, the final link fails. There must be some set of link arguments specified by the Android toolchain I need to apply when building an executable with cargo. I should probably be doing this anyway to make sure CMake specified link args are respected. If you do the final link with a C or C++ executable, then you should be fine. Of course, this breaks building shared libraries. I I intend to figure out what's going on.

I figured out what was broken... Working on a fix.

@lucaszanella There are some fixes in the latest develop branch. The README has also been updated to document cross-compiling for Android. Let me know if you have any questions. I apologize, I don't have a vested interest in cross-compiling for Android, so there may be issues beyond my basic test of just building Corrosion and the examples for Android.

Thank you.


When using the Sentry Native Integration, no Crash Dump is written

Environment
How do you use Sentry?
Sentry SaaS
Which version of the SDK?
0.8.0
Which version of Unreal?
5.2.1
Is this happening in Unreal (editor) or on a player like Android, iOS, Windows?
Cooked Windows Client
Steps to Reproduce

Disable the crash reporter and use the native Sentry integration

Expected Result
Crash Dump is written locally
Actual Result
No crash dump is available
Any logs or screenshots
N/A

@Edstub207 You mean that even though the Enable automatic crash capturing (Windows editor, UE 5.2+) option is enabled in settings and CrashReporter is turned off the crash captured by Sentry has no attachments (dump etc.)?
I've tried to reproduce this on my side with the plugin's sample project on Windows and UE 5.2 however the .dmp file gets uploaded to Sentry as expected in both cases when using CrashReporter / sentry-native. The only thing I've noticed is that dump files have different sizes (3.4 MB for native integration vs 640 Kb for CRC). Not sure if that's important detail though.

@tustanivsky sadly I'm now OOO/AFK for a week, if my memory serves correctly, we couldn't find any crash dumps on the local machine.
I believe the logs where still truncated, as per the other issue, however, i didn't check the crash dumps on the Sentry website.
As most crash dumps are written and uploaded as Minidumps there is no way to re parse them to Sentry afaik. So if any point of the Sentry flow fails, for whatever reason, we will not be able to track the crash wtihout it being local on the machine. Maybe it is on the local machine, but it's not in a location I'd normally expect. I didn't see it in the sentry-native folder either.
I'm also not sure if there are toggles on the Sentry Plugin side to write full dumps or how the dump process works with this new intergration.

As most crash dumps are written and uploaded as Minidumps there is no way to re parse them to Sentry afaik. So if any point of the Sentry flow fails, for whatever reason, we will not be able to track the crash wtihout it being local on the machine. Maybe it is on the local machine, but it's not in a location I'd normally expect. I didn't see it in the sentry-native folder either.

When sentry-native captures a crash the corresponding dump file can be found in <BuildDir>/<ProjectName>/.sentry-native/reports. If it's missing there then most likely native integration wasn't enabled.

I'm also not sure if there are toggles on the Sentry Plugin side to write full dumps or how the dump process works with this new integration.

No, there is nothing specific for dumps in plugin settings.

@tustanivsky I can confirm that we do have some crash dumps in the above folder as suggested. I've shared the new location with the team and will keep an eye on things.
Do you expect callstacks to be written in the logs as per the default Unreal implementation or is that no longer a thing?

Do you expect callstacks to be written in the logs as per the default Unreal implementation or is that no longer a thing?

We'll look at this in the scope of #336. Apparently, it should be possible to obtain callstacks from the default FGenericCrashContext object and if it is so attaching those to the captured event won't be a problem.

@Edstub207 Just a quick update on writing callstacks to logs when using the native integration for crash capturing - currently there is no way to extract them from the FGenericCrashContext object in order to bypass the aforementioned sentry-native limitations. Basically in order to make native integration work we're disabling SEH in Unreal and therefore it doesn't populate callstack info there at all.
Still, you should be able to view a call stack on the issue page if the debug symbols uploading was configured in the Sentry plugin's settings menu.

@tustanivsky Sadly we don't use the built in symbol upload method due to size limitations and also how long it takes.
For the most part our crashes do resolve, but we do get some that don't for whatever reason, which is what I want to try and avoid.
Do you see a situation where the callstack being in the logs would be possible?

Do you see a situation where the callstack being in the logs would be possible?

If uploading the debug symbols doesn't work for you then continuing using the crash reporter which writes callstacks to the log file might be a better option.
With native integration the only way to get a properly symbolicated callstack is to upload debug symbols to Sentry. sentry-native is capable of doing some on-device symbolication (sentry_options_set_symbolize_stacktraces) however it can have a performance impact and after some quick testing the results aren't always great in case with Unreal.
Closing this now since the original issue with the missing dump file seems to be resolved. Also, I believe the thing with missing callstacks is a separate issue described in #271.


Generated invalid address '1FYMZEHnszCHKTBdFZ2DLrUuk3dGwYKQxh'

Bug report
Operating System: windows 7 unlimited x64
MultiBit Version: 0.5.15
I'm generated more new addresses a few weeks ago in multibit. Оne of the addresses is 1FYMZEHnszCHKTBdFZ2DLrUuk3dGwYKQxh, Today i see payment to this adress 0.0098 btc. I can see in my wallet 0.0098 btc, but i can't export private key. How did it happen that I have address with payments? What should I do?

1HT7xU2Ngenf7D4yocz2SAcnNLW7rK8d4E


Use regular URL to generated documentation for input/random_payload_generator.py

Use regular URL (written in Markdown) to generated documentation for input/random_payload_generator.py

Fixed in https://github.com/RedHatInsights/insights-results-aggregator-utils/pull/261


Check orientations of ft sensors in the arms

With #22 we added the unit test that checks the ft sensors orientation.
Using the root-ftSensor transformation used for icub3 makes the test fail:
ergocub-model-test : transform between root_link and l_arm_ft_sensor is not the expected one, test failed.
ergocub-model-test : Expected transform : -0.267012 -0.961047 0.0713662
-0.960459 0.271447 0.0619303
-0.0788901 -0.0520081 -0.995526

ergocub-model-test : Actual transform : -0.250563 -0.961047 0.116648
-0.935113 0.271447 0.227771
-0.250563 -0.0520081 -0.966702

ergocub-model-test : base_link test performed correctly
ergocub-model-test : transform between root_link and r_arm_ft_sensor is not the expected one, test failed.
ergocub-model-test : Expected transform : -0.267012 0.961047 0.0713662
0.960459 0.271447 -0.0619303
-0.0788901 0.0520081 -0.995526

ergocub-model-test : Actual transform : -0.250563 0.961047 0.116648
0.935113 0.271447 -0.227771
-0.250563 0.0520081 -0.966702

If this discrepancy with icub3 is correct, we can ignore this issue and change the expected transformations in the unit tests reading them from the creo
cc @pattacini @traversaro @Mick3Lozzo @salvi-mattia @mfussi66

The discrepancy in the orientation is due to the fact that icub3 and ergocub mechanisms are saved with different joints configurations (shoulder_roll), then we can ignore this difference and make the test happy.


Add Source Chooser into grunt (from PR #374)

It looks like the source chooser feature was added in pull request #374, but it was never added to grunt. I believe this was an oversight as currently the demo page for mediaelementplayer-sourcechooser.html does not work.

Sorry for the delay. This does need to get copied over, but the implementation is pretty limited so I was attempting to leave it out of the core product for now.

@michaellindahl Thanks so much for spending time on this great PR. We really appreciate it. However I do not think this is something we want to add right now, per @johndyer's comment above but in the future this can change. Thanks so much!


How to create multiple technical indicator in main chart

How to create multiple technical indicator in main chart (candle_pane).
The createTechnicalIndicator is created 1 indicator at time.

createTechnicalIndicator(tech, true);

Thank a lot!


Do not ignore the result from celery tasks.

Coverage decreased (-0.0007%) to 92.974% when pulling 396735e7ef923a11244c3162d823e16831646193 on akatsoulas:celery-result into cf36d62249ba0bc3f91dc0b2355b8fe014091e48 on mozilla:master.

r+


Ignore inspector requests

Q
A

Is bugfix?
✔

New feature?
✔/❌

Breaks BC?
✔/❌

Fixed issues
comma-separated list of tickets # fixed by the PR, if any

AFAIR it's already there

I think you are confused with yii-debug config

AFAIR it's already there

I think you are confused with yii-debug config

You are right.


feat: add 'set_buffer_bytes' ext fn

This PR introduces the following changes:

Exposed new proxy function proxy_set_buffer_bytes which is implemented in other language SDKs for request/response rewrites.
Bumped assemblyscript from 0.21.3 -> 0.27.24

lgtm

cc @yuval-k

/test


fix(web) further fix to login flow

last fix stopped the user facing bug, but we were still calling connect twice and had some other unexpected behaviour around logout.

bors merge


Simplify Kokoro configs.

Change the configurations to set a single environment variable, and then
the script uses that to set the right combination of DISTRO,
DISTRO_VERSION, CMAKE_FLAGS, etc.

This change is

PTAL. I think this is a cleaner approach to managing the Kokoro+Docker builds.


Implement Item and Damage Type Classes for Void

Item and damage type classes for void versions of rogue, bard and healer weapons

These are intended to be used for making void weapons for the included damage types. I have an implementation for a rogue implementation of the platinum dart and gold chakram


Added base deployment directory for tracking cfde_client_config changes

I really do think the cfde_client_config.json should live in git somewhere, but I think it would be better suited to the action-provider codebase. That makes the cfde-submit client more streamlined, which is more ideal since it's the user-facing part of submissions.


Replaced precision and recall images

Linked issue(s):
What change does this PR introduce and why?
replaced precision and recall images
Please check if the PR fulfills these requirements

[ ] Include reference to internal ticket and/or GitHub issue "Fixes #NNNN" (if applicable)
[ ] Relevant tests for the changes have been added
[ ] Relevant docs have been added / updated

Congrats on your first PR @pvanburen 💪


Accessing attributes from BufferBuilder and FrameBufferTextureAttachmentSpec

We created a subclass of FrameBuffer and want to overwrite:
protected Texture createTexture (FrameBufferTextureAttachmentSpec attachmentSpec)

Since our class is not in the same package as FrameBufferTextureAttachmentSpec and BufferBuilder, we cannot access the attributes needed to create our custom texture (width, height, format). Public getter methods would help us to access these protected attributes.
We're using libgdx V. 1.9.8-Snapshot on Android and Windows.
Thanks in advance,
Christian

Can you provide an example for what it is you are trying to do by extending?

We need to get a pixmap from the framebuffer object and keep the resulting texture after disposing the framebuffer.
But meantime we found out, that there is no need to overwrite the createTexture(..) function anymore. Maybe caused by updating to V. 1.9.8-Snapshot. So extracting the texture works fine now.
Christian


Cop idea: Enforce stub_const so that dummy classes do not leak across tests

Bad
RSpec.describe 'define some module' do
  class SomeSacrificialClassForTesting
  end

  it 'knows about the sacrificial class' do
    expect(defined?(SomeSacrificialClassForTesting)).to_not be_nil # PASSES
  end
end

RSpec.describe 'a different example group' do
  it 'does not know about the sacrificial class' do
    expect(defined?(SomeSacrificialClassForTesting)).to be_nil # FAILS
  end
end

Good
RSpec.describe 'define some module' do
  before do
    stub_const('SomeSacrificialClassForTesting', Class.new)
  end

  it 'knows about the sacrificial class' do
    expect(defined?(SomeSacrificialClassForTesting)).to_not be_nil # PASSES
  end
end

RSpec.describe 'a different example group' do
  it 'does not know about the sacrificial class' do
    expect(defined?(SomeSacrificialClassForTesting)).to be_nil # PASSES
  end
end

This is definitely a good idea, but it appears to be a duplicate of: https://github.com/backus/rubocop-rspec/issues/197 (let me know if you disagree).
I'll close this issue in favor of the original for now. Thanks for the suggestion!

Ah. I tried searching for an existing issue, but couldn't find one. That one seems to cover it! Thanks, @dgollahon.


Simplify Let's Encrypt support

Description:
Allow to use webroot functionality of certbot and then automate certificate renewal.
Current procedure require to stop webserver, run certbot then restart
the webserver.
Instead, we can use the webroot fonctionnality of certbot like that:
certbot certonly --agree-tos --renew-by-default --webroot -w
PATH_TO_INSTALL/homeassistant/components/frontend/www_static/
-d home.xxxxx --email xxx@xxx
And then just reload webserver and thus avoid a down time

This is a great idea!
Disclaimer: I am not too familiar with the exact process
Doesn't certbot require port 80 to be accessible? But if we're running HA over SSL, it won't be able to communicate at port 80 because it is encrypted?

I completely forgot to share my apache conf, and I understand that it may looks strange to you like that...
To use HA as a subdomain, I've configured my apache such as request on 443 are redirected to HA
<VirtualHost *:443>
  ProxyPreserveHost On
  ProxyRequests Off
  ServerName BLABLA.HOST.org
  ProxyPass / http://localhost:8123/
  ProxyPassReverse / http://localhost:8123/
</VirtualHost>

This kind config avoid to enter the port number.
Using this conf and the above patch make certbot work using port 443

You don't need to stop hass while requesting a cert with
certbot certonly --standalone --standalone-supported-challenges http-01

You can keep port 80 forwarded, and this won't interfere with hass. Port 443 is forwarded to 8123. The problem with automatic renewal and certbot is root requirement to bind port 80. I think it's the same for 443. I you can use a custom higher port with another client, this should solve things.

I'm very sorry because I took my installation as a out of the box one but I
forgot that I use hass behind Apache as a proxy.
This is very convenient and help to have several services running on the
same host. E.g
Home.mathux.org serve hass
Gitlab.mathux.org serve gitlab
Contrysidehome.mathux.org another hass instance
Http to HTTPS redirection...
And so on...
Apache configuration to do so is described in my previous comment (and very
inspired by gitlab official one)
So again, very sorry, it's bit more than the normal setup :)
But many people that want to use hass in a existing server with other
services running may have a similar setup.
And this is where come the issue, certbot cannot be run is standalone mode
as Apache or nginx is already running on 80/443.
To avoid to shutdown those webserver (in order to run certbot), you can use
the webroot feature that just write the token In a given directory that
will be serve on the internet thanks to your webservice (hass here). In
this case you need this PR to serve the token.
All this is a bit complicated so may be, let me use another example.
You want to have hass running on port 80. This way you does not have to
enter port number with the URL.
You cannot use certbot in standalone mode as hass is already listening to
80.
With this PR you can use the webroot feature to have certbot working.
I hope this clarifies things.
Regards
Le 20 juin 2016 7:03 PM, "Martin Hjelmare"<EMAIL_ADDRESS>a
écrit :

You don't need to stop hass while requesting a cert with
certbot certonly --standalone --standalone-supported-challenges http-01
You can keep port 80 forwarded, and this won't interfere with hass. Port
443 is forwarded to 8123. The problem with automatic renewal and certbot is
root requirement to bind port 80. I think it's the same for 443. I you can
use a custom higher port with another client, this should solve things.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/home-assistant/home-assistant/pull/2341#issuecomment-227204041,
or mute the thread
https://github.com/notifications/unsubscribe/AAJE0D-dEfW9s1-SLvhf_64lapPCblL7ks5qNse1gaJpZM4I51qT
.

I get the use case for when Home Assistant is run behind apache or nginx. However, most people will not run Home Assistant like this. As it will only add support for an edge case that is not commonly used, I think it's better to not add this to the Home Assistant core.
However, you can just add this to a custom component and still have it be available for your setup.

Instead, if you want to add a description and how-to for your setup on the examples page on home-assistant.io, I think that would be appreciated.

@balloob The other example does not convince you either ? :)
Anyway, I completely understand your position and take a look a component.
@MartinHjelmare Looks like a good idea! It may interest people and give a reason to re-open this PR :D
Thanks for your time and interesting proposition guys!


Correcting the Spelling Mistake

I would like to contribute to this project by correcting the spelling mistake of medicines, Please assign this issue to me under GSSOC'24.

Assigning

Assigning

Thank You

Hey @Anishkagupta04 ,
I would like to fix the Typos. Kindly assign this issue to me under GSSOC'24 label.
Best Regards,
Ananya Rawat

@Anishkagupta04 I would like to work on this issue kindly assign it to me.

Assigning

@varshith257 Please assign.

Please assign this to me


Vhd16 ctq

Updating VHD images to 2016-Datacenter for as many templates as possible.

@asnarayan,
Thanks for your contribution.
To ensure that the project team has proper rights to use your work, please complete the Contribution License Agreement at https://cla.microsoft.com.
It will cover your contributions to all Microsoft-managed open source projects.
Thanks,
Microsoft Pull Request Bot


Fix minor typos

Thank you, lc0! I've funneled this through our internal version control and merged it into master with commit https://github.com/tensorflow/hub/commit/aa59e175bb2b5449f8c6544f25d164f375042b49.


Create .nvmrc for version v18.13.0

Able to use the proper Node version by simply running
nvm use

hm why is this required, we support node 16+


Add keyboard shortcut for starred messages

We should add a * keyboard shortcut to navigate to the starred messages view.
The shortcut should be documented in several places:

Tooltip in the left sidebar (similar to Inbox, etc.)
In the help menu, Keyboard shortcuts > Navigation. We can try putting it just below A.

Go to starred messages

https://zulip.com/help/keyboard-shortcuts, matching the text and placement above.
Add a keyboard tip to the https://zulip.com/help/star-a-message#view-your-starred-messages Desktop/Web instructions:

Use * to view your starred messages.

CZO thread

@zulipbot claim


Couldn't run example-audio on iOs emulator without a path modification

In www/js/controllers.js we can see
var urlprefix = '/android_asset/www/audio/';
When I ran "ionic emulate ios" the audio files couldn't be found.
I could make it work using
var urlprefix = 'audio/';
I don't see how to make it to make it work in both cases yet.

Yes, the local folders in Android and iOS are different. If you are playing local audio you need to set the path accordingly using ionic.Platform to detect the platform
http://ionicframework.com/docs/api/utility/ionic.Platform/


Trying to use Conv nets with the knifey dataset

I'm trying to train the neural network in tutorial 02 from @Hvass-Labs  using the knifey dataset. All is fine until I try to run a modified version of the print_test_accuracy() function.
In the while loop, images and labels are loaded correctly but when it tries to run the session to predict the result, everything crashes and the python kernel has to be restarted.
I modified placeholder x to have the following shape:
x = tf.placeholder(tf.float32, shape=[None, img_height, img_width, num_channels], name='x')
Could you please help me understand what am I doing wrong?
I pasted the modified print_test_accuracy() function below.
Thanks a lot for you help,
`# Split the test-set into smaller batches of this size.
test_batch_size = 64
def print_test_accuracy(show_example_errors=False,
show_confusion_matrix=False):
# Number of images in the test-set.
num_test = len(image_paths_test)

# Allocate an array for the predicted classes which
# will be calculated in batches and filled into this array.
cls_pred = np.zeros(shape=num_test, dtype=np.int)

# Now calculate the predicted classes for the batches.
# We will just iterate through all the batches.
# There might be a more clever and Pythonic way of doing this.

# The starting index for the next batch is denoted i.
i = 0

while i < num_test:
    # The ending index for the next batch is denoted j.
    j = min(i + test_batch_size, num_test)

    # Get the images from the test-set between index i and j.
    images = load_images(image_paths=image_paths_test[i:j])

    # Get the associated labels.
    labels = labels_test[i:j]

    # Create a feed-dict with these images and labels.
    feed_dict = {x: images, y_true: labels}

    # Calculate the predicted class using TensorFlow.
    cls_pred[i:j] = session.run(y_pred_cls, feed_dict=feed_dict)

    # Set the start-index for the next batch to the
    # end-index of the current batch.
    i = j

# Convenience variable for the true class-numbers of the test-set.
cls_true = test_classes

# Create a boolean array whether each image is correctly classified.
correct = (cls_true == cls_pred)

# Calculate the number of correctly classified images.
# When summing a boolean array, False means 0 and True means 1.
correct_sum = correct.sum()

# Classification accuracy is the number of correctly classified
# images divided by the total number of images in the test-set.
acc = float(correct_sum) / num_test

# Print the accuracy.
msg = "Accuracy on Test-Set: {0:.1%} ({1} / {2})"
print(msg.format(acc, correct_sum, num_test))

# Plot some examples of mis-classifications, if desired.
if show_example_errors:
    print("Example errors:")
    plot_example_errors(cls_pred=cls_pred, correct=correct)

# Plot the confusion matrix, if desired.
if show_confusion_matrix:
    print("Confusion Matrix:")
    plot_confusion_matrix(cls_pred=cls_pred) `

In general I cannot answer questions like this, because it would simply take too much of my time if I had to help everyone who tried to mod my code and got an error somewhere. People expect too much of me. You also don't even print the error message here so it is impossible to say what might be the problem. I would suggest that you first google search for the error-codes, then try adding lots of print statements until you find the problem. Then please complete this thread you opened by writing the full error-message and the solution you found, so it may help others in the future. When you're done please close the thread.

Excellent. Thanks


Auto-size visual output to fit on screen

using whichever dimension (height or width) is the constraining one

[ ] Make sure screenshot output still works

[ ] Make sure screenshot output still works


chore(main): release 2.0.2

:robot: I have created a release beep boop
2.0.2 (2022-12-20)
Bug Fixes

fixed build script typo (fbb57e3)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/flowcore-io/library-flowcore-microservice-ts/releases/tag/v2.0.2 :sunflower:


GPIO page issue:

@ArthurSonzogni There's a minor issue in the UI.
In the GPIO menu, whenever I select the lower GPIO menu it just takes a lot of time before I can select from the page.
Example:

Originally posted by @SAtacker in https://github.com/SAtacker/beagle-config/issues/30#issuecomment-895482381

I am assuming that the parent component's are causing this.

    Add(Container::Tab(
        {
            gpio_menu,
            gpio_individual,
        },
        &tab));

Clearly this is a mistake

I have added a commit that fixes it


[CREATE MEASURES V2] XML related updates

THIS PR COVERS:
Addition of mechanism of XML message id assignment for each creating database record (so that we can keep proper order of creation of records in XML export output)
TRELLO CARD

 [DIT] Create measures - iteration


fix: typo in readme file

Ah, neat, thanks for filing, but I just merged another PR that fixes this! Thanks anyway!
https://github.com/google/typograms/pull/1


Send a message to all my friends will block by account?

Hi,
This is not really an issue with fbchat, just a question I would like to know from your experience working with fbchat. I want to send a message to all my friends (a few hundred).  Do you know if there is a good possibility that my account will be blocked by facebook, due to spam?
I was thinking of send perhaps the message to 20 friends every 10 seconds.

As far as I know FB is very strict with mass messages. So chance is high your activity can be seen as suspicious and may be some approval will be asked from FB that you are human.

I am investigating the same thing @miguelwon is trying to do. I am not really concerned about being classified as spam as it the number of messages/time will be very low. But I am wondering how to even get a list of all friends - which does read very differently than what fetchAllUsers does.
Is that even possible with fbchat?

Update on this: I have tried to send a message at a rate of one each 10s and after around 70 messages, FB "blocked" me, i.e., it requested an "I'm not a robot" proof before sending a new message.
About the fetchAllUsers. It returns only the friends of which you exchanged a message in the past. Is not all friends but near because each time a new friendship is accepted a small automatic message is sent through messenger.

@miguelwon Aren't those automatic messages a "newer" thing? So very old contacts won't be included? At least I don't think it was like that from the beginning. Would be nice to reach all.

@tcurdt, see https://github.com/carpedm20/fbchat/issues/282, I'm not really sure, but I don't actually think we ended up fixing the issue 😕

That's a shame - but thanks for the pointer. Thanks, @madsmtm.

I just tried and I was just listing my friends. I called the script 3 times and my account got temporarily suspended (eeek!) After changing the password fb was happy again. They detected "unusual activity". I guess this raises the question how to avoid this.
For one I forgot to logout in the script - which may or may not be a problem. On the other hand I assume that too frequent logins are more a problem than missing logouts.
I also noticed that the reported browser was different for all detected logins.
Maybe it would make sense to set the browser agent to something fix and "unsuspicious" and retain a single session? Any thoughts?

Are you using cookies sessions? If not that may be the reason. I had a similar issue because I was trying to log in many different sessions in a short period of time. You should log in once, save the session and the log in again but with the same cookies:
session_cookies = client.getSession()
client = Client('<email>', '<password>', session_cookies=session_cookies)

Even with this facebook complains if the login is made from a location it never saw before. For this case, after you set the new password and check it's you that is trying to log in, you should wait a few hours to log in again from that remote location.

@miguelwon I guess that's what I am after then. Thanks.
I used the code from the examples - which probably should be adjusted then.

From a logical point of view - shouldn't something like this be enough then?
client = Client(session_cookies=session_cookies)

If there is already the login stored in the cookies - why the username and password?

@tcurdt, because if the session cookies are invalid / outdated, the client will attempt to login instead 😉

Even with this facebook complains if the login is made from a location it never saw before. For this case, after you set the new password and check it's you that is trying to log in, you should wait a few hours to log in again from that remote location.

this is my situation, I want to setup an email-messenger bridge, but the bot is in a remote server in another country, @madsmtm there are a way to confirm it is me with fbchat? like sending the verification code, since I can't manually access facebook from the remote server,
Thanks in advance

@adbenitez I've used my remote server as VPN by SSH (with PuTTy) and from my computer logged into Facebook with this VPN. Weird, but works.

@kapi2289, yes tis is really weird, since I asked to a friend in Spain to create a test account and I was able to login here in my country with that account, but with other 2 test accounts created in my country and trying to login from Spain it ask for verification  by confirming from other logged device or by identifying friends pictures.
This works similar to 2FA so maybe it can be implemented in fbchat, the url is also m.facebook.com/checkpoint

@kapi2289 also, you logged in with your browser with cookies/session already salved? then it makes sense that it works for you

I've used my remote server's VPN to create and log into the account, and then I could use this account on this remote server. Or previously I was installing desktop browser on the remote server and I was doing it from there, but that's not the best idea :sweat_smile:

well, an easy workaround I had found for this "location/device changed" issue is to enable 2FA for the accounts
Sent from my Android device with K-9 Mail. Please excuse my brevity.


Introduce the "plugins group" concept

Per discussion with @alfsuse
We need to introduce the plugins group.
In this way, we can define a set of plugins to deploy together.
For example:

minimal pipelines group --> installs kubeflow pipelines and kfp sdk
jupyter pipelines --> installs jupyter and kubeflow

etc....
We will define some plugins group on the plugin repo by default.
The user must be able also to create its own local plugins group file.
As always I'd use a YAML file, something like:
plugin-type: group
plugins:
    - pipelines
    - jupyter

etc...

What other plugin-types can be there?

I was thinking to add:

plugin-type: standard
plugin-type: group

so we leave the plugin spec opens for future plugin types