Paket should detect an unsolvable conflict sooner

Given a dependency file that contains FSharp.Core pinned to <IP_ADDRESS> and LiteDB.FSharp (which needs 4.2.3), Paket keeps looking to find a resolution by checking all other packages in the dependencies file e.g. FAKE, Argu etc. etc. - when in reality the resolution can never work because of these incompatible packages

Dependencies file requested package FSharp.Core: <IP_ADDRESS>
LiteDB.FSharp 0.1.0 requested package FSharp.Core: >= 4.2.3

e.g. in the output, I see:
The process is taking longer than expected.
Paket may still find a valid resolution, but this might take a while.
 - FAKE 5.1.0
 - FAKE 5.0.0
 - FAKE 4.64.13
 - FAKE 4.64.12
 - FAKE 4.64.11
 - FAKE 4.64.10
 - FAKE 4.64.9
 - FAKE 4.64.6
 - FAKE 4.64.5
 - FAKE 4.64.4
 - FAKE 4.64.3
 - FAKE 4.64.2
 - FAKE 4.64.1
     FAKE 4.64.1 was unlisted
 - FAKE 4.63.2
 - FAKE 4.63.1
 - FAKE 4.63.0
 - FAKE 4.62.6
 - FAKE 4.62.5
 - FAKE 4.62.4
 - FAKE 4.62.3
 - FAKE 4.62.2
 - FAKE 4.62.1
 - FAKE 4.62.0
 - FAKE 4.61.3
 - FAKE 4.61.2
 - FAKE 4.61.1
 - FAKE 4.61.0
 - FAKE 4.60.0
  Conflict detected:
   - Dependencies file requested package FSharp.Core: <IP_ADDRESS>
   - LiteDB.FSharp 0.1.0 requested package FSharp.Core: >= 4.2.3
   - Argu 5.1.0 requested package FSharp.Core: >= <IP_ADDRESS>

It goes all the way back in time through every version of FAKE on nuget to "prove" that the resolution can't work.

This issue appears to have been fixed.
Paket version 7.1.5+e2fe7c693356a5e70a74cc01501f7dc5f8996695
Resolving dependency graph...
 - FSharp.Core is pinned to <IP_ADDRESS>
Total time taken: 5 seconds
Paket failed with
-> There was a version conflict during package resolution.
     Resolved packages:
      - FSharp.Core <IP_ADDRESS>
     Conflict detected:
      - Dependencies file requested package FSharp.Core: <IP_ADDRESS>
      - LiteDB.FSharp 0.1.0 requested package FSharp.Core: >= 4.2.3

     Please try to relax some conditions or resolve the conflict manually (see http://fsprojects.github.io/Paket/nuget-dependencies.html#Use-exactly-this-version-constraint).


Update components.yaml

components.yaml was a bit behind the externals files. Bringing this up-to-date

Note to @pchakraborty, I added some of the develop: fields/lines/whatever-that's-called-in-yaml. Did I do it right?

Also pinging @sdrabenh so he can hear anything.

@mathomp4 Looks right.


MFX-1079 - Implement multi-protocol relay for MQTT

Pull request title should be MF-XXX - description or NOISSUE - description where XXX is ID of issue that this PR relate to.
Please review the CONTRIBUTING.md file for detailed contributing guidelines.
What does this do?
Implements multi-protocol relay for MQTT. Part of the MQTT adapter, this code subscribes to NATS, gets every message and if it comes from some other protocol (for example HTTP), then it forwards it directly to MQTT broker behind (VerneMQ) to be distributed to all MQTT subscribers.
Which issue(s) does this PR fix/relate to?
Resolves #1079
List any changes that modify/break current functionality
Have you included tests for your changes?
Did you document any new/modified functionality?
Notes

Replaced by https://github.com/mainflux/mainflux/pull/1164


Video Download Timestamp

Hello,
Thanks for developing this app! I installed the desktop version 0.1.6 and it is working flawlessly on my W10 desktop.  Nice job!
Only question I have regarding the app is the timestamp imbedded in the video name for the downloaded Blink videos is 5 hours latter than the actual video on my Blink cameras. Is there any parameter setting I can use to correct this?

Thanks! I am working on it, will post again with new version.

Version 0.1.10 now includes your request. You have to download, install it and then go to configuration file
%userprofile%\Bling.exe\Blink.ini
Edit it and add UseLocalTime=true in SyncVideo section as follows
[SyncVideo]
UseLocalTime=true
Setting this option will save videos using the computer's timezone. I could not use Blink's timezone as they do not have this information directly stored in their API but I imagine computer's timezone is OK.
I cannot put this feature as the default one as other users are already using it with the current universal time.

Thanks for the enhancement. I downloaded what I thought was the latest version to test the enhancement but I keep getting Desktop versioni <IP_ADDRESS> instead of 10. Even tried uninstall/reinstall to no avail. Any help would be appreciated.

Additional info to my comment from yesterday. Version is still showing as <IP_ADDRESS>. Not sure what changed from yesterday but the file download naming process using UserLocalTime=true is working perfectly now. I see the name is now date and timestamp which is perfect. Thanks for your help. This makes it very easy to associate the videos on the mobile app and the desktop app. Thanks again.

Yes, I forgot to update version number when I generated new release. You
already have last version. Happy to help!!
El jue., 2 may. 2019 15:44, c4329<EMAIL_ADDRESS>escribió:

Additional info to my comment from yesterday. Version is still showing as
<IP_ADDRESS>. Not sure what changed from yesterday but the file download naming
process using UserLocalTime=true is working perfectly now. I see the name
is now date and timestamp which is perfect. Thanks for your help. This
makes it very easy to associate the videos on the mobile app and the
desktop app. Thanks again.
[image: Capture]
https://user-images.githubusercontent.com/49692955/57079502-12657f00-6cb6-11e9-8514-167e2162557e.JPG
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/lurume84/bling-desktop/issues/9#issuecomment-488678743,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAGB5TPTITJBGM322Y5HWG3PTLV2RANCNFSM4HGUKZDA
.


Add button not available in certain scenarios

I'm guessing it's when continuous deployment is setup. Could also be because I'm using precompiled functions Please add a clarification to the documentation.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: c59024a4-9208-9b00-43ee-f6ba936c95a6
Version Independent ID: 5ac7705c-35e3-b211-ebba-3798dd949409
Content: Work with proxies in Azure Functions
Content Source: articles/azure-functions/functions-proxies.md
Service: functions
GitHub Login: @alexkarcher-msft
Microsoft Alias: alkarche

@hannesne Thanks for the feedback! I have assigned the issue to the content author to evaluate and update as appropriate.

This has been fixed by UX changes
#please-close


docs(webpack): add webpack3 boilerplate with theming

Rel #1636.
This PR adds the missed information about theming and adds the real boilerplate 😺
Boilerplate features

preconfigured theming
CSS modules for user components
hot module reload
optimized build (automatic direct imports, proptypes removal)

@brianespinosa @levithomason It will be awesome to get feedback from you there. Grammar fixes is much appreciated 😸

Codecov Report

Merging #2371 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2371   +/-   ##
=======================================
  Coverage   99.73%   99.73%
=======================================
  Files         152      152
  Lines        2661     2661
=======================================
  Hits         2654     2654
  Misses          7        7

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 36fd4a7...a3029f5. Read the comment docs.

Very cool, thanks for this!  I'm just wrapping my session for today.  I want to give this PR the attention it deserves, so that may come at a later date. ❤

I saw that we are also using the beta version of babel-loader and @babel. Is this for JSX fragments? I try to stay away from beta releases on packages if I can avoid it.

Babel 7 is much faster and enough stable now. I'm use it in my project last few weeks and I really like it.
I almost sure that it will be released soon as stable and it makes no sence to make bet on Babel 6 now to me.

Looks like we have approvals here. In the future @layershifter, if you get multiple approvals and are confident, please feel free to merge without me. I don't want to hinder progress and I have trust for everyone we're adding to the team.
/cc @brianespinosa @fracmak
Note, @layershifter has been here a long time and has master merge rights. I control releases, but anything that makes it to master will make the next release cycle.

Looks a bad merge on this guy. Build is failing. Might need to roll it back, or make a fix PR. See master on CircleCI.

It's a long term problem with tests:

FAILED TESTS:
✖ "after each" hook
HeadlessChrome 0.0.0 (Linux 0.0.0)
Error: Uncaught RangeError: Maximum call stack size exceeded (src/lib/index.js?504b:178:0

I can't to find out the reason locally, very strange issue.

Random intermittent failure I suppose.  Thanks.

Released in<EMAIL_ADDRESS>


no HA parameter

Hi,
on the configuration page of the Add On, I don't have the options to enter the token and the URL of HA
I've tried to reinstall the addd on but no success...
can you help please?

The tutorial was out of dated. The old version addon needs it (current version don't).
https://github.com/CoolKit-Technologies/ha-addon/issues/76

@CooLajz ok thanks, but still the Devices List remain empty with a message "Get device list failed"

I agree. I have the same problem, nothing loads with same message.


CET menu won't pull up after a short time of game running

likewise, tap to (un)holser via advanced control ceases to function, frequently. getting it to work at all this quickly after a major patch with significant changes to core game files is impressive; keep being amazing!
EDIT: using toggle walk key makes it work again

Noone seems to be reporting sth like this outside you so I would probably blame some mod you use. If you can repro this with clean CET (that is nuking mods folder inside cyber_engine_tweaks), feel free to reopen.


java.lang.NoClassDefFoundError: Could not initialize class org.apache.http.conn.ssl.SSLConnectionSocketFactory

I have an Executor that handles new simple threads which check for sms delivery.
Normally this works just fine but sometimes i get:
java.lang.NoClassDefFoundError: Could not initialize class org.apache.http.conn.ssl.SSLConnectionSocketFactory
without any other errors. This continues for hours; all new threads fail with the same error. Then at some point the errors stop and new threads function normally. Here is part of the stack trace and the code that triggers the exception:
Exception:
... SmsDeliveryCheckRunner error
java.lang.NoClassDefFoundError: Could not initialize class org.apache.http.conn.ssl.SSLConnectionSocketFactory
	at kong.unirest.apache.SecurityConfig.createDefaultRegistry(SecurityConfig.java:85)
	at kong.unirest.apache.SecurityConfig.buildSocketFactory(SecurityConfig.java:75)
	at kong.unirest.apache.SecurityConfig.createManager(SecurityConfig.java:59)
	at kong.unirest.apache.ApacheClient.<init>(ApacheClient.java:54)
	at kong.unirest.Config.buildClient(Config.java:709)
	at kong.unirest.Config.getClient(Config.java:694)
	at kong.unirest.BaseRequest.asString(BaseRequest.java:208)
	...my code...

Code:
HttpResponse<String> httpResponse = Unirest.post( SERVICE_URL )
  .header("Accept", "application/json")
  .header("Accept-Charset", _encoding)
  .header("Content-Type", CONTENT_TYPE)
  .header("Authorization", "Basic " + getApikey())
  .body( request )
  .asString();

In my classpath i have:
unirest-java-3.11.00.jar
httpmime-4.5.12.jar
httpcore-nio-4.4.13.jar
httpcore-4.4.13.jar
httpclient-4.5.12.jar
httpasyncclient-4.1.4.jar
commons-net-3.6.jar
commons-logging-1.2.jar
gson-2.8.6.jar
commons-codec-1.15.jar

It's possible you have two different versions of SSLConnectionSocketFactory on the class path and that the JVM is grabbing the "wrong" one some of the time.

Are you using https?

yes!

It's possible you have two different versions of SSLConnectionSocketFactory on the class path and that the JVM is grabbing the "wrong" one some of the time.

OMG this could be a nightmare to debug and i would do not even know how to approach this. Any tools that can search and find the class in question in classpath? I have quite a few dependencies...

When you do a package with maven, there will be warnings about duplicate package/class's coming from different jars. That will tell you that your package has a conflict directly. Sometimes deployed runtimes can also have classes. Like if you are deploying to a stand alone (not embedded) tomcat for example.
If could also be that your JVM is just messed up. note that the doc for the exception says:
Thrown if the Java Virtual Machine or a ClassLoader instance tries to load in the definition of a class (as part of a normal method call or as part of creating a new instance using the new expression) and no definition of the class could be found.
The searched-for class definition existed when the currently executing class was compiled, but the definition can no longer be found.

I used classgraph tool to clean up some jar hell mainly with JTA which was a couple of times in my classpath. But there were no duplicates for org.apache.http.conn.ssl.SSLConnectionSocketFactory! Anyway, i updated to latest version of unirest-java and will be monitoring if this issue appears again. It may take some months to be sure...

I think it's really hard to know here, these are JVM errors, not really a functional problem with unirest (IMHO), for some reason you are losing the class, one concern I have is that you are getting this error at some point after the system has been running. The init of this class happens during the init of the unirest config, which is kind of heavy thing in 3, because there are complex Apache configurations made as well as monitoring threads. Ideally this should be done once for a instance of unirest, and then left, if you are doing  something to invalidate the config it would force this to happen again, and doing that a LOT would be bad. Look for where you might be messing with .config() and then, move that to happen once per JVM lifecycle.

Yes, the shutdown would cause a re-init IF Unirest is invoked after it, not sure how that would happen after a JVM shutdown though.  BTW, the RC versions of unirest don't even have this class or Apache as a dependency. You do have to be on at least Java 9 for it (but of course we are all on at least Java 11 now that 8 is no longer supported right :D)

I have to stick with old good java 8 for now...
unlucky me or is there something else i can do?


can't append anyone sftp server

When append a sftp will issue the error of failed to authenciation, In fact, connet to the host by ssh is ok.
I try 3~4 hosts with same error.

did you confirm the ssh connection?
Is it server log?

Server listening on :: port 22.
Oct 29 16:34:32 fb_fyoa sshd[571]: Server listening on <IP_ADDRESS> port 22.
Oct 29 16:42:11 fb_fyoa sshd[640]: Connection from <IP_ADDRESS> port 58316 on <IP_ADDRESS> port 22
Oct 29 16:42:20 fb_fyoa sshd[640]: Accepted password for limux from <IP_ADDRESS> port 58316 ssh2
Oct 29 16:42:20 fb_fyoa sshd[640]: User child is on pid 642
Oct 29 16:42:20 fb_fyoa sshd[642]: Starting session: shell on pts/0 for limux from <IP_ADDRESS> port 58316
This is server log when connection use ssh.

This is connection to <IP_ADDRESS> by Brackets.

ah ic, that problem is not connection. error message wrong.
Synapse got file list on the current directory after connected to the server.
perhaps, error occured when requested LIST command to the server.
The error log It is not something that lasts?
like a "error occured when read the directory"

After restart Brackets with do nothing, and set the synapse to connection at once, then there will reports one info of "Initialized completed successfully" and one error of "failed to authentication, please confirm your server setting." and one error of "failed to authentication, please confirm your account setting."
That's all.

I see, so please tell me the synapse's version?
and the developer tools said  what?

the latest 1.2.87

now 1.2.88
but the version on top of the ext panel, that will change when reboot brackets after update

That issue perhaps is the bug of brackets. May be I missed some very importent messages to comment.
I made a try on the mac, thers is no this issue. the Synapse connetted to the sftp server successfully. In another word, the issue is only found on win or exactly win7.
Look at the following picture:

Great to your so fast fix and the very nice Synapse.

Thx for the feedback.
hmm I see, I'll try for reproduce on Win7.
So, if that occurred some error again.
please visit here. thx.


Helm edits

Fixes for #925 . Just a heads up, a lot of the changes requested in the issue were already fixed as I worked on other issues.


kog patch 34

Added a check to import all viable backgrounds (that contain "background" in the file name) with also future implications for error logging, which resolves #411
Put rendering backgrounds in Hubzones under a conditional, meaning all Hubzones (and subsequently levels) are accessible. When no background is present for that Hub, it won't try rendering backgrounds, which resolves #410

lloooks good


Support division operation

Also un-comment some test bench in driver.sh

Not all ARMv7-A core supports sdiv and udiv instructions. See https://patchwork.kernel.org/patch/1494331/
The CPU models such as cortex-a8 and cortex-a9 lack of sdiv/udiv instructions.  Also, you can send another pull request to enforce cortex-a7 support by modifying file mk/arm.mk with -cpu cortex-a7. In addition, the top-level README.md should be updated accordingly.

each ARMv7-A core supports sdiv and udiv instructions

commit message update!

Should be "Division operation" rather than "divide operation"

Thank @eecheng87 for contributing!


Compacted SST file reappears in region

What type of bug is this?
Unexpected error
What subsystems are affected?
Datanode
What happened?
pod_name：greptimedb-frontend-5db6cc4db4-2sgpm
pod_namespace：greptimedb
message：2023-07-14T08:35:21.681888Z ERROR client::database: Failed to do Flight get, addr: greptimedb-datanode-0.greptimedb-datanode.greptimedb:4001, code: Internal error, source: Failed to do Flight get, code: Internal error, source: NotFound (persistent) at read, context: { response: Parts { status: 404, version: HTTP/1.1, headers: {"x-amz-request-id": "[...]", "x-amz-id-2": "[...]", "x-amz-delete-marker": "true", "x-amz-version-id": "[...]", "content-type": "application/xml", "transfer-encoding": "chunked", "date": "Fri, 14 Jul 2023 08:35:21 GMT", "server": "AmazonS3"} }, service: s3, path: data/[...]/public/1968/1968_0000000000/4caac3ad-4ad7-4b3b-8a97-f00b39bfe57a.parquet, range: 0- } => S3Error { code: "NoSuchKey", message: "The specified key does not exist.", resource: "", request_id: "RG8E0ZM8E94P029B" }
Datanode logs:
root@greptimedb-datanode-0:/# grep -rF 4caac3ad-4ad7-4b3b-8a97-f00b39bfe57a

# The SST file [4caac3ad-4ad7-4b3b-8a97-f00b39bfe57a ] was created
/tmp/greptimedb/logs/greptime-datanode.2023-07-08-14:{"v":0,"name":"greptime-datanode","msg":"Successfully flush memtables, region:8452495638528, files: [FileId(4caac3ad-4ad7-4b3b-8a97-f00b39bfe57a)]","level":30,"hostname":"greptimedb-datanode-0","pid":1,"time":"2023-07-08T14:47:31.85146213Z","target":"storage::flush","line":305,"file":"greptimedb/src/storage/src/flush.rs"}

# [4caac3ad-4ad7-4b3b-8a97-f00b39bfe57a] being compacted
/tmp/greptimedb/logs/greptime-datanode.2023-07-08-19:{"v":0,"name":"greptime-datanode","msg":"Compacting SST files, input: [FileId(101a7479-4666-4bc9-9996-f709e5352eb4), FileId(92c5b2c3-4001-48be-b9b0-fe40ac7a4327), FileId(b2f0e5fc-c798-4e90-ae85-aaa22e3a18bc), FileId(4caac3ad-4ad7-4b3b-8a97-f00b39bfe57a), FileId(9a2562e6-df9d-4d85-b363-199b15445a8e), FileId(f8e8a2e6-6894-419c-8ab7-6bb24d6ed5d6), FileId(ce692d00-7434-44ae-a144-091abfefb96c), FileId(13f0465a-f3b2-4db1-81a0-d4d48d0a29e2), FileId(680d04ff-8e53-4bc0-a8fa-cfc09e024db6)], output: [FileId(a5511947-1946-4711-86f4-6ef56051d3d5)], window: Some(604800)","level":30,"hostname":"greptimedb-datanode-0","pid":1,"time":"2023-07-08T19:38:57.200354659Z","target":"storage::compaction::task","line":154,"file":"greptimedb/src/storage/src/compaction/task.rs"}

# [4caac3ad-4ad7-4b3b-8a97-f00b39bfe57a] was deleted (file purge task was submitted)
/tmp/greptimedb/logs/greptime-datanode.2023-07-08-19:{"v":0,"name":"greptime-datanode","msg":"Submitted task: \"8452495638528/4caac3ad-4ad7-4b3b-8a97-f00b39bfe57a\"","level":30,"hostname":"greptimedb-datanode-0","pid":1,"time":"2023-07-08T19:38:57.306224808Z","target":"storage::scheduler","line":267,"file":"greptimedb/src/storage/src/scheduler.rs"}

# And after a week, file [4caac3ad-4ad7-4b3b-8a97-f00b39bfe57a] reappeared in regions's file list and the region found it can be compacted
/tmp/greptimedb/logs/greptime-datanode.2023-07-14-02:{"v":0,"name":"greptime-datanode","msg":"Compaction output [13f0465a-f3b2-4db1-81a0-d4d48d0a29e2,ce692d00-7434-44ae-a144-091abfefb96c,680d04ff-8e53-4bc0-a8fa-cfc09e024db6,101a7479-4666-4bc9-9996-f709e5352eb4,f8e8a2e6-6894-419c-8ab7-6bb24d6ed5d6,4caac3ad-4ad7-4b3b-8a97-f00b39bfe57a,9a2562e6-df9d-4d85-b363-199b15445a8e,b2f0e5fc-c798-4e90-ae85-aaa22e3a18bc]-> 3476ecbc-9e90-46f8-940e-aa36d3deb1ad","level":30,"hostname":"greptimedb-datanode-0","pid":1,"time":"2023-07-14T02:49:08.761007994Z","target":"storage::compaction::task","line":84,"file":"greptimedb/src/storage/src/compaction/task.rs"}

/tmp/greptimedb/logs/greptime-datanode.2023-07-14-04:{"v":0,"name":"greptime-datanode","msg":"Compaction output [4caac3ad-4ad7-4b3b-8a97-f00b39bfe57a,9a2562e6-df9d-4d85-b363-199b15445a8e,f8e8a2e6-6894-419c-8ab7-6bb24d6ed5d6,13f0465a-f3b2-4db1-81a0-d4d48d0a29e2,101a7479-4666-4bc9-9996-f709e5352eb4,b2f0e5fc-c798-4e90-ae85-aaa22e3a18bc,680d04ff-8e53-4bc0-a8fa-cfc09e024db6,ce692d00-7434-44ae-a144-091abfefb96c]-> 2302dc53-69e4-478a-a26f-b8666187865e","level":30,"hostname":"greptimedb-datanode-0","pid":1,"time":"2023-07-14T04:07:24.5846269Z","target":"storage::compaction::task","line":84,"file":"greptimedb/src/storage/src/compaction/task.rs"}

/tmp/greptimedb/logs/greptime-datanode.2023-07-14-04:{"v":0,"name":"greptime-datanode","msg":"Failed to compact region: 1968_0000000000","level":50,"hostname":"greptimedb-datanode-0","pid":1,"time":"2023-07-14T04:07:25.448327862Z","target":"storage::compaction::task","line":165,"file":"greptimedb/src/storage/src/compaction/task.rs","err.msg":"Fail to read object from path: data/.../public/1968/1968_0000000000/4caac3ad-4ad7-4b3b-8a97-f00b39bfe57a.parquet, source: NotFound (persistent) at read, context: { response: Parts { status: 404, version: HTTP/1.1, headers: {...}, service: s3, path: data/etox4eivxxv2helpless_credit/public/1968/1968_0000000000/4caac3ad-4ad7-4b3b-8a97-f00b39bfe57a.parquet, range: 0- } => S3Error { code: \"NoSuchKey\", message: \"The specified key does not exist.\", resource: \"\", request_id: \"Y6MP5QSDD6DXMT6N\" }","err.code":"StorageUnavailable","err.source":"NotFound (persistent) at read, context: { response: Parts { status: 404, version: HTTP/1.1, headers: {...} }, service: s3, path: data/etox4eivxxv2helpless_credit/public/1968/1968_0000000000/4caac3ad-4ad7-4b3b-8a97-f00b39bfe57a.parquet, range: 0- } => S3Error { code: \"NoSuchKey\", message: \"The specified key does not exist.\", resource: \"\", request_id: \"Y6MP5QSDD6DXMT6N\" }"}

Looks like the compacted SST file 4caac3ad-4ad7-4b3b-8a97-f00b39bfe57a is deleted, but after a week, it reappears in region's SST file list.
What operating system did you use?
NA
Relevant log output and stack trace
No response
How can we reproduce the bug?
NA

We suspect it may related to some checkpoint issue:
/tmp/greptimedb/logs/greptime-datanode.2023-07-17-06:{"v":0,"name":"greptime-datanode","msg":"Region manifest checkpoint, start_version: 211, last_version: 253, compacted actions: 43","level":30,"hostname":"greptimedb-datanode-0","pid":1,"time":"2023-07-17T06:42:19.21837659Z","target":"storage::manifest::region","line":138,"file":"greptimedb/src/storage/src/manifest/region.rs"}
/tmp/greptimedb/logs/greptime-datanode.2023-07-17-07:{"v":0,"name":"greptime-datanode","msg":"Region manifest checkpoint, start_version: 211, last_version: 254, compacted actions: 1","level":30,"hostname":"greptimedb-datanode-0","pid":1,"time":"2023-07-17T07:50:54.588092373Z","target":"storage::manifest::region","line":138,"file":"greptimedb/src/storage/src/manifest/region.rs"}

We can see two checkpoint ran with same start_version 211.

The reason of this bug is the dirty _last_checkpoint opendal cache causing the checkpoint read has another start_version.
The previous checkpoint deleted all actions between 211~253, while the latter checkpoint losts these actions, which includes those removing SST files.

This issue is duplicated to https://github.com/GreptimeTeam/greptimedb/issues/2746
We already added a flag in https://github.com/GreptimeTeam/greptimedb/pull/2745 to workaround corrupted manifests.


Avoiding permissions issue for docker.sock

Proposed changes
Added a fix/workaround to the socket permissions issue. Inspired by this answer https://www.digitalocean.com/community/questions/how-to-fix-docker-got-permission-denied-while-trying-to-connect-to-the-docker-daemon-socket?answer=55491
Related issues (optional)
Migt be related to #9697, but was done on Ubuntu.

Deploy preview for docsdocker ready!
Built with commit b64f0b2b0156e245aaf4d6fd9cab28e875f2689d
https://deploy-preview-10115--docsdocker.netlify.com


Expose entrypoints/chunk assocation for Webpack 4

Webpack 4 removes the CommonsChunkPlugin and lets Webpack itself decide how to do code splitting (using the splitChunks and cacheGroups settings). This results in combined chunks  as Webpack sees fit, possibly (entrypoints pageA and pageB result in three chunks: pageA + pageB + pageA~pageB).
As we no longer know which chunks to include for all code required for a specific entrypoint, we really should just be able pass in the entrypoints to any downstream tool such as django-webpack-loader.
Therefore, this plugin should ideally start exposing the entryPoint/chunk associations, similar to webpack --profile:
"entrypoints": { "Homepage": { "chunks": [ 0, 1, "Homepage" ], "assets": [ "0-de629161af8ff152d740.js", "1-de629161af8ff152d740.js", "Homepage-de629161af8ff152d740.js" ] },

django-webpack-loader can then just be instructed to {% render_bundle "Homepage" %} and load the three chunks 0, 1 and Home.
Refs owais/django-webpack-loader#157.

So, I've built a prototype that uses the entrypoints property from the webpack compilation results. The remaining question now is, how do we propagate this to downstream apps (such as django-webpack-loader)? I see a few possibilites:

Completely replace the chunks property
This should work straight out of the box and not require any changes to downstream. This unfortunately does break any templates where. In my codebase for example, we've so far used two render_bundle calls on a single page to load a vendor bundle and an actual site bundle respectively. By using entrypoints, there should be no more need to include the vendor bundle explicitely as it'll be picked up as part of the site entrypoint, so I'll need to drop the render_bundle. This is therefore a breaking change.

Add a new entrypoints property
We could simply augment the stats file with a separate entrypoints property. django-webpack-loader could then either release an update, changing render_bundle to use the entrypoints property instead of chunks, but that would still be a breaking change for the same reasons as above. As an alternative, one could add a new command, i.e. render_entry to automatically render an entrypoint. This would be fully forwards compatible.

There's a few more open questions, such as: how does one deduplicate chunks on a page? If I have two entires, moduleA and moduleB, and both depend on chunk vendor, including both on a page would result in a duplicate vendor script tag. Maybe render_entry should be able to take a variable amount of entries, and deduplicate among them? But then, how do we handle things like the css flag?

I'm coming across this issue as well, a related issue filed in the main webpack repo that has a workaround is https://github.com/webpack/webpack/issues/6797.
That said, I should be able to just mark splitChunks: 'all' and have it just work
For those too lazy to read through the thread above, splitChunks: 'async' works with 0.4.0-beta to load bundles with django-webpack-loader.
Given webpack 4 support is in beta anyways, a breaking change to make it 'just work' for people migrating later I think would be a reasonably safe change, if we expose all the chunks as before it could be non-breaking but load content multiple times as a safer alternative

@beheh, i like your prototype. IMO I'd stick with the second option -- a new entrypoints property. Couldn't this just contain an object with the entrypoints as keys and an array of chunks that match, rather than adding the files to this section too?
As to how django-webpack-loader integrates it: personally I'd add new tags that would compile the chunks to render, then a separate tag to render all the compiled chunks which can consider deduplication:
{# Build the chunks with: #}
  {% webpack_entrypoint 'some-entry' %}
  {# and/or #}
  {% webpack_chunk 'some-chunk' %}
{# Then render them with: #}
  {% render_webpack %}
  {# or #}
  {% render_webpack css %} ... {% render_webpack js %}

I'm running into this as well, @owais are there any plans for bringing something like this into the lib?

webpack4 support is in master now and was contributed by @melck. I'm assuming this was resolved by adding webpack4 support? If not, feel free to re-open and/or send a PR.


Unclear wording

Hello,
"Automation is the solution to reducing toil. By reducing it, engineers can eliminate future toil and concentrate on innovating and automating business solutions."
If the wording "By reducing it" applies to "Automation", the clause is not logic: Automation should be developed, increased, so engineers can eliminate future toil.
Best regards,
François
Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 745e0224-7dde-67aa-eeb7-6a11a58cdf83
Version Independent ID: 9258af0c-411c-210f-6efa-fd63e0c75f88
Content: Automation overview of goals, best practices, and types in Azure - Azure Architecture Center
Content Source: docs/framework/devops/automation-overview.md
Service: architecture-center
Sub-service: well-architected
GitHub Login: @v-aangie
Microsoft Alias: pnp

Thanks for reporting - this issue is under review.  This is a Microsoft Internal DevOps Bug ID AB#328182

Thanks a bunch for taking the time to open this issue. Agreed on the wording, this has been updated and should publish later today or tomorrow.


ElasticSearch driver is almost deprecated

Hi, are there any plans to migrate to the new @elastic/elasticsearch module?
The legacy elasticsearch module will be deprecated in the next few months:
https://www.npmjs.com/package/elasticsearch#we-have-released-the-new-javascript-client-

@jciolek can speak to this but if not there are no plans for this. As usual, pull requests are always welcome.

+1

+1

If nobody else is interested in contributing, another option would be for a business to adopt this module through a gold sponsorship at https://github.com/sponsors/daffl for continued maintenance and to get it updated to all the latest versions.


Update - fixed for most current rakudo nom

I went with the fix in #21, which covers what this does so far as I can tell, but without the "smell" of comparing type names as strings.
Thanks!


Add Traditional Chinese language support

Inspired by #340 ( thanks to atorber )
Edit response prompt let LLM to response Traditional Chinese.

I tried it, Simplified Chinese works

If request is Simplified Chinese, the whole response will be Simplified Chinese.
If edit the prompt to Traditional Chinese, the response will be Traditional Chinese.


apk: build locale code properly

Signed-off-by: Young-Ho Cha<EMAIL_ADDRESS>

Is there a specific reason to concatenate the locales like this: locale = "-r".join((language, region))?
In my opinion the result should be "{}_{}".format(language, region) or if you follow the structure that is given in the documentation: "-b+{}+{}".format(language, region)

In my opinion the result should be "{}_{}".format(language, region)
It means "{}_r{}".format(language, region) ?

yes, but for what is the r? In my opinion a locale code is for example en_US and not en_rUS?

In https://developer.android.com/guide/topics/resources/providing-resources.html#table2 , describes about locale.

The language is defined by a two-letter ISO 639-1 language code, optionally followed by a two letter ISO 3166-1-alpha-2 region code (preceded by lowercase "r").

Ahh I see, thank you! Now I understand


ci: isolation of some gateway tests

This does not speed things up a lot.
Closing this for now. To be revisited with @chesedo's idea of creating a small mock deployer container to run these tests without having to build images.


Proivided style and template doesnt work well with ScrollViewer (Default template works fine and as intended)

I need to show a ScrollViewer inside the Expander and I can do it using the default Expander control with no problem. This template, however, sets the size of the Expander as the Content which is ScrollViewer and that makes ScrollViewer useless. Note that I can not hardcode the size of the ScrollViewer by hand as it defeats the purpose of letting the layout manager decide its size ( the default Expander Control does this perfectly).
<Grid>
    <Expander Margin="10"
              ExpandDirection="Right"
              HorizontalAlignment="Left">

        <ScrollViewer ScrollViewer.CanContentScroll="True">
            <StackPanel Orientation="Vertical">
                <!--My Content is different than this but this shows the problem.-->
                <Image Source="Image 1.jpg" />
                <Image Source="Image 1.jpg" />
                <Image Source="Image 1.jpg" />
                <Image Source="Image 1.jpg" />
                <Image Source="Image 1.jpg" />
                <Image Source="Image 1.jpg" />
                <Image Source="Image 1.jpg" />
                <Image Source="Image 1.jpg" />
            </StackPanel>
        </ScrollViewer>
    </Expander>

</Grid>

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: bdb9feb2-67b1-f850-9acb-38f05f9ce5f1
Version Independent ID: 1ad823ca-dbdf-a145-0265-0cf29056ec98
Content: Expander Styles and Templates - WPF .NET Framework
Content Source: dotnet-desktop-guide/framework/wpf/controls/expander-styles-and-templates.md
Product: dotnet-framework
Technology: dotnet-wpf
GitHub Login: @adegeo
Microsoft Alias: adegeo

Generally these issue come from the template being really out of date. I'm unsure where these templates came from originally. I'll do my best to find an updated version and update the article.


MudTabs: Fix ActivatePanel ArgumentOutOfRange- and NullReferenceException

Description
Fixes #3609
This PR will guard against an ArgumentOutOfRangeException and NullReferenceException
that can be reproduced in TryMud: https://try.mudblazor.com/snippet/mkQFvwmxsYGypqpP
when the "INDEX 4" button and the first "ITEM FIVE" button are clicked.
I have not included any logic to accomodate the expectation mentioned in the bug report:
For index it could move to the last one or the first one (depending on the direction of the value).
I am willing to create a separate PR for this, if possible.

How Has This Been Tested?

Types of changes

[X] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

[X] The PR is submitted to the correct branch (dev).
[X] My code follows the code style of this project.
[ ] I've added relevant tests.

Thanks @Yomodo


[Draft] Fix bug with events being processed during RobloxRenderer.updateHostNode

Closes (ISSUES HERE).
TODO: write this
Checklist before submitting:

[ ] Added entry to CHANGELOG.md
[ ] Added/updated relevant tests
[ ] Added/updated documentation

Going to come back to this when I get the unit tests running locally.


New map features

Features added

Animated Panning
Map placeholder added - Placeholder will show only when it is detected that JS is disabled or map is not loading.

@smaranjitghose @anushbhatia merge conflict resoved

Great Work !! Keep it up


from parse problem

Great library btw!!!!
The following is parsed incorrectly
X-Mailer: MIME::Lite 3.028 (F2.82; T1.31; A2.08; B3.13; Q3.13)
From: "craigslist - automated message, do not reply"<EMAIL_ADDRESS>To<EMAIL_ADDRESS>Subject: craigslist.org:

here is the resulting parsed terms
[%MimeMail.Address{address: "\"craigslist - automated message", name: nil}, %MimeMail.Address{address<EMAIL_ADDRESS>name: "do not reply\""}]

Ooops :) , I have a lot of work this week, so unfortunatly I will only fix this next week.

Hi @jschoch , are you still interested in getting this fixed?

Yup!

Wow, who knew parsing email was such a kludge.  I spent a ton of time reading the RFC's and trying different approaches.
The problem is when the from header has something like "hello there, i'm cool"<EMAIL_ADDRESS>the headers get split via
https://github.com/awetzel/mailibex/blob/89321330b4e46c58938182a63d047dad95b2c15d/lib/mimemail_headers.ex#L20
that should be
data |> String.strip |> String.split(~r/(,)(?=(?:[^"]|"[^"]*")*$)/) |> Enum.map(&MimeMail.Address.decode/1)

This allows for the very oddball multiple from which the RFC's allow.
Wondering if someone can take a look and see if this works.  It may be good to only do this with the From: header


Ctrl(right)+Alt(left)+h will not work

Microsoft PowerToys version
0.83.0
Installation method
PowerToys auto-update, Microsoft Store
Running as admin
Yes
Area(s) with issue?
Keyboard Manager
Steps to reproduce
I would like to remap key combination of following for FancyZones with Keyboard Manager.
I would like to assign the followings:

Ctrl(right) + Alt(left) + h to Win(left) + Left
Ctrl(right) + Alt(left) + j to Win(left) + Down
Ctrl(right) + Alt(left) + k to Win(left) + Up
Ctrl(right) + Alt(left) + l to Win(left) + Right

So FancyZones' window snapping can be mapped, but somehow we cannot.
✔ Expected Behavior

Ctrl(right) + Alt(left) + h to Win(left) + Left
Ctrl(right) + Alt(left) + j to Win(left) + Down
Ctrl(right) + Alt(left) + k to Win(left) + Up
Ctrl(right) + Alt(left) + l to Win(left) + Right

❌ Actual Behavior
Not working
Other Software
No response

This was because of my setting of "Remap a key" section instead of "Remap a shortcut" section.
I withdraw this ticket. Sorry.


Feature Request: XML String to JSON

How hard would it be to implement the JSON parsing from a XML string? This would help with testing where you want to validate the output json structure against specific XML events. Could also be useful for something that uses Windows API that retrieves the XML string and wants to convert it to JSON and maintain a 1 to 1 structure with this library.

This is actually pretty trivial to implement - we could just use a quick-xml reader and translate the events it yields to the input JsonOutput expects, it should be around less than 50 lines of code.
But since we currently doesn't interact with winapi at all, this doesn't offer any utility to this library, and so this falls out of scope of this project, expect maybe as a testing utility.
Since JsonOutput is public, it should be possible to import it and gain structual similarity in a foreign library using this method.

then +1 for adding it as a testing utility ;)

Added :)


Add a new '%matchtype' variable to transform_context in vast-threatbus

:notebook_with_decorative_cover: Description

:memo: Checklist

[x] All user-facing changes have changelog entries.
[x] The changes are reflected on docs.tenzir.com/threatbus, if necessary.
[x] The PR description contains instructions for the reviewer, if necessary.

:dart: Review Instructions

To be honest I also did not test this personally, but we received feedback from @satta that the PR works successfully in combination with fever and live matching after resolving all of the comments.


switch to SHA512

I removed test/auth/smtp-auth-cram-md5.txt because I don't think that CRAM-MD5-AUTH will work anymore, if we don't have a MD5 hash to compare against.

Any idea how to fix this test ?

Yes, the test is diff test/config/example.postfix-accounts.cf test/config/postfix-accounts.cf
So you have to update test/config/example.postfix-accounts.cf as reference with SHA512 passwords.
Default clear password should be mypassword.

SHA512-CRYPT is salting the passwords, which means the hash is always different and thus not comparable.

Thank you. I update the Wiki.


Add Guzman-Solis

but need to check with @mibr30  about site name/dates as it might be from same sites as her paper earlier this year (but report different names in the two papers)
Pull Request
This PR is for a

[x] New Publication(s)
[ ] Correction

For the following list(s):

[ ] ancientmetagenome-anthropogenic (README)
[ ] ancientmetagenome-environmental (README, ask @thedir-team-dirt for advice)
[ ] ancientmetagenome-hostassociated (README, ask @thedir-team-bugparty for advice)
[x] ancientsinglegenome-hostassociated (README, ask @thedir-team-pathopeeps for advice)

New Publication
Publication Information
This pull request is to add samples from the following publication(s): Guzmán-Solis 2021 (https://elifesciences.org/articles/68612)
This is to close  #424
Checklist

[x] Publication is published (preprints currently not accepted)?
[x] Checked the publication is not already in the database?
[x] Checked samples in this publication are not previously published data (newly re-sequenced metagenomes are OK!)?
[x] Samples are shotgun metagenomes (hostassociated-singlegenome may also contain whole-genome enriched data)?
[x] Checked the list follows conventions as described in the corresponding sample type's README file (e.g. using ERS/SRS accession codes for ENA/SRA)?
[x] Changelog is updated to include the publication under 'Added'?
[ ] Pull request has passed validation checks (see automated comment from github-bot)?
[x] Review requested from corresponding team (see list of lists above for each team)?
[x] (If applicable) Made a separate PR to add new categories to controlled lists (stored under /assets/enums, e.g. material or archive)? If so the corresponding PR is here:

If you do not know how to check errors in failed validation checks, expand here

Correction
This PR is for

[ ] ancientmetagenome-hostassociated
[ ] ancientsinglegenome-hostassociated
[ ] ancientmetagenome-environmental
[ ] ancientmetagenome-anthropogenic

Reference
This pull request is to correct samples from the following publication(s):
This is to close
Description
The issue is:

Checklist

[ ] Checked the corrected entries follow conventions as described in the corresponding sample type's README file (e.g. using ERS/SRS accession codes for ENA/SRA)
[ ] Changelog is updated to include the publication under 'Changed'?
[ ] Pull request has passed validation checks (see automated comment from github-bot)?
[ ] Review requested from corresponding team (see list of lists above for each team)?

Also typo in 'Temple of Inmaculate Conception', also present in previous entry


Create Temporal Test Layer

We need a temporal test layer. We recently prepared a monthly sentinel mosaic for Baja CA as material for the workshop. This should be ingested into GT temporal layer.
source of cogs: s3://geotrellis-demo/baja-2018
target catalog: s3://geotrellis-demo/catalog/baja-2018

I attempted this once before but the layer sucks. The mosaic generated for the workshop is way better. In any case, here's the code I wrote to generate that, perhaps its useful: https://gist.github.com/CloudNiner/adf1c4bd07aa4043b17b5fc9ccf3667e
The GeoTrellis layer will require that the valid times for the entire layer are available in the AttributeStore in the times attribute as a List[ZonedDateTime], which is not covered by the sample code above.

🎉


[Bug]: Import and export failed

ODC version
odc423
OB version

What happened?
import

export

What did you expect to happen?
Import and export successful
How can we reproduce it (as minimally and precisely as possible)?
Import, upload files, and export
Anything else we need to know?
No response
Cloud
No response

pass


API to get type information of a given expression

Purpose

LS extension to get Ballerina type information given an expression

Request
{
   "documentIdentifier":{
      "uri":<file_uri>
   },
   "startPosition":{
      "line":1,
      "offset":1
   },
   "endPosition":{
      "line":1,
      "offset":1
   }
}

Response
{ TypeSymbol }

Fixes #29188
Check List

[x] Read the Contributing Guide
[ ] Updated Change Log
[ ] Checked Tooling Support (#)
[ ] Added necessary tests

[ ] Unit Tests
[ ] Spec Conformance Tests
[ ] Integration Tests
[ ] Ballerina By Example Tests

[ ] Increased Test Coverage
[ ] Added necessary documentation

[ ] API documentation
[ ] Module documentation in Module.md files
[ ] Ballerina By Examples

@sajeerAhamed15 The commit messages and PR heading is not according to the best practices. Please correct them.

[1] https://github.com/ballerina-platform/ballerina-lang/blob/master/CONTRIBUTING.md#submit-your-contribution

@sajeerAhamed15 The commit messages and PR heading is not according to the best practices. Please correct them.

[1] https://github.com/ballerina-platform/ballerina-lang/blob/master/CONTRIBUTING.md#submit-your-contribution

ack. I'll squash the commits as well

Closing this PR because of Duplicate PR #29920


Add HIP-859 support for gasConsumed

Problem
A new field for gasConsumed will be returned in the mirror node rest API containing the contract results
The exposure of this HIP would see:
A new field gas_consumed in Mirror Node contract results APIs
The mirror node explorer consuming the extra field and displaying it besides/under Gas Used on the Contract Result section (e.g. on https://hashscan.io/testnet/transaction/1705968001.327442223?p=1&k=1705969403.429657849)
Mirror Node Issue: https://github.com/hashgraph/hedera-mirror-node/issues/7543
Solution
Return the new field
Alternatives
No response

Depends on mirror node release which is in progress to address this issue


Explore RPyC python library for enabling Ray autoscaler

https://rpyc.readthedocs.io/en/latest/index.html

Part of #1538

Generalized summary after a month of use.

When passing local arguments by reference to a remote function, the library passes wrappers over these arguments, when accessing the attributes of which queries are made to the source object via the TCP connection. For some types, the wrappers created cause the following problems with:

serialization/deserialization.
functionality based on the type of object.
executing logic that considers whether the object is callable(as a workaround on RPyC side - we shouldn’t create __call__ method for proxy class).

In these cases, it was decided to perform rpyc.classic.deliver function on local objects, which in essence is a transmission by value.

The problem with timeouts is solved by increasing the value of sync_request_timeout parameter of the connection. Important: this must be done on the client side and on the server side.


chore: main migration

This changeset contains small changes to support the renaming of the master branch to main.

:tada: This PR is included in version 0.34.2 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


OAuth login Wiki keeps asking for permission

Every time you logon the IA website, the wiki also requests new permissions. This results in a long list of permissions (see image).

Yes, when we moved the wiki over to use the website as a login source with oAuth, I saw this problem too, but hoped it would not be this bad. The main issue is that the wiki needs to get a new authorization every time you login because the wiki does not keep track of the oAuth refresh tokens when you are logged out (or automatically logged out due to inactivity). This is a limitation in the oAuth plugin we use.
While I was working on a solution, I came across OpenID Connect, which is a layer on top of oAuth to provide a standardized way to exchange basic profile information. If we can support this protocol in Amelie, we don't need to customize the wiki's auth plugin to get the user's data (name/username) out of the website, but we can use a pre-built MediaWiki plugin [1].
Unfortunately, django-oauth-toolkit does not support OpenID Connect (yet). There is another oAuth library for Django which does (django-oidc-provider) [2], but this also provides an oAuth provider, so we need to remove django-oauth-toolkit and switching might be a bit of a hassle. I also found that a PR is in the works to add OpenID Connect support to django-oauth-toolkit [3], which has been updated recently and is waiting for the 3.0.0 release of its upstream library (oauthlib) [4]. So, we could also wait for that, but we have to live with the excessive tokens until then.
So, summarizing; to properly support this in Amelie, there are two options:

Switch to django-oidc-provider which already includes OpenID Connect support.
Wait for the PR in django-oauth-toolkit (and the release of oauthlib 3.0.0) and switch to it then.

I think option 2 is the best for us, as it requires minimal code modifications in Amelie, and seeing that the current system 'works' well enough, and that both the PR and the Oauthlib release are almost done, we should not have to wait too long for it. I've subscribed myself to notifications on both, so I'll know when they get merged.
[1] https://www.mediawiki.org/wiki/Extension:OpenID_Connect
[2] https://github.com/juanifioren/django-oidc-provider
[3] https://github.com/jazzband/django-oauth-toolkit/pull/545
[4] https://github.com/oauthlib/oauthlib/issues/512

@Kurocon please check if all blocking issues are resolved.

Django-oauth-toolkit has had a release back in March with OIDC support, so we can finally start working on this.
This does however need help from the system administrators, as a new plugin has to be installed in the Mediawiki

This has become outdated with the move to the new authentication platform


MGDOBR-183: add https to ingress application

MGDOBR-183
Please make sure that your PR meets the following requirements:

[x] Your code is properly formatted according to this configuration
[x] Your commit messages are clear and reference the JIRA issue e.g: "[MGDOBR-1] - $clear_explanation_of_what_you_did"
[x] All new functionality is tested
[x] Pull Request title is properly formatted: MGDOBR-XYZ Subject
[x] Pull Request contains link to the JIRA issue
[x] Pull Request contains link to any dependent or related Pull Request
[x] Pull Request contains description of the issue
[x] Pull Request does not include fixes for issues other than the main ticket

@r00ta Alternatively it does look like we can use mkcert in combination with minikube to give us SSL ingress locally as well: https://minikube.sigs.k8s.io/docs/tutorials/custom_cert_ingress/

@r00ta Alternatively it does look like we can use mkcert in combination with minikube to give us SSL ingress locally as well: https://minikube.sigs.k8s.io/docs/tutorials/custom_cert_ingress/, but we'd need to check if the default Ingress implementation that comes with Minikube allows for enforcement of the HTTP --> HTTPS redirect

@robpblake Do we have to setup https also for minikube? Our k8s support is intended to be just for development. Even if we setup that for k8s, the ocp side would not be "tested". The only way to test this thing is to run an IT/E2E test against the platform deployed on ocp.
I think we can avoid setting this up for k8s, but if you have a different opinion let's discuss.

@r00ta Alternatively it does look like we can use mkcert in combination with minikube to give us SSL ingress locally as well: https://minikube.sigs.k8s.io/docs/tutorials/custom_cert_ingress/, but we'd need to check if the default Ingress implementation that comes with Minikube allows for enforcement of the HTTP --> HTTPS redirect

@robpblake Do we have to setup https also for minikube? Our k8s support is intended to be just for development. Even if we setup that for k8s, the ocp side would not be "tested". The only way to test this thing is to run an IT/E2E test against the platform deployed on ocp. I think we can avoid setting this up for k8s, but if you have a different opinion let's discuss.

@r00ta The reason I was thinking about it is that it would help us avoid a test suite that has to understand if it's running against MiniKube or OSD e.g. "The suite is running against MiniKube, do not test the SSL redirect" and also further remove any differences between local dev and production.
I don't want to hold up this PR, so I'm happy for us to add a task to our backlog to decide how we want to proceed with testing the SSL redirect (and if we want to enable SSL on the local dev experience)
cc @sutaakar for awareness of the question on testing

@r00ta Alternatively it does look like we can use mkcert in combination with minikube to give us SSL ingress locally as well: https://minikube.sigs.k8s.io/docs/tutorials/custom_cert_ingress/, but we'd need to check if the default Ingress implementation that comes with Minikube allows for enforcement of the HTTP --> HTTPS redirect

@robpblake Do we have to setup https also for minikube? Our k8s support is intended to be just for development. Even if we setup that for k8s, the ocp side would not be "tested". The only way to test this thing is to run an IT/E2E test against the platform deployed on ocp. I think we can avoid setting this up for k8s, but if you have a different opinion let's discuss.

@r00ta The reason I was thinking about it is that it would help us avoid a test suite that has to understand if it's running against MiniKube or OSD e.g. "The suite is running against MiniKube, do not test the SSL redirect" and also further remove any differences between local dev and production.
I don't want to hold up this PR, so I'm happy for us to add a task to our backlog to decide how we want to proceed with testing the SSL redirect (and if we want to enable SSL on the local dev experience)
cc @sutaakar for awareness of the question on testing

https://github.com/5733d9e2be6485d52ffa08870cabdee0/sandbox/pull/220#issuecomment-1015247184


How do I relate telemetry produced by processing a request?

Hi,
I'm looking for some guidance / best practices for how to use TelemetryClient. My goal is to track and relate all telemetry for a given request, so it can be analyzed as a "package" of telemetry in the portal.
I'm noticing my Request and Exception telemetry are not related in the portal for example. My request has an operationId, but the Exception has none; this makes them appear unrelated even though they were tracked while processing the same server request.
To be more specific, here's how I'm setting up my logging and tracking requests, exceptions, etc:

At application startup, I create a TelemetryClient instance with my iKey and persist it for the lifetime of the application.
As requests come in, the first item of business is to call trackNodeHttpRequest. This results in a Request telemetry record in the portal with an OperationId.
As further business logic processes the request, I call trackException, which results in an Exception telemetry record in the portal with no OperationId.

Based on the answer to https://github.com/Microsoft/ApplicationInsights-node.js/issues/37, I am led to believe a new instance of TelemetryClient should be used for every request, so that OperationId can be assigned on the client and used across all telemetry tracking calls. However, this also seems very manual and what the Application Insights library was trying to solve by use of "auto" settings.
Reflecting on this all more, I guess it makes sense that the client doesn't know my telemetry is related because I haven't passed any data to relate the the multiple track<blah> invokes. So how can I accomplish what I'm after?
Sorry if this has been asked, or is in documentation somewhere already; it likely is since it's a basic scenario, but I couldn't find it and I'm lost for getting this working.
Thanks.

Are you disabling automatic correlation when initializing the SDK? It should be doing this work for you. It sounds like you might be skipping SDK initialization as you directly create a TelemetryClient instance rather than using appInsights.setup().start() and appInsights.defaultClient.
Another thing to look for is to make sure this SDK is the first require you do in your code. It's very important as correlation between requests/dependencies/exceptions/etc. requires patching of require itself (as well as a bunch of other stuff that needs to be patched before anything else can call them).
Some other questions:

Which version of Node are you on? Automatic correlation only works on versions > 3.3
What kind of asynchronous code do you use? Automatic correlation does not yet work with native async/await (but is totally fine with async/await transpiled down into promises)
Do you call trackNodeHttpRequest because automatic request collection does not work, or simply because you choose not to? If it doesn't work, it may imply a deeper issue that is also impacting the patches that start new automatic correlation contexts that happen in the same area of SDK code.

This might also be related to not calling appInsights.setup().start() and instead creating a manual TelemetryClient

As for

Based on the answer to #37, I am led to believe a new instance of TelemetryClient should be used for every request

This is not suggested and is simply old advice from many years ago 😃. Thankfully you don't have to do it this way anymore!
If automatic correlation cannot be made to work, operation_Id should be assigned using the tagOverrides property accepted by every track<> call in TelemetryClient. This is important assuming you have asynchronous code, as it will otherwise be tricky to track what the correct reference to TelemetryClient is without having to pass it around everywhere. Making a new instance each time will also incur extra overhead in memory and network from the extra classes and lack of central batching of telemetry items.

Thanks for the answers!

No, I am using the default settings, which is enabled automatic correlation if I'm not mistaken. Also, I am calling appInsights.setup(iKey) and then using the appInsights.defaultClient instance of TelemetryClient across the application. I'm not calling new TelemetryClient() anywhere.

Great! I was just confused by I create a TelemetryClient instance. To be clear, you also call .start() after .setup(iKey) correct? .start() is responsible for starting autocollection and autocorrelation.

I'm using trackNodeHttpRequest because I thought it was the recommended way to track requests to completion. Are you implying that automatic request tracking was working in my application as intended, I wouldn't need to call trackNodeHttpRequest nor trackRequest?

That's correct. In the following sample app (not tested code but right idea), both requests and dependencies should be collected on your behalf automatically. If you don't see the same behavior when using this SDK in your project, that's a great starting point for debugging the correlation issues!
let appInsights = require("applicationinsights");
let http = require('http');
appInsights.setup(iKey).start();

http.createServer((req, res) => {
   let data = '';
   http.get('http://bing.com', (resp) => {
      resp.on('data', (d) => data += d);
      resp.on('end', () => res.end(data));
   });
});

Well, thank you for asking about start() missing! How embarrassing. 😄 Somewhere along the line, I removed that, forgot to put it back, and never noticed it when double checking the documented samples.
Thanks for your time and pointers on other areas of the library. I've confirmed requests are magically tracked without calling trackNodeHttpRequest -- very cool and convenient library!


Initial commit of 7 games in Python

I already had these written.
Also have Wumpus ready to go if you ever get to the second book :-)

Thanks!! 🤗


Update build.gradle

Although I am curious to see if this builds, the direction of our Go projects/tools that use Gradle and the gogradle plugin is one where we integrate a newer/supported plugin for Go that does not assume (old/deprecated) go vendor or one where we seek to eliminate gradle or a need for a plugin altogether (as the "go" tools have matured and become quite simple as to not require plugins perhaps at all).


Create 'favorites' section

Hi! This solves the issue #273 <<Create 'favorites' section>>
This new feature allows the user to mark a pet as 'favorite' in the pet view and save it to a list which is saved using localstorage.

Now, to allow the user to access their list of favorite pets, I added a button in the navbar that includes the number of favorites and that updates in real time.

Finally, when this heart icon is clicked, the view is displayed with all the pets that are in the favorites list.

Note: The favorites list in localstorage only stores the ids to save space, so when this page is loaded it's necessary to fetch the data.

This is the view when no favorite pets have been marked

And this is the view when there was an error fetching the data

Note: I added the heart icons with yarn add react-icons

I hope you like the implementation :) Let me know if you want me to modify something

wondering if you can fix the conflicting files, was making adjustments to most of the pages

wondering if you can fix the conflicting files, was making adjustments to most of the pages

@redxzeta done :)

wondering if you can fix the conflicting files, was making adjustments to most of the pages

@redxzeta done :)

some formatting issues
just run yarn format

wondering if you can fix the conflicting files, was making adjustments to most of the pages

@redxzeta done :)

some formatting issues just run yarn format

already did it and it doesn't modify any files :( you know what else it could be?

wondering if you can fix the conflicting files, was making adjustments to most of the pages

@redxzeta done :)

some formatting issues just run yarn format

already did it and it doesn't modify any files :( you know what else it could be?

hmm i just cloned the branch and it did modify App.js and Petinfo.js


Add missing commonJS and AMD wrappers

CommonJS and AMD support was accidentally removed for 1.3.0
fixes #72

Verified that @j3tan has signed the CLA. Thanks for the pull request!

Change looks good. Travis is failing due to this: https://github.com/cjohansen/Sinon.JS/issues/761
Also, Is there a way to add a test to ensure CommonJS support isn't broken?

Test would have to run npm run dist which might not be great. Have you seen examples of testing AMD/commonJS wrappers like this?

I'd just run during a release after dist. All you really need to do is require('./dist/t3.js') and see that it returns the correct object.

+2
Sinon was also fixed


Response from "PUT /admin/template/${template_id}" endpoint does not contain the updated template in it's body

Test Case/s To Reproduce Issue
008a ADMIN - Update Existing Template
    [Tags]    436  not-ready  bug
    upload valid OPT    minimal/minimal_admin.opt
    (admin) update OPT    minimal/minimal_admin_updated.opt
    validate PUT response - 200 updated
    [Teardown]    (admin) delete all OPTs

# path to test case
tests/robot/ADMIN_TESTS/005-Template.robot

# robot command to execute related test case(s) in your terminal/console
cd tests
robot -v SUT:ADMIN-TEST -d results/ -L TRACE -i 436ANDadminANDtemplate robot/ADMIN_TESTS/

Actual Result
200
body contains the template_id only

Expected Result
200
body has the complete (updated) template

should be (re)assigned ???

Bug reported and will be tracked in JIRA:
https://jira.vitagroup.ag/browse/CDR-453
Reproducible in EHRBase v.0.22.0.
CC: @stefanspiska, @HolgerReiseVSys


src.hasOwnProperty is not a function

Getting this error when trying to sanitise a path.
{"code":"InternalError","message":"src.hasOwnProperty is not a function"}
Route is as follows:
server.get({
      path: '/api/test',
      params: {
        name: {
          required: true,
          dataTypes: ['string']
        }
      }
    }, (req, res) => {
      console.log(req);
      res.send('testing');
    })

Restify is setup as follows:
let server = restify.createServer({
      name: 'projectSite'
    });

    let respect = new Respectify(server);

    server
      .use(restify.CORS({
        origins: ['*'],
        credentials: true,
        headers: ['authorization', 'content-type', 'accept', 'origin', 'sid'],
        methods: ['GET', 'PUT', 'POST', 'HEAD', 'DELETE']
      }))
      .use(restify.bodyParser())
      .use(restify.queryParser())
      .use(restify.authorizationParser())
      .use(respect.middleware());

@DavidFH Thanks for reporting this, I will try to reproduce this locally.
What versions of node, restify, and respectify are you using?

@sorensen Thank you for the reply. The versions are as follows:
node 5.9.0
restify 4.0.4
respectify 2.3.1
How would one go about getting the stack trace for this?

@DavidFH I have released a fix for this at v2.3.2, let me know if that works for you and I will close this out.

This worked, thank you for the update.

Woo! Thanks for finding this.


Update nextjs-typescript-example

[x] I have followed (at least) the PR section of the contributing guide.

Hi,
I'm starting a new project with MUI v5 and found this Next.js with Typescript example to be a bit outdated.
It featured non-standard Next.js folder structure compared to one generated with create-next-app.
So I've updated it and even included Eslint + Prettier configs. I've tested it locally before pushing to a new branch.
Hopefully this would be useful to new MUI users like me!

Circle CI tests indicated it might have had some conflict with root project formatter.
Should Prettier config files be removed to progress this PR?


[Docs] Update README

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.
Motivation
Please describe the motivation of this PR and the goal you want to achieve through this PR.
Modification
Mainly modifications:

BC-breaking (Optional)
Does the modification introduce changes that break the back-compatibility of the downstream repos?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.
Use cases (Optional)
If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.
Checklist

Pre-commit or other linting tools are used to fix the potential lint issues.
The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
If the modification has potential influence on downstream projects, this PR should be tested with downstream projects.
The documentation has been modified accordingly, like docstring or example tutorials.

 Is there a way to change the Chinese here to English?

It has been updated:


Language Server Implementation

Thanks for the great project!
I really like the erde syntax. It fixes exactly all those little things that make Lua annoying to write for me.
Is a language server implementation planned for erde? Maybe LuaLS could be extended or forked to ease such an implementation?
Apropos: I've just found the vscode extension here. Probably wouldn't hurt to put the link to the site somewhere as well to make it easier to find.

Thanks for the compliment!
I would perhaps like to make a language server at some point but am currently focused on another project and not sure if / when I would have the time / energy, especially because it would be a huge endeavor (even if it was just forked).
It may happen at some point, especially if more people are interested / start using Erde, but I would say unlikely to happen in the foreseeable future (sorry about that).
As for the vscode extension, good point that its not very well advertised, I totally forgot about that :sweat_smile: I'll add a section for editor support somewhere on the site this weekend!


Create dialog.md

Please add your new page to the objects index.

Can I ask what you mean by this?

See file [objects/objects-index.md]

See file [objects/objects-index.md]

I wasn't sure if I could do it through here, so I instead made another pull request: https://github.com/retro-dev-rblx/Docs/pull/10


add an issue template and rename feature request to proposal

Signed-off-by: Fansong Zeng<EMAIL_ADDRESS>Ⅰ. Describe what this PR does
add an issue template for user support and rename feature request to proposal,  we encourage questions and solutions.

please review this pr, thanks @jasonliu747

Codecov Report

Merging #108 (37b6515) into main (1df5a76) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #108   +/-   ##
=======================================
  Coverage   44.19%   44.19%
=======================================
  Files          73       73
  Lines        5965     5965
=======================================
  Hits         2636     2636
  Misses       3036     3036
  Partials      293      293

Flag
Coverage Δ

unittests
44.19% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1df5a76...37b6515. Read the comment docs.

/approve


Steam Deck: Memoria does not seem to work (tested on FF2)

Hi! When using the latest version of Memoria.FFPR on a Steam Deck device, I have noticed that the hotkeys defined in the BepInEx\config\Memoria.ffpr$Section.cfg files are not working reliably. They do not seem to be detected at all in-game.
This is the same cfg file that I use on my Windows installation. On my Windows system all the hotkeys seem to work properly, but on a Steam Deck with the same configuration files there is no response at all when pressing any hotkey (for example, speedup doesn't work at all and encounters continue to happen). I have tried changing the hotkeys and remapping them to any of the physical buttons on the device, but there's no effect.
This problem was observed on FF2, but I'm not sure if it's also happening with the other titles. Might be partially related to this: https://github.com/Albeoris/Memoria.FFPR/issues/39
EDIT: Upon further testing, it seems the latest version of Memoria isn't loading at all when launched on a Steam Deck. I tried to perform a new install from scratch, but it seems Memoria isn't being loaded and is not generating the .cfg files.

Disregard this issue, I got it working. I was unaware of the fact that, in order to make Memoria FFPR work on Steam Deck or any Proton-based installation, there's an additional set of instructions that needs to be applied beforehand. See here for reference: https://docs.bepinex.dev/articles/advanced/steam_interop.html#open-winecfg-for-the-target-game

For some reason, in addition to, I also needed to add export WINEDLLOVERRIDES="winhttp=n,b"; %command% to the launch option in steam for mapping F1 to actually work for speed up.


Editor crashes with imported fonts in certain circumstances

Operating system or device - Godot version:
Arch Linux, Godot 2.1 Git (https://github.com/godotengine/godot/commit/b6fdac80cb0716f4c64aed9d0920159b50e2ed15)
This issue seems to happen only with the Clang compiler. Version used here is clang version 3.8.0 (tags/RELEASE_380/final). With GCC gcc (GCC) 6.1.1 20160501, this bug does not seem to occur.
Issue description (what happened, and what was expected):
The editor will crash in at least two circumstances when using imported bitmap fonts:

Double-clicking res:// in the FileSystem tab with a font imported at the project root.
Setting the editor font to an imported font.

After such a crash, if you re-open the project, it will crash again as soon as you open any scene, a few seconds after the opening, without leaving any error message.
Link to minimal example project (optional but very welcome): test.zip

does this still happen? I think I managed to fix the crash bugs with fonts recently

@Calinou Ping :)

I'm closing as I'm certain I fixed it and can't reproduce it


Reduce image size

The image is 815MB and I believe it can be drastically reduced. So save space on the system and make the image cleaner and optimized.

Bump.
Pretty critical when used on Raspberry Pi. Probably this would reduce RAM usage too.


[☀] make separate viewer handler for vdisk

Frontend issue - https://github.com/ydb-platform/ydb-embedded-ui/issues/618

Issue, related to backend, new issue is created in ydb repository: https://github.com/ydb-platform/ydb/issues/1062


Connection Problem

hello beroset
thanks for your great tool in first place.
i compiled everything successfully ( i think) flashed the uf2 file to the pico and can access via terminal.
when i type for example version it shows me only version "".
my pinout how i connected to the m16c works flawless with e8a debugger. and shows me for example ver 2.77.
i saw under windows that i have an additional unknown "RESET" device.im not sure if its normal.
is there any chance to debug what is wrong with my connection? or maybe some options than i can change so i can connect successfully?
greetings

Do you get the menu title?  It should say "pico-puller Main Menu:" and then list the menu.  If that works, but version does not, then there are two possibilities: either the target device does not implement the Renesas bootloader (and so ignores the command) or there is a problem with the connection between your Pico and the M16C.  Verify carefully that the pin connections shown in the README file are exactly the ones you are using.  Also, make sure you know whether it's a square M16C package or a rectangular one -- the pin numbers are different.

@speters: Thanks for your comment.  Are you also using a Windows host to connect to the pico?  I am wondering if the the line endings might be part of the issue.  My test and development platform is Linux where the line ending is \n versus Windows where the line ending is typically \r\n.  I see that you've said your line ending is set to \n but, depending on the terminal program used, sometimes on Windows that still gets translated to \r\n.  I don't have a Windows machine to try this on, but I will experiment with line endings to see if there's something that I could improve here.
As for pinout, the 1.1 version should definitely be used since the software and documentation were both changed to match.

hi beroset hi speters
Do you get the menu title?  yes i do as i wrote
It should say "pico-puller Main Menu:" and then list the menu. yes it does
If that works, but version does not, then there are two possibilities: either the target device does not implement the Renesas bootloader (and so ignores the command) i can connect with other tools bootloader is VER.2.77
or there is a problem with the connection between your Pico and the M16C. i must say i have exactly the same behavior as speters wrote

OK, I've done two things that may be helpful here.  First, I created a 1.2 release.  No code was changed except for the version number, but I thought it would be useful to have the latest version available for people who don't want to build it themselves.
Second, I experimented with minicom on Linux and see problems very similar to what you describe.  The problem is that minicom sends a CR instead of LF.  It's only the LF that the pico-puller software understands as the end of a line.  The way to avoid that problem is to tell minicom to use LF instead.  Go into "Screen and Keyboard" setup, choose "O - Character conversion" and change character 13 (CR) to emit 10 (LF).  That should take care of part of the problem.  If you're using some other terminal software, either do something similar or perhaps tell your software to use the "DOS" line ending pair (CR/LF).
The other thing is that you probably need to issue a "reset 0" to release the reset line of the CPU.  Otherwise it will be held in reset and nothing will work.  Look at the dump.cmd file in the scripts directory for a typical sequence required to dump memory.
Lastly, using the expect scripts provided with the project works much better than a terminal emulator.  Try them (the pico-puller command) if you're on Linux.
Please let me know your results.  If one or more of these suggestions work for you, I can see about adding to the documentation to make things more clear.  Thanks for your help!

thanks beroset
i have the mcu hooked up on a breakout board.

@speters @dwelltime Have you been successful?

Thanks for the report!


Chart does not cover the entire page with Standalone=1

When Standalone=1 (or standalone=true) is passed in query string the chart does not fit the full page like used to do in the previous version.
Expected results (Superset v. 0.37.2)
In this case the chart area is 1920 x 937 and fit the entire page:

Actual results (Superset v. 1.1.0)
In this case the chart area is 1890 x 806 and does not fit the entire page:

Screenshots
In line with comments
How to reproduce the bug

Create and save a chart
Generate a link to view/share the chart
Get the chart id and point to standalone version: https://superset_v_1_1_0/superset/explore/?r=100&standalone=1
See that the chart will not fit the entire page

Environment

superset version: Superset 1.1.0
python version: Python 3.8.9
node.js version: -

Checklist

[ ] I have checked the superset logs for python stacktraces and included it here as text if there are any.
[x] I have reproduced the issue with at least the latest released version of superset.
[x] I have checked the issue tracker for the same issue and I haven't found one similar.

Additional context
--

Hi, is there any chance that this issue will be addressed shortly?

Hi @suddjian, could you point us where this problem could be?
We can check and eventually create a merge request if we solve it...
Thank you

Hi @nraschi, I would start by looking here: https://github.com/apache/superset/blob/master/superset-frontend/src/explore/components/ExploreChartPanel.jsx#L161
If you open a PR, ping me and I will be happy to review.

Hi @suddjian, thank you very much! I let you know.

Hi @suddjian, can you pin this issue please, I'm trying to resolve "pull request" problems.
Thank you very much

Just checked this on the current version, and it no longer seems to be an issue.


Create spaces/blocks based on reservations and re-use the created space/blocks for new reservations

Is your feature request related to a problem? Please describe.
Would it be possible to add a resource which creates a space and block, based off of a reservation that was previously made.
For instance, if I have <IP_ADDRESS>/16 in a space/block manually configured:
Create reservations for /18 (these become vnet in azure)
Followed with a resource that writes that reservation as a space and block into ipam?
So that next a reservation can be made on the created space/block. (for subnets inside the vnet)
Describe the solution you'd like
a new resource which creates the space/block, with attributes for space and block.
Describe alternatives you've considered
I've considered splitting up my terraform repository into multiple. Having the pipeline extract the CIDR from the initial reservation and using either python requests lib or powershell to create the space/block. Then have the pipeline send those values over to the next repository to trigger it with those inputs.
Additional context
I am currently using multiple modules to create the base networking functionality to be able to deploy across different regions, and to expand that base functionality easily by using a count across the resources. The subnets requiring reservations in the vnets, and the vnets requiring reservations in the cidr pools available to me.
In this feature request it is not possible to create blocks in the space, because the subnets would overlap with the range of the vnet. But I could imagine wanting to add just blocks into a space after a reservation was made as well.
For example:
Region = space
VNET = block
each single VNET = space
subnets = blocks

Hi @MMollyy ,
After reading your request I think we would meet your requirements adding to the provider several resources to maintain and query both spaces and blocks.
This functionality is possible, and reasonably uncomplicated, as the IPAM API allows these actions.
We will take your implementation into consideration, but we are a small team and it may take some time.
Thank you for your collaboration

This functionality is implemented in commit 73783d1, and will be included in next v2.0.0 of provider.

Implemented in v2.0.0


Support to turn on cudnn benchmark mode

Cudnn benchmark mode is recommended for improved performance.
It would be great to have a one-liner option to turn this on. This could be a Trainer constructor arg. I'm happy to do a quick PR/documentation update for this, just want to get feedback/confirmation before I do it.
Only downside/complexity is when determinism is also enabled. AFAICT, there's no option for determinism in Lightning, so seems like this shouldn't be a problem.

 I'm hesitant to change the global environment inside lightning

I was thinking about it as a performance best practice along the lines of
ddp that should be on in most cases. Happy to keep it outside as well (what
I am doing locally already anyways) if you think that is cleaner.
On Wed, Oct 16, 2019 at 2:09 PM William Falcon<EMAIL_ADDRESS>wrote:

Why would you want this inside lightning instead of you doing it yourself?
I'm hesitant to change the global environment inside lightning
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/williamFalcon/pytorch-lightning/issues/370?email_source=notifications&email_token=AADYHNUQSPXVQ5OZ5LSFZVDQO57I5A5CNFSM4JAWOR4KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEBN6GTA#issuecomment-542892876,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AADYHNRQO6IMIM4NKVVZU7DQO57I5ANCNFSM4JAWOR4A
.

--
David Kossnick | Latent Space | We're hiring!
https://angel.co/company/latentspace/jobs |<EMAIL_ADDRESS>

I think it's a good idea to add to our pl-example repo or some pl-best practice repo

@kossnick why don't you submit a PR with a new flag:
Trainer(enable_benchmarking=False)

And do what needs to be done to enable this. Also, make sure to write a test for this.
In the future this flag can be used to group all of these optimization tricks under.

How is the status of this issue for adding a new flag ? Is there any plan to release this feature?

Hi all, sorry for the delay. I wrote the very simple / limited code, but haven't had time to get a full setup with multi-GPU to run all the required tests. I'm unassigning myself for now, anyone feel free to pick up!


feat(protocol-engine): Create LabwareInterface that delegates to protocol engine

Overview
Labware created by ProtocolContextInterface accepts implement LabwareInterface. To support ProtocolEngine, we need to create a LabwareInterface derived class that delegates to protocol engine.
Acceptance Criteria

[ ] LabwareInterface derived class that delegates to Protocol Engine state store

Some hard questions:
How do we handle TipTracker class and WellImplementation.set_has_tip?