[BUG] ERROR :: root :: notify.py :: 45 :: Failed to send email: (550, b'5.7.1 message content rejected').

Describe the bug
ERROR :: root :: notify.py :: 45 :: Failed to send email: (550, b'5.7.1 message content rejected').
Like the idea. But I get the following error when I start docker-compose
To Reproduce
Steps to reproduce the behavior:

just started with docker-compose -f iCloudBackup.yml up -d

Expected behavior
A clear and concise description of what you expected to happen.
Screenshots
If applicable, add screenshots to help explain your problem.
Configuration
app:
  logger:
    level: "debug"
    filename: "icloud.log"
  credentials:
    username: "mali"
    retry_login_interval: 600
  root: "icloud"
  smtp:
    email: "sender"
    to: "receiver"
    password: "pw"
    host: "posteo.de"
    port: 587
    no_tls : false
  region: global
drive:
  destination: "drive"
  remove_obsolete: false
  sync_interval: 300
  ignore:
    - "node_modules"
    - "*.md"
photos:
  destination: "photos"
  remove_obsolete: false
  sync_interval: 500

Additional context
Add any other context about the problem here.

Is sender address and receiver address same? Try some other SMTP server like gmail.

Thanks for your answer.
But I have adp enabled so will try that when your app supports adp as I do not want to use my iCloud without it.no pressure on  you ;).


Get images from chart registry

I've been thinking about writing something that does exactly what your plugin does. Thank you for making it open.
It seems to me that I have to either have a chart locally or have it installed to get the images.
Is there a way to get the images from a chart that is not installed. My use case is that before I install a chart, I may need to get a list of all images the chart uses and pull those into my own registry. My cluster may not let me install from public, so in this case I would not have a release in cluster to get the images from.
I was looking for something like:
helm images get oci://my-repo/charts/my-chart

Where the [RELEASE] is not required as part of the command.

@hawksight, It is great to hear that you find this plugin useful.
Since the plugin uses helm template in the process of identifying images, fetching images from the registry should work; I meant the command helm images get airflow oci://registry-1.docker.io/bitnamicharts/airflow should work.
Just that limiting version of the chart is something that the plugin is not supporting now. I'll check that part alone.

@nikhilsbhat thanks for the comment back. I see now it does not have to be installed, simply a valid release name for the helm template command. If it doesn't matter what the release name is, it would be nice not to need to pass it in with this plugin.
Eg, you passed airflow as the release name, but you could just use a default release name like example.
I actually found some command line wizardry using yq that actually does the same thing as your plugin, in case you find this useful. (Source)
helm template . \
    | yq '..|.image? | select(.)' \
    | sort -u

closing this as the latest release has the necessary changes.


cherry-pick for add_resource_dns (#1189)

Short description:
More details:
What this PR does / why we need it:
Which issue(s) this PR fixes:
Special notes for reviewer:
Bug:

/lgtm


Spec generation docs out of date

Problem statement
The docs are outdated with respect to generating spec from source (most notably missing the --exclude-deps flag).
Docs:
https://github.com/go-swagger/go-swagger/blob/master/docs/generate/spec.md
Vs.
Current output from swagger tool:
Usage:
  swagger [OPTIONS] generate spec [spec-OPTIONS]

generate a swagger spec document from a go application

Application Options:
  -q, --quiet                  silence logs
      --log-output=LOG-FILE    redirect logs to file

Help Options:
  -h, --help                   Show this help message

[spec command options]
      -w, --work-dir=          the base path to use (default: .)
      -t, --tags=              build tags
      -m, --scan-models        includes models that were annotated with 'swagger:model'
          --compact            when present, doesn't prettify the json
      -o, --output=            the file to write to
      -i, --input=             the file to use as input
      -c, --include=           include packages matching pattern
      -x, --exclude=           exclude packages matching pattern
          --include-tag=       include routes having specified tags (can be specified many times)
          --exclude-tag=       exclude routes having specified tags (can be specified many times)
          --exclude-deps       exclude all dependencies of project

Environment
swagger version: 0.23.0

#2271

Fixed https://github.com/go-swagger/go-swagger/pull/2271


Implement drift detection only mode

When setting .spec.approvePlan="disable",
the plan and the apply process would be skipped.
This mode is call the "drift detection" only mode.
The Ready status should be one of these:

Reason="NoDrift", Status=True
Reason="DriftDetected", Status=False

The loop is still performed every .spec.interval duration, but no plan or apply action.

The .spec.approvePlan="disable" behavior must have the higher precedence that .spec.force=true to prevent a bad thing to happen.


[medRoiManagement] set in polygonROI (1)

Need the combobox PR: https://github.com/Inria-Asclepios/medInria-public/pull/47 https://github.com/Inria-Asclepios/music/pull/279 and https://github.com/medInria/medInria-private/pull/40 (this PR is going to be rebased after the merge of these 3 PRs).
Allow to create medRoiManagement toolbox directly into polygonROI toolbox.
This PR has to be tested/reviewed with https://github.com/Inria-Asclepios/music/pull/286 and https://github.com/medInria/medInria-private/pull/42

Just to understand, only the last commit is part of this PR ?

Indeed, just this one https://github.com/Inria-Asclepios/medInria-public/pull/59/commits/ede3e31a0d7f0ad426537a3caa1a89e90ec66f0a

Added in https://github.com/Inria-Asclepios/medInria-public/pull/58


Use read-pkg to load package.json files

https://www.npmjs.com/package/read-pkg

@davewasmer where are you wanting to be using this?

Basically anywhere we say require('package.json'). Probably could just search for occurrences of package.json in the source, and that would pretty well cover the list.


Screen "shaking" on click

On the matchup page when clicking on certain parts of the screen it performs a small "shake" animation. This only happens if the team isn't submitted yet.

Is this it?
https://user-images.githubusercontent.com/26877561/106332353-a3cf9f80-6254-11eb-9d2d-3928b8a1a2ed.mov

Is this it?
https://user-images.githubusercontent.com/26877561/106332353-a3cf9f80-6254-11eb-9d2d-3928b8a1a2ed.mov

That's part of the problem yep, the start button registers click outside of its intended box. And for some reason that click has a shake animation attached.

This has magically gone away. Haven't tested on all browsers, but this issue is now irrelevant after the homepage redesign


[Bug Report] 'HumanRendering' object has no attribute 'window'

Describe the bug
This happens because self.window is set after asserts that causes close() method to be called
First seen build-all 3.8
test_human_rendering.py::test_render_modes Exception ignored in: <function VectorEnv.del at 0x00000211B439C9A0>
Traceback (most recent call last):
File "C:\Users\roger\GITs\Gymnasium\gymnasium\vector\vector_env.py", line 324, in del
File "C:\Users\roger\GITs\Gymnasium\gymnasium\wrappers\vector\rendering.py", line 178, in close
AttributeError: 'HumanRendering' object has no attribute 'window'
Code example
No response
System info
1.0.0a2
Windows 11
Python 3.11.9 (issue first seen on 3.8)
Additional context
Patch on its way
Checklist

[X] I have checked that there is no similar issue in the repo

Issue can be seen here on main
https://github.com/Farama-Foundation/Gymnasium/actions/runs/9422643271/job/25959372466
tests/wrappers/vector/test_human_rendering.py::test_render_modes
  /usr/local/lib/python3.12/site-packages/_pytest/unraisableexception.py:78: PytestUnraisableExceptionWarning: Exception ignored in: <function VectorEnv.__del__ at 0x7f7f7083f9c0>

  Traceback (most recent call last):
    File "/usr/local/gymnasium/gymnasium/vector/vector_env.py", line 324, in __del__
      self.close()
    File "/usr/local/gymnasium/gymnasium/wrappers/vector/rendering.py", line 178, in close
      if self.window is not None:
         ^^^^^^^^^^^
  AttributeError: 'HumanRendering' object has no attribute 'window'

    warnings.warn(pytest.PytestUnraisableExceptionWarning(msg))


Add expiry date to pass

How do you add an expiry date to a pass?
I tried using
"validTimeInterval": {
"start": {
"date": "2023-04-27T05:48:00Z"
},
"end": {
"date": "2023-05-15T07:00:00Z"
}
},
But had no luck
Does the pass have to be a loyalty pass? If so how do you set that instead of generic?
Thanks

Correction, the validTimeInterval parameter does work - it just takes 24 hours for Google Wallet to take any notice of it. The pass moves to the 'Archived' section of Google Wallet.


Running agent locally writes output to agent code folder

Should instead write to /tmp directory.
"/tmp/agent-runner-docker/environment-runs" is specified in https://github.com/nearai/nearai/blob/main/nearai/aws_runner/service.py#L21

@arktoswb @PierreLeGuen @zavodil We've changed this many times and ended up back in this state. Is there some reason we're not writing to tmp or was it an accidental regression?

@gabehamilton  Yes, we have to revert that to write into the tmp folder. Did you already start implementing that fix? I can work on it too if needed.

I am not sure what is desired behavior here. Assigning to @zavodil
But on benchmarks we want agents to write into the same directory (otherwise we will have multithreading conflicts). It's controlled by change_to_temp_dir arg.

Ok, great, that's exactly the info I needed. I'll set that flag for all the non-benchmarking cases (local & remote agent running).


fix windows gradle bug

Motivation
fix windows gradle bug, you can also see full log in https://ci.appveyor.com/project/gengjiawen/react-native/build/1.0.11/job/ic0nml8s4qbmni4e.
FAILURE: Build failed with an exception.

* What went wrong:
Failed to capture snapshot of input files for task ':RNTester:android:app:bundleReleaseJsAndAssets' property '$1' during up-to-date check.
> Failed to create MD5 hash for file content.

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. Run with --scan to get full insights.

* Get more help at https://help.gradle.org

Build success log: https://ci.appveyor.com/project/gengjiawen/react-native/build/1.0.12/job/xuaj8tm3p1piovbt.
Test Plan
pass all current ci.
Related PRs
https://github.com/facebook/react-native/pull/20281
Release Notes
[GENERAL] [INTERNAL] [RNTester] - fix windows gradle bug

Build success log: https://ci.appveyor.com/project/gengjiawen/react-native/build/1.0.12/job/xuaj8tm3p1piovbt.

@hramos @kelset Please review.

Can you add a couple more lines in the PR description explaining which error you were seeing? I guess we will also have to "counter-check" that that change in the ignore doesn't break builds on macOS (or the CI already "takes care" of that?).
Do you have any external references about the Windows bug, I mean, is it like a known bug on Windows that requires to make that change in the build.gradle?

@kelset I add full error info in motivation. This is a bug only windows, so unix-like system works just as I tested. Related gradle bug: https://github.com/gradle/gradle/issues/4663.

With this pr and https://github.com/facebook/react-native/pull/19974, all build issue on windows should be resolved.

Understood.
I'd just wait a bit to hear back from the Metro team because I'm quite sure they have another release coming soon and I'd prefer to have everything double checked against their new version.

@hramos Can you review this pr ? Thanks.

@hramos This fix will greatly help windows user to test RNTester like me. Can you review this ? Thanks.


Update frontend dependencies to latest versions season

Duck season

Failed Test
Failure Summary
Logs

[chromium] should load the v1 homepage correctly.
The test timed out waiting for the expected text "Real SaaS App" and the "Homepage" heading to be visible on the page.
Logs ↗

Test_ServiceUnavailable
failure_message: Failedfailure_text: === RUN   Test_ServiceUnavailable    api_test.go:18: Service unavailable--- FAIL: Test_ServiceUnavailable...
Logs ↗

Test_InternalServerError
failure_message: Failedfailure_text: === RUN   Test_InternalServerError    api_test.go:39: Internal server error occurred--- FAIL: Test_Intern...
Logs ↗

Flaky Test
Failure Summary
Logs

[chromium] should return list of users correctly.
The API call to get the list of users failed with a 404 Not Found error.
Logs ↗

[chromium] should display error message for invalid login correctly.
The expected HTTP status code 401 was not received, instead a function was returned.
Logs ↗

[chromium] should login with credentials correctly correctly.
The login request to the server failed with a 404 Not Found error.
Logs ↗

Test_BadRequest
failure_message: Failedfailure_text: === RUN   Test_BadRequest    api_test.go:53: Bad request sent to API--- FAIL: Test_BadRequest (0.00s)
Logs ↗

View Full Report ↗ ⋅ Docs


Wait for web3 methods

Depends on #58
Adds a timeout override for web3 methods, so that users waiting on the confirmation modal dont have their call flushed in an unreasonable amount of time. Patch fix until #33 is fixed

Pull Request Test Coverage Report for Build 44

3 of 3 (100.0%) changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.08%) to 97.398%

Totals

Change from base Build 40:
-0.08%

Covered Lines:
830

Relevant Lines:
842

💛  - Coveralls


Ibex wb exception fix

Confirming that this fixes the issue I brought up in #912, thanks @GregAC for the quick fix!


Magento 2 changes to pub/.htaccess doesn't reflect

Hi
I am using deployer for a Magento 2 website, and recently I have added some rewrite rules to the pub/.htaccess file and pushed the changes.
However, when I deploy the changes, the original file is being deployed on the server. Has anyone experienced the same issue and has it been resolved already?

You pushed changes to git and they are not deployed?
This sounds like you have pub/.htaccess in the shared files and therefore you either need to change the deployment, so it is NOT shared or do the changes directly on production in the symlinked file


icons does not work with nextjs

I'm using Nextjs12 and @unocss/cli, everything works fine except for icons.
Looking into the css files and generated css, I think it's more of a NextJS issue rather than Unocss's issue, however just how to open this issue and see what others think about this.
Generated CSS (uno.css)
/* layer: icons */
.i-mdi\:alarm{--un-icon:url("data:image/svg+xml;utf8,%3Csvg xmlns='http://www.w3.org/2000/svg' width='1em' height='1em' preserveAspectRatio='xMidYMid meet' viewBox='0 0 24 24'%3E%3Cpath d='M12 20a7 7 0 0 1-7-7a7 7 0 0 1 7-7a7 7 0 0 1 7 7a7 7 0 0 1-7 7m0-16a9 9 0 0 0-9 9a9 9 0 0 0 9 9a9 9 0 0 0 9-9a9 9 0 0 0-9-9m.5 4H11v6l4.75 2.85l.75-1.23l-4-2.37V8M7.88 3.39L6.6 1.86L2 5.71l1.29 1.53l4.59-3.85M22 5.72l-4.6-3.86l-1.29 1.53l4.6 3.86L22 5.72z' fill='currentColor'/%3E%3C/svg%3E");mask:var(--un-icon) no-repeat;mask-size:100% 100%;-webkit-mask:var(--un-icon) no-repeat;-webkit-mask-size:100% 100%;background-color:currentColor;height:1em;width:1em;}
/* layer: default */
.bg-dark-400{--un-bg-opacity:1;background-color:rgba(34,34,34,var(--un-bg-opacity));}
.text-3xl{font-size:1.875rem;line-height:2.25rem;}
.text-dark-500{--un-text-opacity:1;color:rgba(31,31,31,var(--un-text-opacity));}
.flex{display:flex;}
.h-100vh{height:100vh;}
.justify-center{justify-content:center;}
.items-center{align-items:center;}

Here, we can see that the data-uri is properly generated, if I copy the data uri and render it on https://www.site24x7.com/tools/datauri-to-image.html, we can see an icon.
However, when nextjs bundles the files, I think it does some processing on CSS files, when I inspect the CSS in browser, it looks like this

I did go and find this generated static .svg file, it does exists on the Filesystem and is a valid SVG. However, it somehow doesn't work in the browser.

it seems Nextjs is trying to encode the url on the css? the last part of url in your screenshot seems the hash of the asset...


Upgrade codebase to .Net 7

- [x] Create a global.json file
- [ ] Upgrade SWA Blazor app -> If need be, delete existing and use the new empty template
- [ ] Adapte  the authentication and authorization feature in Blazor as per .net 7
- [ ] Add the Auth0 scaffolding

Closing this issue as it is superceded by #69


Restore XML hierarchy to WCF configuration section (part 2)

Applied XML hierarchy format to WCF configuration section files for:

<system.serviceModel.activation><bindings>...</bindings></system.serviceModel.activation> sub-section

Contributes to #2038 & #2149

Thanks for the review and suggested changes @rpetrusha!
I just applied all of the suggested changes.

Thanks, @nemrism, for making these additional changes. I'll merge your PR now.


Files not fixed if --rules option has an excluded rule

Bug report
php-cs-fixer will not fix a file if the --rules option has an excluded rule (i.e. -header_comment).

PHP version: PHP 7.4.6 (cli) (built: May 14 2020 10:38:36) ( NTS )
PHP CS Fixer version: PHP CS Fixer 2.16.4 Yellow Bird by Fabien Potencier and Dariusz Ruminski (1023c34)
the command used to run PHP CS Fixer:php php-cs-fixer-v2.phar fix foo.php --rules=-header_comment

the configuration (file) you used: NONE (I've tested with and without a config file -- same results).

Code snippet that reproduces the problem
Before execution
<?php

class Foo {}

After execution
Actual: No change
Expected:
<?php

class Foo
{
}

The

Actual: No change

is what is expected.
In README you can see:

The --rules option lets you choose the exact rules to apply

and you have chosen to use no rules and exclude header_comment.
You were expecting that the rules from .php_cs file would be used and header_comment would be excluded from the set, right?
Unfortunately, the rules parsing works differently: if the option --rules is used then the rules from config file are ignored.

@kubawerlos

and you have chosen to use no rules and exclude header_comment.

The examples in the README are unclear about what will happen:

By default the PSR1 and PSR2 rules are used.

You can also exclude the rules you don't want by placing a dash in front of the rule name, if this is more convenient, using -name_of_fixer:
$ php php-cs-fixer.phar fix /path/to/dir --rules=-full_opening_tag,-indentation_type

To me, it doesn't make sense that the example would "exclude something from nothing" unless there was something by default.

Unfortunately, the rules parsing works differently: if the option --rules is used then the rules from config file are ignored.

This is good to know. I was expecting .php_cs to be used if one was available, and if not, by default use PSR1 and PSR2 and subtract the excluded rules provided.


Decorate Person Class

In This Pull Request:🚀🎉💫

Add decorate to Person class 🌐

Hi @studiosnabeel
While you made a great effort in this project, unfortunately, I cannot proceed to review your code.
Invalid Code Review Request
You have submitted a project, that does not have the key features section in your readme
Your Code Review Request will be marked as invalid in your Dashboard, so please submit a new one once you are ready 🙏
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification @prolajumokeoni.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.

Invalid Code Review Request does not count into the code reviews limit.


How to use it with proxy

Is there any way to set proxy?

Hello @ML13,
as of now, elisctl does not allow any configuration of proxies by itself.
But it uses requests package, where a proxy can be set using environment variables (for details see requests documentation).
With regards
Krystof


Number parsing should have consistent API

[user feedback]
Why to the arguments differ between double.parse and int.parse? Same functionality but one time with optional arguments and the second time with named arguments?
////////////////////////////////////////////////////////////////////////////////////
Editor: 1.2.0.dev_01_00 (2014-01-17)
OS: Windows 8 - amd64 (6.2)
JVM: 1.7.0_21
projects: 1
open dart files: 4
auto-run pub: true
localhost resolves to: <IP_ADDRESS>
mem max/total/free: 1778 / 1149 / 136 MB
thread count: 37
index: 598084 relationships in 109534 keys in 72587 sources
SDK installed: true
Dartium installed: true

During the libraries review in 2017 we had settled on always having two parse methods.
int v = int.parse(input);  // throws on non-integer input
int v = int.tryParse(input) ?? -1;  // tryParse returns null on bad input

If we make any change to improve consistency, we should make this change.
I reviewed about 2000 of uses of the current int.parse. This supports the parse+tryParse design:
Most uses were int.parse(input) - this would be the same.
Of the remaining uses, 30% defaulted to null, and almost all of the rest to simple values like 0 or -1.
  int.parse(input, onError: (_) => null)
  int.parse(input, onError: (_) => 0)

can be written in a more concisely:
     int.tryParse(input)
     int.tryParse(input) ?? 0

Often the onError: (_) => null version is used with a following test:
  var value = int.parse(input, onError: (_) => null);
  if (value == null) ...

  var value = int.tryParse(input);
  if (value == null) ...

The tryParse design has efficiency advantages.  Creating and passing a function as onError: is slower and results in bigger code on both VM and dart2js than the tryParse alternative of checking the returned value against null.
Another efficiency advantage is that by pushing the null-handling into the call side, the compiler can more easily discover nullability:
  var value = int.parse(input, (_) => 0);
  if (value > 0) ...

  var value = int.tryParse(input) ?? 0;
  if (value > 0) ...

In the first example it would require a new and difficult analysis (non-local, higher-order) to determine value is not null. In the second example, it is obvious from the ?? operator. Practically, only in the tryParse case can code be generated for value > 0 without a null check.
The migration path is not too painful:

Add tryParse methods
Deprecate the onError: (named or positional) arguments
Remove the onError: parameters at some future date

@lrhn This issue is marked as Milestone 2.0. Does this mean we can implement steps 1. and 2. of the migration for Dart 2.0 ?

@lrhn are any further changes happening here for 2.0, or can it be removed from 2.0?

I believe the parse/tryParse library update is still pending.

Any updates?

The CL adding tryParse and deprecating onError is ready to land:
https://dart-review.googlesource.com/c/sdk/+/50723
That's all that can happen for this milestone.

That seems reasonable. The actual removal could be done post-Dart 2.0

Please ensure that these land by Thursday CET. Otherwise, we'll have to do
this after Dart 2.0 stable.
On Wed, Apr 11, 2018 at 2:13 PM Leaf Petersen<EMAIL_ADDRESS>wrote:

The CL adding tryParse and deprecating onError is ready to land:
https://dart-review.googlesource.com/c/sdk/+/50723
That's all that can happen for this milestone.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/dart-lang/sdk/issues/16319#issuecomment-380597450,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ACAsW0GvTXJQzZFWP8Xywm_HMalmxE6Sks5tnnHigaJpZM4Sa-y0
.

This has landed in the SDK.


WIP Bot API 5.1

?
!

Type
feature / improvement

BC Break
no

Fixed issues
#1186

Summary
Add all features for Bot API version 5.1 (March 2021)

@massadm, would you mind checking this PR over so I can then merge it?
You'll notice that I've removed the chat_invite_link table and save the JSON text directly. This is how other fields are saved as well. For sure the whole DB structure needs refactoring and the objects could be saved differently, but for now I think it's best to keep it simple.


Unable to get location for pointer Touch(0)

I've been attempting to use the Pointer<Up> and Pointer<Down> events to handle touches on a mobile mancala game.
With the mouse, click events are working fine, but with touch input, I have to wait about 1 second for the Pointer<Up> event to be registered properly.
Here is the code I'm attempting to use.
I can see the Pointer<Down> pretty much every time, but if I let go too early, I get the following error:
Unable to get location for pointer Touch(0)
Clearly this is happening in pointer_events. But how can I ensure that the PointerLocation gets updated properly before the second is up?

but if I let go too early

My best guess is it's caused by bevy's lack of event ordering within a frame.

AFAIK, this is fixed by #319

Fixed by #319


Fencer and Soul Blade Warlock Longsword interaction

Game 1.5.94
Mod 1.5.94 and .1
I noticed this a couple of days ago and checked it again with the new version. When a soul blade warlock with fencer is granted their bonus attack, that attack appears to not benefit from Charisma to roll/damage. I observed this with longswords: a +1, a +2, and frostburn. Curiously, it appears to work just fine with Shadow Blade.

Do you have a save?

no need. Soulblade is explicitly excluding CHA attribute on bonus attacks. It's written like this as we interpreted the rules. Asking others to confirm if we should filter out bonus or not.

Remembered now what we did. We only allow the bonus to offhand if you have Two Weapon FS. By design.

Thank you. Apologies for wasting y'all's time
On Mon, Jul 24, 2023, 1:13 PM Paulo Monteiro @.***>
wrote:

Closed #3843
https://github.com/SolastaMods/SolastaUnfinishedBusiness/issues/3843 as
completed.
—
Reply to this email directly, view it on GitHub
https://github.com/SolastaMods/SolastaUnfinishedBusiness/issues/3843#event-9903214112,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/BBOLCLULMLMHNAVEUZY3TLTXR23NHANCNFSM6AAAAAA2VN6QFA
.
You are receiving this because you authored the thread.Message ID:
<SolastaMods/SolastaUnfinishedBusiness/issue/3843/issue_event/9903214112@
github.com>

Suppose that means that Shadow Blade interaction is bugged, though? It does
appear to apply the cha bonus to the bonus action attack from fencer.
On Mon, Jul 24, 2023, 1:23 PM Gustavo Heudebert @.***>
wrote:

Thank you. Apologies for wasting y'all's time
On Mon, Jul 24, 2023, 1:13 PM Paulo Monteiro @.***>
wrote:

Closed #3843
https://github.com/SolastaMods/SolastaUnfinishedBusiness/issues/3843
as completed.
—
Reply to this email directly, view it on GitHub
https://github.com/SolastaMods/SolastaUnfinishedBusiness/issues/3843#event-9903214112,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/BBOLCLULMLMHNAVEUZY3TLTXR23NHANCNFSM6AAAAAA2VN6QFA
.
You are receiving this because you authored the thread.Message ID:
<SolastaMods/SolastaUnfinishedBusiness/issue/3843/issue_event/9903214112@
github.com>

Ended up adding an exception for fencer. On next release

Thank you for the update.
On Mon, Jul 24, 2023, 1:57 PM Paulo Monteiro @.***>
wrote:

Ended up adding an exception for fencer. On next release
—
Reply to this email directly, view it on GitHub
https://github.com/SolastaMods/SolastaUnfinishedBusiness/issues/3843#issuecomment-1648450559,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/BBOLCLSE4MO4SPQ7HU5E4KTXR3ASZANCNFSM6AAAAAA2VN6QFA
.
You are receiving this because you authored the thread.Message ID:
@.***>


Campaign goals per run

What's this PR do?
Adds fields on the campaign run node that allow admins to set signup and impact goals.
NOTE: I'm not sure why there are updates to the field_description_field but it looks like it just moved where it was in the feature export file. I didn't make any updates to that field.
How should this be reviewed?
Edit a campaign run and check out the new fields.
Relevant tickets
Fixes #6699
Checklist

[ ] Tested on staging.

NOTE: I'm not sure why there are updates to the `field_description

You need to run drush fra -y before because that field will be removed with this

@angaither ok i don't know what i'm doing wrong here. I rebuilt my dev machine to reset everything, I ran drush fra -y, I added the new goal fields and did drush fu dosomething_campaign_run and I get the same diff.
I see that the description field is removed from dosomething_campaign_run.features.field_base.inc but it does seem to still be present in dosomething_campaign_run.features.field_instance.inc (just moved up to the beginning of the file. Doesn't that mean that the field still exists?

@sbsmith86 just checked on prod and it seems that feature is overridden there as well, so it's not a thing you're doing wrong, features is acting whacky.
If we do a refresh thor/prod and you deploy this there, we can test to make sure the description field doesn't get removed & then clean up the features

@angaither ok so merge and deploy this to staging?

yaaa


Multiple 'update' actions work on initial copy

I am quite new to thermite, so pardon me if this is easy - but I have tried to run multiple update in PerformAction and it seems to me it operates on the initial data, so earlier updates are lost. I just copied this example: https://github.com/nwolverson/purescript-thermite-example , changed the performAction to
performAction Increment _ _ update = do
    update $ \state -> state { counter = state.counter + 1 }
    update $ \state -> state { counter = state.counter + 3 }

And it is incrementing by 3, not by 4. Is this correct behaviour? Reading the source code somehow makes me think it shouldn't ignore the first update, but I don't have any experience with react.

This definitely doens't seem right, although it seems partially related to https://github.com/paf31/purescript-thermite/pull/55.
I'm planning to revisit the way async state updates work after psc 0.9.1 is released tomorrow. Chances are the new solution will be based on purescript-coroutines somehow.

I think writeStateWithCallback will fix this.

This should be fixed in 1.0.


update to latest version of supervisord

this would update to the latest version of supervisord

Ok, merged (rebased actually).
I'll try to bump up Alpine, pip etc before I bump the version it and create a new docker tag.


Should work with .sh files

I want to use JetBrains' EP versions of their products. Link: https://www.jetbrains.com/resources/eap/. They deliver a .tar.gz file, which contains bin/idea.sh. When starting nix-alien with that, the result is:
err:
	not a dynamic executable

This error message is very correct. In the end, that script executes jbr/bin/java, which outputs
jbr/bin/java: You are trying to run an unpatched binary on nixos, but you have not configured NIX_LD or NIX_LD_x86_64-linux. See https://github.com/Mic92/nix-ld for more details

Executing that works:
nix --extra-experimental-features "nix-command flakes" run github:thiagokokada/nix-alien -- jbr/bin/java

But it misses the output:
Usage: java [options] <mainclass> [args...]
           (to execute a class)

When using sh -x, I can see the parameters which need to be passed to java. Then, I use nix-alien, but that misses libXext.so.6  somehow:
kotlinx.coroutines.JobCancellationException: Parent job is Cancelling; job=UndispatchedCoroutine{Cancelling}@61f6e43e

Caused by: java.lang.UnsatisfiedLinkError: /home/koppor/idea-IU-233.13135.103/jbr/lib/libawt_xawt.so: libXext.so.6: cannot open shared object file: No such file or directory

I wished, I could use nix-alien together with an sh file and that nix-alien "just" runs the script and if a binary is executed, that binary is executed using nix-alien.
I know, that could maybe not solve my issue as nix-alien won't fix the Java runtime behavior to look for shared libraries and throw an exception if not found.

Nothing we can do.
Analyzing dependencies inside scripting languages (not just Shell, also things like Python, Ruby, Lua, etc.) is basically impossible since we would need to have a deep understanding on each language (e.g.: knowing that to run a program in Python we can call subprocess.run, but also os.system and others).
The only reason nix-alien works so well for binaries is because they have a well designed mechanism to indicate their dependency (e.g.: ELF metadata), but even this can be bypassed by things like dlopen.

The only reason nix-alien works so well for binaries is because they have a well designed mechanism to indicate their dependency (e.g.: ELF metadata), but even this can be bypassed by things like dlopen.

And this is the reason that nix-alien is missing libXext.so.6, java probably loads this library dynamically and there is nothing we can do except maybe doing a deep analysis of the binary itself (but this is error prone).


Github Organization/Branch Sources plugin creates unique workspaces per job (PR/branch)

This goes somewhat against our idea to cache the checkouts.
It seems the impedance mismatch originates from us wanting to run the same testsuite for multiple repositories.

Indeed the ws (workspace) step allows to reuse the same names and also takes care of @2 suffixes for concurrent test-runs.
https://jenkins.io/doc/pipeline/steps/workflow-durable-task-step/#code-ws-code-allocate-workspace


Added new Q3D Example

This Example will show:

Import EDB project
Create a cutout
export to 3D Layout
create Q3D Project from 3D Layout
Assign Sources and sink
Create setup
solve
postprocess R and L results

No need for [::] with list comprehension.
I added a note about the factor 1000 to covert meters to mm in the comments.


Typo in readme

in mount your engine section, there's a stray '`'

fixed w/ https://github.com/schepedw/gatherable/commit/c46c3dc97861be4021fb566032de944836c03f27


Hotfix 1.3.2 alpha

Update to the .gitignore file
The .catkin_tools directory is automatically created when you do a build with "catkin build". The extra files it creates often pollutes other commits with extra junk that simply does not need to be there. This is especially the case if you clean or build often and don't consistently have the code in a built or cleaned state when doing commits for your code.
By removing the files from version control and adding the directory to the .gitignore file, we don't have to see all of these extra .catkin_tools directory files in our commits and git statuses.

Please rename this to Hotfix-1.3.3-alpha


New-AzStorageContent

The command New-AzStorageContext appears to be incorrectly referenced as New-AzStorageContent in the line "Then use the storage access key to authenticate with the New-AzStorageContent cmdlet..."

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 4679b2b7-8381-d7ba-22d3-0948ee5873ac
Version Independent ID: 84cd272f-a0a9-7e12-1aff-53b24475b048
Content: Use a Windows VM system-assigned managed identity to access Azure Storage
Content Source: articles/active-directory/managed-identities-azure-resources/tutorial-windows-vm-access-storage.md
Service: active-directory
Sub-service: msi
GitHub Login: @MarkusVi
Microsoft Alias: markvi

@PishPoshery
Thanks for your feedback! We will investigate and update as appropriate.

Since this is the new Az module you are correct. I made a pull request to update this. https://github.com/MicrosoftDocs/azure-docs-pr/pull/93651


Update slack invitation link

What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?:

NONE

/approve 🚀

/approve


⚠ Bofrost.fr has degraded performance

In 6ba6c13, Bofrost.fr (https://www.bofrost.fr) experienced degraded performance:

HTTP code: 200
Response time: 1591 ms

Resolved: Bofrost.fr performance has improved in 91c5008 after 7 minutes.


Serialization Issue w/ Processor Spec Nonstd_Instruments

Describe the bug
An issue with the serialization of 'nonstd_instruments' in processerspec.py that causes ProtocolData with experiment designs generated from a processor spec to not write.
To Reproduce
Steps to reproduce the behavior:

Create a processor spec
Create a target model from the processor spec
Add the quantum instrument to the target model
target_model[('Iz', 0)] = pygsti.modelmembers.instruments.Instrument({'p0': Q0 'p1': Q1})
Generate an experiment design from the target model
Generate data
Create a ProtocolData & attempt to save:

Expected behavior
The serialization should work correctly, allowing me to save ProtocolData with experiment designs generated from a processor spec to not write.
Environment (please complete the following information):

pyGSTi version feature-qiskit-mcm
python version 3.10

@coreyostrove I sent you over the notebook where I ran into issues over email (with the same name as this issue) because it relates to an active collaboration. I'll update this thread if I get a chance to get a chance to write a stripped down version.


add some extra linux meta data to analytics

          1 Error

:no_entry_sign:
Please include a CHANGELOG entry.

          1 Message

:book:
See http://keepachangelog.com/en/0.3.0/ for details on good changelog guidelines

  Generated by :no_entry_sign: Danger


Update http4s-async-http-client to 0.23.8

Updates org.http4s:http4s-async-http-client from 0.23.0-RC1 to 0.23.8.
GitHub Release Notes - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.http4s", artifactId = "http4s-async-http-client" } ]

labels: library-update, early-semver-minor, semver-spec-pre-release, commit-count:1

Superseded by #249.


[QUESTION] How to inject instances on handlers?

Is it possible to inject something like a repository instance in a message handler? Or is this only possible using closure approach?

Hey @ararog :wave:
Can you please provide more details? Not sure if I got your point. If you can provide code samples somehow, it'd be helpful :slightly_smiling_face:

I guess he means something like this
 class TopicHandler implements HandlerInterface {     private SomeInterface $something;     public function __construct(SomeInterface $something)     {         $this->something = $something;     }     public function __invoke(KafkaConsumerMessage $message): void     {     }
So by constructor , you can inject into handlers.
AND it is impossible to inject by __invoke method.

@ebrahimradi @ararog can you describe a use case for this? I never needed to inject anything into my handlers 🤔

for me also injecting by __invoke method is unknown. However I needed some services to do some jobs based on a message. then I injected those services by __construct() method.


Support for all GPU arch in pre-built pypi wheel

Seems this pip3 install tensorrt_llm -U --pre --extra-index-url https://pypi.nvidia.com does not works for T4 GPU. Can the pre-built wheel include all the GPU archs?

Thank you for the suggestion! We will fix this issue tomorrow.

We have solved this issue, please try again. Thank you for your support!

Thank you so much @Shixiaowei02 for superfast action! I verified it on T4 -- now it works.


fix and extend index.d.ts && fix test.run parameters

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Pull Request Test Coverage Report for Build 14

2 of 2 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.06%) to 98.261%

Totals

Change from base Build 12:
0.06%

Covered Lines:
89

Relevant Lines:
89

💛  - Coveralls


Periodic scanning of images

We would like to use kubeclarity on our cluster to periodically scan images at runtime. Is there a common approach to do that(aka, cronjob, or does kubeclarity provide an API/configuration for this)?

Hi @L1ghtman2k , Kubeclarity does have an option for periodic scan at runtime.
In the UI:

Select the runtime scan options view from the navigation pane
To schedule a scan at your preferred time, click the “Schedule Scan” option in the upper right corner

More info can be found here under Runtime Scanning Options On UI section.
Also, you can do the same with the API described here.

Would be nice if one could enable this configuration inside the values.yaml file.
This way it would be possible to roll out the same configuration to several clusters automatically.

Hi @L1ghtman2k , Kubeclarity does have an option for periodic scan at runtime.
In the UI:

Select the runtime scan options view from the navigation pane
To schedule a scan at your preferred time, click the “Schedule Scan” option in the upper right corner

More info can be found here under Runtime Scanning Options On UI section.
Also, you can do the same with the API described here.

I was more or less meant a periodic schedule, along the lines of cronjob. But I think this could just be implemented via k8s cronjobs, rather some internal construct

Hi @L1ghtman2k , Kubeclarity does have an option for periodic scan at runtime.
In the UI:

Select the runtime scan options view from the navigation pane
To schedule a scan at your preferred time, click the “Schedule Scan” option in the upper right corner

More info can be found here under Runtime Scanning Options On UI section.
Also, you can do the same with the API described here.

I was more or less meant a periodic schedule, along the lines of cronjob. But I think this could just be implemented via k8s cronjobs, rather some internal construct

Performing this with cronjobs has a drawback. Cronjobs can not know if the previous scan has completed.
Therefor i think it would be better if kubeclarity itself offers an option to schedule scans by environment variable or somthing like this, to avoid parallel scans, which could create a lot of pods inside the cluster.

@jmueller42 In your job, you could check first, if there is a scan currently in action.
https://github.com/openclarity/kubeclarity/blob/15cefca8ca45d9405d58754fc04a66d195775563/api/swagger.yaml#L983C1-L983C26


How to convert Mat to TFTensor?

I have no clue what the "Mat" type is from the above.

Seems like the type CV_8UC3 is not a supported datatype to feed into impotmat. Seems like an OpenCV problem, not a TF problem?


JCenter Shutdown

Move Artifacts

As JCenter is being shutdown in 2022, this api will need to be moved soon. Maven central would be appreciated.

See also: https://github.com/Sybit-Education/airtable.java/issues/41


Design Jisc Pilot

Depends on
What needs to be done before we can do this?

[ ] Jisc giving us contract
[ ] Jisc meetings with their OAB Team

Signicant Subtasks
Are there any large subtasks that make up this project? Something worth a tickbox?

[ ] Deciding what to pilot & Jisc signing off on that
[ ] Identifying main things that need testing
[ ] Identifying who would be up for testing

What success / done look like?
What does it look like for this project to be done?

Ready to start on-campus work / recruiting campuses in the new year

Requirements
What resources are needed for this project (e.g skills or funds)?
RACI
Who is involved in this project? Use the RACI model to identify the roles

Responsible (who's doing the work)

@JosephMcarthur, @chealsye, @meganwaps

Accountable (only one)

@JosephMcarthur

Consulted

Team, Sparc

Informed

Team, Sparc

Got rough marching orders back from Jisc on this! All good!


Build random fixes

+1, but remove 2nd patch since I moved PTHREAD and also changed to depend on HAVE_PTHREAD && SOL_PLATFORM_LINUX.

-1 , still doesn't fix the issue.

+1 modulo the 2nd patch

applied...


Quick box improvements for multi-step inputs

Continuing #45589.

Moved the showInputBox API over to the new implementation. Closing for this milestone because we are out of time. To be continued...


Diaries not being shown

I haven't completed any hard diaries even and today none of the diary helpers are being shown.

I see that this change will fix this issue to closing. Thanks
https://github.com/Zoinkwiz/quest-helper/commit/139f2ea296f2c721d12e9a61212a80aaa2f6ef61


URL Loader Invalid Options

Hi, I'm facing URL loader issue. Can you please add how to import the following from assets folder as an example?

.png/.jpg for image file
.svg for vector image
.woff for fonts

This is the error I'm getting while importing a logo.png:
ERROR in ./app/assets/images/logo.png
Module build failed: Validation Error

URL Loader Invalid Options

options.limit should be number

I found the solution to it. I changed webpack config to this, and voila it started working!
{
    test: /\.(png|jpg|gif)$/,
    use: [
        {
            loader: 'url-loader',
            options: {
                limit: 8192,
                mimetype: 'image/png',
                name: 'images/[name].[ext]',
            }
        }
    ],
}

I will send a pull request on this. Please check and merge it if it looks good enough for you :)

Hey @PrudhviRaj5, thanks for issuing the bug. I'm using the shorthand syntax, which may have been changed in the new versions. Have you tried loading a font (.eot, .woff or .otf)? Fonts are using url-loader too and I guess they'll throw the same error.

Hi @KleoPetroff, I have created a Pull Request and the change are:

change in url and file loader config,
added jest configs for handling images, fonts and etc. (this includes moving shim.js)
and upgraded package.json

Please review my pull request and merge it. After merging you can close this issue.
 I will send couple more pull requests which might deal with history fallback and redux :slightly_smiling_face:

Thank you for taking the time on this, I'll make sure to review the PR tomorrow. As for Redux, I want to give people the freedom to choose the state manager by themselves. That's one of the reasons why the Redux integration didn't happen by now. That being said, I'm totally fine with a separate branch, which includes Redux. You can check the discussion in #83


In mac , command + arrow shortcut  keyup handler is not getting called

i am using https://www.npmjs.com/package/react-hotkeys-hook hook to call the callback handler when the keyup of command+arrow keys shortcut is called
seems in IOS handler is not getting called  when key up of comman+ arrow keys

for keyup i have registered like this
useHotkeys(`command+right`, handler, {  keyup: true,
        keydown: false,} );

Also i have observed for any key combination , during keyup ,the handler is not getting triggered in Mac IOS

I have the same issue. On MacOS is not fired:
hotkeys('ctrl,command', {keyup: true})

hotkeys("ctrl+down", function(event) {
    console.log(event);
    return false;
  });
  hotkeys("ctrl+right", function(event) {
    console.log(event);
    return false;
  });

ctrl+down can trigger, but ctrl+right not work


Telemetry integration tests for Alarms

Description and Motivation
Tests include:

get list
get by id
update alarm
alarm by rule

instant
average

Change type

[ ] Bug fix
[ ] New feature
[x] Enhancement
[ ] Breaking change (breaks backward compatibility)

Checklist:

[x] All tests passed
[x] The code follows the code style and conventions of this project
[ ] The change requires a change to the documentation
[ ] I have updated the documentation accordingly

@jillcary Do we need this PR?

These changes are now here: https://github.com/Azure/azure-iot-pcs-remote-monitoring-dotnet-tests/pull/51


Replace helpers with explicit api in v4

          Thanks for the good discussion above y'all, I generally agree that we should keep it `helpers` to stay closer to Rails naming and conventions, but I think this spurred some great conversation. I love the idea of adding a "did you mean" too!

Personally, for V4 I'd want us to consider removing helpers as-is and try to prevent folks from includeing helpers onto components in favor of a more explicit API like:
class MyComponent < ViewComponent::Base
  use_helper :current_user
end

The thought being that it's much more explicit about where your data dependencies are coming from, and mocking them in unit tests is significantly easier. I don't have any plans to push that forward at the moment, but just something I've been thinking on.
Originally posted by @BlakeWilliams in https://github.com/ViewComponent/view_component/issues/1836#issuecomment-1702774344

@boardfish @BlakeWilliams @Spone @camertron I closed the previous helpers issue and created this issue to discuss @BlakeWilliams suggestion

@BlakeWilliams since you gave us the comment on this I was thinking maybe you can give us a bit of an explanation, your thoughts, some concerns, benefits, etc about this possible change

@reeganviljoen we discussed this internally and I think we're on board to give this new API a try. What we have done in the past for changes like this is to define a module that consumers can opt-into using, eg:
class MyComponent < ViewComponent::Base
  include ViewComponent::HelpersApi

  use_helper :current_user
end

It would also be nice to come up with an API that allows these helper methods to be stubbed/mocked in the test environment. Any ideas there? We came up with this, but maybe there's a better option:
class Test < Minitest::Test
  def test_something
    with_helpers(:current_user, -> { User.new }) do
      render_inline(...)
    end
  end
end

Or maybe:
class Test < Minitest::Test
  def test_something
    renderer = TestRenderer.new
    renderer.with_helper(:current_user) do
      User.new
    end
    renderer.render(TestComponent.new(...))
  end
end

Thoughts?

@camertron I agree with the above with a single addition, maybe adding a deprecation warning in when helpers is used similar to what happened with require: engine in v3

@reeganviljoen yeah, we would definitely add a deprecation warning if/when we think the feature has had long enough to mature.

@camertron I will be working towards a working example this weekend, then.


Update does not handle binary files correctly

Updating the server results in corrupted binary files (woff2, ...)
Need to fix that!!

https://github.com/cbartel/nw-company-tool/blob/05069d8db60ad4ce1787ac139344d76a9128813d/server/src/admin/admin.service.ts#L74
The problem lies here, need to build an array and then use Buffer.concat()
const data = [];
data.push(chunk);
Buffer.concat(data);

fixed it


fixed language server only running for filetypes with tree-sitter Language

I found that even when I setup lspconfig with something like this:
lspconfig.harper_ls.setup {
    filetypes = { "markdown", "text", "lua" },
}

that the harper linter would only run for lua files, not markdown or text files. I realized that this is because if new_from_language_id returns None, the linter simply wouldn't run. So I instead had the wildcard pattern return an arbitrary tree-sitter Language, and it fixed the problem.

Thanks for bringing your issue to my attention, unfortunately, I cannot merge this request in its current state.
The lack of support for the text filetype is not a bug--there simply isn't any support for it.
Its somewhat difficult to pin down how to treat those files since they are often not actually English.
Your solution to this seems to be to treat text files as .toml files, which isn't a robust enough solution for the main repository.
I replaced my harper-ls config with your snippet and was unable to replicate your issue. Would it be possible for me to get a copy of your whole Neovim config? I'd love to find the root problem.

Are you still having this issue on the latest official builds of Harper?


Next gen changes + v1 fixes

[X] Fix floating boot0 pin
[X] Fix oscillator pins
[ ] Change heartbeat LED to not be a JTAG pin
[ ] Make silkscreen more clear
[X] New USB-UART chip
[X] Fix capacitance multiplier BJT
[X] Make SWD connector 1:1 for Nuleo
[X] Make Psom work at 12V
[X] New 3.3V converter
[X] New 3.3V isolation
[X] New 12V protection
[ ] New connector
[X] New CAN ESD diode

Quality Assurance Checklist
To make reviews more efficient, please make sure the board meets the following standards and check everything off once the board meets the quality check. Once everything has been checked, the assigned reviewers will begin the review process. Edit this description to check off the list.
There are exceptions with all guidelines. As long as your decisions are justified, then you are good! Contact the reviewers or the leads about any exceptions.
Please read every word on every bullet point before checking off the corresponding box.
Minimum Prerequisites

[X] The board passes ERC and DRC.

[ ] All traces are routed.
[ ] Units are in metric.
[ ] Gerbers are in a zip file in the main directory (after physical design is done)

Please read every word on every bullet point before checking off the corresponding box.
Schematic Level Requirements

[X] Is proper noise resistance given to all peripheral devices (bypass caps and coils/ferrites)?
[X] Is proper ESD protection given to all MCU input pins (zener diodes)? You could also write the input pin rating for the MCU on the schematic.
[X] Is proper power protection given to peripheral devices (zener diodes)?
[X] Are peripheral units used properly (reading datasheet)?
[X] Are testing points added at useful places?
[X] Is there proper short to GND protection at MCU outputs (inline resistors)?
[X] Do ADC inputs have caps (appropriately sized to prevent RC delay)?
[X] Are ADC inputs biased so there is room above expected value to determine if value is being overflowed?
[X] Are LEDs located at useful places (comm, power, debugging, extra GPIO)? They should be placed in locations
[X] Are parts chosen easy to collect?
[X] Are parts chosen easy to solder?
[X] Is there reverse polarity protection on inputs?
[X] Do parts in the schematic match the actual part datasheet?

Please read every word on every bullet point before checking off the corresponding box.
BOM Requirements

[ ] Bill Of Materials: is there an Excel Sheet BOM and a Mouser Cart link?
[ ] Are all the correct parts in the BOM?
[ ] Is each part in the Mouser Cart in stock (or do we have the part in stock)?
[ ] Does each part in the Mouser Cart have a margin for part quantity?
[ ] Does every component in the schematic have a footprint, mouser link/datasheet, and reference number associated with it?

Please read every word on every bullet point before checking off the corresponding box.
Layout Level Requirements
2D Spacing

[ ] The components are spaced out at an optimal distance.

All components can be easily hand-soldered.
IPC-SM-782A Standard requires a minimum distance of 1.0mm from edge to edge.

[ ] Components that are in parallel with each other are spaced out at an equal distance when possible.
[ ] The components are aligned with each other when possible.
[ ] Components are grouped based off of functionality.

E.g. all components for CAN should be grouped.

[ ] Bypass capacitors are less than 1cm away from their respective IC's power pins.

3D Spacing

[ ] Layout of components have been placed with mounting location and usage of the board in mind.

Are PCBs going to be stacked on above/below this board? Are tall components placed accordingly?
Are buttons and lights easily accessible and viewable?
When mounted into the car, are the heights of the components and connectors accounted for?

[ ] I am not reading every word and I need to start this checklist over.

Please uncheck everything you have checked and start over.

[ ] Location of connectors and wires going out of the board will prevent messy wiring.

Are all the wires that are going in the same direction placed on the same edge of the board?

Components

[ ] Do footprints match the schematic?

Make sure pins on the footprint correspond to pins in the schematic
(e.g. counterclockwise pins on footprint and alternating pins on schematic is bad)

[ ] Custom footprints have been double checked with the datasheet.
[ ] Footprints are consistent across the PCB: i.e. all 0805 for Resistors/Capacitors
[ ] Pin 1 of the footprint is labeled in some way.
[ ] Are LED's in easy to see places?
[ ] Are test points in easy to reach places?
[ ] Are critical paths of switching converters as small as possible?

Copper Layer

[ ] The trace widths and trace clearances are greater than JLCPCB's minimum requirements (https://jlcpcb.com/capabilities/Capabilities).

[ ] Are signal traces are .15mm unless provided with reasoning?

NOTE: One net can have multiple trace widths

[ ] The trace lengths are as short as possible.

Can there be a more optimal route if you go to another layer?

[ ] Each trace's width is capable of handling the expected current flow.

Use PCB width calculator to calculate trace width.

[ ] *No sharp corners. No trace angles equal to or less than 90 degrees.

Orthogonal traces should have vias if necessary.

[ ] Are edges of board surrounded by clean ground on both layers with stitching vias?
[ ] Traces are in parallel with each other when possible (exceptions can be made to prevent signal coupling).

E.g. traces connected between an IC and MCU can be placed in parallel with each other.

[ ] There are no random trace appendages.
[ ] Vias placed in copper pads are fully encompassed in the copper pads.
[ ] Through-hole components do not have extraneous vias.
[ ] Vias should be appropriately sized according to the connected net(s) and expected current capacity.

*Not really a problem for modern manufacturing techniques but good practice and important for high speed signal integrity.
Silkscreen Layer

[ ] Visible text sizes are greater than .8mm(L), .8mm(H), .15mm(W).
[ ] All visible text is on the silkscreen layer.
[ ] All reference labels of each component are not overlapping a copper pad or another component.
[ ] All connector pins are labeled with a meaningful and helpful name.
[ ] All LEDs are labeled with a meaningful and helpful name.
[ ] Silkscreens are mostly facing one direction (or 2).

Edge Cut Layer

[ ] The dimensions of the board and the mounting holes are nice values in metric i.e. no long decimals.
[ ] The physical outline of the board is on the edge cut layer.
[ ] Edge cuts are straight and parallel with opposite edge of the board.
[ ] Mounting holes are aligned and support M3 screws. All mounting holes should have distances between them shown in comments layer.
[ ] Corners are curved and contoured to mounting holes.

Please read every word on every bullet point before checking off the corresponding box.
IMPORTANT NOTICE

[ ] I am confident that this board will be safe to use in a safety critical environment.
[ ] I have read every word on every bullet point and have only checked off a bullet point if I have read every word.
[ ] ((( OPTIONAL ))) I had fun :^)

Other Comments
Write any comments about the board that would help the reviewers here.

ok first of all why these commit messages.
Second, your 12->3.3V step down seems to have diff cap values than the application example on the datasheet (also 12->3.3V). Any particular reason why?

Specifically, the cap from BST to SW

Specifically, the cap from BST to SW

lmao, prob cuz i copy pasted the cap from somewhere else. I'll update

ok first of all why these commit messages. Second, your 12->3.3V step down seems to have diff cap values than the application example on the datasheet (also 12->3.3V). Any particular reason why?

what other cap values? Also, my commit messages are fantastic

Make sure that 47uF rated for at least 16V exist in the 0805 package

What is the point of buck converter and isolated 3v to 3v?
Why not find a 12v to 3.3v isolated DCDC?
https://www.mouser.com/ProductDetail/Flex-Power-Modules/PUA1203S1A?qs=sGAEpiMZZMv0DJfhVcWlK0%252BNBIYn4O1XHOWL70PtnWwdZCaBF3SjNw%3D%3D

Need pullup

Why are we still putting a usb to uart on the psom? This requires more time wasted doing layout and soldering. If we just attach a pin header to the uart pins, we can just use these guys to talk to the mcu.
https://www.amazon.com/HiLetgo-Module-Microcontroller-Download-Serial/dp/B00LZV1G6K/ref=sr_1_3?dib=eyJ2IjoiMSJ9.EVDg6VSjpenXHkAOIddkejC8NrNLBaiI9YKosxxcvxsDo31yf5gNeWnnyarnAb9OCFnmPEciANfEHHYdxWk7No6Tlr5vO4_ebUuJTvogA6bJhRAqyR32sxedLPvMJNlPpADhd6DlhXIqvbWpfD6wtZouD_e9KI-Gsnj13Ub-z5pL749k0X2wd9isZcagW_Mfj3YZjSd_JPMfkKkk9VzrNJbrgRwy6Swc2V3LDS_dGGg.IoI75xI360qvajynLXE5tDX2C18lfeXjeomFNl2Ltqs&dib_tag=se&keywords=ch340&qid=1725126288&sr=8-3

Change R24 to have a lower current limit, probably around 500mA. There is no reason our pSOM should be drawing 2.23A.
Lower the inrush current as well. Set C20 to around 100nF for 54mA current limit.
How were the values of R23, R5, R22 determined? I am calculating that your selection of resistors would set the over voltage protection to around 1.34V, and undervoltage protection to 1.31V

Change R24 to have a lower current limit, probably around 500mA. There is no reason our pSOM should be drawing 2.23A.
Current requirements for psom have changed since we need to drive lights for Controls

Why are we still putting a usb to uart on the psom? This requires more time wasted doing layout and soldering. If we just attach a pin header to the uart pins, we can just use these guys to talk to the mcu.
https://www.amazon.com/HiLetgo-Module-Microcontroller-Download-Serial/dp/B00LZV1G6K/ref=sr_1_3?dib=eyJ2IjoiMSJ9.EVDg6VSjpenXHkAOIddkejC8NrNLBaiI9YKosxxcvxsDo31yf5gNeWnnyarnAb9OCFnmPEciANfEHHYdxWk7No6Tlr5vO4_ebUuJTvogA6bJhRAqyR32sxedLPvMJNlPpADhd6DlhXIqvbWpfD6wtZouD_e9KI-Gsnj13Ub-z5pL749k0X2wd9isZcagW_Mfj3YZjSd_JPMfkKkk9VzrNJbrgRwy6Swc2V3LDS_dGGg.IoI75xI360qvajynLXE5tDX2C18lfeXjeomFNl2Ltqs&dib_tag=se&keywords=ch340&qid=1725126288&sr=8-3
We can get these for like 60 cents a piece on aliexpress too
Breakout out a USB port is simpler than breaking out 4 pins since we want USB debugging to be accessible while in enclosures, and the goal is to make these enclosures waterproof.

 What is the point of buck converter and isolated 3v to 3v? Why not find a 12v to 3.3v isolated DCDC? https://www.mouser.com/ProductDetail/Flex-Power-Modules/PUA1203S1A?qs=sGAEpiMZZMv0DJfhVcWlK0%252BNBIYn4O1XHOWL70PtnWwdZCaBF3SjNw%3D%3D

I see, i think imma keep the buck for the isolated side of the chip so we can use the same part for the LeaderSOM, but will make it a 12V -> 3.3V iso buck instead of 3.3V -> 3.3V.


FANBOX download enhancement

Some minor format changes made by pyCharm
Moved codes to download FANBOX cover images from processFanboxArtist to processFanboxImages, because I don't think cover images should be downloaded if the post is not accessible
Post infomation (mainly just artist_id, post_id, title, feeRequired, workDate, updatedDate, type) would be written into database first thing after 'processFanboxImages' is called inside it, before retrieving post data row from database for comparison between the newly retrieved post updated date and that written in the database. Post would not be processed if it is restricted or download history exists.
Then after everything is down, images downloaded and image info written to file, update the updatedDate in database
Added entry for download fanbox post by post ids, and some related logic in option parser thiingy

Wish I didn't miss anything....

...I am confused now about which I should be using, following or followed...
I wanted to change the apis, I mean I think it's the best, even though the old ones are still good to use.... But some classes might need to be changed a lot... and I am like tired now and don't wanna think about it anymore.... Changed some simple ones though.

Hmm... I found a problem that is to use the new url (https://api.fanbox.cc/...), there need to be a new cookie..... urr.

I will just add a new item in config, and users would need to copy and paste the new FANBOXSEESID into config in order to use it.... how is that....

Okay.... I guess I am almost done.... I will submit the changes now..

Changes required... that I can think of...

Users need to add the new cookieFanbox which is FANBOXSESSID when visiting fanbox.cc.
This cookie is not obtainable by codes... or not implemented currently

The FANBOXSESSID seems to be changing constantly....hmmm

any changes on the unit test? ensure the existing unit test doesn't break, else I need you to update it (as I don't have fanbox access).

hmmm...
I ran it and downloaded stuff...haha. I will take a rest, and take a look at unit tests later

yeah, you change the structure and it fail to import the class

Yeah. Haha. Later tonight.

tried to fix the unittest, but looks like the source json also changed?
I need to set the unittest to pass, else I cannot commit back as I have enable Travis CI

Yeah... I noticed some minor changes, like some new tokens added. But mostly the same...
So I will just fix the syntax to make it pass now...
What is that interface though...?

That one is from TravisCI, so if the build pass then I can merge the pull request, like below:

merged 😄

Hmm.. Didn't notice that before... cuz it was always green before...
Actually I think I can try to do login with account ans password...? do you think that's necessary? I just caught some packages today.... was thinking about how to obtain fanbox cookie then....

account and password

currently not possible due to captcha blocking the authentication form, right?

Actually I am not sure that's like impossible.... cuz I don't see any captcha authentication form on the page, and if it's hidden I think it could be bypassed or simulated with with execjs if it's in js or similar logic if not...?

well I tried to do login with twitter though...
anyway I don't think this should be prioritized.... and I might need further studies on that....

hmm, I'm not sure, I think it is depend on your login behaviour and your IP address? I also don't use twitter or facebook anymore.

I'm not sure either...
the important thing is that it's usable, then comes convenience.
I will look into this if I am like really bored or something. haha

Thanks for all your work so far bluerthanever.
I was about to write an issue for this but it looks like it was an intended enhancement.

Moved codes to download FANBOX cover images from processFanboxArtist to processFanboxImages, because I don't think cover images should be downloaded if the post is not accessible

FANBOX cover images can be used if you pause then resume support to see if anything has changed as well as keep track of deleted posts. Any intent to bring them back as an option if the coding isn't too much of a hassle? It doesn't really slow down the process all that much (at least not until #686 - I will try to keep that one issue informed as I was short on time but should be able to test with a VPN or proxy at some point).
Users who have new creator post notifications set can have the cover sent to their email address but that is a rather buggy thumbnail and not a default setting if I am not mistaken.

@AgentThirteen
Well, it was not on the speed side, but more on the file management side when I was moving the codes, because sometimes I download from an creator with free posts and paid ones, and there would be a whole lot of single cover images.
And in this enhancement, I recorded the updatedDate of each post which is retrieved from FANBOX API in database, so if anything has changed, I think the date is changed too and when the post is hit again it will be downloaded again.
Unless you would want those cover images intentionally?
And I am curious on how you keep track of deleted posts with cover images, do you mind sharing the idea? Not saying no yet, but curious about how different users use it.

Thank you for the quick reply.
Oh I see. That certainly makes sense if you have a lot of followed creators considering how many have a FANBOX by now. I kind of missed the updatedDate enhancement, sorry, this is good to know for the pause-and-resume usage.
As for keeping track of deleted posts with cover images, simply checking based on notifications and locally updated date as you stated as I don't use the API myself and I am not really a coding guru let alone an amateur, haha.

As for keeping track of deleted posts with cover images, simply checking based on notifications and locally updated date as you stated as I don't use the API myself and I am not really a coding guru let alone an amateur, haha.

Sorry I don't quite get this. Do you mean you keep all notification emails of an artist's new post and compare to find out which posts are deleted? Because I don't remember that FANBOX would notify users if an artist deletes their posts.
But whichever way, if you still need to download the cover image, please don't hesitate to let me know.

Yes, that's exactly what I meant. I actually keep all mail sent as updated/new post notifications as I have pretty much unlimited email storage space and it's easy to parse regardless of the amount received. A thumbnail suddenly going missing indicates that the post is gone (the same thing will happen in bell notifications but that kind of history isn't fully checkable as far as I could tell) but there are surely easier ways to tell I am not aware of.

But whichever way, if you still need to download the cover image, please don't hesitate to let me know.

That'd be much appreciated if that's possible when you have time, thanks a lot.
Not sure how many users need this though, so probably as an optional feature if you feel like that's a lot of clogging?

@Nandaka Hey, Nandaka-san. I would like to add the following enhancements, what do you think?

File formats for FANBOX posts

3 separate formats for cover images, images inside posts, and post info

Options to write HTML for posts that are not article type

an option named whenTextsLongerThan or something to write posts into HTML, when they contains more than 1 image, and texts longer than that number
a new HTML template for such posts (that are not articles) or modify the current one so it could be used for both

An option to decide whether to download cover images when post is restricted
An option to decide whether to check database download history to decide whether to download a post or not
Move FANBOX options together under FANBOX section

You means the filename formats? Currently it is already using filenameFormat for the cover, filenameMangaFormat for the images inside the post, and filenameInfoFormat for the post info. Any reason to create separate filename formats?
Should be ok.
Should be ok.
Is it something like this? Only download the post if updatedDate is different?

if config.checkFanboxPostHistory:
   result = db.getFanboxPostHistory(post_id)
   if result is not None:
      post_data = br.getFanboxPost(post_id)
      if result.updatedDate == post_data.updatedDate:
         return False # skip the post
   return True # download the post

Sure, ensure the config upgrate can be handled. I think these are the existing config for Fanbox?

writeHtml
useAbsolutePathsInHtml

Well, it seems like some users are confused, to make it easier to understand, and also, for users who would want the FANBOX posts to be saved by different formats and are not willing to use a different config. Haha, for the lazy ones?
Yup, something like that.
Hmm, Now that you've mentioned it, and I just realized that I am moving the sections, which the current structure does not support yet. I will find a way to deal with that.

well, ok. For moving section upgrade, no need to think on the way to do it automatically, just ensure all the previous configs are read then only throw the error message.
On the previous structure, I'll just move the reading code to the last line after I update the section name (treat it like new config).

Well currently, if a config is moved to another section, it will be reset... so not technically ensuring all previous configs are read... So I need to think of a solution I guess.


CORE-5341: Revisit HsmRpcOps

And align it with the rest of the APIs

@charlieR3 , @YashNabar , @nikinagy  - FYI
Can you check that the examples in the wiki pages are working as expected?

@charlieR3 , @YashNabar , @nikinagy - FYI
Can you check that the examples in the wiki pages are working as expected?

@yift-r3 - sorry I am not too familiar with those examples. On which Wiki page they can be found, please? Is it on https://github.com/corda/corda-runtime-os/wiki or somewhere in the Confluence universe?

@charlieR3 , @YashNabar , @nikinagy - FYI
Can you check that the examples in the wiki pages are working as expected?

@yift-r3 - sorry I am not too familiar with those examples. On which Wiki page they can be found, please? Is it on https://github.com/corda/corda-runtime-os/wiki or somewhere in the Confluence universe?

I thought about https://github.com/corda/corda-runtime-os/wiki/Member-Onboarding-(Dynamic-Networks) and https://github.com/corda/corda-runtime-os/wiki/Virtual-node-setup-(WIP)

@yift-r3 - yes those Wiki pages will need to be updated. I would be happy to do that. Let's approve and merge this PR and I shall update straight away.
https://github.com/corda/corda-runtime-os/wiki/Member-Onboarding-(Dynamic-Networks)
https://github.com/corda/corda-runtime-os/wiki/Virtual-node-setup-(WIP)


[Bug] elasticstack_fleet_output produces inconsistent result after 0.11.8 upgrade

Describe the bug
After upgrading the provider from 0.11.7 to 0.11.8 the provider plans to perform an in-place update to a pre-existing elasticstack_fleet_output-resource and ultimately fails.
Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
  ~ update in-place

Terraform will perform the following actions:

  # elasticstack_fleet_output.<redacted> will be updated in-place
  ~ resource "elasticstack_fleet_output" "cribl" {
        id                     = "<redacted>"
        name                   = "<redacted>"
        # (7 unchanged attributes hidden)
    }

Plan: 0 to add, 1 to change, 0 to destroy.
elasticstack_fleet_output.cribl: Modifying... [id=<redacted>]

Error: Provider produced inconsistent result after apply

When applying changes to elasticstack_fleet_output.<redacted>, provider
"provider[\"registry.terraform.io/elastic/elasticstack\"]" produced an
unexpected new value: .ca_trusted_fingerprint: was null, but now
cty.StringVal("").

This is a bug in the provider, which should be reported in the provider's own
issue tracker.
Error: Terraform exited with code 1.
Error: Process completed with exit code 1.

To Reproduce
Resource config:
resource "elasticstack_fleet_output" "<redacted>" {
  name = "<redacted>"
  type = "elasticsearch"
  config_yaml = yamlencode({
    "ssl.verification_mode" : "full",
    "ssl.certificate_authorities" : <<EOF
-----BEGIN CERTIFICATE-----
<redacted>
-----END CERTIFICATE-----
-----BEGIN CERTIFICATE-----
<redacted>
-----END CERTIFICATE-----
EOF
  })
  default_integrations = true
  default_monitoring   = true
  hosts                = [var.<redacted>]
}

Expected behavior
Don't perform any changes without showing the reason for the change. Don't fail on comparing null values to empty strings.
Debug output
Currently not possible to provide, as TF is executed as CI Pipeline with not easily accessible secrets.
Versions (please complete the following information):

OS: [e.g. Linux]
Terraform Version tag "latest" on GHA hashicorp/setup-terraform@v2
Provider version 0.11.8
Elasticsearch Version 8.15.2

Since I authored it, figured I would take a stab at this. Did you continue to have the error afterwards, or was it only transient during the upgrade?
fwiw, I can't replicate this with the following:
terraform {
  required_version = "1.8.2"
  required_providers {
    elasticstack = {
      source  = "elastic/elasticstack"
      // version = "= 0.11.7"
      version = "= 0.11.8"
    }
  }
}

provider "elasticstack" {
  elasticsearch {
    username  = "elastic"
    password  = "password"
    endpoints = ["http://localhost:9200"]
    insecure  = true
  }
  kibana {
    username  = "elastic"
    password  = "password"
    endpoints = ["http://localhost:5601"]
    insecure  = true
  }
  fleet {}
}

resource "elasticstack_fleet_output" "test" {
  name = "test"
  type = "elasticsearch"
  config_yaml = yamlencode({
    "ssl.verification_mode"       = "full",
    "ssl.certificate_authorities" = <<EOF
-----BEGIN CERTIFICATE-----
...
-----END CERTIFICATE-----
-----BEGIN CERTIFICATE-----
...
-----END CERTIFICATE-----
EOF
  })
  default_integrations = true
  default_monitoring   = true
  hosts                = ["http://localhost:9200"]
}

I confirm this bug in "0.11.8" version.
`+ resource "elasticstack_fleet_integration_policy" "pfsense_routers_lan" {
+ agent_policy_id     = "05ed761b-a3f7-4b3c-9559-9ee720261c40"
+ description         = "pfSense integrations for routers in lan network"
+ enabled             = true
+ id                  = (known after apply)
+ integration_name    = "pfsense"
+ integration_version = "1.20.2"
+ name                = "pfSense- routers lan"
+ namespace           = "default"
+ policy_id           = (known after apply)
+ vars_json           = (sensitive value)
  + input {
      + enabled      = true
      + input_id     = "pfsense-udp"
      + streams_json = (sensitive value)
      + vars_json    = (sensitive value)
    }
  + input {
      + enabled      = false
      + input_id     = "pfsense-tcp"
      + streams_json = (sensitive value)
      + vars_json    = (sensitive value)
    }
}

Plan: 1 to add, 0 to change, 0 to destroy.
elasticstack_fleet_integration_policy.pfsense_routers_lan: Creating...
╷
│ Error: Provider produced inconsistent result after apply
│
│ When applying changes to elasticstack_fleet_integration_policy.pfsense_routers_lan, provider "provider["registry.terraform.io/elastic/elasticstack"]" produced an unexpected new value: .input[0].streams_json: inconsistent values for sensitive attribute.
│
│ This is a bug in the provider, which should be reported in the provider's own issue tracker.`

Since I authored it, figured I would take a stab at this. Did you continue to have the error afterwards, or was it only transient during the upgrade?
fwiw, I can't replicate this with the following:
terraform {
  required_version = "1.8.2"
  required_providers {
    elasticstack = {
      source  = "elastic/elasticstack"
      // version = "= 0.11.7"
      version = "= 0.11.8"
    }
  }
}

provider "elasticstack" {
  elasticsearch {
    username  = "elastic"
    password  = "password"
    endpoints = ["http://localhost:9200"]
    insecure  = true
  }
  kibana {
    username  = "elastic"
    password  = "password"
    endpoints = ["http://localhost:5601"]
    insecure  = true
  }
  fleet {}
}

resource "elasticstack_fleet_output" "test" {
  name = "test"
  type = "elasticsearch"
  config_yaml = yamlencode({
    "ssl.verification_mode"       = "full",
    "ssl.certificate_authorities" = <<EOF
-----BEGIN CERTIFICATE-----
...
-----END CERTIFICATE-----
-----BEGIN CERTIFICATE-----
...
-----END CERTIFICATE-----
EOF
  })
  default_integrations = true
  default_monitoring   = true
  hosts                = ["http://localhost:9200"]
}

The error remained until I added ca_trusted_fingerprint = "" as a workaround.

@MichalMarchewka looking into your configuration you have "ennabled" : true, in the UDP input. Fixing up the typo (i.e "enabled": true) fixes the error. This is a tricky one to improve in the provider at the moment since Fleet is simply ignoring the unknown key.

@mag-mkorn I'm also not able to reproduce this and have tried a few permutations around the 0.11.8 upgrade path.
Are you able to reproduce this in a test setup where you're able to get debug logs?

Elasticsearch Version 8.15.2

Just checking this is accurate?

@mag-mkorn I'm also not able to reproduce this and have tried a few permutations around the 0.11.8 upgrade path.
Are you able to reproduce this in a test setup where you're able to get debug logs?

Elasticsearch Version 8.15.2

Just checking this is accurate?

Hi tobio,
i tried to reproduce the error on a fresh deployment. First, I didn't get the error as well. But after opening the Output Settings on the UI and clicking save, the error occurs.
So apparently saving in the UI adds the empty string variable that leads to the error.

I think that's one of the nullable problem fields too, might make sense to
default empty string that ca field
On Thu, Oct 24, 2024, 3:52 AM mag-mkorn @.***> wrote:

@mag-mkorn https://github.com/mag-mkorn I'm also not able to reproduce
this and have tried a few permutations around the 0.11.8 upgrade path.
Are you able to reproduce this in a test setup where you're able to get
debug logs?
Elasticsearch Version 8.15.2
Just checking this is accurate?
Hi tobio,
i tried to reproduce the error on a fresh deployment. First, I didn't get
the error as well. But after opening the Output Settings on the UI and
clicking save, the error occurs.
So apparently saving in the UI adds the empty string variable that leads
to the error.
—
Reply to this email directly, view it on GitHub
https://github.com/elastic/terraform-provider-elasticstack/issues/836#issuecomment-2434553346,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAFMTBC4LW3BL75OHTVHA33Z5CRNXAVCNFSM6AAAAABPUDIKNSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMZUGU2TGMZUGY
.
You are receiving this because you commented.Message ID:
@.***>

From the dupe:
Describe the bug
Updating elasticstack_fleet_output seems to break with the following error:
elasticstack_fleet_output.elasticsearch_output: Modifying... [id=8f6b6c2a-1d63-4acd-bb2d-ea653dd53168]
╷
│ Error: Provider produced inconsistent result after apply
│
│ When applying changes to elasticstack_fleet_output.elasticsearch_output, provider "provider["registry.terraform.io/elastic/elasticstack"]" produced
│ an unexpected new value: .ca_trusted_fingerprint: was null, but now cty.StringVal("").
│
│ This is a bug in the provider, which should be reported in the provider's own issue tracker.

To Reproduce
Steps to reproduce the behavior:
update hosts array with a new entry

resource "elasticstack_fleet_output" "elasticsearch_output" {
name                 = "elasticsearch"
type                 = "elasticsearch"
config_yaml          = yamlencode({})
default_integrations = true
default_monitoring   = true
hosts = [
"https://${data.terraform_remote_state.eck_elasticsearch.outputs.elasticsearch_name}-es-http.elastic-system.svc:9200",
"https://elasticsearch.acme.test.com:443" # added
]
depends_on = [
helm_release.fleet_server
]
}
Expected behavior
Expect for the fleet_output to be updated
Debug output
Run terraform command with TF_LOG=trace and provide extended information on TF operations. Please ensure you redact any base64 encoded credentials from your output.
eg
[DEBUG] provider.terraform-provider-elasticstack_v0.11.0: Authorization: Basic xxxxx==
Screenshots
Image
Versions (please complete the following information):
OS: [e.g. Linux]: Ubuntu
Terraform Version [e.g. 1.0.0]
Provider version [e.g. v0.1.0]: v0.11.11
Elasticsearch Version [e.g. 7.16.0]: 8.16.1

Additional context
I updated the fleet server from 8.15.4 to 8.16.1 at the same time


feat(esl-utils): extend attr decorator with inherit option

Closes: #2218

:tada: This PR is included in version 5.0.0-beta.11 :tada:
The release is available on:

npm package (@beta dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Render using canvas

@parisk @mofux I don't expect the code to change much now, it's mainly just tests, documentation and any bugs that pop up at this point. Please review, I know it's big but most of the changes are in new files inside src/renderer :smile:
Resolves #935
Fixes #936
Fixes #681
Fixes #730
Fixes #720
Fixes #475
Fixes #937
Fixes #920
Fixes #919

New Stuff!

Ascii characters with their foreground, 8 color and 8 bright/bold colors are pre-rendered and stored in an ImageBitmap. This is used as a texture atlas to draw to canvas really fast.

Multiple canvases are used to layer different things onto the terminal, this method is fast and allows for a nice separation of logic.

Render layers keep track of what they have drawn (when it makes sense) and as such will diff the new contents and only draw when necessary. This turns single character changes in lines to typically take < 0.25ms, down from ~6ms.

Better support for line height, font size and font family. As they're all managed within Terminal now, just setOption and run the fit addon if necessary.

There is now a very clean separation from the model and everything rendering, pretty mcuh everything that renders is within ./src/renderer (viewport being the only exception, which needs a background color set). We should move towards doing similar with the model and the DOM in Terminal to simplify and make testing easier.

Link handlers are getting reworked quite a bit as previously the validationCallback exposes the HTMLElement of the link to allow tooltips to be attached. There is now a hoverCallback which achieves a similar goal.

This fixes a bunch of bugs (see the link of "Fixes #x" above), a notable bug fixes is line characters being misaligned in vtop https://github.com/sourcelair/xterm.js/issues/937.

API Changes
See complete list of changes in the xterm.d.ts diff.
Limitations & regressions

Zooming the browser window will zoom the canvas, meaning at > 100% the text may be a little blurry.
Blink character attribute support was dropped. This is a little difficult to implement and not really worth the effort given its usage.
Links are no longer underlined when hovering (moved to deferred)

Deferred

Add new features to demo https://github.com/sourcelair/xterm.js/issues/939
Links should be underlined when hovering https://github.com/sourcelair/xterm.js/issues/940
The selection render layer should do incremental draws, currently it clears and redraws the entire selection https://github.com/sourcelair/xterm.js/issues/941

Benchmarks
This table contains the average time it takes to render when running various actions or programs.

Render time
2.9.2
canvas_render
Improvement

Typing a single letter
4-5ms
0.4-0.5ms
10x faster

vtop idle
22-73ms*
0.8-1.6ms
27-46x faster

ls -lR large_folder
17-25ms*
2.3-4.6ms
5-7x faster

yes
17-30ms*
1-1.3ms
17-23x faster

* Rendering took multiple frames
Setup

Measured on Chrome 60, Macbook Pro.
Compared https://github.com/sourcelair/xterm.js/commit/cc7c310eee72b8b43d1b5372d4482b4ca54d5b91 (master, 2.9.2) and https://github.com/Tyriar/xterm.js/commit/2d1a1bfb76974219e6a9401e709c2acad501dd15
The times are all rendering-related chunks exposed in devtools added up (render script, rendering, paint, composite layers).
I tried to take the smallest and largest samples for the range.

In pictures
Here's one of my favorites; comparing vtop's performance 🔥.
Before

After

TODO List

[ ] Flesh out API changes

[ ] Should themes just be included in ITerminalOptions instead of a new API setTheme?

[x] Better emoji support
[x] Add selection color to ITheme
[ ] Resolve/accept TODO's in code
[ ] Document classes/methods
[ ] Test

[x] Chrome/macOS
[x] Chrome/Linux
[x] Safari/macOS
[ ] Firefox
[ ] Edge
[ ] IE11

Coverage decreased (-3.7%) to 68.913% when pulling e77f1a928759bfe880c124908b6d81d074ff18a6 on Tyriar:canvas_render into 575c10114be5002b45d4d7842a6f8741ba87f5e3 on sourcelair:v3.

Coverage decreased (-3.7%) to 68.913% when pulling 29a7ee30f33f8712d9320b6465c5a678c1680dad on Tyriar:canvas_render into 575c10114be5002b45d4d7842a6f8741ba87f5e3 on sourcelair:v3.

@Tyriar I think that this is also fixing #920 and #919, right?

What about supporting italic font-style?

I think that this is also fixing #920 and #919, right?

@parisk It does indeed.

What about supporting italic font-style?

@LucaT1 I missed this, will make a note to check it out.

What about supporting italic font-style?

@LucaT1 just realised this isn't a regression https://github.com/sourcelair/xterm.js/issues/580. I won't add this to this PR to reduce complexity, it is very much accomplishable though as I checked and italic chars in the font seem to stay in the cells:

Just need to keep track of the flag against the chars and adding 'italic ' to this._ctx.font.

Coverage decreased (-4.05%) to 68.578% when pulling 0bfdff0b39010b8a49a2396aa1e389de132c3d35 on Tyriar:canvas_render into 575c10114be5002b45d4d7842a6f8741ba87f5e3 on sourcelair:v3.

Coverage decreased (-4.006%) to 68.624% when pulling a17950290c9951dde0af2862e4eb530c639b0097 on Tyriar:canvas_render into 575c10114be5002b45d4d7842a6f8741ba87f5e3 on sourcelair:v3.

Tested the new emoji feature! :tada:
Despite the fact that I'm not able to write any emoji with the MacOS prompt(cmd+ctrl+space), this is how pasting "👍🏻 👈🏿" one of these results. Do you have any idea why skin modifiers aren't supported? They should since it's a web environment.
Platform: OSX
Browser: Chrome 60.0.3112.113
Branch: Latest commit from this PR(9506c01)

Coverage decreased (-1.09%) to 71.54% when pulling 1c3028c59f9afb4623c93d142aedb9ffc49b4cd6 on Tyriar:canvas_render into 575c10114be5002b45d4d7842a6f8741ba87f5e3 on sourcelair:v3.

@LucaT1 it looks like this is not a regression, it happens on master. It looks like we're defining the modifier as a separate character https://github.com/sourcelair/xterm.js/issues/942

Coverage decreased (-1.2%) to 71.404% when pulling 9506c01824a4a348cbd637945ffd7d3ba3e89ef9 on Tyriar:canvas_render into 575c10114be5002b45d4d7842a6f8741ba87f5e3 on sourcelair:v3.

Tested on some more browsers, Firefox and IE don't work well. I'd be happy dropped IE support from the lib (Windows developers should be using Edge or another alternative at this point), not Firefox though. Will probably have to put the old renderer back and come up with a consistent interface. Investigating..

Firefox is fine when I force it to use HTMLCanvas instead of ImageBitmap for the CharAtlas. This was the fallback I added to support Safari anyway. :tada:

Coverage decreased (-1.2%) to 71.408% when pulling da1e3b40cca8017d3d311f57a7e1edc1032b359c on Tyriar:canvas_render into 575c10114be5002b45d4d7842a6f8741ba87f5e3 on sourcelair:v3.

Coverage decreased (-1.3%) to 71.333% when pulling 46b0857ef6c7d85420160ca8b19cef63f7336896 on Tyriar:canvas_render into 575c10114be5002b45d4d7842a6f8741ba87f5e3 on sourcelair:v3.

Coverage decreased (-1.3%) to 71.333% when pulling 1e728d453b7c5981853faa6978025ea23f9cfb7e on Tyriar:canvas_render into 575c10114be5002b45d4d7842a6f8741ba87f5e3 on sourcelair:v3.

Coverage decreased (-1.3%) to 71.355% when pulling 5c2d5dcd274335f1e7067f45b4a74960f9d9aa4f on Tyriar:canvas_render into 575c10114be5002b45d4d7842a6f8741ba87f5e3 on sourcelair:v3.

Coverage decreased (-1.3%) to 71.355% when pulling 7b199ac17f52146296fd30986a1996bb96258074 on Tyriar:canvas_render into 575c10114be5002b45d4d7842a6f8741ba87f5e3 on sourcelair:v3.

I have encountered a visual glitch with the canvas branch that I was unable to reproduce in master. In mc, when editing a file and scrolling, the first row of the screen does not seem to get updated properly. Usually, the first row contains a static menu bar with cyan background that shows the current row and cols the cursor is at. Here's a picture that shows the bug:

You can install mc via brew install mc and then mcedit some/file.js to reproduce the bug.

Maybe there is something wrong with the cols / rows calculated. As you can see in the screen capture, the most right cell is always empty, just as if the renderer renders cols - 1...

@mofux looks like the mc issue happens before this PR, probably fallout from the 0 scrollback alt buffer PR https://github.com/sourcelair/xterm.js/pull/855, please create a new issue 😃

Maybe there is something wrong with the cols / rows calculated. As you can see in the screen capture, the most right cell is always empty, just as if the renderer renders cols - 1...

Are you sure that's not just the space provided for the scroll bar?

Something is definitely going wrong when I resize columns down.

Coverage decreased (-1.3%) to 71.36% when pulling fb90c98f819848c0339a45dfa4bf6dcd59afa8d7 on Tyriar:canvas_render into 575c10114be5002b45d4d7842a6f8741ba87f5e3 on sourcelair:v3.

Coverage decreased (-1.3%) to 71.36% when pulling 66c891df5b0243cd276740ffb3bf169120317680 on Tyriar:canvas_render into 575c10114be5002b45d4d7842a6f8741ba87f5e3 on sourcelair:v3.

@Tyriar Support for ligatures seems to be broken (works in v3 and master). I think we should check if there is a way to support it with canvas - I'm afraid there are lots of people that use it (and some like powerline users can hardly live without it).

Support for ligatures seems to be broken (works in v3 and master)

I didn't think powerline used ligatures? https://github.com/powerline/fonts/issues/42 Do you have a screenshot of the problem?

@Tyriar Just double-checked, I thought some of the glyphs that are used by powerline are coming from the ligatures, but I was wrong, sorry 😓

🎉

I'm curious, does this renderer supports copy/pasting?

Hi @arcanis.
I am not from the Xterm.js team. But after reading the sources, I think the selection of canvas renderer was built almost as same as the custom selection logic shown in #670. There is a separate render layer to make selections work. You can also run the demo and experience its performance directly.

@arcanis copy and paste was barely touched at all, only the drawing of the selection and the events that copy/paste listened to were tweaked.

Will selection and copy/paste still work on iOS?

@tbodt probably not, I'm thinking we should probably bring back the old renderer anyway for environment edge cases. Some computers take much longer to render using canvas which I think it something to do with GPU rendering being disabled or something.


Update images in Using Pipelines and in the devConsole sections

Describe the Bug
A clear and concise description of what the bug is.
Steps to Reproduce
1.
2.
3.
Expected Behavior
A clear and concise description of what you expected to happen.
Additional context
Add any other context about the problem here. If applicable, add screenshots to help explain your problem.

Fixed via #110


Implement shortcut to run the code

Is your feature request related to a problem? Please describe.
I don't prefer use mouse while coding. I think most people don't
Describe the solution you'd like
a shortcut to run the code

The shortcut to run the code is the same as the shortcut to open the tinker console. I have stated that everywhere where in tutorials and even in the description of the shortcut. Hope that helps you!

Thanks.


Blinky lightbulb

Open https://github.com/microsoft/vscode-chrome-debug-core/blob/master/src/chrome/chromeDebugAdapter.ts
Put the cursor on a tslint warning
Get a lightbulb with quick fix suggestions, but it blinks
Seems to be related to cursor blink

I think this is a regression from 1.34 but can't be sure because it doesn't happen totally consistently.

Repos for me in that specific file around line 90. Weird

Looks like a real js/ts bug but not a regression. Too risky to fix this iteration as it involves scheduling and how we manage errors for TypeScript

The cause:

VS Code requests diagnostics (it doesn't matter why, but it has to happen in a state where there is a pending geterr request against the TSServer for the current file)
In our js/ts refactoring provider, we tell TS server to cancel its current work computing diagnostics (because we want to service the code actions request as soon as possible)
This cancel the current geterr request to the tsserver, triggers a refactor request, and then reschedules a new geterr request with the current file in it
The refactor response is returned so we show the lightbulb
But then we get back the geterr response as well, which updates diagnostics in the current file (even if they have not changed)
The diagnostic change cause VS code to request code actions again...

I fully understand why this doesn't happen all the time


Feature Request: Add .has method

This is motivated to make the library more affordable to be adopted in user cases where you are already using Map or WeakMap.
In order to have a compatible API, keyv needs to add a . has method:
https://github.com/sindresorhus/mem/blob/main/index.ts#L63
I feel the addition of this new method will be done easily and the benefit could be huge.
In the worst scenario, it could be a sugar syntactic over .get:
const has = async (key) => await this.get(key) !== undefined

Although better if we can find a lightweight implementation per every store connector.
E.g., Redis can rely on EXISTS command so you don't need the value at all.
thoughts @jytesh?

What should be the case if the user sets the value as undefined then?

https://github.com/lukechilds/keyv/issues/50#issuecomment-366122826

We should also revalidate expiry keys in keyv

IMHO makes sense to consider undefined as an illegal value at .set since the undefined value is the value used by default when the value is not set.
If you really want to specify a nullish value, then use null

alright, makes sense


Bugfix local auth

Fixed local auth. See: https://github.com/reactGo/reactGo/issues/546
This bug occurs with the postgreSQL interface

@shredd You champion! Thanks for fixing!