[4.0 a1] Input map keys wiped when upgrading from Godot 3

Godot version
4.0 alpha 1
System information
Linux Manjaro, Vulkan, Intel Kaby Lake
Issue description
Title.
They're set to "Physical" with no key associated.
Steps to reproduce
Import a project from Godot 3, I guess? (Running it once may or may not be required)
Minimal reproduction project
N/A

I can confirm this on master fc09d783f.

Same thing applies to Shortcut property of the Button (as in, a Control type, not in a physical button on the keyboard :P )
The bigger the project, the more annoying this is going to be.

Yeah, InputEventKey changed slightly in 4.0, as did Shortcut.
Should this really be handled by some engine code or should some modification be made to one of those project converters floating around?

I'd go for modifying one of the project converters, AND shipping said converter with the next alpha.

For InputEventKey, it should just be setting the store_command property to true, plus possibly some other minor changes. For Shortcut, it will just be putting the existing event from 3.X into an array of events for 4.0, as shortcuts can now have more than one event assigned.

Also it needs to change scancode to keycode.
I wouldn't bother with this though. As already said, this should be handled by converters.


change name to bucket_name to clarify the examples and source

Just updating the README and signature to stand out a little better.
I completely missed the "(replace name with name of bucket you want to upload the file to)" comment as I went straight to the method signature, then had to look at the method to see what name was.

Thanks! Makes sense :)


Backport

Will you please make a version for Team Blackout v.3.5.4

Due to the ever-changing nature of software, only the latest version of the Tumblr app is supported.

No, sorry, supporting unofficial and legacy versions opens up a whole new can of worms. If anyone else wants to do this as a fork, feel free.


Multiple projects and migrations

I seem to be in a bit of circular issue: I have a Web and a Business project. All my db access is in Business, and so when I'm in my Business directory, and run the command dnx ef migrations add FirstMigration, I get error messages complaining that "A type named 'StartupProduction' or 'Startup' could not be found in assembly Business" - but Startup wouldn't be here, it would be in the other directory/project. But if I do go into my Web project directory, I get different errors about there being no DbContext...
So is that right? Do I need a Startup.cs in my Business project? Or is there some kind of service I need to add (and more than a using statement that points to my Business project, since I have that) to the Startup.cs file?
PS Need to transfer this to the EF area, as it isn't really a documentation issue I have...

dupe of aspnet/entityframework#2679 ?

Yeah, I saw that one, but I wasn't sure if that was exactly the case, even if it's similar.
My first instinct is to just create a symlink to Startup.cs from the data access project to the project main, but that's just a hack. Instead, I began looking at the EF code, but then I wondered why it got ugly when @bricelam looked at, but then I realized I didn't understand nearly enough to even properly evaluate "ugly" so I stopped.
So thinking out loud here, if dnu/dnx knows that there is another project because it's listed in the dependencies, couldn't EF ask dnu/dnx about that? Or does dnu/dnx just keep that information to itself? Anyway, I love this stuff!

The Startup could not be found error should be resolved (in the nightly builds) by aspnet/EntityFramework#3327.
We need  aspnet/EntityFramework#2679 to fully enable the scenario, and when it's in the commands would look something like this.
cd src\Business
dnx ef migrations add MyMigration --startupProject MyWebApplication

We should have some documentation about how to get EF to work when start-up and context are in different projects.
Points to include:

How to set up startup
How to run ef commands

Consolidating with #204


GraphQL validation: "variable not defined" ignored

Do you want to request a feature or report a bug?
Bug
What is the current behavior?
Queries with undefined variables are accepted by the graph-node. This is invalid as per the GraphQL spec: https://spec.graphql.org/June2018/#sec-All-Variable-Uses-Defined
If the current behavior is a bug, please provide the steps to reproduce and if possible a minimal demo of the problem.
Example with The Graph subgraph. Same behavior on all subgraphs.
Query:
query {
  allocations(first: $first) {
    id
  }
}

Variables:
{
  "first":  10
}

===> OK
What is the expected behavior?
Query:
query {
  allocations(first: $first) {
    id
  }
}

Variables:
{
  "first":  10
}

===> ERROR
But with
query ($first: Int) {
  allocations(first: $first) {
    id
  }
}

===> OK

Hi @aasseman !
We recently introduced GraphQL validations based on the complete spec.
As far as I know, it's not rolled out to the hosted service yet, and if you are running your own graph-node, you can enable it by setting ENABLE_GRAPHQL_VALIDATIONS=1 in your environment variables.

Got it, thanks!
Closing then.

Actually there seems to be a problem.
When variables are not defined, they are silently ignored.
Query:
query {
  allocations(first: $first) {
    id
  }
}

Variables:
{
  "first":  1
}

Yields the same result as:
query {
  allocations() {
    id
  }
}

But:
query ($first: Int) {
  allocations(first: $first) {
    id
  }
}

Correctly returns the first element.
This is a serious problem because we are currently observing a large number of queries using undefined variables, and for all of those the consumer is receiving wrong data.

Actually there seems to be a problem.
When variables are not defined, they are silently ignored altogether (ie. the value of the variable is not even used for the query execution). Query:

Are you running your own graph-node with ENABLE_GRAPHQL_VALIDATIONS=1 set?

We are running an indexer in the distributed network without ENABLE_GRAPHQL_VALIDATIONS set. It looks like all indexers are running that way.
I also poked at the Discord, and no one ever mentioned that env variable before we did. Maybe validation should be on by default in some future version of graph-node? Or some other way to make it a requirement in the distributed network?
For now we don't know if being the only indexer with validation turned will be a problem for the protocol.

Since it's more about setting a standard on the distributed network, maybe @azf20 could help give some insight?

Yeah, this is a fairly new feature, introduced a few months ago, and it's still disabled until we'll roll out to the hosted service.
In the meantime, it's disabled by default. You can activate it in order to have validation that matches the complete GraphQL spec.
I understand the concern regarding activating it, especially if others are not using it as well. @lutter what do you think?

We plan on making ENABLE_GRAPHQL_VALIDATIONS the default at some point; IIRC, the current plan is to do that after API versioning has been introduced, since it's a breaking change. We actually spent a lot of time trying to understand the impact on doing proper validations in the hosted service and the network, and concluded that it's just too disruptive to do in the current setup since it requires that lots of people update their apps.
As for the current behavior: that is less than ideal and sorta implementation defined. Some variables, when ommitted, will just use some built-in default (I believe that's the case for first: $not_a_variable which will silently default to 100) The behavior should be deterministic though, just with a lot of asterisks.


Add consulo

add consulo

You’re still submitting multiple casks in the same PR. Will close this and the related ones. Do you need help making separate ones?


Error executing action enable on resource 'service[chef-client]'

Hello everyone,
exist problem with enable chef-client
mb exist any ideas?
System Info:
chef_version=14.14.14
platform=ubuntu
platform_version=22.04
ruby=ruby 2.5.7p206 (2019-10-01 revision 67816) [x86_64-linux]
program_name=/usr/bin/chef-client
executable=/opt/chef/bin/chef-client
[2022-10-26T12:45:21+00:00] FATAL: Stacktrace dumped to /var/chef/cache/chef-stacktrace.out
[2022-10-26T12:45:21+00:00] FATAL: Please provide the contents of the stacktrace.out file if you file a bug report
[2022-10-26T12:45:21+00:00] FATAL: Mixlib::ShellOut::ShellCommandFailed: service[chef-client] (chef::systemd_service line 93) had an error: Mixlib::ShellOut::ShellCommandFailed: Expected process to exit with [0], but received '1'
---- Begin output of /usr/bin/systemctl --system enable chef-client ----
STDOUT:
STDERR: Synchronizing state of chef-client.service with SysV service script with /lib/systemd/systemd-sysv-install.
Executing: /lib/systemd/systemd-sysv-install enable chef-client
update-rc.d: error: chef-client Default-Start contains no runlevels, aborting.

@dyurashevichLT please log this issue here
https://github.com/chef/chef/issues


Event "changed" on video

Hi,
I'm trying node-raspicam for record video. Apparently it's working correctly, but when I'm recording appears a lot of logs messages in console that says "raspicam::watcher::event changed".
I think while raspicam is recording, the output file is changing, and it's produces that watcher detect that changes continuously. Maybe it can be filtered when the mode is video.
Thanks

Can be found at this line:
https://github.com/troyth/node-raspicam/blob/9e1a8f7735c775e3662421c6e2e88f09709e7fe7/lib/raspicam.js#L191
Just comment that out.


Add PHP How To and Reference docs

Summary

Resolves #370
Blocked on:

[x] Need to proofread
[x] Release of PHP language family with full rewrite done

Use Cases

Checklist

[ ] I have viewed, signed, and submitted the Contributor License Agreement.
[ ] I have linked issue(s) that this PR should close using keywords or the Github UI (See docs)
[ ] I have added an integration test, if necessary.
[ ] I have reviewed the styleguide for guidance on my code quality.
[ ] I'm happy with the commit history on this PR (I have rebased/squashed as needed).

TODO:
add the following composer env vars:
COMPOSER_NO_INTERACTION=1
COMPOSER_HOME=
COMPOSER_VENDOR_DIR
PHPRC
PATH

Add details about enabling extensions

@ForestEckhardt we're releasing this today, so this can be reviewed

I'll get eyes on this today @sophiewigmore  🙂

All in all, these docs seem to cover all the functionality that was added/changed in the rewrite. I did a small amount of line editing, and asked some clarifying questions. I don't have a ton of context on what PHP devs know, so if some questions would be obvious to a PHP developer, no need to further explain.


MONGODB-364 Patch percona tool to fix S3 upload bug

Apply patch from timvaillancourt/mongodb_consistent_backup:issue_187_s3_multipart_1chunk

nm. this doesn't work.


Cannot retrain and predict using a previously saved model.

Please make sure that the boxes below are checked before you submit your issue. If your issue is an implementation question, please ask your question on StackOverflow or join the Keras Slack channel and ask there instead of filing a GitHub issue.
Thank you!

[ ] Check that you are up-to-date with the master branch of Keras. You can update with:
pip install git+git://github.com/keras-team/keras.git --upgrade --no-deps

[ ] If running on TensorFlow, check that you are up-to-date with the latest version. The installation instructions can be found here.

[y ] If running on Theano, check that you are up-to-date with the master branch of Theano. You can update with:
pip install git+git://github.com/Theano/Theano.git --upgrade --no-deps

[ ] Provide a link to a GitHub Gist of a Python script that can reproduce your issue (or just copy the script here if it is short).

Please try using this instead: https://keras.io/getting-started/faq/#how-can-i-save-a-keras-model

Please see issue #2033

https://github.com/tensorflow/tensorflow/issues/2033     check this out


How to add text programmatically?

I can't write or append text programmatically like when I am using keyboard.
I used render() and getInputExtensions().insertEditText(0 ,null ,"TEXT"); and none of them working correctly.
How can I append my text like I'm typing?

I found the solution like this :
CustomEditText editText = editor.getInputExtensions().getEditTextPrevious(editor.getChildCount());
editText.setText(editText.getText() + " " + "TEXT");


test commit

retest gpu-non-pip-multi please

retest cpu-non-pip please.

retest cpu-non-pip please


Detect pipelineRun Name while starting pipeline.

Fix: #380

Codecov Report

Merging #381 into master will decrease coverage by 0.05%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #381      +/-   ##
==========================================
- Coverage   72.92%   72.87%   -0.06%
==========================================
  Files          52       52
  Lines        3550     3543       -7
  Branches      642      640       -2
==========================================
- Hits         2589     2582       -7
  Misses        961      961

Impacted Files
Coverage Δ

src/tekton/startpipeline.ts
50.00% <100.00%> (-4.55%)
:arrow_down:

src/tkn.ts
65.95% <100.00%> (-0.29%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 991e0ee...148022f. Read the comment docs.


[don't merge] testing CI changes

By analyzing the blame information on this pull request, we identified @javache and @mhorowitz to be potential reviewers.


VoiceOver reads two words together for first element in quick open

Does this issue occur when all extensions are disabled?: Yes

Version: 1.58.2 (Universal)
Commit: c3f126316369cd610563c75b1b1725e0679adfb3
Date: 2021-07-14T22:09:06.581Z
Electron: 12.0.13
Chrome: 89.0.4389.128
Node.js: 14.16.0
V8: <IP_ADDRESS>-electron.0
OS: Darwin x64 21.1.0
Steps to Reproduce:

Press Command + P to open "quick open" panel
Type on some path
Let the screen reader (in this case voice over) reads the content:

the image shows that there is no space between the path and the file name, so the screen reader cannot separate those two and pronounce character by character, instead of word by word like it should be

Chrome upstream https://bugs.chromium.org/p/chromium/issues/detail?id=1289592
I can repro with Electron 16.

Can you still reproduce this with the latest version of VS Code?

This issue has been closed automatically because it needs more information and has not had recent activity. See also our issue reporting guidelines.
Happy Coding!


Minor updates to TRI.py and, RCRAInfo.py, plus module cleanup

The script now runs with 0 -F 1a  params, but there are some field issues causing resulting output files to be correct which I will create an issue for

chromedriver now must sit somewhere in your PATH.  From a command prompt if you type

PATH
you will see folders where you can put it.

For RCRAinfo, there is still a problem actually downloading the file - even though the link and destination folder in the code are correct it is getting a 'Failed to download'. This hangs up the python because it's stuck in the while loop (better to not use that).
Also, BR_REPORTING is now downloadable by year. So its now set to download the BR_REPORTING_year zip. I think there is no longer a need for the organize files option B.


After installing library I am getting a gradle error

Error is related to min-sdk versions and I believe I've correctly tried the use tools override library suggestion:
Error:Execution failed for task ':bugsnag-react-native:processDebugAndroidTestManifest'.
> Manifest merger failed : uses-sdk:minSdkVersion 4 cannot be smaller than version 16 declared in library [com.facebook.react:react-native:0.33.1] /Users/trobrock/Sites/Frankenstein/node_modules/bugsnag-react-native/android/build/intermediates/exploded-aar/com.facebook.react/react-native/0.33.1/AndroidManifest.xml
  	Suggestion: use tools:overrideLibrary="com.facebook.react" to force usage

Clearing my build cache and android/build folder seemed to fix this.

Reopening, because this is persistent. Seems like clearing cache helps for a bit, but then this very quickly comes back.

Apologies, someone I missed the notification for this issue. It has been addressed in v1.0.2. Let me know if this helps, @trobrock.


Status bar not dimming when stpopup is shown.

Hi,
Thanks for the awesome library.
I have one query ie status bar does not dim when stpopup is shown.
How can I get through with this issue?

Hi, you could override "preferredStatusBarStyle" or "prefersStatusBarHidden" in your view controller to decide the appearance of status bar.


too long prompt could get different response from the same model

System Info
i use 1.0.3 version
NVIDIA-SMI 525.125.06   Driver Version: 525.125.06   CUDA Version: 12.0
model  llama2-13b-16k
Information

[ ] Docker
[ ] The CLI directly

Tasks

[ ] An officially supported command
[ ] My own modifications

Reproduction
i use the same request,prompt length>6000,and multiple requests can get different response,and i set temperature=1.0 or temperature=0.001 alse can get different response.
Expected behavior
it has some random parameters here?

curl --location --request POST '<IP_ADDRESS>:8080/generate' \
--header 'Content-Type: application/json' \
-w "\n Time Total: %{time_total}\n" \
--data-raw '{
    "inputs": "def quicksort(nums):\n    ",
    "parameters": {
        "max_new_tokens": 60,
        "temperature": 0.9,
        "seed":5938575533597520045
    }
}'

You can ensure same generation results every time by adding the seed parameter.

curl --location --request POST '<IP_ADDRESS>:8080/generate' \
--header 'Content-Type: application/json' \
-w "\n Time Total: %{time_total}\n" \
--data-raw '{
    "inputs": "def quicksort(nums):\n    ",
    "parameters": {
        "max_new_tokens": 60,
        "temperature": 0.9,
        "seed":5938575533597520045
    }
}'

You can ensure same generation results every time by adding the seed parameter.

but the sampling i set is false, so the seed should no function,right?

curl --location --request POST '<IP_ADDRESS>:8080/generate' \
--header 'Content-Type: application/json' \
-w "\n Time Total: %{time_total}\n" \
--data-raw '{
    "inputs": "def quicksort(nums):\n    ",
    "parameters": {
        "max_new_tokens": 60,
        "temperature": 0.9,
        "seed":5938575533597520045
    }
}'

You can ensure same generation results every time by adding the seed parameter.

but the sampling i set is false, so the seed should no function,right?

I don't know the underlying principles of the underlying model, and I'm not even sure whether different models have similar parameters. I verified this conclusion based on tgi's  swagger api document . When my seeds are the same, I can get the same output.

different

ok，i’d try。thanks！


Add two sources to support use as actions

A couple of thin layers to allow gitgitgadget functions to be accessed from GitHub actions.  The actions are similar to misc-helper but more specialized.  Currently, nothing is published as a package.  Action providers must  run npm pack on gitgitgadget and specify the package on the npm install command in the action repo.
pull-action is used for pull request related events (create, synchronize, comment).
misc-action is used for other scheduled events such as checking mailing list emails.
Add *.tgz to .gitignore for untracked package.

Sample repo with two actions using the new functions.  These could (should) be part of gitgitgadget.  The doc suggests all actions should be in separate repos but it is not mandatory.  Since these could be used by external projects using gitgitgadget, should they be in separate projects?

Since such a lot of code is shared, I would think that it makes sense to keep things in a single repository.
I would be in favor of refactoring so that it is a single Action running in different modes.
Eventually, I want to use ncc to pack everything into a single (committed) .js file, much like I do it in setup-git-for-windows-sdk: https://github.com/git-for-windows/setup-git-for-windows-sdk/commits/7da470f0d3b358ecffc95788839430faab761963/dist

Since such a lot of code is shared, I would think that it makes sense to keep things in a single repository.

The actions in the sample have a duplicated setupGitEnvironment() but that is about it.  The reason for separate repos is to keep the workflow invocation cleaner.  This is a bit verbose:
uses: webstech/gitgitgadget-pr-action/.github/actions/pull-request@main

(location suggested in GitHub docs for multi-action repo).

I would be in favor of refactoring so that it is a single Action running in different modes.

The pull request action has different inputs so it should have its own action.yml.  The code could check what action was running and do the appropriate work but it does make it more complex.

Eventually, I want to use ncc

The sample is doing this.  The outputs are in the same folders as the action.yml.

Since such a lot of code is shared, I would think that it makes sense to keep things in a single repository.

The actions in the sample have a duplicated setupGitEnvironment() but that is about it. The reason for separate repos is to keep the workflow invocation cleaner. This is a bit verbose:
uses: webstech/gitgitgadget-pr-action/.github/actions/pull-request@main

(location suggested in GitHub docs for multi-action repo).

I agree, this would be ugly.
But maybe we can use the shorter names gitgitgadget/pr and gitgitgadget/push? FWIW feel free to move your repository into the gitgitgadget org, unless you want to play with it more before moving it.

would be in favor of refactoring so that it is a single Action running in different modes.

The pull request action has different inputs so it should have its own action.yml. The code could check what action was running and do the appropriate work but it does make it more complex.

Now I understand. And I agree with your reasoning. Thank you for being patient with me.

Eventually, I want to use ncc

The sample is doing this. The outputs are in the same folders as the action.yml.

I totally missed this (I was on my phone, I did not work last week). It looks beautiful.


$mdpTimePicker  some time watch click is not working.

Hi,
I'm implement mdptimepicker in my website, but i am facing issue ,  timepicker sometime is not working,  time between 6 to 3 is not clickable or not drag able, it reset default 6 . it happens sometime.
--------------------------------- Angular ------------------------
< div style="margin:15px 0px" >
< label >SET TIME< /label >
< div class="form-group" style="height:inherit;margin:0px" >
< input   maxlength="50" id="txthours"  ng-value=""  ng-model="txthours"   placeholder="Hours"     type="text" class="form-control  Alram-icon "  ng-click="showTimePicker($event)"  />
< /div >
< /div >
---------------------------- controller ---------------------
$scope.showTimePicker = function (ev)
{
$mdpTimePicker($scope.lastTimeSelected, { targetEvent: ev }).then(function (selectedDate) {
var hours = selectedDate.getHours();
var minutes = selectedDate.getMinutes();
var ampm = hours >= 12 ? 'PM' : 'AM';
hours = hours % 12;
hours = hours ? hours : 12; // the hour '0' should be '12'
minutes = minutes < 10 ? '0' + minutes : minutes;
var strTime = hours + ':' + minutes + ' ' + ampm;
$scope.txthours = strTime;
$scope.lastTimeSelected = selectedDate;
});
};

Hi @sheikhbarkat, can you provide a codepen of the issue?

Hi @alenaksu ,
I'm also facing the same issue.

Hi @rajeshsricharan, can you provide a codepen of the issue?

Hi @alenaksu , Its working in codepen but its not working in my project.
I'm thinking the issue is with the versions of momentjs and angular-material.
can you please suggest me the required versions ?

@alenaksu Angular messages was missing in my project. Installed messages and everything works fine now. Thanks for your time.
@sheikhbarkat can you please check whether all the dependencies are installed correctly? Thanks.

How to install Angular messages?

@sheikhbarkat bower/npm install angular-messages


Updating ZEGEMA PARADISE and PROVIDENCE planets.json fields

ZEGEMA PARADISE and PROVIDENCE did not get updated properly when the other entries in planets where updated with the type and weather_effects fields.
This Pull Request corrects that, adding the correct type and weather_effects fields to these planets.

In addition, adding the new planet effects that where added to the game just now.


Data path

It would be cool if the README or the Dockerfile would contain some info on where CouchDB stores it's data with the configuration used. That way I could make this path use a volume.

+1 This can probably be figured out but documentation would be nice.


Linux: Shown download progress early

Codecov Report

Merging #32 into master will decrease coverage by 0.07%.
The diff coverage is 66.66%.

@@            Coverage Diff             @@
##           master      #32      +/-   ##
==========================================
- Coverage   76.04%   75.97%   -0.08%
==========================================
  Files          17       17
  Lines         693      695       +2
==========================================
+ Hits          527      528       +1
- Misses        166      167       +1

Impacted Files
Coverage Δ

lib/support/linux.js
66.03% <66.66%> (-0.31%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b84a701...e404f23. Read the comment docs.


Banners before each collection on homepage

Is your feature request related to a problem? Please describe.
Merchants frequently want to add banners between collections on home, it should be easy to do inside CMS.
Describe the solution you'd like
Add a banners array field to each showcase object, then handle it on home.ejs to render a banner or list of banners (row) before each respective collection.
Describe alternatives you've considered
Edit it with EJS, more flexible but not so easy.
Additional context
Community topic: https://community.e-com.plus/t/imagens-na-pagina-inicial/203/4

New approach with page builder :smiley:


feature request - increase work area in browser

Working on a large screen I've found the map working areas frustratingly small in comparison to the available space in the browser -

As a quick fix on my end I create a chrome add-on which maximizes the screen area. I put a gist up to share the code, which is pretty simple at this point, in case there is some way to work this into the project itself -
https://gist.github.com/lklepner/f7a6fd689fc6798adce2
Here are some screenshots of the end result -

awesome... we agree that the current window size is very limited...
thanks

If there was an interest I would be happy to prepare a proper pull request
On Thu, Mar 3, 2016 at 6:26 PM Mauricio Giraldo<EMAIL_ADDRESS>wrote:

awesome... we agree that the current window size is very limited...
thanks
—
Reply to this email directly or view it on GitHub
https://github.com/nypl-spacetime/nypl-warper/issues/11#issuecomment-192018100
.

that would be great!

I've cloned the project and run vagrant up. Is there a trick to getting the
port forwarding to work for the HTTP requests from the host?
I'm able to connect to ssh through the port forwarding but haven't been
able to connect to http://<IP_ADDRESS>:3000 from my host.  If I curl directly
from the guest I see html in the response so I believe the server is
running properly..
Any ideas?
Thanks! I look forward to work on this together.
On Mon, Mar 7, 2016 at 11:13 AM, Mauricio Giraldo<EMAIL_ADDRESS>wrote:

that would be great!
—
Reply to this email directly or view it on GitHub
https://github.com/nypl-spacetime/nypl-warper/issues/11#issuecomment-193321218
.

if you curl <IP_ADDRESS>:3000 all is well but not if you open it in the browser? what response do you get in curl? what do you get in browser? a blank page?

Starting rails with -b <IP_ADDRESS> did the trick. I'll submit a PR with the
changes.
On Mon, Mar 7, 2016 at 1:30 PM, Mauricio Giraldo<EMAIL_ADDRESS>wrote:

if you curl <IP_ADDRESS>:3000 all is well but not if you open it in the
browser? what response do you get in curl? what do you get in browser? a
blank page?
—
Reply to this email directly or view it on GitHub
https://github.com/nypl-spacetime/nypl-warper/issues/11#issuecomment-193384031
.

PR submitted. I'm still running into another problem - nothing from the
assets folder is loading. Everything except the page itself is coming back
404.
On Mon, Mar 7, 2016 at 1:50 PM, Lou Klepner<EMAIL_ADDRESS>wrote:

Starting rails with -b <IP_ADDRESS> did the trick. I'll submit a PR with the
changes.
On Mon, Mar 7, 2016 at 1:30 PM, Mauricio Giraldo<EMAIL_ADDRESS>
wrote:

if you curl <IP_ADDRESS>:3000 all is well but not if you open it in the
browser? what response do you get in curl? what do you get in browser? a
blank page?
—
Reply to this email directly or view it on GitHub
https://github.com/nypl-spacetime/nypl-warper/issues/11#issuecomment-193384031
.

Seems like the assets 404s might be tied into the hostname / ip problem I
ran into when initially starting up -
Started GET "/warper/assets/jquery.nouislider.all.min.js?body=1" for
<IP_ADDRESS> at 2016-03-07 18:56:51 +0000
Cannot render console from <IP_ADDRESS>! Allowed networks: <IP_ADDRESS>, ::1,
<IP_ADDRESS>/<IP_ADDRESS>
On Mon, Mar 7, 2016 at 1:58 PM, Lou Klepner<EMAIL_ADDRESS>wrote:

PR submitted. I'm still running into another problem - nothing from the
assets folder is loading. Everything except the page itself is coming back
404.
On Mon, Mar 7, 2016 at 1:50 PM, Lou Klepner<EMAIL_ADDRESS>wrote:

Starting rails with -b <IP_ADDRESS> did the trick. I'll submit a PR with the
changes.
On Mon, Mar 7, 2016 at 1:30 PM, Mauricio Giraldo <
<EMAIL_ADDRESS>wrote:

if you curl <IP_ADDRESS>:3000 all is well but not if you open it in the
browser? what response do you get in curl? what do you get in browser? a
blank page?
—
Reply to this email directly or view it on GitHub
https://github.com/nypl-spacetime/nypl-warper/issues/11#issuecomment-193384031
.

The initial problem had been an empty response at port 3000. Adding -b
<IP_ADDRESS> caused the main page to load but the assets are still coming back
404.
It looks like the rails server config might be throwing an error here as
well -
Cannot render console from <IP_ADDRESS>! Allowed networks: <IP_ADDRESS>, ::1,
<IP_ADDRESS>/<IP_ADDRESS>
On Mon, Mar 7, 2016 at 2:01 PM, Lou Klepner<EMAIL_ADDRESS>wrote:

Seems like the assets 404s might be tied into the hostname / ip problem I
ran into when initially starting up -
Started GET "/warper/assets/jquery.nouislider.all.min.js?body=1" for
<IP_ADDRESS> at 2016-03-07 18:56:51 +0000
Cannot render console from <IP_ADDRESS>! Allowed networks: <IP_ADDRESS>, ::1,
<IP_ADDRESS>/<IP_ADDRESS>
On Mon, Mar 7, 2016 at 1:58 PM, Lou Klepner<EMAIL_ADDRESS>wrote:

PR submitted. I'm still running into another problem - nothing from the
assets folder is loading. Everything except the page itself is coming back
404.
On Mon, Mar 7, 2016 at 1:50 PM, Lou Klepner<EMAIL_ADDRESS>wrote:

Starting rails with -b <IP_ADDRESS> did the trick. I'll submit a PR with the
changes.
On Mon, Mar 7, 2016 at 1:30 PM, Mauricio Giraldo <
<EMAIL_ADDRESS>wrote:

if you curl <IP_ADDRESS>:3000 all is well but not if you open it in the
browser? what response do you get in curl? what do you get in browser? a
blank page?
—
Reply to this email directly or view it on GitHub
https://github.com/nypl-spacetime/nypl-warper/issues/11#issuecomment-193384031
.

Adding a whitelist for <IP_ADDRESS> to the development.rb config file cleared
up the render errors -
class Application < Rails::Application
config.web_console.whitelisted_ips = '<IP_ADDRESS>'
end
I'm not sure if you want this change in a PR.
Initial map data - is there a way for me to obtain a dump of map data to
restore locally?
On Mon, Mar 7, 2016 at 2:23 PM, Lou Klepner<EMAIL_ADDRESS>wrote:

The initial problem had been an empty response at port 3000. Adding -b
<IP_ADDRESS> caused the main page to load but the assets are still coming back
404.
It looks like the rails server config might be throwing an error here as
well -
Cannot render console from <IP_ADDRESS>! Allowed networks: <IP_ADDRESS>, ::1,
<IP_ADDRESS>/<IP_ADDRESS>
On Mon, Mar 7, 2016 at 2:01 PM, Lou Klepner<EMAIL_ADDRESS>wrote:

Seems like the assets 404s might be tied into the hostname / ip problem I
ran into when initially starting up -
Started GET "/warper/assets/jquery.nouislider.all.min.js?body=1" for
<IP_ADDRESS> at 2016-03-07 18:56:51 +0000
Cannot render console from <IP_ADDRESS>! Allowed networks: <IP_ADDRESS>, ::1,
<IP_ADDRESS>/<IP_ADDRESS>
On Mon, Mar 7, 2016 at 1:58 PM, Lou Klepner<EMAIL_ADDRESS>wrote:

PR submitted. I'm still running into another problem - nothing from the
assets folder is loading. Everything except the page itself is coming back
404.
On Mon, Mar 7, 2016 at 1:50 PM, Lou Klepner<EMAIL_ADDRESS>wrote:

Starting rails with -b <IP_ADDRESS> did the trick. I'll submit a PR with the
changes.
On Mon, Mar 7, 2016 at 1:30 PM, Mauricio Giraldo <
<EMAIL_ADDRESS>wrote:

if you curl <IP_ADDRESS>:3000 all is well but not if you open it in the
browser? what response do you get in curl? what do you get in browser? a
blank page?
—
Reply to this email directly or view it on GitHub
https://github.com/nypl-spacetime/nypl-warper/issues/11#issuecomment-193384031
.

the 404s might be because it is looking in the /warper folder. i tried running without the prefix and changing this in config/environments/development.rb:
config.action_controller.relative_url_root = ""
config.action_mailer.default_url_options = { :script_name => "" }

running the server now loads the CSS properly

Thanks for the tips on the 404s. I think i've got everything running now.
Next up I need to figure out how to load sample data.. and then a sample
user account (i see notes in the readme) so i can access the interface as
an authenticated user.
On Mon, Mar 7, 2016 at 4:49 PM, Mauricio Giraldo<EMAIL_ADDRESS>wrote:

the 404s might be because it is looking in the /warper folder. i tried
running without the prefix and changing this in
config/environments/development.rb:
config.action_controller.relative_url_root = ""
config.action_mailer.default_url_options = { :script_name => "" }
running the server now loads the CSS properly
—
Reply to this email directly or view it on GitHub
https://github.com/nypl-spacetime/nypl-warper/issues/11#issuecomment-193469202
.

the readme does not tell you to add a confirmed_at date. do so or you will be unable to login
(many things to improve in the docs ¯_(ツ)_/¯)
i guess to load sample data is best to upload some raster map for now.

I'll try creating an account and uploading a raster map. I'd also be happy
to help clean up the docs as I go through things.
I'm experiencing extremely slow response times when moving page to page on
the local dev instance of the project - often times pages take a minute or
longer to load all of their assets.  Is there something I can do to address
this?
On Mon, Mar 7, 2016 at 5:36 PM, Mauricio Giraldo<EMAIL_ADDRESS>wrote:

the readme does not tell you to add a confirmed_at date. do so or you
will be unable to login
(many things to improve in the docs ¯_(ツ)_/¯)
i guess to load sample data is best to upload some raster map for now.
—
Reply to this email directly or view it on GitHub
https://github.com/nypl-spacetime/nypl-warper/issues/11#issuecomment-193487104
.

the thing is the Vagrant version is virtualized so it basically creates a mini Ubuntu and runs it. if you feel brave you can try installing all dependencies manually in your computer (it's a lot of dependencies). if you know Vagrant you can try giving more resources to that instance (i don't know Vagrant).
docs help would be great

I was able to speed up vagrant by increasing the memory and switching to
NFS for the fileshare.
The next stumbling block is getting the DB initialized -
vagrant@vagrant-ubuntu-trusty-64:~$ sudo su - postgres
postgres@vagrant-ubuntu-trusty-64:~$ psql mapwarper_dev -c "create
extension postgis;"
psql: FATAL:  database "mapwarper_dev" does not exist
Its been ages since I've done anything with postgres and even then I wasn't
working in the console. Can you advise?
On Wed, Mar 9, 2016 at 12:58 PM, Mauricio Giraldo<EMAIL_ADDRESS>wrote:

the thing is the Vagrant version is virtualized so it basically creates a
mini Ubuntu and runs it. if you feel brave you can try installing all
dependencies manually in your computer (it's a lot of dependencies). if you
know Vagrant you can try giving more resources to that instance (i don't
know Vagrant).
docs help would be great
—
Reply to this email directly or view it on GitHub
https://github.com/nypl-spacetime/nypl-warper/issues/11#issuecomment-194424655
.

if you do vagrant you dont need to do any of that... it "just works" and you only do:
cd /srv/mapwarper
rails c

create the user and exit
rails s

Gotcha - so at the rails c irb prompt I should paste in the db
initialization below?
user = User.new
user.login = "super"
user.email =<EMAIL_ADDRESS>user.password = "your_password"
user.password_confirmation = "your_password"
user.activated_at = Time.now
user.confirmed_at = Time.now
user.save
role = Role.find_by_name('super user')
user = User.find_by_login('super')
permission  = Permission.new
permission.role = role
permission.user = user
permission.save
role = Role.find_by_name('administrator')
permission = Permission.new
permission.role = role
permission.user = user
permission.save
On Wed, Mar 9, 2016 at 1:47 PM, Mauricio Giraldo<EMAIL_ADDRESS>wrote:

if you do vagrant you dont need to do any of that... it "just works" and
you only do:
cd /srv/mapwarper
rails c
create the user and exit
rails s
—
Reply to this email directly or view it on GitHub
https://github.com/nypl-spacetime/nypl-warper/issues/11#issuecomment-194446894
.

correct
that creates a user with login<EMAIL_ADDRESS>and pass your_password

Excellent - i'm in now! Many thanks for walking me through this. It wasn't
clear to me from the readme that the db initialization should take place
after the rails c command.
Can you advise on how to load a raster map to get the ball rolling? is
there any docs on this?
On Wed, Mar 9, 2016 at 1:50 PM, Mauricio Giraldo<EMAIL_ADDRESS>wrote:

correct
that creates a user with login<EMAIL_ADDRESS>and pass
your_password
—
Reply to this email directly or view it on GitHub
https://github.com/nypl-spacetime/nypl-warper/issues/11#issuecomment-194448010
.

this codebase only supports maps from nypl. fortunately, many of our maps are public domain so you can test it. for this you need a Digital Collections API account and token from http://api.repo.nypl.org/. the warper imports (subject to throttling limits) based on the map UUID visible in the item page (a66456f6-3860-95d5-e040-e00a18065ecc in this case):

add the generated api token to the /config/nypl_repo.yml file (example file)
re-start the server and log in with a super user
go to Admin / Imports
Add New Import
Select Import Type: Map and type in the UUID: a66456f6-3860-95d5-e040-e00a18065ecc and click Create
Click Start Import

this will take a few minutes to pull the map. you now have a map you can work with and test code.

Thanks for the outline. I've got the map imported. Would you like me to add
these notes to the readme file?
On Wed, Mar 9, 2016 at 3:22 PM, Mauricio Giraldo<EMAIL_ADDRESS>wrote:

this codebase only supports maps from nypl. fortunately, many of our maps
are public domain so you can test it. for this you need a Digital
Collections API account and token from http://api.repo.nypl.org/. the
warper imports (subject to throttling limits) based on the map UUID visible
in the item page
http://digitalcollections.nypl.org/items/a66456f6-3860-95d5-e040-e00a18065ecc
(a66456f6-3860-95d5-e040-e00a18065ecc in this case):

add the generated api token to the /config/nypl_repo.yml file (example
file
https://github.com/nypl-spacetime/nypl-warper/blob/master/config/nypl_repo.yml.example
)
re-start the server and log in with a super user
go to Admin / Imports
Add New Import
Select Import Type: Map and type in the UUID:
a66456f6-3860-95d5-e040-e00a18065ecc and click Create
Click Start Import

this will take a few minutes to pull the map. you now have a map you can
work with and test code.
—
Reply to this email directly or view it on GitHub
https://github.com/nypl-spacetime/nypl-warper/issues/11#issuecomment-194490879
.

i'm adding these notes right now... about to re-test and push

done

Do you have any preference where the calculation for the expanded layout
would be added into the mix?
I've been leaning towards /app/views/layouts/mapdetail.html.erb lines 49-83
On Wed, Mar 9, 2016 at 4:58 PM, Mauricio Giraldo<EMAIL_ADDRESS>wrote:

done https://github.com/nypl-spacetime/nypl-warper#development
—
Reply to this email directly or view it on GitHub
https://github.com/nypl-spacetime/nypl-warper/issues/11#issuecomment-194527950
.

that makes sense

I'm getting an error when refreshing the maps page after applying a crop
outline -
Error in loading GML file
http://mapwarper.livefeed.net:3000/shared/masks/1.gml.ol?1459536456
You can try it here -
http://mapwarper.livefeed.net:3000/warper/maps/1#Crop_tab
Any idea about the cause/resolution here?
On Wed, Mar 30, 2016 at 5:41 PM, Mauricio Giraldo<EMAIL_ADDRESS>wrote:

that makes sense
—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
https://github.com/nypl-spacetime/nypl-warper/issues/11#issuecomment-203646272

url not opening for me

this may have to do with the src_maps_dir and dst_maps_dir which by default are in the /public/mapimages folder. if you customized that folder in config/application.yml then you need to make sure it is writable and all that

appplication.yml has default values at this point.
I see files are being created in the mapimages folder
public/mapimages/1.gfs
public/mapimages/1.gml
public/mapimages/1.gml.ol
public/mapimages/dst/1.tif
public/mapimages/dst/png/1.png
public/mapimages/dst/png/1.png.aux.xml
public/mapimages/src/a66456f6-3860-95d5-e040-e00a18065ecc.tif
public/mapimages/src/a66456f6-3860-95d5-e040-e00a18065ecc.tif_masked
On Fri, Apr 1, 2016 at 2:59 PM, Mauricio Giraldo<EMAIL_ADDRESS>wrote:

this may have to do with the src_maps_dir and dst_maps_dir which by
default are in the /public/mapimages folder. if you customized that
folder in config/application.yml then you need to make sure it is
writable and all that
—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
https://github.com/nypl-spacetime/nypl-warper/issues/11#issuecomment-204523378

🤔
is the gml valid? did you crop it in the crop tab? i still cannot view the URL

The .gml and .gml.ol files look valid at first glance -
.gml
<wfs:FeatureCollection
xmlns:wfs='http://www.opengis.net/wfs'><gml:featureMember
xmlns:gml='http://www.opengis.net/gml'><feature:features xmlns:feature='
http://mapserver.gis.umn.edu/mapserver'
fid='OpenLayers.Feature.Vector_2156'>feature:geometrygml:Polygongml:outerBoundaryIsgml:LinearRing<gml:coordinates
cs=',' decimal='.' ts=' '>1488.548,496.17199999999957
3132.084,898.1880000000001 2753.716,3369.404 1269.804,3712.3
1098.356,3339.844 1263.892,1991.908 1293.4520000000023,1421.400000000002
1399.8680000000004,706.0479999999961
1488.548,496.17199999999957</gml:coordinates></gml:LinearRing></gml:outerBoundaryIs></gml:Polygon></feature:geometry></feature:features></gml:featureMember></wfs:FeatureCollection>
.gml.ol
<wfs:FeatureCollection
xmlns:wfs="http://www.opengis.net/wfs"><gml:featureMember
xmlns:gml="http://www.opengis.net/gml"><feature:features xmlns:feature="
http://mapserver.gis.umn.edu/mapserver"
fid="OpenLayers.Feature.Vector_2156">feature:geometrygml:Polygongml:outerBoundaryIsgml:LinearRing<gml:coordinates
decimal="." cs="," ts=" ">1488.548,4915.828 3132.084,4513.812
2753.716,2042.596 1269.804,1699.7 1098.356,2072.156 1263.892,3420.092
1293.4520000000023,3990.599999999998 1399.8680000000004,4705.952000000004
1488.548,4915.828</gml:coordinates></gml:LinearRing></gml:outerBoundaryIs></gml:Polygon></feature:geometry></feature:features></gml:featureMember></wfs:FeatureCollection>
Are you able to log the page itself?
On Fri, Apr 1, 2016 at 3:48 PM, Mauricio Giraldo<EMAIL_ADDRESS>wrote:

🤔
is the gml valid? did you crop it in the crop tab? i still cannot view the
URL
—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
https://github.com/nypl-spacetime/nypl-warper/issues/11#issuecomment-204541149

i get:
Unable to connect
Firefox can't establish a connection to the server at mapwarper.livefeed.net:3000.

in Firefox and:
This site can’t be reached
mapwarper.livefeed.net refused to connect.

in Chrome
removing the port number doesn't help either

Hmmm. Its a new setup but I tested it from a remote computer and was able
to load http://mapwarper.livefeed.net:3000/warper/maps/1
On Fri, Apr 1, 2016 at 4:25 PM, Mauricio Giraldo<EMAIL_ADDRESS>wrote:

i get:
Unable to connect
Firefox can't establish a connection to the server at mapwarper.livefeed.net:3000.
in Firefox and:
This site can’t be reachedmapwarper.livefeed.net refused to connect.
in Chrome
removing the port number doesn't help either
—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
https://github.com/nypl-spacetime/nypl-warper/issues/11#issuecomment-204555616

seems to be a NYPL network issue. i can access it through a VPN… VPN is a bit slow/glitchy so I cannot test very well… will try back home

Any luck from home? I was hoping to use this server to review frontend
changes together.
On Fri, Apr 1, 2016 at 4:45 PM Mauricio Giraldo<EMAIL_ADDRESS>wrote:

seems to be a NYPL network issue. i can access it through a VPN… VPN is a
bit slow/glitchy so I cannot test very well… will try back home
—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
https://github.com/nypl-spacetime/nypl-warper/issues/11#issuecomment-204561021

i created an account but had an error... maybe you can go to the admin and approve me as a user?

account approved and set to role super.

i drew a mask and started the masking process. but i still need a vpn to view this url and my vpn is not very stable so it is hard to know what is going on. does it work properly in localhost? could it be a config problem in livefeed?

I'm able to load things on my local network and over VNC using a client's
remote computer. I'm guessing the NYPL outbound firewall is blocking
requests to port 3000? I can try moving things over to port 80. I only have
a single IP and have a few things running on it so I'll need to setup a
reverse proxy through the other VM.
On Mon, Apr 4, 2016 at 10:28 AM, Mauricio Giraldo<EMAIL_ADDRESS>wrote:

i drew a mask and started the masking process. but i still need a vpn to
view this url and my vpn is not very stable so it is hard to know what is
going on. does it work properly in localhost? could it be a config problem
in livefeed?
—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
https://github.com/nypl-spacetime/nypl-warper/issues/11#issuecomment-205321525

ok i think i found it:
the /shared/masks folder is hardcoded so it is not taking into account the real location
🤔
if the config file points to some network drive (which is the case for the current production server), a mapping needs to be done to point that path to the drive
if it is just the default (empty) url then no need to use /shared/masks but /warper/mapimages/1.gml.ol
i added a new branch with a quick fix to this, although still hardcoded to /warper/ but would work for instances that use that extra folder structure

That did the trick - thanks!
On Mon, Apr 4, 2016 at 11:45 AM, Mauricio Giraldo<EMAIL_ADDRESS>wrote:

ok i think i found it:
the /shared/masks folder is hardcoded so it is not taking into account
the real location
🤔
if the config file points to some network drive (which is the case for the
current production server), a mapping needs to be done to point that path
to the drive
if it is just the default (empty) url then no need to use /shared/masks
but /warper/mapimages/1.gml.ol
i added a new branch
https://github.com/nypl-spacetime/nypl-warper/tree/crop with a quick
fix to this, although still hardcoded to /warper/ but would work for
instances that use that extra folder structure
—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
https://github.com/nypl-spacetime/nypl-warper/issues/11#issuecomment-205358977

one thing we could do is increase the default height (maybe twice as much as it is right now) and disable the scroll-to-zoom feature in the map… it is annoying and we already have a zoom in/out button/slider
this would make it a very simple fix

This sounds like a good starting point. The scroll to zoom is extremely
erratic as currently implemented. Ive been reading the openlayers docs to
see if there is a way to slow it down..
On Mon, Apr 4, 2016 at 5:11 PM Mauricio Giraldo<EMAIL_ADDRESS>wrote:

one thing we could do is increase the default height (maybe twice as much
as it is right now) and disable the scroll-to-zoom feature in the map… it
is annoying and we already have a zoom in/out button/slider
this would make it a very simple fix
—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
https://github.com/nypl-spacetime/nypl-warper/issues/11#issuecomment-205499354

dont bother slowing it down... straight out disable would be ideal...

Sounds good. I'll give it a try in the morning.
On Mon, Apr 4, 2016 at 5:26 PM Mauricio Giraldo<EMAIL_ADDRESS>wrote:

dont bother slowing it down... straight out disable would be ideal...
—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
https://github.com/nypl-spacetime/nypl-warper/issues/11#issuecomment-205503386

I've made some modifications to the Show tab:

removed zoomwheel (by disabling MouseDefaults control for this map)
moved resize functionality into unwarped.js so its instantiated when the
tab is first opened
setup resize listener to adjust layout when browser is resized
adjusted the maxResolution so the unwarped_image fills the available space

http://mapwarper.livefeed.net/warper/maps/1
The other tabs haven't been changed at this point other than changing the
default height from 500px to 1000px.
How does this look on your end?
On Mon, Apr 4, 2016 at 5:27 PM, Lou Klepner<EMAIL_ADDRESS>wrote:

Sounds good. I'll give it a try in the morning.
On Mon, Apr 4, 2016 at 5:26 PM Mauricio Giraldo<EMAIL_ADDRESS>wrote:

dont bother slowing it down... straight out disable would be ideal...
—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
https://github.com/nypl-spacetime/nypl-warper/issues/11#issuecomment-205503386

seems to be down

My router is on its last legs.. I gave it a reboot and it seems to be
working now. Want to give it another whirl?
On Tue, Apr 5, 2016 at 12:13 PM, Mauricio Giraldo<EMAIL_ADDRESS>wrote:

seems to be down
—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
https://github.com/nypl-spacetime/nypl-warper/issues/11#issuecomment-205877083

looks great

I expanded the layout changes to the rectify and crop tabs (zoomwheel
change is not yet in)

animating transitions between showing the complete header for the Show
tab vs maximizing the workspace for Rectify and Crop tabs
improving the scroll position calculation basing it on the wooTabs
position rather than an arbitrary number which became inaccurate if the map
title wrapped to multiple lines

http://mapwarper.livefeed.net/warper/maps/1
If this is heading in a good direction from your standpoint I can continue
with more tabs.
Question on insets - is there a way to name them?
On Tue, Apr 5, 2016 at 1:12 PM, Mauricio Giraldo<EMAIL_ADDRESS>wrote:

looks great
—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
https://github.com/nypl-spacetime/nypl-warper/issues/11#issuecomment-205903003

looking good! can you make the animation a bit quicker?
insets inherit their parent metadata so no, can't be renamed :\

Thanks for the positive feedback. I've sped up the animations from 2000ms
to 500ms. I'll start working on the rest of the tabs.
Insets are pretty confusing without the ability to assign a name to them -
they look like duplicates of the original map in the map listings / align
tool. Would it make sense to create a new issue / feature request to
address this at some point?
On Wed, Apr 6, 2016 at 11:25 AM, Mauricio Giraldo<EMAIL_ADDRESS>wrote:

looking good! can you make the animation a bit quicker?
insets inherit their parent metadata so no, can't be renamed :\
—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
https://github.com/nypl-spacetime/nypl-warper/issues/11#issuecomment-206426214

Another quick question - can you point me towards some documentation on how
the align tool works?
I've been hesitant to try it since I'm unsure how the overwrite and type of
alignment options will play out.
Am I correct in expecting the alignment tool will enable the original map
and multiple insets to be viewed as a single map?
On Wed, Apr 6, 2016 at 12:24 PM, Lou Klepner<EMAIL_ADDRESS>wrote:

Thanks for the positive feedback. I've sped up the animations from 2000ms
to 500ms. I'll start working on the rest of the tabs.
Insets are pretty confusing without the ability to assign a name to them -
they look like duplicates of the original map in the map listings / align
tool. Would it make sense to create a new issue / feature request to
address this at some point?
On Wed, Apr 6, 2016 at 11:25 AM, Mauricio Giraldo <
<EMAIL_ADDRESS>wrote:

looking good! can you make the animation a bit quicker?
insets inherit their parent metadata so no, can't be renamed :\
—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
https://github.com/nypl-spacetime/nypl-warper/issues/11#issuecomment-206426214

re insets: yes... make a new issue about it... or maybe the issue is that the “insetness” of an inset is not readily apparent... if there were a better way of signaling this... in the UI... maybe: metadata title (inset 1)
re alignment tool: we don't need to do the fancy resizing there. i think what it does is allow for maps that are close to each other in the same layer to use their overlapping control points. see this layer for example

If I understand correctly.. the align tool isn't really applicable to the
combining multiple insets. Are insets completely independent maps other
than the metadata and image?
I've completed the Crop and Rectify tabs, disabling the zoomwheel and
cleaning up the associated JS. I think we're in pretty good shape at this
point so I've submitted a PR.
https://github.com/nypl-spacetime/nypl-warper/pull/21
On Wed, Apr 6, 2016 at 12:38 PM, Mauricio Giraldo<EMAIL_ADDRESS>wrote:

re insets: yes... make a new issue about it... or maybe the issue is that
the “insetness” of an inset is not readily apparent... if there were a
better way of signaling this... in the UI... maybe: metadata title (inset
1)
re alignment tool: we don't need to do the fancy resizing there. i think
what it does is allow for maps that are close to each other in the same
layer to use their overlapping control points. see this layer
http://maps.nypl.org/warper/layers/859 for example
—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
https://github.com/nypl-spacetime/nypl-warper/issues/11#issuecomment-206456195

thanks! :fist:


Unable to convert to float

When esphome looses connecting to a node the entity referred in the daily sensor becomes unavailable. This leads to a bunch of errors in the log until the connection is re-established and the entity becomes available again.
2021-05-28 06:35:22 WARNING (MainThread) [homeassistant.components.esphome] Can't connect to ESPHome API for energymeter (<IP_ADDRESS>): Timeout while connecting to ('<IP_ADDRESS>', 6053)
2021-05-28 06:35:34 WARNING (MainThread) [homeassistant.components.esphome] Error getting initial data for <IP_ADDRESS>: Timeout while waiting for API response!
2021-05-28 06:35:43 ERROR (SyncWorker_46) [custom_components.daily.sensor] unable to convert unavailable to float.
2021-05-28 06:35:43 ERROR (SyncWorker_46) [custom_components.daily.sensor] unable to convert to float.
2021-05-28 06:35:43 ERROR (SyncWorker_46) [custom_components.daily.sensor] unable to convert unavailable to float.
2021-05-28 06:35:43 ERROR (SyncWorker_46) [custom_components.daily.sensor] unable to convert to float.
2021-05-28 06:35:43 ERROR (SyncWorker_46) [custom_components.daily.sensor] unable to convert unavailable to float.
2021-05-28 06:35:43 ERROR (SyncWorker_46) [custom_components.daily.sensor] unable to convert to float.

correct. How do propose to fix this? I mean, it's out of the hands of this component - it's a connectivity issue between home assistant and esphome.

Hmmm. MAybe something like: If unavailable -> do nothing
I'm not a programmer. I thought maybe there is an easy fix around here https://github.com/jeroenterheerdt/HADailySensor/blob/d5873f412b5a4006a3b02198533b753d921cb0f8/custom_components/daily/sensor.py#L72

that line does exactly that: is the state is not unavailable or not 'not present' we don't do anything. That's the standard way HA lets a component know the sensor is not there.

I see. So i suppose i just have to live with the log errors :)
Thanks for the explanation. Have a nice weekend.

One last suggestion: Would it be possible to make the error a little more informative?
Like "energymeter is unavailable. unable to convert value to float." Or something similar.

I can absolutely look at that.


I have tried over 300 and all of them are invalid. Does anyone know a fix? :)

there not all going to work because it randomly generates letters an numbers and checks them with discord's api

oh thanks. I just worked out that it would take over 22 million trillion trillion trillion (about<PHONE_NUMBER>0000000000000000000000000000000000) attempts to get one correct one and that would take about 70 years + of leaving it on

No one actually knows what the odds are since we don't know how many valid codes are out there


NIMBLE: ble_store_config.c includes nonexistent config/config.h and base64/base64.h files (IDFGH-1267)

(Using an SDK config with only BLE peripheral role defined.) These files don't exist.

@ecc1 Can you please pull the latest feature/nimble-preview branch of ESP IDF and update the NimBLE submodule. These headers are already removed from ble_store_config.c. See here: https://github.com/espressif/esp-nimble/blob/681a639c1cc24ea6b8bdb36c9a571dae8462614d/nimble/host/store/config/src/ble_store_config.c#L27

Yes, it looks like it was my error with out-of-date git submodules. Closing.


[QUERY] How do you Mock a ResourceGroupResource?

Library name and version
Azure.ResourceManager 1.0.0
Query/Question
I want to Mock a ResourceGroupResponse and set a particular provisioning state and tags to the ResourceGroupData:
Mock<ResourceGroupResource> rg= new Mock<ResourceGroupResource>();
rg.Setup(r => r.Id).Returns(ResourceGroupResource.CreateResourceIdentifier("subId", "name");
rg.Setup(r => r.HasData).Returns(true);
Mock<ResourceGroupData> rgData= new Mock<ResourceGroupData>(AzureLocation.AustraliaCentral);
rgData.Setup(d => d.ResourceGroupProvisioningState).Returns("Deleting");
rgData.Setup(d => d.Tags).Returns(new Dictionary<string, string>() { { "tagName", "tagValue" } });
rg.Setup(r => r.Data).Returns(rgData.Object);

But ResourceGroupProvisioningState cannot be mocked:
Non-overridable members (here: ResourceGroupData.get_ResourceGroupProvisioningState) may not be used in setup / verification expressions.

The code depends on Properties, but Properties can only be set through the Internal constructor.
The same problem happens if I try to Mock the Tags:
Non-overridable members (here: TrackedResourceData.get_Tags) may not be used in setup / verification expressions.

What is the recommended approach to mock the ResourceGroupData?
Environment
No response

Hi @ArthurMa1978, is there a way to Mock these types or another way to simulate this content (ResourceGroupData) in a ResourceGroupResource for testing purposes?

@ealsur thank you for reaching us,  due to the internal / private constructor design all models can be mocked now, but we will provide a model fatory feature to provide mock capability, here is the https://github.com/azure/autorest.csharp/issues/2112 opened

Close as feature task created


[Image] tintColor is not supported with remote images

It should be possible to specify a tintColor for a remote image and would be good for parity between static and remote images. Ex:
<Image
  style={{width: 33, height: 29, tintColor: 'blue'}}
  source={{uri: 'http://facebook.github.io/react-native/img/header_logo.png'}}
/>

+1
if you've only done web programming you don't realize how useful this is.
implementing this would make react native much more usable for anyone coming from an iOS development background.

Should tintColor be a direct prop rather than part of style? For consistency with other components and because it's not a CSS property

@brentvatne It probably should be a separate prop.


markdown codeblocks are italicized

Description
markdown codeblocks are a way to embed code in a markdown file. But the code italicized by default with catppuccin theme. This doesn't occur for other colorschemes. I tried removing the italics for comment still not working

Neovim version
NVIM v0.8.0-1210-gd367ed9b2
Build type: RelWithDebInfo
LuaJIT 2.1.0-beta3

Operating system and version
Windows 11
Catppuccin version / branch / rev
catppuccin 0.2
Steps to reproduce

open a markdown file
start a codeblock with ```
type any text
close the codeblock ```

Expected behavior
code block should be not formatted
Actual behavior
code block is italicized
Minimal config
-- `minimal.lua` used for reproducible configuration
-- Open with `nvim --clean -u minimal.lua`

local is_windows = vim.fn.has("win32") == 1
local function join(...)
  local sep = is_windows and "\\" or "/"
  return table.concat({ ... }, sep)
end

local root_tmp = is_windows and os.getenv("TEMP") or "/tmp"
local site_path = join(root_tmp, "nvim", "site")
local pack_path = join(site_path, "pack")
local install_path = join(pack_path, "packer", "start", "packer.nvim")
local compile_path = join(install_path, "plugin", "packer_compiled.lua")
vim.opt.packpath = site_path

local function load_plugins()
  local packer = require("packer")
  local use = packer.use
  packer.reset()
  packer.init({ compile_path = compile_path, package_root = pack_path })

  use("wbthomason/packer.nvim")
  use({ "catppuccin/nvim", as = "catppuccin" })
  -- ADD PLUGINS THAT ARE _NECESSARY_ FOR REPRODUCING THE ISSUE

  packer.install()
end

_G.load_config = function()
  -- ADD INIT.LUA SETTINGS THAT ARE _NECESSARY_ FOR REPRODUCING THE ISSUE
  require("catppuccin").setup({
    flavour = "mocha"
  })

  vim.api.nvim_command("colorscheme catppuccin")
end

if vim.fn.isdirectory(install_path) == 0 then
  vim.fn.system({ "git", "clone", "--depth=1", "https://github.com/wbthomason/packer.nvim", install_path })
end
load_plugins()
vim.cmd([[autocmd User PackerComplete ++once echo "Ready!" | lua load_config()]])

Should work now

Is the update released :)


Styling does not get applied to a basic button

I got stuck on this issue for a long time, I followed this procedure:

Install react-css-themr
Install react-toolbox-themr
Add to package.json

  "reactToolbox": {
    "include": [
      "BUTTON"
    ],
    "output": "src/styling"
  }

Install the theme with with react-toolbox-themr
Add to my Index.tsx ( I am using Typescript)

  declare function require(moduleName: string): any;
  const theme = require( './styling/theme.css');
  import { ThemeProvider } from 'react-css-themr';
  import Button from 'react-toolbox/lib/button/Button';
  ReactDOM.render(
    <ThemeProvider theme={theme}>
      <Button icon='bookmark' label='Bookmark' accent />
    </ThemeProvider>
   ,
    document.getElementById('root') as HTMLElement
  )

Both
import Button from 'react-toolbox/lib/button/Button';

and
import { Button } from 'react-toolbox/lib/button/Button';

give as output  a single button without any styling:

Am I missing something?

I forgot to import the css itself ...
import './toolbox/theme.css';


Pode cannot listen on both ipv6 and ipv4 unspecified addresses at the same time - it should be able to

Describe the Bug
Since #915 was fixed, pode can now listen on an ipv6 unspecified address, but it cannot listen on both ipv6 and ipv4 unspecified addresses at the same time.
Steps To Reproduce
Start-PodeServer -ScriptBlock {
  Add-PodeEndpoint -Address '::' -Port 8080 -Protocol http
  Add-PodeEndpoint -Address '<IP_ADDRESS>' -Port 8080 -Protocol http

  Add-PodeRoute -Method Get -Path /meat -ScriptBlock {
    Write-Host -Object (Get-Random -InputObject @('Bacon', 'Sausage', 'Steak', 'Italian Sausage', 'Beef'))
    Write-PodeTextResponse -Value success
  }
}

Result:
> Get-NetTCPConnection -State Listen -LocalPort 8080

LocalAddress                        LocalPort RemoteAddress                       RemotePort State       AppliedSetting
------------                        --------- -------------                       ---------- -----       --------------
::                                  8080      ::                                  0          Listen

Or, if you do ipv4 first:
Start-PodeServer -ScriptBlock {
  Add-PodeEndpoint -Address '<IP_ADDRESS>' -Port 8080 -Protocol http
  Add-PodeEndpoint -Address '::' -Port 8080 -Protocol http

  Add-PodeRoute -Method Get -Path /meat -ScriptBlock {
    Write-Host -Object (Get-Random -InputObject @('Bacon', 'Sausage', 'Steak', 'Italian Sausage', 'Beef'))
    Write-PodeTextResponse -Value success
  }
}

Result:
> Get-NetTCPConnection -State Listen -LocalPort 8080

LocalAddress                        LocalPort RemoteAddress                       RemotePort State       AppliedSetting
------------                        --------- -------------                       ---------- -----       --------------
<IP_ADDRESS>                             8080      <IP_ADDRESS>                             0          Listen

Expected Behavior
BOTH listen addresses (IPv4 unspecified, aka <IP_ADDRESS>, and IPv6 unspecified, aka '::') should be listening on the same port at the same time.
Screenshots
Platform

OS: Windows Server build 20348.2322
Browser: N/A
Versions:

Pode: Pode 2.9.0
PowerShell: 5.1.20348.2227

Additional Context
I suspect Pode is trying to dedupe the listen address before attempting to listen again.  In the interactive Pode output, both the ipv6 unspecified and ipv4 unspecified show up as:
Listening on the following 1 endpoint(s) [1 thread(s)]:
        - http://localhost:8080/

So, I would guess that Pode is resolving the address:port to localhost:8080, then seeing that it is already listening on localhost:8080 and then does not attempt to create another listener.
I think this is the issue here:
https://github.com/Badgerati/Pode/blob/df86e0fb5fb37a30d684d79933b95734e4101286/src/Public/Core.ps1#L1006-L1008
But I am honestly having trouble following the logic of what hostname/friendlyname/address should/shouldn't be as that function progresses up to that point.

While implementing a workaround to get all the local addresses and listen on them individually, I am pretty sure this also prevents listening on both IPv4 loopback and IPv6 loopback at the same time.  Probably for the exact same reason.

Hi @araemo,
A related issue was flagged on the Discord recently, and it was found that .NET Sockets have support for a "DualMode" which should allow a single socket to listen on the IPv4 and v6 for a single address - https://devblogs.microsoft.com/dotnet/dual-mode-sockets-never-create-an-ipv4-socket-again/
I'm going to investigate adding a -DualMode switch onto Add-PodeEndpoint to enable this, and was also planning on having this support enabled by default for the localhost address.

Yep, listening on all both the ipv4 and ipv6 'any' addresses at once would address this nicely.


User story 3 continued

Overall looks pretty solid. Nice implementation of the Twitter OAuth! The only proposed change i have is in the in-line comments, but besides that it looks good to me!

One other thing i just noticed: Application.yml was pushed up to github, can we make sure we have /config/application.yml in the .gitignore file so we don't push up any sensitive info?


[add] zoom in text / zoom out text

Coverage remained the same at 55.955% when pulling bc684cdee5119c209592741285a63ce470215fc1 on sunny4381:features/text-zoom into b40d76c692c2a56f9cf6e64e349b722cb8ae8342 on shirasagi:master.


User can add more commits to PR after gaining approval

Gitea version (or commit ref): 1.9.4
Git version:    2.17.1
Operating system: ubuntu 18.04
Database (use [x]):

[ ] PostgreSQL
[ ] MySQL
[ ] MSSQL
[ ] SQLite

Can you reproduce the bug at https://try.gitea.io:

[x] Yes (https://try.gitea.io/ppiwowa2/testrepo/pulls/1)
[ ] No
[ ] Not relevant

Log gist:

Description
We observe that user can add more commits to existing approved PR. After that PR remains approved and can be merged despite new commits not being reviewed.
Steps to reproduce:

fork repo
commit to fork
create PR
get your PR approved
add more commits to fork
merge

This way only first commit was reviewed but all commits can be merged. I suspect that gitea should at least inform that some commits were not reviewed.

I think this should be the standard behaviour, but a new setting could be added. In Github this is called "Dismiss stale pull request approvals when new commits are pushed."

Similar, possible duplicate of #5997

Yes, duplicate of #5997


test(Go SDK): SC-692 Setup Go SDK benchmarks

Benchmark cases:

bare, not instrumented function import "github.com/aws/aws-lambda-go/lambda"
prod mode, instrumented function import "github.com/serverless/console/go/packages/slslambda"

"name"                                 "init:external:overhead"  "init:internal:overhead"  "init:internal:total"  "init:total"  "first:internal:request-overhead"  "first:internal:response-overhead"  "first:external:response-overhead"  "first:internal:total"  "first:total"  "first:billed"  "first:local"  "first:maxMemoryUsed"  "following:internal:request-overhead"  "following:internal:response-overhead"  "following:external:response-overhead"  "following:internal:total"  "following:total"  "following:billed"  "following:local"  "following:maxMemoryUsed"
"nodeSuccess:bare"                     0                         0                         0                      172           0                                  0                                   0                                   0                       4              4               435            57                     0                                      0                                       0                                       0                           2                  2                   114                58
"nodeSuccess:consoleProd"              0                         0                         0                      183           0                                  0                                   0                                   0                       4              5               437            58                     0                                      0                                       0                                       0                           2                  2                   103                58
"nodeSuccess:external"                 21                        0                         0                      537           0                                  0                                   0                                   0                       27             27              924            111                    0                                      0                                       0                                       0                           33                 34                  102                111
"nodeSuccess:consoleOfflineDevMode"    21                        0                         0                      554           0                                  0                                   0                                   0                       27             28              900            111                    0                                      0                                       0                                       0                           28                 28                  108                111
"pythonSuccess:bare"                   0                         0                         0                      130           0                                  0                                   0                                   0                       1              2               372            36                     0                                      0                                       0                                       0                           1                  1                   126                37
"pythonSuccess:consoleProd"            0                         0                         0                      188           0                                  0                                   0                                   0                       2              3               450            40                     0                                      0                                       0                                       0                           1                  2                   106                40
"pythonSuccess:external"               23                        0                         0                      476           0                                  0                                   0                                   0                       24             24              832            91                     0                                      0                                       0                                       0                           28                 28                  100                91
"pythonSuccess:consoleOfflineDevMode"  25                        0                         0                      551           0                                  0                                   0                                   0                       28             28              915            94                     0                                      0                                       0                                       0                           28                 28                  97                 94
"goSuccess:bare"                       0                         0                         0                      31            0                                  0                                   0                                   0                       2              3               443            20                     0                                      0                                       0                                       0                           2                  3                   105                21
"goSuccess:consoleProd"                0                         0                         0                      28            0                                  0                                   0                                   0                       2              3               499            22                     0                                      0                                       0                                       0                           1                  2                   106                23

hmm but I forgot to add SLS_ORG_ID to lambda env vars, let me fix this

hmm but I forgot to add SLS_ORG_ID to lambda env vars, let me fix this

Yes, results look suspicions, instrumented lambda seems to perform better than not instrumented

"name"                                 "init:external:overhead"  "init:internal:overhead"  "init:internal:total"  "init:total"  "first:internal:request-overhead"  "first:internal:response-overhead"  "first:external:response-overhead"  "first:internal:total"  "first:total"  "first:billed"  "first:local"  "first:maxMemoryUsed"  "following:internal:request-overhead"  "following:internal:response-overhead"  "following:external:response-overhead"  "following:internal:total"  "following:total"  "following:billed"  "following:local"  "following:maxMemoryUsed"
"nodeSuccess:bare"                     0                         0                         0                      183           0                                  0                                   0                                   0                       3              4               415            57                     0                                      0                                       0                                       0                           2                  2                   133                58
"nodeSuccess:consoleProd"              0                         2                         87                     223           0                                  5                                   0                                   1                       9              9               426            67                     0                                      1                                       0                                       0                           3                  4                   100                68
"nodeSuccess:external"                 22                        0                         0                      503           0                                  0                                   0                                   0                       27             27              828            111                    0                                      0                                       0                                       0                           28                 28                  103                111
"nodeSuccess:consoleOfflineDevMode"    23                        2                         87                     576           14                                 24                                  0                                   14                      70             71              970            122                    1                                      5                                       0                                       1                           27                 28                  105                122
"pythonSuccess:bare"                   0                         0                         0                      110           0                                  0                                   0                                   0                       2              2               335            36                     0                                      0                                       0                                       0                           1                  2                   125                37
"pythonSuccess:consoleProd"            0                         1                         356                    472           0                                  1                                   0                                   0                       7              8               697            55                     0                                      0                                       0                                       0                           2                  3                   98                 55
"pythonSuccess:external"               22                        0                         0                      491           0                                  0                                   0                                   0                       27             28              837            90                     0                                      0                                       0                                       0                           28                 28                  96                 91
"pythonSuccess:consoleOfflineDevMode"  24                        1                         618                    1130          0                                  3                                   0                                   1                       39             40              1508           116                    1                                      1                                       0                                       1                           28                 29                  109                116
"goSuccess-bare:arm64"                 0                         0                         0                      3             0                                  0                                   0                                   0                       1              5               369            10                     0                                      0                                       0                                       0                           1                  2                   101                10
"goSuccess-bare:amd64"                 0                         0                         0                      20            0                                  0                                   0                                   0                       2              3               385            20                     0                                      0                                       0                                       0                           1                  2                   99                 21
"goSuccess-consoleProd:arm64"          0                         0                         2                      7             0                                  0                                   0                                   0                       3              10              449            13                     0                                      0                                       0                                       0                           2                  3                   112                13
"goSuccess-consoleProd:amd64"          0                         0                         5                      27            0                                  0                                   0                                   1                       5              5               516            23                     0                                      0                                       0                                       0                           2                  3                   95                 23

@medikoo it's ready now, I've added also a comparison between arm64 with provided.al2 runtime and amd64 with go1.x runtime


Bump actions in README

Closes #1287.

In the README, this makes it easy for things to go out of date.

Yeah, I was thinking about this too. I suggest we can use major version in README to let users obtain the latest minor updates.

Resolved through #1352. Dependabot will keep the example up-to-date, so we wont need to update it here anymore.

I suggest we can use major version in README

Since our README example is in our control, we are going to advocate for dependency pinning still.
https://docs.github.com/actions/security-guides/security-hardening-for-github-actions#using-third-party-actions
I did try to switch our starter workflow to using the major versions since that's annoying to upgrade, but their CONTRIBUTING.md requires the use of hash pinning.


[SVE2] Fix kMaxThreadNameLength

Fixes https://github.com/project-chip/connectedhomeip/issues/22336
kMaxThreadNameLength currently set to 32. Spec mandates it to 8

Accepted for 1.0 as a SPEC fix.


[WIP] Enhance vim-airline to Vim9 Script

This is very much Work in progress. Do not merge yet, it might blow up.
I started to explore the new Vim9 script features and see how much this can improve performance on a recent Vim8.2 (I tested with 8.2.2000).
Overall transition was not too hard. There are a couple of problems however:

dictionary functions seem not to be supported yet (or I couldn't make it to work)
assignment of nested dictionaries is ugly and not very nice (had to resort to calling extend())
optional arguments in functions are not allowed. So there are a couple of backward-incompatible changes. Not sure, if this will change

Since Vim9 script is much more strict about types, I decided to make the themes palette a consistent list of string arguments. Currently vim-airline can use string or number types in the list (usually the cterm arguments where numbers, while the gui arguments where strings). So I decided to change those as well to a consistent form. Unfortunately, this means all airline themes need to be changed as well :(
I started converting those files, which looked expansive on the profile (see below). So for now, I added vim9 script implementions to
[x] extensions/tabline.vim
[x] highlighter.vim
[x] extensions/tabline/formatters/default.vim
[x] msdos.vim (this was just the starter to see how well it goes)
[x] airline/themes.vim
The other changes are mostly related to make it work with Vim9 Script. When converting to Vim9 script, I also converted and used some more modern Vim script expressions like lambdas, literal-dicts, (removed some tests for vimscript functions).
I am a bit unsure, whether more files should be converted ...
It's a bit sad, that now a lot of functions need to be maintained in 2 different versions, one for older vims and neovim, and one for modern 8.2 vim. Oh well :/
Overall I like the performance improvements this brings. Here are some numbers on my not so relevant workstation (interesting thing is, the expansive functions from the unpatched vim do not appear at all in the new profile log).
unpatched:
FUNCTIONS SORTED ON SELF TIME
count  total (s)   self (s)  function
    2   6.723342   6.672712  recover#ConfirmSwapDiff()
   73   0.772535   0.770230  airline#extensions#tabline#formatters#default#format()
   12              0.362610  airline#extensions#tabline#redraw()
   11   0.335285   0.329922  <SNR>13_LoadFTPlugin()
 3834   0.565058   0.268838  airline#highlighter#get_highlight()
 7668              0.257577  <SNR>105_get_syn()
   12   0.549743   0.184470  <SNR>110_update_tabline()
   11   0.688532   0.138488  <SNR>16_SynSet()
   11   0.122773   0.121731  <SNR>14_LoadIndent()
 1616   0.439104   0.119735  airline#highlighter#exec()
   16   0.648080   0.078033  airline#highlighter#highlight()
   90   0.430681   0.067069  219()
    1   0.050630   0.050477  <SNR>33_SetSwapfile()
  871   0.552174   0.043375  <SNR>105_exec_separator()
 1616              0.041292  <SNR>105_CheckDefined()
 3834              0.038643  <SNR>105_get_array()
  252              0.031471  <SNR>105_GetHiCmd()
  415              0.020821  <SNR>119_get_accented_line()
   16   0.022824   0.020262  <SNR>33_CheckSwapFileExists()
    6   0.019392   0.019239  airline#extensions#tabline#tabs#tabnr_formatter()

(ignore the first entry)
patched:
FUNCTIONS SORTED ON SELF TIME
count  total (s)   self (s)  function
   67              1.452387  <SNR>124_evaluate_tabline()
  148   0.370885   0.362516  airline#check_mode()
   11   0.360953   0.355273  <SNR>13_LoadFTPlugin()
  215   0.560237   0.182879  219()
  799              0.157534  <SNR>120_get_transitioned_seperator()
   11   0.705152   0.147519  <SNR>16_SynSet()
   11   0.121890   0.120762  <SNR>14_LoadIndent()
  772              0.064452  airline#builder#should_change_group()
 1158              0.063638  <SNR>120_get_accented_line()
 1065   0.056047   0.044595  <SNR>121_get_section()
   14   0.041436   0.041044  airline#extensions#tabline#tabs#tabnr_formatter()
 1442   0.058216   0.029463  <SNR>120_section_is_empty()
  687   0.065757   0.024255  <SNR>121_add_section()
 1455              0.021734  airline#builder#get_prev_group()
   13   0.028121   0.018003  <SNR>33_CheckSwapFileExists()
  213   0.083002   0.017245  <SNR>121_build_sections()
  729   0.186583   0.017021  <SNR>120_get_seperator()
  189   0.173067   0.014839  airline#util#exec_funcrefs()
  189   0.118700   0.014520  airline#extensions#default#apply()
  189   0.025965   0.014227  airline#extensions#apply()

I tried to do the profiling by doing exactly the same thing. For reference, this is how I created those:
vim --cmd ':let g:airline_experimental=1` --cmd 'let g:airline#extensions#tabline#enabled = 1'
:cd `<airline-install-dir>/autoload/airline`
:profile start filename.log
:profile func *
:profile file *
:e highlighter.vim
:tabedit highlighter.vim
:set modified
:argadd *.vim
:sball
:jump through all windows and press redraw a couple of times
:qa!

This is still work in progress. If you want to try this out, set the airline_experimental flag to 1. But it might blow up (or not even work with your Vim version). Fixing errors is not so easy, because the debugging interface of Vim does not work yet correctly and often error messages are not shown, (or they scroll by a lot since Vim is calling statusline and tabline functions at every redraw). So if you experience errors, I might not be able to reproduce and fix those yet.
Work to be done:
[] Clean up Commits
[] Convert more files (mostly ones with expansive functions)
[] other?
Comments welcome. Obviously, this won't work on Neovim.

Will you no longer support legacy Vim script? Also, do you support both legacy Vim script and Vim9 script?

of course we will. But I think we should make use of Vim9 script as it gives us so much better performance

of course we will.

Okay, I got it. I asked because I wanted to confirm the future policy.
But, In order to merge Vim9 script into master, I think it is necessary to confirm stable operation with both legacy Vim script and Vim 9script.

But I think we should make use of Vim9 script as it gives us so much better performance

I think so too, thanks for writing this patch!

FYI, I hold off merging this currently, as Vim9 is still very experimental and there are still a couple of rough edges that have not been adressed (like complex dict assignments). I'll keep on updating this branch for later vims however. So testing might be valuatble

@chrisbra
This branch has been stripped from the current master branch. Can I incorporate the current master branch by rebasing?

@chrisbra
This branch is experiencing a difference from the current master branch
(e.g: this branch's ci is travis, but master branch's ci is github actions)
Can I incorporate the current master branch by rebasing?

Yes sure, if this works.

@chrisbra
Since many files were conflicting, I used cherry-pick to update the CI.
I also made a commit to specify vim9script in the yml.

@chrisbra
Since many files were conflicting, I used cherry-pick to update the CI.
I also made a commit to specify vim9script in the yml.


[regression] ilab no longer supports multiple work profiles and config files

Describe the bug
The ticket is formulated like an enhancement, but I'm flagging this as a bug, because it is a regression from 0.17 and earlier versions. Multiple work profiles was a super useful feature for testing and presenting InstructLab to customers and users.
As a user, I want to use multiple config.yaml and work profiles, so I can several independent work profiles for InstructLab. This enables me to have several independent configurations, checkouts of taxonomy, training data, and models on my machine at the same time.
Until PR #1471 landed, this was very easy. The config file and all other files (models, taxonomy, training data) were references in relation to the current working directory. To create or use a new, independent work profile, I merely had to cd into another directory. With the new storage system, the feature is gone.

ilab config init has no option to set a different config file. It is always creating its config file in an hard-coded path. ilab --config=myconfig.yaml config init does not change the path to default conf

On Linux, it is possible to hack around the problem by setting three env vars. But that's awkward and does not work on macOS or Windows. platformdirs does not read os.environ for any platform except for Linux. Even on Linux it is problematic, because the XDG env vars affect other program. That's why users don't want to set the env vars in their current shell. There are other problems, e.g. taxonomy checkout uses git command and the git command reads its configuration from XDG directories.
XDG_CACHE_HOME=$HOME/instructlab/profile1/cache \
XDG_CONFIG_HOME=$HOME/instructlab/profile1/config \
XDG_DATA_HOME=$HOME/instructlab/profile1/data \
XDG_STATE_HOME=$HOME/instructlab/profile1/state \
ilab config init

To Reproduce
Steps to reproduce the behavior:
See above
Expected behavior
InstructLab should reintroduce a way to have separate configuration and work profiles. Switching profiles should be easy, e.g. with a command or env var.
Device Info (please complete the following information):

0.18.0a3.dev10

@cdoern
will your work in #1399 also include creating separate workspace dirs for different profiles? if so that might address this issue
also related: https://github.com/instructlab/instructlab/issues/729

@cdoern - check this


Project not friendly with VSCode 'Angular Language Service' plugin.

A lot of error message like those:
file: 'file:///xxxxxxxx/src/app/routes/dashboard/v1/v1.component.html'
severity: 'Error'
message: 'Can't bind to 'sparkline' since it isn't a known property of 'div'.'
at: '29,42'
source: 'Angular';

maybe caused by this issue #99

Yes, I added  NgZorroAntdModule.forRoot() into routes.module.ts
imports, some errors disappear.
that had been imported at SharedModule.

import { NgModule } from '@angular/core';
import { RouterModule } from '@angular/router';
import { SharedModule } from<EMAIL_ADDRESS>import { PagesModule } from './pages/pages.module';
import { routes } from './routes';
import { DashboardV1Component } from './dashboard/v1/v1.component';
import { NgZorroAntdModule } from 'ng-zorro-antd';
@NgModule({
imports: [
NgZorroAntdModule.forRoot(),  // should not import again, may caused by Angular Language Service
SharedModule,
RouterModule.forRoot(routes, { useHash: true }),
PagesModule
],
declarations: [
DashboardV1Component
],
exports: [
RouterModule
]
})
export class RoutesModule { }

the Angular Language Service extenstion is optional in development, i can't provider fix this information. sorry.


hack: build unified image in fmt_build

fmt_build now builds a unified operator image where it can be used to run backup_operator and restore_operator.
e2e test can use this image to run backup_operator and restore_operator without requiring individual image.

cc/ @hongchaodeng @hasbro17

Don't separate this out from https://github.com/coreos/etcd-operator/pull/1497.
We should only push the image only after we have the tests for the binaries.

@hongchaodeng this also ensure etcd-operator from the unify image can be run for e2e test. I think separating it out here shouldn't be a problem.

this also ensure etcd-operator from the unify image can be run for e2e test.

It doesn't make sense to test the new unified image without the test.
Let's just close this PR and include this one line in the test PR.

Closing this and merging the effort into #1497


Add CLANG detection

The variable COMPILER_IS_CLANG is not set anywhere in CMakeLists.txt file. Added.

thank you!


Snap mode doesn't stay unchecked

In VS Studio Code, using the inspector, I can uncheck the snap to grid mode, but as soon as I move the camera, it gets checked again. This means it's almost impossible to work without this mode checked, as soon as I adjust the camera it gets reverted back
https://github.com/decentraland/sdk/assets/3507907/33207bb0-cded-4050-a470-793cc32da02f

Confirmed that this still happens


Scroll column is also displayed correctly in Safari

As a user, I want the navigation to be displayed correctly in the Safari browser.
AC:

Scrolling is fixed and shown displayed correctly.

The navigation currently uses scrollIntoView. However, scrollIntoViewOptions are not supported by Safari: https://developer.mozilla.org/de/docs/Web/API/Element/scrollIntoView
To solve the problem, scrollTo should be used instead.
Tasks:

[ ] Use scrollTo to fix the scrolling.
[ ] Insert a comment, as scrollIntoViewOptions may be supported by Safari in the future and can therefore be used again.

So I've tried both .scrollTo() & .scrollBy(). Sadly, both are jumping to the given coordinates like .scrollIntoView() 😢 So I guess there's nothing we can use for Safari to have a smooth scrolling effect


ethcrawler synchronize should gracefully recover from blockchain reorganization

Currently, if the node has to roll back accepted blocks because it got out of sync with the majority of its neighbors, the synchronization process crashes and requires manual reconciliation.
We will put two measures in place to solve this problem:
"--confirmations" argument on "ethcrawler synchronize"
Default value should be 0 indicating that the synchronization should be with the latest block.
--confirmations n for n > 0 indicates that synchronization should always be n blocks behind the latest block on the node.
This is the quick and dirty fix.
Check parent hash before storing block
If parent hash doesn't match block hash for last block stored in database, step backwards on node and in database till hashes match up. Then delete all subsequent blocks from database and start a resynchronization from that point onwards.
This is the principled fix.

Won't fix for now. Leaving issue open. Waiting for 6 confirmations has been good enough for us so far.


Develop

fix(openid):change Openid to OpenID
refact(payment): safeRequest change param and options
fix(payment): transfer to balance


Doesn't work with Sierra and Parallels 12

Nothing happens :(

It works for me with these versions:

I did have to update VirtualBox and remove a broken vm in the list for it. But after that everything seems to be working fine. Thanks for the great project!


Test using raw UUID value in query

I don't believe this change is needed. If you have a rationale for this change, please include it in your PR.