az ad app update --id  --add appRoles gives serialization error

az ad app update --id $app.AppId --add appRoles @"

    {
        "allowedMemberTypes": [
            "User"
        ],
        "description": " Administrators can configure their organisation-wide settings.",
        "displayName": "Administrator",
        "isEnabled": true,
        "origin": "Application",
        "value": "Admin"
    }

"@

az --version
azure-cli                         2.0.67
acr                                2.2.9
acs                                2.4.4
advisor                            2.0.1
ams                                0.4.7
appservice                        0.2.21
backup                             1.2.5
batch                              4.0.3
batchai                           0.4.10
billing                            0.2.2
botservice                         0.2.2
cdn                                0.2.4
cloud                              2.1.1
cognitiveservices                  0.2.6
command-modules-nspkg               2.0.2
configure                         2.0.24
consumption                        0.4.4
container                         0.3.18
core                              2.0.67
cosmosdb                          0.2.11
deploymentmanager                  0.1.1
dla                                0.2.6
dls                               0.1.10
dms                                0.1.4
eventgrid                          0.2.4
eventhubs                          0.3.7
extension                          0.2.5
feedback                           2.2.1
find                               0.3.4
hdinsight                          0.3.5
interactive                        0.4.5
iot                               0.3.11
iotcentral                         0.1.7
keyvault                          2.2.16
kusto                              0.2.3
lab                                0.1.8
maps                               0.3.5
monitor                           0.2.15
natgateway                         0.1.1
network                            2.5.2
nspkg                              3.0.3
policyinsights                     0.1.4
privatedns                         1.0.2
profile                            2.1.5
rdbms                             0.3.12
redis                              0.4.4
relay                              0.1.5
reservations                       0.4.3
resource                          2.1.16
role                               2.6.4
search                             0.1.2
security                           0.1.2
servicebus                         0.3.6
servicefabric                     0.1.20
signalr                            1.0.1
sql                                2.2.5
sqlvm                              0.2.0
storage                            2.4.3
telemetry                          1.0.2
vm                                2.2.23
Python location 'C:\Program Files (x86)\Microsoft SDKs\Azure\CLI2\python.exe'
Extensions directory 'C:\Users\Hiten.azure\cliextensions'
Python (Windows) 3.6.6 (v3.6.6:4cf1f54eb7, Jun 27 2018, 02:47:15) [MSC v.1900 32 bit (Intel)]
Error:
The command failed with an unexpected error. Here is the traceback:
Unable to build a model: Unable to deserialize to object: type, AttributeError: 'str' object has no attribute 'get', DeserializationError: Unable to deserialize to object: type, AttributeError: 'str' object has no attribute 'get'
Traceback (most recent call last):
File "C:\Users\VSSADM~1\AppData\Local\Temp\pip-install-wl9gly17\msrest\msrest\serialization.py", line 1288, in _deserialize
File "C:\Users\VSSADM~1\AppData\Local\Temp\pip-install-wl9gly17\msrest\msrest\serialization.py", line 1078, in rest_key_case_insensitive_extractor
File "C:\Users\VSSADM~1\AppData\Local\Temp\pip-install-wl9gly17\msrest\msrest\serialization.py", line 1101, in attribute_key_case_insensitive_extractor
AttributeError: 'str' object has no attribute 'get'
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "C:\Users\VSSADM~1\AppData\Local\Temp\pip-install-wl9gly17\msrest\msrest\serialization.py", line 571, in body
File "C:\Users\VSSADM~1\AppData\Local\Temp\pip-install-wl9gly17\msrest\msrest\serialization.py", line 1258, in _deserialize
File "C:\Users\VSSADM~1\AppData\Local\Temp\pip-install-wl9gly17\msrest\msrest\serialization.py", line 1267, in _deserialize
File "C:\Users\VSSADM~1\AppData\Local\Temp\pip-install-wl9gly17\msrest\msrest\serialization.py", line 1447, in deserialize_data
File "C:\Users\VSSADM~1\AppData\Local\Temp\pip-install-wl9gly17\msrest\msrest\serialization.py", line 1478, in deserialize_iter
File "C:\Users\VSSADM~1\AppData\Local\Temp\pip-install-wl9gly17\msrest\msrest\serialization.py", line 1478, in
File "C:\Users\VSSADM~1\AppData\Local\Temp\pip-install-wl9gly17\msrest\msrest\serialization.py", line 1460, in deserialize_data
File "C:\Users\VSSADM~1\AppData\Local\Temp\pip-install-wl9gly17\msrest\msrest\serialization.py", line 1298, in _deserialize
File "C:\Users\VSSADM~1\AppData\Local\Temp\pip-install-wl9gly17\msrest\msrest\exceptions.py", line 51, in raise_with_traceback
File "C:\Users\VSSADM~1\AppData\Local\Temp\pip-install-wl9gly17\msrest\msrest\serialization.py", line 1288, in _deserialize
File "C:\Users\VSSADM~1\AppData\Local\Temp\pip-install-wl9gly17\msrest\msrest\serialization.py", line 1078, in rest_key_case_insensitive_extractor
File "C:\Users\VSSADM~1\AppData\Local\Temp\pip-install-wl9gly17\msrest\msrest\serialization.py", line 1101, in attribute_key_case_insensitive_extractor
msrest.exceptions.DeserializationError: Unable to deserialize to object: type, AttributeError: 'str' object has no attribute 'get'
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "C:\Users\VSSADM~1\AppData\Local\Temp\pip-install-wl9gly17\knack\knack\cli.py", line 206, in invoke
File "C:\Users\VSSADM~1\AppData\Local\Temp\pip-install-wl9gly17\azure-cli-core\azure\cli\core\commands_init_.py", line 566, in execute
File "C:\Users\VSSADM~1\AppData\Local\Temp\pip-install-wl9gly17\azure-cli-core\azure\cli\core\commands_init_.py", line 624, in run_jobs_serially
File "C:\Users\VSSADM~1\AppData\Local\Temp\pip-install-wl9gly17\azure-cli-core\azure\cli\core\commands_init.py", line 615, in run_job
File "C:\Users\VSSADM~1\AppData\Local\Temp\pip-install-wl9gly17\azure-cli-role\azure\cli\command_modules\role\commands.py", line 69, in graph_err_handler
File "C:\Users\VSSADM~1\AppData\Local\Temp\pip-install-wl9gly17\azure-cli-core\azure\cli\core\commands_init.py", line 594, in run_job
File "C:\Users\VSSADM~1\AppData\Local\Temp\pip-install-wl9gly17\azure-cli-core\azure\cli\core\commands_init.py", line 303, in call
File "C:\Users\VSSADM~1\AppData\Local\Temp\pip-install-wl9gly17\azure-cli-core\azure\cli\core\commands\arm.py", line 554, in handler
File "C:\Users\VSSADM~1\AppData\Local\Temp\pip-install-wl9gly17\azure-cli-core\azure\cli\core\commands_init_.py", line 409, in cached_put
File "C:\Users\VSSADM~1\AppData\Local\Temp\pip-install-wl9gly17\azure-cli-core\azure\cli\core\commands_init_.py", line 404, in _put_operation
File "C:\Users\VSSADM~1\AppData\Local\Temp\pip-install-wl9gly17\azure-cli-role\azure\cli\command_modules\role\custom.py", line 960, in patch_application
File "C:\Users\VSSADM~1\AppData\Local\Temp\pip-install-wl9gly17\azure-graphrbac\azure\graphrbac\operations\applications_operations.py", line 321, in patch
File "C:\Users\VSSADM~1\AppData\Local\Temp\pip-install-wl9gly17\msrest\msrest\serialization.py", line 574, in body
File "C:\Users\VSSADM~1\AppData\Local\Temp\pip-install-wl9gly17\msrest\msrest\exceptions.py", line 51, in raise_with_traceback
File "C:\Users\VSSADM~1\AppData\Local\Temp\pip-install-wl9gly17\msrest\msrest\serialization.py", line 571, in body
File "C:\Users\VSSADM~1\AppData\Local\Temp\pip-install-wl9gly17\msrest\msrest\serialization.py", line 1258, in _deserialize
File "C:\Users\VSSADM~1\AppData\Local\Temp\pip-install-wl9gly17\msrest\msrest\serialization.py", line 1267, in _deserialize
File "C:\Users\VSSADM~1\AppData\Local\Temp\pip-install-wl9gly17\msrest\msrest\serialization.py", line 1447, in deserialize_data
File "C:\Users\VSSADM~1\AppData\Local\Temp\pip-install-wl9gly17\msrest\msrest\serialization.py", line 1478, in deserialize_iter
File "C:\Users\VSSADM~1\AppData\Local\Temp\pip-install-wl9gly17\msrest\msrest\serialization.py", line 1478, in
File "C:\Users\VSSADM~1\AppData\Local\Temp\pip-install-wl9gly17\msrest\msrest\serialization.py", line 1460, in deserialize_data
File "C:\Users\VSSADM~1\AppData\Local\Temp\pip-install-wl9gly17\msrest\msrest\serialization.py", line 1298, in _deserialize
File "C:\Users\VSSADM~1\AppData\Local\Temp\pip-install-wl9gly17\msrest\msrest\exceptions.py", line 51, in raise_with_traceback
File "C:\Users\VSSADM~1\AppData\Local\Temp\pip-install-wl9gly17\msrest\msrest\serialization.py", line 1288, in _deserialize
File "C:\Users\VSSADM~1\AppData\Local\Temp\pip-install-wl9gly17\msrest\msrest\serialization.py", line 1078, in rest_key_case_insensitive_extractor
File "C:\Users\VSSADM~1\AppData\Local\Temp\pip-install-wl9gly17\msrest\msrest\serialization.py", line 1101, in attribute_key_case_insensitive_extractor
msrest.exceptions.SerializationError: Unable to build a model: Unable to deserialize to object: type, AttributeError: 'str' object has no attribute 'get', DeserializationError: Unable to deserialize to object: type, AttributeError: 'str' object has no attribute 'get'

Updating from arbitrary json fragments is unsupported. Please check out the tip for recommended ways to use the update command.

Meanwhile, I am closing this issue even though there is an uncaught exception, but that is part of the nature of being generic. Feel free to post follow-up questions though.

Thanks Yugang. can we open a feature request for this? Seems like a useful scenario.

Yes, we can consider this for the end to end scenario that you can download the manifest from portal, tweak a bit and then patch back to graph.
Reactivating. We will plan for it once we get enough votes.

for context, I had asked if it can be a feature request. Thanks, Yugang.

The execution of a generic update is at src/azure-cli-core/azure/cli/core/commands/arm.py, so a generic deserialization is supported here. The error is actually caused by malformed command (possibly line-breaks or quotes).
I tested --set and --add with AAD sample. Both worked fine.
az ad app update --id "xxx" --set "appRoles=[{\"allowedMemberTypes\":[\"User\"],\"displayName\":\"Writer\",\"id\":\"d1c2ade8-98f8-45fd-aa4a-6d06b947c66f\",\"isEnabled\":true,\"description\":\"Writers Have the ability to create tasks.\",\"value\":\"Writer\"}]"
az ad app update --id "xxx" --add appRoles "{\"allowedMemberTypes\":[\"User\"],\"displayName\":\"Writer\",\"id\":\"d1c2ade8-98f8-45fd-aa4a-6d06b947c66f\",\"isEnabled\":true,\"description\":\"Writers Have the ability to create tasks.\",\"value\":\"Writer\"}"

The execution of a generic update is at
https://github.com/Azure/azure-cli/blob/ac427269ab4fc55fbe04d8e1445a1b78d191076f/src/azure-cli-core/azure/cli/core/commands/arm.py#L522
So a generic deserialization is supported here. The error is actually caused by malformed command, possibly line-breaks or quotes.
I tested --set and --add with the example from AAD doc. Both worked fine.


Error when installing

Hi, the package doesn't properly install for me. Any ideas?
Traceback (most recent call last):
    File "<string>", line 1, in <module>
    File "/private/var/folders/81/2r7bsh810jd7yrt90z9x1xgh0000gn/T/pip-build-1s_rFU/mythril/setup.py", line 163, in <module>
      scripts=['mythril']
    File "/usr/local/Cellar/python/2.7.14/Frameworks/Python.framework/Versions/2.7/lib/python2.7/distutils/core.py", line 151, in setup
      dist.run_commands()
    File "/usr/local/Cellar/python/2.7.14/Frameworks/Python.framework/Versions/2.7/lib/python2.7/distutils/dist.py", line 953, in run_commands
      self.run_command(cmd)
    File "/usr/local/Cellar/python/2.7.14/Frameworks/Python.framework/Versions/2.7/lib/python2.7/distutils/dist.py", line 972, in run_command
      cmd_obj.run()
    File "/usr/local/lib/python2.7/site-packages/wheel/bdist_wheel.py", line 257, in run
      self.distinfo_dir)
    File "/usr/local/lib/python2.7/site-packages/wheel/bdist_wheel.py", line 427, in egg2dist
      distribution=self.distribution)
    File "/usr/local/lib/python2.7/site-packages/wheel/metadata.py", line 130, in pkginfo_to_dict
      payload = payload.decode('utf-8')
    File "/usr/local/Cellar/python/2.7.14/Frameworks/Python.framework/Versions/2.7/lib/python2.7/encodings/utf_8.py", line 16, in decode
      return codecs.utf_8_decode(input, errors, True)
  UnicodeDecodeError: 'utf8' codec can't decode byte 0x89 in position 1757: invalid start byte

Ho @forgetso, Mythril only works with Python 3.5. Try pyenv.

Thanks, I got it up and running with a conda env 👍


bts field now respects passed-in startTime

after comments, :shipit:

closing because it's out of date now.


App state

Added skeleton state for app as well as event handlers for the nested components to use.

Nice!


Mouse cursor shows text cursor instead of hand symbol

My screenshot app does not show the mouse cursor.
Occurs when hovering 'Legal notice' and 'Privacy policy'

Hi @calixtus , can I try to solve this problem? It seems to be something I usually resolve! Put me as Assignees.

Nice, we don't use assignments here in this repo, but please go ahead and open a PR.


pull

Checklist

[x] Tests have been  updated

Change information

Checklist

[x]  Tests have been  updated

Change information


4.6.2020 csgo update fix

@danielkrupinski fixes the cheat for the new update, please merge

Thx bro! 👍

What do i do to fix it. like what do i do with the fix file

nothing its already merged with master

this virus or something? i need plz

how to fix this

how to fix this

download the new version of osiris

hello, when i launch the osiris i cant open inventory and do anything in csgo. someone help?


Documentation doesn't match current release version

Just realised this while trying to get filter by assembly working.

You've been busy, my notifications keep filling up with coverlet related stuff :)

New version released: https://www.nuget.org/packages/coverlet.msbuild/2.0.0

Hi @tonerdo. I raised this because it will keep happening without a dev/next-release branch that only gets merged into master when released (or some other indication to the user). It's not really an issue for someone familiar with coverlet but for new users it could cause frustration. Although I think this will largely be resolved when you have a nightly build pipeline set up.


typo: fix bam api url in documentation

Status
READY
Description
The default api_endpoint is "https://bam-api.res.ibm.com", but even the small ".com" typo can be confusing to some why it's not working, and can easily get ignored while trying to find the issue
Impacted Areas in Library
None, it's a documentation change
Which issue(s) does this pull-request fix?
Directly created this PR, I will create an Issue for this.
Any special notes for your reviewer?
Checklist

[ ] Automated tests exist
[ ] Updated Package Requirements (if required, and with maintainers' approval)
[ ] Local unit tests performed
[ ] Documentation exists link
[ ] Local pre-commit hooks performed
[ ] Desired commit message set as PR title and description set above
[ ] Link to relevant GitHub issue provided

coverage: 93.955% (-1.2%) from 95.112%
when pulling ae3abb0a08bfe98b48d5669f9a912bcae022559c on adi-g15-ibm:typo-fix-bam-api
into 09c5ecc25adc1e5e0888f5abe3c5ceb167821743 on IBM:main.


Fatal Python error: PyThreadState_Get: no current thread

Dear Kenichi,
I tried to run Single channel WPE dereverberator using the following script:
python test_subband_dereverberator.py -i data/CMU/R1/M1005/KINECT/RAW/segmented/U1001_1M_16k_b16_c1.wav -o out/U1001_1M_16k_b16_c1.wav
and the result is:
Fatal Python error: PyThreadState_Get: no current thread
Abort trap: 6
I googled this issue and it seems caused from multiple version of python installed. I uninstalled python 3.6 but it didn't solve the problem. I'm wondering if I can get some suggestion from you.
Thanks much!

I've never had this error. Could you tell me a bit more detail:

OS
Python package
Python version (python -V)
Also, could you make sure numpy works normally?

Thanks for your reply.
Never mind. I tried it on a newly build Ubuntu system and it works just fine. My macOS has like 3 versions of python, which is probably the reason causing the problem.


Define git branch for package from environment variable?

It it possible to define an environment variable to be used to determine the branch that should be checked out for a git repo used as a module? I have been trying to edit my Pipfile to include this but I'm not having any success. Here's an example error message:
pip9.exceptions.InstallationError: Command "git checkout -q ${PIPENV_ENVIRONMENT}" failed with error code 1 in /tmp/pip-1kIzTE-export

The reason that I'm doing this is that I have two deployments (staging and master) and would like the packages that are pulled in to use the same branch as the repo that is pulling them in (so the master branch would pull in master packages and the staging branch would pull in staging packages).

merging into #2317

second @typhoon2099
specifying targets (branch, ref or even version) dynamically simplifies version and dependency management a lot.
It was possible to use environment variables in packages section up until v2018.05.18 but was dropped thereafter as it seems. Even though I understand why, it would have been very nice :)


Sweetalert not working on nodejs 10.13

I try to follow this link https://stackoverflow.com/questions/41006087/add-sweet-alert-popup-to-button-in-react-component/41006372#41006372 but I got an error
Warning: React.createElement: type is invalid -- expected a string (for built-in components) or a class/function (for composite components) but got: object.
Check your code at Company.js:15.
I dont know why what happened, please help me how to use this?

Im going to need more information to debug this.    I dont know what Company.js is.  This project contains no such file.

Thanks for your reply. I try to follow link above and it's not working so I try other way, maybe I'm new user so I dont know how it works. This is my code changed and its working fine.
<button onClick={() => this.showPopupConfirm('Save changes for client', 'Are you sure?', () => this.handleDeleteClick, 'custom') }>Delete</button> showPopupConfirm(title, message, callBack, style) {     this.setState({       alert: (           <SweetAlert               info               showCancel               confirmBtnText = "Yes"               cancelBtnText = "No"               confirmBtnBsStyle="danger"               cancelBtnBsStyle = "primary"               title = {title}               onConfirm = {callBack()}               onCancel = {this.hideAlert}           >             {message}           </SweetAlert>       )     });   }
Thanks for your awesome component.

@namnguyen2091 I have a similar implementation but getting TypeError: Cannot read property 'setState' of undefined error.
This is the issue link
can you please help me? thanks a ton.


Error in Performance/Sample cop 0.30.1

Just tried upgrading to 0.30.1, but ran into this error with one of my files:
An error occurred while Performance/Sample cop was inspecting <filename>
undefined method `selector' for #<Parser::Source::Map::Variable:0x007fb924c54740>
/Users/alexb/.rvm/gems/ruby-2.2.1/gems/rubocop-0.30.1/lib/rubocop/cop/performance/sample.rb:37:in `on_send'
(eval):5:in `block (2 levels) in on_send'
/Users/alexb/.rvm/gems/ruby-2.2.1/gems/rubocop-0.30.1/lib/rubocop/cop/commissioner.rb:92:in `with_cop_error_handling'
(eval):4:in `block in on_send'
(eval):2:in `each'
(eval):2:in `on_send'
/Users/alexb/.rvm/gems/ruby-2.2.1/gems/ast-2.0.0/lib/ast/processor.rb:239:in `process'
/Users/alexb/.rvm/gems/ruby-2.2.1/gems/parser-<IP_ADDRESS>/lib/parser/ast/processor.rb:42:in `on_vasgn'
/Users/alexb/.rvm/gems/ruby-2.2.1/gems/parser-<IP_ADDRESS>/lib/parser/ast/processor.rb:47:in `process_var_asgn_node'

Can you add here some code that triggers the error? Feel free to obfuscate it if it's something sensitive.

Whoops, sorry, that was lazy.  I'll do some binary code deletion to find the triggering code.  I'll get back to you in a bit.

I am hoping that this has already been fixed, in master, by the other issues reported for this cop.

Thanks, fixed in master.


Send File/Image type attachment from user to bot on Teams group chat through Composer

We are trying to upload attachment from user to bot developed using bot composer. While trying to read the content url of the attachment uploaded through teams group chat, we do not get any content url.  The content url appears blank.
Kindly suggest.
Below is the snippet :
{
"contentType": "text/html",
"contentUrl": null,
"content": "
"<img" "itemscope="png"",
"src="https://us-api.asm.skype.com/v1/objects/0-eus-d7-6aaf03b8f4c12140b9d0d5ee35522c33/views/imgo\"" "alt="image"",
"itemtype="http://schema.skype.com/AMSImage\"" "width="444.44444444444446"",
"height="250"" "id="x_0-eus-d7-6aaf03b8f4c12140b9d0d5ee35522c33"",
"itemid="0-eus-d7-6aaf03b8f4c12140b9d0d5ee35522c33"" "style="vertical-align:bottom">",
", " "name": null, "thumbnailUrl": null } ] }"
}

@SwetalinaGitHub, unfortunately I am unable to repro the issue you are encountering. Are you able to provide details on how you setup the attachment file input in your dialog (properties you filled out, etc.) or a copy of your bot that I can test against?

@stevkan Below is the screenshot of the dialog in composer. Also sharing the screenshot of object files while testing the bot through personal scope and group chat scope respectively.
Through the same bot composer solution, image upload is working properly and we get the object of the image. While it does not work in the group scope.

@SwetalinaGitHub, thank you for your patience. I am still unable to repro the issue.
Can you tell me what version of Composer you are running?
Is this a C# or JS build for your bot?
And, the image you are attempting to send, what is the size of the image file?
Are any other errors reported in Composer either under Problems or Output?

Even I am facing the same issue. Sometimes content URL is blank in the teams and sometimes it works fine.
I am using bot composer 2.0.0. (Windows OS) , C#, I tried pdf, word document but was not able to find the pattern when it's failing and when it's passing.
The only thing for sure is when a word document has "+" in the name it's failing all the time but without it also it fails sometimes.

@stevkan Were you able to reproduce the issue?

@stevkan Could you please provide an update to this issue?

@shrutinehra, apologies for the delay and thank you for your patience. I am now able to repro the issue. When sending a Word doc where the file name ends with a '+', the file's content information is not being added to the Attachments array. However, when the file name is just alphanumerics, the file's content information is added. I've only tested a handful of times; at this point, the outcome has been consistent in each case.
I'm going to dig deeper into this to see if I can isolate the cause. I will update you when I know more.

Testing a JS SDK bot via Teams produced the same results. However, testing in Emulator, Test in Web Chat, and Web Chat (hosted on a web app) all functioned correctly when using either a Composer bot or a JS SDK bot.

Did additional testing by running Fiddler and monitoring requests/responses. Sent attachments in Teams and could see them in the responses for both messages sent to and not to a bot. However, that only displays the attachments as they were sent between the client and the Teams server. Not surprisingly, as the connection between the Teams server and the Teams connector in ABS is not visible, I am unable to determine if the issue lies on the Teams side or the ABS side.

@clearab, could you take a look at this or connect this to the right Teams person to handle?

I believe there might be two issues happening here - an encoding issue with file names including some special characters, and also that sending/receiving files in Teams is only support in the personal scope. Do those two issues account for the failures y'all are seeing, or is there another case to be aware of?
More info on sending/receiving files in Teams can be found here: https://docs.microsoft.com/en-us/microsoftteams/platform/bots/how-to/bots-filesv4

Closing this one due to inactivity, @SwetalinaGitHub feel free to re-open this issue if you still experience problems.


Add Gitea support

Builds on top of #6 so please review that first.
This adds support for Gitea, a popular open-source forge written in Go. The implementation is similar to GitLab, with some instances hardcoded and a heuristic for gitea.<domain>

I have tested it on https://codeberg.org/Freeyourgadget/Gadgetbridge (link to visit) and https://git.rampin.org/remi/calendar-booking

screenshots

I added an option for custom Gitea instances and tested it on a random one I found via a search:

Thanks @remram44, this is a great contribution!

This is now packaged and online as version 0.6.3 on both FF Add-Ons and CWS.
@remram44


Function3: percent_mass

calculate percentage mass for chemical or atom of interest

[ ] function body
[ ] tests


[Tests] Fix node setting overriding file configuration

As stated by @bokobza, argument injection should be preferred over file configuration but currently if we specifiy to use for example, RegTest in the file we will over write the boolean straight after if its NOT in the arguments.
This causes the integration tests to run on the bitcoin network.

Nice one!


feat: add ability to overload all cyberware slots

What it does
Adds ability to overload all cyberware slots (except Ocular System) with configuration managed by Mod Settings.
Motivation
There's a couple mods in nexusmods that patch System-Ex to overload other cyberware slots. Hands-Ex hardcodes hands slots to 2 and All Cyberware-EX hardcodes all slots to the maximum (?) (not sure if there's a maximum).
First, these mods cover extremely specific cases and if users want a different set of options, these mods must either add settings (on top of manually patching System-Ex), or create new mods with different hardcoded values.
Secondly, this manual patching on other mods is unmaintainable. When System-Ex is updated, these patches would most likely be broken, having to merge System-Ex's updates to their code.
So, to integrate everything, I think the best solution is to modify System-Ex with the ability to configure all slots.
Notes

All slot count settings default to vanilla values, except System Replacement, where System-Ex already set it to 2.
I'm not sure how to implement an IScriptable that can be used as a singleton that is automatically initialized by the game, so I used a ScriptableSystem with OnAttach(), following the same pattern as Codeware.Registry.RegistrySystem
I don't know if any cyberware needs special-case handling like System Replacement. If so, then this PR needs to be updated with it
Ocular system is hardcoded to 1, since it doesn't make sense to use multiple
Adding a dependency (Mod Settings) may be a deterrent to get this merged, so I understand if it's rejected
I did not change the mod version. Since it adds a dependency, which is a breaking change, it's up to you if you want to bump the major version. (It seems the mod will still work without Mod Settings installed and will simply use the default values)

Hi. Thanks for the PR. You made a good points. As for details:

ScriptableSystem is the way to go.
Yeah, the good thing about Mod Settings is that it can be an optional requirement. The mod will work with default settings without it.
Active cyberware may require special handling. I can think of a legs slot (double jump, charged jump, hovering). I'd check and handle this as the mod's idea is to provide fully functional extensions.

Yeah, I need to check cyberwares for special cases. I personally don't overload other cyberwares other than System Replacement and Hands (System-Ex + Hands-Ex). I'll also check All Cyberware-Ex to see if they handle special cases.

I'm closing this since 1.0.5 adds Hands cyberware option and OS+Hands is everything I use.


New lint rule: No implicit boolean JSX attributes

Don't allow:
<foo bar />

Autofix it to:
<foo bar={true} />

The consensus from anyone I've spoken to on the React team or those involved with the creation of JSX is that this was a mistake. It's always clearer to have the explicit boolean value and it's confusing with the introduction of shorthand object properties.

I'll grab this one.


feat/disable-dashboard

Please review before merging.

:tada: This PR is included in version 1.45.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


python310Packages.stanza: 1.5.0 -> 1.5.1

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for python310Packages.stanza is: Official Stanford NLP Python Library for Many Human Languages
meta.homepage for python310Packages.stanza is: https://github.com/stanfordnlp/stanza/
meta.changelog for python310Packages.stanza is: https://github.com/stanfordnlp/stanza/releases/tag/v1.5.1
Updates performed

Ran passthru.UpdateScript

To inspect upstream changes
Impact

Checks done (click to expand)

built on NixOS
The tests defined in passthru.tests, if any, passed
found 1.5.1 with grep in /nix/store/y6gaf1qzl6lg2z0550chr1cz2m5rza9a-python3.10-stanza-1.5.1
found 1.5.1 in filename of file in /nix/store/y6gaf1qzl6lg2z0550chr1cz2m5rza9a-python3.10-stanza-1.5.1

Rebuild report (if merged into master) (click to expand)

11 total rebuild path(s)

11 package rebuild(s)

First fifty rebuilds by attrpath
libretranslate
python310Packages.argos-translate-files
python310Packages.argostranslate
python310Packages.libretranslate
python310Packages.stanza
python310Packages.translatehtml
python311Packages.argos-translate-files
python311Packages.argostranslate
python311Packages.libretranslate
python311Packages.stanza
python311Packages.translatehtml

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/y6gaf1qzl6lg2z0550chr1cz2m5rza9a-python3.10-stanza-1.5.1 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A python310Packages.stanza https://github.com/r-ryantm/nixpkgs/archive/9defdc50675d15b69c49745d7004d8492e777c28.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/y6gaf1qzl6lg2z0550chr1cz2m5rza9a-python3.10-stanza-1.5.1
ls -la /nix/store/y6gaf1qzl6lg2z0550chr1cz2m5rza9a-python3.10-stanza-1.5.1/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

2 packages built:

python310Packages.stanza
python311Packages.stanza

Maintainer pings
cc @riotbib for testing.

Result of nixpkgs-review pr 254568 run on x86_64-linux 1

18 packages marked as broken and skipped:

libretranslate
libretranslate.dist
python310Packages.argos-translate-files
python310Packages.argos-translate-files.dist
python310Packages.argostranslate
python310Packages.argostranslate.dist
python310Packages.libretranslate
python310Packages.libretranslate.dist
python310Packages.translatehtml
python310Packages.translatehtml.dist
python311Packages.argos-translate-files
python311Packages.argos-translate-files.dist
python311Packages.argostranslate
python311Packages.argostranslate.dist
python311Packages.libretranslate
python311Packages.libretranslate.dist
python311Packages.translatehtml
python311Packages.translatehtml.dist

4 packages built:

python310Packages.stanza
python310Packages.stanza.dist
python311Packages.stanza
python311Packages.stanza.dist


Optimize Sorted Pivot Flux Queries

Flux queries involving (sorted) pivots (see here) are slower than their equivalent InfluxQL queries. This issue is to optimize the Flux queries to be on par with the InfluxQL queries.

There's already a pushdown for sorted-pivots in OSS, but when I was poking at it with the profiler I could never get the engine to report using that rewrite rule. #22436 suggests that pivot() isn't properly preserving the output ordering of rows. I wonder if there's a bug in the existing optimization that's preventing it from triggering properly.


Climate range slider

Description:
Changes to allow a range slider for thermostats that support that.
@justweb1 is working on the frontend.
I don't understand the honeywell platform, so I could use some help with converting that.
WIP
Related issue (if applicable): fixes #
#3075

target_temp_low and target_temp_high do not convert temp based on unit_of_measurement

Looks like the honeywell classes need the **kwargs parameter added to set_temperature

All climate platforms should have **kwargs in set_temperature

Thay all do :)

You sure?
___________________ TestHoneywellRound.test_set_temperature ____________________

self = <tests.components.climate.test_honeywell.TestHoneywellRound testMethod=test_set_temperature>

    def test_set_temperature(self):

        """Test setting the temperature."""

>       self.round1.set_temperature(25)

E       TypeError: set_temperature() takes 1 positional argument but 2 were given

tests/components/climate/test_honeywell.py:277: TypeError

I don't understand how the honeywell is set up, yes I know the tests for honeywell fail, but I don't understand how it is set up.

Is this GTG?

:clap: :dancers: :+1:


Add unit and integration tests for kati-ui charm

Unit tests cover basic pebble and leader implementation. Integration test checks if charm builds and deploys and that the katib-ui server is coming up.
Relates to #5

Closing in favour of #143


Geo-restore link

The link points to https://docs.microsoft.com/en-us/azure/key-vault/general/disaster-recovery-guidance instead of the correct page.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 0eedc850-d0b4-c414-b8a3-7657635ddd92
Version Independent ID: c458e5cf-15f4-9811-2c6b-90a3bca61973
Content: SaaS apps: Geo-redundant backups for disaster recovery - Azure SQL Database
Content Source: articles/azure-sql/database/saas-dbpertenant-dr-geo-restore.md
Service: sql-database
Sub-service: scenario
GitHub Login: @MashaMSFT
Microsoft Alias: mathoma

@VitalyMCT Thank you for your feedback! We will review and update as appropriate.

@VitalyMCT Could you please share the link

Maybe just remove the link altogether as the page itself seems to be focused on geo-restore? Or maybe point to https://docs.microsoft.com/en-us/azure/azure-sql/database/recovery-using-backups. Just not AKV, it's completely unrelated.

#assign: LitKnd

Hi @VitalyMCT ,
Thank you for letting us know about this issue. I looked into this before I saw your second note with the suggested replacement link and came to the exact same conclusion about which link was likely intended :)
I found the problem at line 62 in the file, which was:
 * [Geo-restore](../../key-vault/general/disaster-recovery-guidance.md), to recover the catalog and tenant databases from automatically maintained geo-redundant backups.
I will create a pull request shortly to update this to:
* [Geo-restore](recovery-using-backups#geo-restore), to recover the catalog and tenant databases from automatically maintained geo-redundant backups.
It will likely take a couple/few business days to move this through our process and publish.
Thanks again,
Kendra
Content Developer, SQL Docs Team

Thanks @LitKnd

Thank you for your patience on this, @VitalyMCT .
I've just been able to sign off on our internal Pull Request. This fix should go out and be published during the business day today.
Thanks again for helping us improve the docs!
Kendra
#please-close


Removal of default Instance Profile breaks old AWSNodeTemplates

Description
Observed Behavior:
0.32.x introduced new CRDs and, in the process removed the default instance profile option from the chart options.
This means upgrading to 0.32 silently breaks all previously existing AWSNodeTemplates that relied on that feature: no new nodes for those nodes can be provisioned anymore, and the controller logs informs about default-instance-profile.
Expected Behavior:

Maintain support for default instance profile and push it to 0.33 to ease migration between 0.31 and 0.32.
Document this edge case

Reproduction Steps (Please include YAML):

Deploy Karpenter latest 0.31 with defaultInstanceProfile set
Create a AWSNodeTemplate without instanceProfile
Verify that new nodes of that type can be created
Upgrade to 0.32.3, loose the ability to define defaultInstanceProfile in chart
Controller starts, finds existing v1alpha[15] CRDs
Creation of nodes supported by the previous AWSNodeTemplates does not work anymore.

Versions:

Chart Version: 0.32.3
Kubernetes Version (kubectl version): 1.27.7

Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
If you are interested in working on this issue or have submitted a pull request, please leave a comment

You can still enable the defaultInstanceProfile in the karpenter-global-settings and you should still enable it in there if you are running AWSNodeTemplates that do not contain an instance profile in v0.32.3. The setting is under settings.aws.defaultInstanceProfile still, we just don't document the value as part of the chart in an effort to migrate users over to the newer values.

I was able to successfully deploy nodes using a Provisioner and AWSNodeTemplate that didn't have an instanceProfile value set when I had the defaultInstanceProfile value set on v0.32.3.

Hi @jonathan-innis, thank you for your reply, I'll give this a try next week (got pulled into another topic).
Should this trick be documented to prevent other users stepping into the same trap?

I was able to successfully (and smoothly) upgrade to Karpenter 0.32.3 today, thanks to your comment 🎉
I see that the docs still reference the defaultInstanceProfile option in the helm upgrade command.
This issue can be closed. Thank you for your help 🙇🏻


Remove dependencies that were dropped upstream

Checklist

[ ] Used a personal fork of the feedstock to propose changes
[ ] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[ ] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[ ] Ensured the license file is being packaged.

conda could make archspec>=0.2.1 a hard dependency potentially now, I'd guess)

xref: https://github.com/conda/conda/pull/13213.
I agree we should make archspec a hard dependency for future (>=23.10) versions of conda. However, I'm going back and forth on whether the >=0.2.1 is actually necessary, or whether conda could just depend archspec, without any lower-bound version constraint.
From what I can tell, requiring >=0.2.1 would lead to a cleaner base environment, in the sense that click wouldn't be a transitive dependency, and that's arguably desirable for many/most? user deployments. On the other hand, click itself isn't that big and is required for conda-index (and by extension, conda-build), so its inclusion in the base environment isn't exactly a major problem. (Similar transitive-dependency arguments apply for six.)


edited test 002

Added a note to the 002 test file so I remember that's the one that should pass

Status Flag 'Pull Request Inspected' - Auto Inspected - Inspection Has Been Deemed Not Necessary for this Pull Request.

Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects:
** NOTE: CUSTOM REPORT NOT LOADED **
JOB: BSSIO_autotester_test; Build 7 on Jenkins server at https://jenkins-son.sandia.gov
Using Parameters:

BSSIO_SOURCE_BRANCH = patch-test-2
BSSIO_SOURCE_REPO = https://github.com/william76/betterscientificsoftware.github.io
BSSIO_SOURCE_SHA = 41610dd4eff45551aaecaf52bed9537692ee88da
BSSIO_TARGET_BRANCH = develop
BSSIO_TARGET_REPO = https://github.com/william76/betterscientificsoftware.github.io
BSSIO_TARGET_SHA = 6bb5c60f4a2eeedd18130ce2be4d49716c8d5e56
JENKINS_JOB_TYPE = Experimental
TEST_REPO_ALIAS = BSSIO

Using Repos:
Repo: BSSIO (william76/betterscientificsoftware.github.io) Branch: patch-test-2 SHA: [41610dd4eff45551aaecaf52bed9537692ee88da] - TEST_REPO
Pull Request Author: william76 (William)

Status Flag 'Pull Request AutoTester' - Jenkins Testing: all Jobs PASSED
NOTE: CUSTOM REPORT NOT LOADED - TESTING HAS PASSED

Status Flag 'Pull Request AutoTester' - Pull Request MUST BE MERGED MANUALLY BY Project Team - Master Automerge is disabled (in .cfg file)

Status Flag 'Pull Request Inspected' - Auto Inspected - Inspection Has Been Deemed Not Necessary for this Pull Request.

Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects:
** NOTE: CUSTOM REPORT NOT LOADED **
JOB: BSSIO_autotester_test; Build 8 on Jenkins server at https://jenkins-son.sandia.gov
Using Parameters:

BSSIO_SOURCE_BRANCH = patch-test-2
BSSIO_SOURCE_REPO = https://github.com/william76/betterscientificsoftware.github.io
BSSIO_SOURCE_SHA = dcf843e9eb4c27d2efb5bb6e090523dd3e641d60
BSSIO_TARGET_BRANCH = develop
BSSIO_TARGET_REPO = https://github.com/william76/betterscientificsoftware.github.io
BSSIO_TARGET_SHA = 6bb5c60f4a2eeedd18130ce2be4d49716c8d5e56
JENKINS_JOB_TYPE = Experimental
TEST_REPO_ALIAS = BSSIO

Using Repos:
Repo: BSSIO (william76/betterscientificsoftware.github.io) Branch: patch-test-2 SHA: [dcf843e9eb4c27d2efb5bb6e090523dd3e641d60] - TEST_REPO
Pull Request Author: william76 (William)

Status Flag 'Pull Request AutoTester' - Jenkins Testing: all Jobs PASSED
NOTE: CUSTOM REPORT NOT LOADED - TESTING HAS PASSED

Status Flag 'Pull Request AutoTester' - Pull Request MUST BE MERGED MANUALLY BY Project Team - Master Automerge is disabled (in .cfg file)

Status Flag 'Pull Request AutoTester' - Pull Request MUST BE MERGED MANUALLY BY Project Team - Master Automerge is disabled (in .cfg file)

Status Flag 'Pull Request AutoTester' - Pull Request MUST BE MERGED MANUALLY BY Project Team - Master Automerge is disabled (in .cfg file)


[Feature Request] Use Specific Codec

Can something like this be implemented? https://github.com/alextrv/enhanced-h264ify

No, It is Immpossible.
The reason is that the video on Youtube servers is already stored in H264 format (max 720p). The resolution above it already uses VP9/AV1. The reason is that AV1 encoded video uses less space on the server. Which reduces overhead (storage and delivery) to Google servers.
The only way to watch videos in a large resolution. This is to use an external player that will play the downloaded video file with the youtube-dl library.
see https://github.com/rainart/youtube-to-smplayer#upd-better-alternative
If your system is a little outdated, then it might be worth making sure that you have hardware video decoding enabled.

I can watch VP9/AV1 video, the reason I'm using this extension because it's faster and less CPU usage for my weak CPU. The downside I can only watch video up to 1080p 60fps and that's okay because it can't handle anything higher.  A lot of people using this just to gain more performance, I just thought it can be useful to be implemented to your extension that already give user more control. Thank you for replying.

The only thing h264ify does is block youtube from sending a response to a request for a supported video format. That is, the extension simply makes the browser pretend that the device does not support anything other than H264.
Nothing more can be done. Of course, I can just paste the code into the plugin, but why? The problem is that Nova starts up slower than the extension. And it just won't work right.

You can try similar script https://github.com/code-for-charity/YouTube-Extension
they added what you want. Their architecture is monolithic and faster than the modular one Nova uses.

The only thing h264ify does is block youtube from sending a response to a request for a supported video format. That is, the extension simply makes the browser pretend that the device does not support anything other than H264.

Yeah I know, thanks for helping me

Sorry, I don't want to open this but. Why are you kept telling me how the h264ify works? I know what it does, maybe I'm not clear enough. H264 codec use less CPU usage.

As I understand it the question - "was whether it is possible to implement a similar mechanism that will use hardware acceleration instead of software"?
I tried to convey that there is only one way known to me. And it has already been implemented. I do not know your knowledge and therefore tried to explain the theory, a possible solution and how it works.
It was probably right to simply say "No, I will not implement." what they are trying to explain. People do not want to delve into, they are lazy. They need ready solutions. I just started to forget about it.
If you want a magical solution to a problem then try these scripts:
https://greasyfork.org/en/scripts?q=cpu+youtube
But without explaining how they work. After all, the main thing is to believe and not to know the truth.


Failed: Installing Cityhash with Ruby2.1 win386

Hi,
I am trying to install cityhash using ruby 2.1 under win-i386 by typing the follwing in the command line:
gem install cityhash
and I am getting the follwing error message:
C:/Ruby21/bin/ruby.exe extconf.rb
creating Makefile
make "DESTDIR=" clean
make "DESTDIR="
generating cityhash-i386-mingw32.def
compiling city.cc
city.cc:64:22: fatal error: byteswap.h: No such file or directory
compilation terminated.
make: *** [city.o] Error 1
make failed, exit code 2
I would appreciate any help.
Best,

I am also having the same error
Here is my output:
Gem::Ext::BuildError: ERROR: Failed to build gem native extension.

    C:/Ruby22-x64/bin/ruby.exe -r ./siteconf20150322-3768-79bsgu.rb extconf.rb
creating Makefile

make "DESTDIR=" clean

make "DESTDIR="
generating cityhash-x64-mingw32.def
compiling city.cc
city.cc:64:22: fatal error: byteswap.h: No such file or directory
compilation terminated.
make: *** [city.o] Error 1

make failed, exit code 2

Gem files will remain installed in C:/Ruby22-x64/lib/ruby/gems/2.2.0/gems/cityhash-0.8.1 for inspection.
Results logged to C:/Ruby22-x64/lib/ruby/gems/2.2.0/extensions/x64-mingw32/2.2.0/cityhash-0.8.1/gem_make.out
An error occurred while installing cityhash (0.8.1), and Bundler cannot
continue.
Make sure that `gem install cityhash -v '0.8.1'` succeeds before bundling.

@TrangPham @HatemMS2012 hey! Sorry about that. I don't really use Windows for ruby development so can't really help. But pull requests are welcome! So if you wanna try to fix it just give it a try. I'm totally here to help you.


Bootstrap 5 Support

@acrobat, @vsn4ik With Bootstrap 5's stable release coming, is it possible to learn whether this high quality date picker component will be compatible? Many thanks!
https://github.com/twbs/release#upcoming-release-schedule

B5 no longer depends on jQuery so datepicker (which is a jQ plugin) would ideally need a rewrite to drop it as a dependency also.

+1 to BS5 support !

@bre7 datepicker without JQuery is a whole new project. So we should first focus on supporting bootstrap 5 with JQuery as extra dependency.

So we should first focus on supporting bootstrap 5 with JQuery as extra dependency.

💯

It does work, same as with bs4

It does work, same as with bs4

Thanks! I suggest this issue be renamed to something like "remove jquery dependency"


⚠ Bofrost.at has degraded performance

In ccff620, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 1094 ms

Resolved: Bofrost.at performance has improved in 90acfa5.


translate cMD1 paper analyses to cMD3

This will replace issue https://github.com/waldronlab/curatedMetagenomicData/issues/70
See https://github.com/waldronlab/curatedMetagenomicData/tree/legacy/vignettes/extras for code to move over.
This is intended as a learning exercise and will be interesting to see how these analyses have changed since the original publication, but there's no need to reproduce something that is too difficult, or to maintain old code if there's an easier way to do it.

This is not high priority but I still think it would be a good learning exercise. @cmirzayi it might actually be even more immediately relevant to you if you feel you have the bandwidth? It involves some unsupervised analysis and machine learning using cMD, and there is already code that just needs to be updated to the cMD3 API.


Add operator-sdk crds generation target

Idea:
We need to validate that our CRDs are inline with the version of the operator-sdk we have. For this we should do that by reusing the sdk version in the vendor folder, and triggering the generation via a make target file.
Acceptance_Criteria:

Generate new make target
Ensure binary is build via the vendor dependencies for the sdk
Ensure the CRDs generation take place per pr, basically validate if they match the generate ones on the fly from the vendor operator-sdk dependency

Closing this in favor of https://github.com/shipwright-io/build/issues/579


fix to put pixels in row-based order

The only change was on line 20 where I swapped x and y when indexing into the image data.
everything else was formatting.
Also commented out network code temporarily so this could be tested.

This looks good, have you tested it?

I tested it, it works.


[bugfix] set default max_dets to same values as pycocotools

Motivation
The COCO dataset recall evaluation in mmdetection differs from the original pycocotools. This is because the mmdetection's default maxDets ([100, 500, 1000] ) are not equal to the others ([1, 10, 100]).
This change fixes issue https://github.com/open-mmlab/mmdetection/issues/6884.
Modification

Rename proposal_nums to max_dets

proposal_nums seems to be used in the first stage of two-stage object detection (many proposals will appear).
The name max_dets is compatible to coco evaluation.

Change the default values to cocoEval.params.maxDets from [100, 500, 1000] to [1, 10, 100]

This change incorrectly sets all case to [100, 500, 1000]
We can fix it to set cocoEval.params.maxDets only if metric == "proposal". I didn't because you'll change this variable in other situations (such as detection of a large number of objects).

BC-breaking (Optional)

Default recall evaluation of COCO dataset (measured after https://github.com/open-mmlab/mmdetection/pull/3497/commits/e20c5c2c83b9deac1ea24915955cea6b56632458 )

If you want to get the previous value, you can set maxDets=[100, 500, 1000] or simply see recall@100 (because recall@[100, 500, 1000] will get the same value in most experiments).

Use cases (Optional)
COCO evaluation
Checklist

Pre-commit or other linting tools are used to fix the potential lint issues.
The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
If the modification has potential influence on downstream projects, this PR should be tested with downstream projects, like MMDet or MMCls.
The documentation has been modified accordingly, like docstring or example tutorials.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Hi @ritosonn ,
Thanks for your kind PR. The current change will introduce BC-breaking because the proposal_nums is no longer used. To avoid that and provide a more smooth experience to the users, could you also keep the argument of proposal_nums? When evaluating AP, we can use max_det to be align with pycocotools. When evaluating proposal AR, we can still use proposal_nums.

Hi @ritosonn ,
I have a question, I wonder if this maxDets is just in a different format than the print of pycocotools? That is, will the change of maxDets affect the calculation of its specific indicator values?And when i try to align with pycocotools and change coco.py file from your work, but when i use tools/test.py to calculate the indicator, it still prints in the previous format，as shown in the image. If i want use tools/test.py to align with pycocotools format,whether you need to modify other files?


Update service-fabric-application-model.md

Hi @alexwun, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!

It looks like you're working at Microsoft (alexwun). If you're full-time, we DON'T require a contribution license agreement.

If you are a vendor, or work for Microsoft Open Technologies, DO please sign the electronic contribution license agreement. It will take 2 minutes and there's no faxing! https://cla.azure.com.

TTYL, AZPRBOT;


Raise InvalidKeyError when metric names will be rejected by Librato

Librato will never accept metrics with certain key values. By raising an
exception, we make that clear up front, instead of waiting for the user
to write an error handler that prints out the error message from Librato
rejecting the entire payload and noting that one key is invalid.
I would prefer to stop these values from even making it in to the
registry, but there’s no way to hook Metriks::Registry#add from here.

What about sanitizing them so they can be submitted instead of failing?

We can sanitize (and I am doing that myself, in bundler-api), but I thought that silently transforming the keys might not be expected or acceptable to end-users. I'm doing this:
key.gsub!(/[^.:_\-0-9a-zA-Z]/, '.')
Metriks.meter(key[0...255]).mark

Without either this patch or key sanitization, if any metric name contains a character Librato rejects, that instance of LibratoMetricsReporter will never be able to successfully submit a single data point to Librato ever again. It's just infinite 400 Not Acceptables forever.

This feels like a good place for a proc to be passed in to allow for different decisions here. Maybe we could provide a couple default implementations that made sense.

Sure. I think defaulting to raise, but providing an option that takes either a string to use as the replacement character or a proc to do the key sanitization probably makes sense?

@eric done, I added String and Proc support via the :sanitize option, while preserving the existing sanitizer for those who don't opt in.


2.x index compaction, and fix concurrency issues

eureka-pull-requests #423 SUCCESS
This pull request looks good

NetflixOSS » eureka » eureka-pull-requests #5 SUCCESS
This pull request looks good

NetflixOSS » eureka » eureka-pull-requests #6 SUCCESS
This pull request looks good

eureka-pull-requests #424 SUCCESS
This pull request looks good


Swift 3.0 - Xcode beta 2: Cannot call value of non-function type 'NSDecimalNumber'

Using the swift3 branch and Xcode beta 2 I get two buildtime errors (see screenshot).

Try NSDecimalNumber.notA and NSDecimalNumber.zero

@slammer8 Thanks, but I know the alternative. It needs to be fixed in the swiftyjson pod. I now also see a couple of pull requests with these fixes, so I'll just wait for it.

Fixed in the final swift3 release, thanks for reporting!


fixed german typos

fixed german typos at 11 monster descriptions where "- " were falsely used

Since I can't really understand german I'll accept it as is, thank you very much!
This does remind me that I do need to set up automatic data extraction and translation extraction for monsters before Iceborne is released on PC.

I am willing to contribute further to the project. I guess I will join you on Discord the next day to disscus what I can possibly do and what makes sense to do.

@Randomdude1001 I wanted to ask. I started working on updating the automatic descriptions from the game files, and it undid your changes and readded the -'s for the german language. I set my game (on PC) to German to check and it turns out they're in the game as well:

Is there some german specific grammar rule I should know about regarding those hyphens? Is that how german people break up lines? Is it safe to join lines that end with - globally?

Figured I might as well try it out. Can you take a look at https://github.com/gatheringhallstudios/MHWorldData/pull/32 and see if it looks right? If it doesn't, can you let me know what its supposed to be and send a screenshot of the game?

I´m happy to help with that and going to take a look at it maybe this evening (CEST timezone).


Setuptools bug fix

Fixing template files being excluded from pypi distribution

Codecov Report

Merging #168 (ed4b3ad) into master (ae17dea) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #168   +/-   ##
=======================================
  Coverage   89.12%   89.12%
=======================================
  Files          49       49
  Lines        1655     1655
=======================================
  Hits         1475     1475
  Misses        180      180

Flag
Coverage Δ

unittests
89.12% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Figure out blog posts for marketing Civic Camp

https://docs.google.com/document/d/1H4V5DmP4OEIGkGE_GiK9DblUudXb4TkT_F_3TuaBPQ0/edit?usp=sharing

Can you give me a deadline for my post?
On Mon, Sep 3, 2018 at 8:07 AM Janel<EMAIL_ADDRESS>wrote:

https://docs.google.com/document/d/1H4V5DmP4OEIGkGE_GiK9DblUudXb4TkT_F_3TuaBPQ0/edit?usp=sharing
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/ncopenpass/NCOpenPass/issues/1132#issuecomment-418096124,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AB3Ie0b2-zgJEvJ6ibfTR0znL1QDkZF-ks5uXRuDgaJpZM4V7TMw
.


Share App Link Visibility

mainFeatures: share-app-link - Toggle link to Google Play Store
mainFeatures: share-download-app-link - Include a URL to application download accessible through mainFeatures: share-download-app-link-url
mainFeatures: share-apk-file - Toggle share APK method
mainFeatures: share-apple-app-link - Toggle link to Apple App Store.

Should the Share App button be turned invisible if none of the sharing options are selected in scripture app builder?

If there are no share options enabled, then the share menu is not visible.

How will the button handle App Store redirection and Google Play redirection if both are toggled?

If there are multiple, show a popup to select which one.  You can see how Android does this.  Actually, Android doesn't show a link for Apple Store.  For PWA, I would like you to show options for all. Look for images on the web (try to use svg and see icons in src/lib/icons).
Apple App Store Guidelines: https://developer.apple.com/app-store/marketing/guidelines/
Google Play Guidelines https://play.google.com/intl/en_us/badges/
These are formatted URLs.
Google Play:  https://play.google.com/store/apps/details?id=package (found in package root element)
Apple Store: https://apps.apple.com/us/app/idshare-apple-id (found in features)

Is that handled in the sidebar component code?

What I would suggest is that there is a service for copying data to the clipboard.  The sidebar can assign the url to a store with "displayname" and "text" properties.  A service would be listening for updates to the store and would put the data into the clipboard and create a toast (from DaisyUI) notifying the user that "displayname set in clipboard"
Originally posted by @chrisvire in https://github.com/sillsdev/appbuilder-pwa/issues/54#issuecomment-1271035251


focus and tab order

@Yomguithereal Thanks for this great library!
I was looking for ways to put a component in focus but couldn't find it in the documentation. Is there anywhere I can look this up?
Thanks!
Ge

Hum. I thinks that currently you might have to set a ref on the component and used blessed's API to focus the component as I think I did not implement any of the react callbacks used to deal with focus and component mounting etc.

Here's a quick sample with hooks to focus if someone is looking for it
const App = ({filter}) => {
	const listRef = useRef();
	useEffect(() => {
		if (listRef.current) {
			listRef.current.focus();
		}
	});
	return (
		<box
			top="center"
			left="center"
			width="50%"
			height="50%"
			border={{type: 'line'}}
			style={{border: {fg: 'blue'}}}
		>
			<list
				ref={listRef}
				keys
				mouse
				items={['oui', 'maybe', 'no ?']}
				style={{
					item: {fg: 'white'},
					selected: {fg: 'cyan'}
				}}
			/>
		</box>
	);
};

Thanks @gouegd.


Add tracking to government navigation

What
Add tracking data attributes to elements in the government_navigation menu header (which mirrors what is in Whitehall).
Why
As part of gathering some baseline data ahead of updating the header design.
Visual changes?
None
Trello

Needs an entry to the changelog, but other than that this is good to go 👍


Npm start

Nothing's loading on port 8080.
Npm install was successful. And npm start yielded no errors.
How do I change the port through the code?
If you have other suggestions that'll be great.

Got it.


SQL command returned non-zero exit status 1 with uppercase column names

Hi Jerome,
I'm having an issue while using Pynonymizer with uppercase table names. It seems the SQL command decodes the table name as lowercase, returning an error.
subprocess.CalledProcessError: Command '['psql', '--host', 'localhost', '--port', '5432', '--username', 'postgres', '--dbname', 'strategy3_e30f5bf9e4b54379896fc2d037930bec', '--command', 'UPDATE APP AS "updatetarget" SET "APP_NAME" = ( SELECT company FROM _pynonymizer_seed_fake_data ORDER BY RANDOM(), MD5("updatetarget"::text) LIMIT 1),"CLIENT_ID" = ( SELECT md5 FROM _pynonymizer_seed_fake_data ORDER BY RANDOM(), MD5("updatetarget"::text) LIMIT 1),"CLIENT_SECRET" = ( SELECT md5 FROM _pynonymizer_seed_fake_data ORDER BY RANDOM(), MD5("updatetarget"::text) LIMIT 1);']' returned non-zero exit status 1.
strategy3_e30f5bf9e4b54379896fc2d037930bec=# UPDATE APP AS "updatetarget" SET "APP_NAME" = ( SELECT company FROM _pynonymizer_seed_fake_data ORDER BY RANDOM(), MD5("updatetarget"::text) LIMIT 1),"CLIENT_ID" = ( SELECT md5 FROM _pynonymizer_seed_fake_data ORDER BY RANDOM(), MD5("updatetarget"::text) LIMIT 1),"CLIENT_SECRET" = ( SELECT md5 FROM _pynonymizer_seed_fake_data ORDER BY RANDOM(), MD5("updatetarget"::text) LIMIT 1);
ERROR:  relation "app" does not exist
LINE 1: UPDATE APP AS "updatetarget" SET "APP_NAME" = ( SELECT compa...

Would you take a look?

I'm using version 1.20.0

Hi,  I think we need a little more information to diagnose the issue - what is the table actually called? and can you give me an example what you think that query should be ?
I'm a little confused by the output since in the query, it looks like the table name is already in uppercase.

Hi Jerome,
I did some research and found this answer in StackOverflow:

Identifiers (including column names) that are not double-quoted are folded to lower case in PostgreSQL. Column names that were created with double-quotes and thereby retained upper-case letters (and/or other syntax violations) have to be double-quoted for the rest of their life

So I tried the query as it is and the relation was folded to lowercase.
strategy3_75721d1a2a054d33bebd27eb5e2ee9ae=# UPDATE APP AS "updatetarget" SET "APP_NAME" = ( SELECT company FROM _pynonymizer_seed_fake_data ORDER BY RANDOM(), MD5("updatetarget"::text) LIMIT 1),"CLIENT_ID" = ( SELECT md5 FROM _pynonymizer_seed_fake_data ORDER BY RANDOM(), MD5("updatetarget"::text) LIMIT 1),"CLIENT_SECRET" = ( SELECT md5 FROM _pynonymizer_seed_fake_data ORDER BY RANDOM(), MD5("updatetarget"::text) LIMIT 1);']
ERROR:  relation "app" does not exist
LINE 1: UPDATE APP AS "updatetarget" SET "APLICACAO" = ( SELEC...
strategy3_75721d1a2a054d33bebd27eb5e2ee9ae'#

After double-quoting table's name, the query ran successfully.
strategy3_75721d1a2a054d33bebd27eb5e2ee9ae'# UPDATE "APP" AS "updatetarget" SET "APP_NAME" = ( SELECT company FROM _pynonymizer_seed_fake_data ORDER BY RANDOM(), MD5("updatetarget"::text) LIMIT 1),"CLIENT_ID" = ( SELECT md5 FROM _pynonymizer_seed_fake_data ORDER BY RANDOM(), MD5("updatetarget"::text) LIMIT 1),"CLIENT_SECRET" = ( SELECT md5 FROM _pynonymizer_seed_fake_data ORDER BY RANDOM(), MD5("updatetarget"::text) LIMIT 1);']
strategy3_75721d1a2a054d33bebd27eb5e2ee9ae'#

Is it possible to always double-quote table's name as has been done for columns?

Hi, thanks for looking into that! Yeah, this seems like a good fix. I can pull together a PR later this week, or i'm happy to look at PRs if you're down 😇

Hi, Jerome. Thanks for your time!


Add service block to formula api

[x] Have you followed the guidelines in our Contributing document?
[x] Have you checked to ensure there aren't other open Pull Requests for the same change?
[x] Have you added an explanation of what your changes do and why you'd like us to include them?
[x] Have you written new tests for your changes? Here's an example.

[x] Have you successfully run brew typecheck with your changes locally?
[x] Have you successfully run brew tests with your changes locally?

This fixes #14925.
The idea here is to include the service block info in the formula API JSON so that it can be loaded from the API. This will allow us to more consistently build service files and will mean that brew services doesn't have to be updated to work with the new API.
The first thing that was added was the ability to serialize and deserialize service blocks. We needed the ability to replace all local paths with placeholders when building the API JSON and then replace those placeholders with local paths when loading from the API.
The second thing was adding this service block JSON to the API and loading it from the API.
The other commits are just tests.

Review period will end on 2023-03-21 at 00:00:00 UTC.

Here's my testing script for checking that the service files were being generated correctly and that the serialization was consistent.

Script: https://gist.github.com/apainintheneck/6ed138ac7214788cd20bb7da82f7aa36

Review period ended.

Thanks for the feedback. I think that I'll rewrite the recursive (de)serialization methods to get rid of the recursion. It'll allow me to add better type annotations and I don't think the special handling around symbols will be necessary anymore which will be another bonus. It will be a little more verbose but that's probably fine.

Ping me when this is near final and I'll review this.

I changed the serialization methods to not be recursive to make it easier to enable typing. I also changed the paths substitutions when serializing to use the same method as we already use with casks. This involves monkey patching the $HOME and $HOMEBREW_PREFIX values when generating the hash. Beyond that I updated the script from before.

Script

The generated service files are still the same but the serialization is different. That is because I'm not converting the Pathname objects to Strings anymore because that happens naturally when converting it to JSON later on.
You can see the different serialization results here.
I still need to do more testing around the generate-*-api commands though to make sure they're still working correctly. Also, will there be any problems with monkey patching those common paths when generating the formula api JSON? I can't think of anything but I might have missed something.

@Bo98 This is ready for final review.

I'm now happy with this as it is right now. I'll wait another day for any final reviews and then merge it in sometime tomorrow.
As a sanity check I created another script that's a sort of brew readable but for the generated API. Might be useful for other PRs too.

Readall Script

As a sanity check I created another script that's a sort of brew readall but for the generated API. Might be useful for other PRs too.

@apainintheneck 💯% yes! Would be nice to get this as a CI check in Homebrew/brew (not in/blocking this PR)? How long does it take to run for you?


initial CSV-recoder

Adds a script for recording files according to the format expected by the CSV-provider

also one conflicting file I see

lgtm.


R11 - Spoke Arrive Remote Rad Order

SOTTP USR 11-1 Remote RAD Order Arrived at Spoke.docx
Completed in Sprint 14
SOTTP USR 11-2 Send Remote RAD Order Arrive from Spoke to Hub.docx
Completed in Sprint 14
SOTTP USR 11-3 Process Remote RAD Order Arrive at Hub.docx
Completed in Sprint 14
SOTTP USR 11-4 View Remote RAD Order Arrive at Hub in CPRS.docx
Completed in Sprint 14


intelligent crashes

add code to check for inbreeding coefficients not available or file empty and for regions or regions file not available or file empty --> then break code and output an error message

I added these checks to all scripts I saw with inbreeding coefficients and/or regions. Someone needs to do a run thru and make sure they work fine


Is there any way for ASR recipes to calculate CER when doing testing?

Hello,
I am using LibriSpeech/ASR/transformer/train.py recipe. I just notice it only calculates WER when doing testing.
Is there any way to calculate character error rate (CER) as well?
Thanks

Hi yes, have a look at the CommonVoice recipes, they report CER. You must add a ErrorRateStats to your yaml and then call it at the evaluation :-)


Add a section about Smart Contract Best Practices

Include common patterns and anti-patterns in smart contract development.
Offer tips for optimizing gas costs.
Explain security measures to prevent vulnerabilities and attacks.

Outside our current focus


will the flash attention embed self-extend?

https://github.com/datamllab/LongLM

Hi! We just implemented FlashAttention for self-extend utilizing the window FA supported by flash_attn. In a word, we merge two FA together to get the attention of self-extend. Check https://github.com/datamllab/LongLM/pull/28 for more details! Now, this implementation, at a cost of slight increased the memory occupation and run time, can extend to 10x larger for Llama, Mistral, Gemma and Qwen1.5 in a fine-turning free way.
But still looking forward to the official implementation of such two-parts FlashAttention with a window!


[TEST BUG] SearchServiceTests.testSearchWhileIndexDeleted extremely slow

This unit test is very slow (e.g. hundreds of seconds). Iterations or number of nodes or whatever should be toned down.

Thanks, we will look into this how we can optimize this and reduce run time.

@abbashus Can you take pick this up and take a look at it?  Thanks!

Sure @CEHENKLE, will go over this.

NOTE : I would not call this is a bug. It's more of an opportunity for optimization. Even at max iterations it was taking 2m45s which I believe does not skews the total build time very much.
Reproduced this with following command and different build envs:
./gardlew clean && ./gradlew ':server:test'  --no-build-cache

Checked the following reports for test run time at
file:///<path-to-OpenSearch-repo>/server/build/reports/tests/test/classes/org.opensearch.search.SearchServiceTests.html

Build Environment
Min Time (100 iterations)
Max Time (10K iterations)
Max Time after tuning (1000 iterations)

Amazon Linux  (Linux 5.11.0-1016-aws)- 48 core- 48 Gradle workers- Max JVM memory heap size 3GB- JVM 14
2.477s
1m 32.742s
16.988s

Mac OS X 10.15.7- 12 core- 12 Gradle workers- Max JVM memory heap size 3GB- JVM 14
3.627s
2m 43.976s
1m 5.594s

After tuning down the max iteration by order of magnitude (10000 ->1000), I was able to reduce testing time by ~30 secs on MacOS and ~70 secs on Amazon Linux. I will be raising a PR based on this observations.


feat: add secret controller in knode

What type of PR is this?
feat
What does this PR do?
add secret controller in knode
Which issue(s) does this PR fix?
Fixes #
Special notes for your reviewer:
In addition, we fixed the log level of "Successfully updated lease"

opened


Merge HTK release 2017.4.3 into master

Overview
Merge the current htk_development branch into master in preparation of marking the 2017.4.3 release.

Merging based on @StephenHodgson 's prior approval (post approval change was to add a new documentation file)


chore(CPlusPlus): add maximum difference

What kind of change does this PR introduce? (check at least one)

[ ] Bugfix
[x] New algorithm
[ ] Optimization in previous algorithms
[ ] Code style update
[ ] Refactor
[ ] Documentation
[ ] Other, please describe:

Briefly describe the changes in this PR

This program finds the maximum difference between two elements in an array such that larger element appears after the smaller number in C++.
Other information:

Hi @khushisinha20,
Any updated?


CUDA out of memory

Hi ZHKKKE,
First of all, thank you for your work. Currently, I retrain the gct by PSPNet with the ResNet-101 backbone in Pascal VOC, and use the parameter of im_size=513, batch_size=4 with 4 gpus. However,  i am getting the error of insufficient memory. I retrained other methods you offered by using the parameter of im_size=513, batch_size=4 with 4 gpus and can get the accuracy provided by README.md.
I want to know how you train the gct with 4 GPUs? Save memory by changing im_size=513 to im_size=321？Or is there any other way？
Thank you and regards

Hi, thanks for your attention.
Which GPU are you using? For PSPNet, if you use 4 GPUs for training, the GCT algorithm requires about 12G memory (each GPU). I have tried to optimize the algorithm, but it still requires a lot of memory during training.
If you change the im_size to 321, the performance may be decreased.
Is it possible for you to use 8 GPUs for training? If so, in the script pspnet_pascalvoc_1-8_sslgct.py, you can change:
('lr', 0.00025),
('batch_size', 4),
('unlabeled_batch_size', 2),

to
('lr', 0.000125),
('batch_size', 2),
('unlabeled_batch_size', 1),

You can also use the results reported by us. For PSPNet + GCT under 1/2 label, the SSL performance is 73.92. This results will be uploaded soon.

Hi, thanks for your attention.
Which GPU are you using? For PSPNet, if you use 4 GPUs for training, the GCT algorithm requires about 12G memory (each GPU). I have tried to optimize the algorithm, but it still requires a lot of memory during training.
If you change the im_size to 321, the performance may be decreased.
Is it possible for you to use 8 GPUs for training? If so, in the script pspnet_pascalvoc_1-8_sslgct.py, you can change:
('lr', 0.00025),
('batch_size', 4),
('unlabeled_batch_size', 2),

to
('lr', 0.000125),
('batch_size', 2),
('unlabeled_batch_size', 1),

You can also use the results reported by us. For PSPNet + GCT under 1/2 label, the SSL performance is 73.92. This results will be uploaded soon.

Thank you very much for your answer.
I used 4 GPUs (each 12G). During the gct experiment, I found that the main GPU used for integration would exceed 12G memory. Next, i will try to solve the imbalance problem of memory by using DistributedDataParallel.

Thank you very much for your answer.
I used 4 GPUs (each 12G). During the gct experiment, I found that the main GPU used for integration would exceed 12G memory. Next, i will try to solve the imbalance problem of memory by using DistributedDataParallel.

Yes. If you use DistributedDataParallel, the memory will be balanced better. I am sorry that I do not have time to implement it recently.

Yes. If you use DistributedDataParallel, the memory will be balanced better. I am sorry that I do not have time to implement it recently.

Thank you again.

Thank you again.


Read filtered chapters from the reader

Describe your suggested feature
Especially for those manga having many chapters, I apply the filter Unread and sort them up by Ascending Chap # so that when I re enter the entry I always see the next unread chapter first.
Problem is, if I for example read this new chapter and I wanna peek at previous ones from the reader, by swiping back from the 1st page of the new chapter, then it tells me there are not chapters available, since those are filtered out, and so I must go back, adjust the filter, scroll down to find that chapter, read it, then go back again and reapply the filter.
Maybe we can have a query asking us if we are sure to view the filtered chapter from the reader?
Anything that could improve QoL.
Other details
No response
Acknowledgements

[X] I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open or closed issue.
[X] I have written a short but informative title.
[X] If this is an issue with an official extension, I should be opening an issue in the extensions repository.
[X] I have updated the app to version 1.10.5.
[X] I will fill out all of the requested information in this form.

Have you tried turn off the option "Skip filtered chapters" in Reader settings?

@cuong-tran turning that off now solved it. Thank you.


Autoloading a rom from a URL

Hello! I have a question that I couldn't find answered in the documentation. I am working on a GBA game and I'd like to publish it so that people can play it in the browser without downloading the rom file and clicking "Select" on https://gbajs2.com. Basically I'd like to know how to modify index.html so it automatically loads a rom from a preselected URL rather than prompting the user.
I'm sure this is probably obvious to someone with a cursory understanding of Javascript, but for the rest of us, it'd be really useful to have this documented. Thanks!

First, you will want to make sure you have legal rights to the rom you are distributing.
Here is example code to do what you are asking
window.onload = function() {
	if (gba && FileReader) {
		gba.audio.masterEnable = false;
		var canvas = document.getElementById('screen');
		gba.setCanvas(canvas);

		gba.logLevel = gba.LOG_ERROR;

		loadRom('resources/bios.bin', function(bios) {
			gba.setBios(bios);
		});

		if (!gba.audio.context) {
			// Remove the sound box if sound isn't available
			var soundbox = document.getElementById('sound');
			soundbox.parentElement.removeChild(soundbox);
		}

		if (window.navigator.appName == 'Microsoft Internet Explorer') {
			// Remove the pixelated option if it doesn't work
			var pixelatedBox = document.getElementById('pixelated');
			pixelatedBox.parentElement.removeChild(pixelatedBox);
		}
	} else {
		var dead = document.getElementById('controls');
		dead.parentElement.removeChild(dead);
	}
	/* TODO: Change this part to the rom you want */
	loadRom("resources/r.gba", run);
}

Be sure to include <script src="resources/ui/xhr.js"></script>

Thanks! It's a game I'm writing myself so that should be no trouble.
Do you think there's somewhere in the documentation this should be added?

I've added this to a copy of gbajs2, but when I load it, I get the following error: Uncaught TypeError: FileReader.readAsArrayBuffer: Argument 1 does not implement interface Blob.
My version is here: https://p.hagelb.org/gbajs2/
Any idea what's up?

Sorry my snippet was incomplete. You need the run function callback as well.
Looks like in your code you need to add file = new Blob([file]); to line 115

window.onload = function() {
	if (gba && FileReader) {
		gba.audio.masterEnable = false;
		var canvas = document.getElementById('screen');
		gba.setCanvas(canvas);

		gba.logLevel = gba.LOG_ERROR;

		loadRom('resources/bios.bin', function(bios) {
			gba.setBios(bios);
		});

		if (!gba.audio.context) {
			// Remove the sound box if sound isn't available
			var soundbox = document.getElementById('sound');
			soundbox.parentElement.removeChild(soundbox);
		}

		if (window.navigator.appName == 'Microsoft Internet Explorer') {
			// Remove the pixelated option if it doesn't work
			var pixelatedBox = document.getElementById('pixelated');
			pixelatedBox.parentElement.removeChild(pixelatedBox);
		}
	} else {
		var dead = document.getElementById('controls');
		dead.parentElement.removeChild(dead);
	}
	/* TODO: Change this */
	loadRom("resources/r.gba", run);
}

function run(file) {
	file = new Blob([file]);
	var load = document.getElementById('select');
	load.textContent = '';
	gba.loadRomFromFile(file, function(result) {
		if (result) {
			for (var i = 0; i < runCommands.length; ++i) {
				runCommands[i]();
			}
			runCommands = [];
			gba.runStable();
			setTimeout(loadSave, 1000);
		} else {
			load.textContent = 'FAILED';
			setTimeout(function() {
				load.textContent = 'SELECT';
				load.onclick = function() {
					document.getElementById('loader').click();
				}
			}, 3000);
		}
	});
}

Perfect; that did the job. Thanks!


 The reasons for this are historic but it makes it extra difficult to add new features and capabilities without breaking compatibility, and this is largely for code that plugins themselves do not need to access (but we can't rule it out).
We should design and implement an improved plugin API that can act as a stable compatibility layer, allowing us to modify the internal libs it interfaces with without introducing breaking changes.
A good start would be the bloblang plugin API since that is a fresh API regardless, and the goal will be to make the interfaces and types that it exposes entirely isolated from Benthos internal and lib packages. Once we're happy with it we can start implementing similar APIs for all other components.
All of this work will be done under V3, and will be available to users for an extended period of time before we can consider bumping to V4 and pruning the old APIs.

Done in that the APIs are now in their forever home. Extensions to the APIs will now get their own issues.


Make use of templatefile Function

Since you require Terraform 0.12.x, I think it's better to use the templatefile function instead.

...and you've got 100 stars :tada:

Some additional context: This module depends on the hashicorp/template provider. Since the template provider has been deprecated and archived it was never built for ARM64 devices such as Apple's M1 Macs, leading to the following error upon running terraform init:
╷
│ Error: Incompatible provider version
│
│ Provider registry.terraform.io/hashicorp/template v2.2.0 does not have a package available for your current platform, darwin_arm64.
│
│ Provider releases are separate from Terraform CLI releases, so not all providers are available for all platforms. Other versions of this provider may have different platforms supported.
╵

A quick fix is to build it yourself, which is described here.


Current Images Contain Deprecated GitHub RSA SSH Host Key

Description
It appears that the ubuntu-latest (at least) image has not been updated to include the latest RSA SSH host key for GitHub.com after We updated our RSA SSH host key. This could enable an adversary to inject malicious code into a running action.
From what I can tell, this should get picked up automatically if the image is rebuilt with the ssh-keyscan.
Could we get a fresh image build(s) to use the current key?
Platforms affected

[ ] Azure DevOps
[ ] GitHub Actions - Standard Runners
[ ] GitHub Actions - Larger Runners

Runner images affected

[ ] Ubuntu 18.04
[ ] Ubuntu 20.04
[X] Ubuntu 22.04
[ ] macOS 11
[ ] macOS 12
[ ] Windows Server 2019
[ ] Windows Server 2022

Image version and build link
Runner Image
Image: ubuntu-22.04
Version: 20230317.1
Included Software: https://github.com/actions/runner-images/blob/ubuntu22/20230317.1/images/linux/Ubuntu2204-Readme.md
Image Release: https://github.com/actions/runner-images/releases/tag/ubuntu22%2F20230317.1
Is it regression?
No
Expected behavior
The latest image should contain the current host keys.
Actual behavior
The latest image (as of now) contains a host key that was removed from use.
Repro steps

Start an action using the ubuntu-latest runner.
grep "github.com ssh-rsa" /etc/ssh/ssh_known_hosts should match the new key:

github.com ssh-rsa AAAAB3NzaC1yc2EAAAADAQABAAABgQCj7ndNxQowgcQnjshcLrqPEiiphnt+VTTvDP6mHBL9j1aNUkY4Ue1gvwnGLVlOhGeYrnZaMgRK6+PKCUXaDbC7qtbW8gIkhL7aGCsOr/C56SJMy/BCZfxd1nWzAOxSDPgVsmerOBYfNqltV9/hWCqBywINIR+5dIg6JTJ72pcEpEjcYgXkE2YEFXV1JHnsKgbLWNlhScqb2UmyRkQyytRLtL+38TGxkxCflmO+5Z8CSSNY7GidjMIZ7Q4zMjA2n1nGrlTDkzwDCsw+wqFPGQA179cnfGWOWRVruj16z6XyvxvjJwbz0wQZ75XK5tKSb7FNyeIEs4TT4jk+S4dhPeAUC5y+bDYirYgM4GC7uEnztnZyaVWQ7B381AK4Qdrwt51ZqExKbQpTUNn+EjqoTwvqNj4kqx5QUCI0ThS/YkOxJCXmPUWZbhjpCg56i+2aB6CmK2JGhn57K5mj0MNdBXA4/WnwH6XoPWJzK5Nyu2zB3nAZp+S5hpQs+p1vN1/wsjk=

Hello @jbeard6, thanks for your report. Images with updated RSA SSH Host Key in rollout process. New version for ubuntu and windows will be available by the end of this week.

It should be fixed as the new image is delivered.

@sergei-pyshnoi
What does:

New version for ubuntu and windows will be available by the end of this week
On March, 29th mean?

I still get today (April, 4th) errors regarding the host key with windows-latest:
@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@
@    WARNING: REMOTE HOST IDENTIFICATION HAS CHANGED!
Someone could be eavesdropping on you right now (man-in-the-middle attack)!
It is also possible that a host key has just been changed.
The fingerprint for the RSA key sent by the remote host is
SHA256:uNiVztksCsDhcc0u9e8BujQXVUpKZIDTMczCvj3tD2s.
Please contact your system administrator.
Add correct host key in /c/Users/VssAdministrator/.ssh/known_hosts to get rid of this message.
Offending RSA key in /c/Users/VssAdministrator/.ssh/known_hosts:1
Host key for github.com has changed and you have requested strict checking.
Host key verification failed.

I can only assume there is a rolling update? When is this finished? This is breaking a lot of builds for us (although arguably Github (hey, aren't they supposed to be the same company :) ) is to blame...)...

@ChristianUlbrich Image with updated key is available. But I am not sure why is in your log ssh client searching its in  /c/Users/VssAdministrator/.ssh/known_hosts when key is stored in /c/Program Files/Git/etc/ssh/ssh_known_hosts . What kind of runner did you use, version? How exactly you get this error?

@sergei-pyshnoi You nailed it! After trying to setup a demo pipeline, I figured out, I was using the InstallSSHKey (ADO) task for setting up access to GitHub via a deploy key and I explicitly added GitHub's (now de-funct) public key. It has been a while, since I have looked at the pipeline code in my project!
So sorry for bothering you, after finally remembering how I magically set up knownHostsEntry: '$(githubSSHFingerprint)' (hint: via a variable group in ADO), I was able to update it with the current one and now everything works again...


Use firebase db for better multidevice support

Note that new features probably won't get any active development from the repo owner.
Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
Read status across devices isn't great, it would be nice if the local read db was stored on the cloud
Describe the solution you'd like
A clear and concise description of what you want to happen. If it's related to the website, provide clear instructions on how to use the feature (including screenshots)
Firebase db
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.

for interacting with firebase db, we should use the https://api.mangadex.org/docs/swagger.html#/User/get-user-me id for user info


Project features required for v1.2

This ticket is for tracking what items are required for the project model.
/cc @jasonpagetas, fyi
Links
Tasks / Requirements

[ ] #285

[ ] #293

[ ] #294

[ ] Project Import permission for API

[ ] Unit tests for project API

[ ] Unit test project Import permissions

[ ] Project index view pagination

Project Priority:

[ ] :memo: Project priority documentation
[ ] :orange_circle: Unit test project priotities
[ ] :large_blue_circle: UI View project priority

Project State:

[ ] :memo: Project state documentation
[ ] :orange_circle: Unit test project states
[ ] :large_blue_circle: UI View project state

Project Type:

[ ] :memo: Project type documentation
[ ] :orange_circle: Unit test project type
[ ] :large_blue_circle: UI View project type

Potential future tasks

[ ] Project team permissions
[ ] Project manager permissions

Project States and Project Types do not show on the Projects page, they do show when you navigate into the project.

Project States and Project Types do not show on the Projects page, they do show when you navigate into the project.

@jasonpagetas, fixed in 92d3692f8584a04d937bb37c891601834f7d3550


expand conn_close_flushed map and add telemetry

What does this PR do?
Increases the size of the conn_close_flushed map which is filling up in some cases in production. Adds some telemetry to give us more insight into this issue.
Motivation
Describe how to test/QA your changes
Possible Drawbacks / Trade-offs
Additional Notes

/merge


Ability to remove actions from context menu

How to modify the right-click menu information in the edit box and add or delete functions?

Currently, it is possible to only add new actions e.g. https://microsoft.github.io/monaco-editor/playground.html#interacting-with-the-editor-adding-an-action-to-an-editor-instance

Currently, it is possible to only add new actions e.g. https://microsoft.github.io/monaco-editor/playground.html#interacting-with-the-editor-adding-an-action-to-an-editor-instance

The connection cannot be opened, indicating that the connection has been reset. Do you have anything else?

The connection cannot be opened, indicating that the connection has been reset. Do you have anything else?

Sorry, I don't know what you mean.

The connection cannot be opened, indicating that the connection has been reset. Do you have anything else?

Sorry, I don't know what you mean.

The connection can't be opened

Do you mean you cannot access https://microsoft.github.io/monaco-editor/playground.html#interacting-with-the-editor-adding-an-action-to-an-editor-instance ?

Do you mean you cannot access https://microsoft.github.io/monaco-editor/playground.html#interacting-with-the-editor-adding-an-action-to-an-editor-instance ?

yes

Please contact your ISP.

See also https://github.com/microsoft/monaco-editor/issues/1567#issuecomment-777876361


Support repeatable migration.

Hi Nikita,
Thanks for making this handy tool.
One feature I would like to have in this tool is the support for Repeatable migration in flyway.
Currently when I have a R__xxx.sql, I am getting
Caused by: org.springframework.beans.factory.BeanCreationException: Error creating bean with name 'r2dbcMigrate' defined in class path resource [name/nkonev/r2dbc/migrate/autoconfigure/R2dbcMigrateAutoConfiguration.class]: Invocation of init method failed; nested exception is java.lang.NumberFormatException: For input string: "R"

I am using the latest release.

Hello @YixingCheng
repeatable migrations (in Flyway definition) requires checksums. This tool currently doesn't supports checksums.
PR are welcome


Create and use a custom context for docker builds

Creates a custom context to pass to the docker build image command. The custom context excludes any directory that:

Is an top-level SDK-created directory that should not be used by the Dockerfile: build, conf, content, logs, resources
Is hidden (e.g., .git, .idea, etc)
Contains a Python virtual environment

Example of running a 2-minute long-run. Times above the 2-minute mark is the time spent setting up the test, the majority of which is building the image.
Without custom context:
(venv-test) ❯ du -h -d 0
159M	.
(venv-test) ❯ time mp-test -c Default long-run -d 2m -i 30s
[...]
mp-test -c Default long-run -d 2m -i 30s  14.45s user 1.76s system 11% cpu 2:24.61 total

With custom context (Approximately 4MB):
(venv-test) ❯ time mp-test -c Default long-run -d 2m -I 30s
[...]
mp-test -c Default long-run -d 2m -i 30s  2.88s user 0.93s system 3% cpu 2:04.67 total

Resolves #89

Is it possible a developer would want to read a properties file (or something similar) from the conf directory?

I was going back and forth on what to include/exclude. Traditionally, we used the conf directory to store user-config files (and describe.xml). With a dockerized adapter, though, the conf directory still exists on the CP in the traditional spot, but it isn't mapped to the container. So, we could include the conf directory in the container, but it would be a duplicate of the one on the CP filesystem, and wouldn't have any persistent storage.
That said, it's likely a small folder size, so it shouldn't affect the build times much, and, especially in the case where the user is not making a programmatic describe, that would be the location the describe.xml lives -- if they want to access it during collection if we don't include the conf directory, then they'd have to duplicate it and maintain two copies.
So, I think you're correct: we should include the conf directory in the image. But definitely an edge case, and I don't know if we should encourage using it.


NeuVector policy alternatives (no image scanning)

It would be nice to offer equivalent of NV admission controller policies.
This is a list of the policies that NV currently offers that we can implement:

[x] allow privilege escalation
[x] kubewarden/kubewarden-controller#307
[x] kubewarden/kubewarden-controller#313
[x] image
[x] image registry
[x] labels
[x] kubewarden/volumeMounts-policy#3
[x] namespace
[x] PSP best practice
[x] resource limit configuration -> no need to implement it, we can use k8s LimitRanger controller that's built into the API server
[x] run as privileged
[x] run as root
[x] share host IPC namespaces
[x] share host network
[x] share host PID namespace
[x] kubewarden/kubewarden-controller#308
[x] kubewarden/kubewarden-controller#309

The NV policies that deal with image scanning are not part of this list, they are covered by this issue.
If needed, the source code of NV controller can be found here

Closing, all the policies are implemented


feat: Add Mode & Mode Sepolia

Adding Mode Network mainnet & testnet
Mainnet: https://docs.mode.network/mode-developer-mainnet/mode-dev-mainnet-information
Testnet: https://docs.mode.network/mode-testnet/using-mode-testnet

fixed failing workflows due to dangling slashes in the explorer URLs and squashed the commit


instlaler-tools: new dir and tool

Rename the dir ipi-tools to generic name (tools can be used in ipi or upi)
Add script to easily use the latest image during

Signed-off-by: Douglas Schilling Landgraf<EMAIL_ADDRESS>

@gekorob @Gal-Zaidman @eslutsky


Add option to set record IDs in ObjectToLiteral

Like JsonDecoder (see JsonDecoder#decode), ObjectToLiteral should use a counter to set record IDs. For compatibility, default should remain empty strings as IDs (see ObjectToLiteral#process).
Came up in OERSI, where we want to avoid JSON roundtripping for getting record IDs (see Flux).

Resolved with https://github.com/metafacture/metafacture-core/pull/354, see usage in https://gitlab.com/oersi/oersi-etl/-/blob/fb559fbb7e3fdcdc4977ab7ba23303844271e509/data/production/hoou-to-oersi.flux#L14

Resolved with https://github.com/metafacture/metafacture-core/pull/354, see usage in https://gitlab.com/oersi/oersi-etl/-/blob/fb559fbb7e3fdcdc4977ab7ba23303844271e509/data/production/hoou-to-oersi.flux#L14


Interpretation of fourth layer preferences

First of all thanks for putting your efforts on making deep visualizations available to a broader audience.
Due to the lack of other options I would like to ask you here about your DeepPref class.
If my memories are correct, visualizing normalized weights from the first layer corresponds to a close-form solution of the optimization problem 'which input maximizes 1st layer activations'. I see that something similar makes sort of sense between the 3rd and 1st layers too - as it is done in the pref_grid function. However, I fail to see any interpretation with further layers. For instance DeepPref between 4th and 1st layers returns K weights between the two first layers, where K is sorted according to the the activations of the 4th layer. What does it mean?

The intuition would be just a depth first search on the connection graph. We use the first layer filters as input themselves and check how much that activated a neuron on a deep layer. To do the visualization, we get a random neuron on a deeper layer and ask which samples (i.e. neurons in the first layer) activated the most that deep neuron?


feat: add rust-fnv src

rust-fnv, fowler–Noll–Vo hash function.
Log: rust-fnv src would be added.
Issue: https://github.com/deepin-community/sig-deepin-sysdev-team/issues/140

/lgtm

/approve

/check obs


Update README.md with new logo

IBM Legal required to change the logo from the icon potentially used from the IBM repo

Updating the logo per IBM Legal recommendation

LGTM

Closing in favor of #72.