RELEASE BLOCKER: Firebase packages and plugins breaking Flutter application

Steps to Reproduce

I'm having major trouble when using firebase packages within my app. On iOS my app will not compile. I think it started since I updated Xcode but don't know why that would be the problem. I've been stuck on it for over a week.
The two packages causing a problem are:

firebase_storage ^3.0.6
cloud_firestore 0.12.9+4

All the other firebase packages do not cause a problem.

firebase_core: ^0.4.0+9
firebase_auth: ^0.14.0+5
firebase_messaging: ^5.1.6
firebase_dynamic_links: ^0.5.0+1
cloud_functions: ^0.4.1+1

The error I get in the console is:
Launching lib/main.dart on iPhone 7 in debug mode... Xcode build done. 103.6s Failed to build iOS app Error output from Xcode build: ↳ 2019-10-01 05:54:27.049 xcodebuild[80532:1543780] DTDeviceKit: deviceType from 6aa0c9719a85c174869a09656237b42f23701a91 was NULL 2019-10-01 05:54:27.192 xcodebuild[80532:1543775] DTDeviceKit: deviceType from 6aa0c9719a85c174869a09656237b42f23701a91 was NULL 2019-10-01 05:54:27.643 xcodebuild[80532:1543780] DTDeviceKit: deviceType from 023ad015ab9ce7b62b0a4e86af10805b3ef8fdb4 was NULL 2019-10-01 05:54:28.935 xcodebuild[80532:1543771] [MT] DTDeviceKit: deviceType from 023ad015ab9ce7b62b0a4e86af10805b3ef8fdb4 was NULL 2019-10-01 05:54:28.944 xcodebuild[80532:1543771] [MT] DTDeviceKit: deviceType from 023ad015ab9ce7b62b0a4e86af10805b3ef8fdb4 was NULL 2019-10-01 05:54:28.951 xcodebuild[80532:1543771] [MT] DTDeviceKit: deviceType from 023ad015ab9ce7b62b0a4e86af10805b3ef8fdb4 was NULL ** BUILD FAILED ** Xcode's output: ↳ /Users/earyzhe/dev/FlutterProjects/Mini exercises/Firebase Projects/firebase_compile_test/ios/Pods/Protobuf/objectivec/google/protobuf/Wrappers.pbobjc.m:17:10: warning: non-portable path to file ''; specified path differs in case from file name on disk [-Wnonportable-include-path] #import ^~~~~~~~~~~~~~~~~~~~~~~~~~~~ 1 warning generated. /Users/earyzhe/dev/FlutterProjects/Mini exercises/Firebase Projects/firebase_compile_test/ios/Pods/Protobuf/objectivec/google/protobuf/Type.pbobjc.m:19:10: warning: non-portable path to file ''; specified path differs in case from file name on disk [-Wnonportable-include-path] #import ^~~~~~~~~~~~~~~~~~~~~~~~ /Users/earyzhe/dev/FlutterProjects/Mini exercises/Firebase Projects/firebase_compile_test/ios/Pods/Protobuf/objectivec/google/protobuf/Type.pbobjc.m:20:10: warning: non-portable path to file ''; specified path differs in case from file name on disk [-Wnonportable-include-path] #import ^~~~~~~~~~~~~~~~~~~~~~~ /Users/earyzhe/dev/FlutterProjects/Mini exercises/Firebase Projects/firebase_compile_test/ios/Pods/Protobuf/objectivec/google/protobuf/Type.pbobjc.m:21:10: warning: non-portable path to file ''; specified path differs in case from file name on disk [-Wnonportable-include-path] #import ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 3 warnings generated. /Users/earyzhe/dev/FlutterProjects/Mini exercises/Firebase Projects/firebase_compile_test/ios/Pods/Protobuf/objectivec/google/protobuf/Timestamp.pbobjc.m:17:10: warning: non-portable path to file ''; specified path differs in case from file name on disk [-Wnonportable-include-path]
This actually carries on like this for another 100 lines or so, basically repeating a similar thing.

               In file included from
/Users/earyzhe/SDKs/flutter/.pub-cache/hosted/pub.dartlang.org/firebase_core-0.4.0+9/ios/Classes/FirebaseCorePlugin.m:8:
               /Users/earyzhe/dev/FlutterProjects/Mini exercises/Firebase
Projects/firebase_compile_test/ios/Pods/Headers/Public/Firebase/Firebase.h:31:13: fatal
               error: could not build module 'FirebaseFirestore'
                   #import <FirebaseFirestore/FirebaseFirestore.h>
                    ~~~~~~~^
               While building module 'FirebaseStorage' imported from /Users/earyzhe/dev/FlutterProjects/Mini exercises/Firebase
               Projects/firebase_compile_test/ios/Pods/Headers/Public/Firebase/Firebase.h:139:
               In file included from <module-includes>:1:
               In file included from /Users/earyzhe/dev/FlutterProjects/Mini exercises/Firebase Projects/firebase_compile_test/ios/Pods/Target Support
               Files/FirebaseStorage/FirebaseStorage-umbrella.h:13:
               In file included from /Users/earyzhe/dev/FlutterProjects/Mini exercises/Firebase
               Projects/firebase_compile_test/ios/Pods/FirebaseStorage/Firebase/Storage/Public/FirebaseStorage.h:17:
               /Users/earyzhe/dev/FlutterProjects/Mini exercises/Firebase
               Projects/firebase_compile_test/ios/Pods/FirebaseStorage/Firebase/Storage/Public/FIRStorage.h:100:1: error: property with 'retain (or
strong)'
               attribute must be of object type
               @property(strong, nonatomic) dispatch_queue_t callbackQueue;
               ^
               1 error generated.
               3 errors generated.

               In file included from
/Users/earyzhe/SDKs/flutter/.pub-cache/hosted/pub.dartlang.org/cloud_functions-0.4.1+1/ios/Classes/CloudFunctionsPlugin.m:8:
               /Users/earyzhe/dev/FlutterProjects/Mini exercises/Firebase
Projects/firebase_compile_test/ios/Pods/Headers/Public/Firebase/Firebase.h:31:13: fatal
               error: could not build module 'FirebaseFirestore'
                   #import <FirebaseFirestore/FirebaseFirestore.h>
                    ~~~~~~~^
               While building module 'FirebaseStorage' imported from /Users/earyzhe/dev/FlutterProjects/Mini exercises/Firebase
               Projects/firebase_compile_test/ios/Pods/Headers/Public/Firebase/Firebase.h:139:
               In file included from <module-includes>:1:
               In file included from /Users/earyzhe/dev/FlutterProjects/Mini exercises/Firebase Projects/firebase_compile_test/ios/Pods/Target Support
               Files/FirebaseStorage/FirebaseStorage-umbrella.h:13:
               In file included from /Users/earyzhe/dev/FlutterProjects/Mini exercises/Firebase
               Projects/firebase_compile_test/ios/Pods/FirebaseStorage/Firebase/Storage/Public/FirebaseStorage.h:17:
               /Users/earyzhe/dev/FlutterProjects/Mini exercises/Firebase
               Projects/firebase_compile_test/ios/Pods/FirebaseStorage/Firebase/Storage/Public/FIRStorage.h:100:1: error: property with 'retain (or
strong)'
               attribute must be of object type
               @property(strong, nonatomic) dispatch_queue_t callbackQueue;
               ^
               1 error generated.
               3 errors generated.

               Libtool /Users/earyzhe/dev/FlutterProjects/Mini\ exercises/Firebase\

Projects/firebase_compile_test/build/ios/Debug-iphonesimulator/firebase_dynamic_links/firebase_dynamic_links.framework/firebase_dynamic_links
               normal x86_64 (in target 'firebase_dynamic_links' from project 'Pods')
                   cd /Users/earyzhe/dev/FlutterProjects/Mini\ exercises/Firebase\ Projects/firebase_compile_test/ios/Pods
                   export IPHONEOS_DEPLOYMENT_TARGET=8.0
                   /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/libtool -static -arch_only x86_64 -D
-syslibroot
                   /Applications/Xcode.app/Contents/Developer/Platforms/iPhoneSimulator.platform/Developer/SDKs/iPhoneSimulator13.0.sdk
                   -L/Users/earyzhe/dev/FlutterProjects/Mini\ exercises/Firebase\
                   Projects/firebase_compile_test/build/ios/Debug-iphonesimulator/firebase_dynamic_links -filelist

/Users/earyzhe/Library/Developer/Xcode/DerivedData/Runner-bnfouqnnbwnhrchjivopxzdlduwp/Build/Intermediates.noindex/Pods.build/Debug-iphonesimu
                   lator/firebase_dynamic_links.build/Objects-normal/x86_64/firebase_dynamic_links.LinkFileList -framework Foundation -o
                   /Users/earyzhe/dev/FlutterProjects/Mini\ exercises/Firebase\

Projects/firebase_compile_test/build/ios/Debug-iphonesimulator/firebase_dynamic_links/firebase_dynamic_links.framework/firebase_dynamic_links

               CodeSign /Users/earyzhe/dev/FlutterProjects/Mini\ exercises/Firebase\
               Projects/firebase_compile_test/build/ios/Debug-iphonesimulator/firebase_dynamic_links/firebase_dynamic_links.framework (in target
               'firebase_dynamic_links' from project 'Pods')
                   cd /Users/earyzhe/dev/FlutterProjects/Mini\ exercises/Firebase\ Projects/firebase_compile_test/ios/Pods
                   export CODESIGN_ALLOCATE=/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/codesign_allocate

               Signing Identity:     "-"

                   /usr/bin/codesign --force --sign - --timestamp=none /Users/earyzhe/dev/FlutterProjects/Mini\ exercises/Firebase\
                   Projects/firebase_compile_test/build/ios/Debug-iphonesimulator/firebase_dynamic_links/firebase_dynamic_links.framework
               /Users/earyzhe/dev/FlutterProjects/Mini exercises/Firebase
               Projects/firebase_compile_test/build/ios/Debug-iphonesimulator/firebase_dynamic_links/firebase_dynamic_links.framework: replacing
existing
               signature

[  +88 ms] Could not build the application for the simulator.
[   +1 ms] Error launching application on iPhone 7.
[   +2 ms] "flutter run" took 19,371ms.

#0      throwToolExit (package:flutter_tools/src/base/common.dart:28:3)
#1      RunCommand.runCommand (package:flutter_tools/src/commands/run.dart:485:7)
<asynchronous suspension>
#2      FlutterCommand.verifyThenRunCommand (package:flutter_tools/src/runner/flutter_command.dart:527:18)
#3      _asyncThenWrapperHelper.<anonymous closure> (dart:async-patch/async_patch.dart:71:64)
#4      _rootRunUnary (dart:async/zone.dart:1132:38)
#5      _CustomZone.runUnary (dart:async/zone.dart:1029:19)
#6      _FutureListener.handleValue (dart:async/future_impl.dart:137:18)
#7      Future._propagateToListeners.handleValueCallback (dart:async/future_impl.dart:678:45)
#8      Future._propagateToListeners (dart:async/future_impl.dart:707:32)
#9      Future._completeWithValue (dart:async/future_impl.dart:522:5)
#10     _AsyncAwaitCompleter.complete (dart:async-patch/async_patch.dart:30:15)
#11     _completeOnAsyncReturn (dart:async-patch/async_patch.dart:288:13)
#12     RunCommand.usageValues (package:flutter_tools/src/commands/run.dart)
#13     _asyncThenWrapperHelper.<anonymous closure> (dart:async-patch/async_patch.dart:71:64)
#14     _rootRunUnary (dart:async/zone.dart:1132:38)
#15     _CustomZone.runUnary (dart:async/zone.dart:1029:19)
#16     _FutureListener.handleValue (dart:async/future_impl.dart:137:18)
#17     Future._propagateToListeners.handleValueCallback (dart:async/future_impl.dart:678:45)
#18     Future._propagateToListeners (dart:async/future_impl.dart:707:32)
#19     Future._completeWithValue (dart:async/future_impl.dart:522:5)
#20     _AsyncAwaitCompleter.complete (dart:async-patch/async_patch.dart:30:15)
#21     _completeOnAsyncReturn (dart:async-patch/async_patch.dart:288:13)
#22     IosProject.isSwift (package:flutter_tools/src/project.dart)
#23     _asyncThenWrapperHelper.<anonymous closure> (dart:async-patch/async_patch.dart:71:64)
#24     _rootRunUnary (dart:async/zone.dart:1132:38)
#25     _CustomZone.runUnary (dart:async/zone.dart:1029:19)
#26     _FutureListener.handleValue (dart:async/future_impl.dart:137:18)
#27     Future._propagateToListeners.handleValueCallback (dart:async/future_impl.dart:678:45)
#28     Future._propagateToListeners (dart:async/future_impl.dart:707:32)
#29     Future._completeWithValue (dart:async/future_impl.dart:522:5)
#30     _AsyncAwaitCompleter.complete (dart:async-patch/async_patch.dart:30:15)
#31     _completeOnAsyncReturn (dart:async-patch/async_patch.dart:288:13)
#32     IosProject.buildSettings (package:flutter_tools/src/project.dart)
#33     _asyncThenWrapperHelper.<anonymous closure> (dart:async-patch/async_patch.dart:71:64)
#34     _rootRunUnary (dart:async/zone.dart:1132:38)
#35     _CustomZone.runUnary (dart:async/zone.dart:1029:19)
#36     _FutureListener.handleValue (dart:async/future_impl.dart:137:18)
#37     Future._propagateToListeners.handleValueCallback (dart:async/future_impl.dart:678:45)
#38     Future._propagateToListeners (dart:async/future_impl.dart:707:32)
#39     Future._completeWithValue (dart:async/future_impl.dart:522:5)
#40     _AsyncAwaitCompleter.complete (dart:async-patch/async_patch.dart:30:15)
#41     _completeOnAsyncReturn (dart:async-patch/async_patch.dart:288:13)
#42     XcodeProjectInterpreter.getBuildSettings (package:flutter_tools/src/ios/xcodeproj.dart)
#43     _asyncThenWrapperHelper.<anonymous closure> (dart:async-patch/async_patch.dart:71:64)
#44     _rootRunUnary (dart:async/zone.dart:1132:38)
#45     _CustomZone.runUnary (dart:async/zone.dart:1029:19)
#46     _FutureListener.handleValue (dart:async/future_impl.dart:137:18)
#47     Future._propagateToListeners.handleValueCallback (dart:async/future_impl.dart:678:45)
#48     Future._propagateToListeners (dart:async/future_impl.dart:707:32)
#49     Future._completeWithValue (dart:async/future_impl.dart:522:5)
#50     _AsyncAwaitCompleter.complete (dart:async-patch/async_patch.dart:30:15)
#51     _completeOnAsyncReturn (dart:async-patch/async_patch.dart:288:13)
#52     _DefaultProcessUtils.run (package:flutter_tools/src/base/process.dart)
#53     _asyncThenWrapperHelper.<anonymous closure> (dart:async-patch/async_patch.dart:71:64)
#54     _rootRunUnary (dart:async/zone.dart:1132:38)
#55     _CustomZone.runUnary (dart:async/zone.dart:1029:19)
#56     _FutureListener.handleValue (dart:async/future_impl.dart:137:18)
#57     Future._propagateToListeners.handleValueCallback (dart:async/future_impl.dart:678:45)
#58     Future._propagateToListeners (dart:async/future_impl.dart:707:32)
#59     Future._completeWithValue (dart:async/future_impl.dart:522:5)
#60     Future.wait.<anonymous closure> (dart:async/future.dart:400:22)
#61     _rootRunUnary (dart:async/zone.dart:1132:38)
#62     _CustomZone.runUnary (dart:async/zone.dart:1029:19)
#63     _FutureListener.handleValue (dart:async/future_impl.dart:137:18)
#64     Future._propagateToListeners.handleValueCallback (dart:async/future_impl.dart:678:45)
#65     Future._propagateToListeners (dart:async/future_impl.dart:707:32)
#66     Future._complete (dart:async/future_impl.dart:512:7)
#67     _BufferingStreamSubscription.asFuture.<anonymous closure> (dart:async/stream_impl.dart:204:14)
#68     _rootRun (dart:async/zone.dart:1120:38)
#69     _CustomZone.run (dart:async/zone.dart:1021:19)
#70     _CustomZone.runGuarded (dart:async/zone.dart:923:7)
#71     _BufferingStreamSubscription._sendDone.sendDone (dart:async/stream_impl.dart:389:13)
#72     _BufferingStreamSubscription._sendDone (dart:async/stream_impl.dart:399:15)
#73     _BufferingStreamSubscription._close (dart:async/stream_impl.dart:283:7)
#74     _SinkTransformerStreamSubscription._close (dart:async/stream_transformers.dart:96:11)
#75     _EventSinkWrapper.close (dart:async/stream_transformers.dart:23:11)
#76     _StringAdapterSink.close (dart:convert/string_conversion.dart:249:11)
#77     _Utf8ConversionSink.close (dart:convert/string_conversion.dart:300:20)
#78     _ConverterStreamEventSink.close (dart:convert/chunked_conversion.dart:80:18)
#79     _SinkTransformerStreamSubscription._handleDone (dart:async/stream_transformers.dart:141:24)
#80     _rootRun (dart:async/zone.dart:1120:38)
#81     _CustomZone.run (dart:async/zone.dart:1021:19)
#82     _CustomZone.runGuarded (dart:async/zone.dart:923:7)
#83     _BufferingStreamSubscription._sendDone.sendDone (dart:async/stream_impl.dart:389:13)
#84     _BufferingStreamSubscription._sendDone (dart:async/stream_impl.dart:399:15)
#85     _BufferingStreamSubscription._close (dart:async/stream_impl.dart:283:7)
#86     _SyncStreamControllerDispatch._sendDone (dart:async/stream_controller.dart:772:19)
#87     _StreamController._closeUnchecked (dart:async/stream_controller.dart:629:7)
#88     _StreamController.close (dart:async/stream_controller.dart:622:5)
#89     _Socket._onData (dart:io-patch/socket_patch.dart:1836:21)
#90     _rootRunUnary (dart:async/zone.dart:1136:13)
#91     _CustomZone.runUnary (dart:async/zone.dart:1029:19)
#92     _CustomZone.runUnaryGuarded (dart:async/zone.dart:931:7)
#93     _BufferingStreamSubscription._sendData (dart:async/stream_impl.dart:336:11)
#94     _BufferingStreamSubscription._add (dart:async/stream_impl.dart:263:7)
#95     _SyncStreamControllerDispatch._sendData (dart:async/stream_controller.dart:764:19)
#96     _StreamController._add (dart:async/stream_controller.dart:640:7)
#97     _StreamController.add (dart:async/stream_controller.dart:586:5)
#98     new _RawSocket.<anonymous closure> (dart:io-patch/socket_patch.dart:1384:35)
#99     _NativeSocket.issueReadEvent.issue (dart:io-patch/socket_patch.dart:890:18)
#100    _microtaskLoop (dart:async/schedule_microtask.dart:41:21)
#101    _startMicrotaskLoop (dart:async/schedule_microtask.dart:50:5)
#102    _runPendingImmediateCallback (dart:isolate-patch/isolate_patch.dart:116:13)
#103    _RawReceivePortImpl._handleMessage (dart:isolate-patch/isolate_patch.dart:173:5)

Analyzing firebase_compile_test...
No issues found! (ran in 2.9s)

[✓] Flutter (Channel dev, v1.10.6, on Mac OS X 10.14.6 18G95, locale en-GB)
    • Flutter version 1.10.6 at /Users/earyzhe/SDKs/flutter
    • Framework revision cc3ca9a916 (6 days ago), 2019-09-25 10:57:58 -0400
    • Engine revision 63949eb0fd
    • Dart version 2.6.0 (build 2.6.0-dev.0.0 69b5681546)

[✓] Android toolchain - develop for Android devices (Android SDK version 28.0.3)
    • Android SDK at /Users/earyzhe/Library/Android/sdk
    • Android NDK location not configured (optional; useful for native profiling support)
    • Platform android-28, build-tools 28.0.3
    • Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_202-release-1483-b49-5587405)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 11.0)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 11.0, Build version 11A420a
    • CocoaPods version 1.7.5

[✓] Android Studio (version 3.5)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin version 39.0.3
    • Dart plugin version 191.8423
    • Java version OpenJDK Runtime Environment (build 1.8.0_202-release-1483-b49-5587405)

[✓] IntelliJ IDEA Community Edition (version 2018.3.4)
    • IntelliJ at /Applications/IntelliJ IDEA CE.app
    • Flutter plugin version 33.2.2
    • Dart plugin version 183.5901

[✓] VS Code (version 1.38.1)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.4.1

[✓] Connected device (4 available)
    • Android SDK built for x86 • emulator-5554                            • android-x86 • Android 9 (API 28) (emulator)
    • Andrew's iPhone           • 6aa0c9719a85c174869a09656237b42f23701a91 • ios         • iOS 13.1.1
    • iPhone 7                  • 2B38F1CA-C1F4-423B-9DEA-1D56CC3EA484     • ios         • com.apple.CoreSimulator.SimRuntime.iOS-11-1 (simulator)
    • iPhone 11 Pro Max         • F7FDFDAF-B8D3-478B-AF97-927C3237EB43     • ios         • com.apple.CoreSimulator.SimRuntime.iOS-13-0 (simulator)

• No issues found!

Hi,
sorry to hear that. Could you please give it a try on the beta channel? There is the release candidate for the next stable hotfix. Alternative you could gife the master channel a try.

I tried all the channels.
I managed to fix the problem by deleting "strong" from

"@property(strong, nonatomic) dispatch_queue_t callbackQueue"

and a few other places in the plugins where "strong" was written.
Very messy though and only a tempory solution.
And if I clean my pods and get them again it will come back.

I tried all the channels
I got it working by deleting "strong" from

@property(strong, nonatomic) dispatch_queue_t callbackQueue

and a few other places in the iOS plugins
Though that's not ok in the long term.
If I delete my pod files and  get them again the problem will come back

This actually carries on like this for another 100 lines or so, basically repeating a similar thing.

Those are all warnings, is there a build error buried in those 100 lines that were excluded?

I managed to fix the problem by deleting "strong" from
"@Property(strong, nonatomic) dispatch_queue_t callbackQueue"
and a few other places in the plugins where "strong" was written.
Very messy though and only a tempory solution.
And if I clean my pods and get them again it will come back.

strong is the default in ARC, so removing it shouldn't do anything.

@jmagman

Those are all warnings, is there a build error buried in those 100 lines that were excluded?

Yeah in the logs below. That's the output of "flutter run -v"

strong is the default in ARC, so removing it shouldn't do anything.

Ok. It definitely did do something though. The app is now working and It was not before. In fact, I have to keep doing it because the pod files keep refreshing.

This means the app will not compile.
I delete "strong" and it works.
Everytime

@earyzhe
This issue has been moved to https://github.com/FirebaseExtended/flutterfire/issues/1074. Any further collaboration will be done there.


Refactoring of Renovate configuration

Renovation does not work properly:

Does not combine updates of related dependencies
Does not link electrons and releases
The car network does not work

You need to investigate the causes of these problems, fix them, and simplify configuration.

Resolve 012517f5544b01dee8557f8a0820f597f43344ee

Resolve 012517f5544b01dee8557f8a0820f597f43344ee


API for setting dynamic package data for the UserAgent header per HttpMessage

Summary of changes

Introduces the TelemetryPackageInfo type to encapsulate the package information used for the UserAgent header value.
Introduces a satict method called SetTelemetryPackage on a new static type called HttpMessageOptions to allow setting only the package name and package version portion of the standard UserAgent header value.

Implementation notes

Added a new private Dictionary<Type, object> field on HttpMessage for storing internal message properties and corresponding internal methods to interact with it. This replaces the previous Dictionary<Type, object> field while maintaining existing functionality.
Added conditional logic to TelemetryPolicy to consider the value of an internal TelemetryPackageInfo set on the HttpMessage when adding the UserAgent header value.
These changes make no changes to the behavior of IsTelemetryEnabled. Setting this to false in ClientOptions will result in no UserAgent header value being added to the request, just like before.
Example usage for a sub-client author:

public BlobServicesRestOperations(ClientDiagnostics clientDiagnostics, HttpPipeline pipeline, string applicationId, Uri endpoint = null, string apiVersion = default)
{
    <...>
    _packageInfo = TelemetryPackageInfo.FromType<BlobServicesRestOperations>(applicationId);
}

internal HttpMessage CreateListRequest(string subscriptionId, string resourceGroupName, string accountName)
{
    var message = _pipeline.CreateMessage();
    <...>
    HttpMessageOptions.SetTelemetryPackageInfo(message, _packageInfo);
    return message;
}

Performance impact
Note: Ignore absolute values, as the benchmarks intentionally are doing extra work to keep per-run data consistent.
How to interpret this data:

ExistingPolicy is the current unchanged behavior for how TelemetryPolicy adds the UserAgent header
AddDynamicHeader_NotSet is with the new policy logic in the case where no custom value is set (only the dictionary lookup)
AddDynamicHeader is the case where the dictionary lookup find a value and adds it to the header rather than the default value

Method
Mean
Error
StdDev
Ratio
RatioSD
Gen 0
Allocated

AddDynamicHeader
754.3 ns
11.92 ns
10.57 ns
0.94
0.02
0.0725
608 B

AddDynamicHeader_NotSet
773.9 ns
8.63 ns
8.07 ns
0.96
0.01
0.0725
608 B

ExistingPolicy
803.6 ns
6.58 ns
5.83 ns
1.00
0.00
0.0849
712 B

closes #26999

API changes have been detected in Azure.Core. You can review API changes here
API changes
+     public class TelemetryPackageInfo {
+         public string UserAgentValue { get; }
+         public static TelemetryPackageInfo Create<T>(string? applicationId = null);
+     }
+     public static class HttpMessageExtensions {
+         public static void SetTelemetryPackageInfo(this HttpMessage message, TelemetryPackageInfo packageInfo);
+     }

API changes have been detected in Azure.Core. You can review API changes here
API changes
+     public static class HttpMessageOptions {
+         public static void SetTelemetryPackage(HttpMessage message, TelemetryPackageInfo packageInfo);
+     }
+     }
+     public class TelemetryPackageInfo {
+         public string UserAgentValue { get; }
+         public static TelemetryPackageInfo FromType<T>(string? applicationId = null);

API changes have been detected in Azure.Core. You can review API changes here
API changes
+     public class UserAgentString {
+         public UserAgentString(Assembly assembly, string? applicationId = null);
+         public static UserAgentString FromType<T>(string? applicationId = null);
+         public override string ToString();
+     }
+     public static class HttpMessageExtensions {
+         public static void SetUserAgentString(this HttpMessage message, UserAgentString userAgentString);
+     }

API changes have been detected in Azure.Core. You can review API changes here
API changes
+     public class UserAgentValue {
+         public UserAgentValue(Type type, string? applicationId = null);
+         public static UserAgentValue FromType<T>(string? applicationId = null);
+         public override string ToString();
+     }
+     public static class HttpMessageExtensions {
+         public static void SetUserAgentString(this HttpMessage message, UserAgentValue userAgentValue);
+     }

API changes have been detected in Azure.Core. You can review API changes here
API changes
+     public class UserAgentValue {
+         public UserAgentValue(Type type, string? applicationId = null);
+         public static UserAgentValue FromType<T>(string? applicationId = null);
+         public override string ToString();
+     }
+     public static class HttpMessageExtensions {
+         public static void SetUserAgentString(this HttpMessage message, UserAgentValue userAgentValue);
+     }


When AbstractControllerTestCase::assertResponseStatusCode() fails it is not counted as an assertion by PHPUnit

This issue has been moved from the zendframework repository as part of the bug migration program as outlined here - http://framework.zend.com/blog/2016-04-11-issue-closures.html

Original Issue: https://api.github.com/repos/zendframework/zendframework/issues/7556
User: @sebastianbergmann
Created On: 2015-05-29T11:41:12Z
Updated At: 2015-11-06T21:55:09Z
Body
AbstractControllerTestCase::assertResponseStatusCode() is not counted as an assertion in the failure case. This is due to the fact that an PHPUnit_Framework_ExpectationFailedException is thrown when the actual and expected response status code are not equal:
public function assertResponseStatusCode($code)
{
    if ($this->useConsoleRequest) {
        if (!in_array($code, array(0, 1))) {
            throw new PHPUnit_Framework_ExpectationFailedException(
                'Console status code assert value must be O (valid) or 1 (error)'
            );
        }
    }
    $match = $this->getResponseStatusCode();
    if ($code != $match) {
        throw new PHPUnit_Framework_ExpectationFailedException(
            sprintf('Failed asserting response code "%s", actual status code is "%s"', $code, $match)
        );
    }
    $this->assertEquals($code, $match);
}

Since the comparison of actual and expected response status code is not performed using assertEquals() or assertThat(), for instance, the assertion counter is not incremented.
The first place in the method's code where a PHPUnit_Framework_ExpectationFailedException is thrown could be refactored as
$this->assertThat(
    $code,
    $this->logicalOr(
        $this->equalTo(0),
        $this->equalTo(1)
    ),
    'Console status code assert value must be O (valid) or 1 (error)'
);

It is not as easy as this, unfortunately, for the second place in the code where a PHPUnit_Framework_ExpectationFailedException is thrown:
if ($code != $match) {
    throw new PHPUnit_Framework_ExpectationFailedException(
        sprintf('Failed asserting response code "%s", actual status code is "%s"', $code, $match)
    );
}
$this->assertEquals($code, $match);

When the actual and expected response status codes are not equal then a custom message is generated and used with the manually thrown PHPUnit_Framework_ExpectationFailedException. This, again, circumvents the assertion counter.
When the actual and expected response status codes are equal then assertEquals() is used to verify the match again. This ensures that the assertion is counted in the success case.
The assertion methods of AbstractControllerTestCase should be refactored to follow the best practice of implementing custom assertions for PHPUnit. Simply implement a constraint object (by extending PHPUnit_Framework_Constraint) for each assertion. Then refactor the assertion to use the constraint object by passing it to assertThat().

This repository has been closed and moved to laminas/laminas-test; a new issue has been opened at https://github.com/laminas/laminas-test/issues/6.


DOC: note additional use case for normalize_token.register

Only changes prose in docs
If any of your classes parents are already in registered with the
dispatcher that registration will be hit before the object
implementation (which is what calls __dask_tokenize__).  Thus to
over-ride the tokenize function of any class which is already
registered, you must also register the sub-class.

This looks good to me.  Thanks @tacaswell for the doc fix.
I'm curious, what were you doing when you ran into this?

https://github.com/bluesky/databroker/pull/483 if you want to see the gory details.
The short version is we are making intake catalogs which we init by passing in some possibly large and deep dictionaries.   In __new__  of a mix-in [1] intake calls dask.base.tokenize on args/kwargs passed to  __init__.  This was costing us 100-200ms / per catalog which starts to add up when we have a few hundred of these.
We are trivially sub-classing dict and registering it to get a a custom tokenize method (we know what keys are the unique identifiers) which gets the init times down to ~30ms which is good enough for now.
[1] https://github.com/intake/intake/blob/34dd38089ccb805759508659b5e8475034df2f0c/intake/utils.py#L79-L87

Thanks @tacaswell, merging.


what is "global_mean_surface_temp" in tutorial-1 going deeper refer to?

in tutorial 1 it says:
https://github.com/mikofski/PVSC48-Python-Tutorial/blob/f73c5cbcbba320e45f2d9ec4df74ecd6ee4f32e9/Tutorial 0 - Overview.ipynb#L230
what notebook is this referring to? I checked in pvlib, and I can't find this notebook. Was it one of the pvsc48 tutorial notebooks that got renamed? Am I just not seeing it? Can we make a link?

Is it this? http://gallery.pangeo.io/repos/pangeo-gallery/cmip6/global_mean_surface_temp.html

@shirubana or @kanderso-nrel know anything about this? I want to close and resolve all issues so we can start using the upstream repo. https://github.com/PVSC-Python-Tutorials/PVSC48-Python-Tutorial
thanks!

I don't know anything about global_mean_surface_temp.ipynb :(

@shirubana okay to change this? I think it was a placeholder maybe? you can blame the commit and see it was added 2020-11-25

fixed in https://github.com/PVSC-Python-Tutorials/PVSC48-Python-Tutorial/commit/ad7916ee50df53889644d613f88c8d2e1e4009c6


build: migrate jobs to small runners

Problem
Summary of changes
Checklist before requesting a review

[ ] I have performed a self-review of my code.
[ ] If it is a core feature, I have added thorough tests.
[ ] Do we need to implement analytics? if so did you add the relevant metrics to the dashboard?
[ ] If this PR requires public announcement, mark it with /release-notes label and add several sentences in this section.

Checklist before merging

[ ] Do not forget to reformat commit message to not include the above checklist

check-style-rust is 13min, 3min slower.
vm-compute-node-image is 4min, 2-3min increase from 90s.
compute-node-iamge is 16-19min instead of 16-17min.


Discriminator for VoterWeightRecord

Not certain this is correct. Any thoughts?

Ok, it now gets the discriminator from the spl_governance crate

Closing as stale.


SharpConfigDotNetStandard config error

SharpConfigDotNetStandard's setting is NetStandard2.0,is not netframework 2.0
can you support NetStandard version on the nuget?
thank you

Fixed with version 3.2.9.


MARC: resource types and communities in 980

:heart: Thank you for your contribution!
Close https://github.com/zenodo/ops/issues/408
Description

Please describe briefly your pull request.

In legacy Zenodo both resource types and communities were placed in 980, rather than in RDM where they are under 980 and 901, which is not a valid MARC field
Checklist
Ticks in all boxes and 🟢 on all GitHub actions status checks are required to merge:

[x] I'm aware of the code of conduct.
[ ] I've created logical separate commits and followed the commit message format.
[ ] I've added relevant test cases.
[ ] I've added relevant documentation.
[ ] I've marked translation strings (for relevant code).
[ ] I've followed the CSS/JS and React guidelines (for relevant code).
[ ] I've followed the web accessibility guidelines (for relevant code).
[ ] I've followed the user interface guidelines (for relevant code).
[ ] I've identified the copyright holder(s) and updated copyright headers for touched files (>15 lines contributions).
[x] I've NOT included third-party code (copy/pasted source code or new dependencies).

Third-party code
If you've added third-party code (copy/pasted or new dependencies), please reach out to an architect.
Reminder
By using GitHub, you have already agreed to the GitHub’s Terms of Service including that:

You license your contribution under the same terms as the current repository’s license.
You agree that you have the right to license your contribution under the current repository’s license.

Just missing to rebase to resolve merge conflicts


Support for verifying http requests are made

We can currently intercept http calls and return stubbed responses e.g.
intercept("http://host.com/some-api-endpoint", ["some response"])
To properly component test our UI we'd like to be able to verify that certain requests are made. For example "click save" then verify that a POST request was sent to the API with a certain payload.
This could potentially look like something along the lines of
var requestSent = intercepted("http://host.com/some-api-endpoint", {method: "POST"})
Which could return null/undefined if the request wasn't made, or some representation of the request + body if it was.
A user could then use their assertion library of choice to assert on what request was or wasn't sent.

You can attach a callback to intercept, so if you were to do something like this:
intercept("http://host.com/some-api-endpoint",r => console.log(r))

You should see the payload that was sent to http://host.com/some-endpoint. The r here would look like this (note: I use a different URL):
request: {
    url: 'http://example.com/register',
    method: 'POST',
    headers: {
      'User-Agent': '<snipped>',
      'Content-Type': 'multipart/form-data; boundary=----WebKitFormBoundaryRI93xiyCXdfRxPa7',
      Accept: '*/*'
    },
    postData: '------WebKitFormBoundaryRI93xiyCXdfRxPa7\r\n' +
      'Content-Disposition: form-data; name="email"\r\n' +
      '\r\n' +
<EMAIL_ADDRESS>+
      '------WebKitFormBoundaryRI93xiyCXdfRxPa7\r\n' +
      'Content-Disposition: form-data; name="password"\r\n' +
      '\r\n' +
      'garbage\r\n' +
      '------WebKitFormBoundaryRI93xiyCXdfRxPa7--\r\n',
    initialPriority: 'High',
    referrerPolicy: 'no-referrer-when-downgrade'
  },

You can attach a callback to intercept, so if you were to do something like this:
intercept("http://host.com/some-api-endpoint",r => console.log(r))

You should see the payload that was sent to http://host.com/some-endpoint. The r here would look like this (note: I use a different URL):
request: {
    url: 'http://example.com/register',
    method: 'POST',
    headers: {
      'User-Agent': '<snipped>',
      'Content-Type': 'multipart/form-data; boundary=----WebKitFormBoundaryRI93xiyCXdfRxPa7',
      Accept: '*/*'
    },
    postData: '------WebKitFormBoundaryRI93xiyCXdfRxPa7\r\n' +
      'Content-Disposition: form-data; name="email"\r\n' +
      '\r\n' +
<EMAIL_ADDRESS>+
      '------WebKitFormBoundaryRI93xiyCXdfRxPa7\r\n' +
      'Content-Disposition: form-data; name="password"\r\n' +
      '\r\n' +
      'garbage\r\n' +
      '------WebKitFormBoundaryRI93xiyCXdfRxPa7--\r\n',
    initialPriority: 'High',
    referrerPolicy: 'no-referrer-when-downgrade'
  },

I guess we could stick an assertion into the callback. It still wouldn't verify the request was actually made, but it would help with us verifying that if the request was made that it was made correctly.
I still think it'd be nice to have an intercepted method of some form. It could potentially hijack the existing interceptor framework thats in place under the hood e.g. create an interceptor that sticks the request in some store which is exposed via an intercepted (or better named) method

I still think it'd be nice to have an intercepted method of some form. It could potentially hijack the existing interceptor framework thats in place under the hood e.g. create an interceptor that sticks the request in some store which is exposed via an intercepted (or better named) method

Something, that could be a plugin?
It's better to keep mocking semantics out of Taiko in favour of stubbing for now.
Closing this issue in the core, but hoping someone can use the info here and implement a plugin to support this.


[Bug]: “Failed to resolve loader: ./builtin:swc-loader” when chaining builtin:swc-loader into expose-loader

System Info
  System:
    OS: Linux 6.11 cpe:/o:nixos:nixos:24.11 24.11 (Vicuna)
    CPU: (12) x64 Intel(R) Core(TM) i7-10710U CPU @ 1.10GHz
    Memory: 8.45 GB / 15.26 GB
    Container: Yes
    Shell: 5.2.37 - /run/current-system/sw/bin/bash
  Binaries:
    Node: 20.18.0 - ~/.nix-profile/bin/node
    Yarn: 1.22.19 - ~/.nix-profile/bin/yarn
    npm: 10.8.2 - ~/.nix-profile/bin/npm
    pnpm: 9.12.3 - ~/.nix-profile/bin/pnpm
    bun: 1.1.31 - ~/.nix-profile/bin/bun
  Browsers:
    Chromium: 130.0.6723.91
  npmPackages:
    @rspack/cli: ^1.1.1 => 1.1.1

Details
When trying to chain builtin:swc-loader into expose-loader, Rspack tries and fails to resolve ./builtin:swc-loader rather than builtin:swc-loader, resulting in an error like Failed to resolve loader: ./builtin:swc-loader in /tmp/test, error: RspackResolver(NotFound("./builtin:swc-loader")).
module.exports = {
  entry: "./foo.js",
  module: {
    rules: [
      {
        test: require.resolve("./foo.js"),
        loader: "expose-loader",
        options: { exposes: "foo" },
      },
      {
        test: /\.js$/,
        exclude: [/node_modules/],
        loader: "builtin:swc-loader",
      },
    ],
  },
};

Reproduce link
https://gist.github.com/andersk/cc79db11483b345f52c13203d2515496
Reproduce Steps
$ npm i
$ npx rspack
ERROR in ./foo-exposed.js 1:41-75
  × Failed to resolve loader: ./builtin:swc-loader in /tmp/test, error: RspackResolver(NotFound("./builtin:swc-loader"))

Rspack compiled with 1 error in 27 ms

The issue is inside expose-loader.
contextify used in expose-loader does not convert the request correctly. As you can see, the value produced by loaderContext.utils.contextify is not returned. https://github.com/webpack-contrib/expose-loader/blob/fcd04070854892a394395bac18d74d39ece6cda4/src/utils.js#L102


Bug/weighted sampling reader

petastorm.pytorch.DataLoader expects the field is_batched_reader in the reader. WeightedSamplingReader does not have this field. It seems to be replaced by the property: batched_output.

petastorm.pytorch.DataLoader expects the functions stop() and join() from the reader. WeightedSamplingReader does not have these functions. This PR adds these functions.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.Robert Gruener seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

@gueguenster , can you please sign the CLA?

@gueguenster : seems that the problem is not CLA but that we have Robert appears as author of one of the unrelated comments in the commit stack. Can you please rebase and remove Robert's commits + push-force?

@selitvin , thanks I look in fixing that.

I had difficulty removing the commits.


Modal gets clipped if put inside an element with drop shadow

Describe the bug
I put a Modal inside a div with drop-shadow-* tailwind class. This is what happens

If I remove drop-shadow-* it works just fine.
Reproduction
REPL
Flowbite version and System Info
System:
    OS: Linux 6.0 Pop!_OS 22.04 LTS
    CPU: (12) x64 AMD Ryzen 5 PRO 4650G with Radeon Graphics
    Memory: 17.53 GB / 27.30 GB
    Container: Yes
    Shell: 5.8.1 - /usr/bin/zsh
  Binaries:
    Node: 16.16.0 - ~/.nvm/versions/node/v16.16.0/bin/node
    npm: 8.11.0 - ~/.nvm/versions/node/v16.16.0/bin/npm
  Browsers:
    Brave Browser: <IP_ADDRESS>
  npmPackages:
    flowbite-svelte: ^0.27.11 => 0.27.11
    svelte: ^3.52.0 => 3.52.0
    vite: ^3.1.8 => 3.1.8

This is an interesting case. It seems there's a strange behaviour (incompatibility) between class fixed and drop-shadow.
I've extracted that to minimal example, but it should be asked at Tailwindcss.
REPL
(Note! You need to touch the left pane for it to render properly)

@jjagielka I've searched in their repo, here's the solution.
In short: replace drop-shadow with shadow class.
So I think this issue can be closed then?

Yes. That's exactly the issue. The child position is affected and as we use overflow-hidden in modal, it causes clipping.
Yes, we can close the issue. It has to be treated as a known limitation.
Thanks for finding out the solution at Tailwindcss. :)

Okay, thanks for giving me a direction beforehand :) closing this.


Is it possible to add a timeout if download is taking longer than expected?

I am downloading a file as part of running my tests on (unfortunately) a very unreliable & slow internet connection. When such internet problem occurs, if my test is in the stage of download a particular file, it just gets stuck there indefinitely.
Is there a way an optional timeout value (in seconds) can be provided to the download command, that will abort the download if specified?
Thanks.

Very good idea! 👍
I implemented a new property called timeout which specifies the maximum number of milliseconds to wait until a connection is established or until the server returns data. I published the feature as 3.3.0-SNAPSHOT. Please let me know if this is what you expected so I can publish a new release. Thanks!

Thanks @michel-kraemer . However, I was not able to get to this 3.3.0-SNAPSHOT.
Looking at the changes, it seems that this timeout configuration will take care of cases where it takes a long time to establish the connection, or for data to start getting downloaded, right?
If yes, I was actually thinking of a timeout value for the overall download process - say - download (including connection time / etc.) for my specified set of file(s) should complete within 60 sec, else, I should see a Timeout error.

Thanks for the clarification. I understand your use case, but I'd rather not add such a very specific functionality to gradle-download-task which is (more or less) a general-purpose plugin.


Not working

installed it on VS under Ubuntu.
When triggering the PrintCode command nothing happens. No message in the output window, no error in the developer tools

Thank you for reporting the problem.
In linux, xdg.open is set to start temporary files.
            case "linux":
                child_process.exec("xdg.open " + tempFile);
                break;

However, xdg-open seems to be more appropriate.
Is it possible to open hogehoge.html with xdg-open hogehoge.html from the command line?
I currently do not have a Linux environment with a GUI, so I hope you have a try and give me a reply.

Thanks for your quick answer.
Tried opening an html file with "xdg-open filename.html" from the command line and it worked fine, opennig a new tag in my already opened browser.
Could you release a quick fix?

Thank you for confirmation! We will update it today!
("New tag" is a typo on "new tab", is not it?)

Yes, I meant "tag".
I just tried your latest version and it works perfectly
It deserves a 5 star review :+1:
Thank you for the help and quick reaction

Thank you so much!!!!!


Error when trying to rename a directory inside S3

This is the current file tree:
test/
├── a/
│   └── image.jpg

The goal is to rename the directory from a/ to b/:

When I submit the request, I get an error: The name is required:

I then try to refresh the filemanager, I can see that there's a new folder b/, however it's empty:

The fill tree looks like this:
test/
├── a/
│   └── image.jpg
└─── b/

Managed to fix it:
https://github.com/simonasposka/Nova-Filemanager/tree/fix/s3-folder-rename


Stop sequence validation error for gpt-4-vision-preview

Calls to openai:chat:gpt-4-vision-preview fail due to a validation error with the stop sequence parameter.
Example config:
prompts:
  - "Write a tweet about {{topic}}"
  - "Write a very concise, funny tweet about {{topic}}"

providers: [openai:chat:gpt-4-vision-preview]

tests:
  - vars:
      topic: bananas

Result:

I fixed this in my config by just setting the stop sequence value like so:
providers:
  - id: openai:chat:gpt-4-vision-preview
    config:
      stop:
        - <|endoftext|>

Thanks @cameronk.  Just pushed a fix that will be included in the next release.  It looks like gpt-4-vision-preview handles undefined stop differently from other chat models.

Fix is in 0.34.0


December 2020 newsletter draft

Sorry for the late start on this.
I populated the PR updates for each project. Please review and edit if needed. I will specifically need help from:

@gklimowicz (Classic and LLVM Flang updates)
@certik (LFortran updates)
@LKedward (contributors data update)

As usual, please add your name to the authors list if you add, edit, or review content.

@certik @gklimowicz do you think you can provide compiler updates by the end of the week? Sorry again for the late notice.

Yes, but the probability increases as we approach Friday.

I'll merge the PR on Monday, 12/07, any additions are welcome until then.

#build_preview

Apologies, it looks like the build preview action is broken due to a previous deprecation in github actions.

Thank you all! I will go ahead and merge.
The build preview CI failed because set-env is not allowed anymore. I will open a separate issue for that, but for now I will just go ahead with this as the newsletter seems fine from looking at the md file.


openFolderPickerOnceGranted

i use new SimpleStorageHelper(this).requestStorageAccess(SimpleStorageHelper.REQUEST_CODE_STORAGE_ACCESS,false);
but the folder picker opens afterwards anyway

SimpleStorageHelper must not be used like that. Keep it as a field:
private lateinit var storageHelper: SimpleStorageHelper

override fun onActivityResult(requestCode: Int, resultCode: Int, data: Intent?) {
    super.onActivityResult(requestCode, resultCode, data)
    storageHelper.storage.onActivityResult(requestCode, resultCode, data)
}

Follow this instruction: https://github.com/anggrayudi/SimpleStorage#simplestoragehelper

Snapdrop app seems to work without requesting permissions 🤷🤷 so I'll close this


Add PhysicalSize and LogicalSize

Objective
As Alice mentioned on Discord, "I personally want to newtype logical vs physical resolution so we stop getting wrecked by scale factor bugs everywhere."
Solution
Added two new types to replace UVec2 and Vec2 in certain places: LogicalSize and PhysicalSize.
Migration Guide

Calls to WindowResolution::new() now take in a LogicalSize instead of two f32.
Viewport physical_size is now a PhysicalSize instead of UVec2.
RenderTargetInfo physical_size and old_viewport_size are now a PhysicalSize instead of UVec2.
LayoutContext physical_size is now a PhysicalSize instead of Vec2.

Is there a reason why we still store physical_width and physical_height in WindowResolution and not just something like: physical_size: PhysicalSize?

Feel a bit ambivalent about this. It doesn't seem like we gain very much, the code doesn't feel any clearer or less confusing to me after these changes.
I've got the flu though and I'm not in a great state today and I'll think about it again when I'm more coherent.

@ickshonpe, if you're feeling better now, I'll defer to you for the final judgement call here. What's your opinion now that this PR is polished up?

Adding Controversial for now: if we can agree that this is a clear improvement happy to remove the label again. For now, I'm not confident enough that it's an improvement to merge it.

Closing this out, I'm no longer convinced this is a good idea.


feat/improve file data batch content

Description
Convert the FileData class to be a pydantic model to have better field validation on it. Also create inherited FileData classes for batch support and inter-index-downloader communication.

My next comment, again not truly a code level conversation yet, but closer: How do you feel about collapsing the case of single and batch into a world where everything is a batch, and it just so happens that sometimes that batch is of size 1?

My next comment, again not truly a code level conversation yet, but closer: How do you feel about collapsing the case of single and batch into a world where everything is a batch, and it just so happens that sometimes that batch is of size 1?

I would be fine with this; however, I think you're proposing a breaking change if we went that route.
I was originally thinking that the indexer should emit records where NOTHING was a batch and everything be a single Record. HOWEVER, that would mean rewriting a lot of the connectors.


[RAC-6176] refactor WsmanTool and wsman-related jobs

Background
As the RACADM replacement work squad, we need to work on common wsman-tools functionality, so that everyone can focus on their own tasks.
Details

create a base job for wsman-related jobs, which handles both syncRequest and asyncRequest
refactor JobUtils.WsmanTool
refine the code for wsman-related jobs

Reviewers
@RackHD/corecommitters @nortonluo @yaolingling

BUILD on-tasks #255 : FAILURE

BUILD on-tasks #256 : FAILURE

BUILD on-tasks #257 : FAILURE

BUILD on-tasks #258 : FAILURE

test this please.

BUILD on-tasks #259 : FAILURE

BUILD on-tasks #260 : FAILURE

BUILD Archiving » tian » PR_GATE #3 : FAILURE

test this please

BUILD on-tasks #263 : FAILURE

test this please

BUILD Archiving » tian » PR_GATE #17 : FAILURE

test this please

Seems there is many tab instead of space


Repo Maintenance

Description
Change "FSM" directory to "SaaS"
Contribution Check List

[x] All tests pass.
[x] New functionality includes testing.
[x] New functionality has been documented in the README if applicable
[x] New functionality has been documented in CHANGELOG.MD

          1 Error

:no_entry_sign:

  Generated by :no_entry_sign: Danger


feat: support for additional types

This PR is to support additional types, other than the built-in ones. The additional types are configurable, but should still follow certain requirements. Currently being set:

all lower case
combination of alphanumeric and underscore
with the length range [3-16]

Pull Request Test Coverage Report for Build<PHONE_NUMBER>2
Details

26 of 26 (100.0%)  changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.04%) to 85.175%

Totals

Change from base Build<PHONE_NUMBER>6:
0.04%

Covered Lines:
6366

Relevant Lines:
7474

💛  - Coveralls


tour: link to more resources throughout all content

Context: https://tour.golang.org/concurrency/5
It would be very useful to have a "Would you like to know more?" link in the description to the documentation, in this case https://golang.org/ref/spec#Select_statements

@campoy?

This might end up making us add links to the specs on every single page of the tour.
We already point to the specs at the end of the tour (http://tour.golang.org/concurrency/11)
What do you think, @adg?

I think it doesn't hurt to add more links. Probably we should be adding more links to definitions and resources throughout the tour.
I'll rename this issue to track the general issue of adding such links.

Here's an attempt at policy:

When a language concept is introduced, link to the corresponding section of the spec.
When a standard library package or name is mentioned, link to the relevant godoc.

Some links to Effective Go would be also nice. Learned many things in Effective Go the hard way.


use valueForKeyPath in sync_toOneRelationship

Hello,
Is it a good approach to a good approach to use valueForKeyPath in sync_toOneRelationship so we put this line :
 guard let managedObjectContext = managedObjectContext, filteredObjectDictionary = (dictionary as NSDictionary).valueForKeyPath(relationshipName) as? [String : AnyObject], destinationEntity = relationship.destinationEntity, entityName = destinationEntity.name, entity = NSEntityDescription.entityForName(entityName, inManagedObjectContext: managedObjectContext) else { return }
Instead of this line :
guard let managedObjectContext = managedObjectContext, filteredObjectDictionary = dictionary[relationshipName] as? [String : AnyObject], destinationEntity = relationship.destinationEntity, entityName = destinationEntity.name, entity = NSEntityDescription.entityForName(entityName, inManagedObjectContext: managedObjectContext) else { return }
I only replaced dictionary[relationshipName] with (dictionary as NSDictionary).valueForKeyPath(relationshipName)
Thank you in advance for your answer

Hi @ali59a,
It has the same effect but dictionary[relationshipName] seems a more readable approach than (dictionary as NSDictionary).valueForKeyPath(relationshipName).
Any special reason on why you would prefer this?
Best,


Let 545 fe user can accept invitation to join account

Description
Following an email link, the user should be able to accept or reject the invitation to join an account. If the user is not signed in, they must sign up first and after sign up, be taken back to the account invitation screen.
Figma: HeCo - Work in progress
It was included the API integration for the user invitation, so the PD or Investor user should be able to send a list of emails to invite other users to they account
Acceptance criteria
Added user will receive an email notifying him/her that she is invited to join the account - user will need to sign-up to the platform
Testing instructions

Send your email to invitations (You can use swagger - Invitation) or http://localhost:3000/en/dashboard/users.

If you already have an account on HeCo with this email, use<EMAIL_ADDRESS>to add as new email.
I already sent 1 email to each of you for the first test

Open the email and click on the link
Change the path to localhost:3000
Refresh the page and follow the flow

Tracking
LET-545

Logged out light users lose access to their user acc

In addition to my few comments, the 3 flows I described in my previous review are still not working:

Logged out light users lose access to their user account
This looks like a BE issue. The sign-in endpoint responds with an error if the invited user (light) tries to sign-in
Logged in light users are not redirected

Invitation opened with another account doesn't sign you out

@clementprdhomme

3/ Invitation opened with another account doesn't sign you out

FIxed


Init ServiceRetriever Class

Pull Request Checklist
ServiceRetriever class for interacting with Anserini REST API. Currently only supports retrieval from pre-built indexes and k=10 (REST API does not accept k as a parameter currently).
Class variables:

host
dataset name (dataset)
retrieval_mode (only DATASET is valid at the moment)
retrieval_method (e.g., BM25)

from_dataset_with_prebuilt_index() takes in:

request
dataset_name
retrieval_method
k  Anserini API currently does not support passing in k
host Defaults to localhost::8081

PR Type

[x] Feature

@sahel-sh linted + added error handling


Made installation text more clear on dependencies

Resolves #1471.
Pull Request Check List
This is just a reminder about the most common mistakes. Please make sure that you tick all appropriate boxes.  But please read our contribution guide at least once, it will save you unnecessary review cycles!

[ ] Added tests for changed code.
[x] Updated documentation for changed code.

Note: If your Pull Request introduces a new feature or changes the current behavior, it should be based
on the develop branch. If it's a bug fix or only a documentation update, it should be based on the master branch.
If you have any questions to any of the points above, just submit and ask!  This checklist is here to help you, not to deter you from contributing!

Thanks!


rename (sass|less)/roboto to (sass|less)/nunito & replace Nunito to nunito

At css/nunito/nunito-fontface.css fonts was at paths containing Nunito capitilzed.
But less and sass was using lower case nunito. So i decided to change all to lower case.

and newest version available from npm https://www.npmjs.com/package/nunito-fontface


Fix missing OS for iOS

:scroll: Description

:bulb: Motivation and Context
Fix https://github.com/getsentry/sentry-dart/issues/942
:green_heart: How did you test it?
:pencil: Checklist

[ ] I reviewed submitted code
[ ] I added tests to verify changes
[ ] I updated the docs if needed
[ ] All tests passing
[ ] No breaking changes

:crystal_ball: Next steps
https://github.com/getsentry/team-mobile/issues/11

Codecov Report

Merging #958 (5b5370e) into main (5a35e4a) will decrease coverage by 0.00%.
The diff coverage is n/a.

:exclamation: Current head 5b5370e differs from pull request most recent head 16c2e54. Consider uploading reports for the commit 16c2e54 to get more accurate results

@@            Coverage Diff             @@
##             main     #958      +/-   ##
==========================================
- Coverage   89.81%   89.81%   -0.01%
==========================================
  Files         104       95       -9
  Lines        3211     3043     -168
==========================================
- Hits         2884     2733     -151
+ Misses        327      310      -17

Impacted Files
Coverage Δ

dart/lib/src/sentry_client.dart
92.53% <0.00%> (ø)

dio/lib/src/sentry_dio_extension.dart

dio/lib/src/sentry_dio_client_adapter.dart

dio/lib/src/dio_event_processor.dart

logging/lib/src/extension.dart

dio/lib/src/sentry_transformer.dart

dio/lib/src/breadcrumb_client_adapter.dart

logging/lib/src/logging_integration.dart

dio/lib/src/tracing_client_adapter.dart

dio/lib/src/failed_request_interceptor.dart

... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a35e4a...16c2e54. Read the comment docs.


Break down the List type

Right now there is a single List type that can represent different things. It represents Python lists (potentially nested), but also numpy arrays (which don't always behave like list, for instance + doesn't concatenate, and truth value has a different meaning), and it's also the magic type for streaming and aggregating multiple connections (i.e. it is special to port depth).
This is an attempt to rework that. It introduces Array, which is the base class (basically replaces List), plus two subclasses, List (that now represents a Python list, a module declaring this port type can expect a proper Python list) and NumpyArray (for a numpy.ndarray).
This came up during my work on the interpreter and pandas.
It turned out to be complicated, because of all the code that checks for the List type (for depth magic). I'm also not sure whether List shouldn't completely be eliminated (though NumpyArray is definitely useful).

Would it not be better to only do the list magic on List, not Array,  so that it is not possible to accidentally loop a numpy array? Looping a list over a module, or aggregating connections, usually requires a Python list.
We could also get rid of List by converting it to a Variant of depth 1. The looping magic already treats them the same. In most cases it is better to use a typed list (type of depth 1) for a simple list of objects, or a numpy array for bigger data.

Would it not be better to only do the list magic on List, not Array

This is my intention, but Array ports have to accept what List ports accept, which is not the case right now.


Update direct-routing-whats-new.md

We need to replace the old Teams IP CIDR <IP_ADDRESS>/14 with the new one <IP_ADDRESS>/15.

@CarolynRowe
PR has been copyedited and is ready for final review, could you please check and merge? Thanks!


⚠ Bofrost.de has degraded performance

In 0faa0a7, Bofrost.de (https://www.bofrost.de) experienced degraded performance:

HTTP code: 200
Response time: 941 ms

Resolved: Bofrost.de performance has improved in 4217d6c after 16 minutes.


Dynamic UI Button Styles with Gradient Effects

Closes : #2006
Dynamic UI Button Styles with Gradient Effects
This repository showcases a set of dynamic UI button styles designed for a modern web application interface. The buttons feature vibrant gradient backgrounds, hover effects, and a clean layout to enhance user interaction.
Key Features

Gradient Backgrounds: Each button utilizes a linear gradient that transitions between shades of red and complementary colors for an eye-catching appearance.
Responsive Design: Buttons are styled for optimal display across different screen sizes, ensuring a consistent user experience.
Interactive Elements: Includes hover effects for better visual feedback and engagement.
Flexbox Layout: Navigation buttons are aligned and centered using CSS Flexbox for a sleek look.

Usage
Simply include the provided CSS styles in your project to apply the dynamic button styles. Modify the colors and sizes as needed to fit your design requirements.
Explore the demo and start enhancing your web application's UI today!
BEFORE

AFTER

@iamrahulmahato , resolved !!


Create exportAs aliasing for all Components/Directives to allow for template referencing

This issue is meant to track which @Components and @Directives include exportAsaliases:

[x] MatAutocomplete
[ ] MatButton
[ ] MatAnchor
[x] MatButtonToggleGroup
[ ] MatButtonToggle
[ ] MatCard
[x] MatChip
[x] MatChipList
[ ] MatDatepicker
[x] MatDatepickerInput
[ ] MatAccordion
[ ] MatExpansionPanel
[ ] MatFormField
[ ] MatGridList
[ ] MatGridTile
[ ] MatIcon
[ ] MatInput
[x] MatTextareaAutosize
[ ] MatList
[ ] MatListItem
[x] MatMenuItem
[x] MatMenu
[x] MatMenuTrigger
[x] MatSelect
[ ] MatPaginator
[ ] MatProgressBar
[ ] MatProgressSpinner
[ ] MatRadioGroup
[ ] MatRadioButton
[ ] MatHorizontalStepper
[ ] MatVerticalStepper
[ ] MatStep
[ ] MatTable
[ ] MatRow
[ ] MatHeaderRow
[x] MatTab
[ ] MatTabGroup
[ ] MatToolbar
[ ] MatToolbarRow
[x] MatTooltip

While we're at it, we should add it to the validate-decorators tslint rule to make sure that we don't forget about.


Proactively mask more potential user info

Similar to how I just added masking for all emails, this should mask all guids, ip addresses, and urls.
Open to ideas for more things to mask and/or your thoughts on making this more or less aggressive

Right, just error messages


Backport "Optimise SpaceEngine.signature" to 3.6.2

Backports #21791 to the 3.6.2 branch.
PR submitted by the release tooling.
[skip ci]

No regressions detected in the community build up to release-3.6.2-backport-21891.
Reference


Overriding child component classes

https://stackoverflow.com/questions/62529550/overriding-tailwind-css-classes-in-a-reusable-vuejs-component
With ref to above if I have a component as:
<template>
  <button
    :disabled="disabled"
    class="
      px-3
      py-1.5
      text-white text-sm
      bg-blue-500
      hover:bg-blue-600
      font-medium
      rounded
    "
    @click="onButtonClick"
  >
    <slot></slot>
  </button>
</template>

<script>
export default {
  name: 'PrimaryButton',
  props: {
    disabled: { type: Boolean, default: false, required: false },
  },
  methods: {
    onButtonClick() {
      this.$emit('click')
    },
  },
}
</script>

and if I try using it as below
<PrimaryButton class="bg-red-500" @click="onClick">
              Sign in
 </PrimaryButton>

There is no effect of bg-red-500 on the button.
Is there any easy way to do that?

There is no effect of bg-red-500 on the button.
Is there any easy way to do that?

Far from ideal but you could do a few things:

Use !bg-red-500 instead so it is more specific than the class on your component
Move the button color to a prop with a default value of bg-blue-500
Add bg-blue-500 conditionally only when there is no class that contains bg- (this kinda sucks because you could be trying to make the background clip or something but then you'd get no bg-color)
Use custom properties on your component. .bg-button could inherit the color from it's instance and fallback to blue when it is not defined (might require you to make changes to core's backgroundColor plugin

@hacknug Thank you for sharing your knowledge. Just wanted to know the best practice for above use case. Is there any standard approach to tackle such case?

@apgapg I'd say go with the first one I mentioned if you only have one button that needs to be different. Go with the second if there's multiple buttons on your codebase that need to be styled differently. The other suggestions would work but might not be the best implementations or the easiest to tackle if you don't have much experience writing custom plugins and such.

Thanks @hacknug for your words. Closing the issue


Chrome and Firefox not dragging elements (via feedback form)

Copied from feedback (East Carolina University)

This is within an educational environment. The cursor changes to a hand, but will not drag any elements within Chrome or Firefox. Please let me know if you need any more details.
Java 7 Update 10 x64
Java 7 Update 40
Chrome 29.0.1547.76 m & 28.0.1500.72 m (Enterprise)
Firefox Frontmotion ESR 17.0.7 x64

Closing due to age


Display 2 times for builds, time spent queueing and time spent running

There is an interesting situation right now, that if a deployment takes a long time to start (which can happen for numerous reasons, e.g. there is a queue of deployments ahead of the one you put through, and QoS is in place) the deployment times can jump around.
There are 3 times that are important for a deployment

created - the time the deployment was queued to start
started - the time the deployment actually started
finished - the time the deployment completed

The UI shows the difference between created and now when the deployment is not yet complete, and started and finished when complete. This can cause the deployment times to jump upon completion. This is confusing.
Perhaps it might be best to show on the deployment 2 times upon completion:

Time spent queueing
Time spent executing

Perhaps in some easy to understand way. For bulk deployments, time spent queueing is not that important, but for regular single deployments it is.

The UI shows the difference between created and now when the deployment is not yet complete, and started and finished when complete. This can cause the deployment times to jump upon completion. This is confusing.

It also shows the difference between started and now when the deployment has started. This is the point where the duration would reset to 0, not when it's completed.

Perhaps it might be best to show on the deployment 2 times upon completion

I disagree, IMHO; For a new deployment, a user might want to know two things 1) how long has a deployment been waiting 2) how long has a deployment been running. The current UI answers both these questions with the same duration column. You can think of the duration as tied to the status of the deployment instead of as an overall duration. For historical deployments, I don't care at all about how long they took to start, only how long it took to run. That way I can more accurately know if a deployment is taking longer than normal, or if the build performance improvements I made are working.
The "queue" time, as you call it, could be useful information in aggregate to glean cluster level resource management, but an individual developer won't be looking at that.

We could do user research to figure out if (1) is something users want at all. If the answer is no, we could not show a duration at all until a deploy starts. Or maybe we pull the "active" deployment off the top of the table into its own section that has all the timings.

part of a larger "Lagoon Metrics" concept that tracks and reports all build metrics properly


Adding RSS feed for Camper News

I love the links I find on Camper News, and while I like both FCC and my own Camper News Zipline, I'd love to have the links aggregated along with my other RSS feeds to get more control and avoid having to repeatedly visit FCC/my Zipline.
I tried looking for a way to integrate it into my own Zipline but it seems that this can only be done on the back-end.
To add an RSS feed to the site, I'd need to add a feed.xml.jade template that looks something like this
doctype xml
rss(version="2.0", xmlns:atom="http://www.w3.org/2005/Atom")
  channel
    title= title
    link= url
    description= description
    atom:link(href="#{ url }/feed.xml", rel="self", type="application/rss+xml")
    for post, slug in posts
      item
        title= post.title
        description <![CDATA[!{ partial(slug) }]]>
        pubDate= new Date(post.date)
        link #{ url }/news/#{ slug }
        guid(isPermaLink="true") #{ url }/news/#{ slug }

And then something like this in <head> of the page that advertises the feed. Can either be included in universal header or in a specific page. Since Camper News is just a part of FCC, I think just adding it to the stories page would suffice.
link(rel="alternate" type="application/rss+xml" title="{{ site.name }}" href="{{ site.url }}/feed.xml")

That's all I can figure out so far, I'd like some pointers in the right direction.
Thanks!

@prashcr LGTM. Form a PR and I'll merge it.

Anyone else want to give this a try?


Carryforward  not working

Describe the bug
We have a monorepo and some modules split by flags, and we use carryforward in order to merge the reports and not to override them, it was working well until 18/03/24, since that it started replacing the reports, we did not change any about codecov config
To Reproduce
All reports we upload replace others.
Expected behavior
We expect it works as before merging all reports
Screenshots
Main branch current

Branchs before

The commits wiew

Additional context
We are using the 0.5.0 uploader version

all those commit message unavailable indicate we are not being able to reach the provider. They use gitlab I assume?

Closing this one.
For future reference (if you happen to have a similar error and is reading this thread), this is the (likely) cause of carryforward not working:
Notice in the image the many "commit message unavailable" across the commits.
This indicates that Codecov failed to get the commit information from the git provider (in this case Gitlab). Commit information includes the message and the parents of the commit.
The parents info is necessary to carryforward reports because they come from parent to child. Because Codecov didn't have that info when creating reports for these new commits it didn't carried forward previous reports.


Add release badge to openebs/README.md

Add a release badge to README.md

Badge: https://img.shields.io/github/release/openebs/openebs/all.svg?style=flat-square
Link : https://github.com/openebs/openebs/releases

I can do that :)
Do you also want to use the flat style on the existing badges?


Connections use ubutnu host user not connection user

I start OmniDB with manage.py runserver, i created a new connection for my localhost postgresql. When I try a connection, OmniDB try to connect with my Ubuntu host user instead of user connection saved.

Hi wlorenzetti,
Could you show us the information you provided in the connection grid?

Hi wlorenzetti,
you probably created the connection without filling the column "Service" right? The database you are connecting to should be specified there.
We already fixed this bug, if no database is specified, postgres db will be used.

Thank you Rafael, it was service column!
All the best
Walter
Il 18/08/2017 14:11, Rafael Thofehrn Castro ha scritto:

Hi wlorenzetti,
you probably created the connection without filling the column
"Service" right? The database you are connecting to should be
specified there.
We already fixed this bug, if no database is specified, postgres db
will be used.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/OmniDB/OmniDB/issues/166#issuecomment-323337148,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAMAyW9VQTDgWdmhrltMuWR4JkfnvITHks5sZX9vgaJpZM4OzpkS.

--
Walter Lorenzetti phD
email<EMAIL_ADDRESS>skype: aiki74
twitter:w_lorenzetti https://twitter.com/w_lorenzetti
g+:aiki74 https://plus.google.com/117055903318462447104/
Tel/Cell: (+39)<PHONE_NUMBER>
Viale Verdi 24 - 51016 Montecatini Terme (PT)
Nuovi corsi QGIS e GFOSS
http://gis3w.it/it/calendario-corsi-software-geografici


Make UseFutureHandle Clone

Description
This change makes UseFutureHandle implement Clone. All other UseXHandle structs have a cheap clone that calls Rc::clone internally, so I think UseFutureHandle should also have this functionality.
Checklist

[x] I have reviewed my own code
[ ] I have added tests

Adding derive(Clone) expands to an impl with a O: Clone constraint, which is redundant in the case of UseFutureHandle, add a manual Clone impl instead

Ok I fixed it. TIL that #[derive(Clone)] will generate:
impl<O: Clone> Clone for UseFutureHandle<O> {
    fn clone(&self) -> Self {
        Self {
            inner: self.inner.clone(),
        }
    }
}

instead of what I intended:
impl<O> Clone for UseFutureHandle<O> {
    fn clone(&self) -> Self {
        Self {
            inner: self.inner.clone(),
        }
    }
}


migrated to the framework461

Codecov Report

Merging #66 (f34bf2f) into master (821e382) will increase coverage by 0.00%.
The diff coverage is 96.96%.

@@           Coverage Diff           @@
##           master      #66   +/-   ##
=======================================
  Coverage   99.66%   99.67%
=======================================
  Files          36       36
  Lines         901      911   +10
  Branches      108      109    +1
=======================================
+ Hits          898      908   +10
  Partials        3        3

Impacted Files
Coverage Δ

...oftAPI/SoftAPIClient/Implementations/RestLogger.cs
98.82% <50.00%> (ø)

....RestSharpNewtonsoft/RestSharpResponseConverter.cs
100.00% <100.00%> (ø)

SoftAPI/SoftAPIClient/Core/RequestFactory.cs
100.00% <100.00%> (ø)

SoftAPI/SoftAPIClient/Core/RestClient.cs
98.80% <100.00%> (+0.02%)
:arrow_up:

SoftAPI/SoftAPIClient/Core/Utils.cs
100.00% <100.00%> (ø)

...nt/Implementations/DataContractJsonDeserializer.cs
100.00% <100.00%> (ø)

...mplementations/DataContractJsonObjectSerializer.cs
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 821e382...f34bf2f. Read the comment docs.


Fix tests

Change travis config to make tests run in parallel. Increase heap to 2 gb and permgem to 512mb. Goog news is that storm-tests are finally passing. Bad news is that there is a legit test failure in summingbird-scalding-test and summingbird-batch build just hangs (even locally)

I have commented Two tests to get a green build for now. One of them is failing and other just hangs. Both of them are in batch/scalding layer

If you're going to take this approach can you make a pull request based on
this branch that re enables both? We need to get the both green.
Also, I wonder when they started failing? Are they broken locally with
0.6.0 which we just released?
On Saturday, February 14, 2015, Mansur Ashraf<EMAIL_ADDRESS>wrote:

I have commented Two tests to get a green build for now. One of them is
failing and other just hangs. Both of them are in batch/scalding layer
—
Reply to this email directly or view it on GitHub
https://github.com/twitter/summingbird/pull/594#issuecomment-74389375.

--
Oscar Boykin :: @posco :: http://twitter.com/posco

they are failing locally as well. Not sure when it started happening but I will enable them in this branch and then we can take a look at them

It would be good not to move things into test that we don't need to because the test coverage tools can't handle testing moduleA in moduleB, so it lowers our reported test coverage. Here the ExpressionDag stuff and the Dependants tests don't need to be moved as far as I can tell. They are not abstract test harnesses, but instead concrete tests for code in core. Let's leave that (and anything similar) in core/src/test.

There was too much going on in this PR so I have split it into 3 different PRs

core-test separation PR https://github.com/twitter/summingbird/pull/593
parallel build with commented failing tests https://github.com/twitter/summingbird/pull/599
parallel build with failing tests https://github.com/twitter/summingbird/pull/598


Add-benchmark

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

196 of 837 (23.42%)  changed or added relevant lines in 23 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-34.1%) to 64.978%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/harissa/init.py
4
6
66.67%

src/harissa/core/inference.py
4
6
66.67%

src/harissa/benchmark/init.py
0
5
0.0%

src/harissa/benchmark/generators/init.py
0
5
0.0%

src/harissa/core/parameter.py
42
51
82.35%

src/harissa/inference/hartree/base.py
6
25
24.0%

src/harissa/inference/cardamom/base.py
5
26
19.23%

src/harissa/utils/progress_bar.py
0
23
0.0%

src/harissa/benchmark/generators/inferences.py
0
70
0.0%

src/harissa/benchmark/generators/datasets.py
0
99
0.0%

Totals

Change from base Build<PHONE_NUMBER>:
-34.1%

Covered Lines:
1408

Relevant Lines:
2057

💛  - Coveralls

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

196 of 837 (23.42%)  changed or added relevant lines in 23 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-35.8%) to 63.264%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/harissa/init.py
4
6
66.67%

src/harissa/core/inference.py
4
6
66.67%

src/harissa/benchmark/init.py
0
5
0.0%

src/harissa/benchmark/generators/init.py
0
5
0.0%

src/harissa/core/parameter.py
42
51
82.35%

src/harissa/inference/hartree/base.py
6
25
24.0%

src/harissa/inference/cardamom/base.py
5
26
19.23%

src/harissa/utils/progress_bar.py
0
23
0.0%

src/harissa/benchmark/generators/inferences.py
0
70
0.0%

src/harissa/benchmark/generators/datasets.py
0
99
0.0%

Totals

Change from base Build<PHONE_NUMBER>:
-35.8%

Covered Lines:
1408

Relevant Lines:
2057

💛  - Coveralls

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

196 of 272 (72.06%)  changed or added relevant lines in 16 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-7.5%) to 91.63%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/harissa/init.py
4
6
66.67%

src/harissa/core/inference.py
4
6
66.67%

src/harissa/core/parameter.py
42
51
82.35%

src/harissa/inference/hartree/base.py
6
25
24.0%

src/harissa/inference/cardamom/base.py
5
26
19.23%

src/harissa/utils/progress_bar.py
0
23
0.0%

Totals

Change from base Build<PHONE_NUMBER>:
-7.5%

Covered Lines:
1408

Relevant Lines:
1492

💛  - Coveralls


bad credentials

Hi.
I wonder do you have any plans to implement different login? Apparently spotify has stopped login with username and password.
Kind regards

seems like spotify has indeed stopped login via username & password, as you said: https://github.com/kokarare1212/librespot-python/issues/277#issuecomment-2266307428
the fix should be easy: https://github.com/kokarare1212/librespot-python/issues/277#issuecomment-2275142944
i will try something tomorrow, and see if it works. thanks for letting me know.


"beta" branch

I can do npm install jest@beta, but this Github repo has no "beta" branch, so I can't know which commits are included in the beta.

cc @mjesun @rubennorte can you push the tag?

Should I? I think we’ve never pushed betas to GH

Dunno, but if we don't want a tag, we can at least add a commit hash to the name when publishing, like React does recently for RN

That would mean pushing anyway. I can push the commit with the tag, no big issue.

adding a git tag to the commit that was in the beat might make sense? But not pushing the version changes in the package.jsons, that messes up the versioning in the lockfile

bump 😉

I can't push anymore because more commits were merged on top. @SimenB should I override or just put over the existing ones?

You can tag any commit, no need to push new commits. git tag -a v24.0.0-alpha.0 *someSha* -m 24.0.0-alpha.0 && git push --tags origin master

But not pushing the version changes in the package.jsons, that messes up the versioning in the lockfile

That requires pushing, right? :D

https://github.com/facebook/jest/releases/tag/v24.0.0-alpha.0


Eslint plugin: missing doc for error details

Describe the bug
Using "@tanstack/eslint-plugin-query": "4.14.2", when clicking on errors in VSCode, I am redirected to a non-existing page in Github.
Your minimal, reproducible example
n/a
Steps to reproduce

Go to VSCode
Generate error @tanstack/query/prefer-query-object-syntax in a file
hover over the error and click on the link for the error
browser opens with url https://github.com/tanstack/query/tree/master/packages/eslint-plugin-query/docs/rules/prefer-query-object-syntax.md
this page does not exist

Expected behavior
When clicking on an eslint error generated by eslint plugin, I am redirected to a page that does not exist, for instance https://github.com/tanstack/query/tree/main/packages/eslint-plugin-query/docs/rules/prefer-query-object-syntax.md
How often does this bug happen?
No response
Screenshots or Videos
No response
Platform
Macos
react-query version
4.14.2
TypeScript version
4.8.4
Additional context
No response

@TkDodo, they don't have to (see https://github.com/TanStack/query/pull/4449).


Update to use fs-nextra

Proposed Semver Increment Bump: [MAJOR/MINOR/PATCH]
minor
Changes Proposed in this Pull Request (List new items in CHANGELOG.MD)

Use fs-nextra instead of fs-extra.

(If Applicable) What Issue does it fix?
Nothing but performance, native promises ❤

With the PR https://github.com/bdistin/fs-nextra/pull/1, it seems to be working perfectly. Loading times decreased from 176.30ms to 154.83ms in my test.


Could you provide the results(epe,3 pix err)  of MPI sintel based on raftstereo-sceneflow.pth?

We prepare to citeyour paper in our new work.  And we have tested the model(raftstereo-sceneflow.pth) on the  MPI sintel. But the results are much worse than other datasets. We are worried about  that something went wrong with our validation experiments, could you provide your experimental results?
Thanks!

Thank you for your reply!

We just download the raftstereo-sceneflow.pth from your google drive without any finetune and evaluate it on MPI sintel(zero-shot).
We add the following code to evaluate_stereo.py.
For the dataset, we use final_left and final_right as the test. We will appreciate if you could provide the result on this set up.

Thanks again!
`@torch.no_grad()
def validate_sintel(model, iters=32, mixed_prec=False):
""" Peform validation using the KITTI-2015 (train) split """
model.eval()
aug_params = {}
val_dataset = datasets.SintelStereo(aug_params,sparse=True)
torch.backends.cudnn.benchmark = True
totalepe=0
total3px=0
out_list, epe_list, elapsed_list = [], [], []
for val_id in range(len(val_dataset)):
_, image1, image2, flow_gt, disp,valid_gt = val_dataset[val_id]
image1 = image1[None]
image2 = image2[None]
    padder = InputPadder(image1.shape, divis_by=32)
    image1, image2 = padder.pad(image1, image2)

    with autocast(enabled=mixed_prec):
        _, flow_pr = model(image1, image2, iters=iters, test_mode=True)
    flow_pr = padder.unpad(flow_pr).cpu().squeeze(0)

    assert flow_pr.shape == flow_gt.shape, (flow_pr.shape, flow_gt.shape)
    epe = torch.sum((flow_pr - flow_gt)**2, dim=0).sqrt()

    epe_flattened = epe.flatten()
    val = valid_gt.flatten() >= 0.5
    out = (epe_flattened > 3.0)
    image_out = out[val].float().mean().item()
    image_epe = epe_flattened[val].mean().item()
    logging.info(f"sintel Iter {val_id+1} out of {len(val_dataset)}. EPE {round(image_epe,4)} D1 {round(image_out,4)}")
    epe_list.append(image_epe)
    out_list.append(image_out)

epe_list = np.array(epe_list)
out_list = np.array(out_list)

epe = np.mean(epe_list)
d1 = 100 * np.mean(out_list)
print(epe)
print(d3)
return {f'sintel{split}-epe': epe, f'sintel{split}-d1': d3}`

Using your code, I get
EPE: 17.3603
% of EPE > 3px: 13.0238
using 32 disparity updates
I'm not sure what is the difference between flow_gt and disp in your code.

Thank you for your reply!  And sorry for my late.
We get the same result.
Please forget the disp in my code, it is a mistake, we have deleted it now.
Thanks again!


Unable to Delete Obsolete Field - on dlrs__LookupRollupSummaryScheduleItems__c

Unable to enter any records!  Have to disable all DLRS
To Reproduce
Steps to reproduce the behavior:
Followed instructions: https://github.com/afawcett/declarative-lookup-rollup-summaries/wiki/Attention:-Need-to-delete-unused-field-on-dlrs__LookupRollupSummaryScheduleItems__c
Field
Expected behavior
Ability to delete field - no delete button. how to delete?
Screenshots
If applicable, add screenshots to help explain your problem.
Additional context
Checked profile permissions.

I believe this is resolved by moving to "Classic": https://trailblazer.salesforce.com/issues_view?id=a1p3A0000003fcfQAA&title=managed-components-can-only-be-deleted-in-salesforce-classic

Instructions should indicate that to delete obsolete fields you must use "classic" mode.


improve liveness probe

In GitLab by @paul.laffitte on Dec 29, 2020, 18:28

[x] check only once per minute

In GitLab by @paul.laffitte on Jan 6, 2021, 19:22
marked the task starts fast as completed

In GitLab by @paul.laffitte on Jan 6, 2021, 19:22
marked the task check only once per minute then as completed

In GitLab by @paul.laffitte on Jan 6, 2021, 19:24
marked the task starts fast as incomplete

In GitLab by @paul.laffitte on Jan 6, 2021, 19:24
marked the task check only once per minute then as incomplete

In GitLab by @paul.laffitte on Jan 8, 2021, 00:29
assigned to @paul.laffitte

In GitLab by @paul.laffitte on Jan 12, 2021, 16:54
changed the description

In GitLab by @paul.laffitte on Jan 12, 2021, 16:54
mentioned in commit b4b7269d7cca5c4d6b2bcc951aabe3d6a1f277b1

In GitLab by @paul.laffitte on Jan 12, 2021, 16:54
marked the task check only once per minute as completed

In GitLab by @paul.laffitte on Jan 12, 2021, 16:55
mentioned in commit b0e018a23e2547d62e373d02fe2887b667248574

In GitLab by @paul.laffitte on Jan 12, 2021, 16:58
mentioned in commit aec038e5f11802f1e4c2473dd1b32a1d29f816d4


Support for text nodes

I was making my way towards building a form using the HTML5 API. However, it seems to be that it's currently impossible to accomplish the following:
<p>
  <label>
    Your name?
    <input type="text" name="object[name]" />
  </label>
</p>

A possible solution could be something like:
# ...
p do
  label do
    text "Your name?"
    text_field :name
  end
end

What do you guys think?

I like the idea
cc @AlfonsoUceda @jodosha

@joneslee85 referred to the possibility for injection to happen. I'll add a failing test to start and work a solution out.


Update README.md

Readme is having very less details as of now and I think adding ABOUT details in it will be good

Part of #115


[Event Request] Table 5767 Warehouse Activity Line - OnBeforeLookUpBinCode

In table 5767 we need possibility to replace and avoid using standard code with our own. Having event with handling in the beginning of OnLookup trigger on field Bin Code, would be perfect solution :

    [IntegrationEvent(false, false)]
    local procedure OnBeforeLookUpBinCode(var WarehouseActivityLine: Record "Warehouse Activity Line"; var Item: Record Item; var BinCode: Code[20]; var IsHandled: Boolean)

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. We will update this issue with information about availability.


add ariaSupportedElements rule and tests

rule
from #341

leaving a note:

still need to add more coverage
use explicit map

where would be the best place for the map file?
Should the map and the types be separated?

Yeah I think it's better for the aria map to live alongside the lint rules. I can't imagine it being useful for anything else.

@bitpshr @sebmck
rebased the changes and moved aria-helpers to<EMAIL_ADDRESS>Thanks for the feedback

Sweet! Thank you!


Unexpected Zero-shot Results

Hi,
I tried to evaluate the fine-tuned checkpoints provided in the repo. My environment has been correctly configured and I followed all steps up to Zero-shot VideoQA section. As I only have one GPU, I didn't use distributed inference.
Here is what I used to run the evaluation:
python videoqa.py --test --eval --combine_datasets <dataset> --combine_datasets_val <dataset> --save_dir=zs<dataset> --ds_factor_ff=8 --ds_factor_attn=8 --suffix="." --batch_size_val=32 --max_tokens=256 --load=checkpoints/frozenbilm_<dataset>.pth --<dataset>_vocab_path <data_folder>/vocab1000.json
I tried with ActivityNet-VQA and iVQA and couldn't get any expected results.
For instance, here is what got by testing on ActivityNet-VQA:
number of params: 29735424
loading from checkpoints/frozenbilm_activitynet.pth
test:  [  0/250]  eta: 0:07:27  acc: 0.0000 (0.0000)  time: 1.7891  data: 0.3052  max mem: 6485
test:  [100/250]  eta: 0:03:35  acc: 0.0000 (0.0006)  time: 1.4358  data: 0.0020  max mem: 7765
test:  [200/250]  eta: 0:01:11  acc: 0.0000 (0.0005)  time: 1.4355  data: 0.0021  max mem: 7765
test:  [249/250]  eta: 0:00:01  acc: 0.0000 (0.0006)  time: 1.4344  data: 0.0020  max mem: 7765
test: Total time: 0:05:59 (1.4361 s / it)
activitynet
test acc1:  0.06%
test acc10:  0.55%
acc motion:  0.00%
acc spatial:  0.12%
acc temporal:  0.00%
acc yesno:  0.00%
acc color:  0.57%
acc object:  0.00%
acc location:  0.00%
acc number:  0.00%
acc other:  0.00%
acc sub:  0.10%; proportion  25.25%

And results on iVQA:
number of params: 29735424
loading from checkpoints/frozenbilm_ivqa.pth
test:  [ 0/63]  eta: 0:02:40  acc: 0.0000 (0.0000)  time: 2.5405  data: 0.2846  max mem: 6485
test:  [62/63]  eta: 0:00:01  acc: 0.0000 (0.0000)  time: 1.1953  data: 0.0018  max mem: 7766
test: Total time: 0:01:16 (1.2169 s / it)
ivqa
test acc1:  0.00%
test acc10:  0.95%
acc sub:  0.00%; proportion  14.20%

Do you have any ideas on this issue?
Cheers

I would try the following things:

Distributing on a single GPU
Trying the text-only variant without pretrained checkpoint, which should already give non-zero performance

Hi @antoyang,
Thanks for pointing out!
Please let me know if you can get expected results via the non-distribution way. Not too sure if this is due to my environment issue or some bugs in the implementation...
Cheers

I have just verified that the performance of a pretrained checkpoint is the same without distributing. Some notes:

It looks like you are trying to use a fine-tuned checkpoint and not the one that actually does zero-shot.
Make sure that the weights of the language model from Hugging Face are loaded. Many of the checkpoints I host do not include these weights for storage issues, which should not be an issue as they are frozen so unchanged through cross-modal training.


Reduce gas costs by drying the amount of sha3 invocations

By reducing the number of times that the registry contract performs sha3, we can reduce the net gas usage of the contract's lifetime.
Gas costs to run all tests
Previously:      68,252,306
After refactor:  67,862,086
Difference:            390,220 (0.57%)
The contract can be further refactored, extracting sha3 from apply, deposit,withdraw, exit, challenge, and updateStatus. This would however require events to emit domain hashes instead of (currently) domain strings.

f9948fd is included in #22
2ba0e51 is a logging snippet I used to get these numbers. I'm happy to drop that commit during rebase.

Cost savings are good but we do need the actual domain name to be emitted in the events, for database storage and querying. The domain name can be passed as a parameter along with the hashed domain but then that would require the contract to check if the domain matches that hash which invalidates the cost savings we we we'er aiming for in the first place.
@skmgoldin @kangarang

maybe we can have a hash table that maps domain hashes with their domain. The only method requiring the actual domain can be the apply method. In there, the domains hash table is populated with the domain hash and domain. The events can pull the actual domain from this map based on the hash.

Hi @skmgoldin . Consulted @miguelmota on this issue today, and he brought up some excellent points.
If we pursue any further in reducing sha3 (i.e. forcing the frontend to submit both domain and domainHash), that would cause inconveniences such as:

frontend needs to program and submit an extra argument
2. contract needs to make sure that the submitted domainHash is correct
events will emit hashes instead of domain strings..
..which means frontend needs to manage the correlations of each domain with its hash

I like miguel's advice - make it easy for the frontend. I do like the cost-savings, I don't like the hash event emissions, and I don't like the added having-to-make-sure the user submitted the right arguments.
As this PR stands, there are no hash event emissions and the only function that takes both domain and domainHash as arguments is resolveChallenge, which is private so it's a non-issue.
In terms of frontend refactoring, as this PR stands, the smart contract functions that would require sha3 arguments from the client are the getters - canBeWhitelisted, isWhitelisted, appExists, challengeExists, and challengeCanBeResolved.

I appreciate your work and good thinking on this PR @kangarang, but I think we should drop it in light of the issues raised by Miguel.

Could you put your code snippet for making testRPC log gas usage in a gist though? That's a good snippet.

Sounds good, will do that @skmgoldin


Upgrade Bazel to 7.3.0

Bazel 7.3.0 has been released.

https://github.com/bazelbuild/bazel/releases/tag/7.3.0

Let's wait for 7.3.1, which fixes issues with the lockfile.

@fmeum Thanks for letting me know about this!