Separate control radius from radar range and add departure destinations

This is a pull request for feedback.  There are further changes required before merge.
Two major changes:

Aircraft outside of airport.ctr_radius are not controllable - #134
Aircraft have departure destinations - #29

I've tested this on KDBG only, all other airports will require some tuning before being playable.
The first change uses the center radius as the control zone, aircraft outside of the terminal area do not respond to commands and are displayed in a subdued manner.  Scoring for arrivals/departures occurs at the area boundary instead of the radar range.  To support this aircraft fly directly away from the airport upon leaving the area boundary.
One 'feature' which needs feedback here is the ability to order an aircraft to climb above the area ceiling to depart.  To use this clear an aircraft to 11,000 feet.
The second major change is adding aircraft departures, by default everything will depart due north.  The airport.json can specify different headings for departures.  A blue arc 10 degrees wide is shown at the area boundary to show where the aircraft must fly to score a valid departure.
Departure directions are included in this PR as a method for separating departures from arrivals outside of the terminal area.
A logical further development will be to eventually extend departure specification to be like arrivals.  This would allow some airlines do depart in certain directions more than others for example.
Before merge, all airports need to be updated with departure directions and arrivals to be certain they won't conflict with either departures or other arrivals prior to reaching the terminal area.

Some initial comments:
General

shifts the balance of play between departures and arrivals
allows greater focus on the control area
future - do we want to add the ability to schedule heading or altitude changes to be followed only after a fix is reached?

Departures

both more interesting from a game play standpoint and more realistic
the blue destination arc is a good visual reminder - not visible when zoomed though
should the arc be bigger?
scoring could be less punitive; getting a departure safely off the ground but missing the arc is still a good thing
no opinion on the 11,000 feet clearance at this point, but I am guessing that in some instances departing aircraft may be initially cleared to a low altitude under arriving aircraft, then later assigned a fix and higher altitude to leave

Arrivals

more realistic to only be able to control aircraft within a defined radius
less zooming in and out required to play since beyond range aircraft can't be controlled
spawn locations, headings and spacing become more critical since player has no recourse to adjust them beyond range
perhaps arriving aircraft could be assigned navigation fixes at spawn time

A future ability to schedule commands after or at a fix would likely be desirable.  I think #147 could naturally create such a capability, it would also be the place to assign fixes at spawn time.
For departures I would like most airports to eventually have actual fixes instead of just a heading/radial.  This would make the arc visibility and size much less important.  The actual implementation would be nearly identical, but instead of a radial shown on the flight strip it would be a fix.  The fixes would be tuned to be very near the terminal boundary.
Scoring for failed departures should probably be reduced, it is equivalent to a failed arrival, which doesn't take into account missing by a small margin.
I will review and update all arrivals for all airports so there aren't any conflicts outside of the terminal area.  The assumption required of course will be that departures generally hit their destination radial.

For departures I would like most airports to eventually have actual fixes instead of just a heading/radial. This would make the arc visibility and size much less important. The actual implementation would be nearly identical, but instead of a radial shown on the flight strip it would be a fix. The fixes would be tuned to be very near the terminal boundary.

Makes sense - I am just finishing an update to KMSP and I will add departure SID fixes to that update. (KJFK and KSFO should be updated with additional fixes also).

All airports now have departure destinations, I didn't do any research I just paired a destination with each arrival.  Two new airlines were added, lightga and fastga.  Airports have been updated so arrivals are separated between jet aircraft and the slow prop aircraft of lightga.  Lightga arrivals should either be infrequent or have a speed set of 80-120 to keep aircraft from overtaking the previous one.  The only reason there should be conflicts outside the terminal area is if a departure is vectored outside of it's destination.
Departure failures score a -2 instead of a -20.

I still can't see these departure destinations. Did you implement this already?

It's in tedrek's development branch t-departure-destinations - it isn't merged yet.

I am terribly sorry, I still don't know how this thing works! Thanks for pointing this out to me!

I am terribly sorry, I still don't know how this thing works! Thanks for pointing this out to me!

No problem, we are all learning from each other. :-)

@zlsa, this is ready for merge from my perspective.

I've been very much behind lately - thanks for pinging me @tedrek, I wouldn't have noticed otherwise.

no worries @zlsa, thanks for making it in the first place and continuing to be the steward :smile:


tests failing due to expired oe_license

can someone update the oe license so we can get back to passing tests? i think that it has to be encrypted?
The tailed traceback for all tests is:

LICENSE: No valid license found for oechem
LICENSE: File(s) used: /home/runner/oe_license.txt
LICENSE: Closest license failed because:
LICENSE: expiration date
##[error]Process completed with exit code 1.

@jaimergp --- would you mind encrypting this file again? I think you had it as an organizational secret before? Thanks!

Not at home right now, but you can change this line so it uses secrets.OE_LICENSE instead of secrets.ENC_OE_LICENSE. That's the ENC-less version is the organization-wide one.


Replace IndexablePath with URI

Motivation

Implementation

Automated Tests

Manual Tests

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

#2916  👈 (View in Graphite)
#2915
main

This stack of pull requests is managed by Graphite. Learn more about stacking.


Markdown fix: avoid non-space character

this fixes Markdown formatting in the output to make two headings render as Markdown
[ci skip]

Yay! 👍

❤


[performance] Process dirty nodes from top to bottom during paint to avoid unnecessary layer tree walks

Prior to this change, the flushPaint method was the odd one out of all the flush methods on PipelineOwner as it would process dirty nodes from bottom to top instead of top to bottom. Some historic digging shows that the flushPaint processing order was changed to that in https://github.com/flutter/flutter/commit/654fc7346eb79780aadeb9c2883ea9938d5f0bd3#diff-d06e00032e4d722205a2189ffbab26c1d8f5e13652efebc849583d0a1359fec9R612. Unfortunately, the exact reason is lost to history. Presumably it was for performance, but no scenario where this order would be beneficial has been identified. Instead, this order of processing causes additional walks of the layer tree during paint that would be avoided with top to bottom processing. Therefore, this PR is changing the order back to top to bottom.
Regressions? If this change causes any performance regression it should be rolled back immediately and the scenario where bottom to top processing is beneficial should be documented in flushPaint (or even better: encoded in a test).

FYI @chunhtai since you recently also run into trouble with the upside down processing order in paint.

Figured out why this was breaking a test in Google3. A widget there is making brittle assumptions about the paint order. The Render tree looks basically like this:
Overlay
  OverlayEntryA
     UninterestingRenderObject
        RenderObjectA
  OverlayEntryB
    RenderObjectB

RenderObjectA and RenderObjectB share some data via a shared object. When RenderObjectA paints it sets some data on that sharedObject, that RenderObjectB is supposed to use during its paint. This is assuming that A paints before B (if B paints first it will use outdated data as A didn't have a chance to update the sharedObject yet). Prior to this PR, we would paint the deepest RenderObject first and since A is deeper in the tree it was guaranteed to paint first. This PR is switching this order around and now B is painting first missing the updated data that A is producing during its paint.
Seems a little brittle to rely on paint order like that. It only works because A happens to be deeper in the tree.

That is definitely an invalid assumption. It's perfectly acceptable for siblings to be painted in any arbitrary order.

Actually, what I describe above is not some custom internal widget. Turns out, it's our Material Slider widget that has this problematic reliance on node processing order during paint. Filed https://github.com/flutter/flutter/issues/98770 for that with more details. We should also add a test for the slider to the framework that would have caught the breakage this caused in google3 earlier on this PR.


Setup schema

Hello dear reviewers 👋
Kindly find in this PR the work done according to the requirements listed in the description below:

Create a new app.

Initialize the project with Git.

Make sure that the project has Postgres database set up.

Build the project schema.

Create and run the necessary migration files.

Table and column names match the ERD diagram.

note: photo for users table should be a link to an image

Foreign keys are be included.
All columns that are foreign keys have a corresponding index.

thanks dear @Felix45 .
I just cleared the code


fix quick start link error

when i read quick start,i found some problems about this links,it would be 404 bot found,so i fixed this links to right address.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.zhiyuan.yang seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

These links are not purposed to be read from Github. They are converted to the actual links in by replacing {{protocol:version}} with the actual version in a release. See Release <IP_ADDRESS> for example. We did this because the docs will be grabbed by StreamNative hub.


stable -> canary

yay success

donut, you could've used git rebase or git merge as well...

@windowz414 Also imaging knowing how to rebase
Couldn't be me


Current community page

[Client] Added visual error indicators to form elements
[Client] Added area-specific page-layouts and routing (i.e. separate layout/routing files for the Communities-Page & the CurrentCommunity-Page)
[Client] Added base flexbox layout to CommunityPage
[Client] Added CommunityProfile to CommunityPage-Sidebar
[Client] Added responsive utility CSS classes, CSS-breakponits + CSS-fluid typography to produce a responsive base font size etc. via CSS custom properties + assigned a breakpoint-specific custom "modifier"-property to calculate other depending custom properties like spacing etc.
[Client] Fixed issues  #3   #4   #7  #8
[Client] Added responsive layout with fluid sidebar to current community page
[Client] Refactored Community Page Component Structure and CSS
[Client] Changed app color-palette
[Server] Added new Group Mongoose-schema
[Server] Introduced Controllers Concept + refactored communities-routes by forwarding requests to CommunitiesControllers-functions
[Server} Added nested communities API-endpoints and CommunitiesController-function for creating Community-Groups..
[Server] Added further API endpoints for nested community user groups incl. CommunitiesController-functions etc.
[Client] Added community user group dummies to CurrentCommunity-Sidebar-layout

Hello, just try to split up your PRs into smaller focused chunks, so that your teacher isn't looking at 52 changed files, rather 5 or 6 tops. It'll save them and you alot of time!

I'll back this up a lot. Will take a look at this monster pr when I have time and the mind strength for that amount of changed files.

Hello, just try to split up your PRs into smaller focused chunks, so that your teacher isn't looking at 52 changed files, rather 5 or 6 tops. It'll save them and you alot of time!

Hi @mayinx
I left some comments here and there, but unfortunately it's super difficult to review this code. The PR has 52 files changed, and keeping them in mind while reviewing is super hard.
We mentioned that in class already, that this type of PRs are not good for reviewers, and also not good for you as a developer. You have way too many changes in one place.
In a company, this PR would probably not be accepted for review, so this is something you really have to work on.
So next PR should be small, otherwise we won't be able to review it.

Will keep it smaller, I promise ;-)


Feature/install instructions

These commits add some of the missing steps in initially setting up a Shared Services instance. I've also fixed the deployment script so it can be run seamlessly after creating the DB and configuring the instance.

Looks great.  Merging.


Correction of grammar and syntax.

The word 'well' refers to a bootstrap class and should not be translated into Portuguese.

[x] I have read freeCodeCamp's contribution guidelines.
[x] My pull request has a descriptive title (not a vague title like Update index.md)
[x] My pull request targets the master branch of freeCodeCamp.
[x] None of my changes are plagiarized from another source without proper attribution.
[x] My article does not contain shortened URLs or affiliate links.

If your pull request closes a GitHub issue, replace the XXXXX below with the issue number.
Closes #XXXXX

Closed and Reopened this PR to attempt to resolve a specific Travis build failure.

Thank you for your contribution to the page! 👍
We're happy to accept these changes, and look forward to future contributions. 🎉


Is needed to insert prosody label under Chinese data?

In filelists/ dir, I see there is no prosody label(#1 #2 #3) in text, if we insert these lable,  can get a better result ?

Another question, why every sentence end with "sp sil" ? I think just sil is enough.


possible license violation by proprietary/pseudo open-source project

Read this conversation on HN for more details.
This is the repo with derivative code and all original copyright notices ripped out. I don't think it's ok, but maybe it is.

Thanks for the heads up, we're looking into this


MC pos control: switching from MANUAL into ALTCTL

@kd0aij Currently when you are switching from manual to ALTCTL the controller will start with params.hover_thrust. This makes the transition not nice, I believe I can see this in SITL and here as well. http://discuss.px4.io/t/pixracer-barometer-issue-px4-vs-arducopter/692
In my opinion the approach before was better which initialized the integrator with the thrust value when switching into ALTCTL. Even if the user was switching into ALTCTL when the vehicle was either falling or climbing the controller was always fast enough to increase or decrease the integrator.

@kd0aij I'm talking about this here https://github.com/PX4/Firmware/blob/master/src/modules/mc_pos_control/mc_pos_control_main.cpp#L1593

The current setting works well for me if MPC_THR_HOVER is set correctly, but I have no objection to changing it back if you feel the old method is more robust. I think all of my transitions from manual to altctl have been performed when hovering, not climbing or descending. But if the throttle stick isn't centered at transition, we can expect a change in vertical speed on transition anyway.

@kd0aij How about using the parameter if it's value is non-zero and having the default parameter value of zero?

I'd avoid adding that complexity, and just change the one line of code. It should have no impact on people who switch from manual to altctl when hovering, and I doubt that I'd notice any difference if I were to change modes in a dynamic situation.

This has been fixed in the recent controller refactor.


urllib.error.HTTPError: HTTP Error 503: Service Unavailable

Running yfinance_analysis.py results in the following error, can someone help me please?
Traceback (most recent call last):
  File "/Users/maxrugen/Developer/Reddit-Stock-Trends/back/yfinance_analysis.py", line 71, in <module>
    analyzer.analyze()
  File "/Users/maxrugen/Developer/Reddit-Stock-Trends/back/yfinance_analysis.py", line 24, in analyze
    df_best[dataColumns] = df_best.Ticker.apply(self.get_ticker_info)
  File "/usr/local/lib/python3.9/site-packages/pandas/core/series.py", line 4135, in apply
    mapped = lib.map_infer(values, f, convert=convert_dtype)
  File "pandas/_libs/lib.pyx", line 2467, in pandas._libs.lib.map_infer
  File "/Users/maxrugen/Developer/Reddit-Stock-Trends/back/yfinance_analysis.py", line 46, in get_ticker_info
    info = yf.Ticker(ticker).info
  File "/usr/local/lib/python3.9/site-packages/yfinance/ticker.py", line 138, in info
    return self.get_info()
  File "/usr/local/lib/python3.9/site-packages/yfinance/base.py", line 446, in get_info
    self._get_fundamentals(proxy)
  File "/usr/local/lib/python3.9/site-packages/yfinance/base.py", line 285, in _get_fundamentals
    holders = _pd.read_html(url)
  File "/usr/local/lib/python3.9/site-packages/pandas/util/_decorators.py", line 299, in wrapper
    return func(*args, **kwargs)
  File "/usr/local/lib/python3.9/site-packages/pandas/io/html.py", line 1085, in read_html
    return _parse(
  File "/usr/local/lib/python3.9/site-packages/pandas/io/html.py", line 893, in _parse
    tables = p.parse_tables()
  File "/usr/local/lib/python3.9/site-packages/pandas/io/html.py", line 213, in parse_tables
    tables = self._parse_tables(self._build_doc(), self.match, self.attrs)
  File "/usr/local/lib/python3.9/site-packages/pandas/io/html.py", line 732, in _build_doc
    raise e
  File "/usr/local/lib/python3.9/site-packages/pandas/io/html.py", line 713, in _build_doc
    with urlopen(self.io) as f:
  File "/usr/local/lib/python3.9/site-packages/pandas/io/common.py", line 195, in urlopen
    return urllib.request.urlopen(*args, **kwargs)
  File<EMAIL_ADDRESS>line 214, in urlopen
    return opener.open(url, data, timeout)
  File<EMAIL_ADDRESS>line 523, in open
    response = meth(req, response)
  File<EMAIL_ADDRESS>line 632, in http_response
    response = self.parent.error(
  File<EMAIL_ADDRESS>line 561, in error
    return self._call_chain(*args)
  File<EMAIL_ADDRESS>line 494, in _call_chain
    result = func(*args)
  File<EMAIL_ADDRESS>line 641, in http_error_default
    raise HTTPError(req.full_url, code, msg, hdrs, fp)
urllib.error.HTTPError: HTTP Error 503: Service Unavailable

Do you have a firewall or app (like pihole) that blocks outgoing connections? Temporary disable them and try again.

Nope, not using anything like that. Tried using my phone's mobile data, no success either.

Hello @maxrugen, this means you’re rate limited by Yahoo Finance API. Overusing the API could be one reason. We’re planning to change our API wrappers soon.

Thanks @iam-abbas, that's what I thought was happening.

@maxrugen it is related to yfinance module. I couldn't use it earlier today, waited few hours and it started working. I think it is not related to overusing API because it crashed when i had ran it first time.

@kztrp Might be true, I've just been able to successfully run the script.


use development version of kableExtra to avoid black text in table captions

Described in https://github.com/NewGraphEnvironment/restoration_wedzin_kwa_2024/issues/54

of note - this actually did not solve the issue.  some discussion here https://github.com/NewGraphEnvironment/fpr/issues/74


Deploy error

Describe the bug
When hitting deploy is just runs nothing but errors.
Link to the Bolt URL that caused the error
https://bolt.new/~/sb1-hjq1vv
Steps to reproduce
Deploy app
Expected behavior
Actually deploy the app
Screen Recording / Screenshot
No response
Platform
Browser name = Chrome
Full version = <IP_ADDRESS>
Major version = 130
navigator.appName = Netscape
navigator.userAgent = Mozilla/5.0 (Linux; Android 10; K) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/<IP_ADDRESS> Mobile Safari/537.36
performance.memory = {
  "totalJSHeapSize": 46838168,
  "usedJSHeapSize": 43138612,
  "jsHeapSizeLimit":<PHONE_NUMBER>
}
Username = Code_red
Chat ID = c67234b18798

Additional context
Error:
An error occured while streaming this message.

@Snipersnippet thanks for your patience during this beta period! This issue is being tracked and investigated in #1022 so please subscribe there for updates!


NPSP Settings tab always resets the load order of NPSP TDTM handlers

We have written a custom TDTM account handler that must run first, before all NPSP handlers including the HH_Households_TDTM. We've changed the load order of all the NPSP handlers and everything works fine. However, whenever someone opens the NPSP Settings tab, it resets the load order to default for all the NPSP handlers, which we don't want.
Is there any way to prevent this from happening?  It defeats the purpose of TDTM if we can't keep our own load order.
Steps to reproduce:
Increase the Load Order value of each NPSP Account TDTM handler by 1, e.g. 3 becomes 4, 2 becomes 3, etc.
Insert a custom TDTM handler with Load Order 0.
  The NPSP TDTM load order has reverted to default.

Hi @davidchengIC Best to post stuff like this on the Hub (which I see you already have ;)) or log a case as we don't provide support via GitHub issues
Thanks


pull request for e2e test at 12/26/2016 12:45:11

:white_check_mark: Validation status: passed
For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Add Accelerator feature gate only for k8s > 1.6

I also merged back master. Only relevant commits for review are: https://github.com/ritazh/acs-engine/pull/1/commits/d8aebde7cfb12b97dca8487918d25a07a0cc7633 and https://github.com/ritazh/acs-engine/pull/1/commits/e550ab40f826e28f9c7f1be300b5557489ab9ce1


Add run_tac15_evaluation script

Looks good. Haven't had a chance to test. But the pilot will serve the purpose.


Add exemplar total label length limit check.

This was missed in the initial storage implementation PR.
cc @mdisibio
Signed-off-by: Callum Styan<EMAIL_ADDRESS>

I've moved the changes here to a new commit in #8296 since the changes in that PR to add ValidateExemplar would have required a rebase/change here anyways.


withConnectedSocket(_:channelInitializer:) in ClientBootstrap is not working

Expected behavior
withConnectedSocket(_:channelInitializer:) should create a channel and activate its handlers.
Actual behavior
withConnectedSocket(_:channelInitializer:) does not activate handlers of the channel it created, and further operations on it don't work.
Steps to reproduce
let fd = connectToSomewhere()

Task {
    do {
        let channel = try await bootstrap.withConnectedSocket(fd) { channel in
            channel.pipeline.addHandler(EchoHandler())
                .flatMap { _ in
                    return channel.eventLoop.makeSucceededFuture(channel)
                }
        }
        try await channel.closeFuture.get()
    } catch {
        // ...
    }
}

The code above will produce an error operationUnsupported.
SwiftNIO version/commit hash
2.75.0
System & version information
This issue is irrelevant to the operating system.
Possible reason
withConnectedSocket(_:channelInitializer:) will internally invoke withConnectedSocket(eventLoop:socket:channelInitializer:postRegisterTransformation:) method and it then invokes initializeAndRegisterChannel(channel:channelInitializer:registration:postRegisterTransformation:) method. The type of registration parameter is @escaping @Sendable (Channel) -> EventLoopFuture<Void>, which will take an any Channel as a parameter. The implementation closure is at https://github.com/apple/swift-nio/blob/ff98c93fe95c65cce6d160605b8e2efcfbe65f8e/Sources/NIOPosix/Bootstrap.swift#L1364
The real registerAlreadyConfigured0(promise:) implementation from SocketChannel is not called, however, the default implementation from Channel extension is called: https://github.com/apple/swift-nio/blob/ff98c93fe95c65cce6d160605b8e2efcfbe65f8e/Sources/NIOCore/Channel.swift#L205
This is an known issue of Swift: https://github.com/swiftlang/swift/issues/42725

Thanks for filing this! I can reproduce this issue as well, let me see if I can put a fix together quickly.

See #2397.


[SPARK-23559][SS] Create StreamingDataWriterFactory for epoch ID.

What changes were proposed in this pull request?
Create StreamingDataWriterFactory for epoch ID.
How was this patch tested?
existing unit tests

Can one of the admins verify this patch?

Test build #88013 has started for PR 20752 at commit c6d4ff5.

Test build #88013 has finished for PR 20752 at commit c6d4ff5.

This patch fails RAT tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
class StreamingInternalRowDataWriterFactory(
case class MemoryWriterFactory(outputMode: OutputMode) extends StreamingDataWriterFactory[Row]

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/88013/
Test FAILed.

Test build #88014 has finished for PR 20752 at commit 3cf5479.

This patch fails RAT tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/88014/
Test FAILed.

Test build #88015 has started for PR 20752 at commit 9c276f3.

Test build #88015 has finished for PR 20752 at commit 9c276f3.

This patch fails to generate documentation.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/88015/
Test FAILed.

Test build #88019 has started for PR 20752 at commit 0c68fd1.

I'm not very familiar with the streaming side, but here is my 2 cents: I agree with @rdblue that it's unnecessary to introduce the epoch id to data sources that don't care about streaming. However, I think it's natural to say that batch data source is a special case of streaming data source and only needs to deal with one epoch.
So it's a tradeoff, do we wanna make it easier to implement a batch data source, or do we wanna make it easier to implement a data source supports both batch and streaming?

Thanks for the clear summary, @cloud-fan. I think we want to make it easy to support batch, and then easy to reuse those internals to support streaming by adding new mix-in interfaces. Streaming is more complicated for implementers, and I'd like to help people conceptually ramp up instead of requiring a lot of understanding to get the simple cases working.
I think we may also want to put a design for the streaming side on the dev list. If the batch side warranted a design discussion, then I think the streaming side does as well. Changing the batch side for streaming changes as they become necessary doesn't seem like a good way to arrive at a solid design to me.

I agree that we should put a design for the streaming side on the dev list, and I intend to do so. The streaming interfaces will remain evolving until a design discussion about them has happened.
Right now, we're still at the point where we aren't quite sure what a streaming API needs to look like. We're starting from basically ground zero; the V1 streaming API just throws a DataFrame at the sink and tells it to catch. So we need to iterate towards something that works at all before a meaningful design discussion is possible.

Right now, we're still at the point where we aren't quite sure what a streaming API needs to look like. We're starting from basically ground zero; the V1 streaming API just throws a DataFrame at the sink and tells it to catch. So we need to iterate towards something that works at all before a meaningful design discussion is possible.

Thanks for the context. This aligns with the impression I've gotten and it makes sense. My push for separation between the batch and streaming sides comes from wanting to keep that evolution from making too many changes to the batch side that's better understood. I also think that streaming is different enough that we might be heading in the wrong direction by trying to combine the interfaces too early on.

Sounds fair to me. I'll continue iterating on the read side, and send out a design proposal for the write side incorporating this discussion in the next few days.

Test build #88019 has finished for PR 20752 at commit 0c68fd1.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/88019/
Test PASSed.

Merged build finished. Test PASSed.

Doc sent to the dev list: https://docs.google.com/document/d/1PJYfb68s2AG7joRWbhrgpEWhrsPqbhyRwUVl9V1wPOE

There've been no comments on the doc. Should we move forward with this PR?

Can one of the admins verify this patch?


added test file.

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To complete the pull request process, please assign momelod
You can assign the PR to them by writing /assign @momelod in a comment when ready.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@momelod: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

pr
d182ebe69e4ac8283a8cdc1ea2deff46e4d531f6
link
/test pr

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. I understand the commands that are listed here.

:star: PR built and available in a preview rewardops-k8s-workshop-pr-7 here

/approve

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: momelod
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [momelod]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

/assign


fix(website): bad translate tags without default translation

Motivation
https://github.com/facebook/docusaurus/pull/6483 broke the versions page labels
https://docusaurus.io/versions

Have you read the Contributing Guidelines on pull requests?
yes
Test Plan
preview

Wait, we don't support using one ID in multiple places? I forgot to check that🤦♂ I think we should anyways


feat(CategoryTheory/Comma): subcategory defined by morphism properties

Given functors L : A ⥤ T and R : B ⥤ T and morphism properties P, Q and W
on T, A and B respectively, we define the subcategory P.Comma L R Q W of
Comma L R where

objects are objects of Comma L R with the structural morphism satisfying P, and
morphisms are morphisms of Comma L R where the left morphism satisfies Q and the
right morphism satisfies W.

For an object X : T, this specializes to P.Over Q X which is the subcategory of Over X
where the structural morphism satisfies P and where the horizontal morphisms satisfy Q.
Common examples of the latter are e.g. the category of schemes étale (finite, affine, etc.)
over a base X. Here Q = ⊤.

I was also thinking about how to do k-Schemes and I don't think Over categories are the best way of doing it.
But we will need this anyways to define etale sites etc.
Thanks!
maintainer merge

Thanks!
bors merge


Create global list dedupe function to run after source record processing

See @ghukill 's comment

Addressed by #206


open-all-notifications should also visible when i select some notifications

Summary

show the open-notifications-button when i select the checkbox on a notification

Where

when i go to https://github.com/notifications?query=reason%3Amention

What i see

when i not select acheckbox - the button open-notifications-button
when i select a checkbox - the button open-notifications-button

What i Expect

the button open-notifications-button should also visible when i select checkboxes

Screenshots

PoC

Modifications
a) Show a second Button Open Selected
a add a second button, like the current button it can visible/hidden with css
b) change to get the selected notifications
depending on the button clicked the selection of notification can handled different
(adding a data-selection-type="all" /data-selection-type="selected" to distinct the buttons
c) edge cases
hide the button, when a user clicks on "select all" and then on "select all 20.212 notifications" (selected counter is > count of checkboxes on the page)
current behavior:

Environment
Chrome: Version 84.0.4147.135 (Offizieller Build) (64-Bit)
Refined GitHub: 20.8.16
Related issues

issue #3487 PR #3488 batch-open-conversations add checkboxes to repo without read access`

There are only 2 situations where this makes sense:

Clicking Select all
Clicking Select by state, if this feature ever comes: https://github.com/sindresorhus/refined-github/issues/3229

If you intend to select each notification and then open them all at once, you'd be wasting a click!
Instead of "check, check, check, open all"
Use "ctrl-click, ctrl-click, ctrl-click" to directly open each link in a new tab.

select-notifications has been implemented by @cheap-glitch now ☺

Should this be implemented as a special case in open-all-notifications, or as a separate button handled by select-notifications? (The second approach makes the most sense to me, but I still want to check)

@cheap-glitch The way https://github.com/sindresorhus/refined-github/pull/4526 was implemented, it would indeed make more sense as part of select-notifications as you can select issues across repositories, and the open-all-notifications buttons are shown on the individual repository lists. I would expect the button to be right next to the Select dropdown instead.

a separate button handled by select-notifications?

The two are unrelated, one can select notifications without that button, even by clicking "All"
While technically it would be a separate button from "Open unread notifications", it still matches that feature and name almost exactly, except it defaults to "select unread"


Add Algorithms for Qiskit

[x] Grover's Search
[ ] Quantum Teleportation
[ ] Bernstein- Vazirani
[x] Shor's Algorithm
[ ] Deutsch-Jozsa Algorithm
[ ] QPE(Quantum Phase Estimation)
[ ] VQE(Variational Quantum Eigensolver) for the specific case of Hydrogen
[ ] QKD(Quantum Key Distribution)
[ ] QAOA(Quantum Approximate Optimization Algorithm)
[ ] QSVM(Quantum Support Vector Machine)
[ ] VQC(Variational Quantum Classifier)

I can take up Bernstein- Vazirani algorithm.

I'd like to take Quantum Teleportation and Deutsch-Jozsa Algorithm

@rawatraghav Sure, you can proceed. Thank you for your contributions.

@DiamondPurvis Sure, you can proceed. Thank you for your contributions.

I'll take Shor's algorithms and Quantum Teleportation!

@JillisaJeffery You can take up Shor's Algorithm. Quantum Teleportation is already taken by @DiamondPurvis.

@JillisaJeffery You can take up Shor's Algorithm. Quantum Teleportation is already taken by @DiamondPurvis.

hello I am sorry, can I do Q#?

can you please assign this issue to me?

[x]  Grover's Search
[ ]  Bernstein- Vazirani
[x]  Shor's Algorithm
[ ]  Deutsch-Jozsa Algorithm
[ ]  QDK
[ ]  Quantum Teleportation

@born-2learn , Can I suggest addition of QAOA(Quantum Approximate Optimization Algorithm), Quantum Support Vector Machines(QSVM)- I will be able to contribute with these two as well.
Also, I would love taking up Bernstein Vazirani or Deutsch Josza Algorithm as my part of contribution .

@aryashah2k You can get started with QAOA and QSVM for qiskit. Bernstein Vazirani has been taken up by @rawatraghav and Deutsch-Jozsa has been taken up by @DiamondPurvis, let's wait and see if they are still interested in contributing else I can assign it to you. And yes, there was a typo in the list: it's QKD(Quantum Key Distribution) instead of QDK.

@Ak-panchal which algorithm would you like to work on specifically?

@born-2learn  can I work on shor's

@aryashah2k You can get started with QAOA and QSVM for qiskit. Bernstein Vazirani has been taken up by @rawatraghav and Deutsch-Jozsa has been taken up by @DiamondPurvis, let's wait and see if they are still interested in contributing else I can assign it to you. And yes, there was a typo in the list: it's QKD(Quantum Key Distribution) instead of QDK.

Yes great! I would love working on those two and am willing to collaborate with @rawatraghav or @DiamondPurvis if need be.
Alright, Thanks! @born-2learn , Starting this at the earliest, Also, where can I join for logistical inquiries and doubts like creating pull request, merge etc since I am relatively new to open source contributions...?

@born-2learn  Shor's or  Deutsch-Jozsa Algorithm

You can proceed with Shor's Algo for now, @Ak-panchal

can I work on quantum teleportation as part of dwoc?

Hello there @born-2learn , Last 14 days of DWOC are left and I would like to work on any pending issues under qiskit, If there is any way I can help with any issues please let me know, looking forward to contribute to the same!
Also I have a pending PR waiting to be merged #35 and have created fresh issues for QFT #36 , Im also working on Random Walks #34 and might open a PR by tomorrow...please look into these at the earliest
Regards,
Arya.


Support Node 10

It looks like a significant number of our dependencies do not work with node 10. This issue is a tracking bug for getting node 10 working.
Includes #236

The WCT was fixed, closed my related issue. Maybe check if this still has related issues?


Fix ivy-switch-buffer virtual buffer support

Fixes #1406
Yes this is a dubious hack, but it works, and ivy-resume still works.  Not sure that there's anything else which could be affected.

Lookgs good to me! Thanks for the help.

With this, +ivy--switch-buffer in
https://github.com/hlissner/doom-emacs/blob/13a20866aa955c323746ee5410e49c6168f83c36/modules/completion/ivy/config.el#L108
is redundant.


AGDIGGER-136 get rid of unnecessary sudo

https://issues.jboss.org/browse/AGDIGGER-136
How to verify
Just provision the entire thing. Make sure it works fine with a local cluster (ex: oc cluster up) and a remote cluster.

:eyes:

@aliok code reviewed, change looks fine. I will verify it now locally.

@aliok verified this locally on vagrant. The sync command works as expected. The licences is returned and the playbook continues.


Analytics so message gets delivered on first loop

Codecov Report

Merging #60 into master will decrease coverage by 1.07%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master      #60      +/-   ##
==========================================
- Coverage   84.94%   83.87%   -1.08%
==========================================
  Files          15       15
  Lines          93       93
  Branches        3        3
==========================================
- Hits           79       78       -1
- Misses         12       14       +2
+ Partials        2        1       -1

Impacted Files
Coverage Δ

.../navpages/page0/area-chart/area-chart.component.ts
84.90% <0.00%> (-1.89%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 32a5390...6b439cc. Read the comment docs.


docker-compose volume name on GCE

When creating a rexray volume with docker-compose, the compose will automatically add project name in front of the volume name (default to the folder name of where the compose file is) separated with underscore.
GCE volumes does not accept underscore as valid volume name. Most likely, rexray gce driver will need to transpose any _ to something safe like - when creating the actual volume name on GCE.

Issue moved to codedellemc/libstorage #458 via ZenHub

@codenrhoden @sterling312 Where you able to find a solution to this?  The linked issue above directs to a 404.

I am having the same problem with the s3fs.


"Românești", "Dămideni", "Românești-Vale" and "Sărata" are listed in the drop-down menu

Description:
"Românești", "Dămideni", "Românești-Vale" and "Sărata" are listed in the drop-down menu alongside its corresponding county and commune, according to the law
Precondition:
The website is up an running.

Step 1
Type "Românești" in the search bar.

Expected results
The location is listed in the drop-down menu as "Românești, Botoșani (Românești)".

Step 2
Press "x" button.

Expected results
The location was deleted from the search bar.

Step 3
Type "Dămideni" in the search bar.

Expected results
The location is listed in the drop-down menu as "Dămideni, Botoșani (Românești)".

Step 4
Press "x" button.

Expected results
The location was deleted from the search bar.

Step 5
Type "Românești-Vale" in the search bar.

Expected results
The location is listed in the drop-down menu as "Românești-Vale, Botoșani (Românești)".

Step 7
Type "Sărata" in the search bar.

Expected results
The location is listed in the drop-down menu as "Sărata, Botoșani (Românești)".


Default shown in usage is incorrect when the option is supplied

my urfave/cli version is
2.1.1
Checklist

[x] Are you running the latest v2 release? The list of releases is here.
[x] Did you check the manual for your release? The v2 manual is here
[x] Did you perform a search about this problem? Here's the Github guide about searching.

Dependency Management

[x] My project is using go modules.
[ ] My project is using vendoring.
[ ] My project is automatically downloading the latest version.
[ ] I am unsure of what my dependency management setup is.

Describe the bug
If a command fails due to invalid usage, values assigned to valid options are used to populate the defaults.
To reproduce

Create the command foo
Add the flag fizz and mark it as required.
Add the IntFlag bang with the default value of 1.
Run the command foo --bang 2

Observed behavior
The default in the usage text will show (default: 2)
Expected behavior
The default in the usage text will show (default: 1)

Unable to reproduce issue. This was the example I tried.

This looks like a duplicate of https://github.com/urfave/cli/issues/1206, but I would have to dive into the code to say that with confidence.

Unable to reproduce.


classifier accuracy increasing as attack strength (epsilon) increases

I have been applying evasion adversarial attacks on medical datasets, and noticed that after attack strength (epsilon) of FGSM, PGD, BIM increases above a certain point, classifier accuracy starts increasing instead of decreasing.
Is there an underlying reason for this behavior?
Example plot:

Hi @joelma1 Thank you very much for raising this issue and describing your observations.
Would you be able to provide more details about your experiments like model architecture, model training, dataset, framework (TensorFlow?), ART version, etc.?
Would you be able to share a script or notebook that runs your experiment for us to reproduce?


attaching price range shipping to manager

In the latest master, under the path saleor/checkout/utils.py on line 493.
it's stated that

TODO: extension manager should be able to have impact on shipping price estimates

I would like to suggest that this gets added, as both myself and #5115, #5001 need's this exact feature. Other than personal interest, I believe it would be a great addition to saleor to add this feature to the manager, so one does not have change the core code, but can settle on creating a plugin instead, which ultimately would make it easier to update saleor between stable releases.

Hi @weestack,
We are planning to convert shipping to the plugin architecture. Same as we did with the payment. During this process, we will extend the possibility to customize shipping methods.
We are going to analyze and discover the best approach for this in future days. I hope it will be introduced in the next release after 2.10


First Pass of API-side NervesHub integration

Coverage remained the same at 93.754% when pulling 1064a4c882cf6c64f1d75a27c6960fc267153805 on RickCarlino:nerves-hub-pt1 into eb22c1762d40a794d42182b44ffd7067a10da9ae on FarmBot:staging.


svg formatter can now add configurable linenumbers

Ported from https://bitbucket.org/birkenfeld/pygments-main/pull-requests/582

Hm, should line numbers be left or right aligned?

They're left-aligned using this patch. I have a patch to make them right-aligned:
diff --git a/pygments/formatters/svg.py b/pygments/formatters/svg.py
index 58d4356d..fb75e494 100644
--- a/pygments/formatters/svg.py
+++ b/pygments/formatters/svg.py
@@ -141,8 +141,8 @@ class SvgFormatter(Formatter):

         if self.linenos:
             if counter % counter_step == 0:
-                outfile.write('<text x="%s" y="%s" %s>%s</text>' % (x,y,counter_style,counter))
-            line_x += self.linenowidth
+                outfile.write('<text x="%s" y="%s" %s text-anchor="end">%s</text>' % (x+self.linenowidth,y,counter_style,counter))
+            line_x += self.linenowidth + self.ystep
             counter += 1

         outfile.write('<text x="%s" y="%s" xml:space="preserve">' % (line_x, y))
@@ -159,7 +159,7 @@ class SvgFormatter(Formatter):
                 y += self.ystep
                 outfile.write('</text>\n')
                 if self.linenos and counter % counter_step == 0:
-                    outfile.write('<text x="%s" y="%s" %s>%s</text>' % (x,y,counter_style,counter))
+                    outfile.write('<text x="%s" y="%s" text-anchor="end" %s>%s</text>' % (x+self.linenowidth,y,counter_style,counter))

                 counter += 1
                 outfile.write('<text x="%s" y="%s" ' 'xml:space="preserve">' % (line_x,y))

Right-aligned looks a bit better in my opinion. Happy to merge and apply the right-align patch if that looks good to you.

Sounds good.

Done!

The history is a bit weird as I apparently have a master merge into the branch, but on master, everything should be fine I hope.


4.1.07

fixes for:
Hideous Laughter
Levitate
Regenerate
Warding Bond
Rod of Rulership
Boots of Speed
Wings and boots of flying
Potion of Flying
Rope of Entaglement
Talisman of Ultimate Evil
Heroism

fixes #61


feat: full URL support for buildUrl and buildSrcSet

This PR adds full URL support to the client via static methods

_buildURL
_buildSrcSet

Unit tests for these methods are included in the PR.
The PR also introduces a helper function, extractUrl that uses the ufo module to parse and isolate different URL components of a full URL. Unit tests for the helper function are also included in the PR.
The PR also introduces ufo package as a dependency.
Examples
const client = ImgixClient
const params = { w: 100 }
const opts = { useHttps: true }
const src = "sdk-test.imgix.net/amsterdam.jpg?h=100"

const url = client._buildURL(src, params, opts)
const srcSet = client._buildSrcSet(src, params, opts)

console.log(url) // => "https://sdk-test.imgix.net/amsterdam.jpg?h=100&w=100"
console.log(srcSet) /** =>
* https://sdk-test.imgix.net/amsterdam.jpg?w=800&q=100&dpr=1&s=f556bd48d069e6435d8f59940fbd2830 1x,
* https://sdk-test.imgix.net/amsterdam.jpg?w=100&h=100&dpr=2 2x,
* https://sdk-test.imgix.net/amsterdam.jpg?w=100&h=100&&dpr=3 3x,
* https://sdk-test.imgix.net/amsterdam.jpg?w=100&h=100&dpr=4 4x,
* https://sdk-test.imgix.net/amsterdam.jpg?w=100&h=100&dpr=5 5x"
*/

Future Work

There are edge cases that might be missing from the unit tests. Please comment on the PR if any come to mind.
These methods could be exported as named exports to avoid having to call client.{method}. This can be added in a subsequent PR if needed.

Comments
This PR is not considered a breaking change since none of the existing public methods are changed.
This PR includes work and feedback from:

#287
#288
#290

Please note that support for full URLs is considered experimental and will not be officially supported.

Forced pushed to try out semantic release on @next.

Ran into an issue with colliding deps. Had to rebase and force push again.


change web address for application traccar web

Hello,
I successful to run  web application traccar in installed on a dedicated server, assuming www.domaine-name.com, what I want to do is to change the default web address www.domaine-name.com to www.domaine-name.com/app/. I changed the setting in the following way <entry key='web.address'></entry> * =>* <entry key='web.address'>/app</entry> but it's not working. help me.

Are you using traccar-web project? I has been deprecated for a long time and not supported any more. If you have a question about Traccar server, you should ask here:
https://github.com/tananaev/traccar/issues

yes I use web-traccar agree I will ask my questions in isssues montionné section above.

Where did you get traccar-web? Which version are you using?

I use the zip version of downloaded Package from here. https://github.com/tananaev/traccar-web file name traccar-web-master.zip

Did you build it yourself? Any particular reason for using this old project? Traccar main repo includes new web interface that is better, faster and has more features than this one.

I have no particular reason it just did happen to run the traccar is not working and tried traccar-web is works.

traccar-web is just a web interface for traccar. You can't run it on it's own, so your answer doesn't actually many much sense. Basically you are saying that traccar doesn't work, but traccar with traccar-web does. How is it even possible? I think there is some misunderstanding.

I wanted to say that I can not run a traccar + traccar-web in path www.domain-name.com/app

In one of the previous comments you said that traccar doesn't work and traccar-web does. My point is that you shouldn't use traccar-web at all because it's out of date and not supported any more.

This is really a install/support question. If issue still exist please open a topic on the forum.
@tananaev
Issue can be closed.


Battery issues TurtleBot4

Hello,
A customer acquired his TB4 in march 2023 and he has a problem with it.
"The battery does not seem to charge or the system reads the charge incorrectly. In fact, the robot "loaded"
( 100% battery on the display and green battery led ) try to do the Undocking operation and then the battery drops to 0% and the LED switches from green to red and start blinking"
What is the cause of the problem ?
Thank you, Valentin.

@ValentinLeglise In order to fully reset the system, please have them turn the robot off and then remove the battery. Wait a few minutes and then put it back in and put it back on the dock to charge. Once the battery indicates 100% again, try to undock. Let me know if the issue persists.

@hilary-luo Hi. We got a response from our customer and his problem persists.
He says : "The robot starts to undock but suddenly it blocks with 0% of battery and red led. Maybe it is an hardware problem, but it is very strange as we use the robot just for few weeks."
What should the procedure for this ? Thank you.

@ValentinLeglise I'm sorry to hear that they are still having this issue.
Have them disconnect the adapter board from within the cargo bay. Then have them remove the battery for at least 15 min. After that time is up reconnect the battery but leave the adapter board disconnected and charge the robot for 4 hours. Then power the robot off and reconnect the adapter board. Let me know if the issue still persists.

Hi @hilary-luo .
Unfortunately, our customer still have the problem after trying your previous instrucions. "The robot undock but suddenly it gives a battery error (with the red led that blink) with the battery that goes to 0%."
Maybe its a hardware problem. What do you think ?

@ValentinLeglise it is possible that there is a hardware issue but it is not a presentation that I have seen before. Are you in a position to be able to troubleshoot more directly? Specifically I am needing the create3 log, the firmware and software versions that it is running and if they can echo the /battery_state topic and confirm that they are seeing the same result there.
Also do they own more than one turtlebot? such that they could swap the batteries between two of them to see if the issue follows the battery or the turtlebot itself?

We can't directly troubleshoot his robot. I'll ask him his logs and versions you need and i come back to you. And what do you mean with "echo the /battery_state topic ? And unfortunately, they don't have another tb. Thank you.

echo the /battery_state topic is terminology relating to ROS 2. The system is broadcasting data on different topics and echoing is one way to view the data that is being broadcast. If they ssh into the robot they should be able to run ros2 topic echo /battery_state and share the output (they should confirm that it matches the screen too).
If they are using namespacing they will need to modify that command to add their namespace and they may need to source ROS2 in the terminal first before sending that command. If they are using the ROS2 functionality then they should be somewhat familiar with this terminology.

logs_turtlebot4.txt
There you can see their logs, and their firmware version is G.3.1. Tell me if it is ok or if i have to tell them to send back the robot.
Regards

Hello,
Can i have an answer for this please ? its pretty urgent.
Regards

These are logs : logs_turtlebot4.txt
This is the echo :
There you can see their logs, and their firmware version is G.3.1. Tell me if it is ok or if i have to tell them to send back the robot.
Regards

@hilary-luo  Hello. Thanks for your answer.
How to process ? Can you send us a new battery and the instructions to replace it.
Find the shipping adress:
Name: Julien Amiel
Email adress<EMAIL_ADDRESS>Phone number: +33 (0)5 56 39 37 05
Company: Génération Robots
Street: 10 Rue Joule
City: Mérignac
Post Code: 33700
Country: France
If you need broker adress, please let me know.
The customer needs his robot for the begining of the next year, i think its urgent.
Best regards, Valentin.

Hi Valentin - I replied to you directly from our Support email - lets correspond there.
Thank you,
Rusty

Closing since this issue as it is now being handled through Clearpath Support to address the hardware.


585 exhibitions note

https://github.com/uwlib-cams/MARC2RDA/blob/main/Working Documents/5XX.csv

I think I am done with this, but my choice for a 585 ("Copy-specific field that contains a note which cites exhibitions where the material described has been shown.") with no $5 indicating a specific item owner --- mapping $a to Note on manifestation instead of minting a phantom item to which to attach the note, and appending "Item exhibited" to the front of the note, may be open to question.   I am mindful that this note could appear in records for single ("manuscript") item manifestation descriptions, "special" copy descriptions, or other contexts where multiple copies of a manifestation exist but one was first exhibited as described in the note.  Without a $5 it is difficult to identify an item so I thought it not worth minting one.
Our Theology library special collections cataloger makes use of this field - with the $5.


Dropdowns on windows become unreadable on hover

On Windows 11 (haven't tested on other platforms) when you hover over the primary element (circled in red in the following image) dropdowns become unreadable:

They remain unreadable until you move your mouse off of any part of the dropdown, at which point they become readable:

They'll then remain readable until you hover over the that primary element again.

After debugging a little it looks like the issue is that when the <select> dropdown element has :hover, the option elements simultaneously inherit the rule for select:hover that color: var(--text-on-hover), and the rule for .dropdown option that background-color: var(--background-primary). These are the same color, so you get no contrast.
I'm not sure what the intended appearance is, but if someone attaches screenshots of what it's supposed to look like I could try to write a fix.


device orientation example didn't work inside Iframe

hello
device orientation example didn't work inside Iframe
you can check it http://zaherk1981.wixsite.com/vr-view-loc/iframe , any idea why  ?
thanks

@tjgq  any idea ?

Cross-domain iframe policies for iOS. Likely this issue is only on iPhone/iPad. You must host the iframe on same domain as the parent window.
https://bugs.webkit.org/show_bug.cgi?id=152299

With iOS 9.2 WebKit now blocks deviceorientation and devicemotion event access from cross-origin iframes.

This Stack Overflow thread has additional information, and suggests a possible workaround.


vagrant: 2.2.3 -> 2.2.5

Motivation for this change
Fixes #64243.
FYI, it is written:

NOTE: bumping the version and updating the hash is insufficient;
you must use bundix to generate a new gemset.nix in the Vagrant source.

However doing this did work for me:
stanislas@nixpsla ~/n/p/d/t/vagrant> (vagrant/update/2.2.5|✚1) ./result/bin/vagrant version
Installed Version: 2.2.5
Latest Version: 2.2.5

You're running an up-to-date version of Vagrant!

Now, I am interested to know how to update the gems without the Gemfile. I saw https://github.com/NixOS/nixpkgs/pull/47519#issuecomment-425645412 but it's doing weird stuff for me.
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Notify maintainers
cc @aneeshusa

FYI by using Vagrant's Gemfile + bundle + bundix, I'm getting this: gemset.nix.txt, which seems weirdly... long?

This pull request has been mentioned on Nix community. There might be relevant details there:
https://discourse.nixos.org/t/prs-already-reviewed/2617/47

Perhaps @alyssais and @manveru could help you with this.
I don't think I see any reason that the gemset.nix would be generated improperly.

In any case, we need some clear documentation/script to update vagrant once this is settled! :slightly_smiling_face:

Well, I can explain it a bit later, a working version is at: https://github.com/manveru/nixpkgs/commit/c2b5d07e6126202c342e7d8b53e5b283a9064d52 for now
You basically have to make a Gemfile because bundix doesn't support the gemspec method yet. It looks like this:
# frozen_string_literal: true

source 'https://rubygems.org' do
  gem 'bcrypt_pbkdf', '~> 1.0.0'
  gem 'childprocess', '~> 0.6.0'
  gem 'ed25519', '~> 1.2.4'
  gem 'erubis', '~> 2.7.0'
  gem 'hashicorp-checkpoint', '~> 0.1.5'
  gem 'i18n', '~> 1.1.1'
  gem 'listen', '~> 3.1.5'
  gem 'log4r', '~> 1.1.9', '< 1.1.11'
  gem 'net-scp', '~> 1.2.0'
  gem 'net-sftp', '~> 2.1'
  gem 'net-ssh', '~> 5.1.0'
  gem 'rb-kqueue', '~> 0.2.0'
  gem 'rest-client', '>= 1.6.0', '< 3.0'
  gem 'ruby_dep', '<= 1.3.1'
  gem 'rubyzip', '~> 1.2.2'
  gem 'vagrant-spec', git: 'https://github.com/hashicorp/vagrant-spec.git'
  gem 'vagrant_cloud', '~> 2.0.2'
  gem 'wdm', '~> 0.1.0'
  gem 'winrm', '~> 2.1'
  gem 'winrm-elevated', '~> 1.1'
  gem 'winrm-fs', '~> 1.0'
end

is taken from the dependencies in the Gemfile and gemspec files in the vagrant repo.
Then you can run nix-shell --pure -p bundler bundix git --run 'bundle lock && bundix' to generate the gemspec.nix.

Thanks for posting this! :slightly_smiling_face:
If I understand correctly you manually created a Gemfile using:
https://github.com/hashicorp/vagrant/blob/5d4c9ef8a74df967f6f24867360d4f6e1f3705ff/vagrant.gemspec#L19..#L43
Thus... don't we keep our own Gemfile (or why did we remove it) in nixpkgs/pkgs/development/tools/vagrant/Gemfile? It seems very bothersome to manually create a new one each time (+ how are newcomers supposed to know?)
Then, I suppose there are some missing steps:
stanislas@nixpsla ~/n/p/d/t/vagrant> (vagrant/update/2.2.5|…) nix-shell --pure -p bundler bundix git --run 'bundle lock && bundix'
Fetching https://github.com/hashicorp/vagrant-spec.git
There was an error accessing `/nix/store/glhmssxi9zpw6r84ws2zdyw2hfvpsnm2-ruby-2.5.5/lib/ruby/gems/2.5.0/cache/bundler/git`.
The underlying system error is Errno::EROFS: Read-only file system @ dir_s_mkdir -
/nix/store/glhmssxi9zpw6r84ws2zdyw2hfvpsnm2-ruby-2.5.5/lib/ruby/gems/2.5.0/cache/bundler

When running bundle install the "hack" I found was to specify a custom --path dir. How did you do?

@GrahamcOfBorg build vagrant

@angristan thanks!
Backported as 25eb016a2f51c0afd6b84c45f4d1ee96ef5aeeba

Ok, thanks!

I think I will do a PR to add the Gemfile back. What would be a good place to add documentation (besides a comment in the Gemfile?)

I think I will do a PR to add the Gemfile back. What would be a good place to add documentation (besides a comment in the Gemfile?)

As this is only relevant for folks who want to modify the vagrant package it should be sufficient to enhance the comment :)

After thinking a bit about it, adding an update script is better than revendoring Gemfile and Gemfile.lock. See #65800 (need some feedback!)


Exchange wallet file size too big, how to replace wallet?

Hi Kzv and other Opentrade admins:
How to maintain, and possibly replace a wallet when the file size is too big?   My exchange NENG wallet is growing really big, now several hundred M size.  At some point, I will need to recycle the wallet.  What is best practice to do that?
Assuming I stop the withdraw and deposit of the wallet, possibly stop trading for a short period,  can I just replace the old wallet to a fresh new wallet?  Of course, I need to transfer the coins at  old wallet to new wallet, but would that be a good practise or not?

This issue is naturally resolved. NewEnglandcoin changed name to Nengcoin. Old coin will be delisted, new coin is listed. A swap.


DEP: signal: remove cmplx_sort

Reference issue

follow up to https://github.com/scipy/scipy/pull/18587
What does this implement/fix?

scheduled to be removed in this release
Additional information

Doc error looks relevant:
/home/circleci/repo/build-install/lib/python3.11/site-packages/scipy/signal/__init__.py:docstring of scipy.signal:118: WARNING: autosummary: failed to import cmplx_sort.

Oops forgot to stage one of the files, hopefully this comes back green

thanks both!


Add a cop to prevent -> ( lambda format

As discovered in https://github.com/rmosolgo/graphql-ruby/pull/313:

Both -> (arg) { ... } and ->(arg) { ... } are supported in Ruby 2+ (notice the space between -> and the parenthesis.
-> (arg) { ... } is not supported in Ruby 1.9.3 and the interpreter reports:

syntax error, unexpected tLPAREN_ARG, expecting keyword_do_LAMBDA or tLAMBEG (SyntaxError)
      -> (arg) {
          ^

It seems reasonable to me to enforce ->(arg) { ... } in style guides. After all, all examples in Rubocop's doc or your Ruby style guide use this format consistently.
This is very valuable when developing a library that supports both versions 1.9.3 and 2+.
Looking forward to hearing your opinion on that.

While I don't care at all about 1.9.3 compatibility, I agree that we should stick to the style without a space for historical reasons. I have some memory that at one points we added some similar check to RuboCop, but I might be mistaken.

I like the idea of a cop to keep this consistent, but I would like the style to be configurable as I prefer the style with the space.

Fine by me.

I have a working cop for this, and will commit soon.


Adding survey with the troubleshooting content

Adding the survey to get customer feedback of the troubleshooting content

@yjin81 : Thanks for your contribution! The author(s) have been notified to review your proposed change. @YanJin

@yjin81 : Thanks for your contribution! The author(s) have been notified to review your proposed change. @YanJin

Microsoft authors of articles need to make updates through the private repository so the updates can be staged and validated by the current validation rules. After you review staging and fix all validation issues, you can add the sign-off comment to let the PR reviewers know the updates are ready to be merged.It's easy to access the private repo version of your articles in GitHub. Just add -pr to the URL, as follows:
Public repo URL: https://github.com/Microsoft/azure-docs/blob/master/articles/azure-portal-overview.md
Private repo URL: https://github.com/Microsoft/azure-docs-pr/blob/master/articles/azure-portal-overview.md
We have closed this pull request. Please resubmit the updates through the private repo. If you need perms to the private repo, see the contributor guide instructions


WinUI 2.6 - Acrylic fallback should be darker

In WinUI 2.6, the acrylic fallback is very close to ApplicationPageBackgroundThemeBrush, making it harder to distinguish areas with acrylic when it's not active with the other sections. Please make it darker to be easily distinguishable from the default page background.

@chigy FYI

Not sure if it should be darker, but there is something odd happening in the MUXTestApp.
The TestUI pages have the NavigationView which should be displaying the default values, but appear not to be.

The Sidebar is showing the same colour as the page background, yet the values are different in code.
<Color x:Key="SolidBackgroundFillColorBase">#F3F3F3</Color>

<StaticResource x:Key="NavigationViewDefaultPaneBackground" ResourceKey="AcrylicInAppFillColorDefaultBrush" />

<local:AcrylicBrush x:Key="AcrylicInAppFillColorDefaultBrush"
                    TintColor="#FCFCFC"
                    TintOpacity="0.0"
                    FallbackColor="#F9F9F9"
                    BackgroundSource="Backdrop"/>

@mdtauk The background colour for NavigationView pane is actually transparent, and the #F3F3F3 colour you're seeing here is coming from ApplicationPageBackgroundThemeBrush. If you take a look at the PaneOverlayGroup in VSM, in the PaneNotOverlaying state, it's pointing to NavigationViewExpandedPaneBackground which is transparent.
It also turns out there's two files, NavigationView_rs1_themeresources.xaml and NavigationView_rs2_themeresources.xaml that's interfering with one another, causing confusion. :/

@mdtauk The background colour for NavigationView pane is actually transparent, and the #F3F3F3 colour you're seeing here is coming from ApplicationPageBackgroundThemeBrush. If you take a look at the PaneOverlayGroup in VSM, in the PaneNotOverlaying state, it's pointing to NavigationViewExpandedPaneBackground which is transparent.
It also turns out there's two files, NavigationView_rs1_themeresources.xaml and NavigationView_rs2_themeresources.xaml that's interfering with one another, causing confusion. :/

Is the transparency by design?  If so could that choice be revisited.

There should be a way to distinguish between the navigation view and the content. The current technique is to use a different background that's noticeable however other techniques like a shadow or a small line could also be used.


Update README.md

Fix a specific grammatical error in the section "How do I build it"  of the README.md

Fix grammatical errors in README.md


Error writing to csv in run_ppo2_mlp

Branch dashing
Env MARA-v0
Command: python3 run_ppo2_mlp.py -g -r -v 0.3

Error
Reward:  [-0.89437598]
ee_translation[x, y, z]:  [ 0.399223   -0.09404414  0.63918883]
ee_orientation[w, x, y, z]:  [ -6.60108844e-06   1.57084723e-03  -3.76790331e-06  -1.05699059e-03]
Traceback (most recent call last):
  File "run_ppo2_mlp.py", line 126, in <module>
    csv_file.write_obs(obs[0], csv_files[0], defaults['env_name'])
  File "/home/nestor/ros2learn/experiments/examples/MARA/write_csv.py", line 16, in write_obs
    df.to_csv(f, header=obs_headers, index=False)
  File "/home/nestor/.local/lib/python3.6/site-packages/pandas/core/generic.py", line 3020, in to_csv
    formatter.save()
  File "/home/nestor/.local/lib/python3.6/site-packages/pandas/io/formats/csvs.py", line 172, in save
    self._save()
  File "/home/nestor/.local/lib/python3.6/site-packages/pandas/io/formats/csvs.py", line 274, in _save
    self._save_header()
  File "/home/nestor/.local/lib/python3.6/site-packages/pandas/io/formats/csvs.py", line 209, in _save_header
    nalias=len(header))))
ValueError: Writing 24 cols but got 12 aliases

we should clean this out, remove or make it work. It trows errors all the time.

I will fix this

This is due to the new stats, now the obs.dim is +12 and the csv writer has the obs size hard coded. We can make it dynamic.


Complete build on "wide" public cloud?

Is there a well-known way to build large nix expressions (e.g. whole nixpkgs) on "wide" public cloud compute resources? For example, to run each individual build in a separate Google Compute Engine preemptible VM instance, with thousands of VMs in total. Parallelism would be bounded only by the number of preemptible instances that are available on the cloud at the time and the dependencies between nix derivations.
I am curious about whether solution(s) for this already exist and how heavyweight they are (e.g. uses only basic nix commands, or requiring nixops, or requiring Hydra, etc.)
Generally musing that with preemptible VMs now being billed in one-second increments it may be time to consider a 1:1 scheduler from builds to machines both for simplicity (outsource scheduling to cloud provider) and for performance (more elastic capacity for lower build latency.)

Even with 1-second billing, it's still advantageous to reuse instances to prevent having to download the same dependencies over and over again. Hydra doesn't currently schedule builds in a way to minimize downloads, but there will be a lot of overlap between dependencies anyway (e.g. stdenv will be the same for most builds).
hydra.nixos.org uses a script called hydra-provisioner that creates EC2 spot instances depending on the current queue size. hydra-provisioner uses NixOps, but any provisioning method will do; the only requirement is that the machines are reachable via SSH and have Nix installed (doesn't even have to be NixOS). The use of NixOps is not ideal for 1-second billing because the deployment can take a few minutes. It would be better to pre-bake an AMI with the required configuration and to use spot fleet to spin up instances.

If we're really talking about thousands of machines, then Hydra is not really appropriate due to its centralized architecture. This would require a different architecture to be scalable. E.g. each worker node independently fetches work items from a queue, where a work item is something like "build the foo attribute from repo git://bar", and independently uploads the results to S3.

Thanks for playing along on the thought experiment.
Yes it seems like a different architecture would be suitable. One machine evaluates a Nix expression to find the set of required derivations, this dependency tree is stored in a common location with the status of each one, and a set of build slaves do "work stealing" to build derivations whose dependencies are done. Right?


Research prioritisation methods and tools

What
Use this ticket to collate and discuss different tools and methods we have discovered during the prioritisation discovery.
Why
After the discovery we can use the resources in this ticket to help us plan our next steps.
EPIC
#951
Related work
#684
Done when

[ ] Prioritisation methods and tools have been documented in the comments
[ ] We have evaluated and discussed each method

Details on Sara and Tosin's method for prioritising the content backlog can be found in the comments of #1128

Engineers at Rolls Royce use an AHP ranking (Analytic hierarchy process) combined with a Pugh matrix to prioritise stages within a project.
Positives of this method:

you work as a team
there is no limit to the amount of criteria/requirements you consider
the process allows you to proportionality scale each criteria by importance

Negatives:

It can take a while to set up
We will need to consider who is involved in the process

@georginaplatt shared a measurement framework used by pm’s working on transformation products.
Georgina is going to learn more about this method and update us :)

@georginaplatt is arranging an intro meeting with Imran, the Community Manager for the GOV.UK Design System. It would be good to try and arrange a follow up meeting with him to discuss how they prioritise their community backlog.

https://uxdesign.cc/feature-prioritization-a089fd0af08
Overcoming prioritisation biases
Method 1. Annotated marks

Method. Add real-life descriptions to abstract numeric marks.
Strengths. Clarity in selection criteria makes for easier agreement, less subjectivity, and less time spent on discussions.
Limitations. Developing a meaningful scale needs time; such a scale is contextual and might not be reused for another project.

As you're interested in prioritisation methods, I thought you might be interested in this blog post: https://www.effortmark.co.uk/five-ways-to-choose-which-form-to-fix/
I've written specifically about fixing forms because that's my area, but I thought you might want to think about adapting my five methods like this:

Pick the thing you happen to be working on now
Pick the thing that has the highest usage
Pick the thing that creates the biggest problem for support
Pick the thing with the worst conversion rate (quite probably conversion rate doesn't work for service manuals, only here for completeness)
Pick the thing with the biggest policy gap

If for no other reason because it's a change of perspective. I've also seen plenty of examples where an example of choice 3 - the thing that was the biggest problem for support - never made it to the top of other prioritisation methods because the support folks weren't on the radar.

Thanks @cjforms 🙌

@georginaplatt is arranging an intro meeting with Imran, the Community Manager for the GOV.UK Design System. It would be good to try and arrange a follow up meeting with him to discuss how they prioritise their community backlog.

I think it would be good to go to the meeting on Tuesday with some questions to ask Imran & the design team - the prioritisation exercise would be a good one. Might even be an idea to ask them in advance of the meeting so they are prepared?

Trilly C has shared insight with me about how he approaches prioritisation:

Start with an approach that is high level and qualitative, something you can easily compare with the top level goals/mission/purpose of the team. That might then reveal more granular prioritisation needs that necessitate a more quantitative approach - but generally I look to make any ‘obvious’ calls in a qualitative way before resorting to quantitative approaches. Sometimes there won’t be ‘obvious’ calls, at which point I look for a framework that best matches the nature of the prioritisation calls we need to make


Are we force pushing on master?

Hi, @GildedHonour, I just came across this repo to find some of my recent work we did on this repo, but I don't see any of those changes like renaming the gem, adding missing standard ruby gem files and implementation of OSS guide. Did we change any plan on this gem and are we force pushing anything to the master?
Missing PR's - https://github.com/riboseinc/asciidoctor-rfc/pulls?q=is%3Apr+is%3Aclosed

@abunashir we've not changed any plans and everything is as originally discussed. I don't think anyone should be force pushing to master.

@abunashir
yes. I have other projects that's why it's a bit slow, sorry. Also, it's taken a bit of time to learn what xml2rfc  is. I'll try to speed up. No change of the plan.
But we haven't discussed in detail how we should commit. A new branch per issue? Or in the branch develop and then merge into master? I've pushed into master because there have been no other commits and developers. I'll then switch to develop, right?
Also we should rename the gem to rfc2xml or rfcxml, huh?

@GildedHonour there were actually a number of commits from @abunashir already merged to master. As mentioned in issue #3, the gem is called "asciidoctor-rfc" as an asciidoctor backend.

Regarding force pushing to master - I completely agree with @ronaldtse, we should never do that. Especially when we have multiple developers working on the project and we have open sourced the code. Rewriting git history in feature branch is okay, but we have to make sure we never do that to the master for any of our open source projects.
@GildedHonour: We have the details guideline here, including Git Protocol, Best Practices  and Code Review, please spent some time on those and if there is any question then ping @ronaldtse, me or @ribose-jeffreylau.
PS: I will try to restore those commits now, and once done then I will post another update here.

I've restored the missing commits, and also extracted the additional work form @GildedHonour in #7. Please have look on those, I am not sure if those would be relevant but if necessary then maybe rebase and then merge that PR.
cc: @ronaldtse.


Duplicate links

Hi, I noticed that there are duplicated links below the website.
The youtube channel link and youtube
I think it would be better if

remove youtube channel link
Make the social media font in bold
and put the social media links under the address, i guess? (to make it more aligned)

if you allow me, I would like to address this issue to contribute 😄

if you allow me, I would like to address this issue to contribute 😄

Yes @xyrelljoi  please remove that link

Thank you! I already did pr @SahityaRoy


support to link external image as banner

support to link external image as banner and  correct  thumbnail‘s link

Thanks for your quick update. It works great :+1:


Support component generics

Implement RFC https://github.com/vuejs/rfcs/pull/437

Codecov Report

Merging #300 (5b6c3fe) into main (5dcab41) will increase coverage by 0.11%.
The diff coverage is 79.35%.

@@            Coverage Diff             @@
##             main     #300      +/-   ##
==========================================
+ Coverage   42.86%   42.98%   +0.11%
==========================================
  Files         162      163       +1
  Lines       20542    20567      +25
  Branches     1273     1282       +9
==========================================
+ Hits         8806     8841      +35
+ Misses      11736    11726      -10

Impacted Files
Coverage Δ

packages/transforms/src/index.ts
0.00% <0.00%> (ø)

packages/transforms/src/tsTransformScript.ts
0.00% <0.00%> (ø)

...ript-plugin-vue/src/features/CompletionsService.ts
0.00% <0.00%> (ø)

packages/compiler-tsx/src/vue/compile.ts
78.47% <53.57%> (-6.33%)
:arrow_down:

packages/transforms/src/tsTransformScriptSetup.ts
80.75% <91.13%> (-0.58%)
:arrow_down:

packages/transforms/src/createProgram.ts
93.54% <93.54%> (ø)

packages/compiler-tsx/src/template/generate.ts
83.34% <100.00%> (-0.04%)
:arrow_down:

...ompiler-tsx/src/vue/blocks/transformScriptSetup.ts
100.00% <100.00%> (ø)

packages/shared/src/rpc/handlers.ts
97.42% <0.00%> (-0.52%)
:arrow_down:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


ppafm-plot-results fails because of missing load_scal_field in GridUtils

The script ppafm-plot-results fails to generate *.png figures, complaining that it cannot load OutFz.xsf because of missing attiribute load_scal_field in the ppafm.GridUtils module. In more detail,
ppafm-plot-results -k 0.5 -q -0.05 -a 2.0 --df

finishes with the following error message:
error:  (<class 'AttributeError'>, AttributeError("module 'ppafm.GridUtils' has no attribute 'load_scal_field'"), <traceback object at 0x1550ab371200>)
cannot load :  Q-0.05K0.50/OutFz.xsf
 ***** ALL DONE *****

Originally posted by @mondracek in https://github.com/Probe-Particle/ppafm/issues/127#issuecomment-1486934443

Now I see that if I replace GridUtils with io too, as @NikoOinonen suggested in #126, this issue is resolved, so I am going to resolve it with the same pull request #127 as issue #126.


Updated example test cases to show error in test application

Added a test case for the Keyboard Down and Up Events labels in the test application to show an error in it. Extended existing keywords "Press key" and "Press keys" to include press and release events to enable the test.
In the test application "WpfApplication.exe" in the "Keyboard Controls" tab, the Keyboard Down Events label does not work for some keys. E.g. Arrow Keys (The Keyboard Up Events work)

@GeoGegl
One thing do you forgot. Pls update changelog.md in root directory about parameters changes in keyboard keywords. Then all looks fine.


x-total-count returns 20000 even when there are more records

Is there some kind of limit to x-total-count header?
I have 39.000 records, but the headers returns 20000

I also noticed Express returns X-Total-Count equal to _limit param instead of real collection size.


Fix pool > poll.

Typo, pool is actually poll.

Coverage increased (+0.05%) to 84.12% when pulling 1661cf8a42a567398c9cd1ae16295b3d1ef2c311 on mo-15-feb-add-instance-and-generator into fefa09807b0a5c3f2b12bdf5708a07638bf66f63 on master.

Coverage increased (+0.05%) to 84.12% when pulling 1661cf8a42a567398c9cd1ae16295b3d1ef2c311 on mo-15-feb-add-instance-and-generator into fefa09807b0a5c3f2b12bdf5708a07638bf66f63 on master.


📅 5/3 @ noon PT - GitHub Action Artifacts with @reconbot

💁🏻 GitHub Action Artifacts
📅 Monday, May 3rd, 2021
🕐 noon Pacific Time (in your timezone)
🎙 with @reconbot
🏷 Action

Subscribe to this issues to get a notification before the show begins and a summary after the show concludes.
GitHub Action Artifacts

I’d like to have a job run after a few others finish and use their artifacts. Eg build serialport with all architectures and ship them in a single npm package.

— @reconbot on twitter
In this show, we will create an releases setup which requires native operating systems bindings to be created on their respective target operating systems. After all bindings are created, they will all be published as part of an npm package using GitHub Actions and @semantic-release.
Outline

Introductions
What are native bindings for Node.js, why do they need to be created on the same operating system version that they will be used on?
Creating the different bindings using a GitHub Actions Workflow matrix in reconbot/bindings-cpp
Upload bindings from all build matrix jobs to as GitHub Artifacts
Download all GitHub Artifacts in a final step
Setup automatic releases of the package with the native bindings to npm using @semantic-releas
Bonus: apply the same setup to serialport/node-serialport

Preparation

[X] Get confirmation from @reconbot on the summary above to make sure we are on the same page in terms of scope for the show
[x] Prepare a repository for a minimal npm package that requires native operating system bindings: reconbot/bindings-cpp
[x] Create a minimal repository to showcase artifacts & GitHub Actions Workflow matrix: gr2m/github-actions-artifacts-test

🔴 Going live now at https://twitch.tv/gregorcodes

Aaand it's a wrap, here is the recording on Twitch: https://www.twitch.tv/videos/1010012340

I'll add more notes and a link to the video on YouTube shortly. Please comment here if you have any more questions about today's show!

The video is now up on YouTube: https://youtu.be/nZFFhygLhzk


gRPC Stream are cancelled by the sidecar

Describe the bug
Setup is :
client pod (+ istio auto-inject sidecar) --> server pod + istio auto-inject sidecar
When the client opens a gRPC connexion to the server (so i'ts HTTP2 + bidirectional stream), the connections is closed after some random timeout.
I've experienced timeouts from 30s to 10 minutes.
While the server sees the connection as "canceled", the client is not aware of it.
If I start more parallel connexions, they all timeout at the same time.
Looking at the Envoy stats, I see :

client sidecar (when enabled)

upstream_rq_active goes from 1 to 0
upstream_rq_pending_failure_eject increase by 1
upstream_rq_total  increase by 1
upstream_rq_200: increase by 1
upstream_rq_2xx: increase by 1

upstream_cx_destroy_remote_with_active_rq: increase by 1
upstream_cx_destroy_with_active_rq: increase by 1
upstream_cx_http1_total: 0
upstream_cx_http2_total: 7

server sidecar

upstream_rq_200: increase by 1
upstream_rq_2xx: increase by 1
upstream_rq_total: increase by 1
upstream_rq_tx_reset: increase by 1

external.upstream_rq_200: increase by 1
external.upstream_rq_2xx: increase by 1
http2.tx_reset: increase by 1

The issue happen when the Istio Sidecar is injected on the Server side so it does not depend on the client side.
My guess is that the Server sidecar is closing the TCP connexion at some point and the gRPC lib on the client silently reconnect.
I've done some TCP dumps that clearly show that the Istio Sidecar, after some time, is sending :

a HTTP/2 Stream RESET to my server app
a TCP FIN/ACK to the client

Expected behavior
The gRPC connection (streams) should remain opened until the client or the server close it
Steps to reproduce the bug
I'm using my client/server in Go from https://github.com/prune998/goHelloGrpcStream
Deploy the client and server with the annotation "sidecar.istio.io/inject": "true"
The client then connect to the server, send a PING message, get a reponse and wait on the channel.
At some point, the Istio Sidecar of the server will cancel the connexion.
Version
Version: 0.8.0
GitRevision: 6f9f420f0c7119ff4fa6a1966a6f6d89b1b4db84
User: root@48d5ddfd72da
Hub: docker.io/istio
GolangVersion: go1.10.1
BuildStatus: Clean

and Kubectl :
Client Version: version.Info{Major:"1", Minor:"11", GitVersion:"v1.11.0", GitCommit:"91e7b4fd31fcd3d5f436da26c980becec37ceefe", GitTreeState:"clean", BuildDate:"2018-06-27T22:30:22Z", GoVersion:"go1.10.3", Compiler:"gc", Platform:"darwin/amd64"}
Server Version: version.Info{Major:"1", Minor:"10+", GitVersion:"v1.10.5-gke.0", GitCommit:"f4c74e18e57148052c59cc0467bb7e99dcc46399", GitTreeState:"clean", BuildDate:"2018-06-21T14:11:26Z", GoVersion:"go1.9.3b4", Compiler:"gc", Platform:"linux/amd64"}

Is Istio Auth enabled or not?
Auth is disabled
Environment
GKE 1.10 cluster

I've just set connection and http2 logs to debug, and here is what I have on the server side :
[2018-07-10 17:57:48.528][22][debug][http2] external/envoy/source/common/http/http2/codec_impl.cc:635] [C115] setting stream-level initial window size to 268435456
[2018-07-10 17:57:48.528][22][debug][http2] external/envoy/source/common/http/http2/codec_impl.cc:657] [C115] updating connection-level initial window size to 268435456

time="2018-07-10T17:57:48Z" level=info msg="Reveived Stream message Ping 0" endpoint=SayHelloStream port=7788

...

[2018-07-10 17:59:04.077][22][debug][connection] external/envoy/source/common/network/connection_impl.cc:98] [C115] closing data_to_write=0 type=1
[2018-07-10 17:59:04.077][22][debug][connection] external/envoy/source/common/network/connection_impl.cc:133] [C115] closing socket: 1
[2018-07-10 17:59:04.077][22][debug][http2] external/envoy/source/common/http/http2/codec_impl.cc:470] [C4] sent reset code=0
[2018-07-10 17:59:04.077][22][debug][http2] external/envoy/source/common/http/http2/codec_impl.cc:515] [C4] stream closed: 0

[2018-07-10 17:59:04.081][23][debug][http2] external/envoy/source/common/http/http2/codec_impl.cc:635] [C116] setting stream-level initial window size to 268435456
[2018-07-10 17:59:04.081][23][debug][http2] external/envoy/source/common/http/http2/codec_impl.cc:657] [C116] updating connection-level initial window size to 268435456
[2018-07-10 17:59:04.082][22][debug][http2] external/envoy/source/common/http/http2/codec_impl.cc:515] [C13] stream closed: 0
time="2018-07-10T17:59:04Z" level=error msg="Error while sending alerts to user: rpc error: code = Canceled desc = context canceled" endpoint=SayHelloStream port=7788
time="2018-07-10T17:59:04Z" level=info msg="finished streaming call with code OK" application=greeter_server grpc.code=OK grpc.method=SayHelloStream grpc.service=helloworld.Greeter grpc.start_time="2018-07-10T17:57:48Z" grpc.time_ns=75546742896 peer.address="<IP_ADDRESS>:37642" span.kind=server system=grpc
[2018-07-10T17:57:48.528Z] "POST /helloworld.Greeter/SayHelloStream HTTP/2" 200 - 13 18 75548 - "-" "grpc-go/1.11.3" "54d8be58-d6ae-9176-9b55-83c10f184af8" "greeter-server:7788" "<IP_ADDRESS>:7788"

...

[2018-07-10 18:00:04.084][23][debug][connection] external/envoy/source/common/network/connection_impl.cc:98] [C116] closing data_to_write=0 type=1
[2018-07-10 18:00:04.084][23][debug][connection] external/envoy/source/common/network/connection_impl.cc:133] [C116] closing socket: 1
[2018-07-10 18:00:04.088][23][debug][http2] external/envoy/source/common/http/http2/codec_impl.cc:635] [C117] setting stream-level initial window size to 268435456
[2018-07-10 18:00:04.088][23][debug][http2] external/envoy/source/common/http/http2/codec_impl.cc:657] [C117] updating connection-level initial window size to 268435456

Which could be explained for each section as  :

the client opens the connexion to Envoy then to the server which receives a PING request
Envoy close the TCP connexion to the client and send a RESET to the server, ending the HTTP/2 stream (which is logged by the server).
client immediately re-open a connection to Envoy and re-negociate. This is done per gRPC specifications. As the client does not send anything, the stream is not propagated to the server
some time later, the TCP connexion is closed again and a new connexion takes place.

As the delay to close the TCP connexion is not constant, I doubt it is related to a connexion timeout of some sort. It look more of a routine doing some cleanups every once and a while...

I've added some more debug and it seems it's Envoy, reconfiguring it's config and dropping the socker, thus leading to a deconnexion :
[2018-07-10 19:21:04.064][16][debug][config] external/envoy/source/server/listener_manager_impl.cc:409] removing listener: name=<IP_ADDRESS>_7788, hash=12065677573634550975, address=<IP_ADDRESS>:7788
[2018-07-10 19:21:04.064][22][debug][connection] external/envoy/source/common/network/connection_impl.cc:98] [C154] closing data_to_write=0 type=1
[2018-07-10 19:21:04.064][22][debug][connection] external/envoy/source/common/network/connection_impl.cc:133] [C154] closing socket: 1

So the behaviour is that a refresh of the Listeners lead to the socket beeing recycled, which close the socket/TCP connexion between the sidecar and the client.
I stil don't know why this is happening...

I know why its happening. We don't have RDS in 0.8. Try with a more recent istio (snapshot release or something). This problem should go away.

thanks @rshriram, I will try that.
Can you please give a little more detail of what is happening there ? What is the link between RDS and Envoy recycling the Listener socket ?
Thanks.

Ok it's related to https://github.com/istio/istio/issues/5934#issuecomment-394864430 right ?

would image docker pull istio/proxy_debug:1.0.0-snapshot.0 solve the issue or should I build my own ?

OK I can confirm this bug is resolved using the image docker.io/istio/proxyv2:1.0.0-snapshot.0 for your sidecar (you have to change it in the istio-sidecar-injector configMap), the Istio-Pilot and both Ingress and Egress Gateways (to avoid errors)
I think we can close this for now.
Thanks @rshriram

Confirmed.
It was broken with 0.8 and working well with Istio 1.0.0-snapshot.2 - 1.0.0 Preview.

@prune998 what needs to change in the istio-sidecar-injector ConfigMap to make this work?


chore: move cache for buildx in docker actions

Description

Related Issue

Motivation and Context

Screenshots (if appropriate)
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Documentation Update (if none of the other choices apply)

Checklist

[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.

@yxxhero @hyy0322


Update to minecraft 1.19.2

This is an initial attempt to update the mod to 1.19.2. I'm opening this PR as a draft as the update is currently incomplete, it's missing the biome/worldgen related changes.
This is my first time ever touching a minecraft mod so let me know if i did anything wrong.

target branch mrh0:1.19.2

Also, currently working on some new stuff for the mod in the 1.18.2 branch

Just commenting on what's my current status, i've been looking at this sparingly and the current issues are:

Biomes went through a big revamp in 1.19 on how they're actually structured, there's no enumeration (as far as i've found) on which vanilla biomes exist, everything is now data driven.

My current idea is to move the beehive generation logic into biome modifier and use biome tags to do the placement picking, i think this should work...

I got to a point where i can launch the game and beehives do generate but i think there's still room for improvement:


🥲 Failed to load the model (in LM Studio)

HF Model Card
About Model:

Model Download Link (LM-Studio)

收到啦！


Simulate partial reflection for mirrors - Specify a percentage of light that goes through a mirror from each side [feature request]

Some mirrors in optics are designed to allow some amount of light to pass through. I think it would be great to be able to make such a specification for mirrors in the simulation.

There is a tool Mirror -> Beam splitter