feat: dutch locale

This adds a Dutch locale. Native speaker but I usually don't use software in Dutch. So some translations might be a bit forced...

@WolfgangAl I'm adding multilingual support to dayspan so everything will be localized. Here's a document you could fill out when you have time!
https://docs.google.com/document/d/1fQ-wGroi36-DSjXIqVRVlQJKJ3o87ax1lvI1kh005MY/edit?usp=sharing

I added the translations, hope it helps!

Thanks, you were wonderfully thorough and thanks for all the comments and explanations!

No problem!
BTW, in Dutch we have a formal/official way of handling dates and times and such, but we do suffer a lot from what we call 'Engelse ziekte' (English disease). It would be perfectly normal to see something like 'Q1 2019' for 'the first quarter of 2019', even though 'quarter' translates to 'kwartaal' so the 'Q' is a really weird abbreviation we just copied from English....
Also, I don't know if you're aware of this, but there is no international consensus about the separator character. See this lemma. Again, officially in Dutch you'd have 28-5-2019 for May 28th, 2019 but nowadays you'd also see 28/5/2019. Which makes something like 12/6/19 impossible to interpret in Dutch without context. Is it the American way of writing Dec 6? Or is it June 12th, just with US separator chars? Probably most people would interpret it as June 12th, but still...


The dataset VTON don't have 'test_pairs.txt', Thank you!

The dataset VTON don't have 'test_pairs.txt', Thank you!

I have the same problem.

https://github.com/sergeywong/cp-vton/tree/master/data
I found it in this project.

you also have to rename the folder of the downloaded dataset to "vton_resize", the folder initially is named "viton_resize".


not sure missing mandatory values for the csi parameters in the static provisioning

[
this page: https://github.com/kubernetes-sigs/azurefile-csi-driver/blob/master/docs/driver-parameters.md
it says below are mandatory, but the example in the static PV setup did not set them up.
so which one is correct?
volumeAttributes.storageAccount | existing storage account name | existing storage account name | Yes |
-- | -- | -- | -- | --
volumeAttributes.shareName | Azure file share name | existing Azure file share name | Yes
]

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: d634c63a-6194-86a6-b522-3310812c81e8
Version Independent ID: fa86da1e-9c86-88fe-170c-5e6aa9230b5f
Content: Manually create Azure Files share - Azure Kubernetes Service
Content Source: articles/aks/azure-files-volume.md
Service: container-service
GitHub Login: @MGoedtel
Microsoft Alias: magoedte

@minnieshi
Thanks for your feedback! We will investigate and update as appropriate.

@minnieshi
Thanks for bringing this to our attention.
I'm going to assign this to the document author so they can take a look at it accordingly
@MGoedtel
Can you please check and add your comments on this doc update request as applicable.

Thanks for providing feedback that helps improve our documentation. This issue has been resolved as part of an unrelated project last semester to edit/rewrite the AKS storage content and we are closing the issue. #please-close


[system-components]: Access theme values from system function

Hey 👋
I've been using system-components and mdx quite a bit, and I love it.  Thanks so much for creating these awesome tools.
I've come across an issue where I wanted to get access to my custom theme from within the system function.
I understand that system accepts a custom function but that raised some other issues.
I've simplified my use case to try try and illustrate what I'm trying to achieve.
Here's my issue:
I have a custom theme, with a space scale.
const theme = {
  space: [10, 40]
}

I have an element, to which I want to add some CSS Properties based off of this theme.
const H1 = system({
  is: 'h1',
  m: 1
})

So far so good 👍
My H1 Component is now being rendered as h1 and it has margin: 40px.
Now I'd like to add some border-bottom to my element:
const Title = system({
  is: 'h1',
  m: 1,
  borderBottom: '10px solid'
})

As expected, this also works. However, instead of hardcoding 10px I'd like to be able to use my space scale, as I do for margin.
I understand styled-system provides a themeGet helper function, so I tried using that.
I've tried passing a function to borderBottom:
const Title = system({
  is: 'h1',
  m: 1,
  borderBottom: `${() => themGet('space.0')}px solid`
})

But unfortunately this didn't work. I also tried: ${props => themGet('space.0')(props)}px solid.
My second attempt, was to use the custom function approach, which looks like this:
const Title = system(props => ({
  is: 'h1',
  m: 1,
  borderBottom: `${themeGet('space.0')(props)}px solid`
}))

So this kind of works, the dynamic border width is applied, but the is and m property are no longer working. (which sort of makes sense, given that this now just returning an object)
I understand I could replace m with margin and update its value to ${themeGet('space.1')(props)}px but now I lost access to the elegant API.
I've created a CodeSandbox demo so you can see an interactive demo.
Anyway, would anyone have any better ideas?
I'd love to hear your thoughts.
Thanks!

Do it like this:
const Title = system({
    is: 'h1',
    m: 1,
  },
  `
    borderBottom: ${props => themGet('space.0')(props)}px solid;
  `
})

The first system() argument is defaultProps. After that, any css strings are passed directly to styled-components.
Btw, system-components is now @rebass/components.

@flybayer hey 👊
Ahhh, I've actually been using system-components this whole time. I've also been referring to this docs.
I'm a bit confused now, maybe the API is different between system-components and @rebass/components but I had actually tried what you suggested, but that never worked.
I'm now giving @rebass/components` a go,  but that doesn't work either.
Are you able to provide me a working example?

Another syntax I"ve used is:
const Title = system({
    is: 'h1',
    m: 1,
  },
  props => ({
    paddingLeft: props.avatarUrl ? themeGet('avatarSizes.small', '32px')(props) : '16px',
  })
})

@lucastobrazil Thanks for your reply. In that case, I'll close this issue since system-components is no longer the recommended package. I created this issue on the rebassjs repo: https://github.com/rebassjs/components/issues/10
Maybe if you're familiar with it you could help me over there?
Thanks 👊


How to use object literals in array with no-object-literal-type-assertion?

Bug Report

TSLint version: 5.4.3
TypeScript version: 2.3.4
Running TSLint via: CLI

TypeScript code being linted
@NgModule({
  providers: [
    <FactoryProvider> {
      deps: [LOG_ROOT_FACTORY],
      provide: LOG_FACTORY,
      useFactory: createLogger,
    },
  ],
})

with tslint.json configuration:
"no-object-literal-type-assertion": true

Behavior
It complains about the <FactoryProvider>.
It would be nice to have an example how to use it in such cases. Should every provider hold as const?

Can you elaborate what the actual problem is?
Just remove the type assertion and everything should be fine. If there's a compile error without the assertion, there's probably something wrong with your code.
I know you use this pattern to get code completion inside the object literal. If that doesn't work without the assertion, that's better reported in the typescript repo.

It is just used for better code completion and I am just wondering how to declare it there.

Maybe this is related and eventually solves your issues: https://github.com/Microsoft/TypeScript/issues/16457


Update the docs to remove the mrtk_development specific warnings.

https://github.com/microsoft/MixedRealityToolkit-Unity/issues/5155
In preparation for release, these features are going to go live in the latest release, so these warnings are no longer relevant.
Going forward we should have separate versions for our docs to make this exercise not necessary

/azp run mrtk_docs


build(css): extract css into standalone bundle

BREAKING CHANGE requiredcss moved into separate file

Yeah, I was gonna update this pr with the new requirements.
Probably update the minimum example, and a note about how we are doing CSS.
On Tue, Jul 11, 2017 at 6:11 PM Oscar<EMAIL_ADDRESS>wrote:

@obartra approved this pull request.
This is perfect. Should we also update the readme? I can take care of the
wiki
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/obartra/reflex/pull/172#pullrequestreview-49368657,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AIV0biDWv3IIs9jHsY8gLfplSXhGQbDQks5sNB0TgaJpZM4OU-OP
.

Sounds good, after you add these changes feel free to merge 👍


Cause Error when using rectifier as activation function.

Dear Yajie.
I used pdnn for deep learning.
It works fine but when I used 'rectifiler' as activation function, it cause following error.

cPickle.dump(cfg, output, cPickle.HIGHEST_PROTOCOL)
cPickle.PicklingError: Can't pickle <type 'function'>: attribute lookup builtin.function failed
I guess, this error be caused by rectifier function is defined as lambda function.
Please give me some advice if you do not mind.
Regards.

Hello, I just made the following changes which should solve the problem
https://github.com/yajiemiao/pdnn/commit/6e6e840bf3f0411d134ead161485157ec8bdff82


buildozer can't download python libs due to ssl certificate check fail

When I try to build a project for android it shows me an error:
Modules changed to hostpython python sdl pygame pyjnius android kivy
Pure-Python modules changed to
Run get packages
Download package for hostpython
Downloading http://python.org/ftp/python/2.7.2/Python-2.7.2.tar.bz2
--2014-12-02 10:26:12--  http://python.org/ftp/python/2.7.2/Python-2.7.2.tar.bz2
Resolving python.org (python.org)... <IP_ADDRESS>, 2001:4802:7901::e60a:1375:0:5
Connecting to python.org (python.org)|<IP_ADDRESS>|:80... connected.
HTTP request sent, awaiting response... 301 Moved Permanently
Location: https://python.org/ftp/python/2.7.2/Python-2.7.2.tar.bz2 [following]
--2014-12-02 10:26:12--  https://python.org/ftp/python/2.7.2/Python-2.7.2.tar.bz2
Connecting to python.org (python.org)|<IP_ADDRESS>|:443... connected.
ERROR: The certificate of ‘python.org’ is not trusted.
ERROR: The certificate of ‘python.org’ hasn't got a known issuer.
Command failed: ./distribute.sh -m "kivy" -d "mymath"
I have upgraded pip to version 1.5.6 but the error is still the same. I've downgraded pip to 1.5.2 and it shows me the same error message

---
Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/6850994-buildozer-can-t-download-python-libs-due-to-ssl-certificate-check-fail?utm_campaign=plugin&utm_content=tracker%2F42681&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F42681&utm_medium=issues&utm_source=github).

Why not skip root cert checking by default to make it failsave?

The issue is not there with an updated certificate chain.


Pandas UDF Support

Are there any plans to support Pandas UDF, when I try to implement it, currently I can't access the get_decoder method to use in pandas?

Can you provide an example of how you are using it?


MIT license?

I noticed that there is no license attached to this library. May i suggest licensing it under the MIT license and dropping a LICENSE.md file in the repo with a copy?
https://opensource.org/licenses/MIT has a good copy.
This could have been a pull request but it is more appropriate for the original author to explicitly state the license under which the code is released.

@BlakeGardner Thanks for starting this topic, as a newbie to opensource community, it was always my question that when MIT almost allows anything to do without restrictions, so why it even matters including MIT or not ?

@pi0 It matters because some software developers work for companies with legal departments that have to do checks on any software component used for compliance reasons. If there is no license attached then adoption of the library would be impossible without clarification in writing.
TL;DR Legal is a good resource as well.


feat: add support for notify_users to snowflake_resource_monitor resource

This PR adds support for managing the notify_users attribute on resource monitors via the snowflake_resource_monitor Resource. It does not include any changes to the snowflake_resource_monitors Data Source.
Test Plan

[x] internal tests
[x] unit tests
[ ] acceptance tests

All new and existing tests pass, though one new test is a bit special and worth calling out explicitly.
The new test in pkg/resources/resource_monitor_acceptance_test.go is particularly tricky, as the users listed must have a verified email address. As far as I know, this verification process may only be completed manually via the Snowflake interface. To circumvent this, that test depends on a new RESOURCE_MONITOR_NOTIFY_USERS_TEST environment variable. If the variable is unset, or set to the empty string, the test will be skipped (similar to the SKIP_* variable for many other acceptance tests). However, if the variable is set, it is expected to be a comma-delimited list of users that already exist with verified email addresses. Open to suggestions on how this can be improved.
References

https://github.com/Snowflake-Labs/terraform-provider-snowflake/issues/1068
https://docs.snowflake.com/en/sql-reference/sql/create-resource-monitor.html#optional-parameters

@nafarlee this looks good. Thank you for your contribution!
Without a better SDK we don't really have a way to validate emails easily.
I am planning to rethink some of these environment variables since they are starting to clutter up the test cases. I will eventually go through and redo these in a different way. Maybe have a .env file with default values or detect whether the account is standard of enterrpise during provider initialization and enable / disable tests as a result.

@sfc-gh-swinkler You are welcome! I am far from experienced with Snowflake, so I don't have a good sense for how difficult/inconsistent automatic detection would be. Personally, a .env that centralizes the options and their individual "considerations" would be a helpful stopgap


drag start not emitting events

I need to get on dragStart event on sortable. I see it's in the code but it's commented.
Any particular reason? Could we have this enabled?
Thanks so much

Yes, of course.
I will make changes today and let you know.
On 8 June 2016 at 11:47, Salvador Subarroca<EMAIL_ADDRESS>wrote:

I need to get on dragStart event on sortable. I see it's in the code but
it's commented.
Any particular reason? Could we have this enabled?
Thanks so much
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/akserg/ng2-dnd/issues/26, or mute the thread
https://github.com/notifications/unsubscribe/ABVeWR_Uz6P_vEJ5SVbbphJ41C4-kNatks5qJo-ggaJpZM4Iwx-q
.

great! thanks a lot!

Fixed in 1.8.1.
Please confirm and close the issue.

Why is this not availble for ng-draggable as well? I want to visually display the possible targets not only on dragOver.

Ok, I will add dragStart and dragEnd emitters to the DraggableComponent. Anything else?

Perfect thanks, other than issue #25 everything is fine.

works like charm. Thank you very much!


Improve resource generator to insert the resource into actions/app.go

This is no longer an issue as it adds the resource to the app from within the resource file itself.


Decrease the interval between checking if OCR jobs are complete for Azure

Basically, remove the Task.delays in AzureOCRService.cs, or make them shorter.

update it in branch v.1.1.2


VPC peering example should include reverse route

Without a route set at the AWS provider side, agents can't reach hosts
on the HCP HVN and using the private URL will fail

Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement
Learn more about why HashiCorp requires a CLA and what the CLA includes
Have you signed the CLA already but the status is still pending? Recheck it.


create stream: Show current user in "People to add" list

Fixes #7475

@timabbott Thanks for reviewing!
Changes made in PR:

Current user will be shown on top on People to add list
By default current user's checkbox will be checked
If user try to create a stream in which he/she is not subscribed, then the warning box will appear to warn user, saying You are not subscribed to stream with two options Go back and Yes, create stream

For information, this can create a scenario where user try to create a private stream, in which he/she is not subscribed.

As per the discussion here, I have remove the warning.
Ready for review!!

As per the discussion here, removed warning for You are not subscribed to stream.

Ready for review!!

@rishig can you review this one?

Just created a PR with a few minor fixes and fixed the up into your commit. Looks good @YJDave!

fixed via ffe3776


Short solution needed: "Check Redis connection" (php-redis)

Please help us write most modern and shortest code solution for this issue:
Check Redis connection (technology: php-redis)
Fast way
Just write the code solution in the comments.
Prefered way

Create pull request with a new code file inside inbox folder.
Don't forget to use comments to make solution explained.
Link to this issue in comments of pull request.

Check Redis connection


Do not explicitly create threads in PacketQueue

Do not explicitly create threads in PacketQueue, but borrow threads for execution from ExecutorService.
Currently there is one inheritor from ice4j's PacketQuque<T> which is RawPacketQueue in libjitsi used by SctpConnection in videobridge.
It is observed that currently there is N threads created to process queues created by SctpConnection. N is the total number of peers connected to JVB. Most of the time threads are idle and blocked in wait(100) inside while(true) loop inside empty PacketQueue.
This pull request enhances implementation of PacketQueue which now temporary borrows execution thread from shared ExecutorService and return thread back to pool when there is no work, this results in less threads used and better usage of existing threads managed by ExecutorService.
As comment at the header of PacketQueue states:
 * An abstract queue of packets. This is meant to eventually be able to be used
 * in the following classes (in ice4j and libjitsi) in place of their ad-hoc
 * queue implementations (which is the reason the class is parameterized):
 *
 RTPConnectorOutputStream.Queue
 *
 PushSourceStreamImpl#readQ
 *
 OutputDataStreamImpl#writeQ
 *
 SinglePortHarvester.MySocket#queue
 *
 MultiplexingSocket#received (and the rest of Multiplex* classes).
 *
 * @author Boris Grozev
 */

This PacketQueue implementation could also dramatically reduce thread usage and enhance overall system performance when aforementioned classes migrated from ad-hoc queue implementations to PacketQueue.
Current implementation allow switching between different ExecutorService implementations: depending on actual handler work, different ExecutorService implementation might give different overall performance.
Summary:

Implementation temporrary borrow execution thread from configurable ExecutorService instead of explicit thread creation and waiting when no items in queue to proceed.
Throttling functionality was added to satisfy requirements of future move of RTPConnectorOutputStream.Queue to PacketQueue
Due to ExecutorService is usually shared between many queues the support of cooperative multi-tasking was added (queue temporary stops it's processing to give execution time to other queues which might work on same ExecutorService)
Unit tests of PacketQueue was added
Benchmark to compare different ExecutorService performance was added. The comparison with baseline implementation added as en example to different branch in my fork.

Some of micro-benchmark results on my machine (there are too many variations of numberOfQueues/numberOfItemsInQueue/singleQueueItemProcessingWeight to provide all of them):

change set
PR #157

OS
Ubuntu 18.04, 4.13.0-46-generic

CPU
i7-4790 CPU

RAM
16 Gb

iterations
100

numberOfQueues
1200

numberOfItemsInQueue
1000

singleQueueItemProcessingWeight
300

ThreadPerQueuePool
avg = 1371 ms, std_dev = 1 ms

CachedThreadPerQueuePool
avg = 1271 ms, std_dev = 0 ms

FixedSizeCPUBoundPool
avg = 1229 ms, std_dev = 0 ms

ForkJoinCPUBoundPool
avg = 1223 ms, std_dev = 0 ms

PacketQueueOld
avg = 1427 ms, std_dev = 1 ms

change set
PR #157

OS
Ubuntu 18.04, 4.13.0-46-generic

CPU
i7-4790 CPU

RAM
16 Gb

iterations
100

numberOfQueues
800

numberOfItemsInQueue
1000

singleQueueItemProcessingWeight
300

ThreadPerQueuePool
avg = 925 ms, std_dev = 2 ms

CachedThreadPerQueuePool
avg = 846 ms, std_dev = 0 ms

FixedSizeCPUBoundPool
avg = 821 ms, std_dev = 0 ms

ForkJoinCPUBoundPool
avg = 763 ms, std_dev = 0 ms

PacketQueueOld
avg = 923 ms, std_dev = 1 ms

change set
PR #157

OS
Ubuntu 18.04, 4.13.0-46-generic

CPU
i7-4790 CPU

RAM
16 Gb

iterations
100

numberOfQueues
400

numberOfItemsInQueue
1000

singleQueueItemProcessingWeight
300

ThreadPerQueuePool
avg = 446 ms, std_dev = 0 ms

CachedThreadPerQueuePool
avg = 422 ms, std_dev = 0 ms

FixedSizeCPUBoundPool
avg = 413 ms, std_dev = 0 ms

ForkJoinCPUBoundPool
avg = 411 ms, std_dev = 0 ms

PacketQueueOld
avg = 473 ms, std_dev = 1 ms

change set
PR #157

OS
Ubuntu 18.04, 4.13.0-46-generic

CPU
i7-4790 CPU

RAM
16 Gb

iterations
100

numberOfQueues
200

numberOfItemsInQueue
1000

singleQueueItemProcessingWeight
300

ThreadPerQueuePool
avg = 238 ms, std_dev = 0 ms

CachedThreadPerQueuePool
avg = 191 ms, std_dev = 0 ms

FixedSizeCPUBoundPool
avg = 207 ms, std_dev = 0 ms

ForkJoinCPUBoundPool
avg = 209 ms, std_dev = 0 ms

PacketQueueOld
avg = 240 ms, std_dev = 1 ms

change set
PR #157

OS
Ubuntu 18.04, 4.13.0-46-generic

CPU
i7-4790 CPU

RAM
16 Gb

iterations
100

numberOfQueues
100

numberOfItemsInQueue
1000

singleQueueItemProcessingWeight
300

ThreadPerQueuePool
avg = 121 ms, std_dev = 0 ms

CachedThreadPerQueuePool
avg = 113 ms, std_dev = 0 ms

FixedSizeCPUBoundPool
avg = 98 ms, std_dev = 0 ms

ForkJoinCPUBoundPool
avg = 106 ms, std_dev = 0 ms

PacketQueueOld
avg = 122 ms, std_dev = 0 ms

change set
PR #157

OS
Ubuntu 18.04, 4.13.0-46-generic

CPU
i7-4790 CPU

RAM
16 Gb

iterations
100

numberOfQueues
5000

numberOfItemsInQueue
400

singleQueueItemProcessingWeight
300

ThreadPerQueuePool
avg = 2196 ms, std_dev = 17 ms

CachedThreadPerQueuePool
avg = 2179 ms, std_dev = 2 ms

FixedSizeCPUBoundPool
avg = 2057 ms, std_dev = 0 ms

ForkJoinCPUBoundPool
avg = 1900 ms, std_dev = 0 ms

PacketQueueOld
avg = 2541 ms, std_dev = 12 ms

@bbaldino could you please review this PR when you have time 😃. Thank you very much in advance!

Adding performance measurements comparison with my previous PRs.
See additional tables in #154 and #155.
As a baseline I've used previosly measured version with my not yet merged PR: #154, #155
20 conferences x 3 peers - baseline

Name
Value
Comment

Computer:
3 GHz Intel Core i7 mac mini, osx 10.14

JVB version:
1.1-20180615.220358-69

ice4j version:
2.0.0-20181105.145933-16
# with PR 154, 155

org.ice4j.TERMINATION_DELAY, ms
604800000

Conf per server:
20

Peers per conf:
3

Est. RTP streams:
180

CPU load:
50-64%

Active threads:
789

Network IN:
~2431 KBit/s

Network OUT:
~4878 KBit/s

Average RTT:
3-28-ms

ICE connection stability:
stable

20 conferences x 3 peers - libjitsi #445 + ice4j #156 & #157

Name
Value
Comment

Computer:
3 GHz Intel Core i7 mac mini, osx 10.14

JVB version:
1.1-20181017.180330-93
# even so I've changed version here, I've checked that actual performance gain was due to

ice4j version:
2.0.0-20181105.145933-16
# with PR 154, 155

org.ice4j.TERMINATION_DELAY, ms
604800000

Conf per server:
20

Peers per conf:
3

Est. RTP streams:
180

CPU load:
48-61%

Active threads:
680

Network IN:
~2440 KBit/s

Network OUT:
~4887 KBit/s

Average RTT:
~3-5 ms

ICE connection stability:
stable

30 conferences x 3 peers - baseline

Name
Value
Comment

Computer:
3 GHz Intel Core i7 mac mini, osx 10.14

JVB version:
1.1-20180615.220358-69

ice4j version:
2.0.0-20181105.145933-16
# with PR 154, 155

org.ice4j.TERMINATION_DELAY, ms
604800000

Conf per server:
20

Peers per conf:
3

Est. RTP streams:
180

CPU load:
99-100%

Active threads:
1177

Network IN:
~2659 KBit/s

Network OUT:
~5346 KBit/s

Average RTT:
~946-1040 ms

ICE connection stability:
stable

30 conferences x 3 peers - libjitsi #445 + ice4j #156 & #157

Name
Value
Comment

Computer:
3 GHz Intel Core i7 mac mini, osx 10.14

JVB version:
1.1-20180615.220358-69

libjitsi
1.0-20180904.192703-363
# plus PR 445

ice4j version:
2.0.0-20181105.145933-16
# with PR 154, 155

org.ice4j.TERMINATION_DELAY, ms
604800000

Conf per server:
20

Peers per conf:
3

Est. RTP streams:
180

CPU load:
85-98%
# mostly around 89 %

Active threads:
999

Network IN:
~3464 KBit/s
# please note gain here

Network OUT:
~6903 KBit/s
# and here, looks like earlier it was unable to handle such load properly

Average RTT:
~10-1400 ms
# mostly stay low values like ~ 10 ms

ICE connection stability:
stable

Started work on moving RTPConnectorOutputStream into PacketQueue, added releasePacket as opposite to createPacket in last commit to simplify pooling implementation.

Jenkins, test this please

Jenkins, test this please

@mstyura apologies about last week, it ended up getting taken over by orientation stuff.  At this point I think I've lost track of everything you've got in flight here, could you kinda summarize things for me?  I think you responded to my question about test harnesses too but I can't remember which PR it was.  Maybe starting a discussion in the jitsi community would be the best place.

At this point I think I've lost track of everything you've got in flight here, could you kinda summarize things for me?

@bbaldino ok, I'll try to summarize:
There are several pending merge request from me: #154, #155, #156, #157, jitsi/libjitsi#445 which I've proposed to make single machine handle more audio-only conferences in my environment.
The state of PRs is the following:

#154 - it looks like it was reviewed by you, because I see questions in discussion, but there was not much comments about code itself. So it think you are still going to look to it and ask to make some changes before merge.

#155  - there was some questions regarding change which I've addressed - like pooling and threads count. Not sure if you have looked at latest revision.

#156 - there was some questions regarding backward compatibility, since it's not very important PR for me as compared to all other I'll fix it later, for now postponing it by marking WIP

#157 - looks like no one reviewed this PR yet because lack of comments, but it's one of the strongest: with unit tests, micro-benchmark and it might be a good base for other PRs which will move additional classes to PacketQueue.

jitsi/libjitsi#445 - looks like no one reviewed it yet.

I think you responded to my question about test harnesses too but I can't remember which PR it was.

It was in #155

Maybe starting a discussion in the jitsi community would be the best place.

let's see how it will go when new question will arise if any. Since both of us are online now and I'll try to be online for next 3 hours maybe we could proceed quicker with comments here on GitHub or some IM app (skype, whatsapp, whatever quicker than comments)

Hey Yury, thanks.  The mini benchmark here looks like a good start, though I'm confused at all the results...which is the one you ended up implementing?  I assume PacketQueueOld is the original code?  I also think we'd like to see something that tests at a higher level...i.e. actually runs an ice agent and a client and does some sort of throughput test.  We'd want to test both a single connection, but also multiple (since a lot of these changes are re-using a single thread across many connections, so there may be regressions there).
Also, I'm trying to get through these but please (continue to) be patient, as they're quite dense and I don't think I'm as fresh with the ice4j code as you are at this point :) Thanks again for all the work.

which is the one you ended up implementing?

@bbaldino I've ended up implementing PacketQueue class which has configurable - it is possible to use it with different ExecutorService implementations. The micro-benchmarks are just an example of different performance when PacketQueue is configured with different ExecutorService.

I assume PacketQueueOld is the original code?

Yes

I also think we'd like to see something that tests at a higher level...i.e. actually runs an ice agent and a client and does some sort of throughput test.

It is not possible because, currently this class is not used in ice4j. It is only used in SctpConnection in videobridge via RawPacketQueue defined in libjitsi.

We'd want to test both a single connection, but also multiple (since a lot of these changes are re-using a single thread across many connections, so there may be regressions there).

Even with single user of this class currently to not introduce any regression caused by limiting number of threads I've chosen ExecutorService newCachedThreadPool() as a default ExecutorService implementation.

Also, I'm trying to get through these but please (continue to) be patient, as they're quite dense and I don't think I'm as fresh with the ice4j code as you are at this point :)

Please consider all PR as independent one by one, maybe it would be easier to handle and not to be overloaded with my changes.

Jenkins, test this please

Good day, @bbaldino, could you please have a look at this PR?
Here is performance comparison with latest ice4j master:
before

Name
Value
Comment

VM CPU
2 cores Intel(R) Xeon(R) CPU E5-2630 v2 @ 2.60GHz

RAM
4 Gb

OS
CentOS Linux release 7.5.1804 (Core)

JVB version:
1.1-20180615.220358-69
# old version, i know

libjitsi version:
1.0-20180607.160234-352

ice4j version:
2.0.0-20181129.205550-18
# latest master

org.ice4j.TERMINATION_DELAY, ms
604800000

Conf per server:
25

Peers per conf:
5

Est. RTP streams:
625

CPU load:
89 - 95 %

Active threads:
1406

RTP loss rate download
0%

RTP loss rate upload
< 2.7 %

Network IN:
~ 4866 KBit/s

Network OUT:
~ 19503 KBit/s

Average RTT:
5-15 ms

ICE connection stability:
stable

after

Name
Value
Comment

VM CPU
2 cores Intel(R) Xeon(R) CPU E5-2630 v2 @ 2.60GHz

RAM
4 Gb

OS
CentOS Linux release 7.5.1804 (Core)

JVB version:
1.1-20180615.220358-69
# old version, i know

libjitsi version:
1.0-20180607.160234-352

ice4j version:
2.0.0-20181129.205550-18
# + PR 157

org.ice4j.TERMINATION_DELAY, ms
604800000

Conf per server:
25

Peers per conf:
5

Est. RTP streams:
625

CPU load:
90-94 %

Active threads:
1288
# org.jitsi.util.RawPacketQueue-SctpConnection-* were gone

RTP loss rate download
0%

RTP loss rate upload
< 1.7%
# get lower for some reason

Network IN:
~ 4903 KBit/s

Network OUT:
~ 19680 KBit/s

Average RTT:
4 - 11 ms
# get lower for some reason

ICE connection stability:
stable

BTW, I had a brief look into nlj, seems like very similar problem were solved, but slightly differently in RtpreceiverImpl.kt and in RtpSenderImpl.kt 😄
I could probably "backport" this PR as a generic class for nlj or (maybe even better) split current PacketQueue implementation into queue and something like AsyncMessageHandler<TMessage>, so nlj could use generic queue handler as well, instead of implementing it's own.
Anyway I believe that for now the change is still quite useful for ice4j as is.
Thank  you very much, Brian!

Jenkins, test this please

Good day, @bbaldino!
I've verified what you've asked: the proposed implementation does not have a problem of eating CPU for polling when PacketQueue does not have work. Thread borrowing from ExecutorService confirmed to be triggered only when item is added to queue. I've also added unit test to check that ExecutorService thread is not used, when PacketQueue completed handling it's items. Test confirms that millions of PacketQueue instances can share single thread.
Could you please review PR and see if anything else need to be fixed before getting your approval?
Thank you very much, Brian!

Good day, @bbaldino!
You've asked me in one of the previous pull request if I have a working solution to do load testing videobridge. My answer at that time was "yes, but my load solution relies on my custom REST API around JVB". Even so I have a solution to load JVB and could share it, it will not be very useful, because I can not share REST API wrapper part (and nobody need it except me).
Recently there was a new project appeared which is capable of load testing JVB with audio-only conferences via standard colibri-based REST API. This project is very-very similar to what I use for load-test JVB via my custom REST API, when I provide comparison tables in PRs.
So, you might try using it and it might be eventually adopted by jitsi as a replacement of (AFAIK) not currently supported jitsi-hammer.
I hope that ability of doing load testing over latest videobridge with above-mentioned tool will have positive influence on speed of accepting different performance-related PR 😄 .
Hope you'll have a change to take a looks at this PR today 🤞 .
Thank you very much, Brian!

Hey @mstyura, thanks for the link, that's very interesting.  Could it support video as well?  I don't know if I will have time to look at this today, as it's quite dense and I need some time to go through it and I'm still trying to focus on the new bridge work.

Could it support video as well?

Right now video is not supported, but support could be added relatively easily.

Could it support video as well?

Right now video is not supported, but support could be added relatively easily.

Ah, that's very exciting.  We've been using a selenium but it's reliability isn't the best.  I'll have to take a look at the project.

Good day, @bbaldino!
I've extracted the queue reading logic into dedicated class AsyncQueueHandler<T> (former AsyncPacketReader) from PacketQueue<T>.
I do like a lot this change which you proposed, because it made logic inside AsyncQueueHandler<T> reusable and it is as well significantly reduced diff inside PacketQueue<T> which made it simpler to review. Don't be scared by amount of added lines in diff, most of them comes from unit tests and benchmark. The rest of the code of AsyncQueueHandler you probably already seen earlier.
I still preserved throttling logic, because I absolutely need it in old libjitsi, until new one is ready and stable. I don't mind removing it later, it should easy to done.
Could you please review changes today? I'll be online until 13.00 PST and could quickly react on questions and other fixes you might ask to implement.
Thank you very much, Brian!

Jenkins test this please

hey @mstyura i am going to try and look at these today.  i planned to first thing this morning but another issue has come up that needs to be looked at first.  hopefully i'll be able to look at this today, though.
yes i'd like to be able to use the AsyncReader logic in the new bridge as a good compromise between non-blocking threads and not constantly polling and therefore using too much cpu, so i'd like to be able to get it in so i can use it.

Don't worry about those test failures, there is a known issue with the torture tests right now that's being worked on.

If there are some necessary changes required before accepting this PR feel free to add fixing commits to this PR, because I'm likely to be not available later today.

@bbaldino I think I'm done, the only unresolved question is about running flag in comment, so waiting for your reply to it.

thanks @mstyura, i think this looks good now.  I'm just trying to clarify something about the license that should be included in the new file.

@bbaldino is there any known issue with Jenkins builder such that new version of ice4j is not in jitsi/jitsi-maven-repository?

@mstyura we're transitioning some infrastructure right now, so the jenkins builders are paused.  we're hoping to have things back up tomorrow.

I was enabling back ice4j build and I ran into this:
[INFO] -------------------------------------------------------------
[ERROR] COMPILATION ERROR :
[INFO] -------------------------------------------------------------
[ERROR] /mnt/bigci/jobs/ice4j/workspace/ice4j/src/main/java/org/ice4j/stack/MessageProcessor.java:[89,66] cannot find symbol
symbol:   method getMessageQueue()
location: variable netAccessManager of type org.ice4j.stack.NetAccessManager
[INFO] 1 error
[INFO] -------------------------------------------------------------
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
It builds fine locally ... but I have a problem compiling it on the ci machine.

Hi, @damencho,
The log suggest that the compilation issue caused by #155, because I've removed this method.

@mstyura but I still do not get it, why locally it is ok and on the ci machine it fails. Latests source and same java versions on both places ... and by not seeing what is a problem, I'm wondering how to fix ci so it can produce new build :P

@damencho sounds like git checkout went wrong on CI, because this file had to be removed and not included into compilation: https://github.com/jitsi/ice4j/tree/master/src/main/java/org/ice4j/stack - no such file here, but only MessageProcessingTask.java. Can you ssh on CI and check an output of git status?

Good guess ... at some point we were doing some rsync which didn't delete files ... Thanks. Build is comming in maven ... :)


Format server stdout

ISSUE: https://github.com/este/este/issues/479

Nice one. @steida wdyt?

LGTM

:+1:

Nice, but too much code just for colors.


Fix display of two list-of-users modals

These two modals (which are very similar, and maybe should be
combined) both had a problem where in some cases and in some display
sizes they looked weird.  The commit button could render outside the
bounds of the modal, the header text wasn't visually centered within
the header, and the close box was weirdly aligned with the rest of the
header.  Fix those things.

#157  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @flooey and the rest of your teammates on  Graphite


[core] [pages.class.php] $dbFields: Switch to protected

Describe your problem
I want to expand the fields in child classes to create new types of content.
Private $dbFields make it difficult.
https://github.com/bludit/bludit/blob/master/bl-kernel/pages.class.php
Solution:
class Pages extends dbJSON {
	private $parentKeyList = array();
	/*private*/ protected $dbFields = array(

This issue was implemented in 3.7.1. thanks


test: add not matching sectioName test

What type of PR is this?
Add conformance test.

What this PR does / why we need it:
Which issue(s) this PR fixes:

Fixes https://github.com/kubernetes-sigs/gateway-api/issues/1719#
Does this PR introduce a user-facing change?:

NONE

/hold until https://github.com/kubernetes-sigs/gateway-api/pull/1730#discussion_r1107918097 gets fixed.

/hold until #1730 (comment) gets fixed.

fixed

/hold cancel


The Discord Server Link in documentation no longer works

https://discord.gg/zMtMQ2vUUa returns an invite invalid

Oh, it has to be invalid for a long time... I pasted a link used on the GitHub page for years :)
Thanks for the report! :)


[Bug]: Jenkins Analysis Task unable to extract password

What steps will reproduce the bug?

K8s Cluster running Jenkins Helm chart: https://github.com/jenkinsci/helm-charts
Running dftw recipe dftimewolf gcp_turbinia_disk_copy_ts
Disk containing Jenkins pod gets processed through Turbinia pipeline.
JenkinsAnalysisTask does not pick up on the Jenkins configuration.

What is the expected behavior?
JenkinsAnalysisTask identifies a weak Jenkins password
What do you see instead?
JenkinsAnalysisTask returns:
No Jenkins instance found
Jenkins version: Unknown

Additional information
Checking inside the Jenkins pod
jenkins@jenkins-0:/$ find . -name config.xml
./var/jenkins_home/users/jenkins_10477391727943582798/config.xml
./var/jenkins_home/config.xml

Grepping for field in first file
jenkins@jenkins-0:/$ cat ./var/jenkins_home/config.xml  | grep password
No results...

Grepping for field in second file
jenkins@jenkins-0:/$ cat ./var/jenkins_home/users/jenkins_10477391727943582798/config.xml | grep password
              <password>{PW_STRING}</password>
      <passwordHash>#jbcrypt:$2a$10$/EH.PW_STRING</passwordHash>

jenkins@jenkins-0:/$ cat ./var/jenkins_home/users/jenkins_10477391727943582798/config.xml | grep fullName
  <fullName>Jenkins Admin</fullName>

I would have expected the JenkinsAnalysisTask return a weak password for the second field.

Verifying the regex used to get the artifact:

it matches the filepath of the config.xml
-- ./var/jenkins_home/users/jenkins_10477391727943582798/config.xml
regex: https://github.com/google/turbinia/blob/master/turbinia/workers/analysis/jenkins.py#L75

Currently k8s (GKE in this case) writes any secret that is needed in a file to a small disk (8GB). Please verify that you copied all disks to make sure you get the config.xml
It is present in the node, but it is stored in a different disk that is mounted on the node (at least on GKE).

Updating per forgetting to add --all_disks flag to dftimewolf recipe.
Now it detects the Jenkins version but is unable to extract the password even though it was set as jenkins:jenkins
status": "Jenkins version 10 found with 1 credentials, but no issues detected",


Significant drop in recall for int8 scalar quantization using maximum_inner_product

Description
While running some benchmarking tests using opensearch-benchmark on int8 scalar quantization using some of the standard datasets, I observed that there is a significant drop in recall with max inner product space type when compared with other space types.
Here are some of those results

Beam Width
Max Connections

100
16

S. No.
Datasets
Dimension of Vector
Train Data Size
Query Data Size
Space Type
fp32 hnsw Recall@100
sq int8 Recall@100

1
cohere-768-l2
768
1M
10K
L2
0.94
0.87

2
cohere-768-IP
768
1M
10K
Inner Product
0.94
0.36

3
lastfm-64-dot
65
292,385
50K
Inner Product
0.95
0.16

4
glove-200-angular
200
1,183,514
10K
cosine
0.74
0.60

5
glove-100-angular
100
1,183,514
10K
cosine
0.80
0.59

6
glove-50-angular
50
1,183,514
10K
cosine
0.89
0.56

The cohere-768-IP dataset can be downloaded from this link. The L2 version of cohere dataset is generated from the same dataset by recomputing ground truth. Rest all datasets are downloaded from here
Version and environment details
No response

@benwtrent Are you aware of this recall issue with IP using SQ int8?

@naveentatikonda interesting results for sure. I tested with max-inner-product & CohereV2 and didn't see a drop like this. I will try and replicate.
The cohere-768-IP, this was coherev2 correct?

The cohere-768-IP, this was coherev2 correct?

@benwtrent Thanks for your response. I'm not exactly sure about the version of it. But, this is the dataset.
https://huggingface.co/datasets/Cohere/wikipedia-22-12-en-embeddings
Using the link I shared in the description, we can download a 1 million vector dataset of this in hdf5 file format.

@naveentatikonda using lucene-util, scalar quantization, I get a recall@100 of 0.735.
I am calculating the recall by gathering the true 100 nearest neighbors from the test queries given the training docs given max-inner-product. Then I compare the overlap with 100 nearest neighbors found via scalar quantized HNSW.
 Maybe I need to kick off some more merges.
Do you force-merge to a single segment?

@naveentatikonda using lucene-util, scalar quantization, I get a recall@100 of 0.735.

This looks much better. I will try to set it up and reproduce with lucene-util.

 Maybe I need to kick off some more merges.

Sorry, I'm not sure how to set the flush buffer size and I don't think we control this parameter from opensearch.

Do you force-merge to a single segment?

Yes, I was actually using a single node cluster with 8 shards force merged to single segment.

OK, I ran it again, on my index where the flush was set at 28MB & force merged. This time I ran it over all 10k queries (previously it was just 1k, as calculating the true nearest neighbors takes significant time).
Recall@100 is a stead: 0.738.

OK, I ran it again, on my index where the flush was set at 28MB & force merged. This time I ran it over all 10k queries (previously it was just 1k, as calculating the true nearest neighbors takes significant time).
Recall@100 is a stead: 0.738.

@benwtrent Sorry for the delay in my response. Can you share more details about the dataset you used to get this recall. Is it a subset of this Cohere-wikipedia-22-12-en-embeddings dataset. I mean is the training data the first million vectors and the query data is the next 10k vectors ? If possible can you please share your dataset and the ground truth you generated through github or huggingface.
Also, have you force merged to 1 segment before running the search queries?

@naveentatikonda I used the dataset you linked. I simply downloaded the file.
Ground truth is just the brute force nearest neighbors. I used the "test" set as the queries (10k of them) and "train" (1M) for the docs. Computing the true NN.
Yes, I force merged. I imagine if I didn't, recall would actually be higher.

@benwtrent I tried to setup luceneutil but I was running into a ton of compilation errors when building it against latest lucene src code. I have a doubt in the existing quantization process of quantizing a float value in a vector.
// For 8 bits, this logic quantizes float value into uint8 range in the form of floats [0.0, 255.0]

float dx = v - minQuantile;
float dxc = Math.max(minQuantile, Math.min(maxQuantile, v)) - minQuantile;
float dxs = scale * dxc;

Here to bring it into signed int8 range of [-128, 127] we are casting it into byte. But, this leads to change of sign and magnitude for values > 127 and < 255 like 128 will be casted as -128 and 129 as -127 and so on...Is this a right way of quantizing because for spacetypes like inner product the sign matters when we are computing the distance and score ?
dest[destIndex] = (byte) Math.round(dxs);

I have added a simple unit test to show that because of this type casting, even if we dequantize the quantized vector we don't get the original vector back.
Also, the corrective offset calculation correlates with the mathematical derivation in documentation. But, for max inner product I have a simple example which is reranking the results because of this corrective offset.
minQuantile * (v - minQuantile / 2.0F) + (dx - dxq) * dxq

Let,
V1 -> [-100.0, 20.0]
V2 -> [100.0, 20.0]
Query Vec -> [100.0, 20.0]

When we perform search against float vectors, the ranking of results are  V2, V1 with score calculation as
Q.V1 -> 1/(1+10400) = 0.00009614
Q.V2 -> 10401

When these vectors are quantized with minQuantile as -100.0 and maxQuantile as 100.0,
the order of the results changes to V1, V2

V1 -> [-100.0, 20.0] after quantization becomes [0, -103] with corrective offset as -2000
V2 -> [100.0, 20.0] after quantization becomes [-1, 102] with corrective offset as -18000
QVec same as V2 becomes [-1, 102] with query offset as -18000

Q.V1 ->  q * v1 * alpha^2 + corrective offset + query offset
          = -10506 * 0.61514807 -2000 -18000 = -26462.746 = 1/(1+26462.746) = 3.7787544E-5

Q.V2 -> 10406 * 0.61514807 -18000 - 18000 = -29599.385 = 1/(1+29599.385) = 3.3783344E-5

Scalar quantization in Lucene is by default 7 bits. Meaning the range of values is actually 0-127.

Scalar quantization in Lucene is by default 7 bits. Meaning the range of values is actually 0-127.

For 7 bits, it makes sense. But, the example I was referring to is for 8 bits.

@benwtrent To be on the same page, can you please confirm if you have used 7 bits or 8 bits in your experiment that you ran above with cohere dataset using InnerProduct to get this recall@100 as 0.738 ?

Thank you @naveentatikonda for the deep dive here and a nice unit test ... I couldn't follow all of the logic you described, but if we are indeed first normalizing a dimension's value v to a float [0 .. 255] and then simply (byte) Math.round(v) for the signed byte (int8) case, then that does indeed sound wrong.  We should instead normalize the float v to [-128 .. 127]?

I used int7 for my experiments. While losing one bit of precision isn't the best, it works well.
I explored adding an unsigned byte dot product, but that got rejected as too much code.
I think for int8 to support all vector similarities, we need an unsigned dot product. Additionally, if we support int8, we should restrict it to [-127, 127], as there can be nice performance benefits  if we can assume these ranges on various hardware.
I haven't done the math on Euclidean to figure out if we need an unsigned byte version of that as well.
I am out on vacation. But here is my old PR:
https://github.com/apache/lucene/pull/12694

I am trying to understand one thing: Does the corrective offset for dot product rectify issues with sign shift that is caused by going from signed domain: [-x, +y] to unsigned domain: [0, 127]? Or is this handled elsewhere?
For an overly simplified example, for a data set with min = -6 and max = 6 (and for simplicity assume min max are the respective upper and lower quantiles)
# Query vectors
query_vector = [-5]
quantized_query_vector = [11]

# Index vectors
## Full precision
1: [-6]
2: [-2]
3: [3]
4: [6]

## Quantized
1: [0]
2: [42]
3: [95]
4: [127]

## Full precision Ordering of query_vector . index_vectors:
1,2,3,4

## Quantized Ordering of quantized_query_vector . quantized_index_vectors
4,3,2,1

I think I might be missing something, but how is this accounted for?

@jmazanec15 this is accounted for in the corrections. The moving from signed to unsigned is still just a linear transformation, we are not manually flipping signs, but instead doing a full linear scale.
Assuming your vectors are in order that you provided [[-6][-2][3][6]]
Their calculated dot-product corrections are [18.0, -5.8750076, -35.787956, -54.0]
For query vector [-5] its correction is 11.95908
The overall quantile multiplier is 0.008928018
To calculate the corrected dot-product score quantizedDotProduct * multiplier + queryCorrection + vectorCorrection
The raw dot-products (in order of the vectors)
[30.0, 10.0, -15.0, -30.0]

The quantized dot-products with corrections
[29.95908, 10.208817, -14.499098, -29.568478]

Of course, the quantized scores without corrections (thus not accounting for linear shift and breaking max-inner product score scaling)
[0.0, 462.0, 1045.0, 1397.0]

I see that makes sense. Thanks @benwtrent

The drop in recall for Inner Product space type for int7 quantization was due to confidence interval, changing it from 0.9 to default (calculated from dimension of vector) solved the issue and gave good recall. So, closing this issue.


Are there json schema for omnisharp.json yet?

I wish there would be official json schema for omnisharp.json in schemastore.org

fixed by https://github.com/SchemaStore/schemastore/pull/260

@filipw That's just my hacked, it not official and not cover anything but FormattingOptions


Styling

Description
Added Less
Added file structure for Less
Added reactstrap
Added styling to user scheduling page
Type of change
Please delete options that are not relevant.

[ ] New feature (non-breaking change which adds functionality)

How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

[x] Just styling changes. Looked at app while I made changes

Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[ ] My code has been reviewed by at least one peer
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes

Peer Review - No issues


chore(master): release 2.7.9

:robot: I have created a release beep boop
2.7.9 (2024-09-11)
Dependencies

deps: update davidanson/markdownlint-cli2-action action to v17 (0eea786)

This PR was generated with Release Please. See documentation.

:robot: Created releases:

v2.7.9
:sunflower:


CLI infrastructure

NEETBOX Cli was proposed for the following considerations:

Users can create an empty project through neet init, containing premade configuration files and basic folder structure. We hope this functionality will be similar to react cli
Users can view status of neetbox processes, and monit results marked by @watch
Users can launch neetbox server and frontend via cli command neet serve
Users can easily switch the data set being used or manage other file resources through cli. These file resources can be scattered everywhere. When users want to use them, they only need to select them in the cli, and neetbox will create soft links or modify the configuration files.

Since we are here to bring the new cli tools, @AndPuQing would like to introduce click for cli, which would be nice.

We have migrated to click thanks to @AndPuQing

Cli can now launch neetbox server and frontend via neet serve in branch dev. #72
https://github.com/visualDust/neetbox/pull/72/commits/af01e30b20b7f83619510e0a6c9ae13f097cbddd


feat(headless): getGeneratedAnswerMetadata method added to the InsightAnalytics provider

SFINT-5248
As previously discussed in the following design doc about the UA events for RGA, it was decided that we wanna include the information about whether the generated answer is shown or not in the Search UA events of search interfaces and insight interfaces.
The logic to add this information in the UA search events of the search use case has been previously added, now it's time to add it in the insight use case.
Changes in coveo.analytics.js have already been made to support having a new method called getGeneratedAnswerMetadata in the InsightAnalyticsProvider.
This method has been added now in Headless and it returns the information about about whether the generated answer is shown or not based on the state.
Example of the information added in the UA search events:

As previously discussed in the following design doc about the UA events for RGA, it was decided that we wanna include the information about whether the generated answer is shown or not in the Search UA events of search interfaces and insight interfaces.

Yes we are.
We've defined some of them already. See api.event.qnaAnswerAction and other api.event.qna* events.
For the new protocol, there are still blockers that we've been trying to remove for a while now surrounding how we want to send info through (or maybe besides) Search Events and the number one thing we're trying to avoid is to add data to the customData field. I'm hoping to have that solved and have an answer for you in early January (kind of late to promise a resolution this week). For the crunchy details if you're really interested: GDoc: Logging additional event data for Service products calling the Search API
Plus, in the new protocol, search events should not be used, because we already have server-side search events that log the same things, only more reliably.


feat: enhancements to OpenTelemetry support

Description

References

Review Checklist

[ ] I have clicked on "allow edits by maintainers".
[ ] I have added documentation for new/changed functionality in this PR or in a PR to openfga.dev [Provide a link to any relevant PRs in the references section above]
[ ] The correct base branch is being used, if not main
[ ] I have added tests to validate that the change in functionality is working as expected

Codecov Report
Attention: Patch coverage is 93.03797% with 11 lines in your changes missing coverage. Please review.

Project coverage is 88.61%. Comparing base (46ab412) to head (4d9ddfc).

Files with missing lines
Patch %
Lines

api.ts
18.18%
0 Missing and 9 partials :warning:

common.ts
92.85%
1 Missing :warning:

telemetry/attributes.ts
98.00%
0 Missing and 1 partial :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #149      +/-   ##
==========================================
+ Coverage   88.13%   88.61%   +0.47%
==========================================
  Files          19       23       +4
  Lines        1003     1124     +121
  Branches      150      184      +34
==========================================
+ Hits          884      996     +112
+ Misses         82       81       -1
- Partials       37       47      +10

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Quick thoughts on this -
My major concern is the configuration as that would be a breaking change to change later.
If we can move the attrib and metric names to enums and make the configuration something like here https://github.com/openfga/dotnet-sdk/blob/main/OpenTelemetry.md, that would be great
Having the constructor as it is currently, take a set of true/false is problematic, b/c it's not easy for the user to tell what they are configuring and we could easily do a breaking change by changing the order without the user being aware


Error when run "train_S3DIS.py"

Hi @HuguesTHOMAS,
I got some error when run 'python train_S3DIS.py'. I noticed that this error is similar with the one in this issue:  https://github.com/HuguesTHOMAS/KPConv-PyTorch/issues/1#issue-613750558
My environment is ubuntu16.04, python=3.6, pytorch=1.2.0, cuda=10.0.
Could you please tell me which lines of code should be changed to solve this data type problem? Thanks!
Starting Calibration (use verbose=True for more details)

Previous calibration found:
Check batch limit dictionary
"potentials_1.500_0.030_6": ?
Check neighbors limit dictionary
"0.030_0.075": ?
"0.060_0.150": ?
"0.120_0.720": ?
"0.240_1.440": ?
"0.480_2.880": ?
Traceback (most recent call last):
  File "train_S3DIS.py", line 269, in <module>
    training_sampler.calibration(training_loader, verbose=True)
  File "/home/dchangyu/mvpnet/KPConv-PyTorch/datasets/S3DIS.py", line 1181, in calibration
    for batch_i, batch in enumerate(dataloader):
  File "/home/dchangyu/miniconda3/envs/mvpnet/lib/python3.6/site-packages/torch/utils/data/dataloader.py", line 819, in __next__
    return self._process_data(data)
  File "/home/dchangyu/miniconda3/envs/mvpnet/lib/python3.6/site-packages/torch/utils/data/dataloader.py", line 846, in _process_data
    data.reraise()
  File "/home/dchangyu/miniconda3/envs/mvpnet/lib/python3.6/site-packages/torch/_utils.py", line 369, in reraise
    raise self.exc_type(msg)
TypeError: Caught TypeError in DataLoader worker process 0.
Original Traceback (most recent call last):
  File "/home/dchangyu/miniconda3/envs/mvpnet/lib/python3.6/site-packages/torch/utils/data/_utils/worker.py", line 178, in _worker_loop
    data = fetcher.fetch(index)
  File "/home/dchangyu/miniconda3/envs/mvpnet/lib/python3.6/site-packages/torch/utils/data/_utils/fetch.py", line 44, in fetch
    data = [self.dataset[idx] for idx in possibly_batched_index]
  File "/home/dchangyu/miniconda3/envs/mvpnet/lib/python3.6/site-packages/torch/utils/data/_utils/fetch.py", line 44, in <listcomp>
    data = [self.dataset[idx] for idx in possibly_batched_index]
  File "/home/dchangyu/mvpnet/KPConv-PyTorch/datasets/S3DIS.py", line 240, in __getitem__
    return self.potential_item(batch_i)
  File "/home/dchangyu/mvpnet/KPConv-PyTorch/datasets/S3DIS.py", line 325, in potential_item
    self.potentials[cloud_ind][pot_inds] += tukeys
TypeError: add_(): argument 'other' (position 1) must be Tensor, not numpy.ndarray

Hi @dcy0577,
This error is strange, and I think could be caused by your old version of PyTorch.

File "/home/dchangyu/mvpnet/KPConv-PyTorch/datasets/S3DIS.py", line 325, in potential_item
self.potentials[cloud_ind][pot_inds] += tukeys

It seems the addition of a tensor and an np.array is not allowed. You can correct this by using torch.from_numpy on the array called tukeys. But there might be other errors that occurs due to the old PyTorch version. I strongly advise upgrading to PyTorch 1.4 (or higher) to be sure you don't have any other errors.
Best,
Hugues

Hi @HuguesTHOMAS, thanks a lot for the quick reply, the training works now. By the way, I later encountered another data format error and I have solved it by simply adding long() behind neighb_row_bool  (might be useful for someone who also use the old version of Pytorch)
https://github.com/HuguesTHOMAS/KPConv-PyTorch/blob/7fefb6a8d38fd304775199777ad01d9f1546e2ff/models/blocks.py#L323


EC2 Instance CreatedDate Tag

Hi,
We wanted to auto-tag EC2 Instance with username who created the Instance and CreatedDate to know when was the Instance first created. We are able to auto tag username using auto-tag-user action. Similar to auto-tag-user, can you also develop auto-tag-time with the EventName 'RunInstances'.

There's built in formatting and variables for tag values that allow you to do this. The variable is now we have some extended syntax as well for performing date arithmetic as well.
here's an example, that will add two tags one with the current time, and one with the time in the future, date formatting options are documented at http://pyformat.info
policies:
 - name: ec2-image-check
   resource: ec2
   filters:
    - or:
      - Launched: absent
      - Expires: absent
   actions:
    - type: tag
      tags:
        Launched: "{now:%Y-%m-%d}"
        Expires: "{now:+7d%Y-%m-%d}"


settings app for redmi note 11

Hello, i tried various settings app. not a single one of them worked
Device is Redmi Note 11 with HyperOS <IP_ADDRESS>.TGCMIXM android 13

Settings_SPESGlobal_from_OS<IP_ADDRESS>.TGCMIXM.apk
try this apk


chore(deps): upgrade dev dependencies

Upgrades project dependencies. See details in workflow run.

Automatically created by projen via the "upgrade-dev-dependencies-k8s-26-main" workflow

⚪ Backport skipped
The pull request was not backported as there were no branches to backport to. If this is a mistake, please apply the desired version labels or run the backport tool manually.
Manual backport
To create the backport manually run:
backport --pr 3824

Questions ?
Please refer to the Backport tool documentation


"ClientIP" handling is unsafe

https://github.com/cloudwego/hertz/blob/3ac19d5b1158badab0c7fc8e47b2e4ba667c4453/pkg/app/context.go#L980-L994
This code has a security risk, when using the ClientIP function it is easy to be spoofed by "X-Real-IP" and "X-Forwarded-For" to bypass the checks。
This problem also occurs with the Gin framework -> https://github.com/gin-gonic/gin/issues/2473
The fix can be found in their issue。

Thanks for reporting! Are you interested in submitting a pr to fix it?
It's OK if it is not so, I'll put it into TODOs.

i want to try it, please assign me.


refactor(router): remove unnecessary function from Refunds Validate Flow

Type of Change

[ ] Bugfix
[ ] New feature
[ ] Enhancement
[x] Refactoring
[ ] Dependency updates
[ ] Documentation
[ ] CI/CD

Description

Refactoring to remove validate_uniqueness_of_refund_id_against_merchant_id as it isn't required because of the db being a unique btree. So you are able to try to insert the refund by id and if the insert fails then the refund is not valid .
Additional Changes

[ ] This PR modifies the API contract
[ ] This PR modifies the database schema
[ ] This PR modifies application configuration/environment variables

Motivation and Context

#1521
How did you test it?

Tested by:

Creating a stripe payment
Creating a refund using the payment id successfully.

Checklist

[x] I formatted the code cargo +nightly fmt --all
[x] I addressed lints thrown by cargo clippy
[x] I reviewed the submitted code
[ ] I added unit tests for my changes where possible
[ ] I added a CHANGELOG entry if applicable

@AaronTJDev Could you address the failing CI checks?

@SanchithHegde Apologies, my rust-analyzer plugin didn't catch that error due to some caching issues locally! This is updated now.

Hello @AaronTJDev ,
Thanks a bunch for all your contributions! We've got a little something for you to show our appreciation.
Just take a moment to fill out this form, and get ready for some awesome swag coming your way.
Thanks!

Hi @swangi-kumari, thank you for your kindness! However, I've already signed up previously (see link below). Thank you for providing an awesome experience for contributors.
https://github.com/juspay/hyperswitch/pull/2456#issuecomment-1750534969


cquery: init at 2018-03-25

Motivation for this change
Add the cquery language server
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[x] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[x] Fits CONTRIBUTING.md.

Thanks!

seems to not build on darwin: https://hydra.nixos.org/build/72710712/nixlog/1
A patch has been provided upstream: https://github.com/cquery-project/cquery/commit/4f773f46446a706e49e64e67fe5dc08130a70385
but upgrading to the latest commits seems to break the tests on linux:
running install tests
/nix/store/9zv4i1yv2y14r52y6r4fqzwhjlr1qsan-source /build/source/build
(   0.003s) [stdin        ]            lsp.cc:166   | Failed to read JsonRpc input; exiting
builder for '/nix/store/bfycja4icdhxf74gsmsqfq1fr3cha8pa-cquery-2018-04-24.drv' failed with exit code 1
error: build of '/nix/store/bfycja4icdhxf74gsmsqfq1fr3cha8pa-cquery-2018-04-24.drv' failed

opened a new PR: #39825


make setup has been deleted but still exists in the document

Description
How can the docs be improved?
Although the make setup command has been removed (#5661), the contributing document in /website/en/docs (or version) still contains the following description on line 129:

Finally, to deploy the correct IAM permissions, including the instance profile for provisioned nodes, run
make setup

I believe this section should be deleted.

Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
If you are interested in working on this issue or have submitted a pull request, please leave a comment

@yoonhyunwoo If you were interested in opening a PR to drop this section and improve the contributing documentation, we'd love to take it in!


[BUGFIX] Scraping: Tolerance should be max 1% of interval

Previous code set it at minimum 1%, which was not intended.
Fixes #13730

Thanks,
I think we should update https://github.com/prometheus/prometheus/blob/3d16d398815d03a756dd8361efe6d1580fba7fcc/cmd/prometheus/main.go#L426 to mention that we go with 1% of the interval now (and we no longer skip as before.)

But we didn't mention that alignments were skipped if the tolerance is greater than 1% of the scrape interval, so we can keep it like that. Your call.

The docstring didn't explain much before, so I don't feel it's essential to improve it in this PR.
Maybe we could do a subsequent PR that takes the feature out of experimental status, and documents it clearly.


Rest api client

Introduce a WIP rest client.

LSR dependency change summary:
target packages:
  M proxy 0.1.0 (workspace, path 'crates/proxy')
    * source changed from path 'common/proxy'
    * (unchanged features: [none])

LEC dependency change summary:
target packages:
  M proxy 0.1.0 (workspace, path 'crates/proxy')
    * source changed from path 'common/proxy'
    * (unchanged features: [none])

release binaries dependency change summary:
target packages:
  M diem-client 0.0.3 (workspace, path 'crates/diem-client')
    * source changed from path 'sdk/client'
    * (unchanged features: blocking, ipnet, ureq)
  M proxy 0.1.0 (workspace, path 'crates/proxy')
    * source changed from path 'common/proxy'
    * (unchanged features: [none])

LSR dependency change summary:
target packages:
  M proxy 0.1.0 (workspace, path 'crates/proxy')
    * source changed from path 'common/proxy'
    * (unchanged features: [none])

LEC dependency change summary:
target packages:
  M proxy 0.1.0 (workspace, path 'crates/proxy')
    * source changed from path 'common/proxy'
    * (unchanged features: [none])

release binaries dependency change summary:
target packages:
  M diem-client 0.0.3 (workspace, path 'crates/diem-client')
    * source changed from path 'sdk/client'
    * (unchanged features: blocking, ipnet, ureq)
  M proxy 0.1.0 (workspace, path 'crates/proxy')
    * source changed from path 'common/proxy'
    * (unchanged features: [none])

LSR dependency change summary:
target packages:
  M proxy 0.1.0 (workspace, path 'crates/proxy')
    * source changed from path 'common/proxy'
    * (unchanged features: [none])

release binaries dependency change summary:
target packages:
  M diem-client 0.0.3 (workspace, path 'crates/diem-client')
    * source changed from path 'sdk/client'
    * (unchanged features: blocking, ipnet, ureq)
  M proxy 0.1.0 (workspace, path 'crates/proxy')
    * source changed from path 'common/proxy'
    * (unchanged features: [none])

LEC dependency change summary:
target packages:
  M proxy 0.1.0 (workspace, path 'crates/proxy')
    * source changed from path 'common/proxy'
    * (unchanged features: [none])

LSR dependency change summary:
target packages:
  M proxy 0.1.0 (workspace, path 'crates/proxy')
    * source changed from path 'common/proxy'
    * (unchanged features: [none])

LEC dependency change summary:
target packages:
  M proxy 0.1.0 (workspace, path 'crates/proxy')
    * source changed from path 'common/proxy'
    * (unchanged features: [none])

release binaries dependency change summary:
target packages:
  M diem-client 0.0.3 (workspace, path 'crates/diem-client')
    * source changed from path 'sdk/client'
    * (unchanged features: blocking, ipnet, ureq)
  M proxy 0.1.0 (workspace, path 'crates/proxy')
    * source changed from path 'common/proxy'
    * (unchanged features: [none])

/land

LSR dependency change summary:
target packages:
  M proxy 0.1.0 (workspace, path 'crates/proxy')
    * source changed from path 'common/proxy'
    * (unchanged features: [none])

LEC dependency change summary:
target packages:
  M proxy 0.1.0 (workspace, path 'crates/proxy')
    * source changed from path 'common/proxy'
    * (unchanged features: [none])

release binaries dependency change summary:
target packages:
  M diem-client 0.0.3 (workspace, path 'crates/diem-client')
    * source changed from path 'sdk/client'
    * (unchanged features: blocking, ipnet, ureq)
  M proxy 0.1.0 (workspace, path 'crates/proxy')
    * source changed from path 'common/proxy'
    * (unchanged features: [none])

Thanks Brandon!
cc @lightmark @gregnazario @zekun000


Module generates undeletable File ".eslintrc." in Windows

# The Issue
When this module 'gulp-tslint-jenkins-reporter' is installed in the normal way :
npm install gulp-tslint-jenkins-reporter --save-dev
...the module becomes undeletable because one of the files is given a file name that is  illegal for windows to use. Specifically, within the sub-directory node_modules/gulp-tslint-jenkins-reporter/.c9/metadata/workspace/ the file called .eslintrc. cannot be removed by regular Windows file delete.
For example, after prepping the project (using the npm install which includes the 'gulp-tslint-jenkins-reporter' in the package.json), then a user is unable to clean up all of the node_modules EXCEPT  'gulp-tslint-jenkins-reporter' , but gets the following results:
C:\git\my-project>git clean -xdf
Removing .idea/
warning: Could not stat path 'node_modules/gulp-tslint-jenkins-reporter/.c9/metadata/workspace/.eslintrc.': No such file or directory

The issue is that a windows file cannot end with a dot (.)  . If such a file gets created (such as through ZIP extraction from another OS, or i/o that does not follow those rules, the file is undeletable by most Windows commands.
# The Request
This module must be changed so that it does not generate a non-windows friendly filename (do NOT put a dot (.) as the last character in a filename).

As a temporary work-around for Windows users who must use this module, until the current issue is fixed.
The only way to  remove the file is to use CMD command del  in conjunction with the Windows shortname while in the local directory in which the illegally named file exists.  In this case, you must drill into the directory by :
 `cd node_modules\gulp-tslint-jenkins-reporter\.c9\metadata\workspace`

then, you must do :
 `dir /x`

which will output something like:
08/09/2016  04:56 PM    <DIR>                       .
08/09/2016  04:56 PM    <DIR>                       ..
08/09/2016  01:53 PM             3,286 ESLINT~2     .eslintrc.
08/09/2016  01:53 PM             3,294 ESLINT~2.JSO .eslintrc.json
08/09/2016  01:53 PM             2,352 NPMIGN~1     .npmignore
08/09/2016  01:53 PM               706 TRAVIS~1.YML .travis.yml
08/09/2016  01:53 PM             1,258 ESLINT~1.JSO eslintrc.json
08/09/2016  01:53 PM             7,507              index.js
08/09/2016  01:53 PM             3,662 PACKAG~1.JSO package.json
08/09/2016  01:53 PM            11,198              README.md
08/09/2016  01:53 PM    <DIR>                       src
08/09/2016  01:53 PM    <DIR>                       test
               8 File(s)         33,263 bytes
               4 Dir(s)  255,819,862,016 bytes free

From that, you must use the shortname to delete the file.   After that file is deleted, the module can be removed the rest of the way.


train works in a web-worker

As of Vite v5.1.6, wasm-bindgen-rayon works in a web-worker.
FYI @ishiko732
Related: https://github.com/open-spaced-repetition/fsrs-browser/pull/11 https://github.com/RReverser/wasm-bindgen-rayon/pull/4#issuecomment-1970024475

It's better to use squash merging because the commit history will be more concise.

I personally prefer a more verbose history as I believe it makes the git history more readable. Each commit does exactly one thing, and if it takes several commits to build a feature that's fine.
So like, the history of this PR is simple/easy to read: update packages, revert a commit, fix some issues, then remove a package.
This history is important as it allows me to do things like revert that commit in step 3. That reverted commit was part of this PR, and I would not have been able to revert if it was squashed into one commit. Also, during the investigation phase of this PR, I was able to check out an intermediate commit for the other PR, update Vite, notice that web-workers now works, and therefore determine that an upstream issue was fixed. Squashing history for conciseness prevents all this.
To be clear, I'm not saying all git repositories should work this way - this is just my preferred way of working with git :)

Fine. What about rebase merging? It also could keep the verbose history of commits.

Hmm I do directly commit to main frequently. My primary objective is a readable git history, and merges (I feel) are an important part of that. If a feature can be done in one commit, then great, I could be convinced to rebase it into main. If not, then having them grouped together into a PR/merge commit has two bonuses; I can revert an entire feature with one commit if necessary, and I can revert parts of a feature as I did above. In the most recent PR from Ishiko, for example, with my guiding light being a readable git history, they added a config, and then later I added some comments justifying why that config is there. In that case the git narrative is 1) config added 2) why config was added. I'm also generally leery of rebase merges because they rewrite history, and I feel like history is important. I actually rebase all the time in my own private branches - it's how I build a "readable" history - but I rarely rebase when merging. I see no reason not to do it for single-commit PRs though! Again, this is all just my personal workflow - I'm not saying anyone else should work this way!

OK. It's totally understandable. I just gave advice in my stand. I very appreciate your contribution. Just let everything  continue as usual.


[Chore] Force check ci on prapare/release branch

Purpose of the pull request

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:

(or)
Pull Request Notice
Pull Request Notice
If your pull request contain incompatible change, you should also add it to docs/docs/en/guide/upgrede/incompatible.md

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 41.32%.

Additional details and impacted files
@@             Coverage Diff              @@
##                dev   #16216      +/-   ##
============================================
- Coverage     41.32%   41.32%   -0.01%
  Complexity     5162     5162
============================================
  Files          1403     1403
  Lines         44423    44390      -33
  Branches       4721     4697      -24
============================================
- Hits          18357    18343      -14
+ Misses        24262    24241      -21
- Partials       1804     1806       +2

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


grafana: Fix display of ingest SST and compaction size

What is changed and how it works?

Issue Number: Ref #15990

What's Changed:
Fix display of ingest SST and compaction size

Related changes

[ ] PR to update pingcap/docs/pingcap/docs-cn:
[ ] Need to cherry-pick to the release branch

Check List
Tests

[ ] Unit test
[ ] Integration test
[ ] Manual test (add detailed scripts or steps below)
[x] No code

Side effects

[ ] Performance regression: Consumes more CPU
[ ] Performance regression: Consumes more Memory
[ ] Breaking backward compatibility

Release note

None

Do we need to cherry-pick this bugfix to older version?

Do we need to cherry-pick this bugfix to older version?

These metrics are added recently, so no need

/retest

/retest


Negation in Blacklist Regex is not working

Description
Negation in Regex is not working.
To Reproduce
I wanted to block all endpoints which does not match "/api/v1/Start" so I've set Blacklist to @"^(?!/api/v1/Start)" and UseRegexForBlacklisting = true.
But now its not loggin /api/v1/Start endpoint even if this does not match the regex.
Expected behavior
I would expect enpoint /api/v1/Start to be logged when my Blacklist is set to @"^(?!/api/v1/Start)".
Details (please complete the following information):

Project Type: API
Framework Version .NET 6
WatchDog Version <IP_ADDRESS>
Database Default
Browser Edge

Without the / at the beggining its working fine. So the solution is Blacklist set to @"^(?!api/v1/Start)"


Atelier Nelke: The Alchemists and the New Earth [PCSG01223]

App summary

App name: ネルケと伝説の錬金術士たち ～新たな大地のアトリエ～
App serial: PCSG01223
App version: 1.00

Vita3K summary

Version: v0.1.6
Build number: 2968
Commit hash: https://github.com/vita3k/vita3k/commit/0df79bb8
CPU backend: Dynarmic
GPU backend: Vulkan

Test environment summary

Tested by: nishinji
OS: Windows 10
CPU: AMD Ryzen 9 3950X
GPU: RTX3060Ti
RAM: 32 GB

Issues
koei issues
I think the footsteps are too loud?
Screenshots

Log
vita3k.log
Recommended labels
Ingame +
graphics bug

Graphics issues are fixed


Gem install fails if missing zeromq/msgpack on OSX

When trying to install the rubygem, it failed until i manually ran brew install. To reproduce, i uninstalled msgpack and zeromq and the gem then tried to reinstall.
$ brew uninstall msgpack
Uninstalling /usr/local/Cellar/msgpack/0.5.9...
2.2.0  ~
$ gem uninstall rbkit
Successfully uninstalled rbkit-0.1.10
2.2.0  ~
$ gem install rbkit
Fetching: rbkit-0.1.10.gem (100%)
Building native extensions.  This could take a while...
ERROR:  Error installing rbkit:
	ERROR: Failed to build gem native extension.

    /Users/richardschneeman/.rubies/ruby-2.2.0/bin/ruby -r ./siteconf20150116-79688-njbp3x.rb extconf.rb
checking for rb_postponed_job_register_one()... yes
checking for rb_profile_frames()... yes
checking for rb_tracepoint_new()... yes
checking for RUBY_INTERNAL_EVENT_NEWOBJ... yes
checking for main() in -lzmq... no
checking for libtool... yes
checking for autoconf... yes
checking for automake... no
*** extconf.rb failed ***
Could not create Makefile due to some reason, probably lack of necessary
libraries and/or headers.  Check the mkmf.log file for more details.  You may
need configuration options.

Provided configuration options:
	--with-opt-dir
	--with-opt-include
	--without-opt-include=${opt-dir}/include
	--with-opt-lib
	--without-opt-lib=${opt-dir}/lib
	--with-make-prog
	--without-make-prog
	--srcdir=.
	--curdir
	--ruby=/Users/richardschneeman/.rubies/ruby-2.2.0/bin/$(RUBY_BASE_NAME)
	--with-zmqlib
	--without-zmqlib
extconf.rb:33:in `block in download_and_install_zeromq_from_source': automake needed by zeromq not found. (RuntimeError)
	from extconf.rb:32:in `each'
	from extconf.rb:32:in `download_and_install_zeromq_from_source'
	from extconf.rb:80:in `<main>'

extconf failed, exit code 1

Gem files will remain installed in /Users/richardschneeman/.gem/ruby/2.2.0/gems/rbkit-0.1.10 for inspection.
Results logged to /Users/richardschneeman/.gem/ruby/2.2.0/extensions/x86_64-darwin-13/2.2.0-static/rbkit-0.1.10/gem_make.out

@schneems This is related to zeromq installation and not msgpack. The gem downloads and installs zeromq for you if it's not found on your system. Before doing that it checks if the following executables are available : ['libtool', 'autoconf', 'automake'] . These are prerequisites for zeromq installation as documented in their installation page. If we don't find it we fail with an error message. I guess adding this piece of information to the README should do ?

I got the same error (although a failure on autoconf rather than automake) despite having autoconf, libtool, and automake installed via homebrew.
After running:
brew unlink autoconf && brew link autoconf

…I was able to get things installed. Hopefully this helps someone else!

One more here who had trouble with zeromq.

Documented this in the README #109


Propagate DPAS layout attribute to the tt.store with the block pointer

Forwards the DPAS layout to the store ops if the ops use a block pointer. Other passes (such as RewriteTensorPointer) need this to enable the use of 2d block store ops where appropriate.
Closes Issue: #1194

Note that I had to improve the code from https://github.com/intel/intel-xpu-backend-for-triton/commit/18a1892387076ca80585b2983712959aa698821f to make it work in the fallback pass pipeline.

The only outstanding comment is about the unit test (remove it and enhance the existing one). Is that doable ? After that I think this PR is ready to go.

The test has been moved to backward_combine_dpas_dot_layout.mlir. (+ added a new test).


Milk mode + PEP8

Now this code is PEP8 compliant, I've alse did some refactoring and added milk mode as described in https://github.com/ripxorip/aerojump.nvim/issues/9

Oops, changed highlights colors, sorry

Cool, thx for making the code PEP8 compliant. Just tested it out and it looks great. Need to update the documentation as well.


Convert VirtualBox parser to using nokogiri

Convert VirtualBox parser to using nokogiri instead of rexml. This allows us to
use namespace agnostic xpaths, so that we successfully parse some ovf files
which use namespaces in unexpected ways. Fixes #88
Shouldn't cause any additional burden since Vagrant requires nokogiri anyway.
Also add nokogiri to gemspec for correctness. Perhaps other parsers should be
converted as well.

All tests pass, with the test changes in #86.

After this change there would only be one place left where we're using rexml. Could you convert it too?
https://github.com/sciurus/vagrant-mutate/blob/a948b80f1b332e7c59cc41eec0feb3b49cd4d508/lib/vagrant-mutate/box/kvm.rb#L24


Evaluate recent bttv update

A new bttv version was just released (cf. https://github.com/night/betterttv/releases/tag/7.5.0). Read the changelog and check for necessary changes to bttv-android.

Done

#583
#582
#581


Fix table try get as non generic argument

Create branch from main
issue-140-fix-table-try-get-as-non-generic-argument


[WIP] feat: add accessible react-bootstrap components

Coverage remained the same at 88.012% when pulling 8b86f779e3c873b7089ff3a7ee819a2901bd45e2 on abutterworth/add-react-bootstrap into c9c2632aec53000e05ec8f6869933c502610bca8 on master.

Two thoughts -
One, I'm curious how a lot of these interact with our existing Paragon components when they're used in sensible ways that folks might expect (our input classes inside their Form, for instance)
Two, documenting all this will be interesting.  In the past we chose to duplicate/wrap all the Bootstrap documentation... are we going to reproduce react-bootstrap's?  Or just reference it from the paragon documentation?  Seems like we're going to need to have a big shift in the doc around which components are deprecated... are we doing a major version change and just removing stuff?  And in reference to the first thought above, documenting any subtlety to those interactions will be fun.

And also, just a reminder to check on tree-shaking to make sure they've packaged react-bootstrap in such a way that it can still be slimmed down when used through Paragon.

Also - after having investigated react-bootstrap quite a bit now, how many cases do we see where we want to 'wrap' things?  Have we seen any specific benefits to exposing them through paragon?
Just thinking about whether or not it'd be a reasonable choice to make react-bootstrap a recommended library and call it a day. 🤔 (not sure I think this is a good idea)

Great points David.

Interaction between components: So far it seems like they're pretty interoperable. I know ValidationFormGroup will not do its job with the react-bootstrap components. I intend to mark the components that I know won't work together. As far as I'm aware right now, that's the only one. I may find more as I continue building the docs.
Documentation: I'm adding one or two examples of usage and then linking to the react-bootstrap docs themselves. I think this is the best blend between convenience and not doing extra work
Tree-shaking: I will double check in a project, but judging by the structure I'm confident it will tree-shake fine.

Why pull it in? Incorporating react-bootstrap inside paragon will help us:

maintain flexibility in the future by making Paragon the single source of truth. We can replace react-bootstrap components with our own in the future if we choose.
By using Paragon to pull in these components we can leverage them internally in Paragon without worrying about peer deps or versions of react-bootstrap.

In general I expect the future of Paragon to aim to create more "molecule-level" components that are composed of these react-bootstrap elements and in the further future we can swap the underlying technology with CSS-in-JS iteratively.

Thanks for indulging the second-guessing questions, @abutterworth.  Explanations totally make sense/I'm behind this!

:tada: This PR is included in version 9.1.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Resource configs_default.rb property cannot be null

Cookbook version
5.0.0 (latest)
Chef-client version
12.12.15
Platform Details
Ubuntu 14.04
Scenario:
configs_default.rb sets a default stats uri as per: https://github.com/sous-chefs/haproxy/blob/9c050820eafb6db1064364a79b40447db8c7ce8f/resources/config_defaults.rb#L7
It would be good if this wasn't set by default, as I suspect many users typically don't want to expose stats externally for every frontend? I typically create an individual listener (that is only available on a port internally) that we can access for stats. Setting the stats uri in configs_default.rb enables it for all frontends (which we have exposed to the internet).
Steps to Reproduce:
Use the configs_default.rb resource, stats uri is then automatically populated if not defined in haproxy.cfg, overriding it and setting it to null causes the cookbook converge to fail.
Desired Result:
If the stats uri is not defined in configs_default.rb, it doesn't get set in the haproxy.cfg file by default. If we want to expose stats we can set a uri in configs_default.rb ourselves OR create a independent listener for it. I guess similar to how it's been written for the listen.rb resource: https://github.com/sous-chefs/haproxy/blob/9c050820eafb6db1064364a79b40447db8c7ce8f/resources/listen.rb#L5
Actual Result:
Using the configs_default.rb creates a default stats uri of /haproxy-status. Overiding the property to null on the resource causes a cookbook converge to fail. All frontends will then expose /haproxy-status.

Actually, it seems the stats property can be 'disabled' from config_defaults.rb using an empty hash:
stats {}
It might be worth making it blank in config_defaults.rb by default though? Or at least documenting it this the readme?

@JJClements thanks man, want to take a crack at a pull request to the readme. I can merge that today?

This is solved by https://github.com/sous-chefs/haproxy/pull/275 @rshade

Hi,
To clean the value of stats or another value that has default value, you have to pass an empty hash.
example:
haproxy_config_defaults 'defaults' do
'http' mode
balance 'source'
stats Hash.new
timeout connect: '5000ms',
client: '5000ms',
server: '5000ms'
end
Regards!!

Fixed via #279


Allow deputies to become/unbecome their primaries

When a primary user assigns another user as their deputy, they should be able to masquerade as that user and do things on their behalf. This feature already existed for admins, so we're expanding it to include users that are assigned deputy roles from another primary user.
To preserve the existing feature, the original admin functions are extracted to a shared module. The admin controller then only needs to include the core functions of that module. The user controller uses those same features but adds additional protections that ensure only the deputy may become the primary.
Once the deputy is vetted, they become the primary user via CurrentUserBuilder. However, certain circumstances may arise where the primary user removes their deputy, revoking their privileges, but that deputy may still have an active session. To guard against that, we always check the deputies privileges for each request. The downside of this is that we can't memoize current_user. CurrentUserBuilder is always called, even if the user it not intending to masquerade as another user.
Fixes #315

@rschenk I've added a new commit to this because the UI buttons to unbecome/become a user with a deputy were not working. This required some changes to the controller. I went back-and-forth with this from component, to profile decorator/presenter, and back to helper methods. I ultimately went with helper methods because it was already headed that way and I couldn't wrap profile_for_current_user? in the component because it's spread out in the view. Ultimately, a decorator/presenter might be in order, but that's another can of works.

@rschenk also, memoizing available_deputy? might be back on the table, but I'm just no sure.


Replacing removeStyling() function with paste event interceptor to facilitate HTML contend editable functions

The removeStyling() function strips out all style=... attributes on any  elements within a RichText area so that when content is pasted in from Word or elsewhere, the extraneous styling is removed immediately, rather than coming as a surprise to the user when it gets stripped out during the submission process.
However this also prevents the use of the HTML5 content editable functions such as backColor and hiliteColor however, which are browser-specific implementations and generally work by inserting a background-color: yellow  element around the text.
I propose that instead of stripping the styling out on paste, the paste command is intercepted and converted into plaintext, before being pasted into the RichText box- this also has the benefit of not leaving any rogue  elements behind after the styling has been stripped. The code in the pull request works in firefox/chrome, yet to be tested in IE but this stack answer may have a solution to that in the comments: http://stackoverflow.com/a/12028136/2547709

It's worth noting that this will strip the "legitimate junk" from Word (etc) as well (bold, italic, hyperlinks, etc). Personally, I'm happy with all markup being stripped, but it's a change in behaviour that'll need documenting.

I think the behaviour @jimr points out is a blocker here, I'm afraid. While the usefulness of preserving the "legitimate" markup is open to debate, there will certainly be users who will see it as a regression if we drop it. Preserving the default behaviour for existing users has to take precedence over enabling new customisations, I think...
There are a few items around rich text fields on our short-term todo list - making the underlying JS library swappable, and adding per-field customisation - which will help in this regard, I think, and once those are in place we'll hopefully be in a better position to revisit this.


Travis for the Gym

Can we get travis for the gym?

By travis, I think you meant to start the CI testing processes. I will be happy to contribute to this part.
Can we discuss a timeline and things to include? Maybe this is also the time we should think about starting the documentation process.

Yes, we should now start documentation. As far as travis CI is concerned, we need to build some tests.
For eg, test to check if every action gives expected behaviour:
Given state St , we get correct next state S(t+1). This can be tested for every action for an environment with discrete actions. It is possible, at least now, given that Action space is small. For those with continuous action space, we can choose certain values in the action space and write tests.
Some more things which would be good to see in future are having a registry #10 .
Thoughts on adding more tests are welcome.

I have certain tests in the Spaces directory. I picked them up from the openai/gym but only the ones that seemed relevant to what this package offers. Why don't we start from that and then build off of that?

Hi,
I'm planning to work on the test part. I wrote some test for Box spaces and is available at my fork https://github.com/v-i-s-h/Gym.jl/blob/dev-vish/test/Spaces/box.jl.
It will be great if you people can give me some early comments.

Looks good to me. @kraftpunk97 thoughts?

@v-i-s-h This set of test is very exhaustive. Great. I think we can add one more test to this, in which low values are actually greater than the high values of the Box. The python gym's version of the Box space can handle this scenario. I think I had a commit addressing this kind of a situation, but it's in the AcrobotEnv PR. Perhaps you can upgrade the current Box space and include the tests for the same?

@tejank10 @kraftpunk97 Thanks for the comments. I will add more tests and open a PR in some days.
One general workflow doubt:
To get the "low<high" updates from @kraftpunk97, I added kraftpunk97/Gym.jl as one of my remotes. In my fork also, I have branch to work for tests. How if I merge kraftpunk97's updates to my test branch and add my test to that branch, will if create a conflict to merge in main repo later when I try a PR with both kraftpunk's updates and my tests?

Shouldn't be a problem I suppose. I have merged @kraftpunk97 's PR now.


Feat [0.3] - Make cart aware of customer

[ ] Documentation updates
[x] Automated tests
[ ] Changelog entries (core and hub)

@wychoong Converting to draft until it's complete and ready for full review.

@wychoong could you target main for this PR please?

closing this with #1125


Fix config type

https://github.com/svg/svgo/pull/1565 changed the signature when using SVGO programmatically so that the config argument is required. This breaks Parcel's usage where it might be undefined (https://github.com/parcel-bundler/parcel/blob/6f6759e5c2140aa8d7c3be70d56432258439ff19/packages/optimizers/svgo/src/SVGOOptimizer.js#L26-L32).
I've matched the original optimize function, and add some basic tests to cover it.
Refs https://github.com/parcel-bundler/parcel/pull/6481#discussion_r707864127

Thanks!

Released in https://github.com/svg/svgo/releases/tag/v2.6.1


Question: How to support html tag in markdown?

Hi, I want to use markdown-render to render markdown text which has html tags in it. In markdown-it, just set {html: true}, but how can I do in this project? Thanks.

You cant, the problem is react-native does not support html. We could create a webview for every html element or convert every div to a react-native view but that wont work.
So no / maybe