Ordering descendents

Hi,
I can't figure out how to order the descendents when executing findAll({ hierarchy: true })
I'm looking to order the data by a specific property as well. For example I'd like my hierarchy of folders to be returned in order of there name:
{
  name: "rootFolder"
  children: [
    { name: "A Folder"},
    { name: "B Folder"},
    { name: "C Folder"},
  ]
}

Is this possible?

findAll({ hierarchy: true, order: [ [ 'name' ] ] }) should work. Does it not?

Hi @nareynolds. Can you please confirm whether this worked for you?

It did work, thanks.
Sorry, I don't know what I was doing before!
On Mon, Oct 26, 2015 at 10:40 AM, overlookmotel<EMAIL_ADDRESS>wrote:

Hi @nareynolds https://github.com/nareynolds. Can you please confirm
whether this worked for you?
—
Reply to this email directly or view it on GitHub
https://github.com/overlookmotel/sequelize-hierarchy/issues/32#issuecomment-151159743
.

Great, thanks for letting me know!

Is this broken? Because these options
attributes: ['abbreviation', 'description', 'id', 'name', 'parentId'],
hierarchy: true,
order: [['name']]

Returns the following data for me (I stripped out the irrelevant attributes):
[
   {
      "name":"Test",
      "children":[
         {
            "name":"unit 9"
         },
         {
            "name":"unit 10"
         },
         {
            "name":"unit 11"
         },
         {
            "name":"unit 12"
         },
         {
            "name":"Operations Support"
         },
         {
            "name":"Army"
         },
         {
            "name":"EU Battalion"
         },
         {
            "name":"Core Engineering"
         }
      ]
   }
]

What about ordering when using this way to include hierarchical children (needed when viewing the tree starting not at the root):
include: [{
        model: model,
        as: 'descendents',
        hierarchy: true
}]

If I put the following order on it:
order: [[{model: model, as: 'descendents'}, 'name', 'ASC']]
It will only apply to the direct descendents, not to all descendents. Is there any way to apply this order to all descendents instead of only the direct descendents?

@leroydev Hmm the code you posted should work fine. Could you post some example data for which it doesn't work?

@overlookmotel:
This is for example a part of the tree that comes back in this way, instead of being ordered:
{
  "name": "Minecraft",
  "children": [{
    "name": "1st Battalion",
    "children": [{
      "name": "Guides"
    }, {
      "name": "1st Battalion Officers"
    }, {
      "name": "Training Team"
    }, {
      "name": "Event Staff"
    }]
  }]
}

@leroydev OK thanks for this. I'll look into it.

By the way, what version of Sequelize and sequelize-hierarchy are you using please?

@overlookmotel version 0.7.0 of sequelize-hierarchy, version 3.23.4 of sequelize. Thanks for looking into this! :)

@leroydev I've replicated this issue and found a fix. Just got to write some tests and I'll push to npm.
In the meantime, the fix is here if you need it urgently: https://github.com/overlookmotel/sequelize-hierarchy/commit/e733da1c4d4ed23011cac740a7ba1e5c17e1115c

Fixed in v0.7.2, just published on npm.
This was a pretty bad bug - ordering is a common requirement. Thanks loads for finding it and bringing it to my attention.


DevHome GitHub extension upgrade stuck in a loop

Dev Home version
0.1001.389.0
Windows build number
10.0.19045.0
Other software
No response
Steps to reproduce the bug
I have upgraded DevHome and GitHub extension to latest version from the Store but the upgrade is stuck in the below loop:

GitHub extension upgrade failed.

Using the wscollect command I have been able to determine why the installation failed: it's related to a dependency of the MSIX.

AppX Deployment operation failed for package Microsoft.WindowsAppRuntime.1.4_4000.1082.2259.0_x64__8wekyb3d8bbwe with error 0x80073D02. The specific error text for this failure is: error 0x80073D02: Unable to install because the following apps need to be closed Microsoft.Windows.DevHome_0.1001.389.0_x64__8wekyb3d8bbwe Microsoft.YourPhone_1.23112.87.0_x64__8wekyb3d8bbwe.

After killing PhoneExperienceHost.exe process I have been able to upgrade the GitHub extension from the Store.

Start DevHome, the "Dev Home is getting things ready for you..." window appear and the GitHub extension is downloaded again stucking at 95%.

Finally DevHome starts but widget are not working.

Very strange that the package resulted as installed.

PS C:\Users\david> Get-AppxPackage -Name Microsoft.Windows.DevHomeGitHubExtension

Name              : Microsoft.Windows.DevHomeGitHubExtension
Publisher         : CN=Microsoft Corporation, O=Microsoft Corporation, L=Redmond, S=Washington, C=US
Architecture      : X64
ResourceId        :
Version           : 0.1000.393.0
PackageFullName   : Microsoft.Windows.DevHomeGitHubExtension_0.1000.393.0_x64__8wekyb3d8bbwe
InstallLocation   : C:\Program Files\WindowsApps\Microsoft.Windows.DevHomeGitHubExtension_0.1000.393.0_x64__8wekyb3d8bbwe
IsFramework       : False
PackageFamilyName : Microsoft.Windows.DevHomeGitHubExtension_8wekyb3d8bbwe
PublisherId       : 8wekyb3d8bbwe
IsResourcePackage : False
IsBundle          : False
IsDevelopmentMode : False
NonRemovable      : False
Dependencies      : {Microsoft.WindowsAppRuntime.1.4_4000.1082.2259.0_x64__8wekyb3d8bbwe}
IsPartiallyStaged : False
SignatureKind     : Store
Status            : Ok

Expected result
DevHome and its extensions have been updated successfully.
Actual result
Upgrade is stuck in a loop.
Included System Information
No response
Included Extensions Information
No response

I think logs would be useful for this one. Can you also tell me the result if you run get-appxpackage *widget* in Powershell?
/logs

Update: I have removed the Microsoft.WidgetsPlatformRuntime package and reinstalled it from DevHome.
Now DevHome is starting as expected and widget are working.
Note that the packages below are still present in the Store as not updated.
The issue may not related to DevHome itself: feel free to close it.

I've been keeping an eye on this and I'm inclined to agree with you that it was store flakiness. Especially, as you point out in your last comment, since the Store claimed there was still an update available while <IP_ADDRESS> (the version you have) is the most recent version. The next release of Dev Home will include #2226, which should at least prevent the weird loop in the case of more store problems. Please let us know if you see any more weirdness here.


Everything has passed except blue! i've done every colour the same way!

Give your h1 element with the text I am red! the color red.
Use rgb for the color red.
Give your h1 element with the text I am orchid! the color orchid.
Use rgb for the color orchid.

**- Give your h1 element with the text I am blue! the color blue.

Use rgb for the color blue.**

Give your h1 element with the text I am sienna! the color sienna.
Use rgb for the color sienna.

Challenge Use RGB to Mix Colors has an issue.
User Agent is: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_10_3) AppleWebKit/600.5.17 (KHTML, like Gecko) Version/8.0.5 Safari/600.5.17.
Please describe how to reproduce this issue, and include links to screenshots if possible.
My code:

I am red!

I am orchid!

I am sienna!

I am blue!

@SDMG96 you got typo in code.
Thanks for reporting this. But your code is incorrect.
GitHub Issues are for reporting bugs on the website only.
Please use the Help chat room for getting challenge related help.
Happy Coding.


[refactor]

If the implementation method signature is different from the interface will get an error tip in GoLand.
Refactoring httpContext & httpResponse make methods signature as same as interfaces declared.

Thanks @Owenxh for reporting and fixing the issue.
Could you please change all func() to FinishFunc and all func(body []byte, complete bool) (newBody []byte) to BodyFlushFunc, the latters are more easy to read and grep.

Codecov Report

Merging #416 (74944b8) into main (c08f411) will decrease coverage by 0.21%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #416      +/-   ##
==========================================
- Coverage   80.30%   80.08%   -0.22%
==========================================
  Files          62       62
  Lines        7112     7112
==========================================
- Hits         5711     5696      -15
- Misses       1104     1121      +17
+ Partials      297      295       -2

Impacted Files
Coverage Δ

pkg/object/mqttproxy/session.go
74.39% <0.00%> (-7.93%)
:arrow_down:

pkg/object/mqttproxy/client.go
79.87% <0.00%> (-1.22%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c08f411...74944b8. Read the comment docs.

Thanks @Owenxh for reporting and fixing the issue.
Could you please change all func() to FinishFunc and all func(body []byte, complete bool) (newBody []byte) to BodyFlushFunc, the latters are more easy to read and grep.

Ok, I will try it later


Feature Enhancement - Support for Sengled multicolor bulbs

Your integration works great to turn on and off the Sengled bulbs! The only issue I have is that they do not seem to support any of the color changing features. If you are willing to work on this, I can provide you with any logs or details you might need.

You are correct currently this will not support any color options for Sengled Bulbs. Do you have wifi bulbs or zigbee bulbs that requires the hub. I plan on adding support for this, but I currently do not have the multi color bulbs that goes with the hub. For the Wifi Color bulbs I have added some support and still adding.

Any logs you have please feel free to share.

Thanks for the reply- I have the zigbee bulbs that require the hub. I am happy to provide logs - can you tell me which ones would be interesting to you?

@informationinsecurity

Setup your logger to print debug messages for this component by adding this to your configuration.yaml:logger:
  default: warning
  logs:
    custom_components.sengledapi: debug

Restart HA
Verify you're still having the issue
File an issue in this Github Repository

I have added some support for RGB if you want to pull down the https://github.com/jfarmer08/ha-sengledapi/tree/Dev


[ENTESB-14445] fix initial property and constant value type

The reason for this is explained in detail in ENTESB-14445.
Also I would like to ask, whether this could be backported to 7.8. branch (of course in case the fix I provided makes sense), as this is also present in 7.7.
I know that master will differ from 7.8., but I'm not completely sure what the 7.8. branch is.

Hi @tplevko thanks for the fix! can you create a GH issue with labels (ui, bug) and put cross reference link? We'll use 2.0.x branch for Fuse 7.8.

Thanks @pleacu and @igarashitm. I created xref issue here: https://github.com/atlasmap/atlasmap/issues/2259

Hi @tplevko, can you also create a backport PR for 2.0.x branch?
https://github.com/atlasmap/atlasmap/tree/atlasmap-2.0.x

@igarashitm sure thing, the backport PR is here: https://github.com/atlasmap/atlasmap/pull/2278


sync: fix 'concurrent map writes' error of buffers

Codecov Report

Merging #2524 (a59f9d5) into main (d31cca4) will increase coverage by 0.05%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #2524      +/-   ##
==========================================
+ Coverage   61.64%   61.69%   +0.05%
==========================================
  Files         138      138
  Lines       25698    25699       +1
==========================================
+ Hits        15841    15855      +14
+ Misses       8000     7993       -7
+ Partials     1857     1851       -6

Impacted Files
Coverage Δ

pkg/sync/download.go
75.55% <100.00%> (+0.27%)
:arrow_up:

pkg/meta/redis.go
71.87% <0.00%> (+0.08%)
:arrow_up:

pkg/meta/tkv.go
76.25% <0.00%> (+0.10%)
:arrow_up:

pkg/meta/sql.go
66.04% <0.00%> (+0.13%)
:arrow_up:

pkg/chunk/disk_cache.go
81.79% <0.00%> (+0.43%)
:arrow_up:

pkg/meta/tkv_mem.go
88.43% <0.00%> (+0.57%)
:arrow_up:

pkg/chunk/utils_unix.go
93.33% <0.00%> (+20.00%)
:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Chihuahua coingecko_id "chihuahua-token"

Data is now pulling on coingecko. Please merge this.
https://api.coingecko.com/api/v3/coins/chihuahua-token

Thanks you for adding coingecko-id !

@IbrarMakaveli you're welcome! I'm using the assetlist in my own app, partially for coingecko price change history... (for now until I have a better solution)


wire: New leaf compact serialization format

With leaf compact serialization, the outpoint is left out.  Because of
this, the reader is responsible for filling in that information.
However, with tx messages, inputs may be unconfirmed, resulting in no
leaf data for such inputs.
This caused a problem where you might have 3 inputs but only 2 leaf
datas.  Since the compact leaf data leaves out the outpoint, you don't
know which inputs correspond to which leaf data.
The new serialization method fixes this by forcing the sender to always
send the equal amount of leaf datas for each of the inputs.  If an input
is unconfirmed, you simply send a 0x01, and the reader recognizes this
as leaf data corresponding to an unconfirmed input.
Note that only tx messages are effected and block messages stay the same.
Lastly, the unneccesary block height information from UData is removed.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

71 of 206 (34.47%)  changed or added relevant lines in 9 files are covered.
4 unchanged lines in 2 files lost coverage.
Overall coverage increased (+0.06%) to 51.339%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

wire/msgblock.go
0
2
0.0%

wire/msgtx.go
0
2
0.0%

blockchain/indexers/flatutreexoproofindex.go
0
6
0.0%

blockchain/indexers/utreexoproofindex.go
0
6
0.0%

wire/leaf.go
39
47
82.98%

wire/udata.go
32
41
78.05%

mempool/mempool.go
0
14
0.0%

blockchain/utreexoviewpoint.go
0
34
0.0%

server.go
0
54
0.0%

Files with Coverage Reduction
New Missed Lines
%

connmgr/connmanager.go
2
86.07%

server.go
2
0%

Totals

Change from base Build<PHONE_NUMBER>:
0.06%

Covered Lines:
21847

Relevant Lines:
42554

💛  - Coveralls


cc!stats power up

Issues:

cc!stats prints to the channel but doesn't write to the database
We are getting minimal data collection (only online, offline, total)
We don't have a table setup in the database to collect stats

Goals:

[ ] Decide on the table schema for collecting server insights (what to collect)
[ ] Set up codebase to use that table
[ ] Decide at what interval to collect data
[ ] Update command to collect the data
[ ] Update command to log to the db

No objections from me! It's been almost a week and nobody spoke up, so I'll go ahead an close it.


fix(console): disable pwa

@livio-a @fgerschwiler @adlerhurst this temporarily disables the PWA function of Angular.
This should mitigate some problems we see around broken service-workers.
@peintnermax can you please verify my bad angular skills got it right? 😁

I'd like to try a simpler version first which is hot changing the routing strategy :)
https://github.com/caos/zitadel/pull/2021

we close this in favour of #2021


some prep for experiments later (wip)

[x] data gated qk normalization
[ ] compare to gateloop with same head dim vs taylor expanded qk head dim
[ ] compare against interleaved taylor linear attention and gate loop

performs poorly


Fix Paging issues caused by non-sequential bucket id

The UNION implementation introduced a MergePhase with two different input
sources. To be able to receive data from two different inputs, the bucket ids
had to contain an additional input id in addition to the node id. As a
consequence, bucket ids may not be sequential anymore. The PageDownstreamContext
relied on the sequential nature of the bucket ids and had to be adjusted.
This commit introduces a Set to hold all existing input ids. While sequential
ids allowed to loop over all input ids without storing the input ids itself, the
Set now replaces this functionality by looping over it to retrieve more data
from the inputs.
Regression of 1bf8efe5555087390436a01e26ca6ed49fe9b24d and
dd4ba3a436f93e68ec6e8f267e9a96c305bdc017.

@mxm I think your commit message is a bit misleading as afaik it refers to https://github.com/crate/crate/commit/1bf8efe5555087390436a01e26ca6ed49fe9b24d and not the current state. I think it would be better to state that this one will supersede  https://github.com/crate/crate/commit/dd4ba3a436f93e68ec6e8f267e9a96c305bdc017.

@mxm I think your commit message is a bit misleading as afaik it refers to 1bf8efe and not the current state. I think it would be better to state that this one will supersede dd4ba3a.

I agree that this is ultimately a fix for the first commit but the second tried to fix it but caused other wrong behavior. So I see it as a fix for both.

Codecov Report

Merging #6680 into master will decrease coverage by 0.1%.
The diff coverage is 100%.

@@             Coverage Diff              @@
##             master    #6680      +/-   ##
============================================
- Coverage     82.94%   82.83%   -0.11%
+ Complexity    13365    13353      -12
============================================
  Files          1527     1527
  Lines         49696    49691       -5
  Branches       5957     5956       -1
============================================
- Hits          41219    41161      -58
- Misses         5642     5690      +48
- Partials       2835     2840       +5

Impacted Files
Coverage Δ
Complexity Δ

...main/java/io/crate/jobs/PageDownstreamContext.java
83.22% <100%> (-1.11%)
46 <0> (-3)

.../main/java/io/crate/analyze/AnalyzedStatement.java
0% <0%> (-100%)
0% <0%> (-1%)

...n/java/io/crate/exceptions/JobKilledException.java
0% <0%> (-66.67%)
0% <0%> (-1%)

...java/io/crate/operation/user/AlterUserRequest.java
47.36% <0%> (-42.11%)
5% <0%> (-2%)

...rc/main/java/io/crate/analyze/UnboundAnalyzer.java
52.63% <0%> (-34.22%)
2% <0%> (ø)

...exceptions/GroupByOnArrayUnsupportedException.java
66.66% <0%> (-33.34%)
1% <0%> (-1%)

dex/src/main/java/io/crate/data/Row.java
40% <0%> (-20%)
1% <0%> (ø)

...a/io/crate/exceptions/ContextMissingException.java
81.81% <0%> (-18.19%)
1% <0%> (-1%)

...crate/executor/transport/TransportShardAction.java
73.68% <0%> (-13.16%)
8% <0%> (-1%)

...n/java/io/crate/planner/projection/Projection.java
90% <0%> (-10%)
6% <0%> (-1%)

... and 29 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fe944cc...4eb43fc. Read the comment docs.


bug(parser): missing/unsupported enum syntax in typescript

Parser fails if computed property is provided as key of enum, this synatx should be allowed only for computed properties with string literal value or template literal without arguments.
// should work
enum Foo { ['baz'] }             // ❌ currently fails
enum Foo { [`baz`] }             // ❌ currently fails
enum Foo { ['baz'] = 2 }         // ❌ currently fails
enum Foo { [`baz`] = 2 }         // ❌ currently fails
enum Foo { 'baz' }               // 👍 work fine
enum Foo { baz }                 // 👍 work fine
enum Foo { 'baz' = 2 }           // 👍 work fine
enum Foo { baz = 2 }             // 👍 work fine

// should fail
enum Foo { [foo] }               // Computed property names are not allowed in enums
enum Foo { [1] }                 // An enum member cannot have a numeric name.
enum Foo { [`test${foo}`] }      // Computed property names are not allowed in enums.
enum Foo { `baz` = 2 }           // Enum member expected.
enum Foo { ['baz' + 'baz'] }     // Computed property names are not allowed in enums.

ref https://github.com/microsoft/TypeScript/issues/42468

Fixed in #4543.


Transition: Not working properly when 'show' duration is less than 'hide'

Steps
Create a transition with a show duration smaller than hide duration
<Transition duration={{show: 100, hide: 2000}} animation="fade">

Nippertown

</Transition>

Expected Result
The transition should take 2 seconds to hide the child.
Actual Result
The hide transition will be interrupted at the show duration (e.g. 100 ms) without completing the intended duration (2 seconds).
Version
0.77.0
Testcase
This is reproducible with the example in the documentation. Configure the sliders to reflect a show value less than the show value.

@alphapseudo Thanks for report, fixed in #2350.


Allow associating labels and notifications with workflows

Use case is the following:
tower-cli workflow associate_label --workflow "t" --label "asdf"
tower-cli workflow associate_notification_template --workflow "t" --notification-template "t"

Coverage decreased (-0.09%) to 90.679% when pulling d5d4e654756529dc35195ca764a87cf08d58fb98 on AlanCoding:wfjt_nt into 9638676e0ebc644729674adf91d8fb4ca21ec3d7 on ansible:master.

Coverage decreased (-0.09%) to 90.679% when pulling d5d4e654756529dc35195ca764a87cf08d58fb98 on AlanCoding:wfjt_nt into 9638676e0ebc644729674adf91d8fb4ca21ec3d7 on ansible:master.

Coverage decreased (-0.09%) to 90.679% when pulling d5d4e654756529dc35195ca764a87cf08d58fb98 on AlanCoding:wfjt_nt into 9638676e0ebc644729674adf91d8fb4ca21ec3d7 on ansible:master.

Coverage decreased (-0.1%) to 90.652% when pulling ac31e2559c4974fb039ba8e638e68e41396cec96 on AlanCoding:wfjt_nt into 9638676e0ebc644729674adf91d8fb4ca21ec3d7 on ansible:master.


LookupResolver: reverse relationship between LookupNetIP() and LookupIP()

avoid redundant conversions by doing the work on net.IP as
returned by github.com/miekg/dns

v0.4.2 tagged


Add better docs on setting up postgresql db

Description
This fixes #1747
Checklist

[ ] Commit sequence broadly makes sense
[ ] Commits have useful messages
[ ] New tests are added if needed and existing tests are updated
[ ] Any changes are noted in the changelog
[ ] Code is formatted with fourmolu on version <IP_ADDRESS> (which can be run with scripts/fourmolize.sh)
[ ] Self-reviewed the diff

Migrations

[ ] The pr causes a breaking change of type a,b or c
[ ] If there is a breaking change, the pr includes a database migration and/or a fix process for old values, so that upgrade is possible
[ ] Resyncing and running the migrations provided will result in the same database semantically

If there is a breaking change, especially a big one, please add a justification here. Please elaborate
more what the migration achieves, what it cannot achieve or why a migration is not possible.

Good idea!
I'd also like you to add this to one of:

https://github.com/IntersectMBO/cardano-db-sync/blob/master/doc/running.md
https://github.com/IntersectMBO/cardano-db-sync/blob/master/doc/installing.md
https://github.com/IntersectMBO/cardano-db-sync/blob/master/doc/installing-with-nix.md

Further, I'm wondering if we need to keep this document around, since all the information seems to be covered in the documents above

@sgillespie agreed I feel like we need to get this into a better shape all together because the new stuff is good but some of the historic is slightly outdated and spread across multiple files in slightly non logical ways.


Listener behind NAT - Agent switch from public Ip adress to private

Hi,
I have two listeners :

(Same default profile, staging key etc..)
When i generate a stager based on the http_foreign listener, and execute it, i got a connexion on my listener and agent is deployed.

The problem is that I can't interract with my agents after that.
When i checked with wireshark, i noticed that my agent try now to connect to the private ip adresse (defined in the listener pub5)...

It seems my agent settings are updated with the settings of the "real" listener after initialization.
Is there any way to avoid that ?
Thanks a lot :-)

Hi,
Instead of 2 listeners, it would be preferable to be able to use a single listener, with the Host option pointing to the public IP and port, and with the BindIP and Port options set to the private (behind NAT and port forwarding) values:
(Empire: listeners/http) > set Host http://publicIP:publicPort
(Empire: listeners/http) > set BindIP privateIP
(Empire: listeners/http) > set Port privatePort
However, this is not currently possible because setting the Host option automatically modifies the Port option, and vice versa.
Commit https://github.com/jetsecurity/Empire/commit/cb1cb96306cfb2b44eebf29470a37aec840d84ad is a quick fix allowing to set distinct port values in the Host and Port options:
Nevertheless, I suppose some things still need to be sorted out before a clean fix:

Changing the settings behavior might disturb existing users. Maybe setting the Port option to a default empty value might help. This way, the Port option would still be automatically updated when the Host option is set.
Should the Port option be renamed BindPort for clarity?
The listeners code will still overwrite the Host option if BindIP is an IPv6 address (see https://github.com/jetsecurity/Empire/blob/b8cda099ce4856044d8dc4c61dd85400d7314505/lib/listeners/http.py#L271-L280 for example).

PS: Using 2 listeners doesn't work because the agent is eventually updated with the in use listener options, thus configuring the agent with the private IP addres:https://github.com/EmpireProject/Empire/blob/b8cda099ce4856044d8dc4c61dd85400d7314505/lib/listeners/http.py#L942-L950

@jetsecurity Thanks for the PR. @qbiguenet I will try to address this soon.

@jetsecurity  So I tried to reproduce this issue by using socat in front of an Empire server. Setting the BindIP to the Empire server and the host option to the external redirector. I did not experience any issues with staging or executing commands. @jetsecurity can you test this again?

The problem only occurs if you want (or have) to use a different listening port than the public port. Notably, if you are behind port forwarding with a public port different than the port Empire listens on. I suspect https://github.com/EmpireProject/Empire/issues/842 is also the same issue.
Let's say you have this port forwarding setup: publicIP:443 -> privateIP:1234. It should be possible to do:
(Empire: listeners/http) > set Host http://publicIP:443
(Empire: listeners/http) > set BindIP privateIP
(Empire: listeners/http) > set Port 1234
Empire would listen on privateIP:1234 while the agent would try to connect to publicIP:443.
However, setting the Port option automatically updates the Host option, resulting in Host being equal to http://publicIP:1234. Same thing the other way.
As a workaround, @qbiguenet tried to use two different listeners: one with the public IP and port, just to setup the agent, and one with the private IP and port which is actually listening. This solution didn't work because, at the end of the staging process, the agent is updated with the configuration of the listener it is connected to (consequently, with the private IP and port, and of course the agent doesn't know the private IP).
So it should be possible to use only one listener, but to not automatically update the port value in the Host option when a user sets the Port option (and to not automatically update the Port option when setting the Host option). That's what jetsecurity/Empire@cb1cb96 proposes.
However, as mentioned, this new behavior might disturb previous users which were used to only set the Host option, with Empire automatically setting the BindIP and Port options accordingly.
In addition, it might be a good idea to rename the Port option to BindPort for clarity. Thus, the Host option would be clearly dedicated to public connection details, while the BindIP and BindPort options would determine on which local IP and port Empire really listens.

@qbiguenet @jetsecurity so take a look at this issue: #363 and #482. Specifically I would recommend trying the steps I outlined in 363. If you use a http_foreign listener as well as a http listener, with different ports, the agent should still stage and operate normally. I'll test out your PR later this evening @jetsecurity. Thanks

Steps in #363 seems to be what @qbiguenet tried. In his first screenshot we can see he's using a foreign http listener with the public IP and port, and and a regular http listener with the local IP and port.
However, he experienced what seems to be the same issue as in #482: at first, the agent is able to connect back (so the listener reports a new connection), but at the end of the staging process, the agent is updated with the configuration of the listener that actually received the connection (the regular http listener configured with the local IP and port).
It should be noted that the 2.0_beta branch was merged between the working steps provided on April 6, and the issue #482 on April 9. So I suppose the big changes in 2.0_beta made impossible to use the steps provided in issue #363.
More precisely, the issue seems to come from the following code:
First, even if the agent is setup with the foreign listener, the line below sets listenerOptions to the listener which is really in use, so the regular http listener which actually received the connection:
https://github.com/EmpireProject/Empire/blob/b8cda099ce4856044d8dc4c61dd85400d7314505/lib/listeners/http.py#L191
Second, at the end of the staging process, the agent configuration is updated with these listenerOptions:
https://github.com/EmpireProject/Empire/blob/b8cda099ce4856044d8dc4c61dd85400d7314505/lib/listeners/http.py#L947-L950
To confirm this scenario, it's possible to print the value of tempListenerOptions['Host']['Value'] before the above lines. It will print the private IP address.
That's why the agent stops communicating with the IP and port provided in the foreign listener and then tries to connect to the private IP and port provided in the regular http listener. At this stage, we can see the connection attempts to the private IP in the Wireshark capture by @qbiguenet.

Fixed in #847


[SPARK-40411][SS] Refactor FlatMapGroupsWithStateExec to have a parent trait

What changes were proposed in this pull request?
This PR proposes to factor the common attributes out from FlatMapGroupsWithStateExec to FlatMapGroupsWithStateExecBase.
Why are the changes needed?
There are a lot of stuff to share if you implement another version of FlatMapGroupsWithStateExec.
Should better factor them out. This is also part of https://github.com/apache/spark/pull/37285 which demonstrates how the refactored trait is used.
Does this PR introduce any user-facing change?
No, this is refactoring-only.
How was this patch tested?
Existing test cases should cover it.

cc @HeartSaVioR and @viirya FYI

Let me get this in - I am pretty much confident that this is the right change too :-).
Merged to master.


[libebur128] update to 1.2.6; fixes dynamic linking on Windows

Fixes #16078

Thanks for the update!


Save XMM registers between exits and fix bug in NtCreateFileHook

Adding saving of XMM registers between exits.
Simplified the logic in NtCreateFileHook. The changed logic also removes a bug I experienced due to reading memory outside of the allocated pool. This is because wcsstr(kObjectName.Buffer, L"test.txt") assumes the buffer in a UNICODE_STRING is null-terminated, which isn't guaranteed to be true.
Updated the IA-32 submodule because the code doesn't compile right out of the box due to a reference to a renamed constant.
Added newlines to each log as WinDBG doesn't append newlines to log entries by default.

Hey there, thanks a lot for the contribution. The code looks good from my end, but I have no CI set up to do a sanity check. It might seem unnecessary, but can you show me a screenshot of this PR running on the version of Win10 you are attempting to port to? I appreciate it.

Sorry for the delay. Here's a screenshot of it on 1909:

No worries, thank you for the contribution!


[Bug]: Disconnected from the server after I upload spectrum

Guidelines

[X] I agree to follow this project's Contributing Guidelines.

Project Version
No response
Platform and OS Version
No response
Existing Issues
No response
What happened?
After I upload a spectrum, I am disconnected from the server and the page requests me to reload. I cannot compare or analyze any spectrum in SPC format.

Steps to reproduce

Click "browse"
Upload my file in SPC format
Choose the preprocessing and identification options.
...

Expected behavior
It is expected that after I upload the spectrum, I can preprocess and identify the particle spectrum
Attachments
No response
Screenshots or Videos

Additional Information
No response

This sounds like Shiny app problem. I transfer the issue there.


Feature request: Excluding files from report

Hey, thanks for writing this action, it's great!
I have a use case where I want to exclude certain files from the pull request coverage report. I have already done this on the Jacoco side of things when generating the coverage report and have removed files that end in names like "Fragment" or "View". This is working correctly, as they are not visible in the HTML report Jacoco itself creates.
However, when creating a pull request, this action still shows those files if they have been changed at all in the PR. I would like a way to remove them.

In the above image - even though I've changed the Fragment and View files, I don't want them showing up because they've been filtered out of the Jacoco report.

Hey @jarrodrobins, could you check if CreatePasscodeFragment is present or not in the jacoco's XML report? Ideally, the action compares the entries in the XML report with the PR's changed files.
We will test this out and get back.

Hi @thsaravana - I think this may have simply been a false alarm, apologies for wasting your time!
After your message I went digging further into the report and realised I had two issues -

My exclusions weren't smart enough: internal classes weren't being filtered out properly (onClickListeners, as an example). Basically by filtering out files with $ in them sorted this one out.
I misread the output. The Jacoco report lists class names whereas your plugin lists files. So, files which contain multiple classes would not show up in the report but would show up on a pull request. For example, a view class which I excluded would still show up in the report if I had a Kotlin extension function on, eg, a model object.

So actually there's nothing wrong here at all, just me. 😅 One possible improvement (or option) could be to display classes instead of files, like the Jacoco report does?


Can Not Set MCMMO requirements

I'm in the middle of trying to setup a quest and I'm at the MCMMO requirements and this comes up no matter what I do.
Doing /quest put me out of the menu and back to the setup of that quest, so nothing lost. I do have the newer MCMMO made by the original devs. Not sure if that matters
What is your Quests version / build number (do not say "latest")?
v3.7.3
Describe the problem and how to replicate it. Any console errors to post using Pastebin.com?
https://pastebin.com/MYmteTXC
If applicable, can you provide an example quest from quests.yml using Pastebin.com?
Still in the middle of creating the quest. It's my first quest ever so I don't have any files for it.

Duplicate of #853
mcMMO Overhaul not yet supported. See #794


[POC] Adding OIDC login functionality

Description
Closing #1450
POCing the OpenID Connect passwordless logon mechanism for Azure AD.
Pipeline references

Pipeline

https://github.com/MariusStorhaug/ResourceModules/runs/6661434629?check_suite_focus=true#step:4:235
Type of Change
Please delete options that are not relevant.

[ ] Bugfix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Update to documentation

Checklist

[x] I'm sure there are no other open Pull Requests for the same update/change
[x] My corresponding pipelines / checks run clean and green without any errors or warnings
[x] My code follows the style guidelines of this project
[x] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation (readme)
[ ] I did format my code

@mblant Any input from you regarding swapping out the current SPN + Secret with OIDC federation for GH Action logon? It another breaking change but think we should lead by example and push customers to a more secure setup. Thoughts?

@jontreynes ARM_CLIENT_ID is indeed the GUID appID of the app registration yes.


[Sort Multi Bit] Upgrade to malicious + semi honest ipa now calls multi bit sort

This will have some small conflicts with #387. https://github.com/andyleiserson/ipa/commits/multi_bit may be useful for resolving them.

This will have some small conflicts with #387. https://github.com/andyleiserson/ipa/commits/multi_bit may be useful for resolving them.
(One thing I am doing in #387 is removing the MaliciousUpgradeInput step. Since each of the upgrades is done with a separate MaliciousValidator, it's not necessary to narrow the context used for the upgrade -- an upgrade context is created as part of the malicious validator creation.)

Let me wait for you to land the code and then I will make the changes. Since there might be some code-restructure I can re-use from your PR

Closing this since this needs a bit of a refactor to use upgrade on a slice of num_multi_bits per record


[Hub Generated] Review request for Microsoft.DBforPostgreSQL to add version preview/2023-06-01-preview

ARM (Control Plane) API Specification Update Pull Request
Changes included in this PR:

New preview API version added: 2023-06-01-preview
Azure Defender / Threat protection APIs support added to this new API version.
VirtualEndpoint APIs and SiteSwap support for read replicas.
Pre-migration Validation API and support for other source types for Migration to PG flexible servers.
Private Endpoint feature support.
PremiumV2_LRS storage type support for PG flexible servers.
Quota usages API feature support.
PG version 16 support for provisioning.

PR review workflow diagram
Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

[1] ARM review queue (for merge queues, see [4])
The PRs are processed by time opened, ascending. Your PR may show up on 2nd or later page.
If you addressed Step 1 from the diagram and your PR is not showing up in the queue, ensure the label ARMChangesRequested
is removed from your PR. This should cause the label WaitForARMFeedback to be added.
[2] https://aka.ms/azsdk/support/specreview-channel
[3] List of SDK breaking changes approvers in pinned Teams announcement
[4] public repo merge queue, private repo merge queue (for ARM review queue, [1])
If you need further help with anything, see Getting help section below.
Purpose of this PR
What's the purpose of this PR? Check all that apply. This is mandatory!

[X ] New API version. (Such PR should have been generated with OpenAPI Hub, per this wiki doc.)
[ ] Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
[ ] Update existing version to fix swagger quality issues in S360.
[ ] Other, please clarify:

edit this with your clarification

Due diligence checklist
To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:

[X ] I confirm this PR is modifying Azure Resource Manager (ARM) related specifications, and not data plane related specifications.
[X ] I have reviewed following Resource Provider guidelines, including
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can proceed to Step 2, "ARM Review", for this PR.

Breaking changes review (Step 1)

If the automation determines you have breaking changes, i.e. Step 1 from the diagram applies to you,
you must follow the breaking changes process.
IMPORTANT This applies even if:

The tool fails while it shouldn't, e.g. due to runtime exception, or incorrect detection of breaking changes.
You believe there is no need for you to request breaking change approval, for any reason.
Such claims must be reviewed, and the process is the same.

ARM API changes review (Step 2)

If this PR is in purview of ARM review then automation will add the ARMReview label.
If you want to force ARM review, add the label yourself.
Proceed according to the diagram at the top of this comment.

Viewing API changes
For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.
Suppressing failures
If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
Swagger-Suppression-Process
to get approval.
Getting help

For general PR approval workflow, see the diagram at the top of this comment.
For guidance on fixing this PR CI check failures, see the hyperlinks provided in given failure
and https://aka.ms/ci-fix.
If the help provided by the previous points is not enough, post to https://aka.ms/azsdk/support/specreview-channel and link to this PR.

Pending lintDiff errors are due to our service not still supporting the new API guidelines for PUT request. PUT request still returns 202 Accepted. This is a big change and our service team needs time to get this fixed. We are currently following the same design across Azure Data.

Pending lintDiff errors are due to our service not still supporting the new API guidelines for PUT request. PUT request still returns 202 Accepted. This is a big change and our service team needs time to get this fixed. We are currently following the same design across Azure Data.

It is required to use 200 and 201 for PUT. Please also fix ProvisioningStateSpecifiedForLROPut and ProvisioningStateSpecifiedForLROPatch in https://github.com/Azure/azure-rest-api-specs/pull/26065/checks?check_run_id=17572007366. Then remove ARMChangesRequested label for another review.

Pending lintDiff errors are due to our service not still supporting the new API guidelines for PUT request. PUT request still returns 202 Accepted. This is a big change and our service team needs time to get this fixed. We are currently following the same design across Azure Data.

It is required to use 200 and 201 for PUT. Please also fix ProvisioningStateSpecifiedForLROPut and ProvisioningStateSpecifiedForLROPatch in https://github.com/Azure/azure-rest-api-specs/pull/26065/checks?check_run_id=17572007366. Then remove ARMChangesRequested label for another review.

I have raised this as a question in this channel https://teams.microsoft.com/l/message/19:0351f5f9404446e4b4fd4eaf2c27448d@thread.skype/1697462898804?tenantId=72f988bf-86f1-41af-91ab-2d7cd011db47&groupId=3e17dcb0-4257-4a30-b843-77f47f1d4121&parentMessageId=1697462898804&teamName=Azure SDK&channelName=API Spec Review&createdTime=1697462898804. Also I have raised this in stackoverflow https://stackoverflow.microsoft.com/questions/374232

Hi @ambrahma, please fix azure-sdk-for-go Duplicate Schema error.

/pr RequestMerge


Crash after breaking some Canola Crops

https://paste.dimdev.org/usixerarid.mccrash

It's impossible for this to be caused by VanillaFix.

Could this be caused by JEID, though?
https://github.com/DimensionalDevelopment/JustEnoughIDs/issues/7


Add instances?

Should this library (or a companion library) include instances for common types, such as those found here?

We already do some such instances. I think if these are Plutus-related, then they definitely do belong, but it also requires canonical Plutarch lifts, which not everything has yet.

Closed as stale


java.lang.IllegalStateException: Jenkins.instance

I ran into the following issue:
java.lang.IllegalStateException: Jenkins.instance is missing. Read the documentation of Jenkins.getInstanceOrNull to see what you are doing wrong.
        at jenkins.model.Jenkins.get(Jenkins.java:778)
        at hudson.model.Descriptor.getConfigFile(Descriptor.java:904)
        at hudson.model.Descriptor.load(Descriptor.java:892)
        at org.jenkinsci.plugins.pipeline.milestone.MilestoneStep$DescriptorImpl.load(MilestoneStep.java:105)
        at org.jenkinsci.plugins.pipeline.milestone.MilestoneStep$DescriptorImpl.<init>(MilestoneStep.java:90)
        at java.lang.Class.newInstance(Class.java:442)
        at com.homeaway.devtools.jenkins.testing.APipelineExtensionDetector.getPipelineSteps(APipelineExtensionDetector.java:83)
        at com.homeaway.devtools.jenkins.testing.JenkinsPipelineSpecification.setupSpec(JenkinsPipelineSpecification.groovy:1005)

What code did you write and run to cause that?

I updated my pom.xml to have the following:
      <groupId>org.jenkins-ci.plugins</groupId>
      <artifactId>plugin</artifactId>
      <version>4.2</version>
      <relativePath />
    </parent>```

and I ran this test that ran into the issue:

```import com.homeaway.devtools.jenkins.testing.JenkinsPipelineSpecification

class CiBuildTriggersHelperSpec extends JenkinsPipelineSpecification {

    def ciBuildTriggersHelper = null

    def setup(){
        ciBuildTriggersHelper = loadPipelineScriptForTest('vars/ciBuildTriggersApp.groovy')
    }

pom.xml.zip

@awittha Thank you for the quick response. I don't know if this make a difference, but the unit test ran without issue before I modified the pom.xml to have ``org.jenkins-ci.pluginsas parent and added some dependencies to comply upper bound dependency caused by enforce plugin. Additionally,ciBuildTriggersApp.groovydoesn'timport jenkins.model.Jenkins``` or doesn't used that object explicitly.

Before updating your pom.xml parent...
Was your parent pom an older version of the Jenkins plugin parent pom? That is to say, is your project a Jenkins plugin?
Or, was your parent pom something else?

I didn't have a parent in the older pom.xml. Below is the pom.xml content that run unit test without issue.
<?xml version="1.0" encoding="UTF-8"?>
<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd">
    <modelVersion>4.0.0</modelVersion>
    <groupId>com.intusurg.spr.jenkins</groupId>
    <artifactId>jenkins-shared-lib</artifactId>
    <packaging>jar</packaging>
    <version>0.4.0</version>
    <description>Jenkins Shared Library</description>

    <repositories>
        <repository>
            <id>jenkins-releases</id>
            <name>Jenkins Releases</name>
            <url>http://repo.jenkins-ci.org/releases</url>
        </repository>
    </repositories>

    <properties>
        <groovy.core.version>2.4.11</groovy.core.version>
        <groovy.gmaven.pluginVersion>1.6.1</groovy.gmaven.pluginVersion>
        <google.guava.version>20.0</google.guava.version>

        <jenkins-spock.version>2.0.0</jenkins-spock.version>
        <jenkins.version>2.102</jenkins.version>
        <jenkins.servlet.version>3.1.0</jenkins.servlet.version>
        <jenkins.workflow.cps.version>2.36</jenkins.workflow.cps.version>
        <jenkins.workflow.step.version>2.10</jenkins.workflow.step.version>
        <jenkins.workflow.basic.steps.version>2.6</jenkins.workflow.basic.steps.version>
        <jenkins.workflow.durable.task.steps.version>2.21</jenkins.workflow.durable.task.steps.version>
        <jenkins.pipeline.stage.step.version>2.3</jenkins.pipeline.stage.step.version>
        <jenkins.git.version>3.9.1</jenkins.git.version>

        <junit.version>4.12</junit.version>
        <junit.plugin.version>1.24</junit.plugin.version>
        <pipeline-utility-steps>2.3.1</pipeline-utility-steps>
        <surefire.pluginVersion>2.22.0</surefire.pluginVersion>

        <logback.configration>logback-test.xml</logback.configration>
        <logdir>${project.build.directory}/log</logdir>
        <test.loglevel>ERROR</test.loglevel>
        <log.logback.version>1.2.3</log.logback.version>
        <log.slf4j.version>1.7.25</log.slf4j.version>
        <build-user-vars-plugin.version>1.5</build-user-vars-plugin.version>

        <sonar.host.url>https://sonarqube-dev.corp.intusurg.com</sonar.host.url>
        <sonar.projectName>Jenkins Shared Library</sonar.projectName>
        <sonar.projectKey>jenkins-shared-lib</sonar.projectKey>
        <sonar.sources>src</sonar.sources>
        <sonar.tests>test</sonar.tests>
        <sonar.groovy.jacoco.reportPath>target/jacoco.exec</sonar.groovy.jacoco.reportPath>
    </properties>
    <dependencyManagement>
        <dependencies>
            <!--  Generally, I'd say you shouldn't use the Jenkins plugin parent pom, if your project is not a Jenkins plugin.

ciBuildTriggersApp.groovy doesn't  import jenkins.model.Jenkins or doesn't used that object explicitly.

Yeah, it's coming from here: https://github.com/jenkinsci/pipeline-milestone-step-plugin/blob/master/src/main/java/org/jenkinsci/plugins/pipeline/milestone/MilestoneStep.java#L105
when MilestoneStep's Descriptor is instantiated (as must be done by jenkins-spock in order to get the name of the step and set up the correct mock), MilestoneStep tries to load configuration from Jenkins... but there is no Jenkins. The specific path it uses hits Jenkins.get(), which isn't stubbed like all of the other Jenkins.get....() methods.
I don't know why, exactly, the parent pom.xml change caused this to surface, but if I had to guess I'd guess that adding the parent pom (or some of the other pom changes you mentioned) brought the Milestone plugin onto the classpath, causing jenkins-spock to try to work with it.
You'd have gotten a different error - one that you could maybe work around by adding stubbing to the Jenkins mock - if Jenkins.get() had been properly stubbed.

That makes sense. Thank you very much for the explanation. Just want to clarify, as of now there is no work around beside not having the parent pom.xml because Jenkins wasn't stubbed properly by jenkins-spock?

as of now there is no work around beside not having the parent pom.xml because Jenkins wasn't stubbed properly by jenkins-spock?

Actually...
I misspoke earlier. This is happening before  any Specification-specific stuff happens... this is happening during static setup of the test-suite, before any mocks exist.
There will never be a mock Jenkins at that time. This makes sense, because looking closer at the code, this actually would have worked if it had happened after the mock Jenkins was created by jenkins-spock.

The stack trace starts here: https://github.com/ExpediaGroup/jenkins-spock/blob/ebdaf89887cce6552d52349af7b703e365b76430/src/main/groovy/com/homeaway/devtools/jenkins/testing/JenkinsPipelineSpecification.groovy#L1005
in static setup before the JenkinsPipelineSpecification runs any tests or creates any mocks - it's still identifying what it will need to mock.
That leads to it instantiating MilestoneStep.DescriptorImpl and running into the load() step from here: https://github.com/jenkinsci/pipeline-milestone-step-plugin/blob/master/src/main/java/org/jenkinsci/plugins/pipeline/milestone/MilestoneStep.java#L105
the implementation of which unfortunately calls Jenkins.get().
There is, indeed, no real Jenkins and no mock Jenkins at this time.
There cannot be, either... because this is static setup, not specific to any test case. A mock created and used here will either be inaccessible during any test or shared across all tests.
I am not sure how to fix this, anymore. I'll think about it.

In this case, it's extra-tough because MilestoneStep.DescriptorImpl is a static final class. We probably cannot mock or stub it or otherwise modify its behavior, so it's probably always going to try to load().
This kind of instantiation- or classload-time (truly static) Jenkins-dependent setup is very frustrating for offline unit-tests; Milestone is far from the only bit of code to to this.
Maybe a special mock Jenkins created and used only at static setup-time just to placate these kinds of setup?
But even then, that won't work properly because there is no way for you, the test author, to access that mock and stub it to do what the step expects. How can you stub the implementation of load() so that Milestone is happy? Where would you write that test code? In setupSpec in your own Specification? Well... the parent setupSpec is run first, per Spock's design, so that method is "too late." But of course, if your code could run before the parent's setupSpec, the mock Jenkins wouldn't be around for you to stub!

FOR NOW, just exclude the Milestone jenkins plugin from your project if you can.
If your code-under-test actually uses it... then I don't know what to tell you.

@awittha I will exclude Milestone jenkins plugin from my project since none of my code under test is not using it. I think the parent org.jenkins-ci.plugins pom.xml has the milestone plugin. Do you know a way to exclude it from the parent pom.xml or it's something I have to not have the parent and add dependency as needed? Again thank you very much for your support.

If the parent pom has it as a direct <dependency>, there's nothing you can do from a child pom.
If the parent pom has some dependency that has the Milestone plugin as a transitive dependency, you need a Maven exclusion for the Milestone plugin, placed in the declaration of whichever dependency(ies) are depending on the Milestone plugin.
You can run mvn dependency:tree and search for "milestone" to locate the plugin(s) that are bringing it in.

The core problem should be resolved in jenkins-spock:2.1.4.
Depending on the situation, there are still several ways to resolve the original exception. In this case, I believe excluding the Milestone plugin (if your code actually doesn't use it) is still the right choice.
Other options are now detailed in the documentation. See https://github.com/ExpediaGroup/jenkins-spock/blob/master/src/test/groovy/com/homeaway/devtools/jenkins/testing/DescriptorTimeJenkinsInteractingSpec.groovy for an example of how you might handle the situation where you actually needed the milestone step.


bug(Badge): Badge only displays single-digit numbers

Is this a regression?

[x] Yes, this behavior used to work in the previous version

The previous version in which this bug was not present was
19.0.0-next.3
Description
Starting 19.0.0-next.4, matBadge only displays a single digit.
Here "Icon with a badge" should display "15":

As it does in Angular Material docs (with older version of Angular Material):

Reproduction
StackBlitz link: https://stackblitz.com/edit/tnwnbh?file=package.json
Expected Behavior
Display at least 2-3 digits. That "..." takes the same space as the second digit would.
Actual Behavior
matBadge only displays a single digit only, then adds "..." if more digits.
Environment

Angular: 19
CDK/Material: 19.0.0-next.8
Browser(s): Google Chrome!
Operating System (e.g. Windows, macOS, Ubuntu): macOS

Nevermind, it's duplicate of https://github.com/angular/components/issues/29788


⚠ API - Lens has degraded performance

In 12caf93, API - Lens ($LENS_API_URL) experienced degraded performance:

HTTP code: 503
Response time: 332 ms

Resolved: API - Lens performance has improved in 47d50bc after 8 minutes.


'Can't resolve 'material-ui/AutoComplete'

Hello!
Still new to programming, and I'm not quite sure what to do. This is the error I keep getting as soon as I download redux-form-material-ui and start importing section from this repo. I don't have a single file asking about autocomplete.
./node_modules/redux-form-material-ui/lib/AutoComplete.js
Module not found: Can't resolve 'material-ui/AutoComplete' in ...'/node_modules/redux-form-material-ui/lib'
_Imported_
import React from 'react';
import PropTypes from 'prop-types';

// redux validation form for material UI
import { Field, reduxForm } from 'redux-form';
import {
  AutoComplete,
  Checkbox,
  SelectField,
  TextField,
} from 'redux-form-material-ui';

// material UI
import { withStyles } from 'material-ui/styles';
import Input, { InputLabel, InputAdornment } from 'material-ui/Input';
import { MenuItem } from 'material-ui/Menu';
import FileUpload from 'material-ui-icons/FileUpload';
import Button from 'material-ui/Button';
import Typography from 'material-ui/Typography';

_package.json_
"material-ui": "^1.0.0-beta.21"
"redux-form-material-ui": "^4.3.1"
"react": "^16.1.1"

please help!

Auto Complete was a module in the material-ui v0.19.4 spec, it appears in the material-ui 1.0.0-beta release that the former Auto Complete module has been deprecated and the usage moved to a property based on the relative components API - accepting either a string or a Boolean value. (Pulled from the 1.0.0 beta docs. For example:
<TextField  id="password"           label="Password"           className={classes.textField}           type="password"           **autoComplete="current-password"**           margin="normal" />
Furthermore, in the material-ui 1.0.0 beta documents there is a section for Autocomplete component API which immediately references usage of the react-autosuggest npm pacakge, find that here. The material-ui docs are written in somewhat poor context to their usage, but alas, this is why I bolden beta as this is what to expect from incomplete distributions. react-auto-suggest accepts a statement with an object to populate the relative component/<TextField> that I suspect you are trying to implement given you code example. If you would like to cease the error you have experienced when you are compiling, remove the v0.19.4 reference to import AutoComplete as it does not correlate to the version of material-ui you are using.
Also, for someone 'new to programming' you have an awful lot of git repo's/commits. Suppose new is 'relative' in this case. Hope my input helps some.

Thank you for the help! I really appreciate it.
As for my GitHub, I recently attended a coding bootcamp June to October, so
I pretty much lived and breathed coding. Now I'm a full fledged software
engineer! So newish I guess :)
Respectfully,
Katherine Lane
https://github.com/MaeDae11
https://www.linkedin.com/in/katherine-lane/
https://medium.com/@katherinelane11
On Mon, Nov 27, 2017 at 2:09 PM, Seetotheody<EMAIL_ADDRESS>wrote:

Auto Complete was a module in the material-ui v0.19.4 spec, it appears in
the material-ui 1.0.0-beta release that the former Auto Complete module
has been deprecated and the usage moved to a property based on the relative
components API - accepting either a string or a Boolean value.
(Pulled from the 1.0.0 beta docs
https://material-ui-next.com/demos/text-fields/. For example:
<TextField id="password" label="Password" className={classes.textField}
type="password" autoComplete="current-password" margin="normal" />
Furthermore, in the material-ui 1.0.0 beta documents there is a section
for Autocomplete component API which immediately references usage of the
react-autosuggest npm pacakge, find that here
https://github.com/moroshko/react-autosuggest. The material-ui docs are
written in somewhat poor context to their usage, but alas, this is why I
bolden beta as this is what to expect from incomplete distributions.
react-auto-suggest accepts a statement with an object to populate the
relative component/ that I suspect you are trying to implement
given you code example. If you would like to cease the error you have
experienced when you are compiling, remove the v0.19.4 reference to import
AutoComplete as it does not correlate to the version of material-ui you
are using.
Also, for someone 'new to programming' you have an awful lot of git
repo's/commits. Suppose new is 'relative' in this case. Hope my input helps
some.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/erikras/redux-form-material-ui/issues/199#issuecomment-347291722,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AZogm9ms_JvwMxs9O9yxX-cLY04ojGK4ks5s6wjxgaJpZM4QqjLa
.

"https://material-ui.com/components/autocomplete/#autocomplete"
This is how material-ui import Autocomplete. But i still got the error: Module not found: Can't resolve '@material-ui/core/Autocomplete'
I can not get it.

"https://material-ui.com/components/autocomplete/#autocomplete"
This is how material-ui import Autocomplete. But i still got the error: Module not found: Can't resolve '@material-ui/lab/Autocomplete'
I can not get it.

same

"https://material-ui.com/components/autocomplete/#autocomplete"
This is how material-ui import Autocomplete. But i still got the error: Module not found: Can't resolve '@material-ui/lab/Autocomplete'
I can not get it.

same

Same

use: npm install @material-ui/lab --save
and try again

use: npm install @material-ui/lab --save
and try again

It's resolved this problem


Tests for include/data

This is the first tranche of tests, starting with the container-like classes in include/data (FluidTensor, FluidTensorView, FluidTensorSupport, FluidDataSet). Coverage is not yet complete...

Everything is runnable through CTest, via CMake so these should be CI friendly
Introduces new dependencies: catch2  and ApprovalTests.cpp (only when testing is enabled)
Some additional plumbing done to support testing for assert deaths and compile time stuff. Both of these work, but could be better

I think this covers the spectrum of types of testing we'll need. Catch is pretty easy to use for regular tests (and does a bunch of other stuff I haven't really investigated properly yet), and the approval testing will be invaluable for those things that are just hard to test in other ways (though it takes some getting used to).
To enable tests pass -DFLUCOMA_TESTS=On to CMake. This will lengthen the configure time quite markedly, so it's not on by default. Tests should then be build when you run make or whatever (again, lengthening the build time appreciably).
To run, you can call ctest . or make test or ninja test  rom your build folder. Depending on your generator it might want more flags passing (e.g. in Xcode).

The compilation tests take much longer than the other ones, because they're trying to build there and then. I think there's probably some exclusion flag we can use with CTest when we don't want to be bothered with them
Compilation tests should be sparingly used: they're really only needed for testing static_asserts: there are facilities within Catch that can help with other types of compile time tests.
Getting the most out of the approval tests requires having a compatible diff & merge tool installed (although there are ways to override that, and it's automatically suppressed in CI contexts). Weirdly Apple FileMerge isn't such a thing, so I've ended up installed kdiff3. This only applies when you're making a new approval test, or breaking an existing one. The rest of the time they should just work.

Congrats! Let me know if/how I can help. IIUC it changes nothing for -DFLUCOMA_TESTS=OFF or is there anything to check out for?

Indeed, not passing -DFLUCOMA_TESTS=ON or setting to something falseish should leave other things unchanged.

Let me know anything you would need me to check.

Checking out and confirming that you can work as normal without tests enabled would be useful, but not as a high priority. There's nothing in the tests to intersect hugely with your day to day at the moment, but at some point I'm sure you'll need to know how to run them.
I guess the next job here is to get a workflow set up to run them so we can get the CI train a-chugging.

It all compiles fine, no more warning than usual. I take that it is off by default since I literally pulled that branch in the tip of dev and it all went well.

Great, cheers. Will merge then.


REJEKIBET APK 51.0 VERSI TERBARU APKPHAT.IO

Jelajahi REJEKIBET APK 2024, platform game dengan visual yang memukau, suara yang memukau, dan beragam opsi permainan. Temukan fitur, pengalaman bermain, dan umpan balik komunitas.
Unduh LINK: REJEKIBET APK

Please share the description of the issue that you are facing in Kubernetes (website). As of now, it seems to be an advertisement instead of an issue.

Closing the issue as it seems to be an advertisement.
/close not-planned


wired metaplot using meta profile_psite

Hi Fabio,
I'm attempting to create a metaplot using the metaprofile_psite function. In the figure below, the last blue sample for the 3nt appears to have shifted to the left. Do you have any insights into this?

Any insights or suggestions would be greatly appreciated.
Thank you in advance for your help!
Trista

H i Trista,
thank you for using riboWaltz.
I think that shift is likely caused by the "wrong" identification of the P-site. In the past, I observed this trend when, for some read lengths, the signal related to the start codon was lower than the signal on a codon downstream (often the 5th codon). It looks like this also in your profile, where you have higher peaks at the beginning of the coding sequence than on the start codon. Usually, the P-site offset computed for the sample showing the shift was greater (or smaller, depending on the optimal read extremity) than all the others.
This is the reason why I introduced the flanking parameter in function psite. According to your metaprofile, I think you can try and increase the flanking region to 10 (default is 6). Might be too much, but the idea is to exclude the possibility that reads which are supposed not to have their P-site on the start codon are incorrectly used are reference.
Let me know if this trick works or not.
Best
Fabio

Thank you for your prompt response! It worked perfectly. I appreciate your help!

Best
Trista

Good!
I'll close this issue then. Feel free to open new ones if needed.
Best
Fabio


Update for gfortran

Several changes are made to clean up the Fortran code. The most important one is to remove the Intel-specific form='binary' specifier, which permits gfortran to compile the code without errors.
Additionally, the tabs are removed (addressing the remaining gfortran warnings), everything is re-indented, I switched to using newunit instead of unit, and I'm using the standard kinds (int32, real32, etc) introduced in Fortran 2003.

If these changes are too much, I can remove all the commits except for just the one that updates the form='binary' modifier. To be clear, stream='access' was introduced in the Fortran 2003 standard, so it works in gfortran as well as the Intel Fortran compiler.


[bugFix#3085]fix dag zoom

What is the purpose of the pull request
FIX BUG #3085
Brief change log
jsPlumbHandle.js
dragZoom.js
util.js
Attention:
It is important to note that dragging the canvas is not supported now! Despite this feature before, it didn't actually do much. About dragging the canvas, you can consider other ways to implement under this modification (it can play the effect of pulling the scroll bar)

According to #3085 , i think the method of using jsplumb is not feasible. jsplumb toolkit version is a commercial version(LOL).
I once implemented the function of dragging and dropping canvas, but its performance is not satisfactory. I will be very grateful If u can give me some suggestions.

@break60 please review this PR

good job,thanks for your first contribution.
if you need help, please send mail to<EMAIL_ADDRESS>or my wechat(510570367), when added, please tell me your github id, thx

front end +1

Codecov Report

Merging #3103 into dev will decrease coverage by 6.21%.
The diff coverage is 24.65%.

@@             Coverage Diff              @@
##                dev    #3103      +/-   ##
============================================
- Coverage     39.60%   33.39%   -6.22%
+ Complexity     2717     2372     -345
============================================
  Files           436      441       +5
  Lines         20111    20518     +407
  Branches       2451     2505      +54
============================================
- Hits           7965     6851    -1114
- Misses        11391    13020    +1629
+ Partials        755      647     -108

Impacted Files
Coverage Δ
Complexity Δ

...apache/dolphinscheduler/alert/utils/Constants.java
0.00% <ø> (ø)
0.00 <0.00> (ø)

...scheduler/api/controller/DataSourceController.java
3.63% <0.00%> (ø)
2.00 <0.00> (ø)

...olphinscheduler/api/service/DataSourceService.java
0.61% <0.00%> (-6.67%)
2.00 <0.00> (-3.00)

...nscheduler/api/service/ProcessInstanceService.java
76.40% <0.00%> (ø)
33.00 <0.00> (ø)

.../apache/dolphinscheduler/api/utils/CheckUtils.java
61.53% <ø> (ø)
19.00 <0.00> (ø)

...dolphinscheduler/common/enums/ExecutionStatus.java
60.00% <0.00%> (-1.77%)
3.00 <0.00> (ø)

...apache/dolphinscheduler/common/model/TaskNode.java
37.34% <0.00%> (-1.41%)
15.00 <0.00> (ø)

...inscheduler/common/task/datax/DataxParameters.java
0.00% <0.00%> (ø)
0.00 <0.00> (ø)

...pache/dolphinscheduler/common/utils/DateUtils.java
87.50% <ø> (+0.40%)
26.00 <0.00> (+1.00)

...che/dolphinscheduler/common/utils/HadoopUtils.java
33.99% <0.00%> (+0.49%)
21.00 <0.00> (ø)

... and 137 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b0a7bb4...aca923d. Read the comment docs.

good job,thanks for your first contribution.
if you need help, please send mail to<EMAIL_ADDRESS>or my wechat(510570367), when added, please tell me your github id, thx

THX! I am very happy to contribute to open source software. Thank you for leaving your contact information!


EIA entity harvesting consistency checks fail when few years are loaded

Describe the bug
When a small number of years of EIA 923 / 860 data is loaded into PUDL, the consistency requirements for "static" entity attributes end up crashing the ETL process.
To Reproduce
Attempt to run PUDL ETL with only EIA 923/860 years of [2015, 2016, 2017]
Expected behavior
Users should be able to load smaller numbers of years if they want to, without the ETL crashing. Maybe we the required consistency thresholds need to adjust based on total number of years?

This issue... seems to have gone away.  I hate when that happens without explanation! Ugh.


Issue on first install (npm i -g generator-react-native-ignite)

Issue occurring on initial install.
Steps:
Ran npm install -g react-native-ignite, said it needed root access.
So I ran sudo npm install -g react-native-ignite
This is the output. (Note: cannot run ignite doctor, since hasn't been installed yet, as this is occurring on initial install)

Environment: node v6.4.0, npm  v3.10.7, Mac OS 10.11.5

npm ERR! Darwin 15.5.0
npm ERR! argv "/usr/local/bin/node" "/usr/local/bin/npm" "i" "-g" "generator-react-native-ignite"
npm ERR! node v6.4.0
npm ERR! npm  v3.10.7
npm ERR! path /usr/local/lib/node_modules
npm ERR! code EACCES
npm ERR! errno -13
npm ERR! syscall access

npm ERR! Error: EACCES: permission denied, access '/usr/local/lib/node_modules'
npm ERR!     at Error (native)
npm ERR!  { Error: EACCES: permission denied, access '/usr/local/lib/node_modules'
npm ERR!     at Error (native)
npm ERR!   errno: -13,
npm ERR!   code: 'EACCES',
npm ERR!   syscall: 'access',
npm ERR!   path: '/usr/local/lib/node_modules' }
npm ERR!
npm ERR! Please try running this command again as root/Administrator.

npm ERR! Please include the following file with any support request:
npm ERR!     /usr/local/lib/node_modules/react-native-ignite/npm-debug.log
npm ERR! Darwin 15.5.0
npm ERR! argv "/usr/local/bin/node" "/usr/local/bin/npm" "install" "-g" "react-native-ignite"
npm ERR! node v6.4.0
npm ERR! npm  v3.10.7
npm ERR! code ELIFECYCLE

npm ERR<EMAIL_ADDRESS>postinstall: `npm i -g generator-react-native-ignite`
npm ERR! Exit status 243
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>postinstall script 'npm i -g generator-react-native-ignite'.
npm ERR! Make sure you have the latest version of node.js and npm installed.
npm ERR! If you do, this is most likely a problem with the react-native-ignite package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     npm i -g generator-react-native-ignite
npm ERR! You can get information on how to open an issue for this project with:
npm ERR!     npm bugs react-native-ignite
npm ERR! Or if that isn't available, you can get their info via:
npm ERR!     npm owner ls react-native-ignite
npm ERR! There is likely additional logging output above.

npm ERR! Please include the following file with any support request:
npm ERR!     /Users/kumar/ReactFirebaseApp/npm-debug.log

See attached npm-debug log file.
npm-debug.txt

I'm having the same issue, Ubuntu linux only (15.10), didn't seem to have install problems in Windows 10.

Please verify you've tried everything here:  https://docs.npmjs.com/getting-started/fixing-npm-permissions
This helps most people with permission issues.

Ran through Option 1: Change the permission to npm's default directory in https://docs.npmjs.com/getting-started/fixing-npm-permissions
Resolve the issue for me. Thanks. Closing issue.


apps/netutils: Add RTP tools

Summary
Add an application to receive/send RTP protocol.

RTP Tools is a set of small applications that can be used for processing RTP data.

rtpplay: play back RTP sessions recorded by rtpdump
rtpsend: generate RTP packets from textual description, generated by hand or rtpdump
rtpdump: parse and print RTP packets, generating output files suitable for rtpplay and rtpsend
rtptrans: RTP translator between unicast and multicast networks

For more info, please refer to:
https://github.com/irtlab/rtptools
Impact
No immediate impact. Some improvements on NuttX are required to enable all the applications to work properly. These changes will be submitted on separate PRs.
Testing
Tested with simulator + ESP32-LyraT v4.1 with rtpdump.

This MR is open for review after https://github.com/apache/nuttx/pull/8985 and https://github.com/apache/nuttx/pull/9142 being merged. Could you please take a look at it, @xiaoxiang781216 and @masayuki2009 ?
I'm planning to make it part of a series of tutorials regarding audio applications of NuttX ;)


Feature/population of

Add the ability to get the population of a city/country or the world to do #29, #37 and #42.
Also does some code formatting and gets rid of some duplicate code

Maybe wait abit before merging so I can add tests for my methods


Feature request: Show About (with version) from Help menu

Expected Behavior
I would like to be able to view the current version of the app from the Help menu. Perhaps something like what Chrome has under Help -> About:

Actual Behavior
Help menu does not show the version
Steps to Reproduce the Problem
View the Help menu
Specifications

Chronos-timetracker version: 2.7.3
OS: Ubuntu 17.10 x64

You can view Chronos Version by clicking Chronos>About Chronos from the menu

I don't appear to have that option in my menu...

It looks like the menu might be different on macOS vs Linux.


pybuilder does not support python3.8

I am one of the early adopter kind of people and I have recently migrated to python3.8 very soon after I heard the release was out there
And then somehow I was introduced to pybuilder, which is incompatible with python3.8
ERROR: Package 'pybuilder' requires a different Python: 3.8.0 not in '!=3.0,!=3.1,!=3.2,<3.7,>=2.6'

So I'm opening this issue for a notice of considering to move toward python3.8
Thanks
And cheers :clinking_glasses:

This is being worked on in #648

This is fixed in #648 in master and will be released in 0.12.0


Add  to the list of merchants

What's the name of your business?
Declic CBD
What's the URL of the website?
https://declic-cbd.fr/
Write a brief description of your business/service (max 50 characters)
CBD products online shop
Enter the URL where a Monero mention can be found
https://declic-cbd.fr/  i mention Monero 2 times in the first page
How do you accept Monero? (choose only one option)

[ ] Monero integrations (github.com/monero-integrations)
[ ] Globee
[ ] Native wallet
[x ] Other payment gateaway (Coinpayments, Morphtoken, etc. Please specify)

How would you categorize your business? (choose only one option)

[ ] Exchange
[ ] Block Explorer
[ ] Payment Gateway
[ ] Web Hosting
[ ] Tool
[ ] Service
[x ] Goods
[ ] Entertainment

Comment
Thanks in advance, regards

OK


Secondary menu items list is empty after OnAppearing

The secondary menu list shows correctly in the application, however at the end of the constructor my list is 9 elements, after OnAppearing completes it's 1.  This prevents me from enabling/disabling items in the list based on activity and such.

I see in your code you remove all the secondary items from the content page list and replace it with a single item to show in the toolbar - which makes sense - however it'd be nice if we had access to the secondary menu items in some fashion so we can adjust enabled/disabled status or update the text in the menu items based on state in app.


Plugin extraction

The goal of this PR is to make it possible to extract code and run it as a plugin. The plan is:

Phase split the monad (already done).
Split out most of the core implementation of run_template_monad_rec into a new module pluginCore which will declare a monad and implement all the TemplateMonad operations.
Implement an interpreter for the phase-split version of the monad that translates all the operations into pluginCore.
Make pluginCore compatible with the result of Coq's extraction.

It would likely be desirable to fix #91.

Hi @gmalecha, is this PR ready?
Do you want that I review it?

It isn't ready yet. I will probably be able to finish it up this weekend. If you want to make any suggestions about it, that would be greatly appreciated

I'll have a look next week.

I ran into more problems than I anticipated. I'm wondering if someone could take a look at the types declared in pluginCore.ml and see if the comments point to the right Coq definitions. In particular, there is kername and Id.t and I'm not sure exactly what should point to what. @SimonBoulier @mattam82

@gmalecha the types looks like they're pointing to the right places, and the code looks fine to me. Is the main issue about handling tmLemma?

I think I got tmLemma, it requires me to cps convert the tm monad. The next thing to do is finish up the implementations of the rest of pluginCore and update run_template_monad.ml with to use the code in pluginCore. I should be able to do that today.

@mattam82 I ran into a few issues implementing some of the pluginCore functions. I left comments on them, do you have any thoughts on them?

This is looking great @gmalecha , what is left?

That's @mattam82. I will address your comments and then we can merge. Then I will open another PR with more of the extraction pieces later tonight or tomorrow.

In the last commit, I changed some of the implementations to use the code in pluginCore.ml but I specifically avoided changing the version of TM that is not used for extraction. Some of the code is slightly longer, but I like the idea of consolidating the implementation in a single place. Would anyone object to changing the other code to use the same implementations?


feat: add protobuf 4.27.5, protobuf 3.25.5, protobuf 4.28.2 releases

update protobuf with release 4.27.5
update protobuf with release 3.25.5
update protobuf with release 4.28.2

:tada: This PR is included in version 1.362.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Pages not garbage collected and therefore leaking (Android).

When investigating memory leaks in our application, I think I have uncovered a leak concerning pages not being Garbage Collected after navigating back.
With a simple main BasicPage, from which we navigate to Basic2Page, and then press the back button to navigate back to BasicPage, I am seeing that Basic2Page is not being garbage collected. There are no Commands or other complications on Basic2Page.
I'm detecting the lack of garbage collection by taking a weak reference to Basic2Page in its constructor; latter it can be seen that the object has not been garbage collected.
This GitHub repository demonstrates the behaviour and has more notes.
Has anyone else seen this behaviour? This is potentially a fundamental problem for us as it means that our non-trivial app is leaking a lot!
Versions: FreshMvvm 2.2.0
Xamarin.Forms: <IP_ADDRESS>0
=== Visual Studio Community 2017 for Mac ===
Version 7.1.5 (build 2)
Installation UUID: 650b4c91-c7f5-4ee5-ad70-6f178f314906
Runtime:
Mono <IP_ADDRESS> (d15-3/14f2c81) (64-bit)
GTK+ 2.24.23 (Raleigh theme)
Package version: 502000224

=== NuGet ===
Version: <IP_ADDRESS>8
=== .NET Core ===
Runtime: Not installed
SDK: Not installed
MSBuild SDKs: /Library/Frameworks/Mono.framework/Versions/5.2.0/lib/mono/msbuild/15.0/bin/Sdks
=== Xamarin.Profiler ===
Version: 1.5.5
Location: /Applications/Xamarin Profiler.app/Contents/MacOS/Xamarin Profiler
=== Apple Developer Tools ===
Xcode 8.0 (11246)
Build 8A218a
=== Xamarin.Android ===
Version: <IP_ADDRESS> (Visual Studio Community)
Android SDK: /Users/jameslavery/Library/Developer/Xamarin/android-sdk-macosx
Supported Android versions:
2.3   (API level 10)
4.0.3 (API level 15)
4.1   (API level 16)
4.3   (API level 18)
4.4   (API level 19)
5.0   (API level 21)
5.1   (API level 22)
6.0   (API level 23)
7.0   (API level 24)
7.1   (API level 25)
SDK Tools Version: 26.1.1
SDK Platform Tools Version: 26.0.0
SDK Build Tools Version: 26.0.2
Java SDK: /Library/Java/JavaVirtualMachines/jdk1.8.0_144.jdk/Contents/Home
java version "1.8.0_144"
Java(TM) SE Runtime Environment (build 1.8.0_144-b01)
Java HotSpot(TM) 64-Bit Server VM (build 25.144-b01, mixed mode)
Android Designer EPL code available here:
https://github.com/xamarin/AndroidDesigner.EPL
=== Xamarin.iOS ===
Version: <IP_ADDRESS> (Visual Studio Community)
Hash: 152b654a
Branch: xcode9
Build date: 2017-09-15 02:25:56-0400
=== Xamarin Inspector ===
Version: 1.3.1
Hash: cbc48dd
Branch: 1.3-release
Build date: Thu, 21 Sep 2017 19:52:53 GMT
Client compatibility: 1
=== Xamarin.Mac ===
Version: <IP_ADDRESS> (Visual Studio Community)
=== Build Information ===
Release ID: 701050002
Git revision: 7afedcaef8e7542e70e3cf8f9bdb26938b8c0876
Build date: 2017-09-15 08:39:58-04
Xamarin addins: 3262aadf811a18c12eac6742532d052b0139a808
Build lane: monodevelop-lion-d15-3-xcode9
=== Operating System ===
Mac OS X 10.11.6
Darwin 15.6.0 Darwin Kernel Version 15.6.0
Thu Jun 23 18:25:34 PDT 2016
root:xnu-3248.60.10~1/RELEASE_X86_64 x86_64
=== Enabled user installed addins ===
Redth's Addins 1.0.9

I've checked system for memory leaks before but I will look into it now again.

Thanks Michael,
I've just run up one of the stock Xamarin sample apps, and it doesn't exhibit the same retained page reference behaviour - so it does seem to be to do with FreshMvvm I'm afraid.

I've been doing some investigation, and think I have a solution to the Page leak.
I had to add a Cleanup method to PageModelCoreMethods.cs:
public void Cleanup()
 {
    this._currentPage = null;
 }

and then add the following to RaisePageWasPopped in FreshBasePageMode.cs:
CurrentPage = null;
this.CoreMethods.Cleanup();

This appears to stop the Page leaking - it's now GC'd.
However, PageModels are still leaking. I think it's to do with the fact that the navPage.Popped event handler is not being unsubscribed. The code to do this is in RaisePageWasPopped in FreshBasePageModel.cs:
var navPage = (this.CurrentPage.Parent as NavigationPage);
if (navPage != null)
    navPage.Popped -= HandleNavPagePopped;

However, at the point this is called, this.CurrentPage.Parent is null, and therefore the event is not being unhooked. This will, I think, be leaving the PageModel referenced by the navPage via the handler and stopping the PageModel being GC'd

I think it is the HandleNavPagePopped handler which is causing the PageModel to not be GC'd.
The problem for me is that the CurrentPage is being set to null before RaiseWasPopped is being called - I assume deep in the Navigation code, as I cannot see where this is being done. Therefore I've implemented the slightly inelegant (I think) solution below which works.
Added a private field:
private NavigationPage CurrentPageNavigationPage = null;
Amended AttachPageWasPoppedEvent:
public void AttachPageWasPoppedEvent()
{
    var navPage = (this.CurrentPage.Parent as NavigationPage);
    if (navPage != null)
    {
        CurrentPageNavigationPage = navPage;
        _alreadyAttached = true;
        navPage.Popped += HandleNavPagePopped;
    }
}

Amended the code in RaisePageWasPopped, relating to clearing the HandleNavPagePopped handler, to:
var navPage = (this.CurrentPage.Parent as NavigationPage);
if (navPage != null)
{
    navPage.Popped -= HandleNavPagePopped;
}
else if (CurrentPageNavigationPage != null)
{
    CurrentPageNavigationPage.Popped -= HandleNavPagePopped;
}

CurrentPageNavigationPage = null;

With the above changes, I now do not see PageModels remaining after calling GC.Collect() - so I think this fixes the PageModel leak.
However, there is probably a more elegant solution!

Hi, I've reproduced this issue and come up with a solution I'm happy with. I can push the code up for you to take a look at and then I can do a release.

That's great Michael. Yes - please push! (we have an interest in this issue too)

Hi Michael,
Great - please push ASAP, I have a customer desperate for this fix.
Regards,
James

Ok, this must have change with a Xamarin.Forms update. I will publish a new nuget.

Hi Michael,
How is this one going? Do you know when we can try the update. It will solve a whole load of problems for us.
J

Hi Michael,
Also a question on the resolution.
I've noticed in my fixing of it locally here that we probably need to clear the PreviousPageModel field in RaisePageWasPopped, to make doubly sure that we've got no lingering references to PageModels.
I've checked, and RaisePageWasPopped is called after PreviousPageModel.ReverseInit, so this is safe to do.
Of course, you may have got a more elegant solution than mine...

I used Rx for weak subscriptions, take a look. - https://github.com/rid00z/FreshMvvm/tree/resolve-memory-issue

Hi Michael,
Thanks - that looks like an elegant solution to the event handler problem!
I found that I also needed to set CurrentPage (and PreviousPageModel) to null in RaisePageWasPopped, to ensure that Pages and PageModels are freed. Did you find this too, or do you think the solution is all with event handlers?

and does this fix release already support net standard 1.4?

Michael
Are there any commits for this one?
J

...I see it: https://github.com/rid00z/FreshMvvm/tree/resolve-memory-issue

This is published into nuget today.

Hi @rid00z
thank you for that update. quick question, now bunch of other libraries are also installed into forms project as shown below. What is the reason? is it because .net standard support is also pushed?

@EmilAlipiev I'm seeing this too, and probably as a result, am getting the error:

/Users/jameslavery/Documents/P4/THI/Musterd/src/dev_JGL2/Musterd.Core.Droid/CSC: Error CS1703: Multiple assemblies with equivalent identity have been imported: '/Users/jameslavery/Documents/P4/THI/Musterd/src/dev_JGL2/packages/System.Runtime.InteropServices.WindowsRuntime.4.0.1/lib/netstandard1.3/System.Runtime.InteropServices.WindowsRuntime.dll' and '/Library/Frameworks/Mono.framework/External/xbuild-frameworks/MonoAndroid/v1.0/Facades/System.Runtime.InteropServices.WindowsRuntime.dll'. Remove one of the duplicate references. (CS1703) (Musterd.Core.Droid)

Any idea on the solution?

It looks like for me update will not possible as well. one of the package complains about profile as I am using 259. I think that it is not fair us to force to use 111 profile for this very important update.

@EmilAlipiev This is not a requirement of FreshMvvm but because of the rx.net dependancy.

I can understand it but can you Kindly explain why suddenly we need all these libraries to work with freshmvvm?

The solution which Michael implemented, to solve the memory leak, was elegant in terms of its implementation - it makes the event subscriptions weak so that they don't hold references to the classes implementing them.
He used the Rx package to implement this. The downside is that Rx has dependencies on all these other packages.
This is a classic case of using a useful feature of a package/framework, but having to bring in all the 'baggage' of the package.
This isn't a criticism of Michael's solution - but an explanation of why we're getting all these packages with this fix.
Now my 2 pence worth (or 2 cents if you're not in the UK).
My solution was as I described in an earlier post (sorry, quote markdown doesn't seem to be working here)
=====
Added a private field:
private NavigationPage CurrentPageNavigationPage = null;
Amended AttachPageWasPoppedEvent:
public void AttachPageWasPoppedEvent()
{
var navPage = (this.CurrentPage.Parent as NavigationPage);
if (navPage != null)
{
CurrentPageNavigationPage = navPage;
_alreadyAttached = true;
navPage.Popped += HandleNavPagePopped;
}
}
Amended the code in RaisePageWasPopped, relating to clearing the HandleNavPagePopped handler, to:
var navPage = (this.CurrentPage.Parent as NavigationPage);
if (navPage != null)
{
navPage.Popped -= HandleNavPagePopped;
}
else if (CurrentPageNavigationPage != null)
{
CurrentPageNavigationPage.Popped -= HandleNavPagePopped;
}
CurrentPageNavigationPage = null;
With this solution, the memory leak is solved with no extra packages.
I have to admit I too would prefer this approach rather than using Rx and weak subscriptions with the associated extra packages. Changing profiles and/or having more packages just adds to the potential for 'package hell'.

On the other hand above library InteropServices does support 259 profile but I guess latest version only, I am not sure. I have already installed it together with other library. But now i cant install older version. it is a conflict for me to use older version. Cant we please at least get latest version of it?

Hi,
I am coming back to this issue and I have feeling that this is not resolved yet. Dont you think that we should implement   IDisposable on FreshBasePageModel.. because it looks like that not only Pages but also PageModels are not disposed?


Issue #7659 foreach warning on adding gateway

To make this happen:

Start with a system with just default DHCP on WAN - the system generates gateways at run ti,e for that and $config['gateways']['gateway_item'] is empty.
Edit some interface, set it to Static IPV4, put in some IPv4 address, click "Add Gateway" and give it some gateway IP.
Save and apply
Go to the dashboard - the "crash" message is given.

This fix adds protection around the foreach() to not bother going there if there are no existing gateway items to process.
 Reopening


feat: prevent duplicate pool creation

Closes: #XXX
What is the purpose of the change
This feature adds a logic check on pool creation that a pool does not already exist for the given denoms, spread factor, and tick spacing (if applicable).
Testing and Verifying
(Please pick one of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)

Added unit test that validates ...
Added integration tests for end-to-end deployment with ...
Extended integration test for ...
Manually verified the change by ...

Documentation and Release Note

[ ] Does this pull request introduce a new feature or user-facing behavior changes?
[ ] Changelog entry added to Unreleased section of CHANGELOG.md?

Where is the change documented?

[ ] Specification (x/{module}/README.md)
[ ] Osmosis documentation site
[ ] Code comments?
[ ] N/A

devbot help

Hi! I'm DevBot, a bot that helps with common tasks in the development process. Commands:

devbot fix: Fix basic errors in the PR. (e.g. imports, changelog conflicts, go mod conflicts)
devbot merge base: Merge the base branch into the PR branch.
devbot add changelog [misc/feat/bug/api/sec] [message]: Add a changelog entry to the PR. (e.g. devbot add changelog feat Added a new feature)

If message is blank, defaults to PR title.

devbot re-pr: Re-PR the PR, useful for external contributors where we have no edit perms.

devbot add changelog feat

Decided to not go through with this


feat: Error boundary main

add error boundary for main process

Can you give an example on how to test this? I tried getting the snack bar but wasn't able to reproduce it.

just throw an error in the main process, i just add another commit to throw an error in the main process for demonstration purpose to trigger the snackbar

Can you give an example on how to test this? I tried getting the snack bar but wasn't able to reproduce it.

just throw an error in the main process, i just add another commit to throw an error in the main process for demonstration purpose to trigger the snackbar

Can you try this - add a return new Error('test') inside the startApp function in madara-app.ts. It should show the snackbar ideally when you try to start the app but it doesn't for me.

Can you give an example on how to test this? I tried getting the snack bar but wasn't able to reproduce it.

just throw an error in the main process, i just add another commit to throw an error in the main process for demonstration purpose to trigger the snackbar

Can you try this - add a return new Error('test') inside the startApp function in madara-app.ts. It should show the snackbar ideally when you try to start the app but it doesn't for me.

let me try!


Add ltex-ls hook

Draft because ltex-ls currently throws an exception when errors span multiple lines.


MAINT: Revert transformer model to previous larger model

This fixes the test suite, which has started failing recently due to a broken HuggingFace dependency.
#3046 switched the model used in the test suite to a "tiny" model, which reduced CI time by a full 5 minutes. However, it looks like the "tiny" model has been removed from HuggingFace.
This PR restores the previous, larger model. This will increase CI times by ~5mins, but should get the tests passing. So, once tests are fixed, we can find a better smaller model for the tests. Or, we could look for an alternative implementation that is faster and doesn't depend on external resources like HuggingFace.

@dsgibbons or @thatlittleboy I'd be grateful for a review on this if you get a minute. Keen to get this fixed so other PRs can be unblocked.
We've had a number of CI failures due to changing external dependencies, which highlights that the test suite is not a pure function of the code and is not reproducible. Over time, it would be great to fix the root causes of these issues so that the test suite cannot unexpectedly break on master.
This probably merits a deeper discussion; for now let's just get the tests passing once more!

oopsies, sorry, forgot to submit my approval. but LGTM


Wrong namespace on creating class

Wrong namespace on creating class

Hi @ErickMBS, thank you for reporting the issue. In order to reproduce and troubleshoot, could you please mention where is your csproj located and what is its name? You don't have to specify the redacted name, use foo instead.

Possible fix:
dotnet.nvim.zip

@ErickMBS, I will take a look, thanks!
If you could create a PR it will be easier, but don't feel pressured to do it :)

Thanks @MoaidHathot, I tryed to create a new branch with the changes, but it seems I don't have permissions :/

@ErickMBS, as to be aligned with the Github flow, you should fork the repo, do the changes there then create a PR from your fork into this repo :)


Nuxt SPA breaks when adding a preset for @vueuse/router

Environment

Operating System: Linux
Node Version:     v18.20.3
Nuxt Version:     3.11.2
CLI Version:      3.11.1
Nitro Version:    2.9.6
Package Manager<EMAIL_ADDRESS>Builder:          -
User Config:      devtools, ssr, modules, components, imports, app, colorMode, googleFonts, i18n, runtimeConfig
Runtime Modules<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>radix-vue/nuxt<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>Build Modules:

Reproduction
https://stackblitz.com/edit/github-g5rvb6
Describe the bug
Adding a preset to nuxt.config.ts from @vueuse/router somehow removes all the auto imports from @vueuse/nuxt
presets: [
      {
        from: '@vueuse/router',
        imports: ['useRouteHash', 'useRouteParams', 'useRouteQuery'],
      },
    ],

I get 500 useTextDirection is not defined or the same error message for any of vueUse composables
Additional context
No response
Logs
No response

This could be an issue with @vueuse/nuxt 🤔

Would you raise an issue/reproduction on https://github.com/vueuse/vueuse? 🙏

@danielroe on it

Thank you! I think we can close it in favour of https://github.com/vueuse/vueuse/issues/4021.
Happy to be looped in if it seems to be caused by Nuxt upstream.


Toggle capitalization of scenarios and feature names

For the purpose of look-and-feel, it’d be nice if there was an included option/switch to toggle capitalization. Long capitalized scenarios and feature names do not look that appealing in my opinion.
Just a suggestion §:-)

This will be included in the 0.8.0 release.


🐛 Bug Report: incorrect policy check for Github Users

📜 Description
Github allows usernames ending with -, however the default policy regex for metadata.name is ^([A-Za-z0-9][-A-Za-z0-9_.]*)?[A-Za-z0-9-]$, which makes username ending with - invalid. This is resulting in Github org data ingestion incorrect and buggy, and I cannot add the team member manually as well.
👍 Expected behavior
It should allow usernames ending with - as a valid metadata.name for entity type User
👎 Actual Behavior with Screenshots

👟 Reproduction steps

Try ingesting a User entity with name ending with -

📃 Provide the context for the Bug.
https://backstage.io/docs/integrations/github/org/
🖥 Your Environment
No response
👀 Have you spent some time to check if this bug has been raised before?

[X] I checked and didn't find similar issue

🏢 Have you read the Code of Conduct?

[X] I have read the Code of Conduct

Are you willing to submit PR?
Yes I am willing to submit a PR!

Updated the docs https://github.com/backstage/backstage/pull/24075