Upgrade releases and packages for meteor 1.10.2

based on the work in issue https://github.com/VulcanJS/Vulcan-Starter/issues/167 this are the necessary changes to run with meteor 1.10.2 and node 12

This works as described in https://docs.vulcanjs.org/#Two-Repo-Install-Optional
git clone -b devel Vulcan
cd Vulcan
npm install
cd ..

git clone -b master Vulcan-Starter
cd Vulcan-Starter
npm install
cp sample-settings.json settings.json
METEOR_PACKAGE_DIRS="../Vulcan/packages" meteor --port 3000 --settings settings.json

Browse localhost:3000

Awesome! I will keep your PR around until next release, I've manually made the minimal changes based on it, it now should work on "master" branch of the Starter and on "devel + Vulcan on devel".

The Starter master branch should work at any time, with a 1-repo install. It is now ok with Meteor 1.10 on my side.

The Starter devel branch should work with a 2-repo install and Vulcan on devel, but it may be a bit broken from time to time, especially when we update NPM package. That's ok, because it's a devel branch. The fix is often slightly changing some syntax or versions, never a huge issue.

I will then include your additional changes manually during the release.
Thanks a lot for your contrib and not giving up against install error, keeping everything up to date is always a fight and that helps a lot.

It will be included in next release. Feel free to include other change in another separate PR if you want (eg adding Husky etc.)


The && operator overload for QueryDescription doesn't seem quite right

Closing as won't fix. We can address this if it becomes a problem.


Improve service runner

Closes #402.

The linter fails on CI but passes locally.

You do; that looks like a GitHub bug


Add VeriSafe

VeriSafe at Etherscan: https://etherscan.io/token/0xac9ce326e95f51b5005e9fe1dd8085a01f18450c
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

[x] Filename in the lowercase format
[x] Image format: png
[x] Image size: 256 by 256 px

Also, you can use these graphics to say that your ERC20 token fully compatible with Trust Wallet (https://trustwallet.com/logo-assets). Tokens will show up automatically once the user receives them.
Feel free to share this on social media and tag Trust Wallet:

Twitter: @trustwalletapp

Facebook: @trustwalletapp


The plugin trust_fall uses a deprecated version of the Android embedding.

To avoid unexpected runtime failures, or future build failures, try to see if this plugin supports the Android V2 embedding. Otherwise, consider removing it since a future release of Flutter will remove these deprecated APIs.

@adispatil Check my github: https://github.com/thanhit93/trust_fall/commit/4c9206a1aeca6186cb0d5ec321c14bebe06de300
https://github.com/thanhit93/trust_fall/tree/null-safety
Usage: pubspec.yaml
trust_fall:
git:
url: https://github.com/thanhit93/trust_fall.git
ref: null-safety

There's a new package similar to trust_fall https://pub.dev/packages/safe_device


Fixes #133

This adds a Pull Request (PR) template to the PRs raised in this repository.
Fixes #133
@Dev-tanay Kindly review and merge this PR.
Also, kindly add "gssoc" and "Level1/2/3" label to this.
Thank you!

@Dev-tanay Please add a gssoc label and a level (1,2,3) to this.
Thank you!

@Dev-tanay Kindly add a level1 / level2 / level3 label to this, otherwise it's not counting towards the leaderboard!
Thank you!


Adding trac_ik to documentation index for lunar

Added trac_ik to lunar distribution.yaml in preparation for release.

The release repository doesn't seem to contain a Lunar release. Did you run bloom for Lunar?

Sorry, I thought I needed to do this first.  I'll run bloom now.

Yeah, when I run bloom, it complains about not seeing my package in the distribution.yaml for lunar.

OK, it looks like the bloom script made the PR for me.


feat: improved the dropdown menu of filter section

Description

enchanced the dropdown menu for better UI .
works fine for mobile view also
need help for design
reduced the height of the menu.

Related issue(s)
Resolves #1318

hey @akshatnema I need help for design of selected items.

@sambhavgupta0705 Regarding design and UI colors, kindly take help from @Mayaleeeee

Thanks @akshatnema I appreciate this.
@sambhavgupta0705 please let me know if you need my help.

yes @Mayaleeeee I need help with what  your color should be given to selected items,for now light blue is being given

it is like this for now

need suggestions on how can we improve this

@sambhavgupta0705 tbh, present dropdown in your PR looks horrible to me in terms of design. You can make the dropdown from scratch also, using new designs and colors. Take help from @Mayaleeeee regarding this.

@sambhavgupta0705 what's the status of this PR?

@sambhavgupta0705 See, it's not necessary to extend the space for dropdown for each field. Instead, you can also overflow the dropdown over each other using z-index. I just want that the dropdown should look professional in terms of UI. You can take reference of https://flowbite.com/docs/components/dropdowns/#background-hover.

ok @akshatnema I will keep this in mind.
Hey @Mayaleeeee can you help me with designing of the dropdown menu of tools filter

@Mayaleeeee any chance you can have a look?

@Mayaleeeee any chance you can have a look?

Yes, please, I will.

ok @akshatnema I will keep this in mind. Hey @Mayaleeeee can you help me with designing of the dropdown menu of tools filter

I'm sorry I missed this :disappointed_relieved: I will take a look at it soon

Hi, @sambhavgupta0705 Take a look at this out, and feel free to reach out if you need any further assistance
screen-recording (1).webm

Hi @sambhavgupta0705 please take a look at this and feel free to let me know if you need any further assistance.
screen-recording (1).webm

@Mayaleeeee please provide the access of the figma file

@Mayaleeeee please provide the access of the figma file

I just did.

@Mayaleeeee the design is good but @akshatnema wanted something different.He said to make something like present in the preview but if he agrees then we can go with this one also.

Any update???

Hi @sambhavgupta0705 please take a look at this and feel free to let me know if you need any further assistance.

Thanks @Mayaleeeee for designing the filter menu and I liked it as well. I personally liked the animation when we clicked on Filters and it has animation of slide-in as well as fade-out for the Filters box. We can surely update these animations in later PRs. But with the scope of present PR, we should render the dropdown in a way that it should be more standardised and easy for the viewers to find their respective options. With current implementation, finding out a specific language from list can be a difficult task as the list is spread out. Instead of this, can we go with this solution - https://codesandbox.io/s/keen-bhabha-2mpiq, but provide it with a multi-select option? In this way, we are giving the user to search for specific languages or technologies they want, and also can go with the search options as well. @Mayaleeeee, if you want, you can provide us with better version of this dropdown which is more inclined toward the AsyncAPI website theme and designs, but I think core crux for this dropdown is to make the dropdown in standard way and provide users with the option to search for languages as well.
cc: @sambhavgupta0705


vs-build: add quotes around version info to allow spaces in path name

Complete this sentence
THIS PULL REQUEST __ IS __ READY TO MERGE
Feature or improvement description
This PR fixes a problem in the vs-build where the build command fails due to spaces in the full path name of the file containing the git version information.
Related issue, if one exists
https://github.com/OpenFAST/openfast/issues/287

I've tested this bug and fix on Windows with Visual Studio. All looks good! Thanks @bjonkman.


updating build files and adding underscored rrepos that weren't pushe…

…d in the last commit, all docs required for RTD documentation build

Required PR: underscored repos required for read the docs build.


added the Simpoint Class and simpoints exit event support on set_se_workload and Simulator

Added a new Simpoint class under the src/python/gem5/components/processor/simpoint.py
It can take in either the simpoint and weight file paths or the simpoint and weight list.
Added the checkpoint generator and dump_reset generator.
The set_se_workload can take in Simpoint object and use the get function to pass the simpoint_start_insts to the core.
Added a schedule_simpoints function for scheduling simpoints in fs mode and schedule simpoint end if needed in Simulator.
Also added a schedule restore_simpoint_stop function in Simulator to schedule a stop when doing restore simpoint checkpoints.

Excited to check this out! Hopefully, I'll get a chance this afternoon :)

Thank you!! No rush. :)

Can you add an example runscript that uses simpoints? I think this looks good, but I'd like to see the external user interface.

Yes, I'll add an example runscript. I'll push it later with the fixed files and ping you and Bobby. Thank you for reviewing :)

@powerjg How about splitting them into an exit_event_generator commit, a simpoints module commit, a base cpu simpoints related scheduling function commit, and a stdlib simpoints support commit(the simulator, exit event, and se_set_workload)?


GDPR compplaince

Hi, is the plugin complaint with GDPR? I couldn't find any info on GDPR.
Many of my apps that were using this plugin were removed from playstore.
I used an older version though :)
Thanks a lot for the hard work. Awaiting you reply.

Is this plugin fully GDPR and CCPA compliant? Is there any risk of an app being removed from the store as of august 2020?


Pin ipopt at the conda-forge level to enable the use of automatic ABI migrations?

In https://github.com/conda-forge/conda-forge-pinning-feedstock/pull/1652 I proposed to pin ipopt at the conda-forge level, so that we can automatically run ABI migrations once a new version of ipopt is released. I open this issue to give visibility to this change to people that are watching this repo.

Does this simply mean that if ipopt is updated here, that PRs will be automatically made to any downstream dependencies in conda forge to build against the new ipopt? If so, that's fine with me.

Does this simply mean that if ipopt is updated here, that PRs will be automatically made to any downstream dependencies in conda forge to build against the new ipopt? If so, that's fine with me.

Exactly, however the PRs will be make only for ABI incompatible changes, i.e. in the IPOPT case for new minor releases, not for patch releases.

resolved


Warn incorrect path usages when NODE_ENV="development"

{ path: '/:id' } // should not include `:`
{ path: createPath`/:id` } // should not include `:`

also with aliases

Also there should be documents about this.

Warning { path: createPath/:id } is implemented


Custom printer name setup in config

add functionality to set the printer name via own setting in config file. Just add under [telegram_ui] the option "printer_name: YourPrinterName" and it shows your custom printer name at startup. Default value, if not set, is "Printer" so the default behaviour stays the same.

addresses https://github.com/nlef/moonraker-telegram-bot/issues/301 by @hoeby


[BUG] Importing Templates - Results in deformed file styling and removed shape objects

Package version, Laravel version
Laravel 5.4.30
Laravel-Excel 2.1
Expected behaviour
Nothing in the template should change when loaded into parser.
Actual behaviour
Objects such as arrows are removed, borders on merged cells become deformed, styling altered in many places.
Exception stack trace
There is no exception
Screenshot of Excel file
https://imgur.com/acM0nAm
Left is after processing. Right is before processing.
Note missing arrow object, and deformed borders, the altered styling of columns.
Template File Below
stripped_production.xlsx
Steps to reproduce the behaviour

$file = Excel::load($templatePath, function ($excel) use ($slip){

// There is no code here

})->setFilename($slname)->store('xls', storage_path($path), true);

It this resolved, being closed?

@patrickbrouwers
I still have same problem.
Can you explain why this issue was closed?

@Troyd-Destin
Did you find any alternative solution to resolve your issue?

I did not.
On Wed, Oct 3, 2018 at 10:05 PM le-thanh-nghi<EMAIL_ADDRESS>wrote:

@Troyd-Destin https://github.com/Troyd-Destin
Did you find any alternative solution to resolve your issue?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/Maatwebsite/Laravel-Excel/issues/1402#issuecomment-426878245,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AQOe0gwUfA4rg4uYtMXLug8YpnYpVDLWks5uhYjqgaJpZM4P_08V
.

any one have solution?


Grammar improvements

Docs Build status updates of commit 85a9830:
:warning: Validation status: warnings

File
Status
Preview URL
Details

docs-ref-services/latest/storage-blob-readme.md
:warning:Warning
View (azure-java-stable)
Details

docs-ref-services/latest/storage-blob-readme.md

Line 2, Column 1: [Warning-ms-prod-and-service] Only one of the following attributes can exist: 'ms.prod', 'ms.service'. Use ms.prod for on-premise products, or ms.service for cloud services.
Line 9, Column 16: [Warning-ms-prod-technology-invalid] Invalid value for 'ms.technology': 'azure' is not valid with 'ms.prod' value 'azure'.
Line 11, Column 13: [Warning-ms-service-subservice-invalid] Invalid value for 'ms.service': 'storagestorage'.
Line 2, Column 1: [Suggestion-description-missing] Missing required attribute: 'description'.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Hey @yihezkel -- Thanks for the contribution. These files are updated through automation so changes that we make here will be overwritten on the next publish of that package. I think the source file you want to update is here -- https://github.com/Azure/azure-sdk-for-js/blob/master/sdk/storage/storage-blob/README.md
Submit a PR to that repo and your changes will persist.

Thanks @danieljurek !
I found it at https://github.com/Azure/azure-sdk-for-java/ and created a PR there.


”MĂCIN” is listed in the drop-down menu

Description:
"MĂCIN" is listed in the drop-down menu alongside its corresponding county and commune, according to the law.
Precondition:
The website is up an running.

Step 1
Type "MĂCIN" in the search bar.

Expected results
The location is listed in the drop-down menu as "Oraș MĂCIN, TULCEA".


Native SSO UX issue when viewing the Privacy Policy

Hi,
there seems to be an issue with the SSO process when the user is viewing the Access to Information OAuth2 consent screen, after tapping on the "(APP NAME) will use this information according to its (Privacy Policy)" link.
Once tapping on the link, the correct page opens, but when pressing the Back button once on the device to go back from the Privacy Policy to the SSO page, the SSO page closes, which results in a failed login result. The expected behaviour is to remain on the SSO page so the user can approve or reject the consent form, after viewing the Privacy Policy.
We are using com.uber.sdk:rides-android:0.6.+
Thanks.

Hi,
the same bug still occurs on com.uber.sdk:rides-android:0.9.1 (Uber app version 4.236.10001). The LoginCallback.onLoginCancel callback is invoked when the user navigates back out of the Privacy Policy page by pressing the Android Back button.
Thanks.


Add description of bookmark

Hi team,
I tried the demo link, the app looks very good !
Is it possible (or do you have a way to do it?) to add description of URL link and see it in the search ?
Wikipediahttps://www.wikipedia.orgWikipedia is a free online encyclopedia, created and edited by volunteers around the world and hosted by the Wikimedia Foundation.
=> For the UX we can limit the number of caracters to display on it, but I think it would be nice.
And optionnally, do the same things to add the favicon URL.
What do you think about it ?

I like the idea, but i'm not really sure where i would put it without making the UI cluttered. Some URL's can be really big and occupy most of the width of the search bar. I could truncate that as well but that would be less useful for folks that rely on seeing the whole URL. I'm open to ideas on how you want to handle that. Another thing I can think of is to have it on a separate line in the search result entry. Open to ideas here :)
This being said, I dont think i have the bandwidth to make this change but I'm open to working with you to contribute a change here.


Check if limit reach on initialization

Refactor limit checking into new function
Call check_limit on init and toggle_option

#44

@fabianlindfors I have tested locally and it works on both initialization as well as on option selection and deselection. I did not update the package version number.

Looks nice! Thank you so much :)

Looks nice! Thank you so much :)


[API v2.0 - vendorPaymentJournal] Added some examples

Simply added example for the request body and the response body. Always two there are. No more, no less.
EDIT: At this point I'm asking myself.. 468 issues vs. 13 PRs. Am I doing something wrong here? Please enlighten me if so. Until then I will continue. Keep moving forward.

Docs Build status updates of commit 2e93b1f:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

dev-itpro/api-reference/v2.0/api/dynamics_vendorpaymentjournal_update.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Thanks for your contribution!


Automation Testing - Create the Basic Login flow test cases

This issue is created to create to cover the success scenarios of login flow using automation testing scripts.

working on setting up the login test cases


Get alignments in python code

❓ Questions and Help
What is your question?
I would like to access alignments or even the attention matrix produced by a model from torch hub.
The combination of verbose and print_alignment should provide an alignment as a logging message.
But I would prefer getting it in python directly, instead of parsing it from logging output.
Is that possible?
After reading the API docs and browsing your codebase it doesn't seem possible to do it at this point.
I came up with a hacky temporary solution as a response to this issue: https://github.com/pytorch/fairseq/issues/1880
Would it be possible to expose alignments as part of the official API
Code
import torch

en2fr = torch.hub.load('pytorch/fairseq', 'transformer.wmt14.en-fr', tokenizer='moses', bpe='subword_nmt')
fr = en2fr.translate('Hello world!', beam=5, verbose=True, print_alignment=True)

What have you tried?
Reading API and code. Editing code to produce a workaround solution.
What's your environment?

fairseq Version: 0.9.0
PyTorch Version: 1.4.0
OS: Linux
How you installed fairseq: pip
Python version: 3.7.6
CUDA/cuDNN version: 10.1 and 7.5
GPU models and configuration: T2000 (mobile gpu)

I'm sorry, I missed an exact duplicate of my issue: https://github.com/pytorch/fairseq/issues/1877
Closing this.


print-dev-env takes over 20 seconds

After upgrading from devenv 0.5 to 0.6 (and now 0.6.2), devenv print-dev-env which is used by direnv takes too long. With version 0.6 it was taking some 20 seconds, but 0.6.2 seems to often take some 50 seconds.
With version 0.5 it was less than a second.
To Reproduce
devenv.nix - https://gist.github.com/vHanda/b59f0eaebfee3f0c8b66fb644ce2be02
devenv.yaml - https://gist.github.com/vHanda/1465594bc9ccb442e06b83f7380bdc2f
devenv.lock - https://gist.github.com/vHanda/3ba3ba920ef9468d1ba3f7a38dbfb5a2
Version
devenv: 0.6.2
I'm running this on macbook air m2.
$ time devenv print-dev-env &> /dev/null

________________________________________________________
Executed in   53.11 secs    fish           external
   usr time    1.82 secs   69.00 micros    1.82 secs
   sys time    0.57 secs  963.00 micros    0.57 secs

Is this on a fresh occasion (where it downloads all the tools) or after it has been run for the first time?

The first invocation took 50s because it downloads 1.9GB of tooling, but the second one is:
❯ time devenv print-dev-env &> /dev/null

real	0m1.252s
user	0m0.817s
sys	0m0.203s

For me this happens everytime. Any way I can provide additional info?

du -sh in your repo

I had to restart my machine for some updates, and now it's no longer occurring.
Not sure what was going on, but I can no longer reproduce it. Closing this.


AVL tree does not seem to implement find()

Did not find an implementation of find() in AVLTree.ts or AVLTreeNode.ts. This seems strange, because it's trivial compared to the rotations.
Shoot this down with fury if I am being presumptuous. But I inspected the source files, so I think I'm okay.

Hey!
Thank you for getting this to my attention, e020ffd should fix this


Invalid OAuth Token from Chrome App Heartbeat

All of our devices have started to show 'This device is not enrolled' error, despite previously being enrolled.
We used to get the issue sporadically, with no clue as to what was causing it as it was very random, but now it's very much permanent, preventing us from using the system.
I'm wondering if it's caused by exceeded a maximum number of granted (live) refresh tokens as referenced here: https://developers.google.com/identity/protocols/OAuth2#expiration, and if there's any system built in to resolve that?
Checking the Logs for the Chrome Endpoint, I can see that the heartbeat is returning a 401 back with:
2018-11-02 14:09:19.857 AEDT
Unable to get authorized scopes. (/base/data/home/apps/f~<APPNAME>/chrome:mcshaneg-20181102.413691614035746910/external/endpoints_archive/endpoints/users_id_token.py:371)
Traceback (most recent call last):
  File "/base/data/home/apps/f~<APPNAME>/chrome:mcshaneg-20181102.413691614035746910/external/endpoints_archive/endpoints/users_id_token.py", line 369, in _set_bearer_user_vars
    authorized_scopes = oauth.get_authorized_scopes(sorted(all_scopes))
  File "/base/alloc/tmpfs/dynamic_runtimes/python27g/3b44e98ed7fbb86b/python27/python27_lib/versions/1/google/appengine/api/oauth/oauth_api.py", line 171, in get_authorized_scopes
    _maybe_call_get_oauth_user(scope)
  File "/base/alloc/tmpfs/dynamic_runtimes/python27g/3b44e98ed7fbb86b/python27/python27_lib/versions/1/google/appengine/api/oauth/oauth_api.py", line 220, in _maybe_call_get_oauth_user
    _maybe_raise_exception()
  File "/base/alloc/tmpfs/dynamic_runtimes/python27g/3b44e98ed7fbb86b/python27/python27_lib/versions/1/google/appengine/api/oauth/oauth_api.py", line 239, in _maybe_raise_exception
    raise InvalidOAuthTokenError(error_detail)
InvalidOAuthTokenError

I was previously seeing this intermittently - , I thought perhaps it was caused by returning a loan and starting a new loan too quickly but now it's constant.
I have tried:
Different Chromebooks, different users, factory reset of Chromebook(s), un-enroll and re-enroll in grab-n-go, hotspot to make sure it's not a network issue, leaving it alone for 24 hours, deploying a new version to app engine (albeit with no code changes made).
The only thing I'm yet to try is deploying a new version of the Chrome App, creating a new OAuth client, and sacrificing a goat.
Interestingly during one of my tests the heartbeat actually worked one time as it updated the Device to show that it was assigned to my user, even though the chrome app on the device kept saying 'Device not enrolled' but I haven't seen it since.

@iamgeef Did you ever get this resolved?  I think I am encountering the same issue.

I installed and ran a demo project in September,  successfully.
I deleted the project but left the gSuite components in place.
I have now tried to rebuild the GCP project and deploy.  Connecting to the same gSuite configuration.
The backend is working as expected.  Recreated the chromebooks in the loan system.
Deployed new oauth keys etc.   web_app is working.
Chrome app doesn't  think it is registered. (see screen shot)
Logs have the same message as indicated above invalid tokens.
Unable to get authorized scopes. (/base/data/home/apps/f~dialoggrabngo/chrome:root-20181205.414461687226952207/external/endpoints_archive/endpoints/users_id_token.py:371)
Traceback (most recent call last):
File "/base/data/home/apps/f~dialoggrabngo/chrome:root-20181205.414461687226952207/external/endpoints_archive/endpoints/users_id_token.py", line 369, in _set_bearer_user_vars
authorized_scopes = oauth.get_authorized_scopes(sorted(all_scopes))
File "/base/alloc/tmpfs/dynamic_runtimes/python27g/d22767677e9aa897/python27/python27_lib/versions/1/google/appengine/api/oauth/oauth_api.py", line 172, in get_authorized_scopes
_maybe_call_get_oauth_user(scope)
File "/base/alloc/tmpfs/dynamic_runtimes/python27g/d22767677e9aa897/python27/python27_lib/versions/1/google/appengine/api/oauth/oauth_api.py", line 221, in _maybe_call_get_oauth_user
_maybe_raise_exception()
File "/base/alloc/tmpfs/dynamic_runtimes/python27g/d22767677e9aa897/python27/python27_lib/versions/1/google/appengine/api/oauth/oauth_api.py", line 240, in _maybe_raise_exception
raise InvalidOAuthTokenError(error_detail)
InvalidOAuthTokenError
Device ID and serial number all check out in console logs.

Note:  I have rebuilt and redeployed the chrome app with new keys twice.  It doesn't seem to be that.
PS:  Set logging to be True in shared/config.ts
Not sure I see anything different in stackdriver

There is also the following warning.   But I cant recall if that was there previously.
multistore_file.py:62
The oauth2client.contrib.multistore_file module has been deprecated and will be removed in the next release of oauth2client. Please migrate to multiprocess_file_storage.
request_id: "5c08b5f400ff0d534af1636bae0001667e6469616c6f67677261626e676f0001726f6f742d3230313831323035000100"
timestamp: "2018-12-06T05:39:03.229Z"
location: "/base/data/home/apps/f~dialoggrabngo/root-20181205.414461667803272195/external/oauth2client_archive/oauth2client/contrib/multistore_file.py:62"


@location tag

One key consideration is if we can auto-add @location on decorators. If we can, then I think this should be named @location, as I don't expect it to be frequently used. If we can't, then I think we should name it @loc.
There's a significant issue with this PR, as I had to make a new ValueTagsWrapper class to handle some functions on ValueTags, due to an issue of circular dependencies. Curious if you have preffered ways of doing this. I also considered having BaseValue rely on an abstract class version of ValueTags, but that seemed like too much.
Tests are failing because the new toString format is different. If this PR is approved, I'll fix these.

After this goes in, we should change exportData to also be a type.

After this goes in, we should change exportData to also be a type.

 I understand that using a type gives us type safety, though. Depends mostly on how soon we get custom structs, and how compile-time-safe they're going to be (will stdlib custom structs be shaped with TypeScript generics to map to TS object shapes? seems doable but difficult to predict).


Flickering when first loading navigator

When first loading the navigator, there appears to be a flicker moment where the navigator shows a blank view.  This is using 0.2.3.
In our fork, this commit solved it:
https://github.com/pharmadata/FluidTransitions/commit/60cb24790272e4ac1d020ea3cdc403e1fb4e5481
Not sure exactly what's going on or why that's there.

Hi @AdamPD, thanks for submitting the issue and suggesting a fix.
From the diff you sent me it seems like the only thing changed (except for some whitespace changes) was line 56:
this._transitionProgress.setValue(-1);

When removing this line you won't get the initial transition into the first screen, so this fixes the issue but introduces another one.
Is this correct?

I'ved tried another thing that might work.
In the file TransitionConstants.js, change the value for the TRANSITION_PROGRESS_START constant to 0.000000001 and see if it helps. (you might need to revert the change you made).

Closing this one due to inactivity.

@chrfalch - it didn't seem to affect the initial transition at all.

See PR #79 and #93 - they are now part of release 0.2.6 which contains a few optimizations to avoid flickering. Btw, did you test to see if there is a difference on the Simulator and the real device?

Hi @chrfalch I still experience this flickering in my emulator. And when going from stacknavigator to fluid navigator. Is there a permanent fix now?


[python] Replace TextMate for Python syntax highlighting

VS Code's syntax highlighting for Python is broken in a few ways.
VS Code currently uses TextMate's Python bundle for syntax highlighting. The problem is that this project seems to be unmaintained. The last commit was from mid-2014.
We should replace this with a project that is more up-to-date and actively maintained. PythonImproved seems to fit the bill, though I haven't used it yet. I've asked the maintainers of that project about compatibility with VS Code.
If anyone has other suggestions for a better tokenizer for Python, please speak up.

There's also https://github.com/Microsoft/vscode/issues/2867 suggesting to take MagicPython.
Did give this a try? (There's already a MagicPython extension)

Just gave it a try. Looks good to me!

I'm the maintainer of Python Improved, and I have no issues at all with your using it to supplement or replace the TextMate syntax definition in VSCode. One issue I've found with Magic Python is that a number of the scopes are rather different than the TM/Sublime Text originals, so switching to that could cause issues with color schemes that aren't compatible with MP. Those of us working on PI with me have tried to maintain compatibility with the original scopes as much as possible (or, at least, as much as makes sense), so it should work with a broader array of color schemes. I've tailored my Neon Color Scheme to work with all the new scopes in PI, in case you want to include that as well.
Let me know what you think, or if I can help in any way. Alternatively, I can add PI and Neon to the VSCode store if you think that would be a better option.

Perhaps @aeschli can offer advice on a path to take (I'm just a random user), but I would guess a solid first step would be to make PythonImproved available as a VS Code extension and then take it from there.

@MattDMo Thanks Matt for your comment. Yes, making Python Improved available as a VS Code extension would be a great first step so more people can try it out.
Let me know if you need help with the extension. We have a yeoman generator that helps you setting up an extension that contributes a grammar. Check out https://code.visualstudio.com/docs/tools/yocode.
To replace an existing grammar use the same language id ('python') and additionally add
	"extensionDependencies": [
		"vscode.python"
	]

to your package.json

There has been new work in the TextMate's Python bundle. So I've updated the grammar to the latest.
I'm still open to update to any other grammar if the community has a clear preference. But then, as said, thanks to the extension model it's possible to add grammars as extensions and each user is free to choose what to use.

@MattDMo , @aeschli , I'm am in the process of creating a VS Code extension using the code from  Python Improved.
The issue #2936 doesn't appear in Magic Python, however when using the tmLanguage file from PythonImproved, I can see that the issue still exists.
Issue #7688 doesn't seem to be a non-issue in both Magic Python and Python Improved.
However, #7688 can be replicated when using PythonImproved on TextMate!
Those are the only two issues I could find.
Anyways, I haven't published the extension yet and it can be found here

@DonJayamanne As a maintainer of MagicPython I'd strongly recommend you to go with it. Simply because we embrace TDD, MP is super stable and we can add new features very quickly. It's also used by GitHub to highlight Python sources. We have 100s of complex automated unittests, something that no other syntax highlighter for any other language does (for tmLanguage format anyways).
Some additional features of MP (I just went through our unittests and checked which one break standard highlighter or PI):

It parses docstrings differently from string literals, allowing you to highlight them in a different way and making sure raw strings aren't highlighted as regexps.

Highlights cases like illegal use of literals:

some. True
a = True

Highlights self and cls for methods:

class F:
    def __init__(self, a, b=1):
        self.a = a

Can highlight type annotations (GH's color schema doesn't support them yet, but try it with MP and Chromodynamics color schema):

x = None # type: List[str, a]
y = None # type: Dict[int, Any] # int

Highlights doctests:

r'''Module docstring

    Some text followed by code sample:
    >>> for a in foo(2, b=1,
    ...                 c=3):
    ...   print(a)
    0
    1
'''

Correctly handles parameter annotations (try that in PythonImproved):

def some_func(a:
                 lambda x=None:
                    {key: val
                        for key, val in
                            (x if x is not None else [])
                    }=42):

Correctly handles invalid line continuations:

1 + \ sdgfsdf
def foo(): pass

Superb support of both old and new style string formatting:

a = 'qqq{0:{width}{base}}www'
a = 'qqq{0:$20}www'
a = 'qqq{0}www'

Unicode is, of course, fully supported (as in PI, I believe):

class Üa(Êa):
    'Œ\nŃ'
    @æaœ
    def ŌÏŒĘ(self, Ú=1):
        print('превед 你好')
        return Ù
    你好 = lambda: 你好
    def 你好(): pass

There are much more small, but handy (sometimes obscure) features in MP, but I don't want to list too many examples.

Also, MP is already used by >31000 VSCode users: https://marketplace.visualstudio.com/items?itemName=magicstack.MagicPython

As the person who reported this issue, I can also add that I'm a happy MagicPython user too. :+1:

I have no issues with using MagicPython, if that's the way you want to go. PythonImproved is just a side project in my free time (I'm actually a research scientist in biotech in real life), and honestly I just don't have the time at the moment to support some of the features that MP does already. If there's anything in PI that can be useful, please feel free to grab it (just attribute me in some way). Hopefully I'll eventually get around to releasing PI for VSCode, but work is definitely my top priority at the moment, so I don't know when that will be.
Sorry I can't spend more time on it, but since PI isn't directly related to my primary job functions at work, the company won't support my time spent on an open source project. Please do keep me in the loop, though, and I'll try to answer any concerns that may arise.

@aeschli , my plan is to update the Python tmlanguage files (later today) with the ones from MagicPython:

Will I need to create any test plans? I don't see the need for this? However, a sanity check wouldn't hurt
Will I (or someone else) need to update the August iteration plan?

FYI - as this is a simple update to a tmlanguage file, I won't be creating a PR.

FYI - as this is a simple update to a tmlanguage file, I won't be creating a PR.

One quick note just in case: please make sure that the name key is set to Python (not MagicPython) in the replaced tmLanguage.  We'd like to have an option for our users to manually install MagicPython and not have any potential conflicts.
Also, would it be possible to publicly state that VSCode uses MagicPython and to direct highlighter related issues to our tracker?

@1st1

make sure that the name key is set to Python

sure thing

publicly state that VSCode uses MagicPython

No sure how this would work, any idea how this would work @aeschli? However redirecting highlighter related issues to Magic Python tracker shouldn't be an issue.

Can you point me to the github repo where the magic python grammar file is located? I'll then file  a legal approval request and we can update OSSReadme.json which will add a reference to Magic Python and it's license to our thirdpartynotices file.
We currently have no mechanism to tell users to directly file issues against to the Magic python repo, but we will move the requests if they are filed against us after verifying it's not a bug in our text-mate parser or theme infrastructure.
A test plan item would make sense. We should test the grammar with all our built-in themes. Just create a issue that explains what to test and add the 'test-item' label and set milestone to August.
When updating, also verify the highlighting of the test file at update the syntax highlighting tests (run with ./scripts/test-integration, accept changes if you have verified that the new result makes sense).
Feel free to add more syntax highlighting tests.
I started adding update scripts as to make it easier to update grammar files. Check out
https://github.com/Microsoft/vscode/blob/master/extensions/scss/package.json#L7 as an example. It's invoked with npm run update-grammar

@aeschli

Here's the location:
https://github.com/MagicStack/MagicPython/tree/master/grammars
Thanks for the tip on automating the update of the grammar files. Will check this out.

I initiated the OSSRequest. You can proceed and change the OSSReadme file to
// ATTENTION - THIS DIRECTORY CONTAINS THIRD PARTY OPEN SOURCE MATERIALS:
[{
	"name": "MagicStack/MagicPython",
	"version": "0.0.0",
	"license": "MIT",
	"repositoryURL": "https://github.com/MagicStack/MagicPython"
}]

Let me know one you committed the changes, then I'll trigger the script that updates the ThirdPartyNotices.

@aeschli , I will submit a PR later today.
With regards to the update-grammar script:

Is this something that needs to be run manually or is this part of the build process? If it is manual, then that's fine

The update-grammar script converts the tmLanguage file to json. However looking at existing code, we don't do this for the Regular Expressions (JavaScript).tmLanguage file.
Would the same apply to the python regular expressions tmLanguage file.

I.e. the final result would be as follows (one json and other tmLanguage):
"grammars": [{
			"language": "python",
			"scopeName": "source.python",
			"path": "./syntaxes/Python.tmLanguage.json"
		},{
			"scopeName": "source.regexp.python",
			"path": "./syntaxes/Regular Expressions (Python).tmLanguage"
		}]

@DonJayamanne Thanks for looking into the grammar update scripts.
It’s a manual step. We want to update at a controlled time (e.g. not right before a release so that we get a chance to receive bug reports in time) and also do some sanity testing before pushing a grammar update.
I have just started adopting the scripts. I will add the script and migrate from using .json instead of plist/tmLanguage when there is a need to update the grammar.
Care is required as in some grammars we made manual changes, in anticipation of a fix or from a pull request, that I need to port over. So best is to check the commit history of the grammar to see what happened. Ideally such additions always have a test with them, like https://github.com/Microsoft/vscode/blob/master/extensions/javascript/test/colorize-fixtures/test6916.js
Yes, if Regular Expressions (Python).tmLanguage is still in use, then I’d suggest to update it as well.
The script takes multiple parameters if both grammars are from the same repo (see https://github.com/Microsoft/vscode/blob/master/extensions/cpp/package.json#L7).
Otherwise use && to run multiple commands in one script.


Repo top tab bar pixelated in latest beta

Something strange seems to have happened in the latest beta, the top tab bar is always pixelated.

Sent with GitHawk

Ugh, this line wasn't pulled. Reverting #2573 temporarily.


"Edit this page" links don't support the versioning scheme

https://forsetisecurity.org/docs/latest/setup/install.html has an "edit this page" link of https://github.com/GoogleCloudPlatform/forseti-security/edit/forsetisecurity.org/_docs/latest/setup/install.md, which does not exist.

The root problem is that in _includes/site/layout/docs/tabs.html the page.path variable is used. Publicly, we use latest while the repo uses _latest
<a class="icon github" href="{{ site.github.repository_url }}/edit/forsetisecurity.org/{{ page.path }}">
        Edit this page
      </a>

@EricBeach Yes, -dev should be the branch for changes.

@mirons-google - SGTM. I assume it should be -dev and the current code was a mistake. I've fixed it in #1807

Fixed in #1807


Using the cast function to convert ip types does not work

I have some string type IP addresses stored in a json.
I want to use the cast function to force a string to be converted to an ip type and then use cidr_match to match the ip address.
But I found that it doesn't work. The converted type is still a string which can't be handled by cidr_match.
{"ipaddr":"<IP_ADDRESS>","data":"test1"}
{"ipaddr":"<IP_ADDRESS>","data":"test2"}
{"ipaddr":"<IP_ADDRESS>","data":"test3"}

typeof(cast(ipaddr,<[ip]>))
----------
"<string>"
"<string>"
"<string>"

where cidr_match(<IP_ADDRESS>/8,cast(host,<[ip]>))
----------
nil

@burpheart: It's not working because the expression of the type in that cast() call reflects an attempt to cast to an array of ip, not a primitive ip type. We can see it working if we drop the square brackets. Note how the quotes are gone in real_ip, which is a visual indicator the cast was successful.
$ zq -z 'real_ip:=cast(ipaddr,<ip>)' data.json
{ipaddr:"<IP_ADDRESS>",data:"test1",real_ip:<IP_ADDRESS>}
{ipaddr:"<IP_ADDRESS>",data:"test2",real_ip:<IP_ADDRESS>}
{ipaddr:"<IP_ADDRESS>",data:"test3",real_ip:<IP_ADDRESS>}

$ zq -z 'where cidr_match(<IP_ADDRESS>/8,cast(ipaddr,<ip>))' data.json
{ipaddr:"<IP_ADDRESS>",data:"test1"}
{ipaddr:"<IP_ADDRESS>",data:"test2"}

BTW, for this type of simple cast you can also use the shorthand:
$ zq -z 'where cidr_match(<IP_ADDRESS>/8,ip(ipaddr))' data.json
{ipaddr:"<IP_ADDRESS>",data:"test1"}
{ipaddr:"<IP_ADDRESS>",data:"test2"}

Were there docs you were working from that led you to believe the syntax with the square brackets was necessary? If you could point them out I'd look at getting those updated to be clearer.


Built-in coroutines support

This will add possibility to run suspending code in blocking way (with launch()) from machine listeners.

When can finish it enhancement ? It's common use case in our development... Thanks

Can't say now. I'll pay it more attention, if you need this feature. You can write here your expectations.
From my point of view the most important here is making listener callback functions suspendable.
Currently I don't know the way how to implement it. As I don't want to add coroutines as dependency to main library .jar, keeping it separate in additional coroutines support .jar.

I expect that it can be supported coroutines and I can use suspend function when transition between states, it is normal use cases in implementation if you used coroutine in your project....

I have added basic coroutines support. now working on publishing it maven central. ferther improvments for coroutines integration will be done in next versions.
Note that you should use new 'kstatemachine-coroutines' artifact to work with coroutines.


.prefix does not prevent the prefix from having a space in it

.prefix allows you to change a server prefix to something with a space in it, however this new prefix will never be recognized by the bot (due to the space), forcing manually db editing to get the bot to ever respond to commands again.

not true. Just tested it.
.prefix one two
one twostats
Correctly works.

Whoops! I never thought to try just the first word. ^.^

just the first word? Both words.


Fix Project URL of NuGet.Server package

The Project Site link from https://www.nuget.org/packages/NuGet.Server/ leads to http://nuget.codeplex.com/, which now has a message directing to this project, https://github.com/nuget/home. I think the link at nuget.org should be rather changed to go directly to a project which builds the NuGet.Server package. And for the life of me I cannot find NuGet.Server sources on github...
Please untangle the links.
moved from https://github.com/NuGet/Home/issues/877

This is because the package was published before we made the final move.
Regardless we should fix this in a future release

It is pretty bad.  I can't find the code anywhere on their official repos.
I found this from @Haacked https://github.com/Haacked/NuGet/tree/861741bd780225a542c73a1d0904dd33b33a7a3d/src/Server
That also says that it is mirrored from a CodePlex repo though: https://git01.codeplex.com/nuget which doesn't work for me.
I am so confused.

We will finish moving over to github in the next few weeks

This PR on NuGet2 repo fixes it in code: https://github.com/NuGet/NuGet2/pull/9
Shall I update the metadata of the packages on nuget.org?
Only the latest version, or all of them?
Proposed change for all NuGet v2 packages (NuGet.Core, NuGet.Server, etc):

projectUrl: https://github.com/NuGet/NuGet2
authors: .NET Foundation (currently still points to Outercurve Foundation)

Just updated package metadata for the latest releases of the following NuGet v2 packages:

NuGet.Core
NuGet.Server
NuGet.Commandline
NuGet.VisualStudio
NuGet.Build


⚠ Tukarcoid has degraded performance

In c11bf59, Tukarcoid (https://tukar.co.id) experienced degraded performance:

HTTP code: 200
Response time: 2620 ms

Resolved: Tukarcoid performance has improved in 6cd7819 after 1 hour, 20 minutes.


UWP Client Exception Object reference not set to an instance of an object

Using the nuget 1.0.0-alpha2-final, my code works on .net core console, fails with the above error on UWP.
Stack:
at Microsoft.AspNetCore.SignalR.Client.HubConnection.d__31.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
at Microsoft.AspNetCore.SignalR.Client.HubConnection.d__27.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
at Microsoft.AspNetCore.SignalR.Client.HubConnection.d__26.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
at Microsoft.AspNetCore.SignalR.Client.HubConnectionExtensions.d__331.MoveNext() --- End of stack trace from previous location where exception was thrown ---    at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()    at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)    at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)    at System.Runtime.CompilerServices.TaskAwaiter1.GetResult()
at MyClient.d__7.MoveNext()
Using the source code 7c635fae56268a434b4fbfdcdcfa65539a733640 the core console works, the UWP gets compiler error "Cannot find type System.Buffers.OwnedMemory`1 in module System.Memory.dll"

I'm using the 1.0.0-rc1-final package from https://www.nuget.org/packages/Microsoft.AspNetCore.SignalR.Client/ and get the exception: Could not load file or assembly 'System.Memory, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=cc7b13ffcd2ddd51'. The system cannot find the file specified.
I'm using it in a blank UWP app, building for 17134 (Target and Min Version).

I'm not able to repro this in a UWP app. Would you be able to post a repro project on GitHub and link it? Getting a look at your csproj would help a lot.

@anurse Are you testing the UWP compiled as both debug and release? Release will do a AOT compile which is quite different.

Yep, I used Debug and Release. I did only try x86 though, I can try x64 and ARM to make sure those work too, since they might affect this.

I am also having this
System.IO.FileNotFoundException: 'Could not load file or assembly 'System.Memory, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=cc7b13ffcd2ddd51'.
My UWP app is compiled with both target and min version : Windows 10, version 1803 (10.0; Build 17134)

Sounds like you found the fix. You need at least a version that supports netstandard 2.0

If I build with all the latest versions, that Exception happens. Check it on your machine, on a UWP Project with
Target version:
Windows 10, version 1803 (10.0; Build 17134)
and Min version:
Windows 10, version 1803 (10.0; Build 17134)

Yes, going back for MinVersion to 16299 did it for me too.
Thanks

I think that the issue is not only that. Look again, Does not SDK 17134 support  .NET Standard 2.0 ?
Seems like a bug.

Ah, I see, when you move the min up to 17134 it breaks. I'll try that, I may know what the issue is.

@anurse keep this open as a tracking issue like Xamarin.

Created a clearer tracking issue #2406 since we've identified the issue and have a corefx PR to track.


Release v5.10.0

I recommend removing node 14 from the matrix. The failure is just due to using an ancient version of npm, and v14 has been EOL for a while now.


BREAD on table where foreign key is a string (belongTo relationship)

Version information

Laravel: v 7.28.0
Voyager: v 1.4.x-dev
PHP: v 7.4.8
Database: MySQL v 8.0.21

Description:
I have two tables products and prices related with a one to one relationship, the primary key of the products table is a string type named id (that represent the sku of a product), in the prices table the foreign key is named product_id.
When i try to add a new price using the price's BREAD I get this herror:
SQLSTATE[HY000]: General error: 1364 Field 'product_id' doesn't have a default value
The problem is that I need to asign a price to an existing product. A price without a product can't exist. But this error is telling me to make the product_id in the prices table nullable or assign a default value.
Obviously i can't assign a default value because the price has to be related to an existing product and if I change the product_id to nullable I have to set the price column nullable too. If I do so I'm able to set a price but the BREAD adds an extra empty record in the database. And in any case it is not the correct solution
Additional context
Before changing datatype from bigint ro string everything worked normally.
Screenshots
Prices BREAD with belongsTo relationship settings:

Full error message:

Tables involved:

Result if I set product_id and price to nullable:
2 records are inserted one is empty

Solved I had something wrong with my model


Is it possible to distinguish between click and swipe?

Hello there and thanks for your awesome library!
I'm trying to handle following case.
I have a product gallery, and I want to be able to know when user clicked on a slide (then I want to redirect user to product page) and when user just swipes to next photo.
Didn't manage to do this. Tried different variations. The best I could do is to apply pointer-events: none to wrapper div, which completely disabled swipe, but this is not exactly what I wanted.
P.S. I put @click on carousel component, tried also to put on slide, the click event didn't fire at all.
Thanks in advance

Hey @victor-ponamariov, sorry for the late reply! We don't currently send separate events for click and swipe, the closest would be a touch event we emit, but I don't think that will solve your problem. However, I think it would be useful - so I'll change this to a feature request.

Hi @quinnlangille :), I would love to build this feature. Has anyone already started on it?

@chicop negative! All yours if you want it :octocat:


Adding cluster - we are starting controller before cluster has been provisioned

Rancher versions: 2.0 master 2/1
Steps to Reproduce:

Create a cluster (I created a RKE cluster with 3 DO nodes)

Results:  There are a ton of error messages in logs because we are trying to start the controller before the cluster is provisioned.

Version - 2.0 master 2/21
Verified fixed


I want a way to comment everything generated

The docs say:

When your YAML is failing to parse, but you want to see what is generated, one easy way to retrieve the YAML is to comment out the problem section in the template, and then re-run

This is indeed extremely useful.
As a chart developer, I want a way to apply this concept to blocks of generated code. For example:
{{- toYaml .Values.foobar | comment }}

Workaround
{{- define "comment" }}
  {{- range (split "\n" .) }}
    {{- println "# " . }}
  {{- end }}
{{- end }}

{{- toYaml $dict | include "comment" }}

IMHO a comment function seems reasonable. I didn't manage to immediately think of a one-line builtin which could be used instead (e.g. | replace "\n" "\n#" is close). I think a PR to introduce such would be good.
In the interest of transparency, the Helm project does tend to try and avoid additional functional (that has to be maintained) if it can easily be achieved via (e.g. composing) existing functionality.


blue thingy on screen

can u make it optional like make the blue thingy appear or dissepear

yh, the script now works its just i press'leftAlt' nothing happens, i press 'alt gr' the blue thing just disappears,i mean yh it does show 'Github/.Averrias' but again i press 'leftalt' nothing happens can u fix this and maybe make the keybind to open the aimbot menu clearer(maybe something like 'ctrl') tysm for this script anyways very helpful, ur my heroes:))) (please fix it tho)

It doesn't seem to be working.

Resolved


[Identity] Add support for the new environment variables.

The latest documentation available by the identity docs show that the Azure resources are moving from MSI_ENDPOINT and MSI_SECRET to IDENTITY_ENDPOINT and IDENTITY_SECRET. Here's an example:
https://docs.microsoft.com/en-us/azure/app-service/overview-managed-identity?tabs=javascript#obtain-tokens-for-azure-resources
We should prepare for this by taking the value of the endpoint and the secret for either of the possible environment variables.

Gave it a cost of 2 because of communication with other members of the team, and feedback.

Closing on favor of https://github.com/Azure/azure-sdk-for-js/issues/10225


Refactor the examples to the plugin system

Related issue #21

Hello, I am a code review bot on flows.network.
It could take a few minutes for me to analyze this PR. Relax, grab a cup of coffee and check back later. Thanks!


Nested useDroppable triggered with the same Draggable

Hello !
I am working on an agenda App. This agenda is composed of:

Shift (Draggable)
Cells (Droppable)

Here is an example of the wanted behavior
https://user-images.githubusercontent.com/15988848/232544394-87d10507-8f5d-488e-9898-6219a7bfbcce.mov
The issue
How can I achieve the wanted behavior ?

My first thought was to use nested useDroppable:

The first one should be triggered when isOver on the whole Cell
The second one should be triggered when isOver on a specific action.
⚠ I tried this solution but it results in an infinite loop and my CPU that goes 100%

My second thought is to compute position in some way on the onDragEnd handler.
Or maybe set custom data-attribute on the actions elements, so I can retrieve theses child element data when the Draggable is dropped

@gamegee did you find a solution for this?

My solution (unfortunately) was to use react-dnd

This seems more like a problem in how you are setting the functionality up and not a bug/limitation of the library itself... If you still want a solution for this try to provide a simplified jsfiddle example of what you want and I'll look into it


Imported files should be treated as a custom shape

This issue has a dependent requirement of needing to support multiple shapes, #137. Once we can draw multiple shapes, the import process could be handled from the Playlist panel.

Support a new Shape type called FileImport (or similar) that cannot be transformed. This shape won’t appear in the Shapes drop list. Attributes are Zoom, File (presumably not editable once selected), and Aspect Ratio.
On the Layers tab, next to “New” button, add an “Import” button.
When clicked, should open a File dialog. If user selects a file, it will add a new FileImport layer. They can resize and move it via the preview.
Move “where to get .thr files” and “Note about copyrights” to “About”
Remove Import tab.

This is spot on. Thank you.
I do wonder if allowing transforms, but turning them off would be awesome. Using inkscape or estlcam to create a simple path (think a simple closed shape like a nike swoosh). Then importing it, then transforming it. That would have let me do the V1 logo without any changes to the code.
That is a feature I have wanted from the beginning, but it's never been this close. I may just silently enable this, and then work on some good documentation to explain how it would work later.


Add support for azurerm_web_application_firewall_policy

Having just used the CAF and noticed that the caf_naming isn't embedded in the submodule for azurerm_web_application_firewall_policy, since it doesn't exist.

hi @laingsc adding it into the provider for 2108 will update the module to use it for next major release.


Could you please tell me which trick has the greatest impact on the overall effect?

1 .2D RoPE in at each layer of our model;
2.Class-conditional image embedding;
3.Text-conditional image embedding;
4.CFG;
5. stage1 clip similarity score & stage2 rewrite pormpt by llava.

Hi~
It is hard to say which part has the greatest impact, because every part is important to the final performance :)
I can share our exploration process on each part:

2D rope: We first use 2D sincos pe, and then change to 2D rope. We find that 2D rope leads to faster convergence in the begining of training than 2D sincos pe, but their final performance are basically same.
Class-conditional embedding: We directly use the simplest implementation, which is using class-conditional embedding as start token.
Text-conditional embedding: Similarly, we use the simplest implementation.
CFG: This is very very very important to the performance, both in FID number and visual quality.
stage1 data filter: Honestly, we don't have the enough resourece to ablate the filter configuration, like clip similarity score. We just set a desired number, for about 50M, and then filter the total images to this number.
stage2 rewrite pormpt by llava: The long caption generated by llava could help our models to deal with long text conditional image generation, versus the short caption of LAION-COCO. Two other factors are also important: (1) image aesthetic quality (2) image resolution.

Hope these can help me .

Why use T5 model instead of GPT end-to-end text token to image token?
Thank you～

Hi~ It is hard to say which part has the greatest impact, because every part is important to the final performance :) I can share our exploration process on each part:

2D rope: We first use 2D sincos pe, and then change to 2D rope. We find that 2D rope leads to faster convergence in the begining of training than 2D sincos pe, but their final performance are basically same.
Class-conditional embedding: We directly use the simplest implementation, which is using class-conditional embedding as start token.
Text-conditional embedding: Similarly, we use the simplest implementation.
CFG: This is very very very important to the performance, both in FID number and visual quality.
stage1 data filter: Honestly, we don't have the enough resourece to ablate the filter configuration, like clip similarity score. We just set a desired number, for example, about 50M, and then filter the total images to this number.
stage2 rewrite pormpt by llava: The long caption generated by llava could help our models to deal with long text conditional image generation, versus the short caption of LAION-COCO. Two other factors are also important: (1) image aesthetic quality (2) image resolution.

Hope these can help you.

I am very surprised at the efficiency of your reply. Regarding the threshold for selecting image aesthetic quality, did you directly use LAION-COCO to filter out the image coefficient to determine it?
In addition, is the image resolution not fixed in the Tokenizer stage, as long as it meets the ratio?

Why use T5 model instead of GPT end-to-end text token to image token?
Thank you～

Hi~
Using an end-to-end model of language and image requires much more training data and resources, which beyond our capabilities. Sadly…

Hi~ It is hard to say which part has the greatest impact, because every part is important to the final performance :) I can share our exploration process on each part:

2D rope: We first use 2D sincos pe, and then change to 2D rope. We find that 2D rope leads to faster convergence in the begining of training than 2D sincos pe, but their final performance are basically same.
Class-conditional embedding: We directly use the simplest implementation, which is using class-conditional embedding as start token.
Text-conditional embedding: Similarly, we use the simplest implementation.
CFG: This is very very very important to the performance, both in FID number and visual quality.
stage1 data filter: Honestly, we don't have the enough resourece to ablate the filter configuration, like clip similarity score. We just set a desired number, for example, about 50M, and then filter the total images to this number.
stage2 rewrite pormpt by llava: The long caption generated by llava could help our models to deal with long text conditional image generation, versus the short caption of LAION-COCO. Two other factors are also important: (1) image aesthetic quality (2) image resolution.

Hope these can help you.

I am very surprised at the efficiency of your reply. @PeizeSun Regarding the threshold for selecting image aesthetic quality, did you directly use LAION-COCO to filter out the image coefficient to determine it?
In addition, is the image resolution not fixed in the Tokenizer stage, as long as it meets the ratio?

LAION-COCO metadata has provided the aesthetic score, and we use it to filter score low quality images in training stage 1 .
Training tokenizers can be resolution-variant. But in our experiments, we use fixed resolution.


feat: async course adding

Courses on Saturday and before 8 AM will be put into the async category now!!!

This change is

This is a Saturday Course

check and merge xd

💀

i would just like to say that this whole experience has been very traumatic and i will never be touching anything remotely related to "className" again


Update README.md

I noticed that I forgot to update the import section of README.md after the latest changes.
==edit==
Please note that I fixed a typo that also occurred in the hyperlink to this project wiki. So we should also fix it there.
While we are at it, we might also consider adding a CHANGELOG.md to inform and keep track about versions and changes. What do you think?

@robinmatz I think the changelog is a very good idea!


Ads support

Please add Ads support using vast to implement pre-roll, mid-roll, etc.
Thank you.

Adding some documentation links which might be helpful for this conversation.
Google's IMA client-side SDKs should be useful (it's also compatible with other VAST-compliant ad servers)
https://developers.google.com/interactive-media-ads
https://developers.google.com/interactive-media-ads/docs/sdks/html5/client-side
There's also a legacy plugin for plyr (last updated 2017) which might be helpful.
https://github.com/ferdiemmen/plyr-ads

Yes, this would be awesome.
One more step towards feature parity with Plyr which supported ads natively: https://github.com/sampotts/plyr?tab=readme-ov-file#ads

There's an open draft PR for IMA integration here. #1046

We'll need this before migrating over from Plyr

Any follow up on this?!

Let's get #1046 merged 🙏🏼

The PR was closed.  That can't be a good sign.

pls add this

we need this, I hope it will be added this year 🙏🏼

Awesome work on the project but we are still waiting for this feature so be able to switch to Vidstack.

As others have already said, I really hope this can be added soon. It’s the last feature needed before my company can start using it.

Hi,
Any update here ?


CLOUD-43501 added frankfurt

@martonsereg

Jenkins build finished, all tests passed.
Refer to this link for build results: http://ci.sequenceiq.com/job/cloudbreak-pull-request/1721/


Fix deprecated interceptors response in auth.js

Hi there, this PR will help fix #1 issue

+1

thanks @ayr-ton


./svc.sh: command not found

The command failed with exit code 1
0. Determining if Azure Pipelines agent is configured...

Determining matching Azure Pipelines agent...
Downloading and installing Azure Pipelines agent...
Configuring Azure Pipelines agent...
[sudo] password for ***: sudo: ./svc.sh: command not found

tried this fix https://github.com/Microsoft/azure-pipelines-agent/issues/1435
but it fails with
E: Package 'libicu67' has no installation candidate
Reading package lists... Done
Building dependency tree
Reading state information... Done
libicu66 is already the newest version (66.1-2ubuntu2.1).
0 upgraded, 0 newly installed, 0 to remove and 0 not upgraded.
Finish Install Dependencies
Specifications

OS: Ubuntu 20.04.5 LTS (GNU/Linux 5.15.0-1020-azure x86_64)
-> Image is running in vsphere
-> image is replicate of azure ubuntu-latest image thats used in azure devops
Version of agent:
-> link https://vstsagentpackage.azureedge.net/agent/2.211.1/vsts-agent-win-x64-2.211.1.zip
-> version 2.211.1.

Desired outcome:
i just want the svc.sh files to show up to pop the agent into systemd, not sure why it thinks its not installing it

tried to get logs but none avalable

Is the link to the agent in your comment correct? This is Window version but you are talking about Ubuntu.

link https://vstsagentpackage.azureedge.net/agent/2.211.1/vsts-agent-win-x64-2.211.1.zip

Did you follow this recommendation to run installdependencies.sh?
https://learn.microsoft.com/en-us/azure/devops/pipelines/agents/v2-linux?view=azure-devops#:~:text=The agent installer knows how to check for other dependencies. You can install those dependencies on supported Linux platforms by running ./bin/installdependencies.sh in the agent directory.

HI @CraigCraig-jpeg do you have any updates?

Hi @CraigCraig-jpeg , close this issue. Feel free to ask any other questions or let us know if it's still relevant for you.


Dart CLI error

I am using flutter since 1 year but not able to learn smoothly for a particular reason.
I get an error Dart CLI error frequently for which I again have to install and uninstall flutter sdk .
Everything goes fine for 1 or two days after then I face the problem again .

Hi @rakz25
Thanks for filing the issue,can you please provide your flutter doctor -v and complete flutter run --verbose logs reproducing the issues?
Thank you

[image: flutrdoc.png]
On Thu, May 6, 2021 at 1:48 PM Taha Tesser @.***> wrote:

Hi @rakz25 https://github.com/rakz25
Thanks for filing the issue,can you please provide your flutter doctor -v
and complete flutter run --verbose logs reproducing the issues?
Thank you
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/flutter/flutter/issues/81914#issuecomment-833330037,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AEOLD4C7EK3264LEKZCPZ7TTMJGFVANCNFSM44FM63LQ
.

[image: flutterrun.png]
On Thu, May 6, 2021 at 5:23 PM Rakesh Lahkar @.***>
wrote:

[image: flutrdoc.png]
On Thu, May 6, 2021 at 1:48 PM Taha Tesser @.***>
wrote:

Hi @rakz25 https://github.com/rakz25
Thanks for filing the issue,can you please provide your flutter doctor -v
and complete flutter run --verbose logs reproducing the issues?
Thank you
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/flutter/flutter/issues/81914#issuecomment-833330037,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AEOLD4C7EK3264LEKZCPZ7TTMJGFVANCNFSM44FM63LQ
.

Hi @rakz25
Looks like the images you're trying to the comments are failed.
Can you please provide your flutter doctor -v and complete flutter run --verbose logs reproducing the issues? instead of screenshots
Thank you

Sure, here it is.
flutter doctor -v
Building flutter tool...
Failed to start the Dart CLI isolate
(null).
Error: Unable to 'pub upgrade' flutter tool. Retrying in five seconds... (9
tries left)
Failed to start the Dart CLI isolate
(null).
Error: Unable to 'pub upgrade' flutter tool. Retrying in five seconds... (8
tries left)
Failed to start the Dart CLI isolate
(null).
Error: Unable to 'pub upgrade' flutter tool. Retrying in five seconds... (7
tries left)
On Thu, May 6, 2021 at 6:25 PM Taha Tesser @.***> wrote:

Hi @rakz25 https://github.com/rakz25
Looks like the images you're trying to the comments are failed.
Can you please provide your flutter doctor -v and complete flutter run
--verbose logs reproducing the issues? instead of screenshots
Thank you
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/flutter/flutter/issues/81914#issuecomment-833499145,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AEOLD4EZT4GINI4IDCKCZ7TTMKGUFANCNFSM44FM63LQ
.

flutter run --verbose
Building flutter tool...
Failed to start the Dart CLI isolate
(null).
Error: Unable to 'pub upgrade' flutter tool. Retrying in five seconds... (9
tries left)
Failed to start the Dart CLI isolate
(null).
Error: Unable to 'pub upgrade' flutter tool. Retrying in five seconds... (8
tries left)
Failed to start the Dart CLI isolate
(null).
Error: Unable to 'pub upgrade' flutter tool. Retrying in five seconds... (7
tries left)
On Thu, May 6, 2021 at 6:30 PM Rakesh Lahkar @.***>
wrote:

Sure, here it is.
flutter doctor -v
Building flutter tool...
Failed to start the Dart CLI isolate
(null).
Error: Unable to 'pub upgrade' flutter tool. Retrying in five seconds...
(9 tries left)
Failed to start the Dart CLI isolate
(null).
Error: Unable to 'pub upgrade' flutter tool. Retrying in five seconds...
(8 tries left)
Failed to start the Dart CLI isolate
(null).
Error: Unable to 'pub upgrade' flutter tool. Retrying in five seconds...
(7 tries left)
On Thu, May 6, 2021 at 6:25 PM Taha Tesser @.***>
wrote:

Hi @rakz25 https://github.com/rakz25
Looks like the images you're trying to the comments are failed.
Can you please provide your flutter doctor -v and complete flutter run
--verbose logs reproducing the issues? instead of screenshots
Thank you
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/flutter/flutter/issues/81914#issuecomment-833499145,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AEOLD4EZT4GINI4IDCKCZ7TTMKGUFANCNFSM44FM63LQ
.

Any command I run regarding flutter I get the same issue . I get resolved
when I uninstall and install flutter sdk and again after a day or two I get
the same error.
WIth regards,
Rakesh Lahkar
On Thu, May 6, 2021 at 6:31 PM Rakesh Lahkar @.***>
wrote:

flutter run --verbose
Building flutter tool...
Failed to start the Dart CLI isolate
(null).
Error: Unable to 'pub upgrade' flutter tool. Retrying in five seconds...
(9 tries left)
Failed to start the Dart CLI isolate
(null).
Error: Unable to 'pub upgrade' flutter tool. Retrying in five seconds...
(8 tries left)
Failed to start the Dart CLI isolate
(null).
Error: Unable to 'pub upgrade' flutter tool. Retrying in five seconds...
(7 tries left)
On Thu, May 6, 2021 at 6:30 PM Rakesh Lahkar @.***>
wrote:

Sure, here it is.
flutter doctor -v
Building flutter tool...
Failed to start the Dart CLI isolate
(null).
Error: Unable to 'pub upgrade' flutter tool. Retrying in five seconds...
(9 tries left)
Failed to start the Dart CLI isolate
(null).
Error: Unable to 'pub upgrade' flutter tool. Retrying in five seconds...
(8 tries left)
Failed to start the Dart CLI isolate
(null).
Error: Unable to 'pub upgrade' flutter tool. Retrying in five seconds...
(7 tries left)
On Thu, May 6, 2021 at 6:25 PM Taha Tesser @.***>
wrote:

Hi @rakz25 https://github.com/rakz25
Looks like the images you're trying to the comments are failed.
Can you please provide your flutter doctor -v and complete flutter run
--verbose logs reproducing the issues? instead of screenshots
Thank you
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/flutter/flutter/issues/81914#issuecomment-833499145,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AEOLD4EZT4GINI4IDCKCZ7TTMKGUFANCNFSM44FM63LQ
.

Hi @rakz25
Thanks for the details, that's unfortunate, I have never this error message on any of my setups.
Do you have any antivirus/firewall installed on your system? Can you please disabling or whitelisting the flutter and it's dependcies. Please check out https://github.com/flutter/flutter/issues/61997

Yes,I have disable and force quit clean my mac app I did. but facing same
error
On Fri, May 7, 2021 at 1:21 PM Taha Tesser @.***> wrote:

Hi @rakz25 https://github.com/rakz25
Thanks for the details, that's unfortunate, I have never this error
message on any of my setups.
Do you have any antivirus/firewall installed on your system? Can you
please disabling or whitelisting the flutter and it's dependcies. Please
check out #61997 https://github.com/flutter/flutter/issues/61997
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/flutter/flutter/issues/81914#issuecomment-834146781,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AEOLD4CX5JZHHK64DATSFBDTMOLYNANCNFSM44FM63LQ
.

 It sounds like your Dart SDK is corrupted or you're running in some non-standard way that we've overlooked.


Check for Google API access from image import/export scripts

Check for Google API access from image import/export scripts running in VMs.

/retest

/flake8

/retest


BUG: optimize failure on wheels

Master branch wheel builds have been failing since around 18 days ago, with the traceback below the fold only observed for Python 3.5 / 3.7 on MacOS:

_______________________ TestCurveFit.test_broadcast_y _________________________

[gw0] darwin -- Python 3.5.4 /Users/travis/build/MacPython/scipy-wheels/venv/bin/python

self = <scipy.optimize.tests.test_minpack.TestCurveFit object at 0x118e37cc0>

    def test_broadcast_y(self):

        xdata = np.arange(10)

        target = 4.7 * xdata ** 2 + 3.5 * xdata + np.random.rand(len(xdata))

        fit_func = lambda x, a, b: a*x**2 + b*x - target

        for method in ['lm', 'trf', 'dogbox']:

            popt0, pcov0 = curve_fit(fit_func,

                                     xdata=xdata,

                                     ydata=np.zeros_like(xdata),

                                     method=method)

            popt1, pcov1 = curve_fit(fit_func,

                                     xdata=xdata,

                                     ydata=0,

                                     method=method)

>           assert_array_equal(pcov0, pcov1)

E           AssertionError:

E           Arrays are not equal

E

E           (mismatch 100.0%)

E            x: array([[ 0.00011 , -0.000783],

E                  [-0.000783,  0.005931]])

E            y: array([[ 0.00011 , -0.000783],

E                  [-0.000783,  0.005931]])

fit_func   = <function TestCurveFit.test_broadcast_y.<locals>.<lambda> at 0x118a48158>

method     = 'dogbox'

pcov0      = array([[ 0.00011024, -0.00078326],

       [-0.00078326,  0.00593076]])

pcov1      = array([[ 0.00011024, -0.00078326],

       [-0.00078326,  0.00593076]])

popt0      = array([ 4.67757254,  3.76916206])

popt1      = array([ 4.67757254,  3.76916206])

self       = <scipy.optimize.tests.test_minpack.TestCurveFit object at 0x118e37cc0>

target     = array([   0.4236548 ,    8.84589411,   26.23758721,   53.691773  ,

         90.16366276,<PHONE_NUMBER>2,<PHONE_NUMBER>4,<PHONE_NUMBER>2,

<PHONE_NUMBER>6,<PHONE_NUMBER>4])

xdata      = array([0, 1, 2, 3, 4, 5, 6, 7, 8, 9])

../venv/lib/python3.5/site-packages/scipy/optimize/tests/test_minpack.py:787: AssertionError

If someone does determine the cause of this failure, it would also be useful to know why it shows up in the wheel repo and not in dev CI, so that we can continue to work toward reducing the dissonance between the two.

Could it be related to the fact that ydata is float when defined as np.zeros_like and an int in the other case?  This might drive subtle differences in environment behavior.

in any case it should have been assert_array_almost_equal

assert_array_equal is definitely wrong to use in this case.
I've tried running these tests on macOS, with 3.5.6 and 3.7.3, from the tip. I can't reproduce the issue on my machine.
I think the fix is to change the onerous assert.


Collect cardinalities inside of loops

We are not yet storing cardinalities measured inside of loops. However, now that we are injecting OperatorContexts into the execution (also in loops), we should actually be able to store them.

This issue was moved to rheem-ecosystem/rheem#26


Create an operation cache

This might involve 2 operations:

UpdateCache - stores the input in the cache (with a provided string key) and returns the input
FetchCache - returns the entire cache
FetchCachedResults - returns results from the cache with the provided key

The cache should work for elements or just objects and allow users to cache steps of an operation chain separately - this could be achieved by passing in a key as part of the UpdateCache operation.
For small amounts of data a HashMap<String, Iterable<Object>> would work for for the cache. We could consider added options to UpdateCache to specify the type of cache you wish to use - for example the cache could be a new Gaffer graph.
For example:

Build up a graph of all vertices traversed

final Iterable<?> cachedResults = graph.execute(new Builder()
    .first(new GetAdjacentEntitySeeds.Builder()
            .addSeed(new EntitySeed("A"))
            .build())
    .then(new UpdateCache())
    .then(new GetAdjacentEntitySeeds())
    .then(new UpdateCache())
    .then(new FetchCachedResult())
    .build());

Get related edges and entities separately

final Map<String, Iterable<?>> cachedResults = graph.execute(new Builder()
        .first(new GetAdjacentEntitySeeds.Builder()
                .addSeed(new EntitySeed("A"))
                .build())
        .then(new UpdateCache("adj-seeds"))
        .then(new GetEntitiesBySeed())
        .then(new UpdateCache("entities"))
        .then(new FetchCachedResult("adj-seeds"))
        .then(new GetRelatedEdges())
        .then(new UpdateCache("edges"))
        .then(new FetchCache())
        .build());

gh-127 will extend this cache operation and add the functionality to return a new gaffer graph.

Pull request approved and merged in to develop branch.


Lists (ordered and unordered) don't have accent color

Checkboxes do have accent color, while lists are grey

Thanks for the feedback, good catch. I've added the accent color to the bullets now which does look a lot better. The update should appear soon. Thanks!


TextConfig: added "errors"

This patch adds the ability to set the errors option of open for loading text datasets. I needed it because some data I had scraped had bad bytes in it, so I needed errors='ignore'.

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.

Thanks for adding this ! You can fix the CI by formatting your code using the make style command :)

@lhoestq commented on Oct 27, 2022, 4:08 PM GMT+3:30:

Thanks for adding this ! You can fix the CI by formatting your code using the make  style command :)

I ran this and force pushed the changes.


Adding in diff plugin execution

This allows the execution of the helm diff plugin for the entire state file, which for us makes it very easy to visualize the configuration drift of a given environment for auditing and greater confidence in the deployment similar to a terraform plan on an environment.
NOTE:

Simple copy-paste for the most part from sync job.  I had started down
the path of adding in a meta PluginCommand directive and trying to make it
more modular, but in the end there are some small differences between
the execution that were a bit difficult to model and it just got ugly.
Figured keeping it simple would be easier to manage.

If a more extensible form of this is desired I can work on modeling that a bit to make it easier to add in arbitrary sets of functionality but I wanted to get the conversation started

Cool! Thanks for the contribution.
I won't have a chance to review this for a couple days, but hang tight.

I think the code looks okay as is.
Can you add documentation with pointers on how to get helm-diff set up and update the README with the new command?

Will do tonight, thanks.

I haven't used helm diff before, but assuming you are currently using this and it's good to go, I'm happy to merge when you are ready.

Appreciate it, I think we are good to go

Excellent! Merging this, and I'll cut a new release once we merge your other PR.


objectForMapping not called

Hello guys.
I've updated pods (ObjectMapper (1.4.0)) a moment ago and had found out that func objectForMapping(map: Map) not called anymore when I call ParsingService<NSManagedObjectInheritant>().parseObject(Object).
It causes objects being duplicated. Please advise if I should use other function now.
UPD: Installed version 1.3. It works fine.

objectForMapping(map: Map) was moved into
protocol StaticMappable: Mappable {
...
}
Replace Mappable with StaticMappable wherever you need to use objectForMapping

Thanks @jpstern

I also ran into this recently and it took some time to debug.
I would have much preferred this to come with a version 2.0 ObjectMapper since this was a breaking change. Is there a particular reason it wasn't?

@jakecraige my mistake, this change definitely warranted a major version number change.


[BEAM-10556] Move rawtype error suppression to class level

Previously rawtype errors were suppressed at the module level. This makes it more fine-grained so it is easier to fix a class and have it stay fixed.

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[x] Choose reviewer(s) and mention them in a comment (R: @username).
[x] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
[x] Update CHANGES.md with noteworthy changes.
[x] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI.

R: @tysonjh
I saw you fix a rawtype in your pull request and it reminded me. I was very happy with the result of doing this with nullness checks.

Ooh Dataflow job 2020-11-04_10_26_53-711210068449461490 terminated in state UNRECOGNIZED but did not return a failure reason. is fun. We should probably make that state UNRECOGNIZED(<raw string>)

Run Java_Examples_Dataflow_Java11 PreCommit

Looks like GitHub Actions one job failed to upload logs after the tests passed. Is there a way to rerun just that action?

Looks like GitHub Actions one job failed to upload logs after the tests passed. Is there a way to rerun just that action?

There should be an option in the workflow list, I can't see it but always assumed it was because I'm not a committer:
https://github.com/apache/beam/actions/runs/346066613

I only have "Re-run all jobs" which seems like overkill. Perhaps it is just about how the actions are grouped.


Vllm support

Hello, I see there was a PR for VLLM support but it was not active since Feb. I wonder if Flashinfer has a roadmap for vllm support. Many thanks. @yzh119

Sorry for the very late reply.
vLLM has FlashInfer backend since a few months ago.


Capture link for changed files for impactBuild scenario in dbb build results

This implements #113 .
In case of an --impactBuild scenario, the dbb build report contains a link to the actual changed files. Similar to the calculation of changed files through the git diff between the baseline and current hash - at https://github.com/IBM/dbb-zappbuild/blob/0d2fe5899fb55d89a4c977bbf53259710281386a/utilities/GitUtilities.groovy#L180
Sample output in verbose (adjusted so you actually see the compare view in Github)
*** Obtaining hash for directory /u/dbehm/test-zapp/dbb-zappbuild/samples/MortgageApplication
** Setting property :githash:MortgageApplication : 0d2fe5899fb55d89a4c977bbf53259710281386a
** Setting property :giturl:MortgageApplication : https://github.com/dbb-zappbuild/dbb-zappbuild.git
** Setting property :gitchangedfiles:MortgageApplication : https://github.com/ibm/dbb-zappbuild/compare/49401c9bd8873d95855ea07bbf9b982aa87ceac4..0d2fe5899fb55d89a4c977bbf53259710281386a
** Writing build report data to /u/dbehm/test-zapp-app-out/mortgageout/build.20210614.012436.024/BuildReport.json
** Writing build report to /u/dbehm/test-zapp-app-out/mortgageout/build.20210614.012436.024/BuildReport.html

retrieveLastSuccessfulBuildResult() in buildUtils is introduced to centrally obtain the last successful build result.

Right now it only supports single repo builds, this is correct. We can add multiple repo builds later. It just creates a link which the customer can use in the browser, so no need to care about credentials.
While Jenkins or others CI orchestrators also provide links to commits, there might be a mismatch, if the previous build failed. The link represents the actual changed files which got identified by the build framework.


A problem with Chat Patches

With Chat Patches installed it plays the mention sound every time you open the chat. Not sure if it's a fault of Chat Patches or chat highlighter but let it be there.

And it plays the sound more the more times you are mentioned in chat, which gets louder

thanks for reporting the issue! i have released 1.2.1 on modrinth which contains a fix

of course! i simply forgot to push my changes yesterday, see commit a2ec72df8e48e868410f71031392145b0447c970

oh, okay <3


Issue with username showed

As we can see on the image, all names are replaced with "User" for real account and for bots at the creation of the file, I don't know where it can from but it happen to all transcript I do.

Update discord.js to the latest version

Okay, I updated to the latest version (14.12.1) and now it's working.
I was in 14.11.0 before.


GoodDollar stuck on BraveBrowser (Chromium-based) on the splash

Initialisation fails due to the 'connection failed'

this is dup of #2307 brave have ad blocking by default. it works fine if ad blocker is turned off

don't think that because user mentioned:

turned off the Brave Shields but the problem persisted

QA reported that app works with shields disabled:
https://www.screencast.com/t/thJxxYpYny


ci(actions): conditional automerge

:tada: This PR is included in version 1.11.3 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Feature Request:  Have the Bot open a DM with a user on ping

For ease-of-use and prevention of clutter, it would be nice to have an option for the Bot to, when pinged with an @ by a user, open a new thread as though the !newthread command had been issued.  Bonus points for an optional opening message or for using the standard one.

More bonus points for purging the message with the ping in the open channel.

This has been added, I think this request can be closed?

Hi, can you please create plugin for creating threads also with reaction panels on servers (something like Ticket tool panel)
So when user react with defined emoji to defined message modmail will start thread with him


Pipeline examples

Create diagrams to sketch and define minimal requirements:

Uni-batch
Multi-modal single batch
Single modal multi-batch
Multi-modal multi-batch

Full joint embedding
Per modality embedding

Align on this.

Put your outputs into docs/use-cases! :)

Examples have been moved to the documentation site, currently at https://openpipelines-bio.github.io/architecture/use-cases.html (subject to change).


blockstore: don't write shreds to the WAL

We don't need the WAL to recover shreds in the case of crashes - shred recovery can be done via chain protocol duh.
This makes inserting shreds into rocks about 4x faster since it stops flushing the WAL to disk.

and corresponding profiles
before

after


Allow plug 1.8

This loosens the version constraint on Plug to allow 1.8 as well as 1.7.1 or higher

thanks @aselder


add data source: go.dev documentation

This is already implemented and just needs to be enabled. It is slow so we need to figure out a way to enable it without blocking important actions from occurring in a timely manner.
Child of #25

Have you confirmed it's slow from Cloud Run to Firestore?

Crawl is now triggered by a Cloud Scheduler job once every weekday.