Implement snap packaging

This pull request implements the necessary changes to package drone-cli as a snap,
Snaps are universal linux packages.
This PR should supersede #122 in terms of completeness, credits goes to @mikeroyal who provides most if not all the details needs to be taken care of, though this PR includes the following notable changes:

Changing the snap and command name from drone-cli to drone to match documented usage

Using my selective checkout scriptlet to checkout and build latest tagged release if the stable channel yet have one

(Hopefully) Fix version tagging:
$ drone --version
drone version 1.2.1-6-geef6428-dirty

Using my locales-launch launcher script to fix locales at runtime

Adding an app-specific maintenance launcher to check confinement status and for future conveniences.

This snap has been successfully built on amd64, armhf, and arm64 architectures, and is runnable on an amd64 system.
Signed-off-by: 林博仁(Buo-ren, Lin<EMAIL_ADDRESS>

Some notes regarding the snap name:

The drone snap name is currently reserved by the Snap Store but is claimable via https://dashboard.snapcraft.io/register-snap/?name=drone
I've registered the drone-cli snap name (rest assured that the snap name is easily transferable), however using this name will require us to file a auto-alias request so that we can continue using the drone command name instead of drone-cli.drone or drone-cli, refer Commands and aliases | Snapcraft documentation and Process for aliases, auto-connections and tracks - store-requests - snapcraft.io, and Requesting default aliases for FeatherPad - store-requests - snapcraft.io for more info.

This looks good 🥇
we have created a proposal https://github.com/drone/proposal/issues/4 to gauge support for this feature, as we would need to setup the infrastructure / support for maintaining this going forward. If you want it give it a 👍

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

This PR has been automatically closed due to inactivity.


fix timing bug

This fixes a bug where errors were thrown if the environment or padding props were changed before the sceneview has finished loading.

Code looks good, not sure how to do the functional testing.


Adds back the precommit hook

Prettier runs on the precommit. It will fail the commit if any file is updated by it, a message is show to warn the developer.
Moved husky and prettier to devDependencies and removed lint-staged as is no longer used.
@jotak I think you removed the precommit because it staged the files automatically, this does something similar to swscore, please review.

Note: There is one file that is failing the linter, fixed in PR #88

I think we should try adding it back for this sprint and judge from there. I have seen people (including myself) forget to format even as easy as it is now.

I think we should try adding it back for this sprint and judge from there. I have seen people (including myself) forget to format even as easy as it is now.

Yes, is failing most of time because someone forgot (and that happens easily) to prettier their files.
Having this precommit hook is middle ground from autocommiting files and not doing anything, plus is similar to what swscore is doing.

https://docs.jboss.org/display/SWS/Project+Rules
"Commit messages must begin the JIRA name associated with the PR. If the PR is to address SWS-99 then the commit message for the PR must start with "SWS-99: " and then followed by the detailed commit message."

@lucasponce what value would bring a JIRA ticket here? Nothing to test for QE. Nothing to track for sprints. No feature. Isn't it over-processing?

@lucasponce what value would bring a JIRA ticket here? Nothing to test for QE. Nothing to track for sprints. No feature. Isn't it over-processing?

I think that could be subjective.
I'm not arguing that, but then it should be clarified when to use JIRA codes in commits and when not, and everyone in the same page.
If not project rules are useless.

@lucasponce I know and that's why I already brought this topic on ml, without effect unfortunately.
I we can avoid flooding our jira notifs even more than they are with trivial stuffs it would be great :)

@lucasponce I know and that's why I already brought this topic on ml, without effect unfortunately.
I we can avoid flooding our jira notifs even more than they are with trivial stuffs it would be great :)

Probably I don't disagree, but until we are in the same page, and everyone accepts same concepts as "trivial" I guess we should follow the rules (if not, again, why project rules are defined ? also, if project rules are wrong, they can be modified).
I don't think we should increase the number of JIRAs, i.e. if I miss something trivial for a related JIRA I reuse the same code, as it will help to understand the context.

My 2 cents on the pre-commit hook. May I propose a more proactive and preventative measure as part of the code-commit process?

Ctrl-Shift-I (assuming you're using Visual Studio Code on Fedora) to prettify your code
Squash your commits
npm run lint

I'm quite happy with prettier doing all the heavy duty formatting. It's just one less decision that Developers need to think about and it ensures consistency.
But I can go either way on the pre-commit hook.

Travis failed because of prettier... how ironic :-)

Actually, that's the point of this PR. Is getting frequent that a developer forgets to run prettier on their code. The error shows but reviewers merge anyway.
The intention of this precommit hook is to make aware the developers that they forgot to do this (in case of an error).
This always run prettier before commiting and if there is an error, warn the developer (and fail the commit). This behavior of course can be skipped. Instructions are print on the screen on how do to Skip the check.
The specifics of the fails are related to #88, will rebase to have travis green. Unless new unpretty code is in master :)

I think prettier and tslint are 2 different tools, no?
prettier: formats code to meet most of tslint rules.
Ultimately it's tslint, the gatekeeper that fails the build.  IMO throwing everything at travis is not the way to go.

Ultimately it's tslint, the gatekeeper that fails the build. IMO throwing everything at travis is not the way to go.

Actually, I don't think (i might be wrong) that we are even running tslint on travis. I didn't even noticed it was a dependency.
I would say that using either one is OK, unless they both complement each other. e.g. some rules not being tested by tslint but by prettier.
At any point, i truly believe that having prettier run on the developer side is good, one thing less to worry about (running prettier before commiting) and ensuring that we only commit formatted code.
On the current PR, it won't auto-commit for you, we could test this way and if there is no issues, we could move to auto-commit.
Thoughts?

Pull Request Test Coverage Report for Build 201

0 of 0 (NaN%) changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 25.991%

Totals

Change from base Build 200:
0.0%

Covered Lines:
190

Relevant Lines:
585

💛  - Coveralls

@josejulio tslint should be automatically run as a part of npm build or npm start

@lucasponce @jotak
Created SWS-243 and added the number to the commit and PR title.

@josejulio tslint should be automatically run as a part of npm run build or npm start. Check out the last 2 lines.

You are right on that, though we had to do an explicit call.

Ok, merging as I think we have agreement on this. Although, we can also change this at any time if we feel this is not the right solution.

This one is under trial assessment and subject to change.


Rename Microsoft.AspNetCore.Razor.Evolution => Microsoft.AspNetCore.R…

…azor.Language.

Also updated corresponding test project to go from Evolution => Language.
Regenerated test files to reflect new file paths.

#1169
MVC Reaction PR: https://github.com/aspnet/Mvc/pull/6105

:shipit:


Redirect to a url after user exits a room

This might be a new feature request, but I would like to redirect a user to a url after the meeting is over or user exits the room. I'm not sure if it's already a feature, I couldn't find a documentation on that.

@shubhendumadhukar thank you. I've added new pull. If you can test then can follow:
https://github.com/mynaparrot/plugNmeet-client/blob/90a13e34bfcf40924c9332fa4e9800b046794faf/src/login.html#L128

Hi @jibon57,
Apologies for the delay in response, I just updated the server, client and sdk to the latest versions, however I don't see the redirection to logout_url happening.

logout_url
string
No
You can put logout URL in where plugNmeet will redirect the users after meeting/session ended.

Steps I have followed:

Create a new meeting with logout_url in metadata.
Join meeting with the generated access token.
Go to menu > end meeting.

Expecting to be redirected to the url provided as logout_url, however after I end the meeting, I am shown the page stating a message.
Room disconnected
The room has been closed. Code: ROOM_ENDED

Make sure you've updated your server + client in latest version. It will took 5 seconds before redirect

My bad. It does work as expected. Thanks!
Is there a justification behind the 5 secs gap?


FIX: Tensor size mismatch in VariationalMeanField.forward

Fixes #14 (at least I hope so).

Good catch, thanks!


add a organizationNormalized template value for SCM provider

From the issue https://github.com/argoproj/applicationset/issues/640
This MR adds a organizationNormalized parameter to the SCM provider to ensure we can then use the Org name in templates

Tests are faining in the docker build image... which is using golang:1.13.4... so old :)


Keyboard navigation to improve accessibility

How can I make this keyboard navigable (rather than just mouse) to improve accessibility and help screen readers?
What I'm going for is something like how the regular bootstrap dropdowns let you focus and move up/down with the cursor keys.

I have solved this. For future readers...
First, in my menu items, I've added an  which causes the menu item to be able to get focus.
Second, at the end of bootstrap-table-contextmenu.js I cause focus on the menu when it is activated:
      // set focus         $(this.options.contextMenu).focus();
Now when I called the menu from a button in the row (with contextMenuButton option), it can be activated with a space bar and the tab key goes down the menu. Press enter to select a menu option.
Also, having a button in the row makes the bootstrap-table navigable with the tab key.


Signal Tracking: update connected checks

Description
In this PR we remove any connected checks in signal tracking system and reset the tracking metrics when a client reconnects.

@jason-ha bumping this


Fix flaky test in ReflectiveDisassembleOperationHandlerTest

Sort the list "operations" by "DisassembleOperation::getKey" to maintain the order of elements to remove flakiness in the test.
Flaky test
cn.crane4j.core.executor.handler.ReflectiveDisassembleOperationHandlerTest#process

https://github.com/bbelide2/crane4j/blob/679c3f860fb8c1d8e69c64cd7662e9047f7d99ed/crane4j-core/src/test/java/cn/crane4j/core/executor/handler/ReflectiveDisassembleOperationHandlerTest.java#L37
Problem
Test process in ReflectiveDisassembleOperationHandlerTest is detected as flaky with the NonDex tool. The test failed with the following error:
Tests run: 1, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 0.21 sec <<< FAILURE!
process(cn.crane4j.core.executor.handler.ReflectiveDisassembleOperationHandlerTest)  Time elapsed: 0.004 sec  <<< FAILURE!
org.junit.ComparisonFailure: expected:<bean[]> but was:<bean[List]>
        at org.junit.Assert.assertEquals(Assert.java:117)
        at org.junit.Assert.assertEquals(Assert.java:146)
        at cn.crane4j.core.executor.handler.ReflectiveDisassembleOperationHandlerTest.process(ReflectiveDisassembleOperationHandlerTest.java:44)

Root cause
During the execution of the test, we fetch the fields names of the "Bean" class (which is an inner class in "ReflectiveDisassembleOperationHandlerTest") using getDeclaredFields function. But, getDeclaredFields does not guarantee the order of elements it returns, so it can return different order of fields each time. Therefore, the order of elements in Collection<DisassembleOperation> operations is not guaranteed thus making this test flaky. When tested with NonDex, this test fails as NonDex shuffles order and tests whether the test passes or not.
Bean class:
https://github.com/bbelide2/crane4j/blob/679c3f860fb8c1d8e69c64cd7662e9047f7d99ed/crane4j-core/src/test/java/cn/crane4j/core/executor/handler/ReflectiveDisassembleOperationHandlerTest.java#L91-L91
We fetch the fields here:
https://github.com/bbelide2/crane4j/blob/679c3f860fb8c1d8e69c64cd7662e9047f7d99ed/crane4j-core/src/main/java/cn/crane4j/core/util/ReflectUtils.java#L471-L473
Fix
I updated the test to sort the operations before making the assertions so that the order of elements is always the same.
This fix will not affect the code since the change is only made in tests.
How this has been tested?
Java: openjdk version "<IP_ADDRESS>"
Maven: Apache Maven 3.6.3

Module build - Successful
Command used -

mvn install -pl crane4j-core -am -DskipTests

Regular test  - Successful
Command used -

mvn -pl crane4j-core test -Dtest=cn.crane4j.core.executor.handler.ReflectiveDisassembleOperationHandlerTest#process

NonDex test  - Failed
Command used -

mvn -pl crane4j-core edu.illinois:nondex-maven-plugin:2.1.1:nondex -DnondexRuns=10 -Dtest=cn.crane4j.core.executor.handler.ReflectiveDisassembleOperationHandlerTest#process

NonDex tests passed after the fix.

"operations" by "DisassembleOperation::getKey"

operations by DisassembleOperation::getKey
Code change looks ok to me and feel free to open a real PR.


submit and cancel buttons don't show show focus when in vscode terminal

in other terminals the submit and cancel button are underlined

this is also true for checkboxs and radio buttons in :sample_form

Using vscode's integrated terminal on macos none of the underlines show up, including the menu headings.
If the terminal font size is changed while vscode is running, the underlines do show up.


ERR: read_csv with dtype specified on empty data

File has this content:
A,A
3,3

When I do pd.read_csv(filepath) - all looks fine, however if I specify skiprows and dtype parameters it fails with the following error:
pd.read_csv(filepath, skiprows=1, dtype=str)

AttributeError: type object 'str' has no attribute 'items'

INSTALLED VERSIONS
commit: None
python: 2.7.10.final.0
python-bits: 64
OS: Linux
OS-release: 2.6.18-238.9.1.el5
machine: x86_64
processor: x86_64
byteorder: little
LC_ALL: None
LANG: en_US
pandas: 0.17.1

This is equivalent to this. So this doesn't have any data, so the dtype converter should handle this properly.
In [13]: read_csv(StringIO(data),header=0,skiprows=1)
Out[13]:
Empty DataFrame
Columns: [3, 3.1]
Index: []

In [14]: data
Out[14]: 'A,A\n3,3'

So an even simpler repro is this.
In [16]: read_csv(StringIO('A,B'),dtype=str)
AttributeError: type object 'str' has no attribute 'items'

care to do a pull-request to fix?

Prepared the fix locally but getting this error when trying to send pull-request:
'It seems you do not have permission to push your changes to this repository'.

see contributing docs here
you need to fork, then push to your branch and open a PR.
you are trying to push to master


Read Receipts for Microsoft Teams bot Conversation Events

Hello there,
I would like to ask whether I am able to obtain the read receipt of the user from the Conversation Events?

@ExplodingCow Currently bot does not receive a read receipt status when a message is read by user. Here is a list of all the events currently available for Bots. However, sending read receipts for bots is something we are working on but we do not have an ETA on when this would be available.


[Blerp] Add new extractor

Please follow the guide below

You will be asked some questions, please read them carefully and answer honestly
Put an x into all the boxes [ ] relevant to your pull request (like that [x])
Use Preview tab to see how your pull request will actually look like

Before submitting a pull request make sure you have:

[x] Searched the bugtracker for similar pull requests
[x] Read adding new extractor tutorial
[x] Read youtube-dl coding conventions and adjusted the code to meet them
[x] Covered the code with tests (note that PRs without tests will be REJECTED)
[x] Checked the code with flake8

In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:

[x] I am the original author of this code and I am willing to release it under Unlicense
[ ] I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

[ ] Bug fix
[ ] Improvement
[x] New extractor
[ ] New feature

Description of your pull request and other information
PR for Issue #31340
Adds a new extractor for Blerp. Uses Blerp's GraphQL API to query the file in the CDN required for download.

It would be nice for a myinstants extractor as well

Issues have been solved @dirkf


Can't use newer java.util.Map implementation with JavalinVue::stateFunction

I get this weird error as if I'm trying to set a null key:
JavalinVue.stateFunction = ctx -> Map.of(
    "currentMsisdn", ctx.sessionAttribute("currentMsisdn"),
    "verifiedMsisdn", ctx.sessionAttribute("verifiedMsisdn")
);

java.lang.NullPointerException
        at java.base/java.util.Objects.requireNonNull(Objects.java:222)
        at java.base/java.util.ImmutableCollections$MapN.<init>(ImmutableCollections.java:964)
        at java.base/java.util.Map.of(Map.java:1328)
        ...

That's odd. It doesn't really look to be related to JavalinVue though?
The state-function has the contract: (Context) -> Any , I'm guessing Map.of doesn't accept null-values ?

I'm guessing Map.of doesn't accept null-values?

Ah!  I see, and Context::sessionAttribute returns a nullable.  Hopefully the Kotlin team will add a @JvmOptional annotation to their list of interop tools 😄.  I'm closing the issue as the error is easily avoided by using the old Map, but maybe you can document the behavior so others can avoid this problem.
Thanks again for your quick reply.

I'm not trying to be difficult, but since it's a requirement for Java's factory method, how would you document it?

I think this issue itself might be enough documentation:  Anyone encountering this behavior in future will probably search this repository for the error message (just like I did before posting) and would then see this issue.

I'll add the info label then :)


Todo files not being deleted when no more violations exist

We're finding that when we:

have an existing package_todo.yml for a given pack
solve all of the violations such that no more exist for that pack
run pks update

the todo file is not being deleted as we would expect. Violations do disappear from the todo file in between runs of pks update as long as they are being addressed, but the file continues to exist even after all violations are gone.
We are specifically running with the options pks -e --no-cache update, if that makes a difference. This has been seen for both regular packs and the package_todo.yml in the root directory.

Whoops, spoke too soon; I was on a much older version of packs (0.1.48). Updating to the newest (0.1.65) fixed this issue!


iamp-nil-check

While running terraforming iamip  I ended up following error. This fix worked for me
$terraforming iamip
...//log
1: from (erb):1:in `each'
(erb):5:in `block in apply_template': undefined method `role_name' for nil:NilClass (NoMethodError)

Coverage remained the same at 100.0% when pulling e3a2495b4e36466054df1abc4d342835e1347ac1 on savankumargudaas:iamp-nil-check into c1d467becef5645e14ff822860f3fc2a9868c066 on dtan4:master.

I just ran into this issue as well. It would be nice to have this merged.


Monitor Slack

I am looking to monitor a slack channel with Huginn and send events. The Huginn is going to be behind the company firewall, so won't be able to receive events from Slack.  I think I am supposed to create a Website Agent and use the Slack Web API - Search.Messages and poll it every minute or so.
Am I going about this the right way, or am I missing a completely obvious alternative here.
Thank you.

I think I am supposed to create a Website Agent and use the Slack Web API - Search.Messages and poll it every minute or so.

That sounds like to right solution to me, if you can not receive their webhooks. You probably could write an Agent that connects to Slack as a bot and receives messages that way, but that's obviously a lot more work.

Thanks @dsander - I switched from Website Agent to Post Agent (I need to POST HTTP messages to the Slack Web API). I'll update this with a configuration once i get it working.

{
  "post_url": "https://slack.com/api/search.all?token={% credential YOUR_CREDENTIAL  %}",
  "expected_receive_period_in_days": "3",
  "content_type": "form",
  "method": "post",
  "payload": {
    "query": "fun"
  },
  "headers": {
    "Content-Type": "application/x-www-form-urlencoded"
  },
  "emit_events": "true",
  "no_merge": "false",
  "output_mode": "clean"
}

Is there an example of this kind of long lived bot agent? I see a use for
it but unsure that huginn has facilities to support a long lived agent.
On Fri, Dec 7, 2018 at 5:12 AM Dominik Sander<EMAIL_ADDRESS>wrote:

I think I am supposed to create a Website Agent and use the Slack Web API

Search.Messages https://api.slack.com/methods/search.messages and
poll it every minute or so.

That sounds like to right solution to me, if you can not receive their
webhooks. You probably could write an Agent that connects to Slack as a bot
and receives messages that way, but that's obviously a lot more work.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/huginn/huginn/issues/2433#issuecomment-445185635, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AACe8Mh8MWaIP3QTRa7j8VlcSxWRSz-8ks5u2j8ogaJpZM4ZHcKv
.

--
Shaun Farrugia
talks at<PHONE_NUMBER>
twitters at twitter.com/h0h0h0


Add jsdoc comments to Phaser.Keyboard key codes

As suggested by @drhayes on issue #2031 I have added the jsdoc comments to include key codes on Phaser documentation.
I don't know too much about jsdoc but I couldn't find an option to include those key codes on another section. I think the Phaser.Keyboard docs became a bit messy :) after adding those comments.

Unfortunately the keys are 'part' of the actual Keyboard type itself and not separate.
From a documentation point it may be better to create a pseudo-type and then link to it, explaining such. I thought there was already such a type setup, but I cannot find it, so I do not even know if this is currently feasible/recommended.

Yeah these all exist in the Phaser.KeyCode namespace now, so closing off the old PR, sorry.


Don't repeat set_url_path logic

Reference #3119
This approach simplifies the management command and delegates url path logic to the Page model.

Thanks! Merged in 9038da9fcd69f0b39121cc54a72f4a6ae6beb06a (with a minor fix - removed the .specific on child too).


Expose I2C interfaces via USB

From @mithro on June 24, 2014 5:57
Exposing the EDID information and other I2C busses via the USB could be useful for debug an experimentation.
One solution would be to emulate the i2c_tiny_usb device. A driver for this device already exist in the Linux kernel. See http://www.harbaum.org/till/i2c_tiny_usb/index.shtml for more information.
Copied from original issue: timvideos/HDMI2USB-jahanzeb-firmware#48

This issue was moved to timvideos/HDMI2USB-fx2-firmware#12


Channel closes automatically - multiple channels not supported

With no channels open. trying to open a channel to my clightning node results in the channel getting closed with the error multiple channels not supported.

This is an issue with c-lightning which does not currently support multiple channels (see https://github.com/ElementsProject/lightning/issues/1389)


Fixed SwingScheduler

The SwingScheduler.Worker had bugs and was non-conformant with the expected Worker behavior, which is now fixed:

Delayed actions were retained after the worker was unsubscribed.
The non-delayed schedule() call was reentrant and if used for recursive scheduling, a stackoverflow was possible.
Both delayed and non-delayed actions were added to the tracking composite after they had the chance to run, causing leak of executed tasks.

The new implementation uses a trampoline queue and a fast-path capable drain logic so the EventQueue is not taxed on recursive scheduling.

Thanks @akarnokd. Maybe we moved too fast on those recent SwingScheduler changes that I made. I might ping you for a review before any future changes, if that's ok.

Sure.


Incorrect real Cartesian spherical harmonics formula

On this webpage (https://e3x.readthedocs.io/stable/_autosummary/e3x.so3.irreps.spherical_harmonics.html), the definition of pi has a $r^{2k - l}$ term. However, in the code (https://github.com/google-research/e3x/blob/main/e3x/so3/_symbolic.py#L65), we are only multiplying by $r^{2k}$ we are not subtracting by l.

Thank you for pointing out this typo in the documentation (the code is correct)! This will be fixed in the next version.


Schema sync improvement (hashtag1389)

hashtag What is currently missing?
When a schema is deleted from cluster manually, and if it exists in klaw, it is not possible currently to remove from klaw
hashtag How could this be improved?
It should be possible to remove from klaw, if schema is not in Schema registry
hashtag Is this a feature you would work on yourself?

[ ] I plan to open a pull request for this feature

This was addressed in hashtag1393


How do I have to configure it to have autocomplete?

I am not sure, what I am doing wrong. I would like there to be autocomplete for the strings I use like
t("common:...") This does not work for me. Do I have to do some specific configuration?

I'm going to assume you're using i18next and not react-intl, but according to these docs you can do something this:
import "i18next";
import ns1 from "locales/en/ns1.json";
import ns2 from "locales/en/ns2.json";

declare module "i18next" {
  interface CustomTypeOptions {
    defaultNS: "ns1";
    resources: {
      ns1: typeof ns1;
      ns2: typeof ns2;
    };
  }
}

Hey @i18nexus thanks for your help. This works for me, but only if I specify the default namespace and then also only for the default namespace. I was expecting e.g. ns2 to work like: t("ns2:someKey")

Alternatively, if you use the same default namespace throughout your app, you could prepend "namespace:" to every key in your non-default namespaces.

@enisze Oh, yeah I guess using "ns2:somekey" wouldn't work. One thing you can do is pass a namespace into useTranslation. For example:
const t = useTranslation("ns2");
...
t("someKey")

Passing the namespace to useTranslation will make t use it as the default namespace.

This does not work for me. It types it, but still uses the default namespace to find the translation. :/

Alternatively, if you use the same default namespace throughout your app, you could prepend "namespace:" to every key in your non-default namespaces in the typescript interface.

What do you mean by that? Is it not possible to somehow achieve it to have somehow properly typed?
My init looks like this:
import i18nConfig from "i18nConfig";
import { createInstance, type Resource, type i18n } from "i18next";
import resourcesToBackend from "i18next-resources-to-backend";
import { initReactI18next } from "react-i18next/initReactI18next";

const namespaces = ["common", "forms", "success", "errors", "tours"];

export default async function initTranslations({
	locale,
	i18nInstance: instance,
	resources,
}: {
	locale: string;
	i18nInstance?: i18n;
	resources?: Resource;
}) {
	const i18nInstance = instance ?? createInstance();

	i18nInstance.use(initReactI18next);

	if (!resources) {
		i18nInstance.use(
			resourcesToBackend(
				(language: string, namespace: string) =>
					import(`./${language}/${namespace}.json`),
			),
		);
	}

	await i18nInstance.init({
		lng: locale,
		resources,
		fallbackLng: i18nConfig.defaultLocale,
		supportedLngs: i18nConfig.locales,
		defaultNS: namespaces[0],
		fallbackNS: namespaces[0],
		ns: namespaces,
		preload: resources ? [] : i18nConfig.locales,
	});

	return {
		i18n: i18nInstance,
		resources: i18nInstance.services.resourceStore.data,
		t: i18nInstance.t,
	};
}

I've gone ahead and tested it out and everything seems to work for me. I've tested this with our example project.
i18next.d.ts (placed at root of the project):
import home from<EMAIL_ADDRESS>import about from<EMAIL_ADDRESS>
declare module 'i18next' {
  // eslint-disable-next-line no-unused-vars
  interface CustomTypeOptions {
    defaultNS: 'home';
    resources: {
      home: typeof home;
      about: typeof about;
    };
  }
}

Using t("header") passes in both server and client components.
Using `t("about:about_header") passes in bother server and client components.
Using any key that doesn't exists does not pass.
I didn't have to change any other files in the project.
If this doesn't work for you, can you please show me your locales directory structure, your declaration of CustomTypeOptions, and your i18nConfig?

I just checked the example out too and used your i18n.d.ts:
import home from<EMAIL_ADDRESS>import about from<EMAIL_ADDRESS>
declare module 'i18next' {
  // eslint-disable-next-line no-unused-vars
  interface CustomTypeOptions {
    defaultNS: 'home';
    resources: {
      home: typeof home;
      about: typeof about;
    };
  }
}

I did try in the ExampleClientComponent. It does not work for me:

On the serverside on the about page it works:

Same behaviour which I currently have in my project.

Ah, I'm sorry you're right. I can reproduce the exact same thing. One thing I have found that works is passing the namespaces into useTranslation like so:

But obviously this isn't ideal. We'll continue taking a look at it!

Ah alright, would use this workaround :) Thank you. Would prefer though to use the default namespace without prefix also.
Appreciate your help :)

Would prefer though to use the default namespace without prefix also

Can you explain what you mean by this?

This seems to work as well:

I think the declaration is working for the 'i18next instance. So i18n.t has definitions, but t does not. I'll have to look more at why these functions respond to the declaration differently.

Would prefer though to use the default namespace without prefix also

Can you explain what you mean by this?

Sure I was hoping for home (because its the default namespace):

To have suggestions without the prefix

This seems to work as well:

I think the declaration is working for the 'i18next instance. So `i18n.t` has definitions, but `t` does not. I'll have to look more at why these functions respond to the declaration differently.

yes it works for me like this. But as mentioned above the Default namespace is still there with a prefix, but that would be fine for me I wouldn't mind to also use the prefix always for my default NS as well.

I just noticed the same issue for the  component regarding the type of the i18nKey. It only includes the default NS.

Yeah, including the namespace in the key for the default namespace seems to be be valid in i18next, so the TypeScript just reflects that.

Are there any news on the  component? The keys don't work there... Is there a workaround for these components?

Using const { i18n: { t } } = useTranslation() seems to be the best method we can find. Does this not work for you?

This works,
but I am alking about the Trans component
						<Trans
							i18nKey='about:back'
/>

Gives me ts errors.

This seems to work. But the weird part is that "about" doesn't show in the autocomplete for ns. But TypeScript accepts "about" as a valid value regardless. Still looking into this.

Here is actually a better solution to make autocomplete work:

Just to clear up where this overall issue stands:
For useTranslation, the react-i18next docs say to include the namespaces as an argument of useTranslation in order for the Typescript to work properly with multiple namespaces. You can see that this is how they do it in their example here:
https://github.com/i18next/react-i18next/tree/master/example/react-typescript/simple-multi-namespaces/src
So it seems that this is how they designed it to work. Personally, I would use the const { i18n: { t } } = useTranslation() method instead since it's cleaner.
We've left this issue open to ensure that our implementation in our i18next example is not at fault here. Given that the i18next official example says to put the namespaces as an argument to useTranslation, it sounds like there is not an issue with our example.
We're going to close this issue now. But happy to continue helping out in this thread if you need more support.

hi sir, can you give a multi namespace demo? the i18next-sample use multiple namespace not working.


Web - Connect Bank Account - When disconnecting the bank account - it directed to Plaid option instead of Connect bank account page

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Go to staging.new.expensify.com
Log in with any account
Go Setting - Workspace - Connect Bank Account
Use Plaid option
5 Select "Fidelity" bank option
Use all information to connect bank account
Tap Disconnect button
Select Delete

Expected Result:
When disconnecting the bank account - it directed to Connect bank account page
Actual Result:
When disconnecting the bank account - it directed to Plaid option instead of Connect bank account page
Workaround:
Unknown
Platform:

Where is this issue occurring?

Web
iOS
Android
Desktop App
Mobile Web

Version Number: <IP_ADDRESS>
Reproducible in staging?: Yes
Reproducible in production?: Yes
Email or phone of affected tester (no customers): any
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
https://user-images.githubusercontent.com/93399543/191062148-b0fdcb72-aaa7-4fd4-a0ca-d3fd7c7fac11.mp4
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
View all open jobs on GitHub

I was able to reproduce this. Working on figuring out what causes this.

Issue not reproducible during KI retests. (First week)

Will test this again today.

@youssef-lr - Just checking in on this, what are the next steps here to help move this forward? Are you at the testing phase still? Or is this something that can be closed because we can't reproduce?

I could not reproduce this one again. Will close this out.


[IDEA PROPOSAL] Using blender to output a 2D file + 3D metadata of each pixel

Hi, I'm not a developer, but I wonder if it could be possible to use blender, to generate using their render and camera system, not a .png file, but a 2D texture + metadata on each pixel, basically each pixel having information about the depth and stuff like what object in the 3D scene, belongs.
And then use said metadata + color information of each pixel as aditional input for a difussion model.

yes, and I think this is actually a good idea. you can generate any 3D information the same way you would in fragment shaders (face normals, camera distance, luminance etc.) and store them in alpha channels. you can use multiple alpha channels to train control net, look here https://github.com/lllyasviel/ControlNet/issues/10 .
(I think this issue is a better fit for discussion section)


PR for #23: Add matlab and lyx run scripts and examples

Closes #23.
Changes and deliverables:
In issue #23, created the new run_matlab.sh and run_lyx.sh commands, along with example files. For details about the changes, see https://github.com/gentzkow/GentzkowLabTemplate/issues/23#issuecomment-2375430620. A second step will be to write README files for these examples. This will be done in a separate issue as we also need to update the Wiki and create or change several other README files following all modifications to the template in #16.
Review
Other than reviewing the changes and testing the overall logic of the new commands and examples, it'd be great to test the robustness for errors in the spirit of #19. It'd also be good to check these examples against the others (latex for lyx, and Stata, R, and Python for MATLAB), as they should be consistent and generate roughly the same output.
I am requesting a review from @ShiqiYang2022. Please let me know if you have any questions. Thanks!

Thanks @ShiqiYang2022 , great points and I agree with your changes. In 3346cea I just reverted one local change in local_env_template.sh that I think was pushed by mistake. While testing you changes, I also noticed a problem in the run_xxx scripts that was not printing the created files correctly so I added a minor fix in 4a6eef4. As this changes all run_xxx files, it'd be great if you could please take a look before I squash and merge. Thanks again!


About course number

CS410 is the course number of Artificial Intelligence, while CS420 is the course number of Machine Learning. Obviously, the project submitted by @skyzh is for Artificial Intelligence.

I believe the course name is wrong instead of the course number. I've proposed a fix.


findPath returns a number

Hello, I have this code
`function checkPath() {
console.log(typeof path)
if(path[1] === undefined) console.log("Null")
else {
console.log("Exists")
powerValue = 1;
}
}
path = electrical_pathfind.findPath(coordX, coordY, powerSourceIndex[0][0], powerSourceIndex[0][1], checkPath);
electrical_pathfind.calculate();`
Notice the typeof path line. This reads "Number." Sure enough, when I log "path," an integer value is logged - NOT an array.
What causes findPath to return a number rather then... well... a path? I have another completely separate pathfind system elsewhere in my code that works flawlessly - it returns an actual path!

Hello there. Thanks for opening an issue. You might be interested in reading the documentation. I think it should answer your question.

I've read the documentation, and the issue clearly isn't addressed. Please point me to where I can find a solution to this issue.


With latest robot framework 4.1 there is increase in execution time where for loop is in place

Execution time of around 135 test cases increased drastically by 4 times . On further debugging , we found out that wherever For loop is used, execution time has increased.
KW Execution time in RF 4.1

KW Execution time old RF version

I did some simple tests with for loops and didn't notice any real performance difference between RF 4.1, 4.0.4 and 3.2.2. Could you please create a simple example demonstrating the performance degradation? Something simple that I can easily run locally without installing any external library. Could you also tell what exact RF version you mean with "old RF version"?

Hi pekka,
I run below script . latest 4.1 release takes twice  more time  then robot framework 3.0
4.1
Time Taken : 39 Seconds

*** Settings ***
*** Variables ***
*** Test Cases ***
running same test case with multiple time
    [Documentation]   Performance Check
    print the name

*** Keywords ***
print the name
    log  'this will run multiple times with for loop'
    FOR  ${I}  IN RANGE  0  10000
        log to console  ${I}
        ${status}  Run Keyword And Return Status  should be equal as strings  ${I}  9999
    END

3.0.0
Time Taken : 20 Seconds
*** Settings ***
*** Variables ***
*** Test Cases ***
running same test case with multiple time
    [Documentation]   This test case will run multiple times without using any loop or template
    print the name

*** Keywords ***
print the name
    log  'this tc will run multiple times without for loop'
    :FOR  ${I}  IN RANGE  0  10000
    \   log to console  ${I}
	\   ${status}  Run Keyword And Return Status  should be equal as strings  ${I}  9999

Hope that helps.

I tested a variation of the above example locally and was able to reproduce performance getting worse. These are average times I got with different versions:
RF 3.0: 6.0 s
RF 3.1: 6.4 s
RF 3.2: 6.8 s
RF 4.0: 7.3 s
RF 4.1: 8.1 s
Somewhat steady decline and surprisingly big drop between RF 4.0 and 4.1. This last drop is especially strange because RF 4.1 was a pretty small release and I don't remember FOR loops being touched much. Could be that there has been some small slow down with keyword execution in general. This example runs tens of thousands of keywords and thus even a small change can cause this kind of difference.
I'll investigate this a bit further by running the example in a profiler. If there's something simple that can be done, I'll do that in RF 4.1.1. If not, possible changes need to wait for later releases.
Notice that if you want better performance, you should try moving the logic from RF side to Python. It can run for loops much faster and your output.xml and log.html sizes won't be so big either.

Profiling didn't reveal anything that would have been easy to fix. I also looked at changes between RF 4.0 and 4.1 and changes related to execution were mostly limited to checking should execution continue after a failure (#2285). I changed the example so that instead of using
${status} =    Run Keyword And Return Status    should be equal as strings    ${I}    9999

it uses
${status} =    Run Keyword And Return Status    Log    ${I}

where the main difference is that there's no failure. Sure enough that dropped the execution time considerably. After that I rerun the test with different versions:
RF 3.0: 4.2 s
RF 3.1: 4.4 s
RF 4.0: 5.2 s
RF 4.1: 5.1 s
There's still a clear difference between RF 3.0 and 4.1 but it's quite a bit smaller than earlier. More importantly, there's no performance drop after RF 4.0, in fact RF 4.1 is a tiny bit faster.
Due to the biggest problem occurring if there are lot of failures (9999 in the original case), I don't think this issue has high priority. Should definitely look at performance again once we start RF 5.0 development and can do bigger changes. That's especially important after we've drop Python 2 support and can remove lot of code that's not needed anymore.

I don't consider handling failures in RF 4 series being a bit slower than in RF 3 series a big enough problem to keep this issue open. We anyway have #3950 about performance issues. Notice also that memory usage enhancements in RF 4.1.2 may affect performance positively as well.

Definitely there is performance issue overall in 4.1.2 , for which we have a ticket #3950,attaching the screen shot for FOR loop issue here , you can notice the time of each iteration doesnt adds up to overall 32mins , my question is what is the hidden executions that take some time.?


Submodule discussion

In particular rpi_281x and rgbw support.
From memory we are now tracking the latest commit at jgarff.
Should we keep doing this ?
Should we peg it to the current commit ?
Do we reference my fork until my rgbw support gets merged ?
I think I'm ready to submit a PR to jgarff to get this done

Not sure how many plans you have to extend these dependencies
If jgarff is not fast enough in merging it may be good to fork it?

I don't want to maintain my own fork unless we have no choice

then we leave it as is. :)

Maybe I should make a tag on the branch of my fork and track it for now.
I actually have some sk6812rgbw and would like it integrates properly

We will see which source we (you) need in future. Depending on this we could switch.

It looks like it will be merged into the main code base in the medium term

https://github.com/jgarff/rpi_ws281x/issues/89


Support VPC attributes

Is your feature request related to a problem?
I need DnsSupport and DnsHostnames on the EC2 VPC resource, to create nodegroups for an EKS cluster. These are supported through the ModifyVpcAttribute API, which is not included in the custom hook code for EC2 currently.
Describe the solution you'd like
New fields for each of the attributes in the root of the VPC resource, similar to the CloudFormation resource. Maybe something like:
spec:
  enableDNSSupport: true
  enableDNSHostnames: true

Added in https://github.com/aws-controllers-k8s/ec2-controller/pull/38


[Question] Proactive messages

Hi, is there a way of sending proactive messages within this project to the twitter users?

Yes, it works out of the box. If you follow the example in the documentation, sending proactive messages is independent of the channel, you just need a reference to the BotAdapter.
https://docs.microsoft.com/en-us/azure/bot-service/bot-builder-howto-proactive-message?view=azure-bot-service-4.0&tabs=csharp
That said, the Twitter adapter should work without modifications.

@tmarkovski Ok, I will try it, thank you!


[Bug] [Trivial] When copying a task, the create time will also be copied

Search before asking

[X] I had searched in the issues and found no similar issues.

What happened
当复制任务的时候，新复制出来的任务使用的创建时间、更新时间还是被复制任务的，包括创建人、更新人也是没有重置

What you expected to happen
复制任务应该只是复制任务内部的逻辑、任务配置等，不应该把创建人、创建时间这些也复制过来
How to reproduce
使用复制功能即可重现问题

Anything else
No response
Version
dev
Are you willing to submit PR?

[X] Yes I am willing to submit a PR!

Code of Conduct

[X] I agree to follow this project's Code of Conduct

来优化一下？？

来优化一下？？

ok


traffic from IPv4Addres and IPv4VXLANTunnelAddr

Trying calico as an alternative to weave I've bumped into some odd behavior regarding the addresses used.
The current setup is a normal EKS cluster with an ALB pointing to traefik as an ingress controller running an echo server to see the requests.
Running the latest tigera operator (3.25.0) with
installation:
  kubernetesProvider: "EKS"
  registry: quay.io
  cni:
    type: Calico
    ipam:
      type: Calico
  calicoNetwork:
    bgp: Disabled

Single node pool
ip-10-138-10-90.eu-west-2.compute.internal
                    projectcalico.org/IPv4Address: <IP_ADDRESS>/24
                    projectcalico.org/IPv4VXLANTunnelAddr: <IP_ADDRESS>
ip-10-138-11-11.eu-west-2.compute.internal
                    projectcalico.org/IPv4Address: <IP_ADDRESS>/24
                    projectcalico.org/IPv4VXLANTunnelAddr: <IP_ADDRESS>
ip-10-138-11-187.eu-west-2.compute.internal
                    projectcalico.org/IPv4Address: <IP_ADDRESS>/24
                    projectcalico.org/IPv4VXLANTunnelAddr: <IP_ADDRESS>
ip-10-138-12-108.eu-west-2.compute.internal
                    projectcalico.org/IPv4Address: <IP_ADDRESS>/24
                    projectcalico.org/IPv4VXLANTunnelAddr: <IP_ADDRESS>

traefik pods IP addresses and node information
kube-system        traefik-public-cd85d884f-2kr6q  <IP_ADDRESS>    ip-10-138-11-11.eu-west-2.compute.internal
kube-system        traefik-public-cd85d884f-7t6k6  <IP_ADDRESS>   ip-10-138-10-90.eu-west-2.compute.internal
kube-system        traefik-public-cd85d884f-hbt9t  <IP_ADDRESS>     ip-10-138-12-108.eu-west-2.compute.internal

running requests to the echoserver
while true; do curl -s https://echoserver | grep ^X-Real-Ip  && sleep 1; done
X-Real-Ip=<IP_ADDRESS>
X-Real-Ip=<IP_ADDRESS>
X-Real-Ip=<IP_ADDRESS>
X-Real-Ip=<IP_ADDRESS>
X-Real-Ip=<IP_ADDRESS>
X-Real-Ip=<IP_ADDRESS>
X-Real-Ip=<IP_ADDRESS>
X-Real-Ip=<IP_ADDRESS>
X-Real-Ip=<IP_ADDRESS>
X-Real-Ip=<IP_ADDRESS>
X-Real-Ip=<IP_ADDRESS>
X-Real-Ip=<IP_ADDRESS>
X-Real-Ip=<IP_ADDRESS>
X-Real-Ip=<IP_ADDRESS>
X-Real-Ip=<IP_ADDRESS>
X-Real-Ip=<IP_ADDRESS>
X-Real-Ip=<IP_ADDRESS>
X-Real-Ip=<IP_ADDRESS>
X-Real-Ip=<IP_ADDRESS>
X-Real-Ip=<IP_ADDRESS>
X-Real-Ip=<IP_ADDRESS>
X-Real-Ip=<IP_ADDRESS>
X-Real-Ip=<IP_ADDRESS>
X-Real-Ip=<IP_ADDRESS>
X-Real-Ip=<IP_ADDRESS>
X-Real-Ip=<IP_ADDRESS>
X-Real-Ip=<IP_ADDRESS>
X-Real-Ip=<IP_ADDRESS>
X-Real-Ip=<IP_ADDRESS>
X-Real-Ip=<IP_ADDRESS>
X-Real-Ip=<IP_ADDRESS>
X-Real-Ip=<IP_ADDRESS>
X-Real-Ip=<IP_ADDRESS>
X-Real-Ip=<IP_ADDRESS>
X-Real-Ip=<IP_ADDRESS>
X-Real-Ip=<IP_ADDRESS>
X-Real-Ip=<IP_ADDRESS>
X-Real-Ip=<IP_ADDRESS>

Sometimes a node can reply using the host or the vxlan address.
X-Real-Ip=<IP_ADDRESS>
X-Real-Ip=<IP_ADDRESS>
Expected Behavior
Not sure if this is expected but I would assume we should only see from one source
Your Environment

Calico version: 3.25.0
Orchestrator version (e.g. kubernetes, mesos, rkt): EKS Kubernetes 1.22
Operating System and version: AL2 amazon-eks-node-1.22-v20230105
Link to your project (optional):

@pfragoso out of curiosity, how is the echoserver deployed? I just want to make sure there isn't anything strange there, but I think that if the echoserver is pod networked, then only the VXLAN addresses should be shown. @fasaxc you might know better, but does that sound right to you?

It's a normal k8s deployment + ingress (without hostNetwork or etc).
Here's the current spec applied:
apiVersion: apps/v1
kind: Deployment
metadata:
  annotations:
  name: echoserver
  namespace: echoserver
spec:
  progressDeadlineSeconds: 600
  replicas: 1
  revisionHistoryLimit: 10
  selector:
    matchLabels:
      app: echoserver
  strategy:
    rollingUpdate:
      maxSurge: 25%
      maxUnavailable: 25%
    type: RollingUpdate
  template:
    metadata:
      creationTimestamp: null
      labels:
        app: echoserver
    spec:
      containers:
      - image: gcr.io/kubernetes-e2e-test-images/echoserver:2.2
        imagePullPolicy: Always
        name: echoserver
        ports:
        - containerPort: 8080
          protocol: TCP
        resources: {}
        terminationMessagePath: /dev/termination-log
        terminationMessagePolicy: File
      dnsPolicy: ClusterFirst
      restartPolicy: Always
      schedulerName: default-scheduler
      securityContext: {}
      terminationGracePeriodSeconds: 30

Hm, interesting.
I don't think that the connection would succeed if the destination we responding with an IP address that didn't match the original conntrack entry on the host.
I wonder if it has to do with how the X-Real-IP header is populated by the server. Could you repeat the experiment and use tcpdump on the client node to see what the actual IP address reported on the packet is?

What does the X-Real-IP header tell you?  Is it the source IP address that the backing pod (or Traefik) saw?   If so then that will depend on how the load balancing happened to get routed.  If traffic goes
External -> Node A -> pod on node A

Then the pod will see the external IP.
If it goes
External -> Node A -> pod on node B

then there's an extra SNAT (done by kube-proxy).
Adding Traefik into the mix may change things again since there's another layer.


Fix miscellaneous ci issues

Requirements for Contributing a Bug Fix (from template)

Fill out the template below. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
The pull request must only fix an existing bug. To contribute other changes, you must use a different template. You can see all templates at https://github.com/atom/.github/tree/master/.github/PULL_REQUEST_TEMPLATE.
The pull request must update the test suite to demonstrate the changed functionality. For guidance, please see https://flight-manual.atom.io/hacking-atom/sections/writing-specs/.
After you create the pull request, all status checks must be pass before a maintainer reviews your contribution. For more details, please see https://github.com/atom/.github/tree/master/CONTRIBUTING.md#pull-requests.

Identify the Bug
Fixes most of https://github.com/atom-ide-community/atom/issues/70

Description of the Change
Update Windows job names.

Windows --> Windows_build makes it more obvious this job simply builds Windows, nothing more.

Windows_RendererTests now depend on Windows_build, not Windows.
Release now depends on Windows_RendererTests, not Windows.

Delete an unnecessary step of preparation on Windows

There is no reason to cd into script/vsts and do npm install during preparation. Those dependencies are only used during GetReleaseVersion, Release and Upload Artifacts jobs, and those jobs already install the dependencies. Installing them during preparation is totally arbitrary and not useful. Deleting the step should save 45 seconds or so in CI, and preparation is run multiple times in Windows Ci, so the time saved is roughly doubled, or even tripled/quadrupled+ if we ever have to "Re-run Failed Jobs" some number of times.

Delete a comment about containers in Linux preparation

We don't run the Linux build in an Ubuntu 14.04 "Trusty Tahr" Docker container anymore like upstream does. We run directly in a virtualized Ubuntu 16.04 "Xenial Xerus" image for now.

Alternate Designs
Not fix these (admittedly minor) issues?

Possible Drawbacks
None that I know of. Watch to make sure that deleting cd script/vsts && npm install on Windows doesn't somehow cause problems.
Watch to make sure I didn't typo the job names under Windows.

Verification Process
CI should pass. Reviewing the diff should confirm there are no typos in the PR.

Release Notes

N/A

@aminya I can move the REPO_OWNER, MAIN_REPO and NIGHTLY_RELEASE_REPO var handling changes to another pull request if you prefer.

Thank you! will check this later today.

I will take your feedback into consideration and try to decide what to do. Some things are subjective, like job names, but still, good decisions make the CI nicer to use and work with.
Strongly considering moving the "no install script/vsts/node_modules on Windows 64-bit stuff out into another PR. I'm very close to getting that done, but part ofmit still needs work (uploading crash reports), it's somewhat experimental, and the rest of the PR is lower risk. Might be good to separate the concerns here.
That said, future me may have a different opinion on this... Just laying out my thoughts while I have nough time to think about this but nt act on it just yet.

This needs a closer look on the Windows x86 stuff. Last I recall I was going to push that out to a separate PR. I also noticed the "script step inexplicably exits after npm ci" comment is no longer true, so we can delete the comment and combine two adjacent script tasks in a few places. I can leave that for another PR if you don't want it here.
There might be a couple other things I notice here and there that can be tidied up.

I prefer that you revert skipping install windows build deps on x64 and take them to another PR.

Working on it.

So I don't lose them, the Windows x86 related commits I dropped from this PR are:

https://github.com/atom-ide-community/atom/pull/78/commits/9e8fd3c97e17c67dac46ca885d71ee617c627928
https://github.com/atom-ide-community/atom/pull/78/commits/118c0d5dfd8907349dc5c78d567e3e5e27e72486
https://github.com/atom-ide-community/atom/pull/78/commits/6235a142b6d20b21d98f0fd4fe4e4d83f02e2c7b

Getting rid of ALL_CAPS BUILD_ARCH in favor of buildArch would be amazing, but I'm going to consider that a to-do for outside of this PR also.

I'd also like to get rid of the explicit Python 3 install in Windows (because it wastes time), instead relying on the already-installed Python versions.
We pinned npm to an older version that can't use Python 3 anyhow, during the Electron 6 PR. 😢 Not a big deal though.

I'd also like to get rid of the explicit Python 3 install in Windows (because it wastes time), instead relying on the already-installed Python versions.

This should be a separate PR. Please keep this just a bug fix.

I added some stuff last minute here, they are the latest commits. Let me know if you want any of them dropped from here and I'll move them somewhere else. Maybe a second "clean up the CI" PR.

Force pushed to update the first commit, where I had missed the Release job dependsOn: windows (should be dependsOn: windows_build now).

That's why I said keep the names as before. Now you need to change dependsOn: Windows everywhere.

I fixed it. All of them are properly updated.
Here's a commit (which I haven't added to this PR) that I mocked up to make the Windows yml more similar to the macOS one. If you like it I'll push it here, but I left it out for now.
https://github.com/DeeDeeG/atom/commit/0ba2f4ae00f2deb822816e9a283075009af082cc
I like that it's consistent, so you don't have to memorize two different sets of naming conventions and ordering of the yaml. Reading one shows you mostly how the other one is set up.

Upstreamable commits:

cfd4a0b2c should be merged to https://github.com/atom/atom/pull/21147
I will do the Windows job name changes manually for https://github.com/atom/atom/pull/21109
We have not made a pull request regarding REPO Name stuff. So a separate pull request should be made for that. But I think it is better to make that once https://github.com/atom/atom/pull/21109 is merged to prevent conflicts

https://github.com/atom-ide-community/atom/commit/cfd4a0b2ce0977acc493517a841aa55f2ebb77a1 does make GetReleaseVersion fail to print the version it finds sometimes. That must be what the old error message was about.
I have only seen this on the Pull Requests pipeline, where GetReleaseVersion is not important. And I have a suspicion that the script may actually be running and its output just isn't being displayed, as an Azure DevOps bug.
In any case, I have seen no issues in those cases where we can't see any output of GetReleaseVersion. Let's look at that carefully before we submit it to upstream. If there are problems, we may need to revert.
I never saw it skip outputting a version on several runs of the Nightly Release pipeline, nor during the Release Branch Build pipeline. Still something to look out for in case it does happen and I just didn't do it enough times to reproduce it yet.

There's more to do on the REPO vars, so I'd like a chance to do that and we can submit it all in one go?
I opened #83 for this. I don't think it's hard; predominantly just sifting through the code for hard-coded strings and replacing them with the right const assigned value.


How to save weights to a file

Is there a way to save weights to a file and reload them later? For instance, in the car example there is ui.cpp which lets the user control the car, and car.cpp appears to train it. I am assuming maybe car_track.cpp is supposed to use the weights? Currently it just appears to perform observations unless rlt::set_action(device, env, ui, action); is doing something extra?

Hi Jonas,
I also want to make a request for continuing the training (having access to.the step() method after loading). My environment is not the fastest and might be interrupted. It would be sufficient for me I guess, to just replace the weights of the compiled model.
Best

bumping for resume training feature

Hi @user-1701
can you elaborate a bit on your use-case? Is it just about pausing and continuing under identical conditions? Because with changes e.g. to the model architecture, replay buffer size etc. the checkpoint might not be compatible.
If it is just about pausing and continuing under identical conditions, in theory it shouldn't be too hard. I hope I will find some time to implement it soon but if you want to give it a shot in the meantime, it would be about saving all the members of the Loop state (e.g. https://github.com/rl-tools/rl-tools/blob/2f955cbd54eb5b2a13325e1fd615ef9782a74de2/include/rl_tools/rl/algorithms/td3/loop/core/state.h) recursively. Just loading the actor and critic parameters is not enough, you would need to load all the state including the optimizer, replay buffer etc. to exactly continue the training as if nothing happened.
I would suggest using save (for hdf5) because it is already implemented for most of the types but you might want to have an additional e.g. json to save scalar variables like the current step or the optimizer's current step.

Well actually 'completely' resuming is not required, just loading the hdf5 again^^ or maybe this should work already and I failed somewhere
I have never encountered any effect of reloading the optimizer state.
The replay buffer is also not required I guess, there is only the 'rl with resets' paper in which I could image it to be useful. Or to collect samples for offline rl, but collecting can always be done efficiently.
Resuming training with a different architecture is surely not required (and I have never seen that.) Only if I a policy that I trained somewhere else, 'I would then still assume the same-sized MLP' and would 'only' want to copy or update the weights 1:1.


"Select primer" should update when selected

Currently, primer is selected under the hood, but modal does not update to show "Set 1" etc.

Looks like this is already fixed. It just seemed broken because the user has to upload the barcodes files before selecting the primer set. The part that still isn't great (but is minor imo) is that when you upload the 2nd or 3rd barcodes file, it resets all the primer set selections. But it is possible for the user to use this without this fix, so I'm going to create a new "nice to have" issue, not required for certifiable V1.


Documentation typo

As Kernel dependencies
rpfilter occurs multiple times in the describe of match criteria.

rpfilter isn't a typo - https://manpages.debian.org/jessie/iptables/iptables-extensions.8.en.html#rpfilter

According to

At least the following match criteria: set, rpfilter, addrtype, comment, conntrack, icmp, tcp, udp, ipvs, icmpv6 (if IPv6 is enabled in your kernel), mark, multiport, rpfilter, sctp, ipvs (if using kube-proxy in IPVS mode).

The word rpfilter occurs multiple times in this sentence.


Patch 13

@rotycenh

@rotycenh  I'm not sure what happened, but I don't think you want to merge this one.

:warning: Validation status: warnings

File
Status
Preview URL
Details

docs/cloud-adoption/business-strategy/business-outcomes/how-to-use-the-business-outcome-template.md
:warning:Warning
View
Details

docs/cloud-adoption/business-strategy/business-outcomes/overview.md
:warning:Warning
View
Details

docs/cloud-adoption/business-strategy/overview.md
:warning:Warning
View
Details

docs/cloud-adoption/digital-estate/calculate.md
:warning:Warning
View
Details

docs/cloud-adoption/governance/cost-management/overview.md
:warning:Warning
View
Details

docs/cloud-adoption/governance/how-can-a-ciso-prepare-for-the-cloud.md
:warning:Warning
View
Details

docs/cloud-adoption/governance/resource-management/governance-multiple-teams.md
:warning:Warning
View
Details

docs/cloud-adoption/governance/resource-management/governance-single-team.md
:warning:Warning
View
Details

docs/cloud-adoption/governance/resource-management/overview.md
:warning:Warning
View
Details

docs/cloud-adoption/governance/security-management/overview.md
:warning:Warning
View
Details

docs/cloud-adoption/migration/execute/assess.md
:warning:Warning
View
Details

docs/cloud-adoption/migration/execute/iteration-release-backlog.md
:warning:Warning
View
Details

docs/cloud-adoption/migration/execute/overview.md
:warning:Warning
View
Details

docs/cloud-adoption/migration/execute/partnership-options.md
:warning:Warning
View
Details

docs/cloud-adoption/migration/operate/optimize.md
:warning:Warning
View
Details

docs/cloud-adoption/migration/plan/first-workload.md
:warning:Warning
View
Details

docs/cloud-adoption/migration/plan/infrastructure-assessment-tools.md
:warning:Warning
View
Details

docs/cloud-adoption/migration/plan/iterative-change-management.md
:warning:Warning
View
Details

docs/cloud-adoption/migration/plan/migration-backlog.md
:warning:Warning
View
Details

docs/cloud-adoption/overview.md
:warning:Warning
View
Details

docs/cloud-adoption/technical-standards/overview.md
:warning:Warning
View
Details

docs/cloud-adoption/transformation-journeys/disruptive-transformation.md
:warning:Warning
View
Details

docs/cloud-adoption/transformation-journeys/operational-transformation/build.md
:warning:Warning
View
Details

docs/cloud-adoption/transformation-journeys/operational-transformation/govern.md
:warning:Warning
View
Details

docs/cloud-adoption/transformation-journeys/operational-transformation/manage.md
:warning:Warning
View
Details

docs/cloud-adoption/transformation-journeys/operational-transformation/migrate.md
:warning:Warning
View
Details

docs/cloud-adoption/transformation-journeys/operational-transformation/plan.md
:warning:Warning
View
Details

docs/cloud-adoption/transformation-journeys/overview.md
:warning:Warning
View
Details

building-blocks/extending-templates/toc.json
:warning:Warning

Details

toc.json
:warning:Warning

Details

bread/toc.json
:warning:Warning

Details

docs/_bread/toc.yml
:white_check_mark:Succeeded

docs/cloud-adoption/_images/GRC-Triangle.png
:white_check_mark:Succeeded
View

docs/cloud-adoption/_images/asr-replication-image.png
:white_check_mark:Succeeded
View

docs/cloud-adoption/_images/business-outcome-focus-areas.png
:white_check_mark:Succeeded
View

docs/cloud-adoption/_images/business-outcome-house.png
:white_check_mark:Succeeded
View

docs/cloud-adoption/_images/business-outcome-template.png
:white_check_mark:Succeeded
View

docs/cloud-adoption/_images/discovery-guide-sdn.png
:white_check_mark:Succeeded
View

docs/cloud-adoption/_images/discovery-guides/discovery-guide-encryption.png
:white_check_mark:Succeeded
View

docs/cloud-adoption/_images/discovery-guides/discovery-guide-identity.png
:white_check_mark:Succeeded
View

docs/cloud-adoption/_images/discovery-guides/discovery-guide-logs-and-reporting.png
:white_check_mark:Succeeded
View

docs/cloud-adoption/_images/discovery-guides/discovery-guide-policy-enforcement.png
:white_check_mark:Succeeded
View

docs/cloud-adoption/_images/discovery-guides/discovery-guide-resource-grouping.png
:white_check_mark:Succeeded
View

docs/cloud-adoption/_images/discovery-guides/discovery-guide-sdn.png
:white_check_mark:Succeeded
View

docs/cloud-adoption/_images/discovery-guides/discovery-guide-subscriptions.png
:white_check_mark:Succeeded
View

docs/cloud-adoption/_images/discovery-guides/discovery-guide-tagging.png
:white_check_mark:Succeeded
View

docs/cloud-adoption/_images/eason-matrix.gif
:white_check_mark:Succeeded
View

docs/cloud-adoption/_images/governance-and-services.PNG
:white_check_mark:Succeeded
View

docs/cloud-adoption/_images/governance-cost-management-discipline.png
:white_check_mark:Succeeded
View

docs/cloud-adoption/_images/governance-discipline-configuration-management.png
:white_check_mark:Succeeded
View

This comment lists only the first 50 files in the pull request.

docs/cloud-adoption/business-strategy/business-outcomes/how-to-use-the-business-outcome-template.md

Line 12: [Warning] Invalid file link:(~/cloud-adoption/business-strategy/business-outcomes/business-outcome-template.xlsx).

docs/cloud-adoption/business-strategy/business-outcomes/overview.md

Line 14: [Warning] Invalid file link:(~/cloud-adoption/business-strategy/business-outcomes/business-outcome-template.xlsx).

docs/cloud-adoption/business-strategy/overview.md

Line 18: [Warning] Invalid file link:(~/cloud-adoption/business-strategy/business-outcomes/business-outcome-template.xlsx).

docs/cloud-adoption/digital-estate/calculate.md

Line 24: [Warning] Invalid file link:(~/cloud-adoption/digital-estate/migration-backlog.md).
Line 24: [Warning] Invalid file link:(~/cloud-adoption/digital-estate/technical-spikes.md).

docs/cloud-adoption/governance/cost-management/overview.md

Line 17: [Warning] Invalid file link:(~/cloud-adoption/_images/adoptionphases.png).

docs/cloud-adoption/governance/how-can-a-ciso-prepare-for-the-cloud.md

Line 26: [Warning] Invalid file link:(~/cloud-adoption/governance/what-is-a-cloud-policy-review.md).
Line 61: [Warning] Invalid file link:(~/cloud-adoption/governance/policy-compliance/).

docs/cloud-adoption/governance/resource-management/governance-multiple-teams.md

Line 265: [Warning] Invalid file link:(~/cloud-adoption/governance/infrastructure/basic-workload.md).

docs/cloud-adoption/governance/resource-management/governance-single-team.md

Line 25: [Warning] Invalid file link:(~/cloud-adoption/governance/_images/governance-3-0.png).
Line 36: [Warning] Invalid file link:(~/cloud-adoption/governance/_images/governance-1-2.png).
Line 47: [Warning] Invalid file link:(~/cloud-adoption/governance/_images/governance-1-3.png).
Line 52: [Warning] Invalid file link:(~/cloud-adoption/governance/_images/governance-1-4.png).
Line 59: [Warning] Invalid file link:(~/cloud-adoption/governance/_images/governance-1-5.png).
Line 66: [Warning] Invalid file link:(~/cloud-adoption/governance/_images/governance-1-6.png).
Line 78: [Warning] Invalid file link:(~/cloud-adoption/governance/_images/governance-1-7.png).
Line 85: [Warning] Invalid file link:(~/cloud-adoption/governance/_images/governance-1-8.png).
Line 104: [Warning] Invalid file link:(~/cloud-adoption/governance/infrastructure/basic-workload.md).

docs/cloud-adoption/governance/resource-management/overview.md

Line 27: [Warning] Invalid file link:(~/cloud-adoption/governance/resource-management/toolchain.md).
Line 39: [Warning] Invalid file link:(~/cloud-adoption/governance/resource-management/toolchain.md).
Line 51: [Warning] Invalid file link:(~/cloud-adoption/governance/resource-management/toolchain.md).
Line 63: [Warning] Invalid file link:(~/cloud-adoption/governance/resource-management/toolchain.md).
Line 64: [Warning] Invalid file link:(~/cloud-adoption/governance/resource-management/toolchain.md).

docs/cloud-adoption/governance/security-management/overview.md

Line 10: [Warning] Invalid file link:(~/cloud-adoption/infrastructure/software-defined-network/overview.md).
Line 27: [Warning] Invalid file link:(~/cloud-adoption/governance/security-management/toolchain.md).
Line 45: [Warning] Invalid file link:(~/cloud-adoption/governance/security-management/toolchain.md).
Line 60: [Warning] Invalid file link:(~/cloud-adoption/governance/security-management/toolchain.md).
Line 75: [Warning] Invalid file link:(~/cloud-adoption/governance/security-management/toolchain.md).
Line 93: [Warning] Invalid file link:(~/cloud-adoption/governance/security-management/governance-single-team.md).
Line 93: [Warning] Invalid file link:(~/cloud-adoption/governance/security-management/governance-multiple-teams.md).
Line 93: [Warning] Invalid file link:(~/cloud-adoption/governance/security-management/azure-resource-access.md).
Line 96: [Warning] Invalid file link:(~/cloud-adoption/governance/security-management/azure-resource-access.md).

docs/cloud-adoption/migration/execute/assess.md

Line 15: [Warning] Invalid file link:(~/cloud-adoption/migration/plan/incremental-change-management.md).
Line 19: [Warning] Invalid file link:(~/cloud-adoption/migration/plan/incremental-change-management.md).
Line 56: [Warning] Invalid file link:(~/cloud-adoption/migration/plan/incremental-change-management.md).

docs/cloud-adoption/migration/execute/iteration-release-backlog.md

Line 12: [Warning] Invalid file link:(~/cloud-adoption/migration/govern/overview.md).

docs/cloud-adoption/migration/execute/overview.md

Line 16: [Warning] Invalid file link:(~/cloud-adoption/migration/plan/overview.md).
Line 16: [Warning] Invalid file link:(~/cloud-adoption/migration/govern/overview.md).
Line 16: [Warning] Invalid file link:(~/cloud-adoption/migration/plan/incremental-change-management.md).
Line 18: [Warning] Invalid file link:(~/cloud-adoption/migration/plan/rationalize.md).

docs/cloud-adoption/migration/execute/partnership-options.md

Line 11: [Warning] Invalid file link:(~/cloud-adoption/migration/plan/overview.md).
Line 11: [Warning] Invalid file link:(~/cloud-adoption/migration/build/overview.md).
Line 13: [Warning] Invalid file link:(~/cloud-adoption/migration/plan/overview.md).
Line 13: [Warning] Invalid file link:(~/cloud-adoption/migration/build/overview.md).
Line 27: [Warning] Invalid file link:(~/patterns/).
Line 28: [Warning] Invalid file link:(~/building-blocks/).
Line 29: [Warning] Invalid file link:(~/example-scenario/).
Line 30: [Warning] Invalid file link:(~/reference-architectures/).

docs/cloud-adoption/migration/operate/optimize.md

Line 12: [Warning] Invalid file link:(~/cloud-adoption/migration/Migrate/overview.md).
Line 19: [Warning] Invalid file link:(~/cloud-adoption/migration/Migrate/overview.md).
Line 27: [Warning] Invalid file link:(~/cloud-adoption/infrastructure/resource-tags/overview.md).

docs/cloud-adoption/migration/plan/first-workload.md

Line 10: [Warning] Invalid file link:(~/cloud-adoption/digital-estate/rationalize-inventory.md).

docs/cloud-adoption/migration/plan/infrastructure-assessment-tools.md

Line 10: [Warning] Invalid file link:(~/cloud-adoption/migration/plan/overview.md).
Line 10: [Warning] Invalid file link:(~/cloud-adoption/migration/plan/overview.md).
Line 12: [Warning] Invalid file link:(~/cloud-adoption/business-strategy/digital-estate.md).

docs/cloud-adoption/migration/plan/iterative-change-management.md

Line 24: [Warning] Invalid file link:(~/cloud-adoption/migration/execute/iteration-release-backlog).
Line 25: [Warning] Invalid file link:(~/cloud-adoption/migration/execute/iteration-release-backlog).

docs/cloud-adoption/migration/plan/migration-backlog.md

Line 10: [Warning] Invalid file link:(~/cloud-adoption/digital-estate/rationalize-inventory.md).

docs/cloud-adoption/overview.md

Line 107: [Warning] Invalid file link:(~/cloud-adoption/govern/overview.md).

docs/cloud-adoption/technical-standards/overview.md

Line 30: [Warning] Invalid file link:(~/cloud-adoption/infrastructure/overview).
Line 33: [Warning] Invalid file link:(~/cloud-adoption/infrastructure/overview).

docs/cloud-adoption/transformation-journeys/disruptive-transformation.md

Line 14: [Warning] Invalid file link:(~/cloud-adoption/transformation-journeys/operational-transformation.md).

docs/cloud-adoption/transformation-journeys/operational-transformation/build.md

Line 16: [Warning] Invalid file link:(~/cloud-adoption/_images/operational-transformation-infographic.pdf).
Line 22: [Warning] Invalid file link:(~/cloud-adoption/transformation-journeys/business-strategy/global-markets.md).
Line 23: [Warning] Invalid file link:(~/cloud-adoption/transformation-journeys/business-strategy/stakeholder-alignment.md).
Line 24: [Warning] Invalid file link:(~/cloud-adoption/transformation-journeys/business-strategy/business-reviews.md).
Line 31: [Warning] Invalid file link:(~/cloud-adoption/transformation-journeys/migration/plan/technical-spike-poc.md).
Line 37: [Warning] Invalid file link:(~/cloud-adoption/transformation-journeys/migration/plan/migration-backlog.md).
Line 38: [Warning] Invalid file link:(~/cloud-adoption/transformation-journeys/migration/plan/rationalize.md).
Line 39: [Warning] Invalid file link:(~/cloud-adoption/transformation-journeys/migration/plan/core-services.md).
Line 41: [Warning] Invalid file link:(~/cloud-adoption/transformation-journeys/migration/plan/corporate-policy-and-compliance.md).
Line 43: [Warning] Invalid file link:(~/cloud-adoption/transformation-journeys/migration/plan/ciso-guidance.md).
Line 47: [Warning] Invalid file link:(~/cloud-adoption/transformation-journeys/business-strategy/global-markets.md).
Line 52: [Warning] Invalid file link:(~/cloud-adoption/transformation-journeys/business-strategy/global-markets.md).

docs/cloud-adoption/transformation-journeys/operational-transformation/govern.md

Line 16: [Warning] Invalid file link:(~/cloud-adoption/_images/operational-transformation-infographic.pdf).
Line 22: [Warning] Invalid file link:(~/cloud-adoption/transformation-journeys/business-strategy/business-risks.md).
Line 26: [Warning] Invalid file link:(~/cloud-adoption/transformation-journeys/culture-strategy/c-suite-readiness.md).
Line 30: [Warning] Invalid file link:(~/cloud-adoption/transformation-journeys/migration/plan/corporate-policy-and-compliance.md).
Line 32: [Warning] Invalid file link:(~/cloud-adoption/transformation-journeys/governance/policy-compliance/overview.md).
Line 33: [Warning] Invalid file link:(~/cloud-adoption/transformation-journeys/governance/monitoring-enforcement/overview.md).
Line 39: [Warning] Invalid file link:(~/cloud-adoption/transformation-journeys/governance/configuration-management/overview.md).
Line 40: [Warning] Invalid file link:(~/cloud-adoption/transformation-journeys/governance/configuration-management/overview.md).
Line 41: [Warning] Invalid file link:(~/cloud-adoption/transformation-journeys/governance/configuration-management/overview.md).
Line 42: [Warning] Invalid file link:(~/cloud-adoption/transformation-journeys/governance/configuration-management/overview.md).
Line 43: [Warning] Invalid file link:(~/cloud-adoption/transformation-journeys/governance/configuration-management/overview.md).

docs/cloud-adoption/transformation-journeys/operational-transformation/manage.md

Line 16: [Warning] Invalid file link:(~/cloud-adoption/_images/operational-transformation-infographic.pdf).

docs/cloud-adoption/transformation-journeys/operational-transformation/migrate.md

Line 16: [Warning] Invalid file link:(~/cloud-adoption/_images/operational-transformation-infographic.pdf).
Line 22: [Warning] Invalid file link:(~/cloud-adoption/transformation-journeys/migration/execute/iteration-release-backlog.md).
Line 23: [Warning] Invalid file link:(~/cloud-adoption/transformation-journeys/migration/execute/assess.md).
Line 24: [Warning] Invalid file link:(~/cloud-adoption/transformation-journeys/migration/execute/architect.md).
Line 25: [Warning] Invalid file link:(~/cloud-adoption/transformation-journeys/migration/execute/remediate.md).
Line 26: [Warning] Invalid file link:(~/cloud-adoption/transformation-journeys/migration/execute/replicate.md).
Line 27: [Warning] Invalid file link:(~/cloud-adoption/transformation-journeys/migration/execute/stage.md).
Line 37: [Warning] Invalid file link:(~/cloud-adoption/transformation-journeys/migration/execute/business-test.md).
Line 38: [Warning] Invalid file link:(~/cloud-adoption/transformation-journeys/migration/execute/business-change-plan.md).
Line 39: [Warning] Invalid file link:(~/cloud-adoption/transformation-journeys/migration/execute/business-priorities.md).
Line 43: [Warning] Invalid file link:(~/cloud-adoption/transformation-journeys/culture-strategy/people-and-skills.md).
Line 47: [Warning] Invalid file link:(~/cloud-adoption/transformation-journeys/migration/execute/ready.md).
Line 48: [Warning] Invalid file link:(~/cloud-adoption/transformation-journeys/migration/execute/promote.md).
Line 49: [Warning] Invalid file link:(~/cloud-adoption/transformation-journeys/migration/execute/retrospective.md).

docs/cloud-adoption/transformation-journeys/operational-transformation/plan.md

Line 16: [Warning] Invalid file link:(~/cloud-adoption/_images/operational-transformation-infographic.pdf).
Line 31: [Warning] Invalid file link:(~/cloud-adoption/culture-strategy/c-suite-readiness.md).
Line 32: [Warning] Invalid file link:(~/cloud-adoption/culture-strategy/hiring-profiles.md).
Line 41: [Warning] Invalid file link:(~/cloud-adoption/migration/plan/prioritize-workloads.md).
Line 42: [Warning] Invalid file link:(~/cloud-adoption/migration/plan/technical-spike-poc.md).

docs/cloud-adoption/transformation-journeys/overview.md

Line 15: [Warning] Invalid file link:(~/overview.md).

building-blocks/extending-templates/toc.json

[Warning] Error happen when converting building-blocks/extending-templates/toc.json to Pdf. Details: Could not find a part of the path 'T:\iuxg\building-blocks\extending-templates\toc.json'.

toc.json

[Warning] Error happen when converting toc.json to Pdf. Details: Could not find file 'T:\iuxg\toc.json'.

bread/toc.json

[Warning] Error happen when converting bread/toc.json to Pdf. Details: Could not find a part of the path 'T:\iuxg\bread\toc.json'.

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Local endpoint

Hello, if I bind to port 0 (OS chosen random available port) I would like to know what was allocated. TCP/UDP have APIs to get the local endpoint. I'm not finding in the docs as to how to get them.
Is that missing (or if it's there somewhere then apologies, can someone point it out pls) or is that deliberately omitted for some reason ? Currently I've to either hard-code the ports or if using 0 use the UDP API to get the port back and then pass the socket to quinn - which seems very round-about.

Which UDP API are you using? Just local_addr()?

Yes

It's just missing. Would you mind doing a PR to add it?

Done

Great, thank you!


When loading a binary file, take feature penalty from config if given there.

This enables users to override the feature penalty when loading a dataset from a binary file.
For instance, it enables disabling/enabling features via:
dataset = lgbm.Dataset('data.bin',params={'feature_contri': [0,1,1,0]})
....

The above is especially useful when the data set is large, so the cost of recreating the data set from the source data is large.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: remcob-gr sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.

Hi @remcob-gr !
Thanks for your contribution!
Sorry for the inconvenience but you should sign the CLA and rebase the branch against the latest master to pass all checks.

Closing this PR in favour of https://github.com/Microsoft/LightGBM/pull/1881 , which I've rebased on top of master.


Support Jupyterlab in Jupyter init action

Theoretically you can pip install jupyterlab and it's available at <masterip>:8123/lab. I'd rather keep Juypter as the default, and Jupyterlab accessible at /lab, at least until Jupyterlab is GA.
It didn't work for me on the first try -- I got a 404 error popup. Digging in, it is {"message": "No such file: <cluster-gcs-bucket>/notebooks", "reason": null}. Since we are using a GCS content manager, I think this is actually this Jupyter bug: https://github.com/jupyterlab/jupyterlab/issues/3796.

Ah I see this was actually a bug in jgscm, the GCS content manager, and it was fixed in https://github.com/src-d/jgscm/commit/d1f1f4bda80cf8559358926f9c6250b2ce18d247
So we just need to jgscm to cut a new version and it should just work.

(The jgscm PR was https://github.com/src-d/jgscm/pull/9)

Creating the cluster with this command

    gcloud dataproc clusters create cluster-1 --bucket storage-north1 --subnet default \
           --zone europe-north1-b --master-machine-type n1-standard-1 --master-boot-disk-size 100 \
           --num-workers 2 --worker-machine-type n1-standard-1 --worker-boot-disk-size 100 \
           --image-version 1.3-deb9 --scopes 'https://www.googleapis.com/auth/cloud-platform' \
           --project bigquery-220317 \
           --initialization-actions  'gs://dataproc-initialization-actions/jupyter/jupyter.sh'\
           --metadata "JUPYTER_CONDA_PACKAGES=jupyterlab:numpy:pandas:matplotlib:pyspark"

I can access jupyterlab at localhost:8123/lab but I immediatly get a pop up window with the error
 Directory not found: ""`

Then I can create new notebooks, but the file explorer pane on the left is empty and unusable.
Can we add back support to jupyterlab in jupyter init action, i.e. re-revert #250 (if that's possible), and fix this bug?

Jupyterlab is supported through the JUPYTER optional component, so closing this issue. The jupyter init action is effectively deprecated.


Auto corrected by following Format Ruby Code

Auto corrected by following Format Ruby Code
Click here to configure it on awesomecode.io

Coverage increased (+0.05%) to 97.086% when pulling 9483883eb5ef80857970acef1c86c36b5dbc841a on awesomecode-format-ruby-code-47937 into e7db0b391d5a853b0a3dbeb08a01a47f90fef3af on master.

Coverage increased (+0.05%) to 97.086% when pulling 9483883eb5ef80857970acef1c86c36b5dbc841a on awesomecode-format-ruby-code-47937 into e7db0b391d5a853b0a3dbeb08a01a47f90fef3af on master.


Problem in loading custom layer

I have used the ZSumLayer from here to average all of the word embeddings from the embedding layer. I am able to train the model and save it successfully. But when I am loading it back for scoring, it is throwing following error:
  File "/home/shwegarg/anaconda2/lib/python2.7/site-packages/keras/models.py", line 197, in model_from_json
    return layer_from_config(config, custom_objects=custom_objects)
  File "/home/shwegarg/anaconda2/lib/python2.7/site-packages/keras/utils/layer_utils.py", line 36, in layer_from_config
    return layer_class.from_config(config['config'])
  File "/home/shwegarg/anaconda2/lib/python2.7/site-packages/keras/engine/topology.py", line 2375, in from_config
    process_layer(layer_data)
  File "/home/shwegarg/anaconda2/lib/python2.7/site-packages/keras/engine/topology.py", line 2353, in process_layer
    custom_objects=custom_objects)
  File "/home/shwegarg/anaconda2/lib/python2.7/site-packages/keras/utils/layer_utils.py", line 36, in layer_from_config
    return layer_class.from_config(config['config'])
  File "/home/shwegarg/anaconda2/lib/python2.7/site-packages/keras/engine/topology.py", line 929, in from_config
    return cls(**config)
TypeError: __init__() takes exactly 2 arguments (1 given)

The full code is as follows:
ZSumLayer code:
from keras.layers import Layer
from keras import backend as K
class ZSumLayer(Layer):
    def __init__(self, output_dim, **kwargs):
        self.supports_masking = True
        self.output_dim = output_dim
        super(ZSumLayer, self).__init__(**kwargs)

    def call(self, x, mask=None):
        count = K.sum(mask, axis=1)[:, np.newaxis]
        avg = K.sum(K.switch(mask[:, :, np.newaxis], x, 0), axis=1) / count
        return K.cast(avg, x.dtype)

    def get_output_shape_for(self, input_shape):
        return (input_shape[0], self.output_dim)

    def compute_mask(self, input, mask):

Training code
from keras.layers.embeddings import Embedding
from keras.layers import Masking, Activation, Input, LSTM, merge
from keras.models import Model
import numpy as np

wt = np.array([[0,0,0,0,0],
              [1,2,0,3,6],
              [4,6,0,5,7],
              [4,5,7,0,4]])

def s(x):
    return K.mean(x, axis=1)

sen = Input(shape=(4,), dtype='int32')

embedding = Embedding(
    input_dim = 4,
    output_dim = 5,
    mask_zero = True,
    trainable=False,
    weights=[wt]
)(sen)

out = ZSumLayer(5)(embedding)

model = Model(input=sen, output=out)

model.compile(loss='mse', optimizer='rmsprop')

print model.summary()

with open('/home/shwegarg/data_files/model_arch.json', 'w') as mfp:
    mfp.write(model.to_json())
model.save_weights('/home/shwegarg/data_files/model_wts.hdf5')

Scoring code:
from keras.models import model_from_json

mfp = open('/home/shwegarg/data_files/model_arch.json','r')
mj = mfp.read()
model2 = model_from_json(mj, {'ZSumLayer': ZSumLayer})

Hello,
Is this by any chance related to https://github.com/fchollet/keras/issues/5396 ?

@unrealwill no, it does not look so...

I have solved the problem my adding following function in the ZSumLayer  class:
def get_config(self):
        config = {'output_dim': self.output_dim}
        base_config = super(ZSumLayer, self).get_config()
        return dict(list(base_config.items()) + list(config.items()))


Name clashes with NIOHTTP1

Currently AWSLambdaEvents defines public symbols HTTPHeaders, HTTPMethod and HTTPResponseStatus. These clash with the symbols of the same name in NIOHTTP1. While you can differentiate between the two sets by prepending NIOHTTP1., I'm not sure modules should be defining symbols with the same name as NIO equivalents.

What's wrong with using the NIOPHTTP1 versions of these objects, they are already imported by AWSLambdaRuntimeCore?

nio's versions are a bit different from the ones in AWSLambdaEvents, the latter are designed for JSON payload decoding/encoding
we could consider adding a prefix to more easily disambiguate.

I'd add prefixes too.

@weissi Do you have any recommendations in mind?

ALR* [A]WS [L]amba [R]untime? Maybe you already have some sort of common prefix? In SwiftNIO of course we use NIO for that purpose.

Of course that makes the type names a bit ugly. How are the users most commonly interfacing with those types?

normally we namespace under the Lambda

sounds good Lambda*?

well i'd put them in Lambda.* then

but that's not really the point since they are not connected to lambda but what the type the aws event is. Maybe we should namespace them in AWSHTTPTypes. But this could also create a naming conflict with the AWS SDK.

@fabianfett There isnt any AWSHTTPTypes and I'm not intending to add any. Even if I did, we'll be able to discriminate between them using the framework name. I'm trying to use the NIO types as much as possible

the latter are designed for JSON payload decoding/encoding
what? :-)

Apart from all the duping, wouldn’t you want to use the NIO types in the public API?
(not that this is necessary, but if you want, you could still use those types internally)
This is not about things like a V2.Request but about the basic http types.

@helje5 IIRC the main issues was that we would need to be extending these types to add functionality to them (Codable conformance mainly IIRC). rule of thumb we have been following in library development is to avoid extending public types from other libraries (SwiftNIO in this case) as it may lead to conflicts with other libraries that may do the same.
cc @weissi

You don't need to extend the types to decode them (yes, Codable can only be added to the original type itself, but that is not required here). You can decode the necessary data in init(decoder:) and then construct the actual model. Kinda similar to this:
https://github.com/SwiftBlocksUI/SwiftBlocksUI/blob/develop/Sources/SlackBlocksModel/InteractiveRequest/BlockActions.swift#L92
As mentioned in the Slack, a reasonable argument for the duping is that NIO isn't actually necessary for Lambdas. Don't know.

You don't need to extend the types to decode them (yes, Codable can only be added to the original type itself, but that is not required here). You can decode the necessary data in init(decoder:) and then construct the actual model. Kinda similar to this:

I guess if we decide to adopt the NIO types after all we could also use property wrappers

As mentioned in the Slack, a reasonable argument for the duping is that NIO isn't actually necessary for Lambdas. Don't know.

that too. personally, I don't love leaking types where not necessary. there is the argument of copying so we need to trade that off
in the case of HTTPHeaders, there is also a set of mutability functionality that comes with that type that may not makes sense to expose in the Lambda request use case which is more immutable in nature

there is the argument of copying so we need to trade that off
They are not even plain copies, e.g. the AWS method is a struct (which is actually the better choice), while the NIO one is an enum w/ an associated type.

Wrt HTTPHeaders, the NIO ones are actually better than the plain Dict you have in AWS because the latter doesn't account for the header case insensitivity.
Yes, AWS breaks out headers in weird ways (single/multi value), but there is no real reason to combine them back into NIO headers after decoding.
I don't get the mutability thing. NIOHeaders are a regular CoW struct just like Dictionary, right?

@adam-fowler now that we adopted Swift HTTP Types in Lambda Events, is this still an issue ?

HTTPHeaders is still there


[FEATURE REQUEST] Add similar navbar from main blog page to cardinal vices blog

Add similar navbar from main blog page to cardinal vices blog also change the logo and make it similar as index page
https://akshitagupta15june.github.io/Moksh/Blogs/Blog.html#

Please assign this to me

Please I’ll like to work on this issue

I would like to work on this issue. @akshitagupta15june

@akshitagupta15june please assign this issue to me because I want to work on it.

Please assign this issue to me.

@akshitagupta15june mam, please assign this issue to me I have completed the last issue.

please assign this to me

assigned


Create act.ve

Submitting a change will write it to a new branch in your fork HamedAsoodeh/SolidityPersianWebDesign, so you can send a pull request.


It takes 7 seconds for each call

It takes 7 seconds to retrieve just four names from the database and this is because you're opening and closing the database after each call so I'm wondering if you would be able to add the ability for the programmer to open and close the database when they see fit. Thank you in advance!

Hello, I just made a pull request to this project, it's work for me, please try to check and tell me if you find another problem

Will do.
I ended up writing my own calls, so don't spend your time making these
changes unless it's something you want to do anyways to enhance the plugin .
Happy coding ☺
On Wed, Feb 13, 2019, 1:15 AM Josloader3<EMAIL_ADDRESS>wrote:

Hello, I just made a pull request to this project, it's work for me,
please try to check and tell me if you find another problem
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/SergioDosSantos/cordova-plugin-sqlserver/issues/4#issuecomment-463073766,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AiGR64ufBJuboTNNguufduPl8TLLgSLrks5vM62MgaJpZM4Ycjxq
.

This is a good cordova plugin, useful for the Ionic Framework layer. That's the reason for enhance this plugin


Support endpoint

Added and restructured to initially choose channel sets
Defaulting BRHost to localhost
Suppress warnings to supress error when remoting
Converted tabs to spaces, fixing indetation to 4 chars

Manual Integration and Upgrade Test completed without problems.
Environment:

Veeam B&R 9.5 U2
Windows 2012 R2
PowerShell 4.0
PRTG <IP_ADDRESS>41


使用apikey时报错401

Server Error: Request failed with status code 401 and body {"error":{"message":"Incorrect API key provided: sk-VKMIswjh3. You can find your API key at https://platform.openai.com/account/api-keys.","type":"invalid_request_error","param":null,"code":"invalid_api_key"}}Server Error: Request failed with status code 401 and body {"error":{"message":"Incorrect API key provided: sk-VKMIswjh3. You can find your API key at https://platform.openai.com/account/api-keys.","type":"invalid_request_error","param":null,"code":"invalid_api_key"}}

请仔细阅读 readme


Removing code coverage and cleanup tox

I don't think so these files or stuff are used let's see.

I think this should be good. cc @NicolasHug @pmeier

Additionally we can think about cleaning up pytest.ini, setup.cfg and pyproject.toml to a single file. Probably just keep pyproject.ml. (Not sure if mypy too can be combined)

Additionally we can think about cleaning up pytest.ini, setup.cfg and pyproject.toml to a single file. Probably just keep pyproject.ml. (Not sure if mypy too can be combined)

I would rather keep things as is.
Any change we make about these will need to be carefully checked on the fbcode side, which has its own requirements and constraints. We wouldn't gain a tremendous value by merging all these into one file anyway, and the low benefit doesn't outweight the extra-work IMHO.

I'm little bit scared :fearful: Since last time I had broken the docs while modifying such files

CI seems all green. Hopefully this doesn't break stuff on fbcode side.

I guess it's not breaking anything. (But take no risks, I can close it otherwise)
cc @datumbox @NicolasHug

Aah finally, Is everything fine on fbcode side? I don't want to break something again :stuck_out_tongue:


[DOC] Quickstart Guide Updates

Update morpheus Quickstart guide with more information

This issue closed with PR#127


Simplified and harden Dockerfile

Hi,
Changes:

Add Git to Studio Dockerfile as it is quite logical to have it present for integration with Git
Simplify Dockerfiles, shrink size and improve readability
Harden Dockerfiles with Hadolint

Let me know if you have questions / suggestions.
Best regards,
Fred

Sorry about the failed tests, I blindly refactored the Connect and Package manager Dockerfile as I was mostly interested in fixing the Studio Pro one and figured might as well do the same for the other Dockerfiles.

Hi Fred, thank you very much for the PR!
Totally makes sense to add git and most of the refactors are pretty good.
I requested one change to split the installation, while its not optimal I would prefer to keep it like that for now.

Thanks! I've added the requested changes.

Thanks for the contribution!