fix with new name in RAVEN base classes

Pull Request Description
What issue does this change request address?
Closes #25
What are the significant changes in functionality due to this change request?
the location of base classes was grammatically changed from PluginsBaseClasses to PluginBaseClasses (red for emphasis)
just remove the s

For Change Control Board: Change Request Review
The following review must be completed by an authorized member of the Change Control Board.

[x] 1. Review all computer code.
[x] 2. If any changes occur to the input syntax, there must be an accompanying change to the user manual and xsd schema. If the input syntax change deprecates existing input files, a conversion script needs to be added (see Conversion Scripts).
[x] 3. Make sure the Python code and commenting standards are respected (camelBack, etc.) - See on the wiki for details.
[x] 4. Automated Tests should pass.
[x] 5. If significant functionality is added, there must be tests added to check this. Tests should cover all possible options.  Multiple short tests are preferred over one large tes.
[x] 6. If the change modifies or adds a requirement or a requirement based test case, the Change Control Board's Chair or designee also needs to approve the change.  The requirements and the requirements test shall be in sync.
[x] 7. The merge request must reference an issue.  If the issue is closed, the issue close checklist shall be done.
[x] 8. If an analytic test is changed/added, the the analytic documentation must be updated/added.
[x] 9. If any test used as a basis for documentation examples have been changed, the associated documentation must be reviewed and assured the text matches the example.

Changes are good, checklists pass, merging.


Example to use Sortable with Knockout.js

Hi!
Could you please provide sample basic example how to build sortable list with knockout?
Thank you in advance!

https://github.com/SortableJS/knockout-sortablejs

Thank you very much! was unable to find it by myself


Added Status Code Constants & Token Functions

This will reduce the number of repeated lines in tests and api/routes. The Token functions are
documented, tested and ensure that they work properly.
@ bad code

rebase


Register other gateways

I'm trying to add new gateway to the PayumServer but I cannot figure which file is responsible to add the gateways. I have to add the next code in order to register the gateway:
<?php
//config.php

use Payum\Core\Extension\GenericTokenFactoryExtension;

// ...
$factory = new \Crevillo\Payum\Redsys\RedsysGatewayFactory;
$gateways['redsys'] = $factory->create(array(
   'merchant_code' => 'REPLACE WITH YOURS',
   'terminal' => 'REPLACE WITH YOURS', // normally '001'
   'secret_key' => 'REPLACE WITH YOURS'
   'sandbox' => true

    // uncomment if you want notify url to be generated automatically.
    // 'payum.extension.token_factory' => new GenericTokenFactoryExtension($tokenFactory),
));

But I cannot find where, looking PayumSilexProvider documentation it says to use $app['payum.gateways'] but I'm getting InvalidArgumentException: Identifier "payum.gateways" is not defined. all the time.
Any point in how to add other gateways than the default ones would be very appreciated :)
Thanks

Something like this has to work:
<?php

$app['payum.builder']->addGatewayFactory('redsys', function($config, $coreGateway)) {
    return new \Crevillo\Payum\Redsys\RedsysGatewayFactory($config, $coreGateway);
});

I am going to remove this service: payum.gateways

It works! Thank you.
I think it would be nice to have this well documented

Indeed.


Rendering issue with

After <kor-icon icon="favorite" size="xl"></kor-icon>, I get (in Firefox, Waterfox) a rectangular with the following characters E87D (UTF-16: 0xE87D)
When icon="train", I get E570 (UTF-16: 0xE570). Web displays a solid circle/bullet.
In both cases, brave displays only a rectangular.
<kor-icon> is used within another component. Only very basic css, nothing weird!
I am not sure if browsers in my system or the system itself have been set in a wrong way or there is problem with this component.

Hi, I have 2 hypothesis to why this is happening in your project:

The CSS file is not loaded properly
The fonts are not found for some reason
You have reassigned the font family of kor-icon

Please try ensuring the css and font files are loaded and that the family is assigned correctly and update the issue if it still doesn't work.

As per doc, I have included both necessary files:

import '@kor-ui/kor/components/icon';
import<EMAIL_ADDRESS>

How can I check that? FYI, I cannot see the Material Design Icons, too!!!.
How can I check that?

In addition, also url option does not properly work.
FYI, I have not modified any file of the module. Moreover, I have removed my own css files. - Tia

As per doc, I have included both necessary files:

import '@kor-ui/kor/components/icon';
import<EMAIL_ADDRESS>

How can I check that? FYI, I cannot see the Material Design Icons, too!!!.
How can I check that?

In addition, also url option does not properly work.
FYI, I have not modified any file of the module. Moreover, I have removed my own css files. - Tia

I have created a basic sample including only sh-icon, maybe this helps: https://stackblitz.com/edit/kor-ui-angular-vkpyyc?file=src%2Fapp%2Fapp.component.ts
To check whether kor-styles.css and the font files are loaded properly, please check you console. You may have an error message saying that either kor-styles.css or md-icons.woff are not found.
The line where the local path is defined can be found here: https://github.com/kor-ui/kor/blob/develop/kor-styles.css#L45

You could also try adding the line below to your component and see if it fixes the issue. It is not a permanent solution but will show whether it is in fact a matter of the resource not being found:
/* typography */
@font-face {
  font-family: 'md-icons';
  src:  local('Material Icons'), local('MaterialIcons-Regular'<EMAIL_ADDRESS>format('woff2'<EMAIL_ADDRESS>format('woff');
}

As per doc, I have included both necessary files:

import '@kor-ui/kor/components/icon';
import<EMAIL_ADDRESS>

How can I check that? FYI, I cannot see the Material Design Icons, too!!!.
How can I check that?

In addition, also url option does not properly work.
FYI, I have not modified any file of the module. Moreover, I have removed my own css files. - Tia

I have created a basic sample including only sh-icon, maybe this helps: https://stackblitz.com/edit/kor-ui-angular-vkpyyc?file=src%2Fapp%2Fapp.component.ts
To check whether kor-styles.css and the font files are loaded properly, please check you console. You may have an error message saying that either kor-styles.css or md-icons.woff are not found.
The line where the local path is defined can be found here: https://github.com/kor-ui/kor/blob/develop/kor-styles.css#L45

No error in console while running.

/* typography */
@font-face {
  font-family: 'md-icons';
  src:  local('Material Icons'), local('MaterialIcons-Regular'<EMAIL_ADDRESS>format('woff2'<EMAIL_ADDRESS>format('woff');
}

Unfortunately, outcome is the same.
I do not really know if the root of the problem is on my side or not. So, for the time being, just keep it in back of your mind. If there is also another complaint then you can put some time to investigate it.
You can close it if you want. - Thanks for your time!


Multiple getterTypes

Hi,
I'm working Vuex modules to state my data.
I store the data in multiple modules to keep my code base nice and clean.
When using vuex-map-fields I have a situation where I'm using data from multiple modules.
There seems to be no method to do this or I am doing it wrong.
Below is my current code;
My component
<template>

        <input type="text" v-model="no_panels">

        <input type="text" v-model="firstName">

        <router-link to="/step-2">Go to step 2</router-link>

</template>

My store file
import kitchen from './kitchen';
import applicant from "./applicant";

export default {
    modules: {
        kitchen: kitchen,
        applicant: applicant
    },
    strict: false
}

Applicant.js
import { createHelpers } from 'vuex-map-fields';

const { getApplicantField, updateApplicantField } = createHelpers({
    getterType: 'getApplicantField',
    mutationType: 'updateApplicantField',
});

export default {
    state: {
        firstName: '',
        lastName: ''
    },
    getters: {
        getApplicantField
    },
    mutations: {
        updateApplicantField
    }
}

The code above results in the following error:

Error in render: "TypeError: this.$store.getters[getterType] is not a function"

Hey @jurgenbosch,
you're almost there, but instead of passing multiple getters to createHelpers(), you can destructure and rename the return value of createHelpers() and call it twice.
const { mapFields: mapKitchenFields } = createHelpers({
  getterType: 'getKitchenField',
  mutationType: 'updateKitchenField',
});
const { mapFields: mapApplicantFields } = createHelpers({
  getterType: 'getApplicantField',
  mutationType: 'updateApplicantField',
});

export default {
  computed: {
    ...mapKitchenFields(['no_panels']),
    ...mapApplicantFields(['firstName', 'lastName']),
  },
}

Awesome! Thank you. Never thought of the destructor. I guess I was stuck at the array option ;)

One more question ..
Is there a way to use module_name.store_name syntax in the template?
In the current setup it might happen that both modules contain a store for the title.
In the current situation I can only use it once.

You can rename properties: https://github.com/maoberlehner/vuex-map-fields#rename-properties

I've seen that solution but and I imagined prefixing everything but that doesn't feel like a nice solution because it would basically adding more work to rename all fields and makes it unnecessary complicated.
It tried something like;
export default {
        computed: {
            ...mapKitchenFields({
                kitchen: {
                    no_panels: 'no_panels',
                    plintm2: 'plintm2'
                }
            }),
            ...mapApplicantFields(['firstName', 'lastName'])
        },
    }

But this results in a error saying;

"TypeError: path.split is not a function"

Ideal would be to have something like:
const { mapFields: mapApplicantFields, prefix: 'applicant' } = createHelpers({
        getterType: 'getApplicantField',
        mutationType: 'updateApplicantField',
    });

And then use 'applicant.firstName' in the template instead of just 'firstName'.

I think that's a pretty good Idea – I'm open for pull requests. See: https://github.com/maoberlehner/vuex-map-fields/issues/19

I might work on it myself the following days, but I can't guarantee that I have time.

Hi @maoberlehner What if I have to use all the fields in the state more than once i.e using it in multiple components. How do I handle this situation?
For Example,
const { mapFields: mapKitchenFields } = createHelpers({
getterType: 'getKitchenField',
mutationType: 'updateKitchenField',
});
const { mapFields: mapApplicantFields } = createHelpers({
getterType: 'getApplicantField',
mutationType: 'updateApplicantField',
});
export default {
computed: {
...mapKitchenFields(['no_panels', 'firstName', 'lastName']),
...mapApplicantFields(['no_panels','firstName', 'lastName']),
},
}
In this case, there is no point in creating two constants when they have the same fields. If I am using it in more than two time I have to create more constants and repeat the existing code which I don't want to. It would be helpful if you can provide an example how to handle this.

Hey @abhinukala Your example would not work, because the fields mapped with mapKitchenFields and mapApplicantFields have the same names. You'd have to rename the fields.
If you don't want to write the createHelpers() function multiple times with the same parameters, you could create a file like this:
// src/store/map-applicant-fields.js
export const { mapFields: mapApplicantFields } = createHelpers({
  getterType: 'getApplicantField',
  mutationType: 'updateApplicantField',
});

// in your component...
import { mapApplicantFields } from '../store/map-applicant-fields.js';

// ...

Or if you're using Vuex modules and assuming you have an applicant Vuex module you could use the module file to provide the mapFields helper function:
// src/store/modules/applicant.js

export const applicant = {
  state: {
  // ...
  },
  // ...
};

export const { mapFields: mapApplicantFields } = createHelpers({
  getterType: 'getApplicantField',
  mutationType: 'updateApplicantField',
});

I'm not quite sure tough if I understood your problem correctly, please provide more informations if I got it wrong :)
Thx.

@maoberlehner. Thank you for your response. Let me put my question this way. I have an address component(which has line1, line2, city, state and zip fields) that will be reused in multiple other components like Title and Registration as a sub-component. Now when I fill the address in Title.vue, in my store I need to have this information saved in the state -> title object. Save for registration.  So basically I need to differentiate where the address is coming from. Hope this makes my question clear.

I wrote an article about reusable Vuex modules. In the article you can see, that the contact.js and address.js Vuex modules are reused. Is this close to what you want to achieve?

Closing this as there has been no further feedback from @abhinukala


(Med-High Prio) Bug: Request to "Convert to CDM" breaks, path missing

After connecting to an Azure SQL database, clicking the "Convert to CDM" and sending the actual request runs into error. It seems like part of requests go through, and server receives them as activity spikes, but no changes are actually finished and pushed to server. Full error message is below

Creating CDM database...
Warning: CDM database exists
Warning: CDM schema exists
Warning: CDM tables exists
CDM tables truncated
Loading locations...
Locations was loaded
Loading care sites...
Care sites was loaded
Loading providers...
Providers was loaded
Saving lookups...
Lookups was saved
CMSPlaceOfService - Loading ...
DONE - 73 ms | KeysCount=260
CMSPlaceOfService - Uploading to File Manager...
CMSPlaceOfService - Uploading DONE
Could not find a part of the path '/app/ETL/Common/Scripts/PostgreSQL/DropChunkTable.sql'.

@Zwky26 I have added fix, please try now.

Tried and got a new message. This seems to be related to my postgres syntax and not any tech issue, and I am working on it. I will update if any other issues related to connections arise


Add spec.externalIPs in gateway helm charts

(This is used to request new product features, please visit https://discuss.istio.io for questions on using Istio)
Describe the feature request
According to https://istio.io/latest/docs/ops/diagnostic-tools/multicluster/ spec..externalIPs is required for environments which don't support kubernetes LoadBalancer services.
In this case, it may be necessary to customize the spec.externalIPs section of the Service to manually give the Gateway an IP reachable from outside the cluster.

The gateway helm chart doesn't support this field for the gateway service.
Describe alternatives you've considered
Affected product area (please put an X in all that apply)
[ ] Docs
[x] Installation
[ ] Networking
[ ] Performance and Scalability
[ ] Extensions and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure
Affected features (please put an X in all that apply)
[ ] Multi Cluster
[ ] Virtual Machine
[ ] Multi Control Plane
Additional context

Can create a pull request for this, if you want.


primer_match [sf#148]

Reported by nlw on 2009-04-21 16:44 UTC
Name: primer_match
Definition: A nucleotide match to a primer sequence.
is_a: SO:0000347 !nucleotide_match

Commented by eilbeck on 2009-04-21 20:07 UTC
Its is done
:o)

Updated by eilbeck on 2009-04-21 20:07 UTC

status: open --> closed-accepted


Added GitHub Assessments to the navbar of the playground-only configuration

Description
Added the GitHub Assessment button to the navbar of the playground-only configuration
Type of change

[x] Bug fix (non-breaking change which fixes an issue)

How to test
Test with different .env configuration combinations for PlaygroundOnly and Enable GitHub Assessments, and toggle between desktop and mobile breakpoints
Checklist

[x] I have tested this code

Pull Request Test Coverage Report for Build 927966126

1 of 5 (20.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.002%) to 29.208%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/commons/navigationBar/NavigationBar.tsx
1
5
20.0%

Totals

Change from base Build 927817345:
-0.002%

Covered Lines:
3031

Relevant Lines:
9562

💛  - Coveralls


How to Identify last viseme?

Hello,
I subscribe to synthesizer.VisemeReceived and play the BlendShapes as they come. Now I want to change the stream, e.g. mix with other BlendShapes, add a fade-out or append a neutral expression like mouth closed. Is there a way to identify the last Viseme event or maybe a way to get the total number of frames in advance?

After a phase of despair and denial, i realized that it is not possible to know the total keyframes before the processing finishes and thus not without introducing additional lag. However the solution I arrived at to apply an animation curve to the viseme stream now looks like this:

Start and peak frames are applied at VisemeReceived
Final frames, if they haven't played yet, are applied at SynthesisCompleted

If there is any other solution to share, please reopen.


Problem with M1 (Macbook 2021 Pro 14 inch)

Hallo
We cant get any app working on a M1 with React-Native admob
We keep getting:

/Users/acetyld/PhpstormProjects/appname/ios/Pods/Pods.xcodeproj: warning: The iOS Simulator deployment target 'IPHONEOS_DEPLOYMENT_TARGET' is set to 8.0, but the range of supported deployment target versions is 9.0 to 15.2.99. (in target 'boost-for-react-native' from project 'Pods')
ld: symbol(s) not found for architecture arm64
clang: error: linker command failed with exit code 1 (use -v to see invocation)

Is this a known issue?

in target 'boost-for-react-native' from project 'Pods'
The log seems to be not related with this library.

@Acetyld Two issues here...

The iOS Simulator Target is below the supported range (9.0 - 15.2.99). So increasing the simulator target within that range should make the warning go away.
It seems there is a package/dependency that isn't yet supported for ARM64 Macs, not sure which one from the log. In that case you may have to run Xcode under Rosetta.

This library is deprecated. Use react-native-google-mobile-ads instead.
Please migrate to the new library if you were using this library as this library is no longer maintained. Now more stronger features are available in the new library.


Set page size for drive items

We introduced a regression where we are not setting the page size for delta queries in drives. As of now, we use the default page size which is much less than the max available (999). Will involve adding Top here.

related to #3007

Change initially seems to have been made in https://github.com/alcionai/corso/pull/3719

Yep correct. I am working on a fix, will share the PR shortly.


Fail to clone/paste one blob under the attached blob container which SAS URL is created by 'User delegation key' (full permissions)

Storage Explorer Version: 1.26.0-dev
Build Number: 20220830.1
Branch: main
Platform/OS: Windows 10
Architecture ia32
How Found: From running test cases
Regression From: Not a regression
Steps to Reproduce

Select one storage account -> Give the account with 'Storage Blob Data Contributor' rbac role.
Expand the storage account -> Blob Containers.
Create one blob container -> Upload one blob to it.
Right click the blob container -> Click 'Get Shared Access Signature...'.
Select 'User delegation key' -> Select all permissions -> Click 'Create'.
Copy the SAS URL -> Attach the blob container via the SAS URL.
Go to the attached blob container.
Select the blob -> Clone the blob with a valid name.
Check whether succeeds to clone it.

Expected Experience
Succeed to clone it.
Actual Experience
Fail to clone it.

{   "message": "\"UnexpectedCancel\"" }
Additional Context

This issue also reproduces when pasting one blob.
This issue doesn't reproduce when uploading/renaming one blob.

AzCopy uses Get Account Information API during the s2s copy if it is set to preserve access tier. and it doesn't support user delegation SAS at the moment. https://docs.microsoft.com/en-us/rest/api/storageservices/get-account-information#authorization. A workaround could be disabling preserve access tier.

Talked to AzCopy about this issue and they said they will improve the error reporting for this scenario. Other than that, the result is expected.


testAddCollectionWhileCacheLoads fails on travis-ci.org

Can't reproduce locally.
e.g. https://travis-ci.org/linkedin/RocketData/builds/147242144
testAddCollectionWhileCacheLoads, Asynchronous wait failed: Exceeded timeout of 10 seconds, with unfulfilled expectations: "waitForCache".
  /Users/travis/build/linkedin/RocketData/RocketDataTests/CollectionDataProviderTests/SharedCollectionDataProviderTests.swift:817

I'm looking into this. See branch: fixci.


#601 and OMA issue #482

Update contributors list #601
Fixes to mia (OMA issue #482)(https://github.com/microbiome/OMA/issues/482)
diversity functions - warning that tells that some indices where not calculated
documentation fix on runRDA()
Updated the DESCRIPTION file to add missing contributors

Resolve conflicts. Is this otherwise ready?

See error

Some checks still fail?

It fails on Ubuntu and I can not figure out why

This branch does not have permission to push to gh-pages (only devel should push). That is why this error occurs. Not sure, why this branch tries to push though...


yaml configuration file for morph_checker

This is the first iteration for a yaml config file. Let me know if I should migrate other options such as the data path in the yaml file etc.

Current coverage is 100.00%

Merging #154 into master will not affect coverage as of e273bf4

@@            master    #154   diff @@
======================================
  Files           30      30
  Stmts         1074    1074
  Branches         0       0
  Methods
======================================
  Hit           1074    1074
  Partial          0       0
  Missed           0       0

Review entire Coverage Diff as of e273bf4

Powered by Codecov. Updated on successful CI builds.


Destroy socket after closing connection

Fixes #360
Just to be clear, I don't like this, but I'm not sure what the alternative is.
This diagram from wikipedia explains pretty well how closing a connection works:

What I think is happening in #360 is that the rate of connections being opened is higher than the rate of connections being closed. That is, when we call Socket.end, that initiates the connection closing handshake dance by sending a FIN packet. Once the server has acknowledged it, the client waits for some time until it actually closes the connection and hands the file descriptor back to the OS. I think the reason for this is that if you want to avoid some delayed packet being received by a subsequent connection.
Socket.destroy ignores this and just completely closes the connection immediately.
I also tried just awaiting the callback to Socket.end, hoping that it would get invoked when the handshake is done and the connection is actually closed, but that did not solve the problem. I'm not sure if it's just because the rate of opened connections is too high or if it's invoked just after sending the initial FIN packet.
My feeling right now is that the proper solution to this is to add a connection pool that bounds the total number of sockets somehow, so that you have to wait for a socket to become available before you can establish a new connection.
FYI @vykimo

I also experimented with listening for the close event before resolving disconnect, which also did not solve the problem.

A Problem I noticed too is that when openning rate is too high, packets seems never closing (or maybe they are but the openning is so high that we can't notice it) and then, overflowing happens.

This is a great article explaining the problem: http://www.serverframework.com/asynchronousevents/2011/01/time-wait-and-its-design-implications-for-protocols-and-scalable-servers.html

I'm quite convinced at this point that the problem is ephemeral port exhaustion on the client side due to the WAIT_TIME. Basically, even though we open and close the socket within the scope of a single message being processed, the socket can stick around for several minutes before it's released. I don't think that forcing the socket to be destroyed and re-used by another connection is an option, since we might get delayed packets ending up in the wrong place.
One way that some applications work around this is by having multiple IP addresses on the source destination. Each source ip gives you a number of available ports, but since the problem is the rate at which sockets are opened, that would only delay the problem.
Even if we could somehow allow the client to create an huge number of connections, eventually the destination would run out of ports, so that's not a solution.
So then we're back to the idea of limiting the creation of sockets. Instead of just directly creating a socket, we could enforce a limit and have the client wait for a socket to be released before we open a new one. This has two issues to solve:

Can we know when a socket is properly closed? I believe that the close event represents this, but I would need to verify it in code.
How do we know how many sockets we can create? This is configurable on the host, and differs across OSs. Maybe we can have a reasonable default and allow the user to override it through configuration if needed.

I'll do some experimentation with this approach when I have some time. I think it's the only reasonable solution outside of userland.
@vikymo: As a workaround for now, you could rate limit your consumer yourself until you hit an equilibrium. There are ways to modify how long the WAIT_TIME on the socket is, but you won't be able to get it so low that you can consume at top speed anyway.

I wrote a little test script to see how the socket events work, but I can't really seem to replicate the issue. I wanted to see if we would get the close event after the TIME_WAIT period, so we could use it to keep track of the number of still open sockets.
const net = require('net')
const ip = require('ip')

const KEEP_ALIVE_DELAY = 60000
const host = ip.address()
const port = 9092

const log = event => (...args) =>
  console.log(`[${event} | ${new Date().toISOString()}]: ${JSON.stringify(args)}`)

const socket = net.connect(
  { host, port },
  log('connect')
)

socket.setKeepAlive(true, KEEP_ALIVE_DELAY)
socket.on('data', log('data'))
socket.on('end', log('end'))
socket.on('error', log('error'))
socket.on('timeout', log('timeout'))
socket.on('close', log('close'))
socket.on('drain', log('drain'))
socket.on('lookup', log('lookup'))
socket.on('ready', log('ready'))

const errorTypes = ['unhandledRejection', 'uncaughtException']
const signalTraps = ['SIGTERM', 'SIGINT', 'SIGUSR2']

errorTypes.map(type => {
  process.on(type, e => {
    try {
      console.log(`process.on ${type}`)
      console.error(e)
      socket.end()
      process.exit(0)
    } catch (_) {
      process.exit(1)
    }
  })
})

signalTraps.map(type => {
  process.once(type, () => {
    try {
      socket.end()
    } finally {
      process.kill(process.pid, type)
    }
  })
})

process.on('SIGHUP', () => {
  log('SIGHUP')('Closing socket')
  socket.end()
})

All I'm doing is establishing a connection to Kafka (doesn't really matter what it is - I just wanted something on the other end) and then on SIGHUP I end the connection.
[connect | 2019-05-15T08:33:06.113Z]: undefined
[ready | 2019-05-15T08:33:06.115Z]: undefined
[SIGHUP | 2019-05-15T08:33:17.686Z]: "Closing socket"
[end | 2019-05-15T08:33:17.690Z]: undefined
[close | 2019-05-15T08:33:17.690Z]: false

If I check what sockets are open for my PID using ps aux | grep socket-test | grep -v grep | tr -s [:blank:] | cut -d' ' -f2 | tr -d '[:space:]' | xargs nettop -p, I can see the connection is established and then disappears pretty much immediately after sending SIGHUP.
Using TCP dump, I can also see that the final FIN packets are sent just about immediately (The . flag I think is just heartbeats. F is FIN):
tcpdump -i lo0 -n tcp and port 9092 and 'tcp[tcpflags] & (tcp-fin|tcp-rst|tcp-ack) != 0'
tcpdump: verbose output suppressed, use -v or -vv for full protocol decode
listening on lo0, link-type NULL (BSD loopback), capture size 262144 bytes
10:33:09.701798 IP <IP_ADDRESS>.9092 > <IP_ADDRESS>.52013: Flags [.], ack<PHONE_NUMBER>, win 6379, length 0
10:33:09.701865 IP <IP_ADDRESS>.52013 > <IP_ADDRESS>.9092: Flags [.], ack 1, win 6379, options [nop,nop,TS val 582780015 ecr 582776435], length 0
10:33:10.807175 IP <IP_ADDRESS>.9092 > <IP_ADDRESS>.52013: Flags [.], ack 1, win 6379, length 0
10:33:10.807289 IP <IP_ADDRESS>.52013 > <IP_ADDRESS>.9092: Flags [.], ack 1, win 6379, options [nop,nop,TS val 582781118 ecr 582776435], length 0
10:33:11.869113 IP <IP_ADDRESS>.9092 > <IP_ADDRESS>.52013: Flags [.], ack 1, win 6379, length 0
10:33:11.869181 IP <IP_ADDRESS>.52013 > <IP_ADDRESS>.9092: Flags [.], ack 1, win 6379, options [nop,nop,TS val 582782177 ecr 582776435], length 0
10:33:13.076164 IP <IP_ADDRESS>.9092 > <IP_ADDRESS>.52013: Flags [.], ack 1, win 6379, length 0
10:33:13.076197 IP <IP_ADDRESS>.52013 > <IP_ADDRESS>.9092: Flags [.], ack 1, win 6379, options [nop,nop,TS val 582783380 ecr 582776435], length 0
10:33:14.167058 IP <IP_ADDRESS>.9092 > <IP_ADDRESS>.52013: Flags [.], ack 1, win 6379, length 0
10:33:14.167131 IP <IP_ADDRESS>.52013 > <IP_ADDRESS>.9092: Flags [.], ack 1, win 6379, options [nop,nop,TS val 582784464 ecr 582776435], length 0
10:33:15.269185 IP <IP_ADDRESS>.9092 > <IP_ADDRESS>.52013: Flags [.], ack 1, win 6379, length 0
10:33:15.269215 IP <IP_ADDRESS>.52013 > <IP_ADDRESS>.9092: Flags [.], ack 1, win 6379, options [nop,nop,TS val 582785564 ecr 582776435], length 0
10:33:16.284796 IP <IP_ADDRESS>.9092 > <IP_ADDRESS>.52013: Flags [.], ack 1, win 6379, length 0
10:33:16.284835 IP <IP_ADDRESS>.52013 > <IP_ADDRESS>.9092: Flags [.], ack 1, win 6379, options [nop,nop,TS val 582786578 ecr 582776435], length 0
10:33:17.285907 IP <IP_ADDRESS>.9092 > <IP_ADDRESS>.52013: Flags [.], ack 1, win 6379, length 0
10:33:17.285941 IP <IP_ADDRESS>.52013 > <IP_ADDRESS>.9092: Flags [.], ack 1, win 6379, options [nop,nop,TS val 582787578 ecr 582776435], length 0
10:33:17.687335 IP <IP_ADDRESS>.52013 > <IP_ADDRESS>.9092: Flags [F.], seq 1, ack 1, win 6379, options [nop,nop,TS val 582787979 ecr 582776435], length 0
10:33:17.687380 IP <IP_ADDRESS>.9092 > <IP_ADDRESS>.52013: Flags [.], ack 2, win 6379, options [nop,nop,TS val 582787979 ecr 582787979], length 0
10:33:17.688757 IP <IP_ADDRESS>.9092 > <IP_ADDRESS>.52013: Flags [F.], seq 1, ack 2, win 6379, options [nop,nop,TS val 582787980 ecr 582787979], length 0
10:33:17.688821 IP <IP_ADDRESS>.52013 > <IP_ADDRESS>.9092: Flags [.], ack 2, win 6379, options [nop,nop,TS val 582787980 ecr 582787980], length 0
^C
20 packets captured
26 packets received by filter
0 packets dropped by kernel

I would have expected the socket to stick around for a few minutes before seeing the final FIN and ACK, but that's not what I'm seeing, so I must be misunderstanding something or I'm not testing it properly.

Closing this PR. It's good background information, but I'm not actively working on this at the moment.


Defer making new conversations until you post

[ ] This is for posting, will handle new convo's w/ attach after this gets approved

@keybase/react-hackers this defers making new conversations until after you try and post a message to the convo. This makes the flow from 'start a chat' to being in the chat much faster as it essentially does nothing.
This touches (sadly) a lot of code so please give this extra scrutiny, and (sadly) extra testing.

The commits a7614ea9c19e...f744c2b0a11b introduce visual changes on linux. :mag_right: 10 removed

Removed: Chat_Conversations_List-You_Rekey_Selected (view original)
Removed: Chat_Conversations_List-You_Rekey (view original)
Removed: Chat_Conversations_List-Selected_Normal (view original)
Removed: Chat_Conversations_List-Selected_Muted (view original)
Removed: Chat_Conversations_List-Part_Rekey_Selected (view original)
Removed: Chat_Conversations_List-Part_Rekey (view original)
Removed: Chat_Conversations_List-Normal (view original)
Removed: Chat_Conversations_List-Long_Top (view original)
Removed: Chat_Conversations_List-Long_Bottom (view original)
Removed: Chat_Conversations_List-Empty (view original)

The commits a7614ea9c19e...5781e2bc1e53 introduce visual changes on linux. :mag_right: 10 removed

Removed: Chat_Conversations_List-You_Rekey_Selected (view original)
Removed: Chat_Conversations_List-You_Rekey (view original)
Removed: Chat_Conversations_List-Selected_Normal (view original)
Removed: Chat_Conversations_List-Selected_Muted (view original)
Removed: Chat_Conversations_List-Part_Rekey_Selected (view original)
Removed: Chat_Conversations_List-Part_Rekey (view original)
Removed: Chat_Conversations_List-Normal (view original)
Removed: Chat_Conversations_List-Long_Top (view original)
Removed: Chat_Conversations_List-Long_Bottom (view original)
Removed: Chat_Conversations_List-Empty (view original)

I think it would be simpler to understand if pending convs were a map from pendingConvIDKey -> List

sweet, using _getInboxAndUnbox cleans this up a bunch tnx!

@MarcoPolo ready for further review, also added attachment support

Pending is sent in separately
On Thu, Feb 16, 2017 at 6:36 PM Marco Munizaga<EMAIL_ADDRESS>wrote:

@MarcoPolo approved this pull request.
In shared/actions/chat.js
https://github.com/keybase/client/pull/5884#discussion_r101652275:

@@ -575,7 +575,7 @@ function * _startNewConversation (conversationIDKey: ConversationIDKey) {
yield put(selectConversation(newConversationIDKey, false))
}
// Load the inbox so we can post, we wait till this is done

yield call(_loadInbox, {payload: {onlyLoad: tlfName}, type: 'chat:loadInbox'})

yield call(_getInboxAndUnbox, {payload: {conversationIDKey: newConversationIDKey}, type: 'chat:getInboxAndUnbox'})

🐑 type the argument here like: call(_getInboxAndUnbox, ({payload ...}:
Constants.GetInboxAndUnbox))
In shared/reducers/chat.js
https://github.com/keybase/client/pull/5884#discussion_r101654354:

 // Re-add any always show inbox items that aren't already there

 const pending = existingRows.filter(row => {

   const id = row.get('conversationIDKey')

   return row.get('alwaysShow') && !rows.find(r => r.get('conversationIDKey') === id)

 })

 const newInbox = sortInbox(rows.concat(pending))

You didn't need to do anything like this?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/keybase/client/pull/5884#pullrequestreview-22388657,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAfhUzV43C9N5IQZA0oBjOny8VSi7YC6ks5rdN1-gaJpZM4MCW6A
.


feature - create confirm order ui

Github Issue URL/Tags (required)
What's this PR do? Please give a technical summary (required)

[x] edit detail UI
[x] edit comment UI
[x] Create confirm order UI

Any references (stackoverflow …) (optional)

:+1: There are no linter violations.


Add support for DigitalOcean Spaces s3

DigitalOcean offers a service called "spaces" that is nothing more than a resale of the famous AWS S3. AdonisJS would probably support DigitalOcean spaces if it were not for a preconfigured URL
Example of s3 endpoint provided by DigitalOcean
Endpoint: nyc3.digitaloceanspaces.com
Bucket: ms2
Access key: ---
Secret access key: ---

When I try to use the service, I have this return
https://s3.nyc3.digitaloceanspaces.com.amazonaws.com/ms2/official/css/store.css

Is it possible to leave this generic configuration entry so that it can accept this service?

Done.
https://github.com/adonisjs/docs/pull/294
https://github.com/adonisjs/adonis-drive/pull/14

@clayderson do you have sample for ACL? it seems DO spaces default is private and need to setup it as public. thanks.


Testground setup

Maybe we can close this @dryajov as we are not going with Testground?

Closing in favor of https://github.com/codex-storage/cs-codex-dist-tests


Disable Alternate and Positive Actions if List Name is Empty

Do not let the user create new lists if a name has not been provided.
Also remove validation in reducer checking if list length is less-than or equal to 0.

Closing in favor of #116


update removeDuplicateTabs to ignore non-editor tabs

Example of a non-editor tab: The table of contents

Instead of hardcoding 'editor', could we use EditableFileView?
if (leaf.view instanceof EditableFileView) {

@o02c good point, works just as well!


@var hints in method declaration

We should be able to set variable types in a method declaration to override inferred types. For instance;
phan> cat 0.php                                                                                amorrison
<?php
function f() : null {
    return new DateTime();
}

/** @var DateTime $var */
function g() :int {
    $var = false;
    $var = f();
    return $var->getOffset();
}
print g() . "\n";

should treat $var as a DateTime despite f() being defined as returning null.

The following had been in the README given that @rlerdorf had implemented this feature in his initial version, but was forgotten in this implementation. It should be added back in once this feature is added.
Dealing with dynamic code that confuses the analyzer
There are times when there is just no way for the analyzer to get things right.
For example:
<?php
function test() {
	$var = 0;
	$var = call_some_func_you_cant_hint();
	if(is_string($var)) {
		$pos = strpos($var, '|');
	}
}

Your best option is, of course, to go and add a /** @return string|array */ comment to
the call_some_func_you_cant_hint() function, but there are times when that is not an
option. As far as the analyzer is concerned, $var is an int because all it sees is the
$var = 0; assignment. It will complain about you passing an int to strpos(). You can
help it out by adding a @var doc-type comment before the function:
<?php
/**
 * @var string|array $var
 */
function test() {
	//...
}

This tells the analyzer that along with the int that it figures out on its own, $var can
also be a string or an array inside that function. This is a departure from the normal use of the
@var tag which is to give properties types, so I don't suggest making a habit of using this hack.
But it can be handy to shut up the analyzer without having to refactor the code to not overload the
same variable with many different types.

Related to https://github.com/etsy/phan/issues/99

Can we populate type hints from return expressions? In the given example return-populated type hint should help without explisit @var notations.

We could add return-populated type hints to functions even they do not match the function signature

@morria just a note. @var is also allowed within functions/methods
function g() :int {
    /** @var DateTime $var */
    $var = false;
    $var = f();
    return $var->getOffset();
}

Wrong issue # in the comment, but https://github.com/etsy/phan/commit/61771fd9183efd82170e28ad5fff0970f538591f closes this issue.


Move NetHandler initialization to be static and not per thread.

This addresses issue #2761. As usual, fixing that lead to other related issues that needed to be fixed.

Rather than scheduling an event, the initialization logic should be moved in to the thread spawn initializer or a global initialization. This guarantees (as the event triggered approach does not) that all thread data is initialized before the NetHandler executes. It also seems a bit baroque to trigger an event to call code that could just as easily be called directly or incorporate.
The configuration update isn't thread safe - the updates are dispatched from a random thread across all NetHandler instances without locks, so a value could be updated in the middle of a computation.
The changes here all address one or both of these issues. The base configuration and update was moved to a global structure to avoid race conditions. When that is updated, events are sent to the NetHandler instances to update their local state. Because this is done in an event it will be done at a point where it is safe to do so.

After much pondering, I decided to take a somewhat different approach. I did not like the enum / array style, it made (IMHO) interacting with the configuration values annoying. I think this is the best compromise - it keeps the separate configs but avoids the casting.


Train arch_parameters with validation data?

Thank you for sharing such beautiful implement.
I'm sorry, but I have a question about why arch_parameters are trained with validation data.
In ./cnn/architect, the _backward_step function computes loss for arch_parameter updates with validation data (i.e. input_valid, target_valid). Should not we train arch_parameters with train data and search the proper architecture on validation data?

ahh... I just make a misunderstanding. The alpha_normal / alpha_reduce should be the actions to search.

Thank you for sharing such beautiful implement.
I'm sorry, but I have a question about why arch_parameters are trained with validation data.
In ./cnn/architect, the _backward_step function computes loss for arch_parameter updates with validation data (i.e. input_valid, target_valid). Should not we train arch_parameters with train data and search the proper architecture on validation data?

Good question! I'm also confused with this question. Could you please explain more? I think the validation set should be not be used to update the architecture parameters.

Well, the same misunderstanding. The code shows that the architecture weights are updated with training data, and the hyperparameters (i.e., alpha_normal / alpha_reduce) are searched on validation data.

Well, the same misunderstanding. The code shows that the architecture weights are updated with training data, and the hyperparameters (i.e., alpha_normal / alpha_reduce) are searched on validation data.

See the val_queue in the code, which is using part of the training data, not the real validation data.

See the code where defines the dataset,
dset.CIFAR10(..., train=True ... )

This is using the training data, and the valid_queue is only part of the training data.


Resource Item as Label

Allows a user to get a label using the DisplayTemplate Label endpoint
Updates the ApiClient to support header and file type overrides for get requests, as well as more accommodation for our Item Label resource. At some point, it would be good to update the other request functions to be in line with these updates.
Would appreciate feedback on how this could all be improved

@timothydc I'd love your feedback on this & #21 when you get a moment :)


treatment of loops

Treat loop as a a kind of sequential syringe pump. Can look up attached devices. need loading and dispensing capability. Both entails valve switching and activating one of 2 pumps.

Note saved to repo in fd2006a635f, closing for now. This will be part of the automatic graph router.


leemeans is translating <command-line-heroes-season-1-crack-the-cloud-open.md>

leemeans is translating <command-line-heroes-season-1-crack-the-cloud-open.md>

改好了


Test keyboard navigation with bluetooth keyboard on iOS 13

Related to https://github.com/phetsims/phet-core/issues/64, platform.mobileSafari won't work anymore for iOS 13. We hid the keyboard help dialog on mobile safari because bluetooth keyboard navigation didn't work, tab navigation and keycode reporting were broken.
Apple's decision to be more "desktop like" may indicate this problem has been fixed.
It would be helpful to test a bluetooth keyboard with iOS 13 and see if keyboard nav works. If it does, then all is well.
If it is still broken, we will need to either decide whether we are OK with the keyboard help button showing up while Bluetooth keyboards don't work or find another solution.
@KatieWoe said she has access to iOS 13 but not a bluetooth keyboard. @oliver-phet @ariel-phet do you know if we have one around the offices or would it be possible to get one to test?

I gave @KatieWoe the bluetooth keyboard that was in the dev office. Hopefully that works!

Looks good

Thats great, thanks! @KatieWoe can you comment on what was tested? For instance, were you able to tab to the balloon in https://phet-dev.colorado.edu/html/balloons-and-static-electricity/1.4.12-rc.2/phet/balloons-and-static-electricity_en_phet.html and pick it up/move it around?

Yeah, that's pretty much exactly what I did, just to make sure it worked.  Let me know if you want more thorough testing.

Nope, I think thats perfect. Thanks for checking!


Proposal: allow select all text in AutoSuggestBox like TextBox

Proposal: [allow select all text in AutoSuggestBox like TextBox]

Summary

Rationale

AutoSuggestBox is based on TextBox, so it should be allowed to select all text

Scope

Capability
Priority

This proposal will allow developers to accomplish W
Must

This proposal will allow end users to accomplish X
Should

This proposal will allow developers to accomplish Y
Could

This proposal will allow end users to accomplish Z
Won't

@zhuxb711 Do you mean adding a SelectAll() API to the AutoSuggestBox? (You can already select all the text in a AutoSuggestBox per click interactions like with a TextBox today.)

@Felix-Dev Yes, but I could not found SelectAll() in AutoSuggestBox

Any progress ?

@zhuxb711 AutoSuggestBox is still in the OS for now so the community is currently unable to add such a method to its API surface (and the team is busy with WinUI 3). For now, you could write a helper method which obtains the internal TextBox of the AutoSuggestBox and call the TextBox.SelectAll() method on it.

@Felix-Dev Got it, thanks.


Question about the the role of ZK in Euler

Thanks for the excellent project!
I have a question about ZK,

It seems that you didn't use it for GraphEngile failover/replica, just uses it as a naming service to make client can get the GraphEngine Server address.  Is my understanding correct ?
Or it depends on the parameter, there will be multiple replicas when worker_num > shard_num?

Thanks in advance~

The second point is correct. There will be multiple replicas when worker_num > shard_num. But this is not in the default run loop.

thanks your explanation!


feat: merge statistics script

Adds a Python script called merge_statistics.py that builds from merge_analyzer.py and creates a CSV with the following information

Number of files in base -> left union base -> right.
Number of intersecting files between base -> left and base -> right.
Number of hunks between left and right.
Number of lines between left and right.
Number of intersecting lines between left and right.
Whether imports are involved.
Whether non-java files are involved.

Usage:
python3 merge_statistics.py --merges_path <path_to_merges>
                            --output_dir <output_dir>

@kjy5 d088209 introduced a test failure due to imports.  I might have just fixed it, but if not, could you take a look?

@kjy5 CI is now failing for a non-trivial reason.  Could you take a look at the differences (say, in the number of lines of diff) in the "small test" to determine whether the new values are an improvement or not?


chore: release 2.9.0

:robot: I have created a release *beep* *boop*
2.9.0 (2024-04-15)
Features

add redundancy options (#487) (0452759)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/ethersphere/swarm-cli/releases/tag/v2.9.0 :sunflower:


GH-34417: [C++][Flight] Upgrade OpenTelemetry SemanticConventions header

Rationale for this change
This is required for compatibility with opentelemtry-cpp 1.8.2 (released 2023-01-31) and beyond.
What changes are included in this PR?
Replaced experimental header with stable one. Added a version guard to our CMake build to enforce minimum version of opentelemtry-cpp that has this header.
Are these changes tested?

[ ] Built locally with minimum version of opentelemtry-cpp.

Are there any user-facing changes?
Yes, this increases the minimum version of opentelemtry-cpp.

Closes: #34417

🤦
https://github.com/open-telemetry/opentelemetry-cpp/blob/3ef579bca397817358c06a55761b17091d2af8bd/CHANGELOG.md?plain=1#L203-L213


Mod breaks Turret, Mine and Airlock commands

With this mod enabled, using the 2-letter commands like "C1" etc. throws an error in the bepinex console, and the terminal textbox doesn't clear.
So with this mod enabled I have to use Backspace to delete the input after every disabled turret, making the job of a terminal operator very frustrating. volvo plz fix

[Error  : Unity Log] NullReferenceException: Object reference not set to an instance of an object
Stack trace:
RouteRandom.Patches.TerminalPatch.RouteToRandomPlanet (TerminalNode __result, Terminal __instance) (at <efbf82379e834cfcbcb11fd944eeac50>:IL_0001)
(wrapper dynamic-method) Terminal.DMD<Terminal::ParsePlayerSentence>(Terminal)
Terminal.OnSubmit () (at <af9b1eec498a45aebd42601d6ab85015>:IL_0060)
UnityEngine.Events.InvokableCall.Invoke () (at <e27997765c1848b09d8073e5d642717a>:IL_0010)
UnityEngine.Events.UnityEvent`1[T0].Invoke (T0 arg0) (at <e27997765c1848b09d8073e5d642717a>:IL_0049)
TMPro.TMP_InputField.SendOnEndEdit () (at <9baa8119dbcd498f902c1a92f10843c1>:IL_000E)
TMPro.TMP_InputField.ReleaseSelection () (at <9baa8119dbcd498f902c1a92f10843c1>:IL_001B)
TMPro.TMP_InputField.DeactivateInputField (System.Boolean clearSelection) (at <9baa8119dbcd498f902c1a92f10843c1>:IL_00B0)
TMPro.TMP_InputField.OnUpdateSelected (UnityEngine.EventSystems.BaseEventData eventData) (at <9baa8119dbcd498f902c1a92f10843c1>:IL_007C)
UnityEngine.EventSystems.ExecuteEvents.Execute (UnityEngine.EventSystems.IUpdateSelectedHandler handler, UnityEngine.EventSystems.BaseEventData eventData) (at <17de86d66286445fa95af59fa8fa644d>:IL_0000)
UnityEngine.EventSystems.ExecuteEvents.Execute[T] (UnityEngine.GameObject target, UnityEngine.EventSystems.BaseEventData eventData, UnityEngine.EventSystems.ExecuteEvents+EventFunction`1[T1] functor) (at <17de86d66286445fa95af59fa8fa644d>:IL_0067)
UnityEngine.EventSystems.EventSystem:Update()

I'm not a programmer and I don't know how to use github but I solved it for myself by adding this line of code:
if (__result != null)
{

just below the line:
public static TerminalNode RouteToRandomPlanet(TerminalNode __result, Terminal __instance) {
.
Author pls review and implement if it's okay, I think it's a big issue when turret disabling commands don't get deleted so you can't quickly turn off different turrets in a sequence.

Closing as fixed


Error thrown when resizing the window

When I resize the window I get an error
TypeError: Failed to execute 'getComputedStyle' on 'Window': parameter 1 is not of type 'Element'.

This error does not seem to affect the functionality in my use case, but the error is thrown for each resize event fired.
I assume this is coming from the code below, but I don't understand how window could be undefined when I'm manually resizing my browser window.
https://github.com/n3r4zzurr0/react-range-slider-input/blob/aebeef05d853caeed5e81fd6d7ba315665b6c030/src/lib/components/RangeSlider.js#L357-L369
chrome_0leDrxZjEX.webm
I'm using next.js and this error happens in development and production.

The problem was that the global event listeners weren't being removed on unmounting. I have pushed an update that fixes this issue.


WIP: firefox/wrapper.nix: make firefox wrapper configurable by the user

Motivation for this change
This is a proof of principle for allowing firefox and its variants to be customized and extended more easily.
Could be a first step towards solving #15959.
Very WIP at the moment.

This pull request has been mentioned on Nix community. There might be relevant details there:
https://discourse.nixos.org/t/firefox-extensions/1122/39

I don't think we should expose extensions as a separate config option as long as they are imperative instead of declarative, given that they so thoroughly violate the expectations usually put upon modules and packages.
I barely know what I'm talking about, but maybe user namespaces with bind mounts are something we would want to look into to provide declarative extensions without having to hack around in Firefox itself.

I am not quite sure what you mean by extensions being "imperative" in this context.
The option as it is now, works as follows:
You can specify either a local xpi file or an url (e.g. https://addons.mozilla.org/firefox/downloads/file/1189923/noscript_security_suite-latest-fx.xpi) from which the xpi will get download. Then the policies engine will ensure that the extension is installed (on startup).
We could make it more declarative by using "Locked" perhaps, this will prevent the real state diverging from the one as specified in the config.
See the docs here

user namespaces with bind mounts are something we would want to look into to provide declarative extensions without having to hack around in Firefox itself.

This was actually my first approach, and I have an implementation using user namespaces and bind mounts in my own nixos config. I did not attempt to upstream that, because its quite "advanced" technology; nixpkgs is more than just linux. I just don't know if that works on all platforms we might want to support.

Imperative means it will permanently install these to your home directory instead of being confined to the package, as a package option should be. Maybe I am alone in this concern but that doesn't seem very compatible with the Nix philosophy.
If you've already got the bindmount solution working, maybe we want to provide a wrapper with that specifically for Linux? Anyone not on Linux could still choose to permainstall extensions via the policy even if it wasn't exposed as a separate option.

Ah ok, I see what you mean by imperative vs declarative now.
Ok, maybe we should Indeed do some work on the extensions option.
But this can be done with policies (there is also an Uninstall option).

But this can be done with policies (there is also an Uninstall option).

For that you would need to calculate the new policy at runtime from the policy of the most recently executed version. I don't even want to begin to imagine the complexity involved. That would be hard in a NixOS option, and it sounds like just asking for trouble in a package option.

Yes, that does sound rather complicated. Also there are still quite a few bugs in the current implementation of the related policies options.
I will remove the extensions option from this pull request for now. The remaining stuff is still useful on its own.
Maybe we could include a hint in the docs that extensions can be included in the extraPolicies option, mentioning the imperative nature of this approach.

Actually, do we have a place for documentation of individual package options?

Not really, but it would probably fit next to the vim section in the manual: https://nixos.org/nixpkgs/manual/#users-guide-to-vim-pluginsaddonsbundlesscripts-in-nixpkgs

Ok, I ended up adding the docs to package-notes.xml. But we really need a separate manual for packages / package options.

@xaverdh reading the patches, I wonder, is there any reasons to not copy everything over to the new directory?
Knowing that you can uncompress the tarball anywhere you want, I would expect the build result to be position independent of its top-level directory. Making a copy (maybe hard-link) could be a simpler way than selecting the few files which are mandatory.

The actual runtime is position independent (on linux at least). The wrapper is not (there is already a wrapper coming from the firefox-unwrapped derivation), so that path and the symlink have to be rewritten. I went for symlinks instead of hardlinks, because I did not want to make assumptions on the file system used, etc. Also how would using hard links simplify anything really?
Making a recursive copy would simplify the code somewhat I guess, at the cost of using more memory.

So maybe if we could change firefox-unwrapped to not wrap the binary (e.g. move that code to the actual wrapper), this could be simplified a lot.
I don't know how to do that in detail though.

@samueldr So based on the wrapper from @xaverdh I have added extension support and a lot of anti tracking / speed improvements for firefox. If this gets merged I can then open a new pull request.
If someone is interested the wrapper is here: https://github.com/Luis-Hebendanz/nix-configs/blob/master/overlays/firefox-with-config.nix
And an example usage is here: https://github.com/Luis-Hebendanz/nix-configs/blob/master/firefox.nix

Closing since https://github.com/NixOS/nixpkgs/pull/91724 was merged


make typescript support cva with generic included

Description

Additional context
thanks for the library, sorry for not following the template. It fixes the regex so that it supports tailwind autocomplete while using generics in cva function

What is the purpose of this pull request?

[x] Bug fix
[ ] New Feature
[ ] Documentation update
[ ] Other

Before submitting the PR, please make sure you do the following

[ ] Read the Contributing Guidelines.
[ ] Follow the Style Guide.
[x] Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
[x] Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).

while using generics in cva function

Hey! Could you elaborate on this please? cva isn't designed to accept generics. The current implementation is really for internal use only

Appreciate your efforts and detailed breakdown, but I'm going to close this as generics aren't supported (maybe I need to find a way to make this clearer)
Thanks again!


Question 7 code block - remove unnecessary usage of 'use client'

Note ErrorBoundary is a client component. You can only pass props to it that are serializeable or use it in files that have a "use client"; directive.

Didn't check the docs of Error boundary, my mistake.


Fix issue with Chain Selector not stopping after selector change.

Fixes #358
Proposed Changes

Fixed issue with Chain Selector, where Selection wasn't properly completed if user switched to another Selector without first clicking Stop/Loop button.

@jszemplinski resolve conflicts and merge it please :)


Modules not found: crypto, cipher-base, hash-base

Expected behavior

I updated angular and my simple tutorial project with steem-js wont compile
Actual behavior

I get:
ERROR in<EMAIL_ADDRESS>Module not found: Error: Can't resolve 'crypto' in '\steemit\test-steemjs-ng6\steemit-api\node_modules@steemit\rpc-auth\lib'
ERROR in ./node_modules/cipher-base/index.js
Module not found: Error: Can't resolve 'stream' in '\steemit\test-steemjs-ng6\steemit-api\node_modules\cipher-base'
ERROR in ./node_modules/hash-base/index.js
Module not found: Error: Can't resolve 'stream' in '\steemit\test-steemjs-ng6\steemit-api\node_modules\hash-base'
i ｢wdm｣: Failed to compile.
How to reproduce
Not sure.

Environment information

node version: 8.11.1
npm version: 5.6.0
Any help much appreciated

This can be solved by  using:  npm install crypto --save

@tomobrien2004 The crypto module is deprecated.

I resolved using this solution:
https://gist.github.com/niespodd/1fa82da6f8c901d1c33d2fcbb762947d
Probably not the best way but it worked.


added the 3325-S motion sensor and the 4257050-RZHAC plug

as noted in https://github.com/Koenkk/zigbee2mqtt/pull/753, Centralite is the OEM for both the 2015 smartthings motion sensor and wall plug module. It appears that the Iris zigbee module is very similar (internally, at least; external shells are different!) and the wall plug is also very similar to the already supported Centralite Swiss Plug / 4256251
I have been using both of these devices with the configuration in this PR the past few days w/o any significant issues.

Thanks!

Can you provide a link to a picture of both devices? (from internet, to be used in the supported devices page).
How are both products labeled? As centralite or smartthings?

@Koenkk
Sure thing.  the 4257050-RZHAC looks identical to the picture you're already using here: https://koenkk.github.io/zigbee2mqtt/images/devices/4256251-RZHAC.jpg
It is labeled with Centralite on the back.
The motion sensor can be seen here:
https://support.smartthings.com/hc/en-us/articles/212204223-Which-SmartThings-Motion-Sensor-model-do-I-have-
Specifically: https://support.smartthings.com/hc/en-us/article_attachments/205642783/SamsungSmartThingsMotionSensor2015model.png
It does not have obvious centralite markings:
Product sticker on the back will say, "SmartSense Motion Designed by SmartThings"

Great, thanks!


TypeError: Cannot read property 'appname' of undefined

after "firebase deploy" this error shows up :
Error: Error occurred while parsing your function triggers.
TypeError: Cannot read property 'appname' of undefined
at Object. (C:\Users\SUBHAM\firestore-social-backend\functions\dist\index.js:1:5536)
at r (C:\Users\SUBHAM\firestore-social-backend\functions\dist\index.js:1:155)
at Object. (C:\Users\SUBHAM\firestore-social-backend\functions\dist\index.js:1:4766)
at r (C:\Users\SUBHAM\firestore-social-backend\functions\dist\index.js:1:155)
at C:\Users\SUBHAM\firestore-social-backend\functions\dist\index.js:1:954
at Object. (C:\Users\SUBHAM\firestore-social-backend\functions\dist\index.js:1:964)
at Module._compile (internal/modules/cjs/loader.js:776:30)
at Object.Module._extensions..js (internal/modules/cjs/loader.js:787:10)
at Module.load (internal/modules/cjs/loader.js:653:32)
at tryModuleLoad (internal/modules/cjs/loader.js:593:12)

duplicate (#1 )


hide update and history buttons option

Add an option to hide update and history buttons in nivagation bar

Instead of hiding, make the option move it to More, then I will merge

Instead of hiding, make the option move it to More, then I will merge

done

It will be merged before the next build 👍

Oooh so notbad too https://github.com/jobobby04/TachiyomiSY/issues/276

@jobobby04

Instead of hiding, make the option move it to More, then I will merge

maybe it's better to add them to the library?

Forgot to merge it, whatever ill just merge it after the check is done

@jobobby04

Instead of hiding, make the option move it to More, then I will merge

maybe it's better to add them to the library?

as optional settings an alternative More

No that wouldnt work out well, they would just hog the limited space

@jobobby04 ?

@jobobby04 maybe do made a double-click on the History to open the Updates, only when Updates is hidden? (how Downloads open when you click on Updates)


Request: Custom markers for skipping outro

First of all, thanks for the good work. I am using the containerized version and it works perfectly!
One thing that would greatly improve upon the existing features would be to allow "negative" values for the custom markers. For example, most shows have the same outro sequence so we could essentially add to the custom.json markers for specific shows / seasons to skip to the next episode when there is X amount of milliseconds left.

3f53fefee8d0ce7111d05eaa17e9c18c34baa771
That should do it
If you set start to 0 it will assume the start as before, but setting end to 0 will assume the full duration of the media
Here's a sample that skips the first 20 seconds and the last 20 seconds
    "markers": {
        "tmdb://32726": [
            {
                "start": 0,
                "end": 20000
            },
            {
                "start": -20000,
                "end": 0
            }
        ]
    },

Additionally if plex adds any outro detection in the future that should already be supported by adding 'outro' or whatever equivalent to the tags option
I have seen some shows recently coming with an End Credits chapter so that can be added to the tags as well to skip that chapter
And finally there's the skip-last-chapter option which will skip the final chapter is present and it occurs within whatever final percentage of the media duration
So that should be a pretty robust set of outro options for you!

Damn, that was quick. Thanks so much. It seems like the scheduled docker publish run missed your changes by about 30 minutes. Whenever you have a chance, could you do a manual run there?
Also I have one last question, would this skip to the next media item (episode), or to the end of the current episode? Cause plex has this annoying 10 seconds countdown which I think is not customizable. It would be nice to be able to just skip to the next episode without waiting for it.

You can use the PAS_UPDATE environment variable and then just restart the container to get the latest git pull
For now it just seeks to the end but I can look into doing a "next" type command

Ah nice, don't know how I missed that. That's great, works as expected now.
Yeah if you find any time to look into that it would be awesome. I think this is a separate request though, I will close this issue.

170a7af2919620afa5e631354c28bc30fe5c2b38
Added a next option to the skip section that will mark the media as watched and trigger a 'skipNext' API call if the media its monitoring has reached its end or if the skip target is the end, default is False so set that True if you want that behavior

Amazing, how kind of you! Thanks.. :)

Let me know if there's any issues but it seems to be working on my testing

I tested it as well. Works perfectly!


Ordering column that's a relation, changes id in action links

Hello,
Summary of problem or feature request
I have a table of users, where the last column is a relation (company name). Meaning my getColumns array has one key as following:
 'company_id' => 'company.name',

I also have a custom partial to add actions, in my ajax method:
->addColumn('action', 'user::admin.partials.installers_datatables_actions')

This is the content of the partial, nothing fancy, just view/edit/delete buttons:

    <button class="btn btn-danger btn-flat" data-toggle="modal" data-target="#modal-delete-confirmation" data-action-target="{{ route('admin.user.installer.destroy', [$id]) }}"></button>

On display this works perfectly, no issues.
However, when filtering on the company name it changes the $id variable in the action partial to the id of a company for that row.
This obviously is an issue since the view/edit/delete buttons are no more pointing to the correct ID (user id).
Expected behaviour
When ordering on the company.name column, the $id should still be the id of the main data (user id in this case)
System details

Operating System: Ubuntu 14.04
PHP Version: 7.0.5
Laravel Version 5.1.34
Laravel-Datatables Version: 6.10.1

Have I missed some option/config somewhere so that it keep using the correct $id on the row ?
Thank you!

@nWidart, you need to specify the selected field on your main model when using relationships to avoid this issue. I also encountered this and thus I updated the demo and added a note like below:
// It is advised that you include select('table.*') on query to avoid weird issues where id from related model replaces the id of the main model.
$posts = Post::with('user')->select('posts.*');

Hello,
Thank you, adding ->select('users.*') did indeed fix the swapping of ID issue. (although not fixing #522)

2 app developers that i'd love chat in this issue >.<

// It is advised that you include select('table.') on query to avoid weird issues where id from related model replaces the id of the main model.
$posts = Post::with('user')->select('posts.');
I think this info must be in main documentation https://yajrabox.com/docs/laravel-datatables/master/relationships
Becose i spent 4 hours to find this topic

@3s777 thank you for the feedback. Docs can be updated on this repo. Can you please send a PR?

how to aplly select with applyScopes ?


AOL extractor broken

[x] I've verified and I assure that I'm running youtube-dl 2016.04.06
[x] At least skimmed through README and most notably FAQ and BUGS sections
[x] Searched the bugtracker for similar issues including closed ones

What is the purpose of your issue?

[x] Bug report (encountered problems with youtube-dl)

youtube-dl -v http://on.aol.com/video/meredith-amelia-are-sisters-again-5707f7f6e4b09a6ef926105a
[debug] System config: []
[debug] User config: []
[debug] Command-line args: [u'-v', u'http://on.aol.com/video/meredith-amelia-are-sisters-again-5707f7f6e4b09a6ef926105a']
[debug] Encodings: locale UTF-8, fs utf-8, out UTF-8, pref UTF-8
[debug] youtube-dl version 2016.04.06
[debug] Python version 2.7.11 - Darwin-15.3.0-x86_64-i386-64bit
[debug] exe versions: ffmpeg 3.0.1, ffprobe 3.0.1, rtmpdump 2.4
[debug] Proxy map: {}
[generic] meredith-amelia-are-sisters-again-5707f7f6e4b09a6ef926105a: Requesting header
WARNING: Falling back on generic information extractor.
[generic] meredith-amelia-are-sisters-again-5707f7f6e4b09a6ef926105a: Downloading webpage
[generic] meredith-amelia-are-sisters-again-5707f7f6e4b09a6ef926105a: Extracting information
[5min] 5707: Downloading embed page
[5min] 5707: Downloading JSON metadata
ERROR: 5min said: We're sorry, but the video you are trying to watch does not exist.
Traceback (most recent call last):
  File "/usr/local/bin/youtube-dl/youtube_dl/YoutubeDL.py", line 669, in extract_info
    ie_result = ie.extract(url)
  File "/usr/local/bin/youtube-dl/youtube_dl/extractor/common.py", line 323, in extract
    return self._real_extract(url)
  File "/usr/local/bin/youtube-dl/youtube_dl/extractor/fivemin.py", line 125, in _real_extract
    expected=True)
ExtractorError: 5min said: We're sorry, but the video you are trying to watch does not exist.

...
<end of log>

Description of your issue, suggested solution and other information
A few days ago the AOL On website (which always worked great in youtube-dl) was refreshed which changed their URL's including video URL's. It appears to have switched from "5min" to "vidible" but the actual video formats and resolutions seem to have remained identical. So I think it's mostly just a name change / URL update?
Example URL: http://on.aol.com/video/meredith-amelia-are-sisters-again-5707f7f6e4b09a6ef926105a
The direct video link should be like this (got it from the website "savevideo.me" ):
http://cdn.vidible.tv/prod/2016-04/08/5707f7f6e4b09a6ef926105a_1920x1080_v1.mp4?hdnea=exp=1460269904~acl=/*~hmac=cc5efbd5cb9288ab1b7b4583c9028407cf6d367cfd7184c856e9f106479e1e01
AOL is one of the larger video sites, they host/syndicate videos for many television networks (NBC,ABC,MSNBC, etc) and whatnot. It doesn't require an account and isn't geo-blocked as far as I know.
Hoping someone can update the extractor to get it working again. Thanks!

will be fixed in the next version.

Hi @remitamine thank you very much for the fast fix. There is still one issue however, it does not work on all of the same URL's that it did before.
For example I usually access site from links like this ("channels"):
http://on.aol.com/partner/abc-518421766
http://on.aol.com/partners/nbc-518886504
http://on.aol.com/partners/access-hollywood-519021709
http://on.aol.com/nbcu
This will be a common scenario since that is the type of url's you most often get when navigating their site (on AOL On homepage, in the main navigation bar at top, goto Channels -> NBCU).
Better explanation:
This URL does not work:
http://on.aol.com/partners/abc-551438d309eab105804dbfe8/sneak-peek-was-haley-really-framed-570eaebee4b0448640a5c944
This URL does work (same video, same website, just different URL):
http://on.aol.com/video/sneak-peek-was-haley-really-framed-570eaebee4b0448640a5c944
Here is output of the failed one, it is still attempting 5min:
iMac:Desktop Sean$ youtube-dl -v http://on.aol.com/partners/abc-551438d309eab105804dbfe8/sneak-peek-was-haley-really-framed-570eaebee4b0448640a5c944
[debug] System config: []
[debug] User config: []
[debug] Command-line args: [u'-v', u'http://on.aol.com/partners/abc-551438d309eab105804dbfe8/sneak-peek-was-haley-really-framed-570eaebee4b0448640a5c944']
[debug] Encodings: locale UTF-8, fs utf-8, out UTF-8, pref UTF-8
[debug] youtube-dl version 2016.04.13
[debug] Python version 2.7.11 - Darwin-15.3.0-x86_64-i386-64bit
[debug] exe versions: ffmpeg 3.0.1, ffprobe 3.0.1, rtmpdump 2.4
[debug] Proxy map: {}
[generic] sneak-peek-was-haley-really-framed-570eaebee4b0448640a5c944: Requesting header
WARNING: Falling back on generic information extractor.
[generic] sneak-peek-was-haley-really-framed-570eaebee4b0448640a5c944: Downloading webpage
[generic] sneak-peek-was-haley-really-framed-570eaebee4b0448640a5c944: Extracting information
[5min] 570: Downloading embed page
[5min] 570: Downloading JSON metadata
ERROR: 5min said: We're sorry, but the video you are trying to watch does not exist.
Traceback (most recent call last):
  File "/usr/local/bin/youtube-dl/youtube_dl/YoutubeDL.py", line 671, in extract_info
    ie_result = ie.extract(url)
  File "/usr/local/bin/youtube-dl/youtube_dl/extractor/common.py", line 341, in extract
    return self._real_extract(url)
  File "/usr/local/bin/youtube-dl/youtube_dl/extractor/fivemin.py", line 125, in _real_extract
    expected=True)
ExtractorError: 5min said: We're sorry, but the video you are trying to watch does not exist.

This URL does not work:
http://on.aol.com/partners/nbc-518886504/ge-fallonventions-project-maverick-570d0f31e4b00f7a95994bc4
This URL does work (same video, same website, just different URL):
http://on.aol.com/video/ge-fallonventions-project-maverick-570d0f31e4b00f7a95994bc4
Cause and Solution
This is the part of the URL that is causing issues:
/partners/abc-551438d309eab105804dbfe8/
/partners/nbc-518886504/
replace with this:
/video/
and it will work. So basically the problem is it works with /video/ but not the other URL's I mentioned. I can work around this for now by renaming the URL but it would be nice if that wasn't necessary.
Hopefully you can add support for these type of URL as well? And once again thank you :)

the extractor will match video only urls,
channel and show pages should be handled differently.

Maybe I am a little confused but those are in fact video urls? if you go to abc or nbc "channel" pages that I linked it automatically redirects to their most recent video and starts playing it. It's the same behavior as regular video only urls. same exact video, same exact domain, just slightly different url.
it's kind of similar to how YT videos have two different links (youtube.com or youtu.be)
i think that /partners/*/ should also be valid matching url in this case


Use backtrace from dmlc-core (dmlc::stack_trace())

remove code duplication
demangle C++ symbols

https://github.com/dmlc/dmlc-core/pull/336

On other PR it was decided that printing dmlc stacktrace function was desired? I remember you mentioning that withjout a macro this would happen:
/workspace/scala-package/init-native/linux-x86_64/target/libmxnet-init-scala-linux-x86_64.so(_ZN4dmlc10StackTraceB5cxx11Ev+0x1bd

@cjolivier01 yes, it can be tested.

You are not updating dmlc-core in this PR. Is it already updated and contains StackTrace?

Yes, I checked, and CI wouldn't pass otherwise.


Randomize seeds for chain states better

shell/main.py initializes the crosscat engine with args.seed, which in
EngineTemplate.init generates a general_utils.int_generator, which
at the moment generates consecutive integers. These are used by
LocalEngine.get_initialize_arg_tuples to generate seeds for the States
which are used to store the MCMC states at each iteration.
This potentially seems like a pretty serious problem: Suppose I start
bayesdb --seed=0, and run a calculation with 60 chains. Then I rerun the
calculation with --seed=1. All but one of the 60 new chains will have
been initialized with a seed used in the prior run.
The same issue applies to programmatic use of crosscat/bayeslite.
This patch corrects that issue by having int_generator yield values from
an RNG instead.

Why do you want to pass in 'anything that supports randint'?

It's more flexible that way.

I don't see a problem with just using an internal Python random state here.

That is what's going to happen most of the time.  Are there any specific changes which need to happen for this to be merged?

I suggest you remove the extra generality unless there is a specific application requiring it.  Then you can remove the lock too and don't need to worry about breaking potential users of the extra generality if/when we change it later to use a better PRNG.

@gregory-marton, have your views on the lock changed?

I usually defer to @riastradh-probcomp, but in this case I see no harm in being more careful and more permissive than one absolutely needs to be. Seems like a good example of Postel's law.  LGTM.


Style Guide docs miss an exceptional case

The Style Guide concerning the order of class members say:

Order other class members in a way that makes sense
The methods, properties, and other members of a class should be in an order that will help readers understand how the class works.
If there’s a clear lifecycle, then the order in which methods get invoked would be useful, for example an initState method coming before dispose. This helps readers because the code is in chronological order, so they can see variables get initialized before they are used, for instance. Fields should come before the methods that manipulate them, if they are specific to a particular group of methods.

But if we look into the library, the build method comes last, as it's a lot easier to review and follow the code this way.
If build isn't considered part of the lifecycle, or if this is an exception to the rule, the style doc should be more specific about it.

Link : https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#order-other-class-members-in-a-way-that-makes-sense

This is fixed now, the build method is explicitly mentioned.


Port to Webpack, ES6 and Typescript

Must be feature parity with existing game.

We will use this starter pack https://github.com/rroylance/phaser-npm-webpack-typescript-starter-project


Why are bundles not supported in call center?

It is very frustrating to see that bundles are not supported in call center.  Direct sales companies need this feature... it is there in D365, but yet we have to re-create it as a customization... crazy.
You should explicitly state in the article why bundles are not supported on call center orders, and what options customers have instead that achieves the exact same functionality.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: c2e759b4-ee7e-56e5-6b32-3981042c6331
Version Independent ID: 7d1125a1-71b2-d0dc-f826-f9c472606223
Content: Revenue recognition bundles - Finance | Dynamics 365
Content Source: articles/finance/accounts-receivable/rev-rec-bundles.md
Service: dynamics-365-finance
Product: ****
Technology: ****
GitHub Login: @kweekley
Microsoft Alias: kweekley

@danielzook, thank you for the feedback.
@kweekley Please review and update the content as needed.

The call center sales order flow is different from the standard Accounts receivable sales order flow. Call center sales orders do not go through a confirmation step which is required for explosion of a bundle.


Extremely large ratios crash the audio system

Ratios that span tens of lines result in lines like NaNe+Infinity that crash AudioParams.

Related issue is that smaller ratios like<PHONE_NUMBER>99999999999/999999999999999999999 do not survive a round trip through the URL and even smaller ratios already suffer from reduced precision.

This is a tricky one. Currently thinking of using BigInt as an intermediary data type while attempting to convert to monzo. I don't think there's hope for fractions that leave too large a residue to represent as Fraction instances. Converting the app to use "BigFraction" is too much work and would slow the whole thing down needlessly.

After working a while on this there doesn't seem to be a way around changing all ratios to be expressed in terms of BigInt instances. It requires reworking everything to support that. I'll push this issue to a later release for now.
(Note to self: This means that residuals are changed to BigInt pairs, the components of extended monzos can remain as Fraction instances.)


Refactor murky_create.sh as python

Refactor murky_create.sh as Python code to preserve noarch status.

or `skip: true  # [win, osx]

Obsolete since the libmamba solver.  Maybe should deprecate then remove.


Python 2 compatibility (in my fork)

I have adapted unshortenit to be compatible with python 2.7 in a separate branch at my fork.
I can create a PR if the original developer @jkehler wants.

It didn't work as I expected, so I deleted it.


MySQL CreateTableGenerator workaround

Workaround for https://liquibase.jira.com/browse/CORE-1374.  This is probably not the best long term solution, but this will ensure the default dates/times that are actual dates and times (1970-01-01 00:00:00) will get passed as strings.  Currently, they are coming across as DatabaseFunction and thus go unquoted. Actual DatabaseFunctions, e.g. CURRENT_TIMESTAMP and NOW() will still get passed as functions. Same thing  with the ENUM datatype.
It should be noted that this workaround  is to make the values that are generated in my generated changelog work.
Also ENUMs are not properly parsed in the generated changelog for MySQL.  Should be enum('Y','N') gets parsed as enum(2), which will fail on table creation.  But I see that is addressed in https://liquibase.jira.com/browse/CORE-1224.
Unrelated quick question:
Are there any plans to change the changelog generation order so that indexing happens before foreign key and unique constraints?  Currently I have to edit my 26k+ line generated file by hand to get the order right.
┆Issue is synchronized with this Jira Story by Unito

Hi @djjolicoeur
Would you resolve branch conflict and consider adding tests for this PR?  Here's some guidance on that below:
Thanks for your pull request!
Here’s what happens next:
A member of the Liquibase team will take a look at your contribution and may suggest:

Changes based on guidelines for PR submission
Additional tests (unit and/or integration)
Provide other feedback, like requesting changes.

The PR will be prioritized according to our internal development and testing capacity.
We’ll let you know when it’s ready to move to the next step or if any changes are needed.

Hi @djjolicoeur Are you still needing this fix?  Are you still using Liquibase?
If no response within a week, I will close this PR.

I had no idea this was still hanging around! Closing as I am not using this project anymore and don’t recall the context. Thanks!


Drawings: Show notification/error on lack of access instead of infinite loading

Attempting to edit a non-accessible image currently leaves the user on a continuously loading diagrams.net view, this UX should be improved to advise of the error scenario.

Added in 48df8725d82cac821ee935498c811509c96e63c2:

Tested across both markdown and WYSWIYG editors.


Use listify for certain analyzers

I found that certain analyzers are still using their own "listify" code.
e.g.
https://github.com/d-Rickyy-b/pastepwn/blob/9b2fee22857e54a5312fdb3d388b472a7d271c50/pastepwn/analyzers/wordanalyzer.py#L12-L17
This should not be the case.

@d-Rickyy-b should the words param always be of type List (or None)? or is there a different "listify" function you have in mind?

Hi @colinlcrawford, you can use the listify util function in analyzers whenever it should be possible to handle multiple inputs. I think it would be cool to handle multiple inputs for the whole word analyzer. Feel free to add this feature :)
Thanks in advance.

Hey @d-Rickyy-b , I did a scan of the analyzers and it looks like they've all been updated. The wordanalyzer ^ has been updated in dev and I made the update in my PR for the exactwordanalyzer as well

Fixed in https://github.com/d-Rickyy-b/pastepwn/commit/0f60fbace3943752a0b415dd97fabfa807981a56

Fixed in https://github.com/d-Rickyy-b/pastepwn/commit/0f60fbace3943752a0b415dd97fabfa807981a56


Front-End and Back-End Proxying is Insufficient to Remove CORS Errors

When attempting to launch this package, each attempt to fetch any existing user tokens and/or login failed with Error 403: Forbidden. I was only able to resolve these issues by installing and using cors middleware, then changing all relevant links to the actual back-end route instead of the port 3000 proxy that this app uses by default. This also required re-configuring the Spotify application dashboard to set the callback URI to the un-proxied address.

I'm having exactly the same issue following this example: requests to http://localhost:3000/auth/* are not forwarded to http://localhost:5000/auth/*. Why is that? Is there a solution to this issue, except for using cors?


Filtering by regex breaks when using -od output directory

Running two commands:

without -od :
ffuf -c -D -e php -w /home/tools/dirsearch/db/dicc.txt -v -o "/home/user/reports/ffuf/website.com/report-2020-01-24-16-05-20.json" -fr "(?i)(Your request cannot be completed)" -u https://www.website.com/FUZZ

Works as intended. I am only getting results when a match is found that does not contain the regex pattern.

with -od output directory flag:

ffuf -c -D -e php -w /home/tools/dirsearch/db/dicc.txt -v -o "/home/user/reports/ffuf/website.com/report-2020-01-24-16-05-20.json" -fr "(?i)(Your request cannot be completed)" -od "/home/user/reports/ffuf/website.com/data/" -u https://www.website.com/FUZZ
Now every result gives a 200, even though they match the string I have configured in the -fr regex in the body.
Simply removing the -od flag and parameter makes it work correctly, so I think there is some connection with using -od that makes -fr not function anymore.

Thanks for reporting the issue! I looked in to this, and it's a legit bug, resulting from trying to read from body twice.
It's handled as a stream in go, so typically you can read it only once - the result that ffuf was trying to read for regex matching was empty because of this!


Hand tracking VisualScripting graph creation

Merged into
Hand tracking sample for creators · Issue #69 · styly-dev/STYLY-Spatial-Layer-Plugin · GitHub
https://github.com/styly-dev/STYLY-Spatial-Layer-Plugin/issues/69


Create methods to handle Kube Secrets

Add functions or methods to create, validate and delete kubernetes secrets.

@yashoza19 can you please clarify what secrets are we using at this moment? I'm not entirely sure which ones are valid for our use case after all the changes we've made.

@acmenezes We no longer require a secret with all the changes we have made to opcap. The secret was to store credentials to fetch bundle images from registries. We can delete this issue.


Heads up for the URL to ping when on node version above 17

If you are on node version above 17, passing localhost as the url to ping might fail. Pass <IP_ADDRESS> instead.
For example if the URL you are pinging is on localhost, do not use http://localhost:port, instead, use 'http://<IP_ADDRESS>:port`

Damn, never tought it would have been that. Thank you internet stranger, you saved me a lot of time.


CPP/taskcpp/1_ugly_number.cpp

quite a tricky one...try your best...question is well explained in the code
NOTE:- Screen shot of the code and output is required

can you please assign me this issue?

Pls assign this task to me

But my code also worked correctly no?

But my code also worked correctly no?

can you please check my code again? I followed all the procedures.


About checkpoints and stable-diffusion-v1-5

Thanks for your wonderful work! And I have some questions:

The checkpoint link you provided includes the folders vae, scheduler, tokenizer, and unet. However, in the pretrained section, you mentioned downloading the pre-trained StableDiffusion-1.5 from SDM, which also includes vae, scheduler, tokenizer, and unet. Which files should I use during training?

In your ./data_process/README.md, it mentions needing to download the required checkpoints such as yolov7.pt. Where can I find these checkpoints?

And if I want to use the 'Testset' uploaded to 'HuggingFace', only extracting the keyframes and their corresponding subtitles via 'python ./data_process/extract.py' is enough?

Since our model is designed based on SDM, all SDM pre-trained parameters need to be used;
Please refer to the official implementation repository of yolov7: https://github.com/WongKinYiu/yolov7
We have processed this part of the test set and can use it directly.


Enable checktvarinvariant on CI

In https://github.com/input-output-hk/ouroboros-network/pull/1040 I added an invariant to enable assertions on StrictTVars. We should enable this on CI.

Maybe somebody with Nix experience can help us out? We need the test-storage and test-consensus testsuites from ouroboros-consensus to run with the checktvarinvariant flag (for the io-sim-classes package) enabled.
Running the tests with that flag enabled takes quite long, so it should not be part of the CI checks for PRs. That would slow down the merge process even more. We want a nightly CI job for this.
@nc6 You wrote https://github.com/input-output-hk/ouroboros-network/blob/master/nix/validate-mainnet.nix, maybe you know what to do?

I have received some pointers:

Addpackage.ouroboros-consensus.component.test.test-storage.flags = { checktvarinvariant = true; };

to https://github.com/input-output-hk/ouroboros-network/blob/da1bd0117399d12e485c112f8413e865fed5bb0f/nix/pkgs.nix#L44
But we want to build that component with the flag enabled for io-sim-classes? We actually want to define an additional variant of an existing component with different flags.
To define a nightly job, create .buildkite/nightly.yml (look at the other .yml file for inspiration). Create a new pipeline in Buildkite: https://buildkite.com/input-output-hk/cardano-sl-nightly/settings/schedules. You can use the new build button to force a build instead of waiting a day.


jsonToHtml makes Vite build --watch stuck

Using jsonToHtml makes vite build --watch stuck
Reproduction
https://stackblitz.com/edit/vitejs-vite-jxfzwy?file=src/index.ts
Steps to reproduce

npm run dev
Modify the string inside console.log and save
Uncomment the code containing jsonToHtml and save
Modify the string inside console.log again and save

Packages versions
@contentstack/json-rte-serializer:  2.0.2
typescript: 4.9.3
vite: 4.2.1

According to a @vitejs core team member, It looks like a regression from https://github.com/vitejs/vite/pull/11919

Hey @marcoborsoi, I checked the project link shared, the build does get stuck, but upgrading to the latest version solves the issue.


Social Sharing of the App

Is your feature request related to a problem? Please describe.
We can share this mobile app with others via whatsapp ,  twitter , mail, etc.
Describe the solution you'd like
Add social sharing with this application.
@KeenWarrior @Abhishek-kumar09 Can I work on this ?

Is it same as https://github.com/codeforcauseorg/edu-client/issues/179

Is it same as #179

Yes ....But I opened this issue earlier.

Oh sorry, I always request everyone to see the issues if already opened before opening a new one.
I think she has started working, nevermind your contribution counts too.

I'm sorry, @poojadas07 You can work on it


Unable to clone canvas as it is tainted

My dom element contains the others HTML  tag,
This error will be prompted
..... Hope to get a reply ....Hope to get a reply....Hope to get a reply...
my code

supplement: dom container contains  others HTML "canvas" tag

Anyone found any solution ?

Still finding the solution

I also meet this problem，please resolve it ?

Same here

I'm using the Google Maps API with React (react-google-maps) and discovered that the issue was related to a custom transparent icon I had created. I'm not entirely sure of the exact reason. It could be that the properties inferred that I was altering a Google Maps original icon, but I may be mistaken.
The best way to pinpoint the cause of the problem is to systematically delete lines of HTML, components, or code until the error no longer appears. This way, you can identify the root of the issue.

(NOTE: THIS CODE IS NOT THE SOLUTION; IT IS JUST WHAT CAUSED THE ISSUE IN MY CODE)
I changed from
  const transparentIcon = {
    path: 'M0,0',
    fillColor: 'transparent',
    fillOpacity: 0,
    scale: 1,
    strokeWeight: 0
  };

to
   const transparentIcon = {
    path: 'M0,0'
  };


Bug in getModelNameForTiktoken method?

I'm using the function calculateMaxTokens to understand how many tokens I have left for a given prompt.
This function is not working properly, and upon digging further I found the issue with getModelNameForTiktoken. There's an extra "-" that are added to every startWith.
What is the reason for having a trailing dash for each model?
It creates a problem because when I pass gpt-3.5-turbo-16k as the model, it doesn't match gpt-3.5-turbo-16k- because of the extra "-" but it does match gpt-3.5-turbo, which returns the wrong model name, and thus the wrong model.
Happy to create a PR to fix, but I'm unsure if I can just remove the "-".
const getModelNameForTiktoken = (modelName) => {
    if (modelName.startsWith("gpt-3.5-turbo-16k-")) {
        return "gpt-3.5-turbo-16k";
    }
    if (modelName.startsWith("gpt-3.5-turbo-")) {
        return "gpt-3.5-turbo";
    }
    if (modelName.startsWith("gpt-4-32k-")) {
        return "gpt-4-32k";
    }
    if (modelName.startsWith("gpt-4-")) {
        return "gpt-4";
    }
    return modelName;
};

Should be fixed by #1931 and released in 0.0.107!


Windows setup

I tried to pull the dependency into my project, on my windows computer.
I obtained an error because riot pulls in go-systemd, for some reason.
Why is systemd required? And is there a solution to avoid this error?
E:\Dev\git\artemix-search>go get github.com/go-ego/riot
go: finding github.com/go-ego/riot latest
go: downloading github.com/go-ego/riot v0.0.0-20191215221243-bdbc256e4cbd
go: extracting github.com/go-ego/riot v0.0.0-20191215221243-bdbc256e4cbd
go get<EMAIL_ADDRESS>requires
<EMAIL_ADDRESS>invalid version: unknown revision<PHONE_NUMBER>00

I have the same error
I found the go mod replace document
cmd/go/alldocs.go

Exclude and replace apply only in the main module's go.mod and are ignored
in dependencies.

If we also use go mod in our project (import riot)，riot/go.mod replace are ignored. so report error.
some solutions：

create a new project base on vendor/github.com/coreos/go-systemd , and update code go-systemd import path

upgrade go-systemd version lateast. remove repalce

@vcaesar Hope to have time to solve it as soon as possible
Thanks.

I have the same error on my computer.


Why dependency on PHP 7.4.0

Hi,
I'm unable to understand why this package psr/container require PHP 7.4.0 as its just collection on some interfaces. I think it should require not more than php: >=5.4.0
Thanks!

Don't worry the version 1.0.0 requires php >=5.3 https://github.com/php-fig/container/blob/b7ce3b176482dbbc1245ebf52b181af44c2cf55f/composer.json#L15

Exactly. The bump on the PHP requirement was done in #20; you can read on the PSR process evolution here: https://www.php-fig.org/bylaws/psr-evolution/

Thanks for your reply :)


Enable for Expo?

Hello.  Thank you for building this project.  Any chance you will be refactoring this to work with Expo?

Hello Adriaan, you mean providing this within Expo as an Expo module?


Avoid using global variable in function

There are some functions where we use global variables instead of sending them as parameters. It is a best practice to avoid global variables in functions.
For example, in delete_temporary_files we use dump_id.

I would like to work on this issue. Please  assign it to me.

Hi @tarunsamanta2k20,
Thank you for being so interested 😃
We prefer not assigning people to our issues because sometimes people ask to be assigned and never come back, which discourages volunteer contributors to open a PR to fix this issue.
We will accept and merge the first PR that fixes correctly and well implements the issue following our contributing guidelines.
We are looking forward to reviewing your PR. ❤

As this repo is now low-maintenance, I'm closing all issues that are not bugs.


Consider removing unreachable code

I was working on PR #1062 which solves issue #843 and while doing that I came across a lot of snippets of the same code that will never be executed or unreachable code
Here are a few examples:

parse_push

Here the match case of 0 will never be executed because of the debug_assert_equal on the very first line.

parse_locaddr

Here the match case of 0 will never be executed because of the debug_assert_equal on the very first line.

Similarly, many other cases exist where nothing changes if we include the 0 case while matching or not because of the assertion about the 0th part of the token in all of these functions.
Happy to hear feedback on this.

I agree that removing the branch for the match case of 0 wouldn't result in any functional changes. However, one could argue that the existence of the 0 branch expresses the fact that an operation having 0 parts is not possible and this makes the code more readable. Having said that one could also argue that this is somewhat redundant as the debug_assert_eq!(..) statement communicates the same message to the programmer.  With everything considered I would be in favour of keeping the 0 branch as I think it does add some value in terms of readability but I am not strongly opinionated on this and would be open to hearing the opinions of other contributors.

One option could be moving the 'debug_assert_eq!(..)' into the ‘match 2’ case ?

One option could be moving the debug_assert_eq!(..) statement into the match 2 case.

I think we want the debug_assert_eq(..) to be in the functions global scope as it applies to all branches of the match expression (including match case of 1) so I don't think this would be a beneficial change.

I'd probably keep it as is now. One of the reasons for having 0 marked as unreachable is to make it clear that it's not going to fall through to the default case. For example:
pub fn parse_locaddr(op: &Token, constants: &LocalConstMap) -> Result<Node, ParsingError> {
    debug_assert_eq!(op.parts()[0], "locaddr");
    match op.num_parts() {
        0 => unreachable!(),
        1 => Err(ParsingError::missing_param(op, "locaddr.<index>")),
        2 => {
            let index = parse_param_with_constant_lookup::<u16>(op, 1, constants)?;
            Ok(Instruction(Locaddr(index)))
        }
        _ => Err(ParsingError::extra_param(op)),
    }
}

If we remove 0 branch, then it may look like extra_param error will be returned for 0 case. Not saying that it is difficult to figure out that that's not the case - but having 0 be unreachable makes it super clear and reduces cognitive load by a bit.

Given that two contributors have come to the same conclusion I will go ahead and close this issue.