[$250] Hold - Red dot for held expense disappears when approve the report partially

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 9.0.62-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/5222741&group_by=cases:section_id&group_order=asc&group_id=309128
Email or phone of affected tester (no customers<EMAIL_ADDRESS>Issue reported by: Applause Internal Team
Action Performed:
Preconditions:

Login as the owner of the workspace.
Create a workspace
Invite the approver and employee
Navigate to more features
Enable "workflows"
On the "Workflow" editor - enable "Add Approvals"
Set the Approver account as the Approver

Steps:

As Employee submit 2 expenses on workspace chat
As Approver hold the first expense
As Approver approve the report partially
Take a look at the held expense on approvers side

Expected Result:
Red dot should be present on the held expense
Actual Result:
Red dot for held expense is lost and only reappears when refresh the page
Workaround:
Unknown
Platforms:

[x] Android: Standalone
[x ] Android: HybridApp
[x] Android: mWeb Chrome
[ ] iOS: Standalone
[ ] iOS: HybridApp
[ ] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos
https://github.com/user-attachments/assets/d7d9b827-6334-4576-9e6a-69ca0e99a12c

View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~021857095206791026885
Upwork Job ID:<PHONE_NUMBER>791026885
Last Price Increase: 2024-11-14

Issue OwnerCurrent Issue Owner: @allgandalf

Proposal
Please re-state the problem that we are trying to solve in this issue.
Red dot for held expense is lost and only reappears when refresh the page
What is the root cause of that problem?
When we put a transaction on hold, we don't add showInReview as true here
https://github.com/Expensify/App/blob/d5a7b499d3ba2074f5ad069ed27a043d029d7036/src/libs/actions/IOU.ts#L7715
Which causes hasViolation of this transaction to return false and no RBR is displayed. After we open the expense report, backend returns the hold violation of this transaction with showInReview as true then RBR appears
https://github.com/Expensify/App/blob/d5a7b499d3ba2074f5ad069ed27a043d029d7036/src/libs/TransactionUtils/index.ts#L870
What changes do you think we should make in order to solve the problem?
We should add showInReview: true for new hold violation here
const newViolation = {name: CONST.VIOLATIONS.HOLD, type: CONST.VIOLATION_TYPES.VIOLATION, showInReview: true};

https://github.com/Expensify/App/blob/d5a7b499d3ba2074f5ad069ed27a043d029d7036/src/libs/actions/IOU.ts#L7715
What alternative solutions did you explore? (Optional)

Looking....

I can't seem to reproduce this locally... when I do it I end up in the approved part of the report, not the held part.
I am also getting all kinds of weird behavior, so maybe it's something related to my tests

As Employee submit 2 expenses on workspace chat

@iwiznia To easier to reproduce, after the step above you can go offline and do the next steps.

ok yeah updated my PR to handle this case too

Not reproducible
https://github.com/user-attachments/assets/98f7eb2e-bb75-4b78-a173-e7a948820883

I think that's acceptable since violations don't work offline. Going to close this for now, reopen if you disagree.
cc @cead22 @pecanoro

@iwiznia The hold violation is working offline, we add the hold violation in optimistic data when we put a transaction on hold here.
https://github.com/Expensify/App/blob/d5a7b499d3ba2074f5ad069ed27a043d029d7036/src/libs/actions/IOU.ts#L7715

Ohhh thanks for that context! It seems we don't do that for the new report when approving it then.
@allgandalf can you take a look into that?

@allgandalf What do you think about my proposal?

@allgandalf - @iwiznia confirmed this is a regression. What's the plan here? Thanks for the update!

Thank you!

Closing - there has been no movement here.
Heads up, I will be offline until Wednesday, December 18, 2024, and will not actively watch over this GitHub during that period.
If this GitHub requires an urgent update, please ask for help in the #expensify-open-source Slack Room. If the inquiry can wait, I'll review it when I return online.


Add namespaces to tasks

This PR adds namespaces to tasks (namely dev and int) and moves most tasks to these new namespaces. I decided against hiding the moved tasks from the listing command as that might be confusing to users.
Available tasks:

  backup                            Backup the database and media files.
  export-records                    Export all database records to a file.
  frontend-download                 Download a pre-build frontend from GitHub if you dont want to
                                    install nodejs on your machine.
  import-records                    Import database records from a file.
  install                           Installs required python packages.
  migrate                           Performs database migrations.
  plugins                           Installs all plugins as specified in 'plugins.txt'.
  remove-mfa                        Remove MFA for a user.
  restore                           Restore the database and media files.
  static                            Copies required static files to the STATIC_ROOT directory, as
                                    per Django requirements.
  superuser                         Create a superuser/admin account for the database.
  update                            Update InvenTree installation.
  version                           Show the current version of InvenTree.
  wait                              Wait until the database connection is ready.
  dev.delete-data                   Delete all database records!
  dev.docs-server                   Start a local mkdocs server to view the documentation.
  dev.frontend-dev                  Start frontend development server.
  dev.gunicorn                      Launch a gunicorn webserver.
  dev.import-fixtures               Import fixture data into the database.
  dev.schema                        Export current API schema.
  dev.server                        Launch a (development) server using Django's in-built
                                    webserver.
  dev.setup-dev                     Sets up everything needed for the dev environment.
  dev.setup-test                    Setup a testing environment.
  dev.test                          Run unit-tests for InvenTree codebase.
  dev.test-translations             Add a fictional language to test if each component is ready for
                                    translations.
  dev.translate                     Rebuild translation source files. Advanced use only!
  int.clean-settings                Clean the setting tables of old settings.
  int.clear-generated               Clear generated files from `invoke update`.
  int.export-settings-definitions   Export settings definition to a JSON file.
  int.frontend-build                Build frontend.
  int.frontend-check                Check if frontend is available.
  int.frontend-compile              Generate react frontend.
  int.frontend-install              Install frontend requirements.
  int.frontend-trans                Compile frontend translations.
  int.rebuild-models                Rebuild database models with MPTT structures.
  int.rebuild-thumbnails            Rebuild missing image thumbnails.
  int.render-js-files               Render templated javascript files (used for static testing).
  int.showmigrations                Show the migration status of the database.
  int.translate-stats               Collect translation stats.
  int.worker                        Run the InvenTree background worker process.

Default task: version

Closes #7852

@SchrodingersGat all changed

@SchrodingersGat this is ready for review and merge

@matmair thanks for tackling this. Can you update the initial comment on the PR to show the latest output of invoke --list?

@SchrodingersGat updated

Thanks for working on this @matmair


write_ds9 silently overwrites output file

https://github.com/astropy/regions/blob/35bab74340b12053942d2bc6ebd071dce340c605/regions/io/ds9/write.py#L62
This behavior is not always desirable. I propose you add an overwrite keyword like what astropy unified I/O does.

Added in v0.5


Add an onBlur property that's forwarded to the input

Expect it this weekend 👍

Added to version 1.5.0


Automate rollbacks

In the case where something fails testing in this enhancement, rollback (mark version as deprecated) everything package manager deployment.

The project currently isn't big enough to need something like this. Instead, we'll just monitor the pipeline. If the project grows, we can reopen this issue.


Sending message with bot

How to send message with bot without handler in this package?!
something just like this: bot.sendmessage().... bot out of any def!

You may just obtain a bot from DjangoTelegramBot.getBot() method.
If you have more than one bot in your config, you could select it by token or username with bot_id parameter in the call.
example how use a bot in a views:
from django.http import HttpResponse
from django_telegrambot.apps import DjangoTelegramBot

def sendMessageTo(request, chat_id, msg_text):
    bot = DjangoTelegramBot.getBot(bot_id="myBot")
    bot.sendMessage(chat_id, text=msg_text)
    response = "Message send to %s."
    return HttpResponse(response % chat_id)

I use this part of code in celery periodic task:
bot = DjangoTelegramBot.getBot('bot_name') bot.sendMessage(chat_id, "Hello!")
But i see only this error:
AttributeError: 'NoneType' object has no attribute 'sendMessage'
How to fix?

I see this error too:
AttributeError: 'NoneType' object has no attribute 'sendMessage'

It means that the first line does not return a valid bot object. The required settings (i.e. token) must be defined in djangos settings.py and you have to make sure, that this settings are loaded, when the script is called from something else than django/wsgi. The 'bot_name' string need to be replaced with the bots user name  (not display name!), which belongs to the token given in settings.py.


Allow authoring/custom winmd consumption (publish the Modern compiler).

Currently there is no way of authoring things modularly and/or consuming non-in-box APIs.
This is a bit of a blocker for me, and I otherwise love the idea.
I noticed that you plan to make the compiler consume winmd instead of IDL, but that doesnt seem critical (for most use cases) as it can be worked around using winmdidl.exe. Right?

I have heard from many folks with interest in using the compiler. I hope to have some news to share about that soon.

Please release the compiler, please, please, please.....


Use Taskfile execution in Github Actions

Codecov Report

Merging #131 (f979598) into main (47a9ec0) will decrease coverage by 37.81%.
The diff coverage is n/a.

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #131       +/-   ##
===========================================
- Coverage   72.36%   34.55%   -37.81%
===========================================
  Files          55       50        -5
  Lines        3094     3018       -76
===========================================
- Hits         2239     1043     -1196
- Misses        669     1742     +1073
- Partials      186      233       +47

Components
Coverage Δ

garden-app
34.55% <ø> (-37.81%)
:arrow_down:


[SPARK-28885][SQL][FOLLOW-UP] Remove the ported PgSQL regression tests from the blacklist of SQLQueryTestSuite

What changes were proposed in this pull request?

SPARK-28885(#26107) has supported the ANSI store assignment rules and stopped running some ported PgSQL regression tests that violate the rules. To re-activate these tests, this pr is to modify them for passing tests with the rules.
Why are the changes needed?

To make the test coverage better.
Does this PR introduce any user-facing change?

No.
How was this patch tested?

Existing tests.

Test build #113669 has started for PR 26492 at commit bab3711.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/18552/
Test PASSed.

Test build #113669 has finished for PR 26492 at commit bab3711.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/113669/
Test FAILed.

retest this please

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/18563/
Test PASSed.

Test build #113682 has started for PR 26492 at commit bab3711.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/18567/
Test PASSed.

Thanks for your quick check, @MaxGekk ! cc: @dongjoon-hyun @gengliangwang

Test build #113682 has finished for PR 26492 at commit bab3711.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/113682/
Test PASSed.

Test build #113751 has started for PR 26492 at commit a4636ec.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/18629/
Test PASSed.

Test build #113751 has finished for PR 26492 at commit a4636ec.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/113751/
Test FAILed.

@maropu Thanks for reenabling the test cases!

ThriftServerQueryTestSuite reuses the queries. It seems that we need to regenerate them too, @maropu .  (Also, cc @wangyum ).

Test build #113759 has started for PR 26492 at commit 202988b.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/18634/
Test PASSed.

Test build #113759 has finished for PR 26492 at commit 202988b.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/113759/
Test FAILed.

retest this please.

Test build #113766 has started for PR 26492 at commit 202988b.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/18639/
Test PASSed.

Test build #113766 has finished for PR 26492 at commit 202988b.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/113766/
Test FAILed.

retest this please

Test build #113823 has started for PR 26492 at commit 202988b.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/18695/
Test PASSed.

Test build #113823 has finished for PR 26492 at commit 202988b.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/113823/
Test FAILed.

retest this please

Test build #114124 has started for PR 26492 at commit 202988b.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/18982/
Test PASSed.

Test build #114124 has finished for PR 26492 at commit 202988b.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/114124/
Test FAILed.

Ur, it seems I need to update the golden file again..

Test build #114154 has started for PR 26492 at commit 7c06f0d.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/19011/
Test PASSed.

Test build #114154 has finished for PR 26492 at commit 7c06f0d.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/114154/
Test PASSed.

Thanks for taking care of it, guys! @dongjoon-hyun @gengliangwang @MaxGekk


Fix audio can't resume in iOS platform

Fixed audio can not resume if it is interrupted cause by an incoming phone call
Fixes #7905.

@akien-mga would you cherry-pick this on 2.1 :smile:

Yeah, I will. :)


Does not work for files with the exw extension

Greg said, "because I whoopsied the configuration... https://github.com/OpenEuphoria/vscode-euphoria/blob/master/package.json#L32
it's just supposed to be a list of dot extensions, and I put in an asterisk for that one"

Fixed by commit: 0e1580a27c855a7eb9665d0115783a8f9d7833f0


Publish to NPM

also need to make sure the executor wasm is compiled with correct profile & optimization

closed by #78


Add table of metadata to listing pages

Yes!
That’s taught me not to attempt refactoring over breakfast.
Am currently fixing this and adding a try block to the get request.

On 1 Jul 2022, at 10:56, Merlin Fisher-Levine @.***> wrote:
@mfisherlevine commented on this pull request.
In src/rubintv/handlers/external/endpoints.py https://github.com/lsst-sqre/rubin-tv/pull/78#discussion_r911814488:

 )

 return web.Response(text=page, content_type="text/html")

+def get_metadata_json(

bucket_name: str, camera_slug: str, date_str: str
+) -> str:
metadata_json = "{}"
metadata_url = get_metadata_url(bucket_name, camera_slug, date_str)
metadata_json = requests.get(metadata_url).text
Sorry, comment from before went somewhere very strange.
I think this is a mistake, right? You're accessing the result before the check for 200 return code.

—
Reply to this email directly, view it on GitHub https://github.com/lsst-sqre/rubin-tv/pull/78#pullrequestreview-1026000919, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAEYMXULM3J252WWM7UYSQTVR26GRANCNFSM52CJQUPA.
You are receiving this because you are subscribed to this thread.


⚠ RbxVeri has degraded performance

In da5f21e, RbxVeri (https://verify.triza.dev) experienced degraded performance:

HTTP code: 200
Response time: 8263 ms

Resolved: RbxVeri performance has improved in 667c598.


log_error(), log_warning(), log_info() and log_header() should use .expect() instead of .unwrap()

Currently there are lots of usages of unwrap() in production code, in the logging helpers in:
https://github.com/heroku/libcnb.rs/blob/2698a713edf19034e382aa702e12acc1516da8fa/libherokubuildpack/src/log.rs
Whilst the nature of these failure modes means that we can't use a Result (and so panicing is appropriate) - we should use .expect() instead of an .unwrap() so at least the panic message is more descriptive.

Note: The log module will be removed in the future, since it's been superseded by the build_output module.


Update migratefromlaunchdarkly.mdx

🚀 Deployed on https://6452ee53f3b3fc1126e794c9--cozy-fox-0defec.netlify.app


Error with settings output mode json

Hi everyone, great project ! Unfortunately I wanted to test it out with the json output and I got an error.
My settings.env:
SETTINGS_OUTPUT_MODE=json SETTINGS_MARKET_PAIRS=ETH/BTC SETTINGS_UPDATE_INTERVAL=300 EXCHANGES_BITTREX_REQUIRED_ENABLED=true SETTINGS_OUTPUT_MODE=json
Error log:
enabled notifers: []
Starting default analyzer...
Found configured markets: ['ETH/BTC']
Using the following exchange(s): ['bittrex']
Beginning analysis of bittrex
Traceback (most recent call last):
File "app.py", line 46, in
main()
File "app.py", line 41, in main
behaviour.run(settings['market_pairs'], settings['output_mode'])
File "/app/behaviour.py", line 57, in run
new_result = self._test_strategies(market_data, output_mode)
File "/app/behaviour.py", line 153, in _test_strategies
output = self._get_json_output(new_result[exchange])
File "/app/behaviour.py", line 252, in _get_json_output
indicator['result']['is_hot']
KeyError: 'momentum'

This might be related to the notifier overhaul I implemented yesterday, I'll look into this when I get a chance.

Fixed in https://github.com/CryptoSignal/crypto-signal/pull/242 waiting for review.

Merged


[Vue warn]: Failed to resolve directive: video-player  (found in )

i am use vue-server-renderer to ssr,so  How to use in ssr?  I am always show this error.

https://github.com/surmon-china/vue-video-player#vue-mount
https://github.com/surmon-china/vue-video-player#use-in-ssr

I use it as vue-mount ,but it is show this error.

require('vue-video-player/ssr')

Ssr!

Sorry，it is not wok.

I fix it by myself.
const inBrowser = typeof window !== 'undefined'
  if (inBrowser) {
    require('video.js/dist/video-js.css')
    Vue.use(require('vue-video-player/ssr'))
  }

import Vue from 'vue'
if (process.BROWSER_BUILD) {
const VueVideoPlayer = require('vue-video-player/ssr')
Vue.use(VueVideoPlayer)
}
warn:
vue.runtime.esm.js:430 [Vue warn]: Failed to resolve directive: video-player
(found in <D:\GitH5Sdk\wuliList\wuliListNuxtVideoPlayer\pages\video\index.vue>)


Updating the value does not cause the placeholder to disappear

When the parent element sets the text value, I would expect the value to cause the placeholder to be removed:

placeholder: { text: 'Some text h1', hideOnClick: true }
Source: https://github.com/yabwe/medium-editor#placeholder-options

Same issue here, we pre-load the editor with data in some cases:

My workaround until this is fixed:
Container div:
<div className={classNames({ 'hide-placeholder': hasText(text.value) })}>

CSS:
.hide-placeholder .medium-editor-placeholder:after {
	display: none;
}

+1, placeholder option doesn't' work correct

@jcalfee, @bassettsj , it works fine, just put placeholder: false to options

issue can be closed, I think


add recheck interval when there is no more data for any specified topic

https://github.com/softwaremill/reactive-kafka/blob/master/src/main/scala/com/softwaremill/react/kafka/KafkaActorPublisher.scala#L33
I think we should add a property that when there is no more data for any specified topic,then we could reschedule the check after a period of time.like recheckInterval?
otherwise I see a lot of traffic there even there is no more data.

Hi @hepin1989, I guess this issue can be closed? :)

yes,I think so,it's very old.


$select statement truncated from odata request

Hello odata-v2-adapter Team,
Thank you for providing us your cds extension! I might came accross an issue while developing my cds service on SAP BTP.
I have an CDS entity with an one-to-many association (file attachments). My UI5 application is requesting the association data apart from the main entity due to performance reasons. The odata request is similar to the following:
ZMain_Entity('1000003880')?$select=to_Files&$expand=to_Files
So, the application requests all files of the main entity without the data of the main entity itself. I am using this kind of request to keep track of relations wihtin the ui5 app.
Unfortunately the v2-adapter removes the "$select" while forwarding the request to v4. The co2ap debug logs shows the following:

Is there any option to prevent this from happening? I am looking forward to your response.
Best regards,
Torben

Thanks for reporting this issue.
In OData V2 selects for expanded data is part of top level $select. In OData V4 selects for expanded data is nested in $expand. That‘s why a transformation happens.
As to_Files is only related to an expand, and no other fields are selected, $selected is removed, so that all root data is selected as well…
If I get you right, you would expect an empty $select, which would not lead to a return of root data, but only all expanded data.
The challenge I see here is, how to control if you want to all data or no data, because you cannot express this decision with just a simple $select.
So no, currently this cannot be influenced. But I could think of an option, that would switch this behavior in future.
What do you think?

Of course you can at least reduce the data, by $select, only including a single root field, e.g. ID and the to_Files. Then you get a correlation of the expanded data to the root instance, which is also not a bad idea. I.e. $select=ID,to_Files

Thank you for the quick reply. I can understand the issue in more detail now. I believe the transformation should differentiate the content of $select between fields related to the main entity and fields related to depended (expanded) entities. In my case "to_Files" should be intepreted as a "field" rather than a select limitation for $expand.
Is it possible to keep the association in the $select if the expand for that association does not contain a slash? So the slash could act as delimiter for truncation. That would not violate the odata v4 definition!
Example (as of current version):

$select=Id,to_Files/FileName,to_Files/Size&$expand=to_Files => $select=Id&$expand($select=FileName,Size)
$select=Id,to_Files/FileName&$expand=to_Files => $select=Id&$expand($select=FileName)
$select=to_Files/FileName&$expand=to_Files => $expand(to_Files/FileName)
$select=to_Files&$expand=to_Files => $expand(to_Files)

Example (preferred behavior)

$select=to_Files&$expand=to_Files => $select=to_Files&$expand(to_Files)
$select=to_Files,to_Files/FileName&$expand=to_Files => $select=$expand(to_Files) : Combination should not work. This should result in selecting all fields. (I reproduced this behavior on my on-premise gateway system)

Could you follow my point here?
I would recommend this as prefered behavior or at least as option in your adapter.
Please share your thoughts on this with me.

Of course you can at least reduce the data, by $select, only including a single root field, e.g. ID and the to_Files. Then you get a correlation of the expanded data to the root instance, which is also not a bad idea. I.e. $select=ID,to_Files

This would work as workaround for me. As mentioned in my previous comment I prefer an extension or a new option in the adapter for handling this situation.

Thanks for you detailed explanations. I will have a look, and also do some tests.

I did further tests, and I think your proposal makes sense.
Two questions I have in addition:

Currently the key is always returned, no matter, if it is selected ($select) or not, as the underlying OData V4 service does the same. So I just pass the same data back. I like that approach, as the data can then always be correlated to an instance. What do you think?

Currently expanded data is returned, although it is may not be selected ($select). So $select=to_Files&$expand=to_Files is the same as $expand=to_Files, as expanded data is always auto-selected. I also like, that, because why would you expand data, that you don't want to select...

Thank you for the investigation and your efforts! I think returning the key is mandatory to keep entity correlations consistent.
$select=to_Files&$expand=to_Files and $expand=to_Files are not equal requests. Yes, both request expand the entity and its values by auto-select. The differences is the returned data from the main entity.

$select=to_Files&$expand=to_Files only return files which are correlated to the main entity without the (whole) entity itself. The $select is the limitation here (see Request 1). If main entity data is needed the request should be changed. E.g.: $select=Description,Changed,Modified,to_Files&$expand=to_Files (see Request 3)
$expand=to_Files addtionally returns all main entity data. No $select no limitation. (see Request 2)

$select=to_Files indicates that only the "field" to_Files is requested. This is independend from the $expand parameter.
See the following examples (odata v2 on-premise gateway/ ECC):

Request: /sap/opu/odata/sap/XXXXXX/Main_Entity('1000003880')?$select=to_Files&$format=json

Request: /sap/opu/odata/sap/XXXXXX/Main_Entity('1000003880')?$select=to_Files&$expand=to_Files&$format=json

Request '/sap/opu/odata/sap/XXXXXX/Main_Entity('1000003880')?$select=CustomerIssue_Text,to_Files&$expand=to_Files&$format=json'

Please share your thoughts with me :-)
Best regards

Implemented with https://github.com/cap-js-community/odata-v2-adapter/commit/c4e1f638b54bd25902c8ca32ead7f02e409cae28

I will target a release end of this week. I update the issue, once it is available....

Release v1.12.10 is available: https://github.com/cap-js-community/odata-v2-adapter/releases/tag/v1.12.10


feat(instrumentation): add support for esm module

Re-opening following https://github.com/open-telemetry/opentelemetry-js/pull/2640 + https://github.com/open-telemetry/opentelemetry-js/pull/2763
I'm marking this as draft since we have a semi problem with this: its really not easy to test this. Granted there wasn't a lot of test in place before that for require in the middle but i think it make sense to do it anyway.
I've looked around and if we want to run in esm mode and verify that we can correctly hook esm module, we need to mark the package itself as being ESM: https://github.com/mochajs/mocha-examples/issues/47#issuecomment-952339528
I'm pretty sure doing this will cause downstream problem for users so i don't think this is the way to go, do someone have an idea ?

Why is it needed to mark @opentelemetry/instrumentation as ESM? Is it needed only for our tests or also for production?
I think datadog APM uses import-in-the-middle but I don't think it's marked as module.

Is it needed only for our tests or also for production?

Apparently for tests only but i didn't test it yet

Added a simple test that patches a esm module and verify that we get the patched version, however making it work with our typescript tooling was pretty much a nightmare. Would like input of everyone to discuss if we ship it like this or we want to do more ?
PS: Wil fix tests for older node version / changelog afterwards
cc @open-telemetry/javascript-approvers

I've fixed the tests (sorry for the bash hack, i didn't see another way to not run those tests for node < 12) and added a comment in the readme to explain that user need to use choose the iitm loader so we can hook into modules

Have you tried running any contrib package against this?

Well i believe most of our instrumentation target cjs module so i didn't try, do you have one in mind that have a esm bundle ?

I love a good bash hack(sarcasm), but if you don't, an less-bash-hacky alternative could be something like:

I prefer your suggestion, i will update my PR

Dismissed my approval because we need to make sure a basic npm test works for windows users. This means either making test:esm work in windows, only running test:cjs for a basic test script, or both.

Well i believe most of our instrumentation target cjs module so i didn't try, do you have one in mind that have a esm bundle ?

I assumed the new paths will also kick in if my application is esm, but not the library. Isn't that the case?

This PR is not stale

FYI @JamieDanielson offered to move this PR forward in slack's dm (as i find it quite hard to commit time on otel those days, it seems that it might go forward faster this way)

Thanks Jamie

Any update here? With Nuxt 3 moving to native ESM, this would be amazing.

Apologies for further delay on helping with this! Some other things had come up but this has moved back into the priority list now. Hope to have an update in the coming days/weeks, as this is definitely an important addition.

Checking back in to see if there has been any update.

All that activity over #1946 motivated me to get back to this. Good news actually some of the issues i've had has been resolved by other PRs:

https://github.com/open-telemetry/opentelemetry-js/pull/2846#discussion_r859026725: no longer needed with newer IITM version
https://github.com/open-telemetry/opentelemetry-js/pull/3161 extracted the logic to a singleton so i've moved the logic there too
https://github.com/open-telemetry/opentelemetry-js/pull/2846#discussion_r864258373 we dropped support for node 12 so the hack to run esm only when available isnt needed anymore

I assumed the new paths will also kick in if my application is esm, but not the library. Isn't that the case?

From my understanding, the new path for esm only kicks in when the ESM module loader is used so for ESM modules, you can find more information there: https://nodejs.org/dist/latest-v18.x/docs/api/packages.html#determining-module-system

Thank you for taking time of your holiday working on this. Let me know, how I can help. I think that agitated is a popular ESM package that could be a test target?

Thank you for taking time of your holiday working on this. Let me know, how I can help. I think that agitated is a popular ESM package that could be a test target?

My simple unit test shows that you can mutate exports with the PR so yeah i think once merged it would be nice to have a esm-only instrumentation created

Thank you for taking time of your holiday working on this. Let me know, how I can help. I think that agitated is a popular ESM package that could be a test target?

My simple unit test shows that you can mutate exports with the PR so yeah i think once merged it would be nice to have a esm-only instrumentation created

I think the got package is an interesting test case as its a package that is widely used 11.8.5 which still CommonJS while the >= 12.0.0 became a ESM pure module. I think both versions are still heavily used

I gave this a PR try on node v18.12.1. I know it's totally work in progress, but just in case it's helpful, I thought I'd post my results here.
Short version: I'm not having much luck :/
$ node --experimental-loader=import-in-the-middle/hook.mjs dist/user.mjs
(node:17) ExperimentalWarning: Custom ESM Loaders is an experimental feature. This feature could change at any time
(Use `node --trace-warnings ...` to show where the warning was created)
@opentelemetry/api: Registered a global for diag v1.3.0.
Exporter "otlp" requested through environment variable is unavailable.
@opentelemetry/api: Registered a global for trace v1.3.0.
@opentelemetry/api: Registered a global for context v1.3.0.
@opentelemetry/api: Registered a global for propagation v1.3.0.
@opentelemetry/instrumentation-express Module express has been loaded before @opentelemetry/instrumentation-express so it might not work, please initialize it before requiring express
@opentelemetry/instrumentation-grpc Module @grpc/grpc-js has been loaded before @opentelemetry/instrumentation-grpc so it might not work, please initialize it before requiring @grpc/grpc-js
@opentelemetry/instrumentation-mysql2 Module mysql2 has been loaded before @opentelemetry/instrumentation-mysql2 so it might not work, please initialize it before requiring mysql2
@opentelemetry/instrumentation-aws-sdk Module aws-sdk has been loaded before @opentelemetry/instrumentation-aws-sdk so it might not work, please initialize it before requiring aws-sdk
@opentelemetry/instrumentation-redis Module redis has been loaded before @opentelemetry/instrumentation-redis so it might not work, please initialize it before requiring redis
@opentelemetry/instrumentation-memcached Module memcached has been loaded before @opentelemetry/instrumentation-memcached so it might not work, please initialize it before requiring memcached
Patching<EMAIL_ADDRESS>Patching Connection.prototype.query
MySQL2Instrumentation: patched mysql query/execute
MySQL2Instrumentation: patched mysql query/execute
items to be sent [
  Span {
    attributes: {
      'db.system': 'mysql',
...

I'm using esbuild to bundle my TypeScript app's source code, but am excluding all node_modules from bundling (so I'm just bundling my app's transpiled TypeScript source code).
Despite the debug error logs above, I am not importing anything before loading the instrumentations as can be seen from the source of my bundled app:
import {createRequire} from 'module';const require=createRequire(import.meta.url);
var __defProp = Object.defineProperty;
var __getOwnPropDesc = Object.getOwnPropertyDescriptor;
var __export = (target, all) => {
  for (var name in all)
    __defProp(target, name, { get: all[name], enumerable: true });
};
var __decorateClass = (decorators, target, key, kind) => {
  var result = kind > 1 ? void 0 : kind ? __getOwnPropDesc(target, key) : target;
  for (var i = decorators.length - 1, decorator; i >= 0; i--)
    if (decorator = decorators[i])
      result = (kind ? decorator(target, key, result) : decorator(result)) || result;
  if (kind && result)
    __defProp(target, key, result);
  return result;
};

// backend/common/tracing/initialize.ts
import * as openTelemetryAPI from<EMAIL_ADDRESS>import { registerInstrumentations } from<EMAIL_ADDRESS>import { NodeTracerProvider } from<EMAIL_ADDRESS>import { OTLPTraceExporter } from<EMAIL_ADDRESS>import { Resource } from<EMAIL_ADDRESS>import { SemanticResourceAttributes } from<EMAIL_ADDRESS>import { SimpleSpanProcessor } from<EMAIL_ADDRESS>import { GrpcInstrumentation } from<EMAIL_ADDRESS>import { HttpInstrumentation } from<EMAIL_ADDRESS>import { ExpressInstrumentation } from<EMAIL_ADDRESS>import { MySQL2Instrumentation } from<EMAIL_ADDRESS>import { AmqplibInstrumentation } from<EMAIL_ADDRESS>import { AwsInstrumentation } from<EMAIL_ADDRESS>import { RedisInstrumentation } from<EMAIL_ADDRESS>import { MemcachedInstrumentation } from<EMAIL_ADDRESS>
// backend/common/tracing/config.ts
var serviceName = process.env["SERVICE_NAME"] ?? "unknown";
var tracingEnabled = process.env["TRACING_ENABLED"] === "true";
var tracingDebugLoggingEnabled = process.env["TRACING_DEBUG_LOGGING"] === "true";

// backend/common/tracing/initialize.ts
if (tracingEnabled) {
  if (tracingDebugLoggingEnabled) {
    openTelemetryAPI.diag.setLogger(new openTelemetryAPI.DiagConsoleLogger(), openTelemetryAPI.DiagLogLevel.DEBUG);
  }
  const provider = new NodeTracerProvider({
    resource: new Resource({
      [SemanticResourceAttributes.SERVICE_NAME]: serviceName
    })
  });
  provider.addSpanProcessor(new SimpleSpanProcessor(new OTLPTraceExporter()));
  provider.register();
  registerInstrumentations({
    instrumentations: [
      new HttpInstrumentation({
        enabled: true,
        ignoreIncomingRequestHook(req) {
          return !!req.url?.match(/chkhealth|chkready/);
        }
      }),
      new ExpressInstrumentation({ enabled: true }),
      new GrpcInstrumentation({ enabled: true }),
      new MySQL2Instrumentation({ enabled: true }),
      new AmqplibInstrumentation({ enabled: true }),
      new AwsInstrumentation({ enabled: true }),
      new RedisInstrumentation({ enabled: true }),
      new MemcachedInstrumentation({ enabled: true })
    ]
  });
}
...

I am seeing auto-instrumented traces in the debug logs of my app and in Jaeger for mysql and http, but I'm not seeing debug logs or traces for any of the other instrumentations.
I recently switched the app from CommonJS to ESM due to several of my dependencies dropping support for CommonJS. I previously saw traces in Jaeger, and then (unsurprisingly) stopped seeing traces after switching my app to ESM.
Anyway, thank you so much for working on this feature, and hopefully my experience is just user error and will work out of the box once this PR lands.

Anyway, thank you so much for working on this feature, and hopefully my experience is just user error and will work out of the box once this PR lands.

I believe this show that my PR doesn't work when we try to patch CJS module from ESM (since most of instrumentation we are patching are still CJS). My test only does ESM loading ESM modules. I'm gonna try to reproduce when i've time but in the mean time:

could you test to bundle all of your node_modules to ESM see if it's better ?
make a small repro of your build so i can test against ?

Thanks for your help

I branched and created an example app to try some things out using HTTP and Express instrumentation. I don't know if it was all necessary, but in a few places I updated the package.json to help ensure I was using the local instrumentation package.
There are instructions in a README for running this app as CommonJS and as ESModules - it defaults to CommonJS. When I run as CommonJS, I see 5 total spans: 1 http, 3 express, 1 manual. When I run as ESM, I only see the manual span.
I notice these in the console output for CommonJS and not ESM:
@opentelemetry/instrumentation-http Applying patch for<EMAIL_ADDRESS>Applying patch for<EMAIL_ADDRESS>

As discussed outside of this PR and in SIG meetings, here is the new PR for this work: https://github.com/open-telemetry/opentelemetry-js/pull/3698


Mutations doesn't persist immediatly after calling "commit"

public async confirmaUsuarioViaUuid(uuid: string) {
        const query = `query user($id: string){
            user(func: eq(uuid, $id)) @filter(has(mUser)) {
              uid
            }
          }`;

        const txn = this._client.newTxn();
        const res = await txn.queryWithVars(query, { $id: uuid });
        const arrUser = res.getJson().user;

        d("arr -> %O", arrUser)

        if (arrUser.length === 0) {
            await txn.discard()
            throw new Error("Uuid nao existe.");
        }
        const uid: string = arrUser[0].uid
        try {
            const data = new Date();
            const p = {
                uid,
                [fieldNames.confirmado]: true,
                [fieldNames.dataAtualizacao]: data,
            };
            const mu = new dgraph.Mutation();
            mu.setCommitNow(true);
            await mu.setSetJson(p);
            const assigned = await txn.mutate(mu);
            d("assigned --- ")
            await txn.commit();
            // COMMIT ------------------------------------------
            d("commit --- ")
            assigned.getUidsMap().forEach((id, key) => d(`\n\n\t${key} => ${id}\n\n`));
            return p;
        } finally {
            await txn.discard();
            d("foi --- ")
        }
    }

I am testing the above method. When I use ratel to see if the changes were persisted I can confirm they were, but my test always show the debug messages "assigned --- ", "commit --- " and "foi --- " after the test been runned. My test is not the problem since I make a call to that method and AFTER the method returns I do another cal to the function below:
public async queryUserByUuid(uuid: string): Promise<any> {
        const query = `query user($id: string){
            user(func: eq(uuid, $id)) @filter(has(mUser)) {
              uid
              uuid
              email
              confirmado
            }
          }`;
        const vars = { $id: uuid };
        const tnx = this._client.newTxn()
        const res = await tnx.queryWithVars(query, vars);
        const ppl = res.getJson();
        await tnx.discard();
        d("query --> %O", ppl.user[0]);
        return ppl.user[0];
    }

The value "confirmado" I receive after calling the second method is still undefined for a moment. If I put a setTimeout on it it returns "true" as expected. I concluded that the "commit" call on the transaction still takes some milisseconds to fully concludes but releases the method before...
Am I missing something or it is really a bug ?

Your mutate method is async, so it returns before dgraph callbacks have completed.
If you do something like
public async mutateAndCheck() {
  await confirmaUsuarioViaUuid("some user id");
  await queryUserByUuid("some user id");
}

You should see that the data is read back correctly, even without a setTimeout. This is normal behaviour of JS async methods.
I haven't tested this code locally, but pretty sure that's the culprit. Closing the issue for now, if my suggested fix still has a problem - please feel free to reopen and I will take another look.


Read status column from spreadsheets

I verified that if a status column is included in a project spreadsheet it is ingested, updated, etc., and that it shows up accurately in the API output and is searchable. I also fixed a bug where values changed in the org spreadsheet weren't getting updated if the linked GitHub project hadn't been updated.
I did all this work with a test spreadsheet because I don't have edit access to any of the org spreadsheets linked from the brigade spreadsheet.
When the owners of those spreadsheets add a status column and values, they'll be reflected in the API.
also fixes #206, a bug I found while researching the problem.

@ondrae could you review this when you get a chance?


⚠ Bofrost.at has degraded performance

In c17328a, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 1389 ms

Resolved: Bofrost.at performance has improved in 86456c5.


have an option to turn off benchmarks

It would be nice to have an option to turn off benchmarks.  I'm running into problems because my benchmarks use Criterion, and the latest version of Criterion doesn't build on Windows.  (And the previous version of Criterion doesn't support ghc 8.0.1, so I can't use that, either.)
I'd like to just be able to say I don't want to build the benchmarks or their dependencies, but it appears that STACK_DEP_OPTIONS is hardcoded to "--test --bench --only-dependencies --ghc-options=-O0" and there doesn't seem to be a way to override it.

How about a DISABLE_BENCH envvar to disable building benchmarks?

BTW, criterion builds successfully on 64-bit windows, so you can use the following in your appveyor.yml:
platform: x64

Thanks!  The option solved my problem!
Also, thanks for the tip about 64-bit.  I hadn't realized Appveyor was available in a 64-bit version.


[SAMPLES] Smart Class Room: Added face registration interface

Added Face Registration interface.
@snosov1 @LeonidBeynenson @sovrasov @evgeny-izutov @vmatveic

@asmorkalov Could you please check what's wrong with CI?

LGTM

Jenkins please retry a build


Add Sequence support for shape arguments

Add Sequence[int] support for shape arguments in ChainerX functions, which only accept int and Tuple[int] at the moment.
Fixes #7427.
Note
I added #include <pybind11/stl.h> to chainerx_cc/chainerx/python/shape.h to avoid the following compilation error. It maybe related to pybind/pybind11#1055.
error message

    ...
    [ 98%] Building CXX object chainerx/python/CMakeFiles/_core.so.dir/shape.o
    [100%] Linking CXX shared module /home/user/chainer/chainerx/_core.so
    /home/user/chainer/build/temp.linux-x86_64-3.6/pybind11/include/pybind11/stl.h:179:49: error: type ‘struct type_caster’ violates one definition rule [-Werror=odr]
     template <typename Type, typename Alloc> struct type_caster<std::vector<Type, Alloc>>
                                                     ^
    /home/user/chainer/build/temp.linux-x86_64-3.6/pybind11/include/pybind11/cast.h:866:56: note: a type with different bases is defined in another translation unit
     template <typename type, typename SFINAE = void> class type_caster : public type_caster_base<type> { };
                                                            ^
    lto1: all warnings being treated as errors
    lto-wrapper: fatal error: /usr/bin/c++ returned 1 exit status
    compilation terminated.
    /usr/bin/ld: error: lto-wrapper failed
    collect2: error: ld returned 1 exit status
    chainerx/python/CMakeFiles/_core.so.dir/build.make:387: recipe for target '/home/user/chainer/chainerx/_core.so' failed
    make[3]: *** [/home/user/chainer/chainerx/_core.so] Error 1
    CMakeFiles/Makefile2:614: recipe for target 'chainerx/python/CMakeFiles/_core.so.dir/all' failed
    make[2]: *** [chainerx/python/CMakeFiles/_core.so.dir/all] Error 2
    CMakeFiles/Makefile2:626: recipe for target 'chainerx/python/CMakeFiles/_core.so.dir/rule' failed
    make[1]: *** [chainerx/python/CMakeFiles/_core.so.dir/rule] Error 2
    Makefile:281: recipe for target '_core.so' failed
    make: *** [_core.so] Error 2
    /home/user/.pyenv/versions/3.6.5/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
      warnings.warn(msg)
    Traceback (most recent call last):
      File "<string>", line 1, in <module>
      File "/home/user/chainer/setup.py", line 197, in <module>
        setup(**setup_kwargs)
      File "/home/user/.pyenv/versions/3.6.5/lib/python3.6/site-packages/setuptools/__init__.py", line 129, in setup
        return distutils.core.setup(**attrs)
      File "/home/user/.pyenv/versions/3.6.5/lib/python3.6/distutils/core.py", line 148, in setup
        dist.run_commands()
      File "/home/user/.pyenv/versions/3.6.5/lib/python3.6/distutils/dist.py", line 955, in run_commands
        self.run_command(cmd)
      File "/home/user/.pyenv/versions/3.6.5/lib/python3.6/distutils/dist.py", line 974, in run_command
        cmd_obj.run()
      File "/home/user/.pyenv/versions/3.6.5/lib/python3.6/site-packages/setuptools/command/develop.py", line 36, in run
        self.install_for_development()
      File "/home/user/.pyenv/versions/3.6.5/lib/python3.6/site-packages/setuptools/command/develop.py", line 136, in install_for_development
        self.run_command('build_ext')
      File "/home/user/.pyenv/versions/3.6.5/lib/python3.6/distutils/cmd.py", line 313, in run_command
        self.distribution.run_command(command)
      File "/home/user/.pyenv/versions/3.6.5/lib/python3.6/distutils/dist.py", line 974, in run_command
        cmd_obj.run()
      File "/home/user/chainer/chainerx_build_helper.py", line 37, in run
        self.build_extension(ext)
      File "/home/user/chainer/chainerx_build_helper.py", line 88, in build_extension
        ['cmake', '--build', '.'] + build_args, cwd=self.build_temp)
      File "/home/user/.pyenv/versions/3.6.5/lib/python3.6/subprocess.py", line 291, in check_call
        raise CalledProcessError(retcode, cmd)
    subprocess.CalledProcessError: Command '['cmake', '--build', '.', '--config', 'Release', '--', '_core.so']' returned non-zero exit status 2.

Jenkins, test this please.

Jenkins CI test (for commit ecdab5abcc2f369f0364ac1ffe140cdda93e3cee, target branch master) failed with status FAILURE.

Jenkins, test this please

Jenkins CI test (for commit fcbd0aa0e0302bb5290e263bf7f8cdd05a73feaf, target branch master) failed with status FAILURE.

Jenkins, test this please

Jenkins CI test (for commit fcbd0aa0e0302bb5290e263bf7f8cdd05a73feaf, target branch master) succeeded!

LGTM

Jenkins CI test (for commit fcbd0aa0e0302bb5290e263bf7f8cdd05a73feaf, target branch master) succeeded!


The parameters suggestedMin/Max have no effect on chart type horizontalBar.

Bug demo: https://codepen.io/bitflower/pen/KyXEEx
Working demo with chart type 'line': http://www.chartjs.org/samples/latest/scales/linear/min-max-suggested.html
Summary
The parameters suggestedMin/Max have no effect on chart type horizontalBar.
Expected Behavior
The expected upper limit of the scale is 50 as set by suggestedMax.
Current Behavior
However it is not considered and the max value of 40 is derived from the real data. It works in other chart types like bar.
Environment

Chart.js version: 2.7.1
Browser name and version: Chrome 62

Looking at the code I see that horizontalBar's yAxes scale is treated as type 'category'. Any chance this can use the suggested* configs?

My fault: had to use the X axe instead of y: https://github.com/bitflower/Chart.js/commit/81bdeedd2ce13e7ca149bdf09126e15e8c1b5051


chore(main): release ec2 0.1.0

:robot: I have created a release beep boop
0.1.0 (2024-10-05)
Features

ec2: add a module that creates an ec2 instance (#6) (3471336)

This PR was generated with Release Please. See documentation.

🤖 Created releases:

ec2-v0.1.0

:sunflower:


Swapping if/else does not work

I thought this used to work:

But it does not swap the branches.
If this is a who-wins thing, I would definitely expect the if branch to move when the cursor is on the if or else.

Yes, it used to. However, I found it hard to remember when to use left/right vs up/down, and there were conflicts with existing shortcuts (expand/shrink selection). Therefore I've changed most move actions to up/down and removed left/right. In cases where there is a conflict (here: move statement vs move if branch), the less common action (here: move if branch) is only accessible through the move context menu (or the refactor context menu). You can access it with Ctrl+Alt+m on Windows.
It seems you have custom shortcuts set up tho? Maybe there is a good way to provide code action kinds that would work for such custom setups 🤔

It seems you have custom shortcuts set up tho? Maybe there is a good way to provide code action kinds that would work for such custom setups 🤔

Just removed them.

Therefore I've changed most move actions to up/down and removed left/right.

I like that!

In cases where there is a conflict (here: move statement vs move if branch), the less common action (here: move if branch) is only accessible through the move context menu (or the refactor context menu). You can access it with Ctrl+Alt+m on Windows.

I would use anchors to distinguish between these cases.
E.g. when the cursor is no the else or if, it should swap branches. Otherwise the statement.

I would use anchors to distinguish between these cases. E.g. when the cursor is no the else or if, it should swap branches. Otherwise the statement.

I was thinking the same and first prototyped enabling move up/down from the else keyword. That leads to issues with the inverse action, so really the branch switch also needs to be activated on the if as well. However, this conflicts with move statement, because you can move all other statements at the beginning of the statement. I'm sure there are ways around it with different activation ranges (i.e. cursor positions / selections), but they are not necessarily obvious or easy to learn imo.
My current take is that learnability is one of the main challenges with the JavaScript Assistant, and I want to make it easier by having fairly simple systems for common cases (move up/down) and then context menus for different intents (e.g. move, extract, convert) with more specialized actions. While different activation ranges are part of it, I try not to make them too complex - otherwise it gets hard to find/activate the right code assist.
I'm open to changing this of course if I get more feedback or additional functionality like move in / move out requires it.

Fair points. What about using the if/else-if condition as anchor?

That could work - re-opening the issue. The one conflict I could see is with Move expression in homogenous condition (a && |b && c -> |b && a && c) (note: overlap/replacement of 'flip operator'), so I'll wait until that is available and then I'll experiment to see how activating on the condition would work.

Hmm, it is a bummer that this still does not work:

I would say reordering is the most valuable feature that p42 offers, but it often does not work :(

Hey thanks for bringing this to my attention. The functionality is there, but it is currently hidden in the refactor menu. I'll look into a better key mapping this week, now that things have settled a bit around the shortcuts and the code action menu.

Check out v1.157.1 - the move if-else up/down can now be triggered on the condition. Outside of the condition, a regular move statement is triggered (to enable both operations to be easily accessible).


add storybook with Buttons

Thinking about the CTAs.
They have a simple rule of that a secondary CTA is only ever used with a primary one.
This is easy to code up quite neatly, using a PrimaryCTA, and a SecondaryCTA that requires a PrimaryCTA as an argument. Voilà.
Cardigan doesn't really support this in a neat fashion though, so starting to see if storybook might help?

@wellcometrust/experience-dev I've moved out any changes bar adding the story book app.
If we want, let's get this in or chuck it out. From a dev perspective, it's already saved me time, but if we think this is too much to be focusing on, that's understandable.

Merging as I find it useful for development.


fix: Add space after xmlns:wsu to prevent xmldom warning

This removes the following xmldom warning:
[xmldom warning]        attribute space is required"xmlns:wsu"!!
  at DOMHandler.warning (<root>/node_modules/@xmldom/xmldom/lib/dom-parser.js:251:29)
  at parseElementStartPart (<root>/node_modules/@xmldom/xmldom/lib/sax.js:398:19)
  at parse (<root>/node_modules/@xmldom/xmldom/lib/sax.js:167:15)
  at XMLReader.parse (<root>/node_modules/@xmldom/xmldom/lib/sax.js:47:3)
  at DOMParser.parseFromString (<root>/node_modules/@xmldom/xmldom/lib/dom-parser.js:96:7)
  at SignedXml.computeSignature (<root>/node_modules/xml-crypto/lib/signed-xml.js:721:23)
  at WSSecurityCert.postProcess (<root>/node_modules/soap/lib/security/WSSecurityCert.js:141:21)
  at Client._invoke (<root>/node_modules/soap/lib/client.js:357:33)
  at <root>/node_modules/soap/lib/client.js:187:18

This was because there was no space between the following attributes in the Security header:
<wsse:Security xmlns:wsu="docs.oasis-open.org/wss/2004/01/oasis-200401-wss-wssecurity-utility-1.0.xsd"soap:mustUnderstand="1">

This is now:
<wsse:Security xmlns:wsu="docs.oasis-open.org/wss/2004/01/oasis-200401-wss-wssecurity-utility-1.0.xsd" soap:mustUnderstand="1">

The required fix can be found in #1206 I will rebase once that is merged.

Hello, I am receiving the same error, this merge will resolve the issue.

I don't see any problem with this change, tried locally and all tests passed.


fix(client-go): pass arguments when using root command to list

Fixes #4357
This change got fairly in depth because of the new matching that had to be done to separate invalid commands from arguments passed to command:list.

Worked for me! Code LGTM

LGTM. I tested this interactively with as many variations on command-line flags as I could think of.


code in musegan.ipynb

Hi @salu133445 Thank you for useful repo !
When I try musegan.ipynb in Settings part , I found that the program number for each track is programs = [0, 0, 25, 33, 48], track_names = ['Drums', 'Piano', 'Guitar', 'Bass', 'Strings']. Is the program number of the drum wrong, or did I miss something?

The program numbers are for creating MIDI samples. In MIDI, drums have a dedicated channel and program numbers have no effect for drums.

The program numbers are for creating MIDI samples. In MIDI, drums have a dedicated channel and program numbers have no effect for drums.

The program numbers are for creating MIDI samples. In MIDI, drums have a dedicated channel and program numbers have no effect for drums.

Got that, thank you.

The program numbers are for creating MIDI samples. In MIDI, drums have a dedicated channel and program numbers have no effect for drums.

Got that, thank you.


[WIP] Script to seed db

I've created a script to seed the database with Fake Students, Fake Admins, and Fake Classrooms with Fake Students as discussed with @tarunsinghal92
The script can be run by using npm run seed:db

Creates a Master Admin and displays its username and password. Can be used by the user to log in.
Creates Fake Students and Fake Admins.
Creates Fake Classrooms with a random number of Fake Students.

I've some doubts about creating Fake Journal mapped to Fake Students.
How much fake the Fake Journals have to be?

Should fake journals entries have to be related to all available activities and have accurate data corresponding to those activities.
or
Should fake journals entries can be related to 5-6 activities and have corresponding data. Students can randomly have any number of journal entries.

Screenshot:

P.S. Currently it's hardcoded to seed 5 Students, 5 Admins, and 5 Classrooms.

Not sure to understand why we need this script. Is it for testing?

@NikhilM98 we need a script to init the database for our current deployment with something similar to your script but with a CSV file as input. Could you adapt your script ?
The idea will be to use an input CSV file with columns:
Name,[Type],[Language],[Color],[Password],[Classroom]
Everything except Name is optional and will be set to default if not provided: default type is student, default language is en, default color is random, default password is random, no classroom by default.
Rules will be for each line:

Create a new user with properties,
Add the user in the matching classroom,
If an user with this name already exist, write a warning and ignore the line,
If a classroom with this name don't exist, create it.

The script should produce a CSV file with all properties for created users (to have a way to retrieve generated password).

@llaske Okay. I'll do it.

No longer need since https://github.com/llaske/sugarizer-server/pull/168


flip equation?

https://github.com/nexlabs22/Nex-Dex-Contracts/blob/c7b8a4164694afa61cabd8f3e642e94c8fc30a5e/contracts/Exchange.sol#L899
Example:
Oracle price is 100ETH/per APE right
So 1000USDC/100APES = 10$ per APE
Flip the nominator with the denominator? for currentPrice &  newPrice

Oracle has usd price too.

See my other reply

I got it.
https://github.com/nexlabs22/Nex-Dex-Contracts/blob/8347102a56aa17d097d5806c36100af0f0f5e430/contracts/Exchange.sol#L862

I got it.
https://github.com/nexlabs22/Nex-Dex-Contracts/blob/8347102a56aa17d097d5806c36100af0f0f5e430/contracts/Exchange.sol#L862


chore(doc):move REST API wiki page to source code

What is the current behavior? (You can also link to an open issue here)
web Api documentation is in the wiki hence not versioned along with the code
What is the new behavior?
Web Api documentation is versioned along with the code.
Please check if the PR fulfills these requirements

[x] The commit message follows Talend standard
[ ] Tests for the changes have been added (for bug fixes / features)
[x] Docs have been added / updated (for bug fixes / features) ?
[ ] The code coverage on new code >75%
[ ] The new code does not introduce new technical issues (sonar / eslint)

What kind of change does this PR introduce?

[ ] Bugfix

[ ] Feature

[ ] Code style update (formatting, local variables)

[ ] Refactoring (no functional changes, no api changes)

[ ] Build / CI related changes

[x] Other... Please describe:
Documentation
Does this PR introduce a breaking change?

[ ] Yes

[x] No

Pull request test result: success :star:
Sonar results

Pull request test result: success :star:
Sonar results


Export Doesn't Read The "Exclude in export?" Column Property

When the "Exclude in export?" option is checked in the Datalist Column property, the data within that column is still being exported.
Expected outcome: The exported data should exclude the specified column.

fixed in 8.0.2 release, columns which are set to hidden or excluded in report, will not be exported.


Update API endpoints to use Northstar ID instead of Drupal ID

What's this PR do?
Updates /campaigns/:id/signup and /campaigns/:id/reportback to use the user's Northstar ID instead of Drupal UID in logic in case a user doesn't have a Drupal UID.
How should this be reviewed?
Sign up for a campaign via /campaigns/:id/signup and it should be reflected in Rogue.
Reportback for a campaign via campaigns/:id/reportback and it should be reflected in Rogue.
Any background context you want to provide?

@DFurnes this should squash the bug and not introduce any problems assuming everyone has a Northstar ID?
Did I miss any other endpoints?

Relevant tickets
Fixes https://github.com/DoSomething/gambit/issues/922
https://www.pivotaltracker.com/n/projects/2019429/stories/150138796
cc @aaronschachter
Checklist

[ ] Documentation added for new features/changed endpoints.
[ ] Tested on staging.
[ ] Pinged a PM if this is a larger PR that would benefit from some additional testing love
[ ] Post a message in #phoenix if this includes something that causes a rebuild!

Ah, so there's an extra piece here that wasn't really documented in the ticket: we want this endpoint to work even if the user doesn't have a Drupal ID at all, so we need to bypass any code that relies on a uid or loaded $user object if a Northstar ID is provided. ↪

Thanks for clarifying, @DFurnes ! I think this will work though even if the user doesn't have a Drupal ID at all, assuming all users have a Northstar ID? Because the Northstar ID will get passed each time and be used. The places where a loaded $user object is loaded is the DS API user in these cases (I'm pretty sure)?


Feat/custom icon components

This a a PR for an issue I submitted for customizable sort components: #478

@RedTn sorry for the delay in communication. I had a weird week with holidays, vacation, and other stuff...
Will try to get to it early this week, but on first glance looks good.

Feel free to let me know if anything needs to be changed/updated

@alexander-alvarez Checking up on this PR, thanks alexander!

Thanks so much @RedTn :heart:


qemu-vm: Make it possible to adjust RAM allocation at runtime

This is handy with things like nixos-rebuild build-vm, where there isn't a good way to expose the memorySize parameter to the user.

Doesn't setting QEMU_OPTS="-m SIZE" work?

Oh you're right, that totally does work.  I incorrectly assumed that the first instance of -m <something> on the qemu commandline would take precedence.


[Spark] Only enable a single legacy feature with legacy metadata properties

Which Delta project/connector is this regarding?

[X] Spark
[ ] Standalone
[ ] Flink
[ ] Kernel
[ ] Other (fill in here)

Description
Currently enabling legacy features on legacy protocols with metadata properties results to enabling all preceding legacy features. For example, enabling enableChangeDataFeed results to protocol (1, 4). This is inconsistent with the rest protocol operations. In this PR, we fix this inconsistency by always enabling only the requested feature. This is a behavioral change.
How was this patch tested?
Existing and new unit tests.
Does this PR introduce any user-facing changes?
Yes. When enabling a feature using a table property, e.g. by setting delta.enableChangeDataFeed to true, then in the previous situation you would typically get protocol (1, 4). Now you would get (1, 7, changeDataFeed). The user can get (1, 4) by also asking for delta.minWriterVersion = 4. This change is OK now because (a) enabling fewer features is safer than enabling more features, and (b) Deletion Vectors requires table features support, and it is very popular to implement, so many clients have added support table features, (c) users can easily get back to the legacy protocol by ALTERing the protocol and asking for delta.minWriterVersion = 4.

Spark master test failures are unrelated.


Improve runtime of CI workflow

This will split the tests workflow into multiple separate workflows. Each workflow is only triggered by changes to files in specified directories to prevent the execution of tests for unchanged code. All tests will still be performed on a daily basis (nightly tests).

A problem of this approach is that status checks cannot be made required anymore. I don't think GitHub will solve that issue in the near future (https://github.community/t/feature-request-conditional-required-checks/). An alternative could be using one of these GitHub actions instead: https://github.com/technote-space/get-diff-action, https://github.com/fkirc/skip-duplicate-actions.

I had to change the tests workflow to be able to make all checks required when matrix is used. The disadvantage of the current version is that it is not obvious if a check was skipped (it will always get a green checkmark). It is only visible by looking into the details of a check if all steps are skipped. I'm not aware of a better solution.


Native language support

Added ability to parse feature files in the users native language.
If language is specified in Specflow's app.config you will need to specify here as well.
CommandLine -l | -language=sv-SE
MsBuild task Language="sv-SE"
NAnt task language="sv-SE"
If language is specified in the feature file with # language: sv nothing is needed here.
HAXEN

WOW!  Thank you for this, very much appreciated.   Looks great.


Update STM32 HAL

Some updates in upstream STM32Cube are required to get Keychron Q1 (STM32L4) works. This PR cherry-picked some commits from zephyr v3.1-branch.

Is this still required after our Zephyr 3.2 update?

Is this still required after our Zephyr 3.2 update?

I think it is not needed anymore. But I haven't test it yet.


Bump int-tester to ^3.1.0

Codecov Report

Merging #15 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##           master    #15   +/-   ##
=====================================
  Coverage     100%   100%
=====================================
  Files           1      1
  Lines          34     34
=====================================
  Hits           34     34

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 46c0a18...00d1459. Read the comment docs.

CC @hankim813


[WIP] Variable length trials fix

Just two small changes to fix cropped decoding to work with variable length trials. Tests does not work locally in my case (no clue why), so let's check here. Trying to solve #222

Great I think this can be merged, but would be great if you can add some comments so we know what we were doing there and why

I added comments you asked for, I also modified EEGRegressor to work the same way as EEGClassifier.
I still have some doubts whether the predict_proba should work with variable length trials (for scoring it should be ok). In particular, I don't know what will be the output of skorch predict_proba method when provided with observation of different shape. I've never done this before. Maybe we should create a test for that? It would need a custom DataLoader?  @robintibor  As you've already tested it on your side maybe you have a minimal working example for variable length trials decoding that we can use a starting point for the test?

I think my example is too complex, also requires loading TUH etc., but I can also see whether I can distill something out of it, if you have time before to make a test, also great, otherwise I will see

ok since my colleague needs it quite urgently now, merging this and we can do test in separate PR potentially.


Fix Discord domain in docs

Powered by
rg '(?<!cdn.)discordapp.com' --pcre2 --files-with-matches | xargs gsed -i 's/discordapp\.com/discord\.com/g'

in case you want to fix more of your own projects.

Whoops. Thanks ❤


Multiple connection after error or end

After losing a connection (catching 'end' event) I try to reconnect in 30 seconds.
Then the connection established, I get not one but two, three or more connections to imap server.
This happens because of not disconnecting imap after 'end' or 'error'.
I try to stop before each start of notifier but it not works, because notifier checks self.connected, so I removed this check from Notifier.prototype.stop and all works fine for me.
Can you fix this, or give an example how to reconnect to server after losing or some another ending of connection.

Indeed, there was a bug when restarting that caused to be notified twice (or more).
This is fix in 8f439e19970ddfe524e76e23e3ddfd57e18d12c7


[CN-Translation]k8smeetup-kubeadm-upgrade-1-8

preview at:
https://k8smeetup.github.io/docs/tasks/administer-cluster/kubeadm-upgrade-1-8/
https://k8smeetup.github.io/docs/tasks/administer-cluster/out-of-resource/

This change is

/cc @zhangxiaoyu-zidif


separate verbose options for compute_psd and joblib

Describe the new feature or enhancement
Add the option to control the verbosity of joblib without affecting the verbosity of joblib. See discussion here:
https://mne.discourse.group/t/remove-output-from-joblib/7303
Describe your proposed implementation
Proposed by @drammock and @larsoner:
one reasonable approach might be a config value (MNE_JOBLIB_LOGGING_LEVEL or so) that can be set separately from the global logging level.
Sounds good to me. We could add it to set_log_level and use_log_level, and have the default joblib_verbose=None mean “use the verbose level” (which would preserve backward compat)
Copied from:
https://mne.discourse.group/t/remove-output-from-joblib/7303
Describe possible alternatives
N/A
Additional context
No response

@chapochn do you want to give this a shot?

Working on another PR right now, so not immediately...


Fix memory leaks in webp encoding

Hi,
I noticed that long running programs which encode a lot of webp images accumulate memory very fast.
This is my attempt at fixing these memory leaks. It's my first time working with unsafe rust, so I am not sure if I caught everything.  I used the following tests to simulate load:
#[test]
fn test_if_webp_encode_has_memory_leak() -> ril::Result<()> {
    let img = Image::new(10, 10, Rgb::new(0, 0, 0));

    let mut out = Vec::new();

    for _ in 0..100000 {
        out.clear();
        img.encode(ImageFormat::WebP, &mut out).expect("encode failed:");
    }

    Ok(())
}

#[test]
fn test_if_webp_decode_has_memory_leak() -> ril::Result<()> {
    let mut webp_bytes = Vec::new();
    Image::new(10, 10, Rgb::new(0, 0, 0))
        .encode(ImageFormat::WebP, &mut webp_bytes)
        .expect("encode failed:");

    for _ in 0..200000 {
        Image::<Dynamic>::from_bytes(ImageFormat::WebP, &webp_bytes).expect("decode failed:");
    }

    Ok(())
}

#[test]
fn test_if_animated_webp_encode_has_memory_leak() -> ril::Result<()> {
    let black = Frame::from_image(Image::new(10, 10, Rgb::black())).with_delay(Duration::from_millis(100));
    let white = Frame::from_image(Image::new(10, 10, Rgb::white())).with_delay(Duration::from_millis(100));

    let mut out = Vec::new();

    for _ in 0..100000 {
        let mut seq = ImageSequence::new();
        seq.push_frame(black.clone());
        seq.push_frame(white.clone());

        out.clear();
        seq.encode(ImageFormat::WebP, &mut out).expect("encode failed:");
    }

    Ok(())
}

#[test]
fn test_if_animated_webp_decode_has_memory_leak() -> ril::Result<()> {
    let black = Frame::from_image(Image::new(10, 10, Rgb::black())).with_delay(Duration::from_millis(100));
    let white = Frame::from_image(Image::new(10, 10, Rgb::white())).with_delay(Duration::from_millis(100));

    let mut seq = ImageSequence::new();
    seq.push_frame(black.clone());
    seq.push_frame(white.clone());

    let mut webp_bytes = Vec::new();
    seq.encode(ImageFormat::WebP, &mut webp_bytes).expect("encode failed:");

    for _ in 0..200000 {
        ImageSequence::<Dynamic>::from_bytes(ImageFormat::WebP, &webp_bytes).expect("decode failed:");
    }

    Ok(())
}

Without my fixes the memory consumption quickly climes to hundreds of MB for both encoding tests. With the patch applied it stays at around 10MB for me. Decoding seams to work fine.
The most important change is the call to libwebp::WebPDataClear after the encoded image was written to the rust writer in WebPEncoder.encode. I also tried to ensure the freeing is done before each return in case of an error.
If you want I can also push the tests to test_webp.rs. I was not sure if this makes sense because they do not assert anything and run for about 30 seconds. They require a human to look at the memory usage of the test runner :)

LGTM, and I would say tests aren't required


Upgrade expat to 2.6.3 to fix CVE-2024-45490, CVE-2024-45491, CVE-2024-45492

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

[x] The toolchain has been rebuilt successfully (or no changes were made to it)
[x] The toolchain/worker package manifests are up-to-date
[x] Any updated packages successfully build (or no packages were changed)
[x] Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
[x] Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
[x] All package sources are available
[x] cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
[x] LICENSE-MAP files are up-to-date (./LICENSES-AND-NOTICES/SPECS/data/licenses.json, ./LICENSES-AND-NOTICES/SPECS/LICENSES-MAP.md, ./LICENSES-AND-NOTICES/SPECS/LICENSE-EXCEPTIONS.PHOTON)
[x] All source files have up-to-date hashes in the *.signatures.json files
[x] sudo make go-tidy-all and sudo make go-test-coverage pass
[x] Documentation has been updated to match any changes to the build system
[x] Ready to merge

Summary

Upgrade expat to 2.6.3 to fix CVE-2024-45490, CVE-2024-45491, CVE-2024-45492
Change Log

Upgrade expat to 2.6.3 to fix CVE-2024-45490, CVE-2024-45491, CVE-2024-45492

Does this affect the toolchain?

YES
Links to CVEs

https://nvd.nist.gov/vuln/detail/CVE-2024-45490
https://nvd.nist.gov/vuln/detail/CVE-2024-45491
https://nvd.nist.gov/vuln/detail/CVE-2024-45492

Test Methodology

Pipeline build id: 636988 (full), 636996 (buddy)

Auto cherry-pick results:

main :white_check_mark: -> https://github.com/microsoft/azurelinux/pull/10401

Auto cherry-pick pipeline run -> https://dev.azure.com/mariner-org/mariner/_build/results?buildId=637452&view=results


State of Adv. Data Structures/Algos in Beta

This Issue is for tracking improvements to the Advanced Algorithms and Data Structures Section in Beta
The original draft of all of these challenges can be found here.

Currently the following needs to be done:
Tests:

[ ] Review tests for Sets challenges from 'union' challenge to end and verify solutions pass.
[ ] Review all tests for Linked List section and verify solutions pass.
[ ] Review/Revise Circular Queue Challenge and verify solutions.
[ ] Review tests for Graphs DFS & BFS / verify solutions.

Formatting:

[ ] Review all challenges and ensure they are in the correct format, i.e. <code> tags, <blockquote> tags for code examples, etc. for the challenge content, instructions, and tests (many challenges need this).
[ ] Review all challenges for any modifications to content.
[ ] Standardize langauge.
[ ] Review seed code to avoid linting errors when code is seeded.
[ ] The GIFs in the Graph challenges may need some revision.
[ ] The seed code for some challenges is extremely verbose.

What Has Been Done:

[x] Challenge sequence has been re-arranged and repeated challenges have been removed.
[x] Moved all sorting algorithms to adv. algorithms section and verified that the tests work. A note on these: currently the tests are only verifying the sorting behavior, not in any way verifying that the intended sorting method was implemented correctly. Writing tests to evaluate this is certainly open for discussion here.
[x] Solution code correctly passes the tests for all of the following: Typed Arrays, Maps, and Trees.

Notes:

Currently trying to progress to the next challenge after passing the last challenge in the curriculum produces erroneous behavior.
There's still space for more advanced algorithms to be added! For instance, recursion, dynamic programming, or generally just some more difficult algorithm challenges would be interesting to add here for campers to work on.

@bonham000 Hey Sean, I'm not sure if you're assigning issues, but if you are I'd like to take a crack at verifying Linked Lists solutions are passing all tests.

I'm not exactly assigning but I think anyone wanting to work on these challenges should discuss it here so we don't get in each other's way! Currently, I'm been waiting on my last PR to be merged before I continue working on these.
But yes it would be great if you want to try to verify the Linked List solutions are working. I found a lot of problems with some of the other challenge tests/solutions so it's possible that there may be many issues with these as well.

Cool, I'll jump on those and if I run into any trouble or power through them and can pick up another task to lighten your load I'll report back!

Ok! By the way, when my PR is merged that challenge seed file is going to look totally different so it may be hard to start a contribution to it right now before it gets merged!

Fyi @TheeMattOliver I just re-submitted my prior PR with a few additional changes to these sections. Once it is merged then by all means take a look at reviewing the Linked List challenges/solutions/tests if you still want to!

Hey there, definitely!
I'm trying to write a new test bc the remove method doesn't actually work the way it should.
Sent from my iPhone

On Jan 25, 2017, at 2:11 AM, Sean Smith<EMAIL_ADDRESS>wrote:
Fyi @TheeMattOliver I just re-submitted my prior PR with a few additional changes to these sections. Once it is merged then by all means take a look at reviewing the Linked List challenges/solutions/tests if you still want to!
―
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

@TheeMattOliver sounds great! Feel free to message me on Gitter if you want to coordinate more about getting these tests working, I know that when I was looking through the challenges I realized some of the challenges had really inadequate tests.

cool, will do.
On Wed, Jan 25, 2017 at 1:48 PM, Sean Smith<EMAIL_ADDRESS>wrote:

@TheeMattOliver https://github.com/TheeMattOliver sounds great! Feel
free to message me on Gitter if you want to coordinate more about getting
these tests working, I know that when I was looking through the challenges
I realized some of the challenges had really inadequate tests.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/freeCodeCamp/freeCodeCamp/issues/12757#issuecomment-275212637,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AJcRJmWL4RtLpUOEXFQNPF83JjYr1wfvks5rV6b-gaJpZM4Lqj0d
.

Just waiting...
On Wed, Jan 25, 2017 at 2:25 PM, Matt Oliver <
<EMAIL_ADDRESS>wrote:

cool, will do.
On Wed, Jan 25, 2017 at 1:48 PM, Sean Smith<EMAIL_ADDRESS>wrote:

@TheeMattOliver https://github.com/TheeMattOliver sounds great! Feel
free to message me on Gitter if you want to coordinate more about getting
these tests working, I know that when I was looking through the challenges
I realized some of the challenges had really inadequate tests.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/freeCodeCamp/freeCodeCamp/issues/12757#issuecomment-275212637,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AJcRJmWL4RtLpUOEXFQNPF83JjYr1wfvks5rV6b-gaJpZM4Lqj0d
.

Hey @TheeMattOliver it's been merged! Looks like we should be good to go for continued improvements here. If you want to take a look at the Linked List challenges I will confine my changes to the Sets, Circular Queue, and Graphs challenges.

Great!
Sent from my iPhone

On Jan 28, 2017, at 1:50 AM, Sean Smith<EMAIL_ADDRESS>wrote:
Hey @TheeMattOliver it's been merged! Looks like we should be good to go for continued improvements here. If you want to take a look at the Linked List challenges I will confine my changes to the Sets, Circular Queue, and Graphs challenges.
―
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

I've slowly started checking the formatting of the text in the challenges I've written. I haven't started doing functionality testing by testing if the tests and solutions work.

@erictleung nice thanks for helping review these! Your challenges look really good.
When I initialized checked I think that only the tests for Graphs BFS and DFS didn't work, but I think for all the other challenges you submitted the provided solutions passed all the tests.
Also, the point I wrote about the GIFs for the Graph challenges was mainly about the sizing of the images, which I'm sure you'll see in Beta when you look at them if you haven't already. Might be able to fix this with inline styles?

@bonham000 thanks! I'm just about to make a PR for BFS and found an error in one of the tests and fixed it. I probably missed something similar in the DFS challenge. I've added img-responsive to the BFS challenge but I think it is more needed in the DFS challenge. I'll see if it helps for the DFS challenge soon.

Review tests for Sets challenges from 'union' challenge to end and verify solutions pass.

@Ethan-Arrowood yes that's a great starting point. You can find the original drafts of the challenges (with solution code) in the link at the top. I think we are trying to add passing solutions to the all the tests under the solutions: [] entry for each challenge (not all challenge have this filled in but a few do, which you can look at as an example). This is for the purposes of running tests on the code.
Also, know that some of these challenges don't have great tests or solutions written (I know by looking through them, but have not gone through and corrected all of them). So if you feel confident that some part of the challenge needs to change (i.e. intro text, instructions, or tests, etc.) feel free to change it and we can take a look at the PR.
On a few I've reviewed I've changed large parts of the challenges. Good luck!
Btw, if you're working on this feel free to message me on Gitter it'll be easier to communicate about specific questions.

@bonham000 Great. Thank you for all the great information. I'll make sure to message you on Gitter if I run into any issues! Thanks again 👍

@bonham000 I've been making some great changes so far. Tell me what you think of tests like these. I plan to go back through the other challenges and add similar tests that also act as decent examples. Similarly, can you expand on the solutions part of each of these challenges? They run the same with or without them so I'm just unsure what their purpose is. Also what is name of Gitter I tried searching bonham000 and Sean Smith but i couldn't find you.

@Ethan-Arrowood the main thing with the tests I think is that they really verify if the user has completed whatever functionality they are testing and provide a useful message about what the test is. Overall, there is not a ton of consistency with the way the tests are written in these challenges so there is always room for improvement but the minimumw goal would be just to have functioning tests that correctly verify the solution.
With the solution it is for running npm test locally to execute tests on the FCC code. So I believe if there is solution code it will try to run this against the challenge code itself and see if it passes the tests. So adding a solution code which passes the tests is a good safeguard against any future updates to the challenge seed code or tests, and I think preferably should be added anytime someone works on one of these challenges where the solution has not been added yet.

@bonham000 you can go ahead and check off

Review tests for Sets challenges from 'union' challenge to end and verify solutions pass.

My commit with these challenges was just merged 😄

Ok, awesome @Ethan-Arrowood! I'll check it off. I just looked at the PR, nice job!

@bonham000 thank you 😄

@bonham000 for linked lists should we use the list.length() method or list.size() method to get the number of elements? There are discrepancies throughout all the challenges causing a bunch of test conflicts. I just need to know what the standard should be and I'll make the change.

I'm closing this issue as stale since it hasn't been active lately. If you think this is still relevant to the newly updated platform, please explain why, then reopen it.


What's "test-apps/" ?

I tried to reproduce your results using the instructions in the README.md file in the replication/ directory, but I encountered the following problem:
/scripts/setup_test_apps.sh: line 6: cd: test-apps: No such file or directory
Upon reviewing your scripts, I noticed that you test the code by running it in a Docker container with files located in replication/test-apps/. However, this directory does not exist in your GitHub project. Could you please provide guidance on what files I should put in this directory and in what format?

Can you please specify which command you ran which led to the error message? It is possible there is a typo somewhere in the scripts
You will need to follow the setup instructions here: https://github.com/microsoft/codamosa/tree/main/replication#start-the-benchmark-container to populate the test-apps subdirectory properly. This directory will then contain the source code for the projects we pull benchmarks from; we are not distributing that source code directly.

Well, this instruction never told me how to populate the test-apps directory, and that is exactly what I am most confused about.
For me, I just clone this repository, and run sudo bash replication/scripts/start_benchmark_container.sh  command. Did I miss any steps? What else should I do?

Did you load the docker container as well, as outlined above that instruction?
If not, do that first.
If so, try creating an empty directory named test-apps in the location where you will run the script. I thought the docker command should create it automatically, but it is possible it does not. I will fix the script accordingly if so.
The script bind mounts a directory in the docker container to a local 'test-apps' directory, and does all the population of that directory in docker. So you should not need to do anything more than create the empty directory and run the script.
If this does not work, please provide the system you are running on (OS and docker version) and all the commands run so I can better debug.

Thanks, that works! After I created a test-apps/ folder manually, I ran the script, and got permisson denied. Then I tried to edit the start_benchmark_container.sh script, to docker run --user=root, and then it starts downloads things.

Thanks, that works! After I created a test-apps/ folder manually, I ran the script, and got permisson denied. Then I tried to edit the start_benchmark_container.sh script, to docker run --user=root, and then it starts work.

Yes, I also agree that it would be better that more clarification be added so that users won't get stuck here.


add learn more missing icon in component step

Fixes

https://issues.redhat.com/browse/HAC-2377
Description

Adds missing icons near the Learn more quickstart link  in Add component step.
Type of change

[x] Bugfix

Screen shots / Gifs for design review

/lgtm

@karthikjeeyar there needs to be a space between the period and Learn more:

Updated code and screenshot.

/approve


bugsnag to datadog event stream

Mostly copied from the Slack one, with a small bit of tweaking, Datadog event streams are a bit limited in their formatting capabilities. But the event overlaying in Datadog is definitely working for me. Happy to make any changes necessary.

Thanks for this @rtortora - looks great! Only have one question, does datadog attribute special meaning to the environment tag or can we call it release stage (to keep it consistent with our terminology)?
Would it in any way be useful for a user to optionally specify tags for bugsnag events or can you already filter on the Bugsnag source?

Datadog tags are totally generic, so it can definitely be release stage instead. I think it's common to call it environment (at least on a rails stack) in Datadog, but I can't think of any reason why a different name would be problematic. I think the main use case of this is creating a feed of Bugsnags that can show up in a Datadog dashboard or be overlayed on a graph, both of which would be filtering on any specific tag, so... This works for me! Would you like me to change it to release_stage instead of environment?

I think release stage makes sense as that is what it is called for all our languages. Let me know when you've made the change and I can merge and release

Done! Looks like the standard multi-word approach for Datadog tags is "word-blah-blah" so I went with that. Figured I'd change it to app-version while I was at it. Let me know if you'd like any other changes.

Thanks @rtortora!


Using multi-threading for unsupported operations

Description
Hi,
I have trained an object detection model using the Tensorflow Lite Model maker. The last three unsupported operations need to be run by the CPU. I have manually splitted the tflite file into two tflite files, a head segment and tail segment. By invoking the head segment using the PyCoral API (contains only supported operations) and the tail segment (contains the unsupported operations) by tflite-runtime, which supports multi-threading. An increase of 2 FPS is achieved.
An edge tpu compiled tflite model in which the last three operations of the AI-model are not supported by the Coral, and therefore needs to be run by the CPU are not performed using multi-threading. I believe the PyCoral API does not provide the option to select  the amount of threads that needs to be used for unsupported operations. Is it possible to run the unsupported operations using multi-threading with the PyCoral API?
Frame rate PyCoral for full AI-model: 5.2 FPS
Frame rate PyCoral + tflite-runtime: 7.3 FPS
Click to expand!
Issue Type
Performance
Operating System
Linux
Coral Device
USB Accelerator
Other Devices
Rapsberry Pi 4
Programming Language
Python 3.9
Relevant Log Output
No response

Is it possible to run the unsupported operations using multi-threading with the PyCoral API?

No, its not possible.
But, Pycoral is just a wrapper around tflite-runtime. So, it should be fine if you were able to work with PyCoral + tflite-runtime. Thanks!!!

Alright! I just thought it would be interesting if this option was implemented into the PyCoral. The process of splitting a tflite file was rather complex.

Frame rate PyCoral for full AI-model: 5.2 FPS

Perhaps, you may try loading the model using tflite interpreter with num_threads instead of using pycoraledgetpu.make_interpreter.

Thanks for the suggestion. I have tried it, the frame rate is the same, i.e. around 5.2 - 5.4 FPS. Setting the amount of threads does not seem to influence the performance during inference.

Perhaps I should post this issue at https://github.com/iCorv/tflite-runtime/issues ?


unrecognized selector sent to instance

I have been getting this error when implementing the latest parse update with latest facebook sdk for XCode 7.
ParseStarterProject-Swift[2841:107652] -[PFUserAuthenticationController authenticationDelegateForAuthType:]: unrecognized selector sent to instance 0x7fd0bbc34620
2015-09-30 00:56:33.960 ParseStarterProject-Swift[2841:107652] *** Terminating app due to uncaught exception 'NSInvalidArgumentException', reason: '-[PFUserAuthenticationController authenticationDelegateForAuthType:]: unrecognized selector sent to instance 0x7fd0bbc34620'

It looks like you are using different versions of ParseFacebookUtils and Parse SDK.
Try getting the latest Parse SDK from releases page here or from Parse Downloads Page and replacing the current one - it should help.
Let me know if this works, or if there is anything else I can help you with.

tried doing it more than 10 times, but the issue is same. i downloaded the latest parse sdk and facebook sdk. still cant work it out.

Try cleaning your project?
Also - you can double check the version (they should match as of right now) in Info.plists of every framework.

even though i added the latest parse sdk, i have the following on my ifo.plist.

Try deleting it first, then if you can still find it - delete it again, then add it back to your app.
On Sep 30, 2015, at 7:26 PM, Rahul Shrestha <notifications<EMAIL_ADDRESS>wrote:
even though i added the latest parse sdk, i have the following on my ifo.plist.
[screenshot 2015-09-30 21 25 09]https://urldefense.proofpoint.com/v1/url?u=https://cloud.githubusercontent.com/assets/7716938/10211548/dee1e704-67b9-11e5-8e91-3403e1acc714.png&k=ZVNjlDMF0FElm4dQtryO4A%3D%3D
&r=zxFHBXEnKtFUPQxCGyQAqg%3D%3D
&m=jew6EOSQI882IT0MEINmLEt2vNhDHapSgnh0Exd2zT0%3D
&s=50b208654be5591c98b6089b35525feeab77d5f87e92f29999e387b1e4e7f472
—
Reply to this email directly or view it on GitHubhttps://github.com/ParsePlatform/Parse-SDK-iOS-OSX/issues/352#issuecomment-144599656.

tried everything, but no any luck. anyway , Thanks nlutsenko! (Y)

The current latest is 1.8.5 - that's the one you are looking for.