Use phin instead of request

phin is a lightweight, fast HTTP module with no dependencies. (Using phin instead of request cuts down dependency tree size by 22!)

Better would be to use no dependency at all and just the built-in http module.

@kgryte Trueeee, but who has time for that? xDDDdd


Remove start page from Calculators

Depends on #187 and https://github.com/alphagov/publisher/pull/629 tasks being run
Now Publisher and Frontend handle the start page for child benefit tax calculator (it's now a transaction), remove all traces of it.

Remove template, tests and routes
Remove old redirects from 2013
Stop sending anything to search (only the start page should be in search, like other services)
Only publish a content item for the calculator form
Request the calculator form content item (eg /main) (this changes the breadcrumb to the one defined on that content item, currently empty – as discussed with @carvil)

@ikennaokpala All the rummage code has been deleted, so the deploy task is trying to run a rake task that no longer exists.

Ahh right!! How can this be skipped.

It needs to be removed from here: https://github.com/alphagov/govuk-app-deployment/blob/master/calculators/config/deploy.rb#L16

@fofr I have raised this PR


Headers added by PR #12 break iframes

It appears that PR #12 adds an X-Frame-Options header set to DENY. We are currently using Cloudflare Sites to publish an internal React Storybook, and Storybook renders stories inside iframes, so this change has broken those deployments.
Would it be possible to make this header configurable in the wrangler.toml? We previously just set sites = "path/to/public/dir" to publish the site, but it doesn't look like there's a way to override this new header in the Wrangler config.

I'm experiencing the same issue.
This configuration is too restrictive by default and there's no way to override this.
We managed a solution changing the worker code and changing DENY to same-origin but in each deploy this would be overriden.
Would be great to be able to configure this using wrangler publish --params or being able to choose templates and having one that allow different X-Frame-Optionsvalues

This repo is a template for new projects, and the headers serve as reasonable defaults.
You should just be able to remove the headers from workers-site/index.js after using wrangler init --site or wrangler generate --site

I might be missing something here, but I only have a wrangler.toml alongside my public directory, and am able to deploy in CI with just that, running wranger publish. I don't have a workers-site/index.js to edit.
My wrangler.toml looks like:
name = "xxxxxx"
type = "javascript"
workers_dev = false
route = "example.com/*"
zone_id = "xxxxxx"
account_id = "xxxxxx"

[site]
bucket = "public"

@jacobwgillespie Ah, had to take a peek at the sites implementation to see what's going on.
You can run wrangler init --site inside of your project locally, which will then put the site worker code inside of your project (in the workers-site directory). This is exactly what wrangler publish is doing for you in CI every time your project is deployed. If wrangler sees that this has already been done, it will skip that step and use the code inside of workers-site/index.js.

Interesting, that explains it somewhat... It's been a while since I've read the documentation in detail, so not sure if this is something I picked up from someplace specific there.
To be a bit more clear about my use-case, I have an internal custom GitHub Action that publishes a static site in a directory to Cloudflare as a Cloudflare Site. The action already contains a copy of wrangler, installed via NPM. So consumers inside our org can add an action to their projects to publish, without needing to know anything about Cloudflare/Wranger. Something like this (simplified):
steps:
  - uses: org/publish-cloudflare-site
    with:
      dir: path/to/public
      domain: site.example.com

Then internally inside the action, it writes a wrangler.toml to disk, filling in the details, and calls wrangler publish.
My immediate fix is probably having the action also pre-generate the workers-site/index.js as well.
That said, it would also be cool for Wranger to have a way to publish a directory of static files as a site, without needing a ton of extra config. The only very important config bits are just the directory of files and the target route after all. It kinda has this now, by simply running wrangler publish, besides this issue with the header change, but I understand that wasn't entirely intentional.

I think your use case is exactly what we're aiming at with Cloudflare Pages, which is now in open beta :)

This repo is a template for new projects, and the headers serve as reasonable defaults.
You should just be able to remove the headers from workers-site/index.js after using wrangler init --site or wrangler generate --site.

I saw the headers that are the root of the problem in the workers-site/index.js, that's why I landed here

You can run wrangler init --site inside of your project locally, which will then put the site worker code inside of your project (in the workers-site directory). This is exactly what wrangler publish is doing for you in CI every time your project is deployed. If wrangler sees that this has already been done, it will skip that step and use the code inside of workers-site/index.js.

What I didn't know is that wrangler would skip overwriting the file.
We didn't include the workers-site in our repository as I thought that was something temporal wrangler needed, didn't give more importance.

I think your use case is exactly what we're aiming at with Cloudflare Pages, which is now in open beta :)

Looks like pages need to be linked to github, there's no option to use any other scm like Gitlab?
Anyway, looks I can continue my journey after reading the replies, thanks @xortive for all the info

I think your use case is exactly what we're aiming at with Cloudflare Pages, which is now in open beta :)

This isn't quite what we're going for - you could think of pull vs push, where Cloudflare Pages is a pull model, as Cloudflare connects to your repo, pulls in source code, runs builds, and publishes the result. Instead we have a push model, where we have a static site artifact produced in CI, and we want to push those files to a Cloudflare Site. There's not a 1-1 mapping between repos and published sites, and we have to build the sites as part of a larger monorepo pipeline that wouldn't fit into the model of Cloudflare Pages.

Pre-generating the workers-site/index.js is working perfectly, we're able to modify the headers there and publish our Storybook sites again. Thanks for the pointer!
Closing this issue...


:stories: JSON Query to graphql/query: HTTP error code 502

Describe the bug
Unable to run :stories for 3 days.
To Reproduce
instaloader -l @AccountName --password ~AccountPassword :stories --no-compress-json --dirname-pattern={profile}
Expected behavior
I have been running the same command for about 20 days consecutively and download all the storie s
Error messages and tracebacks
Retrieving all visible stories...
JSON Query to graphql/query: HTTP error code 502. [retrying; skip with ^C]
JSON Query to graphql/query: HTTP error code 502. [retrying; skip with ^C]
:stories: JSON Query to graphql/query: HTTP error code 502.
Saved session to /tmp/.instaloader-me/session-@swayyydata.
Errors occured:
:stories: JSON Query to graphql/query: HTTP error code 502.
Instaloader version
4.1.1
Additional context
Add any other context about the problem here.

Hi,
http error codes 5XX indicate an error on the server side. So this does not seem to be a problem with Instaloader. We test the ":stories" target daily without the occurrence of any error.
Are you able to see the stories in your browser?

I am closing this since this issue is inactive and on first glance it seems a problem on server's side. Please feel free to reopen this issue if there are any updates.


💬 comments (some TODOs added)

Gotta stop spamming the PRs too, for sure. This shouldn't be done this way 💀
Simple pushes into main are all it takes


Can I use this to exchange Ethereum against any other stable currency?

Now after creating an Ethereum wallet, we need to create a process to exchange Ethereum for tokens, according to the review, we found that the uniswap protocol must be dealt with. Is this repository to deal with the uniswap protocol!!
If it is possible to provide us with the necessary documentation for this process or any examples using Nethereum

Check the unit tests here https://github.com/Nethereum/Nethereum.Uniswap-V2-and-V3/blob/main/Nethereum.Uniswap.Testing/UniSwapV2PairTests.cs

Sorry for the inconvenience, the addresses of the contracts in the test layer are such as :
//Unswap smart contract Address !?
var routerV2Address = "0x7a250d5630B4cF539739dF2C5dAcb4c659F2488D";
//weth smart contract Address !?
var weth = "0xc02aaa39b223fe8d0a0e5c4f27ead9083c756cc2";
//Dai smart contract Address !?
var dai = "0x6b175474e89094c44da98b954eedeac495271d0f";

These addresses are smart contract addresses on the mainnet, right?
I think I need to find them On the test network Ropsten??
Is that correct ??

Yes, this is using mainnet testing as a fork. If you want to work in ropsten it will be different. Use this to get some test weth if needed https://faucet.paradigm.xyz/


Network Routes is not available

Exit out
Operating environment: Docker Desktop
Image: 0.3x.x
Upon testing, it was found that the Network Routes feature in version 0.29.4 is functioning properly, whereas in version 0.3x.x, there are issues and it cannot be accessed correctly.

@Cikaros does SSH still work for you on a route? (#2903)

@Cikaros can you confirm that you are using 0.33.0? Please run netbird debug for 5m -AS in those affected peers and share the output file with us please, it will help get some insight about your described issue.
Would you also be able to share screnshots of a route you defined and the associated Access Control Groups, if any?


Question: duration model vs acoustic model

When running the current run_full_voice demo script, when you create a duration model and an acoustic model, does it use label files generated by the duration model to generate the wave files with the acoustic model? If not, how can we make that happen?

Good question. The scripts for the same are under development and will be ready in a day or two. However, you could still do it with the current setup (but to be configured manually).

copy the generated ".lab" files from duration_model/gen// into acoustic_model/data/label_state_align/ (caution: this will replace original files)
run acoustic model setup again, with only NORMLAB, DNNGEN, GENWAV in the conf file set to True.

Optional: Additionally, you can avoid running on validation set, by using a variable GenTestList under the Main processes section set to True -- by setting this, Merlin reads files from data/test_id_list.scp only.

Great thanks!
I will test it with solution #1 for now and will be looking forward to seeing the implementation.

It's fixed now! Please check latest commit!

Thanks! Pulled latest code.


Application is crashing Fatal signal 11 when opening PDF on few tablets

Application is crashing Fatal signal 11 when opening PDF on few tablets. The PDF contain images and text and is of 11 pages. Please help as we cannot make the application live with this issue.
Attaching the PDF.
testingcrashpdf.pdf
Crash LOG -- : Fatal signal 11 (SIGSEGV), code 1, fault addr 0x0 in tid 5483 (PDF renderer)

Simply catch the error and it my still be ok..

Tested your pdf and no errors here..

Thanks for the reply, Yes in few devices its not crashing but on some it is Android version 5.1(its crashing).
Please load it from internal or external storage as loading a pdf from assets is working, means same pdf is not getting crashed.
Thanks
Sonia

I'm loading it from internal drive on latest 7.1 OS and working fine. Go back to basics and use the example code to check its not something in your code causing this.

I am checking in sample code only which i have downloaded from github. On same tablet the sample app is working  fine when loading pdf from assets and if loading from internal/external storage then its not working.
Also i have observed that its not working on Android 5.1
Thanks
Sonia

Sorry if I'm a little confused when you load from a file it fails on some tablets not others that would be down to the paths as different versions of Android use different names for internal external storage check your paths on each device then use file manager to check path is the same on device to .

PDF opened but when i scroll it closes the sample application.
Says this error- Crash LOG -- : Fatal signal 11 (SIGSEGV), code 1, fault addr 0x0 in tid 5483 (PDF renderer)

Test with the sample pdf and prove it works on all your devices could be issue with the of pdf format, pdfform etc.

same issue here pdfviewer crashes on android 5.0.1 and works fine on 4.4.4 i can send you all required data to fix it, attached is my test file
Ref1_ImpactOfiPads.pdf

Same issue still exist on few PDF on Android 5.0.1 +.

That pdf is a weird format as I don't render the text and I'm using a version of off code that doesnt  have issues with rendering, save the pdf as standard format and it will work.

Works fine on android 4.4.2 but on 6.0 the app crashes if a page contains a table.
Logs from emulator but the same problem on a phone.
A/libc: Fatal signal 11 (SIGSEGV), code 1, fault addr 0x0 in tid 5565 (PDF renderer)
A/DEBUG: *** *** *** *** *** *** *** *** *** *** *** *** *** *** *** ***
A/DEBUG: Build fingerprint: 'Android/sdk_google_phone_x86_64/generic_x86_64:6.0/MASTER/3512684:userdebug/test-keys'
A/DEBUG: Revision: '0'
ABI: 'x86_64'
A/DEBUG: pid: 5537, tid: 5565, name: PDF renderer  >>> com.serviceme <<<
A/DEBUG: signal 11 (SIGSEGV), code 1 (SEGV_MAPERR), fault addr 0x0
A/DEBUG:     rax<PHONE_NUMBER>001000  rbx<PHONE_NUMBER>001000  rcx<PHONE_NUMBER>000000  rdx<PHONE_NUMBER>001000
A/DEBUG:     rsi 00007f1f0c4fe000  rdi<PHONE_NUMBER>000000
A/DEBUG:     r8<PHONE_NUMBER>0015bd  r9  00007f1f093bf440  r10<PHONE_NUMBER>00b304  r11 00007f1f09cc1c90
A/DEBUG:     r12<PHONE_NUMBER>001000  r13 09cc163000000000  r14<PHONE_NUMBER>000001  r15 09cc163000000000
A/DEBUG:     cs<PHONE_NUMBER>000033  ss<PHONE_NUMBER>00002b
A/DEBUG:     rip 00007f1f22560fcf  rbp 00007f1f2264de80  rsp 00007f1f093be1e0  eflags<PHONE_NUMBER>010202
A/DEBUG: backtrace:
A/DEBUG:     #00 pc<PHONE_NUMBER>01cfcf  /system/lib64/libc.so (memcpy+47)
A/DEBUG:     #01 pc<PHONE_NUMBER>000fff
A/DEBUG: Tombstone written to: /data/tombstones/tombstone_08
E/DEBUG: AM write failed: Broken pipe


libgit: implement the delete repo RPC call

And vendor in the protocol changes for it.
Depends on keybase/client#8478, will revendor once that's merged.
Issue: KBFS-2435

@jzila: fixed the uniqueness issue in 6229826.  If you agree, then this can be merged once keybase/client#8478 is approved and merged.


Multi-Select Optionsets not available in Unified Interface Grid Filtering

You cannot correctly filter a grid using an Multi Select Option set in the Unified Interface. This should be added to the section 'Capabilities not yet on Unified Interface'

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 9ab324e0-f5c6-64cb-d93b-85d238bf25d3
Version Independent ID: 94fbb660-5300-51a1-9c98-4b6500800e29
Content: About Unified Interface Dynamics 365 Customer Engagement
Content Source: ce/admin/about-unified-interface.md
Service: crm-online
GitHub Login: @jimholtz
Microsoft Alias: jimholtz

Currently if you try and filter using a multi select option set it looks like:

Filtering on any option set does not seem to provide an acceptable user experience.  We have updated the status reason on lead, and see this in the UCI:  (legacy web view is fine).  Version 9.1
[Not able to paste my screen shot -- but  the filter on Status reason returns:
Search
Select all
"unhandled"
[we have over 50 status reasons (and yes, we are addressing that as a separate issue)]
Filtering on a simple option set with fewer options presents the list, but it provides the optionset value not text which is not useful to users.

Scott, I see your internal MVP thread. This is a bug and will be addressed by the product team.

This value display in view filter instead of text is still not fixed - any follow up bug opened?


Normalize encoding

file:///foo/node_modules/@angular/http and file:///foo/node_modules/%40angular/http are equivalent, but encodeURI or decodeURI will do nothing to @ or %40, while encodeURIComponent/decodeURIComponent will do. When for example saving URLs in a Map it is very important to always save and get a normalized form, it would be awesome if this module supported this.

Why is @ encoded in the first place? @ is allowed in URLs.

I didn't write encodeURIComponent ¯_(ツ)_/¯
But isn't it used for separating username@host? So if the username contained an @, it would need to be encoded.
But often applications receive URLs from outside, and in theory you can encode every character as a % sequence. That's why it's necessary to normalise the encoding to a canonical form.

No, I mean, why are you using encodeURIComponent on a full URL? It's for URL components.
Where do we stop though? An URL could potentially be even double-encoded:
"file%253A%252F%252F%252Ffoo%252Fnode_modules%252F%2540angular%252Fhttp"

I am not using it for that. I just potentially receive URLs as file:///foo/node_modules/%40angular/http, and that is a perfectly valid URL.
The normalisation that can be done here is decoding all characters that are not reserved.

Alright 👍

https://github.com/sindresorhus/normalize-url/pull/44#issuecomment-498140751


meta: rename project

What were you trying to do?
Customers (this repository/service) gets confused with Customer (model) and multiple Customer objects (Customers) a bit too much. We need a better way to refer to this service vs the Customer model.
What did you expect to see?
A clear name for this service.
Options

filecabinet: Storage and organization of PII - Customer, Account, legal entity, etc
rolodex: [rolling] device used to store business contact information

one of our app was called underwriting %-)

registry could work

For underwriting that seems a bit too specific. We're not just doing underwriting with this information, but validation and general storage. I'd think of a "underwriting" service as just computing on the data.
With registry that seems too vague - a registry for what?

@InfernoJJ came up with rolodex. I'm a fan of that name.

Going to keep it as Customers for now.


Log more information when deep-compare fails

We're trying to track down issues at Airbnb where deep comparisons
(where compareThreshold is set) fails with inactionable error messages:
Error: Unexpected end of input
This could either be a corrupt image file or some other network issue
along the way. In order to track this down further, I'm adding one last
fetch without piping the response to pngjs, just to be able to log
details about what that URL responds with. Thing like:

status code
headers
body

Hopefully this will help us track down loading issues further.

Ignoring build failures this time. Puppeteer seems to fail to download in some cases, but that's unrelated to the changes made here.


Question about 'Using a WLDF policy rule and script action to call the operator's REST scale API'

Hi,
I need to enable the auto scaling for a cluster, I have watched the video, now I am trying to scale up my cluster using scalingAction.sh.
I encountered some problems. I have these questions:

I deployed the operator into its own namespace, for example, weblogic-operator, and deployed domains into their own namespaces, for example, weblogic-domain1, as mentioned in Architectural overview. While I found that in this video, the instructor deployed them into one namespace - weblogic-operator, why is that?
Is the script $WEBLOGIC_KUBERNETES_OPERATOR_HOME/src/scripts/scaling/scalingAction.sh the same as the script used by the instructor? I had to provide many params to get it run.
I tried running this script in domain*-admin-server as the instructor did, why I encountered such error:

"status": "Failure",
  "message": "services \"internal-weblogic-operator-svc\" is forbidden: User \"system:serviceaccount:weblogic-domain2:default\" cannot get services/status in the namespace \"weblogic-operator\"",
  "reason": "Forbidden",
  "details": {
    "name": "internal-weblogic-operator-svc",
    "kind": "services"
  },
  "code": 403

So I switched to run this script in weblogic-operator-*, and modified some roles, then the script was able to query weblogic operator service port, etc. While it failed to test the existence of
${INTERNAL_OPERATOR_CERT}. Could you explain what this ENV var is?

Is there a detailed step by step tutorial about running scalingAction.sh and defining WLDF policy rule and script action?

Thanks.

Hi @alai8 ,
Thanks for the new link, I followed it to create the policy and action, but I still cannot make it work.
I was trying running scalingAction.sh on admin-server directly, while I got 403 with no response body.
Here is the request generated by the script:
curl -v -k --cacert weblogic_operator.pem -X POST -H 'Content-Type: application/json' -H 'X-Requested-By: WLDF' -H 'Authorization: Bearer eyJhbGciOiJSUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJrdWJlcm5ldGVzL3NlcnZpY2VhY2NvdW50Iiwia3ViZXJuZXRlcy5pby9zZXJ2aWNlYWNjb3VudC9uYW1lc3BhY2UiOiJ3ZWJsb2dpYy1kb21haW4yIiwia3ViZXJuZXRlcy5pby9zZXJ2aWNlYWNjb3VudC9zZWNyZXQubmFtZSI6ImRlZmF1bHQtdG9rZW4taDY3aGYiLCJrdWJlcm5ldGVzLmlvL3NlcnZpY2VhY2NvdW50L3NlcnZpY2UtYWNjb3VudC5uYW1lIjoiZGVmYXVsdCIsImt1YmVybmV0ZXMuaW8vc2VydmljZWFjY291bnQvc2VydmljZS1hY2NvdW50LnVpZCI6Ijk4ODhmZTlkLTVkOTItMTFlOC05ZWNhLTBjYzQ3YWIxZjgyNCIsInN1YiI6InN5c3RlbTpzZXJ2aWNlYWNjb3VudDp3ZWJsb2dpYy1kb21haW4yOmRlZmF1bHQifQ.he_4EaAZSSMIyDvXbUJ8jRPbeBBlzAkcXOTAgEyTulj6JEX4SxvrV7wUAKwfIp03AJsyHYn59de4OvkGtZ_jMoTWxz8oI7mhfq0GhyKVs2pGNrrOc9cBmGPb4zwoSxKHAFW3aWxBxtGAGixJCluMglhGYcI32h5PHTU1yevytZ_8epVIwkrPaMHXUnS0l66h8mz_obqbyLZ-myqKl4Luvm5B1Typ-y0eOZpYpwRvDJj8iRO-gsFsbvP6aalc09Ft_d1Vz3ZgRXRzObYsebWzK_ufOss2ZEsSKQPw026F5UiXmxymtLoOzYd-ooFwtKUtmFOezeDI5U5_MlyRGxLwRw' -d '{
    "managedServerCount": 4
}' https://<IP_ADDRESS>:8082/operator/v1/domains/domain2/clusters/cluster-1/scale

I cannot figure out what happened, the operator just printed out this line in log file:
{"timestamp":"05-23-2018T05:38:46.974+0000","thread":34,"level":"INFO","class":"oracle.kubernetes.operator.helpers.AuthenticationProxy","method":"check","timeInMillis":1527053926974,"message":"Returned TokenReview","exception":"","code":"","headers":{},"body":""}
Could you help check this problem?
Thanks.

Hi,
I figured out why I got a 403.
Since my admin-server is running in the namespace weblogic-domain2, and the operator is running in the namespace weblogic-operator. I should have generated the access_token using the service account weblogic-operator's secret, not the service account default in weblogic-domain2.
I have another question about the policy and script action. After we create and active it, the script will be called by WLDF on the admin server, right?
Thanks.
Jiahao

Could you verify that the diagnostic system module is targeted to the admin server?
Quote from Automatic Scaling of WebLogic Clusters on Kubernetes blog:
The diagnostic system module is targeted to the Administration Server, specified as as_name, which is passed in as a system argument.  This diagnostic system module was targeted to the Administration Server because its policy contains the ClusterGenericMetricRule smart rule, which must be executed from the Administration Server so that it can have visibility across the entire cluster. For more information about smart rules and their targets, see Smart Rule Reference.

@alai8 ,
Thanks for the help, I made it by deploying the policy only on admin server.
While I still cannot make the policy work.
I created the start rule policy thru admin console, filled in the required params the same as posted in that blog, then attached a script action to it. The admin-server log showed that the module was successfully deployed and activated.  Then I curl-ed several times to  /opensessionapp, the cluster was not scaled up.
Seems that the rules was not evaluated to true.
How can I debug this issue?
I also created a calender based  policy and attached the script action, it worked properly. So I think, basically, the script action is correct, the only problem is  my smart rule. Could you help check if it is right? Here it is:
wls:ClusterGenericMetricRule("cluster-1","com.bea:Type=WebAppComponentRuntime,  ApplicationRuntime=OpenSessionApp,*","OpenSessionsCurrentCount",">=",0.01,2,"2 seconds","10 seconds")

Really appreciate your help :)

The smart rule looks ok.
Can you check the target servers for the diagnostic module, as shown in the screen shot of admin console:

It should have checkbox for "admin-server" box checked, and leave the checkbox for "cluster-1" unchecked.
If this still does not work, could you please upload the config.xml and the diagnostic module xml file under config/diagnostics/ and we will help debug it further.

You can also add "-Dweblogic.debug.DebugDiagnosticWatch=true -Dweblogic.debug.DebugDiagnosticsExpressionPoller=true" to the value for the JAVA_OPTIONS env
in serverStartup section for the admin-server in domain-custom-resource.yaml.
serverStartup:
desiredState legal values are "RUNNING" or "ADMIN"
"RUNNING" means the listed server will be started up to "RUNNING" mode
"ADMIN" means the listed server will be start up to "ADMIN" mode

desiredState: "RUNNING"
the name of the server to apply these rules to
serverName: "admin-server"
The Admin Server's NodePort
nodePort: 30701
an (optional) list of environment variable to be set on the server
env:

name: JAVA_OPTIONS
value: "-Dweblogic.StdoutDebugEnabled=false -Dweblogic.debug.DebugDiagnosticWatch=true -Dweblogic.debug.DebugDiagnosticsExpressionPoller=true"

That would generate debug information related to the WLDF policy in the admin-server.log file which may help us find the cause of the issue. Thanks.

Hi @alai8 ，
For the targets, I only checked the admin-server.
Here is the config file:
Module-0-3905.tar.gz
I'll try adding these options.
Thanks!

Thanks for uploading the WLDF module config file. Could you try removing the spaces before "ApplicationRuntime=OpenSessionApp,*" in the rule-expression and see if that helps?

Hi @alai8 ,
I've added the JAVA options as you suggested, and removed the white spaces, from the log, I saw that this policy was successfully deployed. While I curled many times to the opensessionapp, the policy is always evaluated to false. Could you tell me how to trigger the policy?
Here is the admin-server log:
admin-server.log.tar.gz
Thanks

Hi @alai8 ,
I got the opensessionapp.war from this repo: https://github.com/oracle/docker-images/tree/master/OracleWebLogic/samples/wls-K8s/wls-12213-domain
I tried this morning, and I've reviewed my config.xml, it is same as yours except some params for scalingAction.sh. Here is all the data about the domain:
domain2.tar.gz
It contains copies of the original opensessionapp I got from that repo. Hope you can help find the route cause with them, thanks!

I noticed that the application name in your WLDF rule expression is different from the application name. The case should match too.
Your rule is
<rule-expression>wls:ClusterGenericMetricRule("cluster-1","com.bea:Type=WebAppComponentRuntime,ApplicationRuntime=OpenSessionApp,*","OpenSessionsCurrentCount",">=",0.01,5,"1 seconds","10 seconds")</rule-expression>
but your application is
<app-deployment>
<name>opensessionapp</name>
Could you try making them the same and see if it helps?

@alai8 ,
Thank you very much, it works :)
Really appreciate your help!
Jiahao


Add PROPERTY_USAGE_NONE and use it

This is just a semantic change, the behavior should be identical.

Thanks!


[Task] Rest of Bank functionality in account manager uses JS SDK

Task
Contributors are able to complete this task and earn thenewboston coins.  Check out the labels to learn how much you can earn for contributing by completing this task.  Please make sure to be honest if you wish to contribute by saying you can't finish this and we can just un-assign you with no harm done!  There is no point in delaying tasks from being completed for miscommunication!

Overview

fetchBankBankTransactions
src/renderer/dispatchers/banks.ts
Gets all the bank transactions for the specified bank

fetchBankBlocks
src/renderer/dispatchers/banks.ts
Gets all the blocks for the specified bank

fetchBankConfirmationBlocks
src/renderer/dispatchers/banks.ts
Gets all the banks confirmation blocks

fetchBankInvalidBlocks
src/renderer/dispatchers/banks.ts
Gets all the Invalid blocks for a specified bank

fetchBankValidatorConfirmationServices
src/renderer/dispatchers/banks.ts
Gets all the confirmations blocks for a specified banks blocks

Behavior
Account manager uses js sdk installed from NPM https://www.npmjs.com/package/thenewboston
Rest of Bank functionality in Account manager uses JS SDK
/* code examples are awesome */

Please ask for this task to be assigned to you and earn and its sweet reward 😉
Remember to include your account number in your PR description for us to pay you 💰
** Pull Requests **
All Pull Request should be made to development branch, read contributors guild for more information about contributing

@zinoadidi I've added all of these methods

@tomijaga for the sake of bureaucracy :)
Lets tag the respective PR so i can get Justin to review / close the tasks from this side

closed by https://github.com/thenewboston-developers/Account-Manager/pull/610


Use gRPC between collector and agent as default

We should decide when to use gRPC as default between agent and collector.
The first release with gRPC will be 1.9.0. If all goes well could we switch to the default in 1.10?

sgtm


scanner: add more logs

Problem:
We encounter some weird issue that the ID is changed after reboot.
Solution:
Add these logs would help us to verify easily.
Related Issue:
Test plan:
None

@mergifyio backport v0.5.x v0.6.x


--remote-debug leads to ERROR: connect_to_host: Remote Debugger: Unable to connect. Status: 3.

Godot version:
3.3
OS/device including version:
Ubuntu 18.04
Issue description:

When trying to connect to a remote debugger with --remote-debug, this error message appears:
ERROR: connect_to_host: Remote Debugger: Unable to connect. Status: 3.
   At: scene/debugger/script_debugger_remote.cpp:95.

Steps to reproduce:

start the Godot Editor with an project open
in the root folder of the project, start godot --remote-debug localhost:6007

EXPECTED: the second godot instance connects to the debugger in the first godot instance
OBSERVED: the game starts after step 2, but doesn't connect to the debugger. Instead the above error message appears
Minimal reproduction project:
An empty project with an empty main scene.
empty-godot-project.zip

@mrimvo Does it work if you use <IP_ADDRESS>:6007 instead?

<IP_ADDRESS>:6007 instead?
doesn't work, same error message

Also, are you on a dual-stack IPv4/IPv6 network?
Not sure about this - is there is linux command I can type to check for this? ifconfig shows me both an inet and inet6 address for the wifi-adapter. Is this the information you asked for?

Remember that the Godot editor does not listen for incoming debugger connections. Only the project running from the editor does. See godotengine/godot-proposals#2608.

This sounds like it is exactly the same issue. It looks like the Godot editor doesn't start the debugger to listen on localhost:6007, that's why it can't connect with --remote-debug.

This sounds like it is exactly the same issue. It looks like the Godot editor doesn't start the debugger to listen on localhost:6007, that's why it can't connect with --remote-debug.

In this case, I'll close this as a duplicate of https://github.com/godotengine/godot-proposals/issues/2608.


Many thanks 🙏

@inxilpro I would like to express my gratitude for this plugin. Kindly continue the outstanding work with it. 😃

Thanks @vadviktor 😍
I think I'll leave this issue open for a bit 😛

Funny enough I actually came here with the idea of adding a topic to your discussions tab. An issue works, too.
It doesn't go unnoticed that one single person is maintaining the only viable AlpineJS syntax plugin for us using PhpStorm. So thank you very much for keeping it up to date, and sharing your work with us all!


Upgrade envtest

controller-runtime introduced a new Envtest setup tool in v0.9.0 (see release note here), so Authorino's make test should stop downloading hack/setup-envtest.sh and switch to sigs.k8s.io/controller-runtime/tools/setup-envtest.
Docs: https://github.com/kubernetes-sigs/controller-runtime/tree/master/tools/setup-envtest

@guicassolato Do we want to use always the latest version of the setup-envtest or stick to an specific version?

@guicassolato Do we want to use always the latest version of the setup-envtest or stick to an specific version?

I think it's ok to install latest, and, in case we need a specific version, we can set it in setup-envtest use.


Update README with link to testthat adapter

Hi, thanks for this great plugin! I wrote an adapter for the testthat package for R.

Thanks for contributing! :smile:


[backport] Switch back to golangci

This switches rancher back to golangci and runs the same linters we were running before. It also adds a change to stop printing the rancher logs after the tests run if the tests do not fail. This saves ~6 min in build time.

LGTM. Merge after 2.3.1 ships


Question about types to use

Can this be used with complex objects? not just strings and numbers?
Arrays of objects?

Yes sure, you can try it here https://codesandbox.io/s/fragmented-store-example-4p5dv?file=/src/App.js
However,  at the moment, fragmentation is only done at the first level.


Inserting file path on the terminal, when dragging a file to it

I've tested the following, on a MacOS device:

Dragging a file from the OS filesystem to the terminal
Dragging a file from the tree explorer to the terminal
Dragging a tab from the tab panel to the terminal

Let me know if any change is needed

@jportela,
Thanks for your contribution.
To ensure that the project team has proper rights to use your work, please complete the Contribution License Agreement at https://cla.microsoft.com.
It will cover your contributions to all Microsoft-managed open source projects.
Thanks,
Microsoft Pull Request Bot

@jportela, thanks for signing the contribution license agreement. We will now validate the agreement and then the pull request.
Thanks, Microsoft Pull Request Bot

Thanks for this @jportela, just tested out the code and noticed the following (mac):

Dropping from Finder results in spaces being retains
Dropping from explorer or a VS Code tab results in spaces being encoded to %20
Unicode characters are also encoded incorrectly: 中文 -> %E4%B8%AD%E6%96%87

The main actions so far are:

Do not encode unicode characters and spaces
If the path has spaces it should be wrapped in quotes similar to gnome-terminal https://github.com/Microsoft/vscode/issues/11907#issuecomment-246757193
(Me) Still need to test on Windows

Windows seems to work fine, apart from the path needing the to be wrapped in "" when it contains spaces 👍

@Tyriar thanks for noticing those cases and showing me the URI utility. I think now they are OK:

@jportela sorry about the delay, bit busy with release stuff atm. I hope to get this in for May :smiley:

@jportela sorry about the delay. This is great, thanks a lot :smile: should be included 1.13 :fireworks:


feat: improve playground mobile view and widget variants

Summary
Changes listed below are made to playground.

[x] Fix widget boundary max width number
[x] Improve dark theme in mobile view
[x] Include links to Rango docs and website in mobile view
[x] Add widget variant select
[ ] Improve "liquidity source exclude" name

Fixes # RF-1330
How did you test this change?
Tested the changes listed above on playground.
Checklist:

[x] I have performed a self-review of my code
[x] I have commented my code, particularly in hard-to-understand areas
[x] Implemented a user interface (UI) change, referencing our Figma design to ensure pixel-perfect precision.

Please rename the enableNewLiquiditySources from the config and replace it with excludeLiquiditySources with correct value. (true, false)
Please also update the widget config related to this field.

I think we have an alignment issue here.

I think we have an alignment issue here.

Horizontal align problem fixed. Vertical align problem is due to setting the height of widget fixed to 700 after implementing widget expanded mode and I don't know the reason for that.

Please rename the enableNewLiquiditySources from the config and replace it with excludeLiquiditySources with correct value. (true, false) Please also update the widget config related to this field.

We already use excludeLiquiditySources in configSlice in the following form:
    excludeLiquiditySources: () => {
      const { config, campaignMode } = get();
      return campaignMode.liquiditySources?.length
        ? false
        : !!config.enableNewLiquiditySources;
    },

Please rename the enableNewLiquiditySources from the config and replace it with excludeLiquiditySources with correct value. (true, false) Please also update the widget config related to this field.

We already use excludeLiquiditySources in configSlice in the following form:
    excludeLiquiditySources: () => {
      const { config, campaignMode } = get();
      return campaignMode.liquiditySources?.length
        ? false
        : !!config.enableNewLiquiditySources;
    },

I didn't understand what you mean?
I mean use a better name for excludeLiquiditySources in widget config. (instead of enableNewLiquiditySources)

excludeLiquiditySources

please check this commit:
https://github.com/rango-exchange/rango-client/pull/622/commits/127e7a6f735b52b9714f8f536d81694e6d6c3026

Please rename the enableNewLiquiditySources from the config and replace it with excludeLiquiditySources with correct value. (true, false) Please also update the widget config related to this field.

We already use excludeLiquiditySources in configSlice in the following form:
    excludeLiquiditySources: () => {
      const { config, campaignMode } = get();
      return campaignMode.liquiditySources?.length
        ? false
        : !!config.enableNewLiquiditySources;
    },

I didn't understand what you mean? I mean use a better name for excludeLiquiditySources in widget config. (instead of enableNewLiquiditySources)

please check this commit:
https://github.com/rango-exchange/rango-client/commit/127e7a6f735b52b9714f8f536d81694e6d6c3026

It seems variant icon size looks smaller than other icons.

I updated all the icons to the latest designed files.

We still have issue in widget alignment when page is scrolled.

The renamed field (excludeLiquiditySources is reverse of enableNewLiquiditySources in terms of meaning. You should consider it when you are using it.

Can you remove disable logic in liquidity sources? It should be possible to confirm even if 0 item is selected. (specially if it's excluded)

When we have at least 1 swapper selected for the liquidity sources config, it's better to expose the excludeLiquiditySources field in exported config no matter it's true or false.

When we are in exclude mode in playground, Please change it to Excluded Bridges or Excluded DEXs.

When we have at least 1 item in liquidity sources, maybe it's better to expose exclude liquidity sources to exported code no matter it's true or false.

Im some cases, i'm in exclude mode. but exported config is wrong in playground.

We still have issue in widget alignment when widget parent container is scrolled.

I think I've resolved all the issues related to widget alignment in all variants in this commit. Check please.
https://github.com/rango-exchange/rango-client/pull/622/commits/67344f7c8e5fa394a1cdfee7da208c88eff95675

Can you remove disable logic in liquidity sources?

Done

When we have at least 1 item in liquidity sources, maybe it's better to expose exclude liquidity sources to exported code no matter it's true or false. (to improve clarity and avoid bugs)

Done as you explained.

Im some cases, i'm in exclude mode. but exported config is wrong in playground.

I think this problem is resolved due to the changes made to expose excludeLiquiditySources when we have at least 1 item in liquidity sources. Check please.


UPI on vsphere: Machine-Autoscaler does not work because of missing tag

OKD 4.5
vsphere 7.0
When scaling machines with the machineset, the machine gets created, but the  machine operator fails with the following error message:
„E1020 10:08:37.628961       1 actuator.go:50] chmuw-default-n9wrf error: failed to reconcile tags: GET https://vc4.domain.net/rest/com/vmware/cis/tagging/tag/id:c5: 404 Not Found
E1020 10:08:37.629002       1 controller.go:279] chmuw-default-n9wrf: error updating machine: failed to reconcile tags: GET https://vc4.domain.net/rest/com/vmware/cis/tagging/tag/id:c5: 404 Not Found”
The reason for this is, that the vsphere tag "c5 " (cluster_id), in the category "id", which is used by the operator, gets never created by the UPI installer.
We had to manually create the tag with terraform and then the machine-set is able to create nodes properly.
kind regards
Philipp

This seems to be a dupe of https://bugzilla.redhat.com/show_bug.cgi?id=1877281 in 4.6. Please clone it to 4.5 so that machine-api would be updated in 4.5 as well - and paste the bug number here.
Keeping it open to have a reference to bugzilla

I have this issue with IPI on vSphere. Should I open another issue?

Could you check if its resolved in OKD 4.6?

For me it's still logging Failed to get tag, but machines can be created again.


The "AAD Instance Discovery Endpoint" should be azureCloudInstance enum specific

Core Library
MSAL.js v2 (@azure/msal-browser)
Core Library Version
2.22.1
Wrapper Library
MSAL Angular (@azure/msal-angular)
Wrapper Library Version
2.1.2
Description
The "AAD Instance Discovery Endpoint" is hardcoded to use "https://login.microsoftonline.com/common/discovery/instance?api-version=1.1&authorization_endpoint=" in the file "msal-common\src\utils\Constants.ts". It should be based on the environment/AzureCloudInstance specified by the config enum "AzureCloudInstance" in at the time of instantiating the object PublicClientApplication.
For example, If I specify the environment as  AzureCloudInstance.AzureUsGovernment, then the endpoint should use "https://login.microsoftonline.us/common/discovery/instance?api-version=1.1&authorization_endpoint="  (.us instead of .com).
Or at least, there should be a way for client applications to override the  "Default AAD Instance Discovery Endpoint".
This is a critical requirement for us as we allow only "https://login.microsoftonline.us" in our network and .com version is blocked.
Need this to be fixed as soon as possible.
Error Message
No response
Msal Logs
No response
MSAL Configuration
{
        auth: {
          clientId: environment.azureConfig.clientId, // This is your client ID
          authority: environment.azureConfig.authority, // This is your tenant ID
          redirectUri: environment.azureConfig.redirectUrl, // This is your redirect URI
          azureCloudOptions: {
            azureCloudInstance: AzureCloudInstance.AzureUsGovernment
          }
        },
        cache: {
          cacheLocation: 'localStorage',
          storeAuthStateInCookie: isIE, // Set to true for Internet Explorer 11
        },
}

Relevant Code Snippets
None

Reproduction Steps
Using the above configuration, at runtime, once we try to login to the AD, it is making a call to the "AAD Instance Discovery Endpoint" i.e., "https://login.microsoftonline.com/common/discovery/instance?api-version=1.1&authorization_endpoint=".
The URL login.microsoftonline.com is blocked for us in our network level as we only allow login.microsoftonline.us.
As we use AzureUsGovernment environment, it should use `login.microsoftonline.us'  throughout the application.``
Expected Behavior
The library should use the AAD Instance Discovery Endpoint based on the AzureCloudInstance enum value  passed in the configuration. or it should let the consumers override the default endpoint.
Identity Provider
Azure AD / MSA
Browsers Affected (Select all that apply)
Chrome, Firefox, Edge, Safari, Internet Explorer
Regression
No response
Source
External (Customer)

Closing as we whitelisted the .com in our network.

This issue was not resolved.
I've also been trying to access https://login.microsoftonline.us/ and for me I must get tokens from this source as my tenant is not in the ...com system.
I used tcpdump -i any -c 10 (on wsl ubuntu 20.04) to prove that .us was not being hit...
13:56:17.558491 IP <IP_ADDRESS>.41652 > DESKTOP-XXXXXX: 48688+ A? login.microsoftonline.com. (43)
13:56:17.558518 IP <IP_ADDRESS>.41652 > DESKTOP-XXXXXX: 59454+ AAAA? login.microsoftonline.com. (43)

I read through the code of relevant repo https://github.com/AzureAD/microsoft-authentication-library-for-js
and found that if I turned on verbose logging I could see where the mixup was happening...
 const app = new ConfidentialClientApplication({

    system: {
      loggerOptions: {
        loggerCallback(loglevel, message, containsPii) {
          console.log(message);
        },
        piiLoggingEnabled: false,
        logLevel: LogLevel.Trace
      }
    },
    auth: {
... redacted ...

that allowed me to see that the metadata discovery for that URL was not being found until going down to the network (not sure what that means)
console.log
    [Tue, 06 Jun 2023 21:04:22 GMT] : [2f2dc1c7-320f-47c6-980b-9f2c7594aad4]<EMAIL_ADDRESS>: Verbose - buildOauthClientConfiguration called

      at Logger.log [as localCallback] (src/auth.ts:38:19)

  console.log
    [Tue, 06 Jun 2023 21:04:22 GMT] : [2f2dc1c7-320f-47c6-980b-9f2c7594aad4]<EMAIL_ADDRESS>: Verbose - building oauth client configuration w
ith the authority: https://login.microsoftonline.us/REDACTED

      at Logger.log [as localCallback] (src/auth.ts:38:19)

  console.log
    [Tue, 06 Jun 2023 21:04:22 GMT] : [2f2dc1c7-320f-47c6-980b-9f2c7594aad4]<EMAIL_ADDRESS>: Verbose - createAuthority called

      at Logger.log [as localCallback] (src/auth.ts:38:19)

  console.log
    [Tue, 06 Jun 2023 21:04:22 GMT]<EMAIL_ADDRESS>: Trace - Retrieving all cache keys

      at Logger.log [as localCallback] (src/auth.ts:38:19)

  console.log
    [Tue, 06 Jun 2023 21:04:22 GMT]<EMAIL_ADDRESS>: Trace - Getting cache key-value store

      at Logger.log [as localCallback] (src/auth.ts:38:19)

  console.log
    [Tue, 06 Jun 2023 21:04:22 GMT]<EMAIL_ADDRESS>: Verbose - Attempting to get cloud discovery metadata in the config

      at Logger.log [as localCallback] (src/auth.ts:38:19)

  console.log
    [Tue, 06 Jun 2023 21:04:22 GMT]<EMAIL_ADDRESS>: Verbose - Did not find cloud discovery metadata in the config... Attempting to get cloud
 discovery metadata from the cache.

      at Logger.log [as localCallback] (src/auth.ts:38:19)

  console.log
    [Tue, 06 Jun 2023 21:04:22 GMT]<EMAIL_ADDRESS>: Verbose - Did not find cloud discovery metadata in the cache... Attempting to get cloud
discovery metadata from the network.

      at Logger.log [as localCallback] (src/auth.ts:38:19)

  console.log
    [Tue, 06 Jun 2023 21:04:22 GMT]<EMAIL_ADDRESS>: Verbose - Attempting to find a match between the developer's authority and the CloudInstanceDiscoveryMetadata returned from the network request.

      at Logger.log [as localCallback] (src/auth.ts:38:19)

  console.log
    [Tue, 06 Jun 2023 21:04:22 GMT]<EMAIL_ADDRESS>: Verbose - cloud discovery metadata was successfully returned from getCloudDiscoveryMetadataFromNetwork()

but when I found this suggestion ( https://github.com/AzureAD/microsoft-authentication-library-for-js/issues/4879#issuecomment-1419115535 ) to set knownAuthorities to include the url I thought that might be a way to go...
and sure enough once I included it ...
auth: {
      knownAuthorities: [`https://login.microsoftonline.us/${options.tenantId}`],

I was able to confirm with that earlier tcpdump command that I was now in fact hitting .us
14:09:28.583715 IP <IP_ADDRESS>.59908 > DESKTOP-XXXXXXXX: 28868+ A? login.microsoftonline.us. (42)
14:09:28.583746 IP <IP_ADDRESS>.59908 > DESKTOP-XXXXXXXX: 45762+ AAAA? login.microsoftonline.us. (42)

Dependencies (msal-node was tried with both 1.17.2 and as shown 1.9.0, neither worked.)
and can confirm that http-proxy-agent and https-proxy-agent are both >= 5.0.0
"dependencies": {
    "@actions/core": "^1.7.0",
    "@azure/msal-node": "^1.9.0",
    "@microsoft/microsoft-graph-client": "^3.0.5",
    "@microsoft/microsoft-graph-types": "^2.19.0",
    "cross-fetch": "^3.1.5",
    "glob": "^8.0.1",
    "isomorphic-unfetch": "^4.0.2"
  },
  "devDependencies": {
    "@babel/preset-env": "^7.22.4",
    "@babel/preset-typescript": "^7.21.5",
    "@jest/globals": "^29.5.0",
    "@types/glob": "^7.2.0",
    "@types/mocha": "^10.0.1",
    "@typescript-eslint/eslint-plugin": "^5.21.0",
    "@typescript-eslint/parser": "^5.21.0",
    "@vercel/ncc": "^0.33.4",
    "eslint": "^8.14.0",
    "jest": "^29.5.0",
    "typescript": "^4.6.3"
  },


first version - missing concave hull defn

Hi @KellyVance. I've made this first version of the vocab with all the terms we discussed however I've put Concave & Convex Hull in as narrower terms of Boundary since they are! They are boundaries under certain restrictions: rectangular & circular respectively.
I've not provided a definition for Concave Hull, please could you?

I've skipped the dev- PR step, as per the updated workflow in README.md, and gone straight to review- since the vocab passes all SHACL validators in shapes/ therefore it's valid RDF and has the (very minimal) metadata and Concept properties we've listed as mandatory.

Changes made as per @KellyVance suggestions


Proposal: testing mkldnn with KLEE LLVM Execution Engine

Greetings,
what do you think about the idea of testing mkldnn using KLEE?
In theory, by compiling benchdnn as llvm bitcode with klee_make_symbolic() enabled on certain inputs and executing the bitcode file using KLEE, we can generate batch of test cases automatically. Optimistically, KLEE could analysis the reference implementation ref_conv.cpp / ref_rnn.cpp / etc and generate test cases covering lots of edge cases and code branches. We can collect the test cases and replay on different environment, verify the consistency between the reference implementation and the platform-dependent optimizated implementations.
We could push this even further, analysis different platform-dependent optimized implementations using KLEE by applying KLEE to the llvm bitcode of libmkldnn.
I was hoping KLEE could help us discover tricky bug like https://github.com/intel/mkl-dnn/issues/431, so I spent some time tweaking mkldnn Makefiles and generated a llvm bitcode file for benchdnn, scaned benchdnn.bc using KLEE, unfortunately it failed pretty early on ERROR: Code generator does not support intrinsic function 'llvm.fabs.f32'!". Apparently KLEE does not support fabs yet<EMAIL_ADDRESS>There might be a little bit hope that KLEE-float could bring us further, I haven't try yet, but I would guess there would be some other intrinsic not supported yet, which would take some effort to support but not impossible.
Has anyone tried or thought about KLEE? Any experience to share? Is it worth to push further?
Alternatively, QuickCheck-like method as rapidcheck might be interesting as well.

In theory there is no difference between theory and practice. But, in practice, there is.

:)

Hi @fracting. Sorry for a delay. This looks like an interesting idea, but no one on the MKL-DNN team has experience with KLEE. If there is a way to generate e.g. benchdnn cases for convolutions using it, it would be really helpful.

@rsdubtso @vpirogov Thanks for the feedback. I tried to build klee-float but failed as https://github.com/srg-imperial/klee-float/issues/2, I'll come back and update if there is any progress. In the meanwhile let's keep this issue closed.

Update: I successfully compiled klee-float and was able to test a simple floating number hello world program using klee-float.
However, klee-float depends on llvm-3.4.2, unfortunately such an old version of clang/llvm does not support openmp and wasn't able to compile mkl-dnn. I think the right direction is to port klee-float to recent llvm version, which no one is working on currently. I would revisit this issue in a few months and see if there's any update from klee-float side, if not I might try to port klee-float.


Reserved identifiers for rule names

Forbid rule names to start with parse_* or recognize_* to avoid any conflicts.

I think it is a bad issue. Rule names and generated names are independents in all cases. Two generated names can only conflict if the rule name is the same, which is already analyzed.


Sequence Lock Contention on Apache Derby: FHIR Persistence failed on the examples

Describe the bug
FHIR Persistence failed on the examples test with Derby.
May 06, 2020 6:50:04 PM com.ibm.fhir.persistence.jdbc.dao.impl.FHIRDbDAOImpl severe
SEVERE: SQLException encountered while inserting Resource.
java.sql.BatchUpdateException: A lock could not be obtained within the time requested
	at org.apache.derby.impl.jdbc.EmbedStatement.executeLargeBatch(Unknown Source)
	at org.apache.derby.impl.jdbc.EmbedStatement.executeBatch(Unknown Source)
	at com.ibm.fhir.persistence.jdbc.dao.impl.ParameterVisitorBatchDAO.close(ParameterVisitorBatchDAO.java:629)

Digging into the issue
java.sql.BatchUpdateException: A lock could not be obtained within the time requested
	at org.apache.derby.impl.jdbc.EmbedStatement.executeLargeBatch(Unknown Source)
	at org.apache.derby.impl.jdbc.EmbedStatement.executeBatch(Unknown Source)
	at com.ibm.fhir.persistence.jdbc.dao.impl.ParameterVisitorBatchDAO.close(ParameterVisitorBatchDAO.java:629)
	at com.ibm.fhir.persistence.jdbc.derby.DerbyResourceDAO.storeResource(DerbyResourceDAO.java:444)
	at com.ibm.fhir.persistence.jdbc.derby.DerbyResourceDAO.insert(DerbyResourceDAO.java:129)

 Caused by: ERROR 40XL1: A lock could not be obtained within the time requested
	at org.apache.derby.iapi.error.StandardException.newException(Unknown Source)
	at org.apache.derby.iapi.error.StandardException.newException(Unknown Source)
	at org.apache.derby.impl.sql.catalog.SequenceUpdater.tooMuchContentionException(Unknown Source)
	at org.apache.derby.impl.sql.catalog.SequenceUpdater.getCurrentValueAndAdvance(Unknown Source)

Caused by: java.sql.SQLTransactionRollbackException: A lock could not be obtained within the time requested

The sequence prefetches 1000 values in the sequence. Since it's using multiple threads, it's going go beyond that fetch size and drive contention in derby. that's where the contention comes from in certain circumstances exceed 1000.
CREATE TABLE FHIRAPP.APPOINTMENT_STR_VALUES(MT_ID INT NOT NULL, ROW_ID BIGINT GENERATED BY DEFAULT AS IDENTITY, PARAMETER_NAME_ID INT NOT NULL, STR_VALUE VARCHAR(1024 OCTETS), STR_VALUE_LCASE VARCHAR(1024 OCTETS), LOGICAL_RESOURCE_ID BIGINT NOT NULL, CONSTRAINT PK_APPOINTMENT_STR_VALUES PRIMARY KEY (MT_ID, ROW_ID)) IN FHIR_TS PARTITION BY RANGE (MT_ID) (STARTING 0 INCLUSIVE    ENDING 0 INCLUSIVE );

To Reproduce
Steps to reproduce the behavior:

Rebuild with multiple threads

This is rare and occurs due to lock contention on the sequence generator when there is a large set of inflight transactions - specifically - here ROW_ID BIGINT GENERATED BY DEFAULT AS IDENTITY
Expected behavior
Build should pass
Additional context

Build
#426

/DERBY-6975: ERROR 40XL1: A lock could not be obtained within the time requested
Preallocation - https://db.apache.org/derby/docs/10.9/ref/rrefproperpreallocator.html
I've updated the code to work with this.

PR https://github.com/IBM/FHIR/pull/1059


Not applying material theme on AutoCompleteTextView

Hi, I'm using this for dialog which contains AutoCompleteTextView.
Your libraries works with EditText but AutoComplete TextView(object extending EditText).
Is there any way to apply material theme into AutoCompleteTextView?
Thank you.

I would expect that to be an issue with AppCompat, not my library


Python 2 compatibility

I cannot get it to run in Python 2.
The first complaint is about line 458 in core.py (due to)
        def func_wrapper(
                *args,

I also notices some super() calls [1] [2], which are only supported in Python 3.

Hey man!
I'll take a look as soon as I can, and will make it Python 2 compatible if possible (which I think it should; probably only syntax).
I'll update when it's done.
Thanks for taking notice!

Hey @bjanssen !
I just committed a version working with Python 2.7+! It's even testes and everything!
Thank you for taking the time to open this issue. I hope you enjoy my package.
Cheers,
Shay

Thanks @shaypal5 !

Sure thing, @bjanssen .
Please feel free to keep opening issues if you end up using the package and finding bugs, problems or issues requiring improvements.


Autogenerate toc

Is there still a way to autogenerate the toc file, that now lives in data/toc.yml?
The old script to do this was quite useful, especially when deploying a site that updates periodically. Is there anything that prevents doing this with the new organization? Given a couple assumptions about what ends up in content/ is seems this should be automatable (with more complicated builds / organizations perhaps requiring manual editing).

Not currently but I'm all for it, it's just that the old one built a SUMMARY.md file instead of a toc.yml file...PRs are definitely welcome on that one, shouldn't be too hard

this now happens here:
https://github.com/jupyter/jupyter-book/blob/master/jupyter_book/toc.py
and is called in the build script!


redirect on jupyter rely on new authentication

the authentication is the same on dataPortal (user and pass), but the user is the username and not the  mail address, the password is the same.

Yes, this is an open issue, we are trying to implement a SSO.


Logging field specification and value extraction errors

Description

add exception when illegal args are included in the recipe
add exception when the field cannot be computed
change color of error log in the data export runner
renaming in percentile field
update tests

Fixes #269
Checklist

[ ] Created new test(s) (if applicable)
[x] Updated tests
[ ] Updated the README / documentation (if applicable)

@arya-hemanshu can you have another look?


[FEATURE] HtmlEditorOptions styling

Is your feature request related to a problem? Please describe.
I would like to be able to style the text area as I am currently able to style the toolbar : cursor color, area background color, area radius, etc.
Describe the solution you'd like
Same syling options as the toolbar with the possibility to edit the rendering of text (h1, h2, etc.)

To edit the rendering of text and such I recommend you create a CSS file that affects text rendering and inject it into the webview. There is no good way to allow styling options for the text within Dart since it is rendered in HTML, which is why CSS is the best way to go. This will ensure that your custom style affects all text for any font type, color, size, etc.

Ok thanks. Maybe I missed it but I didn't see any doc about the available classes to style. How would I go rounding the corners of the text field ? Classic text area css styling ? A short example in the doc would be awesome :)

So i got it to work but I still get the caret decoration in that color. Any idea of it's class to change the color ?

The selection handle is controlled by Android theming. You can check https://github.com/tneotia/html-editor-enhanced/issues/138 for how to change its color.

Hopefully these answers helped you, closing this issue for now. Let me know if you have other questions!


Tests should be improved

[ ] Make data file paths configurable
[x] Helper program(s) to interactively generate reference samples
[x] Helper program(s) to append descriptions to reference samples CSV
[x] (Optional) Generalize caching stuff. Options:

[ ] General cache for filtered JSON
[ ] Joblib-style disk-memoize cache
[x] Probably best: Zipped, indexed full JSON (e.g. split into files numbered by ID, then zipped) for caching instead of selective cache of only a few IDs

Closing in favor of #46


Autodestroy after X time

Describe the solution you'd like
HI.
I will like memos for taking little notes about things i have to do, or look, or take into account for short time. I mean, after some x time, lets say a week (at least for the use im thinking right now), those "memos" are useless for me.
So, it will be nice if there is an option to autodestroy after some time.
(i dont see that option)
Well, thanks, and thanks for the work. Memos look really amazing!
Type of feature
User Experience (UX)
Additional context
No response

hi.
I would prefer have the possibility to put that when i create the memo. But of course if that is too cumbersome, your option is useful to me.
Thank you so much!

Oh, i also though maybe a tag or hashtag i dont know how you call that.
I mean "#"
Then if #week all message with #week will autodestroy after a week and so on.
#24h
well, just things that maybe it is difficult to implement, i dont know.
But in that manner there is no need to change UI. (i think)

Oh, i also though maybe a tag or hashtag i dont know how you call that.
I mean "#"
Then if #week all message with #week will autodestroy after a week and so on.
#24h
well, just things that maybe it is difficult to implement, i dont know.
But in that manner there is no need to change UI. (i believe)
Just "an idea", but again, if it is complicated the all ok, with what you think about it.

Well those '#' things are mainly used for filtering memos, so maybe we have to reimplement some functionality so that it can work with auto delete

but it is not so bad idea, dont?
maybe somebody in the future think in another thing and those # could be very usefull for give different actions (maybe)

but it is not so bad idea, dont?
maybe somebody in the future think in another thing and those # could be very usefull for give different actions (maybe)

Yeah definitely not a bad idea. Just wanted to clarify by saying week do you mean like the date or the tags?
So another example when user clicks tomorrow does that system meant to auto delete memos by tomorrow or the system would auto delete memos containing the word or tag tomorrow?

mmmm
Maybe this:
if i wrote #week in a memo, then get time, caltulate when is a week for that memo, save and put  that info in some kind of "internal" task or to do. Then read those task and delete correspondingly.


(PUP-10363) Cache the server list url not the service

The server_list resolver cached the service whose host and port it first
connected to, such as Puppet::HTTP::Service::Compiler. However, the next
request for a different service, would return the cached service, which wasn't
what the caller expected.
Instead cache the URL that we successfully connected to, and use that to
create the service of the correct type.

CLA signed by all contributors.

jenkins please test this with servertests


PrepMod: Add line break in ", 123 somewhere rd"

This is a competing proposal with #987.
This fixes #929 by adding line breaks in situations like ", 123 Some Roadname Rd." and ", PO Box 123". It also removes the Sentry warning, since this covers all the cases we've seen over an entire month.
I'm a little on the fence about this, since it involves so much added code for what feels like little benefit. Another reasonable approach here might be to just drop all the stuff here that is re-breaking lines entirely (the core part of the original problem was just to the redundant city/state/zip in the address lines, and this may have gotten out of hand). For example: 856c57c27125f7b96b1db150cdc4654a44a2cbe2

is there a library that already does this sort of thing that we could pull in instead?

No, not that I was ever able to find and that quite fit our needs and/or data (witness also the absurdity of the matchableAddress() stuff in the utils module, which, in a happier and more organized world, would share some of its guts with this, e.g. the list of streetTypes — that's where I pulled them from, but making the two work together would involve more messy refactoring that I don't want to do right now). Anyway, I’m sure there there is plenty of similar-ish stuff in a variety of geocoding tools, but those are largely closed source and this slice of functionality isn't exposed.

This should probably get merged into utils, or all the address stuff from everywhere should go into one place, or something at some point, but I’m going ahead and merging this for now.


Failed running mksquashfs

Failed running mksquashfs:
C:\git\Observer\Node\ObsNode>C:\nodec\nodec-x64.exe --clean-tmpdir app.js
Node.js Compiler (nodec) v1.0.0 (runtime 8.0.0)

Entrance: C:/git/Observer/Node/ObsNode/app.js
Options: {:clean_tmpdir=>true, :npm=>"npm", :make_args=>"-j4", :vcbuild_args=>"x64", :output=>"C:/git/Observer/Node/ObsNode/a.exe", :tmpdir=>"C:/Users/gre63396/AppData/Local/Temp/nodec"}

-> rm -rf C:/Users/gre63396/AppData/Local/Temp/nodec
-> mkdir -p C:/Users/gre63396/AppData/Local/Temp/nodec
-> cp -r "C:/__enclose_io_memfs__/_local_/node" "C:/Users/gre63396/AppData/Local/Temp/nodec/node"
-> rm -rf C:/Users/gre63396/AppData/Local/Temp/nodec/__work_dir__
-> mkdir -p C:/Users/gre63396/AppData/Local/Temp/nodec/__work_dir__
-> cp -r "C:/git/Observer/Node/ObsNode" "C:/Users/gre63396/AppData/Local/Temp/nodec/__work_dir__/__enclose_io_memfs__"
-> cd C:/Users/gre63396/AppData/Local/Temp/nodec/__work_dir__/__enclose_io_memfs__
-> Running ["\"npm\" -v"]
4.6.1
-> Running ["\"npm\" install --production"]
-> cd C:/git/Observer/Node/ObsNode
-> cd C:/Users/gre63396/AppData/Local/Temp/nodec/__work_dir__/__enclose_io_memfs__
-> cd C:/git/Observer/Node/ObsNode
-> cd C:/Users/gre63396/AppData/Local/Temp/nodec/node
-> rm -f deps/libsquash/sample/enclose_io_memfs.squashfs
-> rm -f deps/libsquash/sample/enclose_io_memfs.c
-> Running ["mksquashfs -version"]
mksquashfs version 4.3 (2014/05/12)
copyright (C) 2014 Phillip Lougher<EMAIL_ADDRESS>
[----------------------------------------------------------]
Compiled by Sebastiaan Ebeltjes @ 2015-06-08 (Domoticx.nl)
Compiled with Cygwin on Windows 8.1, compiler: GCC v4.9.2

This version comes with added support for:
- LZMA v4.65
- LZMA2 (XZ) v5.5.0
- LZO v2.09
- LZ4 r130

Enjoy!

[----------------------------------------------------------]

This program is free software; you can redistribute it and/or
modify it under the terms of the GNU General Public License
as published by the Free Software Foundation; either version 2,
or (at your option) any later version.

This program is distributed in the hope that it will be useful,
but WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
GNU General Public License for more details.
-> Running ["mksquashfs \"C:/Users/gre63396/AppData/Local/Temp/nodec/__work_dir__\" deps/libsquash/sample/enclose_io_memfs.squashfs"]
Failed running ["mksquashfs \"C:/Users/gre63396/AppData/Local/Temp/nodec/__work_dir__\" deps/libsquash/sample/enclose_io_memfs.squashfs"]

FYI, adding the --debug flag didn't give any additional info other than some info on the Node modules installed.

Any ideas here, @pmq20 et al?

wow this is weird. And the log did not give enough information. Would you love to share uyour work dir with me so that I can inspect what inside caused the problem?

Getting the same error :/
Is there any special thing I could do wrong while installing mksquash?

@dunklesToast: I did the same.

@pmq20: Sorry to say but I will unfortunately not be able to share that given it's full of proprietary code. 😕

I solved it with changing the temp directory.
try the -d /tmp/ flag
On 28. Jun 2017, 16:40 +0200, James M. Greene<EMAIL_ADDRESS>wrote:

@pmq20: Sorry to say but I will unfortunately not be able to share that given it's full of proprietary code. 😕
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

Using the -d flag did NOT resolve this issue for me.

@JamesMGreene This seems to be a bug in mksquashfs. Could you just run mksquashfs on your work dir to confirm this? If it fails you could try deleting some content of your work dir to filter out the culprit.


What dose RF visual and RF total mean?

RF-Learning  has two training stages.
In the 1st stage, the model is only trained for the visual character counting task. We name it RF-visual.
In the 2nd stage, the model is trained with both of visual character counting and scene text recognition tasks to a achieve the recropocal fearture learning, which is named as RF-total.
More details can be found in the paper.

ned for the visual character counting task. We name it RF-visual.
In the 2nd stage, the m

Thanks for your reply! And in the counting branch, I note you first output the occurrence numbers at each possible character, then apply a mse loss to calculate the losses between the summary of the occurrence numbers and target length. I wonder have you tried to directly output the text length (0~max_seq_len) to calculate loss, what kind of effect does it bring?

ned for the visual character counting task. We name it RF-visual.
In the 2nd stage, the m

Thanks for your reply! And in the counting branch, I note you first output the occurrence numbers at each possible character, then apply a mse loss to calculate the losses between the summary of the occurrence numbers and target length. I wonder have you tried to directly output the text length (0~max_seq_len) to calculate loss, what kind of effect does it bring?

Yes, we have tried the implementation method as you mentioned. However, the performance is not satisfied. We think the reason is that our current implementation could excavate more detailed supervision.


fix: restore getRouteResponses method

The getRouteResponses method was removed (mistakenly?), but provides a nice utility function for the client to access response types. The method is still documented here https://ts-rest.com/docs/core/#response-types

Hey @DylanSimowitz thank you for your contribution! If I remember correctly, this function was used exclusively by the Nest library, hence why it was removed from the core client. In order to provide this functionality publicly we'll need to distinguish between inferring the Input schema and Output schema for Zod depending on whether the type will be used by the client or server; kind of similar to how trpc has inferRouterInputs and inferRouterOutputs.
For example for responses, we'd need to use the Zod Output on the client, and Zod Input on the server. For everything else (query, body, etc.) it's vice-versa.
Also I'd say using a TS Type (to be used like GetRouteResponses<typeof contract.endpoint>) rather than a function would be more appropriate for this functionality.

Hey @DylanSimowitz thank you for your contribution! If I remember correctly, this function was used exclusively by the Nest library, hence why it was removed from the core client. In order to provide this functionality publicly we'll need to distinguish between inferring the Input schema and Output schema for Zod depending on whether the type will be used by the client or server; kind of similar to how trpc has inferRouterInputs and inferRouterOutputs.
For example for responses, we'd need to use the Zod Output on the client, and Zod Input on the server. For everything else (query, body, etc.) it's vice-versa.
Also I'd say using a TS Type (to be used like GetRouteResponses<typeof contract>) rather than a function would be more appropriate for this functionality.

Hey @DylanSimowitz thank you for your contribution! If I remember correctly, this function was used exclusively by the Nest library, hence why it was removed from the core client. In order to provide this functionality publicly we'll need to distinguish between inferring the Input schema and Output schema for Zod depending on whether the type will be used by the client or server; kind of similar to how trpc has inferRouterInputs and inferRouterOutputs.
For example for responses, we'd need to use the Zod Output on the client, and Zod Input on the server. For everything else (query, body, etc.) it's vice-versa.
Also I'd say using a TS Type (to be used like GetRouteResponses<typeof contract>) rather than a function would be more appropriate for this functionality.

Although it was only used by the Nest library directly, it was actually made to be general so that any client can import and use it. It was added to the core so that developers have a utility function for getting types from their router.
I can work on adding this back, although as @Gabrola  said, this should be a type that the caller can import.

@DylanSimowitz I will take this and fix it for you!


Feature/statistics

Added tools for statistical analysis of seasonality.
Updated the Air Passenger example to show these functionalities.

It'd be nice before merging to add one or a couple of unit tests, for instance to make sure the new method picks up the right seasonality on a simple sine wave.


How to suppress body tremors?

Video

body.sleep
body.slop

body.sleep body.slop

I don’t use falling asleep because it causes bodies to freeze and become motionless.
I couldn’t solve this problem, so I stopped using sleep.


Username/Password doesn't work on docker image

A clear and concise description of what the bug is.
Expected results
Expected the username/password to be admin/admin according to the docker-init.sh file.
"Init Step 1/4 [Starting] -- Setting up admin user ( admin / admin )"
Actual results
Access Denied
How to reproduce the bug

Fresh install using the instructions here: https://superset.incubator.apache.org/installation.html
After the docker image builds, go to the UI to log in.
Denied

Environment
(please complete the following information):

superset version: superset version
python version: python --version
node.js version: node -v
npm version: npm -v

Checklist
Make sure these boxes are checked before submitting your issue - thank you!

[ X] I have checked the superset logs for python stacktraces and included it here as text if there are any.
[ ] I have reproduced the issue with at least the latest released version of superset.
[ ] I have checked the issue tracker for the same issue and I haven't found one similar.

Additional context
You can stop and do another doocker-compose up, the admin/admin will work then you have the issues: You don't have the necessary permissions to load dashboards. Please contact your administrator.

After restarting four times, it finally works. FYI, updating as I test it.
Add any other context about the problem here.

Hi @jbs123, thanks for submitting a bug report. Can you share the SHA or release you were working with when you experienced this issue? We know that the docker build is lengthy. It's likely that the system failed at one point or another along the way and that the restarts eventually caused the initialization steps to converge. Any specific error messages you encountered along the way would be very helpful in finding the source of the issues.

I experienced the same issue. I was running commit 4485800e2118f8bc1424bdf67d2200eb5f0056ac.

The same here，I was running commit 8a3c99b.


"Get all users" is not producing all results

Some people that I can find through "Get a single user"  are not returned through "Get all users."
Thanks

I don't know if this is related. But we're currently trying to get 8000 users across in a get all users, and are experiencing some limitations.
Trying to use this tool to change limits:
https://support.microsoft.com/en-ca/help/315071/how-to-view-and-set-ldap-policy-in-active-directory-by-using-ntdsutil
Maybe you're being impacted by paging?


Custom Passport configuration

This PR provides the ability to override the default Linz passport configuration with your own. It allows you to customise the way in which Linz finds a user in the database, serialisers and deserialises a user.

@sandytrinh, use this branch to test a custom Passport configuration.


Update to Grafana 11.1

Resolve errors for : PR Form 11.1

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Please upload report for BASE (main@0e2eeaa). Learn more about missing BASE report.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #48   +/-   ##
=======================================
  Coverage        ?   75.58%
=======================================
  Files           ?       58
  Lines           ?     1896
  Branches        ?      494
=======================================
  Hits            ?     1433
  Misses          ?      404
  Partials        ?       59

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Bug in /team force [name] [team]

Well, today testing the command /team force found a bug, If I force a player who is playing to obs team, so I can see pushing TAB (as shown in the picture) http://gyazo.com/ca5fb09847b41c192253548e6c19d578

What is the actual issue here?

Nevermim, got it.

When did you last compile the plugin? This should have been fixed along with #82.

I compile the plugin yesterday about #83.

Can you recompile and test again please?

Sure, I'll tell happens after this compilation.

This still happens

I'll look into it when I get home, thanks for reporting. So it happens when someone that is playing is forced to observers?

If this happens when a player is forced to observers, they also once again joineen can see others obs

Closed in b76f5bf.


Time and space complexity of all algorithms

cheat sheet of time and space complexity of searching, sorting ,linkedlist ,arrays operations

can i work on this @Abhijit2505

@nitya123-github as I said previously too, please go through the source code and the documentation site.


Add low complexity region flag to gnomad annotations

gnomad tables have a field lcr somewhere, which is a boolean
output if true (not false/null):
{
  "ancillaryResults": {
    "low_complexity_region": true
  }
}

This flag is under .region_flag.lcr
There is another flag there .region_flag.segdup. Maybe this should be included too.
segdup: Variant falls within a segmental duplication region.
(source: https://gnomad.broadinstitute.org/help/hgdp-1kg-annotations)

Changing to lowComplexityRegion to match camelcasing


Upgrade wasmer version to v5.0.1

Depends on https://github.com/wasmerio/wasmer/pull/5245

Now that your wasmer PR gor merged, we should try with a git dependency.
Following what we did for wamr, using a git dependency for the shim binaries should be fine, as we don't publish those crates

Yay, upgrading wasmer fixes the issue with bumping the rust version! @Mossaka

I would be happy to use the git dependency as the actual dependency (instead of being a patch), and have it merged.
That would unblock bumping rust, and the crate is not published to a registry anyway.
We can always move back to published wasmer versions when they release a new one with the fix.


DEBUG is already defined elsewhere which clashes with G3Log's log level DEBUG

Hi,
When I try to build my project with gcc compiler, using the -DDEBUG flag, g3logger gives me error saying:
"DEBUG is already defined elsewhere which clashes with G3Log's log level DEBUG"
In my project, I use, g3logger with version 1.3.2-20190205, gcc 5.4.0 on an amd64 cpu, include the g3log directory to compilation search with -I$(g3log_folder_location) and link with -lg3logger. Am I misusing the flag or is "-g" flag sufficient?
Thank you,

Glad you managed to resolve it


Enzyme should not ignore transform css property

Running this spec:
it('should not ignore transform', function() {
  class Bug extends React.Component {
    render() {
      const style = { position: 'absolute', transform: 'translate(50px, 100px)' }
      return
;
    }
  }

  const mounted = mount(<Bug/>);
  expect(mounted.html()).to.contain('transform');
});

Results this error:
AssertionError: expected '

' to include 'transform'

What happens if you do mounted.html() ?

class Bug extends React.Component {
  render() {
    const style = { position: 'absolute', transform: 'translate(50px, 100px)' }
    return
;
  }
}

const mounted = mount(<Bug/>);
console.log(mounted.html())

logs:

What version of react/enzyme are you using?
Confirmed it's not a bug with React itself: http://jsbin.com/covusibevi/edit?js,console,output

From my package.json:
    "enzyme": "^2.5.1"
    "react": "15.3.2"

This is quite strange. I can't tell if this is a React issue. I can't see how it would relate specifically to Enzyme. This is what some quick debugging yields.
class Bug extends React.Component {
  render() {
    const style = { position: 'absolute', transform: 'translate(50px, 100px)' }
    return
;
  }
}

const wrapper = mount(<Bug />);
console.log(ReactDOM.findDOMNode(wrapper.node).outerHTML);
//

console.log(ReactDOM.renderToString(wrapper.node));
//

I am noticing, we are using the findDOMNode approach internally. So we could change approaches, though I don't understand why there is the difference.
cc @aweary, any idea why this is happening?

Any news on this? I have the same issue

Would love some feedback from members of the React team. Enzyme doesn't do anything in this situation besides defer to the nodes provided from ReactDOM.
cc @gaearon @spicyj @aweary

Seeing this issue as well for columnCount style property.

I ran into this today. It's a bug with shallow vs full renders.
Repro:
const style = {
  width: '1rem',
  height: '1rem',
  opacity: 0,
  transitionProperty: 'opacity',
  transitionTimingFunction: 'ease-in-out',
  transitionDuration: '400ms'
};

function Bug() {
  return
;
}

console.log('style', style);

const fullRender = mount(<Bug />);

console.log('fullRender', fullRender.html());

const shallowRender = shallow(<Bug />);

console.log('shallowRender', shallowRender.html());

Output:
style { width: '1rem',
        height: '1rem',
        opacity: 0,
        transitionProperty: 'opacity',
        transitionTimingFunction: 'ease-in-out',
        transitionDuration: '400ms' }
fullRender

shallowRender

"enzyme": "2.9.1",
"react": "15.4.2",
"react-dom": "15.4.2",

In that case, please file a bug on cheerio (which is what render uses), and link it here. Thanks!

Have the same problem, ignoring transform: translateX(100%);
But using render is fine.
@ljharb

@chenshuai2144 please file a new issue with the component code and the test code.


Local IP sent in text: cant Teach Oscar

Can we reopen the issue related to this subject ?>> Local IP sent in text: cant Teach Oscar
I have done all the suggested items still , I cannot get to the IP address to teach Oscar

I have tried these things below, but it did not work
=====
navigate to where your node modules folder is:
cd /var/oscar/web/node_modules
(this might be different depending on where you install it to)
then install js-yaml
sudo npm install js-yaml
you will probably also need to install express-dot
sudo npm install express-dot
if you have apache2 running you will need to stop that service or remove it.
should be good to go now, reboot for good measure and check your error log:
tail -f /var/log/supervisor/oscar_web.log


template feature types

Added survey folder containing template feature types for field campaigner.

@pierrealixt I have corrected the issue mentioned in GIF and have rebased the PR.

Nice!
It might not be related but I got an error from osmcha_errors.
"GET /campaign/osmcha_errors_data/81510b0f20d5415abf593975a1ae5466?page_size=100 HTTP/1.1" 500
File "/Users/pea/Documents/CODE/KARTOZA/HOTOSM/field-campaigner/flask_project/campaign_manager/views.py", line 269, in get_osmcha_errors_data
    except Campaign.DoesNotExist:
AttributeError: type object 'Campaign' has no attribute 'DoesNotExist'

Is it related?

It is not related to this PR. The functions still uses the previous version and doesnot calls campaign from DB. It is minor fix.

ok, can you please open an issue on this and fix it asap.
Thank you

otherwise, this PR LGTM.


Migrate ToolchainRegistry to be an actor

While doing this, remove the static shared toolchain registry. Global state is never a good thing and we needed to modify it in tests. The design becomes a lot cleaner if we explicitly pass the toolchain registry.

@swift-ci Please test

@swift-ci Please test

@swift-ci Please test Windows


New rule: avoid-non-ascii-symbols

The rule or changes you're looking for might have already been suggested!
Please search in the issues before creating a new one.
Expected Behavior of the rule

Hi thanks for the wonderful package! I am proposing a new rule that enforces i18n/l10n. The basic idea is, search non-ascii characters ([^\x00-\x7F] in regex) that appears in string literals, and forbid that. This is because, for non-English apps, the text that needs l10n is usually non-ascii, so this rule efficiently finds out such text which need l10n. As for why only searching non-ascii characters, it is because there do exist many string literals which are quite reasonable and is not meant to be read by a user and should not do l10n.
Example:
someFunction("some_ascii_string"); // ok
someFunction("non_ascii_such_as_你好"); // LINT

Context

Is there any documentation out there telling that something like this is a good practice? I don't see why English keys are better than any other language keys.
I undestand that you can have that agreement as a team. But I don't see the value to add it to detekt. In your case I would crate a custom rule to enforce that team agreement.

The idea is to never directly hardcode strings that are to be seen by the end users in code. They should be put separately in a i18n file.
p.s. related: https://github.com/dart-code-checker/dart-code-metrics/issues/819

A comment is not a literal string :)
// ¯\(ツ)/¯

is ok

A comment is not a literal string :)

Yup I see. Well you could still want to put anything inside a custom exception message.
Anyway the point of this rule should be around using String literal, and not the non-ascii chars. I understand the point behind localization, Android has a similar rule for Lint. However, I don't get why non-ascii-symbols should make the difference here.

However, I don't get why non-ascii-symbols should make the difference here.

Sorry I do not get the point. Since android has such a rule (and Flutter also has), it is already proven that this rule is useful.

Since android has such a rule (and Flutter also has), it is already proven that this rule is useful.

Android has a rule for checking any string literal which is not exported to a resource. What you're requesting is a rule to check only string litererals that contains non-ascii symbols

And what android does is that it lints things like this: TextView.setText("Hello world!") but it's ok when doing something like this: val hi = "Hello world!".
I don't see how to generalice a rule for any framework without having lots and lots of false positives. I insist that a detekt rule to enforce l10n is great, but I think that it can't be inside the default rule set.

Closing due to lack of interaction and the sentiment was that this rule was platform specific (Android). Happy to re-open and re-discuss further if there are new discussion points.


Yu7yjyuyh

Acknowledgement of preliminary instructions

[X] I have read and acknowledged the preliminary instructions.

What idea do you have?
Yfxfsf

Fgyzu6se
Iss

Adam

Adam

Max

Matt

Naomi

Ming

Solarite

Krampus


[meshery-server] supporting auth protocols not supported by k8s.io/client-go natively

Description
k8s.io/client-go and other tools (kubectl) need to be authenticated first using the cloud provider's auth methods before they can interact with the cluster.
For doing this, they generally depend on external CLIs given by the providers. For more information on this, lookup this.
When the application using the k8s client library is installed in the cluster, it doesn't need this authentication. However, out-of-cluster applications need to authenticate first.
Thus, to work with an environment in which Meshery is deployed out of cluster and connected to a managed cluster like EKS, Meshery needs to support this authentication.
For EKS, this is handled by the aws cli. Particularly the aws get-token command.
a Kubeconfig for EKS looks like the one below implying every time any kubectl command is executed, the aws get-token command is run for generating a token. The token also has an expiration time after which no further requests can be made using it.  :
kind: Config
preferences: {}
users:
- name: <context>
  user:
    exec:
      apiVersion: client.authentication.k8s.io/v1alpha1
      args:
      - --region
      - <region>
      - eks
      - get-token
      - --cluster-name
      - <cluster-name>
      command: aws

When the client libraries can't find the aws CLI in PATH, the requests fail and Meshery is unable to connect with the cluster. The error below is actually from Meshery server:
time="2021-09-14T10:42:58Z" level=error msg="failed to get K8s Config: Get \"https://<cluster-url>.eks.amazonaws.com/version?timeout=32s\": getting credentials: exec: exec: \"aws\": executable file not found in $PATH"

Implementation

Immediate solution: Ship aws cli in Meshery's docker image so that the client libraries can handle authentication.
Possibly better solution: Use aws-iam-authenticator internally. (I'm not entirely sure about this yet)

Note that this is different from https://github.com/meshery/meshery/issues/3995.
Contrary to earlier assumption, the scripts in mesheryctl, though hacky, work fine. However that issue would now be more targeted towards porting this to a Go native aws sdk which might not be an immediate requirement but is sure nice to have.


proto update

Seems like they had a blast switching around stuff again in the last update

Added a hotfix for requestPlayerinfo as well

So many changes


The price is set to '0' for all flights.

Code built based on the Readme example:
import json
from dataclasses import asdict
from fast_flights import FlightData, Passengers, create_filter, get_flights, Cookies

# Create a new filter
filter = create_filter(
    flight_data=[
        FlightData(
            date="2024-12-30",
            from_airport="MAO",
            to_airport="SDU"
        ),
    ],
    trip="one-way",
    seat="economy",
    passengers=Passengers(
        adults=1,
        children=0,
        infants_in_seat=0,
        infants_on_lap=0
    )
)

# Get flights with a filter
result = get_flights(filter)
print(result)
with open('result.json', 'w') as f:
    json.dump(asdict(result), f, indent=4)

The result price for all flights is '0':

I'm having the same issue - let me know if you find a solution!

I had the same issue
When I pulled the library this bug was still in place:
https://github.com/AWeirdDev/flights/pull/7/files
I applied the change locally and the issue was fixed

Yeah, the price thingy just doesn't work even with the pull somehow, I'm looking for ways to fix it (if I have time).
Does anyone here know how to deal with Google's internal APIs? That'd be cool.

Pulling the repository works for me as well while it looks like the pip version is still behind with the bug fix mentioned by jack-ireland. It would be great if the pip version were updated as well.


Angular component version ?

Hi,
I'm trying to use TUI editor in Angular.
And I was wondering if there is a version of TUI Editor as component.
Is there an official angular component version or a more recent and mantained version than this one ?

Unfortunately, there is no official support for Angular. Please wait for the future plans to support Angular.


order: clarify ordering of ties

Process ID: order
Describe the issue:
The simplest implementation to support the asc parameter is to simply flip the input array before running argsort if descending order is desired. However, the order process currently requires that Ties will be left in their original ordering, regardless of whether asc=True or asc=False. This means that we cannot simply flip the ~input array~ array with the ordered indices, because ties would be flipped too. This makes the implementation more unwieldy than it has to be.
Proposed solution:
Change this requirement such that ties will be in the original ordering if asc=True and flipped otherwise.
Additional context:
See here for initial discussion

@soxofaan @dthiex  Do you know how your implementations handle this?

we currently use this implementation from the legacy openeo-processes-python repo: https://github.com/Open-EO/openeo-processes-python/blob/f57c663e8708061a8222851a8aec2762ac46b0bb/src/openeo_processes/arrays.py#L745-L817
which behaves like the current spec if I understand correctly:
import numpy as np

data = np.array([1, 2, 2, 3])
print(data)
# [1 2 2 3]

print(numpy.argsort(data, kind="mergesort"))
# [0 1 2 3]
print(numpy.argsort(-data, kind="mergesort"))
# [3 1 2 0]

The simplest implementation to support the asc parameter is to simply flip the input array before running argsort if descending order is desired. However, the order process currently requires that Ties will be left in their original ordering, regardless of whether asc=True or asc=False. This means that we cannot simply flip the input array, because ties would be flipped too.

maybe I'm misunderstanding, but if you mean flipping the sign of the input data with "flipping the array", I think the descending mode works just fine with numpy.argsort as illustrated above

Apologies, typo in my description:
I mean after applying argsort, flipping (aka reversing) the array with the ordered indices with np.flip to get the opposite ordering.

If it works with argsort in the old implementation, why do we need a change here? Can you give some examples, @LukeWeidenwalker?

Adding the minus-sign like in the old implementation only works on numerical arrays:
-data
You cannot do this on e.g. string arrays, it will error out. You can however get the sorting indices with argsort and flip that array. However, then the order of ties is flipped too.
Depending on your answer to this comment: Other than changing this in the spec, we can of course just not support anything other than numerical arrays in our order process and throw descriptive errors on why this isn't possible. Don't think that's the best option for users though, because that will only be reportable at runtime.

Order allows number|null|date-time:string|date:string|time:string - All the strings are temporal, so I'd assume internally they could be timestamps (i.e. numerical)? Can you use the - thing on some kind of date/time objects in Python?

No, just tried again, this doesn't work!

we currently use this implementation from the legacy openeo-processes-python repo

@soxofaan so how does your process handle datetime strings then?

with strings we don't do date interpretation, but that's usually not a problem with ISO8601
A string array is eventually passed to np.argsort and:

asc=True (default) mode works
but asc=False currently fails:

[500] Internal: Server error: TypeError("bad operand type for unary -: 'str'")

A mixed arrays with strings and numbers alos fails with:
[500] Internal: Server error: TypeError("'<' not supported between instances of 'str' and 'int'")

It seems it's hard to really come to a conclusion here with the variability of implementations.
There are a couple of options:

Implementation: Throw an error if not supported
Implementation: Remove string-types from the JSON Schema
Implementation: Remove the ask parameter from the JSON Schema
Specification: Drop the "asc" parameter in "order" and add a "array_reverse" process in 2.0. I assume the ties issue is not really a thing in "sort"?
Specification: Clarify that "order" always sorts in ascending order and the reverse is only applied afterwards if the "asc" parameter is set to false. This is likely the most interoperable solution as it's a two-step approach that I assume everyone could follow.

The simpliest part would probably be 5, but this would probably lead to a change in SH, right?

with strings we don't do date interpretation, but that's usually not a problem with ISO8601

@soxofaan fyi: The spec says: "Temporal strings can not be compared based on their string representation due to the time zone/time-offset representations."

with strings we don't do date interpretation, but that's usually not a problem with ISO8601
@soxofaan fyi: The spec says: "Temporal strings can not be compared based on their string representation due to the time zone/time-offset representations."

yes I know, I just mean that is practically not a problem in VITO backend because we usually only work at date resolution (and if there is a time component we'd always use UTC)

Proposal:
Replace "Ties will be left in their original ordering." with "The ordering of ties is implementation-dependant."


Add node 6.9.1 + builder

Context
Needed for building the tup-ops assets in Docker.
Reviewers
@brandondoran can you 👍 ? I believe the new folder needs to be setup in Docker Hub, can you assist with this too please?

Thanks a lot! Merging this now. 🔒

@brandondoran The 6.9.1-builder image does not seem to be available
> $ docker pull thredup/node:6.9.1
6.9.1: Pulling from thredup/node
3690ec4760f9: Pull complete
419f814deb4f: Pull complete
6119257d9cb3: Pull complete
6bce981224e2: Pull complete
Digest: sha256:e68ad0d78ea9676732f542b74793a7a65e338117f8c06a86620354d0e520a8d2
Status: Downloaded newer image for thredup/node:6.9.1

> $ docker pull thredup/node:6.9.1-builder                                                                                [±k8s ●]
Error response from daemon: manifest for thredup/node:6.9.1-builder not found


Multiple windows support?

We currently just zoom and pan using the primary window. Perhaps we should try to figure out which window received input events and somehow map input to the right camera?

see https://github.com/jakobhellermann/bevy_editor_pls/pull/71#pullrequestreview-1367861582