Directory with braces does not show contents when expanded

Self-Diagnosis

[x] I have searched the issues for an answer to my question.
[x] I have reviewed the NERDTree documentation. :h NERDTree
[x] I have reviewed the Wiki.
[x] I have searched the web for an answer to my question.

Environment (for bug reports)

[x] Operating System: Mac OS 10.15.3
[x] Vim/Neovim version :echo v:version: vim 801
[x] NERDTree version, found on 1st line in NERDTree quickhelp ?: 6.7.0
[x] vimrc settings

[x] NERDTree variables

let NERDTreeIgnore=['doc$', '\.pyc', '\.rbc$', '\~$', '\.DS_Store$', 'tmp', '__pycache__']
let NERDTreeChDirMode=2
let NERDTreeMouseMode=3
let NERDTreeQuitOnOpen=0
let NERDTreeMinimalUI=1
let NERDTreeDirArrows=1
let NERDTreeShowHidden=1
let NERDTreeShowBookmarks=1

- Other NERDTree-dependent Plugins: None

Steps to Reproduce the Issue

Create a directory called {foo} and put a file bar.txt inside of it.
Open vim (vim)
In the nerdtree split you'll see {foo} folder, if you change focus to that split and put cursor on that, pressing enter to the open the directory will change the arrow to show the directory is open, but not list the bar.txt file inside (and will therefore display an apparently empty directory).

Current Result (Include screenshots where appropriate.)

Expected Result
Show contents of directory (i.e. be able to see and select foo.txt).

Not sure if this is a regression that took place after #868 - it seems like that PR was meant to solve this issue.

@mcabrams, I'm not seeing this behavior. It's possible there's another part of your .vimrc file that's responsible. What is causing the L-shaped lines in your first screenshot?

@PhilRunninger That's just the output of the tree command in command line to illustrate actual file structure, sorry, should have clarified.
I'll take a look at my .vimrc!

@PhilRunninger FWIW, I just started vim with vim -u .vimrc where vimrc looked like the following:
call plug#begin('~/.vim/plugged')
Plug 'scrooloose/nerdtree'
call plug#end()

and I had the same issue.

An additional note, if instead of pressing o I press t to open in a new tab, the contents show appropriately in the new tab (this is regardless of whether I'm using current vimrc or minimal vimrc).

I made a similar minimalist setup. I have a ~/.vim/vimrc with only
packadd nerdtree

in it, and nerdtree is located in ~/.vim/pack/bundle/opt/nerdtree. There is nothing else in my ~/.vim folder. Even when using the vim -u broken_vimrc command, vim will still read your ~/.vim folder. If there are other vim scripts in the tree (such as in the ~/.vim/ftplugin, ~/.vim/after, ~/.vim/plugin, or ~/.vim/syntax folders), they will be sourced and may affect what's happening.
With my minimalist setup, I still cannot reproduce the error, and t works properly as you describe.

@PhilRunninger So odd, I have the exact same setup, yet I still have the same issue:

I'm assuming this must have something to do with vim version or something else?

FWIW:
➤ vim --version                                                                                11:35:08
VIM - Vi IMproved 8.2 (2019 Dec 12, compiled Mar  3 2020 12:05:00)
macOS version
Included patches: 1-319
Compiled by<EMAIL_ADDRESS>Huge version with MacVim GUI.  Features included (+) or not (-):
+acl               +file_in_path      +mouse_urxvt       -tag_any_white
+arabic            +find_in_path      +mouse_xterm       -tcl
+autocmd           +float             +multi_byte        +termguicolors
+autochdir         +folding           +multi_lang        +terminal
-autoservername    -footer            -mzscheme          +terminfo
+balloon_eval      +fork()            +netbeans_intg     +termresponse
+balloon_eval_term +fullscreen        +num64             +textobjects
+browse            -gettext           +odbeditor         +textprop
++builtin_terms    -hangul_input      +packages          +timers
+byte_offset       +iconv             +path_extra        +title
+channel           +insert_expand     +perl/dyn          +toolbar
+cindent           +job               +persistent_undo   +transparency
+clientserver      +jumplist          +popupwin          +user_commands
+clipboard         +keymap            +postscript        +vartabs
+cmdline_compl     +lambda            +printer           +vertsplit
+cmdline_hist      +langmap           +profile           +virtualedit
+cmdline_info      +libcall           +python/dyn        +visual
+comments          +linebreak         +python3/dyn       +visualextra
+conceal           +lispindent        +quickfix          +viminfo
+cryptv            +listcmds          +reltime           +vreplace
+cscope            +localmap          +rightleft         +wildignore
+cursorbind        +lua/dyn           +ruby/dyn          +wildmenu
+cursorshape       +menu              +scrollbind        +windows
+dialog_con_gui    +mksession         +signs             +writebackup
+diff              +modify_fname      +smartindent       -X11
+digraphs          +mouse             -sound             -xfontset
+dnd               +mouseshape        +spell             +xim
-ebcdic            +mouse_dec         +startuptime       -xpm
+emacs_tags        -mouse_gpm         +statusline        -xsmp
+eval              -mouse_jsbterm     -sun_workshop      -xterm_clipboard
+ex_extra          +mouse_netterm     +syntax            -xterm_save
+extra_search      +mouse_sgr         +tag_binary
-farsi             -mouse_sysmouse    -tag_old_static
   system vimrc file: "$VIM/vimrc"
     user vimrc file: "$HOME/.vimrc"
 2nd user vimrc file: "~/.vim/vimrc"
      user exrc file: "$HOME/.exrc"
  system gvimrc file: "$VIM/gvimrc"
    user gvimrc file: "$HOME/.gvimrc"
2nd user gvimrc file: "~/.vim/gvimrc"
       defaults file: "$VIMRUNTIME/defaults.vim"
    system menu file: "$VIMRUNTIME/menu.vim"
  fall-back for $VIM: "/Applications/MacVim.app/Contents/Resources/vim"
Compilation: clang -c -I. -Iproto -DHAVE_CONFIG_H -DFEAT_GUI_MACVIM -Wall -Wno-unknown-pragmas -pipe  -DMACOS_X -DMACOS_X_DARWIN  -g -O2 -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=1
Linking: clang   -L. -fstack-protector-strong -L/usr/local/lib -L/usr/local/opt/libyaml/lib<EMAIL_ADDRESS>-L/usr/local/opt/readline/lib -L. -fstack-protector-strong -L/usr/local/lib -L/usr/local/opt/libyaml/lib<EMAIL_ADDRESS>-L/usr/local/opt/readline/lib  -L/usr/local/lib -o Vim -framework Cocoa -framework Carbon       -lm  -lncurses -liconv -framework AppKit   -fstack-protector  -L/System/Library/Perl/5.18/darwin-thread-multi-2level/CORE

I know this is a long shot, because you would have already noticed it. Do you, by chance, have
let NERDTreeShowFiles = 0

in your vimrc? The F keystroke in NERDTree will toggle the display of files on and off. Does reveal your missing file?

I'm thinking it has something to do with the way the globpath() function and/or your OS shell interprets the braces. I'm using the bash shell. Let's see if these questions help.

What shell are you using? echo $SHELL
What value does your Vim shell setting have? :set shell?
What does this command return? You may need to use the full path.

echo globpath('source-dirs/{{cookiecutter.name}}', '*', 0, 1, 0)

Yep, seems like it is the issue, I use fish shell
~ » echo $SHELL
/usr/bin/fish

~ » echo globpath('{foo}', '*', 0, 1, 0)

fish: Unknown command: '{foo},'
in command substitution
fish: Unknown error while evaluating command substitution

in vim:
  shell=/usr/bin/fish

:set shell=/bin/bash resolves the isssue

Just to be clear, the :echo globpath... statement should be run inside of Vim. Make sure you use the actual file path of the folder with braces in it's name. Try it again, and report back what it does.

Running :echo globpath in parend of {{cookiecutter.name}} dir returns []. Running :set shell=/bin/bash and then globbing returns list of files
Maybe there is some way to escape those braces? Or I should just set my vim shell to bash?

If set shell=/bin/bash works and doesn't break anything else, I see no reason to not do that. I wonder if this is a Vim bug. @mcabrams, what shell are you running vim in? I wonder if there's a similar issue on the Mac.

Escaping, as shown below, does work, but I think it should work consistently between shells. I will open an issue in the Vim project. I also confirmed this can be recreated in the fish shell on a Mac.
echo globpath(escape('source-dirs/{{cookiecutter.name}}','{}'), '*', 0, 1, 0)

On second thought, this is easily fixed in NERDTree, and calling this a bug in Vim will likely get shot down. The Vim function fnameescape() will properly escape the filename, but NERDTree also has its own way of escaping filenames. Don't ask me why; maybe it was there before Vim built it in.
Anyway, checkout the branch 1092, and give it a shot without your set shell=/bin/fish statement.

Checked out branch 1092, dir expansion works fine, thank you!

Code injection
It is surprising that listing files has anything to do with shell. Does it mean that eventually name of directory is passed to shell? If yes, the escaping should be done for every shell, otherwise I can do nasty things just by having directory danger_$(rm -rf /)_dir or whatever is analog in other shells. I suppose the escaping should be done on vim level.

Error handling
Why does it return empty list instead of propagating the error from shell?

NERDTree is escaping the folder name before calling globpath() for all shells, and I don't think it actually runs in a shell. The new change here is that braces are escaped.
My guess is that since the command doesn't run in the shell, there is no shell error to return. The empty list probably indicates there is no such path with unescaped braces.


Remove feature deprecation manager

Codecov Report

Merging #15715 (4123dd0) into main (3ca66f9) will increase coverage by 0%.
The diff coverage is n/a.

@@          Coverage Diff           @@
##            main   #15715   +/-   ##
======================================
  Coverage     64%      64%
======================================
  Files        557      556    -1
  Lines      26730    26661   -69
  Branches    3887     3874   -13
======================================
- Hits       17292    17262   -30
+ Misses      8708     8675   -33
+ Partials     730      724    -6

Impacted Files
Coverage Δ

src/client/common/serviceRegistry.ts
100% <ø> (ø)

src/client/common/types.ts
100% <ø> (ø)


config default branch

Codecov Report

Merging #62 (5403dd5) into develop (ef6acd4) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop      #62   +/-   ##
========================================
  Coverage    89.07%   89.07%
========================================
  Files            4        4
  Lines          595      595
========================================
  Hits           530      530
  Misses          65       65

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Not getting "note" type shape

I'm trying to generate a graph that makes use of the "note" type shape. However, I get what seems to be the "oval" shape instead.

I have tried looking through the code here in the repo to see what could be the culprit, but haven't been able to find it. To be fair I didn't spend hours on that.
I have read through the DOT language documentation, especially >> http://graphviz.org/content/node-shapes and there I see the "note" shape mentioned. So shouldn't it be available via PSGraph?

what I want

what I get

Is this a bug or am I misunderstanding something?
Thank you 👍

Check your case to make sure it matches the spec. So use note instead of Note. I have been considering adding logic to resolve this. If everything was lowercase then I would just do a tolower() but there are some exceptions.

HI @KevinMarquette
Yup that was it. Simply, the case was the problem.
Thank you very much. Me not being aware that DOT is case sensitive.


[Bug]: Unhandled exception while closing the qr scanner screen

Telegram Application
Telegram for iOS
Describe the Bug
Unhandled exception while closing the qrScanner screen, opened by using useQrScanner hook inside react app
This error prevents subsequent openening of qrScanner, because SDK thinks it's still open
Unhandled Promise Rejection: Error: QR scanner is already opened.

Here is an error snippet
"An error occurred processing the \"scan_qr_popup_closed\" event from the Telegram application. Please, file an issue here: https://github.com/Telegram-Mini-Apps/tma.js/issues/new/choose"
{eventType: "scan_qr_popup_closed", eventData: null}
TypeError: undefined is not an object (evaluating 'i.event') —

To Reproduce
  const qrScanner = useQRScanner()
return <button onClick={() => { qrScanner.open()}}></button>

I click on button and qr screen opens
I close native qr screen
I click on button again and  qr screen opens

Expected Behavior

I click on button and qr screen opens
I close native qr screen
I click on button again and nothing happens due to excpetion

Fixed. Thank you for the report!


Test build with NODE_OPTIONS

Description (required)
Checking if this one weird trick can speed up the Vercel CI
Related issues & labels (optional)

Unfortunately there's no improvement


Add error handling for DELETE for 'HttpURLConnection.writeRequestBody'

Currently, the writeRequestBody method acknowledges PUT, POST, and PATCH as methods that may contain a body.
Although DELETE shouldn't include a body, it is possible and thus should be handled (to be thorough).

In solving this, it might be useful to check the Azure-SDK-for-Android library (specifically the sendIntern method of the `HttpUrlConnectionAsyncHttpClient' class).

This issue was duplicated in issue #33


Add package step to grunt

Update Gruntfile.js to include support for packaging the app up for deployment. This will include ng-annotate and minifying the code, among other things.

Closed by #14


uLocationGetContinuousStart doesn't throw errors

When using uLocationGetContinuousStart function to get a fix using the callback we don't get errors such as timeout or I/O failures.
Device errors aren't coming through e.g. we can disconnect the antenna and don't get a timeout. And we can even disconnect the GNSS completely and we don't get an error.

Hi there.  Yes, checking the code the user callback is only called if a message is received from the GNSS device indicating that a successful-and-at-least-2D position fix has been achieved.
I guess it could be changed to call the user callback if it is able to parse the message from the GNSS device, irrespective whether a position fix has actually been achieved or not, leaving it up to the user to decide what to do with the results.  Would that be better?
This would constitute a [minor] interface change, so I would need to justify it with a good use-case.

When using it in a control system we would also like to know when we get a poor fix or no fix at all.
More particularly if an errors occurs i.e. for some reason the GNSS gets power cycled we could hypothetically restart ubxlib to reconfigure the GNSS.

Understood.  Find here:
https://github.com/u-blox/ubxlib/tree/preview_fix_gnss_streamed_error_case_rmea
...a preview branch which should report any navigation fix received from the GNSS device, irrespective of whether it contains a fix or not.  Let me know if is is closed to what you want and I will push the change to master here, after it has passed testing, and delete the preview branch.
Of course, this still only calls the callback when the GNSS device has sent something.  That's kind of the nature of thte continuous API: the GNSS chip is asked to send navigation fixes at a given periodicity and if it doesn't, well, it doesn't!  The ubxlib code is simply passing on what it gets, IYSWIM.

Well this is actually what I was looking for, so I can get a signal when our fix isn't good enough and we if don't get anything it means something is wrong. Thanks!

Good stuff; will let you know when it's here, gotta tweak a few tests to expect the new behaviour first.

You can now find the change on master here: https://github.com/u-blox/ubxlib/commit/efdc592cb2aa840900e1c6591d00124f41eb8867, I will delete the preview branch later today.


ansible: Update documentation to run ansible on the deployment host

We used to provide a docker container with ansible and the dependencies
required by the playbooks already installed on it.
This commit updates the documentation to instruct the user to install
ansible and the required packages on the deployment host since using
the container proved to be more cumbersome than installing the few
depdendencies.
Signed-off-by: Alberto Murillo Silva<EMAIL_ADDRESS>

Coverage decreased (-0.07%) to 65.907% when pulling 5653e465392d3c5f4771aa4c97573be31968ccd3 on albertomurillo:ciao_deploy into c29e510166e975f6823449c45de06f6649b5a39e on 01org:master.


Nginx Ingress - 400 Bad Request: Request Header Or Cookie Too Large

Whenever I have a ingress controller which proxies to an ingress controller in a different namespace, I sometimes get "400 Bad Request: Request Header Or Cookie Too Large"
Note that I am also using Basic Auth on the second ingress controller.
Thanks,

@qrpike please check if adding large-client-header-buffers: "4 16k" in the configuration ConfigMap solves the issue.

@aledbf I was looking at that. I have kubernetes self hosted on bare metal so I often need to talk across namespaces. As long as I don't enable auth it works fine, enabling auth causes the issues.
I worked around this by having the main ingress just point directly to that namespaces services. Gets rid of a network hop as well.
Thanks,

@qrpike please reopen if you still have issues

Hello,
We are experiencing same problem .
ingress version: gcr.io/google_containers/nginx-ingress-controller:0.8.3
I have added large-client-header-buffers: "4 16k" into configMap - but it was not propagated to to pod.
    args:
    - /nginx-ingress-controller
    - --default-backend-service=$(POD_NAMESPACE)/default-http-backend
    - --nginx-configmap=$(POD_NAMESPACE)/nginx-ingress-controller

apiVersion: v1
data:
server-name-hash-bucket-size: "128"
large-client-header-buffers: "4 16k"
kind: ConfigMap
metadata:
name: nginx-ingress-controller

@MilanDasek This is because ( i found out recently ) that the ingress ~controller~ actually listens in ALL namespaces. You get that header-buffer because it's doing a ton of redirects between your namespaces before finally arriving at the location ( based on luck of finally getting through ). Thats why you only get it sometimes.
So you should make 1 ingress controller deployment/daemonset in default namespace or where ever you like. And create the ingresses for your services in that services namespace. The ingress controller will see it and route the traffic accordingly. I was shocked too, but it works.

@qrpike
I am sorry, I would like to be sure I do understand.
So Nginx Ingress Controller (basically Nginx server) should be deployed in "default" namespace and all ingresses for all services should be in "default" namespace as well, instead of respective namespaces where underlying services are sitting?
That means I have to deploy this ingress to "default" namespace (for example)
apiVersion: extensions/v1beta1
kind: Ingress
metadata:
name: proxy
annotations:
kubernetes.io/ingress.class: "nginx"
ingress.kubernetes.io/ssl-redirect: "true"
spec:
rules:

host: test.url
http:
paths:

path: /
backend:
serviceName: NAMESPACE/proxy
servicePort: 80

Correct?

No, nginx ingress controller should be in default, and the ingress's should be in whichever namespace that service is in. The ingress MUST be in the same namespace as the service it is routing to.

@qrpike so it is exactly how I have it set now.
nginx ingress controller in default NS
ingresses for services are in the same namespaces.
So what is the idea then?

@MilanDasek Then it should work as expected.  I would like still to have a possibility to change
large-client-header-buffers: "4 16k"

@MilanDasek Check to make sure you dont have ingress's or services in the wrong namespaces.

@MilanDasek you can change that setting using the configuration configmap. Just add large-client-header-buffers: "XX XX"

I have this
apiVersion: v1
data:
large-client-header-buffers: 4 16k
server-name-hash-bucket-size: "128"
kind: ConfigMap
metadata:
creationTimestamp: 2017-03-07T18:31:22Z
name: nginx-ingress-controller
but when I search in nginx.conf in ingress
kubectl exec nginx-ingress-controller-XXX -- cat /etc/nginx/nginx.conf | grep client
I got only
client_max_body_size "1m";

@MilanDasek client_max_body_size is configured with proxy-body-size. The body and headers are configured by different nginx directives

@MilanDasek just in case this feature is not present in 08.3. You need to use one of the 0.9 betas.

@aledbf that is the problem, I use 0.8.3 ,but when I use 0.9.0-beta2, TCP stream stops working.
my config:
apiVersion: v1
kind: ConfigMap
metadata:
name: name-27017
data:
27017: "namespace/service:27017"
ingress RC
- --nginx-configmap=$(POD_NAMESPACE)/nginx-ingress-controller
- --tcp-services-configmap=$(POD_NAMESPACE)/name-27017
I found out I have to change
- --configmap=$(POD_NAMESPACE)/nginx-ingress-controller
- --tcp-services-configmap=$(POD_NAMESPACE)/name-27017
but tcp does not work
I am following https://github.com/kubernetes/ingress/tree/master/controllers/nginx
but seems it is fixed in https://github.com/kubernetes/ingress/pull/344
which is not in beta2 https://github.com/kubernetes/ingress/blob/master/controllers/nginx/Changelog.md

works in beta3
https://github.com/kubernetes/ingress/blob/master/controllers/nginx/Changelog.md

@MilanDasek can we close this then?

Yes, thank you.

Hello, It doesn't work for me...
Here's my configmap in ingress-nginx namespace
# Source: ingress-nginx/templates/controller-configmap.yaml
apiVersion: v1
kind: ConfigMap
metadata:
  labels:
    helm.sh/chart: ingress-nginx-4.0.10
    app.kubernetes.io/name: ingress-nginx
    app.kubernetes.io/instance: ingress-nginx
    app.kubernetes.io/version: 1.1.0
    app.kubernetes.io/managed-by: Helm
    app.kubernetes.io/component: controller
  name: ingress-nginx-controller
  namespace: ingress-nginx
data:
  allow-snippet-annotations: 'true'
  large-client-header-buffers: "4 16k"

and I have a few ingresses in another namespace, but no matter how I change large-client-header-buffers value I still get 400 Request Header Or Cookie Too Larg
This's how I'm testing:
curl -I --header "x-test: 8k" https://my.domain # -> 200
curl -I --header "x-test: 8k + a few bytes" https://my.domain # -> 400


Upgrade Spine runtime to spine-ts

blogpost: http://esotericsoftware.com/blog/spine-ts-released
repo: https://github.com/EsotericSoftware/spine-runtimes/tree/master/spine-ts

Awesome! Pretty good plugin. I thought that spine wasn't supported in Phaser before stumbling onto that blogpost, and then this plugin. How's the mobile performance of Phaser + Spine + Intel XDK on a mobile phone for you so far?

It's pretty decent. We've released only one game with Spine assets, and the performance is not bad at all. There's always some room for improvement, but it was definitely playable!

I've given it a test run as well. On an octacore Snadragon 615 CPU, I take it it does about 30-40fps consistently while displaying the spineboy and raptor spine objects at the same time. Speaking of which, how do I destroy spine objects? I currently assigned them to one or two groups, then when I destroy them, I do:
obj[spinekey].destroy();
delete obj[spinekey];
It does remove them, but I'm thinking that removing them while they're still animating will still have the CPU compute for their animations despite them being removed visually. Is this the case?

the Spine object is an extend Phaser.Group so it has a destroy() method like everything else. It could be possible that there is a leak somewhere in destroying them, I didn't add any extra logic there.
As for the tween stuff, spine simply only updates x/y/rotation values based on what is done in the runtime. There are no Phaser Tweens active, so settings tweens to frameBased should have no impact on the Spine animation

Ah ok, so spine's animation is separate and doesn't use Phaser's built-in tweener in any way no?
And the destroy() function should clear up any spine animation on stage and/or running, freeing up memory and cpu as it should, correct?

This gist of it is done in the spine-ts branch, all the lingering issues will be picked up seperatly and we have the project page now to track progress


Index collisions for non-script pages

It looks fairly easy to cause an index collision by having some headings with the same names, which also means that items like Editor properties are difficult to index (since properties like 'name' will be defined in multiple pages).
So this probably needs some page design convention to try and avoid collisions, or a reference to the page title in the index entry, or some kind of reverse lookup for the index.
On a sort of related note, if there is a heading that just says "Conclusions" you probably don't want that indexed at all.

Would it be possible to switch to the manual index instead in the future?
Perhaps that would also allow to add extra alias keywords for existing topics when necessary.

Yes, in theory the index can come from anywhere, so it could be metadata within the document, or metadata read from an external file, or a change of format (so switch to use reST).
...but at the moment I'll try to split the index data between script API and other content, and then try to add the reverse lookup, which I think will fix it.

According to current checks there are no longer any name collisions.


jnilib files aren't signed for mac

I'm trying to notarize a Mac Desktop application that' uses this library. The new Big Sur OS has strict requirements around signing and notarization. When I'm notarizing the application, here is the error that I get from Apple with the notarization process concerning libsqlitejdbc.jnilib:
{
severity: "error",
code: null,
path: "My_App-1.0.0.dmg/My App.app/Contents/app/sqlite-jdbc-3.34.1-371b212b7663f42133e45d49e82ad30.jar/org/sqlite/native/Mac/x86_64/libsqlitejdbc.jnilib",
message: "The binary is not signed.",
docUrl: null,
architecture: "x86_64"
},
{
severity: "error",
code: null,
path: "My_App-1.0.0.dmg/My App.app/Contents/app/sqlite-jdbc-3.34.1-371b212b7663f42133e45d49e82ad30.jar/org/sqlite/native/Mac/x86_64/libsqlitejdbc.jnilib",
message: "The signature does not include a secure timestamp.",
docUrl: null,
architecture: "x86_64"
}

This seems to be an already known issue: https://github.com/xerial/sqlite-jdbc/issues/383
To be honest, I have no idea how to solve that. I'll try to find something.

If you are generating this file when you ship the library, like I think you are, then them signing the file won't fix it I don't think.

So after looking into this some more - I don't think there is anything you can do to fix it. I ended up submitting a PR to have this fixed by compose.


chore: parse escaped double colon (\:) example struct tag

Describe the PR
Replaces the regular string splitting by a ":" made during the "example" tag parsing so that it will not split escaped double colons, allowing string examples containing a double colon to be escaped using double backlashes.
Relation issue
https://github.com/swaggo/swag/issues/1401
Additional context
Since the core regexp library cannot suport negative lookaheads, I had to combine a regular expression with a loop to capture all the ocurrences and append them to an array.

I see your purpose is to make the map value contain colons.
But I wonder why not use a light mode to fix it, for example, use strings.IndexRune to find the first colon and split the string into two parts, a key and a value.

Hello @sdghchj, initially I went with this approach to allow escaped double colons in the key value, but thinking better about it it does not make much sense and I can't think of a valid use case for it.
I've refactored the code using strings.SplitN to split at the first ocurrence of a :, this makes the change much simpler and from my tests it won't be necessary to escape the remaining double colons in the value, so for example the struct from my issue would work without any changes:
type Foo struct {
  Attributes map[string]string `example:"bucket_arn:arn:aws:::foobar-bucket"`
}


Prevent click on popup tip from firing on map.

Fix #4596 / #5720

This change is

@Falke-Design Thank you for great suggestion!
I've added your test (with some mods).
The only flaw - test case does not work in IE.

@mourner your part to approve and merge 😉


Is it possible to open h265 file?

Be sure to search for your issue before opening a new one.
Current Behavior
Application is not opening h265 file
Expected Behavior
Application opening h265 file
Steps to Reproduce

Change url to h265 file (local or external) and doesn't work

Environment

URL attempting to play:
Browser:
Operating system:
jsFiddle example: https://jsfiddle.net/sv5x3ug1

Other Information

ReactPlayer is just a proxy for <video> when playing file URLs. Support for H265 will be based on whether the browser supports it, many of which don’t.


Bug when pushing new view controller from viewDidLoad()

When you are trying to push another (let it be №2) view controller from viewDidLoad() (№1) everything looks good before you want to pop back. NavigationBar inside view controller №1 will be transparent.

Hi @NosovPavel, it is not recommend to push a new view controller in viewDidLoad method.

@MoZhouqi Yeah, but what should I do in this case? If I push new VC in viewWillAppear or later user will see the content and if I do it in viewDidLoad user won't see content. I need this behavior because of project requirements, main thing is - user should have opportunity to move back to rootVC.

You could try to use the setViewControllers: method.


[doc] setTrustedCertificates doesn't replace certs

With the previous wording, "Sets the set of ... certificates", I've assumed it always replaces everything in the store (at least on non-iOS).
This change should make it clear that the certificates are added.
(See also https://github.com/dart-lang/sdk/blob/bc2cf88bac44d02a44b9c315a8fd05eca2ecbaa4/runtime/bin/security_context.cc#L181 for the actual implementation).

@googlebot I signed it!


Config retrieval should convert to relevent data structure automatically

Not sure where exactly this should go (I think it should likely go into the pulumi/pulumi) but filing it here for now, please feel free to move
I load an environment:
# Pulumi.development.yaml
environment:
  - development
config:
  aws:region: us-west-2

I then load than config into my Pulumi program:
"""An AWS Python Pulumi program"""
import pulumi

config = pulumi.Config()

aws = config.get("aws")
pulumi_environment_config = config.get("pulumi")

print(pulumi_environment_config)
print(type(pulumi_environment_config))

This returns the relevant config:
Diagnostics:
  pulumi:pulumi:Stack (esc-test-development):
    {"orgName":"lbrlabs"}
    <class 'str'>

But I was surprising to see that it's just a string. I have to json.loads it to make it useful:
"""An AWS Python Pulumi program"""
import pulumi
import json

config = pulumi.Config()

aws = config.get("aws")
pulumi_environment_config = json.loads(config.get("pulumi"))

print(pulumi_environment_config)
print(type(pulumi_environment_config))

Diagnostics:
  pulumi:pulumi:Stack (esc-test-development):
    {'orgName': 'lbrlabs'}
    <class 'dict'>

Not exactly a showstopper, but I think it would be better if we can somehow make this step not required.

@jaxxstorm Can you show how your environment is defined in this case?

@cleverguy25 do you want the environment definition, or maybe a screenshot?

I think either would work
On Fri, Oct 20, 2023 at 1:17 PM Lee Briggs @.***> wrote:

@cleverguy25 https://github.com/cleverguy25 do you want the environment
definition, or maybe a screenshot?
—
Reply to this email directly, view it on GitHub
https://github.com/pulumi/esc/issues/136#issuecomment-1773342075, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/ABJAMILOAFUUXCCNONRVDNLYALL4LAVCNFSM6AAAAAA6G7FHY2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONZTGM2DEMBXGU
.
You are receiving this because you were mentioned.Message ID:
@.***>

# values is a required top-level key
values:
  pulumi:
    orgName: lbrlabs
  aws:
    orgid: foo
  github:
    orgName: lbrlabs
  environmentVariables:
    AWS_ORG_ID: ${aws.orgid}
  pulumiConfig:
    aws:
      orgid: ${aws.orgid}
    pulumi:
      orgName: ${pulumi.orgName}
    github:
      orgName: ${github.orgName}

@jaxxstorm I think you need to use get_object, not get. get always returns an Optional[str].

That got it, thanks!


doc: write release process

[x] Updated Unreleased section in CHANGELOG or it's not notable changes.

ref: #560

Thank you for your review!


Round trip VR/no-VR works only one time

Hi everyone,
In my house design project, you can at the end activate a VR mode (and take HTC Vive Headset and one controller) to visit the house you designed.
It works, np.
Then, you can leave this VR mode with a button and go back to computer to change something (for example a door). It works too.
But when you re-activate VR mode to visit again, I don't know why but there is not any controller. Headset works, you can see the game world, rotate on yourself, etc. But the controller is fixed in its world position, it doesn't move or take any touch events.
I use SteamVR and OpenVR (HTC Vive). My transition is done just by deactivating the main camera and enabling Player and Teleporting SteamVR prefabs.
Unity 2019.1.10f1
Steam VR 1.5.16
The strangest thing is : It works in editor play mode, but doesn't when it's build (Controllers work only "one time")
To activate VR :
MainCamera.SetActive(false);
yield return new WaitForEndOfFrame();
XRSettings.LoadDeviceByName("OpenVR");
yield return new WaitForEndOfFrame();
XRSettings.enabled = true;
PlayerVR.SetActive(true);
TeleportVR.SetActive(true);

To deactivate VR :
PlayerVR.SetActive(false);
TeleportVR.SetActive(false);
XRSettings.LoadDeviceByName("None");
yield return null;
XRSettings.enabled = false;
MainCamera.SetActive(true);

Did someone develop a program where you could go to VR and back to no-VR as many times as you want ?
Thanks

Hi,
I had the same issue, as you can read here: https://github.com/ValveSoftware/steamvr_unity_plugin/issues/307

I believe this has been fixed since this post was made. If not, please create a new issue with the repro steps and ideally an example project to replicate the issue. Thanks!


Avoid ignoring items for having a permalink

Before submitting the PR:

[x] Does your PR reference an issue? If not, please chat to the team on Discord or GitHub before submission.
[x] Did you update and run tests before submission using npm run test?
[x] Does your branch follow our naming convention? If not, please amend the branch name using branch -m new-branch-name
[x] Did you update documentation related to your new feature or changes?

What does your PR address?
Tips

Tap "convert to draft" to indicate this is work in progress.
Link to an issue using the verbiage Fixes #XX
Linked issues will auto-close when the PR is merged.

@rammsesgit make sure your PR links to a relevant issue. This appears to alter behavior that does not line up with the issue described in #1143. In some scenarios we'll outright deny a PR like this, but I'll give you a pass this time given the scope of the changes are small.
I'll do my review now. If this change is accepted it'll be merged. If not I'll explain why.

@rammsesgit the change looks to work fine so I'll allow it. But I'd advise grouping further table of contents related issues here:
https://github.com/skeletonlabs/skeleton/issues/1030
I'm not currently satisfied with how this component operates and a number of changes are coming soon. The team and I will be discussing how we want to introduce breaking changes, which may arise from a refactor of this scale.
For now just note issues there and I'll take them into consideration when reworking this feature. Thanks!


⚠ Bofrost.at has degraded performance

In f55e79b, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 2613 ms

Resolved: Bofrost.at performance has improved in f3b2467 after 13 minutes.


fix(http-instrumentation): crash fix

Which problem is this PR solving?

Fixes https://github.com/open-telemetry/opentelemetry-js/issues/2008

Short description of the changes

Safely access constructor.name, in case object doesn't have a custructor.

Added a test


created a pipeline for building the OVS docker image.

Description
created a pipeline for building the OVS docker image. This will build and publish the docker image defined here. The production target only.
Motivation and Context

How Has This Been Tested?

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[X] New feature (non-breaking change which adds functionality)
[ ] Enhancement (improves on existing behavior)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[X] My code follows the code style of this project. (Did you install and run the pre-commit hooks?)
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.

:+1:


Raspberry Pi 3B - Error: Cannot find module 'fluent-ffmpeg'

Why the module can't be found?

solved it, it was just an error on the first line:
var ffmpeg = require('fluent-ffmpeg'); ->
var ffmpeg = require('/you/have/to/add/the/libraries/route/fluent-ffmpeg');
It worked properly on my macbook pro without specifying the route, and Raspberry Pi needed it explicitly.


feature request: Look for servers NOT in the server_types.json

basically, it would scan all of the available types and alert on new ones that arent in that list.
This would allow you to be alerted to 'specials' that arent in the normal server options as soon as they become available.

Good feature, implementation seems not hard. If you'll be faster and submit a pull request I'd merge it right away.


text expand to trigger a template

Can jellysnippets have an option in where the snippets can also trigger
insertion of a template not just RHS of a snippet?
example:
Triggerword |+| template(NAME-OF-THE-TEMPLATE)
This could potentially solve the previous issue for a multi-line request.
Where multi-line snippets could simply be in template folder.

I like the idea, both of storing snippets in files and of templating. Will make a note.


Make a local config that can be loaded

I think its confusing to have two different ways to instantiate the DFK. I think we should do away with the shorthand way and instead push people towards using config objects. The easiest way would be to include a local config in the Parsl package that could be imported.
E.g., from parsl.config import local_config

In the latest parsl, we now have a configs module that can be expanded to support a curated set of sites.
from parsl.configs.local import localThreads
from parsl.configs.local import localIPP

The above works in the parsl master branch.
The drawback here is that we are provider whole configs that contain a single site, rather than a method
that pulls together multiple sites into a one config. This is what I think makes most sense:
from parsl.configs import configBase
from parsl.sites import localThreads, coriRemote, thetaRemote
configBase['sites'] = [localThreads, coriRemote, thetaRemote]

I think this would make the config more composable, but I'm not entirely sure how many users would want/use multi-site configs.

I think perhaps this becomes simpler and more manageable if we process
config docs via code instead of importing them?
MICHAEL WILDE
Parallel Works Inc. http://www.parallelworks.com
<EMAIL_ADDRESS>m +1<PHONE_NUMBER>
On Thu, Feb 22, 2018 at 5:41 PM, Yadu Nand B<EMAIL_ADDRESS>wrote:

In the latest parsl, we now have a configs module that can be expanded to
support a curated set of sites.
from parsl.configs.local import localThreads
from parsl.configs.local import localIPP
The above works in the parsl master branch.
The drawback here is that we are provider whole configs that contain a
single site, rather than a method
that pulls together multiple sites into a one config. This is what I think
makes most sense:
from parsl.configs import configBase
from parsl.sites import localThreads, coriRemote, thetaRemote
configBase['sites'] = [localThreads, coriRemote, thetaRemote]
I think this would make the config more composable, but I'm not entirely
sure how many users would want/use multi-site configs.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/Parsl/parsl/issues/96#issuecomment-367860912, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ABqb2PRrzbSQxlnCTaGzh3uLYaVQmWWGks5tXfs_gaJpZM4SAyr0
.

@kylechard If you think the local configs are okay can we close this one ? I think standardizing site configs, and allowing users to combine sites is going to take more design that we should defer until we have more user input.
@mjwilde We are treating configs as code/datastructures that can be imported, modified etc.

This appears to have been unwound in 49d9594b2d6ac782a9edf4776c4521db9133a622


Removing the old sprite editor (may it rest in peace)

Removing the last remaining usage of the old sprite editor in the snippet builder. I saved the editor/gallery toggle because it was used by the melody editor and refactored the bitmap utils into pxtlib so that they aren't duplicated anymore.

The new sprite editor is taller than the old one, so it causes this step to scroll on some screens. I removed the gallery to help mitigate that, but if we want it to not scroll we probably need to shrink the top and bottom modal margins. If I add the gallery back it will scroll on every screen.

@riknoll ready to merge?


How can I enable compat_aliases

I came across the same problem in https://github.com/adambrenecki/virtualfish/issues/51
And figure it by removing compat_aliases, but how can I bring back those commands in virtualenvwrapper?
fish: Unknown command 'mkvirtualenv'
Name: virtualfish
Version: 1.0.0a1

Hi,
If you're using 1.0.0a1, you need to set VIRTUALFISH_COMPAT_ALIASES, as documented in the docs for 1.0.0a1.

Thanks a lot!


add --dangerous-scope-to-fallback-allowed-namespaces

this is useful to force kapp only look within a fallback-allowed-namespace -- and in case there is only 1 ns (currently that's the case), it eliminates a lot list requests when running under a service account that has access to list all namespaces, but does not have access to list resources within those namespaces.

available as part of v0.41.0

why it is not a default? I need to do more tests, but looks like kapp delete --namespace abc --app 'label:x=y'    is not actually scoped to a namespace abc.

Hi @redbaron! This becomes the default behaviour when you have scoped permisions (no permission to list namespaces).

If I have a cluster wide permissions, I'd still expect kapp delete --namespace abc to act only on abc namespace, not anywhere else.

The --namespace flag is actually used to store the metadata configmap, the resources present in the app could be present in other namespaces as well. Right now we only use the namespace provided in namespace flag as a fallback, we are working on including all the resource namespaces as fallback namespaces. But even then there are chances that all the resource namespaces are not included in some scenarios (failure to save/update the metadata configmap), that's why this is a fallback approach rather than the direct one.


[BUILD] Package release tarball

Why are the changes needed?

export RELEASE_VERSION=1.3.0-SNAPSHOT # keep same version with pom.xml
export SKIP_GPG=false                 # optional, default false
build/release/create-package.sh source
build/release/create-package.sh binary

➜  apache-kyuubi git:(asf-pub) ls -lh work/release
total 161256
-rw-r--r--  1 chengpan  staff    60M Aug  4 15:12 kyuubi-1.3.0-SNAPSHOT-bin.tgz
-rw-r--r--  1 chengpan  staff   488B Aug  4 15:12 kyuubi-1.3.0-SNAPSHOT-bin.tgz.asc
-rw-r--r--  1 chengpan  staff   212B Aug  4 15:12 kyuubi-1.3.0-SNAPSHOT-bin.tgz.sha512
-rw-r--r--  1 chengpan  staff    18M Aug  4 15:10 kyuubi-1.3.0-SNAPSHOT-source.tgz
-rw-r--r--  1 chengpan  staff   488B Aug  4 15:10 kyuubi-1.3.0-SNAPSHOT-source.tgz.asc
-rw-r--r--  1 chengpan  staff   215B Aug  4 15:10 kyuubi-1.3.0-SNAPSHOT-source.tgz.sha512

Planning to add release script and release doc in following PRs.
How was this patch tested?

[ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible

[ ] Add screenshots for manual tests if appropriate

[ ] Run test locally before make a pull request

Codecov Report

Merging #889 (4b0be7d) into master (4fecf13) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #889   +/-   ##
=========================================
  Coverage     79.16%   79.16%
  Complexity       11       11
=========================================
  Files           143      143
  Lines          5346     5346
  Branches        649      649
=========================================
  Hits           4232     4232
  Misses          751      751
  Partials        363      363

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4fecf13...4b0be7d. Read the comment docs.

@ulysses-you Would you please have a check on failures of Minikube Integration Test? Seems not relative.

@pan3793 yeah, it's not related. Not sure why this happened, I will do a follow up.

kyuubi-incubating-1.3.0xxx?

kyuubi-incubating-1.3.0xxx?

Both kyuubi-incubating-1.3.0 and kyuubi-1.3.0-incubating are acceptable, prefer the latter because no extra effort after graduating to TLP.
https://mvnrepository.com/artifact/org.apache.iceberg/iceberg-api

kyuubi-1.3.0-incubating +1

@pan3793 yeah, it's not related. Not sure why this happened, I will do a follow up.

seems it's a random event .. I passed it with https://github.com/apache/incubator-kyuubi/pull/890/checks?check_run_id=3239593925

OK, let me retry and see what happens.

Thanks, merging for v1.3.0


Fix tortoise memory leak if verified layer gets stuck

Description
If our assumptions hold, and self-healing works, the verified layer should not get stuck for very long in tortoise. However, if it does get stuck, we have a potential memory leak where the tortoise data structures will keep growing monotonically and will not be able to evict old layers. This is because the eviction window depends directly upon the last verified layer:
https://github.com/spacemeshos/go-spacemesh/blob/9d3a379994e3652eb0378d2cc555588bba91005e/tortoise/verifying_tortoise.go#L187-L204
We either need stronger guarantees about the maximum size that this window can reach, or else we need to take more aggressive steps to manage/bound memory usage here.
This issue appears in commit hash: 9d3a379994e3652eb0378d2cc555588bba91005e

It was noted in some discussion that we should evict from sliding window based on the Last layer, not Verified. It removes this potential leak.

I suggest we don't do anything about it. In current version the "leak" is still there, but it is manageable unless the tortoise is stuck for > 10 000 layers.


Future posts appear in list as just a "read more"

Hi, I'm using this template and I tweaked my config.yml like this:
#hide future posts to allow auto publishing by date:
future: false

Then I uploaded a post to _posts called 2017-4-20-Concepts-Docs-Attach-Notes (that's tomorrow). I have another future post that is scheduled for 2019 (just for a test).
The result: the post for 2019 is correctly hidden from view.
But the one for tomorrow is acting very weird - I think this could be a bug. On my front page I get this:

So, the post appears on the list, but the title doesn't show, the excerpt doesn't show, it just shows the "Read more" link.
If I click on that link, it works, and takes me to the post page, BUT on the bottom it reads "Written on April 19, 2017" instead of "Written on April 20, 2017" which is the date given on the file name...
These are the contents of my index.html:
---
layout: default
---
<link rel="shortcut icon" type="image/x-icon" href="{{ site.baseurl }}/favicon.png" >

  {% for post in site.posts %}

{{ post.title }}

        {{ post.excerpt }}

      Read More

  {% endfor %}

It seems the future posts are part of the for loop, although they don't have titles or excerpts. But the "Read more" expression and the URL are present for some reason... and I have no idea why the other article, farther into the future, doesn't exhibit the same behavior...
Can anybody please help? I appreciate it.

Solved it, it had nothing to do with future posts, simply my post title included a :  and that was breaking Jekyll. It seems post titles with : need to be enclosed in apostrophes.


double-beep: Blacklist shark\W*tank

double-beep requests the blacklist of the keyword shark\W*tank. See the MS search here and the Stack Exchange search here.

shark\W*tank has been seen in 429 true positives, 1 false positive, and 0 NAAs.

I'm strongly hesitant to blacklist something that detects "Shark Tank", with a space between the words, given that it's the name of a television show (which is the reason there's spam saying "shark tank"). While 69 hits is not a huge number of hits on SE, it's still substantial, particularly as a percentage of the 391 detections. OTOH, this has been on the watchlist for awhile and we haven't see a large number of FP. That can easily change quickly if one of the FP posts becomes active, or if a new one is posted, as such FP tend to be detected multiple times.
I'd be much more comfortable with a blacklist that covered "shark" & "tank" separated by things other than spaces (still a couple of hits on SE for "shark-tank", but not nearly as bad). So, for example, I'd be more comfortable with a blacklist of shark[^\sa-z0-9]*tank and leaving a watch for shark\s+tank. This would blacklist 288 of the 390 TP caught by shark\W*tank when searching bodies. [It gets more complicated as to how many would be blacklisted when also considering titles.]


Search function

I would like to implement a search function so you can search for jots by their code, not just url.

Done


Operator validation

resolves #164

Coverage decreased (-1.9%) to 93.996% when pulling 520c67246a1a9811b6953aed3ebe57aa04a0fcc8 on operator-validation into cfd8990416b3cb1760fc772a8759fabda1d62d52 on main.

Coverage decreased (-1.9%) to 93.996% when pulling 520c67246a1a9811b6953aed3ebe57aa04a0fcc8 on operator-validation into cfd8990416b3cb1760fc772a8759fabda1d62d52 on main.


Proper error handling for old config files that lacks key:value pairs

There's no error handling for the config file

Fixed in latest commit


lock jar file when writing to avoid multiple jvm override him

x Author of the following commits did not sign a Contributor Agreement:
be5230f
Please, read and sign the above mentioned agreement if you want to contribute to this project

done

:grey_exclamation: Build Aborted

The PR is not allowed to run in the CI yet

Expand to view the summary

Build stats

Build Cause: [Pull request #1207 updated]

Reason: The PR is not allowed to run in the CI yet

Start Time: 2020-05-27T16:40:43.328+0000

Duration: 3 min 1 sec

Commit: ceeba8a6394430912abaf6de54497d2580cc431c

Steps errors
Expand to view the steps failures

Name: Error signal

Description: githubPrCheckApproved: The PR is not allowed to run in the CI yet. (Only users with write permission

Duration: 0 min 0 sec

Start Time: 2020-05-27T16:43:42.180+0000

log

Log output
Expand to view the last 100 lines of log output

[2020-05-27T16:43:18.647Z]  > git checkout -f ceeba8a6394430912abaf6de54497d2580cc431c # timeout=15
[2020-05-27T16:43:18.834Z]  > git remote # timeout=10
[2020-05-27T16:43:18.844Z]  > git config --get remote.origin.url # timeout=10
[2020-05-27T16:43:18.858Z] using GIT_SSH to set credentials GitHub user @elasticmachine SSH key
[2020-05-27T16:43:18.863Z]  > git merge 2d28d00626db9b41b28a2bab08875853329426e4 # timeout=10
[2020-05-27T16:43:18.875Z]  > git rev-parse HEAD^{commit} # timeout=10
[2020-05-27T16:43:18.884Z]  > git config core.sparsecheckout # timeout=10
[2020-05-27T16:43:18.891Z]  > git checkout -f ceeba8a6394430912abaf6de54497d2580cc431c # timeout=15
[2020-05-27T16:43:22.742Z] Commit message: "lock jar file when writing to avoid multiple jvm override him"
[2020-05-27T16:43:22.751Z] First time build. Skipping changelog.
[2020-05-27T16:43:22.751Z] Cleaning workspace
[2020-05-27T16:43:23.646Z] Masking supported pattern matches of $JOB_GCS_BUCKET or $NOTIFY_TO
[2020-05-27T16:43:23.685Z] Timeout set to expire in 1 hr 0 min
[2020-05-27T16:43:23.697Z] The timestamps step is unnecessary when timestamps are enabled for all Pipeline builds.
[2020-05-27T16:43:22.743Z]  > git rev-list --no-walk be5230f5491744ffd536794b33b067250888c014 # timeout=10
[2020-05-27T16:43:22.751Z]  > git rev-parse --verify HEAD # timeout=10
[2020-05-27T16:43:22.755Z] Resetting working tree
[2020-05-27T16:43:22.755Z]  > git reset --hard # timeout=10
[2020-05-27T16:43:22.773Z]  > git clean -fdx # timeout=10
[2020-05-27T16:43:23.880Z] [INFO] Number of builds to be searched 10
[2020-05-27T16:43:24.110Z] [INFO] 'shallow' is forced to be disabled when running on PullRequests
[2020-05-27T16:43:24.140Z] Running in /var/lib/jenkins/workspace/_java_apm-agent-java-mbp_PR-1207/src/github.com/elastic/apm-agent-java
[2020-05-27T16:43:24.155Z] [INFO] gitCheckout: Checkout SCM PR-1207 with some customisation.
[2020-05-27T16:43:24.179Z] [INFO] Override default checkout
[2020-05-27T16:43:24.205Z] Sleeping for 10 sec
[2020-05-27T16:43:34.367Z] using credential f6c7695a-671e-4f4f-a331-acdce44ff9ba
[2020-05-27T16:43:34.391Z] Wiping out workspace first.
[2020-05-27T16:43:34.402Z] Cloning the remote Git repository
[2020-05-27T16:43:34.416Z] Cloning repository git@github.com:elastic/apm-agent-java.git
[2020-05-27T16:43:34.444Z]  > git init /var/lib/jenkins/workspace/_java_apm-agent-java-mbp_PR-1207/src/github.com/elastic/apm-agent-java # timeout=10
[2020-05-27T16:43:34.457Z] Using reference repository: /var/lib/jenkins/.git-references/apm-agent-java.git
[2020-05-27T16:43:34.458Z] Fetching upstream changes from git@github.com:elastic/apm-agent-java.git
[2020-05-27T16:43:34.458Z]  > git --version # timeout=10
[2020-05-27T16:43:34.466Z] using GIT_SSH to set credentials GitHub user @elasticmachine SSH key
[2020-05-27T16:43:34.471Z]  > git fetch --tags --progress -- git@github.com:elastic/apm-agent-java.git +refs/heads/*:refs/remotes/origin/* # timeout=10
[2020-05-27T16:43:35.377Z] Cleaning workspace
[2020-05-27T16:43:35.390Z] Pruning obsolete local branches
[2020-05-27T16:43:36.106Z] Merging remotes/origin/master commit 2d28d00626db9b41b28a2bab08875853329426e4 into PR head commit ceeba8a6394430912abaf6de54497d2580cc431c
[2020-05-27T16:43:35.353Z]  > git config remote.origin.url git@github.com:elastic/apm-agent-java.git # timeout=10
[2020-05-27T16:43:35.362Z]  > git config --add remote.origin.fetch +refs/heads/*:refs/remotes/origin/* # timeout=10
[2020-05-27T16:43:35.370Z]  > git config remote.origin.url git@github.com:elastic/apm-agent-java.git # timeout=10
[2020-05-27T16:43:35.377Z]  > git rev-parse --verify HEAD # timeout=10
[2020-05-27T16:43:35.381Z] No valid HEAD. Skipping the resetting
[2020-05-27T16:43:35.381Z]  > git clean -fdx # timeout=10
[2020-05-27T16:43:35.391Z] Fetching upstream changes from git@github.com:elastic/apm-agent-java.git
[2020-05-27T16:43:35.391Z] using GIT_SSH to set credentials GitHub user @elasticmachine SSH key
[2020-05-27T16:43:35.395Z]  > git fetch --tags --progress --prune -- git@github.com:elastic/apm-agent-java.git +refs/pull/1207/head:refs/remotes/origin/PR-1207 +refs/heads/master:refs/remotes/origin/master # timeout=10
[2020-05-27T16:43:36.107Z]  > git config core.sparsecheckout # timeout=10
[2020-05-27T16:43:36.112Z]  > git checkout -f ceeba8a6394430912abaf6de54497d2580cc431c # timeout=15
[2020-05-27T16:43:36.262Z]  > git remote # timeout=10
[2020-05-27T16:43:36.270Z]  > git config --get remote.origin.url # timeout=10
[2020-05-27T16:43:36.305Z] Merge succeeded, producing ceeba8a6394430912abaf6de54497d2580cc431c
[2020-05-27T16:43:36.305Z] Checking out Revision ceeba8a6394430912abaf6de54497d2580cc431c (PR-1207)
[2020-05-27T16:43:36.578Z] Commit message: "lock jar file when writing to avoid multiple jvm override him"
[2020-05-27T16:43:36.578Z] Cleaning workspace
[2020-05-27T16:43:36.276Z] using GIT_SSH to set credentials GitHub user @elasticmachine SSH key
[2020-05-27T16:43:36.288Z]  > git merge 2d28d00626db9b41b28a2bab08875853329426e4 # timeout=10
[2020-05-27T16:43:36.298Z]  > git rev-parse HEAD^{commit} # timeout=10
[2020-05-27T16:43:36.306Z]  > git config core.sparsecheckout # timeout=10
[2020-05-27T16:43:36.314Z]  > git checkout -f ceeba8a6394430912abaf6de54497d2580cc431c # timeout=15
[2020-05-27T16:43:36.578Z]  > git rev-parse --verify HEAD # timeout=10
[2020-05-27T16:43:36.588Z] Resetting working tree
[2020-05-27T16:43:36.588Z]  > git reset --hard # timeout=10
[2020-05-27T16:43:36.823Z]  > git clean -fdx # timeout=10
[2020-05-27T16:43:37.856Z] Masking supported pattern matches of $GIT_USERNAME or $GIT_PASSWORD
[2020-05-27T16:43:38.463Z] + git fetch<EMAIL_ADDRESS>+refs/pull/*/head:refs/remotes/origin/pr/*
[2020-05-27T16:43:39.443Z] Archiving artifacts
[2020-05-27T16:43:40.129Z] + git rev-parse HEAD
[2020-05-27T16:43:40.480Z] + git rev-parse HEAD
[2020-05-27T16:43:40.783Z] + git rev-parse origin/pr/1207
[2020-05-27T16:43:40.823Z] [INFO] githubEnv: Found Git Build Cause: pr
[2020-05-27T16:43:41.084Z] Masking supported pattern matches of $GITHUB_TOKEN
[2020-05-27T16:43:41.949Z] [WARN] githubApiCall: The REST API call https://api.github.com/repos/elastic/apm-agent-java/pulls/1207/reviews return 0 elements
[2020-05-27T16:43:41.976Z] [INFO] githubPrCheckApproved: Title: lock jar file when writing to avoid multiple jvm override him - User: twillouer - Author Association: FIRST_TIME_CONTRIBUTOR
[2020-05-27T16:43:42.182Z] ERROR: githubPrCheckApproved: The PR is not allowed to run in the CI yet
[2020-05-27T16:43:42.182Z] ERROR: githubPrCheckApproved: The PR is not allowed to run in the CI yet. (Only users with write permissions can do so.)
[2020-05-27T16:43:42.213Z] [INFO] Let's stop build #2. The PR is not allowed to run in the CI yet
[2020-05-27T16:43:42.226Z] Sleeping for 5 sec
[2020-05-27T16:43:43.263Z] Stage "Build" skipped due to earlier failure(s)
[2020-05-27T16:43:43.337Z] Stage "Tests" skipped due to earlier failure(s)
[2020-05-27T16:43:43.391Z] Stage "Unit Tests" skipped due to earlier failure(s)
[2020-05-27T16:43:43.392Z] Stage "Smoke Tests 01" skipped due to earlier failure(s)
[2020-05-27T16:43:43.393Z] Stage "Smoke Tests 02" skipped due to earlier failure(s)
[2020-05-27T16:43:43.394Z] Stage "Benchmarks" skipped due to earlier failure(s)
[2020-05-27T16:43:43.394Z] Stage "Javadoc" skipped due to earlier failure(s)
[2020-05-27T16:43:43.450Z] Failed in branch Unit Tests
[2020-05-27T16:43:43.451Z] Failed in branch Smoke Tests 01
[2020-05-27T16:43:43.452Z] Failed in branch Smoke Tests 02
[2020-05-27T16:43:43.452Z] Failed in branch Benchmarks
[2020-05-27T16:43:43.453Z] Failed in branch Javadoc
[2020-05-27T16:43:43.507Z] Stage "Integration Tests" skipped due to earlier failure(s)
[2020-05-27T16:43:43.543Z] Stage "AfterRelease" skipped due to earlier failure(s)
[2020-05-27T16:43:43.559Z] Stage "AfterRelease" skipped due to earlier failure(s)
[2020-05-27T16:43:43.602Z] Stage "AfterRelease" skipped due to earlier failure(s)
[2020-05-27T16:43:44.079Z] Running on Jenkins in /var/lib/jenkins/workspace/_java_apm-agent-java-mbp_PR-1207@2
[2020-05-27T16:43:44.318Z] [INFO] getVaultSecret: Getting secrets
[2020-05-27T16:43:44.381Z] Masking supported pattern matches of $VAULT_ADDR or $VAULT_ROLE_ID or $VAULT_SECRET_ID
[2020-05-27T16:43:44.989Z] + chmod 755 generate-build-data.sh
[2020-05-27T16:43:44.989Z] + ./generate-build-data.sh https://apm-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/apm-agent-java/apm-agent-java-mbp/PR-1207/ https://apm-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/apm-agent-java/apm-agent-java-mbp/PR-1207/runs/2 ABORTED 181403
[2020-05-27T16:43:45.240Z] INFO: curl https://apm-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/apm-agent-java/apm-agent-java-mbp/PR-1207/runs/2/steps/?limit=10000 -o steps-info.json

Nice catch!
Could you apply the same changes to co.elastic.apm.agent.util.IOUtils#exportResourceToTemp?
This methods contains duplicated code because there's no good way to share code across the apm-agent-attach and other modules.

Your right !
Done !

I gave this some thought and I think there's an even better and more idiomatic way to guard against this. The problem currently is that checking file.exists() and writing to the file is a classic check-and-act race condition.
A better way is to use the FileChannel#open API to atomically create a new file if it does not exist already:
try (FileChannel fileChannel = FileChannel.open(path, CREATE_NEW, WRITE)) {
    // write to file
} catch (FileAlreadyExistsException ignore) {
}

Let me know if you need help with the details.

@felixbarny I only do the job for IOUtils, tell me if I'm wrong ?
I will report the solution in ElasticApmAttacher if your agree with this fix.
I'm not sure this is the best way to handle this

I think I have missed a key point in your implementation. The channel.lock() call has the big benefit that other JVMs that are concurrently trying to write to the file will wait until the JVM that acquired the lock first has fully written the file before proceeding. This is of course much better than having to manually sleep. Sorry for the confusion, your initial implementation was better. Just don't forget to also check for if (tempFile.length() == 0) in IOUtils

Codecov Report

Merging #1207 into master will decrease coverage by 0.05%.
The diff coverage is 47.05%.

@@             Coverage Diff              @@
##             master    #1207      +/-   ##
============================================
- Coverage     59.38%   59.32%   -0.06%
+ Complexity       86       83       -3
============================================
  Files           339      338       -1
  Lines         16847    15951     -896
  Branches       2468     2225     -243
============================================
- Hits          10004     9463     -541
+ Misses         6203     5840     -363
- Partials        640      648       +8

Impacted Files
Coverage Δ
Complexity Δ

...java/co/elastic/apm/attach/ElasticApmAttacher.java
18.18% <0.00%> (-0.74%)
3.00 <0.00> (ø)

...c/main/java/co/elastic/apm/agent/util/IOUtils.java
58.09% <80.00%> (+17.89%)
0.00 <0.00> (ø)

...ic/apm/agent/plugin/api/TracedInstrumentation.java
26.47% <0.00%> (-6.87%)
0.00% <0.00%> (ø%)

...a/co/elastic/apm/agent/report/ApmServerClient.java
83.48% <0.00%> (-5.58%)
0.00% <0.00%> (ø%)

...agent/plugin/api/ElasticApmApiInstrumentation.java
40.54% <0.00%> (-5.50%)
0.00% <0.00%> (ø%)

...lastic/apm/agent/impl/transaction/Transaction.java
81.02% <0.00%> (-5.16%)
0.00% <0.00%> (ø%)

.../plugin/api/CaptureTransactionInstrumentation.java
34.61% <0.00%> (-4.41%)
0.00% <0.00%> (ø%)

...apm/agent/quartz/job/JobTransactionNameAdvice.java
3.84% <0.00%> (-2.98%)
0.00% <0.00%> (ø%)

...ent/jaxws/JaxWsTransactionNameInstrumentation.java
70.58% <0.00%> (-2.75%)
0.00% <0.00%> (ø%)

...g/webmvc/SpringTransactionNameInstrumentation.java
42.50% <0.00%> (-2.67%)
0.00% <0.00%> (ø%)

... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2d28d00...87a7d60. Read the comment docs.


-w, --nowindow flags don't work

When using -w or --nowindow the expected behaviour is that a console is not to be spawned when launched from the gui, but it still does, it just minimizes the console
The minimizing is nice but doesn't work for my needs as I need it to start on startup with --loop, so I don't want the console window to stick around
Daemons on windows don't require a console window to be open at all times
I am testing it from GUI by creating a shortcut and in it's target adding the flags --loop and -w

If you need a Video of the bug, I'll be more than happy to record one!
Thanks!
@thibaultmeyer

Hello,
I'm not reproducing the problem. I created a shortcut and then edited the target to add "--loop --nowindow".  Double-click on the shortcut and the application starts in the background. The console only appears for a fraction of a second.

Hey! Never mind man, sorry to bother you, some other cheat program was interfering by hooking some function. (I have some drivers for uh um purposes, yk 😉 )

Hey man, sorry I closed the issue wrongly, see the attached to see what is the problem, thanks.
Catbox URL to Video

are there any logs that I can send too?

I've managed to reproduce the problem, but unfortunately I don't have an immediate solution to correct it in the code. It seems that the Windows API to hide a console doesn't work properly with PowerShell.
As a workaround, you can enable legacy mode for this shortcut (see picture below)

Damn :((
The problem is that I actually do not care about using shortcut, I just wanted to add a binwallpaper.exe --loop in the startup registry key so that it runs with my computer all the time, but that spawns a window :((


Live rendered view of document with markdown

While working on documenting APIs of a rust crate, I found that it would be nice to have a live rendered view of current editing function / struct documentation in a separate window in my editor.
I think it is not so hard to implement, it would be similar to how we implement Show Syntax Tree and could be possible to reuse some hover code for that.

I have even one more feature that I really miss from TypeScript. This is highlighting markdown syntax in doc comments:

Anyway, rendering live markdown preview is kinda doable, this just needs vscode API investigation.

What about full language support in markdown code blocks? Is there an issue for that? Granted, it may not necessarily be a rust-specific solution. See this intention:
https://github.com/pushqrdx/code-fences#planned

Agree with @mightyiam, but to stat with if we could get the md bits parsed so that it's not all showing up as comment.line.documentation.rust that would be great. Identifying headings would be a good start.


Static link to glibc

To avoid issues where a user using a pre-compiled binary with an outdated glibc

I think this may be what's happening here:
https://travis-ci.org/jugglinmike/jshint/jobs/70571313
Build runs without issue, but require('nodegit') throws an Error:
/home/travis/build/jugglinmike/jshint/node_modules/nodegit/lib/nodegit.js:13
    throw ex;
          ^
Error: /lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.17' not found (required by /home/travis/build/jugglinmike/jshint/node_modules/nodegit/build/Release/nodegit.node)
    at Error (native)
    at Module.load (module.js:355:32)
    at Function.Module._load (module.js:310:12)
    at Module.require (module.js:365:17)
    at require (module.js:384:17)
    at Object.<anonymous> (/home/travis/build/jugglinmike/jshint/node_modules/nodegit/lib/nodegit.js:8:12)
    at Module._compile (module.js:460:26)
    at Object.Module._extensions..js (module.js:478:10)
    at Module.load (module.js:355:32)
    at Function.Module._load (module.js:310:12)

Same error here, on Ubuntu 12.04.
Do you know how if I can distribute a package depending on nodegit that will work on Ubuntu 12.04 without requiring my users to update their glibc ?

@dorian-marchal you could probably adjust the LD_PATH and point to a precompiled glibc.

I'll try that, thanks

I'm hitting the same issue here: https://travis-ci.org/kimmobrunfeldt/git-hours/jobs/72436073

Does nodegit provide the precompiled GLIBC_2.17? I'm trying to get this fixed in Travis builds.

This may be of interest http://stackoverflow.com/questions/3214168/linking-statically-with-glibc-and-libstdc

This is a problem for me as well on Centos6

Someone can help me to solve it? I have the same problem in travis CI and I dont know how to I set the LD_PATH to fix this problem

The pre-compiled S3 binary did work for me on Node 5.x but not on the LTS 4.2.x. To support both I disabled S3, with BUILD_ONLY and speed up future builds by caching node_modules directory
Example .travis https://github.com/thisconnect/nodegit-kit/blob/b8349239823f32d2ed0c96ef5f41f37c99c352ea/.travis.yml
(you can remove the two git config --global ... configs)

With the latest versions, the glibc dependency has been lowered to not be any higher than is included in 12.04, the oldest ubuntu LTS, so this may not be an issue for most people going forward

How did you get to solve it?

We actually removed code dependent on c++11 and fixed our compiler requirements to work off clang referencing an older glibc

Well, I jave same issue, how can I get it working?

A new verson is going out right now (we just published) which should automatically push out new binaries without the issue. If for some reason you're still seeing it, updating your glibc works, although I don't know how youd do that in the container architecture

It's easy enough to upgrade your OS to get the right library to dynamically link against and the README documents this process, so closing this now.

Updating OS/glibc is not possible (allowed) when using enterprise linux.
Maybe you could link glibc static or depend on an older version?

We cannot depend on an older version since our core Node-interop dependency dictates what we're using today.
I investigated static linking, but was unable to get it working. If this is something that matters for enterprise Linux, do you think you'd be able to help us experiment with? We might be able to ship a static copy and link to it using rpath or LD_LIBRARY_PATH or w/e to try and resolve it.

@tbranyen I'd love to experiment w/ this as I'm in the same boat


rubocop: fix build

This PR fixes Rubocop issues introduced in https://github.com/dry-rb/dry-view/pull/153
In order to get a green build I had to add hamlit & hamlit-block version requirements as tests were failing for hamlit older than 2.16.0 and  hamlit-block older than 0.7.1

Thanks for taking care of this, @olegykz!
Would you actually mind splitting this work into two? A single PR with your rubocop fix would be fine (I'll merge regardless of tests), and then another PR that copies https://github.com/hanami/view/pull/212 to fix the hamlit dependency?
One both of those are in I'll cut a new release :)

@timriley sure, I'll do it

@timriley here you go - https://github.com/dry-rb/dry-view/pull/155

hm, it seems something has changed in rubocop rules, as PR above has a green build

@olegykz Yeah, that's odd! In this case I think we can probably just close this one for now, since main is good.
I'll look to ship a release in the next ~2 days :)

@timriley let's watch the build status, it may happen due to some inconsistency in CI between PR and master builds


MPMA issue with confirmed btc tx using Freewallet 0.9.29

looks like a user is having an issue with an MPMA send not showing up in the xcp database (using Mac OS and most recent version Freewallet Desktop (0.9.29)
Steps to reproduce the behavior

use Freewallet Desktop 0.9.29 on Mac OS
create an MPMA send. ex:

1N2Js4WPg9j64sNYPbo9cXT37Q5F6gJd5Y, GIVEKUDOS, 888, PEPE.CO 888
17dHymDAk2wkzQGRrggT4Pv1drj4Nf6GCL, GIVEKUDOS, 888, PEPE.CO 888
18CtfmVT1hH1vKstHm4TTD5HDMCvvB8nUd, GIVEKUDOS, 888, PEPE.CO 888
12iRwtafSCEjxeM63ALfvxQv2BGRdHCyPx, GIVEKUDOS, 888, PEPE.CO 888
1BVwbixQmHPWhwVgmuyQQsCXFfpWuiFaLD, GIVEKUDOS, 888, PEPE.CO 888
1BNjuv8wnUEJXdF1Bq1Y792t6t4rukWxJS, GIVEKUDOS, 888, PEPE.CO 888
1Tips9o1pgZjyNdsSg6LFuZXR7MfGGKfk, GIVEKUDOS, 888, PEPE.CO 888

Freewallet sees that info as valid
Send tx
Wait for btc confirmation
see tx info on various xcp block explorers:

https://www.xcp.io/tx/28bd1626a21d6a5ccae60dd9b44ad95580dba829114a6dfef81b4e60cafb4bde
https://xchain.io/tx/28bd1626a21d6a5ccae60dd9b44ad95580dba829114a6dfef81b4e60cafb4bde
https://www.xcp.dev/tx/28bd1626a21d6a5ccae60dd9b44ad95580dba829114a6dfef81b4e60cafb4bde
^ only explorer that shows some info related to xcp data

see tx is confirmed on btc side of things but not xcp side of things:

https://blockstream.info/tx/28bd1626a21d6a5ccae60dd9b44ad95580dba829114a6dfef81b4e60cafb4bde
https://mempool.space/tx/28bd1626a21d6a5ccae60dd9b44ad95580dba829114a6dfef81b4e60cafb4bde

Juan commented in the dev chat:
"You can see the hex of the transaction here, which was stored on the Counterparty DB:
https://www.xcp.dev/tx/28bd1626a21d6a5ccae60dd9b44ad95580dba829114a6dfef81b4e60cafb4bde
But there were no messages stored. And after further debug, no entries in the sends table either.
This is a bug in the protocol it seems, maybe is an invalid mpma send. There should at least be an insert of the invalid send (and its entry in the messages table).
The decoding of the hex for mpma transactions is not yet done in xcpdev, but it should be added and it would have been very helpful in a case like this."
Joe commented:
"or just a malformed message, its difficult to decode MPMA data manually"

On my DB, tx.data is empty

tx_index
tx_hash
block_index
block_hash
block_time
source
destination
btc_amount
fee
data
supported

2724764
28bd1626a21d6a5ccae60dd9b44ad95580dba829114a6dfef81b4e60cafb4bde
838333
00000000000000000000677f4778e411dcf0957b5c908caac44547e5b7201984
1712597424
1Cpx1CBqxd7ATUQCsiyav2wdXf5GHb6xpJ

0
33333

1

Closing until there are more reports of this issue


Add telegram

Codecov Report

Merging #59 (f8fa602) into master (9c3c5cf) will decrease coverage by 0.05%.
The diff coverage is 63.88%.

@@             Coverage Diff              @@
##             master      #59      +/-   ##
============================================
- Coverage     61.32%   61.27%   -0.06%
- Complexity      446      461      +15
============================================
  Files            84       85       +1
  Lines          1655     1720      +65
  Branches        191      200       +9
============================================
+ Hits           1015     1054      +39
- Misses          590      611      +21
- Partials         50       55       +5

Impacted Files
Coverage Δ

...eedu/address/logic/commands/person/AddCommand.java
100.00% <ø> (ø)

...in/java/seedu/address/logic/parser/ParserUtil.java
67.53% <0.00%> (-4.69%)
:arrow_down:

.../main/java/seedu/address/model/person/Address.java
84.61% <ø> (ø)

...rc/main/java/seedu/address/model/person/Email.java
84.61% <ø> (ø)

.../java/seedu/address/model/util/SampleDataUtil.java
20.00% <ø> (ø)

src/main/java/seedu/address/ui/PersonCard.java
0.00% <0.00%> (ø)

...address/logic/parser/person/EditCommandParser.java
81.25% <33.33%> (-5.42%)
:arrow_down:

...main/java/seedu/address/model/person/Telegram.java
69.23% <69.23%> (ø)

.../java/seedu/address/storage/JsonAdaptedPerson.java
88.33% <77.77%> (-2.06%)
:arrow_down:

src/main/java/seedu/address/logic/EditUtil.java
56.00% <83.33%> (+1.71%)
:arrow_up:

... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9c3c5cf...f8fa602. Read the comment docs.


Following the "Create a Windows Service installer" my installation failed

I tried to follow the tutorial for creating a Windows Service Installer but it fails when executing I think it's because the sc.exe create ".NET Joke Service" command has to be run in a console as Administrator, but I'm not sure, the error message don't give details.
I Tried run the command ".\App.WindowsService.exe /Install" as administrator and worked fine.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: e044209a-0802-07c0-7518-208967a3ef02
Version Independent ID: 83c4d805-1394-90b7-6def-cf809c33ae22
Content: Create a Windows Service installer - .NET
Content Source: docs/core/extensions/windows-service-with-installer.md
Product: dotnet-fundamentals
GitHub Login: @IEvangelist
Microsoft Alias: dapine

The error message in Portuguese
Should be something like: "There is a problem with this Windows Installer package. A program run as part of the installation did not exit as expected. Contact the support team or the package vendor."

I'm Running on a Windows 10 and the program is in .Net 7


add abbreviation, update short & full name for BA and BAV

@olinux ready for your review on the BA / BAV update (including instances)

@olinux can you have a look at this PR? I hope this solves some of the KG issues.

@olinux can you have a look at this PR? I hope this solves some of the KG Search issues.

I took this over. Looks good and, if this is the same issue from before Christmas, this should solve the KGS issues.
Just a question: The BrainAtlases and their corrsponding BrainAtlasVersions seem to have the same abbreviation, shortName and fullName. The only difference is the VersionIdentifier -Wouldn't it make sense to handle this similar to what we did for datasets (inheritance from BA if BAV fields are empty)?
Just an idea, if we don't want to do this (at all or just now), you can merged the PR as is :)

@UlrikeS91 hey thanks for having a look at this PR. For the inheritance: inheritance rules are implemented by the KG Editor, not openMINDS. In principle these fields are never empty, because the KGE is autofilling these fields. The inheritance is therefore currently not part of the openMINDS definition. For this reason I would like to keep these values explicitly stated for the openMINDS controlled instances.

@UlrikeS91 hey thanks for having a look at this PR. For the inheritance: inheritance rules are implemented by the KG Editor, not openMINDS. In principle these fields are never empty, because the KGE is autofilling these fields. The inheritance is therefore currently not part of the openMINDS definition. For this reason I would like to keep these values explicitly stated for the openMINDS controlled instances.

That makes sense :) I'll merge it then as is ;)


bump  go-gcloud from ancient 2015 version

https://github.com/docker/distribution/blob/afe29bb/go.mod#L53
because of it default token source doesn't work, at least when running in GKE with identity workload feature. Library tries to detect OnGCE presence with with http request made to http://metadata.google.internal like following (captured from strace):
"GET / HTTP/1.1\r\nHost: metadata.google.internal\r\nUser-Agent: gcloud-golang/0.1\r\nAccept-Encoding: gzip\r\n\r\n", 104)

which returns 403 due to missing Metadata-Flavor: Google in the request . Modern go SDK employs more strategies to detect GCE:
https://github.com/googleapis/google-cloud-go/blob/e948dc9416cdedc43b65a5c21a5438dcb786394c/compute/metadata/metadata.go#L153-L160

I see that latest master pull latest oauth2 which dosn't use  go-cloud anymore


Release and CI automation

Goals:

CI can build and sign artifacts
CI can publish artifacts to SVN and Nexus

SVN dev: https://dist.apache.org/repos/dist/dev/incubator/baremaps/
Nexus staging: https://repository.apache.org

CI triggers build, sign and publish on git tags
CI generate release candidate vote email and release announcement email
Reproducible published artifacts (i.e published artifacts with checksum can be reproduced by any machine with exactly the same checksum)
Automation can be executed by committers on their own machine with their own credentials or signing key.

Relates to: https://github.com/apache/incubator-baremaps/issues/492

[ ] SVN and Nexus technical baremaps credentials
[ ] GPG Signing key configured in incubator-baremaps repo as GPG_SECRET_KEY
[ ] Reproducible artifacts

References:

https://infra.apache.org/release-signing.html#automated-release-signing
https://issues.apache.org/jira/browse/INFRA-23996

I just logged an issue on INFRA to setup the secrets on github.
https://issues.apache.org/jira/browse/INFRA-25610
And drafted a PR for the automation of the release process.
https://github.com/apache/incubator-baremaps/pull/844


Add Custom PCI Vendor and Device ID Support

This commit allows the user to configure a custom GPU Vendor and Device PCI ID
This is useful for getting programs to behave similarly on different graphics cards.

We need to add this to readme/wiki


Naming convention update

remove old org instances
replace with new org instances

closing this one due to branch merging issues. New branch will be created


Spotlight Search Engine won't change from DuckDuckGo

iPhone 7 iOS 13.5 running Unc0ver
Tried changing to Google a couple times but now it's stuck on DuckDuckGo

Did you re-add whatever default browser you are using?

Closing due to inactivity


Create listener to open info dialog for when python interpreter path changes

Create listener to open info dialog for when python interpreter path changes
Haven't added the actual implementation for restarting server. Ryan is working on that now so will connect to it next PR when it's ready
Some additional context that Ankush and I discussed:
If user selects an invalid interpreter, that's fine because:

They AIconfig flow will be invalid and fail (upon restarting server), but we have checks to pester them to update their interpreter to the correct one via the installDependencies() flow (defined in https://github.com/lastmile-ai/aiconfig/pull/1307)

Test Plan
https://github.com/lastmile-ai/aiconfig/assets/151060367/b9219c15-5843-4bf7-888f-357b20faff6a

TODO: Add a followup to learn more to link to doc on why changing python interpreter needs to trigger refreshing active AIConfig files


slotEventOverlap custom rendering question.

slotEventOverlap

Determines if timed events in agenda view should visually overlap.

Boolean, default: true
When set to true (the default), events will overlap each other. At most half of each event will be obscured:

I'm needing to have a slot event overlap completely within another event.  For example, from 8am - 12pm, an event can be created that will identify what types of events can be booked into the slot.  When a user would book into the slot, the event would appear within the 'parent' slot.  Currently it overlaps, but only by 50% and the edges of the 'child' event stick out.  Is there any way to customize this to show inside completely?
I attempted to use background events, but I need to be able to put a description on the parent event to identify what can be booked there / what it's purpose is.  Currently it appears background events don't suppor this.  I also need the ability to create an event outside of this parent and render it without any overlapping.  Background events don't seem to have the ability to not overlap with normal events so I don't think this will work.
Can you provide some information that I might have missed in making this possible?  Any other ideas for accomplishing this?
Thanks

Please see http://fullcalendar.io/wiki/Support/ and close this issue. Thanks.


Composables with Modifier.zoomable() aren't drawn on first frame

This breaks static previews, though interactive ones work.
Maybe check for ZoomableContentLocation.SameAsLayoutBounds, and if present, fallback to ScaleFactor(1, 1) rather than ScaleFactor.Zero?

https://github.com/saket/telephoto/commit/7d3a13cd6815a09a6a62ad50bee3aeb15a991a26 fixes this partially by making layout previews work for Modifier.zoomable(). I tried to remove the 1 frame lag as well, but it is slightly involved and may not be worth the effort considering that placeholder images are already displayed without any frame delays.


How should the "many" training files be split?

Hi. In the readme you say that the training data should be split into many files.
Is it important how they are split?
Do they all have to contain the same number of tokens or sentences?
Thanks.

It's important to randomly split your sentences / paragraphs / etc across the training files in order to ensure training processes your data randomly.  They don't need to contain the same number of tokens but you will see reduced memory pressure if they are approximately equally sized.

Ok thanks. I did just split them all with 500,000 lines. With linux split command.


wcslib: 8.1 -> 8.2.1

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://repology.org/project/wcslib/versions.
meta.description for wcslib is: World Coordinate System library for astronomy
meta.homepage for wcslib is: https://www.atnf.csiro.au/people/mcalabre/WCS/
Updates performed

Version update

To inspect upstream changes
Impact

Checks done (click to expand)

built on NixOS
The tests defined in passthru.tests, if any, passed
found 8.2.1 with grep in /nix/store/z5hiyj8dzh5k6i1sdg37d0j3x69kw3iw-wcslib-8.2.1
found 8.2.1 in filename of file in /nix/store/z5hiyj8dzh5k6i1sdg37d0j3x69kw3iw-wcslib-8.2.1

Rebuild report (if merged into master) (click to expand)

5 total rebuild path(s)

5 package rebuild(s)

First fifty rebuilds by attrpath
gnuastro
kstars
siril
stellarsolver
wcslib

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/z5hiyj8dzh5k6i1sdg37d0j3x69kw3iw-wcslib-8.2.1 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A wcslib https://github.com/r-ryantm/nixpkgs/archive/2a049a71ade424a8684769e4306c307903cae704.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/2a049a71ade424a8684769e4306c307903cae704#wcslib

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/z5hiyj8dzh5k6i1sdg37d0j3x69kw3iw-wcslib-8.2.1
ls -la /nix/store/z5hiyj8dzh5k6i1sdg37d0j3x69kw3iw-wcslib-8.2.1/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

5 packages built:

gnuastro
kstars
siril
stellarsolver
wcslib

Maintainer pings
cc @hjones2199 for testing.

8.2.2 is out, please open a new PR.


Add cyclical learning rate schedulers

Migrating CyclicLR from keras-team/keras-contrib as discussed in https://github.com/keras-team/keras-contrib/issues/519.

@gabrieldemarmiesse & @seanpmorgan would love some feedback on implementation
@seanpmorgan is there any recommendations regarding tests? I plan on taking inspiration from tf core schedulers, does it seem ok to you?

@googlebot I signed it!

I'm surprised. Do you guys have a continuous integration service running for pull requests?

I'm surprised. Do you guys have a continuous integration service running for pull requests?

Seems that CI is triggered by adding the kokoro:force-run tag

Maybe some tests would help ensure that no bugs are introduced?

Of course! Wanted to check first that implementation I used seems ok.

@seanpmorgan Added the tests, ready for review

Thanks @RaphaelMeudec! Looks like there are some line too long lint errors. Could you run this to auto format the code
bash tools/run_docker.sh -c 'make code-format

@seanpmorgan This is weird, the code-format is not doing any change. Is there a difference between the code-format and sanity-check? I'll fix the errors tomorrow

@seanpmorgan This is weird, the code-format is not doing any change. Is there a difference between the code-format and sanity-check? I'll fix the errors tomorrow

yapf does not aggressively make the length of lines fit 80 characters so you should manually modify it in most of the time.

@WindQAQ Fixed the errors, should be good now

@seanpmorgan Updated to register_keras_serializable, could you rerun kokoro?

@seanpmorgan Alphabetized it and rebased on tensorflow/addons. You might want to re-run kokoro

Thanks a lot for the contribution @RaphaelMeudec  and thank you @seanpmorgan  for the review!


Update index.rst

i2c pins  P0.4  & P0.5  ruvvitag_hw Rev B8
https://github.com/ruuvi/ruuvitag_hw/blob/master/ruuvitag_revb8/ruuvitag_revb8_schematic.pdf

Not needed.


Add magic plugin for kotlin

Sorry guys, I have had a busy summer and have not got to this yet, iirc @Major- had some work on this started. I probably won't be able to get to this for a few months still. Does someone want to tackle the magic plugin?

I've got some local work, but we've decided to focus on merging kotlin-experiments (and leave magic for after that), unless it's as an external contribution.

That sounds good to me


Append /v2 to module so version 2 can be used as a go package

When trying to import ntfy as a library in another go application, it defaults to the last v1 tag. When trying to import a v2 tag, the following error is thrown<EMAIL_ADDRESS>invalid version: module contains a go.mod file, so module path must match major version ("heckel.io/ntfy/v2")
This change to the go.mod allows for importing (future) v2 tags.
https://github.com/golang/go/wiki/Modules#semantic-import-versioning

The more you know.

I had to change all of my own imports too. https://github.com/binwiederhier/ntfy/commit/22f48c5ad3ec77e9afa3b3865c581adbe315d39a

It's still not working, no idea why

I changed the HTML file on heckel.io/ntfy to this; no idea :shrug:
<!DOCTYPE html>

<meta http-equiv="Content-Type" content="text/html; charset=utf-8"/>
<meta name="go-import" content="heckel.io/ntfy/v2 git https://github.com/binwiederhier/ntfy">
<meta name="go-source" content="heckel.io/ntfy/v2 https://github.com/binwiederhier/ntfy https://github.com/binwiederhier/ntfy/tree/main{/dir} https://github.com/binwiederhier/ntfy/blob/main{/dir}/{file}#L{line}">
<meta http-equiv="refresh" content="0; url=https://github.com/binwiederhier/ntfy">

ntfy, redirecting to GitHub ...


Adding Constraint Grammar disambiguation

For several of these languages there are already disambiguation rules which remove most of the readings. Would it be possible somehow to add this into uralicNLP? I have no ideas about the technical problems which may be related to this, but it would make my life million times easier. This would demand sending more than one token at the time, but I assume this would be practical anyway? Thank you for fantastic work!

Done


Multiple agent scenario.

Will scenario 1 will work if i have multiple agents to accept the requests sent from user?
I tried this thing but it fails if 2 or more users are on the same channel, it is saying you are already connected to user. But if users are on two different channels it is working fine.
Please help me this.

Hi @SonuPriya21 did you find anything related to this? I started working on this and I am using MS Teams as a channel.


Unable to run "devspace use space" command in CircleCI build

What happened?
When I try running the "devspace use space [name of space]" in a CircleCI build, I get an error.  See below for my config.yml for CircleCI and the messages for successful devspace related commands (installing it and devspace login) and the error message for devspace use space

version: 2
jobs:
  build_and_deploy:
    docker:
      # specify the version you desire here
      - image: circleci/buildpack-deps:jessie

    steps:
      - checkout

      - run:
          name: put environment variables in secrets
          command: |
            POSTGRES_USER_ENCODED=$(echo $POSTGRES_USER | base64)
            POSTGRES_PASSWORD_ENCODED=$(echo $POSTGRES_PASSWORD | base64)
            REDIS_PASSWORD_ENCODED=$(echo $REDIS_PASSWORD | base64)
            JWT_SECRET_ENCODED=$(echo $JWT_SECRET | base64)
            jwt_secret_lines=$(echo $JWT_SECRET_ENCODED | tr " " "\n")
            sed -i "s/ENV-VAR-POSTGRES-USER/${POSTGRES_USER_ENCODED}/" ./k8s/secret.yaml
            sed -i "s/ENV-VAR-POSTGRES-PASSWORD/${POSTGRES_PASSWORD_ENCODED}/" ./k8s/secret.yaml
            sed -i "s/ENV-VAR-REDIS-PASSWORD/${REDIS_PASSWORD_ENCODED}/" ./k8s/secret.yaml
            for line in $jwt_secret_lines
            do
                sed -i "s/ENV-VAR-JWT-SECRET/${line}ENV-VAR-JWT-SECRET/" ./k8s/secret.yaml
            done
            sed -i "s/ENV-VAR-JWT-SECRET//" ./k8s/secret.yaml

      - run:
          name: install devspace
          command: |
            curl -s -L "https://github.com/devspace-cloud/devspace/releases/latest" |\
            sed -nE 's!.*"([^"]*devspace-linux-amd64)".*!https://github.com\1!p' | xargs -n 1 curl -L -o devspace && chmod +x devspace;
            sudo mv devspace /usr/local/bin;

      - run:
          name: devspace login
          command: devspace login --key ${DEVSPACE_CLOUD_ACCESS_KEY}

      - run:
          name: set up space to use
          command: devspace use space worldofchatting

      - run:
          name: deploy
          command: devspace deploy

  test:
    docker:
      # specify the version you desire here
      - image: circleci/buildpack-deps:jessie

    steps:
      - checkout
      - setup_remote_docker

      - run:
          name: build test image
          command: docker-compose build

      - run:
          name: test
          command: docker-compose run webserver npm run test

      - run:
          name: containers
          command: |
            docker container ls
            docker container ls -a

      - run:
          name: copy coverage file
          command: docker cp worldofchatting-webserver-test:/user/src/app/coverage-circleci ./coverage-circleci

      - run:
          name: check
          command: |
            pwd
            ls

      - store_artifacts:
          path: ./coverage-circleci

workflows:
  version: 2
  test_build_and_deploy:
    jobs:
      - test
      - build_and_deploy:
          requires:
            - test
          filters:
            branches:
              ignore: master

What did you expect to happen instead?
"devspace use space worldofchatting" to have run successfully, as it does when running it on my computer
How can we reproduce the bug? (as minimally and precisely as possible)

create a CircleCI project
create a devspace space
create a config.yml with installing devspace, logging in, and then running "devspace use space [name of space]"

CircleCI Docker container

base image using in config.yml: circleci/buildpack-deps:jessie (https://github.com/CircleCI-Public/circleci-dockerfiles/tree/master/buildpack-deps/images/jessie)

/kind bug

@slevine111 thanks for opening this issue! I will add a fix to this issue to the next release

@FabianKramm is the issue solved or did you reopen this b/c still working on it? thanks for the update

@FabianKramm ok sounds good. Thanks for the update

@slevine111 should be fixed in v4.2.0


Replace result.class with result.klass

result.class returns the class of the result object, but what you really want is the name of the test class, which is in result.klass.
Currently, all test reports end up in the "Minitest::Result" suite.
I guess there should be a question about whether this breaks compatibility with some earlier version of minitest, whether that matters, and what to do if it does.

Fixes #9
@shepmaster can we get this merged please?