feat: custom option of aider program

It may not be a typical scenario to modify the aider program name, but it helps users who don't have a system-wide aider installation. Or if one wants to route the traffic through some network proxy, they can abuse these options:
(setq
   aider-program "proxychains4"
   aider-args '("-q" "aider" other-arguments...))

Agree with this. Yes it is possible that aider program might be not in the PATH. Thanks for the change.


Is gRPC supported?

I am trying to setup a gRPC connection between client (running in the same cluster) and server. It is working with NGINX, but not with cloudflare-tunnel-ingress-controller.
This is the client application error:
error internal/queue_sender.go:92 Exporting failed. Dropping data. {"kind": "exporter", "data_type": "metrics", "name": "otlp/stackstate", "error": "not retryable error: Permanent error: rpc error: code = PermissionDenied desc = unexpected HTTP status code received from server: 403 (Forbidden); transport: received unexpected content-type \"text/html\"", "dropped_items": 35

Coudl you please look at this? Thanks

tldr; it does not support grpc by open-the-box, but some tuning might resolve it I think.
it seems there is an upstream issue about it: https://github.com/cloudflare/cloudflared/issues/491#issuecomment-1643233485
I did not try with it, maybe you could take a try and tell us could it works?
if it require any modification in this repo, I would be happy to help. Thanks!

Hi @STRRL
Thanks, I will look at it, but in a few weeks, I will be travelling the upcoming weeks. Could you be so kind to take a look at https://github.com/STRRL/cloudflare-tunnel-ingress-controller/issues/145?


bug: 🐛 Some bugs on the demo slides (https://slidesk.github.io/slidesk)

Is your feature request related to a problem? Please describe.
I think there are few issues on the demo slides (https://slidesk.github.io/slidesk).

The X in the left top corner does nothing (on FF)
The button on the right bottom does noting (on FF)
The FR version is in English
The EN version display a 404 when I choose it in the drop down list

Describe the solution you'd like
Fix the issues or document their usage.
Describe alternatives you've considered
N/A
Additional context
N/A

The X in the left top corner does nothing (on FF)
The button on the right bottom does noting (on FF)

=> It's normal, cause I use something available only on FF126 : https://caniuse.com/?search=popover


Feat: sentry and sentry_flutter null safety

:scroll: Description

:bulb: Motivation and Context

:green_heart: How did you test it?
:pencil: Checklist

[ ] I reviewed submitted code
[ ] I added tests to verify changes
[ ] I updated the docs if needed
[ ] All tests passing
[ ] No breaking changes

:crystal_ball: Next steps

Codecov Report

Merging #335 (b875e3b) into main (4a7d680) will decrease coverage by 5.66%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #335      +/-   ##
==========================================
- Coverage   86.64%   80.97%   -5.67%
==========================================
  Files          52        5      -47
  Lines        1759      226    -1533
==========================================
- Hits         1524      183    -1341
+ Misses        235       43     -192

Impacted Files
Coverage Δ

flutter/lib/src/sentry_flutter_options.dart
58.69% <100.00%> (ø)

dart/lib/src/transport/encode.dart

dart/lib/src/version.dart

dart/lib/src/protocol/sentry_level.dart

dart/lib/src/diagnostic_logger.dart

dart/lib/src/integration.dart

dart/lib/src/throwable_mechanism.dart

dart/lib/src/default_integrations.dart

dart/lib/src/platform_checker.dart

dart/lib/src/transport/noop_transport.dart

... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4a7d680...b875e3b. Read the comment docs.


Add maven exit codes + set nested entrypoint.sh files as executable

Thanks for the work thus far!
Managed to get it to work for my project, but hit a few snags while I was getting set up.

Pulled in the first PR from the original repo
Set nested entrypoint.sh files as executable (otherwise they don't run)

Hope these are helpful! (Once merged, I will delete my fork.)

Hello, thanks for the contribute and I'll merge it into the repository.


Althist name pools and whatnot

Take inspiration from the Ill Bethisad althist project to evolve semi-plausible althist languages, name pools etc.
See how to use this feature in ImperatorToCK3 to simulate modern evolution of languages that were already extinct by medieval times. Reason: CK3 tries to use the modern naming conventions for peoples and places (e.g. French Childéric instead of Frankish Hildirîk) and it would not feel right for I:R languages to keep a Latinized ancient feeling to them (the Belgae Sussus Amogus recorded by a Roman chronicler could be registered with a modern Belgian(?) form Soíososh Amuágosh/Susse Amoigue/Süß Amuag Zosos Aamoegos)
Stub of how to modernize name pools:

For Nuragic, apply Italian sound laws and Italian spellings
For Iberian, apply Spanish sound laws and Basque spellings
For Dalmatian, Albanian and Albanian
For Celto-Pannonian, Czech and Hungarian
For Celtiberian, Catalan and Spanish
For Belgae, Dutch and Dutch
For Gaulish, French and French
For Hittite group, look up plausible reconstructions rather than use Greek spellings

Outdated by use of name list assigning


Fails to parse quoted table keys that contain brackets

[nested."level[0]"]
x = 0

The example above raises the following exception:
Traceback (most recent call last):
  File "<pyshell#12>", line 1, in <module>
    toml.loads(_in)
  File "C:\Program Files (x86)\Python36-32\lib\site-packages\toml.py", line 307, in loads
    raise TomlDecodeError("Key group not on a line by itself.")
toml.TomlDecodeError: Key group not on a line by itself.

As far as I can tell, this is legal in the TOML specs and does not cause an issue with pytoml. toml correctly dumps the dict, but fails to load it.

Changing this line to rsplit instead of split worked for me.


how to convert .record file to rosbag .bag file

I have some .record data , now i want to test a program depends on ros, how can i convert .record file to .bag file?

Sorry, it seems that there is no such tool at the moment, we have to write one maybe. : )

same situation…do you get any solution now?

There is a python tool cyber_record can read cyber record, and then use rosbag to write a bag.
You need to implement the function to convert the message from cyber to ros messages yourself, it shouldn't be difficult
Closed due to inactivity. If the problem persists, pls feel free to reopen it or create a new one and refer to it.


add rbac and fixup broken sample

I'm giving this a try now

Got the three runs as expected, I hadn't made my ghe/Docker secrets yet so made those, reopened the pull-request, then got a green PIpelineRun.
Interestingly it's a success but it wasn't actually merged due to apparent bad credentials.
My logs
+ '[' pull_request = push ']'
+ '[' pull_request = pull_request ']'
+ git config --global --add hub.host github.ibm.com
+ git config --global user.name a-roberts
+ git config --global user.email<EMAIL_ADDRESS>+ cd git-source
+ export HUB_VERBOSE=true
+ HUB_VERBOSE=true
+ hub merge https://github.ibm.com/AROBERTS/gitops-example-dev/pull/1
$ git config --get-all hub.host
> GET https://github.ibm.com/api/v3/user
> Authorization: token [REDACTED]
> Accept: application/vnd.github.v3+json;charset=utf-8
< HTTP 401
{"message":"Bad credentials","documentation_url":"https://developer.github.com/enterprise/2.19/v3"}
> GET https://github.ibm.com/api/v3/repos/AROBERTS/gitops-example-dev/pulls/1
> Authorization: token
> Accept: application/vnd.github.v3+json;charset=utf-8
< HTTP 401
{"message":"Bad credentials","documentation_url":"https://developer.github.com/enterprise/2.19/v3"}
Error getting pull request: Unauthorized (HTTP 401)
Bad credentials
+ git push -u origin master
Everything up-to-date
Branch 'master' set up to track remote branch 'master' from 'origin'.
+ echo git push origin --delete AROBERTS-patch-1
git push origin --delete AROBERTS-patch-1

Of course, I was using my original github-secret which points to github.com. So I remade that secret pointing to GHE credentials, but the above should have failed I think (again this could be one for a follow-up issue).
With my good secret, the PipelineRun passes and the PR is merged, but weirdly still open...but no RBAC errors, over to you I think @dibbles? Some follow-up ideas not necessarily for you to do here and an oddity about not needing to include Tekton permissions, which may be due to our namespace usage.

I have also seen failed merge not failing pipeline - that is really another issue though.

I have also seen failed merge not failing pipeline (where I fogot to set the GHE server url) - that is really another issue though.

I agree, happy to get this in as it solves the crux of the problem nicely


Feature request: remove node-notifier dependency

Feature Request
Remove the node-notifier dependency, and fallback to showing a message in the terminal, or nothing at all.
Motivation
https://github.com/mikaelbr/node-notifier/issues/314
This has been open for a while now, it doesn't look like it will get any attention. node-notifier will modify a user's start menu (on Windows and on macOS it seems) to point a shortcut to the vendor directory in node_modules. It's unnecessary.
Also, I find the constant bell sound whenever I make the slightest change to a file very annoying.  I don't need to receive a notification to know that I've changed a file, I already knew that, and it fills up the notification list.
ts-node-dev is a fantastic idea, but I won't be using it more without some of these issues being resolved.

Just as a note: You can disable the notifications using ts-node-dev --no-notify ./index.ts


LoL actuator library failure

PROBLEM
When running github:///upm/master/examples/lol-example.cxx the Olimex LoL lights up but in a rather uncontrolled way. Even doing something simple like:
int main(int argc, char **argv)
{
sensor = new upm::LoL();
sensor->setPixel(1, 1, 1);
sensor->setPixel(1, 2, 1);
sensor->setPixel(1, 3, 1);
sensor->setPixel(1, 4, 1);
usleep(100000000);
}
...causes pixels to flash and turn off almost immediately and then repeat (even though there is no loop.) Some of the pixel flashes are in a pyramid form (matching the charliplexing algorithm.)
 I'm booting to Devkit of course.
uname -a
Linux hostname 3.8.7-yocto-standard #1 Wed Sep 3 10:41:56 BST 2014 i586 GNU/Linux
#cat /etc/opkg/mraa-upm.conf
src mraa-upm http://iotdk.intel.com/repos/1.1/intelgalactic
opkg list | grep -i lol
opkg list | grep -i upm
upm - 0.1.9 - upm built using CMake
Source: https://github.com/intel-iot-devkit/upm
Description: upm built using CMake
Installed-Time:<PHONE_NUMBER>
find /lib/ -name 'lol'
find /lib32/ -name 'lol'
find /usr/lib/ -name 'lol'
/usr/lib/node_modules/jsupm_lol
/usr/lib/node_modules/jsupm_lol/jsupm_lol.node
/usr/lib/libupm-lol.so
/usr/lib/libupm-lol.so.0
/usr/lib/python2.7/site-packages/pyupm_lol.py
/usr/lib/python2.7/site-packages/_pyupm_lol.so
/usr/lib/libupm-lol.so.0.1.9
/usr/lib/pkgconfig/upm-lol.pc
QUESTIONS
What do I need to change to properly control the LoL shield? Build a new libupm-lol from source? Which sources are working?

See issue #11. The problem is that the GPIO pins on the board cannot be switched fast enough as required by the Charlieplexing algorithm to work properly. The LoL Shield has 14 pins to drive the LEDs so if you want a refresh rate of 50Hz you'll need to write the pins at 14 x 50 = 700 Hz. The GPIO pins will do about 230 Hz as listed in the Galileo F.A.Q. (https://communities.intel.com/docs/DOC-22543 under Building).
Won't fix as this is a hardware issue, besides, the LoL Shield has been discontinued.

What about Galileo Gen2 boards, and is it true that libupm-lol works as it should on them? I heard that libupm-lol on Gen2 causes the GPIO kernel driver to deadlock because of an incorrect locking implementation, so my next question is 'where is the source code for this incorrect locking implementation?' Is it in libupm-lol, libupm, libmraa, the Linux kernel, or some other component?
...or is libupm-lol working correctly on Galileo Gen2 boards?

It would be hard to pinpoint the exact reason causing the kernel freeze, and from my understanding it can happen quite often when bit banging the GPIO pins. Even external interference can trigger this thus it's not necessarily a specific line of code. Theoretically though, UPM shouldn't have to lock anything.
To answer your other question, the shield will not work correctly on any arduino board that doesn't meet the speed requirement I listed above.


net/udp: add option WithMulticastInterfaceError

This is a really nice way to "rescue" the errors from the inner loop.


Make Segment Compile On Windows

Adjust the Segment codebase to be buildable on Windows.

Current dependencies on/for this PR:

develop

PR #7   👈

This stack of pull requests is managed by Graphite.

@compnerd when I test this PR in CI and on my local I see the same test failures (yay consistency), but the errors that I see if I turn on additional logging locally seem to be focused around libcurl and ssl, is this possibly just an issue with this toolchain build?
Test Case 'FlushPolicyTests.testIntervalBasedFlushPolicy' started at 2023-11-28 14:39:54.022
noneCleaned up 0 non-running uploads.
noneUploads in-progress: 0
noneProcessing Batch:
0-segment-events.temp
noneError uploading request Protocol "https" not supported or disabled in libcurl.
errorAn internal error occurred: networkUnknown(Error Domain=NSURLErrorDomain Code=-1002 "(null)")
noneProcessed: 0-segment-events.temp
noneCleaned up 0 non-running uploads.
noneCleaned up 1 non-running uploads.
noneUploads in-progress: 0
noneProcessing Batch:
0-segment-events.temp
noneError uploading request Protocol "https" not supported or disabled in libcurl.
errorAn internal error occurred: networkUnknown(Error Domain=NSURLErrorDomain Code=-1002 "(null)")
noneProcessed: 0-segment-events.temp
noneCleaned up 0 non-running uploads.

libcurl shouldn't be exposed - that is indirectly only accessible through FoundationNetworking.  We do disable SSL as we use WinSSL so that the system configuration is made available.

@brianmichel and I paired a bit on this.  This is a regression since 5.9.1.  There is a fix in flight for this.

@brianmichel and I paired a bit on this. This is a regression since 5.9.1. There is a fix in flight for this.

Link to the fix in question, https://github.com/apple/swift/pull/70077

@compnerd looks like the Swift PR merged! Do you happen to know which snapshot it might start appearing in so I can adjust CI on this PR?

@brianmichel since you are using thebrowsercompany/swift-build: 20231129.2

@compnerd @darinf I believe this is ready for review. There are two tests that seems pretty flaky around storage, but I don't think those should hold us back on merging this personally.
@compnerd the testPurgeStorage uses the purge functions on the SDK to basically just remove files on disk. I know we've seen other issues with file manipulation and foundation, could this just be another bug?

@compnerd the testPurgeStorage uses the purge functions on the SDK to basically just remove files on disk. I know we've seen other issues with file manipulation and foundation, could this just be another bug?

Plausible!  I wouldn't count out any bugs in Foundation.  Would be good to understand the exact usage and make sure that it isn't that case.

Merge activity

Dec 4, 5:13 PM: @brianmichel started a stack merge that includes this pull request via Graphite.


Moved launcher.py into the main psij directory.

Fixes #131.

I don't like having two modules/packages with such similar names at the same level: psij.launchers and psij.launcher. I just think it gets confusing. Couldn't we keep the launcher class in psij.launchers.launcher.Launcher but export it as psij.Launcher?

Would it make sense to rename launcher.py and Launcher to job_launcher.py and JobLauncher, respectively? I mean the point here was to have some symmetry with executors.

Would it make sense to rename launcher.py and Launcher to job_launcher.py and JobLauncher, respectively? I mean the point here was to have some symmetry with executors.

I think just renaming the module is fine, renaming the class is overkill.


Fix 404 Link

The link was pointing to a file, that moved. The new link should point to the correct file.

Thanks!


New project layout

This PR will finally move our project structure to be more 'vanilla' and remove cross symlinking the shared code.
tldr; desktop and react-native folders have been moved under shared (we can change this further later). We now share a single package.json
Original PR here: https://github.com/keybase/client/pull/4946
Split into 4 different sections:

[x] https://github.com/keybase/client/pull/5236/commits/609a0d7a5406272613b53fb7aec963ec9b5e86c3 Most of the files are simple moves / renames. Some flowissues go away as flow was confused by the symlinks
[x] https://github.com/keybase/client/pull/5236/commits/a1bdf7374e01672d929601b57ebac8729a5233a2 Updating Jenkins / babel / webpack. A lot of the webpack funkiness is now gone. Babel is driven by a BABEL_ENV that package.json handles which pulls in different presets for RN
[x] https://github.com/keybase/client/pull/5236/commits/acc17502c0b190e8ab10be5c75fd0a3d347863ab The electron packaging script had to be touched a bunch to make it work with the different paths
[x] https://github.com/keybase/client/pull/5236/commits/ddfd76b33dca01ef7dd718a4e2d76be0980839dc Fixes the common input components flexbox issues in RN. In the process of making this work I had to update RN and it now gives you a redbox when you have the flexbox issues instead of just rendering it in a funky way

Before this rolls out (if possible)

[ ] Test electron prod builds on linux
[ ] Test electron prod builds on windows
[ ] Test electron prod builds on osx
[ ] Testflight build of ios
[ ] Test build of android

@keybase/react-hackers this is ready to look at. This review is large enough that I'd advocate for at least 2 thumbs thanks!

Unclear why the tests are failing. Literally the same code as the other pr

@keybase/react-hackers bump

visdiff works (based on testing a branch off of a branch using this PR: https://github.com/keybase/client/pull/5267)

@cjb please TAL

@chrisnojima LGTM


[Guidelines]: Improve documentation of accidentals

The (domain-specific) use of accidentals is not very well documented in the guidelines. This includes questions about when accid, accid.ges or other attribute variants are appropriate or necessary.
Guidelines section <IP_ADDRESS>. Accidentals, Articulation Symbols, ... says nothing about domain specific use of accid.
Section 1.2.1 Musical Domains informs:

Very often, MEI prioritizes the visual domain over the gestural domain by (partly) conflating the logical and the visual domains. For example, MEI utilizes the @pname (pitch name) attribute on notes to capture the written pitch of a note, whereas the sounding pitch may be described with the @pname.ges attribute. Here, the logical and visual domains go without a special indication, whereas the gestural domain is identified by a special suffix

Some use cases:

In section <IP_ADDRESS>, there is an example of Sergei Rachmaninoff’s Prelude in C-sharp minor, Op. 3, No. 2, opening with a c-sharp minor chord in both hands, employing the following encoding for the chord notes:

    <note oct="3" pname="c" accid.ges="s" />
    <note oct="3" pname="e" />
    <note oct="3" pname="g" accid.ges="s" />
    <note oct="4" pname="c" accid.ges="s" />

From the logical perspective, all of these accidentals are sharps, but accid.ges seems to be needed, since there are no visual accidentals with this chord (pitch inflection is given via key signature).

Given two notes within a measure/staff/layer, that both are connected by a tie and have the same accidental, let's say "sharp":

<note dur="8" oct="4" pname="f" stem.dir="up" accid="s" tie="i"/>
<note dur="4" oct="4" pname="f" stem.dir="up" accid="s" tie="t"/>

From a logical perspective, both notes are f sharp, although by most known setting rules, the second accidental would not be repeated in printed music. However, while rendering the above snippet, the second accidental will not be hidden. Instead, one would need to apply accid.ges instead of accid to the second note, to have no accidental repeated.
It would be very helpful to have some dedicated explanation in the guidelines, when (and why) accid.ges has to be applied, and when accid has to be read as accid.vis. (Also, the role of accid.log or accid.vis could be clarified).
I am quite aware that there are lots of other attributes for which the same question applies. accid seems to be a good starting point, because it is quite close to the very basic note element, and very beginners with MEI (CMN) are soon confronted with the somehow unexpected/counterintuitive behaviour described above.
Finally, one could think of another tutorial about these aspects of accidentals.

Related issue and comprehensive discussion: https://github.com/music-encoding/music-encoding/issues/318

This has been a long-running problem -- when to encode the accidental, and how it is displayed. When working through the rules in the Sibelius to MEI plugin I tried to condense my understanding here:
https://github.com/music-encoding/sibmei/blob/e9dab0e48bf580d6169ab58eb60bc943bd1af992/src/ExportConverters.mss#L329-L333
The function to determine whether an accidential is visible or not is probably one of the most complicated functions in the plugin, at 136 lines of code! The result of this function is simply true or false on whether the accidental is visible for any given note. This function looks at the given key signature, whether there are any preceding notes in the same measure with a visible accidental, and also whether that has been cancelled (e.g., a sharp-natural-sharp progression).
https://github.com/music-encoding/sibmei/blob/e9dab0e48bf580d6169ab58eb60bc943bd1af992/src/ExportConverters.mss#L404-L540
Perhaps we need an @accid.visible on <note>, and @visible on <accid>? Then all accidentals would get @accid, and the visibility could be controlled separately. It would then be up to displaying systems to determine how to handle the visibility of accidentals that do not have a visible attribute by default. (i.e., whether @accid.visible defaults to 'false' or 'true').

Thanks for the additional information and links. Your condensation of the issue is that kind of easy-to-comprehend and -to-remember information that we should have somewhere mentioned in the Guidelines.
If accidentals are audible, but not visible, you need to use @accid.ges
If accidentals are both audible and visible, you can use @accid

So in the first case, @accid.ges corresponds to @accid.log, but not @accid.vis or @accid.
In the second case, @accid corresponds to @accid.ges and @accid.vis, but not necessarily to @accid.log as shown in the use cases above.
Your hasVisibleAccidental function is an awesome formalization of human reading processes with regard to accidentals, thanks for the pointer!

The handling of accidentals in sibmei is truly impressive and it formed my understandig a lot. @musicEnfanthen 's condensation seems very approriate to be somewhere in the Guidelines.
This leaves only one question:
Will this kind of explanation only be added in relation to accidentals or should the "visible and audible vs audible but not visible" concept be added to the section about musical domains?

The encoding of accidentals are one of the most problematic points in MEI, in my opinion. The documentation for <accid> says:

Records a temporary alteration to the pitch of a note.

And the documentation for @accid says:

Attributes for capturing momentary pitch inflection.

@accid.ges is similar:

Attributes for capturing momentary pitch inflection in the gestural domain.

This suggests that encoding accidentals is only used when they differ from the pitch in the key signature. ("Momentary/temporary pitch inflection/alteration") But this is completely not how it's used; the Rachmaninoff example is a good one, where the first c in the chord is encoded as
<note oct="3" pname="c" accid.ges="s" />
So even the the C# is in the key signature, the standard practice is to encode the alteration at all times through @accid or @accid.ges. I think the original idea was that it would be encoded as
<note oct="3" pname="c" />
and the sharp would be inferred from the key signature, but (IMO) this leads to all sorts of problems. So it's better to encode the 'absolute' pitch (that is, the letter name and alterations) on every note, so that we're not reliant on identifying the pitches in a key signature.
So it's all a bit of a mess.
I've argued this issue several ways over the years, so I am at least consistent in my inconsistency. But looking at this problem right now, the gestural / logical divide for identifying when an accidental is visible or invisible is not sufficient, particularly because the accid element and attribute is no longer used for temporary alterations but is now used for qualifying the encoded pitch name all the time.
In other words, I think we have two choices:

We change @pname to accept alterations; C# would be @pname="cs", since that is, fundamentally, the pitch name. Then @accid goes back to identifying any accidentals (but it's hard to see how this would work -- maybe @accid would become true|false to indicate a visible accidental?). This is a pretty big change, and not one I would really support, but the clarification that is gives is that the pitch name for the example in the Rachmaninoff is not C, it is fundamentally C#.
We formalize the function of @accid to encode the alterations to the base pitch name at all times. @pname="c", @accid="s". This is effectively what we are doing now, so the only change is that the documentation would need to be updated to reflect this change in practice.

Then the question becomes how to show or hide the actual symbols. As I mentioned above, this means we would need @accid.visible or @visible on <accid> to determine whether the accidental is shown or not.
Then the role of @accid.ges would become much less prominent -- it might be used to encode ficta, for example.
Then the Rachmaninoff example might look something like this:
<layer>
  <chord xml:id="ex-1877520550" dur="2" stem.dir="up">
    <artic artic="acc" place="above" />
    <note oct="3" pname="c" accid="s" />
    <note oct="3" pname="e" />
    <note oct="3" pname="g" accid="s" />
    <note oct="4" pname="c" accid="s" />
  </chord>
  <chord xml:id="ex-1072408883" dur="4" stem.dir="up">
    <artic artic="acc" place="above" />
    <note oct="3" pname="a">
      <accid accid="n" visible="true" />
    </note>
    <note oct="4" pname="a">
      <accid accid="n" visible="true" />
    </note>
  </chord>
  <chord xml:id="ex-0929208104" dur="4" stem.dir="up">
    <artic artic="acc" place="above" />
    <note oct="3" pname="g" accid="s" />
    <note oct="4" pname="g" accid="s" />
  </chord>
</layer>

To make it even clearer, the third chord on the top line might look something like:
<chord dur="8">
  <note pname="d" accid="s" />
  <note pname="f" accid="xs" accid.visible="true" />
  <note pname="a" accid="s" accid.visible="true" />
  <note pname="d" accid="s" />
</chord>

(Looking at this, the naturals for the a are probably because of the sharp here, so you could also include things like @func="caution" on the <accid>)

Regarding more exotic accidentals like data.ACCIDENTAL.aeu I would personally prefer version 2, just because these accidentals are not the end of the road when opening up for more non-european repertoires. It seems kind of frightening to me having this handled within @pname.
I am wondering about two things right now:

What would then be the role of @accid.ges? Would it explicitly be limited to audible variations, where "performer actually 'expresses' (acoustically instantiates) the music" (see 1.2.1) -- a colleague recently pointed me on the beauty of the phrase "acoustically insantiates"...
What implications would this have on mensural music? Accidentals are usually encoded independent from notes, at least there used to be some not well documented convention as the written accidentals do possess some kind of independency as they are not always refering only to the directly following note.

@accid.ges could be used for ficta, for example -- a performed, but not explicitly written, note. But like I said @accid.ges would get a much less prominent role; it would only be used in very specific circumstances.

Sounds fine to me.

Another related discussion https://github.com/rism-digital/verovio/issues/974 (Sorry if it was already listed here)


Add rendering for Mary multi-asset Values

LGTM so far. Is the wiring in the query going to be in this PR or a separate one?

I'm going to do it a part of this PR.

bors r+


Create Simple_Edge_Discovery.yaml

First commit of 5GFF's 'Simple Edge Discovery' API. This is a easy-to-implement API that asnswers a very important question for the developer: "where is the closest MEC platform to my customer's UE?" Once the developer knows this, they can use their prior knowledge of which MEC platforms they have deployed in to connect the UE client application to the closest MEC server.
The 'full' 5GFF Edge Discovery API will be contributed soon, and covers a richer lifecycle. The 'full' API is a superset of the 'simple' API, allowing for an easy upgrade path.
(Commited on behalf of 5GFF by Kevin Smith)

(closed and will resubmit as a branch following recent guidelines)


feat: add prixa tech

What kind of change does this PR introduce?

[ ] Bug Fix
[ ] Documentation change
[x] Added new company
[ ] Other(s)

Why was this change needed?

Other information

@thenishantsapkota @Saphall please have a look, I did all changes as per the requests.

Thank you for your contributions @devkishor8007
:partying_face:
Join our Discord to claim your contributors role (if you haven't already) and stay connected with us.
Cheers!


Website goes blank when clicking React button

Summary of the bug
When clicking "React" button in top navigation component example for "With React Router (using slots)", the whole page goes blank
🪜 How to reproduce
Tell us the steps to reproduce the problem:

Go to page: https://design.sis.gov.uk/components/top-navigation/code
Scroll down to "With React Router (using slots)" under "Variants"
Click on: React (button shown in red below)

Whole page goes blank

📸 Screenshots or code

Chrome console

🖥 📱 Device

Type: Desktop
Device: MacBook
OS version: macOS 15
Browser version: Tested on both Chrome (v129.0.6668.91) and Firefox (v131.0.3)

🧐 Expected behaviour
For the page not to have gone blank
📝 Acceptance Criteria
If relevant, describe in full detail the different interactions and edge cases that the component or patterns needs to fulfil.
Given
When
Then
Additional info
Edit: This issue also occurs with the "Conditional tabs" variant demo

Any examples that only have the React option have this error


Change default OCP 4.12 istio-cni chart directory

Please provide a description of this PR:
Fixes https://github.com/istio/istio/issues/42055

@jacob-delgado: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

release-notes_istio
65fac830d10c750553b9494ffd16148608da4828
link
true
/test release-notes

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

I'd like to get a RedHat member to approve of this change before it gets merged.

@jacob-delgado: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

release-notes_istio
b5179d2eb13683f7ecd25ef9ebba5a1ae0f40758
link
true
/test release-notes

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jacob-delgado: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

release-notes_istio
b5179d2eb13683f7ecd25ef9ebba5a1ae0f40758
link
true
/test release-notes

lint_istio
b5179d2eb13683f7ecd25ef9ebba5a1ae0f40758
link
true
/test lint

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jacob-delgado: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

lint_istio
b5179d2eb13683f7ecd25ef9ebba5a1ae0f40758
link
true
/test lint

release-notes_istio
bcf2641f02e752d721035fecc9fd62fda90ef7cc
link
true
/test release-notes

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

We are looking into whether or not CNI being removed, then re-installed into a different namespace will cause issues. I don't believe it will, but with things like revision labels there may be complications. In-place upgrades appear to work, but we need to do more testing.

Pods that start during that will not have proper iptables I think
On Mon, Nov 21, 2022 at 10:11 AM jacob-delgado @.***>
wrote:

We are looking into whether or not CNI being removed, then re-installed
into a different namespace will cause issues. I don't believe it will, but
with things like revision labels there may be complications. In-place
upgrades appear to work, but we need to do more testing.
—
Reply to this email directly, view it on GitHub
https://github.com/istio/istio/pull/42093#issuecomment-1322461981, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AAEYGXJ3F7K7WEHVUZ54ZTTWJO3MHANCNFSM6AAAAAASG36CNQ
.
You are receiving this because your review was requested.Message ID:
@.***>

Resolve in a later OCP 1.12 rc


A new version is available while the latest version is installed

Describe the problem
I just downloaded the 0.9.3 Self contained - user and after installing and opening Bravo, it immediately prompts for an update.

But following that link still ends up at the same version: https://github.com/sql-bi/Bravo/releases.
Bravo version
0.9.8139.22766
Tabular model
Power BI Desktop, import mode
Power BI
N/A
Steps to reproduce the behavior

Download the latest version: https://github.com/sql-bi/Bravo/releases/download/v0.9.3/Bravo.0.9.3.x64-userinstaller.msi
Install it.
Open it.
It prompts with a "New version available".

Additional context
No response
Screenshots
No response
Anything else ?
No response

You are right, we have just released version 0.9.4. The notification of the new version on GitHub takes a few minutes compared to the notification shown by the application, which is immediate.


[#1427] Order of Gravitino nullability and type columns

What changes were proposed in this pull request?
Order of Gravitino nullability and type columns
Why are the changes needed?
For better UI
Does this PR introduce any user-facing change?
Changes order of table columns
How was this patch tested?
N/A.

Please review and suggest changes if any !

Hi @hiirrxnn , thank you for your contribution.
I think you can copy another branch based on the latest main branch to make the corresponding changes, because I see that there are still quite a few commits behind the main branch on the branch.
Example:
git checkout main
git pull upstream main
git checkout -b fix-1427

# change your code and submit the PR

Accidentally merged two issues I'm working on , #1427 and #1417 . Should i delete this PR and start over as this has become overly complicated.

Please review!

Please review!

My suggestion is to open a new PR, it seems like these tests are looks hard to pass.


Fix theme on godot4 branch

I would like to try helping with the project. Could you add some details? Do you mean project visually looks different on this branch and the task is to make it look close to currently released version?

Yes here's the Godot 3 version:

And here's the Godot 4 version:

Doesn't necessarily have to look exactly the same, but the news are lacking the light background. Same thing for the installed version list. It negatively impacts readability.
There's also a PR adding a dark theme that needs to be forward ported, though that dark theme could be improved a bit first

Still work in progress, but those are current results. Please let me know if I'm taking too much liberty with changing the look of some of controls.

Not at all. I think they look great!
On Sat, May 4, 2024, 09:14 Kregap @.***> wrote:

Still work in progress, but those are current results. Please let me know
if I'm taking too much liberty with changing the look of some of controls.
Godot_v4.2.2-stable_win64_qpP3l0J1aa.png (view on web)
https://github.com/noidexe/godot-version-manager/assets/15647621/34fc68ba-a2af-467b-b2f1-9d1bae237a6d
Godot_v4.2.2-stable_win64_7wv5Yb7X5X.png (view on web)
https://github.com/noidexe/godot-version-manager/assets/15647621/a7267503-3de7-474d-a92e-606ab33d7c3a
—
Reply to this email directly, view it on GitHub
https://github.com/noidexe/godot-version-manager/issues/45#issuecomment-2094143213,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAEAT3OO4KCAFP7DXKBM42LZATGJ7AVCNFSM6AAAAABCZNS7OGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAOJUGE2DGMRRGM
.
You are receiving this because you authored the thread.Message ID:
@.***>

You can find my suggested changes in #53.

Fixed by #53


no tags is returned if one does not specify ->type

Package
filament/spatie-tags-plugin
Package Version
v2.5.20
Laravel Version
v8.75
Livewire Version
v2.8.2
PHP Version
v8.0.13
Bug description
When using the tag field without a type, the wrong result is returned
Forms\Components\SpatieTagsInput::make('tag_with_type')->type('type'),

the data that is returned is something like this:
{"4":{"id":393,"name":{"en":"type"},"slug":{"en":"type"},"type":"type","order_column":393,"created_at":"2021-12-14T13:57:25.000000Z","updated_at":"2021-12-14T13:57:25.000000Z","pivot":{"taggable_id":1,"tag_id":393,"taggable_type":"App\\Models\\Recipe"}}}

Forms\Components\SpatieTagsInput::make('tag_with_no_tag'),

the data that is returned is something like this:
[{"id":2,"name":{"en":"Soup"},"slug":{"en":"soup"},"type":null,"order_column":2,"created_at":"2021-12-14T12:42:08.000000Z","updated_at":"2021-12-14T12:42:08.000000Z","pivot":{"taggable_id":1,"tag_id":2,"taggable_type":"App\\Models\\Recipe"}},{"id":387,"name":{"en":"tag with type"},"slug":{"en":"tag-with-type"},"type":"tagstype","order_column":387,"created_at":"2021-12-14T12:47:34.000000Z","updated_at":"2021-12-14T12:47:34.000000Z","pivot":{"taggable_id":1,"tag_id":387,"taggable_type":"App\\Models\\Recipe"}},{"id":388,"name":{"en":"tag with type"},"slug":{"en":"tag-with-type"},"type":null,"order_column":388,"created_at":"2021-12-14T12:47:34.000000Z","updated_at":"2021-12-14T12:47:34.000000Z","pivot":{"taggable_id":1,"tag_id":388,"taggable_type":"App\\Models\\Recipe"}},{"id":392,"name":{"en":"key"},"slug":{"en":"key"},"type":"keywords","order_column":392,"created_at":"2021-12-14T13:48:26.000000Z","updated_at":"2021-12-14T13:48:26.000000Z","pivot":{"taggable_id":1,"tag_id":392,"taggable_type":"App\\Models\\Recipe"}},{"id":393,"name":{"en":"type"},"slug":{"en":"type"},"type":"type","order_column":393,"created_at":"2021-12-14T13:57:25.000000Z","updated_at":"2021-12-14T13:57:25.000000Z","pivot":{"taggable_id":1,"tag_id":393,"taggable_type":"App\\Models\\Recipe"}},{"id":394,"name":{"en":"notype"},"slug":{"en":"notype"},"type":null,"order_column":394,"created_at":"2021-12-14T13:57:25.000000Z","updated_at":"2021-12-14T13:57:25.000000Z","pivot":{"taggable_id":1,"tag_id":394,"taggable_type":"App\\Models\\Recipe"}},{"id":395,"name":{"en":"category"},"slug":{"en":"category"},"type":"category","order_column":395,"created_at":"2021-12-14T13:57:25.000000Z","updated_at":"2021-12-14T13:57:25.000000Z","pivot":{"taggable_id":1,"tag_id":395,"taggable_type":"App\\Models\\Recipe"}},{"id":396,"name":{"en":"cusine"},"slug":{"en":"cusine"},"type":"cusine","order_column":396,"created_at":"2021-12-14T13:57:25.000000Z","updated_at":"2021-12-14T13:57:25.000000Z","pivot":{"taggable_id":1,"tag_id":396,"taggable_type":"App\\Models\\Recipe"}}]

Different data is return, but it is because the incorrect method is called
on line 24 in SpatieTagsInput you have this:
$tags = $model->tagsWithType($type);

which is correct
on line 26 you have this:
$tags = $model->tags;

I think that the call on line 26 should be
$tags = $model->tagsWithType();

as that will give you all the tags with no type
$tags = $model->tags;

will return all tags regardles if they have a type or not and the result is different and therefor the line:
$component->state($tags->pluck('name'));

will not return the correct result when tags with no type is requested
Steps to reproduce
have a model with tags
add a few tags with type
add a few tags without type
have this in your resource page
Forms\Components\SpatieTagsInput::make('tag_with_type')->type('type'),
Forms\Components\SpatieTagsInput::make('tag_with_no_tag'),

Relevant log output
No response

Fixed by #859.


add DataFactory wrapper layer for conversion of resources

This PR does not include the tests for this handwritten layer. The tests have been running in TFS and we are in the process of moving them to this repo as well. That change will be sent in a separate PR and we would like to merge this first.

Can one of the admins verify this patch?

Hi @bgold09, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!

It looks like you're working at Microsoft (brgold). If you're full-time, we DON'T require a contribution license agreement.

If you are a vendor, or work for Microsoft Open Technologies, DO please sign the electronic contribution license agreement. It will take 2 minutes and there's no faxing! https://cla.azure.com.

TTYL, AZPRBOT;


Fill in mandatory fields for sitelog geodesyml files used in e2e tests

Working out what's mandatory and what's not is a bit tricky. We need GeodesyML domain modelling expertise to work this out. Do the tests break without these changes? We also want to be able to save invalid data.

Sometimes e2e tests failed with unexpected/unknown errors. I noticed that some of the failures were related to the input sitelog geodesyml. Although my intention is to fill in values for mandatory fields, I think it would be good to fill most optional fields as well, only leaving a few fields empty for testing purposes.

I remember this coming up before in a different scenario, but still quite similar. E2E tests of the site manager UI aren't system tests and shouldn't be touching the deployed instance of GWS in dev. In e2e tests, we need to mock calls to the GWS to respond with pre-canned site log files, which are stored in the site manager repository.

Isn't it that e2e tests for site manager use sitelog geodesyml from dev GWS?

They do, but they shouldn't The e2e tests should not touch GWS in dev. E2E tests are integration tests, where end-to-end stands for all components in the site manager application, not end-to-end of our deployed applications/systems. Unit tests target individual components, integration tests target all components together, but still within an application, before it is deployed. If we had system tests for the site manager, they would run against a deployed site manage instance (https://dev-gnss-site-manager.geodesy.ga.gov.au), which then would use GWS in dev.
E2E integration tests run against each pull request, so they can run concurrently, so they should run in isolation. But if they are touching a shared deployed resources (GWS in dev) then there will be interference.

I agree that we should use mock calls to GWS to respond with pre-canned site log files. It is an ideal scenario for e2e tests. But we have to figure out how to save a sitelog with mock calls.

Not relevant anymore


Enabling background --Welcome Tour

What changes were proposed in this pull request?

Changes for enabling background in welcome tour

(Please fill in changes proposed in this fix)

How was this patch tested?
Go to the help tab browser (left side bar with "?" Icon)
Click on "Welcome Tour"
Welcome screens gets displayed on the screen and the background is hidden.
(Please explain how this patch was tested. Ex: unit tests, manual tests)
Manual testing in the following browsers
Chrome
Safari

(Please explain how this patch was tested. Ex: unit tests, manual tests)
(If this patch involves UI changes, please attach a screen-shot; otherwise, remove this)

Before Fix: Background is hidden.

After Fix: Able to see the background

.
Please review Hue Contributing Guide before opening a pull request.

@VijayaKanchamreddy Maybe good to change the commit heading to something like
[frontend] Enable background for welcome tour?


Filtering api broken in 1.0.10

When i grab state of filters and then set it right back i get

Here is the code:
        var state = grid.getGlobalFilter().columnFilters.getState();

        console.warn("filter state", state);

       grid.getGlobalFilter().columnFilters.setState(state);

       grid.behavior.updated();

Furthermore, i followed sample for setting column filter from code and it results in the same error.
Please advise

@joneit Can offer some assistance here

@unclepaul84 Sorry for the delay here. We've confirmed the bugs and have added them to our backlog. We will be triaging them next week

FilterTree has been removed from Hypergrid Core


Step 6. refers to server 2016 - should reflect 2019

In step 6, it should says: "Now on the Windows Server 2016 federation server open AD FS Management. Note that now all of the admin capabilities appear because the primary role has been transferred to this server."
Should be: "Now on the Windows Server 2019 federation server open AD FS Management. Note that now all of the admin capabilities appear because the primary role has been transferred to this server."

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: e5a924c8-8933-cb05-d4d1-8ac3cf64d1a9
Version Independent ID: 15f1d47c-f8ec-7b76-7dbd-9bae4de99125
Content: Upgrading to AD FS in Windows Server 2016 and 2019
Content Source: WindowsServerDocs/identity/ad-fs/deployment/upgrading-to-ad-fs-in-windows-server.md
Product: windows-server
Technology: ad-fs
GitHub Login: @billmath
Microsoft Alias: billmath

#assign:xelu86

Hey @RobertGendreau,
Thanks again for contacting Microsoft. We value your feedback.
A documentation change was made, and this issue was not closed. Changes are live. We will now be closing this thread.
Thank you and have a most pleasant day.
#please-close


Add an alert for detecting stuck deployment rollouts

Description
Alerts of deployment not progressing (whatever the reason) for ODH controllers.
Merge criteria:

[x] JIRA link(s): https://issues.redhat.com/browse/RHODS-8152
[x] Live build image: quay.io/modh/rhods-operator-live-catalog:1.27.0-rhods-8152
[ ] QE contact acknowledges that this has been tested and is approved for merge.

See kubernetes-monitoring/kubernetes-mixin#845 for a potential more general alternative.

/close
(as the upstream PR was merged, it will flow down into openshift eventually)


Sanity check in GraphQL transformer doesn't detect multiple @key changes causing CloudFormation deployment failures

Describe the bug
One of the expectation of the sanity check in the GraphQL transformer is to detect changes for multiple @key updates/additions/deletions on a single table and fail pre-deployment to CloudFormation. For the following updates to the annotated schema, the sanity check doesn't catch the multiple additions of @key and continues with the CloudFormation deployment and the CloudFormation deployment after 10 minutes errors out with the following error:
Resource Name: Todo-je6oynaxxrfmhig5aogdhzhtqi (AWS::DynamoDB::Table)
Event Type: update
Reason: Cannot perform more than one GSI creation or deletion in a single update
URL: https://console.aws.amazon.com/cloudformation/home?region=us-east-1#/stacks/arn%3Aaws%3Acloudformation%3Aus-east-1%3A827149277658%3Astack%2Famplify-keytest-dev-144503-apikeytest-15HAL01D7NL6R-Todo-1JHK03F669U3U%2F01ba18c0-b4f2-11ea-985c-12da3ecd6186/events

My initial schema
type Todo @model
@key(name: "byName", fields: ["name", "description"], queryField: "byNameDescription") {
  id: ID!
  name: String!
  description: String!
}

I run amplify push thereafter and then change my schema to the following after completion of the deployment
type Todo @model
@key(name: "byName", fields: ["name", "description"], queryField: "byNameDescription")
@key(name: "byTitle", fields: ["title", "description"], queryField: "byTitleDescription")
@key(name: "byPurpose", fields: ["purpose", "description"], queryField: "byPurposeDescription")
@key(name: "byReason", fields: ["reason", "description"], queryField: "byReasonDescription") {
  id: ID!
  name: String!
  description: String!
  title: String!
  purpose: String!
  reason: String!
}

Expected behavior
Running  amplify push  after these changes should stop me from deploying to CloudFormation using the Sanity Check mechanism implemented as a part of the GraphQL transformer but it doesn't.
Amplify CLI Version
4.21.3

Hi @kaustavghosh06
I am able to reproduce this bug.Thanks for reporting this


feat: trivy prometheus parser

Add Prometheus Trivy Parser

Add new Parser to get Trivy data from Prometheus
Add Query datafield
Remove requirement for API-Parser project-key + API-key

Hi @JuLiaN47V, thank you very much for your contribution. Getting vulnerabilities out of a live Kubernetes cluster is really valuable. It looks great from a first look. Unfortunately I cannot review it properly at the moment because I am busy today and on holidays without my notebook for the next 2 weeks. In the meantime there are a few things you could do:

We need some unittests for the parser. I have just seen there is none yet for the only other API parser. But the other parsers will give you an idea how to do it and you should get the data in by mocking requests.
I am surprised there is no authentication when accessing the Prometheus API. I don't know Prometheus very well, but I would feel uncomfortable having an API without authentication.
https://github.com/MaibornWolff/SecObserve/blob/dev/frontend/src/rules/general_rules/GeneralRuleEdit.tsx#L110-L116 has an example how to show fields in the frontend dynamically.
We will need some documentation with examples for the queries.

Short Update
I am currently very busy outside work.
So do not wonder if there are no updates in the next time. It is still on my bucket list.

Sorry @JuLiaN47V, didn't see your review request until now. Will do it as soon as possible.

Rebased to upstream dev branch.

@JuLiaN47V Ready for merge?

@JuLiaN47V Ready for merge?

I am not sure about the naming of the parser.
Probably "Trivy Operator Prometheus" rather then just "Trivy Prometheus", to make it more specific.

I am not sure about the naming of the parser. Probably "Trivy Operator Prometheus" rather then just "Trivy Prometheus", to make it more specific.

Fine for me

@JuLiaN47V When you take the PR out of the Draft status, I will merge it 😃

Awesome contribution!

Awesome contribution!

Thanks for all the help :)


[distributed] Fix early stopping and DP

What does this PR do?
This PR fixes an issue where the training was hanging in multi-GPU setting and using earyl stopping
In fact, in a multi-GPU setting, we need to compute the average of policykl across all GPUs, and call early stopping
I can confirm this solution worked, the way I checked was to add a print after the self.optimizer_zero_grad and forcing the coefficient to be 0 :
if policykl > 0 * self.config.target_kl:
cc @edbeeching @lvwerra
4it [00:03,  1.36it/s]early stopping successfulearly stopping successful
5it [00:04,  1.21it/s]early stopping successful

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.

If it looks good for @edbeeching I am happy to merge it.

Should have addressed the last comment by now!


Part Dos

As promised I've done a few random tweaks here as well

Remove some extra borders/spacing
GResource the app icon
Attempt to share between flatpak/snap
Other stuff

Think I've done more work on your two little apps in the last two days than I've done on my own projects in the last two months, c'est la vie
After all this Zoey-ing I may have to go do a little rewatch

Thank you so much! I really appreciate it. I will try a test release in a couple days then merge this.


fix: update the header hash in mocha-3 to be for height 15045

Overview
changes the trusted hash for mocha-3 to that of height 15045. this is a temporary fix the issue experienced on mocha-3 where commit verification fails because the validator set changed >2/3 in a single block
Checklist

[x] New and updated code has appropriate documentation
[x] New and updated code has new and/or updated testing
[x] Required CI checks are passing
[x] Visual proof for any user facing features like CLI or documentation updates
[ ] Linked issues closed with keywords

Ah, ok. I thought this is is going to main


How to create separate logs for each process (hashtag643)

Hi
I need a separate log for each process, How can i do it?

Hi.
You just need to [add()]( an handler in each of your process. Make also sure that the child process does not inherit handlers from the parent process.

tks


Add support for new array template functions

Additional functions have been added to ARM:

indexOf
lastIndexOf
items

https://docs.microsoft.com/azure/azure-resource-manager/templates/template-functions

@ladlavj Thanks for your interest in this feature. Yes we are working on it. We hope to make it available in v1.18.0 later this month.

@ladlavj This shipped.


test_svm svm_enqueue_api - possible crash

Looks like C++ pitfall. Need to exchange
auto check_event : eventMemFillList
to
auto &check_event : eventMemFillList

PR merged, closing.


⚠ AsianCinema has degraded performance

In 23b9977, AsianCinema ($ACM) experienced degraded performance:

HTTP code: 200
Response time: 3513 ms

Resolved: AsianCinema performance has improved in f663b0d after 6 minutes.


Add RuleActionOverrides to AWS::WAFv2::WebACL ManagedRuleGroupStatement

Thank you for the PR. This change was incorporated via the spec 102.0.0 update (57a95092).

@markpeek I don't see RuleActionOverrides in that commit? Can you link to the commit where this is added? We are currently having to patch this into Troposphere.

Sorry, must have grabbed the wrong hash. This should have it: 5ede0da
Also, just released troposphere 4.3.0 with this change in it.


Submit query

Description
Upon submitting, show some error if there's no information.
Screenshots
No response
Additional information
No response

I 'll close this issue, since it's a duplicate.


Wrong date being selected

Hi. I raised a bug on an Angular directive using this plugin. However I don't think it's an Angular thing, I think there is a bug with the latest version.
I downloaded the zip from GIthub and ran both index.htm and date.htm.
I think it's an issue when selecting an older date or a date several months in the future.
Select a date in the past, say 7th October 2014, and it selects October 8th (says so in the  and highlights the 8th when reopening the calendar). Tested in both Chrome and Firefox on Mac.
Anyone else getting this issue?

This makes the current version totally useless... push out a new release... :+1:

This is fixed on master - feel free to point to there with Bower (or whatever your tool of choice).
3.5.5 will be tagged when the remaining issues are resolved: https://github.com/amsul/pickadate.js/milestones/3.5.5
Cheers.


[WIP] Various rule-robustness issues

The fragile-rule warnings introduced in GHC 8.0 have pointed out a few more places where the rules in text may not fire,

Data.Text.length may be inlined before the compareLength rules have a change to fire
the compareLength rules match against class ops
Data.Text.Lazy.Builder.Internal.flush may be inlined before the flush/flush rule has a chance to fire

I still need to test this against GHC <8.0 and check for performance regressions.

Nice. I'll chew through this soon.


More helpful error message when not sufficiently argumentative

The error message suggests you need one argument even when you
have provided one. Suggest having another argument.
Signed-off-by: Justin Cormack<EMAIL_ADDRESS>

LGTM

LGTM :heart_eyes_cat:

@justincormack need to update unit tests though :angel:

@vdemeester ah yes...

no argument here; LGTM :wink:


Added support for requireFailure when multiple gestured are attached

The existing requireFailure implementation doesn't always work because each gesture is a separate directive and not guaranteed to have been added to hammer instance.  I added a new directive with higher priority to ensure that runs after all gestures have been added.

Usage would be as follows.
<div hm-tap="foo"
     hm-doubletap="bar"
     hm-require-failure"{tap: 'doubletap', 'doubletap': ['pan', 'zoom']}">
</div>

Since the pan and zoom gestures aren't registered they are ignored and warning is logged to the console.


Port TableStorage sample into an official package

And while we're at it, write a SQL one too.
https://github.com/GrabYourPitchforks/DataProtection.Azure/tree/dev/DataProtection.Azure

Issues with Azure Key Vault:
0. Absence of netstandard version of package

How to sync distributed writes to secret?
More efficient ways of enumerating secrets then loading multi-part list and then getting each one by id.

https://github.com/aspnet/DataProtection/pull/163


Update data sync complete Jenkins jobs

Can somebody on the service manual team check the service manual change?

@thehenster ^

Huh - I didn't know that was there. We don't need it so I'm happy. :+1:

:+1: merge when ready.


In the release environment, monitoring data changes does not work

What happened?
It is normal to trigger a callback after monitoring data changes in the test environment, but after packaging into a release environment, the application monitoring data changes does not work
Repro steps
final all = DataDB.mainRealm.all();
final user = all.firstWhere((a) => a.isDefault);
this.user = user.obs;
chatSubscription = user.useLimit?.chat.changes.listen((event) async {
// After the data changes, the test environment executes, and the release environment does not execute
});
Version
realm: ^1.0.3, Flutter is already up to date on channel stable Flutter 3.10.1 • channel stable • https://github.com/flutter/flutter.git Framework • revision d3d8effc68 (5 days ago) • 2023-05-16 17:59:05 -0700 Engine • revision b4fb11214d Tools • Dart 3.0.1 • DevTools 2.23.1
What Atlas Services are you using?
Local Database only
What type of application is this?
Flutter Application
Client OS and version
android all OS and version
Code snippets
final all = DataDB.mainRealm.all();
final user = all.firstWhere((a) => a.isDefault);
this.user = user.obs;
chatSubscription = user.useLimit?.chat.changes.listen((event) async {
// After the data changes, the test environment executes, and the release environment does not execute
});
Stacktrace of the exception/crash you're getting
No exceptions, only problems with release

Relevant log output
no log

No directly related, but Flutter 3.10.0 seems to have broken many packages on pub dev... For example Firebase Auth has stopped working and if you search in Google it seems lots of packages have been broken... If you need a fast fix, downgrading Flutter has worked for other packages as a temp measure...so may be worth a spin in the meantime...

No directly related, but Flutter 3.10.0 seems to have broken many packages on pub dev... For example Firebase Auth has stopped working and if you search in Google it seems lots of packages have been broken... If you need a fast fix, downgrading Flutter has worked for other packages as a temp measure...so may be worth a spin in the meantime...

Thank you for your reply, so which version should I downgrade to?

@Tang-Hai This slipped between chairs. Do you still have an issue here?

Hello,
I have the same issue : suscribing to changes on a RealmResults works fine in debug but doesn't show any events after the first one (at init) in release mode.

No directly related, but Flutter 3.10.0 seems to have broken many packages on pub dev... For example Firebase Auth has stopped working and if you search in Google it seems lots of packages have been broken... If you need a fast fix, downgrading Flutter has worked for other packages as a temp measure...so may be worth a spin in the meantime...

Thank you for your reply, so which version should I downgrade to?

sorry did not see this. If its macOS or iOS and you have not configured Keychain Sharing capability enabled, you can see a temporary fix here https://github.com/firebase/flutterfire/issues/11186#issuecomment-1605589309 until Keychain Sharing capability is enabled - use flutter 3.3.9. Although Firebase Auth released this back in Q1, this only hit us when we upgraded to 3.10.0 for some reason, but this is the root cause.

@tanguy-penfen
I'm a bit surprised that there should be any difference in behaviour between:
class MyClass {
  late final realmResults = realm.all<Item>();
  late final streamSubscription;
  MyClass(){
    streamSubscription = reamResults.changes.listen((event){...});
}

and
class MyClass {
  late final realmResults;
  late final streamSubscription;
  MyClass(){
    realmResults = realm.all<Item>();
    streamSubscription = reamResults.changes.listen((event){...});
}

This does not match my understanding of when late final initialisers are called. It should behave exactly the same.

Still does not compute for me. The realmResults member will not be stripped by tree-shaking. Are you saying you can re-create this issue by switching to the  late final realmResults = realm.all<Item>(); version?

same issue here

Hello everyone, I'm still facing the same issue.
I've already updated to the latest version, and the behavior is still the same.
In debug mode, the synchronization is working perfectly. However, when I generate an APK in release mode and test it on the device, the synchronization doesn't work; it doesn't seem to receive any data.
After I close the app and open it again, the information gets updated.
Please, I wouldn't like to move to another solution/platform.

@leandrorazevedo If you can provide us with a minimal reproduction, or share your code, then we can take a look. I promise you that notifications work in release mode as well.
Otherwise, I would look for stream subscriptions that are not tracked and hence streams that become eligible for GC before you intend it. In Dart the GC reachability analysis is a fair bit more aggressive in release than in debug mode.

@nielsenko, I'm sorry to insist on posting here in this thread, but I believe it can be useful for other programmers...
After conducting several tests, I've come to a conclusion (which doesn't make sense to me, but I'll leave it here)...
Just a reminder of the situation: The realm's 'listen' works in debug mode and doesn't work in release mode.
class _HomeScreenState extends State<HomeScreen> {

    RxInt qtNotificationNotRead = 0.obs;
    late final StreamSubscription<RealmResultsChanges<schema.Notification>> streamSubscription;

    @override
    void initState() {
       super.initState();
       _initNotificationRealm();
    }

    Future<void> _initNotificationRealm() async {
        streamSubscription = allNotificationsRealm!.all<schema.Notification>().changes.listen((event) {
          qtNotificationNotRead.value = event.results.where((element) => !element.isRead).length;
        });
    }

    @override
    Widget build(BuildContext context) {
       ...
       icon: Obx(
                      () => Badge(
                          label: BodyText.small(qtNotificationNotRead.value > 9 ? "9+" : ${qtNotificationNotRead.value}", color: colorWhite),
                          isLabelVisible: qtNotificationNotRead.value > 0,
                          backgroundColor: colorError,
                          child: const SvgWidget('regular/bell', color: colorWhite),
                      ),
                 ),
       ...
    }
}

The code above works perfectly fine in both the debug and release environments.
But if we change ONLY the variable declaration to (excluding final):
    late StreamSubscription<RealmResultsChanges<schema.Notification>> streamSubscription;

The app's behavior starts to match the description in the title of this thread: the 'listen' method gets triggered in the debug environment but doesn't get triggered in a release mode APK.
I hope that this can help other people in some way.

Why is _initNotification async?

It was just an error in the text formatting for the issue.
Here's the complete code: (but I think this doesn't interfere with our issue)
  Future<void> _initNotificationRealm() async {
    if (userController.user != null) {
      allNotificationsRealm = await RealmUtils.createNotificationDb(userId: userController.user!.id);

      streamSubscription = allNotificationsRealm!.all<schema.Notification>().changes.listen((event) {
          qtNotificationNotRead.value = event.results.where((element) => !element.isRead).length;
        });
    }
  }

Here's my implementation for the createNotificationDb method:
enum CollectionType { ctNotifications }

class RealmUtils {
  static Future<Realm> createNotificationDb({required String userId}) async {
    const collectionType = CollectionType.ctNotifications;

    final user = await _createAppUser();

    final flxConfig = Configuration.flexibleSync(user, [Notification.schema], path: await _absolutePath("db_${collectionType.name}.realm"));

    var realm = Realm(flxConfig);
    debugPrint("Created local realm db at: ${realm.config.path}");

    final RealmResults<Notification> query = realm.query<Notification>('owner == $userId && deleted == false');

    realm.subscriptions.update((mutableSubscriptions) {
      mutableSubscriptions.add(query);
    });

    realm.subscriptions.waitForSynchronization().then((value) {
      debugPrint("Synchronization completed for realm: ${realm.config.path}");
    });

    return realm;
  }

  static Future<User> _createAppUser() async {
    const String appId = "xxxxxxxxxxxxxx";
    final appConfig = AppConfiguration(appId);
    final app = App(appConfig);
    final apiKeyCredentials = Credentials.apiKey("xxxxxxxxxxxxxxxx");
    final user = await app.logIn(apiKeyCredentials);
    return user;
  }

  static Future<String> _absolutePath(String fileName) async {
    final appDocsDirectory = await getApplicationDocumentsDirectory();
    final realmDirectory = '${appDocsDirectory.path}/mongodb-realm';
    if (!Directory(realmDirectory).existsSync()) {
      await Directory(realmDirectory).create(recursive: true);
    }
    return "$realmDirectory/$fileName";
  }
}

Looking at createNotificationDb I do wonder why you are opening a realm that is named after the collection type? Or maybe you really only have that one realm type in your app?

At the moment, we only have this realm type.
We are still conducting analysis and testing of the solution.
We have already made significant progress. In our architecture, the use of flexible sync (app sync) is crucial.
Regarding platforms, we are working with Android and iOS.

My little project has the same issue in the release build on Windows & macOS.
Thanks for @leandrorazevedo providing the _initNotificationRealm method to work around this issue.
The project is open-source and the problem was fixed in v1.2.1.

v.1.2.1 download here
v1.2.0 download here
Project source code: https://github.com/MainasuK/train_map

Maybe that's enough info to help you take a deep look at what's wrong. @nielsenko
flutter --version
Flutter 3.16.7 • channel stable • https://github.com/flutter/flutter.git
Framework • revision ef1af02aea (5 weeks ago) • 2024-01-11 15:19:26 -0600
Engine • revision 4a585b7929
Tools • Dart 3.2.4 • DevTools 2.28.5

How to reproduce the issue:

Open the app and welcome page display
Copy sheet A content and paste it into the first text input (use text editor e.g VS Code)
Copy sheet B content and paste it into the second text input
Scroll to the bottom of the page. Click the button to import the data

Expect: The sidebar should update and a new data entry row appear
Actual: Nothing updated. Close and open the app again. The data entry display in the sidebar
data_sheet.zip

@MainasuK this issue has been closed for 6 months - if you have a similar problem, please file a new issue and fill in the template.


Need one more convStream element

The loop starting at 493 is off-by-one without it, as are lines 568 and 569.
Furthermore, if it so happens that the model has lots of parts but few levels (ie a small λ) such that parts ("n" here) is more than two greater than the HOG pyramid levels ("numLevels"), line 580 will overflow. This is TODO, but a higher priority IMO is to redesign the use of streams and texture memory, as texMap prevents parallelisation of part map processing.

Looks good.

BTW There are many magic number in GPU code. They are hard to read and understand and may causes bug like this issue.


Can WebView provide a method to execute scripts and callback the result?

I am using WebView to show a html5 page, a requirement for me is to execute a script and callback me the result when page is loaded.
so far WebView only provide a property(injectJavaScript) to execute a script, but does not provide a way to get the result .
could you please enhance this with a callback so that I can get the result ?

Thanks for opening the issue, however it looks like a feature request. As noted in the Issue template we'd like to use the GitHub issues to track bugs only. Can you implement the feature as a standalone npm module? If not consider sending a pull request or a create an entry on Canny. It has a voting system and if the feature gets upvoted enough it might get implemented by someone from the community. Closing this now, thanks for understanding!

@hramos any news, did react-native team add callback feature ?


Update standardized-audio-context

I have been using version 25.2.8 of standardized-audio-context with great success as Tone.js' AudioContext. I primarily had to do this to utilize the new createMediaStreamTrackSource method which allows me to work directly with a MediaStreakTrack as an audio source. 🎶
Out of curiosity, is updating Tone.js deps to the latest version of standardized-audio-context on the roadmap?
Note: I have issues with version 25.2.9 (initializing a new Meter object raises errors about AudioParam) but 25.2.8 works great!

Hi @BrandonMathis, can you share what problems you ran into with v25.2.9? Maybe there is something I need/can/should fix.

Actually... I think i was mistakenly using the browser's built-in AudioContext 😅
I moved back down to the current version of standardized-audio-context and createMediaStreamTrackSource works great.
I will close this issue.


Switch base map style to OSM Liberty

Closes #37
This is deployed right now to the demo server for testing. Deploy went fine, so I'm inclined to merge after the other open PRs it if nobody objects to the docker config.
It looks like lots of POIs I'd expect to see aren't there, and the sprites for interstates and whatnot aren't shown. But this is still a big win IMO. I had to modify the OSM Liberty style to get it to work at all though so it's possible I messed things up as I was aimlessly editing it trying to get minor roads to show up.

Merging because some changes ended up in here that I want to add as a fast-follow to #38. Plus I think the new style looks good! Has some issues but we can sort them out later.


feature：the dashboard can support controlling cluster nodes？

the dashboard  need to deploy independently , replaces the existing built-in.

do it enough for you? apisix supports to enable/disable admin api by yaml config now.
https://github.com/iresty/apisix/blob/master/conf/config.yaml#L5

i want that apisix node can register the config center ，then the admin dashboard can manage the  registered node and show its status ，and the route 、service config must be assigned to which apisix node 。we need apisix cluster。

Do you want to manage multiple clusters in one admin dashboard? We plan to support this feature in the commercial version. The apisix node configuration in a cluster is the same.

so it is！  then  the apisix nodes become resource pool , the manager can assige some nodes to app1, assige  another nodes to app2 , it is convenient for managers.

I am also comfirming whether apisix supports to view the node status of cluster.
Does apisix plan to support it in the community？
@membphis

@agile6v yes, welcome PR

I think we use Prometheus to collect all of the statuses of the cluster nodes.
Apache APISIX support Prometheus is enough, we do not need to support more.
https://github.com/apache/incubator-apisix-dashboard/issues/270


feat: add support for granular autocomplete values

Description

feat: add support for granular autocomplete values

Testing required outside of automated testing?

[ ] Not Applicable

Screenshots (if appropriate):

[ ] Not Applicable

Rollback / Rollforward Procedure

[ ] Roll Forward
[ ] Roll Back

Reviewer Checklist

[ ] Description of Change
[ ] Description of outside testing if applicable.
[ ] Description of Roll Forward / Backward Procedure
[ ] Documentation updated for Change

:tada: This PR is included in version 1.21.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


WIP: create new state snapshots on join

Fixes #211 by implementing #232.

Closing as dmr has ended up doing something different here.


Barrymore Action Description

The previous times John Blyth Barrymore performs meaningful physical acts, it is described inside brackets. I think something similar to  [Gasp.] might be optimal, as your original description was short and impactful. However, I'm unsure if we can clearly convey the meaning without specifying that it is an action Barrymore performs. Because of that, I've attempted to mimic your previous eloquent writing while separating the gasp into the shortest possible sentence. I am open to suggestions.

Will leave this open for now and see to it later. This is a large topic which will require further discussion.

bump


Mitigating abuse of the event depth parameter over federation

Documentation: https://docs.google.com/document/d/16ofbjluy8ZKYL6nt7WLHG4GqSodJUWLUxHhI6xPEjr4/edit
Author: @ara4n
Date: 30/04/2018

Does this have an implementation component already?

Does this have an implementation component already?

Erik started work on it (PR list at https://github.com/matrix-org/synapse/issues/3785), but got distracted.
A temporary mitigation was put in place via https://github.com/matrix-org/matrix-doc/issues/1230.

This is blocked on implementation, which is unlikely to happen any time soon. I'm also curious if this should go through another round of review/FCP given its age and having followed a legacy process in the past.


Return overflowing tokens to avoid memory leak in HF tokenizer

@bjorncs Please review
@havardpe FYI

Consider adding a comment in the code for reason why this option is set


Broken links

Description of the bug
Current behavior:
The wf-paired-end-illumina-assembly pipeline documentation link in the Bug report issue template is broken.
Expected behavior:
Check all links in repo to make sure they work.
Command used and terminal output
N/A
Relevant files
.github/ISSUE_TEMPLATE/bug_report.yml
System information
N/A

setup markdown-link-check https://github.com/marketplace/actions/markdown-link-check or perhaps https://github.com/UmbrellaDocs/linkspector (not yet in marketplace) to verify all links in README.md files are alive not dead


Geocoder reverse.

Master Anton.
Already do 24H I'm not reverse geocoder, use version 3.2
This is the original path of the project that I use.
<Entry key = 'geocoder.enable'> true </ entry>
<Entry key = 'geocoder.type'> nominatim </ entry> <entrykey = 'geocoder.url'>
  http://nominatim.openstreetmap.org/reverse </ entry>

Already moved to google and gisgraphy, no use.
The log does not appear to believe error
log.txt

It looks like you aren't using official version of Traccar. Is that correct?
As for geocoding, there is nothing about it in the log. You should never use official Nominatim reverse geocoding server other than for testing.
Do your device(s) report valid locations?

Traccar use with Web UI Vitalize.
What would be the proper way to use the geocoder services?
Your help will be appreciated.
tracker-server.txt
Yes the coordinates are valid.

How many devices do you have? Try Google geocoder again. It should work, but it has a limit on number of requests.

I use traccar to track trackers 3, 4 smartphone.
Google for providing services in less than 24 hours.
Nominatim being the first time with this problem.
Thanks for the help

If you want to use Nominatim, you should host your own server or use some third party provider.

I don't know if I must open a new issue, because it's about geocoder too ?!!!
I just register as  google's developper's console; because I want to try geocoder reverse more than 2500/day.
I have  activate  the geocoder's API and google sent me a     .json    file !!!
And now, how to put it inside   traccar 3.2 ?????
Thanks.
Igor

Traccar uses Google reverse geocoder by default. You don't need to register or do any configuration.

Thanks, but I think that I reach the free 2500/day google reverse,  (or something not well parameter on my 10 devices or on traccar ????)

Traccar doesn't currently support paid version of Google API. If you think you reached the limit, you either need to slightly modify source code to use your API key or use some other geocoder provider.


Unable to run Linux container on Windows

Hey,
I've followed above example and everything built fine. When I attempt to run the image I receive this error:
standard_init_linux.go:211: exec user process caused "no such file or directory"
Not sure where to take it from here. Did anyone experience similar issue?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: b31d4f6c-d16d-2ba1-1294-6aa94e328046
Version Independent ID: 88aec599-4410-697d-1002-1c41b1c17bb6
Content: Running a self-hosted agent in Docker - Azure Pipelines
Content Source: docs/pipelines/agents/docker.md
Product: devops
Technology: devops-cicd
GitHub Login: @steved0x
Microsoft Alias: sdanie

Hi Guys,
@Lukasz994 problem is with the difference between Windows and unix-based systems EOL (CRLF vs LF), when i create a new image following the documentation on the part of Linux Containers, however using windows, Dockerfile specify to copy the start.sh into the container with the windows format (CRLF). Then when i run in a container the output is: standard_init_linux.go:211: exec user process caused "no such file or directory".
To solve this problem i edited the Dockerfile, adding dos2unix and converting windows to unix format:
FROM ubuntu:16.04

# To make it easier for build and release pipelines to run apt-get,
# configure apt to not require confirmation (assume the -y argument by default)
ENV DEBIAN_FRONTEND=noninteractive
RUN echo "APT::Get::Assume-Yes \"true\";" > /etc/apt/apt.conf.d/90assumeyes

RUN apt-get update \
&& apt-get install -y --no-install-recommends \
        ca-certificates \
        curl \
        jq \
        git \
        iputils-ping \
        libcurl3 \
        libicu55 \
        libunwind8 \
        netcat \
	dos2unix

WORKDIR /azp

COPY ./start.sh .

RUN chmod +x start.sh
RUN dos2unix start.sh

CMD ["./start.sh"]

Do you see a need to put this in the documentation? to users who need to create images using windows for linux.
I know what the documentation specifies in topic 5

Save the following content to ~/dockeragent/start.sh, making sure to use Unix-style (LF) line endings:

If you are editing in vscode you can change the line ending in the editor. See this SE answer. https://askubuntu.com/questions/1036322/running-script-made-in-visual-studio-code-on-windows-on-wsl-ubuntu-returns-li
Be sure to rebuild the image and you should be good to go.


Support for multiple Mikro-ORM instances with context (RequestContext / AsyncLocalStorage)

Is your feature request related to a problem? Please describe.
I need to use Mikro-ORM to connect to different database instances, so I have multiple Mikro ORM instances running in my NestJS application. (One is located within an npm dependency, the other is located in the NestJS application directly).
At the moment it seems I cannot use the Mikro-ORM instance in the npm dependency, because the RequestContext helper only supports a single Mikro-ORM entity manager -- more specifically, whatever Mikro ORM EM is used in the RequestContext.create call.
Describe the solution you'd like
I'd like to find a solution that allows multiple instances of entity manager, belonging to different mikro orm instances, to coexist, without them interfering with one another.
A potential way to do this is to combine the following solutions:

allow Mikro-ORM/entitymanager instances to be named, making them 'aware' of their own name;
using the name for the entity manager instances to fetch the proper entity manager from context;
creating new versions of RequestContext and a wrapper for AsyncLocalStorage that supports storing/fetching multiple entity managers

Describe alternatives you've considered
I've considered rolling the two database instances into one, but that will likely cause trouble for us down the road since we need to be able to scale them independently.
Additional context

I have a commit that makes EntityManager 'name-aware'  over at https://github.com/hilkeheremans/mikro-orm/commit/3c84e9aedddf62b757053c271eff0b31cfa861e5. Note: I could not verify this via tests or add new tests, since I can't get the tests to run properly. Unclear what I need to do to fully set up the schema in the db's of the docker containers.

I believe making RequestContext/AsyncLocalStorage compatible with multiple Entity Managers may require a slightly more fundamental change. The way this context is created now, eg via RequestContext.create() forces you to specify the entity manager you want to fork. Is this still the road we want to take, or is an alternative method, ie letting the user of RequestContext specify a set of root entity managers initially in code, all of which can then be forked on each new request? This would also simplify the API.

Either way, these new versions of RequestContext/AsyncLocalStorage would be breaking changes, so it would probably make sense to create these new versions alongside the existing ones, so users can opt-in to them at will.

Thanks a bunch for your input and let me know what I am missing.

What about this:

EM will have an optional name
the name will be passed as a parameter to the context callback
you will implement custom context method that will pick the right EM from current context holder (let it be domain api or ALS)
we can have additional version of the RequestContext helper to reduce boilerplate, but the original class will stay as is to maintain BC

ok, I should have checked your commit sooner, I see you basically did exactly that :] that sounds like correct way to me
Something like this could work for the context helper:
import domain, { Domain } from 'domain';
import { EntityManager } from '../EntityManager';
import { Dictionary } from '../typings';

export type MultiORMDomain = Domain & { __mikro_orm_context?: MultiRequestContext };

/**
 * For node 14 and above it is suggested to use `AsyncLocalStorage` instead,
 * @see https://mikro-orm.io/docs/async-local-storage/
 */
export class MultiRequestContext {

  private static counter = 1;
  readonly id = MultiRequestContext.counter++;

  constructor(readonly map: Map<string, EntityManager>) { }

  /**
   * Creates new RequestContext instance and runs the code inside its domain.
   */
  static create(map: Map<string, EntityManager>, next: (...args: any[]) => void): void {
    const forks = new Map<string, EntityManager>();
    map.forEach((em, name) => forks.set(name, em.fork(true, true)));
    const context = new MultiRequestContext(forks);
    const d = domain.create() as MultiORMDomain;
    d.__mikro_orm_context = context;
    d.run(next);
  }

  /**
   * Creates new RequestContext instance and runs the code inside its domain.
   * Async variant, when the `next` handler needs to be awaited (like in Koa).
   */
  static async createAsync(map: Map<string, EntityManager>, next: (...args: any[]) => Promise<void>): Promise<void> {
    const forks = new Map<string, EntityManager>();
    map.forEach((em, name) => forks.set(name, em.fork(true, true)));
    const context = new MultiRequestContext(forks);
    const d = domain.create() as MultiORMDomain;
    d.__mikro_orm_context = context;
    await new Promise((resolve, reject) => {
      d.run(() => next().then(resolve).catch(reject));
    });
  }

  /**
   * Returns current RequestContext (if available).
   */
  static currentRequestContext(): MultiRequestContext | undefined {
    const active = (domain as Dictionary).active as MultiORMDomain;
    return active ? active.__mikro_orm_context : undefined;
  }

  /**
   * Returns current EntityManager (if available).
   */
  static getEntityManager(name: string): EntityManager | undefined {
    const context = MultiRequestContext.currentRequestContext();
    return context ? context.map.get(name) : undefined;
  }

}

Any updates on this? I am planning to ship 4.1 soon, will be happy to include MultiRequestContext if you can confirm it does what we need.

Not yet, I have other priorities this week. It may take a while.
On 6 Oct 2020, 09:59 +0200, Martin Adámek<EMAIL_ADDRESS>wrote:
Any updates on this? I am planning to ship 4.1 soon, will be happy to include MultiRequestContext if you can confirm it does what we need.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/mikro-orm/mikro-orm/issues/872#issuecomment-704100425, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ACO7MYHNAH2OFFKNB73XJDLSJLE43ANCNFSM4RZKTJQQ.

Does mikro supports multiple instances without RequestContext? I saw that MetadataStorage has global metadata property where every EntityMetadata is stored (if I understood it correctly).
If I use EntitySchema + custom init function to create connection, I guess it should work, right?

RequestContext is only about automatic handling of contexts, you don't need it if you fork the EM manually. It is also handy when you use DI and have singletons of repositories, but as long as you use em.fork() and work with that (and get repositories from that fork via em.getRepository()), there is now need to RequestContext helper.

Sounds good!
what about global static metadata field on MetadataStorage? and what if I want to have entities with the same name on different connections?

Thats only for decorators, so with EntitySchema it should be all good.

v4.3 will allow specifying contextName in the config (name was already taken by connection name), which will be used to get the right EM in RequestContext. You can now pass array of EMs in the create method.
Let me know if it works, will be happy to reopen.

Wow, thanks. I was just about to pick this up again and just noticed you closed it. I'll add a test ticket to my workload to test this soon.


How to set Content-type=application/json in response

I've tried to produce as response a JSON object, but using FDK content-type is always set to text/plain
I have tried using:
(1) simply a dictionary
res = {}
# res['apps'] = vet
res['id'] = 100

return res

(2) using response.RawResponse
with:
return response.RawResponse(
ctx,
status_code=200,
headers=[{"Content-Type":"application/json"}],
response_data=res
)
but Content-type is not set to application/json

ok, great. NIce work

w


the tests directory is present in the source packages

Since we use the pyproject.toml the tests folder is always part of the source packages. I attempted to fix that multiple times and failed.
@sobolevn: Do you have an idea what I am doing wrong?

Why do you think that this should be fixed? Many maintainers are asked to do exactly this.
Check out https://github.com/typeddjango/pytest-mypy-plugins/issues/114

Oh Interesting! My intention was to decrease the package size and overall shipped Python files. Also, the files end up next to the lona package, not in it.

Ah! You are right. According to https://packaging.python.org/en/latest/guides/using-manifest-in/#how-files-are-included-in-an-sdist it is best practice to include your tests into an sdist. It's a bit weird to me, but ok then. Thanks for your help!


Add link to App Insights on Spring TOC

@brunoborges  I'll merge w/ the build is done.

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs-ref-conceptual/spring-framework/toc.yml
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Complete project code

All the linters setup
Modified HTML code with Home and About pages
Stylized both pages with CSS
Updated Readme File

Hello @Nasirkhan294 - [ ] 🟢 Please record the presentation of the application as the project requirements suggest including the piece of code you are proud of.


Are the third party apps supported with WInAppDriver?

I need to automate Micro Focus Reflection 3270 emulator. is it possible to automate it with WinAppDriver? There is no automation iD available for this software in Inspect.exe. Also, i am not able to create any relevant XPATH for the fields. Please guide me a way to automate this.

What about other properties like name, classname or tagname

attached is the sample screen of the 3270 emulator. We work on the entire black screen. It's a grid prefebally 2480 (but is customizable). I am also attaching the screenshot of inpect.exe. inspect.exe shows the class name as 'REFLECTION_EIGHT" for the entire workarea of 2480 grid. There can be many fields in that area, and I am not able to find any way to pass/get data at a particular field say at row 2 and colum 30 i need to get the data of next 6 bytes, but there is no way to do it.
Could you please suggest me a way to do it?
winAppDriver issue screenshot.docx

grid of 24 X 80. Rows = 24 and coloums = 80.

You need to access inside the black area or the editor, if the SW is under you control ask the developers to implement automation properties without that  you do not have a way out

Nope the software is not under my control. There is no way we can edit the code of the emulator. Consider this emulator as the Android emulator of Windows and myself as the andoid developer. An app runs inside the black screen (which is of 24 X 80 grid). I am a developer of that APP.
In the webdriver, ways to get some data from page/windows application are byattribute, byelementid, by Xpath, by Cssselector etc etc. Is there any way i can tweak it out and get the values by providing row number and coloum number? The same way we do in VBA for excel (For example Cell(row,coloum)). ElementID, Xpath, CSS Selector etc won't help me here with this emulator.
A webpage has a source code with lot of elements on it. Individual elements has unique values. Same is with the windows applications. Windows applications are not versatile as Web pages are. Layout of Windows applciations are always constant. Suppose I know that in a particular Window application there is a text box present at row 12 and column 5, then Won't it be possible for me to get the value from that text box by providing it co-ordinates(Rows and columns in this case).
Sorry for the long comment, I am just trying to explain my problem to you and looking for a ray of hope.

Can we have a hangout call<EMAIL_ADDRESS>

Sure just sent you a request from<EMAIL_ADDRESS>


[jvm-packages] Release dmatrix when no longer needed

When using xgboost4j-spark I had executors getting killed much more
often than i would expect by yarn for overrunning their memory limits,
based on the memoryOverhead provided. It looks like a significant
amount of this is because dmatrix's were being created but not release
as they were only released when the GC decided it was time to
cleanup the references.
Rather than waiting for the GC, release the DMatrix's when we know
they are no longer necessary.

LGTM, waiting for travis, thanks!

merged, thanks


linux-like: add OPEN_TREE_CLONE and OPEN_TREE_CLOEXEC

This adds the OPEN_TREE_CLONE and OPEN_TREE_CLOEXEC constants on Linux and Android.
Those are used by the open_tree() syscall and defined in mount.h:

https://github.com/torvalds/linux/blob/v6.1/include/uapi/linux/mount.h#L61-L65

Thanks! @bors r+

:pushpin: Commit c578f2fae30f1a6f96b078ceae6935a214c2ff04 has been approved by JohnTitor
It is now in the queue for this repository.

:hourglass: Testing commit c578f2fae30f1a6f96b078ceae6935a214c2ff04 with merge 472875e8e6e21362f3f8d9b83a2f5dffbe544e3e...

:broken_heart: Test failed - checks-actions

Amended to add mising linux/mount.h includes in libc-test logic.

@bors r+

:pushpin: Commit 2fd7e81ef0952e02b52dd8867fb071200cf38a9e has been approved by JohnTitor
It is now in the queue for this repository.

:hourglass: Testing commit 2fd7e81ef0952e02b52dd8867fb071200cf38a9e with merge d4a917eb599efbbccca44448e49148f115241b6f...

:broken_heart: Test failed - checks-actions

CI failure:
/checkout/target/i686-unknown-linux-musl/debug/build/libc-test-edac14eb712d5cd2/out/main.c:120:10: fatal error: linux/mount.h: No such file or directory
120 | #include <linux/mount.h>
    |          ^~~~~~~~~~~~~~~

I'm a bit out of clues about why it cannot find linux/mount.h specifically, while all the other linux/*.h kernel headers seem fine. Is there some weird setup for kernel headers in CI? How can I trigger bors tests myself to dig into this?

Hmm, our kernel version on musl is indeed quite old, IIUC but mount.h is more senior than it and I'm not sure why that happens.
You can find our CI structure here: https://github.com/rust-lang/libc/tree/master/ci
You're also now able to use @bors try, feel free to test on bors!
@bors delegate+

@bors delegate+

:v: @lucab can now approve this pull request

@bors try

@bors try

:hourglass: Trying commit 82ded69e24f54e0b2a322f682a0dc83b6e5642e4 with merge 87ed48351296c2d24fe8c5ee3d36d5d9dd3e9bd8...

:sunny: Try build successful - checks-actions, checks-cirrus-freebsd-12, checks-cirrus-freebsd-13, checks-cirrus-freebsd-14
Build commit: 87ed48351296c2d24fe8c5ee3d36d5d9dd3e9bd8 (87ed48351296c2d24fe8c5ee3d36d5d9dd3e9bd8)

Ok, so the problem with musl tests is that the headers snapshot at https://github.com/sabotage-linux/kernel-headers is from version 4.19.88. There has been a rework/split of kernel headers after that, but anyway the OPEN_TREE_* constants are more recent than that version.
I've reworked the tests to take that into account, and bors CI is green now.
This PR should be ready for stamping and merging now.

:sunny: Test successful - checks-actions, checks-cirrus-freebsd-12, checks-cirrus-freebsd-13, checks-cirrus-freebsd-14
Approved by: JohnTitor
Pushing 68ad935b38245088b4cd7276f8e53d80dc20823e to master...


feat: Send metrics no panorama API as a fallback

Issue #, if available:
Description of changes:
If AWSC.Clog.log() API is not present, we can use panorama() API to submit our data
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

There is a downstream build issue: https://github.com/cloudscape-design/component-toolkit/actions/runs/10777035651/job/29885572578?pr=96
I am going to fix these tests, but it requires some preliminary setup: https://github.com/cloudscape-design/components/pull/2686


Examples of race conditions

In your documentation, it is stated: "Because all mutations are centralized and happen one by one in a strict order, there are no subtle race conditions to watch out for"
Can you please give an example of how a race condition can occur? Given that JS is single threaded, every 'action' on the model will operate in a strict order (the execution order). Obviously, asynchronous functions can delay when a mutation occurs, but this is the same as an async action creator 'waiting' before dispatching an action (actions are processed synchronously).
Ive struggled to see how any flux implementation helps in this respect. All they do is allow for a 'change' event after the mutation.
Any help with what i'm conceptually missing  would be great!

Obviously, asynchronous functions can delay when a mutation occurs, but this is the same as an async action creator 'waiting' before dispatching an action (actions are processed synchronously).

Yes. But even async action creator leaves a trace: a synchronous dispatch. If you log them, you can see how a race condition has occurred, if it has, and you can reproduce the exact same state if you replay actions in this order. Flux-when-you-don't-do-AJAX-from-Stores has the same benefits.
By contrast, with something like Backbone or Flux-when-you-call-AJAX-from-Stores, there is no way to reproduce a race condition. You might have a subtle bug due to requests sometimes coming in the wrong order, but unless there is a single synchronous point where everything has to be described as a plain object actions, there is no way for you to reliably reproduce such race conditions.
Of course we can't magically solve the race conditions, as any program is asynchronous (even user input is :-). But Redux makes them explicit, so if you ever get them, you know how to debug, log, and reproduce them.