TypeError: unorderable types: str() > int()

Problem
When I try build blender's documentation with latest development version (0.1.10-alpha), I get TypeError: unorderable types: str() > int():
# Sphinx version: 1.4.6
# Python version: 3.4.4 (CPython)
# Docutils version: 0.12 release
# Jinja2 version: 2.8
# Last messages:
#   manual/compositing/types/color/mix.rst:85: WARNING: inconsistent references in translated message
#   looking for now-outdated files...
#   none found
#   pickling environment...
#   done
#   checking consistency...
#   done
#   preparing documents...
#   done
#   writing output... [  0%] about/contribute/build/index
# Loaded extensions:
#   alabaster (0.7.9) from d:\scripts\python\lib\site-packages\alabaster\__init__.py
#   vimeo (unknown version) from D:\Projects\other\blender_docs\exts\vimeo.py
#   sphinx.ext.mathjax (1.4.6) from d:\scripts\python\lib\site-packages\sphinx\ext\mathjax.py
#   youtube (unknown version) from D:\Projects\other\blender_docs\exts\youtube.py
Traceback (most recent call last):
  File "d:\scripts\python\lib\site-packages\sphinx\cmdline.py", line 244, in main
    app.build(opts.force_all, filenames)
  File "d:\scripts\python\lib\site-packages\sphinx\application.py", line 297, in build
    self.builder.build_update()
  File "d:\scripts\python\lib\site-packages\sphinx\builders\__init__.py", line 251, in build_update
    'out of date' % len(to_build))
  File "d:\scripts\python\lib\site-packages\sphinx\builders\__init__.py", line 322, in build
    self.write(docnames, list(updated_docnames), method)
  File "d:\scripts\python\lib\site-packages\sphinx\builders\__init__.py", line 360, in write
    self._write_serial(sorted(docnames), warnings)
  File "d:\scripts\python\lib\site-packages\sphinx\builders\__init__.py", line 368, in _write_serial
    self.write_doc(docname, doctree)
  File "d:\scripts\python\lib\site-packages\sphinx\builders\html.py", line 452, in write_doc
    self.handle_page(docname, ctx, event_arg=doctree)
  File "d:\scripts\python\lib\site-packages\sphinx\builders\html.py", line 803, in handle_page
    output = self.templates.render(templatename, ctx)
  File "d:\scripts\python\lib\site-packages\sphinx\jinja2glue.py", line 138, in render
    return self.environment.get_template(template).render(context)
  File "d:\scripts\python\lib\site-packages\jinja2\environment.py", line 989, in render
    return self.environment.handle_exception(exc_info, True)
  File "d:\scripts\python\lib\site-packages\jinja2\environment.py", line 754, in handle_exception
    reraise(exc_type, exc_value, tb)
  File "d:\scripts\python\lib\site-packages\jinja2\_compat.py", line 37, in reraise
    raise value.with_traceback(tb)
  File "d:\scripts\python\lib\site-packages\sphinx\themes\basic\page.html", line 10, in top-level template code
    {%- extends "layout.html" %}
  File "D:\Projects\other\blender_docs\manual\../resources/templates\layout.html", line 1, in top-level template code
    {% extends "!layout.html" %}
  File "d:\scripts\python\lib\site-packages\sphinx_rtd_theme\layout.html", line 123, in top-level template code
    {% block menu %}
  File "d:\scripts\python\lib\site-packages\sphinx_rtd_theme\layout.html", line 124, in block "menu"
    {% set toctree = toctree(maxdepth=theme_navigation_depth, collapse=theme_collapse_navigation, includehidden=True) %}
  File "d:\scripts\python\lib\site-packages\jinja2\sandbox.py", line 355, in call
    return __context.call(__obj, *args, **kwargs)
  File "d:\scripts\python\lib\site-packages\sphinx\builders\html.py", line 793, in <lambda>
    ctx['toctree'] = lambda **kw: self._get_local_toctree(pagename, **kw)
  File "d:\scripts\python\lib\site-packages\sphinx\builders\html.py", line 729, in _get_local_toctree
    docname, self, collapse, **kwds))['fragment']
  File "d:\scripts\python\lib\site-packages\sphinx\environment.py", line 1234, in get_toctree_for
    prune=True, **kwds)
  File "d:\scripts\python\lib\site-packages\sphinx\environment.py", line 1508, in resolve_toctree
    self._toctree_prune(newnode, 1, prune and maxdepth or 0, collapse)
  File "d:\scripts\python\lib\site-packages\sphinx\environment.py", line 1302, in _toctree_prune
    if maxdepth > 0 and depth > maxdepth:
TypeError: unorderable types: str() > int()

Reason
Error occured in file sphinx_rtd_theme\layout.html at line 124:
    {% set toctree = toctree(maxdepth=theme_navigation_depth, collapse=theme_collapse_navigation, includehidden=True) %}

After commit 923082974ce1aad26e8f12d6581c68b029b72d58 was added configuration setting navigation_depth, which used in that line. But underlying ConfigParser do not implicitly convert datatypes:

Config parsers do not guess datatypes of values in configuration files, always storing them internally as strings. This means that if you need other datatypes, you should convert on your own:

Nevertheless, value of that setting run into template without conversion to int, and as result we would get TypeError, because toctree() function expects what maxdepth parameter would be int.

This has been fixed in https://github.com/snide/sphinx_rtd_theme/commit/61eb48bc759ad428bde474dc6a441ed2a7adaf7f please close @ericholscher


Support mutable generics and remove var flag

This PR is the result of many discussions with @romac @gsps @vkuncak. There was also great support by @jad-hamza on the Stainless side of things, thanks!
The PR brings the mutability support of rust-stainless closer to Rust's semantics by dropping the var annotation on fields.
Closes #157. Closes #99 because now, all fields can be mutated with mut at binding.
This is a big step for #92 and brings us closer to #140.
Theory
The safety of what we do in this PR, mainly on this single line change is guaranteed by the following theoretical argument:

Rust has either 1 mutable reference or many shared, immutable, aliasable borrows
Stainless allows 1 reference to a mutable object but we can create aliases with freshCopy at our own risk
Thanks to Rust, we know that when we borrow something immutably (BorrowKind::Shared), it’s aliasable and we can therefore safely freshCopy it.

There are 3 other places, where freshCopy is/was introduced:

For function parameters that are taken by-value. It's safe to freshCopy them because the by-value/move semantics guarantee that they are owned i.e. there are no other references to them.

Return values are freshCopy'd to avoid aliasing. This is safe (currently) because we only support returning by-value or by shared, immutable reference.

stainless::Map is a special case. In order to get support for mutable value types, we needed to refactor the map extraction. Behind the immutable Rust interface that resides in libstainless the map is now extracted as MutableMap. To combat aliasing, the insert and remove method now consume self. This allows on the extraction side, to extract for example let b = a.insert(0, 1); as the following in Scala:

val b: MutableMap[UInt32, Option[UInt32]] = freshCopy({
  val map: MutableMap[UInt32, Option[UInt32]] = freshCopy(a)
  map(0) = Some[UInt32](1)
  map
})

This is now finished, CI will pass once the latest stainless-noxt is published.
@gsps @romac please review. 🙏

Closing in favour of #164. Most of the changes here are contained there.


Per format packages support

Pull Request Check List

[x] Added tests for changed code.
[x] Updated documentation for changed code.

This PR adds support for specifying packages on a per-format basis. This is especially useful for adding a tests packages to the sdist which is a common case:
[tool.poetry]
# ...
packages = [
    { include = "my_package" },
    { include = "tests", format = "sdist" },
]

This should fix #1067 and #1109

Can it specify files exclude in certain format?


Tidy build

Thanks for the PR. But I'd like to keep those warnings because some code is temporary unused.

The layout of the changes was intentionally so that it was easy to revert at a later stage when this feature will be re-instated.


Raise supported Opencast version

We should talk about the exact scheme of Opencast versions releases of this tool should support, but what seems very clear to me is that that scheme does not start at 2.3 anymore. And it probably should not start at < 5.0, either, so that we can finally get rid of artifactPrefix option.

Oh thanks for getting rid of this :D
I would opt for only supporting the currently maintained Opencast versions. At the moment, that would mean the last two (7.x and 6.x).

Yes, that was my thinking as well. My proposal would be:
There will be one supported release of the Annotation Tool, and the develop version, where "supported" means "gets bug and security fixes". So kind of like Opencast itself, but with fewer versions, since we simply don't have the capacity for anything more.
Both versions of the tool, i.e. the current release and develop should probably support all currently supported Opencast versions. In detail: Say Annotation Tool 2.0 is released when the supported Opencast versions are 6 and 7. Then AT 2.0 should support these (and potentially develop?). If Opencast then moves on to only support 7 and 8, then AT 2.x should also drop support for 6, and only support 7 and 8. Same for develop.
As for the release cycle: I don't think a regular release makes sense for this tool at this moment. I think we can all just coordinate that as needed/when it makes sense.

I agree with this change, today we use Opencast only. and this will ease the setup to many other adopters.

@JulianKniephoff sounds good although I would not express a support of develop explicitly.


Feat/lw 11778 dapp collateral popup not open when no impure utxo

Checklist

[x] JIRA - <link>
[ ] Proper tests implemented
[ ] Screenshots added.

Proposed solution
Lace currently returns NULL if a dApp request the collateral UTXOs but the wallet does not have any "only ADA" UTXOS. This change makes it so Lace now ask the user to create said collateral UTXO if the wallet has enough balance.

Allure Report
allure-report-publisher generated test report!

processReports: ❌ test report for 87c29b33

passed
failed
skipped
flaky
total
result

Total
31
1
4
0
36
❌


[TEST] AWS with flatcar

What this PR does / why we need it:
Which issue(s) this PR fixes:

Fixes #
What type of PR is this?

Special notes for your reviewer:
Does this PR introduce a user-facing change? Then add your Release Note here:

Documentation:

/test pull-kubeone-e2e-aws-flatcar-install-containerd-v1.26.1
/test pull-kubeone-e2e-aws-flatcar-legacy-machine-controller-containerd-v1.26.1
/test pull-kubeone-e2e-aws-flatcar-install-containerd-external-v1.26.1
/test pull-kubeone-e2e-aws-flatcar-legacy-machine-controller-containerd-external-v1.26.1
/test pull-kubeone-e2e-aws-flatcar-install-containerd-v1.25.6
/test pull-kubeone-e2e-aws-flatcar-legacy-machine-controller-containerd-v1.25.6


About video fragments

Hi thanks for providing the code of your work. In the code what is the video_fragment. Is it for the breakpoint mode? How to create these fragments? Also in the src/video_fragment, you have provided a clip from a different video (GOT) than the Cooking_cake one.

video_fragment stores the video clip read by the sliding window, and it will be created and automatically updated. Also I didn't find  the GOT  video, can u point out the exact path? We didn't upload Cooking_cake since it is too big to upload on Github.

Thanks for the reply. The cooking_cake video I got from the link provided in 15th issue. The GOT video is src/video_fragment/output.mp4

You just need to choose one video as the initialized video fragment at the beginning, and the others video fragments will be created automatically.

Thanks for the reply. I used the MovieChat package in PyPI (version 0.6.3), and I carefully checked the code in the package.
In  /anaconda/envs/MovieChat/lib/python3.9/site-packages/MovieChat/models/chat_model.py:
for i in range(num_frames):
    print(f"current processed frames: {i+1} / {num_frames}")
    video_fragment = self.parse_video_fragment(video_path=video_path, video_length=video_length, n_stage=i)
    video_fragment, msg = self.load_video(
        video_path=fragment_video_path,
        n_frms=4,
        height=224,
        width=224
    )
    video_fragment = self.vis_processor.transform(video_fragment)
    video_fragment = video_fragment.unsqueeze(0).to(self.device)

where the function self.parse_video_fragment() is used for create the video fragment, then the next function 'self.load_video()' can be able to read the video fragment in from fragment_video_path. But it can be seen from here that function self.parse_video_fragment() should save the video fragment locally.
Now take a look at the self.parse_video_fragment() function:
def parse_video_fragment(self, video_path, fragment_video_path, video_length, n_stage = 0):
    decord.bridge.set_bridge("torch")
    per_video_length = video_length / self.n_samples
    fragment_video = self.capture_video(video_path, per_video_length, n_stage)
    fragment_video.write_videofile(fragment_video_path)  # This code was added by me
    return fragment_video

Thank you very much for discovering this issue. We will recheck our code and update the MovieChat package as soon as possible to resolve this problem.

for i in range(num_frames):
print(f"current processed frames: {i+1} / {num_frames}")
video_fragment = self.parse_video_fragment(video_path=video_path, video_length=video_length, n_stage=i)
video_fragment, msg = self.load_video(
video_path=fragment_video_path,
n_frms=4,
height=224,
width=224
)
video_fragment = self.vis_processor.transform(video_fragment)
video_fragment = video_fragment.unsqueeze(0).to(self.device)
I noticed that the video_fragment variable is assigned a value in line 3, but then immediately overwritten in line 4. It seems like the assignment in line 3 might be redundant since its value is not used before it's reassigned.

I understand what you mean. During implementation, we found that some versions of ffmpeg may not support initializing a blank video fragment, so we used an unrelated video clip for initialization.

@HTD1016 You are just amazing!!!

video_fragment stores the video clip read by the sliding window, and it will be created and automatically updated. Also I didn't find the GOT video, can u point out the exact path? We didn't upload Cooking_cake since it is too big to upload on Github.

Hi, I have two little questions for these two hyperparameters in run_inference_qa_msvd.py:
MAX_INT = 8 N_SAMPLES = 32
According to my understanding, does the N_SAMPLES  specify how many fragments (or sliding windows) will be created for each video, and the MAX_INT specify how many frames we will use for encoding as LLM input for each fragment/sliding window?

Sorry for the confusion. N_SAMPLES specifies how many fragments (or sliding windows) will be created for each video. However, MAX_INT is not utilized in the current implementation. In our code, the number of frames included within each sliding window corresponds to the length of the short-term memory window used for encoding.


The problem is a missing adoption of https://github.com/Microsoft/vscode/issues/3161. I've create a PR to address this: https://github.com/Microsoft/vscode-go/pull/258


Modificatons for SFC security group binding service, APIs and list r…

…espponse.

corrected the indentation


Just a thanks!

I just wanted to thank you for all your efforts.  2K wired doorbell plus two 2C cameras all working well with the latest release.

Thanks for feedback, enjoy

I can confirm, it is working for my 2K wired doorbell too. However, after installing this custom_integration, the HA server when I restart, stucks at the message, "Home Assistant is starting, not everything will be available until it is finished."
If I disable the integration and restart, it boots up fine. Not much in the log for help, except an error for "demuxing stream"

I am having a similar issue about initial startup. Can you share your live stream delay?

Seeing the same, here is one error from startup:
2021-08-04 23:39:07 ERROR (MainThread) [homeassistant] Error doing job: Task exception was never retrieved
Traceback (most recent call last):
File "/config/custom_components/eufy_security/camera.py", line 317, in async_start_rtsp
dummy = self.state
File "/config/custom_components/eufy_security/camera.py", line 209, in state
self.set_is_streaming()
File "/config/custom_components/eufy_security/camera.py", line 246, in set_is_streaming
async_call_later(self.hass, 0, self.state_changed)
File "/usr/src/homeassistant/homeassistant/helpers/event.py", line 1223, in async_call_later
return async_track_point_in_utc_time(hass, action, dt_util.utcnow() + delay)
File "/usr/src/homeassistant/homeassistant/helpers/event.py", line 1199, in async_track_point_in_utc_time
cancel_callback = hass.loop.call_later(delta, run_action, job)
AttributeError: 'NoneType' object has no attribute 'loop'

@Jellyfrog i believe you had enabled preload stream, is that correct?

@Jellyfrog i believe you had enabled preload stream, is that correct?

No idea what that is. Cannot find anything about it?

In video streaming window inside home assistant, there is a checkbox in top right, can you check if it is enabled for any of cameras?

In video streaming window inside home assistant, there is a checkbox in top right, can you check if it is enabled for any of cameras?

Have no such window as far as I know. I did disable all enitys for this plugin. Only need to control on/off really. Which this plugin is a bit overkill for :) but that's for another ticket.


feat: remove support for creating key protect resources

Description

remove direct support for creating key protect instance / key rings / keys from this module (use https://github.com/terraform-ibm-modules/terraform-ibm-key-protect-all-inclusive directly going forward). This will be a major version change due to the may variables that have been removed, and change of outputs

docs:

update usage to match changes

Check the relevant boxes:

[x] Bug fix (nonbreaking change that fixes an issue)
[x] New feature (nonbreaking change that adds functionality)
[x] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[x] Examples or tests (addition or updates of examples or tests)
[x] Documentation update
[x] CI related update (pipeline, etc.)

Checklist

[ ] If relevant, a test for the change has been added or updated as part of this PR.
[ ] If relevant, documentation for the change has been added or updated as part of this PR.

Merge

Merge using "Squash and merge".
Make sure to use a relevant conventional commit message that is based on the PR contents. The commit message determines whether a new version of the modules needs to be released, and if so, which semver number to use).

:tada: This PR is included in version 5.0.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


lab: 0.19.0 -> 0.20.0, add SuperSandro2000 as maintainer

Motivation for this change
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[ ] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[ ] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 114139 at 3c1787c2 run on aarch64-linux 1

1 package built:

lab


Feature: New Check "Criticality and Maturity"

New check/s: Criticality & Maturity?
For some quick context, my use-case for ossf/scorecard is to quickly get some information about a repo I've never seen before, to help make a decision about relative risk, and it's suitability for inclusion into projects. One class of repo that I've noticed tends to score fairly poorly are repositories like https://github.com/gkz/type-check. These are repos that I think are characterized by being fairly mature, and highly depended upon; the example repo has very few recent commits, 2 contributors, and lists ~17.8 million dependents. This means it also scores fairly poorly on the contributors and commits checks.
If I were to manually review this repository, I think I would deem it acceptable for use, on the basis that ~17.8 million others have reached the same conclusion. Additionally, I have some level of assurance that if something malicious happens to this repo in the future, there is a high probability it will be noticed. I understand that the low number of commits and contributors doesn't necessarily mean this project is 'unhealthy' per se, I think it's more accurate to say it's 'done'.
I'm not sure about the specifics, and I'm not necessarily convinced it makes sense to bundle these concepts of criticality and maturity into the same check, but I think a check/s that somehow captured these judgements might be useful.

I'm not sure if Scorecard is the best tool for this. It might be a good data point if we want to migrate Scorecard to a "one-stop-shop" for various types of package metadata, but it's hard to come up with a good heuristic to distinguish an abandoned project from one that's simply mature/feature-complete.
Something that may be useful for you is another OpenSSF tool: https://github.com/ossf/criticality_score. It calculates a "criticality score" for a given repository using a bunch of heuristics.
It had a cronjob that automatically scanned ~1M repos and made their scores available via BigQuery. They disabled the cronjob a year ago for some reason, but the data is still available. In the particular case of gkz/type-check you mentioned, it had a criticality_score of 0.52, which ranked it among the 28k highest-scoring projects (i.e. top 3% of projects) at the time.

To help get a better idea, how would you measure project maturity, and how would you distinguish maturity from inactivity/abandonment?

This means it also scores fairly poorly on the contributors and commits checks.

This shortcoming of the Maintained check and mature projects has been brought up before. Any heuristic is going to have edge cases when you consider millions of repos. Really the check looks at "Activity", not whether or not the project is maintained.

Something that may be useful for you is another OpenSSF tool: https://github.com/ossf/criticality_score. It calculates a "criticality score" for a given repository using a bunch of heuristics.

+1 to what Pedro said. Criticality Score is likely what you want?

They disabled the cronjob a year ago for some reason

Caleb is working on getting it going again. There were some technical reasons, partially around token search quota and GCP pub/sub retention time that limited the project's ability to finish.

I'm not necessarily convinced they need to be the same check. Maybe adding a check based on criticality_score would be enough, and users could decide for themselves if a highly depended upon project that was not being actively maintained was risky or not.


Is there some kind of priority between health check and outlier detection

I've known how health check works independently and how outlier detection works independently. But if I configure both of them together, I don't know how they would work together.
If an endpoint is ejected by outlier detection but it is still marked healthy by health check, what would happen? Will it be marked unhealthy immediately in terms of health check? Will the requests of health check continue being sent to it? If it is marked unhealthy by outlier detection but is marked healthy by health check, what would happen?
If an ejected endpoint by outlier detection should rejoin into the cluster in terms of outlier detection but it is marked unhealthy by health check, what would happen? Does it mean that requests of downstream couldn't be routed to it until it is marked healthy? If so, it seems that the endpoint has to wait max(outlier_detection.interval, health_check.interval * health_check.healthy_threshold)?
In a word, both of outlier detection and health check can eject/rejoin an endpoint from/into a cluster, but I'm confused by them because as my understanding, they may make opposite decisions and they may set different time-relative configurations. In these cases, which mechanism has the higher priority?
In the doc https://www.envoyproxy.io/docs/envoy/latest/intro/arch_overview/upstream/outlier, it says,

An ejected host will automatically be brought back into service after the ejection time has been satisfied. Generally, outlier detection is used alongside active health checking for a comprehensive health checking solution.

But for me it's kind of hard to use them together...

https://www.envoyproxy.io/docs/envoy/v1.28.0/intro/arch_overview/upstream/outlier.html#grpc - If both are enabled, a successful health check will uneject the host - This is the the only dependency when both are enabled


TypeError: conv2d() received an invalid combination of arguments

I am trying to implement using the same code and same dataset but it shows an error as I am new to this. Please anyone can help.

Same here


[FEATURE] make changes in the readme files

Description
the readme file is quite simple and basic, i will make it more attractive
Screenshots
No response
Additional information
No response

@anshulsoni4  can you work on other issues please

@anshulsoni4 hey , actually currently we focusing on most priority and important things


Upgrade to Jasmine 3.3.0

Feature Request
It would be great to upgrade to Jasmine 3.3.0.
There's already an issue https://github.com/angular/protractor/issues/4788 and a PR https://github.com/angular/protractor/pull/4842 to upgrade to 3.1.0, but 3.3.0 has some new features including Expectation.withContext() function, which would be a very useful thing for e2e tests.

I will look into this. I want to use a matching version of Jasmine supported internally as well.

Tagging this issue as kinda related: https://github.com/jasmine/jasmine/issues/1522

I changed the title of the PR. I think this is the step in the right direction to getting us to 3.3

Could this fix https://github.com/angular/protractor/issues/3234 ? I have no idea.... fingers crossed. I have two days and a dream to get this done.

Closed with https://github.com/angular/protractor/pull/5102

Cool, thank you!
Looking forward to the new protractor release supporting Jasmine 3.3.0!

What framework are you supposed to use with this? jasmine3 is not a valid framework.

This PR was to go into the selenium-webdriver 4 upgrade. This is being held back and will be released in coordination with the Angular team. Jasmine 3 I believe is a valid testing framework.

Looking forward to the new protractor release supporting Jasmine 3.3.0!

Any updates about supporting Jasmine 3.3.0?

Any updates?

any updates?

any updates?

This depends on the next release of v6-ish.
Related PR https://github.com/angular/protractor/pull/5516


feat!: moving compute_selector to FunctionSelector

Fixes #3681
Checklist:
Remove the checklist to signal you've completed it. Enable auto-merge if the PR is ready to merge.

[ ] If the pull request requires a cryptography review (e.g. cryptographic algorithm implementations) I have added the 'crypto' tag.
[ ] I have reviewed my diff in github, line by line and removed unexpected formatting changes, testing logs, or commented-out code.
[ ] Every change is related to the PR description.
[ ] I have linked this pull request to relevant issues (if any exist).

Benchmark results
No metrics with a significant change found.

Detailed results
All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call  to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.
This benchmark source data is available in JSON format on S3 here.
Values are compared against data from master at commit 3030cc8a and shown if the difference exceeds 1%.
L2 block published to L1
Each column represents the number of txs on an L2 block published to L1.

Metric
8 txs
32 txs
128 txs

l1_rollup_calldata_size_in_bytes
45,444
179,588
716,132

l1_rollup_calldata_gas
223,020
868,316
3,449,912

l1_rollup_execution_gas
867,129
3,746,369
23,306,677

l2_block_processing_time_in_ms
1,324 (-2%)
5,118
21,168 (+1%)

note_successful_decrypting_time_in_ms
338 (-3%)
1,283 (+2%)
3,899 (+4%)

note_trial_decrypting_time_in_ms
48.8 (-19%)
36.4 (+4%)
139 (+3%)

l2_block_building_time_in_ms
13,998 (-1%)
55,619
224,984

l2_block_rollup_simulation_time_in_ms
10,455
41,663
168,357

l2_block_public_tx_process_time_in_ms
3,519 (-2%)
13,907 (-1%)
56,455 (+1%)

L2 chain processing
Each column represents the number of blocks on the L2 chain where each block has 16 txs.

Metric
5 blocks
10 blocks

node_history_sync_time_in_ms
15,245 (-1%)
28,899 (-1%)

note_history_successful_decrypting_time_in_ms
2,576 (-1%)
5,018 (-6%)

note_history_trial_decrypting_time_in_ms
83.8 (+6%)
148 (-5%)

node_database_size_in_bytes
3,620,574
3,728,231

pxe_database_size_in_bytes
29,923
59,478

Circuits stats
Stats on running time and I/O sizes collected for every circuit run across all benchmarks.

Circuit
circuit_simulation_time_in_ms
circuit_input_size_in_bytes
circuit_output_size_in_bytes

private-kernel-init
200
43,109
20,441

private-kernel-ordering
115
25,833
9,689

base-rollup
1,062
123,254
881

root-rollup
82.4 (-1%)
4,088
889

private-kernel-inner
261
64,516
20,441

public-kernel-private-input
172
25,203
20,441

public-kernel-non-first-iteration
171
25,245
20,441

merge-rollup
9.70 (-1%)
2,608
881

Miscellaneous
Transaction sizes based on how many contracts are deployed in the tx.

Metric
0 deployed contracts
1 deployed contracts

tx_size_in_bytes
10,331
26,317


Skip blank zipformer

Hi all,
This PR is to support CTC Skip Blank in Triton Python for Zipformer Offline with greedy search.
Have tested the audio wav, which can be recognized correctly.
Thanks!

@wd929
Thanks! Is it ready for merge?

Yes. Thanks!

Thanks!


Share generator blocklist with yo and the website

Currently it's duplicated.
Put it in a JSON file on yeoman/yeoman.io and have the website and yo use it.

[ ] website: https://github.com/yeoman/yeoman.io/blob/1d3a9c8b77ee88d6c98f92e48dec534723414990/app/assets/js/script.js#L39-L47
[ ] yo: https://github.com/yeoman/yo/commit/681bf11ee5619fd76a093abb04a660784a835d96

i think a better solution is to remove the blocklist and have those packages updated

I think both. From experience with the gulp blocklist it's hard to get random people to fix their package. Easier to block first and have them fix it later (usually never happens anyways).

I think I want to work on this, can I get this one assigned to myself?

@ankurkaushal just send a PR.
We usually assign only when someone of the core team is working on it for a long time to let people know this is being worked on.

Sure thing! Thanks for letting me know.

I'm working on this see https://github.com/gaboesquivel/yo/blob/blacklist/lib/routes/install.js
let me know your thoughts, is q ok or you prefer http?   how to handle error on blacklist request? use empty object or callback(err) ?
list can be mocked with nock, however can you make it a separate file to test with real response?  https://github.com/yeoman/yo/pull/290

let me know your thoughts, is q ok or you prefer http?

https://github.com/gaboesquivel/yo/commit/b87dbf7e384be6efe486ee8a5708bd4c65252e71#commitcomment-9538657

how to handle error on blacklist request? use empty object or callback(err) ?

Empty object.

@sindresorhus I think this issue can be closed now


More geometric tools for Manim

I think we should have more geometric tools to makes the construction of geometry figures easier. With the current tools, it's hard and exhausted to construct anything involved with tangent or perpendicular stuff as you have to calculate the tangent vectors yourself. With the aim to reduce the construction time and makes it easier for Manim user to construct a geometry figure, I suggest adding some more tools as follow:

Perpendicular tools:

Perpendicular line from a point to a line: given a point and a line; return the line that connects that point and its projection on the line.
Perpendicular line from a point to a plane: given a point and a plane; return the line that goes through the point and perpendicular to the plane.
Perpendicular plane from a point to a line: given a point and a line; return the plane that goes through the point and perpendicular to the line.

Parallel tools:

Parallel line from a point to a line: given a point and a line; return the line that goes through the point and parallel to the line.
Parallel line from a point to a plane: given a point and a plane; return the line that goes through the point and parallel to the plane.
Parallel plane from a point to a plane: given a point and a plane; return the plane that goes through the point and parallel to the given plane.

Bisector tools:

Angle bisector of two lines: Given two lines; return the angle bisector of the two lines.
Perpendicular bisector of a segment (lines with put_start_and_end_on in Manim language): given a segment; return the perpendicular bisector of that segment.

Tangent tools:

Tangent line from a point to a parametric curve: given a parametric curve and a point lies on it; return the tangent lines at that point of the parametric curve.
Tangent plane from a point to a parametric surface: given a parametric surface and a point lies on it; return the tangent plane
Then we can have a similar tangent tool for circle and sphere maybe?

Some advanced tools we can talk about are the intersection between two parametric curves or surfaces.

#1798


https://www.googleapis.com/discovery/v1/apis/analytics/v4/rest is returning 404ing and causing services that use the discovery module to fail

https://www.googleapis.com/discovery/v1/apis/analytics/v4/rest
Environment details

OS: Ubuntu
Python version: 3.6.7
pip version: 19.1.1
google-api-python-client version: 1.7.8

Steps to reproduce

Perform a GET request to https://www.googleapis.com/discovery/v1/apis/analytics/v4/rest
Profit.

I can confirm the 404.

Hi @blairg23! Do you know if there was a v4 previously, and when this started to 404? Is it possible you want to use the Analytics Reporting API rather than the Google Analytics API?
See discovery document.
analytics versions:
v2.4preprod, v3alphapreprod, v3preprod, v2.4, v3
analyticsreporting versions:
v4

You are correct, we are using the Analytics Reporting API v4.

In that case it looks like the restUrl is now https://analyticsreporting.googleapis.com/$discovery/rest?version=v4. That may be a recent change.

We're using the from googleapiclient.discovery import build to build the Analytics API service. From there, you can see the following:
DISCOVERY_URI = ('https://www.googleapis.com/discovery/v1/apis/'
                 '{api}/{apiVersion}/rest')
V1_DISCOVERY_URI = DISCOVERY_URI
V2_DISCOVERY_URI = ('https://{api}.googleapis.com/$discovery/rest?'
                    'version={apiVersion}')

This was our working code that is no longer working:
def _build_analytics_api(self, version=4):
     """Builds the Google Analytics Api connection."""

     credentials = client.OAuth2Credentials(
         client_id=self._client_id,
         client_secret=self._client_secret,
         access_token=self._access_token,
         refresh_token=self._refresh_token,
         token_expiry=time.time() - 10,
         token_uri=GOOGLE_TOKEN_URI,
         user_agent='tomis',
     )
     http_client = httplib2.Http()
     credentials.refresh(http_client)
     credentials.authorize(http_client)

     return build('analytics', f'v{version}', http=http_client)

@blairg23 when did this start to 404 for you?

It looks like the v4 has a separate name ('analyticsreporting' instead of 'analytics'). I unfortunately don't have much context on the change.
Please use the name 'analyticsreporting' to build the service if you're using the v4.

Today, first event appears to be Jul 10, 2019 9:31:34 PM UTC

Can confirm: https://www.googleapis.com/discovery/v1/apis/analyticsreporting/v4/rest is working. Unsure why the old URL used to be working... will change code and test.

My theory is this bug originated due to old Analytics documentation that had that analytics build example in it that was copy/pasta'd into our code and just happened to work for a year and a half due to a coincidental bug that allowed the old URL to function with https://www.googleapis.com/discovery/v1/apis/analytics/v4/rest instead of https://www.googleapis.com/discovery/v1/apis/analyticsreporting/v4/rest
My guess is that once Google discovered the bug, they patched it, causing the 404 to start just by happenchance today. It does not appear to be a bug in google-api-python-client.

Hi @blairg23 Thanks for working through this and happy you have been unblocked.
Can I confirm that this did work before? If so, do you have an idea of how long? Just making sure to gather details while it is still fresh on your mind.
Thanks!

I just stumbled upon this.
I can confirm this worked before, used it since at least april 2017.
The quick start documentation is a little confusing. It uses build('analytics', 'v4') but overrides the discovery URL so the serviceName paramter of build has no effect.

@CerealP0rt
Thank you for taking the time to comment! I filed an issue on the team that maintains that quickstart. For anyone stumbling on this issue, please do:
from googleapiclient import discovery

service = discovery.build('analyticsreporting', 'v4')


CI: use components for rustfmt/clippy

Why is this not a problem for gtk-rs?

because @MarijnS95 already did that yesterday :-)

I thought @bilelmoussaoui was on the GTK4 case :)
https://github.com/gtk-rs/gtk-rs/pull/485 for reference. @bilelmoussaoui You might at least use the same justification in your commit :)

I thought @bilelmoussaoui was on the GTK4 case :)

gtk-rs/gtk-rs#485 for reference. @bilelmoussaoui You might at least use the same justification in your commit :)

It just took me a bit of time :p

Hehe no hurry, I thought you were on the case after mentioning something like that but it could have just as well meant something along the lines of "sure, sounds nice, feel free to PR" :grimacing:. But it's all taken care of now :smile:


scrub: also create a media-type scrub method instead of just repo

Is your feature request related to a problem? Please describe.
As we add more media-types (now we also support manifest index which is a container of images), it needs to be scrubbed differently.
Describe the solution you'd like
foreach manifest in a repo:
switch manifest.mediaType:
case ImageManifest: // we already support this
case ImageIndex: // unpack the manifest, iterate over each manifest and scrub them, this is NEW
case ArtifactType: // something else, this is future

Related to issue https://github.com/project-zot/zot/issues/640

The image index case was covered in https://github.com/project-zot/zot/pull/1031.
The artifact case is postponed for now.

Since the artifact manifest was removed, the only remaining requirement is to also take the image manifest 'Subject' into consideration when running scrub.

Done in https://github.com/project-zot/zot/pull/1845


Vertical Scroll For EPUB files

Type of reader (if reader related)
None
Description of the new feature / enhancement
Menu in images

Menu in EPUB's

Scenario when this would be used?
No response
Supporting information
No response

Vertical Scroll is already used for EPUBs.

But i need to use A and D key arrows for passing another page in Epubs

another page in Epubs

That is for chapters.
There is vertical scroll mode and can be enabled in settings, but I have not optimized it yet, so it will take high resources depending on the epub.
Disable this to for pure vertical scroll Settings -> Other settings -> EPUB: Load by chapters


Major performance improvements

Based on results of config profiling at https://github.com/silverstripe/silverstripe-admin/issues/199 I've made the following improvements to cut down uncessary config API calls:

i18n.default_locale was invoked a huge amount of times. This change reduces overall page load by about 20ms in the CMS
Extension construction being done excessively caused a massive amount of performance degradation, especially with 4 times the DBField's being constructed due to default_cast changes
Stopped merging in config from Extension and DataExtension which provide no config worth merging in.

load times of admin/pages/
Before:

After:

@sminnee I've re-worked both extensions and now neither defineMethods() nor constructExtensions() are invoked at all on object construction. These are now safely lazy-loaded.
As a result I can drop the objects_constructed private property, and rely on lazy loading to bootstrap these objects.

All good from me.

It's green, can it be merged?


Could not resolve hostname : Name or service not known

i have done setup. and also update ddclient.
and no any error.
but after that i am ping mine created subdomain that is not ping or ssh.
i have also done port forwarding in my router port 80 and 22.
getting below error.
Could not resolve hostname : Name or service not known
i have setup my ddns server on cloud with static ip with hostname .

Hey, can you give me some details on how you set this up on your side?

hello @dprandzioch
here i have attached screenshot of my cloud server.
that  server route53  i have set on aws.
now i am doing ssh on that server and setup  your docker ddns server.
ZONE=growth.recipes
Name = mymachine
let me know if anything is wrong.

hey @dprandzioch
can u u help me to fix it above issue ?
Thanks

Dear @dprandzioch
hope you are doing good.
I too have same issue.
I have setup docker-ddns container as per instructions and I was able to run API. Below are the images for reference

API Result:

docker-ddns logs:

I have updated domain records as follows:

But when we try to ping the domain recreated using API, it is not getting resolved

Can you please help us in fixing this issue and make our DynDns work... Thank you in advance!


fix check for PLUG_SUPPORT environment variable

needs testing
#41

just kidding it was already fixed in f907cb09107af0088e7eebb3e31cc421429c8922.


The current notebook creation process in vs studio code is not user-friendly

Whenever I create a new workbook locally or download an existing fabric notebook in synapse, it completely ignores any workspace already opened in vs studio code and opens the new notebook workspace in vscode.
This is extremely inconvenient, because I want to keep working on my current workspace, without the change of context. Is there a way to work around this? In my opinion, the notebook directory should be added to the current workspace, or the action should be cancelled altogether if the current workspace already includes the notebook directory (for example, the parent directory of the notebook directory is already open in vscode).

Agree, it is a pain that we can't navigate back to the original workspace


Add ValueError for plot_model is called before model is built

Please go to TF Forum for help and support:
https://discuss.tensorflow.org/tag/keras
If you open a GitHub issue, here is our policy:
It must be a bug, a feature request, or a significant problem with the documentation (for small docs fixes please send a PR instead).
The form below must be filled out.
Here's why we have that policy:.
Keras developers respond to issues. We want to focus on work that benefits the whole community, e.g., fixing bugs and adding features. Support only helps individuals. GitHub also notifies thousands of people when issues are filed. We want them to see you communicating an interesting problem, rather than being redirected to Stack Overflow.
System information.

Have I written custom code (as opposed to using a stock example script provided in Keras): No
OS Platform and Distribution (e.g., Linux Ubuntu 16.04): Ubuntu 20.04
TensorFlow installed from (source or binary): source
TensorFlow version (use command below): 2.4.3
Python version: 3.7.10
Bazel version (if compiling from source):
GPU model and memory:
Exact command to reproduce:

You can collect some of this information using our environment capture script:
https://github.com/tensorflow/tensorflow/tree/master/tools/tf_env_collect.sh
You can obtain the TensorFlow version with:
python -c "import tensorflow as tf; print(tf.version.GIT_VERSION, tf.version.VERSION)"
Describe the problem.
The value error is not there for the plot_model when plot_model is called before the model is built.
If I run the given code:
import keras
model = keras.Sequential()
keras.utils.plot_model(model, show_shapes = True)

It gives the following result:

But it should work similarly to the model.summary() where such model provides a value error when the summary is called before building.
Contributing.

Do you want to contribute a PR? (yes/no): Yes
If yes, please read this page for instructions
Briefly describe your candidate solution(if contributing): Adding a similar value error in the plot_model code.

@krishrustagi Could you please refer to the link and similar issue .Please let us know if it helps ?Thank you!

@sushreebarsa The problem I am talking about is different. When I write model.summary() for the model stated in my previous comment, it gives a ValueError stating about building the model first and then call the summary function, but plot_model doesn't show such type of error and directly prints the empty model name.

@krishrustagi Thank you for the update!
In order to expedite the trouble-shooting process, please provide a code snippet to reproduce the issue reported here. Thanks!

I was thinking of adding
if model.built:
    raise ValueError('This model has not yet been built. '
                       'Build the model first by calling `build()` or calling '
                       '`fit()` with some data, or specify '
                       'an `input_shape` argument in the first layer(s) for '
                       'automatic build.')

in the plot_model function, so that if it is called and has not been built, then it will raise a ValueError.


Translation of Title

Just a simple question. If the module has translation, can the title be "not translatable"?

Hey @Equruler,
When you create a new CMS module by using the twill:module command, you'll find a commented piece of code in the Model as:
    // uncomment and modify this as needed if you use the HasTranslation trait
    // public $translatedAttributes = [
    //     'title',
    //     'description',
    //     'active',
    // ];

As the instruction states you only need to uncomment that snippet and remove the title from that array.
Keep in mind that the migration should reflect this change, e.g.:
in the migration you'll have to modify the creation of the translation table from
        Schema::create('<your_model>_translations', function (Blueprint $table) {
            createDefaultTranslationsTableFields($table, 'setting');
            $table->text('title')->nullable();
            $table->text('description')->nullable();
            ...
        });

to
        Schema::create('<your_model>_translations', function (Blueprint $table) {
            createDefaultTranslationsTableFields($table, 'setting');

            $table->text('description')->nullable();
            ...
        });

by moving the $table->text('title')->nullable(); from the translation table to the main table.
I hope this helps.

Hi @Equruler!
Thanks for answering here @sauron :)
This only part I think is missing is that when a module is translatable the views of that module need to know that the title is not to be translated by using "translateTitle" => false from formData or the Blade @extend directive in the module's form.blade.php file.

#532 which was merged earlier today makes this automatically handled for you, check out @antonioribeiro's PR description.


Add snippets for adding fallback route to  routes.json

Hi @johnpapa
Could you give me some more details about what the feature request is?  I'm not really sure what this entails.

Sure.  The routes.json file is in our docs at https://aka.ms/swadocs
We can add a fallback route to this array. The fallback will catch 404 server errors and serve the index.html, commonly.
I could provide the snippet if it is helpful.

Yes, the snippet would be helpful 😄
My experience with SWA is still pretty limited so any bigger examples beyond the ReactSite repo would also be greatly appreciated!

Here you go. Sorry for the delay
	"SWA Fallback Routes": {
		"prefix": "swa-fallback",
		"body": [
			"{$0",
			"\t\"routes\": [",
			"\t\t{",
			"\t\t\t\"route\": \"/*\",",
			"\t\t\t\"serve\": \"/index.html\",",
			"\t\t\t\"statusCode\": 200",
			"\t\t}",
			"\t]",
			"}",
		]
	},

Hi Team,
My reactjs app is deployed in Azure Static Web App(preview).
My website url : www.example.com shows all images render properly from public folder.
From home page, if user navigate to https://www.example.com/nextpage/page1 then still it shows all the images properly.
But if user, refresh or navigate to https://www.example.com/nextpage/page1 directly then images are not rendered, gives 404 error.
my routes.json file in public folder looks like below
{
"routes": [
{
"route": "/*",
"serve": "/index.html",
"statusCode": 200
}
]
}
Appreciate your help.

@aartigh can you please file an issue at https://github.com/Azure/static-web-apps/issues ?
Please include info on how the img tag is formed and the error in your browser dev tools. If you have a live site that is public and we can troubleshoot, please include that too. Thanks!

@anthonychu thanks, if you access https://www.skillsandautomation.com/blog/B1 url directly, you can see image at top left not rendered, gives 404 error in dev tool. Whereas if we access the https://www.skillsandautomation.com, image at top left is rendered correctly.

@anthonychu my issue is resolved, i have change way of specifying that image path.

@nturinski @wwlorey I think this is covered by https://github.com/SchemaStore/schemastore/pull/1551, which adds example snippets for fallback and other sections, intellisense, and validation:

Regarding staticwebapp.config.json vs routes.json, we're recommended folks use staticwebapp.config.json, so I don't think we need to do much more for routes.json.


bump github actions versions

Description of changes:
Bumping versions of actions used to resolve deprecation warnings
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Codecov Report

Merging #473 (dfcec72) into main (858a4cf) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #473   +/-   ##
=======================================
  Coverage   69.74%   69.74%
=======================================
  Files          21       21
  Lines        1203     1203
=======================================
  Hits          839      839
  Misses        297      297
  Partials       67       67

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Add a New Entitlement to Your Subaccount

Tutorials: https://developers.sap.com/tutorials/cp-cf-entitlements-add.html
Seems like a typo in Select the tile -> title

Hi,
thanks for providing feedback. Actually, this is not a typo. I meant the tile that has the title "Trial"
https://www.pinterest.com/lbroumand/tile-based-ux-design/


Typescript controllers are not found

Hello !
Controllers written in TS are not listed in the data-controller="" auto-completion. Looking at the source code, it seems that only files ending with _controller.js or -controller.js are included in getAllControllers.
I don't have any knowledge of Kotlin to suggest a pull request, unfortunately...

Juste created a simple PR here : #15


URL Cleanup

This commit updates URLs to prefer the https protocol. Redirects are not followed to avoid accidentally expanding intentionally shortened URLs (i.e. if using a URL shortener).
Fixed URLs
Fixed But Review Recommended
These URLs were fixed, but the https status was not OK. However, the https status was the same as the http request or http redirected to an https URL, so they were migrated. Your review is recommended.

[ ] http://aLinkToSomething (UnknownHostException) with 1 occurrences migrated to:
https://aLinkToSomething (https result UnknownHostException).

Fixed Success
These URLs were switched to an https URL with a 2xx status. While the status was successful, your review is still recommended.

[ ] http://creativecommons.org/licenses/by-nd/3.0/ with 1 occurrences migrated to:
https://creativecommons.org/licenses/by-nd/3.0/ (https result 200).
[ ] http://docs.spring.io/spring-boot/docs/ with 1 occurrences migrated to:
https://docs.spring.io/spring-boot/docs/ (https result 200).

Ignored
These URLs were intentionally ignored.

http://localhost:8080 with 1 occurrences
http://localhost:8080/hello with 2 occurrences

Merged in 653f795


refactor: use languages associations replace mime service

Types
Background or solution
Changelog

use languages associations replace mime service

+1


component testing

Some of  our basic components are in desperate need of good integration testing.
Of these:

config manager:
ensure saving of an instance gets saved correctly in zdb
indices are correctly set
encrypted values are in encrypted in backend
can retrieve any instance
can find any instance based on the indexing
jinja code generation:
we generate a lot of code using jinja. We need to be sure the code generated is exactly what we intend.
check the templates
gedis:
to be defined

To be added to as we go along

➤ Christophe de Carvalho commented:
I ported all my work regarding gedis from 9.6.0 version to digitalmeX: https://github.com/threefoldtech/digitalmeX/commit/bca144b4f0fe25ad3588451d80c64a074673e9a0
This include a beginning of some testing for gedis there.
This only covers super basic flows. We need to add more testing:

[ ] test all the possible serialization format
[ ] using schema_in, schema_out:
[x] using list of objects: https://github.com/threefoldtech/digitalmeX/commit/73e7ea6806304722ab22bdb05c4abcd33a63e38c
[ ] schema define in doc strings
[ ] .... I probably forget a lot

➤ kristof de spiegeleer commented:
branch: development_builders

➤ Islam Taha commented:
I'm gonna test the config manager

Test all possible clients get actions


Support SQLite

It is possible extending Flutter Data to use SQLite? More precisely sqfentity  (https://pub.dev/packages/sqfentity#-readme-tab-).

Having SQLite as local backend is something I definitely want to do (once we have async relationships). Not sqfentity.

I'm not pro in Dart, but can you you guide me on firsts steps to start understand and maybe help in this feature?

Once I'm happy with an API design for async relationships (meaning async relationship model retrieval to support lazy Hive boxes and eventually SQLite) I'll let you know.  Have you gone through the code?

Not yet, but I read the documentation https://flutterdata.dev/.
I think I'm going to go through the code and try to understand.
Thanks 👍

Not happening anytime soon.


[CodeCompletion] Don't generate constraints for parts of a result builder unrelated to the code completion token

This basically resolves all performance-related problems in TurnipsView.swift of the ACHNBrowserUI project in the stress tester, improving average code completion duration from 4 billion instructions to 1 billion instruction in that file.
rdar://90769979 [SR-16056]

@swift-ci Please SourceKit stress test

@swift-ci Please smoke test

@ahoppen I think you could skip statements entirely (just continue) after moving the check to visitBraceStmt.

Actually no, statements are added to the buildBlock so they’s need a placeholder

Superseded by https://github.com/apple/swift/pull/59992


Add .gitmodules

Cool project. Needed to add this for the submodule to clone, so making a PR.

Thanks @my0n! Sorry I didn't see this PR until now, I must have missed a notification.

Thanks @my0n! Sorry I didn't see this PR until now, I must have missed a notification.


Progressring updates

Description

Update images, the namespaces used in the sample code and the namespace used in the page code.
Motivation and Context

Closes #485
How Has This Been Tested?

Tested manually
Screenshots (if appropriate):

Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Looks great! One more request - can you add a "New" tag to ProgressRing, just like the AutomationProperties tile has? And probably update ProgressBar's from "Preview" also to "New" while you're in that file. Thank you!

Thank you for making these changes @chingucoding! Double checking - it looks like the black part of the ProgressRing image is fuzzy or something. Is it just me?

Sure @YuliKl , I'll change that.
@stmoy Strange, now I see it too. I'll (hopefully) fix this soon.

Updated images and controls json file now.

Thanks @chingucoding. I'm still seeing some strange rendering artifacts or something - how are these image files generated?

I've taken a screenshot of the actual progressring, removed background and scaled them down using GIMP

Perhaps. What does it look like in dark theme? Most (all?) of the icons have a solid white border, I believe. So I think we'll need that here as well.

It looks bad:

Unfortunately, I am definitely not an expert on this area :/

Thanks for checking. I think we'll probably want to hold off taking this change until the images are fixed (or removed from the change). @yulikl do you have thoughts on how to generate one of these icons? Maybe we could ask our friend @mdtauk 😅

Thanks for checking. I think we'll probably want to hold off taking this change until the images are fixed (or removed from the change). @YuliKl do you have thoughts on how to generate one of these icons? Maybe we could ask our friend @mdtauk 😅

At such a small size, its going to be a struggle, unless you use transparency for the ring itself.
if you wanted it to all be Opaque, thickness is the only option you can change

Or use a dashed line for the track ring

For dark theme however, we would still need a white border of sorts (similiar to other icons) since otherwise, you wouldn't be able to see that well.

For context, many of the other icons are not square nor mono-colored:

@chingucoding, what about this?

Those look fine to me. I am a bit concerned how the ring would look like on the NavigationView given that it is being displayed very small, though it would probably be fine.
Would you like to update the images or would you like me to? We would first need to remove the background to make it transparent and blend in well with the other icons.

Thanks @mdtauk - one further clarification: the light and dark theme use the same assets today, meaning we need a single asset that looks good in both themes.

I am a bit concerned how the ring would look like on the NavigationView given that it is being displayed very small, though it would probably be fine.

Oh, you're right. Oops. The NavigationView only uses FontIcons right now to avoid an issue where using custom assets wouldn't render on first launch. I think we should avoid using a custom asset in the NavigationView and change the icon to a different font icon.

We would first need to remove the background to make it transparent and blend in well with the other icons.
The first picture I included has a transparent background.

Thanks @mdtauk - one further clarification: the light and dark theme use the same assets today, meaning we need a single asset that looks good in both themes.

I am a bit concerned how the ring would look like on the NavigationView given that it is being displayed very small, though it would probably be fine.

Oh, you're right. Oops. The NavigationView only uses FontIcons right now to avoid an issue where using custom assets wouldn't render on first launch. I think we should avoid using a custom asset in the NavigationView and change the icon to a different font icon.

We would first need to remove the background to make it transparent and blend in well with the other icons.
The first picture I included has a transparent background.

You could separate the Progress Segment from the Ring, and overlay one Glyph on top of the other - so a Font Icon can still be used.  This is what is done for the ink toolbar controls

Oh, you're right. Oops. The NavigationView only uses FontIcons right now to avoid an issue where using custom assets wouldn't render on first launch. I think we should avoid using a custom asset in the NavigationView and change the icon to a different font icon.

Ohhhhh, that makes sense. In that case, the question would be, what the new icon would be if we choose to change it. The current item seems like one of the only ones suitable for this use category. We could use
 but I am not sure if it's that good of a choice here.

You could separate the Progress Segment from the Ring, and overlay one Glyph on top of the other - so a Font Icon can still be used. This is what is done for the ink toolbar controls

But are these distinct parts available as font icons? In addition to that, I am not 100% sure if we would be able to load them from the JSON or if we would need to adjust the current "icon" loading process.

You could separate the Progress Segment from the Ring, and overlay one Glyph on top of the other - so a Font Icon can still be used. This is what is done for the ink toolbar controls

But are these distinct parts available as font icons? In addition to that, I am not 100% sure if we would be able to load them from the JSON or if we would need to adjust the current "icon" loading process.

I just drew those icons ideas in figma - does the gallery just use Segoe MDL2, or a custom font?

I just drew those icons ideas in figma - does the gallery just use Segoe MDL2, or a custom font?

In it's current form, we only use the Segoe MDL2 Assets font.

I just drew those icons ideas in figma - does the gallery just use Segoe MDL2, or a custom font?

In it's current form, we only use the Segoe MDL2 Assets font.

That is gonna become problematic as the pace of updates outstrips that of the font.  Not to mention the new Fluent Icons only available as SVGs for now

That is gonna become problematic as the pace of updates outstrips that of the font. Not to mention the new Fluent Icons only available as SVGs for now

Agreed, but this is a separate issue from the one that @chingucoding is trying to fix 😅

Yes, another thing is that we only need a small icon now as the progressring icon is used for one of the categories.
However given that with hierarchical NavigationView, we also show the icons of every control in the NavView now, we should optimize for that too:

That is gonna become problematic as the pace of updates outstrips that of the font. Not to mention the new Fluent Icons only available as SVGs for now

Agreed, but this is a separate issue from the one that @chingucoding is trying to fix 😅

Yes, another thing is that we only need a small icon now as the progressring icon is used for one of the categories.
However given that with hierarchical NavigationView, we also show the icons of every control in the NavView now, we should optimize for that too:

Sure.  It would also be good to synchronise the icons used in the controls gallery, with the icons used in Visual Studio for the SDK - and so more flexibility with icon formatting (multiple colours) would be ideal

@chingucoding - what about U+E8F2 for the NavigationView icon?

Good idea! I've switched it out. What icon should we use for the ProgressRing?

Does this one work?

Hmm, the edges look a bit weird:

Hrm, weird. That does look bad. I'll see if I can fix it in a little bit, but we might need some help.
@mdtauk, can you help out? The requirements are:

one asset for both light and dark theme
does not need to be (and probably shouldn't be) square
72 x 72 px

Hrm, weird. That does look bad. I'll see if I can fix it in a little bit, but we might need some help.
@mdtauk, can you help out? The requirements are:

one asset for both light and dark theme
does not need to be (and probably shouldn't be) square
72 x 72 px

72 x 72 doesn't scale neatly to 16 x 16 for the Navigation view - but it does for 12px and 24px icons.  For them to work at small sizes, the template may need to change, and that doesn't give a lot of resolution if the icons are going to use borders to enable Light and Dark use.
Is there no scope for providing Light and Dark assets?

I don't think 72 x 72 is a hard limit here right @stmoy? If its easier to scale to small sizes, I think another size would be fine too. But I'll let Steven comment on that.
Regarding Light/Dark assets, I am not sure when we will do this, as this would require definitely more work on the loading of the "data json".

Rewinding a little bit. We have two assets that we need to update - each of them has their own requirements as they exist in the app right now.

Tile Icon

one asset for both light and dark theme
does not need to be (and probably shouldn't be) square
72 x 72 px (though not a hard requirement)

NavigationView Group Icon ("Status and Info")

A single font glyph pulled from MDL2 font

NavigationView ProgressRing Icon

Will get scaled down from the tile asset

For the "Status and Info" icon, we need to use an existing font glyph in the MDL2 asset font for right now. Although the NavView technically supports custom asset icons, there is an unresolved bug where the icon doesn't render on first launch that we'd need to investigate/fix before putting in a custom asset. This is beyond the scope of the current PR.
For the Tile icon, we need a single asset that works in both light and dark theme. The asset will be scaled to 72x72 as this is the size of all of our other assets. Although the asset could technically be a different size, it will always get scaled to 72x72, meaning we should probably provide something at this scale if possible. We can investigate having different assets for light and dark theme, but this would also be beyond the scope of the current PR.
For the ProgressRing icon within the hierarchical NavigationView, it naively uses a scaled version of the Tile icon. Although it might not be optimal, that's what every other control page does as well.

@stmoy  I have started making some 72 x 72 icons, that should scale down to 24x24 and 12x12

Thanks @mdtauk for providing these assets. They look nice! The complete set of assets we'd need to update if we wanted to do a visual refresh for all of the tiles are located here: https://github.com/microsoft/Xaml-Controls-Gallery/tree/master/XamlControlsGallery/Assets
I'm hoping to unblock this PR specifically by providing a targeted asset to replace the Progress Ring one. @chingucoding, is this one any better? I took the RadioButton asset and modified it, so hopefully it's close 🤞

Definitely looks better, but the roundedness is very problematic here I think:

Unfortunately, there isn't much we can do about this, progressring is a circle. Maybe if we chose wider circles for the border and the "control"?

Agreed, this one looks better but doesn't quite feel right yet... Bleh. I think you're right that thicker borders will probably look better.
How's this?

This looks fine to me:

:shipit:
Thank you for the help and iteration, @chingucoding! Double checking - how does it look in light mode?
I'd still love to take a holistic pass as @mdtauk mentions, but this seems fine to me for now.

Light mode also looks good in my opinion:

Pushed the image, thanks for providing the new images @stmoy and thank you for your efforts and help @mdtauk .
The new icons you showed @mdtauk look great! If you want we can update them holistically in a separate PR if @stmoy is fine with that.

@chingucoding - is ProgressIcon used anymore? If not, can it be removed?

@chingucoding - is ProgressIcon used anymore? If not, can it be removed?

I can't find any "ProgressIcon" in the XCG code 😅

It's one of the files included in the changelist. https://github.com/microsoft/Xaml-Controls-Gallery/pull/489/files#diff-478ec5ba36eaedd60dc7b04727c64127

Ohhh right, yes that's not needed anymore. Removed it. Totally forgot that.

Haha love it, thank you @stmoy !

I made a somewhat related issue post some time ago in the WinUI repo, but when I am done with the initial set of icons, I guess I can make a new issue here for it.
https://github.com/microsoft/microsoft-ui-xaml/issues/1204

Those new items look awesome! Would you like me to create a tracking issue in this repo to update them once you are finished and happy with the new icons?

Those new items look awesome! Would you like me to create a tracking issue in this repo to update them once you are finished and happy with the new icons?

Hold off until I have a complete set - I may have to do simplified 16px versions as the scaling just does not play nice - but the 72, 48, 24 should work find with these vector shapes.

Ok so I think this is everything included in the Gallery's assets.  I am posting it here - each icon at 72x72 and 16x16 size - and they should work on Light and Dark backgrounds.
@chingucoding  @stmoy  @YuliKl
Any which stand out as odd or wrong, or any feedback in particular would be welcome, before making a separate proposal.

Can you add labels for the icons, that is what icon would correspond to which control? Also I am not sure if the color palette would be the best image for RadioalGradientBrush. Another question, was there a specific reason for going more dark themed icons?
Beside that, those new icons look really good!

Can you add labels for the icons, that is what icon would correspond to which control? Also I am not sure if the color palette would be the best image for RadioalGradientBrush. Another question, was there a specific reason for going more dark themed icons?
Beside that, those new icons look really good!

I was trying to find an approach that worked equally well for Light and Dark themes - these read well on both to me, but all of it is changeable of course.
Here is the Figma file with the icons in.  They are in Frames with names on.  I used the Treeview from the Gallery app to sort them.  The RadialGradientBrush is in the motion section for whatever reason - I think it should probably go into Styles however.
Shared WinUI Gallery Icons.zip

Oh yes, RadialGradientBrush is in the style section now, but not in the store version yet I think.
I think light themed icons are more "friendly" and more "inviting", but that's just my opinion.

Oh yes, RadialGradientBrush is in the style section now, but not in the store version yet I think.
I think light themed icons are more "friendly" and more "inviting", but that's just my opinion.

Here are the icons with the colours inverted.

Those look awesome! Thank you for helping and making those.

I fixed the Gradient Icon, and added the Figma with the inverted colours

Labels Added

Shared WinUI Gallery Icons Inverted.zip

Thank you for the updated version with labels. Regarding your dark theme concern, this is how it looks like with a dark background:

Thank you for the updated version with labels. Regarding your dark theme concern, this is how it looks like with a dark background:

At a first glance it appears fine, but after long periods?
I know this is part of the reason colours are reduced with Dark Mode UI.
I could be overthinking it perhaps?

At a first glance it appears fine, but after long periods?
I know this is part of the reason colours are reduced with Dark Mode UI.
I could be overthinking it perhaps?

That's a good point. I don't think that you are overthinking this, it is definitely a valid concern. Currently the icons have around the same brightness:

I suppose it was fine back then, so it is now? I never felt that the icons are too bright over time, especially since you actually don't spend too much time with them. Generally you search for a page and visit said page, and are looking to much at those control "overviews".

Eitherway, I think the icons work both inverted and un-inverted, so they are out there now if the community and the Repo owners want them.
It would be nice if the Visual Studio toolbox synced with a single set of icons, but that is a much bigger ask 😛
The figma file is there too if tweaks are needed, so I will await comments,

Thanks for including this, @mdtauk!
I think we'd want to update both the WinUI icons and the Xaml Controls Gallery icons at the same time. CC: @ranjeshj - thoughts on cost to do this?
I think the next steps would be to file one more issue on the XCG repo saying "update the icons alongside https://github.com/microsoft/microsoft-ui-xaml/issues/1204", and include a link to all of the image assets. I think two issues are appropriate and they should probably be done at around the same time.
CC: @chigy for visibility as well

@stmoy  Do you need me to make an issue for this, or is that something you will be doing?

Filed: https://github.com/microsoft/Xaml-Controls-Gallery/issues/504


Add details of resource for conflicts

Also externalize strings

https://github.com/stolostron/backlog/issues/21753

/cc @jamestalton

/test lint-check-unittests-sonarcloud


Missing documentaton for EditorConfigFiles propperty.

As of Visual Studio 16.7 the EditorConfigFiles property is supported in project files.
See https://twitter.com/davkean/status/1296314723512639490/
<EditorConfigFiles Include="..\..\linting\.editorconfig" Link=".editorconfig"/>

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 72f45eb4-3596-866a-2c16-ee225737d956
Version Independent ID: cea055e7-fe9b-95c7-6d25-086f182c01d2
Content: EditorConfig settings - Visual Studio
Content Source: docs/ide/create-portable-custom-editor-options.md
Product: visual-studio-windows
Technology: vs-ide-general
GitHub Login: @mikadumont
Microsoft Alias: midumont

Hey! This appears to be a new MSBuild property that was added and needs to be documented. Adding @baronfel who is the PM on MSBuild.

While this is an MSBuild Item, it looks like it's been defined by the Roslyn targets as an input for the C# and VB compilers:

C# Usage
VB Usage

I think the documentation might be better placed on the Compiler Options sections for those compilers:

C#
VB maybe?

After speaking with @jmarolf we do think the compiler options pages are the proper place for this, but we need to detail the use case between this property (which we don't think people should use anymore) and the global analyzer config property (which we recommend instead)

I have a use-case: we want a single repository of shared config files that other repositories can reference. So put all the config files in a single git repository and import that either via git submodules (for internal projects) or as a NuGet package (for some client projects where they don't want to deal with git submodules).
We already have a props file that adds other configurations like StyleCop and SonarLint, I figure we can add EditorConfigFiles to that. (I'm not sure if this is the correct use of EditorConfigFiles as it's not documented, but I guess it'd work like this.)
  <ItemGroup>
    <AdditionalFiles Include="$(MSBuildThisFileDirectory)stylecop.json" Link="stylecop.json" />
    <AdditionalFiles Include="$(MSBuildThisFileDirectory)SonarLint.xml" Link="SonarLint.xml" />
    <EditorConfigFiles Include="$(MSBuildThisFileDirectory).editorconfig" Link=".editorconfig"/>
  </ItemGroup>

Currently we copy the .editorconfig into the importing project's file
  <Target Name="Copy editorconfig" AfterTargets="AfterResolveReferences" Condition="'$(SolutionDir)' != '*Undefined*'">
    <Copy SourceFiles="$(MSBuildThisFileDirectory).editorconfig" DestinationFolder="$(SolutionDir)" SkipUnchangedFiles="true" />
  </Target>

and add it to the importing repository's .gitignore because it's treated like a generated file.
You mentioned the global analyzer config property as a recommended alternative, would that be a better fit for this use-case as well?

@DAud-IcI -- Dávid, thank you for your follow-up.  Please consider these resources:

Visual Studio on Microsoft Q&A
Visual Studio MSDN Forum
Stack Overflow
Reddit

@WilliamAntonRohm I was under the impression, that @baronfel asked for real-life use-cases before this property can get a documentation because they think it's not useful. If I misunderstood what they wrote, that's fine, but sending me away to ask the community forums about an undocumented feature seems somewhat inappropriate.

Bad bot! A lack of action from the documentation owners does not a stale issue make. I'm not making a duplicate of a perfectly valid, relevant and open issue.

Aggressively closing otherwise valid issues because it didn't get attention from maintainers nor have people been spamming "Yes, this is still an issue." seems to me something that discourages community participation.
So, let me add it: this is still an issue. This issue here is what comes up first when you search for "csproj EditorConfigFiles". I don't see any official documentation still. And what @DAud-IcI commented above is still relevant: is this actually a property we should use? Or only .globalconfig files?

Aggressively closing otherwise valid issues because it didn't get attention from maintainers nor have people been spamming "Yes, this is still an issue." seems to me something that discourages community participation.

And (speaking from experience) it becomes a nightmare to investigate and properly learn from a problem a few months (or even years) down the line, because you need to comb through multiple iterations of the same issue, where some or most of the discussion had to be repeated.

Just want to add that ideally this functionality would work for things besides the compiler itself (code analyzers) since there are a lot of style conformity features that we would want Visual Studio/VS Code to enforce (tabs v space, how many spaces, new lines before braces, etc.) within the context of the project using this item type and it is unclear what the supported/expected behavior should be here.


fix deadlock between client and server

See https://github.com/eclipse-lsp4j/lsp4j/issues/51 for details

LGTM, thanks


Extension runs conda install tensorboard when upgrade is needed

https://github.com/microsoft/vscode-python/pull/15539 regressed upgrading tensorboard for conda users with an existing copy of tensorboard
H/T @lenisha for identifying the problem on a call together

@joyceerhl has this been fixed already?

Yes I've submitted a fix, although I don't think the fix has been included in a stable release yet.

It should be out now :)


Shift (Left) + Tab focus to sub-menu options from selected item.

Microsoft PowerToys version
0.70.1
Installation method
Microsoft Store
Running as admin
No
Area(s) with issue?
PowerToys Run
Steps to reproduce
FIRST OF ALL
I change the default settings to the item:

switch to off the option:
PowerToys Settings > PowerToys Run > Search & results > Tab through context buttons

Increase the numbers of results to 7
PowerToys Settings > PowerToys Run > Search & results > Number of results shown before scrolling

STEPS TO REPRODUCE

Invoke PowerToys Run with Alt + Space;
Digit anything that appear multiple option and move to next with Tab key;
Come back to previous option with Shift (Left)+ Tab.

✔ Expected Behavior
Press Shift (Left) + Tab should move to previous select item only.
❌ Actual Behavior
Press Shift (Left) + Tab  to move to previous select item AND focus to last icon to context submenu.
https://github.com/microsoft/PowerToys/assets/112908515/733c91f4-7a76-4637-9bc5-c95709899f55
Other Software
No response

This issue has been worked on during the 0.72 development cycle. Please update your PowerToys installation to the latest.
https://github.com/microsoft/PowerToys/releases
Thank you!


Profiling tool

Can we use a profiling tool to analyze benchmarks' execution? CPU and memory profiling would be nice.

I've found the following options:
http://blog.nodejs.org/2012/04/25/profiling-node-js/
http://blog.jetbrains.com/webstorm/2015/05/node-js-profiling-in-webstorm-part-1-cpu-profiling/

WebStorm profiler is  nice, perf + flamegraph is really nice, though a bit hard to set up
https://gist.github.com/trevnorris/9616784


Faucet Embed is clipping

When in the Testnet faucet section of the integrate cardano documentation the Faucet section is clipping the tADA submission process, so much so that the captcha and the address input sections are not selectable.

I just set up a local testing branch for this, but found that the embedding doesn't work in a local branch (or more likely on a domain that doesn't match the canonical domain).  Any suggestions how to test & debug this one?  If I had some idea how this works I might go at it by setting the container properties plus maybe adding a narrow-screen media query if allowed.

Please also see #759

@rphair unfortunately I'm not sure how to test or debug it, I only spotted the bug while going through the documentation. Hopefully someone here smarter than myself might be able to give us an answer! :)


Add iCloudContainerEnvironment Step Option

Would it be acceptable to add an iCloudContainerEnvironment step option?
Currently, for non app store builds this export options plist key is left out by default (when set to default) in the hash method of bitrise-tools/go-xcode/exportoptions/non_appstore_options.go. The only workaround is to use the custom export options plist which has become cumbersome because we have many schemes and targets. If a step option were to be introduced it could work in a similar fashion to the other export option overrides such as compile bitcode, or team ID.
If there's no opposition, I'm happy to attempt a PR to add this, although I've never used Go before so I might not get it right the first time around.

Hi @leedsalex ,
thanks for the feature request!
Actually, we have a task for this update already, but our idea is not to wire out this option as a new input but set this export option automatically.
If the app uses CloudKit, then this key needs to be set with value: Production for production ipa exports (ad-hoc, app-store, enterprise) and Development for development ipa exports.
What do you think about this idea?

Thanks for the reply @godrei
That sounds great! It’s what I would have set it to anyway. Do you have an ETA on this update?

The task is estimated and ready for sprint, hoverer I do not know if the task will be part of our next week's sprint or not. We will notify you, here.

Hi @godrei any update on this? Thanks

Hi @leedsalex ,
we have released a new version: 2.4.9 which auto detects the iCloudContainerEnvironment export option.
I'll close this issue, but if you need more info/help just let us know and we'll reopen it!

Thanks @godrei

@godrei It appears this still doesn't work. Bitrise is reporting in the log that our Entitlements Map for the Target ID is empty. The Xcode step should be retrieving the map from the archived-expanded-entitlements.xcent file, but I think this is no longer created post Xcode 9.3 (or so I've read online). Any ideas?

@leedsalex can you please copy paste the related build's bitrise.io URL, so that we can check its logs & config?

@viktorbenei
https://www.bitrise.io/build/c446ff2398373e10

Hey @leedsalex !
Fixing the issue is in progress already. We'll notify you as soon as it is released.

@nab0y4enko thanks for the extra info. It is in-progress actually. We will notify you here.

Hi @leedsalex v2.4.11 is released with a new input: icloud_container_environment, which you can use to specify the iCloudContainerEnvironment export option.


Shorthand properties not in docs

Description
Unclear how to use component styling
Problem Statement
Hi
I generally like this library very much. However, it's very frustrating that I can't find a list of the shorthand style properties like h, w, etc and their arguments in the docs anywhere. Checking the RN View component it's not there either. Can you please either add this information to your docs, or provide a clear direction of where to find it?
https://v1.gluestack.io/ui/docs/components/layout/vstack
Thanks!
Proposed Solution or API
Add shorthand props to docs
Alternatives
No response
Additional Information
No response

Gluestack is based heavily on Nativewind (which is based heavily on Tailwind I'd recommend leveraging the documentation from those libraries

Hi – Thanks for the reply this does help some. I use TailwindCSS extensively, but in many cases it’s not at all clear how this translates, as the two environments are structurally different. I appreciate the info and not sure if you are a maintainer or not, but leaving this here hoping they see it. This sort of implicit inheritance puts users in a place where they are guessing. For instance what about ‘leading’ with tailwind for line-height? Based on inheritance, I’d expect ` to work but it just doesn’t, I have to revert to the style property. It would save a lot of frustration if this stuff were explicitly documented on a per-component basis.
From: Aaron Pittenger @.>
Sent: Sunday, August 25, 2024 7:59 PM
To: gluestack/gluestack-ui @.>
Cc: Brian Aderer @.>; Author @.>
Subject: Re: [gluestack/gluestack-ui] Shorthand properties not in docs (Issue #2411)
Gluestack is based heavily on Nativewindhttps://www.nativewind.dev/v4/overview (which is based heavily on Tailwindhttps://tailwindcss.com/docs/installation I'd recommend leveraging the documentation from those libraries
—
Reply to this email directly, view it on GitHubhttps://github.com/gluestack/gluestack-ui/issues/2411#issuecomment-2309051400, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AF5USFCZM3BI4TKE62CIEQLZTJVSVAVCNFSM6AAAAABNCX533WVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMBZGA2TCNBQGA.
You are receiving this because you authored the thread.Message ID<EMAIL_ADDRESS>

Not a maintainer, just using this library extensively recently and it's really worked out well for me! Trying to help out others if possible.
In your example, I typically go to tailwind's documentation and search for leading, that would lead me to the docs for line height which would give you the syntax for the style. Then that goes into the className prop of a component.
<Component className='leading-3' />


add cleanup container

issue: https://github.com/containers/youki/issues/1817

Codecov Report

Merging #1824 (e9cd419) into main (1faa881) will decrease coverage by 0.03%.
The diff coverage is 0.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1824      +/-   ##
==========================================
- Coverage   68.63%   68.61%   -0.03%
==========================================
  Files         121      121
  Lines       13327    13330       +3
==========================================
- Hits         9147     9146       -1
- Misses       4180     4184       +4


Upgrading 2020-09-14 -> 2020-09-21 broke #![feature(rustc_private)]

Setup
Cargo.toml:
[package]
name = "nightlytest"
version = "0.1.0"
authors = ["khyperia<EMAIL_ADDRESS>edition = "2018"

[lib]
crate-type = ["dylib"]

[dependencies]

rust-toolchain:
nightly

src/lib.rs:
#![feature(rustc_private)]

extern crate rustc_ast;

Expected behavior, behavior on rust-analyzer 2020-09-14
No error
Actual behavior on rust-analyzer 2020-09-21
Red squiggles on the extern crate, with popup unresolved extern crate. cargo build etc. still works fine.

Just for context: I don't believe it's as much us breaking rustc_private, but introducing a diagnostic for unresolved imports in rust-analyzer instead of depending on cargo check. So this is very likely #6016.
You should be able to silence the diagnostic by adding the following to your vscode config:
"rust-analyzer.diagnostics.disabled": ["unresolved-extern-crate"]

Aah gotcha, thanks, that is indeed what's happening (diagnostics for things in rustc crates still work, e.g. use rustc_ast::asdf errors but use rustc_ast::[valid item] doesn't), sorry for the silly bug report! Should have investigated a little bit more and figured that out.

No worries! Rather an extraneous bug report than a missed issue :)


Add links

Make links of 'JsonWebKeyCurveName' and 'JsonWebKeyType'.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: fe0f363b-7f21-0ea9-3e27-da7866c94102
Version Independent ID: 6cc413e4-4f7d-9baa-a365-c9275fc6a7ad
Content: az keyvault key
Content Source: src/azure-cli/azure/cli/command_modules/keyvault/_help.py
Service: key-vault
GitHub Login: @rloutlaw
Microsoft Alias: routlaw

@bim-msft please take a look


I got a error in

Did you read https://github.com/pixeltris/YgoMaster/blob/master/Docs/FileLoadError.md

Did you read https://github.com/pixeltris/YgoMaster/blob/master/Docs/FileLoadError.md

yes

I would suggest reading it harder as those are the solutions for fixing the mentioned popup.

open  is fine. but  when I search the 魔獣 (Banquet of Millions)  it also happened.
You mean I my \LocalData has lost data？

It is in the game it's used in D.D. Dynamite decks. For me it shows up fine on both YgoMaster and steam. Again you need to read that link thoroughly.

Avoid having multiple folders inside of /LocalData/ or make sure they are ALL updated
Ensure the language set on YgoMaster is identical to your language setting on steam

FileLoadError.md states all known fixes for loading issues. If you resolve your issue in a way not listed feel free make a PR or describe it and I'll add it to the list.


Ui::grid_under_cursor(): called Option::unwrap() on a None value

Neophyte panics on startup:
thread 'main' panicked at <snip>/neophyte-0.2.3/src/ui/mod.rs:447:50:
called `Option::unwrap()` on a `None` value
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

That's this line on main branch. Seems like just replacing the unwrap with ? makes it work, but there's probably a bigger underlying issue.
I'm on Arch Linux, i3wm using picom. My nvim config is based on LazyVim.

Could you run with RUST_BACKTRACE=1 RUST_LOG=info? I tried running with the stock LazyVim starter and was not able to reproduce. You are right of course that there is a deeper issue here, most likely a mistake in updating draw_order.

Here:
INFO [winit::platform_impl::platform::x11::window] Guessed window scale factor: 1
INFO [neophyte::neovim] Calling method nvim_ui_attach
INFO [neophyte::neovim::stdout_thread] RPC response to 0: Nil
INFO [wgpu_hal::vulkan::instance] Instance version: 0x403112
INFO [wgpu_hal::vulkan::instance] Debug utils not enabled: debug_utils_user_data not passed to Instance::from_raw
INFO [wgpu_hal::vulkan::instance] Enabling device properties2
INFO [wgpu_core::instance] Adapter Vulkan AdapterInfo { name: "NVIDIA GeForce GTX 1660 Ti", vendor: 4318, device: 8578, device_type: DiscreteGpu, driver: "NVIDIA", driver_info: "545.29.06", backend: Vulkan }
INFO [wgpu_core::device::global] configuring surface with SurfaceConfiguration { usage: TextureUsages(RENDER_ATTACHMENT), format: Bgra8UnormSrgb, width: 843, height: 1024, present_mode: AutoVsync, alpha_mode: Opaque, view_formats: [] }
INFO [wgpu_core::device::global] Automatically choosing presentation mode by rule AutoVsync. Chose Fifo
INFO [neophyte::event_handler] New Winit events
INFO [neophyte::event_handler] Got resize: PhysicalSize { width: 843, height: 1024 }
INFO [neophyte::neovim] Calling method nvim_ui_try_resize_grid
INFO [wgpu_core::device::global] configuring surface with SurfaceConfiguration { usage: TextureUsages(RENDER_ATTACHMENT), format: Bgra8UnormSrgb, width: 843, height: 1024, present_mode: AutoVsync, alpha_mode: Opaque, view_formats: [] }
INFO [wgpu_core::device::global] Automatically choosing presentation mode by rule AutoVsync. Chose Fifo
INFO [neophyte::event_handler] Got cursor move: PhysicalPosition { x: 159.0, y: 385.0 }
thread 'main' panicked at <snip>/neophyte-0.2.3/src/ui/mod.rs:447:50:
called `Option::unwrap()` on a `None` value
stack backtrace:
   0: rust_begin_unwind
   1: core::panicking::panic_fmt
   2: core::panicking::panic
   3: core::option::unwrap_failed
   4: neophyte::ui::Ui::grid_under_cursor
   5: neophyte::event_handler::EventHandler::cursor_moved
   6: neophyte::event_handler::EventHandler::handle
   7: winit::platform_impl::platform::x11::EventLoop<T>::drain_events::{{closure}}
   8: winit::platform_impl::platform::x11::event_processor::EventProcessor<T>::process_event
   9: winit::platform_impl::platform::x11::EventLoop<T>::run_on_demand
  10: neophyte::main
note: Some details are omitted, run with `RUST_BACKTRACE=full` for a verbose backtrace.
INFO [neophyte::neovim::stdin_thread] receiving on a closed channel
INFO [neophyte::neovim::stdin_thread] Closing stdin thread
INFO [wgpu_core::global] Dropping Global
INFO [neophyte::neovim::stdout_thread] Got Neovim EOF
INFO [wgpu_core::device] Destroying 0 command encoders

Also, I realize now it happens independent of the nvim config, if I rename ~/.config/nvim to something else the same error happens

I previously had grid 1 initialized in Ui::new, which I think caused this issue because Neovim usually sets us up before any window events. It seems that is not the case on your system. I made a few changes to make initialization more robust. Would you try again with the latest revision?

Yes, I tested with latest main and it works now


Add the xlink and xml namespaces

The schema now supports both the Xlink and XML namespaces.
https://github.com/cjcodeproj/vtmedia-schema/issues/110
Even though the code doesn't do schema validation, the namespace URIs should be added to the media.xml.namespaces.Namespaces() class so the values can be handled by the code.

Commit:
https://github.com/cjcodeproj/medialibrary/commit/c73ac3a58406660994e4e04ccbc7ba6d166fd75b

Closing Notes

Easy implementation, no real side effects of change.
Converted the double-quotes to single quotes, since there are no substitutions or escapes within the strings.


Typo in type hinting

As far as I understand there must be an array type hinted, not the string. I can make PR.
Only i have question, may i type hint argument as well as in DocBlock?
https://github.com/bagisto/bagisto/blob/c967c940957a24ea17b3563c1d42c9d539b56c48/packages/Webkul/Ui/src/DataGrid/DataGrid.php#L235-L239

Yes, this will be an array. Strange I didn't notice.
Thanks for reporting.

Okay, i will do :slightly_smiling_face:

Hi @DeH4eG,
I am currently working on the data grid, if you want I can add in the existing PR. Otherwise, I will leave it as it is.

Hi @devansh-webkul,
As you wish 🙂 If you are already in progress, then I think it will be better that you will do it. It is not a big issue, for making a separate PR. In my opinion


Alternative/more nuanced language for IEF terms

srini1978 commented 2 weeks ago
LGTM. I wonder in some cases whether the distinction between chaining models and simply cleaning/preprocessing data from the impl might get a bit blurry? Probably just semantics.
That's a good point. I've been calling everything a model. I think it's worthwhile still calling them models but having the understanding some will be simple processors?
The distinction between the 2 is : there is a "component" which enriches the observation(s) and passes it on to the next model in the pipeline and the second is a component which actually calculates an Impact metric. In the true sense if we want to brand impact plugin as a software component that calculates impact metrices only then do we want to call these as ModelData Enrichment components. Here I am referring to our Observation as Model Data.
@srini1978 srini1978 2 weeks ago
Here the utilization is an observation. It needs to come from the software only. What we could do is by changing the instance type using this simulation the impact model can output sim-m which is the embodied emissions change.
@jawache jawache 1 minute ago
There is still lots we need to think through around this, eventually I think there will form a dictionary of model terms.
Extract Model
Simulation Model
Adapter Model
I don't think there is any need to figure this out now but over time I think we'll evolve a language around this but it will be determined by the types of models that will be created.
RE: The confusion regarding impacts as a term for something that doesn't match our original defn of impacts. I agree but I'm not confident we have enough information yet to decide on an alternative approach? I suspect once we create more models and IMPLs then even more nuance might appear and an alternative language might surface.
Shall we aim to review this language around the decarb event and maybe our alpha release?

@srini1978
Re: Observations / Impacts
Someone else also mentioned to me last week after I gave a talk on 4Ms and IF, was the use of the terms observations vs impacts. Now we have a pipeline approach as you mention I think it changes things, not breaks, just changes.
What if components simply have inputs and outputs
So in terms of YAML
observations -> inputs
impacts -> outputs
I think that's the syntax but semantically I'd still call things observations and impacts, e.g. cpu-utilization is an observation about a running system, which we configure as an input to a pipeline and the carbon is an impact which might appear in the output of a pipeline.
Re: IMPL / Manifest / Watch Files
We've been calling the files IMPLs (Impact YAMLs) and that's fine I think we are pretty married to the YAML approach for now. But another term that's starting to crop up is

Impact Manifest File: I like the term manifest, it like a record of everything that is included in the impact calculation. I'm using it as at least a description of what an IMPL file is.
Watch File: This might make more sense when the IMPLs move from static data to things that read data dynamically on load or define a real-time processing pipeline. They watch a system and determine impacts from what they can observe. One of the biggest unique selling points of the impact frameworks is that you don't need to install anything, it works by watching your existing data, systems. Most other offerings in this space ask you to install agents on your fleet of machines, we can just tap into the things you've already installed and can watch your system. I like that term to.

I still call them IMPLs in my communication for short ref, but the first time I'll say something like "IMPLs stand for Impact YAML.