Consider reformat of pushw assembly instruction

As discussed in the PR implementing parsing of pushw, it may make sense to allow the pushw instruction to take a single 32-byte hex value either instead of or in addition to the current approach of taking 4 inputs of 1 element each.
This is inspired by this contrived but strange example with the current implementation:
let op = Token::new("pushw.1.23.0x1C8.0", 0);
From Bobbin:
"now that I'm seeing how this actually looks, I wonder if we should change the format of pushw instruction to always take a single hexadecimal value of 32 bytes. Or maybe making this as an additional allowed format. So, for example, possible formats could be:
pushw.<IP_ADDRESS>
pushw.0x13244... (32 bytes)"

Another option worth considering is removing separation between push and pushwinstruction from the assembly. We could have just a singlepush` instruction, and it could take a variable number of arguments. For example, all of these could be valid:

push.1 and push.0x1 (8 bytes)
push.1.2 and push.0x0... (16 bytes)
push.1.2.3 and push.0x0... (24 bytes)
push.<IP_ADDRESS> and push.0x0... (32 bytes)

Another, more radical, idea that came to mind: maybe we should re-factor all assembly i/o instructions to be grouped around four verbs: push, pop, load, save. Then, our current set of instructions could be mapped as follows:
push instructions push value(s) from the specified source onto the stack:

push.const.xyz - similar to the current push/pushw (we could also omit the const keyword).
push.sdepth - same as current env.sdepth.
push.mem.addr - same as current mem.push.addr.
push.adv.n - pushes n values from the advice tape onto the stack (similar to the current read).

pop instructions remove values from the stack and save them into the specified destination:

pop.n - would be similar to the current drop but for n items.
pop.mem.addr - same as current mem.pop.addr.

load instructions would overwrite values at the top of the stack:

load.mem.addr - same as current mem.load.addr.
load.adv - would overwrite top 4 stack values with the next 4 values from the advice tape (similar to current readw)

save would save the values from the stack into the specified destination without removing them from the stack:

save.mem.addr - same as current mem.store.

At the same time, I'm not sure if this provides more or less intuitive understanding about the instruction semantics.

My take on these, in reverse order -
I prefer the last option. I think it's clear, and it groups everything semantically by the effect on stack. My notes are:

push.const.xyz: I would lean towards dropping the const. This op provides immediate values, whereas the other push ops are pushing values from another (specified) source, so I think having just push + immediate values makes sense, since it's sort of the "default" push case
push.sdepth: I would do push.env.sdepth. It matches with mem/adv and will be clearer if other env values ever come along
pop.n: I'm not sure about this one. Would it replace drop? If not, and drop/dropw still exist, then drop.n would be more consistent & it should be a stack op. If it's replacing drop/dropw, how much is gained by allowing variable length drops? Also, if the values are not being used, then it seems more appropriate as a stack manipulation op (as now) than as an io op.
why switch store to save? I thought store was clear, and it matches the machine op as well as being the usual partner to load
this doesn't resolve the question of the format of inputs to push/pushw, so we'd still need to settle that

Regarding removing separation between push and pushw (variable length inputs)
I'm trying to think about how push will actually be most useful. It's really a question of where we want to put the complexity. Most importantly: when we're parsing from higher level languages, would we like to be able to push 8/16/24/32 bytes directly either element-wise or as chunks? How much extra processing would we have to do on these while processing Solidity/etc? If there's significant overhead anyway, maybe it makes sense to let the compiler break it down at the time and just stick to simple push/pushw. If there isn't, then it might make the compilers easier to implement if we put the complexity into the push op now and allow the variable amount of arguments as suggested in the second update. I don't have a confident opinion here because I'm not 100% sure how these things will be affected by STARK setting.
** single hexadecimal input value of 32 bytes**
I think at a minimum it makes sense to accept a word input in addition to the 4 element option. This was what I expected when I first saw the instruction name pushw. Whether we keep the 4 elements or not is related to my comments above

I agree that organizing input/output instructions around four verbs: push, pop, load, and store (or save) is cleaner. My only hesitation is future extensibility of this scheme. For example, at some point, we want to introduce an instruction which reads a word from an advice tape or memory and instead of replacing top 4 stack elements with it, adds values to the top stack elements.
With the current scheme, this can be accomplished like adv.addw or mem.addw (though the direction of what's being added is not clear). But I'm not sure how this would work with the scheme proposed in the original post (adding add.mem or add.adv would be too confusing). Maybe we could introduce a new verb though - like ladd (load-add) or addfrom or something like that.

I think in that case adding a new verb would make sense, and that doesn't really seem problematic to me. But the central question is really just whether you'd rather organize first by "what" is happening or by "where" it's happening. I like the "what" approach, because it seems like it gives a more natural and consistent organization. However, as long as things are consistent it's just a choice & I think both styles are defensible
Are there many (any) other possible future instructions you have in mind at this point?

I like the "what" approach better too. So, at this point, it seems like we've settled on what.where and the operations we have so far are:
Pushing value onto the stack:

push.xyz
push.sdepth
push.mem.addr - or should this be pushw.mem.addr?
push.adv.n

Removing values from the stack:

pop.mem.addr - or should this be popw.mem.addr?

Overwrite the values on the stack:

load.mem.addr - or should this be loadw.mem.addr?
load.adv - similarly, should this be loadw.mem.addr?

Save the stack value:

store.mem.addr - or should this be storew.mem.addr? The reason I was thinking about save originally is because we'll need to have "storage" as a destination at some point. But thinking about it more, we can pick something like pst (persistent storage) or something else for the "where" part.

One other thing to consider: depending on what we decide to do in #73, we will need to have another destination  (e.g., fmp) and also another verb or two (for "adding in" and "adding out"). Any thoughts on what these should be?

I think it might be clearer to keep the w in all cases where we're operating by word rather than by element. (That's all of the ops for mem and loadw.adv.)  I could be convinced otherwise, but it's my gut reaction, and adding the w doesn't really break the verb paradigm.
I will reiterate my vote from above for push.env.sdepth rather than push.sdepth. It matches with the what.where idea we're using for mem and adv and will be clearer if other env values ever come along. This means that anything without a specified where is always the stack

Supersede by #84


Data entry / research for Bett Conference in London March 22

The Bett conference is one of the largest Ed Tech conferences in the world, and we are looking for potential partners who would like to or already integrate PhET into their educational product.
The task is to go through the list of exhibitors and enter the information into a google sheet.
Go to this website:
https://uk.bettshow.com/bett-suppliers-list-library-redirect
Use the filters at the top to filter the exhibitors.
Bett Product categories:

Interactive whiteboards
Educational/Instructional Software
Learning Materials

Then enter the results into the sheet here (one example is already done):
https://docs.google.com/spreadsheets/d/12caPNKkBrqsBrmtyjj_apX-ZjClJ2rPLatpc3b6rvYk/edit#gid=38274592
Since the conference is March 22, it is necessary to have the list done by March 16 (~2 weeks)

QA should be done. Let me know if you need anything else on this.


Update help menu links for new regulations

These links currently 404

Isn't this just #400 ?

Yes, closing as duplicate

Yes, closing as duplicate


Implement persistent red-black tree

Forms the basis of:

Set (could probably also be handled by the HashMap)
Sorted Set
Sorted Map

Done.


Duplicate requests to sign the CLA

I've only seen it once. See https://github.com/spring-projects/spring-boot/pull/3963

Coule you look up the corresponding payloads?
Maybe the label action of spring-issuemaster triggered also an update?
Although I must admit, they are a lot of time apart..
Maybe making the handling occur on one and only one thread will solve possibilities like these?

Maybe the label action of spring-issuemaster triggered also an update?

That seems unlikely. The label was applied by Spring Issuemaster before the first comment from Pivotal Issuemaster.

At least, you would think that something must have triggered it?
Maybe the corresponding payload could be looked up (really wish that page had a filter function, or search).
But yeah, very unlikely that it was that specifically.

@wilkinsona Thanks for the report!
I'm not sure what would have caused this at the moment. The comments are at 2:49 am CDT & 3:49 am CDT which alludes to the fact that it is not a race condition.
Looking at https://status.github.com it appears everything has been operational.
In short, I'm not sure what caused this but we will keep it open until we get it sorted out or haven't seen it in a long time.

Here's another example of a duplicate request: https://github.com/spring-projects/spring-framework/pull/1120

And the second message was posted a while after the PR was closed...

@snicoll Do you have access to the event notification payload? The PR was updated at 2016-07-26T12:09:00 MESZ

@mp911de Also note, that we don't find the existing comment.
The comment could have been updated.

What currently bugs me is that we have two guards in the code and none of them seems to work. We usually don't update closed PR's

Assuming I'm looking at the right place in the code, the logic is an OR, so only one of the guards needs to be wrong for the comment to be made.

The reason is that the body has in each case the body is slightly different. The first PR has a difference in the links (https://cla.pivotal.io/sign/spring vs. https://cla.pivotal.io/sign/spring?repositoryId=spring-projects/spring-boot&pullRequestId=3963). The second PR uses different user names.
That's one riddle solved. Now I just need to find out why we still put comments on closed pull requests.

@mp911de yeah I noticed that, thanks for looking into it.
@wilkinsona the pull request state is probably either open or closed,
Could you find the corresponding webhook payload? The pull_request property should reflect what state the pull request was in.

I'm fixing it right now and constraining comment interaction to open pull requests only.

Could you find the corresponding webhook payload?

How do I do that?

Go to the Repository Settings -> Webhooks & services, select https://cla.pivotal.io/github/hooks/pull_request/pivotal. You'll see in the lower section of the page Recent Deliveries

I guess that's only useful for spring-projects/spring-framework#1120? I don't have access to the repository settings for Spring Framework. @snicoll might be able to help.

I think I found also the other reason why the second comment was added. It's a combination of unknown and the manual sync. The manual sync uses the username of the user logged into Pivotal CLA. It also uses the unknown status to propagate a sync. That are the reasons why spring-projects/spring-framework#1120  got commented twice.

It's a combination of unknown and the manual sync.

Can it be that the repository was deleted?

ehlxr  wants to merge 1 commit into spring-projects:master from unknown repository

That's another issue here. So much coincidence in one PR.

Haha, I believe that's called "field testing".
But yeah, it's unfortunate, so many things to go wrong.
I tried to find the corresponding event in the events API, but it's not published there unfortunately.
So the information has to come from the webhook payload I suppose.

I have access to recent deliveries if someone needs to look at that.

I fixed the discovered issues with duplicate comments. Let's keep the ticket open for a few more days. We can close it at S1 if duplicates don't pop up anymore.

Just wondering/verifying, S1 means SpringOne right?


Not include non requested TLV in Child Update Response from parent

Codecov Report

Merging #1604 into master will decrease coverage by 2.29%.
The diff coverage is 0%.

@@            Coverage Diff            @@
##           master    #1604     +/-   ##
=========================================
- Coverage   72.02%   69.72%   -2.3%
=========================================
  Files         160      160
  Lines       18918    20257   +1339
  Branches     2324     2486    +162
=========================================
+ Hits        13625    14125    +500
- Misses       4449     5222    +773
- Partials      844      910     +66

Impacted Files
Coverage Δ

src/core/thread/mle_tlvs.hpp
95.62% <0%> (-4.38%)
:arrow_down:

src/core/thread/mle_router.cpp
78.69% <0%> (-0.89%)
:arrow_down:

src/core/net/ip6.cpp
63.52% <0%> (-2.59%)
:arrow_down:

src/core/net/ip6_mpl.cpp
92.3% <0%> (-2.31%)
:arrow_down:

src/core/thread/topology.hpp
89.02% <0%> (-1.22%)
:arrow_down:

src/core/thread/network_data.cpp
86.89% <0%> (-0.75%)
:arrow_down:

src/core/thread/network_data_leader.cpp
79.69% <0%> (-0.51%)
:arrow_down:

src/core/thread/network_data_leader_ftd.cpp
68.54% <0%> (-0.24%)
:arrow_down:

src/core/thread/mle.cpp
81.74% <0%> (ø)
:arrow_up:

... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0e3b245...8e15b86. Read the comment docs.


Resolve the promise after the first image loads

Fixes https://github.com/plotly/plotly.js/issues/1685
As there is no test runner for IE11 the test is just to give coverage for other browsers. A manual test has asserted that has fixed the problem in IE11.

Thanks very much @HenryKeen ! PR away once my two small comments are addressed :rocket:

Great stuff! Thanks @etpinard. PR submitted


fix(comment): allow new lines in comments on Android

Fixes #206.
Need to check on iOS. There I understand, there was no such problem?

Nice thank you! Will test this in a bit - will try and solve the issue happening on iOS myself as well 💃

@housseindjirdeh what's new? Did you manage to test?

My apologies, my week has been swamped and I haven't had the chance to test it :( If not today then hopefully tomorrow and I'll let you know. The thing with iOS is that it's just the return key that's causing to post and I feel like there should be a prop or something similar to do newline instead. 🤔

@housseindjirdeh so by pressing the return key, a new line should be inserted? I thought the matter in the onSubmitEditing handler, because it was sending a message, and now it happens in the onSubmit handler. Perhaps this will help for iOS?

This is a test sent from iOS
With new lines.

@Antoine38660 It is perfectly! It turns out we can merge?


to work on the responsive ui for mobile devices

[x] hamburger menu
[x] ui optimization
[x] animations
[x] soft scroll
[x] responsiveness for mobile devices

completed all above listed task (#2)


flask db upgrade crashes on initial db-data volume create

Traceback (most recent call last):
  File "/usr/local/lib/python3.9/site-packages/sqlalchemy/engine/base.py", line 145, in __init__
    self._dbapi_connection = engine.raw_connection()
  File "/usr/local/lib/python3.9/site-packages/sqlalchemy/engine/base.py", line 3269, in raw_connection
    return self.pool.connect()
  File "/usr/local/lib/python3.9/site-packages/sqlalchemy/pool/base.py", line 452, in connect
    return _ConnectionFairy._checkout(self)
  File "/usr/local/lib/python3.9/site-packages/sqlalchemy/pool/base.py", line 1255, in _checkout
    fairy = _ConnectionRecord.checkout(pool)
  File "/usr/local/lib/python3.9/site-packages/sqlalchemy/pool/base.py", line 716, in checkout
    rec = pool._do_get()
  File "/usr/local/lib/python3.9/site-packages/sqlalchemy/pool/impl.py", line 169, in _do_get
    self._dec_overflow()
  File "/usr/local/lib/python3.9/site-packages/sqlalchemy/util/langhelpers.py", line 147, in __exit__
    raise exc_value.with_traceback(exc_tb)
  File "/usr/local/lib/python3.9/site-packages/sqlalchemy/pool/impl.py", line 166, in _do_get
    return self._create_connection()
  File "/usr/local/lib/python3.9/site-packages/sqlalchemy/pool/base.py", line 393, in _create_connection
    return _ConnectionRecord(self)
  File "/usr/local/lib/python3.9/site-packages/sqlalchemy/pool/base.py", line 678, in __init__
    self.__connect()
  File "/usr/local/lib/python3.9/site-packages/sqlalchemy/pool/base.py", line 903, in __connect
    pool.logger.debug("Error on connect(): %s", e)
  File "/usr/local/lib/python3.9/site-packages/sqlalchemy/util/langhelpers.py", line 147, in __exit__
    raise exc_value.with_traceback(exc_tb)
  File "/usr/local/lib/python3.9/site-packages/sqlalchemy/pool/base.py", line 898, in __connect
    self.dbapi_connection = connection = pool._invoke_creator(self)
  File "/usr/local/lib/python3.9/site-packages/sqlalchemy/engine/create.py", line 640, in connect
    return dialect.connect(*cargs, **cparams)
  File "/usr/local/lib/python3.9/site-packages/sqlalchemy/engine/default.py", line 580, in connect
    return self.loaded_dbapi.connect(*cargs, **cparams)
  File "/usr/local/lib/python3.9/site-packages/MySQLdb/__init__.py", line 123, in Connect
    return Connection(*args, **kwargs)
  File "/usr/local/lib/python3.9/site-packages/MySQLdb/connections.py", line 185, in __init__
    super().__init__(*args, **kwargs2)
MySQLdb.OperationalError: (2002, "Can't connect to server on 'db' (115)")

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "/usr/local/bin/flask", line 8, in <module>
    sys.exit(main())
  File "/usr/local/lib/python3.9/site-packages/flask/cli.py", line 1047, in main
    cli.main()
  File "/usr/local/lib/python3.9/site-packages/click/core.py", line 1055, in main
    rv = self.invoke(ctx)
  File "/usr/local/lib/python3.9/site-packages/click/core.py", line 1657, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
  File "/usr/local/lib/python3.9/site-packages/click/core.py", line 1657, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
  File "/usr/local/lib/python3.9/site-packages/click/core.py", line 1404, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "/usr/local/lib/python3.9/site-packages/click/core.py", line 760, in invoke
    return __callback(*args, **kwargs)
  File "/usr/local/lib/python3.9/site-packages/click/decorators.py", line 26, in new_func
    return f(get_current_context(), *args, **kwargs)
  File "/usr/local/lib/python3.9/site-packages/flask/cli.py", line 357, in decorator
    return __ctx.invoke(f, *args, **kwargs)
  File "/usr/local/lib/python3.9/site-packages/click/core.py", line 760, in invoke
    return __callback(*args, **kwargs)
  File "/usr/local/lib/python3.9/site-packages/flask_migrate/cli.py", line 150, in upgrade
    _upgrade(directory, revision, sql, tag, x_arg)
  File "/usr/local/lib/python3.9/site-packages/flask_migrate/__init__.py", line 111, in wrapped
    f(*args, **kwargs)
  File "/usr/local/lib/python3.9/site-packages/flask_migrate/__init__.py", line 200, in upgrade
    command.upgrade(config, revision, sql=sql, tag=tag)
  File "/usr/local/lib/python3.9/site-packages/alembic/command.py", line 378, in upgrade
    script.run_env()
  File "/usr/local/lib/python3.9/site-packages/alembic/script/base.py", line 569, in run_env
    util.load_python_file(self.dir, "env.py")
  File "/usr/local/lib/python3.9/site-packages/alembic/util/pyfiles.py", line 94, in load_python_file
    module = load_module_py(module_id, path)
  File "/usr/local/lib/python3.9/site-packages/alembic/util/pyfiles.py", line 110, in load_module_py
    spec.loader.exec_module(module)  # type: ignore
  File "<frozen importlib._bootstrap_external>", line 850, in exec_module
  File "<frozen importlib._bootstrap>", line 228, in _call_with_frames_removed
  File "migrations/env.py", line 103, in <module>
    run_migrations_online()
  File "migrations/env.py", line 88, in run_migrations_online
    with connectable.connect() as connection:
  File "/usr/local/lib/python3.9/site-packages/sqlalchemy/engine/base.py", line 3245, in connect
    return self._connection_cls(self)
  File "/usr/local/lib/python3.9/site-packages/sqlalchemy/engine/base.py", line 147, in __init__
    Connection._handle_dbapi_exception_noconnection(
  File "/usr/local/lib/python3.9/site-packages/sqlalchemy/engine/base.py", line 2410, in _handle_dbapi_exception_noconnection
    raise sqlalchemy_exception.with_traceback(exc_info[2]) from e
  File "/usr/local/lib/python3.9/site-packages/sqlalchemy/engine/base.py", line 145, in __init__
    self._dbapi_connection = engine.raw_connection()
  File "/usr/local/lib/python3.9/site-packages/sqlalchemy/engine/base.py", line 3269, in raw_connection
    return self.pool.connect()
  File "/usr/local/lib/python3.9/site-packages/sqlalchemy/pool/base.py", line 452, in connect
    return _ConnectionFairy._checkout(self)
  File "/usr/local/lib/python3.9/site-packages/sqlalchemy/pool/base.py", line 1255, in _checkout
    fairy = _ConnectionRecord.checkout(pool)
  File "/usr/local/lib/python3.9/site-packages/sqlalchemy/pool/base.py", line 716, in checkout
    rec = pool._do_get()
  File "/usr/local/lib/python3.9/site-packages/sqlalchemy/pool/impl.py", line 169, in _do_get
    self._dec_overflow()
  File "/usr/local/lib/python3.9/site-packages/sqlalchemy/util/langhelpers.py", line 147, in __exit__
    raise exc_value.with_traceback(exc_tb)
  File "/usr/local/lib/python3.9/site-packages/sqlalchemy/pool/impl.py", line 166, in _do_get
    return self._create_connection()
  File "/usr/local/lib/python3.9/site-packages/sqlalchemy/pool/base.py", line 393, in _create_connection
    return _ConnectionRecord(self)
  File "/usr/local/lib/python3.9/site-packages/sqlalchemy/pool/base.py", line 678, in __init__
    self.__connect()
  File "/usr/local/lib/python3.9/site-packages/sqlalchemy/pool/base.py", line 903, in __connect
    pool.logger.debug("Error on connect(): %s", e)
  File "/usr/local/lib/python3.9/site-packages/sqlalchemy/util/langhelpers.py", line 147, in __exit__
    raise exc_value.with_traceback(exc_tb)
  File "/usr/local/lib/python3.9/site-packages/sqlalchemy/pool/base.py", line 898, in __connect
    self.dbapi_connection = connection = pool._invoke_creator(self)
  File "/usr/local/lib/python3.9/site-packages/sqlalchemy/engine/create.py", line 640, in connect
    return dialect.connect(*cargs, **cparams)
  File "/usr/local/lib/python3.9/site-packages/sqlalchemy/engine/default.py", line 580, in connect
    return self.loaded_dbapi.connect(*cargs, **cparams)
    return Connection(*args, **kwargs)
  File "/usr/local/lib/python3.9/site-packages/MySQLdb/connections.py", line 185, in __init__
    super().__init__(*args, **kwargs2)
sqlalchemy.exc.OperationalError: (MySQLdb.OperationalError) (2002, "Can't connect to server on 'db' (115)")
(Background on this error at: https://sqlalche.me/e/20/e3q8)

put loop into dbupgrade_and_run.sh
#!/bin/sh
# initial volume create may cause flask db upgrade to fail
while ! flask db upgrade
do
    sleep 5
done
exec "$@"


feat(docs): allow control tags

Default tags generation are exhaustively. I am add ability to set Tags for endpoint, and other tags don't auto-generated for this endpoint.
Also, if set Tags to empty strings slice, OpenAPI interpret this as default tag.
But if Tags as nil (by default) automatic generation work as previously.

Hi @Otetz, thanks for the contribution. Your change is indeed right, but please add at least one test for it and I will merge it. The test should cover at least 2 endpoints - one with default and one with custom tags.

Done.

Thanks a lot. I'm merging it and going to make a release later today, together with the openapi3 library update.


default R version seems to be a system R version rather than R portable...

Thanks for this cool tool!
I could be wrong, but the default R version to use seems not to be R Portable... despite what the documentation says...
https://github.com/wleepang/DesktopDeployR/blob/2ddb93dc5c2efbb4ecce9230d0b4fa46cf8f6d09/app/config.cfg#L42

I came to report the same issue. In the config.cfg, I had to change:
"r_exec": {
"home": "C:\Program Files\R\R-4.0.2\bin\"
to:
"r_exec": {
"home": "dist\R-Portable\App\R-Portable\bin\"
So it defaults to the portable R.

I came to report the same issue. In the config.cfg, I had to change: "r_exec": { "home": "C:\Program Files\R\R-4.0.2\bin" to: "r_exec": { "home": "dist\R-Portable\App\R-Portable\bin" So it defaults to the portable R.

I had to change the path as well to make it working. Can someone update the README file, so that new user would figure it out.


Extends 'todo list set' with name option. Closes #1806

Extends 'todo list set' with name option

Extends 'todo list set' with name option. Closes #1806

Linked Issue

Closes #1806

Hey @waldekmastykarz / @garrytrinder  - When I initiate a PR, it seems the test is failing for this commit. Apparently test is running successfully with 100% coverage in my environment. 🤔
Check reveals that the test cases for teams team add is failing. The bizarre thing is  the file is not something which is changed in this commit.
.
Can you advise on that please. Have I done something wrong in this Pull Request?

I'll have a look. Thanks for reporting 👍

I'm not seeing the failing test on my local setup either 🤔

Same here all tests passed for me as well @arjunumenon :| Did you want to push again into the branch something insignificant may be remove an extra space that you missed etc, and see if the checks will pass?

Thanks @rabwill for the direction. I guess the suggestion may work out as expected. I will initiate the PR with a fake change and will see how that behaves.
Adding to that, PR which I had initiated yesterday #1840 passed through the build process successfully without any fail. 🤞

Same here all tests passed for me as well @arjunumenon :| Did you want to push again into the branch something insignificant may be remove an extra space that you missed etc, and see if the checks will pass?

Hey @rabwill - It worked like a charm... Simple and awesome suggestion..
Hey @waldekmastykarz  - I guess the PR  went past without any build / test error after the suggestion by @rabwill . Not sure what was the reason for the failure.
Following is what I did - Made a fake change, reverted the change. After that I had made a force-push by squashing unwanted commits so that the final commit would be clean. Kindly let me know if anything else need to be done from my side.

Awesome work @arjunumenon 👏🏻 We will review shortly.

Like @garrytrinder mentioned: well done. No further action needed on your end @arjunumenon and we'll have a look at it shortly 👍

Merged manually. Thank you!


ipfw scheduler PRIO?

Today I saw in system.log:
kernel: load_dn_sched dn_sched PRIO loaded
Does anyone know what PRIO is? There is no documentation in man page and also in google you only find a report of a kernel panic. Since dummynet "only" supports queuing, this would be very interesting.
ipfw takes this command and looks like this:
root@OPNsense:~ # ipfw sched show
10002:   3.000 Mbit/s    0 ms burst 0
 sched 10002 type PRIO flags 0x0 0 buckets 0 active
10000:  25.000 Mbit/s    0 ms burst 0
 sched 10000 type WF2Q+ flags 0x0 0 buckets 0 active
   Children flowsets: 10002 10001 10000
10001:   2.000 Mbit/s    0 ms burst 0
q75537  50 sl. 0 flows (1 buckets) sched 10001 weight 0 lmax 0 pri 0 droptail
 sched 10001 type FQ_PIE flags 0x0 0 buckets 0 active
  FQ_PIE target 15ms tupdate 15ms alpha 0.125 beta 1.25 max_burst 150ms max_ecnth 0.1 quantum 1514 limit 10240 flows 1024 ECN CapDrop TS Derand

Normally, priority queuing means, always put this first, let others starve. I'd guess you create a rule (not queue) and add it to pipe PRIO to get this running.
But I'm a bit concerned because there is really no documentation around ..
Anyone?

There seem to be defunct types, the comments are telling :D
sys/netpfil/ipfw/dn_sched_prio.c:#define DN_SCHED_PRIO	5 //XXX
sys/netpfil/ipfw/dn_sched_qfq.c:#define DN_SCHED_QFQ	4 // XXX Where?
sys/netpfil/ipfw/dn_sched_rr.c:#define DN_SCHED_RR	3 // XXX Where?

oh no, qfq and rr seem to be documented

QFQ seems to be pretty good .. but I'm interested in PRIO .. just wanted to hear what you say before I send a foolish post on freebsd-net :)

keywords are "pri" / "priority", do the same thing. only for flowsets. Used like "lmax" / "maxlen" or "weight"

These are value from FQ_PIE scheduler ;)

I don't think so. It's a general queue modifier.

I'll try to gather more info via freebsd-net .. thx


Datyson T7 / Raspberry V3B+ => Success :)

I have successfully used your excellent allsky program with following setup :

datyson T7 camera
*raspberry V3b+
To make it work, i have:
upgraded the datyson camera with the ASI122 compatible firmware from ZWO website
With the datyson attached, the RPI V3 / Raspian stretch did not boot, i correct this by :
adding the line :
program_usb_boot_mode=0
in
/boot/config.txt
This must happen quite often, so feel free to add it in the md file.
I would have been very to happy to get this information a week ago :)
Your work is really beautifull, i love you :)
Vincent Steinmetz

Hi Vincent, I have added the description to the readme file. Thanks for testing and reporting that it works fine with this brand as well.


camel-milo: enabled connection caching again.

[ ] Make sure there is a JIRA issue filed for the change (usually before you start working on it).  Trivial changes like typos do not require a JIRA issue.  Your pull request should address just this issue, without pulling in other changes.
[ ] Each commit in the pull request should have a meaningful subject line and body.
[ ] If you're unsure, you can format the pull request title like [CAMEL-XXX] Fixes bug in camel-file component, where you replace CAMEL-XXX with the appropriate JIRA issue.
[ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
[ ] Run mvn clean install -Psourcecheck in your module with source check enabled to make sure basic checks pass and there are no checkstyle violations. A more thorough check will be performed on your pull request automatically.
Below are the contribution guidelines:
https://github.com/apache/camel/blob/master/CONTRIBUTING.md

Wasn't this removed?

Yes, but i down know why. For me the caching are useful and for my usecases necessary. I will have round about 400 routes to the same OPC-UA server. I think it is not a good idea to have for each route a separate connection.
The difference to the old version is that the connection are not created on component start. Now the connection instance are later careted on consumer or producer start.

Wasn't this removed?

Yes, but i down know why. For me the caching are useful and for my usecases necessary. I will have round about 400 routes to the same OPC-UA server. I think it is not a good idea to have for each route a separate connection.
The difference to the old version is that the connection are not created on component start. Now the connection instance are later careted on consumer or producer start.

Currently the connection get closed when component stops. But i think that is to late. I want to close the connection when the routes stops.
How does the component recognizes when all routes stops?

Currently the connection get closed when component stops. But i think that is to late. I want to close the connection when the routes stops.
How does the component recognizes when all routes stops?

There is a ticket to make this better and similar to messaging components where there is a SPI
https://issues.apache.org/jira/projects/CAMEL/issues/CAMEL-16094

There is a ticket to make this better and similar to messaging components where there is a SPI
https://issues.apache.org/jira/projects/CAMEL/issues/CAMEL-16094


Snackbar does not show with attachShy(...) and NestedScrollView (mWithSnackBarImpl.updateSnackbar method never fires)

Hi,
Kudos for making a great library! I have been trying to get a SnackBar to show with attachShy(...) (as I am using a CoordinatorLayout) and the SnackBar doesn't seem to show.
This is my layout:
<android.support.design.widget.CoordinatorLayout
    xmlns:android="http://schemas.android.com/apk/res/android"
    xmlns:app="http://schemas.android.com/apk/res-auto"
    android:id="@+id/coordinator_layout"
    android:layout_width="match_parent"
    android:layout_height="match_parent"
    android:fitsSystemWindows="true">

    <android.support.v4.widget.NestedScrollView
        android:id="@+id/nested_scroll_view"
        android:layout_width="match_parent"
        android:layout_height="match_parent"
        app:layout_behavior="@string/appbar_scrolling_view_behavior">

        <TextView
                xmlns:android="http://schemas.android.com/apk/res/android"
                android:layout_width="wrap_content"
                android:layout_height="wrap_content"
                android:layout_margin="@dimen/text_margin"
                android:text="@string/large_text"/>
    </android.support.v4.widget.NestedScrollView>

</android.support.design.widget.CoordinatorLayout>

This is my setup logic:
@Override
protected void onCreate(Bundle savedInstanceState) {
    super.onCreate(savedInstanceState);
    setContentView(R.layout.activity_main);

    mCoordinatorLayout = (CoordinatorLayout) findViewById(R.id.coordinator_layout);
    NestedScrollView nestedScrollView = (NestedScrollView) findViewById(R.id.nested_scroll_view);

    if (mCoordinatorLayout != null && nestedScrollView != null) {
        mBottomBar = BottomBar.attachShy(mCoordinatorLayout, nestedScrollView, savedInstanceState);
    }

    setupBottomBarTabs();
}

This is my Snackbar invocation logic:
mBottomBar.setOnTabClickListener(new OnTabClickListener() {
    @Override
    public void onTabSelected(int position) {
        // The user selected a tab at the specified position
        Snackbar.make(mCoordinatorLayout), "Tab " + position, Snackbar.LENGTH_LONG);
    }

    @Override
    public void onTabReSelected(int position) {
        // The user reselected a tab at the specified position!
        Snackbar.make(mCoordinatorLayout, "Tab " + position, Snackbar.LENGTH_LONG);
    }
});

When I step through the code in BottomNavigationBehavior, I notice that the dependency injected into layoutDependsOn(...) is always NestedScrollView and never SnackBar.SnackbarLayout, so the logic in mWithSnackBarImpl.updateSnackbar(...) never fires.
Do I need to rearrange my layout somehow so that the SnackBar logic fires?
Thanks,
Jon

I took a look at this again and I was clearly super tired when I wrote this PR as I neglected the .show() method invocation on the Snackbar. I have since added that and the Snackbar does show... but it's huge, as mentioned in #172.


use example accelerators that align with best practices

The existing examples are platform specific. This updates them to set a better precedent for readers.

👍


ldap insecureSkipVerify - remote error: tls: handshake failure

running dex with ldap insecureSkipVerify set to true returns the error below:
017-04-12T14:54:26.707945506Z time="2017-04-12T14:54:26Z" level=error msg="Failed to login user: failed to connect: LDAP Result Code 200 \"\": remote error: tls: handshake failure"
setting the flag to false also returns the same error, any help on what might be causing this? and is it possible to get more information in the logs?
issuer: https://dex.example.com:5556
storage:
  type: kubernetes
  config:
    inCluster: true
web:
  http: <IP_ADDRESS>:5556
  #tlsCert: /etc/dex/tls/tls.crt
  #tlsKey: /etc/dex/tls/tls.key

connectors:
- type: ldap
  id: ldap
  name: ldap
  config:
    host: ldapHost:636
    #rootCA: /etc/dex/cacert.pem
    insecureSkipVerify: true
    bindDN: bindDN
    bindPW: bindPW
    userSearch:
      baseDN: ldapBaseDN
      username: uid
      idAttr: uid
      emailAttr: email

      nameAttr: cn
    groupSearch:
      baseDN: ldapBaseDN
      filter: filter
      userAttr: uid
      groupAttr: group
      nameAttr: cn
oauth2:
  skipApprovalScreen: true

staticClients:
- id: client-id
  redirectURIs:
    - https://client.example.com/callback
  name: clientName
  secret: clientSec
enablePasswordDB: false

Why are you providing both insecureSkipVerify and a rootCA? If you have the latter you don't need the former.
We're just printing the error from the LDAP library we're using https://github.com/go-ldap/ldap.
Maybe we're mixing up LDAPS and LDAP with TLS negotiation?[0] What server are you using?
[0] http://www.openldap.org/faq/data/cache/605.html

ok, im running IBM Directory Server 6.3

There's some more details here: https://github.com/coreos/dex/pull/908
IBM Directory Server should support LDAPS[0]. Do you have ldapsearch available, or an equivalent tool? What happens when you use those to connect to port 636?
[0] https://www.ibm.com/support/knowledgecenter/SSEP7J_10.2.1/com.ibm.swg.ba.cognos.c8pp_inst.10.2.1.doc/t_stp_ssl_ldap.html

ldapsearch connects fine with the following:
openssl s_client -showcerts -connect <ldapHost>:636 </dev/null | openssl x509 -outform PEM -out /tmp/cacert.pem; env LDAPTLS_CACERT=/tmp/cacert.pem ldapsearch -x -H ldaps://<ldapHost>:636
simple connect response:
# extended LDIF
#
# LDAPv3
# base <> (default) with scope subtree
# filter: (objectclass=*)
# requesting: ALL
#

# search result
search: 2
result: 0 Success

# numResponses: 1

Is this still an issue?

@ericchiang, yes, still an issue. running the latest release. that insecureSkipVerify flag doesnt seem to have any effect.

that insecureSkipVerify flag doesnt seem to have any effect.

Little confused by that. Based on my testing this does work https://github.com/coreos/dex/pull/1096


Tint color is not applied to icons

I expected that config.colors.tintColor would be applied to all the elements, but it's not applied to the icons.
Shouldn't it be like that?

@fenixsolorzano Good one, what icon in particular are you looking to tint?

All of them, (I believe the ones are the flash and rotate)

There is 2022 year outside🎉 Old outdated issues are closing. Please search if there are already existing issues with the same problem before opening new ☮


Output Exclusion

I'd like to display a waybar on all outputs BUT my primary output that only shows "sway/workspaces" and display my normal waybar on my primary output. At the moment if i define a waybar (workspaces only) without assigning an output and defining a waybar with all my preferences for my eDP-1 then i get 2 bars on eDP-1.
Is it possible to exclude an output in the "output" field?

Hi, is this closed issue? Because it is mentioned in configuration part at https://github.com/Alexays/Waybar/wiki/Configuration#multi-output-config
but output exclusion does not seem to work for me. I am using Waybar v0.9.2 (Apr 11 2020, branch 'makepkg')

@mab122 Wiki was updated a bit early, it's now possible as #596 is merged!

It doesn't work for me.
I've tested this with Waybar v0.9.2-64-g4b28518 (May 12 2020, branch 'master') from the AUR.
My Config:
[
  {
    "output": ["!eDP-1"],
    "layer": "top",
    "modules-left": ["sway/workspaces", "sway/mode"],
    "modules-right": ["clock", "tray"]
  },

  {
    "output": ["eDP-1"],
    "height": 38,
    "layer": "top",
    "modules-left": ["sway/workspaces", "sway/mode", "custom/media"],
    "modules-right": ["mpd", "idle_inhibitor", "blah", "blah", "blah"],
SNIP
  }
]

The first bar isn't displayed on any screen, the bar for eDP-1 is displayed normally.

My mistake
correcting the line
"output": ["!eDP-1"],
to
"output": "!eDP-1",
fixed it


login error

Hello, I am trying to use 0.3.0, but get an error when trying to login:
>>> from usgs import api
>>> api.login("user","password",save=True)
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/home/sylvain/.virtualenvs/eodag-dev/lib/python3.8/site-packages/usgs/api.py", line 119, in login

  File "/home/sylvain/.virtualenvs/eodag-dev/lib/python3.8/site-packages/usgs/api.py", line 38, in _create_session
    api_key = _get_api_key(api_key)
  File "/home/sylvain/.virtualenvs/eodag-dev/lib/python3.8/site-packages/usgs/api.py", line 22, in _get_api_key
    api_key_info = json.load(f)
  File "/usr/lib/python3.8/json/__init__.py", line 293, in load
    return loads(fp.read(),
  File "/usr/lib/python3.8/json/__init__.py", line 357, in loads
    return _default_decoder.decode(s)
  File "/usr/lib/python3.8/json/decoder.py", line 337, in decode
    obj, end = self.raw_decode(s, idx=_w(s, 0).end())
  File "/usr/lib/python3.8/json/decoder.py", line 355, in raw_decode
    raise JSONDecodeError("Expecting value", s, err.value) from None
json.decoder.JSONDecodeError: Expecting value: line 1 column 1 (char 0)

Hi @sbrunato - have you previously used this library? When save=True during login, a hidden file is written to the user's home directory, $HOME/.usgs. If that file is lingering from a previous login using an older version, it might trigger the JSON parse error you're seeing.
Can you try deleting the .usgs file if it exists?

Thank you very much @kapadia,  deleting ~/.usgs fixed the issue


Fix build break in LeapMotionDeviceManager.cs

Overview
A local field was removed in #10440 but not updated in all cases.

/azp run


Fix comparison of Float with String failed when WD_CACHE_TIME is set

⚠ This PR code has not been tested as I am using Semaphore 1.0 which does not rely on threads for parallel tests. But I thought I would share it if it can help :)
command
bundle exec rake webdrivers:chromedriver:update WD_CACHE_TIME=86_400 WD_INSTALL_DIR=$SEMAPHORE_CACHE_DIR
stacktrace
ArgumentError: comparison of Float with String failed
/home/runner/dossier/vendor/bundle/ruby/2.4.0/gems/webdrivers-4.0.0.rc1/lib/webdrivers/system.rb:48:in `<'
/home/runner/dossier/vendor/bundle/ruby/2.4.0/gems/webdrivers-4.0.0.rc1/lib/webdrivers/system.rb:48:in `valid_cache?'
/home/runner/dossier/vendor/bundle/ruby/2.4.0/gems/webdrivers-4.0.0.rc1/lib/webdrivers/common.rb:153:in `with_cache'
/home/runner/dossier/vendor/bundle/ruby/2.4.0/gems/webdrivers-4.0.0.rc1/lib/webdrivers/chromedriver.rb:34:in `latest_version'
/home/runner/dossier/vendor/bundle/ruby/2.4.0/gems/webdrivers-4.0.0.rc1/lib/webdrivers/common.rb:127:in `correct_binary?'
/home/runner/dossier/vendor/bundle/ruby/2.4.0/gems/webdrivers-4.0.0.rc1/lib/webdrivers/common.rb:83:in `update'
/home/runner/dossier/vendor/bundle/ruby/2.4.0/gems/webdrivers-4.0.0.rc1/lib/webdrivers/tasks/chromedriver.rake:25

Hi @jmgarnier, thanks for the pull request. I thought I had caught and fixed this in my PR, but apparently not.
Anyway, I have fixed this under 10a5bee3518a65c480fb9dd5815153678f0b3e3c and added a spec for it. We'll release a 4.0.0.rc2 very soon with this fix.

And sorry, didn't mean to take credit for your contribution. I just found a better spot to implement the fix and wanted to add a spec for it.
I appreciate you reporting this!

thanks for all the kind words @kapoorlakshya . No offenses, no credit needed! Thanks for quick feedback & sharing your work for free :)


Add Test-Microarchitectural to Report-Coverage dependencies

The dependency to Test-Microarchitectural is missing in Report-Coverage job, but its output is required:
https://github.com/chipsalliance/Cores-VeeR-EL2/blob/d6fe0beba3f76e24500a22bda43ef2306e76503f/.github/workflows/report-coverage.yml#L51-L55
I think it usually works despite missing dependency, because this job finishes sooner than other jobs listed as dependencies.

LGTM


flushable routes cache

Prevents multiple loading when application has multiple RouteServiceProvider classes.
Related with #44221
@taylorotwell what about this approach? This way should be possible to reload routes cache.

I can't really add to contracts on a patch release - I'm not sure I even totally understand the problem you are describing. Can you give example packages, etc.

@taylorotwell for example:
https://github.com/area17/twill/blob/2.x/src/RouteServiceProvider.php
it extends from Illuminate\Foundation\Support\Providers\RouteServiceProvider
so register is called twice: https://github.com/laravel/framework/blob/1d8e86193fd1740606a836f25043e84fe78c562d/src/Illuminate/Foundation/Support/Providers/RouteServiceProvider.php#L37
then exists two boot callback for routes cache:
https://github.com/laravel/framework/blob/1d8e86193fd1740606a836f25043e84fe78c562d/src/Illuminate/Foundation/Support/Providers/RouteServiceProvider.php#L108

Now I was trying another workaround:
protected function loadCachedRoutes()
{
    $this->app->booted(function () {
        if ($this->app['router']->getRoutes()->count() === 0) {
            require $this->app->getCachedRoutesPath();
        }
    });
}

then encountered this:
https://github.com/Intervention/image/pull/1184
Not every package/application respects route caching to use this approach.


Add query building API for the $densify aggregation pipeline stage

$densify (see also the syntax document) has a few syntax rules that are not easy to express via API, which is why the implementation is not trivial as one might have expected: partitionByFields while sometimes being optional is required if range.bounds is "partition", which means that we have to "know" whether range.bounds is "partition" or not at a point when partitionByFields may be set, and require setting it by causing a compile-time error.
You may see how the API usage looks like, or play with it in AggregatesFunctionalSpecification.'$densify'.
TODO: Regardless of the API approach the team agrees with, this PR will need Iterables.concat from https://github.com/mongodb/mongo-java-driver/pull/966 to follow the same approach to varargs for PartitionByFieldDensifySpecificationBase.partitionByFields.
JAVA-4350

Converted to draft to express step as a separate interface. This will simplify things.

Converted to draft until there is a decision on whether we should use a different approach proposed by @katcharov.

Moved back to "Ready for review".

The PR was refactored. A single pipeline stage specification is no longer used. Instead

the required fields are represented as params of Aggregates.densify methods;
the API uses an object that represents optional fields (similarly to Aggregates.bucket, Aggregates.search; the API of this object has the same style as the API of SearchOptions).


pycall validation error

im trying to run these lines of code in atom and python3.6 :
from pycall import CallFile, Call, Application
import sys

def call():
        c = Call('SIP/200')
        a = Application('Playback', 'hello-world')
        cf = CallFile(c, a)
        cf.spool()

if __name__ == '__main__':
        call()

and my sip.conf and extension.conf are shown below:
sip.conf

[general]
disallow=all
allow=g729
allow=ulaw
allow=alaw
context=local_test
allowguest=no
allowoverlap=no
bindport=5060
bindaddr=<IP_ADDRESS>
srvlookup=no
alwaysauthreject=yes
canreinvite=no
nat=yes
session-timers=refuse
localnet=<IP_ADDRESS>/<IP_ADDRESS>
host=dynamic
callevents=yes
notifyhold = yes
callcounter=yes

[100]
type=friend
host=dynamic
secret=123
context=local_test

[200]
type=friend
host=dynamic
secret=123
context=local_test

extension.conf
[local_test]
exten => 1234,1,Answer ; answer the call
exten => 1234,2,Playback(tt-weasels) ; play an audio file that simulates the voice of the called user
exten => 1234,3,Hangup ; hang up the call

exten => 100,1,Set(VOLUME(RX)=10) ; set the RX volume
exten => 100,2,Set(VOLUME(TX)=10) ; set the RX volume
exten => 100,hint,SIP/100; hint  '100' used for presence notification
exten => 100,3,Dial(SIP/100) ; call the user 100'

exten => 200,1,Set(VOLUME(RX)=10) ; set the RX volume
exten => 200,2,Set(VOLUME(TX)=10) ; set the RX volume
exten => 200,hint,SIP/100; hint  '200' used for presence notification
exten => 200,3,Dial(SIP/200) call the user '200' used for presence notification

main.py
from pycall import CallFile, Call, Application
import sys

def call():
        c = Call('SIP/200')
        a = Application('Playback', 'hello-world')
        cf = CallFile(c, a)
        cf.spool()

if __name__ == '__main__':
        call()

finally i faced with this error:
Traceback (most recent call last):
  File "/home/pd/gits/voiphone/main.py", line 12, in <module>
    call()
  File "/home/pd/gits/voiphone/main.py", line 9, in call
    cf.spool()
  File "/home/pd/telephonerelayEnv/lib/python3.6/site-packages/pycall/callfile.py", line 135, in spool
    self.writefile()
  File "/home/pd/telephonerelayEnv/lib/python3.6/site-packages/pycall/callfile.py", line 123, in writefile
    f.write(self.contents)
  File "/home/pd/telephonerelayEnv/lib/python3.6/site-packages/pycall/callfile.py", line 118, in contents
    return '\n'.join(self.buildfile())
  File "/home/pd/telephonerelayEnv/lib/python3.6/site-packages/pycall/callfile.py", line 100, in buildfile
    raise ValidationError
pycall.errors.ValidationError

i would appreciate if you help me solving my problem.
thank you in advance

Run as asterisk user.
sudo su asterisk -s /bin/bash

python

from pycall import CallFile, Call, Application
call = Call('SIP/flowroute/18882223333')
action = Application('Playback', 'hello-world')
c = CallFile(call, action)
c.spool()


Model：BW-SPF1 WiFi Pet Fountain Led Version/UV Version

Hi i try add this Fountain
By Smart Life detect switch on/off
but no uv/light
Is possible to add this to a home assistant?
Codes from IOT
{
"result": [
{
"code": "switch",
"value": true
},
{
"code": "uv",
"value": false
}
],
"success": true,
"t":<PHONE_NUMBER>603
}
{
"result": {
"active_time":<PHONE_NUMBER>,
"biz_type": 18,
"category": "cwysj",
"create_time":<PHONE_NUMBER>,
"icon": "smart/icon/ay1506337792739cXrIR/53d4d09e6737c1fc9926e1dfbeb555ef.jpg",
"id": "4737134140f5203638ab",
"ip":
"lat": "52.0794936",
"local_key":
"lon": "21.0107744",
"name": "BW-SPF1",
"online": true,
"owner_id": "18127768",
"product_id": "1x7uxzc0itrepcrb",
"product_name": "BW-SPF1 UV Version",
"status": [
{
"code": "switch",
"value": true
},
{
"code": "uv",
"value": false
}
],
"sub": false,
"time_zone": "+01:00",
"uid": "eu1604020388098rm3hC",
"update_time":<PHONE_NUMBER>,
"uuid": "4737134140f5203638ab"
},
"success": true,
"t":<PHONE_NUMBER>962
}
Is any chance for integration?

@robertbigk
We will consider it in the next release.

@robertbigk The pet water feeder is supported in v1.3.

Hi can You explane me what is 1.3? how and what I need update?

Work thx allot!!!

Can we also have a low water level warning?

Superb if possible sure:)

Or You ask me? yes i got this kind warning in original app

No i was wondering if we could also get the low level sensor in to ha

Is it possible to have the low level sensor available in HA?


refactor(katana): move predeployedAccounts under DevApi and remove KatanaApi

Closes #2292.
@kariy as discussed it makes sense to have predeployedAccounts endpoint only available under --dev option.
Also, I had the feeling that KatanaApi would certainly ends up being testing mostly, so I deleted it.
But we may actually keep it even if empty, and be completed later if some endpoints make sense to be present even when not in --dev mode. 👍

Summary by CodeRabbit

New Features

Introduced a new asynchronous method to retrieve predeployed accounts, enhancing client-server interactions.
Updated the KatanaRunnerConfig to support a development mode, improving configurability for developers.

Bug Fixes

Removed the Katana API from default configurations, streamlining available API options and preventing potential errors in production environments.

Documentation

Added clarifications regarding the new dev field in KatanaRunnerConfig to guide users on its purpose.

Chores

Updated API endpoint references in code to reflect the removal of the Katana API.

looks alright. removing the katana api seems fine since there's only predeployAccounts under it and it also feels somewhat redundant to have too many namespaces, but maybe we're possibly breaking user code a lil bit by outright changing the namespace of the method? because now they have to do two things; use --dev when starting katana, and change katana_ -> dev_. simply putting katana api under --dev seems less intrusive.
just a lil thought but not married to the idea. what you did is most probably fine.

Yeah I was thinking the same at first. But then, realized that may be better to have this clearly identified as a dev feature.
This change will impact:

sozo: to ensure it uses the new namespace.
slot: --dev option must be exposed (or we should first implement the selection of namespace, doing so the --dev becomes obsolete and slot should expose the namespace selection as Katana plans to do).

We may actually make this refactor here? WDYT? Your comment on doing this namespace selection makes the devX very nice for future namespaces addition.


debashify README

Fixes #22.

Seems fine, but doesn't address #22 IMO.

Seems fine, but doesn't address #22 IMO.

Using $CONDA_EXE to create the environment now.


feat(pack): Google Kubernetes Engine improvements

Summary
Added new graphs to the dashboard and 3 new alerts.
Pre merge checklist

[x] Did you check you NRQL syntax? - Does it work?
[x] Did you check your dashboard image quality? -  Do they look good?
[x] Did you check that your alerts actually work?
[x] Did you include an InstallPlan and Documentation reference?
[x] Did you check your descriptive content for voice, tone, spelling and grammar errors?
[x] Did you attach images of your dashboards to the PR so we can see them working?

Screenshots

Hello, the action<EMAIL_ADDRESS>is failing because I changed the name of a file in /dashboards.
Looks like a change from the current version v1.2.3 to v1.2.4 or master could help fix it, as mentioned by trilom here

Also, @jpvajda if you think this dashboard and alerts are okey. I can implement the same for /azure-kubernetes-service and /kubernetes since they are practically the same?
Otherwise, would you like any changes?

I don't see any difference between this and our existing Kubernetes quickstart - Are there any any GKE specific metrics in here? I would love to see GKE specific metrics that aren't in our generic kubernetes quickstart.

@EmilHammarstrand we could definitely reuse these dashboards for /azure-kubernetes-service and /kubernetes if they apply to those quickstarts,  though it sounds like @lazyplatypus was looking for something specific for GKE metrics in these dashboards

@lazyplatypus I will look into the GKE specific metrics, thanks.

@lazyplatypus how do you feel about merging this in now? If any improvements are required, we can submit a new PR. cc @EmilHammarstrand

@jpvajda could we wait with the merge a little bit?
This thursday I will work on adding GKE specific metrics!

@EmilHammarstrand sure that works. Let me move this back to in-progress then.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.1 out of 2 committers have signed the CLA.:white_check_mark: EmilHammarstrand:x: John P VajdaJohn P Vajda seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

@EmilHammarstrand Thanks for the contributions, just a note: I am no longer with New Relic, yesterday was my last day. If  you need any assistance from the Developer Enablement team please reach out to @zstix or @aswanson-nr

Hey @EmilHammarstrand, are you still working on the content of this PR or should we start getting it merged?

Hey @EmilHammarstrand - just wanted to update ya to let you know we rolled out a change in how we do our quickstarts configuration! Specifically, we are changing the name field in config.yml to slug. I would recommend checking out our update to the contribution docs for the changes. 😄

@aswanson-nr this PR should now be ready for merge!
@josephgregoryii Thank for you the information, I have now changed it!


Climb tuning

Added retracting arm on climb, reduced slow down distance and reset encoder on limit switch

Codecov Report

Merging #40 into master will decrease coverage by 0.14%.
The diff coverage is 60%.

@@            Coverage Diff             @@
##           master      #40      +/-   ##
==========================================
- Coverage   81.74%   81.59%   -0.15%
==========================================
  Files          20       20
  Lines        1282     1288       +6
  Branches      120      122       +2
==========================================
+ Hits         1048     1051       +3
- Misses        208      210       +2
- Partials       26       27       +1

Impacted Files
Coverage Δ

components/climb.py
64.92% <60%> (-0.73%)
:arrow_down:

automations/climb.py
35% <60%> (+1.66%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1bda7e4...8aa93a1. Read the comment docs.


worksheet.commit is not a function

I'm sure I'm being an idiot and it's too late to be programming but I can't see it. plz help.
   //...
    const workbook = new Excel.Workbook();
    const worksheet = workbook.addWorksheet(period, {
        views: [{ xSplit: 1 }],
        properties: { defaultRowHeight: 32 },
        pageSetup: { verticalCentered: true },
    });
    worksheet
        .addRow(['Date', 'Initials', 'Name', 'Period', 'Wines', 'Notes'])
        .commit();
    worksheet.getRow(0).font = { bold: true };
    _.each(invoices, (invoice) => {
        let notes = [];
        if (invoice.status !== 'paid') {
            notes.push('Not Paid!');
            if (_.get(invoice.customer.metadata, 'pays_on_pickup') !== 'true') {
                notes.push('Update CC#');
            }
        }
        worksheet
            .addRow([
                '',
                '',
                invoice.customer.name,
                period,
                invoice.metadata.hold_code,
                notes.join(', '),
            ])
            .commit();
    });
    worksheet.commit(); // <== ERROR HERE
    response.setHeader(
        'Content-Type',
        'application/vnd.openxmlformats-officedocument.spreadsheetml.sheet'
    );
    response.setHeader(
        'Content-Disposition',
        `attachment; filename=Holds Pickup List ${period}.xlsx`
    );
    response.end(await workbook.xlsx.writeBuffer());

I am facing the exact same problem:
  saveToExcel = (path: string, data: IItem[]) => {
    let workbook = new Excel.Workbook();
    workbook.creator = 'StorePro';
    workbook.lastModifiedBy = 'Her';
    workbook.created = Date.today();
    workbook.modified = null;
    workbook.lastPrinted = new Date(2016, 9, 27);

    workbook.views = [{
      x: 0, y: 0, width: 10000, height: 20000,
      firstSheet: 0, activeTab: 1, visibility: 'visible'
    }];

    let ws1 = workbook.addWorksheet(
      'Datasheet',
      { pageSetup: { paperSize: 9, orientation: 'landscape' } }
    );

    data.map(x => {
      ws1.addRow(x).commit();
    });

    ws1.commit(); // PROBLEM HERE

    const writeStream = fs.createWriteStream(path);

    workbook.xlsx.writeBuffer({ stream: writeStream, useStyles: true, useSharedStrings: true })

    writeStream.close();
  }

I get the following error:
TypeError: ws1.commit is not a function
    at ViewInventory._this.saveToExcel (webpack:///./src/components/Inventory/ViewInventory.tsx?:122)
    at eval (webpack:///./src/components/Inventory/ViewInventory.tsx?:95)

Oh I figured this out and forgot to close. commit() was not necessary for my workflow after all. I remove it from the rows and the worksheet and writing the buffer to the return stream worked just fine 🤷♂

Hey @anstosa,
similar issue happen to me but with the error: TypeError: T.createWriteStream is not a function.
I am using : "exceljs": "^3.4.0"
My code is:
import Excel from 'exceljs';
// OR
import * as Excel from 'exceljs';

export default () => {
    const workbook = new Excel.Workbook();
    const worksheet = workbook.addWorksheet('My Sheet');

    worksheet.columns = [
        { header: 'Id', key: 'id', width: 10 },
        { header: 'Name', key: 'name', width: 32 },
        { header: 'D.O.B.', key: 'dob', width: 15 },
    ];

    worksheet.addRow({ id: 1, name: 'John Doe', dob: new Date(1970, 1, 1) });
    worksheet.addRow({ id: 2, name: 'Jane Doe', dob: new Date(1965, 1, 7) });

    // save under export.xlsx
    workbook.xlsx.writeFile('export.xlsx');

Maybe you encountered in a similar error?


feat: improve typing for layout context

By setting the strictNullChecks TypeScript option to true, I saw multiple typings problem (53 total). Here is a first change to remove 6 issues based on LayoutContext typings.

Note for when I'll have some time, fix SonarCloud issue using comments and not undefined


Ignore known warning poo#17600

@foursixnine, @Soulofdestiny I assume you have received the same error message by email?


"nonspacing mark" unicode causes container's width to shift

Describe the bug
Nonspacing mark unicodes are a type of character that doesn't consume space; instead, they "attach" themselves to the previous character. For example, "ี" or "ุ" are nonspacing marks commonly attached to another character like "ด," resulting in "ดี" or "ดุ."
When there are nonspacing mark unicodes inside lipgloss's container, the layout will shift on that line because lipgloss counts these characters as normal unicode that occupy 1 space.
Setup
Please complete the following information along with version numbers, if applicable.

macOS
zsh
iterm2
th_TH.UTF-8

To Reproduce
Steps to reproduce the behavior:

Create a style with a fixed width, such as 16 characters.
Render it with a string that has nonspacing mark unicodes, for example, "สวัสดี." ("ั" and "ี" are nonspacing marks)
See the layout shift.

Source Code
package main

import (
	"fmt"

	"github.com/charmbracelet/lipgloss"
)

var box = lipgloss.NewStyle().Width(8).Height(8).Border(lipgloss.RoundedBorder())

func main() {
	fmt.Println(box.Render("สวัสดี"))
}

Screenshots

This is a known issue that is pending these pull requests:

#257
muesli/reflow#71

Without these being merged, the problem cannot be resolved. For context, this is due to incorrect rune width calculations not handling grapheme clusters (which obviously understand ZWJ).

Confirmed this is fixed with the pull requests I have listed above:

Look like it's fixed on master branch now, thank!


Happened on version 1.19.2

[08/06/2023 21:30:26 p.m.] Caused by: java.lang.UnsupportedOperationException: A mod tried to access the state neighbor table directly. Please report this at https://github.com/malte0811/FerriteCore/issues. As a temporary workaround you can enable "populateNeighborTable" in the FerriteCore config

I believe this was the mod that tried to do it, https://www.9minecraft.net/little-maid-rebirth-mod/

Please upload the full crashlog. You should never download mods from 9minecraft, they are known for re-hosting mods without consent of the modders. CurseForge and modrinth are the main "good" sources for mods.

tl-logger11346663665548823417.txt


Add to aqua-registry

https://github.com/aquaproj/aqua-registry
https://github.com/suzuki-shunsuke/example-renovate-issue-action/blob/9b43cc526e7e7607a3c77fb126e29de1872b6730/registry.yaml

https://github.com/aquaproj/aqua-registry/releases/tag/v2.8.0


Fix bwlimit toggle in conjunction with schedules (Fixes #1607)

See issue #1607. The fix in a nutshell:

Remove assignment side effect from newTokenBucket
Set either prevTokenBucket or tokenBucket on bwlimit schedule changes, depending on whether bwlimit is toggled on or off

That looks great, thanks.  I have reviewed and merged :-)


Unable to create a instance on hyper-v host

ISSUE TYPE

Other

COMPONENT NAME
Hyper-v

CLOUDSTACK VERSION
4.19

CONFIGURATION

OS / ENVIRONMENT

SUMMARY
Hyperv installed  and cloudstack agent installed in hyper-v and it is attached to cloudstack managment successfully. I have created Primary storage as SMB and secondary as SMB. All the componets are got attached and it is in green.
I am trying to  create one instance with ubunutu 22 and windows server 2019  in hyperv through cloudstack but i'm getting the below error " Hypervisor Hyperv does not support rootdisksize override"
Can any one help us on this.
STEPS TO REPRODUCE
I am trying to  create one instance with ubunutu 22 and windows server 2019  in hyperv through cloudstack but i'm getting the below error " Hypervisor Hyperv does not support rootdisksize override"

EXPECTED RESULTS

Hyper-v instance creating thorugh cloudstack

ACTUAL RESULTS

Hyperv installed  and cloudstack agent installed in hyper-v and it is attached to cloudstack managment successfully. I have created Primary storage as SMB and secondary as SMB. All the componets are got attached and it is in green.
I am trying to  create one instance with ubunutu 22 and windows server 2019  in hyperv through cloudstack but i'm getting the below error " Hypervisor Hyperv does not support rootdisksize override"

@kedupuganti-kub I am not sure if there are active hyperv users at the moment. There are no hyperv maintainers. We'll try to help of course. First thing to check: Are the systemvms up and running?

this seems to be caused by #7692
https://github.com/apache/cloudstack/blob/9a73a2f9e1433103373e7bd9da8b5feef4479feb/server/src/main/java/com/cloud/vm/UserVmManagerImpl.java#L665-L671
as @DaanHoogland said, the plugin is not well-maintained.

I have tried to  https://github.com/apache/cloudstack/pull/7692 tried in this way
but  the problem here  the  error which i am getting is  22 port  on hyperv and saying that "kvm is not installed in the host" as i am looking for the hyperv integration.
Could you please help me i need to deliver this to client with hyperv

@kedupuganti-kub are your systemvms up and connected?

No Daan no systemvms  is not running. But agent is started in the hyperv and it is added to cluster.
I have another KVM cluster in that it is running.


h3ToGeoBoundary returns duplicate points for some hexagons

Certain hexagons (including at least some on the edge of the icosahedron face) have duplicate points generated by h3ToGeoBoundary:
$ ./bin/h3ToGeoBoundary
894cc536537ffff
894cc536537ffff
{
   18.043333154<PHONE_NUMBER>65
   18.042238363<PHONE_NUMBER>72
   18.040818259<PHONE_NUMBER>61
   18.040492975<PHONE_NUMBER>33
   18.041040385<PHONE_NUMBER>17
   18.041757122<PHONE_NUMBER>85
   18.043007860<PHONE_NUMBER>18
   18.043007860<PHONE_NUMBER>18
}

The last two vertices here are duplicates. The repeated vertex causes problems in the generation of GeoJSON boundaries.
Will update this issue when I find more details on which hexagons are causing the problem.

Pretty sure this is the result of some Class III hexagons having vertexes directly on the icosahedron edge - those vertices are duplicated.

We noticed that these duplicated vertices are shared with the parent class II hexagon, which might be useful when excluding them from output.

Closed in #46 .


Refactor test data for cellranger modules

closes #867
major refactor of 10X Genomics Cellranger test data to accommodate adequate testing for a new cellranger multi module (https://github.com/nf-core/modules/pull/3229)
test data now all now sit within a cellranger/ folder under data/genomics/homo_sapiens/illumina/10xgenomics/
test data for other *ranger software (cellranger-arc, cellranger-atac, spaceranger) could be easily as sister folders

m guessing this will also need an update to modules/tests/config/test_data.config once this is approved

I sort of feel this shouldn't be embedded in illumina/ as it's even if it uses Illumina sequencing, it is a separate platform I guess, but rather alongside. Secondly it's not derived from the main chr22 (or chr21? don't remember now) dataset like the vast majority of the other data in that folder, so by pushing it to a sister folder that will be slightly clearer. But that's my personal opinion.
Otherwise the data is small, and well documented with their own personal READMEs (which isn't the standard, but I think it's helpful here when we are dealing with prop. software).
Only thing missing is the short descriptions on the main repo README (on the modules branch).

m guessing this will also need an update to modules/tests/config/test_data.config once this is approved
@sateeshperi I intend to handle it in https://github.com/nf-core/modules/pull/3229, since I also need to point all cellranger module tests to the new or adjusted data paths anyways

it will be a pretty big fix 😵 but eminently doable

by pushing it to a sister folder that will be slightly clearer. But that's my personal opinion.
@jfy133 I have no strong feelings either way

I think that all these 10X test data were sequenced on Illumina platforms, but they definitely aren't derived from chr21/chr22
I'll move these data to data/genomics/homo_sapiens/10xgenomics (sister to illumina)

Thanks for moving @klkeys ! You're missing still the update to the main data descritopr section of the README:
https://github.com/nf-core/test-datasets/tree/modules#data-description
CAn ocme in a follow up PR :)

🤦🏼🤦🏼🤦🏼  thank you for keeping me accountable @jfy133
I'll open that PR shortly 👍🏼

see https://github.com/nf-core/test-datasets/pull/884

thanks for this heads-up @adamrtalbot
the original 10X GEX FASTQs got replaced, but there are new FASTQs with the same 10x single cell 3' v3 chemistry
did a quick grep -R "test_10x_1_fastq_gz" * in this repo, and looks like I also broke kallistobustools/count 😣
since I broke things, I'll compile fixes and post a PR soon 👍🏼

see here: https://github.com/nf-core/modules/pull/3486


UI: Inconsistent status in the multi-branch pipeline list page

Screenshot from DevOps page:

Screenshot from Jenkins page:

As you can see from the above screenshot pages. The color of deleted git branch Pipeline was gray in Jenkins UI. But there's no difference on the DevOps page. It makes people feel confused.
The backend response already has the data of that status. Please see also the following screenshot:

/good-first-issue

/area console

/kind console

/need-to-verify

/kind need-to-verify

same as:https://github.com/kubesphere/ks-devops/issues/946
already fixed.


How to log request and response xml format

package version ".2."
laravel lumen version: "5.3.3"
Is there any way to view/log request and response in xml format.

This package is just a wrapper around the PHP SoapClient.
It will work the same as the PHP SoapClient.
You will need the same request and will get the same response.
So if the response is XML, yes you will get XML.


No need analytics from the dev app

https://bithyve-workspace.slack.com/archives/C037SN606P2/p1720172449751709
Refer to above.

CC @cakesoft-shashank Closing this


Support Shadowsocks Proxy

Please support of Shadowsocks Proxy in TDLib
SSR Files

Shadowsocks proxy can be connected using Socks5 protocol, which is already supported.


⚠ Bofrost.lu has degraded performance

In 88525ac, Bofrost.lu (https://www.bofrost.lu) experienced degraded performance:

HTTP code: 200
Response time: 2397 ms

Resolved: Bofrost.lu performance has improved in 7f469d4 after 53 minutes.


Consider math-agnostic API

Looks like the API is hand-wired to use glam currently. Are there any barriers to expose mint instead, thus turning glam to be a private dependency?

I don't really have a good reason for not exposing mint at the edge besides convenience and not needing to spam .into() all over the place. There is an interesting question that falls out of this which is how much should be mint vs glam -- I expose a lot of my private apis as public to allow people to implement their own renderlists. It would be a bother to expose all of that as mint. I think a reasonable middle ground would be having the "user" facing api be mint and the "implementer" api be glam.
This would still mean upgrading glam is a semver break, but this whole crate is basically a semver trap as it is.

I see. Yeah, exposing all the internals doesn't work very well with mint. Feel free to close!

Not going to close this as I'm not sure what I want to end up doing, but going to pull this off v0.1.0


Windows tool_integration_tests_3_6 flakes on expression_evaluation_test

(part of https://github.com/flutter/flutter/issues/97036)
Hit one flake today:
expression_evaluation_test.dart
03:23 +9 -1: test\integration.shard\expression_evaluation_test.dart: flutter test expression evaluation - can evaluate expressions returning complex objects in a test [E]
  Expected: <Instance of 'InstanceRef'> with `valueAsString`: '2022-5-5'
    Actual: InstanceRef:<[InstanceRef id: objects/5, kind: String, identityHashCode: 0, classRef: [ClassRef id: classes/91, name: _OneByteString, library: [LibraryRef id: libraries/@0150898, name: dart.core, uri: dart:core]]]>
     Which: has `valueAsString` with value '2022-5-6' which is different.
            Expected: 2022-5-5
              Actual: 2022-5-6
                             ^
             Differ at offset 7

  package:test_api                                              expect
  test\integration.shard\expression_evaluation_test.dart 189:3  expectValue
  test\integration.shard\expression_evaluation_test.dart 172:3  evaluateComplexReturningExpressions
  ===== asynchronous gap ===========================
  test\integration.shard\expression_evaluation_test.dart 141:5  batch2.<fn>

/cc @zanderso

@DanTup The test run straddled midnight.

Marking P4 since this will certainly flake way below the threshold, but should be cleaned up.

@DanTup The test run straddled midnight.

🙈
Fix at https://github.com/flutter/flutter/pull/103269 - thanks!

Fixed by 4ab68bd04dcc9ecfb74243e8fc324e45fa904774.


Add a class_getitem to Formatter

This is a simpler and less disruptive alternative to #2081.
The type stubs in typeshed distinguish between formatters that output strings and bytes. In type annotations, these are distinguished with Formatter[str] and Formatter[bytes]. For the most part, this works fine without any changes in pygments: users just tell Python to not evaluate type annotations at runtime (with from __future__ import annotations), and then a Formatter[str] type annotation won't cause an error even though subscripting the Formatter class wouldn't work.
But one special case happens when you try to subclass a Formatter. For that, you actually need to specify a class, not a type annotation. So users end up with:
from typing import TYPE_CHECKING
from pygments.formatter import Formatter

if TYPE_CHECKING:
    StringFormatter = Formatter[str]
else:
    StringFormatter = Formatter

class MyFormatter(StringFormatter):
   ...

With this PR, this simplifies to:
from pygments.formatter import Formatter

class MyFormatter(Formatter[str]):
   ...

Merged, thanks!


Update request: koreader 2023.04 → 2024.03.1

Package name: koreader
Latest released version: 2024.03.1

Current version on the unstable channel: 2023.04
Current version on the stable/release channel: 2023.04

[x] Checked the nixpkgs pull requests

Notify maintainers
@contrun @neonfuz

Note for maintainers: Please tag this issue in your PR.

Add a :+1: reaction to issues you find important.

please test #299251


Use aws-sdk-promise

This has biggish diff.
Dominantly modification:

Absorb differences of API between amazon-api-gateway-client and aws-sdk-promise
All restapi(.*) field is renamed restApi\1 what AWS SDK uses
Implement recursive resources creation that was handled it by amazon-api-gateway-client

I just now realized what this branch has still yet some bugs, some errors occurred after fluct deploy when I accessed endpoints from web browser. I'll fix soon.

Fixed some bugs.

GREAT WORK!!!


Powertoys

Description of the new feature / enhancement
Good morning community, I installed PowerToys in windows 11 and I don't get the peek option to preview images like in macos
Scenario when this would be used?

Supporting information

Here is how another user can use that option

Hi. Peek hasn't been included yet. It's still a work in progress :-) What made you think it would be?

Peek is still being developed.  Target release is .70 per release notes.  /dup https://github.com/microsoft/PowerToys/issues/80


[terra-list]  Drag and Drop issue for terra-list in Slide panel

Summary

What was changed:
Added render clone property for drag and drop context to avoid position loss issue while dragging list item inside the terra slide panel.
Why it was changed:
Identified as a bug where the position of dragged or selected items is lost when using Terra List with draggable items inside a Terra Slide Panel component.
Testing

This change was tested using:

[x] WDIO
[ ] Jest
[ ] Visual testing (please attach a screenshot or recording)
[ ] Other (please describe below)
[x] No tests are needed

Reviews
In addition to engineering reviews, this PR needs:

[ ] UX review
[x] Accessibility review
[ ] Functional review

Additional Details

This PR resolves:
UXPLATFORM-9620

Thank you for contributing to Terra.
@cerner/terra

How was the fix tested?

Added a WDIO test case. Thanks


Vue 2 compatible TranslationComponent not working as expected

🐛 Bug Report
Thank you so much for the clear migration documentation it has mostly been a beeze to migrate from @panter/vue-i18next.
I've discovered a couple of slightly unexpected behaviors.

I think the migration docs may need to be updated. According to the docs the <i18next> component is deprecated. However, it seems it was added in V1 here
The TranslationComponent doesn't seem to be working as expected -- the child value isn't interpolated. This seemingly is because the translation prop enters the component's render function with the template values stripped (see screenshot)

To Reproduce
This is a private repository so I unfortunately cannot provide a reproduction but below is my i18next config:
import i18next from 'i18next';
import I18NextVue from 'i18next-vue';
import Vue from 'vue';

import english from '../locales/en/translation.json';
import spanish from '../locales/es/translation.json';

i18next.init({
  lng: 'en',
  nsSeparator: false,
  keySeparator: false,
  fallbackLng: false,
  resources: {
    en: { translation: english },
    es: { translation: spanish },
  },
  interpolation: {
    prefix: '{',
    suffix: '}',
  },
});

Vue.use(I18NextVue, { i18next });

export function setDefaultInterpolationVariables(variables: { [key: string]: string }) {
  i18next.options.interpolation!.defaultVariables = variables;
}

Expected behavior
The following snippet
<i18next :translation="$t('Need help with {processor}?')">
     <template #processor>{{ processor }}</template>
</i18next>

with the follow es translation file key/value pair
  "Need help with {processor}?": "¿Necesita ayuda con {processor}?",
Should render as

Instead it renders as

Your Environment

runtime version: node v16.14.2
i18next version: 19.0.0
os: Mac
any other relevant information
"vue": "2.7.14",
"i18next-vue": "^1.1.0",
"vite": "^2.5.4",

I'm happy to hear you found the migration docs helpful 😄
re 1: The 1.x documentation is indeed not up to date regarding the translation component. I'll change that to match what we have in the 2.x documentation soon.
re 2:
Why it is not working
I believe this problem is related to the Interpolation configuration you use with single curly braces:
interpolation: {
  prefix: '{',
  suffix: '}',
},

This is different from the default double curly {{/}} values. The translation component (always) uses single curly braces as well. This interferes with your config, because i18next itself will already try and interpolate all placeholders:
In your example you pass the result of $t('Need help with {processor}?') as the :translate prop. As you saw when debugging, the  $t call has replaced {processor} with nothing. This is because $t is the "ordinary" $t, which tries to interpolate all values, including {processor} with given replacements. As there is no replacement in the $t call itself, it is just removed. After that, there is no {processor} left in the translation that the translation component can replace.
With the default double curly braces configuration, $t would just get the translation, but leave the single curly placeholder  {processor} alone, so the translation component can do the interpolation.
Solution(s)
There is no simple solution in version 1.1.0 for this, assuming you can't just switch to double curly braces for i18next's interpolation.
Since version 2.2 the Vue 3 version of i18next-vue supports configuring something else than single curly braces to find what to interpolate in the translation component, see https://github.com/i18next/i18next-vue#custom-slot-values.
You could e.g. use
"Need help with {processor}?": "¿Necesita ayuda con <slot>processor</slot>?",
or another start/end pattern that makes sense for you.
This is also available on the special i18next-vue@vue-27-next version, see https://github.com/i18next/i18next-vue/tree/vue-27-next. This is a backport of i18next-vue 3.0 to Vue 2.7 and needs the same additional migration that would otherwise be necessary when switching from i18next-vue 2.x to 3.0, see https://i18next.github.io/i18next-vue/migration-v3.html.
If you are willing to that additional changes to use the @vue-27-next version, that's great.
If you'd rather have 1.x version with just configurable start/end patterns for the translation component, let me know. This is not super easy to do, but I'd then try and selectively bring back that functionality to 1.x.
P.S.
I assume the translation component example is simplified and in reality uses some HTML. Otherwise, you would not need <i18next> at all and could just let $t interpolate the plaintext processor value
{{ $t('Need help with {processor}?', {processor}) }}.

Thanks so much for getting back to me. I went with the approach of installing the i18next-vue@vue-27-next version and using the <slot></slot> custom slot values. This fixed the interpolation!
However, it seemed to cause some of my component units tests began failing that don't use the i18next component but do use Vue slot syntax (<template #foo>). I don't have as much time as I'd like to debug and it's entirely possible it's something to do with our set up not the library. I have a working shim of the @panter component so I'm going to go ahead and use that pending our upgrade to Vue 3.
Thanks again for your time and clear explanation of my options.
P.S. Yes! It was indeed a simplification for the sake of example -- thanks for the tip!


fix for issue#10415

add catch ConstraintViolationException
What is the purpose of the change
Brief changelog
Verifying this change

Checklist

[x] Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
[ ] Each commit in the pull request should have a meaningful subject line and body.
[ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
[ ] Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
[ ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
[ ] Add some description to dubbo-website project if you are requesting to add a feature.
[ ] GitHub Actions works fine on your own branch.
[ ] If this contribution is large, please follow the Software Donation Guide.

fix #10415

Codecov Report

Merging #10431 (9a8a401) into 3.0 (4b55862) will decrease coverage by 0.00%.
The diff coverage is 50.00%.

@@             Coverage Diff              @@
##                3.0   #10431      +/-   ##
============================================
- Coverage     65.66%   65.65%   -0.01%
+ Complexity      319      318       -1
============================================
  Files          1234     1234
  Lines         53916    53917       +1
  Branches       8155     8156       +1
============================================
- Hits          35402    35399       -3
+ Misses        14664    14663       -1
- Partials       3850     3855       +5

Impacted Files
Coverage Δ

.../validation/support/jvalidation/JValidatorNew.java
0.00% <0.00%> (ø)

...bbo/validation/support/jvalidation/JValidator.java
70.98% <100.00%> (-0.89%)
:arrow_down:

...he/dubbo/remoting/transport/netty/NettyServer.java
70.17% <0.00%> (-3.51%)
:arrow_down:

...pache/dubbo/registry/support/AbstractRegistry.java
74.91% <0.00%> (-2.44%)
:arrow_down:

...registry/zookeeper/util/CuratorFrameworkUtils.java
72.22% <0.00%> (-2.23%)
:arrow_down:

...ting/zookeeper/curator/CuratorZookeeperClient.java
68.53% <0.00%> (-1.73%)
:arrow_down:

...a/org/apache/dubbo/config/ReferenceConfigBase.java
62.87% <0.00%> (-1.62%)
:arrow_down:

...ubbo/registry/client/AbstractServiceDiscovery.java
88.37% <0.00%> (-1.56%)
:arrow_down:

...n/java/org/apache/dubbo/config/ConsumerConfig.java
91.17% <0.00%> (-0.72%)
:arrow_down:

... and 7 more

:mega: Codecov can now indicate which changes are the most critical in Pull Requests. Learn more


Container open event

Hi,
Hi,
I am trying to detect when a new component container is added to the DOM so I can instantiate my control.
I have looked over the documentation and I found that the "open" event should be used.
open - Emitted after the item has been sized and added to the DOM. Useful if you're working with an UI library that measures its container on startup.
This works fine on the initialization of the GoldenLayout however when using addChild method to add component (https://golden-layout.com/tutorials/dynamically-adding-components.html) the "open" event is emmited before the element to be added into the DOM.
Seems that the "show" event is triggered after the child is added in the DOM, but the "show" event is not triggered at the initial init of the  GoldenLayout
You can test my using the js code below inside this codepen: http://codepen.io/wolframhempel/pen/9dd68b285dc421364ac9ec13f2bdc999
`
var config = {
settings: {
selectionEnabled: true
},
content: [{
type: 'row',
content: [{
type:'component',
id: 101,
componentName: 'example',
componentState: { text: 'Click the black bar above to select me, then add new components from the menu' }
},
{
type:'component',
id: 102,
componentName: 'example',
componentState: { text: 'Click the black bar above to select me, then add new components from the menu' }
}]
}]
};
var myLayout = new window.GoldenLayout( config, $('#layoutContainer') );
window.MyID;
myLayout.registerComponent( 'example', function( container, state ){
var htmlElement = container.getElement()[0];
alert('created ' + container._config.id);
htmlElement.id= container._config.id;
container.getElement().html( '' + state.text + '');
});
myLayout.on('componentCreated', function (component) {
var _component = component;
component.container.on('open', function (ev) {
alert('open ' + _component.config.id + " " + document.getElementById(_component.config.id));
});
component.container.on('show', function (ev) {
alert('show ' + _component.config.id + " " + document.getElementById(_component.config.id));
});
});
myLayout.init();
var addMenuItem = function( title, text ) {
var element = $( '' + title + '' );
$( '#menuContainer' ).append( element );
var newItemConfig = {
    title: title,
    id: Math.round(Math.random()*10) + 1,
    type: 'component',
    componentName: 'example',
    componentState: { text: text }
};

element.click(function(){
    if( myLayout.selectedItem === null ) {
        alert( 'No item selected. Plsfsdf ease click the black header bar to select which item you want to add new items to1' );
    } else {
        myLayout.selectedItem.addChild( newItemConfig );
    }
});

};
addMenuItem( 'Add me!', 'You've added me  !' );
addMenuItem( 'Me too!', 'You've added me too!' );
`

I believe this is related to #273 and #239.  I'm struggling with the same issue.


onBounce event emitted from a Physics.Arcade.Body

Hello there,
I tried recently to achieve a way of getting an Arcade Physics Body to emit an event without changing Phaser's source code, however, I found myself unable to do so.
I would kindly drop a pull request adding said functionality, however, I would like to ask here first if is there a way already to do it.
Please let me know if really there is no way to do so at the moment, so I can start and draft a pull request for it.
Thanks in advance.

Hi - Thanks for the offer of a PR. First, could you explain why you'd need an onBounce event when you've already got onCollide? (as a bounce cannot happen without a collision)

Hello @photonstorm , thank you for the quick response.
In my idea, the reason for having a universal event onBounce is that it would work with both World Bounds and other bodies. It would simplify and prevent the need of keeping track of everything that is collidable and not having to add an add.onCollide() to each possible collidable body, plus, listening for the worldbounds event.
In the following example, you can see that the collide event is not emitted when it happens to a world bound:
var config = {
    type: Phaser.AUTO,
    width: 800,
    height: 600,
    parent: 'phaser-example',
    physics: {
        default: 'arcade',
        arcade: {
            gravity: {
                y: 200
            }
        }
    },
    scene: {
        preload: preload,
        create: create
    }
};

var game = new Phaser.Game(config);

function preload ()
{
    this.load.image('bg', 'assets/skies/space2.png');
    this.load.spritesheet('ball', 'assets/sprites/balls.png', { frameWidth: 17, frameHeight: 17 });
}

function create ()
{
    this.add.image(400, 300, 'bg');

    var group = this.physics.add.group({
        key: 'ball',
        frameQuantity: 2,
        bounceX: 1,
        scale: 9,
        bounceY: 1,
        collideWorldBounds: true,
        velocityX: 180,
        velocityY: 120,
    });

    Phaser.Actions.RandomRectangle(group.getChildren(), this.cameras.main);

    Phaser.Actions.Call(group.getChildren(), function (ball) {
        ball.body.onWorldBounds = true;
        ball.body.onCollide = true;
    });

    this.physics.world.on('worldbounds', () => console.log('worldbounds event'));
    this.physics.world.on('collide', () => console.log('collide event'));
}


feat: add group 3 code

Add group 3 code from @wontheone1
(sorry, I had to move some things around but I copied your changes into this branch 😃)

Closes #7

Thanks so much for adding this @wontheone1

Thank you for hosting!


[bikeshedding] adjusted status page layout

We chatted about this a little bit in the comms SIG, where it was pondered if it was better to have language SDK stuff first. So I did that! And did some color and words changing stuff too. It's a bikeshed that I'm painting.
Preview: https://deploy-preview-1655--opentelemetry.netlify.app/status/

lgtm :)


add link to legacy site in the sidebar

@jenreiher-bcgov
classic.developer.gov.bc.ca is officially up so we can add the link. Here's what it looks like:

awesome! that's exciting :) I'm having 2nd thoughts about the icon... what do you think?! does it make sense or should we take a second look

I think cloud off is good. It's very recognizable and gets the idea out there that "classic" devhub content is winding down.
It might dissuade people from clicking it, since, I think, it has a somewhat negative connotation.
I tried out some potential alternatives.
Archive:

Launch:

Share:

AccountTree:

Layers:

I think Launch is good, albeit quite vanilla. I like Layers as well. Plus, it's similar to the icon they use for "Topics" on the homepage.

I think cloud off is good. It's very recognizable and gets the idea out there that "classic" devhub content is winding down. It might dissuade people from clicking it, since, I think, it has a somewhat negative connotation.
I tried out some potential alternatives.
Archive:  Launch:  Share:  AccountTree:  Layers:
I think Launch is good, albeit quite vanilla. I like Layers as well. Plus, it's similar to the icon they use for "Topics" on the homepage.

let's go with Launch - I think that's a safer choice... thanks for providing options!


404 - Page not found

I'm working on the router and despite lot's of troubleshooting efforts I can't get the Dispatcher to find the route.
If I do a var_dump on $dispatcher I get the following which I think is ok:
object(FastRoute\Dispatcher\GroupCountBased)#12 (2) { ["staticRouteMap":protected]=> array(1) { ["GET"]=> array(1) { ["/"]=> array(2) { [0]=> string(32) "NOFRAMEWORK\Controllers\Homepage" [1]=> string(4) "show" } } } ["variableRouteData":protected]=> array(0) { } } array(1) { [0]=> int(0) }
I believe it has to do with this line, I'm not sure it's being passed what it's expecting.
$routeInfo = $dispatcher->dispatch($request->getMethod(), $request->getPath());
$request->getMethod() returns GET
$request->getPath() returns /public/
Do those values seem correct?
I am obviously learning here, and appreciate any help.
Thank You

I just figured it out. The /public/ path was incorrect.
I changed this line as follows and it works:
 $routeInfo = $dispatcher->dispatch("$request->getMethod()", $request->getPath()); $routeInfo = $dispatcher->dispatch("GET", "/");
Just have to figure out why $request->getPath() is returning /public/ now.

Good to hear you resolved this issue. How is the build going now?
On Mon, Apr 16, 2018, 10:40 PM Jim Marquardt<EMAIL_ADDRESS>wrote:

I just figured it out. The /public/ path was incorrect.
I changed this line as follows and it works:
$routeInfo = $dispatcher->dispatch("$request->getMethod()",
$request->getPath()); $routeInfo = $dispatcher->dispatch("GET", "/");
Just have to figure out why $request->getPath() is returning /public/ now.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/PatrickLouys/no-framework-tutorial/issues/65#issuecomment-381826681,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AWHlv8cdxFC8XOBFkjyHt-UN1Xv13kOnks5tpWQsgaJpZM4TXkiu
.

I was having the same issue, you shouldn't change anything in the code. Instead, you should run php -S localhost:8000 in the public directory (I was running it in the root directory).
I hope this help someone else.


[ru] Updated kubernetes-api.md. Fixed a typo

Fixed a typo

/remove-lifecycle stale

Thanks for your contribution! Looks like it have been fixed by another PR.

#31143

/close


Mounting local files and directories onto the dlstreamer_test container

Hello,
I am trying to mount a directory present on my machine into the docker container: dlstreamer_test, on Windows 10 OS. I referred the tutorial available at: https://www.youtube.com/watch?v=ht4gqt4zSyw to achieve this.
I used the following command:
docker cp C:/Users/ShraddhaM/OneDrive/Desktop/streamlit-docker-master dlstreamer_test:/opt/intel/openvino_2020.3.194/streamlit-docker-master
I also tried this command:
docker cp C:/Users/ShraddhaM/OneDrive/Desktop/streamlit-docker-master dlstreamer_test:/openvino/ubuntu18_data_dev/streamlit-docker-master
I getting the following errors respectively,  for both commands:
Error: No such container:path: dlstreamer_test:\opt\intel\openvino_2020.3.194
Error: No such container:path: dlstreamer_test:\openvino\ubuntu18_data_dev
@nnshah1 @brmarkus Can you please guide me to resolve this?

Sorry, I don't use Docker under MS-Win (yet), only under Linux environments.
Under Linux I use command lines like this:
docker run -it -v /outside/folder1/:/inside/folder1/ -v /outside/writable/:/inside/writable/:rw mycontainer:1.2.3 /bin/bash
=> "mapping" two volumes, the host folder /outside/folder1/ will be available inside the container as /inside/folder1/, and another one where I specify that I want to write/change/add something from within the container.

@brmarkus  Thank you for the solution.


Cannot read properties of undefined (reading 'parserServices')

Issue workflow progress

Progress of the issue based on the
Contributor Workflow

[ ] 1. The issue provides a reproduction available on GitHub, Stackblitz or CodeSandbox

For example, you can start off by editng the
'basic' example on Stackblitz.

Please make sure the graphql-eslint version under package.json matches yours.

[ ] 2. A failing test has been provided

[ ] 3. A local solution has been provided

[ ] 4. A pull request is pending review

Describe the bug

We upgraded to "@graphql-eslint/eslint-plugin": "4.0.0-alpha.0", recently and this error started coming out.
We have the following setup in the eslintrc.js file
{
      files: '*.graphql',
      parser: "@graphql-eslint/eslint-plugin",
      parserOptions: {
        filePath: './graphql.config.js',
      },
    }

Based on the example, parserOptions seems unnecessary here and we do have a graphql.config.js file that colocates to the eslintrc file with the following content:
module.exports = {
  schema: ['./schema.graphql'],
  documents: ['./src/**/*.{ts,tsx}'],
};

Any ideas please?
To Reproduce Steps to reproduce the behavior:

Expected behavior

Environment:

OS: MacOS 14.1
@graphql-eslint/eslint-plugin:
Node.js: v18.14.2

Additional context

where did you find that you need to specify parserOptions.filePath for your graphql-config?


add more arm architectures

Ninja build for arm32 arch. fails.
See here: https://github.com/PhilipMay/mlflow-image/runs/7696392754?check_suite_focus=true#step:7:2223
Try again later...