[FEATURE] please send intiative requests to players when asked for intiative

Is your feature request related to a problem? Please describe.
when i go for intiative its asking the gm to roll for the players.
Describe the solution you'd like
i would like only npcs and monsters to ask for initative when prompting and for players to receive their requests rather than the gm receiving all the requests to roll.
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.

so it will ask the player to set their initiative if they are connected to the game, otherwise if the player is not connected it will prompt the GM

so it will ask the player to set their initiative if they are connected to the game, otherwise if the player is not connected it will prompt the GM

yeh that worked intodays session but it had this weird interaction where it wouldnt ask me as the gm what i wanted to roll as a prompt before i pressed begin combat. even tho i rolled intiative it asked me for the prompt after i clicked begin intiative. it also didnt give me the music menus. and played other music when i paused the music i manually set.

looking back at your comment, what I think your issue and it has to do with how I got the mod to work. So when a token is added to the combat tracker (NPC and PC) it will ask for what type of initiative roll you want to use BEFORE combat has even started. This may or may not then roll for initiative (something ill have to test out) but depending on if you added the tokens manually (using the combat icon on the token) or by using the select all and hit the hot key method.

ok, that should help me at least figure out whats going on

the way the group NPC rolling option works is that I have to pop up that window when combat starts, not when adding NPCs to the combat tracker. This was to cut down on the amount of popups for the GM (if there are a lot of NPCs in the combat tracker)
Having said that I can do something similar to how the PCs work, where whenever you add a NPC to the combat tracker a window will pop up asking for initiative type, then roll it.
I did notice that if you add a NPC to the combat tacker, roll the initiative manually then click start combat it will ask you again, that should be fixed in the next update

the way the group NPC rolling option works is that I have to pop up that window when combat starts, not when adding NPCs to the combat tracker. This was to cut down on the amount of popups for the GM (if there are a lot of NPCs in the combat tracker)
Having said that I can do something similar to how the PCs work, where whenever you add a NPC to the combat tracker a window will pop up asking for initiative type, then roll it.
I did notice that if you add a NPC to the combat tacker, roll the initiative manually then click start combat it will ask you again, that should be fixed in the next update

im still having issue with the audio selection popping up for combat and it tries to do something funky to music if i put my own on and tell it to stop it tries to play another play list listed in the settings of the mod. then i have to stop that and then continue something manually.

ok, so I tweeked how initiative is being prompted and it now will ask the player when their token is added to the combat tracker either from the right click menu or the hot key menu. This way their initiative should be set before combat is started regardless of the method


rclone mount crypt on acd cp error

Hello,
When I try to use cp against a Crypt -> ACD mount the system hangs most the time. I have this in the system logs:
Jan  9 13:58:16 localhost kernel: INFO: task cp:27494 blocked for more than 120 seconds.
Jan  9 13:58:16 localhost kernel:      Tainted: G        W    3.14.47 #1
Jan  9 13:58:16 localhost kernel: "echo 0 > /proc/sys/kernel/hung_task_timeout_secs" disables this message.
Jan  9 13:58:16 localhost kernel: cp              D ffff88087fc73240     0 27494   7760 0x00000084
Jan  9 13:58:16 localhost kernel: ffff8801045e3c28<PHONE_NUMBER>000082 ffff880823c243d0<PHONE_NUMBER>013240
Jan  9 13:58:16 localhost kernel: ffff8801045e3fd8<PHONE_NUMBER>013240 ffff880823c243d0 ffff880104d137e8
Jan  9 13:58:16 localhost kernel: ffff8808516fb000 ffff8801045e3c58 ffff880104d138c8 ffff880104d137e8
Jan  9 13:58:16 localhost kernel: Call Trace:
Jan  9 13:58:16 localhost kernel: [] schedule+0x29/0x70
Jan  9 13:58:16 localhost kernel: [] __fuse_request_send+0x125/0x290 [fuse]
Jan  9 13:58:16 localhost kernel: [] ? abort_exclusive_wait+0xb0/0xb0
Jan  9 13:58:16 localhost kernel: [] fuse_request_send+0x12/0x20 [fuse]
Jan  9 13:58:16 localhost kernel: [] fuse_send_write+0xd6/0x110 [fuse]
Jan  9 13:58:16 localhost kernel: [] fuse_perform_write+0x28d/0x520 [fuse]
Jan  9 13:58:16 localhost kernel: [] fuse_file_aio_write+0x2a1/0x340 [fuse]
Jan  9 13:58:16 localhost kernel: [] do_sync_write+0x67/0xa0
Jan  9 13:58:16 localhost kernel: [] vfs_write+0xba/0x1e0
Jan  9 13:58:16 localhost kernel: [] ? vfs_read+0xf4/0x160
Jan  9 13:58:16 localhost kernel: [] SyS_write+0x55/0xd0
Jan  9 13:58:16 localhost kernel: [] system_call_fastpath+0x16/0x1b
And the rclone log shows a 429 error (no retries) and passes that back to the stack.
I know writes on mounts are fairly new for ACD. Is writing to a crypt volume that is using an ACD volume supported?
rclone mount --max-read-ahead 200M --transfers 20 --checkers 20 --log-file /root/ACD.log -v ACD_CRYPT: ACD_CRYPT
OS: Linux
Version: rclone v1.35-DEV
Command: cp file.bin

I haven't been able to reproduce this.
  How often does the cp go wrong?
Can you share the rclone log (redact it if necessary) showing the 429 error and what happened before and after?
What should have happened is that rclone should have returned an error on the 429 error and cp should have failed.

I'll work on reproducing. It was an immediate response (didn't ever start copying files as far as I could see).


31 instead of 32  days in Jestha 2081

@TamuYuv please use the latest version of this package pip install --upgrade nepali-datetime.


change an OID value

I'm using this example for the GET command:
I receive a notification for sysObjectID and it seems that my agent returns <IP_ADDRESS>.4.1.20408:
Execution point: rfc3412.returnResponsePdu
* transportDomain: <IP_ADDRESS>.6.1.1
* transportAddress: <ip>
* securityModel: 3
* securityName: usr-md5-des
* securityLevel: 3
* contextEngineId:
* contextName:
* PDU: ResponsePDU:
 request-id=1889684380
 error-status=noError
 error-index=0
 variable-bindings=VarBindList:
  VarBind:
   name=<IP_ADDRESS>.<IP_ADDRESS>.0
   =_BindValue:
    value=ObjectSyntax:
     simple=SimpleSyntax:
      objectID-value=<IP_ADDRESS>.4.1.20408

My question, how can I change the value for sysObjectID ?

I found another example but it seems is not complete:
http://snmplabs.com/pysnmp/faq/how-to-implement-agent-mib.html

It seems that you use the hooks tapping on SNMP engine's internal operations. Could you please explain what is your ultimate goal?
The OID being returned is taken from the MIB which is maintained by the SNMP engine. If your goal is to build SNMP agent serving certain OIDs, please check out this or other examples.

My ultimate goal is to have some custom implementation on generic OIDs and also support some custom OIDs
it's much better what you suggested, Initially I just hacked __SNMP-MIB but after, I created my own :)


Add version: SKDataAS.ORMCore version 202309211

[x] Have you signed the Contributor License Agreement?
[x] Have you checked that there aren't other open pull requests for the same manifest update/change?
[x] This PR only modifies one (1) manifest
[x] Have you validated your manifest locally with winget validate --manifest <path>?

[x] Does your manifest conform to the 1.5 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.

Microsoft Reviewers: Open in CodeFlow

Hey, @stephengillie  I don't know if I can put the question here but, Winget only shows the older corrupt version. It should be the latest one I uploaded. How do I change this?

Hey, @stephengillie I don't know if I can put the question here but, Winget only shows the older corrupt version. It should be the latest one I uploaded. How do I change this?

Hi @skdataas,
Has this updated? We publish the manifests every 3-4 PR approvals, so after a PR is approved, it might take 15 minutes or more to become installable through WinGet.

Hi Stephen,
No it still shows a version that is months old, even though the GITHUB
shows all versions since then being present and earlier versions too.
Here is what it shows in winget:
And these are the versions in the winget microsoft github:
Our version number starts with the year, month, day and then an added
number for the daily releases. 5 days ago we added this version:
202309211. Yet it only shows version 202330051.I made a typo in the
version number there, due to American date order (month before date). So
while the number might be bigger, the update was months earlier in
timestamp.
It seems like WINGET looks to the version number and not the timestamp?
Best regards,
Dennis Kanon
On 2023-09-22 19:02, Stephen Gillie wrote:

Hey, @stephengillie [1 [1]] I don't know if I can put the question
here
but, Winget only shows the older corrupt version. It should be the
latest one I uploaded. How do I change this?

Hi @skdataas [2 [2]],
Has this updated? We publish the manifests every 3-4 PR approvals, so
after a PR is approved, it might take 15 minutes or more to become
installable through WinGet.
--
Reply to this email directly, view it on GitHub [3 [3]], or unsubscribe
[4 [4]].
You are receiving this because you were mentioned.Message ID:
@.***>
Links:
[1] https://github.com/stephengillie
[2] https://github.com/skdataas
[3]
https://github.com/microsoft/winget-pkgs/pull/120384#issuecomment-1731751055
[4]
https://github.com/notifications/unsubscribe-auth/A2UR3ALEONWRPOPPQDJPCFDX3XACZANCNFSM6AAAAAA5BOWT7Q

Links:
[1] https://github.com/stephengillie
[2] https://github.com/skdataas
[3]
https://github.com/microsoft/winget-pkgs/pull/120384#issuecomment-1731751055
[4]
https://github.com/notifications/unsubscribe-auth/A2UR3ALEONWRPOPPQDJPCFDX3XACZANCNFSM6AAAAAA5BOWT7Q


glusterfs

https://www.digitalocean.com/community/tutorials/how-to-create-a-redundant-storage-pool-using-glusterfs-on-ubuntu-18-04

https://medium.com/running-a-software-factory/setup-3-node-high-availability-cluster-with-glusterfs-and-docker-swarm-b4ff80c6b5c3

https://docs.gluster.org/en/latest/Quick-Start-Guide/Quickstart/

https://github.com/gluster/gluster-ansible


Flutter driver fails on dart:ui (even if no ui components are imported)

When trying to run the flutter driver, it fails because of dart:ui, but in none of my tests I am importing any widgets. As you can see it is failing on the material package, which is used to run the app in the first place (or run flutter driver)
Logs
file:///Users/sam/Library/Developer/Flutter/flutter/packages/flutter/lib/src/material/animated_icons.dart:9:8: Error: Not found: 'dart:ui'
import 'dart:ui' as ui show Paint, Path, Canvas;
       ^
file:///Users/sam/Library/Developer/Flutter/flutter/packages/flutter/lib/src/material/animated_icons.dart:10:8: Error: Not found: 'dart:ui'
import 'dart:ui' show lerpDouble;
       ^
file:///Users/sam/Library/Developer/Flutter/flutter/packages/flutter/lib/src/material/arc.dart:6:8: Error: Not found: 'dart:ui'
import 'dart:ui' show lerpDouble;
       ^
file:///Users/sam/Library/Developer/Flutter/flutter/packages/flutter/lib/src/material/colors.dart:5:8: Error: Not found: 'dart:ui'
import 'dart:ui' show Color;
       ^
file:///Users/sam/Library/Developer/Flutter/flutter/packages/flutter/lib/src/material/dialog_theme.dart:5:8: Error: Not found: 'dart:ui'
import 'dart:ui' show lerpDouble;
       ^
file:///Users/sam/Library/Developer/Flutter/flutter/packages/flutter/lib/src/material/input_border.dart:6:8: Error: Not found: 'dart:ui'
import 'dart:ui' show lerpDouble;
       ^
file:///Users/sam/Library/Developer/Flutter/flutter/packages/flutter/lib/src/material/input_decorator.dart:6:8: Error: Not found: 'dart:ui'
import 'dart:ui' show lerpDouble;
       ^
file:///Users/sam/Library/Developer/Flutter/flutter/packages/flutter/lib/src/material/mergeable_material.dart:5:8: Error: Not found: 'dart:ui'

Flutter doctor
[✓] Flutter (Channel beta, v1.1.8, on Mac OS X 10.14 18A391, locale en-PH)
    • Flutter version 1.1.8 at /Users/sam/Library/Developer/Flutter/flutter
    • Framework revision 985ccb6d14 (5 weeks ago), 2019-01-08 13:45:55 -0800
    • Engine revision 7112b72cc2
    • Dart version 2.1.1 (build 2.1.1-dev.0.1 ec86471ccc)

[✓] Android toolchain - develop for Android devices (Android SDK version 28.0.3)
    • Android SDK at /Users/sam/Library/Developer/Xamarin/android-sdk-macosx
    • Android NDK location not configured (optional; useful for native profiling support)
    • Platform android-28, build-tools 28.0.3
    • ANDROID_HOME = /Users/sam/Library/Developer/Xamarin/android-sdk-macosx
    • Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_152-release-1136-b06)
    • All Android licenses accepted.

[✓] iOS toolchain - develop for iOS devices (Xcode 10.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 10.1, Build version 10B61
    • ios-deploy 1.9.4
    • CocoaPods version 1.5.3

[!] Android Studio (version 3.2)
    • Android Studio at /Applications/Android Studio.app/Contents
    ✗ Flutter plugin not installed; this adds Flutter specific functionality.
    ✗ Dart plugin not installed; this adds Dart specific functionality.
    • Java version OpenJDK Runtime Environment (build 1.8.0_152-release-1136-b06)

[✓] IntelliJ IDEA Community Edition (version 2018.1.6)
    • IntelliJ at /Applications/IntelliJ IDEA CE.app
    • Flutter plugin version 26.0.2
    • Dart plugin version 181.4892.1

[✓] VS Code (version 1.30.2)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 2.22.3

[✓] Connected device (1 available)
    • iPhone XR • 7E54F1F3-2AA7-4C64-9B37-19051D3924B4 • ios • iOS 12.1 (simulator)

Seems you are indirectly importing it by importing animated_icons.dart directly or indirectly.
The test file can not contain anything Flutter specific because it is not run on a device/emulator, only the driven app can import such libraries.

So them I am not able to import the material library? Since that one is used for the runApp function in the integration tests

It's not clear to me what you try to accomplish. There is no point in importing any such stuff in the driver code, only in the app code.

I am trying to test the app screen by screen, by running it on an emulator with flutter driver and with flutter driver I can test the app itself right? I need to run the app to be able to test it like shown in the documentation here -> https://flutter.io/docs/cookbook/testing/integration/introduction. It still imports the main.dart file (which has the material.dart). So that is the exact thing that I am doing but still it fails with the same error

You can't import the main.dart file in the test file if it imports dart:ui directly or indirectly.
Why do you want to do that?

How will I test the app with integration tests then? Even in the documentation of Flutter it gives me an example that this is possible and how it is done?

Somehow you seem to mix up driver test and app. This is only an alternative main.dart file for the app to have flutterDriverExtension enabled. This is not the driver test file.
To investigate we would need a minimal reproduction project and the exact command you use to run,
but actually I think this is a support case that should be asked
in one of the other channels listed at http://flutter.io/support .

Hi !
(Please let me know If I should open a new issue for this, as this has been closed [without any solution ?])
I am facing the same issue when trying to do integration-testing, that is, the error is :

> flutter driver --target=test_driver/app.dart
Using device Android SDK built for x86.
Starting application: test_driver/app.dart
Initializing gradle...                                                  9.9s
Resolving dependencies...                                               7.0s
Installing build/app/outputs/apk/app.apk...                            19.6s
Running Gradle task 'assembleDebug'...
Running Gradle task 'assembleDebug'... Done                        18.1s
Built build/app/outputs/apk/debug/app-debug.apk.

Driver tests failed: 254

Note the command I am using to run the tests is  : flutter driver --target=test_driver/app.dart
The source code is here, the actual test file being test_driver/home_page.dart
Now, By little playing-around, it can be found that this exception is being caused dues the flutter/material.dart import, but for my use-case that will be required, to be able to use methods like find.byIcon() etc. Also, since these tests should be running on the actual device, and are Integration tests, I believe "everything" should be available to the test runtime and that "everything" should get testing like a real device.
So, how should I go about solving this exception ? Would also be happy to submit a PR with some guidance from you guys.

The solution was indeed that there is no dart:ui imports allowed. I was in some file still referencing the material library after a long search through my files and after removing it, it worked perfectly fine again. So if you want to use the find.ByIcon , that will not work in integration tests, what will work tho is byType or byKey and giving a specific key to that icon that you want to use in the test and works fine as well

@Sadoge : Okay. So that will add an overhead of using indirect methods (keys etc), over more direct methods (Icons etc). And I think I can live with that, but conceptually this does not sound right. These integration tests are meant to be tests on a full-fledged application. And, the application does use the material library, so, I would expect the integration tests to work fine with the library.

I fully agree on that, since these testing methods are available on the widget tests, only thing is that I do not know if this is possible, since I do not know the ins and outs of the code.

Okay, I think I get it now. While in the integration tests, Flutter does not really start the actual app, but the --target app, which in turn starts the actual "app" from inside it. This target app then executes commands and actions over the actual app's UI. So the actual run-time is not the app, but the target app, which is termed as "Driver" app. And it's this driver run-time, which lacks all these flutter libraries.
Its unlike espresso, because (not sure if this is correct) espresso had access to the core system APIs since they were present on the Android OS itself, which, in case of flutter, the Android system does not have.
So, I would think that there should probably be more FlutterDriver#*() APIs to make testing a little more smooth. For example, I cannot use expect(someSerializableFinder, findsOneWidget);, because it will require me to import flutter_test.dart which will again produce the same exception. I will instead have to use driver.waitFor(someSerializableFinder, timeout: Duration(microseconds:1), which, to be honest, I am not sure if is the correct way to assert existence of a widget (especially that microseconds:1 part ?).
Moreover, I think there should be something in the documentation to make a clear distinction between the "Driver" app and the "Actual" app.

@ZeekHuge your repo saved me from pulling my hair out!!
I've been going through the integration test tutorials on the flutter site and was hitting this dart.ui problem on them, as well. For anyone else still having trouble, this is what sent me off the path:
At some point, it appears flutter went from using
import 'package:test/test.dart';
to using
import 'package:flutter_test/flutter_test.dart';
for doing non-integration unit tests etc. It appeared to me that test/test.dart had just been renamed and the convention changed to use the name flutter_test. As most of the tutorials don't show all the pubspec info, it was difficult to tell (being new to the platform) what was going on.
This led me to believe that test/test.dart was deprecated and some tutorials were just out of date.
So, for doing unit tests/widget tests etc you can put in your pubspec
dev_dependencies:   flutter_test:     sdk: flutter
and use
import 'package:flutter_test/flutter_test.dart';
in your regular testing directory
If you are doing integration tests and using Flutter Driver (and are creating the test_driver directory) to test app elements while running it on a real device or emulator, then in your pubspec put
dev_dependencies:   flutter_driver:     sdk: flutter   test: any
and in your app_test.dart, import
import 'package:flutter_driver/flutter_driver.dart' ; import 'package:test/test.dart';
I saw so many posts saying that the Driver test file can't use flutter elements but wasn't quite sure what that meant in this case. Evidently, the flutter_test.dart import being used in the app_test.dart file is what's trying to find some UI dependencies and using test/test.dart instead overcomes that.
You will also find that if you try to use flutter_driver and flutter_test in the same test file, you will get conflicts trying to use the find function.

Same problem here

When running from terminal it seems to work for my case: 'flutter run'

Based on @MDuRieu's last comment, I believe there is an opportunity here to update the documentation as I ran into this same issue as well following the documentation as-is.

For me helped deleting and importing 'package:flutter_test/flutter_test.dart' import again

After alot of trial and error I found that importing anything from flutter package (package:flutter/material.dart or package:flutter/foundation.dart or package:flutter/widgets.dart) in the driver file (test_driver/*_test.dart) causes this issue.

After alot of trial and error I found that importing anything from flutter package (package:flutter/material.dart or package:flutter/foundation.dart or package:flutter/widgets.dart) in the test file (test_driver/*_test.dart) causes this issue.
Also to resolve this I used package:test/test.dart and not package:flutter_test/flutter_test.dart in the test file.

After alot of trial and error I found that importing anything from flutter package (package:flutter/material.dart or package:flutter/foundation.dart or package:flutter/widgets.dart) in the test file (test_driver/*_test.dart) causes this issue.
And as @MDuRieu suggested I used package:test/test.dart and not package:flutter_test/flutter_test.dart in the test file.

After alot of trial and error I found that importing anything from flutter package (package:flutter/material.dart or package:flutter/foundation.dart or package:flutter/widgets.dart) in the test file (test_driver/*_test.dart) causes this issue.
And as @MDuRieu suggested I used package:test/test.dart and not package:flutter_test/flutter_test.dart in the test file.

Same solution works for me

Hi @MDuRieu
I already comparing your solution with my code, it's all the same but I still cause the same error.
My pubspec.yaml
name: moviecatalogue
description: A new Flutter application.
version: 1.0.0+1

environment:
  sdk: ">=2.1.0 <3.0.0"

dependencies:
  flutter:
    sdk: flutter

  # This is our modular
  core:
    path: core
  shared:
    path: shared

dev_dependencies:
  flutter_test:
    sdk: flutter
  flutter_driver:
    sdk: flutter
  test: any
  json_serializable: any
  shimmer: ^1.1.1
  cached_network_image: ^2.2.0
  flutter_launcher_icons: ^0.7.5

flutter_icons:
  android: true
  ios: true
  image_path: "assets/images/movie_icon.png"

flutter:
  uses-material-design: true
  assets:
    - assets/images/

  fonts:
    - family: IBMPlexSans
      fonts:
        - asset: assets/fonts/IBMPlexSans-Regular.ttf
        - asset: assets/fonts/IBMPlexSans-Bold.ttf
          weight: 700
        - asset: assets/fonts/IBMPlexSans-Italic.ttf
          style: italic
        - asset: assets/fonts/IBMPlexSans-Light.ttf
          weight: 300
        - asset: assets/fonts/IBMPlexSans-SemiBold.ttf
          weight: 600

My app_test.dart
import 'package:flutter_driver/flutter_driver.dart';
import 'package:test/test.dart';

import 'app_test_key.dart';

void main() {
  group("Movies Development Test", (){

    FlutterDriver driver;

    setUpAll(() async {
      driver = await FlutterDriver.connect();
    });

    tearDownAll(() async {
      if (driver != null) {
        driver.close();
      }
    });

    test("show list now plauing", () async {
      await driver.waitFor(homeKey);
      await driver.waitFor(tapBottomNowPlayingKey);
      await Future.delayed(Duration(seconds: 3));
      await driver.waitFor(tapListViewNowPlayingKey);
      await Future.delayed(Duration(seconds: 1));
      await driver.scroll(tapListViewNowPlayingKey, 0, 200, Duration(milliseconds: 500));
      await driver.scroll(tapListViewNowPlayingKey, 0, -600, Duration(milliseconds: 500));
      await driver.scroll(tapListViewNowPlayingKey, 0, 800, Duration(milliseconds: 500));
      await Future.delayed(Duration(seconds: 1));
      await driver.tap(tapItemNowPlayingKey);
      await Future.delayed(Duration(seconds: 3));
      await driver.tap(tapItemFavoriteKey);
      await Future.delayed(Duration(seconds: 1));
      await driver.tap(tapBackButtonKey);
      await Future.delayed(Duration(seconds: 1));
    });

    test("show list up comming", () async {
      await driver.waitFor(tapBottomUpComingKey);
      await Future.delayed(Duration(seconds: 3));
      await driver.waitFor(tapListViewUpComingKey);
      await Future.delayed(Duration(seconds: 1));
      await driver.scroll(tapListViewUpComingKey, 0, 200, Duration(milliseconds: 500));
      await driver.scroll(tapListViewUpComingKey, 0, -600, Duration(milliseconds: 500));
      await driver.scroll(tapListViewUpComingKey, 0, 800, Duration(milliseconds: 500));
      await Future.delayed(Duration(seconds: 1));
      await driver.tap(tapItemUpComingKey);
      await Future.delayed(Duration(seconds: 3));
      await driver.tap(tapItemFavoriteKey);
      await Future.delayed(Duration(seconds: 1));
      await driver.tap(tapBackButtonKey);
      await Future.delayed(Duration(seconds: 1));
    });

    test("show list popular", () async {
      await driver.waitFor(tapBottomPopularKey);
      await Future.delayed(Duration(seconds: 3));
      await driver.waitFor(tapListViewPopularKey);
      await Future.delayed(Duration(seconds: 1));
      await driver.scroll(tapListViewPopularKey, 0, 200, Duration(milliseconds: 500));
      await driver.scroll(tapListViewPopularKey, 0, -600, Duration(milliseconds: 500));
      await driver.scroll(tapListViewPopularKey, 0, 800, Duration(milliseconds: 500));
      await Future.delayed(Duration(seconds: 1));
      await driver.tap(tapItemPopularKey);
      await Future.delayed(Duration(seconds: 3));
      await driver.tap(tapItemFavoriteKey);
      await Future.delayed(Duration(seconds: 1));
      await driver.tap(tapBackButtonKey);
      await Future.delayed(Duration(seconds: 1));
    });

    test("show list top rated", () async {
      await driver.waitFor(tapBottomTopKey);
      await Future.delayed(Duration(seconds: 3));
      await driver.waitFor(tapListViewTopRatedKey);
      await Future.delayed(Duration(seconds: 1));
      await driver.scroll(tapListViewTopRatedKey, 0, 200, Duration(milliseconds: 500));
      await driver.scroll(tapListViewTopRatedKey, 0, -600, Duration(milliseconds: 500));
      await driver.scroll(tapListViewTopRatedKey, 0, 800, Duration(milliseconds: 500));
      await Future.delayed(Duration(seconds: 1));
      await driver.tap(tapItemTopRatedKey);
      await Future.delayed(Duration(seconds: 3));
      await driver.tap(tapItemFavoriteKey);
      await Future.delayed(Duration(seconds: 1));
      await driver.tap(tapBackButtonKey);
      await Future.delayed(Duration(seconds: 1));
    });

    test("show about", () async {
      await driver.waitFor(tapBottomAboutKey);
    });

  });
}

I resolved this issue by remove the line in app_test.dart
import 'package:flutter/material.dart'

I want to use bufferMatchesGoldenFile() from the flutter_test package, so I can perform golden tests along with my integration tests. But as flutter_test depends on dart:ui, I can't use it in my integration test. But they seem to do exactly this here.
Does anyone know, how to make this work?

Hi everyone, I had the same problem during a collaboration using Git. At the end, the problem was a mismatch in flutter vesion. So, I ran flutter upgrade, and everything started to work.

To resolve the issue  follow the following two steps:

verify your app.dart file has no import pakages  apart from
import 'package:flutter_driver/driver_extension.dart';
import 'package: "Your flutter package name "/main.dart' as app;
2.verify your app_test.dart file has no imports  than
import 'package:flutter_driver/flutter_driver.dart';
import 'package:test/test.dart';

In general, senese there must no  exist flutter pakages like  import "package: flutter/material.dart ...etc

To resolve the issue  follow the following two steps:

verify your app.dart file has no import pakages  apart from
import 'package:flutter_driver/driver_extension.dart';
import 'package: "Your flutter package name "/main.dart' as app;
2.verify your app_test.dart file has no imports  than
import 'package:flutter_driver/flutter_driver.dart';
import 'package:test/test.dart';

In general, senese there must no  exist flutter pakages like  import "package: flutter/material.dart ...etc

Still have this issue; seems none of the suggestions work here anymore. Just want to test some simple bloc and services. Anyone know if there's an alternative?


Automatic Setting generation updates

Add the option to separate the settings into different categories.
Add a hovertool which shows additional information about what this setting actually does.

Also make the settings dependent on the type: e.g. a boolean setting has a checkbox as view element.


Error with CLOCK_REALTIME

Trying to compile in linux 3.10.0-1160.el7.x86_64 with -std=gnu99.
But getting below error related to time.h
./src/postgres/include/portability/instr_time.h:118:2: warning: implicit declaration of function ‘clock_gettime’ [-Wimplicit-function-declaration]
clock_gettime(PG_INSTR_CLOCK, &tmp);
^
./src/postgres/include/portability/instr_time.h:108:24: error: ‘CLOCK_REALTIME’ undeclared (first use in this function)
#define PG_INSTR_CLOCK CLOCK_REALTIME
^
./src/postgres/include/portability/instr_time.h:118:16: note: in expansion of macro ‘PG_INSTR_CLOCK’
clock_gettime(PG_INSTR_CLOCK, &tmp);
^
./src/postgres/include/portability/instr_time.h:108:24: note: each undeclared identifier is reported only once for each function it appears in
#define PG_INSTR_CLOCK CLOCK_REALTIME
^
./src/postgres/include/portability/instr_time.h:118:16: note: in expansion of macro ‘PG_INSTR_CLOCK’
clock_gettime(PG_INSTR_CLOCK, &tmp);
Tried all possible solutions mentioned online like:
adding
#define _GNU_SOURCE
#define _POSIX_C_SOURCE = 199309L / #define _POSIX_C_SOURCE >= 199309L
Also tried adding <unistd.h> before time.h
But nothing worked.
Any help would be appreciated.

Thanks for the report!
Could you confirm which commands you're running exactly? (make in the project root?)
Additionally, which distribution are you using? (looks like RHEL7 or CentOS7?)

Thanks for the report!
Could you confirm which commands you're running exactly? (make in the project root?)
Additionally, which distribution are you using? (looks like RHEL7 or CentOS7?)

Hi,
Yes distribution is CentOS version 7 ,
and the only change I have made before running make in project root is adding -std=gnu99 because of some c99 for loop related error.


Upgrades pgx dependency to v3

Most changes are related to pgtype .
Fixes #18.

In the meantime I submitted a PR to pin dependencies to v2

@bgentry I have made the changes.

@aravindc26 I'm seeing three more minor changes that haven't yet been addressed. Sorry for the delay, I'm able to move fast on this this week.

@bgentry can you please point it out ? I believe I have resolved everything.

@aravindc26 I think GitHub's UI was playing tricks on me. Looks good now, thanks! released as v1.0.0


Styling Issues

FIREFOX

[ ] Styling of More info on Firefox eg St. Andrews.
[ ] No scroll on Nearest Toilets selection

IE11

@jermyk could you explain what you mean by:

Styling of More info on Firefox eg St. Andrews.

Looks like this got closed in the pull request, though it should stay open as the Firefox scrolling issue is still at large.
To reproduce: open the toilet map in Firefox and resize the window such that the sidebar content should get its own scrollbar. Instead of this happening, the whole page is extended. This is inconsistent with other browsers.


RNIapModule.buyItemByType got 8 arguments, expected 6 when trying to requestPurchase

Version of react-native-iap
3.4.12
Version of react-native
<IP_ADDRESS>
Platforms you faced the error (IOS or Android or both?)
android
Expected behavior
Actual behavior
Tested environment (Emulator? Real Device?)
Steps to reproduce the behavior
requestPurchase = async (sku) => {
await this.getAvailablePurchases();
var that = this;
try {
await RNIap.requestPurchase(sku, false)
} catch (err) {
console.warn(err.code, err.message);
}
};

I am facing the same issue on
React Native Environment Info:
System:
OS: macOS 10.15
CPU: (4) x64 Intel(R) Core(TM) i5-5250U CPU @ 1.60GHz
Memory: 150.48 MB / 8.00 GB
Shell: 5.7.1 - /bin/zsh
Binaries:
Node: 12.10.0 - /usr/local/bin/node
npm: 6.10.3 - /usr/local/bin/npm
SDKs:
iOS SDK:
Platforms: iOS 13.2, DriverKit 19.0, macOS 10.15, tvOS 13.2, watchOS 6.1
IDEs:
Xcode: 11.3.1/11C505 - /usr/bin/xcodebuild
npmPackages:
react: 16.8.3 => 16.8.3
react-native: 0.59.8 => 0.59.8
npmGlobalPackages:
react-native-cli: 2.0.1
"react-native-iap": "4.4.0",


clarify environment variable for vuln caching

docs in dep-scan say to use VULNDB_HOME environment variable to cache download.
But, the vdb library uses VDB_HOME https://github.com/AppThreat/vulnerability-db/blob/master/vdb/lib/config.py#L19

Hi @stevesea
Good find! Code is obviously correct. I had to rename things to satisfy a trademark infringement claim a while ago. Will update the docs. Btw, please feel free to check out the parent project called scan which include dep-scan with other static analysis tools https://slscan.io

VDB_HOME is the correct variable. Updated the readme.


in some case the %} will comment out some useful code behind it.

Hi Silas,
in some case the %} will comment out some useful code behind it.

use the jianpu file below will invoke the bug
3 - q0 q1 q2 q1
L: aa bb cc dd

Oh... that %} shouldn't be there at all.  It was added by mistake in v0.158 last May (commit d4bad824df54d36d618bd8e2b3b7972b0ae0e75b) and I'm not sure why it didn't hit my tests!  Fixed in version 3.2 https://github.com/ssb22/jianpu-ly/commit/bc82f55a3af1e7ac055f4772b2d9184882835998

Thanks a lot!


Add MACARONSWAP space

Hi! What is your PR about?

[x] Add images for your space
[x ] Add custom domain for your space
[ x] Add alias for migrate your space
[ x] Add or edit a skin
~Edit your space with GitHub?~ (deprecated) Please migrate your space to ENS https://docs.snapshot.page/spaces/migrate
~Create your space with GitHub~ (deprecated) Create your space with ENS instead https://docs.snapshot.page/spaces/create

Hi, It's BSC project, does it require to get ENS again?

I fixed all issues about PR, Please merge it thanks.

Changes commited. Thanks


Fixing #126, possibly breaking compatibility with Django<=1.7

It should be possible to implement compatibility but I'm not interested in this at all.

#126

@aclark4life seems we can't forget projects using django < 1.7 what do you think?

I would say we can drop 1.7 now, see: https://www.djangoproject.com/download/#supported-versions

Thanks


docs(): add common options to README

Just added some common options to the README for easier reference.

This would have been really helpful for me

LGTM


Some improvements for your script.

Thanks for your work, great script!
In case you are interested I added some functionality to your script, see:
https://github.com/walder/google-ads-youtube-channel-excluder
Mainly I added a check so music channels are excluded.
Also I believe your Regex exclusion in the Google Ads query does not work, I changed it to like %XXX%.
Channels explicitly set to be included in the Google Ads interface will now now longer be blacklisted they match exclusion criteria.

@walder Thank you very much for your feedback! Glad to see someone using my script and even improving it. That's really cool! We actually have a lack of video campaigns but I will definitely give it a try as soon as I have a new use case for it.


RemoteJid

I have reviewed go-whatsapp code,Sending text message need RemoteJid.How can I get this ID,is this a inner ID ?

The RemoteJid is the unique identifier for each conversation. It is described in the README of this repo: Chat identification / JID.


Added operating system concept book

What does this PR do?
Add resource(s) | Remove resource(s) | Add info | Improve repo
I added a book relating to the concepts about the operating system, and added it under the Operating systems index.
For resources
Why is this valuable (or not)?
This is valuable because concepts are very important to understand, and this book has very high reviews.
How do we know it's really free?
We know that this book is really free because it is online publicly and anybody can read it.
For book lists, is it a book? For course lists, is it a course? etc.
Yes it is a book.
Checklist:

[x] Read our contributing guidelines.
[x] Search for duplicates.
[x] Include author(s) and platform where appropriate.
[x] Put lists in alphabetical order, correct spacing.
[x] Add needed indications (PDF, access notes, under construction).
[x] Used an informative name for this pull request.

Follow-up

Check the status of GitHub Actions and resolve any reported warnings!

doesn't work for me either


⚠ Bofrost.be has degraded performance

In bdcaab1, Bofrost.be (https://www.bofrost.be) experienced degraded performance:

HTTP code: 200
Response time: 1695 ms

Resolved: Bofrost.be performance has improved in 5fcb7ec after 2 hours, 3 minutes.


Incorrect Characteristics being read ?

I have a Bluetooth module which is broadcasting a custom BLE service. I have been using the LightBlue iOS app to debug. This is showing the results I expect:

However, when using your plugin and then your demo app, I have found it is showing a different service on the exact same service, on the same device. Why is this?
See below:

Don't you see the correct properties when pressing the A000 service?

Yes, it's the A004 Vs. 180D service that seems to have been picked up incorrectly?

I mean: if you press the A000 service doesn't the screen slide to the next page where the characteristics are shown? Please attach a screenshot of that page as well.


fixed multirow sparse background case for KernelExplainer and added test

Thanks! LGTM, will wait for the tests to run though.


Added fallback for django 1.11

There is error when I tried to implement searchable select in django 1.11, I fixed it using the code in this pull request. Please review the code and merge it.

Coverage decreased (-3.0%) to 97.015% when pulling 84308dce765ea010f6c2eb54d38e3cdfb728378b on sheeshmohsin:master into cd00c5dcfd81866cd5061c9f1626c74d07d601d4 on and3rson:master.

Hi, I am not able to detect what's failed? and also I am new to coveralls, so not sure what is decreased coverage? Can you please point me to the error or possible bugs in my code so that i can fix?

@sheeshmohsin I will add info about testing coverage locally into readme in few minutes, stay tuned :)

Cool, Thanks

@shalakhin Please check out the updated readme, I've added info on how to run tests. Your branch should have 100% passing builds once you merge master in.

@sheeshmohsin any luck?

@and3rson I will do by tonight (IST)  after office. Thanks for the informations :)

I've merged it manually, waiting for the tests

Thanks for merging. Apologies for the delay from my side, was bit busy :)

Thanks, Apologies for the delay from my side, was bit busy


Reduce dom size

The HTML produced by npf-renderer contains a lot of useless classes and tags. For example the inline-formatted-content span that surrounds the entire contents of text blocks when something is inline formatted.
This should be fixed. The output of npf-renderer should be as small as possible

With #5 increasing the size of the HTML output even more, this needs to be higher priority


[Docs] Update TOC and list in PR test docs.

Just fixes to the TOC to reflect content

@swift-ci please smoke test and merge


Recipes: Add a Steps field

text field, look into a WYSIWYG editor to implement there?

Completed by adding the Details field


Support for exit animations on Dialogs, Menus,...

I've been using this component library for a couple of days now, LOVING IT!
The only part that's missing is the exit animations, especially for the dialogs and menu components. They animate-in nicely but they disappear instantly on unmount. I'm somewhat new to radixUI, but I read this from radix which basically uses the data-[state=open/close] attributes to animate the state transitions (and this is what accordions seem to use on this library with animations declared on tw config)
So, is not having exit animations on certain components an intentional design choice?

@sanvishal Some of the exit animations are intentionally not added.
Example: for alert dialog you want visual feedback (animation) when the dialog enters but you want it to "get it out of your way" when exit. (I tried adding exit animations and it felt weird/sluggish).
Some are probably oversight on my part. Can you let me know which components and I can fix?
Thank you.

thanks, but for now, I've only seen them missing on dialogs, dropdown menus, tooltips, and popovers. I think your justification makes sense to me in some cases.
I'll create a PR or a separate issue if I find any other components.

I was wondering this myself today. I was trying to modify the dialog to be a slide in nav from the left. I was able to get the enter slide in going but the exit I'm having trouble with.
I have tried force mount on the portal but I was getting sluggish animations

Hey @natac13, how are you doing the exit animation?

Hey @natac13, how are you doing the exit animation?

I followed something similar to this. However I was not very successful.
My idea was to remove the framer motion stuff from the example but leave the open prop. I then made a duplicate of the DialogContent component from this library and used the forceMount prop on the portal then tried to use the data-[state=closed] prefix to handle the exit animation but was getting bad results

With tailwind, just use data-* modifier: data-[state=open]:animate-show data-[state=closed]:animate-hide
https://codesandbox.io/p/sandbox/pedantic-aryabhata-1ykgmk?file=%2FApp.jsx

I tried to add an exit animation to the, but it just doesn't work for some reason. I added the dialog component in the next-template  imported from @/components/ui/dialog.
I added data-[state=closed]:animate-out data-[state=closed]:fade-out-10 data-[state=closed]:zoom-out-50 to the <DialogContent /> here
I've also added logs to the onAnimationStart/End callback, this is what I got after opening and closing the dialog 1 time
start anim: enter
end anim: enter

additionally, I should've also gotten the exit animation log too while closing the dialog, but it seems like radix did not suspend the "unmounting" till the animation finishes up. Is this a radix-specific problem or some other? because the codesandbox by @joaom00 seems to work just fine.

I tried to add an exit animation to the dialog component, but it just doesn't work for some reason. I added the dialog component in the next-template  imported from @/components/ui/dialog.
I added data-[state=closed]:animate-out data-[state=closed]:fade-out-10 data-[state=closed]:zoom-out-50 to the <DialogContent /> here
I've also added logs to the onAnimationStart/End callback, this is what I got after opening and closing the dialog 1 time
start anim: enter
end anim: enter

additionally, I should've also gotten the exit animation log too while closing the dialog, but it seems like radix did not suspend the "unmounting" till the animation finishes up. Is this a radix-specific problem or some other? because the codesandbox by @joaom00 seems to work just fine.

I have the same problem when I tried to add exit animations to Radix components using tailwind-animate plugin, however with self writing animations everything works fine

well, that's a minor inconvenience, TIL :)
thanks, I'll try with non-tailwindy animations!

@joaom00 Wow, it’s strange, but I really tried it now and it works, I don’t even know what happened then, maybe a bug or blunted somewhere. Thankee!

@joaom00 Is it possible to do something with the fact that because of '-translate-x-1/2 -translate-y-1/2' the animation starts from the corner?

@its-monotype Yes, I updated the example with tailwind-animate to match the one in tailwind.config

@joaom00 Is it possible to do something with the fact that because of '-translate-x-1/2 -translate-y-1/2' the animation starts from the corner?

yep, that seems to be the issue, thanks @joaom00

Integration with this makes sense? tailwind-radix

I played a little bit with the code of shadcn/ui's Dialog. The main problem seemed to be the <div> between DialogPrimitive.Portal and {children}:
const DialogPortal = ({
  className,
  children,
  ...props
}: DialogPrimitive.DialogPortalProps) => (
  <DialogPrimitive.Portal className={cn(className)} {...props}>
    <div className="fixed inset-0 z-50 flex items-end justify-center sm:items-center">
      {children}
    </div>
  </DialogPrimitive.Portal>
)
DialogPortal.displayName = DialogPrimitive.Portal.displayName

This causes Radix UI's Portal to ignore animations on Overlay and Content and thus removing the Portal's content immediately. Therefore none of the animation you might have added were visible because the elements weren't longer part of the DOM.
In shadcn/ui#127 I removed the <div>. Problem now is that the positioning of the Overlay and Content relied on the parent div which used CSS's flex. Now the components are directly in the DOM and we need to position them on their own with fixed. And because this positioning is a little bit more complex the animations needed to be as well.
The result should be visually the same with an additional exit animation.

Any updates on this issue 🤕?

@AlvaroAquijeDiaz  My PR hasn't been merged to the code base yet and meanwhile the upstream code has changed. If I find time in the next days I can adjust my PR for the current master. But if it it's urgent, the code changes in my PR/previous comment should still work if you change this in your code accordingly.

Based on the current main branch I re-did the exit animation for dialog and alert-dialog as well as some other components. If anyone needs it now, see the diff in my PR what to change.

This causes Radix UI's Portal to ignore animations on Overlay and Content and thus removing the Portal's content immediately. Therefore none of the animation you might have added were visible because the elements weren't longer part of the DOM.

@baumerdev I've ran into this issue before and had solved it by adding a "fake" animation to the div in question which doesn't do anything visually different:
fakeAnimation: {
  from: { opacity: '1' },
  to: { opacity: '1' },
},

That way Radix.Portal doesn't ignore the underlying Radix.Content animation.

This causes Radix UI's Portal to ignore animations on Overlay and Content and thus removing the Portal's content immediately. Therefore none of the animation you might have added were visible because the elements weren't longer part of the DOM.

@baumerdev I've ran into this issue before and had solved it by adding a "fake" animation to the div in question which doesn't do anything visually different:
fakeAnimation: {
  from: { opacity: '1' },
  to: { opacity: '1' },
},

That way Radix.Portal doesn't ignore the underlying Radix.Content animation.

Hey, can you provide full details on how you achieved this? Unsure if this snippet is for some animation library?

Hey, can you provide full details on how you achieved this? Unsure if this snippet is for some animation library?
This is a pure CSS animation, the library doesn't really matter (the above snippet was done with stitches, but can work with tailwind or any styling library of your choice).

done

Would love to get this working but can't seem to replicate the fix you descibe - any chance you could drop a sandbox?

Hey, can you provide full details on how you achieved this? Unsure if this snippet is for some animation library?

This is a pure CSS animation, the library doesn't really matter (the above snippet was done with stitches, but can work with tailwind or any styling library of your choice).

Would love to get this working but can't seem to replicate the fix you descibe - any chance you could drop a sandbox?

@eIIisd sure, here's a repo with the fix. One thing I forgot to mention is that the div in question has to he a Dialog.Overlay under the hood so that we can hook into the appropriate open/closed data attributes

We now have exit animations on all components.

After hours of trying to solve this and to searching a lot, I solve my problem. The post of @baumerdev helps me. I'll brief my learn:

To use data-state in tailwind do

data-[state=closed]:your-animation

Don't put a div between Portal and Overlay or Content, otherwise the exit animation will you fail
I'm centralizing my dialog with

fixed inset-0

When I put this code in the className of Content, I can't close the portal clicking outside, so I discovered that I can nest the content inside the overlay, and pow! I put the above code into overlay and it works for me

@MateusPitura exactly what worked for me (did not need the fixed inset-0 in my case). Thank you!


Update resources.md

Changed Cpp2IL into clickable link.
Updated UnityExplorer IL2CPP link to point to V Rising Thunderstore.
Put Cpp2IL command into code block so that the double dashes aren't changed into en dashes.

Thanks @stiffmeds , great contribution!


Add scenario for plugin extension overrides

Adds the following scenarios where the plugin extension is configured:

Overwrite parameter set to true
autoReportBuilds set to false
uploadDebug flag set to true in app with debug proguard maps
Modification of default build API info

Updated the Gemfile to use the master branch of maze-runner.
I've also addressed the missing mazerunner step in https://github.com/bugsnag/maze-runner/pull/16

Updated to use the new multipart request syntax introduced in #16


Feature Request: Allow to define an input folder

Current Behavior
Zero pick up files and folders in the project root folder, this is ok for small projects but can get messy for sites with many pages. Look at this:

Proposal
Allow to define an input folder where Zero will get the files, for example:
zero src
zero src/pages // or
zero ../client/pages // or
zero src docs // Multiple entry points, maybe 👀

And so the spread files can be organized into a "src" folder like that:

This also solves the confusion in .zeroignore to route only the desired files.
Backward compatibility
This new behavior can be easily integrated without breaking old projects. If no entry point is specified, it will fallback to root folder as usual.

Although not documented (I think), this should already work. Doing zero src or zero www or even zero build www should work just fine. Give it a shot please and see if you find it good enough.

I searched in the docs before open this issue but did not find this information 😓.
It would be relevant to show this. Wait a minute...

@iagobruno Did it work fine for your project?

Yes, much better than the other solution I used in another project.


Convert text to SelectableText

This is to allow users to select all text on the app. This helps it feel more native.

Done


Actions: promote jobs steps title to h3 to appear in sidebar

Why:

It seems h3 and up title will appear in sidebar.
Currently most common-used job config is hidden with it's h4 title.
What's being changed:

This commit changed the following title from h4 to h3 and also promoted sub-titles:

jobs.<job_id>.steps.*
jobs.<job_id>.strategy.*
jobs.<job_id>.container.*
jobs.<job_id>.services.<service_id>.*

Check off the following:

[x] All of the tests are passing.
[x] I have reviewed my changes in staging.
[x] For content changes, I have reviewed the localization checklist
[x] For content changes, I have reviewed the Content style guide for GitHub Docs.

Side note: after some more digging, it seems like setting miniTocMaxHeadingLevel: 4 like: content/actions/reference/events-that-trigger-workflows.md#L5 should also work.
Changing this way should result in a much smaller commit, if this is preferred then I can redo current commit.

Thanks @dr-js! I'll triage this for review ⚡

ping

Thanks for your patience @dr-js! Our team is still working out way through the amazing contributions we got during Hacktoberfest 🎃

Just realized that, too. Thank you all for keeping up the good work! 🎃
And if this needs any change, let me know!

ping


Board members: Update Gloria Robert's headshot

Please replace Gloria Roberts current headshot with this one:

@shrayshray Done!


Refactor the Arrow Mesh3D type to use zero-copy Buffers

For the arkit scene example this reduces visit time from 7ms to 20us.
Before:

After:

Checklist

[x] I have read and agree to Contributor Guide and the Code of Conduct
[x] I've included a screenshot or gif (if applicable)

350x speedup - decent


[OpenGL] Issue with captures and ARB_query_buffer_object

Description
When recording the result of a query into a buffer (extension ARB_query_buffer_object) the capture does seem to modify the buffer.
The example that I provide does the following:

renders a full screen triangle during a GL_SAMPLES_PASSED query
stores the query result into a buffer
renders a full screen triangle with the query result buffer as an input, with some conditional logic in the vertex shader to skip drawing if the query result is 0

When running the application the second triangle is drawn (the framebuffer is red), but in the RenderDoc capture it is not (the framebuffer is blue), and inspecting the query buffer contents shows 0.
Both the DSA version (glGetQueryBufferObject) and the non-DSA version (glBindBuffer(GL_QUERY_BUFFER) + glGetQueryObject) exhibit the same issue.
Steps to reproduce
Run this program:
Repro.executable.zip
or compile and run this code:
Repro.source.zip
or replay this capture:
Repro.capture.zip
Environment

RenderDoc version: 1.17 Nightly (2e4905a6a833e55f5c5acec0ad1f20d0651199a7)
Operating System: Windows 10
Graphics API: OpenGL 4.6 Core
Graphics Adapter: NVIDIA GeForce GTX 1080 Ti
Driver Version: 496.49

Blerch, looks like I hadn't accounted for the fact that an otherwise read-only CPU function takes on a special meaning depending on a buffer binding. glGetQueryObject with/without DSA isn't serialised much like all of the rest of the glGet functions. I'm also guessing that like vertex attrib bindings reading from an offset and/or CPU pointer this is going to lead to dozens of bugs where drivers read from near-NULL pointers depending on weird conditions.
Why is OpenGL always so completely terrible. It of course would have been utterly unthinkable to just have a different function for copying a query result to a buffer, since after all there are so few GL entry points it would be wasteful to add another...

That commit should serialise the buffer-writing versions of those glGet functions and works correctly on the repro case for me.


Added Dwarf Cannon

Addition of the Dwarf Cannon quest.

Rebased and fixed a few things, and merged in with https://github.com/Zoinkwiz/quest-helper/pull/99. Main things were:

Use substeps to keep the sidebar cleaner. Rather than 6 'fix railings', you can just have 1 which they're all grouped under.
Objects which change in any way are usualyl represented as a NullObjectID instead. You can check the linked PR for examples.


Update @ericcornelissen/bash-parser to 0.5.3

This update:

Resolves a licensing issue in the filter-iterator package. This package has been vendored, since it did not include a license field in its package.json, which is causing problems with automatic license checkers.
Removes dependency on deep-freeze, because the account of the original author has been deleted, making the package available for anyone to grab, which could be a potential security risk.

Thanks, @sockmaster27! And also @ericcornelissen for maintaining this fork, really appreciate it!

Any chance you could do a bun install to update the lockfile as well?

:rocket: This pull request is included in v5.18.2. See Release 5.18.2 for release notes.
Using Knip in a commercial project? Please consider becoming a sponsor.


Change Neo3Boa Documentation describing the features (first iteration)

Summary or solution description

Removed repetitions on README, CONTRIBUTING and docs;
Added execution examples on most functions and classes (some like ByteString and Neo3.6 methods were skipped);
Added some interops that were missing on the docs;
Removed subpackages on interops, since the classes are now shown on the package module;
Changed some files from rst to md.

Task linked: CU-864ej3bwe Change Neo3Boa Documentation describing the features (first iteration)

I had to rebase to get the newest ByteString changes, on the new commit I:

implemented most feedbacks;

The one I didn't do was : https://github.com/CityOfZion/neo3-boa/pull/1061#discussion_r1218256697

removed all warnings that would show up when building the docs;
stopped autogenerating private methods on docs;
added a section talking about how to invoke your deployed smart contract with NeoNova;
added interop subpackages into the main package instead of having a page for each one (for example, 'Block' and 'Transaction' classes are inside the 'interop.blockchain' page).
changed the links on the markdown, because they were referencing the dojo.coz.io documentation that might not have the method/class/variable/same_path on the newest version


scripts-python.yaml example doesn't work

Is this a BUG REPORT or FEATURE REQUEST?: 🦟🐛
What happened:
Running this https://github.com/argoproj/argo/blob/master/examples/scripts-python.yaml
argo -n argo logs -w scripts-python-9stwm
generate:	27
print:	result was: {{steps.generate.outputs.result}}

It's not substituting anything.
What you expected to happen:
argo -n argo logs -w scripts-python-9stwm
generate:	27
print:	result was: 27

How to reproduce it (as minimally and precisely as possible):
Anything else we need to know?:
Environment:

Argo version: 2.4.2
Kubernetes version :

clientVersion:
  buildDate: "1970-01-01T00:00:01Z"
  compiler: gc
  gitCommit: 5e53fd6bc17c0dec8434817e69b04a25d8ae0ff0
  gitTreeState: archive
  gitVersion: v1.14.3
  goVersion: go1.12.7
  major: "1"
  minor: "14"
  platform: darwin/amd64
serverVersion:
  buildDate: "2019-10-18T17:56:01Z"
  compiler: gc
  gitCommit: b7174db5ee0e30c94a0b9899c20ac980c0850fc8
  gitTreeState: clean
  gitVersion: v1.14.8-eks-b7174d
  goVersion: go1.12.10
  major: "1"
  minor: 14+
  platform: linux/amd64

I was not able to reproduce this on v2.4.2 or on master. Is there any more info you could provide to help track this down?
(Here pl is a function to just print the logs of the pod)
Name:                scripts-python-rzw8z
Namespace:           argo
ServiceAccount:      default
Status:              Succeeded
Created:             Mon Dec 02 21:06:48 -0800 (16 seconds ago)
Started:             Mon Dec 02 21:06:48 -0800 (16 seconds ago)
Finished:            Mon Dec 02 21:07:03 -0800 (1 second ago)
Duration:            15 seconds

STEP                                             PODNAME                          DURATION  MESSAGE
 ✔ scripts-python-rzw8z (python-script-example)
 ├---✔ generate (gen-random-int)                 scripts-python-rzw8z-2793789937  7s
 └---✔ print (print-message)                     scripts-python-rzw8z-1274028040  4s
$ pl scripts-python-rzw8z-2793789937
17
$ pl scripts-python-rzw8z-1274028040
result was: 17
$ argo logs -w scripts-python-rzw8z
generate:	17
print:	result was: 17
$ git status
HEAD detached at v2.4.2
...

I'll double check. I'm literally doing:
argo -n argo submit https://raw.githubusercontent.com/argoproj/argo/master/examples/scripts-python.yaml --watch
argo -n argo logs -w scripts-python-dngws

Our workflow-controller is argoproj/workflow-controller:v2.4.2 and our client is actually "2.4.1" (sha256 is 1f9l9d4r0qfhpr2fn17faczcwmwmdz8f56f27cmmnhxz4r7qcm48).

I wouldn't expect this involves the client though as if I do:
kubectl -n argo logs scripts-python-dngws-4266348542 main
then I see:
result was: {{steps.generate.outputs.result}}

time="2019-12-03T05:40:56Z" level=info msg="Processing workflow" namespace=argo workflow=scripts-python-t6dfn
time="2019-12-03T05:40:56Z" level=info msg="Updated phase  -> Running" namespace=argo workflow=scripts-python-t6dfn
time="2019-12-03T05:40:56Z" level=info msg="Steps node scripts-python-t6dfn (scripts-python-t6dfn) initialized Pending" namespace=argo workflow=scripts-python-t6dfn
time="2019-12-03T05:40:56Z" level=info msg="Create stored template '/python-script-example'" namespace=argo workflow=scripts-python-t6dfn
time="2019-12-03T05:40:56Z" level=info msg="node scripts-python-t6dfn (scripts-python-t6dfn) phase Pending -> Running" namespace=argo workflow=scripts-python-t6dfn
time="2019-12-03T05:40:56Z" level=info msg="StepGroup node scripts-python-t6dfn[0] (scripts-python-t6dfn-1919686939) initialized Running" namespace=argo workflow=scripts-python-t6dfn
time="2019-12-03T05:40:56Z" level=info msg="Pod node scripts-python-t6dfn[0].generate (scripts-python-t6dfn-4291393880) initialized Pending" namespace=argo workflow=scripts-python-t6dfn
time="2019-12-03T05:40:56Z" level=info msg="Create stored template '/gen-random-int'" namespace=argo workflow=scripts-python-t6dfn
time="2019-12-03T05:40:56Z" level=info msg="Created pod: scripts-python-t6dfn[0].generate (scripts-python-t6dfn-4291393880)" namespace=argo workflow=scripts-python-t6dfn
time="2019-12-03T05:40:56Z" level=info msg="Workflow step group node scripts-python-t6dfn[0] (scripts-python-t6dfn-1919686939) not yet completed" namespace=argo workflow=scripts-python-t6dfn
time="2019-12-03T05:40:56Z" level=info msg="Workflow update successful" namespace=argo workflow=scripts-python-t6dfn
time="2019-12-03T05:40:57Z" level=info msg="Processing workflow" namespace=argo workflow=scripts-python-t6dfn
time="2019-12-03T05:40:58Z" level=info msg="Updating node scripts-python-t6dfn[0].generate (scripts-python-t6dfn-4291393880) message: PodInitializing"
time="2019-12-03T05:40:58Z" level=info msg="Skipped pod scripts-python-t6dfn[0].generate (scripts-python-t6dfn-4291393880) creation: already exists" namespace=argo workflow=scripts-python-t6dfn
time="2019-12-03T05:40:58Z" level=info msg="Workflow step group node scripts-python-t6dfn[0] (scripts-python-t6dfn-1919686939) not yet completed" namespace=argo workflow=scripts-python-t6dfn
time="2019-12-03T05:40:58Z" level=info msg="Workflow update successful" namespace=argo workflow=scripts-python-t6dfn
time="2019-12-03T05:40:59Z" level=info msg="Processing workflow" namespace=argo workflow=scripts-python-t6dfn
time="2019-12-03T05:40:59Z" level=info msg="Skipped pod scripts-python-t6dfn[0].generate (scripts-python-t6dfn-4291393880) creation: already exists" namespace=argo workflow=scripts-python-t6dfn
time="2019-12-03T05:40:59Z" level=info msg="Workflow step group node scripts-python-t6dfn[0] (scripts-python-t6dfn-1919686939) not yet completed" namespace=argo workflow=scripts-python-t6dfn
time="2019-12-03T05:40:59Z" level=info msg="Processing workflow" namespace=argo workflow=scripts-python-t6dfn
time="2019-12-03T05:41:00Z" level=info msg="Skipped pod scripts-python-t6dfn[0].generate (scripts-python-t6dfn-4291393880) creation: already exists" namespace=argo workflow=scripts-python-t6dfn
time="2019-12-03T05:41:00Z" level=info msg="Workflow step group node scripts-python-t6dfn[0] (scripts-python-t6dfn-1919686939) not yet completed" namespace=argo workflow=scripts-python-t6dfn
time="2019-12-03T05:41:00Z" level=info msg="Processing workflow" namespace=argo workflow=scripts-python-t6dfn
time="2019-12-03T05:41:01Z" level=info msg="Updating node scripts-python-t6dfn[0].generate (scripts-python-t6dfn-4291393880) status Pending -> Succeeded"
time="2019-12-03T05:41:01Z" level=info msg="Step group node scripts-python-t6dfn[0] (scripts-python-t6dfn-1919686939) successful" namespace=argo workflow=scripts-python-t6dfn
time="2019-12-03T05:41:01Z" level=info msg="node scripts-python-t6dfn[0] (scripts-python-t6dfn-1919686939) phase Running -> Succeeded" namespace=argo workflow=scripts-python-t6dfn
time="2019-12-03T05:41:01Z" level=info msg="node scripts-python-t6dfn[0] (scripts-python-t6dfn-1919686939) finished: 2019-12-03 05:41:01.149213341 +0000 UTC" namespace=argo workflow=scripts-python-t6dfn
time="2019-12-03T05:41:01Z" level=info msg="StepGroup node scripts-python-t6dfn[1] (scripts-python-t6dfn-1986944510) initialized Running" namespace=argo workflow=scripts-python-t6dfn
time="2019-12-03T05:41:01Z" level=info msg="SG Outbound nodes of scripts-python-t6dfn-4291393880 are [scripts-python-t6dfn-4291393880]" namespace=argo workflow=scripts-python-t6dfn
time="2019-12-03T05:41:01Z" level=info msg="Pod node scripts-python-t6dfn[1].print (scripts-python-t6dfn-363012119) initialized Pending" namespace=argo workflow=scripts-python-t6dfn
time="2019-12-03T05:41:01Z" level=info msg="Create stored template '/print-message'" namespace=argo workflow=scripts-python-t6dfn
time="2019-12-03T05:41:01Z" level=info msg="Created pod: scripts-python-t6dfn[1].print (scripts-python-t6dfn-363012119)" namespace=argo workflow=scripts-python-t6dfn
time="2019-12-03T05:41:01Z" level=info msg="Workflow step group node scripts-python-t6dfn[1] (scripts-python-t6dfn-1986944510) not yet completed" namespace=argo workflow=scripts-python-t6dfn
time="2019-12-03T05:41:01Z" level=info msg="Workflow update successful" namespace=argo workflow=scripts-python-t6dfn
time="2019-12-03T05:41:02Z" level=info msg="Processing workflow" namespace=argo workflow=scripts-python-t6dfn
time="2019-12-03T05:41:02Z" level=info msg="Labeled pod argo/scripts-python-t6dfn-4291393880 completed"
time="2019-12-03T05:41:02Z" level=info msg="Updating node scripts-python-t6dfn[1].print (scripts-python-t6dfn-363012119) message: ContainerCreating"
time="2019-12-03T05:41:02Z" level=info msg="node scripts-python-t6dfn[0] (scripts-python-t6dfn-1919686939) phase Succeeded -> Running" namespace=argo workflow=scripts-python-t6dfn
time="2019-12-03T05:41:02Z" level=info msg="Step group node scripts-python-t6dfn[0] (scripts-python-t6dfn-1919686939) successful" namespace=argo workflow=scripts-python-t6dfn
time="2019-12-03T05:41:02Z" level=info msg="node scripts-python-t6dfn[0] (scripts-python-t6dfn-1919686939) phase Running -> Succeeded" namespace=argo workflow=scripts-python-t6dfn
time="2019-12-03T05:41:02Z" level=info msg="SG Outbound nodes of scripts-python-t6dfn-4291393880 are [scripts-python-t6dfn-4291393880]" namespace=argo workflow=scripts-python-t6dfn
time="2019-12-03T05:41:02Z" level=info msg="Skipped pod scripts-python-t6dfn[1].print (scripts-python-t6dfn-363012119) creation: already exists" namespace=argo workflow=scripts-python-t6dfn
time="2019-12-03T05:41:02Z" level=info msg="Workflow step group node scripts-python-t6dfn[1] (scripts-python-t6dfn-1986944510) not yet completed" namespace=argo workflow=scripts-python-t6dfn
time="2019-12-03T05:41:02Z" level=info msg="Workflow update successful" namespace=argo workflow=scripts-python-t6dfn
time="2019-12-03T05:41:03Z" level=info msg="Processing workflow" namespace=argo workflow=scripts-python-t6dfn
time="2019-12-03T05:41:03Z" level=info msg="Labeled pod argo/scripts-python-t6dfn-4291393880 completed"
time="2019-12-03T05:41:03Z" level=info msg="Updating node scripts-python-t6dfn[1].print (scripts-python-t6dfn-363012119) status Pending -> Succeeded"
time="2019-12-03T05:41:03Z" level=info msg="node scripts-python-t6dfn[0] (scripts-python-t6dfn-1919686939) phase Succeeded -> Running" namespace=argo workflow=scripts-python-t6dfn
time="2019-12-03T05:41:03Z" level=info msg="Step group node scripts-python-t6dfn[0] (scripts-python-t6dfn-1919686939) successful" namespace=argo workflow=scripts-python-t6dfn
time="2019-12-03T05:41:03Z" level=info msg="node scripts-python-t6dfn[0] (scripts-python-t6dfn-1919686939) phase Running -> Succeeded" namespace=argo workflow=scripts-python-t6dfn
time="2019-12-03T05:41:03Z" level=info msg="SG Outbound nodes of scripts-python-t6dfn-4291393880 are [scripts-python-t6dfn-4291393880]" namespace=argo workflow=scripts-python-t6dfn
time="2019-12-03T05:41:03Z" level=info msg="Step group node scripts-python-t6dfn[1] (scripts-python-t6dfn-1986944510) successful" namespace=argo workflow=scripts-python-t6dfn
time="2019-12-03T05:41:03Z" level=info msg="node scripts-python-t6dfn[1] (scripts-python-t6dfn-1986944510) phase Running -> Succeeded" namespace=argo workflow=scripts-python-t6dfn
time="2019-12-03T05:41:03Z" level=info msg="node scripts-python-t6dfn[1] (scripts-python-t6dfn-1986944510) finished: 2019-12-03 05:41:03.707833475 +0000 UTC" namespace=argo workflow=scripts-python-t6dfn
time="2019-12-03T05:41:03Z" level=info msg="Outbound nodes of scripts-python-t6dfn-363012119 is [scripts-python-t6dfn-363012119]" namespace=argo workflow=scripts-python-t6dfn
time="2019-12-03T05:41:03Z" level=info msg="Outbound nodes of scripts-python-t6dfn is [scripts-python-t6dfn-363012119]" namespace=argo workflow=scripts-python-t6dfn
time="2019-12-03T05:41:03Z" level=info msg="node scripts-python-t6dfn (scripts-python-t6dfn) phase Running -> Succeeded" namespace=argo workflow=scripts-python-t6dfn
time="2019-12-03T05:41:03Z" level=info msg="node scripts-python-t6dfn (scripts-python-t6dfn) finished: 2019-12-03 05:41:03.707889389 +0000 UTC" namespace=argo workflow=scripts-python-t6dfn
time="2019-12-03T05:41:03Z" level=info msg="Checking daemoned children of scripts-python-t6dfn" namespace=argo workflow=scripts-python-t6dfn
time="2019-12-03T05:41:03Z" level=info msg="Updated phase Running -> Succeeded" namespace=argo workflow=scripts-python-t6dfn
time="2019-12-03T05:41:03Z" level=info msg="Marking workflow completed" namespace=argo workflow=scripts-python-t6dfn
time="2019-12-03T05:41:03Z" level=info msg="Checking daemoned children of " namespace=argo workflow=scripts-python-t6dfn
time="2019-12-03T05:41:03Z" level=info msg="Workflow update successful" namespace=argo workflow=scripts-python-t6dfn
time="2019-12-03T05:41:04Z" level=info msg="Labeled pod argo/scripts-python-t6dfn-363012119 completed"

☝ That's the workflow-controller logs during an execution.

I think I know what's going on – your issue seems to be related to https://github.com/argoproj/argo/issues/1792.
It seems that you either do not have your service account set up correctly, or are running the workflow in a namespace in which you do not have the service account set. Because of this, Argo can't access the outputs of the script. Can you check this for me please?
I tried running the same script in a namespace with no service account and was able to reproduce the issue.

Ahh! Yeh this sounds likely. We need to set serviceAccount in our workflows namespace you can't use the default.
Just checked by adding the requisite serviceAccount and yep it works.
This is pretty close to a silent failure. I think this should not be the behaviour of the workflow if it's missing perms. It should fail hard.
What do you think?

This is pretty close to a silent failure. I think this should not be the behaviour of the workflow if it's missing perms. It should fail hard.
What do you think?

Agree with you, that’s what #1792 is tracked to fix.

Yep fair. I was a little thrown off because in this case there technically is no error but that issue is about an error, but yeah that'll cover it.
Cheers for getting on this fast. 👍

Thanks for the discussion!


prevent infinite loop

Couldn't the middleware remove the meta info itself, if the posted back action is of the same type?

I agree and it's a very simple task:
worker.onmessage = ({ data: resultAction }) => { // eslint-disable-line no-param-reassign
      resultAction.meta.WebWorker = false;
      dispatch(resultAction);
    };

No longer using redux. Cleaning up stale issues.


Authentication skeleton

https://auth0.com/docs/quickstart/spa/react/01-login
https://auth0.com/docs/get-started/authentication-and-authorization-flow/authorization-code-flow-with-pkce/add-login-using-the-authorization-code-flow-with-pkce#request-tokens
integrate auth0 with nextjs,
create account add the accounts details in this ticket

https://manage.auth0.com/dashboard/uk/doctors/applications/Oj9TLUzOI5454fHVmboTfmwwhJd8ZlAs/quickstart

.env.local file should be
AUTH0_SECRET='b8946c6aee51d916f04a421e2aa7936bb5cdb8d774a030e8e3d6236048c03d58'
AUTH0_BASE_URL='http://localhost:3000'
AUTH0_ISSUER_BASE_URL='https://doctors.uk.auth0.com'
AUTH0_CLIENT_ID='Oj9TLUzOI5454fHVmboTfmwwhJd8ZlAs'
AUTH0_CLIENT_SECRET='rlrax00qjW2mjSj1J2vbBsv6n5z7t_rBg8GUO_oy-i2Uxkg9H65GaO8BrGwcmjQr'


jruby:9.1.3-alpine image is jruby <IP_ADDRESS>

$ docker run --rm -it jruby:9.1.3-alpine jruby -v
jruby <IP_ADDRESS> (2.3.0) 2016-05-26 7357c8f OpenJDK 64-Bit Server VM 25.92-b14 on 1.8.0_92-internal-alpine-r1-b14 +jit [linux-x86_64]
$ docker images
REPOSITORY          TAG                 IMAGE ID            CREATED             SIZE
jruby               9-alpine            534f74c0c1c8        5 days ago          162.1 MB
jruby               9.1.3-alpine        534f74c0c1c8        5 days ago          162.1 MB

ping @tianon

Huh, this is definitely an odd one -- I looked through the PR history over on https://github.com/docker-library/official-images, and all the Git diffs look correct (I don't see anything that could've caused this), and I just tested the current version (9.1.8) and it does not suffer from this issue. :disappointed:
I think there must have been an issue with our build/push process that somehow got the older 9.1.2 image pushed at the 9.1.3 tag; sorry about that!  Is 9.1.3 important enough that I should do some archaeological digging to restore the previous contents, or do you think we're safe enough to let this one slide and just keep an eye out for repeat occurrences?

It's probably not important, just a patch release.
@shakiyam ?


The name 'WebTemplateCore' does not exist in the current context

I am getting the error "The name 'WebTemplateCore' does not exist in the current context" while trying to implement Intranet.canada.ca theme.   The application runs fine on my local VM but this error happens when I deploy the application to our dev environment.   I am using .NET Framework 4.8 and GoC.WebTemplate version v4_0_39.  I have attached the error message details.
Thank You,
error.txt

Issue resolved (discussed via email).


double.remainder() performance issues?

Hello everyone! Maybe I'm doing something wrong here, but I'm experiencing a pretty heavy performance hit with double.remainder() on ARM64 (M3) in Dart 3.3.3 on macOS.
As per the documentation, a.remainder(b) is mathematically equivalent to:
double remainder(final double a, final num b) => a - (a ~/ b) * b;

But when I compare the two, the custom implementation is somewhere between one and two orders of magnitude faster:
class RemainderBenchmark extends BenchmarkBase {
  const RemainderBenchmark() : super('Remainder');

  @override
  void run() {
    for (double i = -500; i <= 500; i += 0.75) {
      for (double j = -500; j <= 500; j += 0.75) {
        final _ = i.remainder(j);
      }
    }
  }
}

class RemainderCustomBenchmark extends BenchmarkBase {
  const RemainderCustomBenchmark() : super('RemainderCustom');

  @override
  void run() {
    for (double i = -500; i <= 500; i += 0.75) {
      for (double j = -500; j <= 500; j += 0.75) {
        final _ = remainder(i, j);
      }
    }
  }
}

AOT (dart compile exe):
RemainderCustom(RunTime): 38108.96153846154 us.
Remainder(RunTime): 478124.0 us. <- About 13x slower!

JIT (dart run):
RemainderCustom(RunTime): 9825.791469194313 us.
Remainder(RunTime): 507507.0 us. <- About 52x slower!

Any ideas why this is the case?

Similar results on (..checks...) intel CPU.
An up to 40x slowdown suggests to me that the code is either using a very inefficient assembler instruction, or it's calling into the C runtime for each .remainder call. Even using % is faster, but still much slower than the custom version.
Or maybe remainder on doubles is just amazingly expensive to do correctly, and the approximation won't give the same result in all cases. (And if that's OK, it's a good optimization.)
I do think double.remainder is compiled as a runtime call. The code for it is:
  double remainder(num other) {
    return _remainder(other.toDouble());
  }

  @pragma("vm:external-name", "Double_remainder")
  external double _remainder(double other);

which means calling a function in double.cc. There could be an intrinsified version that replaces this with generated assembler, but I can't find it.

An up to 40x slowdown suggests to me that the code is either using a very inefficient assembler instruction, or it's calling into the C runtime for each .remainder call. Even using % is faster, but still much slower than the custom version.

Yes, I was also thinking it could be some form of call overhead, it seems unlikely that disastrous assembler is produced across multiple platforms? I actually re-implemented % as well, but it is quite performant on ARM64. I didn't manage to beat it... I just tried with int.remainder() and it's suffering from the same performance issues as its double counterpart.

Or maybe remainder on doubles is just amazingly expensive to do correctly, and the approximation won't give the same result in all cases. (And if that's OK, it's a good optimization.)

I think it's not a mathematical approximation, but an equivalence. I also considered that the two could be different numerically, but they seem to produce identical results over a pretty large number of inputs, i.e. i.remainder(j) == remainder(i, j) holds, in accordance with the docs (although r.remainder(j) produces a more straight-forward exception when j = 0). Of course, there could be non-trivial edge cases I have overlooked.

//cc @alexmarkov @aam

https://dart-review.googlesource.com/c/sdk/+/364780


Feature branch md

training pr for #138

Great job @mmmiah you are now prepared to handle and resolve merge conflicts in the wild! Also thank you for volunteering to walk the group through this exercise!


Determine the fate of kubecontainer.Option which is only needed by mesos

Hi guys,
We are now refactoring kubelet to use new CRI, and we noticed mesos integration introduced a kubecontainer.Option to kube-runtime, which blocked the refactoring a little bit.
Because we consider sandbox env should be docker specific for now, so we have to remove the runtime levelkubecontainer.Option and move pod sandbox env to dockershim.
So we'd like to discuss is kube-mesos-framework still relying on this option? If we change it to dockershim, how will mesos set pod sandbox env?
ref: https://github.com/kubernetes/kubernetes/pull/33561

A little bit of the background on CRI (Container Runtime Interface). We are in the process of defining an API between kubelet and the container runtime to allow more runtimes to easily integrate with kuberentes. One significant difference introduced by this API is that we define a PodSandbox, which each runtime may interpret differently. For docker, this will be the good old infra container to hold the namespaces. For other runtimes, this may mean a VM. Therefore, the PodInfraContainerEnv can no longer be generic because it assumes that the pod sandbox is a container.
From the codebase point of view, we are splitting the pkg/kubelet/dockertools packages into two packages: pkg/kubelet/kuberuntime and pkg/kubelet/dockershim. The two packages communicate via the new
api. The PodinfraContainerEnv logic definitely belongs to the docker-specific implementation in pkg/kubelet/dockershim. Depends on whether the mesos integration still needs this feature, we can discuss how to implement this in the new docker package (or mesos can write a customized CRI shim for docker as well!).
Note that the old dockertools implementation will still be the default in v1.5, so this issue is not that urgent. It'd still be good to start the conversation about how CRI would affect the current kube-mesos framework.
/cc @jdef, who added the feature

@yujuhong - I am +1 on mesos having a customized CRI shim

And the shim ideally should live in this repo...

@derekwaynecarr , @yujuhong , thanks for our heads up :); I'm going to handle this.
As you known, we're working to re-factor kube-mesos to avoid vendoring kube at https://github.com/kubernetes-incubator/kube-mesos-framework/projects/1 ; so I'm not sure whether the docker shim will be included in this repo. Anyway, let me do some investigation :).


Upgrade socket

closes #3

Currently failing with:
  "stack": [
    "TypeError: Cannot read property 'passport' of undefined",
    "    at Socket.<anonymous> (/Users/glebbahmutov/git/chat.io/app/socket/index.js:116:34)",
    "    at Socket.emit (events.js:375:28)",
    "    at Socket.emitReserved (/Users/glebbahmutov/git/chat.io/node_modules/socket.io/dist/typed-events.js:56:22)",


Installation of ingress plugin isn't described in the doc

Some comments regarding existing README guide:

Installation of ingress plugin isn't described:

minikube addons enable ingress

Minikube creation details:

minikube --memory 4096 --cpus 4 --vm-driver hyperkit

How to find minikube IP (some static one is present in the docs):

minikube ip

Updated.


Add example for a keyvault-managed storage account

Is your feature request related to a problem? Please describe.
A clear example of how to create a keyvault-managed storage account in Bicep would act as a reference guide. For now the information is distributed among:

https://docs.microsoft.com/en-us/azure/key-vault/secrets/overview-storage-keys
https://docs.microsoft.com/en-us/azure/key-vault/keys/quick-create-template?tabs=CLI
https://stackoverflow.com/questions/64403526/how-to-create-a-key-vault-managed-storage-account-in-an-arm-template

Describe the solution you'd like
Have a .bicep example of creating a keyvault-managed storage account.

I can take a look at this!

Just for more context, a secrete parity to managed storage account for retrieving sas token is invisible from Azure portal, and "az keyvault secret show" doesn't work for that secrete (return secret not found error). It looks like a delegation for getting sas token, not a actual secret.

According to @bmoore-msft this isn't possible, if I look at this issue:
https://github.com/Azure/azure-quickstart-templates/issues/7439
Is this still the case?

It looks like what we need is in the storage API:
encryption: {
      identity: {
        userAssignedIdentity: 'string'
      }
      keySource: 'string'
      keyvaultproperties: {
        keyname: 'string'
        keyvaulturi: 'string'
        keyversion: 'string'
      }
}

Additionally, this is the information we are looking for: https://www.codeisahighway.com/how-to-use-customer-managed-keys-with-azure-key-vault-and-azure-storage-encryption-using-arm-template/

Additionally, this is the information we are looking for: https://www.codeisahighway.com/how-to-use-customer-managed-keys-with-azure-key-vault-and-azure-storage-encryption-using-arm-template/

Okay, now things start to get a little more clear, you want to be able to:

Create a Storage Account
Create a Key Vault
Create a key inside the Key Vault and reference it as a encryption key inside the storage account?

The other links in the initial request is partial for how to rotate the Access Keys inside the storage account.
So please confirm the steps above, just to verify please. :)

I confirm.

@stan-sz
See template below and let me know if it fits your need.
I'm going to add it to the "Azure Resource Manager QuickStart Templates"-gallery as well but I thought you could get your hands on it first 😃
// Global
@description('The location into which the resources should be deployed.')
param location string = resourceGroup().location

@description('The Tenant Id that should be used throughout the deployment.')
param tenantId string = subscription().tenantId

// UAI
@description('The name of the User Assigned Identity.')
param userAssignedIdentityName string

// keyVault
@description('The name of the Key Vault.')
param keyVaultName string

// keyVaultKey
@description('Name of the key in the Key Vault')
param keyVaultKeyName string

// storageAccount
@description('The name of the Storage Account')
param storageAccountName string

resource userAssignedIdentity 'Microsoft.ManagedIdentity/userAssignedIdentities@2018-11-30' = {
  name: userAssignedIdentityName
  location: location
}

resource keyVault 'Microsoft.KeyVault/vaults@2021-06-01-preview' = {
  name: keyVaultName
  location: location
  properties: {
    enableSoftDelete: true
    enablePurgeProtection: true
    enabledForDeployment: true
    enabledForDiskEncryption: true
    enabledForTemplateDeployment: true
    tenantId: tenantId
    accessPolicies: []
    sku: {
      name: 'standard'
      family: 'A'
    }
  }
}

resource kvPolicy 'Microsoft.KeyVault/vaults/accessPolicies@2021-06-01-preview' = {
  name: 'add'
  parent: keyVault
  properties: {
    accessPolicies: [
      {
        tenantId: tenantId
        permissions: {
          keys: [
            'unwrapKey'
            'wrapKey'
            'get'
          ]
        }
        objectId: userAssignedIdentity.properties.principalId
      }
    ]
  }
}

resource kvKey 'Microsoft.KeyVault/vaults/keys@2021-06-01-preview' = {
  name: keyVaultKeyName
  parent: keyVault
  properties: {
    attributes: {
      enabled: true
    }
    keySize: 4096
    kty: 'RSA'
  }
}

resource storage 'Microsoft.Storage/storageAccounts@2021-04-01' = {
  name: storageAccountName
  location: location
  dependsOn: [
    kvPolicy
  ]
  sku: {
    name: 'Standard_LRS'
  }
  kind: 'StorageV2'
  identity: {
    type: 'UserAssigned'
    userAssignedIdentities: {
      '${userAssignedIdentity.id}': {}
    }
  }
  properties: {
    encryption: {
      identity: {
        userAssignedIdentity: userAssignedIdentity.id
      }
      services: {
         blob: {
           enabled: true
         }
      }
      keySource: 'Microsoft.Keyvault'
      keyvaultproperties: {
        keyname: kvKey.name
        keyvaulturi: keyVault.properties.vaultUri
      }
    }
    accessTier: 'Hot'
    supportsHttpsTrafficOnly: true
  }
}

Works like a charm. Thank you. A few notes:

consider defaulting storage to TLS1_2
Ideally use the parent/child nesting syntax for the keyvault
access policies can be inlined in the keyvault resource

I found a problem with this example: the keyVault.properties.vaultUri in
keyvaultproperties: {
  ...
  keyvaulturi: keyVault.properties.vaultUri

returns a URL with a trailing / which ends up in the storage RP as (taken from portal): https://<keyVaultName>.vault.azure.net//keys/<keyVaultKeyName> and is an invalid URL.
The PR should disallow setting it or handle trailing /.

@emilguden - is there an ARM template for the managed SAS tokens, per https://docs.microsoft.com/en-us/azure/key-vault/secrets/overview-storage-keys-powershell#shared-access-signature-tokens?

@stan-sz
I think this is what you're looking for (If not, let me know):
https://samcogan.com/generate-sas-tokens-in-arm-teamplates/
I created a Bicep-template for it as well, the parameter "accountSasProperties" could look something like this:
{
        "signedServices": "b",
        "signedPermission": "rwl",
        "signedExpiry": "2022-05-24T00:00:01Z",
        "signedResourceTypes": "sco"
}

Template:
@description('The location into which the resources should be deployed.')
param location string = resourceGroup().location

@description('The Tenant Id that should be used throughout the deployment.')
param tenantId string = subscription().tenantId

@description('Name of KeyVault to Store SaS Token')
param keyVaultName string

@description('Name of Storage Account to Create')
param StorageAccountName string

@description('Name of User Assigned Identity')
param userAssignedIdentityName string

@description('The permissions that the SAS will contain')
param accountSasProperties object

resource userAssignedIdentity 'Microsoft.ManagedIdentity/userAssignedIdentities@2018-11-30' = {
  name: userAssignedIdentityName
  location: location
}

resource StorageAccount 'Microsoft.Storage/storageAccounts@2021-04-01' = {
  name: StorageAccountName
  location: resourceGroup().location
  tags: {
    displayName: StorageAccountName
  }
  sku: {
    name: 'Standard_LRS'
  }
  kind: 'StorageV2'
}

resource keyVault 'Microsoft.KeyVault/vaults@2021-06-01-preview' = {
  name: keyVaultName
  dependsOn: [
    userAssignedIdentity
  ]
  location: resourceGroup().location
  tags: {
    displayName: keyVaultName
  }
  properties: {
    enabledForDeployment: true
    enabledForTemplateDeployment: true
    enabledForDiskEncryption: true
    tenantId: tenantId
    accessPolicies: [
      {
        tenantId: tenantId
        objectId: userAssignedIdentity.properties.principalId
        permissions: {
          keys: [
            'get'
          ]
          secrets: [
            'list'
            'get'
            'set'
          ]
        }
      }
    ]
    sku: {
      name: 'standard'
      family: 'A'
    }
  }
}

resource storageSaSToken 'Microsoft.KeyVault/vaults/secrets@2021-06-01-preview' = {
  dependsOn:[
    StorageAccount
  ]
  parent: keyVault
  name: 'StorageSaSToken'
  properties: {
    value: listAccountSas(StorageAccount.name,'2021-04-01',accountSasProperties).accountSasToken
  }
}


Fix crash on shutdown if init failed

If the init failed, data remains None. The shutdown unconditionally
unwraps data which leads to a panic in the plugin and a crash of
Teamspeak. This changes verifies that data is not None before using it.

Thanks!
Interesting, I thought TeamSpeak wouldn't call shutdown if init failed, but it seems like I never tried it.


Make actions not available while sleeping

About the PR

Title
fixes #13800
Why / Balance

Technical details

Media

[ ] I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes

Changelog

:cl:

fix: Actions now not available while sleeping (cannot scream when sleep).

checkConsciousness already exsits

ok and its too hard for me to understand so maybe ill return to this later, if nobody will make pr for it


Restrict the upper bound unicode-data on hackage for <= 0.2.0

unicode-data has an upper bound of base < 5 for unicode-data <= 0.2.0
This lax upper bound results in unicode-data-0.2.0 being chosen in newer ghc.
The ideal behaviour should be failure of compilation resulting in bump of upper bound accordingly.

Constrained the required revisions.


Use ReadonlyArray in type declarations

We can't really use ReadonlyArray anywhere else until we fix the type declarations.
This is technically a breaking change, but people shouldn't have been modifying arrays after creation anyway.

Do you mean in our API?

In each types.ts basically.

i would rather we wait on this untill we have a readonly type operator.

Can this be revisited as we now have readonly?


add istio metrics graph types

istiocluster -- get istio metric information in cluster level
istioproject -- get istio metric information in project level

LGTM

Link to https://github.com/rancher/rancher/issues/19087

Closing this PR in favor of PR https://github.com/rancher/types/pull/839

Please close this PR


add a book about JS

[ ] I have read freeCodeCamp's contribution guidelines.
[ ] My pull request has a descriptive title (not a vague title like Update index.md)
[ ] My pull request targets the master branch of freeCodeCamp.
[ ] None of my changes are plagiarized from another source without proper attribution.
[ ] My article does not contain shortened URLs or affiliate links.

If your pull request closes a GitHub issue, replace the XXXXX below with the issue number.
Closes #XXXXX

Hi @lilabdel, thank you for the PR!
Unfortunately, your branch has some merge conflicts that are difficult to resolve. The painless way to fix this is to create a fresh PR.
So I'm going to close your PR now and looking forward to your new one. I'm so sorry for the inconvenience.


Terminal uses editor.background instead of terminal.background from color theme

Lapce Version
nightly de2d7b1
System information
arch linux
Describe the bug
The bottom panel's color should be determined by terminal.background, but it uses editor.background
Additional information

@RinLovesYou Would this be more like it?


Bug: cannot pair with streamlabs

portal_1  | 2023-06-01 20:58:06.2864|ERROR|BTCPayServer.Stream.HttpClients.StreamlabsClient.StreamlabsHttpClient|Error while getting a response: Unauthorized - {"error":"invalid_client","error_description":"Client authentication failed."}
portal_1  | 2023-06-01 20:58:06.2994|ERROR|Microsoft.AspNetCore.Diagnostics.ExceptionHandlerMiddleware|An unhandled exception has occurred while executing the request.
portal_1  | 2023-06-01 21:02:00.6867|ERROR|BTCPayServer.Stream.HttpClients.StreamlabsClient.StreamlabsHttpClient|Error while getting a response: Unauthorized - {"error":"invalid_client","error_description":"Client authentication failed."}
portal_1  | 2023-06-01 21:02:00.6935|ERROR|Microsoft.AspNetCore.Diagnostics.ExceptionHandlerMiddleware|An unhandled exception has occurred while executing the request.

The connection and pairing with BTCPayServer works fine though.

Hey Gorrdy, thanks for your feedback.
The problem was caused by the new version of Streamlabs API v2.0, for which the application was not ready. That's why I just released its new version v1.1.0, which fixes it.


Update C# Grammar

C# 8 support (Pattern matching enhancements, Asynchronous streams, Enhancement of interpolated verbatim strings)
csharp-tmLanguage#165
(Contributed by @david-driscoll)
Additional C# 8 support (Using Declarations, Static Local Functions, Null-coalescing Assignment)
csharp-tmLanguage#188
(Contributed by @rchowe)
Add support for Nullable Array types.
csharp-tmLanguage#175
(Contributed by @GeorchW)

@JoeRobich thanks for the PR! I update all the grammars about once per month, and I'm planning on updating on Monday. We are releasing soon, and Monday is after we branch for release. I will look at merging this PR at that time.

Also, if you want me to update a specific to pick up a change earlier than my usual monthly update, then please feel free to open an issue! You are of course welcome to make a PR, but with the grammar updating script we have it is easy for me to do.

You are of course welcome to make a PR, but with the grammar updating script we have it is easy for me to do.

Thanks! I didn't realize this was automated. It had been such a long time since we've taken changes and I saw that Dustin has opened PRs in the past. If it is easier to close this PR and allow it to flow with your scripts, that woudl be fine with me.

Thanks! I have updated all grammars with this change: https://github.com/microsoft/vscode/commit/17e7a257ffc86a48318cefd8f3b904dc546a4314


Enhance login screen options

This PR closes/references issue #148 . It does so by using boostrap accordion in the auth.html
How has this been tested?

Checklist

[x] I have added tests to cover my changes.

Summary by Sourcery
This pull request enhances the login screen by integrating Bootstrap accordion, separating the login and registration forms into collapsible panels for a more organized and user-friendly interface.

Enhancements:

Enhanced the login screen by integrating Bootstrap accordion for better user experience.
Separated login and registration forms into collapsible panels for improved UI organization.

duplicated with https://github.com/fossasia/eventyay-talk/pull/159


Update jni to remove row conversion code

This removes the row conversion code as it has been moved into libcudf (https://github.com/rapidsai/cudf/pull/14664) to overcome a CCCL issue (https://github.com/NVIDIA/spark-rapids-jni/issues/1567).
We may need to move the code back from libcudf once the root cause of the issue is fixed.

Depends on https://github.com/rapidsai/cudf/pull/14664.

build

Will this work before the proclaim_return_type changes go in?

Oh yeah, this is a good question. The answer is NO. It seems that this PR and https://github.com/NVIDIA/spark-rapids-jni/pull/1662 needs to be combined.

build

Close as this is combined into https://github.com/NVIDIA/spark-rapids-jni/pull/1662.


Psadmin io box

switching box from dan's to psadmin.io in vagrant file

I went a little commit crazy, so I would squash this...

I have multiple windows fixes. Going to clean up commit history and package as one.


feat: node runtime version check

Checks the current version of node against a list of SemVer rangers
that are configured in @jsii/node-check, and emit a BIG FAT warning
to STDERR (with color if possible) in case the version is found to be
end-of-life, deprecated, or untested, so that users know that they are
subjecting themselves to random problems.
When marking a range as deprecated, a deadline is also provided in the
message, informing users about when the releases will move to the
end-of-life support level.

The check is performed at the entry point of all CLI utilities, including the
@jsii/runtime entry point.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Leaving pr/do-not-merge in case @MrArnoldPalmer wants to take another look.

Well I do need this to ship sooner rather than later, so I removed the label... That doesn't mean @MrArnoldPalmer doesn't get to have another look (but feedback will be addressed in a follow-up)


Need a way to specify full device path

There might be a case when device path doesn't start with /dev/input, for example, if one uses aliases

Not enough info, not steps to reproduce.