Cleaned up task2_getting_started

Do you mind making the following changes?
Top level:

Change "%cd MTNeuro/MTNeuro" to just "%cd MTNeuro" and the relevant imports to "MTNeuro.bossdbdataset" etc.
Clear the outputs on the pip install cell
Get rid of the random seeding
Do from tqdm.notebook import tqdm instead of from tqdm import tqdm

Dataset Description

Do you mind clarifying the train/test split a bit more (see (see https://github.com/MTNeuro/MTNeuro/blob/347a192cc872023f4a685561c73f64b78fadb306/notebooks/task1_getting_started.ipynb)
Can you update each [1] so that it links to the associated reference? (an example of how to do it should be in the above notebook if you download it)
Since we're cding a directory earlier set root to "./MTNeuro/"

Data Visualization

Remove the type and min/max values of the input/annotation. I don't think they're really necessary. You can keep the shape and possible classes (on a new line though)

Building the Model:

Cite UNet as [3] since you use [1] and [2] in the earlier sections
Align the indents for the UNet params (really minor detail)

Training the Model:

Align trainer indentation

Evaluating the Model:

Add a docstring for the predict function
Use torch.inference_mode instead of no_grad in predict
Align inline comment indentation
Either send the output to the device or explicitly to the cpu and remove the "can also do this on cpu" comment
Don't need no_grad in the prediction loop since the predict function already has it
In the "calculate..." comment say that we'll be using segmentation_models_pytorch to calculate the stats
Get rid of batch_iter and directly index test_dataloader (reference the revised task 1 notebook)

Visualizing Model Predictions:

Move the comments about using the same cmap and legends into the markdown cell right above the visualization code.
Put average F1 and IOU on new lines after the new scores

Mostly looks good- see a couple remaining changes still required from the list above- Accuracy eq should be tp + tn, not tp + fp, lr schedule can still be removed.

I pushed the changes I made to update the accuracy formula and to remove lr schedule; it was my fault that I didn't see Matthew's updated comments at the time of editing the notebook. I realized that many of my images on the notebook are hosted locally on branch notebook_cleanup. I think a good time to update the links to the images is when we merge notebook_cleanup with main, so I can use the image links on main. If I update the image links now, I'll need to immediately push the images to main. Is that better than updating the images later?

Got it- I will approve then go ahead and merge, then push the updated links directly to main? I think fine for this case!


Pulls/4/remove jsmin

Please remove the actual JSMinifier class too.

@chillu That makes sense, but minification lends itself nicely to a single injectable service. If we're just talking about "processing," it seems to me that the API needs to allow for multiple services to be injected.
SilverStripe\Core\Injector\Injector:
  SilverStripe\View\Requirements_Backend:
    properties:
      processors:
        - %$MinificationService
        - %$VariableReplacementService
        - ....

Or we could keep it simple and if the user wants multiple processors, you just chuck them all in one processor service, but that limits configurability.

Given we are removing and making a core function injectable, I don't think it's necessary to rename the service.

It seems weird that we creating new APIs for an approach we want to phase out. But I take your point about not over-optimizing this at the moment with creating a new processor API. How do you feel about marking this API as deprecated for 5.x?

It seems weird that we creating new APIs for an approach we want to phase out. But I take your point about not over-optimizing this at the moment with creating a new processor API. How do you feel about marking this API as deprecated for 5.x?

Great idea. @unclecheese can you action this?

Sure thing.


Error on Superslicer

I got an error when trying to slice with Superslicer

Thanks

You'll need to provide the logs from superslicer itself as there's nothing I can use in your screenshot unfortunately.

Sorry. Do you know where the logs are located?

Try changing the name of the file Gcode file you are exporting. I think there is an issue with overwriting file names. This fixed it for me.
I don't know if the is some way the script can be updated to allow overwriting file names.

It should work without any problem while overwriting existing files.
To move forward, what you can do is:

Disable it from superslicer
Export your gcode on your disk
run the script from command line: C:\PATH_TO_PYTHON.EXE C:\PATH_TO_FILE.gcode and report back if there are errors

It should work without any problem while overwriting existing files.
To move forward, what you can do is:

Disable it from superslicer
Export your gcode on your disk
run the script from command line: C:\PATH_TO_PYTHON.EXE C:\PATH_TO_FILE.gcode and report back if there are errors

I got this error:

Sorry, my bad... it should be C:\PATH_TO_PYTHON.EXE C:\PATH_TO_FastGyroidInfil.py C:\PATH_TO_FILE.gcode

Sorry, my bad, I forgot one piece... it should be C:\PATH_TO_PYTHON.EXE C:\PATH_TO_FastGyroidInfil.py C:\PATH_TO_FILE.gcode

This is the error I got

You downloaded an HTML file, you need to copy the python file content, not the HTML file.

You downloaded the cura file, please use this one: https://raw.githubusercontent.com/RomRider/klipper-FastGyroidInfill/main/superslicer/FastGyroidInfill.py

You downloaded the cura file, not he SuperSlicer one, please use this one: https://raw.githubusercontent.com/RomRider/klipper-FastGyroidInfill/main/superslicer/FastGyroidInfill.py

Done. Thank you.
You can close this issue.


ci: build docker images from PRs

Build Docker images from pull requests only if the docker configuration was changed.
Otherwise use image from the target branch.
closes #38

Creating images for PRs is probably not the best idea because an image gets saved for every PR in the image registry.  https://github.com/naturerobots/HSOS-SEP-PlantMap-2022/pkgs/container/hsos-sep-plant-map-2022

It only makes a new one if the docker config changed, which shouldn't happen too often.
And idk how else to test changes to the docker config without breaking CI for other PRs/commits.

But all the images are still in the registry and won't be deleted. Why even create images from PRs? They will never be used by anyone. PRs should trigger the worklow for the dev or main branch.

If the CI for the PR fails, you still got a working image.

Not if the docker build succeeds and the main job doesn't. Before the fix, #48 would have broken CI for all the other PRs that were going on.


fix cve-2022-29810 for 2.4 release

The related issue: https://github.com/stolostron/backlog/issues/22260
Signed-off-by: Yang Le<EMAIL_ADDRESS>

/lgtm


App Store stuck on "processing" when using fastlane deliver / works with xcode

New Issue Checklist

[x] Updated fastlane to the latest version
[x] I read the Contribution Guidelines
[x] I read docs.fastlane.tools
[x] I searched for existing GitHub issues

Issue Description
We've been successfully using fastlane to deliver our app to the app store. With 2.120.0 (or a recent version) this has stopped working properly. The process completes as usual, but when you go the app store connect the builds are stuck in "processing" (13 hours so far). Ifwe  archive and upload the app via Xcode, it more or less processes immediately, which leads us to believe this is a fastlane issue.
Command executed
bundle exec fastlane deliver --skip_screenshots
Complete output when running fastlane, including the stack trace and command used
Environment

+----------------------+------------------------+
| Detected Values from './fastlane/Deliverfile' |
+----------------------+------------------------+
| app_identifier       | *** |
| username             | ***      |
| force                | true                   |
| ipa                  | ./build/***.ipa    |
+----------------------+------------------------+
[09:48:33]: Login to App Store Connect (***)
[09:48:35]: Login successful
+--------------------------------------+------------------------+
|                    deliver 2.120.0 Summary                    |
+--------------------------------------+------------------------+
| skip_screenshots                     | true                   |
| screenshots_path                     | ./fastlane/screenshots |
| metadata_path                        | ./fastlane/metadata    |
| app_version                          | 10.10.0                |
| username                             | ***      |
| app_identifier                       | *** |
| ipa                                  | ./build/***    |
| platform                             | ios                    |
| edit_live                            | false                  |
| use_live_version                     | false                  |
| skip_binary_upload                   | false                  |
| skip_metadata                        | false                  |
| skip_app_version_update              | false                  |
| force                                | true                   |
| overwrite_screenshots                | false                  |
| submit_for_review                    | false                  |
| reject_if_possible                   | false                  |
| automatic_release                    | false                  |
| phased_release                       | false                  |
| reset_ratings                        | false                  |
| team_id                              | ***              |
| dev_portal_team_id                   | ***             |
| run_precheck_before_submit           | true                   |
| precheck_default_rule_level          | warn                   |
| individual_metadata_items            | []                     |
| ignore_language_directory_validation | false                  |
| precheck_include_in_app_purchases    | true                   |
+--------------------------------------+------------------------+
[09:48:36]: Making sure the latest version on App Store Connect matches '10.10.0' from the ipa file...
[09:48:41]: '10.10.0' is the latest version on App Store Connect
[09:48:42]: Loading './fastlane/metadata/de-DE/description.txt'...
[09:48:42]: Loading './fastlane/metadata/de-DE/keywords.txt'...
[09:48:42]: Loading './fastlane/metadata/de-DE/release_notes.txt'...
[09:48:42]: Loading './fastlane/metadata/de-DE/support_url.txt'...
[09:48:42]: Loading './fastlane/metadata/de-DE/marketing_url.txt'...
[09:48:42]: Loading './fastlane/metadata/de-DE/promotional_text.txt'...
[09:48:42]: Loading './fastlane/metadata/de-DE/name.txt'...
[09:48:42]: Loading './fastlane/metadata/de-DE/subtitle.txt'...
[09:48:42]: Loading './fastlane/metadata/de-DE/privacy_url.txt'...
[09:48:42]: Loading './fastlane/metadata/en-AU/description.txt'...
[09:48:42]: Loading './fastlane/metadata/en-AU/keywords.txt'...
[09:48:42]: Loading './fastlane/metadata/en-AU/release_notes.txt'...
[09:48:42]: Loading './fastlane/metadata/en-AU/support_url.txt'...
[09:48:42]: Loading './fastlane/metadata/en-AU/marketing_url.txt'...
[09:48:42]: Loading './fastlane/metadata/en-AU/promotional_text.txt'...
[09:48:42]: Loading './fastlane/metadata/en-AU/name.txt'...
[09:48:42]: Loading './fastlane/metadata/en-AU/subtitle.txt'...
[09:48:42]: Loading './fastlane/metadata/en-AU/privacy_url.txt'...
[09:48:42]: Loading './fastlane/metadata/en-GB/description.txt'...
[09:48:42]: Loading './fastlane/metadata/en-GB/keywords.txt'...
[09:48:42]: Loading './fastlane/metadata/en-GB/release_notes.txt'...
[09:48:42]: Loading './fastlane/metadata/en-GB/support_url.txt'...
[09:48:42]: Loading './fastlane/metadata/en-GB/marketing_url.txt'...
[09:48:42]: Loading './fastlane/metadata/en-GB/promotional_text.txt'...
[09:48:42]: Loading './fastlane/metadata/en-GB/name.txt'...
[09:48:42]: Loading './fastlane/metadata/en-GB/subtitle.txt'...
[09:48:42]: Loading './fastlane/metadata/en-GB/privacy_url.txt'...
[09:48:42]: Loading './fastlane/metadata/en-US/description.txt'...
[09:48:42]: Loading './fastlane/metadata/en-US/keywords.txt'...
[09:48:42]: Loading './fastlane/metadata/en-US/release_notes.txt'...
[09:48:42]: Loading './fastlane/metadata/en-US/support_url.txt'...
[09:48:42]: Loading './fastlane/metadata/en-US/marketing_url.txt'...
[09:48:42]: Loading './fastlane/metadata/en-US/promotional_text.txt'...
[09:48:42]: Loading './fastlane/metadata/en-US/name.txt'...
[09:48:42]: Loading './fastlane/metadata/en-US/subtitle.txt'...
[09:48:42]: Loading './fastlane/metadata/en-US/privacy_url.txt'...
[09:48:42]: Loading './fastlane/metadata/es-ES/description.txt'...
[09:48:42]: Loading './fastlane/metadata/es-ES/keywords.txt'...
[09:48:42]: Loading './fastlane/metadata/es-ES/release_notes.txt'...
[09:48:42]: Loading './fastlane/metadata/es-ES/support_url.txt'...
[09:48:42]: Loading './fastlane/metadata/es-ES/marketing_url.txt'...
[09:48:42]: Loading './fastlane/metadata/es-ES/promotional_text.txt'...
[09:48:42]: Loading './fastlane/metadata/es-ES/name.txt'...
[09:48:42]: Loading './fastlane/metadata/es-ES/subtitle.txt'...
[09:48:42]: Loading './fastlane/metadata/es-ES/privacy_url.txt'...
[09:48:42]: Loading './fastlane/metadata/es-MX/description.txt'...
[09:48:42]: Loading './fastlane/metadata/es-MX/keywords.txt'...
[09:48:42]: Loading './fastlane/metadata/es-MX/release_notes.txt'...
[09:48:42]: Loading './fastlane/metadata/es-MX/support_url.txt'...
[09:48:42]: Loading './fastlane/metadata/es-MX/marketing_url.txt'...
[09:48:42]: Loading './fastlane/metadata/es-MX/promotional_text.txt'...
[09:48:42]: Loading './fastlane/metadata/es-MX/name.txt'...
[09:48:42]: Loading './fastlane/metadata/es-MX/subtitle.txt'...
[09:48:42]: Loading './fastlane/metadata/es-MX/privacy_url.txt'...
[09:48:42]: Loading './fastlane/metadata/fr-FR/description.txt'...
[09:48:42]: Loading './fastlane/metadata/fr-FR/keywords.txt'...
[09:48:42]: Loading './fastlane/metadata/fr-FR/release_notes.txt'...
[09:48:42]: Loading './fastlane/metadata/fr-FR/support_url.txt'...
[09:48:42]: Loading './fastlane/metadata/fr-FR/marketing_url.txt'...
[09:48:42]: Loading './fastlane/metadata/fr-FR/promotional_text.txt'...
[09:48:42]: Loading './fastlane/metadata/fr-FR/name.txt'...
[09:48:42]: Loading './fastlane/metadata/fr-FR/subtitle.txt'...
[09:48:42]: Loading './fastlane/metadata/fr-FR/privacy_url.txt'...
[09:48:42]: Loading './fastlane/metadata/it/description.txt'...
[09:48:42]: Loading './fastlane/metadata/it/keywords.txt'...
[09:48:42]: Loading './fastlane/metadata/it/release_notes.txt'...
[09:48:42]: Loading './fastlane/metadata/it/support_url.txt'...
[09:48:42]: Loading './fastlane/metadata/it/marketing_url.txt'...
[09:48:42]: Loading './fastlane/metadata/it/promotional_text.txt'...
[09:48:42]: Loading './fastlane/metadata/it/name.txt'...
[09:48:42]: Loading './fastlane/metadata/it/subtitle.txt'...
[09:48:42]: Loading './fastlane/metadata/it/privacy_url.txt'...
[09:48:42]: Loading './fastlane/metadata/zh-Hans/description.txt'...
[09:48:42]: Loading './fastlane/metadata/zh-Hans/keywords.txt'...
[09:48:42]: Loading './fastlane/metadata/zh-Hans/release_notes.txt'...
[09:48:42]: Loading './fastlane/metadata/zh-Hans/support_url.txt'...
[09:48:42]: Loading './fastlane/metadata/zh-Hans/marketing_url.txt'...
[09:48:42]: Loading './fastlane/metadata/zh-Hans/promotional_text.txt'...
[09:48:42]: Loading './fastlane/metadata/zh-Hans/name.txt'...
[09:48:42]: Loading './fastlane/metadata/zh-Hans/subtitle.txt'...
[09:48:42]: Loading './fastlane/metadata/zh-Hans/privacy_url.txt'...
[09:48:42]: Loading './fastlane/metadata/zh-Hant/description.txt'...
[09:48:42]: Loading './fastlane/metadata/zh-Hant/keywords.txt'...
[09:48:42]: Loading './fastlane/metadata/zh-Hant/release_notes.txt'...
[09:48:42]: Loading './fastlane/metadata/zh-Hant/support_url.txt'...
[09:48:42]: Loading './fastlane/metadata/zh-Hant/marketing_url.txt'...
[09:48:42]: Loading './fastlane/metadata/zh-Hant/promotional_text.txt'...
[09:48:42]: Loading './fastlane/metadata/zh-Hant/name.txt'...
[09:48:42]: Loading './fastlane/metadata/zh-Hant/subtitle.txt'...
[09:48:42]: Loading './fastlane/metadata/zh-Hant/privacy_url.txt'...
[09:48:42]: Loading './fastlane/metadata/copyright.txt'...
[09:48:42]: Loading './fastlane/metadata/primary_category.txt'...
[09:48:42]: Loading './fastlane/metadata/secondary_category.txt'...
[09:48:42]: Loading './fastlane/metadata/primary_first_sub_category.txt'...
[09:48:42]: Loading './fastlane/metadata/primary_second_sub_category.txt'...
[09:48:42]: Loading './fastlane/metadata/secondary_first_sub_category.txt'...
[09:48:42]: Loading './fastlane/metadata/secondary_second_sub_category.txt'...
[09:48:42]: Loading './fastlane/metadata/trade_representative_contact_information/trade_name.txt'...
[09:48:42]: Loading './fastlane/metadata/trade_representative_contact_information/first_name.txt'...
[09:48:42]: Loading './fastlane/metadata/trade_representative_contact_information/last_name.txt'...
[09:48:42]: Loading './fastlane/metadata/trade_representative_contact_information/address_line1.txt'...
[09:48:42]: Loading './fastlane/metadata/trade_representative_contact_information/address_line2.txt'...
[09:48:42]: Loading './fastlane/metadata/trade_representative_contact_information/address_line3.txt'...
[09:48:42]: Loading './fastlane/metadata/trade_representative_contact_information/city_name.txt'...
[09:48:42]: Loading './fastlane/metadata/trade_representative_contact_information/state.txt'...
[09:48:42]: Loading './fastlane/metadata/trade_representative_contact_information/country.txt'...
[09:48:42]: Loading './fastlane/metadata/trade_representative_contact_information/postal_code.txt'...
[09:48:42]: Loading './fastlane/metadata/trade_representative_contact_information/phone_number.txt'...
[09:48:42]: Loading './fastlane/metadata/trade_representative_contact_information/email_address.txt'...
[09:48:42]: Loading './fastlane/metadata/trade_representative_contact_information/is_displayed_on_app_store.txt'...
[09:48:42]: Loading './fastlane/metadata/review_information/first_name.txt'...
[09:48:42]: Loading './fastlane/metadata/review_information/last_name.txt'...
[09:48:42]: Loading './fastlane/metadata/review_information/phone_number.txt'...
[09:48:42]: Loading './fastlane/metadata/review_information/email_address.txt'...
[09:48:42]: Loading './fastlane/metadata/review_information/demo_user.txt'...
[09:48:42]: Loading './fastlane/metadata/review_information/demo_password.txt'...
[09:48:42]: Loading './fastlane/metadata/review_information/notes.txt'...
[✔] Activating languages de-DE, en-AU, en-GB, en-US, es-ES, es-MX, fr-FR, it, zh-Hans, zh-Hant...
[✔] Uploading metadata to App Store Connect
[09:49:04]: Successfully uploaded set of metadata to App Store Connect
[09:49:08]: Uploading app icon...
[09:49:10]: Uploading apple watchapp icon...
[09:49:19]: Uploading binary to App Store Connect
[09:49:20]: Going to upload updated app to App Store Connect
[09:49:20]: This might take a few minutes. Please don't interrupt the script.
[10:00:08]: iTunes Transporter successfully finished its job
[10:00:08]: ------------------------------------------------------------------------------------------------------------------
[10:00:08]: --- Successfully uploaded package to App Store Connect. It might take a few minutes until it's visible online. ---
[10:00:08]: ------------------------------------------------------------------------------------------------------------------
[10:00:08]: Finished the upload to App Store Connect
[10:00:08]: Running precheck before submitting to review, if you'd like to disable this check you can set run_precheck_before_submit to false
[10:00:08]: Running precheck 👮♀ 👮
+--------------------------+------------------------+
|           Summary for precheck 2.120.0            |
+--------------------------+------------------------+
| default_rule_level       | warn                   |
| include_in_app_purchases | true                   |
| app_identifier           | *** |
| username                 | ***      |
| team_id                  | ***              |
+--------------------------+------------------------+
[10:00:08]: Checking app for precheck rule violations
[10:00:18]: Reading in-app purchases. If you have a lot, this might take a while
[10:00:18]: You can disable IAP checking by setting the include_in_app_purchases flag to false
[10:00:42]: Done reading in-app purchases
[10:00:43]: ✅  Passed: No negative  sentiment
[10:00:43]: ✅  Passed: No placeholder text
[10:00:43]: ✅  Passed: No mentioning  competitors
[10:00:43]: ✅  Passed: No future functionality promises
[10:00:43]: ✅  Passed: No words indicating test content
[10:00:44]: ✅  Passed: No curse words
[10:00:44]: 😵  Failed: No words indicating your IAP is free-> using text indicating that your IAP is free
[10:00:44]: 😵  Failed: Incorrect, or missing copyright date-> using a copyright date that is any different from this current year, or missing a date
[10:01:06]: ✅  Passed: No broken urls
+------------------------------------------------------------------------------------------------+----------------+
|                                               Potential problems                                                |
+------------------------------------------------------------------------------------------------+----------------+
| Field                                                                                | Failure reason |
+------------------------------------------------------------------------------------------------+----------------+
| in-app purchase desc: ***                                     |                |
| copyright                                                                                | missing: 2019  |
+------------------------------------------------------------------------------------------------+----------------+
[10:01:06]: precheck 👮♀ 👮  found one or more potential metadata problems, but this won't prevent fastlane from completing 👍

See the screenshot for our app store connect state.

This is a serious problem, maybe it's related to the latest Apple API changes?

Probably related to issue #14530?

In my case the terminal command completed without getting stuck for ages - but in app store connect the app remains in the processing state.

I have the check disabled, I bet if it worked someday. Apple process is never quick with Fastlane. It's totally broken.

@hactar I was able to get the app processed in 2 hours, could you please try to use it again? I think it was a backlog on iTunes Connect.

Is there a difference in how you build those apps or just how you uploaded them?

Is there any updates on this issue?

The last message before mine stated that this was just a temporary problem on Apple side: https://github.com/fastlane/fastlane/issues/14553#issuecomment-481803750 Do you have other information @moglistree - are you still experiencing the problem?

@janpio yes last time we have experienced is 2 days ago only parameter we pas in to deliver is team_id and the processing took quite a long time not sure on the specifics but upward of 10h. Asking for updates to know how to proceeded wait for and update or something else?

I wouldn't really know how to proceed here: We can't reproduce it on our side. Fastlane/deliver uses an official Apple tool to upload binaries, in a way that is fully supported by Apple.
Does this happen always in your account for all your apps?
One app or many apps?
Can you observe it with other accounts (e.g. personal) as well?


fix(watchman): Overhauls how Watchman crawler works fixing Windows

Summary
Watchman crawler was ignoring the relative_path field in the response of
a watch-project call, requiring it to match watch roots with the actual
project roots afterward. Not only this was inefficient, it was also faulty
due to the naive .startsWith() check in isDescendant(). This was causing
issues both with Windows file paths (#5553) and after that with case-insensitive
file systems where the names from Watchman did not match the casing of the passed
roots.
This patch replaces all that logic by taking the relative_path field into account
and does some consolidation along with using async/await instead of promises.
Test plan
Run the updated test suite on all platforms and make sure it passes. I've also
verified this on some internal Windows repos by manually patching the built module
and making sure there are no warnings regarding duplicated haste names due to incorrect
crawling of project root siblings.

Codecov Report

Merging #5615 into master will increase coverage by 0.02%.
The diff coverage is 88.33%.

@@            Coverage Diff             @@
##           master    #5615      +/-   ##
==========================================
+ Coverage   60.63%   60.65%   +0.02%
==========================================
  Files         213      213
  Lines        7311     7318       +7
  Branches        3        3
==========================================
+ Hits         4433     4439       +6
- Misses       2877     2878       +1
  Partials        1        1

Impacted Files
Coverage Δ

packages/jest-haste-map/src/crawlers/watchman.js
88.7% <88.33%> (-0.39%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f5879c0...6894a32. Read the comment docs.

Will make things parallel again, thanks for the review!


Review pyenvs.sh

@frankenjoe to make it easier to use Python 3.8 I moved pyenvs.sh out of https://github.com/hagenw/simply-bash to it's own repo at https://github.com/audeering/pyenvs.sh. Could you maybe test it briefly and have a look at the documentation, thanks.

This is now used since a few month and works.


[$500] LHN last message is not updating after deleting attachment

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Open any report
Send any attachment
Observe the sub-title in LHN
Click on attachment in tab 1 see it opens in modal
Open same report in other tab (tab2) and delete the attachement.
Observe that after delete modal get's closed but not LHN updating.

Expected Result:
LHN should update as well with next previous message
Actual Result:
Not updating
Workaround:
Can the user still use Expensify without this being fixed? Have you informed them of the workaround?
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android / native
[ ] Android / Chrome
[ ] iOS / native
[ ] iOS / Safari
[x] MacOS / Chrome / Safari
[ ] MacOS / Desktop

Version Number: 1.3.62-1
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
https://github.com/Expensify/App/assets/43996225/c8777fbe-de78-4ac9-b775-17af278089d4
https://github.com/Expensify/App/assets/43996225/5f65e207-3a6b-4e5c-97ad-36ce4c1f4eac
Expensify/Expensify Issue URL:
Issue reported by: @b4s36t4
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1692975870405119
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~017f650b305c679ab3
Upwork Job ID:<PHONE_NUMBER>240963584
Last Price Increase: 2023-09-03

Proposal
Please re-state the problem that we are trying to solve in this issue.
LHN last message is not updating after deleting attachment
What is the root cause of that problem?
The function getLastMessageTextForReport as shown here is used to decide on the text used in LHN. Now, within getLastMessageTextForReport, we use isReportMessageAttachment here to find out if the lastMessageTextFromReport is an attachment. Since lastMessageText and lastMessageHtml is sufficient to decide on whether it is attachment or not based on code here, we can depend on them for making this decision. However, the decision is also based on lastMessageTranslationKey which does not seem proper here. Using lastMessageTranslationKey to decide on the lastMessageTextFromReport seems to be the reason for this problem.
What changes do you think we should make in order to solve the problem?
We can avoid using lastMessageTranslationKey as follows here
  if (ReportUtils.isReportMessageAttachment({text: report.lastMessageText, html: report.lastMessageHtml})) {
The above condition is safe as lastMessageTranslationKey itself is determined based on lastMessageText and lastMessageHtml as shown here in getLastVisibleMessage function.
Further, I am not sure if there is a need to set lastMessageHtml here as part of implementation of PR here.
I have asked a query there.
What alternative solutions did you explore? (Optional)

The pusher doesn't return lastMesageTranslationKey

I think we should fix this from BE side

@jjcoffee can you review the proposals above?

This seems like a pretty edgy edge case to me! It requires being signed in as the same user in two tabs, which in itself is a pretty unlikely use case - but then adding on top of that trying to switch between tabs and make actions on one and see the changes on another is just not something I think a normal user would do. I recommend closing unless there's a deeper issue. cc @adelekennedy
Additionally, the RCAs proposed so far don't seem to be correct as the behaviour doesn't happen when logged in to a separate account, but lastMesageTranslationKey is also not returned in the pusher event in that case:

the RCAs proposed so far don't seem to be correct as the behaviour doesn't happen when logged in to a separate account

That's interesting! Will check why?

Let's close this! I love eliminating edge cases


refactor: validation returns eithers

This PR is a start to a refactor of the validators approach.
As I mentioned somewhere, the idea is to have 3 PRs that will do the job
Here's what I did:

The validator generic signature now does not return a IPrismDiagnostic[], but rather an Either<NonEmptyArray<IPrismDiagnostic>, T> — which means either a validated T or an array of validation errors. https://github.com/stoplightio/prism/pull/731/files#diff-2991521f751aa9cf68976ceef512e19a
I have created a sequence for an Either with the applicative method modified to concat the errors, as the article we were reading about was suggesting: https://github.com/stoplightio/prism/pull/731/files#diff-d6f4104cbf0cdb51855c413bc0079241R43-R44
All the validators have been modified to return the Either — https://github.com/stoplightio/prism/pull/731/files#diff-ec5f393de032d67a4f08a12ecde5456cR54, and then all sequenced together to get the final request/response validation https://github.com/stoplightio/prism/pull/731/files#diff-52fafd78c752aca126e4fd8c4ce567a6R98-R103
All the improvements then finally converge in the factory.ts file where you can see that finally validation and mocking are two different TaskEither steps melted together with chain calls.

What is not ok yet?

[ ] There are different Either.swap that are just weird; identify why these are required and if there are opportunities to get rid of these
[ ] The way the output validations are extracted makes my eyes bleed. Find another way

@XVincentX, shouldn't the refactor address validators vs serializers in the first place? Is this something that will be addressed in the next PRs?

shouldn't the refactor address validators vs serializers in the first place? Is this something that will be addressed in the next PRs?

This will be a follow up PR. This is just the beginning of breaking it down so that we can easily at least compose the steps (route, validate input, mock, validate output, send response) that is required for Hosted Prism. We'll iterate and move on as we go.


Ability to add a product that doesn't have a barcode

It's actually possible on the web version to add a product without a barcode. We should investigate how to do that on mobile.
poke @stephanegigandet

Server bug: https://github.com/openfoodfacts/openfoodfacts-server/issues/443


cesium 1.66 - 1.68  label fuzzy

i found cesium 1.65 - 1.68  label fuzzy 。plz update
example

and 3dtiles also have this bug

Cesium's default behavior changed in 1.66. From the 1.66 change log:

useBrowserRecommendedResolution flag in Viewer and CesiumWidget now defaults to true. This ensures Cesium rendering is fast and smooth by default across all devices. Set it to false to always render at native device resolution instead at the cost of performance on under-powered devices. #8548

To get the previous behavior back set
viewer.useBrowserRecommendedResolution = false


File Transfer to /mnt uses up all RAM and crashes PC

Environment
Windows build number: 21277.rs
Your Distribution version: [On Debian or Ubuntu run Ubuntu 18.04
Whether the issue is on WSL 2 and/or WSL 1: WSL2

Steps to reproduce
File Transfer (in particular large transfers, 1TB) through CLI or Windows explorer, continuously increases RAM usage until all of it (beyond the limit set in .wslconfig) is used up than it crashes PC -->
No Logs available
Expected behavior
Due to large data created in Ubuntu environment, occasionally transfer to other hard drives for back up, during transfer all expected not to use all RAM or crash
Actual behavior
PC crashes with it occasionally corrupting the wsl2 .ext4 drive

I wasn't able to repro this problem. In both cases when I moved a large file the Vmmem process stopped growing when it reached the size limit specified in the .wslconfig file, and I saw no crashes.
@MustafaElshani could you please check the total memory available to your distro by running free -h? Is the Vmmem process growing larger than what is shown in that output? If it is, could you please attach logs of you doing a large transfer using the instructions here.
I'm going to close this issue out for bookkeeping purposes, but please reopen it with the logs attached if you're still seeing this. Thanks!

I wasn't able to repro this problem. In both cases when I moved a large file the Vmmem process stopped growing when it reached the size limit specified in the .wslconfig file, and I saw no crashes.
@MustafaElshani could you please check the total memory available to your distro by running free -h? Is the Vmmem process growing larger than what is shown in that output? If it is, could you please attach logs of you doing a large transfer using the instructions here.
I'm going to close this issue out for bookkeeping purposes, but please reopen it with the logs attached if you're still seeing this. Thanks!

Hi @craigloewen-msft Thank you prompt reply. I have assigned 196GB of the 256GB available

total        used        free      shared  buff/cache   available
Mem:           192G        347M        192G         68K         74M        191G
Swap:           49G          0B         49G
for df

Filesystem       1K-blocks        Used  Available Use% Mounted on
/dev/sdb<PHONE_NUMBER><PHONE_NUMBER>  126271588  95% /

The transfer involves thousand of files totaling 1TB+, the Vmmem process keeps going up up until it crashes I have submitted logs via feedback.
Currently transferring chunks less than the capacity of the RAM available which seems to work
Kindest of Regards

Hi @craigloewen-msft Thank you prompt reply. I have assigned 196GB of the 256GB available

total        used        free      shared  buff/cache   available
Mem:           192G        347M        192G         68K         74M        191G
Swap:           49G          0B         49G
for df

Filesystem       1K-blocks        Used  Available Use% Mounted on
/dev/sdb<PHONE_NUMBER><PHONE_NUMBER>  126271588  95% /

The transfer involves thousand of files totaling 1TB+, the Vmmem process keeps going up up until it crashes I have submitted logs via feedback.
Currently transferring chunks less than the capacity of the RAM available which seems to work
Kindest of Regards

@MustafaElshani glad that you were able to submit logs for this! Could you please post the link to the Feedback Hub item here in this thread so we're more easily able to find it? Thank you. I'll also reopen this issue since you have logs submitted for it :)

@MustafaElshani glad that you were able to submit logs for this! Could you please post the link to the Feedback Hub item here in this thread so we're more easily able to find it? Thank you. I'll also reopen this issue since you have logs submitted for it :)

Hi @craigloewen-msft again thank you for looking into this, the feedback logs are on https://aka.ms/AAarl5d
After further testing what seems to be causing the crash is the use of mv I think henceforth  I tested the transfer with cp this was slower however after reaching maximum assigned RAM it stayed there until the end of copying, without crashing the PC.
I guess this will have to do with the way mv vs cp handles the memory between filesystems
Hope this helps
Mustafa

Hi @craigloewen-msft again thank you for looking into this, the feedback logs are on https://aka.ms/AAarl5d
After further testing what seems to be causing the crash is the use of mv I think henceforth  I tested the transfer with cp this was slower however after reaching maximum assigned RAM it stayed there until the end of copying, without crashing the PC.
I guess this will have to do with the way mv vs cp handles the memory between filesystems
Hope this helps
Mustafa

UPDATE
Hi @craigloewen-msft it seems that the removal of the files is causing the crash, I just attempted torm -rfthe folder copied earlier and it instantly crashed.
This workstation is being accessed remotely will generate logs when I initiate the rm

UPDATE
Hi @craigloewen-msft it seems that the removal of the files is causing the crash, I just attempted torm -rfthe folder copied earlier and it instantly crashed.
This workstation is being accessed remotely will generate logs when I initiate the rm


[Subtask] Web UI add disable/enable metalake/catalog button

Describe the subtask
Since we add disable/enable metalake/catalog API in server, we should also add the button to Web UI
Parent issue
#5031

using rest api for metalake example:
PATCH http://localhost:8090/api/metalakes/test_metalake
Accept: application/vnd.gravitino.v1+json
Content-Type: application/json

{
  "inUse": true
}

and for catalog, Just need to change the path to /api/metalakes/test_metalake/catalogs/test_catalog


build: attempt to install the import libraries

Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.

Resolves SR-NNNN.

@swift-ci please test

@swift-ci please test and merge


reject and filter should work with Objects as well

So useful
I really enjoy ramda version of reject and filter and how they work on Objects as well. Should be easy to add that. So let us do that.

Submitted PR#118 to address this issue

Merged PR#118.
Closing this out.


CassandraSinkCluster index removal

https://github.com/shotover/shotover-proxy/pull/1476 ported CassandraSinkCluster to use MessageId.
Well almost, it missed one case, which is the handling of use statements.
This PR fixes that.
I spent a bunch of time thinking about how to handle processing them with MessageId's instead of indexes.
Its definitely possible but it also adds a bunch of extra complexity and I'm not sure if its worth it in the first place.
So @cjrolo I'm interested in your thoughts on how often cassandra clients make use of useing a namespace.
With this PR every time the client uses a use namespace statement shotover will close all outgoing connections in use by the transform instance (1 connection per cassandra node in the cluster).
Those connections will then be reopened as shotover routes requests to those nodes. (i.e. there will be delays due to connections being opened in the future)
So if clients regularly change the used namespace then I'd better not go ahead with the approach in this PR.

It will depend by use case. I wasn't using USE namespace at all, and I don't remember it being used often at all.
I can ask around in clusters with a lot of keyspaces how the driver looks like. Are they having a specific driver for each keyspace? Is the keyspace set as keyspace.table? They prepare a statement bound to the keyspace (How does it translate in different drivers to the query level, I don't know), or they use the USE keyword?
I will try to gather further information for you.

I do like the current approach, and I think USE is a niche thing on the domain of CQL connections via CQLSH. But I'll still do my research and get back to you.

Thanks!
I'll go ahead and land this assuming @conorbros is happy with this approach.
I've raised https://github.com/shotover/shotover-proxy/issues/1559 to track the re-adding of keeping the connections open.
@cjrolo if you find anything interesting post it on the issue.


stdio support broken on Windows?

I have the following code that executes my language server and uses stdio as TransportKind:
https://github.com/itmuckel/factor-lsp/blob/master/lsp-sample/client/src/extension.ts
        let serverOptions: ServerOptions = {
		command: "C:/factor/factor-lsp/factor-lsp.exe",
		transport: TransportKind.stdio,
	};

	// Options to control the language client
	let clientOptions: LanguageClientOptions = {
		// Register the server for plain text documents
		documentSelector: [{ scheme: 'file', language: 'Factor' }],
		synchronize: {
			// Notify the server about file changes to '.clientrc files contained in the workspace
			fileEvents: workspace.createFileSystemWatcher('**/.clientrc')
		}
	};

	// Create the language client and start the client.
	client = new LanguageClient(
		'languageServerExample',
		'Language Server Example',
		serverOptions,
		clientOptions
	);

	// Start the client. This will also launch the server
	client.start();

This works on Linux (Ubuntu). My LS gets the "initialize" and "shutdown" requests, but no responses come back from it.
On Windows my LS won't even get the requests from the Client.
Anyone else experienced this and/or have some ideas how to fix this? 🤔

I just tested this under Windows with my test bed in this repository and it worked without any problems. What makes stdio very flaky is that fact that the server can't log anything to stdio. Otherwise the communication will fail.

Does the LSP sample work for you under Windows using stdio. https://github.com/microsoft/vscode-extension-samples/tree/master/lsp-sample

Yes, that seems to work.
The problem is that when I output some debug information to a file, I see that my server has trouble reading the content-length.
It just reads a line, strips it from "Content-Length: ", trims and parses the number, but at this point it already fails. The weird thing is that on linux it worked without problems.
It is especially no node server, just a plain executable that will be started. Maybe that changes things? Surely this lib does different stuff, when running a node server than executing a child process.
To rule out that the programming language I use messes it up, I wrote a C# console app like this:
using System;

namespace ConsoleApp1
{
    class Program
    {
        static void Main(string[] args)
        {
            using (System.IO.StreamWriter file =
                new System.IO.StreamWriter(@"C:\Users\Admin\Documents\lsp.txt", true))
            {
                while (true)
                {
                    file.WriteLine(Console.ReadLine());
                }
            }
        }
    }
}

The file is created, but remains empty. On Linux the same experiment showed me the requests that the client would send to my server. Does this work on your system?

This code works. I still don't know why I need to do this in order to read the input from the client.
using System;
using System.IO;

namespace ConsoleApp1
{
    class Program
    {
        static void Main(string[] args)
        {
            var read = new BinaryReader(Console.OpenStandardInput());

            using var file =
                new System.IO.StreamWriter(@"C:\Users\Admin\Documents\lsp.txt", true);
            while (true)
            {
                file.WriteLine(read.ReadChar());
            }
        }
    }
}

@itmuckel is there anything you need from my end. I am not a C/C++ expert.

I am also running into issues with stdio on Windows. I am developing language server and it runs fine on Mac and Linux. However on Windows, there are all sorts of trouble. It is very strange because my language server runs fine on Windows under Sublime. But it does not work with VSCode.
The problem manifests itself as a hang. The initial traffic from VSCode to the server is in the Output window, and that is all that happens. It seems that the server is waiting on input.
I am trying to dig down and investigate how VSCode launches child processes and sets up stdin, stdout, and stderr on Windows. It seems like there is some difference between Sublime and VSCode that is significant. I'm afraid I don't know much about Windows processes, inheriting handles, console vs. GUI apps, etc.

@bostick please let me know what you find out.

I have an update of sorts...
I'm trying to create a language server for Wolfram Engine. On Windows, there is both a WolframKernel.exe GUI app and a wolfram.exe console app.
Intuitively I was using the console app and it was not working (as described above). The crazy thing is that using GUI app does work!
I am able to have a working language server on Windows by using the GUI app version but not the console app. I do not quite understand why this is the case and I wish debugging this sort of thing was easier.
So that's all good news, though inexplicable.

@bostick to our knowledge this is something specific to Windows. Somehow when you link a Windows executable you can decide how it will deal with stdio. We saw other cases were a parent process couldn't read from stdio from client processes.

@dbaeumer Can you expand on this? How can you decide how it will deal with stdio? This might be exactly the problem bostick and I are facing.

The one the generates the executable (e.g. links it if it is a C++ application) seems to have an influence on it. But I am not an expert with C++ under Windows so I don't exactly know how this works.

This issue may be related to this phenomenon.
I wrote a C program.
#include <stdio.h>
int main() {
   printf("test\n");
   return 0;
}

And I wrote a nodejs program to call this C program.
var cp = require('child_process');
var child = cp.spawn("a.exe");
child.stdout.on('data', function (data) {
    console.log(data);
});

when i get stdout output, \n characters will be replaced with \r\n
(0d 0a) means \r\n

PS D:\Code> node index.js
<Buffer 74 65 73 74 0d 0a>

The same problem occurs in vscode extension.


Update user.css

Closes #
📑 Description

✅ Checks

[ ] My pull request adheres to the code style of this project
[ ] My code requires changes to the documentation
[ ] I have updated the documentation as required
[ ] All the tests have passed

☢ Does this introduce a breaking change?

[ ] Yes
[ ] No

ℹ Additional Information

Summary by CodeRabbit

Style

Removed padding from the .container class, affecting the spacing within the container element.

@gstraccini review


[HELP] How to remove a user profile section

hello good morning I am trying to remove the following section from the user profile section and I cannot find the code that refers to this section inside the resources/view/profile/show.blade.php file

Am I modifying the correct file?

Item
Version

Laravel
9

Project
3

OS
macOS

Hi @marquezmiguel I'm not sure what you have done, since this package does not come with a profile view out-of-the-box. Probably, you have installed one of the Laravel's authentication scaffolding (like, ui, breeze or jetstream)...

that's right, I installed laravel jetstream and I want to remove that section I have marked in the image, but I can't find the file that section refers to.
this is the file show.blade.php
@extends('adminlte::page')
@section('title', 'Dashboard')
@section('content_header')
Dashboard
@stop
@section('content')

            @if (Laravel\Fortify\Features::canUpdateProfileInformation())
                @livewire('profile.update-profile-information-form')
            <x-jet-section-border />
        @endif

        @if (Laravel\Fortify\Features::enabled(Laravel\Fortify\Features::updatePasswords()))

                @livewire('profile.update-password-form')

            <x-jet-section-border />
        @endif

        @if (Laravel\Fortify\Features::canManageTwoFactorAuthentication())

                @livewire('profile.two-factor-authentication-form')

            <x-jet-section-border />
        @endif

            @livewire('profile.logout-other-browser-sessions-form')

        @if (Laravel\Jetstream\Jetstream::hasAccountDeletionFeatures())
            <x-jet-section-border />

                @livewire('profile.delete-user-form')

        @endif

@stop
@section('css')

@stop
@section('js')

@stop

But, that's part of Jetstream package, the view looks similar at the one they shown on the documentation (but in this case embedded in the AdminLTE layout), see here. Probably you need to make changes on the jetstream package or check if you can publish its resources to make customizations...

But, that's part of Jetstream package, the view looks similar at the one they shown on the documentation (but in this case embedded in the AdminLTE layout), see here. Probably you need to make changes on the jetstream package or check if you can publish its resources to make customizations, maybe as explained here.
UPDATE: Looking at the jetstream code in Github, I think that section is the navigation-menu included as a part of the app-layout that is using the profile view...

apparently it is this file, I am trying to delete that section but when I do it, the display is very broken, maybe I am deleting something wrong, my God.

Nice, good to see you have solved it. However, take a read to next issue: https://github.com/jeroennoten/Laravel-AdminLTE/issues/1001, it is discussed somehow the integration of this package with jetstream.

Nice, good to see you have solved it. However, take a read to next issue: #1001, it is discussed somehow the integration of this package with jetstream. It may be helpful to you...

this works correctly in my project, thanks for bothering to look for that article. by the way I enabled the 'usermenu_image' function of adminlte and I have a peculiar problem, in the home page the image and the name are displayed correctly but when I access to another directory the image is broken.

You may try replacing any of these blade files with issues, with the next code:
@extends('adminlte::page')

@section('title', 'Dashboard')

@section('content_header')

Dashboard

@stop

@section('content')

Welcome to this beautiful admin panel.

@stop

If after that, the issue disappear, then it may be related to some of the styles that are applied by the blade view, you will have to investigate which one...

it seems that the one causing the problems is
 <x-guest-layout>
 </x-guest-layout>

that brings the laravel files.

It may be because you are trying to embed one layout (from the jetstream package) into the layout provided by this package. Have you tried to use only the inner code of the x-guess-layout inside this template? For example, if your blade view is like:
<x-guest-layout>
  {{-- INNER JETSTREAM CODE --}}
</x-guest-layout>

Then replace it by something like:
@extends('adminlte::page')

@section('title', 'The title')

@section('content_header')

The Content Header (if needed)

@stop

@section('content')
  {{-- INNER JETSTREAM CODE --}}
@stop

if i remove  the layout is completely broken
for example this is the code with
included inside the adminlte template
@extends('adminlte::page')

@section('title', 'Dashboard')

@section('content_header')

Register New User

@stop

@section('content')
 <x-guest-layout>
    <x-jet-authentication-card>
        <x-slot name="logo">
        </x-slot>

        <x-jet-validation-errors class="mb-4" />

        <form method="POST" action="{{ route('register') }}">
            @csrf

                <x-jet-label for="name" value="{{ __('Name') }}" />
                <x-jet-input id="name" class="block mt-1 w-full" type="text" name="name" :value="old('name')" required autofocus autocomplete="name" />

                <x-jet-label for="email" value="{{ __('Email') }}" />
                <x-jet-input id="email" class="block mt-1 w-full" type="email" name="email" :value="old('email')" required />

                <x-jet-label for="password" value="{{ __('Password') }}" />
                <x-jet-input id="password" class="block mt-1 w-full" type="password" name="password" required autocomplete="new-password" />

                <x-jet-label for="password_confirmation" value="{{ __('Confirm Password') }}" />
                <x-jet-input id="password_confirmation" class="block mt-1 w-full" type="password" name="password_confirmation" required autocomplete="new-password" />

            @if (Laravel\Jetstream\Jetstream::hasTermsAndPrivacyPolicyFeature())

                    <x-jet-label for="terms">

                            <x-jet-checkbox name="terms" id="terms" required />

                                {!! __('I agree to the :terms_of_service and :privacy_policy', [
                                        'terms_of_service' => ''.__('Terms of Service').'',
                                        'privacy_policy' => ''.__('Privacy Policy').'',
                                ]) !!}

                    </x-jet-label>

            @endif

                <x-jet-button class="ml-4">
                    {{ __('Register') }}
                </x-jet-button>

        </form>
    </x-jet-authentication-card>
</x-guest-layout>
@stop

@section('css')
    <link rel="stylesheet" href="/css/admin_custom.css">
@stop

@section('js')

@stop

and this is the result

and this is the code without
included inside the adminlte template
@extends('adminlte::page')

@section('title', 'Dashboard')

@section('content_header')

Register New User

@stop

@section('content')
    <x-jet-authentication-card>
        <x-slot name="logo">
        </x-slot>

        <x-jet-validation-errors class="mb-4" />

        <form method="POST" action="{{ route('register') }}">
            @csrf

                <x-jet-label for="name" value="{{ __('Name') }}" />
                <x-jet-input id="name" class="block mt-1 w-full" type="text" name="name" :value="old('name')" required autofocus autocomplete="name" />

                <x-jet-label for="email" value="{{ __('Email') }}" />
                <x-jet-input id="email" class="block mt-1 w-full" type="email" name="email" :value="old('email')" required />

                <x-jet-label for="password" value="{{ __('Password') }}" />
                <x-jet-input id="password" class="block mt-1 w-full" type="password" name="password" required autocomplete="new-password" />

                <x-jet-label for="password_confirmation" value="{{ __('Confirm Password') }}" />
                <x-jet-input id="password_confirmation" class="block mt-1 w-full" type="password" name="password_confirmation" required autocomplete="new-password" />

            @if (Laravel\Jetstream\Jetstream::hasTermsAndPrivacyPolicyFeature())

                    <x-jet-label for="terms">

                            <x-jet-checkbox name="terms" id="terms" required />

                                {!! __('I agree to the :terms_of_service and :privacy_policy', [
                                        'terms_of_service' => ''.__('Terms of Service').'',
                                        'privacy_policy' => ''.__('Privacy Policy').'',
                                ]) !!}

                    </x-jet-label>

            @endif

                <x-jet-button class="ml-4">
                    {{ __('Register') }}
                </x-jet-button>

        </form>
    </x-jet-authentication-card>
@stop

@section('css')
    <link rel="stylesheet" href="/css/admin_custom.css">
@stop

@section('js')

@stop

and this is the result

this problem should I report it as a bug?
No, it is not a problem on this package, is part of the integration with other package...

this problem should I report it as a bug?

No, it is not a problem on this package, is part of the integration with other package...

have you seen my code? i'm doing it right, right? that's the right way? i want to make sure i'm doing things right.

@marquezmiguel I'm not sure, I haven't integrated jetstream with this package before... So, I'm not sure what is the nice way to follow. However, the next piece of code is not needed (it is just an example of how to include extra css and js):
@section('css')
    <link rel="stylesheet" href="/css/admin_custom.css">
@stop

@section('js')

@stop

If the only issue you are facing is with the upper right logo image, then use your browser's inspector to check what style is added to it when you are mixing the layout, probably both layout uses the same class for the logo image and are adding styles to it...

@marquezmiguel I'm not sure, I haven't integrated jetstream with this package before... So, I'm not sure what is the nice way to follow. However, the next piece of code is not needed (it is just an example of how to include extra css and js):
@section('css')
    <link rel="stylesheet" href="/css/admin_custom.css">
@stop

@section('js')

@stop

If the only issue you are facing is with the upper right logo image, then use your browser's inspector to check what style is added to it when you are mixing the layout, probably both layout uses the same class for the logo image and are adding styles to it...
UPDATE: I'm also noting that Jetstream uses Tailwind CSS while this package (and AdminLTE) is based on Bootstrap4, I do not believe you can mix both things, since both Tailwind CSS and Bootstrap4 contains definition for the class mt-1, for example. One way to follow, may be to change all the views of the Jetstream package to use Bootstrap4 and remove Tailwind CSS, but I'm not sure how hard will that be...

possibly a conflict is occurring between the two technologies, I will see how to proceed, thank you for your help.

OK, if you manage to found a solution for the integration of both technologies, you may share a brief summary here. It may be helpful to other people...


Release Google.Cloud.PubSub.V1 version 2.8.0

Changes in this release:
Bug fixes

Increased grpc.max_metadata_size value to 4 M.B. This fixes an issue in SubscriberClient with exactly-once delivery. (commit e78afdf)

New features

Add IAM mixin to Google.Cloud.PubSub.V1 (commit fda5e80)
Add exactly once delivery flag (commit fa0b21c and commit e7b592b)

This is only for the generated code; SubscriberClient has no support yet

Looks like we need to add @Rishabh-V into Codeowners. Will override and merge.

Created release for Google.Cloud.PubSub.V1-2.8.0


Updated wallet.py to disable staking on self.nodes restart

This should make the test fail less

@chasingkirkjufell I've updated the commit
This is basically to fix this random failure
wallet.py:
Initializing test directory /tmp/testogbnw7hr/57
Mining blocks...
Assertion failed:<PHONE_NUMBER>0 != 59800053.99933800
Stopping nodes
Not cleaning up dir /tmp/testogbnw7hr/57
Failed
stderr:
   File "/home/travis/build/navcoin/navcoin-core/qa/rpc-tests/test_framework/test_framework.py", line 149, in main
    self.run_test()
  File "/home/travis/build/navcoin/navcoin-core/build/../qa/rpc-tests/wallet.py", line 220, in run_test
    assert_equal(self.nodes[2].getbalance(), node_2_bal) #should not be changed because tx was not broadcasted
  File "/home/travis/build/navcoin/navcoin-core/qa/rpc-tests/test_framework/util.py", line 508, in assert_equal
    raise AssertionError("%s != %s"%(str(thing1),str(thing2)))
Pass: False, Duration: 34 s

A new build of 9601229d6816be20c4b9f117fa3f23d5ef7e3a8a has completed succesfully!
Binaries available at https://build.nav.community/binaries/update-walletpy-test

A new build of 6acbcd688247b517fb481cfd697398f0df030a4e has completed succesfully!
Binaries available at https://build.nav.community/binaries/update-walletpy-test


Adding code sample to switch

fixing #157

I hope I did that correctly. Did a git revert 367eea8 and a git push afterwards. Not the biggest git user.


New config field unit

@samgregory even though the new config field unit was part of today’s release, I think we should reconsider where it can be configured. minMaxValLims doesn’t really sound like the right place. The cleanest solution, in my opinion, would be to rename minMaxValLims to yAxis or something similar. But that would be a breaking change. I have no idea how many people have actually used the minVal and maxVal fields. Since they were kind of broken, maybe it’s safe to say there are not a lot of users.
I’m inclined to make this breaking change. What do you think @samgregory?
(Edit: I realized this when I added the unit field to the manual https://github.com/IPS-LMU/The-EMU-SDMS-Manual/blob/master/app_chap-fileFormats.Rmd)

Also, I noticed there is no space between the number and the unit. But that’s the same for the spectrogram.

Hi @MJochim, I'd support a breaking change in this case. I think we can mitigate the issue of users having EMUwebAppConfig files that won't validate by improving the error message on a failed validating (links to the manual, explicit reporting of the offending key(s)?).
I also agree that there should be a space between number and unit - I just followed what was done in the spectrogram.


feat: set admin hostname on web container as alternative dns

Pretty sure the same also needs to happen for customization... Or in general any service that calls another one directly using its Hostname

-redis shouldn't be an alias

crap, that was a copy paste issue 😢

:tada: This PR is included in version 6.2.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Using libhiredis.010 on ubuntu server 12-04 LTS - SEGSEV signal received when not connected or lost connection

HI all, I found this problem with hiredis.
If i am not connected or redis server is down, I receive a SEGSEV executing any command ( no exceptions, directly a signal )
example :
redisReply* reply = 0;
redisContext* context = NULL;
reply = (redisReply*) redisCommand(_context, "SELECT %d", (int)Node );
SEGSEV and not a exception.
this is a obvious example, but if I'm connected to a redis server and lost the connection, finally a Get the same result.
Should be nice to get an exception or a error code or just a null replay, but never a SEGSEV.
Thank you a lot

You're passing a null pointer to redisCommand. Don't do that.
All command functions expect a non-null pointer (a valid connection context).
If another example still segfaults, please provide this. Keep in mind that libhredis.010 sounds like a really old version. Please upgrade to the latest release of hiredis first.
Until then I close this pull request.


fix(subscribe): ignore syncError when deprecated

Description:
This PR adds a failing test and fixes the problem with the implementation of subscribe that sees the catchError operator bypassed in some circumstances.
This will fix the behaviour when useDeprecatedSynchronousErrorHandling is false - i.e. the default version 6 behaviour.
Elsewhere, the syncErrorThrowable flag has no meaning unless useDeprecatedSynchronousErrorHandling is true.
So, when useDeprecatedSynchronousErrorHandling is false, it makes no sense to consider syncErrorThrowable when deciding between a call to _subscribe or _trySubscribe.
Whether or not - as discussed in the related issue - a getter should be added to InnerSubscriber to attempt to fix the deprecated behaviour is another (more complicated) matter. And one that need not be relevant to this PR. As noted in this comment, even with the getter added, the deprecated behaviour is still broken.
Related issue (if exists): #3740

Coverage decreased (-0.2%) to 96.654% when pulling 44e1a2733423cb88225c078ee1523397b127a1a7 on cartant:issue-3470 into d7bfc9ddff01bd65c91ed3e4e6cc6930d4ceeae7 on ReactiveX:master.


Update TypeScript HSM sample application

Update to Node 16.
Simplify SKI code using Node standard packages and avoiding use of jsrsasign.

Also fix multiple existing build breakages.

@hyperledger/fabric-samples-maintainers I think this PR is ready for review. My intention was to deliver a small tidy up of the HSM sample but, when doing so, I discovered that large numbers of samples were failing in the build. I have fixed the majority of them in the second commit associated with this PR. The remaining failures are in Kubernetes deployment of the Full-stack Asset Transfer Guide. I do not know what changes are required to fix this failure.

Hi @bestbeforetoday and @denyeart
Sorry about the test failures falling off the vine.  It looks like there may have been a little bit of drift for the version of kind that is used by the test suite / sample app.  The binaries are pinned to a slightly out of date revision of kind / kubernetes (1.24.x) and it may be having troubles coming up on the latest github test runners.  The kind / kube clients are up to 1.28.x.


2.6.2 Security features

Feature or Bugfix

Security

Detail

#1577
Updating overly permissive policies tagged by checkov for environment role using least privilege principles by @mourya-33 in https://github.com/data-dot-all/dataall/pull/1632
Update sanitization technique by @noah-paige in https://github.com/data-dot-all/dataall/pull/1692
Fix/input validation by @noah-paige in https://github.com/data-dot-all/dataall/pull/1693
Move worksheet logic to service layer by @dlpzx in https://github.com/data-dot-all/dataall/pull/1696
Separating Out Access Logging  by @noah-paige in https://github.com/data-dot-all/dataall/pull/1695
return EnvironmentLogsBucketName from integraiton test getEnv query by @noah-paige in https://github.com/data-dot-all/dataall/pull/1697
add explicit token duration config for both JWTs by @noah-paige in https://github.com/data-dot-all/dataall/pull/1698
update fastapi dependency by @noah-paige in https://github.com/data-dot-all/dataall/pull/1699
Upgrade "cross-spawn" to "7.0.5" by @dlpzx in https://github.com/data-dot-all/dataall/pull/1701
Add MANAGE_SHARES permissions by @dlpzx in https://github.com/data-dot-all/dataall/pull/1702
Disable introspection on prod sizing by @noah-paige in https://github.com/data-dot-all/dataall/pull/1704
Add snyk workflow on schedule by @noah-paige in https://github.com/data-dot-all/dataall/pull/1705
Bump python runtime to bump cdk klayers cryptography version by @noah-paige in https://github.com/data-dot-all/dataall/pull/1707
tenant-permission tests  by @dlpzx in https://github.com/data-dot-all/dataall/pull/1694
Fix Snyk Workflow to Find Project Deps by @noah-paige in https://github.com/data-dot-all/dataall/pull/1708
Added permission check - is tenant to update SSM parameters API by @dlpzx in https://github.com/data-dot-all/dataall/pull/1714
Add GET_SHARE_OBJECT permissions to get data filters API by @dlpzx in https://github.com/data-dot-all/dataall/pull/1717
Add permissions on list datasets for env group + cosmetic S3 Datasets by @dlpzx in https://github.com/data-dot-all/dataall/pull/1718
Add GET_WORKSHEET permission in RUN_SQL_QUERY by @dlpzx in https://github.com/data-dot-all/dataall/pull/1716
Unify Logger Config for Tasks by @noah-paige in https://github.com/data-dot-all/dataall/pull/1709
Change Snyk Actions by @noah-paige in https://github.com/data-dot-all/dataall/pull/1713
Fix integration tests for list_environment_datasets unauthorized cases by @dlpzx in https://github.com/data-dot-all/dataall/pull/1720
Added permissions to Quicksight monitoring service layer by @dlpzx in https://github.com/data-dot-all/dataall/pull/1715
make dashboards optional based on config by @petrkalos in https://github.com/data-dot-all/dataall/pull/1677
Add LIST_ENVIRONMENT_DATASETS permission for listing shared datasets and cleanup unused code by @dlpzx in https://github.com/data-dot-all/dataall/pull/1719
Add omics create_run unauthorized test and improve other tests by @dlpzx in https://github.com/data-dot-all/dataall/pull/1723
Introduce is_owner permissions to Glossary mutations + add new integration tests by @dlpzx in https://github.com/data-dot-all/dataall/pull/1721
Refactor env permissions + modify getTrustAccount by @dlpzx in https://github.com/data-dot-all/dataall/pull/1712
Avoid infinite loop in glossaries checks by @dlpzx in https://github.com/data-dot-all/dataall/pull/1725
Feed consistent permissions by @dlpzx in https://github.com/data-dot-all/dataall/pull/1722
Votes consistent permissions by @dlpzx in https://github.com/data-dot-all/dataall/pull/1724
Consistent get_<DATA_ASSET> permissions - Dashboards by @dlpzx in https://github.com/data-dot-all/dataall/pull/1729
add resource permission checks by @petrkalos in https://github.com/data-dot-all/dataall/pull/1711
Integrational Tests fixes by @SofiaSazonova in https://github.com/data-dot-all/dataall/pull/1744
Bump deps and fix snyk workflow by @noah-paige in https://github.com/data-dot-all/dataall/pull/1745 and in in https://github.com/data-dot-all/dataall/pull/1746
CICD Integration tests: new shares for pre-existing datasets by @SofiaSazonova in https://github.com/data-dot-all/dataall/pull/1611
Feat/integ tests notifications by @noah-paige in https://github.com/data-dot-all/dataall/pull/1597 and in https://github.com/data-dot-all/dataall/pull/1747

⚠ Integration tests in sync with main removing 2.7 features (Redshift, Metadata Forma and Data Filters)
Relates

List above

Security
Please answer the questions below briefly where applicable, or write N/A. Based on
OWASP 10.

Does this PR introduce or modify any input fields or queries - this includes
fetching data from storage outside the application (e.g. a database, an S3 bucket)?

Is the input sanitized?
What precautions are you taking before deserializing the data you consume?
Is injection prevented by parametrizing queries?
Have you ensured no eval or similar functions are used?

Does this PR introduce any functionality or component that requires authorization?

How have you ensured it respects the existing AuthN/AuthZ mechanisms?
Are you logging failed auth attempts?

Are you using or adding any cryptographic features?

Do you use a standard proven implementations?
Are the used keys controlled by the customer? Where are they stored?

Are you introducing any new policies/roles/users?

Have you used the least-privilege principle? How?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Testing

[ ] Unit/Functional tests
[ ] Integration tests
[ ] Smoke test: Deploy to AWS


[BUG] panic: runtime error: invalid memory address or nil pointer dereference

What happened:
I deploy koordinator in a K8s cluster, and one node start koord-runtime-proxy failed with the following error messages, other nodes are ok:
Aug 04 17:17:55 xx.xx.xx.xx koord-runtime-proxy-0.5.0[580852]: panic: runtime error: invalid memory address or nil pointer dereference
Aug 04 17:17:55 xx.xx.xx.xx koord-runtime-proxy-0.5.0[580852]: [signal SIGSEGV: segmentation violation code=0x1 addr=0x30 pc=0x17298db]
Aug 04 17:17:55 xx.xx.xx.xx koord-runtime-proxy-0.5.0[580852]: goroutine 151 [running]:
Aug 04 17:17:55 xx.xx.xx.xx koord-runtime-proxy-0.5.0[580852]: github.com/koordinator-sh/koordinator/pkg/runtimeproxy/resexecutor/cri.(*ContainerResourceExecutor).ResourceCheckPoint(0xc000416fd0, 0x1af4b80, 0xc000a5ff10, 0xc000d151e0, 0x0)
Aug 04 17:17:55 xx.xx.xx.xx koord-runtime-proxy-0.5.0[580852]:         /root/projects/koordinator/pkg/runtimeproxy/resexecutor/cri/container.go:135 +0x7b
Aug 04 17:17:55 xx.xx.xx.xx koord-runtime-proxy-0.5.0[580852]: github.com/koordinator-sh/koordinator/pkg/runtimeproxy/server/cri.(*RuntimeManagerCriServer).failOver(0xc000536330, 0x7ffec00c1eda, 0x23)
Aug 04 17:17:55 xx.xx.xx.xx koord-runtime-proxy-0.5.0[580852]:         /root/projects/koordinator/pkg/runtimeproxy/server/cri/criserver.go:187 +0x2de
Aug 04 17:17:55 xx.xx.xx.xx koord-runtime-proxy-0.5.0[580852]: github.com/koordinator-sh/koordinator/pkg/runtimeproxy/server/cri.(*RuntimeManagerCriServer).Run(0xc000536330, 0x0, 0x0)
Aug 04 17:17:55 xx.xx.xx.xx koord-runtime-proxy-0.5.0[580852]:         /root/projects/koordinator/pkg/runtimeproxy/server/cri/criserver.go:60 +0x97
Aug 04 17:17:55 xx.xx.xx.xx koord-runtime-proxy-0.5.0[580852]: created by main.main
Aug 04 17:17:55 xx.xx.xx.xx koord-runtime-proxy-0.5.0[580852]:         /root/projects/koordinator/cmd/koord-runtime-proxy/main.go:57 +0x59b

What you expected to happen:
koord-runtime-proxy start successfully
How to reproduce it (as minimally and precisely as possible):
Just install koordinator on a node.
Anything else we need to know?:
Environment:

App version: 0.5.0
Kubernetes version (use kubectl version): 1.18.6
Install details (e.g. helm install args): --set featureGates="PodMutatingWebhook=true\,PodValidatingWebhook=true"
Others:

more info:
I found errors in kubelet logs:
kubelet-1.18.6[132718]: F0804 17:46:38.889050  132718 kubelet.go:1384] Failed to start ContainerManager failed to build map of initial containers from runtime: no PodsandBox found with Id 'b533e8e0efb6d6b2231488c57f2f83b1125935293fcfb903b9e8b109256688d6'

b533e8e0efb6d6b2231488c57f2f83b1125935293fcfb903b9e8b109256688d6 is an exited containers, and after the deletion of this container, the koord-runtime-proxy start successfully.
If you think it's not a problem, please close it, thank you!

docker or containerd environment？

docker or containerd environment？

containerd 1.4.11

Hi @wangxiaoq , could you try v0.6.0 or the latest code? Since this may be fixed in pr https://github.com/koordinator-sh/koordinator/pull/355 which is released in v0.6.0


What is the update time on feeds?

I'm not a coder, at all. I've loved RSS readers since Google Reader, then - when that closed - did a pretty comprehensive analysis of what was available (and settled on Inoreader) and now, I'm looking at CommaFeed.
I imported my subscriptions on Wednesday -- it appears many of my folders (and subscriptions in those folders) haven't updated since then (although, about 10-15% of the total folders apparently have). Is there something I need to do; settings-wise? I'm okay with them being checked 1-2 times a day; but they should at least be daily, IMO.

I guess you're using commafeed.com, which is a free instance hosted for your convenience. As there are a lot of users using it, refresh times are a lot longer than a self-hosted instance.
If you'd like to see your feeds refresh faster, I suggest you install your own CommaFeed instance.


Removed Abucoins exchange which is no longer operating

Removed Abucoins exchange which is no longer operating: https://abucoins.com/en

isn't their API still available to download old users trades?

Hi Adam,
I am not sure, because I do not have account here and I am not able to open it, because this exchange is dead. 'Register' button is still available, but it causes following error: "Due to company liqiduation process registrations are punt on hold."
(Public) API to download historical trades or order books does not exist.

I believe it is better to delete it. The exchange had ultra low volume even when it operated so not much damage will be done if we delete it.

thanks!


⚠ Bofrost.lu has degraded performance

In c71b7bf, Bofrost.lu (https://www.bofrost.lu) experienced degraded performance:

HTTP code: 200
Response time: 1045 ms

Resolved: Bofrost.lu performance has improved in e50e00b.


Haleon - Regulatory Affairs Associate - this job doesn't exists anymore on the company's oficial website although in validator it exists

URL: https://admin.peviitor.ro/jobs/Haleon
Browser: Chrome
Device: PC
OS: Linux
STEPS TO REPRODUCE:
Open the URL in the browser
Click on the logo of the validator
Go and click inside the searching bar and write "Haleon"
Verify the number of jobs to be the same as on the company's official website.

EXPECTED RESULTS:
The number of jobs is the same on validator and on the company's official website.
ACTUAL RESULTS:
On validator appears an extra job which isn't available anymore on the company's oficial website (Regulatory Affairs Associate.

Fixed


I want to contribute Space Station 14 development

But I really confused. What repository I must to choose. For now I see that space-wizards/space-station-14 repository is outdated and the lastest commits from Silvertorch5/space-station-14 not merged into it. Thanks for help. I see that volundr- has own fork.

If you haven't already, join the IRC channel<EMAIL_ADDRESS>

Ok. Thanks for quick reply!


Display second toast in same time error

When i'll show two toast's in same time - first do not hide - is always visible and screen is not clickabe

Thanks for your feedback and issue report @PawelSzymanski89

@koukibadr  any predictions about fix?

@PawelSzymanski89 I'm working on the issue

@PawelSzymanski89 the issue is fixed in the new version 2.1.1
https://pub.dev/packages/motion_toast
if the bug is fixed on your side you can close this issue.
Thanks for contributing to the project

@koukibadr thanks! your lib is awesome :)


URLs missing when getting a card by id

Hi! Love the API! I'm using it for my site! Unfortunately getting a card by id no longer returns urls. The image url and other urls are suddenly gone from the response.

Boye, can you include a URL that's broken?
On Apr 27, 2016 4:14 AM, "Boye Svensson"<EMAIL_ADDRESS>wrote:

Hi! Love the API! I'm using it for my site! Unfortunately getting a card
by id no longer returns urls. The image url and other urls are suddenly
gone from the response.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub
https://github.com/kyleconroy/deckbrew/issues/24

I can!
This URL returns empty store_url and html_url and the url, image_url and set_url are missing from the response: https://api.deckbrew.com/mtg/cards/nantuko-husk
While this URL returns them all with values: https://api.deckbrew.com/mtg/cards?name=nantuko husk

All fixed!
{
  "name": "Nantuko Husk",
  "id": "nantuko-husk",
  "url": "https://api.deckbrew.com/mtg/cards/nantuko-husk",
  "store_url": "http://store.tcgplayer.com/magic/product/show?partner=DECKBREW\u0026ProductName=nantuko-husk",
  "types": [
    "creature"
  ],
  "subtypes": [
    "insect",
    "zombie"
  ],
  "colors": [
    "black"
  ],
  "cmc": 3,
  "cost": "{2}{B}",
  "text": "Sacrifice a creature: Nantuko Husk gets +2/+2 until end of turn.",
  "power": "2",
  "toughness": "2",
  "formats": {
    "commander": "legal",
    "legacy": "legal",
    "modern": "legal",
    "standard": "legal",
    "vintage": "legal"
  },
  "editions": [
    {
      "set": "Onslaught",
      "set_id": "ONS",
      "rarity": "common",
      "artist": "Carl Critchlow",
      "multiverse_id": 42186,
      "flavor": "The soul sheds light, and death is its shadow. When the light dims, life and death embrace.\n—Nantuko teaching",
      "number": "159",
      "layout": "normal",
      "price": {
        "low": 0,
        "median": 0,
        "high": 0
      },
      "url": "https://api.deckbrew.com/mtg/cards?multiverseid=42186",
      "image_url": "https://image.deckbrew.com/mtg/multiverseid/42186.jpg",
      "set_url": "https://api.deckbrew.com/mtg/sets/ONS",
      "store_url": "http://store.tcgplayer.com/magic/onslaught/nantuko-husk?partner=DECKBREW",
      "html_url": "https://deckbrew.com/mtg/cards/42186"
    },
    {
      "set": "Magic Origins",
      "set_id": "ORI",
      "rarity": "common",
      "artist": "Carl Critchlow",
      "multiverse_id": 398440,
      "flavor": "\"The soul sheds light, and death is its shadow. When the light dims, life and death embrace.\"—Nantuko teaching",
      "number": "109",
      "layout": "normal",
      "price": {
        "low": 0,
        "median": 0,
        "high": 0
      },
      "url": "https://api.deckbrew.com/mtg/cards?multiverseid=398440",
      "image_url": "https://image.deckbrew.com/mtg/multiverseid/398440.jpg",
      "set_url": "https://api.deckbrew.com/mtg/sets/ORI",
      "store_url": "http://store.tcgplayer.com/magic/magic-origins/nantuko-husk?partner=DECKBREW",
      "html_url": "https://deckbrew.com/mtg/cards/398440"
    },
    {
      "set": "Magic: The Gathering-Commander",
      "set_id": "CMD",
      "rarity": "uncommon",
      "artist": "Carl Critchlow",
      "multiverse_id": 247144,
      "flavor": "The soul sheds light, and death is its shadow. When the light dims, life and death embrace.\n—Nantuko teaching",
      "number": "90",
      "layout": "normal",
      "price": {
        "low": 0,
        "median": 0,
        "high": 0
      },
      "url": "https://api.deckbrew.com/mtg/cards?multiverseid=247144",
      "image_url": "https://image.deckbrew.com/mtg/multiverseid/247144.jpg",
      "set_url": "https://api.deckbrew.com/mtg/sets/CMD",
      "store_url": "http://store.tcgplayer.com/magic/commander/nantuko-husk?partner=DECKBREW",
      "html_url": "https://deckbrew.com/mtg/cards/247144"
    },
    {
      "set": "Ninth Edition",
      "set_id": "9ED",
      "rarity": "uncommon",
      "artist": "Carl Critchlow",
      "multiverse_id": 84663,
      "flavor": "The soul sheds light, and death is its shadow. When the light dims, life and death embrace.\n—Nantuko teaching",
      "number": "148",
      "layout": "normal",
      "price": {
        "low": 0,
        "median": 0,
        "high": 0
      },
      "url": "https://api.deckbrew.com/mtg/cards?multiverseid=84663",
      "image_url": "https://image.deckbrew.com/mtg/multiverseid/84663.jpg",
      "set_url": "https://api.deckbrew.com/mtg/sets/9ED",
      "store_url": "http://store.tcgplayer.com/magic/9th-edition/nantuko-husk?partner=DECKBREW",
      "html_url": "https://deckbrew.com/mtg/cards/84663"
    },
    {
      "set": "Tenth Edition",
      "set_id": "10E",
      "rarity": "uncommon",
      "artist": "Carl Critchlow",
      "multiverse_id": 129653,
      "flavor": "The soul sheds light, and death is its shadow. When the light dims, life and death embrace.\n—Nantuko teaching",
      "number": "162",
      "layout": "normal",
      "price": {
        "low": 0,
        "median": 0,
        "high": 0
      },
      "url": "https://api.deckbrew.com/mtg/cards?multiverseid=129653",
      "image_url": "https://image.deckbrew.com/mtg/multiverseid/129653.jpg",
      "set_url": "https://api.deckbrew.com/mtg/sets/10E",
      "store_url": "http://store.tcgplayer.com/magic/10th-edition/nantuko-husk?partner=DECKBREW",
      "html_url": "https://deckbrew.com/mtg/cards/129653"
    }
  ]
}


Doc site should preserve left nav active state for pages regardless of current tab

Describe the bug
Currently the doc site only shows the active state for left nav items while visiting the default landing tab in the content.
To Reproduce
Steps to reproduce the behavior:

Go to 'auro.alaskaair.com'
Click on any component in the left nav
Notice the active state in the left nav
Click on a different tab for that component (e.g. API)
Notice the active state in the left nav

Expected behavior
Active state should persist regardless of what tab is being viewed

Wrong repo...

Please do not manually close issues. An issue should be linked to its pull request. Once the pull request is merged, the PR and the Issue will be closed automatically.

O_O

Wrong repo

It's easy to make this mistake. Instead of closing the issue, please transfer the issue.


0.24.0 upgrade guide

Commits: v0.23.0...v0.24.0
Added:

#1867 :new: mergeDeepLeft, mergeDeepRight, mergeDeepWith, mergeDeepWithKey
#2120 :new: startsWith, endsWith
#2127 :new: o, binary compose
#2130 :new: memoizeWith
#1868 :new: innerJoin

Removed:

#2182 :x: isArrayLike (#1877)

Deprecated:

#1868 :floppy_disk: intersectionWith

Changes:

#1900 FantasyLand 1.0 :tada:
#2036 dissocPath support integers
#2041 assocPath handle nil
#2119 xtake when n < 0
#2016 groupWith predicate receives adjacent elements
#2168 reduce move dispatch to reduce function to least priority

Let me know if I missed anything!
Many thanks to all the contributors supporting this release, especially to those helping with numerous improvements to tests and documentation :tada:

Hi!
When I upgrade to 0.24.0 my tests that uses memoize fail.
https://travis-ci.org/angeloocana/joj-core/builds/236872907
I don't know why, if i use 0.23.0 it works fine.

The fantasy-land link after #1900 is broken > https://github.com/ramda/ramda/issues/fantasy-land/fantasy-land

The fantasy-land link after #1900 is broken > https://github.com/ramda/ramda/issues/fantasy-land/fantasy-land

ty

@angeloocana
The only test I see that mentions memoize looks like it is passing. Can you re-create the issue in the repl?

@kedashoe  thanks for the answer!
I found the issue, in 0.24.0 memoize only checks the first param and ignores other params.
My example: https://goo.gl/kHxxAl
Simple example: https://goo.gl/ilvs7b
Is it right to memoize a function with more than 1 param?
I can try to fix ramda if it is really wrong behavior.

The error happens because memoize is using memoizeWith(toString)
function toString(val) { return _toString(val, []); }

toString converts only the 'val' to string.
I tried to use arguments, but a lot of other tests failed:
function toString() { return _toString(arguments, []); }

Any suggestion?

Was looking at the changes to memoize and noticed some ES6 features snuck their way into the codebase. https://github.com/ramda/ramda/blob/master/src/memoize.js#L22 Should we change those back to var?

I'm in favour of using arrow functions and other ES6 features in the examples, @Bradcomp.

@angeloocana My suggestion is that we should have never defined memoize and that you should always use memoizeWith. So for your code base, I would recommend replacing memoize with memoizeWith.
However, my time machine is broken and it does look to me like you have identified a regression we did not intend. Would you like to submit a PR? I think if we just explicitly pass arguments to toString in memoize that should do the trick.

@davidchambers Oh dang. Dunno how I missed that that was an example :expressionless:  :coffee:

Pull request done! =D
I created R.toStringN() to fix it.


hide menu options from BikeStoreFragmentActivity. leading to a large …

When entering the LoginActivity the options menu is still present which would allow the login option to be pressed continually spawning new Activities until a surely impending doom.

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA).
:memo: Please visit https://cla.developers.google.com/ to sign.
Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.
If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
If you signed the CLA as a corporation, please let us know the company's name.

I signed it!


Remove naming convention checks

Resolves #21.

Here are some comments on this for future reference. This extra validation made sense when Bramble was a proprietary Movio project. Now that Bramble is open source, it no longer makes sense to impose GraphQL naming best practices on all users. We do still recommend following GraphQL naming best practices but Bramble won't stop you from using any compliant schema.


HpackEncoder writing headers does constantTime lookup

Looking at a profile of a client that sends a lot of http2 requests, I did notice that HpackEncoder spends some unnecessary time in encoding headers.
This is because in this place:
https://github.com/netty/netty/blob/4.1/codec-http2/src/main/java/io/netty/handler/codec/http2/HpackEncoder.java#L173
it does a lookup for an already existing header.
I do understand the idea of not leaking timing information in sensitive code, but I struggle to see that this place could be one where it could apply (especially as the follow up code will make it sidechannel observable which code path was followed)

@carl-mastrangelo PTAL

Also @bryce-anderson

I'd strongly suggest getting someone with a security background to weigh in, but here are my 2 cents.
It looks like there are comparison early-aborts for differences in length and key hashcode, so if you're benchmarking and using identical headers I doubt we'll get better performance. However, I suspect the line
if (e.hash == h && (equalsConstantTime(name, e.name) & equalsConstantTime(value, e.value)) != 0) {
  return e;
}

would be roughly as safe and potentially faster if changed to
if (e.hash == h && equalsConstantTime(value, e.value) && equalsConstantTime(name, e.name)) {
  return e;
}

for headers with the same key but varying values.

Maybe @Lukasa ....

Huh, I'm somewhat surprised to see a constant-time comparison for HPACK header fields in this case.
The reason to want to perform constant-time comparisons when querying the HPACK table is to prevent a side-channel leaking the value of sensitive headers, such as cookies or authorisation headers. The side-channel in question can only exist when running HTTP/2 in a coalescing configuration where there are multiple peers sharing the same HPACK table (otherwise HPACK tables are per-connection, which in a client-server mode is not a shared resource).
The first note here is that I think there is zero security value in performing a constant-time comparison of the field name. Header field names are not per-client and highly unlikely to contain sensitive content, so the odds of anyone launching this side channel attack on a header field name are approximately zero. So we can throw that bit away entirely and just use a regular string comparison. (I'd say this applies more generally to the rest of this code, I can see no value in ever performing constant-time string comparison on HPACK field names.) This is basically an evolution of @bryce-anderson's proposal: in addition to removing the bitwise comparison, we can remove the equalsConstantTime on the name, and go back to comparing the name first (we don't have a side channel if we never even look at the value, so comparing the names first is fine).
Doing the constant-time comparison on the value is more interesting. A general solution is not really available: we can rely on sensitive header detection which should eliminate issues regarding Cookie or Authorization, but people love putting sensitive information in all kinds of random headers and we can't a priori know which ones they'll use. If we wanted to be maximally defensive we can keep the constant time comparison on all values. A more pragmatic approach might be to do it only on sensitive headers. This reflects the fact that another side channel exists: compressed HPACK block size. Sensitive headers that we'd want to defend with constant time string comparison should never enter a HPACK compression table in the first place, so arguably that's the only case in which we'd need to do it here.

The relevant counter argument comes from @jpinner's original comment here:

The compare does predate the inclusion of the "never index" flag. That being said I can certainly think of "sensitive" headers that you might want to index for performance in the table (e.g. domain cookies sent on every request).
I personally would be cautious here.

I disagree with Jeff's argument: while the caution is understandable I think the timing side channel is no more vital to defend against than the sizing side channel, and the only defence against that side channel is never indexed headers. That's the correct solution to here. The performance gain of putting "sensitive" headers in the table is likely to be utterly dwarfed by the performance cost of doing constant-time comparisons for every table lookup.

As some relevant context, neither of the two implementations I wrote perform constant-time comparisons here. Neither does nghttp2 or h2o as two other prominent implementations.

@Lukasa thanks again for all the thoughtful comments :) I knew why I pinged you here. 🍻 on me.
@bryce-anderson @CodingFabian WDYT ? Any takers ?

Jumping ahead without reading the thread.  I had  PR that mostly removes the overhead.  @CodingFabian   Would https://github.com/netty/netty/pull/9259  fix this for you?  Is there anyway you can patch in that PR and see if it helps?

@carl-mastrangelo The PR will pretty likely fix it for me. I will patch my current version and come back.

@CodingFabian thanks... please keep us posted.

I had a look at the PR #9259 by @carl-mastrangelo and compiled 4.1.42 with it, to replace the same version I ran the original experiments / profiling with.
As expected all the calls disappeared (well the code no longer calls them, duh :))
The only really scientific statement I can do is that while previously header encoding showed up in the top list, it now does not anymore.
so in a sense #9259 fixes this issue.

Fixed by https://github.com/netty/netty/pull/9259


Add information from HUB 2 - API 1.1

Via API 1.1 it is possible to query the temperature and humidity of a HUB 2 (new version from Switchbot)
It would be interesting to add Hub 2 with its data to this integration.
As a support I send the instructions via API 1.1 to be sent after authentication to create the sensor which are currently in my configuration.yaml and which work correctly.
Thank you
  - resource: https://api.switch-bot.com/v1.1/devices/HUBDEVICEID/status
    scan_interval: 300
    headers:
      Authorization: "{{ states('input_text.switchbot_token') }}"
      sign: "{{ states('sensor.switchbot_sign') }}"
      t: "{{ state_attr('sensor.switchbot_sign','t') }}"
      Content-Type: "application/json"
      nonce: ""
    sensor:
      - name: "SwitchBot Hub 2 Temperature"
        unique_id: switchbot_hub_2_temperature
        value_template: "{{ value_json.body.temperature }}"
        unit_of_measurement: "°C"
        device_class: temperature
      - name: "SwitchBot Hub 2 Humidity"
        unique_id: switchbot_hub_2_humidity
        value_template: "{{ value_json.body.humidity }}"
        unit_of_measurement: "%"
        device_class: humidity

With the same logic I noticed that the switchbot  contact_sensor doesn't work properly with the original integration via bluetooth.
I created the sensors that  with API 1.1, updating every 10 seconds
I don't know if this is correct but the created sensor works correctly and provides the open close status correctly.
If it helps, I attach the instructions and these too can be included in the integration
Anyone else having issues with the switchbot contact_sensor open/close states in original integration??
  - resource: https://api.switch-bot.com/v1.1/devices/contact_sensor_ID/status
    scan_interval: 10
    headers:
      Authorization: "{{ states('input_text.switchbot_token') }}"
      sign: "{{ states('sensor.switchbot_sign') }}"
      t: "{{ state_attr('sensor.switchbot_sign','t') }}"
      Content-Type: "application/json"
      nonce: ""
    sensor:
      - name: "SwitchBot Finestra Sala Battery"
        unique_id: switchbot_finestra_sala_battery
        value_template: "{{ value_json.body.battery }}"
        unit_of_measurement: "°%"
        device_class: battery
      - name: "SwitchBot Finestra Sala brightness"
        unique_id: switchbot_finestra_sala_brightness
        value_template: "{{ value_json.body.brightness }}"
        device_class: light
      - name: "SwitchBot Finestra Sala open-close"
        unique_id: switchbot_finestra_sala_oc
        value_template: "{{ value_json.body.openState }}"
        device_class: door

@goodsale how did you get the auth token from the integration? i cant make this work

@goodsale how did you get the auth token from the integration? i cant make this work

If like me you are not very experienced with code, you can look at this link.
Once you create the basis with this method to do authentication, then you can do whatever you want.
https://www.speaktothegeek.co.uk/2023/07/switchbot-api-v1-1-and-home-assistant/

@KiraPC yeah i get it, i thought the token was exposed by the integration so i didn't have to get it outside and i could create a sensor, anyway adding Hub2 temp/humidity shouldn't be too complex their are returned by the device list in the payload
@goodsale thanks, actually i am very experienced with coding but not experienced with HA :) thats what i was looking for, i could probably just call a script instead of embedding the entire python line in the command but thanks

@goodsale the purpose of this package is to support IR devices.
Have you managed to try adding Hub 2 through the Matter Server Addon? This works locally without connecting to the cloud.

@goodsale, check the new Home Assistant update, have the native Cloud API integration option

I encountered some issues with the native Home Assistant integration as it didn't meet my requirements effectively. The integration lacked sensor information and the capability to use custom IR commands, prompting me to explore alternatives.
I also connected the Hub via Matter, which provided temperature and humidity data, but unfortunately, light level information was not available. Matter, too, doesn't support the use of custom IR commands, limiting its compatibility to only my AC unit.
Additionally, I observed a lack of synchronization in the IR AC status. After inspecting the API, I couldn't find a method to retrieve this information.
Considering these challenges, I believe it would be beneficial to enhance the existing HACS integration. Specifically, incorporating features to fetch temperature, humidity, and light data through the API could significantly improve the integration's functionality. This would address the shortcomings I've experienced and make the integration more comprehensive.


[4.0][migrator] Update API change data after fixing SR-5498.

Explanation: A case of false positive in swift-api-digester makes migrator update certain APIs wrong. After fixing the issue in swift-api-digester, we need to update the API change data to correct migrator's behavior.
Scope: Swift migrator
Radar (and possibly SR Issue): SR-5498
Risk: Very Low
Testing: Existing tests cover all transformation patterns the change data can describe.

@swift-ci test