markdown preview in Remote SSH not woking properly

Issue Type: Bug
code formatting and styling in markdown preview is not working properly.

Preview of file in local

Preview of file in Remote-SSH

VS Code version: Code 1.39.1 (88f15d17dca836346e787762685a40bb5cce75a8, 2019-10-10T23:35:11.314Z)
OS version: Darwin x64 17.7.0

System Info

Item
Value

CPUs
Intel(R) Core(TM) i5-4570 CPU @ 3.20GHz (4 x 3193)

GPU Status
2d_canvas: enabledflash_3d: enabledflash_stage3d: enabledflash_stage3d_baseline: enabledgpu_compositing: enabledmultiple_raster_threads: enabled_onnative_gpu_memory_buffers: enabledoop_rasterization: disabled_offprotected_video_decode: unavailable_offrasterization: enabledskia_deferred_display_list: disabled_offskia_renderer: disabled_offsurface_synchronization: enabled_onvideo_decode: enabledviz_display_compositor: disabled_offwebgl: enabledwebgl2: enabled

Load (avg)
2, 2, 2

Memory (System)
8.00GB (0.50GB free)

Process Argv
-psn_0_360536

Screen Reader
no

VM
0%

Extensions (14)

Extension
Author (truncated)
Version

code-gnu-global
aus
0.2.2

fortran-ls
han
0.6.0

latex-workshop
Jam
8.2.0

linter-gfortran
krv
2.1.1

anaconda-extension-pack
ms-
1.0.1

python
ms-
2019.10.41019

remote-containers
ms-
0.81.0

remote-ssh
ms-
0.47.1

remote-ssh-edit
ms-
0.47.1

remote-wsl
ms-
0.39.9

vscode-remote-extensionpack
ms-
0.17.0

cpptools
ms-
0.25.1

material-icon-theme
PKi
3.9.1

vscodeintellicode
Vis
1.1.9

(2 theme extensions excluded)

Seem to be running into a similar issue with a WSL-remote.
All of the "advanced" features appear to be broken (such as the preview locking and my custom theme for the Markdown preview). Doing the same in a non-WSL vscode window works without issues.
The following error is generated about a dozen times on the development tools console while in the WSL-remote:
resourceLoader.ts:39 h: Unable to read file (Error: [UriError]: If a URI does not contain an authority component, then the path cannot begin with two slash characters ("//"))     at v.readFileStream (file:///C:/Users/xxx/AppData/Local/Programs/Microsoft VS Code/resources/app/out/vs/workbench/workbench.desktop.main.js:1539:7)     at process._tickCallback (internal/process/next_tick.js:68:7)

Duplicate of #82336
Fixed in insiders. Should be fixed a 1.39.2 build early this week


1.0.53 is broken on stable (#![feature]` may not be used on the stable release channel)

To reproduce
> rustc -vV
rustc 1.75.0 (82e1608df 2023-12-21)
binary: rustc
commit-hash: 82e1608dfa6e0b5569232559e3d385fea5a93112
commit-date: 2023-12-21
host: aarch64-apple-darwin
release: 1.75.0
LLVM version: 17.0.6
> cargo new --lib thiserr-test
> cargo add thiserror
# make sure version is 1.0.53
> cargo build
error[E0554]: `#![feature]` may not be used on the stable release channel
   --> /Users/muradb/.cargo/registry/src/index.crates.io-6f17d22bba15001f/thiserror-1.0.53/src/lib.rs:238:50
    |
238 | #![cfg_attr(error_generic_member_access, feature(error_generic_member_access))]
    |                                                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^

Change version to =1.0.52.
Now cargo build works fine.
I checked that the CI for 1.0.53 has ran fine yesterday, so this might be an issue with OS (unlikely tho)?

I was not able to reproduce this with those same commands.
$ rustc -vV
rustc 1.75.0 (82e1608df 2023-12-21)
binary: rustc
commit-hash: 82e1608dfa6e0b5569232559e3d385fea5a93112
commit-date: 2023-12-21
host: aarch64-apple-darwin
release: 1.75.0
LLVM version: 17.0.6

$ cargo new --lib thiserr-test
     Created library `thiserr-test` package

$ cd thiserr-test

$ cargo add thiserror
    Updating crates.io index
      Adding thiserror v1.0.53 to dependencies.
    Updating crates.io index

$ cargo build
   Compiling proc-macro2 v1.0.73
   Compiling unicode-ident v1.0.12
   Compiling thiserror v1.0.53
   Compiling quote v1.0.34
   Compiling syn v2.0.44
   Compiling thiserror-impl v1.0.53
   Compiling thiserr-test v0.1.0
    Finished dev [unoptimized + debuginfo] target(s) in 2.27s

Would you be able to share the relevant environment variables from your shell where this issue occurs?
$ env | grep 'RUST\|CARGO'

Another thing that might reveal what is going on would be the contents of cargo config.toml.
$ RUSTC_BOOTSTRAP=1 cargo -Zunstable-options config get

With https://github.com/Scripter17/url-cleaner/commit/f4b39889845140b50588820820a4a3287047a578 on Rust 1.75, compiling a debug build will fail but not in release mode.
Weirdly, removing that from my global cargo config makes the error not happen??? I have no idea what that could possibly mean but it also fixed something with tokio (tokio-macros?) from having errors linking to libc.
So uh, @m-spitfire, if you use sccache try clearing the cache?

Thank you @Scripter17! Connecting this to sccache is very helpful. I published one possible fix in thiserror 1.0.54 and another possible fix in 1.0.55. Would you be willing to try both of them to see whether this issue still occurs in either one? I would love if you could wipe the sccache cache in between trying the 2 fixes, but if that would be too disruptive then don't worry about it and I am still interested in the result.

I wiped the sccache cache and recompiled with the same version. It seems to have fixed it
If needed I'll try getting the broken cache from a backup and compile with that

According to my hypothesis in #279, one way you might be able to deterministically screw up the cache is:
$ cargo update -p thiserror --precise 1.0.53
$ RUSTC_BOOTSTRAP=1 cargo +stable check
$ cargo clean
$ unset RUSTC_BOOTSTRAP
$ cargo +stable check  # FAIL

If this reproduces the bug with 1.0.53 and not with 1.0.54 and/or 1.0.55, then I think we'd be set.
Thank you!

Oh, that might not do it on its own. :slightly_frowning_face: There might also have needed to be some Cargo settings changed in between the first check and second check, otherwise the second check will run the build-script but then not recompile thiserror's lib.rs, because that will have been cached from the first check.
Let me install sccache myself and try to experiment with this.

I was able to find a deterministic repro:
#!/bin/bash

set -e
set -x

sccache --stop-server || true
rm -rf repro ~/.cache/sccache
unset RUSTC_BOOTSTRAP
cargo +stable new repro
cd repro
mkdir .cargo
echo -e "[build]\nrustc-wrapper = \"$HOME/.cargo/bin/sccache\"" > .cargo/config.toml
cargo +stable add<EMAIL_ADDRESS>cargo +stable update -p syn --precise 2.0.43
cargo +stable update -p quote --precise 1.0.33
cargo +stable update -p proc-macro2 --precise 1.0.71
RUSTC_BOOTSTRAP=1 cargo +stable check
cargo +stable build  # FAIL

This reproduces the bug in thiserror 1.0.53 and succeeds with 1.0.54 and 1.0.55 (so the second change #280 is not needed after all, only #279).
I'll close this as fixed but we can reopen if anyone still hits anything like this with thiserror 1.0.54+.


Push v5.4.1 to Pursuit

The latest version shown on Pursuit is 5.4.0 (https://pursuit.purescript.org/packages/purescript-lists/). This causes issues for certain documentation links. Can we push v5.4.1?

I believe anyone can push docs to pursuit as long as you authenticate.

Ok. I've never done that before. I'll try and figure it out and let you know if I have issues.

I tried to upload to Pursuit using the instructions found at https://pursuit.purescript.org/help/authors.
Having successfully run pulp login and received Successfully authenticated as JamieBallingall., I tried pulp publish but that resulted in:
remote: Permission to purescript/purescript-lists.git denied to JamieBallingall.
fatal: unable to access 'https://github.com/purescript/purescript-lists.git/': The requested URL returned error: 403
* ERROR: Subcommand terminated with exit code 128

Do I need to be added to some list of approved users to push docs?

No, you just need to use the —no-push flag. That error message comes from trying to push to the GitHub repo.

Ah. Got it.
@natefaubion, @hdgarrood : Thank you for your patient explanations here and on Slack.
Pursuit is now updated. Closing.

Thanks!


Recreate Null Session when App does not load fast enough

I am running into an issue where with my current TestClassBase setup, if the app does not load fast enough WinAppDriver will eventually throw an error saying that the session could not be initialized because the app never launched. Error looks like "Failed to locate opened application window with appID ..."
To handle this, I ended up throwing in some logic in there that would catch this and then attempt to recreate the session. The problem with this though is that the app will eventually load from that first attempt at creating the session. This will then create 2 app windows in some cases causing intermittent failures.
What I would like to do is just catch this error, wait for the app to eventually pop up, and then recreate itself from the app window that finally has launched. Is there a way to do this. Something psuedocode would be
session = openedAppWindow(...)
I know there is a capability that we can use called like waitForAppToLaunch or something like that, but this is totally unacceptable since it uses a hard wait. Who in their right mind would force all of their tests to wait an extra 15 seconds each, might as well be using a Thread.Sleep.

Was able to solve with this example here..
https://github.com/Microsoft/WinAppDriver/issues/445


Add Secondary Navigation component

Context
We need a top-level navigation for the Support console to manage Support Users. With this new requirement, we have to introduce a Secondary Navigation bar to replace the existing Primary Navigation bar for managing Organisations in the Support console.
Changes proposed in this pull request

Rename the NavigationBar component to PrimaryNavigationComponent
Move PrimaryNavigationComponent into the application layout to show only for support controller actions
Add SecondaryNavigationComponent

Guidance to review

Visit the Claims service
Sign in as a Support user
Select a School
See Primary Navigation and Secondary Navigation components

The Primary Navigation "active" status does not show in deep pages. This is out of scope for this change.

Link to Trello card

Things to check

[ ] If the code removes any existing feature flags, a data migration has also been added to delete the entry from the database
[ ] This code does not rely on migrations in the same Pull Request
[ ] If this code includes a migration adding or changing columns, it also backfills existing records for consistency
[ ] If this code adds a column to the DB, decide whether it needs to be in analytics yml file or analytics blocklist
[ ] API release notes have been updated if necessary
[ ] If it adds a significant user-facing change, is it documented in the CHANGELOG?
[ ] Required environment variables have been updated or added to the Azure KeyVault

Screenshots

 Add Secondary Navigation Bar

Sorry to add another comment after my Review. Do you think it's worth adding a spec in our system specs to test the secondary nav is there?

Sorry to add another comment after my review. Do you think it's worth adding a spec in our system specs to test the secondary nav is there?

I'll add it in :)


Workflow position email notifications

This PR somewhat indirectly addressess the request for different mail content/terminology to be used when an application manager receives notification about a project being closed (Plan.IO 27280).
I've approached this from a slightly more abstracted perspective and the bulk of the PR is a lot of groundwork and foundations for sending emails to interested parties when a project moves to any state (and in a way that helps to decouple emails from Notifications and remove side effect logic from the persistence layer).
The use of localisation over branching logic feels like a nice touch, and could help in the long run when things like views diverge to the point where having a single template feels constraining and hurts readability (from e.g. excessive branching), but I'm slightly concious about it...

Is it correct and consistent in terms of favoured approach to these problems within the team and our other codebases? (although I know we've done so on at least one other project, to great effect).
Accessibility to the next dev; can they just pick it up and run, or will they get bogged down in layers of indirection/abstraction?
Am I using a scalpel to spread butter?

So, thoughts very much welcome on this one!
Commits:

Add project_state_name delegate.
Add framework for sending project state change emails
Replicate mail generated from rejected Notification
Boyscouting - clearer variable names
Backport translations fix for state names
Use localisation for varying email content for different target audiences
Add application/eoi specific rejected email
Add an ODR specific version of the project rejected email
Wire up post transition email notifications
Project rejected Notifications should not generate email
Do not email about state changes under certain condiftions

I think this is good approach and as you say there's precedent elsewhere. There's always going to be level of developer onboarding when looking at unfamiliar code. I've made a few comments.


Clipboard hangs when trying to enable OSC 52

Related to #113
I'm using the LazyVim configuration, which includes yanky, but I need clipboard support on my remote server, and would like to use wezterm, which doesn't do X forwarding. The solution seems to be to force the usage of OSC52 so that I can copy/paste to my local clipboard.
However, when I add the suggested
vim.g.clipboard = {
  name = "OSC 52",
  copy = {
    ["+"] = require("vim.ui.clipboard.osc52").copy("+"),
    ["*"] = require("vim.ui.clipboard.osc52").copy("*"),
  },
  paste = {
    ["+"] = require("vim.ui.clipboard.osc52").paste("+"),
    ["*"] = require("vim.ui.clipboard.osc52").paste("*"),
  },
}

to lua/config/options.lua, any time I open a file buffer, I get a message "Waiting for OSC 52 response from the terminal." followed by "Timed out waiting for a clipboard response from the terminal". Then, when I attempt to yank, nothing gets added to the register.
If I disable loading yanky, I don't get the timeout when opening a buffer, and yanking works as expected. However, I don't know that this is really yanky's fault, since when I paste, I get the same timepoint message (though after it times out, the pasting happens).

 If I do a totally blank init.lua other than
vim.opt.clipboard = "unnamedplus"

vim.g.clipboard = {
  name = "OSC 52",
  copy = {
    ["+"] = require("vim.ui.clipboard.osc52").copy("+"),
    ["*"] = require("vim.ui.clipboard.osc52").copy("*"),
  },
  paste = {
    ["+"] = require("vim.ui.clipboard.osc52").paste("+"),
    ["*"] = require("vim.ui.clipboard.osc52").paste("*"),
  },
}

and the same thing happens with alacritty over ssh, so it's not wezterm's fault either. I'll open an issue in nvim

For anyone encountering this in the future, this worked for me: https://github.com/neovim/neovim/discussions/28010#discussioncomment-9877494
vim.o.clipboard = "unnamedplus"

local function paste()
  return {
    vim.fn.split(vim.fn.getreg(""), "\n"),
    vim.fn.getregtype(""),
  }
end

vim.g.clipboard = {
  name = "OSC 52",
  copy = {
    ["+"] = require("vim.ui.clipboard.osc52").copy("+"),
    ["*"] = require("vim.ui.clipboard.osc52").copy("*"),
  },
  paste = {
    ["+"] = paste,
    ["*"] = paste,
  },
}

This workaround apparently breaks the yanky - I'm no longer able to cycle through the history. After some debugging I found that setreg function isn't able to set the "+ register, which isn't the case when I use the osc52 paste.
But I'm having trouble figuring the out the issue beyond this observation.

I solved it by ignoring the clipboard registers on yanky setup.
local yanky = require "yanky"
yanky.setup {
  ring = {
    ignore_registers = { "_", "+", "*" },
  },
  highlight = {
    on_put = true,
    on_yank = true,
    timer = 300,
  },
}

I solved it by ignoring the clipboard registers on yanky setup.

Didn't work for me, still can't cycle over ring buffer, it always pastes the last one even with YankyRingHistory and manually selecting


Add centralized database query

🗣 Description
Centralize database query functions for pe-reports proposed in issue #77.

💭 Motivation and context
To have all database functions all in one place for logical organization.

🧪 Testing
The following processes must run successfully
Install: pip install -e .
Tests: pytest /tests
Additionally pass all pre-commits
pre-commit run --all-files

📷 Screenshots (if appropriate)

✅ Checklist

[ ] This PR has an informative and human-readable title.
[ ] Changes are limited to a single goal - eschew scope creep!
[ ] All future TODOs are captured in issues, which are referenced
in code comments.
[ ] All relevant type-of-change labels have been added.
[ ] I have read the CONTRIBUTING document.
[ ] These code changes follow cisagov code standards.
[ ] All relevant repo and/or project documentation has been updated
to reflect the changes in this PR.
[ ] Tests have been added and/or modified to cover the changes in this PR.
[ ] All new and existing tests pass.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 76.987%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
174

Relevant Lines:
217

💛  - Coveralls

@dav3r or @jsf9k, do you want to take a look before we merge?

@dav3r or @jsf9k, do you want to take a look before we merge?

I would like to take a look at this, but I am not sure if I will be able to get to it today.


Convert.ToDouble(String) won't work

I did a new Avalonia Project with the "Avalonia .NET Core App" template. I use the code below to convert String to Double:
string strDouble = "100,1"; // 100,1
double dblDouble = Convert.ToDouble(strDouble); //<PHONE_NUMBER>99999

Also rounding like
double rndDouble = Math.Round(dblDouble, 1);

has no effect.
A .NET console or a WPF app will convert the string "100,1" correct  to a double 100,1 (100.1).

Not related to the Avalonia.


how to know if the file is modified only

if i print event i am getting all the changes but i want to have call back only if the file is modified(ItemModified)
path: xxxxxxxxxxxxxx, flag: ItemRemoved, ItemRenamed, ItemModified, ItemChangeOwner, ID: 33344323), (path: xxxxxxxxxxx, flag: ItemRenamed, ItemFinderInfoMod, ItemXattrMod, ID: 33344417)

Hello, @remella. Sorry for late reply.
You can filter specific event like this.
for ev in events {
    if ev.flag.contains(.itemModified) {
        // Do what you want for modified here...
    }
}

I updated example target code.
If you're looking for a way to prevent monitoring of specific event instead of post-filtering, This framework does not support it because I couldn't find a way to do it in Apple's FSEvent level.


Add lines length check

@cdmistman Please take a look and let me know if this change makes sense or do you think is related to another part of the flow.
The error is the following when executing new or terminate:
thread 'main' panicked at 'attempt to subtract with overflow', /Users/alejandro/Documents/projects/alantech/alan/anycloud/cli/src/deploy/mod.rs:1321:44

HOW did this not trigger during my testing????

I suspect because you were reusing the same service name all the time? If this bug was introduced near the end,  then you might not have had a totally blank input during your testing.

This fixes the crash, but doesn't look like it behaves correctly?
If the old lines.len() is 0, it should be printing all of the new lines?

maybe @cdmistman could confirm, but what I understand is that if lines has something in it it should print the last one, if it's empty no need to do anything. The new lines are still being printed.

This fixes the crash, but doesn't look like it behaves correctly?
If the old lines.len() is 0, it should be printing all of the new lines?

maybe @cdmistman could confirm, but what I understand is that if lines has something in it it should print the last one, if it's empty no need to do anything. The new lines are still being printed.

So lines is the old set of lines and new_lines is the new set. The iterator calls each of the lines from new_lines just line confusingly.
Basically I stand behind my block here.

HOW did this not trigger during my testing????

I suspect because you were reusing the same service name all the time? If this bug was introduced near the end, then you might not have had a totally blank input during your testing.

I used the same service name for some testing but not every time I tested (some times I chose the same name, I also sometimes didn't come back until >10 mins later, when the logs expired).
Regardless, lines always starts with len() == 0, so the first time the /logs endpoint returns a single, non-empty line during the lifetime of the CLI app should trigger a panic.

If the old lines.len() is 0, it should be printing all of the new lines?

lines is the vec of all the lines we've received. the vec doesn't actually do much besides storing them so we can println them later instead of just leaving them as the message of the spinner. Honestly, lines could be replaced with a single Option that we take() to print and then reassign with line in the for_each closure

This fixes the crash, but doesn't look like it behaves correctly?
If the old lines.len() is 0, it should be printing all of the new lines?

maybe @cdmistman could confirm, but what I understand is that if lines has something in it it should print the last one, if it's empty no need to do anything. The new lines are still being printed.

So lines is the old set of lines and new_lines is the new set. The iterator calls each of the lines from new_lines just line confusingly.
Basically I stand behind my block here.

yes, line in the closure is new_line. the only behavior this pr changes is when len is 0, which is before /logs has returned anything.

Just understood it and tested it. I have restored it to my initial fix since is the expected behaviour. Nevertheless I've added this comment to clarify: https://github.com/alantech/alan/pull/568/files#diff-cdb2ed790a8a8d7ee75b3740ed4c96f3a9bd1c20df6f27a064c8062b3c8fb906R1321-R1323


Font in installation window is unreadable

The font used in the installation window is completely unreadable. I don't recall this being an issue in previous versions.

:man_facepalming: 1.4.1 is fine but 1.4.2 isn't?

This is what it looks like for me, with the grey background behind the text, but I'm still on Sierra. You're on high sierra, right?

Can you let me know what it looks like with this build? https://github.com/Kilian/fromscratch/releases/download/untagged-1202b55297ca612e5903/FromScratch-1.4.3.dmg
If it's still broken, I'll have to do a light background for the installer.


target_speeds

Hi，@eleurent！DiscreteMetaAction has an attribution target_speeds. I can't understand its meaning.
Can you give a detailed example for understanding
issue278  seems not clear.

As explained in https://github.com/eleurent/highway-env/issues/278, target speeds is a set of speeds that can be tracked by the vehicle.
For instance, you could set
target_speeds = [5 m/s, 10 m/s, 15 m/s, 20m / s]
Assume the vehicle is initially created with a target speed of 10 m/s.
If you execute the FASTER action, the target speed will move to the next index in the list, i.e. 15 m/s.
If you execute FASTER again, the target speed will now be 20 m/s. From there, doing FASTER changes nothing (already max speed), and doing SLOWER changes it back to 15 m/s.
By setting this parameter, you can allow for different ranges of reachable speeds depending on your needs.

If you execute FASTER again, the target speed will now be 20 m/s. From there, doing FASTER changes nothing (already max speed),
would this mean, at this point both FASTER and IDLE have the same effect?

If you execute FASTER again, the target speed will now be 20 m/s. From there, doing FASTER changes nothing (already max speed)

Would this mean FASTER and IDLE will be having having the same effect at this point?

Yes, exactly. If your agent supports it, you can also call env.get_available_actions(), which will exclude the FASTER action when the vehicle is already at maximum speed.


Enhancement of UI of Footer Section

Is your feature request related to a problem? Please describe.

In this image you can see the buttons and text fonts are not very appealing
Describe the solution you'd like
The text and buttons interface should be changed in such a way that it looks appealing
Describe alternatives you've considered
For the solution I can change the look of the footer texts and buttons which will match the great footer animation such that it looks very appealing hence leading to a great User Interface.
Additional context (Mandatory )
I'd like if you could assign this issue to me as I have made several projects and won a hackathon and would love to contribute in this too…
Are you contributing under any open-source program ?
GSSoC'24

👋 Hello! I'd be happy to help with this issue. Could you please assign it to me? Additionally, could you please label it for the appropriate level? Thank you! 🚀

All the contributor icons are not aligned and the font family is not that appealing.
Assign this issue to me under GSSoC '24 to help you with these.

I've already raised this issue to get it assigned to me please find some other issues if possible. Thank you!!

Hello @VedantAnand17, Time's up!⏰
Sorry for closing your issue!
But it's more than a week since we haven't received anything from your side 😢 .
Come up with new ideas, create a new issue and make sure you finish it within a week! 🔥
All the best! 🚀
Happy Hacking! 💗

Hey @VedantAnand17 ! Thank you so much for your raising the issue💗
It’s all yours, you can come anytime again and make some contributions! 🚀
Alone, we can do little, but together we can do so much! 😇


Use singular naming convention for package names in client libraries

Reference: https://apiview.azurewebsites.net/Assemblies/Review/0957665bd5d54c2394199d291898e05c#com.azure.core.credentials.AccessToken

We have models, entities, keys, eventhubs and credentials. Maybe keys and eventhubs are exceptions to this rule as they are service names, but should we rename the others to use singular names as well?

Let's won't-fix this for Preview 5 and leave the package names as-is for the release.
/cc @JonathanGiles @Petermarcu as fyi on triaging


Pull Request Comments not sent in webhook event

Gitea version (or commit ref):
Git version:
Operating system:

Database (use [x]):

[x ] PostgreSQL
[ ] MySQL
[ ] MSSQL
[ ] SQLite

Can you reproduce the bug at https://try.gitea.io:

[X ] Yes : https://try.gitea.io/Icoppola/Test2/pulls/2/files
Webhook Response
[ ] No

Log gist:

Description

When commenting inside of the modified files of a pull request, the event is not adding the message information in review > content
Steps to reproduce:

Create a new repository
Add user two as collaborator
Setup a webhook Custom Events > "Pull request comment" event enabled
Create a new file README.md in "master"
Create a new branch "feature1" out of master
Modify the file README.md in the "feature1" branch
Create a new pull request (1)
Login with user two
Go pull request (1) >> Files Changed >> Click in a line (+) >> Add a comment with this content "This is my comment content"
Check the webhook event response, will look like the screenshot below
...

Screenshots

Which webhook type did you use?

Hi, I used Gitea.
These are the settings:
Update Webhook - Test2 - Gitea_ Git with a cup of tea.pdf

content gets filled the review comment and not the inline comment:

But the inline comment is missing completly. If you create multiple inline "Start review" comments they are missing too. So I think the empty content is by design but the missing comment sections are a bug.

That's true, thanks for the help regarding the content attribute. That's been clarified.
So the bug is that the inline comments are not sent in the PR event.


Add curl command to nightly release page to download for macOS to prevent "...Apple cannot check it for malicious software"

We can't do this before going public because you need to log in to access the URL which is probably not easy to do with curl.

Done here: https://github.com/roc-lang/roc/blob/22423ca98bef41e2f55ae54e11c632bd0610c241/www/content/install/macos_x86_64.md#L11
And there's also a note on the releases page under "common issues / macos"


Our testing methods have become rather complex; we should test them.

This package would be very useful for that.

Duplicate of #205.


docs: add slack utm component in docs

Checklist

[ ] The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
[ ] Links to related issues (if applicable)
[ ] Tests for the changes have been added/updated (if applicable)
[ ] Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
[ ] For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@hsheth2 PTAL i changed it to the react component


Create the link between asyncApi spec file and simPlot file

There needs to be an extension for the async-api file so that you can link routes from the async api file with corresponding Plots which are going to define details about how the application simulation should occur.

@jonaslagoni  @NektariosFifes is this now under GSOC???

@jonaslagoni @NektariosFifes is this now under GSOC???

@AceTheCreator It is yes 😄

Ok :+1:

implementation in #27


entry.sh creates faulty httpd.conf

On the startup of the container the entry.sh tries to replace the default port 80 with the internal used port 8080. On restart it tries to do that again and breaks the config by doing so.
At the Moment on second startup the 'Listen' line is 'Listen 808080'
I think the sed command should be changed to:
sed -i 's/^Listen 80$/Listen 8080/g' /usr/local/apache2/conf/httpd.conf

This is resolved in v1.4.0

@Zohhak This should have been fixed with #40 .


Fix CairoRunner::initialize_all_builtins to prioritize program builtins order

Prerviously, we used the starkness initialization order by default, we should instead use the program builtins order and then complete the non-program builtins with the starkness order to mach the original implementation

we should instead use the program builtins order

Why? The code does look like it does what the PR describes, but it's not clear what makes it incorrect. Does it have something to do with ordering of memory segments for relocation?

we should instead use the program builtins order

Why? The code does look like it does what the PR describes, but it's not clear what makes it incorrect. Does it have something to do with ordering of memory segments for relocation?

In the original code for CairoFunctionRunner, they first use the CairoRunner's init method, which creates the builtins according to the program builtins, and then they initialize all the builtins on top of that, this replaces the values of the builtins (and adds the missing ones), but it doesn't change their order. As the builtin order is different in the program than in this second builtin initialization phase, when we just used this new builtin order, the bases for some builtins ended up different, the test I added is an example I found when analyzing some tests in the starknet-devnet


Add SSH upload/download functions

The spatie/ssh package provides upload() and download() methods for transfer of whole directories (via scp).
There should be matching functions for Castor to do the same.
Not exactly sure how these should be named however. Simply upload() and download() would not be an option since the relation to SSH is not clear (could also be HTTP, see request() function). A few options:

Add ssh_upload() and ssh_download()
Add ssh_client() as counterpart to http_client() which returns an Ssh instance. Then one could do e.g. ssh_client(host: ..., user: ..., ...)->upload(...). (Notice that this would have an unclear semantic wrt the ssh() function.)

Hello, thanks for your idea, this is a good one!
I would vote for 1/

Hi @mbrodala. Thanks for your issue. I didn't add those functions because the initial SSH POC was quite different from what was finally merged, so I reduced the scope a lot. But if there is some traction for it, I'm all in favor of adding your suggestion 1 :+1:

@mbrodala Do you want to give it a try?

I am going to close here for now due to the lack of feedback. Please let us know when you have more information and we can consider to reopen.

@pyrech Thanks a lot for tackling this! Currently my time is very limited. :bow:


#80 fix responsiveStyle for order

Sorry I missed this, but I think I tackled this with #82 – thanks for the PR though!


bcompare: init at <IP_ADDRESS>38

Motivation for this change
I was missing Beyond Compare merge/diff application in the repo.
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Assured whether relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Notes
This is initial commit. App works on my NixOS machine with xmonad. I have not tested it with other windows managers.

Hi @JohnAZoidberg , I've added all changes you've suggested. Thank you!

I've squashed all the improvement commits into one.

@ktor https://github.com/NixOS/nixpkgs/pull/62708#discussion_r308958753

@worldofpeace all done, thx!

Thanks for contributing @ktor :sparkles:


[Feature Request] Force db initializing on set filter

I have build a Filter class:
public class DisableFilter : IDisposable
{
    private string _filterName;
    private DbContext _context;

    public DisableFilter(string filterName, DbContext context)
    {
        _filterName = filterName;
        _context = context;
        _context.DisableFilter(_filterName);
    }

    #region IDisposable Members

    public void Dispose()
    {
        Dispose(true);
        GC.SuppressFinalize(this);
    }

    protected virtual void Dispose(bool disposing)
    {
        if (disposing)
        {
            _context.EnableFilter(_filterName);
        }
    }

    #endregion
}

To disable filters for a specified task:
using (var filter = FilterManager.DisableFilter(FilterManager.GlobalCompanyFilter))
{
   // query
}

but I have to ensure that the db is already initialized or an exception will be thrown. Maybe you can check the db status before setting a filter internally and initialize the db first?

This is the same issue as #34.  Watch that for more info.


[iOS] Fatal Error - Unexpectedly found nil while unwrapping an Optional value

Unexpectedly found nil while unwrapping an Optional value
This happened in the "load" in the "handle" method in SwiftOcarinaPlugin.swift

My solution is in #20

Done in #20


[improve][fn] support reading config options from file in Function Python Runner

Fixes #18533

Master Issue: #xyz
Motivation
please refer to this proposal: https://github.com/apache/pulsar/issues/18744
Modifications

Verifying this change

[ ] Make sure that the change passes the CI checks.

(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)

Added integration tests for end-to-end deployment with large payloads (10MB)
Extended integration test for recovery after broker failure

Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes

[ ] Dependencies (add or upgrade a dependency)
[x] The public API
[ ] The schema
[x] The default values of configurations
[ ] The threading model
[ ] The binary protocol
[ ] The REST endpoints
[ ] The admin CLI options
[x] Anything that affects deployment

Documentation

[ ] doc
[x] doc-required
[ ] doc-not-needed
[ ] doc-complete

Matching PR in forked repository
PR in forked repository: https://github.com/tpiperatgod/pulsar/pull/11

Codecov Report

Merging #18951 (e92efe8) into master (3011946) will decrease coverage by 9.96%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master   #18951      +/-   ##
============================================
- Coverage     46.75%   36.78%   -9.97%
+ Complexity    10514     1955    -8559
============================================
  Files           703      209     -494
  Lines         68858    14402   -54456
  Branches       7383     1569    -5814
============================================
- Hits          32193     5298   -26895
+ Misses        33065     8529   -24536
+ Partials       3600      575    -3025

Flag
Coverage Δ

unittests
36.78% <ø> (-9.97%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

.../org/apache/pulsar/client/impl/ConnectionPool.java
37.43% <0.00%> (-1.03%)
:arrow_down:

...ker/resourcegroup/ResourceGroupPublishLimiter.java

...ice/streamingdispatch/PendingReadEntryRequest.java

...naming/SpecifiedPositionsBundleSplitAlgorithm.java

...sar/broker/protocol/ProtocolHandlerDefinition.java

.../transaction/buffer/metadata/AbortTxnMetadata.java

...ava/org/apache/pulsar/broker/service/Producer.java

...load/jcloud/impl/StreamingDataBlockHeaderImpl.java

...istentStreamingDispatcherSingleActiveConsumer.java

...pulsar/broker/stats/ClusterReplicationMetrics.java

... and 485 more

Hi @tpiperatgod, did you have any plans to update the related docs?

Hi @tpiperatgod, did you have any plans to update the related docs?

I will try to submit a PR for the document, please help me review it then, thanks.

@tpiperatgod I'm happy to help. Feel free to ping me.

Hi @tpiperatgod 3.0 is planned to be released on May 2. We're aiming to align docs with code. Can you share some progress on the doc? TIA!

Hi @tpiperatgod, did you have any plans to update the related docs?

I will try to submit a PR for the document, please help me review it then, thanks.

@Anonymitaet Here is the docs pr, please help review: https://github.com/apache/pulsar-site/pull/541

@tpiperatgod thanks for your technical input! I've restructured the docs based on user learning habits and raised a question in https://github.com/apache/pulsar-site/pull/544#issuecomment-1524712753, PTAL.


Allow Refinery to report its health to k8s

When a peer starts to shutdown, Refinery needs to tell k8s to stop sending traffic to the shutting down peer so that it can have a chance to handle the data it already received

#1231


Clarification about logging in with onscreen keyboard

The STG webpage states "Logging in on your camera can be very hard with an onscreen keyboard."
I am not finding it hard, but impossible! I have an RX100 Mk III camera, and I can't find any way to show an onscreen keyboard at all. What am I doing wrong, or does this model not have an onscreen keyboard?
Thanks 🙂

Unfortunately I don't know. Each camera has a custom build of Android on it and it's hard to predict this. Web login should solve this for you though.


build: upgrade tracing-subscriber to 0.3

tracing-subscriber 0.3.0 was released 3 days ago in order to fix RUSTSEC-2020-0159. As test-env-log has a 0.2 dependency, it would be best if this dependency was updated to 0.3 to avoid usage of chrono and support new tracing-* releases.

May I ask why you believe this to be a breaking change? I don't think I see it.

I may have mischaracterized this as a breaking change. An example application that creates a test using #[test_env_log::test(tokio::test)] compiles with the following dependencies:
[dev-dependencies]
tokio = "1"
test-env-log = { version = "0.2", default-features = false, features = ["trace"] }
tracing-subscriber = { version = "0.2", features = ["parking_lot"] }

However, it fails to compile with these:
[dev-dependencies]
tokio = "1"
test-env-log = { version = "0.2", default-features = false, features = ["trace"] }
tracing-subscriber = { version = "0.3", features = ["parking_lot"] }

Outputting this error:
error[E0433]: failed to resolve: could not find `EnvFilter` in `tracing_subscriber`
   --> recaptcha/src/lib.rs:109:5
    |
109 |     #[test_env_log::test(tokio::test)]
    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ could not find `EnvFilter` in `tracing_subscriber`
    |
    = note: this error originates in the attribute macro `test_env_log::test` (in Nightly builds, run with -Z macro-backtrace for more info)

This error can be resolved by explicitly enabling the env-filter feature for tracing-subscriber 0.3:
[dev-dependencies]
tokio = "1"
test-env-log = { version = "0.2", default-features = false, features = ["trace"] }
tracing-subscriber = { version = "0.3", features = ["parking_lot", "env-filter"] }

However, if I use my fork of test-env-log with this change to tracing-subscriber 0.3, I do not need to manually enable the env-filter feature for the tracing-subscriber dependency.
Apologies for my winding explanation. I think I'll leave it up to you to decide if this is a breaking change.

Thanks for the explanation! In the end all we are doing on the test-env-log side is adjusting a recommendation (and some dev-dependencies which have no bearing on user code). We are not the ones pulling in the actual dependency. In fact, people should already be able to use test-env-log with tracing 0.3 as it stands, I believe.
Given that we are not making any actual code changes between the two versions, I am of the opinion that it's a backwards compatibility preserving change.

In fact, people should already be able to use test-env-log with tracing 0.3 as it stands, I believe... I am of the opinion that it's a backwards compatibility preserving change.

Agreed. Thanks for helping me get there! 😂

No worries. I pushed the change in slightly modified form. Thanks for your contribution!


Fix typos in documentation - Managing ODK-X Services

Page Managing ODK-X Services of the Documentation Managing ODK-X Services has the following typos;

In the section Resetting the App Server,  The username can be be changed by pressing the Change User button.  Repetition in the word be.

In the section Resetting the App Server,  A confirmation dialog will popup asking you to confirm resetting the App Server. Should be pop up.

In the section  Setting an Administrator Password,  After creating an admin password, the screen show show that it is enabled. Should be After creating an admin password, the screen shows that it is enabled.

In the section Managing Server Settings Allow unsafe/unsecure Authentication - if checked Services will.  Should be unsecured.

@wbrunette @clarlars  would like to send  PR for this

@sheykerkup go ahead and prepare a PR to fix the issues.

NOTE: The spelling of "popup" is correct when referring to a computing UI visual element, so there is one less change.

hello @wbrunette can I be assigned this please?

@wbrunette  Can I work on this issue

@Sukriti-sood I have assigned the issue to you


[ADD View] package_name

Note: To add multiple Views, open a separate issue for each view.
Details of the view(s) you want to add

toss_intro
https://pub.dev/packages/toss_intro
page - intro

added thanks


Updated react-scripts babel-jest && jest packages to 18.0.0

Updated react-scripts babel-jest and jest versions in order to fix "npm WARN deprecated<EMAIL_ADDRESS>Please update to minimatch 3.0.2 or higher to avoid a RegExp DoS issue" error because of nested dependency of minimatch 2.0.10 inside jest 17.0.2.
├─┬<EMAIL_ADDRESS>│ └─┬<EMAIL_ADDRESS>│   ├──<EMAIL_ADDRESS>│   ├─┬<EMAIL_ADDRESS>│   │ └──<EMAIL_ADDRESS>│   ├─┬<EMAIL_ADDRESS>│   │ ├─┬<EMAIL_ADDRESS>│   │ │ ├──<EMAIL_ADDRESS>│   │ │ └──<EMAIL_ADDRESS>

Had an issue where jest@18 tried to run a test from script\test.js throwing an error saying jest is already required. Fix was to explicitly remove scripts folder from the coverage folders. Can you check?

@gaearon Can you help with this?
https://travis-ci.org/facebookincubator/create-react-app/jobs/186292837
Tried removing the require, renaming the jest const, etc, with no results.
@bondz Thank you for the tip.

@lopezator jest is still trying to run a test from the script folder, although it shouldn't be. Add script here should work.

@bondz great, it worked! Finally the PR is ready :)

Thanks!

@bondz your link is broken now, can you explain what the link said please?

It was a suggestion on using testPathIgnorePatterns documented at https://facebook.github.io/jest/docs/en/configuration.html#testpathignorepatterns-array-string
Also, commenting on a closed PR pings a whole lot of people for an issue that is already resolved.


Add max_addons_dialogue_tokens parameter to the completion request

The parameter is needed for the Assistant service to control the maximum number of tokens dedicated to dialogue with addons.

Closed as Assistant development has been put on hold months ago.


Enable noImplicitAny on the tsconfig

We currently have a ton of any types floating around after the TypeScript conversion.  We should get those cleaned up, and enable noImplictAny on the repo.

Hey @JustinBeckwith
Just wanted to let you know that I am working on this in my spare time. I kind of got slammed with work so unfortunately, I had to put this on the back-burner. Completely understand if someone else wants to take this, otherwise, I'll have a working PR eventually. Sorry 😞


Implement ML-c4.5

A. Clare, R.D. King, Knowledge discovery in multi-label phenotype data, in: Proceedings of the 5th European Conference on PKDD, 2001, pp. 42–53.
Multi-Label C4.5   (ML-C4.5  ) [11] is an adaptation of the well known C4.5 algorithm for multi-label learning by allowing multiple labels in the leaves of the tree. Clare et al. [11] modified the formula for calculating entropy (see Eq. (1)) for solving multi-label problems. The modified entropy sums the entropies for each individual class label. The key property of ML-C4.5 is its computational efficiency:
entropy(E)=−∑Ni=1(p(ci)logp(ci)+q(ci)logq(ci))
where E   is the set of examples, p(ci) is the relative frequency of class label c  i and q(ci)=1−p(ci).

Hi
I did ML-C4.5 implementation in Java. Can I ask what probability you show at leaves? The modification which was proposed by Clare didn't mention the leaves distributions. I guess it is only marginal distribution. For example, if we prune or set the minimum number of examples to 5 , do we use the marginal distribution to predict labels?
Reem


[Feature]:Add Option for Adding rows and column via "+" button top corner of table

What problem does this feature solve?
makes better user experience and more easily adding rows and columns

can i take this


docker-compose -f single-peer-ca.yaml up Failed requesting read certificate

The program was fine in August. It suddenly crash down facing problem below:
E:\p\src\github.com\hyperledger\fabric-images\docker-compose>docker-compose -f single-peer-ca.yaml up
Recreating dockercompose_baseimage_1 ...
Starting dockercompose_membersrvc_1 ...
Recreating dockercompose_baseimage_1
Starting dockercompose_membersrvc_1 ... done
Starting dockercompose_vp_1 ...
Starting dockercompose_vp_1 ... done
Attaching to dockercompose_membersrvc_1, dockercompose_baseimage_1, dockercompose_vp_1
dockercompose_baseimage_1 exited with code 0
membersrvc_1  | 07:53:48.978 [server] main -> INFO 001 CA Server (0.6.1-preview)
membersrvc_1  | 07:53:49.076 [eca] Stop -> INFO 002 Stopping ECA services...
membersrvc_1  | 07:53:49.076 [eca] Stop -> INFO 003 ECA stopped
membersrvc_1  | 07:53:49.076 [aca] Stop -> INFO 004 Stopping the ACA services...
membersrvc_1  | 07:53:49.076 [aca] Stop -> INFO 005 ACA services stopped
membersrvc_1  | panic: runtime error: invalid memory address or nil pointer dereference
membersrvc_1  | [signal 0xb code=0x1 addr=0x0 pc=0x4dea5a]
membersrvc_1  |
membersrvc_1  | goroutine 1 [running]:
membersrvc_1  | panic(0xb22a40, 0xc82000a0a0)
membersrvc_1  |         /opt/go/src/runtime/panic.go:464 +0x3e6
membersrvc_1  | github.com/hyperledger/fabric/membersrvc/ca.(*CA).readCAPrivateKey(0xc82026a880, 0xbff648, 0x3, 0x2e, 0x0, 0x0)
membersrvc_1  |         /opt/gopath/src/github.com/hyperledger/fabric/membersrvc/ca/ca.go:335 +0x27a
membersrvc_1  | github.com/hyperledger/fabric/membersrvc/ca.NewCA(0xbff648, 0x3, 0xd3e150, 0x43d32d)
membersrvc_1  |         /opt/gopath/src/github.com/hyperledger/fabric/membersrvc/ca/ca.go:257 +0x78c
membersrvc_1  | github.com/hyperledger/fabric/membersrvc/ca.NewTCA(0xc8201b2fc0, 0xd3e128)
membersrvc_1  |         /opt/gopath/src/github.com/hyperledger/fabric/membersrvc/ca/tca.go:90 +0x3c
membersrvc_1  | main.main()
membersrvc_1  |         /opt/gopath/src/github.com/hyperledger/fabric/membersrvc/server.go:79 +0x752
dockercompose_membersrvc_1 exited with code 2
vp_1          | 07:53:58.773 [logging] LoggingInit -> DEBU 001 Setting default logging level to DEBUG for command 'node'
vp_1          | 07:53:58.800 [peer] func1 -> INFO 002 Auto detected peer address: <IP_ADDRESS>:7051
vp_1          | 07:53:58.814 [peer] func1 -> INFO 003 Auto detected peer address: <IP_ADDRESS>:7051
vp_1          | 07:53:58.816 [eventhub_producer] AddEventType -> DEBU 004 registering BLOCK
vp_1          | 07:53:58.816 [eventhub_producer] AddEventType -> DEBU 005 registering CHAINCODE
vp_1          | 07:53:58.816 [eventhub_producer] AddEventType -> DEBU 006 registering REJECTION
vp_1          | 07:53:58.816 [eventhub_producer] AddEventType -> DEBU 007 registering REGISTER
vp_1          | 07:53:58.817 [nodeCmd] serve -> INFO 008 Security enabled status: true
vp_1          | 07:53:58.817 [nodeCmd] serve -> INFO 00a Privacy enabled status: false
vp_1          | 07:53:58.817 [eventhub_producer] start -> INFO 009 event processor started
vp_1          | 07:53:58.824 [db] open -> DEBU 00b Is db path [/var/hyperledger/production/db] empty [false]
vp_1          | 07:53:58.828 [db] open -> INFO 00c Setting rocksdb maxLogFileSize to 10485760
vp_1          | 07:53:58.829 [db] open -> INFO 00d Setting rocksdb keepLogFileNum to 10
vp_1          | 07:53:59.370 [nodeCmd] func1 -> DEBU 00e Registering validator with enroll ID: vp
vp_1          | 07:53:59.370 [crypto] RegisterValidator -> INFO 00f Registering validator [vp] with name [vp]...
vp_1          | 07:53:59.393 [crypto] Debugf -> DEBU 010 [validator.vp] Data will be stored at [/var/hyperledger/production/crypto/validator/vp]
vp_1          | 07:53:59.408 [crypto] Debugf -> DEBU 011 [validator.vp] Keystore path [/var/hyperledger/production/crypto/validator/vp/ks] missing [false]: []
vp_1          | 07:53:59.408 [crypto] Debugf -> DEBU 012 [validator.vp] Keystore [/var/hyperledger/production/crypto/validator/vp/ks/db] missing [false]:[]
vp_1          | 07:53:59.408 [crypto] Debugf -> DEBU 013 [validator.vp] Keystore opened at [/var/hyperledger/production/crypto/validator/vp/ks]...done
vp_1          | 07:53:59.408 [crypto] Debug -> DEBU 014 [validator.vp]  Registering node crypto engine...
vp_1          | 07:53:59.409 [crypto] Debug -> DEBU 015 [validator.vp]  Initiliazing TLS...
vp_1          | 07:53:59.409 [crypto] Debug -> DEBU 016 [validator.vp]  Initiliazing TLS...Disabled!!!
vp_1          | 07:53:59.410 [crypto] Debug -> DEBU 017 [validator.vp]  Getting ECA client...
vp_1          | 07:53:59.410 [crypto] Debugf -> DEBU 018 [validator.vp] Dial to addr:[membersrvc:7054], with serverName:[tlsca]...
vp_1          | 07:53:59.410 [crypto] Debug -> DEBU 019 [validator.vp]  TLS disabled...
vp_1          | 07:53:59.410 [crypto] Debug -> DEBU 01a [validator.vp]  Getting ECA client...done
vp_1          | 07:53:59.463 [crypto] Errorf -> ERRO 01b [validator.vp] Failed requesting read certificate [rpc error: code = 14 desc = grpc: RPC failed fast due to transport failure].
vp_1          | 07:53:59.463 [crypto] Errorf -> ERRO 01c [validator.vp] Failed requesting ECA certificate [rpc error: code = 14 desc = grpc: RPC failed fast due to transport failure].
vp_1          | 2017/09/11 07:53:59 grpc: addrConn.resetTransport failed to create client transport: connection error: desc = "transport: dial tcp: lookup membersrvc on <IP_ADDRESS>:53: no such host"; Reconnecting to {"membersrvc:7054" }
vp_1          | 07:53:59.463 [crypto] Errorf -> ERRO 01d [validator.vp] Failed getting ECA certificate [rpc error: code = 14 desc = grpc: RPC failed fast due to transport failure].
vp_1          | 2017/09/11 07:53:59 Failed to dial membersrvc:7054: grpc: the connection is closing; please retry.
vp_1          | 07:53:59.463 [crypto] Errorf -> ERRO 01e [validator.vp] Failed retrieving ECA certs chain [rpc error: code = 14 desc = grpc: RPC failed fast due to transport failure].
vp_1          | 07:53:59.463 [crypto] Errorf -> ERRO 01f [validator.vp] Failed registering node crypto engine [rpc error: code = 14 desc = grpc: RPC failed fast due to transport failure].
vp_1          | 07:53:59.463 [crypto] Errorf -> ERRO 020 [validator.vp] Failed registering peer [vp]: [rpc error: code = 14 desc = grpc: RPC failed fast due to transport failure]
vp_1          | 07:53:59.463 [crypto] Errorf -> ERRO 021 [validator.vp] Failed registering [vp]: [rpc error: code = 14 desc = grpc: RPC failed fast due to transport failure]
vp_1          | 07:53:59.464 [crypto] RegisterValidator -> ERRO 022 Failed registering validator [vp] with name [vp] [rpc error: code = 14 desc = grpc: RPC failed fast due to transport failure].
vp_1          | Error: rpc error: code = 14 desc = grpc: RPC failed fast due to transport failure
vp_1          | Usage:
vp_1          |   peer node start [flags]
vp_1          |
vp_1          | Flags:
vp_1          |   -h, --help                help for start
vp_1          |       --peer-chaincodedev   Whether peer in chaincode development mode
vp_1          |
vp_1          | Global Flags:
vp_1          |       --logging-level string       Default logging level and overrides, see core.yaml for full syntax
vp_1          |       --test.coverprofile string   Done (default "coverage.cov")
vp_1          |   -v, --version                    Display current version of fabric peer server
vp_1          |
dockercompose_vp_1 exited with code 1

vp_1          | 07:53:59.463 [crypto] Errorf -> ERRO 01b [validator.vp] Failed requesting read certificate [rpc error: code = 14 desc = grpc: RPC failed fast due to transport failure].
vp_1          | 07:53:59.463 [crypto] Errorf -> ERRO 01c [validator.vp] Failed requesting ECA certificate [rpc error: code = 14 desc = grpc: RPC failed fast due to transport failure].
vp_1          | 2017/09/11 07:53:59 grpc: addrConn.resetTransport failed to create client transport: connection error: desc = "transport: dial tcp: lookup membersrvc on <IP_ADDRESS>:53: no such host"; Reconnecting to {"membersrvc:7054" }
vp_1          | 07:53:59.463 [crypto] Errorf -> ERRO 01d [validator.vp] Failed getting ECA certificate [rpc error: code = 14 desc = grpc: RPC failed fast due to transport failure].
vp_1          | 2017/09/11 07:53:59 Failed to dial membersrvc:7054: grpc: the connection is closing; please retry.
vp_1          | 07:53:59.463 [crypto] Errorf -> ERRO 01e [validator.vp] Failed retrieving ECA certs chain [rpc error: code = 14 desc = grpc: RPC failed fast due to transport failure].
vp_1          | 07:53:59.463 [crypto] Errorf -> ERRO 01f [validator.vp] Failed registering node crypto engine [rpc error: code = 14 desc = grpc: RPC failed fast due to transport failure].
vp_1          | 07:53:59.463 [crypto] Errorf -> ERRO 020 [validator.vp] Failed registering peer [vp]: [rpc error: code = 14 desc = grpc: RPC failed fast due to transport failure]
vp_1          | 07:53:59.463 [crypto] Errorf -> ERRO 021 [validator.vp] Failed registering [vp]: [rpc error: code = 14 desc = grpc: RPC failed fast due to transport failure]
vp_1          | 07:53:59.464 [crypto] RegisterValidator -> ERRO 022 Failed registering validator [vp] with name [vp] [rpc error: code = 14 desc = grpc: RPC failed fast due to transport failure].
vp_1          | Error: rpc error: code = 14 desc = grpc: RPC failed fast due to transport failure


Distinguish Arc clones from expensive clones

This should make future performance refactoring easier,
by allowing us to more easily identify which clones
we would want to potentially eliminate.

(just an opinion from an outsider)
If I wanted to do this, I would use an extension trait for it (and maybe #![no_implicit_prelude] as any solution without it is unenforceable).
So, something like this:
use std::sync::Arc;
use std::rc::Rc;

// maybe a better name is needed
trait IncrClone: Clone {
    fn incr_clone(&self) -> Self {
        self.clone()
    }
}

impl<T> IncrClone for Arc<T> {}
impl<T> IncrClone for Rc<T> {}

Yes it's less explicit, but it's more generic, the diff becomes simpler, chain-abilitiy is not lost, and future diffs would be smaller if anything other than std::sync::Arc starts to get used.

And maybe another trait for more distinction (if inner clones are used at all):
trait InnerClone<T: Clone>: Deref<Target=T> {
    fn inner_clone(&self) -> T {
        self.deref().clone()
    }
}

impl<T: Clone> InnerClone<T> for Arc<T> {}
impl<T: Clone> InnerClone<T> for Rc<T> {}


My commands do not work since the last update

Hello,
First, thanks for you great work, your plugin removes a lot of frictions in my day to day tasks.
Since the last update, the two commands I have set up do not work anymore, could you please help me understand why ?
Here are they :
obsidian://actions-uri/daily-note/create?vault=MY%20SECOND%20BRAIN%20V3&if-exists=skip
obsidian://actions-uri/weekly-note/create?vault=MY%20SECOND%20BRAIN%20V3&if-exists=skip
Please take in consideration that nothing has changed in my environment except this update.
The Periodic note plugin is still enabled, and my vault still named the same.
Kind regards,
-Jules

Hi @Ornicar85, it still works fine for me, and I haven't really touched anything in the last update. Could you please copy/paste the debug info from Obsidian here? Command palette → Show debug info.

Hello Carlo,
Thank you very much for your prompt reply and for your time.
Here is the debug info:
SYSTEM INFO:
      Obsidian version: v1.4.16
      Installer version: v1.4.13
      Operating system: Windows 10 Home 10.0.22621
      Login status: logged in
      Catalyst license: none
      Insider build toggle: off
      Live preview: on
      Legacy editor: off
      Base theme: light
      Community theme: Minimal v7.3.3
      Snippets enabled: 0
      Restricted mode: off
      Plugins installed: 22
      Plugins enabled: 21
            1: Dataview v0.5.64
            2: QuickAdd v1.6.0
            3: Metadata Menu v0.6.4
            4: Text Generator v0.5.14-beta
            5: Whisper v1.5.1
            6: Templater v1.18.1
            7: Smart Connections v1.6.37
            8: Plugin Update Tracker v1.5.2
            9: Commander v0.5.1
            10: Calendar v1.5.10
            11: Note Refactor v1.8.2
            12: Workspaces Plus v0.3.3
            13: Excalidraw v2.0.4
            14: Link Favicons v1.8.3
            15: Readwise Official v2.0.1
            16: Recent Files v1.3.8
            17: Advanced Tables v0.19.1
            18: Periodic Notes v0.0.17
            19: Todoist Link v2.2.0
            20: Copilot v2.4.4
            21: Actions URI v1.4.0
RECOMMENDATIONS:
      Custom theme and snippets: for cosmetic issues, please first try updating your theme and disabling your snippets. If still not fixed, please try to make the issue happen in the Sandbox Vault or disable community theme and snippets.
      Community plugins: for bugs, please first try updating all your plugins to latest. If still not fixed, please try to make the issue happen in the Sandbox Vault or disable community plugins.
Kind regards,
-Jules

De : Carlo Zottmann @.>
Envoyé : jeudi 30 novembre 2023 16:42
À : czottmann/obsidian-actions-uri @.>
Cc : Ornicar85 @.>; Mention @.>
Objet : Re: [czottmann/obsidian-actions-uri] My commands do not work since the last update (Issue #81)
Hi @Ornicar85https://github.com/Ornicar85, it still works fine for me, and I haven't really touched anything in the last update. Could you please copy/paste the debug info from Obsidian here? Command palette → Show debug info.
—
Reply to this email directly, view it on GitHubhttps://github.com/czottmann/obsidian-actions-uri/issues/81#issuecomment-1834025168, or unsubscribehttps://github.com/notifications/unsubscribe-auth/BANY634ZICGMJEBJDYSHKD3YHCSM7AVCNFSM6AAAAABABBVH42VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMZUGAZDKMJWHA.
You are receiving this because you were mentioned.Message ID: @.***>

Thanks! Hmm, nothing out of the ordinary there. My current working theory is that there's another plugin intercepting the calls to Actions URI, but that's just a very vague guess. More research is necessary! :)
If you're up for it, please install my logging helper plugin Logstravaganza. (This will pipe Obsidian's logging output into a new note.) Once it's installed:

Enable it — this will create a new note LOGGING NOTE (your device name).md in your vault root folder.
Disable, then re-enable Actions URI.
Call the URLs again, the ones that failed.

At this point, the note created by Logstravaganza should contain a table with several rows. At least one of them should contain output by Actions URL. If so, disable Logstravaganza, and send me the note. If you don't want to upload it here, send it via email to<EMAIL_ADDRESS>

@Ornicar85 Attachments are dropped by GitHub when replying by email, I'm afraid. Could you either upload it right here on GH or send it via email to<EMAIL_ADDRESS>please?

Issue was fixed via email, closing.


Update ordered and levels API

rename ordered() into isordered()
ordered!(A, x) and levels!(A, x) return A (that also affects droplevels!())

Closes #24

Current coverage is 84.33% (diff: 94.11%)

Merging #26 into master will decrease coverage by 0.34%

@@             master        #26   diff @@
==========================================
  Files             7          7
  Lines           359        351     -8
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
- Hits            304        296     -8
  Misses           55         55
  Partials          0          0

Powered by Codecov. Last update ba8fb2d...0b394d0

Wow, it looks like DataFrames is not affected by the change!

Ah, and please add deprecations for the old methods to a new src/deprecated.jl file.

Yes, data frames only work with nominal data, they don't care about ordering.

@nalimilan Thanks for the review. I've updated the PR.

Thanks!


Bootstrap fullscreen modal

As described in bootstrap documentation, in order to make a modal full-screen, it is necessary to add the modal-fullscreen class on the modal-dialog element.
However, there is currently no way to add a class on that specific element, cf the corresponding line in the Svelte template (it is the same with other frameworks).

Should we start a new way of customizing the class inside our templates ? or just fix this single issue...

shouldn't be just a prop in this specific case for a bootstrap component?


Export problem on windows11

The author has pointed out in https://github.com/JichouP/obsidian-marp-plugin/issues/10#issuecomment-1451662679 that a Node.js installation is required to export slides. But maybe Node.js installation is not the only requirement to export slides on windows11.
Description
Before I installed the Node.js, it showed "successfully export" and nothing come out in the download directory when I pressed the export buttons. After I installed Node.js and set Node.js to system PATH, it is the same as before.

The version of npx in my system is 10.2.2 .

In addition, it is really a wonderful plugin for ob.
Please forgive the possible English grammar errors above.

Something strange has happened.
Somehow, after many invalid exports, I successfully exported HTML. After this successful export operation, PPT and PDF can also be exported.

Same problem over there. I have installed the packages shown. The obsidian preview is fine; however, the download option does seem not working fine yet for win 11


[Features] - Add a tag element

It would be useful to have a tag element to be able to put the favicon tags in the correct location. This is especially interesting when combined with astro-capo.
https://github.com/natemoo-re/astro-capo

Heyyyy, @Robin-Wils
Migrate to astro-favicons 3.0+ now, See 3.0.2 for change log
If you have any questions, improvements, or contributions, please give us feedback, thanks

Hi thanks for the quick update.
Astro-capo
The astro-capo support turned out a bit different than expected, but it is nice. What I expected was just a tag which would have the favicons meta tags, example:
<Head>
    <MyFavIconsComponent />
    <meta name="some other meta tag" content="some content" />
    <script type="application/ld+json" set:html={schemaJson} />
</Head>

That is how astro-seo has support for astro-capo, without having to include astro-capo itself.
New options
But the update is appreciated! The new options look cool, but aren't documented well yet. Previously I could set description, but I no longer know how I can do that now.


Fix Carthage support

Could not install OHHTTPStubs using Carthage if iOS 7 simulator is installed. The cause of failure is xcodebuild misunderstands deployment target as 6.0, which is from OHHTTPStubs iOS Tests, so I separate tests target for iOS framework from OHHTTPStubs iOS Tests. This might be a bug of xcodebuild, but we need a workaround for now.
NOTE: this is not bug of Carthage because this can be reproduced by xcodebuild -scheme "OHHTTPStubs iOS Framework" -workspace OHHTTPStubsDemo.xcworkspace.
Cartfile:
github "AliSoftware/OHHTTPStubs" "master"

Output:
*** Fetching OHHTTPStubs
*** Checking out OHHTTPStubs at "02cc9fcc0cdfca79e1968df9e3e072c256e5e593"
*** xcodebuild output can be found in /var/folders/0j/p83b0p397sz3y910bvz9_1wh0000gn/T/carthage-xcodebuild.LTKmmE.log
*** Building scheme "OHHTTPStubs iOS Framework" in OHHTTPStubsDemo.xcworkspace
xcodebuild: error: Failed to build workspace OHHTTPStubsDemo with scheme OHHTTPStubs iOS Framework.
	Reason: The run destination iPad 2 is not valid for Running the scheme 'OHHTTPStubs iOS Framework'.

Mmmmh. So as I understand it, you duplicated the iOS Unit Tests target to assign this copy to the iOS Framework target and change its Deployment Target, right?
Probably an xcodebuild bug indeed.
Maybe it would be simpler just to remove the test target from the framework scheme altogether rather than having two duplicate targets to maintain.
After all, the Unit Tests target only contains functional tests (there is no integration test or whatnot in there), so as long as one can run those tests, it should be ok. The only important thing here is that the test can be run, making them run from the static lib or framework shouldn't change their behavior, so only having them associated with the StaticLib scheme should be sufficient, right?

Hey, just for my information, because I'm not that familiar with Cartage yet:

Could not install OHHTTPStubs using Carthage if iOS 7 simulator is installed

Isn't Carthage only supposed to use iOS dynamic Frameworks? And as frameworks are only supported since iOS8, how come you try to run it with iOS7 simulator then?

Yes, you are right. I will remove duplicated test target and remove test target from iOS framework scheme.

Thanks.
Note the original error still seems to make sense for me, regardless of the test target stuff:
xcodebuild: error: Failed to build workspace OHHTTPStubsDemo with scheme OHHTTPStubs iOS Framework.
    Reason: The run destination iPad 2 is not valid for Running the scheme 'OHHTTPStubs iOS Framework'.

if your destination is using the iOS7 runtime, this error makes sense as iOS7 is not compatible with dynamic frameworks that was introduced with iOS8, so I'm not sure your error originates from the test target after all.

Carthage supports dynamic framework only, thus it supports iOS 8 or later and all of OS X. And I did not try to build OHHTTPStubs.framework for iOS 7 runtime (iOS 8 or later only).
The problem is we can not build framework by xcodebuild -scheme "OHHTTPStubs iOS Framework" -workspace OHHTTPStubsDemo.xcworkspace. This is caused by xcodebuild bug and that OHHTTPStubs iOS Framework scheme has test action with lower deployment target. Please try the command above on both of master and forked repository.

I noticed this also happened on Travis CI before.
https://travis-ci.org/AliSoftware/OHHTTPStubs/builds/52363629
This error is avoided by adding -destination option of xcodebuild, but Carthage cannot do that.

Maybe you should file an issue to Carthage then. If that issue is with xcodebuild and Carthage then OHHTTPSTUBS is not the only framework this issue will be happening then: it's gonna be problematic with every library out there on github.

Unfortunately, they decided that they will not add workaround for the similar issue.
https://github.com/Carthage/Carthage/issues/259
Anyway, their requirement is very simple, just making xcodebuild -scheme SCHEME -workspace WORKSPACE build succeeded. So I think this should be fixed by modifying library.

Damn. I don't like that our libraries (I mean not just mine but any other lib developer's too) have to do workarounds for a tool that don't want to fix issues on their end :cry:  Sad that Carthage does not want to fix that at the common place :unamused:
That means that if one wants Carthage support, we need to report this workaround on every of our libraries instead of fixing it at only one place directly on the tool that have the problem. And they told us that "there was nothing to do for lib developers to support Carthage out of the box" ahah…
I'll probably merge your PR anyway as it's ready to go, but integrating with CocoaPods or manual integration for example does not generate this issue when integrating iOS frameworks, so from my point of view it should still be up to Carthage to fix it…

Thank you for merging. I hope this will be fixed in future version of Xcode.


Move Pulse libraries to lib/steel/pulse

share/steel/examples/pulse/dice is using a lib directory, which is slated to become a Pulse library. That lib directory used to be located at share/steel/examples/pulse/lib, but the dice Makefiles were hardcoding the full path to that lib directory, so that broke the opam CI (i.e. made share/steel no longer work without the Steel source repository.) Thus, in 9cf5fda9, I moved the latter under share/steel/examples/pulse/dice/lib.
Ideally, this lib directory should move under lib/steel/pulse, and suitable Pulse namespaces should be added to those file names. However, when trying that, I hit #18 .

We've made some progress on this with all pulse user-facing libraries now consolidated in share/steel/examples/pulse/lib
It would be nice to move the current contents of lib/steel/pulse elsewhere. Tahina, you had some proposal for that to be compatible with opam etc.
And then to move the current share/steel/examples/pulse/lib to lib/steel/pulse

The new repository for Pulse solves this issue at FStarLang/pulse@a5de32a2638757200d38ca5e693e35871d747449
So, this issue can be closed as completed once #168 is merged.


[+WATCH_FULLVIDEOs!] Oviya Helen Viral Leaked Video On Social Media X Twitter [ZNOW2K]

2 sec ago Oviya Helen Leaked Video Viral On Social Media. [+WATCH_FULLVIDEOs!] Oviya Helen Viral Leaked Video On Social Media X Twitter [ZNOW2K]

Oviya Helen’s latest video has gone viral, igniting conversations across numerous social media platforms. This rising digital creator, recognized for her engaging content—particularly her recent Spiderman-themed clip—has experienced a surge of interest from fans eager to find the full version. Many are flocking to platforms like Instagram, X (formerly Twitter), and Discord to check out her latest creations.
As the buzz intensifies, fans are actively sharing their reactions online, highlighting the vital role social media plays in elevating creators like Oviya Helen. With her distinctive style and creative approach, she has quickly made a notable impact in the digital landscape, leaving many curious about her upcoming projects.


Neomake not expanding %

I set my makeprg set to echo\ % and running :make works just fine and I can see it execute echo path/to/file and :copen shows path/to/file, but when I run :Neomake! it doesn't appear to find the file. and :copen shows %.
So it appears that the % is not being expanded but is being treated literally. Is there something simple I'm missing?

Neomake doesn't currently attempt to expand anything. However, to get %, you can do this instead:
let g:neomake_python_echo_maker = {
    \ 'exe': 'echo',
    \ 'args': [],
    \ 'errorformat': &errorformat,
    \ }

And then run :Neomake (note: no exclamation point). With :Neomake, the current file is appended to the arguments list before the job is run and the results are placed in the location list instead of the quickfix list, so you can see them by running :lopen instead of :copen.

Ok, I'll try that. Thanks.
I'm new to Neovim (and Neomake), so maybe this is stupid, but is the not expanding because Neovim can't, because it just hasn't been implemented yet, or because it was a design choice to intentionally not do it?
If you're open to an implementation of it I may give it a shot.

When I was first coding this up it seemed to add more complexity than I wanted to deal with at the time. I haven't looked into it since. I'd be open to an implementation if there was a fairly simple way to do it.


Provide a demo of EVerest's existing automated testing capabilities

This changeset includes a new demo that automatically runs the test in everest-core's startup_tests.py Pytest module, demonstrating how an aspect of EVerest's runtime behavior can be tested using EVerest's built-in Pytest tooling.

The original intent for this work was to showcase an automated E2E test using EVerest's testing tools that actually runs through a charging session.
@couryrr-afs: I believe you created a new test that accomplishes this. Would it be feasible to contribute it as part of these changes?

@drmrd the code for that is in the everest-utils repo. I was running a container built locally based on the updated code base. I think we would need to go through some work to get that committed. As a proof of concept it was successful. We can work to get it all working together.

@couryrr-afs the existing automated tests (as such they are) are run on every PR, so I would expect them to work. The real goal of this task was to start experimenting with end-to-end, non-unit tests, preparatory to creating a full end-to-end test suite.
I don't see the challenge with committing the proof of concept. If you have it working locally, you can either include it in the current container (we can check out two repos) or create a new container for it, or if you really have to, docker commit a container that is manually set up the way you need it.
Is there an ETA for when the actual ask will be available?

@shankari: As far as I'm aware, despite some of the step and image names in their GitHub Actions, EVerest's CI system only executes the startup test module that @couryrr-afs included in this PR:

The pipeline first runs the test_and_install script, whose only tests were commented out six months ago.
The pipeline then runs the e2e-test-server from .ci/e2e, which in turn calls .ci/scripts/tests.sh. Despite its name, the latter script explicitly runs pytest against the startup_tests module, which is what Coury based his automated tests on.
There is an actual E2E charging test in the same tests directory, but it was also commented out six months ago.

@couryrr-afs: Were there any changes outside of everest-core that had to be made to fix the E2E tests? If not but you think your changes require more work before being merged into everest-core, you could still modify the manager Dockerfile to apply them. This can be done by, for instance, copying files into the image and moving them to the right directories before compiling the manager binary or by copying a patch file into the image that contains your changes and applying it to everest-core before compilation.
In terms of adding these changes back into EVerest, we can look at adding them to our backlog if they haven't been already.

@drmrd and @shankari There was no changes in functionality to the test themselves for this update. This is exposing the ability to have a docker container spin up and execute the existing pytests. In this case it is running a startup of everest and a startup and charging based on what was already there.
There were additional changes to run anther test that I created which had a failure case. It also included work to expose more of the messages in the tests which allows for more fine-grained assertions. If this is something I can commit I am happy to do so.

@couryrr-afs I believe these tests already run in a docker container as part of the everest-core CI
https://github.com/EVerest/everest-core/blob/e52b21bd6ad4cdbfc98a132cae55032e1efca918/.ci/e2e/scripts/tests.sh#L4
As you can see from the related issue (https://github.com/US-JOET/everest-demo-private/issues/10), the goal here was not to simply run the existing tests in a container, but rather, to set up a test framework that can run the three demo scenarios that we currently have, but automated and without a UI.
This was intended to lay the framework for additional TDD going forward, and to have additional tests that we can add to CI/CD.

There were additional changes to run anther test that I created which had a failure case. It also included work to expose more of the messages in the tests which allows for more fine-grained assertions. If this is something I can commit I am happy to do so.

This seems more like the original goal. Can you clarify the reason why this might not be committed?

@shankari based on the issue I was given the goal was to re-use the demo services, docker compose, to automate the execution of the tests. This way they are not tied to the CI pipeline and anyone can run them by running the containers. The added functionality with messaging was in EVerest and the changes were not communicated to the community so we decided to hold off on pushing.

The added functionality with messaging was in EVerest and the changes were not communicated to the community so we decided to hold off on pushing.

I understand that the changes were not communicated to the community yet, but what better way to communicate than to 🎉 demo it working 🥳 ? We don't need to make changes to everest to set up a demo - just make a copy of the changed files in the demo repo and copy them in to the correct places while building the image - we do that all over the place in this repo.
Once we have coordinated with the community to get them into the upstream repo, we can remove the hack in here.

@shankari we do that for a lot of config files. This is related to source file for the code. If you are okay with that I can attempt to do so.

I am OK with this as a documented temporary hack, pending discussion and merge of source code.
And I think we should use this approach in general to make progress on demos while: (1) waiting for the build process to be finalized, (ii) coordinating reviews with the broader community

@shankari I am attempting to get a new build for this out but am running into issues with the image. I like the hacky way for the time being.

@shankari: This PR should be ready to merge after #4.

@shankari: This PR is also ready for you to merge (and to review, if you haven't seen the E2E test that was added).

@drmrd I did review these two test cases last week. Happy to merge and make progress on this!

@shankari Wonderful. Thanks much for all of the rapid-fire merging today! Very exciting to get these over the line.


Add vintage U.S. Route shield for historic routes

Added a vaguely 1948-era U.S. Route shield for Historic U.S. Routes. This shield is the same as the one we’ve been using (just a modern U.S. Route shield recolored from black to brown), but with a crossbar up top, similar to what we’ve done with the Maryland state route shield.
Here’s a before and after:

This treatment is consistent with many states’ signs for these historic routes. Some states go further back to the 1926 style with a blocky typeface, but we haven’t been tailoring shields to each country’s typefaces anyways. Originally, I had considered adding a “HIST” banner at the top, but I think the crossbar is distinctive enough.

Fixes #921.

Looks great!

Originally, I had considered adding a “HIST” banner at the top, but I think the crossbar is distinctive enough.

I think this is a good idea.  For those of us in the know, the brown and the crossbar is distinctive enough, but for those who spend less time thinking about highway shields it's probably not clear what the different style means.  Perhaps the legend is enough to answer that question for folks, but a HIST banner would make it clearer and would match the "historic" wording that is generally on the signs.

I think the retro shield looks great but it doesn't solve the problem of the brown being too subtle. So I'd say we either need a banner or some way to make the brown be more obvious.

White text on a brown shield? It would not be entirely unrealistic.

I think this is a good idea. For those of us in the know, the brown and the crossbar is distinctive enough, but for those who spend less time thinking about highway shields it's probably not clear what the different style means. Perhaps the legend is enough to answer that question for folks, but a HIST banner would make it clearer and would match the "historic" wording that is generally on the signs.

I think we’re basically at the point of the difference between an Interstate and an Interstate Business Loop/Spur, where the user will at least notice there’s something unusual about the shield, cuing them to consult the legend. That said, I’m still open to adding a “HIST” banner. It’s just that we only support drawing the banner in black at the moment, which is kind of awkward.

White text on a brown shield? It would not be entirely unrealistic.

I like how this would look visually, but it does take some liberties with the shield, which is white in every state.

Note that the former U.S. Route 412 Scenic in Oklahoma was also set against a brown sign back. Idaho also used to signpost the Thousand Islands Scenic Byway concurrency with U.S. 30 (not U.S. 30 Scenic) as a white-on-brown shield, though ITD has since replaced it with a standard U.S. Route shield.

I like how this would look visually, but it does take some liberties with the shield, which is white in every state.

While the white on brown may not be perfectly accurate, it very nicely communicates the familiar feel of the historic shield.

White on brown looks nice (reminds me of the USFS shields), but given how closely this style replicates real world shields the brown on white seems the better choice to me.

I’m still open to adding a “HIST” banner. It’s just that we only support drawing the banner in black at the moment, which is kind of awkward.

Good point.  A brown banner would look better.  Perhaps adding color support for banners can be a future improvement.  There are other shields where the banner matching the primary color would look better and be more accurate. Green on Vermont shields for example:

Good point. A brown banner would look better. Perhaps adding color support for banners can be a future improvement. There are other shields where the banner matching the primary color would look better and be more accurate. Green on Vermont shields for example:

Agreed.  This would be a welcome feature for the shield library.  Currently it only accepts a global default color, but what's needed is a per-network override option.  I suspect it would be relatively easy to implement.

A brown banner would look better. Perhaps adding color support for banners can be a future improvement. There are other shields where the banner matching the primary color would look better and be more accurate. Green on Vermont shields for example:

#357 tracks drawing banners in colors other than black. In the meantime, I’ve added the “HIST” banner in black.


yuktabajaj/bomnamechange

Problem
Names are not uniform across bom files.
Solution
Follow a standard pattern from name of S/4 hana bom - "SAP S/4 Hana  SPS "
Tests

Notes

Closing as #222 covers the same topic and is merged into experimental


Replace illegal characters in filenames with Unicode lookalikes

This pull request addresses issue #321 and #291 complaining about special characters in filenames.
Filenames in Obsidian are of primary importance as they are also used as note titles. Therefore, the current brute force approach of filename sanitization destroys note titles whenever illegal characters are involved.  This cause unnecessary manual cleanup effort.
This pull request upgrades sanitizeFileName to replace illegal characters with legal Unicode characters that look similar.

Hi @WetHat, thank you for the contribution. I don't think we should head in this direction though as it will likely lead to increased confusion with the unexpected characters. I'll leave a comment in the ticket with some more guidance.


Direct fd produced by IORING_FILE_INDEX_ALLOC can not be used as fixed file

I used io_uring_register_files_sparse to register an empty file table first, then use io_uring_prep_openat_direct with IORING_FILE_INDEX_ALLOC to produce a direct fd.
It seems that direct fd produced by IORING_FILE_INDEX_ALLOC is not in the range of file table registered by io_uring_register_files_sparse, and that direct fd can only be used as a regular file, but not a fixed file.
Using the direct fd produced by IORING_FILE_INDEX_ALLOC, a -EBADF will be returned when using the direct fd with IOSQE_FIXED_FILE, while a success will be returned without IOSQE_FIXED_FILE set.
If file_index is specified, not using IORING_FILE_INDEX_ALLOC, then the direct fd can correctly be used as a fixed file.
Here's an example:
#include <unistd.h>
#include <fcntl.h>
#include <string.h>
#include <stdio.h>
#include <sys/socket.h>
#include <liburing.h>
#include <errno.h>
#include <netinet/in.h>

const char *file_path = "/var/www/html/404.html";

int get_fixed_file_by_open_direct(struct io_uring *ring)
{
    // openat direct
    struct io_uring_sqe *sqe = io_uring_get_sqe(ring);
    // io_uring_prep_openat_direct(sqe, -1, file_path, 0, O_RDONLY, 0);
    io_uring_prep_openat_direct(sqe, -1, file_path, 0, O_RDONLY, IORING_FILE_INDEX_ALLOC);
    int ret = io_uring_submit(ring);
    if (ret == -1)
    {
        printf("error");
        return 0;
    }

    // wait cqe
    struct io_uring_cqe *cqe;
    io_uring_wait_cqe(ring, &cqe);

    printf("openat_direct fixed file is %d\n", cqe->res);
    int fixed_file_idx = cqe->res;

    io_uring_cq_advance(ring, 1);
    return fixed_file_idx;
}

void read_file(struct io_uring *ring, int fixed_file_idx, __u8 flags)
{
    // submit with IOSQE_FIXED_FILE
    struct io_uring_sqe *sqe = io_uring_get_sqe(ring);
    char buf[100];
    io_uring_prep_read(sqe, fixed_file_idx, buf, 100, 0);
    sqe->flags = flags;

    int ret = io_uring_submit(ring);
    if (ret == -1)
    {
        printf("error");
        return;
    }

    // wait cqe
    struct io_uring_cqe *cqe;
    ret = io_uring_wait_cqe(ring, &cqe);
    if (ret == -1)
    {
        printf("error");
        return;
    }
    printf("output: %d\n", cqe->res);
    io_uring_cq_advance(ring, 1);
}

int main()
{

    // setup pipe
    int pipefd[2];
    int ret = pipe(pipefd);
    if (ret == -1)
    {
        printf("error");
        return 0;
    }

    // setup io_uring
    struct io_uring ring;
    struct io_uring_params params;
    memset(&params, 0, sizeof(params));
    params.flags = IORING_SETUP_SQPOLL;
    if (io_uring_queue_init_params(128, &ring, &params) < 0)
    {
        printf("error");
        return 0;
    }

    // register file sparse
    ret = io_uring_register_files_sparse(&ring, 1);
    if (ret == -1)
    {
        printf("error");
        return 0;
    }

    int fixed_file_idx = get_fixed_file_by_open_direct(&ring);

    // cqe->res=-EBADF
    read_file(&ring, fixed_file_idx, IOSQE_FIXED_FILE);

    // cqe->res>=0
    read_file(&ring, fixed_file_idx, 0);

    return 0;
}

You forgot some rather interesting details, like the kernel version being used?

I am using kernel version 6.2.9-060209-generic, and liburing version 9134244a4e16e68cb514ea5192fcd7e9beca96f5

Great thanks, I'll take a look. Thanks for the reproducer!

io_uring_prep_openat_direct(sqe, -1, file_path, 0, O_RDONLY, IORING_FILE_INDEX_ALLOC);

I think you want that as:
io_uring_prep_openat_direct(sqe, -1, file_path, 0, O_RDONLY, IORING_FILE_INDEX_ALLOC - 1);

and we should have an _alloc() helper for that.

This is really a bug in liburing, it should factor in if IORING_FILE_INDEX_ALLOC is being used or not and do the right thing.

io_uring_prep_openat_direct(sqe, -1, file_path, 0, O_RDONLY, IORING_FILE_INDEX_ALLOC);

I think you want that as:
io_uring_prep_openat_direct(sqe, -1, file_path, 0, O_RDONLY, IORING_FILE_INDEX_ALLOC - 1);

and we should have an _alloc() helper for that.

Oh, I see. So the correct usage is IORING_FILE_INDEX_ALLOC - 1. The docs may be misleading, I used IORING_FILE_INDEX_ALLOC directly as file_index because the man page of io_uring_prep_openat_direct said:

If IORING_FILE_INDEX_ALLOC is used as the file_index for a direct  open,  then  io_uring
will  allocate  a free direct descriptor in the existing table. The allocated descriptor
is returned in the CQE res field just like it would be for a non-direct open request. If
no  more  entries  are available in the direct descriptor table, -ENFILE is returned in‐
stead.

The docs should be correct, it's the helpers that are bad. See the commit I pushed. I don't think it makes a lot of sense to have applications be aware of this +/- 1 detail of how it needs to be passed to the kernel.

exactly


Hierarchically budget fuzzer bytes with Autofuzz

Currently, whenever Autofuzz needs to decide how many bytes from the
fuzzer input to spend on the construction of an object, it uses half of
the remaining bytes. While this ensures that primitives with non-trivial
values can be generated with arbitrarily many nested object
constructions, this strategy does not make good use of the fuzzer input
in the case of flat call graphs (e.g. a foo(String, int) method).
Experiments show that ignoring half of the fuzzer input hurts efficiency
quite a bit.
This commit switches to a new strategy that hierarchically assigns a
"budget" for every consume or autofuzz call:

Every call to consume or autofuzz is allocated a fraction of the
remaining bytes and assigns equal parts of this budget to the
recursive invocations it makes.
By constructing the objects that consume a bounded number of bytes
first in autofuzz, the remaining budget for an autofuzz invocation
can be evenly distributed among the variable-length objects without
risking that primitive arguments are forced to trivial values.

To be superseded by the upcoming structured mutation engine.


This code (and some of the code surrounding it) is wildly incorrect

https://github.com/detleph/server/blob/0b7756d42855d9368568a6898487c09e24c77dcc/src/Controllers/organisation.controller.ts#L223

fixed by #95


Fixes #2429 merge 'epithelial cell of alveolus of lung'

Fixes #2429 merge 'epithelial cell of alveolus of lung' into 'pulmonary alveolar epithelial cell'.
Also adds SubclassOf 'squamous epithelial cell' to 'pulmonary alveolar type 1' cell.
'pulmonary alveolar epithelial cell' is classified as 'squamous epithelial cell' because the alveolar epithelium in uberon is categorized as squamous, although pulmoanry alveolar cells type 2 are not squamous. Getting fixed in https://github.com/obophenotype/uberon/issues/3350

#gogoeditdiff


UCI Error on XrmApp.Navigation.OpenSubArea when there is just one Area in Sitemap

Hi Team,
We are writing UI tests for UCI app. We have only one Area in the app to meet application's UI requirements. The problem we are facing is whenever there is just one area in the sitemap we receive "System.InvalidOperationException: No area with the name 'service management' exists." exception. Could you please advise if this issue is under you radar.
Cheers.

Hi,
I am facing the same issue. Error Given is as following:
Code Snippet:
xrmApp.Navigation.OpenSubArea("Service Management", "Service Requests");

Test Outcome:	Failed
Test Duration:	0:01:21.0845611

System.InvalidOperationException: No area with the name 'service management' exists.

The Area exists as per the screen shot below:

Hi,
I'm having the same issue. Has anybody been able to fix this somehow?
Thanks.

Recently add a new method OpenGroupSubArea which should help to navigate while inside an already open app - regardless of the number areas.


Run all phases in parallel

Removes the parallel: [true|false] option from phases.
It's the responsibility of the phase to know when to run exclusively, not cluster manager's.
Also, most of the parallel: false phases were run on a single host, so parallel: false did essentially nothing apart from not creating a thread for the runner.
The parts of phases that should not be run parallelly can utilize the phase mutex brought in by #749

The label nodes phase is now run on master only and it goes through @config.hosts.each, it could be somehow optimized further by getting all nodes at once or labeling them all in a single/batch request.

Please rebase so that we can see travis e2e results.

Seems to work now

Up to date again


Colors disappearing after about 135 characters in PHP code

Prerequisites

[X] Put an X between the brackets on this line if you have done all of the following:

Reproduced the problem in Safe Mode: https://flight-manual.atom.io/hacking-atom/sections/debugging/#using-safe-mode
Followed all applicable steps in the debugging guide: https://flight-manual.atom.io/hacking-atom/sections/debugging/
Checked the FAQs on the message board for common solutions: https://discuss.atom.io/c/faq
Checked that your issue isn't already filed: https://github.com/issues?utf8=✓&q=is%3Aissue+user%3Aatom
Checked that there is not already an Atom package that provides the described functionality: https://atom.io/packages

Description

Steps to Reproduce

Write out a line of code that exceeds about 135 characters with the PHP syntax on.
Look as the colors between quotes, etc. are no longer showing up

Expected behavior:
I would expect that the colors continue to stay consistent throughout the document.
Actual behavior:
The colors abruptly stop at 135 characters.
Reproduces how often:
Every singe time on multiple devices.
Versions
Atom    : 1.44.0
Electron: 4.2.7
Chrome  : 69.0.3497.128
Node    : 10.11.0
apm  2.4.3
npm  6.2.0
node 10.2.1 x64
atom 1.44.0
python 3.8.1
git
visual studio
Windows 10 v1909
Additional Information
I have done this on multiple devices. I have no idea why it happens.

this would be a question for https://github.com/atom/language-php

You are either running into the maximum tokens per line limit (odd for such a small character count) (Atom issue), or a bug in the tokenizer (language-php issue).
Can you post the exact code you are seeing this on so we can narrow down the issue?


Rhmap 17173 render studio

@jhellar
https://issues.jboss.org/browse/RHMAP-13689
Updated function responsible for updating submissions.

SonarQube analysis reported 1 issue:

 1 major

Watch the comments in this conversation to review them.

Verified functionality in local VM.

Changes Unknown when pulling 428425cb70fa806cd9a086e9a3332eefe80750aa on witmicko:RHMAP-17173_render_studio into ** on feedhenry:RHMAP-1157-Repeating_Sections**.

Verified PDF render in local VM.

SonarQube analysis reported 2 issues:

 1 minor
 1 info

Watch the comments in this conversation to review them.
Note: the following issues could not be reported as comments because they are located on lines that are not displayed in this pull request:

 Function has a complexity of 24 which is greater than 20 authorized.
 Move this trailing comment on the previous empty line.

Changes Unknown when pulling 610a511749aed6a37ea538d224d82235809ec94f on witmicko:RHMAP-17173_render_studio into ** on feedhenry:RHMAP-1157-Repeating_Sections**.

SonarQube analysis reported 1 issue:

 1 info

Watch the comments in this conversation to review them.

Changes Unknown when pulling 4af2b12bf83bc15c6bbe5fc67ecbc459b89178ca on witmicko:RHMAP-17173_render_studio into ** on feedhenry:RHMAP-1157-Repeating_Sections**.


SonnyRistrettoPointGadget implementation & refactor

Closes #12 by refactoring #11 according to the stated points on the issue #12

As seen on the last commit 958a204, the non_zero gadget works correctly.
So after building tests for each component, the error has to reside in the way we are computing 8*P. I think that the points that we are getting from the double implementation for SonnyRistrettoPointGadget are not being correctly computed for some reason.

With the latest test on doubling without checking ristretto correctness introduced in b1090aa we can see that the double implementation for SonnyRistrettoPointGadget is failing.
Probably the initial refactor introduced an error somewhere or something similar.
At least, the error is now spotted, so we can now review the double impl @decentralisedkev .

Actually, I noticed that when we commit the Point coordinates using the methods prover_commit_to_sonnypoint() or verifier_commit_to_sonnypoint(). Without constraining the points to be Ristretto the tests also fail. So it can probably mean that the R1CS that the prover and the verifier have are not the same. we need to dig into it.

Even the sk_knowledge_gadget works, we are not able to use it with secret points since we are experiencing an error on the verification that most probably relies on the way on which we are generating the SonnyRistrettoPointGadget from the prover and verifier perspectives.
Also, point doubling gadget is reliyng now on the addition since it was also having an error that we are still looking for. So #4 cannot be closed yet.
Appart from that, I think we should modularize much better the lib since now all gadgets are mixed on the test file and also on the ristretto_point.rs one.

All looks fine as-is! Just pointed a few minor issues that can be solved on further refactoring