Support https_proxy

Hi,
I just tried to use the plugin and according to tcpdump and the access.log of the proxy in front of the API it doesn't even connect to the API server. Not even the "Test connection" works.
servername: https://saltapi.office.blah.de:443
A Curl in a Shell buildstep in the same job works just fine:
[...]
[salt_api] $ /bin/sh -xe /tmp/hudson310140799158824452.sh
+ curl -kI https://saltapi.office.blah.de:443
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed

  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
  0   181    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
HTTP/1.1 200 OK
Server: nginx
Date: Thu, 10 Nov 2016 09:00:29 GMT
Content-Type: application/json
Content-Length: 181
Connection: keep-alive
Access-Control-Expose-Headers: GET, POST
Vary: Accept-Encoding
Allow: GET, HEAD, POST
Access-Control-Allow-Credentials: true
Access-Control-Allow-Origin: *
Set-Cookie: session_id=6d2f14935544aa64d0cbe4e80230d26d4697ae8e; expires=Thu, 10 Nov 2016 19:00:29 GMT; Path=/
[...]

I can't give you any Jenkins logs since I don't know what the right logger would be. The only error I get in the Console Output is the followig:
Auth Error: net.sf.json.JSONException: JSONObject["return"] is not a JSONArray.

{"Error": "java.net.SocketTimeoutException: connect timed out
Build step 'Send a message to Salt API' marked build as failure
Finished: FAILURE

I made sure that our self-signed cert is in Javas keystore.
Jenkins Version: 2.19.2
Salt Plugin Version: 1.7.1
Any help would be much appreciated.

Oh, I RTFM'd and added a logger for com.waytta.saltstack. But this one shows nothing too.

It sounds like the response back isn't the expected JSON. Are you using the cherrypy api?
# curl -k http://localhost:8000
{"clients": ["_is_master_running", "local", "local_async", "local_batch", "local_subset", "runner", "runner_async", "ssh", "ssh_async", "wheel", "wheel_async"], "return": "Welcome"}

# curl -kI http://localhost:8000
HTTP/1.1 200 OK
Content-Length: 181
Access-Control-Expose-Headers: GET, POST
Vary: Accept-Encoding
Server: CherryPy/3.5.0
Allow: GET, HEAD, POST
Access-Control-Allow-Credentials: true
Date: Fri, 11 Nov 2016 16:47:27 GMT
Access-Control-Allow-Origin: *
Content-Type: application/json
Set-Cookie: session_id=35656f11bd7924f85912d406c8b1a0536a7fa6ab; expires=Sat, 12 Nov 2016 02:47:27 GMT; Path=/

You should be able to login with a simple JSON string and get back a response. The connect timeout makes it sounds as if the jenkins host isn't able to reach the salt-master's url.
# curl -ik http://localhost:8000/login -H 'Content-Type: application/json' -d '[{"eauth":"pam","password":"jenkins","username":"jenkins"}]'
HTTP/1.1 200 OK
Content-Length: 187
Access-Control-Expose-Headers: GET, POST
Vary: Accept-Encoding
Server: CherryPy/3.5.0
Allow: GET, HEAD, POST
Access-Control-Allow-Credentials: true
Date: Fri, 11 Nov 2016 16:49:55 GMT
Access-Control-Allow-Origin: *
X-Auth-Token: 4c9f373b331b39417b20d7eecbd6b5f15439d15e
Content-Type: application/json
Set-Cookie: session_id=4c9f373b331b39417b20d7eecbd6b5f15439d15e; expires=Sat, 12 Nov 2016 02:49:55 GMT; Path=/

{"return": [{"perms": [".*", "@runner"], "start":<PHONE_NUMBER>.909112, "token": "4c9f373b331b39417b20d7eecbd6b5f15439d15e", "expire":<PHONE_NUMBER>.909112, "user": "jenkins", "eauth": "pam"}]}

I am using the Cherypy-API. An when authenticating from the command line as Jenkins-User it works as expected:
jenkins@jenkins$ curl -ik --noproxy saltapi https://saltapi:443/login -H 'Content-Type: application/json' -d '[{"eauth":"pam","password":"jenkins","username":"jenkins"}]'
HTTP/1.1 200 OK
Server: nginx
Date: Mon, 14 Nov 2016 09:46:50 GMT
Content-Type: application/json
Content-Length: 210
Connection: keep-alive
Access-Control-Expose-Headers: GET, POST
Vary: Accept-Encoding
Allow: GET, HEAD, POST
Access-Control-Allow-Credentials: true
Access-Control-Allow-Origin: *
X-Auth-Token: 48105ca6efaf3c0d6faa6616097e7d8a0d6a359f
Set-Cookie: session_id=48105ca6efaf3c0d6faa6616097e7d8a0d6a359f; expires=Mon, 14 Nov 2016 19:46:50 GMT; Path=/

{"return": [{"perms": [".*", "@runner", "@wheel", "@jobs"], "start":<PHONE_NUMBER>.4126899, "token": "48105ca6efaf3c0d6faa6616097e7d8a0d6a359f", "expire":<PHONE_NUMBER>.4126911, "user": "jenkins", "eauth": "pam"}]}

We have the https_proxy environment variable set on the Jenkins server. But Jenkins ignores it as you can see by the first curl command I posted.

Oh I see. Then it's really a matter of supporting the https_proxy env var. Yes, that isn't currently supported. I'll look into it.

@mchugh19 I'm not sure if this is correct. The curl in the Shell build step didn't have the proxy variable, so your plugin shouldn't have it too. Meaning, the Jenkins process (slave.jar) doesn't have the variable set (I don't know why). Also the proxy should not been used! That's why I had to type curl -ik --noproxy saltapi on the command line.
I'd still like to know, what really happens inside the plugin. As said above, according to tcpdump there is no connection whatsoever to the API host when I run a build with the plugin configured.

Understood. The tcpdump logging is certainly strange.
All the plugin does is attempt to connect to the url and post the json, just like the curl above.
Since you are not seeing any connection from the tcpdump, it sounds like there is some other issue. Have you tried tcpdump from the Jenkins side to see that a connection is being attempted?
Additionally, could you please test out the current master branch? I've just cut an early beta hpi which incorporates a few cleanups and my hope is we could see more about the exception causing this connectivity issue.

I did the Tcpdump again. With tcpdump -i bond0 -s 0 -l -w - dst port 443 and dst host saltapi I listened for connections. I did a "Test Connection" in "Salt API" build step and that gave me no traffic at all an the following error:
Client error: Auth Error: net.sf.json.JSONException: JSONObject["return"] is not a JSONArray.
{"Error": "java.net.SocketTimeoutException: connect timed out

Also while listening to connections to our proxy (just to be on the safe side) I did a tcpdump which gave me "zip" again.
To make sure I'm didn't mess up the tcpdump I made a curl --noproxy saltapi -I https://saltapi from CLI which succedded and showed traffic.
Before trying your beta I will need to figure how to install the plugin. My Jenkins-foo is not very mighty ;) I get back to you A.S.A.P.
P.S.: Isn't there a way to get some sort of debugging output from the plugin to see what calls are made?

I installed the v2.0-beta1 tag and still the same. Nothing from the logger com.waytta.saltstack, nothing in the tcpdump and the same error as above.

So if tcpdump isn't seeing any traffic being sent from the jenkins server, and the error you are getting back from the plugin states connection timed out, it sure sounds like there is a local configuration problem.
The plugin code will log the json being sent to the salt master as well as the response, but there is no logging code path before the login, as that is the first thing it does. The connect timed out error seems to be pretty valid -- if it isn't sending traffic, the connection will time out. My hope from the 2.0beta1 release is that you might have gotten a different error from the http connection which might have helped.
Could you try running jenkins on another VM? There really isn't any magic at this point. It seems there is something funky about the jenkins environment that is limiting network communication. I'm really stretching here but possibly selinux, or funky iptables rules?

It would help me a lot to see the actual HTTP request.
I can't move Jenkins somewhere else. And to get an exhaustive (containing all traffic) network dump for analysis in Wireshark, I would have to tell too many people to stop working ;)

You can get the output of the http connections by creating a new sun.net.www.protocol.http.HttpURLConnection logger set to FINEST. I wasn't able to get this to show any output until also setting a blank default Jenkins logger on /jenkins/log/levels also to FINEST.

So you can compare, this is the output from running a subset job
Nov 18, 2016 10:04:16 PM FINEST sun.net.www.protocol.http.HttpURLConnection
ProxySelector Request for http://localhost:8000/login
Nov 18, 2016 10:04:16 PM FINEST sun.net.www.protocol.http.HttpURLConnection
Proxy used: DIRECT
Nov 18, 2016 10:04:16 PM FINE sun.net.www.protocol.http.HttpURLConnection
sun.net.www.MessageHeader@6d8aae179 pairs: {POST /login HTTP/1.1: null}{Accept: application/json}{Content-Type: application/json}{Cache-Control: no-cache}{Pragma: no-cache}{User-Agent: Java/1.8.0_101}{Host: localhost:8000}{Connection: keep-alive}{Content-Length: 59}
Nov 18, 2016 10:04:16 PM FINEST sun.net.www.protocol.http.HttpURLConnection
KeepAlive stream used: http://localhost:8000/login
Nov 18, 2016 10:04:16 PM FINE sun.net.www.protocol.http.HttpURLConnection
sun.net.www.MessageHeader@73068da912 pairs: {null: HTTP/1.1 200 OK}{Content-Length: 187}{Access-Control-Expose-Headers: GET, POST}{Vary: Accept-Encoding}{Server: CherryPy/3.5.0}{Allow: GET, HEAD, POST}{Access-Control-Allow-Credentials: true}{Date: Fri, 18 Nov 2016 22:04:16 GMT}{Access-Control-Allow-Origin: *}{X-Auth-Token: 40a68965320d6e4ce95af7adae0a443474cbfd99}{Content-Type: application/json}{Set-Cookie: session_id=40a68965320d6e4ce95af7adae0a443474cbfd99; expires=Sat, 19 Nov 2016 08:04:16 GMT; Path=/}
Nov 18, 2016 10:04:16 PM FINEST sun.net.www.protocol.http.HttpURLConnection
ProxySelector Request for http://localhost:8000/
Nov 18, 2016 10:04:16 PM FINEST sun.net.www.protocol.http.HttpURLConnection
KeepAlive stream retrieved from the cache, sun.net.www.http.HttpClient(http://localhost:8000/login)
Nov 18, 2016 10:04:16 PM FINEST sun.net.www.protocol.http.HttpURLConnection
Proxy used: DIRECT
Nov 18, 2016 10:04:16 PM FINE sun.net.www.protocol.http.HttpURLConnection
sun.net.www.MessageHeader@1568d30c10 pairs: {POST / HTTP/1.1: null}{Accept: application/json}{Content-Type: application/json}{X-Auth-Token: 40a68965320d6e4ce95af7adae0a443474cbfd99}{Cache-Control: no-cache}{Pragma: no-cache}{User-Agent: Java/1.8.0_101}{Host: localhost:8000}{Connection: keep-alive}{Content-Length: 125}
Nov 18, 2016 10:04:31 PM FINEST sun.net.www.protocol.http.HttpURLConnection
KeepAlive stream used: http://localhost:8000
Nov 18, 2016 10:04:31 PM FINE sun.net.www.protocol.http.HttpURLConnection
sun.net.www.MessageHeader@2221514712 pairs: {null: HTTP/1.1 200 OK}{Content-Length: 373}{Access-Control-Expose-Headers: GET, POST}{Cache-Control: private}{Vary: Accept-Encoding}{Server: CherryPy/3.5.0}{Allow: GET, HEAD, POST}{Access-Control-Allow-Credentials: true}{Date: Fri, 18 Nov 2016 22:04:16 GMT}{Access-Control-Allow-Origin: *}{Content-Type: application/json}{Set-Cookie: session_id=40a68965320d6e4ce95af7adae0a443474cbfd99; expires=Sat, 19 Nov 2016 08:04:16 GMT; Path=/}

Hmm, I have configured the loggers as described. But still there only this:
Nov 21, 2016 9:21:42 AM FINEST sun.net.www.protocol.http.HttpURLConnection
ProxySelector Request for https://saltapi:443/login
Nov 21, 2016 9:21:42 AM FINEST sun.net.www.protocol.http.HttpURLConnection
Looking for HttpClient for URL https://saltapi:443/login and proxy value of DIRECT
Nov 21, 2016 9:21:42 AM FINEST sun.net.www.protocol.http.HttpURLConnection
Creating new HttpsClient with url:https://saltapi:443/login and proxy:DIRECT with connect timeout:5000

The access.logs of the API's proxy show nothing too.  Also I did a tcpdump again and the only traffic to the saltapi host was the connection between Minion and Master (the API is also the master).
Just to be sure:

I Created a new logger which named "salt" containing sun.net.www.protocol.http.HttpURLConnection with level set to FINEST.
Under /log/levels I changed the default logger (the empy one) to FINEST.

Any ideas left?
cheers

That looks accurate.
You can see from the example I posted earlier that the first connection was to "http://localhost:8000/login". After that succeeds, it then does a post "{POST /login HTTP/1.1: null}{Accept: ..."
In your example, jenkins attempts to reach "https://saltapi:443/login" and it never completes. This matches the original error returned: "Error": "java.net.SocketTimeoutException: connect timed out.
It appears there is something preventing the jenkins host from resolving or otherwise getting out to the saltapi host.

HaHa, the whole time I was looking on the wrong host. I Pinned the job to a specific slave via the "Node and label parameter" plugin. So I concentrated on this slave. But the whole time the salt plugin was running on the Jenkins master. After figuring out what was happening I opened the port to the Salt-API in our firewall and everything worked as expected.
Thanks a lot for your time and patience


Lint with updated black

With 20.8b1, black devs have changed some rules while the library is approaching a stable release.

Pull Request Test Coverage Report for Build 231326381

1 of 1 (100.0%)  changed or added relevant line in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build 216940498:
0.0%

Covered Lines:
654

Relevant Lines:
654

💛  - Coveralls


Release new version SDK for BackupShortTermRetentionPolicy and ReplicationLink

All SDK Contribution checklist:
This checklist is used to make sure that common guidelines for a pull request are followed.

[ ] Please open PR in Draft mode if it is:

Work in progress or not intended to be merged.
Encountering multiple pipeline failures and working on fixes.

[ ] If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
[ ] I have read the contribution guidelines.
[ ] The pull request does not introduce breaking changes.

General Guidelines and Best Practices

[ ] Title of the pull request is clear and informative.
[ ] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

[ ] Pull request includes test coverage for the included changes.

SDK Generation Guidelines

[ ] The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code. (Track 2 only)
[ ] The *.csproj and AssemblyInfo.cs files have been updated with the new version of the SDK. Please double check nuget.org current release version.

Additional management plane SDK specific contribution checklist:
Note: Only applies to Microsoft.Azure.Management.[RP] or Azure.ResourceManager.[RP]

[ ] Include updated management metadata.
[ ] Update AzureRP.props to add/remove version info to maintain up to date API versions.

Management plane SDK Troubleshooting

If this is very first SDK for a services and you are adding new service folders directly under /SDK, please add new service label and/or contact assigned reviewer.

If the check fails at the Verify Code Generation step, please ensure:

Do not modify any code in generated folders.
Do not selectively include/remove generated files in the PR.
Do use generate.ps1/cmd to generate this PR instead of calling autorest directly.
Please pay attention to the @microsoft.csharp version output after running generate.ps1. If it is lower than current released version (2.3.82), please run it again as it should pull down the latest version.

Note: We have recently updated the PSH module called by generate.ps1 to emit additional data. This would help reduce/eliminate the Code Verification check error. Please run following command:
  `dotnet msbuild eng/mgmt.proj /t:Util /p:UtilityName=InstallPsModules`

Old outstanding PR cleanup
Please note:
If PRs (including draft) has been out for more than 60 days and there are no responses from our query or followups, they will be closed to maintain a concise list for our reviewers.

@VMMicrosoft could you please provide Swagger PR?

Swagger: https://github.com/Azure/azure-rest-api-specs/pull/14671

@nisha-bhatia
and this one: https://github.com/Azure/azure-rest-api-specs/pull/14744
two in total.


Create strlen.cpp

Using the standard library is not helpful. Please use your own implementation of the function. The standard library combined with ,,... already contains most of the algorithms present in the repo.
Thank you for taking your time to contribute.
Please read README and CONTRIBUTING to learn more about how to contribute.


Any way to handle 5m, 10m, 15m bars?

Hello all,
What is the cleanest way to use e.g. 5m bars or 10m bars for intraday backtesting in Zipline? I have quite a bit of historical 5m data that it would be prohibitively expensive to replace with equivalent 1m data.
If given some guidance, I'm happy to write thorough documentation and open a PR with it.
Best
-james

I'm interested in this as well.

@jamescgibson One quick hack is to ffil your 5m data to make it minute data, and then setting your scheduled functions to run once every 5m, or 10m etc.

also interested

@JoaoAparicio Nice, thanks for that tip!

@JoaoAparicio Could you please give some examples?

@imkoukou where did you make changes? can you share? Thanks

was this resolved? is ffill the best way to do this?

Okay it looks like schedule_function is the right thing to be using here.


Kolibri version issue

Attempting to build using a whl file from Develop or 0.5.
Traceback (most recent call last):
--
  | File "/usr/local/bin/buildozer", line 11, in <module>
  | sys.exit(main())
  | File "/usr/local/lib/python2.7/dist-packages/buildozer/scripts/client.py", line 13, in main
  | Buildozer().run_command(sys.argv[1:])
  | File "/usr/local/lib/python2.7/dist-packages/buildozer/__init__.py", line 1058, in run_command
  | self.target.run_commands(args)
  | File "/usr/local/lib/python2.7/dist-packages/buildozer/target.py", line 91, in run_commands
  | func(args)
  | File "/usr/local/lib/python2.7/dist-packages/buildozer/target.py", line 103, in cmd_debug
  | self.buildozer.build()
  | File "/usr/local/lib/python2.7/dist-packages/buildozer/__init__.py", line 212, in build
  | self.target.build_package()
  | File "/usr/local/lib/python2.7/dist-packages/buildozer/targets/android.py", line 642, in build_package
  | version = self.buildozer.get_version()
  | File "/usr/local/lib/python2.7/dist-packages/buildozer/__init__.py", line 717, in get_version
  | ' (looking for `{1}`)'.format(fn, regex))
  | Exception: Unable to find capture version in ./code/kolibri/VERSION
  | (looking for `v(\d+\.\d+\.\d+)`)

08-17 11:04:30.954 31390 31451 I python  : Traceback (most recent call last):
08-17 11:04:30.954 31390 31451 I python  :   File "main.py", line 11, in <module>
08-17 11:04:30.954 31390 31451 I python  :     django.setup()
08-17 11:04:30.954 31390 31451 I python  :   File "kolibri/dist/django/__init__.py", line 17, in setup
08-17 11:04:30.954 31390 31451 I python  :     configure_logging(settings.LOGGING_CONFIG, settings.LOGGING)
08-17 11:04:30.954 31390 31451 I python  :   File "kolibri/dist/django/conf/__init__.py", line 55, in __getattr__
08-17 11:04:30.954 31390 31451 I python  :     self._setup(name)
08-17 11:04:30.954 31390 31451 I python  :   File "kolibri/dist/django/conf/__init__.py", line 43, in _setup
08-17 11:04:30.954 31390 31451 I python  :     self._wrapped = Settings(settings_module)
08-17 11:04:30.954 31390 31451 I python  :   File "kolibri/dist/django/conf/__init__.py", line 99, in __init__
08-17 11:04:30.954 31390 31451 I python  :     mod = importlib.import_module(self.SETTINGS_MODULE)
08-17 11:04:30.954 31390 31451 I python  :   File "/data/user/0/org.le.kolibri/files/lib/python27.zip/importlib/__init__.py", line 37, in import_module
08-17 11:04:30.954 31390 31451 I python  :
08-17 11:04:30.954 31390 31451 I python  :   File "/data/user/0/org.le.kolibri/files/kolibri/__init__.py", line 13, in <module>
08-17 11:04:30.954 31390 31451 I python  :     __version__ = str(get_version(VERSION))
08-17 11:04:30.954 31390 31451 I python  :   File "/data/user/0/org.le.kolibri/files/kolibri/utils/lru_cache.py", line 137, in wrapper
08-17 11:04:30.954 31390 31451 I python  :     result = user_function(*args, **kwds)
08-17 11:04:30.954 31390 31451 I python  :   File "/data/user/0/org.le.kolibri/files/kolibri/utils/version.py", line 404, in get_version
08-17 11:04:30.955 31390 31451 I python  :     return get_prerelease_version(version)
08-17 11:04:30.955 31390 31451 I python  :   File "/data/user/0/org.le.kolibri/files/kolibri/utils/version.py", line 332, in get_prerelease_version
08-17 11:04:30.955 31390 31451 I python  :     tag_describe = get_git_describe()
08-17 11:04:30.955 31390 31451 I python  :   File "/data/user/0/org.le.kolibri/files/kolibri/utils/version.py", line 237, in get_git_describe
08-17 11:04:30.955 31390 31451 I python  :     universal_newlines=True
08-17 11:04:30.955 31390 31451 I python  :   File "/home/christian/repos/kolibri-kivy/.buildozer/android/platform/build/build/other_builds/python2-openssl-sqlite3/armeabi-v7a/python2/python-install/lib/python2.7/subprocess.py", line 679, in __init__
08-17 11:04:30.955 31390 31451 I python  :   File "/home/christian/repos/kolibri-kivy/.buildozer/android/platform/build/build/other_builds/python2-openssl-sqlite3/armeabi-v7a/python2/python-install/lib/python2.7/subprocess.py", line 1228, in _execute_child
08-17 11:04:30.955 31390 31451 I python  : OSError: [Errno 2] No such file or directory
08-17 11:04:30.996 31390 31451 I python  : Python for android ended.

Looks like subprocess doesn't exist in the version of the python interpreter you're pulling in @jamalex @christianmemije. We'll have to add a try-except clause to skip running git describe if subprocess doesn't exist.

What we need is to be able to get the current Kolibri version from the extracted WHL file. We used to get that from the VERSION file, but it seems to now be gone.
Exception: Unable to find capture version in ./code/kolibri/VERSION

Are you able to run python code before this? If so, you can just execute python -c "import kolibri; kolibri.__version__ but there might be a cleaner version (@benjaoming any recommendations?)

Not as part of the buildozer config (it takes a file and a regex for extracting the version number, which could perhaps work also?), but we could do that as part of the docker file, if needed.

We used to get that from the VERSION file, but it seems to now be gone.

It is still there, the regex just needs to be updated since the version schema changed.

Python for Android expects only digits and decimals in the version.
https://github.com/kivy/python-for-android/blob/395c7e0eb5709df316fc04bab00f8c887ae40ea2/pythonforandroid/bootstraps/webview/build/build.py#L283
For something like 0.6.dev020170912184629-git, we can either extract just 0.6, or can you think of a way to match all digits and decimals as one match?

Looks like subprocess doesn't exist in the version of the python interpreter you're pulling in

I think the actual issue it that git is not installed.

Fixed in #15


[18.06] Fix flakyness in TestDockerNetworkInternalMode

cherry-pick of https://github.com/moby/moby/pull/37455 for 18.06
git checkout -b 18.06-backport-fix-internal ce-engine/18.06
git cherry-pick -s -S -x a2bb2144b3e0d49ac615976bfac462a307d85f0e
git push -u origin

no conflicts, cherry-pick was clean
Instead of waiting for the DNS to fail, try to access
a specific external IP and verify that 100% of the pakcets
are being lost.

Wanting this one in ASAP because it stabilizes tests for docker/e2e.


changing

https://github.com/microsoft/opensource.microsoft.com/blob/39b64a6151aa5a29fcb7a91ab910db9cf05b237e/.github/workflows/codeql-analysis.yml#L53

Hi could you explain what exactly you would like to change?


fix typos in bonfire descriptions

About the PR

Why / Balance

Technical details

Media

[X] I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes

Changelog

бывает


Interactive Mode for list commands

It would be a nice idea to have some extra interactivity in the CLI.
As an example see how the jira CLI deals with lists.
For the CLI there are several places where such an interactive experience might be helpful.
Scenario
It would be cool for our CLI if this was possible:
Allow for users to run a list command and select the wanted item using the up, down and enter keys, after which the associated get command is executed and returns the item.
Remarks
We need to research this a bit more to see what the options are. I'm adding this here to keep it in mind.

It is a nice thought Martin. But I guess we already had a discussion on the same lines here #3054 . This could be an extension of that feature which we can bring in.
I personally may not be much interested in getting the lists. But I would very well be interested in getting the list AAD App and get the information by selecting the specific app.

We'd need to think about the user experience especially in cases when there are more results than what fits on the screen: can a terminal handle that properly? How would a user locate an item among 100 of items?

Thinking of this feature, we should also consider the scenario where you want to just get the list of resources without a follow up with get (eg. to build documentation or run some other command). How would the user express which scenario they want to use (interactive list + get vs. just list)?

Perhaps we should just close this as lack of interest and prio. What do you think @waldekmastykarz?

Let's close it for now. We can always reopen in the future if need be


Lasb 2090 documentation

What
Link to story
Add documentation to the application so that other developers can get it running and better understand how it works.
Checklist
Before you ask people to review this PR:

[ ] Tests should be passing: ./gradlew test (Still broken - will fix in future story)
[x] Github should not be reporting conflicts; you should have recently run git rebase main.
[x] Avoid mixing whitespace changes with code changes in the same commit. These make diffs harder to read and conflicts more likely.
[x] You should have looked at the diff against main and ensured that nothing unexpected is included in your changes.
[x] You should have checked that the commit messages say why the change was made.

We can pair and run through testing this together tomorrow if that sounds good? I'll put in a meeting.

We can pair and run through testing this together tomorrow if that sounds good? I'll put in a meeting.

Sounds good, thanks.


⚠ dev.minetest.net has degraded performance

In 9bb28ef, dev.minetest.net (https://dev.minetest.net/Main_Page) experienced degraded performance:

HTTP code: 200
Response time: 2393 ms

Resolved: dev.minetest.net performance has improved in 556850e after 16 minutes.


use cross-spawn

closes #3

@Kinvey Can you merge this and release on NPM?
This would make a huge difference for Windows folks.

Ping.

@patrickjholloway unfortunately I'm no longer on a windows machine, but I remember this being a relatively safe change to make.

@miguelcobain okay, sounds good. I do want to test this out and add an entry to the README. I will take care of this soon and merge. Thank you for the PR and sorry for the huge delay.

@patrickjholloway do we have any progress here?

@patrickjholloway any news here ?

Going to close the PR. Will be reopened in case it is needed at some point.


ES Module support

Great stuff, found this by accident, is it possible to support ES Module output for builds?

Hi @1951FDG thanks for reaching out! It'd be great to have ESM support. If you're interested in implementing it, I'd be happy to review a PR.

Hi @nemtsov, let me look into this next year, I've never done this, but I'll be happy to look into this.


Issue378 fix, change env-sample to correctly point to certificates in…

… ssl folder
Fixes  issue #378
Signed-off-by: Sachin Naik<EMAIL_ADDRESS>Changed the env.sample in cra-client to point correctly to the ssl folder.

Note that the self signed certificates in Egeria were recently updated, so any copy in ui will need to be updated (could be a separate issue/pr but ideally should get in for next release)

That's not an issue with this pr as such, can be a separate change


"DAO name" field validation isn't working and user can create DAO with existing DAO name

STR:
Open Create new DAO page
Enter existing DAO name
Fill all required fields
Create DAO
ER:
User can't create DAO with an existing name due to the "DAO name" field validation
On the bottom of the page error message is appear "There are errors in your form. Please, check validation messages on the page."
AR:
"DAO name" field validation isn't working and user can create DAO with existing DAO name
No error message on the bottom of the page

Verified on testnet. Fixed


Remove obsolete Franz references from CONTRIBUTING.md

Remove obsolete Franz references.

Description

I removed old Franz references from CONTRIBUTING.md and added a link to the issue discussing the current state of development.
Motivation and Context

Because the previous links point to Franz's Slack which is definitely the wrong place to talk about Ferdi.
Checklist:

[x] My pull request is properly named
[x] The changes respect the code style of the project ($ npm run lint)
[x] I tested/previewed my changes locally

Thank you for updating this!

 I was just happy to help. I really want something like Ferdi/Franz/Rambox to work really well and out of those three, Ferdi has the brightest future, I think.


V2.4.x

[OPENENGSB-2723] Add new wsdl plugin and let the old plugin inside because of compatible reasons

looks fine; basically you need to define the version of the maven-plugin somewhere. I'll add it for now in the root pom. But pls keep this in mind for future changes.


Graceful reboot

Possibilities:

Pass pid:host to tink-docker which may allow a reboot syscall to work.
Some third container shenanigans that can signal to the OS.
ACPI call ... No clue how this would work.. sounds cool though.

I like the idea to be as transparent as possible here, an API call or container shenanigans (maybe a remap) sounds magic.
If we can hide something around the reboot syscall I think that will be nice and transparent but I don't know a lot

I like the idea to be as transparent as possible here, an API call or container shenanigans (maybe a remap) sounds magic.
If we can hide something around the reboot syscall I think that will be nice and transparent but I don't know a lot

Can we bind mount /proc from the host and use echo b > /proc/sysrq-trigger? https://stackoverflow.com/a/24759427

Can we bind mount /proc from the host and use echo b > /proc/sysrq-trigger? https://stackoverflow.com/a/24759427

Thank you for your feedback @displague . Finding a way to "cut the power" for a server is easy as you wrote. For example, ContainerSolution uses sysrq-trigger here https://github.com/ContainerSolutions/tinkerbell-rpi4-workflow/blob/master/workflow/05-reboot/reboot.sh#L8 .
The real problem is how to make to catch the reboot and notify to tink-server that it actually happened. Otherwise, the action will be marked as a failure.

Thank you for your feedback @displague . Finding a way to "cut the power" for a server is easy as you wrote. For example, ContainerSolution uses sysrq-trigger here https://github.com/ContainerSolutions/tinkerbell-rpi4-workflow/blob/master/workflow/05-reboot/reboot.sh#L8 .
The real problem is how to make to catch the reboot and notify to tink-server that it actually happened. Otherwise, the action will be marked as a failure.

We need a nice way of replying "we're now going to reboot" as we reboot. Just "resetting" doesn't answer the action so leaves it failed.

We need a nice way of replying "we're now going to reboot" as we reboot. Just "resetting" doesn't answer the action so leaves it failed.

Is there any reason not to just pass tink-docker the necessary capabilities? If you look at the tests from linuxkit, they often include a poweroff, using docker.io/linuxkit/poweroff, e.g. here.
That one already has CAP_SYS_BOOT, see here

Is there any reason not to just pass tink-docker the necessary capabilities? If you look at the tests from linuxkit, they often include a poweroff, using docker.io/linuxkit/poweroff, e.g. here.
That one already has CAP_SYS_BOOT, see here

Is there any reason not to just pass tink-docker the necessary capabilities? If you look at the tests from linuxkit, they often include a poweroff, using docker.io/linuxkit/poweroff, e.g. here.
That one already has CAP_SYS_BOOT, see here

This is the plan ! 👍

Is there any reason not to just pass tink-docker the necessary capabilities? If you look at the tests from linuxkit, they often include a poweroff, using docker.io/linuxkit/poweroff, e.g. here.
That one already has CAP_SYS_BOOT, see here

This is the plan ! 👍

pid:host was all I needed! Can't wait to kill this issue :D

pid:host was all I needed! Can't wait to kill this issue :D

This can be closed via #13 and demonstrated today.

This can be closed via #13 and demonstrated today.


undertow.io icon

SVG sources can be found here: http://design.jboss.org/undertow/index.htm

Added 8d79fa158736a6a68713c96974b9a611b713bd4d
:+1:


Use const generics in InfraRange

Should also fix #67

Also it would be great to use const generics in PulsedataBuffer for internal buffer size.

Also it would be great to use const generics in PulsedataBuffer for internal buffer size, cause 194 byte of RAM is a fortune for some of mcu's smile

It really should. Did a quick implementation of it. Not tested on hardware yet. https://github.com/jkristell/infrared/tree/const-generic-buffer


Update privacy policy based on pathogens portal

Would you be able to take a quick look and see if you're happy with what I've written. I think it looks okay.
I've essentially reused the pathogens portal policy: https://www.pathogens.se/privacy/ with some minor changes (e.g. we only have 1 contact form).

I somehow managed to add a file from the playwright tests here... which I've now removed so I can merge this now. Probably easiest to show it Angela in person or when visible on the dev site itself.


BUG - most_recent_sale_date using wrong aggregation

Are you a current Fivetran customer?

Fivetran created Bug
Describe the bug

The calculation for most_recent_sale_date is currently using a min aggregation. However, it should instead be max.
https://github.com/fivetran/dbt_stripe/blob/1815eb873fc7a6be03da158db5e4ee990f994e61/models/stripe__customer_overview.sql#L71-L74
Expected behavior

The most_recent_sale_date should be the max date.

The merged PR above resolved this issue and the fix is live in the latest version of the package.


Android and phonegap -  flashing's popup after clicking on cancel button

Hello,

After I upgraded the version to the last one, it cause bug of flashing's popup.
This is the scenario:
Open popup with signature pad and do nothing->
click on cancel button and close the popup->
open again the popup ->
Excepted result= the popup open with the signature pad
Actual result= the popup did not open and the screen is flashing.

I'm using phonegap on android with javascript and bootstrap.
This bug can't reproduce on Iphone.
This are the functions that were changed in the new version.
stopDrawing
startDrawing
disableCanvas
initDrawEvents
drawIt

Do you have a versions inside the file? It is very hard to understand which version is on my source control in case of upgrade or downgrade.

Thanks

Hi @MobideoNetser, thanks for reporting this issue. Unfortunately, I don't think I'm going to get a chance to look into it in the near future. If you're up for working on it yourself, I'd be happy to review a pull request.

I know this is very old ticket. But here is my 5cents
@MobideoNetser i was using the signature in bootstrap pop up also.
I had the issue where it doesn't close correctly and the background stay dimmed or grayed out even after the modal disappear.
I remember that the fix was not related to signature, it was related to how you are closing the modal.
You can try to explicitly hide or remove the pop up altogether upon closing. And not rely on bootstrap to do it for you.
Hope this can help.


Adding drone-shark

We are testing a feature to support on the fly passive enumeration through tshark and auto exfils to LAIR.  If you think it would be good to add into the general drones, let me know.  Working poc below.   still in very infant stage.  https://github.com/Cr0n1c/drone/blob/master/drone-shark.py

@Cr0n1c we're moving everything over to @lair-framework, how would you feel about moving your drone over there when the time comes?

I don't mind.  I also have a drone-p0f and a drone-multi (used to shipping up multiple scans) if interested.


Unknown drupal parameter

mglaman/phpstan-drupal1.1.30

phpstan/phpstan1.10.13

I'm getting:
Unexpected item 'parameters › drupal'.
My phpstan.neon:
parameters:
    customRulesetUsed: true
    reportUnmatchedIgnoredErrors: false
    drupal:
        drupal_root: %currentWorkingDirectory%/web
        entityMapping:
            og_membership:
                class: Drupal\og\Entity\OgMembership
                storage: Drupal\Core\Entity\Sql\SqlContentEntityStorage
            rdf_entity:
                class: Drupal\rdf_entity\Entity\Rdf
                storage: Drupal\sparql_entity_storage\SparqlEntityStorage

From composer.json:
        "phpstan": {
            "includes": [
                "vendor/mglaman/phpstan-drupal/extension.neon",
                "vendor/phpstan/phpstan-deprecation-rules/rules.neon"
            ]
        }

and using the phpstan/extension-installer plugin

Weird. This, to me, reads like the phpstan-drupal extension isn't actually being loaded.

Somehow the phpstan/extension-installer has been removed when I've ran composer update. Most probably it was a dependency before and was not explicitly required in the project’s composer. Closing...


remove pointPlaceHolder. reset stedsnavn on new click

A picture tells a thousand words
Before this PR

After this PR

Coverage remained the same at 45.465% when pulling 3e7e9d15501b4df5c405a2f3fb37c609cb0a1675 on removePunktLoaderPlaceHolder into 7aa850fc4e9cefff862f0f80a007022764d45eed on master.


Pub/Sub permission for Service Account on Kubernetes

In what area(s)?

/area runtime
/area test-and-release
Ask your question here
Dear Dapr Team,
I'm trying to deploy a Pub/Sub component using Kafka on Kubernetes. The Kubernetes cluster has fine grain permession for service account. I obtain the following error:
components.dapr.io "pubsub" is forbidden: User "system:serviceaccount:dapr-poc:dapr-poc-sa" cannot get resource "components" in API group "dapr.io"
It could be possibile to have a list of all permission needed?
Thanks.
Francesco

Does this help? https://github.com/dapr/dapr/blob/master/charts/dapr/charts/dapr_rbac/templates/ClusterRoleBinding.yaml

Apologies for jumping in here, but I have the same issue trying to deploy a component in kubernetes.  We have installed dapr to our k8s cluster using the helm chart as instructed with the "dapr-system" namespace.  Our applications are deployed in other namespaces in the same cluster.  I have a secret created in my application namespace, and now I am attempting to setup the component so my app can access the secret.  I am receiving the following error executing kubectl with the component.yml file:
Error from server (Forbidden): error when retrieving current configuration of: Resource: "dapr.io/v1alpha1, Resource=components", GroupVersionKind: "dapr.io/v1alpha1, Kind=Component" Name: "mat-dapr-dotnet-web", Namespace: "mat-dapr-dotnet-web-1" from server for: "component.yml": components.dapr.io "mat-dapr-dotnet-web" is forbidden: User "u-9d8fc" cannot get resource "components" in API group "dapr.io" in the namespace "mat-dapr-dotnet-web-1"
I'm guessing that our service account that is executing kubectl in our deployment pipeline needs some additional access to the API group "dapr.io" in order to deploy a component?  That account already has the "Cluster Owner" role.  I'm not confident I understand where components will be deployed in k8s.  Are they resources in the dapr-system namespace?  I'm not finding any clues in the Dapr Docs.
Any help would be appreciated.

Apologies for jumping in here, but I have the same issue trying to deploy a component in kubernetes. We have installed dapr to our k8s cluster using the helm chart as instructed with the "dapr-system" namespace. Our applications are deployed in other namespaces in the same cluster. I have a secret created in my application namespace, and now I am attempting to setup the component so my app can access the secret. I am receiving the following error executing kubectl with the component.yml file: Error from server (Forbidden): error when retrieving current configuration of: Resource: "dapr.io/v1alpha1, Resource=components", GroupVersionKind: "dapr.io/v1alpha1, Kind=Component" Name: "mat-dapr-dotnet-web", Namespace: "mat-dapr-dotnet-web-1" from server for: "component.yml": components.dapr.io "mat-dapr-dotnet-web" is forbidden: User "u-9d8fc" cannot get resource "components" in API group "dapr.io" in the namespace "mat-dapr-dotnet-web-1"
I'm guessing that our service account that is executing kubectl in our deployment pipeline needs some additional access to the API group "dapr.io" in order to deploy a component? That account already has the "Cluster Owner" role. I'm not confident I understand where components will be deployed in k8s. Are they resources in the dapr-system namespace? I'm not finding any clues in the Dapr Docs.
Any help would be appreciated.

Components need to be deployed in the same namespace of the apps that consume them.

Apologies for jumping in here, but I have the same issue trying to deploy a component in kubernetes. We have installed dapr to our k8s cluster using the helm chart as instructed with the "dapr-system" namespace. Our applications are deployed in other namespaces in the same cluster. I have a secret created in my application namespace, and now I am attempting to setup the component so my app can access the secret. I am receiving the following error executing kubectl with the component.yml file: Error from server (Forbidden): error when retrieving current configuration of: Resource: "dapr.io/v1alpha1, Resource=components", GroupVersionKind: "dapr.io/v1alpha1, Kind=Component" Name: "mat-dapr-dotnet-web", Namespace: "mat-dapr-dotnet-web-1" from server for: "component.yml": components.dapr.io "mat-dapr-dotnet-web" is forbidden: User "u-9d8fc" cannot get resource "components" in API group "dapr.io" in the namespace "mat-dapr-dotnet-web-1"
I'm guessing that our service account that is executing kubectl in our deployment pipeline needs some additional access to the API group "dapr.io" in order to deploy a component? That account already has the "Cluster Owner" role. I'm not confident I understand where components will be deployed in k8s. Are they resources in the dapr-system namespace? I'm not finding any clues in the Dapr Docs.
Any help would be appreciated.

Components need to be deployed in the same namespace of the apps that consume them.

@yaron2 Thank you for the reply.  If that is true, then I don't understand why I'm getting the forbidden error when trying to create the secretstore component in my namespace.  My user account has full access to that namespace.  I'm not sure what I am missing.  Also, shouldn't I be able to see the default "kubernetes" secretstore in the default namespace as a resource?  I am not seeing it in the UI.

@yaron2 I have the same issue as @xendren, unless I make a Role and RoleBinding Cluster wide, I get the error about forbidden. I note that in the example you sent that the role bindings are ClusterRole and ClusterRoleBinding. We're interested in Namespace scoped Roles and RoleBindings.  I've attached two sample yaml's to indicate what works and what gives the error. I'm sure I shouldn't have to give the CustomRole and CustomRoleBinding permissions, but I'm not sure what to use to avoid it
working and not working yamls.zip
.


[Feature Request] Support disableEnforceFocus in Modal Component

Is your feature request related to a problem? Please describe.
We present the react-plaid-link from the Modal component, and are facing an issue similar to the one discussed here.
Plaid keeps flickering, preventing the user from entering their credentials. Upon further inspection, the NextUI modal is preventing focus from leaving while it's open.
Describe the solution you'd like
To solve this problem, I'd like to see an disableEnforceFocus prop which behaves similarly to the behavior described in the Material UI Modal component.
Describe alternatives you've considered
As a workaround, we've been forced to modify how we present the Plaid experience, resulting in an inferior user experience.
Screenshots or Videos
No response

Following up on this issue - do you any suggestions for a workaround?


Create List of "Pinned Actions" on the side nav bar

The sidebar should have links to Home, Search, Your Library, Create Dashboard, Liked Insights, and Your Company.
It should match

When the items are hovered over, they should turn white. They should be clickable as links (that will not go anywhere at the moment)
When on a page, that page's link should be active (bright)
Acceptance Critera-

The sidebar component matches the image shown.
Visually, the links should turn white when hovered
The links should be clickable and can point anywhere atm
The links should be made "selected" - i.e when on the home page, it should remain white

All criteria met - https://gyazo.com/ce66e95a5a591987ff62e0cf8e578f2a


[feat]: deploy aa contracts on local devnet

Overview
Ports aa-contracts and allows to deploy the aa-contracts stack on local anchorage devnet

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (81c0f84) 29.68% compared to head (3901553) 30.79%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #108      +/-   ##
===========================================
+ Coverage    29.68%   30.79%   +1.11%
===========================================
  Files          152      127      -25
  Lines         4902     5169     +267
  Branches      1036      752     -284
===========================================
+ Hits          1455     1592     +137
- Misses        3418     3427       +9
- Partials        29      150     +121

Flag
Coverage Δ

cannon-go-tests
63.48% <ø> (?)

chain-mon-tests
27.14% <ø> (ø)

common-ts-tests
26.74% <ø> (ø)

contracts-bedrock-tests
19.44% <ø> (ø)

contracts-ts-tests
12.25% <ø> (?)

core-utils-tests
?

sdk-tests
?

Flags with carried forward coverage won't be shown. Click here to find out more.
see 65 files with indirect coverage changes


Delete draft Off topic answer

I would like to suggest that we delete the draft Off topic answer
I cant exactly understand the purpose of it.

If the answer itself is off topic and has nothing to do with the question asked?
a.  Answer should be flagged and deleted not just down voted and theirs probably nothing they can do to fix it.  So what is the point of us having a page for it?
b. IMO these pages should be used to help users fix there issues not just slap them on the wrist.
Someone answered an off topic question.
a. Well if you want to spend your time answering an off topic question that will probably be close then all power to you.
b.  It may just be the right answer and there for i wouldn't down vote you for your efforts.

So do we need this page?

Is it worth down voting a code only answer?   If the code is works and is correct while i agree not explaining the solution is a problem but is it really worth a down vote?
Code Only
I guess i am having an issue with the purpose of some of these drafts.

Well, there's a reason why they're in drafts... I pretty much agree with you on code only answers, but there are plenty of folks who do consider that bad practice and want to downvote to discourage it.
As for the off topic question, I disagree with deleting it. The specific purpose is to let people know that answering blatantly off topic questions is a bad thing. It encourages them, which is inconsiderate to the community. How informing the user of this via idvb is not just to get them to delete (thus getting back their rep) but also to encourage them to understand what is and is not on topic, and to join the community redirecting or closing and deleting off topic questions. "Delete your answer" isn't enough to justify the page, I agree. It's the other stuff that I think makes a page for it worthwhile.

I can try to improve them both to the point that they arnt condescending and we can leave them if you like.   No one says i have to personally use them :)


Pre release september

manage the consent

Codecov Report

Merging #6 (079a2f6) into master (47a2e55) will increase coverage by 1.34%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master       #6      +/-   ##
==========================================
+ Coverage   90.94%   92.29%   +1.34%
==========================================
  Files          27       28       +1
  Lines        1845     1933      +88
==========================================
+ Hits         1678     1784     +106
+ Misses        167      149      -18

Impacted Files
Coverage Δ

Source/Audience/FSDevice.swift
95.32% <ø> (ø)

Source/Audience/PresetContext.swift
96.90% <ø> (ø)

Source/Cache/FSBucketCache.swift
100.00% <ø> (+11.36%)
:arrow_up:

Source/Cache/FSCacheManager.swift
88.88% <ø> (+7.87%)
:arrow_up:

Source/Cache/FSStorage.swift
82.69% <ø> (-0.65%)
:arrow_down:

Source/Core/ABService.swift
86.77% <ø> (+1.65%)
:arrow_up:

Source/Core/Bucketing/FSBucketManager.swift
91.30% <ø> (+8.69%)
:arrow_up:

Source/Core/Bucketing/FSBucketService.swift
94.59% <ø> (+1.35%)
:arrow_up:

Source/Core/Bucketing/FSTargetingManager.swift
99.48% <ø> (+0.51%)
:arrow_up:

Source/Core/FSConfig.swift
100.00% <ø> (ø)

... and 45 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 47a2e55...079a2f6. Read the comment docs.


Emit notification if a newer version is available.

What problem are you trying to solve?
Print a notification that informs a newer version is available.
What's your suggested solution?
No response
Examples (if relevant)
No response
Is anything blocking this from being implemented? (if relevant)
No response
Definition of Done
No response

Issue migrated to JIRA: INFRA-13


Skip Select All action on disabled props

As of now if prop is disabled you can still toggle checkbox's value via select all, but instead it should stay frozen

Resolved in v2.0.7


RSC15a as a part of 0.9

Please review and merge if everything looks good.

Please review and merge if everything looks good.

@mattheworiordan could you please find some spare time to take a look at 1cef166 ?

Rebased and tests are passing.


test

Signed-off-by: Igor Gnatenko<EMAIL_ADDRESS>

retest this please

retest this please


Convert perspective-el to lexical scope

Time to append
-*- lexical-binding: t -*-

to the first line of perspective.el. (And fix whatever breaks as needed.)

YES PLEASE

I think I'm close. I'm also removing cl at the same time. Currently battling with one last test:
Test state-save-and-load condition:
    (wrong-type-argument persp--state-complete "#s(persp--state-complete ...))

I'm not positive, but maybe something to do with cl defstruct vs cl-lib cl-defstruct?

I think I have this now... Gonna bang on it for a while...

 Everything SEEMS fine.
😛🤷♀

I just set up my work environment with the following PRs and changes in a local "release candidate" branch:

https://github.com/nex3/perspective-el/pull/95 (stability and cleanup improvement)
https://github.com/nex3/perspective-el/pull/109 (byte compile warnings)
https://github.com/nex3/perspective-el/pull/112 (lexical scope switch)

I will run it through its paces as I work over the next day or two. If I don't see any bugs, let's merge all that in. Maybe cut a new version tag for melpa-stable users also — these PRs are all great improvements.

The change has been stable for me. Very happy with it.


Implement custom constructor/proxy types

Adds constructor= and constructor_factory= arguments to tyro.conf.arg() and tyro.conf.subcommand(). This enables significantly more flexibility for instantiating types from the CLI.
There are a lot of complexities associated with how defaults are handled and reflected in the helptext. A basic example is dict2 in the example script:
def dict_json_constructor(json: str) -> dict:
    """Construct a dictionary from a JSON string. Raises a ValueError if it fails."""
    out = json_.loads(json)
    if not isinstance(out, dict):
        raise ValueError(f"{json} is not a dictionary!")
    return out

# A dictionary type, but `tyro` will construct it with JSON.
JsonDict = Annotated[dict, tyro.conf.arg(constructor=dict_json_constructor)]

def main(
    dict1: JsonDict,
    dict2: JsonDict = {"default": None},
) -> None:
    print(dict1)
    print(dict2)

cc #79

FYI @jkulhanek I think this would be useful for the AnnotatedDataParserUnion + circular imports thing we chatted about at ICCV!
Like we could have:
SelectableDataParserConfig = Annotated[
    DataParserConfig,
    tyro.conf.arg(constructor_factory=some_function_that_returns_the_dataparser_union_type)
]

or, potentially:
@tyro.conf.configure(
    tyro.conf.arg(constructor_factory=some_function_that_returns_the_dataparser_union_type)
)
class DataParserConfig:
    ...


Combined changes requested other than nav menus

Updated out of date social media footer links
Removed Client Charter
Removed sentence stating there are no employed positions
Changes to prices and adding formatting for tables on costs documentation
Note about different annual fees for parachurches on pricing section
Added og:image for linking site on social media

Helps when I actually read the error properly... I'll make sure to run a test before committing from now on.


Sometimes all code is colored

Sometimes, especially when changing or entering code, the entire code is colored and not just the brackets.

Also seeing this. For me, the scattered character colorization usually resolves after a scroll event.

Same problem

The same in my case.

Duplicate of #28 ?

@Zenathor, yes, this is a duplicate of #28


Too many steps created

M1 A100000 V40 R1000 M2 A100000 V40 R1000
yields in simavr 1010 steps.
While M1 A100000 V40 R1000 yields as expected 1000 steps
With two steppers only speeds lower than ~430us work:
M1 A100000 V430 R1000 M2 A100000 V430 R1000

Better implementation of avr Stepper ISR. Now should not loose steps, but may get delayed due to other code

Better implementation of avr Stepper ISR. Now should not loose steps, but may get delayed due to other code


@conda-forge-admin, please rerender

Additional comment:
@conda-forge-admin, please rerender

Somehow the _10 builds build after https://github.com/conda-forge/libignition-gui-feedstock/pull/48 was never updated to anaconda.org , not sure why.


Elastic social buttons in cards

I added specific font sizes by using the different breakpoints of the minimal mistakes theme. Base size for everything smaller than 600px is currently defined with $type-size-1. For bigger screens the icons get smaller.
I am not used the the breakpoints mixin. So if anybody knows how to do this more effectively, please go ahead :)

Closes #48.

What is this fixing? I think I liked how it looked like previously.

What is this fixing? I think I liked how it looked like previously.

Previously you were not able to click the buttons. Touch areas need to have a given size to be usable at all.

If that would be problematic! :)

Within Firefox, there is a responsive Design Mode (https://developer.mozilla.org/en-US/docs/Tools/Responsive_Design_Mode). That's quite useful to test the page for mobile devices. I used this for testing an iPad

Within Firefox, there is a responsive Design Mode (https://developer.mozilla.org/en-US/docs/Tools/Responsive_Design_Mode). That's quite useful to test the page for mobile devices. I used this for testing an iPad

I also tested in the browser for different devices. But it still feels a bit different looking on the webpage and using a mouse or trying to grab those buttons with your finger 😆


Casting mi values to str and casting back to int for sig testing

This needs further adjustments at a later time.


FullText Lucene Index is not working using 'containstext' contraint

OrientDB Version: 2.2.33
Java Version: openjdk 1.8
OS: alpine 3.4
Expected behavior
Let jSon a String field on Analysis.
select * from Analysis where jSon containstext 'zzz' limit 10
give me the correct value without UI warning
Actual behavior
the query give me the correct values but takes too much time. The query execution time is exactly the same if I drop the index.
Also, the UI give me a warning suggesting me to use an index (that is already used).

Steps to reproduce
Just Create some Vertices with String field jSon and use the where contition on it.

Hi @gianluca-valentini
CONTAINSTEXT is intended to be used with legacy FULLTEXT indexes, if you want to use LUCENE indexes you have to use full text search funcitons, see https://orientdb.com/docs/3.0.x/indexing/Full-Text-Index.html
Thanks
Luigi


CVE-2023-26119(9.8) on neko-htmlunit-2.66.0.jar dependency

Starting at around 10.Apr.2023, the following started to fail on the Java project:
[ERROR] One or more dependencies were identified with vulnerabilities that have a CVSS score greater than or equal to '8.0':
[ERROR]
[ERROR] neko-htmlunit-2.66.0.jar: CVE-2023-26119(9.8)

This dependency comes from the latest esapi.jar
+- org.owasp.esapi:esapi:jar:<IP_ADDRESS>:compile
|  +- xom:xom:jar:1.3.8:compile
|  +- commons-beanutils:commons-beanutils:jar:1.9.4:compile
|  |  +- commons-logging:commons-logging:jar:1.2:compile
|  |  \- commons-collections:commons-collections:jar:3.2.2:compile
|  +- commons-configuration:commons-configuration:jar:1.10:compile
|  +- commons-lang:commons-lang:jar:2.6:compile
|  +- org.apache.commons:commons-collections4:jar:4.4:compile
|  +- org.apache-extras.beanshell:bsh:jar:2.0b6:compile
|  +- org.owasp.antisamy:antisamy:jar:1.7.2:compile
|  |  +- net.sourceforge.htmlunit:neko-htmlunit:jar:2.66.0:compile
|  |  +- org.apache.xmlgraphics:batik-css:jar:1.16:compile
|  |  |  +- org.apache.xmlgraphics:batik-shared-resources:jar:1.16:compile
|  |  |  +- org.apache.xmlgraphics:batik-util:jar:1.16:compile
|  |  |  |  +- org.apache.xmlgraphics:batik-constants:jar:1.16:compile
|  |  |  |  \- org.apache.xmlgraphics:batik-i18n:jar:1.16:compile
|  |  |  \- org.apache.xmlgraphics:xmlgraphics-commons:jar:2.7:compile
|  |  +- xerces:xercesImpl:jar:2.12.2:compile
|  |  \- xml-apis:xml-apis-ext:jar:1.3.04:compile
|  \- xml-apis:xml-apis:jar:1.4.01:compile

The ticket in antisamy — https://github.com/nahsra/antisamy/issues/321
The ticket in neko-htmlunit — https://github.com/HtmlUnit/htmlunit-neko/issues/20

The dependency tree listed is for the artifact created from the ESAPI/esapi-java-legacy baseline, which is a different repository.
https://github.com/ESAPI/esapi-java-legacy/
Per the tree you've listed, please note that nekohtml is a dependency of antisamy, not of the ESAPI project.
|  +- org.owasp.antisamy:antisamy:jar:1.7.2:compile
|  |  +- net.sourceforge.htmlunit:neko-htmlunit:jar:2.66.0:compile

The Antisamy team is very responsive to CVE's in the project, but if you'd like to ensure they are aware please follow up with them in the Antisamy github project.
https://github.com/nahsra/antisamy
Worth noting that this dependency is already updated in the development baseline to v 2.70.0
https://github.com/nahsra/antisamy/blob/main/pom.xml
ESAPI is currently using the latest released version of antisamy.  Until a new version of Antisamy is available there is no additional action that can be taken by the ESAPI team.

This is already on the AntiSamy folks' GitHub issues and I've been working with their team for the past day and a half or so. We can't do anything until they upgrade and since this is a major revision (2.70.0 --> 3.0.0) there are LOTS of interface changes so it may take a while. If you are not using any of the HTTPUtilities.getSafeValidInput methods, it shouldn't affect you as I think that is the only place we use AntiSamy.

Also, be careful when creating issues. This should have been on ESAPI/esapi-java-legacy not ESAPI/esapi.

Have done some work on the AntiSamy update - the update itself is not that tricky but there was a regression on neko 3.0.0 that introduces some problems. Will make a fresh snapshot build of Neko 3.1.0 and a PR for the needed updates. If the team is happy with this i will make a release.

Have done some work on the AntiSamy update - the update itself is not that tricky but there was a regression on neko 3.0.0 that introduces some problems. Will make a fresh snapshot build of Neko 3.1.0 and a PR for the needed updates. If the team is happy with this i will make a release.

AntiSamy PR 322 for those of you are are wondering and not watching the AntiSamy repo.


chore: refactor jan-inference -> Nitro repo

Nitro, at the moment, encompasses:

llama-python-backend, llama.cpp
C++ server
Accelerated models (submodule?)
GGML models (submodule?)

The point is that we'll be adding more to it long term

This is no longer the case since we plan to support ggml inside nitro as well


propertyIsEnumerable null reference exception in IE 11

I'm submitting a bug report

Library Version:
1.2.1

Please tell us about your environment:

Operating System:
Windows 10

Node Version:
6.3.1

NPM Version:
3.10.3

JSPM OR Webpack AND Version
webpack 2.2.1

Browser:
IE 11

Language:
ESNext

Current behavior:
Using ag-grid we're consistently getting the following exception in IE 11 when onGetRows fires:

Expected/desired behavior:
No null reference exception appears.

In symbol.js change propertyIsEnumberable to this:
propertyIsEnumerable = function propertyIsEnumerable(key) {
      var uid = '' + key;
      return onlySymbols(uid) ? (
        hOP.call(this, uid) &&
        this[internalSymbol] &&
        this[internalSymbol]['@@' + uid]
      ) : pIE.call(this, key);
    }

I'd be happy to submit the PR, but am unfamiliar with your process.

We welcome your PR. Don't worry about the process too much for the first time. You'll be asked to sign the CLA and we may want to edit the commit title. We can walk you through that after you submit, if needed. Thanks!

This fixes our issue with the usage of Symbol in IE11, and appears to be a pretty straightforward null check. What steps are needed to get this merged in? It would be great to get this in the next version as I'm currently hotfixing in the node_modules, but I know that's eventually going to burn me (is that why it's called a hotfix?)

Merged fix. Releasing in a few minutes.


EBKH/Branches protection [WIP]

Enable the Branch Protection (Get, Update, Delete) to the API

I'll add the other actions soon, this too, works fine, but tests fails when updating dependencies

Coverage increased (+0.7%) to 91.815% when pulling ab09b0a8634fe5360f967da92a151fe2c742d5bc on valiot:Branches-Protection into 93b4dfc96dd8cd934ff3508848758293879b0edb on edgurgel:master.


Remove unused components

fixes #459

Please make sure that all the checks pass. Please add here any additional information regarding this pull request. It's highly recommended that you link this PR to an issue (please create one if it doesn't exist for this PR)

Hey @pdelboca,
Can you please take a look at why it might be failing? I merged the main and still doing so

Looks like an upstream issue with the setuptools package: https://github.com/pypa/setuptools/issues/4519


 When I remove it then the git completion starts magically working again.
Thanks for your great work here!
(Paging @dgoodlad.)

This looks not to be fixed, please see:
https://github.com/robbyrussell/oh-my-zsh/issues/766

OK let me reopen while I investigate.

There are known issues with our zsh completion, some of which might be related to this one: https://github.com/github/hub/issues?q=is%3Aissue+is%3Aopen+zsh
@brodock Which oh-my-zsh plugins do you have loaded?

@mislav plugins=(git git-extras git-remote-branch postgres rails ruby brew bundler zeus)

@mislav Did you get any more insight here?

No, it's something I still need to look at within the hub repo. It doesn't have anything to do with puppet-hub, though. There are enough open issues in hub repo about this, so there's no reason to keep this open.

Cool, thanks!


Ring instrumentantions

Could you add a test please? I also believe the fix should be in Ring.clone,,,

done


config.json: add info for queen-attack

see #345
change difficulty
add topics

I'm a little uncertain about these topics, any thoughts?

Why booleans? Is is because the result is a true/false?
One keyword that may be appropriate is something along the lines of "matrix" or "multi-dimensional (array)" since that is the conceptual visualization?

Perhaps "Errors" would be a good topic since this (and hamming) is an early exercise requiring errors as part of the function sig.

I like both these suggestions, I'll add them in. :+1:


Everything takes 5.6GB Archlinux/retdec-4.0-2

I've build using AUR PKGBUILD and not sure if it should take 5.6GB.
Is it normal?
https://aur.archlinux.org/packages/retdec/
https://aur.archlinux.org/cgit/aur.git/plain/PKGBUILD?h=retdec
647M    pkg/retdec/usr/share/retdec/support/generic/yara_patterns/static-code/elf
4,7G    pkg/retdec/usr/share/retdec/support/generic/yara_patterns/static-code/pe
4,2G    pkg/retdec/usr/share/retdec/support/generic/yara_patterns/static-code/pe/32
488M    pkg/retdec/usr/share/retdec/support/generic/yara_patterns/static-code/pe/64
610M    pkg/retdec/usr/share/retdec/support/generic/yara_patterns/static-code/elf/32
38M     pkg/retdec/usr/share/retdec/support/generic/yara_patterns/static-code/elf/64

retdec git by somebody else at 20201114_7b437f51-1 took only 1.3GB. Maybe something has changed in retdec, maybe new compiler or compiler flags caused that, but it's waay smaller than mine build
du -hs /usr/share/retdec/support/generic//yara_patterns/static-code//
155M    /usr/share/retdec/support/generic//yara_patterns/static-code/elf/32
9,6M    /usr/share/retdec/support/generic//yara_patterns/static-code/elf/64
782M    /usr/share/retdec/support/generic//yara_patterns/static-code/pe/32
118M    /usr/share/retdec/support/generic//yara_patterns/static-code/pe/64

Hi, we are not maintainers of the AUR PKGBUILD. When we pack our release we don't tend to include the static code signatures that you have listed and that's why the other retdec build you have seen was much smaller.
You can look at what we usually pack in the release here: https://github.com/avast/retdec/releases/download/v4.0/retdec-v4.0-debian-64b.tar.xz
Taken from: https://github.com/avast/retdec/releases/download/v4.0

https://github.com/avast/retdec/releases/download/v4.0/retdec-v4.0-debian-64b.tar.xz linked above is literally also 5.6 GB for the exact same reason.


Fall 2017 patch issue: cannot close the "map pins" box properly

If I open the map pins box, I can't close it by pressing the same button. Current workaround is to toggle the map options box on and off.

part of #152


elemental-system-agent (seems to be) started before timesyncd

What steps did you take and what happened:
[A clear and concise description of what the bug is.]
When booting an installed image on Raspberry Pi, elemental-system-agent complains about
panic: error while connecting to Kubernetes cluster: Get "https://<IP_ADDRESS>/k8s/clusters/local/version": x509: certificate has expired or is not yet valid: current time 2022-11-03T12:01:01Z is before 2022-12-01T14:19:13Z

after a while these messages stop as systemd-timesyncd kicks in.
Raspberry Pi has no (buffered) hardware clock and depends on network and timesyncd to get the correct date/time.
What did you expect to happen:
elemental-system-agent not getting in panic.
Anything else you would like to add:
[Miscellaneous information that will assist in solving the issue.]
Environment:

Elemental release version (use cat /etc/os-release):
Rancher version:
Kubernetes version (use kubectl version):
Cloud provider or hardware configuration:

same for obs https://build.opensuse.org/request/show/1041879

#575 should fix that.


Error executing script

I have installed all modules and copied the custom message example into VS Code. When I ran the code, it returned
UnhandledPromiseRejectionWarning: Error: 400 Bad Request

I also face the same problem.


feat: new spam test

Description

Spam test for AC
Testing

Breaking Changes

Closes

close https://github.com/vegaprotocol/OctoberACs/issues/390
close https://github.com/vegaprotocol/OctoberACs/issues/392
close https://github.com/vegaprotocol/OctoberACs/issues/394

{“vega":"9755-spam-stats-extension"}

{"vega":"develop"}

moved to https://github.com/vegaprotocol/system-tests-nbc/pull/4


Failed to execute 'matches' on 'Element'

The plugin stops working recently after I upgraded it to version 0.5.1 . No response after clicking any image.
The console shows the following error message:
Uncaught DOMException: Failed to execute 'matches' on 'Element': 'img:not(a img)' is not a valid selector.
    at HTMLDivElement.<anonymous> (app://obsidian.md/app.js:1:133015)
    at HTMLDocument.s (app://obsidian.md/app.js:1:135596)

The corresponding lines of code:
        N(Element.prototype, "matchParent", (function(t, e) {
            if (this.matches(t))  // this line triggers the exception
                return this;
            if (this === e)
                return null;
            var n = this.parentElement;
            return n ? n.matchParent(t, e) : null
        }
        )),

My current obsidian version is v0.13.19 .

I tried reinstalled the plugin, the settings are the default ones.

I solved the problem by reinstalling with latest installer.


plot_topo should be a method of evoked?

Silly question, but I was expecting to do:
evoked.plot_topo()

instead of
from mne.viz import plot_topo
plot_topo(evoked)

anything against this? cc @jaeilepp interactive visualization is your department ;-)

that would be useful

why not

The plot topo takes lists of evokeds too. I think that's why we kept it like that.

On 25 Jun 2015, at 15:25, mainakjas<EMAIL_ADDRESS>wrote:
Silly question, but I was expecting to do:
evoked.plot_topo()
instead of
from mne.viz import plot_topo
plot_topo(evoked)
anything against this? cc @jaeilepp interactive visualization is your department ;-)
—
Reply to this email directly or view it on GitHub.

I see, that makes sense but I guess it shouldn't be too hard to add a modified version of this function as a method to evoked. I use it all the time to look at my data.

it should not be too much lines of code indeed.

@mainak you could also subclass Evoked from list to make it work more
flawlessly ;)
2015-06-26 9:12 GMT+02:00 Alexandre Gramfort<EMAIL_ADDRESS>
it should not be too much lines of code indeed.
—
Reply to this email directly or view it on GitHub
https://github.com/mne-tools/mne-python/issues/2240#issuecomment-115555020
.

This one's done by #2241


Make text buttons translatable, add 'lang' option

This PR makes text buttons translatable, adds i18n-example and a new "lang" option (so the example was possible to implement).
[#128761165]

This looks good to me. :+1:


Please any help ! I can not access "app_data" only "documents" works.

Describe the bug
firstly, I made a container Id with "a".
when I call CloudStorage.appendFile(path, content) I got the error like this.
ERR_DIRECTORY_NOT_FOUND app_data
but, when after CloudStorage.setDefaultScope("documents"); It works.
At first, I thought I couldn't find it because the names of the bundle identifier and container ID identifier were different.
My bundle identifier was com.a-test, and I realized that the cloud container Id was set to iCloud.com.a, so I created a new container Id iCloud.com.a-test.
However, app_data is still not found.
I don't want the data to be saved to be visible to the user.
Please help.
(When I already checked Cloud is available by your method)
Environment:

Device: Mobile
OS: iOS 17.0

Unfortunately, I'm not able to reproduce this on my end. The container ID indeed needs to be iCloud.com.a-test when the bundle identifier is com.a-test, so that might've caused the initial trouble. Beyond that, this seems like a configuration issue I can't diagnose on my end.
If you can provide a repository with a minimal reproducible example, I should be able to help you further.


Add support for entity_categories

Minor refactor to enable support for entity_categories. https://developers.home-assistant.io/blog/2021/10/26/config-entity
This moves the required Home Assistant version to 2021.11

@leikoilja Good catch!


Statebox changes atop kettlebell (WIP)

This is just here to show which contributions we have lying around; the PR shouldn't actually be merged in the current form; instead, it should be separated into different feature branches.

Oops, I meant to make this PR on my own fork.


Bug: organization, getOrganization returning string instead of KindeOrganization

Prerequisites

[X] I have searched the repository’s issues and Kinde community to ensure my issue isn’t a duplicate
[X] I have checked the latest version of the library to replicate my issue
[X] I have read the contributing guidelines
[X] I agree to the terms within the code of conduct

Describe the issue
The TS types are lying:
export type KindeOrganization = {
  orgCode: string | null;
};
export type KindeState = {
  organization: KindeOrganization;
  getOrganization: () => KindeOrganization;
  getUserOrganizations: () => KindeOrganizations | null;
};

but when running the code I'm getting:

Library URL
https://github.com/kinde-oss/kinde-auth-nextjs
Library version
2.2.3
Operating system(s)
macOS
Operating system version(s)
n/a
Further environment details
Next.js 14.2.2
Reproducible test case URL
No response
Additional information
No response

Thanks for raising @Thinkscape, we'll fix in the next release

Mates, I'm on 2.2.5 and it's still borked.

The access token contains:
  "org_code": "org_REDACTED",
  "org_name": "Default Organization",

Just closing this off now, the organization helpers in getKindeSession and useKindeBrowserClient now return the correct types.
export type KindeOrganization = {
  orgCode: string | null;
  orgName?: string | null;
  properties?: {
    org_city?: string;
    org_country?: string;
    org_industry?: string;
    org_postcode?: string;
    org_state_region?: string;
    org_street_address?: string;
    org_street_address_2?: string;
  };
};

export type KindeOrganizations = {
  orgCodes: string[];
  orgs: {
    code: string;
    name?: string;
  }[];
};


fix quirks noticed when reworking beta.gouv.fr homepage

There were inconsistencies when using template on beta.gouv.fr, this fixes:

responsive on header and footer
wrong color in hero title

Also did I forget to push package.json modifications? 🤔

You did not forget about package.json it's just in another PR https://github.com/etalab/template.data.gouv.fr/pull/54/files


BitMEX tickers: wrong url composition?

Hi,
I see an invalid url composed by ExchangeBitMEXAPI: am I alone to get it? :-D
Thanks.

Thanks for filing this bug. If you send a pull request with the solution, we'll be happy to merge it. If you don't know how, you can also post the updated code here.


FindBar not working for case insensitive values

It behaves differently from the very common searching methods. For ex- If you want to search "getResults" and you type "getresults" , it won't find anything . So , this patch actually fixes this.

@gitexperience it is working as expected when i tried it out.

When the circled Aa button is not pressed, a case insensitive search is performed.; and when it is pressed, a case sensitive search is performed. I see that it is working as expected.

Ohh yes! I have disturbed my own local fork and that's why it is creating problem .With a new one it works fine for me too , so no use of that PR ..


Drag-drop of HTTP URL on reader view's chrome / UI => BrowserWindow loads URL!

This default Electron behaviour can be stopped using the following code snippet:
    window.document.addEventListener("dragover", (ev) => {
        ev.preventDefault();
        return false;
    }, false);

    window.document.addEventListener("drop", (ev) => {
        ev.preventDefault();
        return false;
    }, false);

Note that the main "navigator" rectangular area in the reader view already intercepts links / navigation events (it automatically opens an external web browser for HTTP URLs not recognized by the navigator instance).
The BrowserWindow for the library view already handles drag/drop for local files, not so affected by this bug.

It seems to be fixed

Yes indeed, this seems to be fixed now. Not sure what changed in the code.
The reader view does not have a DropZone, so I am not sure what currently prevent the drop events:
https://github.com/readium/readium-desktop/blob/541e48bbe45407a8918018e0076d4ca5ebecd68b/src/renderer/components/reader/App.tsx#L28-L33
Conversely, the library view has a DropZone which handles local files:
https://github.com/readium/readium-desktop/blob/541e48bbe45407a8918018e0076d4ca5ebecd68b/src/renderer/components/App.tsx#L78-L108
Oh well, the bug does not exist anymore, so let's close :)

PS: maybe the change from Electron v1 to v3 introduced this new behaviour.


Percent threshold help text is wrong

gostatsd may not flush /calculate additional percentiles when --percent-threshold {90,95,99}
For example, w/systemd
[Unit]
Description=gostatsd
After=network.target

[Service]
Type=simple
Restart=on-failure
RestartSec=3s
WorkingDirectory=/home/gostatsd
ExecStart=/bin/bash -c "/home/gostatsd/gocode/bin/gostatsd \
  --config-path=/home/gostatsd/config/staging.toml \
  --percent-threshold {90,95,99} \
  --flush-interval 10s \
  --verbose"

[Install]
WantedBy=multi-user.target

upper_90 exists but not upper_95 or upper_99.

I believe what is happening here is it can't parse {90,95,99} so it falls back to the default (90).  Arguably it should fail to start in this case.
Try using --percent-threshold "90 95 99".

Thanks @tiedotguy!
I updated ExecStart to
ExecStart=/home/gostatsd/gocode/bin/gostatsd \
  --config-path=/home/gostatsd/config/staging.toml \
  --percent-threshold "90 95 99"  \
  --flush-interval 10s \
  --verbose

which did the trick.
Maybe a PR is in order to fix -help or I am misunderstanding?
--percent-threshold string                       Comma-separated list of percentiles (default "90")

Nope, not a misunderstanding! It's legacy (buggy) text, from behavior changed in #130, I'll keep this issue to fix it.

Addressed by #182

This shook out another bug in viper, addressed in 7.0.1

Thanks @tiedotguy


delete rails 5.x support

Why?
scimaenaga looks like support 5.x but actually there are no tests for rails 5.x.
What?
delete rails 5.x support.

方針を確認したのでこれはやらなくてよい。
逆にBrakemanのrailsに関する成約を緩めましょう


Fixed typo in code

It said 'pprint' instead of 'print'

That's not a typo, see https://github.com/plamere/spotipy/blob/50c4f8479513efe0545fd3da4b7ec9541522a962/examples/playlist_tracks.py#L3


Alfred 4 related changes

Minor changes to scripts required to make it work with Alfred 4 again.

I'll try in few weeks (ノω・。)

Here is a forked version that's working. Haven't tested it properly though.
https://github.com/thepratik/alfred4-youtube-control


i can  not find the exactly class

in my find source code ,have two class the one is class="download" the other is class ="download downloadBox",i don`t want to math the class "download",i want to Each the class ="a class="download downloadBox"" ,the html is other website,i want to loop the site,what should i do?

Hello,
If what you want is the elements with downloadBox (but not just download), then you can use this:
// assuming doc is a *goquery.Document created from your HTML data
doc.Find(".downloadBox").Each(func (i int, s *goquery.Selection) {
   // do something with each `s`, which is an element with the downloadBox class
})

Hope this helps,
Martin


Selvach/remove donation

Description
Remove UK donation module now the campaign has run it's course.
On what platform have you tested the change?

[ ] Android - Emulator
[ ] Android - Physical device
[ ] iOS - Emulator
[ ] iOS - Physical device

Screenshots
Please attach screenshots showing the change if relevant
Checklist

[ ] I have updated mockServer
[ ] I've added analytics as relevent
[ ] I have run npm test
[ ] I have run npm run test:i18n

Out of scope and potential follow-up
Is there any related changes that you plan to do in a follow-up PR or voluntarily excluded from the scope?

@selvach Might need to rebase?

@snack-0verflow Fixed the base branch!


Gitlab login broken

Description
Login with GitLab leads to the following error message.
The requested scope is invalid, unknown, or malformed.

A possible repeat of #817 ?

I kind of think the app we're using over at gitlab still points to the beta page. Probably was forgotten when we switched to live.

This should be fixed now. Can you try again?

It wasn't working for me over the weekend but it does work now, so at least for me, this is fixed now. Thanks!


Add a test file for FileExistsError

Going to test out how this works...

Codecov Report

Merging #5 (0250cd4) into main (0c288f4) will increase coverage by 26.99%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             main       #5       +/-   ##
===========================================
+ Coverage   39.67%   66.66%   +26.99%
===========================================
  Files         328        2      -326
  Lines       23250        6    -23244
  Branches     4790        0     -4790
===========================================
- Hits         9224        4     -9220
+ Misses      13573        2    -13571
+ Partials      453        0      -453

Flag
Coverage Δ

unit
66.66% <ø> (+26.99%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

packages/file-explorer/src/FileStorage.ts
0.00% <0.00%> (-100.00%)
:arrow_down:

packages/console/src/csv/CsvParser.js

packages/utils/src/InvalidMetadataError.ts

packages/components/src/ToastNotification.tsx

...ckages/iris-grid/src/format-context-menus/index.js

packages/chart/src/ChartUtils.js

packages/chart/src/ChartModelFactory.js

packages/iris-grid/src/formatters/index.js

...ackages/iris-grid/src/sidebar/TableCsvExporter.jsx

packages/code-studio/src/styleguide/Colors.jsx

... and 318 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0c288f4...0250cd4. Read the comment docs.

Codecov Report

Merging #5 (e5d4338) into main (db43a23) will decrease coverage by 2.61%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main       #5      +/-   ##
==========================================
- Coverage   39.67%   37.05%   -2.62%
==========================================
  Files         328      294      -34
  Lines       23250    21704    -1546
  Branches     4790     4869      +79
==========================================
- Hits         9224     8043    -1181
+ Misses      13573    13202     -371
- Partials      453      459       +6

Flag
Coverage Δ

unit
37.05% <ø> (-2.62%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

...es/iris-grid/src/formatters/CharColumnFormatter.js
0.00% <0.00%> (-50.00%)
:arrow_down:

packages/console/src/monaco/MonacoUtils.js
1.21% <0.00%> (-41.34%)
:arrow_down:

packages/utils/src/TimeoutError.ts
0.00% <0.00%> (-33.34%)
:arrow_down:

...ages/iris-grid/src/sidebar/icons/HistogramIcon.tsx
0.00% <0.00%> (-33.34%)
:arrow_down:

packages/components/src/SearchInput.tsx
8.33% <0.00%> (-30.56%)
:arrow_down:

...console-history/ConsoleHistoryResultInProgress.jsx
5.26% <0.00%> (-28.08%)
:arrow_down:

packages/console/src/common/ObjectIcon.tsx
10.00% <0.00%> (-25.72%)
:arrow_down:

...ckages/iris-grid/src/sidebar/CustomColumnInput.jsx
13.04% <0.00%> (-24.46%)
:arrow_down:

...nents/src/context-actions/GlobalContextActions.tsx
0.00% <0.00%> (-21.43%)
:arrow_down:

...rc/format-context-menus/FormatContextMenuUtils.jsx
0.00% <0.00%> (-20.00%)
:arrow_down:

... and 255 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update db43a23...e5d4338. Read the comment docs.


Set-Output/Set-State Deprecation Update2

Remaking https://github.com/devcontainers/ci/pull/181
Update to handle change for set-output and save-state syntax as per: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
I hope this quote placement is correct. I apologize I don't know how to test locally before pushing.
Why is it being echoed instead of output without echo?

/test fa4a64b

@stephenandary - thanks for pushing on this. I was initially confused why the changes you made were failing and the error message didn't seem helpful at all!
I just spent some time going through this and realised that that script is run in the dev container, so the GITHUB_OUTPUT environment variable wasn't set. I just added that and kicked off a task but realised afterwards that GITHUB_OUTPUT will be pointing to a path that doesn't exist inside the dev container, so will need an additional mount point. This isn't currently supported by the action (and I don't think it is supported by the CLI yet either), so there are a few steps needed to enable this.

@microsoft-github-policy-service agree [company="Jammin Music, Inc"]
@stuartleeks I didn't think to grep other repositories! The only references I found in the CI repo were those 2 lines. I will take a peak at the cli repo now.

@microsoft-github-policy-service agree company="Jammin Music, Inc."

For the CLI I think it can handle multiple mount-points based on:  devContainersSpecCLI.ts#L112
Therefore do you think it is possible to just add the additional mounts in the devcontainer up ci command? I am assuming it is similar to files like start.sh
Going to grep now to see where/if a similar command is used in ci (I imagine it is)

As you mentioned ,the action is written in TypeScript. The dist folder is the output from the TypeScript compilation step.
This repo contains the code for both a GitHub Action and an Azure DevOps Task. Common code between the two is in the common folder.
My starting point would probably be to modify the DevContainerCliUpArgs in the common code to include additional mounts.
Then in the GitHub action code, add the logic to set mounts for the files listed in the Handle GITHUB_OUTPUT issue, and set the env vars for the dev container to point to the location of the mount inside the container.
Hope that makes sense?

Cool! I am working on something else during the week, but I can try to get to that this weekend

I haven't gotten to this yet, I didn't realize the date when I said "I can try to get to it on the weekend" haha. I have not forgotten about it.

@stephenandary - just checking back, is this still something you plan to work on?

@stephenandary - just checking back, is this still something you plan to work on?

@stuartleeks I was looking at this over the weekend and am not too sure how to do what is needed. If I could work with someone, or if it is easier for someone else with experience to do this that will be faster.

@stuartleeks, do you think I am on the right track for the above? Would it be worth adding more time?

@stephenandary - I'm currently working to fix up some PR build issues. After that, getting this resolved is fairly high on my list.
To answer the question about the CLI args, you would need to use --mount to pass the additional mounts in

@stephenandary - I'm currently working to fix up some PR build issues. After that, getting this resolved is fairly high on my list.
To answer the question about the CLI args, you would need to use --mount to pass the additional mounts in

Awesome, and thank you. I would still like to help get this done as long as I am not negatively impacting timeline. I apologize, I have never worked with TS before, so when I have time to look at it I am not very quick. I will try to spend more time soon.

@stuartleeks I am almost done working on something else that has been taking the bulk of my time. I would like to put this in my calendar for later this week to work on. Do you think a new PR should be used? I am not sure how stale this has become yet.

@stephenandary - great news!
Whichever option you prefer is fine. If you continue on this branch, it would be worth merging main into it. You'll get merge conflicts on the generated JS code, but running the local build script will iron that out.

@stephenandary - if you haven't already started work on this, you may want to branch off latest main as I've just pushed through some changes that mean that the compiled JS is no longer a part of the repo. Hopefully this will simplify the process for contributing going forwards and reduce merge conflicts between PRs :-)

@stephenandary - if you haven't already started work on this, you may want to branch off latest main as I've just pushed through some changes that mean that the compiled JS is no longer a part of the repo. Hopefully this will simplify the process for contributing going forwards and reduce merge conflicts between PRs :-)
I've also added some additional logging in the build, and there seems to be an issue with the set-output values not working reliably. Since that approach is deprecated, I'm keen to see what we've discussed here implemented so that we can move off that approach, and hopefully improve the reliability of the builds/releases. If you don't think you will get time to send a PR then let me know 😄

@stuartleeks I was doing some tangental work to dive back into this yesterday, but when I try to build devcontainer and run it I am unable to start a terminal in vscode and get a pty timeout. I found an issue related to it but changing versions like others doesn't work for me. It is making it a challenge to get to a point where I can test changes, though I don't think it affects CI and only vscode so I can just keep running CI builds.
I am going to work on what has been discussed today. If you have time for a synchronous conversation to help me get my bearings again that would be wonderful. I will close and tag this PR and start a new one with this PR tagged in it so that I don't need to show a merge in commit.

Are you in the devcontainers community slack channel? (https://github.com/devcontainers/ci/issues/180#issuecomment-1317900727)

I just requested, I have not joined yet because I don't think I have slack connect, I just use free tier.

No worries - feel free to email me<EMAIL_ADDRESS>

Thanks @stuartleeks. I just ran into a router hiccup, and I think you are in a different time zone so I will do my best to get as far as I can by Monday and then email.

What timezone are you?

Eastern, I usually see your posts come in earlier so guessing you are in EU? Or you are just a morning person 🤣

Yeah, I'm in UK but my team is spread across timezones (including east and west US!)

Closing this PR to create new one that is not stale.


[RFE] Harden Flatcar Linux Defaults Further

Current situation
Flatcar Linux has sensible and robust default settings, which, when coupled with its minimalistic design, immutable filesystem, and automated update system, positions it as an appealing choice for various purposes while also offering ample potential for further hardening.
Impact
Flatcar could be further hardened without disrupting people's workloads. Below, I would like to share some of my thoughts that could serve as valuable points for discussion.
Ideal future situation

[ ] Harden default umasks
[ ] We can further harden the systemd services by default
[ ] Increase number of hashing rounds for passwords
[ ] Install a PAM module like passwdqc or cracklib
[ ] Include rngd
[ ] Harden permissions of home directories
[ ] Harden sysctls: dev.tty.ldisc_autoload, fs.protected_fifos , fs.protected_regular, fs.suid_dumpable, kernel.dmesg_restrict, kernel.kptr_restrict, kernel.modules_disabled, kernel.perf_event_paranoid, kernel.unprivileged_bpf_disabled, net.core.bpf_jit_harden, net.ipv4.conf.all.forwarding,net.ipv4.conf.all.log_martians,  net.ipv4.conf.all.rp_filter, net.ipv4.conf.all.send_redirects, net.ipv4.conf.default.accept_redirects, net.ipv4.conf.default.log_martians, net.ipv6.conf.all.accept_redirects, net.ipv6.conf.default.accept_redirects
[ ] Harden SSH configuration
[ ] Setting up auditd on Flatcar currently is easy enough but we can consider enabling auditd by default.

Are these suggestions based on trying to meet some security benchmark?
Can you add more specifics for the points with "harden" in their description. Harden how?

Which usecase would these options serve?
Some of these do not sound reasonable for a server+container OS. For example the ssh suggestions and at least the following sysctl suggestions would break container usecases:
kernel.modules_disabled=1
net.ipv4.conf.all.forwarding=0

The other suggestions might not be useful for the general population (rp_filter/redirects/logging), or might restrict rootless containers (which we're interested in supporting and improving).
umask/homedir/systemd-analyze sound like they could be OK.


Bug fix/timeout

Moxspec process get stuck when reading files from sysfs. This PR provides fixes by bringing timeout function when loading files from sysfs.

LGTM. Thank you for your contribution.


Dataset mappings

Hopefully, this a short PR.
Dataset Manager

Added a method create_dataset_mappings to generate mappings from random UUIDs to dataset folders, and store this in a yaml file called datasets.yaml.
Added a method bootstrap to decide whether to load the yaml file (if it exists) or call create_dataset_mappings
Added a method get_mappings that returns the loaded mappings, if they exist.
Added tests for these new methods.

Tl;dr the implementation mirrors that of the Configuration Manager (I ultimately decided not to just put the mappings in configuration.ini since I thought that would break abstractions).
NOTE: I accidentally committed parts of the first two methods above in a previous PR, please make sure to still review all of each of the methods.

@georgymh could you explain why UUID again? Like instead of just using the dataset names or other ways of generating random identifiers?
I have an idea of how to make this smoother, but I'm not sure if it would compromise your original reasons for having an identifier in the first place.

So the reason why I ask is because it might be better to use some kind of deterministic encoding (like uuid3/uuid5 and some arbitrary namespace in the docs) so that we don't even need to store the mappings in some file. Obviously not necessary (and there's some drawbacks), but I think it's alternative to consider.
Since I've got two approvals, I'm just going to go ahead and merge.


pre-roll poster

Hello.
As I know StrobePlayer has 'poster' setting allowing to show preroll poster image before starting playback.
Is there such feature in Grind player?

好吧,看来只能修改源码了..


Security Exception

Hey great App you created! Since a month now I cant properly use it sadly since im always getting an Exception. I read about the tip with the Load App Keystore in the Forums and tried it , currently it is working ... what are the drawbacks of it? And also could be the reason for it my Android version 4.2.2? I read that this Version didnt have Keystores yet.
Greets Shikaya

Hiya,
You got the Security Exception because the Root Certificate in your phone is missing/not updated by the vendor, so when the application tried to validate the SSL Certificate path, it will failed due to no root certificate to check.
By using App Keystore, the application will use the embedded root certificate to validate the SSL certification path.
The drawback, if for whatever reason BakaTsuki choose to change the SSL Certificate again (e.g. moving server), then I need to publish new release with the update certificate.
Consider changing your phone or try to install custom rom with latest android version/security patch.

so I am having this same issue since and I can't afford a new phone atm(my phone is only about a year and a half old so I'm not sure why this is a problem) so I was wondering about what you mean by loading app keystore, is that an app I can download?

In the apps, go to Settings -> Update and Notification -> Load App Keystore is tick/enabled.
Ensure you are using the latest version (as per current is 1.1.50).


Git repo as package source

This PR adds git repos as package sources. If the source ends with .git it is interpreted as a git repo, and it is fetched by cloning the default branch. This should allow us to serve scripts from a repo via hermit.
We could improve this in the future by allowing non-default branches or tags.

Oh I forgot - it needs docs.


Question about network weights update in Algorithm 1

Thank you for your amazing work.
Can I ask about line 9 on your Algorithm 1 in your paper? Why do you choose to update network weights based on loss on synthetic data instead of real data?

Hi, thanks. Please refer to the Line 7 in the first paragraph of Page 5 in our paper https://openreview.net/pdf?id=94YYh974g3T
Why? Because:

empirically, it works better.
the objective of dataset condensation is training models on synthetic data, thus updating models on synthetic data is reasonable and in line with the objective.
recently some works such as IDC modify it by updating models on real data and achieve good results.

I think I have gained more understanding now. Thank you for your respond.