2D rendering optimizations for 2.x

I'm optimizing the 2D rendering. I was aware that my work would probably never get merged due to Godot 2.2 skipped and the new renderer for 3.0 will probably be already better optimized than the current.
At least it would be of use in my currently developed game until the Godot 3.0 version compatible with GL ES 2.0 were released.
But now I know Godot 2.1.1 will see the light of the day, tomorrow probably. So there is still a chance for my work to become official and get merged in an official Godot release. Probably I'm too late for 2.1.1, but is there any hope of a 2.1.2 or 2.2 release?
Of course, first I have to complete the task (one or two days I expect) and check it the performance gain worths it (provided there is actually some gain; you never know).
Also I would like to know if people are interested in this being released.

What are these optimizations exactly? Somebody is working on a 3ds port at
the moment, they'll probably benefit from this
On 2 November 2016 at 15:56, Pedro J. Estébanez<EMAIL_ADDRESS>wrote:

I'm optimizing the 2D rendering. I was aware that my work would probably
never get merged due to Godot 2.2 skipped and the new renderer for 3.0 will
probably be already better optimized than the current.
At least it would be of use in my currently developed game until the Godot
3.0 version compatible with GL ES 2.0 were released.
But now I know Godot 2.1.1 will see the light of the day, tomorrow
probably. So there is still a chance for my work to become official and get
merged in an official Godot release. Probably I'm too late for 2.1.1, but
is there any hope of a 2.1.2 or 2.2 release?
Of course, first I have to complete the task (one or two days I expect)
and check it the performance gain worths it (provided there is actually
some gain; you never know).
Also I would like to know if people are interested in this being released.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/godotengine/godot/issues/7017, or mute the thread
https://github.com/notifications/unsubscribe-auth/AGVmPeJRsZA9Yi75RqMu2MIo8DucSo7iks5q6NzPgaJpZM4Knnr0
.

As you know, Godot 3.0 is based on GLES 3.0 and about 45% android devices are still use GLES 2.0.
So, I would use 2.x version for production until 3.x released which support GLES 2.0 also.

What a quick feedback! Knowing some people is interested encourages me.
I'm attempting thsee optimizations:

Use VBOs for primitives like lines and, the most relevant, rects. That with a cache. I hope the cache code is faster than submitting vertices and UVs on every draw.
Front-to-back rendering with depth buffering.

I don't want to give false hopes, but I think at least these deserve a try.

As I mentioned, there will be 2.1.x releases until we decide not to support it anymore (i.e. until 3.x is ripe enough to take over for 99% of use cases). There won't be a 2.2.

Is this optimization will fix jittering/stuttering bug that occurs in 2.1? That would be really nice if you can get it fixed.

Jittering can be due to a number of different things. I can't tell you
what I will be able to achieve.
El 04/11/2016 a las 13:23, JustDevs escribió:

Is this optimization will fix jittering/stuttering bug that occurs in
2.1? That would be really nice if you can get it fixed.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/godotengine/godot/issues/7017#issuecomment-258417688,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ALQCtuf2mkKTCewzEQIdZ6sVUorgUrDkks5q6yPAgaJpZM4Knnr0.

I'm having a stuttering and jittering animated sprite as well.
Not sure though if this is caused by the engine or by code.
https://www.dropbox.com/s/inm16am0tjfsrex/jittering_animated-sprite.m4v?dl=0

I'd say its related to your own code, but it's difficult to know without
knowing more about your scene.

I was able to fix my sprite jittering by following this rule of thumb:

physics = _fixed_process
everything else = _process

I think I have bad news. After more than a month of work, I re-implemented de 2D drawing applying a number of techiques.
I tried different approaches measuring on PC and mobile to try to find the fastest way of doing things and I researched a lot.
Anyway, my final implementation has ended up being a bit slower than the original. It does a lot of book-keeping, probably adding too much work for the CPU. It also adds some RAM overhead. It would worth it if it would have taken us to an overall faster rendering, but it hasn't.
So this has been a big waste of time. At least, I learned a couple of things about how GL driver and hardware works.
Anyway, if anybody wants to try it for himself, you can find by branch here: https://github.com/RandomShaper/godot/tree/exp-optimize-2d-render
It's based on master, though I think the relevant commits could be cherry-picked for the 2.1 branch.

Uhm, given the above comment and the fact that this issue is getting a bit stale, should it be closed?

For me closing this is OK.
I expected some feedback about how my code performed for other people, but yes, this is not getting anywhere.

@akien-mga This can be closed.


Merging main with development

Feature releases

Added the local PostgreSQL database implementation
Linked User management service with PostgreSQL database implementation
Added Gin HTTP routes and route handlers
Added CRUD implementation against the User entity

Bug fixes

Fixed database credentials. I was unable to link the service and database due to wrong password

@AntonyIS , this looks great. Please add authorization and authentication logic


Add Vue.js debugging support

We don't need to worry about Vue.js 1.x, these bindings can focus on major 2.


[SPARK-47987][PYTHON][CONNECT][TESTS] Enable ArrowParityTests.test_createDataFrame_empty_partition

What changes were proposed in this pull request?
Reenable ArrowParityTests.test_createDataFrame_empty_partition
We actually already had set up Classic SparkContext _legacy_sc  for Spark Connect test, so only need to add _legacy_sc in Classic PySpark test.
Why are the changes needed?
to improve test coverage
Does this PR introduce any user-facing change?
no, test only
How was this patch tested?
ci
Was this patch authored or co-authored using generative AI tooling?
no

thank you @dongjoon-hyun and @HyukjinKwon


Error When Trying to Get Value for bert_model in "Classify text with BERT" tutorial

Click to expand!
Issue Type
Bug
Have you reproduced the bug with TF nightly?
No
Source
source
Tensorflow Version
2.4.4
Custom Code
Yes
OS Platform and Distribution
No response
Mobile device
No response
Python version
No response
Bazel version
No response
GCC/Compiler version
No response
CUDA/cuDNN version
No response
GPU model and memory
No response
Current Behaviour?
I am trying to run the "Classify text with BERT" tutorial using Jupyter Notebook on a remote server. When I tried to implement 'bert_model = hub.KerasLayer(tfhub_handle_encoder)', it never returned a result and it is still executing with the asterik (*) next to the cell.

Is this supposed to happen, and is it normal for that line to take a long time to execute?

Standalone code to reproduce the issue
https://www.tensorflow.org/text/tutorials/classify_text_with_bert

The code is this line:
'bert_model = hub.KerasLayer(tfhub_handle_encoder)'

Relevant log output
No response

I'm sorry to hear that you're encountering an error when trying to get the value for bert_model in the "Classify text with BERT" tutorial. Here are some possible solutions:
Make sure you have installed the necessary packages. The tutorial requires tensorflow, tensorflow-text, and tensorflow-hub. You can install them using pip:
pip install tensorflow tensorflow-text tensorflow-hub
Check that you're using the correct BERT model. The tutorial uses the bert_en_uncased_L-12_H-768_A-12 model, which is a smaller and faster version of BERT. Make sure you've downloaded and unzipped this model to the correct directory. You can download it using the following command:
!wget https://storage.googleapis.com/bert_models/2018_10_18/uncased_L-12_H-768_A-12.zip !unzip uncased_L-12_H-768_A-12.zip
Verify that the path to the BERT model is correct. In the tutorial, the path is set to ./bert_en_uncased_L-12_H-768_A-12/. Double-check that this path is correct and that you're not missing any files.
Try clearing the TensorFlow session and reloading the BERT model. You can do this using the following code:
`import tensorflow as tf
import tensorflow_hub as hub
tf.keras.backend.clear_session()
bert_layer = hub.KerasLayer("./bert_en_uncased_L-12_H-768_A-12")
`
If none of the above solutions work, try restarting your Python kernel and rerunning the code from the beginning of the tutorial.
I hope one of these solutions helps you resolve the error. Let me know if you have any further questions or concerns!

I successfully completed the tutorial, and the code worked. It just took longer than expected. Unfortunately, I did not record how long it took for the line of code to run.
I am closing this issue because I no longer have any questions.


Timers not mocked with node v7.3

Do you want to request a feature or report a bug?
BUG
What is the current behavior?
jest.useFakeTimers(), doesn't replace global functions with mocks
Steps

using node v7.3:
create-react-app test && cd test
in src/App.test.js, add jest.useFakeTimers() at the beginning of the file and expect(setTimeout).toBeCalledWith(42) in the test body:

jest.useFakeTimers();

it('renders without crashing', () => {
  expect(setTimeout).toBeCalledWith(42)
});

Output:

What is the expected behavior?
setTimeout should be a mock function
Please provide your exact Jest configuration and mention your Jest, node, yarn/npm version and operating system.

Node: v7.3 (the bug does not appear with v7.2)
OSX 10.12.2
yarn 0.18.1

Note:
I get the same error in other tests where I try to mock window.addEventListener, so I suspect we somehow can't override some properties of the global object now, which is maybe related to this change: https://github.com/nodejs/node/commit/ec2f13fe66

Update to Jest 18.1.


Shouldn't this be called Android/Apple TV?

I am referring to this readme: react-native-website/docs/building-for-apple-tv.md

Can you be more specific in the problem?


Homepage is updated

I updated the homepage with the basic info as a starter and will add in more info as I go along.

Resolved by #184


new package: depfile

This package parses an io.Reader consisting of key/value pairs into a map[string]map[string]string. The format of the line is
name key=value [key=value]...

The intention is this package will be used to parse a dependency file, or depfile, consisting of lines like this
github.com/pkg/profile version=0.1.0
github.com/docker/docker version=1.7.0

note: this package does not assign semantic meaning to the contents of the map[string]map[string]string.

This is a really simple file format! Easy to read, write, and parse, even in raw shell scripting. +1 here

Do you envision specifying version ranges or constraints in this format somehow later, or planning to keep it really simple?

https://xkcd.com/927/ ;)

@tianon

Do you envision specifying version ranges or constraints in this format somehow later, or planning to keep it really simple?

This package just parses the file into map[string]map[string]string, it's up to the caller to interpret what that means.
wrt. questions about ranges and constraints, the decision in #536 is to use this file to specify a direct mapping of import path prefix to version number. Maybe if gb is extended to work with libraries, ranges could be added, but that's up to the calling code to interpret it, not this package.

@kostya-sh yup, that's about the size of it. I'm tired of JSON's inability to deal with numbers, and there are no other encodings save text/csv and xml in the standard library, so this will suffice.

Right, makes sense -- I was just curious if you think this format is
expressive enough to cover that use case (which is likely to come up
eventually). :+1:

@tianon should be, it's just key=value, you can have multiple kv pairs. Here is an example of an valid, but entirely bogus depfile
// use docker 1.7.0
github.com/docker/docker version=1.7.0 vcs=git

// use paultag's fork
github.com/docker/machine remote=https://github.com/paultag/machine rev=ebcidic

Yeah, apologies -- I didn't want to get this straying too far from the actual file format (since how to use the file format for dependencies is definitely a separate discussion), but IMO thinking about the use case for the format is helpful when designing it. :+1:
Seems sane enough to me!

One case which is not covered is quoting whitespace. I don't plan to add it til it is needed.

@davecheney, I am actually quite like this format. Still I beleive having a single format for all Go dependency management tools would be better.
Very minor nit: depfile is not very suitable name for a package does not assign semantic meaning to the contents of the map[string]map[string]string

I'll probably move this package out of gb, I think it'll be called taggedkv.
re: no single format, yes I am disappointed as well.

On 13 Jan 2016, at 11:19, kostya-sh<EMAIL_ADDRESS>wrote:
@davecheney, I am actually quite like this format. Still I beleive having a single format for all Go dependency management tools would be better.
Very minor nit: depfile is not very suitable name for a package does not assign semantic meaning to the contents of the map[string]map[string]string
—
Reply to this email directly or view it on GitHub.


test(mempool): refactor add_tx_input macro

This change is

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Please upload report for BASE (main@724ac68). Learn more about missing BASE report.
Report is 7 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #467   +/-   ##
=======================================
  Coverage        ?   84.08%
=======================================
  Files           ?       37
  Lines           ?     1891
  Branches        ?     1891
=======================================
  Hits            ?     1590
  Misses          ?      225
  Partials        ?       76

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


[build] Make fails if output folder does not exist

Probably, release folder should be checked or created by Makefile...

Release directory created automatically on commit https://github.com/raysan5/raylib/commit/207b5a26b18e669e48b635f088ee57abd9694134


Is 0.1.0 version correctly released to npm?

Hello,
I bumped into the issue that the component is not correctly wrapped. I know that https://github.com/storyblok/storyblok-react/pull/12 is merged, but it seems that npm v0.1.0 still throws an error.
If I inspect the code of https://github.com/storyblok/storyblok-react/blob/master/src/sb-editable.jsx#L24 The code is still old.
Did maybe something went wrong in the release to publish the changes?

Hi! This issue was fixed in the last release - v0.1.1. Take a look!


Json Decoder Returning Only Errors

Steps to Reproduce

Use jsonDecoder with List

Logs

https://paste.xeu100.com/?49310cd9a8bff62f#mUK+5HYLomwYfg4pyQLl3ukmkq8/REXAReAGny8nCVc=

Analyzing xid...

   info - This class (or a class which this class inherits from) is marked as '@immutable', but one or more of its instance fields are not final: AccountElement._accountId, AccountElement._email, AccountElement._website - lib\elements\AccountElement.dart:3:7 -
          must_be_immutable
   info - The value of the field '_accountId' isn't used - lib\elements\AccountElement.dart:5:7 - unused_field
   info - This class (or a class which this class inherits from) is marked as '@immutable', but one or more of its instance fields are not final: AuthenticatorElement._authenticators, AuthenticatorElement._index - lib\elements\AuthenticatorElement.dart:8:7 -
          must_be_immutable
   info - This class (or a class which this class inherits from) is marked as '@immutable', but one or more of its instance fields are not final: AuthenticatorList._authenticators - lib\elements\AuthenticatorList.dart:4:7 - must_be_immutable
   info - This class (or a class which this class inherits from) is marked as '@immutable', but one or more of its instance fields are not final: NavBarElement._currentPage - lib\elements\NavBarElement.dart:3:7 - must_be_immutable
   info - This class (or a class which this class inherits from) is marked as '@immutable', but one or more of its instance fields are not final: AccountPage._storage, AccountPage._authenticatorsController - lib\pages\AccountPage.dart:8:7 - must_be_immutable
   info - This class (or a class which this class inherits from) is marked as '@immutable', but one or more of its instance fields are not final: CreateAuthenticatorPage._secret, CreateAuthenticatorPage._nameController, CreateAuthenticatorPage._secretController,
          CreateAuthenticatorPage._digitsController, CreateAuthenticatorPage._periodController - lib\pages\CreateAuthenticatorPage.dart:6:7 - must_be_immutable

7 issues found. (ran in 4.7s)

[√] Flutter (Channel stable, v1.7.8+hotfix.3, on Microsoft Windows [Version 10.0.17763.615], locale en-US)
    • Flutter version 1.7.8+hotfix.3 at D:\ProgramStorage\Applications\Flutter
    • Framework revision b712a172f9 (10 days ago), 2019-07-09 13:14:38 -0700
    • Engine revision 54ad777fd2
    • Dart version 2.4.0

[√] Android toolchain - develop for Android devices (Android SDK version 29.0.1)
    • Android SDK at C:\Users\liamr\AppData\Local\Android\sdk
    • Android NDK location not configured (optional; useful for native profiling support)
    • Platform android-29, build-tools 29.0.1
    • Java binary at: C:\Users\liamr\AppData\Local\JetBrains\Toolbox\apps\AndroidStudio\ch-0\183.5692245\jre\bin\java
    • Java version OpenJDK Runtime Environment (build 1.8.0_152-release-1343-b01)
    • All Android licenses accepted.

[√] Android Studio (version 3.4)
    • Android Studio at C:\Users\liamr\AppData\Local\JetBrains\Toolbox\apps\AndroidStudio\ch-0\183.5692245
    • Flutter plugin version 37.1.1
    • Dart plugin version 183.6270
    • Java version OpenJDK Runtime Environment (build 1.8.0_152-release-1343-b01)

[!] IntelliJ IDEA Ultimate Edition (version 2019.1)
    • IntelliJ at C:\Users\liamr\AppData\Local\JetBrains\Toolbox\apps\IDEA-U\ch-0\191.7479.19
    X Flutter plugin not installed; this adds Flutter specific functionality.
    X Dart plugin not installed; this adds Dart specific functionality.
    • For information about installing plugins, see
      https://flutter.dev/intellij-setup/#installing-the-plugins

[!] Connected device
    ! No devices available

! Doctor found issues in 2 categories.

From the link, the call that's failing is in:

package:xid/VerifyData.dart:19

That's not Flutter code. If your code, or third-party code you are using, is passing data of the wrong type somewhere, that's an error that needs to be fixed in that code.

The code is correct and I've printed variables, they're all good. It worked then stopped working.

You haven't provided the code necessary to reproduce this; from the stack it's not even possible to tell how JSON decoding is involved. It's simply not possible for anyone to investigate with the information you have provided.
If you are confident that this is a Flutter bug you need to file an issue that contains detailed reproduction steps, most importantly the actual code necessary to reproduce it (ideally a reduced test case).

Since you seem to be focused on the fact that the bug is closed, rather than my explanation as to why, I'm going to re-open this for now. However, as explained above and in the duplicates, in the current state this can't be investigated.
Please provide the missing information necessary for someone to reproduce this bug: sample code and inputs that will reproduce it.

There isn't an amount of code I could give you, all my code and all my projects can't use the function jsonDecode(). No matter what I enter ("[]", "{"blah":"blah"}", for example), it returns a string, not the parsed version.

It sounds like you have a minimal test case for this already, which is exactly what we need. So far you haven't provided any code that someone can reproduce this with, just a general description.

As I've said, there isn't one specific case where this happens. I restarted my machine and updated Flutter and suddenly all of my code functioned this way.

We don't need every case, we just need one. With the actual code, so that someone other than you can run it and see if it's reproducible.
Let's try this another way: if you flutter create a new project, and make no changes at all other than adding print(jsonDecode('[]').runtimeType); in main() and an import 'dart:convert';, what is printed when you run it?


feat(pack): Added AWS Billing quickstart

Summary
Added new quickstart AWS Billing. Unsure about what alerts that could be usable so did not add any right now.
Pre merge checklist

[x] Did you check you NRQL syntax? - Does it work?
[x] Did you check your dashboard image quality? -  Do they look good?
[x] Did you check that your alerts actually work?
[x] Did you include an InstallPlan and Documentation reference?
[x] Did you check your descriptive content for voice, tone, spelling and grammar errors?
[x] Did you attach images of your dashboards to the PR so we can see them working?

Screenshots

@aswanson-nr Oops! 🐙  My bad, missed the updated repo structure.
Have added a link to the aws-billing dashboard now in config file.


Add possibility to add replace to the generated go.mod

Certain projects have the need for defining replace directives in their go.mod to build.
I've tried to use the --with argument to pass additional replace directives:
XK6_SKIP_CLEANUP=1 xk6 build \
  --with k8s.io/client-go="k8s.io/client-go v0.21.0" \
  --with k8s.io/api="k8s.io/api v0.21.0" \
  --with github.com/chaudum/xk6-loki="$(pwd)"

This will correctly add replaces in the resulting go.mod:
module k6

go 1.16

replace k8s.io/client-go => k8s.io/client-go v0.21.0

replace k8s.io/api => k8s.io/api v0.21.0

replace github.com/chaudum/xk6-loki => /home/christian/sandbox/chaudum/xk6-loki

require go.k6.io/k6 latest

However it also adds imports in the main.go:
package main

import (
	k6cmd "go.k6.io/k6/cmd"

	// plug in k6 modules here
	// TODO: Create /modules/standard dir structure?
	// _ "go.k6.io/k6/modules/standard"
	_ "k8s.io/client-go"
	_ "k8s.io/api"
	_ "github.com/chaudum/xk6-loki"
)

func main() {
	k6cmd.Execute()
}

The problem with these imports is, that there are no top-level packages for e.g. k8s.io/client-go,
resulting in the following error:
go: finding module for package k8s.io/client-go
k6 imports
	k8s.io/client-go: module k8s.io/client-go@latest found (v0.0.0-00010101000000-000000000000, replaced by k8s.io/client-go@v0.21.0), but does not contain package k8s.io/client-go

Removing the imports and running go mod tidy && go build -o xk6-loki main.go in the build environment manually solves the problem.
I would like to suggest to add an option to add replace directives without adding the package imports to the main.go file. This could for example be done with a separate --replace argument.

Hi, thanks for suggesting this. A new --replace argument does make sense to handle these cases.
Our resources are scarce for new xk6 features right now, but we'll try to get to this in the next few weeks. Otherwise, feel free to propose a PR :)


Demo Website getbtctoolbox.org

Bought us getbtctoolbox.org today.
Will set up web hosting for the domain after I get done with usage docs.
Looking for input as to UI, site format, styles, colors, etc, but initially I'll set up the home page as a demo donation page in a plain-wrap manner.
@coinables , I could use your help in figuring out how to handle the getBTCBalance portion...not sure how to use AJAX or even if the Bitstamp API HAS an AJAX solution  I could refresh the page every 10 seconds or so, but that's a bit kludgy.
All assistance is appreciated!

Looks like getBTCBalance is simply a file_get_contents call to blockstream's API and totals up all the UTXO values.
So you want to get an updated balance every 10 seconds? Yea AJAX would work, but I'd try to avoid the AJAX idea, that's a new TSP/IP call every 10 seconds, even if the API allows that many requests, it's a lot -- I've come to try to use websocket when you can for such frequent updates. Depending on what you are doing with the address balance subscribing to a specific address for new transactions with websocket could be the preferred approach.

OK, looks like my replies to email are not posting here, so I'm going to add them manually.

START ECDSA PUBLIC KEY
ecdsa-sha2-nistp256 AAAAE2VjZHNhLXNoYTItbmlzdHAyNTYAAAAIbmlzdHAyNTYAAABBBDY1UFJipGhz6WkQ0/Z3P3aIkpI6zIrvgGB2pyNTM06CWskQ3VX9wVXO6lAs1GEe+NpUXN0nTDYCu0IYxJdr0Bg= ecdsa-key-20200825
END ECDSA PUBLIC KEY

@Septem151 , I need one from you too when you get a chance.

ssh-rsa AAAAB3NzaC1yc2EAAAADAQABAAABAQDF/l8yHh7+MmHJiWBZsi+mlddnByAB7+5iojTpn4xH446j4QAG9bJ78Id0Tcu5GcXMhVkmdQv+GARFTnJNErV3o5UQjvy5Do44s3ON5i+lFvoerUBJpRpBkdStii5w7lJldNziFAyIa0QoIPvObvLuHPBf3t6JlTDuEkK0UINVgLyY1hMyQiYiLku2HpZKw6KlGLpiXH4Jrit/TeSVQGzZwU7avhFgcwciILbNZ/U6x3s/OGZfr+GZiEyGzKN9bF1jrUEggEqK5KZ+dPYvNmDsZZMST9y89EN5EpH4pupYF7oHAqUnK8dJtCJfN/jANr6qKdVTUMARCzhoPzggbKO1 openpgp:0xD54EB0F1

@Septem151 , please resubmit an ECDSA key...more secure.

@Septem151 , please resubmit an ECDSA key...more secure.

This is the key I use for everything, including signing my commits to github.  https://Keybase.io/Septem151
I don’t really see how SHA512 RSA is insecure but if you really need an ECDSA SSH key...

OK, hold off, when I get to it, I'll see if it's really a problem.  I have been locking down my servers pretty well and turning off rsa, but lemme do some testing and maybe the rsa will work out ok.

OK, site is up, but I'm having issues setting up mailserver...not enough memory for clamav updates. Will upgrade after my support team gets some other issues resolved.


Remove semver from crypto_shim

Since it was unused.

I beat you to the bunch and did this in another PR to avoid bringing more code into bundles while upgrading the sdk in coda: https://github.com/coda/packs-sdk/pull/2468

Ah whoops, thanks for doing that ahead of me!


Add String Method to admin.LevelSpec struct

the spec field of the admin.LevelSpec is not exposed https://github.com/ceph/go-ceph/blob/4298c2bd0e9a77ae8161be6918d474c88a442405/rbd/admin/admin.go#L25 add a  String method to the LevelSpec which helps for both logging and the comparison when someone lists the snapshot schedules using https://github.com/ceph/go-ceph/blob/4298c2bd0e9a77ae8161be6918d474c88a442405/rbd/admin/msschedule.go#L62

cc @phlogistonjohn @nixpanic

@Madhu-1 is there a particular format or details that you would like to see included?
For comparing, are you interested in sorting like time Before() and After(), or just an Equals() call?

the "interior" type of a LevelSpec is a string, I suspect that @Madhu-1 just wants to be able to "see" that string.
As for comparison I hadn't even noticed the "and the comparison" part of @Madhu-1's request until you pointed it out @nixpanic. I don't know if there's a strong need to make these comparable but if there is let me know. I think adding a String method will suffice for "eyeballing" the LevelSpec values (I hope).

and also adding Equals() will also make the things simple to compare the startTime,interval

@Madhu-1 For comparison, there is no need for a Equal() method. Structs with un-exported fields can still be compared and are equal, even if the string fields are not "identical" but only equal by value. So if you have  two LevelSpec values ls1 and ls2 you can simply compare with ls1 == ls2. If you need the a sting for logging, without any guarantees or structure, you can simply (like with error values) use fmt.Sprintf("%v", ls1) or fmt.Sprintf("%+v", ls1). See https://play.golang.org/p/IGEHypCcsDZ
So, given that information, is there still something, that you actually need?

@ansiwen yes agree for comparison I have to create two structures. and the way the spec is generated is something different with string concatenation https://github.com/ceph/go-ceph/blob/4298c2bd0e9a77ae8161be6918d474c88a442405/rbd/admin/admin.go#L31-L43 and the main intention was only to compare the LevelSpec.spec with a string, not any other fields (if it gets added in the future).
This is not needed anymore at least for cephcsi.

@Madhu-1 I see, but that's already a first misunderstanding, because if another field would be added, I would expect it to be included in a general String() method. So, if you need specific information from that spec field, we might better store the information separately in the value and only create the string on demand. In fact I saw that coming and suggested that in the first place. 😜

@Madhu-1 I see, but that's already a first misunderstanding, because if another field would be added, I would expect it to be included in a general String() method.

I agree. I see that a String method would be useful in informational contexts like logging & display (I know, the logging in golang can "peek" into the private fields of a struct but what if I'm building a GUI or something :-) ). But its not something you should expect to be 100% stable wrt the current output if fileds are added and removed.

So, if you need specific information from that spec field, we might better store the information separately in the value and only create the string on demand. In fact I saw that coming and suggested that in the first place. stuck_out_tongue_winking_eye

Now I'm a tad confused, because that's the way it was being stored in the ye olde versions of my patch, but I also had a 2nd type as an "escape hatch" in case our implementation didn't 100% cover all use cases. Regardless, having private fields allows us flexibility and we're not stuck on the current impl. forever.
Do we need a String method now or in the short term future? If not, I suggest closing this issue and the related PR, and only revisiting this if we do need non-golang-logging display of a string repr of this type.

So I just want to double check that we're all in general agreement that adding a String method is not required at this time? If so, we should close this issue and the associated PR.
Please confirm @Madhu-1. Silence will be taken as an implicit ack after a week. :-)

@phlogistonjohn missed replaying on this one. we don't need this one for now in cephcsi maybe we can add it in future if we get requirement for it.


[Alpha.18] IMAGE_SIZE error on homepage

Issue Summary
Opening homepage works fine but log displays IMAGE_SIZE error.
Steps to Reproduce

ghost update from alpha.17 to alpha.18
ghost run
Open homepage

Technical details:
Ghost Version: alpha.18
ghost-cli Version: 1.0.0-alpha.16
Node Version: v6.10.0
OS: Debian 3.16.39-1+deb8u1
Database: MariaDB 10.0.29
Browser: Comodo Dragon
Log
root@ghost:/var/www/ghost# ghost run
Currently running Ghost 1.0.0 Alpha, this is NOT suitable for production!
 Please switch to the stable branch.
 More information on the Ghost 1.0.0 Alpha at: https://support.ghost.org/v1-0-alpha

Ctrl+C to shut down
Ghost boot: 1444.378ms
[2017-04-04 16:13:25] ERROR

NAME: InternalServerError
CODE: IMAGE_SIZE
MESSAGE: The server has encountered an error.

level:critical

/ghost/img/ghosticon.jpg
InternalServerError: The server has encountered an error.
    at new InternalServerError (/var/www/ghost/versions/1.0.0-alpha.18/node_modules/ghost-ignition/lib/errors/index.js:71:23)
    at IncomingMessage.<anonymous> (/var/www/ghost/versions/1.0.0-alpha.18/core/server/utils/image-size-from-url.js:85:35)
    at emitNone (events.js:91:20)
    at IncomingMessage.emit (events.js:185:7)
    at endReadableNT (_stream_readable.js:974:12)
    at _combinedTickCallback (internal/process/next_tick.js:74:11)
    at process._tickCallback (internal/process/next_tick.js:98:9)

INFO [2017-04-04 16:13:25] "GET /" 200 116ms
INFO [2017-04-04 16:13:25] "GET /assets/css/screen.css?v=74749e4110" 200 8ms
INFO [2017-04-04 16:13:25] "GET /assets/js/jquery.fitvids.js?v=74749e4110" 200 5ms
INFO [2017-04-04 16:13:25] "GET /assets/js/index.js?v=74749e4110" 200 12ms
INFO [2017-04-04 16:13:25] "GET /assets/fonts/casper-icons.woff?v=1" 200 2ms

Hey @PaszaVonPomiot Thanks for your report and thanks so much for your time testing the alpha versions. Very appreciating that 👋
This is almost the same report as https://github.com/TryGhost/Ghost/issues/8215.
The image /ghost/img/ghosticon.jpg will be removed via #8221 asap.


Deploy genomes lab to AARNet

This PR will deploy the "genomes lab" subdomain, the webhooks role and the subdomain_switcher webhook (masthead icon) to aarnet/prod. It also applies some updates to these roles on dev and staging.
Run the aarnet playbook with --extra-vars "certbot_expand=true" to force certbot to create a new certificate that includes the genome.usegalaxy.org domain.
The webhooks role will notify restart galaxy - please make sure that galaxy restarts for the subdomain_switcher webhook to take effect. It should look like this (live on staging):

Do we need to use to force option when adding a new domain?

Do we need to use to force option when adding a new domain?

Yes, it skips the certbot task if a config file already exists - see ops manual. So when you add a new value to certbot_domains you either have to use the certbot_expand var or re-issue manually.


Lab clean up and organisation

[x]  sort all nuts, bolts, things in the plastic bins with labels
[ ]  Get new monitors (and HDMI/DP adapters) [there is an open request for this with the secretaries]
[x]  make 6 workstations
[ ]  Get rid of excess bicycle rims and tires (stacked beside the floor bicycle rack)
[x]  hang interesting bikes on the wall (talk to Jan v. F. for permissions required)
[x]  remove all raw materials to basement in organized fashion, make at least one raw material shelf that is labeled
[x]  organize the tools in the tool cabinets, use dividers, bins, labels, and other organizational methods
[x]  move all bicycles to the basement that are not in active use in the lab or up there for display/demo purposes
[x] send some unneeded bicycles to the kringloopwinkel
[x] inventory all the bicycles in a spreadsheet
[ ]  make a student project cabinet(s), flexible space where new students can claim a shelf and add their label
[x]  fold up the mock hexapod bike and store in basement (make sure it can be reassembled with instructions)
[x]  hang tools on the toolboard (label or make a silhouette of the tool so they end up back in right spot)
[x]  clear old junk from all cabinets to make space
[x] setup method for checking out tools from the lab (for lab members that need to use the tools outside the lab or for other labs borrowing our equipment)
[x] Make space for the large treadmill (likley move cabinets)
[ ] organize all cabinets, shelfs, drawers, etc. with labels and such
[ ] Utilize the small parts bins for organization
[ ] Develop an inventory list of things that are 250 EUR or greater in price
[x] Install a lab equipment check out list on the wall by the door
[ ] Get rid of the excess bicycles in the basement (all of the ones grouped in the floor rack).
[ ] Organize and label shelves in the basement.
[ ] Move materials under the workbench to the material shelf in the basement.
[ ] Remove homeless keys from the bicycle key box. Label all keys for current bikes. Make sure bikes are locked in the basement.
[ ] Move the large treadmill into the bicycle lab.
[ ] Label the fall mats in the basement with "bicycle lab"
[ ] Dismantle the ice skate measuring device and store the materials in the rack in the basement

Bicycle rims & tires are sorted. Marked some of the stock as junk which is ready to be reviewed by Arend or Jason

Can you add the new bicycles from Marco and Shannon's project to the bicycle inventory spreadsheet?

Bicycle rims & tires are sorted. Marked some of the stock as junk which is ready to be reviewed by Arend or Jason

Ok, I'll have a look soon.

Bicycle rims & tires are sorted. Marked some of the stock as junk which is ready to be reviewed by Arend or Jason

Ok, I'll have a look soon.

Let me know when you want to have a look, because there might be some things worth discussing about what's currently stored. (especially the fact that there are loads of rims and tires of one size that are in a good state)

I've made requests for monitors (by email) and for the permission to install bicycle mounts on the wall (with a Topdesk call)

Get new monitors (and HDMI/DP adapters) [there is an open request for this with the secretaries]

Four new monitors have arrived! Now we have:

3x monitors with DisplayPort, VGA, and DVI-D connectors
1x monitor with VGA and DVI-D connectors
4x monitors with DisplayPort and HDMI connectors.

When it comes to cables:

4x VGA cables (for the old monitors)
5x DisplayPort cables (4 new + 1 for the lab's workstation)
1x HDMI cable
1x white VGA - miniDisplayPort adapter (possibly Jan's personal)
1x black VGA - HDMI adapter (Marcos's or Shannon's personal ones?)

make a student project cabinet(s), flexible space where new students can claim a shelf and add their label

The cabinets have been cleared out and there is quite some free space, I saw Tim has already claimed a part of one shelf. So if anyone needs cabinet space for their projects - feel free to grab some.

organize all cabinets, shelfs, drawers, etc. with labels and such
Utilize the small parts bins for organization

We now have a shelf dedicated to electronics (with labeled boxes), a shelf dedicated to safety equipment (helmets, harness, pads) and a few other miscellaneous labelled places. Feel free to label more stuff

I checked off the relevant solved items. Thanks!

Most things were taken care of here. Opening #126 for the 2023 lab cleanup.


Invalid links to javascript and css files for rails 4.2

I've just installed gem with default config. The links to controllers and views are working very well.
But all links to .js and .css files are invalid, and so, cannot be opened:
mvim://open?url=file:///Users/ernest/code/work/ipm_texted/public/assets/application.js&line=1&column=1

Note that app has been replaced by public.
I believe that the reason is here.
This is because Rails.application.config.assets[:enabled] is (in out of the box generated rails app) nil. The quick fix is to set config.assets[:enabled] = true in you development env., but maybe there's a better solution?

+1

Thanks for reporting this. I'm currently on vacation but I'll have a look
as soon as I can.
On Sat Feb 21 2015 at 8:47:58 AM Yannis Kolovos<EMAIL_ADDRESS>wrote:

+1
—
Reply to this email directly or view it on GitHub
https://github.com/josevalim/rails-footnotes/issues/127#issuecomment-75360886
.

Ok I had a look and this part of the code is quite old (still supports pre-asset-pipeline), untested and now buggy (config.assets.enabled is not used anymore, starting from rails 4 IIRC), but the good new is now that I dropped support for Rails < 3.2, I'll be able to drop some code, refactor it, and above all write some tests.
ETA next monday since I'm still on vacations.

removing Rails.application.config.assets[:enabled] is working fine now!

I just pushed rails-footnotes 4.1.6 with a fix for this issue :)


Implement Octopus Deploy and related templates.

Related Issue

Resolves #20
Resolves #8
Resolves #65

Changes Proposed

Creates template object and documentation for Azure App Service
Creates template object and documentation for Azure SQL Server
Creates global resource group folder and associated Terraform objects
Creates deployment flows for the global environment
Updates existing PR checks to support global

Testing

All checks should pass.
Octopus is viewable at the following URL: https://dibbs-ce-global-octopus.azurewebsites.net/

Checklist for Primary Reviewer
Infrastructure

[x] Consult the results of the terraform-plan job inside the "Terraform Checks" workflow run for this PR. Confirm that there are no unexpected changes!

Security

[x] Changes with security implications have been approved by a security engineer (changes to  authentication, encryption, handling of PII, etc.)
[x] Any dependencies introduced have been vetted and discussed

Cloud

[x] Oncall has been notified if this change is going in after-hours
[x] If there are changes that cannot be tested locally, this has been deployed to our Azure dev environment for verification.

Thank you for answering all my questions! :rocket:


feat(ecs): add codepipeline deploy-action to ecs cluster

This will implement #1386
No Unit-Test, one Integration Test ist present. The similar compontent s3 deploy-action has no unit-test (didnt found it), so I oriented there. Please give me feedback when required.
I have tested the integration test in my private AWS Account, and it worked.
Notes:

I did not implement toCodePipelineInvokeAction (on service?) as service and repository is required, as I didnt figured out an easy api for this. Need feedback if this is required.
The default IAM rules are maybe too open (ecs:* for *), I oriented on the default AWS CodePipeline Role: https://docs.aws.amazon.com/codepipeline/latest/userguide/how-to-custom-role.html
Not included in the component, but in the integration-test: sts:AssumeRole and iam:PassRole for * - same reason as point before. The following would be ideal, but I didnt figured out how to construct this with cdk:            - Resource: "*"
              Effect: Allow
              Action:
                - iam:PassRole
              Condition:
                StringEqualsIfExists:
                  iam:PassedToService:
                    - ec2.amazonaws.com
                    - ecs-tasks.amazonaws.com

Pull Request Checklist

[ ] Testing

Unit test added (prefer not to modify an existing test, otherwise, it's probably a breaking change)
CLI change?: coordinate update of integration tests with team
cdk-init template change?: coordinated update of integration tests with team

[x] Docs

jsdocs: All public APIs documented
README: README and/or documentation topic updated

[x] Title and Description

Change type: title prefixed with fix, feat will appear in changelog
Title: use lower-case and doesn't end with a period
Breaking?: last paragraph: "BREAKING CHANGE: <describe what changed + link for details>"
Issues: Indicate issues fixed via: "Fixes #xxx" or "Closes #xxx"

[ ] Sensitive Modules (requires 2 PR approvers)

IAM Policy Document (in @aws-cdk/aws-iam)
EC2 Security Groups and ACLs (in @aws-cdk/aws-ec2)
Grant APIs (only if not based on official documentation with a reference)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license.

created PR under wrong account - I will close this and reopen under new PR under correct account with fixes


Can't change theme

Expected Behavior
export BASH_IT_THEME="kistune" bashit restart should apply the named theme
Current Behavior
Nothing happens
Steps to Reproduce

export BASH_IT_THEME="kistune" bashit restart
The theme is changed

Your Environment

Bash-it version used:
List of enabled plugins, themes and aliases (use bash-it show (plugins/themes/aliases)):

Plugin              Enabled?  Description
alias-completion      [x]     Automatic completion of aliases
base                  [x]     miscellaneous tools

Alias               Enabled?  Description
general               [x]     general aliases

bash-it doctor output:

DEBUG: core: main: Loading libraries(except appearance)...
DEBUG: lib: helpers: Loading library file...
DEBUG: lib: log: Loading library file...
DEBUG: lib: preview: Loading library file...
DEBUG: lib: search: Loading library file...
DEBUG: lib: utilities: Loading library file...
DEBUG: vendor: Loading "preexec"...
DEBUG: core: reloader: Loading all enabled components...
DEBUG: aliases: general: Loading component...
DEBUG: plugin: base: Loading component...
DEBUG: completion: bash-it: Loading component...
DEBUG: completion: system: Loading component...
DEBUG: plugin: alias-completion: Loading component...
DEBUG: core: reloader: Loading "bobby" theme...
 WARN: themes: base: Command 'battery_percentage' does not exist!
DEBUG: core: main: Loading custom aliases, completion, plugins...
DEBUG: core: main: Loading general custom files...
DEBUG: custom: example: Loading custom file...

Bash version: 5.1.0(1)-release
Operating System and version:

LSB Version:	n/a
Distributor ID:	ManjaroLinux
Description:	Manjaro Linux
Release:	21.0
Codename:	Ornara

Your Bash Config File
$ cat /home/me/.bashrc
#!/usr/bin/env bash

# If not running interactively, don't do anything
case $- in
  *i*) ;;
    *) return;;
esac

# Path to the bash it configuration
export BASH_IT="/home/theharicover/.bash_it"

# Lock and Load a custom theme file.
# Leave empty to disable theming.
# location /.bash_it/themes/
export BASH_IT_THEME='bobby'

# (Advanced): Change this to the name of your remote repo if you
# cloned bash-it with a remote other than origin such as `bash-it`.
# export BASH_IT_REMOTE='bash-it'

# (Advanced): Change this to the name of the main development branch if
# you renamed it or if it was changed for some reason
# export BASH_IT_DEVELOPMENT_BRANCH='master'

# Your place for hosting Git repos. I use this for private repos.
export<EMAIL_ADDRESS>
# Don't check mail when opening terminal.
unset MAILCHECK

# Change this to your console based IRC client of choice.
export IRC_CLIENT='irssi'

# Set this to the command you use for todo.txt-cli
export TODO="t"

# Set this to false to turn off version control status checking within the prompt for all themes
export SCM_CHECK=true
# Set to actual location of gitstatus directory if installed
#export SCM_GIT_GITSTATUS_DIR="$HOME/gitstatus"
# per default gitstatus uses 2 times as many threads as CPU cores, you can change this here if you must
#export GITSTATUS_NUM_THREADS=8

# Set Xterm/screen/Tmux title with only a short hostname.
# Uncomment this (or set SHORT_HOSTNAME to something else),
# Will otherwise fall back on $HOSTNAME.
#export SHORT_HOSTNAME=$(hostname -s)

# Set Xterm/screen/Tmux title with only a short username.
# Uncomment this (or set SHORT_USER to something else),
# Will otherwise fall back on $USER.
#export SHORT_USER=${USER:0:8}

# If your theme use command duration, uncomment this to
# enable display of last command duration.
#export BASH_IT_COMMAND_DURATION=true
# You can choose the minimum time in seconds before
# command duration is displayed.
#export COMMAND_DURATION_MIN_SECONDS=1

# Set Xterm/screen/Tmux title with shortened command and directory.
# Uncomment this to set.
#export SHORT_TERM_LINE=true

# Set vcprompt executable path for scm advance info in prompt (demula theme)
# https://github.com/djl/vcprompt
#export VCPROMPT_EXECUTABLE=~/.vcprompt/bin/vcprompt

# (Advanced): Uncomment this to make Bash-it reload itself automatically
# after enabling or disabling aliases, plugins, and completions.
# export BASH_IT_AUTOMATIC_RELOAD_AFTER_CONFIG_CHANGE=1

# Uncomment this to make Bash-it create alias reload.
# export BASH_IT_RELOAD_LEGACY=1

# Load Bash It
source "$BASH_IT"/bash_it.sh

$ cat /etc/skel/.bashrc
#
# ~/.bashrc
#

[[ $- != *i* ]] && return

colors() {
	local fgc bgc vals seq0

	printf "Color escapes are %s\n" '\e[${value};...;${value}m'
	printf "Values 30..37 are \e[33mforeground colors\e[m\n"
	printf "Values 40..47 are \e[43mbackground colors\e[m\n"
	printf "Value  1 gives a  \e[1mbold-faced look\e[m\n\n"

	# foreground colors
	for fgc in {30..37}; do
		# background colors
		for bgc in {40..47}; do
			fgc=${fgc#37} # white
			bgc=${bgc#40} # black

			vals="${fgc:+$fgc;}${bgc}"
			vals=${vals%%;}

			seq0="${vals:+\e[${vals}m}"
			printf "  %-9s" "${seq0:-(default)}"
			printf " ${seq0}TEXT\e[m"
			printf " \e[${vals:+${vals+$vals;}}1mBOLD\e[m"
		done
		echo; echo
	done
}

[ -r /usr/share/bash-completion/bash_completion ] && . /usr/share/bash-completion/bash_completion

# Change the window title of X terminals
case ${TERM} in
	xterm*|rxvt*|Eterm*|aterm|kterm|gnome*|interix|konsole*)
		PROMPT_COMMAND='echo -ne "\033]0;${USER}@${HOSTNAME%%.*}:${PWD/#$HOME/\~}\007"'
		;;
	screen*)
		PROMPT_COMMAND='echo -ne "\033_${USER}@${HOSTNAME%%.*}:${PWD/#$HOME/\~}\033\\"'
		;;
esac

use_color=true

# Set colorful PS1 only on colorful terminals.
# dircolors --print-database uses its own built-in database
# instead of using /etc/DIR_COLORS.  Try to use the external file
# first to take advantage of user additions.  Use internal bash
# globbing instead of external grep binary.
safe_term=${TERM//[^[:alnum:]]/?}   # sanitize TERM
match_lhs=""
[[ -f ~/.dir_colors   ]] && match_lhs="${match_lhs}$(<~/.dir_colors)"
[[ -f /etc/DIR_COLORS ]] && match_lhs="${match_lhs}$(</etc/DIR_COLORS)"
[[ -z ${match_lhs}    ]] \
	&& type -P dircolors >/dev/null \
	&& match_lhs=$(dircolors --print-database)
[[ $'\n'${match_lhs} == *$'\n'"TERM "${safe_term}* ]] && use_color=true

if ${use_color} ; then
	# Enable colors for ls, etc.  Prefer ~/.dir_colors #64489
	if type -P dircolors >/dev/null ; then
		if [[ -f ~/.dir_colors ]] ; then
			eval $(dircolors -b ~/.dir_colors)
		elif [[ -f /etc/DIR_COLORS ]] ; then
			eval $(dircolors -b /etc/DIR_COLORS)
		fi
	fi

	if [[ ${EUID} == 0 ]] ; then
		PS1='\[\033[01;31m\][\h\[\033[01;36m\] \W\[\033[01;31m\]]\$\[\033[00m\] '
	else
		PS1='\[\033[01;32m\][\u@\h\[\033[01;37m\] \W\[\033[01;32m\]]\$\[\033[00m\] '
	fi

	alias ls='ls --color=auto'
	alias grep='grep --colour=auto'
	alias egrep='egrep --colour=auto'
	alias fgrep='fgrep --colour=auto'
else
	if [[ ${EUID} == 0 ]] ; then
		# show root@ when we don't have colors
		PS1='\u@\h \W \$ '
	else
		PS1='\u@\h \w \$ '
	fi
fi

unset use_color safe_term match_lhs sh

alias cp="cp -i"                          # confirm before overwriting something
alias df='df -h'                          # human-readable sizes
alias free='free -m'                      # show sizes in MB
alias np='nano -w PKGBUILD'
alias more=less

xhost +local:root > /dev/null 2>&1

complete -cf sudo

# Bash won't get SIGWINCH if another process is in the foreground.
# Enable checkwinsize so that bash will check the terminal size when
# it regains control.  #65623
# http://cnswww.cns.cwru.edu/~chet/bash/FAQ (E11)
shopt -s checkwinsize

shopt -s expand_aliases

# export QT_SELECT=4

# Enable history appending instead of overwriting.  #139609
shopt -s histappend

#
# # ex - archive extractor
# # usage: ex <file>
ex ()
{
  if [ -f $1 ] ; then
    case $1 in
      *.tar.bz2)   tar xjf $1   ;;
      *.tar.gz)    tar xzf $1   ;;
      *.bz2)       bunzip2 $1   ;;
      *.rar)       unrar x $1     ;;
      *.gz)        gunzip $1    ;;
      *.tar)       tar xf $1    ;;
      *.tbz2)      tar xjf $1   ;;
      *.tgz)       tar xzf $1   ;;
      *.zip)       unzip $1     ;;
      *.Z)         uncompress $1;;
      *.7z)        7z x $1      ;;
      *)           echo "'$1' cannot be extracted via ex()" ;;
    esac
  else
    echo "'$1' is not a valid file"
  fi
}

cat /etc/skel/.bash_profile
#
# ~/.bash_profile
#

#[[ -f ~/.bashrc ]] && . ~/.bashrc

if [ -f ~/.bashrc ]; then
  . ~/.bashrc
fi

@TheHaricover  use vbrc and update the theme there, then open a new tab or window.

Hi yall !
Just for completeness, here's how you can get this to work:
.bashrc
# Default to powerline theme
export BASH_IT_THEME="${BASH_IT_THEME:=powerline}"

command line
# Start bash shell with bobby theme
$ BASH_IT_THEME=bobby bashit restart

Worked for me locally - I think I'll leave it like this to test themes a bit easier.
Hope that helps !

Thank you @tbhaxor and @davidpfarrell !


Up/down in notifications should reset focus

VS Code version: Code - Insiders 1.21.0-insider (1a84a882737184488d965426747a05474f54a759, 2018-02-27T06:17:53.785Z)
OS version: Linux x64 4.13.0-36-generic

#44319
Repro:

Trigger 2 notifications with buttons
Open notifications center
Press tab, the first button of notification 1 should be focused
Press down, moving "focus" to notification 2
Press tab, the second button of notification 1 is focused

I expect the first button of notification 2 to be focused

@Tyriar to be clear, you expect arrow-up/down navigation to work when one of the button has focus, is that true?

@bpasero the problem is that up and down do work when the button has focus, but the actual document focus doesn't go with it. I want navigating up and down to clear the focus on the button, so pressing tab will select the first button in the active notification.

@Tyriar got it
@joaomoreno it looks like our list commands are fired even if the list/tree does not have DOM focus. I think previously that was not the case when we had a focus tracker in place. Now since we have a scoped context key service, I guess the list/tree keybindings remain active when focus is within a list item widget as in this case.
One idea is to fix it by always calling tree/list.domFocus() after each command that gets invoked to ensure that the list/tree has DOM focus again.
Would you agree? I fear regressions, so maybe better to do this in debt week.

@bpasero Yup this is the problem with the context keys. That's why the inputFocus key exists: so we know when to exclude those rules when the user is focused on an input.
Another alternative is to create yet another scoped context key service for the action container, which would set listFocus to false.


Bug: New posts are uploaded twice (20 posts at a time) when a new posts type was selected

Fixed by a0ec386 commit


HHH-16558 Detach removes NaturalIdCrossReference in shared cache too

According documentation detach should only detach/evict the object from persistent contect (first level cache) not from second level cache too.
CachedMutableNaturalIdTest.java: New testmethod which fails without the fix
NaturalIdResolutionsImpl.java: fix, remove unneeded stuff

We need to squash and rebase this before integrating it upstream. I can do that (which ultimately means rejecting this PR) or you can do it and force push to your branch. Let me know.

Please do it. It does not matter to me if it needs the PR being rejected.

Also, did you open a PR against main?
No, I did open PR against branch hibernate:6.2 which I think is the current development branch.

Or should I just cherry-pick this there?
Sounds good.


all copper blocks and deepslate still have corrupted textures when covered by latex

specifically copper

Note to everyone facing this issue, it can be mitigated by pressing F3+T. That of course is no excuse for it to break in the first place; but, at least you can choose to fix it on your end in the mean time.


Fix broken script

Fixes an error which causes the script to always exit with No template file given as argument.

Coverage remained the same at 21.557% when pulling b3ce44134453aa717591376bf9b3a9e7caad00a8 on Yannic:master into 023fe41b6949e208ae2866ce7b1904e6064dd886 on wlbr:master.


chore: bump kcl lib 0.8.0 stable version

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

[x] N
[ ] Y

chore: bump kcl lib 0.8.0 stable version

2. What is the scope of this PR (e.g. component or file name):

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

[ ] Affects user behaviors
[ ] Contains syntax changes
[ ] Contains variable changes
[ ] Contains experimental features
[ ] Performance regression: Consumes more CPU
[ ] Performance regression: Consumes more Memory
[x] Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

[x] N
[ ] Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

[ ] Unit test
[ ] Integration test
[ ] Benchmark (add benchmark stats below)
[ ] Manual test (add detailed scripts or steps below)
[x] Other

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

18 of 27 (66.67%)  changed or added relevant lines in 1 file are covered.
12 unchanged lines in 1 file lost coverage.
Overall coverage decreased (-0.3%) to 62.805%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

pkg/tools/validate/validate.go
18
27
66.67%

Files with Coverage Reduction
New Missed Lines
%

pkg/tools/validate/validate.go
12
58.46%

Totals

Change from base Build<PHONE_NUMBER>:
-0.3%

Covered Lines:
3139

Relevant Lines:
4998

💛  - Coveralls


ghcjs: properly wrap binaries in environment

This fixes the problem that @dnhgff brought to my attention. Without this patch, ghcjs --make can't find the packages installed by Nix.
Another consideration:
I believe we ought to have a separate set of env vars for GHCJS, so programs compiled via GHCJS find the correct libs/compiler. This would entail editing pkgs/development/haskell-modules/ghc-paths-nix.patch so that the the env vars queried are predicated on the compiler. A simple #ifdef __GHCJS__ #ifdef ghcjs_HOST_OS should do.
@peti how does that sound? If you agree, I'll add that to this PR.

IMHO, it's fine to make the change to ghc-paths-nix.patch; it sounds reasonable to me.

So, I ended up just adding a new patch file, that way changes for ghcjs don't cause rebuilds for everyone else.

I think this is 99% done, but I want to first see if I can send a patch upstream to fix ghcjs-run.

Alright, I think I'm going to do the ghcjs-run patch later.
@peti This should be ready to merge now.
/cc @dnhgff

@cstrahan thanks, yes i've been using this without any problems

@dnhgff sweet - thanks for the initial report and the follow up :).

Just added another commit to set the NIX_GHCJS_* env vars in the env helper, so now this works too:
nix-shell -E '((import <nixpkgs> {}).haskell-ng.packages.ghcjs.reflex.env)'


[feat]: add a github action workflow for greeting contributors

Is your feature request related to a problem? Please describe.
Currently, this project does not have any action to greet to contributors. Github action is the great tool to automate the manual stuff for your project.
Describe the solution you'd like.
I would like to add a action workflow. This feature would automatically greet the author when specific event happens like:

When an issue is opened.
When a pull request is opened and merged.
When an issue is closed.
When an issue is assigned to someone, it notifies the assignee and start working.

How would this feature be beneficial for the project

The communication and engagement with the contributors will be improved.
It automates the process of manually greeting the contributors.

Record

[x] I agree to follow project's contribution guidelines
[x] I am a GSSoC'23 contributor
[x] I want work on this issue

Please assign me this issue under GSS0C'23
Thanks.

Thanks, but we don't need it as we actively engage with our contributors.


HDDS-9318. Prevent bucket from being deleted if incomplete MPUs exist

What changes were proposed in this pull request?
While working on the MPU cleanup service, there are possible scenarios that might cause issues when cleaning up / abort incomplete MPUs:

Cleaning up / abort MPUs whose bucket has been deleted
Cleaning up / abort MPUs whose bucket has just been recreated
Cleaning up / abort MPUs whose bucket has changed layout (i.e. delete the original bucket with OBS layout and creating an FSO bucket with the same name)

For case 1, the incomplete MPU will not be able to be aborted since S3MultipartUploadAbortRequest will fail when bucket doesn't exist.
For case 2, if we abort the newly created bucket, the bucket might end up with negative usedBytes since S3MultipartUploadAbortRequest will substract from the bucket quota.
For case 3, if the bucket changes layout from OBS -> FSO, the abort MPU will fail since the MPU open key is located in the openKeyTable, but due to the new FSO bucket layout, it will check openFileTable.
Therefore, to resolve above cases, let's have an invariant that "each incomplete MPU must belong to a unique existing bucket" by disallowing bucket deletion until all the MPUs under that bucket have been aborted / completed / cleaned up.
Edit: Seems this is also enforced in AWS S3 Bucket.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-9318
How was this patch tested?
Unit test.

Clean CI run: https://github.com/ivandika3/ozone/actions/runs/6243751117

@sumitagrawl @ashishkumar50 Could you help take a look if you have time?

Thank you for this very useful commit. Please address the additional test request.

Thanks @ivandika3 for adding the robot test.  It failed at this step:
Delete bucket with incomplete multipart uploads                       | FAIL |

https://github.com/ivandika3/ozone/actions/runs/6742322390/job/18328603228#step:6:9
due to:
Running command 'aws s3api --endpoint-url http://s3g:9878/ abort-multipart-upload --bucket bucket-ozone-test-4657775652 --key incomplete-multipartkey --upload-id 6a88b7b0-e1a1-45ad-b4d7-e85130106e4b-111345478830850064'
${rc} = 255
${output} = An error occurred (NoSuchUpload) when calling the AbortMultipartUpload operation: The specified multipart upload does not exist. The upload ID might be invalid, or the multipart upload might have been aborted or completed.

@adoroszlai Thank you for pointing out the error. I have fixed the typos in the acceptance test.
CI run: https://github.com/ivandika3/ozone/actions/runs/6760340775

Thanks @ivandika3 for updating the patch, LGTM.
@sadanand48 would you like to take a look?

Thanks @ivandika3 for the patch, @kerneltime, @swamirishi for the review.


Hidding query parameter from the controller method

In our project we have need to pass Request object to our controller. This is the routes file
POST         /check    controllers.CheckConotroller.checkStatus(request: Request)
Swagger is generating this output for the parameters object:
                "parameters": [                     {                         "name": "request",                         "in": "query",                         "required": false,                         "type": "string"                     }                 ],
Is there any way to remove the request parameter from the swagger generation?
In swagger annotations document (https://github.com/swagger-api/swagger-core/wiki/Annotations-1.5.X#apiparam), there is a reference to the @ApiParam annotation and hidden flag, but that does not work. With @ApiParam you can control what metadata you want to generate for the given query parameter, but as soon as you set hidden to true, all metadata are ignored and parameter is still in documentation.
An example
If you have controller method declaration like this:
public CompletionStage<Result> checkStatus(@ApiParam(required = true, type = "1", value = "something") Http.Request request)
then you get this in documentation:
                "parameters": [                     {                         "name": "request",                         "in": "query",                         "description": "something",                         "required": true,                         "type": "1"                     }                 ],
However, if you set hidden to true:
  public CompletionStage<Result> checkStatus(@ApiParam(required = true, type = "1", value = "something", hidden = true) Http.Request request)
then all annotation metadata is ignored and parameter is reverted back (or it is indeed removed, but default one is added once again):
                "parameters": [                     {                         "name": "request",                         "in": "query",                         "required": false,                         "type": "string"                     }                 ],
Adding an implicit parameter with the same name,, just adds another parameter without affecting the existing one.
Using Play for Java version: 2.7.0
and swagger-play2 version: 1.6.1

We've come across this issue moving to play 2.7, where the HTTP Request really needs to be added to the route as a parameter.
Our solution is to intercept the request and just remove any route parameters with the name of "request".
      Map<String, Path> paths = swagger.getPaths();
      if(paths != null) {
        for(String key : paths.keySet()) {
          List<Operation> ops = paths.get(key).getOperations();
          for(Operation op : ops) {
            List<Parameter> params = op.getParameters();
            params.removeIf(f -> "request".equals(f.getName()));
          }
        }
      }

This is an easy solution assuming that the route being added is always the same name, and that there aren't any real API parameters also named "route".


Issue using from_orm stripping Relationship data from models

First Check

[X] I added a very descriptive title to this issue.
[X] I used the GitHub search to find a similar issue and didn't find it.
[X] I searched the SQLModel documentation, with the integrated search.
[X] I already searched in Google "How to X in SQLModel" and didn't find any information.
[X] I already read and followed all the tutorial in the docs and didn't find an answer.
[X] I already checked if it is not related to SQLModel but to Pydantic.
[X] I already checked if it is not related to SQLModel but to SQLAlchemy.

Commit to Help

[X] I commit to help with one of those options 👆

Example Code
from sqlmodel import SQLModel, Relationship, Field, create_engine, Session
from typing import List, Optional, Literal

engine = create_engine("sqlite://", connect_args={"check_same_thread": False})

def create_db_and_tables():
    SQLModel.metadata.create_all(engine)

class LocationBase(SQLModel):
    street: str
    city: str
    country: str

class Location(SQLModel, table=True):
    id: Optional[int] = Field(default=None, primary_key=True)

    employee_id: Optional[int] = Field(default=None, foreign_key="employee.id")
    employee: "Employee" = Relationship(back_populates='locations')

class EmployeeBase(SQLModel):
    name: str
    job: str

class Employee(EmployeeBase, table=True):
    id: Optional[int] = Field(default=None, primary_key=True)
    locations: List[Location] = Relationship(back_populates="employee")

class EmployeeCreate(EmployeeBase):
    locations: List[Location]

def create_employees():
    locations = [Location(street='State St.', city='New York', country='USA')]
    e = EmployeeCreate(name='Test Employee', job='Test Job', locations=locations)

    employee = Employee.from_orm(e) # this strips the locations list from the Employee object
    print(employee)

    # You have to manually readd the locations before sending data to the DB.
    # If you skip this line then no location data will be added to the DB.
    e.locations = locations

    # Now you can commit.

def main():
    create_db_and_tables()
    create_employees()

if __name__ == "__main__":
    main()

Description
Apologies if this seems trivial! When using SQLModel's from_orm method the relationship data is stripped from the outputted model. I think that there may be an issue with how the from_orm method works in SQLModel but I can't diagnose where the data is actually stripped.
I found a similar issue here: https://github.com/samuelcolvin/pydantic/issues/1334. The difference is that typically (before SQLModel) most models refer to other Pydantic models instead of other relationships. This could be an example of a typical model relationship in Pydantic:
from pydantic import BaseModel

class Employee(BaseModel):
    id: int
    name: str
    type: str

class Address(BaseModel):
    id: int
    city: str
    employee: Employee

    class Config:
        orm_mode = True

e = Employee(id=1, name='Test', type='pydantic')
a= Address(id=1, city='New York', employee=e)

print(a.from_orm(a))

(This correctly outputs id=1 city='New York' employee=Employee(id=1, name='Test', type='pydantic'))
It's not a big deal to readd the models but it becomes tedious if you have many models to manage. I was wondering if anyone else had this issue and I couldn't find it referenced anywhere else. Thank you so much!
Operating System
macOS
Operating System Details
No response
SQLModel Version
0.0.6
Python Version
3.8.1
Additional Context
No response

I am having the same issue too

I was having the same issue, I'm confused why you are able to add Objects with children here in the Docs:

But in the Fastapi + SQLmodel example there is no example of how to solve this solution only if you want to read from the Database:

I'm assuming the Advanced guide might have a solution for how you create models with children.

@Butch78 I think we are having different issues.
In your first code example, you can add objects with children because you are creating the Team object directly. My example is a little different because I am creating a TeamCreate object and then using the from_orm method in Pydantic. The from_orm method strips out the child data when making the Team SQLModel object. So you have to manually add the child data to the Team object.
The docs do give an example of how to read from the database with children: https://sqlmodel.tiangolo.com/tutorial/fastapi/relationships/#models-with-relationships
My issues is strictly with the from_orm method only. Apologies if I'm misunderstanding your questions.

Sorry my answer wasn't very clear @res234, I would like to do the same as you and I agree the 'from_orm' Doesn't quite work right. I would like to Convert Json or TeamCreate objects into a SQLModel  using 'from_orm' that can then be added to the database instead of having to manually add it.

Facing the same challenge here... :-)

I'm facing the same issue. Any updates?

I'm here like for the same reason, was debugging and found out nested objects were being stripped. This is not intuitive at all, and I came across https://github.com/Wouterkoorn/sqlalchemy-pydantic-orm, but this should be a core feature of SQLModel IMO.

same issue here 😢

Yeah this bit me as well.


Publish to GitHub stuck with GitHub Pull Requests Extension

Issue Type: Bug
Publish to GitHub stuck with the GitHub Pull Requests and Issues Extension.
How to fix or debug this issue?
I edited and committed one small file with one line change, which is very fast as expected.
However, publish to GitHub for that commit is stuck in the two revolving circles at the status bar, even after one hour.
Authentication is fast with the GitHub Pull Requests and Issues Extension.
As a comparison, adding files, etc, at https://github.com with a browser, which is very fast as expected.
My Visual Studio Code has only one Extension:
GitHub Pull Requests v0.27.1
Visual Studio Code info:
Version: 1.57.1 (user setup)
Commit: 507ce72a4466fbb27b715c3722558bb15afa9f48
Date: 2021-06-17T13:28:07.755Z
Electron: 12.0.7
Chrome: 89.0.4389.128
Node.js: 14.16.0
V8: <IP_ADDRESS>-electron.0
OS: Windows_NT x64 10.0.19042
Extension version: 0.27.1
VS Code version: Code 1.57.1 (507ce72a4466fbb27b715c3722558bb15afa9f48, 2021-06-17T13:28:07.755Z)
OS version: Windows_NT x64 10.0.19042
Restricted Mode: No

System Info

Item
Value

CPUs
Intel(R) Core(TM) i5-2430M CPU @ 2.40GHz (4 x 2395)

GPU Status
2d_canvas: enabledgpu_compositing: enabledmultiple_raster_threads: enabled_onoop_rasterization: unavailable_offopengl: enabled_onrasterization: unavailable_offskia_renderer: enabled_onvideo_decode: enabledvulkan: disabled_offwebgl: enabledwebgl2: unavailable_off

Load (avg)
undefined

Memory (System)
5.86GB (0.72GB free)

Process Argv
--crash-reporter-id c894de1e-c7a8-472c-884b-527c2abe550a

Screen Reader
no

VM
0%

A/B Experiments
vsliv368:30146709
vsreu685:30147344
python383:30185418
pythonvspyt700cf:30270857
pythonvspyt602:30300191
vspor879:30202332
vspor708:30202333
vspor363:30204092
pythonvspyt639:30300192
pythontb:30283811
vspre833:30321513
pythonptprofiler:30281270
vsdfh931cf:30280410
vshan820:30294714
pythondataviewer:30285071
vscus158:30321503
pythonvsuse255cf:30323309
vscorehov:30309549
vscod805cf:30301675
pythonvspyt200:30329803
vscextlangct:30322307
binariesv615:30325510

Can you share the output from GitHub Pull Request?

This issue disappears.
Publish to GitHub works as expected.
The output from GitHub Pull Request is blank.


data ingestion endpoint proto

batch upload data from google sheet
Each row is matched to the Data proto message based on the columns from this sheet: https://docs.google.com/spreadsheets/d/1MWVXNHXgLdTHHTVmpi9HmQ3DRV6uU3CWfHdxshUeEUU/edit?gid=0#gid=0

Could you first clean up the commit history


way to install test_dependencies

Is there a way to get pongo to install packages listed in test_dependencies? It seems to only pick up dependencies.
Maybe I'm missing something intrinsic to lua? Is it possible to include test_dependencies when pongo runs tests?

what do you mean with test_dependencies ? That's not a Pongo thing is it?

ah, it's luarocks, in the rockspec

https://github.com/luarocks/luarocks/wiki/Rockspec-format#dependency-information
The rockspec format supports dependencies and test_dependencies things in dependencies seem to get installed when pongo runs. test_dependencies do not.

But you can update the Pongo test initialization with a custom luarocks command that would do it for you

Not familiar with that, example?

here's the docs: https://github.com/Kong/kong-pongo#test-initialization
here's the default action: https://github.com/Kong/kong-pongo/blob/master/assets/default-pongo-setup.sh


WIP: db2 support

Codecov Report

Merging #1387 into master will decrease coverage by 1.9%.
The diff coverage is 2.13%.

@@            Coverage Diff             @@
##           master    #1387      +/-   ##
==========================================
- Coverage   57.46%   55.55%   -1.91%
==========================================
  Files          44       45       +1
  Lines        7915     8187     +272
==========================================
  Hits         4548     4548
- Misses       2804     3075     +271
- Partials      563      564       +1

Impacted Files
Coverage Δ

dialect_db2.go
0% <0%> (ø)

xorm.go
67.16% <60%> (-1.02%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ce79b1c...c2d2ef1. Read the comment docs.


fallback to flash if video doesn't play with html5

Hello,
I have been trying to search for a solution that how can I fall back o flash if the video is not supported by mode:native in that case it should fallback to mode:shim? Kindly let me know how to do this trick?

@faizanqadri Set mode:auto_plugin. Closing old issues. If you'd like to reopen this, let us know. Thanks!


As an ECAD SDET, I want automated tests to ensure that user/group permissions are being set for artifacts correctly so that our end users don't run into frustrating errors

Describe the feature you would like
Automated tests that will ensure that any system generated files will have the correct non-root user/group permissions. Right now the things that will cause files to be generated are:

Compiling a ligo contract
Compiling a smartpy contract
Building taqueria as part of a scaffolding project (npm run setup && npm run build:taqueria after running taq scaffold)

Is this feature solving a problem?
For files/artifacts that are created by taqueria there are some that have the the user/group set to root which isn't too good for people needing to modify these files since they can run into permissions issues
Please share any additional details you have?
Details about the problem your feature solves
Code of Conduct

[X] I agree to follow this project's Code of Conduct

Closing: duplicate #374

Relates to: #374

@alexzbusko This can be closed, right?

@AlirezaHaghshenas it definitely can be. I don't understand how it isn't in the done state when it says that is was moved to the done state previously


Need a tool to stop a task once in progress.

we need a tool which can stop a long running worker task one in progress.

As a first step we really need to signal the workers (via the taskManager) to stop when they user types stop at the rcf read prompt


Log Search is no longer available It was changed to Log Analytics also some of the screenshots are from the previous UI

[FIM's UI was updated. Log Search is no longer available. It was replaced with Log Analytics. See section: Log Search opens when you enter a machine name in the search field or select a machine listed under the Computers tab. Log Search displays all the changes made during the selected time period for the machine. You can expand a change for more information. Also the screenshots need to reflect the new UI changes Thanks!]

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 041c588e-1148-a91e-9f60-137a64582676
Version Independent ID: 4faaf286-5b2f-215c-081e-4a31c83e1cad
Content: File integrity monitoring in Azure Security Center
Content Source: articles/security-center/security-center-file-integrity-monitoring.md
Service: security-center
GitHub Login: @memildin
Microsoft Alias: memildin

@SHANE0MAC
Thanks for your feedback! We will investigate and update as appropriate.

@SHANE0MAC
Thanks for your feedback! I have assigned this issue to the author who will investigate and update as appropriate.

Hi @SHANE0MAC, thanks for the feedback and for taking the time to help us improve the docs.
This change is included in a recent refresh of this page and you'll see the new page and graphics go live in the coming days.
I'm going to close this issue, but feel free to comment again here or open a new one if you have additional requests.
#please-close


[FEATURE REQ] Obfuscating ResponseError Details is breaking for consumers and unnecessary

Library name
Azure.Core <IP_ADDRESS>
Please describe the feature.
As previously discussed in this issue https://github.com/Azure/azure-sdk-for-net/issues/38890, Details, Target, and InnerError are all internal properties on the AzureDeploymentOperation.Properties.StatusMessage.ResponseError class. I understand the expectation is for resource providers (RPs) to ensure all information needed to diagnose an error are in the top-level error code and message, but it's not possible to actually enforce that or guarantee it. My RP, Azure Batch, currently inspects the error Details to inform both our internal error handling and what we return back to our customers. Removing visibility to these Details is effectively a breaking change for us.
I understand that a workaround is to call ToString() and to inspect the Details from there, but given you're making the Details available there, why not just make them accessible on the ResponseError object directly? This obfuscation is unnecessary, and forces consumers to add new logic on their side to avoid the breaking change.

@pateljay-37:  Please refer to the issue that you linked.  Your scenario and request align with the one made there, and the discussion thread with rationale and the decision remain salient.  I'm going to close this out, as there is no change to the outcome from the existing issue.


Import riv file to Unity, Cannot preview and Unity will Crash when reimport

When import riv file to unity will see this error.

Also cannot preview.

When reimport riv file, unity Editor will crash.

Rive version: 0.3.1-canary.31
Unity version: 2022.3.49f1c1
Macos version: 10.15.7


Vulnerability CentOS 7 : dhcp (CESA-2018:1453)(High) was found with NESSUS

A vulnerability: CentOS 7 : dhcp (CESA-2018:1453)(High) was found.
Scanner: NESSUS
Asset Information:
Asset name: ct1
IP: <IP_ADDRESS>
Scan was run on: 2018-09-05 09:15:06
Notification Rules Triggered: External Assets - New Critical Vulnerabilities to Github
Please see Nucleus for more information on these vulnerabilities

I don't know how to fix this :(


Handle MO .mos images

Dumped MO (magneto-optical) images for the X68000 use a .mos file ending, as per the de-facto standard established by the XM6 emulator for X68000.
This ticket is to make sure we support creating, listing and attaching .mos files in the web ui.
References:
https://mijet.eludevisibility.org/XM6 Pro-68k/XM6 Pro-68k.html
https://www.6502man.com/Bricolages/X68000/CD_MO_Scsi_Device/X68000_MO_howToUse_WintoX68KtoWin.html
Examples of supposedly valid .mos files:
https://nfggames.com/forum2/index.php?topic=4917.0
https://nfggames.com/X68000/

Out of the gate, rascsi on develop has no problem recognizing .mos images. However, the one and only verified .mos dump that I've found so far is just a few 100 bytes too large for rascsi to be able to attach it -- 228518912 when rascsi expects 228518400.

Would anybody notice if the X68000 stuff was just discarded? I wonder whether this can be supported at all, as far as testing is concerned.

Last I heard @akuker wasn't ready to discard X68k code. Agreed that testing is a challenge on that platform.
BTW, wasn't SCSI MO drives standard on NeXT machines as well? I'm pretty sure I saw someone mentioning using RaSCSI with their NeXT system.

Current develop now recognizes .mos images on the back and frontend side: rascsi backend recognizes it as a SCMO device, while the frontend has it among the 'recognized file types'.
At this point, I think creating mos images is out of scope, since noone on the dev team has an environment to validate the functionality further.

@rdmark One more note on this: I tried different MO drives in the past with my Atari, and at least with the Atari no special handling is needed. You just need a driver that supports optical drives and (depending on the medium) 2048 bytes per sector. Then you can use MO drives like any other removable media drive.
Using any .mos image with the Atari works fine. The only restriction is that rascsi limits the choice of available images sizes to what it assumes to be the size of real-world MO media.


Error on macOS 10.14.6 while create GNU/Linux (amd64) binary: Package webkit2gtk-4.0 was not found in the pkg-config search path...

What OS are you using (uname -a, or Windows version)?
Darwin My-MBP.local 18.7.0 Darwin Kernel Version 18.7.0: Sat Oct 12 00:02:19 PDT 2019; root:xnu-4903.278.12~1/RELEASE_X86_64 x86_64
What programming language are you using (C/C++/Go/Rust)?
go version:
go version go1.13.4 darwin/amd64

And already installed:

brew install gtk+3
brew install pkg-config

What did you expect to see and what you saw instead?
I want to create GNU/Linux (amd64) binary of my simple Hello World program on macOS 10.14.6.
My main.go:
package main

import "github.com/zserge/webview"

func main() {
	// Webview options:
	//  - name: Google App
	name := "Google App"
	//  - URL: google.com
	url := "https://google.com"
	//  - sizes: 800x800 px
	width := 800
	height := 800
	//  - resizable: true
	resizable := true

	// Let's open window app with options:
	webview.Open(name, url, width, height, resizable)
}

$ cat ./Makefile

build-linux:
        rm -rf ./build/Linux/ \
        && mkdir -p ./build/Linux/ \
        && GOOS=linux GOARCH=amd64 CGO_ENABLED=1 \
        go build -o ./build/Linux/app-linux-amd64

And see this error after run make build-linux:
# pkg-config --cflags  -- gtk+-3.0 webkit2gtk-4.0
Package webkit2gtk-4.0 was not found in the pkg-config search path.
Perhaps you should add the directory containing `webkit2gtk-4.0.pc'
to the PKG_CONFIG_PATH environment variable
No package 'webkit2gtk-4.0' found
pkg-config: exit status 1
make: *** [build-linux] Error 2

What I miss? Please help to understand.

On Arch i had to install webkit2gtk


File has changed;  recompiling...

when I run the webpack build, cause this.
use the http request on nodejs server, compile several different project at the same time，it 'file has changed; recompiling...' all the time, and it return all at the same time.
[2017-06-20 15:13:33.895] [INFO] console - Happy[babel]: Version: 3.1.0. Using cache? Yes. Threads: 8 (shared pool)
[1] [2017-06-20 15:13:33.907] [INFO] console - Happy[babel]: Loaded 0 entries from cache. (0 were stale)
[1] [2017-06-20 15:13:34.231] [INFO] console - Happy[babel]: All set; signaling webpack to proceed.
[1] [2017-06-20 15:13:34.232] [INFO] console - Happy[json]: Version: 3.1.0. Using cache? Yes. Threads: 8 (shared pool)
[1] [2017-06-20 15:13:34.234] [INFO] console - Happy[json]: Loaded 0 entries from cache. (1 were stale)
[1] [2017-06-20 15:13:34.563] [INFO] console - Happy[json]: All set; signaling webpack to proceed.
[1] parseQuery() will be replaced with getOptions() in the next major version of loader-utils.

[1] [2017-06-20 15:13:36.211] [WARN] console - File has changed; re-compiling... (D:\xxx\src\xxx\index.json)

[1] [2017-06-20 15:13:39.337] [INFO] console -
[1] Starting to optimize CSS...
[1] [2017-06-20 15:13:39.338] [INFO] console - Processing index.89491a8e827a2f3b208d9af4a5e037b7.css...
[1] [2017-06-20 15:13:39.396] [INFO] console - Processed index.89491a8e827a2f3b208d9af4a5e037b7.css, before: 4816, after: 4785, ratio: 99.36%
[1] Hash: dd1a9085ed249c8d5ec3
[1] Version: webpack 2.6.1
[1] Time: 5817ms
[1]                                                      Asset       Size  Chunks             Chunk Names
[1]                      static/js/app.1826a2043624b2229a76.js      47 kB       0  [emitted]  app
[1]                 static/js/manifest.f14679b613452583ca0c.js    1.43 kB       1  [emitted]  manifest
[1]                 index.89491a8e827a2f3b208d9af4a5e037b7.css    4.79 kB       0  [emitted]  app
[1] static/pre/core/index.c4d0159c18fc224c6090645a2e77b75d.css    7.17 kB          [emitted]
[1]  static/pre/core/index.e06cf9ace201a0d376faec95fe6bb295.js     139 kB          [emitted]
[1]                                                 index.html  841 bytes          [emitted]

If you're doing multiple builds, the v4 branch may be more stable since there is no caching, can you try that?

is v4 ready?

It's been released a while ago, yes.


179 new mapping service

Switch to a new endpoint, this endpoint also includes rats!

New field, global id containing a GUID, that is now used as occurrence id

Did the event id change?

The event id changed in the past (since last update to GBIF), but not between the old (encrypted) endpoint, and this new (encrypted) endpoint.

The new endpoint uses the same credentials

We have been assured this global_id (a GUID) will remain stable, even when the databank is updated or restored from backup. After this PR, we should be able to update the dataset to GBIF again.
We will lose some 500 records (didn't investigate which ones, just counted them), but gain around 80k, (all rats).


Catch errors on Release Planner creation and validate Swagger PR LInk for Management Plane

The current code is missing error catching and handling.
It is also not validating that the Swagger PR Link field value from the ADO Work Item is a valid URL.
This work is related to: https://github.com/Azure/azure-sdk-tools/issues/5913

Added. Also, I added details to the error notification so we know exactly what went wrong in future failures.
Now only Data Plane steps are missing this validations and error catchs.


Search by a part of a word

George Dorn @gdorn
@AndStatus how do I filter all posts containing links to a specific domain?  Is substring matching not a thing, or have I just not found the right wildcard character?
( https://social.coop/@gdorn/100244759788431726 )

Currently #AndStatus can show timelines filtered by full words or by quoted phrases, containing full words only. This is why, for example, domain name loadaverage.org can be found only in a case it is typed as a separate word, like in this post, and not as a part of the URL with a path inside this domain.
We need to adopt some syntax to tell the application that substring search should be used. #ActivityPub doesn't mention any query syntax. So in order to filter by a part of URL I think that Twitter's "premium" :-) syntax could be used, e.g.:
contains:loadaverage.org
or even:
contains://loadaverage.org/
in order to avoid matching with longer domain names.
See https://developer.twitter.com/en/docs/tweets/rules-and-filtering/overview/premium-operators.html

Implemented in v.41


Ensure node buttons are redrawn when flow lock state is changed

When locking/unlocking a flow, we weren't redrawing the flow to update the enabled/disabled node buttons.
This fix ensures we mark the nodes as dirty so they get redrawn in the correct state.

Coverage: 68.622% (+0.03%) from 68.591% when pulling 70771bf3d65d4d4acbf06609618d0319bbb02d8d on enable-unlocked-buttons into 2ed17f0fff8b39fbc1853ac0a1b3ed5abc802ddd on dev.


Fill Out BoundSpec Functionality

Currently, BoundSpec is just a simple wrapper around the document produced by the process of binding results to properties within a specification. However, we should be able to interact with BoundSpec the same way we do with all other types within the hierarchy.

PR #146 ended up possibly addressing this, since now ValidatedSpec (formerly BoundSpec) contains a Spec and a list of Results, and has to/from json functions, unlike its previous implementation.

Closed by #146,


options package to kotlin

Describe your changes
options package converted to kotlin from java
Fixes #26
Checklist:

[x] I have performed a self-review of my code
[x] I have commented my code
[x] My changes generate no new warnings
[x] Have you successfully run tests with your changes locally?

Thanks for the work 💯


Move the KMS integration imports into the binary entrypoints

Ticket Link
Related: https://github.com/sigstore/sigstore/issues/384
Related: https://github.com/sigstore/sigstore/issues/386
Release Note
BREAKING: if you use cosign as an SDK and rely on KMS integrations, you will need to start importing the integrations you would like to support.

cc @imjasonh

Codecov Report

Merging #1744 (3e1ef76) into main (0ee9d1b) will decrease coverage by 0.03%.
The diff coverage is n/a.

:exclamation: Current head 3e1ef76 differs from pull request most recent head 44d32ff. Consider uploading reports for the commit 44d32ff to get more accurate results

@@            Coverage Diff             @@
##             main    #1744      +/-   ##
==========================================
- Coverage   29.48%   29.45%   -0.04%
==========================================
  Files         141      141
  Lines        8505     8505
==========================================
- Hits         2508     2505       -3
- Misses       5726     5728       +2
- Partials      271      272       +1

Impacted Files
Coverage Δ

cmd/cosign/policy_webhook/main.go
0.00% <ø> (ø)

...econciler/clusterimagepolicy/clusterimagepolicy.go
64.00% <ø> (ø)

pkg/signature/keys.go
19.49% <ø> (ø)

pkg/cosign/tuf/client.go
62.69% <0.00%> (-0.95%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0ee9d1b...44d32ff. Read the comment docs.


The resulting openpose image has inconsistent coordinates with the reference video

MimicMotion GetPoses coordinates and sizes of the generated openpose image and the reference video are inconsistent, How can I fix it? Please...

It tries to match the pose of the reference image to the poses of the motion video, so it's going to be offset if they are too different to begin with.


Add Python ChaCha20 implementation with a 64-bit nonce

Adding as a PR so I can leave review comments

Are you planning to open this as a PR on the Bitcoin Core repo? I'm going to close this PR now, unless having it open helps you track these comments.

@jnewbery Yep, I'll be opening this as PR on the Bitcoin Core repo. I think I can still see the comments even if you close the PR, but I saved the page just in case, so feel free to close the PR.


Fix ListArtifacts to return correct paths

Fixes #355.

the root_uri key now returns the run's artifact location
the path keys of the returned files are now relative to the root_uri
the returned files are sorted by path
an empty directory returns an empty list of files instead of an error
avoids a race condition where a file is removed after we read the directory (local storage)
properly list directories in S3 storage (not recursively)
proper support of runs whose artifact URI starts with file://

Ahh, and it will be nice to add tests for dir object.

already done in both unit and integration tests :)


Fix GO:0035979 histone H2AS139 kinase activity

Position S139 is on H2AX, and not H2A (which is shorter)
So I changed the label  to histone H2AXS139 kinase activity and the definiton to mention H2AX.
@colinlog
Thanks, Pascale

(This sounds really, really close to creating GO terms for single gene products.)

(the term already existed...)
It was decided a while ago to capture the main histone modifications in order to capture their cellular effects. I am just trying to make this consistent.


feat: add basic support for setStatusMessage

Let's release a new version so the changes can be implemented in the sdk | local-storage ?

Let me check the E2E tests first, I'd like to see how this works on the platform.

I was expecting the status message to be printed to the console logs, which apparently it is not. I'd like the behaviour to be the same regardless of the storage being used, it should always log to console, and if apify client is used, it will also make the API call.
Other than that, it seems to be working fine.

Well, we haven't released yet, this is still doable. I would argue that the output will be a bit duplicit on the Platform (seeing the new status message both in the log and the status message pill), but it's probably better than having different logs locally and on the platform 🤔 Let's log from Crawlee directly and noop the statusMessage in the local storage implementations

Well, we haven't released yet, this is still doable. I would argue that the output will be a bit duplicit on the Platform (seeing the new status message both in the log and the status message pill)

The log should be the main source of truth, and only there you can see the history - status message changes over time.

Yeah I don't mind logging from crawlee. I think it sounds sane to have setStatusMessage on storage level that only handles API call (and is no-op in memory/local), and handle the actual logging to console on higher level, e.g. we already do that with Actor.exit, that is the method that logs the message to console + calls setStatusMessage to make the API call.

pr in here #1808

Agree with log everywhere.