Get-Command -List doesn't consider implied executable filename extensions when a PowerShell-native command by a given name takes precedence

Prerequisites

[X] Write a descriptive title.
[X] Make sure you are able to repro it on the latest released version
[X] Search the existing issues.
[X] Refer to the FAQ.
[X] Refer to Differences between Windows PowerShell 5.1 and PowerShell.

Steps to reproduce
Get-Command -List is meant to list all forms of a given command, in descending order of precedence.

Without -List, and with -List if the effective form of the command happens to be an external executable, commands can be discovered even without their filename extension, e.g. Get-Command findstr to discover findstr.exe)

However, if an external program with a given base name happens to be shadowed by a PowerShell command with higher precedence, it isn't discovered by Get-Command -List

# On Windows
Get-Command findstr
'---'
function findstr { 'dummy' }
Get-Command  -List findstr

Expected behavior
CommandType     Name                                               Version    Source
-----------     ----                                               -------    ------
Application     findstr.exe                                        10.0.2262… C:\Windows\system32\findstr.exe
---
Function        findstr
Application     findstr.exe                                        10.0.2262… C:\Windows\system32\findstr.exe

Actual behavior
CommandType     Name                                               Version    Source
-----------     ----                                               -------    ------
Application     findstr.exe                                        10.0.2262… C:\Windows\system32\findstr.exe
---
Function        findstr

That is, the -List invocation no longer discovered findstr.exe, because a shadowing PowerShell command exists.
Error details
No response
Environment data
PowerShell 7.4.0-preview.6 on Windows 11 22H2

Visuals
No response

In 7.3.8
Get-Command -List findstr    # return only function
Get-Command -List findstr*   # return function and executable (in this order)

There is no -List parameter. -List does get expanded to -ListImported though. Are you thinking about the -All parameter? If so, then it seems to work as expected:

Good point, @MartinGC94, I must have confused it with Get-Module -List.
So the bug isn't what I expected, but a different one - or at least an inconsistency.
Since the concept of imported never applies to external programs, it doesn't ever make sense to include them - yet if no PowerShell command by that name exists, they are.
Before I re-title and modify the original post: Do you agree? Just want to make sure there's isn't something I'm missing.

I am not sure. You are of course right that applications can never be imported so from that perspective they should never show up if -ListImported has been specified but was that really the intent behind that parameter? Probably not. The point of -ListImported is seemingly just to exclude PS modules that hasn't been imported yet.

Thanks, @MartinGC94, you're right: I got stuck on the concept of -All, i.e. including shadowed commands, but that isn't inherent to -ListImported. Closing this.


missing filename. request should include a content-disposition header with a filename parameter

Hi, using a Multipart Body I received a unexpected error from the server:
missing filename. request should include a content-disposition header with a filename parameter

...
Request.Builder b =...
b.patch(new MultipartBody.Builder()
          .addFormDataPart("a", "b")
          .addFormDataPart("c", "d")
          .build()
          );
b.build();
...

Sorry if the code is not accurate, I didn't check before post this, anyway this is a simple code
Did anyone knows How to fix this? Or what I did wrong?

See documentation https://square.github.io/okhttp/recipes/#posting-a-multipart-request-kt-java
Please use stackoverflow for such usage questions in future, the issue tracker is really only for bug reports.


Integrate write hooks to metrics storage into actual worker code

Integrated basic implementation, need to improve and all the protocol info not directly exposed to go


feat: rm, rmdir, cp, command history, better flag handling, relative path fixes

Summary
Original PR here: #112
Continuing work on #109

Added rm, rmdir, cp with flags
Fixed bugs with relative paths containing "/" not working
Added support for better flag handling and clear
Toggle through command history with up and down arrow keys
Handling some edge cases with accessing root directory parents (just return the root)
Added support for trailing "/"
Included helper methods for cleaning up code in the future

TODOs:

Finish mv, grep, find, chmod

Add in permissions to the file system (requires refactoring)

Add piping and redirection
ls long format (requires adding additional metadata to file system objects)
Clean up code (remove repeated code using helper functions like getFSObjectHelper)
Refactor - make the flags into an array of strings instead of a string
Refactor - stop using undefined and switch it out with null
Refactor - make stderr/stdout array into an object with stderr and stdout
Refactor- Set up parsing for the flags
Unit tests for argument parsing and file system functionality
Add constants file to improve code maintainability and readability

Test Plan
Note: terminal styling is still broken in these recordings, should be fixed by #124
rm file and directory and rm -r directory:
https://user-images.githubusercontent.com/13056466/193698487-2f6ff271-daa3-49b3-9f53-f172c425b18f.mov
rm . and rm .. and rm / and rmdir nonempty directory:
https://user-images.githubusercontent.com/13056466/193698579-10577f4a-6330-482b-aae9-ecf0d7ad51e8.mov
rmdir empty directory:
https://user-images.githubusercontent.com/13056466/193698660-80640e6d-1cc8-402b-829c-e16f2ae33c2f.mov
Toggling through the command history:
https://user-images.githubusercontent.com/13056466/193698741-26b19c24-0981-43ab-aafe-ef0efa6915ed.mov
cp file and cp file to directory and cp and rename in directory
https://user-images.githubusercontent.com/13056466/193698884-efac9423-3d3b-48f2-86ca-047a4abc6a82.mov
Very complicated cd with access to above root and trailing /
https://user-images.githubusercontent.com/13056466/193698988-8c1131c2-76d0-4b0e-afa9-b75e7237fe57.mov

Awesome test plan, you've raised the bar for quality for this project!


[ESLint-plugin] Adds 'getDerivedStateFromError' to the list of React lifecycle methods to 'react-prefer-private-members'

Adds getDerivedStateFromError to the list of React lifecycle methods to @shopify/react-prefer-private-members.
Fixes https://github.com/Shopify/web-foundation/issues/167
To allow:
class ErrorBoundary extends Component<PropsWithChildren<Props>, State> {
  static getDerivedStateFromError() {
    return {hasError: true};
  }

  render() {
    ...
  }
}

Merge away! Ask in #web-foundation-tech if you want a hand releasing this


Ij 162 update wellbeing colour scale

Updated the colour scale for wellbeing assessment charts as some colours looked very similar and imperceptible.

When creating this branch I accidentally checked out from the feature branch I was working on. I don't believe there are any breaking changes, but should I close this branch and try again?


What licence is this under?

As the title says, I can't see a licence for this?

At least the basic Linux app parts seem to be derived from this: https://fossies.org/linux/flutter/examples/platform_channel/linux/my_application.cc
So it should be whatever "BSD-Style" license the Flutter Devs use, or a compatible one. Not sure about the other parts.
https://github.com/flutter/flutter/blob/master/LICENSE


HTTP and HTTPS exist in the same router Accessing http://domain results in 404 .But accessing http://domia is normal

Do you want to request a feature or report a bug?
Bug
Did you try using a 1.7.x configuration for the version 2.0?

[ ] Yes
[ ] No

What did you do?
When Entrypoints configured both HTTP and HTTPS, I set redictscheme: HTTPS, but I did not redirect to https://domain when visiting http://domian. Instead, the browser reported an error of 404
What did you expect to see?
I want to access http://domain and redirect to https://domain
What did you see instead?
Access http://domian without jumping https://domian, the interface shows 404
Output of traefik version: (What version of Traefik are you using?)
traefik: v2.0
docker:18.03.1-ce
kubernetes:v1.11.2
OS: Centos7.2

What is your environment & configuration (arguments, toml, provider, platform, ...)?
config：
apiVersion: traefik.containo.us/v1alpha1
kind: IngressRoute
metadata:
  name: admin
spec:
  entryPoints:
    - web
    - websecure
  routes:
  - match: Host(`pwjtest.zhixueyun.com`) && PathPrefix(`/`)
    kind: Rule
    services:
    - name: traefik
      port: 18080
    #  scheme: https
    middlewares:
    - name: admin-https
    - name: admin-auth
    #- name: admin-header
  tls:
    secretName: supersecret
---
apiVersion: traefik.containo.us/v1alpha1
kind: Middleware
metadata:
  name: admin-https
spec:
  redirectScheme:
    scheme: https
    permanent: true
    port: 443
---
apiVersion: traefik.containo.us/v1alpha1
kind: Middleware
metadata:
  name: admin-auth
spec:
  basicAuth:
    secret: authsecret

        - --api.insecure
        - --accesslog
        - --entrypoints.web.Address=:80
        - --entrypoints.websecure.Address=:443
        - --entrypoints.traefik.Address=:18080
        - --api.dashboard=true
        - --providers.kubernetescrd

Hi! I'm Træfiker :robot: the bot in charge of communication regulation.
Thanks for your interest in Traefik!
We dedicate the issue tracker to bug reports and feature requests only. My advanced AI has spotted that your issue might be a configuration problem or relates to something that doesn't look like a bug.
To confirm this, please join our Community Forum and reach out to us on the Traefik section.
In case I'm wrong (well, that would be embarrassing :sweat_smile:), my developers will re-open the issue and fix me!
In the meantime, you can double check Traefik's documentation.

Also experiencing this exact same issue. It is not convenient for a bot to redirect the issue to a forum...

Hi @peiwenjian , thanks for switching to the community forum (ref. https://community.containo.us/t/kubernetes-http-to-https-redirect/1337/4)!
Hi @Elegant996, to improve the triage of issues and help the maintainer team , we use the Github Issue tracker only for bugs, proposals and feature requests. Anything related to configuration usage is tracked in the forum where knowledge sharing is clearly better. We (maintainers) try to provide support daily in the forum as well as triaging issues in Github.
By the way, since the redirect topic gained some traction on the community forum, the documentation had been improved with example that you might find useful: https://docs.traefik.io/migration/v1-to-v2/#http-to-https-redirection-is-now-configured-on-routers.


UaaS Toolkit

Rename project as UaaS Toolkit, including other features, such as...
Razor extension methods:

@Umbraco.IsDevelopment()
@Umbraco.IsStaging()
@Umbraco.IsLive() or @Umbraco.IsProduction()

Developer section: UaaS Dashboard

Node Id->Guid lookup
Node Guid->Id lookup
Courier - Force Deploy
Courier - Force XML Rebuild

C# Helper methods

UaaSHelper.GetUmbracoEnvironment() returning "local", "development", "staging", "live"

Closing. Renamed the project and added initial code for the UaaS Toolkit (dashboard and extension helper methods)


Add language support for rendering errors and progress logs

This pull request introduces a new feature that adds language support for rendering errors and progress logs in After Effects.
The changes allow users to specify the language of their After Effects installation via a new --language flag. This flag directly impacts the parsing of error and progress messages from the renderer. Syntax and text from these logs can fluctuate based on the language, thus this feature enhances the versatility and compatibility of our tool across multiple language installations.
Changes:

Introduced a new --language flag to specify the language of After Effects installation.
Added support for interpretation of error and progress logs in both English and German.
Created a translation map to easily handle translation of keywords and phrases present in logs

Example use:
nexrender-worker-win64.exe --host=http://my-host:3000 --multi-frames --ae "v ERRORS_AND_PROGRESS" --language de
Please review and provide any feedback.

@schubc that is an amazing addition!


Remove labels from map properties inputs

Removes labels from fields describing what they do. Empty fields will have default text describing what should be there, but fields with content will show the content instead.
Screenshots:

+1


Update contributors-readme.yml

:white_check_mark: Build Sankhya-SDK-dotnet 3.0.541 completed (commit https://github.com/guibranco/Sankhya-SDK-dotnet/commit/740b02c275 by @guibranco)


buildUpdateInput()

There's an easy way to get, put and delete but no easy way to update.  It would be nice if there was one or more ways to build UpdateItemInput and set the update expression.
UpdateItem: https://docs.aws.amazon.com/amazondynamodb/latest/APIReference/API_UpdateItem.html
Update expression: https://docs.aws.amazon.com/amazondynamodb/latest/developerguide/Expressions.UpdateExpressions.html

This was added in https://github.com/Giftbit/dynameh/releases/tag/v3.0.0 .


add gvalid type password1: Contains numbers and letters

add gvalid type password1: Contains numbers and letters
Issue
https://github.com/gogf/gf/issues/2190

Codecov Report
Base: 76.57% // Head: 76.57% // Increases project coverage by +0.00% :tada:

Coverage data is based on head (c389e15) compared to base (2598745).
Patch coverage: 85.71% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2209   +/-   ##
=======================================
  Coverage   76.57%   76.57%
=======================================
  Files         580      581    +1
  Lines       48272    48286   +14
=======================================
+ Hits        36964    36975   +11
- Misses       9291     9293    +2
- Partials     2017     2018    +1

Flag
Coverage Δ

go-1.15-386
76.60% <85.71%> (+0.05%)
:arrow_up:

go-1.15-amd64
76.60% <85.71%> (+0.01%)
:arrow_up:

go-1.16-386
76.59% <85.71%> (+<0.01%)
:arrow_up:

go-1.16-amd64
76.59% <85.71%> (+0.01%)
:arrow_up:

go-1.17-386
76.59% <85.71%> (+0.01%)
:arrow_up:

go-1.17-amd64
76.59% <85.71%> (+<0.01%)
:arrow_up:

go-1.18-386
76.54% <85.71%> (+0.05%)
:arrow_up:

go-1.18-amd64
76.53% <85.71%> (+0.03%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

util/gvalid/internal/builtin/builtin_password1.go
85.71% <85.71%> (ø)

os/gfsnotify/gfsnotify_watcher.go
81.51% <0.00%> (-2.53%)
:arrow_down:

os/gfsnotify/gfsnotify_watcher_loop.go
83.19% <0.00%> (-1.69%)
:arrow_down:

os/gcache/gcache_adapter_memory_lru.go
97.82% <0.00%> (+8.69%)
:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

@zhonghuaxunGM 感谢您的贡献，但这种简单的密码规则并不通用、较为特殊。建议使用正则表达式regex:$[a-zA-Z]\d]+^


fix #296 - add go modules support

Add go modules support with golang.org/x/tools/go/packages

This works nicely for me.
I had to change the generate command to //go:generate go run gopkg.in/src-d/go-kallax.v1/generator/cli/kallax gen. It would be good to document this requirement in the readme.
And for anyone else wanting to test I added a temporary line to my go.mod file to use this PR: replace gopkg.in/src-d/go-kallax.v1 => github.com/s-kostyaev/go-kallax v1.3.6-0.20190705185553-021d805e3744

Confirming, works good. It just needs to be confirmed to be working for non-mod projects for backward compat

Do we have any update with this one?


Add a docker image for hyperkube, and instructions on how to use.

Please don't merge until I get the service proxy working.  Should be this evening.

Comments addressed.  Support for services added.  Ready to merge (I guess on Monday)

tested locally :+1:
Very nice.

This works very well for me, and makes playing around with porting stuff to run on kubernetes much easier, thank you.

I'll take another look monday and run through it myself once before merging.

Ok, comments addressed.  I think this is ready to merge.  I'm going to continue to iterate, but let's get this checkpointed.

LGTM.


update button

close #1220
Hi @PoorviShetty , I've Improve the alignment of buttons, please check

Fix the Merge Conflicts

Please check #1346

Hi @Souravvmishra, I've resolved the merge conflicts, please check

Add your name either to the very first or very last in data.js

Hi @PoorviShetty, @Souravvmishra , please consider merging the pull request


Implement Field of View and Explored Tiles

As a roguelike developer, I would like for the map that comes from my integration library to contain a Field-Of-View handler that takes care of tile visibility and seen/unseen values.

@Thraka  This will likely require integrating bugfixes made to SadConsole v9 after the release of 9.0.0-beta3, so this will probably have to wait until the next SadConsole release.
@fcheadle An implementation of this may also be affected by the architectural fixes for #4, #9, and #16 , so these may be good prerequisites.

@Thraka  This will likely require integrating bugfixes made to SadConsole v9 after the release of 9.0.0-beta3, so this will probably have to wait until the next SadConsole release.
@fcheadle An implementation of this may also be affected by the architectural fixes for #4, #9, and #16 , so these may be good prerequisites.


Set maximum points to 1.0 on new assignments

The platform always returns a percentage, but we set the max points of
new grades to be 100, which means students need a really big curve to pass.

Coverage remained the same at 100.0% when pulling bbedb5a324977d3ce13e542fd7268897e2c4b57f on feature/fix_max_points into 30a6eaf8cb65590268fc08593d8b7adfe7cb3796 on master.

:+1: Looks like I was a little off in where I thought this change was meant to happen. Thanks getting rid of those zeroes.


Update and rename mc.is-cool.me to mc.is-cool.me.json

Requirements

[x] You have completed your website.
[x] The website is reachable.
[x] The CNAME record doesn't contain https:// or /.
[x] There is sufficient information at the owner field.

Description

Link to Website

..

Merged.


[FEAT] Option for putting remote instances in a folder

We have some wally packages such as these, that we use internally:

Character animation (replicated headtracking, hand/arm ik, etc)
Interactables (proximity prompts with extras like better seat handling, also has custom replication)
Physics package (better network ownership, with actions and low-cost replication to clients)
and some others, but these are the important ones.

I'd like to migrate each individual package to use Zap for optimized networking, but I dont want to delegate all the remote definitions and handling to the consumers of these packages (games).
Right now each package can use the remote_scope option, and migrating to zap will work, but it means we'll have a lot of remotes directly in ReplicatedStorage. That indirectly means:

Finding instances whenever ReplicatedStorage is opened is more difficult
IDE autocomplete for instances under ReplicatedStorage gets cluttered

It would be nice to have a remote_folder setting, or something similar, where as long as all packages use the same option value, all remotes will be under this one folder. It doesn't need to support nesting or anything fancy, a single folder is fine.

Completed in https://github.com/red-blox/zap/commit/523d15f0f73f7af260c49889ba26b7168525fbc7


feat: allow custom install commands on yarn-install

TDESKAPP-700
Description
Add the ability to run custom yarn install commands.
How to test

Run the yarn-install action pointing to TDESKAPP-700-install-options
Example: https://github.com/toptal/desktop-app/actions/runs/3044433958/jobs/4904817778

Development checks

[x] Add changeset according to guidelines (if needed)

PR commands

List of available commands:

@toptal-anvil ping reviewers - Ping FX team for review

@toptal-anvil ping reviewers


Added types definition for TypeScript (picking up #238)

I've picked up on @brennanMKE's work from #238 and attempted to address the points of @isaacs's feedback.

No internal implementation details are exported
All assertions and synonyms mentioned in the public documentation are included
parameter types have been tightened down where possible
Exported description now closely mirrors the actual exported object

Additionally, I've added a typings field to the package.json, which should make tap work "out of the box" with versions of Typescript >= 1.6. It's in a separate commit in case that weirds anyone out. (See: http://www.typescriptlang.org/docs/handbook/typings-for-npm-packages.html for reference)
Have attempted to be thorough and have referenced both the documentation and the source. Seems to work well from my own usage. Let me know if you see any problems and I'm happy to bang on it a little more. A few things I know of that are lacking / loose-endy:

There are some generated iterations of assertion synonyms not mentioned in the API docs that I didn't include in the type definitions. It wouldn't be a big deal to add them if you'd like
I've included only a super-minimal description of the promises returned from the test, spawn and stdin methods. What's actually returned is a Bluebird promise. Wasn't sure the right way to proceed with this.
I've made no attempt to document the inherited properties of readable-streams.

Cheers!

This looks good, and is reasonably intelligible.
Can you add a test for it?  How would I verify that I haven't broken it (for example, by changing the code in the future to change an interface)?

@isaacs : To test it I'll need to add typescript as a dev dependency. You cool with that?

Yeah, as a dev dep it's totally fine.

👍 Thanks for continuing with this update. I prefer tap over other test modules.

Compiling with noImplicitAny gives me. Might be a good idea to fix those before merge.
typings-custom/tap.d.ts(13,3): error TS7010: 'tearDown', which lacks return-type annotation, implicitly has an 'any' return type.
typings-custom/tap.d.ts(13,17): error TS7006: Parameter 'any' implicitly has an 'any' type.
typings-custom/tap.d.ts(14,3): error TS7010: 'setTimeout', which lacks return-type annotation, implicitly has an 'any' return type.
typings-custom/tap.d.ts(15,3): error TS7010: 'endAll', which lacks return-type annotation, implicitly has an 'any' return type.
typings-custom/tap.d.ts(16,3): error TS7010: 'threw', which lacks return-type annotation, implicitly has an 'any' return type.
typings-custom/tap.d.ts(17,3): error TS7010: 'pragma', which lacks return-type annotation, implicitly has an 'any' return type.
typings-custom/tap.d.ts(18,3): error TS7010: 'plan', which lacks return-type annotation, implicitly has an 'any' return type.
typings-custom/tap.d.ts(21,3): error TS7010: 'current', which lacks return-type annotation, implicitly has an 'any' return type.
typings-custom/tap.d.ts(24,3): error TS7010: 'done', which lacks return-type annotation, implicitly has an 'any' return type.
typings-custom/tap.d.ts(25,3): error TS7010: 'passing', which lacks return-type annotation, implicitly has an 'any' return type.
typings-custom/tap.d.ts(26,3): error TS7010: 'pass', which lacks return-type annotation, implicitly has an 'any' return type.
typings-custom/tap.d.ts(27,3): error TS7010: 'fail', which lacks return-type annotation, implicitly has an 'any' return type.
typings-custom/tap.d.ts(28,3): error TS7010: 'addAssert', which lacks return-type annotation, implicitly has an 'any' return type.
typings-custom/tap.d.ts(28,48): error TS7019: Rest parameter 'args' implicitly has an 'any[]' type.
typings-custom/tap.d.ts(29,3): error TS7010: 'comment', which lacks return-type annotation, implicitly has an 'any' return type.
typings-custom/tap.d.ts(29,28): error TS7019: Rest parameter 'args' implicitly has an 'any[]' type.
typings-custom/tap.d.ts(30,3): error TS7010: 'bailout', which lacks return-type annotation, implicitly has an 'any' return type.
typings-custom/tap.d.ts(31,3): error TS7010: 'beforeEach', which lacks return-type annotation, implicitly has an 'any' return type.
typings-custom/tap.d.ts(32,3): error TS7010: 'afterEach', which lacks return-type annotation, implicitly has an 'any' return type.
typings-custom/tap.d.ts(168,12): error TS7006: Parameter 'any' implicitly has an 'any' type.
typings-custom/tap.d.ts(171,12): error TS7006: Parameter 'any' implicitly has an 'any' type.
typings-custom/tap.d.ts(183,35): error TS7006: Parameter 'any' implicitly has an 'any' type.
typings-custom/tap.d.ts(194,29): error TS7006: Parameter 'any' implicitly has an 'any' type.
typings-custom/tap.d.ts(195,35): error TS7006: Parameter 'any' implicitly has an 'any' type.

https://github.com/dlmanning/node-tap/pull/2

@dlmanning @MelleB This needs tests before I can land it.  Thanks.

@isaacs @MelleB : I'll take care of it when I can find a bit of free time (hah), otherwise I definitely encourage anyone else who really wants this to take a swing.

Great stuff, I'm trying this right now. It seems to be missing support for t.end() though.

It seems that t.jobs is also don't working (neither if I add it to typings). It just throws
Cannot assign to 'jobs' because it is a constant or a read-only property. (2540)

What is the status of this? Types for tap are highly anticipated :D

@isaacs Any update on types for tap? :D

@philkunz If there are updates, they'll likely show up in this thread.
I'm waiting on a PR with tests that pass.
You might be able to get some assistance from the DefinitelyTyped folks.  Post a request here, maybe? https://github.com/DefinitelyTyped/DefinitelyTyped/labels/Definition%3ARequest

@isaacs but tests are passing

@goodmind Yeah, I need a test that fails without this file, and then passes with it, so that I don't accidentally break the typings in the future.

I see. That would require writing the tests themselves in typescript and transpiling it for type checking before the test. So if you break something the test's transpilation would fail or the test during runtime.
Another though => Since TypeScript picks up speed and Angular, RxJS and soon Polymer will use it: How about using TypeScript for tap itself?  It makes sure typings are always up to speed (since autogenerated by typescript) And any valid JS is valid TypeScript, so there wouldn't be much refactoring required for making the switch.

@philkunz you don't need to rewrite tests to TypeScript. You just need one test in TypeScript for typings

@goodmind Well, you need to test every function that has typings in place? Since I suspect you don't test a lot twice, you should have all tests in TypeScript, don't you? Anyway that basically just is changing the tests extension  from .js to .ts ...

I'm not interested in rewriting node-tap or all of tap's tests in typescript.  (It's a lovely language, but I would rather keep tap in Plain Old JavaScript.  Call me a stick in the mud, it's fine.  I will be moving to node >=4 soon to use es classes and arrow functions, though.)
I just need a test file that loads tap, loads the typings, says "is this thing valid and are there obviously missing members/etc."  It doesn't need 100% coverage, it just needs to fail if the typings are actively broken.  (That probably will require generating a few test objects, of course.)  Otherwise, there's a very high chance that I or someone else will accidentally break the type definitions in the future, and I'd rather not have that on my conscience.  If it fails when I break it, I'll notice and fix it.
If someone else wants to take ownership for maintaining the types elsewhere (eg, in https://github.com/DefinitelyTyped/DefinitelyTyped) then I'm 100% ok with that.  But unless they follow this repo closely, there's a good chance we'll go out of sync over time, and that probably won't be great.

Might I suggest creating a simple test such as the one tape/index.d.ts has called tape/tape-tests.d.ts. I don't know how @isaacs refactors code but doing a replace-all (for example renaming an exported method) would replace both files and build. If only one file was changed, then it would not build and emit an error.

@isaacs I understand we must have a test for the new typing definition.
Could you accept the suggestion from @styfle?
It seems https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/types/tape/tape-tests.ts is a good way to make the typing definition clearly for maintain(and sync). However, if you only change the interface of javascript, it will not fail. it will only be able to check the typing when you put the new interface to this test file.

Starting with TypeScript 2.3 you can just point the compiler directly to JS files and have the compiler type check those. If you do so, you can just point the compiler directly to the existing test files. See https://github.com/Microsoft/TypeScript/wiki/Type-Checking-JavaScript-Files
The compiler invocation'd look like:
./node_modules/.bin/tsc --allowJs --checkJs --noImplicitAny --noEmit test/*.js

(the --noEmit means it'll just type check the files rather than compiling them and generating some output somewhere).
You'd also have to add some type annotations (in the form of comments) to the test files though, but if the type definitions are correct that'd mean just adding a type to relative requires. TypeScript can infer those require types iff there are specific type definitions for that particular module, but type definitions are usually only added to the entrypoint of a package.
Type inference should take care of the rest (unless meta-programming techniques are used through the tests), and removing implicit any types will make it fail if inference can't work (which usually means the types are wrong). e.g.:
/// <reference path="../tap.d.ts" />
/** @type { Test } */
var test = require('../lib/root.js').test

The other alternative is just adding a single test file that uses all of the API. With that tests would break if existing API changes, but not if new things are added to the API.

I will literally land the first PR that has typings and a test for them.  I've been saying this for a year now.  Send the PR and I'll land it.  I don't know how to make it any more clear that a patch is welcome here.
You there!  Be the tap-using typescript-writing hero this community needs!

These typings are wrong. Test  is not a class, it's a field of some type that resembles a class. Code with test: Test doesn't compile.

Test is as much of a class as JavaScript-circa-node-0.x has.  It's not using the class keyword, because that didn't exist, but it is a function with a prototype, and can be invoked using new Test.  It even inherits from a Base class :)
I do intend to drop support for node 0.x in the next major release, and refactor to use ES6 classes.  Will that make a difference for the type definitions?

(Note that t.test (lowercase) is not a class, it's a function that queues up a test run that may or may not involve the creation of a Test instance.)

@isaacs No, that wouldn't make any difference. It's only a problem with typings. As @NaridaL suggested on TS gitter, there must be an exported type, not a class. The minimal example of required changes is here.
@dlmanning

The type definitions work just fine in the current form but it is missing some stuff addressed here (https://github.com/dlmanning/node-tap/pull/1). What @isaacs is looking for with this PR is a test file like this:
tap-tests.ts
import * as tap from 'tap';
declare var fs; // not testing
declare var __dirname; // not testing

let mam = function (x: number) {
  if (x % 2 === 0) {
    return 'even'
  } else if (x % 2 === 1) {
    return 'odd'
  } else if (x > 100) {
    return 'big'
  } else if (x < 0) {
    return 'negative'
  }
}

tap.pass('this is fine');
tap.pass('this is fine', { skip: true, todo: 'true' });

tap.equal(mam(1), 'odd');
tap.equal(mam(2), 'even');
tap.equal(mam(200), 'big');
tap.equal(mam(-10), 'negative');

tap.test('some async stuff', function (childTest) {
  fs.readdir(__dirname, function (er, files) {
    if (er) {
      throw er // tap will handle this
    }
    childTest.match(files.join(','), /\basync\.js\b/)
    childTest.end()
  });
});

var t = new tap.Test();

t.equal(mam(1), 'odd');

I'm not familiar with this lib, but essentially all you need to do is add this file and go through the documentation and exercise each variation. If tsc compiles the test file without throwing an error then the tests have past. The lib is very well documented so it shouldn't be hard... but it will take time.

@kenhowardpdx Type definitions do not work just fine.

As discussed in #387, the requirement for me to accept typedefs in this module is that there is a test which fails whenever the typedef and the lib are out of sync.
That means that the tests cannot pass if the typedef:

defines a method that doesn't exist
defines return/arg/property types incorrectly
fails to define a public method/property
does not require rewriting the module or all tests in typescript

I am sure that it seems like I'm being overly picky about this, but I'd rather just not support typescript than be responsible for something that works incorrectly and is untested.  I'll break it, and I won't notice, and then I'll feel bad about it.  Better to just handle this with a typedef in a @DefinitelyTyped repo, so that users understand that they're not getting an authoritative reference from the module maintainer.

For anyone else reading this thread and thinking of trying to meet @isaacs’s criteria. It probably isn’t impossible (though I’m not 100% sure some theoretical edge case won’t mean it is), but the level of type reflection and inspection he’s describing would probably be more complex than actually rewriting node-tap in TypeScript. Static types are designed to be maintained in concert with the rest of the source. @isaacs doesn’t want to do that. Fair enough, this is his show. Anyone considering putting more work into the type definitions should probably do it elsewhere.
Though if anyone out there is determined enough to actually make a system for fulfilling his requirements, I hope they’ll publish that work as it’s own module. :D

@dlmanning I just don't want to have someone working in VSCode (or some other TypeScript-aware editor) being told by the system that they can call t.current() to get a Test instance, but actually, that throws TypeError: t.current is not a function.  Incorrect typedefs are worse than none at all, and I'm not interested in shipping code that I know I'll inadvertently break.
If that's not possible with the current state of the art in strongly-typed JavaScript, then ok.
Rewriting node-tap in typescript probably would achieve the goal, because the type definitions would be inferred from the source itself, rather than a standalone artifact that can get out of sync.

Though if anyone out there is determined enough to actually make a system for fulfilling his requirements, I hope they’ll publish that work as it’s own module. :D

Me too!  I'd gladly add type definitions to all of my modules if it were possible to test that they're in sync.

@isaacs yeah, I’m agreeing with you. If the maintainer isn’t into keeping up the type definitions or actually writing the project in TypeScript, it’s probably a bad idea to include them. The sort of tests you’ve described would require hacking into the TypeScript compiler just to get started. It’d be an interesting enough endeavor to definitely deserve its own project.

@isaacs As anyone can still download these typings and fix them appropriately to the current version, it's fine. Stuff with wrong intellisense in VSCode is plain creepy, and it made me think if I ever called non-existing methods in production code.
Please, consider making an article on this topic to gather more attention.

There is a library for runtime checks of type validity https://github.com/gcanti/io-ts. I'm excited to try it out and writing tests for tap types looks like a perfect candidate for that. If @isaacs is still willing to merge types when tests are landed then I'll try to make it work. For sure it can validate the shapes of public interfaces, but validating function argument and return types might be more challenging.

Just to reiterate: I'm fine with this as long as it's maintainable.  First and foremost, it must have a test that fails whenever the type definitions are incorrect, missing, or otherwise inadequate, and they must not be too hard to keep up to date.  I'm probably not going to look at them at all except when the test fails.  If that's too hard to do, just send it to DefinitelyTyped.

@isaacs There's now a way to generate TypeScript definitions from JS 🎉 Just add some JSDoc comments to the lib and that's all.
https://github.com/microsoft/TypeScript/pull/32372
Definitions will be always in sync. Does it address your concern?

I'll point this out again in case it's still useful.  It meets isaacs criteria without changes to the code: https://github.com/tapjs/node-tap/pull/381  It just needs to be rebased onto master.
I'm no longer using this, so I'll be unsubscribing, but if anyone wants to pick it up, I'm pretty sure it would solve this issue.

I'm fine with JSDoc comments.  Tests should fail if they're out of sync, though.

I'm fine with JSDoc comments. Tests should fail if they're out of sync, though.

Your test, in such a scenario, would then simply be running tsc --declarations --allowJs --checkJs, which would fully typecheck your codebase using the doc comments as the source of type information (and also generate the declaration files).

Sounds good.  Patch welcome :)


Type union narrowing upon index access

🔍 Search Terms
"type union narrowing on multiple properties", "type dependencies", "narrowing indexed", "narrowing argument"
✅ Viability Checklist

[X] This wouldn't be a breaking change in existing TypeScript/JavaScript code
[X] This wouldn't change the runtime behavior of existing JavaScript code
[X] This could be implemented without emitting different JS based on the types of the expressions
[X] This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, new syntax sugar for JS, etc.)
[X] This isn't a request to add a new utility type: https://github.com/microsoft/TypeScript/wiki/No-New-Utility-Types
[X] This feature would agree with the rest of our Design Goals: https://github.com/Microsoft/TypeScript/wiki/TypeScript-Design-Goals

⭐ Suggestion
Notice: It’s likely this request has been raised before and I wasn’t using the right search terms. Apologies in advance.
Using type unions and dynamic property access extensively, I have come across the following situation a few times already: There is a discriminating element in the type union that could be used to index a different type that references the corresponding union component. TypeScript could know whether the result from the property access and the union type are structurally related and allow the access. However, as it stands, it needs a little help in form of an explicit conditional (see example below).
📃 Motivating Example
https://www.typescriptlang.org/play?ts=5.3.2#code/JYOwLgpgTgZghgYwgAgPICMBWyDeAoZZOALmQGcwpQBzAbgOXVJAFcBbdaewsiMAQQAUJcpRoBKUgDcA9sAAm3cnwBCgpslYdok5LIX0AvnjABPAA4oACjLJlg6ADYR+CJHZlQyyALwMAPrjmUDLmpADkcOEANHpwjiwQpBRUINSxvGCQUBGZ-OHGhIE4waER6DFxCUma7JxQGXzZuaoF9HgwLCAIYMAyIMpgViHmgjJYpBiYsWCkNnYOzq7uZJ5k4rgMwDCCYAB0pea+Pj7IkeEb+ISE45gA2vuHALq+yPtS8YlKhsgQjryba7IW4PA4jF6nd6fCDfPDGTrdXr9QbLCAeKBjCZoLAzOa2exOFxuNGrLyXLY7R4jY6nc7koEg-aZbJPXZ7D7VcTfX7-FBXa6MvbM6CsqGc2HGPBAA
interface Obj {
  a: string;
  b: number;
  setA(a: string): void;
  setB(b: number): void;
}
type PossibleAccessors =
  | {prop: 'a', value: string, setter: 'setA'}
  | {prop: 'b', value: number, setter: 'setB'};

function setProp(obj: Obj, t: PossibleAccessors) {
  if(t.prop === 'a') {
    obj[t.prop] = t.value;
  } else {
    obj[t.prop] = t.value;
  }
}
function setAccessor(obj: Obj, t: PossibleAccessors) {
  if(t.prop === 'a') {
    obj[t.setter](t.value);
  } else {
    obj[t.setter](t.value);
  }
}

In this example, the if…else constructs in the functions setProp and setAccessor are entirely superfluous but currently required for successful compilation.
As it stands, with every component added to the PossibleAccessors union, a new control flow branch has to be added to get the code to compile without type casting.
💻 Use Cases
Currently, I resort to type casting in these situations and I enforce conformability between the unions and the corresponding properties using an intricate set of conditional types. This is brittle as there is no nothing informing me when I have set these types up incorrectly. Even when it works, it makes the compile error happen at a location very different from where the run-time error would be.
It would be a tremendous help if TypeScript could narrow the property access correctly without the user having to insert superfluous constructs.
I.e., the following code should just compile™: https://www.typescriptlang.org/play?noUncheckedIndexedAccess=true&allowUnreachableCode=true&allowUnusedLabels=true&exactOptionalPropertyTypes=true&noFallthroughCasesInSwitch=true&noImplicitOverride=true&noPropertyAccessFromIndexSignature=true&ts=5.3.2#code/JYOwLgpgTgZghgYwgAgPICMBWyDeAoZZOALmQGcwpQBzAbgOXVJAFcBbdaewsiMAQQAUJcpRoBKUgDcA9sAAm3cnwBCgpslYdok5LIVLqfIbopUQdBkbBrdWzlHoBfPGACeABxQAFGWTLA6AA2EPwISP4yUGTIALwMAD64HlAyHqQA5HAZADR6cEEsEKRmNHm8YJBQmRX8ucjWVZnWdS6ESTgpaZno9VIFRczsDuV8TcgZFSr1jdDNqhlO9HgwLCAIYMAyIMpg3qkegjJYpBiYeWCkvv6BIWERZFFk4rgMx5gA2mAAdF0eALpxZA-fqFCDOFZrDZbHa1cIQSJQI4nNBYC5XPwBYKheGI56vQjvL7fCpVf6CEEDCDiCFAA

This is already possible, at least for the property side of it:
interface Obj {
  a: string;
  b: number;
  setA(a: string): void;
  setB(b: number): void;
}

type ObjAccessor<K extends keyof Obj> = { prop: K, value: Obj[K] };
;
type PossibleAccessors = ObjAccessor<keyof Obj>;

function setProp<P extends keyof Obj>(obj: Obj, t: ObjAccessor<P>) {
  obj[t.prop] = t.value;
}

declare let obj: Obj;
// OK
setProp(obj, { prop: "a", value: "hello" });
// Error
setProp(obj, { prop: "a", value: 32});

I don't think the "setter" implementation is possible to make check, but you can still represent it in the type system
interface Obj {
  a: string;
  b: number;
  setA(a: string): void;
  setB(b: number): void;
}

type FilterBy<K extends keyof Obj, V> = K extends unknown ? Obj[K] extends (arg: V) => void ? K : never : never;
type ValidSetters<V> = FilterBy<keyof Obj, V>;

type ObjAccessor<K extends keyof Obj> = { prop: K, value: Obj[K], setter: ValidSetters<Obj[K]> };

type PossibleAccessors = ObjAccessor<keyof Obj>;

declare let obj: Obj;
// OK
setProp(obj, { prop: "a", value: "hello", setter: "setA" });
// Error
setProp(obj, { prop: "a", value: "hello", setter: "setB" });

I can't think of a way to analyze your given example that doesn't involve combinatorially exploding the check phase into branches based on every possible constituent of the union, which is definitely not a scalable solution.

This looks like another vote for https://github.com/microsoft/TypeScript/issues/30581


Update to modifications in hpp-constraints

constraints::implicit::RelativePose has been removed. Require https://github.com/humanoid-path-planner/hpp-constraints/pull/120.

Thanks.


Export only Steam Guard Code

Make it possible to transfer only the Steam Guard receipt code, without the ability to accept or reject trades and remove the Steam Guard. Make steam guard export via file and QR code

Do not export the account itself, but only the Guard Code


Why not allowing Symfony 3.4?

AFAIK, Symfony 3.4 is the same as Symfony 4.0, except the fact Symfony 4.0 does not have the deprecated stuff.
Furthermore, it will allows to support at least one LTS version of Symfony, that is highly recommended.

Noting that this makes it impossible to use 2.x with Drupal 8, which currently relies on Symfony 3.x :(

Thanks for reaching out.
I got various feedback on this and I think we can make that happen.
It needs to be tested though: https://github.com/Symplify/Symplify/commit/7db9ec225d4d50df5590db81504461e2713ebe36

Closing for incompatibility described in https://github.com/cpliakas/git-wrapper/issues/145#issuecomment-357427295
If anyone need this, add travis build for Symfony 3.4 + compabible layer for the issue in comment


Empty url supplied.

File "testing.py", line 19, in
m.saveWebPage(url, "submission/report.html")
File "C:\Users\anves\Desktop\moss.py-master\moss.py-master\mosspy\moss.py", line 143, in saveWebPage
raise Exception("Empty url supplied")
Exception: Empty url supplied

Hi, Have you entered correct MOSS's userid?


[ownership] Move 3 instructions that are not valid in ossa into the S…

…HOULD_NEVER_VISIT_INST

@swift-ci smoke test and merge


HystrixMetricsStreamServlet infinite loop in Websphere 8

I am new to Hystrix and only somewhat less new to Websphere 8.  So prepare for newbie stupidity.
When I run HystrixMetricsStreamServlet locally in Tomcat 7, things work smoothly.  However when I run it either in WAS Liberty 8.5 or WAS 8.0.. the call to response.flushBuffer() never throws an IOException, even if the browser/client which made the request to the servlet disconnects.  As such, the thread which catches the request to the HystrixMetricsStreamServlet is essentially consumed forever until the app is bounced.  I don't know if this is because I'm missing a relevant setting within WAS/Liberty or if this is a known WAS/Liberty issue, or something else.
I'm in the process of learning Hystrix and so at this point I'm not yet to the point of using Turbine.  I'm only either connecting directly to the stream from my browser or using hystrix-dashboard-1.3.9.war to display a dashboard based on the stream.  I don't think the introduction of Turbine will resolve the issue, but if it does that would be good to know.
It seems unlikely that I am the first person to run into this, but google didn't provide any answers, and neither did my StackOverflow question.  So this seemed the next reasonable place to look for answers.

any luck on this?


google drive v3.d.ts is broken

Hi dear Google!
Your google drive node client codez do not work...
Your test do not work, and if they do - they suck.
Just to get things clear - this "problem" affects only TS projects.
Happy weakly-typed JS people just missed that pleasure.
Boy I hope you can follow this from these clues:
get(params?: Params$Resource$Files$Get, options?: MethodOptions): AxiosPromise<any>;//Schema$File>;

and
    interface Params$Resource$Files$Get {
        /**
         * Auth client or API Key for the request
         */
        auth?: string | OAuth2Client | JWT | Compute | UserRefreshClient;
        /**
         * Whether the user is acknowledging the risk of downloading known malware
         * or other abusive files. This is only applicable when alt=media.
         */
        acknowledgeAbuse?: boolean;
        /**
         * The ID of the file.
         */
        fileId?: string;
        /**
         * Whether the requesting application supports Team Drives.
         */
        supportsTeamDrives?: boolean;

        //Huh? Missing? Still works though...
        alt?: string;
    }

That's what I had to do to get at very least an example code running...
Some technical details:
File:
./apis/drive/v3.d.ts

Package version:
"googleapis": "^30.0.0"

Boy I hope you'll get this super riddle resolved some day, so that we could use your modules in CI.
Have a nice day, thanks in advance!

Just to be completely clear - that's the example code adaptation that does not compile basically:
            const drive = google.drive({version: 'v3', auth});
            let dest = {};
            let chunks = [];
            const res = await drive.files.get(
                {
                    fileId: fileDescriptor.id,
                    alt: 'media'
                },
                {
                    responseType: 'stream'
                }
            );
            res.data
            .on('data', d => {
                chunks.push(d);
            })
            .on('end', () => {
                resolve(Buffer.concat(chunks));
            })
            .on('error', err => {
                reject(err);
            });

Greetings!  Fairly certain we fixed this in 31.0.2.  Please take a look and let me know if you're running into any issues!


NPE viewing dashboard containing announcements merged from site user isn't a member of

@austin48  this needs a jira issue


Convert HQL to Text Blocks

Looks good. Should we agree on a standard SQL query notation in terms of newlines? Something for the CS meeting.

Sounds good. I added it to the agenda. Perhaps we could use the pg_format tool.


Mysql Create Not Working

cargo 1.36.0-nightly
diesel = { version = "1.4.1", features = ["mysql"] }
Compiling mystore v0.1.0 (/home/desktop-64/Documents/Ram/rust/practical)
error[E0425]: cannot find value conn in this scope
--> src/models/product.rs:52:54
|
52 |     products::table.order(products::id.desc()).first(conn).unwrap()
|                                                      ^^^^ not found in this scope
error[E0599]: no method named order found for type schema::products::table in the current scope
--> src/models/product.rs:52:21
|
52 |       products::table.order(products::id.desc()).first(conn).unwrap()
|                       ^^^^^
|
::: src/schema.rs:1:1
|
1  | / table! {
2  | |     products (id) {
3  | |         id -> Int4,
4  | |         name -> Varchar,
...  |
7  | |     }
8  | | }
| |_- method order not found for this
|
= help: items from traits can only be used if the trait is in scope
= note: the following traits are implemented but not in scope, perhaps add a use for one of them:
candidate #1: use crate::diesel::query_dsl::methods::OrderDsl;
candidate #2: use crate::diesel::QueryDsl;
= note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
error[E0599]: no method named desc found for type schema::products::columns::id in the current scope
--> src/models/product.rs:52:40
|
52 |       products::table.order(products::id.desc()).first(conn).unwrap()
|                                          ^^^^
|
::: src/schema.rs:1:1
|
1  | / table! {
2  | |     products (id) {
3  | |         id -> Int4,
4  | |         name -> Varchar,
...  |
7  | |     }
8  | | }
| |_- method desc not found for this
|
= help: items from traits can only be used if the trait is in scope
= note: the following trait is implemented but not in scope, perhaps add a use for it:
use crate::diesel::ExpressionMethods;
= note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
error: aborting due to 3 previous errors

The note sections tell you what's wrong and how to fix it (you're missing use diesel::prelude::*;)


Refactors switch statement in PeekInspectorViewController

Base Branch
Make sure you're currently pointing to the next release base branch. For example:
branch: feature/5.1.0
If you're unsure, check the latest tag, it'll be a semantic version higher than that.
SwiftLint
Ensure SwiftLint hasn't reported any issues. Code styles must be adhered to.
README
Does the README need updating? Ensure anything relevant is updated there as well.

Oh thanks for this! I've been meaning to come back and do exactly this – I wasn't originally aware of this but came across this kind of pattern matching about a month ago and had been meaning to refactor.


xml files for resolve and premiere are the same

I installed this via pip today and ran it on a sample screen recording.
I exported xml files for both premiere and resolve.
I noticed that both files are the same.
Is this by design? Are the files supposed to be different?

Yes, this is intentional. Right now, XML files are always exactly the same on MacOS since both premiere and resolve understand Final Cut Pro XML format. On windows, since the file naming is different, premiere and resolve use a different format of getting the pathurl for the file, but other than that, it's also the same.
The reason there are two seperate commands is that if in the future, there is some change drastic change for one of the editors, auto-editor could change how one editor is exported while the other exporting remains the same.


DocsArchive-<IP_ADDRESS>Auto archive content

Please don't merge this PR until target archive repo PR https://github.com/OPS-E2E-PPE/docs-archive-test-target_d9efa620-f92d-4338-b837-a82dfae48e76/pull/1 is merged into live branch.
Auto archive content to https://github.com/opstest2/docs-archive-test-target_d9efa620-f92d-4338-b837-a82dfae48e76.git

Docs Build status updates of commit 46df4a3:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.

File
Status
Preview URL
Details

:x:Error

Details

[Error-RuningBuildFailed] Some unexpected errors happened when running build, please open a ticket in https://aka.ms/SiteHelp and include the error report for our team to troubleshoot

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


Increase wait times and remove sleep statements

Can you add some reasoning to the "Remove 503 panic" commit message.

This might not be necessary either. I incorrectly thought the CLI could retry if it received a 503. It can't.


Implement @OnRefresh for SwipeRefreshLayout

Is possible to create a custom annotation for custom listeners? I'm try but doesn't work
`@Target(ElementType.METHOD)
@Retention(RetentionPolicy.CLASS)
@ListenerClass(
targetType = "android.support.v4.widget.SwipeRefreshLayout",
setter = "setOnRefreshListener",
type = "android.support.v4.widget.SwipeRefreshLayout.OnRefreshListener",
method = @ListenerMethod(
name = "onRefresh"
)
)
public @interface OnRefresh {
@IdRes int[] value() default { View.NO_ID };

}
`

Butterknife extensions is not there yet. You can follow #573


add query params to request

Coverage remained the same at 97.927% when pulling eaf4cf398441ae3ef71d675aac9e5bd91877f396 on alt-j:patch-1 into 03444d21961a7a44cdc2eae11ee3630f6969023d on form-data:master.

I have a case, when I need to send query parameters with files,
and pathname doesn't contain it (https://nodejs.org/docs/latest/api/url.html#url_urlobject_path).

Please see #98. Thank you.

@alt-j Do you mind to add tests? Otherwise, I think we can go ahead with the major version. Thank you.


Allow protected/private index signatures

Search Terms
TS1071 private protected index number string signature
Suggestion
I can't dope out why it's not supported
Use Cases

Examples
class List {
    private [index :number] :Task
    public * [Symbol.iterator] () :Generator<Task> {}
}

Checklist
My suggestion meets these guidelines:

[x] This wouldn't be a breaking change in existing TypeScript/JavaScript code
[x] This wouldn't change the runtime behavior of existing JavaScript code
[x] This could be implemented without emitting different JS based on the types of the expressions
[x] This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, etc.)
[x] This feature would agree with the rest of TypeScript's Design Goals.

I would love to see this made possible, it feels wrong that everything else (even constructor) in a class may be private/protected/public but not index signatures? An index signature is really nothing more than a general statement for several similar properties, why are protected/private fields not allowed to be generalized this way?
Hopefully this issue can be revived.


Added logic to initialize values for all the unhidden attributes

Fix https://github.com/wso2/api-manager/issues/2745

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

lets check the sonar cloud failure before merging.


[SPARK-32887][DOC] Correct the typo for SHOW TABLE

What changes were proposed in this pull request?
Correct the typo in Show Table document
Why are the changes needed?
Current Document of Show Table returns in parse error, so it is misleading to users
Does this PR introduce any user-facing change?
Yes, the document of show table is corrected now
How was this patch tested?
NA

Can one of the admins verify this patch?

Can one of the admins verify this patch?

cc @jiangxb1987 @gatorsmile @dongjoon-hyun

Jenkins test this please

Test build #128714 has started for PR 29758 at commit 76be6ab.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/33338/
Test PASSed.

Test build #128714 has finished for PR 29758 at commit 76be6ab.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/128714/
Test PASSed.

I trust this is correct, but I am not super familiar with the syntax - can you point me at something that shows this must be correct? if so I'll merge, or others that know more can.

I trust this is correct, but I am not super familiar with the syntax - can you point me at something that shows this must be correct? if so I'll merge, or others that know more can.

@srowen sql/core/src/test/resources/sql-tests/inputs/show-tables.sql we have covered the scenario using the correct syntax.
I tried in my local with the '' and it gave me parse error.

@Udbhav30 should it be (`grade`=1) ? I'm seeing other similar PARTITION statements in tests, etc, that do use this, but, of course are not quoting the value, just col name. It is probably optional in this case as grade is not a reserved word?

@Udbhav30 should it be (`grade`=1) ? I'm seeing other similar PARTITION statements in tests, etc, that do use this, but, of course are not quoting the value, just col name. It is probably optional in this case as grade is not a reserved word?

Yes @srowen you are correct. It can be this  (`grade`=1) just the column name as you mentioned. And moreover if the value is a String it should be either (`grade`='abc')  or (grade='abc')

You want me to update the MR with the `` just on column name ?

@Udbhav30 and @srowen . It's identifier. We don't need quote.
partitionSpec
    : PARTITION '(' partitionVal (',' partitionVal)* ')'
    ;

partitionVal
    : identifier (EQ constant)?

Like we did INSERT INTO employee PARTITION (grade = 2) VALUES ('suj'), we can use it (grade = 2) simply.

@Udbhav30 . Which environment did you test? I'm wondering if the example was working in your environment with backquote.

@Udbhav30 . Which environment did you test? I'm wondering if the example was working in your environment with backquote. I mean not your contribution on partition values, but the original table names.
SHOW TABLE EXTENDED  IN default LIKE `empl*` PARTITION (grade=1);

Yes you are correct i didn't notice, I was also not using backquote on tablename

@dongjoon-hyun Thanks for the corrections. I have updated the MR


Add forwarding shortcut to Gateway Listener

What type of PR is this?
/kind feature
/kind api-change
What this PR does / why we need it:
Adds a backendRef to a Gateway Listener to allow a direct forwarding shortcut to a serviceName/port.
Which issue(s) this PR fixes:
Fixes #529
Does this PR introduce a user-facing change?:
Add forwarding shortcut to Gateway Listener.

Signed-off-by: Steve Sloka<EMAIL_ADDRESS>

I have a couple questions on this:

What should the support on this be? I left as "Custom".
I only left a serviceName/ port in the spec, wasn't sure if a LocalObjectReference was desired.
What should the status be if the service is invalid? I added DegradedListener since DegradedRoutes didn't make sense.

/ok-to-test

Follow up from community call. I think there was general support for getting this into v0.3.0.
There were some concerns that this might grant Gateway admins more access than they currently have. Most notably, this would mean that any Gateway admin has the ability to route traffic to a Service, something that previously required creating an xRoute resource. Although that would be problematic if we were crossing namespace boundaries, it seems fair to say that Gateway admins are highly trusted within the namespace(s) they can manage Gateways for. Since Gateway admins can already arbitrarily target Routes in the same namespace, this feels like a minimal change in the effective capabilities of Gateway admins.
Given the above, I'd propose moving forward with this PR and renaming the field to routeTo, initially supporting serviceName and port fields.
/cc @bowei @hbagdi @danehans

Given the above, I'd propose moving forward with this PR and renaming the field to routeTo, initially supporting serviceName and port fields.

+1 to this. Let's update and get this merged in!

What support type so this get? I added it as "Extended" thinking that it could be adopted by folks but not required.
// @robscott @hbagdi @mark-church @howardjohn

Good discussion around this issue in Slack. It looks like there's still plenty of hesitation around an approach like this, so I'm going to remove this from the milestone and lower the priority. We may also want to close this PR out too, but I'll leave that final decision for @stevesloka.

Freezing this PR pending resolving the discussion.


feat(3127762574): Inject env vars dynamically for Docker container

Description of the Changes
Use dynamic images - build once for a version - regardless of the env.
Inject the env var dynamically on container start.
Solves #3127762574

Checklist

[X] Changes have been done against dev branch, and PR does not conflict.
[ ] Manually tests of the main Application flows are done and passed.
[ ] New unit / functional tests have been added (whenever applicable).
[X] Automation tests are passing in local environment.
[ ] Docs have been updated (whenever relevant).
[X] PR title is follow the Conventional Commits convention: <type>[optional scope]: <description>, e.g: fix: prevent racing of requests

This change is

@danielgluskin-starkware in general LGTM. One comment before we can merge: create scripts dir and move .sh files under it.

updated

:tada: This PR is included in version 1.9.0-dev.19 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:

:tada: This PR is included in version 1.9.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:

:tada: This PR is included in version 1.9.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Fixed typo

This cheeky little devil stopped comments working at my install at burntheregister.com. Thanks for the work, loving Libcrowds resources.

Coverage remained the same at 93.617% when pulling 949165829bb796278e295d99d903a0a0691fb995 on jacksongs:typo-fix into 6f0d8dc02623b882dfc3ce34dc8f75face9c76c1 on alexandermendes:master.

Ah thanks! I'll merge in a bit.


[5.1][Test] Add availability to the GenericMangled test in objc_getClass.swift

Cherry-pick https://github.com/apple/swift/pull/24950 to 5.1.
This is a new test in Swift 5.1 that is not expected to pass when running
with the Swift 5.0 runtime library.
rdar://problem/50175915

@swift-ci please test

Build failed
Swift Test Linux Platform
Git Sha - 592d33220f9866e663b662c1fc3968262411af5d

@swift-ci please test linux platform

Build failed
Swift Test Linux Platform
Git Sha - 592d33220f9866e663b662c1fc3968262411af5d

@swift-ci please test

Build failed
Swift Test OS X Platform
Git Sha - 592d33220f9866e663b662c1fc3968262411af5d

Build failed
Swift Test Linux Platform
Git Sha - 592d33220f9866e663b662c1fc3968262411af5d


Candidate 1: Disable preemptible for some tasks.

Purpose
Please explain the purpose of this PR and include links to any GitHub issues that it fixes:

https://broadinstitute.atlassian.net/jira/software/projects/GL/boards/528?selectedIssue=GL-166
Just looking at this run: https://job-manager.caas-prod.broadinstitute.org/jobs/b3f61b06-635c-466e-997c-2a77a313c6d1?q=caas-collection-name%3Dlira-test%26bundle-uuid%3D00ba4f21-7a70-4517-8bdd-a9ac9aa4c444 we can tell that it's not practical to use the same preemptible settings for all of the tasks in Optimus.  We need finer control over the settings.

Changes
Please list out what major changes were made in this PR to address the issue:

Add another no_preemptible switch to the Optimus pipeline, so we can disable preemptible on specific steps. Downside: not atomic enough. Especially when you run the Optimus within an Adapter workflow, there's no way you can change the pre-defined settings except modifying the pipeline itself.

Review Instructions
Please provide instructions about how should a reviewer test/verify the changes in this PR:

This PR is mutually exclusive to the https://github.com/HumanCellAtlas/skylab/pull/174, only one of them can be merged🥇 !

PR Checklist
Please ensure the following when opening a PR:

[ ] This PR added or updated tests.
[ ] This PR updated docstrings or documentation.
[ ] Let Jodi (jodihir) know when there is user-facing documentation updates needed!
[ ] This PR applied the Mint style guide for WDL.
[ ] This PR has no WDL linting errors reported by miniwdl
[ ] This PR considered generalizability beyond our own use case.

Follow-up Discussions
Please append follow-up discussions and issues during the review process below:

No follow-up discussions.

It seems a bit odd to set a no_preemptible variable that is passed to these tasks--unless you're planning to change no_preemptible, in which case the name choice is inaccurate. I have 2 suggestions, if you'd like to consider them:

Don't pass any preemptible value within Optimus, and set the default preemptible to 0 in the tasks WDLs themselves. This will have them default to 0 unless specifically passed as an input.
Pass a Bool force_non_preemptible so if it is set to false, the preemptible value is used, and if set to true, preemptible for those tasks is set to 0.

The failed test has nothing to do with this PR, I'm going to merge it!


Customized Tags & Followings Revert to Default

The BUGs

All user defined tags in "Customize Tags" revert to the default tags upon restart of the desktop app.
All the user selected accounts to Follow revert to default (not following anyone) upon restart of the desktop app.

Customize Tags (default list)
art, automotive, blockchain, comedy, economics, education, gaming, music, news, science, sports, technology
Customize Tags (user's list)
art, automotive, blockchain, diy, education, fiction, gardening, music, news, poetry, science, technology
Reproduce Bugs

Login, vomit on login screen before clicking "I feel woozy" button, choose Customize, delete unwanted tags, add new tags
Choose Home, sort videos by new tags, find user to follow, click follow heart, check out other users
Watch some more videos, read some @gutenberg, and/or follow more whatever
Close the LBRY app
Login, vomit on the login screen before clicking "I feel woozy" button, choose Home, tada! the tags are reverted again.

Expected behavior

Customized tags to remain customized, not to revert to default
Followed users to remain followed, not to revert to default

System Configuration
LBRY desktop: 0.37.1
LBRY daemon: 0.43.3
LBRY Install ID: 8VabQQt1F54RuMLqr3M1eG41y7k3LDGidyhkVgT8wd6hrjKsciDy5g9nsY2gYxKd7M
OS: Windows 8.1

Thanks for opening the issue. Are you signed into the app with an email address? If not, there's a bug already filed for this case under https://github.com/lbryio/lbry-desktop/issues/3076
And sorry about the wooziness - you should only have to disable that once...let me know if it turns back on.

I am signed in with an email address. The wooziness button setting is not sticking, I do have to turn it off every time I launch LBRY. No worries, @tzarebczan! I actually love the spinny thing, I just can't do it any more. Too many head traumas, I guess.
I don't know what if any of this is related, but it may help troubleshooting...

I created the LBRY local account prior to syncing YouTube,
I did name the channels the same thing, don't ask, (I won't judge, if you don't.)
The email address I use for YouTube is different than the email I used to set up LBRY.
I received a syncing error on the YouTube status page:

The following error occurred: the channel properties cannot be edited anymore For support please send an email to<EMAIL_ADDRESS>

I followed the Clean Up instructions, went into Full History, found the first instance of the channel (the not sync'd to YouTube instance), there was no Trash option. I cannot delete either channel.
Both channels still exist. Even so, I did follow the further suggestion to transfer everything to the YouTube sync'd version of the channel.
Various Settings are also not sticking to user selection, but revert back to default on restart: Mature Content, Theme (Dark), Enable Claim Support

Let me know if there's any other info I can supply. Thanks for the awesome work you all are doing!

Thanks for all the info and sorry to hear about the trouble.
For #4, we are aware of some instances where this happens...we can merge them for you manually.  Were you trying to change the channel name there? Please email us at<EMAIL_ADDRESS>with the 2 emails that need to be merged.
For #5, the channel may show up as Update if there were any updates to it locally.  Let me know if you find it that way. I'll make sure that's mentioned in the FAQ.
As far as your settings not sticking, I'm not sure why that is and can't replicate locally. You are signed into an email in the app right? These settings would not stick between installs, but should stick between restarts. What operating system are you on?

Rock on. I'll send an email with the merge request.
Okay, here's the sysinfo from the log & an error my system is throwing:

"processor": "Intel64 Family 6 Model 42 Stepping 7, GenuineIntel",
"python_version": "3.7.4",
"platform": "Windows-8.1-6.3.9600-SP0",
"os_release": "8.1",
"os_system": "Windows",
"lbrynet_version": "0.43.3",
"torba_version": "0.5.7",

2019-10-30 00:13:45,234 ERROR    lbry.extras.daemon.Components:573: failed to setup upnp
2019-10-30 00:14:23,752 WARNING  lbry.extras.daemon.Components:342: UPnP component failed to get external ip
Would this error cause the sync failures?

Nope, would not. That happens normally on some routers/networks.
Closing this for now.


[GH-170] Allow to overwrite pre join page inside Mattermost

Summary
Added radio buttons in system console settings to disable/enable the pre-join page in Jitsi meet when opened in minimized view.

Added field in plugin.json file to add "Show pre-join page" radio buttons.
OverWrite the Jitsi server config to disable/enable pre-join page.

configOverwrite: {
    // Disable the pre-join page
    prejoinPageEnabled: this.props.meetingEmbedded && this.props.showPrejoinPage
}

When the pre-join page is enabled in minimized view, vertical height of the window is increased to avoid croping of the user's profile image.
Fixed govet fieldalignment errors.

Screenshots

When pre-join page is disabled

When pre-join page is enabled

Ticket
Fixes #170

@mickmister Gentle reminder for review

@mickmister Gentle reminder for review

@mickmister Gentle reminder for review

@mickmister Gentle reminder for re-review

@raghavaggarwal2308 It doesn't look like there have been any changes since I approved the PR. What would you like me to review?

@mickmister I meant the review of the answers to the questions you asked when you last reviewed.

@raghavaggarwal2308 I don't see answers to the questions either though

@mickmister Sorry about that, you should see them now

Ok looks good. For future reference, mentioning me in the comments is good enough if you want to continue discussion on those individual threads. No need to ping with re-review requests if I have "approved" the PR. Hopefully that makes sense.
If the PR is only waiting on QA review, the person you want to reach out to is @DHaussermann

@raghavaggarwal2308 Sorry if I seem aggressive in my previous comment. It's just a little frustrating to see this sit here like this. I'm sure it's more frustrating for you as well, sorry about this.

@mickmister No issues, I understand :)

/update-branch

@DHaussermann Gentle reminder for review

@DHaussermann Gentle reminder for review

@DHaussermann Gentle reminder for review

@DHaussermann Gentle reminder for review

@DHaussermann Gentle reminder for review

@DHaussermann Gentle reminder for review

@DHaussermann Gentle reminder for review

@DHaussermann Gentle reminder for review


Handle frame-generation with Java 7- classes with JSR/RET

Describe the bug

You can edit a class with JSR/RET but unless you disable verify in the config assembling/exporting these modified classes will complain.

Exception
java.lang.IllegalArgumentException: JSR/RET are not supported with computeFrames option
	at org.objectweb.asm.Frame.execute(Frame.java:1017)
	at org.objectweb.asm.MethodWriter.visitJumpInsn(MethodWriter.java:1145)
	at org.objectweb.asm.tree.JumpInsnNode.accept(JumpInsnNode.java:79)
	at org.objectweb.asm.tree.InsnList.accept(InsnList.java:144)
	at org.objectweb.asm.tree.MethodNode.accept(MethodNode.java:751)
	at org.objectweb.asm.tree.MethodNode.accept(MethodNode.java:649)
	at org.objectweb.asm.tree.ClassNode.accept(ClassNode.java:452)
	at me.coley.recaf.ui.controls.text.BytecodeEditorPane.assemble(BytecodeEditorPane.java:230)
	at me.coley.recaf.ui.controls.view.BytecodeViewport.save(BytecodeViewport.java:85)

Potential Fix
When loading older classes, pass them through JSRInlinerAdapter or disable frame generation.

If somebody can find a class/jar that demonstrates this behavior I can toss up a fix. I don't have one laying around at the moment.

afaik frames and jsr/ret are mutually exclusive, and jsr/ret was already deprecated by the time frames were introduced

JBCO (from Soot) will generate tons of these JSRs. As will other obfuscators according to StackOverflow.

but JBCO 'cheats' and doesn't create actual subroutines (adds not rets), but pops the return address.

If it does that, then its a plain GOTO instruction. Nothing magical.


Instructions on how to add your SSH key to a custom user

Relates to #120

[ ] Add your key to the list
[ ] Remove ability for user to login via SSH with password (key only)

Covered in #120


Add file type icon for Systemd .service files

Systemd is a popular Linux system management process system, it's a bit debatable if it technically has an offical icon. This icon was inspired by the image on the offical website: https://freedesktop.org/wiki/Software/systemd/.
Changes proposed:

[x] Add
[ ] Delete
[ ] Fix
[ ] Prepare

@KingDarBoja Support via https://github.com/bearmini/vscode-systemd-unit-file/blob/master/package.json#L20

@JimiC Good find, I didn't notice that. I'll update the logo for this PR :)

@JimiC Good find, I didn't notice that. Should we update the logo in this MR?

Don't worry, I will do that 🍰


New dvdrental backup

Adds the following along with a couple of rows of sample data:
CREATE TABLE public.logs (
    id uuid NOT NULL,
    log_time timestamp without time zone NOT NULL,
    some_data integer[] NOT NULL
)
PARTITION BY RANGE (log_time);

CREATE TABLE public.logs_2019 (
    id uuid NOT NULL,
    log_time timestamp without time zone NOT NULL,
    some_data integer[] NOT NULL
);
ALTER TABLE ONLY public.logs ATTACH PARTITION public.logs_2019 FOR VALUES FROM ('2019-01-01 00:00:00') TO ('2019-12-31 00:00:00');

CREATE TABLE public.logs_2020 (
    id uuid NOT NULL,
    log_time timestamp without time zone NOT NULL,
    some_data integer[] NOT NULL
);
ALTER TABLE ONLY public.logs ATTACH PARTITION public.logs_2020 FOR VALUES FROM ('2020-01-01 00:00:00') TO ('2020-12-31 00:00:00');

CREATE MATERIALIZED VIEW public.long_films AS
 SELECT film.title,
    film.rating,
    ARRAY[1, 2, 3] AS some_data
   FROM public.film
  WHERE (film.length > 180)
  WITH NO DATA;

CREATE TYPE public.simple_type AS (
	some_array integer[],
	some_text text,
	some_number bigint
);

CREATE TYPE public.complex_type AS (
	ratings public.mpaa_rating[],
	nested_composite public.simple_type
);

CREATE TABLE public.table_with_composites (
    simple public.simple_type NOT NULL,
    id integer NOT NULL,
    complex public.complex_type
);

@daz10000, is there anything I can do to move these PRs along unless you're just busy?

Just a little busy - we loved our labs and offices over last few weeks.  Will see what we can do this week.
Von meinem iPhone gesendet

Am 17.02.2020 um 11:29 PM schrieb kerams<EMAIL_ADDRESS>
@daz10000, is there anything I can do to move these PRs along unless you're just busy?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.


Remove the limitation of time format in Expression

closes:  https://github.com/microsoft/BotFramework-Composer/issues/7415
Cause of the issue

The input of datetime function (like getTimeOfDay), only accepts the original datetime format("yyyy-MM-ddTHH:mm:ss.fffZ")
The output format of convertFromUTC is changed from "yyyy-MM-ddTHH:mm:ss.fffZ" to "yyyy-MM-ddTHH:mm:ss.fffffffK".
If put the result of convertFromUTC as the input of getTimeOfDay, the error occurs.

Changes
The current iso format may too be strict for all scenarios. Loose the limitation may help reduce many errors.

Pull Request Test Coverage Report for Build 240379

0 of 0   changed or added relevant lines in 0 files are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage decreased (-0.007%) to 78.861%

Files with Coverage Reduction
New Missed Lines
%

/libraries/AdaptiveExpressions/BuiltinFunctions/GetPreviousViableTime.cs
1
93.94%

Totals

Change from base Build 240267:
-0.007%

Covered Lines:
18138

Relevant Lines:
23000

💛  - Coveralls


how do i get a user's followers?

I'm having trouble figuring this out.
I want to follow a user's followers given an npub.

See NIP-02: https://github.com/nostr-protocol/nips/blob/master/02.md
We just now renamed it from "Contact List" to "Follow List" as a result of this question.
You need something like this:
/** Get a list of pubkey the given pubkey follows by querying their kind 3 event. */
async function getFollows(pubkey: string): Set<string> {
  const [event] = await getFilters([{ kinds: [3], authors: [pubkey], limit: 1 }]);

  return event.tags.reduce((result, [name, value]) => {
    if (name === 'p') {
      result.add(value);
    }
  }, new Set<string>());
}

/** Get events from a filter by using a relay. */
async function getFilters(filters: Filter[]): Event[] {
  // TODO
}

I keep running up on an event size limit when trying to follow more than a few hundred users.
I'm trying to figure out how I can follow of jacks users for example which is like 200k users.


feat(RHTAPWATCH-660): IP filter for smee sever

FIlter traffic tp the Gosmee server so that only traffic from GitHub, GitLab and our internal clusters will be accepted.

/lgtm


Cant write negative coordinates in Set Temperature window

Description

that one

Reproduction

Try to input minus
Minus isnt inputting

technically its possible just very fucky

just discovered, you cant INPUT minus but can PASTE :trollface:


Add  Interview Slot

Fix #38

Codecov Report

Merging #58 (10e4bd2) into master (fa8bbfb) will increase coverage by 0.08%.
The diff coverage is 70.83%.

@@             Coverage Diff              @@
##             master      #58      +/-   ##
============================================
+ Coverage     69.30%   69.39%   +0.08%
- Complexity      410      423      +13
============================================
  Files            79       80       +1
  Lines          1339     1395      +56
  Branches        138      146       +8
============================================
+ Hits            928      968      +40
- Misses          373      383      +10
- Partials         38       44       +6

Impacted Files
Coverage Δ

.../seedu/address/logic/parser/InternApplyParser.java
88.23% <ø> (-11.77%)
:arrow_down:

...in/java/seedu/address/logic/parser/ParserUtil.java
68.96% <0.00%> (-9.47%)
:arrow_down:

.../java/seedu/address/model/util/SampleDataUtil.java
23.07% <0.00%> (+3.07%)
:arrow_up:

src/main/java/seedu/address/ui/PersonCard.java
0.00% <0.00%> (ø)

.../seedu/address/logic/parser/EditCommandParser.java
82.75% <25.00%> (-9.55%)
:arrow_down:

...a/seedu/address/model/application/Application.java
94.23% <72.72%> (-1.43%)
:arrow_down:

...seedu/address/model/application/InterviewSlot.java
86.36% <86.36%> (ø)

...java/seedu/address/logic/commands/EditCommand.java
96.00% <90.90%> (-1.06%)
:arrow_down:

...a/seedu/address/logic/parser/AddCommandParser.java
69.56% <100.00%> (+1.38%)
:arrow_up:

...ain/java/seedu/address/logic/parser/CliSyntax.java
90.00% <100.00%> (+1.11%)
:arrow_up:

... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fa8bbfb...10e4bd2. Read the comment docs.

Added Interview Slot field in Application
Key Summary

Created  InterviewSlot class
Interview slot is stored as a LocalDateTime value in the InterviewSlot class
Adding a new application will default the value to LocalDateTime.Max & the value will default to Interview date is not set.
Edit command is re-enabled to cater to the adding of the interview time slot
Comparison between InterviewSlot class compares its String value instead of its actual value because when saving to JSON, data of  LocalDateTime.Max is truncated
Input format is dd-MM-yyyy HH:mm and display format is d MMM yyyy HH:mm

Usage
Adding/Replacing interview slot
Command: edit 1 idt/13-03-2022 13:00
Feedback:

Edited Person: Shopee; Job Title: Software Engineer Intern; Phone: 87438807; Email<EMAIL_ADDRESS>Address: 5 Science Park Dr, #06-40; Interview Slot: 13 Mar 2022 13:00; Tags: [friends]

Removing interview slot
Command: edit 1 idt/
Feedback:

Edited Person: Shopee; Job Title: Software Engineer Intern; Phone: 87438807; Email<EMAIL_ADDRESS>Address: 5 Science Park Dr, #06-40; Interview Slot: Interview date is not set.; Tags: [friends]

Preview

Other Updates

Update SampleDataUtil to reflect applications
Updated some test case data to reflect applications

Further improvements

Will highlight in GUI that interview date is not set for application depending on tags
Additional test cases for InterviewSlot
Suggestion to change idt/ to 'interview/'
Update remaining test cases data to reflect application

lchokhoe.png file does not need to be updated, please revert the changes in another commit.
While you are at it, some of the files had extra lines as well, I commented on them but here's where they are:

(main folder) InterviewSlot.java (Line 10 - Line 13)
(test folder) CommandParserTestUtil.java (Line 19)
(test folder) PersonBuilder.java (Line 31 and Line 40)

Other then that I think all the changes you made LGTM 👍

@lchokhoe Image updated as per #59 & remove blank spaces


getSingle with returning last data into table

documentation of this library is very very basic and its not good for all of developers and i can't understand how can i use more feature of that, for example:

this operation won't put a limit clause on this statement,if that's needed you would have to do that yourself.

ok, so how can i write this query to get last row, for example:
SELECT * FROM userTable ORDER BY id DESC LIMIT 1;

You can pretty much copy the example straight from the Ordering section of the documentation and add a ..limit(1) clause...
  Future<TodoEntry> getLastRow() {
    return (select(todos)
      ..orderBy([(t) => OrderingTerm(expression: t.title, mode: OrderingMode.desc)])
      ..limit(1)
    ).getSingle();
  }

@Mike278 it doesn't throw exception?

it doesn't throw exception

I'm not sure what you mean by that. getSingle will return null when no data is available instead of throwing (not really intuitive, but that's described in the docs). If a query returns more than one row and you use getSingle, it will throw.

documentation of this library is very very basic and its not good for all of developers and i can't understand how can i use more feature of that

Sorry to hear that. I'll improve the documentation where I can. On the documentation for getSingle(), we now point out that limit exists. I've also added an example similar to that given by @Mike278 to the documentation.
Does that help?

@simolus3 thanks a lot, i'm implementing simple app to learn this library, let me to check, thanks

Sure - I'll close this issue for now, but feel free to reopen if you run into any problems with limit and getSingle.

@simolus3 problem solved, thanks


refactor(ui): replace AutoInput with Clockface

Closes #14625

Replace locally defined AutoInput with the same component from Clockface
Delete locally defined AutoInput component and styles

[x] Well-formatted commit messages
[x] Rebased/mergeable
[ ] Tests pass

@chnn I did a cursory check to see if the changes affect functionality / ux in the histogram options, can you take a look and verify that it still works as expected?


Document cast send/call <calldata>

It is now possible to also just pass raw calldata directly to cast send and cast call, see https://github.com/gakonst/foundry/pull/742

It was a typo, fixed here https://github.com/onbjerg/foundry-book/commit/2cb164bdd31b1e0979e030ce127b48968ea4ab4d


Remove commenting, loving and faving functionality

It is already against Scratch's Terms of Use
Most people don't use it, unlike the cloud variable features which are used a lot!
Even if people do use it, it's probably for bad a reasons like spamming.

Ok. I will think over it. React the above Chiroyce's comment with "thumbs up" or "thumbs down". Let's see how many people want that feature to be removed...

Thumbs up is "remove it" thumbs down is "don't remove it" right?

If you remove commenting, also remove love, favourite, follow,

If you remove commenting, also remove love, favourite, follow,

Yes, we also don't need these. We need this library to be useful for people who want to make cool projects, and not for those who want to spam comments or use follow bots.

Ok. I will remove those features soon. But it may take a long time as my school started and I'm in higher school now. I am busy now...
BTW what do you think of adding a limit. Such as which stops commenting twice on a user's profile and can't comment again until next hour? But he/she can comment on other user's profile only once per hour. I may do the same for loves, faves, and follows...

Thumbs up is "remove it" thumbs down is "don't remove it" right?

Yes.

But people can still download earlier versions and make those spam bots...

When you remove it keep the code in a separate repo so the code is still there in case of someone needing some code for that

It will still be there in the git history - a separate repo is not required.

When you remove it keep the code in a separate repo so the code is still there in case of someone needing some code for that

It will still be there in the git history - a separate repo is not required.

What is the point of this in the first place, then? Anyone interested in making a bot would simply look in the history of the repository and see the code.

No. I won't delete this...
Let me see if I can delete git history...

Removing the git history would need everyone to re-clone right? What about the contributor list (depends on author emails)?

Ok. So do you think that I should not delete this repo's history?

If people are spamming they could just make there own requests using the request library. Its not rocket science (for comments at least. Cloud is very complex though)

Yes. So should I remove this feature or no?

If people are spamming they could just make there own requests using the request library. Its not rocket science (for comments at least. Cloud is very complex though)

This makes it a lot more easier. This will definitely reduce the amount of spam. But sadly we have a huge problem in front of us, most people use the older version and will not update.... so this is sort of pointless... BUT it will prevent any new spammers from rising..

Yes. But if they are making bots, the code must be stored somewhere on the server. So during runtime, the library will be downloaded again to latest version, if the user has not given any version argument. I can delete all the previous versions on pypi. So, the previous versions will not get downloaded. But if the user has stored the library's code on the server and doesn't require installation, then that user might be able to make spam bots.

Yes. I know. But we can request them to install the latest version...

Some people don't like auto-updating open source software. Sometimes they believe it is not FLOSS software if it has auto updating mandatory.

Some people don't like auto-updating open source software. Sometimes they believe it is not FLOSS software if it has auto updating mandatory.

We can't even enforce it - we have to give a reason for why they should update. And if we tell them the actual reason, they'd obviously not want to update (the spammers)

The solution seems very empty, easily bypassed, also they'll all switch to scratchclient. I think all of the library makers should work together then. Also what if they are using DevTools Console?

Everyone, the point of this is not to completely stop spammers, but to discourage them from doing so. If we remove the functionality from this, then they'll have to make their own (either by referring the older commits or on their own), so they might feel like it's too much work and decide to stop spamming.

Ok. Then I will remove those features. What about follow/unfollow?

replit's poetry thing already updates modules. also remove the reporting functionality

replit's poetry thing already updates modules. also remove the reporting functionality

thats a good idea - people using replit for spamming can not do so after the update, and reporting should definitely be removed as well.

Oh. So reporting also causes spam? What about unfollowing?

Everyone, the point of this is not to completely stop spammers, but to discourage them from doing so. If we remove the functionality from this, then they'll have to make their own (either by referring the older commits or on their own), so they might feel like it's too much work and decide to stop spamming.

 All this does is curb functionality due to a few bad actors. Of course commenting using scripts is against the rules, but there are legitimate reasons that you could do so (it's not against the rules if you don't get caught) and what this does is discourage genuine creativity in favor of (possibly) mildly annoying some spammers. FWIW, I doubt any decent bot uses Python anyway because async in Python is weird, so it's pretty likely that this will have no effect on spammers. I don't think personal sentiment is a good tool to decide what gets removed from software.

After some thoughtful consideration, I feel like we should not remove this. The bots spamming aren't our problem, and the ST has shutdown a lot of them in the past 2-3 days. So technically instead of use trying to discourage the spammers, it's better if the ST bans them altogether.

FWIW, I doubt any decent bot uses Python anyway because async in Python is weird, so it's pretty likely that this will have no effect on spammers.

When did the spamming start?

Ok. So, should I keep those commenting and other functionalities? No need for removing them?

It's not allowed to spam or bot @Chiroyce1

It's not allowed to spam or bot @Chiroyce1

That would be a very weird restriction, and it'll still be able to spam others.

You said "it's better if the ST bans them altogether." but the ST already bans the spammers/botters?

And ST deletes the spammed content. Right?

BTW @Chiroyce1 can also disallow commenting on his profile...

BTW @Chiroyce1 can also disallow commenting on his profile...

That's not how the spam is going on. They're abusing the reply function to reply to ghost comments on other people's profiles, so I get a notification for a reply to a comment I never even made.

Oh :(

How about a new update where a reply automatically pings the parent commenter? This will eliminate ghost pings. Just idk what to do of people using older versions of the package.
dumb idea: ask ST to require some other unnecessary piece of data which will break older versions of commenting

Oh. Let me think of that...
I think I will remove the whole commenting feature... Also, I can see that there is a tie in the votes...
Ok. Now, I need to remove the following (Tell me if I can remove anything else or keep it):

commenting: user, studio, project
report
follow/unfollow
love a project
fave a project

Anything else?

Oh. Now I can see that there are "6" votes for not removing that feature and "5" votes for removing it. I think not removing wins. But I will wait for today...

What about adding a time limit in which a user can only post comments on the same profile only once per hour? But can comment on other's profile only once per hour.

How will you make the time limit? People will find ways around it...

Yes. In Python, you can't make an object private, though using "_". I think I should not remove those features. The Scratch Team should fix that ghost reply and add a way to stop spamming. Maybe they can add a time limit of 1 comment per 10 minutes or even more...

If the ST limits to 1 comment per 10 minutes... Conversations would be ruined!

Yes. Maybe they can add 1 comment per 10 minutes per 1 user. Which then will allow a user to post a comment on other user's profile per 10 minutes. Till then, he/she can comment on other user's profile.

Yes. Maybe they can add 1 comment per 10 minutes per 1 user. Which then will allow a user to post a comment on other user's profile per 10 minutes. Till then, he/she can comment on other user's profile.

Still, that wouldn't be good. Then you cant have any real time conversations with just one person

Yes :(
We should report the errors to Scratch Team for removing ghost ping and making a way to reduce or stop spam...

I can see that the "don't remove" votes are more than "remove" votes. I think I will not remove these features.
The ghost reply should be fixed by the Scratch Team and they should have a way to stop spam.
I am going to close this issue on the next update...

Closing this...

To remove ghosting, the package can just make an additional request to the parent comment specified and automatically add the ping to the front. Just like how Scratch forces pings to be in front that we don't write.
Example: someone uses replying feature to reply to parent comment 12345. The package makes requestmto see the 12345 comment author and then adds it to the start.
("@" + parent comment author + " "  + what the User wanted to comment)

I don't think that would work but I will try after some time...


Added a man page

A page for the man utility has been added. It includes a markdown file, a script for generation of a man page by pandoc utility and a generated man page.

Please remove the build artifact, change aproj to antler-proj, and update the CMake file to build the man page.

If you mean that the antler-proj.1 file is a build artifact I'm not agree. It is a documentation and it doesn't make sense to consider it the same way as C++ source code. It has value itself. It may be printed as man ./antler-proj.1 right in the command line or opened in midnight commander which can render it too. It doesn't make sense to force a developer, who just cloned the repo, install pandoc and run CMake only to see a man page as a man page.

antler-proj.1 is built from antler-proj.1.md using pandoc.
My concern is two fold:
1. a change to the source does not result in an automatic update to the artifact.

2. we lack an install target for the artifact.

Additionally, I believe the risk of the artifact losing sync to source is more problematic than needing to install pandoc to view a potentially out of date manpage... And the user can always open the .md source file anyway.

IMHO building of code and writing of documentation are different tasks. So I propose to add the document and then talk about how to integrate it to the  building process. IMHO it should include not only installation of pandoc and conversion but also building of the install packages. Maybe it make sense to think about conversion to help formats of other supported systems because Windows doesn't support man. Again it is a separated big issue but it is not a cause don't add a man page right now. Anyway if you believe it should be in CMake file add it as you wish, you know better how it should be I'm not against it. I just want to leave the man file in order don't force people install pandoc just to get the man page.
Could you tell a realistic scenario how somebody may change a man file directly and it will be approved and make a big problem? Anyway if you add the conversion step into the building process it will recreate the man file.

#25


Add a site map for search engines

Here are some guidelines from Google…
https://support.google.com/webmasters/answer/156184?hl=en
One of these may help as well, since we’re using Jekyll…
https://github.com/jekyll/jekyll-sitemap
https://github.com/kinnetica/jekyll-plugins

bensonnn was kind of enough to get this one started. He created this file…
https://github.com/foodoasisla/site/blob/master/sitemap.xml

The sitemap is live now…
https://foodoasis.la/sitemap.xml
A link to it is included in robots.txt…
https://foodoasis.la/robots.txt