Separate /model into its own module

Which problem is this PR solving?

Resolves #4899

Description of the changes

Created go module at /model. Used replace in go.mod at / and /model
Updated /scripts/check-go-version.sh to check /model/go.mod as well.
Added support in dependabot (opentelemetry moved from dependabot to renovate-bot here. We can use dependabot for multiple modules though.)
For releases, we can use multimod by opentelemetry. A versions.yaml will define the different versions of different modules. (I have not implemented this yet.)
Code coverage should not be affected I feel. Although let's see the codecov report.

How was this change tested?

make lint test

Checklist

[x] I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md
[x] I have signed all commits
[x] I have added unit tests for the new functionality
[x] I have run lint and test steps successfully

for jaeger: make lint test
for jaeger-ui: yarn lint and yarn test

@yurishkuro Can you please help me figure out why the code coverage went down?

Can you please help me figure out why the code coverage went down?

In the report I see that all /model/ files are down to 0% coverage. I suspect go test ./... does not include sub-modules - this is one of the things that needs to be figured out.

another issue - the vulnerability checker flagged /model/ as vulnerable dependency, I suspect because of 0.x version number. What is the story with this version number? In OTEL collector I see that their versions are in sync across modules, so they must have some mechanism for managing/updating those after release.
Vulnerabilities
  model/go.mod »<EMAIL_ADDRESS>– A stored XSS in jaeger UI might allow an attacker who controls a trace to perform arbitrary jaeger queries (moderate severity)
    ↪ https://github.com/advisories/GHSA-2w[8](https://github.com/jaegertracing/jaeger/actions/runs/7656173413/job/20863882760?pr=5144#step:5:9)w-qhg4-f78j
  model/go.mod »<EMAIL_ADDRESS>– Information Exposure in jaeger (moderate severity)
    ↪ https://github.com/advisories/GHSA-gh32-pc56-4c[9](https://github.com/jaegertracing/jaeger/actions/runs/7656173413/job/20863882760?pr=5144#step:5:10)6
  Error: Dependency review detected vulnerable packages.

The wierd versioning happended after I aded the replace lines and ran go mod tidy. Here is a StackOverflow question regarding it.

closing https://github.com/jaegertracing/jaeger/issues/4899#issuecomment-2134139934


Add global mean-level calculations

This PR includes a change that calculates/writes out total global mean sea-level change between the initial and current timesteps.
It also changes the ice volume calculation section to lines below after the 2D field variables are written out.

Testing results:
Tested the PR commit in the eustatic sea-level simulation scenario (i.e., no deformation, no rotation, no gravitation) where the Antarctic ice thickness evolves under the UKESM SSP5-8.5 climate forcing provided by the ISMIP6-2300 experimental protocol.
The total eustatic sea-level change between 2015-2300 is shown as the following:

Picking a point from this field, the time series of the sea-level change is shown in the solid black line in the below figure, and the GMSLE change calculated by the changes made in this PR is shown in blue circles.

I'm closing this PR as the gmsle calculation done in this PR is actually incorrect as it assumes 100% of ice volume change to be above floatation. A new PR will be created for GMSLE calculation.


Return JSON error, instead of plain error messages

Pull Request Test Coverage Report for Build 120621351

6 of 30 (20.0%)  changed or added relevant lines in 3 files are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage decreased (-1.9%) to 61.163%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

cmd/front-end/server/games_handlers.go
0
1
0.0%

cmd/front-end/server/users_handlers.go
0
9
0.0%

cmd/api/server/users_handlers.go
6
20
30.0%

Files with Coverage Reduction
New Missed Lines
%

cmd/front-end/server/users_handlers.go
1
14.04%

Totals

Change from base Build 119290617:
-1.9%

Covered Lines:
263

Relevant Lines:
430

💛  - Coveralls


add GPU AMIP scaling runs

Purpose
closes #663
note: we want to use the slurm_exclusive: flag to get a GPU that's being used for only the performance job, but this seems not to be working when used in Atmos
Need to use ClimaAtmos#fdf1df4 commit to include PR containing atmos config files. Can't use main because of dependency incompatibilities.
Content

[x] add GPU performance buildkite pipeline
[x] add SYPD calculation to driver (use calculation from atmos so we're consistent)
[x] add configs for 1-, 2-, and 4-GPU AMIP runs based on ClimaAtmos chap runs

do for both strong and weak scaling

[x] add runs in buildkite/gpu/pipeline.yml
[ ] manually trigger pipeline to check that these runs succeed on clima

[ ] I have read and checked the items on the review checklist.

See here:
https://github.com/CliMA/ClimaAtmos.jl/pull/2646/commits/448d22c25e66fa310c14b48ebb1659d6e17c5113
-  SLURM_GPU_BIND: none # https://github.com/open-mpi/ompi/issues/11949#issuecomment-1737712291
+  SLRUM_GRES_FLAGS: "allow-task-sharing"

@charleskawczynski @dennisYatunin does increasing the ref counter seem like a good way forward here, or is the behavioral change worrying here?

CHAP is no longer our target; we want to set up scaling runs using the benchmarks pipeline and setups in the future


bbc video does not get downloaded (win10) youtube-dl --version -->2020.05.29

Checklist

[ x] I'm reporting a broken site support issue
[ x] I've verified that I'm running youtube-dl version 2020.05.29
[x ] I've checked that all provided URLs are alive and playable in a browser
[x ] I've checked that all URLs and arguments with special characters are properly quoted or escaped
[x ] I've searched the bugtracker for similar bug reports including closed ones
[x ] I've read bugs section in FAQ

Verbose log

youtube-dl.exe --verbose "https://www.bbc.com/news/av/embed/p08fvzqq/52900486"
[debug] System config: []
[debug] User config: []
[debug] Custom config: []
[debug] Command-line args: ['--verbose', 'https://www.bbc.com/news/av/embed/p08fvzqq/52900486']
[debug] Encodings: locale cp1252, fs mbcs, out cp437, pref cp1252
[debug] youtube-dl version 2020.05.29
[debug] Python version 3.4.4 (CPython) - Windows-10-10.0.18362
[debug] exe versions: ffmpeg git-2020-05-15-b18fd2b
[debug] Proxy map: {}
[bbc] 52900486: Downloading webpage
[bbc] p08fvzqq: Downloading media selection XML
ERROR: No video formats found; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; type  youtube-dl -U  to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.
Traceback (most recent call last):
  File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\ytdl-org\tmpxtvjzx45\build\youtube_dl\YoutubeDL.py", line 797, in extract_info
  File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\ytdl-org\tmpxtvjzx45\build\youtube_dl\extractor\common.py", line 530, in extract
  File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\ytdl-org\tmpxtvjzx45\build\youtube_dl\extractor\bbc.py", line 937, in _real_extract
  File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\ytdl-org\tmpxtvjzx45\build\youtube_dl\extractor\common.py", line 1350, in _sort_formats
youtube_dl.utils.ExtractorError: No video formats found; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; type  youtube-dl -U  to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.

Description

WRITE DESCRIPTION HERE
BBC video is not extracted. Video is here:
https://www.bbc.com/news/av/embed/p08fvzqq/52900486

Works with https://github.com/ytdl-org/youtube-dl/pull/26821.

Still broken at https://github.com/ytdl-org/youtube-dl/commit/e465b25c1fb0e72b97a032220399d4a959662095 (unable to extract playlist data).


Method not found issue

Summary
When I submit my code on CodeCrunch, I am getting a symbol not found error. I understand what the error means, but I am not getting this error on my own laptop, so I'm not sure why it is happening on code crunch. This method is a public method I defined myself within the PQ class to get the size of the priority queue.
Description:
Code Snippets
public int length() {
        return this.pq.size();
    }

Screenshots

Not too sure if this is correct, but I think the only logical explanation if it works on your laptop and doesn't work on CodeCrunch is that you are not meant to modify the PQ.java class, and that CodeCrunch runs its own/original version of PQ.java in its test cases, which is why it can't find the method.


Name the .cache and kustomize directories based on the KFDef name

Currently Kubeflow operator will use /tmp/.cache and /tmp/kustomize to store the downloaded and generated manifests.
These directories should be ideally based on the KFDef resource name, since once the /tmp/kustomize exists, operator will skip the kustomize.Generate step:
time="2020-02-17T12:48:48Z" level=info msg="folder /tmp/kustomize exists, skip kustomize.Generate"

Imagine a scenario where:

A user submits KFDef

Realizes he needs to add another manifests repo to the list

Adds the manifests repository and runs kubectl apply -f

Operator fails with
time="2020-02-17T12:48:48Z" level=error msg="error evaluating kustomization manifest for component Error absolute path error in '/tmp/kustomize/component' : evalsymlink failure on '/tmp/kustomize/component'

because it did not update the /tmp/kustomize

There are probably other scenarios - like someone adding a resource to KF manifests and the operator ignoring it, but I guess for development it is ok to just fall back to kfctl directly

Hmm..now that I read my description, it really does not make much sense. Sorry for this.
IIRC I came across this issue when I submitted a KFDef names X, deleted it and submitted another - different - KFDef named Y where Y = X + additional component.
And I combined this problem with potentially another issue where we want to submit 2 KFdefs - in case, in the future, we have the ability to enable components on namespace scope.
So I would now say that there is this issue in the name - path to .cache and kustomize should be based on the resource name and then there is issue where the cache needs to be updated when the KFDef resource is updated by a user.
What do you think?

@vpavlin yes, I agree in a case when the kubeflow supports multiple instances within a namespace or a cluster (note that current operator is a cluster scoped). And based on just resource name may be solving the update partially. We can have a PR to append the KfDef name as I think it is a right thing.
I also agree the bigger problem is when the configuration of a certain component gets changed, but the KfDef name remains the same. Because the kustomization regeneration is bypassed, even though the KfDef resource itself is updated, the real kubeflow deployment remains the same.
Let the operator code always generate the kustomization directories and files may work for adding additional components. But what if a component is removed from the current KfDef resource? Still thinking how to handle these cases and whether the operator should have the similar behavior as command line deployment.

My approach would be:

Apply - start from clean cache (this sounds obvious, but if the Delete event does not clean the cache, apply does not start from scratch, so in case:

apply
operator crash
delete
operator restart
apply - here we would not start from fresh cache even if the delete cleans it, so it would be best to clean cache on apply always

Update - start from clean cache
Delete - we don't do much here since we agreed on using the ownerReferences, delete the cache
Full reconciliation - use existing cache

This way any new KFDef or update would force manifest regeneration and timed reconciliation would run from well known cache.
WDYT @adrian555

/area kfctl
/priority p1

Hey! Any progress here?

Thanks @vpavlin for checking back. I am still working on this. Basically only when an update is detected to a KfDef will the existing cache be used, otherwise we will generate a new directory and cache for a new KfDef.

@adrian555 we are bumping into this with our new ODH 0.6 operator see issue (https://github.com/opendatahub-io/opendatahub-operator/issues/9)
Basically it is not just the cache, but also the kustomize folder. In general terms the user should be allowed to create multiple instances of the API (in this case kfdef) on the cluster without any issues even if the operator is cluster wide. Currently, the following use case is broken with this operator:

Cluster admin installs this operator cluster wide
User A creates a namespace A and creates an instance Kfdef (name: A, namespace: A). This works.
User B creates a namespace B and creates and instance Kfdef that is different from kfdef in Step 2 (name B, namespace B) This fails with these errors, in this case seldon was the new component:

msg="folder /tmp/kustomize exists, skip kustomize.Generate"
time="2020-04-27T17:20:19Z" level=info msg="/tmp/.cache/manifests exists; not resyncing "
time="2020-04-28T22:13:55Z" level=error msg="error evaluating kustomization manifest for seldon-core-operator Error absolute path error in '/tmp/kustomize/seldon-core-operator' : evalsymlink failure on '/tmp/kustomize/seldon-core-operator' : lstat /tmp/kustomize/seldon-core-operator: no such file or directory"

@nakfour yes, this is expected problem with the current implementation as already mentioned in some previous comments. Therefore, we need to have different directory for each kfdef instance.

Thanks @adrian555, it's good to know this is still on your radar:)

Basically only when an update is detected

So what happens if the update is a new component added into the KFDef? I believe that would fail unless the kustomize dir is regenerated.

@adrian555 I am not clear why we need to keep different kustomize folders. What are they used for? From an operator perspective, users create instances of APIs and they delete them. I don't see a need to keep the kustomize folder since I don't see a Users pattern of re-installing the same API instance over and over again. According to this issue: https://github.com/kubeflow/kubeflow/issues/4368 the folder kustomize is kept to allow users to insert data into it, which is not the case with operators.

@adrian555 there is also one use case to add, users might edit the instance yaml and change it, but this still requires a new generated Kustomize folder.

@nakfour what I said is each instance will have a directory of different name. This is to support the use case you mentioned (name A and name B coexist). The directory for each instance will be deleted when the instance is deleted, just like @vpavlin described.

yes @vpavlin for new application added to kfdef the cache and kustomize will be regenerated/synced. I am hoping I do not need to wipe out the whole directory, but it may come down to that approach to remove the whole directory and recreate.

@adrian555 it still not clear to me. Your sentence "each instance will have a directory of different name. This is to support the use case you mentioned (name A and name B coexist)." What does support mean?? You can have name A and name B coexisting if you just wipe out the kustomize folder on each install. It is not clear to me why the kustomize folder is needed???

@nakfour the reconcile routine calls the same kfApply function as during the install. So the kfapp directory can not be wiped out or replaced after the install.

@adrian555 If you can provide even WIP PR, we'd be happy to test and document the potential cases. There are probably 2 seperate problems
.cache - if something changes in a manifest repository, cache needs to be updated
kustomize - if something changes in KFDef, kustomize dir needs to be regenerated
And that is the case for both apply or update, obviously delete should just clean everything
The cache case could be solved by some checksums being verified if we want to avoid deleting it every time
But as soon as we update the cache, we need to clean up kustomize as well, to prevent stale generated manifests
The kustomize case basically means that if KFDef changes in any way, the kustomize dir needs to be regenerated, otherwise we wouldn't work with correct manifests.
So the simplest (lame) solution really is to run from clean cache and kustomize every time any event is triggered.
More complicated (smarter) solution is to track the manifest source and make sure the cache not outdated and make sure each change in cache or KFdef regenerates kustomize - but I am not sure if this is worth the potential implementation pain.

@adrian555 when is the reconcile routine called? We have the quick fix in ODH of deleting the kustomize folder on every apply' request here: https://github.com/opendatahub-io/opendatahub-operator/pull/14 It seems to work, but maybe we missed the specific use case where reconcile` is called. Does this team have a weekly community meeting we can discuss issues? If not you are welcome to join our ODH community meetings to discuss.

@adrian555 Thanks for the fix, closing the issue!


[bug] youtube -> test drive download -> woah that is out of date

Describe the bug
Hi I was watching this Youtube vid - https://www.youtube.com/watch?v=UxTJeEbZX-0&ab_channel=TauriApps
There is a link in the description, it says:

If you just want to take Tauri for a test-drive, we've uploaded a sample app for MacOS, Linux and Windows that you can download from Github here:
https://github.com/tauri-apps/tauri/r...

Now that was a mistake from me, is I didn't notice at that link it says

@nothingismagick nothingismagick released this May 21, 2020
· [2047 commits(
https://github.com/tauri-apps/tauri/compare/0.5.2-binaries...dev)to dev since this release

Right so that's from 2 years ago.   It's pretty cool.  It seems to work fine.

Trouble is it can't be uninstalled by the Windows add/remove apps in the control panel.

I understand if somehow this can be interpreted as Windows fault. Perhaps one of the devs on the project had this exact same problem 2 years ago and could offer some advice how to uninstall this program.
Secondly I recommend if you feel inclined, perhaps change the link in the Youtube video description to a more updated release.
Reproduction
No response
Expected behavior
No response
Platform and versions
n/a, repro is self contained in `msi` file available via link above

Stack trace
No response
Additional context
No response

I found I can click "Ignore" to proceed past the dialog and then it does appear uninstalled.
Closing this but still the link in the Youtube vid could be updated - perhaps showcase some newer features!

And this is why we stopped making tutorials until we land the stable 1.0 version. Sorry about that!!!


Use mido multi_receive instead of MultiPort to receive midi messages

I tested on Raspberry Pi & Windows and in both cases MultiPort would not yield midi messages, however multi_receive works perfectly.
p.s. I would open up an issue on mido but the dev seems to be inactive there.

Failed due to FakeMido, should I also update that class and re-submit the PR?

@VonHirsch Just update the code and push to your branch. I recommend git commit --amend --no-edit; git push -f origin MidiFix so there's no new commit.

ok thanks for that, done


Alternate array syntax to resolve : issue in key names for RouteClaimsRequirement option in configuration

New Feature
Add an alternate syntax to the RouteClaimsRequirement configuration.  Instead of the current shorter (and nicer) current syntax of:
"RouteClaimsRequirement": {
  "{ClaimType}": "{ClaimValue}"
}

Support a more verbose array syntax as well:
"RouteClaimsRequirement": [
  {
    "type": "{ClaimType}",
    "value": "{ClaimValue}"
  }
]

Motivation for New Feature
Microsoft uses a : to signify hierarchy in configuration files.
See https://github.com/dotnet/extensions/issues/782
There is a great workaround on issue 679 that would be unnecessary if an alternate syntax could be used without the : in a key value.
The most common/reported issue is with the default MS role claim type http://schemas.microsoft.com/ws/2008/06/identity/claims/role
Currently this does not work and requires a workaround:
"RouteClaimsRequirement": {
  "http://schemas.microsoft.com/ws/2008/06/identity/claims/role": "Administrator"
}

Having an alternate syntax would fix this and "just work":
"RouteClaimsRequirement": [
  {
    "type": "http://schemas.microsoft.com/ws/2008/06/identity/claims/role",
    "value": "Administrator"
  }
]

Don't implemented?

I'm having the same problem and was about to suggest the same feature.

@ghorsey
Hi Geoff!
Will you personally contribute and be responsible for feature delivery?

Dear @ghorsey,
Update version to 23.3.0!
With Metadata feature do whatever you want. Good luck!
You have the right to reopen this issue in the future if you come with a PR ready


feature flag to disable consequential Gov V1 hooks

https://github.com/paritytech/polkadot/pull/7314 requires us to temporarily restore Gov V1 pallets to the runtime.
We need the pallets to be entirely benign.
We can disable Calls using exclude_parts {Call}, but still need to prevent hooks from being called.
It was agreed during the last FRAME team call to add a feature flag which would disable hooks we don't want to run. There may be better approaches to disabling hooks (such as creating a new part we can use in exclude_parts, but that would likely take a long time to implement and unlocking the Gov V1 funds is time sensitive.

Going to spend more time trying to remove pallets from construct_runtime!. Converting this to a draft in the meantime.

Superseded by approach laid out in https://github.com/paritytech/substrate/pull/14773


fix: Release scoobie

This should be the first release of Scoobie to npm! It's version-matched to its scoped predecessor @seek/scoobie.

Tested the beta against https://developer.seek.com and it looks good to go :shipit:


[ci:component:github.com/gardener/etcd-druid:v0.16.1->v0.17.0]

Release Notes:
Fixes a bug in snapshotter loop when backup-restore fails to collect events or fails to apply watch if required etcd revision has been compacted.

A bug that caused control plane migrations to fail for shoots with numeric names and a leading `0` has been fixed by eliminating the `EtcdCopyBackupsTask` helm chart.

Remove helm charts for EtcdCopyBackupsTask controller in favour of go code

Update HVPA dependency to `github.com/gardener/hvpa-controller/api:v0.5.0`.

etcd-custom-image updated from `v3.4.13-bootstrap-8` to `v3.4.13-bootstrap-9`

Base alpine image upgraded from `3.15.6` to `3.15.7`

ETCD Statefulset and Services only use `instance:<ETCD Name>` as selector field.

Refactor etcd-druid code: refactor CLI flags, restructure controllers, add controller configs, add controller-specific unit tests, restructure existing controller tests into controller-specific integration tests. This makes etcd-druid easier to maintain and contribute to.

The default value for druid CLI flag `ignore-operation-annotation` is now set to `false`. This means druid will now respect the `gardener.cloud/operation` annotation for reconciling the `Etcd` resource by default. This change allows for developers to follow best practices during local development and testing.

Introduce integration tests for testing the functionalities of each controller, which can be run using `make test-integration`.

Squash multiple bugs in controllers as part of the refactoring process.

Eliminated `ServiceAccount` helm charts and converted into Golang component with added unit tests.

Adapt `etcdbrctl` dir path flags `data-dir` and `restoration-temp-snapshots-dir` based on [etcd-backup-restore#609](https://github.com/gardener/etcd-backup-restore/pull/609).

Enhances the scale-up detection conditions to avoid potential failure while from migrating single node etcd to multi-node etcd cluster.

Optimize disk usage during restoration of delta snapshots, and remove scope for errors in the process.

Introduce CLI flag `--restoration-temp-snapshots-dir` to configure directory used for temporarily persisting delta snapshots during restoration.

Fix behavior of `--data-dir` for `etcdbrctl compact` command to be consistent with the flag's usage in other `etcdbrctl` commands.

Allow for flexible build opts for other CI tools.

Etcd snapshots are copied in parallel instead of sequentially (10 in parallel by default, configurable via `--max-parallel-copy-operations`).

Fixes a bug in snapshotter loop when backup-restore fails to collect events or fails to apply watch if required etcd revision has been compacted.

Restrict the file permissions of `safe_guard` file from 644 to 600.

Upgraded golang version to 1.20
Upgraded dependencies including upstream gardener/gardener dependency to 1.65.0
Upgrades client-go to v0.26.1
Upgrades controller-runtime to 0.14.4

/approve
/milestone v1.68

@acumino can you please remove one occurrence of the following release note in the PR description? It's been repeated twice. It should only be part of etcd-backup-restore release note (the last-but-second release note in the list) and not etcd-druid release note (first release note in the list).
Fixes a bug in snapshotter loop when backup-restore fails to collect events or fails to apply watch if required etcd revision has been compacted.

/kind enhancement


Make matlab_pkg fails on MacOS

I've checkout out the current master and tried to run make matlab_pkg on MacOS 10.14.6 (Mojave). Got the error:
...
Converting texinfo to Matlab-style documentation: doctest.m
cp -ra inst/private/*.m tmp/doctest-matlab-0.7.0+/private/
cp: the -R and -r options may not be specified together.
make: *** [tmp/doctest-matlab-0.7.0+] Error 1

-a on MacOS equals -pPR according to man cp. A workaround is to install coreutils e.g. via Homebrew and then run env PATH="/usr/local/opt/coreutils/libexec/gnubin:$PATH" make matlab_pkg
In some way related to #216.

Thanks!  Any chance you can send a pull request?
I don't have a mac so not easy to test.  But if you send a pull request, I can test to ensure it still works on GNU systems.

I'll try. Also, AFAIK since MacOS is a BSD derivate, the cp command is the same on MacOS and e.g. FreeBSD; just in case you want to try it yourself.

I can test it on macOS (but do not have time right now to implement the fix myself).


Go | 875. Koko Eating Bananas

File(s) Modified: 875-Koko-Eating-Bananas.go
Language(s) Used: Golang
Submission URL: https://leetcode.com/submissions/detail/751221299/

Thanks, @sakiib!


[WIP] Fix wrong routing problem

Fix wrong routing problem
#939 & #857 related

Should be resolved by https://github.com/Strider-CD/strider/commit/ecbef16dc6fb86606afde51ceaf9cd730aa0c4a5


[SPARK-48273][SQL][FOLLOWUP] Explicitly create non-Hive table in identifier-clause.sql

What changes were proposed in this pull request?

A followup of https://github.com/apache/spark/pull/46580 . It's better to create non-Hive tables in the tests, so that it's backport safe, as old branches creates hive table by default.
Why are the changes needed?

fix branch-3.5 CI
Does this PR introduce any user-facing change?

no
How was this patch tested?

N/A
Was this patch authored or co-authored using generative AI tooling?

no

cc @nikolamand-db  @LuciferYang

thanks @cloud-fan but still a failing case in SQLQueryTestSuite

https://github.com/apache/spark/actions/runs/9292789942/job/25574476419

[info] - identifier-clause.sql_analyzer_test *** FAILED *** (756 milliseconds)
[info]   identifier-clause.sql_analyzer_test
[info]   Expected "...lse, LocalTempView, [UNSUPPORTED, ]true
[info]      +- Aggregate...", but got "...lse, LocalTempView, []true
[info]      +- Aggregate..." Result did not match for query #94
[info]   create temporary view identifier('v1') as (select my_col from (values (1), (2), (1) as (my_col)) group by 1) (SQLQueryTestSuite.scala:876)
[info]   org.scalatest.exceptions.TestFailedException:

fixing at https://github.com/apache/spark/pull/46800


json-schema-editor

Is there any chance to have json-schema-editor example ?

Ooops, I didn't see this one. My apologies.
Do you mean something similar to our @stoplight/json-schema-viewer?

@P0lip yes it will be good to see some example not for viewer but for editor ....

Unfortunately, we don't have anything I could share at the moment :disappointed:
Our json-schema-editor is a private repository, and I cannot share the code.


Object Storage Managed Component (PROJQUAY-932)

Issue: https://issues.redhat.com/browse/PROJQUAY-932
Changelog: Add managed storage using ObjectBucketClaim API
Docs: TODO(alecmerdler)
Testing: TODO(alecmerdler)
Details:
Adds objectstorage managed component for registry blob storage. Declaring this optional component will cause the Operator to provision a bucket using the ObjectBucketClaim API and direct Quay to use that as a registry storage backend.

Closed in favor of https://github.com/quay/quay-operator/pull/298


请求支持 docker 镜像

方便打镜像吗？

随便打了个自用,直接用,或者等官方镜像也行.
docker run -d --name=huntly -p 8080:8080 jonnyan404/huntly

提供 PORT 变量自定义端口

启动后,访问 ip:8080 即可

Will there be an official docker image or compose with persistent storage volumes?

Will there be an official docker image or compose with persistent storage volumes?

Yes, will support asap.

Will there be an official docker image or compose with persistent storage volumes?

Yes, will support asap.

Also better mobile support would be a big plus. Right now it's not possible to view on mobile devices.


Host-built sample challenge not guaranteed to work in challenge container

In the local testing walkthrough there's an instruction to build the challenge binary using the host toolchain:
make -C challenge

However, my Ubuntu 22.04 host builds a binary with a different glibc version requirement and this results in the challenge not running in the container:
[I][2022-08-20T20:44:18+0000] Executing '/home/user/chal' for '[STANDALONE MODE]'
/home/user/chal: /lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.34' not found (required by /home/user/chal)

Yeah, for the GoogleCTF we solved this by building all challenge binaries in a Dockerfile themselves:
https://github.com/google/google-ctf/blob/master/2021/quals/kctf/challenge-templates/pwn/challenge/Makefile
We should probably upstream that change. The original motivation for it was to allow anyone to rebuild all challenge binaries without depending on certain packages on the host.

@sirdarckcat wdyt?

I feel it's a little bit weird it's in a Makefile though (I would expect the Makefile to be called within the Dockerfile, not the other way around).
We had some ideas about making all attachments "scratch" docker images iirc? Although I don't remember how we were planning to reference them


Fix a few doc mistakes

What is the purpose of the change
Fix a few things in the docs
Brief change log
Fix a few things in the docs
Verifying this change
No verification - simple doc changes.
Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): no
The public API, i.e., is any changes to the CustomResourceDescriptors: no
Core observer or reconciler logic that is regularly executed: no

Documentation

Does this pull request introduce a new feature? no
If yes, how is the feature documented? docs

Someone with merge privileges please merge after reviewing 🙏

Thanks @ryanvanhuuksloot!


how to inject other objects

How to inject other objects via Spring's annotation @Ressource on a class annotated with @ViewCOntroller

will close this issue as it's not related to JFoeinx development


Some deno.land links are broken

404 but has version - #2064

https://deno.land/x/xtr
https://deno.land/x/dxf
https://deno.land/x/dxr
https://deno.land/x/dexter

Directory not found:

https://deno.land/x/vscode_languageserver_protocol

502

https://deno.land/x/axe
https://deno.land/x/lent
https://deno.land/x/dxi
https://deno.land/x/deenvo

The ones that come in search but give 404 are weird; they have a null versions. Modules that exist but have no version are to be {latest: null, versions: []}, so this is quite weird. @lucacasonato

Yesterday<EMAIL_ADDRESS>reports 404 for me. Now it doesn't, but shows the code in wrong format:

looks like all links to code are "broken"

I don't know much about how Deno Deploy work, does it run the same code upon each request? If true, it's probably not the issue of website itself.

Yesterday<EMAIL_ADDRESS>reports 404 for me. Now it doesn't, but shows the code in wrong format:

This seems to be resolved now. isn't it?

@hyp3rflow yes, this was fixed

seems to be fixed


cmake: Only use freestanding flag on non-posix platform

Zephyr build system has always added -ffreestanding got gcc based
compilers, and then arch/posix/CMakeLists.txt would append
-fno-freestanding to Zephyr compile options.
This works well for gcc based toolchains as flags where a later
-fno-freestanding would overrule an earlier -ffreestanding flag.
With LLVM support, this is no longer possible, as clang doesn't support
a -fhosted / -fno-freestanding flag, and thus -ffreestanding would
always be added as compile flag when using clang for native_posix
builds.
This is now fix by only setting the freestanding compilation flag on
non posix SoCs.
Signed-off-by: Torsten Rasmussen<EMAIL_ADDRESS>

@nashif this should fix the issue with freestanding being set as compile flag on native posix builds you mentioned at the Toolchain wg meeting.

@tejlmand  it does not fix the issue:
FAILED: zephyr/CMakeFiles/offsets.dir/arch/posix/core/offsets/offsets.c.obj
ccache /usr/lib64/ccache/clang -DBUILD_VERSION=zephyr-v2.4.0-1586-ge27a8878d35c -DKERNEL -D_POSIX_C_SOURCE=200809 -D_XOPEN_SOURCE=60c
clang-10: error: unknown argument: '-fno-freestanding'

@tejlmand it does not fix the issue:
FAILED: zephyr/CMakeFiles/offsets.dir/arch/posix/core/offsets/offsets.c.obj
ccache /usr/lib64/ccache/clang -DBUILD_VERSION=zephyr-v2.4.0-1586-ge27a8878d35c -DKERNEL -D_POSIX_C_SOURCE=200809 -D_XOPEN_SOURCE=60c
clang-10: error: unknown argument: '-fno-freestanding'

Oh, then you see a different issue than what I experiences.
I don't see this error.
Let me try to see if I can reproduce this.

@tejlmand it does not fix the issue:
FAILED: zephyr/CMakeFiles/offsets.dir/arch/posix/core/offsets/offsets.c.obj
ccache /usr/lib64/ccache/clang -DBUILD_VERSION=zephyr-v2.4.0-1586-ge27a8878d35c -DKERNEL -D_POSIX_C_SOURCE=200809 -D_XOPEN_SOURCE=60c
clang-10: error: unknown argument: '-fno-freestanding'

Oh, then you see a different issue than what I experiences.
I don't see this error.
Let me try to see if I can reproduce this.

@nashif  Still getting this:
[7/83] ccache /opt/llvm/clang+llvm-10.0.0-x86_64-linux-gnu-ubuntu-18.04/bin/clang -DBUILD_VERSION=zephyr-v2.4.0-1585-g83e555088f36 -DKERNEL -D_POSIX_C_SOURCE=200809 -D_XOPEN_SOURCE=600 -D_XOPEN_SOURCE_EXTENDED -D__ZEPHYR__=1 -I../kernel/include -I../arch/posix/include -I../include -Izephyr/include/generated -I../soc/posix/inf_clock -I../boards/posix/native_posix -Os -imacros /projects/github/ncs/zephyr/build/zephyr/include/generated/autoconf.h -fno-common -g -imacros /projects/github/ncs/zephyr/include/toolchain/zephyr_stdint.h -Wall -Wformat -Wformat-security -Wno-format-zero-length -Wno-main -Wno-typedef-redefinition -Wno-pointer-sign -Wpointer-arith -Wno-sometimes-uninitialized -Wno-shift-overflow -Wno-missing-braces -Wno-self-assign -Wno-address-of-packed-member -Wno-unused-function -Wno-initializer-overrides -Wno-section -Wno-unknown-warning-option -Wno-unused-variable -Wno-format-invalid-specifier -Wno-gnu -Wno-tautological-compare -Werror=implicit-int -fno-asynchronous-unwind-tables -fno-pie -fno-pic -fno-strict-overflow -fmacro-prefix-map=/projects/github/ncs/zephyr/samples/hello_world=CMAKE_SOURCE_DIR -fmacro-prefix-map=/projects/github/ncs/zephyr=ZEPHYR_BASE -fmacro-prefix-map=/projects/github/ncs=WEST_TOPDIR -ffunction-sections -fdata-sections -m32 -include /projects/github/ncs/zephyr/arch/posix/include/posix_cheats.h -std=c11 -MD -MT zephyr/CMakeFiles/offsets.dir/arch/posix/core/offsets/offsets.c.obj -MF zephyr/CMakeFiles/offsets.dir/arch/posix/core/offsets/offsets.c.obj.d -o zephyr/CMakeFiles/offsets.dir/arch/posix/core/offsets/offsets.c.obj   -c /projects/github/ncs/zephyr/arch/posix/core/offsets/offsets.c

which looks correct.
Settings:
$ echo $ZEPHYR_TOOLCHAIN_VARIANT
llvm
$ echo $LLVM_TOOLCHAIN_PATH
/opt/llvm/clang+llvm-10.0.0-x86_64-linux-gnu-ubuntu-18.04/

which sample and board are you building for ?
On my side:
cmake -GNinja -DBOARD=native_posix -Bbuild samples/hello_world/

@nashif I've noticed that clang compiler flag does a check_set_compiler_property() on the empty hosted property.
I have changed this into a pure set_compiler_property() as there is no flag to check.
This ahas been changed in: https://github.com/zephyrproject-rtos/zephyr/pull/30084/commits/395337680343ceb712465acfa1fa20194b8dd1a9
If this helps, then I have a suspicion that your toolchain capabilities database might be out-of-date, which may happen if playing too much around when adding extra toolchain support.
You may try to clear: ~/.cache/zephyr/ToolchainCapabilityDatabase/
and see if the problem vanish on master.
Nevertheless I believe: https://github.com/zephyrproject-rtos/zephyr/pull/30084/commits/395337680343ceb712465acfa1fa20194b8dd1a9 should fix the issue on your side.


The project build failed because it could not download node.js

I am on a Mac M1 laptop and when I am trying to build the project if failed with the following error message.
[INFO] No proxies configured
[INFO] No proxy was configured, downloading directly
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary for cloud-native-app-initializer 0.8:
[INFO]
[INFO] cloud-native-app-initializer ....................... SUCCESS [  0.003 s]
[INFO] initializer-page ................................... FAILURE [  2.818 s]
[INFO] initializer-generator .............................. SKIPPED
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  3.902 s
[INFO] Finished at: 2023-01-10T14:28:59+08:00
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal com.github.eirslett:frontend-maven-plugin:1.10.0:install-node-and-yarn (install node and yarn) on project initializer-page: Could not download Node.js: Got error code 404 from the server. -> [Help 1]
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
[ERROR]
[ERROR] After correcting the problems, you can resume the build with the command
[ERROR]   mvn <args> -rf :initializer-page

After some googling, I figured it out it may related to https://github.com/eirslett/frontend-maven-plugin/issues/952.  Upgrading the version of frontend-maven-plugin to 1.11.0 works for me.

After fixing the issue above, I have encountered another issue:
[INFO] gyp verb `which` failed   code: 'ENOENT' }
[INFO] gyp ERR! configure error
[INFO] gyp ERR! stack Error: Can't find Python executable "python", you can set the PYTHON env variable.
 System Darwin 21.6.0
[INFO] gyp ERR! command "~/work/cloud-native-app-initializer/initializer-page/node/node" "~/work/cloud-native-app-initializer/initializer-page/node_modules/node-gyp/bin/node-gyp.js" "rebuild" "--verbose" "--libsass_ext=" "--libsass_cflags=" "--libsass_ldflags=" "--libsass_library="
[INFO] gyp ERR! cwd ~/work/cloud-native-app-initializer/initializer-page/node_modules/node-sass
[INFO] gyp ERR! node -v v10.15.3
[INFO] gyp ERR! node-gyp -v v3.8.0
[INFO] gyp ERR! not ok
[INFO] Build failed with error code: 1

It looks like node requires python.  Therefore python is another dependency for the project. After installing python I got it fixed.


Add an example to show using large_image.

Show the example as part of the README.  Test the example.
Add a missing module to setup.py.
This has basic information on how to install large_image as a python module (issue #79).

Great! LGTM!


Multilanguage BUG in the latest versions

Laravel: v5.7
Voyager: v1.2.3
PHP: 7.2
Database: MySQL 5.7

Description
When you enable multilanguage, a strange error occurs. For example, in order to edit a message, and select Russian, to switch to the Kazakh language, in translation it also shows in Russian.

Steps To Reproduce
Just enable multilanguage and create a post. Then try to edit it and switch from on language to another and then backwards.

Same here

Same here

Same here

You can try this #4077

Fixed in https://github.com/the-control-group/voyager/pull/4157
Also, duplicate of https://github.com/the-control-group/voyager/issues/4072


No Instance(s) Available.

Traceback (most recent call last):
File "C:\Users\USER\Documents\Programming\Python\LOL API\Test.py", line 16, in <module>
port = re.findall(r'"--app-port=(.*?)"', output)[0]
IndexError: list index out of range

This problem usually occurs if you are running League of Legends with Administrator rights. Running the script itself with Administrator rights should help your issue.

Read more at: f8db25e


proxy error [('SSL routines', 'tls_process_server_certificate', 'certificate verify failed')]

Hi team,
I am using company laptop to extract price data. my code is as below:
msft = yf.Ticker("MSFT")
print(msft)
msft.history(period="max", proxy="https://company_proxy_ip:8080")
but I got error: [('SSL routines', 'tls_process_server_certificate', 'certificate verify failed')]
so, I tried below code:
msft = yf.Ticker("MSFT")
print(msft)
msft.history(period="max", proxy="https://company_proxy_ip:8080", verify=False)
but still the same error, how to not to verify certificate?
Thank you,
Ling

I had an SSL error and this solution worked:
https://stackoverflow.com/questions/59642580/ssl-error-when-trying-to-fetch-stock-data-using-pandas-datareader

I had an SSL error and this solution worked:
https://stackoverflow.com/questions/59642580/ssl-error-when-trying-to-fetch-stock-data-using-pandas-datareader


[BUG] vsock network mode on fedora 33 is failing to ssh to VM

General information

OS: Linux
Hypervisor: KVM
Did you run crc setup before starting it (Yes/No)?  yes
Running CRC on: Laptop

CRC version
$ ./crc version
CodeReady Containers version: 1.21.0+074faf79
OpenShift version: 4.6.13 (not embedded in executable)

CRC config
$ ./crc config view
- consent-telemetry                     : yes
- network-mode                          : vsock
- pull-secret-file                      : /home/prkumar/pull-secret

Host Operating System
$ cat /etc/os-release
NAME=Fedora
VERSION="33 (Workstation Edition)"
ID=fedora
VERSION_ID=33
VERSION_CODENAME=""
PLATFORM_ID="platform:f33"
PRETTY_NAME="Fedora 33 (Workstation Edition)"
ANSI_COLOR="0;38;2;60;110;180"
LOGO=fedora-logo-icon
CPE_NAME="cpe:/o:fedoraproject:fedora:33"
HOME_URL="https://fedoraproject.org/"
DOCUMENTATION_URL="https://docs.fedoraproject.org/en-US/fedora/f33/system-administrators-guide/"
SUPPORT_URL="https://fedoraproject.org/wiki/Communicating_and_getting_help"
BUG_REPORT_URL="https://bugzilla.redhat.com/"
REDHAT_BUGZILLA_PRODUCT="Fedora"
REDHAT_BUGZILLA_PRODUCT_VERSION=33
REDHAT_SUPPORT_PRODUCT="Fedora"
REDHAT_SUPPORT_PRODUCT_VERSION=33
PRIVACY_POLICY_URL="https://fedoraproject.org/wiki/Legal:PrivacyPolicy"
VARIANT="Workstation Edition"
VARIANT_ID=workstation

Steps to reproduce
$ ./crc cleanup
$ ./crc setup
$ ./crc start -b ~/Downloads/crc_libvirt_4.6.9.crcbundle --log-level debug
[...]
DEBU About to run SSH command:
exit 0
DEBU Using ssh private keys: [/home/prkumar/.crc/cache/crc_libvirt_4.6.9/id_ecdsa_crc]
DEBU SSH command results: err: dial tcp <IP_ADDRESS>:2222: connect: connection refused, output:
DEBU error: Temporary error: ssh command error:
command : exit 0
err     : dial tcp <IP_ADDRESS>:2222: connect: connection refused\n - sleeping 1s
DEBU retry loop: attempt 1
DEBU About to run SSH command:
exit 0
DEBU Using ssh private keys: [/home/prkumar/.crc/cache/crc_libvirt_4.6.9/id_ecdsa_crc]
DEBU SSH command results: err: dial tcp <IP_ADDRESS>:2222: connect: connection refused, output:
DEBU error: Temporary error: ssh command error:
command : exit 0
err     : dial tcp <IP_ADDRESS>:2222: connect: connection refused\n - sleeping 1s
DEBU retry loop: attempt 2
DEBU About to run SSH command:
exit 0
DEBU Using ssh private keys: [/home/prkumar/.crc/cache/crc_libvirt_4.6.9/id_ecdsa_crc]
DEBU SSH command results: err: dial tcp <IP_ADDRESS>:2222: connect: connection refused, output:
DEBU error: Temporary error: ssh command error:
command : exit 0
err     : dial tcp <IP_ADDRESS>:2222: connect: connection refused\n - sleeping 1s
DEBU retry loop: attempt 3
DEBU About to run SSH command:
exit 0
DEBU Using ssh private keys: [/home/prkumar/.crc/cache/crc_libvirt_4.6.9/id_ecdsa_crc]
DEBU SSH command results: err: dial tcp <IP_ADDRESS>:2222: connect: connection refused, output:
DEBU error: Temporary error: ssh command error:

Expected
Should able to ssh on 2222 port.

As per https://github.com/mdlayher/vsock#requirements following kernel modules should be removed from hypervisor.
modprobe -r vmw_vsock_vmci_transport
modprobe -r vmw_vsock_virtio_transport_common
modprobe -r vsock

But in current fedora box which actually created by vhost_vsock setup. Once I run crc cleanup this entry no longer exist.
 $ sudo lsmod | grep vsock
vhost_vsock            24576  0
vmw_vsock_virtio_transport_common    40960  1 vhost_vsock
vsock                  49152  2 vmw_vsock_virtio_transport_common,vhost_vsock
vhost                  57344  2 vhost_vsock,vhost_net

Do you something in the crc daemon logs ? Is the VM connected to it ?

Do you something in the crc daemon logs ? Is the VM connected to it ?

@guillaumerose No, there is no crc daemon is running so no logs around it.

You have to start crc daemon manually or you won't get any network connectivity.

@cfergeau yes looks like when I am going through the wiki, I didn't notice the daemon process required but it is there.
Run the daemon in a separated terminal
crc daemon

Closing it, will try the ssh which @jsliacan is mentioned in internal communication channel.


Update the "users" / "use cases" field in machine-learning-model component

Proposal: based on research of model cards across HuggingFace, Google, and Meta, there seem to be a common way of breaking down usage: "direct/intended use," "out of scope" usage, and "misuse / malicious use."
Request: Remove the "users" and "use cases" fields, and replace them with the model below:
"usage" : [
"intended-use": "how is the model intended to be used, primary use case.",
"out-of-scope": "out of scope usage.",
"misuse-or-malicious": "examples of usage considered to be misuse or malicious use."
]
Required: True
Type: Array of strings.

Remove the "users" and "use cases" fields

That would be a breaking change which would have to wait until v2.0.
CycloneDX is aligned to the Tensorflow Model Toolkit and VerifyML, both of which support machine readable model cards supporting both "users" and "use cases".
See:

https://github.com/tensorflow/model-card-toolkit/blob/main/model_card_toolkit/schema/v0.0.2/model_card.schema.json#L104-L113
https://github.com/cylynx/verifyml/blob/main/verifyml/model_card_toolkit/schema/v0.0.4/model_card.schema.json#L61-L74

I'd be happy to add additional fields if necessary.

@stevespringett here are some examples:

Llama2:

Model cards on HuggingFace, Meta, and beyond seem to break things down into Intended Use, Out of Scope, and Misuse/Malicious Use. No mention of "users," and I'm not sure what model developers would regularly put in that field.


Fix errors related to encoding of missing music

Adds fixes to the script for two cases:

Two few hyphens between 6's in a volpiano string would cause the missing music section not to be recognized.
Line, page, or column breaks after a missing music section would lead an error to be thrown on attempted alignment.

Fixing these cases provided an opportunity to simplify how the script deals with spacing around missing music and barlines:

"proper" spacing is no longer enforced during preprocessing or during sectioning
all spacing is now done in the postprocessing step

In the course of making these fixes, also discovered a way to remove a branch in the _align_section function
Closes #19
Also, provides an update for the test case visualization html that makes it easier to view long test cases.

I see that at least some of your functions are labelled by what they return, but all of the variables in this pull request are unannotated.

Goooood catch....this is why we do code review!!! :)


feature: support node metadata sync

[ ] I have registered the PR changes.

Ⅰ. Describe what this PR did
增加集群间元数据同步能力
1.leader选举成功后，生成只包含它自身的元数据，该元数据为一个单例，并同步至follower
2.follower收到这个元数据后，发送自身的元数据至server侧，进行补充follower的元数据
3.leader收到后，在元数据的follower中增加该节点，并推送元数据变更至client和其它tc节点
并且元数据中增加version字段，用于后续比如存在新旧多版本server，leader可以在同步的时候使用所有节点都能支持的协议，以便向下兼容。
Increase the ability of inter-cluster metadata synchronization

After the leader election is successful, generate metadata containing only itself, which is a singleton and synchronized to followers
After the follower receives this metadata, it sends its own metadata to the server side to supplement the follower's metadata.
After the leader receives it, add the node to the follower of the metadata, and push the metadata changes to the client and other tc nodes
And the version field is added to the metadata for subsequent use. For example, if there are old and new multi-version servers, the leader can use a protocol that all nodes can support during synchronization for backward compatibility.

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews

Codecov Report
Attention: Patch coverage is 41.79104% with 78 lines in your changes are missing coverage. Please review.

Project coverage is 52.35%. Comparing base (a866c2d) to head (222ef08).
Report is 1 commits behind head on 2.x.

Additional details and impacted files

@@             Coverage Diff              @@
##                2.x    #6326      +/-   ##
============================================
- Coverage     52.40%   52.35%   -0.05%
- Complexity     5245     5251       +6
============================================
  Files           924      928       +4
  Lines         32066    32170     +104
  Branches       3833     3845      +12
============================================
+ Hits          16805    16844      +39
- Misses        13608    13671      +63
- Partials       1653     1655       +2

Files
Coverage Δ

...g/apache/seata/server/cluster/raft/RaftServer.java
81.57% <100.00%> (+0.49%)
:arrow_up:

...cluster/raft/sync/msg/dto/RaftClusterMetadata.java
89.28% <100.00%> (-10.72%)
:arrow_down:

...e/seata/server/cluster/raft/RaftServerManager.java
86.13% <60.00%> (+0.42%)
:arrow_up:

...raft/processor/request/PutNodeMetadataRequest.java
42.85% <42.85%> (ø)

...in/java/org/apache/seata/common/metadata/Node.java
84.21% <0.00%> (-15.79%)
:arrow_down:

...cluster/raft/serializer/JacksonBoltSerializer.java
40.00% <40.00%> (ø)

...ft/processor/response/PutNodeMetadataResponse.java
0.00% <0.00%> (ø)

...er/raft/processor/PutNodeInfoRequestProcessor.java
27.27% <27.27%> (ø)

...he/seata/server/cluster/raft/RaftStateMachine.java
51.75% <45.78%> (-10.75%)
:arrow_down:

... and 5 files with indirect coverage changes


[UNR-4666] Read schema bundle file to get the component sets

Description
Parsed the schema.json created after running the schema compiler in order to extract the actual content of the component sets.
Tests
Ran functional tests to ensure no regression.

On testing- the extract component sets function at least appears testable given dummy files. Could we add unit tests for this?

On testing- the extract component sets function at least appears testable given dummy files. Could we add unit tests for this?

Schema generation is ran every time CI runs, and we have dedicated errors for schema generation failures, so what could this unit test catch that the CI would not?

Schema generation is ran every time CI runs, and we have dedicated errors for schema generation failures, so what could this unit test catch that the CI would not?

The unit test could catch (that AFAIU wouldn't be caught by generating schema):

an output map which is missing a component set.
an output map which has put a component in a component set it shouldn't have.
etc.
specifically simple things that are nice sanity checks to make sure if anyone does touch this generation code, they can be confident it still works

The unit test could catch (that AFAIU wouldn't be caught by generating schema):

an output map which is missing a component set.
an output map which has put a component in a component set it shouldn't have.
etc.
specifically simple things that are nice sanity checks to make sure if anyone does touch this generation code, they can be confident it still works

That's still not a test worth writing IMO. Not on a sample file that is. Just reading the code gives me more confidence than the test you described passing.
One that would be though, is testing what we get when running on one or two well-known classes. Do we get the expected components in the expected component sets, and do we get all the component sets. And that is relevant to the GDK because it would provide a targeted cause of error and speed up analysis of other tests failing because of this. And it would actually fail every now and then and make people maintain it.
Maybe I can slide such a test in the existing schema ones. I'll have a look.

That's still not a test worth writing IMO. Not on a sample file that is. Just reading the code gives me more confidence than the test you described passing.
One that would be though, is testing what we get when running on one or two well-known classes. Do we get the expected components in the expected component sets, and do we get all the component sets. And that is relevant to the GDK because it would provide a targeted cause of error and speed up analysis of other tests failing because of this. And it would actually fail every now and then and make people maintain it.
Maybe I can slide such a test in the existing schema ones. I'll have a look.


Fix to support hot reload with vim editor changes

This is a proposed fix for #150.
vim is a standard way to update configuration files on servers, so -hotreload not being able to properly handle updates with vim seems like a nuisance.
vim operates on a temporary file and when user saves changes it first renames and removes original file and then renames temporary file with the original name. As a result, file inode changes and inotify/fsnotify don't pick up the change.
Proposed fix adds a 100ms delay on rename event, so the updated file can be put in place of an old one, before checking for its existence. If file exists, hooks are reloaded and watcher updated with new file (because it has new inode).
On linux, webhook received a delete event, which is a "leftover" from renaming and removing the original file. As we monitor file based on its name, not inode, the check is added to see if the monitored file was indeed deleted before unmonitoring it.
I've tested it both on macos and linux, and it worked correctly in all my tests.
Let me know if this solution works for you.

Nice workaround :-)


JS: Barrier guard improvements

A few improvements to barrier/sanitizer guards, motivated by recent query work:

Support arbitrarily many && and || operators in sanitizer guard functions
Generalize sanitizer guard functions to work with any data-flow configuration and flow labels.
Support reflective calls in barrier guards

Commit-by-commit review recommended.
Evaluation was uneventful. Columns 1 and 2 correspond to this PR, and column 3 is another commit that I dropped again.

The tests are failing.
ql/javascript/ql/test/library-tests/TaintBarriers/SanitizingGuard.ql: Test failure (Expected output does not match)
ql/javascript/ql/test/library-tests/TaintBarriers/TaintedSink.ql: Test failure (Expected output does not match)
ql/javascript/ql/test/library-tests/TaintBarriers/isBarrier.ql: Test failure (Expected output does not match)

Indeed. Seems to be benign changes though.

Any comments apart from the asExpr() tangent?


Prepare @kadena/kda-cli for alpha release

@EnoF do we still need to release this?

We don't need to release this just yet for the upcoming event. So I'm marking this PR as draft for now.

Can't mark it as draft... so I'll close it for now :sweat:


Migrate the old '/Contributors' endpoint to v2

Description
Implements #286

Call v2/contributors from the frontend
Remove the old API /contributors

Type of change

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)

thank you for suggestion 🙏


render_labels returns uniform color in large images

Hi,
I'm embedding the segmentation output of Cellpose into a SpatialData object as a labels SpatialElement. In my case I'm working with a 2D segmentation mask, where 0 corresponds to the background and pixels belonging to the same cell are indexed with the same number.
I noticed, that if I want to visualize all masks using sdata.pl.render_labels().pl.show(), the masks appear in a pink color. However, when I crop the object to contain only a particular (small enough) FOV, the cells are visualized nicely using random colors. This issue is related to the size of the image, not the number of cell masks to be plotted. The following is a minimal reproducible example:
import numpy as np
from spatialdata import SpatialData
from spatialdata.models import Labels2DModel
import spatialdata_plot

np.random.seed(seed = 0)
n = [11, 101, 1001, 1501, 2001]

fig, axs = plt.subplots(nrows = 1, ncols = len(n), figsize = (15,15))
for ax_ind, l in enumerate(n):

    # Create a random mask (simulating a cellpose segmentation output)
    # Every number corresponds to a cell index
    mask = np.random.randint(1, l**2 + 1, size=(l, l))

    # Add a big cell in the middle that should be visible in larger images
    center = (l // 2) + 1
    start = int(center - 0.5 * center)
    end = int(center + 0.5 * center) - 1

    uniform_value = l**2 + 1
    mask[start:end, start:end] = uniform_value

    # Create a SpatialData object
    mask_parsed = Labels2DModel.parse(mask)
    labels = {"mask": mask_parsed}
    sdata = SpatialData(labels = labels)

    sdata.pl.render_labels().pl.show(ax = axs[ax_ind])
    axs[ax_ind].set_title(f"l = {l}")
    axs[ax_ind].axis("off")

Somewhere in between ~1500^2 and ~2000^2 pixels, the function does not render the labels properly anymore. As all my images are larger than that, I currently can't render all labels (there are workarounds though). Also, as a sidenote, in the l=11 condition, it is visible that the pixels are shifted by half a pixel, which is probably related to #216.
I am working with:
python = 3.12.3
spatialdata = 0.2.2
spatialdata_plot = 0.2.4
It would be great if there was a fix for that. I appreciate the help & thanks in advance!

I've observed this previously as well but on my end this was fixed by subsequent releases of spatialdata_plot, so it might be worth to update to a more recent release and see if the problem persists.

I updated spatialdata_plot to 0.2.7.dev6+g80c6f77 and now it works, thanks!


[SCB-352] refactor QpsControllerManager, support operation level qps controll on provider side

Follow this checklist to help us incorporate your contribution quickly and easily:

[x] Make sure there is a JIRA issue filed for the change (usually before you start working on it).  Trivial changes like typos do not require a JIRA issue.  Your pull request should address just this issue, without pulling in other changes.
[x] Each commit in the pull request should have a meaningful subject line and body.
[x] Format the pull request title like [SCB-XXX] Fixes bug in ApproximateQuantiles, where you replace SCB-XXX with the appropriate JIRA issue.
[x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
[x] Run mvn clean install to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
[x] If this contribution is large, please file an Apache Individual Contributor License Agreement.

Refactor QpsControllerManager and support operation level qps flow control on provider side.
https://issues.apache.org/jira/browse/SCB-352

Coverage increased (+0.03%) to 87.249% when pulling bc0496708fb6d9ff75401064d9bbd6b9cd3d4aa3 on yhs0092:support_provider_operation_level_flow_control into 83ae473e27889734d8cc0ecf428cd2538d26b1a4 on apache:master.


VirtIO GPU DOD vs QXL

Is the VirtIO GPU DOD controller superior to the QXL controller? Is there any information you can provide in regard to the viogpudo driver and the performance differences?
Is there a signed version available to download?
Can you add support for these resolutions?

I was reading kraxel's blog post virtio-gpu and qemu graphics in 2021 regarding the new virtio-vga and virtio-vga-gl devices in qemu 6.1.

Second, blob resource support for the simple virtio-vga device is in progress, and it will bring support shared resource mappings to qemu. This will accelerate the display path due to less or no copying of pixel data.

Will the "blob resource support" improve the performance of this driver?

You are probably asking about<EMAIL_ADDRESS>Unfortunately, this feature will not be able to improve 2d rendering on Windows VMs

As for me virtio gpu dod is a base for the future improvement and extension to
a Full Graphics or Render-Only WDDM driver

Is any plan for this?  I really need a full graphics WDDM driver because DOD driver's capability is so limited, more and more applications i can't run in VM(e.g. some application request VMR9).

@BruceMok Sorry, the full graphics driver (with DirectX support) is not on a visible horizon.

@matheuswillder I don't think there is an open issues. You can added.
In any case, technically QXL is not virtio-win driver and not managed in this repo, although our installer includes it. This is a project page: https://gitlab.freedesktop.org/spice/win32/qxl-wddm-dod
For virtio-gpu you can create an issue here.

@matheuswillder Thanks! The title looks OK.


Don't add a new logger to winston, just return the transport

This is for a project using actionhero, which allows you to configure logging by adding winston transports. The winston function tries to add the logger to winston directly, which breaks things. This pull request changes it to return a new transport instead, which can then be used however the caller wants.

This PR is not applicable to the new codebase. The actual transport instance is no longer added to Winston, only its constructor (in accord with existing Winston conventions). The user now has control of how a single transport instance is added to Winston.


Support custom redirect URI

Is your feature request related to a problem? Please describe.
Instead of relying on a local server waiting for the authorization code, an app might want to handle the adquisition of this code in a different way:

Custom HTML rendered by the backend
Custom URI scheme in the app

Describe the solution you'd like
I'm thinking on providing a RedirectHandler interface that can customize how the authorization code + state is obtained and provides it to the library so that it continues the auth flow.
The current implementation with the localhost server could be adapted to this interface as a default behavior.
instance.redirectHandler = MyRedirectHandler(...)

import 'package:google_sign_in_platform_interface/google_sign_in_platform_interface.dart';

abstract class RedirectHandler {
  /// Initialize the handler, this could involve spinning up a server to listen for the redirect
  Future<void> init();
  /// Dispose of any resources used by the handler
  Future<void> dispose();

  Uri getRedirectUri();

  /// Obtain the redirect data from Google
  Future<AuthorizationCodeResponse> waitForAuthorizationCode();

  /// Once we have an user, we might want to customize the HTML response
  Future<void> finishFlow(GoogleSignInUserData userData);

  /// If there is an error during the process, an HTTP response could also be customized
  Future<void> onError(Object error, StackTrace stackTrace);
}

class AuthorizationCodeResponse {
  final String? code;
  final String? state;
  final String? error;

  bool get isError => error != null;

  AuthorizationCodeResponse(String this.code, this.state) : error = null;

  AuthorizationCodeResponse.error(String this.error)
      : code = null,
        state = null;
}

I would like to continue having a local server as the only available implementation for the meantime as that is the approach that Google recommends for macOS, Linux, Windows.

To receive the authorization code using this URL, your application must be listening on the local web server. That is possible on many, but not all, platforms. However, if your platform supports it, this is the recommended mechanism for obtaining the authorization code.

That being said I think that it would definitely be useful to be able to customise the HTML that gets rendered after the authorisation code has been successfully received by the application.

When your app receives the authorization response, for best usability it should respond by displaying an HTML page that instructs the user to close the browser and return to your app.

I would like to continue having a local server as the only available implementation for the meantime as that is the approach that Google recommends for macOS, Linux, Windows.


[Idea] Among Us memory library

I was wondering if we can separate classes that read the game memory into a separate class library project and ship it as a NuGet package.
It would be nice to have a central package that the community can maintain and use to build awesome tools.

Yeah that would be pretty neat. Among us capture is in itself kind of a module

Yeah that would be pretty neat. Among us capture is in itself kind of a module


Limit the number of segment builds on a server

Default behavior is to keep this unlimited. However, in some use cases that may have
a loq latency requirement, with a high QPS, and also a large number of columns, we
may incur heavy GC pauses during segment builds.
The only down-side of enabling this limit is that we will pause the consumption if
segment build is delayed on the committer. Since we are consuming on a per-partition
basis, the consumption should catch up quickly.
Alternative is to add more servers.

Codecov Report

Merging #2039 into master will decrease coverage by 0.07%.
The diff coverage is 53.19%.

@@            Coverage Diff             @@
##           master    #2039      +/-   ##
==========================================
- Coverage   69.76%   69.69%   -0.08%
==========================================
  Files         830      830
  Lines       40079    40097      +18
  Branches     5402     5405       +3
==========================================
- Hits        27961    27944      -17
- Misses      10258    10287      +29
- Partials     1860     1866       +6

Impacted Files
Coverage Δ

.../core/segment/index/loader/IndexLoadingConfig.java
84.81% <100%> (+0.59%)
:arrow_up:

.../starter/helix/HelixInstanceDataManagerConfig.java
92.1% <100%> (+0.21%)
:arrow_up:

...manager/realtime/LLRealtimeSegmentDataManager.java
68.36% <48.83%> (-1.28%)
:arrow_down:

...in/pinot/core/query/reduce/NotEqualComparison.java
55.55% <0%> (-11.12%)
:arrow_down:

...kedin/pinot/core/util/SortedRangeIntersection.java
83.82% <0%> (-7.36%)
:arrow_down:

...e/impl/dictionary/LongOnHeapMutableDictionary.java
87.23% <0%> (-6.39%)
:arrow_down:

...impl/dictionary/FloatOffHeapMutableDictionary.java
84.21% <0%> (-5.27%)
:arrow_down:

.../impl/dictionary/LongOffHeapMutableDictionary.java
89.47% <0%> (-3.51%)
:arrow_down:

...e/operator/dociditerators/SortedDocIdIterator.java
61.11% <0%> (-2.78%)
:arrow_down:

.../impl/dictionary/BaseOffHeapMutableDictionary.java
75.8% <0%> (-2.69%)
:arrow_down:

... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d9b5d4d...d965a45. Read the comment docs.


Create Documentation for the collapsable component

Scope:
Ganesha will create documentation for the collapsable.
Vasanth will review the documentation

Thanks Vasant for bringing this to my notice- you'll have the document ready to review on monday

Reviewed and enhanced the documentation
Updated here https://www.notion.so/appsmith/Collapsible-8f367eec7cd14dd7889f740a33086ae7?pvs=4

Can we please close this issue and move this to the main board so that this issue can also be tracked in zenhub board?


What is Word2Vec

This Fixes #1609
Article checklist
NOTE: (Please ensure that you have only one open issue + linked pull request at a time. This will ensure that we complete the article in a timely manner from inception to publishing.)
Preliminary Checks - Formatting and Structure

[x] Does your article follow any of the suggested structure formats? - see example formats
[x] Is your article properly formatted in Markdown? - see Github Markdown guide
[x] Have you used the correct folder and file structure? - see Contribution Guidelines
[x] Is your article over 750 words? - Tool: Wordcounter.net
[x] Have you used our preferred heading structure? - H3 (###) and up
[x] Does your article provide enough value and detail about your topic? - Articles should be clear, accurate, and fully explained.
[x] Can your article be understood by beginners? - Assume the audience is smart but has no prior exposure to the common terminology in your article.
[x] Have you included a hero image that is 600x400 pixels and have the copyright to use it? - Tools: Pixlr Image Editor for resizing and Unsplash for Creative Commons images
[x] In your PR - add a comment that states "This fixes #(enter your Idea Content Form #)" to link and close your Idea Content (issue) when the PR is merged.

Grammar & plagiarism checks

[x] Have you spellchecked and grammar checked your article? - Tools: Write&Improve - ProWritingAid -  Grammarly
[x] Have you placed your article through a 3rd party plagiarism checker? We suggest using Quetext, this tool is free and has a daily limit. We typically accept articles with 10% or less.
[x] Have you checked your article for readability? - Tool: Hemmingway
[x] Have you added sources for quotes and images that aren't yours?

Technical checks

[x] Are your code snippets properly formatted for syntax highlighting - see Syntax guide

Contribution guidelines
For first-time contributors and for more details, see Contributing Guidelines

@wilkistermumbi Great work and welcome to the EngEd program again.
Please be sure to check out our resources pages if you haven't already for more neat resources to explore.
cc @collins-a


Add gitignore for simulator

When building the simulator, per INSTALL.md, ~2K files are generated by Vitis/Vivado and picked up by git, which can make version control and keeping track of changes very inconvenient.

Retargeted this to the dev branch. Otherwise all okay

Noticed a small problem with this - if a new TCL file is added and starts with build_ it will also be be ignored.


I have created a cpp wrapper for ion c and a cpp implement for ion hash. hope it will help somebody.

I have created a cpp wrapper for ion c and a cpp implement for ion hash. hope it will help somebody.
https://github.com/wukakuki/ion-hash-cpp

Great work! Keep going!

Hi @wukakuki, thanks for telling us about your project.
Once your project gets further along, if you would like your project to be considered for addition to the list of community supported Ion projects, please open a PR (like this one) in the ion-docs repository.


feat: Add gene migration incomplete banner (#241)

Reviewers
Functional:
@tihuan
Readability:
@seve

Changes

add Banner component that shows the incomplete gene migration banner on specific collections.
modify collection component to show the banner to "data consumers".

Definition of Done (from ticket)
Banner shown for specified collections.
QA steps (optional)
Locally:

Run locally and add local collection ID to INCOMPLETE_GENE_MIGRATIONS_COLLECTIONS.
Go to the collection page on data portal. Banner should be displayed.

Rdev:

https://ypark-rdev-frontend.rdev.single-cell.czi.technology/collections/50b7e0d4-ecc8-4576-a815-6529e02c883c
https://ypark-rdev-frontend.rdev.single-cell.czi.technology/collections/423cdd2a-d096-4e87-a9a9-18e5168b45e7

@tihuan Thank you!!!


Try it out button not working using root_path with ApiGateway

First Check

[X] I added a very descriptive title to this issue.
[X] I used the GitHub search to find a similar issue and didn't find it.
[X] I searched the FastAPI documentation, with the integrated search.
[X] I already searched in Google "How to X in FastAPI" and didn't find any information.
[X] I already read and followed all the tutorial in the docs and didn't find an answer.
[X] I already checked if it is not related to FastAPI but to Pydantic.
[X] I already checked if it is not related to FastAPI but to Swagger UI.
[X] I already checked if it is not related to FastAPI but to ReDoc.

Commit to Help

[X] I commit to help with one of those options 👆

Example Code
#main.py

from fastapi import FastAPI
from fastapi.openapi.utils import get_openapi

from test_api.router import *

logger = logging.getLogger(__name__)

app = FastAPI(
    title="test_API",
    root_path="/test",
)

app.include_router(router)

description = """
Test API overview
"""

def custom_openapi():
    if app.openapi_schema:
        return app.openapi_schema
    openapi_schema = get_openapi(
        title="Test API",
        version="0.0.1",
        description=description,
        routes=app.routes,
    )
    openapi_schema["info"]["x-logo"] = {
        "url": "https://fastapi.tiangolo.com/img/logo-margin/logo-teal.png"
    }
    app.openapi_schema = openapi_schema
    return app.openapi_schema

# assign the customized OpenAPI schema
app.openapi = custom_openapi

#router.py

import logging

from fastapi import APIRouter

logger = logging.getLogger(__name__)

router = APIRouter(
    prefix="/test",
)

@router.get(
    "/health_check",
)
def root():
    return {"status": "Success"}

Description
We are using FastAPI alongside ApiGateway on AWS. We have multiple APIs being handled by one Custom domain name so we are required to use API mappings with specific Paths.
With the configuration shown all the routes for the API works as well as the documentation or getting the openapi.json file. The only issue is when trying to execute the API from the docs page with the "Try it out" option. Is not adding the prefix so every request is ending up with a 404 error.

We tried working with routes as well, but this ends up duplicating the prefix and we don't want that.
After more testing we found that the issue could be related to the custom_openapi function, if we remove it, the try it out button works. But the rest of the docs does not.
Is there any kind of parameter we could use inside this definition to achieve the addition of the prefix only to the execute part without having the need to add a router since this causes the prefix to be duplicated.
The request would look like this:
curl --location --request GET 'http://<IP_ADDRESS>:9999/test/test/health_check'
Operating System
Linux
Operating System Details
No response
FastAPI Version
0.88.0
Python Version
Python 3.8
Additional Context
No response

Following your solution I agree that the problem could be the custom_openapi function inclusion and it is probably causing the issue because it seems you don't need it. You could try just deleting custom_openapi call (and also definition if you want) and include the API description under app -description- param.  Otherwise in such the case you want to keep using custom_openapi you should continue extending documentation also for paths to "override" the path that doesn't include the prefix from root_path and include the one that includes the path prefix manually, just like this:
`description = """
Test API overview
"""
def custom_openapi():
if app.openapi_schema:
return app.openapi_schema
openapi_schema = get_openapi(
title="Test API",
version="0.0.1",
description=description,
routes=app.routes,
)
openapi_schema["info"]["x-logo"] = {
"url": "https://fastapi.tiangolo.com/img/logo-margin/logo-teal.png"
}
openapi_schema["paths"]["/test/health_check"] = {
'get':
{'summary': 'Root',
'operationId': 'root_health_check_get',
'responses': {
'200': {
'description': 'Successful Response',
'content': {
'application/json': {
'schema': {}
}
}
}
}
}
}
openapi_schema["paths"]["/health_check"] = {}
app.openapi_schema = openapi_schema
return app.openapi_schema
assign the customized OpenAPI schema
app.openapi = custom_openapi`
Hope this helps!


Allow use of big int in rails notation

Currently not possible to use BigInt in rails notation.

I'm not quite following what this PR does. The GraphQL does not have the data type BigInt while the graphql-ruby gem does have one. There are also a few third-party bigint implementations in the npm world. What are the relations to them and how does this PR make graphlient better?

@lax1n Add a test that maybe demonstrates how this is a good idea for Graphlient?

I'm not quite following what this PR does. The GraphQL does not have the data type BigInt while the graphql-ruby gem does have one. There are also a few third-party bigint implementations in the npm world. What are the relations to them and how does this PR make graphlient better?

You're completely right!
I can add that my motivation for adding support for BigInt in ruby notation was that I was working on an integration with TheGraph where this scalar type was required and ended up doing a monkey patch to make it work on my end.
That being said, I have not done enough research on the matter to make a case for this PR anymore so I'll close it for now.
Thanks for the feedback!


[ZEPPELIN-1725] replace cleanDirectory with forceDelete

What is this PR for?
At times while updating dependency from Interpreter settings page it fails with
ERROR [2017-02-24 12:56:03,503] ({Thread-87} InterpreterFactory.java[run]:550) - Error while downloading repos for interpreter group : jdbc, go to interpreter setting page click on edit and save it again to make this interpreter work properly. : Unable to delete file: /home/prabhu/zeppelin-server/local-repo/2CBX1E3VP/jcip-annotations-1.0.jar
java.io.IOException: Unable to delete file: /home/prabhu/zeppelin-server/local-repo/2CBX1E3VP/jcip-annotations-1.0.jar
        at org.apache.commons.io.FileUtils.forceDelete(FileUtils.java:2279)
        at org.apache.commons.io.FileUtils.cleanDirectory(FileUtils.java:1653)
        at org.apache.zeppelin.interpreter.InterpreterFactory$3.run(InterpreterFactory.java:550)

Hence, I propose to replace cleanDirectory with forceDelete
What type of PR is it?
[Bug Fix]
What is the Jira issue?

ZEPPELIN-1725

How should this be tested?
Try adding and removing dependency say "org.apache.hive:hive-jdbc::standalone:1.2.1000" in JDBC interpreter, it does not fails always, but once in a while.
Screenshots (if appropriate)
N/A
Questions:

Does the licenses files need update? N/A
Is there breaking changes for older versions? N/A
Does this needs documentation? N/A

LGTM

Merging this to master and branch-0.7 if no more discussion.


Cannot control TypeProperties even with a custom binder

I was trying to figure out why AutoBogus was doing nothing with the RepeatedField<T> type (a protobuf type). I created my own binder to try and take control of the situation, but it never even called GetMembers.
Digging into the code a bit, I found that this line does not pass the provided binder onto the base class. Therefore, the base class uses the default binder to populate TypeProperties. Hence, I never get a chance to even tell it that I want to populate my RepeatedField<T> instances.
By changing the above line to this:
: base(locale ?? AutoFaker.DefaultLocale, binder)

I got around my problem. However, when I went to PR this, I noticed a couple of tests broke, and I was then well and truly out of my depth.
Any thoughts on this? Ultimately, I just want my RepeatedField<T> instances to populate like any other list would.

Actually, digging further into this, it seems the library doesn't cater for get-only properties at all. Even if I override GetMembers to include my repeated field properties, the current designs I want to create a new RepeatedField<T> instance rather then just read the one that's already there (and add values to it).
Moreover, the entire AutoGeneratorFactory infrastructure is internal, making it hard to generate values with which to populate the repeated field.

Hi Kent,
Following the thread from twitter. Could you post an example model and/or object graph of what you're trying to create with RepeatedField<T>? I'm having a little trouble synthesizing the problem and object models you're looking to create. Also, I'm sorry, I don't have much experience with protobuf.
From best I can discern, you're looking to create something like this?
void Main()
{

   var fooFaker = new Faker<Foo>()
                  .RuleFor( x => x.SomeField, f => new RepeatedField<int>() )

   //When you call .Generate, you want the RepeatedField<T> instace created
   //in the lambda above to be set on a get-only property of an instance of Foo.SomeField?
   var foo = fooFaker.Generate();
}

public class Foo{

   public Foo(){

      //You don't want this particular instance of RepeatedField<T>
      //that is set here in the constructor. Instead,
      //you want a new, populated, and seperate instance of RepeatedField<int>
      //that has been created outside this constructor initialization to
      //be set as SomeField?
      this.SomeField = new RepeatedField<int>();
   }

   public RepeatedField<int> SomeField {get;}
}

Let me know.
PS. I'll try to keep my posts on this issue terse to avoid hijacking Nicks' repo/issue tracker. :)
Thanks,
Brian

Hi @bchavez.
When you define a proto with a repeated field like this:
message Foo {
    repeated string bar = 1;
}

It generates code along these lines:
public class Foo
{
    private readonly RepeatedField<string> bar = new RepeatedField<string>();
    public RepeatedField<string> Bar => bar;
}

Typically you have a lot of these fields, so manually specifying rules for each one is not an option. Instead, I'd need an interception point provided by the framework that allows me to identify any get-only property of type RepeatedField<T> and provide population logic.

Hey @kentcb
Thanks for your message. I have considered extending the AutoGeneratorFactory to allow for custom value generation, I just didn't have a use case. It looks like you might be needing that use case, so I will see what I can do.
@bchavez thanks for your input again, much appreciated and always welcomed 👍
Nick.

Hi @kentcb
I finally found some time to look into addressing your use case. I have made some code changes that allow you to register an override for a type generator (included the built in generators).
In the case of your example above you would implement the following:
public class Foo
{
    private readonly RepeatedField<string> bar = new RepeatedField<string>();
    public RepeatedField<string> Bar => bar;
}

AutoFaker.AddGeneratorOverride<Foo>(context =>
{
    var foo = new Foo();
    foo.Bar.Add("VALUE");
    return foo;
});

That should provide an entry point for customizing the generation of a given type. Does that work for you? If so, I will publish a new version to NuGet.
Nick.

Hi @nickdodd79. Thanks for doing this and for getting back to me.
First, I should tell you that I had to move on to another solution (I went with AutoFixture because I could get it to work the way I wanted, albeit a bit cumbersome). So it's not really practical for me to try this out any more.
However, I would say this looks along the lines of what I was trying for. But I wouldn't want to have to register an override for every type that uses RepeatedField<T>. I'd want to register a 'global' handler that can populate repeated fields for any type.

Hi @kentcb
Thanks for the feedback. Yes, that would make total sense in terms of verbosity of setting up a generic type. I see what rework I can put in place to address it.
Thanks again.
Nick.

Out of curiosity, can you post a code sample of how you achieved your requirement. Thanks.

Sure, it looks like the below. Notice that it's a more generalized solution to work with any get-only collection property. It's possible this could be simplified, but I'm not sure how. See this discussion on the AutoFixture repo for even more context.
    // Populate get-only collections, such as Protobuf repeated fields
    internal sealed class GetOnlyCollectionsCustomization : ICustomization
    {
        public void Customize(IFixture fixture)
        {
            fixture.Customizations.Add(
                new FilteringSpecimenBuilder(
                    new Postprocessor(
                        new MethodInvoker(
                            new ModestConstructorQuery()),
                            new GetOnlyCollectionsCustomizationFiller()),
                    new GetOnlyCollectionsSpecification()));
        }

        private sealed class GetOnlyCollectionsCustomizationFiller : ISpecimenCommand
        {
            public void Execute(object specimen, ISpecimenContext context)
            {
                Ensure.ArgumentNotNull(specimen, nameof(specimen));
                Ensure.ArgumentNotNull(context, nameof(context));

                var allProperties = specimen
                    .GetType()
                    .GetProperties(BindingFlags.Public | BindingFlags.Instance | BindingFlags.GetProperty)
                    .ToList();

                var getOnlyCollectionProperties = allProperties
                    .Where(property => !property.CanWrite)
                    .Where(property => property.PropertyType.IsGenericType && property.PropertyType.GenericTypeArguments.Length == 1)
                    .Where(property => typeof(IList).IsAssignableFrom(property.PropertyType))
                    .ToList();

                var nonCollectionProperties = allProperties
                    .Where(property => property.CanWrite)
                    .Except(getOnlyCollectionProperties)
                    .ToList();

                foreach (var getOnlyCollectionProperty in getOnlyCollectionProperties)
                {
                    var list = (IList)getOnlyCollectionProperty.GetValue(specimen);

                    if (list == null)
                    {
                        continue;
                    }

                    var enumerableType = typeof(IEnumerable<>).MakeGenericType(getOnlyCollectionProperty.PropertyType.GenericTypeArguments[0]);
                    var items = (IEnumerable)context.Resolve(enumerableType);

                    foreach (var item in items)
                    {
                        list.Add(item);
                    }
                }

                // Fill in the remaining properties.
                foreach (var nonCollectionProperty in nonCollectionProperties)
                {
                    var value = context.Resolve(nonCollectionProperty.PropertyType);
                    nonCollectionProperty.SetValue(specimen, value);
                }
            }
        }

        private sealed class GetOnlyCollectionsSpecification : IRequestSpecification
        {
            public bool IsSatisfiedBy(object request)
            {
                var requestType = request as Type;

                if (requestType == null)
                {
                    return false;
                }

                var getOnlyCollectionProperties = requestType
                    .GetProperties(BindingFlags.Public | BindingFlags.Instance | BindingFlags.GetProperty)
                    .Where(property => !property.CanWrite)
                    .Where(property => property.PropertyType.IsGenericType && property.PropertyType.GenericTypeArguments.Length == 1)
                    .Where(property => typeof(IList).IsAssignableFrom(property.PropertyType))
                    .ToList();

                return getOnlyCollectionProperties.Count > 0;
            }
        }
    }

It's registered like this:
                var fixture = new Fixture()
                    .Customize(new GetOnlyCollectionsCustomization());

Awesome. Thanks.

Hey @kentcb
If you are ever interested in using AutoBogus again, I have just released v2.3 which includes the ability to define generator overrides. An example of how to applies these to generics can be found in the Playground project.
I'll close this issue now.
Nick.


Add Docker file validation on PRs

We should use github actions for this. We are building and running tests on appveyor right now on PRs, but this does not include the docker file.
I think eventually we should move everything to github actions, but this would be a good start and give us extra coverage.
I just want to make sure whatever changes are made still let the compression container build so something like this should work
$ docker build -f Dockerfile.CompressImages . -t imgbot

We should use github actions for this. We are building and running tests on appveyor right now on PRs, but this does not include the docker file.
I think eventually we should move everything to github actions, but this would be a good start and give us extra coverage.
I just want to make sure whatever changes are made still let the compression container build so something like this should work
$ docker build -f Dockerfile.CompressImages . -t imgbot

bump

Bump


Ruby 2.2 support

Incorporates https://github.com/DatabaseCleaner/database_cleaner/pull/319

Cucumber tests are failing on ruby 2.2. Trying to find a solution.

A bunch of deprecation warning have appeared on ruby 2.2 (see https://travis-ci.org/DatabaseCleaner/database_cleaner/jobs/46837177). Most of them are related to two gems: cucumber and activesupport.


Sarah afiya/feature/llm implementation

The last 5 commits are of this branch (commits from Feb 15)

@snadi I addressed your feedback from here and also refactored the templates (now reading the templates from the template directory rather than having them hard-coded).
I somehow messed up commits while trying to rebase, I think I fixed it now, you should see only the file changes and commits related to LLM implementation here now. Could you please give it another look and approve if it's okay?

and yes, I can see only the commits related to the LLM evaluation


Config DEPENDENCIES variable incosistent with current jobs

The config template DEPENDENCIES variable is missing some jobs (e.g. TomcatExtractionJob, RedisExtractionJob, SSHDExtractionJob)

Never mind, these don't have external dependencies. Closing this out.


Show user's predicted rating when click on extension

Users can provide their username. After that whenever they click on the LC Predictor extension icon the pop page should also show the user's predicted rating for the latest contest.
It can be achieved by doing this:

User can enter/edit username on options/popup page.
Whenever the pop page is opened, the extension calls API for getting the latest predicted rating and shows it. A new endpoint can be added or we can utilize the existing endpoint in the backend api.

Hi, I'd like to work on this


Permission denied with 2.7.0

When installing kscript via:
sdk install kscript

Things worked great for version 2.6.0, whereas I had a Kotlin script that began with the following header:
#!/usr/bin/env kscript

Unfortunately something seems to have changed, as now with 2.7.0 I'm getting the following error when I try to run Kotlin scripts:
/usr/bin/env: 'kscript': Permission denied

(this was seen on a CI system so it is from a fresh install of kscript, not an upgrade)

Indeed. There seems to be an issue with the sdk installation. I'll update it shortly.
The 2.7.0 release is also 43× the size of the previous one!

Ouch! That has bit me today as well!

@hho the size increase is due to the change in dependeny resolution. kscript does not rely on maven but is using aether instead.

Fixed and released to sdkman as v2.7.1. Tested in docker container and seems fine now.
Sorry for inconvenience.

Thank you! :-)

I'm on holidays atm but I'll remove 2.7.0 from sdkman when I get to a computer. Alternatively, someone can simply raise a PR on our DB migrations repo.


route.tsx changes whether trailing slashes are required in links to index.tsx

Describe the bug
With file-based routing, foo/route.tsx changes whether links to foo/index.tsx must be /foo/ or /foo:

If foo/route.tsx does not exist, foo/index.tsx can be linked to only with /foo/, not /foo.
If foo/route.tsx does exist, foo/index.tsx can be linked to only with /foo, not /foo/.

Your Example Website or App
https://stackblitz.com/edit/github-fzqvge?file=src%2Froutes%2F__root.tsx
Steps to Reproduce the Bug or Issue

Use file-based routing.
In a directory that has an index.tsx, create a route.tsx.

Expected behavior
In the given StackBlitz example, I expected either

the trailing slash to always be required, or
the trailing slash to never be required,

i.e. I did not expect the presence of route.tsx to change the links to index.tsx.
Screenshots or Videos

Platform
StackBlitz
Additional context
No response

fyi, I have a similar setup but we use trailingSlash: 'always' and that seems to work better for us:
https://stackblitz.com/edit/github-fzqvge-yfunzp?file=src%2Fmain.tsx,src%2Froutes%2F__root.tsx
basically, without an index.tsx route, you can't navigate there at all. That makes sense to me because route.tsx is just a layout that renders something + an outlet. Once you have an index.tsx page, even if it renders () => null, you have a concrete route to navigate to.
There seems to be an additional bug though with the types when there is just an index.tsx but no route.tsx. The types seem to be a bit off, because I get these as possible to targets:
"/nested-with-route/" | "/flat-with-route/" | "/" | "./" | "../" | "/nested-no-route//" | "/flat-no-route//" | undefined'. Did you mean '"/flat-no-route//"'

note that the -no-route routes have two slashes at the end 😅 .
@chorobin this might be something to look at

We did see some new type errors after upgrading to v1.32.2 which led me to this experiment, so quite possibly yes. (I did not test this with pre-v1.32.2.)

Yep. I know where to fix it.  Not all index routes should have a trailing slash I guess. Only those that uniquely identified by one


UI fails to load fully on latest Chromium

Hello! Thank you for this amazing extension, I've been using it for years now.
As of a month or two ago, the UI does not load properly. More specifically, my bookmarks are not loading, and the extension can't be properly interacted with:

I'm running Brave 1.66.113 which is based on Chromium 125.0.6422.76.
Thanks!

After some months, it's working again on Brave 1.69.153, based on Chromium 128.0.6613.85.


Linux  Centos

installed in postgres home dir trying to compare two schemas same db.
./pgdiff -U postgres  -H localhost -D testdb -O "sslmode=disable" -S public -O "sslmode=disable" -u postgres  -h localhost -d testdb -s  dynapp TABLE
getting permision denied   ./pgdiff.sh: Permission denied
ls -l
total 11140
-rwxrwxrwx 1 postgres postgres 6552040 Nov 17 01:42 pgdiff
-rwxrwxrwx 1 postgres postgres    2816 Feb  9 16:06 pgdiff.sh
-rwxrwxrwx 1 postgres postgres 4842856 Nov 17 01:42 pgrun
-rwxrwxrwx 1 postgres postgres     857 Nov 17 01:42 README.md

That is very odd given that the permissions are 0777 for pgdiff.sh and pgdiff.  Let me know what you figure out.

-bash-4.2$ ./pgdiff  -V
-bash: ./pgdiff: Permission denied
-bash-4.2$ ./pgdiff.sh  -V
-bash: ./pgdiff.sh: Permission denied
-bash-4.2$

strangest thing is root gets the same issue
[root@dyn-l-ma-pdb-001 pgdiff]# ./pgdiff.sh  -V
-bash: ./pgdiff.sh: Permission denied
[root@dyn-l-ma-pdb-001 pgdiff]# ./pgdiff  -V
-bash: ./pgdiff: Permission denied
[root@dyn-l-ma-pdb-001 pgdiff]#

That is really strange.  It almost has to be something wacky with your Linux.

I think I might see problem is installing go a requirement?

No, it's not a requirement to install go if you use one of the released binaries.


binding does not need to be mutable

r? @alexcrichton
(rust_highfive has picked a reviewer for you, use r? to override)

@bors: r+

:pushpin: Commit bd8b866 has been approved by alexcrichton

:hourglass: Testing commit bd8b866 with merge 8ec10dc...

:sunny: Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing 8ec10dcb8cf6dae898681f69663aa667203ebc26 to master...


cqerl is not listed as a dependency @ hex.pm

cqerl is not listed as a dependency @ hex.pm: https://hex.pm/packages/cqex
Because of that, I need to explicitly add cqerl as a dependency of my application.
Is this correct??

It is correct. To not include it, I would have to add cqerl to hex.pm, but I can't because a couple of its dependencies are not available in hex.pm: semver and re2.


[.NET] Generated .xml files

Platform
What platform is your issue or question related to? (Delete other platforms).

[ ] .NET

Details
When building .NET, the following .xml doc files are generated. These should either be not generated or deleted, added to the repo, or added to .gitignore to avoid noise:
        dotnet/Library/AdaptiveCards.Templating/docs/AdaptiveCardsTemplate.xml
        dotnet/Library/AdaptiveCards/docs/AdaptiveCards.xml

for reference, they're supposed to get deleted
https://github.com/microsoft/AdaptiveCards/blob/9e898e5eeec12e3be0f2cdfd9d757bc364c1af41/source/dotnet/Library/AdaptiveCards/AdaptiveCards.csproj#L18-L19
not sure why they aren't. ultimately, it's not really important. we can add them to the project or ignore them. it's not really interesting to track changes over time, though, since they're generated files...


Verifying the integrity of our blockchain.

Need a way to check the integrity of our blockchain.
isChainValid()

added