WIP Escoria wizard

Features:
Character creator

Creates a character from one or more spritesheets for 4 or 8 direction characters
Requires creation of walk, speak, idle animations to avoid errors in Escoria when playing a game and an animation  is missing
A collision box is created automatically based on largest animation frame
A dialog ESC Location node created automatically (currently 20%  of the character's height above their sprite)

Room creator

Rooms will be automatically created in the folder specified in "Room Selection Room Dir" Escoria setting, but can be modified from the interface. (If having the wizard using and change this setting is problematic as it will break the initial intent of this configuration setting, I'll externalise the setting)
A folder will be created for the room called [room name], with "scripts" and "objects" subfolders.
An ESCCharacter will be linked to the ESCRoom if selected
An ESCBackground will be created. A background sprite will be configured if selected
If the option to use a room ESC script is chosen, a template file will be copied into the scripts folder with the name selected
An ESCTerrain will be created with an empty Navigation Polygon 2D child
An empty Node2D "RoomObjects" node will be created for non-inventory items

Item creator

Allows for both inventory and room object items to be created. They only differ in where the resulting objects are created.
Inventory items will be created in the configured inventory item folder (which can be modified in the interface)
Room object items will be created as a child of the currently selected node in the current scene
An ESCLocation will be created (2 x sprite size below the image) for an interaction location
A rectangular collision shape will be created, matching the sprite size

I was planning on having a "new game" helper, but I'll leave that for v2.
Thoughts/feedback/bug fixes welcome.

Export of characters is currently buggy. Also need to retest items create correctly.


Replace ParameterProvider with static class accessible from everywhere

To better support param set/get make it a static class e.g. ParameterHolder

Fixed.


Migrate from .xproj + project.json to .csproj

Migrate project to the new VS2017 .NET Core project format. Migrated using official .NET Core migration tool.

Project builds with the new project file...I don't know if deployment works but it copies the DLL to the NuGet folder correctly so I would have to assume it should.


Make addresslib Python 3 compatible

This PR makes flanker/addresslib Python 3 compatible.
The current functionality when running in Python 2 is not changed. In Python 3 we expect text inputs (str) and all methods that return string types (str/unicode) in Python 2 are returning str unconditionally.
The only problem that I have not yet fixed is that ASCII separator symbols 0x1c, 0x1d, 0x1e, 0x1f for some reason became allowed in the display name in Python 3.

This is amazing news. Is there a sense of when Python 3 support may be released?

@pudo I am working on it. Although we at Mailgun do not use Python 3, so this is a side project for me.
@b0d0nne11 could you please take a look at the changes.

If flanker now has full python 3 compatibility, would it be possible to possible to push a new release to PyPi such that it can be easily installed via pip?

@JamesMcGuigan unfortunately Flanker does not have full Python 3 compatibility yet. Only a limited set of packages is Python 3 compatible. I have not been able to continue the work due to lack of time.


Add memory allocations to printPlanWithStats

Include number of memory allocations per operator in the output of
printPlanWithStats.


QUESTION: how to properly fetch attachment content in 1.0?

Hi there,
in 0.8 I used this function within the Attachment object:
from salesforce.backend.driver import handle_api_exceptions
...
class Attachment (salesforce.models.Model):
    ...
    def fetch_content(self):
        session = connections['salesforce'].sf_session
        url = session.auth.instance_url + self.body
        blob = handle_api_exceptions(url, session.get)

        return blob

but in 1.0 this does not seem to be valid as there is no definition for the handle_api_exceptions function in there.
How would be the appropriate way of fetching the Attachment content in 1.0?

Followup .. I have a working code, turned the above into:
from salesforce.backend.utils import CursorWrapper
...
class Attachment (salesforce.models.Model):
    def fetch_content(self):
        cursor = CursorWrapper(connections['salesforce'])
        url = cursor.session.auth.instance_url + self.body
        blob = cursor.handle_api_exceptions('GET', url)

        return blob

but it somehow still feels hacky .. is there a "better" way?

You can also use a simpler code
connections['salesforce'].connection.handle_api_exceptions('GET', url)

That simpler code works if the connection has been used since the application start. (the connection attribute exists) That is not sure with setting SF_LAZY_CONNECT = True, but it is perfect enough for the Attachment object.
I leave it open for a docs note or wiki.

Thanks for the reply!

The link to docs is https://github.com/django-salesforce/django-salesforce/wiki/Documents-and-Attachments

I've had some similar trouble in using the ContentVersion object to provide a url,
I've had to go through the route of using simplesalesforce as the Django style requests were failing.
I'd like to tidy the following code up using Django-salesforce, do you have any recommendations?
class ArticleDetailView(LoginRequiredMixin, DetailView):
    login_url = reverse_lazy("login")
    model = AlumniSpotlightArticle
    template_name = "core/article_detail.html"
    context_object_name = 'article'

    def get_context_data(self, **kwargs):
        # Get the existing context from the superclass method
        context = super().get_context_data(**kwargs)

        # Get the current article object
        article = self.get_object()

        # Retrieve attachments related to this article
        # cdls = ContentDocumentLink.objects.sf(minimal_aliases=True).filter(linked_entity_id__in=[article.id])
        # the above line fails

        query = f"""
            SELECT ContentDocumentLink.Id, ContentDocumentLink.LinkedEntityId, ContentDocumentLink.ContentDocumentId
            FROM ContentDocumentLink
            WHERE LinkedEntityId = '{article.id}'
        """

        cdls = ContentDocumentLink.objects.raw(query)

        # Extract ContentDocumentId
        docId=  []
        for cdl in cdls:
            docId.append(cdl.content_document_id)

        # vers=ContentVersion.objects.get(content_document_id='069VA00000193feYAA')
        ver_query = f"""
            SELECT Id, Title, VersionData, VersionDataUrl FROM ContentVersion WHERE ContentDocumentId='{docId[0]}'
        """
        vers = ContentVersion.objects.raw(ver_query)

        # Authenticate and get the session ID
        sf = Salesforce(
            username=sf_params['username'],
            password=sf_params['password'],
            security_token=sf_params['security_token'],
            consumer_key=sf_params['consumer_key'],
            consumer_secret=sf_params['consumer_secret'],
            domain=sf_params['domain']
        )

        documents=[]
        for version in vers:
                # Fetch the actual file data
                version_data_url = f"{version.version_data_url}"
                headers = {'Authorization': f'Bearer {sf.session_id}'}
                response = requests.get(version_data_url, headers=headers)

                if response.status_code == 200:
                    if response.content:
                        content_type = response.headers['Content-Type']
                        if content_type.startswith('image/jpeg'):
                            image_data = response.content
                            documents.append({
                                'Title': version.title,
                                'FileData': image_data,
                                'MimeType': content_type
                            })
                    else:
                        print("Empty response content for URL:", version_data_url)
                else:
                    print("Failed to fetch data for URL:", version_data_url)

        context['documents'] = documents
        return context

        ```

        Thanks

Thank you @brendon-seo-usa, that is an excellent hint for me because I didn't use these objects and I wasn't interested in it. I will write and verify a solution in a remaining hour today or sometimes tomorrow.

Fortunately I fixed yesterday the code of the query compiler that is related also to your today's problem. I fixed it because I implemented yesterday a more exact compiler for evaluating group expressions by date periods like
some_queryset.values('date__year', 'date__quarter').annotate(total=Sum('amount'))
It is committed in the main branch now. A new version 5.0.2 will be released soon.
Your query ContentDocumentLink.objects....filter(linked_entity_id__in=...) works with it now.
The command ContentVersion.objects.get(content_document=...) did not work for you because a document can have more versions. You need .filter() instead of .get().
The field VersionDataUrl in the raw query is for opening the file in a browser with enabled Javascript. You need to use the field VersionData and combine it with https://your...salesforce
Your code related to django-salesforce can be very short:
cdls = ContentDocumentLink.objects.sf(minimal_aliases=True).filter(linked_entity_id__in=[article.id])
vers = ContentVersion.objects.filter(content_document__in=cdls)
connection = django.db.connections['salesforce'].connection
documents = []
for version in vers:
    if version.file_extension in ('jpg', 'jpeg'):
        ret = connection.handle_api_exceptions('GET', version.version_data)
        if ret.status_code == 200:
            documents.append({
                'Title': version.title,
                'FileData': ret.content,
                'MimeType': 'image/jpeg',
            })

EDIT: You probably want to display only the latest version of every document. Therefore I added the condition is_latest=True to the code above.


postgres last inserted id : "RETURNING id" vs "lastval()"

"RETURNING id" is more safe and reliable
"lastval()" can cause some issues with triggers
https://www.postgresql.org/docs/current/dml-returning.html
https://github.com/sqlkata/querybuilder/blob/master/QueryBuilder/Compilers/PostgresCompiler.cs
https://stackoverflow.com/questions/17819001/postgres-not-returning-lastval-properly
https://stackoverflow.com/questions/2944297/postgresql-function-for-last-inserted-id

Yes, it is. But the "id" keyword is not a constant, it is the name of the real table column. So in this case we have to change function design to support referencing to primary key column name.

yes rewriting the function will fix that.

Rewriting the function can propose losing back compatibility, and may be very specific compiler features.

Hello, thanks for developing this project.
For those who are in trouble right now on this issue, I would like to introduce my workaround.
I made extension method for postgres specific InsertGetId instead of rewriting the library core.
public static class QueryExtensions
{
    public static async Task<T> InsertGetIdPostgresAsync<T>(
        this Query query,
        object data,
        string idColumn,
        QueryFactory db,
        IDbTransaction transaction = null,
        int? timeout = null)
    {
        var compiledQuery = db.Compiler.Compile(query.AsInsert(data));
        string sql = compiledQuery.Sql + $" RETURNING {idColumn}";

        var row = (await db.SelectAsync<InsertGetIdRow<T>>(
            sql,
            compiledQuery.NamedBindings,
            transaction,
            timeout
        )).First();

        return row.Id;
    }
}

public async Task<int> InsertAsync(MUser entity)
{
    var query = Db.Query("M_USER");

    int id = Db.Compiler.EngineCode switch
    {
        // PostgreSQL
        EngineCodes.PostgreSql =>
            await query.InsertGetIdPostgresAsync<int>(
                data: entity,
                idColumn: "ID",
                db: Db,
                transaction: Transaction),
        // Other
        _ => await query.InsertGetIdAsync<int>(entity, Transaction)
    };

    return id;
}

Thanks

lastval() also causes issues on postgres tables without sequences, such as when a UUID is used as the ID.
CREATE TABLE my_table
(
    id UUID NOT NULL DEFAULT gen_random_uuid()
);

Trying to insert a row with returnId set will lead to a failed insertion with the following error:
55000: lastval is not yet defined in this session

lastval() also causes issues on postgres tables without sequences, such as when a UUID is used as the ID.
Trying to insert a row with returnId set will lead to a failed insertion with the following error: 55000: lastval is not yet defined in this session

That's all, because the lastval() returns a bigint, not a UUID. You cannot get the last UUID value added with this method.


Fixed bugs in agent bootstrap kubeconfig flow

fixed the user home dir substitution
added list permission for byoh-csr-creator-clusterrole
added the cert/key under appropriate keys in kubeconfig

What this PR does / why we need it:
few issues were discovered while manually testing the host-agent with the new bootstrap flow.

Codecov Report

Merging #566 (cba259d) into main (b09a31d) will increase coverage by 0.16%.
The diff coverage is 94.11%.

@@            Coverage Diff             @@
##             main     #566      +/-   ##
==========================================
+ Coverage   67.22%   67.38%   +0.16%
==========================================
  Files          27       27
  Lines        2346     2358      +12
==========================================
+ Hits         1577     1589      +12
  Misses        665      665
  Partials      104      104

Impacted Files
Coverage Δ

agent/main.go
19.55% <0.00%> (ø)

agent/registration/csr.go
84.09% <100.00%> (+1.59%)
:arrow_up:


bump version to 22.11.0 and update maintainers

Checklist

[x] Used a personal fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[x] Reset the build number to 0 (if the version changed)
[x] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[x] Ensured the license file is being packaged.

@conda-forge-admin, please rerender

@unkcpz Do you want me to merge this?

@csadorf yes, please. Thanks a lot!


add building and uploading windows installer to CI

This adds a plain WiX installer configuration with a suitable license, name & homepage, and is my attempt to extend the release workflow to build and ship it.
Open tasks:

[x] Test the release process @brokad
[ ] ~Add a link to the website~
[ ] ~code-sign the installer (?) This would require a key signed by microsoft and remove the intimidating warning about installing an unsigned binary from the install process~

LGTM. Gotta update the links now to point to the msi.


feat: useWindowScroll - for cross-browser compatibility

For cross-browser compatibility, use window.pageYOffset instead of window.scrollY.
(https://developer.mozilla.org/en-US/docs/Web/API/Window/scrollY)

:tada: This PR is included in version 10.2.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


[BUG] Daily Set not 100% complete (Test your smarts quiz)

Let me just start by saying that I absolutely love this script! Keep up the great work!
I noticed that the farmer doesn't complete all of the daily set quizzes, namely the "Test your smarts" quiz.

Is there any way to get it to double check if all the daily set was completed and if not, to try and complete any remaining sets? Or atleast a way to fix it so that it does all of them? Another way could be that it checks whether or not your current streak has changed after the daily set, and if it hasn't, to try to complete the missing set again. Thanks!

I wasn't aware of this type of quizz so the script does not handle it.
What's your country ?

My country is the United States.

My country is the United States. I think this is one of the newer quizzes. I haven't heard of it either until these past few days.

Ok thanks, I am going to add it very soon.

No problem! Thanks for responding so quickly!

You can try my latest commit : )

Awesome thank you!
I already did today's quizzes but will for sure check again on it tomorrow and let you know!

Checked today and the daily set is now working beautifully! Thank you so much!


Program application review page changes

There are two "Continue" buttons on the program application review page in the applicant experience. Both buttons are problematic: https://docs.google.com/presentation/d/1goxiepPXPrW3wK8wUSNoCpcf7iXIohXfj96iTYiQxo0/edit#slide=id.gfa7bf315fa_0_1862
There is a smaller "Continue" button that takes the applicant to that particular question (it's the last question). This should be replaced by "Edit" to match the other questions.
Then there is the larger blue "Continue" button at the bottom of the page that currently takes the applicant to the start of the application, which is unexpected. This button should take the applicant to where they were previously -- the last page of the application where they can submit it.

Rochester UXR confirms the need for this. Research participants were thrown off by the highlighted rows and unclear CTAs ("Continue" vs "Edit")

Another suggestion from UXR is to add edit icons (i.e. a pencil)

To be clear the changes are:

Remove highlighting of the skipped questions and replace it with an alert icon to indicate it needs extra attention.
Larger Continue button at the bottom should take applicant to where they were previously
Replace smaller continue to edit to match other questions (so it always says edit regardless of whether question was skipped or not)
Add edit icons (pencils) next to the edit button.

@kristinyim @rahaghas can you link me to the icons that we should use?

I suggest changing "Continue" to "Submit application" and throw an error if that button is pressed before all required items are completed (as opposed to disabling it, which can often cause user confusion). I also suggest changing the "Continue" used currently for individual unanswered questions with "Answer" and add a trailing "arrow forward" icon.
Here's a mock:

Here are the necessary icons:
Edit: https://fonts.google.com/icons?selected=Material Symbols Outlined%3Aedit%3AFILL%400%3Bwght%40400%3BGRAD%400%3Bopsz%4048
Arrow forward: https://fonts.google.com/icons?icon.query=arrow

I have to pause my work on this issue for the time being to focus on higher priority items.
I've made some progress in https://github.com/seattle-uat/civiform/tree/azizoval/1920/reviewpage, but more work is needed. That branch introduces table-like formatting, but doesn't yet properly handle all cases on mobile.

any status updates on this?


Add gRPC client-side load balancing doc

Work in progress.
Internal preview URL: https://review.docs.microsoft.com/en-us/aspnet/core/grpc/loadbalancing?view=aspnetcore-3.0&branch=pr-en-us-22348

@Rick-Anderson This feature is getting closer to being released. Could you take another look at this PR? I've rewritten parts and added new sections.

service config is the right name for this

OK, will that localize?  It sounds like well known jargon to me. Your call. All my suggestions are .... suggestions :)

Service config - https://github.com/grpc/grpc/blob/master/doc/service_config.md
I don't know about localizing.

That's jargon but that's OK, we're not allowed to change the term. On first use you need to link to that page. It's going to blow up localization. I'm tempted to code fence the jargon. @IEvangelist  @tdykstra  do you have a recommendation ?

That's jargon but that's OK, we're not allowed to change the term. On first use you need to link to that page. It's going to blow up localization. I'm tempted to code fence the jargon. @IEvangelist David Pine FTE @tdykstra Tom Dykstra FTE do you have a recommendation ?

I agree with @Rick-Anderson - it's the "service configuration", "config" is short for "configuration" obviously, but it's okay that the it refers to the grpc.service_config.ServiceConfig. If @JamesNK doesn't want it changed, just mark it as non-loc.

@wadepickett  can you resolve the warnings on this PR. Don't @mention james if you have questions, just me or someone on the team. I'm on VAC, so someone on the team is best.

@Rick-Anderson, I fixed the validation issues.  Builds fine now for this draft PR.

That's jargon but that's OK, we're not allowed to change the term. On first use you need to link to that page. It's going to blow up localization. I'm tempted to code fence the jargon. @IEvangelist David Pine FTE @tdykstra Tom Dykstra FTE do you have a recommendation ?

I agree with @Rick-Anderson - it's the "service configuration", "config" is short for "configuration" obviously, but it's okay that the it refers to the grpc.service_config.ServiceConfig. If @JamesNK doesn't want it changed, just mark it as non-loc.

If it's a non-localizable technical term, it might be helpful to define it on first use. What it is and what it does isn't obvious then from the words themselves.

Hi @JamesNK .  This pr has a status of "draft" so I'm not jumping in yet.  Do you intend for it still be be draft, or need any help?  Just checking in to see what I can do.  :)

Waiting for feature to be publicly available

@Rick-Anderson @wadepickett Ok to merge?


[1.21][Neoforge] Crash when add extra slot via config

I tried to add some extra ring slots but that crashes the game

If I add the ring slots and I try to /reload the game, or try to join a world with that addition on the configs, the game automatically crashes.
Log:https://pastebin.com/F3muv14Y
accessories-neoforge-1.0.0-beta.25+1.21.jar
accessories_cclayer-9.0.5-beta.5+1.21
neoforge 21.0.157

Hmmm a StackOverflowError Ill have to investigate cause as I never had issues within testing

Released a fix for such an issue.


[FR] A better way instead of  while True: sess.run(..)

I'd like to make tensorflow as the inference backend, and there are quantities of inference inputs to handle.
Currently, tensorflow manages multiple inference inputs as different execution triggers of sess.run, e.g:
while True:
    sess.run(infer_op)

However, the throughput is very bad because every inference task will run through python runtime and also tensorflow scheduler, so I require something like this directly:
    sess.run(tf.loop_forever(infer_op))

You can assume the infer_op read inputs from an one_shot_iterator, and I never want this loop to stop just like it is a long-run server.
Anyway to do this at the moment, or the possibility to support this op like tf.loop_forever ?
You can also share a simple hack in tensorflow source code to make the sess.run (in C++ session) to repeat same computing again without returning data to python session. Thanks!

tf.loop_forever might not be a valid TF_OP that decorates a compute graph, so I think this solution might be reasonable:
sess.run(infer_op, loop_forever=True)

Using tf.while_loop(0 < 1, ..) might be a little ugly to understand, and it also requires to check the answer for each run of the body, which is not
so strongly suggest creating an OP named tf.loop_forever() not to wait and check the answer very time, and this is very necessary for GPU-based operator because we don't want to launch unnecessary kernels to do this meaningless check, or copy device memory to host memory and related synchronization.

I think tensorflow doesn't have a break statement. So implementing an operation for which the only way of stopping it is by killing the process seems to go against a lot of principles.
I don't think the overhead of checking a simple condition like tf.while_loop(True, ..) is going to be noticeable.

@Gonzalo933 An ugly problem for tf.while_loop(True, body, ..) is there are output shape restriction among cond, body and loop_vars, and I have to output something from body for checking even if it is not needed, thus it doesn't support many existing ops while a ideal tf.loop_forever should be expected to support.
Just a example, tf.group it can be the final wrapper of train_op to get away with I/O sychronization from GPU to CPU after the body terminates its execution, but tf.while_loop doesn't work for this case:
train_op = tf.matmul([[4]], [[5]])
graph = tf.group(train_op)

loop = tf.while_loop(lambda i: True, lambda i: body=graph, [])
sess.run(loop)

So how to make tf.while_loop work like tf.loop_forever(any_op)?

I think tensorflow doesn't have a break statement. So implementing an operation for which the only way of stopping it is by killing the process seems to go against a lot of principles.
I don't think the overhead of checking a simple condition like tf.while_loop(True, ..) is going to be noticeable.

Everything is noticeable in TF. It shouldn't be, but it is. There are unintended consequences for everything.

There are 2 problems using tf.while_loop than ideal tf.loop_forever:

Performance: while_loop has to wait for a body answer before it can decide whether to schedule another body execution, so this is apparently in a synchronous style which is much inefficient to feed tasks to GPU, so the latency between adjacent body execution is high;
Not for all TF_Ops: it can not fully support all operations so it should not be a good loop_forever alternative;

I think either enhancing while_loop or extending loop_forever is needed, otherwise, TF engine would be only good in terms of offline batch processing, not efficient for lots of tasks with low-latency requirement.

break statement is not needed because the sess.run could be break or interrupt by any long-run operators that can return non-OK status, so the task could be terminated and handled by a surrounding try: .. expect: .. which is not strange.

I think the solution should be extending an loop_forever for struct RunOptions, and if it is enabled, the RunAsync implementation in direct_session.cc could be looping executed.
Another advantage for support loop_forever is that it could fully replace the Tensorflow C++ programming which is very uncommon (also, complex tool chain is needed, source code is needed, building takes too much time, ..) to most users.
Tensorflow can development a series of stateful operators not pass through python runtime, which could engine most long run services efficiently using Tensorflow engine.
If tf.loop_forever breaks some graph principles, this option should be set at sess.run(.., run_forever=True) which is not enabled by default.
Any agreement? or any supporting plans? If true, I volunteer to handle this feature.

Closing this issue as per mrry's comment in the PR 26561. Thanks!


Cleanup end of infilling notebook

The end of the infilling notebook from #20 isn't as clear as it could be. This goes on the todo list so we can keep moving.

It's certainly radically different by now


Remove www. from link in readme

There is no www.gunnhacks.com, but there is gunnhacks.com

www.gunnhacks.com exists now


request a new release

It has been a while (five years) since last beta release, I wonder if there is any new release plan, also I can help introduce this tool into homebrew-core, thanks!

relates to

#161

I think it's pretty safe to say at point that it's more or less abandoned,
at least by me. I started a new version in Rust, but it's low priority.
On Sun., Jun. 27, 2021, 12:01 rui, @.***> wrote:

It has been a while (five years) since last beta release, I wonder if
there is any new release plan, also I can help introduce this tool into
homebrew-core, thanks!
relates to

#161 https://github.com/iagox86/dnscat2/issues/161

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/iagox86/dnscat2/issues/164, or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAEAQTB5Y2ELNYAI2IIWRBLTU5YOXANCNFSM47MVKBVA
.

I see, that is good to know. Closing my issue then. Thanks!


Command arguments with a default value require a prompt value

When filling in arguments for a command and setting a default value for one of them (while keeping prompt to undefined), this throws an error:
TypeError: Argument prompt must be a string.
    at Function.validateInfo

Command code:
const Commando = require("discord.js-commando");

module.exports = class KickCommand extends Commando.Command {
	constructor(client) {
		super(client, {
			name: "kick",
			group: "mod",
			memberName: "kick",
			description: "Kick a member from the server.",
			guildOnly: true,
			userPermissions: ["KICK_MEMBERS"],

			args: [
				{
					key: "offender",
					label: "the member to kick",
					prompt: "Which member would you like to kick?",
					type: "member"
				},
				{
					key: "reason",
					label: "the reason for kicking the member",
					type: "string",
					default: ""
				}
			]
		})
	}

	run(msg, { offender, reason }) {
		console.log(offender, reason)
	}
};

@TheMrEvgen That is the issue. You shouldn't need to put in a prompt if you're already setting a default value.

This is intentional, as there is a planned feature to allow users to force-prompt arguments for a command.


Expander with Left, Right and Up expand directions?

Unlike the native Expander control the Handycontrol expander seems to have only a Downward expansion. I want to to have a right-sidewise expansion. The following code doesn't work.
<expander ExpandDirection="Right"/>.
And sometimes I may even need a left-sidewise expansion.
Anyway I can have a sidewise expansion?

Is this feature added yet?

Is this feature added yet?

Is this feature added yet?

not yet we are a bit busy but we will add it😉

Is this feature added yet?

not yet we are a bit busy but we will add it😉

Ok Thank you.

Ok Thank you.


ANTify tooltips

Added tooltip to report modal
Issue #53

When you replace the tooltips, please check where the tooltips are in the application (in a corner, or in the middle) and adjust the tooltip position if necessary (e.g. <Tooltip placement="topRight" ...>), and also if the tooltip is helpful immediately, or should have a delay (for example, an icon can have a immediate tooltip, whereas additional information on a label can have a delay) (<Tooltip mouseEnterDelay={0.5} ...>


Only Forsaken Moos Spawning in the End

[x] I am using a release version of the mod
[x] I have mods that integrate with this installed:

[x] Tinker's Construct
[x] Mine Factory Reloaded
[x] Mine Addons
[x] Moo Fluids
[x] Waila
[x] Avaritia

[x] I also have other mods installed
[x] I have searched for this issue previously and it was either (1) not previously reported, or (2) previously fixed and I'm having the same problem.
[ ] I am crashing and can provide my crash report(s)

Additional Information

[x] Java Version:

[ ] Java 6
[ ] Java 7
[x] Java 8

[x] Minecraft Version:

[x] 1.10.2

Issue Description
Forge <IP_ADDRESS>8
Foolcraft 2 Modpack
In the End, the only moos I can find with the current version of Mini Moos (1.3.3) are Forsaken Moos, and even these seem to be rather rare. I spent a good 30 to 40 minutes exploring the end looking for mini moos, and in that time, found only Forsaken Moos. When I downgraded back to 1.2 (I'm not sure if other versions of 1.3 will have this problem or not), I found a cluster of normal moos within a minute or two.
It might be worth mentioning that I hadn't entered the End prior to using 1.3.3.

Reproduce Steps
Start a new world, go to the End, slay the Dragon, and hunt for moos in 1.3.3.

Additional Information
Love the mod, hope this wont be too hard to fix.

@chimeralchimera Send me your config file for the minimoos, it might be a problem there.

Okay, here you go.
minimoos.zip

@chimeralchimera Did you add any new mods to the pack? There isn't a problem in the config, and that is strange because in my server, they keep on spawning with no problem.

The only thing I've added is Optifine. I would have mentioned it earlier, but I forgot until you asked if I added anything (^_^;). It seems strange that it wouldn't cause any problems with 1.2 but would with 1.3.3 though.
The only other things I can think to mention are that I'm playing on a singleplayer world and that I'm running it through MultiMC because Twitch kept having a bunch of problems, and I could never get it to run through it.

@chimeralchimera I will check that and then I will get back to you. Optifine and MultiMC shouldn't be a problem.

@chimeralchimera I just uploaded a new version 1.4.1 that should fix those issues. Should be available shortly.

Awesome, thanks!


DX: move report schemas to dedicated dir

so they are not randomly populating the doc folder

Thank you @keradus.


remove bad chars [,.] from the utterance

We don't want to unconditionally remove all characters - some are actually meaningful (think decimal separators), and we don't want to replace with nothing cause that would merge two consecutive words. We need to be more careful with this.

I think this is still too aggressive. I think we really only want to catch the case of a period that is added as an artifact by MS STT in between two words without spaces. And you don't need to clean up spaces, later tokenization of the sentence will take care of that.
Also, I feel like this is such an artifact of the MS backend that I would do it in the cloud speech API, not here, in a random place in the middle of Genie.


Ct testing

For testing, to test some changes via cluster test.  This is not to be reviewed

/canary

:sunny: Canary successful

/canary

:sunny: Canary successful

/canary

:sunny: Canary successful

No longer needed for now, closing


Nonsensical reformed queries from Reformulator

I am trying to get the reformulations from the reformulator but I get all nonsensical reformulations like this-

My questions were- ['how can i apply for nsa?', 'what is the minimum working hours required for a day?']
I used this code to get the reformulations-
from px.nmt import reformulator
from px.proto import reformulator_pb2

questions = ['how can i apply for nsa?', 'what is the minimum working hours required for a day?']

reformulator_instance = reformulator.Reformulator(
    hparams_path='px/nmt/example_configs/reformulator.json',
    source_prefix='<en> <2en> ',
    out_dir='path/to/reformulator_dir',
    environment_server_address='localhost:10000')

# Change from GREEDY to BEAM if you want 20 rewrites instead of one.
responses = reformulator_instance.reformulate(
    questions=questions,
    inference_mode=reformulator_pb2.ReformulatorRequest.GREEDY)

# Since we are using greedy decoder, keep only the first rewrite.
reformulations = [r[0].reformulation for r in responses]

print reformulations

Resolved ✅
Tensorflow version 1.12.2 is required and if there is tensorflow-estimator installed it needs to be uninstalled.
Suggested by- @graviraja


🚧 Dev ➾ Automated tests for Google Analtyics tracking

🔗 Epic|Feature Link
No response
🚥 Definition of Done

[ ] 🎯 Planning and Design
[ ] 🏎 Dev Implementation Complete
[ ] ♾ PR Merged
[ ] 🏆 Product Acceptance

✅ To Do
Create the following tests for the plugins:
Google Analytics:

opt-in
-- Success
-- Cancel
opt-out
-- cancel
-- success

⚖ Acceptance Criteria
✨ Functional:

[ ]
[ ]

🔭 Scope
🙅♂ Out of Scope:

...

Code of Conduct

[X] I agree to follow this project's Code of Conduct

Currently blocked by -y bug #1455


Ardhive repo

Hi @mkloubert
Can you archive this repo as it is no longer updated since 2018. That would help people using an alternative that is maintained.
Thanks

https://github.com/mkloubert/vscode-deploy-reloaded


Ui fix1

Code and test now work properly.

Rejected this edition of the pull request since loading requirements failed.  Will fix and resubmit.


Send and sniff?

So I've been able to test both the send and sniff components of the flipper modbus app on the flipper, but I have a question about sniffing versus sending.
I've been trying to use manual sender with
Peripheral ID: 1
Function: 0x01
Start Address: 0
Quantity: 12
And I get back a time out
Baudrate: 4800
Data width: 8
Stop bits: 1
Parity: None
Response TimeOut: 500ms

Which looks like a time out response. As in, it doesn't seem like I'm getting a response back from the device.
However, if I drop it into "Sniffer", and bridge the a and b lines with a RS-485 to USB device I have and send what I think is the same command from python, the sniffer picks up the packet and reads it correctly.

-----PERIPHERAL-----
Read Holding Registers(03)
Peripheral: 1
bCount 20
->Reg0: 0
->Reg1: 527
->Reg2: 0
->Reg3: 0
->Reg4: 0
->Reg5: 0
->Reg6: 0
->Reg7: 0
->Reg8: 3072
->Reg9: 512
->Reg10: 0
-> Reg11: 0
CRC: 0x200B
So, if I had the "Sender" configured appropriately, I should get back the same response I get from the "Sniffer" ay? It does look like sniffer works correctly, but have I mis-configured the packet I'm sending to the device? It seems identical to the one I am sending via python.
So to test this, I put the "Sender" into the same config, but gave it a very long time out. I then send a packet from python. When I do this, I do get a response (as if the mod bus shield had sent the packet), and it looks like the right response.
So I think I've got the sender configured correctly but maybe it isn't actually sending the packet?
tldr: it seems like the send packet isn't working.

The mystery deepens..
So using my voltmeter, I was able to test a few things. Looking at either or A or B to ground. I get a voltage response when I make a request from python via a USB to RS485.
Sniffing this packet allows me to use it via Buffer Sender, which I had not considered looking into previously. When I use this packet and send via Buffer Sender, I get a voltage response! Hooray! However, I am encountering errors "Length-Type MissMatch!!!" and "Check Response TimeOut!!!".
It seems like I'm getting some bytes back, but it doesn't look like they are being parsed correctly.
So:
Send via Buffer Send works. However, it doesn't seem to be parsing the result correctly?
Send Via Manual Send does not seem to work (No change in voltage when a packet is to be sent).
Will continue to investigate..

Hi @throughthetrees
Thank you for reporting this and add detailed information about it.
We want to get as much information as possible about this issue to work on it, so please share with us:

What Flipper firmware and version are you suing?
What version of the Modbus app are you using?
Please add a picture of each side of the Modbus Add-On

Thank you for the info.
So Flipper is registering function 0x03 which is READ HOLDING REGISTERS, the same as sent using the function client.read_holding_registers in your Python script.
So let's try something different:

What happens if you create a new packet using Manual Sender in the Flipper app but now sending function 0x03?
Could you please share with us the complete output on the Python side?
What device are you using as a client/slave?
Is there constant traffic on the bus? A server-client (master-slave) communication, other than the Flipper messages?

So yes! It was my misunderstanding about what exactly is going on with read registers/ RS-485 commands.
Manual send is working!
However, it is still not registering the response correctly (in either manual or buffer send).
https://github.com/user-attachments/assets/87f3f4d3-f24d-42f5-aa20-2e5181d9e693

Ok, no worries.
Looks like Flipper is interpreting the packet as a HUB request. Try setting the timeout to a larger value, it should not be that big but try 2 seconds.

I tried for 5000ms and got the same response.

Ok,
We are working to understand what is happening here, but we need some extra information to understand the issue, please share the remaining requested info:

Could you please share with us the complete output on the Python side?
What device are you using as a client/slave?
Is there constant traffic on the bus? A server-client (master-slave) communication, other than the Flipper messages?

What device are you using as a client/slave?

So I'm still learning about this device, but I'm trying to read from a CWT-CO2-5K-EXPS-D CO2 sensor.  It came with almost 0 documentation, and almost everything I've found is from guess.
This is what I found on a review of the device that some one else had figured out:

But afaik, there is no official documentation. I've just been guessing at registers to read from.
Here is the device:

label view:

I am using the electronic cats CatSink variable power supply to get about 2 amp at 12 volt.

and I am bridging to a USB to RS-485 dongle.
So I think the client/ slave answer is just the one device? I only have this device on the modbus and i have to trigger it from either python or flipper to get a reading. I am new to RS-485 and so forgive me if I don't know the terms.

Could you please share with us the complete output on the Python side?

This is the function I'm running in python:
from pymodbus.client import ModbusSerialClient

# Setup the Modbus Serial client
client = ModbusSerialClient(
    method='rtu',
    port='/dev/ttyUSB1',          # Adjust as per your port
    baudrate=4800,                # Set baud rate
    parity='N',                   # Set parity (None, Even, Odd)
    stopbits=1,                   # Number of stop bits
    bytesize=8,                   # Number of data bits
    timeout=.1                     # Timeout in seconds
)

# Connect to the device
connection = client.connect()
if connection:
    # Assuming you want to read holding registers
    response = client.read_holding_registers(address=0x01,count = 16,slave = 1)  # Adjust parameters as needed
    if not response.isError():
        print("Data:", response.registers)
    else:
        print("Error:", response)
    client.close()  # Close the connection
else:
    print("Failed to connect to the device")
    client.close()  # Close the connection

and the response I get back is:
Data: [0, 452, 0, 0, 0, 0, 0, 0, 3072, 512, 0, 0, 0, 0, 0, 0]

The 452 is the ppm CO2, the 3072 is the temperature, and 512 is the humidity (I think).

Is there constant traffic on the bus? A server-client (master-slave) communication, other than the Flipper messages?

No. Its only traffic if I send request from Python or from flipper.  There are no other devices or commands sending or receiving on the circuit.
And with the help you've already given, it seems like now, yes I can get a signal using manual send!!
So that is good. But it seems like it doesn't parse correctly. You said it seems to be reading in HUB mode?

Hi @throughthetrees,
Could you assist us with a test? It would be very helpful in detecting the issue.
We need you to connect the Flipper, the sensor, and the USB to RS485 to your Modbus bus. Then activate the SETTINGS->SAVE LOGS option on the Flipper and set it to SNIFER mode. Now, send the command from Python and wait for the sensor's response.
Once this process is completed, please extract the generated LOG file and send it to us so we can review it for clues to solve the problem.
Please use the latest version of the application, which you can find in the latest release: https://github.com/ElectronicCats/flipper-rs485modbus/releases/tag/v<IP_ADDRESS>.

Pulling the latest.. will edit when have data.

Hey!!
Manual send now works!!!

Thank you so much for getting this fixed. Going to begin experimenting now. Also, I would like to learn to contribute, because getting this working was only step one. I want to learn how to add a feature to this library where I continuously make some request (like the above), maybe ever second, and the flipper logs it.
For another time then.
Here is Ka'ala saying thank you.


Add missing includes, fix #18

This leads to this error when we compile with the fix on pinocchio v1.2.9r2…

include/tsid/robots/robot-wrapper.hpp:25:40: fatal error: pinocchio/multibody/data.hpp: No such file or directory

What's wrong ?

So… Matrix6x was in model.hpp and has been moved to a new file data.hpp without any deprecation ?


Allow 0 (zero) and "" (empty string) to be returned as string.

The current implementation of Record.getString() returns null for 0 and "" (empty string). I don't think this is the intended behavior.
This change makes the value test more explicit so 0 and "" are not returned as null.

can you please add a simple unit test for this case?

I added several unit tests for Record.


SvelthreeInteraction properly type emitted CustomEvents

Currently those are just CustomEvent<any> revealing nothing about the contents of the detail object.

This was not done!


Cannot exit vim...

 - How do you think I got in here in the first place?

type :q!

[ENTER]

I can't type anything, I'm trapped inside my computer!


Edit Posts

This PR adds the ability to edit posts (and only posts, no comments), the idea is that we can discuss if we like this approach.

Do we have any safe way to test this? So far I only tested it in the vscode extension.

@gagdiez You can set up the bos-loader to run the viewer locally with these component changes. Check out the README.

thanks @calebjacob, tested it there and everything seams to work as expected! Now people will be able to correct typos


No reviewers added on https://github.com/web-platform-tests/wpt/pull/11851

@wpt-pr-bot isn't adding reviewers on https://github.com/web-platform-tests/wpt/pull/11851. Seems like a bug. @jugglinmike?

Ah, no, it sprung to life, just much slower than I've ever seen it before.


🖐 Caching docker layers using dagger

What happened? What did you expect to happen?
We're using dagger Go SDK for our CI pipelines in GitHub, and I am having trouble understanding how to enable caching docker layers. We're specifically using Container.Build to build the image and while it does take a ContainerBuildOpts argument, that seems to just allow build args.
I was hoping to be able to use GHA, maybe by passing cache-from and cache-to to Container.Build. Sorry if I'm misunderstanding how this is supposed to work -- I looked through the docs, cookbook and issue and didn't see a reference to anything like this.

I hadn't checked the discord -- but there is some discussion about this there: https://discord.com/channels/707636530424053791/1122941618056614048/1131263862981804042
My summary is that what I'm asking for isn't supported (anymore), and that there are scaling issues with using GHA anyway. There's also a closed source solution for caching that isn't currently available for GitHub. Please correct me if I'm missing something. If it's about right, then feel free to close this issue, thanks!

Hi @mlathara, we'll have an update on distributed caching later this week in the Dagger community call. There are a few threads in Discord on caching, and the most recent one is here: https://discord.com/channels/707636530424053791/1151898625945915454. Hope to see you there. :)


Fix: Resolve BingChatBot Login Issue with Updated loginUrl

The original URL (https://www.bing.com/new) now redirects to the Microsoft official website, preventing users from logging into the Bing ChatBot. This commit updates the URL to https://www.bing.com/chat, resolving the login issue.
Related issues:

#660
#662

Thank you very much. The PR will be included in next release.


1axis gencumsky -- not rounding angles of trackers

if no rounding angle is passed, EPW skies are made ofr each angle. However not all angles are being rounded, hence we have "25.560000000... 7.3900000" and it ends up doing 1 or 2 hours for each sky file. Software should round by default to nearest degree or half degree

actually --- the angle delta was set to 0.01, but it was being ignored and giving EPWs for lots of zeros...? maybe? hmmm... dunno. this might not be an issue. revisit.

Can't reproduce, oh well.


Fix bugs from PropertyString cache changes

Fixes following:
We were not disabling StoreFieldCache for SimpleDictionaryTypeHandle if PropertyDescriptor is not initialized.
We were attempting to cache enumeration of InternalPropertyId in case it was the last property.
We were attempting to cache property reads when object of a LdElem was a tagged number.

These are small fixes, so rather than making separate PRs I decided to just throw them all in here.

@dotnet-bot test Windows x86_debug

:shipit:


Splitting conf files

After the splitting of the services, it seems that the conf files are duplicated and only a portion is used depending on who is loading that configuration (general plus agent o general plus registrar/verifier).
Would it make sense to put only the sections of the conf that the agent is going to use on keylime-agent.conf and do the same for the server part (keylime.conf)?

gut feeling: +1 on that suggestion.
Things that make this special:

they use https://docs.python.org/3/library/configparser.html which can not do includes AFAIK :-/
the config files have sections [general] at the beginning as well as various sections for logging at the end which are needed for server + agent

So the question becomes do we prefer

a) current state - a split config with massive duplication that is inactive (agent section in the server config + server section in the agent config). We've already had cases where this lead to confusion. It also duplicates the general+logging sections
b) better split v1 - split the file a bit to have the keylime-agent.conf only have all [syections] that are known to be only for server components; as well as keylime.conf server having the [agent] section removed.
c) better split v2 - do it right and prep a split the way configparser can do so ("Attempt to read and parse an iterable of filenames"). So we could propose upstream to really split keylime.conf into four. keylime-server.conf keylime-agent.conf keylime-general.conf and keylime-logging.conf. The agent would include general, logging, agent (in that order) and the server would do (general, logging, server).

(c) Certainly is the most complex (convince upstream, do the code changes [also multiple env vars then I guess], quite fun juggling config files in packaging, ...). But it would also have the biggest benefits. It would have no duplicated configuration values anymore. And it would allow to have shared general values that can-be overwritten by agent/server if needed.
I'm tempted to say that IMHO the benefits of (b) over (a) exist but are negligible, so (c) or keep it as is.

I think c) is definitely the best solution and trying to remove sections in the current keylime.conf might result in a non working configuration. Because we now have two agent implementations (python and rust) in upstream, splitting the agent configuration from the rest is in general a good idea.

With the release of 6.5.0 the configuration is now fully split into the different components. We just need to update the package.

Awesome, thanks! \o/

@utkarsh2102 do you have time to update the package? If not I can do that but probably not before the end of this month.


https://docs.flutter.io/flutter/foo/ should redirect to https://docs.flutter.io/flutter/foo/foo-library.html

And https://docs.flutter.io/flutter/foo/Bar/ should redirect to https://docs.flutter.io/flutter/foo/Bar-class.html
Under each library, individual class pages are all located at https://docs.flutter.io/flutter/foo/Bar-class.html and properties/constructors/objects/methods are all located at https://docs.flutter.io/flutter/foo/Bar/property.html
I like to just be able to delete the individual html page from the URL to go back up a level. However, I get a Firebase Page Not Found error (since there's no 404.html) when I do this for a class or library.
Steps to Reproduce
Visit https://docs.flutter.io/flutter/widgets/Border/dimensions.html
Decide to check out the Border class by visiting https://docs.flutter.io/flutter/widgets/Border/ , get Page Not Found error.
Try to just get back to the widget library index by visiting https://docs.flutter.io/flutter/widgets/ and find Border there... get Page Not Found again.

Thanks for the suggestion. I'm not sure how to do this with Firebase Static Hosting. But maybe it's possible?
Another idea is to change how dartdoc produces HTML files.

It looks like Firebase Static Hosting supports redirects.

Is it possible to come up with maintainable redirect rules? We might accept a patch if the rules were pretty simple.
Also, I'm trying to remember why we used ClassName-class.html, and I think it's because there are other top-level names. We needed a way to disambiguate top-level functions, classes, typedefs, and (others?).

There are few enough libraries that you could write those redirects explicitly.
For the class names, I don't think the destination accepts a glob pattern, so I'm not sure there's a scalable method (unless you write a script that creates a redirect rule for each class, but that seems pretty hacky...)
@jamesdaniels -- is there a good solution to this??
I think the ClassName-class.html pattern is to differentiate the class page from the constructor page and makes sense-- so that https://docs.flutter.io/flutter/material/Border-class.html and https://docs.flutter.io/flutter/widgets/Border/Border.html are clearly different targets.

Captured redirects could help achieve this, if I'm gathering what you intend to do correctly. https://firebase.google.com/docs/hosting/full-config#redirects
E.g,
{
  "source": "/flutter/:foo/:bar/",
  "destination": "/flutter/:foo/:bar-class.html",
  "type": 301
}

cc @jcollins-g since this may be something dartdocs could implement.
Moving out of m3 since this doesn't fit our current priorities.

Issue moved to flutter/website #1821 via ZenHub


(Popup) Window and Table Quality of Life Improvements

Is your feature request related to a problem? Please describe.

Closing popup windows using the ESC key. Some dialog boxes can be closed with the ESC key where as some can't, leading minor frustrations. Examples:

ESC does close the active window:

Load PDB File
Menu --> Search -->

Program Text
For address tables
For Strings (the initial options window)
For encoded strings

BSim --> "Manage Servers" and "Search Functions" (the initial window)
Analysis --> Auto Analyze
Edit --> "Tool Options", "Options for ", and "Symbol Server Config"

ESC does NOT close the active window:

Menu --> Search -->

For memory
For Direct References
For Strings (the 2nd window that has the results)

Listing --> Right click --> Show references to address
Decompiler --> Right click a function --> References --> Find references to function/address.
The Bookmarks window if it's popped out as an individual window.
BSim --> "Feature Visualizer" and "Search Functions" (the 2nd window that appears after setting search options)
FWIW, the Listing/Decompiler "References" and "Search Memory" windows are probably the most annoying to me. I'm aware you can apply a custom "Close Window" key binding, but I've found that cumbersome since the action doesn't work in dialogs/windows that close using ESC.

Filter Bar Keyboard Improvement. If the currently selected window has table in it (e.g., Search --> For Strings), it'd be nice if hitting Ctrl+F focused text input to the "Filter" bar and allowed using the arrows to scroll up/down in the table. It's annoying when I'm in a window and have to use the mouse to change focus to the filter bar, type my query, and then use my mouse to select items in the list. To aid with discoverability, any window that does support search could include a search icon in its toolbar.

Hide "Filter" bar if not being used.  Screen real estate is always a battle in Ghidra. One feature that'd help with this is if the "Filter" bar wasn't always displayed and only appears if you hit Ctrl+F.

Console Window Search. Self-explanatory: add the ability to search script output, ideally with Ctrl+F. I have found myself on many occasions copying all text from this window into another text editor and then doing the search there.

Ability to toggle window visibility. Right now, there's actions to open windows individually, but not hide them individually. For example, you can open the Listing window with Menu --> Window --> Listing or assigning a key binding.  Once the window is open though, the only way to close it is by clicking the X in the toolbar or assigning a key binding to "Close Window". My preference would be, if there's a key binding assigned to open a window, that same key binding can to hide the window as well (if it's already open).

Example: I primarily work out of the Decompiler window, but need to use the Listing window occasionally. When I want to use the Listing window, I bind Ctrl+Shift+L to display it side by side with the Decompiler. To close it, I'd like to be able to hit Ctrl+Shift+L again (right now, hitting key binding multiple times trigger the window focus/jiggle animations).

Describe the solution you'd like
See above.
Describe alternatives you've considered
See above.
Additional context
Crammed them all into one issue here so you can break them out into individual ones if you decide they're worth pursuing. Let me know if in the future you'd prefer them as individual issues.

All good suggestions.
Regarding 1, When I bind ESC to the Close Window action, then provider all seem to close as expected and dialogs that support ESC still close too.   Seems like this should work in all cases.   If it is not, then that is something we may be able to fix.
2  and 3 sounds like good suggestions, but are non-trivial.
4 Search and a highlight feature seem useful here.   This would also be non-trivial.
I could see 5 being something we would have to make an option, since it may annoy some users.  Assuming ESC works, then that would handle some workflows in which you wish to open the window and then close it again without changing focus.

Regarding 1, When I bind ESC to the Close Window action, then provider all seem to close as expected and dialogs that support ESC still close too. Seems like this should work in all cases. If it is not, then that is something we may be able to fix.

I tried this initially as well. The annoyance I encountered that caused me to switch back was sometimes I'd hit ESC multiple times to close a dialog box (just out of habit from other tools). Upon doing so, it'd close the dialog box, but because I hit ESC multiple times, then it'd also close the panes I had open in the main window. A compromise here might be to make the "Close Window" action not close open window panes, and maybe add a "Close Window Pane" action if people want to maintain that functionality.

Pressing enter to start analysis when the analysis option window pops up, like it used to. Instead of the "new" behavior of moving to the next analyzer. Shouldn't have to pick up the mouse to move it and click on the 'Analyze' button, especially when the button is outlined to imply hitting enter would click it.
I brought this up here because I think it might be the table consuming the action when it shouldn't be?

@astrelsky This sounds like a regression


Release an aarch64 build

This line shows that the aarch64 target for builds is enabled in the master branch. Could it be feasible to create a new release with this target build? Or, alternatively, if not all changes in master are ripe enough for a release, create a backport of changes that concern the build arch only and then release 2.0.1?

Hey @art-shutter, I will take a look at the matter shortly.

I will attempt a release of the current master branch.

Unfortunately the release process of this project is outdated and broken. I opened up #96 to modernise it though.
@art-shutter you can always install from source and target any commit like so, if that helps the immediate need:
# install the latest version found on crates.io
cargo install helm-templexer

# install a specific commit from source
cargo install helm-templexer --git https://github.com/hendrikmaus/helm-templexer.git --rev 9f75543330b5d10c0b7455a2c21af421802431d5

Of course, you have to have the Rust toolchain installed for that to work.
It will compile for your host architecture.

Thank you! Building locally is not an issue (builds fine), I needed some automation that would use a downloaded pre-built binary.

Let me see if I can add the pre-compiled binary to the latest release manually.

@art-shutter I manually added the aarch63-apple-darwin build inclduing checksums to the latest release https://github.com/hendrikmaus/helm-templexer/releases/tag/2.0.1

Thank you! This is exactly what I needed :)


How to Disable debug globally?

I know this isn't an issue with the package so much as it is a personal issue, but I can't seem to find documentation anywhere to disable debug globally for all projects.   Basically whenever I localhost anything my localStorage is automatically is set to {debug: *}.  I will delete this issue as soon as I figure it out.

For Node? export DEBUG= should do it.

Thank you for the response, yes this is for Node.  Sorry, I have tried running export DEBUG= everywhere in every way I know how and the problem still persists.  Could you be more specific?  Any help would be emensly appreciated.
Basically my chrome console has been filled with 'sockjs-client' info which I can stop by changing the log code in browser.js however I can't seem to find a way to stop the wildcard * from being thrown into local storage.

same issue on electron v6.0.8
export DEBUG= can disable terminal logging output but electron console was keeping printing.
my project was running at raspberry pi 3. logging take too many cpu >.<

It's not CPU that is being eaten - log statement still evaluate even if they're turned off - it's whatever is consuming the stderr stream that is blocking your program. Console output isn't cheap 🙃
Depending on where debug is being used in an Electron app, it's either going to be governed by the DEBUG= environment variable if it's in the main process scripts or the equivalent browser variables if it's being used in a renderer process (the "browser" part of electron).


[DRAFT] Implement Testing for Regression in Consensus Event Ordering

Closes #2309

This PR:
From the issue:

We've seen bugs in testnets where we don't propose if the consensus tasks gets events in the wrong order (where any order should be fine).  Currently there are 2 or 3 events that need to be received for the leader to propose:
SendPayloadCommitmentAndMetadata, QCFormed (either QC or TC), and QuorumProposalRecv for the previous view if a QC was formed by us for it.  We had a bug where SendPayloadCommitmentAndMetadata was the last of theses >events to be received and we didn't propose.  We need regressions tests against such scenarios.

This PR implements testing to detect regressions when such events occur out of some pre-defined order. In the working case, the code should be able to handle events in any order and successfully propose no matter what.
This PR does not:
This PR does not attempt to fix any existing issues within the core logic, any such changes will be subject to later patches.
Key places to review:
All test cases.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


flipped entities repr for ordering

needed, fulfills #317.
fwiw -- i feel pretty iffy about changing the bit repr. I know that hecs says that it "doesn't promise anything" but this library is used a lot! personally, i'd leave the old bit repr in place

If you're comfortable with that, I'm comfortable with that, but I'd say that the Ord change is "higher level" than the bit fiddling changes, so it feels simpler to understand.

@Ralith bumpin this for your thoughts


Support for Global Parameters

Microsoft released (GA) Global Parameters in ADF.
Tweet: https://twitter.com/AzDataFactory/status/1291448987594051584
Blog post: https://techcommunity.microsoft.com/t5/azure-data-factory/global-parameters-generally-available-in-azure-data-factory/ba-p/1571320
Doc CI/CD: https://docs.microsoft.com/en-us/azure/data-factory/author-global-parameters#cicd
I would expect from a new version of the tool:

Expose GlobalParameters property in ADF class (both: code & service)
Add new property to AdfPublishOptions class
Capability to replace any GP values with a config file like for other objects
Publishing Global Parameters

Not yet. I've just got back from holiday, but I started working on that before. I didn't publish it yet because I found a bug in MS script (global parameter with array type) and other things make this case more complicated.

No worries. hope you had a great holiday. We made do without global parameters before so no real rush ;)


Add AWS S3 as supported remote cache

For re-using already known scan results, ORT can use a remote cache. Currently only Artifactory is supported but we would like to add AWS S3 support as it more commonly used and cheaper to set up than Artifactory instance.
See also: https://docs.aws.amazon.com/sdk-for-java/v1/developer-guide/examples-s3.html

This was implemented in https://github.com/oss-review-toolkit/ort/pull/7413.


Rework notifications list

Replace <table> with flexbox
Add issue modification time and issue number
Remove big title
Replace tabs with menu items
Add clicked item deletion on back button cache restoration

Before, for reference:

Tweak line-height on notification icon, before and after:

Will do something about these tabs as well.

Tabs removed, ready again.

Hi, page title ({{.locale.Tr "notification.notifications"}}) is removed.
It's expected behavior or typo?

Hi, page title ({{.locale.Tr "notification.notifications"}}) is removed. It's expected behavior or typo?

Yes, it serves no meaningful purpose and just takes away space imho.

It's not very comfortable to always show pin and read icons. Maybe we can learn from Github to only show the icons when hover this line.

It's not very comfortable to always show pin and read icons. Maybe we can learn from Github to only show the icons when hover this line.

That is one aspect I don't like about GitHub's UI. Buttons that only show on hover might be a accessibilty concern too, I don't think it would be a good experience on mobile to do that.

Ah, yes. Mobile and Desktop are different on this point.

It's not very comfortable to always show pin and read icons. Maybe we can learn from Github to only show the icons when hover this line.

That is one aspect I don't like about GitHub's UI. Buttons that only show on hover might be a accessibilty concern too, I don't think it would be a good experience on mobile to do that.

I see that GitHub just hides the buttons completely on small viewports, making their functions inaccessible. I think it's bad design and we are not so starved for space here that we can not show the two buttons, so I'd keep it as-is.

Did a tweak to button-ghost to always have padding. It is a bit opinionated and could also be done via .gt-p-3 on all buttons, but I feel these buttons look to bare otherwise.
I introduced a .button-link to fix and improve the "Manage Topics" button on repo:
Before:

After:

One more feature added to the notification table:
When clicking a unread notification, and the returning back to it via the back button, the item would still be in the list because the browser's bfcache was in effect. I added a mechanism that detects this restoration from this browser cache and removes clicked items and updates the "Unread" counter based on the number of removed items.

I added a mechanism that detects this restoration from browser cache and removes clicked items and updates the "Unread" counter based on the number of removed items.

Seems this mechanism currently only works in Firefox. Chrome and Safari do not store restore this page from bfcache, and I can only assume those are browser bugs.

Pin is not a frequent operation so I don't think the pin button should always be displayed.

Hmm yes, I think something needs to be done about pinning, the UI is for it quite confusing currently. I think we can as a first step not replace the left icon with the pin icon when pinned, similar to the "Save" action on GitHub.

Did a few tweaks, icon is now shared with issuelist, with the slight complexity of .PullRequest vs .GetPullRequest in the shared template.
Now has the hover effect:

@wxiaoguang what shall we do with this hover effect. I think those button need it, but it looks ugly when the button has no padding:

That's why I suggested a distinction with a button-link because following Chakra, these have no background effect, but do have padding.

Render failed, failed to render template: user/notification/notification, error: template error: builtin(static):shared/issueicon:1:5 : executing "shared/issueicon" at <.IsPull>: nil pointer evaluating *issues.Issue.IsPull
----------------------------------------------------------------------
{{if .IsPull}}
     ^
----------------------------------------------------------------------

Render failed, failed to render template: user/notification/notification, error: template error: builtin(static):shared/issueicon:1:5 : executing "shared/issueicon" at <.IsPull>: nil pointer evaluating *issues.Issue.IsPull
----------------------------------------------------------------------
{{if .IsPull}}
     ^
----------------------------------------------------------------------

Odd, I did not see this during my testing, the new subtemplate worked in both issue and notifications list.

Pinning issues in the notifications list is not a new feature

Yes. My feature request was about losing information after pinning because it replaced the icon that indicated type of notification and status (Issue/PR, Open/Closed/Merged), which your design by keeping the icons separate solves.

Yes, that indeed is a nice improvement over the previous UI. More UX improvement could be done with adding a "Unpin" button, but I think I will defer that to another PR.

Render failed, failed to render template: user/notification/notification, error: template error: builtin(static):shared/issueicon:1:5 : executing "shared/issueicon" at <.IsPull>: nil pointer evaluating *issues.Issue.IsPull
----------------------------------------------------------------------
{{if .IsPull}}
     ^
----------------------------------------------------------------------

Odd, I did not see this during my testing, the new subtemplate worked in both issue and notifications list.

https://github.com/go-gitea/gitea/pull/24812/commits/95ce9466f236496cf3940554032cc447f579bf1e should fix this. I have no idea how to trigger a repo notification, but it should not panic anymore now.


Styling differences between logged object and evaluated object

Log messages have an indent and slightly smaller font size.

@roblourens Cannot repro in 1.8.1

You would need to use 1.8.1 with an up to date debug adapter.
You can build and run node2, then attach to it with "debugServer": 4712 (or I can just verify)

@roblourens I'll let you verify :)


Why is initializePhetioObject called first in Node.mutate?

@samreid and I discovered this, as it related to phetsims/phet-io-wrappers#97.
If something is updated in that mutate call, it will look like things CHANGED and not like we were just manipulating the startup state of the Node. In the days back before PhetioObject, we had the Node.setTandem function and the tandem mutator key. I specifically remember @samreid, @jonathanolson and @zepumph all noting that we wanted the tandem mutation last, signifying that once the instance is added, we are ready for interoperability. I was not involved with the PhetioObject implementation, but wonder if we want to apply the same strategy here, and have the initialize function after we have iterated through mutator keys. @jonathanolson how does that sound?

Sounds like it's still "tricky" to try to guess whenever an object is fully constructed. We wouldn't ever want to say something is fully initialized at the end of its constructor, unless it is guaranteed to have no subtypes.
Are we going to be adding tons of lines of code in sims that note when every object is properly initialized?

Can we add a single, general emitter that says "every object is now finished being constructed" and then "release" them all over the phet-io api as instances added. This batching is how we are handling static instance construction, but maybe we need to take it a step further, and only treat an object as "instrumented" after the sim constructor has finished, and the Screens have finished being created. This is a bit strange because addInstance will still be called throughout construction, but they won't fully be added instances until we give them the final go ahead.

I thought we no longer needed to synchronize the "object is created" logic, because the API is over postMessage and hence the object will be interacted with after the stack resolves.

Indeed!

It sounds like there is still no good solution for this. Should we have a meeting to brainstorm more?

Yes, it would be good to discuss.

Honestly I'm surprised that this hasn't been more of an issue yet. I would assume that most Node's are being emitted to phet-io as  "newly fully constructed instances to interoperate with" before they are fully constructed.
Is it possible that actually this is safe because the entire construction will happen sync on the sim side before passing this information over to the wrapper side?

Honestly I'm surprised that this hasn't been more of an issue yet. I would assume that most Node's are being emitted to phet-io as "newly fully constructed instances to interoperate with" before they are fully constructed.

Sam Reid said very articulately that we don't need to have an object fully constructed before instrumenting it (by calling PhetioObject.initializePhetioObject on it). This is because the PostMessage call over to the wrapper is async, so no matter what it won't happen until after the object has been fully constructed (all the way up and down the hierarchy).
The error in https://github.com/phetsims/phet-io/issues/1365 was different because that was Qunit, running in the same frame as the sim, so there construction did matter. We should be careful about that when writing more tests.
As a result, though in https://github.com/phetsims/phet-io/issues/1365 we changed the order of phetio initialization in Node.mutate, it effected the tests, but not the wrapper communication.
I think we are ready to close this issue.


FIIO X 7 user

Hi, im a FIIO X 7 user and i found that this app can't search any file in the latest version of X7 (FW3.0.8_beta Android 5.1). Thank you.

Hi @BearGor thanks for your report. FIIO X7 is a very good HiFi player but unfortunately I don't have one in hand, and as you might know FIIO might have modified the Android OS quite a lot, so can you confirm is it that you can't see music files or can't search?
If you can't see the music files, because the app relies on the local multimedia file database in Android, so it could be the case FIIO has an alternative so the app can't get music file information out of it. In that case, I can't do anything at the moment.
Thanks,
Ludy


Only push the objects that are not in the remote artifact share

See original issue on GitLab
In GitLab by [Gitlab user @tristanvb] on Oct 27, 2017, 07:45
The push code for the ostree artifact share could be improved.
Note that in the following, refs refers to the symbolic refs, while objects refer to checksummed files, commit objects and detached metadata objects.

Currently the client side sends the refs which it intends to push, and the server side just sends it back.

Instead the client could send a list of the actual objects it has available to push along with the refs, and the server side could respond with a list of objects that are in the received batch, but not present in the artifact share.

This would allow the client to only send the objects which are needed in the remote, instead of redundantly sending over files which the server already has an identical copy of.

In GitLab by [Gitlab user @juergbi] on Jul 10, 2018, 08:30
mentioned in commit a615e00185b097a3ff3ce15f58e79a803339d9f8

In GitLab by [Gitlab user @juergbi] on Jul 10, 2018, 08:51
mentioned in commit 76cbcd4ec52c26fc77134533df64c64221610e22

In GitLab by [Gitlab user @juergbi] on Jul 10, 2018, 17:06
mentioned in commit 8c7ab2f0a3582cde19d5be7f293b47bfa51efbc4

In GitLab by [Gitlab user @juergbi] on Jul 10, 2018, 18:12
mentioned in commit 1792150b63971e2c4335f785cb9c7da1243cfcc4

In GitLab by [Gitlab user @juergbi] on Jul 16, 2018, 15:33
mentioned in commit cb79b711f0c653c10d78e44f3154eee4f9d123b9

In GitLab by [Gitlab user @juergbi] on Jul 16, 2018, 17:24
mentioned in commit fdbc1e33f84fd45f6ac4527846fc3cc8a14d009b

In GitLab by [Gitlab user @juergbi] on Jul 17, 2018, 06:58
mentioned in commit 1f8b4aa290a908a697f008a29ea143a9320dd639

In GitLab by [Gitlab user @juergbi] on Jul 17, 2018, 08:59
closed via merge request !337


New fleet alert messages

New feature implementation
Implemented feature

New messages that allow custom interactions to arise from the fleet level, namely alerts, notifications, user interactions, etc

FleetAlert
FleetAlertParameter
FleetAlertResponse

Example usage
This can hopefully extend to many more cases, other than these 3 examples provided
Case 1

Fleet adapters with custom perform_actions will require user input or responses for certain decisions, can publish an alert with all the possible responses listed
API server picks it up and prompts the users on the frontend
User chooses a response
API server will publish the response back down to the fleet adapter

Case 2

Fleet adapters wishes to inform users something has happened in the form of a notification (info,warning or error), with no user response required

Case 3

Fleet adapters with custom perform_actions will require input or responses from other parts of the system (non-human), an alert can be sent out with it toggled not to be displayed
The other system can respond using the response message as well

LGTM, have tested it and it is comprehensive enough to contain the different types of information we would need to publish messages between the fleet adapter and RMF web.


Typo in project description

"Object Storage Gateway for Hybrid Coud"
Should be Cloud (:
As this is a manual github setting, I can send a PR.

Thanks fixed! 🍰


chore: Update ACIR documentation

While solving the Discover Noir quests in nodeguardians (pretty cool way to learn by the way), I stumbled upon a few grammatical hiccups in the docs. So I thought it'd be helpful to smooth these out for anyone else who's on this learning journey.
Here's a quick rundown of the changes I made:

In acir_docs.md, tweaked a couple of sentences for clarity. For instance, changed "abstract here simply mean" to "abstract here simply means", and "proving system need" to "proving system needs".

In installation/index.md, fixed a typo: changed "though" to "through".

In various testing docs like testing.md, I corrected phrases like "satisfying the all" to "satisfying all".

In migration_notes.md, cleaned up a few words – for example, "filed" to "file" and "you" to "your".

In logging.md, sorted out the word "constrains", changing it to "constraints".

Hi. We've recently decided on a policy that we will not be merging typo fix PRs unless someone has done a significant contribution already. The recent usage of Github commits as a metric mean we have to manage this a bit. We will redo this change and thank you for the contribution.


Minor refactors to make wiggle-generate reusable externally

For https://github.com/bytecodealliance/lucet/pull/439

separate witx loading from code generation
some minor code reuse for param names

These are minor enough that im just going for it


Updated creating an AWS account

Proposed changes
Updated the how to get started with AWS section. Added graphics and instructions.

Updated documentation.
Types of changes
Updated instructions.

[ ] Bugfix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Refactor (changes to code, which do not change application behavior)

Checklist

[x] I have filled out this PR template
[x] I have read the CONTRIBUTING doc
[ ] I have added automated tests that prove my fix is effective or that my feature works
[x] I have added necessary documentation (README.md, inline comments, etc.)
[x] I have updated the CHANGELOG.md under a ## next release, with a short summary of my changes

Relevant Links

Further comments

docs/img/aws_account_id_iam_console.png might be problematic since I see an account number listed.  Is this still an active account?

No. It's an inactive account only used for the purpose of creating the screenshot.

@shubydo can you run the dce check?

@shubydo can you run the dce check?

Done. Sorry for the delay.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.