cmake: add more input validation checks to function flatcc_generate_s…

Add some more input validation checks to the flatcc_generate_sources function.
Instead of taking the output target name as a function argument I added it to the single value arguments with keyword TARGET_NAME because that makes input validation a lot easier.

One problem when using your branch I am currently looking at: when using flatcc_generate_sources without the COMMON_READER or COMMON_BUILDER or ALL option the common header files like 'flatbuffers_common_reader.h' are not found by the C compiler. This even though I link to the flatcc::runtime target and the flatcc::runtime target contain thoses headers.
In the flatccruntime config file  <INSTALL_PREFIX>/include directory is set as INTERFACE_INCLUDE_DIRECTORIES target property, but the common header files are installed in <INSTALL_PREFIX>/include/flatcc/reflection.

Are the common header files from the runtime library supposed to be in the include path or are the COMMON_READER etc. options needed to get the generated code to compile?

One problem when using your branch I am currently looking at: when using flatcc_generate_sources without the COMMON_READER or COMMON_BUILDER or ALL option the common header files like 'flatbuffers_common_reader.h' are not found by the C compiler. This even though I link to the flatcc::runtime target and the flatcc::runtime target contain thoses headers.

The options are modelled on the arguments that flatcc has.
See flatcc -h.

In the flatccruntime config file <INSTALL_PREFIX>/include directory is set as INTERFACE_INCLUDE_DIRECTORIES target property, but the common header files are installed in <INSTALL_PREFIX>/include/flatcc/reflection.

Let's ask to @mikkelfj:
Would it make sense to,
when linking to flatcc::runtime, to also always add include/flatcc/reflection to the include search path?

One problem when using your branch I am currently looking at: when using flatcc_generate_sources without the COMMON_READER or COMMON_BUILDER or ALL option the common header files like 'flatbuffers_common_reader.h' are not found by the C compiler. This even though I link to the flatcc::runtime target and the flatcc::runtime target contain thoses headers.

The options are modelled on the arguments that flatcc has.
See flatcc -h.

In the flatccruntime config file <INSTALL_PREFIX>/include directory is set as INTERFACE_INCLUDE_DIRECTORIES target property, but the common header files are installed in <INSTALL_PREFIX>/include/flatcc/reflection.

Let's ask to @mikkelfj:
Would it make sense to,
when linking to flatcc::runtime, to also always add include/flatcc/reflection to the include search path?

Are the common header files from the runtime library supposed to be in the include path or are the COMMON_READER etc. options needed to get the generated code to compile?

@mikkelfj
When linking to flatcc::runtime, what include path do you expect users to always need?
Same question for flatcc::compiler.

@madebr

When linking to flatcc::runtime, what include path do you expect users to always need?
Same question for flatcc::compiler.

flatcc/include such that <flatcc/flatcc.h> and other headers are available for libflatcc users and <flatcc/flatcc_.h> for libflatccrt users, and <flatcc/portable/.h> in general. Additionally, and infrequently, users can add "flatcc/include/flatcc/portable/include/std" to their include path if they miss critical headers like <stdint.h> Note that flatcc avoids assuming stdint.h is present because it isn't for MSVC2010.
Other subdirectories like flatcc/include/flatcc/support and flatcc/include/flatcc/reflection are optional for runtime users.

when linking to flatcc::runtime, to also always add include/flatcc/reflection to the include search path?

As mentioned in previous comment (I didn't see you question before now)  reflection is needed for building libflatcc and therefore also cli, but runtime users do not need it. As to include path I would expect users to include <flatcc/reflection/...> so no extra include path is needed. Reflection is sort of optional in the sense that you can always regenerate it from reflection.fbs. I have considered removing it because contributors always patch the generated code instead of the code generation, no matter how loud I write do not in README.

Thanks for the clarification.
The generated header files have
#include "flatbuffers_common_reader.h"
So if I understand correctly, to make the generated code compile users should either add the <flatcc_install_prefix>/flatcc/reflection path to the include search path themself or use one of the --common options when calling the flatcc executable. Is that correct ?

Users should never use reflection code for any code not related to reflection.
The common files are always produced along with the other output to ensure they are 100% in sync with generated code.
Users can choose not to generate them for all schema files, for example if they build a lot of files in separate build steps. Or if they risk writing on top if each other in concurrent build steps. They can also be generate separately as a single build step.

Historically the intention with common files was also to support name spaces for flatbuffers variants other than standard, for example with 64-bit internal offsets instead of 32-bits. This might still happen one day.

There are some long term discussions about how to make flatbuffer code generation more pluggable. One suggestion is a reflection v2 format that code generators can use without necessarily running in the same process as the schema compiler. That would make reflection code more important.

Thanks, its clear now.


Volume control

This is a workaround for the missing volume control in node-spotify. it uses loudness that controls the systems output volume.

This seems like a ok workaround until FrontierPsychiatrist/node-spotify#36 has a better solution.
:+1:

:+1: :clap:


ColorTool switches --both and --xterm throw error

Microsoft Windows [Version 10.0.17763.346]
colortool v1.0.1810.02002

What I'm doing and what's happening:
Occurs in both user and elevated command prompt
ColorTool.exe and /schemes/ directory are both in C:\WINDOWS\system32

C:\WINDOWS\system32>colortool campbell -b -x
Could not find or load "-x"

C:\WINDOWS\system32>colortool campbell -b
Could not find or load "-b"

C:\WINDOWS\system32>colortool campbell -x
Could not find or load "-x"

C:\WINDOWS\system32>colortool campbell --both
Could not find or load "--both"

C:\WINDOWS\system32>colortool campbell --xterm
Could not find or load "--xterm"

What's wrong / what should be happening instead:
Switches should not throw error and work

colortool.exe [options] <schemename>
Place options first, after that the scheme name ;)


How does this work: short term migration - exp_setting_lower_p_vl1000

* short term migration - exp_setting_lower_p_vl1000; * mar19;

* if exposed elsewhere externaly, partners may be less likely to be suppressed, i.e u1=lower % supressed;
if exp_setting_lower_p_vl1000 = 1 and 20 <= age < 50 then do;
	r=rand('uniform');  * dependent_on_time_step_length;
	if (gender = 1 and r < rate_exp_set_lower_p_vl1000) or (gender = 2 and r < rate_exp_set_lower_p_vl1000 / 2) then do;
		u1 = u1 / external_exp_factor;
	end;
end;

cu_1=.;cu_2=.;cu_3=.;cu_4=.;cu_5=.;cu_6=.;
cu_1=u1;cu_2=cu_1+u2;cu_3=cu_2+u3;cu_4=cu_3+u4;cu_5=cu_4+u5; cu_6=cu_5+u6;

*   vlg1 < 2.7    vlg2  2.7-3.7  vlg3  3.7-4.7   vlg4  4.7-5.7    vlg5  > 5.7    vlg6  primary;

The values u1 to u6 are proportions of a demographic group which are in a given viral load group.
This code changes only the first group, so that these probabilities would no longer add up to 1.
In code below if the cumulative value is less than 1 then there is a chance that none of the statements will execute
if t ge 2 and nip gt 0 then do;
	d=1;do until (d gt nip);
		risk_nip=0;  * dependent_on_time_step_length ;
		a=rand('uniform');
		if                   a < cu_1/cu_6 then do; risk_nip = max(0,(tr_rate_undetec_vl*fold_tr_newp)+(0.000025*rand('normal'))); vl_source=1; t_prop_rm=t_prop_vlg1_rm; end; *new for prep;
		else if cu_1/cu_6 <= a < cu_2/cu_6 then do; risk_nip = max(0,(0.01*fold_tr*fold_tr_newp)+(0.0025*rand('normal')));       vl_source=2; t_prop_rm=t_prop_vlg2_rm; end; *new for prep;
		else if cu_2/cu_6 <= a < cu_3/cu_6 then do; risk_nip = max(0,(0.03*fold_tr*fold_tr_newp)+(0.0075*rand('normal')));       vl_source=3; t_prop_rm=t_prop_vlg3_rm; end; *new for prep;
		else if cu_3/cu_6 <= a < cu_4/cu_6 then do; risk_nip = max(0,(0.06*fold_tr*fold_tr_newp)+(0.015*rand('normal')));        vl_source=4; t_prop_rm=t_prop_vlg4_rm; end; *new for prep;
		else if cu_4/cu_6 <= a < cu_5/cu_6 then do; risk_nip = max(0,(0.10*fold_tr*fold_tr_newp)+(0.025*rand('normal')));        vl_source=5; t_prop_rm=t_prop_vlg5_rm; end; *new for prep;
		else if cu_5/cu_6 <= a < cu_6/cu_6 then do; risk_nip = max(0,(tr_rate_primary*fold_tr_newp)+(0.075*rand('normal')));       vl_source=6; t_prop_rm=t_prop_vlg6_rm; end; *new for prep;

@andrew-phillips-1
This would leave risk_nip equal to 0. Is this the idea? What is the short term migration code modelling?

@mmcleod89    Hi Michael  The intent is that the "cu_x" variables are the cumulative value of u for numbers up to and including category x.  So having cu_6 as the denominator should mean the values are between 0 and 1 ?  Or have I made a mistake here ?

Yes, you're right, the cu_6 as a denominator will re-normalise everything so that the values are between 0 and 1.
So what does the short term migration code model? It reduces the size of the first probability (u1 = u1 / external_exp_factor) and leaves the rest alone, so it reduces the relative chance of a low viral load relative to higher viral loads / primary infection categories?

Yes the intent is to consider that a person from the population may have had sex with someone outside the community so the viral load profile of the such people will not necessarily be a reflection of the viral load distribution in our population.  In a closed community some kind of 100% treatment coverage would eliminate new transmission, but if people can go outside this setting and have sex and come back then there will still be new HIV cases.  That was the thinking.


Updated documentation for creating units

Seems RTSAttackable component was replaced by tag component: https://github.com/npruehs/ue4-rts/commit/0283189cd9b1cb069b4014db6271f8248047e081

That's correct! Thanks for the PR :)


Created Polish translation (branch 1.12.2)

In this commit I made the same changes as in #56, backported to the old language files format.
If you are not supporting Minecraft version 1.12 anymore, feel free to close this PR.

I don't plan to release a new 1.12.2 version, unless somebody discovers a bug that needs fixing.
I'll pull this in, in case it happens :)
You can grab a build of Mine Menu including the localization (When it's done building) here:
https://jenkins.girafi.dk/job/Mine Menu/job/Mine Menu 1.12/

Thank you for the explanation. I agree it isn't important and necessary to release new version with translated just one string.

Thank you for the explanation. I agree it is not important and necessary to release new version with translated just one string.

Thank you for the explanation. I agree it is not important and necessary to release new version with translated just one string, especially for outdated Minecraft version.


Issues/5 reduce vertex count

Addressing #5.
Developed and tested on Win7 with VS2013, DirectX and OpenGL. I have not tested for other platforms but see no reason that it shouldn't work there as well.

  I'll see if I can figure out what is going on tomorrow morning.  No error or warning messages.

The initial commit that does index-based work inside the function and then converts back to vertices works, once I replace the "for each" with a standard for so it can compile on Linux.

Clearing the screen to red before rendering the triangle mesh shows that the mesh is not showing up -- the window stays red.  Switching which face is front-facing doesn't change things.  It is drawing 38400 triangles in the glDrawArrays call.

When I set these to what they seem like they should be (interleaved, with stride and offset), I get no triangles again.  When I set them to block layout, I get a whole screen full of triangles, but they are scrambled.
Giving up for now.

I'll try to get setup on Linux and look at this.
On Mon, Apr 25, 2016, 9:08 AM Russell Taylor<EMAIL_ADDRESS>wrote:

When I set these to what they seem like they should be (interleaved, with
stride and offset), I get no triangles again. When I set them to block
layout, I get a whole screen full of triangles, but they are scrambled.
Giving up for now.
—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
https://github.com/sensics/OSVR-RenderManager/pull/75#issuecomment-214310313

--
--
Matt Dutton
404-406-1312 (cell)


feat: changing the flag -f to visible

The functionality to add the flag to the convert command was added in the commit  https://github.com/salesforcecli/plugin-packaging/commit/92e7c550ff7b5e4012b8e46b42e278f0ced947bb
We are making the flag visible in the current pull request.
@W-12583095@ : Enable the flag in the force:package:convert command for the support specification of a scratch org definition file.

@peternhale  All passed. can you merge this please?


[CMT-979-1352] translate(tweet): yearning-for-yearn - ZH

translation check required.
Description

Please include a summary of the change and which issue is fixed.
Please also include relevant motivation and context.

This pull request ...
Fixed issue

Please indicate the fixed issues with this exact format Fixes #232 where 232 is the number of the issue. This will trigger an auto-close if the issue when this PR is merged.
Supported keywords:
Fixes #1,#2,#3
close #1, #2, #3
fix #1 #2 #3
resolve #1,#2 #3
Resolves: #1,#2,#3
closed : #1, #2, #3

Fixes #(issue)
Type of change

Please delete options that are not relevant and check the box.

[ ] Add a new article/page
[ ] Fix a Typo
[ ] Add a new translation
[ ] Other

Resources

Any screenshots, links or relevant resources to explain better the changes.

tlchecked, good to go


Fix sunpy test data paths - [merged]

In GitLab by @wtbarnes on May 24, 2021, 11:23
Merges fix-testdata-path -> master
The CI is broken because we were relying on specific sunpy test data paths that changed.

In GitLab by @codecov on May 24, 2021, 11:29
Codecov Report

Merging #112 (932f7c3) into master (6a86eba) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #112   +/-   ##
=======================================
  Coverage   97.23%   97.23%
=======================================
  Files          15       15
  Lines         470      470
=======================================
  Hits          457      457
  Misses         13       13

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6a86eba...932f7c3. Read the comment docs.

In GitLab by @wtbarnes on May 24, 2021, 11:26
enabled an automatic merge when the pipeline for 932f7c3cfc13aaa54ed7d730c172f5e9afe359e4 succeeds

In GitLab by @wtbarnes on May 24, 2021, 11:24
This should be backported to the 0.5 branch

In GitLab by @wtbarnes on May 24, 2021, 11:33
mentioned in commit ef6a44c27941fc9af0dda35e89a42d32c406d923

In GitLab by @wtbarnes on May 24, 2021, 11:34
mentioned in commit db3eeaf7bf5dc9605f649f8ebf25d828a62a36c8

In GitLab by @wtbarnes on May 24, 2021, 11:34
picked the changes into the branch cherry-pick-ef6a44c2 with commit db3eeaf7bf5dc9605f649f8ebf25d828a62a36c8

In GitLab by @wtbarnes on May 24, 2021, 11:44
mentioned in commit 21346193a22b1d2fa0a0ef26ca67b425afc3ee87


[SPARK-40270][PS][FOLLOWUP] Skip test_style when pandas <1.3.0

What changes were proposed in this pull request?
According to https://pandas.pydata.org/docs/reference/api/pandas.io.formats.style.Styler.to_latex.html:
pandas.io.formats.style.Styler.to_latex introduced since 1.3.0, so before panda 1.3.0, should skip the check
ERROR [0.180s]: test_style (pyspark.pandas.tests.test_dataframe.DataFrameTest)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/__w/spark/spark/python/pyspark/pandas/tests/test_dataframe.py", line 5795, in test_style
    check_style()
  File "/__w/spark/spark/python/pyspark/pandas/tests/test_dataframe.py", line 5793, in check_style
    self.assert_eq(pdf_style.to_latex(), psdf_style.to_latex())
AttributeError: 'Styler' object has no attribute 'to_latex'

Related: https://github.com/apache/spark/commit/58375a86e6ff49c5bcee49939fbd98eb848ae59f
Why are the changes needed?
This test break the 3.2 branch pyspark test (with python 3.6 + pandas 1.1.x), so I think better add the skipIf it.
See also https://github.com/apache/spark/pull/38982#issuecomment-1343923114
Does this PR introduce any user-facing change?
No
How was this patch tested?

CI passed
Test on 3.2 branch: https://github.com/Yikun/spark/pull/194, https://github.com/Yikun/spark/actions/runs/3655564439/jobs/6177030747

This might the right way to fix the 3.2 branch.
The check_style test introduced jinja2 deps and also panda > 1.3.0 reuqired, but for branch-3.2 we use python3.6, so we better to just skip it to recover branch-3.2 test.

@HyukjinKwon Thanks, let's wait the CI results of 3.2/master. : )

@dongjoon-hyun @HyukjinKwon Thanks, merged to master/branch-3.3/branch-3.2


Add Articles <> Tools relationship

A lot of times, an Article's content gets re-used in a different form:

compiled with other Articles into a Book
as a Poster
in a podcast Episode
in a Zine

It would be good if there was a way to link those things together, so that on the /zine/:slug page, there could be a link to the original text article. In the header or footer of an article, there could be an image of the zine cover and link to the zine page (with downloads).
Same for Posters, Books, podcast Episodes.
Often it's a one to one relationship. This Article turned into that Zine.
But often enough, it's a one to many relationship. Or a many to many relationship.

All of these Articles compiled into that Book
These two Articles used as the front and back of that Poster
This Article used in that Book, that Sticker and that podcast Episode

So. This will need:

[ ] model associations, with a has many through table
[ ] admin UI for adding the links, preferably from either side of the relationship (the Article or the Zine)
[ ] the template UI to show the linked items, initially it can be just text only links (a designed widget can come later)

Related: #849


Add iOS Support

I can do it, but if you prefer, we are also missing an iOS release in the .github (GitHub Actions) folder


Mod 05 - Application Gateway

Module: 05
Lab/Demo: Application Gateway
Task: 00
Step: 00
Several issues:

Only one subnet can be created with the application gateway. The backend subnet creation steps should be moved to after the gateway creation.
Missing instruction to upload the PowerShell IIS script to the Cloud Shell.
Template installation seems to hang.

Made the corrections. Separated the PowerShell script out of the template. Added a separate lab instruction.


Fixed #162. Made travis configuration more readable.

@felixxm Thank you for your interest in fixing the issue.
When you change the travis configuration it looks like Travis don't show the exact python version used to run the test. Take for example a current build vs the one you propose:

As you can see on the left it shows the Python version used and with your changes it doesn't.
Also you say it fixes the #162 issue. Can you elaborate more why this solves this issue?

As you can see in travis doc build condition will be pasted into a bash expression:
if [[ <condition> ]]; then <deploy>; fi

In bash string comparison work only with whitespaces framing =. "$TOXENV=py27-django-18" (without whitespaces) will the translate to string "py27-django-18=py27-django-18" which is always true.

Great. Thanks.
How about the other changes from line 9 to 21 ?

Travis displays default python version, inside test it will use appropriate. You can check travis-ci issue about python3.5 (see #4794) which is not easily available in travis env. The easiest solution is to set it as a default python version, just like for example in django-debug-toolbar (.travis.yml).

Thank you so much.


HADOOP-13704. Optimised getContentSummary()

Description of PR
JIRA: https://issues.apache.org/jira/browse/HADOOP-13704
This PR implements an optimised version of getContentSummary which uses the result from the listFiles iterator.
Explanation of new buildDirectorySet method added:
Since the listFiles operation can return the directory a/b/c as a single object, we need to recurse over the path a/b/c to ensure we have counted all directories. We do this by keeping two sets, dirSet (Set of all directories under the base path) and pathTraversed (Set of paths we have recursed over so far).
Iterating over directory structure basePath/a/b/c, basePath/a/b/d, we will first find all the directories in basePath/a/b/c. Once this is completed, the pathTraversed set will have {basePath/a/b} and dirSet will have {basePath/a, basePath/a/b, basePath/a/b/c}.
Then for basePath/a/b/d, just add basePath/a/b/d to the dirSet and don't do any additional work as path basePath/a/b has already been traversed.
The Jira ticket mentions that we should add in some instrumentation to measure usage. T's already code that does this
here and usage is tested in an integration test here .
How was this patch tested?
Tested in eu-west-1 by running
mvn -Dparallel-tests -DtestsThreadCount=16 clean verify

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
1m  3s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
markdownlint
0m  0s

markdownlint was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 4 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
62m  6s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
22m 50s

trunk passed

+1 :green_heart:
compile
22m 26s

trunk passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
compile
19m 41s

trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
checkstyle
3m 32s

trunk passed

+1 :green_heart:
mvnsite
3m  7s

trunk passed

+1 :green_heart:
javadoc
1m 55s

trunk passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javadoc
2m 35s

trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
3m 47s

trunk passed

+1 :green_heart:
shadedclient
21m  6s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 26s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
1m 35s

the patch passed

+1 :green_heart:
compile
21m 48s

the patch passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javac
21m 48s

the patch passed

+1 :green_heart:
compile
19m 43s

the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
javac
19m 43s

the patch passed

-1 :x:
blanks
0m  0s
/blanks-eol.txt
The patch has 3 line(s) that end in blanks. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply

-0 :warning:
checkstyle
3m 31s
/results-checkstyle-root.txt
root: The patch generated 53 new + 4 unchanged - 0 fixed = 57 total (was 4)

+1 :green_heart:
mvnsite
2m 38s

the patch passed

+1 :green_heart:
javadoc
1m 52s

the patch passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javadoc
2m 32s

the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
4m 12s

the patch passed

+1 :green_heart:
shadedclient
21m 20s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
17m 33s

hadoop-common in the patch passed.

+1 :green_heart:
unit
2m 44s

hadoop-aws in the patch passed.

-1 :x:
asflicense
0m 59s
/results-asflicense.txt
The patch generated 3 ASF License warnings.

268m 34s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3978/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/3978

Optional Tests
dupname asflicense mvnsite codespell markdownlint compile javac javadoc mvninstall unit shadedclient spotbugs checkstyle

uname
Linux 656603d35bca 4.15.0-65-generic #74-Ubuntu SMP Tue Sep 17 17:06:04 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 061765df76561a47a98cae35ec7d0a43bbd09ab7

Default Java
Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3978/1/testReport/

Max. process+thread count
1267 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common hadoop-tools/hadoop-aws U: .

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3978/1/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 59s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
markdownlint
0m  1s

markdownlint was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 4 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
12m 49s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
21m 57s

trunk passed

+1 :green_heart:
compile
22m 32s

trunk passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
compile
19m 45s

trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
checkstyle
3m 41s

trunk passed

+1 :green_heart:
mvnsite
2m 37s

trunk passed

+1 :green_heart:
javadoc
1m 54s

trunk passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javadoc
2m 35s

trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
3m 50s

trunk passed

+1 :green_heart:
shadedclient
21m 19s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 27s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
1m 34s

the patch passed

+1 :green_heart:
compile
21m 53s

the patch passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javac
21m 53s

the patch passed

+1 :green_heart:
compile
19m 48s

the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
javac
19m 48s

the patch passed

-1 :x:
blanks
0m  0s
/blanks-eol.txt
The patch has 1 line(s) that end in blanks. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply

-0 :warning:
checkstyle
3m 33s
/results-checkstyle-root.txt
root: The patch generated 53 new + 4 unchanged - 0 fixed = 57 total (was 4)

+1 :green_heart:
mvnsite
2m 37s

the patch passed

+1 :green_heart:
javadoc
1m 49s

the patch passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javadoc
2m 36s

the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
4m  6s

the patch passed

+1 :green_heart:
shadedclient
21m 25s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
17m 50s

hadoop-common in the patch passed.

+1 :green_heart:
unit
2m 41s

hadoop-aws in the patch passed.

+1 :green_heart:
asflicense
0m 59s

The patch does not generate ASF License warnings.

218m 43s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3978/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/3978

Optional Tests
dupname asflicense mvnsite codespell markdownlint compile javac javadoc mvninstall unit shadedclient spotbugs checkstyle

uname
Linux 89374a95dc5c 4.15.0-65-generic #74-Ubuntu SMP Tue Sep 17 17:06:04 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / ce88d31a45a4fd7455d7dffc6999475d90b51d28

Default Java
Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3978/2/testReport/

Max. process+thread count
1267 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common hadoop-tools/hadoop-aws U: .

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3978/2/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

@steveloughran thanks for the review :) I've made the suggested changes and also updated ITestS3ADirectoryPerformance.testListOperations()

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 45s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
markdownlint
0m  0s

markdownlint was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 5 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
12m 32s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
24m 29s

trunk passed

+1 :green_heart:
compile
24m 44s

trunk passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
compile
20m 44s

trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
checkstyle
3m 32s

trunk passed

+1 :green_heart:
mvnsite
2m 32s

trunk passed

+1 :green_heart:
javadoc
1m 47s

trunk passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javadoc
2m 28s

trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
3m 54s

trunk passed

+1 :green_heart:
shadedclient
22m  7s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 29s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
1m 36s

the patch passed

+1 :green_heart:
compile
24m 29s

the patch passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javac
24m 29s

the patch passed

+1 :green_heart:
compile
21m 29s

the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
javac
21m 29s

the patch passed

-1 :x:
blanks
0m  0s
/blanks-eol.txt
The patch has 1 line(s) that end in blanks. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply

-0 :warning:
checkstyle
3m 54s
/results-checkstyle-root.txt
root: The patch generated 29 new + 4 unchanged - 0 fixed = 33 total (was 4)

+1 :green_heart:
mvnsite
2m 29s

the patch passed

+1 :green_heart:
javadoc
1m 49s

the patch passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04

-1 :x:
javadoc
0m 47s
/results-javadoc-javadoc-hadoop-tools_hadoop-aws-jdkPrivateBuild-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07.txt
hadoop-tools_hadoop-aws-jdkPrivateBuild-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 generated 2 new + 39 unchanged - 0 fixed = 41 total (was 39)

+1 :green_heart:
spotbugs
4m  9s

the patch passed

+1 :green_heart:
shadedclient
20m 52s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
25m 12s

hadoop-common in the patch passed.

+1 :green_heart:
unit
2m 24s

hadoop-aws in the patch passed.

+1 :green_heart:
asflicense
0m 57s

The patch does not generate ASF License warnings.

235m  5s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3978/3/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/3978

Optional Tests
dupname asflicense mvnsite codespell markdownlint compile javac javadoc mvninstall unit shadedclient spotbugs checkstyle

uname
Linux 9d17fd41a2e1 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 51bf192f3df13708414841ffd1c6b0b0b845bf90

Default Java
Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3978/3/testReport/

Max. process+thread count
3158 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common hadoop-tools/hadoop-aws U: .

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3978/3/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
1m 21s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
markdownlint
0m  0s

markdownlint was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 5 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
12m 51s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
21m 54s

trunk passed

+1 :green_heart:
compile
22m 16s

trunk passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
compile
19m 42s

trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
checkstyle
3m 42s

trunk passed

+1 :green_heart:
mvnsite
2m 39s

trunk passed

+1 :green_heart:
javadoc
1m 55s

trunk passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javadoc
2m 29s

trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
3m 49s

trunk passed

+1 :green_heart:
shadedclient
21m 15s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 29s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
1m 33s

the patch passed

+1 :green_heart:
compile
21m 43s

the patch passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javac
21m 43s

the patch passed

+1 :green_heart:
compile
19m 37s

the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
javac
19m 37s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
3m 32s
/results-checkstyle-root.txt
root: The patch generated 29 new + 4 unchanged - 0 fixed = 33 total (was 4)

+1 :green_heart:
mvnsite
2m 38s

the patch passed

+1 :green_heart:
javadoc
1m 54s

the patch passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04

-1 :x:
javadoc
0m 48s
/results-javadoc-javadoc-hadoop-tools_hadoop-aws-jdkPrivateBuild-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07.txt
hadoop-tools_hadoop-aws-jdkPrivateBuild-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 generated 1 new + 39 unchanged - 0 fixed = 40 total (was 39)

+1 :green_heart:
spotbugs
4m  8s

the patch passed

+1 :green_heart:
shadedclient
21m 13s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
31m 58s

hadoop-common in the patch passed.

+1 :green_heart:
unit
2m 52s

hadoop-aws in the patch passed.

+1 :green_heart:
asflicense
1m  0s

The patch does not generate ASF License warnings.

232m 39s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3978/4/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/3978

Optional Tests
dupname asflicense mvnsite codespell markdownlint compile javac javadoc mvninstall unit shadedclient spotbugs checkstyle

uname
Linux f31a06407672 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 67f011a0ef63f319a74e03f0a75acc89a0d0825f

Default Java
Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3978/4/testReport/

Max. process+thread count
1281 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common hadoop-tools/hadoop-aws U: .

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3978/4/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
1m 11s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
markdownlint
0m  0s

markdownlint was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 5 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
12m 55s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
21m 43s

trunk passed

+1 :green_heart:
compile
22m 28s

trunk passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
compile
19m 46s

trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
checkstyle
3m 43s

trunk passed

+1 :green_heart:
mvnsite
2m 40s

trunk passed

+1 :green_heart:
javadoc
1m 57s

trunk passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javadoc
2m 33s

trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
3m 48s

trunk passed

+1 :green_heart:
shadedclient
21m 10s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 28s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
1m 35s

the patch passed

+1 :green_heart:
compile
21m 53s

the patch passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javac
21m 53s

the patch passed

+1 :green_heart:
compile
19m 51s

the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
javac
19m 51s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
3m 32s

the patch passed

+1 :green_heart:
mvnsite
2m 40s

the patch passed

+1 :green_heart:
javadoc
1m 51s

the patch passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javadoc
2m 34s

the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
4m 10s

the patch passed

+1 :green_heart:
shadedclient
21m 22s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
32m  7s

hadoop-common in the patch passed.

+1 :green_heart:
unit
2m 46s

hadoop-aws in the patch passed.

+1 :green_heart:
asflicense
0m 59s

The patch does not generate ASF License warnings.

233m 23s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3978/5/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/3978

Optional Tests
dupname asflicense mvnsite codespell markdownlint compile javac javadoc mvninstall unit shadedclient spotbugs checkstyle

uname
Linux a16af9ec9b1c 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 945a9d9bfbe07a11e49cb325daaeb3bf05eb88ef

Default Java
Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3978/5/testReport/

Max. process+thread count
1664 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common hadoop-tools/hadoop-aws U: .

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3978/5/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 47s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
markdownlint
0m  0s

markdownlint was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 5 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
12m 52s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
24m 20s

trunk passed

+1 :green_heart:
compile
27m  6s

trunk passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
compile
24m 53s

trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
checkstyle
4m 20s

trunk passed

+1 :green_heart:
mvnsite
2m 51s

trunk passed

+1 :green_heart:
javadoc
1m 47s

trunk passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javadoc
2m 27s

trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
4m 15s

trunk passed

+1 :green_heart:
shadedclient
24m 11s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 28s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
1m 49s

the patch passed

+1 :green_heart:
compile
26m 59s

the patch passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javac
26m 59s

the patch passed

+1 :green_heart:
compile
24m 25s

the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
javac
24m 25s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
4m 16s

the patch passed

+1 :green_heart:
mvnsite
2m 41s

the patch passed

+1 :green_heart:
javadoc
1m 41s

the patch passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javadoc
2m 36s

the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
4m 38s

the patch passed

+1 :green_heart:
shadedclient
24m 13s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
31m  3s

hadoop-common in the patch passed.

+1 :green_heart:
unit
2m 47s

hadoop-aws in the patch passed.

+1 :green_heart:
asflicense
0m 58s

The patch does not generate ASF License warnings.

261m 31s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3978/6/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/3978

Optional Tests
dupname asflicense mvnsite codespell markdownlint compile javac javadoc mvninstall unit shadedclient spotbugs checkstyle

uname
Linux 1634af7db360 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 3f3e1c4ba6c5f37181fa48ac077358846aa28990

Default Java
Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3978/6/testReport/

Max. process+thread count
1260 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common hadoop-tools/hadoop-aws U: .

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3978/6/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

.. not deliberately ignoring this, just falling behind on reviews while i try to get my manifest committer out the door. reviews there welcome, even though it targets abfs and gcs. #2971
i will pull some of this back into the s3a committer afterwards, including stat names and some IO enhancements to get parquet files writing faster (disabling existence/overwrite checks in __magic dirs)
#3289

patch is in, though i realise i forgot to add the pr# to the header, which is automatic when done through the UI. never mind, at least the JIRA Is in. closing this PR as done


Updates for OpenSAML support

Two major changes:

updated to OpenSAML 3.4. There were some package changes that occurred
rework the way the OpenSAML library is bootstrapped. Use of the Java service API to find a configuration service, and falling back to default configuration if none is found. This allows for finer control over the library that some developers might need.

LGTM. I earmarked this for 3.3.0.

opensaml 3.4 was released. I think this is ready for final review


would nice to have a column autoupdate

would nice to have a column autoupdate with info from cask if true

👍  thx


how to install?

noob here so don't know much about how to install this.
can you write a guide?

Does this work on a normal pc with no gpu, only cpu like faster-whisper?
Or only online using tpu? i saw another project which only used tpu. is this like this?
also, would love it if you guys can have standalone version like https://github.com/Purfview/whisper-standalone-win

Hi @deadcoder0904 - This does require a GPU to work. I'll add instructions for CPU inference later this week.

Does it work with cpu if we follow instructions on the README? It says exclusive to NVIDIA Gpu

@Herz3h not yet, I think we might CPU support this week: https://github.com/Vaibhavs10/insanely-fast-whisper/issues/46


Use CRR xref mapping file instead

To avoid check in huge xrefmap.yml in content repo directly...

:warning: Validation status: warnings

File
Status
Preview URL
Details

azurermps-4.4.1/AzureRM.DataFactories/index.md
:warning:Warning

Details

.openpublishing.publish.config.json
:white_check_mark:Succeeded

_xref/xrefmap0.yml
:white_check_mark:Succeeded

_xref/xrefmap1.yml
:white_check_mark:Succeeded

docfx.json
:white_check_mark:Succeeded

azurermps-4.4.1/AzureRM.DataFactories/index.md

[Warning] Failed to extract file creator information from git history.
[Warning] Uid(AzureRM.DataFactoryV2) has already been defined in azurermps-4.4.1/AzureRM.DataFactoryV2/index.md.

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


incorrect query used in rec_track_sat

Hi, I've started to get a grip on the code
I think this line
https://github.com/ScalefreeCOM/datavault4dbt/blob/c170e700505beca8d726eaa423830fe656c1f468/macros/tables/exasol/rec_track_sat.sql#L84
should be run_query(rsrc_static_query_source_count) ?
KR
Christoph

Hi @cmettler,
Correct, that should have been "run_query(rsrc_static_query_source_count)". It is implemented like this for the record tracking satellites of all adapters. Will add a corresponding branch to fix this!
Kind Regards
Tim


FlutterFragmentActivity not find setContentView

old project for Android.  import the flutter module. android project used androidx support aar.
my activity extends FlutterFragmentActivity , the "setContentView" error . i guess it's "androidx" reason.would you give me solution. thanks

@psujug did you manage to solve the issue?

Without additional information, we are unfortunately not sure how to resolve this issue. We are therefore reluctantly going to close this bug for now. Please don't hesitate to comment on the bug if you have any more information for us; we will reopen it right away!
Thanks for your contribution.


Updated Linux info

I updated the Linux related docs because they were out-of-date - here are key changes:
1.) Removed references to the GNOME networking issue since this was specific to older versions that are no longer in the free marketplace.  I only left this info in for the doc that provides steps to bring in a custom image.
2.) Made the docs more explicit on how to set up remote graphical desktop for specific distros/versions/etc along with links to the GitHub steps/scripts on how to configure them - note that all the fixes to the GitHub scripts have already been checked in prior to this.
3.) Updated the images showing how to enable RDP because they were from V1.

@nicolehaugen - the warnings would have to be fixed for this PR to be merged. Also, it's preferable for Microsoft staff to work in the private repo, so content changes go through validation and staging.
For details and instructions, see the Contributor Guide.

@nicolehaugen,
To add to the comment above:

Read about authors working in the public repo for more information.
If you need help getting set up to work in the private repo, see Get started contributing to the Microsoft Learn platform.

We'll close this PR. Thank you.

The validation errors are for updated image files - these files shouldn't be merged, and instead should overwrite the existing version.

@nicolehaugen - I'm unable to resolve the merge conflicts. Can you remove the images from the PR?  the merge conflict is likely because the images were changed in another PR and merged since you committed them.
@ntrogh

Can you review this PR? after @nicolehaugen has resolved the merge conflicts?
IMPORTANT: When this content is ready to merge, you must add #sign-off in a comment or the approval may get overlooked.

#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

I had issues with deleting the unused image files without merge conflicts - I have omitted the for now and will delete them in a follow up PR.  #sign-off

@ntrogh - can you sign off to merge this PR?  thanks!

@nicolehaugen @ntrogh - no substantive content changes since last sign-off ... only tweaks to address merge conflicts (in image calls). merging this. thanks @nicolehaugen  for following up to clean up the images in a future PR.
Note that usually PRs of this complexity should be submitted into the private repo azure-docs-pr ... @nicolehaugen here's some additional information if it's useful:

Microsoft authors and contributors should make content contributions through the private repository so the content can be staged and validated by the current validation rules.
After you make your changes in the private repo, review the articles on staging, and fix any validation issues, you can add the sign-off comment to let PR reviewers know that the updates are ready to be merged.
Read about authors working in the public repo for more information.
If you need help getting set up to work in the private repo, see Get started contributing to the Microsoft Learn platform.


End-to-end: restore 'pendingOps' suite

In order to reenable 'realsvc' test, I temporarily disabled this suite.
The suite passes locally, but encountered timeouts at 2000ms during CI.  Now attempting to reenable with an increased timeout.

Unfortunately at 20s it encounters test assertion failures.
I've seen two different test fail this way and it posses locally, so I'm guessing non-determinism?
leaving disabled and opening #6157 for tracking.  @wes-carlson - FYI.


Feature request: glm copy [--overwrite] {fromrepo} {torepo}

My top use case is getting a common subset of labels in sync across repos.
I'd like to be able to
glm copy my/repo1 my/repo2 # ignore duplicates, copy labels from repo1 which don't exist in repo2
glm copy --overwrite my/repo1 my/repo2 # as above, plus update colors and case of duplicates

Without this there's even no point in such tool as it's main use case for everyone.


Viewing a reporting period other than CY22Q3 returns "'This reporting period is cloesd"

Not able to upload files to a previous or (dummy) future quarter. I would like to do so, to illustrate to our partners next Monday the benefits of the audit report (comparison of key fields across quarters).
Assuming this bug is resolved I'm also not sure whether the audit report will pull submissions across reporting quarters.

this is not a bug, it's by design. you'll have to close the reporting period to begin uploading files for the next reporting period.


Bot no longer works after new GL version?

Is anyone else facing the same issue?

I'm pretty sure it's patched now.

Yeah. Seems to be the end for injections. Or we need to find another way. All the other sites that sold injections are saying that it won't work anymore. Ah too bad. Maybe someone else will find a way.

Server fixed exploit


Rancher, RDS, and IAM Integration

Today the documentation for Rancher includes instructions for bootstrapping a MySQL database. In every case the operator uses a predetermined user and password. Operators need to automate environment configuration but must compromise security to do so. Operators provide that secret material to any management nodes via user-data, CloudFormation templates (or parameters), or other automation tooling. This is tragic because the username and password become difficult to rotate. Users store the secrets in cleartext, and in some terrible cases source control.
The proper solution on AWS is to leverage IAM database authentication. Doing so would allow AWS to generate and rotate secrets automatically, push database communication over SSL, and drop any database bootstrapping requirements (you can already seed the initial database, this would allow you to seed user access).
Database security is a serious matter for businesses of any size, but cliché configuration shortcomings like these can be show stoppers for a major enterprise.

We generally avoid provider-specific integration in any of the core code... Couldn't this be done with a generic local proxy and no Cattle/client change?

I completely understand the hesitance. However, there are few providers that actually offer a complete solution like AWS does. I'm not sure that running a local proxy which forwards unauthenticated requests over SSL to be executed as an admin user would fly with enterprise customers any more than cleartext passwords. The authentication mullet proxy - if such a thing exists today - would be a fantastic opportunity for misconfiguration.
The majority of my clients use AWS and of my clients exactly 0% want to run their own databases. Integrating with RDS this way makes it easier to adopt Rancher securely on AWS than not. The superior provisioning experience alone would be worth the integration. Avoiding cleartext root database user credentials is a really nice benefit.

I'm not very familiar with this part of AWS, but if there is a standalone service that can manage/broker credentials on container starts, then it would be pretty straightforward to inject them.
https://github.com/rancher/rancher/blob/master/server/artifacts/cattle.sh#L59

I hoped that I could do this when I was reading about IAM DB credentials, but unfortunately the integration requires that clients use token based authentication (generated using EC2 instance role credentials and db parameters). There is a code sample for Java here.
 I had hoped that they were signed with Amazon's public CA so that we could avoid injecting custom trust stores. That does not seem to be the case.

If you're already executing code on the host or in the server container then you can just make your own request to get credentials from RDS and talk to it directly.  Having a separate process do that work for you and present a (local) interface compatible with the standard client doesn't fundamentally change the security.

FWIW <15% of active Rancher installs (opted in to telemetry) have their server container on AWS.

Your point about the local proxy is well taken. However, its still not a good idea for all the same reasons that running with unauthenticated local connections on LAMP stacks was a bad idea. It is way too easy to accidentally bind to the wrong interface
Interesting to see the data on the Rancher install base. I would never have guessed. Have those numbers been sanitized for "demo" environments or workstation installs? Is longevity measured? I can't count the number of Rancher labs I've setup in the past.
Anecdotally many AWS users I know are on ECS because its a default solution. I'd hope that is a mindset that Rancher can help change. Making it simple install while getting the most from AWS RDS authentication would be a nice way to further that story.

Thanks for your report!
With the release of Rancher 2.0, development on v1.6 is only limited to critical bug fixes and security patches.
If you think we should keep this issue open, please let me know.


Respect hash-equivalent literals in iteration-over-set

Summary
Closes https://github.com/astral-sh/ruff/issues/14049.

Welcome back, HashableExpr!

New HashableExpr just dropped

Ah wait this doesn't work for tuples.


Making relations available for other fieldtypes i.e assets, taxonomies …

Hi, thank you so much for your addon. I've was desperately in the need for something like it and build some solution on my own which worked for the project but was not really a addon.
Different project right now where I have relationships between assets and originally taxonomies (which can not really be asigned to assets unfortunately), changed it to a custom collection since I was hoping that one entry would do the magic, but I does not.
Therefore the question – is there a way to alter the code that the addon is also working for non entry / collections?
In my case I would like to have a one to many taxterm -> assets, or if this is super special, rather assets -> entry of a collection
Thank you!

This is something I have started to think about/explore with #2 (the work to refactor to support Users would largely be applicable to the other types of stored content that supports the various required events).
I am still thinking through how that would look (and not break existing implementations). Right now, I am considering something like this (where books is a collection with an author User field, and user:id references the id field on a User resource):
Relate::oneToMany(
    'books.author',  // No prefix defaults to `entry:` for backwards compatibility.
    'user:id' // The `user:` prefix indicates this is a User resource.
);

For a book containing an author, and a cover image stored as an Asset, this may look like this:
Relate::oneToOne(
    'books.cover_image',
    'asset:container_name.field'
);

Relate::oneToMany(
    'books.author', 'user:id'
);

This would be amazing for Entries to Taxonomies

This would be amazing for Entries to Taxonomies

This is quite a popular request. Relationship support for Taxonomy Terms will be available in the next release (no timelines to disclose in case things crop up in testing) 🙂

Bi-directional support for taxonomy support is available starting with 1.2.0

Hi @JohnathonKoster! Big thanks for the awesome plugin first of all.
Just curious if you have any plans to add assets support as well? Having a particular many-to-many use case where "downloads/files" need to be related to a "product" and vice-versa knowing which products particular assets are related to, and this would solve it perfectly.

Hi @JohnathonKoster! Big thanks for the awesome plugin first of all.
Just curious if you have any plans to add assets support as well? Having a particular many-to-many use case where "downloads/files" need to be related to a "product" and vice-versa knowing which products particular assets are related to, and this would solve it perfectly.

It's something that I can look into (would have to get a few new events added to Statamic itself); and need to think through asset replacements/uploads. Will let you know! 🙂