Develop and Build duplicates chromium src

Looks like python build.py doesn't use already downloaded and unpacked chromium src at build/src, it redownloads and unpacks again.

Also to build I need to remove already unpacked src? why not separate dev/src and build/src?


DX11 games do not work with DXVK >0.6

I am a bit confused about this, the last three releases of DXVK simply do not run for me. I only have two games that make use of D3D11: Diablo III and Skyrim Special Edition. D3 will show a crash window at some point trying to start up, and Skyrim will simply create an empty window that will sit there for ever (I even left it for an hour thinking that maybe all shaders were being compiled). I have to kill the process. I have no issues with DXVK 0.54 in neither games.
Software information
Fedora Workstation 28, up to date, kernel 4.17.5
System information

GPU: GTX 1080
Driver: 396.24
Wine version: 3.11-staging, 3.12-staging
DXVK version: 0.6, 0.61, 0.62
In the process of getting the apitrace and logs

Unfortunately, DXVK requires at least vulkan beta driver 396.24.02 or the new 396.24.10 beta driver. If you can't get those then you will have to stay on v0.54 until a new stable driver comes out.

Makes sense. I rather install from package manager, but I will install 396.24.10 from nvidia.

See #435 and the driver support page in the Wiki....


DOC-7539: Manage channel bookmarks page needs animated GIFs for mobile app workflows

Summary
This PR adds visual workflows for the Mattermost mobile app tab on the Manage channel bookmarks page.
Ticket Link
Fixes #7539

[x] This PR follows Mattermost Contributing Guidelines.
[x] The changes are tested in a local docs build.

Hello @Rutam21,
Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

@cwarnermm Please review and suggest changes, if any. Thanks.
@lindy65 Please add this to my queue for QA Testing, if needed. Thank you.

Assigned you for testing @Rutam21 👍

@Rutam21 - Would you be able to crop the mobile images in step 4 where there's considerable empty whitespace? Here's an example:

Really loving the animated captures!

Sure, consider it done. I will push a new commit for that. And, thanks. I thought GIFs would serve the purpose better.

@cwarnermm I have added the cropped images.


Document jest.setTestTimeout()

Summary
This is to document a new method so consumers will know it exists.
Test plan
This is just documentation so there isn't any code to test.

awesome! thanks @sandersky


Potential pattern of ignoring stranded RPC workers

While trying to understand why we'd encounter rexi:init_stream errors in https://github.com/apache/couchdb/issues/5122 I believe I've identified a pattern present in at least four of the fabric RPC related modules. I think fabric_view_all_docs.erl is a relatively straightforward representation of the issue, so I'm going to dissect the flow from there.
Step 1) Instantiate RPC workers
We first create a set of RPC workers on the remote nodes as specified in Shards. This creates the handle Workers0 with a set of references to all instantiated RPC workers.
    Workers0 = fabric_util:submit_jobs(
        Shards, fabric_rpc, all_docs, [Options, WorkerArgs]
    ),

Step 2) create a set of monitors for all remote nodes
    RexiMon = fabric_util:create_monitors(Workers0),

This creates a set of monitors on the relevant remote rexi processes for each of the nodes in question, not the workers themselves:
create_monitors(Shards) ->
    MonRefs = lists:usort([rexi_utils:server_pid(N) || #shard{node = N} <- Shards]),
    rexi_monitor:start(MonRefs).

Step 3 handle fabric_streams:start in a try ... after .... end block
    try
        case fabric_streams:start(Workers0, #shard.ref, RingOpts) of
            ...
        end
    after
        rexi_monitor:stop(RexiMon)
    end

This invokes fabric_streams:start in a try block so that after we invoke rexi_monitor:stop(RexiMon) to clear out the monitors.
Step 4) handle the inner case clauses of Step 3)
First off we have the successful case when the stream has been initialized:
            {ok, Workers} ->
                try
                    go(DbName, Options, Workers, CoordArgs, Callback, Acc)
                after
                    fabric_streams:cleanup(Workers)
                end;

The key thing of note here is that this clause performs a fabric_streams:cleanup(Workers) in the after clause of a try block to ensure the remote workers are cleaned up after the job is done.
However, the cleanup is performed against the subset of workers selected to perform the job in Workers, not the original full set of RPC workers instantiated and stored in Workers0.
Next we have the two failure cases for this fabric operation. I'll lump them together as their behavior is identical:
            {timeout, NewState} ->
                DefunctWorkers = fabric_util:remove_done_workers(
                    NewState#stream_acc.workers, waiting
                ),
                fabric_util:log_timeout(
                    DefunctWorkers,
                    "all_docs"
                ),
                Callback({error, timeout}, Acc);
            {error, Error} ->
                Callback({error, Error}, Acc)

Both of these failure clauses bubble up the error through the caller provided Callback, however, neither performs any cleanup of the workers. In the outer after clause we do a rexi_monitor:stop(RexiMon) but that's basically a no-op to kill the dedicated monitoring process.
Core Issue
I think there are two things going on here we need to address:

RPC workers are not cleaned up at all upon fabric_streams:start error modes

I think this is fairly straightforward here, we should always ensure workers are cleaned up, especially when failures happen. Basically I think we should do a fabric_streams:cleanup on the workers in the outer after clause so they're always cleaned up.

when we do call fabric_streams:cleanup(Workers) it's on Workers instead of Workers0

This might be a bit more controversial, but I suspect one of the ways in which https://github.com/apache/couchdb/issues/5122 manifests is because we're not diligent about canceling RPC workers. It's possible that fabric_streams:cleanup(Workers) is sufficient, but I think fabric_streams:cleanup(Workers0) against the full original set of workers is appropriate.

bonus item: we should consider moving the cleanup logic to the rexi_mon monitor

The core rationale here is that after clauses do not trigger when a process is killed, leaving the possibility of remote zombied RPC workers. In theory the remote nodes' rexi_server processes should get a process down notification? Again, perhaps that's sufficient, I'm personally inclined to do double bookkeeping in these types of scenarios, where we monitor from the RPC and also send out a kill signal from the coordinator side. What do folks think?
Presence in the codebase
Right now I think I've identified this pattern in the four following fabric modules, although I've not done a full audit of the other modules so there may be more instances of this:

https://github.com/apache/couchdb/blob/main/src/fabric/src/fabric_view_all_docs.erl#L28-L54
https://github.com/apache/couchdb/blob/main/src/fabric/src/fabric_view_map.erl#L45-L84
https://github.com/apache/couchdb/blob/main/src/fabric/src/fabric_view_reduce.erl#L36-L73
https://github.com/apache/couchdb/blob/main/src/fabric/src/fabric_view_changes.erl#L173-L219

Looks like dreyfus_rpc does the right thing and cleanup the Workers in the outer after clause https://github.com/apache/couchdb/blob/main/src/dreyfus/src/dreyfus_fabric_search.erl#L147 and it looks like that's the full list of workers too, not just the winning shard range workers. I suggest, at a minimum, we follow the same pattern from dreyfus_rpc and do cleanup on the full set of workers in the after clause.
I say "at a minimum" because I think we should consider moving the cleanup to the dedicated rexi_mon process such that if the coordinator process dies it'll still have the workers cleaned up. This is definitely a secondary concern compared to the main source of stranded workers in this ticket, but still worth considering.

Good finds @chewbranca! Clearly there is something broken here and we should fix. Thanks for the detailed analysis!

we should consider moving the cleanup to the dedicated rexi_mon process

For streams we already have a cleanup process spawned for every streaming request https://github.com/apache/couchdb/blob/main/src/fabric/src/fabric_streams.erl#L47. We should see why that doesn't clean up the workers and lets them timeout instead.
Perhaps it's too cautious to avoid sending unnecessary kill messages? It tries to use the rexi_STREAM_CANCEL which makes the worker exit normal, instead of killing it to avoid generating sasl generate sasl logs. But perhaps that won't happen as those workers are not gen_servers?
Recently we also added a kill_all command to aggregate kill commands per node, so instead of sending one per shard, it's one per node with a list of refs, maybe that's enough to keep the overhead of the extra kills fairly low.
Another thing to keep it mind is that we don't always want to kill the workers, at least in the update docs path we specifically allow them to finish updating to reduce the pressure on the internal replicator.

Looks like dreyfus_rpc does the right thing and cleanup the Workers in the outer after clause

Dreyfus doesn't use the streams facility, so likely has a slightly different way to doing cleanup. There is also the complication of replacements if they are spawned, those have to be cleaned up as well. However if we do a blanket kill_all for all the workers then it should take care of that, too. But, it would nice to see what corner cases we're missing currently. Which errors are generated and if it's triggered by some error or just a race condition...
Do you have a easily reproducible scenario to test it out?

Having failed to reproduce this locally so moved on to investigate on a cluster where this error happens regularly.
Found a cluster where exit:timeout stream init timeout errors happen up to 4000 times per minute. Noticed most of them are not generated by an error in the coordinator or the workers. The processes will generate those are calls to fabric:design_docs/1 from the ddoc cache recover logic. The calls seem to not generate any failures except the left-over workers in the stream_init state, waiting or stream start/cancel messages, which was rather baffling at first.
However after a more thorough investigation, the reason for that is that design docs are updated often enough that the ddoc cache is quickly firing up and immediately kill the fabric:design_docs/1 process. There is nothing to log an error and since these are not gen_servers registered with SASL they don't emit any error logs, as expected.
In general, we already have a fabric_streams mechanism to handle the coordinator being killed unexpectedly. However tracing the lifetime of the fabric:design_docs/1 processes, the coordinator is often killed before it gets a chance to even start the auxiliary cleanup process. The current pattern is something like this:
We submit the jobs:
https://github.com/apache/couchdb/blob/d0cf54e1ef5c7e67fe08c29c5e80a1b77ca614e7/src/fabric/src/fabric_view_all_docs.erl#L28-L30
Then we spawn the cleanup process:
https://github.com/apache/couchdb/blob/d0cf54e1ef5c7e67fe08c29c5e80a1b77ca614e7/src/fabric/src/fabric_streams.erl#L49-L51
Those may seem like they would happen almost immediately, however tracing the init_p call on the workers side, and trying to log the process info of the caller (coordinator), by the time the init_p function is called, the coordinator is already dead. Since we never spawned the cleaner process yet, there is nothing to clean up these workers.
On the positive side, these workers don't actually do any work, they just wait in a receive clause, albeit with an open handle Db handle which is not too great.
To fix this particular case we have to ensure the cleaner process starts even earlier. By the time the coordinator submits the jobs the cleanup process should be up and waiting with the node-ref tuples ready to clean them up.

So far in production we noticed most of the cases of exit:timeout errors generated by rexi:init_stream came from quick killing of design doc fetches from ddoc cache. That should be fixed by https://github.com/apache/couchdb/pull/5152. However, the analysis above is also correct that we do not clean up workers on error or timeouts. Except for a few expected error types only:
https://github.com/apache/couchdb/blob/a2241d36621e6bee101aad0d1bf19e52de1be3aa/src/fabric/src/fabric_streams.erl#L168-L171
In this PR we improve cleanup and perform cleanup for all stream start errors, including timeouts.


[docs] Demo SearchIcons crashes

[x] I have searched for similar issues in this repository and believe that this is not a duplicate.

Steps to Reproduce

Visit https://mui.com/pt/components/material-icons/?query=qr
Click in any icon
demo SearchIcons crashes

Your Environment

Tech
Version

MUI
v5.2.5

netlify deploy
https://61c098e520eae9000736c0df--material-ui-docs.netlify.app

Browser
Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/95.0.4638.69 Safari/537.36 OPR/81.0.4196.61

Duplicate of #30304


Irregular order of devices make PSVR on Mac untrustworth

Note the following output as the right HID devices are being found on a Mac:
054c:09af IOService:/AppleACPIPlatformExpert/PCI0@0/AppleACPIPCI/XHC1@14/XHC1@14000000/PRT2@14200000/PlayStation®VR@14200000/PS VR Control@5/IOUSBHostHIDDevice@14200000,5
opening
054c:09af IOService:/AppleACPIPlatformExpert/PCI0@0/AppleACPIPCI/XHC1@14/XHC1@14000000/PRT2@14200000/PlayStation®VR@14200000/PS VR Sensor@4/IOUSBHostHIDDevice@14200000,4
054c:09af IOService:/AppleACPIPlatformExpert/PCI0@0/AppleACPIPCI/XHC1@14/XHC1@14000000/PRT2@14200000/PlayStation®VR@14200000/PS VR Control2@8/IOUSBHostHIDDevice@14200000,8
054c:09af IOService:/AppleACPIPlatformExpert/PCI0@0/AppleACPIPCI/XHC1@14/XHC1@14000000/PRT2@14200000/PlayStation®VR@14200000/PS VR Sensor@4/IOUSBHostHIDDevice@14200000,4
054c:09af IOService:/AppleACPIPlatformExpert/PCI0@0/AppleACPIPCI/XHC1@14/XHC1@14000000/PRT2@14200000/PlayStation®VR@14200000/PS VR Control2@8/IOUSBHostHIDDevice@14200000,8
opening
054c:09af IOService:/AppleACPIPlatformExpert/PCI0@0/AppleACPIPCI/XHC1@14/XHC1@14000000/PRT2@14200000/PlayStation®VR@14200000/PS VR Control@5/IOUSBHostHIDDevice@14200000,5

The first 3 lines (+opening) are finding the sensor device, the next 3 finding the control device.
First time around its control, sensor and control2
Second time around its sensor, control2 and control
Needless to say the control is now used as sensor, and control2 as control...

Yups, tested and merged to master


on a same line only the first undocumented variable is indicated

Minor issue. Also when a comment is finally added then the variables 1..$ are not detected at all.
e.g
int a,b ; // variable a is not ....

/// some DDOC
int a,b ; // no message for b

/// some DDOC
int a, b;

results in documentation for a and b though and not just for a, so that behavior is correct


Creation of Replay Pipeline for Splunk export

@rarsan I standardized the input variable for template path, and switched to use the local template path variable like in replay.tf. Let me know if that's what you were thinking!


Scroll position not updating well when using line break on iOS

When using line break on iOS I have the following behavior :

Scroll position is not updating except if I type something from keyboard.
I removed ScrollView component in the CNRichTextEditor.js file and I also removed the scrollEnabled TextInput prop in CNTextInput.js file and I have the following behavior :

Do you think the ScrollView component can be removed to keep the default scroll behavior of TextInput ?
Note : on Android everything works fine for both cases

@rmarquois I just tried your proposal. It indeed makes a better UI experience, however it doesn't work when you implement image upload. Apparently, editor creates array of rn elements and when you upload image next text input is below the image. Since scrollview is gone you cannot scroll anymore.

Interesting, I 'll investigate this further

Hey, I just released a new version 1.0.34 of the library.
Please try the new version and see if it addresses your issue. If not, please open a new issue.


jquery spectrum set value

This jquery plugin is working awesome but i am unable to find this kind of functionality like i am having this colorpicker in a foreach loop. In every iteration i have different color to set regarding this colorpicker dynamically.. i need to iterate colorpicker corresponding to number of records. Please do the needful.

Adding this attribute (data-color="#4c9625" ) to your picker will show different color for each picker.


Support for Urdu language

Issue Summary
Add locale for urdu lanuage.
Steps to Reproduce
NA
Ghost Version
5.67.0
Node.js Version
18.17.0
How did you install Ghost?
Set-up development on my MacOS
Database type
MySQL 5.7
Browser & OS version
No response
Relevant log / error output
No response
Code of Conduct

[X] I agree to be friendly and polite to people in this repository

If you're able to add the language, please read https://forum.ghost.org/t/help-translate-ghost-beta/37461 and submit a PR to do so 🙂

RTL languages are not support by Ghost yet. Urdu is an RTL lang so we might need to close this issue 😪


[spaceship] Fix: use Time instead of Date to detect the latest app store version

Checklist

[x] I've run bundle exec rspec from the root directory to see all new and existing tests pass
[x] I've followed the fastlane code style and run bundle exec rubocop -a to ensure the code style is valid
[x] I see several green ci/circleci builds in the "All checks have passed" section of my PR (connect CircleCI to GitHub if not)
[x] I've read the Contribution Guidelines
[x] I've updated the documentation if necessary.

Motivation and Context
The get_latest_app_store_version method is supposed to return the latest version on the store, regardless of the state associated with that version. However, while parsing the timestamps, it uses Date. Since Date disregards time, issues around the newness of a version can arise.

If there are two releases on the same day (one delivered and another inflight), it seems like Date.parse will simply preserve the order returned in the original array. This leads to ambiguity in the latest version.
Mapping the data,
irb(main):028:0> app.app_store_versions.map { |v| [v.app_store_state, Date.parse(v.created_date)] }
=>
[["WAITING_FOR_REVIEW", #<Date: 2023-04-11 ((2460046j,0s,0n),+0s,2299161j)>],
 ["READY_FOR_SALE", #<Date: 2023-04-11 ((2460046j,0s,0n),+0s,2299161j)>],
 ["REPLACED_WITH_NEW_VERSION", #<Date: 2023-03-24 ((2460028j,0s,0n),+0s,2299161j)>],
 ["REPLACED_WITH_NEW_VERSION", #<Date: 2023-03-20 ((2460024j,0s,0n),+0s,2299161j)>],
 ["REPLACED_WITH_NEW_VERSION", #<Date: 2023-03-14 ((2460018j,0s,0n),+0s,2299161j)>],
 ["REPLACED_WITH_NEW_VERSION", #<Date: 2023-03-10 ((2460014j,0s,0n),+0s,2299161j)>],
 ["REPLACED_WITH_NEW_VERSION", #<Date: 2023-03-09 ((2460013j,0s,0n),+0s,2299161j)>],
 ["REPLACED_WITH_NEW_VERSION", #<Date: 2023-03-09 ((2460013j,0s,0n),+0s,2299161j)>],
 ["REPLACED_WITH_NEW_VERSION", #<Date: 2023-02-28 ((2460004j,0s,0n),+0s,2299161j)>],
 ["REPLACED_WITH_NEW_VERSION", #<Date: 2023-02-25 ((2460001j,0s,0n),+0s,2299161j)>]]

Sorting the data,
irb(main):030:0> app.app_store_versions.sort_by { |v| Date.parse(v.created_date) }
=>
[#<Spaceship::ConnectAPI::AppStoreVersion:... @app_store_state="REPLACED_WITH_NEW_VERSION", @created_date="2023-02-25T03:02:46-08:00" ...>,
 #<Spaceship::ConnectAPI::AppStoreVersion:... @app_store_state="REPLACED_WITH_NEW_VERSION", @created_date="2023-02-28T04:43:31-08:00" ...>,
 #<Spaceship::ConnectAPI::AppStoreVersion:... @app_store_state="REPLACED_WITH_NEW_VERSION", @created_date="2023-03-09T04:09:27-08:00" ...>,
 #<Spaceship::ConnectAPI::AppStoreVersion:... @app_store_state="REPLACED_WITH_NEW_VERSION", @created_date="2023-03-09T11:40:56-08:00" ...>,
 #<Spaceship::ConnectAPI::AppStoreVersion:... @app_store_state="REPLACED_WITH_NEW_VERSION", @created_date="2023-03-10T01:00:02-08:00" ...>,
 #<Spaceship::ConnectAPI::AppStoreVersion:... @app_store_state="REPLACED_WITH_NEW_VERSION", @created_date="2023-03-14T06:26:50-07:00" ...>,
 #<Spaceship::ConnectAPI::AppStoreVersion:... @app_store_state="REPLACED_WITH_NEW_VERSION", @created_date="2023-03-20T04:37:23-07:00" ...>,
 #<Spaceship::ConnectAPI::AppStoreVersion:... @app_store_state="REPLACED_WITH_NEW_VERSION", @created_date="2023-03-24T09:10:25-07:00" ...>,
 #<Spaceship::ConnectAPI::AppStoreVersion:... @app_store_state="WAITING_FOR_REVIEW", @created_date="2023-04-11T22:45:25-07:00" ...>,
 #<Spaceship::ConnectAPI::AppStoreVersion:... @app_store_state="READY_FOR_SALE", @created_date="2023-04-11T09:28:49-07:00" ...>]

Even though, the WAITING_FOR_REVIEW release is newer, get_latest_app_store_version thinks the READY_FOR_SALE is latest one.
Description
Use Time instead of Date. Fastlane does appear to be using Time.parse is various other places in the codebase. And this usage seems to be the only one that uses Date.parse. We can also see that Apple clearly returns the created_date with time in the ISO 8601 format. Like so,
2023-03-14T06:26:50-07:00
2023-03-24T09:10:25-07:00

Testing Steps
I couldn't not directly find a way to write specs, happy to add them in an appropriate place with some assistance.

Could someone help me with this PR? The CircleCI Pipeline is red and I'm not sure how to correct that.

This is still on my radar. I will come back to this soon.


[WIP] - allow inquiry_questionnaire modals to be closed via x button, click outside or escape

The first step to address https://artsyproduct.atlassian.net/secure/RapidBoard.jspa?rapidView=39&projectKey=EV&modal=detail&selectedIssue=EV-27

Still need to kill redundant now 'nevermind' link at the bottom of the dialog. Checking with analytics team if it'll have any implications.

@oxaudo This PR is pointing to the wrong branch, it should go into feature-add-accepts-card-payments-indicator

(I deleted my previous comment, because I wasn’t paying close attention. This PR was probably meant to go into master rather than the QA deployment.)

The changes look good to me thus far. Once you hear back and no further changes are needed, feel free to merge 👍

Yea, this one is unrelated to credit card display so should be treated independently. I confirmed that we are ok with removing ‘never mind’ link and all associated events and will add that removal here a bit later. I know that Eloy will be out next two weeks so will ask somebody else to take a look before merging. All of that will probably happen on Monday:)
Sent from my iPhone

On Apr 13, 2018, at 4:44 PM, Eloy Durán<EMAIL_ADDRESS>wrote:
The changes look good to me thus far. Once you hear back and no further changes are needed, feel free to merge 👍
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

👍 looks good to me!


Feature/Gold and Item Tracking

Feature Name: Gold and Item Tracking
Context:

As a player
When I acquire gold or items
Then I want a way to track that gold and those items

Description:
We can add a command like !dungeon inventory or something like that which lets you interact with the amount of gold you have stored or even track items
!dungeon inventory -gold 10 could add 10 gp to the inventory
!dungeon inventory -add "Potion of Healing could add a potion of healing
!dungeon inventory -remove "Potion of Healing" could remove that potion of healing
Benefits: Makes tracking rewards in the dungeon easier and makes sure players know when they have healing potions or other
Cons: The commands might be a bit complicated - tracking items might also be complicated
Mitigations to cons We should automate as much of it as possible, whilst still giving players the control to manage their inventories

https://github.com/Sykander/downtime-dungeon/pull/54


Unicode error with python3

I was running a script that imported itty and whenever I run it using python3 I get this error:
Traceback (most recent call last):
File "connect_cisco_bot.py", line 1, in
from itty import post, run_itty
File "/home/ubuntu/.local/lib/python3.5/site-packages/itty.py", line 588
except UnicodeError, e:
^
SyntaxError: invalid syntax
When I run it with python2.7 it works fine.

I'm getting the same issue using Python 3.7.3 in environment mode:
File "test.py", line 3, in
from itty import *
File "/Users/yyy/Documents/projects/python/log/lib/python3.7/site-packages/itty.py", line 588
except UnicodeError, e:
^
SyntaxError: invalid syntax

I get the same issue using Python 3.9.9 on mac:
>>> from itty import get, run_itty
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/usr/local/lib/python3.9/site-packages/itty.py", line 588
    except UnicodeError, e:
                       ^
SyntaxError: invalid syntax

🤦🏻♀  Ok, I found the correct repo for python3 support: https://github.com/toastdriven/itty3/
(Just leaving a breadcrumb here for anyone else who ends up here.)


ci: Update submodules automatically before building packages

Changes:

Update void-packages to 3288eca
Update submodules automatically before building packages 520d099

It only updates the submodule whenever there are new changes from void-packages or apindex

I'll take a look into this later, am on my phone right now.

LGTM, thanks!

Ah, dang. Gotta revert the changes due to the error remote: error: Changes must be made through a pull request. : https://github.com/xdeb-org/voidlinux-repository/actions/runs/7369335515/job/20054532494
Which is what I wanna keep active for this repository.

Ah, dang. Gotta revert the changes due to the error remote: error: Changes must be made through a pull request. : https://github.com/xdeb-org/voidlinux-repository/actions/runs/7369335515/job/20054532494
Which is what I wanna keep active for this repository.

Ahh I see, imma take a look at permissions if it needs something. Not a big deal if this doesn't get into stream.

Already reverted, no need to look it up. I think it's best to keep it on a PR / push to master basis.


License?

Friendly reminder to add a (BSD 3-Clause?) license. I realise this project is still in development.

Yes, in a very, very early state. Together with BLE Library and nRF Toolbox projects on develop branch. I will add the the licence, of course.
I'm glad you took a look at it. I'll push some breaking changes today, hoping someone except me will check if the lib is useful.


Interthreshold calib

All remarks from https://github.com/JPETTomography/j-pet-framework-examples/pull/85 are done.
This is a separate PR as I cannot push to Magdas branch.

retest it, please

Done. Last commit is containing new stuff. Others are cosmetics.


Use pg_ls_tmpdir() in check_temp_files

PostgreSQL 12 introduced function pg_ls_tmpdir to list live temp files
in a given tablespace. This function requires the pg_monitor privilege

As per issue #231


Cannot find the plugin in the logseq marketplace

Hi,
Thanks for creating the plugin 👍🏼
I am trying to follow the installation using logseq marketplace and I cannot find the plugin there.

Best
Laurent

I just tried now, and can see it


missing android platform

design-token-transformer/config.json missing android support

Hey, we are working on adding more support, per chance android was actually the first one with examples added:
here are all transformers: https://github.com/lukasoppermann/design-token-transformer/tree/main/src
Here is the android example: https://github.com/lukasoppermann/design-token-transformer/tree/main/examples/android

Using this file as input, I expect to see an Android build output with colors for Android, like there is for ios and ios-swift.
Ideally I would like Android Jetpack Compose compatible files, but xml is fine, too.
But no android folder is created when following the readme.

Export my colors from figma
place the file in ./token/, overwriting the sample file
npm run transform-tokens

When I then run the android task, it says it cannot find inputs for colors
 node ./examples/android/build.js

android
No properties for values/font_styles.xml. File not created.
No properties for values/dimens.xml. File not created.
No properties for values/colors.xml. File not created.
No properties for values-night/colors.xml. File not created.
Copying ./examples/android/filesToCopy/font_family.xml to ./examples/build/android/font/font_family.xml

Now the android folder is created, but as the cli output hints at, its only the template font file that gets created

Edit: had to create a new issue because this one is closed: #56


[Issue-1285] - adds ability to manage federations to TP and TO API

fixes #1285

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/incubator-trafficcontrol-PR/594/
Test PASSed.

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/incubator-trafficcontrol-PR-trafficops-test/550/

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/incubator-trafficcontrol-PR/595/
Test FAILed.

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/incubator-trafficcontrol-PR-trafficops-test/551/

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/incubator-trafficcontrol-PR/596/
Test PASSed.

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/incubator-trafficcontrol-PR-trafficops-test/552/

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/incubator-trafficcontrol-PR/597/
Test PASSed.

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/incubator-trafficcontrol-PR/598/
Test PASSed.

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/incubator-trafficcontrol-PR-trafficops-test/553/

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/incubator-trafficcontrol-PR-trafficops-test/554/

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/incubator-trafficcontrol-PR/599/
Test PASSed.

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/incubator-trafficcontrol-PR-trafficops-test/555/

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/incubator-trafficcontrol-PR/601/
Test PASSed.

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/incubator-trafficcontrol-PR-trafficops-test/557/

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/incubator-trafficcontrol-PR/603/
Test PASSed.

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/incubator-trafficcontrol-PR-trafficops-test/559/


Sending Data

How do I send data/stream to this controller from my c# program?

I don't think anyone did enough reverse engineering on the original firmware to help. Most people use these cards to run their own bitstream to do not-necessarily-LED-related-things.


Write documentation for data generation strategies, custom check registration, ordered columns

#314 introduces a new features: generating synthetic data from a schema! Need to write documentation for this:

data synthesis strategies

basic usage (interactive)
pytest usage
using Checks as constraints
gotchas with Checks

custom check + strategy registration
ordered columns

fixed by #354


Building Images ip instructions should be more specific

and copy the value next to 'IPV4 Address'.

should be

and copy the value next to 'IPV4 Address' under 'Ethernet adapter vEthernet (WSL)'.

Should be this address:

Though, I haven't tested whether the "Ethernet adapter vEthernet (WSL)" IPv4 address works too

I believe both will work

In which case, did we want to change the .env lines that require user input from {IPV4 HERE}  to export WSL_HOST=$(ip route | awk '{print $3; exit}') ? i believe this automatically gets the vEthernet WSL

I am on wifi and have "Wireless LAN adapter Wi-Fi" which does not work for me, but that may just also be that my LAN is a bit sus, either way I believe that pointing it to the vEthernet WSL is a better default.

In which case, did we want to change the .env lines that require user input from {IPV4 HERE} to export WSL_HOST=$(ip route | awk '{print $3; exit}') ? i believe this automatically gets the vEthernet WSL. btw this was just copied from my ubuntu bashrc file but we'd change it to SIM_HOST= not export WSL_HOST=

I attempted to add a subshell (the $(...)) into the envfile before but makefiles dont support it.
I see you've updated the wiki already @b1n-ch1kn so will close this issue.

ah oh well, for now a fixed IP works


Support for Multi-Root Workspaces

We use multi-root workspaces because we have several dependant apps. This works very well but the object designer does not like that (it shows "discovering objects..." but then nothing happens. Opening just one single app folder works as intended).
Furthermore the .alcache folder will be created in the first root folder instead of the one i'am currently working on.
I think it should be possible to open the object designer based on the context on the current root folder i'am working on right now. Or maybe let me select the folder/context i want to show the designer for.

Multi-root support is a main goal that I thought is working well. Although, I have faced similar issues myself when started working on a real-life multi-root project :)
There are several alpha build in the 0.0.7-dev branch, where fixes were made in connection with "discovering objects" and multi-root issues. Latest 0.0.7-alpha.9 build
In the new build it works as follows:

First workspace folder is regarded as the main folder where .alcache folder is created
Downloaded Symbols are collected and processed from all workspace folders
Fixed: only distinct symbols are processed to avoid duplications
Object Designer windows shows all objects in the workspace, regardless of the currently selected context. So you can oversee the entire project-set
In the new alpha version "Application" column has correct values, so it's easy to see where an object belongs to.

Perhaps, an extension setting would be better if you want to override the path of .alcache folder?


Linux Native Lua Binaries Needed

Its time we support Linux (I will add x86_64 support)!
If you have a Linux on ARM64 cpu, your assistance is needed (Read Below)!
This is how you download and build lua.
curl -L -R -O https://www.lua.org/ftp/lua-all.tar.gz
tar zxf lua-all.tar.gz
cd lua-all
make -j $(nproc) all

Each sub folder in lua-all will have a .so file associated inside of it resulting from the build.
This is how you download and build luajit.
git clone https://luajit.org/git/luajit.git
cd luajit
make -j $(nproc) all

Collect each minor versions highest patch number (5.4.6, 5.3.6, 5.2.4, 5.1.5) and rename the so appropriately (lua546.so, lua536.so, lua524.so lua515.so) For luajit, retain the name of lua51.so.
Move these so's to runtimes/linux-arm64/native. example About RIDs

HI @tilkinsc , is there a branch available where we can test the linux x64 binding?

When you build luajit, you need to have all the symbols available. I was trying to build these .so's for Linux, but ran into issues with the lua headers themselves.  If you look at lua.h there is no reference to dlls for anything other than windows. I was going to experiment to see if I could create either a custom configuration or if I could jerry rig the .a (which should have everything necessary) into a dll as the path of least resistance. Missing symbols means things will stop working.
require("socket").

I've compiled luasocket with luarocks, but getting following error:

error loading module 'socket.core' from file '/usr/local/lib/lua/5.1/socket/core.so':
        /usr/local/lib/lua/5.1/socket/core.so: undefined symbol: lua_gettop

I've trying loading these modules:
lua_State L = luaL_newstate();
if (L == 0)
{
Console.WriteLine("Unable to create context!");
}
luaopen_base(L);
luaL_openlibs(L);
luaopen_jit(L);
but the same error appears.

I've tried to dlopen luajit, but still the same error appears.
IntPtr moduleHandle = dlopen("lua51.so", RTLD_GLOBAL | RTLD_NOW);
Console.WriteLine($"handle: {moduleHandle}");

As per dlopen api, I think its the fact that the file isn't found 'lua51.so' is not a valid path. This would definitely return a null pointer. LuaRocks is a layer that sits somewhere between lua and lua libraries. You may get around this by manually linking your luajit dll with the luasocket library. Let me know how that goes.

I am on archlinux. To be transparent, this is the setup I am using for figuring out how to handle this.
yay -Syu
yay -S dotnet-runtime dotnet-sdk
git clone https://github.com/tilkinsc/Lua.NET
cd Lua.NET
git clone https://luajit.org/git/luajit.git
curl -L -R -O https://www.lua.org/ftp/lua-all.tar.gz > lua-all.tar.gz
tar zxf lua-all.tar.gz

luaso.tar.gz
I was able to drive the library with these .so's. However, I had to dump these next to the binary. For some reason, its looking relative to it (makes sense due to windows), rather than from runtimes/** which I expect to always be on the search path as well. This is local testing, however, and I havent been able to test it due to nuget being a required step in this process. Perhaps I should just release a -dev suffixed nuget package for this purpose.
I'll check out getting luarocks support in after this.

Moving LuaRocks discussion to #21


Return values for commands lacking foreign keys

Hi team, I've noticed a change/regression in the behaviour of "create"/"update" commands in repositories. With the latest stable release of rom-repo and friends, the commands return any foreign keys that are in the row. With the versions from master, those keys are missing.
Example:
begin
  require "bundler/inline"
rescue LoadError => e
  $stderr.puts "Bundler version 1.10 or later is required."
  raise e
end

gemfile(true) do
  source 'https://rubygems.org'
  gem "sqlite3"

  # Switch between these two sets of gems to exercise the two behaviours:

  gem "rom-repository", git: "https://github.com/rom-rb/rom-repository", branch: "master"
  gem "rom-sql", git: "https://github.com/rom-rb/rom-sql", branch: "master"
  gem "rom", git: "https://github.com/rom-rb/rom", branch: "master"

  # gem "rom-repository"
  # gem "rom-sql"
  # gem "rom"
end

require "rom-sql"
require "rom-repository"
require "sqlite3"

module Relations
  class Products < ROM::Relation[:sql]
    schema :products do
      attribute :id, Types::Serial
      attribute :name, Types::Strict::String
    end
  end

  class Posts < ROM::Relation[:sql]
    schema :posts do
      attribute :id, Types::Serial
      attribute :title, Types::Strict::String
      attribute :product_id, Types::ForeignKey(:products)

      associations do
        belongs_to :products
      end
    end

    def by_id(id)
      where(id: id)
    end
  end
end

module Repositories
  class Products < ROM::Repository[:products]
    commands :create
  end
  class Posts < ROM::Repository[:posts]
    commands :create, update: :by_id
  end
end

config = ROM::Configuration.new(:sql, "sqlite::memory")
config.register_relation Relations::Products
config.register_relation Relations::Posts
container = ROM.container(config)

container.gateways[:default].tap do |gateway|
  migration = gateway.migration do
    change do
      create_table :products do
        primary_key :id
        String :name, null: false
      end
      create_table :posts do
        primary_key :id
        String :title, null: false
        foreign_key :product_id, :products
      end
    end
  end
  migration.apply gateway.connection, :up
end

products = Repositories::Products.new(container)
posts = Repositories::Posts.new(container)

product = products.create(name: "Red Mars")
p product
post = posts.create(title: "The Mars Trilogy", product_id: product.id)
p post
post = posts.update(post.id, title: "KSR's Mars Trilogy")
p post

# With released versions of rom, we get this output (note the product_id is included):
#
# #<ROM::Struct[Product] id=1 name="Red Mars">
# #<ROM::Struct[Post] id=1 title="The Mars Trilogy" product_id=1>
# #<ROM::Struct[Post] id=1 title="KSR's Mars Trilogy" product_id=1>

# With github master versions of rom, we get this (product_id missing):
#
# #<ROM::Struct[Product] id=1 name="Red Mars">
# #<ROM::Struct[Post] id=1 title="The Mars Trilogy">
# #<ROM::Struct[Post] id=1 title="KSR's Mars Trilogy">

Was it a conscious decision to exclude these?

Oh, I guess it was, I just saw this line in the CHANGELOG:

Auto-mapping to structs ignores FK attributes consistently (solnic)

What was the thinking there?

@timriley uhm, right, those shouldn't be skipped if it's not an aggregate

@timriley I make it always include FKs no matter what, sensible for now. In the future I would like to skip them in aggregates though, but this needs some thinking

This sounds like a good plan, thanks @solnic.


List "prod" environments at the bottom

Ask
Sort environments when prompting such that environments with Prod=true appear last.
https://github.com/aws/amazon-ecs-cli-v2/blob/5f136e4e44383d8319af4b6b19d6eba966f8ab81/internal/pkg/archer/env.go#L14
Context
When running "app deploy" or any other commands that require an environment as input, by default we list the environments in the order that they were added to SSM.

The problem is that usually production environments are created last, and if a user just blindly keeps pressing the enter-key then they can fat finger a deployment to a production environment.
Instead if the order in the list was:
> test
> prod

this would make it unlikely that a user accidentally deploys to a production environment.

happy to take a shot at it. first timer to this repo any extra pointer could i have?

@sandyleo26 yay, thank you!
Check out the env.go file in the store pkg:
https://github.com/aws/amazon-ecs-cli-v2/blob/5f136e4e44383d8319af4b6b19d6eba966f8ab81/internal/pkg/store/env.go#L79-L96
Right now it just grabs the environments in whichever order they were stored in SSM.
We can sort the slice so that:

non-prod environments appear first
sorted alphabetically within that

See this for an example:
https://github.com/aws/amazon-ecs-cli-v2/blob/5f136e4e44383d8319af4b6b19d6eba966f8ab81/internal/pkg/cli/app_show.go#L169-L170
Once you have your changes ready, you can just run make test to ensure that the new test cases and old ones pass!

thanks @efekarakus for the detailed info. very helpful. PR ready to have a look.


[NTR]Epithelial stem cell of gut

Please check that the term does not already exist by using the ontology search tool OLS:
https://www.ebi.ac.uk/ols4/ontologies/cl
Preferred term label
Epithelial stem cell of gut
Synonyms (add reference(s), please)
Epithelial fate stem cell [PMID:29362471] [PMID:38835047]
Definition (free text, with reference(s), please. PubMed ID format is PMID:XXXXXX)
A type of stem cell located at the base of intestinal crypts. This cell is capable of self-renewal and multipotent differentiation into all intestinal epithelial cell types including enterocytes, goblet cells, enteroendocrine cells, and paneth cells. Expresses markers such as LGR5, ASCL2, SMOC2. Interacts with supportive Paneth cells in the stem cell niche. Rapidly dividing to maintain intestinal epithelial homeostasis[PMID:24326621][PMID:38835047].
Parent cell type term (check the hierarchy here https://www.ebi.ac.uk/ols4/ontologies/cl)
Epithelial stem cell
Anatomical structure where the cell type is found (check Uberon for anatomical structures: https://www.ebi.ac.uk/ols4/ontologies/uberon)
Epithelium
Your ORCID
https://orcid.org/0009-0005-7919-4905
Additional notes or concerns
Cell guide definition to be added as extended:
Epithelial fate stem cells, also known as epithelial stem cells, possess remarkable abilities for self-renewal and the generation of diverse cell types constituting epithelial tissues. The epithelium, derived from these cells, acts as the body's frontline defense against external threats and facilitates the exchange of nutrients, gases, and waste materials within the internal environment.
Epithelial fate stem cells contribute to tissue development, homeostasis, and repair, maintaining the structural and functional stability of epithelial tissues throughout the human body, including the skin, organs, and glands. Through a delicate balance of quiescence, proliferation, and differentiation, these cells ensure the continuous turnover of epithelial cells.
Furthermore, these cells serve a critical role in cellular differentiation, where initially unspecialized stem cells mature into specialized entities that perpetuate the functionality of epithelial tissues. This process is intricately regulated by a network of gene expression patterns and external signaling cues to guarantee a coordinated and balanced cellular turnover. Hence, epithelial fate stem cells, with their unique attributes of self-renewal and differentiation, are central to the physiological and reparative functions performed by epithelial tissues in the human body.

should be part of intestinal epithelium

These are commonly known as IESCs - Intestinal epithelial stem cells.  I would use this name and add the abbreviation.
"Epithelial fate stem cell" is very broad sounding - I don't think useful as synonym.  Looks like it belongs on parent class.
Some suggested tweaks to def.
An epithelial stem cell located in a stem cell niche at the base of intestinal crypts. This cell is capable of self-renewal and multipotent differentiation into all intestinal epithelial cell types including enterocytes, goblet cells, enteroendocrine cells, and paneth cells.  These cells divide rapidly to maintain epithelial homeostatis.  A variety of adjacent cell types secrete signals that support and maintain the identity of this cell type in the niche, including Paneth Cells and specialised fibroblasts.
Expresses markers such as LGR5, ASCL2, SMOC2.  <-- Make clear in what species these apply (Do they cover both mice and humans?
[PMID:24326621][PMID:38835047].
Some more potential refs: PMID:22610555, https://doi.org/10.1038/s12276-024-01179-1

Probably the same cell type as intestinal crypt stem cell http://purl.obolibrary.org/obo/CL_0002250


FInalise the design of eth_getTransactionCount for Contracts

Problem
Nonces for a contract are 1 + n where n is the number of times the contract created other contracts through CREATE or CREATE2. The deployment of the contract itself is considered part of the nonce, that's why the nonce starts from 1.
Currently eth_getTransactionCount for contracts returns hardcoded value of 1.
Solution
Clear out how services will handle nonces for contracts and whether they will do something with nonces. Once the design is defined, a discussion on how to handle them on the relay side must be conducted.
A potential solution for services -> Update the nonce of the contract for every CREATE / CREATE2 opcode executed from it.

Filed a ticket in hedera-services to address this: https://github.com/hashgraph/hedera-services/issues/3640


Forcedly enabled conversion grant expiry changes

Forcedly enabled conversion grant expiry changes

No longer required - so closing off


gnomeExtensions.pop-shell: Keyboard shortcuts aren’t listed in settings

Describe the bug
Pop Shell reportedly defines keyboard shortcuts that can be configured via GNOME’s settings, but they are missing.
Steps To Reproduce

Enable gnomeExtensions.pop-shell and re–log in.
View Settings → Keyboard → View and Customize Shortcuts.

Expected behavior
The available keyboard shortcuts include Move, resize, and swap windows → Move window left outside management mode.
Additional context
I can see the keyboard shortcuts listed in the Pop Shell source but I’m not sure how to make GNOME use them.
Notify maintainers
@genofire
Metadata
$ nix-info --markdown
 - system: `"x86_64-linux"`
 - host os: `Linux 6.1.91, NixOS, 23.11 (Tapir), 23.11.7237.46397778ef1f`
 - multi-user?: `yes`
 - sandbox: `yes`
 - version: `nix-env (Nix) 2.18.1`
 - channels(root): `"nix-math, nixos-23.11, nixos-hardware"`
 - channels(ak): `"community-vscode-extensions, home-manager-23.11.tar.gz, nix-colors, rust-overlay, unstable"`
 - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos`

Add a :+1: reaction to issues you find important.

Working around #92265 and linking keybindings makes it work:
gnomeExtensions = pkgs.gnomeExtensions // {
  pop-shell = pkgs.gnomeExtensions.pop-shell.overrideAttrs (p: {
    postInstall = p.postInstall or "" + ''
      # Workaround for NixOS/nixpkgs#92265
      mkdir --parents "$out/share/gsettings-schemas/$name/glib-2.0"
      ln --symbolic<EMAIL_ADDRESS>"$out/share/gsettings-schemas/$name/glib-2.0/schemas"

      # Workaround for NixOS/nixpkgs#314969
      mkdir --parents "$out/share/gnome-control-center"
      ln --symbolic "$src/keybindings" "$out/share/gnome-control-center/keybindings"
    '';
  });
};

# Workaround for NixOS/nixpkgs#92265
services.xserver.desktopManager.gnome.sessionPath = [ pkgs.gnomeExtensions.pop-shell ];

so should we but it to this extension? @AndrewKvalheim do you like to create a PR?
Or is it a failure in nixos and gnome and this should be solved anywhere else like #92265  (and we could close this issue)

I've tried the above workaround, however, it now crashes for some reason when I try to open the keyboard shortcuts. The jounal log shows that it still does not find the schema right before it crashes.

@AndrewKvalheim do you like to create a PR?

No, I’m not sure how to correctly package this and I personally don’t use Pop Shell. Just sharing what I discovered in case that helps anyone.

I've tried the above workaround, however, it now crashes for some reason when I try to open the keyboard shortcuts. The jounal log shows that it still does not find the schema right before it crashes.

Just wanted to let others know that I'm also facing the same issue. Furthermore, not all the shortcuts are applied either, some are still overridden by the default behavior such as Ctrl+H for hiding a window.
Trying to find a fix, but I have been using NixOS for only a couple of days, so it might take a while 😅

I have the same issue

So what I have now works pretty reliably, but I'm not sure whether this is the most appropriate method of fixing this. Personally, I have a hard time understanding the interactions of gsettings and NixOS, so I've resorted to hard-coding the keybindings with dconf:
# pop-shell-keybindings.nix

{
  "org/gnome/desktop/wm/keybindings" = {
    close = ["<Super>q" "<Alt>F4"];
    minimize = ["<Super>comma"];
    toggle-maximized = ["<Super>m"];
    move-to-monitor-left = [];
    move-to-monitor-right = [];
    move-to-monitor-up = [];
    move-to-monitor-down = [];
    move-to-workspace-down = [];
    move-to-workspace-up = [];
    switch-to-workspace-down = ["<Primary><Super>Down"];
    switch-to-workspace-up = ["<Primary><Super>Up"];
    switch-to-workspace-left = [];
    switch-to-workspace-right = [];
    maximize = [];
    unmaximize = [];
  };

  "org/gnome/shell/keybindings" = {
    open-application-menu = [];
    toggle-message-tray = ["<Super>v"];
    toggle-overview = [];
  };

  "org/gnome/mutter/keybindings" = {
    toggle-tiled-left = [];
    toggle-tiled-right = [];
  };

  "org/gnome/mutter/wayland/keybindings" = {
    restore-shortcuts = [];
  };

  "org/gnome/settings-daemon/plugins/media-keys" = {
    screensaver = ["<Super>Escape"];
    home = ["<Super>f"];
    www = ["<Super>b"];
    terminal = ["<Super>t"];
    email = ["<Super>e"];
    rotate-video-lock-static = [];
  };

  "org/gnome/shell/extensions/pop-shell" = {
    toggle-tiling = ["<Super>y"];
    toggle-floating = ["<Super>g"];
    tile-enter = ["<Super>Return"];
    tile-accept = ["Return"];
    tile-reject = ["Escape"];
    toggle-stacking-global = ["<Super>s"];
    pop-workspace-down = ["<Shift><Super>Down" "<Shift><Super>j"];
    pop-workspace-up = ["<Shift><Super>Up" "<Shift><Super>k"];
    pop-monitor-left = ["<Shift><Super>Left" "<Shift><Super>h"];
    pop-monitor-right = ["<Shift><Super>Right" "<Shift><Super>l"];
    pop-monitor-down = [];
    pop-monitor-up = [];
    focus-left = ["<Super>Left" "<Super>h"];
    focus-down = ["<Super>Down" "<Super>j"];
    focus-up = ["<Super>Up" "<Super>k"];
    focus-right = ["<Super>Right" "<Super>l"];
  };
}

I also have custom keybindings, which is why I put them in a separate file, and then combine them like this:
# gnome.nix

{ config, lib, pkgs, ... }:

let
  popOsKeybindings = import /home/zohar/.dotfiles/pop-os-keybindings.nix;
  # customKeyBindings = import /home/zohar/.dotfiles/custom-keybindings.nix;
in
  {
    dconf.settings =
      popOsKeybindings;
      # // customKeybindings
  }

NOTE: To set keybindings (especially custom keybindings), make sure that there are no conflicting bindings. You can check whether any are set using, for example, gsettings list-recursively | grep "<Super><1>".

I'm not sure how to integrate this into the package, but I thought to put this here first so people can still use it. You have to make sure that you delete any current keybindings you have. Ideally you would have them defined declaratively anyway.
Personally, I don't think this is the 'ideal' way of solving this, as we are now hard-coding their keybindings. If they change, we have to change the package. But declaring the keybindings like this does seem a more 'nix-ian' approach, and it is definitely more readable/hackable. Another thing that's not great is that, at least in my case, I need the --impure flag to be able to find the files.

Personally, I don't think this is the 'ideal' way of solving this, as we are now hard-coding their keybindings.

This seems like a valid workaround, at least until jtojnar or someone else implements a way to load keybindings into gnome-control-center.

I've tried the above workaround, however, it now crashes for some reason when I try to open the keyboard shortcuts. The jounal log shows that it still does not find the schema right before it crashes.

Just wanted to let others know that I'm also facing the same issue

Not sure what to tell you; I just tested the exact same workaround in a ac35b104800bff9028425fec3b6e8a41de2bbfff VM and it did not crash.


rofs-filtered 1.7

rofs-filtered changed the build system to cmake.

Version 1.6 and older fail to install on MacOS 10.12, see https://github.com/gburca/rofs-filtered/issues/18.

And... wow, using CMake is so much cleaner!

@ilovezfs are there any objections to this? Since rofs-filtered switched build systems, the existing formula will not work for new releases. Also, until this is is merged, installation fails on MacOS 10.12

Bump.


Documentation fails to build

Running make html results in

Configuration error:
There is a programable error in your configuration file:

Traceback (most recent call last):
  File "/usr/local/lib/python3.6/site-packages/sphinx/config.py", line 161, in __init__
    execfile_(filename, config)
  File "/usr/local/lib/python3.6/site-packages/sphinx/util/pycompat.py", line 150, in execfile_
    exec_(code, _globals)
  File "conf.py", line 18, in <module>
    import sphinx_rtd_theme
ModuleNotFoundError: No module named 'sphinx_rtd_theme'

make: *** [html] Error 2

You need to pip install sphinx_rtd_theme from pip


Incorrect isStorybook-check ("Storyshots is intended only to be used with storybook")

Issue details
The hasDependency()-check to verify if addon-storyshots is running in a storybook-project is looks up the first package.json's dependency list via read-pkg-up. If the dependency resides in the node_modules on higher level (e.g. in certain monorepos) this check gives a false positive and fails. However, a lookup due to an import '@storybook/react' would succeed in jest/Node.js/Webpack/etc.
Steps to reproduce

Setup repository like this

- package.json (contains @storybook/*-dependencies for all packages)
- packages/
  - package1/
    - package.json (only contains per-package scripts)
    - .storybook/
    - test/
      - storybook.spec.js

Make the storybook.spec.js look like this:

import initStoryshots from "@storybook/addon-storyshots";

initStoryshots();

Run jest on package1

Please specify which version of Storybook and optionally any affected addons that you're running

@storybook/react 3.2.18
@storybook/addon-storyshots 3.2.18

Affected platforms

macOS (Sierra, 10.12.6)
Node.js 6.10.2
npm 3.10.10
Yarn 1.3.2
Jest 22.0.3

There is a framework prop that should help you. We actually use StoryShots in the Storybook monorepo as you describe.

Oh, I apologize for missing that one. Thanks for helping out!

I came across the error storyshots is intended only to be used with storybook which took several hours for me to find the solution (setting framework).
I wish the error message would have been much more helpful and informative.

Jiminy cricket!! I just released https://github.com/storybooks/storybook/releases/tag/v5.1.0-alpha.25 containing PR #6383 that references this issue. Upgrade today to try it out!
Because it's a pre-release you can find it on the @next NPM tag.


sdk artifact broken when publishing to npmjs

The publish CI step publishes an artifact that only includes project meta files (license, readme, package.json), but not the sdk bundle (dist/owncloud.js). This became apparent when we tried to publish a final v3.0.0 yesterday (deleted the release on github, deprecated the release on npmjs).
See https://drone.owncloud.com/owncloud/owncloud-sdk/3965/11/5 for the CI run which published the broken artifact.
See<EMAIL_ADDRESS>for the contents of the broken artifact (note that there is no dist/owncloud.js present).
We already tried to debug this a little bit, but are not that deep into the caching logic that was set up in the sdk repo. Probably makes more sense if someone debugs this who has more clue.
Debugging PR: https://github.com/owncloud/owncloud-sdk/pull/1182 -> revealed, that the dist folder which was supposedly restored from the cache is completely missing on disk when publishing the artifact. Feel free to further use this PR or close and debug in a different way.
cc @kiranparajuli589 @individual-it

@individual-it the urgency on this issue changed. we'll soonish need to bring two enhancements in a new sdk release artifact to the web repo. Could you re-prioritize it please? 😇


This packaged is outdated needs upgrade

This package is outdated. Is no longer valid for Spatie 3,3 can you update the package?

It's it denied by Spatie 3

use this https://novapackages.com/packages/vyuldashev/nova-permission


SWC-62: Project Data Handler

Modified the patch requests for both the projects and users to properly work under any case, updated auth, and the retrival of project history is also possible. API Endpoint creation is yet to be implemented.

I can find the needed changes for the frontend thanks.


does card supported multiple buttons like when we say "ok Google" and show me hospital name. It usually shows hospital name, map,google search button, call button, direction button. if it is possible how to achieve this?

Please see issue #34  for context.  Multiple buttons are not supported.  See the documentation for the platform you're working with for info on how to add multiple buttons with a Payload


BeanParam default values substitution does not work

Parameters placed inside a bean annotated with BeanParam annotation lose their default values provided by defaultValue annotation field. That is why generated documentation lacks default parameter values.
During investigation of the code I found out that BeanParamInjectParamExtention skips default values of parameters declared within BeanParam annotated beans.
Fix for this is available here:
https://github.com/kongchen/swagger-maven-plugin/pull/351
Could you please review and accept this request?

Closing as merge request was accepted.


Violation of Device and Network Abuse policy

When using this library, the app is rejected by google playstore. The Reason is app shouldn't download, monetize, or access YouTube videos in a way that violates the YouTube Terms of Service. So is there any solution for this issue?

Your app is not being rejected because of the library. You are probably violating the terms of services in some other way, for example by showing ads in the wrong way.

Duplicate of #82.


Portal Fantom: pool entity TVL not matching liquidityPoolDailySnapshot TVL

It appears that the TVL on the pool entity is not the same as the liquidityPoolDailySnapshot TVL. See query.

@dhruv-chauhan Did some more digging on this and looks like this transaction is actually a transfer of fake SFI. The FTM token address https://ftmscan.com/token/0x924828a9fb17d47d0eb64b57271d10706699ff11 has a huge supply compared to the real address on ETH https://etherscan.io/token/0xb753428af26e81097e7fd17f40c88aaa3e04902c. Could we blacklist this address 0x924828a9fb17d47d0eb64b57271d10706699ff11

Thanks @dhruv-chauhan looks good so far, will take another looks when it syncs to head!

Looks good


tasks: allow changing run state from fixtures

Some minor fixes to tasks that makes the final run status (and exit code) depend on the values stored in task objects. Which in turn allows affecting them in the new teardown fixtures.

LGTM, so, +1 from me (missing a unit-test for it though...).

Added a small test for mutating the state.
Now that the task status/state is part of the user-facing API, I changed it to a proper string enum, and separated it from the status of the logging. Take a quick look

+1 -- ship it ;)


fix: unlock magic button on dropcard

Description

Deploy Notes
Notes regarding deployment of the contained body of work. These should note any
db migrations, nginx routes, infrastructure changes, and anything that must be done before deployment.

[ ] Need to add environment variables

ENV_VAR=

Screenshots (if appropriate)

Review Error for ximxim @ 2023-08-13 15:35:17 UTC
User failed mfa authentication, see go/mfa-help


error[E0635]: unknown feature proc_macro_span_shrink

error[E0635]: unknown feature `proc_macro_span_shrink`
  --> $HOME/.cargo/registry/src/index.crates.io-6f17d22bba15001f/proc-macro2-1.0.59/src/lib.rs:92:30
   |
92 |     feature(proc_macro_span, proc_macro_span_shrink)
   |

V. 1.0.40, in nightly 0.72.

This appears to be filed in the wrong repo. I can't tell what this has to do with thiserror.


Windows inbox WASDK vs public WASDK features mapping

Hey team,
Windows has a number of feature flags (via velocity) baked into Windows for Windows App SDK. Are these fixes/features also shipping in the WASDK today/soon?
/* Name: Feature ID */
Servicing_WinAppSdkCBFCBCacheLocalizedStringResources: 46607274
Servicing_WinAppSdkCacheActivationFactory: 46468883
Servicing_WinAppSdkCommandBarFlyoutBackdropLeak: 47050253
Servicing_WinAppSdkEnableThemeLookupCacheDuringLayout: 46076120
Servicing_WinAppSdkFlyoutPositioningFix: 46832968
Servicing_WinAppSdkLineUnderTabViewFix: 46770740
Servicing_WinAppSdkMonitorTracker: 47094211
Servicing_WinAppSdkOverlappedPresenterMinMaxRegression: 47351829
Servicing_WinAppSdkPackDCompISharedAllocations: 46144133
Servicing_WinAppSdkPauseRenderingOnWindowFocusRestore: 46833401
Servicing_WinAppSdkProvidePopupHWndToDManip: 46702704
Servicing_WinAppSdkReduceFocusStealing: 47229546
Servicing_WinAppSdkSkipCommandPropertiesDuringThemePropagation: 46010864
Servicing_WinAppSdkSkipInvalidateRectNull: 46157957
Servicing_WinAppSdkSyncCreateContentExternalBackdropLink: 46074461
Servicing_WinAppSdkTabViewScrollButtonsDisableDManip: 46832679
Servicing_WinAppSdkXamlLocalizeDisplayLanguage: 46751006

The mapping is actually the other way around.  These are fixes that are in the public version that are Disabled for Explorer that were not needed there. They were disabled to minimize churn/risk.  These are also only in 1.4, and all of them are uncontained in 1.5.

That's great to hear, thanks!


Entering a date in the past crashes the current DateTime form element

Describe the bug
When we try to enter a date in the past say 1800 and then we access the calendar the Datetime form element crashes as we cannot edit the date anymore
Steps to reproduce

Create a form with datetime picker
In the datetime picker field enter a year in the past in the Form preview
Click on the calendar element and we could see that the calendar for the entered past year is displayed
Now try to make any changes to the calendar or by typing in the field
We could see that the current element has crashed and no changes are effective to it

https://user-images.githubusercontent.com/85225325/211035620-74e0272e-b568-41bc-a9b9-1b2b5fbbf240.mp4
Expected behavior
Entering a date in the past should also be possible
Environment

OS: [Windows 10]
Camunda Modeler Version: [5.7.0 rc-1]
Execution Platform: [Camunda Cloud]

Additional context
No response

We've disabled dates prior to 1900 as a temporary fix. We will however figure out a proper fix for this in the future, and it's tracked here. Nevertheless, this remains fixed upstream and we chose for now not to support dates pre-1900.

Closed via https://github.com/camunda/camunda-modeler/commit/41d2d9bed5c426d2a07dba4064ea668682160d18


Simple install as plugin

Would it be possible to provide the releases of this awesome tool as a kibana-compatible plugin "out of the box"?
Especially for docker deployments it would be awesome to just use
RUN kibana-plugin install https://github.com/dlumbrer/kbn_network....zip

Never mind ...it actually is as simple as this:
Install plugin in Dockerfile:
RUN curl -L https://github.com/dlumbrer/kbn_network/releases/download/6.0.X-1/network_vis.tar.gz | tar xz -C /usr/share/kibana/plugins


Saturn: Network Support

It would be nice to have Network support for Chitu printers that have a network port. Chitu printers listen on port 3000/udp and you can send Gcode M commands through that.  e.g. echo -n M27 | nc -w 1 -u <IP_ADDRESS> 3000
printers on the network can be found with echo -n M99999 | socat - UDP4-DATAGRAM:<IP_ADDRESS>:3000,so-broadcast

That's a good idea! Do you have access to one of those printers that has network?
I would need someone to take on this, since I don't have one myself.
It should be fairly easy to build a quick prototype of this. In order for us to ship it though, we would need some sort of configuration file for mariner, which we don't have yet.

Yes, I have a Saturn. I tried to implement it myself, but didn't get it running on my computer (Ubuntu amd64) I guess a config file would be nice, but looking at the code, making an additional file (mars-network.py) should be enough for the prototype. Switching over to a network config can then be done by adding the network config to this file and renaming it.
Cheers,
Dirk

Also of note is that the Chitusystems website has the module for adding wifi module support to their motherboards, that they sell (although I think it could be bought elsewhere
https://www.chitusystems.com/product/esp-01-wifi-module/
Along with  tutorial on how to add the network printing functionality.
https://www.chitusystems.com/2020/11/03/how-to-activate-the-wifi-module-function-on-your-3d-printer/
I assume this is the same functionality? The sonic mini 4k also has a slot where in theory you could solder an ethernet port.

I found an unused raspberrypi and installed mariner3d on it and can therefore help with development/testing

I think we'll need the configuration file that it's being proposed on #329 here: so we can configure if the printer should be accessed through the serial port or through the network.

Ok, with some socat magic, I have this running now on my Raspberry Pi 2 and Elegoo Saturn. There are some issues, though.
setup:
#create and connect together pseudo serial ports (on a fresh booted system this will be /dev/pts/2 and /dev/pts3
socat -d -d pty,raw,echo=0 pty,raw,echo=0
#forward the other end of the pseudo port to the network printer
socat -d -d -d -d /dev/pts/3 UDP4-DATAGRAM:<IP_ADDRESS>:3000
change the serial port in /opt/venvs/mariner3d/lib/python3.7/site-packages/mariner/mars.py
self._serial_port.port = "/dev/pts/2"
restart mariner3d and you have mariner support without opening the printer.
The problem now is that mariner3d does not know the contents of the usb stick, so starting a print will fail if the contents of the usb stick does not match the contents of /mnt/usb_share
It would be possible to send the file over serial to the printer, but I am guessing this will be really slow. A solution could be to equip the raspberry zero-w with a network port via a ENC28J60 module. In this case it would not be needed to open the printer to get mariner3d working.
Also the Saturn has an internal 4GB disk which will be enabled with a future firmware update, so files could be put there.

is anyone working on this ?  i have a saturn and am thinking about how to get better remote access to manage printing.
is there a way to possibly use a regualr pi and a usb cable to make the pi hold the files and let the printer see the pi as a usb drive maby ?


Promo

Hi @data-charya  please tell me which tool you used for promo video of your app in README

Adobe After Effects

Looks great bro , but you made all of it on your own or used some template .

I had to get it done quick so did it via a template

Could you please provide template link if it is public , please , btw your promo is awesome .


Computed property union lifting

Fixes #13948
Fixes #16789
Fixes #20725
Computed properties of object literals with a union type distribute across the type to create a union type. In the following example,
let ab: 'a' | 'b'
let o = { [ab]: 'hi' }

o has the type { a: string } | { b: string }.
Previously, computed properties caused the object literal type to have a index signature instead. This now happens only if the type of the computed property is not a literal type or union of literal types.
This PR also improves two other aspects of computed properties:

Destructuring: Destructuring with a literal-typed computed property (or union-literal-typed) now correctly uses the type of the index signature for the resulting variable:

declare let one: 1
declare let onetwo: 1 | 2
declare let o: { [n: number]: boolean }
declare let o1: { '1': boolean }
var { [one]: d1 } = o1
var { [one]: d1s } = o
var { [onetwo]: d12 } = o

d1, d1s and d12 have the type boolean now, instead of any.

Printing: Computed properties with literal types or unions of literal types now print the string representation of the literal type instead of the source expression. This avoids duplicates from lifted unions, but makes the type more understandable even for other computed properties:

declare let a: 'x'
declare let ab: 'a' | 'b'
let o1 = { [a]: 'hi' }
let o2 = { [ab]: 'hi' }

Currently the quickinfo for o1 is { ["x"]: string }. Previously it was { [a]: string }. Similarly, the quickinfo for o2 is { ["a"]: string } | { ["b"]: string }. Without improved printing it is { [ab]: string } | { [ab]: string }.

Is this ever going to be implemented?

I may actually be able to integrate fixes for the same issues into #26797. I'll look into it.

It may also be possible to excise a less-ambitious chunk of this PR. It's on my list of bugs to fix for 3.1 or 3.2, but near the bottom. I'll talk with @weswigham to decide on an approach.


Added font-awesome icons to user defined icon

[ ] Bugfix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)

Proposed changes
Added font-awesome icons to a user defined icon feature.
The places of displaying icons are as follows.

Workspace
Subflow node on palette
Node edit dialog & icon tile
Quick-add nodes/wires (ctrl-click)
Search (ctrl-f)
Diff on history tab

Tested on the following environment.

OS

Windows, Linux, mac OS

browser

IE, Firefox, Chrome, Safari

Checklist

[x] I have read the contribution guidelines
[x] For non-bugfix PRs, I have discussed this change on the mailing list/slack team.
[x] I have run grunt to verify the unit tests pass
[ ] I have added suitable unit tests to cover the new/changed functionality

Hi - thanks for this.
Could you explain the difference between createIconElement and createDynamicIconElement? When would you use one and not the other? It would be helpful to have some function-level comments added to the new functions you've added to RED.util - the fact I haven't documented the other functions is a mistake on my part, not a style guide to follow 😉

Thank you for pointing it out.  The difference is whether the icon will be changed later or not.  But I'm feeling like it is better to merge those functions.  Please let me reconsider the part.
I will also add comments. Thanks!

All looks good.
The only piece that makes me slightly nervous is including all of the brand-specific icons from font-awesome - https://fontawesome.com/v4.7.0/icons/#brand
From the FA page:

All brand icons are trademarks of their respective owners.
The use of these trademarks does not indicate endorsement of the trademark holder by Font Awesome, nor vice versa.
Brand icons should only be used to represent the company or product to which they refer.
Please do not use brand logos for any purpose except to represent that particular brand or service.

I know plenty of nodes use a brand's icon in some form, but I feel that is different to the core of node-red bundling them.
I would feel better, I think, if we filtered out these brand icons. What do you think?

Just to clarify - I don't mean to remove them from the version of FA we bundle with Node-RED. I just mean to filter them out of the list we off the end-user to pick from.

Thank you very much for your consideration. (And sorry I didn't care that point.)  I completely agree with your suggestion.  We should remove brand's icons from icon tile.  I will send another commit.  Thanks!


Feature/integration test fixes 0403 release

Coverage remained the same at 75.862% when pulling d96f5136765a50d7b1f70c226ffac47eb4330f99 on feature/integration-test-fixes-0403-release into ccb0a5054e70555ef24af68789e411b32177b982 on develop.

Looks good! 👍  :shipit:

Looks good :shipit:

looks good :shipit:


get_add_url() value in IndexView overriden by client side LinkController

Issue Summary
I'm trying to override get_add_url() method on snippets IndexView to include the URL query parameter of the currently active parent FK filter in the list view, in order to prepopulate the parent field on the add form.
This indeed works on the backend and when looking at the page source, the correct URL is set on the add button, but LinkController strips those query parameters and overwrites the link.
Steps to Reproduce
models.py
import uuid
from django.db import models

# Create your models here.
class Parent(models.Model):
    id = models.UUIDField(primary_key=True, default=uuid.uuid4)
    title = models.CharField(max_length=100)

class Child(models.Model):
    id = models.UUIDField(primary_key=True, default=uuid.uuid4)
    title = models.CharField(max_length=100)
    parent = models.ForeignKey(Parent, on_delete=models.CASCADE)

wagtail_hooks.py
from wagtail.admin.utils import set_query_params
from wagtail.snippets.models import register_snippet
from wagtail.snippets.views.snippets import (
    IndexView,
    SnippetViewSet,
)

from .models import Child, Parent

class PrefilledParentIndexView(IndexView):

    def get_add_url(self):
        add_url = super().get_add_url()
        if self.filters.data.get("parent"):
            add_url = set_query_params(
                add_url, {"parent": self.filters.data["parent"]}
            )
        return add_url

class ParentViewSet(SnippetViewSet):
    model = Parent

class ChildViewSet(SnippetViewSet):
    model = Child
    list_filter = ["parent"]
    index_view_class = PrefilledParentIndexView

register_snippet(ChildViewSet)
register_snippet(ParentViewSet)

You can find the whole project here.
Steps to reproduce:

Set up the project
Go into the admin panel and create a new parent
Go into the child index view and turn on the filter by parent, adding ?parent=<parent_uuid> to the URL.
Click on the "add" button.
I would expect that the URL I'm taken to is /admin/snippets/bug/child/add/?parent=<parent_uuid>, but is /admin/snippets/bug/child/add/ instead.

In general, I would expect whatever I set in get_add_url() to be, in fact, the URL that's set in the UI.

I have confirmed that this issue can be reproduced as described on a fresh Wagtail project: yes

Technical details

Python version: Python 3.10.4
Django version: Version: 5.0.3
Wagtail version: Version: 6.0.1
Browser version: https://www.whatsmybrowser.org/b/HMGAR

Working on this
Unfortunately at this time, I don't have enough time and probably not enough JS skills to work on this.

Hi, this is expected. The reason why we resorted to client-side updates for the add link is because the listing results get refreshed via AJAX as you apply search/filtering, so we need to have a way to reflect the filters query params to the add URL on the client side.
Looking at your configuration, you should be able to fix this by overriding header_buttons on the IndexView class so that the parent key is reflected:
https://github.com/wagtail/wagtail/blob/caf9142c5dac1fbd8555569f2d30c187ba4dd740/wagtail/admin/views/generic/models.py#L328-L340
e.g.
     @cached_property
     def header_buttons(self):
         buttons = []
         if self.add_url:
             buttons.append(
                 HeaderButton(
                     self.add_item_label,
                     url=self.add_url,
                     icon_name="plus",
-                    attrs={"data-w-link-reflect-keys-value": '["locale"]'},
+                    attrs={"data-w-link-reflect-keys-value": '["parent"]'},
                 )
             )
         return buttons

You can verify that when the parent filter value is changed in the filter popup, the add URL will also be updated to reflect the parent URL param.
For completeness sake, if you have URL params in the add_url that you want to preserve regardless of what happens after filtering, you can add "data-w-link-preserve-keys-value" to the attrs. Any keys specified in this list will never be removed/updated on the client side.

Hi @laymonage , thanks for the quick reply and the solution to this!
If this is the intended behavior, it might be good to add a note to the documentation indicating that as it's not really quite clear right away why the link is being overwritten, and what's the relationship between the default add_url and the client side code.

Although now that you mention it, perhaps we should change the default behaviour of the controller to use the keys of the params that are in the URL (at the time the controller is loaded) as the default value for preserve-keys. That way, as long as the server adds the params to the initial link, they will be updated when the listing is refreshed (provided the filter uses the same URL param key). This should make the header_buttons override unnecessary, which makes it easier to upgrade.

That seems like a great solution, I think this is a good default behavior that would be expected from a user.


If there is an expired cookie, redirect the user to /login

Should we keep a second, longer-lived cookie that is also cleared by logout? That way, we can differentiate between a first visit, an expired session, and a logout.

Should we keep a second, longer-lived cookie that is also cleared by logout? That way, we can differentiate between a first visit, an expired session, and a logout.

I think it's simpler than that - cookies should always have max TTL so they never expire.  If we validate a JWT that is expired, then we should redirect to /login so that the token is updated.  The other issue here is that popular frameworks like next-auth prevent this token expiration by constantly re-issuing tokens with an updated expiration every time it's interacted with.  The problem we're having here is that even with constant use, our users are constantly logged out over time.


Training data (aggregate_paraphrase_corpus_0)

Hello Victor.
I would like to thank u first for your contribution.
I am trying to retrain your model but the aggregate_paraphrase_corpus_0 is missing,
Could you share me the files or maybe explain the format of the files ?
Thanks

I need this training data as well.
Could you share me the download link or how to create this format of dataset?

how to get the trainging dataset

@vsuthichai
I would like to have the training data as well, is it possible to share with me privately?

Hi, I know has already passed some time since you were asking these files.
I'm not @vsuthichai but I think I understand how to generate training data.
First thing you need to download the data from internet (just search para-nmt-50m-demo).
Next you need to run the file "preprocess_data.py" passing as parameter the file you downladed called "para-nmt-50m-small.txt".
This will create a bunch of files called "para-nmt-50m-small.txt + ".
Now the last thing you need to do is create the sentence embeddings (I need to find out how to do) and correct all the import strings where all these files are used in the code.
Finally You should be able to train your model. Make sure that the dataset you use is formatted like so "Source sentence" + "\t + "final sentence".
I need now to translate all the dataset to italian and try to train in italian...
Wish me luck

Hi, I know has already passed some time since you were asking these files.
I'm not @vsuthichai but I think I understand how to generate training data.
First thing you need to download the data from internet (just search para-nmt-50m-demo).
Next you need to run the file "preprocess_data.py" passing as parameter the file you downladed called "para-nmt-50m-small.txt".
This will create a bunch of files called "para-nmt-50m-small.txt + ".
Now the last thing you need to do is create the sentence embeddings (I need to find out how to do) and correct all the import strings where all these files are used in the code.
Finally You should be able to train your model. Make sure that the dataset you use is formatted like so "Source sentence" + "\t + "final sentence".
I need now to translate all the dataset to italian and try to train in italian...
Wish me luck

thanks for your comment, have you secceeded? I'm doing the similar thing, translate these to chinese.

Hi, I know has already passed some time since you were asking these files.
I'm not @vsuthichai but I think I understand how to generate training data.
First thing you need to download the data from internet (just search para-nmt-50m-demo).
Next you need to run the file "preprocess_data.py" passing as parameter the file you downladed called "para-nmt-50m-small.txt".
This will create a bunch of files called "para-nmt-50m-small.txt + ".
Now the last thing you need to do is create the sentence embeddings (I need to find out how to do) and correct all the import strings where all these files are used in the code.
Finally You should be able to train your model. Make sure that the dataset you use is formatted like so "Source sentence" + "\t + "final sentence".
I need now to translate all the dataset to italian and try to train in italian...
Wish me luck

thanks for your comment, have you secceeded? I'm doing the similar thing, translate these to chinese.

hi, I didn't really succeeded. I tried to use the training data and translate into Italian. The thing is that the translation weren't good and the training dataset wasn't big enough (maybe because I only used the para-nmt whereas the author of the repository used a bunch of them). I tried to train anyway but I didn't have good results.


Added exact ignored_dirs support

Per discussions in #98 here is my take on an exact ignored_dirs.

This looks great. And thanks for updating the tests and the README!


[1.11] general ci fixes

Testing

Trade-offs

Dependencies

Screenshots

:tada: This PR is included in version 1.25.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Making a plugin full-width

I'd like to make a plugin for Tweakpane that allows you to have an expanded list that you can hover on and select an item from the list. Like the image below.

From my experiments so far, it seems like any input binding produces a side-by-side view with a variable name on the left and an editable field on the right. Is there any way to accomplish something sort of like this?

label: null option hides a label and widen a control area.

const pane = new Pane();
pane.addInput({foo: 1}, 'foo', {min: 0, max: 1});
pane.addInput({foo: 1}, 'foo', {min: 0, max: 1, label: null});

(This option doesn't work properly due to a bug and has been fixed in the latest version 3.1.7)

Awesome! That worked. Thanks! Is there a way to control this from inside the plugin? I couldn't find a way to force the label to null.

There is no way to control it from the plugin. All bindings have a label and users expect to be able to specify the label.

Okay I figured that would be the case as it would create unexpected behavior. Thanks for the help!

FYI: You can create a blade without label not as an input binding, but as a blade without a binding. Built-in separator plugin may be helpful to know its structure:
https://github.com/cocopon/tweakpane/blob/03bbd12592534ec6af96a23cae130083d4f886bd/packages/core/src/blade/separator/plugin.ts

I didn't realize that. Thank you! I'll look into this and go this route instead.


add two references and fix one

Fix one ref to an ITP paper and add two more

I'm confused about why CI succeeded on this PR -- the build on the main branch is failing because of dulicated references. @faenuccio once the site has built and deployed, could you check that all the references you expect are being displayed at https://leanprover-community.github.io/papers.html ?

Sure, I will keep on eye and will report as soon as I see that the site has built.

OK, I have double-checked and there is no duplicate. There was one problem with a curly bracket (fixed in #438 ) but I think that the duplicate warning comes from the fact that there are two submissions with almost the same name (but for capitalization) that are actually two different papers.


Orthographic corrections by Teodora Berova in tutor.bg-utf-8

These are additional fixes to the translation.

I have included the parts that still apply, otherwise the text has already been changed.
If you think some parts are missing, please create a new PR.


Add support for v1.5

hi, thanks for adding support for this! looks like the docs aren't updated, i can make a PR for this fix. the default is now 1.5 right?


[Bug]: Category not found

Summary
I serached for a category that exists, but it doesn't show up.
Steps to reproduce

When uploading an image, search for category: Amavenita

Expected behaviour
Category:Amavenita (ship, 2014) should be suggested.
Actual behaviour
"No Categories found"
Device name
Samsung Galaxy S10
Android version
Android 12
Commons app version
3.1.1~1c9267ca0
Device logs
No response
Screen-shots

Would you like to work on the issue?
No response

@Ainali isn't this the expected behaviour.? Because, Amavenita (ship, 2014) is a non-hidden category and I think we are only supposed to show the hidden category.

Oh, I didn't realize. Then this is a duplicate with #4192 (and a use case for why it is needed, this is how all ships are categorized and the way for a human to identify them).

"we are only supposed to show the hidden category in search bar"

@devarsh-mavani-19 I would consider that a bug. If a category is not hidden, then the upload wizard's category search step is supposed to show it.

By the way, when I search for "rabbits", the first result is https://commons.wikimedia.org/wiki/Category:Rabbits which is not a hidden category:

By the way, when I search for "rabbits", the first result is https://commons.wikimedia.org/wiki/Category:Rabbits which is not a hidden category:

Yes that is how it should work if it is non-hidden, then it should be displayed. However, in case of Ainali it was not displayed because category name contained a year which was older than previous year  (Amavenita (ship, 2014)). so according to this issue #750 it should be filtered out.
so just to summarize currently 2 conditions must met 1. it should be non-hidden and 2nd either should not have any year in name or the year should be current or previous year.

However, in case of Ainali it was not displayed because category name contained a year which was older than previous year (Amavenita (ship, 2014)). so according to this issue #750 it should be filtered out.

Then I would still consider that issue to have been too poorly defined, because the app shouldn't filter out things where the year is part of the identifier of that thing, in this case, the ship that got the name in 2014. (Also, the app should probably not filter out by year, since it's common to upload files a day or two after they are taken which means that if I upload an image on January 1, I expect to see the category for the year before. Safer would be to filter categories where the year is less than current year minus 2.)

I'm presuming the issue #750 was understood properly but the fix for it was a bit loose than it should've been. The relevant code snippet:
return item.matches(".*(19|20)\\d{2}.*".toRegex())
                && !item.contains(yearInString)
                && !item.contains(prevYearInString)
                || item.matches("(.*)needing(.*)".toRegex())
                || item.matches("(.*)taken on(.*)".toRegex())
                || item.matches(".*0s.*".toRegex())
                && !item.matches(".*(200|201)0s.*".toRegex())

That essential returns true (which means the category is filtered out) when the name:

Contains "19xx" OR "20xx" AND
Does not contain current year AND
Does not contain previous year OR
Contains "needing" OR
Contains "take on" OR
Contains 0s AND
Does not contain "2000s" OR "2010s"

If we were to convert the implicit precedence to explicit ones the condition looks like this:
(((1) AND (2) AND (3)) OR (4) OR (5) OR ((6) AND (7)))
Given short-circuiting evaluation, the condition should've returned true for "Amavenita (ship, 2014)" thus the category getting filtered out.
We could fix this by fixing the loose condition. I'll open a PR.

Thanks a lot @devarsh-mavani-19 for finding this out!
I had forgotten about this feature.
Do wee all agree on this?

Photographs taken on 2015-11-08 -> Hide
Amavenita (ship, 2014) -> Do not hide

Thanks a lot @devarsh-mavani-19 for finding this out! I had forgotten about this feature. Do we all agree on this?

Photographs taken on 2015-11-08 -> Hide
Amavenita (ship, 2014) -> Do not hide

yes

@Discostu36 This bug still happens, I just tried on the latest Git code. Do you want to work on it? :-)

Sadly, I lack the skills. I have started learning Kotlin development, but I'm only at the very first baby steps (and don't have much time).

For those interested in picking this up, MR #4902 already has the changes to fix this. Only the tests need fixing IIRC. So, it could be used as a base.
I intend to get around to completing it. Do feel free to beat me to it, though 😉

I want to try ✋

Apart from filtering strings needing & taken on we have these filters

years that ends with XXX0s & are above 2000s are allowed i.e 2000, 2010, 2020.
Otherwise we only allow current or previous year.

Now, this issue needs the second condition to be removed i.e any year should be allowed. But then it also doesn't make sense to have filter for decades (in the first point) right?
Solution:
We can remove both of the filters and allow any year between 19XX & 20XX (inclusive)
OR
Just have one filter to allow any year above >2000s instead of only current or previous year or in decades terms.
WDYT? @nicolas-raoul
Also, api only works correctly under prod because the query (Amavenita) mentioned in the issue was returning empty result in beta , shouldn't be an issue right?


Re-enable PreloadKernArgs on all 94x non-custom kernels

94x CI pass http://math-ci.amd.com/blue/organizations/jenkins/gfx94x%2Fprecheckin%2FhipBLASLt/detail/PR-736/1/pipeline/642


⚠ Processors has degraded performance

In c24fed6, Processors ($STATUS_URL) experienced degraded performance:

HTTP code: 200
Response time: 68 ms

Resolved: Processors performance has improved in 10a3018.


The e2e tests for 1.28 fail consistently

Dashboards:
https://testgrid.k8s.io/sig-scheduling#periodic-jobset-test-e2e-release-0-5-1-28
https://testgrid.k8s.io/sig-scheduling#periodic-jobset-test-e2e-release-0-4-1-28
https://testgrid.k8s.io/sig-scheduling#periodic-jobset-test-e2e-main-1-28
Example history:

Example log:
Creating cluster "kind" ...
 • Ensuring node image (kindest/node:v1.28.3) 🖼  ...
 ✗ Ensuring node image (kindest/node:v1.28.3) 🖼
ERROR: failed to create cluster: failed to pull image "kindest/node:v1.28.3": command "docker pull kindest/node:v1.28.3" failed with error: exit status 1

I suppose this is because there is no 1.28.3 image available for kindest/node on dockerhub.

cc @danielvegamyhre

/assign
Thanks @mimowo

Created https://github.com/kubernetes/test-infra/pull/32677

Fixed in https://github.com/kubernetes/test-infra/pull/32677


Refactor pagination handling

Wwe already got one Page back from the Spring Data Repository. The Page contains all relevant pagination information. Therefore I removed the countXXX methods and did some other refactorings.

 Revision of releases page


Benchmarking against other implementations

Would be useful to be able to compare performance against other implementations.

There's a large djot document with good feature spread here: https://github.com/jgm/djot/issues/227#issuecomment-1612235687 , may be useful for end-to-end benchmarking.

I'm implementing this feature in https://github.com/jgm/djot/pull/326.

I made my own repository which now holds the benchmarks.


Improve doc comments for Marker and friends

This clarifies a bunch of things I have run into during code reading
in preparation for some performance improvements around muting.
It also moves doc comments from places where they don't show up in
godoc to visible places.
It also fixes golint warnings.
Signed-off-by: beorn7<EMAIL_ADDRESS>

No code changes. Just let me know if I deciphered all of this correctly from the code.

Oops, I think you wanted to merge #1764. @mxinden still wanted to comment on this one.
Anyway, there will be another PR in the same area in a few minutes.


Can't disable "check spelling", auto-correction, etc. on Mac

Thanks for this app, I'm trying it out for the first time, using macOS 12.3.
I can't seem to turn off auto-correction (where the little box with suggestions pops up), spell checking (red underlines) and related things.
I expected there to be settings in Preferences for Auto-Correction, like there is in Pages, Numbers, etc., with persistent options like "Correct spelling automatically", "Capitalize words automatically", "Use smart quotes and dashes", "Symbol and text substitution", etc.
I did find options in the menu "Edit > Spelling and Grammar" for "Check Spelling While Typing" and "Correct Spelling Automatically". I expected these to persist. However, if I uncheck these, they only stay unchecked and inactive until I press Enter and start a new line, or click to move the cursor to a different line, then they're checked and active again.
As a workaround, I used:
defaults write io.vincode.Zavala NSAutomaticSpellingCorrectionEnabled -bool false

to disable auto-correction, but I can't find a way to disable the spell checking. Neither of these work:
defaults write io.vincode.Zavala NSAllowContinuousSpellChecking -bool false
defaults write io.vincode.Zavala CheckSpellingWhileTyping -bool false

This is a good request. I'll include it in a future release.


reattach doesn't update the idle timer

If you reattach and don't send any commands, you'll hit the 1-minute idle timeout (and you won't get a PING first).
Not sure how long this bug has existed (I suspect it was in 2.0 though).

git bisect traced this to f3d64d28596d30c7dd346be2720ae3bb5cf35d66 (#895), so it was never in stable.


Investigate (and possible remove) ModelObservers

Model has some infrastructure for a pub/sub system.
Investigate if we use this, and if not ponder if it is useful.
If the answer to both the above is "no", remove it.

"No" and "not really".
Although it could be potentially useful to have infrastructure to alert listeners if rules have changes, the current PSL infrastructure is pretty much a single pipeline.
There is no real current need for us to add/remove rules while running.