Not running as Docker image on Elasticbeanstalk

What I'm trying to achieve
I tried to deploy Saleor as a docker container on AWS Elasticbeanstalk.
What happened instead/how it failed
I am getting error 'Error reading ./webpack-bundle.json. Are you sure webpack has generated the file and the path is correct?'. The issue is related to frontend assets but why is the Docker container not building them? How do I build these as a part of deployment?

I tried adding npm run build-assets / yarn run build-assets but neither of them is working and preventing from the image to build. How do I build the frontend assets?

Hey, Docker images are supposed to contain the bare minimum required to launch an application therefore they don't have Node.js installed. Any operations requiring Node (including building the assets) need to be performed prior to building the container which is only responsible for packaging (and later running) the Python part of the application.

Hi,
Thanks for responding. So I should run npm install and npm run build-assets
first and then deploy  the code to AWS Elastic beanstalk?
On Dec 4, 2017 9:55 PM, "Patryk Zawadzki"<EMAIL_ADDRESS>wrote:

Hey, Docker images are supposed to contain the bare minimum required to
launch an application therefore they don't have Node.js installed. Any
operations requiring Node (including building the assets) need to be
performed prior to building the container which is only responsible for
packaging (and later running) the Python part of the application.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/mirumee/saleor/issues/1402#issuecomment-349015506,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AZUAtaeOD8S8q2kQzlYHD8i6e1Ad9GjXks5s9B0KgaJpZM4QzmVR
.

Yes, you need to run all npm commands prior to docker build. Then Docker will package the files for you (including the webpack-bundle.json file generated by Webpack).

The page you referred to is not found @patrys


:bug: Resolve the sender panic occurring during concurrent calls

Summary
Related issue(s)
Reference: https://github.com/cloudevents/sdk-go/pull/1094
Fixes: https://github.com/cloudevents/sdk-go/issues/1093

LGTM

/approve
/lgtm


double tap to zoom should zoom to the point where the user tapped

https://github.com/flutter/flutter/issues/10048

For now, we can zoom to the current center point

this is implemented now


add new parameter failoverStrictReader

Summary
Implement a new parameter to control failover logic. https://github.com/awslabs/aws-advanced-jdbc-wrapper/issues/223
Additional Reviewers
@karenc-bq
@congoamz
@hsuamz

Should we add a test for this scenario or do you think it isn't needed?


Getting Dephpugger to work with PHPunit from the command line

Hi,
I can't seem to get xdebug_break() to start from the command line. I have reviewed the following documentation
https://dephpugger.com/docs/usage/running_with_phpunit, and it states to add thexdebug_break(); in the code where you want to start troubleshooting. After adding the function to the PHPUnit test and running the command, it won't work. Can you see from the information below why it won't break?
When I have added the function https://github.com/purencool/search/blob/master/tests/SSearchGetSearchResultsTest.php.
  public function testAPartialStringRequest()
  {
    xdebug_break(); # <-- Add this line
    $testObj = new Purencool\TestData\TestData();
    $obj = new Purencool\Search\Search($testObj::defaultArray());

To run the tests from the command line I run the following,
./vendor/bin/dephpugger cli  ./vendor/bin/phpunit

The tests run, but dephpugger never breaks.
Time: 72 ms, Memory: 6.00 MB

There was 1 failure:

1) SSearchGetSearchResultsTest::testAPartialStringRequest
Failed asserting that false is true.

/somepath/search/tests/SSearchGetSearchResultsTest.php:46

FAILURES!
Tests: 28, Assertions: 42, Failures: 1.

This is my version of php and xdebug
$ php -v
PHP 7.3.20 (cli) (built: Jul  9 2020 23:55:30) ( NTS )
Copyright (c) 1997-2018 The PHP Group
Zend Engine v3.3.20, Copyright (c) 1998-2018 Zend Technologies
    with Zend OPcache v7.3.20, Copyright (c) 1999-2018, by Zend Technologies
    with Xdebug v2.9.6, Copyright (c) 2002-2020, by Derick Rethans

$ ./vendor/bin/dephpugger cli -vvv  ./vendor/bin/phpunit
Running file script: ./vendor/bin/phpunit
Command: XDEBUG_CONFIG="idekey=PHPSTORM"<EMAIL_ADDRESS>-dxdebug.remote_enable=1 -dxdebug.remote_mode=req -dxdebug.remote_port=9005 -dxdebug.remote_host=<IP_ADDRESS> ./vendor/bin/phpunit
PHPUnit 7.5.20 by Sebastian Bergmann and contributors.

The debugger works in another terminal. You must open another terminal and run
$ ./vendor/bin/dephpugger debugger

When application find the breakpoint, should stop and start the debug in the debug terminal

I do have it running in another terminal. When I run the tests it say Connected to XDebug server but will never break on xdebug_break();

Nvm found the problem. If I run the test on a separate process, the breakpoint won't work.
    /**
     * @runInSeparateProcess
     * @preserveGlobalState disabled
     */
     ```

I removed those lines and it worked.


Gateway management

please add some cmdlets for managing the on-premises data gateway

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 6a682d40-fb0d-4938-b1ac-cee291c2bbff
Version Independent ID: c7fdffb8-c6b7-f02b-a5e0-6787218978c6
Content: PowerShell support (preview) - PowerApps
Content Source: powerapps-docs/administrator/powerapps-powershell.md
Service: powerapps
GitHub Login: @jamesol-msft
Microsoft Alias: jamesol

@DeanGross
Sorry for the much delayed response. Clearing a backlog, we noticed this hadn't be resolved. Thanks for your feedback. For product-related feedback, visit https://ideas.powerapps.com.


GuardsOnMurderers Problem / Fleeing Issue

Setting GuardsOnMurderers to 0 causes humans to flee from blue chars, it will also have them call guards on them
// Will guards attack Murderers and Criminals (1) or criminals only (0)
GuardsOnMurderers=0

i believe this was completed and working fine. closing


web app doesn't work with SimulatedTemperatureSensor

Hello,
to get this sample to work with IoT Edge SimulatedTemperatureSensor-Module, I had to change the field access as in PR #40
It prepends .ambient to .temperature and .humidity in the callback function.
This was already added with an earlier PR and overridden by a commit from Sept. 04th 2019.
(e1377fe071b8826ae7c8d178cfcc2a3fba26c62c)
In case this is wanted, just reject my PR and close the issue.
Best regards,
Jan

Hi Jan -
Thank you for your contribution. :)
That change would make this sample incompatible with the existing documentation instructions to use a different telemetry source. We don't want to break the existing sample, and we want to maintain the ease with which the sample can be run.
However, I am open to making the code capable of reading from either schema. One trade-off to that approach is that it will make this sample code more complex and harder to read, so we'd want to make sure any changes we make are very clear, documented, and easy to read.
If you are interested in submitting an update to your PR with those goals in mind, I will certainly consider it.
All the best,
David


4n6 scripts

Updates for the 4n6 scripts state.

@digitalsleuth can you update this to just be the 4n6 scripts and make it work with the latest master branch, as Jammy support has now been merged.

Indeed, will get to it this afternoon.

Not sure why the other states got pulled into it.. interesting..

Superseded by #83


Set up fancier SBT build.

 This is so great.

I think the imports need to change

Unfortunately we do need to set up a bit of extra stuff on Travis. I'll try to get to this over lunch.

Looks like this one passed.


🌱 Improve target log collection for e2e

This PR will help the log collection of target cluster during e2e tests. It has the following parts:

It will fetch target cluster kubeconfig and save it to tmp folder with kubeconfig-test1.yaml, which will help the project-infra log collection of target during failure in target cluster and also helps to collect logs of target cluster before re-pivoting in case of successful run.
Fetch target clulster resources during integration test.
Add script to collect target logs before re-pivot.

/test-centos-e2e-integration-main
/test-ubuntu-e2e-integration-main

/test-ubuntu-e2e-feature-main

/test golangci-lint

/cc @mboukhalfa

/test-centos-e2e-integration-main
/test-ubuntu-e2e-integration-main
/test-ubuntu-e2e-feature-main

/test-centos-e2e-integration-main
/test-ubuntu-e2e-integration-main
/test-ubuntu-e2e-feature-main

/test-ubuntu-e2e-integration-main

/test unit

/test golangci-lint

/test-centos-e2e-integration-main
/test-ubuntu-integration-main
/test-ubuntu-e2e-feature-main

/test-centos-e2e-integration-main
/test-ubuntu-integration-main

Link for e2e test with target cluster logs: https://jenkins.nordix.org/job/metal3_capm3_e2e_integration_test_centos/93/

/cc @kashifest
/cc @lentzi90

since we clone dev-env here in e2e tests, do we need to keep a copy of fetch target cluster log file here or can we leverage https://github.com/metal3-io/metal3-dev-env/blob/main/tests/scripts/fetch_target_logs.sh ? Thinking about code maintenance and entropy here.

(I am fine with taking this in directly and improving in follow up PRs also. Quite important to get these logs!)

(I am fine with taking this in directly and improving in follow up PRs also. Quite important to get these logs!)

Agree.
/approve

Alright let's get the logs
/lgtm

since we clone dev-env here in e2e tests, do we need to keep a copy of fetch target cluster log file here or can we leverage https://github.com/metal3-io/metal3-dev-env/blob/main/tests/scripts/fetch_target_logs.sh ? Thinking about code maintenance and entropy here.

We can check the scope in future as the main goal is to get these logs in e2e. I will open a ticket and mention this scope and improvements.

/cherry-pick release-1.2
/cherry-pick release-1.3
Adding the log collection script to release-1.2 and release 1.3

/cherry-pick release-1.3


PickList triangle icon overlaps text

I don't know if it has to do with the font, which is NerdFont (Agave). In the case of two words, it seems like it's too late to break into two lines:

You can just increase the width of the picklist

Yes but it seems like a bug to me because there is a mechanism in place to break into multiple lines if it overflows, but it kicks in too "late" (in terms of width).

Besides, if I want to use Length::Shrink it will consistently overlap


SPIKE: Determine manual process to be used for supporting wire payments

Overview
There's going to be a requirement to offer customer service to those who need to pay using wire. What should an admin setup support?
Additional context
Add a separate story for the implementation once this is complete.
Possible situations to handle:

Someone pays for the item but the wrong amount was sent
Someone pays for the item but the bank denied it
Someone wants to check at the status
Revoking a claim to the pack
Awarding the pack to another bidder
Email notifications throughout process

Wire payments flow

User creates bank account using checkout form and instructions are presented + emailed to them.

Expiration date is added to the payment

Payment is initiated by the user

Scheduled task finds a matching pack payment

If a resolved status: Emails the application owner to let them know the status of the matching payment (i.e., paid, failed).

Scheduled task finds expired wire payments that are not in a resolved status (i.e., pending)

Checks for any matching payments. If resolved: Email the app owner with the status of the payment.

Application owner logs into admin interface
Application owner has a list of (expired?) payments

View email (and phone?) for user

Email/phone user in case something went wrong
Should this be an action they can take? Or just provide contact info for manual contact?

Option to:

Review Circle API payments associated with the payment source ID. Actions include:

Revoke claim for associated pack
Awarding the pack to the user
Update expiration date for payment

Admin options
Resolving wire payments

Search through all wire payments in Circle's API (don't limit time; we use 24 hours in past for task)
Find any matching wire payments in Circle's API; could require paging through.
Show all wire payments associated with the bank account ID + statuses.

No matching: Allow option to revoke claim to the pack or to update the expiration date for payment
Matching: Allow option to select the found payment as the payment for the pack

Removes expiration and updates the status of the payment and the external ID.
Alternatively, if the payment is found but still pending, they could update the expiration date.

Expired payments

List all payments past the expiration date

If they have an external ID: they are linked to a payment in Circle's API.

Check the status
Option to extend expiration date if pending
Option to find new payments if there's a failed payment linked.

For instance, if someone had successfully sent the funds but it took multiple tries.
See Resolving wire payments above

If there's no external ID:

See Resolving wire payments above

All payments

List all payments

Payments with a bank account ID is wire.
Payments with no bank account ID is card (may not have card association even if a card so cannot base off the payment card ID).
Sorted by date of creation (or update)
Display status in table

The list could include all unresolved statuses, or every payment that's been made.

If a payment is selected (could be accordion table or individual pages), display more information + actions

Show associated pack details
Show associated user details
For wires: Option to search Circle API for any matching payments (i.e., see Resolving wire payments above)
For cards: Option to revoke/send email about failed payment and possibly revoking

If something went wrong down the line and the payment goes from confirmed to failed, we could auto-revoke the packs, or we could display here and allows the application owner to revoke or send an email to try payment again.

All packs

List all packs

Need ability to search by username and/or by the title/slug
Show if the pack is owned by someone

Click on pack to see more details

For each edition of the pack:

Retrieve associated payment with the pack
List payment details (i.e., status, if associated with an external ID, if wire/card)
Options to revoke/send email/update expiration.
Option to check Circle's API more thoroughly (see Resolving wire payments above) and associating a payment and awarding the pack

Listing all payments is more conducive to troubleshooting wires, but adding different options in case another route solved another use-case.

Closing in place of #152

User stories for wire "unhappy" paths
As a customer attempting to purchase a pack using wire transfers, I want to be able to change my bank account if purchasing using my other bank account fails

User is notified a wire payment was found with a failed status
Customer support is notified of the failed payment status
Customer support reaches out to user

Customer support finds the payment in the table

Search by user details (i.e., username) OR associated pack details (i.e., ID, slug, title)

User wants to provide new bank account

Completely manual process?
User provides bank account information to customer support
Action: Update bank account

As a customer attempting to purchase a pack using wire transfers, I want to initiate a wire transfer after an unsuccessful wire transfer

User is notified a wire payment was found with a failed status
Customer support is notified of the failed payment
Customer support reaches out to user

Customer support finds the payment in the table

Search by user details (i.e., username) OR associated pack details (i.e., ID, slug, title)

User may want to try again

Customer support needs to reach out in the future to check status

Should we track anything? Set an expiration?
Likely manual process for now, where customer success periodically checks

Customer support finds the payment in the table
Customer support searches through matching payments

Action: Search for all matching Circle payments
IF payment is found:
Customer support finds a valid payment and updates the associated payment ID

Action: Update associated payment

IF payment not found or unsuccessful again:

Customer support does not find a valid payment and revokes the claim to the pack

Action: Revoke claim for pack

As a customer attempting to purchase a pack using wire transfers, I want to initiate a wire transfer in the remaining amount after a successful wire transfer in the wrong amount

User is notified a wire payment was found for the incorrect amount
Customer support is notified of the incorrect amount payment
Customer support reaches out to user

Customer support finds the payment in the table

Search by user details (i.e., username) OR associated pack details (i.e., ID, slug, title)
Should we add a new status for payments for an incorrect amount?

User may want to refund the amount => manual process
User may want to send the remaining amount

Customer support needs to reach out in the future to check status

Should we monitor the time? Set an expiration? Likely manually initially.

Customer support finds the payment in the table
Customer support searches through matching payments

Action: Search for all matching Circle payments

IF payment is found:

Customer support finds a valid payment

Nothing needs to happen re: ownership since the pack owner is set, unless that changes to be claimed by, etc.
Update the status of the payment

Possibly add additional status for invalid amount, or mark as Failed at that point, and change to Paid

IF payment not found or unsuccessful again:

Customer support does not find a valid payment and revokes the claim to the pack

Action: Revoke claim for pack

Actions
Search for all matching Circle payments

Search Circle's API for all payments with a source ID matching the bank account ID associated with the payment
List of payments in table format

Revoke claim

Call endpoint to revoke the claim on the pack

Updates pack claimed by details

Notify user they no longer own the pack

Update associated payment

Select a valid payment from the list of Circle payments
Click a button to associate with the pack

Updates the external ID for the payment + status

Update bank account

Update existing payment to remove pack association
Create new bank account in Circle
Create new wire payment in database, associated with this now unclaimed pack + user

Development

Endpoints

List all payments

Support for: pagination, sorting, filters
For all user stories

Search for all matching payments in Circle

Retrieves all payments in Circle matching the source ID, regardless of the price and status
Required to provide customer support the information they need in any situation.

Revoke claim

Revoke a user’s claim to a pack
Notify the user

Update payment

Update the external ID and status for a payment

Update bank account

May not be a requirement, if changing bank accounts for the wire was a manual process
Remove pack association with existing payment, and add a new bank account and wire payment to associate with the pack.
For the As a customer attempting to purchase a pack using wire transfers, I want to be able to change my bank account if purchasing using my other bank account fails user story

Tasks

Update payment statuses

For all payment types, send a notification to the user AND customer support when a resolved status is found (i.e., Failed or Paid).

Update bank account statuses

If the wrong amount is provided, update the status to Failed.
Should there be a different status for a wrong amount?

Updates

New status for payments with wrong amount?

Questions

Should we track expiration for the payment?
How should someone find a payment in the table?


Removed deprecated API endpoint

/api/subreddits_by_topic was silently removed around a year ago. Removing function and related test for it.

https://www.reddit.com/dev/api
https://www.reddit.com/r/redditdev/comments/8gmf9v/api_receiving_404_when_hitting_get_subreddits_by/

Removing the test sounds fine to me, but can we keep the method in the source code and add a warning to its documentation? Someone might be using it on their own instance of reddit from when reddit was open-source (although admittedly I'm not sure how many people are actually doing that).

Though would they not use an older version off the API? Reddit's API is probably very different than the open sourced Reddit, since they no longer use/maintain it

They would be using the latest version of snoowrap with a potentially outdated version of reddit's API. It would be a breaking change for snoowrap to stop supporting that outdated version of reddit's API.

I'll change it to be a deprecated function instead. Though not sure about supporting old Reddit source code with the newest revision. That API hasn't changed since at least the last commit of the repository, so it would make more sense to use an older version of Snoowrap that don't have changes to the wrapper that coincide with the new Reddit.
Not sure if there are any such API changes that behave differently for the same endpoints between the FOSS Reddit code base and what Reddit is hosting, but it wouldn't surprise me given it's been several years

@not-an-aardvark How does that look?


add support for syntax highlighting for Copy and Paste commands

Is your feature request related to a problem? Please describe.
The current tree-sitter doesn't have support for Copy and Paste
Describe the solution you'd like
Add support for these commands
Describe alternatives you've considered
This feature can be added simply and doesn't need any alternative.
Additional context
I will work on adding support for this.

This is now added! Thanks so much for the issue!


Use C_TooltipInfo APIs for companion owner names

A future build of 10.0.2 will add a new UnitOwner tooltip line type that provides the GUID of the owning unit as part of its payload. We can use this to extract owner names and realm, thus removing the need to de-format localization strings and deal with locale-specific quirks like declensions.

This is implemented in the latest beta build and works fine.


Docs update locaddr

The assembly docs say at the end of the io section
The push.env.locaddr is provided specifically to map an index of a procedure's local to an absolute address

but this instruction does not exist now. The correct instruction is locaddr.i which says
a←address_of(i)
Pushes the absolute memory address of local memory at index i onto the stack.

Closed by #615.


[Resource Pack] Dark Amethyst

Dark Amethyst :black_heart: :purple_heart:
A theme for OSRS/runelite by R-Y-M-R.
Credit to Levy for Spacenation edition :blue_heart: and iawhd for the original :black_heart: version. :purple_heart: :purple_heart: :purple_heart:
Download the source.zip and read how to use a custom pack (not from the hub).
Give your Runelite client an Amethyst vibe.

Check the wiki to get your pack to be available to upload:
https://github.com/melkypie/resource-packs/wiki/Submitting-a-Resource-pack-to-the-Hub-using-GitHub-Desktop
Basically resubmit the pull request but choose pack-dark-amethyst as the base instead of master. For some reason when I changed the base into your desired branch name it closed your pull request.

Follow the guide what @nickyGyul posted. The reason your previous pull request did not work is due to you branching off of master. If you follow the guide precisely, you should not have any issues submitting your pack. Closing this issue, if you need anymore support do it on discord as I would like to keep Github Issues for pack requests and bugs/enhancements.


Summer/winter hour change messes with datepicker

Hi:
I have an issue with the datepicker:
Here in my country we change the hour for summer/winter at 0:00. One day we set one more hour (say, 04-10-2014 00:00:00 becomes 04-10-2014 01:00:00), and another day is set one less (03-09-2014 00:00:00 becomes 03-08-2014 23:00:00). This has become a troublesome issue in javascript, and as suspected, in this example, when I choose "03-09-2014" it picks "03-08-2014" because as local time suggests, it becomes one hour less.
Is there a way to fixing it? I usually, when I don't need the hour, I set it to an arbitrary hour which it won't mess with the dates, for example 12 PM. So, when the hour is substracted, it just becomes 11 AM but preserving the date. Is there an easy way to change this?
Thanks

I've just had this bug manifest itself through beforeShowDay.
...
if (this.o.beforeShowDay !== $.noop){
    var before = this.o.beforeShowDay(this._utc_to_local(prevMonth));
...

Example calling code:
beforeShowDay: function(today) {
var dateString = today.toISOString().slice(0,10);
return  (dateString == '2015-03-30');
}
This code would always mark the 31st March as available, rather than 30th March. My ignorant fix was to make sure that "prevMonth" wasn't sitting on a midnight threshold:
var _DSTbugfix = new Date(prevMonth);
_DSTbugfix.setHours(11); // nowhere near midnight so DST can't change the date
var before = this.o.beforeShowDay(this._utc_to_local(_DSTbugfix));

I hope this helps someone.

I just ran into this bug.

I think my issue is related to the same bug. When I disable a day in month the next one gets disabled as a result... So when I disable 2016-03-15, 2016-03-16 gets disabled.
iyarych@cat:~$ cat /etc/timezone
Europe/Kiev
iyarych@cat:~$ LC_ALL=C date
Fri Mar 18 09:52:47 EET 2016

Is there any solution for this?

For me this change makes my bug go away:
diff --git a/public/js/bootstrap-datepicker.js b/public/js/bootstrap-datepicker.js
index 11fedaf..d8c1cdb 100644
--- a/public/js/bootstrap-datepicker.js
+++ b/public/js/bootstrap-datepicker.js
@@ -951,7 +951,7 @@
 				clsName.push('day');

 				if (this.o.beforeShowDay !== $.noop){
-					var before = this.o.beforeShowDay(this._utc_to_local(prevMonth));
+					var before = this.o.beforeShowDay(prevMonth);
 					if (before === undefined)
 						before = {};
 					else if (typeof(before) === 'boolean')

Do you think that's the proper fix? I don't have much time to find out how things work in datepicker code...


Favicon briefly changes to my specified one, but then changes back once page loads

Describe the bug
Chrome tab modifier has been AWESOME, thank you! I recently updated to Brave Version 1.67.123 Chromium: 126.0.6478.126 (Official Build) (arm64), and I'm suddenly back to the Favicon for the site, rather than the one I want. I see the Favicon I specified in the rules briefly, but the tab reverts to the site's Favicon once the page is fully loaded.
To Reproduce
Steps to reproduce the behavior:

Using the latest version of Brave browser, go to a website that matches a Chrome tab modifier rule.
Watch how the tab briefly shows the correctly specified Favicon, then reverts to the site's Favicon.

Expected behavior
Prior to updating Brave this morning, the tab correctly showed my specified Favicon.
Screenshots
Here's a link to a video of this problem in action. Note that the Favicon briefly includes "TW," as I've configured, but then quickly reverts to the default Favicon once the page is loaded. This was working prior to updating Brave this morning, and I've made no other config changes.
Extension version: 1.0.6
Can be found here: chrome://extensions/?id=hcbgadmbdkiilgpifjgcakjehmafcjai

Hi @gerrymiller,

Do you have the same behavior on other sites?
Do you confirm the same website works on Chrome so the issue is only targeted on Brave?

Bests

Thank you, @sylouuu. I am not seeing this behavior on other sites (e.g., https://oxygen.cloudticity.com), so it may be isolated just to https://teamwork.cloudticity.com.
The issue with https://teamwork.cloudticity.com shows on the latest versions of both Brave and Chrome.
Warm regards,

Gerry

Hi @gerrymiller,
Do you still have the bug with version 1.0.7, please?
Regards,

It's working with v1.0.7! Thank you.

That's great to hear! Thank you for letting us know.


Expression.ToString() is incorrect.

Describe the bug
Expression.ToString() is used by JsonConverter to turn an Expression back into a string.  It has a bug that it doesn't create proper strings.  For example:
json(`{'foo': '${hello}','item': '${world}'}`).foo,hello,)
generates incorrect escaping of quotes
(replace("hello'", "'", '"'),hello",)
generates incorrect escaping of quotes,
etc.
To Reproduce
This unit test fails in 14 places:
        [DataTestMethod]
        [DynamicData(nameof(Data))]
        public void Roundtrip(string input, object expected, HashSet<string> expectedRefs)
        {
            var parsed = Expression.Parse(input);
            var newExpression = Expression.Parse(parsed.ToString());

            Assert.AreEqual(parsed.ToString(), newExpression.ToString(), $"{input} should have round tripped as string");
        }

Expected behavior
Expression x = "....";
Expression y = x.ToString(); // create new expression from previous expression
// string forms are the same for 2 expressions.
x.ToString() == y.ToString();
[bug]

Offline talked with Tom, We don't have to to exactly same string,  but we need to make sure at least the toString() result is re-parseable and generate same parseTree


quick_start.py

Found it confusing to change the config file so asked o1-preview to get me: quick_start.py a simple script that can be run with text to generate as argument.
Here is quick_start.py
# quick_start.py

import sys
import os
import hashlib
import torch
import torchaudio
from einops import rearrange
from vocos import Vocos

from model import CFM, UNetT, DiT
from model.utils import get_tokenizer, convert_char_to_pinyin

# Set the device
device = "cuda" if torch.cuda.is_available() else "cpu"

# Default text
default_text = "this is the default text, please provide something interesting via arguments for me to generate"

# Get the text from command-line arguments or use the default text
if len(sys.argv) > 1:
    text_input = ' '.join(sys.argv[1:])
else:
    text_input = default_text

# Generate a unique filename based on the text
hash_object = hashlib.md5(text_input.encode())
filename = f"/tmp/f5-{hash_object.hexdigest()[:4]}.wav"

# --------------------- Model Settings -------------------- #

# Inference settings
seed = None  # int | None

exp_name = "F5TTS_Base"  # F5TTS_Base | E2TTS_Base
ckpt_step = 1200000

nfe_step = 32  # 16, 32
cfg_strength = 2.0
ode_method = 'euler'  # euler | midpoint
sway_sampling_coef = -1.0
speed = 1.0

if exp_name == "F5TTS_Base":
    model_cls = DiT
    model_cfg = dict(dim=1024, depth=22, heads=16, ff_mult=2, text_dim=512, conv_layers=4)
elif exp_name == "E2TTS_Base":
    model_cls = UNetT
    model_cfg = dict(dim=1024, depth=24, heads=16, ff_mult=4)

# Dataset Settings
target_sample_rate = 24000
n_mel_channels = 100
hop_length = 256
target_rms = 0.1

tokenizer = "pinyin"
dataset_name = "Emilia_ZH_EN"

use_ema = True

# Load the checkpoint
checkpoint_path = f"ckpts/{exp_name}/model_{ckpt_step}.pt"
if not os.path.exists(checkpoint_path):
    raise FileNotFoundError(f"Checkpoint not found at {checkpoint_path}. Please download the checkpoint.")

checkpoint = torch.load(checkpoint_path, map_location=device)

# Vocoder model
vocos = Vocos.from_pretrained("charactr/vocos-mel-24khz")

# Tokenizer
vocab_char_map, vocab_size = get_tokenizer(dataset_name, tokenizer)

# Model
model = CFM(
    transformer=model_cls(
        **model_cfg,
        text_num_embeds=vocab_size,
        mel_dim=n_mel_channels
    ),
    mel_spec_kwargs=dict(
        target_sample_rate=target_sample_rate,
        n_mel_channels=n_mel_channels,
        hop_length=hop_length,
    ),
    odeint_kwargs=dict(
        method=ode_method,
    ),
    vocab_char_map=vocab_char_map,
).to(device)

if use_ema:
    from ema_pytorch import EMA
    ema_model = EMA(model, include_online_model=False).to(device)
    ema_model.load_state_dict(checkpoint['ema_model_state_dict'])
    ema_model.copy_params_from_ema_to_model()
else:
    model.load_state_dict(checkpoint['model_state_dict'])

model.eval()

# Text processing
text_list = [text_input]
if tokenizer == "pinyin":
    final_text_list = convert_char_to_pinyin(text_list)
else:
    final_text_list = [text_list]
print(f"Text input: {text_list}")
print(f"Pinyin: {final_text_list}")

# Duration estimation based on text length
# Estimate duration (in mel frames) based on text length
words_per_second = 2.5  # Average speaking rate
estimated_duration_seconds = len(text_input.split()) / words_per_second
duration = int((estimated_duration_seconds * target_sample_rate) // hop_length) + 1

# Create a zero-filled conditioning tensor
cond = torch.zeros(1, duration * hop_length).to(device)

# Inference
with torch.no_grad():
    generated, _ = model.sample(
        cond=cond,
        text=final_text_list,
        duration=duration,
        steps=nfe_step,
        cfg_strength=cfg_strength,
        sway_sampling_coef=sway_sampling_coef,
        seed=seed,
    )

# Post-processing
generated_mel_spec = rearrange(generated, '1 n d -> 1 d n')
generated_wave = vocos.decode(generated_mel_spec.cpu())

# Adjust RMS if necessary
rms = torch.sqrt(torch.mean(torch.square(generated_wave)))
if rms < target_rms:
    generated_wave = generated_wave * target_rms / rms

# Save the audio file
torchaudio.save(filename, generated_wave, target_sample_rate)
print(f"Generated audio saved to {filename}")

Sadly this is what it generated: generated audio (converted to webm)

what does this script intend to do?
I also get gibberish when trying

maybe just parser.add_argument
your quick_start.py seems to not correctly deal with ref_audio, btw null output may for invalid input text

what does this script intend to do?
I also get gibberish when trying

I was trying to get a quick_start script that will do the following:
python quick_start.py # running this will print how to use it
python quick_start.py 'this text will be generated' # running this will generate the audio and save it to `/tmp/f5-<ID>.wav` and print the path


"Host Tests for ios_debug_sim" failing on bots but passing locally

Example PR's failed run: https://ci.chromium.org/p/flutter/builders/try/Mac iOS Engine/7106?
These unit tests were fixed in https://github.com/flutter/engine/commit/0cda2931e502809dcc8dcb335816b4259fbe04ba and the tree eventually turned green after that PR landed.  But that bot started turning red again for the some reason, see  https://ci.chromium.org/p/flutter/builders/prod/Mac iOS Engine/6386.
It's almost like the tests are running with an old version of ios_test_flutter but run_tests.py is ensuring that that is getting built before the tests are run.
https://github.com/flutter/flutter/issues/63802 is probably related.
cc @dnfield @godofredoc

Do we need to clobber the builder caches?

If you look at the failure before the fixing PR: https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket.appspot.com/8871971729595584672/+/steps/Host_Tests_for_ios_debug_sim/0/stdout
/b/s/w/ir/cache/builder/src/out/ios_debug_sim/../../third_party/ocmock/Source/OCMock/OCMockObject.m:419: error: -[AccessibilityBridgeTest testAnnouncesLayoutChangeWithLastFocused] : failed: caught "NSInvalidArgumentException", "-[OCMockObject(FlutterView) view]: unrecognized selector sent to instance 0x600001dff340"

and after the fixing pr: https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket.appspot.com/8871969852673199920/+/steps/Host_Tests_for_ios_debug_sim/0/stdout
2020-08-14 11:04:17.082120-0700 IosUnitTests[27591:420192] ERROR: UIAccessibilityElement initialized with nil container:

The errors are different.  This seem to not be an infra problem, but some flake that isn't showing up locally.  This may have been flakey for a while but the tests were passing on red.

we are clobbering by default in all the engine builds

The root problem got fixed in https://github.com/flutter/engine/commit/f60e8369681e7c75e7cb93b7ae03bac0e92dce5e.  It appears to be a problem with running the tests on different platforms since how the UIAccessibilityElement class behaves triggered the error or not.  That's why they worked locally and not remotely.  I don't think there is much we can do there.


Destructuring for assignments, parameters and declarations

We need support for destructuring assignments, e.g.
const [ x, y ] = [ 1, 2 ];

Destructing shouldn't need any new tokens. It will, however, require grammar changes to allow variable declarators to store data other than identifiers.

Ping ?


Cant deploy sonarqube.

It seems the sonarqube deployment and the postgresql dc are using the same Claim volume name.... and also that there isnt a PVC for postgresql...

We need a CI: https://github.com/rht-labs/helm-charts/issues/61

Sonarqube seems fine now :) for CI, we have https://github.com/redhat-cop/helm-charts/issues/15 and things in my mind hoping to discuss with you soon 😇


Adding connection pooling for cbt/cdf.

Pub/Sub connectors can create a bundle every few milliseconds.  The existing solution creates a new connection, which takes a few seconds.  The pooling will allow the bundles to be handled in a better fashion.

All comments were addressed.  PTAL.

I addressed all of the comments.  I also added a shutdown executor service that will close the connections asynchronously.  PTAL

LGTM


⚠ ClamAV has degraded performance

In 975f8a1, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 77 ms

Resolved: ClamAV performance has improved in d2453be.


Add extension point for refresh behavior on iOS

This patch adds an extension point for controlling the refresh browser behaviour when returning from the BankID app.
The problem we are trying to solve is that when starting the flow from a native iOS app using an embedded view like
ASWebAuthenticationSession, we do not want to refresh the browser. With the new IReloadPageOnReturnFromBankIdApp interface, we can simply disable the refresh.
This PR fixes #423.

Thanks, great with contributions form the community!
We are a bit short on time to review this in detail near time, but we have not forgotten it!


lost data

if i have a database with  existing data in table X , then i change model for table X adding property i lost all rows previously created!!! there is a way to avoid this!!!!

Hello
You have the option to choose between the following three initializers:

SqliteCreateDatabaseIfNotExists
SqliteDropCreateDatabaseAlways
SqliteDropCreateDatabaseWhenModelChanges

I assume you use SqliteDropCreateDatabaseWhenModelChanges which drops the database if the model changes. I suggest to use SqliteCreateDatabaseIfNotExists. This will only create the DB if it does not exist.
Take into account that you have to apply the migrations to the DB before using the new model.
EF migrations are not supported (https://github.com/msallin/SQLiteCodeFirst/issues/4).
Greetings

Ok thanks!!!!


HDDS-10293. IllegalArgumentException: containerSize Negative

What changes were proposed in this pull request?
Encounterd an error in recon log IllegalArgumentExpection: containerSize Negative" :-
2024-02-01 19:50:21,727 ERROR [ContainerSizeCountTask]-org.apache.hadoop.ozone.recon.tasks.ContainerSizeCountTask: FIXME: Failed to process ContainerInfo{id=#3979, state=DELETED, stateEnterTime=2024-02-01T02:45:43.506025Z, pipelineID=PipelineID=0ea98cdd-adf9-4ffa-b7f8-15a3052b155a, owner=om1546336125}
java.lang.IllegalArgumentException: containerSize = -63 < 0
    at com.google.common.base.Preconditions.checkArgument(Preconditions.java:204)
    at org.apache.hadoop.ozone.recon.ReconUtils.getContainerSizeBinIndex(ReconUtils.java:329)
    at org.apache.hadoop.ozone.recon.ReconUtils.getContainerSizeUpperBound(ReconUtils.java:309)
    at org.apache.hadoop.ozone.recon.tasks.ContainerSizeCountTask.getContainerSizeCountKey(ContainerSizeCountTask.java:333)
    at org.apache.hadoop.ozone.recon.tasks.ContainerSizeCountTask.updateContainerSizeCount(ContainerSizeCountTask.java:313)
    at org.apache.hadoop.ozone.recon.tasks.ContainerSizeCountTask.decrementContainerSizeCount(ContainerSizeCountTask.java:308)
    at org.apache.hadoop.ozone.recon.tasks.ContainerSizeCountTask.process(ContainerSizeCountTask.java:127)
    at org.apache.hadoop.ozone.recon.tasks.ContainerSizeCountTask.process(ContainerSizeCountTask.java:168)
    at org.apache.hadoop.ozone.recon.tasks.ContainerSizeCountTask.run(ContainerSizeCountTask.java:106)
    at java.base/java.lang.Thread.run(Thread.java:834)
2024-02-01 19:50:21,728 ERROR [ContainerSizeCountTask]-org.apache.hadoop.ozone.recon.tasks.ContainerSizeCountTask: FIXME: Failed to process ContainerInfo{id=#3985, state=DELETED, stateEnterTime=2024-02-01T02:45:43.509864Z, pipelineID=PipelineID=4c92a12e-7c4d-457a-ab61-0bddd1a23711, owner=om1546336125}
java.lang.IllegalArgumentException: containerSize = -63 < 0
    at com.google.common.base.Preconditions.checkArgument(Preconditions.java:204)
    at org.apache.hadoop.ozone.recon.ReconUtils.getContainerSizeBinIndex(ReconUtils.java:329)
    at org.apache.hadoop.ozone.recon.ReconUtils.getContainerSizeUpperBound(ReconUtils.java:309)
    at org.apache.hadoop.ozone.recon.tasks.ContainerSizeCountTask.getContainerSizeCountKey(ContainerSizeCountTask.java:333)
    at org.apache.hadoop.ozone.recon.tasks.ContainerSizeCountTask.updateContainerSizeCount(ContainerSizeCountTask.java:313)
    at org.apache.hadoop.ozone.recon.tasks.ContainerSizeCountTask.decrementContainerSizeCount(ContainerSizeCountTask.java:308)
    at org.apache.hadoop.ozone.recon.tasks.ContainerSizeCountTask.process(ContainerSizeCountTask.java:127)
    at org.apache.hadoop.ozone.recon.tasks.ContainerSizeCountTask.process(ContainerSizeCountTask.java:168)
    at org.apache.hadoop.ozone.recon.tasks.ContainerSizeCountTask.run(ContainerSizeCountTask.java:106)
    at java.base/java.lang.Thread.run(Thread.java:834)

The changes proposed in the PR :-

Skip the containers having negative size for some reasaon.
Skip the containers which has gone into the DELETED state.

What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-10293
How was this patch tested?
Unit Testing and Manual Testing.

@ArafatKhan2198 please wait for clean CI run in your fork before opening the PR

@devmadhuu @dombizita Can you please take a look.

@szetszwo @ArafatKhan2198 we've seen problems in the past with ContainerInfo#usedBytes going negative on the datanodes when block deletes happen. Block counts had a similar issue. We did some fixes in the past to try to get them more accurate but there may still be issues, or the issues are left over from when this cluster was running an older version. We ended up just not using these for anything requiring exact values. For example, container delete uses the isEmpty flag now, but container close and DU approximations still use usedBytes since those can have some margin of error.
I checked one of our clusters with the issue and SCM sees the negative counts too so it is coming from the datanodes, not Recon. I think Recon should be tolerant of the inaccuracies and probably not log anything alarming like warn/error in this case.

@szetszwo @ArafatKhan2198 we've seen problems in the past with ContainerInfo#usedBytes going negative on the datanodes when block deletes happen. Block counts had a similar issue. We did some fixes in the past to try to get them more accurate but there may still be issues, or the issues are left over from when this cluster was running an older version. We ended up just not using these for anything requiring exact values. For example, container delete uses the isEmpty flag now, but container close and DU approximations still use usedBytes since those can have some margin of error.
I checked one of our clusters with the issue and SCM sees the negative counts too so it is coming from the datanodes, not Recon. I think Recon should be tolerant of the inaccuracies and probably not log anything alarming like warn/error in this case.

Thanks @errose28 for your explanation. As you mentioned that isEmpty flag being used in SCM now to know if container bceomes empty, however Recon have a different use case where Recon has a task to categorize containers on different size ranges based on usedBytes, so Recon has to rely on this attribute, but since you mentioned this attribute has still some underlying margin of error, can Recon use something else to know the actual used space in a container. Any suggestions ?

@ArafatKhan2198 , We may consider adding a counter in Recon for the containers with negative usedBytes. It could be a useful feature for debugging and fixing clusters with such problems.

Good idea, we could consolidate all related container information into a table, including container ID, state, and other useful details. This table could then be periodically updated by the container size count task to reflect any changes, especially if a container is found to have negative used bytes.

@ArafatKhan2198 , We may consider adding a counter in Recon for the containers with negative usedBytes. It could be a useful feature for debugging and fixing clusters with such problems.

Good idea, we could consolidate all related container information into a table, including container ID, state, and other useful details. This table could then be periodically updated by the container size count task to reflect any changes, especially if a container is found to have negative used bytes.

Do not add a new table. Better add a new category of Unhealthy container in UNHEALTHY_CONTAINERS table.

@ArafatKhan2198 , We may consider adding a counter in Recon for the containers with negative usedBytes. It could be a useful feature for debugging and fixing clusters with such problems.

Good idea, we could consolidate all related container information into a table, including container ID, state, and other useful details. This table could then be periodically updated by the container size count task to reflect any changes, especially if a container is found to have negative used bytes.

Do not add a new table. Better add a new category of Unhealthy container in UNHEALTHY_CONTAINERS table.

Yes, you're correct. We could utilize the existing Unhealthy Container Table. I forgot about that!

Whatever solution we go with I don't think Recon should show user facing alerts about the negative container sizes. It will just raise more questions to users for something that is not a serious problem. I think datanodes or SCM may want to log warnings, but Recon would probably be fine with just a debug log and some sort of error handling when classifying by container sizes (maybe just round them to zero).

Whatever solution we go with I don't think Recon should show user facing alerts about the negative container sizes. It will just raise more questions to users for something that is not a serious problem. I think datanodes or SCM may want to log warnings, but Recon would probably be fine with just a debug log and some sort of error handling when classifying by container sizes (maybe just round them to zero).

Yes agree, we should not expose to UI, having it in table and periodic cleanup should be ok, and some API internally, may not be a documented one , so that using curl, we can easily fetch out such bad data. Why suggesting an API because if we are planning to store in existing SQL derby table , so someone needs not to have a client for sql table.


Default boolean value

I can't find any information on the web. I need a boolean flag that is false by default and can be toggled by simply passing --flagname instead of --flagname true. Is there something implemented in this cli?
I always get an flag provided but not defined error.

Hi @SirWindfield,
That is the default behavior of the BoolFlag. Can you provide some sample code demonstrating the undefined flag error?

I created a gist holding the code. It fails at the global check flag. I enter the following command ./main --verbose parse <dir>

Thanks for the gist. I used that code, but was unable to reproduce.
Specifically, I did:
package main

import (
	"fmt"
	"os"

	"github.com/urfave/cli"
)

func main() {
	app := cli.NewApp()

	app.Flags = []cli.Flag{
		cli.BoolFlag{
			Name:  "verbose",
			Usage: "Prints more verbose output to the console",
		},
		cli.BoolFlag{
			Name:  "dry, d",
			Usage: "Runs the algorithm without making any changes to the filesystem",
		},
	}

	app.Commands = []cli.Command{
		{
			Name:    "parse",
			Aliases: []string{"p"},
			Usage:   "Parse the specified directory",
			Action: func(c *cli.Context) {
				fmt.Printf("%+v\n", c.GlobalBool("verbose"))
			},
		},
	}

	app.Run(os.Args)
}

$ go run /tmp/tmp.go --verbose parse
true

Ok, looks like it is then probably some local file errors (maybe the repo isn't up to date or some stuff like that). Going to check real quick.

Similarly to jszwedko above, I don't think there's any bug here! So I'm going to close this. I can totally re-open it if someone can reproduce this issue 👍


chore: refactor repo structure

:tada: This PR is included in version 2.0.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Oracle

Laravel Version: 5.4
Adldap2-Laravel Version: latest
PHP Version: 7

Description:
I m using laravel with oracle. I don't need password sync.
There is problem with with databaseUserProvider because the PASSWORD is reserved keyword.
So i find solution
https://github.com/yajra/laravel-oci8/blob/5.4/src/Oci8/Auth/OracleUserProvider.php
How can i use with adldp driver?
i m using Auth::attempt($credentials)
and $credentials = ["password"=>"pp", "username"=>"test"]
Because i don't need to check db user
my workflow is next

Check username and pass with AD server
IF true then map user only by username

I don't wanna store pass localy
My config is working i can connect and i disabled sync options.
Steps To Reproduce:

Hi @marijang,
This isn't yet a configurable option unfortunately, but it's coming. If you're using the Adldap auth driver, you'll need to add a mutator to your User model to prevent it from setting the password field on your User model:
public function setPasswordAttribute($password)
{
    // Do nothing.
}

If you'd prefer to write your own implementation, it wouldn't be too difficult. Let me know if this is what you would prefer.


add flow check to windows ci

Motivation
add flow check to windows ci
Test Plan
none
Related PRs
none
Release Notes
[GENERAL] [INTERNAL] [CI] - add flow check to windows ci.

Should we run Flow for iOS files as well? Since this is only JavaScript, I expect it to work on Windows.

Is it even worth running this? Since it runs on Circle, running it on Appveyor is essentially just testing Flow itself to make sure it doesn't have weird windows specific bugs. It doesn't seem like it really tells us anything extra about our codebase.

@TheSavior Yes, because now flow is broken on windows, if we have this, we can find this earlier see https://github.com/facebook/react-native/issues/21311.
@hramos Yes, I think we can add it. My first thought is that iOS check maybe redundant on windows platform.

Flow is broken on Windows!? :O

If there is no future question, I think this can be merged.

@hramos Is anyone working on the flow issue in windows ?

This is not something I am tracking closely at the time. We should definitely merge this once #21311 is fixed, though, to prevent regressions as you suggested.

Appveyor build failed with:
$ flow check --flowconfig-name .flowconfig.android
C:\projects\react-native\node_modules\flow-bin\cli.js:17
  throw new Error('Platform not supported.');
  ^

After swith to x64 platform, here is the new error:
$ flow check --flowconfig-name .flowconfig.android
Error -------------------------------------------------------------------- node_modules/invariant/invariant.js.flow:4:14
Unclear type. Using `any`, `Object`, or `Function` types is not safe! (`unclear-type`)
   4|   condition: any,
                   ^^^
Error -------------------------------------------------------------------- node_modules/invariant/invariant.js.flow:6:18
Unclear type. Using `any`, `Object`, or `Function` types is not safe! (`unclear-type`)
   6|   ...args: Array<any>
                       ^^^

It's complaining about this file: https://github.com/zertosh/invariant/blob/master/invariant.js.flow
Imo that file should be erroring... it's annotated Flow strict mode, but it's using any types, which correctly triggers the unclear-type rule.  So the bug seems to me more like why does that file not error on Linux?
I can't see anything in RN's flowconfig which indicates that file is meant to be ignored.  So don't think this is to do with normalizing file paths like the previous errors were.

@gengjiawen Maybe this explains it: https://github.com/facebook/flow/commit/ba425e403cf40e9232aab68aff96b8e3fca192b0

@gengjiawen Maybe this explains it: facebook/flow@ba425e4

Let's wait for next release :)

@gengjiawen the latest Flow version should now be deployed on master. Can you rebase and make this PR pass on Windows? Then we can finally land and enable it!

@gengjiawen the latest Flow version should now be deployed on master. Can you rebase and make this PR pass on Windows? Then we can finally land and enable it!

Done :)

🎉 It worked! Landing.


Implement JSON utility class

This pull request replaces #40 to remove all unrelated commit history

#40 has comments I would like to keep


Porting console verbosity fixes to master.

Making Verbosity minimal by default.
Removed the code that appends extra new line.
Removed the extra tags [Information/Warning/Error] in the Output.

Hi @singhsarab, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

It looks like you're a Microsoft contributor. If you're full-time or an intern, we DON'T require a Contribution License Agreement. If you are a vendor, please DO sign the electronic Contribution License Agreement. It will take 2 minutes and there's no faxing! https://cla.microsoft.com.

TTYL, MSBOT;

Reviewed 5 of 5 files at r1.
Review status: all files reviewed at latest revision, 2 unresolved discussions, some commit checks failed.

src/vstest.console/Internal/ConsoleLogger.cs, line 59 at r1 (raw file):

        /// Level of verbosity
        /// </summary>
        private Verbosity verbosityLevel = Verbosity.Minimal;

How is this documented for the user? Will it appear in /??

test/Microsoft.TestPlatform.CoreUtilities.UnitTests/Output/OutputUtilitiesTests.cs, line 16 at r1 (raw file):

        [TestInitialize]
        public void TestInit()

Could use ctor for more readability.

Comments from Reviewable


Multiple File Upload to Blob Storage

I am not sure about the pattern but I am using the GitHub action to pull JSON files from my GitHub folder and upload it to Blob Storage for configuration setup purposes.
There are a total of 21 JSON configuration files. But somehow, when I run the workflow, some of the files are getting missed.
Also, it's not a filename issue since every time some different file ends up missing.
I am using this action.

name: Uploading to Azure storage...
uses: LanceMcCarthy/Action-AzureBlobUpload@v2
with:
connection_string: ${{ secrets.AZURE_CONNECTION_STRING }}
container_name: ${{ vars.AZURE_DTS_METADATA_CONTAINER }}
source_folder: ${{ vars.DTS_SRC_FOLDER }}
destination_folder: ${{ steps.setup_dest.outputs.destination }}

Also in logs, it shows all files being uploaded but in blob storage, some are missing.

Hi, it looks like you're using an older version. Can you please try v3 and see if that resolves it?
uses: LanceMcCarthy/Action-AzureBlobUpload@v3


UDP service - fix sample descriptions

Fix sample descriptions
Additional changes:

Remove extra spaces at the start and end of text and code.
Simplify code samples

Fixes https://github.com/dotnet/docs/issues/6070

Thanks, @karelz, for making the additional changes. I'll merge your PR now.


Issue 507 fixes

Corrected missing prefix in Apache conf causing all UI assets to request unavailable locations
Fixed DB_PORT not being passed to WebServer based on DB running in cluster
Added missing labels to webserver container for exposure of UI via /service/ context of DCOS.

Agreed. This is something I'll consider if I have time following the documentation and cleanup for this release.

There's already an issue for it, FYI.


Implement labels.

As specified in login-gov_styleguide_v1.9.3.sketch:

These should be an adaptation of Labels in the U.S. Web Design System.
There should be some documentation added about the appropriate uses for these labels as well. What are those uses?

Currently put on hold since we don't actually use labels in our apps.


Topic/neutral config

Added joints default neural configuration +
neutralConfigurations vector in Model.
Also added srdf parsing to fill the neutralConfigurations vector ( looking for "half_sitting" at the moment, should we change it to "neutral_configuration" ?
Also: in hrp2_14 and romeo srdf files i only meet joints with 1 dof. In the actual status of this PR, joints with more than 1 DoF are not handled, you will see a commented line in parser/srdf. How should it be handled ? ( I mean, can one find the following tag in an srdf file: <joint name="LARM_JOINT4" value="0.  0.  1." /> )

Coverage remained the same at 62.065% when pulling a9f71a1351552a38558dc68b3090fab7007673e0 on fvalenza:topic/NeutralConfig into 120895347ed550a3fc58f091f657a71b7c6f6d2d on stack-of-tasks:devel.


Fixed: typo in the DashboardController.php

Description
Fixed a typo in DashboardController.php replacing twillTrans('twill::lang.dashboard.unkown-author') to twillTrans('twill::lang.dashboard.unknown-author')

Related Issues
Fixes #1153

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Create codeql-analysis.yml

codeql is a tool for security analysis, provided by github and
integrated to github.
Maintainers will complete the following section

[ ] Commit messages are descriptive enough
[ ] Code coverage from testing does not decrease and new code is covered
[ ] JSON/YAML configuration changes are updated in the relevant schema
[ ] Changes to metadata also update the documentation for the metadata
[ ] Pull request has a link to an osbs-docs PR for user documentation updates
[ ] New feature can be disabled from a configuration file

Hmm, this is already part of LGTM.com https://codeql.github.com/  (it is not showing results in github web, only in LGTM).
But I think that one integration is enough


add callback support and fix tests

fixes #3
fixes #7

@tremby would you mind reviewing?

Callback works for me, called at the right time, so #3 looks good.
Test now fails if it beeps more or fewer times than expected, so #7 looks good.
I noticed something else, though, which I'll fix in a new PR.

Actually no, there is a bug, #3 is not good. If called with 1, it beeps once but the callback does not fire.

Actually no, there is a bug, #3 is not good. If called with 1, it beeps once but the callback does not fire.

Should be fixed.

Lgty?

Yes. I'm about to open another PR which builds on this one.


The orders page throws an error when there is a partially filled order

Hi,
I noticed that every time I have an order that is partially matched, the \orders page shows this error message:
Whoops!
We couldn’t load that feature. Please try again!

I'm using the official web site, and the error shows on page https://www.stellarx.com/activity/orders.
I have a pending  [GOLD GRAM] Sell order, partially filled. Actually, when I'm writing, it is still in front of the market at price 677.
Like I said before when I click Activity (https://www.stellarx.com/activity/orders) The error message is :
Whoops!
We couldn’t load that feature. Please try again!

Gotcha. I was asking how you came to this place to submit your issue because we are not part of StellarX (maybe they sent you a bad error message asking you to submit here?).
Please contact StellarX support here: https://stellarxsupport.zendesk.com/hc/en-us
Looks like it's a StellarX issue.


Remove reduntant error code store for no-interrupt case

Why is the error code store redundant? If dynamic interruption is disabled we still want to get error codes like overflow, etc.

What happens is we already store it with record_error_code inside the row function, then at the upper level we load the value to check if an error occurred, and if yes we store it back again. I discovered this while triaging the GPU hanging issue on a specific query. I wasn't sure that's always the case (even though we seem to always do it unconditionally, see createErrorCheckControlFlow), so I created this draft to check with CI.

I saw cases when row_func doesn't even get error_code but still can return a non-zero value. This happens when the number of matched rows exceeds max_matched value. In this case, we return -pos written later to error_code. I'm not sure if this is used in tests, but looks like a useful feature to interrupt and then continue execution from the last position.


xml is obsolete deprecated serializable format

You should use json or yaml as a human-readable format. Or binary serialization for speed dependent operations.

I mean these days there are only two reasons to use xml:

third party service does not support anything else than xml
are you so scared of getting broken data that insert a hash into each tag

<outer crc32="...">
	<inner1 crc32="...">
		...
	</inner1>
	...
	<innerN crc32="...">
		...
	</innerN>
</outer>

XML was removed and I added json support.


Cursor over variables does not work on members on current debugging line

Works hovering over contentWindow on line 104 but not on line 102

This is a current limitation of the debug hover that it does not have a full language understanding and does some heuristics to figure out the parent chain of the value that is being hovered over. In this case the bracket before the frame is stopping the heuristic from finding that the frame is the parent of the hovered value - contentWindow.
To improve this the debug hover would need to have an AST understanding of the language which is a feature request and not yet on the plan.

I don't buy it. It works when the hover is on either side of the current
debug target line. Just on the highlighted line it is wrong.
On 5/02/2016 11:01 pm, "Isidor Nikolic"<EMAIL_ADDRESS>wrote:

This is a current limitation of the debug hover that it does not have a
full language understanding and does some heuristics to figure out the
parent chain of the value that is being hovered over. In this case the
bracket before the frame is stopping the heuristic from finding that the
frame is the parent of the hovered value - contentWindow.
To improve this the debug hover would need to have an AST understanding of
the language which is a feature request and not yet on the plan.
—
Reply to this email directly or view it on GitHub
https://github.com/Microsoft/vscode/issues/2721#issuecomment-180280109.

Dup of https://github.com/Microsoft/vscode/issues/24520


[WIP] Cannot clone a VM with a hotplug disk

What this PR does / why we need it:
Adds a test that reproduces https://bugzilla.redhat.com/show_bug.cgi?id=2237418.
The test can be found here: https://github.com/kubevirt/kubevirt/pull/10527/commits/1de3a1e7c2c5bc5845d57e42607bdfa61a85bb9b.
As described in the BZ, during the test the following happens:
> k get vm -Aw
selecting docker as container runtime
NAMESPACE                NAME              AGE     STATUS                    READY
kubevirt-test-default1   testvmi-fb92r     4m41s   Stopped                   False
kubevirt-test-default1   vm-clone-target   3m49s   WaitingForVolumeBinding   False

The clone target VM cannot be started.
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #
Special notes for your reviewer:
Checklist
This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR.
Approvers are expected to review this list.

[ ] Design: A design document was considered and is present (link) or not required
[ ] PR: The PR description is expressive enough and will help future contributors
[ ] Code: Write code that humans can understand and Keep it simple
[ ] Refactor: You have left the code cleaner than you found it (Boy Scout Rule)
[ ] Upgrade: Impact of this change on upgrade flows was considered and addressed if required
[ ] Testing: New code requires new unit tests. New features and bug fixes require at least on e2e test
[ ] Documentation: A user-guide update was considered and is present (link) or not required. You want a user-guide update if it's a user facing feature / API change.
[ ] Community: Announcement to kubevirt-dev was considered

Release note:

/test pull-kubevirt-e2e-k8s-1.27-sig-storage

/test pull-kubevirt-e2e-k8s-1.27-sig-storage

/cc @mhenriks @aglitke @ShellyKa13 @awels


TypeError: testSuite.testcase is not iterable

I'm seeing this error when I try to use this action in CI (example failing run at https://github.com/jhurliman/music-interpolation/actions/runs/5825642285/job/15797676619).
/home/runner/work/_actions/pmeier/pytest-results-action/main/dist/index.js:7273
    for (const result of testSuite.testcase) {
                                   ^

TypeError: testSuite.testcase is not iterable
    at extractResults (/home/runner/work/_actions/pmeier/pytest-results-action/main/dist/index.js:7273:36)
    at async postResults (/home/runner/work/_actions/pmeier/pytest-results-action/main/dist/index.js:7247:[19](https://github.com/jhurliman/music-interpolation/actions/runs/5825642285/job/15797676619?pr=1#step:9:20))
    at async main (/home/runner/work/_actions/pmeier/pytest-results-action/main/dist/index.js:7605:3)

Duplicate of #10. This happens if there is only a single test or error in the resulting file.


Add shared projects instead of linked files to improve code sharing

It might look a bit overwhelming at first, but once people start adding more "Created" & "Embed" tasks you'll notice that it's nice to have a "1 go-to" shared project for all shared code.

Looks great!


Make namespace configureable for services

https://github.com/longhorn/longhorn/issues/3433
Signed-off-by: Lukas Auerbeck<EMAIL_ADDRESS>

@jenting Please help review. After merging, please help backport to 1.1.4 as well. Thank you!

@jenting Please help review. After merging, please help backport to 1.1.4 as well. Thank you!

#3463


Won't install on Ubuntu 16.04

There are issues with installing on Ubuntu 16.04. pty.js has node-gyp rebuild issues.

I have the same issue.

Same here I get this:

<EMAIL_ADDRESS>install /home/username/src/wetty/node_modules/pty.js
node-gyp rebuild

/bin/sh: 1: node: not found
gyp: Call to 'node -e "require('nan')"' returned exit status 127 while in binding.gyp. while trying to load binding.gyp
gyp ERR! configure error
gyp ERR! stack Error: gyp failed with exit code: 1
gyp ERR! stack     at ChildProcess.onCpExit (/usr/share/node-gyp/lib/configure.js:354:16)
gyp ERR! stack     at emitTwo (events.js:87:13)
gyp ERR! stack     at ChildProcess.emit (events.js:172:7)
gyp ERR! stack     at Process.ChildProcess._handle.onexit (internal/child_process.js:200:12)
gyp ERR! System Linux 4.4.0-51-generic
gyp ERR! command "/usr/bin/nodejs" "/usr/bin/node-gyp" "rebuild"
gyp ERR! cwd /home/username/src/wetty/node_modules/pty.js
gyp ERR! node -v v4.2.6
gyp ERR! node-gyp -v v3.0.3
gyp ERR! not ok
npm ERR! Linux 4.4.0-51-generic
npm ERR! argv "/usr/bin/nodejs" "/usr/bin/npm" "install" "pty.js"
npm ERR! node v4.2.6
npm ERR! npm  v3.5.2
npm ERR! code ELIFECYCLE
npm ERR<EMAIL_ADDRESS>install: node-gyp rebuild
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>install script 'node-gyp rebuild'.
npm ERR! Make sure you have the latest version of node.js and npm installed.
npm ERR! If you do, this is most likely a problem with the pty.js package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     node-gyp rebuild
npm ERR! You can get information on how to open an issue for this project with:
npm ERR!     npm bugs pty.js
npm ERR! Or if that isn't available, you can get their info via:
npm ERR!     npm owner ls pty.js
npm ERR! There is likely additional logging output above.
npm ERR! Please include the following file with any support request:
npm ERR!     /home/username/src/wetty/npm-debug.log

This fixed it for me:
sudo apt-get install nodejs-legacy
Details here: http://stackoverflow.com/questions/21168141/cannot-install-packages-using-node-package-manager-in-ubuntu

Didn't work for me. And I already had that installed when I first had the issue.

I get the same problem using Debian Jessie. I also installed npm nodejs-legacy, and still get the same error. Any solution?

I too wasted alot of time on this. for future purposes. All you have to do is sudo apt-get install -y build-essential

Update node to last version. Worked for me.
npm cache clean -f npm install -g n n stable

Same issue. Use yarn install instead, it works well.

Hi all, any updates on this issue? none of above suggestions work for me.

I too wasted alot of time on this. for future purposes. All you have to do is sudo apt-get install -y build-essential

Thanks mate


firefox-bin: 91.0 -> 91.0.1

Motivation for this change

High security fix
Other updates and fixes

https://www.mozilla.org/en-US/firefox/91.0.1/releasenotes/
https://www.mozilla.org/en-US/security/advisories/mfsa2021-37/
Related: https://github.com/NixOS/nixpkgs/pull/134584
Things done

[X] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[X] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[X] Tested execution of all binary files (usually in ./result/bin/)
21.11 Release Notes (or backporting 21.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[X] Fits CONTRIBUTING.md.

Already in master after 027b2ac2eb415d4efc49a044b596f01c5d0125ae/#134584


You should really try this out. https://github.com/elParaguayo/qtile-extras

Thanks, I'm using the decorations from there :D


Return button in text input should be handled as kboard key event (not text input event)

There is an incorrect return button handling within dialog with user input. Return handled inside the text input handler, so the reply is to be accepted on return press, it causes an NPC reply to be shown and skipped on button release.
So the Return handling for user input should be moved to window_handle_kboard.

Done in 8f95b9fc5706723becda81882d92b394f9ab584c commit.


I wrote youtube channel instead of youtube page and i wrote let's  wind which helps in interaction with readers.

@Mranonymoussg thank you for the suggestion and PR.


Light and Shadow?

A major design principle of Material Design is Light and Shadow. Currently MaterialSkin does not implement any lighting or shadow effects. Is this planned?

MaterialSkin components currently all have the property Depth that describes this. However, this hasn't been implemented yet.
The difficulty is that all controls take care of their own rendering. Shadows, described with depth, should be caluclated relatively. e.g. if  control with depth 4 'sits' on a control with depth 2 the shadow should be less hard than when it would be placed on a control with depth 0. This makes the calculation harder.
You could decide not to calculate depths relatively, but there would still be a though difficulty. Controls can't draw out of their bounds.
What I'm thinking of right now is creating a sort of 'Depth Container Control' that would wrap any MaterialSkin component and that would handle the depth.
I see MaterialSkin as a secondary project for me, so I do not have anything planned myself to work on it.

As pointed out above, shadow effects need to be implemented by the container for any controls requiring such effects. I have implemented a simple approach to support "card" like objects built from panels and posted the code to StackOverflow here http://stackoverflow.com/questions/2463519/drop-shadow-in-winforms-controls in response to a 6 year old question on the subject.


error: default initialization of an object of const type 'const Subgraph::Identity' without a user-provided default constructor

Please make sure that this is a build/installation issue. As per our GitHub Policy, we only address code/doc bugs, performance issues, feature requests and build/installation issues on GitHub. tag:build_template
System information

OS Platform and Distribution (e.g., Linux Ubuntu 16.04):
OS X 10.11.6

Mobile device (e.g. iPhone 8, Pixel 2, Samsung Galaxy) if the issue happens on mobile device:

TensorFlow installed from (source or binary):
Source

TensorFlow version:
13.1

Python version:
3.6.7

Installed using virtualenv? pip? conda?:
Conda

Bazel version (if compiling from source):
bazel 18.1 & 0.21.1

GCC/Compiler version (if compiling from source):
$ g++ --version
Configured with: --prefix=/Applications/Xcode.app/Contents/Developer/usr --with-gxx-include-dir=/usr/include/c++/4.2.1
Apple LLVM version 8.0.0 (clang-8<IP_ADDRESS>)
Target: x86_64-apple-darwin15.6.0
Thread model: posix
InstalledDir: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin
MacBook-Pro:tensorflow davidlaxer$ c++ --version
Apple LLVM version 8.0.0 (clang-8<IP_ADDRESS>)
Target: x86_64-apple-darwin15.6.0
Thread model: posix
InstalledDir: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin
MacBook-Pro:tensorflow davidlaxer$ clang --version
clang version 5.0.0 (tags/RELEASE_500/final)
Target: x86_64-apple-darwin15.6.0
Thread model: posix
InstalledDir: /Users/davidlaxer/anaconda/bin
MacBook-Pro:tensorflow davidlaxer$ which clang
/Users/davidlaxer/anaconda/bin/clang
MacBook-Pro:tensorflow davidlaxer$ /Users/davidlaxer/anaconda/bin/clang --version
clang version 5.0.0 (tags/RELEASE_500/final)
Target: x86_64-apple-darwin15.6.0
Thread model: posix

CUDA/cuDNN version:
CPU Only

GPU model and memory:

Describe the problem
ERROR: /Users/davidlaxer/tensorflow/tensorflow/core/grappler/graph_analyzer/BUILD:5:1: C++ compilation of rule '//tensorflow/core/grappler/graph_analyzer:graph_analyzer_lib' failed (Exit 1)
tensorflow/core/grappler/graph_analyzer/graph_analyzer.cc:75:28: error: default initialization of an object of const type 'const Subgraph::Identity' without a user-provided default constructor
const Subgraph::Identity empty_parent;
^
{}
1 error generated.
Target //tensorflow/tools/pip_package:build_pip_package failed to build
Use --verbose_failures to see the command lines of failed build steps.
Provide the exact sequence of commands / steps that you executed before running into the problem
$ bazel build --config=opt //tensorflow/tools/pip_package:build_pip_package
Any other info / logs
Include any logs or source code that would be helpful to diagnose the problem. If including tracebacks, please include the full traceback. Large logs and files should be attached.

TensorFlow requires macOS 10.12.6 (Sierra) or later (64-bit)

I was able to Tensorflow built 1.12  from source on 10.11.6.
Is that the final version I can build on this OS?

On May 20, 2019, at 3:46 PM, ymodak<EMAIL_ADDRESS>wrote:
TensorFlow requires macOS 10.12.6 (Sierra) or later (64-bit)
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

In Tensorflow 13.1 , I adjusted the Subgraph::Identity initialization.  But ...
ERROR: /Users/davidlaxer/tensorflow/tensorflow/contrib/ignite/BUILD:148:1: Executing genrule //tensorflow/contrib/ignite:gen_igfs_ops_pygenrule failed (Trace/breakpoint trap): bash failed: error executing command /bin/bash -c ... (remaining 1 argument(s) skipped)
dyld: lazy symbol binding failed: Symbol not found: _clock_gettime
  Referenced from: /private/var/tmp/_bazel_davidlaxer/f9fe21ec5c09226e5ca0dce9376abe82/execroot/org_tensorflow/bazel-out/host/bin/tensorflow/contrib/ignite/../../../_solib_darwin_x86_64/_U_S_Stensorflow_Scontrib_Signite_Cgen_Ugen_Uigfs_Uops_Upy_Uwrappers_Ucc___Utensorflow/libtensorflow_framework.so (which was built for Mac OS X 10.12)
  Expected in: /usr/lib/libSystem.B.dylib

dyld: Symbol not found: _clock_gettime
  Referenced from: /private/var/tmp/_bazel_davidlaxer/f9fe21ec5c09226e5ca0dce9376abe82/execroot/org_tensorflow/bazel-out/host/bin/tensorflow/contrib/ignite/../../../_solib_darwin_x86_64/_U_S_Stensorflow_Scontrib_Signite_Cgen_Ugen_Uigfs_Uops_Upy_Uwrappers_Ucc___Utensorflow/libtensorflow_framework.so (which was built for Mac OS X 10.12)
  Expected in: /usr/lib/libSystem.B.dylib

/bin/bash: line 1: 53224 Trace/BPT trap: 5       bazel-out/host/bin/tensorflow/contrib/ignite/gen_gen_igfs_ops_py_wrappers_cc , '' 0 0 > bazel-out/darwin-opt/genfiles/tensorflow/contrib/ignite/python/ops/gen_igfs_ops.py
Target //tensorflow/tools/pip_package:build_pip_package failed to build
Use --verbose_failures to see the command lines of failed build steps.
INFO: Elapsed time: 3007.455s, Critical Path: 200.07s
INFO: 2483 processes: 2483 local.
FAILED: Build did NOT complete successfully

I am not familiar with this code. Please reassign to grappler developers.

I'm not familiar with grappler unfortunately, unassigning myself.

Hi @dbl001 !
It seems you are using older versions(1.x versions) of Tensorflow. We recommend that you upgrade  your code base to 2.x  versions as many features and bug fixes has been done in newer versions and let us know if the issue still persists in newer versions.
Tensorflow 2.6 is available on Macbook M1 ,Please follow this reference
You can also build from using this link using Bazel. Please create a new issue ,if you face any problem!
Thanks!


Point added under [ important ] section : Line 20

ACLs are not supported on NSF4 file share on linux clients.

@khdownie
Can you review the proposed changes?
When the changes are ready for publication, add a #sign-off comment to signal that the PR is ready for the review team to merge.
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

Fixed in a separate PR. Changes are live: https://learn.microsoft.com/en-us/azure/storage/files/files-nfs-protocol

#please-close


Breadth First Search in Java

This issue is about [Algo/DS Name/Question Name](link to resource for the Algo/DS/Question)

[ ] I searched or browsed the repo’s other issues to ensure this is not a duplicate

[ ] Issue Title is in form [Algo/DS Name] in [Language] (ex:- BubbleSort in Java)

[ ] I will send my PR only after I'm assigned to this issue by any maintainer

[ ] Assign this issue to me (I want to work on this)

[ ] I ensure that I am not already assigned to 2 or more issues

Kindly assign this to me.

Sir, Here is the pull request:
https://github.com/SobhanBera/algorithms/pull/85


Update/refactor docs

This commit is to update go version and also refactor some parts
of doc

What this PR does / why we need it:
Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #
Special notes for your reviewer:
Release note:

@ramineni Thanks, mostly looks good to me, just one suggestion inline

@adisky updated. PTAL

@adisky updated. PTAL

@ramineni Thanks!!

/lgtm
/approve


Livy shell UX improvements

I'm not sure how large of an audience the livy-shell has, but I've come to use it quite a bit in my testing/use of Livy and added a few small improvements that have made it a bit easier to use for me (and may help others):

Replaced the use of httplib with requests to fix dropped connection issues (and a few other robustness issues).
Added some context to the REPL prompt, by including the session kind and ID.
Ignore SIGINT signal so that users can type CTRL-C to cancel out a command.

I know the use of requests is pretty ubiquitous but I included livy-shell-requirements.txt just in case 1) someone doesn't have it installed or 2) more dependencies are added down the road.

Codecov Report

Merging #55 into master will increase coverage by 0.74%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master      #55      +/-   ##
============================================
+ Coverage     70.13%   70.87%   +0.74%
- Complexity      790      791       +1
============================================
  Files            97       97
  Lines          5384     5384
  Branches        798      798
============================================
+ Hits           3776     3816      +40
+ Misses         1069     1034      -35
+ Partials        539      534       -5

Impacted Files
Coverage Δ
Complexity Δ

...in/java/org/apache/livy/rsc/rpc/RpcDispatcher.java
64% <0%> (-2%)
19% <0%> (-1%)

...in/java/org/apache/livy/rsc/driver/JobWrapper.java
80.64% <0%> (ø)
8% <0%> (+1%)
:arrow_up:

...ava/org/apache/livy/client/http/JobHandleImpl.java
75.22% <0%> (+0.91%)
13% <0%> (ø)
:arrow_down:

...c/main/java/org/apache/livy/LivyClientBuilder.java
83.33% <0%> (+1.66%)
17% <0%> (ø)
:arrow_down:

...ain/java/org/apache/livy/client/http/HttpConf.java
76.92% <0%> (+1.92%)
5% <0%> (ø)
:arrow_down:

...java/org/apache/livy/client/common/ClientConf.java
99.06% <0%> (+2.8%)
44% <0%> (ø)
:arrow_down:

...main/java/org/apache/livy/rsc/ContextLauncher.java
83.66% <0%> (+2.97%)
17% <0%> (ø)
:arrow_down:

...n/java/org/apache/livy/client/http/HttpClient.java
82.81% <0%> (+3.12%)
15% <0%> (ø)
:arrow_down:

...ain/java/org/apache/livy/rsc/driver/RSCDriver.java
80% <0%> (+4.25%)
42% <0%> (+1%)
:arrow_up:

.../java/org/apache/livy/rsc/driver/SparkEntries.java
60.27% <0%> (+5.47%)
10% <0%> (ø)
:arrow_down:

... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ff6c2eb...3b282af. Read the comment docs.

A few notes and issues:

If you could please open a JIRA for this and update the title according to the contributor guidelines (https://livy.incubator.apache.org/community/)
I like your idea of using the requests library, but since I only have passing knowledge of python I'll defer to others on whether it makes sense from a python choice @jerryshao
I don't think adding the livy-shell-requirements.txt file makes sense, adding a inline comments or a help print line would be better options.
I have mixed feelings on handling SIGINT but I lean toward agreeing with you
I like the addition of showing kind and id in the prompt given our recent addition of shared language support.

@ajbozarth thank you for the quick response

Sorry about that, I have created https://issues.apache.org/jira/browse/LIVY-409 and updated the title of this PR to reflect the link.
I removed livy-shell-requirements.txt and exit with a message if that module cannot be imported. Happy to take suggestions if you'd like to see something different.

Running build again.

@ajbozarth I fixed another issue I missed and re-ran the build a few times to get it to pass. This should be ready to review again.

Thanks @ericjperry for your contribution, I think we seldom use Livy shell for testing and others, but it is better to keep this up-to-date, I think it is useful in local test. Will spend time to review this.

If @jerryshao signs off on this then LGTM

@ajbozarth @jerryshao apologies, but I found an issue with the SIGINT handling in my code, which was concatenating lines of input together into a single command. I updated the loop to continue and reissue the raw_input call if a user submitted the ctrl-C command. This works far better and doesn't involve the raw writes to stdout which is a little nicer.

The latest update still look fine to me, but I was wondering why there are so many extra blank lines in the file? Is it a python thing? Cause I've alway thought multiple empty lines in a row was bad style no matter the language.

@ajbozarth I may have gone a bit overboard but PEP8's guidance on blank lines says to surround top level functions and class definitions with two blank lines: http://legacy.python.org/dev/peps/pep-0008/#blank-lines.
Since there aren't any class members in here I split everything up with two blank lines.

I think @ericjperry is right, python code follows two blank lines convention between class definitions and top level functions, you can refer to pyspark code @ajbozarth .

Thanks, good to know more python style conventions :)

@ajbozarth @jerryshao is there any trick here to getting the tests to pass?

Usually just trying it again, I've never seen it fail this much before

@ajbozarth @jerryshao Tests passed!

Thanks for the contribution, merging to master.


process_replay: in-place modification for message migration

Down to 0.9 sec for rlog and 0.09 for qlog (from 2.5 and 0.3)

@BBBmau looks like the open is inverted?


change Taliwind to Tailwind

What kind of changes does this PR include?

Minor content fixes (broken links, typos, etc.)

Description

What does this PR change? Give us a brief description.
Fixed a small typo, Tailwind was referred to as Taliwind

Looks great, @andriesniemandt! Thanks so much for spotting this, and taking the time to contribute. Welcome to Team Docs!  🥳


Expand main vignette

It would be good to expand the main vignette and revise the organization of the information that is presented there.

If possible, try to keep the number of sections equal to avoid changing the section numbers, which would break vignette links people may have used. Although, if there is a clear need for additional sections then I guess giving up consistency is worth it.

May I suggest that we first make an offline plan for this issue? FOr example, in shared Word document?
The risk is that we spend months on updating and expanding the vignette, but it may help to first have a map of what we aim for and priorities:

To what extent does the section structure need to be re-order?
Are there missing sections?
Which sections are weak and need to be revised first?
Are there parts that can be easily moved outside GGIR, e.g. to my website and then referenced from the vignette?
Which of all these potential areas are most urgent? For example, which ones directly complement the GGIR training or which ones contain mistakes and are not clear to the user.

Also, I think we need to do a careful typo check. For example, I just spotted that ActCR is written as "Ac tCR" in several places. It is as if the problem with the random spaces we had earlier is not resolved yet.

Now closing this issue: We now plan to move substantial parts of the vignette to github.io documentation. Probably easier to create specific issues for that project then to have this issue still open.


I get the error 403, ONLY when trying to print members of one group.

The issue tracker is for reporting product deficiencies. "How do I?" questions should be posted to the discussion forum at https://groups.google.com/group/google-apps-manager. When in doubt, start at the discussion forum and return here only when instructed to do so.
Please confirm the following:

I have upgraded to the latest GAM release from https://git.io/gamreleases and I still have this issue.
I am typing the command as described in the GAM Wiki at https://github.com/jay0lee/gam/wiki

Full steps to reproduce the issue:

Try to print group members
gam print group-members group mygroup membernames
most groups will simply print, but one group gives error:
ERROR: 403: Domain cannot use apis. - domainCannotUseApis

Expected outcome (what are you trying to do?):
I expect to get the list of names I get the error above, ONLY on one group.
Actual outcome (what errors or bad behavior do you see instead?):
I get the error above, ONLY on one group.

I was using version 4.3.2 initially, but upgraded to 4.6.0 and still have the same issue.

What happens if you do: gam info group mygroup
Is mygroup in your domain?
Ross
On Mon, Aug 6, 2018 at 1:55 PM pprotogam<EMAIL_ADDRESS>wrote:

The issue tracker is for reporting product deficiencies. "How do I?"
questions should be posted to the discussion forum at
https://groups.google.com/group/google-apps-manager. When in doubt, start
at the discussion forum and return here only when instructed to do so.
Please confirm the following:

I have upgraded to the latest GAM release from
https://git.io/gamreleases and I still have this issue.
I am typing the command as described in the GAM Wiki at
https://github.com/jay0lee/gam/wiki

Full steps to reproduce the issue:

Try to print group members
gam print group-members group mygroup membernames
most groups will simply print, but one group gives error:
ERROR: 403: Domain cannot use apis. - domainCannotUseApis

Expected outcome (what are you trying to do?):
I expect to get the list of names I get the error above, ONLY on one group.
Actual outcome (what errors or bad behavior do you see instead?):
I get the error above, ONLY on one group.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/jay0lee/GAM/issues/778, or mute the thread
https://github.com/notifications/unsubscribe-auth/AIU8L4IofZOJb7aUlKiKS65arVPJMoQTks5uOK1bgaJpZM4VxEjw
.

--
Ross Scroggs
<EMAIL_ADDRESS>


Temporarily disable Espressif in CI until fixed upstream

See https://github.com/esp-rs/xtensa-lx/issues/14 and https://github.com/rust-embedded/svd2rust/pull/564#issuecomment-1011606835

r? @Emilgardis
(rust-highfive has picked a reviewer for you, use r? to override)

bors merge


Fix discord support link

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):
Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] My code follows the code style of this project.
[x] My change requires a change to the documentation.
[x] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[x] I have added tests to cover my changes.
[x] All new and existing tests passed.

Hey @PululuK, thanks for your attention, I'm happy to see you here.
I hope to see you more on this repo ;) please let me know if you see we can improve the idea, at anytime.


Change icon of default buttons

Is it possible to change the icon of the default buttons?
I once requested this feature but my request has been closed with the message that it has been implemented in version 0.3.0.
Except that I can't find any documentation / example for this?
I do see that custom buttons were introduced but I just want to change the up/stop/down buttons to mdi:arrow-up-bold-circle-outline, mdi:stop-circle-outline and mdi:arrow-down-bold-circle-outline respectively. (in order to match other UI elements in my dashboard)

I think there was a misunderstanding: state color is a feature of this card which changes the icon color respectively to the state.
This card won't get any new features, as I am working more or less atm on a new card. Just trying to keep it as long a possible life.
Do you know card-mod? Should be easy to change the color with it.

I do not want to change the color but maybe you meant to say that I can change the icon with card-mod?

Sad to read that this card won't get any new features. Are you creating a new covers card then? And is it already available for testing/beta users?

It will support nearly every entity type and I will try to fit in all known features from this card too.
No, I am not convinced atm with the main handling, I am breaking my head about this for months already.

I do not want to change the color but maybe you meant to say that I can change the icon with card-mod?

My bad, this happens when you try to answer in between gym sets 🫣.
Still don't know which feature you saw, you can't change icons. You can just customize all actions of all three main buttons.
I need to look at home, but I am quite sure the icons are hardcoded.

Ok. So no more feature updates to this card for now so I decided to not update anymore and change it to my likings for now.
So far I changed the icons to my likings by changing the mdiChevronDown, mdiChevronUp and mdiStop variables inside the script.
So far, so good.
The only thing that's bothering me now is the fact that the slide no longer has working tooltip and won't show the position before letting go your finger/mouse when changing the position.
This is not a new feature but a bugfix request. I already opened another issue for that. I hope you can fix this or at least point me in the right direction on how to get it fixed?

Yes this is correct, just import the icons from the library and use it at the point where it renders the buttons.
I saw that issue and I never notice it myself until today. But I noticed one thing mini media player card, which has the same slider as this card: it's very buggy with the slider. Seems like they reimplemented the tool tip, but not that perfomant.
I need to look if there is a quick fix possible, but I don't have high hopes.


'import param' fails: ImportError: cannot import name 'version' from 'param._version' (/usr/local/lib/python3.9/site-packages/param/_version.py)

ALL software version info
Version: 2.0.1
Python 3.9
py39-hatch-vcs-0.4.0
py39-hatchling-1.20.0
FreeBSD 14.0
Description of expected behavior and the observed behavior
>>> import param
Traceback (most recent call last):
  File "/usr/local/lib/python3.9/site-packages/param/__init__.py", line 89, in <module>
    raise FileNotFoundError
FileNotFoundError

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/usr/local/lib/python3.9/site-packages/param/__init__.py", line 93, in <module>
    from ._version import __version__
ImportError: cannot import name '__version__' from 'param._version' (/usr/local/lib/python3.9/site-packages/param/_version.py)

Complete, minimal, self-contained example code that reproduces the issue
# code goes here between backticks

How did you install param?  It looks like it was done with a Linux distribution, which did not package the _version file.

param was built and installed using the PEP517-compliant build and install projects within the FreeBSD ports framework.

Hi @yurivict, you mention the install project, is it thin one https://pypi.org/project/install/?
I've just tried the following with success:

Clone the repo and cd into it
python3 -m venv .venv and source .venv/bin/activate
python -m build
pip install dist/param-2.0.2.dev2+g3e90912-py3-none-any.whl
mkdir foo && cd foo
Run the Python interpreter and import param

Could you please report the exact steps that lead you to the error you reported?

Here is the log.

Thanks @yurivict, but I'm still confused by this issue.
I've tried to reproduce locally some of the steps you shared in this log file (get sdist, install build/installer/hatchling/hatch-vcs, isolated wheel build, wheel installed with installer) and could import param without any issue.
Coming back to your traceback, it clearly shows that the param/_version.py module exists (otherwise you would see a ModuleNotFoundError) but that it does not contain a __version__ variable, resulting in an ImportError. However, I can confirm that the sdist on PyPI has a __version__ variable in the param/_version.py module:
❯ curl -sL "https://files.pythonhosted.org/packages/14/c8/b42882ed1ba40478d5c1daa6fbb953c8180ea69fe94b9e6783060f5564ae/param-2.0.1.tar.gz" | tar -xzO "param-2.0.1/param/_version.py"
# file generated by setuptools_scm
# don't change, don't track in version control
TYPE_CHECKING = False
if TYPE_CHECKING:
    from typing import Tuple, Union
    VERSION_TUPLE = Tuple[Union[int, str], ...]
else:
    VERSION_TUPLE = object

version: str
__version__: str
__version_tuple__: VERSION_TUPLE
version_tuple: VERSION_TUPLE

__version__ = version = '2.0.1'
__version_tuple__ = version_tuple = (2, 0, 1)

Maybe you could check the content of param/_version.py in your pipeline?

Oh wait wait wait, I think I know, do you download param-2.0.1.tar.gz from Github?

Oh wait wait wait, I think I know, do you download param-2.0.1.tar.gz from Github?

No, the tarball is downloaded from the PYPI site: https://pypi.org/packages/source/p/param/param-2.0.1.tar.gz

Ok ok. I'm at a loss there :/ Really wish I could unblock you. I'd be curious to see the content of param._version.py at different stages of your pipeline.

Before build:
$ cat ./work-py39/param-2.0.1/param/_version.py
# file generated by setuptools_scm
# don't change, don't track in version control
TYPE_CHECKING = False
if TYPE_CHECKING:
    from typing import Tuple, Union
    VERSION_TUPLE = Tuple[Union[int, str], ...]
else:
    VERSION_TUPLE = object

version: str
__version__: str
__version_tuple__: VERSION_TUPLE
version_tuple: VERSION_TUPLE

__version__ = version = '2.0.1'
__version_tuple__ = version_tuple = (2, 0, 1)

After build:
$ cat ./work-py39/param-2.0.1/param/_version.py
# coding: utf-8
# file generated by setuptools_scm
# don't change, don't track in version control
version = '2.0.1'
version_tuple = (2, 0, 1)

py39-setuptools_scm-6.4.2 is used.

The latest is setuptools-scm 8.0.4, but it wasn't yet adopted.
Now I vaguely remember that a similar problem happened with some other port because setuptools-scm was 6.x, and they had to patch the project in some way because setuptools-scm changed behavior between versions.

Indeed __version__ was added in _version.py to setuptools-scm in version 7.0.0 (part of this massive PR https://github.com/pypa/setuptools_scm/pull/580/files#diff-bdefa0298003efada7c465428643cc6d9c129168afb3eb5c551b40fcc77feac1R42).
To add compatibility to older versions of setuptools-scm it seems we could try to import version if importing __version__ files. I also see in their docs they suggest using:
from importlib.metadata import version, PackageNotFoundError

try:
    __version__ = version("package-name")
except PackageNotFoundError:
    # package is not installed
    pass

Feel free to have a look at https://github.com/holoviz/param/pull/903 :)
We plan to release 2.0.2 soon, it's very likely it'll include this fix.