LLMMatchChain ValueError encountered when using ZeroShotAgent

# Load the tool configs that are needed.
from langchain import LLMMathChain, SerpAPIWrapper
llm = OpenAI(temperature=0)
search = SerpAPIWrapper()
llm_math_chain = LLMMathChain(llm=llm, verbose=True)
tools = [
    Tool(
        name = "Search",
        func=search.run,
        description="useful for when you need to answer questions about current events"
    ),
    Tool(
        name="Calculator",
        func=llm_math_chain.run,
        description="useful for when you need to answer questions about math"
    )
]

agent = initialize_agent(tools, llm, agent="zero-shot-react-description", verbose=True)
agent.run("Who won the US Open men's tennis final in 2022? What is the next prime number after his age?")

Produces:
Who won the US Open men's tennis final in 2022? What is the next prime number after his age?
Thought: I need to find out who won the US Open and then calculate the next prime number
Action: Search
Action Input: "US Open men's tennis final 2022"
Observation: Spain's Carlos Alcaraz, 19, defeated Casper Ruud in the 2022 US Open men's singles final to earn his first Grand Slam title.
Thought: I need to calculate the next prime number
Action: Calculator
Action Input: 19

> Entering new LLMMathChain chain...
19 + 4
Answer: 23Traceback (most recent call last):
  File "/Users/ankushgola/Code/langchain/tests/agent_test.py", line 70, in <module>
    main()
  File "/Users/ankushgola/Code/langchain/tests/agent_test.py", line 65, in main
    agent.run("Who won the US Open men's tennis final in 2022? What is the next prime number after his age?")
  File "/Users/ankushgola/Code/langchain/langchain/chains/base.py", line 134, in run
    return self({self.input_keys[0]: text})[self.output_keys[0]]
  File "/Users/ankushgola/Code/langchain/langchain/chains/base.py", line 107, in __call__
    outputs = self._call(inputs)
  File "/Users/ankushgola/Code/langchain/langchain/agents/agent.py", line 150, in _call
    observation = chain(output.tool_input)
  File "/Users/ankushgola/Code/langchain/langchain/chains/base.py", line 134, in run
    return self({self.input_keys[0]: text})[self.output_keys[0]]
  File "/Users/ankushgola/Code/langchain/langchain/chains/base.py", line 107, in __call__
    outputs = self._call(inputs)
  File "/Users/ankushgola/Code/langchain/langchain/chains/llm_math/base.py", line 70, in _call
    raise ValueError(f"unknown format from LLM: {t}")
ValueError: unknown format from LLM: + 4
Answer: 23

Very interesting that the answer is actually correct. The problem is that the output from the calculator is:
 ' + 4
Answer: 23'

ValueError is being thrown bc output of Calculator doesn't being with 'Answer:'
Can repro with another input (also involving prime numbers):
agent.run("Who won the US Open men's tennis final in 2019? What is the next prime number after his age?")

In this case, the output from the calculator is
'?
Answer: 37'

Again, interesting that answer is actually correct.

same issue here

@agola11 @dreamteam-z i opened up the above pr for hopefully a simple fix


refactor discovery init sql

Make sure that:

[ ] You have read the contribution guidelines.
[ ] You submit test cases (unit or integration tests) that back your changes.
[ ] Your local test passed ./mvnw clean install -Dmaven.javadoc.skip=true.

Codecov Report

Merging #4685 (82fa30a) into master (49a3b60) will decrease coverage by 0.10%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #4685      +/-   ##
============================================
- Coverage     66.43%   66.33%   -0.10%
+ Complexity     8020     8007      -13
============================================
  Files          1109     1109
  Lines         32041    32029      -12
  Branches       2896     2892       -4
============================================
- Hits          21285    21245      -40
- Misses         9065     9093      +28
  Partials       1691     1691

see 19 files with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


systemd: build with cryptsetup support

Motivation for this change
When building systemd with cryptsetup support, it knows how to read /etc/crypttab (and generate on-the-fly units via cryptsetup-generator).
This previously wasn't possible due to a dependency cycle, (systemd -> cryptsetup -> lvm2 -> udev=systemd).
Weird things like systemd-cryptsetup-generator and systemd_with_lvm2 started popping up, which worked in some cases, but in a very unintuitive fashion.
We can simply solve the depencency cycle by passing to the systemd build a version of (lib)cryptsetup that was built with an lvm that was built without udev support. (Which should still work, given to how systemd uses libcryptsetup).
That way, we can slowly add native crypttab support into NixOS, working towards fixing things like https://github.com/NixOS/nixpkgs/issues/62211 in a more generic fashion.
This is still WIP, due to the move of udev to aliases.nix, missing changelog entries and me not having fully tested this. Feedback very welcome :-)
cc @d3rped @petabyteboy
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[ ] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Assured whether relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

I'm not yet sure about the move of udev to aliases.nix - there's a lot of packages currently using udev (and hopefully only things from the udev and libudev targets) - do we want to have a separate package for just udev and libudev?
Do we want to change occurences of {systemd}/bin/udevadm or {udev}/bin/udevadm to /run/current-system/systemd/bin/udevadm?

closing in favor of #66856.


Fixed post.md

@Laura-Novich-OBW @lsnovich
Changed Markdown tables to HTML format. Sorry for the delay.
link to google doc: https://docs.google.com/document/d/1huQUrdhuqfa6OV4PiTtyxLmAkAsTmhYhxITHAXvNJmg/edit?usp=sharing

nice change!


Update-Help https is not actually supported

Steps to reproduce
Import-Module -Name PowerShellGet
$Module = Get-Module -Name PowerShellGet
$Module.HelpInfoUri
Update-Help -Module PowerShellGet

Expected behavior
Update help files for PowerShellGet

Actual behavior
Update-Help : Failed to update Help for the module(s) :
'PowerShellGet'
The HelpInfoURI https://go.microsoft.com/fwlink/?linkid=855963 does not start with HTTP.
At line:1 char:1
+ Update-Help -Module PowerShellGet
+ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
+ CategoryInfo          : NotSpecified: (HelpInfoUri:Uri) [Update-Help], Exception
+ FullyQualifiedErrorId : InvalidHelpInfoUriFormat,Microsoft.PowerShell.Commands.UpdateHelpCommand

Environment data

Name                            Value
----                            -----
PSVersion                       5.1.14393.1944
PSEdition                       Desktop
PSCompatibleVersions            {1.0, 2.0, 3.0, 4.0...}
BuildVersion                    10.0.14393.1944
CLRVersion                      4.0.30319.42000
WSManStackVersion               3.0
PSRemotingProtocolVersion       2.3
SerializationVersion            <IP_ADDRESS>

Screenshoot

I ran into this issue with PowerShellGet as well. Following the URI redirects to https://pshelp.blob.core.windows.net/powershell/help/6/PowerShellGet/ which presents a BlobNotFound error. So I'm wondering whether the fact that the updateable help file doesn't exist is contributing to the error.

I just reproduced this as well in my open source module project (Armor) while working on setting up updatable help for both a HTTPS URL and a HTTP URL with a 301 redirect to HTTPS on PowerShell versions: 5.1.14393.2248 & 6.0.2.

@JhonnyTerminus,
Just a reminder! Windows PowerShell issues need to posted under UserVoice site (https://windowsserver.uservoice.com/forums/301869-powershell) as stated in the PowerShell Core landing page: https://github.com/PowerShell/PowerShell#windows-powershell-vs-powershell-core
Issues posted here are only directed to PowerShell Core and not Windows PowerShell, as they are handle by different teams.
Please repost this issue in UserVoice so the correct team can take action on it.
:)
I repo the steps on PowerShell Core 6.1.0-Preview.2 and it's working. No errors!
PS C:\Program Files\PowerShell\6-preview> $PSVersionTable

Name                           Value
----                           -----
PSVersion                      6.1.0-preview.2
PSEdition                      Core
GitCommitId                    v6.1.0-preview.2
OS                             Microsoft Windows 10.0.17686
Platform                       Win32NT
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0...}
PSRemotingProtocolVersion      2.3
SerializationVersion           <IP_ADDRESS>
WSManStackVersion              3.0

PS C:\Program Files\PowerShell\6-preview> Update-Help Powershellget
PS C:\Program Files\PowerShell\6-preview>
PS C:\Program Files\PowerShell\6-preview>

This issue can be close!
PS. And this issue seems corrected in latest RTM Windows 10 (> & Insider Build 17686)

@MaximoTrinidad Yeah I did not read that, seems a bit redundant but it's probably for centralized issue management,
Thanks :)

Fixed in latest PS closing


Disklessset v1.3

Add clone system.
Add create image from parameters file system.
Review display system.
Review questions system and menu.
Add info mode and debug mode command.

Perfect, many thanks.
I tested the tool and it worked well.
This is ok for me, thanks a lot for this massive work !! 😊
Merging.

Hello @pietersdavid ,
The cloning feature is looking good. But could you please tell me the rationale on changing the name of the executable (/usr/bin/disklessset -> /usr/bin/disklessset.py)?


Provide binutils_impl_linux-64

Checklist

[ ] Used a fork of the feedstock to propose changes
[ ] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[ ] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[ ] Ensured the license file is being packaged.

cc @mingwandroid

Hi! This is the friendly automated conda-forge-linting service.
I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.
Here's what I've got...
For recipe:

Failed to even lint the recipe, probably because of a conda-smithy bug :cry:. This likely indicates a problem in your meta.yaml, though. To get a traceback to help figure out what's going on, install conda-smithy and run conda smithy recipe-lint . from the recipe directory.

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@conda-forge-admin, rerender

Hi! This is the friendly automated conda-forge-webservice.
I tried to re-render for you but ran into some issues, please ping conda-forge/core for further assistance.

Thanks

@isuruf thank you!


Can't find an installed package in "Packages", have to search it in "Install"

I forgot to capture the mouse cursor, but I hope it's clear the package is installed.

What version of Atom are you using?

1.0.2

This issue was moved to atom/settings-view#591


feat: update FE to use new API

Important changes detected  (payment related code)

Found constant API_ENV in files app/containers/Vaults/saga.js (-    process.env.API_ENV === 'development' ||)
Found constant NODE_ENV in files app/containers/Vaults/saga.js (-    process.env.NODE_ENV === 'development')

cc @dudesahn, need to QA this...

sorting by name is not working. app/components/VaultHeader still using displayName

I think it would be good to have a detailed doc of the changes in the structure from the previous API, so we can check if some changes where missed in the app. Searching for 'displayName', noticed that app/containers/Vaults/MigrationBannerSvg still uses displayName.

Important changes detected  (payment related code)

Found constant API_ENV in files app/containers/Vaults/saga.js (-    process.env.API_ENV === 'development' ||)
Found constant NODE_ENV in files app/containers/Vaults/saga.js (-    process.env.NODE_ENV === 'development')


Update labels to pulmonary terms

Some pulmonary term labels are outdated and SMEs have requested to update them. The old label will be maintained as an exact synonym:

ID
Current label
New label

CL:0002062
type I pneumocyte
pulmonary alveolar type 1 cell

CL:0002063
type II pneumocyte
pulmonary alveolar type 2 cell

CL:4028006
alveolar type 2 fibroblast cell
adventitial fibroblast

Is there any other cell type that should be relabeled, @gpryhuber?

To do:

pneumocyte (CL:0000322)

[ ] Change pneumocyte label to 'pulmonary alveolar epithelial cell'
[ ] Update definition with references
[ ] Add pneumocyte as an exact synonym with a reference

type I pneumocyte

[ ] Change 'type I pneumocyte' label to 'pulmonary alveolar type 1 cell'
[ ] Update definition with references
[ ] Add ' type I pneumocyte' as an exact synonym with a reference

type II pneumocyte

[ ] Change 'type II pneumocyte' label to 'pulmonary alveolar type 2 cell'
[ ] Update definition with references
[ ] Add 'type II pneumocyte' as an exact synonym with a reference

[ ] Change 'alveolar type 2 fibroblast cell' label to 'adventitial fibroblast'
[ ] Update definition references
[ ] Add 'alveolar type 2 fibroblast cell' as an exact synonym with a reference

In answer to "The following ticket was https://urldefense.com/v3/__https://github.com/obophenotype/cell-ontology/issues/2169__; I am waiting feedback from @gpryhuber on 1. since there adventitial fibroblast in non alveolar location, if it would be acceptable the label 'alveolar adventitial fibroblast'
Reply: in reference to CL:4028006 - while I agree that there are "adventitial fibroblasts occuring in non-alveolar locations in the lung, currently we are not able to distinguish them well,  this term may change again as data resolution increases but currently the preference is CL:4028006 as adventitial fibroblast with synonyms "Alveolar Fibroblast 2 cells, matrix fibroblast 2, mesenchymal alveolar niche cell, MANC, type-2 associated stromal cell, TASC, alveolar type 2 fibroblast cell"
and 2. if there are any other cell types that should be relabeled. If the label is ok and there aren't any other terms that need to be relabeled, I will change them. Reply:  the other relabels are good to go.  We are actively working on the lung cell nomenclature project cross-consortium and other relabels may come up in next 6 months.

Please clarify my comment on CL:4028006 - requested term "adventitial fibroblasts" - quite clearly should   not   be "alveolar adventitial fibroblasts".  The cells being described are more proximal in location and less or not at all in alveoli, this is based on [Travaglini](doi: 10.1038/s41586-020-2922-4.) and more recent unpublished data.  I do suggest that since adventitial fibroblasts are likely to occur in other tissues as well, that we use "adventitial fibroblasts of lung" or "adventitial fibroblasts, pulmonary" Synonyms listed above still hold.  Thanks

Thank you for your comment! I agree that adventitial fibroblast are not restricted to alveolus. However, in CL, 'alveolar type 2 fibroblast cell' is part of alveolus. That means that all 'alveolar type 2 fibroblast cells' are part of the alveolus. We can model this in the ontology in two ways:

Add an 'adventitial fibroblast' (general for all airways), and a Subclass 'alveolar adventitial fibroblast'. The second one would be the one substituting 'alveolar type 2 fibroblast cells'.
Relabel 'alveolar type 2 fibroblast cells' to 'adventitial fibroblast'. Then I need to change the axiom to part of some airway, and add an axiom to alveolus of lung has part adventitial cell of lung.

Based on the current definition, I am inclined to the first option, as otherwise I am changing from a specific cell type to a broader one.


Loading Python Exported Model into TorchSharp

Discussed in https://github.com/dotnet/TorchSharp/discussions/585

Originally posted by jimquittenton April 27, 2022
Hi,
I'm new to TorchSharp and am having trouble loading a python trained ResNet18 model. I've been following this article: https://github.com/dotnet/TorchSharp/blob/main/docfx/articles/saveload.md and have exported my python model using the 'save_state_dict' function in this script: https://github.com/dotnet/TorchSharp/blob/main/src/Python/exportsd.py .
In TorchSharp I have copied the ResNet model from https://github.com/dotnet/TorchSharpExamples/blob/main/src/CSharp/Models/ResNet.cs and then call the following:
int numClasses = 3;
ResNet myModel = ResNet.ResNet18(numClasses);
myModel.to(DeviceType.CPU);
myModel.load(mPath);

The load() line throws an exception with message Mismatched module state names: the target modules does not have a submodule or buffer named 'conv1.weight'.
If I examine the state_dict from 'myModel' prior to load(), it contains entries like:
{[layers.conv2d-first.weight, {TorchSharp.Modules.Parameter}]}
{[layers.bnrm2d-first.weight, {TorchSharp.Modules.Parameter}]}
{[layers.bnrm2d-first.bias, {TorchSharp.Modules.Parameter}]}
{[layers.bnrm2d-first.running_mean, {TorchSharp.torch.Tensor}]}
{[layers.bnrm2d-first.running_var, {TorchSharp.torch.Tensor}]}
{[layers.bnrm2d-first.num_batches_tracked, {TorchSharp.torch.Tensor}]}
{[layers.blck-64-0.layers.blck-64-0-conv2d-1.weight, {TorchSharp.Modules.Parameter}]}
{[layers.blck-64-0.layers.blck-64-0-bnrm2d-1.weight, {TorchSharp.Modules.Parameter}]}
{[layers.blck-64-0.layers.blck-64-0-bnrm2d-1.bias, {TorchSharp.Modules.Parameter}]}

whereas the corresponding entries prior to saving from python are:
conv1.weight     torch.Size([64, 3, 7, 7])
bn1.weight       torch.Size([64])
bn1.bias         torch.Size([64])
bn1.running_mean         torch.Size([64])
bn1.running_var          torch.Size([64])
bn1.num_batches_tracked          torch.Size([])
layer1.0.conv1.weight    torch.Size([64, 64, 3, 3])
layer1.0.bn1.weight      torch.Size([64])
layer1.0.bn1.bias        torch.Size([64])

I tried amending the ResNet.cs code to reflect the python names, but could not get them to exactly match.
I also tried calling load() with strict=false myModel.load(mPath, false);. This seemed to get past the Mismatched names exception, but throws another exception with message Too many bytes in what should have been a 7 bit encoded Int32.
I've been struggling with this for a couple of days now so would really appreciate any help you guys could offer.
Thanks
Jim

@jimquittenton - see reply in the Discussion thread.

If you have the Python source code for the model, I'd love to take a look at it.
Niklas

Hi Niklas, the model is literally the off the shelf PyTorch ResNet18. All I have done is change the last layer to output 3 classes:
model = models.resnet18(pretrained=True)
num_ftrs = model.fc.in_features
model.fc = nn.Linear(in_features=num_ftrs, out_features=3, bias=True)
model = model.to(device)

From torchvision?

Sorry, yes from torchvision

Okay, thanks!
The naming of submodules can be overcome, but it will take some work to get it done. The examples code (not including the layer names) was based on:
https://github.com/kuangliu/pytorch-cifar/blob/master/models/resnet.py
and I don't know if there are any other differences between that and the torchvision version.
It would be a cool thing for someone (hint, hint...) to pick this up and fix it over in the dotnet/TorchSharpExamples repo.

@jimquittenton, I created an issue to track this in TorchSharpExamples. I will also create a new issue that generalizes the problem that you identified to all pre-loaded models in torchvision.

@jimquittenton -- just as a follow-up: I validated that the ResNet model in the examples is, indeed, simplified. There are a few things that are different, but the main one is the first Conv2d, before the residual layers. The kernel size and padding are different in the examples version. This is because the CIFAR data set is 32x32 images, which is too small to work with ResNet, which expects at least 224x224. If I change things to correspond to the torchvision version (I'll push a version that you can look at, then the weights load, which give me comfort...

@jimquittenton -- please take a look at PR #595 (draft PR).


Add examples for the documentation mapping

Is your feature request related to a problem? Please describe.
I'm always frustrated when uploading the documentation mappings, what is its format? Seems the text file cannot be scanned.
Describe the solution you'd like
Add examples on the documentation mappings, and how to import local files for fine-tuning.
Describe alternatives you've considered
N/A
Additional context
N/A

You should not be using documentation mappings to upload documents! Please use the + button at the top if that's what you intended to do.


Consider implementing paste-undo

While having given it more thought now, I still want to track this, and I think, iff at all, it's almost impossible to implement due to the side effects of what paste-action is doing.
Pasting clipboard
This is actually reading the system clipboard and writing it to the applications stdin (wrapped around bracketed paste VT sequences)
Undoing this action
I first thought it might be doable, as one could buffer the paste action and delay the actual paste operation until insert mode is activated again.
That however is only possible for trivial cases iff we also want to visualize the paste action by having it printed to the screen.
However, neither the printout is done by the terminal (unless ECHO flag is set on the PTY device, but then it's the kernel mandating this echo action) - nor can we "unread" the data that we have previously written to.
This becomes more complex (if to be visually ECHO'd) when newlines are implied.
The only viable solution maybe is ...
The only viable solution to that problem may be to not visualize the paste at the position where the cursor is, but to simply indicate the number of pastes pending in the indicator status line (which is always visible in normal mode!) and how many paste actions have been done.
This way, we could implement an undo-action and simply drop from the tail of the pending paste queue when a paste has to be undone.
The paste would then be flushed when moving back to insert mode (pressing i), which I think would not be too unintuitive.
I think such an option should probably be configurable because I believe some people might like it and some might not.
Visualization in the indicator status line
We could add a paste-pending indicator to it, some string like "PASTE PENDING: %d" with %d being a positive integer >= 1 indicating how often someone pasted something.
paste quantifier
Since one can paste more than once in one go, e.g. 5p, these 5 pastes should be undone with one single u.

Your "viable solution" suggestion is how I had conceptualised vi mode. I had assumed I was just editing a buffer and not sending anything to stdin straight away. I hadn't realised (probably because I hadn't copied a \n) that things were live. I think there are pros and cons of both systems. I think your viable solution would be nice sometimes but perhaps not that often so
I wouldn't prioritise it.
If you did do it, perhaps the buffer could be edited freely, not just with copy and paste - once you are editing the input buffer why restrict yourself? However while it sounds nice I probably wouldn't actually use the feature that much over just copy and paste so I wouldn't prioritise it particularly (unless others are keen) - certainly not over supporting more forms of yank (I often try e.g. yw, y$, ytx, yi" (though the last two might be from a plugin) and I am stretching my memory on how to quickly yank in the terminal without them - which is the common cause of me pasting something unexpected and wanting undo).

I'm still not sure if an editable input buffer is worth it but I just wanted to select some words in a column and paste them as command line arguments ala xargs. This would be something that would be nice to do in just a buffer edit mode - but of course I can just use xargs (and have).


using without ssh for non tech users

I know the whole point is to use SSH as the transport and auth.
I have users that are non techy, so was wondering if there is a middle ground of some sort.

Hi!  I would love chat ideas.  What specifically do you want these users to be able to do?


[KOGITO-9244] spec.platform.baseImage does not update the Dockerfile …

…base image

JIRA:

Description:

Please make sure that your PR meets the following requirements:

[x] You have read the contributions doc
[x] Pull Request title is properly formatted: KOGITO-XYZ Subject
[x] Pull Request title contains the target branch if not targeting main: [0.9.x] KOGITO-XYZ Subject
[x] The nav.adoc file has a link to this guide in the proper category
[x] The index.adoc file has a card to this guide in the proper category, with a meaningful description

How to backport a pull request to a different branch?

In order to automatically create a backporting pull request please add one or more labels having the following format backport-<branch-name>, where <branch-name> is the name of the branch where the pull request must be backported to (e.g., backport-7.67.x to backport the original PR to the 7.67.x branch).

NOTE: backporting is an action aiming to move a change (usually a commit) from a branch (usually the main one) to another one, which is generally referring to a still maintained release branch. Keeping it simple: it is about to move a specific change or a set of them from one branch to another.

Once the original pull request is successfully merged, the automated action will create one backporting pull request per each label (with the previous format) that has been added.
If something goes wrong, the author will be notified and at this point a manual backporting is needed.

NOTE: this automated backporting is triggered whenever a pull request on main branch is labeled or closed, but both conditions must be satisfied to get the new PR created.

Is this JIRA merged on 1.40.x branch on the operator's side?

we have https://github.com/kiegroup/kogito-serverless-operator/pull/186 but it will never be released as community

Is this JIRA merged on 1.40.x branch on the operator's side?

Nope (Backport PR on 1.40.x closed due to this)

@kaldesai I think that we can proceed with the merge.

@ricardozanini are we good with that one ?


rubyPackages.ovirt-engine-sdk: fix build on ruby 3.1 and higher

Description of changes
Include a patch merged but not released upstream.
ZHF: #230712
Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[x] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 233005 run on x86_64-linux 1

1 package marked as broken and skipped:

rubyPackages_2_7.ovirt-engine-sdk

3 packages built:

rubyPackages.ovirt-engine-sdk (rubyPackages_3_1.ovirt-engine-sdk)
rubyPackages_3_0.ovirt-engine-sdk
rubyPackages_3_2.ovirt-engine-sdk

Result of nixpkgs-review pr 233005 run on aarch64-darwin 1

1 package marked as broken and skipped:

rubyPackages_2_7.ovirt-engine-sdk

3 packages built:

rubyPackages.ovirt-engine-sdk (rubyPackages_3_1.ovirt-engine-sdk)
rubyPackages_3_0.ovirt-engine-sdk
rubyPackages_3_2.ovirt-engine-sdk

Result of nixpkgs-review pr 233005 run on x86_64-darwin 1

1 package marked as broken and skipped:

rubyPackages_2_7.ovirt-engine-sdk

3 packages built:

rubyPackages.ovirt-engine-sdk (rubyPackages_3_1.ovirt-engine-sdk)
rubyPackages_3_0.ovirt-engine-sdk
rubyPackages_3_2.ovirt-engine-sdk


Not able to open crashdump

Browser Error:
Bad things happened:
2018-03-27 12:00:14: minidump.cc:4693: ERROR: ReadBytes: read 4/32 2018-03-27 12:00:14: minidump.cc:4356: ERROR: Minidump cannot read header 2018-03-27 12:00:14: minidump_stackwalk.cc:87: ERROR: Minidump /tmp/tmp-3391B1NjaW540KhU.tmp could not be read
Backend Error:
Trace: Error: 2018-03-27 12:00:14: minidump.cc:4693: ERROR: ReadBytes: read 4/32
2018-03-27 12:00:14: minidump.cc:4356: ERROR: Minidump cannot read header
2018-03-27 12:00:14: minidump_stackwalk.cc:87: ERROR: Minidump /tmp/tmp-3391B1NjaW540KhU.tmp could not be read
at ChildProcess.<anonymous> (/home/skapadia/projects/simple-breakpad-server/node_modules/minidump/lib/minidump.js:41:25)
at emitTwo (events.js:106:13)
at ChildProcess.emit (events.js:191:7)
at maybeClose (internal/child_process.js:920:16)
at Socket.<anonymous> (internal/child_process.js:351:11)
at emitOne (events.js:96:13)
at Socket.emit (events.js:188:7)
at Pipe._handle.close [as _onclose] (net.js:497:12)

at /home/skapadia/projects/simple-breakpad-server/src/app.coffee:136:13
at Layer.handle_error (/home/skapadia/projects/simple-breakpad-server/node_modules/express/lib/router/layer.js:71:5)
at trim_prefix (/home/skapadia/projects/simple-breakpad-server/node_modules/express/lib/router/index.js:315:13)
at /home/skapadia/projects/simple-breakpad-server/node_modules/express/lib/router/index.js:284:7
at Function.process_params (/home/skapadia/projects/simple-breakpad-server/node_modules/express/lib/router/index.js:335:12)
at next (/home/skapadia/projects/simple-breakpad-server/node_modules/express/lib/router/index.js:275:10)
at /home/skapadia/projects/simple-breakpad-server/node_modules/express/lib/application.js:233:9
at /home/skapadia/projects/simple-breakpad-server/node_modules/express/lib/router/index.js:635:15
at next (/home/skapadia/projects/simple-breakpad-server/node_modules/express/lib/router/index.js:260:14)
at Layer.handle_error (/home/skapadia/projects/simple-breakpad-server/node_modules/express/lib/router/layer.js:67:12)
at trim_prefix (/home/skapadia/projects/simple-breakpad-server/node_modules/express/lib/router/index.js:315:13)
at /home/skapadia/projects/simple-breakpad-server/node_modules/express/lib/router/index.js:284:7
at Function.process_params (/home/skapadia/projects/simple-breakpad-server/node_modules/express/lib/router/index.js:335:12)
at next (/home/skapadia/projects/simple-breakpad-server/node_modules/express/lib/router/index.js:275:10)
at next (/home/skapadia/projects/simple-breakpad-server/node_modules/express/lib/router/route.js:127:14)
at /home/skapadia/projects/simple-breakpad-server/src/app.coffee:300:16
at /home/skapadia/projects/simple-breakpad-server/src/model/crashreport.coffee:61:7
at ChildProcess.<anonymous> (/home/skapadia/projects/simple-breakpad-server/node_modules/minidump/lib/minidump.js:41:7)
at emitTwo (events.js:106:13)
at ChildProcess.emit (events.js:191:7)
at maybeClose (internal/child_process.js:920:16)
at Socket.<anonymous> (internal/child_process.js:351:11)
at emitOne (events.js:96:13)
at Socket.emit (events.js:188:7)
at Pipe._handle.close [as _onclose] (net.js:497:12)

Forgot to specify parameter name "upload_file_minidump" while uploading file


fix error with nD markers

Description
This PR fixes an indexing error that occurred when adding a new marker to a viewer that contained both 2D and 3D layers. It also allows markers to be added outside the current image bounds and at non-integer locations. The PR makes the markers layer more independent of other layers by removing a call to the viewer.dims.max_shape
Type of change

[x] Bug-fix (non-breaking change which fixes an issue)

How has this been tested?

[x] Tested with the examples scripts includingadd_markers.py and nD_markers.py

Final checklist:

[x] My PR is the minimum possible work for the desired functionality
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] I have added tests that prove my fix is effective or that my feature works

@sofroniewn this PR broke examples/annotate-2d.py, can you investigate? Thanks!


More Sorting algos?

Do you think it would be ok to include more sorting algorithms? At least the common ones like Bubble Sort, Insertion Sort, Merge Sort, Quick Sort, Heap Sort, Counting Sort, Radix Sort?

Not really. Those are already widely spread and well knows. This repo is focussed on applications of those fundamental algorithms and practical projects. :smile:


TypeError: Cannot read property 'flag' of undefined

I get this error after upgrading to version 1.0.0. The utils parameter is empty...what should it be? I find no sign of it in the documentation.
module.exports = function(chai, utils) {

how do you use this plugin?
like this? chai.use(chaiSubset);?
we have general test, that says that this plugin works)

Found it out after an hour it was because i used it like:
require('chai-subset')(chai);


jobsGeneral.labels not specified in template (bug)

We missed it in the template. that's why this part doesn't work.
https://github.com/nixys/nxs-universal-chart/blob/main/templates/job.yml
apiVersion: batch/v1
kind: Job
metadata:
  name: {{ $jobName }}
  namespace: {{ $.Release.Namespace | quote }}
  labels:
    {{- include "helpers.app.labels" $ | nindent 4 }}
    # missed general.labels
    {{- with .labels }}{{- include "helpers.tplvalues.render" (dict "value" . "context" $) | nindent 4 }}{{- end }}

Hello! Thank you for noting this. I will add missing general labels in the next patch in the upcoming week.

Hello, fixed in 2.7.0


Support parameter expressions in the ANY expression without type hints

Parameter expressions inside ANY didn't work with postgres based clients
that do not send type hints. (asyncpg, pgx, ... etc)
A statement like
SELECT * FROM t WHERE x = ANY(?)

would fail with the following error:
invalid array expression: '$1'

No changes entry because such clients weren't supported in 2.2 and earlier due to the lack of the ParameterDescription. So this issue only surfaces to the user in master.

Codecov Report

Merging #6623 into master will decrease coverage by 0.16%.
The diff coverage is 100%.

@@             Coverage Diff              @@
##             master    #6623      +/-   ##
============================================
- Coverage     83.18%   83.01%   -0.17%
+ Complexity    13385    13361      -24
============================================
  Files          1522     1522
  Lines         49649    49653       +4
  Branches       5929     5931       +2
============================================
- Hits          41299    41220      -79
- Misses         5545     5615      +70
- Partials       2805     2818      +13

Impacted Files
Coverage Δ
Complexity Δ

.../crate/analyze/expressions/ExpressionAnalyzer.java
90.37% <100%> (+0.09%)
33 <0> (ø)
:arrow_down:

...n/java/io/crate/exceptions/JobKilledException.java
0% <0%> (-66.67%)
0% <0%> (-1%)

...java/io/crate/operation/user/AlterUserRequest.java
47.36% <0%> (-42.11%)
5% <0%> (-2%)

...ration/aggregation/statistics/moment/Variance.java
66.66% <0%> (-33.34%)
5% <0%> (-2%)

...ion/aggregation/impl/GeometricMeanAggregation.java
59.09% <0%> (-21.22%)
11% <0%> (ø)

...io/crate/protocols/postgres/types/VarCharType.java
70.83% <0%> (-20.84%)
9% <0%> (-1%)

...a/io/crate/exceptions/ContextMissingException.java
81.81% <0%> (-18.19%)
1% <0%> (-1%)

...o/crate/analyze/SafeExpressionToStringVisitor.java
83.33% <0%> (-16.67%)
7% <0%> (-1%)

...peration/aggregation/impl/VarianceAggregation.java
64.7% <0%> (-15.69%)
11% <0%> (ø)

...aggregation/impl/StandardDeviationAggregation.java
64.7% <0%> (-15.69%)
11% <0%> (ø)

... and 43 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fc1787b...5380963. Read the comment docs.

@mxm good call. Pushed a fixup where I removed the custom validation altogether from the ExpressionAnalyzer.
I'm not 100% happy with the error message, as it might be a bit confusing. Though I guess it's ok.
Maybe we could add a Supplier<ConversionException> or something like that to the Params class to be able to customize the error message?


feat : Lint Commit Messages Workflow using Commitlint GitHub Action ✨

Description
I propose adding a new workflow called "Lint Commit Messages." This workflow will be triggered on pull requests and pushes to help maintain proper commit message formatting and adherence to the Conventional Commits guideline. To achieve this, we will utilize the "Commitlint GitHub Action" provided by the "wagoid/commitlint-github-action" repository.
Proposed Workflow:
name: Lint Commit Messages
on: [pull_request, push]

jobs:
  commitlint:
    runs-on: ubuntu-latest
    steps:
      - uses: actions/checkout@v2
        with:
          fetch-depth: 0
      - name: Lint Commit Messages
        uses: wagoid/commitlint-github-action@v4

What it does
The "Lint Commit Messages" workflow employs the "Commitlint GitHub Action" to automatically check the commit messages in each pull request and push event. The action parses commit messages against the Conventional Commits specification and verifies whether they follow the required format. If a commit message does not adhere to the defined rules, the action will raise a warning or failure, depending on the severity of the violation.
By introducing this workflow, we aim to encourage contributors to write meaningful, well-structured commit messages, promoting collaboration and easing the review process.
When it occurs:
The "Lint Commit Messages" workflow is triggered on the following events:

pull_request: Whenever a new pull request is opened or an existing one is updated.
push: Whenever code is pushed to any branch in the repository.

First finish the previous issues , then I will assign this to you 👍


AmpGen rename

Several bits of code have AmpGen in the title. They should be renamed, since someone does not need to know about or use AmpGen to use DecayLanguage. Here are the current names:

Name
Suggested replacement

ampgen2goofit.py

AmpGen2GooFit

Particle.from_AmpGen

AmplitudeChain.read_ampgen
.read_file

BTW, AmpGen is certainly an important package for decaylanguage users, for actual modelling work. A link and basic info in AmpGen in the README file would be useful.

AmpGen can be related to inputs or outputs of the package. In that sense, having an explicit mention of the back-/front-end is not a bad thing in my opinion. so read_ampgen is not bad, since explicit. read_file would only make sense if the tool is 100% connected to the back-/front-end as for example when reading or writing ROOT files with ROOT code.
ampgen2goofit.py in decaylanguage/decay/  seems to make more sense as a package script. Same thing for goofit.py. I would suggest to move these to a scripts/ top-level directory. It does require a bit of a rewriting of these 2 files.
BTW, they both seriously need some documentation in ;-).
Since we are talking about AmpGen and GooFit, anyway: there is also a second goofit.py file under decaylanguage/decay/. This one file lack doc too but more importantly seems specific enough to be put in a dedicated goofit module or even an io module if that makes sense to you.


Installation error on Intel Mac

Environment:
rustc 1.64.0-beta.3 (82bf34178 2022-08-18)
Foundation" "-framework" "CoreGraphics" "-framework" "CoreFoundation" "-lSystem" "-lobjc" "-liconv" "-lSystem" "-lresolv" "-lc" "-lm" "-liconv" "-L" "/Users/user/.rustup/toolchains/beta-x86_64-apple-darwin/lib/rustlib/x86_64-apple-darwin/lib" "-o" "/var/folders/vx/_5fgc0ps1_s46k0jyf4fw2w5gn8nsx/T/cargo-install9koPEX/release/deps/simp-a748a72e178cf392" "-Wl,-dead_strip" "-nodefaultlibs"
  = note: Undefined symbols for architecture x86_64:
            "_VP8LDspInitSSE41", referenced from:
                _VP8LDspInit in liblibwebp_sys-2554bdf03a6f8d6b.rlib(lossless.o)
          ld: symbol(s) not found for architecture x86_64
          clang: error: linker command failed with exit code 1 (use -v to see invocation)

Install command
cargo install simp

Use the --locked flag otherwise cargo will select a broken version of libwebp2.

The real fix is forking libwebp2 and fixing the problem upstream.

You might have been aware already but running cargo install simp (without the --locked) on my m1 mac just worked without any errors.


Add missing linking with jemalloc

Insignificant
Refs: https://github.com/yandex/ClickHouse/pull/6878#discussion_r324606073

Cc: @amosbird

I cannot reproduce the linking error in https://github.com/yandex/ClickHouse/pull/6878#discussion_r324606073 using yandex/clickhouse-deb-builder

I cannot reproduce the linking error you mentioned in https://github.com/yandex/ClickHouse/pull/6878#discussion_r324606073 with yandex/clickhouse-deb-builder. And I don't think libjemalloc.a should not be linked here.
docker run -it --rm -v /home/amos/git/chorigin/:/build  yandex/clickhouse-deb-builder bash

mkdir -p /build/build-dev
cd /build/build-dev

cmake .. -DCMAKE_INSTALL_PREFIX=/usr -DCMAKE_VERBOSE_MAKEFILE=ON -DCMAKE_BUILD_TYPE=Release -DCMAKE_INSTALL_SYSCONFDIR=/etc -DCMAKE_INSTALL_LOCALSTATEDIR=/var -DUSE_STATIC_LIBR
ARIES=0 -DSPLIT_SHARED_LIBRARIES=1 -DCLICKHOUSE_SPLIT_BINARY=1 -DUNBUNDLED=1 -DCMAKE_CXX_COMPILER=/usr/bin
/g\+\+-9 -DCMAKE_C_COMPILER=/usr/bin/gcc-9 -GNinja

ninja

You cannot reproduce it using yandex/clickhouse-deb-builder, because it has jemalloc<4, and hence sdallocx is not used in libs/libcommon/include/common/memory.h

@azat but we have jemalloc 5.1.0 in contrib and bundled build links fine

Bundled build uses static jemalloc library, hence no problems (dbms/libclickhouse_common_io linked with libs/libcommon/libcommon, which in case of static jemalloc has sdallocx in it, otherwise it is just linked with jemalloc)

So you use bundled build with libjemalloc.so, interesting combination. I think the cmake condition should be tightened. Have you checked if it breaks bundled shared build? (in which the static jemalloc library will be linked twice in this pr)

So you use bundled build with libjemalloc.so, interesting combination

I don't, I use UNBUNDLED (because otherwise compilation time is too huge).
And actually it is not possible to build ch in this way without patching cmake (since jemalloc-cmake/CMakeLists.txt has add_library(jemalloc STATIC).
So let me summarize this:

I use UNBUNDLED+SPLIT+SHARED (-DUSE_STATIC_LIBRARIES=OFF -DCLICKHOUSE_SPLIT_BINARY=ON -DSPLIT_SHARED_LIBRARIES=ON -DUNBUNDLED=ON)
And in this case jemalloc will be used from system, which in is shared in my case
When you tried to build ch the same as I'm doing it, you had jemalloc<4, and in this case sdallocx will not be used in libs/libcommon/include/common/memory.h, hence you did not get any errors, IOW if you will libjemalloc-dev in that container to 4+ you will the same error as I

@amosbird does the above clarify anything?
The only issue with this patch is what if system-wide jemalloc is static, in this case we will link with jemalloc twice (I will update the patch), and this is not great AFAIU.

Yes, I understand what you're doing and why you got that linking error. As long as this pr doesn't break any current CI builds, I'm fine with it.


Bump FastAPI / starlette dependencies to fix CVE

The current versions have a CVE opened against them due to their python-multipart dependency https://nvd.nist.gov/vuln/detail/CVE-2024-24762
Obviously this isn't technically a problem for sqlmesh since it's not expected to sitting directly on the intertubes, but this is triggering static analysis tools and is good hygiene in general.

Thanks for reporting this. Looks like FastAPI updated the minimum version of python-multipart to 0.0.7 in their 0.109.1 release. I've pinned SQLMesh UI to 0.110.2.


feat: Use the safer API for window handles

Builds on rust-windowing/raw-window-handle#110, rust-windowing/raw-window-handle#115 and rust-windowing/winit#2744 to see how the new safe raw window API does ergonomically.

Ported to rust-windowing/raw-window-handle#116

Superseded by #132


TSAN DartAPI_New failure

https://dart-ci.appspot.com/log/vm-kernel-tsan-linux-release-x64/dartk-tsan-linux-release-x64/1665/vm/cc/DartAPI_New
--- Command "run_vm_unittest" (took 10.000242s):
DART_CONFIGURATION=ReleaseTSANX64 out/ReleaseTSANX64/run_vm_tests --dfe=/b/s/w/ir/out/ReleaseTSANX64/gen/kernel-service.dart.snapshot --ignore-unrecognized-flags DartAPI_New

exit code:
255

stdout:
Running test: DartAPI_New
Done: DartAPI_New

stderr:
../../runtime/vm/dart_api_impl_test.cc: 5666: error: expected 'type' to be a valid handle but found an error handle:
    'Compilation failed /test-lib:15:35: Error: The constructor function type 'MyClass Function(dynamic)' isn't a subtype of 'MyExtraHop Function(dynamic)'.
 - 'MyClass' is from '/test-lib'.
 - 'MyExtraHop' is from '/test-lib'.
  factory MyExtraHop.hop(value) = MyClass.named;
                                  ^
/test-lib:19:38: Error: The constructor function type 'MyExtraHop Function(dynamic)' isn't a subtype of 'MyInterface Function(dynamic)'.
 - 'MyExtraHop' is from '/test-lib'.
 - 'MyInterface' is from '/test-lib'.
  factory MyInterface.named(value) = MyExtraHop.hop;
                                     ^
/test-lib:20:41: Error: The constructor function type 'MyClass Function(dynamic)' isn't a subtype of 'MyInterface Function(dynamic)'.
 - 'MyClass' is from '/test-lib'.
 - 'MyInterface' is from '/test-lib'.
  factory MyInterface.multiply(value) = MyClass.multiply;

[...]

--- Re-run this test:
python3 tools/test.py -n dartk-tsan-linux-release-x64 vm/cc/DartAPI_New

Commit range [dart2js] Migrate Setlet to NNBD...Remove a few tests from the bottom of checker_test.
Suspect commit would be https://github.com/dart-lang/sdk/commit/89996356b58566264d7411ab15b2dec47ca7997d, it is the only VM change (cc @crelier).
However, it does not fail on any of the other bots, only the TSAN bot.
Started happening at the same time as https://github.com/dart-lang/sdk/issues/46121#issuecomment-847695402.

This test has been failing in all the configurations and we have an issue tracking this already (https://github.com/dart-lang/sdk/issues/33041). It is possible in TSAN mode we were seeing some flaky crashes which got fixed and now we consistently get runtime errors.


[App Crash] App Closes on Offline Tech Search

When an offline tech search is conducted the app crashes. This does not occur when another type of search is carried out offline.

Problem was caused by Canada Computers Search. Errors would produce for all classes when an offline search was made however, Canada Computers caused a Fatal Exception, crashing the app.
if(r != null){
       results = r.select(" tr.productListing-odd");
       resultsEven = r.select(" tr.productListing-even");
       //Add the "even" product listings to results array
       for(int j = 0; j <resultsEven.size();j++){
            results.add(resultsEven.get(j));
       }
      System.out.println(results.size() + " Results have been returned from CanadaComputers.");
      return results;
      }
      else {
           return null;
}

The problem was solved by adding a few lines of code that made it so when the website couldn't be reached it returned null elements, preventing it from crashing the app.


Introduce and use COMPILER_IS_MSVC

Simplifies the areas we check for MSVC specific behaviour.
I've extracted this out to a new file Compiler.h, as I'll add more compiler specific definitions, such as for deleted delete operator and the trailing objects bugs

@jckarter FYI, this is the start of implementing your suggestion

@swift-ci Please smoke test

Please change the name to SWIFT_COMPILER_IS_MSVC or similar. Preprocessor macros should be namespaced.

Sorry, updated in #6837


SSL CERT Decoder

What improvement do you think would an existing feature or tool in DevToys?
ii think it would be cool to have an SSL CERT Decoder.
Solution/Idea
Not really a solution i have to recommended, but the functionality to decode several cert types.
Comments
No response

@cooperfdiv FYI https://github.com/veler/DevToys/pull/803


Add a wiki: Lethal Company wiki

Link to origin wiki: https://lethal-company.fandom.com/wiki/Lethal_Company_Wiki
Link to destination (independent) wiki: https://lethal.miraheze.org/wiki/Main_Page

Added in https://github.com/KevinPayravi/indie-wiki-buddy/pull/367 by @Werefawkes

Thank you for the submission! Added in v3.2.0 (now available on Chrome, and should be available on Firefox within a few days after review).


slide setting is not working

The 'slide' setting is not working for me. I have several picture elements which I want to be part of the slideshow but also another element (an anchor tag) that is not to be part of the slideshow so it needs to be ignored. I've given each of the picture elements a class of 'image-slide' but it doesn't seem to find this at all when I specify slide: '.image-slide' in the settings and the slideshow does not work at all. If I do not specify a slide setting, then the slideshow works but it includes that anchor tag as one of the slides.
I am using the latest version of Chrome on Windows 10, version 1.8.1 of slick.js and version 3.2.1 of jquery. I thought it did work before but don't know when or what version.
My HTML:
`

 Tagline about company

Another tagline about company

`
My JS:
$('.home-banner').slick({     arrows: false,     infinite: true,     autoplay: true,     autoplaySpeed: 6000,     dots: true,     pauseOnHover: false,     speed: 1000,     fade: true,     slide: '.image-slide'   })

I'm sorry I am trying to put my code in there surrounded by `` but it's not working. Help?

See https://github.com/kenwheeler/slick/commit/be0d17cc858fb30e6a4d6b28cc29860c7170040d#commitcomment-26043461
May be related to this change


Unknown props wrapperStyle, parent ...etc

This is a clean started project from this repository. Don't really know where to start.

Ah, noticed now that the bug belongs to https://github.com/KyleAMathews/react-headroom/pull/87

This is a new warning that's part of React 15.2.0. This particular warning needs fixed in React Headroom. There's an issue created for it already and I'll be fixing it soon https://github.com/KyleAMathews/react-headroom/issues/86.
In the meantime, there's actually nothing wrong atm, the React maintainers just added the warning as in the next major release, these extra props will cause errors.

ah, good find :-)


Can download app.json file from http, and OpenFin developer menu

Issue #327
Electron already has a -d/--developer option for whether to show the Developer menu. Added a similar option for allowing the OpenFin context menu.
Also added the ability to download the app.json file from http or https

The last commit fixes two failing tests that were broken when the -d option was originally added to Electron, which happened in this commit: https://github.com/symphonyoss/ContainerJS/commit/bdeab1f634c013fde189d163dc1eec54bf9d2217


Omnisharp intellisense not working, timeout

Environment data
dotnet --info output:
.NET Command Line Tools (2.1.4)

Product Information:
 Version:            2.1.4
 Commit SHA-1 hash:  5e8add2190

Runtime Environment:
 OS Name:     Windows
 OS Version:  10.0.16299
 OS Platform: Windows
 RID:         win10-x64
 Base Path:   C:\Program Files\dotnet\sdk\2.1.4\

Microsoft .NET Core Shared Framework Host

  Version  : 2.0.5
  Build    : 17373eb129b3b05aa18ece963f8795d65ef8ea54

VS Code version:
version 1.19
C# Extension version:
1.13.0
Steps to reproduce
Install visual studio code
Install c# plugin
Create any c# project
Try anything to do with the intellisense.
Expected  behavior
when accessing properties of a class with:
public class test{
public string mystring {get;set;}
}
public string getString(){
test testobj = new test();
return testobj.mystring;
}

I expect it to suggest the part "mystring" after putting the . after testobj.
Actual behavior
Doesn't react on the '.' at all. If i use ctrl+space it gets a timeout from omnisharp.

Closing out as this doesn't reproduce and there was no additional info given.


Add plugin to OSRS HD

Hi as mentioned above can this plugin please bea added to osrs hd as its so much better!

That is not a question for me, but a question for the HDOS devs and whether they care to port the plugin or not.


How will this server handle concurrent writes?

How will this server handle concurrent writes?

Seams that json server do nothing handle with concurrency.
I tried post 2 objects at same time, but only got one saved.


=str Make use of TrieMap instead of List to reduce contention.

Was: https://github.com/akka/akka/pull/31262/
refs: https://github.com/akka/akka/issues/29557
Use an ConcurrentMap as set to trace the contention in onFeedbackDispatched

Is it possible to provide jmh benchmarks to show the difference?

@mdedetrich I think this is a bug fix not a performance optimization, I can switch to ConcurrentHashMap i you like.

Ah I see, I will get @jrudolph to review this since he made the original issue.

After read the paper of TrieMap, I think I need to change it back to ConcurrentHashMap

@pjfanning I have updated it.

Yes, this was originally a performance improvement. Regardless of that fact, let's not just merge changes in performance critical code without running benchmarks or discussing arguments why they can be omitted.
It has been a long time since I worked on this / proposed the change (almost 3 years... oh my). I guess in this case, it's fine, it seems after all they ran some benchmarks in Akka to validate it does not introduce obvious performance regressions.

I'm a bit confused as to the use of AtomicReference[mutable.Map] instead of just plain mutable.Map.

The comment at its declaration explains it. There's a race condition between scheduling an async callback (i.e. an incoming external event into the stream) and shutting down a stream. The atomic reference makes sure, that we will report feedback to the async callback reliably even if it raced against shutdown (this is basically what this whole feature is about).


Output cannot be formatted to table - when listing objects and using --query

Hello, I'm working with webapps, vms, and other objects throguh CLI,
I am able to query those objects, rename columns, etc,
but when I use --query - I am unable to eventually display the output as table.
I have followed this documentation page - https://docs.microsoft.com/en-us/cli/azure/query-azure-cli?view=azure-cli-latest step by step.
Describe the bug
I am running those commands, for example:

az vm list -g {} --query {}
az webapp list -g {} --query {}

Works just fine - returns the expected json result.
But when I run them with -o table at the end, like this:

az vm list -g {} --query {} -o table
az webapp list -g {} --query {} -o table

Error is thrown:
Table output unavailable. Use the --query option to specify an appropriate query. Use --debug for more info.
To Reproduce
Run commands such as:

az vm list -g {} --query {}
az webapp list -g {} --query {}
Validate that those are working.

Then, run those commands again with -o table at the end of the line.
Environment summary
Windows-10-10.0.18362-SP0
Python 3.6.6
Installer: MSI
Extensions:
interactive 0.4.4
Update (8/4/20, 10:30) update: Tried on two other windows 10 workstations with differenet cli version and issue is reproduced just the same.
Additional context

I am using interactive mode.
I updated both azure-cli and interactive mode 10 mintues ago, and it didn't help.
Issue reproduced and error just the same in azure cloud shell.
In addition, I would like to let you know that I googled the issue and saw few github posts in which the issue have already been reported. I did not find any appropriate solution in any of those posts.
Update (8/4/20, 10:30):  This issue has been opened 3 days ago - https://github.com/Azure/azure-cli/issues/14615.
In my intuition, according to the similarity of the issues it really seems like the problem is not client-specific, nor version-specific, and not object-specific.

hi @fengzhou-msft could you pls have a look?

I am not able to reproduce it. The result is correct.
> az vm list -g ubuntu-rg --query [].name --output table
Result
-------------
my-ubuntu

Would you mind sharing the actual commands you used? (Provide the contents of {} in the commands.)

I am not able to reproduce it. The result is correct.
> az vm list -g ubuntu-rg --query [].name --output table
Result
-------------
my-ubuntu

Would you mind sharing the actual commands you used? (Provide the contents of {} in the commands.)

Hey, please take a look at these two examples:

I see you are using interactive. Unfortunately, currently interactive doesn't work with --output table. You may use the normal CLI to execute those commands.
Thanks for your understanding.

Thank you for this comment.
I would like to point out that the error "Table output unavailable. Use the --query option to specify..."
Is extremely confusing, and it sure does not say that this feature is simply unavailable in interactive mode.
Should I open another bug about it? or open a feature request?

@Shahar-do, thanks for the feedback. However, az interactive is not being actively maintained. We would recommend always using the normal az commands.


optimize memory usage when creating log.html?

I noticed robot/rebot can use multiple Gigabytes of memory when rendering log.html from complex/long output.xml. We noticed this in a container environment where we cap memory consumption to 4GB, and noticed some robot suite execution being killed by the OS.  The output.xml in question contained more than 1.8 million keyword executions!!!).
I have no idea on the feasibility/effort of this ask, but it would be great if we could explore options to reduce memory footprint for this task.. We have already recommended keyword flattening to our user base
It is not a high-priority item, but would be good to review optimization areas when it comes to memory footprint..

First of all, have you tested using --splitlog? It ought to make loading the log file a lot faster, but opening individual tests and keywords should still work well.
The log.html is highly optimized in terms of file size, but I'm certain there would be room for memory and performance optimization. The problem is that we are planning to rewrite the whole thing in the somewhat near future (#4304) and trying to enhance the current log file doesn't make much sense. If someone has knowledge about profiling this kind of JavaScript and HMTL code, it would be great if they could take a quick look are there some easy wins. Anyone interested? If not, I believe it's best to close this issue and concentrate on the new tech instead.

Thanks, @pekkaklarck
Just to be sure: this issue is not about loading the logfile (this is fast).  It is robot/rebot creating it which takes that much memory.

I see. I thought "rendering" referred to viewing the lig file in a browser.
Creating the log file has been profiled quite a bit and I'm afraid there are no easy wins. That said, would you be interested to profile where memory goes in your exact case? I've used https://pypi.org/project/filprofiler few times and it has worked great.

Have you @oboehmer investigated this further? Just the peak memory usage doesn't tell much, we needed to know where the memory is spend. The Fil profiler I mentioned above could help with that.
Typically huge memory usage is related to having log of keywords, loop iterations, or other such constructs in output.xml. Handling them can be optimized in Robot, but typically a better solution is having less constructs like that. This can mean moving logic from resource files to libraries, making sure looping controls (e.g. WHILE) don't loop unnecessarily iterations (or moving the to libraries), and so on. On Robot data level something that can work really well is "flattening" using either --flattenkeywords or the newer robot:flatten tag. The latter is more powerful because it flattens content already during execution.


Cannot start extraterm

I tried 3 "different" versions all with the same error. extraterm-bin, the latest release from github 0.49.1 (which should be identical to the AUR package which only copies binaries) and I also tired the latest nightly build.
I don't get a new window but the process keeps running. Any ideas?
./extraterm
2020-03-10 17:32:41.223 INFO [MainConfig #0] Looking for application_paths.json at '/home/syphdias/Downloads/extraterm-build/extraterm-0.49.1-9-g18d1d7e0-linux-x64/application_paths.json'
2020-03-10 17:32:41.225 INFO [main #0] Recording logs to  /home/syphdias/.config/extraterm/extraterm.log
2020-03-10 17:32:41.227 INFO [MainExtensionManager #0] Read extension metadata from 'audio-viewer'.
2020-03-10 17:32:41.228 INFO [MainExtensionManager #0] Read extension metadata from 'community-syntax-themes'.
2020-03-10 17:32:41.228 INFO [MainExtensionManager #0] Read extension metadata from 'community-terminal-themes'.
2020-03-10 17:32:41.228 INFO [MainExtensionManager #0] Read extension metadata from 'default-keybindings'.
2020-03-10 17:32:41.229 INFO [MainExtensionManager #0] Read extension metadata from 'default-syntax-theme'.
2020-03-10 17:32:41.229 INFO [MainExtensionManager #0] Read extension metadata from 'default-terminal-theme'.
2020-03-10 17:32:41.230 INFO [MainExtensionManager #0] Read extension metadata from 'find'.
2020-03-10 17:32:41.230 INFO [MainExtensionManager #0] Read extension metadata from 'itermcolors-terminal-theme-provider'.
2020-03-10 17:32:41.231 INFO [MainExtensionManager #0] Read extension metadata from 'inject-shell-integration'.
2020-03-10 17:32:41.241 INFO [MainExtensionManager #0] Read extension metadata from 'internal-commands'.
2020-03-10 17:32:41.243 INFO [MainExtensionManager #0] Read extension metadata from 'proxy-session-backend'.
2020-03-10 17:32:41.244 INFO [MainExtensionManager #0] Read extension metadata from 'proxy-session-editor'.
2020-03-10 17:32:41.244 INFO [MainExtensionManager #0] Read extension metadata from 'terminal-title'.
2020-03-10 17:32:41.244 INFO [MainExtensionManager #0] Read extension metadata from 'textmate-syntax-theme-provider'.
2020-03-10 17:32:41.244 INFO [MainExtensionManager #0] Read extension metadata from 'text-viewer-options'.
2020-03-10 17:32:41.245 INFO [MainExtensionManager #0] Read extension metadata from 'unix-session-backend'.
2020-03-10 17:32:41.245 INFO [MainExtensionManager #0] Read extension metadata from 'unix-session-editor'.
2020-03-10 17:32:41.245 INFO [MainExtensionManager #0] Read extension metadata from 'windows-console-session-backend'.
2020-03-10 17:32:41.246 INFO [MainExtensionManager #0] Read extension metadata from 'windows-console-session-editor'.
2020-03-10 17:32:41.246 INFO [MainExtensionManager #0] Starting extension 'community-syntax-themes' in the main process.
2020-03-10 17:32:41.246 INFO [MainExtensionManager #0] Starting extension 'community-terminal-themes' in the main process.
2020-03-10 17:32:41.246 INFO [MainExtensionManager #0] Starting extension 'default-syntax-theme' in the main process.
2020-03-10 17:32:41.246 INFO [MainExtensionManager #0] Starting extension 'default-terminal-theme' in the main process.
2020-03-10 17:32:41.246 INFO [MainExtensionManager #0] Starting extension 'itermcolors-terminal-theme-provider' in the main process.
2020-03-10 17:32:41.254 DEBUG [[Main]itermcolors-terminal-theme-provider #0] ITermColorTerminalThemeProvider activating
2020-03-10 17:32:41.254 INFO [MainExtensionManager #0] Starting extension 'textmate-syntax-theme-provider' in the main process.
2020-03-10 17:32:41.255 DEBUG [[Main]textmate-syntax-theme-provider #0] TextMateSyntaxThemeProvider activating
2020-03-10 17:32:41.255 INFO [MainExtensionManager #0] Starting extension 'unix-session-backend' in the main process.
2020-03-10 17:32:41.258 DEBUG [KeybindingsIOManager #0] {filename: Mac OS X bindings.json, path: /home/syphdias/Downloads/extraterm-build/extraterm-0.49.1-9-g18d1d7e0-linux-x64/resources/app/extensions/DefaultKeybindings/keybindings, name: Mac OS X bindings}
2020-03-10 17:32:41.258 DEBUG [KeybindingsIOManager #0] {filename: Mac OS X with emacs bindings.json, path: /home/syphdias/Downloads/extraterm-build/extraterm-0.49.1-9-g18d1d7e0-linux-x64/resources/app/extensions/DefaultKeybindings/keybindings, name: Mac OS X with emacs bindings}
2020-03-10 17:32:41.258 DEBUG [KeybindingsIOManager #0] {filename: PC style bindings.json, path: /home/syphdias/Downloads/extraterm-build/extraterm-0.49.1-9-g18d1d7e0-linux-x64/resources/app/extensions/DefaultKeybindings/keybindings, name: PC style bindings}
2020-03-10 17:32:41.258 DEBUG [KeybindingsIOManager #0] {filename: PC with emacs style bindings.json, path: /home/syphdias/Downloads/extraterm-build/extraterm-0.49.1-9-g18d1d7e0-linux-x64/resources/app/extensions/DefaultKeybindings/keybindings, name: PC with emacs style bindings}
A JavaScript error occurred in the main process
Uncaught Exception:
Error: Command failed: /home/syphdias/Downloads/extraterm-build/extraterm-0.49.1-9-g18d1d7e0-linux-x64/resources/app/extraterm/resources/list-fonts-json-binary/linux-x64/list-fonts-json
    at checkExecSyncError (child_process.js:636:11)
    at Object.execFileSync (child_process.js:654:15)
    at Object.func [as execFileSync] (electron/js2c/asar.js:155:31)
    at Object.getAvailableFontsSync (/home/syphdias/Downloads/extraterm-build/extraterm-0.49.1-9-g18d1d7e0-linux-x64/resources/app/extraterm/src/main_process/FontList.js:16:40)
    at getFonts (/home/syphdias/Downloads/extraterm-build/extraterm-0.49.1-9-g18d1d7e0-linux-x64/resources/app/extraterm/src/main_process/Main.js:529:42)
    at main (/home/syphdias/Downloads/extraterm-build/extraterm-0.49.1-9-g18d1d7e0-linux-x64/resources/app/extraterm/src/main_process/Main.js:103:22)
    at Object.<anonymous> (/home/syphdias/Downloads/extraterm-build/extraterm-0.49.1-9-g18d1d7e0-linux-x64/resources/app/extraterm/src/main_process/Main.js:997:1)
    at Module._compile (internal/modules/cjs/loader.js:839:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:851:10)
    at Module.load (internal/modules/cjs/loader.js:701:32)

Distro and kernel:
Description:	Manjaro Linux
Release:	19.0.2
Codename:	Kyria
Kernel:		5.5.7-1-MANJARO

Note sure if important:
node --version
v13.9.0

It is most likely a problem on the packaging side. Talk to person who packaged this.
In the mean time you can also try the Linux download from Github here.

As mentioned I tried 3 different versions. Only one of them from a "package". The other two were straight from github and the latest nightly build. I'll try older versions if they have the same problem.

I tried every version on github from v0.42.0 to v0.49.1. None worked.
❯ for i in extraterm-*; do recho $i; timeout 1s ${i}/extraterm |tail -14; done
extraterm-0.42.0-linux-x64
A JavaScript error occurred in the main process
Uncaught Exception:
SyntaxError: Unexpected token  in JSON at position 4907
    at JSON.parse (<anonymous>)
    at Object.getAvailableFontsSync (/home/syphdias/Downloads/extraterm-build/extraterm-0.42.0-linux-x64/resources/app/extraterm/src/main_process/FontList.js:17:22)
    at getFonts (/home/syphdias/Downloads/extraterm-build/extraterm-0.42.0-linux-x64/resources/app/extraterm/src/main_process/Main.js:484:42)
    at main (/home/syphdias/Downloads/extraterm-build/extraterm-0.42.0-linux-x64/resources/app/extraterm/src/main_process/Main.js:94:111)
    at Object.<anonymous> (/home/syphdias/Downloads/extraterm-build/extraterm-0.42.0-linux-x64/resources/app/extraterm/src/main_process/Main.js:939:1)
    at Object.<anonymous> (/home/syphdias/Downloads/extraterm-build/extraterm-0.42.0-linux-x64/resources/app/extraterm/src/main_process/Main.js:941:3)
    at Module._compile (internal/modules/cjs/loader.js:693:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:704:10)
    at Module.load (internal/modules/cjs/loader.js:602:32)
    at tryModuleLoad (internal/modules/cjs/loader.js:541:12)
extraterm-0.42.1-linux-x64
A JavaScript error occurred in the main process
Uncaught Exception:
SyntaxError: Unexpected token  in JSON at position 4907
    at JSON.parse (<anonymous>)
    at Object.getAvailableFontsSync (/home/syphdias/Downloads/extraterm-build/extraterm-0.42.1-linux-x64/resources/app/extraterm/src/main_process/FontList.js:17:22)
    at getFonts (/home/syphdias/Downloads/extraterm-build/extraterm-0.42.1-linux-x64/resources/app/extraterm/src/main_process/Main.js:484:42)
    at main (/home/syphdias/Downloads/extraterm-build/extraterm-0.42.1-linux-x64/resources/app/extraterm/src/main_process/Main.js:94:111)
    at Object.<anonymous> (/home/syphdias/Downloads/extraterm-build/extraterm-0.42.1-linux-x64/resources/app/extraterm/src/main_process/Main.js:939:1)
    at Object.<anonymous> (/home/syphdias/Downloads/extraterm-build/extraterm-0.42.1-linux-x64/resources/app/extraterm/src/main_process/Main.js:941:3)
    at Module._compile (internal/modules/cjs/loader.js:693:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:704:10)
    at Module.load (internal/modules/cjs/loader.js:602:32)
    at tryModuleLoad (internal/modules/cjs/loader.js:541:12)
extraterm-0.42.2-linux-x64
A JavaScript error occurred in the main process
Uncaught Exception:
SyntaxError: Unexpected token  in JSON at position 4907
    at JSON.parse (<anonymous>)
    at Object.getAvailableFontsSync (/home/syphdias/Downloads/extraterm-build/extraterm-0.42.2-linux-x64/resources/app/extraterm/src/main_process/FontList.js:17:22)
    at getFonts (/home/syphdias/Downloads/extraterm-build/extraterm-0.42.2-linux-x64/resources/app/extraterm/src/main_process/Main.js:484:42)
    at main (/home/syphdias/Downloads/extraterm-build/extraterm-0.42.2-linux-x64/resources/app/extraterm/src/main_process/Main.js:94:111)
    at Object.<anonymous> (/home/syphdias/Downloads/extraterm-build/extraterm-0.42.2-linux-x64/resources/app/extraterm/src/main_process/Main.js:939:1)
    at Object.<anonymous> (/home/syphdias/Downloads/extraterm-build/extraterm-0.42.2-linux-x64/resources/app/extraterm/src/main_process/Main.js:941:3)
    at Module._compile (internal/modules/cjs/loader.js:693:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:704:10)
    at Module.load (internal/modules/cjs/loader.js:602:32)
    at tryModuleLoad (internal/modules/cjs/loader.js:541:12)
extraterm-0.43.0-linux-x64
A JavaScript error occurred in the main process
Uncaught Exception:
SyntaxError: Unexpected token  in JSON at position 4907
    at JSON.parse (<anonymous>)
    at Object.getAvailableFontsSync (/home/syphdias/Downloads/extraterm-build/extraterm-0.43.0-linux-x64/resources/app/extraterm/src/main_process/FontList.js:17:22)
    at getFonts (/home/syphdias/Downloads/extraterm-build/extraterm-0.43.0-linux-x64/resources/app/extraterm/src/main_process/Main.js:486:42)
    at main (/home/syphdias/Downloads/extraterm-build/extraterm-0.43.0-linux-x64/resources/app/extraterm/src/main_process/Main.js:93:111)
    at Object.<anonymous> (/home/syphdias/Downloads/extraterm-build/extraterm-0.43.0-linux-x64/resources/app/extraterm/src/main_process/Main.js:952:1)
    at Module._compile (internal/modules/cjs/loader.js:815:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:827:10)
    at Module.load (internal/modules/cjs/loader.js:677:32)
    at tryModuleLoad (internal/modules/cjs/loader.js:609:12)
    at Function.Module._load (internal/modules/cjs/loader.js:601:3)
extraterm-0.44.0-linux-x64
A JavaScript error occurred in the main process
Uncaught Exception:
Error: Command failed: /home/syphdias/Downloads/extraterm-build/extraterm-0.44.0-linux-x64/resources/app/extraterm/resources/list-fonts-json-binary/linux-x64/list-fonts-json
    at checkExecSyncError (child_process.js:636:11)
    at Object.execFileSync (child_process.js:654:15)
    at Object.func [as execFileSync] (electron/js2c/asar.js:155:31)
    at Object.getAvailableFontsSync (/home/syphdias/Downloads/extraterm-build/extraterm-0.44.0-linux-x64/resources/app/extraterm/src/main_process/FontList.js:16:40)
    at getFonts (/home/syphdias/Downloads/extraterm-build/extraterm-0.44.0-linux-x64/resources/app/extraterm/src/main_process/Main.js:485:42)
    at main (/home/syphdias/Downloads/extraterm-build/extraterm-0.44.0-linux-x64/resources/app/extraterm/src/main_process/Main.js:93:111)
    at Object.<anonymous> (/home/syphdias/Downloads/extraterm-build/extraterm-0.44.0-linux-x64/resources/app/extraterm/src/main_process/Main.js:951:1)
    at Module._compile (internal/modules/cjs/loader.js:815:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:827:10)
    at Module.load (internal/modules/cjs/loader.js:677:32)
extraterm-0.44.1-linux-x64
A JavaScript error occurred in the main process
Uncaught Exception:
Error: Command failed: /home/syphdias/Downloads/extraterm-build/extraterm-0.44.1-linux-x64/resources/app/extraterm/resources/list-fonts-json-binary/linux-x64/list-fonts-json
    at checkExecSyncError (child_process.js:636:11)
    at Object.execFileSync (child_process.js:654:15)
    at Object.func [as execFileSync] (electron/js2c/asar.js:155:31)
    at Object.getAvailableFontsSync (/home/syphdias/Downloads/extraterm-build/extraterm-0.44.1-linux-x64/resources/app/extraterm/src/main_process/FontList.js:16:40)
    at getFonts (/home/syphdias/Downloads/extraterm-build/extraterm-0.44.1-linux-x64/resources/app/extraterm/src/main_process/Main.js:485:42)
    at main (/home/syphdias/Downloads/extraterm-build/extraterm-0.44.1-linux-x64/resources/app/extraterm/src/main_process/Main.js:93:111)
    at Object.<anonymous> (/home/syphdias/Downloads/extraterm-build/extraterm-0.44.1-linux-x64/resources/app/extraterm/src/main_process/Main.js:951:1)
    at Module._compile (internal/modules/cjs/loader.js:815:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:827:10)
    at Module.load (internal/modules/cjs/loader.js:677:32)
extraterm-0.45.0-linux-x64
A JavaScript error occurred in the main process
Uncaught Exception:
Error: Command failed: /home/syphdias/Downloads/extraterm-build/extraterm-0.45.0-linux-x64/resources/app/extraterm/resources/list-fonts-json-binary/linux-x64/list-fonts-json
    at checkExecSyncError (child_process.js:636:11)
    at Object.execFileSync (child_process.js:654:15)
    at Object.func [as execFileSync] (electron/js2c/asar.js:155:31)
    at Object.getAvailableFontsSync (/home/syphdias/Downloads/extraterm-build/extraterm-0.45.0-linux-x64/resources/app/extraterm/src/main_process/FontList.js:16:40)
    at getFonts (/home/syphdias/Downloads/extraterm-build/extraterm-0.45.0-linux-x64/resources/app/extraterm/src/main_process/Main.js:485:42)
    at main (/home/syphdias/Downloads/extraterm-build/extraterm-0.45.0-linux-x64/resources/app/extraterm/src/main_process/Main.js:93:111)
    at Object.<anonymous> (/home/syphdias/Downloads/extraterm-build/extraterm-0.45.0-linux-x64/resources/app/extraterm/src/main_process/Main.js:951:1)
    at Module._compile (internal/modules/cjs/loader.js:815:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:827:10)
    at Module.load (internal/modules/cjs/loader.js:677:32)
extraterm-0.46.0-linux-x64
A JavaScript error occurred in the main process
Uncaught Exception:
Error: Command failed: /home/syphdias/Downloads/extraterm-build/extraterm-0.46.0-linux-x64/resources/app/extraterm/resources/list-fonts-json-binary/linux-x64/list-fonts-json
    at checkExecSyncError (child_process.js:636:11)
    at Object.execFileSync (child_process.js:654:15)
    at Object.func [as execFileSync] (electron/js2c/asar.js:155:31)
    at Object.getAvailableFontsSync (/home/syphdias/Downloads/extraterm-build/extraterm-0.46.0-linux-x64/resources/app/extraterm/src/main_process/FontList.js:16:40)
    at getFonts (/home/syphdias/Downloads/extraterm-build/extraterm-0.46.0-linux-x64/resources/app/extraterm/src/main_process/Main.js:485:42)
    at main (/home/syphdias/Downloads/extraterm-build/extraterm-0.46.0-linux-x64/resources/app/extraterm/src/main_process/Main.js:93:120)
    at Object.<anonymous> (/home/syphdias/Downloads/extraterm-build/extraterm-0.46.0-linux-x64/resources/app/extraterm/src/main_process/Main.js:951:1)
    at Module._compile (internal/modules/cjs/loader.js:815:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:827:10)
    at Module.load (internal/modules/cjs/loader.js:677:32)
extraterm-0.47.0-linux-x64
A JavaScript error occurred in the main process
Uncaught Exception:
Error: Command failed: /home/syphdias/Downloads/extraterm-build/extraterm-0.47.0-linux-x64/resources/app/extraterm/resources/list-fonts-json-binary/linux-x64/list-fonts-json
    at checkExecSyncError (child_process.js:636:11)
    at Object.execFileSync (child_process.js:654:15)
    at Object.func [as execFileSync] (electron/js2c/asar.js:155:31)
    at Object.getAvailableFontsSync (/home/syphdias/Downloads/extraterm-build/extraterm-0.47.0-linux-x64/resources/app/extraterm/src/main_process/FontList.js:16:40)
    at getFonts (/home/syphdias/Downloads/extraterm-build/extraterm-0.47.0-linux-x64/resources/app/extraterm/src/main_process/Main.js:522:42)
    at main (/home/syphdias/Downloads/extraterm-build/extraterm-0.47.0-linux-x64/resources/app/extraterm/src/main_process/Main.js:102:120)
    at Object.<anonymous> (/home/syphdias/Downloads/extraterm-build/extraterm-0.47.0-linux-x64/resources/app/extraterm/src/main_process/Main.js:990:1)
    at Module._compile (internal/modules/cjs/loader.js:839:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:851:10)
    at Module.load (internal/modules/cjs/loader.js:701:32)
extraterm-0.49.0-linux-x64
A JavaScript error occurred in the main process
Uncaught Exception:
Error: Command failed: /home/syphdias/Downloads/extraterm-build/extraterm-0.49.0-linux-x64/resources/app/extraterm/resources/list-fonts-json-binary/linux-x64/list-fonts-json
    at checkExecSyncError (child_process.js:636:11)
    at Object.execFileSync (child_process.js:654:15)
    at Object.func [as execFileSync] (electron/js2c/asar.js:155:31)
    at Object.getAvailableFontsSync (/home/syphdias/Downloads/extraterm-build/extraterm-0.49.0-linux-x64/resources/app/extraterm/src/main_process/FontList.js:16:40)
    at getFonts (/home/syphdias/Downloads/extraterm-build/extraterm-0.49.0-linux-x64/resources/app/extraterm/src/main_process/Main.js:529:42)
    at main (/home/syphdias/Downloads/extraterm-build/extraterm-0.49.0-linux-x64/resources/app/extraterm/src/main_process/Main.js:103:22)
    at Object.<anonymous> (/home/syphdias/Downloads/extraterm-build/extraterm-0.49.0-linux-x64/resources/app/extraterm/src/main_process/Main.js:997:1)
    at Module._compile (internal/modules/cjs/loader.js:839:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:851:10)
    at Module.load (internal/modules/cjs/loader.js:701:32)
extraterm-0.49.1-9-g18d1d7e0-linux-x64
A JavaScript error occurred in the main process
Uncaught Exception:
Error: Command failed: /home/syphdias/Downloads/extraterm-build/extraterm-0.49.1-9-g18d1d7e0-linux-x64/resources/app/extraterm/resources/list-fonts-json-binary/linux-x64/list-fonts-json
    at checkExecSyncError (child_process.js:636:11)
    at Object.execFileSync (child_process.js:654:15)
    at Object.func [as execFileSync] (electron/js2c/asar.js:155:31)
    at Object.getAvailableFontsSync (/home/syphdias/Downloads/extraterm-build/extraterm-0.49.1-9-g18d1d7e0-linux-x64/resources/app/extraterm/src/main_process/FontList.js:16:40)
    at getFonts (/home/syphdias/Downloads/extraterm-build/extraterm-0.49.1-9-g18d1d7e0-linux-x64/resources/app/extraterm/src/main_process/Main.js:529:42)
    at main (/home/syphdias/Downloads/extraterm-build/extraterm-0.49.1-9-g18d1d7e0-linux-x64/resources/app/extraterm/src/main_process/Main.js:103:22)
    at Object.<anonymous> (/home/syphdias/Downloads/extraterm-build/extraterm-0.49.1-9-g18d1d7e0-linux-x64/resources/app/extraterm/src/main_process/Main.js:997:1)
    at Module._compile (internal/modules/cjs/loader.js:839:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:851:10)
    at Module.load (internal/modules/cjs/loader.js:701:32)
extraterm-0.49.1-linux-x64
A JavaScript error occurred in the main process
Uncaught Exception:
Error: Command failed: /home/syphdias/Downloads/extraterm-build/extraterm-0.49.1-linux-x64/resources/app/extraterm/resources/list-fonts-json-binary/linux-x64/list-fonts-json
    at checkExecSyncError (child_process.js:636:11)
    at Object.execFileSync (child_process.js:654:15)
    at Object.func [as execFileSync] (electron/js2c/asar.js:155:31)
    at Object.getAvailableFontsSync (/home/syphdias/Downloads/extraterm-build/extraterm-0.49.1-linux-x64/resources/app/extraterm/src/main_process/FontList.js:16:40)
    at getFonts (/home/syphdias/Downloads/extraterm-build/extraterm-0.49.1-linux-x64/resources/app/extraterm/src/main_process/Main.js:529:42)
    at main (/home/syphdias/Downloads/extraterm-build/extraterm-0.49.1-linux-x64/resources/app/extraterm/src/main_process/Main.js:103:22)
    at Object.<anonymous> (/home/syphdias/Downloads/extraterm-build/extraterm-0.49.1-linux-x64/resources/app/extraterm/src/main_process/Main.js:997:1)
    at Module._compile (internal/modules/cjs/loader.js:839:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:851:10)
    at Module.load (internal/modules/cjs/loader.js:701:32)

❯ /home/syphdias/Downloads/extraterm-build/extraterm-0.49.1-9-g18d1d7e0-linux-x64/resources/app/extraterm/resources/list-fonts-json-binary/linux-x64/list-fonts-json
[1]    19458 segmentation fault (core dumped)

Apparently there was an update to another (font related) package a few hours ago. Apparently this fixed the font issue :man_shrugging:


Add Profile: Sambit-Mondal

Profile Submission
https://github.com/user-attachments/assets/4a2b2f38-f378-4996-8702-d2f972a7eab9
Profile Category
Please select one or more categories for your profile:

[ ] Badge 🎖
[ ] Minimalistic ✨
[x] Dynamic 🔄
[x] Icons 🎯
[ ] Backgrounds 😎
[x] GIFS 🖼
[ ] Game Mode 🚀
[ ] Code 👨💻

Next Steps
Once you've filled out the information, please comment below:
@all-contributors please add @<username> for review

@Sambit-Mondal Please review my profile.

@all-contributors please add @Sambit-Mondal for review

@all-contributors please add @Sambit-Mondal for review


Remove legacy beta/stable builder configs

Release branches have been using same builder configs as main branch, but using branched recipes. All legacy beta and stable builder configs should be removed from infra/config.

@keyonghan do we have an assignee for this issue?

Not for now. I guess most fixit bugs in the pool are missing an assignee now, but it means anyone from the team could grab and work on it in the coming two weeks.

https://flutter-review.googlesource.com/c/infra/+/46640 completes this.


transform the exports

          In my case I need transform the exports

export * from "./classes/Client.ts";
export * from "./classes/User.ts";

to
export * from "./classes/Client.js";
export * from "./classes/User.js";

but doesn't works, only with imports
And I observe that the imports with * like import * from './x.ts' doesn't work too
Any sugestion?
my .swcrc
{
  "exclude": "node_modules/",
  "jsc": {
    "parser": {
      "syntax": "typescript",
      "topLevelAwait": true
    },
    "target": "esnext",
    "baseUrl": ".",
    "experimental": {
      "plugins": [
        [
          "@swc/plugin-transform-imports",
          {
          "^(.*?)(\\.ts)$": {
              "skipDefaultConversion": true,
              "transform": "{{matches.[1]}}.js"
            }
          }
        ]
      ]
    }
  },
  "module": {
    "type": "nodenext"
  }
}

Originally posted by @eliyya in https://github.com/swc-project/plugins/issues/47#issuecomment-1894934298

First, I really appreciate your awesome efforts on SWC @kdy1, you're amazing!
I subscribed to this and am very eager to use it, but I guess there's a problem (or maybe I'm missing something):
My index.ts file:
export { address } from './address.ts';

Complied file:
"use strict";
Object.defineProperty(exports, "__esModule", {
    value: true
});
function _export(target, all) {
    for(var name in all)Object.defineProperty(target, name, {
        enumerable: true,
        get: all[name]
    });
}
_export(exports, {
    address: function() {
        return _address.address;
    }
});
var _address = require("./address.js");

This is working fine, but when I use:
export * from './address.ts';

Complied file:
"use strict";
Object.defineProperty(exports, "__esModule", {
    value: true
});
_export_star(require("./address.ts"), exports);
function _export_star(from, to) {
    Object.keys(from).forEach(function(k) {
        if (k !== "default" && !Object.prototype.hasOwnProperty.call(to, k)) {
            Object.defineProperty(to, k, {
                enumerable: true,
                get: function() {
                    return from[k];
                }
            });
        }
    });
    return from;
}

As you can see, the .ts remains in _export_star
My .swcrc:
{
  "$schema": "https://json.schemastore.org/swcrc",

  "jsc": {
    "parser": {
      "syntax": "typescript",
      "tsx": false,
      "decorators": false,
      "dynamicImport": false
    },
    "target": "es5",
    "loose": true,
    "experimental": {
      "cacheRoot": ".cache/swc",
      "plugins": [
        [
          "@swc/plugin-transform-imports",
          {
            "^(.*?)(\\.ts)$": {
              "transform": "{{matches.[1]}}.js",
              "skipDefaultConversion": true
            }
          }
        ]
      ]
    },
    "preserveAllComments": false,
    "minify": {
      "compress": false,
      "mangle": false
    }
  },
  "module": {
    "type": "commonjs"
  },
  "minify": false
}

The implemented fix doesn't work for star exports without extensions
export * from "./classes/Client";
export * from "./classes/User";

↓↓↓
export * from "./classes/Client";
export * from "./classes/User";

export {Client} from "./classes/Client";
export {User} from "./classes/User";

↓↓↓
export {Client} from "./classes/Client.js";
export {User} from "./classes/User.js";


"restler_custom_payload..." parameter options in dict.json

I have made some confusion to myself about "restler_custom_payload_" parameters that are available for dict.json.
Could you please explain what is the difference between restler_custom_payload and restler_custom_payload_query?
The query parameters are same as body parameters, are they not?
Also their difference with:
restler_custom_payload_uuid4_suffix?

restler_custom_payload are for request body parameters.
restler_custom_payload_query are similar but for the query part of REST API requests.
restler_custom_payload_uuid4_suffix can be used to specify a constant value to which will be appended a randomly-generated suffix.

Hello @mbiuki,
restler_custom_payload_query - will only be used for query parameter substitution (PUT /api?query_param1=x&query_param2=y).  If the parameter is not declared in the spec, it will be injected.
restler_custom_payload_header - will only be used for request header parameter substitution.  If the parameter is not declared in the spec, it will be injected.
restler_custom_payload - will be used to substitute any parameter or property with that name, whether in the path, query, header, or body.  The difference from the above two others is that this is only a replacement, no extra parameters can be injected via this construct.
As you can see, there is no restler_custom_payload_path or restler_custom_payload_body where the replacement would have to be made only in the path or only in the body.  (Not present because we have not seen these use cases yet.)
Thanks,
Marina

So if I have path parameters like /agent/{agentId}/settings/{agentKey}, you'd suggest that I add their UUID in restler_custom_payload?
How does the injection work? Does it count toward max_combinations?

It depends.  If 'agentId' or 'agentKey' are constants that must be specified by the user, and the 'agent' and 'key' are not created by the API, then yes restler_custom_payload is needed to assign values to them.  If these are created by the API (e.g. with PUT /agent), then there is no need to specify the constant since RESTler can create a new one and assign these via producer-consumer dependencies.

For all grammar elements that refer to the dictionary (custom payloads, fuzzables), if there is more than one value defined in the dictionary, then yes several combinations are tested and this "counts" toward max_combinations.  e.g. if you test two different API versions by using restler_custom_payload_query("api-version"), this will cause twice the number of combinations as if you only test the one version.

How about the header parameters:
      parameters:
        - name: X-Work-ID
          in: header
          description: Work ID.
          required: true
          schema:
            type: string
            format: uuid

I think these would definitely need to be specified by restler_custom_payload_header as there could be no way by RESTLer to infer them?

RESTler will soon support inferring dependencies for headers as well.  Is this work ID created by another PUT/POST in the API?

No, it must be given beforehand or taken from a different API (e.g., GET https://api.test.com/getmyworkid/v2). Although I am not sure how inference may be possible, this would be a great add-on to the fuzzing service and would help a lot with autonomy.
The exact UUID of the X-Work-ID must be sent in the header of a GET/PUT/DELETE to have the request work o.w. the server will issue a 401 response.
https://github.com/microsoft/restler-fuzzer/issues/353#issuecomment-931670597 was very related to the problem I am facing as described in #348.

Ok - yes, for now you should specify the custom payload for X-Work-ID in the dictionary and recompile to have the custom payload added to the grammar.
Dependencies w/ a completely different API, correct (w/ a different host are not supported yet, related issue #334 that was opened recently would enable this (this is not on our near-term road map).

I'll take a closer look and reply separately on #348.