Playback failed One or more items failed to play

Hi, i was looking for some help with this issue
I can't use elementum anymore. For a while when I make a search, it scraps the torrents, I choose one of the list, it shows "resolving magnet" and then the message "Playback failed. One or more items failed to play". Thanks
Expected Behavior

The torrents should start to buffer and eventually play

Current Behavior

It seems that elementum fails resolving the magnet and then it shows the message "Playback failed. One or more items failed to play"

Steps to Reproduce (for bugs)

Make a search in elementum
Choose a torrent from the list

Context

Your Environment

Version used:

 0.1.64

Environment name and version:

Kodi 18.9

Operating System and version:

CoreElec 9.2.5

Link to Kodi debug log:

https://paste.kodi.tv/ireyebiman

@borisantelo To resolve magnet links you need working DHT. You log says it is enabled, so I don't know why it can't be resolved. Unless, you chose magnets with few seeders, so you just can't find them.
You can try to increase magnet timeout in elementum settings.

@borisantelo To resolve magnet links you need working DHT. You log says it is enabled, so I don't know why it can't be resolved. Unless, you chose magnets with few seeders, so you just can't find them.
You can try to increase magnet timeout in elementum settings.

Hi elgatito, thanks for answering. Yes, I've tried before increasing magnet timeout with the same result. I've tried popular torrents with lot of seeders also the same (the torrents works normally in a PC with utorrent). I've tried adding manually the magnet, this way it shows the downloading window, but never start downloading, it stays in 0 MB. Could be something with the operating system? A year ago worked normally, I don't know there's some problem with an update.

I have downgraded to the Coreelec and elementum versions that worked last year and it shows the same message (playback failed) this time, it didn't work

@borisantelo If your magnet got found and then you see that it's not downloading - it can be network issue.
I don't know what to advise, if previous versions worked fine and now it does not work - then it's not caused by Elementum.

@borisantelo If your magnet got found and then you see that it's not downloading - it can be network issue.
I don't know what to advise, if previous versions worked fine and now it does not work - then it's not caused by Elementum.

I think the magnet are not found, they get stuck in resolving magnet message and then the playback failed message. I don't think it's a network issue either. I've downloaded using the same network and the same torrent in a PC with utorrent. The only way it shows the downloading windows is adding a torrent file manually. But like I've said before it never start downloading, it stays in 0 MB. The weird thing is not even downgrading versions works. Well, if anybody had a similar problem and solved it, please let me know. Thanks

I don't know if it has some importance for this issue in order to understand if it's a bug in elementum or not, but I tried quasar and it worked with the same torrents. Again, this is not a criticism it's just because @elgatito suggested it could be a dht problem or something about the network, and maybe this fact helps in some way.

@borisantelo you have a lot of errors saying your DNS cannot resolve names when your coreelec boots up. Try changing settings to  load Kodi after network is ready.
If Quasar works for you - I'd stay with it.
Elementum is not doing any downloads, it is done by libtorrent library.

@borisantelo you have a lot of errors saying your DNS cannot resolve names when your coreelec boots up. Try changing settings to load Kodi after network is ready.
I did this, I chose a 60 seconds maximum time of waiting, but nothing changed.

I've been looking in internet for similar cases, on reddit I found this solution for a similar problem:
"
I had the same problem and while looking through the settings found some built-in proxy and DNS settings which I guess aren't being maintained any more by the developer. I turned them off, rebooted, and everything started working again.
In the Elementum Menu > Settings > Proxy tab, Internal HTTP proxy section I disabled "Use internal DNS resolver" and "Enable built-in HTTP proxy". In the Proxy section I disabled "Enabled".
In the Elementum Menu > Settings for Elementum Burst provider > General tab I disabled "Proxy HTTP requests with Elementum".
Then I rebooted and searching and adding torrents worked again
"
It wasn't the solution either. But I was wonder if somebody with more knowledge of the matter could tell if I'm going any near of the right way. @elgatito said it has something to do with the DNS maybe, what else could I do about it?

I've been looking in internet for similar cases, on reddit I found this solution for a similar problem

It is totally different.
Set logging level to DEBUG in Elementum settings. Add torent (not magnet) and show log file then.

@elgatito thanks for answering, I did what you told and these are the two kind of logs, I don't know which is more useful
http://paste.kodi.tv/ocuwikiqaf
http://paste.kodi.tv/elipufajez
As I've said before when I add torrent files it shows the downloading window but never starts to download, It stays O B/s until  no matter how much time you stay waiting. I've proved these two torrent files in utorrent and they have peers and seeds so they're able to download.
Hope it helps for a solution. Thanks

@borisantelo can't see anything helpful. You still have not fixed your issue with DNS.

@elgatito thanks for answering. A question, if there would have some issue with the DNS, Quasar would have the same problem, wouldn't it? Cause it works, like I've said before. But I also tried changing the DNS to public, using Google DNS and others, but there's no change. Still can't resolve the magnets

@borisantelo Again and again. It looks like your system does not have internet when Kodi starts.
Coreelec has a setting to start Kodi only when network is started.
Elementum starts faster than Quasar, so it might not have network at the moment it starts.

@borisantelo Again and again. It looks like your system does not have internet when Kodi starts.
Coreelec has a setting to start Kodi only when network is started.
Elementum starts faster than Quasar, so it might not have network at the moment it starts.

@elgatito thanks for replying.
I've already posted that I did what you suggest but it didn't work. Here:
https://github.com/elgatito/plugin.video.elementum/issues/661#issuecomment-752295608
I've changed to 60 seconds the time of waiting for the network but nothing changed.

Hi @elgatito, sorry for bother you again, but  I found this previous post https://github.com/elgatito/plugin.video.elementum/issues/150#issue-318675548
Maybe it has something to do
There's the same error on that log "NEWADDON Unknown Video Info Key "dbtype"" as the one my logs and the same bahavior can't play torrents.
Could it be something with Coreelec? But like I've said I've downgraded Coreelec to a version I recall elementum worked fine, from a clean install, but nothing changed.

Hi @elgatito, sorry for bother you again, but  I found this previous post https://github.com/elgatito/plugin.video.elementum/issues/150#issue-318675548
Maybe it has something to do
There's the same error on that log "NEWADDON Unknown Video Info Key "dbtype"" as the one my logs and the same bahavior can't play torrents.
Could it be something with Coreelec? But like I've said I've downgraded Coreelec to a version I recall elementum worked fine, from a clean install, but nothing changed.

I have to add that I tried on a libreelec operating system with the same results.

I have to add that I tried on a libreelec operating system with the same results.

@borisantelo

There's the same error on that log "NEWADDON Unknown Video Info Key "dbtype"" as the one my logs and the same bahavior can't play torrents.

No, not affecting anything.
I have asked you to enable libtorrent debug (Elementum settings, Bittorrent tab, if I recall it right) and make a new log. But cannot find that message now. It will show more information what happens in libtorrent.

@borisantelo

There's the same error on that log "NEWADDON Unknown Video Info Key "dbtype"" as the one my logs and the same bahavior can't play torrents.

No, not affecting anything.
I have asked you to enable libtorrent debug (Elementum settings, Bittorrent tab, if I recall it right) and make a new log. But cannot find that message now. It will show more information what happens in libtorrent.

I think this is: https://github.com/elgatito/plugin.video.elementum/issues/661#issuecomment-752359490
That is with torrent files, as you asked that time
I have this other two logs
http://paste.kodi.tv/adetejagok This is the log I got about the resolving magnets issue.
http://paste.kodi.tv/ejetujemak This is another log adding a torrent file
Hope it helps

I think this is: https://github.com/elgatito/plugin.video.elementum/issues/661#issuecomment-752359490
That is with torrent files, as you asked that time
I have this other two logs
http://paste.kodi.tv/adetejagok This is the log I got about the resolving magnets issue.
http://paste.kodi.tv/ejetujemak This is another log adding a torrent file
Hope it helps

@elgatito No, there is log level setting in general for Elementum (that is enabled on your settings).
And there is an option to print all libtorent alerts, that is another one.

@elgatito No, there is log level setting in general for Elementum (that is enabled on your settings).
And there is an option to print all libtorent alerts, that is another one.

Sorry. This is the log enabling libtorrent debug on Elementum settings
https://paste.kodi.tv/etaxipabos This is the resolving magnets issue

Sorry. This is the log enabling libtorrent debug on Elementum settings
https://paste.kodi.tv/etaxipabos This is the resolving magnets issue

Can you make the log with regular torrent file? And can you check upnp settings on your router.

Can you make the log with regular torrent file? And can you check upnp settings on your router.

This is the log adding a torrent file
https://paste.kodi.tv/regimofoco
About the upnp settings on my router, the upnp is enable as you can see here

Hope it helps

This is the log adding a torrent file
https://paste.kodi.tv/regimofoco
About the upnp settings on my router, the upnp is enable as you can see here

Hope it helps

I checked this new post https://github.com/elgatito/plugin.video.elementum/issues/685
It has a similar behavoir, is there something about it that helps solving this problem?

I checked this new post https://github.com/elgatito/plugin.video.elementum/issues/685
It has a similar behavoir, is there something about it that helps solving this problem?

@borisantelo totally different issue.

@borisantelo totally different issue.

With the new update the magnets pass the resolving magnet issue and it shows the downloading window whrere there are seeds and peers now but never start buffering (no active seeds for some reason).
Nothing changed about adding torrent files (The mandalorian in the image, No seeds, no peers).
Cheers

@borisantelo I can suggest you to try to run Kodi/Elementum on the host, that is able to download torrents. And check if it works with the same OS and same network settings on that host.

With the new update the magnets pass the resolving magnet issue and it shows the downloading window where there are seeds and peers now but never start buffering (no active seeds for some reason).
Nothing changed about adding torrent files (The mandalorian in the image, No seeds, no peers).
Cheers

@elgatito In a second test I've noticed that some providers (like YTS and Limetorrent) pass the resolving magnet issue, others don't (like KickAss and The Pirate Bay).
About your suggestion

@borisantelo I can suggest you to try to run Kodi/Elementum on the host, that is able to download torrents. And check if it works with the same OS and same network settings on that host.

Do you mean in another device on the same network? If that's so on my Windows PC Elementum runs normally. On the device with the problem (Odroid C2 with Coreelec) Quasar downloads torrents but Elementum doesn't.
Or do you mean with a remote host?
Thanks for the replies. Cheers.

Please if you could take a look.
This is a new log with the latest version of elementum with the same problem.
bundle_2021_2_19_22_8.zip

@elgatito a question please. The status of Elementum shows that elementum proxy port is 65222. I've checked and this port is closed. Maybe it's a dumb question I'm no expert but is this has something to do with this issue? Is that normal?

@borisantelo That is an internal proxy port. It is not used for libtorrent.
I have asked you already to uninstall Elementum, remove plugin.video.elementum/settings.xml and re-install plugin. To use default settings.

@elgatito

@borisantelo That is an internal proxy port. It is not used for libtorrent.
I have asked you already to uninstall Elementum, remove plugin.video.elementum/settings.xml and re-install plugin. To use default settings.

I have already done that several times and I've posted it, but I did it again anyway. Nothing has changed 0 seeds, never starts to donwload.

@borisantelo is this still relevant?
is so - have you tried to disable quasar, restart, then test elementum? iirc there might be conflicts if you will try to use both of them.

@borisantelo is this still relevant?
is so - have you tried to disable quasar, restart, then test elementum? iirc there might be conflicts if you will try to use both of them.

HI Anton, thanks for the reply. I have to use quasar because Elementum didn't work anymore. But still I tried a clean install of kodi only with Elementum and it didn't work either and couldn't use anymore

@borisantelo
i see. this is sad. but i do not see anything specific in the log. and since you said that elementum works on your Windows PC - then i guess this is something connected to the specifics of your device (Odroid C2 with Coreelec) or how it is set up (e.g. some network settings in the OS).
since we don't have such device/environment - i am afraid there is nothing we can do to help.
btw, elementum works for me on android tv box and linux pc (and CoreELEC is also linux). so it is quite hard to imagine the reason why it does not work for you.

It is weird because elementum worked before with the same device and network settings, in fact they were standard settings, it was after it stopped working that I tried changing many things that I found on internet, I had no improvements. Even with the clean install of kodi and elementum didn't work, so I don't know. Maybe it has to do with the changes on python and the OS of my device (Odroid C2 it's an old device and Coreelec team doesn't keep updating for it), but honestly I couldn't say I'm no expert.

the only suspicious thing in the log is a lot of UPnP errors. maybe check the upnp table on router to see if it really does the forwarding.

@antonsoroko
The UPnP option is turned on in my router's setup, and I guess it works forwarding because quasar works normally. I've tried the latest Elementum version, and still when I pick some of the scrapped torrents options get stuck in the resolving torrent alert and then the playback error message, others get thru that and it shows the seeds and peers window but the seeds stays on zero and never start downloading. Just one of many many intents worked and start downloading, but just that time, since that never worked again.

@borisantelo there should be a way to see upnp table. Just "enabled" does not say much. Maybe there is a bug in upnp library in elementum , but confirmation is needed. although it should be a platform specific bug, since it works for you on windows.

@antonsoroko
This is the port table I could get. I think it's ok, or not?
Protocol	Ext. Port	         Int. Client	Int. Port	Description
UDP		6881		<IP_ADDRESS>	6881	libtorrent/<IP_ADDRESS> at <IP_ADDRESS>:6881
TCP		6881		<IP_ADDRESS>	6881	libtorrent/<IP_ADDRESS> at <IP_ADDRESS>:6881
TCP		6885		<IP_ADDRESS>	6885	libtorrent/<IP_ADDRESS> at <IP_ADDRESS>:6885
UDP		6886		<IP_ADDRESS>	6886	libtorrent/<IP_ADDRESS> at <IP_ADDRESS>:6886
UDP		6889		<IP_ADDRESS>	6889	torrest/0.0.6 libtorrent/<IP_ADDRESS>
TCP		6889		<IP_ADDRESS>	6889	torrest/0.0.6 libtorrent/<IP_ADDRESS>
UDP		6891		<IP_ADDRESS>	6891	Elementum/0.1.77 at <IP_ADDRESS>:6891
TCP		6891		<IP_ADDRESS>	6891	Elementum/0.1.77 at <IP_ADDRESS>:6891
TCP		6897		<IP_ADDRESS>	6897	Elementum/0.1.77 at <IP_ADDRESS>:6897
With the latest version I notice one improvement. In one of my many tests (but only one time) a torrent finally start downloading very very slowly after a long time waiting.
Any suggestion will be very appreciated. Cheers.

@borisantelo
UDP 6891 <IP_ADDRESS> 6891 Elementum/0.1.77 at <IP_ADDRESS>:6891
TCP 6891 <IP_ADDRESS> 6891 Elementum/0.1.77 at <IP_ADDRESS>:6891
TCP 6897 <IP_ADDRESS> 6897 Elementum/0.1.77 at <IP_ADDRESS>:6897

looks correct.
if you do not have some firewall rules that prevent elementum from downloading - i ran out of ideas.
next steps to troubleshoot that could be to use tcdpump/wireshark to see networks traffic.
if you know people who can help you with that - then probably worth a try.
another easy thing to try - is to play around with settings on bittorrent tab in elementum.
e.g. encryption on/off, different protocols on/off, etc.

@borisantelo Try to open elementum settings, there is an option to restart addon. Try to restart with that and then test again.

@elgatito
Thanks for the suggestion. It didn't work though, maybe even worst some providers that worked (it passed the resolving magnet part) before, now they don't (at least so far). Either way when you get to the download window it keeps stuck with 0 seeds of some number so it doesn't start downloading.


Problem with mapping gold annotations (from BRAT) to candidates

Hi,
I have some (already annotated) standoff files containing both entities and relationships and I am trying to import them into snorkel with no success. I am following workshop tutorial 7, but when I running brat.import_gold_labels(session, "development", dev_cands), I get the following warnings:
Warning: 23425605 Span annotations do not match BRAT:[MeHg]!=SNORKEL:[] [949:953]
Warning: 23425605 Span annotations do not match BRAT:[dopamine]!=SNORKEL:[] [221:229]
Warning: 23425605 Span annotations do not match BRAT:[MeHg]!=SNORKEL:[] [1034:1038]
Warning: 23425605 Span annotations do not match BRAT:[calcium]!=SNORKEL:[] [1025:1032]
Warning: 23425605 Span annotations do not match BRAT:[methylmercury]!=SNORKEL:[synthesis, in] [57:70]
Warning: 23425605 Span annotations do not match BRAT:[catecholamine]!=SNORKEL:[demonstrate t] [20:33]
Warning: 23425605 Span annotations do not match BRAT:[tyrosine hydroxylase]!=SNORKEL:[] [1178:1198]
Warning: 23425605 Span annotations do not match BRAT:[dopamine]!=SNORKEL:[ar DA, a] [89:97]
Mapped 0/3558 ( 0%) of BRAT labels to candidates

As you can see, most of the SNORKEL mentions are empty, apart from those having offsets which are not that big. After having a look at my data, I figured out that while BRAT offsets are based on the beginning of the document, the snorkel span annotations (when not empty) start from the beginning of the last sentence of each document.
From the preprocessed dump used in tutorial 7 (brat-spouse.zip), I can see that each sentence was split in a new line and this might be the cause of the problem, as I copied tools.conf from the tutorial files, which has the following configuration:
# Possible values for splitter:
# - regex  : regular expression-based sentence splitting
# - newline: split by newline characters in source text (only)
Sentences	splitter:newline

However, I am unsure how to fix that problem, as there is a good chance that I will either ruin the offsets or might not be able to split the sentences again in a consistent way. Initially, for the candidate extraction phase (when creating snorkel db), I used the Stanford corpus parser with the pre-tagged candidate extractor (using a unary_tags dictionary and a mesh dict) for the entity tags.
Is there a way to ensure that the sentences are split again in the same way, or another way to import the gold labels into snorkel?
Thanks in advance!

we are facing the same issue , dis we find any approach to resolve this.
Thanks

@jason-fries any ideas here?

@littlewine You are correct that BRAT uses absolute document offsets. If you did any preprocessing of your documents before bringing them into BRAT (e.g., tokenization, stripping whitespace) this can cause alignment issues when importing into Snorkel. Given an unmodified document annotated in BRAT, the same document parsed by CoreNLP should have the same absolute document offsets.


'esp_ble_gatts_send_indicate' fails when 'value_len' is larger than 512 (IDFGH-14150)

Answers checklist.

[X] I have read the documentation ESP-IDF Programming Guide and the issue is not addressed there.
[X] I have updated my IDF branch (master or release) to the latest version and checked that the issue is present there.
[X] I have searched the issue tracker for a similar issue and not found a similar issue.

IDF version.
v5.3
Espressif SoC revision.
ESP32
Operating System used.
Windows
How did you build your project?
Eclipse IDE
If you are using Windows, please specify command line type.
CMD
Development Kit.
Custom Board
Power Supply used.
USB
What is the expected behavior?
Hi,
We’ve encountered an issue when interacting over BLE with some Android devices, specifically Google Pixel and some Samsung Galaxy models.
The problem seems to be related to the MTU size of the Android device, which in these devices is set to 517 (instead of 512).
After reading the ESP-IDF BLE Documentation, it is said MTU=517 is supported:

By default, the MTU size of ESP32 Bluetooth LE is 23 bytes, and can be configured to reach 517 bytes.

Also see ESP_GATT_MAX_MTU_SIZE macro (=517).
What is the actual behavior?
The issue arises when in esp_ble_gatts_send_indicate  the 'value_len' >= 512 (due to a resulting total MTU of 515 or higher, as 'ATT header (3 bytes)' is already considered as in ble_spp_server example)
Although esp_ble_gatts_send_indicate  is returning 'ESP_OK' -> (ee 'Debug Logs' section)
Note also that setting the LOG verbosity to maximum 'ESP_LOG_VERBOSE' is not reporting any message that indicates that the function is having any error.
Please, see 'Debug Logs' section.
Steps to reproduce.
See 'What is the actual behavior?' section
Debug Logs.

MTU limited to 512: Works as expected: 3 BLE frames are received by Android Phone

(11:55:18.966) *****************************************
(11:55:18.966) 'ESP_GATTS_MTU_EVT':MTU_RECEIVED:517:LIMITED:512
(11:55:18.994) *****************************************
(11:55:21.930) *****************************************
(11:55:21.930) 'BLE PACKET TO SEND:1237
(11:55:21.930) *****************************************
(11:55:21.930) *****************************************
(11:55:21.945) 'MTU_USED:512
(11:55:21.945) *****************************************
(11:55:21.945) *****************************************
(11:55:21.945) 1561 | ble_spp_helper_write: 'esp_ble_gatts_send_indicate':FRAME:1/3:LEN:509:OK:ESP_OK
(11:55:21.959) *****************************************
(11:55:21.959) *****************************************
(11:55:21.959) 1561 | ble_spp_helper_write: 'esp_ble_gatts_send_indicate':FRAME:2/3:LEN:509:OK:ESP_OK
(11:55:21.976) *****************************************
(11:55:21.976) *****************************************
(11:55:21.976) 1592 | ble_spp_helper_write: 'esp_ble_gatts_send_indicate':FRAME:3/3:LEN:231:OK:ESP_OK
(11:55:21.976) *****************************************

MTU limited to 515: Still works: 3 BLE frames are received by Android Phone

(12:04:17.049) *****************************************
(12:04:17.049) 'ESP_GATTS_MTU_EVT':MTU_RECEIVED:517:LIMITED:515
(12:04:17.049) *****************************************
(12:04:18.514) *****************************************
(12:04:18.514) 'BLE PACKET TO SEND:1237
(12:04:18.514) *****************************************
(12:04:18.514) *****************************************
(12:04:18.514) 'MTU_USED:515
(12:04:18.514) *****************************************
(12:04:18.514) *****************************************
(12:04:18.514) 1561 | ble_spp_helper_write: 'esp_ble_gatts_send_indicate':FRAME:1/3:LEN:512:OK:ESP_OK
(12:04:18.514) *****************************************
(12:04:18.514) *****************************************
(12:04:18.514) 1561 | ble_spp_helper_write: 'esp_ble_gatts_send_indicate':FRAME:2/3:LEN:512:OK:ESP_OK
(12:04:18.546) *****************************************
(12:04:18.546) *****************************************
(12:04:18.546) 1592 | ble_spp_helper_write: 'esp_ble_gatts_send_indicate':FRAME:3/3:LEN:225:OK:ESP_OK
(12:04:18.546) *****************************************

MTU limited to 516: Already fails: Just last packet is received by Android Phone

(12:08:21.496) *****************************************
(12:08:21.496) 'ESP_GATTS_MTU_EVT':MTU_RECEIVED:517:LIMITED:516
(12:08:21.496) *****************************************
(12:08:23.049) *****************************************
(12:08:23.049) 'BLE PACKET TO SEND:1237
(12:08:23.049) *****************************************
(12:08:23.065) *****************************************
(12:08:23.065) 'MTU_USED:516
(12:08:23.065) *****************************************
(12:08:23.065) *****************************************
(12:08:23.065) 1561 | ble_spp_helper_write: 'esp_ble_gatts_send_indicate':FRAME:1/3:LEN:513:OK:ESP_OK
(12:08:23.080) *****************************************
(12:08:23.080) *****************************************
(12:08:23.080) 1561 | ble_spp_helper_write: 'esp_ble_gatts_send_indicate':FRAME:2/3:LEN:513:OK:ESP_OK
(12:08:23.096) *****************************************
(12:08:23.096) *****************************************
(12:08:23.096) 1592 | ble_spp_helper_write: 'esp_ble_gatts_send_indicate':FRAME:3/3:LEN:223:OK:ESP_OK
(12:08:23.112) *****************************************

No MTU limitations: Fails: Just last packet is received by Android Phone

(12:13:47.074) *****************************************
(12:13:47.074) 'ESP_GATTS_MTU_EVT':MTU_RECEIVED:517:LIMITED:517
(12:13:47.074) *****************************************
(12:13:49.795) *****************************************
(12:13:49.795) 'BLE PACKET TO SEND:1237
(12:13:49.810) *****************************************
(12:13:49.810) *****************************************
(12:13:49.810) 'MTU_USED:517
(12:13:49.810) *****************************************
(12:13:49.810) *****************************************
(12:13:49.829) 1561 | ble_spp_helper_write: 'esp_ble_gatts_send_indicate':FRAME:1/3:LEN:514:OK:ESP_OK
(12:13:49.829) *****************************************
(12:13:49.829) *****************************************
(12:13:49.845) 1561 | ble_spp_helper_write: 'esp_ble_gatts_send_indicate':FRAME:2/3:LEN:514:OK:ESP_OK
(12:13:49.845) *****************************************
(12:13:49.845) *****************************************
(12:13:49.859) 1592 | ble_spp_helper_write: 'esp_ble_gatts_send_indicate':FRAME:3/3:LEN:221:OK:ESP_OK
(12:13:49.859) *****************************************

More Information.
No response

Until now, I thought the problem was solely related to the negotiated MTU being 517 (which means a value_len in esp_ble_gatts_send_indicate larger than 512).
However, I tested with another Android device with an MTU of 517, and it works. Currently, the results are as follows:

Google Pixel 6 Pro: MTU 517 → Fails

Samsung Galaxy A15 5G: MTU 517 → Fails

OnePlus Nord 4: MTU 517 → Success

Any Android device with an MTU of 512 (or when the MTU size is limited to 512 by code) → Success on all devices.

I am also attaching screenshots from the BLE Android Serial Terminal:
Success Example: (MTU Limited to 512) 3 BLE frames are receive by Android device

Fail Example: (MTU is 517) Just last packet is received by Android device

There’s a "loose end" that I’m not entirely clear about, related to the ATT Header Size.
I’ve been assuming it’s a constant 3 bytes:
#define CUSTOM_MAX_MTU_SIZE      512 // See: https://github.com/espressif/esp-idf/issues/14953
#define ATT_HEADER_SIZE           3 // 'ATT Transmission Unit' headers -> Pending to find real documentation about this
#define MULTIPACKETS_HEADER_SIZE  4 // ##xy [x:total_num, y: current_num]
#define SPP_DATA_SIZE             (spp_mtu_size - ATT_HEADER_SIZE)
#define SPP_MULTIPACKET_DATA_SIZE (SPP_DATA_SIZE - MULTIPACKETS_HEADER_SIZE)

However, I found documentation suggesting that the ATT Header Size for Android can be up to 5 bytes:
MTU is set to 517 for the first GATT client requesting an MTU

Alternatively, limit your GATT characteristic writes based on the minimum between the known supported value of your peripheral and the received MTU change

A reminder that you should reduce 5 bytes from the supported size for the headers
For example: arrayMaxLength = min(SUPPORTED_MTU, GATT_MAX_ATTR_LEN(517)) - 5

Could it be that the ATT Header is defined by the GATT Client and that the server must adapt/replicate the same header when answering? And could this be the reason why it fails on certain devices, where the ATT Header is 5 bytes?
Is there any way in ESP-IDF to retrieve the ATT Header size from the client, so I don’t hardcode 3 bytes as a constant and instead dynamically adjust to the client’s header size?

@carlessole
could you revert 20a780da8cccfe4b5af14c55e223a12af0432cd7,and test again?

@carlessole Any updates?


@Api description not visible in swagger.json file

When I give some description in @Api annotation like
@Api(value = "UsersController", description = "Controller for users"
that information is not passed to output swagger.json file
"tags" : [ {
"name" : "UsersController", description="[there should be: Controller for users]"
},
instead, the whole description part is missing
I've seen that you read that information in SpringMvcApiReader.java -> read() method, but nothing happens with that text
Is it possible to handle this information and pass it to json file? Swagger-ui can read that information from file and display near the controller's name if I enter it manually
Using smp v.3.0.1

I would love to see this fixed as well, the top level API descriptions are the most important part of documentation! Poseidon, have you found a workaround other than manually editing the json files?

No, just assumed that I dont have that description for now. I'm writting good descriptions hoping to have the functionality in the future.

Is there any work-around or fix for this issue. This is working fine for Jax-RS (as  it using JaxrsReader.java).
Can someone add the same code in SpringMvcApiReader.java and fix this issue for Springboot Project?

This PR adds Api description to a Tag, if there's a single tag defined. If there are no explicit tags, existing code already adds one.


OpenAPI not adding backslash to URLs

Using the default host.json configuration below. Functions all work great through postman, but when trying to execute through OpenAPI site, it is not adding a backslash to the URL after the domain/port:
Request URL
http://localhost:7071api/v1/todo?status=active
TypeError: Failed to execute 'fetch' on 'Window': Failed to parse URL from http://localhost:7071api/v1/todo?status=active
host.json:
{   "version": "2.0",   "extensions": {     "http": {       "routePrefix": ""     }   } }
Function:
.Functions(functions => functions .HttpRoute("/api/v1/HelloWorld", route => route                         .HttpFunction<HelloWorldCommand>()                     )                     .HttpRoute("/api/v1/todo", route => route                         .HttpFunction<GetTodoQuery>(HttpMethod.Get)                         .HttpFunction<GetTodoByIdQuery>("/{id}", HttpMethod.Get)                         .HttpFunction<CreateTodoCommand>(HttpMethod.Post)                        .HttpFunction<MarkTodoAsCompleteCommand>("/complete", HttpMethod.Put)                             .OpenApiDescription("this is a test")                     )                 );

+1 - while postman working well, any hints or workaround to being able to test with swagger appreciated.

also the /api part is missing from the swagger url

is there any known workaround for this issue?

I don't think there's a workaround but I'll try and take a look today - I think the fix should be fairly simple.

This should all be resolved in v2.1.1 that is indexing in NuGet now.
Thanks for raising.

yes @JamesRandall, it is fixed now. many thanks!


Can I use leddar vu8 instead of velodyne Lidar?

Thanks for using Autoware and for your question. However the issue tracker is for posting confirmed bugs and feature requests.
We ask that you please ask questions at the ROS Answers website following our support guidelines: https://github.com/autowarefoundation/autoware/wiki/Support-guidelines#ros-answers. Please pay particular attention to the information we ask you to provide.


cli alters generated files

Repo contains generated code that helpfully starts with
// Code generated - DO NOT EDIT.

Running the cli renames these files to foo.go.grc.bk and then leaves them like this.
I would expect that the report card should not actually alter any files in anyway.

I believe that the idea is that goreportcard as a services clones the repository and does whatever it pleases with it. This is fine. However, goreportcard-cli suffers from this.
The workaround would be to clone temporary, and then run report on that. That's a pain, but valid workaround.
Greater would to actually rename the files back that were skipped. Maybe a fork of this project has already done this? I have clone the repository, maybe I can figure something out.

Sorry, but goreportcard-cli can be run at any time on a working repo in order to find issues during development. So renaming generated code is just bad behavior; you can try to find some excuses for it, but it is simply still bad behavior.


Add specification roadmap to README

Cursory roadmap of the DLC specification, feel free to comment if there are more to add on to it.

Merging this for now, if anyone wants to change anything feel free to open a PR


job stays in CF status with the default setting

I followed the README to setup a slurm cluster using my jetstream xsede allocation.
When the install.sh finished, I check the cluster status with "sinfo", it said there were two compute nodes in "idle" state.
Then I submitted a test job(the sample job in the source tree)
sbatch slurm_test.job

But it stays in "CF" state forever
[centos@cyberwater-slurm-jetstream CRI_Jetstream_Cluster]$ squeue -u $USER
             JOBID PARTITION     NAME     USER ST       TIME  NODES NODELIST(REASON)
                 2     cloud slurm_te   centos CF       9:28      1 tg837458-compute-0
[centos@cyberwater-slurm-jetstream CRI_Jetstream_Cluster]$ sinfo
PARTITION AVAIL  TIMELIMIT  NODES  STATE NODELIST
cloud*       up   infinite      1 alloc# tg837458-compute-0
cloud*       up   infinite      1  idle~ tg837458-compute-1

The node list is empty
[centos@cyberwater-slurm-jetstream CRI_Jetstream_Cluster]$ scontrol show hostname
scontrol: error: host list is empty

So I guess I need to add compute nodes manually to the cluster somehow? (I saw some snapshot images are created during the installation, am I just going to launch the instances from web portal, and they will be managed by the headnode automatically?)
Thanks!
Feng

Hm, that's frustrating. The nodes shouldn't stay in 'CF' state more than a minute or two.
Is there any output in
/var/log/slurm/slurm_elastic.log
?
Are the compute nodes created in Openstack? ("source openrc.sh && openstack server list")
The 'scontrol show hostname' command is actually just a cli tool for expanding hostname blobs - the compute nodes are registered in slurmctld as shown by 'sinfo', but something has gone wrong during creation. The instances should be launched automatically when you submit jobs to slurm via the web portal, yes, and the image snapshot is used for the base image of those instances. :)
Thanks for following up; hopefully we can get this nailed down quickly!

Hi Eric,

The log shows

[centos@cyberwater-slurm-jetstream ~]$ cat /var/log/slurm/slurm_elastic.log
Node resume invoked: /usr/local/sbin/slurm_resume.sh tg837458-compute-0
creating tg837458-compute-0
No password entered, or found via --os-password or OS_PASSWORD
Mon Mar  2 14:11:01 UTC 2020 Node suspend invoked: ./slurm_suspend.sh
Node resume invoked: ./slurm_resume.sh
Node resume invoked: /usr/local/sbin/slurm_resume.sh tg837458-compute-1
creating tg837458-compute-1
No password entered, or found via --os-password or OS_PASSWORD

I checked with the openstack server list: only  one instance is running (cyberwater-slurm-jetstream),
Thanks

Aha! So, it's broken because the openrc is asking for a password during automated node creation.
I just pushed a change that should fix how the openrc file used by slurm is created, but if you're attached to the current cluster, you can change the file /etc/slurm/openrc.sh to contain:
export OS_PROJECT_DOMAIN_NAME=tacc export OS_USER_DOMAIN_NAME=tacc export OS_PROJECT_NAME=${OS_PROJECT_NAME} export OS_USERNAME=${OS_PROJECT_NAME} export OS_PASSWORD=${OS_PASSWORD} export OS_AUTH_URL=${OS_AUTH_URL} export OS_IDENTITY_API_VERSION=3
but with all of the variables (enclosed in ${}) replaced with the actual values for your allocation, and then make sure the openrc is only useable by the slurm user via
sudo chmod 600 /etc/slurm/openrc.conf
sudo chown slurm:slurm /etc/slurm/openrc.conf

Thanks for the fix,
but I think this can be a typo?
https://github.com/XSEDE/CRI_Jetstream_Cluster/blob/a914cc084fdd665a56ebb308aafff3846621caf2/install.sh#L153
shall be:
export OS_USERNAME=${OS_USERNAME}

In the case when I am "attached to the current cluster", what actions can i take for the modified /etc/slurm/openrc.sh to take effect (to avoid delete/recreate head node)?
I tried the following but didn't work:
[centos@js-slurm-cluster CRI_Jetstream_Cluster]$ sudo ./slurm_suspend.sh
scontrol: error: host list is empty
[centos@js-slurm-cluster CRI_Jetstream_Cluster]$ sudo ./slurm_resume.sh
scontrol: error: host list is empty

Thanks!
Feng

@ECoulter Hi Eric,
My Slurm cluster runs correctly now. But I still have a few questions:

Based on the log in (/var/log/slurm/slurm_elastic.log), when I submit the slurm_test.job, one compute node instance is created on-the-fly, after the job is done, that instance is deleted, am I understanding it correctly?
So if i need to add a yum package, I don't need to suspend the cluster at all: I just need to modify the compute_build_base_img.yml. When the next job is available in the queue, a new instance will be created using the updated new yml file, right?
After slurm_test.job finished, I checked the output file, and  It complains that module command is not found,

[centos@cyberwater-slurm-cluster CRI_Jetstream_Cluster]$ cat nodes_2.out
/tmp/slurmd/job00002/slurm_script: line 5: module: command not found
/tmp/slurmd/job00002/slurm_script: line 6: module: command not found
/tmp/slurmd/job00002/slurm_script: line 8: mpirun: command not found

but it's shall already be provided by the lmod-ohpc, right?
https://github.com/XSEDE/CRI_Jetstream_Cluster/blob/a914cc084fdd665a56ebb308aafff3846621caf2/compute_build_base_img.yml#L58-L66,
Thanks for your help again!

@fengggli Hi Feng!

Yes, that's exactly right!
Partially true - you actually have to rebuild the compute image yourself if you've added something, by running the ansible playbook (which creates an instance, modifies, and saves as a new image).
"sudo ansible-playbook -v compute_build_base_img.yml"
will do the trick. Sudo is still needed b/c it uses the slurm-key (the ssh key used by slurm to access compute nodes) to access the temporary instance which is created. Once the new image is created, the next compute node to be created will use it. The images are labelled by date, so you can switch back to the old image if something breaks, but images created on the same day will overwrite each other for now (this is done in compute_take_snapshot.sh).
Was this immediately after the build? I've seen this happen after installing lmod-ohpc on the headnode, but not logging out/in again, so that the module command isn't defined in the submitting shell environment, so it isn't picked up on the compute node either. The module command is actually a shell function that gets defined when /etc/profile is sourced on login, so it's a little different from most commands. If it happens again after logging out and back in (and submitting a new job), then something is broken - I'd double check that lmod-ohpc is installed & working on the headnode first.

Cheers,
Eric C.

@ECoulter Hi Eric,
Thanks for explaining 2, and it's clear to me now.
For 3, it happened immediately after the build, today I re-logged in and "module load" works correctly~  Everything looks good now.
Best,
Feng

Great - Feel free to reach out if you have other questions!
Cheers,
Eric.


Add "Sell Stock" Functionality

#56

@Akshat111111 please merge this pull request.

@Akshat111111 please merge this pull request.

@Akshat111111 please merge this pull request.

@Akshat111111 please merge this pull request.

@Akshat111111 please merge this pull request.

@Akshat111111 please merge this pull request.

@Akshat111111 please merge this pull request.

@Akshat111111 please merge this pull request.

@Akshat111111 please merge this pull request.

@Akshat111111 please merge this pull request.

@Akshat111111 please merge this pull request.

@Akshat111111 please merge this pull request.

@Akshat111111 please merge this pull request.


Fix incorrect class in variable definitions

Changes in this pull request
Fix incorrect class in variable definitions in IGListIndexPathResult. No change in functionality, nothing to test.
Pull request checklist

[x] All tests pass. Demo project builds and runs.
[x] I added tests, an experiment, or detailed why my change isn't tested.
[x] I have reviewed the contributing guide

Coverage remained the same at 94.22% when pulling 867b43c1eef5bd3ebcccb98ee94093657b78ea05 on antons:feature/fix-incorrect-class-names into f05ae5b14555fcbfe0cb966484c291a54c5dda27 on Instagram:master.

Actually the reason we use a set is to make the object lookups O(1), if we change these to arrays we'll end up with an O(n^2) method.

@rnystrom In that case it’s currently O(n^2), because these three variables are mutable arrays, not sets.

@antons good eye! Looks like this got lost in refactoring. Want to fix it so we're operating on sets w/in this algorithm?

@rnystrom Initially I thought it was a remnant of an old API, where ivars were sets, so I corrected the definition. I see two options to fix the bug:
NSMutableSet<NSIndexPath *> *deletes = [NSMutableSet setWithArray:self.deletes];

If the order of elements is important, ordered set could be a better option:
NSMutableOrderedSet<NSIndexPath *> *deletes = [NSMutableOrderedSet orderedSetWithArray:self.deletes];

@antons let's go w/ the first one, order isn't important at all. The only reason we ended up w/ NSArray for the result public API was that its (a little) easier to work w/ for consumers.
Thanks for digging on this!

@rnystrom My pleasure, and thank you for open sourcing this! I’ll submit a new pull request for the bug fix.


refactor terraform CLI

There is an issue installing terrafrom.

we need to make sure terraform start automatically when gitpod workspace is started


make the codebase more consistent

:tada: This PR is included in version 1.13.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


[Storage] az storage copy: Add parameter --content-type to fix#6466

History Notes:
(Fill in the following template if multiple notes are needed, otherwise PR title will be used for history note.)
[Component Name 1] (BREAKING CHANGE:) (az command:) make some customer-facing change.
[Component Name 2] (BREAKING CHANGE:) (az command:) make some customer-facing change.

Fix #6466
This checklist is used to make sure that common guidelines for a pull request are followed.

[ ] The PR title and description has followed the guideline in Submitting Pull Requests.

[ ] I adhere to the Command Guidelines.

There is an issue with azcopy 10.3 and the content-type cannot work as expected. Let's merge it when azcopy is ready.

add to S167


StackTraceVerbosity

I get an stacktrace on every Failure.
According to (https://pester.dev/docs/usage/output)
There is the Config variable  StackTraceVerbosity :
Where can I set this?

Because of the way we currently inject into Pester, we do not expose the ability to add your own custom options to invoke-pester because it may fail in weird ways. You can always try invoke-pester at the command line or add a PesterPreference to your session
https://pester.dev/docs/usage/configuration.
I'll leave this flagged as a possible future enhancement but it would require a lot of compatibility testing.


Error: Expected a value of type 'MouseEvent$', but got one of type 'Event$'

I'm facing an issue where I'm getting an error coming from the Dart SDK when using the Dashlane Chrome extension to fill a text input:
Uncaught (in promise) Error: Expected a value of type 'MouseEvent$', but got one of type 'Event$'
    at Object.throw_ [as throw] (errors.dart:291:21)
    at Object.castError (errors.dart:127:3)
    at Object.cast [as as] (operations.dart:742:12)
    at MouseEvent$.as_C [as as] (classes.dart:660:14)
    at Object._argumentErrors (operations.dart:364:42)
    at Object._checkAndCall (operations.dart:570:22)
    at Object.dcall (operations.dart:579:39)
    at html_dart2js.dart:37236:58
    at _rootRunUnary (zone.dart:1415:13)
    at async._CustomZone.new.runUnary (zone.dart:1308:19)
    at async._CustomZone.new.runUnaryGuarded (zone.dart:1217:7)
    at HTMLDivElement.<anonymous> (zone.dart:1254:26)

The input is created like this:
final InputElement _emailInput = InputElement()
    ..placeholder = 'Your email address'
    ..type = 'email';

How can we ignore events that are not implementing MouseEvent?
Details

Dart 3.1.2 (stable) (Tue Sep 12 16:26:23 2023 +0000) on "macos_arm64"
macos / Version 13.4.1 (Build 22F82)
dependencies: args, collection, http, image, intl, meta, path, pdf, synchronized, uuid, vector_math
dev_dependencies: build_runner, build_test, build_web_compilers, cli_util, lints, sass_builder, test
Chrome 117

I'm not sure if we have enough context yet, but my current hunch is that this should hopefully be addressable in your application logic.
The error location points to https://github.com/dart-lang/sdk/blob/3.1.2/sdk/lib/html/dart2js/html_dart2js.dart#L37236:
  _EventStreamSubscription(
      this._target, this._eventType, void onData(T event)?, this._useCapture)
      : _onData = onData == null
            ? null
            // If removed, we would need an `is` check on a function type which
            // is ultimately more expensive.
            // ignore: avoid_dynamic_calls
            : _wrapZone<Event>((e) => (onData as dynamic)(e)) {
                                                         ^ HERE

The (onData as dynamic)(e) is invoking an event listener, which is added by using some of the custom event streams exposed by dart:html (like element.onFoo.listen(callback)). The compiled code is checking that the T allows the value of e. It appears the compiler believes that in your case the onData callback expects a MouseEvent as input. This could be because the callback has a type that is too narrow, or because there is an error in dart:html on what kind of event is expected from a specific kind of event stream.
Could you share how are you listening for events on this input element in your application? That could give us the missing clue to figure out what is at fault here. If the MouseEvent type is declared in your application, the fix may simply be to relax that type.

If _wrapZone<Event>((e) => (onData as dynamic)(e)) were changed to _wrapZone<T>((e) => (onData as dynamic)(e)) then we'd avoid having a function accepting a T wrapped by a function that accepts an Event (so the outer function seems to be happy about a non-T event, but the inner one still throws). We will then have a function accepting a T wrapped by another function that accepts a T.
If _onData is later invoked (dynamically, or with an argument of type dynamic) with a non-T event then we will still get the run-time error. But it is now possible to do things like if (_onData is void Function(Event)) _onData(myEvent), and actually avoid calling _onData when we have an event that it doesn't want.
I don't know whether this kind of testing is actually used, I'm just commenting on this particular snippet of code from a language perspective. However, this change seems to be an improvement in type safety, no matter how that function object is used later on.


Fix sprintf syntax to enable string extraction

Fixed sprintf to enable string extraction of the below Power Operation related strings.
https://bugzilla.redhat.com/show_bug.cgi?id=1396278

@miq-bot add_label internationalization

@mzazrivec I noticed that some of the newer Power Operation related strings did not get extracted here: https://github.com/ManageIQ/manageiq-ui-service/pull/339, probably because of the incorrect usage of sprintf.
(No action required from your end. Just a FYI)

This should be euwe/yes since the Power Operations feature is part of Euwe.
Flipping the flag euwe/no to euwe/yes...
@miq-bot remove_label euwe/no
@miq-bot add_label euwe/yes

Euwe backport details:
$ git log -1
commit 588c13dccca29975eb9d3758d5c78c182d9f5e37
Author: Chris Kacerguis<EMAIL_ADDRESS>Date:   Wed Nov 16 15:43:20 2016 -0600

    Merge pull request #346 from AparnaKarve/i18n_fix_sprintf

    Fix sprintf syntax to enable string extraction
    (cherry picked from commit cc9e5c1c2e0c69cbfd44d39eddaca91c05c7e004)

    https://bugzilla.redhat.com/show_bug.cgi?id=1396576


⚠ ClamAV has degraded performance

In 1fde704, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 47 ms

Resolved: ClamAV performance has improved in 5205757.


[MVP Checkpoint] Implement Wazuh Indexer packaging

Description
As part of the ongoing development of the new Data Persistence Model, we need to ensure that the Wazuh Indexer can be installed on the host system and run as a background service, utilizing the system's built-in tools (packaging managers, Systemd, etc.). This issue aims to implement the following key components:

Ensure the Wazuh Indexer can run as a background service (daemon).
Develop system services for the Indexer to run on Linux.
Implement standard package management (RPM, DEB) for Wazuh Indexer installation.

Functional Requirements

The Wazuh Indexer should run as a background process (daemon) across supported systems.
The system must offer the capability to start, stop, and restart the Indexer manually. The default behavior (enabled/disabled) depends on the standard defined by the underlying platform.
The Wazuh Indexer should be installable via appropriate package management systems:

Linux:

RPM for RHEL-based distributions.
DEB for Debian-based distributions.

The Wazuh Indexer package contains ships the new plugins:

Setup plugin. https://github.com/wazuh/wazuh-indexer-plugins/issues/13
Command Manager plugin. https://github.com/wazuh/wazuh-indexer/issues/407
Reporting plugin. https://github.com/wazuh/wazuh-indexer/issues/423

Ensure all the index templates match the data model.

Non-Functional Requirements

The installation packages should follow the conventions and standards of the target operating systems.
The installation process should be as seamless as possible, reducing manual configuration steps.
Clear logging of Wazuh Indexer activities must be available to facilitate troubleshooting.

Implementation Restrictions

The service for Linux must use systemd as the service manager, since it is widely supported across the listed distributions.
Packaging must integrate with native package managers (e.g., rpm, apt, install) and conform to the relevant package guidelines for each platform.
For Linux distributions without systemd support (e.g., CentOS 6, RHEL 6), alternative service management methods must be considered (e.g., init).
The Wazuh Indexer packages are built using the GH Workflows created for this purpose.

Plan

Develop and test the Indexer's ability to start and run in the background independently on each platform.
Develop a systemd service for the Indexer on Linux platforms.
Create RPM and DEB packages for Linux distributions.
Set up testing pipelines to ensure proper installation and service functionality.
Documentation:

Create installation and service management documentation for system administrators.
Provide instructions for package installation, service control, and troubleshooting.

try this
https://mega.co.nz/#!B31G2LaZ!uBBOCp9hLC7bq9kP8NC6s4DanQJJZuoFRr5FI_jkeic
I put the necessary dlls in the archive

Every requirement described in this issue are fulfilled. The documentation will be worked on a future objective.


uninstalled without any apparent reason

Every time I install 'cursor-vip_windows_amd64.exe', it is uninstalled without any apparent reason immediately afterward. I use Xunlei to download it.

可能是杀毒软件的原因

你好，已收到你的邮件，我将在查看完邮件后尽快回复。

Wow，that`s it.解决了哥们，没啥好回报的给你点个star吧


Is there any way we can make first row sticky along with header ?

Is your feature request related to a problem? Please describe.
we have requirement to make first row sticky along with header which is basically a user row .
Describe the solution you'd like
I want to know solution or workaround to make very first row sticky along with header .
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.

Hi, were you able to resolve that requirement any way? I'm facing same issue right now.


Asynchronous GraphClient.Connect

I wanted to give it a try and implement this async but before starting that, it would be good to know if there is a particular reason why this wasn't implemented async.

No reason I'm aware of - if you want to do it - go for your life! (and thanks!)

@cskardon awesome, I will give that a go.

Ace!


NFC Normalize

This pull request should solve the problem described on https://github.com/StripesFramework/stripes-xss/issues/3


python3 support of pymacs

Issue description
nox only shows me a python2.7 package of pymacs, pymacs supports python 3, so it would be nice to get a version 3 of it.

The package has been disabled for Python 3.x as can be seen in the expression. Why I don't know. Maybe the maintainer @cillianderoiste can explain.
In any case, if you want the Python 3.x version I suggest you fix the expression.

Because this is a package request I am closing this issue. Do feel free to discuss further.


Adjust timestamp level to second

Codecov Report

Merging #331 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #331   +/-   ##
=======================================
  Coverage   81.41%   81.41%
=======================================
  Files          40       40
  Lines        1060     1060
  Branches      135      135
=======================================
  Hits          863      863
  Misses        126      126
  Partials       71       71

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 14873e0...0b54410. Read the comment docs.


update Masks.html

Submission Checklist
Required

[ ] The pull request title clearly contains the name of the sheet I am editing.
[ ] The pull request title clearly states the type of change I am submitting (New Sheet/New Feature/Bugfix/etc.).
[ ] The pull request makes changes to files in only one sub-folder.
[ ] The pull request does not contain changes to any json files in the translations folder (translation.json is permitted)

Changes / Description
black color on the roll text

Character Sheet Info Roll20 Internal Use only.


Update link to book in getting started guide

@osanstrong noticed that the old link to the effective computation in physics book is dead. Long live a new link.
I'm submitting a ...

[x] bug report
[ ] feature request
[ ] question

Expected Behavior
The ECIP book link in the getting started guide should go to a real page.
Actual Behavior
404
Steps to Reproduce the Problem

Go here
try link to "book"
get nowhere.

How can this issue be closed?
Replace that link with this one which should work for most folks : https://i-share-uiu.primo.exlibrisgroup.com/permalink/01CARLI_UIU/gpjosq/alma99954930827405899

This was resolved by #305


DEV: update tools for exercising code in docs

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.04%) to 91.318%

Totals

Change from base Build<PHONE_NUMBER>:
0.04%

Covered Lines:
177765

Relevant Lines:
194666

💛  - Coveralls


Please add macros

Description of the new feature / enhancement
Please add macros using some assigned combination of keys
Scenario when this would be used?
programming on any languaje, input shortkeys to do some recurrent tasks on keyboard...
Supporting information
You may know what is macro is by sure.
excellent job with this tool. regards.

Hello and thanks for your message. AutoHotkey or PowerAutomate could do this without breaking a sweat!


Add Bundle-ActivationPolicy: lazy

In this case the bundle gets automatically started, when one of its class get loaded.
So we don't have to start the bundle eagerly. It will be started automatically when its needed.

I close this pull request. This has been fixed in the master branch.


Calling a method in React from Webcomponent

Is there a way to call method in a React Component from my web component?  For instance, I render the react component as a webcomponent.  After using the react component to perform tasks and generate data, I would like to access that data from my web component.  After my webcomponent closes, I would like to call a function in the React Component to get data and pass it to another process.

Yes, we might be able to setup the proxy to return a method on a class-based react component.

Yes, we might be able to setup the proxy to return a method on a class-based react component.

I think this is possible

@christopherjbaker what does it mean to call a function on a traditional react component?

What do you mean by "web component closes"?


feat: nav menu revamp

Refactor navigation menu and break it down into smaller components
Allow nested menu items
Handle BTC/STX price fetch failure

:tada: This PR is included in version 1.118.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Tabular: Added tie_breaker options for EnsembleSelection, defaulted to 'second_metric'

Issue #, if available:
Description of changes:

Added tie_breaker options for EnsembleSelection, defaulted to 'second_metric'

Next Steps:

[x] Benchmark PR to ensure quality has not degraded.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Job PR-913-1 is done.
Docs are uploaded to http://autogluon-staging.s3-website-us-west-2.amazonaws.com/PR-913/1/index.html

Job PR-913-2 is done.
Docs are uploaded to http://autogluon-staging.s3-website-us-west-2.amazonaws.com/PR-913/2/index.html

Job PR-913-3 is done.
Docs are uploaded to http://autogluon-staging.s3-website-us-west-2.amazonaws.com/PR-913/3/index.html

Job PR-913-4 is done.
Docs are uploaded to http://autogluon-staging.s3-website-us-west-2.amazonaws.com/PR-913/4/index.html


porter maybe can cache old bundle versions forever

Describe the bug
I have seen this locally when working on the integration tests (for dependencies with the mysql and wordpress bundles). It was also just reported in Slack as well.
To Reproduce
I'm not totally sure but I'm guessing it looks something like this:

Publish a bundle with under a version, e.g. 1.0
Run porter install --tag mybuns:v1.0
Make changes to that bundle and republish to that same version again
Run porter install --tag mybuns:v1.0 again

Expected behavior
The user expects it to use the latest version of that bundle.
I'm not sure how porter knows to expire the cache for that tag? Maybe it's just a problem for local developers who are pushing and repushing the same tag, so when we publish, we should nuke the cache for that bundle and tag combo?
Version
v0.16.0-beta.1

Ah, I've been running into this as well.  Indeed, currently, Porter simply caches using a hash of the bundle tag.  Therefore, if digest/contents change whilst still using the same tag, no new cache entry will be generated.
We probably need to add additional unique info (digest/etc.) when generated the cached bundle hash?  The only tricky bit is ensuring it is still easy to find a cached bundle purely on bundle tag (or, perhaps we can update this logic to incorporate the same unique info.)


Update Database.java

Exclude unnecessary catch clause in the getModules() method. Reserved word final was deleted, because parameter e, if we catching multiple exception types, will be final by default (according to oracle documentation).
Do the same to getProjects() and load() methods in the seccond commit.

@cblichmann The following example, which is valid in Java SE 7 and later, eliminates the duplicated code:
catch (IOException|SQLException ex) {
    logger.log(ex);
    throw ex;
}

The catch clause specifies the types of exceptions that the block can handle, and each exception type is separated with a vertical bar (|).
Note: If a catch block handles more than one exception type, then the catch parameter is implicitly final. In this example, the catch parameter ex is final and therefore you cannot assign any values to it within the catch block.
P.S.: In my comment (about deleting a final key word) I meant the "Note" part.

@cblichmann And, as you can read, it is true only for multipart exception types catch clause.

Alright then, I actually wasn't aware of this aspect of multi-catch.
Care to prepare a pull-request to do that everywhere? :)

I can do it. But I need some time (like a day or few). If it is OK, I will do it.

Sure, getting rid of unnecessary keywords and unifying the exception handling sounds good.

Do it in small batches such that we can still verify it in a reasonable
amount of time. We should probably also get the tests working again to have
at least some regression testing.
alexVengrovsk<EMAIL_ADDRESS>schrieb am Mi., 2. Sep. 2015 um
16:35 Uhr:

I can do it. But I need some time (like a day or few). If it is OK, I will
do it.
—
Reply to this email directly or view it on GitHub
https://github.com/google/binnavi/pull/27#issuecomment-137105003.

I can provide a separate commit for every target class and a separate pull request for every package. It will be easy to test and revert changes. At least, it looks so for me.

SGTM
alexVengrovsk<EMAIL_ADDRESS>schrieb am Mi., 2. Sep. 2015 um
16:44 Uhr:

I can provide a separate commit for every target class and a separate pull
request for every package. It will be easy to test and revert changes. At
least, it looks so for me.
—
Reply to this email directly or view it on GitHub
https://github.com/google/binnavi/pull/27#issuecomment-137108350.

@0xFFFFFFFE  ?

sounds good to me -> your plan.
alexVengrovsk<EMAIL_ADDRESS>schrieb am Mi., 2. Sep. 2015 um
16:49 Uhr:

@0xFFFFFFFE https://github.com/0xFFFFFFFE ?
—
Reply to this email directly or view it on GitHub
https://github.com/google/binnavi/pull/27#issuecomment-137110333.

Ok


Feature/observation lifetime

Codecov Report

Merging #18 into master will increase coverage by 0.78%.
The diff coverage is 100%.

@@             Coverage Diff              @@
##             master      #18      +/-   ##
============================================
+ Coverage     88.98%   89.76%   +0.78%
- Complexity       88       93       +5
============================================
  Files            12       12
  Lines           236      254      +18
  Branches         19       19
============================================
+ Hits            210      228      +18
  Misses           17       17
  Partials          9        9

Impacted Files
Coverage Δ
Complexity Δ

...in/java/fi/helsinki/btls/services/MqttService.java
82% <100%> (+1.14%)
10 <0> (ø)
:arrow_down:

.../java/fi/helsinki/btls/datamodels/Observation.java
92.3% <100%> (+8.97%)
8 <2> (+2)
:arrow_up:

.../main/java/fi/helsinki/btls/datamodels/Beacon.java
93.1% <100%> (+2.62%)
12 <5> (+3)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7ce4003...87e0bea. Read the comment docs.


Fix #14: UTF-8 Support

Fixes #14.

Codecov Report

Merging #15 (aa32073) into develop (cd0ff6c) will decrease coverage by 0.17%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop      #15      +/-   ##
===========================================
- Coverage    85.46%   85.29%   -0.18%
===========================================
  Files           26       26
  Lines          406      408       +2
===========================================
+ Hits           347      348       +1
- Misses          59       60       +1

Impacted Files
Coverage Δ

lib/src/translator.dart
88.79% <100.00%> (-0.34%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cd0ff6c...aa32073. Read the comment docs.


Adapte after light turns onnwith matter Hue

Hi, I'm no sure this is bug, but yesterday, before I update my Hue bridges to Matter firmware and add them to HA everthing was working, the lights when turn  on were already adapted on color and brightness.
Now after this change, the light turn on and only after it adapts.
Can be a problem with matter connections? I noticed the lights response to my clicks on switch or over phone is quicker than before.

Just made some tests.
If the light is not add to configuration on integration, and we turn onnthe light using the dev tools, it only turns ON, not adapted color or brightness.
If I have the light add to configuration it adapts after the light turns on, not before as it should be.

New information, it's only color that isn't be updated, brightness is.
So it looks like a issue with adapt color be applie before lights turn ON, it adapts fine after the light is turn ON.

Transition times are not working too, at least for initial adaptation

I got the same issue, but with Nanoleaf essential thread lights on a matter only network, they turn on in the color state they turned off in, and only after the brightness is set they switch color!
I also have massive issues with them turning on after turning off, this only happens if they are color controlled.
Maybe there are issues with the matter/thread implementation?

I add the lights again using HUE integration.
Everything works fine, it just a bit slower between push of the button and action.

Interesting, thank you for the feedback :)


Minor text agreement correction

Hey, I just made a Pull Request!
Just a minor doc correction, nuffin' fancy. Simple subject numerical agreement.
Made this commit directly via github.com rather than the CLI, not sure if that ticks the "signed-off-by" requirement.
:heavy_check_mark: Checklist

[ ] A changeset describing the change and affected packages. (more info)
[x] Added or updated documentation
[ ] Tests for new functionality and regression tests for bug fixes
[ ] Screenshots attached (for UI changes)
[ ] All your commits have a Signed-off-by line in the message. (more info)

Running into access errors when attempting to push the amended commit via the CLI. I'll try recreating this PR.


allow gameobjects to have more than one prefab child in scene

ty Anabel, we don't know what we could do without you


[firebase_messaging] fcm notifications not working in release mode

Describe the bug
I wrote a small app to generate fcm token. I use this token to send a notification to my app with firebase admin sdk. It works perfectly fine when i build and install debug app on my ios device. The problem is in release build of the app. I always get token not registered error.
{
  code: 'messaging/registration-token-not-registered',                                                          message: 'The provided registration token is not registered. A previously valid registration token can be unregistered for a variety of reasons. See the error documentation for more details. Remove this registration token and stop using it to send messages.' },
  codePrefix: 'messaging'
}

To Reproduce
Steps to reproduce the behavior:

Build debug app to generate fcm and install on iOS device
Get token
Send notification to app via notification composer or admin sdk. Confirm notification
Build release app to generate fcm and install on iOS device
Send notification to app via notification composer or admin sdk. No notification.
Instead we see above error if sent via admin sdk.

Expected behavior
Notification should be seen in app in release mode
Additional context
I am using the same app identifier "com.example.fcm..." for both debug and release, so this eliminates the need to generate another set of identifier/provisioning profile, certificates and APNs.
My output of flutter doctor:
[✓] Flutter (Channel stable, v1.9.1+hotfix.4, on Mac OS X 10.14.6
    18G103, locale en-US)
    • Flutter version 1.9.1+hotfix.4 at
      /Users/.../flutter
    • Framework revision cc949a8e8b (9 days ago), 2019-09-27 15:04:59
      -0700
    • Engine revision b863200c37
    • Dart version 2.5.0

[✓] Android toolchain - develop for Android devices (Android SDK
    version 28.0.3)
    • Android SDK at /Users/.../Library/Android/sdk
    • Android NDK location not configured (optional; useful for native
      profiling support)
    • Platform android-28, build-tools 28.0.3
    • Java binary at: /Applications/Android
      Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build
      1.8.0_152-release-1136-b06)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 11.0)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 11.0, Build version 11A420a
    • CocoaPods version 1.7.5

[!] Android Studio (version 3.2)
    • Android Studio at /Applications/Android Studio.app/Contents
    ✗ Flutter plugin not installed; this adds Flutter specific
      functionality.
    ✗ Dart plugin not installed; this adds Dart specific
      functionality.
    • Java version OpenJDK Runtime Environment (build
      1.8.0_152-release-1136-b06)

[✓] VS Code (version 1.38.1)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.5.1

[✓] Connected device (1 available)
    •iPhone • 1c65d688b4859230d0f603c22144033caaa63b43 •
      ios • iOS 12.4.2

! Doctor found issues in 1 category.

have same problem...

Any updates on this?

Never mind, this can be solved by building the app with App Store certificates and deploying it to test devices using TestFlight.

Never mind, this can be solved by building the app with App Store certificates and deploying it to test devices using TestFlight.

please, what do u mean with appstore certificate? how do you build it with that? also you can't build -release on iphone without test flight and the notifications working?

I have the same issue ...

I have the same issue and I am hard stuck at this.
It used to work with older versions of firebase_messaging, however, the latest version is not working for me.
Note: I also use the flutter_local_notifications, but everything is setup according to the documentation.

Hey all 👋
As part of our roadmap (#2582) we've just shipped a complete rework of the firebase_messaging plugin that aims to solve this and many other issues.
If you can, please try out the dev release (see the migration guide for upgrading and for changes) and if you have any feedback then join in the discussion here.
Given the scope of the rework I'm going to go ahead and close this issue in favor of trying out the latest plugin.
Thanks everyone 🤓

Hi all. I am currently experiencing this issue. I was getting notification in the previous version but onMessage method didn't work. I recently updated firebase_messaging and now I cannot receive notifications in release mode. If I debug on simulator or on physical device I do get the notifications correctly. I have the certificates created and placed on appropriate places.
Can any one help. ?
Thanks.

@muzammil22, I had the same issue when was using flutter run --release.
You can try this, archive the app and upload your build to AppStore Connect. Then install it to your phone using TestFlight.
This worked for me.

I create a build using xcode and donot deploy it on app store connect. Instead I click development and get the .ipa file. Then I distribute the .ipa file using another service.
And it doesn't work this way. I have been trying to fix it for 2 days now.

I create a build using xcode and donot deploy it on app store connect. Instead I click development and get the .ipa file. Then I distribute the .ipa file using another service.
And it doesn't work this way. I have been trying to fix it for 2 days now.

@muzammil22, I know, I had similar experience as you when I tried to distribute with Firebase App Distribution.
The whole point is to put it in App Store Connect and download it with Test Flight. I think this weird behavior is related with the APNs certificates.

Okay. I'll try to do this.

I do get the notifications when the app is in background or closed but doesn't receive notifications when it's running. I added a Toast in onMessage and onResume to check. It doesn't show that.
Anyone experiencing the same issue ?

See https://firebase.flutter.dev/docs/messaging/notifications#foreground-notifications

Isn't this method available in the latest and stable version 7.0.3 or 7.0.0 ?
Plus how come the foreground notifications work currently on simulator but not when I build the app ?


APP-267 - allowing spread operator on main tile div

What does this PR do? (please provide any background)
In using the toolkit components it has come to light that we need to be more flexible in our approach. It's great giving people a framework, but when it's as rigid as this tile it isn't flexible to all the required uses. For instance the grouped product tiles require an onClick handler. To add in a new PR to add an extra prop/attribute to the tile every time we want to slightly change something or add a mouseOver handler seems nonsense.
Therefore we're adding the spread operator so that, within the confines of it's application we can customise our use of the tile without having to add extra code to the toolkit.
I wanted to use the rest destructuring to do something like var { image, children, ...props } = this.props but that wasn't possible with the make-up rules and eslint's support (or intentional lack of) for ES7. I therefore used lodash's omit to achieve the same result (props without the image or children). After some investigation I've found that the lodash method is faster to render in Tripapp than the rest method and the difference between the polyfill and lodash is negligible.
Also: https://facebook.github.io/react/docs/transferring-props.html#transferring-with-underscore
I'm aware the above link is talking about if we don't use JSX, which we do, but ES7 destructuring is subject to change/removal and we need something stable to achieve this. Hence lodash appears to me to be the better option.
I did look at doing this without lodash or the destructuring, but the props are immutable and read only so even if I cloned them I'd still have the same issue.
What tests does this PR have?
I've added a test to check that a spread prop will be passed through.
How can this be tested?
run the docs and check that you can add an onClick or equivalent to the tile.
Screenshots / Screencast
What gif best describes how you feel about this work?

[x] I have checked our general contributing document and the project specific contributing document (if present) and I'm happy for this to be reviewed.

Reviewers
Review 1

[ ] :+1:

By adding a +1 you are confirming you have...

Witnessed the work behaving as expected (this could be on the author's machine or screencast).
Checked for coding anti-patterns.
Checked for appropriate test coverage.
Checked all the tests are passing.

Thanks for the detailed explanation, happy with your investigation and action. This approach has had plenty of discussion prior to undertaking the work so happy to go through without a 2nd review. Nice work @lukehansell 👍


feat: Write and use docker-compose file for dashcore

Issue being fixed or feature implemented
Currently dashcore must be managed only via the Ansible play. This will allow management of the dashcore container locally,  and give the ability to locally tweak the config (image, command, etc) via the docker-compose.yml file. This is (I believe) the only service we run that does not use docker-compose in the tool.
What was done?
Adds a docker-compose.yml file for dashcore, and uses docker-compose to manage the container. Also removes the play which users docker container to manage it.
How Has This Been Tested?
Tested on masternode on testnet.
Breaking Changes
n/a
Checklist:

[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[ ] I have added or updated relevant unit/integration/functional/e2e tests
[ ] I have made corresponding changes to the documentation

Note: This has also been tested and validated on testnet seed nodes now.


Update README.md

Add note for required Python version (and modify 2010 to 2020 for update date)

Thanks @lp4n6 !
I would use your merge but I will reflect the changes in the script.


Plugin uninstall will not work with executeComposerCommands() returning true

PHP Version
8.2
Shopware Version
<IP_ADDRESS>.RC.3
Expected behaviour
Plugin uninstall should work with the method executeComposerCommands return true, when using a own plugin class in uninstall method.
Actual behaviour
The plugin classes will be loaded from a directory that not longer exists and therefore you get an error as mentioned in the How to reproduce section.
How to reproduce
I'm currently update a plugin for the new 6.5 version. I added a new composer requirement because the dom will not be installed by default.
{
    "require": {
        "shopware/core": "^6.5",
        "symfony/dom-crawler": "~6.2.0"
    }
}

I saw the new feature that composer commands will be installed by shopware, so I added the executeComposerCommands method returning true.
class AcmePlugin extends Plugin
{
    public function executeComposerCommands(): bool
    {
        return true;
    }
}

In the same plugin class is an uninstall method that just removes plugin tables from database.
public function uninstall(UninstallContext $uninstallContext): void
{
    if ($uninstallContext->keepUserData()) {
        parent::uninstall($uninstallContext);

        return;
    }

    /** @var Connection $connection */
    $connection = $this->container->get(Connection::class);

    $entities = [
        AcmeEntityTranslationDefinition::ENTITY_NAME,
        AcmeEntityDefinition::ENTITY_NAME,
    ];

    foreach ($entities as $entityName) {
        $connection->executeStatement(\sprintf('DROP TABLE IF EXISTS `%s`', $entityName));
    }
}

Now put your plugin into custom/plugins, install and activate the plugin. After that just uninstall the plugin with Remove all app data permanently. You will get an error like this:
Warning: include(/full/path/shopware/vendor/composer/../acme/my-plugin/src/Entity/AcmeEntity/Aggregate/AcmeEntityTranslationDefinition.php): Failed to open stream: No such file or directory.
The plugin is now deactivated but still installed. If you repeat the uninstall process it will work without errors and all plugin data is removed as expected.

Hi @JD297,
thanks for your detailed bug report :+1:
I'm currently trying to reproduce your issue but having some troubles. At least when you install activate and uninstall the plugin over the CLI everything works fine locally for me.
Do you use the administration to install or uninstall the plugin?

Ok i was able to reproduce your issue and created a ticket for that: https://issues.shopware.com/issues/NEXT-26059
Will take a look and we'll fix this for the <IP_ADDRESS> final release.
Thanks again for bringing up the issue.

The issue should be fixed with https://github.com/shopware/platform/commit/4a92c0e60e756170e9fb120b437eb487c08fb08c on the trunk branch, the fix will be included in the next 6.5 release.


In batch mode tokens are unnecessarily stored for every request although unchanged

When in batch mode, it appears that tokens are written to user table in database for every request, even when the tokens only changes for the first request.
These unnecessary operations can lead to poor performance, especially when combined with model versioning (eg using paper_trail).
Our test (paper_trail enabled) with 100 requests, resulted in a total processing time of 25s with change_headers_on_each_request enabled and only 6s with change_headers_on_each_request disabled.

The DB write is necessary to extend the duration of the batch buffer to account for the time taken for each request.
https://github.com/lynndylanhurley/devise_token_auth/blob/c158898b81e03478ee47dba066556ed49a841bf9/app/controllers/devise_token_auth/concerns/set_user_by_token.rb#L111
Can you think of another way to accomplish this without DB writes?

Alternatively, can't you just have papertrail ignore the tokens column?
https://github.com/airblade/paper_trail#2c-choosing-attributes-to-monitor

Thank you so much @lynndylanhurley for providing insight and also for pointing us to the relevant papertrail docs - we will give that a go

@lynndylanhurley just to report back on this: having papertrail ignoring the token column did make it significantly faster (100 requests ~ 18s (instead of 25s)) but still it appears that the write operation to the user table is quite expensive... for now we will be turning off change_headers_on_each_request reducing it to ~6s. thanks again for your help regardless


Fix CLI binary download link for Windows

h/t to @aureq for spotting this one while we were looking at something else.

I noticed another problem on the same page that needs some investigation. The links under the Other Installation Methods for Windows don't render correctly. If you know what the problem is, I am happy to edit this PR with the fix (or feel free to edit it yourself as well. I gave maintainers access to edit this PR.)


How to merge Javascript files

It would produce lots of *.js files after the project is built. Please tell me how to merge those files to one file.

This question is available on Nuxt.js community (#c2415)

These files are for asynchronous loading, each one is a separated page, with this process you won't need to load all unrelated pages, so it will make pages loading more efficiency.
If you don't want to use it, you can use @nuxt/router and manually define router.js with static import:
// router.js
import Vue from 'vue'
import Router from 'vue-router'

import MyPage from '~/components/my-page' // static import

Vue.use(Router)

export function createRouter() {
  return new Router({
    mode: 'history',
    routes: [
      {
        path: '/',
        component: MyPage
      }
    ]
  })
}

@tevel
The router.js can be put into ${srcDir}/app/router.js
srcDir: https://nuxtjs.org/api/configuration-srcdir#the-srcdir-property


GP3: Right size volumes

Overview
There are some over provisioned volumes due to our previous usage of gp2 volumes that we can right size to reduce total cost overhead.
References and additional details
arbitrum one:

indexer

avalanche:

indexer

gnosis:

daemon
daemon-beacon

optimism:

daemon
indexer
op-node

Acceptance Criteria

Volumes right sized

Need By Date
No response
Screenshots/Mockups
No response
Estimated effort
No response

scale down > resize


Use Elixir 1.4 Registry for aggregates

This addresses issue #38. The homegrown registry has been replaced by using the Elixir standard library Registry. Let me know if this looks alright.

@patrickdet Looks great, thanks for taking the time to implement these changes.

@slashdotdash sure thing. glad i could contribute to this great project! hope there will be more


Remove specialist

so funny you are mindi... if i didnt tell you 10 times not to put specialist...


recoverylog/exact offsets

Fixes #26.
This series of commits extends RecordedOp with first and last offset "meta" fields -- fields not actually serialized by the Recorder, but passed to FSM for tracking of relevant hints.
Adding LastOffset in particular enables FSMHints to track exact start and stop offsets of log Segments, which means that we can now use hints to determine whether a given log fragment is still necessary to the reproduction of those hints (and if not, we can delete it ala #27).
Also /cc @julianvmodesto if you're interested.

This change is

Publishing feedback of [r5,r6].

Reviewed 4 of 4 files at r5, 1 of 1 files at r6.
Review status: 9 of 19 files reviewed at latest revision, 6 unresolved discussions.

charts/gazette/templates/deployment.yaml, line 50 at r3 (raw file):
Previously, jgraettinger (Johnny Graettinger) wrote…
Hmm, this was driven by encountering a startup error on the examples. I assumed it was due to an intended removal of the flag and made this change mechanically. Though, looks like the flag changed from etcdEndpoint to etcd (we should confirm the internal project isn't affected).

Ah right. I forgot that the previous envflag appended -Endpoint. The internal project now has its own variant of the factory function, so it's not affected.

pkg/recoverylog/playback.go, line 377 at r5 (raw file):

			// ErrDesyncDetected is returned by FixedFraming.Unmarshal (and not Unpack, meaning the reader
			// is still in a good state). This frame is garbage, but playback can continue.
			log.WithField("mark", fsm.LogMark).Warn("detected de-synchronization")

I think this should clear err to avoid potentially being caught by the error checking in the defer.
** Leaving this comment here, although it might be rendered obsolete by a later commit in this PR. **

pkg/recoverylog/playback_test.go, line 383 at r5 (raw file):

	// Expect decoded operation includes first & last offset of the exact operation frame.
	var b = frameRecordedOp(newCreateOp("/a/path"), nil)
	var br = bufio.NewReader(bytes.NewReader(append(b, "extra"...)))

What is the purpose of appending "extra" to the framed op?

Comments from Reviewable

 % nits.

Reviewed 7 of 7 files at r7, 4 of 4 files at r8.
Review status: all files reviewed at latest revision, 4 unresolved discussions.

pkg/recoverylog/playback.go, line 377 at r5 (raw file):
Previously, rupertchen (Rupert Chen) wrote…
I think this should clear err to avoid potentially being caught by the error checking in the defer.
** Leaving this comment here, although it might be rendered obsolete by a later commit in this PR. **

Comment is obsolete.

pkg/recoverylog/playback.go, line 101 at r7 (raw file):

// Play using the prepared Player. Returns on the first encountered
// unrecoverable error, or upon a successful MakeLive or Handoff.
// Deprecated: Remove after context is plumbed through (Issue #37).

Nit: Godoc convention is to start a new paragraph ("blank" line).
Example: https://golang.org/src/syscall/syscall_windows.go?h=deprecated#L25

Comments from Reviewable

Thanks!

Review status: 3 of 19 files reviewed at latest revision, 5 unresolved discussions.

pkg/recoverylog/playback.go, line 101 at r7 (raw file):
Previously, rupertchen (Rupert Chen) wrote…
Nit: Godoc convention is to start a new paragraph ("blank" line).
Example: https://golang.org/src/syscall/syscall_windows.go?h=deprecated#L25

Done.

pkg/recoverylog/playback_test.go, line 383 at r5 (raw file):
Previously, rupertchen (Rupert Chen) wrote…
What is the purpose of appending "extra" to the framed op?

It's there to sanity-check that the exact encoded operation length is read (rather than reading to end-of-buffer). Removed already in later commit.

pkg/recoverylog/recorded_op.proto, line 23 at r1 (raw file):
Previously, rupertchen (Rupert Chen) wrote…
Nit: write => wrote

Done.

test/NOTES.rst, line 4 at r4 (raw file):
Previously, rupertchen (Rupert Chen) wrote…
RST syntax: embeded link:
Bootstrap an Etcd cluster using `Etcd operator <https://coreos.com/blog/introducing-the-etcd-operator.html>`_.

Done.

test/NOTES.rst, line 13 at r4 (raw file):
Previously, rupertchen (Rupert Chen) wrote…
RST syntax: inline literal, use double backquotes.
This will setup the ``examples`` bucket.

There's several instances of this in this file.

Done.

Comments from Reviewable


Cannot read property 'index' of undefined @ discontinuousTimeScaleProvider.js:248

I am using v0.6.1 and similar codes copy from https://github.com/rrag/react-stockcharts/blob/master/docs/lib/charts/CandleStickChartPanToLoadMore.jsx and I get the following error:

While searching for solution, I came across https://github.com/rrag/react-stockcharts/issues/198 and https://github.com/rrag/react-stockcharts/issues/121 but adding to code to check for null data does not resolve the issue.

Any hints where could be the possible issue?

Thanks!

Sorry, typo issue.