Make cycle detection throw an exception instead of returning null.

Fixes #4490
Description
Remove the two-step passes and the cache logic. Just throw an exception when detecting the loop.

Thanks for working on this. I'm not sure that this is the route we want to go. There are customers that require usage of cycles. On the other hand, we know that PVA wants to be able to jsut throw an exception when cycles are found, so we might want to configure 1) throw on cycles or 2) load graph with cycles. However the cycle should not return null -- do you ahve an example graph that results in null?

Thanks for working on this. I'm not sure that this is the route we want to go. There are customers that require usage of cycles. On the other hand, we know that PVA wants to be able to jsut throw an exception when cycles are found, so we might want to configure 1) throw on cycles or 2) load graph with cycles. However the cycle should not return null -- do you ahve an example graph that results in null? If there is a bug in cycle detection, then there are 2 things to do here: first, make it configurable and second, fix the bug if there is one. If there is a bug, feel free to share the json and conversation that triggers the bug and I could help.

Thanks for the reply.
I have no idea that the issue filed by tom means we should make it configurable or just throw an exception. (Maybe throw directly is a breaking change for some customers.)
The question is:

Configurable or just throw
if configurable, the default config is throwing or allow the cycles.
@tomlm  can you give the goal of this issue? Thanks.

Thanks @Danieladu. Based on @carlosscastro's message above, since some customers is depending on this to not throw, so making it configurable makes sense to me, we definitely prefer not to break any existing scenario. Thus make the default value to "not throw" make sense, because it will achieve the best back-ward compatible.

hi @carlosscastro, I have made "allowCycle" configurable.  Please take a look.

Thanks guys, you got it right, this way customers can choose their behavior. Appreciate it!

The changes are going in the right direction! I added comments for some details. Let me know if anything doesn't make sense to you. Ping me on Teams if you want to chat or I can be of help. thanks!

The changes are going in the right direction! I added comments for some details. Let me know if anything doesn't make sense to you. Ping me on Teams if you want to chat or I can be of help. thanks!

The suggestion is very useful. I have changed the common Exception type to a specific type.

@Danieladu and I jsut discussed a small change where ResourceExplorer will receive a REsourceExplorerOptions object that includes an AllowCycle bool property. Please don't merge until then.


fix ci tags

@leonheldattoradex the CI image needs to be pinned to a specific version. Otherwise merge requests or merges that change Dockerfile-ci will build a new CI container which will affect past and concurrent builds, the test runs need to be somewhat reproducible.
If you need to run CI in tests you could manage your own actions with your own containers. you could also run the ci container build action for the same revisions, which will create a tag with the same sha that can be used across forks.
Otherwise you can rely on MRs to this repo to run CI for you, which is what we do on the cloud team side.


Has issues with vim-powerline

When using this plugin: https://github.com/Lokaltog/vim-powerline
you get weird escaping going on when you invoke VimRoom.
before vimroom:
http://cl.ly/2W2H1C1t372J1G0c3C1L
after vimroom:
http://cl.ly/3V2n1J0D1j2K3V3B352C
I wish I was more of a vim pro to give a solution rather than just presenting a problem… it would appear that it has to do with some escaping of characters. I'd be content if the statusbar just hid during vim room mode. I dunno.

I don't experience the same problem. My powerline looks fine.
I normally turn it off
set statusline=0

when I'm in vimroom.

I use goyo.vim now. (https://github.com/junegunn/goyo.vim)


Add 500 page

@imbhargav5 should this page be a react router page or a static server rendered page?

I think, it should be a react router page. When something goes wrong on the server, the server can also render this route using router context.

I am working on this.


FIX: Repeated template lookups were not cached (fixes #4626)

Hopefully the test makes a bit more sense than my wall of text in #4626. Basically, <% with $Foo %>, <% loop $Foo %> and {$Foo.Bar} are not cached.
As far as I can see in git history, they never have been explicitly cached. However, they were somewhat accidentally cached in 3.1. This is what happened in 3.1:

<% if $Foo %> looks up Foo and then caches the result
<% with $Foo %> would not be cached, but as the result was already in the cache from the <% if %> it would be pulled out anyway

#3985 changed this behaviour, meaning that now if $cache is set to false, it avoids the cache - even if Foo is already present in the cache.
I don’t like using regular expressions to add a fourth parameter to obj() calls, but I can’t see any way to avoid it. Its method signature is different to XML_val() and hasValue(), yet it looks like the template parser expects it to be identical.
cc @hafriedlander

Tentatively setting milestone for this issue to 4.0 (even though it's a pr against the 3.2 branch).

Essentially we should REMOVE $forceReturnedObject, always return an object, and make both ViewableData::obj and ViewableData::*_val have the same method signature. Does that remove the need to hack in the extra param and special case for $method === 'obj'?

Yes, making both method signatures identical would solve the issue (and remove the need for either hack). We can definitely fix this (for master) a lot more cleanly if we do it that way.

I would prefer not changing it again at this stage, though, since it's actually working predictably.

The API in ViewableData is more predictable but the way it works in “template-land” is, if anything, less predictable than 3.1 as a result. I agree that we probably shouldn’t revert that commit, though.
My concern is that this is potentially a BC breaking issue when upgrading to 3.2 as this might cause unexpected repeated queries etc with no notice of what’s happening or why: it took me some time to track down why my example wasn’t working in 3.2 but was working in 3.1.
It’s not a critical issue - it’s possible to work around it, at least for my example - but it’s a pain and is potentially a (minor) performance issue depending on what data is being fetched, so I’d like to see this fixed for 3.2 in some way if at all possible.

Hm, it might be a bit late for 3.2.0, since it's in rc2 at the moment. =(

Shall we rebase this against master and merge it in, @tractorcow @kinglozzer?

I think it’s best to wait for #3924 to be merged before looking at this again. Either way this won’t be merged into 3.2, so closing

I'm in favour of removing $forceReturnedObject in master. :)


Remove forceful exit

Up to now, interrupt handling was implemented in two phases. If user would press Ctrl-C, rubocop would start exiting gracefully with the following message "Exiting... Interrupt again to exit immediately.", and if Ctrl-C was pressed again, rubocop would exit without any further cleanup.
However, I don't think this behavior is necessary. I tried to interrupt rubocop running without or without cache, in big or small projects, and I always get a graceful exit without even having any time to trigger the forceful exit path. So, I think we can simplify things and get rid of it.
This is actually some preparation to fix the actual end user problems I wanted to fix in #5808, but does not yet fix them. I still think this is a code simplification and an improvement in the end user experience.

Before submitting the PR make sure the following are checked:

[x] Wrote good commit messages.
[ ] Commit message starts with [Fix #issue-number] (if the related issue exists).
[x] Feature branch is up-to-date with master (if not - rebase it).
[x] Squashed related commits together.
[ ] Added tests.
[ ] Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
[x] The PR relates to only one subject with a clear title
and description in grammatically correct, complete sentences.
[x] Run bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.

I think @yujinakayama wrote the original code, so it'd be nice to hear what were his reason to implement the two-stage interrupt. I think this was a common approach taken by several tools, and we just borrowed it, but my memory is a bit fuzzy.

Yeah, the original approach seems taken from RSpec, which makes sense since @yujinakayama is/was a RSpec contributor. I'd like to hear his thoughts too! :+1:

I gave this some more though, and I managed to figure out a situation where one would not get an immediate exit when pressing Ctrl-C with this patch. If Ctrl-C is pressed during analysis of a huge file (> 10000 lines), then under the current patch one would have to wait until the analysis of that file finishes and that's not immediate.
I'll give it some more thought to see if I can keep the current behavior while improving the stuff I wanted to improve.

For now I'm closing this in favor of #6537!


[Adaptive Cards>Blogs]: Flags elements whose role is none or presentation and which cause the role conflict resolution to trigger.

Target Platforms
Other
SDK Version
1.5
Application Name
Adaptive Cards
Problem Description
Test Environment:
OS Version: 22H2 (Build 25267.1000)
Browser: Edge Dev (110.0.1556.0 (Official build) dev (64-bit)
URL: https://adaptivecards.io/blog/
Tool: Accessibility Insights for Web
Repro Steps:

Open the above URL in edge dev browser.
Run the fast pass of Accessibility Insights for Web
Observe the issue.

Actual Result:
Flags elements whose role is none or presentation and which cause the role conflict resolution to trigger.
Element is not focusable or Element does not have global ARIA attribute
Expected Result:
Element should be focusable or Element should have global ARIA attribute.
Notes:
This issue is repro throughout for the 'Blogs' tab.
User Impact:
Screen reader user will have difficulty in interacting with the contents and in understanding the purpose and its relationship with the content.
MAS Reference link:
https://microsoft.sharepoint.com/:w:/s/accessibility/EXdDUZzldv5MgwDaMHnTzcMBcT8opKGncYjU-gCJ4uqQdg?e=9nuVmt
Have feedback to share on Bugs? Please help fill Trusted Tester Bug Feedback (office.com)"
Screenshots

Card JSON
NA

Sample Code Language
No response
Sample Code
No response

This issue is not repro, hence closing this issue.


Recognition using FisherFaceRecogniser

Doing the FaceRecognition using  FisherFaceRecogniser class in OpenCV

create a seprate folder for this in the repo

Readme has been added.

Done


SpriteAnimation's function "onComplete" dont work when the animation has only one frame.

SpriteAnimation(
[SpriteAnimationFrame(await Sprite.load('enemy3_hit.png'), 0.1)],
loop: false)
..onComplete = () => current = EnemyState.normal;
This is my code, but I have only one animation frame, the onComplete fuction dont work. Is it a bug ?

Are you using that SpriteAnimation in a SpriteAnimationComponent, or how are you rendering it?
I'm suspecting that its update method is never called, I'd recommend adding it to a SpriteAnimationComponent and then add that component to your game (or to another component in a component tree that is attached to the game).

Hi, thanks for your answers. This is my code:
`
/// 战斗机
class WarEnemy extends BaseEnemy {
WarEnemy() : super(Vector2(69, 109) / 2.0, blood: 3, speed: 48, score: 2);
@override
Future? onLoad() async {
await super.onLoad();
final _normalAnimation = SpriteAnimation.spriteList([
await Sprite.load('enemy2.png'),
await Sprite.load('enemy2.png'),
], stepTime: 0.1);
final hitAnimation = SpriteAnimation.spriteList([
await Sprite.load('enemy2_hit.png'),
await Sprite.load('enemy2_hit.png'),
], stepTime: 0.1, loop: false)
..onComplete = () => current = EnemyState.normal;
final _deadAnimation = SpriteAnimation.spriteList(
await Future.wait(
[1, 2, 3, 4].map((el) => Sprite.load('enemy2_down$el.png'))),
stepTime: 0.1,
loop: false)
..onComplete = () => isDestory = true;
animations = {
EnemyState.normal: _normalAnimation,
EnemyState.hit: hitAnimation,
EnemyState.dead: _deadAnimation,
};
}
@override
void onMount() {
super.onMount();
FlameAudio.play('enemy2_out.mp3');
}
@override
void onPlaneHit() {
if (current != EnemyState.hit) {
animation?.done();
}
current = EnemyState.hit;
}
@override
void onPlaneDestroy() {
if (current != EnemyState.dead) {
FlameAudio.play('enemy2_down.mp3');
current = EnemyState.dead;
}
}
}
`
When I have single-frame , the 'onComplete' function dont work. Sometimes, the state cannot work well. Because I found that after I changed the sprite's current state, the frame dont have any changes.

@YugeCse Try the branch of PR #1387 and see if it fixes the problem.


python-modules.weasyprint: 50 -> 52

Motivation for this change
Updating weasyprint to the latest major upstream version.
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[x] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[x] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 107976 1

4 packages failed to build:

python37Packages.xml2rfc
xml2rfc (python38Packages.xml2rfc)
python39Packages.weasyprint
python39Packages.xml2rfc

3 packages built:

python37Packages.weasyprint
python38Packages.weasyprint
sourcehut.metasrht

Result of nixpkgs-review pr 107976 run on x86_64-darwin 1

7 packages failed to build:

python37Packages.weasyprint
python37Packages.xml2rfc
python38Packages.weasyprint
xml2rfc (python38Packages.xml2rfc)
python39Packages.weasyprint
python39Packages.xml2rfc
sourcehut.metasrht

weasyprint:
File "/nix/store/1pmbm2hpjvll1kmaz8c5njkh753sqfkj-python3.7-pytest-6.1.2/bin/.pytest-wrapped", line 9 in
/nix/store/2kq3igrr75pj6nay6phchgn5x1z1f30z-stdenv-darwin/setup: line 1317: 49611 Segmentation fault: 11  pytest -k 'not test_font_stretch'
python3.8-pgpy:
tests fail on sandbox due to network access
python-3.8-cfn-lint:
FAILED test/integration/test_quickstart_templates.py::TestQuickStartTemplates::test_templates
FAILED test/integration/test_quickstart_templates_non_strict.py::TestQuickStartTemplates::test_module_integration
FAILED test/integration/test_quickstart_templates_non_strict.py::TestQuickStartTemplates::test_templates
================== 3 failed, 497 passed, 1 warning in 59.83s ===================

This is a semi-automatic executed nixpkgs-review. If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.
Result of nixpkgs-review pr 107976 run on x86_64-linux 1

1 packages failed to build and are new build failures:

python37Packages.xml2rfc
xml2rfc
(python38Packages.xml2rfc)
python39Packages.weasyprint
python39Packages.xml2rfc
sourcehut.metasrht

2 packages built:

python37Packages.weasyprint
python38Packages.weasyprint

ERROR: Could not find a version that satisfies the requirement configargparse>=1.2.3 (from xml2rfc)
ERROR: No matching distribution found for configargparse>=1.2.3
ERROR: Could not find a version that satisfies the requirement appdirs>=1.4.4 (from xml2rfc)
ERROR: No matching distribution found for appdirs>=1.4.4
builder for '/nix/store/kmal5zpm1217y34316g3gcq8c2w3avs1-python3.8-cfn-lint-0.35.1.drv' failed with exit code 1; last 10 log lines:
test/unit/rules/functions/test_sub_needed.py:30
/build/source/test/unit/rules/functions/test_sub_needed.py:30: DeprecationWarning: invalid escape sequence $
{'custom_excludes': '^${self.+}$'}, 0
		  -- Docs: https://docs.pytest.org/en/stable/warnings.html
		    =========================== short test summary info ============================
			  FAILED test/integration/test_quickstart_templates.py::TestQuickStartTemplates::test_templates
			    FAILED test/integration/test_quickstart_templates_non_strict.py::TestQuickStartTemplates::test_module_integration
				  FAILED test/integration/test_quickstart_templates_non_strict.py::TestQuickStartTemplates::test_templates
				    ================== 3 failed, 497 passed, 1 warning in 48.01s ===================
					cannot build derivation '/nix/store/65crvik6h3fh53fdi79p87xvwpcqmvm8-python3.8-moto-1.3.14.drv': 1 dependencies couldn't be buil

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.
Result of nixpkgs-review pr 107976 run on x86_64-linux 1

1 package marked as broken and skipped:

python39Packages.xml2rfc

1 package failed to build and are new build failure:

python39Packages.weasyprint: log was empty

5 packages built:

python37Packages.weasyprint
python37Packages.xml2rfc
python38Packages.weasyprint
xml2rfc (python38Packages.xml2rfc)
sourcehut.metasrht

The following issues got detected with the above build packages.
Please fix at least the ones listed with your changed packages:
sourcehut.metasrht:

Zero tests run by pytest got detected: 'Ran 0 tests in 0.000s'
You have the following options to fix this:

Tell pytest(CheckHook) where to find the tests included in the package
Check if the GitHub Repo contains tests but they are not shipped with Pypi. If so please switch to fetchFromGitHub.
If the Packages does not contain any tests add 'doCheck = false;'and apythonImportsCheck`.

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.
Result of nixpkgs-review pr 107976 run on x86_64-linux 1

1 package marked as broken and skipped:

python39Packages.xml2rfc

1 package failed to build and are new build failure:

python39Packages.weasyprint: log was empty

5 packages built:

python37Packages.weasyprint
python37Packages.xml2rfc
python38Packages.weasyprint
xml2rfc (python38Packages.xml2rfc)
sourcehut.metasrht

The following issues got detected with the above build packages.
Please fix at least the ones listed with your changed packages:
sourcehut.metasrht:

Zero tests run by pytest got detected: 'Ran 0 tests in 0.000s'
You have the following options to fix this:

Tell pytest(CheckHook) where to find the tests included in the package
Check if the GitHub Repo contains tests but they are not shipped with Pypi. If so please switch to fetchFromGitHub.
If the Packages does not contain any tests add 'doCheck = false;'and apythonImportsCheck`.


To add Domain , Range and Graph of Trigonometric Function

Is your feature request related to a problem? Please describe.
To add Domain , Range and Graph of Trigonometric Function

Hi, I want to work on this issue I will start working on it as soon as I get assigned!! I am a part of GSSoC'21.
Kindly assign this issue to me!
Discord Username : Abhijeet Sinha(P)
Discord Tag: #4018


change packaging: download frontends as binaries

also: upgrade cpg

reasons to invoke frontends via shell command rather than jvm dependency

smaller classpath

sbt/idea/... work faster
joern/ocular start faster

no hidden memory leaks (as observed with fuzzyc2cpg)
less complexity in classpath
no issues with jre versions
only a matter of time until we have version clashes between frontends

It looks like with the current revision, sbt stage is no longer sufficient to get a working joern build from a clean repo. Would it be possible to add fetch and extract steps as part of the stage job?

yes, good point, I'll take a look

@johannescoetzee done, stage and distribution now work
will test joern-install.sh again after this was merged/released


TB /cam fog off feature no longer works.

After updating to v6.25, I have tried using /cam fog off to eliminate the fog in-game. As soon as I hit enter, the command doesn't work. Could be a bug?

It is still not working for me. I have tried in several areas. I don't even know why it won't turn off even if I hotkey it.

Enter gloom and show a screenshot

Enter gloom and show a screenshot

Sure thing. Of course.

I entered Gloom and used Hotkey /cam fog off and /camera fog off to turn off the fog, which had no effect.

Enter gloom and show a screenshot

Okay,  as it turns out. I got this message on Discord. It reads the following: GWCA / TB++
Cam fog off and cam fog on works. They work, but only the other way around. Cam fog off” turns the fog on and cam fog on turns the fog off.
@3vcloud


Element publishing improvements

We're currently bundling all elements, no matter if they are supposed to be used in apps or via CDN. This seems to be a bad practice as it increases bundle size, and makes development harder. See https://lit.dev/docs/tools/publishing/#don't-bundle-minify-or-optimize-modules:

Don't bundle, minify, or optimize modules
Bundling and other optimizations are application concerns. Bundling a reusable component before publishing to npm can also introduce multiple versions of Lit (and other packages) into a user's application since npm can't deduplicate the packages. This causes bloat and may cause bugs.
Optimizing modules before publication may also prevent application-level optimizations.
Bundling and other optimizations can be valuable when serving a module from a CDN, but since users may need to use multiple packages that depend on Lit, serving from a CDN can result in users loading more code than necessary. For these reasons we recommend performance-sensitive applications always build from npm where packages can be deduplicated, rather than loading bundled packages off of a CDN.
If you want to support usage from a CDN, we recommend making a clear separation between the CDN modules and the modules intended for production use. For example, placing them in a separate folder, or only adding them as part of a GitHub release and not adding them to the published npm module.

I am still not sure how to handle imports with Lit. On the one hand, importing only the custom element class is nicer for treeshaking and preventing double imports, but on the other hand the custom elements are not defined this way (needs to import the entire file).
To tackle the "double definition" customElements error, a workaround was introduced in https://github.com/EOX-A/EOxElements/issues/747, but I'm not sure if this is a good permanent solution.


adding ability to use regex in trigger phrase

It would be useful to have this because the builds could be parameterized on the comment.

Triggers are now considered as Regular expressions.


New methods to manipulate number

It includes some additional methods for providing more information to users.

First I added all the features in the class Validator

To manipulate the number there are methods that return the country code, the network code and the cell phone number.

The class contains a codes dictionary that will allow including country code and network belonging to other countries if in the future the package validates for different countries.

Thank you Marion,
Overall, I like the ideias your PR proposes, but the API you are proposing is a bit messy and It would be hard to maintain. I will send some commits to polish the edges.

Thank you Marion,
Overall, I like the ideias your PR proposes, but the API you are proposing is a bit messy and It would be hard to maintain. I will send some commits to polish the edges.


Readme File

WHEN I click on the read me I can view a description of the project, what the project was built with, the APIs used, links to the website and the repo, a screenshot of the final web page, the user story and the creators of the app
TO see if this is an app I want to use


Research and draft for curve algorithm with polyline

Note: Old ticket #179 was about coordinates, this one is about polylines
User story

As a user
I want to search for routes with a specific number of turns/length of turns
So that I can plan test drives

Acceptance criteria

Draft (e.g. Pseudo code) for implementation is documented in this issue

Definition of done

Code was reviewed by another person
GitHub CI runs successfully
Feature is merged into main branch

Okey here is the Pseudo Code:
calculating the radius of every point :
// starting point for this approach : https://roadcurvature.com/how-it-works/
val coordinates //list of coordinates
val radiuses //list of radious
for (i in 0 until coordiantes.size){
	val firstC = coordinates[i]
	val secC   = coordinates[i+1]
	val thirdC = coordinates[i+2]

	val a = distance(firstC, secC)
	val b = distance(secC,thirdC)
	val c = distance(firstC, thirdC)

	// resource: https://www.mathopenref.com/trianglecircumcircle.html
	val radius = (a*b*c)/(sqrt((a+b+c)*(b+c-a)*(c+a-b)*(a+b-c)))
	radiuses.add(radius)
}

We now have a radius for every 3 nodes in the route.
The problem is a curve is not have to only contain 3 nodes. Let's say if a curve has 9 nodes and if we filter them only by radius, our result will be like, "there are 9 curves here" but normally all of these nodes are in the same curve. OSM has segments attributes for it, it might be useful to calculate but here API doesn't have these attributes.
Need to find a way to differentiate if a node group is just in an already determined curve or a new curve.


navbar ,dropdowns, theme mode buttons updated.

Reference issue #92
Resolved

[x] Nav bar is fixed while scrolling.
[x] Shadow added to give uplifted view to navbar.
[x] dropdowns are oriented.
[x] Git hub icon added for direct link to Code-Social git hub profile.
[x] Dark/light theme button fixed in navbar.
[x] All internal styles are added to style.css for better code readability .

screenshot
Light mode

Dark mode

@riyaaryan2004 I assigned this issue to you. do following changes :-

pull current changes
update img urls with any public urls. (either store that images to cloudinary and use public urls / use internet img urls).
kindly resolve merge conflicts if any and then push it

Can u check #106
Merge conflicts resolve.


[6.0][Concurrency] Stage in new Async{Throwing}Stream.init(unfolding:) errors as warnings.

Explanation: Marking the closure parameter to Async{Throwing}Stream.init(unfolding:) as @Sendable changed the inferred isolation of closure arguments in actor-isolated contexts, which caused new effects checker errors when accessing isolated properties and methods without await. Mark these inits as @preconcurrency, and fix the effects checker to downgrade those errors to warnings when the context of the call is @preconcurrency.
Scope: Only impacts code calling these initializers in an actor-isolated context.
Risk: Low; the only effect of this change is downgrading errors to warnings.
Testing: Added new tests.
Main branch PR: https://github.com/apple/swift/pull/73310

@swift-ci please test


deps and included_applications

Here is kind of an odd case that I was hoping for a bit of insight into:

I have an umbrella project with 3 applications in it, lets call them App1, App2, and App3
This umbrella project will create two different exrm release builds and they are App1 and App3.

App1 has an "include_appplications" list with App2
App3 has both App1 and App2 in it's applications list

My expectation would be when I run App1, App2 was not started.  And when I run App3 I should see both App1 and App2 running, however when App3 is started only App1 is running.
It looks like the "included_applications" list from App1 is overriding the fact that it should be started in App3.  I was hoping that since App3 is the "root" project anything in the "applications" list would override any "included_applications" from a dependency.
Is there any way to get around this behavior?
Once again any help would be greatly appreciated!

As a followup:  If I run the projects using
iex -S mix
The behavior is what I was expecting:
App1 runs without App2
App3 runs with both App1 and App2 started
Thanks!

The configuration is merged I believe, could you try adding included_applications: [] to App3's mix.exs to see whether that fixes it? I'll try and dig in to this as soon as I can, just got back from vacation though and have a bit of a backlog :(

No joy, same behavior as before :p
-Chris

On Jul 23, 2015, at 7:31 AM, Paul Schoenfelder<EMAIL_ADDRESS>wrote:
The configuration is merged I believe, could you try adding included_applications: [] to App3's mix.exs to see whether that fixes it? I'll try and dig in to this as soon as I can, just got back from vacation though and have a bit of a backlog :(
—
Reply to this email directly or view it on GitHub https://github.com/bitwalker/exrm/issues/172#issuecomment-124124724.

@cjimison Could you post the mix.exs of each application? I want to try and reproduce this locally.

@bitwalker Sorry for the delay in response, I am out of town.  I created a sample project that should show the behavior off here:
https://github.com/cjimison/testExrm
Let me know if there is anything else I can do to help.
Thanks!
NOTE:  This is a quick and dirty project so please forgive any type-o, etc

Found the cause of the issue in the Erlang docs here.
The gist of it is these points:

An application can only be included by one other application.
An included application can include other applications.
An application that is not included by any other application is called a primary application.
The application controller automatically loads any included applications when loading a primary application, but does not start them. Instead, the top supervisor of the included application must be started by a supervisor in the including application.
This means that when running, an included application is in fact part of the primary application, and a process in an included application considers itself belonging to the primary application.

In effect, what this means is that because alt includes util, alt is responsible for starting/supervising util. I think what you really want here is for util to be started as a primary application, in which case it should be in applications for both main and alt.

Gotcha.  Learn something new about erlang every day :)

In effect, what this means is that because alt includes util, alt is responsible for starting/supervising util. I think what you really want here is for util to be started as a primary application, in which case it should be in applications for both main and alt

What I was hoping for was to include the code from “util” in the “alt” release package so I can call the Util.print function (which does a GenServer.cast to Utils.Server, a process registered in global).  Basically what we are looking to do is something like so:
Node 1)
main, alt, util
Node 2)
alt_app
Node N)
alt_app
with Nodes 2 - N including the “util" code in the release but NOT running the util supervisor/gen server.  If I made util the primary application it would start up it’s supervisor on all the nodes which is not what I want.
Just to give more context our project is games based so “util" in this case maybe a very large world map that is tracking player positions/etc and has a very high memory requirement (play positions change to quickly to be stored in a data base), alt is a TCP interface handler/msgPack serialize/deserializer which we will throw on hardware with less memory, and main could be a user Auth system.  When load is low we may just run Node 1 and when load starts to spike we will spin up Node 2+ (games tend to be VERY chatty so we burn a lot of CPU time just packing/unpack data).
Note: we have a work around for this in that we split our applications up into two types, logic applications which we do not build release packages, and deployment application that we use as primary and hand manage :applications and :included_applications in.  I was just hoping there was a way to cut this down because we have something like 5 different deployment packages and 15 logical packages.
Thanks for all the help!

Chris

On Aug 12, 2015, at 3:27 PM, Paul Schoenfelder<EMAIL_ADDRESS>wrote:
Found the cause of the issue in the Erlang docs here http://www.erlang.org/doc/design_principles/included_applications.html.
The gist of it is these points:
An application can only be included by one other application.
An included application can include other applications.
An application that is not included by any other application is called a primary application.
The application controller automatically loads any included applications when loading a primary application, but does not start them. Instead, the top supervisor of the included application must be started by a supervisor in the including application.
This means that when running, an included application is in fact part of the primary application, and a process in an included application considers itself belonging to the primary application.
In effect, what this means is that because alt includes util, alt is responsible for starting/supervising util. I think what you really want here is for util to be started as a primary application, in which case it should be in applications for both main and alt.
—
Reply to this email directly or view it on GitHub https://github.com/bitwalker/exrm/issues/172#issuecomment-130465983.

@cjimison The context helps a lot, I made the changes to your testExrm app for what you would need to do and sent your repo a PR so you can see the diff, but just to clarify the setup:

alt has util in it's included_applications
main has alt in it's applications
main is responsible for starting util in it's startup code (or wherever makes the most sense in order to ensure it's supervised)

This allows you to use util code in alt, without starting the util application, while also allowing main to pull in both alt and util and have the util application started. The non-intuitive bit here is that unlike most of the time when you omit an application in a release and it is not available at runtime, because main has alt in it's applications, and alt has util in it's included_applications, util is actually included in the release.
Hopefully that helps or at least makes sense. Let me know if you have any additional questions on this!

@bitwalker WOW this is awesome!!  Thank you so much for taking the time to dig into that project and updating it with the need changes.  That was really above and beyond what I was hoping for and I will be tasking some folks out tomorrow to help me clean our builds.

Chris

On Aug 12, 2015, at 9:15 PM, Paul Schoenfelder<EMAIL_ADDRESS>wrote:
@cjimison https://github.com/cjimison The context helps a lot, I made the changes to your testExrm app for what you would need to do and sent your repo a PR so you can see the diff, but just to clarify the setup:
alt has util in it's included_applications
main has alt in it's applications
main is responsible for starting util in it's startup code (or wherever makes the most sense in order to ensure it's supervised)
This allows you to use util code in alt, without starting the util application, while also allowing main to pull in both alt and util and have the util application started. The non-intuitive bit here is that unlike most of the time when you omit an application in a release and it is not available at runtime, because main has alt in it's applications, and alt has util in it's included_applications, util is actually included in the release.
Hopefully that helps or at least makes sense. Let me know if you have any additional questions on this!
—
Reply to this email directly or view it on GitHub https://github.com/bitwalker/exrm/issues/172#issuecomment-130527011.


Scrollcontroller issues.

How can I detect whether maxScrollExtent of Scroll controller is changed or not when I add children into Listview or Grid dynamically?

@Darkhorse07232020
if you need assistance with your code please follow the link I want help writing my application in the new issue menu
or, if you are reporting a bug, please provide your flutter doctor -v your flutter run -v
and a minimal reproducible code sample

@Darkhorse07232020
if you need assistance with your code please follow the link I want help writing my application in the new issue menu
or, if you are reporting a bug, please provide your flutter doctor -v your flutter run -v
and a minimal reproducible code sample

@Darkhorse07232020
Your issue description sounds more of a How to question rather than a bug or feature request in the framework. I'd suggest you to ask this question on support channels / use the link referred above.
Closing this for now. If you think you are facing an issue in the framework, provide above requested details and I'll reopen it.
Thanks.


Feature Request: Storage Images

Describe the feature request
Currently, VK_DESCRIPTOR_TYPE_COMBINED_IMAGE_SAMPLER is used throughout the vulkan frontend. This is fine and the simplest thing to do, although is troublesome when we think about Storage Images.
If we want a compute shader to be able to write to an image resource, we're screwed, because the vulkan frontend doesn't create any storage images, nor does it ever create descriptors of type VK_DESCRIPTOR_TYPE_STORAGE_IMAGE.
Remember: Storage Images don't require samplers, so I don't think it means we need to change non-storage images to not be combined with samplers. I think they're fine.
Might also need tzslc syntax for specifying the image format in the shader, because for some reason that's a thing.
Justification
Needed for GPU occlusion cullling based on depth pyramid. Culling (compute) shader needs to be able to imageStore max depth. https://vkguide.dev/docs/gpudriven/compute_culling/#occlusion-culling
Additional context
Does opengl just support this???

This requires complicated architectural changes in the vulkan frontend.

Storage Images must always be in the General image layout.,
In renderer_vulkan2, renderer_descriptor_manager's constructor runs before renderer_command_processor, meaning scratch commands aren't available while descriptor manager is being initialised.
Validation layers complain if you write an image descriptor that is both a storage image and isn't in the general layout.
Important note: Only preinitialised and undefined are allowed to be the initial image layouts. This means we must run scratch commands before writing our first set of descriptors. Due to the inheritance order, this is impossible

To fix this, renderer_command_processor needs to happen before renderer_descriptor_manager. From the sounds of things, they are orthogonal and this is technically more correct. However, there might be various gotchas. I haven't tried properly yet. This is a scary roadblock though.
In the meantime, my local changes on this will live on the vk_storage_images branch.


HDFS-15539. When disallowing snapshot on a dir, throw exception if its trash root is not empty

https://issues.apache.org/jira/browse/HDFS-15539
I initially intended to put the logic in SnapshotManager#resetSnapshottable.
But later I figured it makes more sense to put the check on the client side instead:

Trash is more of a client-side concept.
As a result of (1), it is much cleaner to add the check on the client than on the server side.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m  6s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s
The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
3m 15s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
28m 34s
trunk passed

+1 :green_heart:
compile
4m 38s
trunk passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1

+1 :green_heart:
compile
3m 49s
trunk passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

+1 :green_heart:
checkstyle
0m 58s
trunk passed

+1 :green_heart:
mvnsite
2m 10s
trunk passed

+1 :green_heart:
shadedclient
19m  3s
branch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
1m 25s
trunk passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1

+1 :green_heart:
javadoc
1m 54s
trunk passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

+0 :ok:
spotbugs
2m 29s
Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
5m 34s
trunk passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 23s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
1m 56s
the patch passed

+1 :green_heart:
compile
4m 10s
the patch passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1

+1 :green_heart:
javac
4m 10s
the patch passed

+1 :green_heart:
compile
3m 50s
the patch passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

+1 :green_heart:
javac
3m 50s
the patch passed

+1 :green_heart:
checkstyle
0m 53s
the patch passed

+1 :green_heart:
mvnsite
1m 55s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
shadedclient
15m 51s
patch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
1m 18s
the patch passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1

+1 :green_heart:
javadoc
1m 45s
the patch passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

+1 :green_heart:
findbugs
5m 45s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
1m 57s
hadoop-hdfs-client in the patch passed.

-1 :x:
unit
110m 48s
hadoop-hdfs in the patch passed.

-1 :x:
asflicense
0m 36s
The patch generated 3 ASF License warnings.

224m 24s

Reason
Tests

Failed junit tests
hadoop.hdfs.TestGetFileChecksum

hadoop.hdfs.TestFileChecksumCompositeCrc

hadoop.hdfs.TestViewDistributedFileSystem

hadoop.hdfs.TestFileChecksum

hadoop.hdfs.TestDistributedFileSystem

Subsystem
Report/Notes

Docker
ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2258/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/2258

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux 656e503fc62c 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 44542863f41

Default Java
Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

unit
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2258/1/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2258/1/testReport/

asflicense
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2258/1/artifact/out/patch-asflicense-problems.txt

Max. process+thread count
2857 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2258/1/console

versions
git=2.17.1 maven=3.6.0 findbugs=4.0.6

Powered by
Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

Thanks @smengcl for working on this,. The test failures like TestDistributedFileSystem#testGetTrashRoots look related. Can you plz verify?

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m  7s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s
The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
3m 28s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
28m 49s
trunk passed

+1 :green_heart:
compile
4m 37s
trunk passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1

+1 :green_heart:
compile
4m 15s
trunk passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

+1 :green_heart:
checkstyle
1m  2s
trunk passed

+1 :green_heart:
mvnsite
2m 14s
trunk passed

+1 :green_heart:
shadedclient
19m  0s
branch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
1m 25s
trunk passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1

+1 :green_heart:
javadoc
1m 56s
trunk passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

+0 :ok:
spotbugs
2m 28s
Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
5m 38s
trunk passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 24s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
1m 56s
the patch passed

+1 :green_heart:
compile
4m 10s
the patch passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1

+1 :green_heart:
javac
4m 10s
the patch passed

+1 :green_heart:
compile
3m 46s
the patch passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

+1 :green_heart:
javac
3m 46s
the patch passed

+1 :green_heart:
checkstyle
0m 53s
the patch passed

+1 :green_heart:
mvnsite
1m 59s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
shadedclient
15m 50s
patch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
1m 20s
the patch passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1

+1 :green_heart:
javadoc
1m 47s
the patch passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

+1 :green_heart:
findbugs
7m  3s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
2m 18s
hadoop-hdfs-client in the patch passed.

-1 :x:
unit
77m 54s
hadoop-hdfs in the patch passed.

+0 :ok:
asflicense
0m 38s
ASF License check generated no output?

194m 25s

Reason
Tests

Failed junit tests
hadoop.hdfs.server.namenode.TestReencryption

hadoop.hdfs.server.namenode.TestFSEditLogLoader

hadoop.hdfs.server.namenode.TestNameNodeReconfigure

hadoop.hdfs.server.namenode.TestNamenodeStorageDirectives

hadoop.hdfs.server.namenode.TestNameEditsConfigs

hadoop.hdfs.server.datanode.TestDataNodeVolumeFailureReporting

hadoop.hdfs.server.namenode.TestFileLimit

hadoop.hdfs.server.namenode.sps.TestStoragePolicySatisfierWithStripedFile

hadoop.hdfs.TestAppendDifferentChecksum

hadoop.hdfs.server.sps.TestExternalStoragePolicySatisfier

hadoop.hdfs.server.namenode.TestCheckpoint

hadoop.hdfs.server.namenode.TestMetadataVersionOutput

hadoop.hdfs.server.blockmanagement.TestReconstructStripedBlocksWithRackAwareness

hadoop.hdfs.server.namenode.TestFSImageWithXAttr

hadoop.hdfs.server.namenode.TestQuotaWithStripedBlocksWithRandomECPolicy

hadoop.hdfs.server.namenode.TestPersistentStoragePolicySatisfier

hadoop.hdfs.TestDFSStripedInputStream

hadoop.hdfs.server.namenode.TestStoragePolicySatisfierWithHA

hadoop.hdfs.server.datanode.TestDataNodeLifeline

hadoop.hdfs.server.blockmanagement.TestBlockTokenWithDFSStriped

hadoop.hdfs.server.datanode.TestDirectoryScanner

hadoop.hdfs.server.namenode.TestNamenodeCapacityReport

hadoop.hdfs.server.datanode.TestBatchIbr

hadoop.hdfs.server.namenode.TestLargeDirectoryDelete

hadoop.hdfs.TestDFSStripedInputStreamWithRandomECPolicy

hadoop.hdfs.server.namenode.TestEditLog

hadoop.hdfs.TestReconstructStripedFile

hadoop.hdfs.server.blockmanagement.TestBlockManager

hadoop.hdfs.server.blockmanagement.TestReplicationPolicy

hadoop.hdfs.server.datanode.TestDataNodeErasureCodingMetrics

hadoop.hdfs.server.datanode.TestBlockReplacement

hadoop.hdfs.TestDFSRollback

hadoop.hdfs.TestDFSClientExcludedNodes

hadoop.hdfs.server.namenode.TestDeleteRace

Subsystem
Report/Notes

Docker
ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2258/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/2258

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux ec8de439f715 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 9960c01a25c

Default Java
Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

unit
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2258/2/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2258/2/testReport/

Max. process+thread count
2045 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2258/2/console

versions
git=2.17.1 maven=3.6.0 findbugs=4.0.6

Powered by
Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

Thanks @smengcl for working on this,. The test failures like TestDistributedFileSystem#testGetTrashRoots look related. Can you plz verify?

I'm checking. Probably need to add a line or two to clean up the old tests.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
2m 28s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s
The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
3m 33s
Maven dependency ordering for branch

-1 :x:
mvninstall
6m 17s
root in trunk failed.

-1 :x:
compile
0m 26s
hadoop-hdfs-project in trunk failed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1.

-1 :x:
compile
0m 25s
hadoop-hdfs-project in trunk failed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01.

-0 :warning:
checkstyle
0m 23s
The patch fails to run checkstyle in hadoop-hdfs-project

-1 :x:
mvnsite
0m 17s
hadoop-hdfs-client in trunk failed.

+1 :green_heart:
shadedclient
3m  6s
branch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
1m 51s
trunk passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1

+1 :green_heart:
javadoc
2m 19s
trunk passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

+0 :ok:
spotbugs
3m  4s
Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
7m  1s
trunk passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 42s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 18s
the patch passed

-1 :x:
compile
6m  7s
hadoop-hdfs-project in the patch failed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1.

-1 :x:
javac
6m  7s
hadoop-hdfs-project in the patch failed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1.

-1 :x:
compile
0m 22s
hadoop-hdfs-project in the patch failed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01.

-1 :x:
javac
0m 22s
hadoop-hdfs-project in the patch failed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01.

-0 :warning:
checkstyle
0m 23s
The patch fails to run checkstyle in hadoop-hdfs-project

-1 :x:
mvnsite
0m 26s
hadoop-hdfs-client in the patch failed.

-1 :x:
mvnsite
0m 25s
hadoop-hdfs in the patch failed.

+1 :green_heart:
whitespace
0m  1s
The patch has no whitespace issues.

+1 :green_heart:
shadedclient
0m 25s
patch has no errors when building and testing our client artifacts.

-1 :x:
javadoc
0m 25s
hadoop-hdfs-client in the patch failed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1.

-1 :x:
javadoc
0m 27s
hadoop-hdfs in the patch failed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1.

-1 :x:
javadoc
0m 23s
hadoop-hdfs in the patch failed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01.

-1 :x:
findbugs
0m 28s
hadoop-hdfs-client in the patch failed.

-1 :x:
findbugs
0m 30s
hadoop-hdfs in the patch failed.

_ Other Tests _

+1 :green_heart:
unit
2m 11s
hadoop-hdfs-client in the patch passed.

-1 :x:
unit
129m 33s
hadoop-hdfs in the patch passed.

-1 :x:
asflicense
0m 33s
The patch generated 4 ASF License warnings.

179m 16s

Reason
Tests

Failed junit tests
hadoop.security.TestPermissionSymlinks

hadoop.fs.permission.TestStickyBit

hadoop.hdfs.server.sps.TestExternalStoragePolicySatisfier

hadoop.hdfs.TestGetFileChecksum

hadoop.metrics2.sink.TestRollingFileSystemSinkWithSecureHdfs

hadoop.hdfs.TestFileChecksumCompositeCrc

hadoop.metrics2.sink.TestRollingFileSystemSinkWithHdfs

hadoop.hdfs.TestFileChecksum

hadoop.security.TestRefreshUserMappings

hadoop.hdfs.TestReadStripedFileWithMissingBlocks

hadoop.tools.TestJMXGet

hadoop.hdfs.server.namenode.ha.TestHAAppend

hadoop.security.TestPermission

Subsystem
Report/Notes

Docker
ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2258/3/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/2258

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux 3158e5f6446b 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 9960c01a25c

Default Java
Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

mvninstall
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2258/3/artifact/out/branch-mvninstall-root.txt

compile
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2258/3/artifact/out/branch-compile-hadoop-hdfs-project-jdkUbuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1.txt

compile
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2258/3/artifact/out/branch-compile-hadoop-hdfs-project-jdkPrivateBuild-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01.txt

checkstyle
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2258/3/artifact/out/buildtool-branch-checkstyle-hadoop-hdfs-project.txt

mvnsite
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2258/3/artifact/out/branch-mvnsite-hadoop-hdfs-project_hadoop-hdfs-client.txt

compile
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2258/3/artifact/out/patch-compile-hadoop-hdfs-project-jdkUbuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1.txt

javac
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2258/3/artifact/out/patch-compile-hadoop-hdfs-project-jdkUbuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1.txt

compile
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2258/3/artifact/out/patch-compile-hadoop-hdfs-project-jdkPrivateBuild-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01.txt

javac
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2258/3/artifact/out/patch-compile-hadoop-hdfs-project-jdkPrivateBuild-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01.txt

checkstyle
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2258/3/artifact/out/buildtool-patch-checkstyle-hadoop-hdfs-project.txt

mvnsite
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2258/3/artifact/out/patch-mvnsite-hadoop-hdfs-project_hadoop-hdfs-client.txt

mvnsite
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2258/3/artifact/out/patch-mvnsite-hadoop-hdfs-project_hadoop-hdfs.txt

javadoc
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2258/3/artifact/out/patch-javadoc-hadoop-hdfs-project_hadoop-hdfs-client-jdkUbuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1.txt

javadoc
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2258/3/artifact/out/patch-javadoc-hadoop-hdfs-project_hadoop-hdfs-jdkUbuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1.txt

javadoc
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2258/3/artifact/out/patch-javadoc-hadoop-hdfs-project_hadoop-hdfs-jdkPrivateBuild-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01.txt

findbugs
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2258/3/artifact/out/patch-findbugs-hadoop-hdfs-project_hadoop-hdfs-client.txt

findbugs
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2258/3/artifact/out/patch-findbugs-hadoop-hdfs-project_hadoop-hdfs.txt

unit
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2258/3/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2258/3/testReport/

asflicense
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2258/3/artifact/out/patch-asflicense-problems.txt

Max. process+thread count
3074 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2258/3/console

versions
git=2.17.1 maven=3.6.0 findbugs=4.0.6

Powered by
Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

/retest


Devise Parameter Sanitizer not working?

I have not been able to get the devise_parameter_sanitizer to work in my invitations_controller.rb. Here is what I am seeing in the console. Can anyone shed some light on this?
(Note that this happens in the create action.)

[1] pry(#<Users::InvitationsController>)> devise_parameter_sanitizer
  => #<Devise::ParameterSanitizer:0x007fdbb1bba0a0
   @blocks={},
   @params=
    {"invite"=>{"name"=>"Volkan"<EMAIL_ADDRESS>     "controller"=>"users/invitations",
     "action"=>"create"},
   @permitted={:invite=>[:email, :name]},
  [2] pry(#<Users::InvitationsController>)> devise_parameter_sanitizer.sanitize(:invite)
  => {}

I just encounter this issue. I'm using a link to invite user so I had to provide param hash instead of the form provided in the generated view.
devise_parameter_sanitizer.sanitize(:invite) will fetch the resource_name (which is the invitable model - usually User model) in the params not the :invite symbol.
To fix the issue, you need to wrap the parameter in the resource name like this assuming your model is user:
params = { user: {"name" => "John", "email" =><EMAIL_ADDRESS>}
Hope this helps.


b2b components break script-rule functionality

Used Shopware Version: <IP_ADDRESS>
B2B for Shopware 6
Description:
When the b2b-suite is installed, rule-conditions that are defined in an app via twig-script can not be selected in the backend.
This is probably because in the file src/commercial/src/B2B/OrderApproval/Resources/config/rule/rules.xml the ScriptRule Service gets defined again with the tag shopware.approval_rule.definition. Now the tag "shopware.rule.definition" is missing for this service.
Environment:
locally in a dockware-container, but online inside a cloud-enviroment aswell.
Steps to reproduce:

Have the b2b-suite installed
Create a rule-condition in an app
Create a rule in the shopware-backend, select the created rule-condition and save the rule.

Expected result:

The rule gets saved.

Actual result:

Error-Message: "This scriptRule is not a valid condition type."

[public] Automated response: This issue is linked to the internal issue https://shopware.atlassian.net/browse/B2B-1264.
[created from B2B-1264, comment 487114]


Feature request: parameter for max file size

Hello,
I think it could be useful to have a parameter to limit max file size of recorded video. Or maybe also add parameter if user wants to create new video file after max_file_size is reached or just to stop recording.
Regards :)

The same thing can work for max duration of video

Duration is a good idea, but the program actually don't know the duration of the clips, hence why I make the filesize feature first.

Maybe it can check the value of recordStartTime() - nowTime() (counting pause when author goes to private/offline)?

Sounds good enoguh for estimated time if the requirement was not asking for very precise


Adding ability to override ndots for alpine/musl compatability

I have problems with Alpine / Musl's DNS resolution and need to adjust ndots for compatibility. Lots of community discussion about this out there.

Hi Greg,
Thank you for your PR. I would actually prefer a more general option using the dnsConfig section in values.yaml. Your solution overrides the default DNS configuration in a cluster (I'm aware that ndots=5 is a default value, but the administrator might have globally changed it). Therefore, by default, the helm chart should respect the cluster's default DNS configuration and not be forced to value 5.
I hope you understand what I think to do.
# Pod's DNS Configuration
# https://kubernetes.io/docs/concepts/services-networking/dns-pod-service/#pod-dns-config
# This value is useful if you need to reduce the DNS load: set "ndots" to 0 and only use FQDNs.
dnsConfig: {}
#  nameservers:
#    - <IP_ADDRESS>
#  searches:
#    - ns1.svc.cluster-domain.example
#    - my.dns.search.suffix
#  options:
#    - name: ndots
#      value: "2"

and in your statefulset.yaml something like this:
    spec:
      {{- if .Values.dnsConfig }}
      dnsConfig: {{- toYaml .Values.dnsConfig | nindent 8 }}
      {{- end }}

Regards
Pavel

Pavel,
Your solution is much cleaner 👏 . Implemented as suggested!

Hi Greg,
thank you for update, please check the location of your changes, I think it should be here:
apiVersion: apps/v1
kind: StatefulSet
spec:
  template:
    spec:
    {{- if .Values.dnsConfig }}
      dnsConfig:
        {{- toYaml .Values.dnsConfig | nindent 8 }}
    {{- end }}

:shame:
You're right again. I had that at the wrong level. Fixed.

thank you


Support for Oklab/Oklch?

Oklab is an alternative to Cielab. It works with the same logic, but claims to be more perceptually uniform than Cielab. It uses a D65 whitepoint. There are conversions defined from and to XYZ-D65 (a matrix + a cubic root respective power of three + another matrix).
Since its inclusion in the CSS Color Module Level 4 [W3C Candidate Recommendation Draft] it’s gaining wider support.
Would it be possible to support Oklab (and its derived cylindrical variant, Oklch) in LittleCMS out-of-the-box? So that pipelines can directly convert between Oklab/Oklch and an arbitrary ICC profile?

Here is the definition of Oklab: https://bottosson.github.io/posts/oklab/

That seems a nice addition, and would be as easy as adding a color space profile bult-in.
What I need is the set equations to convert CIE Lab* to this space and vice-versa. Also it would need some sort of chromatic adaptation to convert from D65 to D50, which is where ICC colorimetry is based.

@sommerluk
In f4e9f9122a001b71219d9b2d2a6ec5b8c784d785 you can see a preliminary implementation of OkLab space. This built-in profile cannot be saved as an  ICC file, so its use is programmatically only.
It is a colorspace profile, so It can deal with OkLab-> whatever and whatever->OkLab. Note that it uses D50 as PCS white point.
The stages are:
[Conversion D60 to D65] ->[Conversion to LMS cone space] -> [Non-linearity] -> [Final matrix to OkLab]
The input direction pipeline is like this one but reversed.
I still have to figure out how to deal with white point in unadapted absolute colorimetric, probably a D65 should be used as media white.  It should do its way to 2.16, which is still months ahead.
Thanks again for the idea.

That's great! I've downloaded it and played around, and it works fine.
Maybe it makes sense to add
#define TYPE_OKLAB_DBL          (FLOAT_SH(1)|COLORSPACE_SH(PT_MCH3)|CHANNELS_SH(3)|BYTES_SH(0))

to the public header?
Thanks for implementing this as fast! That's a super-conveniant feature!

Full support is now added by 6cabbcec8c229bf09dfa13b2b68eb0ab9f1030c8

That's great. Thanks a lot!

int main()
{
    cmsSetLogErrorHandlerTHR(nullptr, log);
    cmsContext ctx = cmsCreateContext(nullptr, nullptr);

    cmsCIExyY D65xyY;
    cmsWhitePointFromTemp( &D65xyY, 6504);
    cmsHPROFILE oklabProfile = cmsCreateLab4Profile(&D65xyY);
    setupMetadata(ctx, oklabProfile);

    // Strict transformation between LAB and XYZ
    cmsSetDeviceClass(oklabProfile, cmsSigColorSpaceClass);
    cmsSetColorSpace(oklabProfile, cmsSigMCH3Data);
    cmsSetPCS(oklabProfile, cmsSigMCH3Data);
    cmsSetHeaderRenderingIntent(oklabProfile, INTENT_RELATIVE_COLORIMETRIC);

    const double M_D65_D50[] =
    {
       1.047886, 0.022919, -0.050216,
       0.029582, 0.990484, -0.017079,
      -0.009252, 0.015073,  0.751678
    };

    const double M_D50_D65[] =
    {
         0.955512609517083, -0.023073214184645,  0.063308961782107,
        -0.028324949364887,  1.009942432477107,  0.021054814890112,
         0.012328875695483, -0.020535835374141,  1.330713916450354
    };

    cmsStage* D65toD50 = cmsStageAllocMatrix(ctx, 3, 3, M_D65_D50, NULL);
    cmsStage* D50toD65 = cmsStageAllocMatrix(ctx, 3, 3, M_D50_D65, NULL);

    const double M_D65_LMS[] =
    {
        0.819022437996703, 0.3619062600528904, -0.1288737815209879,
        0.03298365393238847, 0.9292868615863434, 0.03614466635064236,
        0.04817718935962421, 0.2642395317527308, 0.6335478284694309
    };

    const double M_LMS_D65[] =
    {
        1.226879875845924, -0.5578149944602171, 0.2813910456659647,
       -0.04057574521480083, 1.112286803280317, -0.07171105806551635,
       -0.07637293667466008, -0.42149333240224324, 1.5869240198367818
    };

    cmsStage* D65toLMS = cmsStageAllocMatrix(ctx, 3, 3, M_D65_LMS, NULL);
    cmsStage* LMStoD65 = cmsStageAllocMatrix(ctx, 3, 3, M_LMS_D65, NULL);

    const double RootParameters[] = {1.0 / 3.0, 1, 0, 0};
    const double CubeParameters[] = {3.0, 1, 0, 0};

    cmsToneCurve* Root = cmsBuildParametricToneCurve(ctx, 6, RootParameters);
    cmsToneCurve* Cube = cmsBuildParametricToneCurve(ctx, 6, CubeParameters);

    cmsToneCurve* Roots[3] = { Root, Root, Root };
    cmsToneCurve* Cubes[3] = { Cube, Cube, Cube };

    cmsStage* NonLinearityFw = cmsStageAllocToneCurves(ctx, 3, Roots);
    cmsStage* NonLinearityRv = cmsStageAllocToneCurves(ctx, 3, Cubes);

    const double M_LMSprime_OkLab[] =
    {
        0.21045426830931396, 0.7936177747023053, -0.0040720430116192585,
        1.9779985324311686, -2.42859224204858, 0.450593709617411,
        0.025904042465547734, 0.7827717124575297, -0.8086757549230774
    };

    const double M_OkLab_LMSprime[] =
    {
        1.0, 0.3963377773761749, 0.21580375730991364,
        1.0, -0.10556134581565857, -0.0638541728258133,
        1.0, -0.08948417752981186, -1.2914855480194092
    };

    cmsStage* LMSprime_OkLab = cmsStageAllocMatrix(ctx, 3, 3, M_LMSprime_OkLab, NULL);
    cmsStage* OkLab_LMSprime = cmsStageAllocMatrix(ctx, 3, 3, M_OkLab_LMSprime, NULL);

    //LAB -> XYZD50
    cmsPipeline* AToB = cmsPipelineAlloc(ctx, 3, 3);
    cmsPipelineInsertStage(AToB, cmsAT_END, cmsStageDup(OkLab_LMSprime));      // Matrix = LAB -> LMS
    cmsPipelineInsertStage(AToB, cmsAT_END, cmsStageDup(NonLinearityRv));
    cmsPipelineInsertStage(AToB, cmsAT_END, cmsStageDup(LMStoD65));            // Matrix = LMS -> XYZ
    cmsPipelineInsertStage(AToB, cmsAT_END, cmsStageDup(D65toD50));            // Matrix = D65 -> D50
    cmsWriteTag(oklabProfile, cmsSigDToB0Tag, AToB);

    //XYZD50 -> LAB
    cmsPipeline* BToA = cmsPipelineAlloc(ctx, 3, 3);
    cmsPipelineInsertStage(BToA, cmsAT_END, cmsStageDup(D50toD65));            // Matrix = D50 -> D65
    cmsPipelineInsertStage(BToA, cmsAT_END, cmsStageDup(D65toLMS));            // Matrix = XYZ -> LMS
    cmsPipelineInsertStage(BToA, cmsAT_END, cmsStageDup(NonLinearityFw));
    cmsPipelineInsertStage(BToA, cmsAT_END, cmsStageDup(LMSprime_OkLab));      // Matrix = LMS -> LAB
    cmsWriteTag(oklabProfile, cmsSigBToD0Tag, BToA);

    cmsPipelineFree(AToB);
    cmsPipelineFree(BToA);

    cmsFreeToneCurve(Root);
    cmsFreeToneCurve(Cube);

    if (!cmsMD5computeID(oklabProfile)) {
        std::cerr << "Failed MD5 computation" << std::endl;
        return -1;
    }

    const std::string profileName{"oklab.icc"};

    if (!cmsSaveProfileToFile(oklabProfile, profileName.c_str())) {
        std::cerr << "CANNOT WRITE PROFILE" << std::endl;
        return -2;
    }
}

Hi, @mm2, I have created an ICC profile for oklab in this situation, but I found that when a or b is negative, when using cmsCreateTransform to convert oklab to an integer colour space, such as rgb8 or rgb16, the result of the conversion seems to be incorrect (a and b seem to be clipped to 0 before the conversion) . But when converting to floating point such as rgbF16 or rgbF32 the result is correct, could the error be caused by Optimisation? Thanks a lot!

You are including only BtoD /DToB tags which according the spec are to be used as a complement specialized on floats.  You should use AtoB/BToA tags and if you want more precision on floats then also add DToB/BToD . If you could use unstable, 2.16 has an OkLab implementation on cmsCreate_OkLabProfile(). You can look at the code too.

Okay, thank you so much!

You are including only BtoD /DToB tags which according the spec are to be used as a complement specialized on floats. You should use AtoB/BToA tags and if you want more precision on floats then also add DToB/BToD . If you could use unstable, 2.16 has an OkLab implementation on cmsCreate_OkLabProfile(). You can look at the code too.

You are including only BtoD /DToB tags which according the spec are to be used as a complement specialized on floats. You should use AtoB/BToA tags and if you want more precision on floats then also add DToB/BToD . If you could use unstable, 2.16 has an OkLab implementation on cmsCreate_OkLabProfile(). You can look at the code too.

Well, I tried to create the oklab icc profile in krita using cmsCreate_OkLabProfile(), but since krita uses cmsSaveProfileToMem, it doesn't seem to be able to do it successfully, which is really sad.

This particular profile cannot be saved. The ICC file format does not support the combination of stages in the pipeline. It only works as a built-in.

This particular profile cannot be saved. The ICC file format does not support the combination of stages in the pipeline. It only works as a built-in.

Okay, I got it. Thank you.

Hi, @mm2, I created the oklab profile using A but it doesn't seem to convert to rgb16 correctly, here's the code I'm testing with:
#define TYPE_LABA_F32 (FLOAT_SH(1)|COLORSPACE_SH(PT_MCH3)|EXTRA_SH(1)|CHANNELS_SH(3)|BYTES_SH(4))

    cmsUInt16Number rgb[3];
    cmsFloat32Number lab[3];

    cmsHPROFILE labProfile = cmsCreate_OkLabProfile(NULL);
    cmsHPROFILE rgbProfile = cmsCreate_sRGBProfile();

    cmsHTRANSFORM hBack = cmsCreateTransform(labProfile, TYPE_LABA_F32, rgbProfile, TYPE_RGB_16, INTENT_RELATIVE_COLORIMETRIC, 0);
    cmsHTRANSFORM hForth = cmsCreateTransform(rgbProfile, TYPE_RGB_16, labProfile, TYPE_LABA_F32, INTENT_RELATIVE_COLORIMETRIC, 0);

    cmsCloseProfile(labProfile);
    cmsCloseProfile(rgbProfile);

    rgb[0] = 0;
    rgb[1] = 0;
    rgb[2] = 65535;

    cmsDoTransform(hForth, rgb, &lab, 1);
    cmsDoTransform(hBack, lab, &rgb, 1);

    cmsDeleteTransform(hBack);
    cmsDeleteTransform(hForth);

    std::cout<<rgb[0]<<' '<<rgb[1]<<' '<<rgb[2]<< std::endl;

    //Target results: 0 0 65535
    //Actual results: 22025 22020 22012

Thanks for reporting. This seems not related to OkLab but on transforms going float->integer. If you use floats on rgb the roundtrip works well, so it is not the profile. I will file a bug regarding this issue, not limited to OkLab.
See below the code that works fine
`
#define TYPE_LABA_F32 (FLOAT_SH(1)|COLORSPACE_SH(PT_MCH3)|EXTRA_SH(1)|CHANNELS_SH(3)|BYTES_SH(4))
cmsFloat32Number rgb[3];
cmsFloat32Number lab[4];

cmsHPROFILE labProfile = cmsCreate_OkLabProfile(NULL);
cmsHPROFILE rgbProfile = cmsCreate_sRGBProfile();

cmsHTRANSFORM hBack = cmsCreateTransform(labProfile, TYPE_LABA_F32, rgbProfile, TYPE_RGB_FLT, INTENT_RELATIVE_COLORIMETRIC, 0);
cmsHTRANSFORM hForth = cmsCreateTransform(rgbProfile, TYPE_RGB_FLT, labProfile, TYPE_LABA_F32, INTENT_RELATIVE_COLORIMETRIC, 0);

cmsCloseProfile(labProfile);
cmsCloseProfile(rgbProfile);

rgb[0] = 0;
rgb[1] = 0;
rgb[2] = 1.0f;

cmsDoTransform(hForth, rgb, &lab, 1);
cmsDoTransform(hBack, lab, &rgb, 1);

cmsDeleteTransform(hBack);
cmsDeleteTransform(hForth);

`

Okay, that's great. Thanks！

It is now fixed by 4c0c66e7109a903c470159ecd3d753e8a4d56c79, but I have to check it more carefully.

It is now fixed by 4c0c66e, but I have to check it more carefully.

Now it works fine in krita! Really thank you for your help!


add support for Gatsby 5.x

Add support for Gatsby 5.x and deprecate the Helmet function (also deprecated upstream)
fixes: https://github.com/microapps/gatsby-plugin-react-i18next/issues/163

@gdams seems there is an issue with gatsby-plugin-sitemap
https://stackoverflow.com/questions/72250191/error-siteurl-does-not-exist-on-sitemetadata-in-the-data-returned-from-the
Could you please take a look?

@gdams seems there is an issue with gatsby-plugin-sitemap

Looking


Change Comformance test to whole Conformance tests when all are selected

In most cases, we'd like to run the whole Conformance tests for K8s compatibility verification, since there is no other tests using '--e2e-all', simply enable the whole Conformance tests when all are selected.

/skip-all


net/http/pprof: profiling isn't cancelled when the client hangs up

go version go1.5.2 darwin/amd64

If I use go tool pprof to collect a profile from a server running the net/http/pprof endpoints then kill the HTTP client before the profile is completed, the server keeps profiling for the full 30s. This means that any further attempts to collect profiles during this time period will fail with 500 Internal Server Error because it multiple CPU profiles cannot be collected simultaneously.
It seems that the server should detect termination of the TCP connection and call pprof.StopCPUProfile in: https://golang.org/src/net/http/pprof/pprof.go

Sent https://go-review.googlesource.com/18283


Show stashes

Show if there are changes in stashes in the given repositories. Developers might use that information to quickly see whether there are changes they have to care about or not.

The current stash sign, causes issues with grrui:


Added link to an initial data catalog for explore + download

To assist in the registration and discovery of data, we configured a Prep Open Data Site. This PR adds a simple link from the prototype to explore this catalog.

Hey @ajturner,
Awesome thanks for doing this work, we should definitely build this in.
We may need to do some additional work down the road in terms of service integration and maintaining a consistent user experience. We can discuss next week.
Best,
F

@fgassert the PR adds this capability. Do you want to merge it and we can update the UX in subsequent PR?

Merge away

On May 31, 2016, at 5:10 PM, Andrew Turner<EMAIL_ADDRESS>wrote:
@fgassert the PR adds this capability. Do you want to merge it and we can update the UX in subsequent PR?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

LGTM
On Tue, May 31, 2016, 2:16 PM Francis Gassert<EMAIL_ADDRESS>wrote:

Merged #45 https://github.com/PReP-Team/prep-prototype/pull/45.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/PReP-Team/prep-prototype/pull/45#event-677624877, or mute
the thread
https://github.com/notifications/unsubscribe/AAcNrzdGYxuZ-w_b2wu5KzgEoPTVLDTyks5qHKUvgaJpZM4Iqp5W
.


Background color does not change in user-made levels

Hello, I'm experiencing an issue with making levels with this mod. Whenever I play my levels that have color triggers in them, they don't work, and the background constantly stays the color it was at the start of the level. This does not seem to occur in main levels. Here is my list of mods:

BepInEx
6dash 0.4.0
3DashTools 0.3.0
3DashCustomMusic 0.1.1 (Though removing this mod doesn't solve the issue)
BetterEditor (Again, the issue persists when this mod is removed)
Please fix when you can!

Hello, does the bug occur without 3DashTools installed?

I tested it, and it does appear to persist without 3DashTools installed. Strangely, it also persists when 6dash is uninstalled, so it could be a problem with BepInEx. The only solution I can think of is to completely change the color trigger code somehow...

bepinex doesn't do anything by itself
make sure you removed the patcher (in BepInEx/patchers) when uninstalling 6dash as well

Oh yeah, that fixed it, it seems that it's a 6dash issue.

transferring the issue to the 6dash repo then


Update for botkit events API?

botkit started supporting Events API late last year. Would be nice to run in beepboop using that.
https://github.com/howdyai/botkit/releases/tag/v0.4.2

Yes, this is sorely needed.


Support generating JWT tokens using cli

Is your feature request related to a problem? Please describe.

Trying to talk to Azure EventHub and due to reasons I need to have a JWT token. Today I can generate it by using the oauth2 endpoint as described in: https://docs.microsoft.com/en-us/rest/api/eventhub/get-azure-active-directory-token#use-postman-to-get-the-azure-ad-token.
I need to generate this JWT token from kubernetes and I would like to use aadpodidentity to be able to get this token.
Describe the solution you'd like

Through the CLI be able to get a JWT token even if az login -i is used.
Another option could be to have azure eventhub sub command to be able to give a JWT token.
Describe alternatives you've considered

Thought I could perform a az login -i but it doesn't create the accessTokens.json file, so I can't steel the JWT token from there.
I have also tried to use az rest.
az rest --headers 'Content-Type=application/x-www-form-urlencoded' --body '{"grant_type":"client_credentials","client_id":"my-client-id","client_secret":"so-much-secret","resource":"https://eventhubs.azure.net"}' -u https://login.microsoftonline.com/<tenant-id>/oauth2/token

But this gives me the following error:
Get Token request returned http error: 400 and server response: {"error":"invalid_resource","error_description":"AADSTS500011: The resource principal named https://login.microsoftonline.com was not found in the tenant named
Even if it would have worked I still would have needed to get the client_secret from a azure key vault and it's nothing that I would like to do.
Additional context

I'm trying to build a fluxcd notification-controller integration with Azure EventHub that supports both SAS and JWT token.
Sadly I won't be able to add any other input variables than a JWT token, eventhub name and eventhub namespace.
And that is why I need to use a pure JWT token.

@jiasli for awareness

There is a command for this and it works with az login -i
az account get-access-token

My bad, I will close this issue.


Fixed #35295 -- Used INSERT with multiple rows on Oracle 23c.

ticket-35295

.

The current patch fails on field_defaults.tests.DefaultTests.test_bulk_create_mixed_db_defaults_function:
django.db.utils.DatabaseError: ORA-01797: this operator must be followed by ANY or ALL

It seems that wrapping in parentheses confuses Oracle, except for the set operator in statements like:
TO_NUMBER(CASE WHEN :arg1 > (:arg2) THEN :arg3 ELSE :arg4 END))

The current patch fails on field_defaults.tests.DefaultTests.test_bulk_create_mixed_db_defaults_function:
django.db.utils.DatabaseError: ORA-01797: this operator must be followed by ANY or ALL

It seems that wrapping in parentheses confuses Oracle, expect for the set operator in statements like:
TO_NUMBER(CASE WHEN :arg1 > (:arg2) THEN :arg3 ELSE :arg4 END))

Fixed.

Thanks both for reviews :+1:


OCPBUGS-18024: Set Arch to amd64 for HCP NodePool Create

What this PR does / why we need it:
Sets Arch to amd64 for HCP NodePool Create so the InstanceType is chosen through the HCP CLI.
Which issue(s) this PR fixes:
Fixes OCPBUGS-18024
Checklist

[x] Subject and description added to both, commit and PR.
[x] Relevant issues have been referenced.

/area cli

/lgtm

/approve

/test e2e-kubevirt-aws-ovn


Questions from a newbie

Some of these questions may be straightforward but I've never done in game ui or used imgui, and I'm working on my first rust project, so it's all new to me.

I've been reading through the example code try to get a handle on how things work. I see a lot of these sorts of show calls in the example: .show(ui, |ui| self.painting.ui(ui)); Why take the ui object and also a lambda taking a ui object? I started digging to try and see if the ui just gets passed in later but it looks like child ui's are getting passed in?

I guess more generally if the rendering isn't immediate mode, is each frame building one big call-list/vertex-buffer/etc from scratch, or is it somehow figuring out what has or hasn't changed between frames and only sending stuff to the gpu that's different?

Why is a bunch of the core app state serializable? For example the ExampleApp struct. I noticed state seems to be preserved across refreshes if you only manipulate the Examples window -- but if you open any other window than it resets the whole gui to its original state on refresh -- and there's an every frame call to save_memory, but it looks like ultimately that is is only going to save the Memory struct, so I'm not sure how that would interact with other application state.

Why take the ui object and also a lambda taking a ui object?

in most cases the lambda is given a different Ui instance, or some setup/teardown is performed on the Ui before calling the lambda

is each frame building one big call-list/vertex-buffer/etc from scratch

yes

Why is a bunch of the core app state serializable?

the web wasm example stores the state in local storage, and the glium example code stores it in a json file. it is just nice to be able to continue where you left off.
I might switch out serde for nanoserde though.


#7775: allow team / system admin to convert a channel to private

Summary
This PR contains client side change for #7775. It adds a dropdown item in channel header that allows team or system admin to convert a public channel to private
Corresponding server side PR:
https://github.com/mattermost/mattermost-server/pull/7950
Ticket Link
[Please link the GitHub issue or Jira ticket this PR addresses.]
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

[x] Ran make check-style to check for style errors (required for all pull requests)
[X] Ran make test to ensure unit and component tests passed
[x] Added or updated unit tests (required for all new features)
[X] Has server changes (please link)
[ ] Has redux changes (please link)
[X] Has UI changes
[X] Includes text changes and localization file (.../i18n/en.json) updates
[ ] Touches critical sections of the codebase (auth, posting, etc.)

Setup Test Server label detected. Spinmint test server created if build succeeds (checks pass and no conflicts with base branch).

Spinmint test server created at: http://i-0a45d8b23773b127a.spinmint.com
Test Account 1: Email<EMAIL_ADDRESS>| Password: passwd
Test Account 2: Email<EMAIL_ADDRESS>| Password: passwd
Instance ID: i-0a45d8b23773b127a

Setup Test Server label detected. Spinmint test server created if build succeeds (checks pass and no conflicts with base branch).

Spinmint test server created at: http://i-0dc728d2d203903bc.spinmint.com
Test Account 1: Email<EMAIL_ADDRESS>| Password: passwd
Test Account 2: Email<EMAIL_ADDRESS>| Password: passwd
Instance ID: i-0dc728d2d203903bc

Hello all,
I have two questions :

what is the current status of this PR ? Merging being blocked means that there is a problem with it ? SHould I/ Can I help in any way ?
without this feature, is it ok for now for a mm admin to just change the value of the "Type" field in database "Channels" to "P" to convert a channel to a private one? Are there dependencies anywhere else ?

Thanks a lot, and sorry for the dumb questions, I am very new to all this collaborative thing.

This is queued for PR review.
Technically, changing Type field to P will convert channel into private one but it's not recommended since there are several key items that being bypassed like validation, log for audit, system message that the channel has been changed, etc.

I see. please let me know in case change is needed. I was not aware of these complications.

@liusy182 What are the complications ? Can I help ?

@saturninoabril can you please help with some technical guidance so we don't run into any of the issues you described?

Spinmint test server destroyed

@esethna @liusy182 Sorry if I confused everyone. The comment I made above is a response to @gfra54 about directly modifying the field on the database and not about the changes/implementation on this PR.
Please proceed with PM review. Thanks!

@liusy182 anything we can help with on this PR?

@esethna i have pushed a change a few weeks ago. Looks like I missed to see merge conflicts. I will try to pick this up in the upcoming week est. before 21Feb. Sorry too busy on my schedule.

hey @liusy182! Let us know if we can help with the merge conflicts? I understand you're busy, but just wanted to offer help.
Huge appreciation for your work thus far.

hi @jasonblais sorry it turns out i didn't get time to work on the merge. Could someone help on it? Thank you ! :)

@jasonblais @liusy182 Let me fix merge conflicts.

Setup Test Server label detected. Spinmint test server created if build succeeds (checks pass and no conflicts with base branch).

Spinmint test server created at: http://i-0eb559442ef34aac9.spinmint.com
Test Admin Account: Email<EMAIL_ADDRESS>| Password: user-0
Test User Account: Email<EMAIL_ADDRESS>| Password: user-1
Instance ID: i-0eb559442ef34aac9

@jasonblais (Maybe worth a separate ticket) Do we need system message that the public channel has been converted to private channel?

@liusy182 Really great work here.
I found a few minor improvements/fixes that we could do here. Let us know if you need any help, or if you don't have time for the updates, and we'd be glad to help.

Focus not on "Yes, convert to private channel" button when dialog opens

Click "Convert to private channel" channel menu option.
Hit ENTER on the dialog that opens
observed: No action taken
expected: "Yes, convert to private channel" action taken

Part 3 of the issue (https://github.com/mattermost/mattermost-server/issues/7775) proposed adding a diagnostic event for telemetry each time this feature is used. This should be a two-line change similar to https://github.com/mattermost/platform/pull/5516/files#diff-4821c248760929f278cfda4b8c0e1fa3.

I agree with @saturninoabril that we should post a system message when the channel is converted to a private channel. We could simply re-use the existing string here: https://github.com/mattermost/mattermost-server/blob/master/i18n/en.json#L215

I was able to join a channel after it was made private

User A: Create a new public channel, call it "Channel A"
User A: Converts "Channel A" to private
User B: Clicks the "More..." option below public channels, and finds "Channel A" as a channel he can join
observed: joining a channel works
expected: "Channel A" should not be in the list of available public channels to join

hi @jasonblais could someone help to proceed from here? I don't expect to be able to pick this up in the upcoming 1~2 months. thank you :)

Thanks @liusy182, we have queued this for one of our core developers to take over. Really appreciate your help here!

Spinmint test server destroyed

@jasonblais

Done
Done
Submitted PRs at server and redux

https://github.com/mattermost/mattermost-server/pull/8501
https://github.com/mattermost/mattermost-redux/pull/432

Can't repro (will take a look again after the server and redux PRs get in)

(Also, this PR needs to update redux commit after merging corresponding PR)
Added @enahum for dev review since I did the latest update to this PR.

Thanks @saturninoabril! I'll re-test once server and redux PRs are merged.
Requesting review from @grundleborg from the permissions team.
@enahum Ticket for RN app - it was only added for the webapp for now given there isn't a UI design for it https://mattermost.atlassian.net/browse/MM-9951
@enahum An admin can convert a private channel to be public, but we didn't want to allow this in the UI for now, given the risk of sharing private/confidential info from that private channel.

Setup Test Server label detected. Spinmint test server created if build succeeds (checks pass and no conflicts with base branch).

Spinmint test server created at: http://i-05cde815fd44a1609.spinmint.com
Test Admin Account: Username: sysadmin | Password: sysadmin
Test User Account: Username: user-1 | Password: user-1
Instance ID: i-05cde815fd44a1609

@jasonblais @esethna Server and redux PRs were merged recently and this PR has been rebased to latest master (with corresponding commit on redux). This is now ready for PM review.

Spinmint test server destroyed

Thanks @enahum!
Added ChannelPermissionGate to the 'Convert to Private' option with permission of Permissions.MANAGE_PUBLIC_CHANNEL_PROPERTIES.
This now ready for PM review.

Setup Test Server label detected. Spinmint test server created if build succeeds (checks pass and no conflicts with base branch).

Spinmint test server created at: http://i-02a06647d46eb33f4.spinmint.com
Test Admin Account: Username: sysadmin | Password: sysadmin
Test User Account: Username: user-1 | Password: user-1
Instance ID: i-02a06647d46eb33f4

@saturninoabril I think there is a permissions issue where this is appearing for all users. It should be limited to system admins only. Looks really good otherwise.

Thanks @esethna! This should be ready for PM review.

Spinmint test server destroyed

Setup Test Server label detected. Spinmint test server created if build succeeds (checks pass and no conflicts with base branch).

Spinmint test server created at: http://i-04f2db6e3fdf163bd.spinmint.com
Test Admin Account: Username: sysadmin | Password: sysadmin
Test User Account: Username: user-1 | Password: user-1
Instance ID: i-04f2db6e3fdf163bd

Spinmint test server destroyed

Unassigning myself since there's already 3 other people reviewing this

Thanks @grundleborg!  Submitted PRs for server and redux store

https://github.com/mattermost/mattermost-server/pull/8655
https://github.com/mattermost/mattermost-redux/pull/464


cluster detail implementation

added cluster details page with host and pool/volume list (using existing controller and html page for listing)
added create page for pool/volume

Signed-off-by: kamleshKumarVerma<EMAIL_ADDRESS>

@gnehapk @cloudbehl Please review it.


Configure travis CI build

Travis is switched on and the config file had been here before we forked the repo. Did you notice anything you'd like changed in the config?


The button wont let me in because it will glitch the site (real)

Which button? Also, please provide more clarification (by means of a screenshot or putting something in the description), as I have no clue what you are referring to.
My only guess is that this may be a more modern version of issue #594
Please provide more information.

When i press enter it will glitch and not work.

From: ImaginaryNeon @.>
Sent: Tuesday, February 28, 2023 1:39 PM
To: sm64js/sm64js @.>
Cc: James Fipps @.>; Author @.>
Subject: Re: [sm64js/sm64js] The button wont let me in because it will glitch the site (real) (Issue #773)
Which button? Also, please provide more clarification (by means of a screenshot or putting something in the description), as I have no clue what you are referring to.
My only guess is that this may be a more modern version of issue #594https://nam10.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fsm64js%2Fsm64js%2Fissues%2F594&data=05|01|jfipps8651%40ccsstudent.net|4f1c74dece9c40f367bd08db19bb2159|ed345ec2661b4eebb2efc197a473cd66|1|0|638132063746754294|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=3lFpgJhZ8Xjy9QYq%2FHsymTDB%2FpynI6rpHVCCVtK4xAA%3D&reserved=0
Please provide more information.
—
Reply to this email directly, view it on GitHubhttps://nam10.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fsm64js%2Fsm64js%2Fissues%2F773%23issuecomment-1448678160&data=05|01|jfipps8651%40ccsstudent.net|4f1c74dece9c40f367bd08db19bb2159|ed345ec2661b4eebb2efc197a473cd66|1|0|638132063746754294|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=kaS09v6hqr1xixaYeisj5fNQ53VC1%2BWg6xMXiQNHfbA%3D&reserved=0, or unsubscribehttps://nam10.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FA6E76WOXRZAR2R2AZY3ZEUTWZZA6FANCNFSM6AAAAAAVJNPWQM&data=05|01|jfipps8651%40ccsstudent.net|4f1c74dece9c40f367bd08db19bb2159|ed345ec2661b4eebb2efc197a473cd66|1|0|638132063746754294|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=4NdvCzKfcVmr9fz4rlR9okN3ho06xch63hzLlVWM7Nw%3D&reserved=0.
You are receiving this because you authored the thread.Message ID: @.***>

Please take a screenshot of how it "glitches" so that way I know what it looks like.
Is there text in weird spots?
Does everything look like it's moving everything to the center?
Is it something else entirely?


Promotion release 1.6.22

Promotion release 1.6.22

/ok-to-test sha=945ad27

/ok-to-test sha=0da092b


Content-Length for GET requests with an empty body

...is zero. Even though the HTTP spec doesn't forbid sending a body in a
GET request, it's generally not recommended to send a body via GET. Some
servers behave oddly with a Content-Length of 0 on a GET request since
it seems there are related security vulnerabilities (IIS, I believe)?
The problem I have is basically that Terremark is denying requests because they have a Content-Length: 0 header being passed in GET requests with no body.
This is what they said:
---- 8< ----
We do not expect any content when the client is making a “GET”. Content-length in a GET method is not explicitly prohibited. But message-body (a property which Content-length is based upon) is prohibited in GET requests. So, I would say, do not include Content-Length header for “GET” requests.
---- 8< ----
http://fixunix.com/tcp-ip/66198-http-rfc-related-question-content-length-0-get-request.html
I can provide more detail on how it fails if you need it, but basically I just want to start a discussion here.
Can we just kill the Content-Length:0 for GET requests? It gets set automatically in Excon, and bottom line is I need a way to ensure it doesn't get set.

So does this pull request make sense then, or should we be doing it a different way...?

@shaiguitar grumble, grumble.  For being something that we all rely on, I have a terrible time actually reading the damnable spec.  It definitely indicates when it is required to include it, but it isn't particularly clear on when it is omitable.  I think that we can simplify your logic a bit though.  From my reading of the spec, it is required for anything that includes a message body, but if it doesn't it isn't clear exactly.  But I presume this means that you should be able to just do the latter part of the check, ie params[:body].to_s.empty?.  But really a nil check is probably more appropriate (there might be weird occasions where sending a 0 length body was actually what you wanted).  All that being said, upon reviewing the code I think it is a bit weird anyway (I suspect that allowing an explicitly set content-length instead of calculating it will almost always be wrong, or at least wasted effort).  So perhaps the easiest thing would be to remove the wrapping if and the else clause from the case statement, so something like:
      case params[:body]
      when File
        params[:body].binmode
        params[:headers]['Content-Length'] = File.size(params[:body])
      when String
        if FORCE_ENC
          params[:body].force_encoding('BINARY')
        end
        params[:headers]['Content-Length'] = params[:body].length
      end
    end

I think that is simpler but should do what you want.  Thoughts?
See also:
http://www.w3.org/Protocols/rfc2616/rfc2616-sec14.html#sec14.13
http://www.w3.org/Protocols/rfc2616/rfc2616-sec4.html#sec4.4

Hey Wes, that seems perfect.

Should I submit a new pull request with that, or?

@shaiguitar if you have the time, yeah that would be great.  That way you can be immortalized and have credit for it since you did the leg work.

OK, so:
-POST still needs a Content-Length of 0 when the request is empty. I haven't checked for DELETE but it's possible too.
I added DELETE tests since I saw they were "missing" from the request method tests.
Using that snippet you suggested above, we'll still need some form of differentiating between GET and the rest anyhow. How about the pull request as it is now? Some other path?

@shaiguitar IES is for jerks, just saying...  I made some inline comments above to outline a couple small changes that I think should clean up the idea a bit.  Let me know if any of it doesn't make sense or doesn't end up working.  Thanks!

Fixed spelling mistake, changed the check to params[:body].nil below, and changed to casecmp. Tests all pass for me.

Released in 0.10.0.

Fast. Sweet, thanks Wes

By the way, any preference if all this was Sqaushed into one commit or this makes no difference to you? Wondering for future fog/excon contributions.

@shaiguitar I kind of prefer squashed, at least such that each commit is a whole unit of something (ie if two or more commits are changes of each other they should be squashed).  For things that aim at different areas, with different effects, separate commits are probably better.  Hope that makes sense.

Right, I wasn't aware you'd go ahead and merge and release it quite yet and that quickly. Next time I'll just sqaush while the discussion is in place or something. :)


Best wishes

I just noticed your statement
English is not my native language，cut a long story short
Sincerely thank you for the constant maintenance
Wish you good luck in the new year.

Congratulations to the author on everything going well in the New Year


.dj domains

Problem
There's no whois server registered to the IANA Route Database Zone for all .dj domains.
Conclusion
That makes all .dj domains fails.

Please report to http://www.nic.dj/whois.php for whois lookup