Update AWS dependenciess, remove vendor folder

What does this PR do?

Update dependencies:

github.com/aws/aws-lambda-go v1.11.1 -> v1.25.0
github.com/aws/aws-sdk-go v1.36.29 -> v1.40.2
github.com/aws/aws-lambda-go v1.11.1 -> v1.25.0

Remove the vendor directory that contained copies of dependencies. I am not sure if this directory was actually being used, as it was missing the vendor/modules.txt manifest file. Either way, we don't really need to vendor our dependencies for this library; we can build by directly downloading dependencies from their sources like we do for our other libraries.

Motivation
A community PR pointed out the need to upgrade github.com/aws/aws-xray-sdk-go. I decided to use this opportunity to update some other dependencies and clean up the vendor directory as well.
Testing Guidelines
Unit and integration tests.
Types of changes

[ ] Bug fix
[ ] New feature
[ ] Breaking change
[x] Misc (docs, refactoring, dependency upgrade, etc.)

Checklist

[x] This PR's description is comprehensive
[ ] This PR contains breaking changes that are documented in the description
[ ] This PR introduces new APIs or parameters that are documented and unlikely to change in the foreseeable future
[ ] This PR impacts documentation, and it has been updated (or a ticket has been logged)
[x] This PR's changes are covered by the automated tests
[ ] This PR collects user input/sensitive content into Datadog

Codecov Report

Merging #84 (d3ca177) into main (a0a402d) will increase coverage by 0.44%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main      #84      +/-   ##
==========================================
+ Coverage   82.45%   82.89%   +0.44%
==========================================
  Files          12       12
  Lines         644      725      +81
==========================================
+ Hits          531      601      +70
- Misses         89      100      +11
  Partials       24       24

Impacted Files
Coverage Δ

ddlambda.go
78.04% <0.00%> (-2.24%)
:arrow_down:

internal/trace/listener.go
59.32% <0.00%> (-1.79%)
:arrow_down:

internal/metrics/kms_decrypter.go
76.00% <0.00%> (-1.28%)
:arrow_down:

internal/metrics/time.go
66.66% <0.00%> (ø)

internal/metrics/batcher.go
100.00% <0.00%> (ø)

internal/metrics/context.go
100.00% <0.00%> (ø)

internal/wrapper/wrap_handler.go
100.00% <0.00%> (ø)

internal/metrics/processor.go
97.70% <0.00%> (+0.26%)
:arrow_up:

internal/metrics/listener.go
75.53% <0.00%> (+1.12%)
:arrow_up:

internal/metrics/api.go
90.00% <0.00%> (+1.32%)
:arrow_up:

... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a0a402d...d3ca177. Read the comment docs.


2022 0223 UI improvements

Use different string for todo and non-todo mode
Turn on TODO mode automatically if user enters TODO
render better when window is very narrow
import logseq libs so IDEs know what's going on

Thanks @benjaffe! Some comments:

I've done an update so package.json now has a conflict.
Actually in your IDE, if you open index.tsx, you will get the auto-completion since it applies to all the children.
Agree that the string should reflect differently. Will make the change since I am making other changes as well.
This may be quite confusing though! I got a little confused when I tried it.
Will look into using Tailwind for this as I hope to be a little consistent.

Thanks again!

Oh interesting, makes sense! I wonder if there's a way my IDE could know that from the start.
Awesome!
No worries... I'm ultimately interested in a way to toggle this without touching the mouse.
Sounds good. I haven't looked at Tailwind yet, but seems like an interesting system!

Will look into the mouse toggle bit!


docs: add JSDoc comments for TestUtils and TestRenderer

Description

Adds JSDoc comments for TestUtils and TestRenderer.
2 minor documentation fixes that I came across making the above changes

References
LUI-872

Testing
Read through the added comments and confirm they are understandable.
Optionally, in VSCode hover over any of the documented functions to see the comments in Intellisense.

Automation
n/a

Checklist

[x] all commented code has been removed
[x] any new console issues have been resolved
[x] code linter and formatter has been run
[x] test coverage meets repo requirements
[x] PR name matches the expected semantic-commit syntax

Sanity Tests Execution Failed.

Sanity Tests Execution Failed.

:tada: This PR is included in version @lightningjs/ui-components-test-utils-v1.3.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


local updates not reflected in master

I'm new to this and quite confused as to why my local updates are not reflected in the site
everytime I command "git add ." it tells me that my changes have already been updated and there is nothing to add/commit/push. as such, even when i create a new post and try to publish, it always tells me that the origin master is updated, when in fact has not and my post is not published.
i might have messed things up when i deleted files from my local repo and synced it to github. the changes are reflected when i jekyll serve localhost:4000 but NOT on the original website.
help!

Have you checked your .gitignore?

Just a thought. You mention "origin master". Did you mean "origin gh-pages"?

I keep getting this email:
The submodule jekyll-bootstrap was not properly initialized with a .gitmodules file. For more information, see https://help.github.com/articles/page-build-failed-missing-submodule.
gitignore seems to be fine though

Are you working on https://team-melbourne-rgsoc2015.github.io/?
Looks like it was forked from barryclark/jekyll-now rather than plusjade/jekyll-bootstrap. I'm not familiar with that repo, or how it differs.
Here's another user with the same issue (unresolved).
http://helloburgh.me/2015/03/09/gitmodules/
And here's a user who resolved the issue.
http://dsimidzija.github.io/programming/2014/02/15/jekyll-bootstrap-themes-and-github-pages/
Hope that helps. Last link looks promising?

Any update, @snjqi188?

@groundh0g i encountered this exact issue and inadvertently followed the process laid out here: http://dsimidzija.github.io/programming/2014/02/15/jekyll-bootstrap-themes-and-github-pages/
it worked for me. maybe consider adding a warning to the user if _theme_packages isn't included in their .gitignore when running a task in the :theme namespace?


merge from konsum-frontend-svelte,template-arlac77-github,template-svelte-app

package.json

fix(deps): add ^1.7.3 (dependencies.mf-hosting)
fix(deps): add ^1.0.61 (dependencies.npm-dep-graph)
chore(deps): add ^5.0.1 remove ^4.3.3 (devDependencies.ava)
chore(deps): add ^14.13.0 remove ^14.12.1 (devDependencies.stylelint)
chore(deps): add ^2.0.1 remove ^2.0.0 (devDependencies.testcafe)
chore(package): add examples (pkgbuild.groups)

.github/workflows/browser_ci.yml

chore: add ubuntu-latest (jobs.test.runs-on)

:tada: This PR is included in version 1.34.10 :tada:
The release is available on:

npm package (@latest dist-tag)
v1.34.10
GitHub release

Your semantic-release bot :package::rocket:


Visible focus

Drafted preliminary documentation for visible focus standards.

wow Willa made a PR!!! Looks nice!
I am curious about how to document in design-toolkit/docs/_sections
I see some files are .md some are .html

@ktp242 please approve or request changes to this PR.

Do we have a convention for documentation? Should we use .md or .html?

It doesn't matter too much because the rendering engine will pick up either and correctly generate the file we want. But, for consistency, we should pick on or the other. But, there is no convention for regarding the type of file for this repo yet so that can be settled later.

I think its best to put any conventional documentation in a .md file, where there are .html files those particular files are heavy w/ html / js / css examples.
To @EdwinGuzman's point. The convention should be, as such. Basic documentation should be in a .md file and but if there are code examples, we should use .html files. Hope that clears up any questions.

@ricardoom I like your approach! Thanks for the answer. We can definitely settle it later, but I just felt I need to ask for clarifying :-)

@wlla feel free to merge whenever you want.


VScode creates .vscode inside user-dir on windows.

Does this issue occur when all extensions are disabled?: Yes

VS Code Version: 1.80.0
OS Version: Windows 11 (22H2<PHONE_NUMBER>)

VScode creates config folders inside the userdir (i.e. %homepath%) on Windows 11 even if in portable mode. Config folders directly inside the userdir are non-standard on Windows. The configuration should be stored inside the data folder when in portable mode and inside AppData when not portable.
This might be related to https://github.com/microsoft/vscode/issues/181017
Steps to Reproduce:

Configure VScode in portable mode according to https://code.visualstudio.com/docs/editor/portable
Run VScode

Expected result:
All settings should be stored in x:...\vscode_folder\data
Actual result:
.vscode and .config folders get created inside the user-dir i.e.  %homepath%/.vscode; %homepath%/.config.

Thanks for creating this issue! It looks like you may be using an old version of VS Code, the latest stable release is 1.80.0. Please try upgrading to the latest version and checking whether this issue remains.
Happy Coding!

Updated version from 1.80 to 1.80.0. :-/

Configure VScode in portable mode according to https://code.visualstudio.com/docs/editor/portable
Run VScode
Expected result:
All settings should be stored in x:...\vscode_folder\data

I followed these steps and extensions and user-data got created in the data folder as mentioned in the portable mode docs

Are you seeing differently? If so can you please explain how you set up the portable mode?

Hi, Thanks for picking this up. I am not talking about the user-data from the data folder. That works fine. I am talking about the additional folders being created inside the user home directory (i.e.  %homepath%), which should instead be created in the user-data from the data.
In the img attached .vscode and .config should be somewhere in the data  folder (possibly in  user-data), but definitely not next to Documents, AppData, etc. in the user home directory.

I assume the data in this .vscode folder is machine specific or cache and nothing to do with the portability.

Inside .vscode  there is a cli folder (i.e. ./vscode/cli, hence the relation issue https://github.com/microsoft/vscode/issues/181017, I mentioned in the OP). In my case cli is empty, but the folder keeps getting recreated every time I start VScode. I was actually hoping that https://github.com/microsoft/vscode/pull/182102 would move this into the proper user-data of VScode, but currently the "user data dir" refered there seems to point to the OS's user dir.

Thanks for that last piece of info @meehien.

Duplicates https://github.com/microsoft/vscode/issues/184646


DRM Video player support for windows Desktop

Use case
Hello, Guys.
Wanted to know if there are any current plans on developing or extending the support of flutter's default video player to work with windows desktop applications.

I can see that windows is not marked as supported. Also, in current version.. can we play DRM encrypted videos ?
Needed to know if there are any such plans in the near future.
Proposal
I am looking for a cross platform video player solution (Android, IOS and windows applications) with DRM support. I could see that there is https://pub.dev/packages/media_kit .. but does not have a DRM support.

Windows support is being tracked in https://github.com/flutter/flutter/issues/37673
DRM support is being tracked in https://github.com/flutter/flutter/issues/24923
Kindly follow up in the issues linked above for updates.
Closing from here as these feature requests are being tracked in other issues.


Problem with MakeLMDB - always uses first pre-processed data set

After completing training on the AN4 data set, I can't seem to get past the pre-processing step for the LibriSpeech data. No matter what arguments I provide or hard-code in MakeLMDB.lua, it keeps generating the LMDBs for the AN4 test and training sets (identical md5sums).
I've yet to test this out (and my Torch programming skills are rudimentary to say the least) but I think the problem might be in the second line of the 'createLMDB' function (in MakeLMDB.lua):
local sortIdsPath = 'sort_ids_'.. id .. '.t7' -- in case of crash, sorted ids are saved
I think what's happening is it's finding "sort_ids_test.t7" and "sort_ids_train.t7" in the root folder. This causes it to skip the if statement and fall through to the else statement:
vecs = torch.load(sortIdsPath)
The result being that it reloads the AN4 sorted ID paths but still uses the lmdbPath argument supplied by the user. So it just regenerates the same lmdb just in a different folder. Hilariously, if the user doesn't notice, they'll end up getting some really good WER and CER scores believing that all their training is paying off, when they're just massively over-fitting :)
Two easy ways to deal with this:

Just add a line in the documentation reminding people to delete the 'sort_ids_*.t7' files between pre-processing runs. Might be a bit of a hack...

Add a line of code at the bottom of the (createLMDB function? I think?) to delete these files as they're no-longer needed after successful pre-processing (I think?)

Just confirming that the above is correct. After deleting the sort_ids files (and the new lmdb directory) it's now pre-processing the new data set.

Sorry I was late to this and I've actually ran into the same issue.  I like the idea of deleting them after usage, I'll get to this as soon as I can! Thanks so much @markmuir87 and awesome display picture :D

No problemo @SeanNaren , glad to help. Thanks for sharing such an awesome ML model which, for my money, is the 'openface' of speech recognition :)

Removed those pesky sort ids for now in this!


💭 Is there a way to get the zoom thresholds where a multi-cam device switches between physical devices?

Question
Hi, apologies if this has already been asked, but I couldn't find it when searching or in the docs.
Is there a way to get the zoom levels at which a multi-cam device transitions between the physical cameras? For instance, how can we tell where the transition point from the wide angle to the ultra wide angle camera is?
What I'm looking for I guess would be something like:
const ranges = {
  ultraWideAngleRange: [0.5, 2],
  wideAngleRange: [2, 8],
  telephotoRange: [8, 128]
}

function switchToTelephoto() {
  camera.zoom = ranges.telephotoRange[0];
}

For context, we're trying to add some zoom buttons, much like those in the stock iOS camera, e.g. to set the zoom to 0.5x, 1x, 2x, 3x etc. I can't really find a way to do this with the current APIs, we can't find the zoom levels that these buttons should jump you to, and we can't find the real optical zoom level of each physical camera device (e.g. on the iPhone 16, the 3x button reads 5x in the stock UI; and it doesn't seem possible to detect that currently).
What I tried
I tried getting the physical cameras by themselves:
const devices = useCameraDevices();

const physicalDevices = devices.filter(({ isMultiCam }) => !isMultiCam);

console.log(
  physicalDevices.map(({ name, minZoom, maxZoom, formats }) => ({
    name,
    minZoom,
    maxZoom,
    formats: formats.map(({ maxZoom }) => maxZoom)
  }))
);

but, they all have their own zoom ranges, starting from 1 --- this doesn't really get us anything that helps figure out the zoom ranges of a multi-cam composed of these individual devices:
[
  { "name": "Back Camera", "minZoom": 1, "maxZoom": 123.75 },
  { "name": "Front Camera", "minZoom": 1, "maxZoom": 128.875 },
  { "name": "Back Telephoto Camera", "minZoom": 1, "maxZoom": 123.75 },
  { "name": "Back Ultra Wide Camera", "minZoom": 1, "maxZoom": 123.75 }
]

Likewise, there seem to be no properties on the CameraDevice object that return information about the optical characteristics of the device from which we could otherwise try to approximate these numbers, unless I'm missing something.
VisionCamera Version
3.9.0
Additional information

[X] I am using Expo
[X] I have read the Troubleshooting Guide
[X] I agree to follow this project's Code of Conduct
[X] I searched for similar questions in the issues page as well as in the discussions page and found none.

Excellent question!  Wondering the same thing.

I have the same question :)


How to compile with 3rd party libs?

I'm having trouble successfully recompiling the DLL file with third party libs. Are the source files or a compiled version pulled straight from each website manually? Are they installed via vcpkg and the arm64-uwp triplet. Perhaps yet another way?
This line in particular has me stumped:
Add zlib, libtiff, opencv412d to the project before compilation

The way I have done it is to compile static .lib libraries for windows on arm, then import them into the project. You can either compile them on your own or simply get them from https://github.com/microsoft/HoloLens2ForCV/tree/main/Samples/CameraWithCVAndCalibration/OpenCvInstallArm64-412d. To add them, just drag and drop the linked folder into the project folder. A future version of this tracking will rely on opencv 480 though, so at that point it will need to be compiled manually. I will provide instructions once that version is public.

I was able to compile the dll for ARM64 but it fails to load dll on HoloLens2. Just wondering if you encountered similar issues in the past, and if so, how you went about debugging them.
'HL2IRToolTrackingSample.exe' (Win32): Unloaded 'U:\USERS\DefaultAccount\AppData\Local\DevelopmentFiles\HL2IRToolTrackingSampleVS.Release_ARM64\HL2IRToolTracking.dll'
Exception thrown at 0x00007FFC0933D5D0 in HL2IRToolTrackingSample.exe: Microsoft C++ exception: Il2CppExceptionWrapper at memory location 0x0000006B659FED20.

the only thing that I could think of is that you either do not have enabled research mode, or that you compiled the dll and/or the application in debug mode.

@andreaskeller96 thank you for your prompt responses. I have tried adding HoloLens2ForCV\Samples\CameraWithCVAndCalibration\OpenCvInstallArm64-412d\x64\vc15\lib\opencv_world412d.lib and compiling as Release. (Btw, your Release build relies on Release version of opencv_word421.lib not opencv_world412d,lib). No luck. So, I have also tried to get opencv libraries compiled for arm64 using vcpkg, both vcpkg install opencv:arm64-windows and vcpkg install opencv4:arm64-uwp. They don't provide opencv_world412, but they provide enough libraries to compile your dll. However, the dll still fails to load. If I remove anything related to opencv and just try to load the dll, it works fine. So, it really comes down to opencv. Do you mind to share your opencv libs or how exactly you got them? Is there anything else (other dlls) you had to include (besides libtiff and zlib). It seems like a missing dependency issue.

Are you able to run the sample on your HoloLens without any issues (https://github.com/andreaskeller96/HoloLens2-IRTracking-Sample) ?
I have not tried using vcpkg to compile so I do not know if that is possible. Did you try adding the whole folder HoloLens2ForCV\Samples\CameraWithCVAndCalibration\OpenCvInstallArm64-412d including all headers and libraries?

hi @andreaskeller96 - we appreciate your responses on this thread.  However, I don't think either @denisshoth or myself are able to reproduce or recreate your project based on your README and comments here. It's just not possible without a much more detailed README or access to your working developer project via zip or docker file.  Denis used to work at Microsoft on the Hololens team developing eye tracking, he's quite familiar with C++ projects in general.   We actually had two issues that drew interest in recompiling your project.  1) Stop IR Tracking doesn't work. It just continues to function and eat up resources. 2) When we get the transform after adding the first IR tracker, it pretends to be successful even if it isn't. What I mean is that It seems like the Transform + Timestamp should give us an idea of how long ago it last picked up the IR sphere array, but it doesn't.  The Transform shows a valid result, even when the IR Sphere array is hidden from view, and the timestamp keeps updating.  Thought I would share, because we can't recompile to tweak these behaviors.

@andreaskeller96, just to clarify is HoloLens2ForCV\Samples\CameraWithCVAndCalibration\OpenCvInstallArm64-412d where you got the binaries for your precompiled dll? The hardest part with recompiling OpenCV projects appears to be finding the binary that compiles and works for the specific architecture. So, if you have those binaries, it would really help if you can attached them to your project as well.

@adconk I apologize for the lackluster README and the comments from memory that were not comprehensive. I have updated the repository to rely on OpenCV 4.8.0 and added the required headers and a step-by-step guide in the OpenCV folder on how to compile the necessary binary. As for your your issues:

Stop IR Tracking should work now
The array returned by the tracking is now correctly setting the final value to 0 if the object has not been detected in the last analyzed frame. If you want the timestamp itself, you can either track it from within unity or you can adjust the array to include the timestamp.
@denisshoth I was going off memory and got it wrong, the binary I used for OpenCV412 was compiled by a colleague since the linked repository only includes the opencv_world412d.lib. I have now included a guide on how to compile OpenCV for HoloLens 2, if this does not work for you I can provide the binary directly to you.

hi @andreaskeller96 - thank you so much for the updates the repo.  We'll give it a spin. If there's a chance you might be open to an icebreaker, it would be great to learn more about what you're up to and we can share our efforts too.  I can be reached here if you have interest: andrewconklin (AT) hothintel.com

Sounds great! I have sent you an email and am closing this issue. If you find more issues with the library, feel free to open more tickets or contact me directly!


[Vue + Apollo + Quasar] Create main page layout

Background
As a user, my main page view should show me my gists and top repositories.
Acceptance

[ ] 2 column layout
[ ] Left side

[ ] gists panel

[ ] Right side

[ ] Top repositories title
[ ] card for each of the users’ top repos
[ ] view all repositories button that navigates to user profile page

Notes

Closed by other upstream issue


fix: Make CollisionProspect's a, b have unordered equality

Description
See this comment

Checklist

[x] The title of my PR starts with a Conventional Commit prefix (fix:, feat:, docs: etc).
[x] I have read the Contributor Guide and followed the process outlined for submitting PRs.
[ ] I have updated/added tests for ALL new/updated/fixed functionality.
[ ] I have updated/added relevant documentation in docs and added dartdoc comments with ///.
[ ] I have updated/added relevant examples in examples.

Breaking Change

[ ] Yes, this is a breaking change.
[x] No, this is not a breaking change.

Related Issues
Fixes #1478

@spydon
Should I remove or clean up the reproducing test code?


Update path to system settings on Ventura

"System Preferences" has been renamed to "System Settings" on Ventura. Privacy and security settings have moved, too. This commit makes sure these changes are reflected. (Some adjustments were already made in #14092.)

[x] Have you followed the guidelines in our Contributing document?
[x] Have you checked to ensure there aren't other open Pull Requests for the same change?
[x] Have you added an explanation of what your changes do and why you'd like us to include them?
[ ] Have you written new tests for your changes? Here's an example.

All but one of brew tests passed. Though unrelated to this change, I don't know why this one failed (it failed on master too):
Failures:

  1) brew bottle builds a bottle for the given Formula
     Failure/Error:
       expect { brew "bottle", "--no-rebuild", "testball" }
         .to output(/testball--0\.1.*\.bottle\.tar\.gz/).to_stdout
         .and not_to_output.to_stderr
         .and be_a_success

       expected block to not output to stderr, but output "tar: Could not open extended attribute file: Permission denied\ntar: Could not open extended attribute file: Permission denied\ntar: Could not open extended attribute file: Permission denied\ntar: Could not open extended attribute file: Permission denied\ntar: Could not open extended attribute file: Permission denied\ntar: Could not open extended attribute file: Permission denied\ntar: Could not open extended attribute file: Permission denied\ntar: Could not open extended attribute file: Permission denied\ntar: Could not open extended attribute file: Permission denied\ntar: Could not open extended attribute file: Permission denied\ntar: Could not open extended attribute file: Permission denied\ntar: Could not open extended attribute file: Permission denied\ntar: Could not open extended attribute file: Permission denied\ntar: Could not open extended attribute file: Permission denied\ntar: Could not open extended attribute file: Permission denied\ntar: Could not open extended attribute file: Permission denied\n"
     # ./test/dev-cmd/bottle_spec.rb:20:in `block (2 levels) in <top (required)>'
     # ./test/support/helper/spec/shared_context/integration_test.rb:50:in `block (2 levels) in <top (required)>'

Review period will end on 2023-03-20 at 11:32:36 UTC.

Review period skipped due to critical label.


Memory leak warning when using a predefined instance of rsmq

If I create an instance of rsmq and create 11 or more queues on that instance - if I then create 11 or more rsmq-workers and specify the rsmq instance in the options (so that it does not create its own) then it starts throwing warnings:
warning: possible EventEmitter memory leak detected. 11 disconnect listeners added. Use emitter.setMaxListeners() to increase limit.
This is because each time I create the new rsmq-worker it adds a disconnect listener to the original rsmq instance.  As soon as you add 11 or more EventEmitter goes into meltdown :(

A simple piece of code to illustrate:
var RSMQWorker = require( "rsmq-worker" );
var RedisSMQ = require("rsmq");

var rsmq = new RedisSMQ( {host: "<IP_ADDRESS>", port: 6379, ns: "rsmq"} );
var workers=[];

for (var i=0; i<12; i++) {
    var name="worker_"+i.toString();
    workers.push(new RSMQWorker(name,{
        rsmq:       rsmq,
        autostart:  true,
    }))
}

i optimized the event listener handling so the single rsmq instance will only have as much listeners as workers connected.
So if you .stop() a worker the listener will be removed from the rsmq instance and re-added on a .start().
My small test script can be found here as gist

OK great - will the listener also be removed on quit()?

Is the fix on NPM?

Yeah all good - thanks

YES! quit is equal to stop but disconnects hard from the queue.
But i recommned .stop() in your case, because .quit() will detroy the connection of the rsmq instance.
See code and README.


[Fix #10657] Fix AutoGenerateConfig command ignores specified config file by option

Fixes #10657.
This PR fixes a bug that caused config files specified by --config options to be unintentionally ignored in AutoGenerateConfig command.

Before submitting the PR make sure the following are checked:

[x] The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
[x] Wrote good commit messages.
[x] Commit message starts with [Fix #issue-number] (if the related issue exists).
[x] Feature branch is up-to-date with master (if not - rebase it).
[x] Squashed related commits together.
[x] Added tests.
[x] Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
[x] Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

Thanks!


Apple App for Canada

When I search for Wled in Apple Store it doesn't exist. And when I clicked the link in here it says not available in my country.

Hi there, I have the same problem, but then for New Zealand. Would it be possible to enable the app for this region too?
Much love!

Yes. Why it is not available in Canada?? Make no sense to me.


Proposal Creation Wizard: max allowed period count

Reproduce:

Create a role assignment
Pick e.g. 28 periods
See error message: you must select less than 27 periods

Click to select 26 periods and click next and "publish to staging"
see error message: you must select less than 26 periods

Expected behaviour:
Consistent use of max periods
Experienced behaviour:
Mixed messages (less than 27 and less than 26 periods)
We are also working on changing the limit to 52 periods, see https://github.com/hypha-dao/dho-web-client/issues/1102

@leonieherma1 @Gerard097 Can we have the max number of periods on a setting from the backend so we can read it? Also maybe would be useful for owners of DAOs to be able to configure it?

yes good idea - is it possible to adjust per document type? E.g. assignments 12 periods and badge assignment 26?

@pugakn good idea - I will add it to the design with massimo and create a story

Let's discuss it a bit more tomorrow after stand up, there are a few things that we might or might not need to chage/add


Typescript Definition file needed

Problem to Solve
Need Typescript definitions
Current Workaround
None
Proposed Solution
Create Typescript definition file(s)
Additional Information
See https://www.typescriptlang.org/docs/handbook/declaration-files/introduction.html

Any idea if this request might be accomplished in the near future? We would like to consume Grank in upcoming project.

I don't think we have the bandwitdh to implement and maintain this ourselves right now. That being said, I believe the bindings would be relatively easy to create for your use case! Perhaps we can help you collaborate and design the bindings and contribute them as an open source project?

@sorsaffari  would be the one to talk to as he has the relevant experience.

I agree @flyingsilverfin.
A PR to this repo or DefinitelyTyped would be much appreciated @MichaelNino.

Okay I'll create the definition files. Thank you for technically supporting
me.
On Wed, Jan 8, 2020, 8:05 AM Soroush Saffari<EMAIL_ADDRESS>wrote:

I agree @flyingsilverfin https://github.com/flyingsilverfin.
A PR to this repo or DefinitelyTyped
https://github.com/DefinitelyTyped/DefinitelyTyped would be much
appreciated @MichaelNino https://github.com/MichaelNino.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/graknlabs/client-nodejs/issues/82?email_source=notifications&email_token=AM6IN4CFV55O7KISVMF3LS3Q4XFR3A5CNFSM4J7S6B22YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEIMKHUA#issuecomment-572040144,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AM6IN4BXNVQFYZJOWKWSEY3Q4XFR3ANCNFSM4J7S6B2Q
.

Hi @sorsaffari
I have begun writing the Typescript definition. Below is the definition file so I might better ask my questions.
// Type definitions for grakn-client 1.6.0
// Project: Grakn Client API: NodeJS
// Definitions by: Michael Niño https://www.michaelnino.com

export = GraknClient;

interface Credentials {
    username: string;
    password: string;
}

interface KeyspacesResponse {
   retrieve(): Promise<any>;
   delete(keyspace: string): Promise<any>;
}

declare class GraknClient {
    constructor(uri: string, credentials?: Credentials);

    session(keyspace: string): Session;

    /*
    this.keyspaces = () => ({
        delete: (keyspace) => keyspaceService.delete(keyspace),
        retrieve: () => keyspaceService.retrieve()
    });
    */
    keyspaces(): KeyspacesResponse[];

    close(): void;
}

/*
module.exports.dataType = {
    STRING: messages.AttributeType.DATA_TYPE.STRING,
    BOOLEAN: messages.AttributeType.DATA_TYPE.BOOLEAN,
    INTEGER: messages.AttributeType.DATA_TYPE.INTEGER,
    LONG: messages.AttributeType.DATA_TYPE.LONG,
    FLOAT: messages.AttributeType.DATA_TYPE.FLOAT,
    DOUBLE: messages.AttributeType.DATA_TYPE.DOUBLE,
    DATE: messages.AttributeType.DATA_TYPE.DATE
};
 */
declare namespace GraknClient {
    export interface dataType {
        STRING: any;
        BOOLEAN: any;
        INTEGER: any;
        LONG: any;
        FLOAT: any;
        DOUBLE: any;
        DATE: any;
    }
}

I have included comments from the your project's JavaScript source file for reference as well.

Could you elaborate on your intention to destructure object literals in the method keyspaces. I would like to better understand the approach so I may create necessary typing but not over-typing.
Could you provide me with the URL to the declaration of messages.AttributeType.DATA so I might create the correct types for that part of the Typescript definition? Thank you I couldn't easily locate it.

Thanks for your assistance. I think this definition file will increase overall adoption of Grakn/NodeJS.

@sorsaffari you input would be greatly appreciated :-)

Hi! I'm very interested in using Grakn with a NodeJS project I'm working on, written in TypeScript.
Is there anything I could do to help make this Type Def file happen?

The NodeJS client for Grakn 2.0 is a TypeScript project, and the npm package grakn-client contains both .js and .d.ts files as of 2.0.


Repartition on day is incorrect when index is timestamped per day

When the index is timestamped per day (at midnight), repartition per day gives the wrong result:
index = [
    pd.Timestamp(2020, 1, 1),
    pd.Timestamp(2020, 1, 1),
    pd.Timestamp(2020, 1, 2),
    pd.Timestamp(2020, 1, 2)
]

pdf = pd.DataFrame(index=index, data={"foo": "foo"})
ddf = dd.from_pandas(pdf, npartitions=2).repartition(freq="D")

print(ddf.npartitions)
>>> 1

print(ddf.partitions[0].compute())
>>>             foo
>>> 2020-01-01  foo
>>> 2020-01-01  foo
>>> 2020-01-02  foo
>>> 2020-01-02  foo

I would expect two partitions (one for January 1 and one for January 2).
If you agree that this is a bug, I could look into it.
Python: 3.8.6
Dask: 2021.01.1
OS: MacOS (Big Sur)

I did some more digging, the problem is as follows:
If:
a) the penultimate division is non-empty, AND
b) there are observations that coincide with the end of the final division
then the last two divisions are wrongfully combined.
So this will go wrong:
index = [
    pd.Timestamp("2020-10-31"),
    pd.Timestamp("2020-11-30"),
    pd.Timestamp("2020-12-31"),
]

pdf = pd.DataFrame(index=index, data={"foo": "foo"})
ddf = dd.from_pandas(pdf, npartitions=1).repartition(freq="M")

but this will be fine
index = [
    pd.Timestamp("2020-10-31"),
    pd.Timestamp("2020-12-31"),
]

pdf = pd.DataFrame(index=index, data={"foo": "foo"})
ddf = dd.from_pandas(pdf, npartitions=1).repartition(freq="M")

Pretty tricky to circumvent this, since you'd have to query the index to check if a) holds.

I did some more digging, the problem is as follows:
If:
a) the penultimate division is non-empty, AND
b) there are observations that coincide with the end of the final division
then the last two divisions are wrongfully combined.
So this will go wrong:
index = [
    pd.Timestamp("2020-10-31"),
    pd.Timestamp("2020-11-30"),
    pd.Timestamp("2020-12-31"),
]

pdf = pd.DataFrame(index=index, data={"foo": "foo"})
ddf = dd.from_pandas(pdf, npartitions=1).repartition(freq="M")

but this will be fine
index = [
    pd.Timestamp("2020-10-31"),
    pd.Timestamp("2020-12-31"),
]

pdf = pd.DataFrame(index=index, data={"foo": "foo"})
ddf = dd.from_pandas(pdf, npartitions=1).repartition(freq="M")

Pretty tricky to circumvent this, since you'd have to query the index to check if a) holds.

Yeah. Turns out pandas-style resampling is kind of hard for distributed data. If you are able to dig into it more and open a pull request that would be appreciated. I started a PR a while ago #6300 but I didn't really get anywhere.

I’ll give it a go.

Yeah I think it should either be
Timestamp("2015-01-01 00:00:00")
Timestamp("2015-02-01 00:00:00")

or something that is basically equivalent like:
Timestamp("2015-01-01 00:00:00")
Timestamp("2015-01-31 23:55:00")
...

For instance in that test you point to we should be able to add this check and it should work:
pandas_mean = df.groupby(pd.Grouper(freq="1M")).mean()
assert_eq(expected,  ddf.mean())

The index of pandas_mean indicates what our partitions should be like.

I don't think I understand that. Doesn't ddf.mean() just return the column means?

I don't understand it anymore either, sorry about that. Let me try to write this down more carefully. I think this is what I meant:
import numpy as np
import pandas as pd
import dask.dataframe as dd

ts = pd.date_range("2015-01-01 00:00", " 2015-05-01 23:50", freq="10min")
df = pd.DataFrame(
    np.random.randint(0, 100, size=(len(ts), 4)), columns=list("ABCD"), index=ts
)
ddf = dd.from_pandas(df, npartitions=1).repartition(freq="1M")

pandas_mean = df.groupby(pd.Grouper(freq="1M")).mean()
for index_value in pandas_mean.index:
    assert index_value == ddf.divisions[i + 1]

But looking at this now I think you are totally right that last day of the month should be fully included in the division for that month. So your proposal in https://github.com/dask/dask/issues/7139#issuecomment-795419359 seems perfect.

Fixed in https://github.com/dask/dask/pull/7357


Can't add user to groups

Whenever i try to add a user to a group i get an error that user can only be in one group, but the usser isnt associated with any groups.

user addgroup Chuperto gen

10/1/2015 1:17:58 AM Command> Exception from command
10/1/2015 1:17:58 AM Command> System.NotSupportedException: A player can only be associated to one group, please assign a parent to the desired group
at OTA.Data.Storage.AddUserToGroup(String username, String groupName)
at TDSM.Core.Entry.UserPermission(ISender sender, ArgumentList args)
at OTA.Command.CommandInfo.Run(ISender sender, ArgumentList args)
at OTA.Command.CommandParser.ParseAndProcess(ISender sender, String line)
at OTA.Command.CommandParser.ParseConsoleCommand(String line, ConsoleSender sender)
at TDSM.Core.Entry.ListenForCommands()

user listgroups Chuperto
There are no registered groups for user Chuperto

Confirmed. Adding a new user and then immediately attempting to assign a group to the user results in the above exception.

As per the new database, this might be fixed. This needs testing again.


Availability on F-Droid

Because it is Open-Source, wouldn't it be great to have it available on F-Droid as well?
https://f-droid.org/
Should fit your philosophy of open and not feeding "others" perfectly

Definitely. I'll request a package upload. https://gitlab.com/fdroid/rfp/issues

That would be great because I cannot access the Alpha otherwise. I do not have installed the Google Framework on my LineageOS fueled device.

Yeah I have the same problem. For now you can either compile the app yourself or just join the Slack linked in the readme, @lifenautjoe uploads APKs there. Although distribution through F-Droid would be nicer ^^

Thanks for the hint, got the apk from Slack (better than nothing...).

Definitely. I'll request a package upload. https://gitlab.com/fdroid/rfp/issues

Can you link to the request you submitted? Couldn't find it on F-Droids issues page on Gitlab

As the people are searching for a "new" safe Haven/Social Platform, this's more relevant than ever. As noted by @IzzySoft in the issue over at F-Droid's data, there's 3 things to be cleared:
[ ] Updating Fastlane data
[ ] Replacing the function call of the versionname/-code with literals as F-Droid still don't support it
[ ] OneSignal -including gsf & hms - could be a big problem, suggestion: a build-flavour using Foreground-based Notification service like Telegram and Signal(At least when no gsf is found)

As the people are searching for a "new" safe Haven/Social Platform, this's more relevant than ever. As noted by @IzzySoft in the issue over at F-Droid's data, there's 3 things to be cleared:
[ ] Updating Fastlane data
[ ] Replacing the function call of the versionname/-code with literals as F-Droid still don't support it
[ ] OneSignal -including gsf & hms - could be a big problem, suggestion: a build-flavour using Foreground-based Notification service like Telegram and Signal(At least when no gsf is found)


Rule to ban ts-ignore comments?

https://github.com/Microsoft/TypeScript/wiki/What's-new-in-TypeScript#suppress-errors-in-ts-files-using--ts-ignore-comments
if (false) {
    // @ts-ignore: Unreachable code error
    console.log("hello");
}

Awesome, this was fixed by #3728. 🎉

Hello,
That's maybe a dumb question by I am wondering why I can't see this rule in the list?
My project is using TSLint 5.11.0
Thanks

@mickaeltr what you're seeing is correct - TSLint 5.11.0 was released before this rule was merged in. A new version hasn't been released yet (folks from the Palantir side are still looking for a full-time maintainer). You'll have to wait for the next version. Sorry!

Thanks for the answer @JoshuaKGoldberg, I missed that somehow.

Is there a way to ban tslint:disable comments?


Generate secret for master key if the env is set to production

With these changes, if someone were to set MEILI_ENV to production and not set MEILI_MASTER_KEY, then a cryptographically secure random secret (using randAlphaNum) will be created automatically and then loaded as an environment variable.
If you set MEILI_MASTER_KEY in the values.yaml, then that is used instead, so no secret is generated/used.
If the env is development then no secret is created at all. You could still set MEILI_MASTER_KEY in the values.yaml, as those just get loaded in no matter what.
Resolves #19 and maybe #38

I've bumped the versions of the actions, mainly to fix the linting issue (though they were also a bit outdated) as it's a newer helm feature.

* Mentioning this behavior also in [this section of the chart README](MEILI_ENV: development)

The link is broken, so I made a guess as to where it may be best placed 😄

Finally, regarding #38, I think we can definitely add explicitly MEILI_MASTER_KEY to the values file, but ignore it if it is empty, what do you think? This can be part of a different PR and doesn't;t have to be handled here.

The problem is the value is then nil and since the values are mapped with configMapRef which essentially grabs the whole bunch, then it causes an error. Could would around it by mapping the values individually but then you'd need to do that for all possibilities in the environment. I've put it in the values as a commented out value and then placed the text you wrote above it instead of above the MEILI_ENV.
If the value is there and defined as nil then it may make people think they can have a production environment with a key of nothing (like in development).
You can always feel free to write directly to my fork/branch to make any changes around wording and such. You should have permissions since it's a fork of this repo and it inherits those permissions with fork creation.

The link is broken, so I made a guess as to where it may be best placed 😄

Oh, I lost the message from my review after writing it, and had to re-write it again, sorry for this error! But you guessed more than right! 😂
Regaqring #38: thanks for your explanation! Indeed, adding
# MEILI_MASTER_KEY:

seem to be a good option, as it is at least explicit and self-explanatory, and doeasn't add unnecessary complexity!
Thanks a lot for taking all that feedback into account, this LGTM! 🔝

Bors try

Bors merge


remove dependency on emojify and make it work better with windows

Coverage decreased (-3.7%) to 96.313% when pulling 6b406f59149b851ee93d9e0b091a17569bf67290 on windows into 91738ec540fed0bf496ec934e4620b8a5a5ef34a on master.

Coverage decreased (-3.7%) to 96.313% when pulling 9353bbd33e2332d64a14d76197328b31f5250e9d on windows into 91738ec540fed0bf496ec934e4620b8a5a5ef34a on master.

Coverage decreased (-3.7%) to 96.313% when pulling a0dc04e1a14bc910dd76aa67437949670a8dab0c on windows into 91738ec540fed0bf496ec934e4620b8a5a5ef34a on master.

Coverage decreased (-3.7%) to 96.305% when pulling 69de681c31ca083233a3031677aabfa91b3faa76 on windows into 91738ec540fed0bf496ec934e4620b8a5a5ef34a on master.

Coverage remained the same at 100.0% when pulling 2c165eada91eba9ed60ad0a303f07bf02fb7589b on windows into 91738ec540fed0bf496ec934e4620b8a5a5ef34a on master.

Coverage remained the same at 100.0% when pulling 43fda1e2ced8a09000cface1b96f949428e42e69 on windows into 91738ec540fed0bf496ec934e4620b8a5a5ef34a on master.


extension crashed

The extension crashed because it could not import module pynotifier.
Try installing this module manually: pip3 install pynotifier --user and then restart Ulauncher.

I will look into this. In the meantime try: pip3 install pynotifier --user  or sudo pip3 install pynotifier --user  if the first one doesn't work. When did the problem occur? While installing with the installer script?

I will look into this. In the meantime try: pip3 install pynotifier --user  or sudo pip3 install pynotifier --user  if the first one doesn't work. When did the problem occur? While installing with the installer script?
It happent when restart Ulauncher after install this extension
and

pip3 install pynotifier --user or sudo pip3 install pynotifier --user

not wok
system say
ERROR: Could not find a version that satisfies the requirement pynotifier (from versions: none)
ERROR: No matching distribution found for pynotifier

In the end, I was wrong!
There is no note on the Ulauncher Extensions website that must run installscript.sh before adding this extension to configuration.
Now it work perfect
p/s: please note that there is only py-notifier package, not pynotifier package
Thank you for creating a great extension @KarlFrederik

There is no note on the Ulauncher Extensions website that must run installscript.sh before adding this extension to configuration.

There should be one now.

p/s: please note that there is only py-notifier package, not pynotifier package

The crash reports are done automatically from Ulauncher. I can't edit them, unfortunately.


Introduce StorageClientImpl.ApplicationName

This is used when constructing new instances of StorageClient without specifying
a StorageService. Most applications will never need this, which is why it's
somewhat hidden away - as client construction is basically the first thing
we do, it's best to avoid overcomplicating it.

LGTM


Add profile section to the rest of the pages

Describe the bug
The profile section is missing from some pages in the application. This should be consistently present across all pages.
To Reproduce
Steps to reproduce the behavior:

Go to any page where the profile section is not displayed (e.g., [specific pages])
Observe the missing profile section.

Expected behavior
The profile section should appear on all pages, allowing users easy access to their profile information regardless of which page they are on.
Screenshots

Additional context
It looks like you're describing a bug report template for a software project. Here’s how you might structure the information to make it easy to follow:
Bug Report
Title
Add profile section to the rest of the pages.
Describe the bug
The profile section is missing from some pages in the application. This should be consistently present across all pages.
To Reproduce
Steps to reproduce the issue:
Go to any page where the profile section is not displayed (e.g., [specific pages])
Observe the missing profile section.
Expected Behavior
The profile section should appear on all pages, allowing users easy access to their profile information regardless of which page they are on.
Screenshots
Add screenshots showing a page with the profile section visible and one without it to illustrate the issue.
Additional Context
It appears that the profile section was added on some pages but not all. This may require updating the page layout or template files across the application for consistency.

@ANSHIKA-26 what about this?


Docs: Broken Link in Meshery Documentation Build and Release Page

Current State
The link in question is: https://docs.meshery.io/project/build-and-release. Clicking this link leads to a 404 error page with the message

Desired State
Clicking the link should take users to the correct documentation page on Meshery's build and release information.
Contributor Guides and Handbook

📚 Instructions for contributing to documentation

Meshery documentation site and source

🛠 Meshery Build & Release Strategy
🎨 Wireframes and designs for Meshery UI in Figma (open invite)
🙋🏾🙋🏼 Questions: Discussion Forum and Community Slack

Can I fix this?

@Mohiit70 were you wanting to work on this?
The correct link is - https://docs.meshery.io/project/contributing/build-and-release

@Mohiit70 were you wanting to work on this?
The correct link is - https://docs.meshery.io/project/contributing/build-and-release

Yes I'd like to work on this issue

@shubhamku044 Thanks for jumping in.
While assigning issues we follow FCFS. Please be sure to review @Mohiit70 's PR.
A list of good first and help wanted issues : https://github.com/issues?q=is%3Aopen+is%3Aissue+archived%3Afalse+org%3Alayer5io+org%3Ameshery+org%3Aservice-mesh-performance+org%3Aservice-mesh-patterns+label%3A"help+wanted"+

@shubhamku044 Thanks for jumping in. While assigning issues we follow FCFS. Please be sure to review @Mohiit70 's PR.
A list of good first and help wanted issues : https://github.com/issues?q=is%3Aopen+is%3Aissue+archived%3Afalse+org%3Alayer5io+org%3Ameshery+org%3Aservice-mesh-performance+org%3Aservice-mesh-patterns+label%3A"help+wanted"+

sure. I will review it and also will try to contribute to other issues.

@vishalvivekm Just to clarify, the broken link issue I reported is in the "service-mesh-performance" repository, not Meshery. I've opened a new issue there. Thanks!


[No QA] [TS migration] Migrate 'DeviceCapabilities' lib to TypeScript

Details

Migrate 'DeviceCapabilities' lib file to TypeScript
Fixed Issues

$ https://github.com/Expensify/App/issues/24830
Tests

[x] Verify that no errors appear in the JS console

Offline tests

QA Steps

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

https://github.com/Expensify/App/assets/41169160/eb71f619-e235-4ce0-b638-77eedd01a71c

Mobile Web - Chrome

Mobile Web - Safari

https://github.com/Expensify/App/assets/41169160/9c24ede5-ac0f-47fb-a5a9-c64897e43f43

Desktop

iOS

Android

https://github.com/Expensify/App/assets/41169160/90398adb-75f5-49d2-a472-99b2de525e39

@BartoszGrajdek bump in case you have missed this one 😅

Thanks for the review & for bumping @BartoszGrajdek , @fabioh8010 :D 👍

Sorry, missed this PR, should be ok now @fabioh8010

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by https://github.com/Beamanator in version: 1.3.73-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/mountiny in version: 1.3.73-1 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
failure ❌

🕸 web 🕸
success ✅

🚀 Deployed to staging by https://github.com/Beamanator in version: 1.3.74-0 🚀

platform
result

🤖 android 🤖
failure ❌

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/chiragsalian in version: 1.3.74-3 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
failure ❌

🕸 web 🕸
success ✅


Feature/issue-205

Github Issue: #205 , #220
Description
If there are dimensions that have the same string name but different values in different groups. Then the xarray.rename_dims function will need to be used so that the copying variables back into the netCDF dataset is successfull
Overview of work done
get the names of dimensions that have different values and then put the old name and new name into the .rename_dims for an updated dataset. Check that the same time variable isn't added
Overview of verification done
run bounding box test on OMIPIXCOR data file
Overview of integration done
Explain how this change was integration tested. Provide screenshots or logs if appropriate. An example of this would be a local Harmony deployment.
PR checklist:

[x] Linted
[x] Updated unit tests
[x] Updated changelog
[ ] Integration testing

See Pull Request Review Checklist for pointers on reviewing this pull request

Synk seems to be failing, and I'm not sure how to trouble shoot that

@nlenssen2013 there are some conflicts that need fixing.  Also, don't worry about the Synk and SonarCloud failure.  I have another branch to address that.  But if you can fix the conflicts then we should be able to merge this.

@nlenssen2013 there are some conflicts that need fixing. Also, don't worry about the Synk and SonarCloud failure. I have another branch to address that. But if you can fix the conflicts then we should be able to merge this.

Conflicts are fixed. Added a small issue fix with the compute time coordinates function. Let me know if it's acceptable.


Create .gitignore

Reasons for making this change:

TODO
Links to documentation supporting these rule changes:
TODO
If this is a new template:

Link to application or project’s homepage: TODO

what.


allow-clear="true" does not work when tagging and reset-search-input="false" are specified

The issues forum is NOT for support requests. It is for bugs and feature requests only.
Please read https://github.com/angular-ui/ui-select/blob/master/CONTRIBUTING.md and search
existing issues (both open and closed) prior to opening any new issue and ensure you follow the instructions therein.
Bug description:
allow-clear="true" does not work when tagging and reset-search-input="false" are specified
Link to minimally-working plunker that reproduces the issue:
http://plnkr.co/edit/5Y0TL6CNo09LaQfk8nnR?p=preview
the 1st dropdown is to demonstrate working scenario.  2nd dropdown shows the bug
Version of Angular, UI-Select, and Bootstrap/Select2/Selectize CSS
Angular: 1.4.9
UI-Select: 0.15.0
Bootstrap/Select2/Selectize CSS (if applicable):

I have solution for this.  Pull request is forthcoming...

Is this issue still in the works?

@edlahoz  the linked PR still needs a unit test and rebasing due to conflicts. Feel free to pick it up if you like a submit a new one.

Hey, i tried the PR but it still has glitches where the selected values cant be cleared. I found another way to do it which seems to fix the problems with 3 simples lines of code. If anyone is interested let me know I will submit a pull request.

@mikemicmike I have the same situation .can you share your solution ?

Ok so basically in the ui-select source, add the following and everything should work. Let me know if anything seems to not work i'll look into it.
https://gist.github.com/mikemicmike/ed847517f4f6862d27b6789aedfcc574
Up there is the UI-Select JS file, just look for the MODIFIED*** tag to find the 3 lines that were updated
Gl! I dont know exactly how pull requests and whatnot work im sort of new to Github but let me know if i can do anything to help. I was gonna have a workmate help me out but he's gone for a while. So if anyone wants this in a PR just tell me how or use my code to do it.


Remove defaulting of translation_key

Part 2 of changes related to: https://github.com/zigpy/zigpy/pull/1488
Proposed change
translation_key no longer defaults to attribute_name or command_name.
There's more information in the linked zigpy PR below on why this should be the case.
Additional information
Somewhat requires this zigpy PR to ensure translation_key or device_class is provided for a proper name:

https://github.com/zigpy/zigpy/pull/1488

Requires for tests to pass:

https://github.com/zigpy/zha/pull/252

I wanted to keep these changes separate from #252, as the changes are only semi-related.

Will this require any changes in quirks, to manually add the defaults?

Somewhat. When zigpy is bumped in the quirks repo, quirks missing translation_key will fail to validate.
At the moment, the zha-quirks version used for ZHA doesn't contain any quirks v2 entities.
The next version of zha-quirks will contain quirks v2 entities, but in the quirks repo, a translation_key and fallback_name is already present for all of those.


Changes to initial maintenance dose

max HD MD (pending decision by workgroup)
increase max initial TDD to 4.5 g
non-HD and CrCl >= 90 and age < 25: 20 mg/kg q8h
non-HD and CrCl >= 90 and age > 40: 15-20 mg/kg q12h (consider closer to 15 for mild-mod infx e.g. SSTI/UTI)
non-HD and CrCl >= 90 and age 25-40: 15-20 mg/kg q8h (consider closer to 15 for mild-mod infx e.g. SSTI/UTI)
non-HD and CrCl < 90: 15-20 mg/kg q12h (consider closer to 15 for mild-mod infx e.g. SSTI/UTI)
CVVH/D/F: 7.5-10 mg/kg q12h
SLED: 15-20 mg/kg after the session ends (or in the last 60-90 minutes)

combined with #2


Stop failing on double finalization

Stop failing on double finalization
Internal cleanups/improvements

Exception in flutter tests:
00:05 +3: SemanticsDebugger will schedule a frame
══╡ EXCEPTION CAUGHT BY FLUTTER TEST FRAMEWORK ╞════════════════════════════════════════════════════
The following _Exception was thrown running a test (but after the test had completed):
Exception: The object 616336549 GCed twice

When the exception was thrown, this was the stack:
#0      ObjectRecord.setGCed (package:leak_tracker/src/leak_tracking/_object_record.dart:66:31)
#1      ObjectTracker._onObjectGarbageCollected (package:leak_tracker/src/leak_tracking/_object_tracker.dart:84:12)
#9      _FinalizerImpl._runFinalizers (dart:core-patch/finalizer_patch.dart:66:18)
#10     _FinalizerImpl._handleFinalizerMessage (dart:core-patch/finalizer_patch.dart:79:15)
(elided 7 frames from dart:async and package:stack_trace)
════════════════════════════════════════════════════════════════════════════════════════════════════

@ksokolovskyi


Update README.md so signal.tube link works on IOS

Should read.
https://signal.tube#<your_host_name>
not
https://signal.tube/#<your_host_name>
the "/" breaks the link on IOS

Issue with the link in the read me.
It fails to work on IOS becaues of extra "/"
https://signal.tube#<your_host_name>
not
https://signal.tube/#<your_host_name>
the "/" breaks the link on IOS

signal.tube links with a / before the fragment should work fine in ios. I've tested this and things seem to to be in order now, but let us know if you are still seeing an issue.


Build and run tests on Windows

Probably need to take care of issue #2 first, then the default build process can be changed on Windows to use Clang instead of MSVC.

Of course after issue #2 is resolved there's still the fact that support for local debugging with LLDB on Windows is still very much a work in progress, and most tests use local debugging so many will probably fail.


Add a s2i based deployment of 'spring-petclinic'

Below may be worth considering for adding another s2i based example app
See:  https://github.com/spring-projects/spring-petclinic

Below links may help for getting a demo running on openshift with mysql

https://github.com/burrsutter/spring-petclinic
https://github.com/demo-thursday/azure-service-operator/tree/master/base


Warning: Stateless function components cannot be given refs. Attempts to access this ref will fail.

Warning: Stateless function components cannot be given refs. Attempts to access this ref will fail.

    Check the render method of `LinearGradient`.
        in Unknown (created by LinearGradient)
        in LinearGradient (created by ChatHeader)
        in View (created by View)
        in View (created by ChatHeader)
        in ChatHeader

I think this is the problem https://github.com/react-native-community/react-native-linear-gradient/blob/master/index.ios.js#L73
React-Native: 0.50.0
iOS: 11.1

I am facing a similar issue, please look into this.


[Add hover effect on Fork button]

Description
I want to add hover effect on Fork button. Please assign me task under GSSOC'23.
Screenshots
No response
Checklist

[X] I have checked the existing issues
[X] I have read the Contributing Guidelines
[X] I am willing to work on this issue (optional)
[X] I am a GSSoC'23 contributor

I want to solve this problem please assign me this task.

I want to solve this problem please assign me this task.

@KHADIJA-09, @akshaysoni10 wants to work on this issue. Let's see if they still want to before we move any further. 😄

I'm closing this issue as it was already resolved in #1029


People Page

Initial requirements:

The landing page of people page should include everybody

Each person thumbnail should be click-able (reference individual pages)
Divide by different job/degree titles (PI, PostDoc, PhD, RA, Masters, Bachelors, ...)
Include an alumni page

Each person should  have its own page which they can control

Should include a bit more detailed background, links to projects involved and publication posts

To be discussed:

Do we keep alive the personal page of any alumni?
Should the person thumbnail pop-out a very short summary instead of individual pages? [1]
Should we include icon links to Google Scholar/Github/Person page/Twitter/Orchid/Email/LinkedIn? [2]
Should we have standardized profile shots? [3]

References:

https://weblab.t.u-tokyo.ac.jp/en/members/
https://weblab.t.u-tokyo.ac.jp/en/members/
https://weblab.t.u-tokyo.ac.jp/en/members/

Added draft of people page in 49654f8


evermonkey.fontSize not override fontsize in evermonkey.markdownTheme

I  have been set fontSize like  this:     "evermonkey.fontSize": "14px". Then i used the vscode-md-preview  to preview my note , the fontsize setting is effective,  but after publish this note to evernote, the fontSize is still 16px
<div markdown="1" style="-ms-text-size-adjust: 100%; -webkit-text-size-adjust: 100%; color: #333; font-family: Helvetica Neue,Helvetica,Segoe UI,Arial,freesans, sans-serif,微软雅黑,Heiti SC Light,Apple Color Emoji,Segoe UI Emoji,Segoe UI Symbol !important; font-size: 16px !important; line-height: 1.6; margin-bottom: 50px; word-wrap: break-word;">

Hi, there are two "fontSize" configurations. "evermonkey.fontSize" is for regular text and "evermoneky.codeFontSize" is for highlight code. Check that please.
Besides, remember to check this by using ever browse or ever client to view it in evernote. What you see in vscode, both md-view or markdown text may not be the final look as they are.

@michalyao Thanks for your reply. Maybe some note styles is different between evermonkey(vscode)
with evernote(in sublime).


fix issue 971:to have ability to ignore all assert when expected value is null

Check List:

Fixes #971
Unit tests : YES
Javadoc with a code example (on API only) : YES
In assertions.java, I add two methods for most types. The conditionalAssertThat method adds a boolean type argument, when it's false, the assertThat will be skipped. The notNullAssertThat method ask the argument called expected to not be null, if it's null, the assertThat will be skipped. Also, I add some tests to test these two methods.
I'm a student, and my ability to develop a project is poor. I just tried making a pull request. Maybe my pull request is totally wrong and doesn't meet your requirements. If it happens, I'm sorry about that and you can ignore my pull request and don't merge it.

Sorry @wuqihan837 but this does not solve the issue, I'm thus closing this PR.
I recommend to look for issues with "Good first issue" that are easy to address for less experienced developers.


Property based test for Azure put/get to verify symmetric results

Related to #333
Seems it's working fine with cats.effect.IO, in my stacktrace you'll see I'm using ZIO as effect monad. Probably an issue there, will investigate

Seems there is a race condition.
The FSM is already in UpstreamCompletion while sometimes we receive a chunk of bytes, skimmed across fs2-reactivestreams .. but could not find any strange things yet.

There was a quite recent change for fs2-reactive-streams https://github.com/typelevel/fs2/commit/a9ff266ea23c67e9feb43ea8a672242a7bf99e5d
In this fix the onNext/onSubscribe effects are evaluated synchronously instead of asynchronously.
In conclusion, the fix was to update fs2-reactive-streams to the latest version and the problem was not in the ZIO interop.
There is still an outstanding issue with it though https://github.com/typelevel/fs2/issues/2260

Good investigation!
Yeah, having laws over blobstore operations sounds like a good idea. Currently we have AbstractStoreTest which all Store tests extend, maybe we can move this test there for now?

@Fristi I moved the check to the AbstractStoreTest we currently have in #345 That also helped surface bug in S3 store implementation, so thanks for that.
Tests do need some work in general, and that is likely to include more declarative-invariant/law-based approach.

Cool! Glad you fixed another bug with these tests :)


Fix Permissions for Project access(detail view)

Fixes #3205
Fixes #3216

Staff can access the project in every status.
Contracting can access projects only in WAITING_FOR_APPROVAL and CONTRACTING statuses.
Finance can access projects only in the WAITING_FOR_APPROVAL and IN_PROGRESS statuses.
Applicant(only project user) can access the project in every status to keep track.
Unauthorised users and any other role can not access the project.

@frjo I'll fix the tests after we decide on the permissions. If the above permissions look good to everyone then I can move forward with the tests.  cc_ @fourthletter

If you looking to add permissions for the lower level permissions and they are configurable i would to have separate permissions for them.

On Feb 20 2023, at 10:56 AM, Sandeep Chauhan  @.***>  wrote:

@sandeepsajan0  commented on this pull request.
In   hypha/apply/projects/permissions.py (https://github.com/HyphaApp/hypha/pull/3220#discussion_r1111466960):

permissions_map = {
'contract_approve': can_approve_contract,
'contract_upload': can_upload_contract,

   'project_access': can_access_project,

I was also thinking to use
project_view
but that ProjectDetailView contains multiple forms(actions/buttons) as well so it is like 'view project + access to those actions'. And if we want to have those forms' view permission separately then it will be just many permission but yes at the same time, it might give us more flexibility over every form/button.
These permissions are not confirmed yet so let's wait for the confirmation, we can work on it after that.
—
Reply to this email directly,     view it on GitHub (https://github.com/HyphaApp/hypha/pull/3220#discussion_r1111466960), or     unsubscribe (https://github.com/notifications/unsubscribe-auth/AABZWRFJSKXQXDG2MBN2RMTWYL57NANCNFSM6AAAAAAU5ZGYBI).
You are receiving this because you commented.


Task/sumeragi json format error

Sorry, I can't solve circle-ci error docker run -p 1204:1204 hyperledger/iroha-docker /test.sh

Created sumeragi.json format checker

It ensures valid nested json keys, values and types of values of sumeragi.json.
Example

ensureKeyValueFormat<ValueType>(jsonObject, {"hoge", "foo", "fuga"}, 0) verifies the format of json {"hoge":{"foo":{"fuga":"value"}}}
{"me":{"iP": "<IP_ADDRESS>", ...}} can be detected and it shows warning Type mismatch "ip" in "me"
{"me":{"ip": "<IP_ADDRESS>9", ...}} can be detected and it shows warning of invalid IP addr message.

Not implemented

find keys that sumeragi.json does not use.

e.g. In sumeragi.json, text including {"uselessKey","12345"} cannot be detected.

verify whether valid base64 encoded string (publicKey) or not.

Thx motxxx for developing this features in IROHA.  In the not implemented features, unused key check is useful and need in IROHA. And, I think verify base64 strings will be done at later time in IROHA, in which IROHA nodes are verified by those public key.  So, it does'nt need in this time.

Sorry, I think it's ugly that json format is hard coding. It's better to prepare a basic format JSON file and compare config files with it. Then, unused key check feature is also solved at the same time, I think.

Sample of basic_sumeragi.json file

{
  "me":{
    "ip":"ip",
    "name":"*",
    "publicKey":"*",
    "privateKey":"*"
  },
  "group":[
    {
      "ip":"ip",
      "name":"*",
      "publicKey":"*"
    }
  ]
}

Sample of regex_def.json file

{
  "ip" : "^(([1-9]?[0-9]|1[0-9]{2}|2[0-4][0-9]|25[0-5]).){3}([1-9]?[0-9]|1[0-9]{2}|2[0-4][0-9]|25[0-5])$"
}

In the not implemented features, unused key check is useful and need in IROHA.
to prepare a basic format JSON file and compare config files with it.
I dealt with these issues.

I could not deal with loading regex_def.json because nlohmann/json does not support to read symbols used in regular expression.

I will look.

Thank you for looking. My local test has passed. I suppose the program cannot read the test files. I will investigate it.

This is what I've got after local build:
bogdan@private ~/tools/iroha/build/test_bin $ ./ensure_sumeragi_json_format_test
Running main() from gtest_main.cc
[==========] Running 5 tests from 1 test case.
[----------] Global test environment set-up.
[----------] 5 tests from ensure_sumeragi_json_format
[ RUN      ] ensure_sumeragi_json_format.normal_sumeragi_json
1486128144 INFO [peer with json] load json is {
  "me":{
    "ip":"ip",
    "name":"*",
    "publicKey":"publicKey",
    "privateKey":"privateKey"
  },
  "group":[
    {
      "ip":"ip",
      "name":"*",
      "publicKey":"publicKey"
    }
  ]
}
[       OK ] ensure_sumeragi_json_format.normal_sumeragi_json (30 ms)
[ RUN      ] ensure_sumeragi_json_format.bad_json
[       OK ] ensure_sumeragi_json_format.bad_json (2 ms)
[ RUN      ] ensure_sumeragi_json_format.bad_ip
1486128144 WARNING [peer service with json] IP <IP_ADDRESS>7 looks like not a valid ip.
1486128144 WARNING [peer service with json] IP <IP_ADDRESS>. looks like not a valid ip.
[       OK ] ensure_sumeragi_json_format.bad_ip (25 ms)
[ RUN      ] ensure_sumeragi_json_format.missing_key

/home/bogdan/tools/iroha/test/infra/config/inputs/no_group_ip.json
1486128144 WARNING [peer service with json] Not found: ip

/home/bogdan/tools/iroha/test/infra/config/inputs/no_group_name.json
1486128144 WARNING [peer service with json] Not found: name

/home/bogdan/tools/iroha/test/infra/config/inputs/no_group_publicKey.json
1486128144 WARNING [peer service with json] Not found: publicKey

/home/bogdan/tools/iroha/test/infra/config/inputs/no_me_ip.json
1486128144 WARNING [peer service with json] Not found: ip

/home/bogdan/tools/iroha/test/infra/config/inputs/no_me_name.json
1486128144 WARNING [peer service with json] Not found: name

/home/bogdan/tools/iroha/test/infra/config/inputs/no_me_privateKey.json
1486128145 WARNING [peer service with json] Not found: privateKey

/home/bogdan/tools/iroha/test/infra/config/inputs/no_me_publicKey.json
1486128145 WARNING [peer service with json] Not found: publicKey
[       OK ] ensure_sumeragi_json_format.missing_key (90 ms)
[ RUN      ] ensure_sumeragi_json_format.useless_key

/home/bogdan/tools/iroha/test/infra/config/inputs/useless_me_key.json
1486128145 WARNING [peer service with json] Unused keys: aaaa

/home/bogdan/tools/iroha/test/infra/config/inputs/useless_group_key.json
1486128145 WARNING [peer service with json] Unused keys: key123456
[       OK ] ensure_sumeragi_json_format.useless_key (27 ms)
[----------] 5 tests from ensure_sumeragi_json_format (174 ms total)

[----------] Global test environment tear-down
[==========] 5 tests from 1 test case ran. (175 ms total)
[  PASSED  ] 5 tests.

Thank you. And this output is what I have expected.

test.sh uses return code to determine if test failed or not.
Your code returns 1 (exit failure, bad json), so test.sh thinks that test has failed.
If test completes with success, make sure you return 0.
Also, some of these files are changed in feature/refactoring branch, make sure you pull it before accepting pull request.


unsloth installation problem

WARNING: Generating metadata for package unsloth produced metadata for project name unknown. Fix your #egg=unsloth fragments.
Discarding git+https://github.com/unslothai/unsloth.git: Requested unknown from git+https://github.com/unslothai/unsloth.git has inconsistent name: filename has 'unsloth', but metadata has 'unknown'
ERROR: Could not find a version that satisfies the requirement unsloth (unavailable) (from versions: none)
ERROR: No matching distribution found for unsloth (unavailable)

Sorry on the delay! Can you copy paste ur exact installation instructions here? Also is this Windows / Linux?

I'm using the llama 3 colab file, but on a vast.ai server:
!pip install "unsloth[colab-new] @ git+https://github.com/unslothai/unsloth.git"
!pip install --no-deps "xformers<0.0.26" trl peft accelerate bitsandbytes

I also tried
!pip install "unsloth @ git+https://github.com/unslothai/unsloth.git"
!pip install --no-deps "xformers<0.0.26" trl peft accelerate bitsandbytes

But I got the same error
Collecting unsloth@ git+https://github.com/unslothai/unsloth.git
  Cloning https://github.com/unslothai/unsloth.git to /tmp/pip-install-003vhf9y/unsloth_c51ad7c7d9274626a241db165f755ccb
  Running command git clone --filter=blob:none --quiet https://github.com/unslothai/unsloth.git /tmp/pip-install-003vhf9y/unsloth_c51ad7c7d9274626a241db165f755ccb
  Resolved https://github.com/unslothai/unsloth.git to commit 715e935b5eda5768d1bab6592095dc192ddab7e6
  Installing build dependencies ... done
  Getting requirements to build wheel ... done
  Installing backend dependencies ... done
  Preparing metadata (pyproject.toml) ... done
  WARNING: Generating metadata for package unsloth produced metadata for project name unknown. Fix your #egg=unsloth fragments.
Discarding git+https://github.com/unslothai/unsloth.git: Requested unknown from git+https://github.com/unslothai/unsloth.git has inconsistent name: filename has 'unsloth', but metadata has 'unknown'
ERROR: Could not find a version that satisfies the requirement unsloth (unavailable) (from versions: none)
ERROR: No matching distribution found for unsloth (unavailable)
Requirement already satisfied: xformers<0.0.26 in /usr/local/lib/python3.10/dist-packages (0.0.25.post1)
Requirement already satisfied: trl in /usr/local/lib/python3.10/dist-packages (0.8.6)
Requirement already satisfied: peft in /usr/local/lib/python3.10/dist-packages (0.11.2.dev0)
Requirement already satisfied: accelerate in /usr/local/lib/python3.10/dist-packages (0.31.0.dev0)
Requirement already satisfied: bitsandbytes in /usr/local/lib/python3.10/dist-packages (0.43.1)
WARNING: Running pip as the 'root' user can result in broken permissions and conflicting behaviour with the system package manager. It is recommended to use a virtual environment instead: https://pip.pypa.io/warnings/venv

Great!

i still having the issue when using torch 2.3.0
Collecting unsloth[cu118-torch230]@ git+https://github.com/unslothai/unsloth.git
  Cloning https://github.com/unslothai/unsloth.git to /tmp/pip-install-330e70xt/unsloth_e16b4b10e65e4517bd41fe552a1d709f
  Running command git clone --filter=blob:none --quiet https://github.com/unslothai/unsloth.git /tmp/pip-install-330e70xt/unsloth_e16b4b10e65e4517bd41fe552a1d709f
  Resolved https://github.com/unslothai/unsloth.git to commit b0781339f035c72b3028d846eb2261e8115cd375
  Installing build dependencies ... done
  Getting requirements to build wheel ... done
  Installing backend dependencies ... done
  Preparing metadata (pyproject.toml) ... done
  WARNING: Generating metadata for package unsloth produced metadata for project name unknown. Fix your #egg=unsloth fragments.
Discarding git+https://github.com/unslothai/unsloth.git: Requested unknown from git+https://github.com/unslothai/unsloth.git has inconsistent name: filename has 'unsloth', but metadata has 'unknown'
ERROR: Could not find a version that satisfies the requirement unsloth (unavailable) (from versions: none)
ERROR: No matching distribution found for unsloth (unavailable)

@yakov-rakhlin What is your python version?

@danielhanchen I'm using python 3.10

@yakov-rakhlin How about
pip install -U xformers --index-url https://download.pytorch.org/whl/cu121
pip install "unsloth[kaggle-new] @ git+https://github.com/unslothai/unsloth.git"

@danielhanchen
still the same issue:
Collecting unsloth[kaggle-new]@ git+https://github.com/unslothai/unsloth.git
  Cloning https://github.com/unslothai/unsloth.git to /tmp/pip-install-06ri50c8/unsloth_c8953b5c6a98482d9d1f77e79f604588
  Running command git clone --filter=blob:none --quiet https://github.com/unslothai/unsloth.git /tmp/pip-install-06ri50c8/unsloth_c8953b5c6a98482d9d1f77e79f604588
  Resolved https://github.com/unslothai/unsloth.git to commit b0781339f035c72b3028d846eb2261e8115cd375
  Installing build dependencies ... done
  Getting requirements to build wheel ... done
  Installing backend dependencies ... done
  Preparing metadata (pyproject.toml) ... done
  WARNING: Generating metadata for package unsloth produced metadata for project name unknown. Fix your #egg=unsloth fragments.
Discarding git+https://github.com/unslothai/unsloth.git: Requested unknown from git+https://github.com/unslothai/unsloth.git has inconsistent name: filename has 'unsloth', but metadata has 'unknown'
ERROR: Could not find a version that satisfies the requirement unsloth (unavailable) (from versions: none)
ERROR: No matching distribution found for unsloth (unavailable)

@yakov-rakhlin That's extremely weird - Colab works fine right? Windows / Linux?

@danielhanchen
running upgrade pip does solve the issue for me. i was able to install unsloth.
thanks for your assistance

Ran into the same problem. Had to run the pip3 install --upgrade pip command in WSL. Seems to be getting farther this time ....

It worked for me after updating pip, thank you @danielhanchen, pip install "pip==23.1.2"


fix(Modal): change overflow hidden to visible so content can be seen when exceeds Modal dimensions

fix(Modal): change overflow hidden to visible so content can be seen when exceeds Modal dimensions

🔗 Linked issue
Resolves #1459
❓ Type of change

[ ] 📖 Documentation (updates to the documentation or readme)
[x] 🐞 Bug fix (a non-breaking change that fixes an issue)
[ ] 👌 Enhancement (improving an existing functionality)
[ ] ✨ New feature (a non-breaking change that adds functionality)
[ ] 🧹 Chore (updates to the build process or auxiliary tools and libraries)
[ ] ⚠ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description
Changed overflow style form Modal component
📝 Checklist

[x] I have linked an issue or discussion.
[ ] I have updated the documentation accordingly.

Fixes


MBL-1919: API | Implement BuildPaymentPlan Query On Checkout Screen

📲 What
Hooked up BuildPaymentPlanQuery to the checkout flow for crowdfund checkout.
🤔 Why
PLOT
🛠 How
In crowdfund checkout, we call buildPaymentPlanQuery to see if the project has opted into PLOT, and pass the pledge amount to check that it meets the plot minimum.
Then we display the ui according to the response
If the user selects plot, we pass that value back to the CrowdfundCheckoutViewModel and change the incremental value to true or false, based on if they user opted in or out of plot
We pass that incremental value to the createBackingMutation
The plot ui should only be visible on checkout for new pledges.
It should NOT show:

on late pledges
on manage pledge checkout for regular pledges
on anything other than brand NEW pledges

👀 See
Dark mode - Plot allowed on project, ineligible and eligible, unselected and selected

Light mode - Plot allowed on project, ineligible and eligible, unselected and selected

📋 QA
There are a few test case scenarios. Please test these with dark and light mode, and logged in or out prior to backing:
Project = PLOT allowed, Pledge = ineligible (does not meet minimum):

Navigate to test project "Dubstep Raspberry Pi Album"
Go through pledge flow, set bonus amount to anything under $125
On checkout screen, plot and pay in full should both be displayed, but PLOT option is disabled and NOT selectable
Should show badge on plot option "Available for pledges over $125"
All other copy should be normal pledge copy
Hit the pledge button. Navigate to manage pledge, tap the button in the top right corner, should show all the normal manage pledge options (change reward, change payment method, etc etc)

Project = PLOT allowed, Pledge = eligible (meets the minimum)

Navigate to test project "Dubstep Raspberry Pi Album"
Go through pledge flow, set bonus amount to anything over $125 (previous minimum was $150, but was supposed to be changed to $125, not sure if the backend changed the minimum yet, but to be sure I usually set the bonus amount to $200)
On checkout screen, plot and pay in full should both be displayed, but PLOT option is enabled and selectable
Tapping on PLOT option expands the option, should see charge schedule, amounts, etc etc
Text describing plot should be visible
Copy displayed at bottom of screen should explain they will be charged for the first installment if the project is successful
copy displayed at bottom should show line item badge "Please Over Time" and text "Charged in as 4 payments"
Hit pledge, navigate to manage pledge, tap 3 dots in top right corner. Options should be limited to "Cancel Pledge" and "Contact Creator"

Project = PLOT not allowed

Navigate to any project that is NOT "Dubstep Raspberry Pi Album"
Go through pledge flow
On checkout page, should not see any collection plan options. Just the regular degular checkout flow
Pledging should

Manage Pledge = should not be able to opt into PLOT

Back  "Dubstep Raspberry Pi Album" with a regular pay in full pledge, NOT PLOT
Go to manage pledge, select "change payment method" or  "change reward"
Go through checkout flow. when landing on the checkout page, should NOT have the option to opt into plot. should not display plot ui at all.

Story 📖
MBL-1919: API | Implement BuildPaymentPlan Query On Checkout Screen

:warning: Please install the  to ensure uploads and comments are reliably processed by Codecov.
Codecov Report
Attention: Patch coverage is 52.48619% with 86 lines in your changes missing coverage. Please review.

Project coverage is 68.43%. Comparing base (95476a9) to head (2d989cd).

Files with missing lines
Patch %
Lines

...i/activities/compose/projectpage/CheckoutScreen.kt
0.00%
25 Missing :warning:

...tarter/ui/views/compose/checkout/CollectionPlan.kt
65.21%
12 Missing and 12 partials :warning:

...p/src/main/java/com/kickstarter/libs/KSCurrency.kt
21.42%
10 Missing and 1 partial :warning:

...java/com/kickstarter/libs/utils/RewardViewUtils.kt
25.00%
8 Missing and 1 partial :warning:

...com/kickstarter/libs/utils/extensions/StringExt.kt
0.00%
6 Missing :warning:

...ewmodels/projectpage/CrowdfundCheckoutViewModel.kt
83.78%
4 Missing and 2 partials :warning:

...com/kickstarter/models/extensions/StoredCardExt.kt
60.00%
2 Missing :warning:

...arter/services/transformers/GraphQLTransformers.kt
0.00%
2 Missing :warning:

app/src/main/java/com/kickstarter/models/Amount.kt
66.66%
1 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #2190      +/-   ##
============================================
+ Coverage     68.33%   68.43%   +0.10%
- Complexity     2171     2188      +17
============================================
  Files           351      351
  Lines         23435    23558     +123
  Branches       3426     3455      +29
============================================
+ Hits          16014    16122     +108
- Misses         5605     5610       +5
- Partials       1816     1826      +10

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Use bold colors

With the default colour schemes for xTerm, Linux console, Rxvt, the dark blue on black background is near unreadable. Bold blue would be much better. Red is similar but not as bad:

I was thinking it might be an idea to make all the colours configurable but on the other hand, it's just as easy to fork and local publish for oneself. I made mine look like this:

Thanks for the report! I just tried your branch. The result of your whole set of changes look really good, and make everything even easier to read.
Would you mind opening a PR with your config?

Yeah I was going to ask you about that.  I can create a PR with all the changes or just a subset that you're happy with.
To summarise my changes:

changed colours of filenames
made most colours bold so they are more readable on black backgrounds (at least in my envs)
in the by-filename report at the end

sort by filename
only print if more than one file
print total error/warning count per file
don't print line numbers
consolidate problem ids where possible (eg. [1-4,9] instead of [1,2,3,4,9])

print total errors and warnings

All of them sound good to me! Looking forward to the PR!

Great, I'll get a PR ready later this week!

Hey @japgolly, I've been looking in more details at your changes, and I had missed that you removed the line numbers from the summary. That's basically the reason why I created this reporter :( Can you think of a way of adapting your changes while keeping the line numbers from the summary? Maybe a flag that would let users switch between the 2 modes?

@japgolly Colors and such are now completely configurable. You can set, for instance:
reporterConfig := reporterConfig.value.withErrorIdColor(BLUE + BOLD)
                                      .withSourcePathColor(YELLOW + UNDERLINED)


Netpol warning is off

A bug report on slack describes an app that has the inbound policy set, but is warned regardless
https://nav-it.slack.com/archives/C5KUST8N6/p1694691711285449

@rbjornstad fixed this


Add CVE reference maps to create aliases

See https://cve.mitre.org/data/refs/index.html

These can also be used to create references