fix: only record bytecode if >0

Benchmark results
Metrics with a significant change:

protocol_circuit_proving_time_in_ms (base-rollup): 96,444 (+16%)
protocol_circuit_proving_time_in_ms (public-kernel-app-logic): 9,910 (+17%)
app_circuit_proving_time_in_ms (Token:transfer_public (avm)): 10,685 (+17%)

Detailed results
All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call  to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.
This benchmark source data is available in JSON format on S3 here.
Proof generation
Each column represents the number of threads used in proof generation.

Metric
1 threads
4 threads
16 threads
32 threads
64 threads

proof_construction_time_sha256_ms
5,782
1,556 (-1%)
695 (-2%)
765
773

proof_construction_time_sha256_30_ms
11,920
3,186
1,434 (+2%)
1,449
1,476

proof_construction_time_sha256_100_ms
44,163 (-1%)
12,668 (+3%)
5,670 (-1%)
5,570 (-1%)
5,522

proof_construction_time_poseidon_hash_ms
79.0
34.0 (-3%)
34.0
59.0
89.0

proof_construction_time_poseidon_hash_30_ms
1,534
420
201
229 (+1%)
270

proof_construction_time_poseidon_hash_100_ms
5,667
1,537
680 (-1%)
719 (-2%)
751

L2 block published to L1
Each column represents the number of txs on an L2 block published to L1.

Metric
4 txs
8 txs
16 txs

l1_rollup_calldata_size_in_bytes
4,324
7,844
14,852

l1_rollup_calldata_gas
49,732
92,464
177,404

l1_rollup_execution_gas
1,294,395
2,042,095
3,869,074

l2_block_processing_time_in_ms
260
443 (-2%)
865 (+3%)

l2_block_building_time_in_ms
9,618
18,820
37,688 (+1%)

l2_block_rollup_simulation_time_in_ms
9,617
18,819
37,687 (+1%)

l2_block_public_tx_process_time_in_ms
8,005
16,982
35,694

L2 chain processing
Each column represents the number of blocks on the L2 chain where each block has 8 txs.

Metric
3 blocks
5 blocks

node_history_sync_time_in_ms
2,969 (-1%)
3,825 (-1%)

node_database_size_in_bytes
12,734,544
16,932,944

pxe_database_size_in_bytes
16,254
26,813

Circuits stats
Stats on running time and I/O sizes collected for every kernel circuit run across all benchmarks.

Function
time_ms
bytecode_size_in_bytes

FeeJuice:_increase_public_balance
95.7 (+2%)
8,139

FeeJuice:set_portal
9.95 (-5%)
2,362

Token:constructor
120 (-8%)
31,107

FPC:constructor
94.3 (-3%)
22,380

FeeJuice:mint_public
78.1 (-4%)
6,150

Token:mint_public
93.9 (-1%)
11,720

Token:assert_minter_and_mint
80.3 (-1%)
8,028

AuthRegistry:set_authorized
7.09
4,537

FPC:prepare_fee
289 (+3%)
8,812

Token:transfer_public
31.7 (+25%)
47,374

FPC:pay_refund
61.1 (+1%)
12,114

Benchmarking:increment_balance
1,026 (+1%)
7,450

Token:_increase_public_balance
9.69 (+1%)
8,960

FPC:pay_refund_with_shielded_rebate
137 (+1%)
12,663

Public DB Access
Time to access various public DBs.

Function
time_ms

get-nullifier-index
0.165 (+4%)

Tree insertion stats
The duration to insert a fixed batch of leaves into each tree type.

Metric
1 leaves
16 leaves
64 leaves
128 leaves
256 leaves
512 leaves
1024 leaves

batch_insert_into_append_only_tree_16_depth_ms
2.19 (-2%)
3.94
N/A
N/A
N/A
N/A
N/A

batch_insert_into_append_only_tree_16_depth_hash_count
16.8
31.7
N/A
N/A
N/A
N/A
N/A

batch_insert_into_append_only_tree_16_depth_hash_ms
0.113 (-2%)
0.111
N/A
N/A
N/A
N/A
N/A

batch_insert_into_append_only_tree_32_depth_ms
N/A
N/A
11.4 (-2%)
17.8 (-7%)
31.5 (-1%)
58.7 (-6%)
115 (+1%)

batch_insert_into_append_only_tree_32_depth_hash_count
N/A
N/A
95.9
159
287
543
1,055

batch_insert_into_append_only_tree_32_depth_hash_ms
N/A
N/A
0.109 (-2%)
0.103 (-7%)
0.102 (-1%)
0.101 (-6%)
0.103 (+1%)

batch_insert_into_indexed_tree_20_depth_ms
N/A
N/A
14.4 (-2%)
26.4 (+1%)
46.7 (+5%)
82.2 (-3%)
171 (+6%)

batch_insert_into_indexed_tree_20_depth_hash_count
N/A
N/A
109
207
355
691
1,363

batch_insert_into_indexed_tree_20_depth_hash_ms
N/A
N/A
0.109 (-2%)
0.107 (+2%)
0.114 (+6%)
0.102 (-3%)
0.110 (+8%)

batch_insert_into_indexed_tree_40_depth_ms
N/A
N/A
16.4 (-2%)
N/A
N/A
N/A
N/A

batch_insert_into_indexed_tree_40_depth_hash_count
N/A
N/A
132
N/A
N/A
N/A
N/A

batch_insert_into_indexed_tree_40_depth_hash_ms
N/A
N/A
0.106 (-2%)
N/A
N/A
N/A
N/A

Miscellaneous
Transaction sizes based on how many contract classes are registered in the tx.

Metric
0 registered classes
1 registered classes

tx_size_in_bytes
64,756
668,997

Transaction size based on fee payment method
| Metric |  |
| - |  |


Add DualSense Haptic Feedback support

DualSense advanced haptic feedback can be triggered via audio channel sent to it. Actuators are used in this controller not vibration motors like in DS4 and in result it can give better vibration experience to users.
The feature is related to #131 due to the need of sending audio data to controller and compress it with SBC before send via Bluetooth.
Here is demo code that can work for USB use case (without compression): https://gist.github.com/Ohjurot/b0c04dfbd25fb71bc0da50947d313d1b
Related Linux driver code: https://github.com/torvalds/linux/blob/master/drivers/hid/hid-playstation.c (DS_OUTPUT_VALID_FLAG0_COMPATIBLE_VIBRATION shouldn't be set invalid_flag0 as far as I understand).

Very nice timing, this will certainly help my journey of DualSense emulation 👍

Related code for Bluetooth audio: https://github.com/sensepost/dual-pod-shock/blob/master/dual_pod_shock_POC.c
And description: https://sensepost.com/blog/2020/dualsense-reverse-engineering/

I think Roderick Colenbrander<EMAIL_ADDRESS>can be asked for some details on this - he is author of DualSense Linux kernel code support. :)
https://github.com/torvalds/linux/commit/51151098d7ab832f2a8b8f5c51fe224a9c98fdd5

Kudos to him 🙏


Not Importing Racial HD when it has class levels.

When an NPC has both racial HD and Class levels, the racial HD are not being imported (shows as 0 HD)

Example: https://www.aonprd.com/MonsterDisplay.aspx?ItemName=Amalya

Fixed in v3.1.1


Building a Lyrics Search App Using Vanilla Js

NOTE: All 1st-time contributors should know Topic approval and PR submission does NOT guarantee your Topic/Article will be published. Our team of Peer Reviewers and Content Moderators will review all PRs that come in to make sure they adhere to the standard of quality we expect from the EngEd community.
We expect all community memebers to go through provided examples, resources, and previously published material before submitting content. As a rule of thumb, please only submit articles (pull requests) that are complete, formatted correctly, and include a fully polished article (ready to be published and error free).
All revisions and edits should be completed on your own forked repo (as to not take up room in the queue). Any PR that is submitted incomplete (meaning not ready to be published as is) will be closed. A PR being closed does NOT mean the article can not be published (or fixed) it simply means that the edits, revisions, and fixes will happen outside of the queue.
Topic Suggestion
Building a Lyrics Search App Using Vanilla Js.
Pre-submission advice
By following all our pre-submission advice and reviewing our Resources folder, you will maximise your chances of your topic being approved.
We ask that you please be patient as our team works through approving and publishing all articles/tutorials in a timely manner.
Allow 1-3 days for a topic to be reviewed and/or approved - allow 3-7 days for an articles to be reviewed and/or published (subject to vary depending on volume and/or backlog of articles).
Be sure to visit our Resources Page for tools, resources, and example articles that will help you propose and write a successful article.
Please ensure that you have only one open issue + linked pull request at a time. This will ensure that we complete the article in a timely manner from inception to publishing.)
We tend to stray away or tend not to publish reviews/comparisons of commercial product offerings.
Writing sample(s):
Include any links or writing samples - to help our team better gauge your writing quality.
Proposal Submission
Proposed title of article
Your title should be descriptive of the article/tutorial. Be Specific.
Use keyword research to improve your article's SEO.
Proposed article introduction.
Not knowing the lyrics of the song is a problem most song-lovers encounter. In this article, we will be creating a platform where users can search for lyrics by entering the entering the artist name or title of the song.
This article works you through how to create a lyrics search app using html5, css3, vanilla js, async await with fetch method (ovh API) and es6 features like arrow functions.
For example, if the article is based on machine learning, use the following: [Machine learning] Introduction to Machine Learning.
If the article is based on developing an Android application, use the following: [Android] Developing Apps using Android.
ONLY viable topics to pick from:

API
Artificial Intelligence
Blockchain
Containers
Edge Computing
Languages
Machine Learning
Networking
Node.js
Security

Key takeaways
1.) Readers will learn how to work with DOM and event listeners.
2.) Readers will learn how to use template literals.
3.) Readers will learn how to fetch data from an api using async await with the fetch method.
4.) I will explain in step by step sequence how to build this from the markup(Html5),  to the css3 for styling and finally JavaScript for the functional part of the project.
5.) At the end of this article, readers will be able to build and customize a working lyrics search app the way they want.
Article quality
There are just few free lyrics api, which OVH lyrics API stands to be one of best. Beginners find it difficult to use this API in their project, as the documentation isn't beginner-friendly. In this article, I would give a step by step guide on fetching data(lyrics) using the OVH lyrics api, by building a fully functional lyrics search app. Users just input the name of the song or the artist name and the lyrics is returned.
References
Please list links to any published content/research that you intend to use to support/guide this article.
Conclusion
Finally, remove the Pre-Submission advice section and all our blockquoted notes as you fill in the form before you submit.
We look forwarding to reviewing your topic suggestion.
Templates to use as guides

How To Guide Template
Software Review Template
Tutorial Template

Please fill in the article's quality section @shegz101

@ahmadmardeni1 I just filled the article's quality section

Sounds like a helpful topic - let's please be sure it adds value beyond what is in any official docs and/or what is covered in other blog sites. (the articles should go beyond a basic explanation - and it is always best to reference any EngEd article and build upon it). @shegz101
Please be attentive to grammar/readability and make sure that you put your article through a thorough editing review prior to submitting it for final approval. (There are some great free tools that we reference in EngEd resources.)
ANY ARTICLE SUBMITTED WITH GLARING ERRORS WILL BE IMMEDIATELY CLOSED.
Please be sure to double-check that it does not overlap with any existing EngEd articles, articles on other blog sites, or any incoming EngEd topic suggestions (if you haven't already) to avoid any potential article closure, please reference any relevant EngEd articles in yours. - Approved

Closed #5700 via #6322


Incomplete information.

Type of issue
Typo
Description
[Enter feedback here]
A reference to the ArmDnsModelFactory.DnsARecordData factory would be helpful on the DnsARecordData Constructor page.
Page URL
https://learn.microsoft.com/en-us/dotnet/api/azure.resourcemanager.dns.dnsarecorddata.-ctor?view=azure-dotnet
Content source URL
https://github.com/Azure/azure-docs-sdk-dotnet/blob/master/xml/Azure.ResourceManager.Dns/DnsARecordData.xml
Document Version Independent Id
b1f6f435-ef70-0544-45dc-4ad04b5e0b1f
Article author
@azure-sdk
Metadata

ID: b12e77f5-7325-38f6-db72-8bed77364c60
Service: azure

Hi @bigtfromaz , the navigation on the top of the article shows and could reach the parent pages. Hope this could help.

Hi @bigtfromaz , The document is auto generated from our SDK source.
Regarding the usage question, you could check our usage sample: https://github.com/Azure/azure-sdk-for-net/tree/main/sdk/dns/Azure.ResourceManager.Dns/samples or test code: https://github.com/Azure/azure-sdk-for-net/tree/main/sdk/dns/Azure.ResourceManager.Dns/tests/Scenario.


Add callback as param to update() and scheduleUpdate()

Can write tests if need be. I'm not sure how hefty using spread/rest params is here, so feel free to suggest fixes! First ever PR btw, 😨

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.atomiks seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

After playing with my implementation here it doesn't really do what I want so I guess I'll close this now, maybe can resolve it in the future if need be...


feat: open registration for configured case references

Describe your changes
2313: https://pins-ds.atlassian.net/jira/software/c/projects/ASB/boards/166?selectedIssue=ASB-2313
Open registration for configured case references.
Type of change 🧩

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation update
[ ] Other (please explain in the description section above)

Checklist before requesting a review

[x] I have performed a self-review of my own code
[x] I have double checked this work does not include any hardcoded secrets or passwords
[ ] I have made corresponding changes to the documentation
[x] I have provided details on how I have tested my code
[x] I have referenced the ticket number above
[x] I have provided a description of the ticket
[x] I have included unit tests to cover any testable code changes

:tada: This PR is included in version 1.8.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:

:tada: This PR is included in version 2.18.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Add coveralls

Changes Unknown when pulling 89378343e4e01a3f78dc05e38735c15f5b3c54c1 on coverage into ** on master**.

Changes Unknown when pulling 63732f34dc60c33222ca011ab06597f0bfced9d0 on coverage into ** on master**.


Website Board administrator issue

No verification email is sent, emails sent to the board administrator give a microsoft send error that the email is not found or something like that, therefore, i cant post in forums

I've tested this on a new account and the email verification is sent.  I've also resent your activation, have you checked spam filters?

I checked my spam filters, and my inbox, nothing was recieved

I manually activated your account.

Thank you :)


'/docker-entrypoint.sh' not found

After update to go 1.7 I have this error
docker: Error response from daemon: Container command '/docker-entrypoint.sh' not found or does not exist.
I can`t even start container to see if this file exists

I found a solution, returning to containerd-0.2.2  fixed this error


Optimize HashBuild row storage by being join-type aware.

Description
In low cardinality Build-Side table cases, if the join is SEMI-variant or ANTI join, HashBuild side does not need to store all input rows, indiscriminately into the RowContainer before HashBuild step.
Instead, only rows with unique "join value"'s need to be stored, as the Join is used for "pruning" purpose.
Example:
Table A ANTI-JOIN Table B

Table A

1

2

3

Table B

1

1

2

2

3

3

Currently, HashBuild will store all 6 rows (1,1,2,2,3,3) before HashBuild. In big-data scenarios, this leads to OOM.
@mbasmanova @oerling

@shiyu-bytedance This is a good point. HashBuild::setupTable has some logic to determine whether to allow duplicates or not. Is this not working properly?

@mbasmanova You are right, setupTable has dedup logic and works correctly. Although I believe that before rows are inserted into the hashtable, they are "bufferred" in RowContainer, which practically stores every row.
This behavior, that, before being hashed, all rows are stored temporarily, results in "peaky" ram usage. I wonder if an improvement is possible here; for example, "stream" input rows into the hashtable as they come in.

before being hashed, all rows are stored temporarily, results in "peaky" ram usage.

This is a good point.

I wonder if an improvement is possible here; for example, "stream" input rows into the hashtable as they come in.

Makes sense. Would you like to prototype something like this?

@mbasmanova
Sure, happy to investigate and do a prototype for PR. Please assign this issue to me?

Thank you, @shiyu-bytedance

@mbasmanova updated title to be more reflective of what this ticket is based on our discussion.

We find the same issue in tpcds q14. There is a lot of duplicate key data in the left semi join, but the row container stores all the rows. @shiyu-bytedance Is there some progress so far?


hero names are not read from config.ui.ini in start up

If I define hero names in config.ui.ini file, they are not used when the game is started (even with --newGame switch). Characters are called to Captain, Hero 1, Hero 2, and so on.
However, the names are used after I use ctrl+a to start a new game.

This is now fixed on master by moving hero naming fully to client.


I cloned new repository for specific branch then i got workspace but no data recived on that workspace anyone knows help me on that

-------Please read and delete this text before creating the issue-------
To report a good issue, please verify that you validate these points:

[ ] you have read the documentation about command line options and advanced use cases
[ ] upgrade and test with the last version
[ ] specify the version you are using
[ ] include steps you followed to reproduce the problem
[ ] if the problem occurs when using a git-tfs command, please provide the output of the command when using the --debug command line option (providing a gist could be a clever idea ;))

And don't forget:

The fastest way to get an issue fixed is to submit a PR that fixes it.

The slowest way to get it fixed is to hope someone else will fix it.

Please follow the template. Not enough information given. Closing...


Update of wasm-pack release to resolve CVE's

The current version of wasm-pack (0.10.3) was last released on 14th June 2022. As there have been many dependency updates, this means that the version of wasm-pack and it's cargo.toml is affected by at least 6 CVE's.

RUSTSEC-2021-0078 -> crate: hyper, cvss: CVSS:3.1/AV:N/AC:L/PR:N/UI:N/S:U/C:N/I:L/A:N, class: []
RUSTSEC-2021-0079 -> crate: hyper, cvss: CVSS:3.1/AV:N/AC:L/PR:N/UI:N/S:U/C:N/I:H/A:H, class: []
RUSTSEC-2022-0032 -> crate: openssl-src, cvss: None, class: ['crypto-failure']
RUSTSEC-2022-0040 -> crate: owning_ref, cvss: None, class: ['memory-corruption']
RUSTSEC-2021-0124 -> crate: tokio, cvss: None, class: ['memory-corruption', 'thread-safety']
CVE-2022-31394 -> crate: hyper: dos in h2

Many of these are related to the older version of reqwest that is used by wasm-pack in 0.10.3 (0.9 rather than 0.11). This means simply running "cargo update" on the current release is not sufficient to resolve these issues.
It would be great for wasm-pack to make a new release from current main to resolve these, or for some of these updates/version changes to be backported down to the 0.10 release.
Thanks!

Should be resolved in v0.12.0:

https://github.com/rustwasm/wasm-pack/releases/tag/v0.12.0
https://crates.io/crates/wasm-pack/0.12.0
https://www.npmjs.com/package/wasm-pack/v/0.12.0


Example of bash script  that automatically extract tables and convert them to XLS

Thanks @laigor!
What do you think about moving this script to an examples folder and adding a bit of documentation as a comment at the top of it?

https://github.com/tabulapdf/tabula-java/wiki/Automatically-extract-tables-and-convert-them-to-XLS-using-bash-script.


[SuperEditor] make caret display optional when selection is expanded

Most text editors apparently hide the caret when a selection is expanded. IDEs, however, tend to always display the caret.
Make the display of a caret optional when the selection is expanded.

This ticket is blocked on moving caret painting from individual components into a document overlay.
There's an open PR heading that direction right now: #645


HBASE-25061 Update default URL to KEYS file in hbase-vote.sh

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 31s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 25s
Maven dependency ordering for branch

_ Patch Compile Tests _

+0 :ok:
mvndep
0m  9s
Maven dependency ordering for patch

_ Other Tests _

1m 53s

Subsystem
Report/Notes

Docker
Client=19.03.13 Server=19.03.13 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2416/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2416

Optional Tests

uname
Linux cca0f04cd742 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / e386ec566f

Max. process+thread count
50 (vs. ulimit of 12500)

modules
C:  U:

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2416/1/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 38s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+0 :ok:
shelldocs
0m  0s
Shelldocs was not available.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+0 :ok:
mvndep
0m 23s
Maven dependency ordering for branch

_ Patch Compile Tests _

+0 :ok:
mvndep
0m  8s
Maven dependency ordering for patch

+1 :green_heart:
shellcheck
0m  1s
There were no new shellcheck issues.

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

LGTM overall. Should the developer documentation for this flag and the download links also be updated with this one?

Let me address this concern and keep the PR ready.  U: .

 U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2416/2/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 58s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+0 :ok:
shelldocs
0m  0s
Shelldocs was not available.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+1 :green_heart:
mvninstall
5m 23s
master passed

+1 :green_heart:
mvnsite
14m 24s
master passed

+0 :ok:
refguide
6m 32s
branch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
4m 51s
the patch passed

+1 :green_heart:
mvnsite
12m 57s
the patch passed

+1 :green_heart:
shellcheck
0m  1s
There were no new shellcheck issues.

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
xml
0m  2s
The patch has no ill-formed XML file.

+0 :ok:
refguide
6m 36s
patch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.

_ Other Tests _

+1 :green_heart:
asflicense
0m 16s
The patch does not generate ASF License warnings.

54m 27s

Subsystem
Report/Notes

Docker
Client=19.03.13 Server=19.03.13 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2416/2/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2416

Optional Tests
dupname asflicense shellcheck shelldocs refguide mvnsite xml

uname
Linux dd3635438517 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / e386ec566f

refguide
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2416/2/artifact/yetus-general-check/output/branch-site/book.html

refguide
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2416/2/artifact/yetus-general-check/output/patch-site/book.html

Max. process+thread count
79 (vs. ulimit of 12500)

modules
C: . U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2416/2/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) shellcheck=0.4.6

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

Ah, thanks. Yes those are good too.

Oh, sorry. This was my first time making a PR from within GH's UI.


Only perform digest authentication if the server supports it

The middleware should only act if the server mentions the digest authentications scheme in the WWW-Authenticate header. Without checking the header, the middleware offers the header to the
Net::HTTP::Digest library which cannot handle it and it crashes.
Parsing/regexps for the header are inspired by RFC 2617: https://tools.ietf.org/html/rfc2617#section-3.2.1.

This also works when the server supports and offers multiple authentication methods (such as digest and NTLM), however the Net::HTTP::Digest library still crashes on this. See this PR for a proposed fix: https://github.com/drbrain/net-http-digest_auth/pull/16.

Coverage increased (+2.2%) to 92.683% when pulling 8d10720ec777d179bc509d19d64dbc074433c06a on paulvt:auth-when-needed into f94748c0ff25b3d8b427a83865fbb4deb3f35c00 on bhaberer:master.

Coverage increased (+2.2%) to 92.683% when pulling 8d10720ec777d179bc509d19d64dbc074433c06a on paulvt:auth-when-needed into f94748c0ff25b3d8b427a83865fbb4deb3f35c00 on bhaberer:master.

Thanks for the PR!


feat: added openai functions output parser class

Moved the output parsing function to a new class OpenAIFunctionsAgentOutputParser to match py
Added an entry-point for this class so it can be accessed externally (for use in openai function runnables, etc)

cc @jacoblee93, just a refactor so it can be exported in a class


alipay_kit_ios-6.0.1 lib库无法兼容x86 iOS模拟器

Error (Xcode): Building for iOS Simulator, but linking in object file built for iOS, file '/Users/sgxm/.pub-cache/hosted/pub.flutter-io.cn/alipay_kit_ios-6.0.1/ios/Libraries/utdid/AlipaySDK.framework/AlipaySDK' for architecture arm64
Could not build the application for the simulator.
Error launching application on iPhone 14 Pro Max.

+1

+1

post_install do |installer|
  installer.pods_project.targets.each do |target|
    target.build_configurations.each do |config|
      config.build_settings['EXCLUDED_ARCHS[sdk=iphonesimulator*]'] = 'arm64'
    end
  end
end

work for me

post_install do |installer|
  installer.pods_project.targets.each do |target|
    target.build_configurations.each do |config|
      config.build_settings['EXCLUDED_ARCHS[sdk=iphonesimulator*]'] = 'arm64'
    end
  end
end

work for me

work for me too, thank you!


Condense privileged RoleBinding

Skuba only needs some service accounts to have the
suse:caasp:psp:privileged ClusterRole in order to function. It is
redundant to also apply this RoleBinding to any authenticated user in
the kube-system namespace, since any service account (including
"default") already has this RoleBinding. This change cleans up the
redundancy.
This is not a security issue in itself because even with the redundancy
removed any service account in the kube-system namespace can still use
the privileged PSP, but it prepares the RoleBinding for further pruning
in the future.
Why is this PR needed?
Does it fix an issue? addresses a business case?
add a description and link to the issue if one exists.
Fixes #
Reminder: Add the "fixes bsc#XXXX" to the title of the commit so that it will
appear in the changelog.
What does this PR do?
please include a brief "management" technical overview (details are in the code)
Anything else a reviewer needs to know?
Special test cases, manual steps, links to resources or anything else that could be helpful to the reviewer.
Info for QA
This is info for QA so that they can validate this. This is mandatory if this PR fixes a bug.
If this is a new feature, a good description in "What does this PR do" may be enough.
Related info
Info that can be relevant for QA:

link to other PRs that should be merged together
link to packages that should be released together
upstream issues

Status BEFORE applying the patch
How can we reproduce the issue? How can we see this issue? Please provide the steps and the prove
this issue is not fixed.
Status AFTER applying the patch
How can we validate this issue is fixed? Please provide the steps and the prove this issue is fixed.
Docs
If docs need to be updated, please add a link to a PR to https://github.com/SUSE/doc-caasp.
At the time of creating the issue, this PR can be work in progress (set its title to [WIP]),
but the documentation needs to be finalized before the PR can be merged.
Merge restrictions
(Please do not edit this)
We are in v4-maintenance phase, so we will restrict what can be merged to prevent unexpected surprises:
What can be merged (merge criteria):
    2 approvals:
        1 developer: code is fine
        1 QA: QA is fine
    there is a PR for updating documentation (or a statement that this is not needed)

Hi!
New code has been merged in master regarding terraform 0.12. Please rebase your branch to take this changes in.
Happy hacking

This is clearly consistently not working although I can't exactly reproduce the issue, closing since I think it's not a priority to figure out.


if some faces in facebank not appear in video

Thank you very much for the job. Now i have a question, that's if facebank contains some faces that not appear in the inference video, that's to say i want to find out the faces which appear in the videos, can the code still work? I had a try but some mistake occured like following. if i want to solve this problem, how can i change the codes?
File "/media/luminous/6400d1cb-edcd-4607-817b-1b69856b6144/jzf/InsightFace_Pytorch-master/mtcnn.py", line 92, in detect_faces
keep = nms(bounding_boxes[:, 0:5], nms_thresholds[0])
TypeError: 'NoneType' object is not subscriptable

Hello @jzf1995
We are also facing this problem.
Did you resolve this ?


azure-image doesn't build with nixos-unstable-small

Issue description
I can't get azure-image to build with a branch of nixos-unstable-small.
It hangs at starting stage 2 (/nix/store/lp6sd4r785qhy77pxvfbyvfhk0cp5739-vm-run-stage2)
Steps to reproduce
git clone git@github.com:colemickens/nixpkgs.git
cd nixpkgs
git checkout bugreport
# note there's only one commit, bumping the version of qemu-img, this shouldn't impact the image build
cd nixos/maintainers/scripts/azure
./create-azure.sh

Output:
...
copying path '/nix/store/4vlpqqlw76r2yms47pra6m4dysv666gv-unit-polkit.service' to 'local'...
copying path '/nix/store/rbb67vh2llp8nkx9mr23l3cbw96lczz6-unit-dbus.service' to 'local'...
copying path '/nix/store/i2ks6i9k91gw1cgv56ag3081dxzabbrm-unit-systemd-fsck-.service' to 'local'...
copying path '/nix/store/9hc671d6sawnhrjpnm11csvk412aymzk-user-units' to 'local'...
copying path '/nix/store/p22imb8wql19hhsbf9ajw3sc91zsssgs-system-units' to 'local'...
copying path '/nix/store/69g0a9l3wqd2dabm08a89mdwllrdaxsz-etc' to 'local'...
copying path '/nix/store/761gcizvigvl8dm04jwaap56l9jbxmni-nixos-system-unnamed-18.09.git.03991bb' to 'local'...
copying channel...
installation finished!
copying staging root to image...
[    0.000000] Linux version 4.15.0 (nixbld@) (gcc version 7.3.0 (GCC)) #1 Tue Apr 10 04:20:30 UTC 2018
[    0.000000] bootmem address range: 0x7fffe9c00000 - 0x7fffeffff000
[    0.000000] Built 1 zonelists, mobility grouping on.  Total pages: 25249
[    0.000000] Kernel command line: mem=100M virtio_mmio.device=292@0x1000000:1
[    0.000000] Dentry cache hash table entries: 16384 (order: 5, 131072 bytes)
[    0.000000] Inode-cache hash table entries: 8192 (order: 4, 65536 bytes)
[    0.000000] Memory available: 100760k/102396k RAM
[    0.000000] SLUB: HWalign=32, Order=0-3, MinObjects=0, CPUs=1, Nodes=1
[    0.000000] NR_IRQS: 4096
[    0.000000] lkl: irqs initialized
[    0.000000] clocksource: lkl: mask: 0xffffffffffffffff max_cycles: 0x1cd42e4dffb, max_idle_ns:<PHONE_NUMBER>83 ns
[    0.000000] lkl: time and timers initialized (irq2)
[    0.000005] pid_max: default: 4096 minimum: 301
[    0.000033] Mount-cache hash table entries: 512 (order: 0, 4096 bytes)
[    0.000039] Mountpoint-cache hash table entries: 512 (order: 0, 4096 bytes)
[    0.006030] console [lkl_console0] enabled
[    0.006064] clocksource: jiffies: mask: 0xffffffff max_cycles: 0xffffffff, max_idle_ns:<PHONE_NUMBER>2750000 ns
[    0.006071] xor: automatically using best checksumming function   8regs
[    0.006189] random: get_random_u32 called from bucket_table_alloc+0x80/0x2d0 with crng_init=0
[    0.006260] NET: Registered protocol family 16
[    0.172122] raid6: int64x1  gen()  3437 MB/s
[    0.344114] raid6: int64x1  xor()  1927 MB/s
[    0.516077] raid6: int64x2  gen()  4026 MB/s
[    0.691532] raid6: int64x2  xor()  1770 MB/s
[    0.888004] raid6: int64x4  gen()  1116 MB/s
[    1.073002] raid6: int64x4  xor()   899 MB/s
[    1.247861] raid6: int64x8  gen()  2005 MB/s
[    1.338777] random: fast init done
[    1.419744] raid6: int64x8  xor()  2342 MB/s
[    1.419758] raid6: using algorithm int64x2 gen() 4026 MB/s
[    1.419763] raid6: .... xor() 1770 MB/s, rmw enabled
[    1.419794] raid6: using intx1 recovery algorithm
[    1.419976] clocksource: Switched to clocksource lkl
[    1.420146] NET: Registered protocol family 2
[    1.420365] TCP established hash table entries: 1024 (order: 1, 8192 bytes)
[    1.420426] TCP bind hash table entries: 1024 (order: 1, 8192 bytes)
[    1.420443] TCP: Hash tables configured (established 1024 bind 1024)
[    1.420574] UDP hash table entries: 128 (order: 0, 4096 bytes)
[    1.420593] UDP-Lite hash table entries: 128 (order: 0, 4096 bytes)
[    1.420720] virtio-mmio: Registering device virtio-mmio.0 at 0x1000000-0x1000123, IRQ 1.
[    1.421313] workingset: timestamp_bits=62 max_order=15 bucket_order=0
[    1.422581] SGI XFS with ACLs, security attributes, no debug enabled
[    1.428708] jitterentropy: Initialization failed with host not compliant with requirements: 2
[    1.428732] io scheduler noop registered
[    1.428737] io scheduler deadline registered
[    1.428863] io scheduler cfq registered (default)
[    1.428875] io scheduler mq-deadline registered
[    1.428879] io scheduler kyber registered
[    1.428904] virtio-mmio virtio-mmio.0: Failed to enable 64-bit or 32-bit DMA.  Trying to continue, but this might not work.
[    1.433736]  vda: vda1
[    1.434121] NET: Registered protocol family 10
[    1.434655] Segment Routing with IPv6
[    1.434689] sit: IPv6, IPv4 and MPLS over IPv4 tunneling driver
[    1.435247] Btrfs loaded, crc32c=crc32c-generic
[    1.435499] Warning: unable to open an initial console.
[    1.435534] This architecture does not have kernel memory protection.
[    1.438122] EXT4-fs (vda1): mounted filesystem with ordered data mode. Opts:
[    3.219318] random: crng init done
[   12.394270] reboot: Restarting system
WARNING: Image format was not specified for 'nixos.raw' and probing guessed raw.
         Automatically detecting the format is dangerous for raw images, write operations on block 0 will be restricted.
         Specify the 'raw' format explicitly to remove the restrictions.
cSeaBIOS (version rel-1.11.0-0-g63451fca13-prebuilt.qemu-project.org)

iPXE (http://ipxe.org) 00:03.0 C980 PCI2.10 PnP PMM+3FF912F0+3FEF12F0 C980

Booting from ROM...
Probing EDD (edd=off to disable)... ok
cloading kernel modules...
mounting Nix store...
mounting host's temporary directory...
starting stage 2 (/nix/store/lp6sd4r785qhy77pxvfbyvfhk0cp5739-vm-run-stage2)
^Cerror: interrupted by the user

FULL OUTPUT: https://gist.github.com/colemickens/ee6030926248ee2d0d305c4fd120506d
Technical details
(the above should cover it)
Please run nix-shell -p nix-info --run "nix-info -m" and paste the
results.
 - system: `"x86_64-linux"`
 - host os: `Linux 4.14.36, NixOS, 18.09.git.fa39203 (Jellyfish)`
 - multi-user?: `yes`
 - sandbox: `no`
 - version: `nix-env (Nix) 2.0.1`
 - channels(root): `"nixos"`
 - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos/nixpkgs`

(I'm not sure this will be applicable since the ./create-azure script references it's own nixpkgs enlistment via a local path...)

cc: @copumpkin I think you refactored some stuff in make-disk-image.nix, probably since the last time anyone tried to build an Azure image. Do you have any pointers?
cc: @jbgi I saw you make an azure-image PR, have you seen this? What branch of nixpkgs do you build with?

I think @edolstra basically rewrote most of the image building code since that refactor

It looks like is 9pfs related. A similar thread: https://lists.gt.net/linux/kernel/2599597

@colemickens I did not try to build an image. I originally just used the existing 16.09 image, upgraded it from time to get the 18.03-based image we use now.

@jbgi thanks for the information.
It seems that I can build images on one of my local machines. Must be an oddity of running qemu in an Azure VM or something?
I don't know whether to leave this open or closed. I'll leave it up to someone else.

@colemickens I think all my patches about 9pfs hangs are merged in recent kernels, that shouldn't be the problem.

It seems that I can build images on one of my local machines. Must be an oddity of running qemu in an Azure VM or something?

That's almost certainly it. Nested hardware accelerated virtualization seems just to be horribly broken in Linux.

This had worked in the past, but I think the VM I was building on yesterday is one of the SKUs that specifically has nested virtualization enabled.
I may end up patching the qemu invocation to disable KVM. It will probably be net faster based on how slow my upload is. Thanks for mentioning it, I hadn't really thought about it.

Yeah, I've also found that nested virtualization has basically stopped working entirely for me in the past year or so.

I think this actually came down to me using a commit from nixos-unstable-small. I had been building images for Azure for a few weeks on an Azure VM without issue, and without having to take steps to disable nested virtualization. Must've been something weird with qemu/kvm/etc at a single point in time... Either way, closing this out.


Can't find raw hex of a transaction

Using recent git build on testnet, listunspent shows:
{
			"address_type": 0,
			"address": "tb1qrs7t2eymme2ywupy4l385qzkphkdyjzlkyk2wn",
			"amount_sat": 2309600,
			"pk_script": "00141c3cb5649bde54477024afe27a00560decd2485f",
			"outpoint": "ac6b5aac6d974a7f5db4f94c1b030132edd206652db61ec96a59e51fd3898494:0",
			"confirmations": 0
		}

Which was created via: sendcoins tb1qy9wvwra0ly3r0wv7uv5trwruf29h5fly4apn3a 500000
However that transaction is not getting mined, nor appearing in other nodes.
Trying to see the raw hex of it, using listchaintxns returns:
        {
            "tx_hash": "ac6b5aac6d974a7f5db4f94c1b030132edd206652db61ec96a59e51fd3898494",
            "amount": "-507050",
            "num_confirmations": 0,
            "block_hash": "",
            "block_height": 0,
            "time_stamp": "1564342371",
            "total_fees": "7050",
            "dest_addresses": [
            ],
            "raw_tx_hex": ""
        }

(note how it's missing the raw_tx_hex field)

Snippet of logs around the time the transaction was created:
2019-07-28 19:31:43.192 [WRN] BTCN: No peers replied to inv message for transaction b5d6e10ffb4a77cd62e549fb64e41a8eeaf7a648a31327168e511b5b6d93be1f
2019-07-28 19:31:43.692 [WRN] BTCN: No peers replied to inv message for transaction 071d1211d0ac1b6e743c9892fbfc02fbcd7480c52c5b55b5aab2b4efe757f2e2
2019-07-28 19:32:42.691 [WRN] BTCN: No peers replied to inv message for transaction 071d1211d0ac1b6e743c9892fbfc02fbcd7480c52c5b55b5aab2b4efe757f2e2
2019-07-28 19:32:43.191 [WRN] BTCN: No peers replied to inv message for transaction 696832e533fb684efdbf8dd92532ae603a6aad80b4fa94aeb7993bde45a66d03
2019-07-28 19:32:43.692 [WRN] BTCN: No peers replied to inv message for transaction b5d6e10ffb4a77cd62e549fb64e41a8eeaf7a648a31327168e511b5b6d93be1f
2019-07-28 19:32:51.857 [INF] RPCS: [sendcoins] addr=tb1qy9wvwra0ly3r0wv7uv5trwruf29h5fly4apn3a, amt=0.005 BTC, sat/kw=12500, sweep_all=false
2019-07-28 19:32:51.980 [INF] LNWL: Inserting unconfirmed transaction ac6b5aac6d974a7f5db4f94c1b030132edd206652db61ec96a59e51fd3898494
2019-07-28 19:32:52.484 [WRN] BTCN: No peers replied to inv message for transaction ac6b5aac6d974a7f5db4f94c1b030132edd206652db61ec96a59e51fd3898494
2019-07-28 19:32:52.484 [INF] RPCS: [sendcoins] spend generated txid: ac6b5aac6d974a7f5db4f94c1b030132edd206652db61ec96a59e51fd3898494
2019-07-28 19:33:42.691 [WRN] BTCN: No peers replied to inv message for transaction 696832e533fb684efdbf8dd92532ae603a6aad80b4fa94aeb7993bde45a66d03
2019-07-28 19:33:43.192 [WRN] BTCN: No peers replied to inv message for transaction b5d6e10ffb4a77cd62e549fb64e41a8eeaf7a648a31327168e511b5b6d93be1f
2019-07-28 19:33:43.192 [WRN] BTCN: No peers replied to inv message for transaction 071d1211d0ac1b6e743c9892fbfc02fbcd7480c52c5b55b5aab2b4efe757f2e2
2019-07-28 19:33:43.192 [WRN] BTCN: No peers replied to inv message for transaction ac6b5aac6d974a7f5db4f94c1b030132edd206652db61ec96a59e51fd3898494
2019-07-28 19:34:42.191 [WRN] BTCN: No peers replied to inv message for transaction b5d6e10ffb4a77cd62e549fb64e41a8eeaf7a648a31327168e511b5b6d93be1f

Problem was solved by kill -9'ing lnd, and restarting. 696832e533fb684efdbf8dd92532ae603a6aad80b4fa94aeb7993bde45a66d03 got successfully pushed out on restart.

@riperk  The raw transactions are in listchaintxns.

@molxyz  Did you see the part where I wrote: "Trying to see the raw hex of it, using listchaintxns returns:"
(FWIW: After the restart, I now see the raw hex.)

@riperk Ah ok. Sorry I wasn't clear if you knew this is only available in the current version 0.7.0, not the older versions afaik.  All good then.

@riperk everything's good then? Was unable to reproduce, raw_tx_hex was shown for unconfirmed and confirmed transactions.

Everything resolved itself after the reset, yeah. But there's still an underlying bug lurking somewhere =)
Interestingly the unconfirmed transaction ac6b5aac6d974a7f5db4f94c1b030132edd206652db61ec96a59e51fd3898494 had no unconfirmed parents at the time of creation, and was very standard. So there's no real reason it shouldn't have been propagated (it only got propagated after the reset).

I see that you're using neutrino. It's possible for the transaction to not propagate properly if your peers don't respond within a timeout. The timeout could've been exceeded for different reasons (handling other requests, latency, etc.), which is why we regularly rebroadcast them.
Will close for now, feel free to re-open/comment if you're able to reproduce this reliably/provide more details.


Banner encouraging Bicep use on the MS Template reference docs?

For anyone who hasn't heard of Bicep it would be great to have some sort of banner at the top of the page under the various template reference docs -e.g. https://docs.microsoft.com/en-us/azure/azure-resource-manager/templates/template-functions.

Seems like a reasonable suggestion. @tfitzmac / @mumian / @stephaniezyen / @ucheNkadiCode -- any concerns?

@davidsmatlak is working on this.

On the ARM template overview we have a Tip that points people towards Bicep. @davidsmatlak - in addition to the specific links that go from each section of function to the Bicep equivalent, it might be good to add a general Tip at the top. It might be more visible.

We also have a Tip on the first ARM template tutorial. Maybe the same tip could be added to the initial quickstarts, and the template reference landing page.

#assign:davidsmatlak

I'll create a work item for myself and update the articles.

@tfitzmac / @mumian / @stephaniezyen / @ucheNkadiCode
I added a Tip with links to Bicep content in the introduction of the following published articles:

ARM template all functions. Each section in the article also includes links to Bicep content.
ARM functions docs (array, comparison, date, etc)
Quickstart: Create ARM templates with Visual Studio Code
Tom added a Tip to Define resources with Bicep and ARM templates

Thanks @davidsmatlak - looks good


latest image tags used in the release code

When using a tagged version of the code the image tag specified for the manager is always latest, but the payload images are tagged to specific digests. Therefore if I try to use version v0.7.0 it doesn't work because of the changes in the way that the runtimeclass gets created in recent updates.
https://github.com/confidential-containers/operator/blob/v0.7.0/config/manager/kustomization.yaml#L13-L16
images:
- name: controller
  newName: quay.io/confidential-containers/operator
  newTag: latest

It would be benefical it the newTag was v0.7.0 in this case. But I understand that that is not a simple fix as the tag gets created as part of the release process.

Yeah, we have a bit of a cycle here - IIUC the release image of the operator is created by the release process after the tag is done, so if we updated the kustomize to point to this tag before this is cut then I assume that all the tests will fail. I agree that pointing to latest isn't ideal though.
/cc @bpradipt @jensfr @fidencio who might have thoughts/ideas on this

On peer pods we have a similar issue. There we point to the tag (commit SHA) of the latest built cloud-api-adaptor image before the commit that bump the version. It doesn't point to the version tagged image but at least it will be pinned rather than following latest.
To implement that approach on the operator,  we would need to change https://github.com/confidential-containers/operator/blob/main/.github/workflows/docker-publish-latest-on-merge.yml to tag the image with the commit SHA; currently that workflow only publishes to latest.
@fitzthum you might be interested on this issue...


chore: bdd-gh-1586119293 to 0.0.1

chore: Promote bdd-gh-1586119293 to version 0.0.1

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approvers:
If they are not already assigned, you can assign the PR to them by writing /assign  in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


Implement feedback on AWS support

Summary
This PR is based on https://github.com/mattermost/mattermost-plugin-apps/pull/191 and implements some feedback of mine. I've went through the logging calls of the whole code base and fixed some inconsistencies.
Ticket Link
None

Codecov Report

Merging #193 (4dd8630) into lev-onprem-aws (7467ebc) will increase coverage by 0.06%.
The diff coverage is 6.66%.

@@                Coverage Diff                 @@
##           lev-onprem-aws     #193      +/-   ##
==================================================
+ Coverage           23.64%   23.70%   +0.06%
==================================================
  Files                  29       29
  Lines                1438     1434       -4
==================================================
  Hits                  340      340
+ Misses               1066     1062       -4
  Partials               32       32

Impacted Files
Coverage Δ

server/proxy/expand.go
10.90% <0.00%> (ø)

server/proxy/install.go
0.00% <0.00%> (ø)

server/proxy/proxy.go
23.14% <0.00%> (ø)

server/proxy/synchronize.go
0.00% <0.00%> (ø)

server/store/apps.go
0.00% <0.00%> (ø)

server/store/manifest.go
0.00% <0.00%> (ø)

server/proxy/bindings.go
83.33% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7467ebc...4dd8630. Read the comment docs.


:hover styles

Is there a way to generate :hover styles from the name of the image?

Hi Todd,
I'm using the version 4.6.1 and I have the following task in the Gruntfile.js
sprite: {
  icons: {
    src: 'styles/img/sprites/icons/*.png',
    dest: 'styles/img/icons.png',
    destCss: 'styles/css/icons.css',
    cssTemplate: 'styles/img/sprites/sprite.mustache',
    cssOpts: {
      cssClass: function (item) {
          return '.sprite-' + item.name + ':hover';
      }
    }
  }
},

but still does not see the hover state in the resulted css.
Can you please clarify what I'm doing wrong.
Thank you!

@yuyokk There are a few things wrong with your setup:

As of 3.0.0, cssClass has been renamed to cssSelector to be more generic

https://github.com/Ensighten/grunt-spritesmith/tree/4.6.1#breaking-changes-in-300

You are using a custom CSS template. The cssSelector is used by the normal CSS template so your cssOpts are currently in vain.

https://github.com/twolfson/spritesheet-templates/blob/9.5.0/lib/templates/css.template.js#L15-L18

To remedy your issue, the clearest options are:

Stop using a custom CSS template (i.e. remove cssTemplate)

sprite: {
  icons: {
    src: 'styles/img/sprites/icons/*.png',
    dest: 'styles/img/icons.png',
    destCss: 'styles/css/icons.css',
    cssOpts: {
      cssClass: function (item) {
          return '.sprite-' + item.name + ':hover';
      }
    }
  }
},

Update your custom CSS template to append :hover classes

You can remove cssOpts as this is no longer used

@twolfson
this solution works for me.

Stop using a custom CSS template

Thank you for the reply. I appreciate it!

Thank, useful feature


Policy updates and fixes

Closes #102
Closes #109
Closes #110
Closes #96
Closes #124
This PR updates the PSS restricted policy "restrict-seccomp" to comply with the latest published standard and adds much more comprehensive tests.
It also updates the message Kyverno prints in the "require drop all" policy to indicate that ALL must be specified in all caps.

Reminder: Once merged, this and all other PSS policies must be copied to kyverno/kyverno Helm chart's relevant policies as these are maintained separately.

@JimBugwadia please review

Ok, in resolving conflicts I shouldn't have merged into main, I guess. It looks like it picked up previous commits. @JimBugwadia can you please review?


merge from arlac77/npm-package-template

package.json

chore(scripts): cover@#overwrite c8 -x 'tests/**/*.mjs' --temp-directory build/tmp ava && c8 report -r lcov -o build/coverage --temp-directory build/tmp
chore(engines<EMAIL_ADDRESS>chore(package): set $.ava.require='esm' as in template
chore(package): set $.ava.files='tests/*-test.mjs' as in template
chore(package): set $.ava.extensions='mjs' as in template

.travis.yml

chore(travis): remove node versions 10.16.2,12.8.0
chore(travis): add node versions -10,-11,-12,10.16.3,12.8.1

Coverage remained the same at 98.438% when pulling 26dc3b5dd8d4abfba60528802d596fbbe59b0d26 on npm-template-sync/1 into e535a11567ef189c27612d1708b436ff2d935214 on master.

:tada: This PR is included in version 2.1.8 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Add a manpage.

I added this to the Debian package for DMRconfig but you are welcome to include it directly in the main repo.

Hello Mr. Marier...
Are you suggesting I should/can modify man pages on 'dmrconfig' github project pages?
If that's possible, I'd love to contribute.
Please let me know.
Thank you.
Damien
‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐
On Sunday, September 20, 2020 5:14 PM, Francois Marier<EMAIL_ADDRESS>wrote:

I added this to the Debian package for DMRconfig but you are welcome to include it directly in the main repo.

You can view, comment on, or merge this pull request online at:
https://github.com/sergev/dmrconfig/pull/57
Commit Summary

Add a manpage.

File Changes

A dmrconfig.1 (78)

Patch Links:

https://github.com/sergev/dmrconfig/pull/57.patch

https://github.com/sergev/dmrconfig/pull/57.diff

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

@user111222333 You can send any changes to me<EMAIL_ADDRESS>and I will merge them into the Debian repository (https://salsa.debian.org/debian-hamradio-team/dmrconfig) before updating this pull request.


Issue 22383 is solved so now can use noreturn

However, this is still draft because the compiler ICEd when testing

Some minor advantages:

Removes a redundant custom type
only() can be used to initialize other types that accept a slice
front and friends become noreturn as well, diagnosing some misuse (but that's really hypothetical)

only() can be used to initialize other types that accept a slice

Isn't the entire point of using Voldemort types to prevent users from relying on the concrete types of ranges? The only guarantee only currently makes about its return value is that it is "A RandomAccessRange"  [1]. If someone wants to initialize a slice with only(), they should be using only().array.
Regardless, if this is intended to be a supported use-case, there should be a unit test for it.
[1] https://dlang.org/phobos/std_range.html#only

@dukc I am going to close this as the implementation of noreturn is still half baked. We can come back to this later.

@dukc I am going to close this as the implementation of noreturn is still half baked. We can come back to this later.

Okay

Seems strange to close this outright. Why not label as "blocked" if it's only being held back by compiler issues?

@pbackus I did not see the point in having this PR in the queue while noreturn is still semi-implemented. However, indeed, we can keep it open and label it as blocked.

Issue 22390 has been fixed. Let's give this another spin.

Tried to get this to compile. You guessed it: 1-3 more ICEs dug up from this rabbit hole. Here: https://issues.dlang.org/show_bug.cgi?id=23331

I close this for now. This PR has resulted in three different ICE reports already. When this PR compiles and passes the tests after enought ICEs are solved, it's still likely that some client code that happens to use empty only() in a different way will ICE after a compiler update.


Do not remove comments from values.yaml in UI

When adding an app/helm the comments from the original values.yaml are removed
Many chart maintainers provide helpful guidance in the form of comments, removing them makes it challenging to deploy new charts.

I agree but this would require backend changes as the values are currently delivered as already parsed into JSON and the comments are gone at that point.

I agree but this would require backend changes as the values are currently delivered as already parsed into JSON and the comments are gone at that point.


show separator in filtered quick pick

Show separators in the quick pick also when the list is filtered.
This can only be supported if sorting is disabled.

Thanks @TylerLeonhardt !


Vietnamese localization

Add Vietnamese language plz, Thank you so much!
          /**
             * FlipClock Vietnamese Language Pack
             *
             * This class will used to translate tokens into the Vietnamese language.
             *
             */

            FlipClock.Lang.Spanish = {

                'years'   : 'Năm',
                'months'  : 'Tháng',
                'days'    : 'Ngày',
                'hours'   : 'Giờ',
                'minutes' : 'Phút',
                'seconds' : 'Giây'

            };

            /* Create various aliases for convenience */

            FlipClock.Lang['vn']      = FlipClock.Lang.Spanish;
            FlipClock.Lang['vn-vn']   = FlipClock.Lang.Spanish;
            FlipClock.Lang['vietnamese'] = FlipClock.Lang.Spanish;

Thank you, @hoangnm89. I will make corrections to the classes and add to the upcoming release.

This has been integrated into the js-es6 branch, which is the new v1 draft release.


exploitdb: 2023-05-12 -> 2023-05-14

Diff: https://gitlab.com/exploit-database/exploitdb/-/compare/refs/tags/2023-05-12...2023-05-14
Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 231942 run on x86_64-linux 1

1 package built:

exploitdb


feat(rate-limiting) remove timer and phase handlers

Summary
Context:

starting timers on busy servers on each request will just move  the load elsewhere
there is little chance that upstream sets rate-limiting headers, so we can just set them on access

So this PR removes timers and all the phase handlers except access from rate-limiting plugin. Yes, it might add some latency to request, but on a bright side we have more accurate rate-limits.
Issues Resolved
This might fix #5311

@bungle @hishamhm are we still considering to add this feature?

@bungle @hishamhm are we still considering to add this feature?

I think it should be merged.

When can this PR be merged & released? We find the same problem.

When can this PR be merged & released? We find the same problem.

The #6802 contains most of this PR, except timer removal, so it is still a slightly less accurate.


App install issue on quest

Hi, following these directions:

From Oculus Store
You can download ALVR Client from Oculus Store with key.
Open the key distribution page on your smartphone and follow the instruction.

I entered the code on my phone, and it seemed to be stuck downloading forever.
Now it does not show in my library,  but if I re-add the code I get an error on my phone saying I already own that item.
Do I need to have a developer Account on oculus to do this?

Key distribution is for GearVR and Go.
For Quest, you need to register as developer and install apk.
Follow this guide. https://uploadvr.com/how-to-sideload-apps-oculus-go/
2019年5月27日(月) 9:04 Jack Fruh<EMAIL_ADDRESS>
Hi, following these directions:
From Oculus Store
You can download ALVR Client from Oculus Store with key.
Open the key distribution page on your smartphone and follow the
instruction.
I entered the code on my phone, and it seemed to be stuck downloading
forever.
Now it does not show in my library, but if I re-add the code I get an
error on my phone saying I already own that item.
Do I need to have a developer Account on oculus to do this?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/polygraphene/ALVR/issues/316?email_source=notifications&email_token=AAU7XEELJ3ALIFFL2YXTO4LPXMQQBA5CNFSM4HPXX452YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4GV5NGIA,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAU7XEH4V4GEQU2A7PCKNB3PXMQQBANCNFSM4HPXX45Q
.


Pass info throw a listener

I'm trying to pass a info contained on the item (like price) to a new activity when press the Request button, so i need get first the info using something like "items.get(i).getBoxID()" the problem is  when i do
for(int i = 0; i< items.size(); i++) {
final ArrayList  idboxes = new ArrayList<>();
final int finalI = i;
items.get(i).setRequestBtnClickListener(new View.OnClickListener() {
            @Override
            public void onClick(View v) {
                Toast.makeText(getApplicationContext(), "CUSTOM HANDLER FOR FIRST BUTTON", Toast.LENGTH_SHORT).show();
                System.out.println(items.get(i).getBoxID());
            }
        });

}
on the println there is a error with the i variable the code need to be final but that doesn't do what i need
any idea?

Solved using the listener on the item and not on the adaptor

Hey,
may you post your solution?
I am struggling with quite the same problem, I want to pass infos from current cell when pressing the button.
Thank you!

Thomas the proyec was 1 year ago and I dont remember all :/ but he solutión was quite simple, on item of each element I store the listeners.
The item have all the info, so you can use that as a guide.
the code on the first comment its de solution i found
sorry for my english


Out of Source Builds for WASM

Why the .wast and .abi file exist in the "eos/contract/currency/" rather than "eos/build/contract/currency" ?

Closing in favor of #246 -- questions about building contracts should go there.


Exercising block level tb

While exercising below block level test benches in VCS facing simulation hang /run for long time , updated file list from config path
Is any inputs files needs to be added/updated?
ECC, CSR,DOE, soc_ifc

Not able to run ECC block/ip test can you please share the steps?

To run ECC block testbench:

Compile the testbench source using ecc_top_tb.vf
In the output/run folder, execute cp $CALIPTRA_ROOT/src/ecc/tb/test_vectors/mm_test_vectors*.hex . as shown here
Execute the sim. Depending on which test you intend to run, provide the necessary plusargs. Plusargs to use are defined for each test here


⚠ Processors has degraded performance

In 9aeda66, Processors ($STATUS_URL) experienced degraded performance:

HTTP code: 200
Response time: 194 ms

Resolved: Processors performance has improved in 0e39263.


⚠ ClamAV has degraded performance

In adc9b1b, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 173 ms

Resolved: ClamAV performance has improved in 524790b.


SimpleBar together with Framework7

Actually simple bar is exactly want I was looking for, but
I am using simpleBar together with framework7. After some page changes simplebar is not working any longer. All the simplebar warappers are still available, recalculate does not help.
Example
Sandbox: https://codesandbox.io/s/floral-https-t9nuf?file=/app.js
Fullscreen: https://t9nuf.csb.app/
(1) click on "Info"
(2) page incl scroll bar is generated; everything is working
(3) go back
(4) click on "info" again
-> Scrolling is possible, but no scrollbar is shown any more...
Any thoughts? It seems that the listeners are lost...

Hey, thanks for the reproductible example, that's interesting!
It seems like this framework is caching the page content for reuse. I guess you noticed that since you put a new Date() and we can see the time is always the same so the page content is never re-rendered.
The problem here is that SimpleBar is unmounting automatically when it's being removed from the DOM (when you press "back"), but when it's called again, SimpleBar thinks it's already mounted because the DOM is already set with data-simplebar="init" on it, so it doesn't mount again. Which makes it not work!
However this problem has been solved in the latest beta version! But after testing I just realised there is another issue with the browser version of SimpleBar, which hopefully should be solved soon, so please keep an eye on this.

Hi Adrien,
many thanks for looking at this topic. I noticed as well that it seems that all the bindings are lost and the events (like touch) are not longer received (all the wrappers remain)
Would be great if this is solved with the next version...
Many thanks & best regards
Andreas

Hi Adrien,
do you have a rough idea when the next version (solving this issue) will be available?
Many thanks & best regards
Anton

Closing as hopefully this is fixed by now!


Classif documentation

Add #278 to RTD

Pull Request Test Coverage Report for Build 213853558

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at ?%

Totals

Change from base Build 213828280:
0%

Covered Lines:

Relevant Lines:
0

💛  - Coveralls


Rethink the owner->contact link

Do we need a searchable / filterable label in the main contact table?

Let's hope not.


Missing image in Cameras, Mesh Collisions and Gravity Tutorial (9)

The image here seems to be missing. I can see a link in the markdown, but it gives a 404.

Do you mind to submit a PR to remove the images?


Unit Tests: Improve Unit Test Coverage

The unit test project AllReady.UnitTest only has a 3 tests and only tests the ActivityApiController. Write more tests and improve the robustness of existing tests.

I'm doing this

I'm also working on this

We know we don't have the test coverage that we want.  We'd welcome anyone adding more unit test coverage.

Looking to pitch in, I'll start with ResourceAPIController to get my feet wet.

This is probably silly as far as missing a setting or something, but when I run "Analyze Code Coverage -> All tests" in the web only solution (I'm trying to easily identity areas that still need test coverage)  it only shows that 33.33% of code is not covered.  The strange this is, that 33% is made up of only a total of 12 blocks (4 missing).  The only assembly showing up in the first tier of the drop down is AllReady.Models.dll.  Any ideas why my code coverage is clearly not checking out the code coverage of the entire solution?

Hello. I've been discussing with @BillWagner and @RichardCampbell  a proposal to to host a "hackathon" day at my company (codeweavers.net) to work on AllReady.
We're still in the planning stages but looking at the kind of areas we could work on for the day this seems like a gentle introduction for our developers (contributing to open source is new to most of them) and something which would add value.
Once we settle on a date, we'd be happy to take any gaps in the testing and look to plug those. Failing that, if there are any obvious areas/features for us to to look at (which would be of most benefit to the project) then please do let me know.
Thank you

@jonhilt I think that is an awesome idea. Let us know when you have the date finalized.

I have a passion for unit tests ... so this may be a good place for me to jump in.

@DocHammoc That would be perfect. Note that some improvement has happened here since this issue has been created, but we're still not where we want to be.

Some people are having trouble running code coverage, so here is a spreadsheet with current numbers.
Coverage.xlsx

@mheggeseth and @MKSessions, I'd like to contribute to allReady. Looks like you just had a hackathon this past weekend and there have been unit tests added to the controllers. These controllers still have no unit tests:
CampaignApiController
ClosestLocationsController
HomeController
ManageController
MeApiController
TaskApiController
I'd like to start with writing unit tests for these unless there are any particular controllers out of the these that you do NOT want unit tests written for?
Thanks,
Mike

@mgmccarthy Go right ahead. Start with the ones that that seem to be most used in the app (I'm not sure all of these are). For those you cover, create new, more specific issues that reference this one and then submit pull requests that fix the new issues.

@mgmccarthy I agree with @mheggeseth Dive in! Any additions here will be useful.

Any chance we want to use a library like Shouldly to make our Unit Tests a bit easier to write (and output easier to read)? I've used both FluentAssertions and Shouldly and would strongly recommend the use of Shouldly. It's simple to use, and it shows really easy to understand failure messages. See more in the docs.
Also, I am in the process of refactoring controllers to use MediatR #567. So any unit tests that get written right now will need to be refactored too. Could I suggest that instead of just writing more tests, that you first refactor the controller method to the MediatR pattern, then write unit tests for the resulting Handler?
Here's a great post that shows what I think we're striving for with MediatR: https://lostechies.com/jimmybogard/2015/05/05/cqrs-with-mediatr-and-automapper/

@mikesigs, funny you should mention Shoudly. I just stumbled on that repository a week or two ago, and had a quick look. From an initial glance, it looked very fluent, and I liked the API. I have no experience with the framework yet.
That being said, since I'm an nUnit guy, I'm kind of a fish out of water with the xUnit tests and it's slowing me down right now. If I'm moving slower than usual, and Shoudly offers a superior API to xUnit, then I might as well be slow and learn Shoudly at the same time.
I guess the one thing I'm not clear on, is Shoudly just a wrapper around an existing test framework or is it testing framework unto itself?
For MediatR changes, I use NServiceBus at my current job, so the approach of sending commands to "do things" or publishing "events" for things that have been done is very familiar to me. I find it a little "weird" that you send a request to execute a query, but I'm sure I'll catch on.
Will all controllers be refactored to MeidatR? If so, maybe some sample code from a controller and unit test for that controller that you're working on could give me an idea of what you're thinking so we're on the same page.

Shouldly is an "Assertion Framework". It doesn't replace xUnit, it just alleviates you from having to use Assert.Foo calls. For example...
Instead of writing:
Assert.AreEqual(foo, 2);
You write:
foo.ShouldBe(2)
It makes for much more readable code, and must better failure messages.
The MediatR stuff is still a work in progress for me. I started changing a couple methods on the ActivityController at the Hackathon on Saturday. See this commit for an example of what I've done so far.
One thing I don't like is that I'm explicitly checking for null and returning HttpNotFound(). An improvement to this (and something I think I'd like to attempt) is using ExceptionFilters. So in the RequestHandler we could throw a new EntityNotFoundException() or something and use an MVC ExceptionFilter to translate those kinds of exceptions into 404s.

I found this page to be extremely handy when starting out with xUnit.
https://xunit.github.io/docs/comparisons.html

@mikesigs, Shouldly looks good. Do we need approval from the overall project team to use it? Would using Shouldly act as a barrier to bringing other open source contributors aboard? Would sticking with xUnit assertions made it easier to get devs up and running quicker? That's a question I'm not qualified to answer.
As far as MediatR controller refactoring, i just looked at your commit. I guess one question I have is why do you have to check for null? The code was not checking for null before when the query calls against allReadyDataAccess lived in the controller.
in ActivityDetailQueryHandler, it looks like the model is being set to null:
ActivityDetailModel result = null;
instead of a new model instance:
ActivityDetailModel result = new ActivityDetailModel();
I don't understand why the model is set to null instead of instantiating a model class and then populating its properties from queries in the handler. This would eliminate null checking altogether.
In Jimmy's handler sample, he's new'ing up the model class in his handler, setting some properties, then setting the rest of the properties using data from his queries:
public Result Handle(Query message)
{
    var model = new Result
    {
        CurrentSort = message.SortOrder,
        NameSortParm = String.IsNullOrEmpty(message.SortOrder) ? "name_desc" : "",
        DateSortParm = message.SortOrder == "Date" ? "date_desc" : "Date",
    };
...

I'm probably missing something here b/c I'm new to the codebase and new to MediatR, or a combination of both.
Either way, if Shouldly and MediatR is something the allReady project has decided on, then I'll just get started on the refactoring starting with HomeController.

You're absolutely correct about there not being a check for null beforehand. I could probably remove it altogether if it's truly not needed. But in other cases these kinds of checks will be needed, and there's got to be a way of handling it that doesn't require duplicating that checking code in all/any controller methods. Read the comments on the post I mentioned earlier. There's some useful stuff in there too.
I'm going to re-visit my approach a bit with MediatR too. I didn't read the above article before the Hackathon. And I think it could use a bit of changing WRT how I'm passing/creating the Command objects. Jimmy just uses the ViewModel/Command passed to the Controller, whereas in many places I am creating a new Command object inside the controller and sticking on the UserId, etc. I don't really like that.
As for whether or not to use Shouldly... I think it may simplify things for new contributors. But then, I've been using some manner of "Should" framework for testing in all of my projects for years. I've never been much fond of using Assert.Bla(). As for whether we need explicit permission before introducing a new framework.... that I don't know.

@tonysurma How do you go about deciding when to add a new framework to this project? How do you feel about using Shouldly to assist in writing unit tests?

@mikesigs, either way, I'm on board, Shouldly or no Shouldly. Thanks for reaching out someone who can answer this question for us.
Looking at HomeController, the one place I could move to MediatR is the Index action method. However, Id' like to submit my first PR with the tests I've written, and once that is checked in, I'll refactor HomeController to MediatR. The good part is I'll have all the unit tests already written and passing, so that can help me refactor to sending a request for the data.
Thanks

In short, we balance the complexity, dependence & another thing "cost" of adding a library or framework against the ease of use, code reduction, etc. "benefits" from using it.  From my quick review of this it appears this isn't a different or conflicting framework for testing and is instead one for ease of assertion work so it is 'complementary' to xUnit and also means that folks can use Shouldly or not in their unit tests.
Therefore given those points using it should be a good addition and thanks for the contribution and discussion and checking in to make sure the addition fits with the project plan @mgmccarthy and @mikesigs

@mikesigs, let me know when you install Shouldly via NuGet. I'd like to try to work with the framework. For now, I'm working on refactoring to MediatR on the HomeController. @tonysurma @mikesigs, do either of you know who installed MediatR for use in the solution? If so, was there any type of convention they wanted us to follow for naming our our Query and Model classes we use with our Handlers? Thanks

For Mediator I would talk to @misterjames I believe

@mgmccarthy When I do install it, it will be in my own fork for now. I also don't anticipate having time to push anything here until the weekend. Please feel free to install it if you want. I'll just rebase anyways and handle any conflicts.

@tonysurma @migsigs @MisterJames @SeanFeldman.
I installed the xUnit runner extension for ReSharper 10 Ultimate the other day (b/c I'm tired of using MsTest to run the xUnit tests). I'm using Visual Studio 2015:

yet when running the unit tests in ReSharper I get the following error pop up twice (I have to hit the "Ok" button between each error dialogue):

I've poked around a bit online, but there is not much to go on. Was wondering if anyone else was using this same setup (ReSharper 10 Ultimate and xUnit extension) and was running into a similar problem?
ReShaper works perfectly for running NUnit tests.

@mgmccarthy I had the same problem.  I think it has to do with the Resharper plugin for xunit not being compatible with asp.net core.

@mgmccarthy yep, same thing here. NUnit works, xUnit doesn't.
@mmoore99 is spot on.
Two things:
Generating assemblies
By default DNX/Core doesn't emit assemblies.

Produce outputs on build needs to be enabled (I think)
Output path
When it's failing, it's looking for the unit tests assembly under
\artifacts\bin\AllReady.UnitTest\AllReady.UniteTest.dll
when DNX produces this assembly under
\artifacts\bin\AllReady.UnitTest\Debug\dnx451\AllReady.UnitTest.dll
Guessing that it's the xUnit adapter that doesn't know how to resolve DNX assemblies.

From R# xUnit author:

DNX isn't supported right now

Will need to wait for this  to be resolved :sunglasses:

Thanks for digging into this a little deeper @mmoore99  add @SeanFeldman.
@SeanFeldman, sounds like you tried checking "produce outputs on build" in the project properties of AllReady.UnitTest yet it still didn't work based on the xUnit Repo-Issue #38? If that's so, I'll keep begrudgingly using MSTest for now.

@mgmccarthy correct. It needs to be done by xUnit adaptor. Until then, the
amazing mstest ui will do.

@tonysurma @mikesigs @MisterJames @SeanFeldman @mmoore99
for those of you using ReSharper Ultimate 10.1, there is an EAP of ReSharper 2016.1 (that's 10.1, they changed their versioning) that supports xUnit: http://blog.jetbrains.com/dotnet/2016/03/17/resharper-ultimate-2016-1-formerly-10-1-eap-6/. I'm not too sure how "safe" if it to install the EAP... I'll probably hold off until the official, finalized release, but just wanted others to know.

@mgmccarthy the Jetbrains  blog states:

One thing to note is that this build does not yet support running tests for DNX projects, this will hopefully be included in a future build.

Does that mean it would not work with allReady?

@mmoore99, yeah, your' right, the upgrade will not work for allReady. I'm deleting my original comment. Just waiting for someone to get xUnit running w/ReSharper for DNX projects.... anyone. MS Test is driving me crazy.

As an alternative to running the tests in Visual Studio you could always run them from the command line using dnx test.
You can run your tests continuously this way using nodemon. First, install nodemon npm install -g nodemon then run this command (from the Web-App folder)
nodemon -e "cs,json" --exec "dnx -p ./AllReady.UnitTest test"

@mikesigs thanks for the tip. Devs like me are spoiled by ReSharper... I'll give nodemon a shot

I am working on unit tests for TaskStatusChangeHandlerAsync via #787

@mgmccarthy should this still be open and/or thoughts on a way to document what is left open?  thanks

@tonysurma we should close this "umbrella" issue and move to an issue per test class approach so we can track this.


LSP Code Action Source

Hello,
Just wondering if there is a way to include code action source names with vim.lsp.buf.code_action(), similar to Telescope's builtin lsp_code_actions.
vim-ui-select (with dressing.nvim)

Telescope

At the moment, no. The display of lines is specified by the opts.format_item function that is passed in by the caller of vim.ui.select. In this case, it's specified here.
There are some different directions I could go from here. It would be fairly straightforward to add a special_format option to the config that lets you pass in a function that overrides format_item for a specific select kind (e.g. opts.kind == 'codeaction'). That would be enough to display the client name, but it wouldn't get you the nice highlighting or column alignment.
I could go further and build out the API to let you specify highlighting and column alignment as well, but then I have to make sure that it works (or at least behaves) across all the potential backends. It adds quite a bit of code complexity and diverges from the core API, so I'm hesitant to do it without good motivation.
I think the better way to go about it would be to make the case in Neovim core to officially add columns/highlighting to the vim.ui.select API. If something like that were standardized, I'd be way happier about implementing it.
Thoughts?

Hi thanks for your detailed response. I reckon before Neovim updates their core API, the best approach right now would be to override the format item.

Hi thanks for your detailed response. I reckon before Neovim updates their core API, the best approach right now would be to override the format item.

Added a config option and also some example code in the help docs that should do what you want

Looks good thank you! Love how you can also filter by language server now :))

Hi @stevearc, just wondering, but is it possible to link the [LANGUAGE_SERVER] to the Comment highlight group? This would be amazing if possible :D

Yeah fair enough thanks for the clarification. Sometimes it's quite annoying that Telescope's code action doesn't do everything vim.lsp.buf.code_action would do (esp for nvim-jdtls), so I have to switch between both conditionally based on filetype. But yeah, perhaps I'll have a look into creating my own Telescope picker. Thanks again!

Hi, just wondering if this can now be achieved with e607dd99aeb5ce21e9a3d8f4c028650db12bd3af

That commit was more intended for a different use case altogether, but it does technically unlock more UI customization abilities for end users as well (via the get_config override).
In this case though, I think I'm going to go back on my previous decision. I was stuck on trying to figure out how to keep the UI consistent across all of the backends, but (especially with that recent change) I don't think that's a hard requirement anymore. I'm more on board with small amounts of customization in certain circumstances for common or core neovim features.
So I've gone ahead and added a custom formatter when kind = 'codeaction'. Let me know if it works for you!

Thanks I love the change! Is it possible to search through the language server names (comment) as well?

Done!

Thank you so much for the quick changes. Love your work as always!


Black MAPDL window opens when compiling a program with PyMAPDL

🤓 Before submitting the issue

[X] I have visited the Troubleshooting section.
[X] I have searched among the existing issues.
[X] I am using a Python virtual environment.
[X] I am using the latest version of PyMAPDL and its dependencies (fully updated virtual environment). You can update them using pip install --upgrade --upgrade-strategy eager ansys-mapdl-core in your activated virtual environment.

🔍 Description of the bug
When using pymapdl and starting a MAPDL instance using the function launch_mapdl, MAPDL runs in the background and does not display any window which is the expected behavior. However, when packaging a script that uses this function, a black MAPDL empty console will appear and remain on screen as long as the instance is running.
This is a problem for any program with a GUI using pymapdl that needs to be compiled. I am not able to test on Linux to see if the problem also exists but it could be simply solved on Windows by adding the following argument creationflags=0x08000000 in the subprocess command that calls the MAPDL executable file.
🕵 Steps To Reproduce
# Package the following code with PyInstaller using the noconsole argument.
from time import sleep
from ansys.mapdl.core import launch_mapdl
mapdl = launch_mapdl()
print(mapdl)
sleep(10)
mapdl.exit()

💻 Which Operating System are you using?
Windows
🐍 Which Python version are you using?
3.11
💾 Which MAPDL version are you using?
23.1
📝 PyMAPDL Report
Show the Report!
PyMAPDL Software and Environment Report

Packages Requirements
*********************

Core packages
-------------
ansys.mapdl.core    : 0.68.0
numpy               : 1.26.4
platformdirs        : 4.2.0
scipy               : 1.12.0
grpc                : Package not found
ansys.api.mapdl.v0  : Package not found
ansys.mapdl.reader  : 0.53.0
google.protobuf     : Package not found

Optional packages
-----------------
matplotlib          : 3.8.3
pyvista             : 0.43.3
pyiges              : 0.3.1
tqdm                : 4.66.2

Ansys Installation
******************
Version   Location
------------------
222       C:\UserProg\ANSYS Inc\v222
231       C:\UserProg\ANSYS Inc\v231

Ansys Environment Variables
***************************
CADOE_LIBDIR231                C:\UserProg\ANSYS Inc\v231\CommonFiles\Language\en-us
AWP_ROOT222                    C:\UserProg\ANSYS Inc\v222
ANSYS231_DIR                   C:\UserProg\ANSYS Inc\v231\ANSYS
AWP_LOCALE222                  en-us
ANSYS222_DIR                   C:\UserProg\ANSYS Inc\v222\ANSYS
AWP_ROOT231                    C:\UserProg\ANSYS Inc\v231
CADOE_LIBDIR222                C:\UserProg\ANSYS Inc\v222\CommonFiles\Language\en-us
AWP_LOCALE231                  en-us

📝 Installed packages
Show the installed packages!
alabaster==0.7.16
altgraph==0.17.4
ansys-api-mapdl==0.5.1
ansys-api-platform-instancemanagement==1.0.0
ansys-mapdl-core==0.68.0
ansys-mapdl-reader==0.53.0
ansys-math-core==0.1.3
ansys-platform-instancemanagement==1.1.2
ansys-tools-path==0.4.1
appdirs==1.4.4
Babel==2.14.0
certifi==2024.2.2
chardet==5.2.0
charset-normalizer==3.3.2
click==8.1.7
colorama==0.4.6
commonmark==0.9.1
contourpy==1.2.0
coverage==7.4.4
cx-Logging==3.1.0
cx_Freeze==6.15.15
cycler==0.12.1
docutils==0.20.1
et-xmlfile==1.1.0
fonttools==4.49.0
geomdl==5.3.1
grpcio==1.62.0
idna==3.6
imagesize==1.4.1
importlib-metadata==7.0.1
iniconfig==2.0.0
Jinja2==3.1.3
kiwisolver==1.4.5
lief==0.14.0
MarkupSafe==2.1.5
matplotlib==3.8.3
numpy==1.26.4
openpyxl==3.1.2
packaging==23.2
pdfkit==1.0.0
pefile==2023.2.7
pillow==10.2.0
platformdirs==4.2.0
pluggy==1.4.0
pooch==1.8.1
protobuf==3.20.3
psutil==5.9.8
pyansys-tools-versioning==0.5.0
Pygments==2.17.2
pyiges==0.3.1
pyinstaller==6.4.0
pyinstaller-hooks-contrib==2024.1
pyparsing==3.1.1
pytest==8.1.1
pytest-cov==5.0.0
pytest-rerunfailures==14.0
python-dateutil==2.8.2
pyvista==0.43.3
pywin32-ctypes==0.2.2
PyYAML==6.0.1
recommonmark==0.7.1
reportlab==4.1.0
requests==2.31.0
rinoh-typeface-dejavuserif==0.1.3
rinoh-typeface-texgyrecursor==0.1.1
rinoh-typeface-texgyreheros==0.1.1
rinoh-typeface-texgyrepagella==0.1.1
rinohtype==0.5.4
rst2pdf==0.101
scipy==1.12.0
scooby==0.9.2
six==1.16.0
smartypants==2.0.1
snowballstemmer==2.2.0
Sphinx==7.2.6
sphinx-markdown-builder==0.6.6
sphinx-rtd-theme==2.0.0
sphinxcontrib-applehelp==1.0.8
sphinxcontrib-devhelp==1.0.6
sphinxcontrib-htmlhelp==2.0.5
sphinxcontrib-jquery==4.1
sphinxcontrib-jsmath==1.0.1
sphinxcontrib-qthelp==1.0.7
sphinxcontrib-serializinghtml==1.1.10
tabulate==0.9.0
tqdm==4.66.2
urllib3==2.2.1
vtk==9.3.0
zipp==3.17.0

📝 Logger output file
Show the logger output file.

# PASTE HERE THE CONTENT OF THE LOGGER OUTPUT FILE.

Hi @PaulCreusy
I haven't work much on packing PyMAPDL in an executable using pyinstaller. Can you share the code you use to create the compiled executable (aka the pyinstaller commands or files)??

Hi, thank you for your quick answer, here is a script that will allow you to compile the example included in the issue. The example should be placed in a file called main.py for this script to work.
Also because some files must be included manually after the packaging, please make sure that the versions of the pyansys_tools_versioning and ansys_tools_path are the ones specified in my pip freeze or in the paths below. Otherwise, please change them to match yours.
import os
from distutils.dir_util import copy_tree
from site import getsitepackages

# Find the location of Python's site packages directory
print(getsitepackages())
site_packages_path = getsitepackages()[-1]

PACKAGE_NAME = "MyPackage"

# Package with PyInstaller
os.system(f"pyinstaller --noconsole -n {PACKAGE_NAME} main.py")

# Include additional files to avoid crash on start
copy_tree(site_packages_path + "/ansys/api", f"dist/{PACKAGE_NAME}/_internal/ansys/api")
copy_tree(site_packages_path + "/pyansys_tools_versioning-0.5.0.dist-info",
          f"dist/{PACKAGE_NAME}/_internal/pyansys_tools_versioning-0.5.0.dist-info")
copy_tree(site_packages_path + "/ansys_tools_path-0.4.1.dist-info",
          f"dist/{PACKAGE_NAME}/_internal/ansys_tools_path-0.4.1.dist-info")

Probably you can replace the versions in the hardcoded paths using:
try:
    import importlib.metadata as importlib_metadata
except ModuleNotFoundError:  # pragma: no cover
    import importlib_metadata
__version__ = importlib_metadata.version("ansys-mapdl-core")

Or maybe just importing the library and read the version:

https://github.com/ansys/pyansys-tools-versioning/blob/1752af086157a3244b51c15f5d16cb70bf975c26/src/ansys/tools/versioning/__init__.py#L32C1-L32C12
https://github.com/ansys/ansys-tools-path/blob/ac1ddc391ec55e1aa56747cefdb3f45bb264ff70/src/ansys/tools/path/__init__.py#L9

I am currently quite busy with other projects, I won't have time to check this until later next week. I hope this is OK. Please keep pinging here if I dont contact you back by then.

Hello @germa89, do you have news about this issue ?

Hi @PaulCreusy
I am re-reading your issue:

When using pymapdl and starting a MAPDL instance using the function launch_mapdl, MAPDL runs in the background and does not display any window which is the expected behavior.

The default Windows OS behaviour is to open another window which can be a black MAPDL window, but it might be minimized by default. At least, that is what I see when I run it in my Windows 11 machine. There is always another window whenever MAPDL is running.
If you click on that minimized window, the window will maxime showing a black window which is probably what you are seeing also when you compile the image.
Hence, I think when you compile the image, you cannot avoid seeing that black window, because you see it also when you are working normally (using python scripts).
@clatapie can you confirm my statements? Is there always a black windows running on Windows OS?

Reference: https://stackoverflow.com/questions/2935704/running-shell-commands-without-a-shell-window

Oh.. OK you want the MAPDL window to be minimized. I see.
Well, I guess we could add subprocess.CREATE_NO_WINDOW to the subprocess call. But I will need to check side effects for this. Since I'm quite busy with other projects, I'm keeping this issue open to address this.
However, feel free to propose that change in a PR.


Update functions-create-first-azure-function-azure-cli.md

@Juliako : Thanks for your contribution! The author, @ggailey777, has been notified to review your proposed change.


Draft 0.8.0 for Windows

Hi,
Any plans to updated version of draft v.0.8.0 for Windows?
Thanks

Hey there!
Due to some current issues with running Draft on Windows (see #406), we have dropped official Windows support in v0.8.0. We are still continuing to build and release Windows binaries, but given the current state of the project, we intend to target MacOS/Linux support out of the gate, with Windows support as an added bonus if anyone wants to tackle the problems associated with running Draft in that OS.
Canary builds for Windows can be found here: https://azuredraft.blob.core.windows.net/draft/draft-canary-windows-amd64.tar.gz
I'm going to close this and ask anyone to direct discussion towards #406. That way we can have one ticket to discuss the blockers for adding Windows support for Draft. Thanks! 😄

any update on Draft for windows?

you can follow #406 for status updates. :)


Gh-2924 Fix send null payload with KafkaTemplate#send(Message), and …

…JsonMessageConverter
fixes: https://github.com/spring-projects/spring-kafka/issues/2924

@pswrdf Thank you for signing the Contributor License Agreement!

@pswrdf Thanks for the PR! Can you add a unit test to verify the changes? Or point to an existing test where this code is exercised.

I think it's done.
Would I squash commits? It needs to change email also.

... and cherry-picked to 3.0.x


Switch to pnpm in pde2e scripts

see: https://github.com/containers/podman-desktop/issues/8566

fixed by: https://github.com/odockal/pde2e-builder/commit/f816308494b4a29034db48d233b58ec554044563 and https://github.com/odockal/pde2e-runner/commit/6425c2254dc7675d087023e39c938738218b6558


Question about ModuleServiceRepository

I want to ask why the value of the first two maps is List? And the kv of the last providers is one-to-one, should the kv of the first two maps also be one-to-one?(想问下前两个map的value为什么是List？而最后的providers的kv是一对一的。是不是前两个map的kv也应该是一对一的？)

service => In a multi-classloader scenario, there may be two interfaces with different service descriptors.
consumer => Dubbo supports multiple consumers, that is, multiple linseners can be created on the same service.
provider => Dubbo only supports exporting one service in the same context. Otherwise, Dubbo will not be able to distinguish which service the request belongs to.

Thank you, looking at the todo here, there is no classloader dimension added to the access of services. Does it need to be improved?

Thank you, looking at the todo here, there is no classloader dimension added to the access of services. Does it need to be improved?

yep, if possible


Revert "Patch prow-docs to test prow-build-prow-images"

Reverts aws-controllers-k8s/test-infra#472

/lgtm


Responsivness

Description of changes
Updated a few lines in the Navbar, index.tsx, join.tsx, course/create.tsx and course/id/index.tsx, to add more responsivness. In the home screen, the progress bars are being resized if the screen width hits certain breakpoints.
Navbar course items might need a rework, meaning if the screen width falls under a certain breakpoint, secondary node might have to be displayed. Propably an abbreviation of the course name, but has to be discussed.
Breakpoints are moistly the predefined ones from TailwindCSS and MUI.
How has this been tested?
Please describe the test strategy you followed.

[ ] automated unit test
[ ] automated integration test
[ ] automated acceptance test
[x] manual, exploratory test

In case of manual test, please document the test well including a set of user instructions and prerequisites. Each including an action, it's result, and where appropriate a screenshot.
Checklist before requesting a review

[x] My code follows the coding guidelines of this project
[x] I have performed a self-review of my code
[ ] I have commented my code, particularly in hard-to-understand areas
[x] My code fulfilles all acceptance criteria
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[ ] I have made corresponding changes to the documentation
[ ] I have added explanation of architectural decision and rationales to wiki/adr
[x] I have updated the changes in the ticket description

Checklist for reviewer

[ ] The code works and does not throw errors
[ ] The code is easy to understand and there are no confusing parts
[ ] The code follows the coding guidelines of this project
[ ] The code change accomplishes what it is supposed to do
[ ] I cannot think of any use case in which the code does not behave as intended
[ ] The added and existing tests reasonably cover the code change
[ ] I cannot think of any test cases, input or edge cases that should be tested in addition
[ ] Description of the change is included in the documentation

The larger navbar sizes are ok, but I would make it a modal drawer when too small. The rest looks  good. For larger screens it could be nice to limit the growth of some elements (like the course links on the home page).