Should we support native scrolling?

As is explained in issue #14, smooth-scrollbar breaks native scrolling experience on some devices (e.g. iOS/Android with hardware accelerated scrolling). So I am thinking about the possibility of integrating with native scrollbar.
The following is a table of API compatibility with native scrollbar:

API name
Compatibility
Explanation

instance#targets
✔ (partial)
We may no longer need scroll-content wrapper and scrollbar-track.

instance#offset
✔
As an accessor property that returns el.scrollTop and el.scrollLeft.

instance#limit
✔
As(maybe) an accessor property.

instance#scrollTop
✔

instance#scrollLeft
✔

instance#update()
❌
Unnecessary.

instance#unregisterEvents()
❌
Unnecessary.

instance#registerEvents()
❌
Unnecessary.

instance#clearMovement()
❌
Unnecessary.

instance#stop()
❌
Unnecessary.

instance#destroy()
❌
Unnecessary.

instance#showTrack()
❌
Unnecessary and impossible.

instance#hideTrack()
❌
Unnecessary and impossible.

instance#setPosition()
✔(partial)
withoutCallbacks parameter may be broken.

instance#getSize()
✔

instance#scrollTo()
✔

instance#scrollIntoView()
✔

instance#isVisible()
✔

instance#addListener()
✔

instance#removeListener()
✔

instance#infiniteScroll()
✔

Well...the compatibility looks nice. However it may be a tough work to make the integration, and file size will increase by at lease 30% I think.
In my view we'd better not support native momentum scrolling, it's complex and useless. Users who want to perform native scrolling, just throw this plugin away and listen to original scroll event. You can not alway cover all situations.
What's your option @bfred-it?

The problem with your last paragraph is who you mean by users. If you make it optional, the developers will be the users and most devs won't really care about degraded experience unless they themselves use these devices. The actual users of the scrolling (website visitors) will be the ones with a poor experience... by default.
scrollbar-track can and probably should stay, to keep the style consistent, so the track-related methods could also keep working.

@bfred-it so I think you may not be a potential user/developer of this script.
This plugin (and many others) is designed for those who want to customize scrollbars on all kinds of browsers, css is too weak to do this so we need a javascript simulation.
On desktop devices, scrolling is based on wheel delta from your input devices (mouse, trackpad etc.), if friction is set to 100%, easing effect will be disabled and the behavior is absolutely the native one.

Again, it doesn't matter to me as a developer but as the user. As a developer I already know I can customize scrollbars with CSS in the majority of all browsers and other JS solutions that don't break the native scroll by default.
The problem is with the smoothing part. damping:1 feels good, actually. Would it make sense to set it automatically once native smooth scrolling is (somehow) detected?

@bfred-it I think it's impossible to detect whether it's smooth scrolling. The only thing I can do is to use damping < 1 to apply our smooth scrolling on most devices, or damping = 1 to switch to native scrolling on particular devices (e.g. OSX with trackpad), it's a trade-off.
I am not able to tell which kind of input device it is, and I have no idea to set damping value automatically according to current environment. So I made it a configurable option and leave it up to developers.
Users in your words suffer from poor scrolling because I (or developers) want them to behave the same way unless we could distinguish between the input hardwares, it's rude, it's communist, but it's a trade-off.

You're free to be a communist but know that you're contributing to making the web worse when you don't have to.
http://codepen.io/bfred-it/full/pboNvw/
This is my graph for a big flick and a medium flick:

I'm not entirely sure of how it appears on non-smooth devices. While you might not be able to tell whether the device has smooth scrolling in the first scroll event, you can easily tell after they let go and the momentum keeps it going down smoothly.

you can easily tell after they let go...

@bfred-it I think it's hard to detect the release action. Maybe I can record an amount of momentum and compare it with the mathematical model of smooth scrolling - wow am I building an A.I.?
BTW my movement graph is similar to yours:

No, use the codepen example, I'm not trying to show how comparable they are but if we can detect the native smooth scrolling

@bfred-it yeah I know what you're arguing about, but:

it's hard to detect the release action

So I can't:

easily tell after they let go and the momentum keeps it going down smoothly

The plot looks substantially different; in your stepped plot there's no slope, the delta switches between nearly identical large steps, rather than decreasingly small steps. I think it would be as easy as:
d = lastFiveDeltas;
d[0] - d[1] <
d[1] - d[2] <
d[2] - d[3] <
d[3] - d[4]

In short, if the delta's delta is less than the previous couple, then it's reasonably a momentum scroll.
This check could run at the beginning, maybe for the first seconds or until it matches.

@bfred-it a little attempt on your theory: http://codepen.io/idiotWu/full/YWzpQz/
As you can see, the result is unstable.

It doesn't need to be stable, once it detects it once or twice it should stop and set damping:1:

How does it look with a stepped scrollwheel?

Either way I'd at least start disabling it almost entirely on mobile since:

the scroll is always smooth
mobile devices essentially don't have a scrollbar
performance is guaranteed to be worsened and lead to crashes when you apply translate3d to long pages, especially when the devices is not the latest.

@bfred-it the logs of stepped mousewheel:
false, 288,300,308,304,300, delta's delta: 12,8,-4,-4
false, 300,308,304,300,240, delta's delta: 8,-4,-4,-60
false, 240,200,156,92,56, delta's delta: -40,-44,-64,-36
false, 200,156,92,56,20, delta's delta: -44,-64,-36,-36
true, 156,92,56,20,4, delta's delta: -64,-36,-36,-16

Look at true on line 5.

Right, then look at the delta's delta, it's one more check: delta < 3

@bfred-it yes I agree with you on the point of mobile devices, that's the reason why I opened this issue :)


Inline error/violation suppression doesn't work with existing comments

Hi,
at work, our client requires us to use their SonarQube. At the same time, I'd like to use Ruff as well.
These two clash when you're trying to add inline suppression comments for both, at least this way:
except:  # NOSONAR python:S5754 noqa: E722

In this particular case, switching them works:
except:  # noqa: E722 NOSONAR python:S5754

However, this might not work with other inline comment based metadata.
I'm not sure what a good solution for this might look like, but I have two ideas.
You could look for the noqa pattern anywhere in a comment.
And/or, you could add a feature like coverage, that lets you exclude lines that match a provided pattern. This way, I could provide a suppression pattern NOSONAR to Ruff and both tools would be happy.
PS: I know I should open the same issue with SonarQube 🙈

Would you mind trying this? except:  # NOSONAR python:S5754  # noqa: E722
We allow the noqa anywhere, but we require that it's prefixed by its own #.

I'm gonna close since we do ask for the leading # to clearly disambiguate the suppression. Hopefully that's ok for your use-case.


Update Phpstan to the latest version

Update PHPStan to the latest version, which fixes an issue with anonymous classes and constructor parameters.

Coverage increased (+0.004%) to 25.502% when pulling 502a91130733c4a5b072c08c5fae586301bce42b on pierredup:phpstan into e0d320aaba6d70ff9fcc1922f247a6377f029195 on CSBill:master.

Coverage increased (+0.004%) to 25.502% when pulling 40b9ef7103799bd1e58f95413953d2372b7435aa on pierredup:phpstan into e0d320aaba6d70ff9fcc1922f247a6377f029195 on CSBill:master.


Fix sqlite db path in parameters.yml.dist

This should have been done in #1032. ~Adding the path to .gitignore was done on symfony-demo, I think we can do it here too.~

Merging into 3.2 instead.

Rebased on 3.2.


How to handle duplicate uploads of a same file in preview

Currently, if a user attempts to upload a same file multiple times, each upload is listed as a separate entry in preview. Is it possible to customize the preview so that only the last upload is displayed?

Hello @lifan0127,
I experienced the same problem and I found a way to do this.
3 elements were needed:

The component's state to manage the list of uploads,
The Dropzone's validate prop, to check if the current uploading file is already in the list of uploads,
A custom LayoutComponent to remove duplicates files from the preview, because it seems that validate cannot handle this properly.

const CustomLayout = ({input, previews, submitButton, dropzoneProps}) => {
  // Remove previews which do not pass the validation
  const previewsToDisplay = filter(previews, (preview) => {
    return preview.props.meta.status !== 'error_validation';
  });
  return (
    <div {...dropzoneProps}>
      {previewsToDisplay}
      {input}
      {submitButton}
    </div>
  );
};

class App extends Component {
  constructor(props, context) {
    super(props, context);
  }

  state = {files: []};

  render() {
    const getUploadParams = () => {
      return {url: '/api/uploads', method: 'POST'};
    };
    const handleChangeStatus = ({meta}, status) => {
      let updatedFiles = [];
      if (status === 'done' || status === 'remove') {
        // Add meta to files
        if (status === 'done') {
          updatedFiles = [...this.state.files, meta];
        }
        // Remove meta from files
        else {
          updatedFiles = filter(this.state.files, (file) => {
            return file.name !== meta.name
                || file.size !== meta.size
                || file.type !== meta.type;
          });
        }
        this.setState({files: updatedFiles});
      }
    };
    const handleSubmit = (files, allFiles) => {
      allFiles.forEach(f => f.remove());
      this.setState({files: []});
    };
    const handleValidation = ({meta}) => {
      return some(this.state.files, (file) => {
        return file.name === meta.name
            && file.size === meta.size
            && file.type === meta.type;
      });
    };

    return (
        <div style={{textAlign: 'center'}}>
          <Dropzone
              getUploadParams={getUploadParams}
              onChangeStatus={handleChangeStatus}
              onSubmit={handleSubmit}
              validate={handleValidation}
              LayoutComponent={CustomLayout}/>
        </div>
    );
  }
}

Could you do it?

const handleValidation = ({ meta }) => {
            const { filesArray } = this.state;
            return filesArray.find(e => e.name === meta.name && e.size === meta.size && e.type === meta.type);
}

This worked for me

My problem is, when the user chooses a file, its uploaded directly to my server.But if the user remove a file from the drop zone how can i delete it from my server?

I've also discovered this same issue. The issue arises with drag 'n drop into the component. The file comes in as a DataTransferItem which has no name. The only props are type and kind (file) which aren't enough to determine if it exists already.

What worked for me, is to use the filter() to check each submission in useDropzone:
`const { getRootProps, getInputProps } = useDropzone({
accept: 'image/*',
onDrop: (acceptedFile) => {
const newFiles = acceptedFile.map(file => {
return Object.assign(file, {
preview: URL.createObjectURL(file)
})
})
setFieldValue('files', [
...files,
...newFiles
])
  files.map(file => {
    newFiles.forEach(newFile => {
      if (newFile.name == file.name) {
        setToast({
          open: true,
          severity: 'error',
          text: 'Não é possível adicionar imagens duplicadas!'
        })

        const filteredArray = files.filter((item, index) => files.indexOf(item) == index)
        setFieldValue('files', filteredArray)
      }
    })
  })
}

})`


Index was outside the bounds of the array

Sometimes bot is unavailable and very slow to answer. In log i see
Index was outside the bounds of the array

Can you add a code snippet? Are you in C# or Node.js ? And, which channel? Or are you seeing this in the emulator?

Problem in Telegram.
Skype work perfect, but Telegram most time is very slow and in bot logs i find this error.
I move from Async to Sync.
Bot send is HeroCard
HeroCard plCard = new HeroCard
{
Text = post.Text,
Buttons = new List
{
new CardAction
{
Value = command,
Type = "postBack",
Title = "Next"
},
new CardAction
{
Value = "GET#" + post.SysId,
Type = "postBack",
Title = "Open"
},
new CardAction
{
Value = ".menu",
Type = "postBack",
Title = "Menu"
}
},
Images = !string.IsNullOrWhiteSpace(post.ImageUrl) ? new List { new CardImage(url: post.ImageUrl) } : new List()
};`

@ZOXEXIVO We're logging this error on behalf of your bot. Your bot is throwing this exception. Have you tried running your bot locally in a debugger to catch the exception at the moment it is thrown?

@eanders-MS My code haven't places, that must throw this Exception.
MVC Action executes with success result and ExceptionFilter not catch anything.
WebChat, Skype works ok.

@ZOXEXIVO what is your bot id?

Resolved with https://github.com/Microsoft/BotBuilder/issues/1563


Monero syncer: Reuse http dialers

Codecov Report

Merging #186 (3899a60) into main (3d1c04b) will increase coverage by 0.0%.
The diff coverage is 0.0%.

@@          Coverage Diff          @@
##            main    #186   +/-   ##
=====================================
  Coverage   15.6%   15.6%
=====================================
  Files         27      27
  Lines       6077    6070    -7
=====================================
  Hits         945     945
+ Misses      5132    5125    -7

Impacted Files
Coverage Δ

src/syncerd/monero_syncer.rs
0.0% <0.0%> (ø)

src/lib.rs
10.1% <0.0%> (-0.1%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3d1c04b...3899a60. Read the comment docs.


created OrderedList.tsx and UnorderedList.tsx with stories.

References [link the ticket here]
Motivation and context
[Describe the problem we're solving and lay out the solution]
Before
[Describe the current behavior and / or add a screenshot of the current state]
After
[Describe the new behavior and / or add a screenshot of the new state]
How to test
[Add a deep link and instructions how to verify the new behavior]

Please also add a PR description as discussed last week in listings-web


Fix ListFilteredDimensionSpec blacklisting on non-present values.

Bug reported in https://groups.google.com/d/topic/druid-user/6GuZfzzz6o0/discussion.
The bug is that reverseMapping was sized too small when one of the blacklisted values didn't actually appear in the column.

👍


DE/FR/JA Timeline translations for E5/6/7/8 Savage

Many thanks to @Akurosia who helped a noob like me with regexes.

Thanks for all these translations! Sorry for all the tests that cause awkward regexes, but in the end it means that everything gets translated in a more understandable way (I hope!)

Np, I learned many things today

npm run test is a harsh teacher ;)


Java Backend: function cache fix

Proper support for caching+fresh vars and impure functions. Terms using fresh vars and impure functions are not cached.
Description
Added a field JavaSymbolicObject.isCacheable, computed recursively on the AST tree. It is only computed on fully evaluated terms. The value depends not only on the present term bot also on the source term from which present term was computed through function evaluation.
A result term is not cacheable if either:

Source term KLabel is [impure].
A fresh variable is created during evaluation from source term to present term.
Any sub-term is not cacheable.

The entry source -> result is added to the cache only for cacheable results. But the entry result -> result is added for any term, to distinguish terms that are already evaluated from unevaluated terms.

@ehildenb Ready for review. See description. Also includes your tests. Only the latest commit contains the implementation.

@ehildenb Yes. It does not affect KEVM because it doesn't use impure/freshVar.


Refactor/dotnet2.1 efdbcontextfactory

Thank you for contributing to EF.DbContextFactory!
The issue or feature being addressed
https://github.com/vany0114/EF.DbContextFactory/issues/15
Details on the issue fix or feature implementation

Moved out the dependency on AspNetCore.All to the IntegrationTest where it's actually being used
Upgraded both the EFCore.DbContextFactory.IntegrationTest project and the EFCore.DbContextFactory project to target .NET Core 2.1

Confirm the following

[x]  I have merged the latest changes from the dev branch
[X]  I have successfully run a local build
[X]  I have included unit tests for the issue/feature
[X]  I have targeted the PR against the latest dev branch

Hi @ptyang,
Thanks for the PR, and sorry for the delayed answer. I'm gonna try to have a look this week or in the worst case the next week.
Thanks again.


 But cant close it. In task manager uses all allocated RAM.

forgot to include  when opening the terminal its shows as all the chests are empty

What launcher? Which Version are you using? Any other Mods?

im playing on 1.21 minecraft java version, fabric - 0.16.2.
other mods inlcude:

additional structures by XxRexRaptorxX
advanced music mod
alloy forgery
animal feeding trough
Architectury API
artifacts
athena
better advancements
better recipe books (+smithing tables, brewing stands)
Biomes O' plenty
blasting raw metal blocks into blocks
cardinal components API
Carry on
Charm of undying
Chipped
Chipped express
Cloth Config API
Clumps
Cobweb
Collective
Compostables
CraftTweaker
Cristel LIB
Croptopia
Cupboard
Dungeons and Taverns
Durability Tooltop
Dynamic Lights
Elytra slot
EpheroLib
Explorify - Dungeons & structures
fabric API
Faux custom entitiy data
Fish of thieves
Forge Config API port
GeckoLib
GlitchCore
GObber
handcrafted
Harvest with ease
InventoryTweak
Jade
JamLib
Just Enough Items
just Hammers
Lan Server Properties
Lavender API
Macaw's bridges
Macaw's bridges - BIomes O' plenty
Macaw's doors
Macaws's fences and walls
Macaw's furniture

Macaw's lights and lamps

Macaw's Paths and Pavings
Macaw's roofs
Macaw's trapdoors
Macaw'swindows
MaLiLib - community updated
ModernFix
Mouse Tweaks
mythic metals
Mythic Upgrades
Nature's compass
oritech
owo-lib
Phillips Ruins
Polymorph
Reborn Core
Resourceful LIb
retraining
RightclickHarvest
Searchable
spark
Structory
SuperMartijn642's Config lib
Tech reborn
Terrabelnder
Towns and Towers
Traveler's Backpack
tree harvester
Trinkets
Useful hats
Xaero's minimap
Xaero's World map

Solution: i had mini automatic bonemeal farm connected to chest and terminal crashed it. Removed the farm it works fine now.


[GITHUB-2] Adds users and security from code

Adds the ability to configure Nexus via Groovy scripts and adds
more control over the OS service.
Changes:

Adds tasks for executing Groovy scripts from code
Adds flag for turning off service start as well as enablement,
this allows for child roles to install plugins configure the service
Adds Groovy for updating the default admin password
Adds Groovy for setting up an S3 blobstore
Adds Groovy for setting up realms and roles
Adds Groovy for setting HTTP proxies
Fixes tests and they weren't really testing anything

Pure Awesomeness!


[Feature] MobileNetV2 SSD-Lite

Feature

Support setting anchor size manually in SSDAnchorGenerator
Add MobileNetV2 SSD-Lite config

Performance of MobileNetV2 SSD-Lite on coco val2017:
 Average Precision  (AP) @[ IoU=0.50:0.95 | area=   all | maxDets=100 ] = 0.213
 Average Precision  (AP) @[ IoU=0.50      | area=   all | maxDets=1000 ] = 0.354
 Average Precision  (AP) @[ IoU=0.75      | area=   all | maxDets=1000 ] = 0.218
 Average Precision  (AP) @[ IoU=0.50:0.95 | area= small | maxDets=1000 ] = 0.016
 Average Precision  (AP) @[ IoU=0.50:0.95 | area=medium | maxDets=1000 ] = 0.209
 Average Precision  (AP) @[ IoU=0.50:0.95 | area= large | maxDets=1000 ] = 0.413
 Average Recall     (AR) @[ IoU=0.50:0.95 | area=   all | maxDets=100 ] = 0.322
 Average Recall     (AR) @[ IoU=0.50:0.95 | area=   all | maxDets=300 ] = 0.322
 Average Recall     (AR) @[ IoU=0.50:0.95 | area=   all | maxDets=1000 ] = 0.322
 Average Recall     (AR) @[ IoU=0.50:0.95 | area= small | maxDets=1000 ] = 0.045
 Average Recall     (AR) @[ IoU=0.50:0.95 | area=medium | maxDets=1000 ] = 0.347
 Average Recall     (AR) @[ IoU=0.50:0.95 | area= large | maxDets=1000 ] = 0.597

Notice
There are some differences between this implementation and the one in TensorFlow 1.x detection model zoo.

Use 320x320 as input size instead of 300x300.
The anchor setting is different.
The C4 feature map is taken from the last layer of stage 4 instead of the middle of the block.
TensorFlow1.x implementation is trained on coco 2014 and validated on coco minival2014 but this is trained and validated on coco 2017. The mAP on val2017 is usually a little bit lower than minival2014 (refer to the results in TensorFlow Object Detection API, e.g. mAP of MobileNetV2 SSD is 22 on minival2014 but 20.2 on val2017).

Also update readme.


Final Documentation

Create a README.txt file that contains any instructions or outstanding bugs that would be helpful for the teaching staff.

Done.


[Feature Request] Black-/Whitelist and IP based rules won't allow you to import external lists

The current situation is that the white-/blacklist and the IP based rules can be manually edited/enabled/disabled within the configuration file of dnscrypt-proxy. However, the problem or the missing feature I see here is that we don't have any option to work with external pre-made lists.
Modern adblockers like AdGuard, uBlock or the Pi-Hole allowing you to import external lists to make it easier to work with rules from external people.
For example my blocklist rules can't be imported directly into the blacklist or the dnscrypt-proxy.toml. So my wish here would be that people could pickup the blacklist.txt and import it into their blocklist/whitelist/IP list or the configuration file in order to import those rules. Idealy a parser for this seems to be required to check for errors or syntax problems. So we need somwething for the import to check this.

This sounds like a really great idea to keep different lists separate and generally have a sanitized dnscrypt-proxy config...

These lists are highly redundant, with a lot of overlap. This is why external scripts such as the python one which is part of this project are useful. They remove invalid rules, but also optimize them, by merging duplicates and overlaps.
Looking at the output, such as in the mybase list, you can see how many useless rules have been optimized out, and it is quite huge.
Parsing different formats, validating and optimizing the content is not straightforward, and is really better done by an external script.


[Unity] Fix LazyTransformParams use-def analysis and binding emission

Previously the pass LazyTransformParams did not take the case where an output variable is used by other bindings inside the function. It generates wrong Relax function in this case.
This PR fixes this issue. The new test case is an example to elaborate the issue. This PR introduces a sanity assertion check to ensure we handle the case properly.
This PR also enhances variable naming. For binding variables of set_item and kill_object, we now use an underscore ("_") as its name, compared with the previous lv name.

LGTM! thanks for the fix!!


Show topics on channels page

On the screen showing the list of your subscribed channels/streams (from #187), it'd be useful to also have a feature to show the topics within each channel, by tapping something to expand a channel — akin to web's left sidebar.
This doesn't exist in the zulip-mobile RN app, so it could be a post-launch feature. On the other hand, zulip-mobile does have a dedicated screen for listing the topics in a channel, which serves an overlapping set of use cases; it's possible we could leave out that feature if we build this one instead.

We've had a request for this in beta feedback: https://chat.zulip.org/#narrow/channel/48-mobile/topic/mobile.20beta.20feedback/near/2002291

How, where I can acces list of Topics in the Channel in the new Flutter app?

Separately this was requested today:

Channels. I think this is a reasonable default, but Channels on mobile doesn't organize by topic - and by-topic is now the default for Desktop (it is quite hard to get a view of a channel as a feed). I am not sure whether that was a UX mistake - would want more research - but regardless if you want to stick with it, the mobile app should behave the same way.

along with including it as one of the home-view options in #517.
(I think the other request mentioned above would probably be more fully satisfied by #1158.)

Feedback this week:

In my view, an accordion presentation of the topics inside their channels, similar to the presentation on the web app, would be the biggest singular improvement of the mobile UX, because this presentation matches the data model (channel -> topic -> message). Someone who is not aware of that model and gets to know Zulip through the exclusive use of the mobile app would immediately pick it up, something they are unlikely to do on the RN app, in my opinion.


spinner should be less obtrusive

to avoid the feeling of being locked out of the app when you're not

This feeling is even worse with LL. Things open quicker and the relative time of the spinner display looks huge.

mmm. @nadonomy, any thoughts on a quick tweak we might be able to do to show when the ios app is waiting to sync with the server without putting a big spinner on it? @manuroe, what is the specific criteria currently for showing the spinner?

(i assume it's because if we haven't had enough messages in the room since the app launched, we need to go and backfill the history - so we're waiting for a backfill to complete?)


MicrosoftTeams powershell 2.3.1 getting error

When trying to setup policy , I am getting error
Get-CsOnlineSession : Connecting to remote server api.interfaces.records.teams.microsoft.com failed with the following error message : The WinRM client cannot process the request. Basic
authentication is currently disabled in the client configuration. Change the client configuration and try the request again. For more information, see the about_Remote_Troubleshooting Help
topic.
Grant-CsTeamsAppPermissionPolicy -PolicyName "HR App Policy" -Identity d72f6b50-ac7-470a-80b8-919ab8b3232e

Hello @harshdamaniahd how did you connect to Teams PowerShell?

@get-itips Thank you very much for the contribution and digging deep into it.  @harshdamaniahd We appreciate any feedback that improves the content in the Microsoft docs but we haven't had any response from you so we are going to close this issue.
Please feel free to re-open this issue if you see an improvement is required in the specific area of this documentation. We will certainly update this documentation with that valuable information. Thanks again, for taking out some time to open the issue. Appreciate and encourage you to do the same in future also.


Build the wallet canister using nix

Right now it's built manually and the WASM copied into the repo.
This is because the wallet canister source is not stable yet, so it's built from various branches. This is necessary for sodium

not relevant anymore


shutdown hook seems not executed on generic ESG launcher

we have to test if current carina implementation is ok with shutdownhook and drivers cleanup.
need confirmation from carina side that aborted by Ctrl+C or by kill id command execute hook at the end

I can't see the logs from the hook (at least sometimes only the beginning), however, all browsers are closed when launched locally and closed with ctrl+c.

closed as invalid

reopening as it seems entrypoint issue with kill operation


Lose my whole file when JuliaBox disconnects + reload

This has happened to me twice now; both times were a big bummer. :(
While editing for a long time on a file and not touching the JuliaBox main Notebook browser page, sometimes JuliaBox disconnects. Then, the Notebook I'm editing throws up an error saying I must restart. I do so.  :(
So I've completely lost everything I was working on for the last 2 hours. :(

@NHDaly your disk usage (from backed up size) seems pretty close to the quota. Is it likely to be exceeding the quota while running your programs? A large disk could also slow down login (restore) and logout (backup). You may see timeouts when the host machine (shared) is busy.
Handling these cases or showing proper error messages would be a good enhancement to have in JuliaBox.  Larger EBS disk mounts are possible, but it is currently experimental and not enabled for all.
The other reason could be exceeding the allotted RAM of 6GB, but this seems less likely as you reported having lost everything.
If this is likely to be a disk limit issue, and the problem is persisting, please let us know and we can reset your disk.

It could have been a disk usage problem, it looks like. I deleted a bunch of stuff after your message and I don't think I've noticed the problem since, although I have been much more careful about saving regularly and verifying that is says checkpointed, and navigating around on the main JuliaBox page just to keep it from logging me out. So it could be either thing...


Move CachePadded to separate sub-crate

This is (for now) just a proof of concept to see whether moving CachePadded to a separate sub-crate is feasible.
Fixes #1066, which contains related discussion.

Closing in favor of https://github.com/crossbeam-rs/crossbeam/pull/1075.


Float on focus

Dependant on: https://github.com/marvinlabs/android-floatinglabel-widgets/pull/25
This is a proof of concept for edit text float behaviour
adds a flag to float on focus versus float on value present (default)

If this is cool, i'll proceed with the rest of the widgets.

FYI @sebmartin @pseudomuto

Oops forgot to ping you @vpratfr

Looks good. And I think this should actually be the default behaviour.

@vpratfr  All right I think that addresses your first review items, and adds FloatTrigger for the rest of the widgets, except Instant widgets (they seem to always have a value) and Chooser widgets (they are covered from the get go)

@vpratfr sorry to be a ping nuisance you have any notion of when you'll get a chance to look at these?

Should be available in 1.6.0 with some changes. Got rid of the enum, I felt this was not necessary and confusing. Thanks a lot for the rest, that's a great enhancement.


Anonymous, self-invoking function

Currently, Transcrypt has a -p option so I can set the parent object of the function.  Many times, I just need the JS to run at load time and then disappear.  It's not an "app" that needs to stick around.  Any way to do this with the options?
As an example, suppose I have myscript.py:
print('Hello World')

With default transcrypt options, myscript.js adds to the global namespace:
function myscript () {
    ...
}
window ['myscript'] = myscript ();

With -p .none option, myscript.js still puts the function myscript in the global namespace:
function myscript () {
    ...
}
myscript ();

(-p .user also puts the function in the global namespace)
What I'm after is this:
$(function() {
    function myscript () {
        ...
    }
    myscript ();
});

That way it never enters the global JS namespace.  In fact, we could even remove the inner function and get rid of the myscript reference entirely, but that's just a minor enhancement.
Thanks again for the project.  Loving it.

@JdeH In case you want to see the interest in this, I was thinking about it recently as well.

Thanks both for the feedback.
Am considering adding something like this.
Will get back on it.

This can now be done with 3.7.1 alpha, it just generates ES6 modules, but no particular way to start them. See demo's in the prerelease.


Support ACLs in navbarMenu chaise config

We want to be able to control which links show up in the navbar dropdown lists based on ACLs so logged in users, less privileged users, and logged out users can potentially see different dropdown menu lists of links to navigate to.
A proposed solution for this is to extend the navbarMenu chaise config option to include another attribute as a sibling to name and url:
navbarMenu: {
  "children": [{
    "name": "Add Anatomical Record",
    "url": "/chaise/recordset/#1/vocab:anatomy",
    "acls": {
      "show": [attribute, ...],
      "enable": [attribute, ...]
    }
  }, {...}, ...]
}

The 2 lists in acls will be used to control 2 things, whether the option/link is displayed and whether it is interactable. The show array will control what group or groups of users can see the current option. The enable array will control what group or groups can click that displayed option.
The attributes should match the attributes that are returned as part of the user's session object from webauthn when they login.

I will edit the issue to fix one syntax problem.  The "acls" value is the object containing the "show" and "enable" lists.  There is no extra list around this object.
Otherwise, I think we're on the same page, but I'll add that these ACLs should be located hierarchically, so if not found on the current navbar tree node, look up towards root to find an ACL by that name.  so a top-level ACL can set default rules for the whole bar, then each parent can set defaults for all its children entries and each leaf node can have a custom rule.  This should be done for each of show and enable, i.e. so I could inherit one ACL but set the other.
I would suggest that when a node is determined to have show=false, you skip it and all its children. If show=true but enable=false, it is disabled and so is visible but a disabled interior node (with children) gets converted to a disabled leaf, so there is no way to click/reach its children.
As for implementation, I would suggest that you digest the attribute.id list of the client's webauthn session into a hashmap like { "attribute_url_1": true, "attribute_url_2": true, ..., "*": true } at the beginning. (So even anonymous users have {"*": true} as their attribute summary.)  Then, you can quickly iterate an ACL until you find the first element that is a key in the hashmap to answer true or reach the end of the ACL and answer false.
When searching up the navbar tree, to find the applicable ACL, consider a top-most inherited default of "acls": { "show": ["*"], "enable": ["*"] } which yields a backwards-compatible default behavior for navbars without any ACLs.

@karlcz the changes for this issue have been merged into master. Reassigning to you for review.


Change regex to use PCRE

This changes the regex matching for criterias to use PCRE instead of POSIX. i3 uses PCRE, so this would be increase compatibility with it.
PCRE is already pulled in as a dependency so I don't think this will cause any issues.

Thanks!


Pick an email marketing system for signup form

Resources listing the best CRM/email marketing tools out there:

PCMag: The Best Email Marketing Software for 2022
wpbeginner: 7 Best Email Marketing Services for Small Business (2022)
Email Tool Tester: Compare the Top 5 Newsletter Services
Influencer Marketing Hub: 11 of the Best Email Marketing Services for Small Businesses
Website Builder Expert: 6 Best Email Marketing Services for Small Business
Fit Small Business: 6 Best Email Marketing Software for Small Businesses in 2022
QuickSprout: Top 10 Best Email Marketing Services
isitwp: 8 Best Email Service Providers
BenchmarkOne: 10 Best Email Marketing Tools for Small Business

Based on the above resources, the tools with the most recommendations (in desc order) were:

MailChimp (8)
Constant Contact (8)
SendinBlue (8)
GetResponse (6)
AWeber (6)

So these are the ones I took the time to dig into on this comparison spreadsheet on Google Drive. I looked at cost, max contacts, email send limit, customer support, and general user-friendliness and feature-completeness according to those articles (user segmentation, email scheduling/automation, number of templates, etc.). It ultimately boils down to what we're willing to pay for, because different services are more worthwhile at different cost tiers. I can't imagine we'll ever have more than a few hundred contacts, or send more than one or two messages to each of them in a month, so I don't really want a recurring monthly fee for this small use case. Based on the above research the best free tier service seems to be SendinBlue. So yeah, I'm voting
SendinBlue
@asdkiller and I will discuss and close this issue once we reach a decision.

Yep, we are going to move forward with SendinBlue. #3 is now unblocked. 👍


[tensorflow/compiler/xla/service/shape_inference.cc] Add calls to reserve() before populating vectors

https://github.com/tensorflow/tensorflow/pull/51739#issuecomment-940389562 told me to split the larger PR into one PR per file; thus this (thanks bash, git and gh!)

@gbaned / @akuegel With no leading spaces?! - Ok, you're the boss


Skip scoring if model has other errors.

It would be better if zxcvbn doesn't append password score related errors, when the model has other validation errors already. For e.g. errors like this Password can't be blank. Password not strong enough. It scored 0. It must score at least 2. doesn't make any sense.

I do agree.

@msumit Thanks, closed by version 2.1.2

I understand the rationale, but it's somewhat unexpected behaviour to have errors 'appear' once all the others have gone, and I think it would be good to have this documented somewhere.


Update to tab-view-items.component.html

spelling error & incorrect tense.

Than you for your PR - the addressed issues were fixed with another PR so I will close this one.


NavigationHistory

Want to back this issue? Place a bounty on it! We accept bounties via Bountysource.

Closing this due to lack of activity.  This can be handled at the application level by listening for moveend events (and you can use the browser history with something like tschaub/hashed).


Minor docstring fixes

I added those fixes to hopefully fix the code example on http://ts-vanilla.readthedocs.io/en/latest/objects/FloatingWindow.html.
The HUDFloatingWindow doesn’t seem to be included in the documentation at all, although there is a docstring. Is there a reason for that?
Also, I don’t know why the first table (options for fullScreenMode) on http://ts-vanilla.readthedocs.io/en/latest/objects/Window.html doesn’t render properly

I leaving this open because I can't answer those questions. @typesupply?

HUDFloatingWindow

I probably added the wrapper in haste and didn't add it to the documentation. Bigger question: is a defined HUDWindow the right way to do this anymore or should it be handled with NSAppearance.

options for fullScreenMode

A quick glance at the source doesn't tell me, either. It's probably a hard to spot markup issue. I'd just rebuild it from scratch and see if that solves the problem.


ROS node hangs

I followed the steps from the ReadMe, when I run the tracker by below command, (with roscore running)
$rosrun multi_object_tracking_lidar kf_tracker
It hangs showing About to setup callback
Do I need to do something else? Like providing inputs ? From where does it takes the input?

Thanks Praveen.
Since I am new to ROS, not aware of ros commands.
Can you direct me on how to use rostopic etc.,?

Thanks for your wonderful contribution, i came through the same problem as "It hangs showing About to setup callback".
Then, i changed the subscribed topic in main.cpp from "filtered_cloud" to "pandar_points" which is the topic published by the lidar i used. but it still didn't work.
i can't figure it out.

The "pandar_points" is in the form of PointCloud2

@VijeetBenni : There are a lot of tutorials and documentation online that cover how to publish data to ROS topics. Please refer to them. Some pointers:

Understanding ROS topics
Laser scans and point clouds in ROS; Converting laser scans to point clouds

@xph123123 : You can use the remap tag to remap "pandar_points" to "filtered_cloud".
If you change the topic anme in the code, please make sure you rebuild this ROS node before running to make sure your code change came into effect.

Thank you very much for your help. The problem has been solved!

@xph123123 : Glad that your problem has been solved!
Closing this issue. Reopen or create a new one if required.

@praveen-palanisamy: I have the same issue.  Do I need to publish each cluster, obj_id, and viz to the filtered_cloud topic?  After running "rosrun multi_object_tracking_lidar kf_tracker", I look at the rostopic list and it reads:
Published topics:

/rosout_agg [rosgraph_msgs/Log] 1 publisher
/rosout [rosgraph_msgs/Log] 2 publishers
/cluster_0 [sensor_msgs/PointCloud2] 1 publisher
/cluster_1 [sensor_msgs/PointCloud2] 1 publisher
/cluster_2 [sensor_msgs/PointCloud2] 1 publisher
/cluster_3 [sensor_msgs/PointCloud2] 1 publisher
/cluster_4 [sensor_msgs/PointCloud2] 1 publisher
/cluster_5 [sensor_msgs/PointCloud2] 1 publisher
/obj_id [std_msgs/Int32MultiArray] 1 publisher
/viz [visualization_msgs/MarkerArray] 1 publisher
/initialpose [geometry_msgs/PoseWithCovarianceStamped] 1 publisher
/move_base_simple/goal [geometry_msgs/PoseStamped] 1 publisher
/clicked_point [geometry_msgs/PointStamped] 1 publisher

Subscribed topics:

/rosout [rosgraph_msgs/Log] 1 subscriber
/filtered_cloud [sensor_msgs/PointCloud2] 2 subscribers
/tf [tf2_msgs/TFMessage] 1 subscriber
/tf_static [tf2_msgs/TFMessage] 1 subscriber

I even went into the main file of kf_tracker source code and included:
#include <pcl_ros/point_cloud.h>
I still get the "About to setup callback" error.
I also opened rviz and tried to add the PointCloud2 display with filtered_cloud topic.  I've tried just about everything but nothing seems to work.  I would really love your help!


Save intermediate results of mutli-resolution recon

Per Rakesh's request, we should add an argument in recon() function to save the intermediate results of multi-resolution recon.
Specifically, the interpolated results from lower resolution should be saved. In the case where the experiment gets interrupted, the interploated lower resolution image can be used as an init image to re-launch the experiment.
Proposed interface:
def recon(sino, angles, dist_source_detector, magnification,
          ...
          lib_path=__lib_path, save_init_images=0,
          ...
          ):

lib_path (str, optional): [Default=~/.cache/mbircone] Path to directory containing library of forward projection matrices.

save_init_images (int, optional): [Default=0] If (save_init_images>0) and (max_resolutions>0), the init_image for all resolution spaces except for the lowest one will be saved.
Each init_image is generated from the interpolation of the recon result from the lower resolution space.
Each init_image will be saved as a .npy file to <lib_path>/init_images/<sysmatrix_name>.npy, where < sysmatrix_name > is the name of the system matrix corresponding to the geometry parameters of the current resolution space.

Interface design, implementation and testing here:
mbircone_save_progess.pptx
I can make a PR once we get group agreement on the interface design.

Diyu, I don't think it is a good idea to save ppt's or binaries in general on the GitHub. I'm looking at your email now.

Diyu, I don't think it is a good idea to save ppt's or binaries in general on the GitHub. I'm looking at your email now.

Got it. Thanks!
I deleted the ppt slides from the reply above.


Restructure CLI documentation

Installation has to handle several Materialize versions with several Aurelia-CLI versions. The number of possible combinations may cause some confusion as the description is now quite long and fragmented.
On top of that, there is now the possibility to add SystemJS to the bundlers used by the CLI.
Additionally, some "tricks", like font handling with Aurelia CLI, seem to be hard to find. Probably because the installation instructions are as long and fragmented as they are now.
One approach is to create sub-navigation items for each Materialize version. I'd like to add collapsible areas for different Aurelia-CLI versions if GitBook supports that - there's probably a plugin for that.
Any ideas appreciated. 😃

Of course, an installation helper (au install aurelia-materialize-bridge) which does all the configuration would probably be the best help of all..

Note to myself: don't forget CLI supports webpack, too. 😃

Problems with SystemJS loader (so far):

apparently users still need to create an AMD module which I find counter-intuitive
if placed in a separate bundle, Materialize and the bridge are not loaded

I guess point 2 is the reason why the CLI docs don't work for SystemJS out of the box.


TabBar metadata is not reassigned if the data is an empty Array or Dictionary

Godot version
v4.2.dev4.official [549fcce5f]
System information
Godot v4.2.dev4 - Windows 10.0.22621 - Vulkan (Forward+) - dedicated NVIDIA GeForce RTX 2060 (NVIDIA; <IP_ADDRESS>99) - AMD Ryzen 5 2600X Six-Core Processor (12 Threads)
Issue description
If we assign empty arrays or dictionary to tab metadata, they will not be reassigned if new and old data is empty.
Steps to reproduce
var tab_bar := TabBar.new()
tab_bar.add_tab()

var data_a : Array = [] # Old empty data.
tab_bar.set_tab_metadata(0, data_a)

var data_b : Array = [] # New empty data.
tab_bar.set_tab_metadata(0, data_b)

print(is_same(data_b, tab_bar.get_tab_metadata(0))) # false, but must be true.
print(is_same(data_a, tab_bar.get_tab_metadata(0))) # true, but must be false.

Minimal reproduction project
demo.zip

It checks for value comparison, which treats these as equivalent and doesn't update the value
The question is if relying on reference equivalence here is safe, and if this is a bug or just the way these types are usually treated
But removing the check would be trivial


bug / downgrade package to be buildable with .net6-sdk

Closes #33

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 75.417%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
257

Relevant Lines:
364

💛  - Coveralls


Move boot_with_cloudinit logic from provision to rhevm vm

In some cases during a provision, the provisioner does not want to use the
autostart destination logic of the provisioning state machine. Unfortunately
for rhevm vms, we need to set use_cloud_init = true when booting for the
cloud-init data to be attached. So we move this logic to the vm istelf by
setting a custom attribute on the vm, then modifying the raw_start method
to check for the custom attribute and conditionally set the flag and remove
the custom attribute.
https://bugzilla.redhat.com/show_bug.cgi?id=1348614

@gmcculloug Please review

@miq-bot add_label provisioning
@miq-bot add_label providers/rhev
@miq-bot add_label bug


[GHSA-2g42-2pwg-93cj] Sensitive information disclosure in NetScaler ADC and...

Updates

Affected products
Description
References
Severity
Source code location
Summary

Comments
Added link to exploit code

👋 Hi @nathanawmk, thank you for your interest in GHSA-2g42-2pwg-93cj. We can't accept the contribution and review the advisory because NetScaler ADC and NetScaler Gateway are proprietary products and not part of one of the GitHub Advisory Database's supported ecosystems.


Chromebook support?

Hey there!
I really like uBlue and use it or it's derivatives on all my machines.
I recently got a Chromebook, will not be the last.
And once corebooted with EDK2 (UEFI) they can run any Linux distro!
But they have

strange keyboards
strange soundcards

The keyboards work how they should, kinda, but the soundcard is nonfunctional.
On KDE I can use "Pro Audio" mode and get sound in one strange channel.
There is this script by chrultrabook community members that is supposed to automatically fix the audio issues. There is also this keyboard remapping script to make the special keys work like normal F1-12 keys.
At least the soundcard fix requires a mutable system to work, and I thought this could be a nice candidate for the custom uBlue images!
I will try to build an image myself, based on kinoite-main and including these scripts. If it runs, I will report back.

Ultramarine is much further ahead than us on this, probably the way to go: https://wiki.ultramarine-linux.org/en/anywhere/chromebook/

@castrojo afaik their goal is to make Fedora run on stock Firmware, which is not meant to run regular Linux and thus this approach is a bit crazy. If that is true, and their only goal is this, it also lacks the advantages of a laptop which you dont need to trust / where you can reflash firmware once it got into the wrong hands.

@castrojo afaik their goal is to make Fedora run on stock Firmware, which is not meant to run regular Linux and thus this approach is a bit crazy. If that is true, and their only goal is this, it also lacks the advantages of a laptop which you dont need to trust / where you can reflash firmware once it got into the wrong hands.

all of our userspace and kernel tweaks also work on full ROM (e.g; MrChromebox Coreboot)


Otherwise, I wouldn't have noticed.


fix(sec): upgrade org.testng:testng to

What happened？
There are 1 security vulnerabilities found in org.testng:testng 7.3.0

CVE-2022-4065

What did I do？
Upgrade org.testng:testng from 7.3.0 to  for vulnerability fix
What did you expect to happen？
Ideally, no insecure libs should be used.
The specification of the pull request
PR Specification from OSCS

Hi @cubxxw, thank you for the patch! Based on https://nvd.nist.gov/vuln/detail/CVE-2022-4065, it seems like the vulnerability exists for 7.7.0 as well:

A vulnerability was found in cbeust testng 7.5.0/7.6.0/7.6.1/7.7.0. It has been declared as critical. Affected by this vulnerability is the function testngXmlExistsInJar of the file testng-core/src/main/java/org/testng/JarFileUtils.java of the component XML File Parser. The manipulation leads to path traversal. The attack can be launched remotely. Upgrading to version 7.5.1 and 7.7.1 is able to address this issue. The name of the patch is 9150736cd2c123a6a3b60e6193630859f9f0422b. It is recommended to upgrade the affected component. The associated identifier of this vulnerability is VDB-214027.

Perhaps upgrade to 7.7.1 or the latest version 7.8.0?

@cubxxw, can you please look into the failing CI checks? The integration test module is failing to compile:
Error:  Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.11.0:compile (default-compile) on project druid-integration-tests: Compilation failure: Compilation failure:
Error:  /home/runner/work/druid/druid/integration-tests/src/main/java/org/testng/DruidTestRunnerFactory.java:[73,7] no suitable constructor found for TestRunner(org.testng.internal.IConfiguration,org.testng.ISuite,org.testng.xml.XmlTest,java.lang.String,org.testng.internal.annotations.IAnnotationFinder,boolean,java.util.Collection<org.testng.IInvokedMethodListener>,java.util.List<org.testng.IClassListener>,java.util.Comparator<org.testng.ITestNGMethod>,org.testng.DataProviderHolder)
Error:      constructor org.testng.TestRunner.TestRunner(org.testng.internal.IConfiguration,org.testng.ISuite,org.testng.xml.XmlTest,java.lang.String,org.testng.internal.annotations.IAnnotationFinder,boolean,java.util.Collection<org.testng.IInvokedMethodListener>,java.util.List<org.testng.IClassListener>,java.util.Comparator<org.testng.ITestNGMethod>,org.testng.DataProviderHolder,org.testng.SuiteRunner) is not applicable
Error:        (actual and formal argument lists differ in length)

Error:  Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.11.0:compile (default-compile) on project druid-integration-tests: Compilation failure
Error:  /home/runner/work/druid/druid/integration-tests/src/main/java/org/testng/DruidTestRunnerFactory.java:[23,27] cannot access org.testng.internal.IConfiguration
Error:    bad class file: /home/runner/.m2/repository/org/testng/testng/7.8.0/testng-7.8.0.jar(org/testng/internal/IConfiguration.class)
Error:      class file has wrong version 55.0, should be 52.0
Error:      Please remove or make sure it appears in the correct subdirectory of the classpath.


AngularJS Flip Control - Uncaught TypeError

Using NPM start, I get the following error in the PCF Control Sandbox.  The sandbox content does not display and a blank screen appears.  Node version 12.18.3
Files = https://github.com/microsoft/PowerApps-Samples/tree/master/component-framework/AngularJSFlipControl
`
SimpleFormatter.ts:41
   Uncaught TypeError: e.toLowerCase is not a function
at Object.t.ParseRaw (SimpleFormatter.ts:41:34)
at DefaultHostProps.ts:183:41
at Array.forEach (<anonymous>)
at f (DefaultHostProps.ts:181:42)
at u (DefaultHostProps.ts:52:39)
at Object.t.createWebClientWrapperProps (DefaultHostProps.ts:38:48)
at t.render (ControlHost.tsx:85:15)
at finishClassComponent (react-dom.development.js:17515:33)
at updateClassComponent (react-dom.development.js:17465:26)
at beginWork (react-dom.development.js:19103:18)
at HTMLUnknownElement.callCallback (react-dom.development.js:3942:16)
at Object.invokeGuardedCallbackDev (react-dom.development.js:3991:18)
at invokeGuardedCallback (react-dom.development.js:4053:33)
at beginWork$1 (react-dom.development.js:23994:9)
at performUnitOfWork (react-dom.development.js:22809:14)
at workLoopSync (react-dom.development.js:22737:7)

`

@DeanB2015
Sorry for the late reply. If you are still experiencing this problem, please re-open this issue

Thanks @rolf-weiglein-bizerba
I can't repro this specific issue, I've got a different one. I'm going to reach out to the dev team.

@jopursle tells me he is working on a fix for this. Let's close this when those changes get pushed out.

Thanks @rolf-weiglein-bizerba I can't repro this specific issue, I've got a different one. I'm going to reach out to the dev team.

Thanks @JimDaly

@JimDaly As I understand your approach with Angular Flip Control, you are creating the Angular app virtually in the DOM. Are there any ways to use an Angular app (created with ng new  in the PCF project) inside a PCF code control? I am currently having issues when I try to initialize the Angular app. It is not rendering in the PCF.


Allow testing multiple apps with "samples test app"

For example, testing "6-pubsub/app.js" and "6-pubsub/worker.js" - ideally, I should be able to test both using "samples test app".

Conversed with @jmdobry offline - this utility is a test runner, not a tester in and of itself.


Extract license info outside of the JavaScript bundle

Description
This is something between a bug and a feature I guess, but I notice that my JS bundle contains a lot of similar license code comments.
Sample: https://stackblitz.com/edit/vitejs-vite-k6vbhh?file=dist%2Fassets%2Findex-trimmed.js
After removing these with uglify-js I see about 20% file size decrease.
npx uglify-js ./dist/assets/index-DQVm2kVJ.js --output ./dist/assets/index-trimmed.js

-rw-rw-r--  1  staff  staff  475905  Aug  16  14:27  index-DQVm2kvJ.js
-rw-rw-r--  1  staff  staff  371060  Aug  16  14:32  index-trimmed.js

While these licenses are important, my average website visitor won't really bat an eye about this.
Suggested solution
I'm wondering if Vite could extract all the comments and place them into a license.txt file and link that in my bundled.js instead.
Alternative
I guess I can do post processing myself to deal with this.
Additional context
The firebase package does seem to bring a lot of very similar Google licenses. So you only have this problem based on what packages you use.
Validations

[X] Follow our Code of Conduct
[X] Read the Contributing Guidelines.
[X] Read the docs.
[X] Check that there isn't already an issue that request the same feature to avoid creating a duplicate.

I think esbuild is preserving @license comment by default https://esbuild.github.io/api/#legal-comments
You can esbuild.legalComments: "none" to strip all comments:
import { defineConfig } from 'vite';

export default defineConfig({
  esbuild: {
    legalComments: 'none',
  },
});

Probably what you want is esbuild.legalComments: "linked", but unfortunately this is not supported for Vite build since Vite uses esbuild to trasnform individual files.

I'm personally inclined to mark this as an enhancement since it would be a nice default for Vite to auto manage and emit licenses when building apps.


init_speed

openscenario_configuration.py with get_actor_speed()
scenario_configuration.py with init speed value
atomic_behaviors.py with new atomic behavior SetOSCInitSpeed and
blackboard variable to switch off the init speed atomic
open_scenario.py with _create_init_behavior(),
added to beginning of parallel behavior tree
carla_data_provider with actor.id
added new implementation to CHANGELOG

Description

Fixes #
Where has this been tested?

Platform(s): ...
Python version(s): ...
Unreal Engine version(s): ...
CARLA version: ...

Possible Drawbacks

This change is

As soon as I’m in the office I’ll send another PR with some further changes from yesterday evening and with respect to your comments here. Thanks;)


[add-resource] New Plugin: Minify HTML

I would like to add my new plugin to the Grav Repository. Here are the project details: https://github.com/jmbelloteau/grav-plugin-minify-html

Added to GPM

@rhukster thank you !

Hi @rhukster!
I've just try to install the plugin from admin and apparently there is a little problem.
The root folder of the plugin is not properly named.
Actually it's /user/plugins/minify-html but should be /user/plugins/minifyhtml
Because of this the plugin is not showing/working.

The folder is taken from the repo name, it's grav-plugin-minify-html, so Grav gets minify-html.
Change your main php file and yaml to minify-html.php and minify-html.yaml and create a new release. The class name is ok.

Actually i can fix via GPM, by setting the 'slug' name.  It's always better to use the same name in your repo as in your local Grav plugin though or it gets confusing :)

fixed for next GPM update

Don't worry @rhukster, I will stick to the default behaviour and make the @flaviocopes modification. This is easy to do 😄

Done!

@rhukster I think we both update and it's broke again ^^
Can you go back to minify-html for the next release.
Thank you man and sorry for the misunderstanding.

switched it back for next update.

@rhukster you will hate me lol !
I had to change my github username... sorry... here is the new link... it's the last time promess
https://github.com/jimblue/grav-plugin-minify-html

done

Apparently the minify-html plugin was deleted. Is there any alternative?


HumanCompatibleAI -> AlignmentResearch (v1)

Updates README and .gitmodules to reflect migration to AlignmentResearch github org.

Closing because README has since been updated to incorporate many of the changes in this PR.

Reopening now I've moved gogui

Can't actually review cause I am the original PR author, but LGTM.
I checked and the only references to "HumanCompatibleAI" (non-case-sensitive) are for docker hub.
I made a new issue to track the docker migration when we eventually get to it: https://github.com/AlignmentResearch/go_attack/issues/104


New install - No "beloved" LivePreview :( .. error launcing browser

On Linux Mint. Had it working nicely. Accidentally resized partitions, so had to reinstall, from 18.3 to 20.1 (latest version of the OS).
Now, when I install, it says "error launching browser.  Even the experimental live preview is not working!

_


Clean up interface

This is work in progress. The objective of this PR is to do a little polishing of the tagging interface before migrating the first applications and opening it up to GDS Editors.
The most important page is the tagging screen:

I will be deploying this branch to preview so that it can be reviewed easily:
https://content-tagger.preview.alphagov.co.uk/
Trello: https://trello.com/c/ilVoAp9Z

https://github.com/alphagov/content-tagger/commit/a496b2e7473f25bd89c76484efcd14362053da47 fixes a bug when a page is untaggable. It's deploying to preview now.

A few bits for addressing, otherwise looks good. Happy to merge once commented bits are addressed.

@mobaig updated

lgtm


Add crossguard blog

Add CrossGuard preview blog.

@spara

Needs an appropriate meta.png image

Yes but I wasnt quite sure what to use here.. any suggestions?

@spara I cannot merge this until you re-review since you requested changes. Please take another look


glossentry references are not rendered correctly

I receive the following error with a simple test scenario:
[DOTJ047I] Unable to find key definition for key reference "G_Term" in root scope.

test scenario:
Glossary-Test 002.zip
The glossary entry does not appear in the PDF output. I have tested this using the DITA-OT 2.2.1.

Possible Solution
Suggested by @drmacro in duplicating issue #2788:

Remove the check in "topic.term" template that gets the matching acronym. That behavior should be applied to abbreviated-form.

Hmm. Has this ever worked? I tried 1.5.4, 1.7.5, 1.8.5, 2.0.1, and 2.2.1 and it didn't work on any of them.

Ok, so not a bug, it's missing functionality.

In fact, this is a duplicate of #1721.

(The workaround is to add @print="yes" to the <glossref> element.)

Ah, that one. A feature of DITA that is by no means obvious.

Well, print="no" is a strange default here. Could anyone who is working on the OASIS deliverables force that print="yes" is becoming the default value? Otherwise it would be interesting to read a motivation in the specs, why print="no" is the default.
So, I assume that nobody realized that the default also affects the rendering of abbreviated-form and term. I think that the intention was, that a glossary should not be printed, which might make sense. But it does not make sense to have gaps in the text.
So please, if you do not want any text to appear here, please throw at least a message that informs the publisher, why that happens. This would not break anything but would reduce a little confusion here.

But anyway, there is a bug here. This is the code of the <concept>:
<?xml version="1.0" encoding="UTF-8"?>
<!DOCTYPE concept PUBLIC "-//OASIS//DTD DITA Concept//EN" "concept.dtd">
<concept id="C_Concept">
 <title>Concept</title>
 <shortdesc>Concept with a term.</shortdesc>
 <conbody>

<codeph>term</codeph> (empty) with <codeph>keyref</codeph> attribute: <term keyref="G_Term"/>

<codeph>term</codeph> (filled) with <codeph>keyref</codeph> attribute: <term keyref="G_Term">term</term>

<codeph>abbreviated-form</codeph>: <abbreviated-form keyref="G_Term"/>

 </conbody>
</concept>

This is the code of the <glossentry>:
<?xml version="1.0" encoding="utf-8"?>
<!DOCTYPE glossentry PUBLIC "-//OASIS//DTD DITA Glossary//EN" "glossary.dtd">
<glossentry id="G_Term">
    <glossterm>term</glossterm>
    <glossdef>definiton</glossdef>
    <glossBody>
        <glossAlt>
            <glossAbbreviation>abbreviation</glossAbbreviation>
        </glossAlt>
        <glossAlt>
            <glossAcronym>acronym</glossAcronym>
        </glossAlt>
    </glossBody>
</glossentry>

And this is the rendered PDF result (print="yes" is set):

<abbreviated-form> shows the text term, but it should display acronym. This intended behavior is also very strange. The specs say, that <abbreviated-form> displays the value of <glossAcronym> not of <glossAbbreviation> and BTW an <acronym-form> element would be nice.
Fortunately the XHTML processing is logically, but it does not comply to the specs. This is the rendered result:

The specs say, that <abbreviated-form> displays the value of <glossAcronym> not of <glossAbbreviation>, but in this case, <glossAbbreviation> is displayed.

So please, reopen this. I change the title from Processing glossentry elements throws [DOTJ047I] to glossentry references are not rendered correctly, because the subject has changed.

I haven't looked at the code yet so I'm not sure, but I would imagine that it doesn't handle the distinction between what the spec calls "introductory" and "non-introductory" contexts (which basically mean first use and subsequent uses, I guess), either, so that should probably also be implemented.
Also, if I remember correctly, there's quite a bit of code duplication between transtypes when it comes to the processing of <abbreviated-form> and <term> elements. Might be better to move some of the code into preprocessing or into common library code.

This is probably quite easy to fix. How about adding a milestone tag?

Having taken a proper look at the issue and the code, isn't the case actually that the PDF output is per spec?
The <abbreviated-form> element in your example is the first (introductory) use of the abbreviated form, therefore:

In an introductory context, processors SHOULD render the surface form of the term by displaying the contents of the glossSurfaceForm element from the referenced glossentry topic.
If the glossentry topic does not contain a glossSurfaceForm element or the glossSurfaceForm element is empty, processors SHOULD render the contents of the glossterm element in introductory contexts.

In other words, first use → <glossterm>, since <glossSurfaceForm> doesn't exist, which how DITA-OT currently behaves.
The second use displays the value of <glossAcronym>:

I agree that it's kinda odd that it uses <glossAcronym> instead of <glossAbbreviation> (@robander might be able to comment on that), but it is, as you say, per spec.
So I guess the only actual bug (kinda sorta) here is that the XHTML output uses <glossAbbreviation> instead of <glossAcronym>, right? I agree that both transtypes should use the same element, at least.

Not much to comment about except that the creation of <abbreviated-form> and most of the glossentry markup did not come about together, with the functions sort of combined at a later date. I believe the original use case for <abbreviated-form> was specifically to support acronyms, but it was renamed before final approval to make it more general. However, the original intent can still be seen in the rendering connection to <glossAcronym>.
I had never noticed that disconnect, because I still remembered this as a feature to support acronyms, with the <abbreviated-form> name coming about as part of a compromise; I hadn't noticed <glossAbbreviation> while also considering the other domain. Regardless, the creation of all of those elements (and the combination of the modules for processing) went through a lot of churn, and I'm not too surprised that some quirks came out in the end.

So I guess the only actual bug (kinda sorta) here is that the XHTML output uses  instead of , right? I agree that both transtypes should use the same element, at least.

@eerohele: Yes.
I enhanced the test data and added <glossSurfaceForm>.
Test data: Glossary-Test.zip
PDF
As @eerohele said, the PDF complies to the specification and no change is needed here. This is the PDF output of the test data.

XHTML
The XHTML result does comply to the specification (needed changes are summarized at the end of this post). This is the XHTML output of the test data.

Needed Changes
This list summarizes the differences between the processing of the <term> and the <abbreviated-form> element of the XHTML output.

<term> shows the value of <glossAbbreviation> when it is not the first occurance of a <term> element referring to the same glossary entry in the same topic. This is wrong. <term> should always show the value of the <glossterm> element.
<abbreviated-form> shows the value of <glossAbbreviation> when it is the first occurance of an <abbreviated-form> element referring to the same glossary entry in the same topic.  This is wrong. <abbreviated-form> should show the value of <glossterm> when it is being used the first time and no <glossSurfaceForm> does exist.
<abbreviated-form> shows the value of <glossAcronym> when it is not the first occurance of an <abbreviated-form> element referring to the same glossary entry in the same topic.  This is wrong. <abbreviated-form>  should show the value of the <glossAbbreviation> element.
<term> shows the value of <glossSurfaceForm> when a glossary entry has a <glossSurfaceForm> element and it is the first occurance of the <term> element referring to the same glossary entry in the topic.
<abbreviated-form> shows the value of <glossAbbreviation> when it is the first occurance of an <abbreviated-form> element referring to the same glossary entry in the same topic. This is wrong. <abbreviated-form> should show the value of the <glossSurfaceForm> element of the glossary entry, if it has one and if not, it should show the value of the <glossterm> element.

@eerohele , could you please replace the pdf label of this issue with the html label?

@jelovirt , could you please add a priority label?

#2243 is also related to <term> so it should be kept in mind when fixing this.

I recently ran into this issue with a project using DITA-OT 3.3.3. Using <term keyref="gloss-key"> produces output in PDF but <abbreviated-form keyref="gloss-key"> does not and generates the error below. The gloss-key is defined on a glossary entry and @print="yes".
[DOTX060W]: Key 'gloss-key' was used in an abbreviated-form element, but the key is not associated with a glossary entry. Abbreviated-form should ONLY be used to reference to a glossary entry.


[ROX-15359] Add support for FILTER clause

Description
This PR adds the capability to apply filters to aggregations/derived fields. FILTER clause allows you to filter individual columns on different parameters. This is unlike the WHERE clause that affects the full response. Note that the filter clause is only supported on aggregations. Filter cause is analogous to switch-case.
Filters remove a lot of post-processing because each filter group can be read into a separate column. (Tip: Group By -> Rows; Filter -> Columns)

Example:
To query the count of images grouped by registry, the query would be:
q := search.NewQueryBuilder().
	AddSelectFields(
	   search.NewQuerySelect(search.CVE).
	   AggrFunc(aggregatefunc.Count).
	   Filter(
                "affected_by_critical",
                 search.NewQueryBuilder().
	         AddExactMatches(search.Severity, storage.Vulnerability_Severity_CRITICAL.String()).ProtoQuery(),
           ),
	  search.NewQuerySelect(search.CVE).
	  AggrFunc(aggregatefunc.Count).
	  Filter(
	      "affected_by_important",
	       search.NewQueryBuilder().
	       AddExactMatches(search.Severity,  storage.Vulnerability_Severity_IMPORTANT.String()).ProtoQuery(),
	   ),
    ).AddGroupBy(search.Image).ProtoQuery()

and the response struct would be:
type Demo struct {
  CVEsWithCriticalSeverity int `db:"affected_by_critical"`
  CVEsWithImportantSeverity string `db:"affected_by_important"`
  Image string `db:"image"`
}

and the call would be:
results, err = pkgPG.RunSelectRequestForSchema[Demo](ctx, testDB.Pool, schema.Images, q)
// where results is []*Demo

Checklist

[ ] Investigated and inspected CI test results
[X] Unit test and regression tests added
~Evaluated and added CHANGELOG entry if required~
~Determined and documented upgrade steps~
~Documented user facing changes~

If any of these don't apply, please comment below.
Testing Performed

LGTM. Out of curiosity, did you check or read what type of performance improvements this provides?

@dashrews78, I have not performed a holistic performance test. However, we read much fewer records into memory with FILTER clause support, so memory improvement is evident. For instance, we read extra records and sometimes whole objects into the memory to compute the data for dashboard widgets.
Regarding the turnaround time, I will pick up our current ACS use cases, such as dashboard widgets, and perform a comparative analysis.

The e2e job failure is irrelevant to the changes in this PR.


cg makeLISAdata line 503

            if ii == 0:
                # Take inverse fft to get time series data
                h1 = splice_win * np.fft.irfft(htilda1, N)
                h2 = splice_win * np.fft.irfft(htilda2, N)
                h3 = splice_win * np.fft.irfft(htilda3, N)

            else:

                ## First append half-splice worth of zeros
                h1 = np.append(h1, np.zeros(halfN))
                h2 = np.append(h2, np.zeros(halfN))
                h3 = np.append(h3, np.zeros(halfN))

The else block referenced h1 before assignment. I'm getting this referenced before assignment error, because the primordial model falls into the else block.

@kuan0020 You should not get an error here. The index ii is a reference to the time index. You always start with ii=0

@kuan0020 You should not get an error here. The index ii is a reference to the time index. You always start with ii=0

You are right. It was outside of the loop, that's why it didn't go through ii=0.