Make FormControl externally extensible (via hook)

Followup from discussion in https://github.com/primer/react/pull/3621
Motivation
FormControl supports an 'auto-wiring' functionality where it automatically applies certain props to the wrapped input in order to make accessibility easier. For example, it automatically applies an id prop (if none is provided) to link the wrapped input to the Label.
At present, this is only supported for a limited subset of components, defined internally:
https://github.com/primer/react/blob/65b888c278bb3130fef449163e787a475c971b38/src/FormControl/FormControl.tsx#L58-L67
Consumers of the library cannot add to this list, so it's impossible for consumers to create their own components that support integration with FormControl.
As I work on moving the InlineAutocomplete component out of this repository, we either need to make this functionality externally extensible or we have to break the InlineAutocomplete component and require it to be manually wired up whenever used. I think the first one is much more desirable as it's generally useful for all component authoring.
Solution
I exposed a new hook on the FormControl API: FormControl.useForwardedProps. This hook is given the external props of the component and handles merging them together and building the aria-describedby attribute.
I honestly think this is much cleaner a far preferable solution vs the one proposed in https://github.com/primer/react/pull/3621. There are few downsides, and it's much more idiomatic React. We can avoid using the Children API and the relationship between FormControl and child feels much more natural and robust.
A huge advantage of this approach is that we don't need to forward props down through children - since it's context-based, supported components can be deeply nested.
The only downsides I can think of are:

It's a little less readable to have to wrap the props in a hook. This is pretty minor though and it's not something most users will have to care about at all
We have no way of preventing the id from getting assigned to multiple components. We really want to error if two components in one FormControl are both calling the hook, but I can't think of a clean way to do that. However, this is a pretty rare edge case and I don't think most users will actually try rendering multiple components in a single FormControl

it'd be great if the only way components could interact with the context value was through a hook (instead of useContext()). This could include the optional fallback value, as well, so that calls didn't need to useContext() ?? {}.

Currently it's only internal components that use useContext (the context is not exposed publicly) and I only left it that way to be avoid making too many changes to existing code. But I definitely can make that change :+1:

I'm also curious if you feel like a hook like useFormControl could work as a more strictly defined function so that all the props didn't need to be forwarded along.

I went back and forth on this but eventually landed on this approach for two reasons:

To ensure consistent handling of external props. We want to avoid have a mix where some components override external props and others let external props take priority (over FormControl props). This approach with the hook doesn't force that, but it does strongly encourage it.
To support the console warnings when users do override the props when wrapping in a FormControl. The only way to do that is to know what props are incoming.

I think (1) isn't critical. If we're willing to drop the warnings (which I think are dubious anyway for reasons noted in other comments) then I would definitely agree with changing the hook to accept no arguments and only return the forwarded props. IMO, overall that's more intuitive.

It would be helpful if we could add Storybook stories showing some examples of how consumers might use useFormControlForwardedProps.

Add useFormControlForwardedProps examples to Storybook

I see a few hooks in the Storybook, but they are all visual. I have a hard time seeing how I might make a story for this hook since it does not have a visual effect. Do you have anything in mind?

@iansan5653 - it's ok if there's no visual effect. I just think it would help Primer consumers discover that hook and see an example of how it could be used. I'd recommend adding something like this in the "Hooks" section of Storybook:
export default {
  title: 'Hooks/useFormControlForwardedProps',
  decorators: [
    Story => {
      return (
        <ThemeProvider>
          <BaseStyles>{Story()}</BaseStyles>
        </ThemeProvider>
      )
    },
  ],
  argTypes: {
    disabled: {
      type: 'boolean',
      defaultValue: false,
    },
    id: {
      type: 'string',
      defaultValue: 'some-id',
    },
    placeholder: {
      type: 'string',
      defaultValue: 'Placeholder',
    },
    required: {
      type: 'boolean',
      defaultValue: false,
    },
    validationStatus: {
      defaultValue: undefined,
      options: ['error', 'success', 'warning', undefined],
      control: {type: 'radio'},
    },
    // whatever else you might want to pass to useFormControlForwardedProps
  },
} as Meta

export const UseFormControlForwardedProps = args => {
  const {
    disabled,
    id,
    required,
    validationStatus,
    ['aria-describedby']: ariaDescribedBy,
    ...externalProps
  } = useFormControlForwardedProps(args)

  return (
    <>
      Label {required ? '*' : undefined}
      <input
        id={id}
        disabled={disabled}
        required={required}
        aria-invalid={validationStatus === 'invalid'}
        aria-describedby={ariaDescribedBy}
        {...externalProps}
      />

Some caption

    </>
  )
}

or if you just want to demonstrate what gets returned by the forwarded props, you could just render the result into a table or something:
export const UseFormControlForwardedProps = args => {
  const forwardedProps = useFormControlForwardedProps(args)

  return (

          Forwarded prop
          Value

        {Object.entries(forwardedProps).map(([key, value]) => (

            {key}
            {value}

        ))}

  )
}

@mperrotti Done -- added a story, tests, and directly exposed the hook


Zombie_war game in c++

hello
i would like to add a zombie war game in c++ as a part of Hacktoberfest. please assign me @Astrodevil

Go Ahead👍🏼 Also mention this issue in PR

yeah sure thanks


Locating element by partial text only considers direct child text nodes

Fixes #866
Note that in the SelectorBuilder::XPath that :text and :contains_text are now the same - ie comparing to normalize-space(). From what I could see, there's no reason that they should ever be different. However, for now, to minimize changes, I have left them separate.

Pull Request Test Coverage Report for Build 2003

1 of 1 (100.0%)  changed or added relevant line in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 97.439%

Totals

Change from base Build 2002:
0.0%

Covered Lines:
2321

Relevant Lines:
2382

💛  - Coveralls

Pull Request Test Coverage Report for Build 2003

1 of 1 (100.0%)  changed or added relevant line in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 97.439%

Totals

Change from base Build 2002:
0.0%

Covered Lines:
2321

Relevant Lines:
2382

💛  - Coveralls


Add --listen-metrics flag for /metrics endpoint's port

#1225

I'm going to merge this after doing a release, just so it's not a last-minute change.


1.Solves the bug where the first access _services empty when using Po…

Solves the bug where the first access _services empty when using PollConsul

@0xblack Hi wuhuajun!
After merging latest top commits from base:develop and after running of CI pipeline,
we have one failed unit test:
Failed Ocelot.UnitTests.Consul.ProviderFactoryTests.should_return_PollingConsulServiceDiscoveryProvider

Could you fix this unit test please?
And, it makes sense to cover this case by adding new unit test(s) too.
I will start review as soon as you've fixed current unit tests.

@0xblack Hi Wuhuajun!
Thanks for the fix!
@TomPallister
Please, review and merge the PR!
Pay attention, this bug was mentioned in #1634 .

@0xblack  Well...
Did you fix your own user case, or is the PR related to some open issue?
Also, I have intentional feeling your PR can be a duplicate... We have a number of PRs which address this PollConsul problem.
Let's see!
I'm going to rebase feature branch for more accurate code review...

@ggnaegi
This PR has one line change with extra synchronous call of provider ignoring asynchronous Poll method at all.
I have no idea, it seems calling async operations inside of constructor is not good.
What will we do with this PR, on your opinion? 😃

@raman-m this PR should be addressed now, no?

@ggnaegi commented on Sep 29

Don't address at all! 😸
I've decided to close this PR because it is useless now, after your contribution to latest release.

Duplicate of #1670

@0xblack
Sorry, your PR is not developed well for accepting. And this problem was addressed and bugs were fixed in #1670
Going to close...

I hope you will return to us back with many interesting PRs to close items in backlog. 😉


Added an es.ssl.verificationMode option (only to skip verification)

This allows to set es.ssl.verificationMode to none to skip hostname / CA verification.
@delirius325 if useful I can extend this code to load custom CA certificates or client certificates instead of using javax.net.ssl system properties.

Hello, sorry for the delay, I rebased and add a note about this option to the README file.


Fix weird chruby issue on new terminal windows

With chruby auto, sometimes it doesn't respond to the ruby version. This will use the system ruby so you aren't set with just a plain diamond symbol.

@jwaldrip isn't it just a slight miss use of chruby when there is no default version defined? Like as in RVM/Rbenv there is a way to set default rubies, there is also a way in chruby: https://github.com/postmodern/chruby#default-ruby
My recommendation is to use chruby to it's fullest, then patch minor cases in this theme.


Specify the version number of pandoc for Travis build

This PR  fix the issue #108
Recently, the travis build for documentation have failed during the installation of pandoc through cabal.
It seems that the version of pandoc installed through cabal is now <IP_ADDRESS>. This induce a conflict when resolving dependencies (see travis log).
One way to solve this is to install a previous version of pandoc, which worked before: <IP_ADDRESS>

Looks good to me. Very minor changes, to fix a very annoying bug. I merge.


mypy-type-checker.ignorePatterns doesn't work with glob pattern as documented

Problem
The documentation of mypy-type-checker.ignorePatterns states that it works with glob patterns like described in https://code.visualstudio.com/docs/editor/glob-patterns
But this is not true.
Your implementation uses match from pathlib that (as far as I understand it) doesn't work with glob patterns.
Example
import pathlib

def is_match(patterns: list[str], file_path: str) -> bool:
    """Returns true if the file matches one of the glob patterns."""
    if not patterns:
        return False
    return any(pathlib.Path(file_path).match(pattern) for pattern in patterns)

patterns: list[str] = [
    "**/a_path/**/*.py",
]

file_path: str = "/a_path/a_subpath/a_subpath/my_file.py"

print(is_match(patterns, file_path))

This prints out False.
Replacing **/a_path/**/*.py with **/a_path/**/**/*.py will return True.
External Sources
Here you can see, that the glob pattern **/a_path/**/*.py should work:

https://www.digitalocean.com/community/tools/glob?comments=true&glob=**%2Fa_path%2F**%2F*.py&matches=false&tests=%2Fa_path%2Fa_subpath%2Fa_subpath%2Fmy_file.py

Hi, @karthiknadig amd @Mutantpenguin!
I see that my issue (#214) is a duplicate of this one.
Could you offer any suggestions of a working expression?
Even the full address "/mnt/c/Users/bread/Documents/abz_code/graveyard/*.py" doesn't seem to work.
Thanks again!

@tabbea In the report scope workspace case we are not applying the filtering. The filtering feature was added because linters do not exclude files even if there is a pattern match if the file path is explicitly used when linting.


Use ACTION_DIAL but do not work automatically

Hi  I using follow code ,the secret is pasted to the dial UI, But it do not automatically jump to the engineer IMEI UI（if you input #*06#  manually from UI it will work)
Intent intent = new Intent(Intent.ACTION_DIAL,Uri.parse("tel:" + "*%2306%23"));         intent.setFlags(Intent.FLAG_ACTIVITY_NEW_TASK);         context.startActivity(intent);
is there any solution for this? Thanks.

Hi,
To make this action automatically you need to use Intent.ACTION_CALL as intent parameter.

Hi,
Accessing secret codes like this has been banned. The user needs to enter the code himself. In AOSP (here https://android.googlesource.com/platform/packages/apps/Dialer/+/91197049c458f07092b31501d2ed512180b13d58/src/com/android/dialer/SpecialCharSequenceMgr.java#131), you can see that the handle chars method is used to determine if a secret code was entered and then makes the call to the broadcast.
But in the input logic (here https://android.googlesource.com/platform/packages/apps/Dialer/+/91197049c458f07092b31501d2ed512180b13d58/src/com/android/dialer/dialpad/DialpadFragment.java?autodive=0%2F%2F), in the afterTextChanged method, this method is only called if the input is not from an intent. You can also look up the documentation of the mDigitsFilledByIntent at the top of the file.
So the user would have to first delete everything from the intent and then dial it in themselves, which works. In general, I found that accessing secret codes as a third party app is not possible anymore as the broadcast also requires special permissions now.


Dummy commit for CI integration testing

All checks are now running as expected, although with a slight delay for showing notifications.


Support for Signing String Literals

Description
Adding support for signing string literals. This is similarly to sign-blob, except it allows for a string to be passed in instead of being read from a file.
Example:
$ cosign sign-string --key cosign.key "hello world"
Enter password for private key: MEUCIB2yVuhvuwKLH4AiodNzvxVOvsKVygyYXZpa8R7kUHQiAiEAuuBTC2rJF3DkbT+LH4sZUMkO17LWpvYC/7bhdOG1Hy4=

$ cosign verify-string --key cosign.pub --signature MEUCIB2yVuhvuwKLH4AiodNzvxVOvsKVygyYXZpa8R7kUHQiAiEAuuBTC2rJF3DkbT+LH4sZUMkO17LWpvYC/7bhdOG1Hy4= "hello world"
Verified OK

Please see pull request https://github.com/sigstore/cosign/pull/1299

Closing as the attached PR was closed!


Record locations of prefix and name in AstTypeReference

Would be useful if AstTypeReference.prefixLocation and AstTypeReference.nameLocation existed, rather than just the full location currently available.

Sound like a good idea.


MQTT publish errors

homebridge-xbox-tv v2.3.8 on homebridge 1.6.0
I'm seeing MQTT publish errors in the XboxTV plugin:
[26/11/2022, 20:40:30] [XboxTv] Device: xbox.local Xbox, MQTT Publish error: TypeError [ERR_INVALID_ARG_TYPE]: The "string" argument must be of type string or an instance of Buffer or ArrayBuffer. Received an instance of Object
[26/11/2022, 20:40:30] [XboxTv] Device: xbox.local Xbox, MQTT Publish error: TypeError [ERR_INVALID_ARG_TYPE]: The "string" argument must be of type string or an instance of Buffer or ArrayBuffer. Received an instance of Object
[26/11/2022, 20:40:34] [XboxTv] Device: xbox.local Xbox, MQTT Publish error: TypeError [ERR_INVALID_ARG_TYPE]: The "string" argument must be of type string or an instance of Buffer or ArrayBuffer. Received an instance of Object
[26/11/2022, 20:40:34] [XboxTv] Device: xbox.local Xbox, MQTT Publish error: TypeError [ERR_INVALID_ARG_TYPE]: The "string" argument must be of type string or an instance of Buffer or ArrayBuffer. Received an instance of Object
[26/11/2022, 20:43:16] [XboxTv] Device: xbox.local Xbox, get Power state successful: ON
[26/11/2022, 20:43:16] [XboxTv] Device: xbox.local Xbox, get Input successful, input: Xbox Guide, reference: Xbox.Guide_[redacted]!Xbox.Guide.Application, product Id: XboxGuide
[26/11/2022, 20:43:16] [XboxTv] Device: xbox.local Xbox, get Current Media state successful: STOP
[26/11/2022, 20:43:16] [XboxTv] Device: xbox.local Xbox, get Target Media state successful: STOP
[26/11/2022, 20:43:16] [XboxTv] Device: xbox.local Xbox, get Mute successful: ON
[26/11/2022, 20:43:16] [XboxTv] Device: xbox.local Xbox, get Volume successful: 0

I'm not entirely clear what could be causing this.

Just restarted homebridge...
[26/11/2022, 20:50:06] [XboxTv] Device: xbox.local Xbox, Connected.
[26/11/2022, 20:50:06] [XboxTv] -------- Xbox --------
[26/11/2022, 20:50:06] [XboxTv] Manufacturer: Microsoft
[26/11/2022, 20:50:06] [XboxTv] Model: Xbox Series X
[26/11/2022, 20:50:06] [XboxTv] Serialnr: [redacted]
[26/11/2022, 20:50:06] [XboxTv] Firmware: 10.0.25249
[26/11/2022, 20:50:06] [XboxTv] ----------------------------------
[26/11/2022, 20:50:06] [XboxTv] Device: xbox.local Xbox, MQTT Publish error: TypeError [ERR_INVALID_ARG_TYPE]: The "string" argument must be of type string or an instance of Buffer or ArrayBuffer. Received an instance of Object
[26/11/2022, 20:50:06] [XboxTv] Device: xbox.local Xbox, MQTT Publish error: TypeError [ERR_INVALID_ARG_TYPE]: The "string" argument must be of type string or an instance of Buffer or ArrayBuffer. Received an instance of Object

Restarted my MQTT broker and this is ok now, I think there was a message "stuck", possibly my own fault. Thanks.


AppGW Updates for network_appdelivery_checklist.en.json

@ppascan the commas are missing here to. I am not too sure about the AGIC recommendation, especially now that we have GA'ed App GW for Containers, that should be the default option.


New dashboard layout

Full image view is the same as sensor card now?

Full image view is the same as sensor card now?

yeah, no modifications on the sensor card view (full image view)

One spec that is missing I see is that where to forward user if he/she taps any of these areas (after custom background is set):

I think it should forward to the current sensor card view (full image view) for now just like it's doing on the old dashboard.

Do we have plans to modify sensor card? If so I suggest to specify changes now and implement changes to dashboard and sensor card at the same time because these two are connected.

no modifications on the sensor card view (full image view)

We agreed with S-M that sensor card will stay untouched for now.

Suggestion:
Add "Change Background" option under the 3 dots dropdown menu. It can be the lowest one under the settings&alerts.

@andreevdenis remember to add the placeholder text and link to Nearby Ruuvi sensors page to this view (same as in previous version) when no sensors are added yet

Some changes to "Image view" cards:

Cards' height can vary and image area stretch
Small measurements' color: #fff with 80% opacity

Let's add "Simple view"
Add "View" menu with dropdown

(These cards are designed with an additional setting on Sensor Settings where user can select "Sensor Priority", but let's design the default cards first with four default sensors.)

@sini-maaria There was a good point in our Telegram channel about showing Voltage in card. Maybe we shouldn't show it all the time but instead show some low battery icon when voltage is low.

There was a good point in our Telegram channel about showing Voltage in card. Maybe we shouldn't show it all the time but instead show some low battery icon when voltage is low.

Yes, battery voltage shouldn't be shown on the mobile by default. The layout examples had it just as an example. We are planning to make the cards more customisable later.

There are two things which will help the situation when we’d like to see as many sensors as possible at the same time.

Let’s hide the header when scrolling down. It should come back when user scrolls up.
Bottom menu could be transparent, same kind as on sensor page.

@andreevdenis can you please provide a link to
"Telegram channel about showing Voltage in card."

@DG12 https://t.me/ruuvicom/12592

@laurijamsa How does one add a new sensor with the new view selector at top right corner? Bring also the "+" icon to top row?

Let's forget the + icon for now. New sensors can be added from the menu.

Remove Battery here:

Use the same arrow as on the Settings page:

Align the dropdown menu with he cards and arrow icon with the 3-dots on the cards:

(Original design)

An other note: "4 s ago" and "Low battery" should be transparent, 50% #fff.

Add more space under the title. It seems too tight.

Alert icon could be tiny bit smaller. The smaller size should be updated to alert settings page as well.

Here:

About the transparent layer on top of dashboard images. They should be:

On dark theme: 75%
On light theme: 30%

Now they seem to be the same:

https://github.com/ruuvi/com.ruuvi.station/issues/906

QA passed


Add a cache defeating per version query string to the pdf.worker.js

Users whom have previously accessed the viewer can end up using a cached old worker implementation. Adding a query string forces them to guaranteedly always get the correct one.

I dropped testing against the combination of Ruby 2.3 and Rails 4.2 as that combination is troublesome and I could not figure out how to use conditionals for downgrading bundler for that build only.
Downgrading bundler breaks newer rubies.
I find the effort tradeoff reasonable.


Add missing enum associated value label in ReadMe

This updates the ReadMe to match the current state of the code.

Thanks for spotting this discrepancy!


ci: use Tui prefix for exported classes

PR Checklist
Please check if your PR fulfills the following requirements:

[x] The commit message follows Conventional Commits
[ ] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)

PR Type
What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Refactoring
[ ] Code style update
[x] Build or CI related changes
[ ] Documentation content changes

@waterplea @vladimirpotekhin @nsbarsukov hello, please review me later)


To Open Existing File in project

[ ]  Opening Of File previously formed readme file to re-edit !

Shall I work on this?

Go For it .

@hkaur008 pls assign me this issue.

@hkaur008 can you pls elaborate the issue?

One can open a readme file in doc or .md in left side !

One can open a readme file in doc or .md in left side !

okay!


2.0.36 breaks Codeception tests

What steps will reproduce the problem?
After install 2.0.36 update all our codeception tests became broken. Reason: https://github.com/yiisoft/yii2/pull/18127.
If I remove
elseif (is_array($dependency)) {
    $dependencies[$index] = $this->resolveDependencies($dependency, $reflection);
}

from \yii\di\Container::resolveDependencies, tests become OK.
First of all, it IS breaking change a-priory because of Container::resolveDependencies behaviour change.
Problem starts here: vendor/codeception/codeception/src/Codeception/Lib/Connector/Yii2.php:75. Connector use Yii::createObject (and therefore dependency container) for Application creation. We have application config like this:
return [
...
'container' => [
    'definitions' => [
        common\interfaces\NewsletterEmailGeneratorInterface::class => [
            ['class' => common\components\newsletter\NewsletterEmailGenerator::class],
            [
                di\Instance::of(web\View::class),
                di\Instance::of('internalFilesystem'),
]
...

Recursive resolveDependencies call try get 'internalFilesystem' component, but it's not configured in DI Container on this stage! We got:
[yii\base\InvalidConfigException] Failed to instantiate component or class "internalFilesystem".
Example of stack trace:
 Test  unit/commands/news/news_domain/NewsBorrowCommandTest.php:testInvalidData

  [yii\base\InvalidConfigException] Failed to instantiate component or class "internalFilesystem".

.../vendor/yiisoft/yii2/di/Container.php:449
.../vendor/yiisoft/yii2/di/Container.php:447
.../vendor/yiisoft/yii2/di/Container.php:374
.../vendor/yiisoft/yii2/di/Container.php:159
.../vendor/yiisoft/yii2/di/Container.php:484
.../vendor/yiisoft/yii2/di/Container.php:491
.../vendor/yiisoft/yii2/di/Container.php:491
.../vendor/yiisoft/yii2/di/Container.php:491
.../vendor/yiisoft/yii2/di/Container.php:491
.../vendor/yiisoft/yii2/di/Container.php:395
.../vendor/yiisoft/yii2/di/Container.php:159
.../vendor/yiisoft/yii2/BaseYii.php:365
.../vendor/codeception/codeception/src/Codeception/Lib/Connector/Yii2.php:75
.../vendor/codeception/codeception/src/Codeception/Lib/Connector/Yii2.php:53
.../vendor/codeception/codeception/src/Codeception/Module/Yii2.php:185
.../vendor/codeception/codeception/src/Codeception/Subscriber/Module.php:56

Q
A

Yii version
2.0.36

PHP version
7.4

it's not configured in DI Container on this stage!

Where/how is it configured?

Where/how is it configured?

Not sure, that understand question. When we create application in typical way ($application = new yii\web\Application($config);), container options from $config['container'] go to \yii\base\Application::setContainer(). But codeception creates application in another way:
/** @var \yii\web\Application $app */
$this->app = Yii::createObject($config);

See this part of stacktrace:
.../vendor/yiisoft/yii2/di/Container.php:395
.../vendor/yiisoft/yii2/di/Container.php:159
.../vendor/yiisoft/yii2/BaseYii.php:365
.../vendor/codeception/codeception/src/Codeception/Lib/Connector/Yii2.php:75

There is no configured application instance (and therefore no configured container) on line Container.php:395, but recursive dependency resolve starts.

I see. @SamMousa is it better to be adjusted in Codeception module or in the framework (not sure how yet)?

First of all:  #18127 seems to be bad regardless of this specific issue:

As @DmLapin noted it changes behavior, so it is a BC break
It introduces (possible) infinite recursion without checks

Then there is the Yii2 issue of attempting to have everything in the configuration array. Things like the logger, errorhandlers and possibly the container get populated from the application config, but they are not part of the application instance.
The application in the codeception module is recreated for every test, but the container is not. As @DmLapin correctly notes, the module uses the container to ask for an application object given a configuration array. If this array refers to objects that are not yet configured, because they are configured by the application at some later stage this will cause issues.
I see several options to remedy the situation:

Revert the change from #18127
Refactor the config so DI container config lives outside the application config, which from my point of view will improve the code structure regradless of other solutions
Have the Yii2 Codeception module parse the configuration array and treat some keys specially

I think 3 is the worst solution; the whole point of the module is to NOT know how the configuration format works, it is not relevant if we let Yii's own code figure that out. I believe 2 is a bad thing to ask from a user even if it (subjectively, in my view) improves their code; especially considering Yii2 should not be releasing BC breaking versions.
The option 1 is best in my opinion, since we have only had the feature for a very short while there will not be a lot of applications that are not under active development that use it. Apps under active development that use such a new feature will likely be able to step away from it.
Upon further inspection, I think the resolveDependencies call should also be more secure in things like forwarding the $reflection variable, since it makes no sense to use that for nested array dependencies..
In conclusion, I propose reverting #18127 and for these advanced cases just relying on a \Closure for configuration of the DI container. It is cleaner and more readable for all PHP users instead of using some secret array language understood only by Yii developers. The array config should be limited to simple cases in all other cases it imo more sensible to use a (static) closure.

@hiqsol what do you think about reverting it?

Additional thoughts about Codeception connector. If recursive resolveDependencies will be remained (now or in future), it will be not good way to create application object through Yii::createObject. It will try to resolve all dependencies at start but not on-demand. Performance of tests will degrade.

It won't, the dependencies need to be instantiated anyway, so delaying it is not an option.
Note that optional dependencies still are delayed (not all components are instantiated for example). So performance wise it is not an issue.

It won't, the dependencies need to be instantiated anyway, so delaying it is not an option.

If one test use only one application component, we shouldn't resolve all Instance objects on all levels of application config - it's waste of time. See example in my first post: NewsBorrowCommandTest don't use internalFilesystem and don't even use NewsletterEmailGeneratorInterface.

Sorry for long delay. I had no time.
I can't reproduce the issue. I'm trying to create a test for this issue.
Please see #18270 .
What needs to be added to reproduce the problem?

@DmLapin, @SamMousa would you please help with some additional info?

@SamMousa would it solve the issue to create application with new in Codeception module same way as it is done in framework bootstrap file itself?

Sure but that will break tests for other people. The issue with this is that it breaks BC and that simply means should revert it...

It would break for people who have subclassed the application object..

Added a test for it.


Screenshare is not working

Environment
SDK Version:  https://github.com/DolbyIO/comms-sdk-flutter/releases/tag/3.6.1
Client Platform: Flutter test app.
Description/Steps-to-reproduce:
Install the QA test app
Connect to the conference
Start screenshare (iOS or Android)
Expected result:
Users can see your screenshare
Actual result:
Users cannot see your screenshare
Devices:
DV-WRO-iOS66 iPhone XS Max + iOS16
Poco X3 NFC + Android 12
DV-WRO-IOS108 iPhone 13 Pro Max + iOS 15
DV-WRO-SAM91 Samsung S22 Snapdragon + Android 12

Fixed by @azduda


Feature/ceremony files

What is this PR for?

What is this PR for?

This is me trying to see the diff with the parent branch, and clicking the wrong thing and getting the diff with the entire master instead.


When for 1.2

When Online versión for 1.2?🥺

Last year
https://github.com/CraftyBoss/SuperMarioOdysseyOnline/tree/v1.2.0
However in general it is not good to ask open source developers when the next version will be out for a free project.


Confused with rayIntersectPlane

Hi,
Can you please tell me how rayIntersectPlane works? If possible explain with simple example?
https://developer.viromedia.com/virocore/reference/com/viro/core/Vector.html#rayIntersectPlane(com.viro.core.Vector, com.viro.core.Vector, com.viro.core.Vector, com.viro.core.Vector)
Thanks

Hi @geetves,
Here is a sample showing how that method works:
        Vector rayDirection = new Vector(0, 0, -1);
        Vector rayOrigin = new Vector(0, 0,0);
        Vector pointOnPlane = new Vector(0, 0, -5);
        Vector normalOfPlane = new Vector(0, 0, 1);

        Vector collidePoint = new Vector();
        if(rayDirection.rayIntersectPlane(pointOnPlane, normalOfPlane, rayOrigin, collidePoint)) {
            System.out.println("Point: " + collidePoint.x + "," + collidePoint.y + ", " + collidePoint.z);
       }

In the sample above, we create a new vector called rayDirection with a x,y,z of (0, 0, -1), this will serve as the direction of the ray used for finding an intersection with a plane. Then we define the origin of the ray at (0,0,0) and name that vector rayOrigin. So now are ray is defined with an origin of (0,0,0) pointing in the direction of (0,0,-1).
Next we define our plane to intersect with. A plane is defined by a point on that plane and the normal vector of the plane.  In this example the point on plane is(0,0, -5), defined in the vector named pointOnPlane and the normal is (0,0,1), defined in the vector named normalOfPlane. In this case the plane lies on the z axis at -5 and is pointing towards positive z.
Finally, the collidePoint vector is used pass information back.  We define an empty vector and only use this value if rayIntersectPlane returns true.
Now we invoke rayIntersectPlane on the vector that represents the direction of the ray, which is rayDirection.  In this example it will return true and print out the collide point which will be (0,0, -5). This is point on the plane that the ray collided with.
Let me know if this helps or if you need more info!

Thanks for the explanation.
Actually I am creating an application where 3d object is resting on arplane. Now I have attached drag listener to the 3d object. On drag event I want to find if object is still on the ar plane or not. Is it achievable using this method?

Hi @geetves,
You are correct in that this is a test of a plane of infinite dimension. What you can do is use rayIntersectTest first,  then if a collision occurred, check the collide point and use the getExtant() and getCenter() methods of ARPlaneAnchor to compute whether the collide point lies within the ARPlaneAnchor itself.
Those methods should give you the information you need to compute whether you are intersecting with the plane or not.
Here's some more info describing the math:
https://stackoverflow.com/questions/2752725/finding-whether-a-point-lies-inside-a-rectangle-or-not
Let me know if this helps. Thanks!

By rayIntersectTest, do you mean rayIntersectPlane? Or is this the method I dont know of?

Hi @geetves, sorry,  I mistyped, I meant rayIntersectPlane!

Yes, but OnDrag event of 3d object I don't have pointOnPlane.

Hi @geetves, based on your use case the point on plane would be the ARPlane not the 3dObject which has the onDrag event callback. In that case, the point on plane would simply be getCenter() of ARPlaneAnchor. Let me know if I'm misunderstanding or if this makes sense. Thanks!

Yes, you are correct. On OnDrag event of 3d object, I don't know on which ARPlane the object is anchored to. My issue is finding the ARPlane the 3d object is currently resting on. Now since I don't know the ARPlane of the 3dObject I cannot get poinOnPlane of that ARPlane to use in rayIntersectPlane method.
It would be cool if there is a method for hit testing taking only source point and direction in argument and returns all real-world features that are intersected by the ray.
performARHitTestWithPosition is one such method but its restriction is that its source point is only camera's current position.

Hi @geetves, I'll put this suggestion into our backlog. Curious, how are you placing your 3d object in the world? If you are adding the 3D object to an ARNode, you can store the ARPlaneAnchor that comes with it in the onAnchorFound callback of ARScene.Listener. This way you can reference it to see if the object is dragging off the plane it is anchored to.

I am using ARPlacingObjects example provided by virocore as a reference

Hi @geetves, just wanted to ask, is your goal above an attempt at dragging a 3D object that is locked within the boundaries of an ARPlane?


sap.m.SplitContainer (ShowHideMode) displays the detail pages as a default on devices which are in portrait mode

OpenUI5 version: 1.71.13
Browser/version (+device/version): 86.0.4240.198 (Official Build) (x86_64) (macOS Version 10.15.7 (Build 19H15))
URL (minimal example if possible): https://jsfiddle.net/nfae4w1y/2/
Steps to reproduce the problem:

Open URL
Open developer tools and choose iPad as device in landscape mode to have result page within jsfiddle in portrait mode
Refresh page

What is the expected result?
UI5 provides configuration to set if either "masterPages" or "detailsPages" are shown as default on tablet in portrait mode.
What happens instead?
Details pages are displayed as default (deep in UI5 coding...) without any possibility to change.
Any other information?

sap.m.SplitAppMode: sap.m.SplitAppMode.ShowHideMode
sap.ui.Device.orientation.portrait = true

On phone devices the "masterPages" are the default which is not really a consistent behaviour.

Hello @4lexBaum,
Thank you for sharing this finding. I've created an internal incident<PHONE_NUMBER>. The status of the issue will be updated here in GitHub.
Regards,
Patric

Hello @4lexBaum,
Thank you for your feedback!
If i understand correctly you want an API to enable when "master" or "details" pages are shown on Tablet in portrait mode?
This is how the sap.m.SlitContainer should act.
"SplitContainer maintains two NavContainers if running on tablet or desktop and one NavContainer - on phone. The display of the master NavContainer depends on the portrait/landscape mode of the device and the mode of SplitContainer."
It is taken from the documentation of the control.
Also if you use sap.m.SplitApp which extends the sap.m.SplitContainer, and use the orientationChange event and use the hideMaster method this can help you in controlling when the master is seen.
The details should be always visible.
On phone devices the "masterPages" are the default this decision was taken after a lot of user feedback.
Maybe the sap.m.SplitContainer is not the correct control for your use case, if you want  more flexibility
take a look at https://experience.sap.com/fiori-design-web/flexible-column-layout/#usage


code cleanup, check for missing dep in schema test

This PR cleans up some gross code around schema test parsing. Additionally, it adds a check for schema tests defined in packages which are not present in the context. This can happen if a dbt user forgets to run dbt deps, for example.
# models/schema.yml

test:
    constraints:
        dbt_utils.not_constant:
            - id

If run without a preceding dbt deps:
Before:
$ dbt test
Encountered an error:
'NoneType' object has no attribute 'get'

After:
$ dbt test
Encountered an error:
Compilation Error in test schema (models/schema.yml)
  Error while parsing "not_constant" test on model "test".
  The required package "dbt_utils" was not found. Is the package installed?

Fixes https://github.com/fishtown-analytics/dbt/issues/655

@cmcarthur will merge this when the tests pass


Reduce allocations in Get-Content cmdlet

PR Summary
Current implementation do huge extra allocations for every line of a file and at worst for every char (!). The fix exclude the extra allocations by moving initializations in a constructor and using Span for temporary buffer.
The search algorithm used is controversial (using Dictionary is definitely very slow for small search patterns) but not addressed by the PR.
You could review commit by commit.
PR Checklist

[x] PR has a meaningful title

Use the present tense and imperative mood when describing your changes

[x] Summarized changes
[x] Change is not breaking
[x] Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
[x] This PR is ready to merge and is not Work in Progress.

If the PR is work in progress, please add the prefix WIP: to the beginning of the title and remove the prefix when the PR is ready.

User-facing changes

[x] Not Applicable
OR
[ ] User-facing Documentation needed

[ ] Issue filed - Issue link:

Testing - New and feature

[x] Not Applicable or can only be tested interactively
OR
[ ] Make sure you've added a new test if existing tests do not effectively test the code changed

[ ] Add [feature] if the change is significant or affects feature tests

I agree that the offset Dictionary could be a perf issue for simple delimiter characters.

I don't found how quickly fix this. Will investigate (out of the PR).

Have you performed any tests to verify perf gains?

No. I accidentally discovered this by reading code. Once I realized that we allocate in heap for every char in a worst case and for every line I did not see the point to run PerfView.

@anmenaga  @SteveL-MSFT Have you any comments?

Get-Content is a frequently used cmdlet. I would like to see a green [feature] test run for this. Thanks.


Typescript typings

Hey,
It would be great to have typings for regl! I'm not experienced with using regl yet, but if nobody has started I can start making some as I use it more and more!

Yes!  I would also love to have this. If you want to add them to the main npm repo please send a PR or stop by the gitter.

Progress on this: https://github.com/stevebest/regl-typings

I've been working on this issue the past few days, using @stevebest's work as a starting point. Hope to finish and make a PR next week. Here's what I've got: https://github.com/davschne/regl/blob/typescript-declarations/regl.d.ts


fix translate

Job d2l-zh/PR-809/1 is complete.
Check the results at http://preview.d2l.ai/d2l-zh/PR-809/

ok get it


Selector hides all footer elements when printed

There's a CSS rule to hide the footer when printing, but it uses element selectors to determine what to hide:
https://github.com/alphagov/govuk_template/blob/master/source/assets/stylesheets/_core-print.scss#L76-L77
This assumes that all footer elements contain information that is not worth printing. That can't be guaranteed.
body footer {
  display: none !important;
}

Duplicate of https://github.com/alphagov/govuk_template/issues/64


Make SelectedText a property

I need to be able to set the selected text, like in the old Scintilla.
Here is my "rough draft" attempt at doing so:
 public unsafe string SelectedText
        {
            get
            {
                // NOTE: For some reason the length returned by this API includes the terminating NULL
                var length = DirectMessage(NativeMethods.SCI_GETSELTEXT).ToInt32() - 1;
                if (length <= 0)
                    return string.Empty;

                var bytes = new byte[length + 1];
                fixed (byte* bp = bytes)
                {
                    DirectMessage(NativeMethods.SCI_GETSELTEXT, IntPtr.Zero, new IntPtr(bp));
                    return Helpers.GetString(new IntPtr(bp), length, Encoding);
                }
            }
            set
            {
                DirectMessage(Constants.SCI_REPLACESEL, IntPtr. Zero,value);
            }
        }

I think what you would like to do is combine the SelectedText property and ReplaceSelection method.

Once again you have solved my issue! Thank you!
On Jul 2, 2015 9:54 AM, "jacobslusser"<EMAIL_ADDRESS>wrote:

I think what you would like to do is combine the SelectedText property
and ReplaceSelection method.
—
Reply to this email directly or view it on GitHub
https://github.com/jacobslusser/ScintillaNET/issues/53#issuecomment-118040464
.


Event not emitting on page load

On page load I connect to socket.io then emit some events.
For example, one of those events may grab a list of Vehicle Makes or Models.
About 75% of the time (it seems random) if I connect then do socket.emit('req-vehicles') the server never sees the event. However, if I setup a 2 second timeout before emitting any requests it will work everytime.
Any clue why this is? If any more info is needed let me know!
Thanks,
Cameron

I am also experiencing this issue.

Anyone find anything on this?

Can you post a code example which we can reproduce the issue?

Just something like:
var socket = io.connect();
$(document).ready(function(){
socket.emit('req-vehicles');
});
The server will never see the req-vehicles.
If I add a timeout of two second the server will see it. Its odd because this didn't used to happen. Not sure what it is. I didn't spend a ton of time debugging. The connection may not have been made yet?

What version of socket.io-client do you use? On recent versions of socket.io, messages emitted before connect event will be buffered and sent when the connection is actually established.

Is the socket connection async? Is there a callback?
I upgrade often. Every couple of months. I'm on 1.3.5 right now.

I tried to reproduce the issue, but it worked fine for me.
Connection happens async. You can listen connect event to know when the connection actually established.

On this particular app a LOT is going on right on load so that could be it.
Can you just do?
socket.on('connect', function() {
console.log('connected');
});
I'll close it if that is the case. I thought I looked for something like this a year or so ago and never found it.

yep, you can socket.on('connect', function(){}). Anyway it sounds a bug if there is data loss.
Please inform us if you could find how to reproduce this.

I'm probably just firing off events before its connected. Thanks.


fix: :bug: fix sidesheet header overflow:hidden

Description
Please include a summary of the change and which issue is fixed.
List any external dependencies that are required for this change.
Completes: AB#FILL_IN_YOUR_ISSUE_ID
Checklist:

[ ] I have performed a self-review of my own code.
[ ] I have linked my DevOps task using the AB# tag.
[ ] My code is easy to read, and comments are added where needed.
[ ] My code is covered by tests.

Remember to check if this affects any other app, seeing as you changed styling for all sidesheets

Everything work as expected in other apps


[suggestion] localbranch pull suggestion

hello
I have a very confusing problem. Every time I pull from a local branch, the wrong remote branch is pulled down. In the pull window, the remote branch is the default even if the remote branch is not tracked.
[suggestion] If the local branch does not track the remote branch, the default remote branch to be pulled is recommended to be changed to empty. thank you!

It is recommended to refer to sourcetree

Since user can Ctrl+Mouse Cllick to run pull quickly with default parameters, the remote branch is required. Currently, if local branch does not track any remote branch, the first remote will be selected, and try to select a branch with the same name or just the first one.
The auto-select feature is added also because some people's feature request. See issue #342.

BTW, at this point, this project has the same behavior with another well-known GIT client, Fork.

What I don't understand is why a local branch that doesn't track any remote branch needs to have a default remote branch to pull.
In the case of Ctrl+Mouse shortcut operation, you can just check whether there is a tracking remote branch. If there is, you can pull it. Otherwise, you are required to select it manually. Is this better? #342 issue seems does not conflict with this issue

What I don't understand is why a local branch that doesn't track any remote branch needs to have a default remote branch to pull. In the case of Ctrl+Mouse shortcut operation, you can just check whether there is a tracking remote branch. If there is, you can pull it. Otherwise, you are required to select it manually. Is this better? #342 issue seems does not conflict with this issue

Yes, you are right. Currently, I've done this job and I'm doing some testing with the modification.

The new remote branch auto-selection algorithm will be changed to:

If local branch tracks some branch in selected remote, just select it.
If local branch tracks no branch in selected remote, but a branch with same name exists in the selected remote, select it.
Otherwise, leave the selected branch to empty

The new remote branch auto-selection algorithm will be changed to:

If local branch tracks some branch in selected remote, just select it.
If local branch tracks no branch in selected remote, but a branch with same name exists in the selected remote, select it.
Otherwise, leave the selected branch to empty

That's great. Thank you!

You can test the latest build from https://github.com/sourcegit-scm/sourcegit/actions/runs/10846657299

I just test it. No problem ! Thank you !


Make sortable heading in 'Properties' by name

Is your feature request related to a problem? Please describe.
As of now, There is no sortable option in 'Datasets' > .... > 'Properties' by property's name.
It would be nice to have a sortable heading to 'Name'
Describe the solution you'd like
Add a sortable heading to 'Name'. i.e., ascending or descending toggle on 'Name'

Hi folks!
We are now managing feature requests through our new portal to improve visibility & prioritize work into our public roadmap. If this request is still relevant, please create a new issue so we can gauge current interest from the Community & prioritize work accordingly.
We'll close out this issue in the meantime. Feel free to reach out to me on DataHub Slack with any questions!


fix: lyric setting not saved

style: make heart more consistent
🆙  deps

could you post a copy of prettier config? I found pr ususally include reformat.

That's because I‘m used to use ctrl+alt+f. The format uses the prettier config in the repo which somehow conflicts with the format eslint generates. I've add a prettier config to eslint and a pre commit hook so that every code is formatted when pushed.

update:
It seems that the config I use for .vue files are actually volar included formatter which also reads .prettierrc but acts a little bit differently. oops!

update: It seems that the config I use for .vue files are actually volar included formatter which also reads .prettierrc but acts a little bit differently. oops!

that's right, let's do some research and figure out how to make it consistent.
Check script in github action will be added in the frture, so I think it's better to config volar to follow prettier config instead to    use its own config which is hard to run check in github action env.


Bower packages in gulpfile

Hi there.
I have added a solution, which allows to pass array of Bower packages in gulpfile.

[Current coverage][cc-pull] is 96.96%

Merging [#56][cc-pull] into [master][cc-base-branch] will increase coverage by 0.03%

@@             master        #56   diff @@
==========================================
  Files             1          1
  Lines            98         99     +1
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
+ Hits             95         96     +1
  Misses            3          3
  Partials          0          0

Powered by Codecov. Last updated by [02704fd...b6da56f][cc-compare]
[cc-base-branch]: https://codecov.io/gh/zont/gulp-bower/branch/master?src=pr
[cc-compare]: https://codecov.io/gh/zont/gulp-bower/compare/02704fdd2fdd9246edac22dd6c2ea00f746c7ca1...b6da56f195f06c499141b2ceacdba17f84417abb?src=pr
[cc-pull]: https://codecov.io/gh/zont/gulp-bower/pull/56?src=pr

Why you do not specify the dependencies advance in the bower.json?

I think that point dependency in the build file is a bad practice.


Adding  support of INNER JOIN

This is a  feature request.
I'm finalizing supporting ql in the ORM I'm hacking on. While fixing Many to many relation I am supposed to use INNER JOIN. I Have found OUTER JOIN is already supported so Maybe INNER JOIN will be possible as well.
Thanks

It is like I have the following schema
BEGIN TRANSACTION;
    CREATE TABLE blogs (id int64,locale string,subject string,body string ) ;
    CREATE TABLE tags (id int64,locale string,value string ) ;
    CREATE TABLE blogs_tags (tag_id int64,tag_locale string,blog_id int64,blog_locale string ) ;
COMMIT;

And I would like to run the following query
SELECT count(*)
FROM   tags
       INNER JOIN blog_tags
               ON blog_tags.tag_id = tags.id
                  AND blog_tags.tag_locale = tags.locale
WHERE  ( ( blog_tags.blog_id, blog_tags.blog_locale ) IN (( $1, $2 )) )

@gernest IIRC correctly, INNER JOIN is the same as CROSS JOIN. IOW, your query should be equal to something like (not tested)
SELECT count(*)
FROM   tags , blog_tags
WHERE blog_tags.tag_id = tags.id
        AND blog_tags.tag_locale = tags.locale
        AND (( blog_tags.blog_id, blog_tags.blog_locale ) IN ( $1, $2 ));

Can you please test it?

@cznic I copied the query verbatin
I get this error
unexpected ',', expected logical or operator or one of [')', OR, ||]

For some reason I noticed the issue is with this part of the query. QL seeems to fail compiling it/parse it I suppose.
        AND (( blog_tags.blog_id, blog_tags.blog_locale ) IN ( $1, $2 ));

After I  changed it not use IN it worked
        AND blog_tags.blog_id - $1
        AND  blog_tags.blog_locale = $2

Thanks,


⚠ Site ANTS has degraded performance

In 82bc868, Site ANTS (https://ants.gouv.fr) experienced degraded performance:

HTTP code: 200
Response time: 3214 ms

Resolved: Site ANTS performance has improved in 8c4d904.


New Eyre - New Hope

Since Plato v0.3.0 will require router and possible other functionality to make it work, after Plato v0.2.0 I decided to temporarily freeze its development and shift focus to eyre itself.
A long time ago I proposed UP3, which I will finally get to. After implementing UP3, I would like to eye re-designing eyre itself. With new %ford coming up, it is certainly something beneficial, as it would even more speed up the public face of Urbit.
New Eyre should provide at least the following:

Significantly speeding up requests, if possible. Request to google server several hundreds miles
away take around milisecond. Plato request to eyre sitting just here take 500x time longer to complete. I am not sure where latency comes from, but it seems unlikely that from the plato code execution itself, which in dojo is almost instaneous.
Redesign of the eyre APIs - with the focus on uniformity, predictability, eliminating reduntant API endpoints and so on.
Passing of Marks - With alpha of elm-urbit released, marks should be passed from eyre with preserving their data type, and then seamlessly reconstructed using elm-urbit. We should probably provide stock mark decoders in elm-urbit for all stock marks convertible to JSON.
Routing capabilities for SPAs
Some other areas which I am not aware of (...)

This probably should be best developed against the cc-branch - if it is possible at this stage.
It will take at least solid couple of months to have anything, so we should treat this with a longer time-horizon.
I will definitely require assistance and coordination from @ohAitch, which I believe, originally implemented %eyre? :-)

Not originally, but rewrote the current implementation ground up yeah!
To address your points:

Significantly speeding up requests, if possible. Request to google server several hundreds miles
away take around milisecond. Plato request to eyre sitting just here take 500x time longer to complete. I am not sure where latency comes from, but it seems unlikely that from the plato code execution itself, which in dojo is almost instaneous.

A good first step might be turning on -DGHETTO in the Makefile(mesonfile?), |verb, and looking at the timing information for how long each arvo-level event is taking. My bet it most of it is in ford, but this may be pride talking, I've only rewritten like half of that :)

Redesign of the eyre APIs - with the focus on uniformity, predictability, eliminating reduntant API endpoints and so on.

You might want to look at the https://github.com/ohAitch/arvo/tree/cleaner-http branch, which among other things refactors the uniform two-letter /~/xx/... URL names to instead be descriptive – I'm really surprised you cited those as user-friendly in #700, actually. The main feature disabled on that branch is single-sign-on, which I think will not be necessary in MVE; but also feel free to treat that branch as ~inspirational~ and pick and choose whichever refactorings still look useful :P

Passing of Marks - With alpha of elm-urbit released, marks should be passed from eyre with preserving their data type, and then seamlessly reconstructed using elm-urbit. We should probably provide stock mark decoders in elm-urbit for all stock marks convertible to JSON.

Not sure what precisely you mean by "mark decoders", given they're already in JSON; is there a standard convention for annotating JSON with Elm types, using a @@type@@ key or such? A more ambitious plan might be writing an elm implementation of the mold system, and passing the mark data as ++jam or at least untyped noun-json; but I'm not sure how much of an undertaking that would be, and whether auto-generating elm based on sur/ files even makes sense.

Routing capabilities for SPAs

I think cleaner-eyre involved a foo.urbit.org/:talk/path/passed/to/javascript url format, but maybe that part never got implemented. It's also possible that there was more extensive routing involving talking to the app during the first HTTP request: I certainly remember that when gall v1 was written a few years ago, there was just a ++page app interface arm that you could generate arbitrary html from by path.

Some other areas which I am not aware of (...)

I'm not on my work computer right now, but I'll look around for any other areas I am: I remember writing up extensive wishlists for various parts of urbit, and might even be able to find some of them. Have you looked through the %eyre issue tag for anything UI-related?

@ohAitch
By passing marks at the very minimum I mean tagging passed JSON properly.
Currently, everything that comes out of eyre is tagged with json mark.
This is very bad for elm<->urbit bridge, because it essentially means your mark codecs inside Elm have to camp on a particular /wire, and bind proper decoders per wire. With mark tagging, Elm mark codecs will dispatch based on mark field.
Autogenerating elm decoders from sur/ is actually a very good idea, but I am not sure if I follow. Given sur/ hoon file, there is an easy way to turn given mold into elm structure decoder - unsure what passing mark data as jam would mean? Is it binary encoding of the nouns?

It would not be difficult to add a "_mark":foo in every mar/foo++grow++json, certainly :P
++jam is the native binary encoding yeah. It doesn't have all the json name/atom-type/human-readability overhead, which sur-derived Elm could just rehydrate using the mold algorithms.

@ohAitch we should hop on skype some day to talk about the state of %eyre;
We finally need to get it done, since I would like to release the elm-urbit library, for which we will need
to at least build in the routing...

Closing this one as %lighter-than-eyre is the new hope for the time being.


docs: Add a list of contributors to docs/about.md

We should add a list of core contributors to docs/about.md to help steer folks to people who can answer their questions, review their PRs, etc.

@showell I imagine this would include the experts on all the Zulip repositories, e.g., the React Native app, major integrations, etc. -- your thoughts?

Yeah, I think that would make sense.  I filed this PR about five weeks ago, and I think it still makes sense, but with the recent Outreachy influx, I'd be curious to know how they found the process of figuring out who to ask questions, etc.

@showell I started working on this today in the course of the multilayered project of increasing review-and-merge velocity, and roughed out a partial list (only for the web app, not really for any of the other codebases):

Brock - frontend, JS, css, images, emoji
Umair (umairwaheed) - Casper & frontend tests, backend (Tornado), virtualenvs, auth, handlebars, i18n, templates
Neeraj Wahi (neerajwahi) - React Native, JavaScript
Vishnu Ks (hackerkid) - JS, backend (realm creation)
Taranjeet (TroJan): backend, provisioning
umkay - auth, dependencies, backend test, Tornado
Steve Howell (showell) - backend, databases, tests, tooling, provisioning, some frontend
Tim Abbott (tabbott) -- all-around
Christie Koehler (christi3k) - provisioning and docs
Sumana Harihareswara (brainwane) -- docs

Is this the kind of thing you were envisioning?

Yeah, makes sense.  You may want to remove "provisioning" from my list.

As an element in how we address this, I think http://limetext.org/contribute.html is a pretty cool way to show all the contributors to an open source project.  Also since they're open source we may be able to borrow the code...

Indeed, the code is pretty simple an open source here: https://github.com/limetext/limetext.github.io/blob/master/contribute.html#L69

@timabbott Team page exists now; can this be closed?

Sorta.  I think we should probably close this and open a new issue about "having a list of subsystem experts/maintainers", since that was sorta tangled in with the issue description here.

I think probably we should have just closed this; I don't think we're going to generate a list like this because of this stale issue :)


Feature request: realtime table bouncing

Whenever I upgrade the schema of a table, I need to wait up to 1hour to wait for current segment to be persisted then next realtime segment will pick up the new schema. If I want this change to take immediately then I need to bounce all the realtime servers, which is not desired behavior since I'm running many tables on the same server.
For implementation, we can persist current in_progress segment then new created segment will just catch up with new schema.

+1 for the feature. Are there any other alternatives other than forcing current segment to be flushed?

+1 for the feature. It seems low cost to force the current segment to be
flushed. This would be an issue only if we upgrade the schema often, which
is not usual.
On Fri, Jun 3, 2016 at 11:51 PM, Kishore Gopalakrishna <
<EMAIL_ADDRESS>wrote:

+1 for the feature. Are there any other alternatives other than forcing
current segment to be flushed?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/linkedin/pinot/issues/151#issuecomment-223740505, or mute
the thread
https://github.com/notifications/unsubscribe/AIUJl97b027zfzPjy0-ppy5L8AljAYilks5qISB6gaJpZM4IuEOs
.

The other alternative I can think of is to drop current in_progress segment then restart it.
For this, we need to reinit kafka consumer to make sure we are consuming from the offsets that previous segment committed.

Wouldn't dropping the current segment cause queries to give inconsistent
results during the time that the realtime segment catches up? What is the
benefit in dropping the segment over just moving to a new segment? Aren't
previous segments still with the old schema?
On Sat, Jun 4, 2016 at 12:06 AM, Xiang Fu<EMAIL_ADDRESS>wrote:

The other alternative I can think of is to drop current in_progress
segment then restart it.
For this, we need to reinit kafka consumer to make sure we are consuming
from the offsets that previous segment committed.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/linkedin/pinot/issues/151#issuecomment-223740975, or mute
the thread
https://github.com/notifications/unsubscribe/AIUJl1gTfYtjxkZ1rM4EY9HWtkBiyDSwks5qISPugaJpZM4IuEOs
.

+1 to what jfim said. We need to make sure this works with new design as well.

@mcvsubbu Thanks for your inputs!
In our environment, around 2/3 of our production tables are REALTIME, and we are seeing more and more requests to evolve schemas, especially with our recent efforts to onboard customers in a self-serve mode.
Our flush thresholds are 5 hours by default, by which time the new schema should be picked up. But the problem is when to reload segments. If we reload segments right after the schema change (call reload endpoint in the onboarding portal when the user bumps the kafka schema version), the consuming segments would keep consuming and seal with the old schema. This results in schema mismatch at query time, causing this segment to be dropped, since this would be the only segment with the old schema - old segment are reloaded with the new schema, and new segments would pick up the new schema as well. Reloading segments X hours after the schema change could solve the issue, but it adds operational overhead.
So, if we can force flush the consuming segments upon schema change, once the new segments start consuming with the new schema, we can call reload endpoint on all old segments, which would both solve the schema mismatch issue, and allow consumption with the new schema right away.
If you anticipate issues with force flushing segments across partitions, we can manage customers' expectations on the time to pick up the new schema, and only address the schema mismatch issue, like upon completion of the consuming segment, fetch the latest schema and add the new column(s) to the mutable segment?


The DH is fixed to the code ?

I see you fixed code the DH Parameters ? Should it be auto generated ?

Yes, it is hardcoded. Not a problem.
Search for previous discussion about this in this issue tracker, if you need further explanation.


Reuse & expose events

We stumbled upon a need to react on the same events wouter's useLocation, but outside of a hook & react itself.
For example, to clean up certain state from all components on history's state changes, but not notifying them about it.

basically a case similar to useRef, but outside of react

This PR should decrease the bundle a tiny bit (or probably leave it the same, due to additional export) for an already tiny library :D
And let users to reuse some of the events, keeping wouter as a source of truth.

For example, to clean up certain state from all components on history's state changes, but not notifying them about it

Can you provide a more specific example? Just curious what the use case might be, maybe it can be solved by just using an API provided by wouter.

Codecov Report

Merging #129 into master will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #129      +/-   ##
==========================================
+ Coverage   99.48%   99.50%   +0.01%
==========================================
  Files           7        7
  Lines         196      200       +4
  Branches       35       35
==========================================
+ Hits          195      199       +4
  Misses          1        1

Impacted Files
Coverage Δ

use-location.js
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 142c969...663581c. Read the comment docs.

I believe requested changes are made. Please re-review when convenient.
About size-limit, unfortunately I am not familiar with using that library.
After brief familiarization with it, I see they support custom bundling configurations.
IMHO, if you would like to get the true size of the library in production of use-location.js file, then you should consider to set a custom rollup + terser configuration, so that way we could see the weight of it after minifaction.
As of now, the size increased a bit due to:

naming affecting the size
exporting a new variable

+2 bytes for the whole bundle
+18 bytes for use-location
but in reality, the size shouldn't increase due to mangling & other processing by terser

Release in v2.5.2 https://github.com/molefrog/wouter/releases/tag/v2.5.2


How should i use "onAll" at root store when i use namespaced state?

Hey @zonghow! You're almost there
export interface State {
  app: AppState
}

export type StoreEffects = EffectsAs<State>

export const effects: StoreEffects = (s) => {
  appEffects(s)
  withReduxDevtools(s.app)
  return s
}

If you want, you could update withReduxDevtools to accept either a store or a namespaced store -- PRs are welcome!

If like this.
withReduxDevtools(s.app)

When s.otherStore changed, redux devtool can not capture this change.
It doesn't work even add this:
withReduxDevtools(s.otherStore)

That’s surprising - do you think you could post a self contained repro case (eg. On stackblitz)? That sounds like a bug.

That’s surprising - do you think you could post a self contained repro case (eg. On stackblitz)? That sounds like a bug.

https://stackblitz.com/edit/undux-quick-start-typescript-8bstzx

@zonghow This works fine for me locally. Did you:

Enable Redux devtools extension

Give it access to file URLs

Choose Autoselect instances in Redux Devtools


Compiling the executable file from the source code

Hello,
Being relatevely new to your product, I spoke to an engineer of the technical team which informed me about this API to adapt the CLARIUS acquisition for research purposes. My institution has a Microsoft Visual Studio IDE subscription and I was thinking I could use it to build the executable from the source code. However I read in previous issues that the project is compilable through QT creator which as far as I understood is a licensed IDE that require an additional subscription with the possibility to use an open source suite.
Is the latter enough to build the solution or do I need the full QT IDE ?

UPDATE: I manged to download and install QT creator however when i load the project and build it there are some missing files.
Specifically the error I get from the compiler is:
LINK : fatal error LNK1104: impossibile aprire il file 'cast.lib'
jom: C:\Users\REHE-Lab2\Downloads\cast-master\src\example\build-caster-Desktop_x86_windows_msvc2019_pe_64bit-Debug\Makefile.Debug [debug\caster_qt.exe] Error 1104

note you cannot use the MinGW compiler, we only distribute binaries built with MSVC


The problem of offset

def  get_center_and_offset_bev(self, lrtlist_cam, seg_bev):
......
......
offset     = torch.stack([offset[:,0], offset[:,2]], dim=1)
min_offset = torch.min(offset, dim=3)[0]
max_offset = torch.max(offset, dim=3)[0]
offset     = min_offset + max_offset
The meaning expressed by the sum of min_offset and max_offset？
What is the role of MIN_offset and max_offset？

This is a shortcut to obtaining the nonzero values along the Y dimension, to get a BEV offset map. There are zeros above and below the car regions, and inside the car regions we have vectors with positive and negative numbers. With these lines we eliminate the Y dimension while retaining the right values within the car regions.


Fix/itocloud 331 rds mysql db version update

Please review my PR.

This PR is included in version 1.33.1 :tada:


Error no file named pytorch_model.bin, model.safetensors, tf_model.h5, model.ckpt.index or flax_model.msgpack found in directory E:\ComfyUI\models\LLM\Florence-2-base-PromptGen-v2.0.

Regardless of whether you clone the repo or install it using the Manager node in Comfyui, it doesn't pull down this file (or this one) and it's breaking the node.
Please either add the file into the repo or tell people they need to get it from the Florence PromptGen 2.0 repo.

What file do I need to download manually? Could you explain it more clearly?


[AutoPR containerregistry/resource-manager] Xiadu/msi

Created to sync https://github.com/Azure/azure-rest-api-specs/pull/4220

(message created by the CI based on PR content)

This PR has been merged into https://github.com/Azure/azure-sdk-for-python/pull/3467


LogoProposal For mkcert

Hello I am a graphic designer and I like to make contributions in open source projects, even if you do not have the logo for your project, I would be excited to create one for you, if you allow it?

Hey, I'd love a logo. I happened to ask for one on Twitter shortly before this issue: https://twitter.com/FiloSottile/status/1015099706844774401 :)

So if I can create a logo for you or I reserve the task? or just want you to design the pegantina with the same information as design @lgarron


Feature Request: Sub-fields in collections

I'd love to have some way to have a group of fields be part of a parent field, as shown below.
{
  // default fields
  "created": "",
  "modified": "",
  "id": "",

  // sub-field
  "something_new": {
    "sub_field_a": "",
    "sub_field_b": ""
  }
}

This would help with organisation and naming of fields.
I know I can just do a JSON type field, but then I don't get the form inputs in the admin UI, and I don't get the schema validation and relation features.

For what it's worth, you could listen to the records event hook with the new JS extension and modify the response before it is sent. This would end up being quite gnarly to maintain as you would have to detect the record property per collection and group them accordingly in a huge switch statement.
https://pocketbase.io/docs/js-event-hooks/#onrecordviewrequest

I feel that this can be implemented using the exesting JSON fields if we have a JSON Schema as mentioned here : #1154


Feature/add reposync dev script

Added a reposync dev script that take two parameters, a repo config file (a yum repo file) and a save location.

boy squash your commits

Ah, sorry, did that one on my phone, the UI is different.


Add some quick information about what it's actually doing

I just quickly stumbled upon this repository and couldn't find much information about what it's actually doing to make the variables available in the JS. It is something I would want to know before using such a library and I guess having this information in the README would be useful instead of going through the code.

Sure! This information is in usage section: https://github.com/gazay/gon#usage

My bad, I went too quickly. Thanks!

No problem =)

Ah sorry, I went to quickly in issue, so I misunderstood you. Do you mean I need to provide information about internal gon flow, how it stores data from action and then renders it in view? But I thought it is pretty clear – it just stores data for current request inside Gon RequestStore, then when view calls include_gon – it takes it from there and converts to json and add script tag with it.

Yes, this I what I meant. It is indeed quite clear it should be doing what you just described once you read the usage section correctly, but the I believe the short description you just gave could be worthy of being included somewhere.


Runtime is not matching as mentioned in the paper

Hello,
Firstly, I want to express my appreciation for your excellent work and the valuable contribution you've made to the field.
I recently had the opportunity to implement your method and evaluate its performance on the Kitti2015 dataset using the evaluate.py script. However, I noticed a discrepancy in the runtime compared to the values reported in your paper. While your paper indicates a runtime of 0.18s, my evaluation on an NVIDIA RTX 3090 GPU card yielded a runtime of 0.29s.
Any additional information or parameters that might influence the runtime would be immensely helpful.
Thank you very much for your time, and I appreciate any assistance you can provide. I look forward to hearing from you soon.

Thanks for your attention. The runtime is tested using 16 iterations. I mentioned the measurement of runtime in my paper.

On KITTI 15 benckmark, the results (D1-all: 1.59) of 16 iters and 32 iters are consistent. So we use the result of 16 iters.

Thank you for the quick reply. I was able to reproduce the same runtime after revisiting the implementation.


chore: update cached_pair_addresses

Fixes #10
Checklist

[x] My branch is up-to-date with upstream/develop branch.
[x] Everything works and tested for Python 3.8.0 and above.
[x] I ran pre-commit checks against my changes.
[x] I've written tests against my changes and all the current present tests are passing.

Change logs
Update cached_pair_addresses.json to use latest uniswap v2 pair addresses

Not relevant anymore, closing.


Write tests

I was taking a look at the repo and noticed you have a file called tests that doesn't have tests yet! Do you want some help writing them? I would be happy to help! Thanks!

I would love to have it Gui :)
On Sat, Oct 3, 2020 at 9:43 AM Guilherme Lucas<EMAIL_ADDRESS>wrote:

I was taking a look at the repo and noticed you have a file called tests
that doesn't have tests yet! Do you want some help writing them? I would be
happy to help! Thanks!
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/scopeta/focusedme/issues/7, or unsubscribe
https://github.com/notifications/unsubscribe-auth/AC2C3SBCONLGK6TN5DEQHV3SI5IBNANCNFSM4SDDYCSA
.

Closing this due to PR already merged!


Temporary remove debian 9 which is Flaky

What does this PR do?
Remove debian 9 which is flaky for now. Investigation in progress to fix it

Motivation
Avoid flakiness

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

Reviewer's Checklist

[ ] If known, an appropriate milestone has been selected; otherwise the Triage milestone is set.
[ ] Use the major_change label if your change either has a major impact on the code base, is impacting multiple teams or is changing important well-established internals of the Agent. This label will be use during QA to make sure each team pay extra attention to the changed behavior. For any customer facing change use a releasenote.
[ ] A release note has been added or the changelog/no-changelog label has been applied.
[ ] Changed code has automated tests for its functionality.
[ ] Adequate QA/testing plan information is provided if the qa/skip-qa label is not applied.
[ ] At least one team/.. label has been applied, indicating the team(s) that should QA this change.
[ ] If applicable, docs team has been notified or an issue has been opened on the documentation repo.
[ ] If applicable, the need-change/operator and need-change/helm labels have been applied.
[ ] If applicable, the k8s/<min-version> label, indicating the lowest Kubernetes version compatible with this feature.
[ ] If applicable, the config template has been updated.

/merge

/merge


web-ui: when running docker:build, build compiled assets first

Just a minor change to the docker:build task

@fmueller can you check this one?

👍


MissingPluginException(No implementation found for method Query#addSnapshotListener on channel plugins.flutter.io/cloud_firestore)

Hey guys, just trying to get the Firebase Flutter basic application up and running, but hitting this MissingPluginException all over the place. This seems to have occurred after I did a flutter upgrade. I have another computer in which I did not do a flutter upgrade in which I was able to get the flutter-firebase sample to work.
Logs
5.4.1 - [Firebase/Analytics][I-ACS023007] Firebase Analytics v.50001000 started
5.4.1 - [Firebase/Analytics][I-ACS023008] To enable debug logging set the following application argument: -FIRAnalyticsDebugEnabled (see http://goo.gl/RfcP7r)
[1.1 AFBC0916-DE63-43C4-9C55-F73294FFC810 2604:5500:c1a7:3000:a0cc:bf72:780a:1941.49758<->2607:f8b0:4005:802::200a.443]
Connected Path: satisfied (Path is satisfied), interface: en0
Duration: 2.608s, DNS @0.003s took 0.010s, TCP @0.017s took 0.008s, TLS took 1.319s
bytes in/out: 3879/4075, packets in/out: 13/18, rtt: 0.007s, retransmitted packets: 8, out-of-order packets: 0
[2.1 F434C211-2D8E-42BB-A96C-0801F0CC12A2 2604:5500:c1a7:3000:a0cc:bf72:780a:1941.49760<->2607:f8b0:4005:804::200e.443]
Connected Path: satisfied (Path is satisfied), interface: en0
Duration: 4.071s, DNS @0.001s took 0.001s, TCP @0.004s took 0.968s, TLS took 2.793s
bytes in/out: 3642/832, packets in/out: 9/9, rtt: 0.795s, retransmitted packets: 0, out-of-order packets: 0
[3.1 9672580A-9B67-4BC2-B059-8DAD984169A2 2604:5500:c1a7:3000:a0cc:bf72:780a:1941.49764<->2607:f8b0:4005:804::200e.443]
Connected Path: satisfied (Path is satisfied), interface: en0
Duration: 0.087s, DNS @0.000s took 0.002s, TCP @0.003s took 0.007s, TLS took 0.046s
bytes in/out: 3589/1371, packets in/out: 9/10, rtt: 0.006s, retransmitted packets: 0, out-of-order packets: 0
Application finished.

Flutter Upgrade
Flutter 0.5.8-pre.277 • channel master • https://github.com/flutter/flutter.git
Framework • revision e5432a2843 (15 hours ago) • 2018-08-08 16:45:08 -0700
Engine • revision<PHONE_NUMBER>
Tools • Dart 2.0.0-dev.69.5.flutter-eab492385c

Running "flutter packages upgrade" in storymachine...        5.7s

Running flutter doctor...
Doctor summary (to see all details, run flutter doctor -v):
[✓] Flutter (Channel master, v0.5.8-pre.277, on Mac OS X 10.13.5 17F77, locale en-US)
[!] Android toolchain - develop for Android devices (Android SDK 28.0.0)
    ! Some Android licenses not accepted.  To resolve this, run: flutter doctor --android-licenses
[✓] iOS toolchain - develop for iOS devices (Xcode 9.4.1)
[✓] Android Studio (version 3.1)
[!] IntelliJ IDEA Community Edition (version 2018.2)
    ✗ Flutter plugin not installed; this adds Flutter specific functionality.
    ✗ Dart plugin not installed; this adds Dart specific functionality.
[✓] VS Code (version 1.25.1)
[✓] Connected devices (1 available)

Oh dang, I think I know what I did, because I replaced the AppDelegate code with the Firebase recommended header, I forgot to include
[GeneratedPluginRegistrant registerWithRegistry:self];

I also have MissingPluginExceptions everywhere. What does you AppDelegate.m look like. Are you saying the recommended AppDelegate.m file doesnt work


Shortcut for Open to the side from Quick Open not working

Does this issue occur when all extensions are disabled?: Yes

VS Code Version: 1.73.0 (Universal)
OS Version: 13.0

Steps to Reproduce:

Quick open (cmd+p)
Select file
Press ctrl+enter

The UI button for Open to the side from quick open works.
The shortcut also works for file selection in the explorer
My settings:
  {
    "key": "ctrl+enter",
    "command": "explorer.openToSide",
    "when": "explorerViewletFocus && explorerViewletVisible && !inputFocus"
  },
  {
    "key": "ctrl+enter",
    "command": "-explorer.openToSide",
    "when": "explorerViewletFocus && explorerViewletVisible && !inputFocus"
  },
  {
    "key": "ctrl+enter",
    "command": "search.action.openResultToSide",
    "when": "fileMatchOrMatchFocus && searchViewletVisible"
  },
  {
    "key": "ctrl+enter",
    "command": "-search.action.openResultToSide",
    "when": "fileMatchOrMatchFocus && searchViewletVisible"
  },
  {
    "key": "ctrl+enter",
    "command": "-interactive.execute",
    "when": "resourceScheme == 'vscode-interactive'"
  },
  {
    "key": "ctrl+enter",
    "command": "search.action.openNewEditorToSide"
  },
  {
    "key": "ctrl+enter",
    "command": "editor.action.openDeclarationToTheSide"
  }

Related to https://github.com/microsoft/vscode/issues/43059

Thanks for creating this issue! It looks like you may be using an old version of VS Code, the latest stable release is 1.73.0. Please try upgrading to the latest version and checking whether this issue remains.
Happy Coding!

Setting aside your Ctrl+Enter issue, did you know that Ctrl+RightArrow will already do what you want? It intentionally leaves the quickpick open so you can open another of the matches, but it's easy enough to close by pressing Esc.

@elchead ctrl+enter appears to be working for me even with your settings. What is it doing for you?

This issue has been closed automatically because it needs more information and has not had recent activity. See also our issue reporting guidelines.
Happy Coding!

sorry for the late reply.
@TylerLeonhardt ctrl+enter has the same effect as enter for me, it opens the file in the current tab.
@gjsjohnmurray this also opens the file in the current tab for me, leaving quickopen open

if you remove these keybinding settings, does anything change?
I'd also love to see what settings you have in your user settings to see if maybe something is up there.

Thanks for reaching back. I commented all keyboard shortcuts and disabled all extensions. Indeed I got it to work when I commented all config of settings.json.
Then I got it to pinpoint it to this setting:
"workbench.editor.enablePreviewFromQuickOpen": true,
which apparently needs to be false.
Thanks for your help!

That's interesting. @bpasero is there are scenario where we can open to the side but as a preview? I wonder if this is why this setting affects the behavior.

This is driven by this line:
https://github.com/microsoft/vscode/blob/4f6f7d50b9941ab4dcd6280f49584c1c66e7b17a/src/vs/workbench/contrib/search/browser/anythingQuickAccess.ts#L1043
I can only speculate that when I re-implemented quick open, I took this behaviour over from our first version. If I had to guess, then we had this rule back then:

Alt always opens to the side
Ctrl opens an editor as non-preview when preview editors are enabled
Ctrl opens an editor to the side when preview editors are disabled

So I would argue that Alt-click is the key to use here, same as for the explorer for example. And Ctrl has special semantics depending on your settings.

Thanks. That is the behavior I see. Maybe we update the setting description to make this more clear?
Current:

Controls whether editors opened from Quick Open show as preview editors. Preview editors do not stay open, and are reused until explicitly set to be kept open (via double click or editing). This value is ignored when #workbench.editor.enablePreview# is disabled.

Maybe we add:

Hold Ctrl before selection to open an editor as a non-preview

"non-preview" or whatever jargon we use. Thoughts @bpasero?

Yeah I like the idea of updating settings, feel free to do that!

verification: read the docs for the settings. Does the use of Ctrl there make sense (knowing that we don't want to change the behavior)


Process summary input file name collision

When both params.pangolin and params.vadr are set to false, nextflow complains:
Error executing process > 'summary (P120-S09-00846-4-S_S24)'

Caused by:
  Process `summary` input file name collision -- There are multiple input files for each of the following file names: Cecret.nf

Tip: when you have fixed the problem you can continue the execution adding the option `-resume` to the run command line

Possible offending lines:
https://github.com/UPHL-BioNGS/Cecret/blob/c683a197604ebd2f703ceb1cb8f187e8d2a2e0db/Cecret.nf#L1134-L1136
https://github.com/UPHL-BioNGS/Cecret/blob/c683a197604ebd2f703ceb1cb8f187e8d2a2e0db/Cecret.nf#L1233-L1235
This was run with version 1.3.3 of the StaPH-B toolkit, which may not include an up-to-date workflow file.

That was a hacky way to accomplish this anyway.
The new version should not have this issue.

The StaphB toolkit should be updated _soon_ish

It should be fixed in the staph-b toolkit now.
https://github.com/StaPH-B/staphb_toolkit/pull/59


Solved #91 Refactoring : added url_for

Have you read the Contributing Guidelines on Pull Requests?
Yes
Description
url_for in Flask is used for creating a URL to prevent the overhead of having to change URLs throughout an application (including in templates). Without url_for , if there is a change in the root URL of our application then we have to change it in every page where the link is present.
Checklist

[x] I've read the contribution guidelines.
[x] This PR mets all the requirements like Clean Code, proper README and Documentation

Related Issues or Pull Requests
Fixes: #91

Please review @BALaka-18


Any plans to revive this repo ?

Is android-folder-picker-library actively maintained anymore ? It seems pretty dead right now. Any plans of restarting development ?
Regards

Hey @Tombstone2K Thanks for showing interest, After receiving your interest I've decided to update this project to work on latest android versions.
Thanks Again.


Markdown in column descriptions renders as raw text when collapsed

When showing the single-line preview for Markdown descriptions, Markdown content like links is rendered as the raw text.  When expanded, the text renders as Markdown as expected.
This may be tricky to solve elegantly, because ideally you'd want to render the first line, but ignore things like multiline code blocks or bulleted lists.

@jdavidheiser I tried to reproduce and it looks like the issue is currently fix on master. Please reopen if you are somehow able to still reproduce with the latest code.

Hi, I'm seeing this issue with the current master - 9d558af458c3545249daafb5b44c48fbf3746a6a
This is using the sample data loader.
Collapsed:

Expanded:

Hi, I'm seeing this issue with the current master - 9d558af458c3545249daafb5b44c48fbf3746a6a
This is using the sample data loader.
Collapsed:

Expanded:


Enable time range

Hi,
It would be nice to set specific hours and just show them.
Something like this in mind :
time_enable:['10:20', '5:40']
Really useful to make reservation tool or something like that.
Voilà, it was just a proposal !

Hello @mimyka
I think you can  already do this using e.g. minTime: "10:20" and maxTime: "17:40'

Yes, it's almost that i've in mind. thinking about picking only hour defined by user, not a really range, i made a mistake in title
Sorry if it's not clear

@Mimyka in that case there's not much flatpickr can do here, because limiting user selection to very specific times cannot be done in a way that's intuitive for the user. In this case I would suggest using a simple select box with available times instead.

@chmln You're right, that's probably a best solution, thanks for reply ! By the way, awesome project :+1:

@Mimyka you're most welcome :+1:


I18n migration - tables without prefix

What steps will reproduce the problem and what do you get?
Executing yii migrate --migrationPath=@yii/i18n/migrations/ creates tables without prefix.
What is the expected result?
Tables with prefix set in common/main-local.php?
Additional info

Q
A

Yii version
2.0.8

PHP version
5.6.15

Operating system
Win10

this issue can be closed, guys )


streaming search example with colbert ranking

I confirm that this contribution is made under the terms of the license found in the root directory of this repository's source tree and that I have the authority necessary to make this contribution on behalf of its copyright owner.

You need to rename the notebook to have -cloud as suffix as the rest of the notebooks, that is why the Screwdriver/7055/PR:notebooks-except-cloud fails


GU - Send Errors from 5/4

DevOps notified that there have been failures communicating with receivers due to send errors. GU errors noted below. Need to resubmit failed files to GU.
[1;31m09:28:31.275 [pool-2-thread-7811][78225] FATAL-ALERT gov.cdc.prime.router.azure.SendFunction - FAILED Sftp upload of inputReportId de3a9460-6995-4d47-a073-c3bedbca4637 to SFTPTransportType(host=sftp-west.inductivehealth.com, port=22, filePath=./prod/, credentialName=null) (orgService = gu-doh.elr), Exception: Connection timed out (Connection timed out), All retries failed.  Manual Intervention Required.  Send Error report for: de3a9460-6995-4d47-a073-c3bedbca4637 to gu-doh.elr[m
[1;31m11:28:27.192 [pool-2-thread-7992][77410] FATAL-ALERT gov.cdc.prime.router.azure.SendFunction - FAILED Sftp upload of inputReportId e1ceb250-d4c4-4365-b97e-363eb0b780c9 to SFTPTransportType(host=sftp-west.inductivehealth.com, port=22, filePath=./prod/, credentialName=null) (orgService = gu-doh.elr), Exception: Connection timed out (Connection timed out), All retries failed.  Manual Intervention Required.  Send Error report for: e1ceb250-d4c4-4365-b97e-363eb0b780c9 to gu-doh.elr[m
[1;31m13:27:01.394 [pool-2-thread-8177][104805] FATAL-ALERT gov.cdc.prime.router.azure.SendFunction - FAILED Sftp upload of inputReportId c62cd7b4-e896-4866-ba87-f3998fa64b9c to SFTPTransportType(host=sftp-west.inductivehealth.com, port=22, filePath=./prod/, credentialName=null) (orgService = gu-doh.elr), Exception: Connection timed out (Connection timed out), All retries failed.  Manual Intervention Required.  Send Error report for: c62cd7b4-e896-4866-ba87-f3998fa64b9c to gu-doh.elr[m

5/4: Anshul checking with Inductive to see if the timeouts are a known issue for their west servers since only GU files failed. MS, TN and other Inductive states are fine.

@anshulkumar-usds @sarahnw @Adrian-Brewster - Files have been transferred


Grunt can't find Node package binaries after nvm update

As a command line user, I like being able to define make-like dependency task trees with Grunt.
I used to be able to do this in my Gruntfile.js, but after upgrading my nvm to nvm v0.23.3, this on longer works. Attempts to execute jshint with grunt jshint now fail with command not found, due to grunt-cli failing to connect the NPM PATHs to the Node package binaries.
How can we get grunt-cli to automatically pull in NPM PATHs so that grunt-cli can once again run Node package binaries?

This has nothing to do with grunt-cli, but rather your terminal not finding the grunt-cli binary.
https://www.google.com/search?q=command+not+found+npm&oq=command+not+found+npm&aqs=chrome..69i57j0l5.1276j0j1&sourceid=chrome&es_sm=91&ie=UTF-8

My terminal CAN find grunt-cli (grunt), that is not the problem.
grunt-cli is failing to load the proper NPM PATH before attempting to run commands.


Table transform only happens for foreign keys and indices

The actual tables are migrating with the same name. Thus for the following csv:
CUSTOMER,Customer,False
The files are turning up in MySQL (from Oracle) as 'CUSTOMER' but then it tries to add indices and FKs to Customer and falls down in a heap.

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

@Xaraxia  Is this related to issue https://github.com/seanharr11/etlalchemy/issues/22 ? It just sounds like we aren't using the Table Transform logic when generating the schema. Are you able to throw a quick fix in there to remedy this? If not, let me know and I'll hack on it sometime this week.


Thesis : Replace default with a Pretty Title Page ?

Currently, the \maketitle command is used to add an Abstract, keywords and everything. Yet, this also sets the design of the front page to something, that is not very aesthetically pleasing for a thesis front page.

Maybe one could also design a pretty front page and then have the manual page as the first numbered page (i.e. page 3)