Search: prevent triggering other integrations with /

It seems that /, ?, Ctrl + f and Ctrl + k are pretty common hotkeys to trigger modals (eg. search, help, etc). We are currently mapping our search modal to /.
MkDocs, for example, uses / to show a modal with some help about the hotkeys. This conflicts with our own modal:

I tried to find how to call document.removeEventListener("keydown"); but it seems it requires passing the function handler as second attribute. What would be a possible solution for these cases?

Interesting. Material for MkDocs also uses / to jump into the focus of the search input. However, it does not collide with ours for some reason 🤷🏼 . I'm testing this locally at http://test-builds.devthedocs.org/en/mkdocs-material/

Currently, we are injecting our script at the end of <head>. Would be possible to solve this issue by injecting our script at the beginning of it, making it loading in a sync way and using event.preventDefault()?

Just wanted to note that C-f is a browser shortcut (find in Firefox and others) that we shouldn't override.

Would be possible to solve this issue by injecting our script at the beginning of it, making it loading in a sync way

We still want to load async or we'll block the page load, so async might still load after other async scripts still.
Noted on #115, but I'd probably say we shouldn't do anything unexpected here and let the project maintainer decide this instead. They can control their own project's behavior on keyboard shortcuts.
Long term, we need UI that will trigger these elements, keyboard shortcuts are more of a temporary solution because we don't have this UI.

In https://github.com/readthedocs/addons/pull/115#issuecomment-1710908540 we talked about documenting how to disable conflicting hotkeys from other doctools and point users to this documentation: https://github.com/readthedocs/addons/pull/115#issuecomment-1710908540

Apparently this does conflict with mkdocs, you can clearly see it here, this documentation uses a custom build process, maybe this is the reason.
Also, clicking on the search string from mkdocs-material opens the readthedocs search and this is very annoying.
https://github.com/readthedocs/addons/assets/26704473/946bd7b0-2fd8-43d7-9c8d-b804a58023dc

@FeeeeK thanks for reporting this 👍🏼 . We are working on improving this integration and hopefully we will fix it soon.

Is there any way to disable this but leave the site indexed?

I disabled the hotkeys addon on that project for now. In the near future, maintainers will be able to enabled/disable these addons by themselves.

I didn't find a way to disable the keyboard shortcuts on Material for MkDocs: https://squidfunk.github.io/mkdocs-material/setup/setting-up-navigation/#keyboard-shortcuts

Next steps: document that each tool needs a way to disable hot keys.

I wrote some thoughts about this at:

https://github.com/readthedocs/addons/issues/165#issuecomment-1781287582
https://github.com/readthedocs/addons/pull/168#issuecomment-1778842061

Summarizing,

Hotkeys addon should be disabled by default
Each hotkeys from the addon should be configurable as enabled/disabled (e.g. enable "show search modal" with / but disable "docdiff" with d)
We need to document how to disable keyboard shortcuts from known incompatibilities with doctools/plugins/etc and explain how to integrate in a nicer way our owns

With that said, I'm closing this issue and opening a new one about writing the documentation required for this plan.

@FeeeeK Hi 👋🏼 . Material for MkDocs released v9.5.5 that includes a fix for this. Can you upgrade to the latest version of it if haven't already and re-enable the hotkeys addons by going to the new dashboard at https://beta.readthedocs.org/ and then to your project's settings? I'd appreciate that 🙏🏼


Update FPGA onchip_memory_cache tutorial to create a reusable class and get rid of ivdep

Description
This update hides the implementation of the cache in a reusable class (OnchipMemoryWithCache, in the shared include directory) and gets rid of the (previously improperly applied) ivdep attribute on the loop.
This change results in a small area increase (a cache depth of 7 is needed to achieve the same results as the original design with a cache depth of 5), but no performace (fmax or throughput) degradation.  The change also allows users to simply re-use the class in the shared header file, rather than having to implement it themselves, which is a process that was very prone to errors.
More importantly, the previous version of this tutorial was using the ivdep attribute in an incorrect way that could result in functional errors.  Removing the ivdep entirely eliminates this possibility.
External Dependencies
None
Type of change

[X] Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?
Ran seed sweeps with each relevant cache depth (0, 1, and 7) in isolation to verify no fmax drops from the previous version.
Ran the full design (hardware and emulation) on a10 and s10 devices in both Linux and Windows, all passed.

Adding @tomlenth for the README changes and @pmpeter1 for the SYCL code changes.
(This PR has been reviewed internally before)

Please make sure all usages of the samples work with this approach.

I don't understand what you mean by 'this approach'?  If you're talking about the explicit use of sycl::, I don't see how that's related?  Perhaps you're referring to the shared include directory?  If so, we have many FPGA samples that use this shared directory, and it has been validated with the sample browser and when checking out the entire repo.

The explicit use of sycl:: is a style issue.    If we want to move in this direction it means ratifying a change in the samples WG to the coding guidelines.    Given the community feedback this may be a good change.
By "this approach" I was referring to the use of the samples via the sample-browser.     If you have already validated that this code works with the sample-browser (all relative links are checked out correctly), then I have no additional concern.

We've been trying to remove the use of using namespace in new FPGA samples.
I can bring this up in the next samples meeting.


Add --only flag

Something from my stash. Something for #160.
Related to https://github.com/haskellpeople/hlint/issues/12.

Thanks!


HDDS-8685. [SNAPSHOT] CreateCheckpoint needs to be idempotent.

What changes were proposed in this pull request?
Checkpoint creation should be idempotent in the case of log replays.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-8685
How was this patch tested?
Existing UT and New UT.

findbugs in test:
M D DLS: Dead store to omSnapshotCheckpoint in org.apache.hadoop.ozone.om.TestOmSnapshotManager.testCreateSnapshotIdempotent()  At TestOmSnapshotManager.java:[line 428]
M D DLS: Dead store to omSnapshotCheckpoint1 in org.apache.hadoop.ozone.om.TestOmSnapshotManager.testCreateSnapshotIdempotent()  At TestOmSnapshotManager.java:[line 436]

https://github.com/apache/ozone/actions/runs/5337343478/jobs/9673267601


[EN DateTimeV2] Cannot recognize "over 12 months"

Only "12 months" is recognized.

This issue can be ambiguous. A longer analysis of the possible solutions will be necessary.


feat: add gruvbox dark theme

this PR adds support for gruvbox dark theme on both the application and website.

open to any feedback as this is my first port of a theme!

Thanks for this!
I may make some tweaks to the orange text color before shipping.
Also, this makes me want to prioritize providing themes as plugins. I'll try to do that in the next release or two as well.

awesome! i'm happy to take a look at the PR once it's ready


Fix instances of luxengine/math

https://github.com/luxengine had all it's repositories excluding lux deleted (We don't know why as of yet, and we received no notice of this) including one that engo depends on math.  This is causing all CIs to build and will mean that any newcomers who go get engo will receive an error. This is an urgent issue.

It's not deleted, just moved to https://github.com/luxengine/lux/tree/master/math ...

Oh well I didn't see that and there was no indication of what happened


Réécriture en Rouille

Python very bad, Rust very good :rocket:

Dang it, everyone is rewriting software in Rust these days...
@qexat sorry for bothering again -- could you review this PR as well?

Sure, LGBT uhh I mean LGTM

Nice, thank you @qexat for your hard work. Merging ASAP.


Meteor 1.2 support

After upgrading to 1.2 RC i'm getting the following error for images:
=> Errors while initializing project:

While building package tabular:
error: No plugin known to handle file 'images/sort_asc.png'. If you want this
file to be a static asset, pass the {isAsset: true} option to api.addFiles; eg,
api.addFiles('images/sort_asc.png', 'client', {isAsset: true}).
error: No plugin known to handle file 'images/sort_asc_disabled.png'. If you
want this file to be a static asset, pass the {isAsset: true} option to
api.addFiles; eg, api.addFiles('images/sort_asc_disabled.png', 'client',
{isAsset: true}).
error: No plugin known to handle file 'images/sort_both.png'. If you want this
file to be a static asset, pass the {isAsset: true} option to api.addFiles; eg,
api.addFiles('images/sort_both.png', 'client', {isAsset: true}).
error: No plugin known to handle file 'images/sort_desc.png'. If you want this
file to be a static asset, pass the {isAsset: true} option to api.addFiles; eg,
api.addFiles('images/sort_desc.png', 'client', {isAsset: true}).
error: No plugin known to handle file 'images/sort_desc_disabled.png'. If you
want this file to be a static asset, pass the {isAsset: true} option to
api.addFiles; eg, api.addFiles('images/sort_desc_disabled.png', 'client',
{isAsset: true}).

I can confirm that changing it to   ], 'client', {isAsset: true}); works. I don't have enough time this week to PR though :frowning:

Yeah, I saw that in the 1.2 release notes. Hopefully old Meteor doesn't choke on isAsset being there. I will merge a PR or fix on my next tabular sprint.

Cool thanks @aldeed!
I just tried it on  <IP_ADDRESS> and it doesn't throw when building but when going to the table page has an undefined error. Removing isAsset fixes it.... I guess changing the versionsFrom to 1.2 will make the packager choose a lower version for pre 1.2 apps?

Probably whenever I update I will have to bump major version of this pkg and it won't be usable on < 1.2 anymore. Unless I can detect what the Meteor version is and keep both types of api.use in there depending.

We have upgraded our project to Meteor 1.2 without any issue.

Yeah this was fixed awhile back


Adds StoreResult start time and latency to diagnostics

Pull Request Template
Description
This PR adds the store result start time to the diagnostics. The information was already being captured but was not added to the JSON diagnostics. This is useful to help determine how long each individual request to the backend took and the duration between each call.
Type of change
Please delete options that are not relevant.

[] Bug fix (non-breaking change which fixes an issue)
[] New feature (non-breaking change which adds functionality)
[] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[] This change requires a documentation update

Closing issues
To automatically close an issue: closes #IssueNumber

and can help show thread starvation for requests ran in parallel like strong reads

How can this be used? Is the Start Time captured before the Task is created or after? If it's before, should this then be compared with the Create on the request timeline?

How can this be used? Is the Start Time captured before the Task is created or after? If it's before, should this then be compared with the Create on the request timeline?

The start time gets set before the task is created. I updated the description.


Bug: Repository Insights are Replacing each other on creation

Describe the bug

Steps to reproduce

Create a repository insight in a workspace
Note it is in the repository insight list
Create a Second repository insight in a workspace
Note that it replaces the First.

Browsers
No response
Additional context (Is this in dev or production?)
After some local debugging, I think it is most likely API related. I was able to confirm that this is persistent on beta. I haven't looked into the API just yet/
Code of Conduct

[X] I agree to follow this project's Code of Conduct

Contributing Docs

[ ] I agree to follow this project's Contribution Docs

Looks like this line is failing on beta currently when trying to create an insight @zeucapua
https://github.com/open-sauced/app/blob/beta/components/organisms/InsightPage/InsightPage.tsx#L705

Doesn't seem to be API related: here's the same PATCH /v2/workspaces/{id}/insights I made with the same name and the same repo and they both appear.

@brandonroberts I can confirm that this only happens when I sync an organization and not when I add repos manually.

Confirmed on my end also

Fixed in https://github.com/open-sauced/api/pull/642


Proposal: Migrate native code to Kotlin and Swift

Following up on some of the good discussion in #1628 and a suggestion from @CHaNGeTe I wanted to start a new proposal: Migrate native code to Kotlin and Swift.
Pros:

Safer, more modern and productive languages recommended by Google And Apple.
More familiar to developers coming from the native world, might increase contributions

Cons:

Less common in the react-native world. react-native core is still java/objective-c.
Kotlin is a new dependency some react-native apps may not have yet.

Here is a PR for the Swift conversion. Would be great if anyone has time to give it a try.
https://github.com/react-native-video/react-native-video/pull/2527


iOS UI customization in monorepo project structure

Describe the bug
After following the docs, I applied the UI customization for Android ( and it worked as expected ) for iOS not styles not reflected.
To Reproduce
App Structure: ("apps/{APPNAME}/ios/{TENANT}/AdyenAppearance.swift")
Expected behavior
iOS styling to be updated.
Additional context
I applied the same UI styling in the AdyenExample repo and worked fine.
I have monorepo project. with multi tenant.
The DropIn component runs fine.

Hey @Alieltahan
AdyenAppearance.swift need to be added in Xcode. Also make sure to set correct "Target Membership" to it.

To debug this make a breakpoint in AdyenApperance and in Xcode console log print out
po Bundle.allBundles.compactMap { $0.infoDictionary?[bundleExecutableKey] as? String }

Thank you @descorp  for your support, Kindly note:

I had added the file in Xcode, and selected a Target Membership.
I'm facing the following error while trying to print:

Appreciate your feedback.

@Alieltahan
try
Bundle.allBundles.compactMap { $0.infoDictionary?["CFBundleExecutable"] as? String }

Hey @Alieltahan
Any luck?

@descorp Thank you for your follow up.
I'm still unable to resolve it at the moment.
Please find the output:
["Correct-Tenant-NAME", "ContactViewViewService", "BoundingPathData"]
Appreciate your support.

Hey @Alieltahan
I think "-" in your target name might be a cause of the problem.
Here is PR to fix this #300
Could you try this fix locally by updating "AdyenAppearance.swift" in Pods  ?

Hello @descorp
This is worked perfect!
Thank you so much for your extended support.
Have a great day ahead.

Thanks for confirming 💚
I'll keep this ticket open till we fix the bug in 1.2.0 release

Release on 1.2.0


fix(ios): Remote issues: #1041 / #1096 onForegroundEvent() and getInitialNotification()

👋 Hello!
This PR fixes

#912
🤔 Perhaps #999
#1041
#1076
#1096.
#1109

🙏 Please keep in mind I just learned Objective C and Swift in order to fix those issues.
What's changed?

onForeground() is called with getInitialNotification() for PRESS and PRESS_ACTION events when app is opened from a terminated state.
remote payload is picked up when local payload is not available. Thanks to this, getInitialNotification() will return the correct payload on app start.
With the above, I think this code will be unreachable so I removed it
onForeground()  is called for DELIVERED events by removing this condition, but I have mixed feelings about it. Might need a deeper look.

How to test

Be sure to configure Notifee to handle remote notifications
If you're using patch-package, in your patches folder create a file called @notifee+react-native+9.1.1.patch
Paste the following:

diff --git<EMAIL_ADDRESS><EMAIL_ADDRESS>index 560a62c..c010367 100644
---<EMAIL_ADDRESS>+++<EMAIL_ADDRESS>@@ -58,13 +58,18 @@
 #pragma mark Application Notifications

 - (void)application_onDidFinishLaunchingNotification:(nonnull NSNotification *)notification {
-#pragma clang diagnostic push
-#pragma clang diagnostic ignored "-Wdeprecated-declarations"
-  UILocalNotification *launchNotification =
-      (UILocalNotification *)notification.userInfo[UIApplicationLaunchOptionsLocalNotificationKey];
-  [[NotifeeCoreUNUserNotificationCenter instance]
-      onDidFinishLaunchingNotification:launchNotification.userInfo];
-  [[NotifeeCoreUNUserNotificationCenter instance] getInitialNotification];
+  NSDictionary *notifUserInfo =
+      notification.userInfo[UIApplicationLaunchOptionsLocalNotificationKey];
+
+  if (!notifUserInfo) {
+      // Fallback to remote notification key if local notification key is not available
+      notifUserInfo = notification.userInfo[UIApplicationLaunchOptionsRemoteNotificationKey];
+  }
+
+  if (notifUserInfo) {
+      [[NotifeeCoreUNUserNotificationCenter instance] onDidFinishLaunchingNotification:notifUserInfo];
+      [[NotifeeCoreUNUserNotificationCenter instance] getInitialNotification];
+  }

   [[NotifeeCoreUNUserNotificationCenter instance] observe];
 }
diff --git<EMAIL_ADDRESS><EMAIL_ADDRESS>index beaa360..ff53bef 100644
---<EMAIL_ADDRESS>+++<EMAIL_ADDRESS>@@ -21,7 +21,6 @@
 #import "NotifeeCoreUtil.h"

 @implementation NotifeeCoreUNUserNotificationCenter
-
 struct {
   unsigned int willPresentNotification : 1;
   unsigned int didReceiveNotificationResponse : 1;
@@ -73,12 +72,31 @@ struct {

 - (nullable NSDictionary *)getInitialNotification {
   if (_initialNotificationGathered && _initialNotificationBlock != nil) {
+
     // copying initial notification
     if (_initialNotification != nil &&
         [_initialNoticationID isEqualToString:_notificationOpenedAppID]) {
-      NSDictionary *initialNotificationCopy = [_initialNotification copy];
+
+      NSMutableDictionary *event = [NSMutableDictionary dictionary];
+      NSMutableDictionary *initialNotificationCopy = [_initialNotification mutableCopy];
+      initialNotificationCopy[@"initialNotification"] = @1;
+
       _initialNotification = nil;
-      _initialNotificationBlock(nil, initialNotificationCopy);
+
+      // Sets the return payload for getInitialNotification()
+     _initialNotificationBlock(nil, initialNotificationCopy);
+
+      // Prepare onForegroundEvent() payload
+      event[@"detail"] = [initialNotificationCopy copy];
+      if ([event[@"detail"][@"pressAction"][@"id"] isEqualToString:@"default"]) {
+          event[@"type"] = @1;  // PRESS
+      } else {
+          event[@"type"] = @2;  // ACTION_PRESS
+      }
+
+      // Call onForegroundEvent() on Javascript side with payload:
+      [[NotifeeCoreDelegateHolder instance] didReceiveNotifeeCoreEvent:event];
+
     } else {
       _initialNotificationBlock(nil, nil);
     }
@@ -104,7 +122,6 @@ struct {
   NSDictionary *notifeeNotification =
       notification.request.content.userInfo[kNotifeeUserInfoNotification];

-  // we only care about notifications created through notifee
   if (notifeeNotification != nil) {
     UNNotificationPresentationOptions presentationOptions = UNNotificationPresentationOptionNone;
     NSDictionary *foregroundPresentationOptions =
@@ -148,23 +165,16 @@ struct {
       presentationOptions |= UNNotificationPresentationOptionAlert;
     }

-    NSDictionary *notifeeTrigger = notification.request.content.userInfo[kNotifeeUserInfoTrigger];
-    if (notifeeTrigger != nil) {
-      // post DELIVERED event
-      [[NotifeeCoreDelegateHolder instance] didReceiveNotifeeCoreEvent:@{
+    // post DELIVERED event
+    [[NotifeeCoreDelegateHolder instance] didReceiveNotifeeCoreEvent:@{
         @"type" : @(NotifeeCoreEventTypeDelivered),
         @"detail" : @{
           @"notification" : notifeeNotification,
         }
-      }];
-    }
+    }];

     completionHandler(presentationOptions);

-  } else if (_originalDelegate != nil && originalUNCDelegateRespondsTo.willPresentNotification) {
-    [_originalDelegate userNotificationCenter:center
-                      willPresentNotification:notification
-                        withCompletionHandler:completionHandler];
   }
 }

Hey @LunatiqueCoder 👋 ! Haven't hacked on things with you in a while, good to see you
I need to focus first on making sure Notifee is compatible with react-native 0.76 as I believe we have New Architecture incompatibilities even with the compat mode
But right after that I was planning on tackling all of these issues related to FCM delivery and events not firing and such - and it looks like you have beaten me to it with this PR
This is an area I really only want to change once (or...one more time) though so I need to think pretty deeply about how exactly this should work (should it consume the initial notification or not? how exactly should it interoperate with react-native-firebase? etc). So please be patient as it may be a little bit before I get to this, but it is pretty important to get right and I'm excited to see you've already thought through it with this patch here

@mikehardy 🍺 Hehe, long time indeed. Happy to talk to you again
I'm still tinkering, but I was very excited to see I might have fixed some Github issues while I was working on my stuff, especially when I saw you're a core contributor here as well.
I'm also planning to open source an Expo config plugin for Notifee's iOS remote notifications. Basically it will follow these steps here: https://notifee.app/react-native/docs/ios/remote-notification-support

Anyway, back to our issues:

For one specific question:

This will also enable getInitialNotification() for iOS if the app was opened from a terminated state by pressing the notification. However, the docs say it should be deprecated. How are we supposed to handle this scenario without getInitialNotification()? Should we remove that part from the docs?

The app is started and brought to the foreground and I believe a Notifee event handler is called, to deliver the event?

While trying to understand the code, I noticed that getInitialNotification() should work by implementation, but it was ALWAYS checking for local notifications, and never for remote ones.
This is all I did to make it work: https://github.com/invertase/notifee/blob/5d46de0867f3e8fe5e0712547024186e3ebd695c/ios/NotifeeCore/NotifeeCore%2BNSNotificationCenter.m#L61-L72

As a side note, since apns-push-type: background it's almost useless, we had to rely on remote notifications for iOS without breaking Android.
We ended up using this following snippet with Firebase Node.js SDK
which I think it would be very useful to add in the docs):
import type {NextApiRequest, NextApiResponse} from 'next';
import type {Notification} from '@notifee/react-native/src/types/Notification';
import {AndroidImportance} from '@notifee/react-native/src/types/NotificationAndroid';
import {MulticastMessage} from 'firebase-admin/lib/messaging/messaging-api';

const notifeeOptions: Notification = {
  id: Date.now().toString(),
  title: 'Title',
  subtitle: 'Subtitle',
  body: 'Main body content of the notification',
  android: {
    channelId: 'default',
    importance: AndroidImportance.HIGH,
    pressAction:
  },
  ios: {
    sound: 'default',
    criticalVolume: 1,
    critical: true,
    foregroundPresentationOptions: {
      badge: true,
      banner: true,
      list: true,
      sound: true,
    },
  },
};

const message: MulticastMessage = {
  // ✅ We can continue using local notifcation for Android
  // 👍 while triggering iOS remote notifications from `apns`
  data: {body: JSON.stringify(notifeeOptions)},
  tokens: [],
  android: {
    priority: 'high',
  },
  apns: {
    payload: {
      notifee_options: notifeeOptions,
      aps: {
        alert: {
          // 🚧 This is needed to trigger an alert/remote notification only for iOS
          // 👍 but Android will continue using data-only notifications
          title: 'Hello World',
        },
        mutableContent: true,
      },
    },
  },
};

export default async (req: NextApiRequest, res: NextApiResponse) => {
  try {
    await admin.messaging().sendEachForMulticast(message);

    res.status(200).end();
  } catch (e) {
    res.status(400).end();
  }
};

FYI, I just tested the fix, and on my side, the first index in the patch differed from mine.
Also, after some JS debugging, the call to await notified.getInitialNotification(); was not returning at all, aka the promise was hanging there.
I'm not an iOS expert, so something else I'm not aware from our project could interfere!
The different index after reconstructing the patch manually:

Hmm, just noticed those changes were made with<EMAIL_ADDRESS>If I update to the latest version, the patch fails. I'll try again and see how it goes. Thanks for the input!

I'm also on "<EMAIL_ADDRESS>

Pushed one more commit to also fix onForegroundEvent() not being called when app is started from a terminated state. Now it's called after getNotification()
Perhaps there's a more elegant solution, and we could do it better. However, I believe the didReceiveNotificationResponse() method of NotifeeCore+UNUserNotificationCenter.m can be updated without this old time delay workaround:
https://github.com/invertase/notifee/commit/c606a85d730259fb418d7d64d5534a2113742ca9#diff-ec80c62b93aed0afa4addac8a6cd5fb6534543b3cc39bbd1b706adb9ec82a1ccL122-R132
https://github.com/invertase/notifee/blob/c606a85d730259fb418d7d64d5534a2113742ca9/ios/NotifeeCore/NotifeeCore%2BUNUserNotificationCenter.m#L123-L129

But for now it works (on my computer 🤣) and we can improve the logic over time. Of course, there's also the New Arch and so on. :)
Cheers 🍻

Hi again. Based on the conversation so far I updated the first post:

Adapted the patch to use the latest Notifee version
Added What's changed section describing the code changes decisions.
Improved How to test section

Amazing work hope to see news about this PR soon 👀 thanks !

when we can expect the latest version with the updated code?

@TestWts2017 you can't. It is open source and I am always very clear with people - when you interact with open source you must abandon your expectations of release dates. If it is important to you, use patch-package and integrate the changes in your project directly, no need to wait

☝ the referenced issues above might be duplicated

They probably are, most of the complaints in this repo are all actually the same complaint / disagreement with how it functions, or some ridiculously niche thing which is hard to solve 😆
Been traveling all week but will be back to work next week

Hey there! I partly agree with this because the Firebase documentation can be pretty unclear, especially when it comes to integration. It often feels like you have to dig through issues or PRs to get answers. Also, I wonder why Invertase promotes Notifee in react-native-firebase if it’s considered niche? Notifee is such a powerful library and a great addition to any React Native project. Ideally, it should work seamlessly on both iOS and Android with Firebase—if not, maybe it shouldn’t be featured as an option!

Just to answer one part: Notifee is not at all considered niche! However, a full screen notification is a niche case, as is a permanent notification attached to a foreground service of a niche type, as is scheduling exact alarms. Each of those is a niche feature just based on query traffic here related to them. Non-niche use is "I want to post a notification, perhaps with styling and an image, in the foreground and background case"
It just so happens that this PR is right in that area of work.
However, my mention of the other stuff as niche is not to say Notifee shouldn't be supporting it. And in either case, react-native-firebase had to eject the local-notification device API surface area specifically because all those niche use cases (which are each important to someone!) were a huge drag on the core purpose of react-native-firebase which is to wrap firebase APIs.
It is not possible (we tried!) to support the local device notification APIs people want and all the firebase APIs in the react-native-firebase repos, we had to split it out, thus Notifee exists.
And unfortunately, with the pace of device-local notification API change (typically in the form of increasing restrictions to curb abusive behavior from app developers...) and the pace of change of device-local power management which affects message delivery (typically in the form of increasing restrictions to curb abusive behavior from app developers...) there is no simple integration. Troubleshooting unfortunately always starts with a tree of questions of the form "okay, iOS or Android? okay is it a notification, data, or mixed FCM? okay, what version of the operating system?" and gets worse from there.
There is no seemless unfortunately. The work in this PR should make it a great deal better though because yes, it is rough going right now.
Hope that's sort of clear with regard to maintainer goals and repo motivation at least?

I completely agree that separating Notifee from react-native-firebase was the right approach! I also understand the difficulty of meeting OS requirements for both Android and iOS—each has its own set of complexities. Over the past few months, I’ve read through many Notifee issues and comments to better understand how notifications work across platforms, and I want to acknowledge and appreciate all the hard work put into this package.
I’m excited to see the improvements in the PR, as they’ll make these features more accessible. That said, I know that adding new functionality without impacting other areas is a significant challenge, especially given the wide range of use cases Notifee supports. Enhanced documentation, particularly around Firebase integration, could also help more developers avoid common pitfalls and make setup easier. I’ve noticed that this repo used to get frequent responses from you and other maintainers, so better documentation could help lighten that load too.
Thanks for the insight—it really clarifies the goals and challenges behind Notifee!

I know there is a lot of interest in this one and I am as well. Just wanted to let everyone know it won't sit forever but I'm still backlogged on urgent items - that is there is one repo left that still does not seem to be behaving well with new architecture at all in the form of @invertase/react-native-apple-authentication and I must get that working first. cocoapods/xcodeproj blowing up all react-native-firebase builds last week was unexpected and took time as well.
There is one other new architecture issue here that came up where foreground services appear to freeze and I'll need to handle that as a regression before coming back to this, but once all the new arch stuff is done, this is first. It will happen but I'll appreciate the patience in the meantime

Getting closer on this - apple auth qualified on new arch, and got reproduction scaffolding setup in react-native-firebase in order to test this stuff over the weekend https://github.com/invertase/react-native-firebase/pull/8143 - there is methodical progress towards having real test coverage for all the foreground / background stuff. I continue to appreciate the patience

Thanks man! This fix really helped!!!!
Keep doing the good man's work!

I'm wondering if this PR also fix the problem where you can't update the badge in the onBackgroundEvent handler... I'm asking because I see that this PR also fix some issues the background event.

Great library!!!
But with the above patch package (tried with latest version also and mentioned version also) or with an older version, I am not able to get any payload for remote notification in iOS, but with Android, it is working. Any help or feedback is appreciated.

@TestWts2017 commented:

I am not able to get any payload response for remote notification in iOS, but with Android, it is working.

   👈 [click]   Did you try this sauce along with the patch?

📖 Source: Answered above in https://github.com/invertase/notifee/pull/1118#issuecomment-2400737750

@TestWts2017 on iOS, you will not receive anything in onBackgroundEvent. You will get the payload when you open the app in onForegroundEvent or getInitialNotification. Let me know if this works for you.

@TestWts2017 on iOS, you will not receive anything in onBackgroundEvent. You will get the payload when you open the app in onForegroundEvent or getInitialNotification. Let me know if this works for you.

Yes means onForegroundEvent is not able to log payload so is there any additional configuration we need to add

Personally, I'm using shared group preferences to store background notifications within the notifications extension, and retrieve them on JS side with react-native-shared-group-preferences. That's how I get my background notifications on iOS

@LunatiqueCoder this sounds interesting but it is not so clear to me. Could you explain with more details?
Thanks in adavance for any help!

@LunatiqueCoder This patch make my app to crash when pressing on a local notification to open app in killed state. I'm using xcode 16.2,  "react-native": "0.74.3", "@notifee/react-native": "9.1.1"

@ng-ha "....and the stack trace from the crash is...."

@mikehardy Sorry for the delayed reply. I had to reproduce the crash. The previous crash was more informative, with the specific location of the crash. It came from NotifeeCore+UNUserNotificationCenter.m, but I didn't save that stack trace. Here is the stack trace I got this time with "@notifee/react-native": "^9.1.8". Thank you in advance!
detail.txt

Here is the stack trace with "@notifee/react-native": "9.1.1"
detail-9.1.1.txt


Add LinCE Sentiment Analysis Task

Tested on GPT2 and T5-small locally.

Change PR to big-science fork


No metadata available when installing #r.area.createweight addon for GRASS GIS

Hello,
Currently im struggling when installing #r.area.createweight add on for my GRASS GIS, error always appear as down below in GRASS GIS 7.8.3, 7.8.7, 8.0.1
Please, give your advice, if there any solution for this
WARNING: No metadata available for module 'r.area.createweight': Unable to
fetch interface description for command '<r.area.createweight>'.
     Details: <Cannot find the executable r.area.createweight>

ERROR: Unable to read manual page: [Errno 2] No such file or directory:
'C:\Users\*in\AppData\Roaming\GRASS8\addons\docs\html\r.area.createweight.html'

Thank you!

Hi @naufalianf  and thank you for reporting.
I received a message from someone else last week with the same issue you are facing right now.
I my side, I'm on Ubuntu 20.04 and GRASS 7.8.6 and I can (re-)install without any problem as you can see bellow. So, I'm guessing the problem is only with Windows. Maybe another Linux user can confirm ?

Mon Apr 25 10:56:12 2022)
g.extension r.area.createweight
WARNING: Extension <r.area.createweight> already installed. Re-installing...
Fetching <r.area.createweight> from GRASS GIS Addons repository (be patient)...
Compiling...
Installing...
Updating extensions metadata file...
Updating extension modules metadata file...
Installation of <r.area.createweight> successfully finished
(Mon Apr 25 10:56:25 2022) La commande s'est terminée (12 sec)
(Mon Apr 25 10:56:27 2022)
g.extension r.area.createweight operation=remove -f
Updating addons metadata file...
Extension <r.area.createweight> successfully uninstalled.
(Mon Apr 25 10:56:28 2022) La commande s'est terminée (0 sec)
(Mon Apr 25 10:56:35 2022)
g.extension r.area.createweight
Fetching <r.area.createweight> from GRASS GIS Addons repository (be patient)...
Compiling...
Installing...
Updating extensions metadata file...
Updating extension modules metadata file...
Installation of <r.area.createweight> successfully finished
(Mon Apr 25 10:56:44 2022) La commande s'est terminée (9 sec)


PF4 Select: add example and documentation for pf-m-plain

There is a request to have a pf-m-plain select, similar to the options menu and dropdown. Lets add an example and also add the documentation for the pf-m-plain modifier for the button is not documented in usage

:tada: This issue has been resolved in version 2.21.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Migrate documentdb client from sdk track 1 to track 2 client

Which issue this PR addresses:
Fixes: ARO-4565
What this PR does / why we need it:
Making a progress towards migrating to track 2 go sdk clients.
Test plan for issue:
Unit tests, E2E test and INT test
Is there any documentation that needs to be updated for this PR?
N/A

@bennerv should I delete the track 1 client in this PR too?

should I delete the track 1 client I'm replacing in this PR too?
If it's not in use, go ahead.


Update composer.json to allow for Laravel 6 usage

It looks to me like this is the only change that would be needed for the package to work with 6. 6 is basically the next evolution of 5 and a switch to a new versioning structure. It doesn't appear to be like the shift from 4 to 5.

@rennokki , do you can view this, please?

It looks to me like this is the only change that would be needed for the package to work with 6. 6 is basically the next evolution of 5 and a switch to a new versioning structure. It doesn't appear to be like the shift from 4 to 5.

@realripley00 needs change something about phpunit, has problems with CI of Travis.

Thanks for the PR. This package needed the 6.0^ new semver. It's going to be added in the following PR: https://github.com/rennokki/schedule/pull/13


2.0.0-pre.2: cowboy/src/cowboy_http2.erl:80: type opts() undefined

Get a build error:
===> Compiling /home/cw/erlfector/_build/default/lib/cowboy/src/cowboy_http2.erl failed
/home/cw/erlfector/_build/default/lib/cowboy/src/cowboy_http2.erl:80: type opts() undefined

deleting the -spec fixes the build error (yes, I'm a rebel)

I think I fixed that on the commit that immediately follows. Didn't bother tagging. :-)

Closing, thanks!


#506 remove HTML tag in confirm window

Description

BR tag shown in Folder delete confirmation window
Related Issue : #506

How Has This Been Tested?

Go to workspace
Click on trashbean icon in folder
See error

Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[ ] My code follows the code style of this project. it will be added soon
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have read the CONTRIBUTING document. it will be added soon
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.

Additional Context

run build
deploy to 2


Installer does full build from source

The ansible roles will download the latest source from GitHub and build the source to do the install. This should not happen. The installer should pull down and install a released version of the code.
Installer users could run an install mid-way during a development cycle and pick up incomplete implementations. This could cause problems and a bad first experience using OpenSDS. This also requires the installation of large packages on the users system like gcc and development packages that are not needed to actually run the service.
There could optionally be a way for them to specify that they want a development build, but that should not be the default thing that happens when running the installer.

Hi @stmcginnis , we do provide the option to install from release files, but I'm afraid it's not working now, considering we change the format of released files when publishing aruba release. So maybe we should test it at first and change the default way to release after the bug is fixed.

Let's discuss about this in tomorrow's technical meeting.  I have added it in the agenda.

Discussed with Sean about this issue in today's technical meeting.  We will backport important bug fixes to stable/aruba.  Installation can be either from stable/aruba if choosing source code or from a release tar ball after a Aruba stable release.


Can this agent use Azure's api or key?

Can this agent use Azure's api or key?
I want to try it with Azure key. Can this agent support it?

@MichaelYang1995  wondering if you ever get this to work ? would be great if you can share you implementation code (sample)


Combined stdout and stderr for osm collector run cmd

The result of this change is that if there is no resource of a specific type, instead of writing an empty file, the stderr message "No resources..." is written to the file instead.
Before
Table file is empty (not intended)

JSON config file is NOT empty (as intended)

After
Table file contains the stderr message No resources... (as intended)

JSON config file is NOT empty (no changes as intended)

No regressions for non-empty files checked:


Allow usage of zstd compression on json files

Instaloader currently compresses json files with xz.  While xz offers good compression ratio, zstd has a specific and optimized mode for compressing many similar small files.  It would be very useful to use zstd compression instead of xz (and I anticipate it would save a significant amount of disk space).
Edit: I've managed to get ~50% size reduction using zstd, and that's with a relatively small amount of training data.  711kb for zstd vs 1.4mb for xz.  Both were running with maxinum compression on this set of files:
https://drive.google.com/file/d/1uWh83FDaIqMWqgojOhG_no6QOWcK0YyT/view

@aandergr  how can i read a json.xz file ?

@HCWcoder unxz FILE makes it a normal json file.

@HCWcoder unxz FILE makes it a normal json file.

@ealgase Can i know how to use it ?
sorry im new here

@HCWcoder A JSON file is just a text file, you can open it with a text editor to see the contents.
Most programming languages have libraries for using JSON files, if you're interested in doing that.

If i need to open the json.xz in python and read it how can i do it ? @ealgase
I tried searched everywhere nothing worked for me

@HCWcoder https://docs.python.org/3/library/lzma.html should help you.

I close this issue due to its inactivity and the low relevance of the suggested feature.


Enable the sessions to access the original cwd

Closes #469. Store the original cwd inside global_config, and then enable the sessions to get access to it.
CC @theacodes

@theacodes I supposed you want me to enable the access to the original cwd as an option for the CLI, right? Or do I have to do something different?

Tell me before I add more commits, please.

Oh, I think I should add this as a session property, as you suggested. I understand that the original cwd will be used like this:
nox --use-original-cwd

Is that true? Or should I do something else?

This was superseeded by #472.


Modified code to allow for images

Modified the doPost() function in the MessageServlet.java class to include image capabilities.
Modified the user-page.css file to restrict the image size
Updated Datastore index by adding a recipient field to the index.yaml file

Yes sure. A screenshot is attached below

@kyrabusser How do I check that Hannah's features still work? But I don't think I broke her code though 😆

Sounds like a good question for @hengelman ! Hannah, what should Stanley do to verify styled text?

@stanleynwakamma try inputting messages with any of the modifications allowed in whitelist.basic such as bold, underline, etc. Also I'm not sure but you might need to change it to .basicWithImages() to allow images but adding images works without that its probably fine

@kyrabusser @hengelman  I think everything works well. Please see my attachment above. thanks

@kyrabusser Please checkout commit 38696cd  Just fixed it. Thanks 😃

(Also, I love your example images! So cute! :smile: )


^ caret as default keybinding for bol

many of the other keybindings are inspired by vi.  why then use 0 for bol instead of ^ ?
don't mean to complain, wish i would've found TerminalPager earlier.  am loving it!

and TIL that 0 in vi does the same thing as ^ !!!


Torchvision Resnet 50 accuracy

Hey, Pytorch’s (torchvision) Resnet 50 accuracy is declared to be 76.15.
But when I’m using the training script from PyTorch’s repo, which is mentioned in the official torchvision website(https://pytorch.org/docs/stable/torchvision/models.html#classification):
[https://github.com/pytorch/examples/blob/master/imagenet/main.py]
and the Resnet50 from torchvision:
[https://github.com/pytorch/vision/blob/master/torchvision/models/resnet.py]
When training it, after one epoch I’m getting an accuracy of 76.6, how can it be? isn’t the models fully trained?
Thanks!

@fmassa Hi, I also found the problem that the reported error rates for ResNet50 and ResNet101 in the official torch vision website(https://pytorch.org/docs/stable/torchvision/models.html#classification) is higher than our re-trained results.  For example, group normalization reported a 22% top 1 error rate of  ResNet101 on ImageNet, which is 0.63% lower (I did the experiments and 22% can be achieved ). I think the results of group normalization are also trained from PyTorch?  So would you re-train the network to change the results?
Maybe the reported results from torch vision website did not use zero-gamma trick (use zero to initialize the last BN weights in each residual blocks). But the difference is not so big.

@KaiHoo the resnet-pretrained models didn't use the zero-initialization trick, and we don't provide pretrained models with group-normalization in torchvision.

@fmassa Sorry I did not make myself clear. The reported ResNet101 error rate with Batch Normalization in the GN paper is 22.0% (https://arxiv.org/pdf/1803.08494.pdf page 6 Deeper models. They use a batch size of 32 per GPU and 8 GPUs. All other training settings are the same as shown in the torchvision training scripts.)
As a reference,  Mixup: Beyond empirical risk minimization also shows that ResNet101 with Batch Normalization and without extra regularization can achieve a 22.0% error rate.
I understand the resnet-pretrained models didn't use the zero-initialization trick. But the difference should not be so big (0.64%). I believe it is beyond statistical significance.

Performance of resnet has gradually improved over time. The first officially-reported pre-trained weights for ImageNet for ResNet101 had a top1 error of 23.6, see https://github.com/KaimingHe/deep-residual-networks
So the zero-initialization trick (which was used in the GN paper) can give (on ResNet50) 0.5 top1 accuracy, see https://github.com/pytorch/vision/pull/498#issuecomment-398436396

Hi @fmassa,
I want to ask that which training type did you use for training ResNet on ImageNet - DP or DDP in examples/imagenet/main.py ?
Thanks.

I meet same problem as @KaiyuYue ,  for ResNet-50 I only got 75.806% with default settings , how to reproduce the torchvision.models performances ? @fmassa

@KaiyuYue @YYangZiXin IIRC the pre-trained models available in torchvision have the batch-norm statics recomputed after training is over, which gives slightly better accuracies. Those models have been trained a long time ago, and I'm afraid the code for doing the batch norm stats recomputation is lost, but it shouldn't be too hard to implement it.

@fmassa Could you give some details about the the re-computation? Is it computed over the whole dataset? Or it is achieved by forwarding with very large batch size? Thanks!

@hukkai I haven't done it myself, but I believe it was done over the whole train dataset.


V6 with external coreuiv4

This is https://github.com/Laravel-Backpack/CRUD/pull/4934 merged with https://github.com/Laravel-Backpack/CRUD/pull/4990

A new inspection was created.

The inspection completed: 797 Issues, 103 Patches


feat: progressbar lower jaw

Checklist:

[ ] I have read freeCodeCamp's contribution guidelines.
[ ] My pull request has a descriptive title (not a vague title like Update index.md)
[ ] My pull request targets the main branch of freeCodeCamp.
[ ] I have tested these changes either locally on my machine, or GitPod.

Closes #XXXXX

I can't figure out what the issue is here.

Thanks for working on this much demanded feature 👏. I was able to see the progress bar after a rebase and replacing completedPercent with a number.

Just a side note:
Since we have a progress bar in the modal. It would be better to turn that into an isolated component and use it in the modal and here.

We'll definitely want to provide this progress information to screen reader users as well. Whether we do this through the progress bar itself or hide it and provide sr-only text is the question. I'm not able to get this PR working locally at this time, but once it does work I'll do testing with various screen readers to see which one is best.


Docs: remove "Cloud" from resources that are not cloud-only

Changes "Prefect Cloud" to "Prefect" for resources that are not cloud-only.
Context: reported in a community Slack thread that Variables appeared to be Prefect Cloud only.
Related to https://linear.app/prefect/issue/PLA-452/cycle-5-catch-all

@mitchnielsen should we close this branch?

Ah thanks for the callout @parkedwards, didn't notice terraform docs had overwritten the changes. I pushed 8f6c724 so the changes are made in the source code, and then generated the docs changes.


NullReferenceException on OfflineSQLiteStore in UpsertAsync method

Describe the bug
I've came across an exception when playing with the TodoApp demo.
This exception is thrown in the OfflineSQLiteStore UpsertAsync method.
To Reproduce
I have made changes to the app and the schema of the Database so maybe this is my doing.
Expected behavior
I would have though the null reference should not be thrown.
What platforms?
ASP.Net Core 5.0.1
Xamarin.Forms, Android Emulator

Client (.NET, JavaScript, iOS, Android):

.NET Runtime Environment (WPF, UWP, Xamarin.Forms, etc.):
Library versions?
What platform versions are you running on?
Does it happen in an emulator / simulator, or only on a real device?

Screenshots

Additional context
The variable c is null for the column definition.
I am debugging this today to see why this happens and will report back.

It seems when using the JsonIgnore attribute one must use the same library. In my model I was using:
System.Text.Json.Serialization when I should have been using Newtonsoft.Json
At least this mistake highlighted a bug and hopefully can educate others, I never knew about this.
@adrianhall , I recommend updating the code as shown above and closing this issue.

I can see the bug - feel free to submit a PR if I don't get to it first.

@adrianhall , I've done a PR but it's my first one so not sure if I've don't it correctly.

I saw - thank you!  There is a style issue to fix, and a build issue I need to fix.
Welcome to the open source contributors community!


Introduce :pedantic? + dogfooding

Closes https://github.com/rm-hull/lein-nvd/issues/78

Introduce and satisfy :pedantic? option
integration_test.sh: remove useless step
Dogfood nvd-clojure and lein-nvd in integration_test.sh

Some vulnerable dependencies have been updated accordingly.

README: link to an example of the .json config file

Thanks!


chore: split node from CI

Problem
See https://github.com/waku-org/js-waku/issues/1548
Solution
Created a new workflow test-node that has the workflow_call and can be called from nwaku as well
Removed workflow_call and all extra conditions from the main workflow
Calling the new workflow for all node test jobs

Not sure why it appears 1 expected checks here. @weboko  do you know?


OHRI-799 Enrollment Form Revised to have 4 different sections

@kajambiya please make the PR to Dev and request my review


Fix OAuth 2.0 for Yahoo and AOL

Yahoo and AOL OAuth 2.0 was broken, because they removed support for plain Authentication Codes and authentication requests without any code challenge mechanism. Now they only support Authorization Codes with PKCE. As this is Mandatory To Implement (MTI) for OAuth servers according to RFC7636, we will enable it for all supported OAuth 2.0 providers.
Fixes: #7159 and #7132

Can you please test the other providers supporting OAuth to make sure they also work with this change. Just because something is mandatory according to the specification doesn't mean implementations actually support it :smile:

I tested all, should have written that to the description

when will the fixed version be released (yahoo)?
is it already out to users signed up to the beta version via google play store?


Add logging knobs in the config

Right now we export all the logs to the Google Cloud Logging. However, this can significantly impact the cloud bill.
This PR provides an optional logging knob to the user to specify the minimum level for a log entry to be exported to the Google Cloud Logging. Note that this option only applies to application logs. We'll continue to export all the services logs (e.g., controller, distributor, manager logs).
By default all app logs are exported. However, if the user wants to set a minimum log level for exporting logs, they can modify their gke config as follows:
weaver.toml
... [gke] telemetry.logging = {min_export_level = "WARN"} ...
This will export all logs with the level at least WARN, i.e., WARN and ERROR.

@mwhittaker do you mind reviewing this change?


Move ETL tool to custom plugin

To avoid compatibilty issues with installing two kube-prometheus-stack instances in the same cluster, we should move the data import tool to its own plugin instead of shipping it as part of the metrics.

Manual testing has begun. PR to follow

Closing in favor of solution described here: https://github.com/rancher/opni/pull/1210


SSID change via telnet?

Hello, sorry, the question is of course not about integration.
Tell me, is there any way to change the SSID of a wifi network via telnet?
I change in two files, but after rebooting the gateway still connect to the old wifi network.
There is no access to the gateway, only telnet, you need to change wifi.

I have no idea


Library name change request

Library repository URL
https://github.com/ultiblox/DisplayValueOLED.git
Rename to: UltiBlox-DisplayValueOLED

Hi @maker-zone . I am confirming your request.
Unlike submissions, this type of request is still handled manually. The Library Manager index maintainer occasionally comes through to clear all the outstanding requests. They will close this issue when it is done. You will get a notification from GitHub at that time.
After that, you can monitor the indexing of the library via its dedicated logs web page.
Information about that here:
https://github.com/arduino/library-registry/blob/main/FAQ.md#can-i-check-on-library-releases-being-added-to-library-manager

Done:
2024/11/12 14:53:58 Loaded 7463 libraries from DB
Removing UltiBlox DisplayValueOLED
Success!


No scaffolding being done on the Scaff10xV4

Hi,
I have been trying out scaffolding the pacbio contigs using scaff10x, using the latest version the version 4 uploaded last month.
I can see that the align* series files are empty, but the tool doesn't throw an error, nor does it do scaffolding. Please see the attached screenshot.

It seems during the update the tool names in the scaff-bin folder have been changed, but calling them in the main script seems to be done using the older names, creating the error. (I observed this for bwa).
This is the command I have been using:
~/Tools/Scaff10X/src/scaff10x -nodes 48 -longread 1 -gap 100 -matrix 2000 -reads 10 -score 20 -edge 50000 -link 8 -block 50000 final_MP_scaff.fa genome-BC2_1.fastq.gz genome-BC2_2.fastq.gz out.scaffolds.fa &
I'm also a bit unsure if this is because the genome is fragmented? Please see the stats below:
file    final_MP_scaff.fa
num_seqs        20896
sum_len 896879817
min_len 2002
avg_len 42921.1
max_len 1276294
Q1      14596
Q2      21642
Q3      37521
sum_gap 1782762
N50     86627
Edit: On closer look, it seems that for some reason the bwa indices are not being created.

I've just pushed an update with should have better error handling.  Could you try the latest version out.
BTW, unless you want to keep the barcode processed reads, it will be more efficient to list your 10x fq files in an input.fofn text file and pass that in with -data input.fofn.

Thank you for the update!
I did try having the list in the fofn and then pass it on. But I then broke down all the steps to see where the errors occurred!
I have manually generated the bwa indices and I'm currently doing the steps manually to further trouble shoot where the issues are.
I'll keep you updated.

I have the same problem!  I've been pulling my hair out thinking I've been doing something wrong.  It would be really brilliant to get this fixed.

Alright, I have finally a 10X dataset that I have to use to scaffold. These are the errors on the latest commit:
[main] CMD: /home/harish/Tools/Scaff10X/src/scaff-bin/bwa mem -t 30 tarseq.fastq /data/analysis/dr.n.v.singh/genome/10X/scaff/genome-BC2_1.fastq.gz /data/analysis/dr.n.v.singh/genome/10X/scaff/genome-BC2_2.fastq.gz [main] Real time: 43975.365 sec; CPU: 1319572.223 sec sh: -c: line 0: syntax error near unexpected token ('
sh: -c: line 0: mv genome.fasta /data/analysis/plant/genome/10X/scaff/(null)' Error running command: mv genome.fasta /data/analysis/plant/genome/10X/scaff/(null) Input target assembly file2: /data/analysis/plant/genome/10X/scaff/polished.fa Input read1 file: /data/analysis/plant/genome/10X/scaff/genome-BC2_1.fastq.gz Input read2 file: /data/analysis/plant/genome/10X/scaff/genome-BC2_2.fastq.gz /home/harish/Tools/Scaff10X/src/scaff-bin/bwa mem -t 30 tarseq.fastq /data/analysis/plant/genome/10X/scaff/genome-BC2_1.fastq.gz /data/analysis/plant/genome/10X/scaff/genome-BC2_2.fastq.gz | egrep tarseq_ | awk '($2<100)&&($5>=0){print $1,$2,$3,$4,$5}' | egrep -v '^@' > align.dat


rename UPDATE_LOCATION to CALL_HISTORY_METHOD

Following comments on #259.

I'm not sure keeping the old name is worth the confusion generated by introducing two actions.
Especially now that we encourage calling history methods directly, people relying on the old action and thinking they don't need to change their analytics code will have broken code because direct history calls will not invoke the new action.
I think CALL_HISTORY_METHOD might be the best choice here. It makes it clear this is not intended for analytics.

@gaearon

Also, let's not forget the the name already changed once in the past...

UPDATE_PATH is now UPDATE_LOCATION.

:kiss: Thank you!


Document API endpoints

closed as per https://github.com/vyahello/fast-weather-api/commit/dd73552443b62bdf7a49bb352c72608bda61a05d


I would like to join your team and contribute with my many years of experience and skills.

Hi, I'm Ethan Tan, a seasoned web full-stack and blockchain developer with over 8 years of experience in the industry. I specialize in building robust, scalable web applications and innovative blockchain solutions. Leveraging my expertise in frameworks like React.js, Vue.js, and Next.js, along with my proficiency in Solidity for smart contract development, I deliver high-quality, secure, and efficient solutions tailored to meet your specific needs.

Hey thanks for reaching out. We apologize for not being able to respond sooner.

Hello @johnsmith0212 ,
Thank you for sharing your expertise with us. We're interested in discussing potential collaboration opportunities further. Let's continue this discussion via email at<EMAIL_ADDRESS>Best regards,
Team DevEleven

-Contact Info
mail<EMAIL_ADDRESS>skype: https://join.skype.com/invite/FVUI6gLcYgAE
telegram: https://t.me/ethantan1116
slack: https://join.slack.com/t/ksc-xme4972/shared_invite/zt-2ld45idp2-G9HkxP_wX4ctwQshyPM7Ig
discord: https://discord.gg/VxnfdY4bS4


[5.10] Quick Navigation user should be able to tab from list of results to preview and use arrow keys within the list

Explanation: Improves keyboard navigation (AX) features in Quick Navigation
Scope: Quick Navigation
Issue: rdar://111742596
Risk: Low
Testing: Added/updated unit tests, tested manually with keyboard
Reviewer: @mportiz08
Original PR: https://github.com/apple/swift-docc-render/pull/736

@swift-ci test


Fixed crash on invalid standardsettings file

fixed a crash that occurs if the path in standardoptions.txt has invalid characters

Bro is farming with this one


Add dhall Prelude

Hey, I like this idea and thought it could benefit from a prelude to get some semantics on some of the list elements.
I'm using it like
-- ghc-options.dhall
let Prelude = ./Prelude.dhall

let W = Prelude.GhcWarning.Type

let Yes = Prelude.GhcWarningFlag.Type.Yes

let No = Prelude.GhcWarningFlag.Type.No

in  [ Yes W.Everything
    , No W.AllMissedSpecialisations
    , No W.ImplicitPrelude
    , No W.MissingSafeHaskellMode
    , No W.PrepositiveQualifiedModule
    , No W.Safe
    , No W.Unsafe
    ]

-- package.dhall
...
    , dependencies = Prelude.Prelude.List.map Prelude.Dependency.Type Text Prelude.Dependency.toText ./dependencies.dhall
    , ghc-options = Prelude.Prelude.List.map Prelude.GhcWarningFlag.Type Text Prelude.GhcWarningFlag.toText ./ghc-options.dhall

I used this project as a reference to write the prelude https://github.com/bgamari/dhall-gitlab-ci

Ok I didn't realise you could treat adts constructors lowercase and write them out. This changes things.

Thanks @locallycompact for the pull request.

@locallycompact I've just published hpack-dhall-0.5.3 with a better README. I'm interested in this pull request or its successor.


Plugin only supports the application variant

The plugin only allows Groovy files to appear in the application variant. This does not allow for Groovy to appear in libraries or tests. Support for the library and test variants would be awesome!

I am still getting this error with org.codehaus.groovy:gradle-groovy-android-plugin:0.3.6.  Is there a solution?

@IgorGanapolsky Yes, use 1.0.0

@pieces029 Not possible, I get an error:

Error:(25, 1) A problem occurred evaluating root project 'CrestronApp_Android'.
Failed to apply plugin [id 'groovyx.android']
You must apply the Android plugin or the Android library plugin before using the groovy-android plugin


 This should being some slight performance upgrade to rwkv.cpp and serve as a intermediate step before implementing GGUF support.

Wait. Closing. I based on a very of version...


Debugging

Error I had that could have been fixed a lot quicker with debugging: Extra back slash in http://<IP_ADDRESS>:8086/api/users/authenticate/

[ ] Start backend using Debugging

[ ] Set break point at the beginning of endpoint code

[ ] Start in frontend with split screen loading source for an API fetch using GET.

When trying to log in, I get a 404 error which means that the server could not find the requested web page.

[ ] Set break point on fetch, inside .then, inside .fetch

[ ] Run frontend, screen capture break at fetch while examining Body

[ ] Press play on frontend, observe stop inside of backend

[ ] Press step over on backend until you have obtained data from database, screen capture Python Object

[ ] Press play b

utton to end backend debugging session.

[ ] Return to frontend debug session

[ ] Step in until you see data, screen capture capturing break point and Data.

1.85/2 - The debugging is done on the login, not the Cpt. Overall, the debugging is highlighted well.

1.9 / 2 - The debugging is done on the login but it's done all the CPT project itself just not it's feature, but overall the breakpoints and debugging is good.

I don't really see step or data displayed in backend.


Simplify widget hiding with Magic Filters

Hi! I think aiogram Magic Filters can simplify code.
On render needs to create an object from data dict to pass into "magic" method and condition to separate callable and Magic Filter.
# Original

def is_tishka17(data, widget, manager):
    return data.get('name') == 'Tishka17'

Button(Const('Admin mode'), id='nothing', when=is_tishka17)

# Magic Filters

Button(Const('Admin mode'), id='nothing', when=F.name == 'Tishka17')

Thanks a lot 🙏


linux_local_container: Extract debs directly, don't use dpkg

Using dpkg is slow and error-prone. We were overriding enough dependency checking anyway that it makes more sense to just unpack the packages.

Changes Unknown when pulling e5900a510312670689a3f84abf3675aa60ea145c on smspillaz:polysquare-travis-container.local-container-extract-debs-directly into ** on polysquare:master**.


grpc blocking for ~10 seconds and reporting LEAKED OBJECT

Please answer these questions before submitting your issue.
Should this be an issue in the gRPC issue tracker?
Yes
Create new issues for bugs and feature requests. An issue needs to be actionable. General gRPC discussions and usage questions belong to:

grpc.io mailing list
StackOverflow, with grpc tag

Please don't double post your questions in more locations; we are monitoring both channels, and the time spent de-duplicating questions is better spent answering more user questions.
What version of gRPC and what language are you using?
1.10.1
What operating system (Linux, Windows, …) and version?
Linux
What runtime / compiler are you using (e.g. python version or version of gcc)
gcc 4.8.5
What did you do?
If possible, provide a recipe for reproducing the error. Try being specific and include code snippets if helpful.
Want to use Google Speech API via grpc.
My program does open multiple Speech::Stub's and grpc streamers at the same time, since we want to handle multiple transcription channels at the the same time.
It often happens, that during the close phase of a transcription channel the complete process get stuck for around 10 seconds. On GRPC log-level we see some "LEAK OBJECT" messages and we see tons of "TIMER CHECK BEGIN"  + "TIMER CHECK END" messages for this period of 10 seconds.
What did you expect to see?
No hanging thread for ~10 seconds ...
What did you see instead?
.. hanging thread/process for around 10 seconds.
.. and what do those "LEAK OBJECT" messages mean?
Make sure you include information that can help us debug (full error message, exception listing, stack trace, logs).
.. the attached log-file contains logging from my programm as well as from grpc.

Search for 2018-04-16 16:46:41,211 >> here the 10 seconds are over and you'll see the LEAK OBJECT messages
mediaserver.zip

Anything else we should know about your project / environment?

Please close this ticket I found the reason for this behavior and could solve it on my code-side ..


Make doxygen run on a the doxygen image instead

This is expected to make builds slightly faster (still not great because we also need graphviz, can add that later to the image too) and more consistent and not have errors like in #11463

Doxygen run completed, saw output of Doxygen version used: 1.9.2 (caa4e3de211fbbef2c3adf58a6bd4c86d0eb7cb8)

Hotfixing it in so that PRs depending on this can pass.


WIP: initial RMarkdown .Rmd support

Load .Rmd files with Jupytext.
This is to:

Ask whether this is the right way to go;
Act as a basis for better support.

xref #745.

Heya, yes and no; yes this will work for your particular use case, but when I implement it, I will make it more generic.

Any benefit in putting something like this in until you get to the more generic thing?

I'm +1 on making it possible to read in other jupytext-supported extensions (or just RMarkdown) into Jupyter Book, but for the time being treating it as an "advanced" feature that may change in the future and may have reduced functionality (e.g. we can't promise the conversion from RMarkdown is lossless, it's just a matter of whatever jupytext does). I think this could be a nice way for people used to the RMarkdown workflow to try out Jupyter Book even if it behaves unpredictably sometimes

Probably worth pointing out somewhere that the requirements.txt file needs jupytext in order for Binder / Jupyter to realize the .Rmd files are notebooks.   I guess you have this somewhere already for the MyST .md files.

I think we could add explanation about that (with "advanced usage" caveats) here: https://jupyterbook.org/content-types/jupytext.html

Any benefit in putting something like this in until you get to the more generic thing?

No sorry, but don't worry, I should have it done within the week 😄

(just pester me if you don't see anything in week or so)

I should have it done within the week

@chrisjsewell could you describe the broad contours of the more generic thing you have in mind? I do think this is relatively timely, because the jupyter book blog post caught the attention of a bunch of bookdown people, so I think there may be a momentary interest from RMarkdown users that won't last forever

https://nbsphinx.readthedocs.io/en/0.7.1/custom-formats.html


rex_pcre2 match function returns false. match(s,p) function

Is there an existing issue for this?

[X] I have searched the existing issues

Kong version ($ kong version)
3.7
Current Behavior
We have custom plugin using lrexlib-pcre2 (rex_pcre2) to do regex operations.
After upgrading to 3.7 that functionality stopped working and kong starts returning
{
 "message":"An unexpected error occurred",
 "request_id":"d8451b17c985a02685deb00aecd8587b"
}

I have tried update the libraries libpcre2-dev.
This functionality is working on 3.6 and other versions.
In 3.7 we have this change Bumped PCRE from the legacy libpcre 8.45 to libpcre2 10.43 and in 10.43 there are bugs reported: https://github.com/search?q=repo%3APCRE2Project%2Fpcre2+10.42&type=issues could be related.
Expected Behavior
rex_pcre2 match(s,p) returns match strings instead of response (false) on kong 3.7
Steps To Reproduce
No response
Anything else?
No response

@chronolaw @hanshuebner
Here is how you can reproduce it:
docker-compose 2.zip

docker-compose up --build
http://localhost:8080/jokes/random (since its on kong 3.7.1-ubuntu it will fail)
update the dockerfile base image to 3.6.1-ubuntu
again docker-compose up --build
http://localhost:8080/jokes/random will works.

What errors do you see in the error log?

What errors do you see in the error log?

I see the error only in the plugin logs. These logs might not help  the main problem is with rex_pcre2.match(s,p) function on 3.7. :
handler.lua:34: bad argument #3 to 'gsub' (string/function/table expected), client: <IP_ADDRESS>, server: kong, request: "GET /testing/jokes/random HTTP/1.1", host: "localhost:8080", request_id: "22a09c4b3c40f57a9103872366edeb75" compose-kong-1  | {"ts": "1720005095.334", "remote_addr": "<IP_ADDRESS>", "request": "GET /testing/jokes/random HTTP/1.1", "status": "500", "host": "localhost", "client_ip": "", "request_time": "0.024", "request_length": "793", "bytes_sent": "499", "upstream_bytes_received": "", "upstream_connect_time": "", "upstream_bytes_sent": "", "uri": "/testing/jokes/random", "upstream_response_time": ""}
so rex_pcre2.match(s,p) return false value unexpectedly and gsub failed because it was expecting string/function/table but it got bool.
These logs might not help  the main problem is with rex_pcre2.match(s,p) function on 3.7.

With Kong Gateway 3.7.0, we have switched from using libpcre 8.45 to libpcre2 10.43.  This means that pcre2 is loaded by Kong Gateway already and your problem likely is that you're using a regular expression library wrapper function that is incompatible with the version of pcre2 that is already loaded into Kong Gateway.  I would suggest that you update your plugin to use ngx.re.match instead.

Thanks for quick response @hanshuebner
I used ngx.re.match it return table and contain false instead of matching values:
local groups = {re.match(path, v.pattern)}   for k,l in pairs(groups) do          for k1,v1 in pairs(l) do                         kong.log.debug('value of l is: ' .. tostring(v1))                         kong.log.debug(k)                         replacement = string.gsub(replacement, "$" .. k,v1 )             end    end

I took your ZIP file, removed the lrexlib-pcre2 reference from the rockspec and the local re = require "rex_pcre2" from handler.lua and replaced the invocation of re.match by ngx.re.match.  This made the plugin work:
docker-compose-kong-1  | 2024/07/03 17:59:24 [debug] 1338#0: *3221 [kong] handler.lua:19 [dummy] re.match working

Please let us know if any problems remain.  If not, please close the issue.  Thank you.

I have tested..looks like its working. closing the issue. Thanks @hanshuebner

It failing for exact match eg:
local groups = {ngx.re.match("testing", "testing")} --> returns nil

The exact match is working on 3.6 libpcre 8.45.
we can reproduce it.
docker-compose up --build
docker-compose 2.zip

@muh-kamran , could you open a new issue for recent question? We can not figure out the correct context of it.

I've tried your docker-compose 2.zip file and things work for me there:
kong-1  | 2024/07/08 15:29:05 [debug] 1335#0: *3222 [kong] handler.lua:14 [dummy] maching value is:################
kong-1  | 2024/07/08 15:29:05 [debug] 1335#0: *3222 [kong] handler.lua:15 [dummy] table: 0x234a24979638
kong-1  | 2024/07/08 15:29:05 [debug] 1335#0: *3222 [kong] handler.lua:16 [dummy] nil

Its printing nil:
kong-1  | 2024/07/08 15:29:05 [debug] 1335#0: *3222 [kong] handler.lua:16 [dummy] nil
It should be the matching value.

FYI: the issue was on my end..
I was fetching the wrong index.. Adding a loop fixed it.


How to sort Tinkers' Construct tools and weapons?

I'm trying to get invTweaks to auto-sort my Iron Pickaxe into D1 and my Iron Rapier into D3 when I press R. Problem is, I've created these items using the Tinkers' Construct mod, and I have thus far been unable to figure out how to get it to work properly.
So far I've tried:
D1 pickaxe
D3 sword

D1 5575
D3 5580

D1 TConstruct:5575
D3 TConstruct:5580

D1 Tinkers' Construct:5575
D3 Tinkers' Construct:5580

But none of them seem to be working. It looks like invTweaks is not recognizing the items.
Am I doing something wrong, or is Tinkers' Construct somehow incompatible with invTweaks' sorting?

Hit F3+H to get the right names. TCon does put a lot of its info in
into places that inventory Tweaks doesn't know about, however, so attempting to make rules for them will be imprecise on material type at best.

Hitting F3+H tells me that the iron pickaxe is called TConstruct:pickaxe and the iron rapier TConstruct:rapier.
However, when I put the following into InvTweaksRules.txt and Ctrl+S:
D1 TConstruct:pickaxe
D3 TConstruct:rapier

and press R, it doesn't put the pickaxe and rapier in their specified slots. It seems to sort all the other items just fine though.
I'm running FTB Direwolf20 1.7.10 through Curse with InventoryTweaks-1.58-147.jar.
And just to clarify, I don't have any other pickaxes or rapiers in my inventory, so material discrimination is not an issue.

Ah, looking at it again I guess I never made it work with raw new-IDs in the rules -- try adding them to the tree.xml, probably in the same section as similar tools. Then you can use either the group they are in or the name you used for them there.

Thanks, doing it that way worked!
Are there any methods that InvTweaks could be updated with to have access to the material info, or would that just be opening a can of worms?

So i'm not sure how I'm suppose to add this to the tree.xml
I'm actually trying to add The Ender sword but next I plan to add tinker's construct to the sorting list as well


[Docs] The BottomNav page examples overwrap the top nav

Describe the bug

We need to either increase the z value for the top nav or decrease the z value for the examples.
Reproduction
https://flowbite-svelte.com/docs/components/bottom-navigation
Flowbite version and System Info
N/A

Solved.


Set basic functions for trivia

Pull Request Test Coverage Report for Build 30

140 of 409 (34.23%)  changed or added relevant lines in 30 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-12.3%) to 80.523%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/main/java/seedu/address/ui/MainWindow.java
2
3
66.67%

src/main/java/seedu/address/logic/parser/AddressBookParser.java
0
1
0.0%

src/main/java/seedu/address/model/card/exceptions/CardNotFoundException.java
0
1
0.0%

src/main/java/seedu/address/model/card/exceptions/DuplicateCardException.java
0
2
0.0%

src/main/java/seedu/address/model/UserPrefs.java
2
4
50.0%

src/main/java/seedu/address/MainApp.java
7
9
77.78%

src/main/java/seedu/address/model/card/Question.java
6
9
66.67%

src/main/java/seedu/address/commons/events/model/TriviaBundleChangedEvent.java
0
4
0.0%

src/main/java/seedu/address/model/TriviaBundle.java
14
19
73.68%

src/main/java/seedu/address/ui/BrowserPanel.java
0
5
0.0%

Totals

Change from base Build 29:
-12.3%

Covered Lines:
1571

Relevant Lines:
1951

💛  - Coveralls


Unable to begin superfluid donation stream using G$

Describe the bug
Unable to begin a donation stream using GoodDollar
To Reproduce
Steps to reproduce the behavior:

Go to GoodCollective Build
Attempt to donate using a superfluid stream with GoodDollar tokens
Attempt to confirm the transaction

Expected behavior
The transaction is executed and begins a screen
Screenshots

Error Code
Reason: An unexpected error occurred: Error: transaction failed [ See: https://links.ethers.org/v5-errors-CALL_EXCEPTION ] (transactionHash="0x02a83b70fed3f28698bbc6dd2b524a0d4436e0b15fb272f8e2020b3af339eb80", transaction={"hash":"0x02a83b70fed3f28698bbc6dd2b524a0d4436e0b15fb272f8e2020b3af339eb80","type":2,"accessList":null,"blockHash":null,"blockNumber":null,"transactionIndex":null,"confirmations":0,"from":"0x7B1a84b6546C7F8fe95fa4E94E4FD1b2eB040165","gasPrice":{"type":"BigNumber","hex":"0x02540be400"},"maxPriorityFeePerGas":{"type":"BigNumber","hex":"0x02540be400"},"maxFeePerGas":{"type":"BigNumber","hex":"0x02540be400"},"gasLimit":{"type":"BigNumber","hex":"0x124f80"},"to":"0xcfA132E353cB4E398080B9700609bb008eceB125","value":{"type":"BigNumber","hex":"0x00"},"nonce":27,"data":"0xe15536b600000000000000000000000062b8b11039fcfe5ab0c56e502b1c372a3d2a9c7a0000000000000000000000007b1a84b6546c7f8fe95fa4e94e4fd1b2eb04016500000000000000000000000011f18e8f2a27d54a605cf10486b3d4c5aeeba81f0000000000000000000000000000000000000000000000000000150d9925c7b400000000000000000000000000000000000000000000000000000000000000a00000000000000000000000000000000000000000000000000000000000000000","r":"0xdbe3372c155e3b2ce6237fd1621d4f9269fd9f4597f12d98463351534ee3547b","s":"0x37a01495b1ab731f1c62c9de84a973bce000a8e4d552cb2ffc19dc5d6879b32f","v":0,"creates":null,"chainId":0}, receipt={"to":"0xcfA132E353cB4E398080B9700609bb008eceB125","from":"0x7B1a84b6546C7F8fe95fa4E94E4FD1b2eB040165","contractAddress":null,"transactionIndex":1,"gasUsed":{"type":"BigNumber","hex":"0x01ff11"},"logsBloom":"0x00000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000","blockHash":"0xf4f01eb68e6ab08501b632d276973cb967f65a6009b104a6bb6e8b150928704d","transactionHash":"0x02a83b70fed3f28698bbc6dd2b524a0d4436e0b15fb272f8e2020b3af339eb80","logs":[],"blockNumber":25264187,"confirmations":3,"cumulativeGasUsed":{"type":"BigNumber","hex":"0x04a1c8"},"effectiveGasPrice":{"type":"BigNumber","hex":"0x02540be400"},"status":0,"type":2,"byzantium":true}, code=CALL_EXCEPTION, version=providers/5.7.2)

Was using an old build. CLosing


Failed to Minify the Code

When trying to update Semiotic to use a version of Rough that was not my own ES5 tenderized version I get the following error: Failed to minify the code from this file:  ./node_modules/roughjs/dist/rough.umd.js:1:220
Are there certain settings for babel and rollup necessary to build Rough in a project?

If rest of your code is ES6 then you can just import unbundled rough.js in your code and let your own build script deal with appropriate transpilations.
But, i also ship with an es5 bundled version now:
.../dist/rough.es5.umd.js
This is not the default module but you can try pointing your code to this file if you want to use the ES5 build

@emeeks  I am not sure if you ever solved this issue. I am not an expert in webpack, but from what I recall semiotic needed an es5 build - which roughjs now ships with /dist/rough.es5.umd.js

@pshihn I just installed the latest version of rough @4.0.4 and I am receiving this error when trying to build with rough in my library. I am building a project which passes roughjs into Semiotic, so thought it was relevant to the above thread.
`Creating an optimized production build...
Failed to compile.
Failed to minify the code from this file:
    ./node_modules/roughjs/bundled/rough.esm.js:1:71

`

@demartsc Not sure what the setup is. I suspect it's Webpack and I have no experience in it.
I can tell you that roughjs ships with following 3 bundled versions:
CommonJS: roughjs/bundled/rough.cjs.js
ESM: roughjs/bundled/rough.esm.js
Browser IIFE: roughjs/bundled/rough.js
When importing roughjs try the commonJS location.

Also look at setup of https://github.com/excalidraw/excalidraw - also a react app that includes and builds roughjs

I had the same issue with the cjs build. Seems to be a problem with minifying already minified code.
I worked around this issue by creating my own unminified build using rollup.
rollup --format cjs -i node_modules/roughjs/bin/svg.js -o client/utils/rough.js -p node-resolve

I added this to my postinstall task in package.json and ignored the resulting file in .gitignore
Another advantage of this is, that I now only have an svg-only-build, because I don't use the canvas one.
I advice to not minify by default but provide a minified version which really only makes sense for the Browser-IIFE build. For all other versions the consumer should take care of this.


Feat/update react query kit

What does this do?

update react-query-kit to latest version
update APIs to follow the structure expected by react-query-kit latest version

Why did you do this?

to benefit from the latest updates of react-query-kit

How did you test this?

locally

@ElenaBitire Can you please update the documentation and snippets for queries


Thumbnail quality options

I'd like to add additional configuration options around thumbnail generation. Primarily, I'd like to support the following:

JPG, JPEG-XL, WEBP export format (currently only WEBP)
Customizable scale factor (0-1, default currently is 0.75)
Customizable dimensions (maybe, might be too much of a hassle)

I will need to decide whether this should be library or server level options.
General tasks:

[ ] Create generalized wrapper function in my image crate that handles the conversion

[ ] should accept the options selected from user

[ ] Update WEBP conversion to accept options
[ ] Create functions to convert buffer to:

[ ] JPG
[ ] JPEG-XL
[ ] WEBP
[ ] PNG

I can take it

Hey @berkingurcan thanks! Sorry for the late reply, been extra busy lately. Here you'll find all of the image thumbnail generation logic.
Essentially, what I was thinking was to update what's there, and add a few new functions for the new formats, to allow future custom scaling options. Something like:
/// The size factor to use when generating a thumbnail. This can be a
/// scaled factor, where the height and width are scaled by the same factor, a
/// a custom factor, where the height and width are scaled by different factors,
/// or a specific size, where the height and width are set to the specified size.
///
/// All floats are clamped to the range [0.0, 1.0].
pub enum ThumbnailSizeFactor {
	Scaled(f32),
	CustomScaled((f32, f32)),
	Sized((u32, u32)),
}

/// The format to use when generating a thumbnail.
pub enum ThumbnailFormat {
	Webp,
	Jpeg,
	JpegXl,
	Png,
}

pub struct ThumbnailConfig {
	pub size_factor: ThumbnailSizeFactor,
	pub format: ThumbnailFormat,
}

impl Default for ThumbnailConfig {
	fn default() -> Self {
		Self {
			size_factor: ThumbnailSizeFactor::Scaled(0.5),
			format: ThumbnailFormat::Webp,
		}
	}
}

So the thumbnail functions would take a reference to a ThumbnailConfig that controls some of the hard coded values throughout that file. It might be worth while to consider splitting my image.rs into a crate with multiple modules per format, and have some sort of factory pattern for uniformity. E.g:

image/jpg.rs

from_path
from_bytes

image/png.rs

from_path
from_bytes

etc

But, I'll leave that up to you. I think for now you can leave the jpeg-xl format alone, since it would require pulling in https://github.com/inflation/jpegxl-rs, but if you want to try it feel free.

Resolved from https://github.com/aaronleopold/stump/pull/134


Reference errors when running client in node app

I am running into ReferenceError errors when trying to use the @streamerbot/client inside of a simple Node app. Specifically, WebSockets, and sometimes Crypto, can't be found. Hopefully I'm just missing something simple.
The Code
This is the entirety of the code I am trying.
import { StreamerbotClient } from '@streamerbot/client';
const sbClient = new StreamerbotClient();
const myActions = await sbClient.getActions();

The Error
When running it, I get the following error:
file:///sb-client/node_modules/@streamerbot/client/dist/index.js:154
  return `sb:client:req:${Date.now()}-${crypto.getRandomValues(new Uint32Array(12))[0]}`;
                                        ^

ReferenceError: crypto is not defined
    at generateRequestId (file:///sb-client/node_modules/←[4m@streamerbot←[24m/client/dist/index.js:154:41)
    at StreamerbotClient.<anonymous> (file:///sb-client/node_modules/←[4m@streamerbot←[24m/client/dist/index.js:336:14)
    at Generator.next (<anonymous>)
    at file:///sb-client/node_modules/←[4m@streamerbot←[24m/client/dist/index.js:37:61
    at new Promise (<anonymous>)
    at __async (file:///sb-client/node_modules/←[4m@streamerbot←[24m/client/dist/index.js:21:10)
    at StreamerbotClient.request (file:///sb-client/node_modules/←[4m@streamerbot←[24m/client/dist/index.js:334:12)
    at StreamerbotClient.<anonymous> (file:///sb-client/node_modules/←[4m@streamerbot←[24m/client/dist/index.js:487:25)
    at Generator.next (<anonymous>)
    at file:///sb-client/node_modules/←[4m@streamerbot←[24m/client/dist/index.js:37:61

I also ran multiple iterations of npm install to try and make sure things were installed

npm install
npm install @streamerbot/client
npm install crypto
npm install ws

Thank you in advance! Again, hopefully it's something simple I'm missing.

Thanks for the detailed report!
This has been fixed with v1.0.1


do fine tuning with my own image size

I would like to do transfer learning and fine tuning with some pretrained model in tensorflow.contrib.slim. I searched some examples about this. However, almost all of these examples will resize images to the specified size that the model needs. For example, 224×224 is the size that vgg16 needed. Will it be possible to set my own image size? Like 512×512. In keras, I can do this like following:
`base_model= VGG16(include_top=False, input_shape=(512, 512, 3))`

Up till now, I have not found the solution, can this be down in tensorflow and slim?

That sounds like a question for stackoverflow; please close this issue here. Thanks!


New model for codec instances (work in progress)

This is still messy and undocumented, but I wanted to post it for comparison with the older approach.
I fixed the tests for scodec, but not core, and not the benchmarks.

Looks fantastic! :+1:

Do you mind to merge this so I can start working on benchmarks?

Don't mind, that sounds good to me, thanks. I'm going to polish the exception encoding business a bit and then start on expanding the tests (unless you have other ideas?).

I'm going to kill pickling stuff and continue working on benchmarks.


Cast shouldn't be necessary inside if that checks type of a property.

Example

This is working as specified. Unfortunately, type promotion, as defined by the specification, doesn't handle this case:
if (a.value is B) {
  print(a.value.message);
}

It only allows the type of variables to be promoted. That means that it will handle a slightly modified case:
var value = a.value;
if (value is B) {
  print(value.message);
}

but not the one you care about.

Is there a technical limitation to this, or is it just the spec which is the limiting factor?

Yes. It's the specification, but the specification is limited because it's hard to specify when it's safe to know that the value of a field of an object won't have changed between the type test and the reference to it later in code.

Ah ok good point, I can see how that would be difficult :)

Imagine if a.value is a getter that randomly returns different types :)


Update 6. Developer Guides/REST API/Users/update.md

Add password update information and correct optional fields.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Endless loop when discard changes inside a notebook

open notebook
make inline chat changes
select "Discard"
🧊 the editor will freeze, stuck in an endless loop in _undoModelUntil

This doesn't reproduce but I had this with insiders and I could see that canUndo would return true and undo wouldn't do anything, e.g it would not change the alternative version id.
@rebornix This is notebook specific and the debugger did show me that parts of undo seems to be async. I wonder if this should be exposed in the undo-method that I am calling and that's the cause for this

I did a quick look at the source code in UndoRedoService.canUndo and that looks OK to me. @jrieken TextModel.undo() returns void | Promise<void>. I notice the loop doesn't await the result in case a promise is returned. Could that be the right fix here?

I missed it returning a promise. Might be the right fix here but I also wasn't able reproduce and only debugged this from insiders once.


disable background when menu is opened

i am showing listivew with floating menu. on clicking list items, i am showing details about it. and when menu is opened, listview should not be work. which is working right now. please make it correct.

Please try this: FloatingActionMenu.setClosedOnTouchOutside(true).

yeah it works on for click but i am using longpress on list item.
On 15 Jun 2015 13:37, "Dmitry Tarianyk"<EMAIL_ADDRESS>wrote:

Please try this: FloatingActionMenu.setClosedOnTouchOutside(true).
—
Reply to this email directly or view it on GitHub
https://github.com/Clans/FloatingActionButton/issues/66#issuecomment-111973117
.

I've just checked. OnItemLongClickListener works just fine with the FloatinActionMenu opened for me.

For me, this does not work at all. Using a FAB in a RelativeLayout or in an FrameLayout does make no difference, the FAB is on top, but when opened, the background is always touchable...

Congrats mate!, you really did a nice job!.
Well im facing a similar situation using the option FloatingActionMenu.setClosedOnTouchOutside(true). however the fab menu close only if i clicked close to it. not if i clicked on the list view. do you have any idea of what could be happened? I will attach an image of a part of my activity_main probably is related to the way how i created.

I had the same problem... The menu has to somehow catch the click, so use match_parent for width and height instead of wrap_content...  Otherwise it will only wrap the expanded content, which mostly is not enough...

Yes. FloatingActionMenu is a ViewGroup so set its width and height properly.


Enable to handle Workload Identity

Workload Identity is released as a new way to auth in this January.
This crate couldn't auth with Workload Identity.
To use Workload Identity, we have to get access token from Google server like this:
$ curl -s -H 'Metadata-Flavor: Google' http://metadata/computeMetadata/v1/instance/service-accounts/default/token

ref: https://github.com/vmware-tanzu/velero/issues/1657#issuecomment-514688510

Thanks ! That's true, this was a really ugly change.
I introduced with_workload_identity without changing public API.
Could you review again ?

Thanks for this quick update. I just had a quick look at the code and it looks good to me. I will spend a little more time after my day job to merge the code and publish a new version of this crate.

Thanks for your contribution. The version 0.9.1 is now available on crates.io


C#: Fix signature of generated signal callbacks

Use long and double types since signals currently only support 64-bit types.
Fix bug for checking if the type name is a class registered in ClassDB.
Closes https://github.com/godotengine/godot/issues/67009.

Partly addresses C#: Area3D node error calling from signal "input_event" - Method not found #67009.

I guess it can close it fully, the confusing "Method not found" part can be tracked in #35910.
Probably also needed for 3.x?

Probably also needed for 3.x?

The ClassDB check should be backported, but I believe Godot 3.x uses 32-bit types for scalar Variants.

I believe Godot 3.x uses 32-bit types for scalar Variants.

Variant::INT and Variant::REAL are int64_t and double respectively:
https://github.com/godotengine/godot/blob/ec21ac518a2f9407febbfdd377fca1a0dc798e35/core/variant.h#L155-L156
The other vector and poolarray types are 32-bit though.

Then now I'm wondering why we marshal them as 32-bit types in variant_to_mono_object:
https://github.com/godotengine/godot/blob/ec21ac518a2f9407febbfdd377fca1a0dc798e35/modules/mono/mono_gd/gd_mono_marshal.cpp#L474-L486
But it's likely we don't want to make this type of change in 3.x.

Then now I'm wondering why we marshal them as 32-bit types in variant_to_mono_object:
https://github.com/godotengine/godot/blob/ec21ac518a2f9407febbfdd377fca1a0dc798e35/modules/mono/mono_gd/gd_mono_marshal.cpp#L474-L486
But it's likely we don't want to make this type of change in 3.x (see #39629 (comment)).

That would break compat in 3.x, and I'd prefer not to do that.

Partly addresses C#: Area3D node error calling from signal "input_event" - Method not found #67009.

I guess it can close it fully, the confusing "Method not found" part can be tracked in #35910.
Probably also needed for 3.x?

Is this error still a thing on latest Godot 4? My guess is that, as long as the parameter count matches, the method will be called and the Variant will be adapted to the parameter type, similar to the way it works in C++.

My guess is that, as long as the parameter count matches, the method will be called and the Variant will be adapted to the parameter type

That is correct. But I think the issue is that having a parameter count mismatch and getting a "Method not found" error, while accurate, is kind of vague and may be difficult to understand for users.
See, for example, this issue that was recently opened https://github.com/godotengine/godot/issues/69519. From the error message, the user thought that there was a bug in Godot because it couldn't find the method even though the method "exists" (the user doesn't see a method with a different signature as a different method).
If instead we were using the error that is used in GDScript, the error would be much friendlier since it explains that the issue is that the parameters don't match:
ERROR: Error calling method from CallbackTweener: 'Node3D(Node3D.gd)::foo': Method expected 1 arguments, but called with 0

If instead we were using the error that is used in GDScript, the error would be much friendlier since it explains that the issue is that the parameters don't match:
ERROR: Error calling method from CallbackTweener: 'Node3D(Node3D.gd)::foo': Method expected 1 arguments, but called with 0

GDScript can easily do that because it doesn't allow method overloading. In our case it's harder and it may add overhead.

It'd most likely add overhead, but maybe we can do it only in Debug. Not sure if it'd be a good idea to print different errors in Release than in Debug though.
Either way, I was just trying to explain the issue (https://github.com/godotengine/godot/issues/35910), it's not about using the wrong parameter type but about the message being confusing to users when a method does exist but the parameter count does not match.


Update docs for layout

For nodes, arcs and geos docs, we should put layout inside of the types.custom_type_key_*.layout. For example purposes it should never be in data (although we do support it - it is the exception and not the norm). We should also remove the old order keys in the docs when they are not relevant anymore. Similarly, all examples should only put value in the end of each prop and everything else should be in types.
For panes, naturally the layout would go at the same level as the props.

Closing with https://github.com/mit-cave/cave_app/commit/9ae43d4375f704fd059784d06502fe637cdab0e7


Small error in diagram: preserving_state_increment.png

Hi! I was reading the Preserving and Resetting State chapter and I noticed the diagram "preserving_state_increment.png" (dark variant here) has a small defect. Currently, it looks like it should display both child components: "Counter" but the second one is named "Count". I'm more than happy to fix this, but I don't know which tools are being used for diagramming.

cc: @rickhanlonii

Can I do this in photoshop?

Can I do this in photoshop?

Seems like a good solution haha, though who knows if the React team keeps the diagrams somewhere.


⚠ ClamAV has degraded performance

In e2ab207, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 212 ms

Resolved: ClamAV performance has improved in 381a30b.


Redux: Best way to architect reducers

Suggested by user luckyleprechaun98 over Reddit (https://www.reddit.com/r/SideProject/comments/58antx/react_casts_weekly_short_videos_with_tips_tricks/)

Other relevant info:

Redux docs on "Structuring Reducers": http://redux.js.org/docs/recipes/StructuringReducers.html
Articles on Redux architecture: https://github.com/markerikson/react-redux-links/blob/master/redux-architecture.md


Rotary

Lihuiyu rotary panel shows up blank. Others too.

They were flagged as hidden. This seems in error. I removed the flag.