Add special case for Linear pipeline input

Should handle cases like
10000
01000
00100
00010
00001

What happen on those cases in the actual code?

@gerarq Thank You for your interest
Currenty it prints blank -

And the MAL and the Throughput comes out to be 1. Though it should be irrelevant in this case.

I see, i would be happy to help you i will only need a bit o background on this matter, so what we expect to be the output, to start working on it.

@gerarq I think it would be a good idea if it outputs Throughput effective for Linear Pipelines.
Well the first step would be to detect if its a Linear Pipeline though.

Ok i'll start on that

OK @gerarq go ahead


fix: prevent route duplication by switching to navigate for CallScreenPageRoute

Task linked: CU-86956pyy9 Fix navigation to active call


I often encounter situations where the model is in free fall. when I do something or when there is no action it falls freely

This could be useful for you: https://github.com/pmndrs/ecctrl/issues/26#issuecomment-1881925148
Or you could sleep the character when there is no interaction with the web page

I have also experienced similar issues. I wonder if there is a recommended solution for this.

@Dukeyeboah , You could find solutions here: https://github.com/pmndrs/ecctrl/issues/26#issuecomment-1881925148
Or you could follow my example app (delaying the physics when app start or putting the character to sleep when there is no interaction)


Palette: Make all properties virtual & Improve docs

Description

Add file copyright headers
Improve and simplify documentation
Make all remaining properties virtual that weren't already

How Has This Been Tested?

Type of Changes

[ ] Bug fix (non-breaking change which fixes an issue)
[X] New feature (non-breaking change which adds functionality)
[x] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation (fix or improvement to the website or code docs)

Checklist

[X] The PR is submitted to the correct branch (dev).
[X] My code follows the code style of this project.
[ ] I've added relevant tests.

You now get all the good stuff from Records (comparison, etc) and can do this:

I think you need to give more explanation about why this change is useful. Otherwise, it sounds like we should switch all classes to records just because "we get good stuff." I just don't see how this change is being utilized in our code.
Also, isn't a record mainly for making immutable data, because by default the properties in records are get and init when you declare them in the constructor? Here, we have get and set properties.

@ScarletKuro I don't want to duplicate my palette styles
MudTheme _theme = new()
    {
        PaletteLight = new PaletteLight()
        {
            Primary = "#776be7",
            PrimaryLighten = "#978dec",
            Info = "#776be7",
            AppbarText = "#ffffffe6",
            Background = "#f7f6fb",
            TextDisabled = "#424242",
            HoverOpacity = 0.1,
        },

        PaletteDark = new PaletteDark()
        {
            Primary = "#776be7",
            Info = "#776be7",
            AppbarText = "#ffffffe6",
            TextPrimary = "#ffffffcc",
            TextSecondary = "#ffffff99",
            TextDisabled = "#ffffffb2",
            HoverOpacity = 0.1,
        },
}

    Palette _basePalette = new()
        {
            Primary = "#776be7",
            Info = "#776be7",
            AppbarText = "#ffffffe6",
            HoverOpacity = 0.1,
        };

    MudTheme _theme = new()
        {
            PaletteLight = _basePalette with
            {
                PrimaryLighten = "#978dec",
                Background = "#f7f6fb",
                TextDisabled = "#424242",
            },

            PaletteDark = _basePalette with
            {
                TextPrimary = "#ffffffcc",
                TextSecondary = "#ffffff99",
                TextDisabled = "#ffffffb2",
            },
}

Though I should have made Palette non-abstract

What's wrong with data classes being turned into records?

Nothing at all. I just want to know your use case for this change. Are we making this change for fun, or is there a good reason? This is a breaking change at both the API and ABI levels, since records can only inherit from other records. Therefore, if people have their own classes inheriting from it, they will need to change those to records as well. That's why I'm asking if this change is worth making, considering it is a breaking change.

Should the palette be immutable since it's only used once, right? 🤷

Yes, I think it should be immutable.
Since you changed it to a record, it's another reason to make this immutable. Even though record allows mutable properties, I believe the main idea behind records is to make immutability easy and fast, along with the with syntax. Also, the GetHashCode should always work only with readonly/immutable properties. In your code, this is not the case, which means it's not good code.

Your edits for simpler docs are spot on! Is there a need for a palette for colorblind folks? If so, I think I could put one together with someone to help test. (A different PR of course)

@jperson2000 I definitely have accessibility concerns about certain contrasts in the default palette (ex: the text is way too gray) which I have to address in my own apps. I don't know if changing that is acceptable but I bet a separate one for color blindness would be. Maybe we can work something out - cc @henon

+1 on immutability. Shall we make this change in the next major version together with other theming changes?

+1 on immutability. Shall we make this change in the next major version together with other theming changes?

Wise idea
@henon @ScarletKuro  I've updated the PR to exclude record changes so it should be easy to merge now

+1 on immutability. Shall we make this change in the next major version together with other theming changes?

Feel free to add to v8 project.


How do you respond to a private message?

AccountManager#reply() previously used to accept PrivateMessage, which made it possible to reply to them. What's the alternative to this in v1.0? Is InboxReference#compose() what I'm supposed to use?

I must have forgotten that POST /api/comment also lets you reply to PMs. I'll add InboxReference#reply

Ah okay. Do you also plan to introduce abstractions like PrivateMessage and CommentMessage again instead of just Message?

I don't think its necessary. The only difference between PrivateMessage and CommentMessage is two additional methods in CommentMessage. The new combined class and its isComment() method should be good enough to distinguish the two.

There are more actually. There's link_title for comments and replies for private messages. But I'm okay having nullable functions for them for now.


dosbox-x failed to build on OS X 10.11

I can't upload gist-logs; brew gist-logs dosbox-x gives the same error seen by the user in https://github.com/Homebrew/homebrew/issues/50180 (which I think is https://github.com/Homebrew/homebrew/pull/49846/files).
I have run brew update and brew doctor twice each, and also made sure to manually brew upgrade any dependencies of the package.
I have the latest non-beta XCode (7.2.1), with the CLT, and xcode-select --install tells me error: command line tools are already installed, use "Software Update" to install updates.
I have the latest version of XQuartz (2.7.8), and I verified that /usr/local/X11R6 as well as /usr/local/X11 got linked.
When I try to install, here's what I get:
$ brew install dosbox-x
==> Installing dosbox-x from homebrew/games
==> Downloading https://github.com/joncampbell123/dosbox-x/archive/v0.801.tar.gz
Already downloaded: /Library/Caches/Homebrew/dosbox-x-0.801.tar.gz
==> ./configure --prefix=/usr/local/Cellar/dosbox-x/0.801 --disable-sdltest --en
==> make install
Last 15 lines from /Users/abarnert/Library/Logs/Homebrew/dosbox-x/02.make:
clang++ -DHAVE_CONFIG_H -I. -I../..  -I../../include -I/usr/local/include/SDL -D_GNU_SOURCE=1 -D_THREAD_SAFE  -g -O2 -std=gnu++11 -Wall -mmmx -msse -msse2 -D_FILE_OFFSET_BITS=64 -Wno-strict-aliasing  -c -o midi.o midi.cpp
clang++ -DHAVE_CONFIG_H -I. -I../..  -I../../include -I/usr/local/include/SDL -D_GNU_SOURCE=1 -D_THREAD_SAFE  -g -O2 -std=gnu++11 -Wall -mmmx -msse -msse2 -D_FILE_OFFSET_BITS=64 -Wno-strict-aliasing  -c -o direct3d.o direct3d.cpp
clang++ -DHAVE_CONFIG_H -I. -I../..  -I../../include -I/usr/local/include/SDL -D_GNU_SOURCE=1 -D_THREAD_SAFE  -g -O2 -std=gnu++11 -Wall -mmmx -msse -msse2 -D_FILE_OFFSET_BITS=64 -Wno-strict-aliasing  -c -o hq2x_d3d.o hq2x_d3d.cpp
clang++ -DHAVE_CONFIG_H -I. -I../..  -I../../include -I/usr/local/include/SDL -D_GNU_SOURCE=1 -D_THREAD_SAFE  -g -O2 -std=gnu++11 -Wall -mmmx -msse -msse2 -D_FILE_OFFSET_BITS=64 -Wno-strict-aliasing  -c -o sdl_gui.o sdl_gui.cpp
clang++ -DHAVE_CONFIG_H -I. -I../..  -I../../include -I/usr/local/include/SDL -D_GNU_SOURCE=1 -D_THREAD_SAFE  -g -O2 -std=gnu++11 -Wall -mmmx -msse -msse2 -D_FILE_OFFSET_BITS=64 -Wno-strict-aliasing  -c -o menu.o menu.cpp
clang++ -DHAVE_CONFIG_H -I. -I../..  -I../../include -I/usr/local/include/SDL -D_GNU_SOURCE=1 -D_THREAD_SAFE  -g -O2 -std=gnu++11 -Wall -mmmx -msse -msse2 -D_FILE_OFFSET_BITS=64 -Wno-strict-aliasing  -c -o DelayReverb.o DelayReverb.cpp
In file included from menu.cpp:25:
/usr/local/include/SDL/SDL_syswm.h:58:10: fatal error: 'X11/Xlib.h' file not found
#include <X11/Xlib.h>
         ^
1 error generated.
make[2]: *** [menu.o] Error 1
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [install-recursive] Error 1
make: *** [install-recursive] Error 1

READ THIS: https://git.io/brew-troubleshooting
If reporting this issue please do so at (not Homebrew/homebrew):
  https://github.com/Homebrew/homebrew-games/issues

Trying to install --HEAD produces the same error.

I think I solved it.
My SDL 1.2.15 was built manually. I ran brew reinstall sdl to get the El Capitan bottle, and now dosbox-x builds.
I have no idea what's different between the local build and the bottle. It may have something to do with the local build being built against an older Xcode/CLT or XQuartz?

We'll accept PRs for this but we're not actively working on it at this time.


farmerbot log report node as certified

Why is the farmerbot.log says that my node is certified while it's not.

markdown file

https://gridproxy.dev.grid.tf/nodes/69

Can I see your configuration file? The .md file. The only way that certified is set to true is because of the configuration file. Did you  set certified to yes in the configuration file?

Hi. I see what is wrong here. Could you set the value to false please?

I modified the code to also recognize "no" in the arguments. Can you please use the new docker-compose file from https://github.com/threefoldtech/farmerbot/blob/development/docker-compose.yaml and try again?

Verified.
So I deleted the log file and run docker compose rm -f -s && docker compose up -d, and it was fixed


Reject transactions with insufficient gas

Emulate what happens when trying to send a Ropsten transaction with a gas limit of zero:
{"code": -32000, "message": "intrinsic gas too low"}

Related:

#16
https://github.com/aurora-is-near/aurora-engine/issues/119

Would like to help in this.

@artob I experienced this error when I used with a gasLimit 20k. So I can confirm that it works.


Ensure merge workflow exports AnnData for multiplexed samples

While looking into https://github.com/AlexsLemonade/ScPCA-admin/pull/823#issuecomment-1952781648, it has become clear that merge.nf has actually never properly exported AnnData files at all for multiplexed projects.
This can be seen here:
// mimics merge_sce.out
merge_sce_out = Channel.from(["/nextflow-ccdl-data/work/c0/f8f45d984a4e92a6d3083f7f25ef92/SCPCP999990_merged.rds", "SCPCP999990", "false", "true"])

// next step in workflow:
//  anndata_ch = merge_sce.out
//      .filter{!it[3]} // remove multiplexed samples before export
//      .map{it.take(3)} // keep everything but multiplexed logical

merge_sce_out
  .filter{!it[3]}
  .view() // it's empty.

Since merge_sce.out doesn't contain samples, it just contains project ids, we're losing projects that have any multiplexed samples altogether. This means the anndata_ch ends up being empty and we don't actually run the anndata export step at all. I recall being confused by this a while back (see discussion in https://github.com/AlexsLemonade/scpca-nf/pull/652)... The thing is, we don't want to remove SCEs that are multiplexed - we just don't want to export their altexp too!
Proposed (likely) solution
We should do what I originally thought we should do - just delete .filter{!it[3]} and keep only  .map{it.take(3)}:
 anndata_ch = merge_sce.out
  .map{it.take(3)} // keep everything but multiplexed logical

Then, I'm fairly sure the anndata process itself should work as expected. The had_adt value will be false, so the altExp will not get exported to AnnData, only the main SCE rna counts. I'm running this through now to confirm!

Sorry I think I got confused with your comment in the test data. We do not convert multiplexed data to AnnData and don't support it for either individual or merged objects. I was concerned there was no output but that's because one of the libraries was multiplexed. So I think the fix actually needs to be made there and we should have a project with multiplexed that has no other samples, a project with cite, and a project without either.
Apologies again for the confusion but not producing a multiplexed merged AnnData object was intentional.

Ooook everything makes more sense now!

We do not convert multiplexed data to AnnData and don't support it for either individual or merged objects.

Good, this is what I thought, but I thought from your comment next door I was wrong about this!
So everything is indeed fine here!


implement mTLS

Proposal to implment mTLS authentication within Concourse Web

Is anyone able to help with this?  It seems to be stuck?

This is quite similar to the work I did on concourse/concourse#6017.
It generally seems on the up-and-up to me, but usually I go by the checks to make sure I'm not breaking anything.
 If we have ATC or workers reaching out to this, it would mean provisioning certs for them too. There was also a different approach discussed in concourse/concourse#578 , but I personally think it's better practice to do blanket mTLS over limiting it to certain paths.
I'm not sure I understand, why this is written as an RFC and not simply a PR? This proposal does not change anything fundamental to Concourse's approach to authentication. I'm not sure this requires an RFC.

Hi,
I ended up doing this as an RFC as we weren't sure about the process.
With respect to the scope, we only wanted to lock down the interface between a proxy and concourse to avoid issues around proxies being misconfigured and, for example, test and production systems end up getting interconnected in error.

@nickhyoti Thanks for doing a PR, and sorry for the confusion! I've updated the README to be much clearer around when the RFC process is necessary. I'll close this out since the feature has already been merged, and I don't think an RFC is needed for this. :)


add workflowInjectables to unittest dependencies

This is part of fix for https://github.com/RackHD/RackHD/issues/138
if the workflowInjetables are not added into the unit-test dependencies, then it bring much difficulty to every unit-test file if it depends on those modules that stored in workflowInjectables.
@RackHD/corecommitters @iceiilin @WangWinson @cgx027 @pengz1 @sunnyqianzhang

:+1:

:+1:

:+1:

test this please

*** BUILD #337 ***
Test Name: test_workflowTasks_put
Error Details: Snmp Discovery Collect != fn_1
-------------------- >> begin captured logging << --------------------
tests.api.v1_1.workflowTasks_tests: INFO: Adding workflow task : {'friendlyName': 'fn_1', 'injectableName': 'in_1', 'properties': {}, 'options': {}, 'implementsTask': 'im_1'}
--------------------- >> end captured logging << ---------------------
Stack Trace:   File "/usr/lib/python2.7/unittest/case.py", line 331, in run
    testMethod()
  File "/usr/lib/python2.7/unittest/case.py", line 1043, in runTest
    self._testFunc()
  File "/usr/local/lib/python2.7/dist-packages/proboscis/case.py", line 296, in testng_method_mistake_capture_func
    compatability.capture_type_error(s_func)
  File "/usr/local/lib/python2.7/dist-packages/proboscis/compatability/exceptions_2_6.py", line 27, in capture_type_error
    func()
  File "/usr/local/lib/python2.7/dist-packages/proboscis/case.py", line 350, in func
    func(test_case.state.get_state())
  File "/var/lib/jenkins/jobs/on-core/workspace/RackHD/test/tests/api/v1_1/workflowTasks_tests.py", line 84, in test_workflowTasks_put
    assert_equal(readFriendlyName,self.workflowTaskDict.get('friendlyName'))
  File "/usr/local/lib/python2.7/dist-packages/proboscis/asserts.py", line 55, in assert_equal
    raise ASSERTION_ERROR(message)
"Snmp Discovery Collect != fn_1\n-------------------- >> begin captured logging << --------------------\ntests.api.v1_1.workflowTasks_tests: INFO: Adding workflow task : {'friendlyName': 'fn_1', 'injectableName': 'in_1', 'properties': {}, 'options': {}, 'implementsTask': 'im_1'}\n--------------------- >> end captured logging << ---------------------"

@jlongever , I think my code change will not cause the Jenkins failure, because helper.js is only used in unit testing but travis-ci succeed. Have you encountered the same issue?

test this please

*** BUILD #340 ***

test this please

*** BUILD #342 ***
Test Name: test_node_workflows_del_active
Error Details: (404)
Reason: Not Found
HTTP response headers: HTTPHeaderDict({'Content-Length': '62', 'X-Powered-By': 'Express', 'Connection': 'keep-alive', 'ETag': 'W/"3e-uVr3eF51jj1og38xQuRGng"', 'Date': 'Tue, 22 Mar 2016 07:28:50 GMT', 'Access-Control-Allow-Origin': '*', 'Content-Type': 'application/json; charset=utf-8'})
HTTP response body: {"message":"NotFoundError: No active workflow found for node"}

Stack Trace: Traceback (most recent call last):
  File "/usr/lib/python2.7/unittest/case.py", line 331, in run
    testMethod()
  File "/usr/lib/python2.7/unittest/case.py", line 1043, in runTest
    self._testFunc()
  File "/usr/local/lib/python2.7/dist-packages/proboscis/case.py", line 296, in testng_method_mistake_capture_func
    compatability.capture_type_error(s_func)
  File "/usr/local/lib/python2.7/dist-packages/proboscis/compatability/exceptions_2_6.py", line 27, in capture_type_error
    func()
  File "/usr/local/lib/python2.7/dist-packages/proboscis/case.py", line 350, in func
    func(test_case.state.get_state())
  File "/var/lib/jenkins/jobs/on-core/workspace/RackHD/test/tests/api/v2_0/nodes_tests.py", line 308, in test_node_workflows_del_active
    Api().nodes_del_active_workflow_by_id(identifier=id)
  File "/usr/local/lib/python2.7/dist-packages/on_http_api2_0/apis/api_api.py", line 2673, in nodes_del_active_workflow_by_id
    callback=params.get('callback'))
  File "/usr/local/lib/python2.7/dist-packages/on_http_api2_0/api_client.py", line 322, in call_api
    response_type, auth_settings, callback)
  File "/usr/local/lib/python2.7/dist-packages/on_http_api2_0/api_client.py", line 149, in __call_api
    post_params=post_params, body=body)
  File "/usr/local/lib/python2.7/dist-packages/on_http_api2_0/api_client.py", line 374, in request
    headers=headers)
  File "/usr/local/lib/python2.7/dist-packages/on_http_api2_0/rest.py", line 201, in DELETE
    query_params=query_params)
  File "/usr/local/lib/python2.7/dist-packages/on_http_api2_0/rest.py", line 177, in request
    raise ApiException(http_resp=r)
ApiException: (404)
Reason: Not Found
HTTP response headers: HTTPHeaderDict({'Content-Length': '62', 'X-Powered-By': 'Express', 'Connection': 'keep-alive', 'ETag': 'W/"3e-uVr3eF51jj1og38xQuRGng"', 'Date': 'Tue, 22 Mar 2016 07:28:50 GMT', 'Access-Control-Allow-Origin': '*', 'Content-Type': 'application/json; charset=utf-8'})
HTTP response body: {"message":"NotFoundError: No active workflow found for node"}

test this please

test this please


Validate number of files?

Is it possible to validate the maximum number of files on a multiple upload field?
I tried 'maxlength' but it only count the number of chars of the file.
Thanks

I'm sorry for the lack of activity on this issue. Instead of leaving it open any longer, I decided to close old issues without trying to address them, to longer give the false impression that it will get addressed eventually, especially after several years with no activity. It doesn't mean I'm abandoning the project, just that I'm unable to work through 200+ open issues with the little time I can afford to spend on this project.
To the reporter (or anyone else interested in this issue): If you're still affected by the same issue, please consider opening a new issue, with a testpage that demonstrates the issue with a current version of the plugin. Even better, make an attempt to fix the issue yourself, and improve the project by sending a pull request. This may seem daunting at first, but you'll likely learn some useful skills that you can apply elsewhere as well. And you can help keep this project alive. We've documented how to do these things, too. A patch is worth a thousand issues!


examples/tcpblaster: When a host PC is used, take its implementation of hton/ntoh functions.

@yamt This should address #150
Please take a look.

lgtm. thank you.


update @xstate/inspect README about new beta viz URL

Related to my other PR #2580. Just my suggestion for how you might want to handle the new vs. old viz situation at the moment.

This is now included in the current version: https://xstate.js.org/docs/packages/xstate-inspect/#installation


Additional fixes for codebase path changes

Test URLs:

Before: https://main--hlx-test--urfuwo.hlx.live/blog/2023/11/idc-marketscape-sap-a-leader-cloud-enabled-sourcing-applications
After: https://codebase2--hlx-test--urfuwo.hlx.live/blog/2023/11/idc-marketscape-sap-a-leader-cloud-enabled-sourcing-applications

https://www-qa.sap.com/news/0000/the-article
/news is not on the CDN config yet

https://www-qa.sap.com/blog/2024/02/next-wave-digital-transformation-automotive-industry => social icons are back; author profile image is back; but header and footer are still empty
Header & Footer are not on the CDN config yet


SoundCloud Playlist won't play

I can play individual songs on soundcloud, but cannot play soundcloud playlists (even if they are public)
I do not have any error, I have the message saying that the playlist is loaded, but there is absolutely no sound. I first thought this could be a loading time, but it isn't as a two songs playlist wouldn't play too.

Did you resolve it?

Yes, I forgot a line.
Le jeu. 13 juin 2019 à 15:39, MCOfficer<EMAIL_ADDRESS>a écrit :

Did you resolve it?
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/sedmelluq/lavaplayer/issues/178?email_source=notifications&email_token=AL3L5HSN7NB3KFVAVHRCTIDP2JEYTA5CNFSM4HXYG53KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODXTXBBQ#issuecomment-501706886,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AL3L5HSBRE27P4RE3K2CL53P2JEYTANCNFSM4HXYG53A
.


Error "security status not satisfied", SW1 = "69", SW2 = "82", when running restore of Mifare Classic.

I'm trying to use a restore command using the lib PcscSdk but I'm just getting a response 6982 - security status not satisfied.
What should I do?
The command was used:
FF C2 00 03 0E
0C A1                 // decrement
80 01 05             // block 5 and
80 01 06             // restore to block 6
81 04 01 00 00 00   // value = 1
As demonstrated in: http://www.pcscworkgroup.com/specifications/files/pcsc3_v2.01.09_amd1.pdf
The increment, decrement, write and read, they are working perfectly.
I appreciate any help.

This appears to be a problem with your own program, not a problem in the Nfc sample. You can open a support case with our Developer Support team who can further help with the specific problem you are experiencing. Please use these steps below for further help:

Visit http://aka.ms/storesupport and sign-in with your Microsoft account.
Under the “App Development” section choose the appropriate type – such as Building apps and games, and then choose from the Problem type/Category to get engaged through a formal support channel.


fix(browser): Bail out from handleTouchMove if 'disabled' property is enabled.

Before #239 onTouchMove was not listened when disabled property was enabled. This PR restores the behaviour by returning early from handleTouchMove. It fixes situations where swiping causes slides to partially slide in and get stuck when swiping should be disabled.

Thanks.


Problems configuring Pylance

From the marketplace ratings and reviews.

Do you want to spend more time configuring Pylance then coding? Go ahead and install this and enjoy your non stop fiddling with JSON config files in an endless loop.
If it works for you out of the box, start playing Bingo as you are very lucky person.

Amir, to understand the problem you are facing, would you please add more information on repro steps and the experience.
thanks!

Came across this issue in yet another attempt to get Pylance to just work.
I've been using VSCode with Pylance and Pyright extensively for the past three years, and the amount of time I've spent dealing with out-of-memory crashes, unstable indexing behavior, and high CPU load is simply ridiculous.
It typically works fine in small, newly created Python projects, but as soon as a project matures with additional dependencies and an increased symbol count, performance takes a nosedive. This is when weird behavior starts to kick in, often requiring a full VSCode reload.
I'm constantly tweaking analysis exclusions, ignore settings, and package indexing depth, yet the only feedback you get is an overly verbose debug trace log. The configuration documentation is unhelpful—parameters are vaguely described, with little to no examples provided, and there's no clear guidance on how one parameter might affect another.
I've remained a loyal user because it's a great product when it works, but it feels like there's a growing disconnect between the maintainers and users regarding the overall experience. Despite Pyright having 13k stars, there are only 13 open issues—not because there are so few issues, but because reports are frequently dismissed with arrogance and closed.

@olafurnielsen, can you provide access to a project (or projects) that reproduce any of these behaviors? We are aware that users are encountering out-of-memory issues, for example, but without a repro case it's difficult to fix them.

just in case you didn't see this, we have a wiki that explains how to setup a large workspace - https://github.com/microsoft/pylance-release/wiki/Opening-Large-Workspaces-in-VS-Code
also, we have wiki that explains how to use pylance is glorified text editor - https://github.com/microsoft/pylance-release/wiki/Pylance-Configuration-Tips


75 redirection buttons

Pull Request Template
**Fixes #75 **
What was changed?
Describe what part of the application was changed (e.g., login page, database, etc.). Mention specific components that were added, removed, or modified.

Added back buttons to donor form, new item form, and new item status
Redirects users to '/donors' page upon successful submission of donor form

Why was it changed?
Explain the problem or issue that prompted this change. Detail why this change effectively resolves the issue or improves the application.

Improved user experience.
Assists users in quicker and easier navigation

How was it changed?
Detail the key modifications in the codebase, highlighting significant files, functions, or lines of code.

Added buttons that take you back to the respective page for the forms.
Added a navigation to '/donors' after a successful submission of the donor form

Screenshots that show the changes (if applicable) (I may have accidentally uploaded a lot of screenshots, I thought it was glitching, sorry!):
Include screenshots or visual representations of the changes, especially for user interface updates.

Before:

After:

@truffer11 changes looks good but I found the following issues, please fix them

Prettier checks and client pipelines failed as shown here https://github.com/oss-slu/material-donor-mutual-assist/actions
Please run the prettier on your code following the readme instructions as shown here https://github.com/oss-slu/material-donor-mutual-assist/blob/main/README.md#code-formatting
Merge conflicts are there. Pulling latest code from main branch should fix this issue


Allow scarb new to accept - in name

Problem
scarb new will raise when using a - in the new command
error: invalid value 'my-cairo-project' for '--name <NAME>': invalid character `-` in package name: `my-cairo-project`, characters must be ASCII lowercase letters, ASCII numbers or underscore

it's however common case to have folder names with - but package name actually with _ instead.
Furthermore, doing mkdir my-cairo-project && cd my-cairo-project && scarb init my_cairo_project is legit.
Proposed Solution
Just accept the - and replace in the package name with _
Notes
No response

Dup of #278 😇

Hi!
This is a intentional decision.
Closing as duplicate of #278


Implement Module#const_missing

That's not what I meant in #1144 :wink:

Haha, that was just a funny coincidence. Actually I thought it followed naturally from #1269.


[spirv-opt] Inlining pass generates OpVariable of PhysicalStorageBuffer pointer type without AliasedPointer decoration.

If the source spirv contains a function that takes an AliasedPointer parameter, the --inline-entry-points-exhaustive pass generates a pointer-typed OpVariable without AliasedPointer decoration, which leads to validation error.
Steps to reproduce:
test.zip
Use the test.spv in test.zip file:
spirv-val test.spv       # passes validation
spirv-opt --inline-entry-points-exhaustive -o test-out.spv
spirv-val test-out.spv       # FAILS validation

spirv-val output:
error: line 121: OpVariable 131: expected AliasedPointer or RestrictPointer for PhysicalStorageBuffer pointer.
  %131 = OpVariable %_ptr_Function__ptr_PhysicalStorageBuffer_int Function

@dneto0 I believe @greg-lunarg worked on this. We'd be happy to look at this bug. Please assign to me if you'd like.

FYI, I have a fix for this incoming. Just wrapping up the test.


How to update FsLogix

Hello Team,
Reopened the below request again as there seems lack of documentation on how to Update FsLogix Agent on existing VM running old versions of FSLOGIX. Can someone please help here:
Documentation that needs update:  https://docs.microsoft.com/en-us/fslogix/install-ht
Following was the ask which remained unanswered
https://github.com/MicrosoftDocs/fslogix-docs/issues/111

Hi @DeepMalh44, thanks for the feedback.  There are no separate instructions for upgrade installs versus new installs.  We are working on a complete doc refresh by end of year and we'll add a note about this at that time.

@msft-jasonparker But that is not "simple" without appropriate guidance. When "installing a new version," should the session hosts be drained of sessions? Should a reboot be expected after the install? Is it recommend to uninstall first?
When you're installing the new version on a host with an existing version and existing users, it seems to take a very long time for the installer the finish. It seems to be successful. If that lengthy (30+ minutes, I've observed) is expected, then that should be documented.
These are all reasonable questions that customers running an enterprise-scale service need to know rather than find out the hard way.


mappings to increment or decrement indent

Allow to adapt to several different files who uses two, four, whatever spaces for indent
Define handy mappings to ease adoption
Review needed:

[ ] The init of g:indentLine_tab needs a review
[ ] Maybe SetTab() can be replace with ResetWidth()

I think this feature is duplicate with IndentLinesReset, and I don't think it is necessary to have.


Possible to grab partial desktop?

Testing latest and it works great!
Is there a setting/possibility/instructions to support capturing Desktop(window title area only)
Capturing window works ok, desktop works ok....but i'd like to capture the window area from desktop (have some overlapped windows in that area)... and don't want to always grab/crop entire desktop.
thanks.

Sorry for the late reply... Currently, uWindowCapture captures the entire window. However, cropping can be achieved by calculating the UV scale and offset using the width and height of the window, and using the Tiling and Offset parameters of the texture (another asset of mine, uDesktopDuplication, uses this method for cropping: https ://github.com/hecomi/uDesktopDuplication/blob/4ba7caf792659d715a61cdf0ef6c0b616cb3b4ff/Assets/uDesktopDuplication/Examples/Scripts /Loupe.cs#L38-L43)


🐛 [Bug report]: Unused Imports and states

Descrcibe the bug?
There are 2 unused imports and 1 unused state found in the project.
Steps to reproduce the bug?
Files in which unused imports are found:

src/common/activities/hackathon/HackathonBanner.jsx [Line 1]
src/common/activities/hackathon/HackathonBanner.jsx [Line 2]
src/common/home/Home.jsx [Line 19]

Expected behavior
Importing and using only what is required improves code readability and simplifies code.
Desktop (Please provide your system information)
OS: MacOS
Browser: Chrome
Version: 106.0.5249.119
Mobile (Please provide your device information)
No response
Screenshot / Screenshare
No response
Relevant log output
No response
Code of Conduct

[X] I agree to follow this project's Code of Conduct

I would like to contribute to this issue.


always return column default family for a table

Default column family doesn't appear in Describe section for a table when only one column family is used for it.

it's required to apply this protobuf config: https://gist.github.com/adameat/23e644872dfad0ce286588808ba54952
BEFORE creating a table


there is no port: 5432

$ docker exec spfx ss -nlptu
Netid  State      Recv-Q Send-Q Local Address:Port               Peer Address:Port
tcp    LISTEN     0      128       *:4321                  *:*                   users:(("gulp serve",pid=107,fd=21))
tcp    LISTEN     0      128      :::35729                :::*                   users:(("gulp serve",pid=107,fd=22))

Could it be that you have something else running on 5432 already?

# docker run -it --rm --name ${PWD##*/} -v $PWD:/usr/app/spfx -p 5432:5432 -p 4321:4321 -p 35729:35729 waldekm/spfx
spfx@4f33dc91ab3f:/usr/app/spfx$ yo @microsoft/sharepoint
? ==========================================================================
We're constantly looking for ways to make yo better!
May we anonymously report usage statistics to improve the tool over time?
More info: https://github.com/yeoman/insight & http://yeoman.io
========================================================================== No

     _-----_     ╭──────────────────────────╮
    |       |    │      Welcome to the      │
    |--(o)--|    │  SharePoint Client-side  │
   `---------´   │         Solution         │
    ( _´U`_ )    │<EMAIL_ADDRESS>   │
    /___A___\   /╰──────────────────────────╯
     |  ~  |
   __'.___.'__
 ´   `  |° ´ Y `

Let's create a new SharePoint solution.
? What is your solution name? spfx
? Only SharePoint Online (latest) is supported.  For earlier versions of SharePoint (2016 and 2019) please use the 1.4.1 version of the generator. SharePoint Online only (latest)
? Where do you want to place the files? Use the current folder
? Do you want to allow the tenant admin the choice of being able to deploy the solution to all sites immediately without running any feature deployment or adding apps in sites? No
? Will the components in the solution require permissions to access web APIs that are unique and not shared with other components in the tenant? No
? Which type of client-side component to create? WebPart
Add new Web part to solution spfx.
? What is your Web part name? HelloWorld
? What is your Web part description? HelloWorld description
? Which framework would you like to use? React

   create package.json
    force .yo-rc.json
   create config/package-solution.json
   create config/config.json
   create config/serve.json
   create tsconfig.json
    force .vscode/extensions.json
    force .vscode/launch.json
    force .vscode/settings.json
   create config/deploy-azure-storage.json
   create config/write-manifests.json
   create src/index.ts
   create README.md
    force .gitignore
    force .npmignore
   create gulpfile.js
   create tslint.json
   create src/webparts/helloWorld/components/IHelloWorldProps.ts
   create src/webparts/helloWorld/components/HelloWorld.module.scss
   create src/webparts/helloWorld/components/HelloWorld.tsx
   create src/webparts/helloWorld/HelloWorldWebPart.ts
   create src/webparts/helloWorld/loc/en-us.js
   create src/webparts/helloWorld/loc/mystrings.d.ts
   create src/webparts/helloWorld/HelloWorldWebPart.manifest.json
   create teams/d9cc3a49-916a-4e5c-8e82-1fdd68584049_outline.png
   create teams/d9cc3a49-916a-4e5c-8e82-1fdd68584049_color.png

Changes to package.json were detected.

Running npm install for you to install the required dependencies.
npm WARN deprecated<EMAIL_ADDRESS>Chokidar 2 will break on node v14+. Upgrade to chokidar 3 with 15x less dependencies.
npm WARN deprecated<EMAIL_ADDRESS>fsevents 1 will break on node v14+ and could be using insecure binaries. Upgrade to fsevents 2.
npm WARN deprecated<EMAIL_ADDRESS>TSLint has been deprecated in favor of ESLint. Please see https://github.com/palantir/tslint/issues/4534 for more information.
npm WARN deprecated<EMAIL_ADDRESS>This is a stub types definition. anymatch provides its own type definitions, so you do not need this installed.
npm WARN deprecated<EMAIL_ADDRESS>gulp-util is deprecated - replace it, following the guidelines at https://medium.com/gulpjs/gulp-util-ca3b1f9f9ac5
npm WARN deprecated<EMAIL_ADDRESS>use String.prototype.padStart()
npm WARN deprecated<EMAIL_ADDRESS>request has been deprecated, see https://github.com/request/request/issues/3142
npm WARN deprecated<EMAIL_ADDRESS>request-promise-native has been deprecated because it extends the now deprecated request package, see https://github.com/request/request/issues/3142
npm WARN deprecated<EMAIL_ADDRESS>Please upgrade  to version 7 or higher.  Older versions may use Math.random() in certain circumstances, which is known to be problematic.  See https://v8.dev/blog/math-random for details.
npm WARN deprecated<EMAIL_ADDRESS>Package renamed to @opentelemetry/api, see https://github.com/open-telemetry/opentelemetry-js
npm WARN deprecated<EMAIL_ADDRESS>Please upgrade  to version 7 or higher.  Older versions may use Math.random() in certain circumstances, which is known to be problematic.  See https://v8.dev/blog/math-random for details.
npm WARN deprecated<EMAIL_ADDRESS>some dependency vulnerabilities fixed, support for node < 10 dropped, and newer ECMAScript syntax/features added
npm WARN deprecated<EMAIL_ADDRESS>this library is no longer supported
npm WARN deprecated<EMAIL_ADDRESS>https://github.com/lydell/resolve-url#deprecated
npm WARN deprecated<EMAIL_ADDRESS>Please see https://github.com/lydell/urix#deprecated
npm WARN deprecated<EMAIL_ADDRESS>The querystring API is considered Legacy. new code should use the URLSearchParams API instead.
npm WARN deprecated<EMAIL_ADDRESS>This version of tar is no longer supported, and will not receive security updates. Please upgrade asap.
npm WARN deprecated<EMAIL_ADDRESS>This SVGO version is no longer supported. Upgrade to v2.x.x.
npm WARN deprecated<EMAIL_ADDRESS>"Please update to latest v2.3 or v2.2"

><EMAIL_ADDRESS>install /usr/app/spfx/node_modules/node-sass
> node scripts/install.js

Cached binary found at /home/spfx/.npm/node-sass/4.14.1/linux-x64-83_binding.node

><EMAIL_ADDRESS>postinstall /usr/app/spfx/node_modules/node-sass
> node scripts/build.js

Binary found at /usr/app/spfx/node_modules/node-sass/vendor/linux-x64-83/binding.node
Testing binary
Binary is fine
npm notice created a lockfile as package-lock.json. You should commit this file.
npm WARN optional SKIPPING OPTIONAL DEPENDENCY<EMAIL_ADDRESS>(node_modules/jest-haste-map/node_modules/fsevents):
npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for<EMAIL_ADDRESS>wanted {"os":"darwin","arch":"any"} (current: {"os":"linux","arch":"x64"})
npm WARN optional SKIPPING OPTIONAL DEPENDENCY<EMAIL_ADDRESS>(node_modules/chokidar/node_modules/fsevents):
npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for<EMAIL_ADDRESS>wanted {"os":"darwin","arch":"any"} (current: {"os":"linux","arch":"x64"})
npm WARN optional SKIPPING OPTIONAL DEPENDENCY<EMAIL_ADDRESS>(node_modules/@rushstack/typings-generator/node_modules/chokidar/node_modules/fsevents):
npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for<EMAIL_ADDRESS>wanted {"os":"darwin","arch":"any"} (current: {"os":"linux","arch":"x64"})
npm WARN<EMAIL_ADDRESS>requires a peer of<EMAIL_ADDRESS>but none is installed. You must install peer dependencies yourself.

added 2232 packages from 1039 contributors and audited 2238 packages in 192.758s

114 packages are looking for funding
  run `npm fund` for details

found 105 vulnerabilities (8 low, 49 moderate, 45 high, 3 critical)
  run `npm audit fix` to fix them, or `npm audit` for details

   ╭───────────────────────────────────────────────────────────────╮
   │                                                               │
   │     New major version of npm available! 6.14.13 -> 8.1.3      │
   │   Changelog: https://github.com/npm/cli/releases/tag/v8.1.3   │
   │               Run npm install -g npm to update!               │
   │                                                               │
   ╰───────────────────────────────────────────────────────────────╯

      _=+#####!
   ###########|       .-----------------------------------.
   ###/    (##|(@)    |          Congratulations!         |
   ###  ######|   \   |     Solution spfx is created.     |
   ###/   /###|   (@) |  Run gulp serve to play with it!  |
   #######  ##|   /   '-----------------------------------'
   ###     /##|(@)
   ###########|
      **=+####!

spfx@4f33dc91ab3f:/usr/app/spfx$ gulp serve
Build target: DEBUG
[09:40:53] Using gulpfile /usr/app/spfx/gulpfile.js
[09:40:53] Starting 'serve'...
[09:40:53] Starting gulp
[09:40:53] Starting subtask 'spfx-serve'...
[09:40:53] [spfx-serve] To load your scripts, use this query string: ?debug=true&noredir=true&debugManifestsFile=https://<IP_ADDRESS>:4321/temp/manifests.js
[09:40:53] Warning - [spfx-serve] When serving in HTTPS mode, a PFX cert path or a cert path and a key path must be provided, or a dev certificate must be generated and trusted. If a SSL certificate isn't provided, a default, self-signed certificate will be used. Expect browser security warnings.
[09:40:53] Starting server...
[09:40:53] Finished subtask 'spfx-serve' after 95 ms
[09:40:53] Starting subtask 'pre-copy'...
[09:40:53] Finished subtask 'pre-copy' after 28 ms
[09:40:53] Starting subtask 'copy-static-assets'...
[09:40:53] Starting subtask 'sass'...
[09:40:53] Server started https://<IP_ADDRESS>:4321
[09:40:53] LiveReload started on port 35729
[09:40:53] Running server
[09:40:53] Opening https://enter-your-SharePoint-site/_layouts/workbench.aspx using the default OS app
[09:40:54] Finished subtask 'sass' after 928 ms
[09:40:54] Starting subtask 'tslint'...
[09:40:54] [tslint] tslint version: 5.20.1
[09:40:54] Starting subtask 'tsc'...
[09:40:54] [tsc] typescript version: 3.9.10
(node:108) UnhandledPromiseRejectionWarning: Error: Exited with code 3
    at ChildProcess.<anonymous> (/usr/app/spfx/node_modules/opn/index.js:84:13)
    at Object.onceWrapper (events.js:483:26)
    at ChildProcess.emit (events.js:376:20)
    at ChildProcess.emit (domain.js:532:15)
    at maybeClose (internal/child_process.js:1055:16)
    at Socket.<anonymous> (internal/child_process.js:441:11)
    at Socket.emit (events.js:376:20)
    at Socket.emit (domain.js:532:15)
    at Pipe.<anonymous> (net.js:673:12)
    at Pipe.callbackTrampoline (internal/async_hooks.js:134:14)
(Use `node --trace-warnings ...` to show where the warning was created)
(node:108) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). To terminate the node process on unhandled promise rejection, use the CLI flag `--unhandled-rejections=strict` (see https://nodejs.org/api/cli.html#cli_unhandled_rejections_mode). (rejection id: 1)
(node:108) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.
[09:40:55] Finished subtask 'copy-static-assets' after 1.95 s
[09:40:57] Finished subtask 'tslint' after 2.78 s
[09:40:58] Finished subtask 'tsc' after 3.45 s
[09:40:58] Starting subtask 'post-copy'...
[09:40:58] Finished subtask 'post-copy' after 209 μs
[09:40:58] Starting subtask 'configure-webpack'...
[09:40:58] Finished subtask 'configure-webpack' after 356 ms
[09:40:58] Starting subtask 'webpack'...
[09:40:59] Finished subtask 'webpack' after 1.05 s
[09:40:59] Starting subtask 'reload'...
[09:40:59] Finished subtask 'reload' after 2.1 ms

What I meant is, if it's possible that there's something else running on port 5432 on your host and which could be preventing Docker from mapping it to the container?

the container's network is not the host, You can find a Linux system without a graphical interface and try it like the above command after installing docker. You will run into the same problem

Sorry, but I'm not sure what you're saying. In the first command, you're running a command on your host, to execute a command inside the Docker container to show port mappings and 5432 isn't there. This could be caused by port 5432 being blocked on the host and which is why it can't be mapped to the same port inside the container.

This is what I can see in Windows.

Starting a new container: docker run -it --rm --name spfx00 docker-spfx:1.13.1_00 /bin/bash -c "yo @microsoft/sharepoint --solution-name helloworld --framework react --component-type webpart --component-name hello-world-webpart --component-description 'HelloWorld web part' --is-domain-isolated true --skip-install --environment spo --skip-feature-deployment false && cd helloworld && npm install && gulp serve"
Answer the question about usage statistics reports
Wait until it is started (2 min)
Not closing the console, run in another console: docker exec spfx00 ss -nlptu

Expected:
5432 port is open on the container
Observed:
PS C:\projects> docker run -it --rm --name spfx00 docker-spfx:1.13.1_00 /bin/bash -c "yo @microsoft/sharepoint --solution-name helloworld --framework react --component-type webpart --component-name hello-world-webpart --component-description 'HelloWorld web part' --is-domain-isolated true --skip-install --environment spo --skip-feature-deployment false && cd helloworld && npm install && gulp serve"
? ==========================================================================
We're constantly looking for ways to make yo better!
May we anonymously report usage statistics to improve the tool over time?
More info: https://github.com/yeoman/insight & http://yeoman.io
========================================================================== Yes

     _-----_     ╭──────────────────────────╮
    |       |    │      Welcome to the      │
    |--(o)--|    │  SharePoint Client-side  │
   `---------´   │         Solution         │
    ( _´U`_ )    │<EMAIL_ADDRESS>   │
    /___A___\   /╰──────────────────────────╯
     |  ~  |
   __'.___.'__
 ´   `  |° ´ Y `

A folder with solution name helloworld will be created for you.
A component for the spo environment will be created for you.
A web part with the name hello-world-webpart will be added to your solution with react framework.
Web part description is going to be HelloWorld web part.
Let's create a new SharePoint solution.
Add new Web part to solution helloworld.

    force helloworld/.yo-rc.json
   create helloworld/package.json
   create helloworld/config/package-solution.json
   create helloworld/config/config.json
   create helloworld/config/serve.json
   create helloworld/tsconfig.json
   create helloworld/.vscode/extensions.json
   create helloworld/.vscode/launch.json
   create helloworld/.vscode/settings.json
   create helloworld/config/deploy-azure-storage.json
   create helloworld/config/write-manifests.json
   create helloworld/src/index.ts
   create helloworld/README.md
   create helloworld/.gitignore
   create helloworld/.npmignore
   create helloworld/gulpfile.js
   create helloworld/tslint.json
   create helloworld/src/webparts/helloWorldWebpart/components/IHelloWorldWebpartProps.ts
   create helloworld/src/webparts/helloWorldWebpart/components/HelloWorldWebpart.module.scss
   create helloworld/src/webparts/helloWorldWebpart/components/HelloWorldWebpart.tsx
   create helloworld/src/webparts/helloWorldWebpart/HelloWorldWebpartWebPart.ts
   create helloworld/src/webparts/helloWorldWebpart/loc/en-us.js
   create helloworld/src/webparts/helloWorldWebpart/loc/mystrings.d.ts
   create helloworld/src/webparts/helloWorldWebpart/HelloWorldWebpartWebPart.manifest.json
   create helloworld/teams/25c39751-3e89-435e-bebf-948d24408942_outline.png
   create helloworld/teams/25c39751-3e89-435e-bebf-948d24408942_color.png

Changes to package.json were detected.
Skipping package manager install.

Skipping installation of dependencies. You should run "npm install"

      _=+#####!
   ###########|       .-----------------------------------.
   ###/    (##|(@)    |          Congratulations!         |
   ###  ######|   \   |  Solution helloworld is created.  |
   ###/   /###|   (@) |  Run gulp serve to play with it!  |
   #######  ##|   /   '-----------------------------------'
   ###     /##|(@)
   ###########|
      **=+####!

npm WARN deprecated<EMAIL_ADDRESS>TSLint has been deprecated in favor of ESLint. Please see https://github.com/palantir/tslint/issues/4534 for more information.
npm WARN deprecated<EMAIL_ADDRESS>Chokidar 2 will break on node v14+. Upgrade to chokidar 3 with 15x less dependencies.
npm WARN deprecated<EMAIL_ADDRESS>fsevents 1 will break on node v14+ and could be using insecure binaries. Upgrade to fsevents 2.
npm WARN deprecated<EMAIL_ADDRESS>This is a stub types definition. anymatch provides its own type definitions, so you do not need this installed.
npm WARN deprecated<EMAIL_ADDRESS>gulp-util is deprecated - replace it, following the guidelines at https://medium.com/gulpjs/gulp-util-ca3b1f9f9ac5
npm WARN deprecated<EMAIL_ADDRESS>request has been deprecated, see https://github.com/request/request/issues/3142
npm WARN deprecated<EMAIL_ADDRESS>request-promise-native has been deprecated because it extends the now deprecated request package, see https://github.com/request/request/issues/3142
npm WARN deprecated<EMAIL_ADDRESS>Package renamed to @opentelemetry/api, see https://github.com/open-telemetry/opentelemetry-js
npm WARN deprecated<EMAIL_ADDRESS>Please upgrade  to version 7 or higher.  Older versions may use Math.random() in certain circumstances, which is known to be problematic.  See https://v8.dev/blog/math-random for details.
npm WARN deprecated<EMAIL_ADDRESS>use String.prototype.padStart()
npm WARN deprecated<EMAIL_ADDRESS>Please upgrade  to version 7 or higher.  Older versions may use Math.random() in certain circumstances, which is known to be problematic.  See https://v8.dev/blog/math-random for details.
npm WARN deprecated<EMAIL_ADDRESS>some dependency vulnerabilities fixed, support for node < 10 dropped, and newer ECMAScript syntax/features added
npm WARN deprecated<EMAIL_ADDRESS>this library is no longer supported
npm WARN deprecated<EMAIL_ADDRESS>The querystring API is considered Legacy. new code should use the URLSearchParams API instead.
npm WARN deprecated<EMAIL_ADDRESS>https://github.com/lydell/resolve-url#deprecated
npm WARN deprecated<EMAIL_ADDRESS>Please see https://github.com/lydell/urix#deprecated
npm WARN deprecated<EMAIL_ADDRESS>This version of tar is no longer supported, and will not receive security updates. Please upgrade asap.
npm WARN deprecated<EMAIL_ADDRESS>This SVGO version is no longer supported. Upgrade to v2.x.x.
npm WARN deprecated<EMAIL_ADDRESS>"Please update to latest v2.3 or v2.2"

><EMAIL_ADDRESS>install /usr/app/spfx/helloworld/node_modules/node-sass
> node scripts/install.js

Cached binary found at /home/spfx/.npm/node-sass/4.14.1/linux-x64-83_binding.node

><EMAIL_ADDRESS>postinstall /usr/app/spfx/helloworld/node_modules/node-sass
> node scripts/build.js

Binary found at /usr/app/spfx/helloworld/node_modules/node-sass/vendor/linux-x64-83/binding.node
Testing binary
Binary is fine
npm notice created a lockfile as package-lock.json. You should commit this file.
npm WARN optional SKIPPING OPTIONAL DEPENDENCY<EMAIL_ADDRESS>(node_modules/jest-haste-map/node_modules/fsevents):
npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for<EMAIL_ADDRESS>wanted {"os":"darwin","arch":"any"} (current: {"os":"linux","arch":"x64"})
npm WARN optional SKIPPING OPTIONAL DEPENDENCY<EMAIL_ADDRESS>(node_modules/chokidar/node_modules/fsevents):
npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for<EMAIL_ADDRESS>wanted {"os":"darwin","arch":"any"} (current: {"os":"linux","arch":"x64"})
npm WARN optional SKIPPING OPTIONAL DEPENDENCY<EMAIL_ADDRESS>(node_modules/@rushstack/typings-generator/node_modules/chokidar/node_modules/fsevents):
npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for<EMAIL_ADDRESS>wanted {"os":"darwin","arch":"any"} (current: {"os":"linux","arch":"x64"})
npm WARN<EMAIL_ADDRESS>requires a peer of<EMAIL_ADDRESS>but none is installed. You must install peer dependencies yourself.

added 2232 packages from 1040 contributors and audited 2238 packages in 73.082s

114 packages are looking for funding
  run `npm fund` for details

found 98 vulnerabilities (8 low, 60 moderate, 27 high, 3 critical)
  run `npm audit fix` to fix them, or `npm audit` for details
Build target: DEBUG
[06:31:00] Using gulpfile /usr/app/spfx/helloworld/gulpfile.js
[06:31:00] Starting 'serve'...
[06:31:00] Starting gulp
[06:31:00] Starting subtask 'spfx-serve'...
[06:31:00] [spfx-serve] To load your scripts, use this query string: ?debug=true&noredir=true&debugManifestsFile=https://localhost:4321/temp/manifests.js
[06:31:00] Warning - [spfx-serve] When serving in HTTPS mode, a PFX cert path or a cert path and a key path must be provided, or a dev certificate must be generated and trusted. If a SSL certificate isn't provided, a default, self-signed certificate will be used. Expect browser security warnings.
[06:31:00] Starting server...
[06:31:00] Finished subtask 'spfx-serve' after 50 ms
[06:31:00] Starting subtask 'pre-copy'...
[06:31:00] Finished subtask 'pre-copy' after 15 ms
[06:31:00] Starting subtask 'copy-static-assets'...
[06:31:00] Starting subtask 'sass'...
[06:31:00] Server started https://localhost:4321
[06:31:00] LiveReload started on port 35729
[06:31:00] Running server
[06:31:00] Opening https://enter-your-SharePoint-site/_layouts/workbench.aspx using the default OS app
[06:31:00] Finished subtask 'sass' after 504 ms
[06:31:00] Starting subtask 'tslint'...
[06:31:00] [tslint] tslint version: 5.20.1
[06:31:00] Starting subtask 'tsc'...
[06:31:00] [tsc] typescript version: 3.9.10
(node:1) UnhandledPromiseRejectionWarning: Error: Exited with code 3
    at ChildProcess.<anonymous> (/usr/app/spfx/helloworld/node_modules/opn/index.js:84:13)
    at Object.onceWrapper (events.js:520:26)
    at ChildProcess.emit (events.js:400:28)
    at ChildProcess.emit (domain.js:537:15)
    at maybeClose (internal/child_process.js:1058:16)
    at Socket.<anonymous> (internal/child_process.js:443:11)
    at Socket.emit (events.js:400:28)
    at Socket.emit (domain.js:537:15)
    at Pipe.<anonymous> (net.js:686:12)
    at Pipe.callbackTrampoline (internal/async_hooks.js:130:17)
(Use `node --trace-warnings ...` to show where the warning was created)
(node:1) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). To terminate the node process on unhandled promise rejection, use the CLI flag `--unhandled-rejections=strict` (see https://nodejs.org/api/cli.html#cli_unhandled_rejections_mode). (rejection id: 1)
(node:1) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.
[06:31:01] Finished subtask 'copy-static-assets' after 1.18 s
[06:31:02] Finished subtask 'tslint' after 1.72 s
[06:31:02] Finished subtask 'tsc' after 1.86 s
[06:31:02] Starting subtask 'post-copy'...
[06:31:02] Finished subtask 'post-copy' after 157 μs
[06:31:02] Starting subtask 'configure-webpack'...
[06:31:03] Finished subtask 'configure-webpack' after 475 ms
[06:31:03] Starting subtask 'webpack'...
[06:31:04] Finished subtask 'webpack' after 1.12 s
[06:31:04] Starting subtask 'reload'...
[06:31:04] Finished subtask 'reload' after

PS C:\Windows\system32> docker exec spfx00 ss -nlptu
Netid  State      Recv-Q Send-Q Local Address:Port               Peer Address:Port
tcp    LISTEN     0      511    <IP_ADDRESS>:4321                  *:*                   users:(("gulp serve",pid=1,fd=21))
tcp    LISTEN     0      511      :::35729                :::*                   users:(("gulp serve",pid=1,fd=22))

I think the reason is that in SPFx 1.13 there were fundamental changes in the local web sites. For example, in 1.12 the content of the /config/serve.json was this:
{
  "$schema": "https://developer.microsoft.com/json-schemas/core-build/serve.schema.json",
  "port": 4321,
  "https": true,
  "initialPage": "https://localhost:5432/workbench",
  "api": {
    "port": 5432,
    "entryPath": "node_modules/@microsoft/sp-webpart-workbench/lib/api/"
  }
}

So you see it included reference on the local workbench and api.
However, in SPFx 1.13 the local workbench is removed completely, so I guess you don't need to expect this port open when running solutions based on 1.13 SPFx.

I think need update the docs in the README.md

Great idea, I added this to the PR: https://github.com/waldekmastykarz/docker-spfx/pull/59

This issue is related: #53


docs/dev-env: Recommend setting up lxc network config on Debian.

lxc on Debian does not ship with a default network config for
containers, so we now recommend setting up the lxc network config
manually.
@gnprice: Thanks for your help with this! (I just remembered that we should probably update our docs for this) :)

I merged this as 8ccb25289a27d48698306a728067ebadd1581ce1, after moving the text and adding links to (A) make the new step much harder to ignore and (B) Point to the actual step-by-step part more immediately.
Thanks @eeshangarg!


Datepicker is-open weirdness

Hi,
I've noticed that when setting is-open to true using an ng-click on the text element itself the date picker popup opens and closes as you would expect.  However, if you move the ng-click to a separate button (the calendar glyph for instance) that this does not work.
This plunk demonstrates the problem.
The solution is the pass $event and then call $event.stopPropagation().  This is a behaviour is little unexpected and prompts these questions:

Is this intentional / would someone be able to explain why this works the way it does?
Would it be worth making the documentation spell this behaviour out a little more clearly?  I've stumbled over this a couple of times now and ended up writing this up to remind myself in future.  I can't be the only person this has confused...

@RobJacobs Mr. Datepicker, any thoughts on this?

The date picker popup binds a document click event here. I believe if we wrap that in a $timeout the originating click event would not get captured. I'll test that theory later today or tomorrow.

Cool @RobJacobs thanks for looking into it. Although I must say that my Angular-alert-system went off on the keywords 'wrap that in a $timeout'. Are you sure that's the way to go on this?

Using $timeout(function() { ... }, 0, false) prevents angular from triggering another digest cycle while waiting for the current cycle to complete. So there should not be a performance hit, but I could be wrong.

I would say go for it -- it's better to have a fix and refactor later if someone else has a better plan instead of not applying a fix at all.

Well this is encouraging!  Assuming the fix is made I'm guessing it would be non-breaking?  i.e. People out there using  $event.stopPropagation() wouldn't find their datepickers stopped working as a result of the upgrade.

Under PR #3666 I moved the $timeout call for setting focus to the datepicker popup to this line:
https://github.com/angular-ui/bootstrap/pull/3666/files#diff-6240fc17e068eaeef7095937a1d63eaeR695
Moving the document click bind to the $timeout like so:
$timeout(function() {
  scope.$broadcast('datepicker.focus');
  $document.bind('click', documentClickBind);
 }, 0, false);

Does negate the need for calling stopPropagation and preventDefault in the trigger element click event.  I want to wait until #3666 is merged to master before creating another PR so I don't have to worry about merge conflicts.

Great - thanks for the update!

Thank you for this, but it seems that the solution, at least for me was the both
$event.preventDefault();
$event.stopPropagation();


Themes at the bottom of document is frustrating

By putting Theme button at the bottom, You are now forcing users, who prefer to read in dark theme, to scroll to the end of the article, switch color, and come back to beginning so they can start to read. And they have to do this every time they open a link on a new page. This is not user friendly at all.
Please, put it back where it was.

I too was confused about where the theme change button got shifted to. Since the language and theme have an immediate effect on the UX, it should be located prominently so that users can quickly customize the way they want to experience the website and continue with those settings. Thanks for listening.


swtich over dev.rebuildingakidney.org to use new globus auth

This is needed before we can make changes to the rbk access control policy and the rbk frontend.

It turns out I need to get some new client-side settings from Kyle for this.

At this rate I'm not sure we're going to get any access prior to the new whitelist rolling out next week.

This is done and you login via the new globus_auth method now.  I think this exposes a viewer app problem now, where its ACLs need to be checked against the new session attributes content.

Reassigning to @hongsudt for review of RBK functions.  You might also want @ljpearlman to review the specifics of the webauthn config on the backend and in the provisioning recipe.

@ljpearlman can you please review the webauthn config and provisioning recipe?

The webauthn config looks okay if the intention was to send people to /chaise/logout (instead of the main RBK page) post-logout. If not, the default_logout_path should be changed to whatever you want it to be.

@ljpearlman on rbk-staging, upon logout, the globus page is shown, not the chaise logout.

This is already done on both rbk-dev and rbk-staging, as well as in their recipes.

@svoinea the link is still wrong. I don't want it to go back to the search app which requires a login page. It should go to project static link. For rbk, it is https://staging.rebuildingakidney.org/image-annotation/,

The link is now implemented correctly on rbk.


A slurm sbatch executor

Coverage increased (+0.3%) to 85.447% when pulling ab907710c3625ea675f8bc52592e16373bb27f6a on enh/slurm_exec into 20b7767052b45a9bf8d4ae8f5b8fa9aac1416113 on master.

Yes I think it is cleaner to keep the process tree as small as possible.
Tristan Carel
On Thu, Apr 12, 2018 at 4:35 PM, Omar Awile<EMAIL_ADDRESS>wrote:

@ohm314 commented on this pull request.
In hpcbench/templates/sbatch.jinja
https://github.com/tristan0x/hpcbench/pull/147#discussion_r181104403:

@@ -0,0 +1,6 @@
+#!/bin/bash
+{%- for name, value in sbatch_arguments.items() %}
+#SBATCH --{{name}}={{value}}
+{%- endfor %}

+{{hpcbench_command}}
ah, that will execute in the same shell?
I never did that in sbatch script and I am not sure about the effects -
you think that's the best thing to do?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/tristan0x/hpcbench/pull/147#discussion_r181104403,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAWd-yLAnbMtG-IVHS2fO92mFCqm3g41ks5tn2YggaJpZM4TR3Ye
.


How to do routing specific to a service

This may be a basic use case but I couldn't figure out based on the documentation I looked at.
I am expecting each of my service to create some service level alerts and package them as part of their helm charts which seems simple enough to do - each service creates a Prometheus rule for alerts it cares about.
Is it possible for the service to allow implementing some of the routing rules as part of its deployment definition ? To me it seems like there is one config file where alert manager picks the routing information from. How can individual services update that config file (a secret in k8s) as part of their deployment ?

Thanks for your report. It looks as if this is actually a question about usage and not development.
It makes more sense to ask questions like this on the prometheus-users mailing list rather than in a GitHub issue. On the mailing list, more people are available to potentially respond to your question, and the whole community can benefit from the answers provided.


bsdthread_register error

Hello,
pgfutter was working well (some months ago). Now my Mac upgraded to Monterey 12.3.1.
Now any try to run pgfutter throws:
./pgfutter --help
fatal error: runtime: bsdthread_register error

runtime stack:
runtime.throw(0x1358b2a, 0x21)
	/goroot/src/runtime/panic.go:605 +0x95 fp=0x7ff7bfeff870 sp=0x7ff7bfeff850 pc=0x1029875
runtime.goenvs()
	/goroot/src/runtime/os_darwin.go:108 +0x83 fp=0x7ff7bfeff8a0 sp=0x7ff7bfeff870 pc=0x1027113
runtime.schedinit()
	/goroot/src/runtime/proc.go:482 +0xa1 fp=0x7ff7bfeff8e0 sp=0x7ff7bfeff8a0 pc=0x102c221
runtime.rt0_go(0x7ff7bfeff918, 0x2, 0x7ff7bfeff918, 0x0, 0x1000000, 0x2, 0x7ff7bfeffa78, 0x7ff7bfeffa83, 0x0, 0x7ff7bfeffa8a, ...)
	/goroot/src/runtime/asm_amd64.s:175 +0x1eb fp=0x7ff7bfeff8e8 sp=0x7ff7bfeff8e0 pc=0x1053fbb

My go version:
➜ go version
go version go1.18.4 darwin/amd64

Having the same issue here, Monterey 12.6
go version go1.20.4 darwin/amd64


Cleanup CNI and iptables binaries

istio-iptables is not used now (compiled into pilot-agent and CNI)
Drop dependency on XDS, 76M -> 53M in binary size. The changes to the Go code were to drop agent imports which bring a lot in. We were just referencing strings anyways

@howardjohn: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-basic-arm64_istio
65373e4ca080e3e6b013bfe91a43fc111c6b9a78
link
true
/test integ-basic-arm64

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-basic-arm64_istio
65373e4ca080e3e6b013bfe91a43fc111c6b9a78
link
true
/test integ-basic-arm64

release-test_istio
65373e4ca080e3e6b013bfe91a43fc111c6b9a78
link
true
/test release-test

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-basic-arm64_istio
65373e4ca080e3e6b013bfe91a43fc111c6b9a78
link
true
/test integ-basic-arm64

release-test_istio
65373e4ca080e3e6b013bfe91a43fc111c6b9a78
link
true
/test release-test

integ-security-istiodremote_istio
65373e4ca080e3e6b013bfe91a43fc111c6b9a78
link
true
/test integ-security-istiodremote

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-basic-arm64_istio
65373e4ca080e3e6b013bfe91a43fc111c6b9a78
link
true
/test integ-basic-arm64

release-test_istio
65373e4ca080e3e6b013bfe91a43fc111c6b9a78
link
true
/test release-test

integ-security-istiodremote_istio
65373e4ca080e3e6b013bfe91a43fc111c6b9a78
link
true
/test integ-security-istiodremote

integ-security_istio
65373e4ca080e3e6b013bfe91a43fc111c6b9a78
link
true
/test integ-security

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-basic-arm64_istio
65373e4ca080e3e6b013bfe91a43fc111c6b9a78
link
true
/test integ-basic-arm64

release-test_istio
65373e4ca080e3e6b013bfe91a43fc111c6b9a78
link
true
/test release-test

integ-security-istiodremote_istio
65373e4ca080e3e6b013bfe91a43fc111c6b9a78
link
true
/test integ-security-istiodremote

integ-security_istio
65373e4ca080e3e6b013bfe91a43fc111c6b9a78
link
true
/test integ-security

integ-pilot-istiodremote-mc_istio
65373e4ca080e3e6b013bfe91a43fc111c6b9a78
link
true
/test integ-pilot-istiodremote-mc

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-basic-arm64_istio
65373e4ca080e3e6b013bfe91a43fc111c6b9a78
link
true
/test integ-basic-arm64

release-test_istio
65373e4ca080e3e6b013bfe91a43fc111c6b9a78
link
true
/test release-test

integ-security-istiodremote_istio
65373e4ca080e3e6b013bfe91a43fc111c6b9a78
link
true
/test integ-security-istiodremote

integ-security_istio
65373e4ca080e3e6b013bfe91a43fc111c6b9a78
link
true
/test integ-security

integ-pilot-istiodremote-mc_istio
65373e4ca080e3e6b013bfe91a43fc111c6b9a78
link
true
/test integ-pilot-istiodremote-mc

integ-telemetry-istiodremote_istio
65373e4ca080e3e6b013bfe91a43fc111c6b9a78
link
true
/test integ-telemetry-istiodremote

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-basic-arm64_istio
65373e4ca080e3e6b013bfe91a43fc111c6b9a78
link
true
/test integ-basic-arm64

release-test_istio
65373e4ca080e3e6b013bfe91a43fc111c6b9a78
link
true
/test release-test

integ-security-istiodremote_istio
65373e4ca080e3e6b013bfe91a43fc111c6b9a78
link
true
/test integ-security-istiodremote

integ-security_istio
65373e4ca080e3e6b013bfe91a43fc111c6b9a78
link
true
/test integ-security

integ-pilot-istiodremote-mc_istio
65373e4ca080e3e6b013bfe91a43fc111c6b9a78
link
true
/test integ-pilot-istiodremote-mc

integ-telemetry-istiodremote_istio
65373e4ca080e3e6b013bfe91a43fc111c6b9a78
link
true
/test integ-telemetry-istiodremote

integ-helm_istio
65373e4ca080e3e6b013bfe91a43fc111c6b9a78
link
true
/test integ-helm

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-basic-arm64_istio
65373e4ca080e3e6b013bfe91a43fc111c6b9a78
link
true
/test integ-basic-arm64

release-test_istio
65373e4ca080e3e6b013bfe91a43fc111c6b9a78
link
true
/test release-test

integ-security-istiodremote_istio
65373e4ca080e3e6b013bfe91a43fc111c6b9a78
link
true
/test integ-security-istiodremote

integ-security_istio
65373e4ca080e3e6b013bfe91a43fc111c6b9a78
link
true
/test integ-security

integ-pilot-istiodremote-mc_istio
65373e4ca080e3e6b013bfe91a43fc111c6b9a78
link
true
/test integ-pilot-istiodremote-mc

integ-telemetry-istiodremote_istio
65373e4ca080e3e6b013bfe91a43fc111c6b9a78
link
true
/test integ-telemetry-istiodremote

integ-helm_istio
65373e4ca080e3e6b013bfe91a43fc111c6b9a78
link
true
/test integ-helm

integ-operator-controller_istio
65373e4ca080e3e6b013bfe91a43fc111c6b9a78
link
true
/test integ-operator-controller

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-basic-arm64_istio
65373e4ca080e3e6b013bfe91a43fc111c6b9a78
link
true
/test integ-basic-arm64

release-test_istio
65373e4ca080e3e6b013bfe91a43fc111c6b9a78
link
true
/test release-test

integ-security-istiodremote_istio
65373e4ca080e3e6b013bfe91a43fc111c6b9a78
link
true
/test integ-security-istiodremote

integ-security_istio
65373e4ca080e3e6b013bfe91a43fc111c6b9a78
link
true
/test integ-security

integ-pilot-istiodremote-mc_istio
65373e4ca080e3e6b013bfe91a43fc111c6b9a78
link
true
/test integ-pilot-istiodremote-mc

integ-telemetry-istiodremote_istio
65373e4ca080e3e6b013bfe91a43fc111c6b9a78
link
true
/test integ-telemetry-istiodremote

integ-helm_istio
65373e4ca080e3e6b013bfe91a43fc111c6b9a78
link
true
/test integ-helm

integ-operator-controller_istio
65373e4ca080e3e6b013bfe91a43fc111c6b9a78
link
true
/test integ-operator-controller

integ-pilot-istiodremote_istio
65373e4ca080e3e6b013bfe91a43fc111c6b9a78
link
true
/test integ-pilot-istiodremote

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-basic-arm64_istio
65373e4ca080e3e6b013bfe91a43fc111c6b9a78
link
true
/test integ-basic-arm64

release-test_istio
65373e4ca080e3e6b013bfe91a43fc111c6b9a78
link
true
/test release-test

integ-security-istiodremote_istio
65373e4ca080e3e6b013bfe91a43fc111c6b9a78
link
true
/test integ-security-istiodremote

integ-security_istio
65373e4ca080e3e6b013bfe91a43fc111c6b9a78
link
true
/test integ-security

integ-pilot-istiodremote-mc_istio
65373e4ca080e3e6b013bfe91a43fc111c6b9a78
link
true
/test integ-pilot-istiodremote-mc

integ-telemetry-istiodremote_istio
65373e4ca080e3e6b013bfe91a43fc111c6b9a78
link
true
/test integ-telemetry-istiodremote

integ-helm_istio
65373e4ca080e3e6b013bfe91a43fc111c6b9a78
link
true
/test integ-helm

integ-operator-controller_istio
65373e4ca080e3e6b013bfe91a43fc111c6b9a78
link
true
/test integ-operator-controller

integ-pilot-istiodremote_istio
65373e4ca080e3e6b013bfe91a43fc111c6b9a78
link
true
/test integ-pilot-istiodremote

integ-telemetry-mc_istio
65373e4ca080e3e6b013bfe91a43fc111c6b9a78
link
true
/test integ-telemetry-mc

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-basic-arm64_istio
65373e4ca080e3e6b013bfe91a43fc111c6b9a78
link
true
/test integ-basic-arm64

release-test_istio
65373e4ca080e3e6b013bfe91a43fc111c6b9a78
link
true
/test release-test

integ-security-istiodremote_istio
65373e4ca080e3e6b013bfe91a43fc111c6b9a78
link
true
/test integ-security-istiodremote

integ-security_istio
65373e4ca080e3e6b013bfe91a43fc111c6b9a78
link
true
/test integ-security

integ-pilot-istiodremote-mc_istio
65373e4ca080e3e6b013bfe91a43fc111c6b9a78
link
true
/test integ-pilot-istiodremote-mc

integ-telemetry-istiodremote_istio
65373e4ca080e3e6b013bfe91a43fc111c6b9a78
link
true
/test integ-telemetry-istiodremote

integ-helm_istio
65373e4ca080e3e6b013bfe91a43fc111c6b9a78
link
true
/test integ-helm

integ-operator-controller_istio
65373e4ca080e3e6b013bfe91a43fc111c6b9a78
link
true
/test integ-operator-controller

integ-pilot-istiodremote_istio
65373e4ca080e3e6b013bfe91a43fc111c6b9a78
link
true
/test integ-pilot-istiodremote

integ-telemetry-mc_istio
65373e4ca080e3e6b013bfe91a43fc111c6b9a78
link
true
/test integ-telemetry-mc

integ-ds_istio
65373e4ca080e3e6b013bfe91a43fc111c6b9a78
link
true
/test integ-ds

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-basic-arm64_istio
65373e4ca080e3e6b013bfe91a43fc111c6b9a78
link
true
/test integ-basic-arm64

release-test_istio
65373e4ca080e3e6b013bfe91a43fc111c6b9a78
link
true
/test release-test

integ-security-istiodremote_istio
65373e4ca080e3e6b013bfe91a43fc111c6b9a78
link
true
/test integ-security-istiodremote

integ-security_istio
65373e4ca080e3e6b013bfe91a43fc111c6b9a78
link
true
/test integ-security

integ-pilot-istiodremote-mc_istio
65373e4ca080e3e6b013bfe91a43fc111c6b9a78
link
true
/test integ-pilot-istiodremote-mc

integ-telemetry-istiodremote_istio
65373e4ca080e3e6b013bfe91a43fc111c6b9a78
link
true
/test integ-telemetry-istiodremote

integ-helm_istio
65373e4ca080e3e6b013bfe91a43fc111c6b9a78
link
true
/test integ-helm

integ-operator-controller_istio
65373e4ca080e3e6b013bfe91a43fc111c6b9a78
link
true
/test integ-operator-controller

integ-pilot-istiodremote_istio
65373e4ca080e3e6b013bfe91a43fc111c6b9a78
link
true
/test integ-pilot-istiodremote

integ-telemetry-mc_istio
65373e4ca080e3e6b013bfe91a43fc111c6b9a78
link
true
/test integ-telemetry-mc

integ-ds_istio
65373e4ca080e3e6b013bfe91a43fc111c6b9a78
link
true
/test integ-ds

integ-security-multicluster_istio
65373e4ca080e3e6b013bfe91a43fc111c6b9a78
link
true
/test integ-security-multicluster

integ-pilot-multicluster_istio
65373e4ca080e3e6b013bfe91a43fc111c6b9a78
link
true
/test integ-pilot-multicluster

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-basic-arm64_istio
65373e4ca080e3e6b013bfe91a43fc111c6b9a78
link
true
/test integ-basic-arm64

release-test_istio
65373e4ca080e3e6b013bfe91a43fc111c6b9a78
link
true
/test release-test

integ-security-istiodremote_istio
65373e4ca080e3e6b013bfe91a43fc111c6b9a78
link
true
/test integ-security-istiodremote

integ-security_istio
65373e4ca080e3e6b013bfe91a43fc111c6b9a78
link
true
/test integ-security

integ-pilot-istiodremote-mc_istio
65373e4ca080e3e6b013bfe91a43fc111c6b9a78
link
true
/test integ-pilot-istiodremote-mc

integ-telemetry-istiodremote_istio
65373e4ca080e3e6b013bfe91a43fc111c6b9a78
link
true
/test integ-telemetry-istiodremote

integ-helm_istio
65373e4ca080e3e6b013bfe91a43fc111c6b9a78
link
true
/test integ-helm

integ-operator-controller_istio
65373e4ca080e3e6b013bfe91a43fc111c6b9a78
link
true
/test integ-operator-controller

integ-pilot-istiodremote_istio
65373e4ca080e3e6b013bfe91a43fc111c6b9a78
link
true
/test integ-pilot-istiodremote

integ-telemetry-mc_istio
65373e4ca080e3e6b013bfe91a43fc111c6b9a78
link
true
/test integ-telemetry-mc

integ-ds_istio
65373e4ca080e3e6b013bfe91a43fc111c6b9a78
link
true
/test integ-ds

integ-security-multicluster_istio
65373e4ca080e3e6b013bfe91a43fc111c6b9a78
link
true
/test integ-security-multicluster

integ-pilot-multicluster_istio
65373e4ca080e3e6b013bfe91a43fc111c6b9a78
link
true
/test integ-pilot-multicluster

integ-telemetry_istio
65373e4ca080e3e6b013bfe91a43fc111c6b9a78
link
true
/test integ-telemetry

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-basic-arm64_istio
65373e4ca080e3e6b013bfe91a43fc111c6b9a78
link
true
/test integ-basic-arm64

release-test_istio
65373e4ca080e3e6b013bfe91a43fc111c6b9a78
link
true
/test release-test

integ-security-istiodremote_istio
65373e4ca080e3e6b013bfe91a43fc111c6b9a78
link
true
/test integ-security-istiodremote

integ-security_istio
65373e4ca080e3e6b013bfe91a43fc111c6b9a78
link
true
/test integ-security

integ-pilot-istiodremote-mc_istio
65373e4ca080e3e6b013bfe91a43fc111c6b9a78
link
true
/test integ-pilot-istiodremote-mc

integ-telemetry-istiodremote_istio
65373e4ca080e3e6b013bfe91a43fc111c6b9a78
link
true
/test integ-telemetry-istiodremote

integ-helm_istio
65373e4ca080e3e6b013bfe91a43fc111c6b9a78
link
true
/test integ-helm

integ-operator-controller_istio
65373e4ca080e3e6b013bfe91a43fc111c6b9a78
link
true
/test integ-operator-controller

integ-pilot-istiodremote_istio
65373e4ca080e3e6b013bfe91a43fc111c6b9a78
link
true
/test integ-pilot-istiodremote

integ-telemetry-mc_istio
65373e4ca080e3e6b013bfe91a43fc111c6b9a78
link
true
/test integ-telemetry-mc

integ-ds_istio
65373e4ca080e3e6b013bfe91a43fc111c6b9a78
link
true
/test integ-ds

integ-security-multicluster_istio
65373e4ca080e3e6b013bfe91a43fc111c6b9a78
link
true
/test integ-security-multicluster

integ-pilot-multicluster_istio
65373e4ca080e3e6b013bfe91a43fc111c6b9a78
link
true
/test integ-pilot-multicluster

integ-telemetry_istio
65373e4ca080e3e6b013bfe91a43fc111c6b9a78
link
true
/test integ-telemetry

integ-distroless_istio
65373e4ca080e3e6b013bfe91a43fc111c6b9a78
link
true
/test integ-distroless

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-basic-arm64_istio
65373e4ca080e3e6b013bfe91a43fc111c6b9a78
link
true
/test integ-basic-arm64

release-test_istio
65373e4ca080e3e6b013bfe91a43fc111c6b9a78
link
true
/test release-test

integ-security-istiodremote_istio
65373e4ca080e3e6b013bfe91a43fc111c6b9a78
link
true
/test integ-security-istiodremote

integ-security_istio
65373e4ca080e3e6b013bfe91a43fc111c6b9a78
link
true
/test integ-security

integ-pilot-istiodremote-mc_istio
65373e4ca080e3e6b013bfe91a43fc111c6b9a78
link
true
/test integ-pilot-istiodremote-mc

integ-telemetry-istiodremote_istio
65373e4ca080e3e6b013bfe91a43fc111c6b9a78
link
true
/test integ-telemetry-istiodremote

integ-helm_istio
65373e4ca080e3e6b013bfe91a43fc111c6b9a78
link
true
/test integ-helm

integ-operator-controller_istio
65373e4ca080e3e6b013bfe91a43fc111c6b9a78
link
true
/test integ-operator-controller

integ-pilot-istiodremote_istio
65373e4ca080e3e6b013bfe91a43fc111c6b9a78
link
true
/test integ-pilot-istiodremote

integ-telemetry-mc_istio
65373e4ca080e3e6b013bfe91a43fc111c6b9a78
link
true
/test integ-telemetry-mc

integ-ds_istio
65373e4ca080e3e6b013bfe91a43fc111c6b9a78
link
true
/test integ-ds

integ-security-multicluster_istio
65373e4ca080e3e6b013bfe91a43fc111c6b9a78
link
true
/test integ-security-multicluster

integ-pilot-multicluster_istio
65373e4ca080e3e6b013bfe91a43fc111c6b9a78
link
true
/test integ-pilot-multicluster

integ-telemetry_istio
65373e4ca080e3e6b013bfe91a43fc111c6b9a78
link
true
/test integ-telemetry

integ-distroless_istio
65373e4ca080e3e6b013bfe91a43fc111c6b9a78
link
true
/test integ-distroless

integ-cni_istio
65373e4ca080e3e6b013bfe91a43fc111c6b9a78
link
true
/test integ-cni

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-basic-arm64_istio
65373e4ca080e3e6b013bfe91a43fc111c6b9a78
link
true
/test integ-basic-arm64

release-test_istio
65373e4ca080e3e6b013bfe91a43fc111c6b9a78
link
true
/test release-test

integ-security-istiodremote_istio
65373e4ca080e3e6b013bfe91a43fc111c6b9a78
link
true
/test integ-security-istiodremote

integ-security_istio
65373e4ca080e3e6b013bfe91a43fc111c6b9a78
link
true
/test integ-security

integ-pilot-istiodremote-mc_istio
65373e4ca080e3e6b013bfe91a43fc111c6b9a78
link
true
/test integ-pilot-istiodremote-mc

integ-telemetry-istiodremote_istio
65373e4ca080e3e6b013bfe91a43fc111c6b9a78
link
true
/test integ-telemetry-istiodremote

integ-helm_istio
65373e4ca080e3e6b013bfe91a43fc111c6b9a78
link
true
/test integ-helm

integ-operator-controller_istio
65373e4ca080e3e6b013bfe91a43fc111c6b9a78
link
true
/test integ-operator-controller

integ-pilot-istiodremote_istio
65373e4ca080e3e6b013bfe91a43fc111c6b9a78
link
true
/test integ-pilot-istiodremote

integ-telemetry-mc_istio
65373e4ca080e3e6b013bfe91a43fc111c6b9a78
link
true
/test integ-telemetry-mc

integ-ds_istio
65373e4ca080e3e6b013bfe91a43fc111c6b9a78
link
true
/test integ-ds

integ-security-multicluster_istio
65373e4ca080e3e6b013bfe91a43fc111c6b9a78
link
true
/test integ-security-multicluster

integ-pilot-multicluster_istio
65373e4ca080e3e6b013bfe91a43fc111c6b9a78
link
true
/test integ-pilot-multicluster

integ-telemetry_istio
65373e4ca080e3e6b013bfe91a43fc111c6b9a78
link
true
/test integ-telemetry

integ-distroless_istio
65373e4ca080e3e6b013bfe91a43fc111c6b9a78
link
true
/test integ-distroless

integ-cni_istio
65373e4ca080e3e6b013bfe91a43fc111c6b9a78
link
true
/test integ-cni

integ-ipv6_istio
65373e4ca080e3e6b013bfe91a43fc111c6b9a78
link
true
/test integ-ipv6

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-basic-arm64_istio
65373e4ca080e3e6b013bfe91a43fc111c6b9a78
link
true
/test integ-basic-arm64

release-test_istio
65373e4ca080e3e6b013bfe91a43fc111c6b9a78
link
true
/test release-test

integ-security-istiodremote_istio
65373e4ca080e3e6b013bfe91a43fc111c6b9a78
link
true
/test integ-security-istiodremote

integ-security_istio
65373e4ca080e3e6b013bfe91a43fc111c6b9a78
link
true
/test integ-security

integ-pilot-istiodremote-mc_istio
65373e4ca080e3e6b013bfe91a43fc111c6b9a78
link
true
/test integ-pilot-istiodremote-mc

integ-telemetry-istiodremote_istio
65373e4ca080e3e6b013bfe91a43fc111c6b9a78
link
true
/test integ-telemetry-istiodremote

integ-helm_istio
65373e4ca080e3e6b013bfe91a43fc111c6b9a78
link
true
/test integ-helm

integ-operator-controller_istio
65373e4ca080e3e6b013bfe91a43fc111c6b9a78
link
true
/test integ-operator-controller

integ-pilot-istiodremote_istio
65373e4ca080e3e6b013bfe91a43fc111c6b9a78
link
true
/test integ-pilot-istiodremote

integ-telemetry-mc_istio
65373e4ca080e3e6b013bfe91a43fc111c6b9a78
link
true
/test integ-telemetry-mc

integ-ds_istio
65373e4ca080e3e6b013bfe91a43fc111c6b9a78
link
true
/test integ-ds

integ-security-multicluster_istio
65373e4ca080e3e6b013bfe91a43fc111c6b9a78
link
true
/test integ-security-multicluster

integ-pilot-multicluster_istio
65373e4ca080e3e6b013bfe91a43fc111c6b9a78
link
true
/test integ-pilot-multicluster

integ-telemetry_istio
65373e4ca080e3e6b013bfe91a43fc111c6b9a78
link
true
/test integ-telemetry

integ-distroless_istio
65373e4ca080e3e6b013bfe91a43fc111c6b9a78
link
true
/test integ-distroless

integ-cni_istio
65373e4ca080e3e6b013bfe91a43fc111c6b9a78
link
true
/test integ-cni

integ-ipv6_istio
65373e4ca080e3e6b013bfe91a43fc111c6b9a78
link
true
/test integ-ipv6

integ-pilot_istio
65373e4ca080e3e6b013bfe91a43fc111c6b9a78
link
true
/test integ-pilot

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-security-multicluster_istio
65373e4ca080e3e6b013bfe91a43fc111c6b9a78
link
true
/test integ-security-multicluster

integ-cni_istio
c60695031ae300e36ce05122826e32e6192a8f9c
link
true
/test integ-cni

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


Coverage is always failing, even in PRs that increase coverage (see closed PRs)

As far as I can see, the coverage failing is due to:
1- new paths open that aren't covered in the same repo (i.e. deployer adding options to log or not)
2- code size changes. lines_covered/total_lines can be reduced by either reducing lines_covered or increasing total_lines.

Looks like it was caused because the going to be merged PR wasn't updated with the last changes from main. Will close the issue for now and re-open if it happens again.


Signal -> Input link 404s

This page
http://elm-lang.org/learn/Interactive-UI-Elements.elm
linked from here
http://elm-lang.org/Learn.elm
gives me a 404.

Duplicate of #230

That link has been removed in favor of https://github.com/evancz/elm-architecture-tutorial, check that out instead!


Add no-clean and no-update flags

It would be useful to have a flag that skips configuration inside a phase (for rapid debugging).


add "gaby summarize" functionality and page

Add a new page (similar to the search page), which allows the user to input an issue URL and get a Gemini-generated summary of that issue and all of its comments so far.

Can we expand this to the github discussion too?

Yes, definitely.
Also we should add a feature summarize the discussion since a certain time (feature request from @cherrymui).


Fix chat name color not immediately changing after player sets chat name color

Actual Behavior
The first time a player chats on the server after changing their chat name color, the old color is used.
Expected Behavior
Modifying chat name colors should take effect immediately.

This may be resolved by taking Ren's suggestions into account: https://github.com/RP-Kit/RPKit/pull/662


NFT image is not viewable in my wallet

After minting i imported the NFT with my address & token ID into my wallet, its getting imported but i can see only an text on that NFT

This is how my basic test contract look's like:

Deployment script

:

Goerli test net block explorer ,after successful transaction

Change your token uri to https://ipfs.io/ipfs/Q....

Can you share how your metadata looks like?

What wallet did you used?

Metamask mobile

I also have the same issue........

@JAI-VINOD-GIT are you able to see it on OpenSea?
I have the same issue for non erc-721a NFTs, and it maybe it's not an issue of this implementation.

Hi,
you have to override function tokenURI, not _baseURI. This because if _baseURI is set, then tokenURI (which is the function called to check the NFT metadata) will return a concatenation of _baseURI and the tokenID. Also for me it worked passing the https URL like this:
 function tokenURI(uint256 tokenId) public view virtual override returns (string memory) {
    if (!_exists(tokenId)) revert URIQueryForNonexistentToken();

    return 'https://gateway.pinata.cloud/ipfs/"the metadata CID"';
}


Creating podcast md file for myanmar

Add Techshaw podcast to Markdown file.
Hacktoberfest notes:

due to volume of submissions, we may not be able to review PRs that do not pass tests and do not have informative titles.
please read our contributing guidelines
be sure to check the output of Travis-CI for linter errors
if this is your first open source contribution, make sure it's not your last!

What does this PR do?
Add Resource(s) | Remove Resource(s) | Add info | Improve Repo
For resources
Description
Why is this valuable (or not)?
How do we know it's really free?
For book lists, is it a book? For course lists, is it a course? etc.
Checklist:

[ ] Not a duplicate
[ ] Included author(s) if appropriate
[ ] Lists are in alphabetical order
[ ] Needed indications added (PDF, access notes, under construction)

language code for burmese is 'my'


Downloads Queue

Can we create a queue for the downloads, so that only one mod category can be downloaded at a time?
I think this will help many users who experience download freezing due to bandwidth issues.

I have to investigate how I can do this
will take some time

Debug.zip
Release.zip


Add IAM/STS context condition keys

These are yet missing: https://docs.aws.amazon.com/IAM/latest/UserGuide/reference_policies_iam-condition-keys.html

Actually: no. While these are listed in the main IAM docs, these are service specific conditions of IAM and STS and already covered.


readme with description

@swagnercarena If the readme contains the necessary description of what the code is doing and how it can be used (e.g. what the examples are), that'd be great such that I know how I can test it.

This has now been done.


Add CMake support

This adds CMakeLists.txt from vcpkg. The project compiles locally, I haven't yet tested it with AliceVision. I will add AliceVision support in a subsequent PR.

@simogasp We should probably have av_develop in this repository too.

@simogasp We should probably have av_develop in this repository too.

done, it's the default branch now and I changed the target branch of this PR as well

@simogasp I have fixed all issues that you've identified. Note, that I disable OpenMP support because the current code is broken and needs investigation on whether the simple compile issues I've seen are the only ones and there isn't more significant bitrot.

@simogasp Just a friendly ping :-)

thanks for the reminder, I've forgotten


[FLOC-2970] Improved wait error

This PR adds a more explicit check of the states that Cinder volumes traverse when performing create/delete and attach/detach operations.  This allows unexpected states to raise a more useful exception. See, in particular, the test test_disk_attachment_fails_with_conflicting_disk in test_cinder.py, which now sees an UnexpectedStateError rather than a TimeoutError.  The error is both more informative and occurs sooner.
To quote https://github.com/ClusterHQ/flocker/pull/1910:
"Unfortunately these tests can not be run using our existing CI system and are currently being run manually on a devstack instance running on an on-metal Rackspace server. To run these tests, ssh into the Rackspace server then ssh into the guest node on this server. The code has already been checked out on this guest and the tests can be run there. Please ask [@zubron] for connection details."
There are still some potential problems, such as another instance attaching a volume before the polling sees a final 'available' state, but these can be worked out for FLOC-1832.

Looks good. One optional suggestion. I noticed a test failure so kicked off another run. Please merge when the tests pass.
Thanks!


Update ws to 8.18.0

npm uninstall @kubernetes/client-node @storybook/cli jest-environment-jsdom webpack-bundle-analyzer webpack-dev-server @pmmmwh/react-refresh-webpack-plugin storybook @types/webpack-dev-server
npm i -D<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>npm i -D --save-exact<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>

/cc @Randy424