Unused exception variable warning not detected by CI

          The exception parameter `ex` is not used and should have caused CI to fail!

Originally posted by @achim-k in https://github.com/foxglove/ros-foxglove-bridge/pull/191#discussion_r1132433845

From https://stackoverflow.com/a/56085300:

Clang
Bug report: https://bugs.llvm.org/show_bug.cgi?id=41746
It turns out that clang has the warning -Wunused-exception-parameter, although it is not activated by any of the groups -Wall, -Wextra, or -Wunused.
GCC
Bug report: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=90353
As noted in a comment to this question and in the bug report, all catch parameters are always marked as used. This is being investigated in the linked bug report.


Question abut performance

Hey guys. Greate job on select2 btw.
I would like to ask what is the perfomarnce of new select2 v 4.0?
Is it faster to previous version? Have somebody tried to measure it?

Is it faster to previous version?

Much faster, I put quite a bit of effort into making sure that the major performance issues were removed. You can read a bit about it in the blog post I wrote.

Have somebody tried to measure it?

I don't have any recent measurements, but at the time I was able to drop querying 10,000 <option> elements from 2.5 seconds to just under half a second on the first query. It's much quicker after the first query (under 100ms) because we do quite a bit of caching.
If someone is interested in contributing performance tests, that'd be helpful to allow us to quantify the improvements.

Nice work Kevin.  Is this only for AJAX requests?  Is searching any faster if constructing from HTML elements, or JSON (non-AJAX requests)?

Is this only for AJAX requests?

AJAX requests weren't causing most of the performance issues in Select2 3.x. While there were some performance issues relating to caching data objects, the performance was already pretty good.

Is searching any faster if constructing from HTML elements

It's much faster if working from a <select> with lots (10,000+) of elements. Right now there is a slight delay for the first search (when the dropdown opens) which has to due with the initial caching, but it shouldn't be noticeable and it should only happen once.

or JSON (non-AJAX requests)?

This is in the same boat as AJAX requests. The only difference is that we automatically convert data-provided queries into standard <option> elements when Select2 is initialized.

Hey Kevin, thanks for the update! Indeed, it is a fair bit faster. Still having some bottlenecks though, check out this fiddle with 10k items:
https://jsfiddle.net/f57fd7mj/4/
The bottleneck appears to be opening the menu -- selecting items, searching, all that is great, but anything that opens that dropdown is very slow, 3 seconds or so on my machine.
Any ideas on how I might be able to speed that up? Seems like that could potentially be built and cached on load, so opening doesn't take so long.

Note that this answer really helps for big lists:
http://stackoverflow.com/a/25466453/1974848
Would be cool to see that kind of internal lazy loading built in.

Hello! I’m profiling with this example with a lot of options, especially with ArrayAdapter  (data) and templateResult:
http://codepen.io/molily/pen/EjEZKQ
I’m using the Timeline and Profiles of the Chrome Dev Tools. There are a some things I noticed and I’d like to mention, hopefully that’s helpful for further perf optimization.

four calls of SelectAdapter.prototype.current. This is costly because of .find(':selected'). All selected options need to be walked, plus parentNode.selectedIndex is read each time (this is how Sizzle works because of a Safari bug).

I’ve implemented a low-level SelectAdapter.prototype.current for this special case, it’s a bit faster but I guess the gain is only noticeable in my rather contrived performance stress test with 20,000 options.
2. When using ArrayAdapter, I understand the DOM has to be created upon the first Select2 opening. Some micro-optimizations would be possible there, but I guess the performance boils down to DOM element creation (innerHTML) and $.data being the bottleneck.
However, is it necessary to recreate the DOM with every subsequent opening?
Results.prototype.bind = function (container, $container) {
  // …
  container.on('results:all', function (params) {
    self.clear();
    self.append(params.data);

The clear() operation is very costly, recreating all options too. AFAICS, recreating is currently necessary because

The select value might have changed
Templates might use the selected state, even return null

Is it possible to implement a cache so the DOM doesn’t have to be created from scratch with each opening if the value hasn’t changed?
3. Three calls to positionDropdown. One in the beginning, two after DOM creation. This is costly because it involves synchronous layouting of all options due to jQuery#position, position, outerHeight calls.
4. Results.prototype.setClasses is relatively fast but could benefit from some optimization since it’s does heavy DOM operations (mostly setAttribute calls). For example, I guess the list var $selected = $options.filter('[aria-selected=true]'); could be aggregated in the loop before, saving the DOM query.
In my real-world app, I have up to 1000 options with a fairly complex templateResult. I’ve implemented the pagination solution mentioned above to speed up the rendering, showing 100 options in each batch.

I've been considering creating an adapter or decorator that enables pagination on local data sets, similar to how it is handled with remote data sets.

Hello! I’m profiling with this example with a lot of options

Thank you! It's always good to see profiling done by others, as I usually make some mistake when doing it. :)

$.data being the bottleneck

I've actually looked into this, and it used to be around 15x worse. Here's a writeup I did on why we use $.data.

However, is it necessary to recreate the DOM with every subsequent opening?

Yes, specifically for the case of AJAX and other custom data adapters.

Results.prototype.setClasses is relatively fast but could benefit from some optimization since it’s does heavy DOM operations

I'm always open to pull requests with optimizations, as long as it doesn't break anything.

Closing, since there has been no discussion for over 2 years.


Handle Lambda Timeout in Export to FireCloud

The connection to a lambda times out after 30 seconds. But the lambda will continue to processing for up to 300 (?) seconds.
While I haven't seen a timeout yet, I worry that with bigger datasets it could happen.
If the browser makes a call and it times out, the UI should display a message indicating that it timed out but may eventually suceed.
moved from ticket https://github.com/DataBiosphere/boardwalk/issues/7

This will become moot as we redirect to FireCloud to handle the import, #11, so closing this.


publish snapshot releases on every merge to main

This is part of a project being undertaken by OSP to help new code make it's way to TBD's downstream projects faster. It creates a snapshot release for each merge to main, which is published to our Artifactory* registry. Once this is done, downstream projects (ie. tbdex-js and developer.tbd.website) can pull in new web5-js features before a real release has been produced by depending on the snapshot version.
It creates snapshot release for any packages that have changed since the last snapshot version. It does this by counting the number of commits in each package since the last time the package.json version was changed, and producing a snapshot release name in the format <version>-SNAPSHOT.<commit count> (for example, there have been 55 commits that touched packages/api since it was bumped to 0.8.4, so it will produce snapshot version 0.8.4-SNAPSHOT.55). It checks if a snapshot with this version has already been published, and if not it builds and publishes the snapshot release.
Once that has been published, someone writing documentation for developer.tbd.website can set the example to depend on @web5/api version 0.8.4-SNAPSHOT.55 and write sample code that can be validated against that snapshot.
*Artifactory: behaves like npmjs.com, but isn't real npmjs.com so the high number of releases this creates will not spam up our npmjs.com page.

@finn-tbd Is it possible to publish the short SHA in the version <version>-SNAPSHOT.<short-SHA> rather than commit count?
If no, how does a consumer of the published release know which commit it is associated with?  I'm imagining a scenario where a downstream consumer reports they ran into an issue/bug with 0.8.4-SNAPSHOT.55.  During troubleshooting, how would we determine which commit in the main branch this release was cut from?  Is the only way to manually look up the commit for 0.8.4 and then count 55 commits later?

It's possible, but that would break npm's versioning scheme. in particular, it would make it unable to determine which is the latest snapshot. If that's something we're super concerned about, we could combine the two approaches (ie. <version>-SNAPSHOT.<count>-<sha>) and probably have comparable versions, but i'm 100% sure how npm's version comparing works. Should I implement the combined approach?

It's possible, but that would break npm's versioning scheme. in particular, it would make it unable to determine which is the latest snapshot.

Can you elaborate on the concern?
Based on npm publish command in this PR it appears the desired outcome is that if someone runs npm install @web5/<package-name> --registry https://blockxyz.jfrog.io/artifactory/api/npm/tbd-oss-snapshots-npm/ without specifying a specific version that latest will be the most recent commit to main?
Do we really want latest to be the latest commit to main or should latest be the most recent version that went through the normal release process?

Based on npm publish command in this PR it appears the desired outcome is that if someone runs npm install @web5/ --registry https://blockxyz.jfrog.io/artifactory/api/npm/tbd-oss-snapshots-npm/ without specifying a specific version that latest will be the most recent commit to main?

correct

Do we really want latest to be the latest commit to main or should latest be the most recent version that went through the normal release process?

I would expect the latest version in the snapshot repository to be the latest snapshot. If we just used the SHA and had no count, it would still install a snapshot release, it just wouldn't be the latest one. I'm not 100% sure how it would pick but i think it would be the (alphabetically) highest SHA, so closest to fffffff.
i've updated it to include the SHA in the snapshot version, so version numbers are computed like this:
snapshot_version="${base_version}-SNAPSHOT.${commits_since_version_bump}-${last_commit_to_package:0:7}"

for example, @web5/crypto's latest snapshot number is 0.4.0-SNAPSHOT.97-7442465


New package: EnergyModelsCO2 v0.7.0

Registering package: EnergyModelsCO2
Repository: https://github.com/EnergyModelsX/EnergyModelsCO2.jl
Created by: @JulStraus
Version: v0.7.0
Commit: 06d5a8bb760dca61b32c1f5576a668a384191d13
Reviewed by: @JulStraus
Reference: https://github.com/EnergyModelsX/EnergyModelsCO2.jl/commit/06d5a8bb760dca61b32c1f5576a668a384191d13#commitcomment-145280267

[noblock] Yeah, it’s totally fine.


Filter by Categories [Project Gallery]

In the dropdown, when you click a new category group, it refreshes the window and removes the applied filter from the dropdown

Also, we should remove the default categories from that dropdown because they are considered for every project


Mass source code rework/ cleanup

Describe the change
Source code is quite non standard, and does not conform to pep standard or any standards for that matter, the argument list is now too lengthy with arguments that are currently defunct after removing the internal neural networks. External libraries are uneccessarily split, and should be instead included in nemesyst. Documentation needs a rework after neural network separation.
Why this is desireable
Causing my eyes to bleed now that I am increasingly familiar with python.
Example?
Cannot run nemesyst with python version 2
Additional context
Lets just clean things up significantly to make things easier for people to understand and for us to maintain, maybe even use magic functions for once.

https://github.com/DreamingRaven/nemesyst/pull/85


Layout duplicate when using a Custom Layout

What you were expecting:
Use a Custom Layout
What happened instead:
The admin layout is duplicate

Steps to reproduce:
Install admin on rest (Admin-on-REST Tutorial)
Follow the custom layout documentation
Related code:
The code of the documentation

CodeSandbox (https://codesandbox.io/s/nklv6w52kj)

Environment

Admin-on-rest version: 1.4.0
Last version that did not exhibit the issue (if applicable): 1.3.4
React version: 16.2.0
Browser: every browsers

Sorry about that, we did not update this part of the documentation on 1.4.0


requireDefaultImportShorthand and friends

I'd like to have a rule, which allows the following
import _ from "lodash";

but disallows the following (equivalent) code:
import {default as _} from "lodash";

And a similar rule for default exports. Allow this:
export default {
  field1: value1,
  field2: value2
};

and disallow this:
let myObject = {
  field1: value1,
  field2: value2
};
export {myObject as default};

I would call these rules requireDefaultImportShorthand and requireDefaultExportShorthand, but I am open to name changes. The dual rules (the ones with disallow) should also be implemented.
Any opinions?

---
Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/25848297-requiredefaultimportshorthand-and-friends?utm_campaign=plugin&utm_content=tracker%2F281640&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F281640&utm_medium=issues&utm_source=github).

Not sure how would you enforce second case, like what if
let myObject = {
  field1: value1,
  field2: value2
};
// ... lots of code, or no code at all
myObject.field3 = value3;
export {myObject as default};

?

Ok the way I wanted to implemt this (probably this weekend), is:
For
export default {
  field1: value1,
  field2: value2
};

the AST looks somewhat like
{
  "type": "ExportDefaultDeclaration",
  "declaration": {
    "type": "ObjectExpression",
    "properties": [/*...*/]
  }
}

So prohibiting this with disallowDefaultExportShorthand is basically only calling disallowNodeTypes with "ExportDefaultDeclaration".

The case of requireDefaultExportShorthand is only a little bit more complicated. Requiring the default export shorthand, means dissallowing code like
export {myObject as default};

For this snippet the AST looks somewhat like
{
  "type": "ExportNamedDeclaration",
  "declaration": null,
  "specifiers": [
    {
      "type": "ExportSpecifier",
      "local": {
        "type": "Identifier",
        "name": "myObject"
      },
      "exported": {
        "type": "Identifier",
        "name": "default"
      }
    }
  ],
}

So, for the ExportSpecifier we need to disallow the use of "default" in the exported.name property.
@markelog I hope, this answers your question. The rules for the imports can be handled accordingly.

We released 3.0 recently! We also wrote a post about how 3.0 will be our last major release (since we are deprecating the project) and that we are merging with ESLint!
Thus we won't be working on any new features moving forward which includes new rules/options. We will continue to fix bugs and work on CST/better autofixing for current rules in the upcoming months both to help JSCS users and to gain experience that we can hopefully use in ESLint. But otherwise we both teams will be working on getting ESLint feature parity with JSCS and just a nice transition for our users.
I'm putting an orphaned label to note this issue isn't planned to be worked on, but might be a good contribution as a custom rule (not in JSCS core itself).
I would encourage anyone who wants the rule to try writing it themselves: I would either write a custom rule or submit an issue to ESLint and if accepted a PR. Otherwise a custom rule that won't be in core repo itself.
JSCS rules are also very similar to ESLint rules: here are some resources to get started:

Project-specific Lint Rules with ESLint
Creating Custom Rules for ESLint
Maintaining JavaScript Code Quality with ESLint


CRUD Locale Interface

Functional Requirements

Core CRUD Operations

Create: Add new JSON objects
Read: Retrieve existing JSON objects
Update: Modify existing JSON objects
Delete: Remove existing JSON objects

Questions:

How will merging work?
Will operations like Update/Delete be handled by the entire object or will be get specific objets keys within pre-exsiting json.

The CRUD interface is meant for the locale object.
Different Object stores will provide different update/merge methods. An object stored in an S3 bucket will not allow for partial updates. The interface for a partial update in SQL or MongoDB are completely different.
The specification for this interface is to create a new locale object. to update [overwrite] and existing locale object. delete an locale object and read an exisitng locale object.
Access restricitions are to be covered in a different ticket.


readme update

Signed-off-by: Chengxuan Xing<EMAIL_ADDRESS>

I understand the need for exit(), just suggesting the exit code be eg 1 instead of 0 in case of error.
On Jan 12, 2023 at 6:58 AM -0500, Chengxuan Xing @.***>, wrote:

@Chengxuan commented on this pull request.
In holder/wallet/index.js:

 })

.catch((err) => {

 console.error(err);

});

 console.error(err.message);

}).finally(() => process.exit(0));
this is just there because node.js thread doesn't exist.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you commented.Message ID: @.***>


Fully working proof of concept

Nice and simple. :+1: :+1: :smile:

Thanks for checking over @rhattersley - think I've addressed your comments in the review.
I'll add some travis testing once this is merged.

Super duper. :smile:


Ensure destructive actions work independently of action.destructive_requires_name

There are a couple of destructive APIs in Elasticsearch that allow wildcards (i.e. * or _all) by default (configurable with the setting action.destructive_requires_name). The default value for this setting will change with https://github.com/elastic/elasticsearch/pull/66908. We have put a stop-gap solution in place in https://github.com/elastic/rally-teams/pull/58 to set this value to false for all clusters that are configured by Rally. However, we should ensure that we always use explicit names in destructive actions as not all cluster might be configured by Rally. The affected APIs are:

Adding an index block
Open / close index API
Delete Index / data stream

Note: I am not aware that we add index block or use the open / close index APIs anywhere but I wanted to mention them for completeness.
For the delete index / data stream APIs which are supported out of the box by Rally should choose one the following approaches:

Temporarily set action.destructive_requires_name to false via the cluster settings API and reset it afterwards.
Resolve index names containing patterns via an API call and enumerate all index names explicitly.

When we have implemented support in Rally, we should also revert the stop gap solution implemented in https://github.com/elastic/rally-teams/pull/58  after a short grace period.

@DJRickyB can you please have a look at this one?

@DJRickyB can you please have a look at this one?


Changed the _get_blocks() method of block.Blocks()

A multi-block vector slice of World().blocks now properly returns block data instead of inevitably setting it to 0. Tested with Raspberry Jam.

#22 is fixed by this change for Raspberry Jam.

Just discovered a major problem resulting from a misunderstanding of which of the separators (comma, and vertical bar) were used for separating block ID and data, and for separating individual blocks from each-other in the returned network transaction. Have edited a fix, am now testing...

Just tested on vanilla Minecraft Pi Edition 0.1.1-6, fully functional.


KAFKA-2212: Authorizer CLI implementation.

@junrao I haven't added 2 things that you recommended yet.

I haven't add --addproducer --addconsumer options. I remember in review of KAFKA-2210 you recommended that we add these options so users don't have to call the CLI multiple times. This CLI is already looking very busy so I wanted to confirm that we still want to go ahead and add more options rathern than just adding the commands in help message.

I haven't created a map of what actions are meaningless (as of now) for a resource as you recommended in jira. I just noticed that when I went to the jira to mark it as in progress.

Yes, I think adding the --addproducer --addconsumer will be convenient since most users will be using that.

A few other things.
a. In terms of testing, now that we have all the pieces, we should add some kind of integration test. For example, we can authenticate with SSL and set some permissions based on SSL principal name and verify some common requests against the broker. We can do this either in this jira or a followup one.
b. I was thinking whether it will be useful to have wildcard resources. For example, perhaps you can grant all topics to MirrorMaker and allow a user to read a topic from any consumer groups.

@junrao  Thanks for your comment. I will add the producer and consumer option.
a. Will file a follow up jira for the integration test. I was actually waiting for the sasl patch where I know we already have a producer consumer test with MiniKDC which sets up a kerberos identity and was planning to modify that test only but I can try to write a test using ssl identities.
b. Makes sense. I think the concept of superuser kind of achieves this at a higher granularity as it grants access to all resources for all actions.

@Parth-Brahmbhatt, @junrao Yeah, I think an integration test is indeed very important so that we can find issues like KAFKA-2579 before the release. I was actually going to file an issue about that, but I'll leave it to you Parth.

Add --producer and --consumer options + unit test for the same. All comments addressed.
Will create a jira for the integration test.

Could you also write up a wiki on how to use the AclCommand?

@junrao Should I just modify the KIP with the CLI usage or create a new wiki?

I don't know what is the right answer regarding whether to update the KIP or a new wiki page, but I think it would also be helpful to see some example output after invoking the various commands.

@Parth-Brahmbhatt : We can create a new wiki to describe how to use the ACL command.

Added getAcls(), Still need to add the wiki page.

Thanks for the patch. LGTM.


node-notifier: Remove unused reference

It can be removed.
It should be removed.

@progre Thanks mate!


Any more optimizing space with intel SIMD

BLAKE3 performance is really so impressive, just wondering that besides current AVX512, whether there is any more optimizing space based on intel SIMD, like existing cryptographic related instructions. Thanks

Not that I'm aware of in common use cases, but Samuel is the expert on this. In my head, the known areas of missing optimizations are:

The C implementation is not multithreaded.
The Rust implementation supports multithreading, but currently it works best in an all-at-once approach, like hashing an entire memory-mapped file in one go. An interleaved-from-the-front approach is also possible, with all the worker threads taking chunks from the start of the input in an alternating fashion, but we haven't implemented it yet. That would probably require some extra memory allocation, but it would solve some thrashing issues on spinning disks, and it might be easier than memory mapping for some applications to deploy. If/when we do implement this, it will probably become b3sum's default behavior, assuming the performance is close enough.
Extended outputs don't take full advantage of SIMD. When you hash a 1 GB file, we use whatever max-width SIMD vectors your processor supports, but if you want to produce 1 GB of output, those same optimizations don't get used. Instead the implementation will just call the one-block compression function in a loop. There's no particular barrier to vectorizing output just like we've done with input, but it's a very rare use case, and we haven't gotten around to it.

I should add that while "produce 1 GB of output" is a very rare use case today, once it's fully optimized it might be tempting for someone to use BLAKE3 as a stream cipher, and maybe then it would become less rare :)

@sharifib until these XOF optimizations get added, a reasonable workaround
could be to use BLAKE3 to generate a regular 32-byte hash, and to then use
that hash as a stream key for ChaCha20 on the output side. Any fast ChaCha
implementation already has the SIMD optimizations we're discussing here.
This would also give you the option of using ChaCha12 or ChaCha8, depending
on your opinion about their security margins. BLAKE has around the same
security margin in this use case as a hypothetical "ChaCha14".
On Wed, Jun 8, 2022 at 8:58 AM sharifib @.***> wrote:

FYI, the missing SIMD output optimizations seem to be a bottleneck in
applications like LtHash
https://engineering.fb.com/2019/03/01/security/homomorphic-hashing/#:~:text=LtHash takes a set of arbitrarily long elements as input%2C and produces a 2KB hash value as output. Two LtHash outputs can be “added” by breaking up each output into 16-bit chunks and performing component-wise vector addition modulo 216.
LtHash takes a set of arbitrarily long elements as input, and produces a
2KB hash value as output. Two LtHash outputs can be “added” by breaking up
each output into 16-bit chunks and performing component-wise vector
addition modulo 2^16
Basically, individual item hashers produce 2KB outputs (4KB in LtHash32
which uses 32-bit chunks) which are treated as vectors to combine them
homomorphically. For LtHash32 benchmarking, I've measured over 90% of the
total runtime being spent in the output loop.
—
Reply to this email directly, view it on GitHub
https://github.com/BLAKE3-team/BLAKE3/issues/137#issuecomment-1150104656,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAGSGBDLXFVLFNJGAMKDUKTVOC7L7ANCNFSM4UG637OA
.
You are receiving this because you commented.Message ID:
@.***>


Avoid clobbering assembly settings from other plugins

I encountered this issue when trying to write an SBT auto plugin which adds sbt-assembly settings. Looks like a hang-over from the days before sbt-assembly was made an auto plugin.
Since sbt-assembly is now an auto plugin, the baseAssemblySettings will already have been appended to the project. Appending them again in uniformAssemblySettings is unnecessary, and will clobber changes made by other plugins which add functionality on top of on sbt-assembly.

LGTM

LGTM


Unsubscribing from observables

Hey,
When you are loading data like:
let fetchProductStatuses = () => {
    Client.taxonomy("product_status")
        .get()
        .subscribe(response => {
            productStatuses = response.taxonomy.terms;
            notifyChange();
        });
}

You should also have a way of unsubscribing from the Observable when its no longer needed (usually when user goes to another page, but can be different). The consequences  of not doing so can be quite important because the subscription code upon completion can be executed after user left the page. Ideally, you should cancel the HTTP request (as well as the execution of code in your subscribe section) when user leaves the page or you no longer need it.
In Angular, this can be best achieved with takeUntil that uses a notifier on ngDestroy which gets called when component gets destroyed. In React, you could use onUnmount. Not sure about Vue, but surely there is something similar.
To see that your code is cancelling request properly, add a delay to your Observables and try switching pages. You should see that upon switching to another page, the request is cancelled in network tab in dev tools of your browser. See the top answer here  to see how it can be used with Angular.

@Enngage can I implement unsubscribe during beforeDestroy() or destroyed() method. I am a little confused because during beforeDestroy() the component is still fully functional. Not sure what's the right place. But I think its safer to do it in destroyed(). Let me know your thoughts.

@Enngage is on vacation until tomorrow. he'll answer then.
@Simply007 do you know the answer, by any chance?

@sripaulgit I'm way more familiar with Angular then React, but destroyed() seems like a way to go. You shouldn't cancel observables while the page is still active so either use destroyed or some 'afterDestroy' if there is any.
Also, I would highly recommend using takeUntil rxjs operator rather then using the unsubscribe method on the obsevables. This is because using takeUntil uses less code and is easier to manage.

Thanks @Enngage. I'd be interested to take this on and implement with takeUtil. I just filed a PR for similar one in the react sample.

In my opinion, it is better to use beforeDestroyed. This is how it is solved in vue-rx.
I have just created poll on twitter - let's see :-)
https://twitter.com/ChrastinaOndrej/status/1007574909558632449

Linking issue: https://github.com/Kentico/cloud-sample-app-react/issues/66

implementation would be similar


TypeError in automatic annotations with tag

I'm trying to add my classifier as a serverless function. But I get "TypeError: Cannot read properties of null (reading 'constructor')" in UI. I have simplified the handler function to the form:
def handler(context, event):
    context.logger.info("Run classifier...")

    results = [{
        "label": "class",
        "type": "tag",
    }]

    return context.Response(body=json.dumps(results), headers={},
        content_type='application/json', status_code=200)

But still getting the same error.
spec in yaml file looks like:
    spec: |
      [
        {
          "id": 1,
          "name": "class"
        }
      ]

For reproducibility, you can modify this part of the code: https://github.com/openvinotoolkit/cvat/blob/develop/serverless/openvino/omz/public/yolo-v3-tf/nuclio/model_handler.py#L153
results.append({
    "confidence": str(obj['confidence']),
    "label": self.labels.get(obj_class, "unknown"),
    # "points": [xtl, ytl, xbr, ybr],
    "type": "tag",
})

I get the same problem, maybe it's caused by cvat_ui. Since the code of auto-annotation is updated without modifying the ui code.
see cvat-ui/src/components/annotation-page/standard-workspace/controls-side-bar/tools-control.tsx, line 1035
when auto annotion completed, the result is still copied to objectType: ObjectType.SHAPE, and points return needed
                       const states = result.map(
                            (data: any): any => new core.classes.ObjectState({
                                shapeType: data.type,
                                label: jobInstance.labels.filter((label: any): boolean => label.name === data.label)[0],
                                points: data.points,
                                objectType: ObjectType.SHAPE,
                                frame,
                                occluded: false,
                                source: 'auto',
                                attributes: (data.attributes as { name: string, value: string }[])
                                    .reduce((mapping, attr) => {
                                        mapping[attrsMap[data.label][attr.name]] = attr.value;
                                        return mapping;
                                    }, {} as Record<number, string>),
                                zOrder: curZOrder,
                            }),
                        );

                        createAnnotations(jobInstance, frame, states);

Knowing how to modify this code may solve the problem

Even if you send send points you'll still get error because type cannot be tag, it's supposed to be shape:
Could not create annotations Error: Object shape must be one of: ["rectangle","polygon","polyline","points","ellipse","cuboid"]
One option could be allowing objectType be defined in response you send from serverless model. I'm not sure if it wouldn't break any other things, I haven't tested it, just a wild guess.
 const states = result.map(       (data: any): any => new core.classes.ObjectState({           shapeType: data.type,           label: jobInstance.labels.filter((label: any): boolean => label.name === data.label)[0],           points: data.points ?? undefined,           objectType: data.objectType ?? ObjectType.SHAPE,           frame,           occluded: false,           source: 'auto',           attributes: (data.attributes as { name: string, value: string }[])               .reduce((mapping, attr) => {                   mapping[attrsMap[data.label][attr.name]] = attr.value;                   return mapping;               }, {} as Record<number, string>),           zOrder: curZOrder,       }),   );

I am looking for this feature support...
Basically there will some DeepLearning classification model which I would to run (possibly as detector) and tag the image to have all those classes...
Idea is to run the automation task using a classification model to tag all the frames or images.
Definitely want to use tag rather than hacking object shape to be rectangle etc.. so that annotators won't get confused and continue using Tags from CVAT
Any help on this?  Any pointers to modify the code also works for now..

I get the same problem, maybe it's caused by cvat_ui. Since the code of auto-annotation is updated without modifying the ui code. see cvat-ui/src/components/annotation-page/standard-workspace/controls-side-bar/tools-control.tsx, line 1035 when auto annotion completed, the result is still copied to objectType: ObjectType.SHAPE, and points return needed
                       const states = result.map(
                            (data: any): any => new core.classes.ObjectState({
                                shapeType: data.type,
                                label: jobInstance.labels.filter((label: any): boolean => label.name === data.label)[0],
                                points: data.points,
                                objectType: ObjectType.SHAPE,
                                frame,
                                occluded: false,
                                source: 'auto',
                                attributes: (data.attributes as { name: string, value: string }[])
                                    .reduce((mapping, attr) => {
                                        mapping[attrsMap[data.label][attr.name]] = attr.value;
                                        return mapping;
                                    }, {} as Record<number, string>),
                                zOrder: curZOrder,
                            }),
                        );

                        createAnnotations(jobInstance, frame, states);

Knowing how to modify this code may solve the problem

any luck on modifying the UI code to support creating Tags?

If you want to return tags from an annotation model, add objectType to model response and server response (need to check that cvat server also passes this to response).
After that you can modify source code approximately this way to run detector on one frame:
``cvat-ui/src/components/annotation-page/standard-workspace/controls-side-bar/tools-control.tsx`
return new core.classes.ObjectState({
    shapeType: data.type,
    label: jobLabel,
    points: data.points,
    objectType: data.objectType || ObjectType.SHAPE,
    frame,
    occluded: data.occluded || false,
    source: 'auto',
    attributes: (data.attributes as { name: string, value: string }[])
        .reduce((acc, attr) => {
            const [modelAttr] = Object.entries(body.mapping[modelLabel].attributes)
                .find((value: string[]) => value[1] === attr.name) || [];
            const areCompatible = checkAttributesCompatibility(
                model.attributes[modelLabel].find((mAttr) => mAttr.name === modelAttr),
                jobLabel.attributes.find((jobAttr: Attribute) => (
                    jobAttr.name === attr.name
                )),
                attr.value,
            );

            if (areCompatible) {
                acc[attrsMap[data.label][attr.name]] = attr.value;
            }

            return acc;
        }, {} as Record<number, string>),
    zOrder: curZOrder,
});

When you are running detectors for the whole task, UI is not matter because all handling and object creating is on the server side. Probably need to modify this file cvat/apps/lambda_manager/views.py, LambdaFunction::invoke method.
Let me know if you need some more assistance, and of course, you are welcome to open a pull request :)

I will close the issue for now, if somebody is able to contribute us the feature of automatic annotation of tags, it would be great.


Keycloak 25 support

Hello there,
Is keycloak 25 support in your roadmap?
Updating to keycloak 25 is ending up in infinite redirection after authentication. Any help on this is much appreciated.

@sumesh-aot Thanks for letting us know.
Can you detail your setup a bit more? Spring Boot? SSO yes or no? Camunda Run? What about your application.yaml? This would help to reproduce your isssue.

Thank you @VonDerBeck , appreciate your reply!
Here is the application.yaml : https://github.com/sumesh-aot/forms-flow-ai/blob/FWF-3599-camunda-kc-update/forms-flow-bpm/forms-flow-bpm-camunda/src/main/resources/application.yaml
Pom.xml : https://github.com/sumesh-aot/forms-flow-ai/blob/FWF-3599-camunda-kc-update/forms-flow-bpm/forms-flow-bpm-camunda/pom.xml
Filter : https://github.com/sumesh-aot/forms-flow-ai/blob/FWF-3599-camunda-kc-update/forms-flow-bpm/forms-flow-bpm-camunda/src/main/java/org/camunda/bpm/extension/keycloak/sso/OAuth2LoginSecurityConfig.java#L111
Logs attached.
camunda-logs.txt

@sumesh-aot : are you using client side JWT authentication in Camunda Cockpit, based on the original keycloak-js script?

@sumesh-aot : are you using client side JWT authentication in Camunda Cockpit, based on the original keycloak-js script?
This is always a bit tricky and subject to changes. It works, but it is very sensitive when upgrading Keycloak, Camunda itself, etc. Because of that there is a warning in the README that using camunda-platform-7-keycloak-jwt is considered "incubation" status.

YEs we are using client side JWT auth, probably we may need to revert it back until it's usable for new version. Thanks for your help, really appreciate it! 👍

@sumesh-aot : Version 7.21.6 should solve your problem. Thanks for bringing this to my attention 👍

Thanks a lot @VonDerBeck


Detect Arduino 1.0

Detect Arduino 1.0 files
With the 1.0 release of the Arduino ide the file extension will be changed from .pde to .ino, this change will make detection of Ardino repos possible.
For more info on the extension change: http://code.google.com/p/arduino/wiki/Arduino1

Should we add .pde too?
Also is "Arduino" actually its own programming language?

Ah, nevermind. .pde is used by processing too. Extension conflicts!


Add rfkill status to network module and new bluetooth module

I added an interface to the linux rfkill utility. This allows modules to update based on changes of the rfkill state. I added this to the existing network module and created a new bluetooth module implementing the feature.
rfkill
The code is adapted from here.
bluetooth
I was never sure if my bluetooth module was deactivated or not connecting to my devices for another reason.
It's possible to update the module via an interval in addition to rfkill events.
network module
Two main changes were made:

Distinction between no wifi connection present and wifi module turned off. (think: airplane mode)
Update status on rfkill event in addition to interval based updates.

The second actually gave me some trouble as there seems to be an unrelated bug. The module doesn't seem to reflect a change in status in the bar, even though the corresponding update() function was executed both via the interval as well as based on the rfkill event.
I reproduced this on v0.9 from the arch community repos.  Also see my comment in #494.
I am open to any feedback, especially on style. I don't have much experience with c++.

Thanks a lot for the feedback! I changed everything you requested.

For the update that doesn't seem to work, this may be due to the fact that the getInfo stuff needs a delay to be updated and get new information, can you try with a large delay of 1s and reduce it?

As for this, I have tried lots of different combinations of delays at different points, but couldn't figure it out. Maybe you or someone could take another look at that. I don't think my change interfere here - I tested v 0.9 form the repos again and I had the same issue.

Thanks a lot for the feedback! I changed everything you requested.

For the update that doesn't seem to work, this may be due to the fact that the getInfo stuff needs a delay to be updated and get new information, can you try with a large delay of 1s and reduce it?

As for this, I have tried lots of different combinations of delays at different points, but couldn't figure it out. Maybe you or someone could take another look at that. I don't think my changes interfere here - I tested version 0.9 form the repos again and I had the same issue.

The issues disappeared. Now everything is working as expected!

Thanks @marcplustwo, will merge this by the end of the week ❤

Thanks a lot, can you update the github wiki?


Slow compare to seldon-core-microservice with multiple workers

I have ported an existing seldon-core model service into mlserver but found the performance dropped a lot.
Below is my load test config and result of Rest endpoint
seldon-core 2 replica, 2cpu, 2g ram, 4 gunicorn workers 2 threads, about 100 request/s
mlserver 2 replica, 8cpu, 4g ram, 4 parallel workers, about 8 requests/s
not sure is it due to https://github.com/SeldonIO/MLServer/issues/353 ?
version:
mlserver==0.5.3

Hey @cksac ,
Thanks for sharing those results. From our own internal benchmarking MLServer is generally faster than the previous server used in Seldon Core, so it would be great to understand more about your environment to learn why is it slower in this case.
Is this a custom model? Ideally, it would be great if you could share the code. Conscious that this can be delicate sometimes though so, if that's not possible, could you share as many details as you can? E.g. does your custom code leverage asyncio? For how long did the test run? How large are generally the request payloads? etc.
Alternatively, if this is using one of the pre-packaged runtimes, could you share which one was it using? Also, any extra details around the model that can help us replicate the low throughput would be appreciated.
PS: #353 should only become an issue if your custom code uses asyncio. However, even if this was the case, this would just "drop" MLServer's performance to the same level of the previous inference server in Seldon Core.

Hey @cksac,
Thanks a lot for putting the time on getting that benchmarking repo together.
I've been spending some time looking at it, and was just wondering that with 2 parallel workers per instance and 100ms of blocking time (at least) per request, doesn't 35 reqs / sec sound about right? That is, if we take into account only the blocking time, each "parallel worker thread" would only be able to execute 10 of them in a second, so 35 reqs / sec doesn't sound too far off. Is there anything I'm missing on that reasoning?
On top of that, from what I've seen, time.sleep() also tends to overshoot the waiting time on sub-second timeouts.
Just for reference, we do run benchmarks from time to time (on both custom and simple SKLearn models). You can check them out on the ./benchmarking folder. On those, average request times tend to be on the lower 50ms.
On your original benchmark, where you reported the performance difference against the current server in Seldon Core, were you using a similar test setup?

Hey @cksac ,
We'll be closing this one due to inactivity. However, please do reopen it if this is still an issue for you.


bosh deploy --dry-run changes deployment releases

Hi,
we use bosh deploy --dry-run to validate that our BOSH deployments, which are executed by our CI/CD system, are working in a pre run. This pre-run will always be executed against our next version of deployment-manifests and should validate if there are incompatibilities in our operation files.
Our expectation of bosh deploy --dry-run was that the deploy command will be executed under realistic circumstances (applying ops files and checking if variables can resolve) but without changing the upstream deployments. The last requirement is very important since we are running bosh deploy --dry-run against production environment, which can not be changed without customers permission.
We observed that after the execution of bosh deploy --dry-run the deployments referenced double release version.
Every bosh deploy --dry-run which would update a deployment release version, added this release version to the deployment next to the old release version.
This can lead to a critical problem in production environments considering the following use case:
[1] The CI/CD deploys deployment manifest versions v1.0.0
[2] The CI/CD calls bosh deploy --dry-run with manifest version v2.0.0 in order to validate that the next update does not contain incompatibilities concerning the operation files or variables.
[3] The configuration of the deployments is adjusted and the CI/CD deploys deployment manifest versions v1.0.0 again to apply the config changes.
Step [3] potentially yields unintended migrations since we can have double release versions after [2] in the upstream bosh deployments of manifest version v1.0.0.
If a manifest in version v1.0.0 does reference a release using the version constraint latest, an update of this release version will happen upon [3] which can cause downtime on production environments and inconsistent state of the environment.
upstream deployments - deployments that are currently deployed on our productive environments

@gdenn thanks for the verbose problem statement. We're actively looking into ways of addressing this and improving it. Hopefully you'll start seeing some improvements in this area in future releases of the BOSH director. I'm going to close it for now since it's an active stream for the team, but feel free to re-open if you have additional thoughts.

Hi guys,
Is there a possibility to add a real dry-run feature to only check what would be deployed using the given manifest?
For CI scripting this would be very handy. In principle the same as a terraform plan for BOSH.
Cheers,
Julian


Table View didnt reload when i switch from one tabbar to another tab bar

I have 3 bar items when i switch from on view to second the table view didn't reload. how can we hit the api when the view controller presents?

you don't want to do that on the tabview controller. That'll be unnecessary. It'd be best to do it in viewWillAppear(_:) for the table view in question


all hosts blocked except localhost on Rails

Describe the bug
I'm trying to use the application inside a GCP Ubuntu VM, applying it to the local IP address and then using IP forwading to redirect external traffic to it
The problem is that, doing the test both in GCP and locally, the problem is always the same, I can't get the application to work with the local IP address instead of localhost because apparently Rails blocks any hosts other than localhost, as shown in the screenshot.
I've tried numerous ways to solve this problem, following some tips on stackoverflow and some tips in this issue, such as:

in the config/initializers/custom.rb file, I tried to add the lines config.hosts.clear, config.hosts << "<IP_ADDRESS>", config.hosts << "my_hostname_name"

in the config/enviroments/development.rb file, I tried to change the ui_host and cookie_domain lines to my hostname and local IP address

in the config/application.rb file, I tried to add the Rails.application.config.hosts.clear line to release all hosts

i also asked the firewall to accept all necessary ports like 5000, 8000 and 5432, just in case
and after each change, I reinstalled the entire application using docker-compose down -v and docker-compose up, but none of the alternatives, and in none of the environments did it solve the problem.
is there any way I can solve this? access my application via http://my_local_ip:5000 instead of http://localhost:5000?
OpenCSPM version
0.1.23
Expected behavior
access the application via my local ip address instead of localhost, to establish access for other addresses on the network (ex: http://<IP_ADDRESS>:5000)
Screenshots

Docker information
20.10.2
docker-compose: 1.26.0
Cloud provider
GCP

Yup.. Facing the same issue.

This is by design. Accessing the web ui over the network is not possible the way the Docker image is currently built.
The frontend (vue.js) app is bundled and built into the Docker image. There is no SSL/TLS certificate support and the location of backend (Rails API) is hardcoded into the frontend ui bundle.


Update upgrade-22h2-to-23h2-other-methods.md

Recommended updates.

@alkohli
Can you review the proposed changes?
Important: When the changes are ready for publication, adding a #sign-off comment is the best way to signal that the PR is ready for the review team to merge.
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

@Jak-MS pulled the changes in this PR: https://github.com/MicrosoftDocs/azure-stack-docs-pr/pull/15695
Will be closing this PR. #please-close


Installation error on RHV

I tried installation OKD 4.7 on RHV many times.
ERROR Attempted to gather debug logs after installation failure: failed to get bootstrap and control plane host addresses from "install/terraform.tfstate": failed to lookup bootstrap ipv4 address: cannot find IPs for vmId: 95d7481d-623d-43a9-851c-4e2c583c5aa6
FATAL Bootstrap failed to complete: failed to wait for bootstrapping to complete: timed out waiting for the condition
Bootstrapping is not completed and I have only 3 master nodes.

Please attach log bundle

@vrutkovs   I tried to. install 4.6 and error again
ERROR Attempted to gather debug logs after installation failure: failed to create SSH client: failed to use the provided keys for authentication: ssh: handshake failed: ssh: unable to authenticate, attempted methods [none publickey], no supported methods remain
FATAL Bootstrap failed to complete: failed to wait for bootstrapping to complete: timed out waiting for the condition
This time bootstrapping is finished API is ok but there are no workers and apps
When I  try to get log
./openshift-install gather bootstrap --dir=install
INFO Pulling debug logs from the bootstrap machine
FATAL failed to create SSH client: failed to use the provided keys for authentication: ssh: handshake failed: ssh: unable to authenticate, attempted methods [publickey none], no supported methods remain

install 4.6 and error again

Is this reproducible in latest OKD 4.7?

ok np . I will install 4.7 again.

The installation was cancelled again
ERROR Attempted to gather debug logs after installation failure: failed to get bootstrap and control plane host addresses from "install/terraform.tfstate": failed to lookup bootstrap ipv4 address: cannot find IPs for vmId: 9a9fe831-7e82-42fa-a6d7-d44c91222045
FATAL Bootstrap failed to complete: failed to wait for bootstrapping to complete: timed out waiting for the condition
When I try to get log
[root@bastion okd]# ./openshift-install gather bootstrap --dir=install
FATAL failed to get bootstrap and control plane host addresses from "install/terraform.tfstate": failed to lookup bootstrap ipv4 address: cannot find IPs for vmId: 9a9fe831-7e82-42fa-a6d7-d44c91222045
@vrutkovs

bootstrap.log
i got log via that command
ssh<EMAIL_ADDRESS>"journalctl -b  -u release-image.service -u bootkube.service --no-page" > bootstrap.log

cannot find IPs for vmId: 9a9fe831-7e82-42fa-a6d7-d44c91222045

Which machine - bootstrap/master - id is that? Did that machine boot? Does it have IPs assigned?

" 9a9fe831-7e82-42fa-a6d7-d44c91222045" is bootstrap instance and got IP from DHCP.

Meanwhile, this bootstrap instance is still running...  i am attaching new log file
bootstrap1.log
Yesterday night, I waited 12 hours for compilation but never.

got IP from DHCP.

Did that IP render on vsphere UI? Does this instance run vmtoolsd.service?

@vrutkovs  I don't understand your question. My platform is RHV (oVirt) and used the IPI installation method. Actually, I installed OCP on the same RHV platform  2 months ago and running now and 1 month ago I installed OKD 4.6 but I had some problems. Because  I gave an "OKD" as a cluster name in my opinion. Meanwhile,  At first, I tried to install 4.7 before and failed, therefore I decided to install 4.6. Now I could not install either 4.6 or 4.7 :(

The bootstrap service  still running in loop
.....
May 24 17:19:17 localhost bootkube.sh[340365]: Skipped "secret-kube-apiserver-to-kubelet-signer.yaml" secrets.v1./kube-apiserver-to-kubelet-signer -n openshift-kube-apiserver-operator as it already exists
May 24 17:19:18 localhost bootkube.sh[340365]: Skipped "secret-loadbalancer-serving-signer.yaml" secrets.v1./loadbalancer-serving-signer -n openshift-kube-apiserver-operator as it already exists
May 24 17:19:18 localhost bootkube.sh[340365]: Skipped "secret-localhost-serving-signer.yaml" secrets.v1./localhost-serving-signer -n openshift-kube-apiserver-operator as it already exists
May 24 17:19:19 localhost bootkube.sh[340365]: Skipped "secret-service-network-serving-signer.yaml" secrets.v1./service-network-serving-signer -n openshift-kube-apiserver-operator as it already exists
May 24 17:38:40 localhost bootkube.sh[340365]: Error: error while checking pod status: timed out waiting for the condition
May 24 17:38:40 localhost bootkube.sh[340365]: Tearing down temporary bootstrap control plane...
May 24 17:38:40 localhost bootkube.sh[340365]: Error: error while checking pod status: timed out waiting for the condition
May 24 17:38:40 localhost podman[340365]: 2021-05-24 17:38:40.793824833 +0000 UTC m=+1207.822227835 container died 07f1cc2d7a6006b4dde6eed10fb1e178eae94ca45ab247679d5a51dd693191d9 (image=quay.io/openshift/okd-content@sha256:99b54b2c35145c3084d773acabbe0ec94425189ae215c639b87055b55625e066, name=interesting_swirles)
May 24 17:38:41 localhost podman[340365]: 2021-05-24 17:38:41.473043034 +0000 UTC m=+1208.501446024 container remove 07f1cc2d7a6006b4dde6eed10fb1e178eae94ca45ab247679d5a51dd693191d9 (image=quay.io/openshift/okd-content@sha256:99b54b2c35145c3084d773acabbe0ec94425189ae215c639b87055b55625e066, name=interesting_swirles, com.redhat.build-host=cpt-1004.osbs.prod.upshift.rdu2.redhat.com, io.openshift.build.name=, io.openshift.release.operator=true, io.openshift.build.commit.message=, io.openshift.expose-services=, architecture=x86_64, io.openshift.build.namespace=, version=v4.0, build-date=2021-01-09T00:40:49.580557, maintainer=Red Hat, Inc., url=https://access.redhat.com/containers/#/registry.access.redhat.com/openshift/ose-base/images/v4.0-202101090039.11723, com.redhat.license_terms=https://www.redhat.com/agreements, io.openshift.build.source-context-dir=, summary=Provides the latest release of Red Hat Universal Base Image 8., io.k8s.display-name=OpenShift Base, vendor=Red Hat, Inc., io.buildah.version=1.16.4, vcs-url=https://github.com/openshift/cluster-bootstrap, io.openshift.tags=base rhel8, vcs-type=git, vcs-ref=6665cae3374c18d466f11c9e0b8e41a61fcb0819, distribution-scope=public, io.openshift.build.source-location=https://github.com/openshift/cluster-bootstrap, io.openshift.build.commit.author=, io.openshift.build.commit.ref=master, name=openshift/ose-base, release=202101090039.11723, description=The Universal Base Image is designed and engineered to be the base layer for all of your containerized applications, middleware and utilities. This base image is freely redistributable, but Red Hat only supports Red Hat technologies through subscriptions for Red Hat products. This image is maintained by Red Hat and updated regularly., io.k8s.description=This is the base image from which all OpenShift images inherit., com.redhat.component=openshift-enterprise-base-container, io.openshift.build.commit.id=6665cae3374c18d466f11c9e0b8e41a61fcb0819, io.openshift.build.commit.date=)
May 24 17:38:41 localhost systemd[1]: bootkube.service: Main process exited, code=exited, status=1/FAILURE
May 24 17:38:41 localhost systemd[1]: bootkube.service: Failed with result 'exit-code'.
May 24 17:38:46 localhost systemd[1]: bootkube.service: Scheduled restart job, restart counter is at 22.
May 24 17:38:46 localhost systemd[1]: Stopped Bootstrap a Kubernetes cluster.
May 24 17:38:46 localhost systemd[1]: Started Bootstrap a Kubernetes cluster.
May 24 17:38:47 localhost podman[354708]: 2021-05-24 17:38:47.004666943 +0000 UTC m=+0.202675520 container create 127672f714c39d60dd8e63e5c72f1b8cca4fc897a1ef80611e3b4ce6732cb47b (image=quay.io/openshift/okd@sha256:301cd36b2ab370027ddb0ec43e540a03a24748a25b69578dec504d130475304b, name=cranky_khayyam, io.openshift.release.base-image-digest=sha256:bdb9d78eef0258d55a2ffac0d7dcb1ac25bc9143d1528b34a0efcca444a52362, io.openshift.release=4.7.0-0.okd-2021-05-22-050008)
May 24 17:38:47 localhost podman[354708]: 2021-05-24 17:38:47.101221462 +0000 UTC m=+0.299230051 container init 127672f714c39d60dd8e63e5c72f1b8cca4fc897a1ef80611e3b4ce6732cb47b (image=quay.io/openshift/okd@sha256:301cd36b2ab370027ddb0ec43e540a03a24748a25b69578dec504d130475304b, name=cranky_khayyam, io.openshift.release.base-image-digest=sha256:bdb9d78eef0258d55a2ffac0d7dcb1ac25bc9143d1528b34a0efcca444a52362, io.openshift.release=4.7.0-0.okd-2021-05-22-050008)
May 24 17:38:47 localhost podman[354708]: 2021-05-24 17:38:47.13621319 +0000 UTC m=+0.334221771 container start 127672f714c39d60dd8e63e5c72f1b8cca4fc897a1ef80611e3b4ce6732cb47b (image=quay.io/openshift/okd@sha256:301cd36b2ab370027ddb0ec43e540a03a24748a25b69578dec504d130475304b, name=cranky_khayyam, io.openshift.release.base-image-digest=sha256:bdb9d78eef0258d55a2ffac0d7dcb1ac25bc9143d1528b34a0efcca444a52362, io.openshift.release=4.7.0-0.okd-2021-05-22-050008)
......
```

Is there any tests on RHV? I am suspect because OCP has a bug and I detected it and created a case one month ago and now Redhat is working on it. And I could install OKD on different platforms easily but RHV. It is interesting because RHV is a Redhat product.

Oh, sorry, I misread the platform as vsphere instead of ovirt.
I don't think we have oVirt tests for OKD, but we have those for OCP.
You'd need to figure out why bootstrap is not setting the address on oVirt (and terraform can't record that IP).

@vrutkovs
I download "openshift-install-linux-4.6.0-0.okd-2020-11-27-200126.tar.gz" and I succeded. It is the first 4.6 version.
I had errors but installation was completed by bootstrap instance and the bootstrap instance is still up, could not be destroyed.
But I can assess the console and OKD is running. I tried the last version of 4.6 yesterday, It has a problem.  I think there is a problem after a specific version 4.6
INFO Obtaining RHCOS image file from 'https://builds.coreos.fedoraproject.org/prod/streams/stable/builds/32.20201004.3.0/x86_64/fedora-coreos-32.20201004.3.0-openstack.x86_64.qcow2.xz?sha256=6065c21bf6903bf72cce8c5f57c1a07232e93aa85132834baa5859d56ee4ef9a'
INFO Creating infrastructure resources...
INFO Waiting up to 20m0s for the Kubernetes API at https://api.dev.example.com:6443...
INFO API v1.19.0-rc.2.1077+43983cda8af930-dirty up
INFO Waiting up to 30m0s for bootstrapping to complete...

My 2 cents

hi @tdemaret
which version did you install?

I have this issue with 4.5 and 4.6, I don't try with 4.7 (just update my cluster).

hi @tdemaret
I think config JSON was changed for 4.7. There are  no timeouts key in bootstrap.ign
I found that
 --runtime-request-timeout=${KUBELET_RUNTIME_REQUEST_TIMEOUT}

So, its a regression in 4.7? Is it reproducible in 4.8 nightlies? Did you get any information where it could be?

@vrutkovs
This is  the last 4.7
[root@bastion okd]# ./openshift-install version
./openshift-install 4.7.0-0.okd-2021-05-22-050008
built from commit ba1a5fc61dd3be134a24fa6d89ae24012a93385a
release image quay.io/openshift/okd@sha256:301cd36b2ab370027ddb0ec43e540a03a24748a25b69578dec504d130475304b
I  run :
./openshift-install create ignition-configs --dir install
when I check the bootstrap.ign
   "contents": "[Unit]\nDescription=Kubernetes Kubelet\nWants=rpc-statd.service crio.service release-image.service\nAfter=crio.service release-image.service\n\n[Service]\nType=notify\nExecStartPre=/bin/mkdir --parents /etc/kubernetes/manifests\nExecStartPre=/bin/mkdir --parents /etc/kubernetes/kubelet-plugins/volume/exec\nExecStartPre=/usr/local/bin/kubelet-pause-image.sh\nEnvironment=KUBELET_RUNTIME_REQUEST_TIMEOUT=10m\nEnvironmentFile=-/etc/kubernetes/kubelet-env\nEnvironmentFile=-/etc/kubernetes/kubelet-pause-image-override\n\nExecStart=/usr/bin/hyperkube \\\n  kubelet \\\n    --anonymous-auth=false \\\n    --container-runtime=remote \\\n    --container-runtime-endpoint=/var/run/crio/crio.sock \\\n    --runtime-request-timeout=${KUBELET_RUNTIME_REQUEST_TIMEOUT} \\\n    --pod-manifest-path=/etc/kubernetes/manifests \\\n    --minimum-container-ttl-duration=6m0s \\\n    --cluster-domain=cluster.local \\\n    --cgroup-driver=systemd \\\n    --serialize-image-pulls=false \\\n    --v=2 \\\n    --volume-plugin-dir=/etc/kubernetes/kubelet-plugins/volume/exec \\\n    --pod-infra-container-image=${MACHINE_CONFIG_INFRA_IMAGE}\n\nRestart=always\nRestartSec=10\n\n[Install]\nWantedBy=multi-user.target\n",
        "enabled": true,
        "name": "kubelet.service"
      },
```

@vrutkovs
I downloaded 4.8
[root@bastion okd]# ./openshift-install version
./openshift-install 4.8.0-0.okd-2021-05-27-020828
built from commit 4b15f0537ad76206c8ba9ba042b404f8c00a295a
release image registry.ci.openshift.org/origin/release@sha256:9a2317e206328b7187420ea1e7561d9191c30bca539b3548f566b17abdd5a036

Now, there is no timeouts key in ign files
        "contents": "[Unit]\nDescription=Kubernetes Kubelet\nWants=rpc-statd.service crio.service release-image.service\nAfter=crio.service release-image.service\n\n[Service]\nType=notify\nNotifyAccess=all\nExecStartPre=/bin/mkdir --parents /etc/kubernetes/manifests\nExecStartPre=/bin/mkdir --parents /etc/kubernetes/kubelet-plugins/volume/exec\nExecStartPre=/usr/local/bin/kubelet-pause-image.sh\nEnvironment=KUBELET_RUNTIME_REQUEST_TIMEOUT=10m\nEnvironmentFile=-/etc/kubernetes/kubelet-env\nEnvironmentFile=-/etc/kubernetes/kubelet-pause-image-override\n\nExecStart=/usr/local/bin/kubelet.sh\n\nRestart=always\nRestartSec=10\n\n[Install]\nWantedBy=multi-user.target\n",
        "enabled": true,
        "name": "kubelet.service"
      },

Timeouts have absolutely nothing to do with that. The issue is that oVirt can't get bootstrap's IP address. Perhaps we don't start qemu-agent service in 4.7 (fairly certain we do in 4.8)

Meanwhile, I tried to install  4.8 on RHV 4.4
INFO Obtaining RHCOS image file from 'https://builds.coreos.fedoraproject.org/prod/streams/stable/builds/34.20210427.3.0/x86_64/fedora-coreos-34.20210427.3.0-openstack.x86_64.qcow2.xz?sha256=55ef751cca6f46cf7a603a18786479b14cf5a8060df4ef03839581ada0f5324c' ***************************************************************************************************************************************************************************************************************************INFO Creating infrastructure resources...         ********************************************************************************************************************************************************************************************ERROR                                              *******************************************************************************************************************************************************************************************ERROR Error: updating the VM (f6267568-21e3-49cb-8c47-57c114a5d273) with auto pinning policy failed! failed to set the auto pinning policy on the VM!, Failed to find StartElement ***********************************************************ERROR                                              *******************************************************************************************************************************************************************************************ERROR   on ../../tmp/openshift-install-619524212/masters/main.tf line 1, in resource "ovirt_vm" "master": ************************************************************************************************************************************ERROR    1: resource "ovirt_vm" "master" {         *******************************************************************************************************************************************************************************************ERROR                                              *******************************************************************************************************************************************************************************************ERROR                                              ********************************************************************************************************************************************
ERROR
ERROR Error: updating the VM (ea3e3209-ffd1-421c-b38e-60764ca9ba83) with auto pinning policy failed! failed to set the auto pinning policy on the VM!, Failed to find StartElement
ERROR
ERROR   on ../../tmp/openshift-install-619524212/masters/main.tf line 1, in resource "ovirt_vm" "master":
ERROR    1: resource "ovirt_vm" "master" {
ERROR
ERROR
ERROR
ERROR Error: updating the VM (21b5194b-694a-42d5-87a8-f23807f426b1) with auto pinning policy failed! failed to set the auto pinning policy on the VM!, Failed to find StartElement
ERROR
ERROR   on ../../tmp/openshift-install-619524212/masters/main.tf line 1, in resource "ovirt_vm" "master":
ERROR    1: resource "ovirt_vm" "master" {
ERROR
ERROR
FATAL failed to fetch Cluster: failed to generate asset "Cluster": failed to create cluster: failed to apply Terraform: failed to complete the change

failed to set the auto pinning policy on the VM

looks like an ovirt error

Seems we were missing liburing as a new dependency for qemu-agent in 4.7. This was fixed in latest 4.7 nightlies - could you give one of these a try?

hi vadim
The problem continues and I think It is important because RHV is a RedHat product. Today I will try the different version from nightlies. Please do not close this issue.

It is like a joke!!!
OKD is not installing on ovirt/rhv. neither version 4.6 nor version 4.7. Even, version 4.8 can not be started the installation process.


Relax fp16 tolerances in TestContrastive

Fix #7704.

Jenkins, test this please

Jenkins CI test (for commit bbe78fab29a4fc1fe08d0098fa0c31a26471df25, target branch master) succeeded!


Does it work with React.js?

Hi I just want to get a token so that my React app can send POST request to a app deployed on app engine.
Is it because it does not work with React?

Greetings!  The approach you're trying to take here is using "Application Default Credentials", where it mostly assumes you're working from a server.  This library should work from React, in very targeted scenarios (3 legged oauth).
Can you describe what you're trying to do?
Which API are you trying to use?
Do you expect users to authenticate as themselves?
Or do you expect to authenticate with a single service account, and always use that identity?

Hi thanks for the quick response!
Actually the task is very simple. I want to send a POST http request to a flask app deployed on App Engine and want to send with Authorization. In another way, I want to get a token in React instead of type in command line gcloud auth print-access-token every time.
fetch("API of Agg Engine", {
            method: 'POST',
            headers: {
                'Accept': 'application/json',
                'Authorization': access_token //  <-------- this is what I want
            },
            body: JSON.stringify({
                  text: 'some text',
            })
        })

Thanks!
It is okay to send to the App Engine without a token, just because it is more secure.

So if your app is running in App Engine, and you're trying to use a cloud API, that should "just work" ™.  The App Engine environment uses Application Default Credentials, which let your app access basic services like Datastore, PubSub, Storage, etc without any explicit setup.
You shouldn't need to mess with access tokens at all, unless you're trying to use some other API that requires user level credentials.
I guess I'm still not sure what you're trying to do :)

The original intent was to check if this works with React.js, which we're tracking in #150.  Let's use that issue to track the request!

I suggest re-opening this given GCP's solution of choice for deploying applications is now Cloud Run - this question is open and relevant. Going back to @jguo1002 's original question, we would have two Cloud Run apps - one React "client" app and a "server" app. We'd typically want to block unauthenticated invocations from the server app, so that it can only be queried by the client app.
https://cloud.google.com/run/docs/authenticating/service-to-service says that we should, in this case, query the metadata server from the React app to get a token that can be used to query the server app (i.e. it doesn't "just work" with Cloud Run, even if both services are hosted on Cloud Run in the same project). However, that internal metadata endpoint in the linked docs seems to be broken (and if it's not, it would be useful to have an external service to query for local debugging anyway).
So then, the need to use google-auth-library on the front end is still there


Annotations showing "undefined"

I'm submitting a ...

[ x] Bug report
[ ] Feature request
[ ] Question / Support request

For bug report please include this information:

What Grafana version are you using? 3.1.1
What Zabbix version are you using? 3.0.4
What zabbix plugin version are you using? 3.1.1
What OS are you running grafana on? Ubuntu 14.04.1 LTS
What did you do? upgraded grafana and grafana zabbix to latest
What was the expected result?  annotations would still show trigger description etc
What happened instead?  annotations show 3 lines "PROBLEM|OK", "undefined", "[timestamp]"

Fixed by ca97d392e9e43dd9ab5cbf0435869d7402a7aa62


Error ord installing in Ubuntu

I am getting this error in install process on the Ubuntu. I already searched and tried some commands and packages but still same.

try to build from source.

Please reopen if you still have this problem


Autolock loop - Simplified the autolock logic, removed the timeout

The app state cycle was a bit messy and the setTimeout wasn't triggering consistently. Since it wasn't working at all on iOS and we had a little delay when coming back until it was locked (that was deemed acceptable at the time) and since Android handles the events differently and locks a lot faster I simplified the logic a lot, removing the timeout and handling the app state changes tighter.
This should fix the lock loop that @aramab was experiencing and also make the autolock work more consistently in both platforms.

@juan-cortes can you squash into one commit so it's easier to cherry-pick? i'll cherry-pick from master on monday so we do the patch release

@arnaud97234 doubt I can do anything about that, @gre I will squash later, sure

It's an interesting feedback but I don't feel it's a regression right?
Nevertheless, let's add this in our backlog.
One idea to fix this is to delay the splashscreen.show() , even tho I'm not even sure if it's used at this time but that's my first blind guess

I'll take a look tonight, maybe I can do something about it, but I think it's just the time it takes for the unlock to do its thing. I'll give it a couple hours see what comes out of it

I'll take a look tonight, maybe I can do something about it, but I think it's just the time it takes for the unlock to do its thing. I'll give it a couple hours see what comes out of it

It might be possible to use the app state changes to animate an overlay that hides that screen if it's an issue or the sensitive data that could be seen in that fraction of time that it takes to lock, I tested a bit the idea and it should be doable. I say keep it as it is, and see what kind of feedback from the community we get. See if it's an issue at all.
@gre squashed into a cherry-pickable commit

You don't need to implement an overlay btw. It's already what splashscreen.show() and hide () does
And btw we already have a timeout of 300ms today. Maybe you want to try increasing that. See code of src/index

afaik the splashscreen is only used from the onRebootStart from js and natively called at launch, so unless we are doing a resetAll or clear data, the splash wouldn't show? Maybe I'm misunderstanding it, I was playing with the idea of showing something that fades into transparency on unlock, but it's probably not even worth it

In Arnaud gif we see the splash screen appearing no? 🤔

Then I'm all confused again! I don't get the splash on an autolock -.-

I suspect it's only happening if you come back after a long term (app reboot)
So yeah, not tricky to solve , let's leave that in a backlog task as initially said ;)


feat: use container based Travis builds.

This appears to reduce build start times substantially (seconds, not minutes!).

LGTM


Meta exists, while reviews are absent

Take a look: https://www.codexia.org/p/774
I see meta information stored about Reddit and HN, but no reviews posted. Is it a bug?

@yegor256 this happens due to daily review limits for bots.
These reviews are in the db-queue now and will be sent as soon as limits will expire.
See the db-queue screenshot:

Each review in queue correlates with the corresponding meta:

To prevent such a case from happening, in my opinion, we should increase the review limits for bot (maybe just only for my bot) as I described in this codexia-issue.
@yegor256 what do you think?

@yegor256 since this is not a bug, I'd prefer to close this issue.


Add testnet support

Hi,
I'm looking to add cashaddress support into bitcash. Your library looks to be the easiest way to do that.
However, it doesn't seem to support testnet addresses. Is this something you can add in, or would you be interested in a patch for testnet support?
Thank you!

Thanks for suggestion, testnet support was implemented just download new release


refactor imports and width for map notification

https://trello.com/c/9x1DwjdQ

@AngelRodRo conflicts


added video thumbnail and user avatar seeds

Description
Added video and avatar seeds
Had to modify some dB models to also bring in the image data.
Type of change
Please delete options that are not relevant.

[x] New feature (non-breaking change which adds functionality)

Change Status

[x] Complete, tested, ready to review and merge
[ ] Complete, but not tested (may need new tests)
[ ] Incomplete/work-in-progress, PR is for discussion/feedback

How Has This Been Tested?

[x] Test A - Local browser render
[x] Test B - checked endpoints in Insomnia
[x] Test C - back end tests still pass, had to modify auth tests to include avatar string

Checklist

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[ ] My code has been reviewed by at least one peer
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[ ] There are no merge conflicts

 add video thumbnail migration and seeds

 add user avatar migration and seeds


standard output: h1 to h3, h5 to h1, etc

Read in a nt or aa fasta, export a tab delimited text file where first column is "HX" numbering for every position (based upon the desired --subtype flag), and each position is then annotated by desired annotation tables or --wiley/caton.
The usage here is to read in hundreds/thousands of sequences, and then have each position numbered using the desired numbering scheme + annotations. So - a "desktop" version of the IRD numbering translator tool with the additional benefit of being able to include custom annotations and the published epitope sites.

This may no longer fall into the "aadiff" tool - so, perhaps an "annotation" option would be better.

Read in a nt or aa fasta, export a tab delimited text file where first column is "HX" numbering for every position (based upon the desired --subtype flag), and each position is then annotated by desired annotation tables or --wiley/caton.
The usage here is to read in hundreds/thousands of sequences, and then have each position numbered using the desired numbering scheme + annotations. So - a "desktop" version of the IRD numbering translator tool with the additional benefit of being able to include custom annotations and the published epitope sites.

This would be fairly easy to do. I'd probably want to batch the input sequences for performance sake. The command might look something like:
$ flutile annotate --subtype=H1 --caton82 mydata.faa > mydata.txt

I am not quite happy trusting the --subtype=H1 info from the user. I would like a way to double check that the user's sequence are really members of the subtype. This would involve finding some sort of scoring metric and cutoff that can be calculated from the alignments. An obvious choice would be to use the same metrics as BLAST.

I like that approach - with the same (--annotation-tables, --join-annotations) as aadiff.
I think you may be misreading my subtype query. The most common use here is most likely going to be someone who wants H3 numbering on their H1/H5 sequence (or people with H3 who want H3 + annotations). So, the --subtype flag, maybe needs to be reworded to --output-numbering.

That makes sense. I still want some sort of "crap filter" or diagnostic function in flutile that I help identify and/or remove bad data. But make this can be a flutile diagnose functiion. So this is a different topic for a different issue.
Adding --annotation-tables and --join-annotations makes sense. Actually, I can keep exactly the same API as aadiff and just change the output format. This would reuse all the functions I've already implemented and simplify maintenance.


Fix handling Googlevideo URLs returning redirects

It seems direct googlevideo.com URLs can return plain text with intent to have you redirect, instead of redirecting you itself.

Check the content-type header for text/plain and assume it's a redirect URL.
Potentially recursively call the function that checks up to X times until a working URL is given.
Move the sq param to the end of the URL instead of truncating the rest of the URL. Could end up never retrieving video or audio.

I've never seen this outside of the one time that caused me to open this ticket, and I think it may have been in part from trying to mess with the url while testing stuff in the browser.


How to USB-C cable?

First of all: big thanks for this great project, love the hardware, love the software.
I have customized the firmware, and now finally got overconfident and messed up the firmware. I always used the wifi /update method, so as I understand ota1 now has my bricked firwmare, and ota0 still is supposed to have the original firmware.
My first problem is the USB-C connection: I see a 6 pin header marked P2, is this the header the USB-ftdi cable has to be connected to? What are the specs of the header-pins, or is there a standardized USB-cable that I can buy that has the header already in place?
I understand I can clear the ota partition with the esptool:
python esptool.py --chip esp32 --port "COM7" --before default_reset --after hard_reset erase_region 0xe000 0x2000
Will this clear the ota0 (usb-programmable) partition or the ota1 (wifi /update partition) ?
Big thanks for your support!

Thanks for your quick response!
For all others out there, the USB-C port is located at the top right side, next to the high voltage connections.
Now the esptool command worked, but I expected the SmartEVSE to reboot on the original firmware. It did not, the LCD screen keeps flashing (like it did with my bricked firmware) and repowering does not change anything.
The vscode upload is not working, it cannot the device:
[code]Reading symbols from /usr/local/src/SmartEVSE-3-main.orig/SmartEVSE-3/.pio/build/release/firmware.elf...
done.
PlatformIO Unified Debugger -> https://bit.ly/pio-debug
PlatformIO: debug_tool = esp-prog
PlatformIO: Initializing remote target...
Open On-Chip Debugger  v0.10.0-esp32-20210721 (2021-07-21-13:33)
Licensed under GNU GPL v2
For bug reports, read
http://openocd.org/doc/doxygen/bugs.html
adapter speed: 20000 kHz
WARNING: boards/esp-wroom-32.cfg is deprecated, and may be removed in a future release.
adapter speed: 5000 kHz
Info : tcl server disabled
Info : telnet server disabled
Error: no device found
Error: unable to open ftdi device with vid 0403, pid 6010, description '', serial '' at bus location ''
Error: no device found
Error: unable to open ftdi device with vid 0403, pid 6014, description '', serial '' at bus location ''
openocd: ../src/jtag/core.c:343: jtag_checks: Assertion `jtag_trst == 0' failed.
Aborted (core dumped)
.pioinit:11: Error in sourced command file:[/code]
The vid and pid are completely wrong, lsusb says
Bus 003 Device 004: ID 10c4:ea60 Silicon Labs CP210x UART Bridge  .
What would be the esptool command to flash the current firmware (when I compile the current git)? Same for the spiffs partition?
Also: I assume the SmartEVSE should be powered (no car connected), it will also power on via the usb connector....

Ok just found out that vscode does NOT upload the code automatically by running the debugger, for anyone else out there: click the platformio.ide icon, a strange out-of-space icon on the left menu bar, and there is an upload option available there. That works.
Now just one remaining question: if I now upload through the /update wifi method, I still boot on the ota0 usb partition (as you warned people for). How can I make the SmartEVSE switch to booting from ota1 again, so I can resume the comfortable wifi updating?

I just checked my program script, and i program the ota partition with a file called 'boot_app0' you can find this file in the
.platformio\packages\framework-arduinoespressif32\tools\partitions> folder.
(i have also attached it)
python esptool.py --chip esp32 --port /dev/ttyUSB0 --before default_reset --after hard_reset write -z --flash_mode dio 0xe000 boot_app0.bin
You can also do a full erase from within platformio, but then you'll lose the per device keys. (note that these are currently not used)
The controller can be powered through the USB connection. That's how i program them.
boot_app0.zip

Big thanks for your excellent support @mstegen !!
Just for collective learning:
I did not need to flash the boot_app0.zip , I don't think the ota0 / ota1 works as you described (being: ota0 = flash by usb, ota1= flash by webserver, and your warning not to mix it up).
I don't know if this is relevant documentation:
https://docs.espressif.com/projects/esp-idf/en/latest/esp32/api-reference/system/ota.html
..but it seems to work exactly this way: when you flash by webserver, it always is flashed onto the partition that is not in use, because it cannot flash over the running partition. Then at reboot it tries to execute the new firmware, if that fails it rolls back to the old firmware. Flashing by USB I didn't test, but I would expect it to behave the same way.
As for debugging, I added a library that allows remote debugging over wifi at serkri's github (trying to add my stuff to his github to prevent too many forks): https://github.com/serkri/SmartEVSE-3/pull/23  . I only use the serial print facility but it can even be expanded with breakpoints and manipulation of global variables, looks great!

I needed to install the CP210x_Universal_Windows_Driver to be able to upload the firmware from platformio.

Closing this one @dingo35 ;-)


Cmon guys, this is GitHub. Not IG or TikTok to gain followers 😂

If wanna get likes, there's HF and PapersWithCode.
Or maybe we should ask ArXiv.org to have social media features 👍👎♥⭐.


create DOS-DP patterns for non-human diseases

we need templates for non-human diseases.
These templates would probably be the same as for the human counterpart.

@cmungall and @matentzn I have some questions. Could you please advise? Thank you!
(If this is too long to discuss here, I could bring this up on a call.)
Question 1:

pattern 1: species-specific disease (e.g. dog diseases)
pattern 2: infectious disease (e.g 'disease has primary infectious agent' some 'infectious agent')

Do we need a 3rd pattern for "infectious disease in a specific species"? or can we mix the 2 patterns?
Question 2:
We already follow a pattern to relate non-human diseases to their human analogs ("cross-species analog" some 'human disease').
Should a non-human disease have 2 equivalents? for example:
'infectious disease, non-human animal'
= 'non-human animal disease' and ('cross-species analog' some 'infectious disease')
= 'non-human animal disease' and ('disease has infectious agent' some root)
Note: I am not 100% sure that the "cross-species analog" relation is correct since I don't think it is 100% correct to be passed to the children terms, but this is a different conversation for another issue/time.

Note: I am not 100% sure that the "cross-species analog" relation is correct since I don't think it is 100% correct to be passed to the children terms, but this is a different conversation for another issue/time.

I think you are right, and I would like to suggest to delete this relationship right after the initial classification is computed. We should not expose the "cross-species analog" relationship to our users, instead, we can use the relationship to classify the diseases and then use sparql to simply add regular mapping predicates to the release files (annotation level) which do not inherit down. If you raise this issue we can solve it in about 20 minutes.
For question 1, the lazy main answer is: generally we only need one pattern (pattern 1) for all diseases. This assumes that there is always an infectious disease counterpart in the human branch that can be used. My assumption is that for your use case, there is not; so you want to add a non-human disease which does not have a human counterpart?
This is best discussed in a call.

From my 1:1 with Nico:

we would use the "cross-species analog" relation to get the classification, but we would remove it as part of the release process (ie we would keep the classification but not the relation which would (and should not) get passed to the children)

RE: DOS-DP pattern:

for all the non-human diseases that have a "cross-species analog":
- the pattern should be to use the "cross-species analog" axiom
- we need to "materialize" the relations used in the human patterns so that the Equivalent in human diseases are inferred to the non-human disease.
- example: 'disease has location' (RO:0004026) : add the "SuperProperty Of" (Chain) 'cross-species analog' o 'disease has location' SubPropertyOf: 'disease has location'

for the non-human diseases that do NOT have an analog in human:
- we should create a script that would clone all the human-centric patterns and update them to use the "non-human disease" terms
- we would therefore only have to maintain human-centric patterns

@matentzn could you please review this summary to make sure I got it correctly? (feel free to edit directly if it is easiest).  Thank you !

Yes it is possible, but on closer that, I noticed that the correct pattern here (that is compatible with the normal cross species approach) is:
Non-human animal disease and 'has cross-species analog' some {HUMAN DISEASE PATTERN}

Which means for example:
Non-human animal disease and 'has cross-species analog' some infectious disease and has infectious agent some coronavirus

Which means it cannot be represented in OBO format (too complex). Big problem, you will have to check with Chris again.
So we need too discuss this with Chris. For now, don't let this block you though and just add subclass axioms wherever no cross-species analog exist, and maybe add a subset tag or something so we can easily find and curate those when we find a solution.

See DOSDP for genetic disease here: https://github.com/monarch-initiative/mondo/pull/7277

Note that most existing patterns use "MONDO:0000001" for the "disease" variable. MONDO:0000001 is the parent term of "human disease" and "non-human disease", and therefore the pattern could be use for both human and non-human diseases.
This simplify the creation of pattern for non-human animal diseases, especially since these patterns were to be the same as the human counterparts.
TO DO: review the patterns and make sure that the description is updated to include both human and non-human animal.

pattern for genetic diseases here: https://github.com/monarch-initiative/mondo/pull/7277

Genetic disease pattern is done.
I am closing this issue and will create more specific one(s) as needed.


[UI] Changes in Navigator

Description
Changes to UI of Navigator

Added Scroll Custom scrollbar
On Hover Opening of navigator
Moved Release details from dashboard to footer of navigator

Video
https://user-images.githubusercontent.com/51405571/138395823-1f846e0d-156a-4beb-a9a3-faf90a03dfd7.mp4
Signed commits

[x] Yes, I signed my commits.

A merge conflict here, @manav1403

https://user-images.githubusercontent.com/51405571/140636226-fd338a0a-ed20-41b7-bcac-9991bb884bfa.mp4
updated desgin @leecalcote

This looks pretty great, @manav1403. We'll either need a slight shadow or an off-white for the chevron. I think that's the only remaining feedback.


Added suggestions and fixed typo

Updated :)

Thanks @akshitac8

This looks good to me, thanks a lot!

Thanks for the comments @GeorgLink


vibe check

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

#243  👈
#238
master

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @chrisaddy and the rest of your teammates on  Graphite


sig-node: Introduce some responsibilities

What this PR does / why we need it:
make sure that we have specialists
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #
Special notes for your reviewer:
This is adding no new approver permissions, only defining ownership of some paths.
Checklist
This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR.
Approvers are expected to review this list.

[x] Design: A design document was considered and is present (link) or not required
[x] PR: The PR description is expressive enough and will help future contributors
[x] Code: Write code that humans can understand and Keep it simple
[x] Refactor: You have left the code cleaner than you found it (Boy Scout Rule)
[x] Upgrade: Impact of this change on upgrade flows was considered and addressed if required
[x] Testing: New code requires new unit tests. New features and bug fixes require at least on e2e test
[x] Documentation: A user-guide update was considered and is present (link) or not required. You want a user-guide update if it's a user facing feature / API change.
[x] Community: Announcement to kubevirt-dev was considered

Release note:

NONE

@vladikr wdyt?

I'm fine with this.
/approve

/retest

This PR would benefit from #11147


The interpreter does not appear in VSCode

Issue Summary
When doing the "Your first Wagtail site" tutorial I had the same problem on several attempts, and that is that I cannot set the interpreter of the virtual environment created with the command that wagtail delivers. That makes me unable to use autocomplete and VS code drives me crazy showing me errors in the errors tab.
The only "patch" solution I could find was the one mentioned at the beginning of this post, which uses pipenv
pipenv for function/code completion
with "Create and activate a virtual environment" step, it just doesn't show up in VScode.
Steps to Reproduce

python3 -m venv mysite/env
source mysite/env/bin/activate
and it doesn't show up in VScode

I don't know if it's a VScode or Wagtail bug, but I would like to know if the only solution to that is to use pipenv or am I doing something wrong?
thanks
Technical details

Python version: Python 3.10.2
Django version: 4.0.2
Wagtail version: 2.16.1

Closing this as VSCode configuration is out of scope for Wagtail, but you may be able to get further pointers from people on our support channels.


Feature request: support for IPv6 inside the tunnel

The current configuration is set up for IPv4 only. It would be nice to be able to support IPv6.

#24 might be worth a look.

Check this merge request #45.


Progress bar does not follow drag

When you grab and slide the progress bar, you would expect the pointer to follow your finger, but Chewie doesn't do that.
It seems that the _latestDraggableOffset is not passed to the StaticProgressBar and the update is not reflected, is this intended?
https://github.com/fluttercommunity/chewie/pull/712

good to fix this

https://github.com/fluttercommunity/chewie/issues/797
im having the same issue

@koutaro-masaki I'll look into this sometime this week. If you have a PR that fixes this, I'll be happy to review it. Thanks.

@diegotori Would you be able to publish the fix to the package?

I'll make an effort first thing tomorrow. Gonna be out of the country for two weeks, so I'll try to squeeze it before I head out.

Published in version 1.7.2.

Thank you!


Mistake in docs

The docs for the set method should read "returned by with" instead of "returned by get".

Or maybe it means "returned by f"?


Pass reference into SAM Reader for CRAM support

This allows CRAM files to be used in the existing structure. Fixes #606

:+1:


Adding a new rebus

Associated Issue: #121
Summary of Changes

Added angrybirds , which is an angry emoji, a bird emoji and the letter s

Pull Request Test Coverage Report for Build 917

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 87.143%

Totals

Change from base Build 514:
0.0%

Covered Lines:
158

Relevant Lines:
180

💛  - Coveralls


README should link to manual

The readme should prominently link to the manual.  Also a link in the tag-line would be good.  Last, a screenshot in the "Overview" section would be cool.
This is just from my first quick impression landing here.

Thanks for the suggestion. It's an easy fix :-)


Quiet builds a bit more

As the commits say:

include bower and npm commands in --quiet target
short-circuit TestCommand() calls once commands are installed locally

/cc @davidfowl

Eh, seems :shipit: to me... assuming you've tested it in the various relevant scenarios (installed, not installed, quiet, not quiet, etc.).


about kitti training classes

Hi, sir. there is a question I want to ask.
I found in pv_rcnn.ymal, there only CLASS_NAMES:['Car','Pedestrian','Cyclist'], so it only use the labels of these three classes to train model and don't use the label of other classes such as van, dontcare? Very appreciate for your reply!

Yes

thanks for your reply!


Could you please upload the processed datasets?

Hi, thanks for your great job. I am kindly request if you could share the processed dataset that you used for your project. For example, the SOTAB-27 you named in your paper simplifies the original SOTAB into 27 distinct labels.

How can I find the flan-t5-xxl-zs-shortprompt model checkpoint?

Hi! The SOTAB-27 and SOTAB-91 benchmarks were constructed from the SOTAB dataset. The SOTAB train, validation and test files, as well as instructions for their extraction and use, can be acquired via their website. (http://webdatacommons.org/structureddata/sotab/)
Once you have downloaded and extracted the SOTAB dataset, you need only point the model to the correct data path and specify the label set you wish to apply as a command line argument (E.G., --label_set="SOTAB-91")

I apologize for the oversight. Thank you for your guidance!


Request for adding examples of "Other Plans"

[Enter feedback here]
Could you add examples of Other Plans?
Customers using Microsoft 365 Business Basic, Standard, and Premium can find it difficult to determine that they fall under the “Other Plans”.
Phone number
0120 628 860 (Other Plans) → 0120 628 860 (Other Plans e.g. Microsoft 365 Business Basic, Standard, Premium)
Technical Support:
Other Plans: -> Other Plans e.g. Microsoft 365 Business Basic, Standard, Premium:
Local call charges apply:
03 4332 6257 (Other Plans) → 03 4332 6257 (Other Plans e.g. Microsoft 365 Business Basic, Standard, Premium)

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 6e3618e4-be59-8a6f-92c8-cd915c63313d
Version Independent ID: 9caeb339-7a2b-a2ce-4850-61896ea68825
Content: Support information for Japan - Microsoft 365 admin
Content Source: microsoft-365/admin/support/japan.md
Service: microsoft-365-business
GitHub Login: @cmcatee-MSFT
Microsoft Alias: cmcatee

@sasaito Thank you for your feedback. We have made changes to the document via PR#https://github.com/MicrosoftDocs/microsoft-365-docs/pull/9941
Once the author approves, the changes will be live.
Thanks
Sri

@sasaito Closing as per author's comment. Thanks

@yogkumgit This can be closed as well as the japan.md article was retired and replaced with Find Microsoft 365 for business phone support numbers by country or region

Thank you for this update.
I am looking at Find Microsoft 365 for business phone support numbers by country or region, but I can't see the examples for other plans in Japan region. Is it expected?


@show_requirements documentation seems misleading.

The docstring for @show_requirements suggests that the macro can be invoked as @show_requirements(solver, problem):
https://github.com/JuliaPOMDP/POMDPLinter.jl/blob/87ecbbb844b3f3c93b4d28124523162cef6e9796/src/requirements_interface.jl#L107
However, I get an error if I try to do that. The only valid invocation seems to be @show_requirements(POMDPs.solve(solver, problem.)).

I looked at this briefly, but couldn't figure out what you meant. The invocation at the end of the first line doesn't match the docstring that you quote. In any case, it is not a high priority.

Oh, you are absolutely right. It must have been late. I'm sorry for the confusion.