Rendering of mixed lists not consistent

Original issue comment https://github.com/MunifTanjim/minimo/issues/212#issuecomment-478317755.
I noticed that Hugo will add the class .task-list to any parent/top-level list that has a nested task items. Whereas this is not the case with GitHub rendered markdown .contains-task-list class, which is added at respective inner levels only.
This makes styling difficult.

I noticed that Hugo will add the class .task-list to any parent/top-level list that has a nested task items.

But we do so consistently, right? I was a little confused by the title; I assume this is about GitHub doing it differently (and better)?

Sorry about the confusing title.
Yes, I do like GitHub's approach of rendering it. It allows for more flexibility/easiness of styling in case of complex nested and mixed lists.
Sample: https://github.com/facelessuser/MarkdownPreview/blob/master/examples/test.md#mixed-lists


Created a RAG with history it's working but not following the prompt instructions properly

Checked other resources

[X] I added a very descriptive title to this issue.
[X] I searched the LangChain documentation with the integrated search.
[X] I used the GitHub search to find a similar question and didn't find it.

Example Code
qa_system_prompt = """Note\
            Make sure to address the user's queries politely.\
            Compose a comprehensive reply to the query using the search results given.\
            1.Respond to the questions based on the given context. \
            2.please refrain from inventing responses.\
            3.Use as much detail when as possible when responding. Answer step-by-step.\
            4.Locate the answer within the given context.\
            5.Keep the response within 3000 tokens.\
            6. If a user asks the questions like please summarise the above, then you should summarize the previous answer you provided which can be fetched from the history\
            7. If the user queries based on its previous questions please surround your answers based on the history of previous questions\

        IMPORTANT NOTE: Don't answer question outside of provided context and kindly respond with "I apologize, but that falls outside of my current scope of knowledge."\

        Use the following context to answer the question:\
                ------

                CONTEXT:
                {context}

                """

Description
Using this prompt, this was working fine in v0.0.336 but after i started using this new v0.1.0 code the no matter how i write the prompt it's not following the instruction mentioned below:
IMPORTANT NOTE: Don't answer question outside of provided context and kindly respond with "I apologize, but that falls outside of my current scope of knowledge.
It's working for few questions and not working for others.
System Info
%pip install --upgrade langchain langchain-community langchainhub langchain-openai chromadb bs4
python 3.9
model: gpt-3.5-turbo-16k
Related Components

[X] LLMs/Chat Models
[ ] Embedding Models
[X] Prompts / Prompt Templates / Prompt Selectors
[ ] Output Parsers
[ ] Document Loaders
[ ] Vector Stores / Retrievers
[ ] Memory
[ ] Agents / Agent Executors
[ ] Tools / Toolkits
[X] Chains
[ ] Callbacks/Tracing
[ ] Async

No, i'm not getting any errors. Infact every bit of the RAG i built is working fine, just that it's not following that specific instruction properly. some of the questions i tried that worked but shouldn't work are:

what is cyberpunk 2077
write a python code to identify prime numbers

The original document used to built the RAG is Interstellar movie script and it should only answer question related to Interstellar.

@dosu-bot, but it was working fine in v0.0.336 facing issue after i started migrating to v0.1.0.

@dosu-bot, This is the resource i'm using to build the bot Resource and i have tried changing the prompt multiple times

Issue got fixed after I replaced
SUPPORT_PROMPT = ChatPromptTemplate.from_messages(
     [
        ("system", support_template),
         MessagesPlaceholder(variable_name="chat_history"),
         ("human", "{question}"),
     ]
 )

with
SUPPORT_PROMPT = PromptTemplate(
    template=support_template, input_variables=["chat_history", "context", "question"]
)

Instead of me following the examples given in the docs, used some code from my previous implementation.


Public API to hide the dockLayer Side panel

As discussed in https://github.com/napari/napari/pull/3947, it would be amazing to hide the side panel in napari programmatically.
This is already possible by accessing the private API like this:
viewer.window._qt_viewer.dockLayerControls.toggleViewAction().trigger()
viewer.window._qt_viewer.dockLayerList.toggleViewAction().trigger()

It would more convenient though to create a new public API, e.g. as @jni suggested:
viewer.controls.visible = False
viewer.layers.visible = False

Why this would be nice to have:
One could then use viewer.window.resize(600, 600) together with viewer.screenshot() and the aspect ratio would be kept.
To keep the aspect ratio, one could also use right now the size=  parameter in screenshot, but that comes with disadvantage that it is not wysiwyg.

I have exactly the same request (this command is needed for plugins) and I currently get this warning each time I use the private API:
FutureWarning: Public access to Window.qt_viewer is deprecated and will be removed in v0.5.0. It is considered an "implementation detail" of the napari application, not part of the napari viewer model. If your use case requires access to qt_viewer, please open an issue to discuss.!

I agree we probably need some public API to generally achieve the hiding and showing of widgets.  But it would be nice to do so in a single method such that we don't need to add a new one everytime we want to show hide another thing.  viewer.controls.visible = False and viewer.layers.visible = False are simple enough for now, but what about viewer.console ... and yes we have two commonly used internal controls for now, but will we always?  and do they each have to come with a new public method?
Perhaps we could consider a more future proof viewer.window.hide/show_widget(some_key)?  (note: I don't love that particular proposal, especially if some_key is a string ... but I also don't know that I love having a new viewer.window.thing for every new widget we want to make available

Is this api decision still under consideration as 0.5.0 approaches? I've been using this method from the forums
import napari

with napari.gui_qt():
    viewer = napari.Viewer()
    viewer.window.qt_viewer.dockLayerList.setVisible(False)
    viewer.window.qt_viewer.dockLayerControls.setVisible(False)

but it throws the FutureWarning mentioned above.
Public access to Window.qt_viewer is deprecated and will be removed in
v0.5.0. It is considered an "implementation detail" of the napari
application, not part of the napari viewer model. If your use case
requires access to qt_viewer, please open an issue to discuss.

There is still a lack of implementation of the necessary API that will allow to removal viewer.qt_viewer. So we do not know at this moment what will happen. most probably not at 0.5.0. maybe 0.5.1 or 0.6.0
But If you do not want LayerList and LayerControls then you may directly use QtViewer instead of Viewer and embed it in your own interface.


Fix a shadow symbol warning

Will fix the Travis-ci master build.
If it's not currently in the internal review pipe.

+1

+1 will merge

done.  thanks!


[SIDECAR] Check if all types returned from sidecar have a json representation

As per the triage, this is already done. So closing it.


mongo-connector appears to be working, but not seeing updates from replica set

Had an issue the other day in our production environment.  Mongo-Connector processed a burst of updates (inserts and deletes) to ElasticSearch.  According to the logs, it supposedly went back to monitoring the mongo replica set, but was not picking up any changes.  We modified records in Mongo - mongo-connector did not pick up the changes.   Once we restarted the mongo-connector, it picked up changes again (not a surprise).
According to the log files, it was running just like it was before the burst.   No errors were in the log file at all (before, during, or after) the burst went through.    No messages indicating it was falling behind...no error messages.  The burst was not necessarily "unique" as our traffic tends to be bursty.   The burst lasted for about 11 seconds.  According to the log files - no failures in updating the data.
Any ideas on what might have gone wrong, maybe config parameters to help prevent this in the future, or, further checks we can do to see what's going on with the mongo-connector would be appreciated.  If someone has seen this before, what did you do to get around this?
Here's information about the setup.

Mongo-Connector running as a daemon on an AWS Redhat Linux VM.
Two instances of Mongo-Connector are running against the same mongo cluster.   One instance replicates a collection where only certain fields are sent to ElasticSearch, the other instance fully replicates 3 other Mongo collections   The instance that went silent was the one replicating the 3 mongo collections.
Mongo cluster consists of 3 nodes - no sharding.  All 3 nodes are in AWS running on VMs.
Mongo cluster did not change primary servers at this time.
ElasticSearch instance running as an AWS ElasticSearch service.
Mongo-Connector is using aws-es-proxy (from github) to communicate to AWS ElasticSearch Service.
Mongo-Connector had been running for multiple weeks prior to this with no issues (that we are aware of).
Mongo-Connector version - 2.5.1
Mongo version - 3.2.4

The configuration information for the instance that had issues:
{
"mainAddress":
"mongodb://mongodbNode1:port,mongodbNode2:port,mongodbNode3:port/",
"oplogFile":
"/oplog/file/location",
"verbosity":
3,
"continueOnError" :
true,
"namespaces": {
"mongodb.collection1": "elasticSearchIndex1.type1"," mongodb.collection2": " elasticSearchIndex2.type2"," mongodb.collection3": " elasticSearchIndex3.type3"
},
"logging":{
"rotationWhen":
"M",
"rotationInterval":
30,
"filename":
"/path/to/logfile/logname"
},
"authentication": {
"adminUsername":
"username",
"password":
"password"
},
"docManagers": [
{
"args":{
"clientOptions": {
"timeout":
100
}
},
"docManager":
"elastic2_doc_manager",
"targetURL":
"localhost:9200"
}
]
}

Doing some research on this and digging through the code a little - keeping in mind my Python is rough and my PyMongo is non-existent...
Looking at the Mongo 3.6 documentation it states:

Tailable cursors may be dead, or invalid, if either:
- the query returns no match.
- the cursor returns the document at the "end" of the collection and then the application deletes that document.
 A dead cursor has an id of 0.

It appears the mongo-connector code is performing a cursor.alive call - is the potential solution for this issue as simple as adding a check on the cursor.cursor_id() to verify it is > 0?
If that is the case:

how to modify the code to restart the cursor and enter back into the while loop?

Once that is figured out, how best to test this?  Add a record to a collection, let it update to ElasticSearch and then delete the record from Mongo? Is that considered to be at the "end" of a collection in Mongo?


Not all celery workers being used

This has been observed with the AMI images on AWS; not sure if it applies to local installs also.

Replaced by #566.


fix: improve cluster scaling

:newspaper: PR description
Implement various improvements to enable scaling clusters to 10+ nodes:

[ ] optimize target node waiting in seed to decrease binding time
[ ] improve logging
[ ] better handle edge cases in proxying
[ ] improve lambda scaling by finxing thread pool size

:memo: Reviewer instructions

At this state we still have unexplained timeouts. In particular we see that sometimes the quic connection fails in a surprising fashion:
> cat output.log | grep "WARN perforator{virt_ip="<IP_ADDRESS>"}"
12:55:53.473  WARN perforator{virt_ip="<IP_ADDRESS>"}:tcp_srv:tcp_conn{src_port=52087}:fwd_conn:cli_quic_conn{tgt_nat=<IP_ADDRESS>:5001 tgt_port=8080}:quic_conn_creation: chappy_perforator::quic_utils: timeout, retrying...
12:55:53.561  WARN perforator{virt_ip="<IP_ADDRESS>"}:tcp_srv:tcp_conn{src_port=38017}:fwd_conn:cli_quic_conn{tgt_nat=<IP_ADDRESS>:5001 tgt_port=8080}:quic_conn_creation: chappy_perforator::quic_utils: timeout, retrying...
12:55:53.658  WARN perforator{virt_ip="<IP_ADDRESS>"}:tcp_srv:tcp_conn{src_port=36817}:fwd_conn:cli_quic_conn{tgt_nat=<IP_ADDRESS>:5001 tgt_port=8080}:quic_conn_creation: chappy_perforator::quic_utils: timeout, retrying...
12:55:53.761  WARN perforator{virt_ip="<IP_ADDRESS>"}:tcp_srv:tcp_conn{src_port=44791}:fwd_conn:cli_quic_conn{tgt_nat=<IP_ADDRESS>:5001 tgt_port=8080}:quic_conn_creation: chappy_perforator::quic_utils: timeout, retrying...
12:55:53.789  WARN perforator{virt_ip="<IP_ADDRESS>"}:tcp_srv:tcp_conn{src_port=55893}:fwd_conn:cli_quic_conn{tgt_nat=<IP_ADDRESS>:5001 tgt_port=8080}:quic_conn_creation: chappy_perforator::quic_utils: timeout, retrying...
12:55:53.884  WARN perforator{virt_ip="<IP_ADDRESS>"}:tcp_srv:tcp_conn{src_port=51155}:fwd_conn:cli_quic_conn{tgt_nat=<IP_ADDRESS>:5001 tgt_port=8080}:quic_conn_creation: chappy_perforator::quic_utils: timeout, retrying...
12:55:54.009  WARN perforator{virt_ip="<IP_ADDRESS>"}:tcp_srv:tcp_conn{src_port=39205}:fwd_conn:cli_quic_conn{tgt_nat=<IP_ADDRESS>:5001 tgt_port=8080}:quic_conn_creation: chappy_perforator::quic_utils: timeout, retrying...
12:55:54.014  WARN perforator{virt_ip="<IP_ADDRESS>"}:tcp_srv:tcp_conn{src_port=53613}:fwd_conn:cli_quic_conn{tgt_nat=<IP_ADDRESS>:5001 tgt_port=8080}:quic_conn_creation: chappy_perforator::quic_utils: timeout, retrying...
12:55:54.162  WARN perforator{virt_ip="<IP_ADDRESS>"}:tcp_srv:tcp_conn{src_port=34225}:fwd_conn:cli_quic_conn{tgt_nat=<IP_ADDRESS>:5001 tgt_port=8080}:quic_conn_creation: chappy_perforator::quic_utils: timeout, retrying...

> cat output.log | grep "ERROR perforator{virt_ip="<IP_ADDRESS>"}"
12:56:32.877 ERROR perforator{virt_ip="<IP_ADDRESS>"}:tcp_srv:tcp_conn{src_port=55019}:fwd_conn:cli_quic_conn{tgt_nat=<IP_ADDRESS>:5001 tgt_port=8080}:quic_conn_creation: chappy_perforator::quic_utils: connection timeout elapsed
12:56:32.877 ERROR perforator{virt_ip="<IP_ADDRESS>"}:tcp_srv:tcp_conn{src_port=55019}:fwd_conn:cli_quic_conn{tgt_nat=<IP_ADDRESS>:5001 tgt_port=8080}: chappy_perforator::forwarder: Dropping upstream connection
12:56:32.878 ERROR perforator{virt_ip="<IP_ADDRESS>"}:tcp_srv:tcp_conn{src_port=36147}:fwd_conn:cli_quic_conn{tgt_nat=<IP_ADDRESS>:5001 tgt_port=8080}:quic_conn_creation: chappy_perforator::quic_utils: connection timeout elapsed
12:56:32.878 ERROR perforator{virt_ip="<IP_ADDRESS>"}:tcp_srv:tcp_conn{src_port=36147}:fwd_conn:cli_quic_conn{tgt_nat=<IP_ADDRESS>:5001 tgt_port=8080}: chappy_perforator::forwarder: Dropping upstream connection

The timed out connections don't match the connections that warned of failures before, which shouldn't be possible as multiple failed attempt should occur before the timeout.


Does test_iter in faster_rcnn don't need prepare(possibly bug)?

in https://github.com/chainer/chainercv/blob/master/examples/faster_rcnn/train.py#L46 there is prepare operation in img, but in https://github.com/chainer/chainercv/blob/master/examples/faster_rcnn/train.py#L100 your code just doesn't use Transform to transform(contains  prepare and mirror image)
is this code correct?

because def prepare contains substract mean value from each pixel , this means your test_iter simply doesn't substract mean value?

All the necessary preprocessing is carried out inside FasterRCNN.predict, which is a function that is called inside DetectionVOCEvaluator.


Misc 5.6 docs

@amyblais Eric is out for the rest of the week, so we may want to either make changes ourselves if you see fit, or merge as-is and submit another PR for updates next week.
If the latter, let me know and I can own the follow-up given you're away next week.


[SPARK-44409][SQL] Handle char/varchar in Dataset.to to keep consistent with others

What changes were proposed in this pull request?

This PR replaces user-specified char/varchar in dataset.to API to make it consistent with other dataset/dataframe APIs
Why are the changes needed?

Currently, INVALID_COLUMN_OR_FIELD_DATA_TYPE is thrown when converting char to char, varchar to varchar.
Does this PR introduce any user-facing change?

yes, different error classes when LEGACY_CHAR_VARCHAR_AS_STRING off and using char/vachar in dataset.to. While LEGACY_CHAR_VARCHAR_AS_STRING on, to is able to handle char/varchar
How was this patch tested?

new tests

cc @cloud-fan who added this new API in 3.4

thanks @HyukjinKwon , merged to master


Implement GroupKeyStoreImpl in nRF5

Problem
Currently, we does not have GroupKeyStoreImpl for nRF5 platforms.
Proposed Solution
Implement GroupKeyStoreImpl.

Closing issue on a legacy platform.


Support to List VPC clusters

Can you please add unit test cases..

@hkantare I aded units test . Please review and merge


Cannot train custom speech with utterances and pronunciation

When I try to train a custom speech model I cannot use an utterances file and a pronunciation file together. I prepared both of these as text files and can train a model using 1 file at a time. I cannot however train with both. When following the instructions in #31337 the "Add pronunciations" option does not appear. Here is what I see:

I have also tried to zip the utterances and pronunciation text files together, but when I try to upload the data it can only be in .txt format.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 120ebdde-5785-5850-c963-803bf3744112
Version Independent ID: 82bc9a4e-3908-499f-dd2c-31eacc227fff
Content: Prepare test data for Custom Speech - Speech Services
Content Source: articles/cognitive-services/Speech-Service/how-to-custom-speech-test-data.md
Service: cognitive-services
Sub-service: speech-service
GitHub Login: @erhopf
Microsoft Alias: erhopf

@OlieVuur Thank you for the question! We are investigating this and will get back to you shortly.

@ArcherAZ Hi Archer, could you please help to check this issue? It has happened before. https://github.com/MicrosoftDocs/azure-docs/issues/31337 Thank you very much.

Good day, given that this issue prevents me from training the appropriate model, do you have a time-frame by when I might expect some feedback?

@OlieVuur Hi, do you have a support plan under your Azure subscription ID? If yes, I would highly recommend you to create a support ticket to live trouble shooting. IF not, please send us an email at<EMAIL_ADDRESS>with your Azure subscription ID and URL of this thread. We could enable one for you. Thank you.

Hi, which language/locales are you working on? Only en-US/de-DE are supported with pronunciation training at this moment

@ArcherAZ thanks for highlighting this, I was using en-UK. I can now add the pronunciations when using en-US.


ARROW-6778: [C++] Support cast for DurationType

https://issues.apache.org/jira/browse/ARROW-6778

Codecov Report

Merging #5578 into master will increase coverage by 0.58%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #5578      +/-   ##
==========================================
+ Coverage   88.79%   89.37%   +0.58%
==========================================
  Files         983      791     -192
  Lines      132170   117048   -15122
  Branches     1501        0    -1501
==========================================
- Hits       117362   104614   -12748
+ Misses      14443    12434    -2009
+ Partials      365        0     -365

Impacted Files
Coverage Δ

cpp/src/arrow/type_traits.h
87.35% <ø> (ø)
:arrow_up:

cpp/src/arrow/compute/kernels/cast.cc
96.71% <100%> (+0.13%)
:arrow_up:

cpp/src/arrow/compute/kernels/cast_test.cc
99.62% <100%> (+0.15%)
:arrow_up:

cpp/src/arrow/dataset/scanner.cc
66.66% <0%> (-6.87%)
:arrow_down:

cpp/src/arrow/filesystem/s3_internal.h
90.74% <0%> (-3.71%)
:arrow_down:

cpp/src/arrow/stl.h
95.48% <0%> (-2.91%)
:arrow_down:

cpp/src/arrow/dataset/dataset.h
80% <0%> (-2.36%)
:arrow_down:

python/pyarrow/plasma.py
58.9% <0%> (-1.37%)
:arrow_down:

python/pyarrow/tests/test_parquet.py
95.24% <0%> (-0.06%)
:arrow_down:

cpp/src/arrow/ipc/reader.cc
90.15% <0%> (-0.03%)
:arrow_down:

... and 211 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update af097e6...4ebbce7. Read the comment docs.

Still to do in this PR is casting to different unit.

Still to do in this PR is casting to different unit.

What do you mean? It seems this is tested for.

Ah, yes, you're right ;) I somehow forgot I already added that ...
It was already implemented, and tested for going to higher resolution (s -> ms), but not yet for the other way around, so added tests for that now.


Support project reference builds in gulp builds

This restores support for building TypeScript using gulp now that gulp-typescript has minimal support for project references.
This was accomplished using the following changes:

Most non-gulp.task related logic has been moved out to individual gulp "plugin" scripts in scripts/build.
I've exposed the up-to-date checking logic from src/compiler/tsbuild.ts so that it can be leveraged by scripts/build/upToDate.js.
I added scripts/build/project.js, which wraps our project references in a gulp orchestration.

NOTE: I've needed to temporarily disable support for gulp.watch as I still need to clean up/expire changed "projects" from the cache in scripts/build/project.js, but that could happen in a later PR.

There are also a number of unexpected differences in the LKG I want to look at before we take this as well.


Should MacroCall be MacroDef?

I was looking into plugging mbe into signature help and while I don't know a lot about macros I noticed that
/// empty macro
macro_rules! foo { // <--- Why is this MACRO_CALL ?
    () => {}
}

fn f() {
    foo!(<|>); // <--- other MACRO_CALL
}

contains two MACRO_CALL nodes once of which I would think of as the definition. Indeed https://doc.rust-lang.org/reference/macros-by-example.html shows the first example as MacroRulesDefinition

macro_rules! is almost a macro. In particular, the grammar in rustc was like
macro_call ::= ident! ident? token_tree

I think right now macro calls with extra ident are removed and macro_rules is special cased, but for example, macro_rules body is still parsed as a general token_tree and destcructed into $( lhs => rhs);* using the macro by example machinary as well.
TL;DR: it's a macro call because, syntactically, it's actually a macro call.

Thanks


'No upcoming pickups' message

Current coverage is 98.51% (diff: 100%)

Merging #204 into master will not change coverage

@@             master       #204   diff @@
==========================================
  Files           100        100
  Lines          1479       1479
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
  Hits           1457       1457
  Misses           22         22
  Partials          0          0

Powered by Codecov. Last update bdcf458...00c536b


chore(RingTheory/Ideal): split up Ideal/Basic.lean

This PR splits off various definitions and results from RingTheory/Ideal/Basic.lean:

Ideal goes to Ideal/Defs.lean
results on ⊥, ⊤, ⊔, ⊓ go to Ideal/Lattice.lean
Ideal.IsPrime goes to Ideal/Prime.lean
IsPrincipalIdealDomain and Ideal.span go to Ideal/Span.lean
Ideal.IsMaximal goes to Ideal/Maximal.lean

Thanks :tada:
If CI passes, please remove the label awaiting-CI and merge this yourself, by adding a comment bors r+.
bors d+

bors merge


unable to read gmail inbox

The software cannot read mails from the GMAIL Inbox.

Fixed the issue.


MWPW-142200 ability to add strikethrough fro price for Special offer

Resolves: MWPW-142200
Test URLs:

Before: https://main--milo--adobecom.hlx.page/drafts/vkniaziev/document6?martech=off
After: https://mwpw-142200--milo--adobecom.hlx.page/drafts/vkniaziev/document6?martech=off

@VKniaz could you please update your test urls and provide valid milo urls instead of cc ones?

@yesil done.


Parse and render messages synchronously.

This significantly simplifies MessageContainer and possibly speeds up rendering.

I was going to suggest that. 👍


fix: use WST currency code for Samoa

https://en.wikipedia.org/wiki/Samoa
According to Wikipedia, the Tālā (symbol: WST) is the current currency in Samoa.

Hello @jasongitmail, thank you for the contribution. Since index.ts is a file generated by generate.js, any inclusions or fixes need to be made in the latter. Sorry for not explaining that before.
I just published a new release that mentioned and included your contributions.
Thank you

Good to know. Thanks for making the updates!


Dockerfile ignores local changes

This prescription will ignore local changes (really confusing):
git clone https://github.com/nypublicradio/audiogram.git
cd audiogram
docker build -t audiogram .

As Dockerfile specifies RUN git clone https://github.com/nypublicradio/audiogram.git.
A quick fix I made for @evoterra: https://gist.github.com/Laurian/32a1250e270ad5d31a75e0a729179c79

Note that in that quickfix I commented out USER audiogram due to some permission errors:
<EMAIL_ADDRESS>postinstall /home/audiogram/audiogram
mkdir -p editor/js && browserify client/index.js > editor/js/bundle.js

mkdir: cannot create directory 'editor/js': Permission denied

That permissions issue is part of the reason why it clones from the repo rather than copying locally, because Docker unfortunately doesn't allow ADD as anything other than root:
https://github.com/docker/docker/issues/6119
But the more general issue is that changes being reflected in Docker will depend on where you make them in either case.  For example, ADDing the files will incorporate initial changes but not subsequent ones.
Among other options, you can:

Edit the themes.json file in the Docker container.
Edit the themes.json file locally and copy it.
Mount the settings folder in the container.

https://github.com/nypublicradio/audiogram/issues/39#issuecomment-239681199
I'm not sure there is any ideal solution to these tradeoffs, but resolving #32 should make it mostly irrelevant by eliminating the need to customize by directly editing source files.

Laurian,
I think this thread is relevant to my issue, but it's a bit over my head.
I've made some simple changes to themes.json. Different name, color and background image. Image is in the correct folder. Committed in GitHub and synced. This new theme is not showing up in the dropdown menu. Thoughts?

See #50 as a solution, or modify the Dockerfile in your fork to git clone from your repo.

Thank you, Laurian. I've put in an additional query on #50. I don't know how to modify the Dockerfile—or what a "fork" is. I'm sorry. I've never attempted anything like this before.


Update goldens for https://github.com/flutter/flutter/pull/19044

Submitting TBR to unblock flutter engine roll from completing all tests


Could you help me understand the "fix sign" process?

Hi,
Thank you for your effort to implement the ECI algorithm!
However, I do have a question that needs your help. After calculating the ECI for each country and the PCI for each product, why there is an additional step to "fix the sign"? I know the rankings may be reversed without this step, but I can't find it in the papers or books by the authors. Is it a typical procedure in linear algebra?
In addition, according to Kemp-Benedict (2014), ECI and the diversity of countries are orthogonal. Does it mean that ECI is independent of diversity and should have a close-to-zero correlation coefficient? In my experiment with your and the official code, ECI and the diversity show a significant positive correlation (~0.5, both Pearson's and Spearman's correlation). Do I misunderstand what orthogonal means?
Thank you!

Hello @tomleung1996,
The step to fix the sign is there because an eigenvector is not just one vector, but all nonzero scalar multiples of that vector. Due to the numerical optimization methods used to calculate the vectors, the sign might flip. Particularly, numpy will return the vector with magnitude 1. Thus, we correct the sign by the correlation with diversity (ubiquity), as more diverse economies (less ubiquitous products) tend to be more complex.
Here is a video by 3Blue1Brown I like about eigenvectors where you can get a better understanding of why the multiples of eigenvectors can be treated the same.


Add regression test for CircleHash64

Description
Add tests to check some CircleHash64 digests for compatibility.
This is a subset of the full CircleHash64 compatibility tests (which verify nearly 600,000 digests).  This subset was copied from fxamacker/circlehash (Apache License 2.0).
Closes #245

[x] Targeted PR against main branch
[x] Linked to Github issue with discussion and accepted design OR link to spec that describes this work
[x] Code follows the standards mentioned here
[x] Updated relevant documentation
[x] Re-reviewed Files changed in the Github PR explorer
[x] Added appropriate labels

Codecov Report

Merging #247 (2953a4b) into main (82a5e53) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #247   +/-   ##
=======================================
  Coverage   68.90%   68.90%
=======================================
  Files          14       14
  Lines        7245     7245
=======================================
  Hits         4992     4992
  Misses       1621     1621
  Partials      632      632

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 82a5e53...2953a4b. Read the comment docs.


break out of frame on log in window

Currently, if you have 2 windows and in one you log out there is a chance that you will get a weird behavior cause we are not forcing/breaking from frames, see:

Probable solution: https://css-tricks.com/snippets/javascript/break-out-of-iframe/

fixed via: https://github.com/biocore/qiita/pull/2328


Set username/password and can no longer access web UI

Hi. Thanks for this firmware. This is amazing. I have one issue with a few cameras I setup (9FUS). I set a username/password as well as a root password. Once they rebooted I cannot login to the web interface with that username and password. I can however login via SSH. Is there a way to reconfigure the standard user's credentials from SSH and is there any limitations to the length and characters allowed in the user account for the web interface? Thanks!

I don't remember exactly but another user found a limit in the size.
You can change the password from SSH editing the file /home/yi-hack/etc/system.conf

Thanks I figured it out eventually. It wasn't actually the length that was a problem for me it was an issue with some symbols. Switched to alphanumeric and it worked fine. Appreciate all your work on this firmware @roleoroleo!

If you use only the suggested special chars, it should work.


Neo4j - Unable to run multiple cypher files with Neo4J Docker 4.2.5

I am using neo4j with docker version 4.2.5 and cypher file to initialize data.
I am setting following environment property to initialize data with docker-compose -
NEO4J_apoc_initializer_cypher=CALL apoc.cypher.runFile ("file:///sample.cypher")
This works fine and load the data after server started. However, you cannot create indexes in this file. You need runSchema call to create indexes. As per doc for neo4j 4.2, you can run multiple cypher,
NEO4J_apoc_initializer_cypher_0=CALL apoc.cypher.runSchemaFile ("file:///schema.cypher")
NEO4J_apoc_initializer_cypher_1=CALL apoc.cypher.runFile ("file:///sample.cypher")
However, this throws error:
unknown settings: apoc.initilizer.cypher.0
unknown settings: apoc.initilizer.cypher.1

@jexp is this an issue with apoc or cypher perhaps?

@jennyowen i think this seems neo4j.conf couldn't understand these properties. But as per doc it should.

@akshaymhetre do you mean this documentation? https://neo4j.com/labs/apoc/4.2/operational/init-script/
This says the parameter is apoc.initializer.<DATABASENAME>.0 you're creating parameters apoc.initialize.cypher.0 so you're doing initialize not initializer and is your database called cypher or are you using the default database name neo4j?

Apologies, Some copying error from my side, i have updated the issue.
I am using initializer in the code and also using different database other than neo4j and system.
As i mentioned it worked with single file but not working with multiple ones.

@jennyowen  Tried with apoc.initializer..0 as well still not working
Same error has been thrown:
Unrecognized setting. No declared setting with name: apoc.initializer.mydb.0

I have the same problem

It sounds like neo4j is starting up and the parameters are being correctly passed. I believe this is a problem with APOC rather than the docker image.
Could you raise your issue at https://github.com/neo4j-contrib/neo4j-apoc-procedures please?

@akshaymhetre Do you want to raise an issue on the APOC side ?

@aowss added at, Please add your points if any.


Allow for passing of parameters for uvicorn process call

I use this container to host an ML model, which takes a while to load on startup. Uvicorn tries to kill it because of this. Normally one could set the timeout, but this is not yet supported in this container.
Maybe it would be nice to have some way to add parts to the uvicorn command, such as timeout values.

Added! Thanks for the request!


Implementation of Holtslag SCFs

Purpose

Add stability correction functions from Holtslag and De Bruin (1988) into UniversalFunctions.jl.
Here is a visual tabulation of the equations in UniversalFunctions.jl for ease of reference.
To-do

[x] Implement Holtslag  SCF (phi) momentum and heat functions
[x] Implement Holtslag integrated-SCF (psi) momentum and heat functions
[x] Implement Holtslag volume-averaged integrated-SCF (Psi) momentum and heat functions
[x] Add Holtslag to docs
[x] Add Holtslag-specific asymptotic tests (phi equations diverge to infinity)

[x] I have read and checked the items on the review checklist.

Attached are locally created Holtslag plots using CLIMAParameters.jl commit dd38cdb1114e2dd7093cf75ab3f40958d61a41d7.
Holtslag_plots.zip

LGTM. Thanks @gdecker1.

bors r+


API for interacting with selection session / integration session

Selection sessions need an API for adding/removing/returning results back to their caller.
This call should be a form post from the browser as it will eventually redirect back to the caller
POST /api/selection/{sessionid}/return?integid={integid}
POST /api/selection/{sessionid}/add
BODY:
{
  "key": {
     "uuid": "UUID",
     "version": "1",
     "type": "a|p",
     "attachmentUuid": "?UUID",
     "folderId": "?folderId",
     "url": "?url"
  },
  "title": "Title of selection"
}

@doolse and @cathfitz confirmed working.


[Feature Request] Consider offering an official Docker image

Is your feature request related to a problem? Please describe.
Not directly linked to JMusicBot's code, no. Considering that there's a bunch of different Docker images available on DockerHub, the most popular of them having 50K downloads, but it being updated a year ago (!), having an official image for JMusicBot could provide a safer and up to date way for users to run the bot using Docker or Podman.
What is your ideal solution to the problem?

Select a good Java base image (ex.: eclipse-temurin:17-jre-focal);
Create a Dockerfile in this repository that catches the latest release and builds an image. Ex.:

FROM cycloid/github-cli as downloader
ARG GH_TOKEN
ENV GH_TOKEN=$GH_TOKEN
WORKDIR /app
RUN gh release download --pattern "JMusicBot-*.jar" --repo jagrosh/MusicBot
RUN mv JMusicBot-*.jar JMusicBot.jar

FROM eclipse-temurin:17-jre-focal
COPY --from=downloader /app/JMusicBot.jar /app/JMusicBot.jar
WORKDIR /app
ENTRYPOINT ["java", "-Dconfig=/app/config.txt", "-Dnogui=true", "-jar", "/app/JMusicBot.jar"]

Setup your DockerHub and GitHub secrets for this repository. The GitHub token doesn't require any permissions, only public access is necessary.
Use a GitHub Actions workflow to build the image periodically and as soon as a new release is published then push it to DockerHub for all architectures supported by the base image. You can include automatic vulnerability scanning for the image as a good measure. Ex.:

name: Build and push Docker image

on:
  schedule:
    - cron: '24 9 * * 6'
  release:
    types: [released]
  workflow_dispatch:

jobs:
  build:
    runs-on: ubuntu-latest
    steps:
      - name: Checkout Dockerfile
        id: checkout
        uses: actions/checkout@v2

      - name: Setup QEMU
        id: qemu
        uses: docker/setup-qemu-action@v1
        with:
          image: tonistiigi/binfmt:latest
          platforms: all

      - name: Setup Docker Buildx
        id: buildx
        uses: docker/setup-buildx-action@v1

      - name: Login to DockerHub
        id: login
        uses: docker/login-action@v1
        with:
          username: ${{ secrets.DOCKERHUB_USERNAME }}
          password: ${{ secrets.DOCKERHUB_TOKEN }}

      - name: Build and push Docker image
        id: build
        uses: docker/build-push-action@v2
        with:
          build-args: GH_TOKEN=${{ secrets.GH_TOKEN }}
          context: .
          file: ./Dockerfile
          platforms: linux/amd64,linux/arm64/v8,linux/arm/v7,linux/ppc64le,linux/s390x
          push: true
          tags: |
            jagrosh/jmusicbot:latest

      - name: Run Trivy vulnerability scanner
        uses: aquasecurity/trivy-action@master
        with:
          image-ref: 'docker.io/jagrosh/jmusicbot:latest'
          format: 'template'
          template<EMAIL_ADDRESS>          output: 'trivy-results.sarif'
          severity: 'CRITICAL,HIGH'

      - name: Upload Trivy scan results to GitHub Security tab
        uses: github/codeql-action/upload-sarif@v1
        with:
          sarif_file: 'trivy-results.sarif'

The image will be automatically published to DockerHub, so any user could run it as:

$ docker run --name jmusicbot -d -v /path/to/config.txt:/app/config.txt:ro \
-v /path/to/serversettings.json:/app/serversettings.json:ro --restart=always \
jagrosh/jmusicbot

If they want to use playlists, all they have to do is to set the playlistsFolder location in their config,txt relative to the /app path (ex.: playlistsFolder = "/app/playlists") and bind a local playlist folder to the bot container:

$ docker run --name jmusicbot -d -v /path/to/config.txt:/app/config.txt:ro \
-v /path/to/serversettings.json:/app/serversettings.json:ro \
-v /path/to/playlists:/app/playlists:ro --restart=always jagrosh/jmusicbot

Include the instructions on how to run the bot using Docker/Portainer in the documentation.

How would this feature be used?
Users wanting to host JMusicBot using Docker or Portainer would have easy of mind that the image they're running is secure. Additionally, users without much experience on server administration could easily host the bot with a single command.
Additional Info
All the steps mentioned above, with some changes, are being used on my repository (https://github.com/alexandreteles/jmusicbot_docker) to build and publish a Docker image (https://hub.docker.com/r/alexandreteles/jmusicbot) on those parameters. Please, go check it out if you have any questions on how the process works. Especial detail for the Security tab being populated with the relevant information about vulnerabilities in the image.
The code is under the WTFPL so, well, "Do What The F*ck You Want".
In any case, having it built and shipped by the project maintainer would make it much more trusted, especially if the build process is transparent and mentioned in the image description. Even if it should be just a bit of CTRL+C/CTRL+V for it to be setup, I could submit the necessary PRs. You would still need to setup the secrets, tho.
Checklist

[X] I have checked the documentation to make sure this feature doesn't already exist
[X] I have searched for similar feature requests
[X] I have confirmed that my requests is not on the list of things that will not be added
[X] I am running the latest version of the bot:

I think there might be simpler ways to do this, unless I'm mistaken.
Instead of building an image, pulling the jar and running the openjdk image would be way faster to setup (imho), or as an
alternative.
I created the following:
├── data
│   ├── config.txt
│   ├── JMusicBot-0.3.7.jar
│   ├── JMusicBot-current.jar -> JMusicBot-0.3.7.jar
│   └── serversettings.json
└── docker-compose.yml

And the docker-compose.yml goes like this :
---
version: "3"
services:
  musicbot:
    image: openjdk
    container_name: musicbot
    volumes:
      - ./data:/usr/src/myapp
    working_dir: /usr/src/myapp
    restart: unless-stopped
    entrypoint: java
    command: "-Dnogui=true -jar JMusicBot-current.jar"

Doing that allows the last openjdk version to be pulled and used, and when a new version is released, just replace the symlink in the data folder, then restart the container and everything runs smoothly.

That does work, but it prevents systems such as Watchtower from working, which automatically pull new image versions.

True, but as the bot notifies you already about a new version, I just DL the new jar, replace the symlink and restart the container, which seems reasonable compared to creating github jobs etc... for people who might not be as familiar with such processes :)

I think both approaches should be considered tbh. If people want automated updates with a current image, then your idea is better, if they don't care about updating manually, knowing that the bot updates might be quite rare, then maybe I should create a PR for documenting my method?

If there will be a docker image for this bot then I'm not sure why one would choose your method, using the bot image is probably easier to set up even if you don't care about updating it.

I do have Docker Hub Pro, which (I believe) allows me to configure an autobuild to run everytime this repo is updated. I am the developer of the docker "azamserver/pihole-doh" which has 1.5K pulls, and I would be glad to help out.

Any update on this issue? I'm holding off updating my bots till this is resolved.

@AzamServer The issue is on-hold, which means that the dev probably has an eye on it but isn't going to move with the changes too quickly. If you want, you can use the images I publish to Docker Hub (https://hub.docker.com/r/alexandreteles/jmusicbot), built and published thru my repository (https://github.com/alexandreteles/jmusicbot_docker).
Images are periodically rebuilt based on updates to the base image(s) or to this repository.

@alexandreteles Thanks for the help, and I will be using your docker!

@alexandreteles thanks so much for this!

Any update on this? Will there be an official image?


display->print lettering is dropping pixels

I saw something strange in the neighborhood but the Ghostbusters were busy so I'm reporting it here.
When using the print function on an ESP32 and a HUB75 64x64, some of the pixels are dropping out. This can be seen in the video at:
https://www.youtube.com/watch?v=Z6VJ1vh9FLc
The ESP32 is plugged in via a PCB:

In the video, watch the row of A's as they drop down the screen. The blue markers are solely there to show 32 lines below the top of the white time text (the white text will drop down in the video as well so the markers will also move.)
When the green row of letters A gets to the 32 row below the white time display, they start dropping out some of the columns (watch the left side of the second letter A. It also happens on # 7, 9 and 10 but the second one is easiest to spot.) When they get to around row 42 or so, they come back on.  Note that the green rectangle never drops out, showing the panel itself seems to be OK.
The dropouts have nothing to do with the fact that it's scrolling (I first saw them when just printing the time and lettering as stationary characters and was trying different things to test the issue.) They have nothing to do with the green bar (added just to make sure it was only letters affected) or the blue lines (added solely to verify that they were dropping at 32 rows below the top of the white text.) And also the green bar is intentionally out of step with the row of A's so that it shows the two aren't related as to the drops.
It ONLY drops the green pixels so if I make the A row all white, the pixels with the issue will be purple (where the red and blue still show.)
Further experiments show that if I set the time row to the following colors and leave the A row green, I get the following results.
255,0,0     OK
0,255,0     OK
0,0,255     OK
255,255,0   drops
255,0,255   drops (but not quite as much)
0,255,255   drops
255,255,255 drops
This first code is what's in the video:
#include <ESP32-HUB75-MatrixPanel-I2S-DMA.h>

#define R1_PIN 26
#define G1_PIN 27
#define B1_PIN 25
#define R2_PIN 12
#define G2_PIN 13
#define B2_PIN 14
#define A_PIN 23
#define B_PIN 19 // Changed from library default
#define C_PIN 5
#define D_PIN 17
#define E_PIN 32
#define LAT_PIN 4
#define OE_PIN 15
#define CLK_PIN 16
#define LDR 35

/*--------------------- MATRIX PANEL CONFIG -------------------------*/
#define PANEL_RES_X 64 // Number of pixels wide of each INDIVIDUAL panel module.
#define PANEL_RES_Y 64 // Number of pixels tall of each INDIVIDUAL panel module.
#define PANEL_CHAIN 1  // Total number of panels chained one to another

// Another way of creating config structure
// Custom pin mapping for all pins
HUB75_I2S_CFG::i2s_pins _pins = {
    R1_PIN, G1_PIN, B1_PIN, R2_PIN, G2_PIN, B2_PIN, A_PIN, B_PIN, C_PIN, D_PIN, E_PIN, LAT_PIN, OE_PIN, CLK_PIN};
HUB75_I2S_CFG mxconfig(
    64,                    // width
    64,                    // height
    1,                     // chain length
    _pins,                 // pin mapping
    HUB75_I2S_CFG::FM6126A // driver chip
);

MatrixPanel_I2S_DMA *dma_display = nullptr;

void setup()
{
  /************** SERIAL **************/
  Serial.begin(115200);
  TickType_t xLastWakeTime;
  const TickType_t xFrequency = 150;
  uint8_t i=0;
  uint8_t j=0;
  dma_display = new MatrixPanel_I2S_DMA(mxconfig);
  dma_display->begin();
  dma_display->setBrightness8(60); // 0-255

  for (;;)
  {
    dma_display->clearScreen();
    dma_display->setTextColor(dma_display->color565(255,255,255));
    dma_display->setTextSize(2);
    dma_display->setCursor(0, j);
    dma_display->print("12");
    dma_display->setCursor(28, j);
    dma_display->print("00");
    dma_display->setCursor(52, j);
    dma_display->setTextSize(2,1);
    dma_display->print("A");
    dma_display->setTextSize(1);
    dma_display->setTextColor(dma_display->color565(0,255,0));
    dma_display->setCursor(0, (i%47));
    dma_display->print("AAAAAAAAAA");
    dma_display->fillRect(0,(i+8)%56,64,8,dma_display->color565(0,255,0));
    dma_display->drawFastHLine(0,(32+j)%64,4,dma_display->color565(0,0,255));
    dma_display->drawFastHLine(60,(32+j)%64,4,dma_display->color565(0,0,255));
    i++;
    vTaskDelayUntil(&xLastWakeTime, xFrequency);
    if ((i%64)==0)
        j+=4;
  }
}

void loop()
{
}

Simpler code without all of the scrolling, etc. First the image. Note that two of the pixels are fainter than the rest but not dropped completely. They are solid but just much dimmer.

#include <ESP32-HUB75-MatrixPanel-I2S-DMA.h>

#define R1_PIN 26
#define G1_PIN 27
#define B1_PIN 25
#define R2_PIN 12
#define G2_PIN 13
#define B2_PIN 14
#define A_PIN 23
#define B_PIN 19 // Changed from library default
#define C_PIN 5
#define D_PIN 17
#define E_PIN 32
#define LAT_PIN 4
#define OE_PIN 15
#define CLK_PIN 16
#define LDR 35

/*--------------------- MATRIX PANEL CONFIG -------------------------*/
#define PANEL_RES_X 64 // Number of pixels wide of each INDIVIDUAL panel module.
#define PANEL_RES_Y 64 // Number of pixels tall of each INDIVIDUAL panel module.
#define PANEL_CHAIN 1  // Total number of panels chained one to another

// Another way of creating config structure
// Custom pin mapping for all pins
HUB75_I2S_CFG::i2s_pins _pins = {
    R1_PIN, G1_PIN, B1_PIN, R2_PIN, G2_PIN, B2_PIN, A_PIN, B_PIN, C_PIN, D_PIN, E_PIN, LAT_PIN, OE_PIN, CLK_PIN};
HUB75_I2S_CFG mxconfig(
    64,                    // width
    64,                    // height
    1,                     // chain length
    _pins,                 // pin mapping
    HUB75_I2S_CFG::FM6126A // driver chip
);

MatrixPanel_I2S_DMA *dma_display = nullptr;

void setup()
{
    /************** SERIAL **************/
    dma_display = new MatrixPanel_I2S_DMA(mxconfig);
    dma_display->begin();
    dma_display->setBrightness8(60); // 0-255
    dma_display->setTextColor(dma_display->color565(255, 255, 255));
    dma_display->setTextSize(2);
    dma_display->setCursor(0, 0);
    dma_display->print("12");
    dma_display->setCursor(28, 0);
    dma_display->print("0");
    dma_display->setCursor(52, 0);
    dma_display->setTextSize(2, 1);
    dma_display->print("A");
    dma_display->setTextSize(1);
    dma_display->setTextColor(dma_display->color565(0, 255, 0));
    dma_display->setCursor(0, 27);
    dma_display->print("AAAAAAAAAA");
}

void loop()
{
}

And then here's code with the top row in different colors. In this one, the very bottom-left pixel of the 9th A is actually flickering a bit (it looks like it's fully on in the picture.) I also added two yellow spots where pixels are missing here. If I make the whole upper row 255,0,255, then those two pixels come on but they flicker (the one on the second A is almost full brightness but on the last A, it's just barely visible.)

#include <ESP32-HUB75-MatrixPanel-I2S-DMA.h>

#define R1_PIN 26
#define G1_PIN 27
#define B1_PIN 25
#define R2_PIN 12
#define G2_PIN 13
#define B2_PIN 14
#define A_PIN 23
#define B_PIN 19 // Changed from library default
#define C_PIN 5
#define D_PIN 17
#define E_PIN 32
#define LAT_PIN 4
#define OE_PIN 15
#define CLK_PIN 16
#define LDR 35

/*--------------------- MATRIX PANEL CONFIG -------------------------*/
#define PANEL_RES_X 64 // Number of pixels wide of each INDIVIDUAL panel module.
#define PANEL_RES_Y 64 // Number of pixels tall of each INDIVIDUAL panel module.
#define PANEL_CHAIN 1  // Total number of panels chained one to another

// Another way of creating config structure
// Custom pin mapping for all pins
HUB75_I2S_CFG::i2s_pins _pins = {
    R1_PIN, G1_PIN, B1_PIN, R2_PIN, G2_PIN, B2_PIN, A_PIN, B_PIN, C_PIN, D_PIN, E_PIN, LAT_PIN, OE_PIN, CLK_PIN};
HUB75_I2S_CFG mxconfig(
    64,                    // width
    64,                    // height
    1,                     // chain length
    _pins,                 // pin mapping
    HUB75_I2S_CFG::FM6126A // driver chip
);

MatrixPanel_I2S_DMA *dma_display = nullptr;

void setup()
{
    /************** SERIAL **************/
    dma_display = new MatrixPanel_I2S_DMA(mxconfig);
    dma_display->begin();
    dma_display->setBrightness8(60); // 0-255
    dma_display->setTextColor(dma_display->color565(255, 255, 255));
    dma_display->setTextSize(2);
    dma_display->setCursor(0, 0);
    dma_display->print("12");
    dma_display->setCursor(28, 0);
    dma_display->setTextColor(dma_display->color565(0, 255, 255));
    dma_display->print("0");
    dma_display->setTextColor(dma_display->color565(255, 0, 255));
    dma_display->print("0");
    dma_display->setCursor(52, 0);
    dma_display->setTextSize(2, 1);
    dma_display->setTextColor(dma_display->color565(255, 255, 0));
    dma_display->print("A");
    dma_display->setTextSize(1);
    dma_display->setTextColor(dma_display->color565(0, 255, 0));
    dma_display->setCursor(0, 27);
    dma_display->print("AAAAAAAAAA");
}

void loop()
{
}

mxconfig.clkphase   ?

I tried it with both mxconfig.clkphase=false and with mxconfig.clkphase=true and no difference.

I'm closing this issue as it's probably a defective panel.


Add job enqueueing for domain scans

We already have refresh logic in the email check feature
czw., 18 sty 2024, 18:44 użytkownik msm-cert @.***>
napisał:

@.**** commented on this pull request.
Some CI checks are failing.
Also consider auto reload of the page?
In app/templates/check_running.html
https://github.com/CERT-Polska/mailgoose/pull/35#discussion_r1457788282:

@@ -0,0 +1,15 @@
+{% extends "custom_layout.html" %}

+{% block body %}

{% trans %}Domain analysis is running{% endtrans %}

{% trans %}Waiting for the domain analysis to finfish{% endtrans %}

maybe add an autmatic page refresh every 5s here (with javascript or http
header or http-equiv)?
—
Reply to this email directly, view it on GitHub
https://github.com/CERT-Polska/mailgoose/pull/35#pullrequestreview-1830250715,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAJNBK4MSSKURJRGSROD42LYPFNPVAVCNFSM6AAAAABCAU42G6VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTQMZQGI2TANZRGU
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>


Missing ServiceType definition

Bug description
The documentation on How to Use a Service suggests using the ServiceType type when referencing a service from another service:
import { ServiceOptions, ServiceType } from "@open-pioneer/runtime";

However, no such type exists (index.ts):
Module '"@open-pioneer/runtime"' has no exported member 'ServiceType'.ts(2305)

Logs
No response
Validations

[X] Read and follow our code of conduct
[X] Read the contributing guidelines
[X] Check that there isn't already a similar issue

Right, this is outdated. We'll fix it soon, for you should just import the needed type directly.


Snapshots metrics not showing completely - Missing snapshot data

When querying the exporter, I only get the data of five snapshots in the repository. The latest (which is nice), the three oldest, and then the latest snapshot of the second-oldest month. The repository is remote at backblaze, if that matters.
$ restic -r ... snapshots -c
ID        Time                 Host      Tags
-----------------------------------------------
[redacted]  2024-06-17 23:12:22  host1
[redacted]  2024-07-08 00:42:55  host1
[redacted]  2024-07-08 01:27:21  host1
[redacted]  2024-07-08 11:29:47  host1
[redacted]  2024-07-08 12:26:29  host1
[redacted]  2024-07-09 00:51:40  host1
[redacted]  2024-07-16 00:04:21  host1
[redacted]  2024-07-18 22:14:21  host1
[redacted]  2024-07-21 02:00:12  host1
[redacted]  2024-07-28 02:00:11  host1
[redacted]  2024-08-04 18:00:02  host1
[redacted]  2024-08-25 02:00:12  host1
[redacted]  2024-09-29 02:00:12  host1
[redacted]  2024-10-06 02:00:11  host1
[redacted]  2024-10-13 02:00:10  host1
[redacted]  2024-10-20 02:00:10  host1
[redacted]  2024-10-27 02:00:11  host1
[redacted]  2024-11-03 02:00:12  host1
[redacted]  2024-11-10 02:00:11  host1
-----------------------------------------------
19 snapshots

But the exporter only shows these five snapshots (I converted the unix timestamp to something readable in parentheses)
$ curl restic-exporter:8001
# HELP python_gc_objects_collected_total Objects collected during gc
# TYPE python_gc_objects_collected_total counter
python_gc_objects_collected_total{generation="0"} 213.0
python_gc_objects_collected_total{generation="1"} 66.0
python_gc_objects_collected_total{generation="2"} 0.0
# HELP python_gc_objects_uncollectable_total Uncollectable objects found during GC
# TYPE python_gc_objects_uncollectable_total counter
python_gc_objects_uncollectable_total{generation="0"} 0.0
python_gc_objects_uncollectable_total{generation="1"} 0.0
python_gc_objects_uncollectable_total{generation="2"} 0.0
# HELP python_gc_collections_total Number of times this generation was collected
# TYPE python_gc_collections_total counter
python_gc_collections_total{generation="0"} 33.0
python_gc_collections_total{generation="1"} 2.0
python_gc_collections_total{generation="2"} 0.0
# HELP python_info Python platform information
# TYPE python_info gauge
python_info{implementation="CPython",major="3",minor="12",patchlevel="1",version="3.12.1"} 1.0
# HELP process_virtual_memory_bytes Virtual memory size in bytes.
# TYPE process_virtual_memory_bytes gauge
process_virtual_memory_bytes 3.086336e+07
# HELP process_resident_memory_bytes Resident memory size in bytes.
# TYPE process_resident_memory_bytes gauge
process_resident_memory_bytes 2.0414464e+07
# HELP process_start_time_seconds Start time of the process since unix epoch in seconds.
# TYPE process_start_time_seconds gauge
process_start_time_seconds 1.73157723095e+09
# HELP process_cpu_seconds_total Total user and system CPU time spent in seconds.
# TYPE process_cpu_seconds_total counter
process_cpu_seconds_total 0.49
# HELP process_open_fds Number of open file descriptors.
# TYPE process_open_fds gauge
process_open_fds 6.0
# HELP process_max_fds Maximum number of open file descriptors.
# TYPE process_max_fds gauge
process_max_fds 1.048576e+06
# HELP restic_check_success Result of restic check operation in the repository
# TYPE restic_check_success gauge
restic_check_success 1.0
# HELP restic_locks_total Total number of locks in the repository
# TYPE restic_locks_total counter
restic_locks_total 0.0
# HELP restic_snapshots_total Total number of snapshots in the repository
# TYPE restic_snapshots_total counter
restic_snapshots_total 19.0
[...]
# HELP restic_backup_timestamp Timestamp of the last backup
# TYPE restic_backup_timestamp gauge
restic_backup_timestamp{client_hostname="host1",client_username="user",client_version="restic 0.16.4",snapshot_hash="[redacted]",snapshot_paths="",snapshot_tag="",snapshot_tags=""} 1.718651542e+09 (2024-06-17T23:12)
restic_backup_timestamp{client_hostname="host1",client_username="user",client_version="restic 0.16.4",snapshot_hash="[redacted]",snapshot_paths="",snapshot_tag="",snapshot_tags=""} 1.720394841e+09 (2024-07-08T01:27)
restic_backup_timestamp{client_hostname="host1",client_username="user",client_version="restic 0.16.4",snapshot_hash="[redacted]",snapshot_paths="",snapshot_tag="",snapshot_tags=""} 1.720434389e+09 (2024-07-08T12:26)
restic_backup_timestamp{client_hostname="host1",client_username="user",client_version="restic 0.16.4",snapshot_hash="[redacted]",snapshot_paths="",snapshot_tag="",snapshot_tags=""} 1.722124811e+09 (2024-07-28T02:00)
restic_backup_timestamp{client_hostname="host1",client_username="user",client_version="restic 0.16.4",snapshot_hash="[redacted]",snapshot_paths="",snapshot_tag="",snapshot_tags=""} 1.731200411e+09 (2024-11-10T02:00)
[...]
# HELP restic_scrape_duration_seconds Amount of time each scrape takes
# TYPE restic_scrape_duration_seconds gauge
restic_scrape_duration_seconds 58.340163707733154

I really would like to be able to see all snapshot data exported. Can you help me?

This might be due to the context deadline being exceeded. Is there a way to increase it?


GitHub action to push deployment to Azure

Experiencing problems deploying this to Azure. For more info refer to the issue raised at Azure/static-web-apps


How with Grad-CAM in my own model

Hi,
Thank you for sharing your work! I meet a problem when use Grad-CAM with my own model that have no FC classifier layer and no softmax layer. Would you please help me how to deal with it? Thank you very much!

Define the score for which you want to investigate the causality. In the original Grad-CAM, the score is arbitrary class logit before softmax is applied.
Extract the intermediate feature maps in the forward propagation.
Compute gradients of the score with respect to the feature maps.
Weight the feature maps by the gradient magnitudes.


update nix: 0.19 -> 0.22

Hi! Currently working on moving this to 0.23. Once that goes through I'll close this

Should be resolved through #74


Smart Contract Traceability: State Trace Design

Problem
Contract state trace information needs to be made available in the explorer.
Solution
Create a design to expose this information based on the requirements.
Alternatives
No response

Design completed in Figma.


JsonValidator should require a UriRetrieverInterface

The JsonValidator constructor should not require an instance of the UriRetriever, but the UriRetrieverInterface

A test failed, but I a not sure it is due to this PR.
Is it OK to merge it?

Ping @webmozart

Hi ! can you make the merge happen @webmozart ? thx !

Closing as inactive


add access to private sheets by passing accessToken to spreadSheetQueryParameters

add access to private sheets by passing accessToken to spreadSheetQueryParameters

This is awesome !
Thanks 😄

Published as 3.0.10


MaybeDisplay no longer necessary

The Display trait, has been moved from std::fmt to core::fmt and should now be compatible with no_std crates.
MaybeDisplay can now be removed for simplicity.

We still want to avoid having types implement Display trait in wasm to avoid size bloat.

Consider whether that optimization is worth the extra complexity. Remember, this is part of the substrate public interface and therefore user-facing.
It's usually a good idea to test optimizations. Tests may show that MaybeDisplay doesn't make a difference on wasm size.

I don't see the complexity of MaybeDisplay and as highlighted by @xlc Display introduces a lot of code bloat.
Given this, I close this issue.


Add 'bytes' and 'milliseconds' metrics to Stats package

ATM the stats package just collects event counts, which increment an internal counter by one whenever the event is logged. Ideally we need also to be able to count bytes transmitted through a channel and milliseconds paused. Then we can start to log things like total latency during a communication session, total bytes transmitted, total time spent waiting for a particular condition, which will all be very useful when it comes to performance tuning this beast.

Needed this to check a theory. Committed feature, so closing.


Database protection on CF stack

Related to https://github.com/PostHog/posthog.com/pull/1167 & this user report we definitely need to add some protections against accidental data deletion. Some suggestions:

Add database protection by default to the RDS instance.
Set a default PITR rolling backup for something low like 2-4 days. This will ensure there's something to rollback on just in case something happens and it won't add too much infrastructure expense.
We need a way to update the CF stack without recreating the DB. If this is definitely not possible for now, can we add a warning for when you're trying to recreate your stack?

We need a way to update the CF stack without recreating the DB.

This is incorrect. By default CF does not recreate the DB except when changing something that cannot be updated in place.
Some parameters which change this are:

PubliclyAccessible
MasterUsername
MasterUserPassword
Port
DBSubnetGroupName
... etc

See https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-rds-database-instance.html and search for Update requires: Replacement for a full list.
This means that as long as we don't change the template in incompatible ways AND users don't toggle stuff inbetween deploys no recreation no replacements should occur.
Should an error occur however there is a recovery path. I added a RestoreRDSSnapshotSelected parameter to the template, which allows restoring the database from a snapshot. During replacement/deletion we always make a snapshot so that should help.

can we add a warning for when you're trying to recreate your stack?

No. Cloudformation is extremely limited in that regard, we can't customize that. We can disable the deletion of the DB (which I think should also disable replacement) is the closest we can get.
However Cloudformation does itself warn about this by showing a list of changes that apply if you wait on the page for ~30 seconds.

Thanks for this @macobo! Yeah so re 1, I meant for when the DB needs to be recreated, we had a user to whom this happened, and it almost caused them to lose their entire dataset. We were indeed able to recover the data through the snapshot, found the RestoreRDSSnapshot param when going through the stack details, didn't know you added this recently, amazing stuff!


Help Wanted: User Guide

We need a proper User Guide for the extension that explains how to use Normal mode, Quick mode, how to create wallet, accounts, etc.
This should probably initially be added to the documentation repo, and later adopted for a video / CoinVault website.
This is something anyone could help with, doesn't require coding skills.

Hello @sondreb
Are there any resource reference for Block-core that can aid in this issue?
I would love to take this up.

Hi and welcome, sorry I didn't follow this up before now (just saw it).
I have made a basic guide here, that we could expand with more and improve text descriptions, and more recordings (I can make those).
If you have any suggestions to improvements of the text, feel free to either share here, or if you want to make pull requests, you can do it on our website repo.
https://www.blockcore.net/wallet/guide
This is the file: https://github.com/block-core/blockcore-website/blob/master/src/app/wallet/guide/guide.component.html

Thank you for responding @sondreb I'll get to it as soon as possible.


Merge tickets

Ben and Charley Allen's spouses want to cancel. Ben and Charlie will room together on the same ticket.

Process: add a button to the payment page to allow merging of one payer with another.
Use the people search mechanism to find a person to merge to.
Gather all related data for the record: payment, tourists
add that information to the new record.
User must be cancelled.


Complete spec for PlaceNode. Fixes #11

Added more functions to PlaceNode to complete the PLAC spec.
Added several new nodes; FormatNode, LatitudeNode, LongitudeNode, MapNode, NoteNode, PhoneticVariationNode, RomanizedVariationNode, TypeNode.
Added CastNodes which creates a slice of a more specific node type.
Added Phonetic and Romanized variation type constants.

This change is

Codecov Report

Merging #132 into master will increase coverage by 0.57%.
The diff coverage is 100%.

@@            Coverage Diff            @@
##           master    #132      +/-   ##
=========================================
+ Coverage   93.02%   93.6%   +0.57%
=========================================
  Files          28      36       +8
  Lines        1291    1407     +116
=========================================
+ Hits         1201    1317     +116
  Misses         78      78
  Partials       12      12

Impacted Files
Coverage Δ

tag.go
93.15% <ø> (ø)
:arrow_up:

map_node.go
100% <100%> (ø)

decoder.go
97.87% <100%> (+0.43%)
:arrow_up:

format_node.go
100% <100%> (ø)

latitude_node.go
100% <100%> (ø)

romanized_variation_node.go
100% <100%> (ø)

place_node.go
100% <100%> (ø)
:arrow_up:

type_node.go
100% <100%> (ø)

note_node.go
100% <100%> (ø)

phonetic_variation_node.go
100% <100%> (ø)

... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d3d8e0d...36946b4. Read the comment docs.


Revert "Fix goroutine leak when reconciling"

Description of your changes
This reverts commit 0927b1f82bb5ee29df4a647d4a985d874d73460e.
With the above-reverted change, we encountered issues creating and deleting some resources.

examples/cloudplatform/v1beta1/projectservice.yaml

    message: 'async create failed: failed to create the resource: [{0 Error when reading
      or editing Project Service : Parent context of request project/official-provider-testing/services
      canceled  []}]'

examples/cloudplatform/v1beta1/projectiammember.yaml

    message: 'create failed: async create failed: failed to create the resource: [{0
      Parent context of request iam-project-official-provider-testing modifyIamPolicy
      canceled  []}]'

examples/container/v1beta1/cluster.yaml

    message: 'create failed: async create failed: cannot get connection details: cannot
      get additional connection details: endpoint: not a string'

    message: 'async delete failed: failed to delete the resource: [{0 Error waiting
      for deleting GKE cluster: error while retrieving operation: unable to finish
      polling, context has been cancelled  []}]'

Fixes https://github.com/crossplane-contrib/provider-upjet-gcp/issues/611
I have:

[x] Read and followed Crossplane's contribution process.
[x] Run make reviewable to ensure this PR is ready for review.
[ ] Added backport release-x.y labels to auto-backport this PR if necessary.

How has this code been tested
The above failed tests have been tested manually and with uptest:

examples/cloudplatform/v1beta1/projectservice.yaml

NAME                                                          SYNCED   READY   EXTERNAL-NAME                                          AGE
projectservice.cloudplatform.gcp.upbound.io/project-service   True     True    official-provider-testing/clouddeploy.googleapis.com   2m8s

examples/cloudplatform/v1beta1/projectiammember.yaml

NAME                                                                SYNCED   READY   EXTERNAL-NAME
                                                    AGE
projectiammember.cloudplatform.gcp.upbound.io/project-iam-member2   True     True    official-provider-testing/roles/viewer/serviceAccount:official-provider-testing-noop@
official-provider-testing.iam.gserviceaccount.com   2m25s

examples/container/v1beta1/cluster.yaml

NAME                                       SYNCED   READY   EXTERNAL-NAME   AGE
cluster.container.gcp.upbound.io/primary   True     True    primary         8m30s

/test-examples="examples/container/v1beta1/cluster.yaml"

/test-examples="examples/cloudplatform/v1beta1/projectiammember.yaml"

/test-examples="examples/cloudplatform/v1beta1/projectservice.yaml"


[Bug]: LATERAL query doesnt work

What's wrong?
SELECT * from CTE left join LATERAL
(Select d,e,targetid  from T2 where (datetime > CTE .datetime - interval '1 Hour' and datetime <= CTE.datetime )
	    and targetid = CTE.targetId
            order by DateTime desc  Limit 1) t ON true;`

The 	line:   and targetid = CTE.targetId  makes the LATERAL to not work and return nothing
Also on the CTE if you add  at the end order by datetime nothing is returned

can you please check SELECT current_setting('enable_memoize');?

can you provide a self-contained reproduction of the issue you are seeing?

I started making some equivalent table but they also have partitions so its  bit more hard... will take a while to script all with generate series also.
In the mean time I found out that not using the CTE but another subquery makes it work.

Ok so now I narrowed it down to the more where conditions that sometime cause no result:

there are several issues with the char type in postgres, and probably shouldn't be used - are you also using it for the field type?

Which field type ?

the char field type, which you are doing a conversion to for comparison of tenant.

Yes the column in db is type "char"

But because when using "char" its selecting the correct partition I suspect the issue with "char" is only on Hydra

I would recommend creating tables with a different type (TEXT, VARCHAR, or whatever works other than CHAR) and try with that - you should not need to cast, and you should find it works a bit better.

CHAR types are an issue in heap as well as columnar.  they do not work like you would expect them to, and have issues with conversions.  tenant::text works because it strips the additional white spaces added in the CHAR type that are invisible to you.

I've been running Timescaledb for > 1 year with secondary dimension the same tenant "char" and had no issues so far but will surely switch on hydra where the storage is a lot smaller and regular char will not have an impact

I spend all day redoing the database with tenant column as char(1) instead of "char" and surprise the bug is the same:
This 2 work:

This 2 dont work:

your pictures are still showing tenant as a char.

Yes but now is standard char(1) not the legacy "char"

as noted, that will not fix the issue.

So you reccomend only text column?

So I narrowed it down to a duplicate row in event table that should not have existed due to PK constraint but still it did exist ..and thus I belive was also breaking the additional index

CREATE INDEX IF NOT EXISTS event_tenant_datetime_targetid_idx
ON public.event USING btree
(tenant ASC NULLS LAST, datetime DESC NULLS LAST, targetid ASC NULLS LAST);
And while this broken index was in place all those query were failing.

I removed the duplicate row. I re-made the index and now is working correctly.

So you believe the index causing no data return is related to vacuum?

Based on the (deleted) comment history it wasn't clear that this issue was still current. If you can provide a reproducible test case we would be happy to look into it.

Unfortunately all my attempts to create scripts that generate data to reproduce the issue were not successful. Only on my real db data this reproduces and I did the migration at least 7 times so is consistent.  Once I drop the index the results start coming and the excution plan no longer looks like this:
"[ { ""Plan"": { ""Node Type"": ""Index Scan"", ""Parallel Aware"": false, ""Async Capable"": false, ""Scan Direction"": ""Forward"", ""Index Name"": ""event_ten4_2023_42_tenant_datetime_targetid_idx"", ""Relation Name"": ""event_ten4_2023_42"", ""Alias"": ""event"", ""Actual Rows"": 0, ""Actual Loops"": 1, ""Index Cond"": ""((tenant = '4'::text) AND (datetime >= '2023-10-20 04:00:00'::timestamp without time zone) AND (datetime <= '2023-10-20 08:05:00'::timestamp without time zone) AND (targetid = 44722))"", ""Rows Removed by Index Recheck"": 0 }, ""Triggers"": [ ] } ]"


add iofs test cases bat file

Let's update this branch and any idea why Travis is failing?

Coverage decreased (-0.04%) to 79.604% when pulling 954e0afba64fd8a270edeb726c40bdf6f167980c on aravuri/iofs_bat into d48bd8fcacfc7ba47f4f2ccc42682d8f91fde629 on master.


Will redo.


install failure on 0.11.x

Just FYI, robotskirt currently refuses to build on Node 0.11.8.
Looks like hitting against some changes to v8 api.
e.g.
error: no type named 'Arguments' in namespace 'v8'
...
error: 'New' is a private member of 'v8::Persistent<v8::Context, v8::NonCopyablePersistentTraits<v8::Context> >'
...
In file included from ../src/robotskirt.cc:1:
../src/v8u.hpp:87:109: error: too few arguments to function call, expected 2, have 1
    throw v8::Persistent<v8::Value>::New(v8::Exception::RangeError(v8::String::New("Not enough arguments.")));

Full error output from build here: https://gist.github.com/timoxley/7478954

Now that node 0.12 is out, robotskirt is now broken on the latest stable node.

Basically I wanted to wait before Node.JS 0.12 was released, because the API changed very frequently between unstable versions, leading to confusion and me throwing the monitor out of the window.
Robotskirt is now deprecated, so I don't plan on updating it. node-hoedown is the successor and I'll probably switch to NAN on it soon.

Okie good to know. I'll update docpad-plugin-robotskirt to reflect that.


Prototype of encrypting ZFS dataset on EVE

new file introduced(vaultmgrzfs.go) to manage encrypted datasets on ZFS
device-steps.sh modified to get rid of P3 file system type check
storage-init.sh modified to use an unencrypted dataset persist/snapshots for containerd (it is now  a common problem to solve for both fscrypt and zfs - to encrypt containerd snapshots)

tests done:
upgrade to this image and checked that fscrypt vaults are intact
changed it to ZFS mode, rebooted, and checked that we have default datasets setup, and we have persist/vault marked for encryption, and we are no longer using fscrypt and instead using ZFS native encryption.
Signed-off-by: Hariharasubramanian C S<EMAIL_ADDRESS>

LGTM


Add missing tooltips, adjust statuses

Description
Changes proposed in this pull request:

add tooltips to the resources
adjust statuses of deployments, replica sets, stateful sets, daemon sets
simplify some statuses

/retest

/retest

/test pre-busola-integration-test-k3s

/test pre-busola-integration-test-k3s

/test pre-busola-integration-test-k3s

/retest

/retest

/retest


Preliminary work to add Swap Panes functionality (GH Issues 1000, 4922)

Summary of the Pull Request
Add functionality to swap a pane with an adjacent (Up/Down/Left/Right) neighbor.

References
This work potentially touches on: #1000 #2398 and #4922

PR Checklist

[x] Closes a component of #1000 (partially, comment), #4922 (partially, SwapPanes function is added but not hooked up, no detach functionality)
[x] CLA signed. If not, go over here and sign the CLA
[ ] Tests added/passed
[ ] Documentation updated. If checked, please file a pull request on our docs repo and link it here: #xxx
[x] Schema updated.
[ ] I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx

Detailed Description of the Pull Request / Additional comments
Its been a while since I've written C++ code, and it is my first time working on a Windows application. I hope that I have not made too many mistakes.
Work currently done:

Add boilerplate/infrastructure for argument parsing, hotkeys, event handling
Adds the MovePane function that finds the focused pane, and then tries to find
a pane that is visually adjacent to according to direction.
First pass at the SwapPanes function that swaps the tree location of two panes
First working version of helpers _FindFocusAndNeighbor and _FindNeighborFromFocus
that search the tree for the currently focused pane, and then climbs back up the tree
to try to find a sibling pane that is adjacent to it.
An `_IsAdjacent' function that tests whether two panes, given their relative offsets, are adjacent to each other according to the direction.

Next steps:

Once working these functions (_FindFocusAndNeighbor, etc) could be utilized to also solve #2398 by updating the NavigateFocus function.
Do we want default hotkeys for the new actions?

Validation Steps Performed
At this point, compilation and manual testing of functionality (with hotkeys) by creating panes, adding distinguishers to each pane, and then swapping them around to confirm they went to the right location.

I attempted to add some basic test cases for the move panes functionality, but getting them ran has so far eluded me.
In the visual studio test runner, and when trying to run \bin\x64\Debug\LocalTests_TerminalApp\TE.exe .\TerminalApp.LocalTests.dll both fail with messages akin to
Error: TAEF: [HRESULT: 0x80070002] Failed to create the test host process for out of process test execution. (A custom AppxManifest does not exist at [snip]\terminal\bin\x64\Debug\LocalTests_TerminalApp\TestHostAppXManifest.xml.)

The TestHostApp project also refuses to build for me, with a large number of errors about not being able to instantiate abstract Monarch and Peasant classes in RemotingTests.cpp

Yea, you'll definitely need to build TestHostApp first to be able to run the tests.

The TestHostApp project also refuses to build for me, with a large number of errors about not being able to instantiate abstract Monarch and Peasant classes in RemotingTests.cpp

That's definitely not expected, what errors exactly are you seeing? I could have swore that TestHostApp didn't depend on the RemotingTests at all...

Taking a look again, TestHostApp does build, and I did check that it does not depend on RemotingTests.cpp. I may have done a full solution build when I saw that problem? Regardless I just noticed the powershell Invoke-OpenConsoleTests that does seem to work for me so I'll try that out.

I was also seeing issues when compiling the UnitTests_Remoting module, and thought it was a configuration issue on my machine.
It seems to have been fixed by #10593, so if you sync your fork the compilation issues should go away.

Assuming this gets approved, I took a quick peak at doing #2398 as well, and the commit is rather simple https://github.com/Rosefield/terminal/commit/b6da1ead21b9aac2794d8ecec6fe11320e39d2fd.

@zadjii-msft What are the next steps to getting this merged? Thanks again for all of your time for reviewing.

At this point we need another signoff - @PankajBhojwani and @DHowett are fairly well versed in this part of the codebase, but it could be anyone on the team IMO.


Add a more creative headline to the MySolutions Page and style it

Describe an issue
The text of the Hero section of the MySolutions page doesn't look good, every line in that text looks very close.
Describe the solution you'd like
You need to come up with a creative headline for the Hero section of the MySolutions page and replace it with the existing headline and style it properly, play with letter spacing and line-height property to give proper spacing and you can also increase the width of the text container, there are so many ways to make it look good on different screens sizes.
Screenshots

Desktop (please complete the following information):

OS: macOS
Browser: Chrome

Hey! I would like to work on this, could you assign this to me?

@shikhar13012001 assigned to you.
Please share the new headline with me, before committing your changes.

hey kindly assign this issue to me, i will surely try to resolve it.

@shikhar13012001 are you working on this issue?

hey kindly assign this issue to me, i will surely try to resolve it.

Hello @Paawan9700 👋
Welcome to the CODINGSPACE community,🚀
If you have some creative headline for this page, you can share with us.

@Paawan9700 @shikhar13012001 any updates?

Hey @rishipurwar1, I would like to work on this as well.
The headlines I would suggest are:

Looking for solutions? You have come to the right page!
There you go. All the solutions you need are right here.
Take a look around. Here are your solutions.
Do help yourselves with all the solutions available.
Kindly suggest to me which you feel might be best, and I will start working on it.

@Harshavardhan7678 great headlines. But this is "my solutions" page means this page is only available to the user that submitted those solutions.
this line is good(Take a look around. Here are your solutions.) but improve it a little bit something like "All your hard work lives here. Take a look around. Here are your solutions." Try to improve it and make a pr.

Yes! add this line and first send me ss of different screen sizes.


Driver after Update from 0.14.3 to 1.0 not working on venosos3

Originally posted by @mr-manuel in https://github.com/Louisvdw/dbus-serialbattery/discussions/687#discussioncomment-6063425

Please open an issue as you should: Issues -> New issue -> Bug report.
There is a reason why we created issue templates.


Bulk Assessment Editor: input broken for entity kinds that are not applications

Description
The input box is hidden for licences and legal entity rel assessments
Waltz Version
No response
Steps to Reproduce

...
Expected Result
Should be able to bulk upload for entity kinds other than apps
Actual Result
No box for inputting data

Dupe of #7156


problem running the framework

Hello, i was trying to run the framework but it gives me those errors, i installed everything doing ./install.sh.

It seems Flask API can't access cert file on your system.
Could you verify that cert.pem and key.pem are exist in Osmedeus/core/certs folder.
If they exist just run python3 core/app.py to verify that you can run Flask API server properly.

i have the .pem files, i tried running the command but it gives me the same errors

Flask server still can't access your cert file for some reason(maybe because Osmedeus required python 3.6+).
But it looks like you're running on Debian which is not native support OS.
So could you verify that this is lines of code in Osmedeus/core/app.py is works?
# BASE_DIR = Path(os.path.dirname(os.path.abspath(__file__)))

# get core directory
BASE_DIR = Path('/your/absolutelypath/Osmedeus')

cert_path = BASE_DIR.joinpath('certs/cert.pem')
key_path = BASE_DIR.joinpath('certs/key.pem')

print(str(cert_path))
print(str(key_path))

See if you can get the right path of your *.pem file.

Due to Osmedeus upgraded into v2.0, this issue is no longer exist.
Please use the new version and send me a feedback.
Thank you.


Test changes for loading xlsx NECC

I cut the loading time by 3. Can you have a look:
https://github.com/nomad-hzb/nomad-chemical-energy/blob/eddff07ac525be5a4535f27e80f99fec397e6d7e/ce_necc/schema.py#L106
i also moved the parsing in the plugin, i will do this with the others too

We should definitely test more the time it needs to parse also when saving some notes eg in description

maybe have a checkbox which is checked after parsing?

I cut the loading time by 3. Can you have a look:
https://github.com/nomad-hzb/nomad-chemical-energy/blob/eddff07ac525be5a4535f27e80f99fec397e6d7e/ce_necc/schema.py#L106
i also moved the parsing in the plugin, i will do this with the others too

It is nice that it works but I don't understand why. Don't we need different header numbers for e.g. potentiometry and thermocouple? Because their headlines are defined in different rows in the excel?

https://github.com/nomad-hzb/nomad-chemical-energy/blob/7ee8dba16082311cb93eed845714dcb7bf53f6d4/ce_necc/schema.py#L138
There i reset the header and then in the call i dont pass the full data frame


Delete all PostgreSQL types when calling fresh (#765)

PR Info
Closes #765.
Adds
This PR adds the removal of all PostgreSQL types in the current schema when calling fresh on migrator.
Unfortunately, it was not possible to remove all types without for, because when calling names, incorrect SQL is compiled.
DROP TYPE “test””test1”

Hey @karpa4o4, I added a test for creating db enum on PostgreSQL

https://github.com/karpa4o4/sea-orm/compare/issue/765...billy1624:pr/864

Feel free to cherrypick :D

@billy1624, done

@billy1624, the fmt warnings fixed.

Thank you so much @karpa4o4


Update migration command to enable/disable transactions

This is a modified version of Beanie that includes an option to enable or disable transactions during migrations. Please see the motivation here (https://github.com/roman-right/beanie/discussions/827). To run a migration without a transaction, use the following command:
beanie migrate --no-use-transaction -uri 'mongodb://username:password@localhost' -db 'db' -p .

Please let me know if you'd like this feature in the upstream, and whether you require any changes to the PR. I will ensure to squash the commits and tidy things up.

Hi @mmabrouk ,
Thank you for the PR! It is useful.
Could you please add a test for this? To guarantee that everything works as expected after future changes.

Hi @mmabrouk ,
Thank you for the provided test suite. Yes, this is enough. I'll double check everything this week and will merge then. Thank you for the work!

Hi @mmabrouk ,
Thank you for your work! Merged. It will be published in the next 2 days


Search options

I found this treat in the plugin definition:
				/**
				 * Enable/disable the search in the dropdown
				 * Also limit displayed items (display: 20)
				 * and set minimum number of characters to search (min: 3)
				 */

It would be great to have this documented in the readme.

You can use the same options as available for the multiselect field: https://getkirby.com/docs/reference/panel/fields/multiselect

Oh really, cool! Thanks, I hadn't notice!


[Feature-2127][sql-schema] Fix the mysql version limited error

What is the purpose of the pull request
Fix the mysql version and datetime sql syntax limited error for 5.5x - 5.64.
Brief change log

Remove the CURRENT_TIMESTAMP in sql file.
Change the sql datetime(0) syntax to common syntax datetime, because mysql5.5x does not support the datetime(0) syntax, and datetime syntax is be in common use in mysql5.x and mysql8.x.
There is no need to set datetime in java code, because the default time was set up before.

Verify this pull request
This pull request is code cleanup without any test coverage.

good idea.
if remove default time set in sql file, but create_time and update_time is not set in java code in 1.0 version(you can check the code, I'm not remember clearly),  system will not work fine

good idea.
if remove default time set in sql file, but create_time and update_time is not set in java code in 1.0 version(you can check the code, I'm not remember clearly), system will not work fine

Thx for your review.
The java code has done the setter operation for create_time and update_time in previous version.
I've checked the java code and deployed the app to test this part.
When I do insert operation, it will generate create_time and update_time in db correctly.

good idea.
if remove default time set in sql file, but create_time and update_time is not set in java code in 1.0 version(you can check the code, I'm not remember clearly), system will not work fine

Thx for your review.
Do I need to check all the released version and fix that issue?

good idea.
if remove default time set in sql file, but create_time and update_time is not set in java code in 1.0 version(you can check the code, I'm not remember clearly), system will not work fine

Thx for your review.
I've checked all the active dev branch and fixed 2127 in those dev branch.

Codecov Report

Merging #2911 into dev will decrease coverage by 0.17%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##                dev    #2911      +/-   ##
============================================
- Coverage     39.57%   39.39%   -0.18%
+ Complexity     2711     2701      -10
============================================
  Files           435      435
  Lines         20116    20116
  Branches       2453     2453
============================================
- Hits           7960     7925      -35
- Misses        11400    11438      +38
+ Partials        756      753       -3

Impacted Files
Coverage Δ
Complexity Δ

...he/dolphinscheduler/common/enums/SqoopJobType.java
0.00% <0.00%> (-88.89%)
0.00% <0.00%> (-3.00%)

.../server/worker/processor/TaskExecuteProcessor.java
10.16% <0.00%> (-27.12%)
1.00% <0.00%> (-2.00%)

...nscheduler/server/entity/TaskExecutionContext.java
89.10% <0.00%> (-9.91%)
61.00% <0.00%> (-5.00%)

...inscheduler/common/task/sqoop/SqoopParameters.java
74.00% <0.00%> (-2.00%)
25.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 24c7f76...39528e9. Read the comment docs.

good job,  please contact<EMAIL_ADDRESS>or wechat(510570367) , when added, please tell me your github id, thx


add Sassy-Gridlover

Added Sassy-Gridlover to the 'Libraries and Mixins' list

Sassy-gridlover looks awesome!
Can you fix the merge conflict?

There you go! ;)

Thanks @hiulit! Cheers 😄  🍻  😃


1.16.2 breaks follow_redirect! in tests

After upgrading to 1.16.2 for some reason it loses the authentication when a follow_redirect! is performed and redirects back to the login screen. We are using the backdoor properly in the test environment as well. We fixed it by monkey patching follow_redirect to accept an as: user field.
Not sure if this was the intended effect with the new version.

Thanks for the report.
Can you provide some (redacted if needed) test code that was working on 1.16.1 and now fails? Alternately, can you provide a failing spec against clearance itself?

@mjankowski thanks for the response.
In the process of trying to recreate the issue I believe I have honed in on the exact problem. In 1.16.1 when you explicitly set config.cookie_domain it did not effect the test environment but with 1.16.2 unless the cookie domain is set to "example.com" for the test env the follow_redirect! fails.
You can see it fail here: https://github.com/navied/clearance_test
To make it pass all you have to do is reduce the clearance version to 1.16.1.

Thanks ... and yes, a local git bisect reveals this commit as the first one where your tests fail - https://github.com/thoughtbot/clearance/commit/cf1f03c1fc045048306de84995cd3ed06675ed31

I opened #822 and am also seeing the issue here on feature specs.

@navied I think you are correct.
In earlier versions when cookie_domain was set, we would actually set two cookies: a) a cookie without a domain, b) a cookie with a domain. I suspect that the first cookie without the domain was being set and was making the tests pass, despite the disconnect between the clearance cookie_domain setting and the "example.com" used by rack test.
In your example app, if you change the cookie domain line to:
config.cookie_domain = Rails.env.production? ? '.example.com' : nil
I suspect that would resolve the failures?

Yep, setting the cookie domain to nil would solve the issues. That explanation definitely make sense on what is probably going on. Not sure if it would make sense to ignore the cookie_domain config in test environments.

Great.
I'm going to close this with the conclusion that there's not actually a bug in 1.16.2, but that instead there's behavior from prior releases that was unknowingly relied upon, and that it can be resolved by making sure the domain name being set for cookies matches whatever is being used in specs.
If that's not the case, please re-open or otherwise report back.

Seems like it might be better to set the cookie domain for the test and dev environments in config/application.yml:
development:
  COOKIE_DOMAIN:    ".localhost:3000"

That seems like it would be easier to maintain down the road because it's crystal clear what's going on with each environment and you don't have to add a mysterious conditional to the clearance config file.


fix PlatformViewsController dispose do not call VirtualDisplayController dispose method

Is there an existing issue for this?

[X] I have searched the existing issues
[X] I have read the guide to filing a bug

Steps to reproduce
I am debugging a pure Flutter project that includes rtc live streaming. Refer to code address:
git@github.com:AgoraIO-Extensions/Agora-Flutter-SDK.git
When I pop out of the current page, the corresponding PlatformView destruction, VirtualDisplayController not call the dispose () method, which leads to increasing the number of AccessibilityDelegatingFrameLayout。
Expected results
when i pop up page, PlatformView disposed then also call VirtualDisplayController dispose method.
Actual results
VirtualDisplayController dispose method no called
Code sample
Code sample
          if (usesVirtualDisplay(viewId)) {
            final VirtualDisplayController vdController = vdControllers.get(viewId);
            final View embeddedView = vdController.getView();
            if (embeddedView != null) {
              contextToEmbeddedView.remove(embeddedView.getContext());
            }
            vdControllers.remove(viewId);
            **vdController.dispose();**
            return;
          }

Screenshots or Video

Screenshots / Video demonstration
[Upload media here]

Logs
Logs
[Paste your logs here]

Flutter Doctor output
Doctor output

┌─────────────────────────────────────────────────────────┐
│ A new version of Flutter is available!                  │
│                                                         │
│ To update to the latest version, run "flutter upgrade". │
└─────────────────────────────────────────────────────────┘
[✓] Flutter (Channel stable, 3.3.10, on macOS 13.1 22C65 darwin-arm, locale zh-Hans-CN)
    • Flutter version 3.3.10 on channel stable at /Users/salton/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 135454af32 (7 个月前), 2022-12-15 07:36:55 -0800
    • Engine revision 3316dd8728
    • Dart version 2.18.6
    • DevTools version 2.15.0
    • Pub download mirror https://pub.flutter-io.cn
    • Flutter download mirror https://storage.flutter-io.cn

[!] Android toolchain - develop for Android devices (Android SDK version 33.0.1)
    • Android SDK at /Users/salton/Library/Android/sdk
    ✗ cmdline-tools component is missing
      Run `path/to/sdkmanager --install "cmdline-tools;latest"`
      See https://developer.android.com/studio/command-line for more details.
    ✗ Android license status unknown.
      Run `flutter doctor --android-licenses` to accept the SDK licenses.
      See https://flutter.dev/docs/get-started/install/macos#android-setup for more details.

[✓] Xcode - develop for iOS and macOS (Xcode 14.2)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Build 14C18
    • CocoaPods version 1.11.3

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[!] Android Studio (version 2022.1)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    ✗ Unable to find bundled Java version.
    • Try updating or re-installing Android Studio.

[!] Android Studio (version 2022.2)
    • Android Studio at /Applications/Android Studio 2.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    ✗ Unable to find bundled Java version.
    • Try updating or re-installing Android Studio.

[✓] Android Studio (version 2021.3)
    • Android Studio at /Applications/Android Std.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.13+0-b1751.21-8125866)

[✓] Android Studio (version 2020.3)
    • Android Studio at /Users/salton/Downloads/历史文件202303/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.10+0-b96-7249189)

[✓] VS Code (version 1.66.2)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.40.0

[✓] Connected device (3 available)
    • M2011K2C (mobile) • 55c9f322 • android-arm64  • Android 12 (API 31)
    • macOS (desktop)   • macos    • darwin-arm64   • macOS 13.1 22C65 darwin-arm
    • Chrome (web)      • chrome   • web-javascript • Google Chrome 108.0.5359.94

[✓] HTTP Host Availability
    • All required HTTP hosts are available

! Doctor found issues in 3 categories.

There's an existing issue tracking this in https://github.com/flutter/flutter/issues/130870.
It also has a PR linked over here https://github.com/flutter/engine/pull/43807.
Closing from here as duplicate.
Thank you