Add a notes field to ImageWithDescription

@daseinkapital original comment
Notes distinct from description because description might be like "This utility pole has large holes in it that stop 2/3rds of the way up" but the note might be like "This is only found in the south of argentina"
so like the description tells you what you're specifically looking for (so you're not just like look at this utility pole and guess what makes it different) but then the note (which is highly optional) might actually tell you how common they are

@daseinkapital original comment
Notes distinct from description because description might be like "This utility pole has large holes in it that stop 2/3rds of the way up" but the note might be like "This is only found in the south of argentina"
so like the description tells you what you're specifically looking for (so you're not just like look at this utility pole and guess what makes it different) but then the note (which is highly optional) might actually tell you how common they are

I think this makes sense. I'd be almost tempted to make the notes field something like "Significance" where you can list out reasons why it's significant? Notes feels a little too broad if it's specifically going to be used in this context. And, while we are at it, do you think a single string field is enough for description? or should we make that a list of strings as well?

@daseinkapital original comment
Notes distinct from description because description might be like "This utility pole has large holes in it that stop 2/3rds of the way up" but the note might be like "This is only found in the south of argentina"
so like the description tells you what you're specifically looking for (so you're not just like look at this utility pole and guess what makes it different) but then the note (which is highly optional) might actually tell you how common they are

I think this makes sense. I'd be almost tempted to make the notes field something like "Significance" where you can list out reasons why it's significant? Notes feels a little too broad if it's specifically going to be used in this context. And, while we are at it, do you think a single string field is enough for description? or should we make that a list of strings as well?

Writing other comments, I'm also realizing that we are using description in the place of a notes field in a lot of other places. If we are changing the expectation here, we need to make sure we do it uniformly across the board.

@daseinkapital original comment
Notes distinct from description because description might be like "This utility pole has large holes in it that stop 2/3rds of the way up" but the note might be like "This is only found in the south of argentina"
so like the description tells you what you're specifically looking for (so you're not just like look at this utility pole and guess what makes it different) but then the note (which is highly optional) might actually tell you how common they are

I think this makes sense. I'd be almost tempted to make the notes field something like "Significance" where you can list out reasons why it's significant? Notes feels a little too broad if it's specifically going to be used in this context. And, while we are at it, do you think a single string field is enough for description? or should we make that a list of strings as well?

Writing other comments, I'm also realizing that we are using description in the place of a notes field in a lot of other places. If we are changing the expectation here, we need to make sure we do it uniformly across the board.

I'm down with making it more explicit with "Significance" or "Meta", but I would agree notes vs description are very similar. Maybe we remove the term "notes" across the board because it is very broad.

I had Notes at the top level just so there's a place to put extraneous information that doesn't really fit neatly into any category. We can remove it if you want

I had Notes at the top level just so there's a place to put extraneous information that doesn't really fit neatly into any category. We can remove it if you want

If we want to keep this type of information, i could rename is "extra info" or something like that? I agree that Notes in general is probably too broad

In regards to the ImageWithDescription (thinking about renaming this Tip on the backend, won't impact front end):
we could keep description as a "what does this thing look like"
and then significance could be "where is this thing, why do you care, etc"?
Or do you think we can merge all of that into one list of strings? probably depends whether or not you plan on representing description and significance separately in the UI.

I'm fine with that specific notes staying because it is more of a textual
catch all (although I do feel that some of the current notes we have for
Argentina could be turned into ImageWithDescription and classified
somewhere)
On Wed, Sep 28, 2022, 10:04 PM Ryan Grant @.***> wrote:

I had Notes at the top level just so there's a place to put extraneous
information that doesn't really fit neatly into any category. We can remove
it if you want
—
Reply to this email directly, view it on GitHub
https://github.com/GeoguessrTools/calico-cut-pants/issues/3#issuecomment-1261650528,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ADXGV33KSMI2K5VYXXZMYZTWAT2LLANCNFSM6AAAAAAQXGXKVA
.
You are receiving this because you were mentioned.Message ID:
@.***>

Hmmm uncertain. I'd say leave them separate so there's an option to
separate them because it really shouldn't be more than a short sentence for
each of them and I think it's a little deceptive in nature to say it's a
list when you know the list should only be one or two lines long.
Andrew Samuelson
Virginia Tech Class of 2018 | Industrial & Systems Engineering - Statistics
Minor
Institute of Industrial and Systems Engineers Virginia Tech Student Chapter
(VT IISE) | Treasurer
Cell:<PHONE_NUMBER> | Email: @.***
On Wed, Sep 28, 2022 at 10:10 PM Ryan Grant @.***>
wrote:

In regards to the ImageWithDescription (thinking about renaming this Tip
on the backend, won't impact front end):
we could keep description as a "what does this thing look like"
and then significance could be "where is this thing, why do you care, etc"?
Or do you think we can merge all of that into one list of strings?
probably depends whether or not you plan on representing description and
significance separately in the UI.
—
Reply to this email directly, view it on GitHub
https://github.com/GeoguessrTools/calico-cut-pants/issues/3#issuecomment-1261653456,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ADXGV3474JMHT4JZXXIE4TDWAT3ADANCNFSM6AAAAAAQXGXKVA
.
You are receiving this because you were mentioned.Message ID:
@.***>

possibly. I was just pulling off how the reference reddit post was organized. Ok i'll leave it for now and if we decide later we don't need it we just yeet it

I'm fine with that specific notes staying because it is more of a textual catch all (although I do feel that some of the current notes we have for Argentina could be turned into ImageWithDescription and classified somewhere)
…
On Wed, Sep 28, 2022, 10:04 PM Ryan Grant @.> wrote: I had Notes at the top level just so there's a place to put extraneous information that doesn't really fit neatly into any category. We can remove it if you want — Reply to this email directly, view it on GitHub <#3 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADXGV33KSMI2K5VYXXZMYZTWAT2LLANCNFSM6AAAAAAQXGXKVA . You are receiving this because you were mentioned.Message ID: @.>

possibly. I was just pulling off how the reference reddit post was organized. Ok i'll leave it for now and if we decide later we don't need it we just yeet it

Hmmm uncertain. I'd say leave them separate so there's an option to separate them because it really shouldn't be more than a short sentence for each of them and I think it's a little deceptive in nature to say it's a list when you know the list should only be one or two lines long. -- Andrew Samuelson Virginia Tech Class of 2018 | Industrial & Systems Engineering - Statistics Minor Institute of Industrial and Systems Engineers Virginia Tech Student Chapter (VT IISE) | Treasurer Cell:<PHONE_NUMBER> | Email: @.***
…
On Wed, Sep 28, 2022 at 10:10 PM Ryan Grant @.> wrote: In regards to the ImageWithDescription (thinking about renaming this Tip on the backend, won't impact front end): we could keep description as a "what does this thing look like" and then significance could be "where is this thing, why do you care, etc"? Or do you think we can merge all of that into one list of strings? probably depends whether or not you plan on representing description and significance separately in the UI. — Reply to this email directly, view it on GitHub <#3 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADXGV3474JMHT4JZXXIE4TDWAT3ADANCNFSM6AAAAAAQXGXKVA . You are receiving this because you were mentioned.Message ID: @.>

Actually, thinking about it, i do still think we need some sort of identifier, almost like a dedicated title field. In the maps one, I realized we probably want to title each city map (or whatever map) so we can specifically display that as a title. I was kind of overloading description as a thing that could be a title and could also be a description.
Hm, let me whip something up and I'll have you look at it.

As per meeting discussion:
Changed ImageWithDescription to Hint with optional ImageUrl
Added RegionSpecificity to Hint
Added CountrySpecificity to Hint
Added Frequency to Hint
Added Identifier to Hint
Nixed notes idea
Added Significance


[Slider] Not working in Next.js when reactStrictMode is enabled

Bug report
Hello,
I copy basic example with stitches from official docs.
I use it in Next.js app with enabled react strict mode in next.config.js
Current Behavior
Server warning Did not expect server HTML to contain a <span> in <span>...
Can't change value with thumb.
Expected behavior
When reactStrictMode: false it work as expected.
Reproducible example
StackBlitz

Hi @domosedov,
That StackBlitz example you linked to seems to work for me.
Am I missing something?

Hi @domosedov,
That StackBlitz example you linked to seems to work for me.
Am I missing something?

Hello, try with reactStrictMode: true in next.config.js

Ha thanks, I assumed it was already the case as you linked as a reproducible example.
I can see the issue now seems to be a focus issue, as the focus gets lost. 🙏


Add  hint for unknown node type

fix for https://github.com/KaotoIO/kaoto-next/issues/803

I'd rephrase the warning message a bit:
Unknow node type
The configuration for an unknown node cannot be changed in the configuration form. Please switch to the source code and correct the node type. Another option is to replace the step in the graphical editor but in that case you will probably lose the existing configuration.

Updated - moved to separate file, updated the Hint to Alert, with variant warning. Also changed the message.
With updates:

you did not change the headline, did you?

you did not change the headline, did you?

Missed that the headline was also changed - Updated.


Display blue text for a link, in SimpleTable component

Issue: https://github.com/ManageIQ/manageiq-ui-classic/issues/6572
This PR fixes the issue with the link to Pod which did not look like a link, in the Build Instances table in textual summary of selected Container Build.
Before:

After:

@epwinchell : what do you think about the color of the link? Blue is correct?

@epwinchell : what do you think about the color of the link? Blue is correct?

@martinpovolny Perfect

:tada: This PR is included in version 0.11.60 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


How to set a custom event queue?

Hello,
I was trying to convert my C wayland client application to Zig, and one feature I used there was creating a custom event queue to handle wayland events.
Like so:
struct wl_display* display;
struct wl_event_queue* event_queue;

...

event_queue = wl_display_create_queue(display);
wl_proxy_set_queue((struct wl_proxy *) display, event_queue);

...

wl_display_roundtrip_queue(display, event_queue);

...

while (0 > wl_display_prepare_read_queue(display, event_queue)) {
  wl_display_dispatch_queue_pending(display, event_queue);
}

I have the following code currently:
const display: ?*wl.Display = wl.Display.connect(null);

...

const event_queue: ?*wl.EventQueue = display.createQueue();

...

display.roundtripQueue(event_queue);

which yields "only" 2 dispatched events instead of the 42 I expected when using the default queue. And afterwards the compositor reference is null, so I assume the registryListener wasn't called.
I would have set the queue on the display object but found no reference to it in the zig-wayland package. I then assumed it automatically sets the queue to the display it was created with, but now I don't really know how to proceed.
So my question: Am I missing something obvious? Or am I holding it wrong? My reference C project seems to work so I hoped I had a reliable orientation, but now I am questioning that as well. :sweat_smile: Let me know, if you need additional information from me.
Thank you anyway for the project. Looking at the code it must have been no easy feat to write a package for a somewhat generated API (looking at the scanner code and such). :green_heart:

Just a heads-up. As far as I can tell with wayland-1.22 this is will segfault, as it uses an incorrect mental model of display/proxy/etc.
This was explained here https://gitlab.freedesktop.org/wayland/wayland/-/issues/391#note_1978401
tl;dr: wl_display is a connection to a server, creating and setting a new event_queue from the display to the display object will not work. The correct order of operation is:

Create a display connection,
create a display_wrapper (using wl_create_proxy_wrapper(display)),
set the queue to this wrapper, and
operate on the queue.

See https://gitlab.freedesktop.org/wayland/wayland/-/blob/6d3334657180f3663b8d83636f4d1bc2097492d2/src/wayland-client.c#L1390 for an example.


Add files via upload

Circular Link list added
Description of Change

Checklist

[ ] Added description of change
[ ] Added file name matches File name guidelines
[ ] Added tests and example, test must pass
[ ] Added documentation so that the program is self-explanatory and educational - Doxygen guidelines
[ ] Relevant documentation/comments is changed or added
[ ] PR title follows semantic commit guidelines
[ ] Search previous suggestions before making a new one, as yours may be a duplicate.
[ ] I acknowledge that all my contributions will be made under the project's license.

Notes:

Circular Linked List


ABC-244: fix team invite link handling

Summary
The hash and data parameters, being null, were cast to strings
downstream in mattermost-redux as part of buildQueryString, resulting
in a value of "null" being passed up instead of the expected empty
string. The server correctly rejected the hash as invalid.
This change copies the more correct handling from the sign up controller.
Perhaps an even better solution would be to update buildQueryString in
mattermost-redux to check null parameters and send up empty strings
automatically, however that's probably not the change we want near the
end of a release. I'll propose the change in master separately
instead.
Ticket Link
https://mattermost.atlassian.net/browse/ABC-244
Checklist

[x] Ran make check-style to check for style errors (required for all pull requests)
[x] Ran make test to ensure unit and component tests passed

Forgot @hmhealey was off this afternoon, so I've flipped the review over to @MusikPolice :)


Build error

https://github.com/ocicl/stripe/actions/runs/11092034481/job/30816555113#step:2:42775

Will look into this, thanks!

This commit should fix this.

Looks like it passed, thanks for flagging!


vector should be used in tilelink mask_

After reading the codes and comments in tilelink.hpp, it seems like the program only uses the first bit in mask_ , so I think the type of mask_ should be vector.

The implementation of std::vector<bool> depends on the compiler and platform. Many implementations pack/unpack the bits into an underlying integer storage, which imposes a performance penalty for a relatively minor reduction in runtime memory usage. We've opted for the simpler vector<uint8_t> implementation here for to keep performance predictable, and the memory overhead should be minor since TileLink mask values are relatively small.


feat(build): use ngm build over custom solution

hey
here is the simple method to build AoT compatible + bundles version of any package with one simple command ;)
just checkout and do npm i
you will see in dist folder version ready for publishing

BTW A lot of files can be removed from project
Did not touched them for now, let us chat first

Root tsconfig can be removed

so... how to use it

npm run build (runs ngm build -p src) - and check dist folder
you have aot compiled version + umd bundles
npm run build -- -w (or ngm build -p src -w)
ngm publish -p src will run test, e2e, prepublish build and publish...


New topic: metadata

Files from Tim. The .png files need to be added as images in the text, I know how to do that in MD but where (i.e. in which folder) should I put these images?
@chartgerink do we have a procedure for images?

Update: what I've done, looking at previous examples, is put the .png files in the Public folder and I also saw that Tim had already entered the code of where to put the images in the .qmd file, also using the Public folder.
Since I made a few changes to the text, I would also like to get Tim's approval before we merge. And I'd like it if @Jolien-S and @jhrudey were able to review this PR.
How can we add Tim as a contributor?

A final comment here: the lists starting with "-" don't seem to render correctly on the preview. What's going on?

For adding Tim as a contributor, do you mean to this list or on the repo specifically? In any case, we would need their GitHub handle 👍
Overall, I would suggest to call the topic Metadata instead of data documentation, because it is more about metadata in reality. As a result, I wonder whether some of the content needs to be included directly, or are their own topics and should be linked to.

I don't think Tim has a Github handle - that's why he sent this to me. Can we add him somewhere manually?
How would Documentation and metadata do instead as a topic title?

@Elisa-on-GitHub I've been thinking this over more and this topic is too extensive, I am afraid, in its current form.  It covers multiple topics, so we would have to split this into subtopics for it to be manageable. For example, the "Persistent identifier" topic is reused in this topic, which is reserved for pathways. These standards have not been super clear, so my apologies for that ambiguity.
I suggest we either:

Merge as-is and I will work on ensuring all the topics get split accordingly
We rework the content jointly to split the page into its relevant, standalone subtopics

If there is a need for a page that overarches multiple topics, that might indicate the need for a pathway around data documentation.

@Elisa-on-GitHub I've been thinking this over more and this topic is too extensive, I am afraid, in its current form. It covers multiple topics, so we would have to split this into subtopics for it to be manageable. For example, the "Persistent identifier" topic is reused in this topic, which is reserved for pathways. These standards have not been super clear, so my apologies for that ambiguity.
I suggest we either:
1. Merge as-is and I will work on ensuring all the topics get split accordingly

2. We rework the content jointly to split the page into its relevant, standalone subtopics

If there is a need for a page that overarches multiple topics, that might indicate the need for a pathway around data documentation.

@chartgerink thanks - I've only just come back from my holiday and I'm still not fully back up to speed. I did go over this PR with Tim (who wrote the page) yesterday, to see where things are standing, and we briefly discussed the ontologies/controlled vocabularies discussion: he is open to writing a separate topic about that. So I think we can also pitch for this to become two separate topic pages.
Should we consider making this PR a draft? Or close the PR, do some work on my patch to split the page into two, and create two new PRs?

@Elisa-on-GitHub great to hear 😊 No worries about timing – all in due time.
I would recommend closing this pull request and opening a pull request per topic. That way the discussions can be contained. Does that sound okay?

@chartgerink agreed. I will close the PR with this comment.


integration with application framework (quasar)

Is there a possibility to create an example which works with Quasar Framework? For example dragging from one qlist to another qlist or from qtree to another qtree (with model synchronization)? This library looks great (I love the concept of datasets), but I wonder if it is suitable for real world integration with application frameworks. Here is quasar list component:
https://quasar-framework.org/components/lists-and-list-items.html

well, backward compatibility is overrated. this is not a library with global reach, but IMHO it could be if you take a leap of faith and go where vue is going :-) What I mean, is that Vue encourages to not think in terms of DOM elements (which it virtualizes btw), but in terms of model changes, where those changes causes simple DOM updates only in places where it is necessary and nowhere else. Vue has a concept of components, so communication between components is realized preferably one-way from parent to child by references and from child to parent by simple events. Communication between sibling componenst is in Vue realized either by global events bus (for thos who couldn't live without events) or ... by VueX and state changes. Those state changes is a preferred architecture of the Vue ideology.
You are writing something amazing, which is embedded in Vue ecosystem, so you shouldn't prefer the "old" way of thinking and encourage to work with dnd omitting declared model structures. That's why your work is ingenious, because now, you can allow the sibling communication between components with dnd library. This communication between components is a model also. As for now, your library is able to detect which data model is associated with dragged/dropped DOM element which is great - but - in the end - you should even communicate those model changes with specific Vue components. But - as for now, let's just keep the model changes/updates/inserts/removals and the rest will architecturally show itself.
What to do next? Well, I will be available after 10th february. I think that it could be helpful to have another git repository "vue-draggable-example-quasar" with quasar project in which we could have some use cases:

3 q-lists
2 q-trees
1 q-list for "clipboard" for temporary keeping the items
And in this use case, it should be implemented the dnd scenarios of exchanging items between all those components. I could help with that - after 10th february. It would be awesome to have on the component level something which makes this component draggable or droppable.

In the meantime, I've started working on improvements regarding this.
It's work in progress, but take a look at updated codesandbox demo.
Beta version of the library<EMAIL_ADDRESS>is published with new events introduced.
Attach custom events on group elements and you can write your own logic to work with model data.
@added="added($event, group)"
@removed="removed($event, group)"
@reordered="reordered($event, group)"

Every event has detail property formed like this
{
  ids: array, // array of ids
  index: number // index of next element in dropped group
}

I've also created vue-draggable-with-quasar repo so you can try this also locally.
https://github.com/nikolasp/vue-draggable-with-quasar
I'm open for all suggestions regarding this implementation.

Released v2.0.0 🎉

@nikolasp could you elaborate on how you integrate with quasar?
I'm on the latest quasar version and it no longer uses a main.js file. External libraries are pulled in with plugins and yours doesn't seem to work when I create a plugin for it.
My plugin (registered in quasar.conf.js):
import VueDraggable from 'vue-draggable'

export default ({ Vue }) => {
  Vue.use(VueDraggable)
}

I then copy/pasted everything from Hello.vue in your link: https://codesandbox.io/s/p9vzv6qko7
Am I missing a step?

@nikolasp Apologies for resurrecting this thread, but digging around only finds this one year old post. And I have the same question as altShiftDev did up there.
Do you mind elaborating? Because I can't for the life of me manage to get the two libraries to behave together.

Hi @missionz3r0 , @altShiftDev
No need for apology. Thanks for the feedback.
I've updated old repo with new Quasar version and integrated vue-draggable so please take a look at that.
https://github.com/nikolasp/vue-draggable-with-quasar
STEPS:
VueDraggable plugin is registered through separate boot file (https://quasar.dev/quasar-cli/cli-documentation/boot-files#Introduction), which I have created with quasar-cli command quasar new boot vue-draggable.
Created boot file vue-draggable.js should look like this
import VueDraggable from 'vue-draggable'

export default async ({ Vue }) => {
  Vue.use(VueDraggable)
}

The last step is updating of quasar.conf.js boot section
    boot: [
      'vue-draggable'
    ],

And that's it... 🎉
PS. Don't forget to install quasar list components before usage...
For our example I just used these:
components: [
        'QList',
        'QItem',
        'QItemSection',
        'QItemLabel'
],
...

well, I feel like a dunce now. I'd gotten everything except explicitly defining the components in quasar.conf.js. That's what I was missing, and thank you for taking the time to update this issue.


Inappropriate substitution of $DIR and $WORKSPACE

I'm trying to run tests on https://github.com/PyO3/pyo3 and running into some issues with output mismatch. This is with trybuild = "=1.0.49". Note that the URL https://github.com/PyO3/pyo3/issues/1632 is replaced with https://github.com$DIR$WORKSPACE/issues/1632.
EXPECTED:
┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈
error: Python functions cannot have generic type parameters
 --> tests/ui/invalid_pyfunctions.rs:4:21
  |
4 | fn generic_function<T>(value: T) {}
  |                     ^

error: Python functions cannot have `impl Trait` arguments
 --> tests/ui/invalid_pyfunctions.rs:7:36
  |
7 | fn impl_trait_function(impl_trait: impl AsRef<PyAny>) {}
  |                                    ^^^^

error: `async fn` is not yet supported for Python functions.

Additional crates such as `pyo3-asyncio` can be used to integrate async Rust and Python. For more information, see https://github.com/PyO3/pyo3/issues/1632
  --> tests/ui/invalid_pyfunctions.rs:10:1
   |
10 | async fn async_function() {}
   | ^^^^^
┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈

ACTUAL OUTPUT:
┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈
error: Python functions cannot have generic type parameters
 --> tests/ui/invalid_pyfunctions.rs:4:21
  |
4 | fn generic_function<T>(value: T) {}
  |                     ^

error: Python functions cannot have `impl Trait` arguments
 --> tests/ui/invalid_pyfunctions.rs:7:36
  |
7 | fn impl_trait_function(impl_trait: impl AsRef<PyAny>) {}
  |                                    ^^^^

error: `async fn` is not yet supported for Python functions.

Additional crates such as `pyo3-asyncio` can be used to integrate async Rust and Python. For more information, see https://github.com$DIR$WORKSPACE/issues/1632
  --> tests/ui/invalid_pyfunctions.rs:10:1
   |
10 | async fn async_function() {}
   | ^^^^^
┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈

Maybe a solution for this would be to recognize the <protocol>:// in the URL and skip over it?

Ooops this is a result of me developing in a Docker container with the code mounted at /pyo3 - confirmed by making a test for this repo with a similar URL and the code mounted at /trybuild. I can fix that test by mounting to a different location that does not conflict with the URL like that.

I published a fix in 1.0.50 so that it should work even at /pyo3.


docs: Menu on the left side can be expanded by clicking on arrow buttons

Description
This PR allows expanding folded menus in the documentation site without having to visit intermediate pages.
Checklist

[x] The title of my PR starts with a Conventional Commit prefix (fix:, feat:, docs: etc).
[x] I have read the Contributor Guide and followed the process outlined for submitting PRs.
[-] I have updated/added tests for ALL new/updated/fixed functionality.
[-] I have updated/added relevant documentation in docs and added dartdoc comments with ///.
[-] I have updated/added relevant examples in examples.

Breaking Change

[-] Yes, this is a breaking change.
[x] No, this is not a breaking change.

Related Issues
Closes #1774

@st-pasha could it be this PR that removed the menu?

possible, i'll take a look


1431 - Kids With the Greatest Number of Candies

Description of the Problem
Given the array candies and the integer extraCandies, where candies[i] represents the number of candies that the ith kid has.
For each kid check if there is a way to distribute extraCandies among the kids such that he or she can have the greatest number of candies among them. Notice that multiple kids can have the greatest number of candies.
Example 1:
**Input**: candies = [2,3,5,1,3], extraCandies = 3
**Output**: [true,true,true,false,true]
**Explanation**:
Kid 1 has 2 candies and if he or she receives all extra candies (3) will have 5 candies --- the greatest number of candies among the kids.
Kid 2 has 3 candies and if he or she receives at least 2 extra candies will have the greatest number of candies among the kids.
Kid 3 has 5 candies and this is already the greatest number of candies among the kids.
Kid 4 has 1 candy and even if he or she receives all extra candies will only have 4 candies.
Kid 5 has 3 candies and if he or she receives at least 2 extra candies will have the greatest number of candies among the kids.

Example 2:
**Input**: candies = [4,2,1,1,2], extraCandies = 1
**Output**: [true,false,false,false,false]
**Explanation**: There is only 1 extra candy, therefore only kid 1 will have the greatest number of candies among the kids regardless of who takes the extra candy.

Example 3:
**Input**: candies = [12,1,12], extraCandies = 10
**Output**: [true,false,true]

Code
class Solution:
    def kidsWithCandies(self, candies: List[int], extraCandies: int) -> List[bool]:

##Constraints:

2 <= candies.length <= 100
1 <= candies[i] <= 100
1 <= extraCandies <= 50

Link To The LeetCode Problem
Kids With the Greatest Number of Candies

@vJechsmayr Please assign this issue to me. I am happy to contribute.


Ctrl-C doesn't work on non latin keyboard layout

Bug description

I noticed a couple of other equally annoying bugs. The first is when the application is launched on marcos Ventura beta 14.0 (23A5301h), the fingerprint authorization window becomes inactive. The second problem is that if I am on the Russian keyboard layout, the keyboard shortcuts (example: Control+Z/x/c/v) do not work

Fingerprint window is managed by macOS itself so I think it will be fixed by Apple later.
Keyboard shortcuts should work out of the box.
Could you check what happen with :
showkey -a

Control+Z(Я)/D(В) not worked at russian layout
root@nextcloud:~# showkey -a
Press any keys - Ctrl-D will terminate this program
^Z       26 0032 0x1a
^X       24 0030 0x18
^C        3 0003 0x03
^V       22 0026 0x16
^D        4 0004 0x04
root@nextcloud:~# showkey -a
Press any keys - Ctrl-D will terminate this program
<ctrl-ч>         60 0074 0x3c
99 0143 0x63
116 0164 0x74
114 0162 0x72
108 0154 0x6c
45 0055 0x2d
209 0321 0xd1
135 0207 0x87
62 0076 0x3e
<ctrl-с>         60 0074 0x3c
99 0143 0x63
116 0164 0x74
114 0162 0x72
108 0154 0x6c
45 0055 0x2d
209 0321 0xd1
129 0201 0x81
62 0076 0x3e
<ctrl-м>         60 0074 0x3c
99 0143 0x63
116 0164 0x74
114 0162 0x72
108 0154 0x6c
45 0055 0x2d
208 0320 0xd0
188 0274 0xbc
62 0076 0x3e
^D        4 0004 0x04
root@nextcloud:~#

You’re right when Russian keyboard layout is enabled Ctrl-XXX doesn’t work.
I will search why and try to fix it

A fix is now available on the latest beta release : https://testflight.apple.com/join/QSrBK59z


issue:Mount the HDD

@indykish
I connect the External Hdd so kindly Mount the Hdd in 175 server

ji kindly send the rbd usage cmd

what command do you need..?

ji if i  launch any vm only launch the 175 server
how much convert the vm size that cmd

rbd ls rio it will list your VM

ji i know this cmd but i want how much convert the current vm size vhdx to raw file that cmd i need

Use this command to convert vhdx image to raw image
qemu-img convert -f vhdx -O raw sigma2.vhdx  rbd:rio/sigma2.img


bug: apisix restarts, ingress controller unavailable

Current Behavior
The following scenario:
1 * apisix gateway instance.
2 * ingress controller instances.
Apisix gateway restart occurred,   the health check interface of leader ingress controller  throws 500 error code.
interface: /apisix/healthz
500 error msg: {"status":"timed out waiting for the condition"}
This interface keeps reporting errors, but another candidate ingress controller interface is normal.
Expected Behavior
It should be able to recover automatically after reporting an error for a period of time.
At present, it can only be solved by restarting the ingress controller
Error Logs
curl http://<IP_ADDRESS>:8080/apisix/healthz
{"status":"timed out waiting for the condition"}
Steps to Reproduce
resource preparation:
1 * apisix gateway instance.
2 * ingress controller instances.
step1: restart apisix gateway.
step2: Observe the leader ingress controller status and logs.
Environment

APISIX Ingress controller version: v1.5.0
Kubernetes cluster version (run kubectl version): v1.22

I want to work on this issue please assign this to me.

Assigned, thanks


Dcmp improve

Here are some minor improvements for dcmp.
"dcmp: improve the usage()
dcmp: improve the summary a bit"
These two are used to improve the usage and summary log, in order to make it more friendly to users.
"dcmp: record the rawtime directly rather than converting from wtime"
This patch uses localtime() to record the time rather than MPI_Wtime (with additional conversion), to avoid some unexpected condition.
"dcmp: skip the size differ check for dir"
This commit remove the size differ check for dir, as we are focusing the size check of files, not dirs, and on the other hand, size of dir may be different even contained files are the same, depends on the fs.

@KnightKu sorry I haven't reviewed this yet. I'll get you a review sometime early this week.

ping... if you can reveiw them, that's much helpful. thanks!

@dinatale2 ，@Adam could you please review them, these patches are landed on my local tree for a long time, and we tested them a lot, works well till now, we think they are useful to many other guys, so if you can review and merge them soon, that would be helpful, thanks.

@KnightKu Hi, can you please send us all of the commands and/or tests you are running so that we can verify your output here?

@KnightKu Thanks, so most of my output was the same. I did notice some edge cases:
./install/bin/dcmp /tmp/dir2 /tmp/dir1 -o SIZE=DIFFER:/tmp/xxxx
Fatal error in PMPI_Type_get_extent: Invalid datatype, error stack:
PMPI_Type_get_extent(121): MPI_Type_get_extent(MPI_DATATYPE_NULL, lb=0x7fffffffda10, extent=0x7fffffffda08) failed
PMPI_Type_get_extent(80).: Datatype for argument datatype is a null datatype
PMGR_COLLECTIVE ERROR: rank 0 on cab670: Called pmgr_abort() Code: 1, Msg: Fatal error in PMPI_Type_get_extent: Invalid datatype, error stack:
PMPI_Type_get_extent(121): MPI_Type_get_extent(MPI_DATATYPE_NULL, lb=0x7fffffffda10, extent=0x7fffffffda08) failed
PMPI_Type_get_extent(80).: Datatype for argument datatype is a null datatype
cab670{sikich1}49: ./install/bin/dwalk -i /tmp/xxxx -p

This happens when all of the files in both directories are the same size. So, we should add support for this case.
I'm also having trouble parsing some of the options:
$: ./install/bin/dcmp /tmp/dir1/ /tmp/dir2/ -o EXIST=ONLY_SRC,TYPE=DIFFER,SIZE=DIFFER,UID=DIFFER,GID=DIFFER,PERM=DIFFER,MTIME=DIFFER
field "PERM" illegal
failed to parse expression "PERM=DIFFER"
failed to parse conjunction "PERM=DIFFER"

dcmp:161414 terminated with signal 11 at PC=40234d SP=7fffffffdb10.  Backtrace:
./install/bin/dcmp[0x40234d]
./install/bin/dcmp[0x406065]
./install/bin/dcmp[0x40630f]
./install/bin/dcmp[0x406cbe]
./install/bin/dcmp[0x406e49]
/lib64/libc.so.6(__libc_start_main+0xfd)[0x2aaaacf03d1d]
./install/bin/dcmp[0x402189]

I can successfully run the getfacl function:
cab670{sikich1}54: getfacl /tmp/dir2/file1.txt
getfacl: Removing leading '/' from absolute path names
# file: tmp/dir2/file1.txt
# owner: sikich1
# group: sikich1
user::rw-
group::---
other::---

But I get a parsing error again here:
cab670{sikich1}55: ./install/bin/dcmp /tmp/dir1/file1.txt /tmp/dir2/file1.txt -o ACL=DIFFER
field "ACL" illegal
failed to parse expression "ACL=DIFFER"
failed to parse conjunction "ACL=DIFFER"

dcmp:168303 terminated with signal 11 at PC=40234d SP=7fffffffdb40.  Backtrace:
./install/bin/dcmp[0x40234d]
./install/bin/dcmp[0x406065]
./install/bin/dcmp[0x40630f]
./install/bin/dcmp[0x406cbe]
./install/bin/dcmp[0x406e49]
/lib64/libc.so.6(__libc_start_main+0xfd)[0x2aaaacf03d1d]
./install/bin/dcmp[0x402189]

Also, did you also test these cases with multiple processes?

Hi @dsikich , yeah, sure, the above cmd&output is a quick show.
BTW, did you apply all the patches (perm and acl support ones)? I mean, the parsing fail only happened to unsupported options.

@KnightKu I believe so, I pulled down the latest changes on master, then made a branch off of that with your pull request. The acl functions are in the branch I was testing on.

Hi @dsikich , sorry for late reply. But it is really strange,  I can not reproduce these issues.:(

@KnightKu hmm ok, well I will check again. I'm primarily worried about this one:
./install/bin/dcmp /tmp/dir2 /tmp/dir1 -o SIZE=DIFFER:/tmp/xxxx

I will reproduce again, and give you the exact structure of the directory and/or files.

@KnightKu can you provide me with your Lustre version, mpi you are using & version, and your version of SLURM?
Also, can you provide me with the contents of the directories you were using for this command:
./install/bin/dcmp /tmp/dir2 /tmp/dir1 -o SIZE=DIFFER:/tmp/xxxx

Since I am still getting this error when I run it:
Fatal error in PMPI_Type_get_extent: Invalid datatype, error stack:
PMPI_Type_get_extent(121): MPI_Type_get_extent(MPI_DATATYPE_NULL, lb=0x7fffffffd360, extent=0x7fffffffd358) failed
PMPI_Type_get_extent(80).: Datatype for argument datatype is a null datatype
PMGR_COLLECTIVE ERROR: rank 0 on cab1: Called pmgr_abort() Code: 1, Msg: Fatal error in PMPI_Type_get_extent: Invalid datatype, error stack:
PMPI_Type_get_extent(121): MPI_Type_get_extent(MPI_DATATYPE_NULL, lb=0x7fffffffd360, extent=0x7fffffffd358) failed
PMPI_Type_get_extent(80).: Datatype for argument datatype is a null datatype

Hi @dsikich , following is what I did, includes the version info.
`[root@server14 mpifileutils]# lctl lustre_build_version
Lustre version: <IP_ADDRESS>-g2e588d8-PRISTINE-2.6.32-642.1.1.el6.x86_64
lctl   version: <IP_ADDRESS>-g2e588d8-PRISTINE-2.6.32-642.1.1.el6.x86_64
[root@server14 mpifileutils]# mkdir /tmp/dir_src
[root@server14 mpifileutils]# mkdir /tmp/dir_dst
[root@server14 mpifileutils]# echo "abc" > /tmp/dir_src/file_foo
[root@server14 mpifileutils]# echo "abc" > /tmp/dir_dst/file_foo
[root@server14 mpifileutils]# mpirun --allow-run-as-root --version
mpirun (Open MPI) 1.8.1
Report bugs to http://www.open-mpi.org/community/help/
[root@server14 mpifileutils]# mpirun --allow-run-as-root ./install/bin/dcmp /tmp                                                                                /dir_src  /tmp/dir_dst -o SIZE=DIFFER:/tmp/xxxx
Files which have different sizes: [0/0], dumped to "/tmp/xxxx"
`
btw, could you please provide the environment  you used to test? lustre version, mpi version and some others, so that I can try with them too, thanks.

@KnightKu Okay, here is what I did:
cab668{sikich1}14: mkdir /tmp/dir_src
cab668{sikich1}15: mkdir /tmp/dir_dst
cab668{sikich1}16: echo "abc" > /tmp/dir_src/file_foo
cab668{sikich1}17: echo "abc" > /tmp/dir_dst/file_foo
cab1{sikich1}19: srun -N1 -n1 install/bin/dcmp /tmp/dir_src /tmp/dir_dst -o SIZE=DIFFER:/tmp/xxxx
Fatal error in PMPI_Type_get_extent: Invalid datatype, error stack:
PMPI_Type_get_extent(121): MPI_Type_get_extent(MPI_DATATYPE_NULL, lb=0x7fffffffd0a0, extent=0x7fffffffd098) failed
PMPI_Type_get_extent(80).: Datatype for argument datatype is a null datatype
srun: error: mvapich: rank 0: unexpected hostidlen = 260
srun: error: mvapich: Fatal error. Killing job
PMGR_COLLECTIVE ERROR: rank 0 on cab1: Called pmgr_abort() Code: 1, Msg: Fatal error in PMPI_Type_get_extent: Invalid datatype, error stack:
PMPI_Type_get_extent(121): MPI_Type_get_extent(MPI_DATATYPE_NULL, lb=0x7fffffffd0a0, extent=0x7fffffffd098) failed
PMPI_Type_get_extent(80).: Datatype for argument datatype is a null datatype
srun: forcing job termination
slurmd[cab1]: *** STEP 3730632.4 KILLED AT 2018-03-13T10:11:59 WITH SIGNAL 9 ***
srun: Job step aborted: Waiting up to 2 seconds for job step to finish.
srun: error: cab1: task 0: Exited with exit code 1
slurmd[cab1]: *** STEP 3730632.4 KILLED AT 2018-03-13T10:11:59 WITH SIGNAL 9 ***

We cannot run jobs as root here. What does --allow-run-as-root exactly do?
Lustre version:
lustre-2.5.5-13chaos_2.6.32_6<IP_ADDRESS>chaos.ch5.6.x86_64.x86_64
And I am using mvapich2, but I also tried running with mpirun and openmpi (1.8) with the same result:
cab1{sikich1}25: mpirun -n 1 install/bin/dcmp /tmp/dir_src /tmp/dir_dst -o SIZE=DIFFER:/tmp/xxxx
Fatal error in PMPI_Type_get_extent: Invalid datatype, error stack:
PMPI_Type_get_extent(121): MPI_Type_get_extent(MPI_DATATYPE_NULL, lb=0x7fffffffcbf0, extent=0x7fffffffcbe8) failed
PMPI_Type_get_extent(80).: Datatype for argument datatype is a null datatype
PMGR_COLLECTIVE ERROR: rank 0 on cab1: Called pmgr_abort() Code: 1, Msg: Fatal error in PMPI_Type_get_extent: Invalid datatype, error stack:
PMPI_Type_get_extent(121): MPI_Type_get_extent(MPI_DATATYPE_NULL, lb=0x7fffffffcbf0, extent=0x7fffffffcbe8) failed
PMPI_Type_get_extent(80).: Datatype for argument datatype is a null datatype
-------------------------------------------------------
Primary job  terminated normally, but 1 process returned
a non-zero exit code.. Per user-direction, the job has been aborted.
-------------------------------------------------------
--------------------------------------------------------------------------
mpirun detected that one or more processes exited with non-zero status, thus causing
the job to be terminated. The first process to do so was:

  Process name: [[43218,1],0]
  Exit code:    1
--------------------------------------------------------------------------

@dsikich we couldn't sucess your problem yet, but i want to reproduce and check your problem.
cab668{sikich1}14: mkdir /tmp/dir_src
cab668{sikich1}15: mkdir /tmp/dir_dst
cab668{sikich1}16: echo "abc" > /tmp/dir_src/file_foo
cab668{sikich1}17: echo "abc" > /tmp/dir_dst/file_foo
cab1{sikich1}19: srun -N1 -n1 install/bin/dcmp /tmp/dir_src /tmp/dir_dst -o SIZE=DIFFER:/tmp/xxxx
what is cab668 and cab1? is that hostname? are you sure running dcmp on node has /tmp/dir_src and /tmp/dir_dst? e.g. you created /tmp/dir_src and /tmp/dir_dst on cab668, but run dcmp on cab1?

@sihara I realized the issue yesterday. I was rebuilding the code with ./buildme instead of ./buildme_dev so it was using an old version of libmfu out of the install directory instead of the new src/.

@sihara @KnightKu @dinatale2 In any case, before merging I'd like a better description of what the code does in both the pull request and the commit messages. For instance, the "add ACL comparison support" commit. It would help if the pull request also listed all of the major changes and why they were added. I think splitting up the ACL comparison work with the summary improvements in dcmp would also speed up the merge process if you want to do that.

@dsikich thanks for your checking and hope you could move forward your testing of patch. And I agreed with you adding more descriptions to what/why we changed with patch. we will improve this sooner.

@sihara Great, yes I was able to move forward. Thanks for all of your work.

@dsikich ，yeah, indeed, more description for each patch is needed, will improve it as you suggested, and spit this series into detail topics, to make them easy for you guys review and move forward. Anyway, thanks very much.

Hi @dsikich , I have updated the changelog of patches and comment of the PR, and split the ACL comparison patch into another PR (not pushed yet), so hope you guys can review this one first and move forward, thanks.

Hi guys, could you please have a look and move forward? any comment is welcome, thanks.

@dsikich anyway, thanks, let me refresh it.

hello, Just wanted to ping. would you re-review patch and commit comments please?

Hi @dsikich , could please review it again? thanks


Codify style for doctring summary lines

Currently, we ask contributors to strive for consistency with existing code, but it would be helpful to clarify the following regarding docstrings:

Docstrings should begin with a short (~70 characters or less) summary line that ends in a period.
The summary line should begin immediately after the opening quotes (do not add a line break before the summary line)
The summary line should describe what it is if it is a class (e.g., "An asynchronous, file-like object for reading ASGI streams.")
The summary line should describe what it does when called, if it is a function, structured as an imperative (e.g., "Delete a header that was previously set for this response.")

We will need two patches to address this issue:

[ ] Update CONTRIBUTING.md to include the guidelines above
[ ] Fix up any existing docstrings to provide a baseline of consistency going forward

@kgriffs I can help in updating CONTRIBUTING.md

Hi @danilito19 ,
Awesome, thanks for your contribution :exclamation:
Could you attempt the second part too? It shouldn't be too hard either, mostly mechanical grepping plus some touch ups in case people (for instance, me :smiling_imp: ) happened to merge non-conforming docstrings.

Absolutely! I thought I needed a bit more understanding on the functions but I can grep and update without changing the wording / meaning.

Fixed by @danilito19 in https://github.com/falconry/falcon/pull/1763


BET-1211: Build both for linux/amd64 and linux/arm64 (actually Apple M1)

Merging opportunistically - please let me know anyway if you have any comments @jamesza @rodrigues @gilacost.

Note to self: we need to automate the branch deletion after merge

I am really keen to use official image instead, will be tackled in CI 😛


Enhancement: Remove the notice that app-only permissions are not supported on commands dealing with event-based retention.

An update to the Microsoft Graph, the retention endpoints have been updated. They now support app-only permissions. We can remove the notice that says app-only permissions aren't supported for these commands:

m365 purview retentionevent [verb]
m365 purview retentioneventtype [verb]
m365 purview retentionlabel [verb]

Can I work on this?


Kf 856 gh109 fix resolve CVE

Design
For more details refer to: https://github.com/canonical/notebook-operators/issues/109
Ignore new files under ./kubeflow/, but please review all update files, eg. Dockerfiles, Makefiles, requirements.*
This PR has limited updates. It downgrades builder images to previous base OS images.
Testing

Follow instructions in ./image-definitions/README.md to create a VM and install all required tools
Checkout this PR in the VM (main branch already contains bulk of the changes for the https://github.com/canonical/notebook-operators/issues/109)
Follow instructions in README.md to build and scan updated images.

No need to do setup part, because it is only used for creating updates.
No need to specify tag, it will be setup automatically.

Expected results:

Rebuilt updated images.
Trivy reports.

images build successfully with following results:
Image build artifacts:
REPOSITORY               TAG                 IMAGE ID       CREATED                  SIZE
notebook-controller      v1.6.1              b8c2e07ea149   Less than a second ago   73.3MB
<none>                   <none>              c99c62cbcd79   4 seconds ago            2.11GB
jupyter-web-app          v1.6.1              fcf6afa50fba   3 minutes ago            184MB
<none>                   <none>              8618ab06e647   3 minutes ago            1.42GB
<none>                   <none>              3c526fcb3dca   8 minutes ago            693MB
<none>                   <none>              246955bcdd52   10 minutes ago           119MB
<none>                   <none>              c15ff77a7b46   10 minutes ago           436MB
base                     v1.6.1              8d686b9ef267   10 minutes ago           436MB
ubuntu                   20.04               f32fe8df6a4c   5 days ago               72.8MB
gcr.io/distroless/base   debug               3713eb4249de   6 days ago               21.5MB
python                   3.7-slim-buster     b39f6ea4df78   7 days ago               116MB
python                   3.7-slim-bullseye   7ef53f615a8b   7 days ago               123MB
golang                   1.19                8295ad49803f   2 weeks ago              993MB
node                     12-buster-slim      44f66a685237   9 months ago             155MB

Scan results:
Tag: v1.6.1
Date: 2023.1.31
CVEs per image:

IMAGE
BASE
CRITICAL
HIGH
MEDIUM
LOW

notebook-controller:v1.6.1
debian:11.6
0
6
2
0

jupyter-web-app:v1.6.1
debian:11.6
0
1
0
0

base:v1.6.1
ubuntu:20.04
0
0
0
0

ubuntu:20.04
ubuntu:20.04
0
0
0
0

gcr.io/distroless/base:debug
debian:11.6
0
0
0
0

python:3.7-slim-buster
debian:10.13
1
1
0
0

python:3.7-slim-bullseye
debian:11.6
0
1
0
0

golang:1.19
debian:11.6
7
12
11
0

node:12-buster-slim
debian:10.12
13
21
11
5

Totals:
21
42
24
5


vcpkg.exe has crashed. windows 10 x64

after clean install from git Latest commit c8c332c  4 hours ago
and running "vcpkg install grpc"
i recived
Process creation failed with error code: 87
and also  "vcpkg.exe has crashed"
C:\vcpkg\vcpkg-master>vcpkg install grpc:x86-windows-static
The following packages will be built and installed:
grpc:x86-windows-static
Starting package 1/1: grpc:x86-windows-static
Building package grpc:x86-windows-static...
-- CURRENT_INSTALLED_DIR=C:/vcpkg/vcpkg-master/installed/x86-windows-static
-- DOWNLOADS=C:/vcpkg/vcpkg-master/downloads
-- CURRENT_PACKAGES_DIR=C:/vcpkg/vcpkg-master/packages/grpc_x86-windows-static
-- CURRENT_BUILDTREES_DIR=C:/vcpkg/vcpkg-master/buildtrees/grpc
-- CURRENT_PORT_DIR=C:/vcpkg/vcpkg-master/ports/grpc/.
-- Downloading https://github.com/grpc/grpc/archive/v1.7.2.tar.gz...
-- Downloading https://github.com/grpc/grpc/archive/v1.7.2.tar.gz... OK
-- Testing integrity of downloaded file...
-- Testing integrity of downloaded file...
Installing package grpc:x86-windows-static... done
Elapsed time for package grpc:x86-windows-static: 7.364 min
Total elapsed time: 7.364 min
The package grpc:x86-windows-static provides CMake targets:
find_package(grpc REQUIRED)
# Note: 6 targets were omitted
target_link_libraries(main PRIVATE gRPC::gpr gRPC::grpc gRPC::grpc_cronet gRPC::grpc_unsecure)

Process creation failed with error code: 87
vcpkg.exe has crashed.
Please send an email to:
<EMAIL_ADDRESS>containing a brief summary of what you were trying to do and the following data blob:
Version=0.0.99-unknownhash
EXCEPTION='device or resource busy: device or resource busy'
CMD=
vcpkg|
install|
grpc:x86-windows-static|
Microsoft Visual Studio Professional 2017
Version 15.4.1
VisualStudio.15.Release/15.4.1+27004.2005
Microsoft .NET Framework
Version 4.7.02556
Installed Version: Professional
Visual Basic 2017   00370-10001-02349-AA565
Microsoft Visual Basic 2017
Visual C# 2017   00370-10001-02349-AA565
Microsoft Visual C# 2017
Visual C++ 2017   00370-10001-02349-AA565
Microsoft Visual C++ 2017
ASP.NET and Web Tools 2017   15.0.30925.0
ASP.NET and Web Tools 2017
ASP.NET Core Razor Language Services   1.0
Provides languages services for ASP.NET Core Razor.
Common Azure Tools   1.10
Provides common services for use by Azure Mobile Services and Microsoft Azure Tools.
JavaScript Language Service   2.0
JavaScript Language Service
Microsoft JVM Debugger   1.0
Provides support for connecting the Visual Studio debugger to JDWP compatible Java Virtual Machines
Microsoft MI-Based Debugger   1.0
Provides support for connecting Visual Studio to MI compatible debuggers
Microsoft Visual C++ Wizards   1.0
Microsoft Visual C++ Wizards
Microsoft Visual Studio VC Package   1.0
Microsoft Visual Studio VC Package
NuGet Package Manager   4.4.0
NuGet Package Manager in Visual Studio. For more information about NuGet, visit http://docs.nuget.org/.
Visual Studio Code Debug Adapter Host Package   1.0
Interop layer for hosting Visual Studio Code debug adapters in Visual Studio
Visual Studio tools for CMake   1.0
Visual Studio tools for CMake
WiX Toolset Visual Studio Extension   <IP_ADDRESS>588
WiX Toolset Visual Studio Extension version <IP_ADDRESS>588
Copyright (c) .NET Foundation and contributors. All rights reserved.

I got the same error here trying to install the pcl-library:
Additional packages (*) will be installed to complete this operation.
Starting package 1/24: bzip2:x86-windows
Building package bzip2:x86-windows...
Process creation failed with error code: 87
Process creation failed with error code: 87
vcpkg.exe has crashed.
Please send an email to:
<EMAIL_ADDRESS>containing a brief summary of what you were trying to do and the following data blob:
Version=0.0.99-2017-11-30-c8c332c8935e0141f4fcb074b511e77e649f0bd9
EXCEPTION='device or resource busy: device or resource busy'
CMD=
D:\repos\vcpkg\vcpkg.exe|
install|
pcl|

Thanks for reporting and identifying the offending commit.
Hotfixed with 88d953a88d7061c4c49a5cb3d6323bb8f4442521 until we figure out the problem.


[BugFix] fix compatibility issue when collecting query statistics (#29678)

backport #29678
What type of PR is this:

[ ] BugFix
[ ] Feature
[ ] Enhancement
[ ] Refactor
[ ] UT
[ ] Doc
[ ] Tool

Does this PR entail a change in behavior?

[x] Yes, this PR will result in a change in behavior.
[ ] No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

[ ] Interface/UI changes: syntax, type conversion, expression evaluation, display information
[ ] Parameter changes: default values, similar parameters but with different default values
[ ] Policy changes: use new policy to replace old one, functionality automatically enabled
[ ] Feature removed
[ ] Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

[ ] I have added test cases for my bug fix or my new feature
[ ] This pr needs user documentation (for new or modified features or behaviors)

[ ] I have added documentation for my new feature or new function

Bugfix cherry-pick branch check:

[ ] I have checked the version labels which the pr will be auto-backported to the target branch

[ ] 3.1
[ ] 3.0
[ ] 2.5
[ ] 2.4

[FE Incremental Coverage Report]
:heart_eyes: pass : 2 / 2 (100.00%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
com/starrocks/qe/SessionVariable.java
2
2
100.00%
[]

[BE Incremental Coverage Report]
:disappointed: fail : 2 / 11 (18.18%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
src/runtime/runtime_state.h
0
4
00.00%
[286, 287, 288, 289]

:large_blue_circle:
src/exec/pipeline/pipeline_driver.cpp
2
7
28.57%
[144, 543, 547, 565, 566]


Clarify bosh scp and bosh ssh documentation

Add positional arguments to the usage string
Be more explicit re: what scp --upload and --download options do

Fixes #884

Any thoughts on this?

@voelzmo @cppforlife What needs to happen to get this in a merge-able state?

fwiw... the incomplete scp command help also confuses the bosh devs :)

@dpb587-pivotal - can we get this PR merged then?

Successfully tested local merge of 78bf608...

scp - tested upload and download; tested older <job> <index> ... syntax
ssh - tested interactive and command argument
units are green
integrations are green

$ bosh help scp
scp <job>/<index> <source> <destination> [--download] [--upload]
[--gateway_host HOST] [--gateway_user USER] [--gateway_identity_file
FILE] [--no_gateway]
    Transfer files to (--upload) or from (--download) a job.
    Note: for --download, <destination> is treated as a directory
    --download                                                Download <source> file from the job
    --upload                                                  Upload <source> file to the job
    --gateway_host HOST                                       Gateway host
    --gateway_user USER                                       Gateway user
    --gateway_identity_file FILE                              Gateway identity file
    --no_gateway                                              Ignore gateway provided by the director

$ bosh help ssh
ssh <job>/<index> [--gateway_host HOST] [--gateway_user USER]
[--gateway_identity_file FILE] [--default_password PASSWORD]
[--strict_host_key_checking <yes/no>] [--no_gateway]
    Execute command or start an interactive session
    --gateway_host HOST                                                     Gateway host
    --gateway_user USER                                                     Gateway user
    --gateway_identity_file FILE                                            Gateway identity file
    --default_password PASSWORD                                             Use default ssh password (NOT RECOMMENDED)
    --strict_host_key_checking <yes/no>                                     Can use this flag to skip host key checking (NOT RECOMMENDED)
    --no_gateway                                                            Ignore gateway provided by the director

Merged - thanks!


Automated cherry pick of #2741: io throttle add log event

Cherry pick of #2741 on release/2.12.
#2741: io throttle add log event

Codecov Report

:exclamation: No coverage uploaded for pull request base (release/2.12@9c6f0d5). Click here to learn what that means.
The diff coverage is 0%.

@@              Coverage Diff               @@
##             release/2.12   #2742   +/-   ##
==============================================
  Coverage                ?   7.23%
==============================================
  Files                   ?     472
  Lines                   ?   74412
  Branches                ?       0
==============================================
  Hits                    ?    5384
  Misses                  ?   68576
  Partials                ?     452

Flag
Coverage Δ

#aFlag
7.23% <0%> (?)

Impacted Files
Coverage Δ

pkg/cloudcommon/db/opslog.go
2.66% <ø> (ø)

pkg/compute/models/guest_actions.go
0% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9c6f0d5...de58f51. Read the comment docs.


Deal with VS/template vs. .NET CLI/template in upcoming BWA+MIE/B2C articles

I am getting the PKCE error when following this how-to: https://learn.microsoft.com/en-us/aspnet/core/blazor/security/webassembly/hosted-with-azure-active-directory-b2c?view=aspnetcore-7.0
Already tried that but didn't work https://github.com/MicrosoftDocs/azure-docs/issues/90850
To reproduce: create a vanilla Blazor WASM project using the latest Visual Studio and Net 7, follow the tutorial.
It doesn’t work.
Please let me know if this is enough.
By the way, what was the resolution for the previous issue if any?
Can you help me please?
Thanks a lot!

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 520b9821-ecef-20af-a601-ea36c4297d88
Version Independent ID: da9c8ac9-4d7a-4b40-56a2-a4bfe7083567
Content: Secure a hosted ASP.NET Core Blazor WebAssembly app with Azure Active Directory B2C
Content Source: aspnetcore/blazor/security/webassembly/hosted-with-azure-active-directory-b2c.md
Product: aspnet-core
Technology: aspnetcore-blazor
GitHub Login: @guardrex
Microsoft Alias: riande

In response to https://github.com/MicrosoftDocs/azure-docs/issues/114778#issuecomment-1722804416 ...

automatically generated

By what? That's not the correct configuration for an app generated by following the article's guidance.
The article shows examples of the configuration files ...

Server app: https://learn.microsoft.com/en-us/aspnet/core/blazor/security/webassembly/hosted-with-azure-active-directory-b2c?view=aspnetcore-7.0#appsettingsjson-configuration
Client app: https://learn.microsoft.com/en-us/aspnet/core/blazor/security/webassembly/hosted-with-azure-active-directory-b2c?view=aspnetcore-7.0#wwwrootappsettingsjson-configuration

You'll need to follow the guidance exactly. The config is very finicky. If one little thing is misconfigured, an app will usually 💥 and not work correctly.

Generated by VS wizard.
It matches what is shown in the article actually.

As a side-note, VS used to have trouble getting the config correct, and I do expect that those problems have been sorted out by now. The article uses the .NET CLI; and although it should generate the same solution with the same config 🤞🍀, I would need to look and validate it. I can use this issue to check on it, including for the other security articles that we maintain. However, we're really under the gun right now on the .NET 8 release work. I'm booked solid right through release, probably right through the EOY. I'll get to it eventually 😅. We'll be replacing our hosted WASM B2C article with a Blazor Web App B2C article, but it will also rely upon the .NET CLI approach, initially anyway. Ideally, I would like to have both .NET CLI and VS approaches explained.
Anyway, what you showed on the other issue doesn't match. That config has a "ServerAPI" section that doesn't match what the topic shows. If VS placed that, then we know that there's some kind of config delta between the article and VS's behavior that I'll need to investigate further. However, that delta in config might not be the cause of the problem. I can only attest to the guidance as written following the steps exactly, including the use of the .NET CLI to generate the app.
Alternatively, the Azure registration also has to match the article's guidance ... exactly. Any deviation on the Azure side also tends to 💥 an app 😈. That's something that I can't look at. I'm not permitted to directly inspect AAD/B2C configs. That part is up to the dev to confirm (or perhaps through a MS Support agreement with a MS Support tech).
To proceed here, you'll need to put up a minimal repro project that demonstrates the problem. If it looks good on a visual inspection, I'll place my Azure test registration config into the repro app to see if it runs here. If the app breaks and I can't figure out why, I'll ask one of the product unit engineers to step in and help. If it runs here, then the problem is almost certainly on the Azure registration side.

Per my company's third-party access guidelines, I'm only allowed to access public repos.

But it contains my tenant etc…
How can we proceed ?
Julien Muller

From: Luke Latham @.>
Sent: Tuesday, September 19, 2023 12:03:24 PM
To: dotnet/AspNetCore.Docs @.>
Cc: Julien Muller @.>; Author @.>
Subject: Re: [dotnet/AspNetCore.Docs] Blazor Wasm Azure B2C Microsoft Account - Proof Key for Code Exchange is required for cross-origin authorization code redemption (Issue #30387)
Per my company's third-party access guidelines, I'm only allowed to access public repos.
—
Reply to this email directly, view it on GitHubhttps://github.com/dotnet/AspNetCore.Docs/issues/30387#issuecomment-1725200434, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AFOT2JD32PR67GQKJUFVYH3X3FUWZANCNFSM6AAAAAA44GGJRA.
You are receiving this because you authored the thread.Message ID: @.***>

Just delete your config values. I'm going to replace them with my values, which match what the topic shows in it's config examples.

contains my tenant

That's why we have the rule. We don't want to see anything private to your company or personal resources, Azure subscription details, or anything of a sensitive nature. It's a security risk that we don't want responsibility for.

Ok, done.
Julien Muller

From: Luke Latham @.>
Sent: Tuesday, September 19, 2023 12:10:39 PM
To: dotnet/AspNetCore.Docs @.>
Cc: Julien Muller @.>; Author @.>
Subject: Re: [dotnet/AspNetCore.Docs] Blazor Wasm Azure B2C Microsoft Account - Proof Key for Code Exchange is required for cross-origin authorization code redemption (Issue #30387)
contains my tenant
That's why we have the rule. We don't want to see anything private to your company or personal resources, Azure subscription details, or anything of a sensitive nature. It's a security risk that we don't want responsibility for.
—
Reply to this email directly, view it on GitHubhttps://github.com/dotnet/AspNetCore.Docs/issues/30387#issuecomment-1725215139, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AFOT2JDUJDMEII6RW2QYIUDX3FVR7ANCNFSM6AAAAAA44GGJRA.
You are receiving this because you authored the thread.Message ID: @.***>

Thanks ... I'll take a look now and get back to you shortly.

No problem here ...

... BUT using the article's recommended configuration. Namely ...
"AzureAd": {
  "Instance": "https://XXXXXXXX.b2clogin.com/",
  "Domain": "XXXXXXXX.onmicrosoft.com",
  "ClientId": "3e6d ... a26",
  "Scopes": "API.Access",
  "SignUpSignInPolicyId": "B2C_1_signupsignin1"
},

... and for the client (noting that I'm using the article's recommendation for the signup/signin user flow) ...
{
  "AzureAd": {
    "ClientId": "96fb ... c4e",
    "Authority": "https://XXXXXXXX.b2clogin.com/XXXXXXXX.onmicrosoft.com/B2C_1_signupsignin1",
    "ValidateAuthority": false
  },
  "ServerApi": {
    "Scopes": "https://XXXXXXXX.onmicrosoft.com/3e6d ... a26/API.Access"
  }
}

I recommend adopting the article's recommended config. Note in passing that for any of our tutorials that they must be followed exactly for the best experience. This one is .NET CLI based. For VS, all bets are off 🎲🎲. 😆 I know and agree on there being parity between these approaches. In a perfect world, that's what we'd have. We don't have it. There are differences, and those differences can 💥 an app.
If that approach works, cool ... I suggest going forward with it. If that fails, then I suspect the Azure registration isn't correct. You'd need to carefully run back down the article's Azure config and check everything.
While you're working on the app and Azure config, note that every app change and every Azure registration change no matter how insignificant requires you to both re-run the app AND use a new incognito/in-private browser (as our guidance calls for) because lingering cookies can 💥 the sign-on. We have guidance on it in the article at ...
https://learn.microsoft.com/en-us/aspnet/core/blazor/security/webassembly/hosted-with-azure-active-directory-b2c?view=aspnetcore-7.0#cookies-and-site-data
Even if you get it working with the article's config, leave this issue open. I plan to use this issue to deal with the discrepancies between the article's config, which is based on using the .NET CLI and project template, and what VS sets up. However, I might only be working on this for new Blazor Web Apps for 8.0 or later. I don't think it's important to update for VS in old guidance in the hosted WASM case. That template is being dropped for SDK 8.0 or later. Devs are going to need to know about CLI/template versus VS/template deltas for Blazor Web Apps going forward. I'd like to keep this issue open as a reminder for that work. I'll probably close this when I set up the new BWA issues tho, which should just before or after RC2 releases next month.

From scratch, using the CLI : exactly the same error.
Julien Muller
De : Luke @.>
Envoyé le :mardi 19 septembre 2023 13:13
À : @.>
Cc : Julien @.>; @.>
Objet :Re: [dotnet/AspNetCore.Docs] Blazor Wasm Azure B2C Microsoft Account - Proof Key for Code Exchange is required for cross-origin authorization code redemption (Issue #30387)
No problem here ...
[image]https://user-images.githubusercontent.com/1622880/268931362-20e47c95-b070-4ae4-943a-4ef37f5cca15.png
... BUT using the article's recommended configuration. Namely ...
"AzureAd": {
"Instance": "https://XXXXXXXX.b2clogin.com/",
"Domain": "XXXXXXXX.onmicrosoft.com",
"ClientId": "3e6d ... a26",
"Scopes": "API.Access",
"SignUpSignInPolicyId": "B2C_1_signupsignin1"
},
... and for the client (noting that I'm using the article's recommendation for the signup/signin user flow) ...
{
"AzureAd": {
"ClientId": "96fb ... c4e",

"Authority": "https://XXXXXXXX.b2clogin.com/XXXXXXXX.onmicrosoft.com/B2C_1_signupsignin1",

"ValidateAuthority": false

},
"ServerApi": {
"Scopes": "https://XXXXXXXX.onmicrosoft.com/3e6d ... a26/API.Access"

}
}
I recommend adopting the article's recommended config. Note in passing that for any of our tutorials that they must be followed exactly for the best experience. This one is .NET CLI based. For VS, all bets are off 🎲🎲. 😆 I know and agree on there being parity between these approaches. In a perfect world, that's what we'd have. We don't have it. There are differences, and those differences can 💥 an app.
If that approach works, cool ... I suggest going forward with it. If that fails, then I suspect the Azure registration isn't correct. You'd need to carefully run back down the article's Azure config and check everything.
While you're working on the app and Azure config, note that every app change and every Azure registration change no matter how insignificant requires you to both re-run the app AND use a new incognito/in-private browser (as our guidance calls for) because lingering cookies can 💥 the sign-on. We have guidance on it in the article at ...
https://learn.microsoft.com/en-us/aspnet/core/blazor/security/webassembly/hosted-with-azure-active-directory-b2c?view=aspnetcore-7.0#cookies-and-site-data
Even if you get it working with the article's config, leave this issue open. I plan to use this issue to deal with the discrepancies between the article's config, which is based on using the .NET CLI and project template, and what VS sets up. However, I might only be working on this for new Blazor Web Apps for 8.0 or later. I don't think it's important to update for VS in old guidance in the hosted WASM case. That template is being dropped for SDK 8.0 or later. Devs are going to need to know about CLI/template versus VS/template deltas for Blazor Web Apps going forward. I'd like to keep this issue open as a reminder for that work. I'll probably close this when I set up the new BWA issues tho, which should just before or after RC2 releases next month.
—
Reply to this email directly, view it on GitHubhttps://github.com/dotnet/AspNetCore.Docs/issues/30387#issuecomment-1725299313, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AFOT2JF65HMKYXW3EGJL24LX3F44RANCNFSM6AAAAAA44GGJRA.
You are receiving this because you authored the thread.Message ID: @.***>

Also note the « Run user flow » command in Azure AD B2C gives the same.
Julien Muller
De : Luke @.>
Envoyé le :mardi 19 septembre 2023 13:13
À : @.>
Cc : Julien @.>; @.>
Objet :Re: [dotnet/AspNetCore.Docs] Blazor Wasm Azure B2C Microsoft Account - Proof Key for Code Exchange is required for cross-origin authorization code redemption (Issue #30387)
No problem here ...
[image]https://user-images.githubusercontent.com/1622880/268931362-20e47c95-b070-4ae4-943a-4ef37f5cca15.png
... BUT using the article's recommended configuration. Namely ...
"AzureAd": {
"Instance": "https://XXXXXXXX.b2clogin.com/",
"Domain": "XXXXXXXX.onmicrosoft.com",
"ClientId": "3e6d ... a26",
"Scopes": "API.Access",
"SignUpSignInPolicyId": "B2C_1_signupsignin1"
},
... and for the client (noting that I'm using the article's recommendation for the signup/signin user flow) ...
{
"AzureAd": {
"ClientId": "96fb ... c4e",

"Authority": "https://XXXXXXXX.b2clogin.com/XXXXXXXX.onmicrosoft.com/B2C_1_signupsignin1",

"ValidateAuthority": false

},
"ServerApi": {
"Scopes": "https://XXXXXXXX.onmicrosoft.com/3e6d ... a26/API.Access"

}
}
I recommend adopting the article's recommended config. Note in passing that for any of our tutorials that they must be followed exactly for the best experience. This one is .NET CLI based. For VS, all bets are off 🎲🎲. 😆 I know and agree on there being parity between these approaches. In a perfect world, that's what we'd have. We don't have it. There are differences, and those differences can 💥 an app.
If that approach works, cool ... I suggest going forward with it. If that fails, then I suspect the Azure registration isn't correct. You'd need to carefully run back down the article's Azure config and check everything.
While you're working on the app and Azure config, note that every app change and every Azure registration change no matter how insignificant requires you to both re-run the app AND use a new incognito/in-private browser (as our guidance calls for) because lingering cookies can 💥 the sign-on. We have guidance on it in the article at ...
https://learn.microsoft.com/en-us/aspnet/core/blazor/security/webassembly/hosted-with-azure-active-directory-b2c?view=aspnetcore-7.0#cookies-and-site-data
Even if you get it working with the article's config, leave this issue open. I plan to use this issue to deal with the discrepancies between the article's config, which is based on using the .NET CLI and project template, and what VS sets up. However, I might only be working on this for new Blazor Web Apps for 8.0 or later. I don't think it's important to update for VS in old guidance in the hosted WASM case. That template is being dropped for SDK 8.0 or later. Devs are going to need to know about CLI/template versus VS/template deltas for Blazor Web Apps going forward. I'd like to keep this issue open as a reminder for that work. I'll probably close this when I set up the new BWA issues tho, which should just before or after RC2 releases next month.
—
Reply to this email directly, view it on GitHubhttps://github.com/dotnet/AspNetCore.Docs/issues/30387#issuecomment-1725299313, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AFOT2JF65HMKYXW3EGJL24LX3F44RANCNFSM6AAAAAA44GGJRA.
You are receiving this because you authored the thread.Message ID: @.***>

I left a message on the other issue that they should say what they did offline to resolve it.
Did you search on this online? I see remarks, such as ...

The error "AADSTS9002325: Proof Key for Code Exchange is required for cross-origin authorization code redemption" indicates that the authorization code was sent from a different origin than the redirect URI specified in the initial authorization request. This is a security feature designed to prevent unauthorized access to the user's access tokens.
To fix this issue, you need to ensure that the redirect URI specified in your initial authorization request matches the redirect URI specified in the Azure AD application registration. You also need to ensure that the same redirect URI is used in both the initial authorization request and the subsequent token request.
Please refer the below links which could solve this problem

Cross-ref: https://learn.microsoft.com/en-us/answers/questions/1194524/how-to-fix-aadsts9002325-proof-key-for-code-exchan
BUT .... I recommend being very careful about following guidance in links haphazardly because it can lead to an unsafe configuration. Whatever they're discussing in those links has to be carefully checked itself before just following their advice, especially non-Microsoft links.
However, my guess is that your Azure config doesn't match our guidance in some way.

Ok, finally it works :

The Microsoft Identity provider App Registration has to be set up in the non B2C Tenant
This App Registration auth has to be Web and not SPA

Thanks a lot four your help and time !
De : Luke @.>
Envoyé le :lundi 25 septembre 2023 13:36
À : @.>
Cc : Julien @.>; @.>
Objet :Re: [dotnet/AspNetCore.Docs] Deal with VS/template vs. .NET CLI/template in upcoming BWA+MIE/B2C articles (Issue #30387)
I left a message on the other issue that they should say what they did offline to resolve it.
Did you search on this online? I see remarks, such as ...
The error "AADSTS9002325: Proof Key for Code Exchange is required for cross-origin authorization code redemption" indicates that the authorization code was sent from a different origin than the redirect URI specified in the initial authorization request. This is a security feature designed to prevent unauthorized access to the user's access tokens.
To fix this issue, you need to ensure that the redirect URI specified in your initial authorization request matches the redirect URI specified in the Azure AD application registration. You also need to ensure that the same redirect URI is used in both the initial authorization request and the subsequent token request.
Please refer the below links which could solve this problem
Cross-ref: https://learn.microsoft.com/en-us/answers/questions/1194524/how-to-fix-aadsts9002325-proof-key-for-code-exchan
BUT .... I recommend being very careful about following guidance in links haphazardly because it can lead to an unsafe configuration. Whatever they're discussing in those links has to be carefully checked itself before just following their advice, especially non-Microsoft links.
However, my guess is that your Azure config doesn't match our guidance in some way.
—
Reply to this email directly, view it on GitHubhttps://github.com/dotnet/AspNetCore.Docs/issues/30387#issuecomment-1733489814, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AFOT2JECCUBBE35RG3EAOWLX4FUCJANCNFSM6AAAAAA44GGJRA.
You are receiving this because you authored the thread.Message ID: @.***>

Ok ... glad to hear that it's working now.
IIRC, that sounds familiar for a B2C app that isn't registered in a B2C tenant. I had a remark about that scenario in an earlier version of this article, but I removed it because I don't want to complicate an already complex configuration. Besides, a B2C tenant for a B2C app is what the Azure docs do, so we're more inline with their recommendation.
Leave this issue open. I'll try to get our guidance to include a VS experience SxS with the .NET CLI experience. Not sure when I'll reach it ... probably 24H1.

I finally reached this for a look 😅 ... it's been a very busy period for docs with the .NET/BWA guidance rollout this release.
We don't maintain this guidance any longer for hosted WASM. The hosted WASM template is gone now (>=8.0).
I also just generated an app using the Visual Studio built-in "dotnet msidentity tool" and discovered that it doesn't produce the correct app settings and configuration for a standalone WASM app that uses MS personal accounts. [I just tried the MS Accounts article procedure first. We maintain three articles where describing the tool's use might have come in handy.] The best approach is still to create the app from the .NET CLI and set the app settings/config by hand.
I also followed their link next to the tool in the VS wizard, and that link only takes you to the landing page for MS Identity Platform ...
https://learn.microsoft.com/en-us/entra/identity-platform/
... and I can't find any article in their doc set dedicated to this built-in tool/wizard ...
https://www.google.com/search?client=firefox-b-1-d&q=site%3Alearn.microsoft.com+"dotnet+msidentity+tool"#ip=1
Therefore, I have nothing to link to for how it works and how to use it.
For the preceding reasons, we're going to stick with our .NET CLI approach. Closing this now as a won't fix, but thanks for the issue and discussion. I'm glad that you were able to get your app running when we chatted on this subject 🎉.


Change av profile default logic based on new version support matrix

I'm okay with this change, but I agree w/ @CecileRobertMichon that we should do >= 1.10.2 to reflect the real requirement. We don't have to document the boring detail about why imds didn't work until 1.10.2, but the tl;dr is that vmss + Azure cloudprovider is functional as of k8s 1.10.2.

/lgtm


Fix homepage on mobile

From telegram:

For the mobile portrait perspective, we can use the corresponding vertical logo or just keep the horizontal version as we had last year - probably even better, since you will then be able to see the important dates right on the initial screen.

Artur, [12 Mar 2019 at 19:22:20]:
to get this ↑ working on mobile we will need someone to write some additional CSS, because in current template (and it's basically off the shelf bootstrap) what happens with the horizontal logo is that it overflows the screen to the right

so the logo itself is visible and some of the text, but the rest of it is off the screen.

Closing because this is fixed already


Segmentation Fault in RedisTest::testSetAndGetItemOfDifferentTypes

The segfault happens on trying to store a NULL value and it has been fixed in redis-2.2.7 which was released in 2015-03-03
The problem here is that most distros are shipping an older version.
I see the following possibilities:

Mark as wontfix
increase minimum required redis extension version to 2.2.7
check redis extension version and define the capability supported data types accordingly
manually cast to NULL to string as this is what the current capability supported data types defines

@weierophinney @Maks3w @Ocramius @kynx  Thoughts ?

Does this affect to production code or only to tests?

What redis extension version is distributed in those distributions?

Is that version branch still supported by the vendor?

About to transform null in a different type, definitely no as it breaks forward compatibility and breaks the developer expectations.
If we conclude we can't raise the minimum version then we should throw Exception if null data type and bugged extension are used at the sametime. The exception should indicate the developer must update the extension, avoid to write null values or replace null values with any other value like string, integer,  etc

Of the distros I've got running:

RHEL 5 (via EPEL): doesn't ship extension
RHEL 6 & 7 (via EPEL): 2.2.7
Ubuntu 14.04.4: 2.2.4
Brew: 2.2.7

Would bumping the minimum version mean tests won't run in travis? That would be a pain.

IIRC there is a setting for use a most recent version of Ubuntu.
As far as I see only current Ubuntu LTS ship an older version. But Ubuntu has a large userbase and the jump to versions greater than 14.1 is not easy.
An alternative is ask to Ubuntu if they want to upgrade the version or backport the fix.

debian jessie = 2.2.5
debian sid (unstable) = 2.2.7

Because (currently) this adapter only supports string defined by our own capabilities I think the simplest fix would be to cast every input into a string before calling writing functions to redis.
As far as I can see in the redis source code it already supports serializing data into strings but for zend-cache this is a new future we can add this functionality in a future release that than needs to proper handle different versions of the installed redis extension.

mh forget about my last comment this is more complicated:
Currently the capabilities describes that the redis adapter casts everything into strings.
This is not true!
In fact the adapter itself doesn't cast anything and gives the values as-is to the extension.
The extension does support serializing values but it needs to be configured to use a serializer.
By default no serializer is configured and yes in this case every value shoiuld be cast to a string by the extension but with the edge case that on storing NULL a segmentation fault happens in version 2.2.5.
I have a working PR #89 which fixes both because I'm sure if we blindly cast everything into a string only because the supported datatypes capability tells that it's still a BC break as it was working before.


correctly (don't) interpolate non-text values in custom responses

Proposed changes:

revert this change, which turned all template values into strings in interpolation in order to avoid int and None values from breaking templates
fix #5453 by bypassing interpolation for int, None, and bool values
avoid turning ints, Nones, and bools into strings, which can negatively affect the type of the value sent to the connector

Note: when 1.10.x is merged to master, we need to revert the change in the above PR, as it won't show in the diff
Status (please check what you already did):

[x] added some tests for the functionality
[ ] updated the documentation
[x] updated the changelog (please check changelog for instructions)
[x] reformat files using black (please check Readme for instructions)

About the failing type check: maybe we have to add # pytype: disable=pyi-error to the line 7 in rasa.core.nlg.template,  where we do from rasa.core.nlg.generator import NaturalLanguageGenerator.
The issue is probably that in rasa.core.nlg.generator there is a function _create_from_endpoint_config which does from rasa.core.nlg import TemplatedNaturalLanguageGenerator, so the type checker thinks there is a cyclical import. In fact, that isn't really a problem (I think), so we can disable it.


Implement docker production build and serving

Pushed to dev-build and merged to dev, Closing this issue


fix: add cred helpers and sbom to gitignore

Signed-off-by: ankitm123<EMAIL_ADDRESS>

killed old jobs manually

/approve

/hold

/hold cancel


Check internal links on Travis

Fix #106
Adding a script that does the job just for us is easy, we can replace it when mdbook win the ability to check internal links.
I am first checking that Travis does fails, I'll send another commit to fix broken links.

It works!
$ ./scripts/check-html-book.py doc/book
broken link to 'concepts/intro.html' in doc/book/intro.html
broken link to 'concepts/intro.html' in doc/book/index.html
broken link to 'faq.html#Why%20is%20Lumol%20written%20in%20Rust?' in doc/book/installation.html
broken link to 'faq.html#Is%20the%20code%20parallel?%20If%20so,%20how%20well%20does%20it%20scale?' in doc/book/faq.html
broken link to 'input/simulations.html#Outputs' in doc/book/concepts/simulation.html
broken link to 'input/intro.html#Input%20metadata' in doc/book/input/intro.html
broken link to 'pairs.html#Pairs%20restrictions' in doc/book/input/interactions.html
broken link to 'pairs.html#Pairs%20restrictions' in doc/book/input/interactions.html
broken link to 'input/md.html#Thermostats' in doc/book/input/md.html
broken link to 'input/mc.html#Translation' in doc/book/input/mc.html
broken link to 'input/mc.html#Rotation' in doc/book/input/mc.html
broken link to 'input/mc.html#Resize' in doc/book/input/mc.html
broken link to 'chemfiles.github.io' in doc/book/input/mc.html
------------------
13 link errors in doc


Canvas: Don't pass isRTL to svg tag

Summary
Make isRTL a transient prop so that it's not passed to the svg tag.
Testing Instructions

[x] This is a non-user-facing change and requires no QA

This PR can be tested by following these steps:

Add video to canvas
Hover/select video in canvas
Should not see error in console for isRTL.

Reviews
Does this PR have a security-related impact?
no
Does this PR change what data or activity we track or use?
no
Does this PR have a legal-related impact?
no
Checklist

[x] This PR addresses an existing issue and I have linked this PR to it in ZenHub
[x] I have tested this code to the best of my abilities
[x] I have verified accessibility to the best of my abilities (docs)
[x] I have verified i18n and l10n (translation, right-to-left layout) to the best of my abilities
[x] This code is covered by automated tests (unit, integration, and/or e2e) to verify it works as intended (docs)
[x] I have added documentation where necessary
[x] I have added a matching Type: XYZ label to the PR

Fixes #10006

FYI I am also fixing this in #9944.
There are more affected SVGs, see b37338908fe0b9e343569dc638caae787c7603fd

Oh nice! This pr isn't necessary then 😄


Crashed when batch processing two images

Here is the error code:
java.lang.OutOfMemoryError: Failed to allocate a 132483960 byte allocation with 16773152 free bytes and 94MB until OOM
java.lang.OutOfMemoryError: Failed to allocate a 132483960 byte allocation with 16773152 free bytes and 94MB until OOM
at dalvik.system.VMRuntime.newNonMovableArray(Native Method)
at android.graphics.BitmapFactory.nativeDecodeStream(Native Method)
at android.graphics.BitmapFactory.decodeStreamInternal(BitmapFactory.java:726)
at android.graphics.BitmapFactory.decodeStream(BitmapFactory.java:702)
at android.graphics.BitmapFactory.decodeStream(BitmapFactory.java:740)
at f6.a.h(SourceFile)
at q5.e.j(SourceFile:45)
at e4.a.p(SourceFile)
at u4.h0.run(SourceFile)
at kotlinx.coroutines.internal.e.run(SourceFile)
at kotlinx.coroutines.scheduling.j.run(SourceFile)
at kotlinx.coroutines.scheduling.a$a.run(SourceFile:79)
Suppressed: u4.f0: [k1{Cancelling}@74a284, Dispatchers.Main.immediate]

Similar error when opening one of the two images:
java.lang.OutOfMemoryError: Failed to allocate a 132483960 byte allocation with 16773912 free bytes and 93MB until OOM
java.lang.OutOfMemoryError: Failed to allocate a 132483960 byte allocation with 16773912 free bytes and 93MB until OOM
at dalvik.system.VMRuntime.newNonMovableArray(Native Method)
at android.graphics.BitmapFactory.nativeDecodeStream(Native Method)
at android.graphics.BitmapFactory.decodeStreamInternal(BitmapFactory.java:726)
at android.graphics.BitmapFactory.decodeStream(BitmapFactory.java:702)
at android.graphics.BitmapFactory.decodeStream(BitmapFactory.java:740)
at f6.a.h(SourceFile)
at d6.c.j(SourceFile:45)
at e4.a.p(SourceFile)
at u4.h0.run(SourceFile)
at kotlinx.coroutines.internal.e.run(SourceFile)
at kotlinx.coroutines.scheduling.j.run(SourceFile)
at kotlinx.coroutines.scheduling.a$a.run(SourceFile:79)
Suppressed: u4.f0: [k1{Cancelling}@b068cfd, Dispatchers.Main.immediate]

This only means that you trying to resize too large images for your device, can you send them here?

No, i can't share the photos here.
But the photos are 4.7 mb and 4.9 mb only.
My device memory is 2gb and operating system is android 7.1.1.
When it crashed i used the below app
https://play.google.com/store/apps/details?id=com.simplemobilephotoresizer
And in the app resize took place with no crashes.

No, i can't share the photos here.
But the photos are 4.7 mb and 4.9 mb only.
My device memory is 2gb and operating system is android 7.1.1.
When it crashed i used the below app
https://play.google.com/store/apps/details?id=com.simplemobilephotoresizer
And in the app resize took place with no crashes.

Which resolution they are?

132483960 is a 132 mb sized image, this is too large

The details of the images are here:

Have no idea, saving should work correctly, I'm fine even with 8k images :(


[no-object-literal-type-assertion] allowAsParameter

const foo = [['a', 1], ['b', 2]].reduce(
  (o, [k, v]) => {
    o[k] = v + 1
    return o
  },
  {} as Record<string, number> // eslint-disable-line @typescript-eslint/no-object-literal-type-assertion
)

I see nothing wrong with that assertion. Perhaps allowAsParameters should be turned on.

https://github.com/typescript-eslint/typescript-eslint/blob/master/packages/eslint-plugin/docs/rules/no-object-literal-type-assertion.md

I think it wants you to type:
-const foo = [['a', 1], ['b', 2]].reduce(
+const foo: Record<string, number> = [['a', 1], ['b', 2]].reduce(
   (o, [k, v]) => {
     o[k] = v + 1
     return o
   },
-  {} as Record<string, number> // eslint-disable-line @typescript-eslint/no-object-literal-type-assertion
+  {}
 )

Not sure that it's nice to enforce that though, but maybe it is... 🤔

I would be alright with that. How did you figure this out?

How did you figure this out?

I just guessed from the rule description, I haven't tested it 😄

I think the current way is good. Another solution for this is:
const foo = [['a', 1], ['b', 2]].reduce(
-  (o, [k, v]) => {
+  (o: Record<string, number>, [k, v]) => {
    o[k] = v + 1
    return o
  },
-  {} as Record<string, number> // eslint-disable-line @typescript-eslint/no-object-literal-type-assertion
+ {}
)

You are probably good to close this out, and someone can reopen/comment on this if they have a differing opinion 😄


Hdp

Chun/Krystal,
I added some tests on top of partitioned hive tables where metadata changes took place.  I got a clean functional run with no failures. Kindly take a look and let me know your thoughts.
Rahul

The tests/changes look good to me.
Thanks,
Krystal


How is this not on awesome-go?

Really, get it up there!

I never had time to open a PR there and I also wasn't quite sure if they would be even interested. I've opened a PR now, so let's see if they accept it.


Improve std.test

[ ] Allow tests to be named (and these names should be visible when printing)
[ ] Allow tests to be grouped (and these groups should be visible when printing)
[ ] Two stage test execution. Tests should first be defined as a data structure see (https://github.com/Marwes/tensile/ or http://haskell.github.io/test-framework/) which then gets executed. This would let us gather information about how many tests there are before starting execution and let it integrate better with tensile
[ ] Integrate with tensile #468

Might also be nice to check out these libs for inspiration too:

https://hspec.github.io/
https://github.com/elm-community/elm-test

The neat thing about http://haskell.github.io/test-framework/ (and really, any of the Haskell test frameworks) is that they have good interop between various test providers (such as quickcheck etc). The foundation described here should be a fairly solid foundation (it mirrors both hspec and elm-test) and then we can build specialized test on top of this.
I mustn't forget to make tests lazy as elm-test has (changing test : String -> Test a to  test: String -> (() -> Test a))


change pulse source/proportion to support simultaneous sources in pulse events

See https://github.com/popsim-consortium/demes-spec/issues/100 and PR #353.
NOTE: This is a breaking change, so we'll need to coordinate with downstream software.

I think the best way to manage this breakage is to introduce it in a 0.2.0 release. And we should first give downstream software enough time to make their own point release that pins demes < 0.2. Then when we release 0.2.0 it hopefully won't break too many installations.

Closed by #353


Delivery Option incorrectly allows time selection

Description
The Delivery Option in the application currently includes the ability to select a time, which is unintended or unnecessary for this feature.
To Reproduce

Navigate to the Delivery Option in the application.
Observe the option to select a delivery time.

Expected behavior
The Delivery Option should not include a time selection.
Desktop (please complete the following information):

OS: Windows
Browser: Chrome

Smartphone (please complete the following information):

Device: iPhone15pro
OS: iOS17.6.1

Hi, Can you assign this issue to me? I  am new to open source and would like to work on this.