Add mention to e2e pipelines in README

What this PR does / why we need it
Checklist

[ ] Update changelog in CHANGELOG.md.

Trigger e2e tests

/test create
/test upgrade

hey @QuentinBisson I'm trying to explain better how the pipelines work, any feedback is welcome.

Thanks a lot Jose this is definitely helps but why did I also found the build in prow?
Also, would it be possible to have a link to the pipeline run in the github issue so we can check directly?

Thanks a lot Jose this is definitely helps but why did I also found the build in prow?

What do you mean? We use prow to communicate between PRs and tekton.

Also, would it be possible to have a link to the pipeline run in the github issue so we can check directly?

I don't think it's possible at the moment without some effort, and we currently don't have the bandwidth.

Well, you were mentionning teckton and not prow hence my question :)
I'm fine without the links but for people that do not use tekton or prow on a regular basis, having a quick how to find your pipeline section would help in the doc :)

I'll merge this for now and see if I can document it better.


Issue after installing styled-icons: Uncaught Error: Cannot find module "./Package"

I am trying to use icon components from boxicons-refular and from feather but I keep getting this error:
Uncaught Error: Cannot find module "./Package"
at Object../node_modules/styled-icons/boxicons-regular/index.esm.js (index.esm.js:1)
at webpack_require (bootstrap dc6288451e0e3c5e8494:678)
at fn (bootstrap dc6288451e0e3c5e8494:88)
at Object../src/Containers/Notifications.js (NotFound.js:5)
at webpack_require (bootstrap dc6288451e0e3c5e8494:678)
at fn (bootstrap dc6288451e0e3c5e8494:88)
at Object../src/Containers/Routes.js (Query.js:1607)
at webpack_require (bootstrap dc6288451e0e3c5e8494:678)
at fn (bootstrap dc6288451e0e3c5e8494:88)
at Object../src/App.js (fetch.js:461)
at webpack_require (bootstrap dc6288451e0e3c5e8494:678)
at fn (bootstrap dc6288451e0e3c5e8494:88)
at Object../src/index.js (index.js:90)
at webpack_require (bootstrap dc6288451e0e3c5e8494:678)
at fn (bootstrap dc6288451e0e3c5e8494:88)
at Object.0 (_site.scss?0c0b:26)
at webpack_require (bootstrap dc6288451e0e3c5e8494:678)
at bootstrap dc6288451e0e3c5e8494:724
at bootstrap dc6288451e0e3c5e8494:724
It seems to think that the Package components is a json ? But I'm not sure, I've tried removing that component but with no luck.

Thanks for the report!  I found the issue, it was that on case-insensitive file systems, certain bundlers were trying to load the package.json file instead of the Package directory for that icon - I fixed the issue in #823 by renaming the Package icons to PackageIcon instead, to eliminate the naming conflict.
CI is building now, and the fix should be released shortly as v8.0.0.


Assigned XRI hover events for tripod center piece to enable outlines (Fixes #692)

Fixes #692
The XRI hover events on the center of the tripod object in the OutlineExample scene were not set, resulting in the outline not appearing when selecting, looking at or pointing at the object.

/azp run

Thanks for assigning these fields!


bump submodule commits

bump commits of all submodules to the most recent one.
(I don't know why git submodule doesn't do this automatically/ how to do that. Maybe this is the wrong way of doing this.)

ok, I think I need to regenerate the protocol data from xml.
still need to figure this out

I don't know why git submodule doesn't do this automatically

It's by design, submodules are like dependencies, and usually you don't want dependencies to update behind your back.

ok, I think I need to regenerate the protocol data from xml. still need to figure this out

See one of the previous updates to known how to edit src/data/protocol-registry.ts file.
After that just run npm run regenerate-protocols


getAdapter return null, use of a promise to init Bluetooth.

I'm starting to study the plugin for use of Bluetooth.
Unfortunately I discovered that the tablet I have does not have bluetooth, so when I initialize the plugin I get an exception, since the getAdapter function returns null.
Given this I would suggest that this plugin's start point would be a 'Promise' something like:
Bluetooth.init = function() {
  return new Promise(function(resolve, reject) {
      var bluetoothManager = utils.ad.getApplicationContext().getSystemService(android.content.Context.BLUETOOTH_SERVICE);
      adapter = bluetoothManager.getAdapter();
      if(adapter === null) {
         reject("this device not have bluetooth!");
         return;
       }
       //......
  });
};

And this initialization was controlled by the application, so we would have access to the 'then' and 'cath' functions to take some action so the application did not break.

Well, technically you should/could call 'init' inside or after checking isBluetoothEnabled method, which in this case should return false if no bluetooth turned on/existing.
dp


Xyd/reorg

Reorg python lib structure

simulator/common -> drltt/

improve ci

in dockerfile, make git clone more robust
in runner launch script, parse URL from argument
add retry for git clone

CI passed. LGTM


Added Isabelle 2021

Added Isabelle 2021 (no changes from 2020).

Cool. seems to be stable between Isabelle versions. Is this already tested and running on some server?

Yes, on vmnipkow14.in.tum.de (Isa21 Test contest).


Repository has modified files immediately after cloning it

It looks like someone submitted something that is confusing this repository. If you clone the repository, it will clone with modified files in it. You cannot checkout tags, or do anything with the repository. This is breaking continuous integration that is using this repository.
This commit is causing git to modify these files on clone. https://github.com/jashkenas/backbone/commit/1bb06dba0668fdfdfc11dfcfa21224075c23f7f0
Can someone please fix this so that people can clone this repository correctly again? Or suggest how one might go about getting this to work with their system?

Yep. We are tracking it in #4036 and #4042. Thanks for reporting.


Fix weekly CI pipeline errors

Fix type annotation for _add_attribute_to_torchscript_node and removed runtime type checking because int like inputs are not correctly recognized by beartype
Fix test_tensor_proto_tensor_bfloat16 with latest onnx-weekly
pytorch-nightly errors will be fixed separately

Do we plan on fixing the failing dort ci's in a future PR?

I don't have plans for it yet. The dort ci failures should be the same as the torch-nightly failures, which are mostly tolerance issues.


Updated Data - Experiment Details, Recommendation and Information for Templates. (Removed Dummy Data)

Proposed changes
This PR has removed the dummy data from templates that were used for Experiment details.
Updated Files
-Head
-Experiment
-Recommandation
-BrowserTemplate
-Redux Changes
Types of changes
What types of changes does your code introduce to Litmus? Put an x in the boxes that apply

[x] New feature (non-breaking change which adds functionality)
[x] Bugfix (non-breaking change which fixes an issue)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation Update (if none of the other choices applies)

Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

[ ] I have read the CONTRIBUTING doc
[ ] I have signed the commit for DCO to be passed.
[ ] Lint and unit tests pass locally with my changes
[ ] I have added tests that prove my fix is effective or that my feature works (if appropriate)
[ ] I have added necessary documentation (if appropriate)

Dependency

Please add the links to the dependent PR need to be merged before this (if any).

Special notes for your reviewer:

@rajdas98 PTAL

@rajdas98 We can close this PR for now.

@S-ayanide I already worked on this let me know changes. Why you want to close this PR. cc, @rajdas98 please keep this PR.

Thank you for your review @S-ayanide but  I didn't add extra interfaces I just add a variable into it. Please Look carefully. cc, @rajdas98

/preview 10

/preview


🚀 [Feature] update registration link on wordpress page(s)

🚀 Feature

change the wordpress pages to use the new "registration URL" defined by the new registration process
append the optional URL parameter PID to the registration URL

@ulfgebhardt: are the changes on the wordpress-pages done with the last hotfix-rollout?
If yes, the ticket can be closed too.

They are done, but not part of the hotfix - we have to wait for a new deploy unless we want to do another hotfix. We merged some admin hotfixes instead

this is done


Provided the support of shared pointer with example

As per the conversation in the PR #51 , provided the support of shared pointer along with an example.
Please consider the PR for the merge.

Hi @gnodet
Can you please look into the changes, and let us know if anything else is required from our side.
Seeing the package supporting the shared pointer would be a delight.

@gnodet  Is there any update regarding the progress of this activity?
Eagerly waiting for shared pointer support.

Hi @ossdev07 and @gnodet
As an Arm user, I have an interest in seeing this work landed. I've checked out the code, but it is unclear to me how to test. Can you advise how I can execute the test suite to test this functionality?
@gnodet please let me know if I can help with testing this PR

@rhenwood-arm  SHARED_PTR  is a FIELD FLAG
We added the support in a hawtJNI generator to parse this field and generate the corresponding JNI.
To test this flag we have defined a variable CheckStr  with the SHARED_PTR field flag,
We can see, when the hawtjni runs the test case, for variable CheckStr  JNI gets generated.
If you have any more queries, let me know. I will be more than to happy to explain it.

Thanks @ossdev07
One further question: what are the steps I need to go through to test this new functionality on a AArch64 machine?

@rhenwood-arm You just need to install all the dependencies and test the package
We can achieve it by the command  mvn install test
By this command, all the dependencies get to install, test cases get to run and we could see the result on console.

I'll try to review the PR this week.

Thanks @ossdev07. The self-test passes in my Java AArch64 container:
root@4066ed129600:/tmp/hawtjni# java --version
openjdk 11.0.2 2019-01-15
OpenJDK Runtime Environment (build 11.0.2+9-Debian-3bpo91)
OpenJDK 64-Bit Server VM (build 11.0.2+9-Debian-3bpo91, mixed mode)
root@4066ed129600:/tmp/hawtjni# uname -a
Linux 4066ed129600 4.10.0-38-generic #42~16.04.1-Ubuntu SMP Tue Oct 10 16:33:57 UTC 2017 aarch64 GNU/Linux
root@4066ed129600:/tmp/hawtjni# mvn clean test
.
.
.
[INFO] ------------------------------------------------------------------------
[INFO] Building HawtJNI Example 1.17-SNAPSHOT
[INFO] ------------------------------------------------------------------------
[INFO]
[INFO] --- maven-clean-plugin:3.0.0:clean (default-clean) @ hawtjni-example ---
[INFO] Deleting /tmp/hawtjni/hawtjni-example/target
[INFO]
[INFO] --- maven-resources-plugin:2.5:resources (default-resources) @ hawtjni-example ---
[debug] execute contextualize
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] skip non existing resourceDirectory /tmp/hawtjni/hawtjni-example/src/main/resources
[INFO]
[INFO] --- maven-compiler-plugin:3.6.1:compile (default-compile) @ hawtjni-example ---
[INFO] Changes detected - recompiling the module!
[INFO] Compiling 2 source files to /tmp/hawtjni/hawtjni-example/target/classes
[INFO]
[INFO] --- hawtjni-maven-plugin:1.17-SNAPSHOT:generate (default) @ hawtjni-example ---
[INFO] Analyzing classes...
[INFO] Generating...
[INFO] Wrote: /tmp/hawtjni/hawtjni-example/target/generated-sources/hawtjni/native-src/hawtjni-example.cpp
[INFO] Wrote: /tmp/hawtjni/hawtjni-example/target/generated-sources/hawtjni/native-src/hawtjni-example_stats.h
[INFO] Wrote: /tmp/hawtjni/hawtjni-example/target/generated-sources/hawtjni/native-src/hawtjni-example_stats.cpp
[INFO] Wrote: /tmp/hawtjni/hawtjni-example/target/generated-sources/hawtjni/native-src/hawtjni-example_structs.h
[INFO] Wrote: /tmp/hawtjni/hawtjni-example/target/generated-sources/hawtjni/native-src/hawtjni-example_structs.cpp
[INFO] Wrote: /tmp/hawtjni/hawtjni-example/target/generated-sources/hawtjni/native-src/hawtjni.h
[INFO] Wrote: /tmp/hawtjni/hawtjni-example/target/generated-sources/hawtjni/native-src/hawtjni.c
[INFO] Wrote: /tmp/hawtjni/hawtjni-example/target/generated-sources/hawtjni/native-src/hawtjni-callback.c
[INFO] Wrote: /tmp/hawtjni/hawtjni-example/target/generated-sources/hawtjni/native-src/windows/stdint.h
[INFO] Done.
[INFO] executing: /bin/sh -c ./autogen.sh
[INFO]
[INFO] --- hawtjni-maven-plugin:1.17-SNAPSHOT:build (default) @ hawtjni-example ---
[INFO] executing: /bin/sh -c ./configure --disable-ccache --prefix=/tmp/hawtjni/hawtjni-example/target/native-build/target --libdir=/tmp/hawtjni/hawtjni-example/target/native-build/target/lib
[INFO] executing: /bin/sh -c make install
[INFO] Adding test resource root: /tmp/hawtjni/hawtjni-example/target/generated-sources/hawtjni/lib
[INFO]
[INFO] --- maven-resources-plugin:2.5:testResources (default-testResources) @ hawtjni-example ---
[debug] execute contextualize
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] skip non existing resourceDirectory /tmp/hawtjni/hawtjni-example/src/test/resources
[INFO] Copying 1 resource
[INFO]
[INFO] --- maven-compiler-plugin:3.6.1:testCompile (default-testCompile) @ hawtjni-example ---
[INFO] Changes detected - recompiling the module!
[INFO] Compiling 1 source file to /tmp/hawtjni/hawtjni-example/target/test-classes
[INFO]
[INFO] --- maven-surefire-plugin:2.20:test (default-test) @ hawtjni-example ---
Downloading: https://repo.maven.apache.org/maven2/org/apache/maven/surefire/surefire-junit4/2.20/surefire-junit4-2.20.pom
Downloaded: https://repo.maven.apache.org/maven2/org/apache/maven/surefire/surefire-junit4/2.20/surefire-junit4-2.20.pom (4 KB at 4.6 KB/sec)
Downloading: https://repo.maven.apache.org/maven2/org/apache/maven/surefire/surefire-providers/2.20/surefire-providers-2.20.pom
Downloaded: https://repo.maven.apache.org/maven2/org/apache/maven/surefire/surefire-providers/2.20/surefire-providers-2.20.pom (3 KB at 132.2 KB/sec)
Downloading: https://repo.maven.apache.org/maven2/org/apache/maven/surefire/surefire-junit4/2.20/surefire-junit4-2.20.jar
Downloaded: https://repo.maven.apache.org/maven2/org/apache/maven/surefire/surefire-junit4/2.20/surefire-junit4-2.20.jar (81 KB at 758.6 KB/sec)
[INFO]
[INFO] -------------------------------------------------------
[INFO]  T E S T S
[INFO] -------------------------------------------------------
[INFO] Running test.ExampleTest
[INFO] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.24 s - in test.ExampleTest
[WARNING] Corrupted stdin stream in forked JVM 1. See the dump file /tmp/hawtjni/hawtjni-example/target/surefire-reports/2019-05-15T18-51-36_092-jvmRun1.dumpstream
[INFO]  the JNIEnv is at: 88010b40
[INFO]
[INFO] Results:
[INFO]
[INFO] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0
[INFO]
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] HawtJNI ............................................ SUCCESS [  0.228 s]
[INFO] HawtJNI Runtime .................................... SUCCESS [  5.061 s]
[INFO] HawtJNI Generator .................................. SUCCESS [  4.018 s]
[INFO] HawtJNI Maven Plugin ............................... SUCCESS [  5.343 s]
[INFO] HawtJNI Example .................................... SUCCESS [01:14 min]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 01:29 min
[INFO] Finished at: 2019-05-15T18:52:59+00:00
[INFO] Final Memory: 29M/560M
[INFO] ------------------------------------------------------------------------

@gnodet : have you had a chance to review this PR?

@gnodet Any update?

Any update on the comments ? I'd like to get rid of this PR.

Any update on the comments ? I'd like to get rid of this PR. @ossdev07

@gnodet please verify changes to support shared_ptr

@gnodet : have you had a chance to review this PR?

It does not seem to work for me:
[INFO] /bin/sh ./libtool  --tag=CXX   --mode=compile g++ -DHAVE_CONFIG_H -I. -I./src     -isysroot /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.14.sdk -arch x86_64 -arch i386 -g -O2 -I/usr/local/Cellar/adoptopenjdk-openjdk8/jdk8u172-b11/include -I/usr/local/Cellar/adoptopenjdk-openjdk8/jdk8u172-b11/include/darwin -c -o src/hawtjni-example_structs.lo src/hawtjni-example_structs.cpp
[INFO] libtool: compile:  g++ -DHAVE_CONFIG_H -I. -I./src -isysroot /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.14.sdk -arch x86_64 -arch i386 -g -O2 -I/usr/local/Cellar/adoptopenjdk-openjdk8/jdk8u172-b11/include -I/usr/local/Cellar/adoptopenjdk-openjdk8/jdk8u172-b11/include/darwin -c src/hawtjni-example_structs.cpp  -fno-common -DPIC -o src/.libs/hawtjni-example_structs.o
[INFO] src/hawtjni-example_structs.cpp:78:19: error: no matching function for call to 'make_shared'
[INFO]         set_sp(lpStruct, std::make_shared<intptr_t>(env->GetIntField(lpObject, barFc.CheckStr)));
[INFO]                          ^~~~~~~~~~~~~~~~~~~~~~~~~~
[INFO] /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/memory:4734:1: note: candidate function [with _Tp = long, _A0 = int] not viable: expects an l-value for 1st argument
[INFO] make_shared(_A0& __a0)
[INFO] ^
[INFO] /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/memory:4726:1: note: candidate function template not viable: requires 0 arguments, but 1 was provided
[INFO] make_shared()
[INFO] ^
[INFO] /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/memory:4742:1: note: candidate function template not viable: requires 2 arguments, but 1 was provided
[INFO] make_shared(_A0& __a0, _A1& __a1)
[INFO] ^
[INFO] /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/memory:4750:1: note: candidate function template not viable: requires 3 arguments, but 1 was provided
[INFO] make_shared(_A0& __a0, _A1& __a1, _A2& __a2)
[INFO] ^
[INFO] 1 error generated.
[INFO] make: *** [src/hawtjni-example_structs.lo] Error 1
[INFO] rc: 2

Also, the getter for the shared pointer is an int, shouldn't it be a shared_ptr somehow ?

Also, the getter for the shared pointer is an int, shouldn't it be a shared_ptr somehow ?

@gnodet
I was busy in some other assignment so sorry for late response ..
modification done as per your suggestions ..
please review ..

@ossdev07 this looks almost good to me but the example still fails to compile:
[INFO] src/foo.cpp:19:12: error: no viable conversion from returned value of type 'int' to function return type 'std::shared_ptr<intptr_t>' (aka 'shared_ptr<long>')
[INFO]     return 0;
[INFO]            ^

I think the return value needs to be changed to something else: https://github.com/fusesource/hawtjni/blob/44bb822466a1ae96bc2e406bc2766b6146d75d94/hawtjni-example/src/main/native-package/src/foo.cpp#L19

@ossdev07 this looks almost good to me but the example still fails to compile:
[INFO] src/foo.cpp:19:12: error: no viable conversion from returned value of type 'int' to function return type 'std::shared_ptr<intptr_t>' (aka 'shared_ptr<long>')
[INFO]     return 0;
[INFO]            ^

I think the return value needs to be changed to something else:
https://github.com/fusesource/hawtjni/blob/44bb822466a1ae96bc2e406bc2766b6146d75d94/hawtjni-example/src/main/native-package/src/foo.cpp#L19

In our setup it is always pass , can you tell me how are you testing means command
we ran "mvn clean install" and "mvn clean test" both are working properly

@ossdev07 this looks almost good to me but the example still fails to compile:
[INFO] src/foo.cpp:19:12: error: no viable conversion from returned value of type 'int' to function return type 'std::shared_ptr<intptr_t>' (aka 'shared_ptr<long>')
[INFO]     return 0;
[INFO]            ^

I think the return value needs to be changed to something else:
https://github.com/fusesource/hawtjni/blob/44bb822466a1ae96bc2e406bc2766b6146d75d94/hawtjni-example/src/main/native-package/src/foo.cpp#L19

In our setup it is always pass , can you tell me how are you testing means command
we ran "mvn clean install" and "mvn clean test" both are working properly

Just running mvn clean install.  I guess it depends on the native compiler somehow.
Here's a more complete log:
[INFO] ---------------< org.fusesource.hawtjni:hawtjni-example >---------------
[INFO] Building HawtJNI Example 1.18-SNAPSHOT                             [5/5]
[INFO] --------------------------------[ jar ]---------------------------------
[INFO]
[INFO] --- maven-clean-plugin:3.0.0:clean (default-clean) @ hawtjni-example ---
[INFO] Deleting /Users/gnodet/work/git/hawtjni/hawtjni-example/target
[INFO]
[INFO] --- maven-resources-plugin:2.5:resources (default-resources) @ hawtjni-example ---
[debug] execute contextualize
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] skip non existing resourceDirectory /Users/gnodet/work/git/hawtjni/hawtjni-example/src/main/resources
[INFO]
[INFO] --- maven-compiler-plugin:3.6.1:compile (default-compile) @ hawtjni-example ---
[INFO] Changes detected - recompiling the module!
[INFO] Compiling 2 source files to /Users/gnodet/work/git/hawtjni/hawtjni-example/target/classes
[INFO]
[INFO] --- hawtjni-maven-plugin:1.18-SNAPSHOT:generate (default) @ hawtjni-example ---
[INFO] Analyzing classes...
[INFO] Generating...
[INFO] Wrote: /Users/gnodet/work/git/hawtjni/hawtjni-example/target/generated-sources/hawtjni/native-src/hawtjni-example.cpp
[INFO] Wrote: /Users/gnodet/work/git/hawtjni/hawtjni-example/target/generated-sources/hawtjni/native-src/hawtjni-example_stats.h
[INFO] Wrote: /Users/gnodet/work/git/hawtjni/hawtjni-example/target/generated-sources/hawtjni/native-src/hawtjni-example_stats.cpp
[INFO] Wrote: /Users/gnodet/work/git/hawtjni/hawtjni-example/target/generated-sources/hawtjni/native-src/hawtjni-example_structs.h
[INFO] Wrote: /Users/gnodet/work/git/hawtjni/hawtjni-example/target/generated-sources/hawtjni/native-src/hawtjni-example_structs.cpp
[INFO] Wrote: /Users/gnodet/work/git/hawtjni/hawtjni-example/target/generated-sources/hawtjni/native-src/hawtjni.h
[INFO] Wrote: /Users/gnodet/work/git/hawtjni/hawtjni-example/target/generated-sources/hawtjni/native-src/hawtjni.c
[INFO] Wrote: /Users/gnodet/work/git/hawtjni/hawtjni-example/target/generated-sources/hawtjni/native-src/hawtjni-callback.c
[INFO] Wrote: /Users/gnodet/work/git/hawtjni/hawtjni-example/target/generated-sources/hawtjni/native-src/windows/stdint.h
[INFO] Done.
[INFO] executing: /bin/sh -c ./autogen.sh
[INFO]
[INFO] --- hawtjni-maven-plugin:1.18-SNAPSHOT:build (default) @ hawtjni-example ---
[INFO] executing: /bin/sh -c ./configure --disable-ccache --prefix=/Users/gnodet/work/git/hawtjni/hawtjni-example/target/native-build/target --libdir=/Users/gnodet/work/git/hawtjni/hawtjni-example/target/native-build/target/lib --with-universal
[INFO] executing: /bin/sh -c make install
[INFO] /bin/sh ./libtool  --tag=CXX   --mode=compile g++ -DHAVE_CONFIG_H -I. -I./src     -isysroot /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.15.sdk -arch x86_64 -arch i386 -g -O2 -I/Users/gnodet/.jenv/versions/1.8/include -I/Users/gnodet/.jenv/versions/1.8/include/darwin -c -o src/foo.lo src/foo.cpp
[INFO] libtool: compile:  g++ -DHAVE_CONFIG_H -I. -I./src -isysroot /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.15.sdk -arch x86_64 -arch i386 -g -O2 -I/Users/gnodet/.jenv/versions/1.8/include -I/Users/gnodet/.jenv/versions/1.8/include/darwin -c src/foo.cpp  -fno-common -DPIC -o src/.libs/foo.o
[INFO] In file included from src/foo.cpp:9:
[INFO] ./src/foo.h:42:27: warning: 'get_sp' has C-linkage specified, but returns incomplete type 'std::shared_ptr<intptr_t>' (aka 'shared_ptr<long>') which could be incompatible with C [-Wreturn-type-c-linkage]
[INFO] std::shared_ptr<intptr_t> get_sp(struct foo *arg);
[INFO]                           ^
[INFO] src/foo.cpp:19:12: error: no viable conversion from returned value of type 'int' to function return type 'std::shared_ptr<intptr_t>' (aka 'shared_ptr<long>')
[INFO]     return 0;
[INFO]            ^
[INFO] /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/../include/c++/v1/memory:3757:23: note: candidate constructor not viable: no known conversion from 'int' to 'std::__1::nullptr_t' for 1st argument
[INFO]     _LIBCPP_CONSTEXPR shared_ptr(nullptr_t) _NOEXCEPT;
[INFO]                       ^
[INFO] /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/../include/c++/v1/memory:3771:5: note: candidate constructor not viable: no known conversion from 'int' to 'const std::__1::shared_ptr<long> &' for 1st argument
[INFO]     shared_ptr(const shared_ptr& __r) _NOEXCEPT;
[INFO]     ^
[INFO] /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/../include/c++/v1/memory:3774:9: note: candidate template ignored: could not match 'shared_ptr<type-parameter-0-0>' against 'int'
[INFO]         shared_ptr(const shared_ptr<_Yp>& __r,
[INFO]         ^
[INFO] /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/../include/c++/v1/memory:3793:9: note: candidate template ignored: could not match 'auto_ptr<type-parameter-0-0>' against 'int'
[INFO]         shared_ptr(auto_ptr<_Yp> __r,
[INFO]         ^
[INFO] /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/../include/c++/v1/memory:3818:9: note: candidate template ignored: could not match 'unique_ptr<type-parameter-0-0, type-parameter-0-1>' against 'int'
[INFO]         shared_ptr(unique_ptr<_Yp, _Dp>,
[INFO]         ^
[INFO] /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/../include/c++/v1/memory:3827:9: note: candidate template ignored: could not match 'unique_ptr<type-parameter-0-0, type-parameter-0-1>' against 'int'
[INFO]         shared_ptr(unique_ptr<_Yp, _Dp>,
[INFO]         ^
[INFO] src/foo.cpp:25:141: error: cannot pass non-POD object of type 'std::shared_ptr<intptr_t>' (aka 'shared_ptr<long>') to variadic function; expected type from format string was 'int' [-Wnon-pod-varargs]
[INFO]     printf("foo@%p: { a: %d, b: %d, c: \"%s\", prev: @%p, d: %f, Checkstr: %d}\n", arg, arg->a, (int)arg->b, arg->c, arg->prev, get_d(arg), get_sp(arg));
[INFO]                                                                            ~~                                                               ^~~~~~~~~~~
[INFO] src/foo.cpp:52:46: warning: format specifies type 'unsigned int' but the argument has type 'JNIEnv *' (aka 'JNIEnv_ *') [-Wformat]
[INFO]    printf("%s, the JNIEnv is at: %x\n", who, env);
[INFO]                                  ~~          ^~~
[INFO] 2 warnings and 2 errors generated.
[INFO] make: *** [src/foo.lo] Error 1
[INFO] rc: 2
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary for HawtJNI 1.18-SNAPSHOT:
[INFO]
[INFO] HawtJNI ............................................ SUCCESS [  0.231 s]
[INFO] HawtJNI Runtime .................................... SUCCESS [  4.887 s]
[INFO] HawtJNI Generator .................................. SUCCESS [  1.431 s]
[INFO] HawtJNI Maven Plugin ............................... SUCCESS [  1.897 s]
[INFO] HawtJNI Example .................................... FAILURE [ 21.991 s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  30.772 s
[INFO] Finished at: 2019-11-14T09:42:09+01:00
[INFO] ------------------------------------------------------------------------

@ossdev07 this looks almost good to me but the example still fails to compile:
[INFO] src/foo.cpp:19:12: error: no viable conversion from returned value of type 'int' to function return type 'std::shared_ptr<intptr_t>' (aka 'shared_ptr<long>')
[INFO]     return 0;
[INFO]            ^

I think the return value needs to be changed to something else:
https://github.com/fusesource/hawtjni/blob/44bb822466a1ae96bc2e406bc2766b6146d75d94/hawtjni-example/src/main/native-package/src/foo.cpp#L19

In our setup it is always pass , can you tell me how are you testing means command
we ran "mvn clean install" and "mvn clean test" both are working properly

Just running mvn clean install. I guess it depends on the native compiler somehow.
Here's a more complete log:
[INFO] ---------------< org.fusesource.hawtjni:hawtjni-example >---------------
[INFO] Building HawtJNI Example 1.18-SNAPSHOT                             [5/5]
[INFO] --------------------------------[ jar ]---------------------------------
[INFO]
[INFO] --- maven-clean-plugin:3.0.0:clean (default-clean) @ hawtjni-example ---
[INFO] Deleting /Users/gnodet/work/git/hawtjni/hawtjni-example/target
[INFO]
[INFO] --- maven-resources-plugin:2.5:resources (default-resources) @ hawtjni-example ---
[debug] execute contextualize
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] skip non existing resourceDirectory /Users/gnodet/work/git/hawtjni/hawtjni-example/src/main/resources
[INFO]
[INFO] --- maven-compiler-plugin:3.6.1:compile (default-compile) @ hawtjni-example ---
[INFO] Changes detected - recompiling the module!
[INFO] Compiling 2 source files to /Users/gnodet/work/git/hawtjni/hawtjni-example/target/classes
[INFO]
[INFO] --- hawtjni-maven-plugin:1.18-SNAPSHOT:generate (default) @ hawtjni-example ---
[INFO] Analyzing classes...
[INFO] Generating...
[INFO] Wrote: /Users/gnodet/work/git/hawtjni/hawtjni-example/target/generated-sources/hawtjni/native-src/hawtjni-example.cpp
[INFO] Wrote: /Users/gnodet/work/git/hawtjni/hawtjni-example/target/generated-sources/hawtjni/native-src/hawtjni-example_stats.h
[INFO] Wrote: /Users/gnodet/work/git/hawtjni/hawtjni-example/target/generated-sources/hawtjni/native-src/hawtjni-example_stats.cpp
[INFO] Wrote: /Users/gnodet/work/git/hawtjni/hawtjni-example/target/generated-sources/hawtjni/native-src/hawtjni-example_structs.h
[INFO] Wrote: /Users/gnodet/work/git/hawtjni/hawtjni-example/target/generated-sources/hawtjni/native-src/hawtjni-example_structs.cpp
[INFO] Wrote: /Users/gnodet/work/git/hawtjni/hawtjni-example/target/generated-sources/hawtjni/native-src/hawtjni.h
[INFO] Wrote: /Users/gnodet/work/git/hawtjni/hawtjni-example/target/generated-sources/hawtjni/native-src/hawtjni.c
[INFO] Wrote: /Users/gnodet/work/git/hawtjni/hawtjni-example/target/generated-sources/hawtjni/native-src/hawtjni-callback.c
[INFO] Wrote: /Users/gnodet/work/git/hawtjni/hawtjni-example/target/generated-sources/hawtjni/native-src/windows/stdint.h
[INFO] Done.
[INFO] executing: /bin/sh -c ./autogen.sh
[INFO]
[INFO] --- hawtjni-maven-plugin:1.18-SNAPSHOT:build (default) @ hawtjni-example ---
[INFO] executing: /bin/sh -c ./configure --disable-ccache --prefix=/Users/gnodet/work/git/hawtjni/hawtjni-example/target/native-build/target --libdir=/Users/gnodet/work/git/hawtjni/hawtjni-example/target/native-build/target/lib --with-universal
[INFO] executing: /bin/sh -c make install
[INFO] /bin/sh ./libtool  --tag=CXX   --mode=compile g++ -DHAVE_CONFIG_H -I. -I./src     -isysroot /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.15.sdk -arch x86_64 -arch i386 -g -O2 -I/Users/gnodet/.jenv/versions/1.8/include -I/Users/gnodet/.jenv/versions/1.8/include/darwin -c -o src/foo.lo src/foo.cpp
[INFO] libtool: compile:  g++ -DHAVE_CONFIG_H -I. -I./src -isysroot /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.15.sdk -arch x86_64 -arch i386 -g -O2 -I/Users/gnodet/.jenv/versions/1.8/include -I/Users/gnodet/.jenv/versions/1.8/include/darwin -c src/foo.cpp  -fno-common -DPIC -o src/.libs/foo.o
[INFO] In file included from src/foo.cpp:9:
[INFO] ./src/foo.h:42:27: warning: 'get_sp' has C-linkage specified, but returns incomplete type 'std::shared_ptr<intptr_t>' (aka 'shared_ptr<long>') which could be incompatible with C [-Wreturn-type-c-linkage]
[INFO] std::shared_ptr<intptr_t> get_sp(struct foo *arg);
[INFO]                           ^
[INFO] src/foo.cpp:19:12: error: no viable conversion from returned value of type 'int' to function return type 'std::shared_ptr<intptr_t>' (aka 'shared_ptr<long>')
[INFO]     return 0;
[INFO]            ^
[INFO] /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/../include/c++/v1/memory:3757:23: note: candidate constructor not viable: no known conversion from 'int' to 'std::__1::nullptr_t' for 1st argument
[INFO]     _LIBCPP_CONSTEXPR shared_ptr(nullptr_t) _NOEXCEPT;
[INFO]                       ^
[INFO] /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/../include/c++/v1/memory:3771:5: note: candidate constructor not viable: no known conversion from 'int' to 'const std::__1::shared_ptr<long> &' for 1st argument
[INFO]     shared_ptr(const shared_ptr& __r) _NOEXCEPT;
[INFO]     ^
[INFO] /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/../include/c++/v1/memory:3774:9: note: candidate template ignored: could not match 'shared_ptr<type-parameter-0-0>' against 'int'
[INFO]         shared_ptr(const shared_ptr<_Yp>& __r,
[INFO]         ^
[INFO] /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/../include/c++/v1/memory:3793:9: note: candidate template ignored: could not match 'auto_ptr<type-parameter-0-0>' against 'int'
[INFO]         shared_ptr(auto_ptr<_Yp> __r,
[INFO]         ^
[INFO] /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/../include/c++/v1/memory:3818:9: note: candidate template ignored: could not match 'unique_ptr<type-parameter-0-0, type-parameter-0-1>' against 'int'
[INFO]         shared_ptr(unique_ptr<_Yp, _Dp>,
[INFO]         ^
[INFO] /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/../include/c++/v1/memory:3827:9: note: candidate template ignored: could not match 'unique_ptr<type-parameter-0-0, type-parameter-0-1>' against 'int'
[INFO]         shared_ptr(unique_ptr<_Yp, _Dp>,
[INFO]         ^
[INFO] src/foo.cpp:25:141: error: cannot pass non-POD object of type 'std::shared_ptr<intptr_t>' (aka 'shared_ptr<long>') to variadic function; expected type from format string was 'int' [-Wnon-pod-varargs]
[INFO]     printf("foo@%p: { a: %d, b: %d, c: \"%s\", prev: @%p, d: %f, Checkstr: %d}\n", arg, arg->a, (int)arg->b, arg->c, arg->prev, get_d(arg), get_sp(arg));
[INFO]                                                                            ~~                                                               ^~~~~~~~~~~
[INFO] src/foo.cpp:52:46: warning: format specifies type 'unsigned int' but the argument has type 'JNIEnv *' (aka 'JNIEnv_ *') [-Wformat]
[INFO]    printf("%s, the JNIEnv is at: %x\n", who, env);
[INFO]                                  ~~          ^~~
[INFO] 2 warnings and 2 errors generated.
[INFO] make: *** [src/foo.lo] Error 1
[INFO] rc: 2
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary for HawtJNI 1.18-SNAPSHOT:
[INFO]
[INFO] HawtJNI ............................................ SUCCESS [  0.231 s]
[INFO] HawtJNI Runtime .................................... SUCCESS [  4.887 s]
[INFO] HawtJNI Generator .................................. SUCCESS [  1.431 s]
[INFO] HawtJNI Maven Plugin ............................... SUCCESS [  1.897 s]
[INFO] HawtJNI Example .................................... FAILURE [ 21.991 s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  30.772 s
[INFO] Finished at: 2019-11-14T09:42:09+01:00
[INFO] ------------------------------------------------------------------------

I checked in 3 different systems and its getting passed , i think it's because of some compilation settings, my systems has default configurations of compilation flags ..

[INFO] executing: /bin/sh -c ./configure --disable-ccache --prefix=/Users/gnodet/work/git/hawtjni/hawtjni-example/target/native-build/target --libdir=/Users/gnodet/work/git/hawtjni/hawtjni-example/target/native-build/target/lib --with-universal

I found one difference in your setup is  "--with-universal" flag in configure command ..
[INFO] executing: /bin/sh -c ./configure --disable-ccache --prefix=/Users/gnodet/work/git/hawtjni/hawtjni-example/target/native-build/target --libdir=/Users/gnodet/work/git/hawtjni/hawtjni-example/target/native-build/target/lib --with-universal

My C++ compiler seems to be more strict.  Any way you could improve the example to not return 0, but use real getters / setters to access a shared pointer ? That would give me some confidence that this thing is actually working...
also, if that's still related to https://github.com/fusesource/rocksdbjni/pull/10 and if that's the only driver for supporting shared pointers, you may really want to investigate the RocksDB JNI layer provided by rocksdb directly.

Hi gnodet,
We have made changes as per your review comments and now we are returning non-zero value (i.e. shared_ptr)
We modified code generation kept noted that java doesn't know pointer and shared_ptr. Java deals with variables/objects only.
Please refer to latest commit at this pull request 57

@gnodet it's long pending PR almost chasing for last 1 year, Please have a look on modifications.
thank you for your support

@gnodet require your further review for this change.

Hi @gnodet
We have made changes as per your review comments and now we are returning non-zero value (i.e. shared_ptr)
We modified code generation kept noted that java doesn't know pointer and shared_ptr. Java deals with variables/objects only.
Please refer to latest commit at this pull request 57

@gnodet require your further review for this change.

Hi @gnodet
We have made changes as per your review comments and now we are returning non-zero value (i.e. shared_ptr)
We modified code generation kept noted that java doesn't know pointer and shared_ptr. Java deals with variables/objects only.
Please refer to latest commit at this pull request 57

@gnodet , Require your review and valuable suggestions. Thanks.

After having fixed a bunch of issues in the example (see https://github.com/gnodet/hawtjni/commits/ossdev07-shared_ptr_support), the compiler still does not build: there's a conversion error in the generated native code:
[INFO] --- hawtjni-maven-plugin:1.18-SNAPSHOT:build (default) @ hawtjni-example ---
[INFO] executing: /bin/sh -c ./configure --disable-ccache --prefix=/Users/gnodet/work/git/hawtjni/hawtjni-example/target/native-build/target --libdir=/Users/gnodet/work/git/hawtjni/hawtjni-example/target/native-build/target/lib --with-universal
[INFO] executing: /bin/sh -c make install
[INFO] /bin/sh ./libtool  --tag=CXX   --mode=compile g++ -DHAVE_CONFIG_H -I. -I./src    -std=gnu++11 -isysroot /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.15.sdk -arch x86_64 -arch i386 -g -O2 -I/Users/gnodet/.jenv/versions/1.8/include -I/Users/gnodet/.jenv/versions/1.8/include/darwin -c -o src/foo.lo src/foo.cpp
[INFO] libtool: compile:  g++ -DHAVE_CONFIG_H -I. -I./src -std=gnu++11 -isysroot /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.15.sdk -arch x86_64 -arch i386 -g -O2 -I/Users/gnodet/.jenv/versions/1.8/include -I/Users/gnodet/.jenv/versions/1.8/include/darwin -c src/foo.cpp  -fno-common -DPIC -o src/.libs/foo.o
[INFO] /bin/sh ./libtool  --tag=CXX   --mode=compile g++ -DHAVE_CONFIG_H -I. -I./src    -std=gnu++11 -isysroot /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.15.sdk -arch x86_64 -arch i386 -g -O2 -I/Users/gnodet/.jenv/versions/1.8/include -I/Users/gnodet/.jenv/versions/1.8/include/darwin -c -o src/hawtjni-example_structs.lo src/hawtjni-example_structs.cpp
[INFO] libtool: compile:  g++ -DHAVE_CONFIG_H -I. -I./src -std=gnu++11 -isysroot /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.15.sdk -arch x86_64 -arch i386 -g -O2 -I/Users/gnodet/.jenv/versions/1.8/include -I/Users/gnodet/.jenv/versions/1.8/include/darwin -c src/hawtjni-example_structs.cpp  -fno-common -DPIC -o src/.libs/hawtjni-example_structs.o
[INFO] src/hawtjni-example_structs.cpp:78:2: error: no matching function for call to 'set_sp'
[INFO]         set_sp(lpStruct, std::make_shared<jlong>(env->GetLongField(lpObject, barFc.CheckStr)));
[INFO]         ^~~~~~
[INFO] ./src/foo.h:61:6: note: candidate function not viable: no known conversion from 'shared_ptr<long long>' to 'shared_ptr<intptr_t>' for 2nd argument
[INFO] void set_sp(struct foo *arg, std::shared_ptr<intptr_t>);
[INFO]      ^
[INFO] 1 error generated.
[INFO] make: *** [src/hawtjni-example_structs.lo] Error 1
[INFO] rc: 2

Hi @gnodet
Thanks for your review and build attempt.
However I am unable to reproduce above issue at my system.
I tried our branch and your branch, here both reported success for command mvn clean install. (Refer my log here)
If you think, this could be due to any environmental change, then please suggest me how can I reproduce the same...
Could this build difference be due to compiler version/flag difference (like using more strict/advance compiler) ?

I'm on OSX. I've been able to build the branch by switching to a recent gcc version instead of using the one that comes by default with OSX.

I'm on OSX. I've been able to build the branch by switching to a recent gcc version instead of using the one that comes by default with OSX.

Well, I can't make it succeed again :-( I'll investigate.

Hi @gnodet
If review of my system environment info suggests anything regarding this:
ubuntu@1pthunderx1-137:~$ g++ --version
g++ (Ubuntu/Linaro 8.4.0-1ubuntu1~18.04) 8.4.0
Copyright (C) 2018 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.  There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

ubuntu@1pthunderx1-137:~$ ldd --version
ldd (Ubuntu GLIBC 2.29-0ubuntu2) 2.29
Copyright (C) 2019 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.  There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
Written by Roland McGrath and Ulrich Drepper.

ubuntu@1pthunderx1-137:~$ env
SHELL=/bin/bash
rvm_prefix=/home/ubuntu
JAVA_HOME=/usr/lib/jvm/java-8-openjdk-arm64
GRADLE_HOME=/opt/gradle/gradle-5.0
MY_RUBY_HOME=/home/ubuntu/.rvm/rubies/ruby-2.6.3
ANT_HOME=/usr/local/ant
RUBY_VERSION=ruby-2.6.3
PWD=/home/ubuntu
LOGNAME=ubuntu
XDG_SESSION_TYPE=tty
rvm_version=1.29.9 (latest)
HOME=/home/ubuntu
LANG=en_US.UTF-8
rvm_bin_path=/home/ubuntu/.rvm/bin
GEM_PATH=/home/ubuntu/.rvm/gems/ruby-2.6.3:/home/ubuntu/.rvm/gems/ruby-2.6.3@global
GEM_HOME=/home/ubuntu/.rvm/gems/ruby-2.6.3
XDG_SESSION_CLASS=user
TERM=xterm
LIBVIRT_DEFAULT_URI=qemu:///system
USER=ubuntu
SHLVL=1
XDG_RUNTIME_DIR=/run/user/1000
S_COLORS=auto
XDG_DATA_DIRS=/usr/local/share:/usr/share:/var/lib/snapd/desktop
PATH=/home/ubuntu/.rvm/gems/ruby-2.6.3/bin:/home/ubuntu/.rvm/gems/ruby-2.6.3@global/bin:/home/ubuntu/.rvm/rubies/ruby-2.6.3/bin:/usr/lib/jvm/java-8-openjdk-arm64/bin:/opt/gradle/gradle-5.0/bin:/usr/local/ant/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/games:/usr/local/games:/snap/bin:/snap/bin:/var/lib/snapd/snap/bin:/home/ubuntu/.rvm/bin
DBUS_SESSION_BUS_ADDRESS=unix:path=/run/user/1000/bus
MAIL=/var/mail/ubuntu
SSH_TTY=/dev/pts/12
IRBRC=/home/ubuntu/.rvm/rubies/ruby-2.6.3/.irbrc
rvm_path=/home/ubuntu/.rvm
_=/usr/bin/env

I have not removed non-required info as well.
If you require any more environment detail, then also please let me know.
Thanks.

on Mac, I'm getting the same error as @gnodet and really can't understand why this would have been closed. What was the solution?

on Mac, I'm getting the same error as @gnodet and really can't understand why this would have been closed. What was the solution?

I think I had to upgrade Xcode iirc.


chore: upgrade Azure File CSI driver to v1.24.1

What type of PR is this?
/kind cleanup
/kind feature
What this PR does / why we need it:
chore: upgrade Azure File CSI driver to v1.24.1
This PR also removed some unused images
Which issue(s) this PR fixes:

Fixes #
Requirements:

[x] uses conventional commit messages

[ ] includes documentation
[ ] adds unit tests
[ ] tested upgrade from previous version

Special notes for your reviewer:
Release note:
none

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 61.836%

Totals

Change from base Build<PHONE_NUMBER>:
0%

Covered Lines:
2526

Relevant Lines:
4085

💛  - Coveralls

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Warning: This coverage report may be inaccurate.
This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

For more information on this, see Tracking coverage changes with pull request builds.
To avoid this issue with future PRs, see these Recommended CI Configurations.
For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall first build on andyzhangx/upgrade-azurefile-1.24.1 at 61.913%

Totals

Change from base Build<PHONE_NUMBER>:
61.9%

Covered Lines:
2531

Relevant Lines:
4088

💛  - Coveralls


About WebRTC

Excuse me (I' m from Taiwan ,so please don't mind my poor english..)
First,thanks your component, It is very good!
When I try to open Demo ALLiveVideoChat and run to ios Device
and has error "[DCC Error] E2597 ld: warning: directory not found for option '-LC:\Dev\Alcinoe\demos\ALLiveVideoChat\client_source\ios\frameworks\WebRTC.framework'
ld: file not found: WebRTC"
I know Its need to install framework from "\lib\ios\webrtc"
But I dont understand how to install
Can anyone help me ? Thank you  and have good time

Hi lewis. everything is explained in {Alcinoe_rootdir}\lib\ios\webrtc\readme.txt
The framework must be signed with the same team identifier in the main executable code signature.
The team identifier is the 10-character alphanumeric string, such as YH9SZ5LKR4, associated with your developer account,
and recorded in your Apple-issued signing certificate.
You must do this manually still embarcadero implement it
https://quality.embarcadero.com/browse/RSP-22899
codesign -s  /YourPathto/WebRTC.framework/WebRTC
After you need to deploy yourself the WebRTC.framework in the .\Frameworks\WebRTC.framework
file to deploy:
Info.plist
LICENSE.md
WebRTC
_CodeSignature\CodeResources
Stripping Unwanted Architectures From WebRTC
http://ikennd.ac/blog/2015/02/stripping-unwanted-architectures-from-dynamic-libraries-in-xcode/
lipo -info /YourPathto/WebRTC.framework/WebRTC
lipo -remove i386 /YourPathto/WebRTC.framework/WebRTC -o /YourPathto/WebRTC.framework/WebRTC
lipo -remove x86_64 /YourPathto/WebRTC.framework/WebRTC -o /YourPathto/WebRTC.framework/WebRTC
lipo -info /YourPathto/WebRTC.framework/WebRTC


Any way to identify an Active element?

I would like to do something similar to:
1 - click on username field
2 - assert username is currently focused on
Is this possible? I tried driver.switch_to.active_element but it does not seem to work with flutter elements.

It could if https://api.flutter.dev/flutter/flutter_driver/flutter_driver-library.html had since this flutter context depends on the library.
Or you may be able to do via NATIVE_APP context (then, via uia2 or xcuitest driver). If the element is exposed to the OS's accessibility features, it may work

Thank you @KazuCocoa, unfortunately trying to use Native also did not work, since the focused element displays focused="false" in the native page tree. Must be a custom Flutter implementation to show what is selected on screen. I will close this question.


Malformed metadata in requests should not trigger a client-side assertion error

I've observed that sending an RPC with an invalid metadata triggers an assertion error in the C++ client implementation, causing applications to crash. In our case this crashes a gRPC server that is proxying data passed from a non-gRPC client to another gRPC backend.
Demo:
absl::StatusOr<std::unique_ptr<MyService::Stub>> stub = ...;
grpc::ClientContext context;
context.AddMetadata("foo", "ba⋄r");
auto status = stub.value()->Hello(&context, request, &response);
if (!status.ok()) {
  std::cerr << "Request failed!: " << stub.status() << std::endl;
} else {
  std::cout << response.greeting() << std::endl;
}

I expected to see this request fail with an invalid status, but instead an error is logged and the application exits:
E1025 15:33:32.069022103  133403 call.cc:840]                validate_metadata: UNKNOWN:Illegal header value {file:"external/com_github_grpc_grpc/src/core/lib/surface/validate_metadata.cc", file_line:44, created_time:"2023-10-25T15:33:32.068557055-07:00", offset:2, raw_bytes:"62 61 e2 8b 84 72 \'ba...r\'\x00"}
E1025 15:33:32.069061311  133403 call_op_set.h:985]          assertion failed: false

The referenced lines in call.cc and call_op_set.h (which are still present at head; call.cc, call_op_set.h) say this "indicates an API misuse", but I do not feel crashing is the appropriate response to this sort of misuse.
In particular, I do not see a supported API for actually validating the arguments you intend to pass as metadata keys/values. Ideally AddMetadata() would return a Status, but assuming that ship has sailed there should be an IsValidMetadata() function or similar to check the arguments prior to hitting this assertion. So even if crashing is necessary at this point there's no reasonable way for a caller to actually detect this case short of re-implementing the validations in the gRPC internals (which aren't complicated, but duplicating them is still tedious).

@yashykt IMO this is a bug report, not an enhancement request. A malformed outbound request should not crash the application.

I think the reason I called this a feature request instead of a bug is because given that we cannot modify the existing function signatures without making breaking changes, we need to expose a method to help verify that the metadata is acceptable.

Why is an API change necessary? IMO the right fix is to fail the RPC instead of crashing, which doesn't require any changes.

That is an interesting suggestion. I think we should dig into that and adopt that approach if feasible. (Doing the same thing wouldn't work on the server side though.)
@ctiller thoughts?

We've considered this in the past in some other contexts and arrived at a
similar conclusion: it would be better to fail the rpc rather than crash
(and I think we could on the server too).
On Tue, Jan 23, 2024, 12:57 PM Yash Tibrewal @.***>
wrote:

That is an interesting suggestion. I think we should dig into that and
adopt that approach if feasible. (Doing the same thing wouldn't work on the
server side though.)
@ctiller https://github.com/ctiller thoughts?
—
Reply to this email directly, view it on GitHub
https://github.com/grpc/grpc/issues/34798#issuecomment-1906906186, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/ACNG45KAV2LXDHLZBJNCVXLYQAP3RAVCNFSM6AAAAAA6QDZCHWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMBWHEYDMMJYGY
.
You are receiving this because you were mentioned.Message ID:
@.***>

Alright, then I think we have a plan. I'm less sure on the server side behavior but maybe with the right error status/message, it'll be fine.

Recently we run into the exact same issue both in server and client side. Any idea when will this be implemented? Thx.


instruction for Jekyll

I tried to use staticman-netlify-function with Jekyll on Netlify. The function fails to build.
I tried to replace yarn --production with npm install in the post install command. The build process starts but gets stack at:
yarn build
2:22:11 PM: [DEPRECATION] The trollop gem has been renamed to optimist and will no longer be supported. Please switch to optimist as soon as possible.

Then Netlify kills it because of the build time limit.
Please, try to build from this test repo on Netlify to reproduce the problem: https://github.com/avglinux/avgt

Hi @evodify!
I primarily built statesman-netlify-function to work with Gatsby or other node based static site generators. So following the instructions might actually break your project's build process. I believe netlify automatically figures out the project type based on the files in the repo and placing the config files I have provided might interfere with that.
That said in your case, you can get rid of the root package.json and instead modify the build section of netlify.toml to be
[build]
  publish = "_site"
  command = "jekyll build && cd functions/staticman && npm install"

I adapted this config from a jekyll config I found online (https://github.com/algolia/jekyll-algolia-example/blob/master/netlify.toml) you might need to set publish to the folder where the final files are generated and adjust the Jekyll build command to what you use.
Let me know if that helps. (also post the entire log output from netlify, the sample you provided doesn't show anything out of the ordinary)

Hi @evodify!
I primarily built statesman-netlify-function to work with Gatsby or other node based static site generators. So following the instructions might actually break your project's build process. I believe netlify automatically figures out the project type based on the files in the repo and placing the config files I have provided might interfere with that.
That said in your case, you can get rid of the root package.json and instead modify the build section of netlify.toml to be
[build]
  publish = "_site"
  command = "jekyll build && cd functions/staticman && npm install"

I adapted this config from a jekyll config I found online (https://github.com/algolia/jekyll-algolia-example/blob/master/netlify.toml) you might need to set publish to the folder where the final files are generated and adjust the Jekyll build command to what you use.
Let me know if that helps. (also post the entire log output from netlify, the sample you provided doesn't show anything out of the ordinary)

Thanks for your help!
It did not work with your functions/staticman files, but I was able to build it with the official code and the build command you provided.
However, it doesn't work. I assume it requires some code modification to run on Netlify. I see the error staticman.handler is undefined or not exported when I submit a comment.
I also added GITHUB_TOKEN and RSA_PRIVATE_KEY in Settings > Build & deploy > Environment > Environment variables on Netlify.
I will stick with Heroku deployment for now and may get back to Netlify functions later.
Thanks again for your time.

Thanks for your help!
It did not work with your functions/staticman files, but I was able to build it with the official code and the build command you provided.
However, it doesn't work. I assume it requires some code modification to run on Netlify. I see the error staticman.handler is undefined or not exported when I submit a comment.
I also added GITHUB_TOKEN and RSA_PRIVATE_KEY in Settings > Build & deploy > Environment > Environment variables on Netlify.
I will stick with Heroku deployment for now and may get back to Netlify functions later.
Thanks again for your time.


⚠ SkyfallMC Minecraft Server has degraded performance

In 7646dc3, SkyfallMC Minecraft Server (play.skyfallmc.ga) experienced degraded performance:

HTTP code: 200
Response time: 1107 ms

Resolved: SkyfallMC Minecraft Server performance has improved in c108ece.


invoke all commands in shell

we already run commands defined by users - it's gonna be more convenient for them
to do ls *.tar.gz instead of bash -c "ls *.tar.gz"
and we have the sandbox to minimize the damage

Fixes #692

I have to change the implementation signifficantly, please re-review.

recheck


failed: listen tcp4 <IP_ADDRESS>:5001: bind: address already in use

👉 Please describe what you were doing when this error happened.
Specifications

OS: linux
IPFS Desktop Version: 0.22.0
Electron Version: 19.0.8
Chrome Version: 102.0.5005.148

Error
Error: Initializing daemon...
Kubo version: 0.14.0
Repo version: 12
System version: amd64/linux
Golang version: go1.18.3
2022/07/26 11:07:10 failed to sufficiently increase receive buffer size (was: 208 kiB, wanted: 2048 kiB, got: 416 kiB). See https://github.com/lucas-clemente/quic-go/wiki/UDP-Receive-Buffer-Size for details.
Swarm listening on /ip4/<IP_ADDRESS>/tcp/4001
Swarm listening on /ip4/<IP_ADDRESS>/tcp/4001
Swarm listening on /ip4/<IP_ADDRESS>/tcp/4001
Swarm listening on /ip4/<IP_ADDRESS>/tcp/4001
Swarm listening on /ip4/<IP_ADDRESS>/tcp/4001
Swarm listening on /ip4/<IP_ADDRESS>/tcp/4001
Swarm listening on /ip4/<IP_ADDRESS>/tcp/4001
Swarm listening on /ip6/::1/tcp/4001
Swarm listening on /p2p-circuit
Swarm announcing /ip4/<IP_ADDRESS>/tcp/4001
Swarm announcing /ip4/<IP_ADDRESS>/tcp/4001
Swarm announcing /ip6/::1/tcp/4001

Error: serveHTTPApi: manet.Listen(/ip4/<IP_ADDRESS>/tcp/5001) failed: listen tcp4 <IP_ADDRESS>:5001: bind: address already in use

    at errorTemplate (/opt/IPFS Desktop/resources/app.asar/src/daemon/migration-prompt.js:78:49)
    at loadWindow (/opt/IPFS Desktop/resources/app.asar/src/daemon/migration-prompt.js:115:26)
    at module.exports (/opt/IPFS Desktop/resources/app.asar/src/daemon/migration-prompt.js:120:3)
    a

Hi @ankurpython,
It seems that IPFS Desktop failed to detect that something was already running on 5001, or it did and you chose not to change the ports. The error is clear, there is something running on port 5001. Do you perhaps know what it is?
I see you're on Linux, so if you run:
sudo netstat -tulpn | grep LISTEN | grep 5001

You can see whatever process is running on that port.

@lidel as per our discussion yesterday, I checked if the workflow for detecting the busy ports is working correctly and it seems to be working well on both macOS and Windows. Could you check if it works well on your Linux distro? It may be an issue with Linux in general, or a specific distribution.

@hacdias how did you test?
I've shut down IPFS node and run unrelated HTTP server on port 5001 via
$ npx serve -l 5001 -d

Then I started ./ipfs-desktop-0.22.0-linux-x86_64.AppImage and it failed silently like this:
$ ./ipfs-desktop-0.22.0-linux-x86_64.AppImage
2022-08-15T16:49:43.774Z info: [meta] logs can be found on /home/lidel/.config/IPFS Desktop
2022-08-15T16:49:44.980Z info: [web ui] loading STARTED
2022-08-15T16:49:45.637Z info: [App] startup time - 2.0857269892692565 seconds
2022-08-15T16:49:45.639Z info: [web ui] loading FINISHED 0.6585600352287293s
2022-08-15T16:49:45.655Z info: [web ui] window ready
2022-08-15T16:49:45.656Z info: [web ui] navigate to /
Checking for update
2022-08-15T16:49:45.662Z info: [tray] starting
2022-08-15T16:49:45.717Z info: [tray] started
2022-08-15T16:49:45.718Z info: [ipfsd] start daemon STARTED
2022-08-15T16:49:45.796Z error: [ipfsd] start daemon HTTPError: <!DOCTYPE html> <meta name="viewport" content="width=device-width, initial-scale=1, user-scalable=no"/>
 404
The requested path could not be found

    at Object.errorHandler [as handleError] (/tmp/.mount_ipfs-d4EwGbi/resources/app.asar/node_modules/ipfs-http-client/cjs/src/lib/core.js:84:15)
    at process.processTicksAndRejections (node:internal/process/task_queues:96:5)
    at async Client.fetch (/tmp/.mount_ipfs-d4EwGbi/resources/app.asar/node_modules/ipfs-utils/src/http.js:145:9)
    at async Object.id (/tmp/.mount_ipfs-d4EwGbi/resources/app.asar/node_modules/ipfs-http-client/cjs/src/id.js:12:17)
    at async Daemon.start (/tmp/.mount_ipfs-d4EwGbi/resources/app.asar/node_modules/ipfsd-ctl/src/ipfsd-daemon.js:268:16)
    at async startIpfsWithLogs (/tmp/.mount_ipfs-d4EwGbi/resources/app.asar/src/daemon/daemon.js:144:5)
    at async module.exports (/tmp/.mount_ipfs-d4EwGbi/resources/app.asar/src/daemon/daemon.js:194:17)
    at async startIpfs (/tmp/.mount_ipfs-d4EwGbi/resources/app.asar/src/daemon/index.js:47:17)
    at async module.exports (/tmp/.mount_ipfs-d4EwGbi/resources/app.asar/src/daemon/index.js:115:3)
    at async run (/tmp/.mount_ipfs-d4EwGbi/resources/app.asar/src/index.js:84:5)
2022-08-15T16:49:45.815Z info: [automatic gc] enabled
2022-08-15T16:49:45.816Z info: [pubsub] disabled
2022-08-15T16:49:45.816Z info: [ipns over pubsub] disabled
2022-08-15T16:49:45.820Z info: [launch on startup] disabled
[31913:0815/184946.096041:ERROR:browser_main_loop.cc(271)] Gdk: gdk_window_thaw_toplevel_updates: assertion 'window->update_and_descendants_freeze_count > 0' failed
Update for version 0.22.0 is not available (latest version: 0.22.0, downgrade is disallowed).
2022-08-15T16:49:46.651Z info: [updater] update not available
2022-08-15T16:50:16.169Z info: [web ui] window hidden
^C

No GUI informing user about port being taken, just webui in broken state:

@lidel that is exactly what I did (albeit I used caddy instead of npx serve). I followed your steps on macOS and Windows and it works as expected.

Seems like we need to do some debugging in Linux

@lidel is OOO this week so this will probably be delayed until he gets back


knife solo cook doesnt find chef installed by knife solo prepare

the package installed by solo prepare ( chef/now 16.10.17-1 amd64  )  installs the chef binary to /opt/chef/bin,
which is not in PATH.
but even after adding it to PATH using /etc/profile , it won't find it, likely knife isnt using a n interactive shell
so i tried adding it to  bashrc (dangerous) but that also wont work
the next problem is that the awk is wrong because --version says "Chef Infra Client: 16.10.17" while awk matches "Chef:"
this is Ubuntu 20.10
$ knife solo prepare<EMAIL_ADDRESS>Bootstrapping Chef...
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100 23393  100 23393    0     0  25262      0 --:--:-- --:--:-- --:--:-- 25235
ubuntu 20.10 x86_64
Getting information for chef stable 16.10.17 for ubuntu...
downloading https://omnitruck-direct.chef.io/stable/chef/metadata?v=16.10.17&p=ubuntu&pv=20.10&m=x86_64
  to file /tmp/install.sh.7015/metadata.txt
trying wget...
sha1	32516ce8fe7ba09ea96d1e32e7f64087338a3b48
sha256	156057bb0a39b73a9abc2ea940b38210dcf02da4a1b5a461bff3e714a290cc02
url	https://packages.chef.io/files/stable/chef/16.10.17/ubuntu/20.04/chef_16.10.17-1_amd64.deb
version	16.10.17
downloaded metadata file looks valid...
downloading https://packages.chef.io/files/stable/chef/16.10.17/ubuntu/20.04/chef_16.10.17-1_amd64.deb
  to file /tmp/install.sh.7015/chef_16.10.17-1_amd64.deb
trying wget...
Comparing checksum with sha256sum...
Installing chef 16.10.17
installing with dpkg...
(Reading database ... 63434 files and directories currently installed.)
Preparing to unpack .../chef_16.10.17-1_amd64.deb ...
removing /opt/chef...
Unpacking chef (16.10.17-1) over (16.10.17-1) ...
Setting up chef (16.10.17-1) ...
Thank you for installing Chef Infra Client! For help getting started visit https://learn.chef.io

ssh<EMAIL_ADDRESS>which chef-solo
/opt/chef/bin//chef-solo

knife solo cook<EMAIL_ADDRESS>Running Chef on 46.4.__...
Checking Chef version...
ERROR: RuntimeError: Couldn't find Chef >=0.10.4 on 46.4.__. Please run `knife solo prepare<EMAIL_ADDRESS>to ensure Chef is installed and up to date.

I suspect the version output of chef has changed since 0.10 and the knife solo code doesn’t know how to parse it.
This gem is deprecated so I don’t intend to fix it. If you’re interested in taking over maintenance let me know.

yeah that makes sense.
btw switching to ansible was what i really should have done. It uses this workflow out of the box without external hacks

Good move 👍


[Improvement][project management] Modify the title

*For better global communication, please give priority to using English description, thx! *
Please review https://dolphinscheduler.apache.org/en-us/community/development/issue.html when describe an issue.
Describe the question
“项目管理”功能模块中“项目首页”菜单与页面内容关系不大。.
What are the current deficiencies and the benefits of improvement

“项目首页”文字，修改成“工作流监控”.

Which version of DolphinScheduler:
-[1.3.7]
Describe alternatives you've considered
A clear and concise description of any alternative improvement solutions you've considered.

Hi, i will take this issue. Thanks.


Auth method drop down on Query tab doesn't remember users default selection

I only use the API key when I'm developing yet everytime I go into run a query it defaults to IAM even though I don't have any IAM setup.
Would be wonderful if it remembered my last selection and then just used that going forward until I change it. It keeps catching me out then when you link that with issue #1530 it can cause quite a bit of frustration as my query disappears!

To Reproduce
Steps to reproduce the behavior:

Go to AppSync
Click on "Query"
Write a query
Change the auth drop down to API key
Refresh the page
Drop down will have reverted to IAM again.

Expected behavior
The console remembers the last Auth method I had selected between logins/refreshes/etc.
Desktop (please complete the following information):

OS: Windows 10
Browser chrome

Please open a ticket with the AppSync team here: https://forums.aws.amazon.com/forum.jspa?forumID=280


Color legend widget

Implementation of color legend widget.
Support both discrete and continuous scale.
Scale calculation is based on d3 scale.
Discrete color scale supports linear log, sqrt, pow, quantile, ordinal.
Continuous color supports linear log, sqrt, pow. Continuous color supports two color transition.
This is is WIP PR, will test use this widget in a project first.

this is looking awesome @matthewma

This is ready for review

@manthey, Thank you very much for your detailed previous reviews. They totally make sense.
I have made corresponding changes.
This is ready for further review.
(I don't know why codecov indicates two line is not covered, I have a expect() that tests the results from that two lines)

With PR #733, you can remove examples/color-legend/index.pug and examples/color-legend/main.css, and remove the lines that have path and example.css from examples/color-legend/example.json.

OMG, I finally fixed the build. @manthey, could you take a quick look?

I realize this is closed, however I have a question regarding how to use this. When I add a contour plot as well as one of these legends, the colouring of the contour plot doesn't match the legend's colour. Is this to be expected?

Are you using the same colors for the contour plot and the legend?  They can be specified independently;  there is nothing that forces them to be the same, though you should be able to use the same colors for both.
If you have a code snippet, we can advise further.


[CLI] OSError: [Errno 18] Invalid cross-device link:

Description
When logging multiple tables with relatively long names in the UI,  only the first table is logged and I get an error message.
Wandb features
for data in multiple_data_lists:
      table = wandb.Table(data=data, columns=columns)
      wandb.log({table_name: table})

Error Message:
Traceback (most recent call last):
  File "/home/wilsonchan/anaconda3/envs/AceOne-CALF/lib/python3.8/shutil.py", line 791, in move
    os.rename(src, real_dst)
OSError: [Errno 18] Invalid cross-device link: '/tmp/tmpfgmsj1jjwandb-media/wx1cbx2g.table.json' -> './CALF/wandb/run-20211018_170848-3nuk7qkt/files/media/table/Predictions fo
r YONEX All England Open 2018: WS _ TAI Tzu Ying (TPE) [1] vs Saina NEHWAL (IND) _ BWF 2018_3_34a8e27be30377cd5860.table.json'

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "CALF/src/main.py", line 346, in <module>
    main()
  File "CALF/src/main.py", line 285, in main
    predictions.upload_predictions()
  File "/media/wilsonchan/Giratina/Projects/BadmintonAI/AceOne-BadmintonAI/CALF/src/predictions.py", line 121, in upload_predictions
    wandb.log({table_name: table})
  File "/home/wilsonchan/anaconda3/envs/AceOne-CALF/lib/python3.8/site-packages/wandb/sdk/wandb_run.py", line 1193, in log
    self.history._row_add(data)
  File "/home/wilsonchan/anaconda3/envs/AceOne-CALF/lib/python3.8/site-packages/wandb/sdk/wandb_history.py", line 44, in _row_add
    self._flush()
  File "/home/wilsonchan/anaconda3/envs/AceOne-CALF/lib/python3.8/site-packages/wandb/sdk/wandb_history.py", line 59, in _flush
    self._callback(row=self._data, step=self._step)
  File "/home/wilsonchan/anaconda3/envs/AceOne-CALF/lib/python3.8/site-packages/wandb/sdk/wandb_run.py", line 937, in _history_callback
    self._backend.interface.publish_history(
  File "/home/wilsonchan/anaconda3/envs/AceOne-CALF/lib/python3.8/site-packages/wandb/sdk/interface/interface.py", line 214, in publish_history
    data = data_types.history_dict_to_json(run, data, step=step)
  File "/home/wilsonchan/anaconda3/envs/AceOne-CALF/lib/python3.8/site-packages/wandb/sdk/data_types.py", line 2318, in history_dict_to_json
    payload[key] = val_to_json(run, key, val, namespace=step)
  File "/home/wilsonchan/anaconda3/envs/AceOne-CALF/lib/python3.8/site-packages/wandb/sdk/data_types.py", line 2398, in val_to_json
    val.bind_to_run(run, key, namespace)
  File "/home/wilsonchan/anaconda3/envs/AceOne-CALF/lib/python3.8/site-packages/wandb/data_types.py", line 427, in bind_to_run
    super(Table, self).bind_to_run(*args, **kwargs)
  File "/home/wilsonchan/anaconda3/envs/AceOne-CALF/lib/python3.8/site-packages/wandb/sdk/data_types.py", line 518, in bind_to_run
    shutil.move(self._path, new_path)
  File "/home/wilsonchan/anaconda3/envs/AceOne-CALF/lib/python3.8/shutil.py", line 811, in move
    copy_function(src, real_dst)
  File "/home/wilsonchan/anaconda3/envs/AceOne-CALF/lib/python3.8/shutil.py", line 435, in copy2
    copyfile(src, dst, follow_symlinks=follow_symlinks)
  File "/home/wilsonchan/anaconda3/envs/AceOne-CALF/lib/python3.8/shutil.py", line 264, in copyfile
    with open(src, 'rb') as fsrc, open(dst, 'wb') as fdst:
OSError: [Errno 22] Invalid argument: './CALF/wandb/run-20211018_170848-3nuk7qkt/files/media/table/Predictions for YONEX All England Open 2018: WS _ TAI Tzu Ying (TPE) [1] vs
Saina NEHWAL (IND) _ BWF 2018_3_34a8e27be30377cd5860.table.json'

How to reproduce
N/A
Environment

OS: Pop! OS 20_04
Environment: Conda Env + Python scripts
Python Version: 3.8.11

Related to #1252 - issue still persists in wandb version 0.12.4

@Wilann we cache all data in your home directory by default.  The error is coming from windows mounting the tmp directory on a different drive than the cache directory.  You can override the cache directory to be on the same device as your tmp directory by setting the WANDB_CACHE_DIR environment variable.  If you want to maintain the cache you can copy ~/.cache/wandb into the directory you set WANDB_CACHE_DIR to.


Continue interfering with "terminal.integrated.allowChords"

Before submitting your bug report

[X] I believe this is a bug. I'll try to join the Continue Discord for questions
[ ] I'm not able to find an open issue that reports the same bug
[ ] I've seen the troubleshooting guide on the Continue Docs

Relevant environment info
- OS: macOS Sonoma 14.5 (23F79)
- Continue: v0.8.39
- IDE: VSCode 1.89.1 (Universal)

Description
When Continue is enabled disabling chords in integrated terminal using "terminal.integrated.allowChords": false settings is not working which breaks cmd + K as terminal clear shortcut
To reproduce

Set "terminal.integrated.allowChords": false in user preferences
Open terminal, press Cmd\Ctrl + K
Terminal output should be cleared
Enable Continue extension
Press Cmd\Ctrl + K
VSCode enters chord mode and waits for next key

Log output
There is no output in continue log

I don't think that Continue should be doing anything to interfere with cmd+K (we use cmd+L and cmd+I). Are you certain that this is happening only with the Continue extension installed?

I can confirm I was also having this issue only after installing Continue.
As a workaround I added an extra terminal clear keybind in my user keybindings (for the same key combination) which seemed to fix it:
  {
    "key": "cmd+k",
    "command": "workbench.action.terminal.clear",
    "when": "terminalFocus"
  },

This is fixed by https://github.com/continuedev/continue/pull/1671


Hotfix: Corrected typo in logdie call

Typo was corrected

Approved

Coverage remained the same at 100.0% when pulling 1e922262711d8922d76dcd15c329234fc0d3cc11 on hotfix/correct_typo_in_logdie into 8f6e708229c14a248d530f3480b6fae77989c4ed on master.


How to overwrite  log output use System.out.println

when I set
.withLogging(LogType.STREAM).
and the log messages out put use
System.out.println
How can I use the org.slf4j.Logger to  log the messages

Hi! To avoid creating a dependecy on Slf4j, Speedment uses its own logging system. However, it is possible to define a custom LoggerFactory to control where the logs are being outputted. Here I have created a small adapter that simply delegates all logs to Slf4j.
I might release it to the Maven Central Repository since it might be useful for more people.

ths
like orthers sayed  you are so handsome : )

Released it to maven central now so that it is easier to access. It should be live within an hour or so. You can see the repository here.


Add class-specific metric calculation at the end of training

For training species classifiers it is often important to know how well the model performs on certain species, as opposed to only knowing the overall accuracy. This PR includes an new function into lib_model.py that is called from mewc_train.py and evaluates each class and prints a classification report like the one below.
Classification report:
                       precision    recall  f1-score   support

     african wild cat       0.94      0.87      0.90      3795
               baboon       0.79      0.86      0.82      2195
                 bird       0.83      0.94      0.88      4714
         brown hyaena       0.53      0.92      0.67       804
                canid       0.71      0.66      0.68       830
              caracal       0.16      0.77      0.27        44
               cattle       1.00      0.90      0.94     29470
              cheetah       0.76      0.77      0.77       911
             elephant       0.92      0.88      0.90     12575
              gemsbok       0.91      0.91      0.91      5555
              giraffe       0.93      0.90      0.91      6589
                 hare       0.94      0.87      0.90      3422
                hyrax       0.19      1.00      0.32        21
klipspringer+steenbok       0.26      0.85      0.39       158
                 kudu       0.50      0.93      0.65       565
              leopard       0.34      0.77      0.47       161
                 lion       0.87      0.71      0.78      3472
             mongoose       0.48      0.85      0.62       238
              ostrich       0.89      0.91      0.90      2291
                other       0.48      0.87      0.61       819
            porcupine       0.60      0.95      0.73       203
           rhinoceros       0.20      0.95      0.33       330
       spotted hyaena       0.86      0.75      0.80      2953
            springbok       0.81      0.88      0.84      1780
                zebra       0.87      0.90      0.89      3713

             accuracy                           0.88     87608
            macro avg       0.67      0.86      0.72     87608
         weighted avg       0.91      0.88      0.89     87608

It additionally saves a visual representation of a normalised confusion matrix. This provides insight into misclassifications and can help ecologists to group certain species together. It will adjust font size according to the number of classes present, and with few classes it will also print its cell value.

I'm waiting to get a quick review from @BWBrook on the pull request, but the code changes look good to me. Will merge this pull request once it gets another thumbs up. :)

I'm going to merge this pull request, I think Barry is out for a little bit longer. If there are problems we can always roll back.


Prevent events duplication on initialisation

Description
I have always been wondering why on appstarter the pre_system event is called twice, as shown in the toolbar. Then, this forum thread emerged also discussing this duplication. It turns out, as pointed by OP, that on events discovery the Config\Events file is included twice even though they are referencing the same file. This PR attempts to filter Events::$files to have only unique found files to include.
Checklist:

[x] Securely signed commits
[x] Component(s) with PHPdocs
[x] Unit testing, with >80% coverage
[ ] User guide updated
[x] Conforms to style guide

I had no idea this was happening! Good catch. I suppose we could also switch to include_once to be super sure but I hear that has a slight performance impact.

Is a couple of thousand milliseconds a performance hit? I just tried changing include to include_once and the Bootstrap event in toolbar went up tremendously on first time load. It even maxed the 30 seconds execution time. Relevant times were min of 1000 ms to max of 6000 ms on Windows. But returned to average 30 ms on subsequent loads. I guess it is not worth it as I see it in my pseudo-benchmarking. 🤣

Wow! If that's the case, we should probably change out Autoloader to use include and se what performance improvements we get. By definition, it should only be called on to include a file that has not already bene included.

I guess so. I've read that the performance time increase was due to the internal tracking of what have already been included.


Combining CSS, SASS and LESS configuration.

There is a way to work combining more than one styles configuration?
I noticed when I try to combine two preprocesor, the last one overwrite the output file.
I want to add https://ant.design/ LESS files as a global style and manage my app styles using SASS with CSS Modules.
Can you show me an example if there is a way to do it?

@sfernandezsl, https://github.com/zeit/next-plugins/issues/71#issuecomment-367421555

thanks @JerryCauser it works! just one more thing...
It is possible to set up css Modules just in one of the styles configurations?
have CSS as global styles and SASS with CSS Modules?

just wrap your global styles in :global{}
Also, you can split your CSS file and make 2 files vendor.css for ant-design less files and 'app.css' for sass project files. When #55 will be merged, then it gives you the possibility to split files by using include or exclude.


Update 'imports-requiring-flow' eslint rule to support regex patterns

Summary:
We want to ensure all components using HOCs are using Flow in webapp.  If we detect any that aren't we'll either updating them to use Flow or check that their usages very careful.  In particular we want to make sure that consumers of components using HOCs aren't using ref forwarding.
Issue: None
Test plan:

cd packages/eslint-plugin-khan
yarn test

I'm not sure why these lint issues didn't come up in #638, but I'm going to fix them in this PR so we don't end up with even more lint.

This was previously approved and all of the checks are passing now so even though there were some changes that affect other packages I'm going to go ahead and land this.


62 annotate lineages with described mutations

With this merge request, we include the mutations in the DB that are described to define a given lineage.
This addresses #62. Since the constellation mutation representation allows descriptions at the nucleotide and amino acid level, we translate SNVs and deletions to the protein level to obtain an HGVS representation in the database

Okay, let's move on to hopefully the last round of review :smile:

All comments have been addressed. Merge coming soon :rocket:


Taking Familiar Rings out of Dimensional Storage behaves strangely

Describe the bug
Taking familiar rings out of dimensional storage will always take out the first ring shown, instead of whatever you selected. This seems to only affect familiar rings, and not other NBT containing items like written books or soul gems.
To Reproduce
Steps to reproduce the behavior:

Put multiple familiar rings containing different familiars inside of a dimensional storage controller.
Take one out
notice that instead of taking out the familiar you selected, you took out something different.

Expected behavior
I would always retrieve the familiar ring that I had selected.
Screenshots
https://github.com/klikli-dev/occultism/assets/30442287/ddb1db35-90a9-4fbc-a5ad-3a51a2b8bf81
System (please complete the following information):

Occultism Version: 1.89.1
OS: [e.g. Windows]: Windows 10
Minecraft Version: 1.20.1
Modpack Link and Version, or list of mods: Tested in an environment with purely the dependencies of curios, geckolib, modonomicon, and smartbrainlib.
Forge Version: tested on both 47.2.0 and 47.1.3 to ensure that this wasn't just a Lex Manos Imploding issue

Additional context
Happens regardless of whether you are accessing the storage from a wormhole, the actual controller, or an accessor. You can still retrieve all of the rings by just taking them all out one by one, of course.
The bug still happens even if i rename each ring in an anvil, as long as multiple show up in a single search query.

@f-raZ0R @steventsvetkov I think I know what is going on.
The storage actuator is different from a chest in how it identifies items. Chests identify items by the slot they occupy, the actuator does not do this, instead it tries to create a query to get a fitting item (this allows scenarios where a full stack of an item is taken, even if under the hood the item is split into multiple stacks from previous take operations).
The problem is that certain items do not send their full nbt tag to the client side (usually that is items that store other items), which means that the query is incomplete.
I think there are some ways to solve this, but I have to experiment

This bug exists as of the latest version, is there a way around this?

I am not sure how to fix it to be honest, it would require a bigger rework on how items are identified on server vs client.
However, it looks like in 1.20.6+ this will resolve itself due to changes to vanilla minecraft.
For this reason I will close the issue. If it remains in 1.20.6 please let me know and I will reassess the situation


Great Job！

Dear Author,
Thank you for your excellent work! We have recently come across your meaningful paper and are very interested in it. We were wondering if you would consider open-sourcing more details of your code? We are not sure if we have achieved the performance as described in the original paper during our replication efforts.

Hi,
I am not the author of the paper, I just tried to implement based on their writings, that's why this is an unofficial implementation. Thus I can't open-sourcing more details on the paper results, because I do not have more. Do you have any other question? Thanks!


Error while collecting story X - CommonJS module

Describe the bug
On some story MyStory.story.vue i import a vue component that relies on the @apollo/client package and this is what i get as error:
`Error while collecting story ... MyStory.story.vue
file:/// ... node_modules/@apollo/client/utilities/globals/fix-graphql.js:1
import { remove } from "ts-invariant/process/index.js";
SyntaxError: Named export 'remove' not found. The requested module 'ts-invariant/process/index.js' is a CommonJS module, which may not support all module.exports as named exports.
CommonJS modules can always be imported via the default export, for example using:
import pkg from 'ts-invariant/process/index.js';
const { remove } = pkg;
at ModuleJob._instantiate (node:internal/modules/esm/module_job:127:21)
at async ModuleJob.run (node:internal/modules/esm/module_job:193:5)
at async Promise.all (index 0)
`
the story is not shown in the Histoire UI, while the others are.
Other than this issue i'm having, i've had a great experience with Histoire. Migrating from storybook to this. 100 times better <3
Reproduction
Maybe this is enough. I'll add if needed.
System Info
System:
    OS: Linux 5.15 Ubuntu 20.04.4 LTS (Focal Fossa)
    CPU: (12) x64 Intel(R) Core(TM) i7-8750H CPU @ 2.20GHz
    Memory: 9.34 GB / 15.27 GB
    Container: Yes
    Shell: 5.0.17 - /bin/bash
  Binaries:
    Node: 16.14.2 - ~/.nvm/versions/node/v16.14.2/bin/node
    Yarn: 1.22.19 - /usr/bin/yarn
    npm: 8.5.0 - ~/.nvm/versions/node/v16.14.2/bin/npm
  Browsers:
    Brave Browser: <IP_ADDRESS>
    Firefox: 103.0

Used Package Manager
yarn
Validations

[X] Follow our Code of Conduct
[X] Read the Contributing Guidelines.
[X] Read the docs.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] Check that this is a concrete bug. For Q&A open a GitHub Discussion.
[X] The provided reproduction is a minimal reproducible example of the bug.

Could you try adding the ts-invariant package to Vite optimizeDeps include config?

A runnable reproduction as a stackblitz or a clonable repo would help a lot, thanks!

seems to be solved by using vite 3+. i had vite 2.x using @rollup/plugin-commonjs which was apparently causing the issue. i guess it can be closed. Thanks a lot for the prompt answer and all the best with this crazy useful project! I hope i'll manage to find some spare time to contribute

I hope i'll manage to find some spare time to contribute

That would be rad :100:


Drop Node 0.10 support

There are references to Node 0.10 in the codebase, let's kill it with fire! 🔥

This will be released in 5.1.0


accessibility problem with NVDA screen reader

Hi,
I would like to have a taste with the software. I try installing the desktop app, yet it is not pretty accessible with NVDA
I cannot access the interface and not knowing what to do with the app.

@lstar4ever Thank you for raising this issue. I'll investigate what we can do to support NVDA and other screen reading software.

Thankyou for your reply!
Feross Aboukhadijeh 於 28/4/2016 19:43 寫道:

@lstar4ever https://github.com/lstar4ever Thank you for raising this
issue. I'll investigate what we can do to support NVDA and other
screen reading software.
—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
https://github.com/feross/webtorrent-desktop/issues/439#issuecomment-215398738

use that commands
DEBUG=* webtorrent
localStorage.debug = '*'

Sorry, what do you mean by use that command?
How to use it???
47sallo93 於 27/5/2016 18:12 寫道:

use that commands
DEBUG=* webtorrent
localStorage.debug = '*'
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/feross/webtorrent-desktop/issues/439#issuecomment-222110879,
or mute the thread
https://github.com/notifications/unsubscribe/APVJnciyeKTXycfjyIPmEK24IN24IWy5ks5qFsOggaJpZM4IOj9m.

@lstar4ever I don't think @47sallo93's advice is relevant.

Ok thanks
Feross Aboukhadijeh 於 28/5/2016 7:34 寫道:

@lstar4ever https://github.com/lstar4ever I don't think @47sallo93
https://github.com/47sallo93's advice is relevant.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/feross/webtorrent-desktop/issues/439#issuecomment-222274748,
or mute the thread
https://github.com/notifications/unsubscribe/APVJnT7ofb8C5tq5XGU6DL7Q_Ksnv48tks5qF3-AgaJpZM4IOj9m.

@lstar4ever Have you had a chance to play with a recent version of WebTorrent Desktop? Has the situation improved at all?
I ask you because according to this thread, later versions of Chromium expose a lot more to screen readers: https://github.com/atom/atom/issues/1691
If you could test with WebTorrent Desktop 0.18.0 that would be great!

Yes, I tested the version just now.
Well I forgot how it was performing in the previous version, but I could
say the current one is still have many accessibility problems.
e.g. screen reader may say there are clickable objects, but no more
information, which not knowing what to do with it.
Feross Aboukhadijeh 於 10/2/2017 7:07 寫道:

@lstar4ever https://github.com/lstar4ever Have you had a chance to
play with a recent version of WebTorrent Desktop? Has the situation
improved at all?
I ask you because according to this thread, later versions of Chromium
expose a lot more to screen readers: atom/atom#1691
https://github.com/atom/atom/issues/1691
If you could test with WebTorrent Desktop 0.18.0 that would be great!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/feross/webtorrent-desktop/issues/439#issuecomment-278804443,
or mute the thread
https://github.com/notifications/unsubscribe-auth/APVJnW34A3W_2zO75Ot8_sNrSKa7xKLlks5ra5wYgaJpZM4IOj9m.

@lstar4ever Can you recommend a free screenreader? I'd like to test how the app behaves with one, but don't know which to use. Ideally it would be free.

Oh, the most widely used and free one is NVDA.
download link here:https://www.nvaccess.org/download/
Feross Aboukhadijeh 於 12/2/2017 13:38 寫道:

@lstar4ever https://github.com/lstar4ever Can you recommend a free
screenreader? I'd like to test how the app behaves with one, but don't
know which to use. Ideally it would be free.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/feross/webtorrent-desktop/issues/439#issuecomment-279198351,
or mute the thread
https://github.com/notifications/unsubscribe-auth/APVJnc83rVRdssxEUewpytTOFqqy49joks5rbprfgaJpZM4IOj9m.


[feature] Add common shells completions

I have trouble with zsh on my machine. It returns weird errors which I'm not willing to debug. I would appreciate it if anyone could help with zsh completions.


Animation Editor: Drag Handles

Drag Handles need these three features:

dragging the handles need a ticking noise
a counter to show how far the handle was moved (ex: +0.5 studs)
somehow needs to overcome the issue of selecting handles from underneath the UI

The selection of handles from under the UI is an issue that will be fixed soon.  The other requests are for new features and should be submitted on the ROBLOX developer forum for possible inclusion rather than here as a bug.

I've made these changed within my own fork https://github.com/benbrimeyer/Studio-Tools/pull/1


Update MSBuild.sln for MSBuildTaskHost

This change just updates the version of Visual Studio and maps AnyCPU for MSBuildTaskHost to x86 which is disabled anyway.

@dotnet-bot test Windows_NT Build for CoreCLR please


Failed to stop HttpClient threads

Since I started using this library I have experienced some memory leaks in Tomcat 7.
When I redeploy the webapp I see some messages like the following:
SEVERE: The web application [/analyse] appears to have started a thread named [HttpClient-82] but has failed to stop it. This is very likely to create a memory leak.

After checking TinCanJava, I see that you use Jetty to make HTTP requests. There is a suspicious static private attribute in RemoteLRS of the HttpClient class.
Is sharing a unique HttpClient object a common practice for Jetty? Can this be related to the memory leak?
I also see that httpClient.stop() is not called anywhere in RemoteLRS. Would not be a good idea to add a method to allow us (users of TinCanJava) to properly close it before our application shutdowns?
Any other reason that could make Tomcat not be able to stop these threads?

You are probably correct. The PR for gzip compression (#32) started to address this issue by adjusting the thread pool handling, but based on a cursory look still doesn't seem to fully expose it via an API which is probably the best fix. I can't really speak to common practice for Jetty, but given how HttpClient is positioned, particularly with the thread setup, I suspect that yes sharing an instance is common, but as stated we probably need to expose the thread setup to the user. I can't give a timeframe on when I'll be able to get to this but if you want to take a stab and submit a pull request it will at least get the ball rolling.

#44 should help contribute a fix for this if I understand the issue correctly. I'd still like to get the thread pool stuff in place, and based on further discussion of gzip I'm expecting the other two PRs to be closed, though I would like to capture the thread stuff from them so I'm currently leaving them open a little longer in case I can get to it in this sprint.

Hi Brian, thanks for letting me know. The code sent for the issue 44 definitely looks like a solution for this problem. I will use it and test it ASAP.
P.S.: Sorry for not attending you first request, I had it marked as a TODO but I never found the moment.

I have come back to this issue and discovered that Jetty 8 is End of Life.
In Jetty 9's HttpClient setThreadPool and start/stop methods don't exist anymore.
Therefore, I was wondering whether this and other similar issues could be fixed by simply updating the Jetty dependency.
From what I have checked, TinCanJava doesn't depend on Jetty so much. I think that it should not be so complex to make the necessary adaptations (particularly attending all the potential benefits that it could bring).
Do you want me to try this?

I have already updated TinCanJava dependency to Jetty 9.
However, I won't make a pull request yet as I cannot execute all the tests successfully. This problem is independent of the changes I made so I have opened a new issue (#46).

The problem described in this issue can be fixed now thanks to the new RemoteLRS.destroy method. For more info see #50.
Many thanks @brianjmiller.


neovim: add vimdiffAlias

Git's merge.tool needs to "point" to a binary. For vim's case will provide a separate executable known as vimdiff which can simulate vim -d, however, neovim doesn't have this, and needs an explicilt alias.
If you want to use neovim as a diff tool, you would have to do programs.<shell>.shellAliases = { vimdiff = "nvim -d"; };.
Not sure if we want neovim to be "aware" of the shell, but I think this is a little nicer than explicitly adding the vimdiff entry to .shellAliases

Do you use vimdiff in your shell ? I never do and thus prefer to configure git's diff tool instead.

I was testing it out, which is when i realized that it wasn't inheriting my neovim settings. And rather, was from the vim package

Thanks! Rebased to master in 09abc29b73e2d852a189932103d101fa5d961a7a.

sorry for not following up on this, got side tracked with reviewing  nixpkgs PRs.... so many PRs :(

No worries. I'm having a few days off around Easter so I'm trying to go through as many PRs as possible, including ones I've forgotten about 🙂


fix(exe): remove assignation on undefined variable

This makes my build fails since pv is undefined and you try to assign it the undefined value. I'm maybe guessing that pv should be py, but since the variable is not used anywhere after, I think we could safely remove this.

Not sure how that went by without notice :cry:


Remove pypandoc hack when downloading pandoc

https://github.com/bebraw/pypandoc/pull/154 is merged and released. We can remove the hack for file name handling

Codecov Report

Merging #2034 (4bba502) into master (5e28195) will decrease coverage by 4.34%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2034      +/-   ##
==========================================
- Coverage   94.59%   90.25%   -4.35%
==========================================
  Files          50       54       +4
  Lines       11277    11286       +9
==========================================
- Hits        10668    10186     -482
- Misses        609     1100     +491

Impacted Files
Coverage Δ

databricks/koalas/plot/plotly.py
10.52% <0.00%> (-85.53%)
:arrow_down:

...bricks/koalas/tests/plot/test_frame_plot_plotly.py
23.89% <0.00%> (-76.11%)
:arrow_down:

...ricks/koalas/tests/plot/test_series_plot_plotly.py
27.83% <0.00%> (-70.23%)
:arrow_down:

databricks/koalas/usage_logging/__init__.py
27.58% <0.00%> (-64.73%)
:arrow_down:

databricks/koalas/usage_logging/usage_logger.py
47.82% <0.00%> (-52.18%)
:arrow_down:

databricks/koalas/__init__.py
70.14% <0.00%> (-20.48%)
:arrow_down:

databricks/conftest.py
89.83% <0.00%> (-10.17%)
:arrow_down:

databricks/koalas/spark/functions.py
88.88% <0.00%> (-7.41%)
:arrow_down:

databricks/koalas/accessors.py
86.43% <0.00%> (-7.04%)
:arrow_down:

databricks/koalas/namespace.py
78.49% <0.00%> (-5.92%)
:arrow_down:

... and 27 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5e28195...4bba502. Read the comment docs.

@ueshin, let me merge this. I am 100% sure on this :-)