Provider generates invalid Proxy (blank)

What happened?
I am using the mysql.NewProvider, without a proxy.  This is returning the following error:
     └─ mysql:index:Database    dev_app                         error: could not validate provider configuration: 1

Diagnostics:
  mysql:index:Database (dev_app):
    error: could not validate provider configuration: 1 error occurred:
        * invalid value for proxy (The proxy URL is not a valid socks url.)

I believe this is due to the fact that the proxy is being default to a blank instead of a nil here:
https://github.com/pulumi/pulumi-mysql/blob/master/sdk/go/mysql/provider.go#L43
This is a generated file, so I did not consider making any kind of PR.  For the moment I am just removing that check locally.
Steps to reproduce
Use the explicit provider, without a Proxy set.
Expected Behavior
The provider should not use a proxy, instead of defaulting it to an invalid blank ("") proxy.
Actual Behavior
Based on the error message, I am assuming the blank proxy is invalid further down the chain.
Output of pulumi about
CLI
Version      3.46.0
Go Version   go1.19.2
Go Compiler  gc
Plugins
NAME    VERSION
auth0   2.14.0
aws     5.13.0
awsx    1.0.0-beta.11
docker  3.2.0
go      unknown
mysql   3.1.0
Host
OS       ubuntu
Version  20.04
Arch     x86_64
This project is written in go: executable='/home/matt/.gvm/gos/go1.18/bin/go' version='go version go1.18 linux/amd64'
......
Dependencies:
NAME                                   VERSION
github.com/pulumi/pulumi-auth0/sdk/v2  2.14.0
github.com/pulumi/pulumi-aws/sdk/v5    5.13.0
github.com/pulumi/pulumi-awsx/sdk      1.0.0-beta.11
github.com/pulumi/pulumi-mysql/sdk/v3  3.1.0
github.com/pulumi/pulumi/sdk/v3        3.39.1
Additional context
No response
Contributing
Vote on this issue by adding a 👍 reaction.
To contribute a fix for this issue, leave a comment (and link to your pull request, if you've opened one already).

Thanks for posting this issue @mpholcomb :star:. I'm able to reproduce the problem with this program:
package main

import (
	"github.com/pulumi/pulumi-mysql/sdk/v3/go/mysql"
	"github.com/pulumi/pulumi/sdk/v3/go/pulumi"
)

func main() {
	pulumi.Run(func(ctx *pulumi.Context) error {
		prov, err := mysql.NewProvider(ctx, "mysql", &mysql.ProviderArgs{
			Endpoint: pulumi.String("localhost"),
			Username: pulumi.String("squaremo"),
		})

		if err != nil {
			return err
		}

		_, err = mysql.NewDatabase(ctx, "mydb", nil, pulumi.Providers(prov))

		return err
	})
}

OK, having consulted with my colleagues and peered at the code, I think we can do better with the code generation, to avoid this problem -- I've filed the issue linked just above.

Is this the same as @pierskarsenbarg and me have been looking into in 11086 ?
I have been super happy if this could be fixed 🥇

Is this the same as @pierskarsenbarg and me have been looking into in https://github.com/pulumi/pulumi/issues/11086 ?

The symptom is exactly the same (blank proxy), and the diagnosis looks exactly the same (incorrect handling of defaults) -- yes it is! Let's keep the earlier posting, mention the underlying issue there, and mark this one as duplicate. @mpholcomb if I may redirect your attention over to https://github.com/pulumi/pulumi/issues/11086 ...


Is parse.com (BaaS) support coming?

This would be an amazing "out of the box" feature to  have :-)

Not sure if this is specific to this component or something more generic for Realm?

Closing this for now, please re open if you have further questions.


Matches all empty strings when using :let @/ = "" to clear the search pattern.

nvim --version: v0.6.1
Operating system/version: Linux arch 5.16.2-arch1-1

Describe the bug
Clearing the search pattern "the intended way" (not with the hlsearch option, because it disables highlighting) makes hlslens match all empty string in the document.
https://stackoverflow.com/a/657484
As stated in the above Stack verflow answer, and unless nvim does anything different, :let @/ = "" clears the search pattern and does not set it to "empty string". However hlslens does interpret it as empty stirng and matches all empty strings of the document, which is inconvenient.
http://vimdoc.sourceforge.net/htmldoc/pattern.html#last-pattern
To Reproduce using nvim -u mini.lua
Example:
cat mini.lua
-- packer
use {'kevinhwang91/nvim-hlslens'}

Steps to reproduce the behavior:

/anything
:let @/ = ""
Enjoy?

Expected behavior
hsllens should not match anything.
Screenshots

Remark / question: using nohlsearch to disable the highlighting causes the virtual text to linger until the cursor is moved. Is there any way to have it react more quickly?

Fixed now.


Support temporary (302) redirects

With no explicit cache expiry set, a browser may choose to cache a 301 redirect for as long as it likes. This can cause problems if you choose to alter where a domain redirects to in the future; browsers which cache the request will continue to point to the old redirect.
By specifying the temporary option, a user can ask that Rack::CanonicalHost return 302 redirects instead, causing the browser not to cache the request, and making it easier to redirect the domain somewhere else at a later date.
Usage:
use Rack::CanonicalHost, 'example.com', temporary: true

Have updated this PR to display the correct HTML response.

@tylerhunt Does this look okay?

@Aupajo I've been mulling this over, and I'm hesitant to merge it, because it adds additional and unnecessary complexity and isn't really in alignment with the intention of this gem, which is to redirect to the canonical host. For more generic redirects there are other Rack middleware gems out there, like rack-rewrite.
Also, it sounds like your primary motivation here is to work around browser caching of permanent redirects, but the new :cache_control option should solve that concern, no?

@tylerhunt That's right, my main motivation is to avoid browser caching. I understand where you're coming from – “canonical” and “temporary” don't really jive. Happy if you want to close this. Thanks for the consideration and the response!


Unable to install using fusepm

Getting the following error when trying to install:
fusepm install https://github.com/bolav/fuse-sqlite
Found 2 unoproj files. Wanted 1

Any ideas?

You have 2 unoproj files in your current directory. Choose which one is the one you want to use by fusepm install https://github.com/bolav/fuse-sqlite --unoproj main.unoproj

Now something different is happening?
fusepm install https://github.com/bolav/fuse-sqlite --unoproj main.unoproj
Found 0 unoproj files. Wanted 1

I'm unclear on what you are trying to achieve? Are you trying to make the example work, or to install fuse-sqlite into one of your projects?

I'm just trying to install it in one of my projects, but it does not work?
Please excuse me if i'm a total noob...
On Wed, May 18, 2016 at 1:14 PM, bolav<EMAIL_ADDRESS>wrote:

I'm unclear on what you are trying to achieve? Are you trying to make the
example work, or to install fuse-sqlite into one of your projects?
—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
https://github.com/bolav/fuse-sqlite/issues/8#issuecomment-219984340

If you write fusepm install https://github.com/bolav/fuse-sqlite in your projects directory it should be ready to use.

I do that, but this happens:
fusepm install https://github.com/bolav/fuse-sqlite
Found 2 unoproj files. Wanted 1
On Wed, May 18, 2016 at 1:49 PM, bolav<EMAIL_ADDRESS>wrote:

If you write fusepm install https://github.com/bolav/fuse-sqlite in your
projects directory it should be ready to use.
—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
https://github.com/bolav/fuse-sqlite/issues/8#issuecomment-219991291

That error message states that you have 2 .unoproj files in the current directory.

Ooook, so the error is on my side, i presumed it was on the github side...
Many many apologies....
On Wed, May 18, 2016 at 1:59 PM, bolav<EMAIL_ADDRESS>wrote:

That error message states that you have 2 .unoproj files in the current
directory.
—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
https://github.com/bolav/fuse-sqlite/issues/8#issuecomment-219993208


Git authentication

There are at least two ways to authenticate Git to third parties: HTTPS protocol, or SSH protocol.
Most of this is explained in length in https://happygitwithr.com/connect-intro.html
The idea of this tutorial is to condense some of this material and make clear recommendations for use at INBO. I think we should mainly follow this advice: https://usethis.r-lib.org/articles/articles/git-credentials.html
Authentication is necessary for communication between Git and GitHub REST API (gh package),  GitHub Git Server (gert and git2r packages), some continuous integration procedures, etc.

Part of this tutorial is already written as part of a now obsolete PR in the checklist package. See https://github.com/inbo/checklist/pull/67


mask doesn't work with Angular's default input type="number"

Hello. I tried an input field with type="number" and mask="99%" with bootstrap styling. The appearance works correctly but I cannot type in any value, the ng-model's value predefined in controller doesn't show up.
The reason for using type="number" is for the convenience of min/max/required.
http://docs.angularjs.org/api/ng.directive:input.number
Any ideas?

I'd be interested in a fix for this as well. We use<PHONE_NUMBER> masking for phone #'s on our contact pages and they don't work correctly on mobile if its a type="number" field.

has anyone found a solution for setting up a mask for input type=number?

anyone try type=tel? i think that helped my masking on phones, esp Android which uses keyboard autocomplete when its another field. and type=number shows up kinda ugly for desktop (while tel gives the numberpad on mobile, and on desktop doesn't do that number field whose browser UI 'number-incrementer' may not work with textfield masking)

It is using tel on the input type, worked well and the way I would if usase number, thank @armyofda12mnkeys

Closing since there is a workaround

I'd like to recommend this be reopened. Using type 'tel' is inappropriate for accessibility users.

I agree with Istone and suggest that this Issue be reopened, since the workaround is not appropriate.

Based on https://github.com/plentz/jquery-maskmoney/issues/80 and https://github.com/igorescobar/jQuery-Mask-Plugin/issues/25 the general consensus seems to be to not use type=number for fields you wish to mask. If your concern is accessibility then perhaps using @rayshan's solution is better?
I'm on the fence about re-opening this issue because I don't know how to solve it.

This is project is now obsolete, please continue the discussion, if need be, over there: https://github.com/angular-ui/ui-mask so that the project maintainer can pitch in too.


Object spreading restrictions are inconsistent "Spread types may only be created from object types."

TypeScript Version:  3.3.3
function unsafeSpread<T extends number>(arg: T) {
  return {...arg}; // why isn't this an error
}
let val = 1;
let spreadVal = {...val}; // but this is
let unknownVal: unknown = 1;
let unknownSpreadVal = {...unknownVal}; // and this is not

Expected behavior:
"Spread types may only be created from object types." should be thrown whenever non-objects are spread.
Actual behavior:
unknown and generics can be spread regardless
Playground Link:
https://www.typescriptlang.org/play/#src=function unsafeSpread<T extends number>(arg%3A T) {
  return {...arg}%3B %2F%2F why isn't this an error
}
let val %3D 1%3B
let spreadVal %3D {...val}%3B %2F%2F but this is
let unknownVal%3A unknown %3D 1%3B
let unknownSpreadVal %3D {...unknownVal}%3B %2F%2F and this is not

Related Issues:
did not find any in the first couple pages when searching

Also raised here. I suspect this might be a bug?

I've created a PR that attempts to resolve the first scenario (spread on T) https://github.com/Microsoft/TypeScript/pull/31185. However, I'm still a little concerned about restricting spreading for any and unknown types as there is a possibility of this being a breaking change.

I think it's fine to allow spreading on an any - unknown I think should fail. No need to add that in https://github.com/microsoft/TypeScript/pull/31185 (but if you, dear reader, might be interested in raising your own PR for that - I'd help get that in )

Sure. I can have a PR for this by end of this weekend. Thank you.

any in almost all contexts means "disable all type checking for this"; it would IMO be weird if it disabled spreading.


COMP: Declare ITKCudaCommon as an IMPORTED library in ITKTargets.cmake

See #360

@LucasGandel

Do you think that the failing builds are related? I'm lost!

Closing and reopening to relaunch checks

Closing, as ITKCudaCommon has been moved to a separate repository, https://github.com/RTKConsortium/ITKCudaCommon.


Ability to Join Classroom Added

'''
sdk.dir=D:\Android\SDK
flutter.sdk=D:\flutter
flutter.buildMode=debug
flutter.versionName=1.0.0
flutter.versionCode=1
flutter.minSdkVersion=24
flutter.targetSdkVersion=33
flutter.compileSdkVersion=33
'''
This is how it should look like. Use the given configuration, but make sure to replace it with your sdk paths. Also, make sure not to add the file in your commit as it contains user dependent paths.

Please refrain from using hardcoded values for sdk version in build.gradle. Use them through configured values in local.properties file

Yes I have made the requested changes.


Last names with spaces in them aren't properly scraped

E.g. Mc Donald, only the Donald part is picked up when scraping the email.

#51 may have reopened this one. I'm going to wait until I have some evidence of that.


We got a crash in the Java_com_polygraphene_alvr_VrActivity_requestIDR

And we used addr2line to locate the crash：

the source code is as below：

But even I comment out IDR_REQUEST_NOTIFIER.notify_waiters(); it still the same crash. We don't know why, is it something going wrong in the RUST runtime which we don't know the reason yet?

Recently, I found out even I comment out requestIDR in the vrActivity.java, it still the same crash. So maybe the libalvr_client.so I used for the addr2line tool did not contain the symbols.


CharField missing __init__ declaration

https://github.com/microsoft/pylance-release/issues/3401

Pretty sure we use __new__ instead so that we can make both pyright and mypy happy:
https://cs.github.com/sbdchd/django-types/blob/8b5f4bcbfa3b3ee7663f2b502490f1d4a7021d98/django-stubs/db/models/fields/__init__.pyi?q=CharField#L687
might be worth revisiting if that's still necessary -- I can't remember which type checker preferred new to init

pyright seems to prefer init.. users not getting correct signatures anymore

I'll have to revert pylance back to the old stubs https://github.com/typeddjango/django-stubs  for now

Yeah, we could probably change the types to use __init__ instead of __new__

@bschnurr I've refactored the type definitions to use __init__ in #139, but Pylance is having issues with understanding foreign keys. Mypy seems to work fine though and we do have better autocomplete.
reveal_type(comment.nullable_user_type)
mypy: Revealed type is "Union[tests.trout.models.User, None]"
Pylance: Type of "comment.nullable_user_type" is "_M@ForeignKey | None"

Pylance/pyright have been updated to look at __new__


[incubator/jaeger] Allow globally and individual overrides for names of components

This PR provides a consistent method for a given user to override the default names of components in the Jaeger chart. This is required in order for charts using Jaeger as a dependency to allow the Jaeger components have a consistent naming conventions for the parent charts components. Previously, there was some functionality to do name overrides only for select components, but this PR creates a consistent method for all components in Jaeger.
Currently, the default format all component names are prefixed with --. As an example, if the helm release name is called myrel, the collector deployment is named myrel-jaeger-collector. This PR implements 2 methods of overriding the prefix (-). The first is an option for globally changing the prefix for all components and the second is allowing the individual override of a single component. If both the global override and an individual override of a component is used, the individual component override takes precedence over the global. Please see examples below.
If --set fullnameOverride=mycomponents, the Jaeger components that get deployed will be named:

mycomponents-collector
mycomponents-query
mycomponents-agent

If --set fullnameOverride=mycomponent and --set query.fullnameOverride=yourcomponents, the Jaeger components that get deployed will be named:

mycomponents-collector
yourcomponent-query
mycomponents-agent

If --set collector.fullnameOverride=thiscomponent and the name of the release is called myrel, the Jaeger components that get deployed will be named:

thiscomponent-collector
myrel-jaeger-query
myrel-jaeger-agent

These nameOverride options are  considered very advanced and should only be used by implementers of charts where Jaeger is a dependency chart OR for very advanced users. As such, the README will not be updated to reflect these options.
Tested on kubernetes 1.7 and 1.8 and also tested using Jaeger as a dependent chart to have consistent names with the parent chart.
UPDATE: to reflect the new variable fullnameOverride

/ok-to-test

/lgtm

/lgtm


SSD reference when running on multiple gpus uses only one gpu's running batch norm stats for eval

At line
https://github.com/mlperf/training/blob/e8237dc295deab8f9064dc2e0651c8234710c0d5/single_stage_detector/ssd/train.py#L329
eval() is called with the model weights only of rank 0.  This is fine for most model weights (which are produced using a reduction between all gpus on every training iteration).  The exception is for batch-norm running_mean and running_var, which are kept individually on each gpu, and not used at all during training iterations.  At eval time (for example, just above https://github.com/mlperf/training/blob/e8237dc295deab8f9064dc2e0651c8234710c0d5/single_stage_detector/ssd/train.py#L322) the running_means and running_vars must be averaged between all the gpus in some way, else with large numbers of gpus the eval is done with running_means and running_vars that represent only a very small fraction of the input data which is not representative of the entire data set (especially if the implementation were to do sharding).

It seems this would be addressed by https://github.com/mlperf/training/pull/264


Update yargs version

Update has been done in https://github.com/storybookjs/storybook-deployer/pull/84


Travis build failing

@erikras @trueter CI failed on #532—which is weird because the PR build passed and code looks fine
build error on master coming from node-sass dependency npmconf see: https://travis-ci.org/erikras/react-redux-universal-hot-example/jobs/90821306#L154
maybe just try triggering a new build?

I tried restarting the build.

coolio, the rebuild passed. closing.


npm ERR! peerinvalid The package<EMAIL_ADDRESS>does not satisfy its siblings' peerDependencies requirements!

On npm install I get this error:
npm install
npm ERR! Darwin 14.5.0
npm ERR! argv "/usr/local/bin/node" "/usr/local/bin/npm" "install"
npm ERR! node v4.4.6
npm ERR! npm  v2.15.5
npm ERR! code EPEERINVALID

npm ERR! peerinvalid The package<EMAIL_ADDRESS>does not satisfy its siblings' peerDependencies requirements!
npm ERR! peerinvalid Peer<EMAIL_ADDRESS>wants<EMAIL_ADDRESS>npm ERR! peerinvalid Peer<EMAIL_ADDRESS>wants<EMAIL_ADDRESS>
npm ERR! Please include the following file with any support request:

any idea?

solved installing npm 3+


Rename the MessageProperties class

Because you named your message "message", it is unclear whether I need a properties class for every property.  You named it MessageProperties and the only message in it is one named message.  Please either point out that it is a general name for all messages or chose another name.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 583bc242-0fd9-1253-0ff5-7ab627be2403
Version Independent ID: 1c80d801-3512-29cb-c2c9-39888954ab25
Content: Quickstart to learn how to use Azure App Configuration
Content Source: articles/azure-app-configuration/quickstart-java-spring-app.md
Service: azure-app-configuration
GitHub Login: @AlexandraKemperMS
Microsoft Alias: alkemper

Thank you for your feedback! We will review and update as appropriate.

This is very valid, it would be better to rename Message to something more useful. c: @maud-lv

Thank you for your feedback @jhaydt. We opened a PR with your suggestion. I will be merged shortly.

#please-close


Crash when including a parameter

The following bit of code produces the error "Compilation segmentation fault (core dumped)".
import algebra.ordered_field
open algebra
section sequence_c

  parameter Q : Type
  parameter lof_Q : linear_ordered_field Q
  definition to_lof [instance] : linear_ordered_field Q := lof_Q
  include to_lof

  theorem foo (a b : Q) : a + b = b + a := !add.comm

end sequence_c

I see this isn't the appropriate way to do what I want to. But, I'm guessing the crash isn't intentional!

Dear Rob,
I fixed the crash. However, with the fix, Lean rejects foo.
Your file makes sense, but Lean does not support this kind of instance yet.
This limitation is discussed at issue #554.
For convenience, I'm copying a relevant part here:

Eventually (this can be implemented much later than the other points) it would be nice that for every attribute we have a local attribute which acts as an attribute for the alias (and hence would act the same way as if all parameters were replaced by constants). Then local coercions and local instances are special cases of this. This is probably an enormous amount of work to implement, because it is different for every attribute. It's probably not useful for every attribute (local attribute foo [c-unfold n] doesn't look very useful). Is there a full list of attributes somewhere?

Floris is right. This one is an enormous amount of work.
Right now, all attributes local or not are for the abstracted version.
I think it too much work for a relatively modest improvement in usability.
As I told with Jeremy yesterday, I want to focus all resources on better automation.

Thanks, Leo! That's more than fair. This is easy enough to work around for now, and more automation will be a huge help.


[New Port Request] xapian

Library name: xapian
Library description: an Open Source Search Engine Library
Source repository URL: https://git.xapian.org/xapian
Project homepage: https://xapian.org/
Anything else that is useful to know when adding:
xapian is possibly the only viable and mature IR and Full Text Search framework for the c++ world. It would be great to have it in vcpkg.
It supports msvc via msys, and depends on zlib, and optionally, icu.
[ref]
https://github.com/xapian/xapian/blob/master/xapian-core/INSTALL
https://github.com/xapian/xapian/blob/master/xapian-core/configure.ac for other useful flag

If you wish to add this port in the future, you can reopen this issue, but we're closing it for now.


Crash when aligning TextField by baseline

I would like to have a TextField and a button in a Row together, aligned by baseline.  This causes a crash due to an unimplemented function in package:flutter/src/material/input_decorator.dart.
import 'package:flutter/material.dart';

void main() => runApp(Main());

class Main extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      title: 'Attendance',
      theme: ThemeData(
        primarySwatch: Colors.blue,
      ),
      home: Scaffold(
        appBar: AppBar(),
        body: Row(
          crossAxisAlignment: CrossAxisAlignment.baseline,
          textBaseline: TextBaseline.alphabetic,
          children: [
            Expanded(child:TextField()),
            Container(width: 16.0),
            RaisedButton(child: Text('REFRESH')),
          ],
        ),
      ),
    );
  }
}

Output:
I/flutter (25288): ══╡ EXCEPTION CAUGHT BY RENDERING LIBRARY ╞═════════════════════════════════════════════════════════
I/flutter (25288): The following assertion was thrown during performLayout():
I/flutter (25288): not implemented
I/flutter (25288): 'package:flutter/src/material/input_decorator.dart': Failed assertion: line 966 pos 12: 'false'

flutter doctor -v:
[√] Flutter (Channel beta, v0.11.9, on Microsoft Windows [Version 10.0.17134.407], locale en-US)
    • Flutter version 0.11.9 at C:\Users\Admin\Desktop\flutter
    • Framework revision d48e6e433c (4 days ago), 2018-11-20 22:05:23 -0500
    • Engine revision 5c8147450d
    • Dart version 2.1.0 (build 2.1.0-dev.9.4 f9ebf21297)

[√] Android toolchain - develop for Android devices (Android SDK 28.0.3)
    • Android SDK at C:\Users\Admin\AppData\Local\Android\sdk
    • Android NDK location not configured (optional; useful for native profiling support)
    • Platform android-27, build-tools 28.0.3
    • Java binary at: C:\Program Files\Android\Android Studio\jre\bin\java
    • Java version OpenJDK Runtime Environment (build 1.8.0_152-release-1136-b06)
    • All Android licenses accepted.

[√] Android Studio (version 3.2)
    • Android Studio at C:\Program Files\Android\Android Studio
    • Flutter plugin version 30.0.1
    • Dart plugin version 181.5656
    • Java version OpenJDK Runtime Environment (build 1.8.0_152-release-1136-b06)

[√] Connected device (1 available)
    • Pixel XL • HT7470204168 • android-arm64 • Android 9 (API 28)

• No issues found!

Might be the same underlying cause as #23377

The asserting that's triggering is here: https://github.com/flutter/flutter/blob/c8ff617fd8cf72f8ec5b107fb6729feb22fd101d/packages/flutter/lib/src/material/input_decorator.dart#L965-L968
That means @zoechi hunch is correct. I am going to de-dup the issues.

@HansMuller, who submitted the assert :)

That function wasn't implemented because at the time it wasn't possible to. Here are my notes from a year ago, when I was working on it:

... I thought this would work:

  double _lineHeight(double width, List<RenderBox> boxes) {
    double aboveBaseline = 0.0;
    double belowBaseline = 0.0;
    for (RenderBox box in boxes) {
      if (box == null)
        continue;
      final double baseline = box.getDistanceToBaseline(TextBaseline.alphabetic);
      aboveBaseline = math.max(baseline, aboveBaseline);
      belowBaseline = math.max(box.getMinIntrinsicWidth(width) - baseline, belowBaseline);
    }
    return aboveBaseline + belowBaseline;
  }

If fails in a complex assertion due to the call to getDistanceToBaseline().  I assume that it's enforcing this documented limitation:
Only call this function after calling layout on this box. You are only allowed to call this from the parent of this box during that parent's performLayout or paint functions.
I noticed this in flex.dart, which should need to do the same baseline-aligned line-height thing:
// TODO(ianh): Support baseline alignment.

Apparently this is still an open TODO:
https://github.com/flutter/flutter/blob/master/packages/flutter/lib/src/rendering/flex.dart#L511

Is this going to be solved?

@bzd2000 I'm hoping to take a look at this when I get some time.  I'm trying to clean up a bunch of TextField related problems.

@justinmc thanks that would be appreciated. I ran into the same issue on Android Studio with Flutter plugin version 33.3.1 and Dart plugin version 182.5215.

https://github.com/flutter/flutter/pull/30069 includes a fix for the assert(false...), and I believe Justin is also working on a more thorough fix for this. Whichever lands first (probably Justin's) will fix this, since my patch may take longer as it is part of a much bigger change.

This should work now with the above PR.

Is there a solution to this problem?My Flutter current version is 1.5.4

This should be fixed as of v1.4.17.  If you're seeing it on 1.5.4 then let us know how to reproduce it if you can.

I'm having the same problem. Here is my code snippet:
     body: SingleChildScrollView(         child: Container(           margin: EdgeInsets.all(15.1),           child: Form(             key: _formKey,             autovalidate: _autoValidate,             child: ListView(               children: <Widget>[                 ListTile(                   title: TextFormField(                     decoration: const InputDecoration(labelText: 'Product Barcode'),                     keyboardType: TextInputType.text,                   ),               ],             ),           ),       ),
Runnning on version:
1.5.4-hotfix.2_ • channel stable • https://github.com/flutter/flutter.git
Framework • revision 7a4c33425d (7 weeks ago) • 2019-04-29 11:05:24 -0700
Engine • revision 52c7a1e849
Tools • Dart 2.3.0 (build 2.3.0-dev.0.5 a1668566e5)

I'm having the same problem. Here is my code snippet:
 body: SingleChildScrollView( child: Container( margin: EdgeInsets.all(15.1), child: Form( key: _formKey, autovalidate: _autoValidate, child: ListView( children: <Widget>[ ListTile( title: TextFormField( decoration: const InputDecoration(labelText: 'Product Barcode'), keyboardType: TextInputType.text, ), ], ), ), ),
Runnning on version:
1.5.4-hotfix.2_ • channel stable • https://github.com/flutter/flutter.git
Framework • revision 7a4c334 (7 weeks ago) • 2019-04-29 11:05:24 -0700
Engine • revision 52c7a1e849
Tools • Dart 2.3.0 (build 2.3.0-dev.0.5 a1668566e5)

The problem seems to be the SingleChildScrollView container. After removing it I don't have the problem anymore.

@andersonptf-work Do you need the SingleChildScrollView?  I tried your code and couldn't find anything that looked like a bug.  If something seems broken let me know.


HADOOP-18872: [ABFS] [BugFix] Misreporting Retry Count for Sub-sequential and Parallel Operations

Jira Ticket: https://issues.apache.org/jira/browse/HADOOP-18872
Description of PR
There was a bug identified where retry count in the client correlation id was wrongly reported for sub-sequential and parallel operations triggered by a single file system call. This was due to reusing same tracing context for all such calls.
We create a new tracing context as soon as HDFS call comes. We keep on passing that same TC for all the client calls.
For instance, when we get a createFile call, we first call metadata operations. If those metadata operations somehow succeeded after a few retries, the tracing context will have that many retry count in it. Now when actual call for create is made, same retry count will be used to construct the headers(clientCorrelationId). Alhough the create operation never failed, we will still see retry count from the previous request.
Fix is to use a new tracing context object for all the network calls made. All the sub-sequential and parallel operations will have same primary request Id to correlate them, yet they will have their own tracing of retry count.
How was this patch tested?
For code changes:

[ ] Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
[ ] Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
[ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
[ ] If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 40s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 7 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
43m 37s

trunk passed

+1 :green_heart:
compile
0m 41s

trunk passed with JDK Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04

+1 :green_heart:
compile
0m 38s

trunk passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
checkstyle
0m 36s

trunk passed

+1 :green_heart:
mvnsite
0m 44s

trunk passed

+1 :green_heart:
javadoc
0m 43s

trunk passed with JDK Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04

+1 :green_heart:
javadoc
0m 37s

trunk passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
spotbugs
1m 11s

trunk passed

+1 :green_heart:
shadedclient
33m 34s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 29s

the patch passed

+1 :green_heart:
compile
0m 32s

the patch passed with JDK Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04

+1 :green_heart:
javac
0m 32s

the patch passed

+1 :green_heart:
compile
0m 29s

the patch passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
javac
0m 29s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
0m 22s
/results-checkstyle-hadoop-tools_hadoop-azure.txt
hadoop-tools/hadoop-azure: The patch generated 8 new + 4 unchanged - 0 fixed = 12 total (was 4)

+1 :green_heart:
mvnsite
0m 30s

the patch passed

-1 :x:
javadoc
0m 26s
/results-javadoc-javadoc-hadoop-tools_hadoop-azure-jdkUbuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04.txt
hadoop-tools_hadoop-azure-jdkUbuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04 with JDK Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04 generated 2 new + 15 unchanged - 0 fixed = 17 total (was 15)

-1 :x:
javadoc
0m 27s
/results-javadoc-javadoc-hadoop-tools_hadoop-azure-jdkPrivateBuild-1.8.0_382-8u382-ga-1~20.04.1-b05.txt
hadoop-tools_hadoop-azure-jdkPrivateBuild-1.8.0_382-8u382-ga-1~20.04.1-b05 with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05 generated 2 new + 15 unchanged - 0 fixed = 17 total (was 15)

+1 :green_heart:
spotbugs
1m  4s

the patch passed

+1 :green_heart:
shadedclient
34m  8s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
2m 17s

hadoop-azure in the patch passed.

+1 :green_heart:
asflicense
0m 41s

The patch does not generate ASF License warnings.

128m 24s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6019/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/6019

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux fd343a23cc0b 4.15.0-213-generic #224-Ubuntu SMP Mon Jun 19 13:30:12 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / dc2f952356e05a9253ab16b129c442879a87c2c2

Default Java
Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6019/1/testReport/

Max. process+thread count
735 (vs. ulimit of 5500)

modules
C: hadoop-tools/hadoop-azure U: hadoop-tools/hadoop-azure

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6019/1/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 38s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+0 :ok:
detsecrets
0m  1s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 7 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
44m 58s

trunk passed

+1 :green_heart:
compile
0m 43s

trunk passed with JDK Ubuntu-<IP_ADDRESS>+1-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
compile
0m 40s

trunk passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
checkstyle
0m 36s

trunk passed

+1 :green_heart:
mvnsite
0m 44s

trunk passed

+1 :green_heart:
javadoc
0m 42s

trunk passed with JDK Ubuntu-<IP_ADDRESS>+1-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
0m 39s

trunk passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
spotbugs
1m  9s

trunk passed

+1 :green_heart:
shadedclient
33m 35s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 30s

the patch passed

+1 :green_heart:
compile
0m 32s

the patch passed with JDK Ubuntu-<IP_ADDRESS>+1-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javac
0m 32s

the patch passed

+1 :green_heart:
compile
0m 28s

the patch passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
javac
0m 28s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
0m 21s

the patch passed

+1 :green_heart:
mvnsite
0m 32s

the patch passed

+1 :green_heart:
javadoc
0m 29s

the patch passed with JDK Ubuntu-<IP_ADDRESS>+1-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
0m 27s

the patch passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
spotbugs
1m  4s

the patch passed

+1 :green_heart:
shadedclient
34m  7s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
2m 17s

hadoop-azure in the patch passed.

+1 :green_heart:
asflicense
0m 40s

The patch does not generate ASF License warnings.

130m 11s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6019/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/6019

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux 30c41dd1da6b 4.15.0-213-generic #224-Ubuntu SMP Mon Jun 19 13:30:12 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 140c78b756d9ead52168cb5ae58b128a139adc95

Default Java
Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-<IP_ADDRESS>+1-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6019/2/testReport/

Max. process+thread count
703 (vs. ulimit of 5500)

modules
C: hadoop-tools/hadoop-azure U: hadoop-tools/hadoop-azure

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6019/2/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

Thanks for the review @steveloughran
Added fs.close() wherever applicable or enclosed FS creation inside a try.

reviewing
@anujmodi2021 can you avoid doing rebase/forced push when we are in those final review stages; as long as there are no merge problems it helps reviewers as we can easily review changes since their last review. thanks

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 25s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 7 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
32m 43s

trunk passed

+1 :green_heart:
compile
0m 30s

trunk passed with JDK Ubuntu-<IP_ADDRESS>+1-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
compile
0m 27s

trunk passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
checkstyle
0m 26s

trunk passed

+1 :green_heart:
mvnsite
0m 32s

trunk passed

+1 :green_heart:
javadoc
0m 31s

trunk passed with JDK Ubuntu-<IP_ADDRESS>+1-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
0m 28s

trunk passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
spotbugs
0m 48s

trunk passed

+1 :green_heart:
shadedclient
20m  3s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 21s

the patch passed

+1 :green_heart:
compile
0m 22s

the patch passed with JDK Ubuntu-<IP_ADDRESS>+1-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javac
0m 22s

the patch passed

+1 :green_heart:
compile
0m 20s

the patch passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
javac
0m 20s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
0m 15s
/results-checkstyle-hadoop-tools_hadoop-azure.txt
hadoop-tools/hadoop-azure: The patch generated 1 new + 4 unchanged - 0 fixed = 5 total (was 4)

+1 :green_heart:
mvnsite
0m 22s

the patch passed

+1 :green_heart:
javadoc
0m 20s

the patch passed with JDK Ubuntu-<IP_ADDRESS>+1-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
0m 19s

the patch passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
spotbugs
0m 42s

the patch passed

+1 :green_heart:
shadedclient
19m 54s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
1m 53s

hadoop-azure in the patch passed.

+1 :green_heart:
asflicense
0m 28s

The patch does not generate ASF License warnings.

85m 38s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6019/3/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/6019

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux 827c40174939 4.15.0-213-generic #224-Ubuntu SMP Mon Jun 19 13:30:12 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 25cc6d9bc5f4b96757b71f77078f27c68837b26b

Default Java
Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-<IP_ADDRESS>+1-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6019/3/testReport/

Max. process+thread count
557 (vs. ulimit of 5500)

modules
C: hadoop-tools/hadoop-azure U: hadoop-tools/hadoop-azure

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6019/3/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

Hi @steveloughran
Really sorry for making it difficult for you. There were some merge conflicts that I wanted to resolve.
I later learned that instead of using a git rebase, I should have used git merge.
I will keep this in mind for all my future PRs. Kindly request you to please take the effort this time and review the PRs.
Apologies again.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 27s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 7 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
31m 44s

trunk passed

+1 :green_heart:
compile
0m 30s

trunk passed with JDK Ubuntu-<IP_ADDRESS>+1-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
compile
0m 27s

trunk passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
checkstyle
0m 25s

trunk passed

+1 :green_heart:
mvnsite
0m 31s

trunk passed

+1 :green_heart:
javadoc
0m 31s

trunk passed with JDK Ubuntu-<IP_ADDRESS>+1-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
0m 28s

trunk passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
spotbugs
0m 48s

trunk passed

+1 :green_heart:
shadedclient
20m 25s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 21s

the patch passed

+1 :green_heart:
compile
0m 22s

the patch passed with JDK Ubuntu-<IP_ADDRESS>+1-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javac
0m 22s

the patch passed

+1 :green_heart:
compile
0m 20s

the patch passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
javac
0m 20s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
0m 15s
/results-checkstyle-hadoop-tools_hadoop-azure.txt
hadoop-tools/hadoop-azure: The patch generated 1 new + 4 unchanged - 0 fixed = 5 total (was 4)

+1 :green_heart:
mvnsite
0m 22s

the patch passed

+1 :green_heart:
javadoc
0m 20s

the patch passed with JDK Ubuntu-<IP_ADDRESS>+1-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
0m 19s

the patch passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
spotbugs
0m 42s

the patch passed

+1 :green_heart:
shadedclient
21m 17s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
1m 54s

hadoop-azure in the patch passed.

+1 :green_heart:
asflicense
0m 29s

The patch does not generate ASF License warnings.

85m 46s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6019/4/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/6019

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux fbb3fdc4b378 4.15.0-213-generic #224-Ubuntu SMP Mon Jun 19 13:30:12 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 213cdaa703a3dc5c205cecc8cdf45672a5dc0cfc

Default Java
Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-<IP_ADDRESS>+1-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6019/4/testReport/

Max. process+thread count
573 (vs. ulimit of 5500)

modules
C: hadoop-tools/hadoop-azure U: hadoop-tools/hadoop-azure

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6019/4/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

Really sorry for making it difficult for you.
no worries -I need to apologise for not giving the abfs code enough attention, either in reviews or my own work

merged! Anuj -can you do a branch-3.3 backport and retest...mukund has been getting his signing setup for a 3.3.x release


[Bug]: Failed to load plugin 'react': es-iterator-helpers tried to access call-bind

Is there an existing issue for this?

[X] I have searched the existing issues and my issue is unique
[X] My issue appears in the command-line and not only in the text editor

Description Overview
After upgrading to eslint-plugin-react 7.33.2, the following error appears when using Yarn PnP / Next.js lint:
- info Linting and checking validity of types .- error ESLint: Failed to load plugin 'react' declared in '.eslintrc.json » eslint-config-next/core-web-vitals » redacted/.yarn/__virtual__/eslint-config-next-virtual-3dd005a3fc/0/cache/eslint-config-next-npm-13.4.16-745205b385-c4b6849c4b.zip/node_modules/eslint-config-next/index.js': es-iterator-helpers tried to access call-bind, but it isn't declared in its dependencies; this makes the require call ambiguous and unsound.  Required package: call-bind Required by: es-iterator-helpers@npm:1.0.12 (via redacted/.yarn/cache/es-iterator-helpers-npm-1.0.12-35df79bd02-df1800a64b.zip/node_modules/es-iterator-helpers/Iterator.from/)  Require stack: - redacted/.yarn/cache/es-iterator-helpers-npm-1.0.12-35df79bd02-df1800a64b.zip/node_modules/es-iterator-helpers/Iterator.from/index.js - redacted/.yarn/__virtual__/eslint-plugin-react-virtual-df620cb600/0/cache/eslint-plugin-react-npm-7.33.2-08f77ebc15-b4c3d76390.zip/node_modules/eslint-plugin-react/lib/util/Components.js - redacted/.yarn/__virtual__/eslint-plugin-react-virtual-df620cb600/0/cache/eslint-plugin-react-npm-7.33.2-08f77ebc15-b4c3d76390.zip/node_modules/eslint-plugin-react/lib/rules/boolean-prop-naming.js - redacted/.yarn/__virtual__/eslint-plugin-react-virtual-df620cb600/0/cache/eslint-plugin-react-npm-7.33.2-08f77ebc15-b4c3d76390.zip/node_modules/eslint-plugin-react/lib/rules/index.js - redacted/.yarn/__virtual__/eslint-plugin-react-virtual-df620cb600/0/cache/eslint-plugin-react-npm-7.33.2-08f77ebc15-b4c3d76390.zip/node_modules/eslint-plugin-react/configs/all.js - redacted/.yarn/__virtual__/eslint-plugin-react-virtual-df620cb600/0/cache/eslint-plugin-react-npm-7.33.2-08f77ebc15-b4c3d76390.zip/node_modules/eslint-plugin-react/index.js - redacted/.yarn/cache/<EMAIL_ADDRESS>Referenced from: redacted/.yarn/__virtual__/eslint-config-next-virtual-3dd005a3fc/0/cache/eslint-config-next-npm-13.4.16-745205b385-c4b6849c4b.zip/node_modules/eslint-config-next/index.js
Expected Behavior
The missing dependencies should be automatically installed.
The related es-iterator-helpers issue is https://github.com/es-shims/iterator-helpers/issues/3. When it is resolved, need to upgrade es-iterator-helpers version in this project.
eslint-plugin-react version
v7.33.2
eslint version
v8.47.0
node version
v16.20.0

Fixed in es-iterator-helpers v1.0.13. This project depends on es-iterator-helpers with a ^, so no upgrade or change or release is needed here.
Note this works fine in actual npm, it just seems that PnP can't handle it.

Verified, works well. Thanks for a quick resolution!


Update build to use prebuilt extensions

Updates Elyra to use prebuilt extensions, thus removing the jupyter lab build step from user installs.
Fixes #1077
Fixes #2339
Developer's Certificate of Origin 1.1
   By making a contribution to this project, I certify that:

   (a) The contribution was created in whole or in part by me and I
       have the right to submit it under the Apache License 2.0; or

   (b) The contribution is based upon previous work that, to the best
       of my knowledge, is covered under an appropriate open source
       license and I have the right under that license to submit that
       work with modifications, whether created in whole or in part
       by me, under the same open source license (unless I am
       permitted to submit under a different license), as indicated
       in the file; or

   (c) The contribution was provided directly to me by some other
       person who certified (a), (b) or (c) and I have not modified
       it.

   (d) I understand and agree that this project and the contribution
       are public and that a record of the contribution (including all
       personal information I submit with it, including my sign-off) is
       maintained indefinitely and may be redistributed consistent with
       this project or the open source license(s) involved.

I've moved this out of WIP but have left it as a draft. It is now fully function for local builds and watch mode. It is also Theoretically ready for releases, but that is untested and dependent on the sister PR in the template repo (PR linked above). I have not touched any of our Docker code yet and have not updated any docs, which is why this is still in draft

Addressed CI test failures. The fix for code snippets was a "hack" and I opened up a followup https://github.com/elyra-ai/elyra/issues/2501 to properly address it.

Is this because I didn't run the "clean" script? Based on the message, it seems this could happen whenever a package dependency is updated.

Possibly, since how the artifacts is handled has changed, old files left in the previous extensions dir could cause issues. Running the clean-jupyterlab.sh script should remove those artifacts. For instance we used to link the extension libs(the ones listed in the ss), but now they are just included in the built extensions and lab doesn't need to know about them.

While I suppose this may have always been the case, it seems like the git extension is producing output that I don't recall before...

IIRC git has always dumped a ton of junk into debug, it's a previously raised complaint on their repo

After running etc/scripts/clean-jupyterlab.sh then make clean install, about 20 seconds after Lab presents itself in the browser, I get the following:

Do I need to do any additional "cleanup"?

IIRC git has always dumped a ton of junk into debug, it's a previously raised complaint on their repo

Yeah, I still see the dumped git log.  I guess I hadn't noticed that before as it was probably lost in the other debug output (including all the LSP stuff!).

I just pushed some update to the release script, but just like docker, further testing will have to wait till the PR is merged since it depends on git clone to pull the code to build

I only did a make clean install but it worked for me! Thanks!


[style]: Updating readme.md file

What's the style idea?
the image is not loaded properly
adding a proper image of the website
Add screenshots

Code of Conduct

[X] I agree to follow this project's Code of Conduct

@AmanSingh6574  can you  specify how can i produce same issue


Message: support body to be a callback

What?
In Sabre\HTTP\MessageInterface (and Sabre\HTTP\Message), support $body to be a callback outputting the body into php://output
Why?
Some responses may be big, so it's not scalable to hold the whole response in a variable (in memory), see https://github.com/fruux/sabre-dav/pull/890.
Limitation
getBodyAsString() and getBodyAsStream() doesn't currently work with the callback (throws an exception). It's implementation seem to be a bit complicated - mostly because we are able to produce output only once, but i'm open to ideas.
Usage example from sabre/dav
Snippet from sabre/dav to make generateMultiStatus() method work as a callback:
    function generateMultiStatus($fileProperties, $strip404s = false) {

        $w = $this->xml->getWriter();
        return function() use ($fileProperties, $strip404s, $w) {
            $w->openUri('php://output');
            $w->contextUri = $this->baseUri;
            $w->startDocument();
            $w->startElement('{DAV:}multistatus');

            foreach ($fileProperties as $entry) {
                $href = $entry['href'];
                unset($entry['href']);
                if ($strip404s) {
                    unset($entry[404]);
                }
                $response = new Xml\Element\Response(
                    ltrim($href, '/'),
                    $entry
                );
                $w->write([
                    'name'  => '{DAV:}response',
                    'value' => $response
                ]);
                // maybe we should flush() from time to time here as well
            }

            $w->endElement();
            $w->endDocument();
            $w->flush();
        };

    }

ping @evert / @staabm: will you have a chance to look into this? thanks!

can i get some 👀 on this? thanks!

so in the last commit i implemented getBodyAsString() and getBodyAsStream() for the case when body is a callback. I'm not sure if there is more effective way how to convert the php://output into stream -- at the moment there is an intermediate string representation used
I also removed the commit 47c4b1f which was changing $body() to $body($response)


Problems in running the plugin

Please add SCons to build

I would love to add a scons build, however, the llama.cpp dependency is a CMake/Make project and I believe it is quite hacky to integrate scons with CMake/Make.
It is possible to port a scons build for llama.cpp. It is a major effort though.

@Adriankhl I built it using CMake, I now have the libraries godot-cpp.windows.debug.32.lib, libgodot_llm.windows..amd64.lib, llama.lib, ggml_static.lib, what should I do with all this next?

@JekSun97 I am not familiar with visual studio myself, but it seems like you are getting close.
You need to find a way to build a dynamic library dll instead of static library lib, and if possible, set the cmake variable a CMAKE_BUILD_TYPE to Release (be aware that this is not used by MSBuild, you need to set the release build target somewhere else). Then, you should be able to build libgodot_llm.windows.release.amd64.dll (or rename the libgodot_llm... to this if you don't know how to set the cmake variable)
Finally, simply copy the dll and gdextension file to the addons folder of your godot project
├── addons
│   └── godot_llm
│       ├── bin
                        libgodot_llm.windows.release.amd64.dll
│       └── godot_llm.gdextension

It turns out that initially there was a compilation type for dll, now I decided to build libgodot_llm.windows..amd64 separately, but I get errors:
godot-cpp.windows.debug.32.lib(node.obj) : error LNK2038: mismatch detected for "_ITERATOR_DEBUG_LEVEL": value "2" does not match value "0" in gdllama.obj
1>godot-cpp.windows.debug.32.lib(node.obj) : error LNK2038: mismatch detected for "RuntimeLibrary": value "MDd_DynamicDebug" does not match value "MD_DynamicRelease" in gdllama.obj
1>godot-cpp.windows.debug.32.lib(wrapped.obj) : error LNK2038: Inconsistency detected for "_ITERATOR_DEBUG_LEVEL": value "2" does not match value "0" in gdllama.obj
1>godot-cpp.windows.debug.32.lib(wrapped.obj) : error LNK2038: Inconsistency detected for "RuntimeLibrary": value "MDd_DynamicDebug" does not match value "MD_DynamicRelease" in gdllama.obj
1>godot-cpp.windows.debug.32.lib(error_macros.obj) : error LNK2038: mismatch detected for "_ITERATOR_DEBUG_LEVEL": value "2" does not match value "0" in gdllama.obj
1>godot-cpp.windows.debug.32.lib(error_macros.obj) : error LNK2038: mismatch detected for "RuntimeLibrary": value "MDd_DynamicDebug" does not match value "MD_DynamicRelease" in gdllama.obj
1>godot-cpp.windows.debug.32.lib(memory.obj) : error LNK2038: mismatch detected for "_ITERATOR_DEBUG_LEVEL": value "2" does not match value "0" in gdllama.obj
1>godot-cpp.windows.debug.32.lib(memory.obj) : error LNK2038: mismatch detected for "RuntimeLibrary": value "MDd_DynamicDebug" does not match value "MD_DynamicRelease" in gdllama.obj
1>godot-cpp.windows.debug.32.lib(char_string.obj) : error LNK2038: mismatch detected for "_ITERATOR_DEBUG_LEVEL": value "2" does not match value "0" in gdllama.obj
1>godot-cpp.windows.debug.32.lib(char_string.obj) : error LNK2038: mismatch detected for "RuntimeLibrary": value "MDd_DynamicDebug" does not match value "MD_DynamicRelease" in gdllama.obj
1>godot-cpp.windows.debug.32.lib(string.obj) : error LNK2038: Inconsistency detected for "_ITERATOR_DEBUG_LEVEL": value "2" does not match value "0" in gdllama.obj
1>godot-cpp.windows.debug.32.lib(string.obj) : error LNK2038: mismatch detected for "RuntimeLibrary": value "MDd_DynamicDebug" does not match value "MD_DynamicRelease" in gdllama.obj
1>godot-cpp.windows.debug.32.lib(string_name.obj) : error LNK2038: mismatch detected for "_ITERATOR_DEBUG_LEVEL": value "2" does not match value "0" in gdllama.obj
1>godot-cpp.windows.debug.32.lib(string_name.obj) : error LNK2038: mismatch detected for "RuntimeLibrary": value "MDd_DynamicDebug" does not match value "MD_DynamicRelease" in gdllama.obj
1>godot-cpp.windows.debug.32.lib(variant.obj) : error LNK2038: Inconsistency detected for "_ITERATOR_DEBUG_LEVEL": value "2" does not match value "0" in gdllama.obj
1>godot-cpp.windows.debug.32.lib(variant.obj) : error LNK2038: Inconsistency detected for "RuntimeLibrary": value "MDd_DynamicDebug" does not match value "MD_DynamicRelease" in gdllama.obj
1>godot-cpp.windows.debug.32.lib(object.cpp.obj) : error LNK2038: mismatch detected for "_ITERATOR_DEBUG_LEVEL": value "2" does not match value "0" in gdllama.obj
1>godot-cpp.windows.debug.32.lib(object.cpp.obj) : error LNK2038: mismatch detected for "RuntimeLibrary": value "MDd_DynamicDebug" does not match value "MD_DynamicRelease" in gdllama.obj
1>godot-cpp.windows.debug.32.lib(method_bind.obj) : error LNK2038: mismatch detected for "_ITERATOR_DEBUG_LEVEL": value "2" does not match value "0" in gdllama.obj
1>godot-cpp.windows.debug.32.lib(method_bind.obj) : error LNK2038: mismatch detected for "RuntimeLibrary": value "MDd_DynamicDebug" does not match value "MD_DynamicRelease" in gdllama.obj
1>godot-cpp.windows.debug.32.lib(class_db.obj) : error LNK2038: mismatch detected for "_ITERATOR_DEBUG_LEVEL": value "2" does not match value "0" in gdllama.obj
1>godot-cpp.windows.debug.32.lib(class_db.obj) : error LNK2038: mismatch detected for "RuntimeLibrary": value "MDd_DynamicDebug" does not match value "MD_DynamicRelease" in gdllama.obj
1>godot-cpp.windows.debug.32.lib(godot.obj) : error LNK2038: mismatch detected for "_ITERATOR_DEBUG_LEVEL": value "2" does not match value "0" in gdllama.obj
1>godot-cpp.windows.debug.32.lib(godot.obj) : error LNK2038: mismatch detected for "RuntimeLibrary": value "MDd_DynamicDebug" does not match value "MD_DynamicRelease" in gdllama.obj
1>godot-cpp.windows.debug.32.lib(resource.obj) : error LNK2038: Inconsistency detected for "_ITERATOR_DEBUG_LEVEL": value "2" does not match value "0" in gdllama.obj
1>godot-cpp.windows.debug.32.lib(resource.obj) : error LNK2038: mismatch detected for "RuntimeLibrary": value "MDd_DynamicDebug" does not match value "MD_D"

I decided not to suffer and download the finished build, fortunately the license allows me to do this, once I test it I’ll post :)

You are mixing debug build and release build, probably need to clean up project and rebuild everything under the same mode

@Adriankhl  I installed the plugin manually and via AssetLib, and I get the same error:

@Adriankhl I installed the plugin manually and via AssetLib, and I get the same error:

May I confirm that you have created a new project, installed the plugin from the asset library, and this error pops up?

If that is the case can you try to extract the dll file here and replace the addons/godot_llm/bin/libgodot_llm.windows.release.amd64.dll by this new file?
libgodot_lib.zip

May I confirm that you have created a new project, installed the plugin from the asset library, and this error pops up?

Yes

If that is the case can you try to extract the dll file here and replace the addons/godot_llm/bin/libgodot_llm.windows.release.amd64.dll by this new file? libgodot_lib.zip
This is built without vulkan acceleration, just to see if the problem is related to gpu settings

Same error :(

:( Do you have Microsoft Visual C++ Redistributable installed?

Let's try it one more time, here I also statically linked MSVC runtime.
libgodot_llm.zip

Installing the addon crashes the editor for me.

Installing the addon crashes the editor for me.

May I know if you have Microsoft Visual C++ Redistributable installed?

I have created a new version of the plugin, this time I statically link the library to msvc runtime so no dependencies are needed, hopefully it fixes the problem.

Installing the addon crashes the editor for me.

May I know if you have Microsoft Visual C++ Redistributable installed?

I don't have MSVC. I tried the new version and it's still crashing as soon as the editor starts. I'm on Linux.. should I drop into Windows to see it the problem persists or would that not be it?

Installing the addon crashes the editor for me.

May I know if you have Microsoft Visual C++ Redistributable installed?

I don't have MSVC. I tried the new version and it's still crashing as soon as the editor starts. I'm on Linux.. should I drop into Windows to see it the problem persists or would that not be it?

I see. It is strange that I am able to reproduce the problem on my linux laptop but it works fine under wsl on Windows, let me spend some time today to investigate the problem.

:( Do you have Microsoft Visual C++ Redistributable installed?

Yes

Let's try it one more time, here I also statically linked MSVC runtime. libgodot_llm.zip

@JekSun97 @spiderbyte87 Finally I know what happened, there is a hidden default LLAMA_NATIVE option in the llama.cpp build, which introduces optimization to my local cpu, but it becomes incompatible on many platform. The Windows problem and Linux problem are the same issue, just that Windows handle the incompatibility slightly better so it doesn't crash (though it still doesn't provide useful debug information.
I have tested the new version on multiple PCs and VMs, I think now it should work.

@JekSun97 @spiderbyte87 Finally I know what happened, there is a hidden default LLAMA_NATIVE option in the llama.cpp cmake build, which introduces optimization for my local cpu, but the binary becomes incompatible on many platforms. The Windows problem and Linux problem are the same issue, just that Windows handle the incompatibility slightly better so it doesn't crash (though it still doesn't provide useful debug information).
I have disabled the option and tested the new version on multiple PCs and VMs, I think now it should work.

Will give it a try a little later today and let you know it if it works!

Yep it works without a hitch. I would highly recommend packaging this as a proper Godot addon with all the components in one place. Other than that, it's pretty great! I spent all yesterday getting Ollama working via POST, which works fine, but this is a far better solution! Thanks again!!

@Adriankhl can I test the dll?

@Adriankhl can I test the dll?

Yes, you can grep it from the the zip file of the release page: https://github.com/Adriankhl/godot-llm/releases/tag/v0.2.2
You will fine libgodot_llm.windows.release.amd64.dll in the bin folder

Now there is no error, but for some reason I couldn’t wait for an answer, I waited for about an hour, then closed the application.
I used this code:
extends Node

var lm = GDLlama.new()

func _ready() -> void:
if FileAccess.file_exists("res://Meta-Llama-3-8B-Instruct-Q5_K_M.gguf"):
lm.model_path="res://Meta-Llama-3-8B-Instruct-Q5_K_M.gguf"
var gen = lm.generate_text("5+5?")
print(gen)
else:
print("no file!")
pass

var gen = lm.generate_text("5+5?")

The default llama.cpp parameter lm.n_predict = -1 generates an infinite sequence, try setting lm.n_predict = 10 before running lm.generate_text

@Adriankhl  Thank you! Now everything is working, I advise you to write the minimum verification code in the README for a quick start.
I wanted to know how you can make it so that the model can receive and respond in other languages? Maybe some special model is needed?

@Adriankhl Thank you! Now everything is working, I advise you to write the minimum verification code in the README for a quick start.

Thanks for the suggestion! There is already a template godot project as a starting, but I think it is also good to have some simple coding example in the README.

I wanted to know how you can make it so that the model can receive and respond in other languages? Maybe some special model is needed?

It really depends on the model, llama 3 is already multillingual (depends on which language you want, it may or may not be good), and there are fine-tuned models which strengthen the output in a particular language. Bear in mind that the current stable version of this plugin doesn't convert utf8 correctly (fixed in the development version), so characters in other languages might be garbled.

@JekSun97 I have fixed the text encoding bug, now at least llama 3 works in Chinese according to my testing.
And I have also updated the README documentation, I hope now it is clear enough 😺

@JekSun97 I have fixed the text encoding bug, now at least llama 3 works in Chinese according to my testing.
And I have also updated the README documentation, I hope now it is clear enough 😺

Best! I'll test it today

Let's close this and use a new issue thread if there are further problems


Create "--flake-project" option

Would be nice to be able to extend a template to give an opinionated flake project setup for a template:
flake.nix
flake.lock
nix/
  overlay.nix
  <pname>.nix

another option, would be to create a "project" subcommand:
nix-template project python


Skill Scrolling broken on Firefox

Scrolling behavior on the left hand side of the character sheet is broken on the Firefox browser. The user cannot scroll using a scroll wheel and the visual scroll bar is not present. Tested by myself and a friend. Behavior works as expected while using a chromium-based browser.

Ooof. Thanks for the report. I'll take a look, why does Firefox insist on making life difficult?

resolved in 0.11.3


[naming] rename filegen to shellgen; and move devcontainer_util.go to /impl/generate

Summary
How was it tested?

Current dependencies on/for this PR:

main

PR #1198   👈

This comment was auto-generated by Graphite.


Dokka plugin breaks task scanning

Extension Name: vscode-gradle
Extension Version: 3.12.3
OS Version:  macos 12.5.1
VSCode version: 1.70.2
When I add the plugin org.jetbrains.dokka, the gradle extension is not able to identify tasks properly. See the screenshots below.
(I realise that the problem might be with the dokka plugin rather than with the gradle extension, but I have to start in this end, since this is where the problem shows up.)

Create a gradle project with gradle init. Choose groovy DSL, kotlin implemenation language, and library project.
Open the folder in VSCode and look at the gradle task list.
Add the dokka plugin to the gradle.build file
The gradle task list is not much shorter.

Screenshots
Without dokka plugin

With dokka plugin

Output from "Gradle for Java"
[info] Build file changed: /Users/xgumag/Documents/GU/projekt/aktiva_projekt/programmering/kutil/kutil/build.gradle
[info] Java Home<EMAIL_ADDRESS>[info] JVM Args: --add-opens,java.base/java.util=ALL-UNNAMED,--add-opens,java.base/java.lang=ALL-UNNAMED,--add-opens,java.base/java.lang.invoke=ALL-UNNAMED,--add-opens,java.base/java.util=ALL-UNNAMED,--add-opens,java.prefs/java.util.prefs=ALL-UNNAMED,--add-opens,java.prefs/java.util.prefs=ALL-UNNAMED,--add-opens,java.base/java.nio.charset=ALL-UNNAMED,--add-opens,java.base/java.net=ALL-UNNAMED,--add-opens,java.base/java.util.concurrent.atomic=ALL-UNNAMED,-XX:MaxMetaspaceSize=256m,-XX:+HeapDumpOnOutOfMemoryError,-Xms256m,-Xmx512m,-Dfile.encoding=UTF-8,-Duser.country=SE,-Duser.language=sv,-Duser.variant
[info] Gradle User Home: /Users/xgumag/.gradle
[info] Gradle Version: 7.4.1
[error] FAILURE: Build failed with an exception.

* What went wrong:
Could not create task ':kutil:dokkaJavadoc'.
> Cannot change dependencies of dependency configuration ':kutil:dokkaJavadocPlugin' after it has been resolved.

* Try:
> Run with --stacktrace option to get the stack trace.
> Run with --info or --debug option to get more log output.
> Run with --scan to get full insights.

* Get more help at https://help.gradle.org
[info] Deprecated Gradle features were used in this build, making it incompatible with Gradle 8.0.

You can use '--warning-mode all' to show the individual deprecation warnings and determine if they come from your own scripts or plugins.

See https://docs.gradle.org/7.4.1/userguide/command_line_interface.html#sec:command_line_warnings

CONFIGURE FAILED in 1s
[error] [gradle-server] The supplied build action failed with an exception.
[error] Error getting build for /Users/xgumag/Documents/GU/projekt/aktiva_projekt/programmering/kutil: The supplied build action failed with an exception.
[info] Found 0 tasks

looks like a issue related to gradle extension. when resolving tasks, we use TaskContainerInternal.forEach which seems to be forbidden for a resolved container:https://github.com/microsoft/vscode-gradle/blob/6fb12a264988a2fb110b00ed13cba82969a6a7a1/gradle-plugin/src/main/java/com/microsoft/gradle/GradleProjectModelBuilder.java#L212-L225
Maybe we should consider use sth like getAsMap() instead.


dodal#139 Adds i19-1 devices required for pin tip centring

Adds
--  i19-1 diffractometer with x,y,z and phi,omega,2theta and detector distance motion (as per EPICS controls)
-- on axis viewer OAV1
-- off axis viewer OAV2

See also Jira ticket I19-484 ( source for dodal#139 )

Closing as this has been implemented in GDA instead


AP for PartSeg

Hi @workforai et al.,
thx for ur cvpr'24 work. for part segmentation, may i ask if the conventional ap metric (apart from iou in the paper) could be reported as well? looking fwd to the code & ckpt. thx & best,

Sorry, we haven't tested the segmentation results with AP metric. We may try to count that later if we have time.
We have released the general inference code and UniLSeg-20 model weights (w/o finetuned on specified task dataset).


⚠ Bofrost.de has degraded performance

In 0207179, Bofrost.de (https://www.bofrost.de) experienced degraded performance:

HTTP code: 200
Response time: 1405 ms

Resolved: Bofrost.de performance has improved in 57c0c32.


chore: Add analytics event to track telemetry is disabled & update properties for INVITE_USER event

Description

Add analytics event to track telemetry is disabled
Update properties for INVITE_USER event
Updating @appsmith imports

PR fixes following issue(s)
Fixes #1514 #23754
Type of change

Chore (housekeeping or task changes that don't impact user perception)

Testing
How Has This Been Tested?

[x] Manual
[ ] Jest
[ ] Cypress

Checklist:
Dev activity

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[ ] PR is being merged under a feature flag

QA activity:

[ ] Speedbreak features have been covered
[ ] Test plan covers all impacted features and areas of interest
[ ] Test plan has been peer reviewed by project stakeholders and other QA members
[ ] Manually tested functionality on DP
[ ] We had an implementation alignment call with stakeholders post QA Round 2
[ ] Cypress test cases have been added and approved by SDET/manual QA
[ ] Added Test Plan Approved label after Cypress tests were reviewed
[ ] Added Test Plan Approved label after JUnit tests were reviewed

/ok-to-test sha=4312b08

/ok-to-test sha=e851f71


HTML Coding for Web Page

Integration of all technology via CS4 Dream Weaver

Requires CSS3
Requires JavaScript
Requires SQL
Requires HTML

Flow-chart: Software Engineering each part with literal statements, ...then convert to code

Coding HTML


feature: implement sst import

we need to expose the import command so people can add existing resources to their state file
ION-240

Hey, what's the status of this? Are there any updates? Such an important feature.

Not yet, but it'll be done before we ask people to start migrating from SST2.

In the meantime that this is being implemented can we use the import argument code-wise?
/**
     * When provided with a resource ID, import indicates that this resource's provider should import its state from
     * the cloud resource with the given ID. The inputs to the resource's constructor must align with the resource's
     * current state. Once a resource has been imported, the import property must be removed from the resource's
     * options.
     */
    import?: ID;```

Yeah actually you can. We just need to document it better on our side.

Sorta I'm going to document both of these in the next week.


Feat:Appearance of Navbar

Describe the feature
In navbar of website distribution of each component is not correctly done its looking very assymetrical and little bit confusing
I can make it more attractive
Add ScreenShots

Record

[X] I agree to follow this project's Code of Conduct
[X] I'm a GSSOC'24 contributor
[X] I want to work on this issue

i have tried solving the issue , please look into #302

Please assign me this work so i can fix it with a dynamic layout and i can contribute also

Hey @Suchitra-Sahoo , I have made appropriate changes , please do check .

Hey @Suchitra-Sahoo I want to work on this issue please assign me this issue

@K-Tikaraya Please assign to me task and solve the problem


Email Spamming

Hi
Why my all email goes to spam?
I have test email using mail-tester site and i got 8.5 score but still my email goes to spam only
Why? what will be the reason ?
Thanks

It will probably be that whoever you're sending email to doesn't completely trust your Postal server yet.
Can you share the details of your mail-tester score?

https://www.mail-tester.com/web-6cue1

Your IP seems to be in a blacklist, almost no chance to be clear out from spam:
-1.644 | RCVD_IN_BRBL_LASTEXT | Your sending server IP is listed in the Barracuda blacklist<IP_ADDRESS> listed in bb.barracudacentral.org

You have to check with the list how to delist yourself.

i haven't send more then 100 email till yet n it's show black list... surprised
Given bb.barracudacentral.org website is not working

You have to warm up your IP which is sending a small amount of messages at first and then progressively increasing this total.  It could take several weeks before remote mail systems start trusting mail from your Postal server.  For example, Gmail will usually block postal traffic the first few days you try sending to it.


[Android] Refunded inapp purchase still shows status=Purchased

Bug Information
I'm testing a new in-app (non-consumable) purchase. The purchase succeeds, and I acknowledge the purchase. To repeat my tests, I want to refund the purchase so it can be repeated with a different simulated payment type. After refunding the purchase on the Google Play developer console, the purchase status shows as "Refunded", but when I get the purchase in my app, it shows as "Purchased". I verified that the purchase IDs match.
Version Number of Plugin: 5.0.1-beta
Device Tested On: OnePlus 7 Pro
Simulator Tested On:
Version of VS: 16.10.4
Version of Xamarin: <IP_ADDRESS>
Versions of other things you are using:
Xamarin.Android.SDK: <IP_ADDRESS>
Steps to reproduce the Behavior

Purchase an in-app product (non-consumable)
Use the Google Play dev console to refund the order
Get the user's purchases in the app.

Expected Behavior
Purchase object shows Status = Refunded
Actual Behavior
Purchase object shows Status = Purchased

Double check -> https://developer.android.com/google/play/billing/test
you may also need to clear out your Google play data.
I just return what they send me.

Yes, those are the instructions I've been using. I tried deleting all data for "Google Play Services", but there was no change. Then, I tried deleting all data for "Google Play Store" and that solved the problem. Thanks for the suggestion.

@jamesmontemagno  - just FYI... I updated the status on this. This remains an annoying problem, but not yours.


Avoid copying a ref in a loop

Avoid triggering a warning from newer Clang, which turns into an error
on macOS.

This avoids an error with updated XCode compilers on macOS.


HTTP 502 error querying private repo with GITHUB_TOKEN

I'm trying to get information about our pull requests from an internal repo and I'm getting a 502 error and I'm not sure how to debug what the issue is:
mergestat "SELECT count(*) from github_repo_prs('private-org/private-repo');" -v
Apr 19 12:57:06 INF starting GitHub repo_pull_requests iterator for private-org/private-repo name=private-repo owner=private-org per-page=100
Apr 19 12:57:06 INF fetching page of repo_pull_requests for private-org/private-repo cursor=null name=private-repo owner=private-org per-page=100
Apr 19 12:57:13 INF fetching page of repo_pull_requests for private-org/private-repo cursor=Y3Vyc29yOnYyOpHOGcCNUA== name=private-repo owner=private-org per-page=100
+----------+
| COUNT(*) |
+----------+
+----------+
Apr 19 12:57:28 ERR failed to output resultset: non-200 OK status code: 502 Bad Gateway body: "{\n   \"data\": null,\n   \"errors\":[\n      {\n         \"message\":\"Something went wrong while executing your query. This may be the result of a timeout, or it could be a GitHub bug. Please include `51EA:050C:152958:3CEDAD:625EF7F3` when reporting this issue.\"\n      }\n   ]\n}\n"

Hi @klauern - it's hard to know exactly from the GitHub API error, but something to try would be to set the GITHUB_PER_PAGE env variable to a smaller number (it defaults to 100) - try 50, if that doesn't address it, try going lower.
My guess is the relevant bit of the message is This may be the result of a timeout. If you're requesting too much data at once (many PRs with lots of content in their body for instance), it could cause the GitHub API to take too long to respond and throw this error.
Let me know if that helps!
We may want to change the default from 100 to a smaller number, as it's not uncommon to hit this type of error

Thank you for the tip!  I didn't know the GITHUB_PER_PAGE var was available.  I dropped it to 50 and things seem to be working.

do you have any flags for wait periods between queries?
Apr 19 13:41:49 ERR failed to output resultset: non-200 OK status code: 403 Forbidden body: "{\n  \"documentation_url\": \"https://docs.github.com/en/free-pro-team@latest/rest/overview/resources-in-the-rest-api#secondary-rate-limits\",\n  \"message\": \"You have exceeded a secondary rate limit. Please wait a few minutes before you try again.\"\n}\n"

ok, I am using GITHUB_RATE_LIMIT as well, so I'll fiddle with these two values to see if I can find a happy place that passes all the tests.  50 and 1/3 don't appear to be enough

Great - GITHUB_RATE_LIMIT would be what I'd suggest. So if you're triggering a "secondary" rate limit, slowing down the call frequency may not actually address it. You might need to reduce the GITHUB_PER_PAGE again, as I believe the secondary limit could be triggered based on the "complexity" of results. This page has some info as well. My suggestion would be to try reducing GITHUB_PER_PAGE again to see if that helps. It makes the total collection run slower...but may avoid some of these errors


JSON Schema breaks valid ENV Variables

https://github.com/runatlantis/helm-charts/blob/c86eab114b0ec1f8d0bce812d5bbc9f7baacc30b/charts/atlantis/values.schema.json#L859C1-L865C7
Error
│ - environment.ATLANTIS_WRITE_GIT_CREDS: Invalid type. Expected: string, given: boolean
│ - environment.ATLANTIS_ALLOW_DRAFT_PRS: Invalid type. Expected: string, given: boolean

locals.tf
  environment_variables = {
    ATLANTIS_DEFAULT_TF_VERSION = "v1.5.2"
    ATLANTIS_WRITE_GIT_CREDS    = "true"
    ATLANTIS_ALLOW_DRAFT_PRS    = "true"
  }

Part of a helm_resource
  dynamic "set" {
    for_each = local.environment_variables

    content {
      name  = format("environment.%s", upper(set.key))
      value = format("%s", set.value)
    }
  }

Whats rendered
  - environment              = {
      - ATLANTIS_ALLOW_DRAFT_PRS    = true
      - ATLANTIS_DEFAULT_TF_VERSION = "v1.5.2"
      - ATLANTIS_WRITE_GIT_CREDS    = true
    }

This was working, and the docs read like its a bool: https://github.com/runatlantis/atlantis/blob/main/runatlantis.io/docs/server-configuration.md?plain=1#L1082

Should we close this?

@jamengual this was fixed in #338


fix error when method doesn't have a declaring type

The declaring type is sometimes null. Here's how RollbarSharp handled it:
https://github.com/mroach/RollbarSharp/blob/master/src/RollbarSharp/Builders/FrameModelBuilder.cs#L56
fileName = method.ReflectedType != null
			   ? method.ReflectedType.FullName
			   : "(unknown)";

I'll see about getting this in hopefully by Friday at the latest. Will try to shoot for sooner though.
Thanks a lot. :D


Feat/tests

Implement transcripts list tests

First, you can't get the value of { foo, baz } inside /bar/:foo/bar/:baz which i suppose you thought to be a placeholder
why ? because RA has its own way to manage navigation between pages unlike express, springboot or something like that.
Line 9: i separated the Version List from TranscriptShow details
now, I can access the _context values of the  component which holds bunch of useful data, because
 is being rendered inside  and is a separate component so i can do separate computation.
in this case, i can access id in the ShowContext.record object and make use of 'em to fetch versions data


Exporting InnerHTML doesn't get me what I see?

So i spent a while making, debugging and modifying a bit Quill, adding some custom modules and whatnot, only to find out that the result of innerHTML lacks all styling?
The very reason why I swicthed to Quill was for is WYSIWYG abilities, as so described everywhere on the website, but visibly doesn't get me what i'm seeing? what's going on here?
For the time being, i'm manually importing some CSS styling like this
<link<EMAIL_ADDRESS>rel="stylesheet">
<link<EMAIL_ADDRESS>rel="stylesheet">
but I feel this is something that should be given by default?

same


Search Bar on Browser

Searching URLs is very difficult from the terminal.

I think is implemented thanks to @jackpot51. See https://github.com/redox-os/orbutils/commit/8d50cb7324238e5c1a3ab9c377f71332e958e61a

Thanks!


Fix bug in cloudsnapshot functions

When running cloudsnapshot functions on a system that is running several
mkcloud created clouds, the createcloudsnapshot/restorecloudfromsnapshot
functions are a bit too greedy removing logical volumes.

+1 if someone tested it

@bmwiedemann I'll test it on my workstation. Should have an update by tomorrow.

@bmwiedemann: On my workstation with two clouds running this works as expected.

then, +1


dynamic table creation

is it possible to create the model tables via the API? or i need to create an .sql file dependent on the driver?

You'll need to manage the scheme using something else, MicroLite doesn't support schema creation and updates, quite often they require more than a tool can generate.
Personally I use a combination of the RedGate tools to create scripts and DbUp to update a database. There are other sorts of migration tools you could look at or just manage .sql scripts yourself

I suggest https://github.com/jonwagner/Insight.Database.Schema :)


Displayed labels disappear/appear while "throwing" the graph

When I pan the graph quickly, when I release the mouse button, the graph is "thrown" (which is a feature), and some displayed labels appear or disappear (which is a bug).
This is linked to camera animations. If you open an example, zoom somewhere in the graph and type in your JS console:
renderer.camera.animate({
  ...renderer.camera.getState(),
  x: renderer.camera.getState().x + 0.001
});

the displayed labels will probably change.
We miss an early escape in the labels heuristics for when the camera stays still - but adding it will break things, such as displayed labels for the initial rendering, displayed labels when the graph is updated or for whatever reason that is not a camera move.
We probably need to add the early escape as well as a force option that skips all early escapes, and add this force flag for some cases (which ones?).

This is solved since v2.0.0-beta8, with the new labels grid management.


status: Make the docker-receive app optional

Users restoring from a cluster backup may not have a docker-receive release, so docker-receive will not start as part of bootstrap, causing the final status check to fail.
Given not all users will be using docker-receive, we should just make it optional and have a mechanism to create a release and scale it up when pushing an image.

LGTM


[AUTOPATCHER] Patches CVE-2021-38207 for kernel

        Patches CVE-2021-38207 for kernel.
        This patch and PR was automatically generated and needs human verification before merging.

Closing Autopatch of Kernel.  Tooling error.


copy/paste question

in edit quiz page. would it be possible to get a copy button to easyly copy the tet in the field instead of having to manually select and copy

Kamino closed and cloned this issue to louis-antoine-etsmtl/EvalueTonSavoir


Update legacy oracle proposals to new proposal formats using msg server

Update legacy oracle proposals to new proposal formats using msg server
Add migration script to migrate eden vesting to 12hrs
Update joinPool & exitPool sender to be accepted by wasmbinding broker address

software upgrade test ✅
2:54PM ERR CONSENSUS FAILURE!!! err="UPGRADE \"v0.29.21\" NEEDED at height: 6278056: " module=consensus stack="goroutine 42 [running]:\nruntime/debug.Stack()\n\truntime/debug/stack.go:24 +0x64\ngithub.com/cometbft/cometbft/consensus.(*State).receiveRoutine.func2()\n\tgithub.com/cometbft/cometbft@v0.37.2/consensus/state.go:732 +0x44\npanic({0x1077e40c0, 0x14000d6fde0})\n\truntime/panic.go:884 +0x204\ngithub.com/cosmos/cosmos-sdk/x/upgrade.BeginBlocker(_, {{0x107ccbe40, 0x140002f0080}, {0x107ce2130, 0x1400a9eeb80}, {{0xb, 0x0}, {0x1400631ab00, 0xd}, 0x5fcba8, ...}, ...}, ...)\n\tgithub.com/cosmos/cosmos-sdk@v0.47.4/x/upgrade/abci.go:78 +0xc28\ngithub.com/cosmos/cosmos-sdk/x/upgrade.AppModule.BeginBlock(...)\n\tgithub.com/cosmos/cosmos-sdk@v0.47.4/x/upgrade/module.go:161\ngithub.com/cosmos/cosmos-sdk/types/module.(*Manager).BeginBlock(_, {{0x107ccbe40, 0x140002f0080}, {0x107ce2130, 0x1400a9eeb80}, {{0xb, 0x0}, {0x1400631ab00, 0xd}, 0x5fcba8, ...}, ...}, ...)\n\tgithub.com/cosmos/cosmos-sdk@v0.47.4/types/module/module.go:562 +0x170\ngithub.com/elys-network/elys/app.(*ElysApp).BeginBlocker(...)\n\tgithub.com/elys-network/elys/app/app.go:1343\ngithub.com/cosmos/cosmos-sdk/baseapp.(*BaseApp).BeginBlock(_, {{0x1400cfc20a0, 0x20, 0x20}, {{0xb, 0x0}, {0x1400631ab00, 0xd}, 0x5fcba8, {0x2eca8018, ...}, ...}, ...})\n\tgithub.com/cosmos/cosmos-sdk@v0.47.4/baseapp/abci.go:196 +0x674\ngithub.com/cometbft/cometbft/abci/client.(*localClient).BeginBlockSync(_, {{0x1400cfc20a0, 0x20, 0x20}, {{0xb, 0x0}, {0x1400631ab00, 0xd}, 0x5fcba8, {0x2eca8018, ...}, ...}, ...})\n\tgithub.com/cometbft/cometbft@v0.37.2/abci/client/local_client.go:283 +0x108\ngithub.com/cometbft/cometbft/proxy.(*appConnConsensus).BeginBlockSync(_, {{0x1400cfc20a0, 0x20, 0x20}, {{0xb, 0x0}, {0x1400631ab00, 0xd}, 0x5fcba8, {0x2eca8018, ...}, ...}, ...})\n\tgithub.com/cometbft/cometbft@v0.37.2/proxy/app_conn.go:101 +0xf4\ngithub.com/cometbft/cometbft/state.execBlockOnProxyApp({0x107ccd3b0?, 0x14006f20de0}, {0x107cde7c0, 0x14000a288e8}, 0x1400effe3c0, {0x107ce2d38, 0x14001296108}, 0x5fcba7?)\n\tgithub.com/cometbft/cometbft@v0.37.2/state/execution.go:363 +0x3e8\ngithub.com/cometbft/cometbft/state.(*BlockExecutor).ApplyBlock(_, {{{0xb, 0x0}, {0x14006ee17da, 0x6}}, {0x14006ee17f0, 0xd}, 0x5fcba0, 0x5fcba7, {{0x140094f6800, ...}, ...}, ...}, ...)\n\tgithub.com/cometbft/cometbft@v0.37.2/state/execution.go:197 +0xe4\ngithub.com/cometbft/cometbft/consensus.(*State).finalizeCommit(0x140016c8e00, 0x5fcba8)\n\tgithub.com/cometbft/cometbft@v0.37.2/consensus/state.go:1700 +0x964\ngithub.com/cometbft/cometbft/consensus.(*State).tryFinalizeCommit(0x140016c8e00, 0x5fcba8)\n\tgithub.com/cometbft/cometbft@v0.37.2/consensus/state.go:1609 +0x28c\ngithub.com/cometbft/cometbft/consensus.(*State).enterCommit.func1()\n\tgithub.com/cometbft/cometbft@v0.37.2/consensus/state.go:1544 +0xa0\ngithub.com/cometbft/cometbft/consensus.(*State).enterCommit(0x140016c8e00, 0x5fcba8, 0x0)\n\tgithub.com/cometbft/cometbft@v0.37.2/consensus/state.go:1582 +0xb90\ngithub.com/cometbft/cometbft/consensus.(*State).addVote(0x140016c8e00, 0x14003d8a6e0, {0x0, 0x0})\n\tgithub.com/cometbft/cometbft@v0.37.2/consensus/state.go:2212 +0x1790\ngithub.com/cometbft/cometbft/consensus.(*State).tryAddVote(0x140016c8e00, 0x14003d8a6e0, {0x0?, 0x1042c6d40?})\n\tgithub.com/cometbft/cometbft@v0.37.2/consensus/state.go:2001 +0x28\ngithub.com/cometbft/cometbft/consensus.(*State).handleMsg(0x140016c8e00, {{0x107c9efe0, 0x1400093e1c0}, {0x0, 0x0}})\n\tgithub.com/cometbft/cometbft@v0.37.2/consensus/state.go:861 +0x37c\ngithub.com/cometbft/cometbft/consensus.(*State).receiveRoutine(0x140016c8e00, 0x0)\n\tgithub.com/cometbft/cometbft@v0.37.2/consensus/state.go:788 +0x350\ncreated by github.com/cometbft/cometbft/consensus.(*State).OnStart\n\tgithub.com/cometbft/cometbft@v0.37.2/consensus/state.go:379 +0xf4\n"
2:54PM INF service stop impl={"Logger":{"Logger":{}}} module=consensus msg={} wal=/tmp/elys/data/cs.wal/wal
2:54PM INF service stop impl={"Dir":"/tmp/elys/data/cs.wal","Head":{"ID":"pC3p6Sa4uPgZ:/tmp/elys/data/cs.wal/wal","Path":"/tmp/elys/data/cs.wal/wal"},"ID":"group:pC3p6Sa4uPgZ:/tmp/elys/data/cs.wal/wal","Logger":{"Logger":{}}} module=consensus msg={} wal=/tmp/elys/data/cs.wal/wal
2024/03/06 14:54:39 Block height 6278056 reached
2:54PM INF Ensure peers module=pex numDialing=0 numInPeers=0 numOutPeers=0 numToDial=10
2:54PM INF No addresses to dial. Falling back to seeds module=pex
2:54PM INF Timed out dur=3000 height=6278056 module=consensus round=0 step=3
2024/03/06 14:54:44 Process killed successfully
2024/03/06 14:54:44 Process was killed: signal: killed
2024/03/06 14:54:49 Waiting for node to start...
2:54PM INF starting node with ABCI Tendermint in-process module=server
2:54PM INF service start impl=multiAppConn module=proxy msg={}
2:54PM INF service start connection=query impl=localClient module=abci-client msg={}
2:54PM INF service start connection=snapshot impl=localClient module=abci-client msg={}
2:54PM INF service start connection=mempool impl=localClient module=abci-client msg={}
2:54PM INF service start connection=consensus impl=localClient module=abci-client msg={}
2:54PM INF service start impl=EventBus module=events msg={}
2:54PM INF service start impl=PubSub module=pubsub msg={}
2:54PM INF service start impl=IndexerService module=txindex msg={}
2:54PM INF ABCI Handshake App Info hash="�Ի\x7f��4\"�\x18g����6|\naUk�1����B�<�~" height=6278055 module=consensus protocol-version=0 software-version=v0.29.21
2:54PM INF ABCI Replay Blocks appHeight=6278055 module=consensus stateHeight=6278055 storeHeight=6278056
2:54PM INF Replay last block using real app module=consensus
2:54PM INF applying upgrade "v0.29.21" at height: 6278056 module=server
2:54PM INF Running upgrade handler for v0.29.21 module=server
2:54PM INF Deleting proposals with ID <= 113 module=server
2:54PM INF migrating module commitment from version 1 to version 2 module=server
2:54PM INF migrating module oracle from version 2 to version 3 module=server


Return fixture relationship IDs if not an object (fix #166)

Handle FactoryGuy.make() with relationships specified as IDs.

Sorry I did not include this in last release @mmelvin0. For some reason I just missed it. Ugh.


⚠ Bofrost.de has degraded performance

In d590336, Bofrost.de (https://www.bofrost.de) experienced degraded performance:

HTTP code: 200
Response time: 944 ms

Resolved: Bofrost.de performance has improved in 82abb92 after 7 minutes.


Training (clients and subfolders)

I am unable to do training on what is meaning by creating clients can you explain. How to create subfolders and manage it.

Hello,
as written in the referenced paper, the script simulates a network of server and clients, which are all hosted on the same computer. To start the federated training, you have to prepare a folder, in which there is one subfolder for each client. A structure like the following:

In our research, we assumed one attack type per client (so, the name of the folders above), but you can do whatever you want, even giving a portion of every attack to each client (for instance).
Each client's folder must contain the usual training/validation/test files, as obtained by using the LUCID dataset parser:

Hope this clarifies.
All the best
--roberto


Setting camera rotation switches X and Y angles

Camera rotation should be set in euler angles, according to void SET_CAM_ROT(Cam cam, float rotX, float rotY, float rotZ, int rotationOrder), first parameter is rotation around X axis, second around Y axis, third around Z axis.
But when creating new camera and setting its rotation, it does not work correctly. X and Y are switched.
I want to create new camera, in fixed position, loking downwards. That means rotation around Y axis for 270 degrees, doing a "pitch" in (roll, pitch, yaw) terminology. That code should do it.
var newCamera = World.CreateCamera(new Vector3(), new Vector3(), 50);
newCamera.NearClip = 0.15f;
newCamera.IsActive = true;
newCamera.Position = new Vector3(-1078f, -216f, 37f);
newCamera.Rotation = new Vector3(0f, 270f, 0f);

but this instead it performs roll, rotation around X axis, for 270 degrees, can be seen on this screenshot

The correct position, performing pitch, is done by
var newCamera = World.CreateCamera(new Vector3(), new Vector3(), 50);
newCamera.NearClip = 0.15f;
newCamera.IsActive = true;
newCamera.Position = new Vector3(-1078f, -216f, 37f);
newCamera.Rotation = new Vector3(270f, 0f, 0f);

and it looks like that, which is desired result:

Note I tried to perform the rotation myself by calling the SET_CAM_ROT function, tried various values of the rotationOrder variable, but nothing changed.
Is this a bug, or did I mess up understanding of GTA coordinate system?
Because all other rotations, rotation of entites (cars, peds) seem to be in Euler angles.
E.g. when calculating bounding box of car from its position, rotation and model dimensions, math for classical euler angles applies, without any switching of X and Y angle.

@racinmat
As said for function "SET_CAM_ROT" in
http://www.dev-c.com/nativedb/
rotationOrder seems to be the constant. Which is why SHVDN doesnt take any argument for that.

The function is working properly.
You quote : "did I mess up understanding of GTA coordinate system?" :  Yes

Check the coordinate system of GTA 5 from my previous comment, and as usual "right hand thumb" rule applies for rotation around axes.

Thanks, I has wrong assumption about the order of angles, I though they were Euler angles.

That confused me, thanks for clarification. For some reason, With this definition of rotation around axes, it makes sense.


Update tensor_dataset.py

Fix bug in self.transform_y:
self.transform_y was applied to x instead of y

Thank you for spotting and fixing @slanthaler !


[MODULE] - financial/insurance email extraction via GPT

Please describe the module you would like to add to bricks
financial/insurance Email extraction via GPT
Do you already have an implementation?
It can be used various keywords like insurance company, adress, website, etc.
extraction_keyword1 = "insurance companies"
extraction_keyword2 = "insured company"
extraction_keyword3 = f"website of {extraction_keyword2}"

I made a first attempt for this brick.