Add subdirectories of site-lisp/ to Emacs' load-path

Issue description
Many Emacs packages, for instance mu4e, move their .el-files into a subdirectory of $out/share/emacs/site-lisp. Nixpkgs currently only adds all files located in $out/share/emacs/site-lisp to the load-path but does not add the files in its subdirectories. This currently makes mu4e from Nixpkgs unusable (by default).
We have to fix this snippet of code: https://github.com/NixOS/nixpkgs/blob/master/pkgs/applications/editors/emacs/site-start.el#L1-L5
Steps to reproduce
E.g. nix-env -i mu4e will not make mu4e available within GNU Emacs.

This broke the package realgud which have subdirectories that include "non-public" files, which gets required as the wrong package for python, is etc. See https://github.com/realgud/realgud/issues/234#issuecomment-471254002
Perhaps this should be revisited? I am not sure if this potentially breaks some other packages.

I have reverted this locally (or at least I think so, could be that the change was not propagated somehow), but still seems like paths are added, I see a lot of projects test directories being added to the load-path e.t.c.

Here is an example of bad load-path and this is just a subset of them all, nix-shell to reproduce:
nix-shell -p '(pkgs.emacsPackagesNgGen pkgs.emacs26).emacsWithPackages(epkgs: (with epkgs.melpaPackages; [ realgud ansible parrot alchemist ]))' --run 'emacs -Q'

(
"/nix/store/481qlvqh4q259bsqi2zngk0fk290sv7n-emacs-packages-deps/share/emacs/site-lisp"
"/nix/store/481qlvqh4q259bsqi2zngk0fk290sv7n-emacs-packages-deps/share/emacs/site-lisp/elpa"
"/nix/store/481qlvqh4q259bsqi2zngk0fk290sv7n-emacs-packages-deps/share/emacs/site-lisp/elpa/alchemist-20180312.604"
"/nix/store/481qlvqh4q259bsqi2zngk0fk290sv7n-emacs-packages-deps/share/emacs/site-lisp/elpa/ansible-20180812.1814"
"/nix/store/481qlvqh4q259bsqi2zngk0fk290sv7n-emacs-packages-deps/share/emacs/site-lisp/elpa/company-20181221.738"
"/nix/store/481qlvqh4q259bsqi2zngk0fk290sv7n-emacs-packages-deps/share/emacs/site-lisp/elpa/dash-20180910.1156"
"/nix/store/481qlvqh4q259bsqi2zngk0fk290sv7n-emacs-packages-deps/share/emacs/site-lisp/elpa/elixir-mode-20180711.545"
"/nix/store/481qlvqh4q259bsqi2zngk0fk290sv7n-emacs-packages-deps/share/emacs/site-lisp/elpa/epl-20180205.1249"
"/nix/store/481qlvqh4q259bsqi2zngk0fk290sv7n-emacs-packages-deps/share/emacs/site-lisp/elpa/f-20180106.122"
"/nix/store/481qlvqh4q259bsqi2zngk0fk290sv7n-emacs-packages-deps/share/emacs/site-lisp/elpa/load-relative-20170526.310"
"/nix/store/481qlvqh4q259bsqi2zngk0fk290sv7n-emacs-packages-deps/share/emacs/site-lisp/elpa/loc-changes-20160801.1008"
"/nix/store/481qlvqh4q259bsqi2zngk0fk290sv7n-emacs-packages-deps/share/emacs/site-lisp/elpa/parrot-20181026.912"
"/nix/store/481qlvqh4q259bsqi2zngk0fk290sv7n-emacs-packages-deps/share/emacs/site-lisp/elpa/pkg-info-20150517.443"
"/nix/store/481qlvqh4q259bsqi2zngk0fk290sv7n-emacs-packages-deps/share/emacs/site-lisp/elpa/realgud-20181210.1125"
"/nix/store/481qlvqh4q259bsqi2zngk0fk290sv7n-emacs-packages-deps/share/emacs/site-lisp/elpa/s-20180406.108"
"/nix/store/481qlvqh4q259bsqi2zngk0fk290sv7n-emacs-packages-deps/share/emacs/site-lisp/elpa/test-simple-20170527.832"
"/nix/store/481qlvqh4q259bsqi2zngk0fk290sv7n-emacs-packages-deps/share/emacs/site-lisp/elpa/alchemist-20180312.604/alchemist-server"
"/nix/store/481qlvqh4q259bsqi2zngk0fk290sv7n-emacs-packages-deps/share/emacs/site-lisp/elpa/ansible-20180812.1814/dict"
"/nix/store/481qlvqh4q259bsqi2zngk0fk290sv7n-emacs-packages-deps/share/emacs/site-lisp/elpa/ansible-20180812.1814/snippets"
"/nix/store/481qlvqh4q259bsqi2zngk0fk290sv7n-emacs-packages-deps/share/emacs/site-lisp/elpa/parrot-20181026.912/img"
"/nix/store/481qlvqh4q259bsqi2zngk0fk290sv7n-emacs-packages-deps/share/emacs/site-lisp/elpa/realgud-20181210.1125/realgud"
"/nix/store/481qlvqh4q259bsqi2zngk0fk290sv7n-emacs-packages-deps/share/emacs/site-lisp/elpa/alchemist-20180312.604/alchemist-server/lib"
"/nix/store/481qlvqh4q259bsqi2zngk0fk290sv7n-emacs-packages-deps/share/emacs/site-lisp/elpa/alchemist-20180312.604/alchemist-server/test"
"/nix/store/481qlvqh4q259bsqi2zngk0fk290sv7n-emacs-packages-deps/share/emacs/site-lisp/elpa/ansible-20180812.1814/snippets/text-mode"
"/nix/store/481qlvqh4q259bsqi2zngk0fk290sv7n-emacs-packages-deps/share/emacs/site-lisp/elpa/ansible-20180812.1814/snippets/yaml-mode"
"/nix/store/481qlvqh4q259bsqi2zngk0fk290sv7n-emacs-packages-deps/share/emacs/site-lisp/elpa/parrot-20181026.912/img/confused"
"/nix/store/481qlvqh4q259bsqi2zngk0fk290sv7n-emacs-packages-deps/share/emacs/site-lisp/elpa/parrot-20181026.912/img/default"
"/nix/store/481qlvqh4q259bsqi2zngk0fk290sv7n-emacs-packages-deps/share/emacs/site-lisp/elpa/parrot-20181026.912/img/emacs"
"/nix/store/481qlvqh4q259bsqi2zngk0fk290sv7n-emacs-packages-deps/share/emacs/site-lisp/elpa/parrot-20181026.912/img/nyan"
"/nix/store/481qlvqh4q259bsqi2zngk0fk290sv7n-emacs-packages-deps/share/emacs/site-lisp/elpa/parrot-20181026.912/img/rotating"
"/nix/store/481qlvqh4q259bsqi2zngk0fk290sv7n-emacs-packages-deps/share/emacs/site-lisp/elpa/parrot-20181026.912/img/science"
"/nix/store/481qlvqh4q259bsqi2zngk0fk290sv7n-emacs-packages-deps/share/emacs/site-lisp/elpa/parrot-20181026.912/img/thumbsup"
"/nix/store/481qlvqh4q259bsqi2zngk0fk290sv7n-emacs-packages-deps/share/emacs/site-lisp/elpa/realgud-20181210.1125/realgud/common"
"/nix/store/481qlvqh4q259bsqi2zngk0fk290sv7n-emacs-packages-deps/share/emacs/site-lisp/elpa/realgud-20181210.1125/realgud/debugger"
"/nix/store/481qlvqh4q259bsqi2zngk0fk290sv7n-emacs-packages-deps/share/emacs/site-lisp/elpa/realgud-20181210.1125/realgud/lang"
"/nix/store/481qlvqh4q259bsqi2zngk0fk290sv7n-emacs-packages-deps/share/emacs/site-lisp/elpa/alchemist-20180312.604/alchemist-server/lib/api"
"/nix/store/481qlvqh4q259bsqi2zngk0fk290sv7n-emacs-packages-deps/share/emacs/site-lisp/elpa/alchemist-20180312.604/alchemist-server/lib/helpers"
"/nix/store/481qlvqh4q259bsqi2zngk0fk290sv7n-emacs-packages-deps/share/emacs/site-lisp/elpa/alchemist-20180312.604/alchemist-server/lib/server"
"/nix/store/481qlvqh4q259bsqi2zngk0fk290sv7n-emacs-packages-deps/share/emacs/site-lisp/elpa/alchemist-20180312.604/alchemist-server/test/api"
"/nix/store/481qlvqh4q259bsqi2zngk0fk290sv7n-emacs-packages-deps/share/emacs/site-lisp/elpa/alchemist-20180312.604/alchemist-server/test/fixtures"
"/nix/store/481qlvqh4q259bsqi2zngk0fk290sv7n-emacs-packages-deps/share/emacs/site-lisp/elpa/alchemist-20180312.604/alchemist-server/test/helpers"
"/nix/store/481qlvqh4q259bsqi2zngk0fk290sv7n-emacs-packages-deps/share/emacs/site-lisp/elpa/alchemist-20180312.604/alchemist-server/test/server"
"/nix/store/481qlvqh4q259bsqi2zngk0fk290sv7n-emacs-packages-deps/share/emacs/site-lisp/elpa/ansible-20180812.1814/snippets/text-mode/ansible"
"/nix/store/481qlvqh4q259bsqi2zngk0fk290sv7n-emacs-packages-deps/share/emacs/site-lisp/elpa/realgud-20181210.1125/realgud/common/buffer"
"/nix/store/481qlvqh4q259bsqi2zngk0fk290sv7n-emacs-packages-deps/share/emacs/site-lisp/elpa/realgud-20181210.1125/realgud/debugger/bashdb"
"/nix/store/481qlvqh4q259bsqi2zngk0fk290sv7n-emacs-packages-deps/share/emacs/site-lisp/elpa/realgud-20181210.1125/realgud/debugger/gdb"
"/nix/store/481qlvqh4q259bsqi2zngk0fk290sv7n-emacs-packages-deps/share/emacs/site-lisp/elpa/realgud-20181210.1125/realgud/debugger/gub"
"/nix/store/481qlvqh4q259bsqi2zngk0fk290sv7n-emacs-packages-deps/share/emacs/site-lisp/elpa/realgud-20181210.1125/realgud/debugger/ipdb"
"/nix/store/481qlvqh4q259bsqi2zngk0fk290sv7n-emacs-packages-deps/share/emacs/site-lisp/elpa/realgud-20181210.1125/realgud/debugger/jdb"
"/nix/store/481qlvqh4q259bsqi2zngk0fk290sv7n-emacs-packages-deps/share/emacs/site-lisp/elpa/realgud-20181210.1125/realgud/debugger/kshdb"
"/nix/store/481qlvqh4q259bsqi2zngk0fk290sv7n-emacs-packages-deps/share/emacs/site-lisp/elpa/realgud-20181210.1125/realgud/debugger/nodejs"
"/nix/store/481qlvqh4q259bsqi2zngk0fk290sv7n-emacs-packages-deps/share/emacs/site-lisp/elpa/realgud-20181210.1125/realgud/debugger/pdb"
"/nix/store/481qlvqh4q259bsqi2zngk0fk290sv7n-emacs-packages-deps/share/emacs/site-lisp/elpa/realgud-20181210.1125/realgud/debugger/perldb"
"/nix/store/481qlvqh4q259bsqi2zngk0fk290sv7n-emacs-packages-deps/share/emacs/site-lisp/elpa/realgud-20181210.1125/realgud/debugger/rdebug"
"/nix/store/481qlvqh4q259bsqi2zngk0fk290sv7n-emacs-packages-deps/share/emacs/site-lisp/elpa/realgud-20181210.1125/realgud/debugger/remake"
"/nix/store/481qlvqh4q259bsqi2zngk0fk290sv7n-emacs-packages-deps/share/emacs/site-lisp/elpa/realgud-20181210.1125/realgud/debugger/trepan"
"/nix/store/481qlvqh4q259bsqi2zngk0fk290sv7n-emacs-packages-deps/share/emacs/site-lisp/elpa/realgud-20181210.1125/realgud/debugger/trepan.pl"
"/nix/store/481qlvqh4q259bsqi2zngk0fk290sv7n-emacs-packages-deps/share/emacs/site-lisp/elpa/realgud-20181210.1125/realgud/debugger/trepan2"
"/nix/store/481qlvqh4q259bsqi2zngk0fk290sv7n-emacs-packages-deps/share/emacs/site-lisp/elpa/realgud-20181210.1125/realgud/debugger/trepan3k"
"/nix/store/481qlvqh4q259bsqi2zngk0fk290sv7n-emacs-packages-deps/share/emacs/site-lisp/elpa/realgud-20181210.1125/realgud/debugger/trepanjs"
"/nix/store/481qlvqh4q259bsqi2zngk0fk290sv7n-emacs-packages-deps/share/emacs/site-lisp/elpa/realgud-20181210.1125/realgud/debugger/zshdb"
"/nix/store/481qlvqh4q259bsqi2zngk0fk290sv7n-emacs-packages-deps/share/emacs/site-lisp/elpa/ansible-20180812.1814/snippets/text-mode/ansible/a10"
"/nix/store/481qlvqh4q259bsqi2zngk0fk290sv7n-emacs-packages-deps/share/emacs/site-lisp/elpa/ansible-20180812.1814/snippets/text-mode/ansible/amazon"
"/nix/store/481qlvqh4q259bsqi2zngk0fk290sv7n-emacs-packages-deps/share/emacs/site-lisp/elpa/ansible-20180812.1814/snippets/text-mode/ansible/azure"
"/nix/store/481qlvqh4q259bsqi2zngk0fk290sv7n-emacs-packages-deps/share/emacs/site-lisp/elpa/ansible-20180812.1814/snippets/text-mode/ansible/basics"
"/nix/store/481qlvqh4q259bsqi2zngk0fk290sv7n-emacs-packages-deps/share/emacs/site-lisp/elpa/ansible-20180812.1814/snippets/text-mode/ansible/citrix"
"/nix/store/481qlvqh4q259bsqi2zngk0fk290sv7n-emacs-packages-deps/share/emacs/site-lisp/elpa/ansible-20180812.1814/snippets/text-mode/ansible/commands"
"/nix/store/481qlvqh4q259bsqi2zngk0fk290sv7n-emacs-packages-deps/share/emacs/site-lisp/elpa/ansible-20180812.1814/snippets/text-mode/ansible/digital_ocean"
"/nix/store/481qlvqh4q259bsqi2zngk0fk290sv7n-emacs-packages-deps/share/emacs/site-lisp/elpa/ansible-20180812.1814/snippets/text-mode/ansible/docker"
"/nix/store/481qlvqh4q259bsqi2zngk0fk290sv7n-emacs-packages-deps/share/emacs/site-lisp/elpa/ansible-20180812.1814/snippets/text-mode/ansible/f5"
"/nix/store/481qlvqh4q259bsqi2zngk0fk290sv7n-emacs-packages-deps/share/emacs/site-lisp/elpa/ansible-20180812.1814/snippets/text-mode/ansible/files"
"/nix/store/481qlvqh4q259bsqi2zngk0fk290sv7n-emacs-packages-deps/share/emacs/site-lisp/elpa/ansible-20180812.1814/snippets/text-mode/ansible/google"
"/nix/store/481qlvqh4q259bsqi2zngk0fk290sv7n-emacs-packages-deps/share/emacs/site-lisp/elpa/ansible-20180812.1814/snippets/text-mode/ansible/helper"
"/nix/store/481qlvqh4q259bsqi2zngk0fk290sv7n-emacs-packages-deps/share/emacs/site-lisp/elpa/ansible-20180812.1814/snippets/text-mode/ansible/inventory"
"/nix/store/481qlvqh4q259bsqi2zngk0fk290sv7n-emacs-packages-deps/share/emacs/site-lisp/elpa/ansible-20180812.1814/snippets/text-mode/ansible/language"
"/nix/store/481qlvqh4q259bsqi2zngk0fk290sv7n-emacs-packages-deps/share/emacs/site-lisp/elpa/ansible-20180812.1814/snippets/text-mode/ansible/linode"
"/nix/store/481qlvqh4q259bsqi2zngk0fk290sv7n-emacs-packages-deps/share/emacs/site-lisp/elpa/ansible-20180812.1814/snippets/text-mode/ansible/logic"
"/nix/store/481qlvqh4q259bsqi2zngk0fk290sv7n-emacs-packages-deps/share/emacs/site-lisp/elpa/ansible-20180812.1814/snippets/text-mode/ansible/messaging"
"/nix/store/481qlvqh4q259bsqi2zngk0fk290sv7n-emacs-packages-deps/share/emacs/site-lisp/elpa/ansible-20180812.1814/snippets/text-mode/ansible/misc"
"/nix/store/481qlvqh4q259bsqi2zngk0fk290sv7n-emacs-packages-deps/share/emacs/site-lisp/elpa/ansible-20180812.1814/snippets/text-mode/ansible/monitoring"
"/nix/store/481qlvqh4q259bsqi2zngk0fk290sv7n-emacs-packages-deps/share/emacs/site-lisp/elpa/ansible-20180812.1814/snippets/text-mode/ansible/mysql"
"/nix/store/481qlvqh4q259bsqi2zngk0fk290sv7n-emacs-packages-deps/share/emacs/site-lisp/elpa/ansible-20180812.1814/snippets/text-mode/ansible/network"
"/nix/store/481qlvqh4q259bsqi2zngk0fk290sv7n-emacs-packages-deps/share/emacs/site-lisp/elpa/ansible-20180812.1814/snippets/text-mode/ansible/notification"
"/nix/store/481qlvqh4q259bsqi2zngk0fk290sv7n-emacs-packages-deps/share/emacs/site-lisp/elpa/ansible-20180812.1814/snippets/text-mode/ansible/openstack"
"/nix/store/481qlvqh4q259bsqi2zngk0fk290sv7n-emacs-packages-deps/share/emacs/site-lisp/elpa/ansible-20180812.1814/snippets/text-mode/ansible/os"
"/nix/store/481qlvqh4q259bsqi2zngk0fk290sv7n-emacs-packages-deps/share/emacs/site-lisp/elpa/ansible-20180812.1814/snippets/text-mode/ansible/postgresql"
"/nix/store/481qlvqh4q259bsqi2zngk0fk290sv7n-emacs-packages-deps/share/emacs/site-lisp/elpa/ansible-20180812.1814/snippets/text-mode/ansible/rackspace"
"/nix/store/481qlvqh4q259bsqi2zngk0fk290sv7n-emacs-packages-deps/share/emacs/site-lisp/elpa/ansible-20180812.1814/snippets/text-mode/ansible/source_control"
"/nix/store/481qlvqh4q259bsqi2zngk0fk290sv7n-emacs-packages-deps/share/emacs/site-lisp/elpa/ansible-20180812.1814/snippets/text-mode/ansible/system"
"/nix/store/481qlvqh4q259bsqi2zngk0fk290sv7n-emacs-packages-deps/share/emacs/site-lisp/elpa/ansible-20180812.1814/snippets/text-mode/ansible/vmware"
"/nix/store/481qlvqh4q259bsqi2zngk0fk290sv7n-emacs-packages-deps/share/emacs/site-lisp/elpa/ansible-20180812.1814/snippets/text-mode/ansible/web_infrastructure"
"/nix/store/481qlvqh4q259bsqi2zngk0fk290sv7n-emacs-packages-deps/share/emacs/site-lisp/elpa/ansible-20180812.1814/snippets/text-mode/ansible/windows"
"/nix/store/p1if8dbvw752c5n4qrxrnkyjz45q0sln-emacs-26.1/share/emacs/26.1/lisp"
"/nix/store/p1if8dbvw752c5n4qrxrnkyjz45q0sln-emacs-26.1/share/emacs/26.1/lisp/vc"
"/nix/store/p1if8dbvw752c5n4qrxrnkyjz45q0sln-emacs-26.1/share/emacs/26.1/lisp/url"
"/nix/store/p1if8dbvw752c5n4qrxrnkyjz45q0sln-emacs-26.1/share/emacs/26.1/lisp/textmodes"
"/nix/store/p1if8dbvw752c5n4qrxrnkyjz45q0sln-emacs-26.1/share/emacs/26.1/lisp/progmodes"
"/nix/store/p1if8dbvw752c5n4qrxrnkyjz45q0sln-emacs-26.1/share/emacs/26.1/lisp/play"
"/nix/store/p1if8dbvw752c5n4qrxrnkyjz45q0sln-emacs-26.1/share/emacs/26.1/lisp/org"
"/nix/store/p1if8dbvw752c5n4qrxrnkyjz45q0sln-emacs-26.1/share/emacs/26.1/lisp/nxml"
"/nix/store/p1if8dbvw752c5n4qrxrnkyjz45q0sln-emacs-26.1/share/emacs/26.1/lisp/net"
"/nix/store/p1if8dbvw752c5n4qrxrnkyjz45q0sln-emacs-26.1/share/emacs/26.1/lisp/mh-e"
"/nix/store/p1if8dbvw752c5n4qrxrnkyjz45q0sln-emacs-26.1/share/emacs/26.1/lisp/mail"
"/nix/store/p1if8dbvw752c5n4qrxrnkyjz45q0sln-emacs-26.1/share/emacs/26.1/lisp/leim"
"/nix/store/p1if8dbvw752c5n4qrxrnkyjz45q0sln-emacs-26.1/share/emacs/26.1/lisp/language"
"/nix/store/p1if8dbvw752c5n4qrxrnkyjz45q0sln-emacs-26.1/share/emacs/26.1/lisp/international"
"/nix/store/p1if8dbvw752c5n4qrxrnkyjz45q0sln-emacs-26.1/share/emacs/26.1/lisp/image"
"/nix/store/p1if8dbvw752c5n4qrxrnkyjz45q0sln-emacs-26.1/share/emacs/26.1/lisp/gnus"
"/nix/store/p1if8dbvw752c5n4qrxrnkyjz45q0sln-emacs-26.1/share/emacs/26.1/lisp/eshell"
"/nix/store/p1if8dbvw752c5n4qrxrnkyjz45q0sln-emacs-26.1/share/emacs/26.1/lisp/erc"
"/nix/store/p1if8dbvw752c5n4qrxrnkyjz45q0sln-emacs-26.1/share/emacs/26.1/lisp/emulation"
"/nix/store/p1if8dbvw752c5n4qrxrnkyjz45q0sln-emacs-26.1/share/emacs/26.1/lisp/emacs-lisp"
"/nix/store/p1if8dbvw752c5n4qrxrnkyjz45q0sln-emacs-26.1/share/emacs/26.1/lisp/cedet"
"/nix/store/p1if8dbvw752c5n4qrxrnkyjz45q0sln-emacs-26.1/share/emacs/26.1/lisp/calendar"
"/nix/store/p1if8dbvw752c5n4qrxrnkyjz45q0sln-emacs-26.1/share/emacs/26.1/lisp/calc"
"/nix/store/p1if8dbvw752c5n4qrxrnkyjz45q0sln-emacs-26.1/share/emacs/26.1/lisp/obsolete"
)


Update to latest ELK stack

The PR upgrades all the ELK components to:

Java8
Elasticsearch 1.4.4
Logstash 1.5.0.rc2
Kibana 4.0.1

You're brave upgrading both software and its runtime in a single step. Personally I would have been a bit more conservative and done java after we successfully deployed and confirmed the other upgrades. But, if you're confident everything is working, I'm good with that.
I didn't realize logstash 1.5 hadn't been release yet - are we going to wait to merge until 1.5 is stable and we've updated this branch with it?

It turns out that this upgrade is going to be breaking; so I'm inclined to bundle all the breaks into one release.
Specifically:

Logstash 1.5 breaks some filters (specificaly those that muck about with ruby Time)
Java8 disables SSLv3, which breaks nxlog < 2.9

are we going to wait to merge until 1.5 is stable and we've updated this branch with it

Lets wait up to 2 weeks, and then make this call again.

logsearch-shipper then also needs to be updated and redeployed to all the deployments using it - otherwise it sounds like encrypted syslog forwarding is going to break when the target logsearch is upgraded.

Yes - logsearch-shipper needs to be upgraded

@dpb587, You can now enable SSLv3 support (its disabled by default) by adding this to your deploy manifest:
logstash_ingestor:
	syslog_tls:
		jdk_tls_client_protocols:"SSLv3,TLSv1,TLSv1.1,TLSv1.2"

logsearch-shipper should still be upgraded to nxlog 2.9, but it isn't required to deploy logsearch v19

Great, thanks.

@dpb587, I've pulled logsearch/logsearch-filters-common into src/logsearch-filters-common as we discussed.
After removing (see https://github.com/cityindex/logsearch-filters-internal/pull/55) the syslog filters from cityindex/logsearch-filters-internal, the resulting running /var/vcap/jobs/log_parser/config/logstash.conf is the same, as expected.
I'm fairly pleased with the outcome.  Any further thoughts?

BUG:  It turns out that for SSLv3 to be supported the /var/vcap/packages/java8/lib/security/java.security file must be edited and SSLv3 removed from the jdk.tls.disabledAlgorithms=SSLv3 setting

@dpb587, could you peer review these changes please

@dpb587 I've deployed this to meta.logsearch.io - https://github.com/cityindex/labs-operations/compare/2135b58017d5...9719435c4add - and it seems to be working ok.

@dpb587, Its also deployed to cityindex.logsearch.io - https://github.com/cityindex/labs-operations/compare/9719435c4add...cbfe776225d4
If you are happy after review, please just go ahead and merge this PR.


Stride Issue in ResNet?

https://github.com/labmlai/annotated_deep_learning_paper_implementations/blob/b10e3dea2c7e1f6569bfdf8e1a48f8d48b5a645d/labml_nn/resnet/__init__.py#L286-L288
Your annotation in the above code says: "The first block for the new feature map size, will have a stride length of 2, except fro the very first block".
On the contrary, your implementaion means the first convolution of the very first block has a stride of 2, and the first convolution of other blocks have a stride of 1. I think this is an issue.

Another question, in the original ResNet paper, there is a max pooling layer before the first residual block. It doesn't exist in your implementation, why?

A block consists of a few convolution layers https://nn.labml.ai/resnet/index.html#section-8
https://github.com/labmlai/annotated_deep_learning_paper_implementations/blob/master/labml_nn/resnet/__init__.py#L119-L141
The first convolution layer and the projection for shortcut has a stride of 2 or 1. The other convolution layer always have a stride of 1.
This loop adds multiple blocks in series.
https://github.com/labmlai/annotated_deep_learning_paper_implementations/blob/master/labml_nn/resnet/__init__.py#L285-L308
On each iteration i of the outer loop it adds n_blocks[i] number of blocks with channels number of channels. All the blocks of a single iteration have same feature map size.
The first block of a feature map size will have a stride length of 2 and the next n_blocks[i] -  blocks will have a stride length 1.
And the very first block i = 0 will also have a stride of 1.
I feel the description is correct. May be there is a better way to phrase it.

As for the pooling layer, this implementation was for CIFAR-10 dataset. The paper says the feature map sizes are 32x32, 16x16 and 8x8 (section 4.2) which implies there is no pooling layer and that the initial convolution layer (before the residual blocks) has a stride of 1, since the image size is also 32x32.

About the max pooling layer, the paper mentions that the feature map sizes are 32x32, 16x16 ... for CIFAR-10 implementation in section 4.2. Since the image size is 32x32 this means that either the very first convolution layer has a stride length of 1 or that they omitted the max pooling. We chose to omit max pooling because they don't mention that in section 4.2.
While going through the code again to look at your question i figured we had a mistake where the initial convolution had a stride of 1 which i changed to 2. Thanks.
I feel that you would need the max pooling layer for larger images while it's not necessary since we are dealing with much smaller image sizes (32x32 vs 112x112).

Closing the issue


chore: use env https_proxy as oss client option proxy_host #12313

Fixes #12313
Motivation

Modifications

Verification

Beyond this PR

@shuangkun Could you help review this?

Okay

Hi @terrytangyuan and @isubasinghe,
I'd like to expedite the progress of this PR. It's crucial for supporting proxy settings in OSS client for us. Currently, we rely on Argo v3.4.8 with our self-fix build in our production environment. However, this setup is blocking any of our Argo Workflow upgrade plans, including trying out the new build which addresses the potential issue detailed in https://github.com/argoproj/argo-workflows/issues/11948.
I hope you can help move the review forward. Thank you so much.

Could you solve the test error？

Hi @jingkkkkai , please help to resolve the error for this PR.

@jingkkkkai DCO isn't passing and the test suite isn't passing, maybe try commit an empty commit.

Hi @shuangkun , @isubasinghe
the test suite passed after adding an empty commit, thanks for your help
then could you please help review the pr again?
additionally, is there a way to apply this change to branch v3.4?

Hi @isubasinghe,
All checks have passed now, can you help to move this PR forward?

Hi @terrytangyuan ,
Do you think Argo's development team could help cherry-pick this fix into the 3.4 branch? We're struggling with the build environment, and I believe it would be much easier for Argo's team to handle this.
Thanks,
Carol

@carolkao See https://github.com/argoproj/argo-workflows/issues/11851#issuecomment-2339509093

@carolkao See #11851 (comment)

Cool, thank you @terrytangyuan . Looking forward to the next 3.4 release.


Error in code.gs line 101

google script detect error  in code.gs at line 101 " for each (var address in adresses){ "

Could you please add some screenshots and details about what the error is saying exactly?

hi take this screenshot
On Sun, Jul 23, 2023 at 9:01 PM Kshitij Tiwari @.***>
wrote:

Could you please add some screenshots and details about what the error is
saying exactly?
—
Reply to this email directly, view it on GitHub
https://github.com/ktiwari9/event-management-system/issues/1#issuecomment-1646933085,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AH5JGPUCBHF27RDWYUSVETDXRVYJZANCNFSM6AAAAAA2UNVUBY
.
You are receiving this because you authored the thread.Message ID:
@.***>

Sorry don't see any screenshot. Perhaps try uploading it to Github issue tracker instead of email reply so it renders properly?

I send you on your mail
Le dim. 23 juil. 2023 à 20:44, Kshitij Tiwari @.***> a
écrit :

Sorry don't see any screenshot. Perhaps try uploading it to Github issue
tracker instead of email reply so it renders properly?
—
Reply to this email directly, view it on GitHub
https://github.com/ktiwari9/event-management-system/issues/1#issuecomment-1646943951,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AH5JGPWX44M5NBDLDWKOZQ3XRV5KLANCNFSM6AAAAAA2UNVUBY
.
You are receiving this because you authored the thread.Message ID:
@.***>

Ok got it. Have you tried replacing that with forEach() instead? Here is an example: https://spreadsheet.dev/foreach-loop-in-apps-script

i tries but nothing fix


Either3, Either4, Either5.

Not high priority and a bit of a nuisance to implement. But does come in handy.

Either3 was still kind of fun...

How should we call the cases for Either4 and Either5? Left, KindaLeftish...? Naa, just kidding.
Maybe just First, Second...
Or shorter: E1, E2...

I was thinking _1, _2, _3 wouldn't hurt.

I like it, but I'm afraid it might get confused with tuples.

E1, E2, ... Would be fine too.

Thank you for Either4. It will be useful in highj-typeable


Demuxalot: Limit number of parallel jobs

PR #46 paves the way to upgrade Demuxalot to the latest version (v. 0.4.0).
However, that version includes support for parallel processing via joblib.parallel  with a default value for n_jobs of -1, resulting in the use of all CPUs/threads provided by the system.
This PR addd a commit adding the -p/--nproc parameter (cf. Vireo) to override that default on top of PR #46.
Since Demuxalot's default behaviour could potentially result in bad surprises, the default value was changed from -1 to 1 in the wrapper script. Thus, existing pipelines using Demuxafy's Demuxalot.py script won't require any changes to avoid unexpected CPU loads.

closes #46

@drneavin: Just to clarify: If you merge this along upgrading the bundled Demuxalot to version >=0.4.1, PR #46 will be closed automatically and I can convert PR #48 from draft to ready, which would finally enable running Demuxafy on non-CellRanger data.

@drneavin: Any update on this? Did you encounter issues with my suggested changes or are you simply still busy with other things? Let me kniw if I can help somehow. Using a custom build python module on top of singularity is kinda painful, so I'd happily do more work to get a new container with those changes (and PR #48) included.

Hi @mschilli87, yes sorry it's just been a busy time on my end. I'm getting one thing off my plate at the end of the week that has been taking ~50% of my time so hoping I can get to this early next week. Will take some time to build it and test it but I'll let you know when I start the process

Hi @mschilli87 , I'm trying to attend to all the Demuxafy updates this week and wanted to clarify how you think it would be best to proceed with these changes. To be clear, all changes in pull request #46 are now included here so there is no reason to merge #46 before #47?
And then #48 can be merged as well since it seems there shouldn't be any conflicts between them?

@drneavin

To be clear, all changes in pull request #46 are now included here so there is no reason to merge #46 before #47?

Yes and yes.

And then #48 can be merged as well since it seems there shouldn't be any conflicts between them?

There might be a minor conflicts but I can either fix those in #48 once this is merged or rebase #48 on this branch now so you only have a single PR including all changes at once.


Change command descriptions to make sense

Pull request

[x] I have read and agreed to the code of conduct.
[x] I have read and complied with the contributing guidelines.
[ ] What I'm implementing was assigned to me or was not being worked on and is a somewhat requested feature. For reference see our GitHub projects.
[x] I have tested all of my changes.

Added/Changed
What did you add and/or change for this.
Feature
If this is a new feature, why should we add it to the bot.

jenkins build

We probably should add a . To everything but do we really need to do it?

I mean it can wait till lang cause we're going to be moving all of these anyway

Yup true. @JamesHawkinss Can you get that one change completed and we'll get this merged 😄

on it

@binaryoverload done xx

You didn't read my comment :(

the one about full stops?

@binaryoverload actually done this time


Preferences stops working after v3.2.10

After v3.2.10 /hawtio/preferences starts to redirect to /hawtio/Console%20Logs thus the Preferences page cannot be seen.
Initially I thought what I've done at master broke it, but even at v3.2.10 the behaviour reproduces and it doesn't happen at v3.2.9. You can check the issue by running yarn start in this hawtio-core project.

@akieling @astefanutti Do you guys have any ideas on this issue?

I'll have a look.
I've been making some changes to the hawtio-tabs component.
On Wed, Feb 14, 2018 at 9:36 AM, Tadayoshi Sato<EMAIL_ADDRESS>wrote:

@akieling https://github.com/akieling @astefanutti
https://github.com/astefanutti Do you guys have any ideas on this issue?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/hawtio/hawtio-core/issues/22#issuecomment-365576940,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AB0lT7VvxvVgvbDmgmJAC7ulKGh3doKpks5tUsUhgaJpZM4SFLKl
.

--
Alexandre KielingSr. Software Engineer, JBoss FuseRed Hat

@tadayosi ah indeed, I may have broken things to fix other stuff. I'll have a look ASAP as well.

It seems related to the change in the hawtio-tabs component.


Target not #defined when using mbed-rtos with ST Nucleo F072RB

Error: #error directive: "no target defined" in "mbed-rtos/rtx/RTX_Conf_CM.c", Line: 60, Col: 6
(but builds fine by changing board to e.g Nucleo F401RE)
Anyway .. Nice work  :)
regards
Andy

This issue can be closed.


Making frontend changes to output tags in the register-environment

Making frontend changes to output tags in the register-environment in Deploy RG.
Also making changes to not persist in task context in consumer(of output variables) tasks.

Need to bump minimum agent version when we check-in post the next deployment.

looks good now, just verify them and add tests to catch issues where one can change key in the dictionary

accept or close

Closing old PR.


Uncaught TypeError: Cannot redefine property: userDefinition

Dear @volkanceylan,
sometime I get the following error in console:

I know that it's impossible to guess what's wrong without see all my code, but I really have no idea on what could be the problem or where start looking for...
In your experience, what can produce those kind of error?
From console I tried to call the GetUserData and the response seems to be ok...

Any idea on what I can try to do in order to debug this thing?
Edit: digging digging I found that such error it's related to the "Object.defineProperty()" in Authorization.ts, but once again I don't know why...
Thank you very much for your support
Bye

Did you update jQuery?

@brunobola currently I've version 2.2.3 while in the version in the base project is 2.2.0...
Do you think that I should try a downgrade?
Thanks

This looks like same code that registering some propert is loading twice. Cant guess which but you might have duplicate items in bundle. E.g. Serenity.CoreLib.js separate and in bundle
Check html source.

I checked the json bundle config file twice and it seems to be ok:
{
  "Libs": [
    "~/Scripts/pace.js",
    "~/Scripts/rsvp.js",
    "~/Scripts/jquery-{version}.js",
    "~/Scripts/jquery-ui-{version}.js",
    "~/Scripts/jquery-ui-i18n.js",
    "~/Scripts/jquery.validate.js",
    "~/Scripts/jquery.blockUI.js",
    "~/Scripts/jquery.cookie.js",
    "~/Scripts/jquery.json.js",
    "~/Scripts/jquery.autoNumeric.js",
    "~/Scripts/jquery.colorbox.js",
    "~/Scripts/jquery.dialogextendQ.js",
    "~/Scripts/jquery.event.drag.js",
    "~/Scripts/jquery.scrollintoview.js",
    "~/Scripts/jsrender.js",
    "~/Scripts/select2.js",
    "~/Scripts/sortable.js",
    "~/Scripts/toastr.js",
    "~/Scripts/SlickGrid/slick.core.js",
    "~/Scripts/SlickGrid/slick.grid.js",
    "~/Scripts/SlickGrid/slick.groupitemmetadataprovider.js",
    "~/Scripts/SlickGrid/Plugins/slick.autotooltips.js",
    "~/Scripts/SlickGrid/Plugins/slick.headerbuttons.js",
    "~/Scripts/SlickGrid/Plugins/slick.rowselectionmodel.js",
    "~/Scripts/SlickGrid/Plugins/slick.rowmovemanager.js",
    "~/Scripts/bootstrap.js",
    "~/Scripts/Saltarelle/mscorlib.js",
    "~/Scripts/Saltarelle/linq.js",
    "~/Scripts/Serenity/Serenity.CoreLib.js",
    "~/Scripts/Serenity/Serenity.Script.UI.js",
    "~/Scripts/Serenity/Serenity.Externals.js",
    "~/Scripts/Serenity/Serenity.Externals.Slick.js",
    "~/Scripts/jquery.cropzoom.js",
    "~/Scripts/jquery.fileupload.js",
    "~/Scripts/jquery.iframe-transport.js",
    "~/Scripts/jquery.slimscroll.js",
    "~/Scripts/mousetrap.js",
    "~/Scripts/fastclick/fastclick.js",
    "~/Scripts/bootstrap-multiselect.js",
    "~/Scripts/bootbox.js",
    "~/Scripts/jquery.signalR-2.2.0.js"
  ],
  "Site": [
    "~/Scripts/adminlte/app.js",
    "~/Scripts/Site/eService.Web.js"
  ]
}

I tried to put a breakpoint clientside (on Chrome I mean) and such piece of code:
Object.defineProperty(Authorization, 'userDefinition', {
    get: function () {
        return Q.getRemoteData('UserData');
    }
});

is "hit" only once.
Moreover I checked also that in the sources such object definition has only one occurence.
The strange thing is that 99% of the time my application is working fine without any kind of error and suddenly (and rarely) it stops working with the error of the my first post.
I'm still digging but as a temporary workaround I have modified the code above in the following way:
Object.defineProperty(Authorization, 'userDefinition', {
    get: function () {
        return Q.getRemoteData('UserData');
    },
    enumerable: true,
    **configurable: true**
});

So if the object somehow will be redefined, it should be ok...
Thanks for your support
Bye

Thanks, i removed that one, some leftover from old project.
Anyway i'm pretty sure one of your scripts is loading twice sometimes, some ajax call might be the issue.

Uhm interesting...what kind of ajax call?  I use only your service calls (and a "get" for the counter like the sample that I've posted before).
Perhaps I use the clientside "userDefinition" too "early"? It make any sense to you?
Thanks as usual for your feedback
Bye


Fixed incorrect commands for generating reference docs

I followed the process for generating reference docs, but encountered and fixed some problems along the way due to incorrect commands in the documentation:

Fixed incorrect go get source for github.com/kubernetes-sigs/reference-docs
Fixed syntax error in shell commands by changing $(GOPATH) to $GOPATH
Fixed wrong variable name, changed WEB_ROOT to K8S_WEBROOT to match what Makefile expects

/assign @steveperry-53

/lgtm

Page preview:
https://deploy-preview-19693--kubernetes-io-master-staging.netlify.com/docs/contribute/generate-ref-docs/kubectl/

/approve


Enable command groups

Pull request summary

Re-enable command groups and fix the bug where a command could be called from outside of its group
Checklist

[x] If code changes were made then they have been tested.

[ ] I have updated the documentation to reflect the changes.
[ ] I have updated the changelog with a quick recap of my changes.

[ ] This PR fixes an issue.
[x] This PR adds something new (e.g. new method or parameters).
[ ] This PR is a breaking change (e.g. methods or parameters removed/renamed)
[ ] This PR is not a code change (e.g. documentation, README, ...)

If enabling this feature please also update the Changelog and write the docs for it please.
Then run through black with line length 120.
Thanks.

@broenn if you want this PR merged, please add a changelog entry and run black over your code. otherwise ill close this pr in about a week


[bug] Livekit's CPU usage

Describe the bug
When I test my application on Flutter iPhone, livekit's CPU usage is as follows:
Viewer CPU usage when there is a streamer in the room and his cameras are off:

Viewer CPU usage when there is a streamer in the room and his cameras are on:

Viewer CPU usage when there are two streamers in the room and their cameras are on:

Viewer CPU usage when there are three streamers in the room and their cameras are off:

Viewer CPU usage when two streamers in the room with their cameras on and one streamer with his camera off:

When I test without a livekit connection in the same application, I observe 6% CPU usage.
In this case, we observe 50-60% CPU usage per broadcaster in Livekit. These processor uses cause the phone to overheat and increase battery usage.
I think Livekit needs optimization.
Platform information

Flutter version: Flutter 3.13.4
Plugin version: livekit_client: 1.3.5
Flutter target OS: iOS

Hi. Users of my app that has video call integrated by means of this plugin also experience overheating. For some of them it is moderate and for the others it is pretty high.

hey @furkanKotic @Parfyonator, Hey, can you guys confirm what video code was being used when this issue occurred, and what phone model you were using? I think the video code that consumes the most power in libwebrtc is usually the video code.

Hi @cloudwebrtc. The scenario of @Parfyonator is also valid for me. My users report that the phone overheats after 30 minutes, the app becomes extremely slow, and the phone gives a high temperature warning. We are using H264 codec. We know that it is available in all recent iPhone models.
Some tested models:
iPhone 15 pro max
iPhone 14 pro max
iPhone 14
iPhone X
I have all of these devices. These devices experience overheating when broadcasting or just participating as a viewer. But there is no problem on Android devices.
Resolution: h540_43
Bitrate: 1000
Framerate: 15

Heyo! I wanted to point out that I've observed high CPU usage and high temps during extended use in my project, the LiveKit example project, and the Flutter WebRTC example project. I tested these projects on my iPhone XR, using the H264 encoder at a 540_43 resolution and 20 fps.
I also experimented with the example project for the camera package. It appears to utilize approximately 30% CPU when the camera is active. Is it typical for the camera in Flutter for iOS to demand such high CPU consumption?
Also, a big thanks for everything you do. @cloudwebrtc

I have the same heating problem. iPhone users complain about the application overheating and overheating after 30 minutes of use.
@cloudwebrtc @davidzhao

Can confirm, same thing happens to our iOS devices (12, 14 Pro, iPad Pro 11"). Very high energy + CPU usage. Perhaps this is a flutter-webrtc issue?

high cpu ,high energy and high temperature, Is there any official plan to solve this performance problem?

Hey all, we will investigate this issue this week. Can you post the model and year of the device you are using?

Can confirm, same thing happens to our iOS devices (12, 14 Pro, iPad Pro 11"). Very high energy + CPU usage. Perhaps this is a flutter-webrtc issue?

Could you provide some reference for cpu usage?
For example, open the camera on 14 pro, or publish a 720p video track using h264,
I have a 14 pro, and iPad air M1, I will do a comparison test

Can confirm, same thing happens to our iOS devices (12, 14 Pro, iPad Pro 11"). Very high energy + CPU usage. Perhaps this is a flutter-webrtc issue?

hi @domvie Could you provide some reference for cpu usage? For example, open the camera on 14 pro, publish a 720p video track with using h264, I have a 14 pro, and iPad air M1, I will do a comparison test

So I just re-tested this using the livekit client-sdk-flutter example (I believe its version 2.1.0) as of right now. I connected with two real clients (iPhone 12, iPad Pro 11"). At times I've played around with adding a couple of video publishers using livekit-cli but that never seemed to make a difference.
Some stats I'm getting:

H264/720p/30fps/Simulcast/Adaptive Stream/Dynacast after ~10min:
iPhone 12: CPU ~50%, Energy Impact: "Very High" (with GPU taking around ~45% and "Overhead" the next largest 25%). No overheating.
iPad: Virtually the same stats, also no overheating

Same settings as above but with E2EE:
Again pretty much same as above, except CPU spikes to around ~60%, no overheating.

Same settings as above but 1080p and simulcast off:
No difference, no overheating.

Everything off, 1080p/30fps (and I assume still h264 by default?):
Again all the same and no overheating.

VP8, 1080p/30fps, everything enabled again:
iPhone 12: CPU goes up to around 130%
iPad: CPU ~65%
quite expected. The devices, especially iPhone, do get noticeably warmer this time. Not so much that I get a OS warning about it though (which honestly was the biggest issue, even worse than the extreme throttling that would happen sometimes), but it's very warm.

AV1, 1080p/30fps, again everything enabled:
CPU goes up substantially, to around 200-300% especially when moving camera. Still warm/hot, some throttling, but not yet overheating.

At this point I have stopped testing as it is quite time consuming.
All in all, in this session I could unfortunately not reproduce the overheating issue I encountered a while back. Especially when using hardware accelerated H264 the devices seemed to run just fine, other codecs increased CPU and heat quite a bit (although that is to be expected). Energy consumption was always very high.
I'm guessing this could be due to multiple reasons:

not testing long enough with various settings/combinations
perhaps the problem lies somewhere in the implementation of livekit in our app, or some UI/Flutter component triggering it
different version? (was tested on v2.0 before)

In the current form of our app it also does not overheat most of the time. We enable only dynacast, everything else off, with a resolution of 1440p @ 30fps and max bitrate of 15mbps using H264. These are the settings we had the most success with for our requirements. So it can definitely handle quite a bit of data without causing issues. I also remember the problem happening independent of res/fps, so it would also overheat at say 540p and a low frame rate. The weirdest thing to me is that it's not easily reproducible, or why it would sometimes happen with h264 and sometimes not. Other codecs make more sense I guess but even then it was never obvious.
Hopefully this was somehow helpful, sorry I couldn't reproduce it this time. Perhaps @furkanKotic still can.

should I just upgrade the sdk to 2.1.5 to solve this issue?

@elonmaph  you can try this branch https://github.com/livekit/client-sdk-flutter/pull/509, and change VideoTrackRenderer like this.
VideoTrackRenderer(
    _videoTrack!,
    fit: RTCVideoViewObjectFit.RTCVideoViewObjectFitContain,
    renderMode: VideoRenderMode.platformView,
  )

I've been testing the platform view branch and wanted to share some feedback. The CPU performance improvements are definitely noticeable and my iphone hasn’t overheated, which is fantastic!
However, I’ve encountered a couple of issues:

The platform views do not respect the RTCVideoViewObjectFit.RTCVideoViewObjectFitCover fit option and extend beyond the widget frame.
The video feed briefly freezes when muting/unmuting the microphone. This issue worsens when rapidly toggling mute/unmute.

I’m really excited about the platform view and performance updates for iOS! Thanks so much for your help!

The platform views do not respect the RTCVideoViewObjectFit.RTCVideoViewObjectFitCover fit option and extend beyond the widget frame.

I noticed this problem too. It's like it doesn't care about the height of the Sizedbox and the image is created with a size higher than the value given to the Sizedbox.


Impression data flag as part of getFeatureToggleDefinition

Describe the feature request
I would like the moreOperations (src/main/java/io/getunleash/MoreOperations.java) method getFeatureToggleDefinition to provide the flag on if impression data is enabled or disabled for that toggle. This comes as part of the payload from /api/client/features but is discarded by the Java SDK instead of stored.
Background
No response
Solution suggestions
No response

Closed by #201


arr mapped with ensuring

@rultor merge

@rultor merge

@maxonfjvipon OK, I'll try to merge now. You can check the progress of the merge here

@rultor merge

@maxonfjvipon Done! FYI, the full log is here (took me 3min)


Using chance in server side

Why chance.integer is undefined in the server side? Do I have to add/install anything else a part of thepumpinglemma:chance

This worked for me:
chance = new Chance()
chance.integer()

Have to call the method on an instantiated instance.


Add auto merge

@conda-forge-admin, please add bot automerge

Hi! This is the friendly automated conda-forge-webservice.
I just wanted to let you know that I added bot automerge in conda-forge/msg-extractor-feedstock#47.


[ble mesh] before publish callback event (IDFGH-12504)

Is your feature request related to a problem?
No response
Describe the solution you'd like.
No response
Describe alternatives you've considered.
No response
Additional context.
Hi,
im still beginner on the ble mesh field, but i am wondering. Is it possible to implement publish callback event which will be fired before publish so we could update model state just before publish?
In most cases its not important, because most models state is known and can be updated when state is changed.
I found 3 use cases where it could be useful to have such event:

most obvious may be vendor model (optional)
then location server model, assuming we are talking about global location and GPS
another model may be time server model.

I am currently thinking about time server. In theory i could update its state and publish buffer every some time, like every 1 second or more often, but its not efficient and not accurate. With location model it is less important, because GPS location updates are less often, even if node is moving.
Custom model is just concept, and probably its state can update itself whenever its needed.
Thanks

Yes, i know, and i am using it now.
But, like i mentioned, it updates after publish, so i cant update state (current time) before publishing it.
There is few hacks i could do, like mentioned update time every some time (100ms) or so, but this still is just a hack.
It is nothing really important, just an idea.
Thanks

@chegewara
Ok, I see the feature you want, I'll make a note of it and discuss it with the teams. Thanks for the suggestion.


updating screenshots for rebranding

Description

Motivation and Context

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Documentation fix (typos, incorrect content, missing content, etc.)

Checklist

[ ] I have read the contributing document.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.

@aliciakrebs The branch has conflicts that require time to resolve so I'm closing this PR and creating a new one


Please update structural data for CHEBI:18000

Dear ChEBI curators,
Please would you update structural data for CHEBI:18000
The 2D structure (status DELETED) was correct for me, could you change it to CHECKED and update also the formula status
Xrefs:
MetaCyc: Arylalkylamines
Needed for Rhea to create the reaction of EC <IP_ADDRESS>
N-acetylarylalkylamine + H(2)O = arylalkylamine + acetate.
(this issue is related to #3457)
Thanks for your support
Cheers, Anne

Now done.


[INLONG-2187] support audit view

Title Name: [INLONG-XYZ][component] Title of the pull request
where XYZ should be replaced by the actual issue number.
Fixes #2187
Motivation
Explain here the context, and why you're making that change. What is the problem you're trying to solve.
Modifications
Describe the modifications you've done.
Verifying this change

[ ] Make sure that the change passes the CI checks.

(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)

Added integration tests for end-to-end deployment with large payloads (10MB)
Extended integration test for recovery after broker failure

Documentation

Does this pull request introduce a new feature? (yes / no)
If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
If a feature is not applicable for documentation, explain why?
If a feature is not documented yet in this PR, please create a followup issue for adding the documentation

Codecov Report

Merging #2222 (3cc34a7) into master (75a21cd) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #2222      +/-   ##
============================================
- Coverage     12.58%   12.58%   -0.01%
+ Complexity     1208     1206       -2
============================================
  Files           417      417
  Lines         35735    35735
  Branches       5590     5590
============================================
- Hits           4499     4497       -2
  Misses        30435    30435
- Partials        801      803       +2

Impacted Files
Coverage Δ

.../producer/qltystats/DefaultBrokerRcvQltyStats.java
45.31% <0.00%> (-0.79%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 75a21cd...3cc34a7. Read the comment docs.


[5.4] Switch branch-based dependencies from main to release/5.4.

In the release/5.4 branch, also switch the branch-based dependencies to the release/5.4 branch.

@swift-ci please test

@swift-ci please test

Thanks @artemcm.  Who else will need to approve it at this point in the 5.4 release schedule?

Thanks @artemcm.  Who else will need to approve it at this point in the 5.4 release schedule?

@DougGregor Do we need Ben's approval for this?

@DougGregor Do we need Ben's approval for this?

@DougGregor Do we need Ben's approval for this?

Nope, please go ahead.

@DougGregor Do we need Ben's approval for this?

Nope, please go ahead.

Great, thanks!

Great, thanks!


unable to load 4 7b size model in step3

My actor model and critic model are both 7b in size. When I run the step3, there will be memory overflow, which consumes about 225G of memory space. Is there any solution to reduce memory consumption without changing the size of the model?

I guess you could use LoRA, gradient checkpoint, lower batch size & gradient accumulation, off-load reference model to CPU RAM, decrease max_length.

I guess you could use LoRA, gradient checkpoint, lower batch size & gradient accumulation, off-load reference model to CPU RAM, decrease max_length.

In fact, I ran out of memory, not GPU memory. So is there any other solutions to solve this problem?

@Mr-lonely0 I tried training actor model and critic model with LLaMa model. The training in step3 crashed when torch.load(critic_model) which i guess is out of memory problem. Have you solve the problem you mentioned?


Remove jsonify dependency, add a stringify option

The stringify option can be provided by users who wish to polyfill
This is a breaking change as it will break support for browser that don’t have a built in JSON implementation.

#10, #11 and #12 are alternatives to this proposal.

If you're using browserify, a simple workaround is to add jsonify to the external list.
That way, it won't include it in the bundle.
Since jsonify is only required if JSON is not available, this works for modern browsers.

True, although it wouldn't work if some other library depends on jsonify (and doesn't prefer the builtin JSON).  It also means solving the problem on a user-by-user basis, rather than improving performance for every user of json-stable-stringify across the board.  I have actually published a version of this module that doesn't include jsonify as https://www.npmjs.com/package/stable-stringify

#12 is better, I suggest closing


p5.Camera not being treated as a class

Most appropriate sections of the p5.js website?
Reference
What is your operating system?
Mac OS
Web browser and version
All
Actual Behavior
Currently, p5.Camera is showing up in the reference as a method.
Expected Behavior
Previously, it would show up as a class, and its methods would be available to browse.
Steps to reproduce
This happened in this commit https://github.com/processing/p5.js-website/commit/2438f3de63c1d654e066b970287b6c266295ddd4#diff-45545281b23895f7bbb1789126d4056142ce9a51dff2be85ee67889193f51edd after I rebuilt the docs from the v1.10.0 tag.
It looks like this may be because after the v1.10.0 release, a correction for this was added by @limzykenneth, and by locking the version number used in the reference to this specific tag, I've reverted to the older behaviour:
https://github.com/processing/p5.js/commit/449e6dcb6fc1986090e31049575fca84f39f9ec1
Version locking is necessary so that new docs from unreleased features don't show up in the reference when we rebuild, and rebuilding is necessary to fix some bugs in the reference scripts. It sounds like in this case, we maybe need to replace v1.10.0 with 449e6dcb6fc1986090e31049575fca84f39f9ec1 (or maybe a new patch tag on the p5 repo to be more readable?), run npm run build:reference again, and then commit the results.
Would you like to work on the issue?
It's ok if someone else wants to take this on!

Version is updated so this is fixed; more frequent releases will help mitigate this issue.


Do we need groups or can they be replaced with policies?

Do we need groups or

From my experience, group is a TOSCA construct little used.

can they be replaced with policies?

Yes.
A policy can refer several node templates like a group does.

Groups are currently only used in policy definitions as a short-cut to associate a policy with a collection of nodes without having to list those nodes individually directly in the policy definition. I'm not aware of any other uses for groups.


Replaced SSF by numfmt (ECMA-376 support)

I replaced SSF by numfmt the reasons what I did that is because SSF doesn't support custom localization features. To replace SSF by numfmt it will open the door to use custom localization features like number formats, currencies, etc.
Numfmt supports by default Chinese (traditional and simplified), Spanish and English among other locales.

@juanparati Thanks. This is a big change. I need to look into this deeply to ensure it doesn't break anything.

Hi @juanparati , fortune-sheet has added its own extra changes in ssf implementation (that's why we aren't importing the package but created a file ssf.js). The changes are from line 1700-1825 in ssf.js. I'm not sure in numfmt takes in account the 万 chinese character.
@sanchit3008

I replaced SSF by numfmt the reasons what I did that is because SSF doesn't support custom localization features. To replace SSF by numfmt it will open the door to use custom localization features like number formats, currencies, etc.
Numfmt supports by default Chinese (traditional and simplified), Spanish and English among other locales.

This would be nice to have

@juanparati maybe you can upstream the changes from ssf to the repo?


Consider using delegation instead of notification for the request complete event

Cons of using notification:

information is not typed
have to parse and extract the user info

Notes:

this would be a breaking change and client projects will need an update

This was one as part of #65, but this bug wasn't ever closed. Closing.


Update Metadata table to include entity level descriptions

Maybe add a row with no column name so you can add a description on the table level.

Good idea. I'll get right on to it!

please keep a column for recent notes, like DQ issues and recent changes

@tfoldi 👍 that would go into the table-level row's comment column.


Addition to Asn1.X509.PolicyQualifierInfo

Background - I am rejuvenating a CA system that was built on BC 1.7 (with extensions). I am trying for a clean (non extended) version of 1.8. Any chance of incorporating some of my changes into 1.8.x?
For example.  In Asn1.X509.PolicyQualifierInfo add:
    public DerObjectIdentifier GetPolicyQualifierId()
    {
        return policyQualifierId;
    }

    public string GetQualifier()
    {
        if (policyQualifierId.Equals(PolicyQualifierID.IdQtCps))
            return qualifier.ToString();
        else
        {
            Asn1Sequence notice = Asn1Sequence.GetInstance(qualifier);
            return notice[0].ToString();
        }
    }

Thanks for the feedback - I have no idea which branch I was looking at. I see that the stuff I was looking for is already there in the current branch. Trying to move from a pretty old 1.7 is proving challenging (particularly when I had extended the original library).


Weird save option window

Please explain me, why?

you can't use the default Explorer one?

You can turn on "Use Native File Picker" by pressing the settings gear in the bottom right, but the file picker available for Java applications on Windows looks like this:


Support additional from datasources within Zed

As a noob to the Zed ecosystem,While playing with the zed and zq CLI, and was looking for an ability to integrate it with other data sources within the zed pipeline. I know this can currently be satisfied using other tools like curl, find, psql, etc... But, I would like to have the ability to integrate these sources directly within Zed for the following benefits:

Ability to build a more efficient and streamlined dataflow pipeline since the data source integrations can leverage the full power of Go's capabilities.

Simplify the interface into zed for new users (albeit at a cost to additional complexity within the supported syntax). I think many users will lean towards the tools they know using shell pipelines to feed this data into zed, but I feel like this would severely limit the power of the dataflow pipelines that zed can create (but my experience with Zed and Go in general is quite new).

Allow data throughput to be controlled such that you can build data sources that potentially pull from infinite streams. Here I'm thinking of activities like paging through API endpoints, SQL query results, or files on a file system.

Is this something that Zed already supports?
If not, is this use case something that aligns with vision and goals for Zed?
I believe there is a similar ticket here, that is focused on extending the from / get operator to support HTTP requests. Should this go there?
A somewhat related tool in this space is steampipe, which has a plugin capability to enable new data sources. I've been a huge fan of their product, but Postgresql syntax seems a bit heavy at times. I think Zed's data lake concept plus the power of its query tools would be a really attractive alternative.

As those of us involved with the Zed project often say, "the architecture supports it". 😉  These concepts are indeed in line with the direction the project is headed. That said, as there's limited Dev resources available today, the bulk of the effort lately and in the near future is likely to be more toward the core of the tech, e.g., ensuring solid performance and ease of management with data once it's in the system. Making it easy for users to get data into the system is still important. However, the way we'll likely enable this in the short term is by publishing best practices for tools that have existing integrations with a diverse set of inputs, then show how those tools can easily push their data onward into Zed. Two recent prototyping efforts along these lines have been Logstash (#3151) and Fluentd (#4271) and pretty soon I expect we'll publish more formal docs that turn the findings in those issues into "best practices". As noted above, we also recognize that the existing get <uri> variation of from should probably be extended to cover other HTTP methods and parameters/payloads that could allow for hitting a wider set of REST APIs (#4225).
We'll keep this issue open as a record of our intent to make ongoing investment in this area. Thanks for your interest in Zed!


Crash if inserting items into stash too fast while Loot-Tracking is on

Not sure what it all means as I'm not familiar with coding but it happens sometimes if I stash many items very quickly.
Version: 1.55.1
Normal PoE Client from website
Resolution: 1920x1080
Using Loot-Tracking within Map-Tracker

Just got another one so I thought more data = better understanding !

Thanks for reporting this. I can't replicate it on my end, but from the error-message it seems to be a timing-issue between flashing the panel (to signal kill-count refresh) and adding an item to the list. I'll include a potential fix in a hotfix-release shortly.

v1.55.1 (Hotfix 1) includes a potential fix for that. Before applying color to the panel to make it flash, it now checks if the panel can be addressed first.
I'll leave this thread open for now in case something else comes up.


Update build.yml

Codecov Report

Merging #6 (26081ae) into main (5e32107) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main       #6   +/-   ##
=======================================
  Coverage   70.33%   70.33%
=======================================
  Files          37       37
  Lines        1561     1561
  Branches      180      180
=======================================
  Hits         1098     1098
  Misses        463      463

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Allow Sneakers to use default exchange

This PR fixes following issue:
RabbitMQ does not allow to bind queues to default exchange. But Sneakers always tries to bind queue to an exchange. This means that Sneakers can't be used with default exchange. See https://github.com/jondot/sneakers/issues/105

Second commit fixes build error - "guard" is required for tests but is not specified as dependency
Let me know if you want me to submit second commit in a separate PR

Thanks Andrew, I appreciate the guard fix as well! :)
With that in mind - I'd like to start sending Sneakers t-shirts to committers (it is now being designed). Feel free to send me a shipping address to<EMAIL_ADDRESS>if you want one :)


Update expressroute-howto-circuit-classic.md

Customer are not able to delete the circuit because correct subscription context was not set correctly by the command mentioned in the current document. After following the proposed changes customer were successfully able to delete the circuit.

@PedroPerezMSFT,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot

@PedroPerezMSFT : Thanks for your contribution to the Azure documentation! The author, @ganesr, has been notified to review your proposed change.

#sign-off


Fix #2114, Add macro for initializing command header

Checklist (Please check before submitting)

[x] I reviewed the Contributing Guide.
[x] I signed and emailed the appropriate Contributor License Agreement to<EMAIL_ADDRESS>and copied<EMAIL_ADDRESS>
Describe the contribution

Fix #2114

Just adds CFE_MSG_CMD_HDR_INIT
Testing performed
Built and ran with nasa/SC#35, and observed the commands getting sent
Expected behavior changes
None, just provides a more portable way to define tables with commands
System(s) tested on

Hardware: i5/wsl
OS: Ubuntu 18.04
Versions: Build main + the SC changes and this commit

Additional context
None
Third party code
None
Contributor Info - All information REQUIRED for consideration of pull request
Jacob Hageman - NASA/GSFC

CCB:2022-06-08 APPROVED


Sorting_by_actual_quantity_is_crashing_msupply_mobile

Build Number: 2.1.0-rc8
Description:When i was testing msupply mobile and pressed the actual quantity in stock take msupply mobile gets crashed. I dont know whether we need to sort by actual quantity or not but it was clickable so while clicking its crashed the msupply  mobile.
Reproducible:just create new stock take and click the actual quantity.
Reproduction Steps:Create stock take or open any other stock take.Then try to sort by actual quantity then msupply will crash.
Comments:

Duplicate of #617
@anildahalsussol What wrong with spaces in the title haha?

@Chris-Petty : haha sorry ,Nothing but got habit writing in github. Will follow the standard system ...


Requesting to integration of current carina with cucumber as a separate module.

Hi,
Can you please help me with a merged code of current carina and cucumber module.

There should be a facility that current carina/cucumber version gets updated then we can also update the same.
The merged code should also help to Zafira and cucumber reporting.
The merged code should be treated as a separate module.

TestNG+Cucumber carina runner is available again in snapshot core builds.
To enable it for your project we have:

declare carina-core 6.1.25-SNAPSHOT and carina-cucumber 1.0-SNAPSHOT as dependencies
https://github.com/qaprosoft/carina-demo/blob/40621d2dfff6a1592e8d70b82d53fa2e0ab6df9f/pom.xml#L37

create appropriate TestNG suite and java classes
https://github.com/qaprosoft/carina-demo/blob/cucumber/src/test/resources/testng_suites/cucumber-web.xml
https://github.com/qaprosoft/carina-demo/blob/cucumber/src/test/java/com/qaprosoft/carina/demo/CucumberWebSampleTest.java

Extend your cucumber test from CucumberBaseTest
https://github.com/qaprosoft/carina-demo/blob/40621d2dfff6a1592e8d70b82d53fa2e0ab6df9f/src/test/java/com/qaprosoft/carina/demo/CucumberWebSampleTest.java#L16

describe BDD methods as steps:
https://github.com/qaprosoft/carina-demo/blob/cucumber/src/test/java/com/qaprosoft/carina/demo/cucumber/steps/GSMArenaNewsSteps.java

describe features steps:
https://github.com/qaprosoft/carina-demo/blob/cucumber/src/test/resources/features/GSMArenaNews.feature

inject features and steps in your test class using @CucumberOptions annotation:
https://github.com/qaprosoft/carina-demo/blob/40621d2dfff6a1592e8d70b82d53fa2e0ab6df9f/src/test/java/com/qaprosoft/carina/demo/CucumberWebSampleTest.java#L7

As result you could execute cucumber-web.xml as regular TestNG but in additions to carina generate extended cucumber reports with features/steps/tags etc

done


IHostedService StopAsync cancellationToken updates

Fixes #9144
Internal Review Topic
cc: @ygoe

@jkotalik Here's another really quick one ... it's just Line 40. Just trying to flesh out StopAsync and the cancellation token a bit more.


Keyboard elements do not show up in dark mode

I'm just a casual user of the template and not familiar with the codebase, but I'd be willing to help if someone could point out where I should look to fix this. Thank you!

Hey @FelixNgFender, I'm not sure where the above is coming from, but I'm guessing this is markdown?
If it is, it looks like typography isn't picking it up / being overruled. I will need a bit more code or link to help further

| Action                | Shortcut                                   |
| --------------------- | ------------------------------------------ |
| Vertical split        | Alt+Shift++                     |
| Horizontal split      | Alt+Shift+-                     |
| Auto split            | Alt+Shift+d                     |
| Switch between splits | Alt + arrow keys                |
| Resizing a split      | Alt+Shift + arrow keys          |
| Close a split         | Ctrl+Shift+W                    |
| Maximize a pane       | Ctrl+Shift+P + Toggle pane zoom |

Here's the markdown for that.


New 'FileReference' property for 'FileProperty' table

Each file / directory will be assigned unique reference which should be included in the bagit package 'file-metadata.csv' file"

@paulyoung84 Are you happy for the new file_reference field to be added to the export package, even though it will be empty, until TDR starts assigning the references?

@paulyoung84 Are you happy for the new file_reference field to be added to the export package, even though it will be empty, until TDR starts assigning the references?

Hi @TomJKing I'm happy for it to appear, I will need to update Talend Job to handle it anyway. Cheers


ibm-select value doenst update when ngmodel value changes

Detailed description
When using the ibm-select component to filter, trying to reset the filter with another component by changing the value of the bound variable. This does not update the selectbox.

Is this a feature request (new component, new icon), a bug, or a general issue?
Bug

Is this issue related to a specific component?
ibm-select

What did you expect to happen? What happened instead? What would you like to see changed?
Value should reflect the value in the ngModel

What browser are you working in?
Newest chrome and firefox.

What version of the Carbon Design System are you using?
"carbon-components": "10.20.0",
"carbon-components-angular": "4.17.0"

Steps to reproduce the issue
template:
<ibm-select [(ngModel)]="filterVal" (ngModelChange)="filter()" >
 <option value="one" >one</option>
 <option value="two" >two</option>
</ibm-select>
<button type="button" (click)="filterVal = 'one'" >Reset</button>

component:
filterval = 'one'

Reproduce:
Clicking the reset button, should reset the visual of the component, but doesn't.

i think related https://github.com/IBM/carbon-components-angular/issues/1518

Yeah it's the same issue, only with a different component.


CreateFolderAsync not working on UWP with spaces in the path

If i call the following:
var res = myFolder.CreateFolderAsync(dir, CreationCollisionOption.OpenIfExists).Result;
where the Path is:
"C:\\Users\\My Admin\\AppData\\Local\\Packages\\guid\\LocalState\\App\\Folder"
Note the space in my "User"
I get the following exception:

The filename, directory name, or volume label syntax is incorrect. (Exception from HRESULT: 0x8007007B)
at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
at PCLStorage.WinRTFolder.d__12.MoveNext()

I guess its down to the space in my path

Turned out to be a bug in my program rather than this library


The container can not start: error "task: non-zero exit (1)"

I'm trying to set up the nginx proxy on my Amazon AWS Docker instance together with a pimcore instance. This is my compose file:
version: '3.4'

services:
  nginx-proxy:
    image: codesuki/ecs-nginx-proxy
    ports:
      - "80:80"
  pimcore-jcii:
    image: ****/pimcore5:current
    ports:
      - "8000:80"
    links:
      - "db"
    volumes:
      - efs-storage:/data
  db:
    image: mariadb
    restart: always
    ports:
      - "3306:3306"

volumes:
  efs-storage:
    driver: cloudstor:aws
    driver_opts:
      backing: shared

If I deploy this stack the nginx proxy container can not start. It appears the following error message:
task: non-zero exit (1)
What am I doing wrong?

Are you using ECS?

@codesuki Yes, I'm using ECS.

Hard to diagnose from this. Do the ECS machines have the needed permissions? Is there any log output? In many cases ecs-nginx-proxy should log some kind of error. If you could post the log output maybe we can find a solution.


Template registration support needed

A push notification plugin for Cordova apps really needs to support the template registration feature of Azure Notification Hubs.

+1

& tags ! :)


Calling syslog.log too early in the boot process prevents esp8266 from booting

Hi there!
Firstly thanks for this great component, I've been using it to log time-based events and it's been very useful.
This evening I stumbled on a scenario where I believe esphome_syslog prevents an esp device from booting successfully.
In this scenario the esphome api, web_server and remote logger all stop functioning. Fortunately OTA is still available.
I have a script which is called by "on_boot" and under normal circumstances it never calls syslog.log until well after the esp boots, time syncs, api connects, etc.
Tonight the script tried to call syslog.log immediately after a reboot and that's where things went awry.
I use the following syslog configuration:
syslog:
  enable_logger: false
  ip_address: "192.168.x.x"
  port: 514

The following on_boot reproduces the problem:
esphome:
  on_boot:
    priority: 700.0
    then:
      - wait_until:
          wifi.connected:
      - syslog.log:
          level: 5
          tag: "ESPHome"
	  payload: "This will break things"

This on_boot also causes issues:
esphome:
  on_boot:
    priority: -100.0
    then:
      - syslog.log:
          level: 5
          tag: "ESPHome"
	  payload: "This will break things"

However this on_boot works fine:
esphome:
  on_boot:
    priority: 700.0
    then:
      - wait_until:
          time.has_time:
          #also working is api.connected:
      - syslog.log:
          level: 5
          tag: "ESPHome"
          payload: "This will work fine"

I can see you have return setup_priority::LATE; defined, so I'm not sure where else to go looking for the cause of this issue.
For the moment I have a workaround in place (testing for api.connected anywhere that I call syslog.log).
Thanks!

Humm this is interesting, I don't really know what's going on here.
Is there any error or it just stops working ?

I hooked up a serial connection tonight to see what's going on and it appears calling syslog.log early is creating a boot loop.
Eventually the device boots into safe mode which is why only OTA is working.
 ets Jan  8 2013,rst cause:2, boot mode:(3,6)

load 0x4010f000, len 3460, room 16
tail 4
chksum 0xcc
load 0x3fff20b8, len 40, room 4
tail 4
chksum 0xc9
csum 0xc9
v0006dea0
@cp:B0
ld
[I][logger:242]: Log initialized
[C][ota:461]: There have been 0 suspected unsuccessful boot attempts.
[I][app:029]: Running through setup()...
[C][wifi:037]: Setting up WiFi...
[D][wifi:373]: Starting scan...
[D][wifi:388]: Found networks:
[I][wifi:431]: - 'xxxx-IoT' (C0:xxxx) ▂▄▆█
[D][wifi:433]:     Channel: 11
[D][wifi:434]:     RSSI: -31 dB
[I][wifi:248]: WiFi Connecting to 'xxxx-IoT'...
[I][wifi:505]: WiFi Connected!
[C][wifi:353]:   Local MAC: 9C:xxxx
[C][wifi:354]:   SSID: 'xxxx-IoT'
[C][wifi:355]:   IP Address: 192.168.xxxx
[C][wifi:356]:   BSSID: C0:xxxx
[C][wifi:358]:   Hostname: 'xxxx'
[C][wifi:360]:   Signal strength: -34 dB ▂▄▆█
[C][wifi:364]:   Channel: 11
[C][wifi:365]:   Subnet: <IP_ADDRESS>
[C][wifi:366]:   Gateway: 192.168.xxxx
[C][wifi:367]:   DNS1: 192.168.xxxx
[C][wifi:368]:   DNS2: <IP_ADDRESS>
[D][wifi:514]: Disabling AP...

And after 10 unsuccesful boot attempts:
 ets Jan  8 2013,rst cause:2, boot mode:(3,6)

load 0x4010f000, len 3460, room 16
tail 4
chksum 0xcc
load 0x3fff20b8, len 40, room 4
tail 4
chksum 0xc9
csum 0xc9
v0006e570
~ld
[I][logger:242]: Log initialized
[C][status_led:014]: Setting up Status LED...
[C][ota:461]: There have been 10 suspected unsuccessful boot attempts.
[E][ota:468]: Boot loop detected. Proceeding to safe mode.
[I][app:029]: Running through setup()...
[C][wifi:037]: Setting up WiFi...
......... usual safe boot follows from here

Thanks, I think I'll have time to look at it this weekend, hopefully I can find the cause

I think I've found the cause, but I'm not convinced I have a good solution.
It appears syslog.log is called before the syslog component setup actually completes.
I modified syslog_component.cpp to add some serial logging and commented out the syslog.log call as follows:
	Serial.println ("syslog.log called");
	Serial.print ("Payload: ");
	Serial.println (payload.c_str());
    // syslog.log(esphome_to_syslog_log_levels[level],  payload.c_str());

During the boot event I see the following:
... normal boot to this point, trimmed for brevity.
[21:55:47][D][wifi:514]: Disabling AP...
[21:55:47]syslog.log called
[21:55:47]Payload: on_boot test payload
[21:55:47][C][web_server:096]: Setting up web server...
[21:55:47][C][ota:085]: Over-The-Air Updates:
[21:55:47][C][ota:086]:   Address: xxxx
[21:55:47][C][api:025]: Setting up Home Assistant API server...
[21:55:47][C][sntp:025]: Setting up SNTP...
[21:55:47]syslog.log called
[21:55:47]Payload: Syslog started
[21:55:47][I][syslog:032]: Started
[21:55:47][I][app:062]: setup() finished successfully!

My guess is that the Wi-Fi client is initialized but not actually connected yet. Causing the crash the moment it tries to send

I thought that might be the case too, however testing that theory just now (I included ESP8266WiFi.h and tested for WiFi.Status()) and it's returning a state of WL_CONNECTED.
I'm getting out of my depth at this point unfortunately.

Odd. I moved the syslog location after the wifi startup and now the board boots fine!! Thanks for an esphome syslog ability :-)

Weird, maybe the upload got corrupted at some point because the order of the YAML should have any impact as you need to specify the order manually in the component (See SyslogComponent::get_setup_priority())

@pmannk
Finally, got some time to fix this while waiting, for a 3D print
So fixing the boot loop was dead simple:
Using a priority of setup_priority::LATE and calling the log() function too early meant that the setup() function was not called yet, resulting in the udp_ pointer being rubbish, and you can probably guess what happened next 😅
Now, I changed the priority to setup_priority::AFTER_WIFI and added a check in the log() function to make sure that the pointer is not NULL but it still doesn't send the message, so I need to keep investigating, current guess is no internet

Ok, so I was wrong there is internet, and the logs are being sent if the priority is -100 (had a wrong filter on my server).
However setting the on_boot priority to 700 using a wait_util for wifi.connected still failed and here is what I think was going on:

Hardware is initialized (priority 800)
on_boot automation called (priority 700)

Waiting for wifi connected
Wifi is now connected (priority at 200)
syslog.log called (priority still at 200 meaning the component isn't setup)

Esphome is going throught priorities 600 to 220
Wifi is connected (priority 200)

setup() called in the api
setup() called in the component

Esphome is going throught the rest of the priorities

Here is what I think is going on when using api.connected :

Hardware is initialized (priority 800)
on_boot automation called (priority 700)

Waiting for api.connected
Wifi connected (priority at 220)
Api gets connected
EspHome goes to the next priority
syslog.log called (priority is no longer at 200 meaning the component is setup)

Esphome is going throught priorities 600 to 220
Wifi is connected (priority 200)

setup() called in the api
setup() called in the component

Esphome is going throught the rest of the priorities

To solve this, I choose to simply init WifiUDP in the constuctor and not in the setup() and add a check for connectivity in the log(). This doesn't really poses an issue because of the check before logging and WifiUDP doesn't generate an exception anyways if there is no internet.
But for some reason, WifiUDP still errors out with [E][WiFiUdp.cpp:183] endPacket(): could not send data: 12 when the node print the config, works fine after tho
Bit more work, commits one way

Error 12 is ENOMEM and this is what the esp32 docs have to say: https://docs.espressif.com/projects/esp-idf/en/latest/esp32/api-guides/lwip.html#limitations
This could be due to the the fact that the underlying lib is using multiple prints instead of one big formated one (Syslog.cpp#L261), but it's clear that it's because something is going to fast for the wifi tx buffer.
The thing is I don't have a esp8266 that I can plug on my computer right now but uploading the new version to an already running one seems to work even with a lot of messages. So I guess the udp implementation is better 🥳.
I'll add a warning for the esp32 because it's not something I can fix easily (would require either that the arcao/Syslog lib to actually realize that there is an issue or that esphome compiles with a bigger buffer and I'm not sure on how it will impact other things)

Here we go, this should be fixed, please let me know if there is still an issue. Sorry it took so long 😅

Nice one, that did the trick. I can't trigger the fault anymore.
Thanks @TheStaticTurtle !


Way too awesome!

Hey there, I didn't know how else to contact you but I wanted to say thank you! I just upped my app to the Angular 2 rc and totally thought I'd have to rip out the toaster for now. I was really impressed to see that you've already made the move.
Thanks for being an absolute gem, you've made my life very nice!

No problem!
Thanks for the awesome feedback!  It's great to hear that the library is being used and abused, especially in new apps staying on the Angular 2 edge.  It's been a bit tricky keeping up with the breaking changes, but I'm happy to do so and keep it as closely behind as possible.
Thanks again for the wonderful feedback and glad it's been so helpful to you and your projects!


fix: add check for listId to hooks

Description

Adds checks for listId to hooks to prevent requests with an undefined value

What type of PR is this? (check all applicable)

[ ] 🍕 Feature
[x] 🐛 Bug Fix
[ ] 📝 Documentation Update
[ ] 🎨 Style
[ ] 🧑💻 Code Refactor
[ ] 🔥 Performance Improvements
[ ] ✅ Test
[ ] 🤖 Build
[ ] 🔁 CI
[ ] 📦 Chore (Release)
[ ] ⏩ Revert

Related Tickets & Documents

Mobile & Desktop Screenshots/Recordings

Added tests?

[ ] 👍 yes
[ ] 🙅 no, because they aren't needed
[ ] 🙋 no, because I need help

Added to documentation?

[ ] 📜 README.md
[ ] 📓 docs.opensauced.pizza
[ ] 🍕 dev.to/opensauced
[ ] 📕 storybook
[ ] 🙅 no documentation needed

[optional] Are there any post-deployment tasks we need to perform?
[optional] What gif best describes this PR or how it makes you feel?

Do the views consuming those hooks still work with this change?

Do the views consuming those hooks still work with this change?

Yes, they do. SWR won't make the request until the listId is there, but they have the initial data until then.

Do the views consuming those hooks still work with this change?

Yes, they do. SWR won't make the request until the listId is there, but they have the initial data until then.

I'm still new to SWR. 😅


integrate tenderly simulation on frontend

nance-api has endpoints to get a customTransaction by uuid and simulate with tenderly api
we may be better off simulating from frontend so users can change the transaction if they see it will fail before submitting
something to think about

[ ] useTenderlySimulation hook, option to skip
[ ] can run simulation on each custom transaction
[ ] warn user that some transaction may failed, provide them the simulation links


Clean up DWP checker

The way it was merged in #268 it needs to be revisited and cleaned up properly. This was just a hack.

@colinbruce should we just delete all the commented out code?
If we need to come back to it, we can always cherry-pick it later.

Will be addressed by #419


Update compileSdkVersion

Updates compileSdkVersion from 27 to 28.
pubpspec.yaml and changelog were both updated as well, so it's ready to deploy a new version to pub.dev.
Thank you.

@j0j00 any news on this?

is this package still maintained?

@EliuTimana I wish it was as the matter of fact that is handy and requires low maintenance.

Published a 1.2.2 update incorporating the latest changes.
Also added @miguelpruivo as a collaborator to the project, so he'll be able to handle any maintenance related tasks that might be needed in my absence.
Apologies for the delay, I wasn't receiving any notifications and last I checked #8 wasn't stable enough to merge and release.

Thank you @j0j00.