Update WiX Toolset

Tool name
WiX
Tool license
Microsoft Reciprocal License (MS-RL)
Add or update?

[ ] Add
[X] Update

Desired version
3.14
Approximate size
No response
Brief description of tool
WiX handles MSI installation as you folks most likely know. WiX was recently released v 3.14 to mitigate DLL redirect vulnerability

https://wixtoolset.org/news/2024/02/06/wix-v4.0.4-available/
https://www.firegiant.com/blog/2024/2/6/wix-security-releases-available/

URL for tool's homepage
https://wixtoolset.org/
Provide a basic test case to validate the tool's functionality.

Platforms where you need the tool

[ ] Azure DevOps
[X] GitHub Actions

Runner images where you need the tool

[ ] Ubuntu 20.04
[ ] Ubuntu 22.04
[ ] macOS 11
[ ] macOS 12
[ ] macOS 13
[ ] macOS 13 Arm64
[ ] macOS 14
[ ] macOS 14 Arm64
[X] Windows Server 2019
[X] Windows Server 2022

Can this tool be installed during the build?
No response
Tool installation time in runtime
No response
Are you willing to submit a PR?
No response

And here I was wondering why my builds that ran fine just yesterday are now failing ...
Anybody else getting these after the update to 3.14?
light.exe : error LGHT0204: ICEM10: The property 'ProductCode' is not allowed in a Merge Module

light.exe : error LGHT0217: Error executing ICE action 'ICE103'. The most common cause of this kind of ICE failure is an incorrectly registered scripting engine. See http://wixtoolset.org/documentation/error217/ for details and how to solve this problem. The following string format was not expected by the external UI message logger: "There is a problem with this Windows Installer package. A DLL required for this install to complete could not be run. Contact your support personnel or package vendor.

Deployed!

Just in case anybody finds this: Seems to be a bug in VS's mergemodule.cub that got picked up in Wix 3.14 and just never got fixed. Merge modules can be built by suppressing ICE103 and ICEM10.

I've found multiple issues with this change and reported it under https://github.com/actions/runner-images/issues/9543

Yes, taking mergemod.cub from 3.11 and copying it to 3.14\bin works around this issue.  I also found an issue with the NetFx Extension which can be solved in a similar way. I don't know what other issues might lurk in 3.14 though.


replace UnobservableError "invalid object" with object type

Description:
My application was crashing with the following generic error.

You provided an invalid object where a stream was expected. You can provide an Observable, Promise, Array, AsyncIterable, or Iterable.

Upon closer inspection, I discovered that the object was indeed an Observable. The underlying issue was that multiple versions of rxjs were installed in my application. Once I was able to see that the "invalid object" was an "Observable", I knew immediately to audit node_modules for this issue. I'm hopeful that providing additional information about this runtime error will help others.
Related issue (if exists):
None that I could find.

I've been thinking about this, and we may want to start having error numbers and documentation links with more concise messages overall. We have to ship all of this code, after all.
Something like RX0001 - object unobservable https://rxjs.dev/errors#RX0001 or RX0002 - Foreign observable https://rxjs.dev/errors#RX0002 and so on, where we can provide detailed information about what that error means, why it's happening, and how to solve it.

Core Team:

Not sure if this provides a ton more value than what we have.
People usually want to know where the returned thing was created or returned that didn't get converted to an observable.

There is an interesting proposal from 2014 by @stefanpenner brought to my attention by @ladyleet today: https://bugs.chromium.org/p/chromium/issues/detail?id=332624
Something like that might help get better context as to where something came from.
(BTW: Sorry @abacaphiliac for super late re-review)

CORE TEAM: We can get this in v8 maybe. It doesn't save the world, but maybe it will help someone? 🤷♂


Bet slip bug

If I click on an outcome the betslip filters in. If I then change the wager size, the "To Win" box needs to adjust
This actually updates if I click off the wager box...needs to update without me clicking off

fixed- closing


Js6 1 1

Added js6_1_1.html (Verifying the validity of form data)

Added js6_1_1.html (Verifying the validity of form data)


LinkNotFoundError in Gmail login flow

While testing the Gmail module, I noticed that https://github.com/ustayready/CredSniper/blob/d37d391dee550dd17459a77b29c699ce247c27da/modules/gmail/gmail.py#L151 now causes a LinkNotFoundError. It looks like there's no longer an Email selector in the login form.
There is an identifier selector. Initially, this seemed promising to me, but after attempting to use that instead, I noticed that code that handles pass_form below that doesn't seem to work either.
It looks like the Gmail login flow may have changed since this code last worked?

My apologies, I tried again, and this does seem to work now. I'm not sure what happened before, but I'm closing this.


OpenEXR&IlmBase's private preprocessor definition HALF_EXPORTS leaks to OpenVDB, causing unresolved external symbol _toFloat & _eLut

Building Environment:

Windows 10 version 1803
Visual Studio 2015 Update 3
CMake 3.11.4
Source code downloaded from official OpenVDB site (version 5.1.0) or master branch from here (version 5.2)
OpenEXR&IlmBase is downloaded from the current dev branch from https://github.com/openexr/openexr
Both OpenVDB and OpenEXR&IlmBase are built under Debug x64 DLL mode in VS

CMake command line for IlmBase:
cmake -DBUILD_SHARED_LIBS=ON -DCMAKE_INSTALL_PREFIX=C:\...\openexr-develop\IlmBase\install_ -G"Visual Studio 14 2015 Win64" ..
CMake command line for OpenEXR:
cmake -DBUILD_SHARED_LIBS=ON -DILMBASE_PACKAGE_PREFIX=C:\...\openexr-develop\IlmBase\install_ -DCMAKE_INSTALL_PREFIX=C:\...\openexr-develop\OpenEXR\install_ -DZLIB_LIBRARY=C:\...\zlib-1.2.11\install\lib\zlib.lib -DZLIB_INCLUDE_DIR=C:\...\zlib-1.2.11\install\include -G"Visual Studio 14 2015 Win64" ..
CMake command line for OpenVDB:
cmake -DOPENVDB_ABI_VERSION_NUMBER=5 -DBUILD_SHARED_LIBS=ON -DGLEW_LOCATION=C:\...\glew-2.1.0-src -DBLOSC_LOCATION=C:\...\c-blosc-master\install -DTBB_LOCATION=C:\...\tbb2018_20180618oss -DZLIB_ROOT=C:\...\zlib-1.2.11\install -DILMBASE_LOCATION=C:\...\openexr-develop\IlmBase\install_ -DOPENEXR_LOCATION=C:\...\openexr-develop\OpenEXR\install_ -DOPENVDB_BUILD_DOCS=ON -DCPPUNIT_LOCATION=C:\...\cppunit-1.12.1 -G"Visual Studio 14 2015 Win64" ..
A few modifications were made inside VS in order to proceed:

change link input tbb.lib to tbb_debug.lib
Add /bigobj as an additional compiling option

When building openvdb_shared project in VS, I got the following error:

1>------ Build started: Project: openvdb_shared, Configuration: Debug x64 ------
1>     Creating library C:/.../openvdb-5.1.0/build/openvdb/Debug/openvdb.lib and object C:/.../openvdb-5.1.0/build/openvdb/Debug/openvdb.exp
1>points.obj : error LNK2001: unresolved external symbol "private: static union half::uif const * const half::_toFloat" (?_toFloat@half@@0QBTuif@1@B)
1>openvdb.obj : error LNK2001: unresolved external symbol "private: static union half::uif const * const half::_toFloat" (?_toFloat@half@@0QBTuif@1@B)
1>points.obj : error LNK2001: unresolved external symbol "private: static unsigned short const * const half::_eLut" (?_eLut@half@@0QBGB)
1>openvdb.obj : error LNK2001: unresolved external symbol "private: static unsigned short const * const half::_eLut" (?_eLut@half@@0QBGB)
1>C:\...\openvdb-5.1.0\build\openvdb\Debug\openvdb.dll : fatal error LNK1120: 2 unresolved externals
========== Build: 0 succeeded, 1 failed, 1 up-to-date, 0 skipped ==========

After some analysis, the error arises from the presence of a preprocessor definition HALF_EXPORTS:

If I removed this preprocessor definition, openvdb_shared project builds successfully in VS. HALF_EXPORTS is set only by CMake for the Half project itself in IlmBase in order to cause symbols to export. It is done in C:\...\openexr-develop\IlmBase\Half\CMakelists.txt, line 43. The definition is marked private:
  TARGET_COMPILE_DEFINITIONS ( Half PRIVATE HALF_EXPORTS )
I think it should not be the OpenEXR&IlmBase's problem to leak HALF_EXPORTS because there is another famous project that uses OpenEXR&IlmBase: OpenImageIO. If IlmBase leaks HALF_EXPORTS, it should appear in the OIIO project too. But there is no HALF_EXPORTS in OIIO. So I think it should be OpenVDB's problem. All the builds are clean, that is, there is no cache residues affecting the build.
So, could you please figure out how the preprocessor definition HALF_EXPORTS is leaked from IlmBase to OpenVDB VS solution, and how to fix it? Please let me know if you need other info to troubleshoot the issue. A reference to a related OpenEXR&IlmBase issue ticket is here: https://github.com/openexr/openexr/issues/302. Thank you.

User has been deleted - but this problem is now resolved. A line in the older root CMakeLists.txt of OpenVDB (pre v6.1) for windows builds was adding the define:
IF (WIN32)
  ADD_DEFINITIONS ( -D_WIN32 -DNOMINMAX -DHALF_EXPORTS -DOPENVDB_DLL )
...


I cann't push some images into the harbor's registry,always retrying，get stuck in pushing, and EOF.

2017-12-07.zip
2017-12-07.zip
[root@szautodeploy5 ~]# docker push <IP_ADDRESS>/rancher/agent:latest
The push refers to a repository [<IP_ADDRESS>/rancher/agent]
da9f45a1a82f: Layer already exists
b3e14099ad4a: Layer already exists
131926e86d5d: Layer already exists
34c32605199e: Pushing [==================================================>]  2.048kB
5972ebe5b524: Pushing [==================================================>]  3.072kB
3d515508d4eb: Pushing [==================================================>]  4.608kB
bbe6cef52379: Pushing  11.78kB
87f743c24123: Pushing [==================================================>]  15.87kB
32d75bc97c41: Pushing [==================================================>]  134.6MB
EOF
1)Version of docker engine and docker-compose.
docker:17.05
docker-compose:1.17.0
harbor:1.2.2
2)Config files of harbor, you can get them by packaging "harbor.cfg" and files in the same directory, including subdirectory.
harbor.cfg only modify：
hostname = <IP_ADDRESS>
3)Log files, you can get them by package the /var/log/harbor/ .
attachment

Are you seeing EOF for all images or only <IP_ADDRESS>/rancher/agent:latest?
Does it fail at the same point everytime?

Some successes and others fail like this，fail at different point ，i don't know why？

The logs contain no information about your pushing operation. Could you reproduce the error, package the logs and upload it again?

I know the reason now, i start dockerd "nohup docker daemon -H tcp://<IP_ADDRESS>:2375 -H unix:///var/run/docker.sock &" and proxy , i remove them all ,and work fine. Thanks

I am getting the same error while pushing to my private harbor registry. I tried tweaking nginx and registry config but to no avail.
It retries for a certain time and then gives an EOF message and fails to upload. Uploading a end snippet of the registry logs with masked values.
Let me know if more details are required. The log file contains the version details
registry.log


font-manager uses 100% CPU/infinite loop

Font-manager goes into an infinite loop when one does the following:
Steps to reproduce
Install font-manager and gnome3.adwaita-icon-theme
Start font-manager
Resize the left pane by moving the splitter to the right.
Click on Vendor
Click on Google

Does this only occur when clicking that specific vendor?
If so, how far down the listing is this vendor on your machine?
Also, is there any output during the loop if run with the verbose flag?
In any case, I'll try to reproduce this tonight. Thanks for the detailed report.

Same with Adobe
font-manager -V
[WARNING 17:34:25] Error retrieving accessibility bus address: org.freedesktop.DBus.Error.ServiceUnknown: The name org.a11y.Bus was not provided by any .service files
[DEBUG 17:34:25] [Main:299] Font Manager 0.7.3
[DEBUG 17:34:25] [Main:300] Using GLib 2.48.2
[DEBUG 17:34:25] [Main:301] Using JSON-GLib 1.2.0
[DEBUG 17:34:25] [Main:302] Using SQLite 3.14.2
[DEBUG 17:34:25] [Main:303] Using FontConfig 2.11.01
[DEBUG 17:34:25] [Main:304] Using Pango 1.40.2
[DEBUG 17:34:25] [Main:305] Using GTK+ 3.20.9
[DEBUG 17:34:25] [Main:307] Screen is composited. Client side decorations enabled.
[DEBUG 17:34:25] [Main:311] Running on KDE
[DEBUG 17:34:25] [FontPreviewPane:148] Selected preview mode : Preview
[WARNING 17:34:25] [Gtk] Could not load a pixbuf from /org/gtk/libgtk/theme/Adwaita/assets/bullet-symbolic.svg.This may indicate that pixbuf loaders or the mime database could not be found.

Tested locally, 895 fonts (don't ask) and it sits at ~0% cpu usage at rest.
When following the reproduction instructions it does use 100% cpu for a small while, but goes back to 0%.
Verified using:
/nix/store/jlqk1dcy2zbiwb01gdm83iq42fyv3r0l-font-manager-0.7.3

With my lack of repro, plus the time since last activity, I'm closing; do re-open if you still can reproduce the issue with recent revisions.


Sort tasks by time

Hi
When I create my task template I separate what want to do (Read article, write report) every day from random interuption tasks (buy this, fetch that, email this person, etc.) or meetings. They are all given a time, but when shown on the timeline, they are in the order of the list and not TIME. Would it be possible for the day planner to read the time and slot the items accordingly in my timeline?

I'd love to have this too!

That would be awesome to have, I also usually order tasks like this. It would be great if the Day Planner did the sorting by time for me :)

+1

Available in 0.23.2


Update worker loading instruction (vite 2.8+)

Vite 2.8 changed the worker loading syntax removing the new for special import syntax.
All working handling code needs to be adapted to this.

Realized after merging monaco-editor-workers branch.


docker system prune does not support use of the "--filter" option

File: engine/reference/commandline/system_prune.md, CC @mstanleyjones
It doesn't appear that the filter command provided in the example is actually accepted:
https://docs.docker.com/engine/reference/commandline/system_prune/#examples
~ $ docker system prune --filter "until=1h"
unknown flag: --filter
See 'docker system prune --help'.
~ $ docker system prune --help

Usage:	docker system prune [OPTIONS]

Remove unused data

Options:
  -a, --all     Remove all unused images not just dangling ones
  -f, --force   Do not prompt for confirmation
      --help    Print usage

What version of Docker do you have? I do not believe --filter was valid for this command until 17.03. @thaJeztah can confirm.

Yes, looking, looks like a bad cherry-pick; the CLI fixups were against master, and the cherry-pick applied "cleanly", but pulled these changes in

I suspect GitHub "randomly hiding diffs" made the changes in these files invisible https://github.com/docker/docker/pull/31242 😞

@mstanleyjones
~ $ docker version
Client:
Version:      17.03.0-ee-1
API version:  1.26
Go version:   go1.7.5
Git commit:   9094a76
Built:        Fri Feb 24 19:01:49 2017
OS/Arch:      linux/amd64
Server:
Version:      17.03.0-ee-1
API version:  1.26 (minimum version 1.12)
Go version:   go1.7.5
Git commit:   9094a76
Built:        Fri Feb 24 19:01:49 2017
OS/Arch:      linux/amd64
Experimental: true

We found the problem: https://github.com/docker/docker/pull/32390
This should be fixed soon!

Great -- that filter will be very useful!

Looks like it's in there now. Thanks all! :)


A proposition for another OfferCollectionResponseContent type with OfferSummary only

Hi.
Do you mind to add one more option to OfferCollectionResponseContent which restriction is somewhere in between current TRIPS and OFFER: OFFER_SUMMARY? Most of our (PKP) retailer systems flow has a stage that we can call "first page price" or " overall price query" that is not represent in OSDM API. Pulling a full offersCollectionResponse for each trip in tripCollection is not needed at this stage, moreover generating only overall offerSummary for trips list and then, in another action, full offerCollection for particular out- and inbound trips pair is very helpful for backend efficiency.

Discussion with PKP is needed.  Offer request for cheapest price only?

Could be solved with a new value for the embed attribute OFFER_SUMMARY


failed to ping localhost:25565 : read tcp <IP_ADDRESS>:48942-><IP_ADDRESS>:25565: read: connection reset by peer

Describe the problem
I cannot connect to my minecraft server, container keeps reporting back this error.
Container definition
docker run -d -p 25565:25565 --name minecraft -e TYPE=QUILT -e EULA=TRUE -v /home/oliverjelincic/Minecraft/home:/data itzg/minecraft-server
Container logs
Very normal Minecraft server logs

Please provide container logs as was requested in the issue template.


Invalid e2e workflow

Description
See - https://github.com/meshery/meshery-kuma/actions/runs/1616010189
Invalid workflow file : .github/workflows/e2etest.yaml#L37
The workflow is not valid. .github/workflows/e2etest.yaml (Line: 37, Col: 11): Input k8s_version is required, but not provided while calling. .github/workflows/e2etest.yaml (Line: 37, Col: 11): Input sm_version is required, but not provided while calling.

Contributor Resources
The meshery.io website uses Jekyll and GitHub Pages. Site content is found under the master branch.

See the Contributing to Meshery.io Website section of the readme.md and other contributing instructions, too.
See Meshery site designs in this Figma designfile. Fill-in the Layer5 Community Member Form and join the Layer5 Community Slack for access.

@alphaX86, @Revolyssup ...

@alphaX86, @Revolyssup ...

I know this issue. It will be fixed tomorrow


Can't resolve './components/InstanceMonitoringCard'

I was trying to import order summary from this library. When I was trying to install this library I am getting an error message. I have attached the screenshot below.

This issue is related to components file path, it tries to import a component from the folder which is not there. So we need to rename the file name.
I am also getting another issue with related to styles(scss). Pls refer screenshot below.

Please take a look at this issue. I am in need of this library.

Is there anyone looking into this issue. I am in need of this library. My application is getting an error.
Can anyone look into this issue please??


Get to 0 Duplication on Code Climate

Volt, now 100% DRY!

Grr… worked on my machine!

…and now it doesn't. Didn't save?


fixed nodejs requirement for netlify

Commit 553edb6191564311eac166e45b0e8c653ba0a150 breaks Netlify-deployments. Node 12.0.x has been available on Netlify for some time, but it still defaults to 10.x.x, so it can't satisfy the required bumped version. By adding the enviroment variable in the toml-file we can specify the Node version on Netlify's side.
Another fix would be to create a .node-versions or .nvmrc which would also work on Netlify's end (I think?)

I took the long way around. Forked it, then I edited netlify.toml, which just failed. Oops
Going to try your new build with the patch. Sorry for closing prematurely, I assumed it would be fixed. Seemed simple enough.

I thought I was commenting on my issue. I'm new to all this.

@theapplegates yes sorry, I'm a silly sausage. The 12.0.x was erroneous, it should be 12.0.0. It's an enviroment variable, not a semver package version. I'll do a new pull request.


file system support for 'volume.block.filesystem'

Greetings (again),
I am just wondering if there is any plan to add more file systems for 'lxc storage create lxd ceph volume.block.filesystem' type configurations.
Right now I see ext4/xfs are only supported.
xfs + ceph are not playing nice at the moment, and would like to try a few different file systems for the backends there.

What filesystems are you thinking about?
More can be added but this needs specific code in LXD for the LVM and Ceph code paths.

Actually, really now that I think about it -- probably just btrfs.

Ok, that should be reasonably straightfoward to add. We just need to check how to re-generate the btrfs fs uuid on copy, assuming that btrfs would be confused by the exact same uuid being present multiple times.

@albertodonato can you send a branch which adds support for mkfs.btrfs where we currently support mkfs.ext4 an mkfs.xfs?

@albertodonato this will need an API extension string.


Always add #success to response from #hlr

After using HLR status requests, I faced with problem that for some numbers (e.g. Ukrainian) sending HLR request is not successed (and we will not have id to pass it to #hlr_status).
So, I add second rule to parse response from #hlr and make success method to be available anyway. It is realized in v0.1.2 by #success? method, but I miss this in v0.0.10 :)

Thank you!

Will you bump version for me?) I'll be very grateful to you

@Earendil95 ahh, sorry, I've totally missed that
Done

Thank you!


fix: LaTeX issues in questions

Fixes #521

Summary by Sourcery
Fix LaTeX syntax issues in multiple JSON data files to address rendering problems in mathematical expressions within questions.
Bug Fixes:

Correct LaTeX syntax in JSON data files to ensure proper rendering of mathematical expressions in questions.

The validation script also failed in one of the other PRs before ...

Merging now to still get it done


bug repro: channel sync on reconnect

This pr contains a docker-based integration test that reproduces a rejected commitment error when syncing a channel after reconnect.
Test can be executed by running ./repro.sh

Some of the crashes caught so far:
[bob] 2020-04-15 08:48:44.370 [ERR] HSWC: ChannelLink(501:1:0): failing link: unable to update commitment: height=299, for ChannelPoint(8434184d22e2db03ed5dfaef2fa7ab0c5b0374136138d92e18612c087babaf00:0) attempts to consume 0.1001945 BTC while channel capacity is 0.1 BTC with error: internal error
2020-04-02 10:14:37.648 [ERR] HSWC: ChannelLink(27294:1:0): failing link: ChannelPoint(af6c8536ef5b1a5bcce6ad1ddf2b60e2f5cf191094f8f623f61917ccc817339a:0): unable to accept new commitment: not enough HTLC signatures. with error: invalid commitment
2020-04-02 13:37:16.309 [ERR] HSWC: ChannelLink(27414:1:0): failing link: unable to handle upstream add HTLC: parent entry 183 for update 360 had zero local add height with error: invalid update

Without chaos monkey randomly killing instances, no errors happen. Maybe something in the re-establish logic.


use task's last updated time for scheduler rank

Description
In very large task graphs with task retry enabled (awaiting updates), the tasks which are scheduled first may never execute because by the time the newer tasks inserted into the graphs expire their re-attempt timeouts, the scheduler will decide to run them again. This results in the earlier scheduled tasks not executing until the later scheduled tasks have completed.
Motivation and Context
It makes running very large task graphs with task reattempts enabled work as expected. It doesn't seem to affect scheduling otherwise (in a task graph without re-attempts, the tasks which are updated won't be considered in the first place)
See #2259
Have you tested this? If so, how?
We have been running with this change in production for six months and it has been working as expected. If this breaks or otherwise justifies a test, I haven't tested it though.

I'm fine with this I think. But can you check and understand why so many tests fail? Are the tests overasserting or is something essential breaking with this change?

Is there something significant about it only failing under the "nonhdfs" build profiles?
I believe the test_resend_batch_on_get_work_retry is a natural consequence of the proposed change resulting in the work ordering constraints being loosened. So if you agree, I would run sorted on the array contents.
WRT test_tasks_parallel and test_lock_resources_for_second_worker I'm not sure how these tests are being affected by the proposed change since it doesn't seem like the priority system should interact with resource constraints. Does work have to be returned in the same order for resource constraints to function?

Is there something significant about it only failing under the "nonhdfs" build profiles?

Well, "nonhdfs" was a poorly choosen name by me. But it's the "main" or "core" tests, including the scheduler tests.

I believe the test_resend_batch_on_get_work_retry is a natural consequence of the proposed change resulting in the work ordering constraints being loosened. So if you agree, I would run sorted on the array contents.

Sure. Actually you probably want assertCountEqual.

WRT test_tasks_parallel and test_lock_resources_for_second_worker I'm not sure how these tests are being affected by the proposed change since it doesn't seem like the priority system should interact with resource constraints. Does work have to be returned in the same order for resource constraints to function?

Can you investigate this further on your own? test_lock_resources_for_second_worker was very recently submitted by @riga in #2346 tough.


Add regolith-filter tag to the repository

The filter resolver repository uses regolith-filter "topic" to detect repositories with regolith filters. This way the filter can be automatically added to the resolver allowing easier installation of the filter, with command:
regolith install nbt-to-mcstructure

The GitHub action that manages the resolver repository runs once per day.

Additionally you could add a special tag that regolith uses for versioning to tag the version of the filter. The tags use pattern - <filter-name>-<semver>. In case of this repository it should be: nbt-to-mcstructure-1.0.0 or some other version number if you prefer a different one.


github action to create a release

This is dependent on issue #82, after a successful build, run a github action to create a release.

We still want this Stalebot 🤓

Wait, I am not sure I understand. You are proposing a release every time a PR is merged? That would be so many releases. Why would we need that?
Perhaps,  I don't completely understand.

Wait, I am not sure I understand. You are proposing a release every time a PR is merged? That would be so many releases. Why would we need that?
Perhaps,  I don't completely understand.

@adityaraute it is good to have build releases, for example increment the X on the release version 0.0.X each time

@adityaraute it is good to have build releases, for example increment the X on the release version 0.0.X each time

Every time we push a commit?

Every time we push a commit?

ideally each commit push should be deployable - in the perfect situation, which is not always the case. I think when people realise a potential release is created they try to push better commits or group commits together and do not push then until ready - so really it is on each push not necessarily each commit

ideally each commit push should be deployable - in the perfect situation, which is not always the case. I think when people realise a potential release is created they try to push better commits or group commits together and do not push then until ready - so really it is on each push not necessarily each commit

I did mean each push, yes. That would be too many releases, though. Wouldn't it?

I did mean each push, yes. That would be too many releases, though. Wouldn't it?

there would be a lot, but these would be build releases - each project is slightly different. It can also be done when merged to the default branch this will reduce the releases because they would have had to be reviewed first

there would be a lot, but these would be build releases - each project is slightly different. It can also be done when merged to the default branch this will reduce the releases because they would have had to be reviewed first

We not doing this then?


Publish on npm and bower

Publish the package in bower and npm registry. @cjhowald I noticed that the solution header is published on bower and npm? do we have a zalando user for publishing?

I just used a personal npm account to publish. Did some digging on npm and I see there is a zalando user. Looks like it is connected to @prayerslayer. Perhaps he can shed some insight.

I asked to @prayerslayer and he confirmed that we don't have a npm organization. So we should publish with our personal account.

closed with https://github.com/zalando/dress-code/commit/658bf3721928380bd263dde129358deac728bdf1


create Alternative text page

Ready for review
In development - Alternative text and long description – Best practices - Digital Accessibility Toolkit / Sharing space
Missing French version


MINOR: [C++][Benchmark][Acero] Fix a typo

Rationale for this change
It causes a build error:
cpp/src/arrow/acero/hash_join_benchmark.cc:40:3: error: ‘JoinType’ does not name a type; did you mean ‘UnionType’?
   40 |   JoinType join_type = JoinType::INNER;
      |   ^~~~~~~~
      |   UnionType
...

What changes are included in this PR?
Fix a typo.
Are these changes tested?
Yes.
Are there any user-facing changes?
No.

+1


Remove repo chip from default context

Removes the repo chip from the default chat context:

BeforeAfter

To make the repo context still discoverable, adds a Rerun with repository context button when no repo chips are present:
https://github.com/user-attachments/assets/4f8f1763-c229-4993-b198-15d41100fe32
Test plan

Changelog

@sqs

Approved for dogfooding on prerelease asap. Will need migration and more design work for the transition in the release.

We (me, Grace, et al) have a proposal to use the prerelease channel to "soak" versions before going to stable. We would patch ship blocking bugs on that channel, and the next stable release would be based on that. The motivation is to reduce the serious defects reaching our customers and use time that had been spent firefighting on more productive things. However it does come at the cost of adding some latency between commits on main and wide distribution.
In practice in this case, it means dogfooding on prerelease would have to wait up to a week. Design work would not be merged to release branches unless it was a ship blocking bug.
I appreciate having a low-latency way to get feedback is very valuable but I believe we need more reliable low-latency quality indicators before we can do that. We are working on it.


Mechanics of replay rendering and demo file info

I am thinking how the replay file and Dota 2 client are working together to render the game. The following are some of my questions and assumptions.
Question 1 (neutral stacking)
When we click on a replay tick, the state of current world in shown. There may be neutral stacking. How is it generated?
Assumption 1
The state of current tick is calculated from the first tick.  When they are attacked, they will act in the predefined way. The neutral stacking, pulling, creeps attacking are working in this way.
Assumption 2
We have stacking info stored in the demo file, so the stacking state at a neutral point is restored for a particular tick.
Question 2 (creep location and health)
Similar to Q1. At a particular tick, how are the creep location and health generated?
Assumption 1
The mouse click, keyboard press, damage info are stored in the demo file, and the state of current world is generated based on the mechanism described in Assumption 1.
General question
How do I know what info are stored in the demo file and what info are generated by the Dota 2 client? Go through all the proto files?
Does anyone have any ideas on this? Thanks a lot.

Q1: Both assumptions do not hold. The replay does only contain the state of the world at every tick. Every 2 minutes there is a full packet with the complete state, and differential updates in between. When a minute mark passes in the game, the server spawns entities, which will be reflected in the world state. When playing back, it'll just display the world state, and not compute anything.
Q2: There are no actions whatsoever in the replay file. No state is generated when playing back. You only see the results of actions done (changes in health for example).
Starcraft for example uses a system where they store player actions in the replay. This has the disadvantage that a later client cannot play back an earlier replay, since things change in patches, for example the damage amount a nuke does. So to be able to play back a replay from an old patch with the current client, there must not be a single computation done from an action while playing back

the replay contains an entity for every building, hero, creep, neutral. That entity contains life state, health, position and so on. There might be an entity for a neutral-camp, but I am not sure.
yes. There's several IDs for an entity: First is it's index in the entity table, the other is a so called handle.

You can get to entity data, by using the Entities-processor, for example:
ctx.getProcessor(Entities.class).getByHandle(theHandle)
ctx.getProcessor(Entities.class).getByIndex(theIndex)
ctx.getProcessor(Entities.class).getAllByPredicate(yourPredicate)

To enable entity processing, you have to annotate your processor with @UsesEntities.
I recommend using clarity analyzer to see what data there is.

Thanks for the recommendation, I will try it now! 👍


dockerfile: alpine:3.16

Update the alpine base image from 3.12 to 3.16.
Per https://endoflife.date/alpine or https://alpinelinux.org/releases/ , support for 3.12 ended on 2022-05-01.
Support for 3.16 will continue to 2024-05-23.

Great, thank you!


Unable to authenticate version 1.34

Preflight Checklist

[X] I have installed the latest version of Storage Explorer.
[X] I have checked existing resources, including the troubleshooting guide and the release notes.
[X] I have searched for similar issues.

Storage Explorer Version
1.34
Regression From
1.31
Architecture
i86
Storage Explorer Build Number
No response
Platform
All
OS Version
windows11
Bug Description
I am experiencing an authentication issue with Storage Explorer version 1.34. In version 1.31, authentication via browser and other methods works without any problems. However, in version 1.34, the browser does not open, and I am unable to authenticate. Reverting back to version 1.31 resolves the issue. I believe this is a bug and would appreciate a fix for it.
Steps to Reproduce

Update to Storage Explorer version 1.34.
Attempt to authenticate using the browser or any other method.

Actual Experience
The browser does not open, and authentication fails.
unable to authenticate all methods
Expected Experience
The browser should open, allowing for successful authentication.
Additional Context
Reverting back to Storage Explorer version 1.31 resolves the issue, and authentication works as expected.
Thank you for your attention to this matter.

@TakataMichiyoshi What about versions in between 1.31.0 and 1.34.0? Do any of those versions authenticate successfully?

Version 1.30, 1.31, 1.33.1 works fine today, but version 1.34.0 does not progress beyond the initial state. Thank you for your reply.

1.34.0

1.33.1

Version 1.34 is stuck on loading and won't progress. The Help, View, Edit, and File menus are all unresponsive.

@TakataMichiyoshi do you know if you have .NET 8 installed? If you don't know, you can share the output you see of running dotnet --info in PowerShell, like:
PS C:\Users\username> dotnet --info
.NET SDK:
 Version:           8.0.400-preview.0.24324.5
 Commit:            736a2616db
 Workload version:  8.0.400-manifests.fbc8f109
 MSBuild version:   17.11.0+1192b22fd

Runtime Environment:
 OS Name:     Windows
 OS Version:  10.0.26120
 OS Platform: Windows
 RID:         win-arm64
 Base Path:   C:\Program Files\dotnet\sdk\8.0.400-preview.0.24324.5\

.NET workloads installed:
Configured to use loose manifests when installing new manifests.
 [aspire]
   Installation Source: VS 17.12.35101.237
   Manifest Version:    8.0.0/8.0.100
   Manifest Path:       C:\Program Files\dotnet\sdk-manifests\8.0.100\microsoft.net.sdk.aspire\8.0.0\WorkloadManifest.json
   Install Type:        FileBased

Host:
  Version:      8.0.5
  Architecture: arm64
  Commit:       087e15321b

.NET SDKs installed:
  8.0.400-preview.0.24324.5 [C:\Program Files\dotnet\sdk]

.NET runtimes installed:
  Microsoft.AspNetCore.App 8.0.5 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
  Microsoft.NETCore.App 8.0.4 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
  Microsoft.NETCore.App 8.0.5 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
  Microsoft.WindowsDesktop.App 8.0.5 [C:\Program Files\dotnet\shared\Microsoft.WindowsDesktop.App]

Other architectures found:
  x64   [C:\Program Files\dotnet\x64]
    registered at [HKLM\SOFTWARE\dotnet\Setup\InstalledVersions\x64\InstallLocation]
  x86   [C:\Program Files (x86)\dotnet]
    registered at [HKLM\SOFTWARE\dotnet\Setup\InstalledVersions\x86\InstallLocation]

Environment variables:
  Not set

global.json file:
  Not found

Learn more:
  https://aka.ms/dotnet/info

Download .NET:
  https://aka.ms/dotnet/download

.NET SDK:
Version:   8.0.100-preview.5.23303.2
Commit:    3fe444af72
ランタイム環境:
OS Name:     Windows
OS Version:  10.0.22631
OS Platform: Windows
RID:         win10-x64
Base Path:   C:\Program Files\dotnet\sdk\8.0.100-preview.5.23303.2\
.NET workloads installed:
表示するインストール済みワークロードはありません。
Host:
Version:      8.0.0-preview.5.23280.8
Architecture: x64
Commit:       bc78804f5d
.NET SDKs installed:
8.0.100-preview.5.23303.2 [C:\Program Files\dotnet\sdk]
.NET runtimes installed:
Microsoft.AspNetCore.App 8.0.0-preview.5.23302.2 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
Microsoft.NETCore.App 6.0.16 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
Microsoft.NETCore.App 8.0.0-preview.5.23280.8 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
Microsoft.WindowsDesktop.App 8.0.0-preview.5.23302.2 [C:\Program Files\dotnet\shared\Microsoft.WindowsDesktop.App]
Other architectures found:
None
Environment variables:
Not set
global.json file:
Not found
Learn more:
https://aka.ms/dotnet/info
Download .NET:
https://aka.ms/dotnet/download

The Japanese '表示するインストール済みワークロードはありません', and it's means 'no installed workload'.
Thank you for your cooperation.

After updating .NET and the SDK to the latest versions, everything started working properly with version 1.34.0. Thank you for your assistance.

.NET SDK:
Version:           8.0.303
Commit:            29ab8e3268
Workload version:  8.0.300-manifests.c915c39d
MSBuild version:   17.10.4+10fbfbf2e
ランタイム環境:
OS Name:     Windows
OS Version:  10.0.22631
OS Platform: Windows
RID:         win-x64
Base Path:   C:\Program Files\dotnet\sdk\8.0.303\
インストール済みの .NET ワークロード:
表示するインストール済みワークロードはありません。
Host:
Version:      8.0.7
Architecture: x64
Commit:       2aade6beb0
.NET SDKs installed:
8.0.100-preview.5.23303.2 [C:\Program Files\dotnet\sdk]
8.0.303 [C:\Program Files\dotnet\sdk]
.NET runtimes installed:
Microsoft.AspNetCore.App 8.0.0-preview.5.23302.2 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
Microsoft.AspNetCore.App 8.0.7 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
Microsoft.NETCore.App 6.0.16 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
Microsoft.NETCore.App 8.0.0-preview.5.23280.8 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
Microsoft.NETCore.App 8.0.7 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
Microsoft.WindowsDesktop.App 8.0.0-preview.5.23302.2 [C:\Program Files\dotnet\shared\Microsoft.WindowsDesktop.App]
Microsoft.WindowsDesktop.App 8.0.7 [C:\Program Files\dotnet\shared\Microsoft.WindowsDesktop.App]
Other architectures found:
None
Environment variables:
Not set
global.json file:
Not found
Learn more:
https://aka.ms/dotnet/info
Download .NET:
https://aka.ms/dotnet/download


Overhead in solver interface

When doing many "easy" solve calls, the overhead of CPMpy becomes very significant.
We should try to minimize this to some extend as it can slow down many applications relying on repeated solving, such as MUS extraction/enumeration!
The following code snippet gives an idea of the extend of the problem:
import cpmpy as cp
from time import time

n = 100
iterations = 10000

bvars = cp.boolvar(name="bv", shape=n)

import random
random.seed(0)

solver = cp.SolverLookup.get("pysat")
solver += cp.sum(bvars) >= 0

solve_time = 0
t0 = time()

for i in range(iterations):
    print(f"\rAt iteration {i+1}", end="\t")
    if solver.solve() is False:
        break
    solve_time += solver.status().runtime
    # do something with the assignment
    bvars.value().sum()
    # add new constraint
    solver += cp.any([bv if random.random() >= 0.5 else ~bv for bv in bvars])
print()

print(f"Did {i+1} iterations")
print("Total time spent in solving:", solve_time)
print("Total time:", time()-t0)

Solver
Solve time
Total time

OR-Tools
990.01s
1192.569s

Pysat
0.08s
17.94s

Gurobi
38.45s
126.27s

Z3
275.06s
515.65s

Attached are some of the profiler runs for the above script
profile.zip

Here is a slightly updated version that does the profile and ranks by time (excluding time in subfunctions):
import cpmpy as cp
from time import time

n = 100
iterations = 10000

bvars = cp.boolvar(name="bv", shape=n)

import random
random.seed(0)

solver = cp.SolverLookup.get("pysat")
solver += cp.sum(bvars) >= 0

solve_time = 0
t0 = time()

for i in range(iterations):
    print(f"\rAt iteration {i+1}", end="\t")
    if solver.solve() is False:
        break
    solve_time += solver.status().runtime
    # do something with the assignment
    bvars.value().sum()
    # add new constraint
    solver += cp.any([bv if random.random() >= 0.5 else ~bv for bv in bvars])
print()

print(f"Did {i+1} iterations")
print("Total time spent in solving:", solve_time)
print("Total time:", time()-t0)

It showed '  1010000    1.271    0.000    1.812    0.000 /home/tias/research/cpmpy/cpmpy/expressions/variables.py:449(getitem)
which turned out to be due to the         from .globalfunctions import Element # here to avoid circular import that is at the top of that function.
So that is useful to know and easy to fix... we can do a generic import cpmpy as cp import at the top of the file, and we should never do inline imports... I'll report separately.

Could it be that you accidentally pasted the same code as Ignace, instead of your updated version?

Yes...
import cpmpy as cp
from time import time
import cProfile
import pstats

n = 100
iterations = 5000

bvars = cp.boolvar(name="bv", shape=n)

import random
random.seed(0)

solver = cp.SolverLookup.get("pysat")
solver += cp.sum(bvars) >= 0

solve_time = 0
t0 = time()

profiler = cProfile.Profile()
profiler.enable()
for i in range(iterations):
    print(f"\rAt iteration {i+1}", end="\t")
    if solver.solve() is False:
        break
    solve_time += solver.status().runtime
    # do something with the assignment
    bvars.value().sum()
    # add new constraint
    solver += cp.any([bv if random.random() >= 0.5 else ~bv for bv in bvars])
profiler.disable()
print()

print(f"Did {i+1} iterations")
print("Total time spent in solving:", solve_time)
print("Total time:", time()-t0)

# Print the results
stats = pstats.Stats(profiler)
stats.sort_stats('time')  # You can sort by 'time', 'cumulative', etc.
stats.print_stats()


Suggestion: add a suffix to item's name indicating that they are automated

I think it would be helpful if automated spells, items and feats in the DAE SRD compendiums had something in their name indicating that they are automated (for instance a D or A in parenthesis at the end or something like that). That way, it is possible to easily know when to expect an automated behavior or not, or which of our actors' owned items are automated and which ones are not and should be replaced by the DAE SRD version.
However I suppose this would require you to go over every item one by one, and maybe I'm the only one who would find that useful, so I'd totally undestand if this wasn't considered.
Cheers and thanks for the great module!

Im afraid this isnt possible for another reason too. Many mass replace functions look at names when replacing data, this wouldnt be possible with this addition. Everything in the DAE SRD is automated to some extent (auto update on equip, attune, attack etc)


Return nil at the end of createScrapeConfigs

Currently the function returns the latest value of the "err" variable. This isn't what should be happening. If we want to return an error, we should do so in one of the if err != nil {} blocks. When the function gets to the end, it should be considered as successfuly executed.

/retest

/retest
RDO timeout

recheck

/lgtm


add db scripts

Description
Add scripts for use with new Craft config, that allow for stashing and popping local databases to stash.sql.gz file
Related issues
project.yaml (I think that's all I need to say 🙃 )
How to test

make sure your ./backups directory doesn't have a stash.sql.gz file in it
make some things (entries, categories, etc.) and run ./bin/stash-db, which should result in a stash.sql.gz file being created in the ./backups directory
restart Docker containers (./bin/start) and you none of those entries, categories, etc. should have persisted
stop containers, run ./bin/pop-db and ./bin/start, and then check for the entries, categories, etc. that you created (which should now be present)

Thanks for the PR, @saurookadook! Can you add some documentation detailing this new functionality in the README?

@mgburns Lost track of this but I'll make a note to update the README soon!


Blank window on startup (network related?)

VS Code worked fine until it self-updated from 1.11.0 to 1.11.1. After the first restart only empty windows appeared and the application hung. After killing Code and Code Helper processes it doesn't start at all. Processes Code and "Code Helper" are running, but no windows are created. Adding "git.enabled": false to settings doesn't make any difference. Downgrading to 1.11.0 restores functionality.
I can provide a hang report of the initial hang after upgrade if necessary.

VSCode Version: 1.11.1
OS Version: macOS Sierra 10.12.4

Extensions:

Java Debugger 0.0.2
Language Support for Java(TM) by Red Hat 0.1.0
php cs fixer 0.1.33
PHP Debug 1.10.0
PHP Extension Pack 1.0.1
PHP IntelliSense 1.1.4
PHP Intellisense - Crane 0.3.6
phpcs 0.7.0

Steps to Reproduce:

Install version 1.11.1
Try to execute it

@EreMaijala I wonder if there are some leftover Code processes hanging around, could you either restart or kill any code process from activity monitor and then try again? Also, does it make a difference if you run from a terminal vs. dock?

@bpasero I've tried both to no avail. From terminal it just sits there waiting.

This is what opened after the march update for me, can't even do cmd + q to quit.
only extension installed is python extension

@EreMaijala what if you run "code -n" from the command line?

@bpasero I'm not sure if I'm doing it right since there's no executable "code" in the package, but I tried to run /Applications/Visual\ Studio\ Code.app/Contents/MacOS/Electron -n and it didn't change anything.

What, this suddenly popped up, after a full day of this black screen, and when I decided to fix my visual studio code installation. I don't know it will fix it, I don't see a progress of downloading the helper thing.
I even uninstalled and reinstalled the new version from visual studio code website yesterday. Even a new install didn't fix it.
I remember using code command, but i dont know why its not working now.. but apparently for code command to work you need to do this http://stackoverflow.com/questions/29971053/how-to-open-visual-studio-code-from-the-command-line-on-osx which needs vscode to work.

@EreMaijala yeah that is fine, thanks. To rule out any update issue, can you download Code 1.11.1 fully (from here) and run it out of the download to see if that works any better?

@syllogismos the code command can be installed via our command entry:

The popup you see can happen when you have downloaded Code to another location then where you typically run it from (e.g. applications) and then auto update kicks in. Did you download a previous version or is this 1.11.1?

Oh sorry, yeah, I unzipped the downloaded installation again and started it from different folder, just now to see. It makes sense. It also didn't work for me.
Even command entry command cmd+shift+p doesn't work for me.
It is 1.11.1

@syllogismos can you try to run from the command line and see if that makes any difference?

I removed my old installation from Applications, and downloaded from the link you gave me and unzipped and moved it to applications, still its just a black screen. The only other notable thing I can think of is that I use high contrast theme. Im just wondering if it made everything black in this release.
somehow code command started working again, don't know what I did that made it work.
but even with code command its just opening the black window and not doing anything.

@bpasero Tried full download, didn't help.

@bpasero Ok, here's a weird discovery: I just undocked my laptop and moved to a wifi network (had previously wired ethernet via a Thunderbolt Display), and now Code started up properly.

@syllogismos what tool are you using to unzip VS Code? Another thing you could try is to run from the command line "code --user-data-dir <some empty folder>" to see if that brings it up?
@EreMaijala that is good news, at least it points to some direction. Just to confirm: you can start VS Code if you are offline or connected via WLAN but not when connected via LAN?

I'm using Archive Utility.app in osx, I'm so confused, I was able to open it using code and code --user-data-dir command. but that works sometimes and doesntwork other times. So confused.
here is a video i recorded https://www.youtube.com/watch?v=8sQSvVQ3bcQ

@bpasero I had to restart my system and now 1.11.1 starts up fine regardless of the network I'm connected to or whether connected at all.  So it seems I can't reproduce the issue anymore.

I can't yet restart the system.. I am running some day long script.. Will do that and report. normally I restart the system before looking for a solution, but I can't currently. thinking back, I shouldn't have updated vscode at all..

ping @joaomoreno

@syllogismos Your issue is #7426. Workaround is here. Fix comes this month.

Let's merge into https://github.com/Microsoft/vscode/issues/23639 we have a fix ready.

I'm still seeing the black screen, its the same after this command, also the folder ~/Library/Caches/com.microsoft.VSCode.ShipIt/ is empty in my computer, so I had to remove the * from the original work around for the command to succeed.
sudo chown $USER ~/Library/Caches/com.microsoft.VSCode.ShipIt/
xattr -dr com.apple.quarantine /Applications/Visual\ Studio\ Code.app

I use App Cleaner tool to uninstall software, maybe it deleted the files in that caches folder. but it still doesnt work.

launching the app directly never works, typing code on command line works sometimes,
when ever it works, code --verbose looks like this
$ code --verbose
[main 20:43:32] Starting VS Code in verbose mode
[main 20:43:32] from: /Applications/Visual Studio Code.app/Contents/Resources/app
[main 20:43:32] args: { _: [],
  help: false,
  h: false,
  version: false,
  v: false,
  wait: false,
  w: false,
  diff: false,
  d: false,
  goto: false,
  g: false,
  'new-window': false,
  n: false,
  'unity-launch': false,
  'reuse-window': false,
  r: false,
  performance: false,
  p: false,
  'prof-startup': false,
  verbose: true,
  logExtensionHostCommunication: false,
  'disable-extensions': false,
  disableExtensions: false,
  'list-extensions': false,
  'show-versions': false,
  nolazy: false }
[main 20:43:33] IPC#vscode-machineId
[main 20:43:33] IPC#vscode-workbenchLoaded

and when it shows blank screen it shows this
$ code --verbose
[main 20:42:56] Sending env to running instance...
[main 20:42:56] Sent env to running instance. Terminating...
$ code --verbose
[main 20:43:16] Sending env to running instance...
[main 20:43:16] Sent env to running instance. Terminating...

Ok, restarted my comp and its still throwing up blank black screen when launching from dock, but I am able to start from command line consistently, after these two commands
sudo chown $USER ~/Library/Caches/com.microsoft.VSCode.ShipIt/
xattr -dr com.apple.quarantine /Applications/Visual\ Studio\ Code.app

after trying insiders build from here https://github.com/Microsoft/vscode/issues/24360#issuecomment-292862208 I am able to start it from dock, but I would like this update in the stable one soon.


Possible rounding problem in sum line?

Hi Folks,
we created a zugferd invoice with profile "Xrechnung". It seems that that the total amount gross is not calculated correctly.

We had a integration test for this. running against an older version of mustang this was fine. Since update zu 2.1.1 our test is red.
Any ideas?
Thanks,
Norbert

assuming you're on 19% VAT 58,72*1,19 seems to amount to 69,8768 which IMO would be rounded to 69,88 Eur?

The net amount is shown to the customer on the invoice with only 2 decimal places, sorry for the confusion.
 Then the Gross total sum is calculated. In the last step this total gross amound is rounded for 2 decimal places.

sums and AFAIK also the tax base amount are two digits
(Factur-X Specification 1.0.50, chap 7.1.5) and I believe something similar is mentioned in  EN16931-1 Chap. 6.5.12 (https://www.beuth.de/en/standard/din-en-16931-1/314992770), in which case IMO the 69,88 would be correct?

ok you are right. rounding on position sum line has only 2 digits. This is a major difference to older mustang lib versions. I will close this issue. Thx


granular control

When activating the plugin for a user, this user gets too much control. This user can delete a super admin, which is not wanted behavior.

Do you have any idea how we could overcome this?
Any good system that we could implement to handle such cases.
I was thinking about giving a 'power' or 'level' or call it whatever to each group. And a user can only edit users with lower power. It's a naive solution but better than nothing.
We need to come up a good system which can handle most of the use cases. If you have any idea then share it here please.

I had a similar problem, and I've just added a new issue.
The problem is that using this user manager plugin, new users are not given site login access. That means that only users (created by this plugin) who have supervisor login access can actually login. I agree with the initial poster that it is undesirable to give all users supervisor login access.
The work-around is to use expert mode for the user and to add the following lines to the section access:
access: # this line already is in the user file
  site:
    login: 'true'

Agreed. This plugin is pointless for administrators wishing to give users some control of managing content of a website without allowing them to either:

Assign themselves new permissions above the level they already have or 2. delete/modify users with permissions above their level (i.e. ACTUAL admins who would be kicked out of the system by a subordinate user).

There needs to be a check in place that looks to see if a user has permission to overwrite admin level permissions.

@adamschmid Yes, it's not the purpose plugin anyway. And maybe that's not even possible without modifying Grav core.

So any news on declining users, who have access to the user mananger, to delete or edit the super admin?

@david-szabo97 Would you consider making this plug-in more useful to administrators wishing to grant certain access levels to other Grav admin users for updating content, etc? Use case is something along the lines of how Wordpress handles users. There really isn't anything else from what I've seen that comes close to managing users in Grav. The plugin description itself then seems misleading if the purpose isn't to control a user's access.

"A simple admin panel extension which adds the option to manage users and groups."

All this does is allow a user access to the admin section where they, themselves would technically be an admin despite assigning a specific group of roles/functions can easily be overridden by said user. Was this your intention?

@adamschmid We are kinda limited by how Grav Admin and Grav Core works. The purpose of this plugin is to edit your users and groups file via interface.

@david-szabo97 Except that there seems to be a bug, forcing us to give superadmin rights, as I mention it here : https://github.com/david-szabo97/grav-plugin-admin-addon-user-manager/issues/56

Grav v1.7.0 has a built-in interface for managing users and groups. 🎉 I'm discontinuing the plugin. Thanks for using my plugin for the time being! 🙇


Simplify BCM/DataAnalysis.ipynb

Hello,
I did some unrequested changes to the DataAnalysis notebook:

Simplified model5, using Potential + Binomial distribution to compute CDF for truncated observations.
Simplified model7, using DensityDist + HyperGeometric logp, and commented out the implementation of the zeros-trick with Poisson.

- Increased target-accept in model1 and model2 to avoid divergences.
Let me know if you think the notebook is more useful with these changes or whether it should remain as it was.
Calling out @junpenglao and @AlexAndorra who worked on the notebook before.
Best,
Ricardo

LGTM, thanks!


PasswordBox reveal button disappears

Which version of the app?
WinUI 3 Gallery
Description
When I type some password in PasswordBox of "WinUI 3 Gallery app", it shows a button for showing the password and it works perfectly. But when I go to another control and get back to PasswordBox it doesn't show the reveal button again.
Screenshots

Windows version
Windows 11 21H2 (22000)
Additional context
No response

This is not a bug with the WinUI Gallery or the PasswordBox control but rather by design. See https://github.com/microsoft/microsoft-ui-xaml/issues/1224 for more context.


feat: ADR-006 implementation

Implements ADR-006. Based on previously-closed #1567 and uses newer features from #1648
This PR has its own, newer version of the ADR, that completely matches the implementation. Adds reconnect function and uses client.service to create PromiseClient.
To check the implementation, do this:

Check out the branch of this PR
Use https://github.com/prax-wallet/web/pull/134 PR in Prax while using this PR's packages
Use https://github.com/penumbra-zone/nextjs-penumbra-client-example/pull/5 PR in NextJS example to see how this ADR affects real apps

if some of these changes were intended to address state management concerns discussed in DM, i don't think they achieve that objective

closed in favor of #1648


Cache the 'users' state

Fixes #2591
This is a very simple and effective solution to the issue.
Alternatives were examined and found to be both complex and
have drawbacks. Waiting asynchronously for the users to load
would require a lot of rework and would lengthen the action to
potentially several seconds on mobile network.
Initially we were preserving most of the store keys but then went
for a more lean approach.
The app handles correctly the cases when users might not have yet
loaded on startup. An exception is narrowing to a group narrow.
When pressing a group notifications we get only the users' IDs and
need to map these IDs to users' emails so we can perform the narrow.
A future improvement to the narrowing functionality where we will
narrow by IDs will remove this dependency for us.

Seems like a fine change. I have a few questions that this brings up:

Why is there a storeKeys and a cacheKeys -- is there a distinction between which keys go in which one? It looks like they just get concatenated together, to become the list of properties of the root store which get persisted.
At this point are we gaining anything by trying to be selective in which parts of the store we persist? We have messages and now users, and those seem like the bulkiest items.

In particular, why keep messages but drop flags and caughtUp? Those three seem very tightly related -- so that if for some messages or narrows we have the information in messages but not in flags or caughtUp, that sounds likely to be a source of bugs.

Just merged this, with some rewriting of the commit message -- thanks again!
I am still curious about my questions above. :-)


URL pipeline catalog doesn't reflect updates on remote side

Describe the issue
URL pipeline catalog doesn't reflect updates on remote side
To Reproduce
Steps to reproduce the behavior:

provide url with kfp pipeline yaml
create url catalog using elyra ui
use component (e.g. submit to kfp)
change kfp pipeline yaml (contents of url)
changes are ignored

Workaround: Delete url component catalog and recreate
Expected behavior
Changes are reflected (e.g. new kfp yaml submitted to kfp)
Deployment information
Describe what you've deployed and how:

Elyra version: v3.11.1
Operating system:linux
Installation source: pypi
Deployment type: local

Pipeline runtime environment

Kubeflow Pipelines build version dev_local DEX_STATIC_PASSWORDS

Runtime configuration settings

I thought there was a way to force a catalog refresh - do you see such an option available within the context of the catalogs?

You are right, there is:

reload all catalog entries
reload a single catalog entry

Depending on the catalog type it might take a little bit for the changes to be reflected in the pipeline editor.

I'm guessing that you saw the functionality if you are using version version 3.7 or above, but am not completely sure whether the issue you are reporting is that the outdated component definition is rendered when you view/use if the the pipeline editor. In case it is, I created https://github.com/elyra-ai/elyra/pull/2997 to document the feature and included important disclaimers that explain why the pipeline editor might not render what you expect.
We do have an open requirement to expose the catalog load status that should remove some of the current uncertainty.

please ignore - problem sat in front of the keyboard - thanks for your help and sorry for wasting your time @ptitzler et. al.


Mac default converge fails since notify is not included by homebrew

I was trying to use java 1.41.0 in Test Kitchen using a MacOS VM and got an error from homebrew when installing the default java recipe.  It could not notify log[jdk-version-changed] because it could not find that resource.  Debugging showed that notify.rb is not included by default.rb or homebrew.rb.
Unfortunately there are no public Mac OS X boxcutter images, so I can't update the tests to validate this change, but I did confirm it fixed the problem in my personal Mac OS test kitchen environment.

Thanks, I actually had this change locally and forgot to push it up! Will release on Friday with the java update.


Adding godot to the rtfm command

adding the godot docs to the rtfm command would be nice https://docs.godotengine.org/en/stable

adding the godot docs to the rtfm command would be nice https://docs.godotengine.org/en/stable

dis bot is dead asf


Run-time error '91': Object variable or With block variable not set

Hi, We have recently downloaded and installed XLRISK. However, when we try to set up or configure, we get the subject error, please see screenshot below.

When I click on debug we get the following VBA code which I am not sure what to change from:

Will be grateful for your guidance.
Many thanks.

Which Excel version are you using?

Duplicate of https://github.com/pyscripter/XLRisk/issues/14

MS365

I closed Excel and restarted it so this worked as I can XLRisk Options Dialog. Thanks, I will go through the documentation and will reach out if I have other issues.


IMPROVE - Empty DashboardView

Describe the feature you want to improve

DashboardView has this text when the view is empty (meaning a user hasn't added their vehicle yet)
Add a button below this text that says "AddVehicle" and show the AddVehicleView as a sheet

if viewModel.events.isEmpty {
Text("Add your first maintenance", comment: "Placeholder text for empty maintenance list prompting the user to add a maintenance event")
   // ...
}

[!NOTE]
Leave the closure for AddVehicleView nil because this will be something that is going to be in a different PR (the actual functionality to add a vehicle is in the SettingsViewModel, and not accessible here), and I want that refactor in a different PR

Describe alternatives you've considered

N/A

This looks like a fun one :)


Attempts to sort by column that do not exist after join

What happened?
Sorry the example is not small enough, but the following example seems to fail to execute the query because it tries to sort using column a._expr_0, which does not actually exist.
PRQL input
from a
join side:left b (==col)
sort a.col
select !{a.col}
take 5

SQL output
WITH table_0 AS (
  SELECT
    a.*,
    b.*,
    a.col AS _expr_0
  FROM
    a
    LEFT JOIN b ON a.col = b.col
  ORDER BY
    a._expr_0
  LIMIT
    5
)
SELECT
  *
FROM
  table_0
ORDER BY
  _expr_0

-- Generated by PRQL compiler version:0.9.2 (https://prql-lang.org)

Expected SQL output
WITH table_0 AS (
  SELECT
    a.*,
    b.*,
    a.col AS _expr_0
  FROM
    a
    LEFT JOIN b ON a.col = b.col
  ORDER BY
    a.col
  LIMIT
    5
)
SELECT
  *
FROM
  table_0
ORDER BY
  _expr_0

-- Generated by PRQL compiler version:0.9.2 (https://prql-lang.org/)

MVCE confirmation

[X] Minimal example
[X] New issue

Anything else?
No response

Nice catch, the example is small enough!

+1 I just ran into this myself
It seems the issue is with the ordering guarantee characteristic of sort:

PRQL pushes the sort down the pipeline, compiling the ORDER BY to the end of the query.

What's more, I would've thought wrapping it in a variable would work but unfortunately no.
Here's another example runnable in the playground:
let a = (
  from invoices
  sort {-invoice_date}
)
let b = (
  from a
  select {customer_id}
)
from b

WITH a AS (
  SELECT
    *
  FROM
    invoices
),
b AS (
  SELECT
    customer_id
  FROM
    a
)
SELECT
  customer_id
FROM
  b
ORDER BY
  invoice_date DESC

-- Generated by PRQL compiler version:0.9.4 (https://prql-lang.org)

A smaller example, if it helps:
let x = (
  from table
  sort index
  select {fieldA}
)
from x

WITH table_0 AS (
  SELECT
    "fieldA",
    "index"
  FROM
    "table"
),
x AS (
  SELECT
    "fieldA"
  FROM
    table_0
)
SELECT
  "fieldA"
FROM
  x
ORDER BY
  "index"

-- Generated by PRQL compiler version:0.10.0 (https://prql-lang.org)

I don't know when, but this seems to be happening again.

I've just verified it works in the playground:
let x = (
  from artists
  sort artist_id
  select {name}
)
from x

WITH table_0 AS (
  SELECT
    name,
    artist_id
  FROM
    artists
),
x AS (
  SELECT
    name,
    artist_id
  FROM
    table_0
)
SELECT
  name
FROM
  x
ORDER BY
  artist_id

-- Generated by PRQL compiler version:0.11.1 (https://prql-lang.org)

Oh, I see, it's the naming. Damn, this ORDER-BY-pushdown feature is producing a lot of weird bugs. Maybe I should re-think it from the beginning.


[cherry-pick][branch-2.1] cherry-pick Support more lowcardinality optimization (#3988)

Fix #5395

run starrocks_fe_unittest


Make more HTTP/2 settings configurable and make them consistent

Made sure both client and server have the following HTTP/2 settings

Connection-level initial window size
Stream-level initial window size
Max frame size
Max header list size

Reordered the fields and methods related with HTTP settings so that
HTTP/2 settings come right before HTTP/1 settings.
(breaking) Made the protocol-related property names consistent so that
they all start with protocol name first, e.g.

maxHttp1ChunkSize -> http1MaxChunkSize
initialHttp2ConnectionWindowSize -> http2InitialConnectionWindowSize

Renamed ServerBuilder.http2InitialWindowSize to http2InitialStreamWindowSize
Added ServerBuilder.http2InitialConnectionWindowSize and implemented
connection-level initial window size update in HttpServerHandler.
Improve/fix validation of HTTP/2-related properties
Change the type of http2MaxStreamsPerConnection and http2MaxHeaderListSize
to long because its maximum value is 0xFFFFFFFFL
(breaking) Removed default prefix for HTTP/1-related properties because
they should've not been named so from the beginning.
Miscellaneous:

Fixed a race between Http2RequestDecoder and HttpServerHandler
trying to write an error response, causing HTTP/2 violation.

Reproduced by HttpServerTest.testTooLargeContentToNonExistentService()
which makes Http2RequestDecoder and HttpServerHandler send
413 Entity Too Large and 404 Not Found.

@anuraaga :rofl: No worries! It was interesting to know sending 0xFFFFFFFF MAX_CONCURRENT_STREAM breaks OKHTTP by the way.

Thanks for reviewing.


feat(Menu/Select): add onHighlightedItemChanged handler

Fixes #994
Description
Work in progress.
Scope

[ ] Patch: Bug Fix
[X] Minor: New Feature
[ ] Major: Breaking Change

Hi @chasestarr ! This is my first attempt to solve it.

It prints the array index of the highlighted item whenever it changes, for both arrow keys and mouse hover events;
Right now it always prints the index, regardless of whether the item is disabled or not;
In the initial state no item is highlighted, so it does not print anything;
I tried other things such as making getBackgroundColor function on styled-components.js call a helper fuction or using callbacks inside this.internalSetState on stateful-container,js, but none worked quite right;

Let me know your thoughts about it, thanks!

Hi @IgorWilbert, thanks! Check out some features of base that may be helpful demonstrated here: https://codesandbox.io/s/w6o67nqr2l
In particular, stateful components have a stateReducer prop that is called on each internal state change. The use-case described in #994 is possible when only using the Menu component, but we have no way to pass props through the Select component to the dropdown menu. This may be a good reference for how to 'override' internal components: https://github.com/uber-web/baseui/blob/master/src/datepicker/datepicker.js#L141

The interface I'd like to see is something like the example below. This does not require importing anything from the StatefulMenu component, but rather providing additional props to the internal menu.
<Select
  overrides={{StatefulMenu: {props: {stateReducer: reducerFn}}}
/>

No need to add a StyledStatefulMenu, but rather create a override where the default the call looks like
const [OverriddenStatefulMenu, statefulMenuProps] = getOverrides(overrides.StatefulMenu,StatefulMenu);

// ...

<OverriddenStatefulMenu
  // ...already existing props
  {...statefulMenuProps}
/>

Haven't tested if the code provided here is correct, but should be a decent starting point

Hi @chasestarr ! I guess the code I pushed is working, but I'm not sure how to test it. In the following codepen:
https://codesandbox.io/s/238xqp5mmp
The basic.js gives a Select in which changeType select is printed on click in an item, but it does not respond to hover or arrows. The one in controlledExample.js on the other hand, gives the error reducerFn is not defined. I think I am missing something quite obvious. Any idea of what it might be? Thanks!

codesandbox can only reference published versions of the baseui package. so your changes are not reflected there. I would edit a scenario file and yarn storybook to double check.

Hi @chasestarr ! I know, I only used codesandbox to show you the code I was writting without committing it. Now I managed to create an example in a scenario file that responds to both mouse hover and arrow keys. I also created an example in the documentation site that seems to work as it should. Let me know if you want me to change something else. Thanks!

looks like linting fails. can you run yarn test locally?

Hi @chasestarr ! I ran yarn test and this was the result:

Unfortunately, I didn't have time to investigate and try to fix it, I'll do so as soon as I get home. It would be helpful if you had time to give me some hints. Thanks!

most of those errors are from prettier. follow the instructions on that site to align with the style guide.
also ensure that the uber header comment (found at the top of other files) is included as well as a // @flow comment.
You may need to use eslint-disable to suppress the no/console error

Hi @chasestarr ! I did what you suggested and now all tests passed. Thank you!


Performance regarding marker count

Hello,
How many markers do you think one can put into map considering performance issues? The app just hangs or crashes when I put around thousand markers, is it too much? Or am I doing something wrong (I've custom kind of big pngs for icons, but also tried without them).
Now I'm going the way of calculating visible markers on camera change, but would like to know if this could be handled by a simple performance switch. It would be a valuable addition to specify this somewhere, at least the magnitude of it.
Thanks!

Thank you for the fast response!


Fix typo in test/resampling.jl

Codecov Report

Merging #594 (91ca641) into dev (8de6c5a) will decrease coverage by 0.13%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##              dev     #594      +/-   ##
==========================================
- Coverage   85.16%   85.03%   -0.14%
==========================================
  Files          37       37
  Lines        3188     3180       -8
==========================================
- Hits         2715     2704      -11
- Misses        473      476       +3

Impacted Files
Coverage Δ

src/measures/continuous.jl
97.70% <0.00%> (-2.30%)
:arrow_down:

src/measures/loss_functions_interface.jl
70.83% <0.00%> (-2.09%)
:arrow_down:

src/measures/finite.jl
96.30% <0.00%> (-0.30%)
:arrow_down:

src/utilities.jl
78.21% <0.00%> (-0.22%)
:arrow_down:

src/composition/learning_networks/nodes.jl
69.93% <0.00%> (-0.21%)
:arrow_down:

src/univariate_finite/methods.jl
86.25% <0.00%> (-0.11%)
:arrow_down:

src/data/datasets_synthetic.jl
95.37% <0.00%> (-0.05%)
:arrow_down:

src/univariate_finite/types.jl
91.50% <0.00%> (+0.85%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8de6c5a...91ca641. Read the comment docs.


Show full names on the cards

Show Full or partial names for the links on the cards, instead of Watch, Open, Learn, Tips, and Clone

How will you do that? @mastrero

For example,
instead of Open in Websites cards, lets display website links directly.
making it more user-friendly

I'll open a new PR on this issue.


Is supported ContextMenu templates?

Hello.
Is possible to assign a ContextMenu template to a different tree view item?
Thanks.

Can you please explain what you are trying to do?

For example, in the MultiSelectTreeView demo, can you have different context menus for the objects ColorItemViewModel and TreeItemViewModel using a template?

Hm, I use a single context menu and show/hide or enable/disable the menu items based on the tree items selection. This also allows you to react on multiple selected items of different types, if that's allowed. Would that be a solution for you?

I think that is a better solution. Thank you very much.


Custom keys on ProgressStyle do not work together with enable_steady_tick

It seems as though there are the following two interactions in indicatif 0.17.2, which were not present in 0.17.0-rc4:

If set_style is used before enable_steady_tick, the steady tick takes effect, but any custom keys that are set on the ProgressStyle using its with_key method are never updated.
If set_style is used after enable_steady_tick, then the custom keys work but the steady tick is disabled.

Hmm, I find both of these behaviors quite surprising. Would you be able to run a git bisect to find which commit between -rc.4 and .2 regressed this?

It appears that 516c0dcea6eeb51407d8cf03fdcd96bf6f849220 is the commit that introduced the breakage.

Expected behavior:

Buggy behavior:

Pff, honestly not sure what's going on here. Would you be able to dig in a bit more, since you've already built up some context? Happy to answer further questions about how stuff is supposed to work.

It seems I've narrowed it down further and it's related to ProgressState::per_sec not updating when steady tick is enabled. If I use the code from https://github.com/console-rs/indicatif/issues/394#issuecomment-1309971049 and build a per_sec or eta equivalent using .pos(), .len(), and .elapsed(), it works properly with steady tick.

Thanks, it works for me as well. Turns out the issue only affected my custom keys because my custom keys depended on per_sec and eta.


Support mhtml

Supporting mhtml would be really nice. That'd mean this extension could be used to preview .mhtml and .eml (email) files.

Bump

Agreed. The usefulness of mhtml is growing in importance, especially as html documents are becoming more common. The ability of VScode to edit html is invaluable, and should be extended to mhtml as well.

It's 2024 and still nothing...


Update the npm package to the latest release

Hi,
Thanks for this package.
I'm currently installing it by npm, and the version no. in npm is 1.2.3, and the latest here is 1.2.7. Could you update the npm package or it is better to clone it?
Thanks

Hi @luisfontes! The npm package is up-to-date now :)


chore: bdd-spring-1580985858 to 0.0.1

chore: Promote bdd-spring-1580985858 to version 0.0.1

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approvers:
If they are not already assigned, you can assign the PR to them by writing /assign  in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


#115 Added the rest of the props to the td element

Added the rest of the props to the <td>element and to the distribution and created a snapshot test for it

Pull Request Test Coverage Report for Build 569

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build 549:
0.0%

Covered Lines:
33

Relevant Lines:
33

💛  - Coveralls

Hello, can someone look at this pull request?

Hello,
@coston can you please look over this pull request or get some other contributor to look over it please!


Playbook fails due to run with Ansible 2.10

Ansible version: 2.10
OS: Ubuntu 20.04
Ansible role using Galaxy
Playbook:
---
- hosts: all
  become: true
  roles:
    - role: googlecloudplatform.google_cloud_ops_agents
      vars:
        agent_type: ops-agent

Error:
ERROR! couldn't resolve module/action 'win_shell'. This often indicates a misspelling, missing collection, or incorrect module path.
The error appears to be in '/root/.ansible/roles/googlecloudplatform.google_cloud_ops_agents/handlers/main.yml': line 8, column 3, but may
be elsewhere in the file depending on the exact syntax problem.
The offending line appears to be:
- name: "restart windows {{ agent_type }} agent"
  ^ here
We could be wrong, but this one looks like it might be an issue with
missing quotes. Always quote template expression brackets when they
start a value. For instance:
    with_items:
      - {{ foo }}
Should be written as:
    with_items:
      - "{{ foo }}"

I just ran into this - seems like there should be a check to see if the target is even running Windows, as I'm also targeting Ubuntu, but anyways...looks like the windows collection needs to be installed first via ansible-galaxy collection install ansible.windows and then the issue should go away!
I think the proper solution would be for this collection to add the windows collection as a dependency.


License

First, I would like to commend you on your excellent research on dynamic signed graphs.
I am interested in utilizing your code for my work. Could you please clarify the licensing terms for this repository?

Thank you for your interest in my research and code.
I have applied the MIT license to my code and have uploaded the license file for your reference.
Please feel free to reach out if you have any further questions or need additional information.


Release 📦

📦 Release Pull Request
📝 Release Notes

Attempt at fixing pipeline so that release is carried successfully by first building the application and then running semantic release.
🚧 Pre-Release Checklist

[x]  ~All tests passed successfully.~
[x]  Code follows coding standards.
[x]  Documentation is up-to-date.
[x]  Dependencies are correctly updated.
[ ]  ~Continuous Integration (CI) pipelines passed.~

:tada: This PR is included in version 1.1.0 :tada:
The release is available on:

v1.1.0
GitHub release

Your semantic-release bot :package::rocket:


PlotlyBase.PlotConfig(scrollZoom=true) does not work as expected

Description: The scrolling action should result in zooming into the plot but it scrolls the page instead, independently of the pointer location.
Small example to reproduce the issue:
using Stipple, StipplePlotly
using PlotlyBase

@reactive! mutable struct Example <: ReactiveModel
    plot::R{Plot} = Plot(config = PlotlyBase.PlotConfig(scrollZoom=true, displaylogo=false))
end

function ui(model::Example)
    page(model, class = "container", [
        plot("plot.data", layout = "plot.layout", config = "plot.config")
    ])
end

model = init(Example, debounce=0)
route("/") do
    model |> ui |> html
end

up(8800)

Minimal example to see what would be expected:
using PlotlyBase
Plot(config = PlotlyBase.PlotConfig(scrollZoom=true, displaylogo=false))

Note: displaylogo is just there to show that the config is working correctly.

There is plotly(:plot) which will probably do what you want.
Have a look at its output
julia> plotly(:plot)
"<plotly :data=\"plot.data\" :layout=\"plot.layout\" :scrollZoom=\"plot.config.scrollZoom || ''\" :editable=\"plot.config.editable || ''\" :staticPlot=\"plot.config.staticPlot || ''\" :toImageButtonOptions=\"plot.config.toImageButtonOptions || ''\" :displayModeBar=\"plot.config.displayModeBar || ''\" :modeBarButtonsToRemove=\"plot.config.modeBarButtonsToRemove || ''\" :modeBarButtonsToAdd=\"plot.config.modeBarButtonsToAdd || ''\" :modeBarButtons=\"plot.config.modeBarButtons || ''\" :showLink=\"plot.config.showLink || ''\" :plotlyServerURL=\"plot.config.plotlyServerURL || ''\" :linkText=\"plot.config.linkText || ''\" :showEditInChartStudio=\"plot.config.showEditInChartStudio || ''\" :locale=\"plot.config.locale || ''\" :displaylogo=\"plot.config.displaylogo || ''\" :responsive=\"plot.config.responsive || ''\" :doubleClickDelay=\"plot.config.doubleClickDelay || ''\"></plotly>"

The reason is that plot() by default takes the fields of the StipplePlotly.PlotConfig, while configtype of plotly() defaults to PlotlyBase.PlotConfig as soon as PlotlyBase is loaded. Before loading of PlotlyBase it generates fields for a StipplePlotly.PlotConfig.
That having said, I found that rendering StipplePlotly.PlotConfig is more difficult than I initially thought (camelcasing plus serialisation of toImageButtonOptions).
I pushed some changes to the main branch, that solve the issue.
@garibarba would you be so kind to test it?

Hey @hhaensel thanks!
I've tried this (note: watchplots() without arguments was critical to avoid errors):
using Stipple, StipplePlotly
using PlotlyBase

@reactive! mutable struct Example <: ReactiveModel
    plot::R{Plot} = Plot(config = PlotlyBase.PlotConfig(scrollZoom=true, displaylogo=false))
    plot_selected::R{Dict{String, Any}} = Dict{String, Any}()
    plot_hover::R{Dict{String, Any}} = Dict{String, Any}()
end

Stipple.js_mounted(::Example) = watchplots()

function ui(model::Example)
    page(model, class = "container", [
        plotly(:plot, syncevents = true)
    ])
end

model = init(Example, debounce=0)
route("/") do
    model |> handlers |> ui |> html
end
function handlers(model)
    on(model.isready) do isready
        isready || return
        push!(model)
    end

    on(model.plot_selected) do data
        haskey(data, "points") && @info "Selection: $(getindex.(data["points"], "pointIndex"))"
    end

    return model
end

up(8800)

model.plot[] = Plot(scatter(y = rand(5)), config = PlotlyBase.PlotConfig(scrollZoom=true, displaylogo=false))

Works as expected when selecting points, but the zoom when scrolling is still not working 🤔

I think I fixed this. Could you please try the latest main branch?
]add StipplePlotly#main

It does work indeed. Thanks for the great work!


Allow the Oculus retargeting to start also without joypads

Since we have two similar configuration parameters (i.e., skip_joypad and move_icub_using_joypad), for the sake of completeness and future reference let's describe them here:
The joypad is used for the following two set of functionalities:

To continuously move the robot, or provide references to the robot:

The reference to the walking controller for the robot base motion (when we are not using virtualizer)
The reference velocities to the robot finger velocities (when not using SenseGlove)

To change the walking-teleoperation state machine and prepare and start the teleoperation

For these functionalities, we have the following relevant configuration parameters:

move_icub_using_joypad --> to Not use Virtualizer
useSenseGlove --> to user SenseGlove
and now:
skip_joypad --> To totally avoid using joypad for any functionality.

So, if we are using both the Virtualizer and SenseGlove, we can skip the joypad (since we can use also rpc command to change the state machine https://github.com/robotology/walking-teleoperation/pull/70). Otherwise (if for one of those two functionalities, we are not using SenseGlove or Virtualizer), we cannot skip jpypad.
@S-Dafarra  Maybe at this point instead of move_icub_using_joypad, we can change it to useVirtualizer? But for this, we have to update all the laptop files, and the all the configuration files.

@S-Dafarra Maybe at this point instead of move_icub_using_joypad, we can change it to useVirtualizer? But for this, we have to update all the laptop files, and the all the configuration files.

This makes sense, but I think it is outside the scope of this PR.

I've rebased the branch after #73 , merging.


Integration of "Add Click" Button & Email Notification

Integrated the email notification functionality with the "Add" button in the home page


Guys I'm facing memory leak problem. How to fix it?

System:
CPU:

RAM:

OS:

My Code:

report:

I've googled 'bout it but google clearly have no useful feedback so I go back to GitHub.

I think you need to add this to your code


Typo in wiki page "Video Conference Mute Overview (Experimental)"

There's a small typo in the wiki page Video Conference Mute Overview (Experimental).
The 2nd sentence of the 3rd paragraph reads
You can do audio, video both.
That should probably be changed to
You can do audio, video or both.

@Patrekees
fixed, thank you.


Details here http://stackoverflow.com/questions/39953594/picturefull-lazysizes-unable-to-get-property-push-in-ie
Will try to work on a PR.

This bug is not a picturefill bug. It is provoked by bad markup:
The source elements have a lazyload/lazypreload class which shouldn't be added and the img has the following class:
<img class="picturefill__image class="lazyload lazypreload" />

I still noticed the same issue using valid markup. Will provide a test case when I have time.

Please provide a test case.


In promoting jianpu-ly

Hi @ssb22,
I had been thinking of different ways I can help promoting the wider-adoption of jianpu-ly, and here are my two thoughts:

Grant me access to the wiki, so that I can put many of my closed questions there, as they would be common for any jianpu-ly starters.

I've also collected all possible jianpu-ly based music files I could find on the internet into a github repo, would you think if it is a good idea that we move both your jianpu-ly software and my jianpu-ly based music file collection under a single github organization, so that it'll make jianpu-ly newcomers to get easier start? (If so, please accept the github organization invitation as I've done some legworks for you)

Thanks.  I'm not 100% sure how GitHub organisations & wikis work, but we can look at it.  Moving a project worries me: does it mean the URL will change, and will everybody who's already git cloned from the old URL still be able to git pull?  If not, a move could be disruptive and I wonder if the organisation could just link back to the original repo instead....

Moving a project does change its url (and git clone/pull url too), however, if you don't create another repo with the same name, then people who's already git cloned from the old URL can still be able to git pull, as GH will do the redirect automatically. You can try creating a small test repo under github.com/ssb22 then moved it to under jianpu-ly, then try doing the git pull and git push.
If you feel comfortable about it, then we can talk about moving the main repo over, just that its url does get changed. Give it a try and then we can decide...
BTW, the wiki is working for me, and I've already put into one TIP note.
thanks

Testing with https://github.com/jianpu-ly/jianpu-test - see readme there - old URLs work, but old list of "my repositories" no longer lists it, which could be a minor hassle.  If I can fix git2gmi then I might at least be able to use that.  Or maybe I'm just navigating GitHub wrongly....

Yep, I checked the items you put in https://github.com/jianpu-ly/jianpu-test, and apparently the impact is more than I anticipated.
So let's park this idea for now until another person would like to contribute into jianpu-ly collection, so that we can "group multiple repositories under the project" by then.

So let's park this idea for now until ...

Ah, I now have a perfect solution -- mirror, instead of move!
I know you have a few more git repos than this, and when you push, you push them altogether. So,

Fork this repo into/under jianpu-ly
Add the forked repo under jianpu-ly to your pushed remotes
Make a small change, like doc KeepOctave & KeepLength commands in readme, then push, and make sure the forked repo under jianpu-ly is pushed as well.

If AOK, add me as the admin to the forked repo under jianpu-ly, I'll co-maintain it with you.

This could work, although apparently it's difficult to sync issues and pull requests between forks—don’t know if that’s important.
There are a few mirrors already: when GitHub was taken over by Microsoft, I got nervous and set up mirrors of all my public repositories on other platforms “just in case”.  The nice thing about Git is you can do that—it’s just a matter of adding extra push URLs to my local copy of the repo, which I scripted—so we’re not tied to one platform.  (That's why I always write commit messages saying "#26 on GitHub" instead of just "#26".)  Only trouble is, the mirrors share the Git history but they don't share the issues history.

apparently it's difficult to sync issues and pull requests between forks

Yep, that's actually my next question -- we cannot keep both so we need to stick to one place for  issues and pull requests. If you want to keep them here then it is simple, I can turn off the issues and pull requests feature at the fork (and make a note in its wiki) so people will not be confused.

Any progress, blockage, or concerns?

Sorry I've not yet tried this.  I need to figure out how to fork my own repository.  I can create a new repository (not a fork) and push to both, but that would make the relationship less obvious.  It's not clear how to create a fork if I myself am the owner of the repo being forked; I'm not sure if GitHub even allows this.

Oh, sure, I didn't realized that this could be an issue. Glad that I can help.

Done.
I've turned off the issues and added a note not to do pull requests.
All set, and all your now.

Thanks.  OK seeing as there's a new commit I'm going to see what happens if I try to git push directly to the new fork....

... it doesn't work :-(
git remote set-url origin --push --add git@github.com:jianpu-ly/jianpu-ly.git
git push
...
ERROR: Permission to jianpu-ly/jianpu-ly.git denied to ssb22.

Maybe it doesn't automatically give me permission just because I'm in the same organisation, and you have to explicitly set it on every repository you create.

Aha, you're right. (I'm doing this for the first time as well)
Try again pls.

Thanks, it worked that time, and the GitHub Web interface correctly recognised it as the same commit and now says "This branch is up to date with ssb22/jianpu-ly:master" (not "1 commit ahead, 1 commit behind" as it would have said if it hadn't recognised it as the same commit).  Good.
Interestingly, when I did the git push --tags, it said all version tags right back to v1.145 (when I started doing version tags) were pushed to the fork.  That suggests creating a fork on GitHub does not by default copy the version tags, which is an oversight on their part.  Not to worry though if we're going to be pushing them anyway.

Bravo!!! Thanks!!!


python311Packages.google-cloud-vision: 3.5.0 -> 3.6.0, python311Packages.pandas-stubs: <IP_ADDRESS>814 -> <IP_ADDRESS>227

Changelog: https://github.com/googleapis/python-vision/blob/v3.6.0/CHANGELOG.md
Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Result of nixpkgs-review pr 285636 run on x86_64-linux 1

2 packages failed to build:

python311Packages.layoutparser
python311Packages.layoutparser.dist

2 packages built:

python311Packages.google-cloud-vision
python311Packages.google-cloud-vision.dist

Result of nixpkgs-review pr 285636 run on x86_64-linux 1

8 packages built:

python311Packages.google-cloud-vision
python311Packages.google-cloud-vision.dist
python311Packages.layoutparser
python311Packages.layoutparser.dist
python311Packages.pandas-stubs
python311Packages.pandas-stubs.dist
python311Packages.pdfplumber
python311Packages.pdfplumber.dist

Result of nixpkgs-review pr 285636 run on x86_64-darwin 1

8 packages built:

python311Packages.google-cloud-vision
python311Packages.google-cloud-vision.dist
python311Packages.layoutparser
python311Packages.layoutparser.dist
python311Packages.pandas-stubs
python311Packages.pandas-stubs.dist
python311Packages.pdfplumber
python311Packages.pdfplumber.dist

Result of nixpkgs-review pr 285636 run on aarch64-darwin 1

6 packages failed to build:

python311Packages.layoutparser
python311Packages.layoutparser.dist
python311Packages.pandas-stubs
python311Packages.pandas-stubs.dist
python311Packages.pdfplumber
python311Packages.pdfplumber.dist

2 packages built:

python311Packages.google-cloud-vision
python311Packages.google-cloud-vision.dist

Result of nixpkgs-review pr 285636 run on aarch64-linux 1

6 packages failed to build:

python311Packages.layoutparser
python311Packages.layoutparser.dist
python311Packages.pandas-stubs
python311Packages.pandas-stubs.dist
python311Packages.pdfplumber
python311Packages.pdfplumber.dist

2 packages built:

python311Packages.google-cloud-vision
python311Packages.google-cloud-vision.dist


Occasionally Error Domain=XCDYouTubeVideoErrorDomain Code=-1

XCDYoutubeKit somtimes return error with Error Domain=XCDYouTubeVideoErrorDomain Code=-1.

Can you let me know which version of the library you're using? As well as a video that exhibits this issue?

It occurs to random video. Here is the log.
2018-10-04 22:42:46.419258+0800 Xenon[6456:1445262] dnssd_clientstub read_all(17) DEFUNCT
2018-10-04 22:42:46.419567+0800 Xenon[6456:1445262] [BoringSSL] nw_protocol_boringssl_error(1584) [C129.1:2][0x10e6735d0] Lower protocol stack error: 53
2018-10-04 22:42:46.499472+0800 Xenon[6456:1445262] TIC TCP Conn Failed [133:0x2817b3a80]: 10:-72000 Err(-65563)
2018-10-04 22:42:46.505810+0800 Xenon[6456:1445262] TIC Read Status [129:0x281798300]: 1:53
2018-10-04 22:42:46.505911+0800 Xenon[6456:1445262] TIC Read Status [129:0x281798300]: 1:53
2018-10-04 22:42:46.519820+0800 Xenon[6456:1445805] Task .<1> HTTP load failed (error code: -1003 [10:-72000])
2018-10-04 22:42:46.605256+0800 Xenon[6456:1445830] Task .<1> finished with error - code: -1003

Looks more like a network issue. See NSURLErrorCannotFindHost. How is your project setup?

I think so, since i can only replicate this on very few times 😄