Suspicious Conditional Values

Summary
We should report conditions that evaluate to a constant true or false in conditional and while/until statements. Most likely, that's a typo. Additional ideas:

Use a constant evaluator for the condition expression.
Provide basic dataflow analysis to check if there are any read-only variables holding the constant value used in that condition.
Use the same logic to check repeat statements with 0 iterations.

Examples
const FALSE: Bool = false;
// Bad: Always false because of operator precedence
if ((param | value) & FALSE) { /* never executed */ } else {}

Use instead:
const FALSE: Bool = false;
// Fixed after the analyzer highlighted this.
if (param) {} else {}

Requires the latest version of the constant evaluator (perhaps implemented in #33)


Google Api Error: multiApkShadowedActiveApk: Version 4145 of this app can not be downloaded...

Our deploys were working fine for a long time and suddenly started failing with this error. I don't understand what's wrong, or how to fix.
fastlane supply --apk ./android/app/build/outputs/apk/app-release.apk --json_key ./creds_android/playstore_jsonkey.json --track beta --package_name com.stardust

+-------------------------+-------------------------------------------------+
|                         Summary for supply 2.41.0                         |
+-------------------------+-------------------------------------------------+
| apk                     | ./android/app/build/outputs/apk/app-release.apk |
| json_key                | ./creds_android/playstore_jsonkey.json          |
| track                   | beta                                            |
| package_name            | com.stardust                                    |
| rollout                 | 0.1                                             |
| skip_upload_apk         | false                                           |
| skip_upload_metadata    | false                                           |
| skip_upload_images      | false                                           |
| skip_upload_screenshots | false                                           |
| validate_only           | false                                           |
| check_superseded_tracks | false                                           |
+-------------------------+-------------------------------------------------+

[15:01:06]: Preparing apk at path './android/app/build/outputs/apk/app-release.apk' for upload...
[15:01:10]: Updating track 'beta'...
[15:01:10]: Uploading all changes to Google Play...
[15:01:13]: Sending crash report...
[15:01:13]: The stacktrace is sanitized so no personal information is sent.
[15:01:13]: To see what we are sending, look here: /Users/distiller/.fastlane/latest_crash.json
[15:01:13]: Learn more at https://github.com/fastlane/fastlane#crash-reporting
[15:01:13]: You can disable crash reporting by adding `opt_out_crash_reporting` at the top of your Fastfile

[!] Google Api Error: multiApkShadowedActiveApk: Version 4145 of this app can not be downloaded by any devices as they will all receive APKs with higher version codes.

fastlane supply --apk ./android/app/build/outputs/apk/app-release.apk --json_key ./creds_android/playstore_jsonkey.json --track beta --package_name com.stardust returned exit code 1

Action failed: fastlane supply --apk ./android/app/build/outputs/apk/app-release.apk --json_key ./creds_android/playstore_jsonkey.json --track beta --package_name com.stardust

Sorry, I thought the above was enough. Here it is:
distiller-build-59:~ distiller$ fastlane env
[15:19:06]: Generating fastlane environment output, this might take a few seconds...
🚫 fastlane environment 🚫

### Stack

| Key                 | Value                                           |
| ------------------- | ----------------------------------------------- |
| OS                  | 10.11.6                                         |
| Ruby                | 2.3.1                                           |
| Bundler?            | false                                           |
| Git                 | git version 2.10.2                              |
| Installation Source | /opt/rubies/ruby-2.3.1/bin/fastlane             |
| Host                | Mac OS X 10.11.6 (15G1108)                      |
| Ruby Lib Dir        | /opt/rubies/ruby-2.3.1/lib                      |
| OpenSSL Version     | OpenSSL 1.0.2j  26 Sep 2016                     |
| Is contained        | false                                           |
| Xcode Path          | /Applications/Xcode-8.2.app/Contents/Developer/ |
| Xcode Version       | 8.2.1                                           |

### System Locale

| Error                       |
| --------------------------- |
| No Locale with UTF8 found 🚫 |

### fastlane files:

**No Fastfile found**

**No Appfile found**

### fastlane gems

| Gem                 | Version | Update-Status       |
| ------------------- | ------- | ------------------- |
| credentials_manager | 0.16.2  | 🚫 Update availaible |
| spaceship           | 0.38.1  | 🚫 Update availaible |
| fastlane_core       | 0.57.1  | 🚫 Update availaible |
| deliver             | 1.16.0  | 🚫 Update availaible |
| snapshot            | 1.16.4  | 🚫 Update availaible |
| frameit             | 3.0.0   | 🚫 Update availaible |
| pem                 | 1.4.0   | 🚫 Update availaible |
| cert                | 1.4.4   | 🚫 Update availaible |
| sigh                | 1.11.2  | 🚫 Update availaible |
| produce             | 1.3.1   | 🚫 Update availaible |
| gym                 | 1.12.1  | 🚫 Update availaible |
| pilot               | 1.12.1  | 🚫 Update availaible |
| scan                | 0.14.2  | 🚫 Update availaible |
| supply              | 0.8.0   | 🚫 Update availaible |
| match               | 0.11.0  | 🚫 Update availaible |
| screengrab          | 0.5.6   | 🚫 Update availaible |
| fastlane            | 1.110.0 | 🚫 Update availaible |

### Loaded fastlane plugins:

**No plugins Loaded**

Loaded gems

| Gem                       | Version      |
| ------------------------- | ------------ |
| did_you_mean              | 1.0.2        |
| highline                  | 1.7.8        |
| commander                 | 4.4.0        |
| terminal-table            | 1.4.5        |
| json                      | 1.8.3        |
| faraday                   | 0.10.0       |
| faraday_middleware        | 0.10.1       |
| dotenv                    | 2.1.1        |
| net-ssh                   | 3.2.0        |
| net-sftp                  | 2.1.2        |
| security                  | 0.1.3        |
| krausefx-shenzhen         | 0.14.11      |
| slack-notifier            | 1.5.1        |
| CFPropertyList            | 2.3.4        |
| claide                    | 1.0.1        |
| colored                   | 1.2          |
| nanaimo                   | 0.2.2        |
| xcodeproj                 | 1.4.1        |
| rouge                     | 1.11.1       |
| xcpretty                  | 0.2.4        |
| terminal-notifier         | 1.7.1        |
| public_suffix             | 2.0.4        |
| addressable               | 2.5.0        |
| multipart-post            | 2.0.0        |
| credentials_manager       | 0.16.2       |
| multi_xml                 | 0.5.5        |
| unf_ext                   | <IP_ADDRESS>      |
| unf                       | 0.1.4        |
| domain_name               | 0.5.20161021 |
| http-cookie               | 1.0.3        |
| faraday-cookie_jar        | 0.0.6        |
| fastimage                 | 1.6.8        |
| xcode-install             | 2.0.9        |
| word_wrap                 | 1.0.0        |
| multi_json                | 1.12.1       |
| babosa                    | 1.0.2        |
| excon                     | 0.54.0       |
| rubyzip                   | 1.1.7        |
| gh_inspector              | 1.0.2        |
| fastlane_core             | 0.57.1       |
| bundler                   | 1.13.6       |
| mini_magick               | 4.5.1        |
| xcpretty-travis-formatter | 0.0.4        |
| uber                      | 0.0.15       |
| representable             | 2.3.0        |
| retriable                 | 2.1.0        |
| mime-types-data           | 3.2016.0521  |
| mime-types                | 3.1          |
| hurley                    | 0.2          |
| little-plugger            | 1.1.4        |
| logging                   | 2.1.0        |
| jwt                       | 1.5.6        |
| memoist                   | 0.15.0       |
| os                        | 0.9.6        |
| signet                    | 0.7.3        |
| googleauth                | 0.5.1        |
| httpclient                | <IP_ADDRESS>      |
| google-api-client         | 0.9.20       |
| i18n                      | 0.7.0        |
| thread_safe               | 0.3.5        |
| tzinfo                    | 1.2.2        |
| activesupport             | <IP_ADDRESS>      |
| io-console                | 0.4.6        |
| plist                     | 3.2.0        |

*generated on:* **2017-06-23**

[15:19:18]: Open https://github.com/fastlane/fastlane/issues/new to submit a new issue ✅

#######################################################################
# fastlane 2.41.0 is available. You are on 1.110.0.
# It is recommended to use the latest version.
# Please update using `sudo gem update fastlane`.
#######################################################################

2.41.0 snapshot support for Xcode 9
* [snapshot] Add support for Xcode 9 (#9559) via David Ohayon
* Add calculating of fastlane plugin scores and nice rendering on docs page (#9511) via Felix Krause
* Pilot: Allow '~' in ipa path (#9481) via Nick
* Pass app_identifier through to precheck (#9566) via Joshua Liebowitz
* support Xcode 9 new export options when using sigh (#9449) via igor-makarov

2.40.0 Introducing fastlane precheck
* New: _fastlane precheck_: Check your app's metadata before submitting to App Review
* Allow to skip updating of an app version under 'Prepare for submission' (#9469) via Victor Ronin
* Apk check superseded tracks (#9459) via Marcelo Oliveira
* Fixed issue where deliver would not print appropriate error messages after failing to upload metadata (#9515) via Colin McDonnell

2.39.2 Improvements
* [increment_build_number] Fix issue when incrementing versions and specifying a `xcodeproj` value (#9508) via Hawken Rives
* [supply] Mask json_key_data in summary table (#9507) via Stanislav Shakirov
* [snapshot] Show message that Xcode 9 isn't supported yet (#9468) via Felix Krause

To see all new releases, open https://github.com/fastlane/fastlane/releases

Please update using `sudo gem update fastlane`
distiller-build-59:~ distiller$

We are not on the latest, since upgrading in the past led to instabilities.

Dupe of #6791 and it has been fixed on 2.40.0 (Apk check superseded tracks #9459), you also have to use --check_superseded_tracks to allow the feature to work.

I'm running 2.42.0 and I'm still getting this error while using check_superseded_tracks.  Any tips?

I think is better to open a new issue with the log so I can help diagnose it.

@keplersj Did you figure this out or open a new issue? I'm also running 2.55 with check_superseded_tracks:true and hitting this when I have a beta version out.

Also getting this error with the following parameters:
  # Deploy build to the Alpha Channel
  supply(
    json_key: GOOGLE_PLAY_JSON_KEY,
    package_name: ANDROID_APPLICAITON_IDENTIFIER,
    apk: apk,
    track: "alpha",
    # metadata_path: "metadata/google-play",
    skip_upload_metadata: true,
    skip_upload_images: true,
    skip_upload_screenshots: true,
    check_superseded_tracks: true,
    validate_only: false
  )

Also the error:
[!] Google Api Error: multiApkDowngradedDevice: Devices with version 355826070 of this app would be downgraded to version 29 if they met the following criteria: [(API_LEVEL in range 21-0 AND RELEASE_TRACK containing any of each of [[ALPHA]] AND SCREENS containing any of each of [[small, normal, large, xlarge]] AND NATIVE_PLATFORM containing any of each of [[armeabi-v7a]] AND GL_ES_VERSION in range 131072-0 AND FEATURES containing all of [android.hardware.FAKETOUCH, android.hardware.LOCATION, android.hardware.CAMERA, android.hardware.camera.FLASH])].

Why was this issue closed if it was never adressed?

You error multiApkDowngradedDevice is not the same error as multiApkShadowedActiveApk that the --check_superseded_tracks is trying to avoid.

Thank you @capyvara. You are right.

I am running fastlane 2.63.0 and getting
Google Api Error: multiApkShadowedActiveApk: Version 106 of this app can not be downloaded by any devices as they will all receive APKs with higher version codes.

with next supply configuration:
+-------------------------+---------------------------------------+
|                    Summary for supply 2.63.0                    |
+-------------------------+---------------------------------------+
| track                   | beta                                  |
| package_name            | *******                    |
| json_key_data           | ********                              |
| check_superseded_tracks | true                                  |
| apk                     | app/build/outputs/apk/app-release.apk |
| skip_upload_apk         | false                                 |
| skip_upload_metadata    | false                                 |
| skip_upload_images      | false                                 |
| skip_upload_screenshots | false                                 |
| validate_only           | false                                 |
+-------------------------+---------------------------------------+

Am I missing something? Thanks in advance.

@capyvara any ideas?

@andreyslyusar Can we have the full log?

@capyvara
...
[13:11:19]: ▸ BUILD SUCCESSFUL
[13:11:19]: ▸ Total time: 8 mins 1.229 secs
[13:11:19]: Cruising back to lane 'android deploy' 🚘
[13:11:19]: --------------------
[13:11:19]: --- Step: supply ---
[13:11:19]: --------------------

+-------------------------+---------------------------------------+
|                    Summary for supply 2.63.0                    |
+-------------------------+---------------------------------------+
| track                   | beta                                  |
| package_name            | xxx                    |
| json_key_data           | ********                              |
| check_superseded_tracks | true                                  |
| apk                     | app/build/outputs/apk/app-release.apk |
| skip_upload_apk         | false                                 |
| skip_upload_metadata    | false                                 |
| skip_upload_images      | false                                 |
| skip_upload_screenshots | false                                 |
| validate_only           | false                                 |
+-------------------------+---------------------------------------+

[13:11:22]: Preparing apk at path 'app/build/outputs/apk/app-release.apk' for upload...
[13:11:28]: Updating track 'beta'...
[13:11:28]: Checking superseded tracks...
[13:11:29]: Uploading all changes to Google Play...
[13:11:36]: ----------------------------
[13:11:36]: --- Step: reset_git_repo ---
[13:11:36]: ----------------------------
[13:11:36]: $ git reset --hard HEAD
[13:11:36]: ▸ HEAD is now at 1bbf992 Merge pull request #103 in FNX/app-react-native from feature/APP-300 to develop
[13:11:36]: $ git clean -qfdx
[13:11:36]: Git repo was reset and cleaned back to a pristine state.
+-----------------------------+--------------------------------------------------------------------------------------------------+
|                                                          Lane Context                                                          |
+-----------------------------+--------------------------------------------------------------------------------------------------+
| DEFAULT_PLATFORM            | android                                                                                |
| PLATFORM_NAME               | android                                                                                |
| LANE_NAME                   | android deploy                                                                                |
| GIT_REPO_WAS_CLEAN_ON_START | true                                                                                |
| GRADLE_ALL_APK_OUTPUT_PATHS | ["/Users/utv/workspace/mobile-app/deploy/android/app/build/outputs/apk/app-release.apk"] |
| GRADLE_APK_OUTPUT_PATH      | /Users/utv/workspace/mobile-app/deploy/android/app/build/outputs/apk/app-release.apk     |
+-----------------------------+--------------------------------------------------------------------------------------------------+
[13:11:36]: Google Api Error: multiApkShadowedActiveApk: Version 106 of this app can not be downloaded by any devices as they will all receive APKs with higher version codes.

+------+-------------------------------------+-------------+
|                     fastlane summary                     |
+------+-------------------------------------+-------------+
| Step | Action                              | Time (in s) |
+------+-------------------------------------+-------------+
| 1    | Verifying required fastlane version | 0           |
| 2    | default_platform                    | 0           |
| 3    | ensure_git_status_clean             | 0           |
| 4    | Switch to android build_app lane    | 0           |
| 5    | gradle                              | 482         |
| 💥   | supply                              | 15          |
| 7    | reset_git_repo                      | 0           |
+------+-------------------------------------+-------------+

[13:11:36]: fastlane finished with errors

[!] Google Api Error: multiApkShadowedActiveApk: Version 106 of this app can not be downloaded by any devices as they will all receive APKs with higher version codes.

#######################################################################
# fastlane 2.64.0 is available. You are on 2.63.0.
# You should use the latest version.
# Please update using `bundle update fastlane`.
#######################################################################

2.64.0 iPhone X support and more
* Support App Preview for iPhone X (#10799) via Fumiya Nakamura
* Add auto_release_date option to deliver (#10768) via Joshua Liebowitz
* Support for iPhone X in frameit (#10533) via Alfredo Delli Bovi
* Snapshot - fix String character count deprecation warning in SnapshotHelper (#10761) via xta
* Commit version bump enhancements (#9483) via Jimmy Dee
* [Deliver] Fix uses idfa limits tracking (#10715) via Jorge
* Allow snapshots on older iOS versions when no specified/latest found (see #10211) (#10755) via Ely Alvarado
* In two-stage Hockey action, do not set the status to 2 (downloadable) until after the app is uploaded (#10706) via Steve Rubin
* Fix colon styling in SnapshotHelper (#10736) via Sampsa Kuronen
* Fixes image reference in pilot's README. (#10804) via Péter Krassay
* Fixed instruction for update plugin (#10809) via Rishabh Tayal
* Fix mismatched  tags in docs_generator (#10797) via David Vanoni
* Allow in app purchases check to be disabled via deliver (#10758) via Iulian Onofrei
* Remove redundant let declaration for a discardable result (#10762) via Sampsa Kuronen
* Update AppfileTemplate (#10759) via Aaron Brager
* Added is_string: false to active_days_limit config entry (#10763) via vspac
* issue template fix (#10673) via Rishabh Tayal

Please update using `bundle update fastlane`
error Command failed with exit code 1.
[Pipeline] }
[Pipeline] // script
[Pipeline] }
[Pipeline] // stage
[Pipeline] }
[Pipeline] // withCredentials
[Pipeline] }
[Pipeline] // withEnv
[Pipeline] }
[Pipeline] // node
[Pipeline] End of Pipeline
ERROR: script returned exit code 1
Finished: FAILURE

Are there verbose flag for supply?

I'll add some verbosity to the command and post a PR later.
For now can you use the google_play_track_version_codes action and show me the apk versions on all the tracks? production, rollout, beta, alpha?

I'm having the same issue with with uploading from my CI, the APK that is being uploaded to production has an higher versionCode the the one released in Alpha. When uploading through the dashboard everything works fine and the Alpha release gets closed automatically when uploading directly to production.

@capyvara Sorry for long response. I do not have direct access to JSON key, so I cannot fetch track version codes.

The PR #10927 is now merged and will be included in the next release.

🚀


feature suggestions: generate link of selected text

I think Link to Text Fragment is also a good extension, and I hope this extensions can generate url for selected text, it would it is more elegent of the output format

Hi chenboshuo, I guess this feature is already existed if i'm not mistaken? When you open the note by clicking the link, it will jump back to the location of the note and the url is with the noteId.

Please correct me if I am wrong.

Well, This link can be located when you click it, but can't locate text when you copy it, if I want to share this link, it is better if it can locate the selected text. Thanks for your attention.

Thanks, I tried Link to Text Fragment and I think I understand what your need is.
The copied url of the example of Link to Text Fragment is https://web.dev/#:~:text=Let's%20build%20the-,future,-of%20the%20web which uses the postfix :~:text=xxx to highlight the selected text, if you scroll the page then the postfix would disappear. I think this feature is pretty good when you want to share this selected text with other people. But as context note is a note-taking extension, it might focus more on how to store the selected text into storage and show it again next time you open, which can not be achieved by the above method.
So as for the need to share the link, I would suggest using [Link to Text Fragment] instead.

Thanks, I got it, this is a good product positioning, and I think the extension will be more prefect.


297 dynamic site radii based on dataset

Dynamic site radii (based on quantiles) for measurements for TADA_OverviewMap

Codecov Report
Attention: 12 lines in your changes are missing coverage. Please review.

Comparison is base (81910b0) 48.47% compared to head (01b3536) 48.50%.

:exclamation: Current head 01b3536 differs from pull request most recent head 855afa9. Consider uploading reports for the commit 855afa9 to get more accurate results

Files
Patch %
Lines

R/Figures.R
0.00%
12 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #389      +/-   ##
===========================================
+ Coverage    48.47%   48.50%   +0.03%
===========================================
  Files           13       13
  Lines         3340     3344       +4
===========================================
+ Hits          1619     1622       +3
- Misses        1721     1722       +1

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


--exclude-ignored outputs arcane 128 warning when a provided input is not a git directory

If you run fly execute with --exclude-ignored and an --input which is not a git directory (i.e. it does not have a .git subdirectory), you'll get an error like this: could not determine ignored files: exit status 128.  It doesn't seem to break anything but it's likely to confuse users.  The --exclude-ignored flag should only apply to inputs that look like git repository roots.

We're also seeing the partial upload bug occurring frequently alongside this warning.  It's probably unrelated, but just in case...
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
  0     0    0     0    0     0      0      0 --:--:--  0:00:59 --:--:--     0
curl: (18) transfer closed with outstanding read data remaining
gzip: invalid magic
tar: Child returned status 1
tar: Error is not recoverable: exiting now
exit status 2

I am seeing this too, and it seems like the directory never uploads, it just seems to hang forever after printing
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
  0     0    0     0    0     0      0      0 --:--:--  0:02:19 --:--:--     0

Moved to concourse/concourse#1075


Dark and light button

This is a dark mode and light mode button that changes theme with toggle.
Fixes issue: #431
Checklist
✓ You've linked this PR to the correct issue.
✓ You have checked that the code is working correctly.
✓ You ⭐ the repository!

Please remove the unnecessary files outside public and src folders, and follow the naming convention for the files in the buttons folder

Can you check now

Actually  the files are used in the button so i cannot remove them @PoorviShetty

Also I keep on resolving conflicts but as the time passes by the number of people following the steps of making pr keeps on creating conflicts in Data.js files I already updated the pr around 2-3 times

Upload files as per Readme please

Upload files as per Readme please

@VardaPanchal005 Still can't merge because of extra files

@TANYA-CHAN  can you check now

@TANYA-CHAN can you check now

@Spyware007 please look into this as soon as possible

Please check #1346

Hello @VardaPanchal005
Please spare us some time we are reviewing everything!
Will lyk if there's anything!
Thank you for your contribution 🎉

Hello @VardaPanchal005 Please spare us some time we are reviewing everything! Will lyk if there's anything! Thank you for your contribution 🎉

@

Fix Conflicts

Fix Conflicts

Can you check now


code should be "cargo format" clean

... and currently isn't.
We should make sure the CI bails when the code isn't "cargo format" (currently it doesn't) and have a pre-commit hook that enforces this so that we minimize the changes of reintroducing divergence in the future.
(I'm postponing this for now because a lot of development is going on in the webgraph_reader branch. When merged into master it will be a good moment to format all the code and update the CI.)

as of 10b28c6d7d7653442671c080a7776b1a2fe10ae1 (at least) this is fixed


Proposal: Ability to control visibility of NavigationView Header

Proposal: Ability to control visibility of NavigationView Header
Summary
Add a 'HeaderVisibility' property to make user able to control the visibility of NavigationView Header.
Rationale
NavigationView currently has 'AlwaysShowHeader', but what we need more is to totally control the behavior of its Header.
Implementation
<ContentControl x:Name="HeaderContent" ContentTemplate="{TemplateBinding HeaderTemplate}" Content="{TemplateBinding Header}" HorizontalContentAlignment="Stretch" IsTabStop="False" MinHeight="{StaticResource PaneToggleButtonHeight}" Grid.Row="1" Style="{StaticResource NavigationViewTitleHeaderContentControlTextStyle}" VerticalContentAlignment="Stretch" Visibility="{TemplateBinding HeaderVisibility}"/>

public Visibility HeaderVisibility { get; set; }
public static readonly DependencyProperty HeaderVisibilityProperty = DependencyProperty.Register(nameof(HeaderVisibility), typeof(Visibility), typeof(NavigationView), new PropertyMetadata(Visibility.Visible));

@hez2010 when are you seeing that AlwaysShowHeader isn't working? We have another issue #757 relating to AlwaysShowHeader not controlling the header in "Top" mode, but in left it should essentially work like IsVisible.

AlwaysShowHeader only makes decision for us about when to hide Header, however, with HeaderVisibility we can do what AlwaysShowHeader can do as well as making it more customizable.

@hez2010, I'm sorry, I still don't understand. Maybe you can explain your scenario of what you're trying to achieve and how AlwaysShowHeader isn't letting you accomplish this?

For example, in the below scenario the header will show in the red rectangle, however, the blue rectangle I marked up has already shown the header, which will lead to duplicated headers and make the whole page ugly.

I think what you're reporting is a duplicate of #757


Added to condition to avoid null objects

This is a quick fix for #69. However I feel like there should be a decision made as to how we're going to avoid unwanted methods being added the the helper function array #72
#64 Also related to this.

Pull Request Test Coverage Report for Build 184

1 of 1 (100.0%)  changed or added relevant line in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.03%) to 96.985%

Totals

Change from base Build 178:
0.03%

Covered Lines:
144

Relevant Lines:
144

💛  - Coveralls


Failed to load the vim-mode package

(Note: Atom redirected me to #892 when it failed to load the vim-mode package for me. However, I'm not running Windows, and there are no special characters in my name, so I'm thinking this s a new issue.)
I recently upgraded the vim-mode package (not sure what the old version was, but probably the previous one). Ever since, I've been getting the below error message, and vim-mode isn't active. Upgrading Atom from 1.2.1 to 1.3.2 didn't help.
Atom Version: 1.3.2
System: Ubuntu 15.10
Thrown From: vim-mode package, v0.64.0
Stack Trace
Failed to load the vim-mode package
At Cannot find module 'mixto'

Error: Cannot find module 'mixto'
    at Module._resolveFilename (module.js:336:15)
    at Function.Module._resolveFilename (/usr/share/atom/resources/app.asar/src/module-cache.js:383:52)
    at Function.Module._load (module.js:286:25)
    at Module.require (module.js:365:17)
    at require (/usr/share/atom/resources/app.asar/src/native-compile-cache.js:50:27)
    at Object.<anonymous> (/home/rs55df/.atom/packages/vim-mode/node_modules/grim/node_modules/emissary/node_modules/property-accessors/lib/property-accessors.js:6:11)
    at Object.<anonymous> (/home/rs55df/.atom/packages/vim-mode/node_modules/grim/node_modules/emissary/node_modules/property-accessors/lib/property-accessors.js:74:4)
    at Module._compile (/usr/share/atom/resources/app.asar/src/native-compile-cache.js:103:30)
    at Object.defineProperty.value [as .js] (/usr/share/atom/resources/app.asar/src/compile-cache.js:208:21)
    at Module.load (module.js:355:32)
    at Function.Module._load (module.js:310:12)
    at Module.require (module.js:365:17)
    at require (/usr/share/atom/resources/app.asar/src/native-compile-cache.js:50:27)
    at Object.<anonymous> (/home/rs55df/.atom/packages/vim-mode/node_modules/grim/node_modules/emissary/lib/behavior.js:9:23)
    at Object.<anonymous> (/home/rs55df/.atom/packages/vim-mode/node_modules/grim/node_modules/emissary/lib/behavior.js:120:4)
    at Module._compile (/usr/share/atom/resources/app.asar/src/native-compile-cache.js:103:30)
    at Object.defineProperty.value [as .js] (/usr/share/atom/resources/app.asar/src/compile-cache.js:208:21)
    at Module.load (module.js:355:32)
    at Function.Module._load (module.js:310:12)
    at Module.require (module.js:365:17)
    at require (/usr/share/atom/resources/app.asar/src/native-compile-cache.js:50:27)
    at Object.<anonymous> (/home/rs55df/.atom/packages/vim-mode/node_modules/grim/node_modules/emissary/lib/helpers.js:5:14)
    at Object.<anonymous> (/home/rs55df/.atom/packages/vim-mode/node_modules/grim/node_modules/emissary/lib/helpers.js:55:4)
    at Module._compile (/usr/share/atom/resources/app.asar/src/native-compile-cache.js:103:30)
    at Object.defineProperty.value [as .js] (/usr/share/atom/resources/app.asar/src/compile-cache.js:208:21)
    at Module.load (module.js:355:32)
    at Function.Module._load (module.js:310:12)
    at Module.require (module.js:365:17)
    at require (/usr/share/atom/resources/app.asar/src/native-compile-cache.js:50:27)
    at Object.<anonymous> (/home/rs55df/.atom/packages/vim-mode/node_modules/grim/node_modules/emissary/lib/emissary.js:4:13)
    at Object.<anonymous> (/home/rs55df/.atom/packages/vim-mode/node_modules/grim/node_modules/emissary/lib/emissary.js:14:4)
    at Module._compile (/usr/share/atom/resources/app.asar/src/native-compile-cache.js:103:30)
    at Object.defineProperty.value [as .js] (/usr/share/atom/resources/app.asar/src/compile-cache.js:208:21)
    at Module.load (module.js:355:32)
    at Function.Module._load (module.js:310:12)
    at Module.require (module.js:365:17)
    at require (/usr/share/atom/resources/app.asar/src/native-compile-cache.js:50:27)

Commands

Config
{
  "core": {},
  "vim-mode": {
    "useClipboardAsDefaultRegister": true
  }
}

Installed Packages
# User
atom-jshint, v2.0.0
emmet, v2.3.17
language-javascript-jsx, v0.3.7
linter, v1.11.3
minimap, v4.18.4
vim-mode, v0.64.0
vim-surround, v0.8.1

# Dev
No dev packages

Getting errors also after updating
Atom Version: 1.2.4
System: elementary OS
Thrown From: vim-mode package, v0.64.0
Stack Trace
Failed to load the vim-mode package
At Cannot find module 'grim'

Error: Cannot find module 'grim'
    at Module._resolveFilename (module.js:336:15)
    at Function.Module._resolveFilename (/usr/share/atom/resources/app.asar/src/module-cache.js:383:52)
    at Function.Module._load (module.js:286:25)
    at Module.require (module.js:365:17)
    at require (module.js:384:17)
    at Object.<anonymous> (/home/herbert/.atom/packages/vim-mode/lib/vim-state.coffee:1:9)
    at Object.<anonymous> (/home/herbert/.atom/packages/vim-mode/lib/vim-state.coffee:1:1)
    at Module._compile (module.js:434:26)
    at Object.defineProperty.value [as .coffee] (/usr/share/atom/resources/app.asar/src/compile-cache.js:190:21)
    at Module.load (module.js:355:32)

Commands

Config
{
  "core": {
    "projectHome": "/home/herbert/Projects",
    "autoHideMenuBar": true,
    "themes": [
      "one-dark-ui",
      "an-old-hope-syntax"
    ],
    "packagesWithKeymapsDisabled": []
  },
  "vim-mode": {}
}

Installed Packages
# User
an-old-hope-syntax, v0.4.1
linter, v1.11.3
linter-flake8, v1.9.3
linter-js-standard, v3.2.1
vim-mode, v0.64.0
vim-surround, v0.8.1

# Dev
No dev packages

@Habu-Kagumba you should probably update to the latest version of Atom (v1.3.2) and see if it occurs again.

I'm getting the same issue on v1.3.3

+1, issue occurring for me too. Running on Ubuntu 14.04. Atom version is 1.5.3

For me, the module was event-kit.

Sorry! This was an issue on my end. I installed the package using git and so I didn't have any of the packages it required. An npm install seems to have fixed it. :)

@polybuildr: For next time, please use apm install instead.  npm and apm have very subtle differences in how they install modules that could lead to conflicts with Atom.

@50Wliu, thanks for the advice - will keep that in mind. I generally refrain from using apm due to some annoying proxy server issues that I seem to have fixed with npm but haven't managed to resolve for apm.

I just upgrade to vim-mode 0.65, and the issue no longer seems to appear. @Habu-Kagumba I'm closing this, could you check whether it still happens for you with a recent version of Atom and vim-mode, and if so, re-open it? (Or let me know, if you can't re-open it.)


Added dotnet core 2.2 as Targeting framework

Hi,
I have added dotnet core 2.2 as Targeting framework as it is the most popular framework version currently. I didn't find any breakages so far.

Test cases are passing locally. Not sure why it is failing here.

Succeeded after retrying.

Once this is merged I have some PR's to go up


Dark mode theme

Related component
Styles - Colours
Description
Create a new colour palette to be used for dark mode themes.
Rationale
Dark mode can be a more pleasant experience¹ than traditional light themes and has official support in major platforms (Windows, OSX, Android, iOS) and browsers.
¹ When done correctly, rather than relying on automatic plugins
Additional information

https://www.nngroup.com/articles/dark-mode-users-issues/ (2023)
https://www.nngroup.com/articles/dark-mode/ (2020)

Thanks @tschbc — we'll add this to our backlog for investigation. Out of curiosity, do you know of any examples of existing B.C. gov digital services that support dark mode? I'd be interested to see how they've approached it in production.
@bcgov/design-system-team some top-of-mind things to contemplate when we get here:

Tokens: structural implications of implementing a dark mode (or any other alternate 'theme'.) How would these tokens fit into the overall schema?
Components: how is setting an alternative theme controlled — at the component level, or globally? Is it a simple toggle, or something more configurable? Is 'supports dark mode' a line item in the DoD for each new component?

Some interesting avenues to explore here around theming more broadly.

@mkernohanbc I don't know of any existing BC gov service that uses dark mode in production.
That being said, I'm currently working on a mobile app for the social sector and have had great interest in supporting dark mode since we started. The only reason we haven't made it yet is priority for other features.
Also, when you get around to it looking over it, the articles I linked have in-depth UX information and some implementation information to base off of.


Add specific fields for all references at once ?

Hi,
Thank you very much for this BetterBibTeX tool, it has been very helpful to me.
I found out here how to add specific fields in my BibTeX file using the Extra field of each of my references, but I was wondering if it was possible to add those specific fields in every references of an export.
It seems possible, but I never wrote JavaScript, and English is not my mother tongue so I have difficulties understanding your tutorial.
What I would like to do is

Add BibTeX fields that would look like "x-audience = {international}" ; "x-popularlevel = {no}" ; "x-peereviewing = {yes}" ; "x-proceedings = {yes}" and "x-invitedcommunication = {yes}" in every reference (including these special values)
Make the normal "language = {...}" field look like "x-language = {...}" (adding an x- at the beginning of the field, ... being whatever value). I tried to edit the var fieldMap thing (only place where it was written "language") in the BibTeX.js file of my Zotero translators folder, but it doesn't work.
Make the normal "type = {...}" field look like "x-reporttype = {...}" only for report references.

Am I even clear ? I hope I am.
Thank you very much for your help !
Justine

No worries, this is not the most intuitive part of BBT. The following should work:
this.add({ name: 'x-audience', value: 'international' });
this.add({ name: 'x-popularlevel', value: 'no' });
this.add({ name: 'x-peereviewing', value: 'yes' });
if (this.has.language) {
  this.has.language.name = 'x-language';
}
if (this.item.itemType = 'report' && this.has.type) {
  this.has.type.name = 'x-reporttype';
}

(previous comment updated -- I missed two fields)

Thank you very much !!
Unfortunately, I cannot access the about:config part of my Firefox, for safety reasons sigh
Is there a place inside the JS code where I can paste this, and then replace the BibTeX.js file directly in the Zotero translators folder ?
Thank you again,
Justine

I'll add the screen, but how come you can install XPIs, but not access about:config? That seems a little confused, security-wise.
Replacing the translator file won't help as they're replaced by BBT at every start.

You can try https://github.com/retorquere/zotero-better-bibtex/releases/download/builds/zotero-better-bibtex-1.6.43-circle-2119.xpi

It's in the "Advanced" part of the prefs

part of the next release

Hi,
Thank you very much but it still doesn't work (I have a about:config button in the Advanced part of the Prefs but I still get an error message). I asked the IT department of my institution to do it for me and will keep you updated.
Thank you again,
Justine

No, I mean if you install that build, you can go into the Advanced prefs of Better BibTeX. There's a text box where you can paste your postscript.

IT WORKS \o/ Thank you so much !
I only got one problem left : the field "type" is renamed "reporttype" for every document type that contains a "type" field (e.g. phdthesis, misc and unpublished), and I only need it for techreport and manual...

My bad -- that last = should have been an ==
this.add({ name: 'x-audience', value: 'international' });
this.add({ name: 'x-popularlevel', value: 'no' });
this.add({ name: 'x-peereviewing', value: 'yes' });
this.add({ name: 'x-proceedings', value: 'yes' });
this.add({ name: 'x-invitedcommunication', value: 'yes' });
if (this.has.language) {
  this.has.language.name = 'x-language';
}
if (this.item.itemType == 'report' && this.has.type) {
  this.has.type.name = 'x-reporttype';
}

Awesome !!!
Can I take advantage of your kindness one last time ? How can I set the code if I only want the "x-peerreviewing" field to appear for a certain type of document (let's say, only for articles) ?
Many thanks,
Justine

this.add({ name: 'x-audience', value: 'international' });
this.add({ name: 'x-popularlevel', value: 'no' });
if (this.item.itemType == 'journalArticle') {
  this.add({ name: 'x-peereviewing', value: 'yes' });
}
this.add({ name: 'x-proceedings', value: 'yes' });
this.add({ name: 'x-invitedcommunication', value: 'yes' });
if (this.has.language) {
  this.has.language.name = 'x-language';
}
if (this.item.itemType == 'report' && this.has.type) {
  this.has.type.name = 'x-reporttype';
}

(BTW, I wouldn't encourage you to raise the issue with IT, but their security policy is beyond flawed. It would take me all of 60 minutes to whip up an extension that replicates the about:config screen)

In the next release (due in a day or so, but it's not in the release you have) you will be able to do the shorter
this.add({ 'x-audience': 'international' });
this.add({ 'x-popularlevel': 'no' });
if (this.item.itemType == 'journalArticle') {
  this.add({ 'x-peereviewing': 'yes' });
}
this.add({ 'x-proceedings': 'yes' });
this.add({ 'x-invitedcommunication': 'yes' });
if (this.has.language) {
  this.has.language.name = 'x-language';
}
if (this.item.itemType == 'report' && this.has.type) {
  this.has.type.name = 'x-reporttype';
}

Yaaaay ! Thank you soooo much !
And, well, I won't raise the issue with IT...
Many thanks again !

My pleasure.


Docs: Missing "Social Icons" in "Basic layout example"

A minor thing:
In the Basic layout example the documentation has a section for "Social icons". But the Facebook icon is missing in the Try-it-Live-Template. It would be nice, if the example is on the same state as the docs.

Hi, thanks for reporting this
The example template is defined at the website level, so we'll have to wait for a release of the site.


[Enhancement] The spark load timeout of 5 minutes that waits for yarn to be set is optimized to a custom configuration

What type of PR is this:

[ ] BugFix
[ ] Feature
[x] Enhancement
[ ] Refactor
[ ] UT
[ ] Doc
[ ] Tool

Which issues of this PR fixes:

Fixes #
Problem Summary(Required):

Checklist:

[ ] I have added test cases for my bug fix or my new feature
[ ] This pr will affect users' behaviors
[ ] This pr needs user documentation (for new or modified features or behaviors)

[ ] I have added documentation for my new feature or new function

Bugfix cherry-pick branch check:

[ ] I have checked the version labels which the pr will be auto backported to target branch

[x] 3.0
[ ] 2.5
[ ] 2.4
[ ] 2.3

@Mergifyio backport branch-3.0

@Astralidea Is this FE parameter visible to users? If yes, pls submit a doc pr to add this para?


Not listed yet: www.burg-warberg.de

The website at this url is unlisted: https://www.burg-warberg.de/cms/

This website does not provide a consent dialog. The effort is appreciated though!


Tooltip is cut off when used in a custom cell of data grid

Package name(s)
Core v1.4.0 (@salt-ds/core), Data Grid v1.0.3 (@salt-ds/data-grid)
Description
When using Tooltip in a custom cell of data grid, tooltip is cut off within each individual cell.
Steps to reproduce
https://stackblitz.com/edit/salt-grid-template-gjunhl?file=App.tsx
Expected behavior
Tooltip display without obstruction
Operating system

[X] macOS
[ ] Windows
[ ] Linux
[ ] iOS
[ ] Android

Browser

[X] Chrome
[ ] Safari
[ ] Firefox
[ ] Edge

Are you a JPMorgan Chase & Co. employee?

[X] I am an employee of JPMorgan Chase & Co.

the same issue when using Tooltip in Tabs
cc @robin-k


Cannot clone repo due to bad timezone error

nyuszika7h@cadoth ~/src > git clone https://github.com/kennethreitz/requests.git
Cloning into 'requests'...
remote: Counting objects: 18867, done.
remote: Compressing objects: 100% (11/11), done.
error: object 5e6ecdad9f69b1ff789a17733b8edc6fd7091bd8: badTimezone: invalid author/committer line - bad time zone
fatal: Error in object
fatal: index-pack failed

Thanks for raising this issue! In future, please search the issue history before opening new issues on projects, as you'll often find that your issue has been reported before. In this case, this is a duplicate of #3088, #3008, and #2690.

Sorry. I did search, but didn't get the right terms.

If you have an error message, it's usually sufficient just to try to search for that. In this case, I searched for "fatal: index-pack failed" and #3088 popped right up.

Yeah, well, I searched for "timezone" because I didn't realize there's a space in it for the error message. (Also, it's strange, I don't remember enabling fsck, but I found it in my git config.)

fsck is on-by-default on new installs of git, so unless you're persisting a gitconfig from an older version of git you'll always find it on. =)

I do have a custom gitconfig, so that's strange. This kind of issue could have been avoided if they enabled fsck by default in the first place, but oh well. You can't rewrite 6 years of history now, that would just mess things up even more.

Yeah, it's really annoying because it causes legitimate problems for lots of people, especially those who use git in automated scripts, but we really can't do anything about it now. =(

Even though it hurts to do this, you may want to consider rewriting the history to fix this problem once and for all. For Breathe I ended up doing this and I added a notice to the top of the README, in the biggest heading possible, for a while.
Projects using this as a submodule will have to update the SHA once. But currently many setups encounter a clone failure meaning existing submodules will not work at all and cloning this repo directly won't either.
Ref: https://github.com/michaeljones/breathe/issues/340#issuecomment-394396673


python310Packages.co2signal: init at 0.4.2

Motivation for this change
CO2Signal is a depency of home-assistant that is used as part of the CO2Signal integration. Fetching the source from PyPi as the Github source (danielsjf/CO2Signal) isn't tagged with versions.
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[ ] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 155848 run on x86_64-linux 1

3 packages built:

home-assistant-component-tests.co2signal
python310Packages.co2signal
python39Packages.co2signal


Unable to integrate Ola Maps (Recently Released)

Unable to integrate Ola Maps.
Using React Native Expo.
When using https://demotiles.maplibre.org/style.json as styleUrl, everything is working fine.
import { StyleSheet, Platform, Dimensions } from "react-native";
import ThemedScrollView from "@/components/ThemedScrollView";
import MapLibreGL, { Logger } from '@maplibre/maplibre-react-native';
// MapLibreGL.setConnected(true);
MapLibreGL.setAccessToken(null);

if (Platform.OS !== 'web') {
  const originalFetch = global.fetch;

  global.fetch = async (input, init = {}) => {
    let url;

    if (typeof input === 'string') {
      url = input;
    } else if (input instanceof Request) {
      url = input.url;
    } else if (input instanceof URL) {
      url = input.toString();
    }

    // Replace the wrong URL with the correct one
    console.info("URL", url);
    if (url) {
      url = url.replace("app.olamaps.io", "api.olamaps.io");

      if (url.includes("api.olamaps.io")) {
        // Add the API key to the URL based on existing parameters
        if (url.includes("?")) {
          url += "&api_key={MY_API_KEY}";
        } else {
          url += "?api_key={MY_API_KEY}";
        }
        console.log(input, url);
      }
    }

    const modifiedRequest = new Request(url as any, init);

    return originalFetch(modifiedRequest);
  };
}

export default function HomeScreen() {
  return (
    <ThemedScrollView>
      <MapLibreGL.MapView
        style={styles.map}
        logoEnabled={true}
        // styleURL="https://demotiles.maplibre.org/style.json"
        styleURL="https://api.olamaps.io/tiles/vector/v1/styles/default-light-standard/style.json?api_key={MY_API_KEY}"
      >

        <MapLibreGL.Camera
          zoomLevel={5}
        />
      </MapLibreGL.MapView>
    </ThemedScrollView>
  );
}

const styles = StyleSheet.create({
  page: {
    flex: 1,
    justifyContent: 'center',
    alignItems: 'center',
    backgroundColor: '#F5FCFF',
  },
  map: {
    flex: 1,
    height: Dimensions.get('window').height,
    alignSelf: 'stretch',
  },
});

Error from console-
MapLibre error {mous.myproj}[Setup]: loading style failed: HTTP status code 401 {"level": "error", "message": "{mous.myproj}[Setup]: loading style failed: HTTP status code 401", "tag": "Mbgl"}
INFO  URL http://<IP_ADDRESS>:8081/symbolicate

The styleURL has to go through the same transformation similar to the condition block .. that will ensure the other pre-appended params are treated well.
url.includes("?")

@tenhtof
Can you please help me? What exactly I have to do?

You are close. When supplying Ola map URL to the <MapLibreGL.MapView>  you need to make sure you use '?' only if there is no prior param added to the URL. If present, use '&' instead.
The following code from your own sample should be used before supplying URL to the map tag
      if (url.includes("api.olamaps.io")) {
        // Add the API key to the URL based on existing parameters
        if (url.includes("?")) {
          url += "&api_key={MY_API_KEY}";
        } else {
          url += "?api_key={MY_API_KEY}";
        }
        console.log(input, url);
      }
    }

You may also refer to this page which has similar implementation - https://github.com/tofables/poc.olamaps/blob/main/src/App.js

@tenhtof but we don't have transformRequest props for MapView component

You need transformRequest to handle this. Just use React useState or useMemo to add the api_key?
const style_url = React.useMemo(()=> `${url}${ url.includes("?") ? '&' : '?'}api_key=${api_key}`, [url, api_key])

Or, you know, just include the api_key in the styleUrl prop:
style: `https://api.olamaps.io/tiles/vector/v1/styles/default-light-standard/style.json?api_key=${api_key}`,

@tyrauber tried this. Not working.

Sorry, @dsardar099, You are correct. You do need transformRequest in order to pass the api-key to the tile server. Unfortunately, that function doesn't exist. Let's close this in favor of ticket #424. In the meantime, the best you can do is copy the content of the style.json from the server, add it to your rn app, and update it to include the api-key, and then pass the json to the styleJSON prop.

Thanks @tyrauber. I will do that for now.


Add score share flow

When the game is over, the user has an option to Play Again, or Share.
If the user selects Share, a new screen is drawn.
This screen includes a QR code, and the text: "Scan to share your score on Twitter!"
The QR code will create a Tweet with the text: "I just scored {score} on #HAIRPEPESuperShine"

@ayalan Do you know anything about how to generate a QR code in Pico-8?

Someone apparently made some code that will do it during a Game Jam event several years ago.
https://github.com/ctinney94/Pico8-QR-Code-Generator
https://itch.io/jam/procjam2019/rate/514330
If we want to make dynamic content for the tweet text so that the score is included, then we would need something like this.

https://github.com/speedata/luaqrcode


Add thumb color customization to CupertinoSwitch using Switch.adaptive

Description
When using Switch.adaptive allow to set the thumbColor
This PR fixes issue #103485
Tests
I edited the "Switch.adaptive" testWidget to add a thumbColor check.
Pre-launch Checklist

[X] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[X] I read the Tree Hygiene wiki page, which explains my responsibilities.
[X] I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
[x] I signed the CLA.
[x] I listed at least one issue that this PR fixes in the description above.
[x] I updated/added relevant documentation (doc comments with ///).
[x] I added new tests to check the change I am making, or this PR is test-exempt.
[x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@LongCatIsLooong do you know why luci-flutter and google testing checks are failing?

Unfortunately this turns out to be a breaking change: it breaks one of our internal customer's golden tests (in dark mode a dark color is used for the cupertino switch thumb which doesn't make sense). Also on iOS the thumb is white by default, in both dark mode and light mode, and on android the thumb has different colors for on/off/light mode/dark mode. So I'm thinking maybe we shouldn't map inactiveThumbColor or activeThumbColor to CupertinoSwitch.thumbColor.

Ok so let's go with your solution and map thumbColor

Ah from https://material.io/components/switches the inactive thumb looks like a good fit for cupertino switch . I'll look into why the internal test failed

Looks like an internal customer is using the same color for inactiveTrackColor and inactiveThumbColor, but with a different opacity. So in dark mode the thumb becomes dark on iOS.

I don't think we should use thumbColor: thumbColor?.resolve(Set<MaterialState>.of(MaterialState.values)) here. Changing it toinactiveThumbColor probably makes sense but that will be a breaking change.

Issue closed


Since this appears in a generated class, the comment is sourced from the service Swagger.

Thank you for your feedback.  Tagging and routing to the team best able to assist.

Since this appears in a generated class, the comment is sourced from the service Swagger directly and would need to be updated there.

yeah, I think so, it was from Azure service that generated the swagger the SDK team using.


use try-with-resources when possible

no-one should be calling close() by themselves. All Closables are Autoclosables and all should be converted to the modern style. Code migrated from Java 6 is full of the old idiom and needs to be updated.

Closed by #583


qtcreator: 4.6.2 -> 4.9.1

Motivation for this change
https://blog.qt.io/blog/2019/05/28/qt-creator-4-9-1-released/
Appears to work! However overall integration (ability to find/generate
compilers and such) requires a bit of hand-holding for now.
This is likely the same with the currently packaged version,
but just mentioning in case that's unexpected :).
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Assured whether relevant documentation is up to date
[ ] Fits CONTRIBUTING.md.

Already built that locally. Currently trying to build a simple QT application with it. If that seems fine, I'd merge that into master :)

After instaling QT, CMake and configuring a local device for the "Desktop" profile I managed to get a simple QT application running as well...

Regarding the aarch64 build failure: it seems as botan isn't used anymore, hence we can remove the patch. I'll push a fix, let's see if aarch64 continues to build :)

@GrahamcOfBorg test qtcreator

@GrahamcOfBorg build qtcreator

Everything appears to evaluate and aarch64 should be fixed by now.

@dtzWill thanks!


brainyquote.py: get_quotes returns quotes in form of (quote1, quote2, ..., author) instead of ((quote1,author), (quote2,author)... )

@prajwal72 is it fixed? If not can I work on this?


JS/TS: Index variables according to the schema. [phab:D640]

Created by zarko at 2015-12-10 19:06:20:

schroederc accepted this revision at 2015-12-10 19:33:58

zarko closed via commit 1e61421288706af2a51433e354ad708d88c67bd1 at 2015-12-10 20:22:41


Bot Orchestrator : Unable to achieve disambiguation of common utterances present across multiple PVA skills

Describe the bug

We have added multiple PVA skills in Azure Bot (C#) and enabled orchestrator. The unique utterances are getting navigated to associated PVA skill and getting the appropriate response.
Now, we have common utterances in multiple PVA skills .. for an example
PVA Skill 1 : utterances - Create incident
PVA Skill 2: utterances - Create incident for HR Functions
PVA Skill 3: utterances - Create incident for IT functions
Now, when we search Create incident , it goes into unknown intent. and unable to proceed further.
We tried another approach to solve this issue .. there is an trigger phrase - "Duplicated intents recognized"
Using this Azure Bot goes into disambiguation and gives an option to use to select which Skill you want to go for utterances asked "Create Incident" .. when we select appropriate skill and submit ... the bot doesn't respond.. found that utterance is not getting passed to the selected skill..
Version

2.1.2
Browser

[ ] Electron distribution
[ ] Chrome
[ ] Safari
[ ] Firefox
[ ] Edge

OS

[ ] macOS
[ ] Windows
[ ] Ubuntu

To Reproduce
Steps to reproduce the behavior:

Go to '...'
Click on '....'
Scroll down to '....'
See error

Expected behavior

When we select the PVA skill and submit .. it should send the asked utterance to the selected PVA skill and respond appropriately.
Screenshots

Additional context

Thanks @pckyn, I'm investigating.

Hi @pckyn, could you please provide the steps to reproduce this issue?

Hi @ramfattah - The steps are as below

Create an Azure Bot
Create PVA bots and add few similar utterances in all the PVA bots
Add PVA bot skills in azure bot, may be please add two to three PVA skills to test the usecase
Enable Orchestrator in azure bot
Publish the azure bot in azure
Search similar utterances that are available in skills and observe the response

Please let me know if any additional details are needed.

Thanks for your patience @pckyn, we are actively investigating.

For next steps, I will add PVA skills to see if the issue is reproducible.

Hi @pckyn,
Could you please provide detailed steps of how you added multiple PVA skills to the Composer bot?

Add PVA bot skills in azure bot, may be please add two to three PVA skills to test the usecase

Closing due to inactivity. @pckyn, please re-open with the details needed. Thanks.


[WIP] Order completion

[x]  Create order completion protobuf
[x]  Refactor rating signature in OrderConfirmation and OrderFulfillment
[x]  Create api call to complete order
[x]  Create, send and handle the order completion network message
[ ]  Sign payout if moderated order
[ ]  Complete moderated payout on vendor side
[ ]  Save rating on buyer side
[ ]  Save rating on vendor side and update overall rating
[ ] Create direct purchase integration test
[ ] Create moderated purchase integration test
[ ]  Update api documentation

Coverage remained the same at 60.413% when pulling 8b73847c667bd294fe60d8aabafef963bb13b9a5 on cpacia:master into f9ef1b8196e86001786a4e011e4ec0797c4f3cdb on OpenBazaar:master.

Coverage remained the same at 60.413% when pulling c4dbb2062ce177b2238bfe0b5b47234e28040b20 on cpacia:master into f9ef1b8196e86001786a4e011e4ec0797c4f3cdb on OpenBazaar:master.

Coverage remained the same at 60.413% when pulling 6a7d67bbadfed8cb7d1622eff0d74c86f9c06769 on cpacia:master into f9ef1b8196e86001786a4e011e4ec0797c4f3cdb on OpenBazaar:master.

Coverage remained the same at 60.413% when pulling b3a60e37458cde9181533ce9a2eb8a6841aa9d89 on cpacia:master into 33daeb30b8261b53c89dd8189ac1b9fd2de01add on OpenBazaar:master.

Coverage remained the same at 60.413% when pulling b3a60e37458cde9181533ce9a2eb8a6841aa9d89 on cpacia:master into 33daeb30b8261b53c89dd8189ac1b9fd2de01add on OpenBazaar:master.

Coverage remained the same at 60.413% when pulling bba7d3b8ec013ec8f26645c61f024e4b743f3fc1 on cpacia:master into 33daeb30b8261b53c89dd8189ac1b9fd2de01add on OpenBazaar:master.

Coverage remained the same at 60.413% when pulling 38948871ead05f48ad2999d647db8a94af98630a on cpacia:master into 33daeb30b8261b53c89dd8189ac1b9fd2de01add on OpenBazaar:master.

Coverage remained the same at 60.413% when pulling aac1967edd65c6937700f430db4fe6dc17fd8fa2 on cpacia:master into 33daeb30b8261b53c89dd8189ac1b9fd2de01add on OpenBazaar:master.

Coverage decreased (-0.02%) to 60.398% when pulling 55d11f059669464f1fe1d66b22df542b0a36e488 on cpacia:master into 33daeb30b8261b53c89dd8189ac1b9fd2de01add on OpenBazaar:master.

Coverage decreased (-0.02%) to 60.398% when pulling 9d5c7748073cf8ad15ed4aecd52788340b0b82dd on cpacia:master into 33daeb30b8261b53c89dd8189ac1b9fd2de01add on OpenBazaar:master.

Coverage decreased (-0.02%) to 60.398% when pulling e6e3d3d2a92f72259ef79453d304c7b5516f3731 on cpacia:master into 33daeb30b8261b53c89dd8189ac1b9fd2de01add on OpenBazaar:master.

Coverage decreased (-0.05%) to 60.367% when pulling 6a1718b6f1041579f3f539b26bc2d77518835db0 on cpacia:master into 33daeb30b8261b53c89dd8189ac1b9fd2de01add on OpenBazaar:master.

Coverage decreased (-0.05%) to 60.367% when pulling 3b485cf365f5d403f42595760b896a5cfd87b65f on cpacia:master into 33daeb30b8261b53c89dd8189ac1b9fd2de01add on OpenBazaar:master.

Coverage decreased (-0.05%) to 60.367% when pulling fa76f4e32cacedc793f7bfc024fa942d7732824e on cpacia:master into 33daeb30b8261b53c89dd8189ac1b9fd2de01add on OpenBazaar:master.

Coverage decreased (-0.05%) to 60.367% when pulling e939613d15f23a73da55294a57b8e1b4fe7293aa on cpacia:master into 33daeb30b8261b53c89dd8189ac1b9fd2de01add on OpenBazaar:master.

Coverage decreased (-0.05%) to 60.367% when pulling dd7df37a8796b610aef2f37f6a1e122e9bc267ba on cpacia:master into 0ab362f43832b1a93e3e573bef2a30fd2ad7fab7 on OpenBazaar:master.

 For now there are integrations tests that are working.


Add flag for position dependent library compiling

Otherwise NiftyReg won't pass -fPIC to the CUDA files, thus will complain.
This requires the following to work: KCL-BMEIS/niftyreg#67

Hum, Travis doesn't like my changes. I don not know why/how to fix it. Happy to take suggestions.

Looks good to me, one of our docker builds is broken. See here: https://github.com/CCPPETMR/SIRF-SuperBuild/issues/331


3d level nested menu does not work, it closed leaving 2nd level

If I have a menu like option (i)-> nested 1 -> nested 2, when I leave second level, the third closes and it's not possible to select the desired option on 3rd level (actually, the one having the real action)

Could you provide a demo or plunker for this? Thanks

Nevermind, it's actually just a simple fix. Should be ready in the latest master and will be in 1.1.0

Thanks, when 1.1.0 will be ready?

It should be ready now. I just released v1.1.0

thanks a lot, very good work! Just a note: documentation appears broken on github project page


chore(main): release 2.3.3

:robot: I have created a release beep boop
2.3.3 (2023-09-08)
Bug Fixes

📈 修复入口页面模块引用格式不统一的问题 (bd72731)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/viarotel-org/vite-uniapp-template/releases/tag/v2.3.3 :sunflower:


Option to pass Ensembl object

Ensembl is down this month. Generally, it can be unreliable. If a user plans to test various parameters, it could be useful to store the biomaRt object in Synapse and then use the stored version.
Could create a function, outside of plan, to store a saved version of the object.

blocker


Consolidated system observables

@maxtroy @smile616
First step to flatten the calls more sensibly, and without the additional allocations the other flattener had to use.
Based on this I think I can add immediate calls to observableActivate and update when on the same looper. Have two more commits for those later

[Current coverage][cc-pull] is 98.71%

Merging [#53][cc-pull] into [master][cc-base-branch] will decrease coverage by 0.24%

@@             master        #53   diff @@
==========================================
  Files            38         38
  Lines          1447       1400    -47
  Methods           0          0
  Messages          0          0
  Branches        239        235     -4
==========================================
- Hits           1432       1382    -50
- Misses            2          3     +1
- Partials         13         15     +2

Powered by Codecov. Last updated by [5555880...b675032][cc-compare]
[cc-base-branch]: https://codecov.io/gh/google/agera/branch/master?src=pr
[cc-compare]: https://codecov.io/gh/google/agera/compare/5555880a4997cacc83fd9bbd8be8cd01d8d7cc77...b6750323588db7f88b0e92682dfeaa215b96ac0f
[cc-pull]: https://codecov.io/gh/google/agera/pull/53?src=pr

LGTM


Please allow for not updating the lockfile (eg: with a --locked option).

:clipboard: Description

Context
I tend to to do CI builds by passing --locked to everything that triggers a build, to ensure that the lockfile is up to date. However, I'd also gotten into the habit of using cargo fmt --all -- --check before the build, so we can get faster feedback on small changes that need to happen.
The Problem
However, I'd found that builds that had passed cargo build --locked on CI still had a stale lockfile. After some poking (such as removing write permissions on the lockfile) it turns out that running cargo fmt will update the lockfile, as it uses cargo metadata (or at least it's core implementation) to figure out where the roots of each lockfile.
However, it appears that cargo metadata will default to updating the lockfile unless --locked or --frozen is passed. So running cargo fmt -- --check before cargo build --locked means the latter isn't checking what's in source control.
Proposed solution
I think that the most coherent option for now is to add --frozen and --locked options to cargo fmt, along with the rest of the suite.

Oh, and I should also say thanks! This is a hugely useful tool, and greatly appreciate all of the hard work that's gone into this one part of the ecosystem.

Thanks for reaching out, but think I'm probably going to close this as another symptom of the root cause covered in #4247. The core of this issue is that --all actually has to support a ton of use cases, and in order to do so it at the moment has to call cargo metadata without the --no-deps arg which is what results in the lockfile an registry hit.
This was driven by the nature of the cargo metadata output which has subsequently changed, and instead of iterating on that existing flow we really just need to make the update which allows us to always include --no-deps, and that in turn solves the problem reported in this issue as well as various others.
In the short term, if you are using an explicit workspace and have your workspace members defined (as opposed to just a tree of packages with relative path based dependencies on each other) then you don't even need to use the --all flag with cargo fmt. Running cargo fmt in the root of a workspace will already format everything in that workspace.

Ah, that's great! Thanks for the easy solution.


Only reset port settings for motor on first start()

This should mostly solve Issue #122

update_speed() would mostly duplicate start() and only save the elif branch from executing as you would just bail out if it weren't already running.  Not sure if it's worth it even if you make start() call update_speed() to de-duplicate, as then it would make sense to require start() before update_speed() and then repeated start() calls would assume a re-initialization and then we'd be back to looping start() makes the motor serial line crash.

From a technical point of view I agree with that assessment.
Once this functionality is transferred to the main branch, you might want to include an example which calls the start function in a hard loop. That might help users to create robot functionality.

Thanks a lot for this pull request @mutesplash, I've just been testing it with alternating between a speed of 0 and 1, and it seemed to work great :). I'll also add an extra test case soon for the motors that tests for this issue that your pull request fixes.
Do you mind altering this pull req. so that we use an enum for runmodes (I just checked enum was introduced in 3.4 and the minimum python version we're supporting is 3.7).

There we go


Code39  - Modulo 43 Checksum digit enhancement

Dear ExLibris Community (dear Josh),
Thank you very much for providing the solution to adjust the barcode width and the height. My current workflow is increasingly focused on barcode label printing and I have hit once more on a technical 'bump'. Accordingly, I have experienced an issue in printing CODE39 barcodes with SpineOMatic.
After some trial-error testing and desk research, I figured out that our previous label printing tool, based on BIAF, appends a modulo 43 check digit at the end of each sequence for increased data integrity. As a result, the barcodes printed via SpineOMatic are not readable from the scanners due to their correspondent value. For example, a physical item with barcode 'KUL935357' in Alma is scanned successfully only if it contains the value 'KUL935357h' (h = modulo 43 checksum digit).
As an institution it would be beneficial to have versatile barcode option to include (or not) the modulo 43 checksum in order to avoid re-programming all the scanning devices. Thus:
Would you be able to provide us with a SpineOMatic enhancement that supports the generation of the modulo 43 checksum digit?

Thank you in advance!
Vangelis Palaskas.
Sources:

Barcodes - Modulo 43 explanation: https://meral.edu.mm/record/3118/files/Development of Bar Codes for All Products in Commercial Control System.pdf
Modulo 43 calculator:
https://www.activebarcode.com/codes/checkdigit/modulo43.html
Current Alma checksum XSL template (Configuration Menu > General > Letters > Component Configuration):
checksum_calc.txt

Thanks for your suggestion. We can look into this.

Many thanks Josh. Looking forward to your update!


Slot tag in parent instead of directive/attribute?

NOT a bug report, but would be intended use from my perspective.
Vue.js version
1.0.21
Reproduction Link
http://jsbin.com/cixorubeju/edit?html,js,output
What is Expected?
I would expect to be able to use <slot> inside the parent declaration as well.
What is actually happening?
It does not work as an independent tag, but instead only as directive/attribute.
Is this intentional? If so, any way around it? It would really be useful not to push markup around. In my use-case for instance, I have a
 that always comes with a set of classes, and I want only the
's to be in the  component on a parent.

Because it's not designed to work like this? I think the doc explains it pretty well. <slot> stands for "replace this with parent content", you are basically using it in reverse.
I still have no idea what you are trying to achieve after reading your explanation, but if you just want to insert plain text, use <template slot="xxx"></template>.

@devboxr you can not use <slot name="one"> in place of <... slot="one">, because former defines a "box" while later defines content to be placed into a "box".

Hi Evan,
I understand what the docs say, you did a great job writing these. What I am saying is that the use case for me will not allow this to work.
What I am trying to achieve is simple:
I do have a component that is contains a
. When using the component, I do not want to repeat the markup for the unordered list, but instead only use a slot that contains list items, that are then placed in the appropriate slot inside the component (= inside the unordered list).
I cannot wrap the
something
 with anything else. First of all would this be unnecessary markup, and secondly does the
 break when doing this.
I see that there was a mistake in the jsbin, I updated the example:
http://jsbin.com/suhohuceqo/edit?html,js,output
How would you guys approach this?

In that case, this is a question and should not be opened as an issue. Please adhere to the issue reporting guidelines.


Key error: 'mqreader'

Hello,
thanks for making this package available!
I am trying to run this on a Mac M1max.
I have created a virtual env using the following:
conda create --name mspypeline
conda activate mspypeline
conda config --env --set subdir osx-64
conda install -c conda-forge -c siheming mspypeline

When I try to run the analysis with the GUI I get the following error:
raceback (most recent call last):
  File "/opt/homebrew/Caskroom/miniconda/base/envs/mspypeline/lib/python3.8/site-packages/mspypeline/core/MSPPlots/BasePlotter.py", line 143, in __init__
    self.required_reader_data = reader_data[required_reader]
KeyError: 'mqreader'
Exception in Tkinter callback
Traceback (most recent call last):
  File "/opt/homebrew/Caskroom/miniconda/base/envs/mspypeline/lib/python3.8/tkinter/__init__.py", line 1892, in __call__
    return self.func(*args)
  File "/opt/homebrew/Caskroom/miniconda/base/envs/mspypeline/lib/python3.8/site-packages/mspypeline/core/MSPypeline.py", line 169, in <lambda>
    command=lambda: self.report_button())
  File "/opt/homebrew/Caskroom/miniconda/base/envs/mspypeline/lib/python3.8/site-packages/mspypeline/core/MSPypeline.py", line 388, in report_button
    mspplots = self.selected_reader.plotter.from_MSPInitializer(self.mspinit)
  File "/opt/homebrew/Caskroom/miniconda/base/envs/mspypeline/lib/python3.8/site-packages/mspypeline/core/MSPPlots/MaxQuantPlotter.py", line 76, in from_MSPInitializer
    return super().from_MSPInitializer(mspinit_instance, **default_kwargs)
  File "/opt/homebrew/Caskroom/miniconda/base/envs/mspypeline/lib/python3.8/site-packages/mspypeline/core/MSPPlots/BasePlotter.py", line 209, in from_MSPInitializer
    return cls(**default_kwargs)
  File "/opt/homebrew/Caskroom/miniconda/base/envs/mspypeline/lib/python3.8/site-packages/mspypeline/core/MSPPlots/MaxQuantPlotter.py", line 55, in __init__
    super().__init__(
  File "/opt/homebrew/Caskroom/miniconda/base/envs/mspypeline/lib/python3.8/site-packages/mspypeline/core/MSPPlots/BasePlotter.py", line 143, in __init__
    self.required_reader_data = reader_data[required_reader]
KeyError: 'mqreader'

Would you be able to help me sort out this error?
Thanks,
Piero

Hi Piero,
can you share the yml file, that was created to analyze the experiment? I am not sure how this error could come from looking at the trackeback. It seems like the data was stored under another key, but this should not really happen.

Thanks for looking into this.
config.yml.zip
Here is the yml file.

The file seems to be fine, so I am guessing that the csv file by max quant is not read corretly. The program was tested with max quant 1.5+ but there might be older (or newer) versions for which this does not work. It might also be that you are using a different delimiter, currently tabs are expected. If you can, you could also share the first few lines of your csv file, so I could take a look.

If you still run into issues reopen the issue, but I will close it for now

Hi I'm facing the same issue, for public data. I'm trying to examine the SerumVsPlasma files in here. My yaml file is very similar to the one above, with the difference that I have no GO_terms specified. How to overcome this issue?

Hi @Benfeitas , I would guess the same issue. I dont have a lot of free time on my hand unfourtunatly so I did not manage to take a closer look at the file you linked. Are you familiar with python? If yes you could try to look into the file reader of maxquant. https://github.com/siheming/mspypeline/blob/master/mspypeline/file_reader/MQReader.py . Otherwise you could compare it to the csv in the public dataset https://github.com/siheming/mspypeline_public_dataset/tree/122966b0e29ce53698371d4c1d65dff8c89f2fbe/txt . Maybe you could also tell me how your file structure currently looks like. My tool expects there to be something like this
some_experiment
|- txt
|-- proteinGroups.txt
|-- etc...

So it might be that you have to restructure the files similar to the output that max quant generates


Vec4 sub z is incorrect

In glm.BasicOperators.java on line 2256 res.y = a.z - bZ; should be res.z = a.z - bZ;

Fixed, thanks for your contribution :+1:


refactor:move branchSession#unlock to LockManager

Ⅰ. Describe what this PR did
refactor:move branchSession#unlock to LockManager
Ⅱ. Does this pull request fix one issue?
fix #944
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews

Codecov Report

Merging #945 into develop will increase coverage by 0.01%.
The diff coverage is 63.33%.

@@              Coverage Diff              @@
##             develop     #945      +/-   ##
=============================================
+ Coverage      37.16%   37.17%   +0.01%
- Complexity      1024     1025       +1
=============================================
  Files            224      224
  Lines           8882     8884       +2
  Branches        1065     1066       +1
=============================================
+ Hits            3301     3303       +2
  Misses          5196     5196
  Partials         385      385

Impacted Files
Coverage Δ
Complexity Δ

...in/java/io/seata/server/session/BranchSession.java
81.81% <20%> (-0.22%)
40 <1> (-3)

...a/io/seata/server/lock/DefaultLockManagerImpl.java
84.21% <85%> (+0.21%)
21 <4> (+4)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2d6f239...0d515b9. Read the comment docs.


Install dev packages into production, is this correct?

Describe the feature you'd like
Installation documentation mentions installing using composer install. Shouldn't this be composer install --no-dev?
Describe the benefits this feature would bring to BookStack users
Does not install development packages into "production"

Just confirming that this works and results in a working production instance.

Yeah, probably worth doing. I ideally want to avoid composer being required at all for production setups so never looked to optimised it, but that's likely still a way off so have marked this to be updated before next release.

Thumbs up for this one. I am doing this in two production environments and it did not have any negative impact so far.

Just fired up my own and it seems to work without issues when not installing dev packages.
Note there might be some packages in the non dev that could be moved to dev.

Thanks for confirming everyone.
I've now updated the docs and install scripts to use --no-dev mode. Will therefore close this.


Cull high-velocity ammo

It does more damage than regular ammo but it's just extra mapping hassle and never gets used anyway so I think we're better off removing it.

This is now used in the Tier 2 "optimized ballistics" technology.


Pod Lifecycle - force termination docs should mention the possibility of resources running forever

When forcefully deleting a pod, kubectl issues a warning:
[~]$ k delete pod nginx --force --grace-period 0
Warning: Immediate deletion does not wait for confirmation that the running resource has been terminated. The resource may continue to run on the cluster indefinitely.
pod "nginx" force deleted
[~]$ k get pods

/language en
/triage accepted
/kind feature

/close
Fixed in #37158


Navigating straight to a listing/order fails to rehydrate position data

Before refresh and after refresh:

The graph is forgetting the pixel position of the selected listing/order during refresh, so believe it's drawing the lines & annotation at (0, 0).

I was inspecting this bug and found more issues with this particular graph.

Select a point
Resize the window vertically
You'll see that the horizontal and vertical line hasn't been redrawn to the new scale.

I don't have the project setup, but looks like the bug is around here. The cursorPoint is memoized, so it's not being updated when the selectedPoint hasn't changed during the window resize. I am sure the charting system has an onChange callback that can be used to set the new selectedPoint and similarly on first load so it can trigger that memoization.
https://github.com/BeanstalkFarms/Beanstalk/blob/master/projects/ui/src/components/Market/PodsV2/Modules/MarketGraph.tsx#L268

@silochad Could you assign this to me please?


Integrate export/save as options with JupyterLab?

The editor works really great here (including the save option).
I wonder if it would would be possible to add save as/export options so that the file can be saved to the current JupyterLab directory. Currently export to disk (this is download) does not work for me. Choosing:

and then:

Leads to:
Download is disallowed. The frame initiating or instantiating the download is sandboxed, but the flag ‘allow-downloads’ is not set. See https://www.chromestatus.com/feature/5706745674465280 for more details.

Somehow this had passed under my radar!
Anyhow, I guess I'm slightly missing some context (and I should make some .github templates!). Is this with:

a .dio(.svg|.png) Diagram document
a MimeRenderer/rich display
a Jupyter Widget

In a nutshell: it's found it hard to properly take away things from the drawio UI, and there is of course a lot of duplication between the Lab File Stuff and the Drawio File Stuff. There are a bunch of command palette commands for file actions for the Diagram... but none of these work for the other activities (like the Jupyter Widget).

Anyhow, I'll tag this as part of the 1.0.0 release plan (in the next week or so TBD), if you can fill in some of what you're looking for!

Still no headway on actually hiding that option (in a future-compatible way), but at least did add allow-downloads over on #22...


[BUG] CrewAI is failing when I use agentops

Description
When I am using agentops, CrewAI Crew.kickoff returns the LLM response to be None, i.e. fails silently.
Steps to Reproduce
import os
from dotenv import load_dotenv
assert load_dotenv()
import agentops
agentops.init(os.environ["AGENTOPS_API_KEY"])

...
crew.kickoff()

Output:
> Entering new CrewAgentExecutor chain...
> Finished chain.
 Error parsing JSON: Expecting value: line 1 column 1 (char 0). Attempting to handle partial JSON.
 Failed to convert text into JSON, error: 'NoneType' object is not callable. Using raw output instead.
 [2024-09-06 17:44:26][DEBUG]: == [Agent Name] Task output: Agent stopped due to iteration limit or time limit.

Expected behavior
If there is an error, it should be notified. It should not fail silently.
Ideally, this should not happen at all, and the kickoff function call should return a proper CrewResponse with LLM completion.
Screenshots/Code snippets

Operating System
Ubuntu 20.04
Python Version
3.12
crewAI Version
0.51.1
crewAI Tools Version
0.12.0
Virtual Environment
Poetry
Evidence
Run this code:
import os
from dotenv import load_dotenv
load_dotenv()

import agentops
agentops.init()

from crewai import Agent, Task, Crew

dummy_agent = Agent(
    role="Dummy",
    goal="You don't have any goal",
    backstory=(
        "You are a dummy and you just give one word replies to everything you are asked to do"
    ),
    allow_delegation=False,
	verbose=True,
)

dummy_task = Task(
    description=(
        "The task is to be yourself"
    ),
    expected_output="Give one word answers",
    agent=dummy_agent,
)

dummy_crew = Crew(
    agents=[dummy_agent,],
    tasks=[dummy_task],
    memory=False,
    verbose=True
)
dummy_crew_output = dummy_crew.kickoff()

Possible Solution
NA
Additional context
NA

Never import agentops before importing crewai classes.
Inside crewai crew.py, agent.py, tool_usage.py, etc, they are importing autogen by checking the variable:
agentops = None
if os.environ.get("AGENTOPS_API_KEY"):
    try:
        import agentops
    except ImportError:
        pass

If you import autogen and do autogen.init() before importing any of crewAI's Crew, Agent, Tool class, your agentops variable will reset and the agentops.init() session will be lost. The system then fails silently and you are left scratching your head why your LLM is not responding.


Base ga4gh PURL does not resolve

This resolves
http://purl.org/ga4gh/kin.owl
But this does not:
http://purl.org/ga4gh/
Although this is not strictly a KIN problem, AFAICT KIN is the main user of this purl, and many semantic web users would expect to find something in the parent path, and I am not sure where else to report this
FWIW, there is also a PURL registered at https://w3id.org/ga4gh/
https://github.com/perma-id/w3id.org/blob/master/ga4gh
This resolves to a not very useful directory with a single minimal README

@lindsmith @buske any update on this? The monarch team has a lot of experience with w3id just reach out if you need help...

@cmungall These purl paths were set up by @ametke. Perhaps he has input on this? Should the base path resolve to something ga4gh generic, or something ga4gh pedigree specific, since it looks like those are the only purls under the ga4gh path?

Yes, I created those with my account. I'll delete them so someone in GA4GH can take over and redefine them appropriately.

There doesn't seem to be an obvious way to transfer ownership of this @buske and I don't think I can (or should) delete them since they are meant to be persistent identifiers.

It seems like there are not in heavy use yet
For the base resolver, I favor w3id.org over purl.org. I use w3id for many projects, it's a really simple and transparent system, all managed by github and PR.
Years ago OBO used purl.org, and it was disastrous, as it became impossible to edit the purls we owned, the system may have improved
whatever the base resolver, the next question is whether to have an overall ga4gh namespace with sub-namespaces underneath, or to have looser coupling e.g. w3id.org/kin

Any objections to using w3id.org?


editor specific browser-compability issue, including the  tag or  tag instead of

Normally when we type a sentence in an wysiwyg editor and if we need one in next line we use to press the enter key and it will automatically insert a
 tag. But when we use the jeditable wysiwyg editor and do this it is inserting

 tags instead of
 in internet explorer and

 tag in chrome. But it is inserting
 tag in mozilla(which is the right one)
So I smell this as an editor specific browser-compability issue
Please fix this.

This happens on demo at http://www.appelsiini.net/projects/jeditable/wysiwyg/wysiwyg.html

The example uses quite old jWYSIWYG plugin.


A mistake in ICE

hi, I have read your code, and I find a mistake in ICE modules L165.
in2 = F.interpolate(in1, size=in1.size()[2:], mode='bilinear')

I think it should correct like below:
in2 = F.interpolate(in2, size=in1.size()[2:], mode='bilinear')

Thank you so much. It seems truly a mistake during tiding up my code. I invite you as a contributor.


While vs code is being used in split screen the output cell border is glitching in jupyter lab

Type: Bug
While using jupyter notebook and seeing the output in split windows mode when vs code is being run in half the screen width only, the border line should be around the whole output instead on scrolling horizontally it is comming in betwwen the output and not the whole output and hindering the view of output.
 Unfortunately, it's hard for us to understand what issue you're seeing. Please help us out by providing a screen recording showing exactly what isn't working as expected. While we can work with most standard formats, .gif files are preferred as they are displayed inline on GitHub. You may find https://gifcap.dev helpful as a browser-based gif recording tool.
If the issue depends on keyboard input, you can help us by enabling screencast mode for the recording (Developer: Toggle Screencast Mode in the command palette). Lastly, please attach this file via the GitHub web interface as emailed responses will strip files out from the issue.
Happy coding!

@gjsjohnmurray did you get the problem?

@ravaldhrumil the issue is assigned to @rebornix. I only got involved to improve the information available to the assigned.

This issue has been closed automatically because it needs more information and has not had recent activity. See also our issue reporting guidelines.
Happy Coding!


jar binary missing from serverjre, which is required for OracleWebLogic

I built the serverjre image from docker-images/OracleJava/java-8
no 'jar' command exists in the resulting image (even though the Dockerfile tries to set the alternatives for jar)
The build of a Weblogic image, from docker-images/OracleWebLogic/<IP_ADDRESS>  requires the jar binary be available, so it is failing.

Taking a step back I looked at the server-jre from OTN, which I'm using server-jre-8u161-linux-x64.tar.gz, and if you look in that tarball you can see it doesn't have the jar utility:

gzip -dc server-jre-8u161-linux-x64.tar.gz | tar -tvf - | grep bin
drwxr-xr-x  0 java_re java_re     0 Dec 19 18:21 jre1.8.0_161/bin/
-rwxr-xr-x  0 java_re java_re  7949 Dec 19 18:21 jre1.8.0_161/bin/rmiregistry
-rwxr-xr-x  0 java_re java_re 231482 Dec 19 18:21 jre1.8.0_161/bin/unpack200
-rwxr-xr-x  0 java_re java_re   6264 Dec 19 18:21 jre1.8.0_161/bin/jcontrol
-rwxr-xr-x  0 java_re java_re   7965 Dec 19 18:21 jre1.8.0_161/bin/servertool
-rwxr-xr-x  0 java_re java_re   7997 Dec 19 18:21 jre1.8.0_161/bin/policytool
-rwxr-xr-x  0 java_re java_re   7941 Dec 19 18:21 jre1.8.0_161/bin/jjs
-rwxr-xr-x  0 java_re java_re   8149 Dec 19 18:21 jre1.8.0_161/bin/orbd
-rwxr-xr-x  0 java_re java_re   7957 Dec 19 18:21 jre1.8.0_161/bin/pack200
-rwxr-xr-x  0 java_re java_re   7941 Dec 19 18:21 jre1.8.0_161/bin/rmid
-rwxr-xr-x  0 java_re java_re   8181 Dec 19 18:21 jre1.8.0_161/bin/tnameserv
-rwxr-xr-x  0 java_re java_re   7941 Dec 19 18:21 jre1.8.0_161/bin/keytool
-rwxr-xr-x  0 java_re java_re 132911 Dec 19 18:21 jre1.8.0_161/bin/javaws
lrwxrwxrwx  0 java_re java_re      0 Dec 19 18:21 jre1.8.0_161/bin/ControlPanel -> jcontrol
-rwxr-xr-x  0 java_re java_re   7734 Dec 19 18:21 jre1.8.0_161/bin/java
-rwxr-xr-x  0 java_re java_re    49341 Dec 19 18:21 jre1.8.0_161/lib/amd64/libinstrument.so

Not sure how you built your image but server-jre-8u161-linux-x64.tar.gz (SHA256: eb5776cacfd57fbf0ffb907f68c58a1cc6f823e761f4e75d78a6e3240846534e) when uncompressed does contain jar.
find . -name jar
./bin/jar
What you shouldn't have, yet you show in your results, is  either javaws or jcontrol.  I'd recommend downloading the serverJRE again, manually uncompressing, and seeing if you can find jar.

I apologize, I think someone may have taken some other jdk/jre download and renamed it so that the java-8 build would pick it up.  I re-downloaded serverjre, rebuilt java-8 and all was fine.


Algorithm used in goose ?

Hi,
I am working on my undergrad research thesis and using goose extractor.Goose is really a commendable tool. However, I have a mid term presentation regarding my thesis and I will have to explain the algorithm used by goose.
Can you please tell me the algorithm or how goose extracts information from html pages.
Thanks,
Faisal

Since they report that the code was initially based on readability, maybe this is a good place to start:
https://code.google.com/p/arc90labs-readability/source/browse/trunk/js/readability.js#711

ok thanks will look into it.
but do you know about any research paper or algorithm used by them

No - I think they use an heuristic approach (http://en.wikipedia.org/wiki/Heuristic). Web pages are messy stuff, and its unlikely that an elegant mathematical algorithm would give good results.
That said, I saw a piece of the code and it was something like: "for each paragraph, compute a score that  tells you how likely this paragraph is actual content".
For example, if we were trying to find the content of this Github page, we could suppose that finding the words "Terms, Privacy, Contact" meant that we were looking at the footer, not content.
HTH

ok thanks


Supported Destinations

Please make it clear that OneDrive or Teams are supported destinations. This is not documented anywhere here and is only obvious when users click through the Migration Manager task wizard.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 210e3fb6-665e-a4e6-7b5e-fe3776ec1635
Version Independent ID: 80b1c7f6-736f-70a4-ae6c-503d64e94a26
Content: Get started with Migration Manager  - SharePoint Online - Migrate to SharePoint and OneDrive
Content Source: migration/mm-get-started.md
Service: sharepoint-online
GitHub Login: @JoanneHendrickson
Microsoft Alias: jhendr

@cabtilx Thank you for submitting feedback and contributing to the docs. We are currently investigating this.

@cabtilx thank you for reaching out and helping improve MS Docs. Please can you be a bit more specific about which section of this article needs to be updated with that information so that I can assist further.

Hi @lindspea
Where it says "Access to the destination: You must either be a global admin or SharePoint admin to the Microsoft 365 tenant where you want to migrate your content." This suggests the destination has to be SharePoint. OneDrive is not mentioned on the document at all yet this is also a valid destination.

@cabtilx  Thank you for submitting feedback. We understand that this issue has been resolved.
Please feel free to re-open this issue if there is a specific area of the docs that we can improve or make better. Thank you.


Modify agents to support SMTP protocol

For agents:

upload
geo outlier

Modify PATTERN to extract IP from data.
Different methods possible:

créer une classe Abstract puis différentes implémentations
mettre le pattern dans le fichier de configuration (Profile)

But: how to make distinction between sent and received e-mails?

Implement SMTP Reprocess that reprocesses raw email data saved to the MARK db to more complex raw email data that parses the different headers for further passes them to SMTP agents


Few grammatical errors

In #align-items section, align-items: flex-end; property, redundant underscore:
By default, the cross axis is vertical. This means the flexbox items will be aligned vertically at the _bottom.
In #position section, all properties text description refer to yellow block, while block itself is reddish:
It also makes the element positioned: it will act as an anchor point for the absolutely positioned yellow block.
Overall, very useful project for CSS study, thank you.

Thanks!


flutter-analyze bot (or similar) should analyze flutter/cocoon

Some flutter rolling process somewhere analyzes flutter/cocoon. If analysis reports anything, a bot turns red.
Given this situation, the flutter-analyze bot (or something similar) should analyze flutter/cocoon (presumably just on analyzer and _fe_analyzer CLs).
I think the philosophy is that anything which can break the flutter roll, and which will strongly prompt a rollback, must be presubmitted with a bot, like flutter-analyze. Without this check, nothing stops a swift roll-forward to re-break.

CC @devoncarew

CC @devoncarew

Once https://dart-review.googlesource.com/c/recipes/+/186780 lands hhh will flutter-plugins that should analyze flutter/cocoon as well.

Closing this issue in favor of the fix in 5fe21f2ec1415aa45653eea2a7b9c186dc6d6722. I think the flutter-analyze bot is good for a 95% gut check of analysis changes to flutter repos, but the HHH bot will be more canonical.


[DNM] Revert "Implement several peephole optimizations to unblock further o…

…ptimizations of autodiff code (#60520)"
This reverts commit 2f5492f572818e728e3358c13315c2d4e5c9be64.

@swift-ci please build toolchain Windows platform

Testing to make sure this repairs windows builds.

From the log:
[4/5][ 80%][0.418s] Install the project... -- Install configuration: "Release" -- Installing: T:/Library/Developer/Toolchains/unknown-Asserts-development.xctoolchain/usr/lib/swift/windows/ArgumentParser.lib -- Installing: T:/Library/Developer/Toolchains/unknown-Asserts-development.xctoolchain/usr/bin/ArgumentParser.dll -- Installing: T:/Library/Developer/Toolchains/unknown-Asserts-development.xctoolchain/usr/lib/swift/windows/x86_64/ArgumentParser.swiftdoc -- Installing: T:/Library/Developer/Toolchains/unknown-Asserts-development.xctoolchain/usr/lib/swift/windows/x86_64/ArgumentParser.swiftmodule -- Installing: T:/Library/Developer/Toolchains/unknown-Asserts-development.xctoolchain/usr/lib/swift/windows/ArgumentParserToolInfo.lib -- Installing: T:/Library/Developer/Toolchains/unknown-Asserts-development.xctoolchain/usr/bin/ArgumentParserToolInfo.dll -- Installing: T:/Library/Developer/Toolchains/unknown-Asserts-development.xctoolchain/usr/lib/swift/windows/x86_64/ArgumentParserToolInfo.swiftdoc -- Installing: T:/Library/Developer/Toolchains/unknown-Asserts-development.xctoolchain/usr/lib/swift/windows/x86_64/ArgumentParserToolInfo.swiftmodule
This is building ArgumentParser now, but there is another unrelated error. So this confirms the SILCombine changes were breaking the build.

Created an issue with some more details here  - https://github.com/apple/swift/issues/61731

@swift-ci test

Since the tests passed, and the toolchain has been broken for ~1w, going to mark this as ready for review and merge to enable the next set of changes.

CC: @asl @BradLarson @CodaFi (Anton/Brad for the reverted bits for AD, Robert for the Syntax issues).