Program deployment and associated register_program contract registry predicate.

Once the new program Predicate type is ready to land with the updated Program DAG model, the contract registry should be updated in the node to allow Solutions to register Programs independently of Predicates.
Programs can be stored using a unique key within the existing contract registry.
Programs will need to be deployed either in the same Solution that their dependent Predicate(s) are deployed in, or in any earlier Solution.
The contract registry mutation for deploying a program will likely look something like this:
key: [2, <program-ca>]
value: [len_bytes, <program-bytecode-padded>]

where 2 is the programs storage prefix within the contract registry.
Validation
Program deployment validation will involve ensuring:

The content address that appears in the key matches the actual program content address (i.e. sha256 of the program bytecode).
The length in bytes does not exceed Program::MAX_SIZE.

I think the program registry should be a separate contract as it's kind of unrelated to the contract registry. Contracts are sort of built on top of programs but that might not be the only usecase for programs.


Make clear only one fluid-container is needed

Pre-Submission Checklist

[x] Your pull request targets the staging branch of FreeCodeCamp.
[x] Branch starts with either fix/, feature/, or translate/ (e.g. fix/signin-issue)
[x] You have only one commit (if not, squash them into one commit).
[ ] All new and existing tests pass the command npm run test-challenges. Use git commit --amend to amend any fixes.

Type of Change

[x] Small bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds new functionality)
[ ] Breaking change (fix or feature that would change existing functionality)
[ ] Add new translation (feature adding new translations)

Checklist:

[ ] Tested changes locally.
[ ] Closes currently open issue (replace XXXX with an issue no): Closes #XXXX

Description
Really simple change in wording to make it less confusing.

@JelteF:
Just to confirm, not sure if this will be confused that all elements should be closed vs now just one to be closed?
How was this confusing earlier?

The old wording implies that there should be more than one div elements. But this is not the case: Only a single container-fluid element needs to be added.


[@ukic/react]: npm script to copy web-components core CSS to react CSS doesn't create/copy file

Summary of the bug
When building the web-components and react packages, the core CSS file should get copied across from web-components to react. This doesn't seem to be the case.
🪜 How to reproduce
Tell us the steps to reproduce the problem:

Reference @ukic/react/dist/core/core.css in React application

🧐 Expected behaviour
Core CSS file should be available and style components.
📸 Screenshots or code

🖥 Desktop

OS: N/A
Browser: N/A
Version: N/A

📱 Mobile

Device: N/A
OS: N/A
Browser: N/A
Version: N/A

Additional info
Current workaround is to install @ukic/web-components and reference the core.css file from there (e.g. @ukic/web-components/dist/core/core.css
Offending line:
copy:css": "echo 'Copy core css from: @ukic/web-components' && mkdirp -p ./dist/core && ncp ../web-components/dist/core/core.css ./dist/core/"

This looks to be the issue: https://stackoverflow.com/questions/38637023/node-js-and-ncp-module-fails-to-copy-single-file


two button blocks doesn't create new simulator

I created a second button variable (b2) and dragged a second button simulator out, but it didn't create a new simulator. It was the same as "button 1"'s simulator (MZ57).  My expectation is to get a new button simulator.

Not implemented yet, it vaporware

From: Tom Ball @.>
Sent: Saturday, May 29, 2021 10:40:00 PM
To: microsoft/jacdac @.>
Cc: Peli de Halleux @.>; Assign @.>
Subject: Re: [microsoft/jacdac] two button blocks doesn't create new simulator (#415)
Assigned #415https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fmicrosoft%2Fjacdac%2Fissues%2F415&data=04|01|jhalleux%40microsoft.com|b6c24272b98c4fafd32008d9232d5e53|72f988bf86f141af91ab2d7cd011db47|1|0|637579500037386081|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=n4gEmg7vJmKLN2ax0VLdnqUeAlQfO9ktmh27xbjjv8M%3D&reserved=0 to @pelikhanhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fpelikhan&data=04|01|jhalleux%40microsoft.com|b6c24272b98c4fafd32008d9232d5e53|72f988bf86f141af91ab2d7cd011db47|1|0|637579500037396074|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=0kmttL8se6KvupJErbPBqQ4%2FDiIfBVdEmnU40sh7bnw%3D&reserved=0.
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHubhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fmicrosoft%2Fjacdac%2Fissues%2F415%23event-4816734638&data=04|01|jhalleux%40microsoft.com|b6c24272b98c4fafd32008d9232d5e53|72f988bf86f141af91ab2d7cd011db47|1|0|637579500037406069|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=Y2NoRz3qKvFRAkhrGfvYOMWMvv3iyOuUdtMyyO9SDBM%3D&reserved=0, or unsubscribehttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAA73QKLMLYURT73SULBAUBDTQHFTBANCNFSM45Y7GIHA&data=04|01|jhalleux%40microsoft.com|b6c24272b98c4fafd32008d9232d5e53|72f988bf86f141af91ab2d7cd011db47|1|0|637579500037406069|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=RtWYpbFPz6E4zX8XWEay58qhrqRhOTzYR4wnpSbdnkc%3D&reserved=0.


[driver] API for getting performance traces

Add support for starting/stopping tracing
Make scroll perf test use it

LGTM (modulo travis being mad).
How is the data sent over the wire? Is it more like this:
 { 'profile': { ... } }

...or like this?:
 { 'profile': '{...}' }

I couldn't tell from this side of the code.

How is the data sent over the wire?

Right now it in chrome://tracing JSON format, but switching to Dart VM service protocol soon.

I meant more to ask whether the data is sent as a string (which happens to contain JSON) or whether it's sent as part of the service protocol JSON structure.

This message was created automatically by mail delivery software.
A message that you sent could not be delivered to one or more of its
recipients. This is a temporary error. The following address(es) deferred:
<EMAIL_ADDRESS>Domain zyapps.com has exceeded the max emails per hour (411/400 (102%)) allowed.  Message will be reattempted later
------- This is a copy of the message, including all the headers. ------
Received: from github-smtp2-ext7.iad.github.net ([<IP_ADDRESS>]:54389 helo=github-smtp2a-ext-cp1-prd.iad.github.net)
by serveur.ex2-p10.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256)
(Exim 4.86_1)
(envelope-from<EMAIL_ADDRESS>id 1afmMQ-000ag0-Im
for<EMAIL_ADDRESS>Tue, 15 Mar 2016 11:38:05 +0100
Date: Mon, 14 Mar 2016 15:50:38 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com;
s=pf2014; t=1457995838;
bh=UNmVB4nr7gcAppDJaSMYAHoEk4z6qhoYNQDNMSTb0nw=;
h=From:Reply-To:To:Subject:List-ID:List-Archive:List-Post:
List-Unsubscribe:From;
b=Mec/jrXt5xPtAzPOalaydCXasYActTrtD9WJXjmCbX9LBNkKUf+o2uy1b4Ga9bueO
KGy8Ej+gGTa63g2jg8aLuUuK8xsFkHMivX+b0EwUKgirO2KIe6On+FFMJH8JmVfOlz
hlcfjL16YjkvV3IAG2Ym4MMkjSQPOuyVvDQRZyZg=
From: Yegor<EMAIL_ADDRESS>Reply-To: flutter/flutter<EMAIL_ADDRESS>To: flutter/flutter<EMAIL_ADDRESS>Message-ID<EMAIL_ADDRESS>Subject: [flutter] [driver] API for getting performance traces (#2689)
Mime-Version: 1.0
Content-Type: multipart/alternative;
boundary="--==_mimepart_56e7403ed0711_252d3fe6416df29c328d0";
charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: yjbanov
X-GitHub-Recipient: yanndupuy
List-ID: flutter/flutter <flutter.flutter.github.com>
List-Archive: https://github.com/flutter/flutter
List-Post<EMAIL_ADDRESS>List-Unsubscribe<EMAIL_ADDRESS>https://github.com/notifications/unsubscribe/AA3w3Ag2Z2Wls_dGIKG2Sk_jXleRVut0ks5pteY-gaJpZM4HwjUI
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address<EMAIL_ADDRESS>X-Spam-Status: No, score=-3.3
X-Spam-Score: -32
X-Spam-Bar: ---
X-Ham-Report: Spam detection software, running on the system "serveur.ex2-p10.com",
has NOT identified this incoming email as spam.  The original
message has been attached to this so you can view it or label
similar future email.  If you have any questions, see
root@localhost for details.
Content preview:  - Add support for starting/stopping tracing - Make scroll
perf test use it You can view, comment on, or merge this pull request online
at: https://github.com/flutter/flutter/pull/2689 [...]
Content analysis details:   (-3.3 points, 5.0 required)
pts rule name              description

-5.0 RCVD_IN_DNSWL_HI       RBL: Sender listed at http://www.dnswl.org/, high
trust
[<IP_ADDRESS> listed in list.dnswl.org]
-0.0 RCVD_IN_MSPIKE_H3      RBL: Good reputation (+3)
[<IP_ADDRESS> listed in wl.mailspike.net]
1.1 DATE_IN_PAST_06_12     Date: is 6 to 12 hours before Received: date
-0.0 SPF_PASS               SPF: sender matches SPF record
0.7 HTML_IMAGE_ONLY_20     BODY: HTML: images with 1600-2000 bytes of words
0.0 HTML_MESSAGE           BODY: HTML included in message
-0.1 DKIM_VALID_AU          Message has a valid DKIM or DK signature from author's
domain
0.1 DKIM_SIGNED            Message has a DKIM or DK signature, not necessarily valid
-0.1 DKIM_VALID             Message has at least one valid DKIM or DK signature
-0.0 RCVD_IN_MSPIKE_WL      Mailspike good senders
X-Spam-Flag: NO
----==_mimepart_56e7403ed0711_252d3fe6416df29c328d0
Content-Type: text/plain;
charset=UTF-8
Content-Transfer-Encoding: 7bit

Add support for starting/stopping tracing
Make scroll perf test use it

You can view, comment on, or merge this pull request online at:
https://github.com/flutter/flutter/pull/2689
-- Commit Summary --

[driver] API for getting performance traces

-- File Changes --
M examples/stocks/test_driver/scroll_perf.dart (2)
M examples/stocks/test_driver/scroll_perf_test.dart (39)
M packages/flutter_driver/lib/src/driver.dart (58)

-- Patch Links --
https://github.com/flutter/flutter/pull/2689.patch
https://github.com/flutter/flutter/pull/2689.diff

Reply to this email directly or view it on GitHub:
https://github.com/flutter/flutter/pull/2689
----==_mimepart_56e7403ed0711_252d3fe6416df29c328d0
Content-Type: text/html;
charset=UTF-8
Content-Transfer-Encoding: 7bit

Add support for starting/stopping tracing
Make scroll perf test use it

You can view, comment on, or merge this pull request online at:
  https://github.com/flutter/flutter/pull/2689
Commit Summary

[driver] API for getting performance traces

File Changes

M
examples/stocks/test_driver/scroll_perf.dart
    (2)

M
examples/stocks/test_driver/scroll_perf_test.dart
    (39)

M
packages/flutter_driver/lib/src/driver.dart
    (58)

Patch Links:

https://github.com/flutter/flutter/pull/2689.patch
https://github.com/flutter/flutter/pull/2689.diff

—Reply to this email directly or view it on GitHub.

----==_mimepart_56e7403ed0711_252d3fe6416df29c328d0--

@Hixie: the service protocol does not have a schema for responses other than it has to be some JSON. package:json_rpc_2 that's used behind the scenes to talk to the service protocol automatically deserializes all responses from plain strings to their JSON equivalents (primitives, lists and maps). In this case it so happens that the returned JSON is a Map simply because chrome://tracing format makes it a Map. Currently FlutterDriver does not add any more processing of the response, and just passes the map through.

So it's preparsed and handed over as a data structure, ok.
If we're expecting to only deal with this data outside of the app, it might be worth considering not preparsing it. Read it in as an opaque (UTF-8) string, pass it over the protocol as a raw string, save it to disk as a string. No need to pay the JSON parsing/serialising/parsing/serialising cost.

I confirmed with @johnmccutchan that we will continue receiving the trace in chrome://tracing format, so I can put more structure on it already. As for serialization cost, we pay that cost on the localhost machine, not on the device, so it has no impact on the runtime of the Flutter app.
Logged https://github.com/flutter/flutter/issues/2713 to follow-up.


[Question] Extracting full error into a variable

Hi,
Just wondering if this is possible. By the way, I have hooks attached to the logger.
Thanks
message := logrus.WithContext(r.Context()).Warning(err)
fmt.Println(message)

So the content of the message variable would be what logrus would log.
For instance: {"env":"dev","level":"error","message":"context deadline exceeded","request_id":"338a6e89","request_method":"GET","time":"2020-07-11T22:07:47+01:00"}

Warning(...) doesn't return anything so don't know what you're getting at.
Can you elaborate on this a little more?

I know it doesn't return anything. I was asking if we could somehow extract the message into a variable instead of outputting it. Maybe there was a flag, arg, method etc. that I am not aware of.

Logrus as a logging library is not intended to be used as a formatter. Therefore it doesn't have methods to achieve that.
Said that, if I had to implement that behaviour, and not being responsible for what I'm about to say nor the consequences of implementing this... I would use channels:
package main

import (
  "fmt"
  "github.com/sirupsen/logrus"
)

type Hook struct {
	Writer    chan string
	LogLevels []logrus.Level
}

func (hook *Hook) Fire(entry *logrus.Entry) error {
	line, err := entry.String()
	if err != nil {
                fmt.Printf("error: %+v", err)
		return err
	}
	hook.Writer <- line
	return nil
}

func (hook *Hook) Levels() []logrus.Level {
	return logrus.AllLevels
}

func main() {
 	hook := Hook{Writer: make(chan string, 1)}
  	logrus.SetFormatter(&logrus.JSONFormatter{})
  	logrus.AddHook(&hook)
  	logrus.WithContext(context.Background()).Warning("This is a warning")
  	logged := <- hook.Writer
	fmt.Printf("Logged: %s", logged)
}

Things to consider with this:

Don't do it. Seriously. Use a function to custom format the message before doing this.
If you don't read a message from the channel for each message you or someone writes in the logger, you'll get a deadlock... you can increase the buffer but that's just gonna buy you some time.
If there's concurrent logging happening you might end up with a message that's not what you just wrote in the logger.

I just discovered that you can use the test hook for that purpose:
package main

import (
  "fmt"
  "github.com/sirupsen/logrus"
   logrus_test "github.com/sirupsen/logrus/hooks/test"
)

func main() {
	logrus.SetFormatter(&logrus.JSONFormatter{})
 	hook := logrus_test.NewGlobal()
   	logrus.AddHook(hook)
  	logrus.WithContext(context.Background()).Warning("This is a warning")
  	logged, _ := hook.LastEntry().String()
        // Prevent the test hook to keep storing all the logs.
	hook.Reset()
	fmt.Printf("Logged: %s", logged)
}


Assertion `pindexPrev' failed.

Hello, my Namecoin got a problem
./namecoind
Namecoin server starting
namecoin@server ~/namecore/src $ namecoind: main.cpp:3004: bool AcceptBlockHeader(const CBlockHeader&, CValidationState&, CBlockIndex**): Assertion `pindexPrev' failed.
I already tried
namecoin@server ~/namecore/src $ ./namecoind -reindex
but I got the same result.
Any advice?

This is strange.  As far as I can tell, the code in question is the same that Bitcoin uses.  You can try running the latest version of the Github sources, in case you don't.  Possibly this is a bug that was already fixed.  Apart from that, it could be some kind of damage to your blockchain directory - if you do not mind the trouble, you can try redownloading the blockchain.
If the problem presists even after a fresh download, can you please post the last lines of debug.log?  Also, if you can, it would be great to get a recipe for reproducing the crash so I can look at it with a debugger.

Hi @Dobredan, were you able to get this fixed?

Closing this as likely obsolete.  Feel free to reopen if the issue still persists.


Outliers module not working

I have tried to chain or import outliers with many different methods. I have tried importing tukey directly as well. Everything results in  error:
`---------------------------------------------------------------------------
AttributeError                            Traceback (most recent call last)
 in
----> 1 outliers = df_csv.outliers.tukey("cnt").select().table()
C:\Spark\spark-3.0.0-preview-bin-hadoop2.7\python\pyspark\sql\dataframe.py in getattr(self, name)
1300         if name not in self.columns:
1301             raise AttributeError(
-> 1302                 "'%s' object has no attribute '%s'" % (self.class.name, name))
1303         jc = self._jdf.apply(name)
1304         return Column(jc)
AttributeError: 'DataFrame' object has no attribute 'outliers'
`

Hi @cemsa1992 ,
Thanks for the report. I am going to push a fix in a couple of hours.

@cemsa1992,
I am pushing 2.2.29 to pip. It'll be available in the next hour.

@cemsa1992 2.2.29 is now available. Please let me know if this fix the problem.

@cemsa1992 2.2.29 is now available. Please let me know if this fix the problem.

It is fixed indeed. Thanks! I recently found this library and it is outstanding!


Add custom Ansible lint rule for mode arguments

Using non-string modes can be unpredictable in atypical cases. It is
usually safer to just use strings, whether representing the typical
numeric representation of permissions or the symbolic representation.
This is a lint check to enforce the opinions from #441.

Do you have any examples of why quoted vs leading zero is better? Both the Ansible and Ansible Lint docs suggest they're equivalent, and we only noted it as a bug in 2.1.

The docs say:

You must either add a leading zero so that Ansible's YAML parser knows it is an octal number (like 0644 or 01777) or quote it (like '644' or '1777') so Ansible receives a string and can do its own conversion from string into number.

So just to enforce consistency and prevent incorrect interpretation. directory_mode still gives warnings about how its parsing it as 493 or whatever. Seems like the kind of detail that can get missed in review and checking for a leading 0 is harder in a lint rule since the YAML has already been parsed :)


Provide email generation overview

Overview
Test emails were submitted into production landing page database. An analysis must be done of what patterns were used to gernerate emails. This information will be used to deduce which emails in production database are legitimate and which are test submissions.
If test submissions are still being input into prod environment please raise this to PM's immediately.
Action Items

[ ] Provide overview of how test e-mails were generated in a word doc to PM's

Resources/Instructions

@ladissi There is a test for the footer subscription field that uses the "faker" package to generate random emails.  There isn't a clear pattern that would distinguish those fake emails from real ones.


Add comments to queries

For purposes of auditing and profiling, I would like to add comments to some queries.
(For clarity, this type of comments: https://docs.exasol.com/sql_references/basiclanguageelements.htm#Comments_in_SQL)
For cases where the query is directly executed, like when running connection.execute("SELECT * FROM FOO"), this is easy.
However, for import_* and export_* function, as well as for metadata access functions, the actual query is built in pyexasol, without possibility for us to add comments to it.
Is that something that you'd be willing to integrate in pyexasol? If so, I'd be willing to help

Yep, it should be easy to implement using import_params and export_params.
Do you prefer to have comment in the beginning, at the end or somewhere in the middle of query? :)

beginning is fine :)
So, for import, you'd recommend adding a key to import_params and use it here: https://github.com/badoo/pyexasol/blob/da486a18313d3cd4b40280ade66f5f21b0c2f120/pyexasol/http_transport.py#L161
for export, use the same idea here: https://github.com/badoo/pyexasol/blob/da486a18313d3cd4b40280ade66f5f21b0c2f120/pyexasol/http_transport.py#L105
And add a bit of documentation here: https://github.com/badoo/pyexasol/blob/da486a18313d3cd4b40280ade66f5f21b0c2f120/docs/HTTP_TRANSPORT.md#parameters
Would that be sufficient?

Extra argument comment for export_params, import_params.
Additional condition in query builders for EXPORT and IMPORT to use the extra argument.
Validation, to make sure comment will not contain \n, */ or other ways for SQL injection.
Documentation.
A few lines in http_transport examples.

Thank you.

Live in 0.16.1. Enjoy! :)

That was fast! thanks :)


Reader seems to accumulate annotations between invocations

Annotations should not accumulate  between new instances of IonReader.
r = require("ion-js").makeReader("ann1a::ann1b::10 ann2::11"); r.next(); r.annotations()
[ 'ann1a', 'ann1b' ]
> r = require("ion-js").makeReader("ann1a::ann1b::10 ann2::11"); r.next(); r.annotations()
[ 'ann1a', 'ann1b', 'ann1a', 'ann1b' ]
> r = require("ion-js").makeReader("ann1a::ann1b::10 ann2::11"); r.next(); r.annotations()
[ 'ann1a', 'ann1b', 'ann1a', 'ann1b', 'ann1a', 'ann1b' ]

Should verify reader's beahviour when for the same reader instance we navigate to multiple values that have annotations. The API should return the annotations of the current value being pointed to by the reader.

This also seems to be masking (via causing the test suite to never reach cases where the first annotation is $ion_symbol_table) bugs in the symbol table parsing.

This has been solved on PR #118


Path bar doesn't show correctly when being opened externally

Explain the bug
When files is open through external programs like "open file location" in windows start menu the path doesn't show the full folder names it when through adding ~1 or ~3 to the end.
Expected behaviour
The path bar show show it location like if I manually navigated to it
Screenshots

System Information

Version: <IP_ADDRESS>
OS Version: 10.0.19043.1110

Still and issue in <IP_ADDRESS>

Merging with #6190


⚠ Avatar API Endpoint has degraded performance

In 738de79, Avatar API Endpoint (https://avatar.roblox.com/v1/avatar-rules) experienced degraded performance:

HTTP code: 200
Response time: 1159 ms

Resolved: Avatar API Endpoint performance has improved in af9637a.


Cross-context (API+UI) refresh token invalidation (regression from v2.18.0)

Problem description
This is a bug which has been frustrating the heck out of me that is related to the 2.18.0 release, and I can finally articulate what is going on!
Consider, a situation where you are in parallel experimenting/testing with guardian on the UI and API (or different browsers)
As per the new authentication measures in 2.18.0 there is a hard requirement for the generation of a refresh token before the access token can be created.
There is an issue where that is problematic.
If you are generating new refresh tokens through the API (or potentially in a different browser) the old refresh token loses the ability to generate new access tokens.
A screenshot from the policies view:

This basically happens under the conditions:

Multiple refresh tokens are generated under different context
The last refresh token has context to the user object
(For UI token) After default access token timeout of 60 seconds a new access token can't be generated as the previous refresh token has been overwritten.

This is because of these lines
https://github.com/hashgraph/guardian/blob/main/auth-service/src/api/account-service.ts#L156
This is exacerbated due to this line:
https://github.com/hashgraph/guardian/blob/main/auth-service/src/api/account-service.ts#L185
As the filter is looking for both the username, and the refresh token id (that may not exist on the user object due to it being overwritten)
Step to reproduce
Steps to reproduce the behavior:

UI Login as user
Use API to login as same user (or potentially different browser)
Wait 60 seconds
See DID missing error

Expected behavior
Looking into the code, it seems that the refresh token should last for a year, this is fine as it is configurable, but losing login context (or a user potentially feeling they lost all their data) isn't great UX.
In terms of code behaviour, I would presume that this change would fix the issue:
const user = await new DataBaseHelper(User).findOne({refreshToken: decryptedToken.id, username: decryptedToken.name});

to
const user = await new DataBaseHelper(User).findOne({username: decryptedToken.name});

The reason why this might be okay, is that the expire at decoding happens on the line above, so a refresh token, would last for the period of time by default.
As this is authentication related, it requires review from more people.
More context
I am unsure to whether this could be related to this issue https://github.com/hashgraph/guardian/issues/3450, as the lock up of the system could be related to a invalid access, token that is in an infinite loop state.

It could be more appropriate to examine if there are any other authentication libraries that are more industry standard in terms of sec and auth, or perhaps we will reach a state where email/pass auth isn't even required for individual guardian instances.

Hi @mattsmithies, thank you for the detailed description - much appreciated!
Currently Guardian internals do not support multiple simultaneous user sessions, as this can result (if such a user is not being careful) in complex workflow issues. So this session 'kick out' functionality is there by design, however what is clear from your description is that it is currently poorly done. Guardian should indicate to the user that they have been disconnected because another session was established, and redirected to the login page. We will address this as a matter of urgency.
It is definitely possible to make Guardian workflow engine multi-session safe if there is a business need for it. This would be a project, and thus needs to be discussed and prioritised as per the usual procedure.

Maybe I am misremembering, but Guardian never allowed multiple simultaneous user sessions anyway? We also came across this behaviour while doing some manual testing (as our application uses Guardian API exclusively but we sometimes check the UI); I agree that the user should be made aware that they have been disconnected and redirected to the login page.

That's correct @armarik, it was never allowed.


Catalog integration in Pipeline

[ ] Publish Catalog Template Step:

users select a catalog,
users put a chart directory in the source code repository,
variable substituion available in the chart files,
users provide git deploy key via secrets,
as the result, a new version of the catalog template will be added in catalog repository.
example yaml would be:steps:
- publishCatalogConfig:
    path: <path-to-chart-directory>
    catalog: <catalog name/id>
    version: <version-to-publish>
  envFrom:
    sourceName: my-secret
    sourceKey: deploy-key
    targetKey: ALIAS_ENV

[ ] Apply Catalog App Step:

users select a catalog,
users fill in answers, like how they do deploying an app,
variable substitution available in the answers,
example yaml would be:steps:
- applyCatalogConfig:
    catalog: <catalog name/id>
    version: <version-to-publish>
    name: <name>
    targetNamespace: <ns>

[ ] Publish Catalog Template Step:

users provide git deploy key via secrets,
users put a chart directory in the source code repository,
variable substituion available in the chart files.
example yaml would be:steps:
- publishCatalogConfig:
    path: <path-to-chart-directory>
    catalog: <catalog name/id>
    version: <version-to-publish>
  envFrom:
    sourceName: my-secret
    sourceKey: deploy-key
    targetKey: DEPLOY_KEY

as the result, a new version of the catalog template will be added in catalog repository.

[ ] Apply Catalog App Step:

users select catalog
users fill in answers, like how they do deploying an app.
variable substitution available in the answers.
example yaml would be:steps:
- applyCatalogConfig:
    catalog: <catalog name/id>
    version: <version-to-publish>
    name: <name>
    targetNamespace: <ns>

Verified the following cases with rancher/rancher:master 1/31/19

Publish Catalog App

Validate run the pipeline under Gitlab, Github, Bitbucket
Validate check rules
Validate HTTP(S) or SSH protocol
UI compatible with multiple languages
Publish a new version to repo using edit config
Publish a new version to repo using edit yaml
Validate Git Branch
Publish multiple versions
Set multiple steps to publish catalog app
Set the wrong parameters
Run multiple times without source code changes
Modify the source and republish
Validate the results of the run

Deploy Catalog App

Validate run the pipeline under Gitlab, Github, Bitbucket
Validate UI text box
Deploy catalog app using edit config
Deploy catalog app using edit yaml
Validate deployment results
Add multiple steps
Set the wrong yaml
Validate the global/cluster/project level private catalog
Validate upgrade app

Currently, there is still an issue #17511 that is open

Version: master 2.2 (2/12/19)
Confirmed fix.


Add tooltips for settings with unclear description

For example, should add a tooltip for the common.awayPhp setting with note that it specifically bypasses away.php redirects.

Closed in a0d5ed264ab0caaaec3b6bd23721620cdb18655e.


Picker returns empty array of assets when iPhone 13 Pro raw (.dng) photo is selected [🐛]

Description
When I select raw photo on iPhone 13 Pro (.dng extension), the assets array is empty.
How to repeat issue and example

Create a raw photo on iPhone 13 Pro.
Select photo
Array is empty

Solution
Add iPhone 13 Pro RAW (.dng) support.
Additional Information

Image Picker version: ^4.8.2
React Native version: 0.67.2
Platform: iOS
Development Operating System: Mac OS Montrey 12.3.1
Dev tools: Xcode 13.3.1, iOS 15.4

@wmatyjanomtek I don't have a iPhone 13 Max, so you are going to need to do some debugging to see where exactly the code is failing in the objective-c. You could also try my branch here, which updates the request photo method, to see if it fixes the issue: https://github.com/react-native-image-picker/react-native-image-picker/pull/1981 then let us know

@lukebrandonfarrell thank you for your answer. You could just put the .dng file into any iPhone and try to pick it. I can event send you one ;)

Anyway, I'll do the debugging.

@wmatyjanomtek Please send one if you can, and try with my latest branch linked above

@wmatyjanomtek Also, since I don't have a 12 or 13, could you get me a video of taking a DNG picture then picking it from library? So I can get an idea of the flow here.

@lukebrandonfarrell it's a little bit more complicated - the picture you got is the picture of my colleagues' wardrobe. 😆  He's a QA and has a lot of different fancy devices which I don't have (similar to you as I can see ;) ) So, I don't know what's the flow of taking a photo and I don't really have an option to show it to you. What I did with him was exactly what I did with you - he sent me an image in a specific format and I just saved it and tried to pick it. It didn't work. :)

@lukebrandonfarrell the feature works on your branch! 😮  is it going to be merged in some near future?

@wmatyjanomtek Hopefully, we are running it on our production application and waiting for a review from @Johan-dutoit

I was mostly waiting for @lukebrandonfarrell to give me the go ahead :D

Specifically

Using Sentry to determine if this reduces the frequency of the issue.

Sounds good @Johan-dutoit, we should have some data soon! :)

Any updates here?

Any updates?

Any updates?


Flashing from with WSL is also possible

It's not much more troublesome than flashing from Windows.

Both need the CP210x driver to be installed
Instead of flashing tools, the usbip-win USB/IP server needs to be installed

WSL has usbip within it, and the two are intended to work together. I would add a mention about this to the "Troubleshooting" section:
-build inside WSL and only flash the compiled MCU ELF file from outside of WSL.
+build inside WSL and only flash the compiled MCU ELF file from outside of WSL. A third is to use USB/IP to show the development board within WSL itself, and flash it from there <sub>[ESP32-WSL](https://github.com/lure23/ESP32-WSL)</sub>. Pick your poison.

Should I send this as a PR?  Is it too much to have the repo link included?

Maybe we could add a note saying that it's possible, but I don't think we should cover it in too much detail, maybe just add the note with a link.

Then should I just proceed and file a PR with the diff above?
On details - absolutely not. There are already a bit too many different ways to flash a board and it's kinda confusing. But I think for WSL users being able to flash from within that environment is the smoothest way, and worth mentioning.

I see that there are different methods: https://blog.golioth.io/usb-support-in-wsl2-now-with-a-gui/?hss_channel=tw-1348350211681251328

That blog post shows two GUI's to control the USB/IP.

Hopefully they help the remaining Windows devs who prefer something graphical over using the commandline

I did not know such exist - but... I don't see that as being very essential. The auto-attach feature was mentioned, and that is potentially useful. Haven't used that one, either.


RigidBody2D mouse_entered, mouse_exited, on_input_event signals dont work

Godot version
4.0.3.stable
System information
Fedora Linux 37
Issue description
rigidbody is pickable, but signals dont fire
Steps to reproduce
scene:
RigidBody2D
---Sprite2D
---CollisionShape2D
rigidbody is pickable, connect mouse_entered, mouse_exited, on_input_event signals
Minimal reproduction project
N/A

This works fine for me on v4.0.3.stable.official [5222a99f5]
It is always helpful to provide a Minimal reproduction project, so that it is easier and quicker to pinpoint the problem.
Have you made sure, that the Viewport has Object Picking enabled?

my bad, connected signal body_entered was connected to method i deleted, so i disconnected it and everything works.
there was no warnings or errors shown, maybe add some errors when signal connected to nothing.

maybe add some errors when signal connected to nothing

That sounds like a good idea for improving usability. Feel free to report this separately.

actually, i tested again, but this time it works even if signal connected to nothing. Problem in main project was Viewport Object Picking disabled.

my bad, signal body_entered was connected to method i deleted, so i disconnected it and everything works
maybe script did not connected right then.


[Bug] Cannot specify pivot field as optional

Bug report
What I did
I have created a repeatable field using the following:
CRUD::field([
  'name' => 'attachments',
  'label' => 'Attachments',
  'type' => 'relationship',
  'subfields' => [],
  'pivotSelect' => [
    'label' =>  'Select attachment','
    'allows_null' => true,
    'inline_create' => [
      'entity' => 'attachment',
      'modal_route' => route('attachment-inline-create')
    ],
  ],
  'new_item_label' => 'Add new item',
  'init_rows' => 1,
  'min_rows' => 1,
]);

What I expected to happen
The pivot field shouldn't be required.
What happened
When I submit the form I get: pivot field is required.
What I've already tried to fix it
I have specified "allows_null" to true, so I guess it's not working.
Is it a bug in the latest version of Backpack? Yes.
After I run composer update backpack/crud the bug... is it still there? Yes.
Backpack, Laravel, PHP, DB version
When I run php artisan backpack:version the output is:
PHP VERSION:
8.2.4
PHP EXTENSIONS:
Core, date, libxml, openssl, pcre, sqlite3, zlib, ctype, curl, dom, fileinfo, filter, ftp, hash, iconv, json, mbstring, SPL, session, PDO, pdo_sqlite, standard, posix, random, readline, Reflection, Phar, SimpleXML, tokenizer, xml, xmlreader, xmlwriter, mysqlnd, bcmath, exif, gd, gmp, imagick, intl, memcached, pcntl, pdo_mysql, pdo_pgsql, redis, soap, sodium, zip
LARAVEL VERSION:
<IP_ADDRESS>
BACKPACK PACKAGE VERSIONS:
backpack/basset: 1.3.6
backpack/crud: 6.7.41
backpack/filemanager: 3.0.8
backpack/generators: v4.0.7
backpack/logmanager: v5.0.2
backpack/medialibrary-uploaders: 1.2.1
backpack/newscrud: 5.1.0
backpack/pagemanager: 3.3.2
backpack/permissionmanager: 7.2.1
backpack/pro: 2.2.21
backpack/revise-operation: 2.0.0
backpack/settings: 3.1.1
backpack/theme-tabler: 1.2.13

Hey @cod3rshotout thanks for the questions.
I don't think there is any bug here, pivot field is a mandatory field to create the relation, otherwise how would the models relate if the connecting key was not set in the database ?
I will be closing this, but if you feel I am wrong, please continue the conversation and we can re-evaluate. 👍
Cheers

Hey @cod3rshotout thanks for the questions.
I don't think there is any bug here, pivot field is a mandatory field to create the relation, otherwise how would the models relate if the connecting key was not set in the database ?
I will be closing this, but if you feel I am wrong, please continue the conversation and we can re-evaluate. 👍
Cheers

Hi, I don't think you're wrong but I need a little help please.
I need to create the repeatable structure you see in this image:

How can I do it without it being a mandatory field?

Hey @cod3rshotout
You can overwrite all the "backpack defaults" for pivot field, so setting 'pivotSelect' => ['validationRules' => []] in your field definition should work.
It's possible you will enter in errors while attempting to save the relation, for that you can overwrite the store() function in your CrudController: https://backpackforlaravel.com/docs/6.x/crud-operation-create#override-the-store-method and adjust as needed.
 You wish, you have it 😄
Cheers

Hey @cod3rshotout
You can overwrite all the "backpack defaults" for pivot field, so setting 'pivotSelect' => ['validationRules' => []] in your field definition should work.
It's possible you will enter in errors while attempting to save the relation, for that you can overwrite the store() function in your CrudController: https://backpackforlaravel.com/docs/6.x/crud-operation-create#override-the-store-method and adjust as needed.
 You wish, you have it 😄
Cheers

maybe I'm missing something, but... I added the following as you said and the field is still shown as mandatory:

Ahh sorry, you also need to remove it from required fields.
After the field definition do:
$requiredFields = CRUD::getOperationSetting('requiredFields');
CRUD::setOperationSetting('requiredFields', array_diff($requiredFields, ['attachments[attachments]']);

Cheers

Ahh sorry, you also need to remove it from required fields.
After the field definition do:
$requiredFields = CRUD::getOperationSetting('requiredFields');
CRUD::setOperationSetting('requiredFields', array_diff($requiredFields, ['attachments[attachments]']);

Cheers

Thank you! Have a good day :)


IGNITE-12823 .NET: Fix service calls with user-typed array arguments

This PR is associated with a resolved ticket. Closing the PR, please reopen it if you still need it.


istioctl confusing error message when creating rules in non-default namespace

The current error message is confusing:
istioctl --namespace abc create -f ../istio/demos/apps/bookinfo/route-rule-all-v1.yaml
Error: the server could not find the requested resource

The user was supposed to supply --istioNamespace=default
istioctl is getting a message from Kubernetes, a JSON-wrapped message of "services "istio-manager" not found".  Even that would be better than what we have now.
Ideally istioctl could understand the message is coming from Kubernetes because there is no istio-manager Service in the "abc" namespace and suggest the user use --istioNamespace` in addition to --namespace.

From https://istio.io/docs/tasks/installing-istio.html#installation-steps
For the 0.1 release, Istio must be installed in the same Kubernetes namespace as the applications.

The error message should only be seen if user installs Istio in a different namespace than the applications.

Issue moved to istio/galley #11 via ZenHub


Add next_preprocessed_mask()

This commit adds next_preprocessed_mask() to EvalAtRow interface. In most cases it's just a thin wrapper over next_interaction_mask(). However, in InfoEvaluator, next_preprocessed_mask() is the only way to access rows except the current one.
Motivation
I wanted to use the IsFirst column to get both [is_first, is_last] by looking at the current row and the next row. An assertion in  InfoEvaluator::next_interaction_mask() failed with an error message: use get_preprocessed_column().
However, get_preprocessed_column() didn't have access to the next row, so this change.

This change is


Numbered lists don't continue

Describe the bug
Numbered lists restart at 1 after subheading even when given a specific starting number after the heading.
Having just looked at the Notion markdown, I think it may be a Notion bug not a docu-notion bug.
Reproduction Steps
I have 25 chapters in my Paratext Manual. In the overview I break them up into sections but need the sequential numbering to continue so it shows correct chapter number.
Add a numbered list with headings.
Edit each list item after the heading with the number to continue.
Notion displays correctly.
But the resulting page restarts the numbering.
URL of a source Notion page that, when docu-notion accesses or converts it, shows the problem:
Notion: https://jennibeadle.notion.site/Overview-of-Training-Manual-3ce84f9ca3264aed8532489c0574f95c
Resulting page: https://sillsdev.github.io/paratext-manual/Overview/
Expected behavior
Numbering should continue (as per my other Docusaurus site.
https://manual.paratext.org/Training-Manual/Overview
Notion markdown
The notion markdown still has 1.
### Stage 1 Drafting

1. 2. **[OD** – Organising your desktop](https://sillsdev.github.io/paratext-manual/2.OD)
2. **[PP1** – Project plan and progress](https://sillsdev.github.io/paratext-manual/3.PP1)

I added the 2. to specify to continue from 2 but it still has the 1.
I corrected the markdown and pasted it again but it added the 1. again.
Screenshots
In Notion: showing the continuer set

Result of Docu-notion (showing restart as 1):

Site using Markdown (sequential):

Additional context
I searched for possible solutions.
https://stackoverflow.com/questions/18088955/markdown-continue-numbered-list/22138846#22138846
suggested putting a blank link before the element (in their case a code block) but had no effect.

Yeah, this was reported to Notion here, and I also tried with Notion's email support back i October, but didn't get anywhere.

I did have success indenting the text.

Yielded

Which was rendered as

Not sure about indenting headings. But I guess I could turn the headings into text and bold them.

Doesn't work with non-indented bold text blocks. :(

Notion wrote back saying that they are not going to fix this in the API. So without that, we can't support this, sorry.

Anyone having this problem, please make yourself heard by writing to Notion. They rejected my request for a fix, but said that they might act on it if more people asked. So please ask!  See: https://github.com/makenotion/notion-sdk-js/issues/292


Hold piece scaling + adjustments

I've changed the sizeCanvas() function to make the hold piece appear with the correct scaling, and allowed a large maximum board size in the html slider. However, the grid lines seem to appear on the pieces at a browser scaling of something other than 100% (which is not an issue in the original).

Could you please review the code and edit as necessary to hopefully fix the hold piece scaling? I wasn't sure whether to open an issue or a PR for this, but I hope this is okay.

I think removing the rounding stuff from c.width and c.height might be causing the problem with the grid lines showing on the piece, cause then the size isn't and integer. I'm not too sure about this tho because i haven't tested.
Also I'll close this because the next update will kinda organise a lot of code so that its easier to modify later.
After the update u can pr with the board height changes and see if the issue is still there.

oh ig u can fork the tetirewrite branch cause thats where the update stuff it,

Alright feel free to make another pull request cause i deecided to push the update now, i believe ur changes are good


Window caption in Mission Control says "Goofy at Work"

I'm using the normal version of Goofy so I guess it's a bug. Quite easy to correct, though.

I've made a pull request to resolve this issue.


Login the front web errors.

HIi, I meet the follow errors, when I login the front web after activated the user.
api_1  | [22/Dec/2023 15:44:16] "POST /api/token/ HTTP/1.1" 200 483
web_1  |  ⨯ TypeError: "ikm" must be at least one byte in length
web_1  |     at normalizeIkm (webpack-internal:///(rsc)/../../node_modules/.pnpm/@panva+hkdf@1.1.1/node_modules/@panva/hkdf/dist/node/cjs/index.js:25:32)
web_1  |     at hkdf (webpack-internal:///(rsc)/../../node_modules/.pnpm/@panva+hkdf@1.1.1/node_modules/@panva/hkdf/dist/node/cjs/index.js:46:60)
web_1  |     at getDerivedEncryptionKey (webpack-internal:///(rsc)/../../node_modules/.pnpm/next-auth@4.23.2_next@13.5.4/node_modules/next-auth/jwt/index.js:80:36)
web_1  |     at Object.encode (webpack-internal:///(rsc)/../../node_modules/.pnpm/next-auth@4.23.2_next@13.5.4/node_modules/next-auth/jwt/index.js:34:36)
web_1  |     at Object.callback (webpack-internal:///(rsc)/../../node_modules/.pnpm/next-auth@4.23.2_next@13.5.4/node_modules/next-auth/core/routes/callback.js:356:36)
web_1  |     at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
web_1  |     at async AuthHandler (webpack-internal:///(rsc)/../../node_modules/.pnpm/next-auth@4.23.2_next@13.5.4/node_modules/next-auth/core/index.js:298:38)
web_1  |     at async NextAuthRouteHandler (webpack-internal:///(rsc)/../../node_modules/.pnpm/next-auth@4.23.2_next@13.5.4/node_modules/next-auth/next/index.js:50:30)
web_1  |     at async NextAuth._args$ (webpack-internal:///(rsc)/../../node_modules/.pnpm/next-auth@4.23.2_next@13.5.4/node_modules/next-auth/next/index.js:85:24)
web_1  |     at async /app/node_modules/.pnpm/next@13.5.4/node_modules/next/dist/compiled/next-server/app-route.runtime.dev.js:6:62361

@changwu did you set NEXTAUTH_SECRET in .env.frontend?


Fixes notebook launch terminal issue

@mehrdadrafiei pipeline is failing. Also, don't forget to update the version


Improve menu popup focus when opened

Summary
Resolves #1900
Resolves #1919
Resolves #2015
Deployment Links
https://terra-core-deployed-pr-2004.herokuapp.com/#/components/terra-menu/menu/menu
https://terra-core-deployed-pr-2004.herokuapp.com/#/components/terra-collapsible-menu-view/collapsible-menu-view/collapsible-menu-view
https://terra-core-deployed-pr-2004.herokuapp.com/#/components/terra-tabs/tabs/tabs

Talked with @mmalaker about adding up down arrow key support on menu when you first open it, shifting focus to first / last item in it.
We also talked about disabling right arrow shifting to the first menu item in the tabs menu when it is opened via enter/spacebar. We want to treat keyboard interaction between the tabs (left / right arrow keys) to cycle between tabs and the tabs menu (up / down arrow keys) as separate so if a user knows how to navigate a menu already, the expected keys don't change when it's part of a tab component.

@yuderekyu Yeah, I don't have a good fix for #2014. Plan to leave that out of scope for this PR.

During screen reader testing I found issues with each of the components. It seems there is some conflict between keyboard navigation and screen reader actions when those actions share the same keys.

For menus, when you get to the nested menu, the screen reader will leave the menu and start reading the underlying page. Left and right arrow keys do not work for navigation between menu and submenus when using JAWS.
For collapsible menu view, when you enter the menu using VoiceOver, and attempt to navigate using VoiceOver commands, it says "Safari busy" and will not navigate through the list items. You can access the menu using regular keyboard nav, but focus will move off of the menu and back onto the main page while the menu is still open.
For tabs, using the arrow keys to navigate between tabs doesn't work reliably. Sometimes you can't tab to or arrow back to the previous tabs. Also, JAWS does not read the tab text when switching between tabs in a group using the arrow keys.

@mmalaker I've logged issues for the items identified in functional verification. In regards to the changes on this PR, where you able to verify the following issues were resolved:

https://github.com/cerner/terra-core/issues/1900
https://github.com/cerner/terra-core/issues/1919

Functional verification completed. The menu popup examples have the correct focus behavior. Other screen reader issues to be addressed separately.


tree doesn't work

Issue type

is there any update/fix on this tree view component?

I would like to fix it but it's working on my branch. Could you give me more informations ?

Yes ,I have it,too.
It works in the development environment, and  has this error in the production environment(npm build:prod).
My solution:
Replace the ng2-tree with the ngx-treeview

Hey @Pterrat would be great if you could take a look.


URI not exported for login records

I noticed when importing login type records, the associated URL was being ignored (not added to the json file for import).
Here's a quick diff for bitwarden_json.py that I think addresses this correctly:
<                 "uris": [],
---
>                 "uris": [
>                   {
>                     "match": "null",
>                     "uri": data["login_uri"],
>                   }
>                 ],

Thanks for writing this!

wow good spot, thank you!
now I have to think how to fix that in my 1000+ records that I already migrated and using..


Change way of accessing hostname

The ${sys:hostname} variable is not always set. However, Log4J2 has a default variable called hostName that is always available. This change adapts the example configuration to use the default variable.
See also: https://logging.apache.org/log4j/2.x/manual/configuration.html#AutomaticConfiguration

Default Properties
[...]
The default map is pre-populated with a value for "hostName" that is the current system's host name or IP address [...]

Thank you for the contribution and excuse me that it has waited for so long.


add_graph raises RuntimeError when parsing constant node

Hello
I got "RuntimeError: VariableType::ID() not implemented" when parsing constant nodes in the computation graph.
code to reproduce the RuntimeError:
class SimpleModel(nn.Module):
    def __init__(self):
        super().__init__()

    def forward(self, x):
        return x * 2

input = (torch.zeros(1, 2, 3),)

model = SimpleModel()

with SummaryWriter(comment='test') as w:
    w.add_graph(model, input)

Stack:
File "...tensorboardX\writer.py", line 419, in add_graph
    self.file_writer.add_graph(graph(model, input_to_model, verbose))
File "...tensorboardX\graph.py", line 85, in graph
    list_of_nodes = parse(graph)
File "...tensorboardX\graph.py", line 28, in parse
    attrs = {k: n[k] for k in n.attributeNames()}
File "...tensorboardX\graph.py", line 28, in <dictcomp>
    attrs = {k: n[k] for k in n.attributeNames()}
File "...torch\onnx\utils.py", line 444, in _node_getitem
    return getattr(self, sel)(k)
RuntimeError: VariableType::ID() not implemented

The stack shows that calling Constant["value"] will give RuntimeError
str(n)  =  "%1 : Dynamic = onnx::Constant[value={2}](), scope: SimpleModel"
n["value"] ==>  RuntimeError
So is this a bug or an unimplemented feature of ONNX ?
My temporary workaround for this is to set attrs = str(n) if {k: n[k] for k in n.attributeNames()} raises RuntimeError.
pytorch = 0.4.0
tensorflow = 1.8.0
tensorboardX = 1.2

Both of them. I didn't consider that case. If you would like to send a PR, please also print a warning message if the if condition is true.


corrected order of helm lint coalescing of multiple values files

What this PR does / why we need it:
Example
The following command is run with the below value files and a json schema specifying service.port is required.
helm lint ./testchart --values ./testchart/second_values.yaml

values.yaml
{
...
service:
  type: ClusterIP
  port:
...
}

second_values.yaml
{
...
service:
  port: 80
...
}

The result is an error.
helm lint ./testchart --values ./testchart/second_values.yaml
==> Linting ./testchart
[INFO] Chart.yaml: icon is recommended
[ERROR] values.yaml: - service: port is required

Error: 1 chart(s) linted, 1 chart(s) failed

See the attached chart below for the full, runnable example.
testchart-0.1.0.zip
Problem
Running helm lint with the flag -f/--values specifies a user-provided values file.  When using helm lint if a user-provided values file exists, then the user-provided values file and chart provided values.yaml are coalesced to create a single values file.  When coalescing the values files if a value exists, see port above, in both the chart provided values.yaml and a user-provided values file, see second_values.yaml above, helm lint uses the value in the chart provided values.yaml.
This behavior is backwards as the user-provided values file should take precedent over the chart provided values.yaml.
Solution
The values files are coalesced in the following line of pkg/lint/rules/values.go
values = chartutil.CoalesceTables(values, overrides)

The CoalesceTables function states the following
// CoalesceTables merges a source map into a destination map.
//
// dest is considered authoritative.
func CoalesceTables(dst, src map[string]interface{}) map[string]interface{

Since dst is authoritative, overrides should be dst.  Also overrides is passed in so in order to not manipulate it, a deep copy of overrides should be used.
Special notes for your reviewer:
Fixes #8880
Fixes #8892
If applicable:

[ ] this PR contains documentation
[*] this PR contains unit tests
[ ] this PR has been tested for backwards compatibility

The requested reasoning for the unit test change was provided above. Can you provide feedback @bacongobbler @jdolitsky as to how this pull request should proceed?

The circleci build failed on step test style with the following timeout error:
GO111MODULE=on golangci-lint run
ERRO Timeout exceeded: try increasing it by passing --timeout option
make: *** [Makefile:116: test-style] Error 4

I am able to run the following commands locally without error:
$ make test-style --debug
GNU Make 4.2.1
Built for x86_64-pc-linux-gnu
Copyright (C) 1988-2016 Free Software Foundation, Inc.
License GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.html>
This is free software: you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.
Reading makefiles...
Updating makefiles....
Updating goal targets....
 File 'test-style' does not exist.
Must remake target 'test-style'.
GO111MODULE=on golangci-lint run
Successfully remade target file 'test-style'.

$ golangci-lint run --verbose
INFO [config_reader] Config search paths: [./ /home/mluckam/development/helm/helm /home/mluckam/development/helm /home/mluckam/development /home/mluckam /home /]
INFO [config_reader] Used config file .golangci.yml
INFO [lintersdb] Active 14 linters: [deadcode dupl gofmt goimports golint gosimple govet ineffassign misspell nakedret staticcheck structcheck unused varcheck]
INFO [loader] Go packages loading at mode 575 (compiled_files|exports_file|types_sizes|deps|files|imports|name) took 6.1874238s
INFO [runner/filename_unadjuster] Pre-built 0 adjustments in 282.5927ms
INFO [linters context/goanalysis] analyzers took 0s with no stages
INFO [linters context/goanalysis] analyzers took 0s with no stages
INFO [runner/skip dirs] Skipped 1 issues from dir internal/third_party/dep/fs by pattern (^|/)third_party($|/)
INFO [runner] Issues before processing: 43, after processing: 0
INFO [runner] Processors filtering stat (out/in): skip_dirs: 42/43, autogenerated_exclude: 42/42, cgo: 43/43, path_prettifier: 43/43, skip_files: 43/43, exclude-rules: 0/42, filename_unadjuster: 43/43, identifier_marker: 42/42, exclude: 42/42
INFO [runner] processing took 88.0427ms with stages: path_prettifier: 58.1572ms, autogenerated_exclude: 25.639ms, skip_dirs: 3.4317ms, identifier_marker: 586.7µs, exclude-rules: 207µs, cgo: 11.5µs, filename_unadjuster: 4.5µs, max_same_issues: 1.2µs, nolint: 1µs, exclude: 500ns, uniq_by_line: 500ns, diff: 400ns, skip_files: 300ns, max_per_file_from_linter: 200ns, path_shortener: 200ns, severity-rules: 200ns, max_from_linter: 200ns, source_code: 200ns, sort_results: 100ns, path_prefixer: 100ns
INFO [runner] linters took 384.675ms with stages: goanalysis_metalinter: 295.3923ms, unused: 1.1594ms
INFO File cache stats: 0 entries of total size 0B
INFO Memory: 70 samples, avg is 75.9MB, max is 140.3MB
INFO Execution took 6.88118s

Can you provide guidance on what would cause this issue?
@bacongobbler @jdolitsky

Can you try rebasing your commits on top of master? There was a few fixes in master to address some CI issues.

@bacongobbler Isn't this a bugfix? Any change we can get it sooner, i.e. with the next 3.5.x? :pray:


Setup typeversions export in core

We need to double check our typeversion exports in core. Specifically to confirm they are working with pnpm.
See the discussion in the typescript channel for more details.

We think this is solved. Lets double check. See Pato's repo.


Official package distribution

I see this has already been brought up in #3 but I'd like to raise it again. IMO a 3rd-party fork with a Podfile isn't a great solution as 1) it's already out of date with this repo and 2) it's not in the official package index. UberSignature is an awesome repo – let's make it easier for more people to install and use in their projects!
@myhrvold @viralplatipuss @jmascia is this something you'd be willing to support? I'd be happy to submit a PR with a Podspec if you guys are on board to publish it to https://cocoapods.org/. It would also be great to support installation via Carthage.

It would be awesome to have at least CocoaPods support.
I would also be available to help with this.

I no longer work at Uber, but seeing if I can get someone to look into adding this.

I'll have a go

Published on CocoaPods.
https://cocoapods.org/pods/UberSignature

Thanks @alanzeino!


Some multi-threading improvements

I improved multi-threading a bit

Fix multi-threading for parabolic terms on ARM (such as Apple M series processors)
Reduce allocations a bit

See the commit messages for more details.

(you need to run the formatter)


Port TestAllBuiltinFunctionsHaveParameterDescriptions from PAClient

This test can fail in PAClient even though the change was in PowerFx and the PowerFx build passed. This change adds this test to PowerFx so that we can catch the failures here, instead of in the PAClient pipeline.

Pull Request Test Coverage Report for Build 310987

0 of 0   changed or added relevant lines in 0 files are covered.
9 unchanged lines in 1 file lost coverage.
Overall coverage increased (+0.1%) to 59.495%

Files with Coverage Reduction
New Missed Lines
%

/src/libraries/Microsoft.PowerFx.Core/Texl/Builtins/Boolean.cs
9
85.71%

Totals

Change from base Build 310522:
0.1%

Covered Lines:
21420

Relevant Lines:
36003

💛  - Coveralls


Comments on data range

I know those values are indicative and should not prevent pushing the data if the tests on value are broken but the less errors we have for good reason, the better it is I think.

base: min value is -3000. In Bedmachine, I found a point under the ice sheet at -3710m (under Amery glacier), so probably -4000m is more reasonable than -3000m.
ligroundf: max value accepted is 0. This test is broken as soon as you have a pinning point in the model (ice is coming inside upstream of the pinning point (+ sign) and outside downstream of the pinning point (- sign)). I suggest to have the same sanity check on min and max and check the integrated value to detect error on the sign convention (should be negative).

I updated the value for base to be -4000m to avoid that problem.
I also updated ligroundf to a relatively small value to limit this problem, however the goal was mostly to check the sign of the field to make sure it was consistent with the description, so we won't put it to the same range as the maximum. We have not developed test for integrated value, it would be great be beyond what we could do for this version.


Rebuild sources when the lib dir is removed or when the build system changes

@Mossop

Coverage increased (+0.6%) to 39.969% when pulling 9a6431524e35b230b6d4c4e392883ee5d5804f78 on victorporof:check-build-dir into b478292654274947c86b5e733094cb9a43b891b2 on mozilla:master.

LGTM


PacketIO sniff() issue

Hi
I'm actually using the p4runtime-shell with the latest feature (#55), more precisely the function sniff. While testing this feature I noticed that the sniff blocks indefinitely if the rate of incoming Packet_INs is > of the provided timeout.
it blocks here https://github.com/p4lang/p4runtime-shell/blob/main/p4runtime_sh/shell.py#L2392
apparently, the timeout within the self.packet_in_queue.get() function resets everytime a new packet_in is dequeued.
The reason why I opened this issue is because I was expecting a behaviour similar to scapy's sniff().

I do agree that it's a bit surprising. I think it's natural for someone to expect that the function will return after the timeout expires, and it shouldn't be a per packet timeout. @Yi-Tseng any thoughts?
@EmanueleGallone feel free to open a PR to address this if you want

Per packet timeout is my initial design, and I didn't realize this issue because I only test few packets manually.
I think it is a good idea to change this to make the function return after a certain period.
I was also thinking about changing the behavior of this function.
For example, apply the function when we receive a packet-in instead of applying all packet-ins after the timeout.
Feel free to open a pull request to change this, thanks!


module 'system' not found error when running busted -c

When running busted -c I get a failure to find the system module:
╰ busted -c
/usr/local/opt/lua/bin/lua5.3: /usr/local/share/lua/5.3/busted/core.lua:6: module 'system' not found:No LuaRocks module found for system
        no field package.preload['system']
        no file '/usr/local/share/lua/5.3/system.lua'
        no file '/usr/local/share/lua/5.3/system/init.lua'
        no file '/usr/local/lib/lua/5.3/system.lua'
        no file '/usr/local/lib/lua/5.3/system/init.lua'
        no file './system.lua'
        no file './system/init.lua'
        no file '/Users/dbalatero/.luarocks/share/lua/5.3/system.lua'
        no file '/Users/dbalatero/.luarocks/share/lua/5.3/system/init.lua'
        no file '/usr/local/lib/lua/5.3/system.so'
        no file '/usr/local/lib/lua/5.3/loadall.so'
        no file './system.so'
        no file '/Users/dbalatero/.luarocks/lib/lua/5.3/system.so'
stack traceback:
        [C]: in function 'require'
        /usr/local/share/lua/5.3/busted/core.lua:6: in main chunk
        [C]: in function 'require'
        /usr/local/share/lua/5.3/busted/runner.lua:18: in function 'busted.runner'
        /usr/local/lib/luarocks/rocks-5.3/busted/2.0.0-1/bin/busted:3: in main chunk
        [C]: in ?

In core.lua, this is referenced:
  busted.gettime = system.gettime
  busted.monotime = system.monotime
  busted.sleep = system.sleep

What is the system module and how do I install it?
Sidenote: Is Lua packaging just super gross compared to other ecosystems, or am I doing something wrong? I feel like every package I install, I have to play dependency whack-a-mole.

Also I cannot find any documentation on Google relevant to monotime, gettime, or sleep that would point me at a module called system.

Ok I found it - luarocks install luasystem - but why didn't luarocks do the right thing with these dependencies?
https://github.com/Olivine-Labs/busted/blob/master/busted-scm-2.rockspec#L20-L31

how did you install busted?

I think I just did luarocks install busted?

I think I just did luarocks install busted?

It doesn't sound like it. That should have installed the dependency tree too. The Lua package ecosystem has more rough edges than some, but it isn't quite that dumb. It sounds like something probably errored out in the install and you didn't notice ... or perhaps you ran the install with --no-deps?
Also, depending on your project and system usage of course you might look into whether your system/distro has packages. It can be useful to have busted around as a system binary to easily run on projects without having to install dev dependencies every time.

The Lua package ecosystem has more rough edges than some, but it isn't quite that dumb.

Yeah this was definitely my surprised thought as well.
I got my dependencies from this script originally which just runs luarocks install pkg, although it's been a while since I ran it. https://github.com/dbalatero/VimMode.spoon/blob/4dad48dd22c79beb20ee2cc08f1e2af9f1cc5b52/bin/dev-setup#L1-L43
Maybe I'll try a clean install of luarocks and see if I hit the same problem, but I think we can close this.


Possible to push FocusGained events to output.events?

Hey, thanks so much for this crate!
I'm making blind-accessible games for which the keyboard/gamepad are very important. Currently I use egui, but tab/shift-tab aren't ideal and creating something better has been on the todo list for a while.
This crate almost works for me, but I'm using output.events and a Bevy system as kind of a kludgy screen reader. You can get an idea of what I'm doing here.
When you move focus to a new widget, would it be possible to push an event so this crate could be compatible with my bevy_egui_a11y demo? It doesn't seem too difficult, and if you don't have time but can point me to where and how I might do this myself then I'm happy to take a crack at it. You can see an example of how egui does this here. I guess the biggest challenge will be whether or not you've got enough info to create the focus events from within the plugin, though at least you're only dealing with focus and not other event types. :) Also wondering if it may be possible for the decorators to augment widgets with at least their type, name, and value if necessary so the plugin can create the necessary events. Those should be enough for at least basic versions of FocusGained.
Thanks again.

Please try with the fix-focus-event-emission and see if it works well for you.

Unfortunately it seems to make things worse. :(
I just pushed a kbgp branch to the above demo. Unless I'm doing
something wrong, this branch doesn't even present events when
tabbing/shift-tabbing anymore.
Thanks for looking into this so quickly!

I downloaded and built it, and on some runs it would indeed not do anything on focus events, but on other runs it'd work fine for both tab and arrow navigation.
This usually means that the order of systems matter.
In this case, when I changed your screen_reader system run before egui processes output:
.add_system_to_stage(CoreStage::PostUpdate, screen_reader.system().before(bevy_egui::EguiSystem::ProcessOutput))

it works consistently. When I change it to run after instead, it doesn't work - also consistently.
I think a system labeled with bevy_egui::ProcessOutput that runs during the post update stage wipes out the output events.

Oh, you're absolutely right. I'd made that change in my game but forgot
that I hadn't made it in the concept demo. Sorry about that.
It does seem to work consistently now. Thanks! I'll integrate it into my
game for broader testing as soon as it's released.
Thanks again for making this. It's always nice when I can strike
something major like this from the todo list.

Oh, one minor thing I noticed, not sure if it's something you can fix. I don't get an event for .kbgp_initial_focus() on my "Start" button. Other events now work consistently.

Try now (same branch)

Yup, works now. Thanks!


feat: add filter to resource config

@singhvikash11 can you please give more context on this? or link to the related issue if any?

@mabdh @rahmatrhd can you please approve this, it is used in pr github.com/odpf/guardian/pull/323

@bsushmith can you please review and approve this

Need these changes for - https://github.com/odpf/guardian/issues/313


copr: add feature json_quote

Signed-off-by: ZingLix<EMAIL_ADDRESS>
What problem does this PR solve?
Issue Number:  #5751
Problem Summary: JsonQuoteSig did not have a vectorized version in TiKV.
What is changed and how it works?
What's Changed: Implemented json_quote
Check List
Tests

Unit test

Release note

Add copr feature: json_quote

/rebuild

/rebuild

/rebuild

/cc @Xuanwo @andylokandy

I'm not familiar with json_quote either... Would mind having a look @ichn-hu?

MySQL's documentation doesn't clearly state the specification of the behavior of json_quote, so I think it is okay to firstly match TiDB's behavior.

@Xuanwo  PATL~

/merge


revert #108 to fix #237

Issue #, if available:
#237 described a problem deleting resources on rollback. If merged, we should re-opem #107 which describes a visibility problem on custom resource creation failures.

Codecov Report

Merging #241 into master will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master     #241   +/-   ##
=======================================
  Coverage   74.44%   74.44%
=======================================
  Files          20       20
  Lines         677      677
=======================================
  Hits          504      504
  Misses        128      128
  Partials       45       45

Impacted Files
Coverage Δ

cfn/wrap.go
65.78% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 81cc163...f818d73. Read the comment docs.


Android build documentation

It would be really useful to have documentation about building android from source.

@nswamy @Roshrini why are we labeling Build as Installation? Doesn't seem like the same thing.


Add SRL Initiator for EDRGen and New OGC Action Type

Purpose
The purpose of this pull request is to implement functionality for the SRL Initiator in the EDRGen system, as well as introduce a new action type for OGC process execution. This PR addresses two key issues:

Create an SRL initiator for evaluating .dat and .emd files, based on the NISAR example.
Add a new initiator action type to submit OGC processes by process ID.

Proposed Changes

[ADD] A new evaluator DAG in Apache Airflow to determine if .dat and .emd file pairs are ready for processing.
[ADD] A new action type, SubmitOgcProcessExecution, to execute OGC processes via process ID.
[CHANGE] Updated router.yaml configuration to include the new SRL use case and OGC process execution.
[CHANGE] Switched router input format to S3 URL for improved integration.
[CHANGE] Updated resource naming conventions for consistency across Terraform modules.
[CHANGE] Bumped Terraform version to ensure compatibility with the latest features.
[FIX] Used hyphens instead of underscores in Terraform module names to comply with naming conventions.
[FIX] Removed !!python/regexp to ensure YAML validity and compatibility.
[FIX] Explicitly provisioned the Lambda's CloudWatch log group to enhance monitoring capabilities.
[FIX] Used realpath in Docker run calls to ensure accurate path resolution.

Issues

#413
#412

Testing

Unit Tests: Successfully ran unit tests (which included exercising the new SubmitOgcProcessExecution action type).
Integration Tests: Conducted integration tests to ensure end-to-end functionality, demonstrating successful invocation of the evaluator DAG upon file deposition. Test logs available in the CloudWatch log group for Lambda functions.
Environment: Tests were performed on AWS using an S3 bucket for file storage and CloudWatch for log monitoring. Initiator Terraform modules were integrated into the SPS Terraform codebase and deployed in MCP to ensure compatibility with existing services.

@drewm-jpl Thanks!  This look good to me, however, I would defer mostly to @pymonger on this one to get his approval.


diceCombinations should be called in diceRollHandler

Currently, the diceCombinations are calculated on drag, but should be moved to be calculated when the roll is made (only if an activePlayer is assigned). diceCombinations should then be used for validating available points and be updated after a checker is moved in state via useReducer.

This code has been refactored and the suggested changes are no longer possible.


Include "Japanese (vertical)" to list of languages

Tesseract supports OCR'ing japanese text in vertical mode, and has a trained model in their tessdata(_best) repo.

Confirmed that adding this single line works by directly changing the code in the Flatpak app location.
Tested:

[x] Changing code
[x] Running app to check if anything breaks
[x] Downloading trained data
[x] Running Frog on a test image

As can be seen on the image below, it successfully OCR'd the test image.
Accuracy is not 100%, but that is attributed to the image quality and Tesseract itself.

Awesome, thank you!


Gaudi2 support opt-66b(DS mode)

What does this PR do?
current text-generation only support Bloom-176b, but not support opt-66b, since opt-66b can not fit into 1 gaudi2 device(96GB).
with this PR opt-66B could run with 2 Gaudi2 cards

Fixes # (issue)
Before submitting

[ ] This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
[ ] Did you make sure to update the documentation with your changes?
[ ] Did you write any new necessary tests?

@regisss opt-66B cannot run on 1 Gaudi2 and also cannot run with DS 8x, since in here model weights will be transferred to device before weights sharding in deepspeed.init_inference(), I have tried to  change opt path to bloom path, but there are confliction, such as

deepspeed will hijack nn.Embeddingwhich is also be done inmodeling_opt.py`
in _attn, the device of caucal_mask  is meta which lead to a runtime mismatch of tensors

so I change the device from args.device to cpu, means load weight to host and then do weights sharding in deepspeed.init_inference(), which works well when running opt-66b on 2x
But see here, if device is cpu and when running with 8x, means loading weights from disk to memory 8 times, waste lots of host memory, right?

Thanks for this PR @ZhaiFeiyue, I'll review this PR by the end of this week!

@ZhaiFeiyue So I investigated this a bit, and with a few changes to DeepSpeed I got it to work:

replace torch.half by torch.bfloat16 here and there
replacing the forward in OPTEmbedding with more or less the same as we have here

Do you think we can push these changes to Habana's DeepSpeed fork?
Otherwise we can do some monkey patching in a similar way to what we do to override Transformers modeling. WDYT?

@regisss thanks for your investigation :smile:, with the changes above you can run text-generation with opt-66b ds 8x in the way like Bloom right,? since bloom is special handled in run_generation.py (I guess you have another PR that makes changes in run_generation.py).
or base on this PR with your changes, you can run opt-66b ds 8x in your side?

@regisss thanks for your investigation 😄, with the changes above you can run text-generation with opt-66b ds 8x in the way like Bloom right,? since bloom is special handled in run_generation.py (I guess you have another PR that makes changes in run_generation.py). or base on this PR with your changes, you can run opt-66b ds 8x in your side?

Yes, it follows the same path as BLOOM in the script. I'm going to push a new commit so that you can test it.
But the question is: should these changes be directly in Habana's DeepSpeed fork or just in Optimum Habana?

cool @regisss, for your question I prefer we do these in optimum-habana side, since Habana DS is a fork version and  should not involve too much model special changes.

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.

@regisss very clean changes 👍
but there is a error in my side, seems that the Linearlayer  has not been replaced.

any ideas or I missed something?

@ZhaiFeiyue Yeah I have the same error, I need to see where it comes from exactly. When doing the changes directly in DeepSpeed it was working.
I've not got time to investigate this much yet, I'll let you know when it is fixed :slightly_smiling_face:

@ZhaiFeiyue The model is now loaded correctly but results are weird:
Input/outputs:
----------------------------------------------------------------------
input 1: ('DeepSpeed is a machine learning framework',)
output 1: ('DeepSpeed is a machine learning framework',)
----------------------------------------------------------------------

It's like it is not doing anything.

@regisss  yes, same in my side

outputs are always 50272

weights seems that not loaded correctly
the red part is dummy weights

Weird :thinking:
I'll be off for a few hours, feel free to keep investigating @ZhaiFeiyue. Otherwise I'll get back to it later.

Weird :thinking:
I'll be off for a few hours, feel free to keep investigating @ZhaiFeiyue. Otherwise I'll get back to it later.

@ZhaiFeiyue There must be something wrong in the injection policy. Maybe because of the way we write the JSON checkpoint here: https://github.com/huggingface/optimum-habana/blob/b1f0bd7e436be6d57a893eee7e34647a5a86ca3f/examples/text-generation/checkpoint_utils.py#L59
I also see that auto-injection will be merged at some point (see here), so if it's planned for v1.11.0 maybe it's better to just wait for it and keep your initial change?

@regisss agree with you, I will open a new PR and we could keep your changes in this PR

new PR is #285

@regisss I finally got time to debug OPT-66b now 😄, the weights is not loaded correctly because the name mismatch, your injection works well. I add new changes here

if with opt-125m and 66b the weights name starting from model. but 13b starting from decoder.
see here the prefix with level=0 will be stripped, which lead to the name mismatch here
I have tested 125m 13b, will test 66b later when resource available.

@ZhaiFeiyue Nice! Let me know if OPT-66b works  :slightly_smiling_face:

@regisss  bad news 😢  66b does not work, but  comment this line it works need do more investigation.

@regisss I have checked all the weights' name of bloom models(from 560m to 176b), all of them are same.
but for OPT, they are different as I mentioned before

OPT-125m OPT-66b prefix=model. and  name starting with model.
OPT-13b, OPT-30b prefix = '' and name starting with decoder.

transformers from_pretrained() could handle both the above cases from here but in DS, the prefix are always removed I think from here, because ckpt_type should be pp and level should be 0, so when running OPT-125m and 66b the name is mismatch(in the checkpints bin file it starting with model. but in DS the name is starting decoder. since model. is removed) and weight cannot be loaded.
base on the above analysis, what I think is is there any possible that we create a offline weights converter tool that to remove prefix for 125m and 66b?
correct me if some wrong.

@regisss  that's great if could fix in Transformers team.

@regisss let's close this PR, because the changes for OPT should be in Habana DS like official DS

@regisss let's close this PR, because the changes for OPT should be in Habana DS like official DS

Sounds good!


Exception in netns.py

@lwr20 was rerunning our scale testing script today, the build pulled in a new revision of libcalico and we started getting this error.  He's going to retry with an older revision to confirm that it was a regression.
Traceback (most recent call last):
  File "./host-agent.py", line 354, in <module>
    main()
  File "./host-agent.py", line 337, in main
    start_job(job_id, sub_job)
  File "./host-agent.py", line 199, in start_job
    netns.move_veth_into_ns(pid, ep.temp_interface_name, interface)
  File "/usr/local/lib/python2.7/site-packages/pycalico/netns.py", line 118, in move_veth_into_ns
    with NamedNamespace(namespace) as ns:
  File "/usr/local/lib/python2.7/site-packages/pycalico/netns.py", line 227, in __init__
    self.ns_path = namespace.path
AttributeError: 'int' object has no attribute 'path'

The older version works.  The version I used was:
git+https://github.com/projectcalico/libcalico.git@d5b7cf7dca5f072aa2d66628e78fcc8048eb7f38#egg=libcalico

Check #13

We have a version of Namespace() called PidNamespace() which emulates the old version.

@fasaxc @lwr20 So it looks like you need to update your scale script. Sorry for not making this change clearer in the release note (though is was mentioned - https://github.com/projectcalico/libcalico/releases/tag/v0.1.3)
I'm going to close the issue, feel free to reopen if you still think there's a bug here.


unhelpfull error message when adding an new lambda function with same name

How did you install the Amplify CLI?
No response
If applicable, what version of Node.js are you using?
No response
Amplify CLI Version
11.1.1
What operating system are you using?
Mac
Did you make any manual changes to the cloud resources managed by Amplify? Please describe the changes made.
no
Describe the bug
when adding a lambda function with a same name. The CLI throws the follow error message
<function-name> is present in amplify-meta.json

while the error message is minimal, the message is not helpfull
Expected behavior
throw error message -> Function with name <function-name> already present in the project. create the function with a new name
Reproduction steps

amplify add function -> name as test
amplify add function -> name as test
observe error

Project Identifier
No response
Log output

# Put your logs below this line

Additional information
No response
Before submitting, please confirm:

[X] I have done my best to include a minimal, self-contained set of instructions for consistently reproducing the issue.
[X] I have removed any sensitive information from my code snippets and submission.

Hey @ykethan I was able to successfully reproduce this issue using the latest version of Amplify CLI (11.1.1). This also appears to print a stack trace without using --debug, for which I'll add the ops-errors label.
Marking as a bug


Fix SP2 flag for UFF torsion contributions

Reference Issue
There is no reference issue.
What does this implement/fix? Explain your changes.
In the torsion contribution addition method of the UFF force field builder, SP2 hybridization of the end atoms is checked, but there was a typo in the code (probably due to copy-and-paste) that resulted in an erroneous check for the condition. This change fixes that typo.
Any other comments?
Nothing.

This is a fun one.  I agree this looks like a bug, however the energy calcs for UFF in the regression tests now fail.  This will require some investigation.

Hi @jasad1
Thanks for finding this and submitting a patch. The code change looks completely correct and I suspect that your hypothesis about a copy-paste error is completely correct.
Unfortunately, since this changes the results of at least some of the force field calculations, the change breaks some of the tests. The expected test results need to be updated (and checked to make sure the new results actually do look better than the old ones) so that the tests pass before the PR can be merged.

@jasad1: are you going to have time to update the expected test results?

@greglandrum Not right now, but probably in a few weeks. Is it enough to regenerate the test data with a manual check if they look correct, or do you know about anything else I should take special care with?

I think it's fine if you just take a close look at the results to make sure they seem reasonable

This is fixed in #2875, so I will close it once that is merged.
@jasad1 : thanks for noticing this and reporting it!

Thank you! I never had time to fix the tests, so it is nice to see you got around to it! :)


Return type of Function is not honored, resulting in incorrect results

This function definitely sets a return value and returns it:

And the return type of the function is void**. However, you can see above that the MLIL SSA is seeing the current value of rax as being the return value of a previously called function.

I think this bug is fixed isn't it?

It's not fixed, here's the same binary in HLIL SSA form

Fixed in v2.0.2120


LaTeX formula on the documentation not displayed due to Missing \end{eqnarray} error

The math part of the documentation of pinocchio::forwardDynamics is not displayed due to an error Missing \end{eqnarray}:

See also https://gepettoweb.laas.fr/doc/stack-of-tasks/pinocchio/master/doxygen-html/namespacepinocchio.html#ab26c1ca5d01d5885b329fc35793682df .
The related line of code is https://github.com/stack-of-tasks/pinocchio/blob/a1df23c2f183d84febdc2099e5fbfdbd1fc8018b/src/algorithm/contact-dynamics.hpp#L17, but I could not understand at the first sight the problem.
The error is present on both the latest Google Chrome and Firefox. Upon more inspection, it seems to also affect pinocchio::impulseDynamics.

Thanks @traversaro for raising this point, pretty useful as usual. I've also noticed this issue on my side without taking time to analyse it.

Solved by #1567.


Migrate Github API Code to Octokit

Removes GitHub API boilerplate in favor for Octokit which is an API wrapper for GitHub's API. This is nice because Octokit comes with type definitions (so coming up with response types aren't up to developers) and has more concise endpoint calls.
As a result the total diff is negative  ~200 LOC's (excluding the lockfile diff)
Todo:

[x] Fix bug where changing URL from one to another doesn't populate folders
[x] Migrate user authenticated GitHub requests
[x] Finish testing

I really appreciate the contribution but unfortunately, I'm not looking to add Ocktokit to the project. While I agree that it'd reduce boilerplate, fetch is sufficient as of now as only a small amount of GitHub's REST endpoints are used.

Fix bug where changing URL from one to another doesn't populate folders

I'm not sure I'm able to replicate this. If this is still an issue, feel free to create an issue with steps on how to reproduce it!

I really appreciate the contribution but unfortunately, I'm not looking to add Ocktokit to the project. While I agree that it'd reduce boilerplate, fetch is sufficient as of now as only a small amount of GitHub's REST endpoints are used.

Fix bug where changing URL from one to another doesn't populate folders

I'm not sure I'm able to replicate this. If this is still an issue, feel free to create an issue with steps on how to reproduce it!

Understandable, the bug wasn't any issue with your code it was just a bug I introduced with octokit that I wanted to keep track of


Amend wrong type message

I had to import customers. These customer data was partly hand-written. An error message like "Email is not valid email" does not really help as it is not clear which entry fails the validation. Therefore I added the value to the error message so you can search for the errornous data.

Hello,
thank you for creating this pull request.
I have opened an issue on our Issue Tracker for you. See the issue link: https://issues.shopware.com/issues/PT-9479
Please use this issue to track the state of your pull request.

Thank you for your contribution. This was merged and will be released with one of the next releases.


Sequencing and Concurrency

I have the following code:
object Main extends IOApp {
  override def run(args: List[String]): IO[ExitCode] = {
    implicit val runner: ProcessRunner[IO] = new JVMProcessRunner

    val proc0 = Process[IO]("sleep", List("3"))
    val proc1 = Process[IO]("echo", List("hello")) >? fs2.text.utf8Decode[IO]
    for {
      result1 <- Blocker[IO].use { blocker =>
        proc1.run(blocker)
      }
      _ <- IO(println(result1.output))
    } yield ExitCode.Success
  }
}

As expected, this prints
❯ sbt run
[info] Loading global plugins from /Users/ethan/.sbt/1.0/plugins
[info] Loading settings for project stackoverflow-build from plugins.sbt ...
[info] Loading project definition from /Users/ethan/IdeaProjects/stackoverflow/project
[info] Loading settings for project stackoverflow from build.sbt ...
[info] Set current project to cats-effect-tutorial (in build file:/Users/ethan/IdeaProjects/stackoverflow/)
[info] Compiling 1 Scala source to /Users/ethan/IdeaProjects/stackoverflow/target/scala-2.12/classes ...
[info] running (fork) Main
[info] Vector(hello
[info] )
[success] Total time: 5 s, completed May 1, 2020, 12:58:58 PM

But suppose I want to first run proc0 and then proc1?
Moreover, suppose I want to run two instances of this sequence in parallel? The equivalent of
#! /usr/bin/env bash
sleep 3 && echo hello &
sleep 3 && echo hello &
wait

To run sleep 3 and echo hello sequentially you can just use the .run function as you did which waits until the process exists, and chain the to IO actions together with flatMap or one of the syntax helpers of cats-effect such as *>:
    Blocker[IO].use { blocker =>
      val proc0then1 = proc0.run(blocker) *> proc1.run(blocker)
   }

(Note that it is enough to have one Blocker thread pool, it is not something you want to create per process)
This is not exactly the same as && in bash, because it does not check the exit code of the first process before starting the second. This currently can only be done by writing a helper function for it:
  def mustSucceed[O, E](f: IO[ProcessResult[O, E]]): IO[ProcessResult[O, E]] =
    f.flatMap { result =>
      result.exitCode match {
        case ExitCode.Success => IO(result)
        case code: ExitCode => IO.raiseError(new RuntimeException(s"Process exited with code $code"))
      }
    }

and then use it like:
val proc0then1 = mustSucceed(proc0.run(blocker)) *> mustSucceed(proc1.run(blocker))

To run this twice in parallel you can use cats-effect's fibers like this:
      for {
        fiber1 <- Concurrent[IO].start(proc0then1)
        fiber2 <- Concurrent[IO].start(proc0then1)

        result1 <- fiber1.join
        result2 <- fiber2.join

        _ <- IO(println(result1.output))
        _ <- IO(println(result2.output))
      } yield ExitCode.Success

So as you can see currently both can be solved using prox as a building block with the help of the underlying effect library. The library could provide syntax to perform these in a more concise way and I like the idea. I will implement it for the next release, created two separate issues to track this:
https://github.com/vigoo/prox/issues/112
https://github.com/vigoo/prox/issues/113

Thanks for your help! I put together a full IOApp in case any other newcomers to Scala look at this:
import cats.effect._
import cats.implicits._
import io.github.vigoo.prox.{Process, _}

object Main extends IOApp {
  def mustSucceed[O, E](f: IO[ProcessResult[O, E]]): IO[ProcessResult[O, E]] =
    f.flatMap { result =>
      result.exitCode match {
        case ExitCode.Success => IO(result)
        case code: ExitCode => IO.raiseError(new RuntimeException(s"Process exited with code $code"))
      }
    }

  override def run(args: List[String]): IO[ExitCode] = {
    implicit val runner: ProcessRunner[IO] = new JVMProcessRunner

    val sleep = Process[IO]("sleep", List("4"))
    val date = Process[IO]("date") >? fs2.text.utf8Decode[IO]

    for {
      outputs <- Blocker[IO].use { blocker =>
        val proc101 = for {
          date1 <- date.run(blocker)
          date2 <- sleep.run(blocker) >> date.run(blocker)
        } yield (date1, date2)
        for {
          fiber1 <- Concurrent[IO].start(proc101)
          fiber2 <- Concurrent[IO].start(proc101)

          result1 <- fiber1.join
          result2 <- fiber2.join
        } yield (
          (result1._1.output, result1._2.output),
          (result2._1.output, result2._2.output)
        )
      }
      _ <- IO(println(outputs))
    } yield ExitCode.Success
  }
}

I'll add, being a newcomer myself, please let me know if there more idiomatic ways to express this.
Thanks for your help!


More on Pledges

I now get an error when building pulse:
* Warning 285 at Pulse.Lib.Stick.fst(20,21-20,26):
  - module not found in search path: pulse.lib.trade

* Error 128 at Pulse.Lib.Stick.fst(20,21-20,26):
  - Module Pulse.Lib.Trade cannot be found

1 error was reported (see above)
make: *** [../Makefile.pulse.common:64: _output/cache/Pulse.Lib.Stick.fst.checked] Error 1

This may be a stale .depend file, could you run find . -name '*.dep*' -delete and retry?

That was my first instinct as well, but it didn't help.  FWIW I get the error when running:
make verify -C share/steel/examples/pulse/lib/

Ah, thanks, indeed I broke that rule. This fixes it, will get it to main:
commit e167077f740b03377bc6aff09eae7f1703cd663f (HEAD -> main)
Author: Guido Martínez<EMAIL_ADDRESS>Date:   Tue Feb 6 13:01:20 2024 -0800

    pulse/lib/Makefile: fix include path

diff --git a/share/steel/examples/pulse/lib/Makefile b/share/steel/examples/pulse/lib/Makefile
index 62aa01b2..a1f8556f 100644
--- a/share/steel/examples/pulse/lib/Makefile
+++ b/share/steel/examples/pulse/lib/Makefile
@@ -1,5 +1,6 @@
 STEEL_HOME=../../../../..
 FSTAR_FILES := $(wildcard *.fst *.fsti)
+INCLUDE_PATHS=pledge
 include ../Makefile.pulse.common

 %.fst-in,%.fsti-in:

Is there actually a reason we don't build that target by default?

We build the parent directory (share/steel/examples/pulse) which generates a (bigger) .depend file, and checks all the files under lib/ too. This makefile is not hierarchical, it's just separate from this one, so if we were to also make this target we would build everything under lib twice. I guess this target is more of a convenience feature.. ideally it would reuse the dependency analysis of the parent but just restrict to building files under lib.


Resolve coverage-pools contracts

We are adding a new functionality of coverage pools to the Keep Network.
The contracts required for its support are stored in the
coverage-pools repo and are deployed to the npm registry thanks to the
coverage-pools/.github/workflows/contracts.yml workflow.
In this PR we are updating the workflow building Token Dashboard to
use those published coverage-pools contracts.

NOTE: If changes from https://github.com/keep-network/keep-core/pull/2532 get merged to main before this PR, there will be additional commit here. And if otherwise, additional commit will be needed in https://github.com/keep-network/keep-core/pull/2532.


⚠ ClamAV has degraded performance

In 1a4f0b7, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 211 ms

Resolved: ClamAV performance has improved in bc1bd6e.


not work well in macOS high Serria

Me too.
After updating my macOS, Sketch crashed every time when I exported my spec ...Q_Q

+1

@utom It's likely that this issue can be safely closed now.


Basic webpage for opportunities added

Pull Request
resolves #1339
Description
Please include a summary of the changes and the related issue.
This pull has the basic website, with main section, the navbar, footer and slider. In next pulls I will be adding the sub-sections of the page.
Type of change

[ ] Adding a new Resource
[ ] Adding a new Category
[ ] Documentation enhancement or fixes
[x] Website enhancement or fixes

Checklist:

[x] I read carefully CONTRIBUTING.md
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation

Screenshots (if appropriate):
Please add screenshots to help explain your changes.
Additional

Did you create seperate html for it?

Can you just add it inside the nav items?

Yes a separate html, adding to navbar

Please check now

Can I see the output in your end? I cant really tell just by looking at the changes.

or even a short mp4 to demo how it looks, for example, when I clicked the navigation item, where would it go? What would happen if I clicked jobs or opportunities? Does the search component work? Just to get an idea

No, the separate sections doesn't work yet. To keep commit history clean, I have added the overall UI first, I will be adding other functionalities in next PR(s). The navbar work now, it directs to Opportunities page

Sounds good. Thanks


It does not show play list in mongard.ir

Describe the bug
I tried to download a video but your plugin does not work on any video in "mongard.ir"
Desktop (please complete the following information):

OS: [windows and ubuntu]
Browser [chrome]

Hi
i'm the owner of mongard.ir
this is not really a bug in hls-web-extension.
you cant download any of my videos :)

Hi Mr. Amir
I mean any sites which use blob protocol to stream videos and your website is just an example.


STARTTLS at userdefined SMTP configuration not working

Using version 1.1.2 & 1.1.1_
Problem: SMTP connection which requires STARTTLS is no longer working
When using user defined SMTP configuration there is no option to configure STARTTLS.
While downloading the system.adapter.email.0.json file I can see, that the option "requireTLS":false, is set, which is not working.
After Rolling back to version 1.1.0 it's working again.

I can confirm this issue!

In 1.1.x there is a new checkbox "Always use STARTTLS:" ... how you set that? Please show screenshot of you confog

Ahhh I see .. the checkbox is hidden ... grmmpff... Can you please try GitHub version?

Well, I can see the checkbox now.
Test was successful

fixed in 1.1.3


[Bug]: Unmatched version<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>

Version
0.5.6

Details
Unmatched version<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>
maybe @rspack/binding-linux-arm64-musl don't have 0.5.9-canary-8778e17-2024032810483 version
after rollback to<EMAIL_ADDRESS>problem resolved.
Reproduce link
N/A
Reproduce Steps
1、login linux-arm64 server
2、run rsbuild build

Fixed: https://github.com/web-infra-dev/rsbuild/releases/tag/v0.5.7


(peazip) Package is failing validation and shipping files that shouldn't be there

Chocolatey Version
2.2.2
Chocolatey License
None
Package Version
9.4.0
Current Behaviour
The ProjectSourceUrl appears to be invalid (when I go there I am getting a 504 error) so the package is failing validation.
The package is also shipping the README.md and the update.ps1 file from the repository.

Expected Behaviour
Package passes validation and only ships the files necessary.
Steps To Reproduce
N/A
Environment
N/A

Chocolatey Log
N/A

Anything else?
No response

This is waiting on the merge of #2187