Update scala-collection-compat to 2.4.0

Updates org.scala-lang.modules:scala-collection-compat from 2.3.2 to 2.4.0.
GitHub Release Notes - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.scala-lang.modules", artifactId = "scala-collection-compat" } ]

labels: library-update, semver-minor

Codecov Report

Merging #358 (71efdcc) into master (3898b6e) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #358   +/-   ##
=======================================
  Coverage   86.08%   86.08%
=======================================
  Files         108      108
  Lines        1423     1423
  Branches       34       34
=======================================
  Hits         1225     1225
  Misses        198      198

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3898b6e...71efdcc. Read the comment docs.

Codecov Report

Merging #358 (71efdcc) into master (3898b6e) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #358   +/-   ##
=======================================
  Coverage   86.08%   86.08%
=======================================
  Files         108      108
  Lines        1423     1423
  Branches       34       34
=======================================
  Hits         1225     1225
  Misses        198      198

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3898b6e...71efdcc. Read the comment docs.


snippetSupport: v:true and friendly snippets

Hello, I can't get to work "friendly-snippets" plugin completion preview with vsnip and vsnip-integ.

@yegappan can you please provide your lspOptions and completion keybinds, because I dont know whats wrong with my config, just ultisnips works

could you not open dup issue (this one same like #124 which also opened by you).
// and #182
vsnip-integ is not a plugin not provided by this author, maybe you can ask that plugin author gave some advice to integ.

could you not open dup issue (this one same like #124 which also opened by you). // and #182
vsnip-integ is not a plugin not provided by this author, maybe you can ask that plugin author gave some advice to integ.

ok

thx. if he gave some advice or did some enhance something to vsnip-integ, wish you can give feedback to #124 or #182 as well.


Crash the DB server with this query

I believe it reaches the "trivia" id and crashes.
[2022-11-12 22:12:28] DEBUG surrealdb::iam Authenticated as super user
[2022-11-12 22:12:28] DEBUG surrealdb::dbs Executing: CREATE type::thing($table, $id) CONTENT $data
[2022-11-12 22:12:28] INFO  surreal::web <IP_ADDRESS>:59429 POST /key/config/topics HTTP/1.1 200 "python-httpx/0.23.0" 3.223868ms[2022-11-12 22:12:28] DEBUG surrealdb::iam Authenticated as super user
thread 'tokio-runtime-worker' panicked at 'called `Option::unwrap()` on a `None` value', lib/src/sql/strand.rs:156:36
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
Aborted (core dumped)

import asyncio
from pprint import pprint
from surrealdb.clients.http import HTTPClient

# create a new client to connect to SurrealDB
client = HTTPClient(
    ip,
    namespace='test1',
    database='a',
    username='root',
    password='root',
)

defaults_example = {
    'color': 'red',
    'channel_id': 123456789,
    'topics': [
        'abcd',
        'defg',
        'hijk'
    ],
    'trivia': [
        {
            'Question': 'How many?',
            'Answer': '2',
        },
        {
            'Question': 'What is Obama\'s last name?',
            'Answer': '😐'
        }
    ]
}

async def config_test():
    for id, data in defaults_example.items():
        response = await client.create_one('config', id, data)
        pprint(response)

async def select_all():
    response = await client.select_all('config')
    pprint(response)

async def main():
    await config_test()
    await select_all()

asyncio.run(main())

I'm aware it's the incorrect usage, just thought i'd point out that it managed to crash the db iteslf.

i think this is an issue for the main surrealdb repo not here as it is not specific to the python driver.

Thanks for pointing this out, we've updated the Python client and are working on releasing beta9 in the coming days, which has a lot of fixes for the database. Will therefore close this issue.


Existing SSH key is overwritten

When running az vm create --generate-ssh-keys: When the option --generate-ssh-keys is called, and a private key exists in ~/.ssh/id_rsa, but there is not a public key in ~/.ssh/id_rsa.pub, the existing private key is overwritten by generation of a new key pair. Correct behavior is to derive a public key from the private key using ssh-keygen -y.

@yugangw-msft

I think the overwritten is particularly bad.

Let me see how much we can do here.


Throw an error if defined after babel-plugin-styled-components

@nvanselow What do you think of this? https://github.com/TrevorBurnham/babel-plugin-namespace-styled-components/pull/5

Nice one! I commented on the PR in your repo as well. Feel free to open a PR here so we can merge it in.

Just checking in. Did you want to open a PR against this repo so we can merge it into the plugin here @TrevorBurnham?

@nvanselow I think it might be easier for you to do it on your end. The trouble is that I don't have a way to test out the functionality without spinning up a new project that uses this plugin.


feat: playwright github action

Description
This change enables running playwright tests as a GitHub action.
Additionally, the playwright.config.ts includes an update to start the development server before running tests.
Type of change
Please delete options that are not relevant.

[x] New feature (non-breaking change which adds functionality)

How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

[x] Build passed locally

Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes

Legal
This project is available under the Apache 2.0 License.

Be sure to checkout the test run artifact at https://github.com/awslabs/iot-application/actions/runs/4474738764.

Be sure to checkout the test run artifact at https://github.com/awslabs/iot-application/actions/runs/4474738764.

html looks great <3
Suggestion: Can we view the result without downloads? How about something like deploying the report html file to github static page (example, another)?

Be sure to checkout the test run artifact at https://github.com/awslabs/iot-application/actions/runs/4474738764.

html looks great <3
Suggestion: Can we view the result without downloads? How about something like deploying the report html file to github static page (example, another)?

That's a great idea! Thanks for the links! Do you know if we can deploy multiple items to GH pages? For example, docs and the playwright report?


 Manually calling the MNZST OFF command via the Home Assistant service call does work and correctly turn off the all zone stereo.
NOTE: Haven't actually tested this change just yet
EDIT: Just tested and confirmed it works

You're right. That's a bug. Thanks for fixing 😄


Fix datepicker mess

At the moment we have dateinput timeinput timeselector and datepickerinput.
Gonna rationalise this and clean up the controls, hook bindings properly etc.
Definately a breaking change ;)

All done, renamed datepickerinput to calendar input and leaving the rest of that one to Jonny ;)


METRON-1839 Install Elasticsearch MPack Step in Ansible Not Idempotent

When re-provisioning the development environment, the "Install Elasticsearch MPack on Ambari Host" step will fail.  This step needs to be idempotent so it succeeds when re-provisioned.
Steps to Replicate

Start the development environment.
cd metron-deployment/development/centos6
vagrant up

Re-provision the environment.
vagrant provision

This will fail with the following error message.
TASK [ambari_master : Install Elasticsearch MPack on Ambari Host] **************
fatal: [node1]: FAILED! => {"changed": true, "cmd": "ambari-server install-mpack --mpack=/tmp/elasticsearch_mpack-<IP_ADDRESS>.tar.gz", "delta": "0:00:00.360554", "end": "2018-10-20 17:13:54.836885", "msg": "non-zero return code", "rc": 255, "start": "2018-10-20 17:13:54.476331", "stderr": "", "stderr_lines": [], "stdout": "Using python /usr/bin/python\nInstalling management pack\nERROR: Management pack elasticsearch-ambari.mpack-5.6.2 already installed!\nERROR: Exiting with exit code -1. \nREASON: Management pack elasticsearch-ambari.mpack-5.6.2 already installed!", "stdout_lines": ["Using python /usr/bin/python", "Installing management pack", "ERROR: Management pack elasticsearch-ambari.mpack-5.6.2 already installed!", "ERROR: Exiting with exit code -1. ", "REASON: Management pack elasticsearch-ambari.mpack-5.6.2 already installed!"]}
to retry, use: --limit @/Users/nallen/tmp/metron-pr1238/metron-deployment/development/centos6/ansible/playbook.retry

PLAY RECAP *********************************************************************
node1 : ok=36 changed=5 unreachable=0 failed=1

Ansible failed to complete successfully. Any error output should be
visible above. Please fix these errors and try again.

Root Cause
While the Elasticsearch mpack tarball is named with the Metron version (elasticsearch_mpack-<IP_ADDRESS>.tar.gz), when installed the install path on disk uses the Elasticsearch version 5.6.2 (/var/lib/ambari-server/resources/mpacks/elasticsearch-ambari.mpack-5.6.2).
Previously, the expected install path on disk was wrong.  This made the task always attempt to re-install the mpack.  The reinstall of an mpack failed since the --force option is not used.
Testing

Spin-up a development environment.
cd metron-deployment/development/centos6
vagrant up

Re-provision the same environment after the fist completes.
vagrant --ansible-skip-tags="build,sensors" provision

If the re-provision makes it past the "Install Elasticsearch MPack on Ambari Host" step, the change is good.

Pull Request Checklist

[x] Is there a JIRA ticket associated with this PR? If not one needs to be created at Metron Jira.
[x] Does your PR title start with METRON-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
[x] Has your PR been rebased against the latest commit within the target branch (typically master)?
[x] Have you included steps to reproduce the behavior or problem that is being changed or addressed?
[x] Have you included steps or a guide to how the change may be verified and tested manually?
[x] Have you ensured that the full suite of tests and checks have been executed in the root metron folder via:
[ ] Have you written or updated unit tests and or integration tests to verify your changes?
[x] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
[ ] Have you verified the basic functionality of the build by building and running locally with Vagrant full-dev environment or the equivalent?

+1
Thanks for the fix @nickwallen !

Re-created the problem first by:
a) Running vagrant up
b) Then attempting vagrant provision again
c) Noticed the following error (which I have also seen previously many times!):

TASK [ambari_master : Install Elasticsearch MPack on Ambari Host] **************
fatal: [node1]: FAILED! => {"changed": true, "cmd": "ambari-server install-mpack --mpack=/tmp/elasticsearch_mpack-<IP_ADDRESS>.tar.gz", "delta": "0:00:00.433435", "end": "2018-10-21 18:12:29.939320", "msg": "non-zero return code", "rc": 255, "start": "2018-10-21 18:12:29.505885", "stderr": "", "stderr_lines": [], "stdout": "Using python  /usr/bin/python\nInstalling management pack\nERROR: Management pack elasticsearch-ambari.mpack-5.6.2 already installed!\nERROR: Exiting with exit code -1. \nREASON: Management pack elasticsearch-ambari.mpack-5.6.2 already installed!", "stdout_lines": ["Using python  /usr/bin/python", "Installing management pack", "ERROR: Management pack elasticsearch-ambari.mpack-5.6.2 already installed!", "ERROR: Exiting with exit code -1. ", "REASON: Management pack elasticsearch-ambari.mpack-5.6.2 already installed!"]}
	to retry, use: --limit @/Users/asubramanian/Desktop/Metron/anand-metron-fork/metron-latest/metron/metron-deployment/development/centos6/ansible/playbook.retry

Destroyed the VM, applied the fix and
a) Running vagrant up
b) Then ran vagrant --ansible-skip-tags="build,sensors" provision to see that the ES mpack install goes through fine:

TASK [ambari_master : Install Elasticsearch MPack on Ambari Host] **************
ok: [node1]

+1
Thanks for the fix @nickwallen !

Re-created the problem first by:
a) Running vagrant up
b) Then attempting vagrant provision again
c) Noticed the following error (which I have also seen previously many times!):

TASK [ambari_master : Install Elasticsearch MPack on Ambari Host] **************
fatal: [node1]: FAILED! => {"changed": true, "cmd": "ambari-server install-mpack --mpack=/tmp/elasticsearch_mpack-<IP_ADDRESS>.tar.gz", "delta": "0:00:00.433435", "end": "2018-10-21 18:12:29.939320", "msg": "non-zero return code", "rc": 255, "start": "2018-10-21 18:12:29.505885", "stderr": "", "stderr_lines": [], "stdout": "Using python  /usr/bin/python\nInstalling management pack\nERROR: Management pack elasticsearch-ambari.mpack-5.6.2 already installed!\nERROR: Exiting with exit code -1. \nREASON: Management pack elasticsearch-ambari.mpack-5.6.2 already installed!", "stdout_lines": ["Using python  /usr/bin/python", "Installing management pack", "ERROR: Management pack elasticsearch-ambari.mpack-5.6.2 already installed!", "ERROR: Exiting with exit code -1. ", "REASON: Management pack elasticsearch-ambari.mpack-5.6.2 already installed!"]}
	to retry, use: --limit @/Users/asubramanian/Desktop/Metron/anand-metron-fork/metron-latest/metron/metron-deployment/development/centos6/ansible/playbook.retry

Destroyed the VM, applied the fix and
a) Running vagrant up
b) Then ran vagrant --ansible-skip-tags="build,sensors" provision to see that the ES mpack install goes through fine:

TASK [ambari_master : Install Elasticsearch MPack on Ambari Host] **************
ok: [node1]

+1
Thanks for the fix @nickwallen ! I have seen this issue previously as well.

Re-created the problem first by:
a) Running vagrant up
b) Then attempting vagrant provision again
c) Noticed the following error:

TASK [ambari_master : Install Elasticsearch MPack on Ambari Host] **************
fatal: [node1]: FAILED! => {"changed": true, "cmd": "ambari-server install-mpack --mpack=/tmp/elasticsearch_mpack-<IP_ADDRESS>.tar.gz", "delta": "0:00:00.433435", "end": "2018-10-21 18:12:29.939320", "msg": "non-zero return code", "rc": 255, "start": "2018-10-21 18:12:29.505885", "stderr": "", "stderr_lines": [], "stdout": "Using python  /usr/bin/python\nInstalling management pack\nERROR: Management pack elasticsearch-ambari.mpack-5.6.2 already installed!\nERROR: Exiting with exit code -1. \nREASON: Management pack elasticsearch-ambari.mpack-5.6.2 already installed!", "stdout_lines": ["Using python  /usr/bin/python", "Installing management pack", "ERROR: Management pack elasticsearch-ambari.mpack-5.6.2 already installed!", "ERROR: Exiting with exit code -1. ", "REASON: Management pack elasticsearch-ambari.mpack-5.6.2 already installed!"]}
	to retry, use: --limit @/Users/asubramanian/Desktop/Metron/anand-metron-fork/metron-latest/metron/metron-deployment/development/centos6/ansible/playbook.retry

Destroyed the VM, applied the fix and
a) Running vagrant up
b) Then ran vagrant --ansible-skip-tags="build,sensors" provision to see that the ES mpack install goes through fine:

TASK [ambari_master : Install Elasticsearch MPack on Ambari Host] **************
ok: [node1]

+1
Thanks for the fix @nickwallen ! I have seen this issue previously as well.

Re-created the problem first by:
a) Running vagrant up
b) Then attempting vagrant provision again
c) Noticed the following error:

TASK [ambari_master : Install Elasticsearch MPack on Ambari Host] **************
fatal: [node1]: FAILED! => {"changed": true, "cmd": "ambari-server install-mpack --mpack=/tmp/elasticsearch_mpack-<IP_ADDRESS>.tar.gz", "delta": "0:00:00.433435", "end": "2018-10-21 18:12:29.939320", "msg": "non-zero return code", "rc": 255, "start": "2018-10-21 18:12:29.505885", "stderr": "", "stderr_lines": [], "stdout": "Using python  /usr/bin/python\nInstalling management pack\nERROR: Management pack elasticsearch-ambari.mpack-5.6.2 already installed!\nERROR: Exiting with exit code -1. \nREASON: Management pack elasticsearch-ambari.mpack-5.6.2 already installed!", "stdout_lines": ["Using python  /usr/bin/python", "Installing management pack", "ERROR: Management pack elasticsearch-ambari.mpack-5.6.2 already installed!", "ERROR: Exiting with exit code -1. ", "REASON: Management pack elasticsearch-ambari.mpack-5.6.2 already installed!"]}
	to retry, use: --limit @/Users/asubramanian/Desktop/Metron/anand-metron-fork/metron-latest/metron/metron-deployment/development/centos6/ansible/playbook.retry

Destroyed the VM, applied the fix and
a) Running vagrant up
b) Then ran vagrant --ansible-skip-tags="build,sensors" provision to see that the ES mpack install goes through fine:

TASK [ambari_master : Install Elasticsearch MPack on Ambari Host] **************
ok: [node1]

+1
Thanks for the fix @nickwallen ! I have bumped into this issue previously as well.

Re-created the problem first by:
a) Running vagrant up
b) Then attempting vagrant provision again
c) Noticed the following error:

TASK [ambari_master : Install Elasticsearch MPack on Ambari Host] **************
fatal: [node1]: FAILED! => {"changed": true, "cmd": "ambari-server install-mpack --mpack=/tmp/elasticsearch_mpack-<IP_ADDRESS>.tar.gz", "delta": "0:00:00.433435", "end": "2018-10-21 18:12:29.939320", "msg": "non-zero return code", "rc": 255, "start": "2018-10-21 18:12:29.505885", "stderr": "", "stderr_lines": [], "stdout": "Using python  /usr/bin/python\nInstalling management pack\nERROR: Management pack elasticsearch-ambari.mpack-5.6.2 already installed!\nERROR: Exiting with exit code -1. \nREASON: Management pack elasticsearch-ambari.mpack-5.6.2 already installed!", "stdout_lines": ["Using python  /usr/bin/python", "Installing management pack", "ERROR: Management pack elasticsearch-ambari.mpack-5.6.2 already installed!", "ERROR: Exiting with exit code -1. ", "REASON: Management pack elasticsearch-ambari.mpack-5.6.2 already installed!"]}
	to retry, use: --limit @/Users/asubramanian/Desktop/Metron/anand-metron-fork/metron-latest/metron/metron-deployment/development/centos6/ansible/playbook.retry

Destroyed the VM, applied the fix and
a) Running vagrant up
b) Then ran vagrant --ansible-skip-tags="build,sensors" provision to see that the ES mpack install goes through fine:

TASK [ambari_master : Install Elasticsearch MPack on Ambari Host] **************
ok: [node1]

+1
Thanks for the fix @nickwallen ! I have bumped into this issue previously as well.

Re-created the problem first by:
a) Running vagrant up
b) Then attempting vagrant provision again
c) Noticed the following error:

TASK [ambari_master : Install Elasticsearch MPack on Ambari Host] **************
fatal: [node1]: FAILED! => {"changed": true, "cmd": "ambari-server install-mpack --mpack=/tmp/elasticsearch_mpack-<IP_ADDRESS>.tar.gz", "delta": "0:00:00.433435", "end": "2018-10-21 18:12:29.939320", "msg": "non-zero return code", "rc": 255, "start": "2018-10-21 18:12:29.505885", "stderr": "", "stderr_lines": [], "stdout": "Using python  /usr/bin/python\nInstalling management pack\nERROR: Management pack elasticsearch-ambari.mpack-5.6.2 already installed!\nERROR: Exiting with exit code -1. \nREASON: Management pack elasticsearch-ambari.mpack-5.6.2 already installed!", "stdout_lines": ["Using python  /usr/bin/python", "Installing management pack", "ERROR: Management pack elasticsearch-ambari.mpack-5.6.2 already installed!", "ERROR: Exiting with exit code -1. ", "REASON: Management pack elasticsearch-ambari.mpack-5.6.2 already installed!"]}
	to retry, use: --limit @/Users/asubramanian/Desktop/Metron/anand-metron-fork/metron-latest/metron/metron-deployment/development/centos6/ansible/playbook.retry

Destroyed the VM, applied the fix and
a) Running vagrant up
b) Then ran vagrant --ansible-skip-tags="build,sensors" provision to see that the ES mpack install goes through fine:

TASK [ambari_master : Install Elasticsearch MPack on Ambari Host] **************
ok: [node1]


fix simplify airthmetic should not change return type (#31237)

pick from master #31237
commit id abb98747a6400e007c063e5a17b0d97d8249c8b5
Proposed changes
Issue Number: close #xxx

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall

run buildall


33 | Search in Rotated Sorted Array | Python

Leetcode Question no. - 33
Problem name - Search in Rotated Sorted Array
Instructions

Create a new folder for your script and file/folder name should be appropriate.
Create a README.md in your folder for program Instructions
add requirements.txt if needed

Programming Language

[x] Python

Happy Coding

This will be done , just need two days .


Remove deprecated org.gradle.api.internal.artifacts.dsl.dependencies.DependencyFactory

Remove usage in DependencyNotationParser.
Update smoke test with latest version of Gretty to pass.

Fixes #21879
Will also need a change for 7.6 to @Deprecate the class to be removed, see: #21886

@bot-gradle test this

OK, I've already triggered the following builds for you:

PullRequestFeedback build

OK, I've already triggered the following builds for you:

PullRequestFeedback build

@octylFractal - This is the smoke test failing with Gretty 3x I mentioned.

This is waiting for https://github.com/gretty-gradle-plugin/gretty/pull/265 to be merged and a new Gretty version to fix the Gretty 3x branch.

@bot-gradle test this

@bot-gradle test this

OK, I've already triggered the following builds for you:

PullRequestFeedback build

We are going to remove this type in 7.6 via https://github.com/gradle/gradle/pull/21920, since there are now upgrade paths in both Gretty 3.x and 4.x, which is the only smoke test using this class and it is internal.  This PR is no longer needed.


Idea: Contract Transfer command

As a Sia host it would be nice to be able to move your contracts to another host gracefully. How this would work.
You have a host hosting 100GB of things. You transfer those contracts to another host with 100GB of space. The current host would be responsible for the difference in hosting cost. (perhaps a max transfer cost difference of +5%). Once transfer is complete your contract with the renter is considered ended and your collateral returned.
This would increase the stability of hosting for renters, and allow hosts to be able to take down their servers more gracefully. The only current solution is wait out the contracts, or take the collateral hit.

I am in this situation right now, where I want to clean up and reorganize my disk usage, so I am trying to wait out my duration with by not accepting any new contracts.  Having a command to allow the network to reshuffle, protecting the renter from losing redundancy, even if I as the host have to pay for it would be fantastic.

Me as well. @darval @kassimila do you know if we can just directly copy the renter folder over?

I was reading that you can copy the folder over to a new host and stand it up there provided the path and everything is the same. This is workable when dealing with small data sets, however the ability to 'sublet' seems like a more enterprise level approach to the issue.

I envisioned this as not knowing who was going to take over.  Just the ability for the host, to relinquish the role, pay a fee, and the system will migrate the chunks over to other hosts, and when completed, free up the hosts storage and collateral.
I know it is not that simple, but from the users perspective, that is what I was hoping.  Given the way the contracts work, the host still may not be able to get the collateral back until the original contract is over, but at least they won't have to keep hosting while waiting.

So the one issue I see with that would be the difference in transfer costs. Lets say your host was charging 5sc for download, and theirs was 150. You would need to account for that somehow to be fair to the renter.

Remember from the renters point of view, if the host just quits, the hosts loses the collateral, but the renter will still have to pay the new costs, assuming they want to maintain their redundancy.  I assume the "system" would just select a new host for redundancy and the renter will pay whatever is needed given the new host.

I am, what I am considering is the following. So I setup a 3 TB host REALLY cheap, some guy rents it. Ok so now I transfer the contract to my other 3TB host same hosting cost, but the upload/download costs are insane. That's not what the renter signed up for.

I will note that it's already possible to end a contract prematurely; just submit the most recent contact revision to the blockchain, and the coins in the contract will be returned immediately. We don't currently have any user-facing support for this, but I'm definitely in favor of adding it.

@lukechampine this is related to #2246 , but I think the ability to cancel contracts would be amazing. Also, when you type in siac renter contracts, I would love to be able to see a split between fees spent on hosting vs. contract fees. If the allowance is under 1KS, when the contracts are first created, over 20-30% of the entire remaining funds for many contracts are already "spent". When it's under 500SC, it's over 70-80%. It's very confusing (and frustrating).

Seems like this process could utilize the recent file repair machinery. So A host could indicate that they want to stop hosting, but not take their storage offline until the repair code had done it's job of relocating the files elsewhere.

@eddiewang I was slightly mistaken; see my EDIT above.

@lukechampine Sounds like a good idea. It's inevitable that hosts will wish to take their storage down for various real life things. Or just to rebuild a raid. :P

@lukechampine thinking this through, would there be a reason a host would be incentivized not to let the renter cancel the contract? If not, this would be a useful RPC to implement.

@eddiewang Could be done as some sort of mutual agreement thing? Would be a lot simpler to do if you got rid of 'upload/download' pricing and just did a single 'bandwidth' price. I'm not sure about the value in charging a different rate for each direction.

@eddiewang there are competing concerns. The host clearly would like to retain any contracts that it believes can make it money, and drop any contracts that it believes will not make it any money. If a renter requests the "cancel" RPC, it's a strong sign that the renter does not intend to use the contract anymore. If the host has high storage utilization, it will gladly drop the contract to free up space for a more profitable contract. Hosts may also be incentivized to drop contracts early in order to limit their exposure to siacoin price fluctuations. On the other hand, if the host has low utilization, there is little incentive for it to drop the contract, since in the worst case it will make 0 coins, and in the best case it will continue to be used despite the "cancel" RPC. We could tip the scales a little further by penalizing hosts that refuse "cancel" RPCs, I suppose, but it may not be necessary.

@lukechampine @eddiewang - So I think I have a way to make it mutually beneficial for both parties. So example transaction (Host) is hosting 100GB for someone. Charge is 100SC /month, 10sc bandwidth, 100SC collateral. The host can gracefully cancel the contract at any time, however 10% of the collateral would go to the renter, in this case 10 SC. The renter can also cancel at any time, however they too would be responsible for paying the host 10 SC. If the host just goes offline never to be seen again, renter would get the 100 SC as normal. This process would be beneficial to everyone, allow for a nice way to early end contracts. It would also promote higher collateral amounts since they would have more meaning. What are your thoughts on this?

@lukechampine if a renter sends a cancel RPC, it's a strong signal that the renter no longer wishes to engage in the contract. As it stands, it is just as easy (although cumbersome) to simply delete my renter folder and remake contracts with new hosts, given that as a renter I have enough funds to do so.
For an underutilized host, a cancelled contract gives more flexibility to spin down their operations, as their collateral risk is greatly reduced with cancelled contracts. In the underutilized host's worst case, it's less than 0 coins, it's actually negative if you factor in the risks related with storing the data (if the hardware breaks, network goes down, or other server issues).

Recommendation to Devs: "Feature Request"


Possibility for both Left and Right Menus.

Hi ,
I am using the "https://components.xamarin.com/view/sidebarnavigation",in my iOS App.
Can I have the both left and right menu's in the SidebarController,
I think it is not possible with control itself,as it is a enum.
Or Please mention what customisations required to make the sidebar to support the both left and right menus.
Thanks in advance.

You should be able to next the navigations menus. Create one and set it's content view to your content view controller. Then create a second one and set its content to the first navigation menu. Just set one to open from left and the other to open from the right.

I didn't that,Please provide more information.
There is no need to MenuLocations Enum for SideBarController?

Would it be possible to get a code complete example of both left and right side slideout menus?


The Sass test example is missing the plugin

Get an error for when testing the sass example.

I have the solution and will push a quick fix PR

Good find
On Fri, Dec 8, 2017 at 6:06 PM Tony Alves<EMAIL_ADDRESS>wrote:

Get an error for when testing the sass example.
[image: image]
https://user-images.githubusercontent.com/784848/33791568-7828a368-dc42-11e7-8a74-688e002eb7a3.png
I have the solution and will push a quick fix PR
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/nozzle/react-static/issues/228, or mute the thread
https://github.com/notifications/unsubscribe-auth/AFUmCeT-ow94aMJJ6ai_drFWTj0NGznjks5s-es-gaJpZM4Q728J
.


Cant change background color

Cant figure out how to change the background color to the theme background color. Been looking at it for hours. It always defaults back to the card color, but I'm using it as a standalone without a 'card', so i want it to be the default theme background color. I tried changing the .js but any changes i make don't seem to take effect no matter what i reload or restart.
Please help

Yeah I have the same error and card_mod does not seem to work on it either.

See no issues here.
Default dark theme:

Can change a background:


More Actions Drop Down Menu - Native Notebook Editor

"More Actions" drop down menu only displayed in a stable manner when in cell selected mode.
When in cell editor mode, menu drop down and cell editor outline flashing.

[ ] Drop down menu should be displayed in a stable manner in either mode.

[ ] "Change cell to Code" should only be option for a markdown cell and vice versa.

Merging the first into #103926, the second into #103922


Cannot init the PersistentContainer

let persistentContainer = PersistentContainer()
Thread 1: Fatal error: 'try!' expression unexpectedly raised an error: AlecrimCoreData.PersistentContainerError.invalidManagedObjectModelURL

Hello. The convenience methods with optional parameters are things I think if they are really a good idea to keep in the framework.
In the case you brought, the framework is trying to infer the Core Data model URL using the framework name (AlecrimCoreData in this case). This code was made this way thinking in subclasses. But this is not well documented.
I think passing the name in the first parameter of your core data model file may work. If not, let me know.

    public convenience init(name: String? = nil) {
        try! self.init(name: name, managedObjectModel: type(of: self).managedObjectModel(), storageType: .disk, persistentStoreURL: try! type(of: self).persistentStoreURL(), persistentStoreDescriptionOptions: nil, ubiquitousConfiguration: nil)
    }

The convenience 'init' method does not passing the 'name' parameter to 'managedObjectModel'  method.
    public static func managedObjectModel(withName name: String? = nil, in bundle: Bundle? = nil) throws -> NSManagedObjectModel {
        let bundle = bundle ?? Bundle(for: Self.self)
        let name = name ?? bundle.bundleURL.deletingPathExtension().lastPathComponent

        let managedObjectModelURL = try self.managedObjectModelURL(withName: name, in: bundle)

        guard let managedObjectModel = NSManagedObjectModel(contentsOf: managedObjectModelURL) else {
            throw PersistentContainerError.managedObjectModelNotFound
        }

        return managedObjectModel
    }

And in the 'managedObjectModel' method, it using the bundle of AlecrimCoreData Framework but not the Application bundle.
Should I subclass the PersistentContainer before using it?

Same here, do you have any idea ?

I'm going through personal problems, sorry for the delay in answering.
@YLKwan: Subclassing the PersistentContainer class may work, using a constructor like this:
public init() throws {
    let managedObjectModel = ...
    let persistentStoreURL = ...

    try super.init(managedObjectModel: managedObjectModel, storageType: .disk, persistentStoreURL: persistentStoreURL)
}

@kvacquier: A future update should improve how this is done in the framework.

try using this extension for temporary fix
extension PersistentContainer {

	public convenience init(name: String? = nil) {
		try! self.init(name: name, managedObjectModel: type(of: self).managedObjectModel(withName: name, in: Bundle.main), storageType: .disk, persistentStoreURL: try! type(of: self).persistentStoreURL(), persistentStoreDescriptionOptions: nil, ubiquitousConfiguration: nil)
	}
}


Add bolt action and pump action for guns

About the PR

list of guns, that affected by PR must be equal to list of #19287
Why / Balance
Fix #19250

[X] I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes

Changelog

:cl:

fix: Some guns now have pump and bolt action again.

I remember this being just mostly unpleasant.

it makes mosin actually the shitty meme gun
and it makes kammerer not just enforcer with a few less shots

At least i can make no changes for players (all guns auto cycled), but leave ability to make guns non auto cycleable


fix: improve SSR handling of React components with children

This PR extends the React components with limited SSR functionality, which improves state detection in relation to children.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

:exclamation: No coverage uploaded for pull request base (main@2a01652). Click here to learn what that means.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2306   +/-   ##
=======================================
  Coverage        ?   93.63%
=======================================
  Files           ?      238
  Lines           ?    24287
  Branches        ?     2133
=======================================
  Hits            ?    22741
  Misses          ?     1503
  Partials        ?       43

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Recompile plugin with steampipe-plugin-sdk v4.1.13

Example query results

Results
Add example SQL query results here (please include the input queries as well)

Closing the PR in favor of https://github.com/turbot/steampipe-plugin-zoom/pull/29


Building SQLines

../sqlparser/sqlparser.a doesn't exist for use by
sqlines/sqlines/build_all64.sh
and
sqlines/sqlines/build_all.sh

Also got error:
g++: error: unrecognized command line option ‘-m32’; did you mean ‘-mbe32’?
and
g++: error: unrecognized command line option ‘-m64’
using G++:
g++ (Raspbian 8.3.0-6+rpi1) 8.3.0
Copyright (C) 2018 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.  There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
Note that this could be an issue compiling on an ARM processor, going to try x86 and x86-64

Thould that the error with the missing " ../sqlparser/sqlparser.a" could have been that it needed to be built. Went to that directory to attempt build without x86 and x86_64 flags on gcc build.


Error opening Excalidraw

I opened a new scene in my Excalidraw workspace but the scene is totally blank. URL

Chrome: Version 117.0.5938.88 (Official Build) (64-bit)
Ubuntu 23.04

Hi, this is on excalidraw.com?

Yes, it works on excalidraw.com but fails on app.excalidraw.com (when I go into one of my Plus drawings)

It looks like it could be a VPN/firewall issue. I'm assuming loading user preferences to set the flag won't work, but you can pop into the dev console (Opt-Cmd-I on mac or Ctrl-Shift-I on Win) and paste this:
localStorage.setItem('FIRESTORE_LONG_POLLING', 'true')

Then reload the tab.
Let me know if it helps!

I do use a VPN for work, but I disabled it and I still see the issue.
I tried the console command and a hard refresh but the problem persists.

Hmm. This thing concerns me:

Possible your ISP / firewall somewhere down the line is blocking the QUIC protocol.
You can try disabling it in the chrome flags: chrome://flags/ (paste in the address bar)

Not quite sure that'll help though.

I reopened today and see errors which aren't the QUIC error


[Bug]: fish completions directory wrong

Version

[X] latest

version
1.0.0
Tested release files:
lsd-musl_1.0.0_amd64.deb
lsd_1.0.0_amd64.deb
What OS are you seeing the problem on?
Linux
installation
dpkg -i
term
No response
ls-colors
No response
What happened?
Fish completions end up in
/usr/share/fish/completions/completions

What expected?
Should be
/usr/share/fish/vendor_completions.d

What else?
No response

it looks like fish ship its own completions in /usr/share/fish/completions/completions, and vendors should put it in /usr/share/fish/vendor_completions.d
ref: https://fishshell.com/docs/current/completions.html
/milestone v1.1.0
/kind enhancement
/area packaging


Refactor: CGAT/PipelineGWAS.py -> CGAT/GWAS.py

Follow up https://github.com/CGATOxford/cgat/issues/352

Argg, did it without much thinking and therefore the review request.
Will revert, thanks.

Will remove unused imports on a separate PR.
Please let me know your thoughts about the latest changes.

Thank you!


Very big gridlock in static DUE scenario

I observe huge gridlock in this scenario, by running
sumo -c due.static.sumocfg
This makes the whole scenario unreal.
Is there a way to fix it?

Hi,
which version of SUMO are you using? The problem shouldn't appear with SUMO 0.26.
Regards,

I am using 0.32, but I really don't think the version of SUMO can change the performance.
The gridlock only show up at late stage (40000+s) and only show up on a particular part of the map (several streets on south-east,  for example), please refer to the snapshot in attached:

DUE stands for Dynamic User Equilibrium and is generated running 50+ cycles of simulations with SUMO 0.26. It's expected that changing the simulator, the equilibrium is gone. If you use it with another version of sumo, the traffic demand is not validated anymore.

Thank you, by changing to version 0.26.0, I do see the problem disappear. There is no cars teleporting anymore.
I still don't understand that since the route file is generated after running duaIterate. Namely, the route file you included should be the one that already achieved equilibrium, how is changing SUMO version makes difference?
Meanwhile, is there a way to have it work for SUMO 0.32?

It's not only a matter of routes, from 0.26 to 0.32 (or newer) the mobility model has changed (improved) and the interactions between vehicles are not the same anymore.
I don't have access to the validation data since I finished the PhD, so no, I cannot update this project.
I don't know what are you doing with this scenario, but if you need a scenario with an up-to-date version of SUMO, check https://github.com/lcodeca/MoSTScenario


Update manifest: Git.Git version 2.46.0

Details

Fix incorrect installer switches

Checklist for Pull Requests

[x] Have you signed the Contributor License Agreement?
[x] Resolve #173310

Manifests

[x] Have you checked that there aren't other open pull requests for the same manifest update/change?
[x] This PR only modifies one (1) manifest
[x] Have you validated your manifest locally with winget validate --manifest <path>?

[x] Does your manifest conform to the 1.6 schema?

Note: <path> is the directory's name containing the manifest you're submitting.

Microsoft Reviewers: Open in CodeFlow

@wingetbot run

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

This error seems to be occurring frequently in recent days. I'm not entirely sure, but I believe it might be related to the recent pipeline work.

This package installs and launches normally in a Windows 10 VM.


Add label Waiting for reply to bug/feature label avoid stale bot close

ref #6673

Codecov Report

Merging #6676 (c795076) into dev (ef9de9d) will increase coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##                dev    #6676   +/-   ##
=========================================
  Coverage     38.48%   38.49%
+ Complexity     3226     3225    -1
=========================================
  Files           646      646
  Lines         25886    25886
  Branches       2808     2808
=========================================
+ Hits           9963     9964    +1
- Misses        15008    15010    +2
+ Partials        915      912    -3

Impacted Files
Coverage Δ

...org/apache/dolphinscheduler/remote/utils/Host.java
37.77% <0.00%> (-2.23%)
:arrow_down:

...e/dolphinscheduler/remote/NettyRemotingClient.java
52.11% <0.00%> (-1.41%)
:arrow_down:

...dolphinscheduler/remote/future/ResponseFuture.java
83.05% <0.00%> (+1.69%)
:arrow_up:

...er/master/processor/queue/TaskResponseService.java
60.97% <0.00%> (+3.65%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ef9de9d...c795076. Read the comment docs.

But situation two in [Bug] [community] Stale bot will close issue/pr unexpected #6673, still do not have good way to fix. Some community will make stale bot only close issue with specific label, such as waiting user response. This requests issue reviewer add label waiting user response after they finish review add ask user for additional information. I do not know weather it will increase reviewer's load or not.

After discuss in meeting, we decide adding issue close days to reduce the occurrence of this situation.
For now, issue would close when it not activity in 37 days, and 127 days for PR
PTAL @dailidong @lenboo  @CalvinKirs @caishunfeng @kezhenxu94

LGTM


Ctrl-C will detach tty but not kill the process in container

I attach a running pod and run command "ping <IP_ADDRESS>" in it.
Then I try to input Ctrl-C to stop the process , but the result is I detach the Pod and the process is still running.The detail is showed as follow:
monster@monster:~/go/src/github.com/hyperhq/hyperd$ sudo ./hyperctl attach pod-DsfXyWajPy
Attach tag is t52xbqe3
ping <IP_ADDRESS>
PING <IP_ADDRESS> (<IP_ADDRESS>): 56 data bytes
64 bytes from <IP_ADDRESS>: seq=0 ttl=64 time=0.242 ms
64 bytes from <IP_ADDRESS>: seq=1 ttl=64 time=0.056 ms
64 bytes from <IP_ADDRESS>: seq=2 ttl=64 time=0.043 ms
^Cmonster@monster:~/go/src/github.com/hyperhq/hyperd$ sudo ./hyperctl attach pod-DsfWajPy
Attach tag is 5wn5oavp
64 bytes from <IP_ADDRESS>: seq=7 ttl=64 time=0.056 ms
64 bytes from <IP_ADDRESS>: seq=8 ttl=64 time=0.113 ms
64 bytes from <IP_ADDRESS>: seq=9 ttl=64 time=0.058 ms
^Cmonster@monster:~/go/src/github.com/hyperhq/hyperd$
The commit of hyperd is dc966a88ab87
The commit of runv is bf2bb08511e

when the container tty is disabled, the ctrl-c is sent to hyperctl itself only. when ctrl-c is received, the hyperctl detach without stop the container. we should keep hyperctl running in this case.


Create separate About and Partners pages

Got stuck but Elle was able to assist me with resolving the dual MyQuer error. About page info has been divided between 2 pages. Will need to either add content to whitespace created at bottom of About page or delete whitespace.

Closing this request to resolve merge conflicts and will make a new MR


Fixes array of arrays and duplicates

In some use cases it addCollection was returning nested array of arrays, and also duplicates.

Hi,
Are you perhaps also able to add a test that handles duplicate entries? Change looks good besides that, just want to expand the unit tests to cover as much of the functions as possible.

Yeah, but I need to finish some other things first.
On Fri, Jun 12, 2015 at 10:13 AM, arryon<EMAIL_ADDRESS>wrote:

Hi,
Are you perhaps also able to add a test that handles duplicate entries?
Change looks good besides that, just want to expand the unit tests to cover
as much of the functions as possible.
—
Reply to this email directly or view it on GitHub
https://github.com/arryon/sails-hook-fixtures/pull/8#issuecomment-111487329
.


[Bug] vane-portals - Exit orientation lock doesn't work while riding an entity

When you lock the exit orientation and try to enter the portal while riding an entity, this lock is not respected and you will come out the portal wrong way.
Can be dangerous in situations like this:

Video:
https://user-images.githubusercontent.com/46417703/182299565-62572763-c805-491a-8ded-26147d0a2359.mp4

Thanks for reporting this, can confirm this is a bug. I'll have a look at it when I find some free time.


claws-mail: fix attachment MIME detection, enable parallel build

Adds support for shared-mime-info to Claws, to fix attachments in
outgoing messages always having MIME type application/octet-stream
because Claws doesn't know where to look, instead complaining:
/nix/store/...-claws-mail-3.11.1/etc/mime.types: fopen: No such file or directory
Moreover, Claws relies on incoming MIME types for knowing when e.g. to
display an attached image, so sending application/octet-stream
unnecessarily is bad.
Also turns on enableParallelBuilding.
Tested against release-15.09.

ok looks fine to me

Awesome, thanks for the review and fast turnaround time.


Test random number sequence

This function checks that the sequence of uniform numbers produces white noise. The auto correlation of white noise is a Dirac delta function.
Should the random sequence show any correlation, multiple peaks would appear.

test this please

@cianciosa can you please merge in the new changes from main that @idigs made to the ExCL (onyx) workflows? Thanks!

test this please

test this please

@idigs, the onyx workflow fails to build the CPU or GPU versions. The compilers being chosen are not compiling a test code. Please try to correct this. Thanks!

@idigs scratch the previous comment. It appears to be working now :)

test this please

please test, onyx tests should fail

please test, onyx tests should pass if there's not an issue with JOB_COUNT


launcher: Drop console hack

We temporarily carried a console hack in order to allow the OpenShift
Webconsole to conncet to a VM's console. But since then we added a
API subresource which can be accessed, and it's up to the webconsole
to adjust to this new feature.
Originally introduced with #819
Fixes #834
A friendly hack we carried around for OpenShift Web Console is getting removed by this change.

Signed-off-by: Fabian Deutsch<EMAIL_ADDRESS>

I'd liekt o get this into v0.7.0

/cc @michalskrivanek

Right - Just to understand it correctly:
The current kubevirt console code uses a different transport than the k8s
container console.
The work in #1015 contains partial work to adjust the kubevirt code to have
the same transport as k8s container console.
Correct?
if so, then yes, dropping it in 0.8 is also fine for me.

The work in #1015 contains partial work to adjust the kubevirt code to have
the same transport as k8s container console.

yes it contains the necessary glue-code (the ssh sessions there are transported with the streaming protocol). That part can be copied and connected to the vm-console stream.

@mareklibra the discussion in that PR might be interesting for you.

/hold

Could you remind me what /hold means?

Could you remind me what /hold means?

Updated the comment, was bad practice that I did not also add the reason. Just meant as a marker that although the PR may be fine we have reasons to not merge it right now. I had the impression we agreed on removing it once we provide the k8s streaming protocol support.

/unhold

Just noting it here as well: The stream protocol has an issue. but there is another workaround which is to just launch the socket-connector from the terminal which is created in the webconsole for the VM serial console.


Add Mute Feedback

Feedback for all available mutes (issue #1)
HELP update
Version bump

Since the board status is live, I was able to add a toggle option to all of the mutes.


Review outstanding summer student work

We have a couple of outstanding PRs and branches from students we've hosted as summer interns to review and merge into develop
Here are some links to them (there may be more).
There may be overlap among some of these and/or some may be superseded by others:

[x] Delaunay triangulation
https://github.com/LLNL/axom/pull/742
[x] New Multimat component in Axom
https://github.com/LLNL/axom/pull/565
https://github.com/LLNL/axom/tree/feature/multimat
https://github.com/LLNL/axom/tree/feature/weiss27/multimat-rebase
[ ] New Material Interface Reconstruction (MIR) component in Axom
https://github.com/LLNL/axom/pull/54
https://github.com/LLNL/axom/tree/feature/weiss27/3D-zoo-rebase
https://github.com/LLNL/axom/tree/feature/mir
https://github.com/LLNL/axom/tree/feature/sterbentz/mir3D
[ ] Intersections of regions defined by polygons with curved edges
https://github.com/LLNL/axom/pull/112
https://github.com/LLNL/axom/pull/590
https://github.com/LLNL/axom/tree/feature/weiss27/bezier-mesh-example
https://github.com/LLNL/axom/tree/feature/gunderman/bezier-polygon

I'd like to chip away at this during FY22.
I'll likely split this into a few more manageable chunks.

The "Intersections of regions defined by polygons with curved edges" task was partially resolved in #844, which added a CurvedPolygon class and improved the BezierCurve class.
I also updated and rebased #590 on the develop branch after merging the former.

@kanye-quest updated the MultiMat branch, which was merged in #565


Update action.yml

For now is only warning, but it will be error ...
build-vcpkg-deps-linux:
Node.js 12 actions are deprecated. Please update the following actions to use Node.js 16: Kingtous/run-on-arch-action@amd64-support.
For more information see: https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/.

LGTM


How can I show last opened page?

Hi!
How can I make the activity start from the last opened page
Thank you.

store the pdf path and compare to the selected pdf if its the same use the stored page number, simple enough to implement.

when i close the app it will start from first pdf  page
i need to get last readed page

Store current page number in eg. SharedPreferences and restore it in Activity#onCreate() using .defaultPage(int) method when configuring PDFView.

So how can i store it and restore it
onSaveInstanseState() & onRestoreInstanceState()

This is core Activity lifecycle concept, you can read about it in Android docs

okay thank you


Crash using --copy-audio-name if audio track has no name

If you use the --copy-audio-name all option on an MKV that has an audio track with no name transcode-video will crash with {binpath}/transcode-video: undefined method `gsub' for nil:NilClass

@faithfracture
Thanks for raising this issue! Would you mind providing the entire command line that you used so that we can troubleshoot more effectively? This is likely going to be a @donmelton issue, but the rest of us might catch something if we can see the entire scope.
Thanks!

Sure!
This command throws the exception:
transcode-video --add-audio all --copy-audio all --copy-audio-name all --audio-width other=double --add-subtitle all --burn-subtitle scan --output transcodedVideoFile.mkv --filter decomb --filter detelecine --crop 0:0:26:8 --dry-run someVideFile.mkv
If I just remove the --copy-audio-name all parameter it runs just fine. Likewise, if I add the name field to the audio track and don't remove the --copy-audio-name all parameter it also runs as expected.

Thanks! I was hoping we'd see an easy fix, but that command line looks right. Bumping this up to Don.

If I had to guess, I'd say it's right here: https://github.com/donmelton/video_transcoding/blob/61f800fbc1e70bcdae9ace2d4c968abb4b834959/lib/video_transcoding/media.rb#L104

@faithfracture As @khaosx already wrote, thanks so much for opening this issue. And my apologies for this crash interrupting your use of transcode-video.
When you write, "if I add the name field to the audio track"... Do you mean that you modified your original MKV input file to add a name property using a tool like mkvpropedit?
If so, could you attach the output of a scan of your original unmodified file here using this command?
transcode-video -vv --scan "/path/to/Movie.mkv"

Thanks.
As to the location of the crash, I doubt it would be in the media scanning code since removing --copy-audio-name all would not prevent that code from running. But I've been wrong before. :)

Yep. I use the MKVToolNix mac GUI app, but yes - mkvpropedit.
Here's the output from transcode-video
Output
$:  transcode-video -vv --scan 0001-3483.mkv
transcode-video 0.25.1
Copyright (c) 2013-2019 Don Melton
Processing: 0001-3483.mkv...
Scanning media title 1 with HandBrakeCLI...
HandBrake 1.2.2 found...
[08:39:32] hb_init: starting libhb thread
[08:39:32] thread 7000011e5000 started ("libhb")
HandBrake 1.2.2<PHONE_NUMBER>) - Darwin x86_64 - https://handbrake.fr
24 CPUs detected
Opening 0001-3483.mkv...
[08:39:32] CPU: Intel(R) Xeon(R) CPU E5-2697 v2 @ 2.70GHz
[08:39:32]  - Intel microarchitecture Ivy Bridge
[08:39:32]  - logical processor count: 24
[08:39:32] hb_scan: path=0001-3483.mkv, title_index=1
udfread ERROR: ECMA 167 Volume Recognition failed
disc.c:323: failed opening UDF image 0001-3483.mkv
disc.c:424: error opening file BDMV/index.bdmv
disc.c:424: error opening file BDMV/BACKUP/index.bdmv
[08:39:32] bd: not a bd - trying as a stream/file instead
libdvdnav: Using dvdnav version 6.0.0
libdvdread: Encrypted DVD support unavailable.
libdvdread:DVDOpenFileUDF:UDFFindFile /VIDEO_TS/VIDEO_TS.IFO failed
libdvdread:DVDOpenFileUDF:UDFFindFile /VIDEO_TS/VIDEO_TS.BUP failed
libdvdread: Can't open file VIDEO_TS.IFO.
libdvdnav: vm: failed to read VIDEO_TS.IFO
[08:39:32] dvd: not a dvd - trying as a stream/file instead
Input #0, matroska,webm, from '0001-3483.mkv':
  Metadata:
    SCENE           : Scene
    FILE            : /Volumes/Tantiss/video_transcoding/done/Dirty_Dancing/original/Emile_Ardolino_Q&A-featurette.blend
    DATE            : 2019/05/15 08:32:59
    ENCODER         : Lavf58.12.100
  Duration: 00:01:56.22, start: 0.000000, bitrate: 6023 kb/s
    Stream #0:0: Video: h264 (High), yuv420p(progressive), 1920x1080 [SAR 1:1 DAR 16:9], 29.97 fps, 29.97 tbr, 1k tbn, 59.94 tbc (default)
    Metadata:
      DURATION        : 00:01:56.216000000
    Stream #0:1: Audio: aac (LC), 48000 Hz, stereo, fltp (default)
    Metadata:
      DURATION        : 00:01:56.181000000
[08:39:32] scan: decoding previews for title 1
[08:39:32] scan: audio 0x1: aac, rate=48000Hz, bitrate=1 Unknown (AAC LC) (2.0 ch)
[08:39:32] scan: 2 previews, 1920x1080, 29.970 fps, autocrop = 0/0/0/0, aspect 16:9, PAR 1:1
[08:39:32] libhb: scan thread found 1 valid title(s)
+ title 1:
  + stream: 0001-3483.mkv
  + duration: 00:01:56
  + size: 1920x1080, pixel aspect: 1/1, display aspect: 1.78, 29.970 fps
  + autocrop: 0/0/0/0
  + chapters:
    + 1: cells 0->0, 0 blocks, duration 00:01:56
  + audio tracks:
    + 1, Unknown (AAC LC) (2.0 ch) (iso639-2: und)
  + subtitle tracks:
HandBrake has exited.

{:title=>1, :size=>87500085, :directory=>false, :duration=>116, :width=>1920, :height=>1080, :fps=>29.97, :autocrop=>nil, :audio=>{1=>{:format=>"AAC LC", :channels=>2.0, :language=>"und", :bps=>nil, :stream=>1, :default=>true, :name=>nil}}, :subtitle=>{}, :h264=>true, :hevc=>false, :mpeg2=>false, :stream=>0, :bd=>false, :dvd=>false, :mkv=>true, :mp4=>false}
+ title 1:
  + stream: 0001-3483.mkv
  + duration: 00:01:56
  + size: 1920x1080, pixel aspect: 1/1, display aspect: 1.78, 29.970 fps
  + chapters:
    + 1: cells 0->0, 0 blocks, duration 00:01:56
  + audio tracks:
    + 1, Unknown (AAC LC) (2.0 ch) (iso639-2: und)
  + subtitle tracks:
Done.

Background on how this file came to be: I grabbed a few different interview clips that were originally separate titles on a DVD and used Blender to add a text scene with the question & the corresponding video so I could just have them all in one video file for my Plex server. First time I've used Blender to do this, so I didn't really pay any attention to the details of what it was spitting out. Just checked that it produced a video file that contained & played what I expected it to.
Not much of an interruption really. gsub looked to be a string manipulation function or something, so it seemed natural to look for parameters that dealt with text (like audio names, subtitles, etc). Just divide-and-conqure the parameters. Didn't really take too long to figure it out.
Only reason I thought that might be the place is it looks like that bit is grabbing the audio name from a collecting & calling gsub on it (which is what the displayed undefined method was anyways). Assuming Ruby lets you jam nil values into a collection, that just seemed like an obvious place. (If I knew anything about debugging Ruby (or had the time to figure it out) I'd probably just try to find it myself.)

@faithfracture Thanks for the quick response! And from the dump of the media.info hash in your scan output I can see :name=>nil there. Which is causing the following code in the the prepare_audio function in the actual transcode-video source file problems:
        info = media.info[:audio][track]
        copy = (@copy_audio.first == :all or @copy_audio.include? track)

        if @copy_audio_name.first == :all or @copy_audio_name.include? track
          name = info.fetch(:name, '')
        else
          name = ''
        end

        name = @audio_name.fetch(track, name).gsub(/,/, '","')

That name = info.fetch(:name, '') line is the problem because it's stupidly assuming that :name won't be nil. D'oh!
Again, my apologies for this bug.
I should be a able to get a fix out sometime this week. Stay tuned and thanks again for reporting the issue!

@faithfracture Perfect! 🤣

I should make a version of that that includes the amount of yelling & swearing at your computer that occurs at each stage, lol.

@faithfracture OK, the fix is in: https://github.com/donmelton/video_transcoding/commit/60ccb3eb283a138e0b517d91785e201d9ebdf28c
Should be released sometime later today.

Awesome! Thanks @donmelton!

@faithfracture OK, it's released Just gem update video_transcoding and you'll get the fix.
Thanks again for opening this issue!


Appstudio update hacbs-test-project-oaap

Pipelines as Code configuration proposal
To start the PipelineRun, add a new comment with content /ok-to-test
For more detailed information about running a PipelineRun, please refer to Pipelines as Code documentation Running the PipelineRun
To customize the proposed PipelineRuns after merge, please refer to Build Pipeline customization

Pipelines as Code CI has failed.There was an error creating the PipelineRun: hacbs-test-project-oaap-on-pull-request-
creating pipelinerun hacbs-test-project-oaap-on-pull-request- in namespace rhtap-demo-okmf-tenant has failed.
Tekton Controller has reported this error: the namespace of the provided object does not match the namespace sent on the request


[Improvement]: Update group limit or clarify wording

Contact Details
<EMAIL_ADDRESS>What can we improve?
Reading the docs for the Group Identify API, available with the Accounts add-on, it states that "You can track up to 5 unique group types and 10 total groups". I can understand the limit for group types, but it's inconceivable that there would be a limit of 10 total groups. The examples given in other areas of the documentation for the Accounts add-on ("a company of customers, a team of users, or a playlist with listeners"). For all these examples, you would expect any business (even the earliest stage startup) to have more than 10.
Could you please update the documentation with the actual limit (if there is one), or update them to better articulate what is meant by "total groups" if it means something different (perhaps the limit is per request, when identification is an array of JSON objects, or the limit applies to each individual user). I suspect it's the latter, as on https://www.docs.developers.amplitude.com/analytics/apis/identify-api/#required-parameters, the same limit is referenced regarding the groups parameter when identifying an individual user.
To clarify, the way I understand the current phrasing and meaning of "10 total groups" in the context of the Group Identify API is as follows:
If we were using the Accounts add-on to to track at a company level, we might have a company for each user (in reality we'd use ids, but using a names makes this easier to explain) to which each user belongs, e.g.
user: Alice, company: Amplitude
user: Bob, company: Amplitude
user: Sarah, company: Google
user: Fred, company: Netflix

We would like to track at the company level, so that whether an event is performed by Alice or Bob, it's still attributed to Amplitude, and we can look up events performed by Amplitude in any part of the UI that supports it.
To identify our groups we'd send:
[
  {"group_type":"company" ,"group_value":"Amplitude", "group_properties":{...}},
  {"group_type":"company" ,"group_value":"Google", "group_properties":{...}}},
  {"group_type":"company" ,"group_value":"Netflix", "group_properties":{...}}},
]

This would be "3 total groups", meaning we'd only be able to send another 7 before exhausting our limit of "10 total groups".
Additional improvements
Assuming the limit is per user, it would be great if you could provide more detail on what happens if this limit is exceeded. For example, if the following call is made:
amplitude.getInstance().logEventWithGroups('initialize_game', eventProperties, {'sport': 'Soccer'});

and (because this user is particularly sporty) we subsequently log 10 further events with sport set to Ultimate Frisbee, Solo Synchronised Swimming, Parkour, Chess Boxing, Zorbing, Quidditch, Unicycle Polo, Curling, Tug-of-War, and finally Cheese Rolling, what happens when the 11th event with {'sport': 'Cheese Rolling'}?
Does the event fail because the user is already in 10 sports? Do we stop being able to analyse that user's events where the event was logged with the least-recently-used group (Soccer)? Or is this actually fine, and the limit simply means we couldn't call logEventWithGroups with 11 groups for the user for one event?
Which page needs an update?
https://www.docs.developers.amplitude.com/analytics/apis/group-identify-api/

Hi @ed-bassett -- I'm looking into this. Thanks!


Temperature "-100 °C"

In
https://github.com/ksheumaker/homeassistant-apsystems_ecur/blob/69b808cb2997c68a3c395c9fb580c6f16f9e27be/custom_components/apsystems_ecur/APSystemsSocket.py#L322
the temperature is calculated as offset by 100, since the ECU sends data with 0 = -100 °C up to 255 = 155 °C.
As result, when no data is available because the panel is offline, the HA and Grafana graphs are nonsense:

The component should filter out values of "-100 °C", so that HA and Grafana will omit the measurement point, which is what is right, since... the panel is offline! why a fake value?
I'm not sure how to replace a number by "unavailable" or how to avoid adding that measurement point altogether.
Maybe replacing:
inv["temperature"] = self.aps_int(data, location) - 100
by:
if self.aps_int(data, location) > 0:
  inv["temperature"] = self.aps_int(data, location) - 100

but I don't know python, I just looked up "python if then else".

I currently use https://github.com/HAEdwin/homeassistant-apsystems_ecur/blob/main/custom_components/apsystems_ecur/APSystemsSocket.py and get zero values when the inverter is offline. This keeps the temperature graph somewhat inbound.

You can imagine that replacing a nummeric value for a text value for graphs won't work.

No it wouldn't work but then the value should be omitted entirely, since that's what actually happens: the panels are offline and no value is reported by the inverters (which are powered by the panels).
In winter 0°C is a perfectly reasonable value for daily operation of the panels.

Would you rather have it produce the graph like the red line is showing?

I think, if the value is ommited entirely, the sensor produces an invalid data statement from within Home Assistant since the value is not being updated anymore. Option is to keep the latest value and jump to the new value when the inverter goes online but I don't think that is a neat solution. Just go to zero like all values is the best solution imho.

I'm not at home but I can tell you that when data is missing home assistant simply omits the line, it doesn't connect the latest value with the newest one. It may also depend whether the previous value has an expiration or is set to be maintained until a new one arrives?

I confirm the same problem. during night the temperture drops to -100. this should not happen.

This sensor has connection issues (TCP modbus) and clearly has holes in the graph where data is missing or errors are returned.

https://community.home-assistant.io/t/is-it-possible-to-mark-a-sensor-as-unavailable/448865/3
How to make the sensor "unavailable" is beyond my capabilities, but it is possible and it is IMHO the correct choice whenever theECU provides "0" as temperature.

I'll give it a try, thanks for all the info. I'll get back to this though I don't understand why I have zero values and others have -100

@dewi-ny-je and @12christiaan:  Did the update https://github.com/HAEdwin/homeassistant-apsystems_ecur/commit/a8867f2787680f24880f04d24049833a6a152d76 solve your issue?

No, the update did not solve the problem. i think the unit is still online, while the value is already dropping to -100

Noticed the issue due to unexpected behavior :) will look into it.

perhaps check if "frequency" > 0 than update "temperature" else "temperature" = none?

creative idea, I'm going to find out why the online parameter is apparently not correct.

I like to help, but am new to HASS. i have started a TCPdump, so we will see tonight what happens on the communication flow. at least we can see what the system send, etc.

Error was in the boolean evaluation, data was right. Solved it and evaluating...
https://github.com/HAEdwin/homeassistant-apsystems_ecur/commit/35b9372df6f7b5bdf73a802801a72f986cb6abc4

i apply the change to my local script. let's see tonight what happens

As expected, the "None" value produces a flat line until the value is no longer "None". Here the temperature graph hangs at 23 degrees Celsius.

When saving data to an external databa6such as Influxdb having a gap may be the intended behaviour.
Using 0 as gap filling may well mean that in winter there is overlap between fake and valid data, in some locations (corner case I would say... it's uncommon).
I would prefer the flat line which becomes a gap as soon as a new valid datum arrives,but other users may have other priorities.

I get it but this does leave a challenge for those who use a gauge to indicate the temperature. To accommodate non-numeric values in the gauge, None must be replaced by 0.
I'm struggling with a template myself but can't figure it out.
value_template: "{{ 0 if states('sensor.inverter_806000011111_temperature') == none }}
does not work
So I asked the community for help.

Can you have an option in the settings? Besides IP address and polling time.
"When offline, report inverter temperature as: (leave blank for not reporting values, which may cause troubles with gauges)"
Then a field with 0 as default.

I also thought of that solution, but it can also be concluded with a clear comment that a value template must be used. I was already given a solution that works. As a result, the gouge then represents a fictitious temperature so it's better to keep the default None. I modified it in the repository. https://github.com/ksheumaker/homeassistant-apsystems_ecur/pull/84/commits/17d6fc086142d323f93da2079f8f9018d2bf038e

Guess this issue can be closed? I asked @ksheumaker  if he got some spare time left to do a merge of the pull requests so that we're more up to date.

i confirm the 0 is fine for me (100 times better than -100 :-) )
also here the change is working fine.


Runner - CollectionWasNotInitialized

Hi Roman, thank you for great Beanie package.
Could you please point me to a direction how to use Runner class? It took me a while to figure out, that beside creating my own ExampleTask from Task, I need to pass that, as a model to init_beanie.
So now I'm able to push my tasks to Mongo DB and execute them with ExampleTask.queue() or await start() with Worker(task_classes=[ExampleTask]).
Next step is to use Runner, but in that case I get beanie.exceptions.CollectionWasNotInitialized.
My code looks like this:
import asyncio
from motor.motor_asyncio import AsyncIOMotorClient
from beanie import init_beanie
from beanie_batteries_queue import Task, Runner, Priority

class ExampleTask(Task):
    data: str

    async def run(self):
        self.data = self.data.upper()
        await self.save()

# This is an asynchronous example, so we will access it from an async function
async def example():
    client = AsyncIOMotorClient("mongodb://localhost:27017")
    await init_beanie(database=client.db_name,
                    document_models=[ExampleTask]
                    )

    # Producer
    task = ExampleTask(data="test", priority=Priority.HIGH)
    await task.push()

    # Consumer
    runner = Runner(task_classes=[ExampleTask])
    runner.start()

    # Results in error:
    # File "C:\Git\Todo-app_II\.venv\Lib\site-packages\beanie\odm\documents.py", line 1024, in get_settings
    # raise CollectionWasNotInitialized
    # beanie.exceptions.CollectionWasNotInitialized

if __name__ == "__main__":
    asyncio.run(example())

Do you please have any suggestion how to fix this? Thank you

@RomaCZ, I'm also facing the same issue, did you get any workaround?

Hi @nabhosal not yet. You? 😉
I quess we would have to wait for @roman-right


Add Open Source Couch podcast episode with @fkr

Signed-off-by: Eduard Itrich<EMAIL_ADDRESS>

@itrich and I concluded, that this will be merged, once @itrich listened to the episode.

@itrich and I concluded, that this will be merged, once @itrich listened to the episode.

OK, someone needs to hack @itrich's audio equipment now!

@itrich and I concluded, that this will be merged, once @itrich listened to the episode.

OK, someone needs to hack @itrich's audio equipment now!

 However, I already listened to 50% of the episode.


Export ActionInContext type

As part of https://github.com/elastic/synthetics-recorder/issues/85, it would be good to depend on the upstream action type instead of maintaining parallel types that might be out of sync. It will take some of the maintenance burden off of the recorder as well.
With this change, when the next release is published we should be able to reference this type and delete our existing action type.

:broken_heart: Tests Failed

the below badges are clickable and redirect to their specific view in the CI or DOCS

Expand to view the summary

Build stats

Start Time: 2021-11-29T20:38:41.763+0000

Duration: 8 min 35 sec

Commit: 6192751bdfd01c1c2a3a998123d591864ac346cf

Test stats :test_tube:

Test
Results

Failed
1

Passed
139

Skipped
0

Total
140

Test errors
Expand to view the tests failures
Test / tracing capture filmstrips – tracing capture filmstrips

no error details
Expand to view the stacktrace
 Error: expect(received).toBeGreaterThan(expected)

Expected: > 0
Received:   0
    at Object.<anonymous> (/var/lib/jenkins/workspace/nt-rum_elastic-synthetics_PR-420/src/github.com/elastic/synthetics/__tests__/plugins/tracing.test.ts:48:31)

Steps errors
Expand to view the steps failures

Runs the tests

Took 1 min 1 sec . View more details here
Description: ./node_modules/.bin/jest --ci --reporters=default --reporters=jest-junit

:robot: GitHub comments
To re-run your PR in the CI, just comment with:

/test : Re-trigger the build.


Implement RFC0052: Graceful Stack Upgrades

RFC
Summary
All Paketo Buildpacks should support graceful stack upgrades between the current Bionic and Jammy stacks. For most buildpacks, this should not require any changes, but for some buildpacks, layers created in previous builds that would normally be reused should be recreated if the stack ID changes.
Action Item
Consider what types of buildpacks would be impacted by a stack upgrade and make any relevant changes that would help to mitigate issues caused by that upgrade. If there is no work to be done, please comment on this issue explaining the context that helped to arrive at that conclusion.

For Java-Native-Image, we made the following changes to support Jammy:

https://github.com/paketo-buildpacks/native-image/pull/169

This includes Jammy-Tiny in the list of native-image stacks checked when adding a tiny-specific argument.

Does that mean that this is done?

I believe so, yes.


Create Search for the DAOs data section

Overview
Build out the search input component and the searching logic for the DAOs in both the Table and Grid views.

User Stories

As a connected user, I should be able to use the Search as a fuzzy search across all data in both Table and Grid views.
As a connected user, the Search placeholder should indicate how many DAOs I'm in.

Detail

Search on Name or a fuzzy search across all table data
React Table has support for searching across all the table data
Search component has a dynamic placeholder with amount of DAOs user is in (ie "Search 7 DAOs)

Can probably pass this in as the placeholder prop on the Input used in Search once the data is loaded

Related Issues

#108
#128

@skuhlmann Does this even make sense on hub if user has a few daos.

We can do this with the local data and we can pipe it, but what are implications when we start combining these filters:

are these all ANDs?

if name contains... AND on this network... AND is a delegate
we should build utils to handle this since we'd use this pattern a lot during Core UI (there are several tables)

When an element goes into the filter dropdown, it can have the query with it, and as you click through the filters it builds up the where filter on the query?

On any state change we'd re-fetch the query (search debounced or onBlur -- change the state on this, and then this would fire off the new query)
state on the input itself and also on the searchState

Challenges and considerations with this:

Can we turn the entire "Data control" section (sort, filter, search) into a separate component?
Sort: label and the query that the label passes up (sort based on the label value)
Each of these can be separate components and combined into a <Control/> component -- but we'd want to check with design to be sure that we're going to use the List and Card pattern moving forward in Core UI

Will be always be using Card views for mobile moving forward or are we going to do a mobile view for tables? Or will we be needing to support both?


Whare can I find all options related to configuration

as for 'namespaces' used to create the dataset - the simple v2 config has some examples, but is this the full list of available options?
Looking for some hints with the command: 'poetry run bootstrap-cli --help' but can't find anything about the config file there

FYI . know I can look in the configuration.py file - but maybe add something to the documentation or example config file?

@sdorheim will help to update the documentation for v2 syntax.
We've planned to do this after the merge, as this allows some projects which tested the v2 changes already to migrate.

@BergsethCognite since PR #48 added a better readme => can we close this issue?

assuming now good enough :)


how to adapt to non square image model training and inference?

can you share how to adapt to non square image model training and inference? is it possible to use stable diffusion pipeline to generate non-square images?

Hi, you mentioned you will adapt to SDM 2.1, can you specify how you are going to do that?

@mihirp1998 Any thoughts on this? I tried to adapt to SDM 2.1, the hps score is very low, after training for 20 epochs, it's still around 0.24. Wondering what went wrong with my experiment.

I haven't tried SDM 2.1, plan to try it in the weekend.
Also i'm not sure what's the issue with non square image training?
Can you ellaborate more on the issues you are facing with SD 2.1  trainingand non-square image training can help me with the integration.

Hi @mihirp1998 , thank you very much for the quick response. I am trying to train with SDM 2.1, i changed the height and width in vae from 64, 64 to 96, 96 (512 vs. 768). But the generated images from epoch 0 are non-sense, and the more I train the model, the worse the quality will be. The HPS reward is always in the range of 0.22 to 0.24.
I'm wondering besides vae config, what else do I need to change? What's the parameter value 0.18215 here? Do I need to change it for SD2.1?
ims = pipeline.vae.decode(latent.to(pipeline.vae.dtype) / 0.18215).sample
BTW, accelerate does not work for me, so I can only use 1 GPU for the training.
Any advice or help is appreciated! Thanks!

okay i'll look into sd 2.1.
btw what is the error you get with accelerate in multi-gpu setting? also does accelerate work for you with other repos or is it just with this repo it doesn't work?

@mihirp1998, cool, thanks a lot! When I use accelerate, the training is just hung there, looks like data has not been loaded at all, so no training is happening. I used accelerate with dreambooth model training, it worked. It could be python3.10 and accelerate 0.17.0 are not compatible with my AWS EC2 env. Please let me know if you have any updates! I tried to load stabilityai/stable-diffusion-2-1 for training, but the losses are nan, I printed the latents values, all are nan, but the evaluation worked fine, very weird, let me know if you have encountered the same problem!

For accelerate, does it hang after one epoch, or from the the beginning?
can you try removing this line and trying it again:
https://github.com/mihirp1998/AlignProp/blob/a269c5af788792509c0184b0828abcc90f0038ec/main.py#L602

@mihirp1998 From the beginning, I didnot use accelerate for sd1.5, and i was able to replicate your results. Sure, let me try this, thank you!

@mihirp1998 This is the training log with sd 2.1, the loss does not drop but increase gradually...

can you maybe try lower learning rates to see if the loss goes down?
I did try sd 2.1-base and found a similar issue of loss not going down. I think i'll have to look into it more closely to get it to work.
Probably playing with learning rate or parameters to adapt (lora vs unet vs changing lora dimension) might be worth trying.

Also i'll recommend directly trying  SDXL instead: https://stablediffusionxl.com/
As i think it's probably better than SD 2.1

Hi @mihirp1998, thank you very much for the confirmation! I did try different lora rank, and different learning rates, none of them worked. Unfortunately, SDXL is too big for us, we can only consider sd 2.1, I will also keep looking into this and keep you posted! BTW, accelerate now worked with multiple gpu for me, thankfully!

I see, what changed in accelerate to get it to work?

I honestly do not know. Maybe the system updates helped...

@mihirp1998 This is the training log with sd 2.1, the loss does not drop but increase gradually...

are these curves with sd 2.1 or sd 2.1-base?
If they are with sd 2.1 then how did u fix the nan problem?

This is sd 2.1, I used pipeline.unet to do the prediction instead of unet. But this is a bit different from your original lora setting.  The loss increases I believe it's the lr is too big, as I reduced the per_gpu_capacity to 1 but the lr is still se-3.  When i changed the lr from 1e-3 to 1e-4, the loss does not drop, nor increase.

I also tried the new lora setting with sd 1.5, seems not working well. check the orange wandb logs attached.

I see, so i'm assuming u r not updating the lora parameters anymore but the whole unet?
Also can you try setting : config.train.adam_weight_decay = 0.0
try both settings updating with and without LoRA,  i'm not sure why are u get nan with lora

No, I did freeze the unet, but only updating unet, otherwise, the memory will explode as you mentioned in your paper. Let me try config.train.adam_weight_decay = 0.0. Are you not getting nan problem with sd 2.1?

I don't understand how this fixes the nan problem?  Like what's happening here and how does this change anything?

I used pipeline.unet to do the prediction instead of unet. But this is a bit different from your original lora setting.

I don't understand how this fixes the nan problem? Like what's happening here and how does this change anything?

I used pipeline.unet to do the prediction instead of unet. But this is a bit different from your original lora setting.

It's weird indeed, but seems like the lora layers added do not work for SD 2.1. I'm thinking we can try other ways of lora for SD 2.1, for example, peft.

Okay sure, but do u know what results in the nan outcome?
btw i tried sd2.1-base with setting config.train.adam_weight_decay = 0.0 and i find the loss to go down.

Okay sure, but do u know what results in the nan outcome at the first place?
btw i tried sd2.1-base with setting config.train.adam_weight_decay = 0.0 and i find the loss to go down.

but do u know what results in the nan outcome at the first place?--> I just replaced sd 1.5 with stabilityai/sd-2.1 from huggingface, and changed the latent dimension from 64 to 96. As a result, the lora weights were not updated due to nan problem, so the image quality keep unchanged.
Great to hear that! Can you help try sd 2.1 as well? Because sd 2.1, the dimension changed from 512 to 768, so the per_gpu_capacity will also go down from 4 to 1, that will affect the lr.

As a result, the lora weights were not updated due to nan problem, so the image quality keep unchanged.
I am not sure why the weights won't get updated. I think they should and setting weight decay to 0.0 should make it work.
Can you help try sd 2.1 as well?
I plan to try this after a week, will also try SD refiner then as i have neurips camera ready deadline. But i think sd-2.1-base is working, and i think the same strategy should work for sd-2.1. Let me know if it works for you.

I think having 64 as the latent dimension height width was causing the nan issue. Probably sd-2.1 should work after setting weight_decay to 0 I tried 96, nan issue was still not solved. I'm currently testing with 0 weight decay, hopefully it will work!
Thanks a lot for the help! I will keep you posted on this.

sorry for hijacking this thread, but, when trying to adapt for SDXL, this occurs:
RuntimeError: mat1 and mat2 shapes cannot be multiplied (308x768 and 2048x640)

It seems that the LoRA implementation on SDXL is completely different too.

got much further and now running into a negative tensor issue on the backprop...

Thanks! if you are successful in integrating do please send a pull request. Would love to integrate it.

got much further and now running into a negative tensor issue on the backprop...

oddly, after a few hours of working on this the issue can be skirted by setting the latent dim to 64x64 or 96x96 rather than 128x128 (which causes the issue).

@mihirp1998, cool, thanks a lot! When I use accelerate, the training is just hung there, looks like data has not been loaded at all, so no training is happening. I used accelerate with dreambooth model training, it worked. It could be python3.10 and accelerate 0.17.0 are not compatible with my AWS EC2 env. Please let me know if you have any updates on sd 2.1! I tried to load stabilityai/stable-diffusion-2-1 for training, but the losses are nan, I printed the latents values, all are nan, but the evaluation worked fine, very weird, let me know if you have encountered the same problem!

In my experience losses end up at NaN when using float16, bfloat16 doesn't have this issue. I still have to check if lowering the latent dim causes NaN on SDXL.

I don't understand how this fixes the nan problem? Like what's happening here and how does this change anything?

I used pipeline.unet to do the prediction instead of unet. But this is a bit different from your original lora setting.

It's weird indeed, but seems like the lora layers added do not work for SD 2.1. I'm thinking we can try other ways of lora for SD 2.1, for example, peft.

https://github.com/huggingface/diffusers/pull/5331
it might aiso be worthwhile to note that LoRAAttnProcessor (and by extension LoRAAttnProcesor2_0) is deprecated - a dump of the unet shows a difference in layout when directly setting LoRALinearLayer(s).

thanks for the infromation! i'll work on this in few days. Did SDXL work for u?

@Xerxemi Could you share the script for SDXL if possible?

Hi @Xerxemi , does it work for your SDXL well? Does the loss drop normally?

Hi @Xerxemi , does it work for your SDXL well? Does the loss drop normally?

yup, I'm currently fixing a lot of little bugs (I practically replaced 80% of the code) but the loss does drop with weight decay active.

Hi @Xerxemi , that's great! I cannot make the loss decrease. Could you help share the learning rate you use, and how you add the lora layers for SDXL? Will really appreciate the help!

@SkylerZheng sure, my LR is 3e-4 and weight decay is 5e-2 using the AdamW bnb sampler (I also lowered beta2 to 0.99 and epsilon to 1e-6).
I use peft to add the LoRA layers (or LoHa/LoKr).

Hi @Xerxemi , congratulations on this! It looks great, and thank you very much for the sharing!

Hi @Xerxemi , I have set up the codebase for SDXL, currently trying to get it to work.
In the above plots, what was the reward function u were using? Also is there anything else u changed other than the ones u mentioned:
my LR is 3e-4 and weight decay is 5e-2 using the AdamW bnb sampler (I also lowered beta2 to 0.99 and epsilon to 1e-6).

@mihirp1998 , @Xerxemi
Hi, are there any updates for SDXL??
I would appreciate if I could use xl version.

Hi @Xerxemi , I have set up the codebase for SDXL, currently trying to get it to work.
In the above plots, what was the reward function u were using? Also is there anything else u changed other than the ones u mentioned:

my LR is 3e-4 and weight decay is 5e-2 using the AdamW bnb sampler (I also lowered beta2 to 0.99 and epsilon to 1e-6).

reward function was HPSv2.

@mihirp1998 , @Xerxemi Hi, are there any updates for SDXL?? I would appreciate if I could use xl version.

well, we practically gave up on the idea due to quality reasons but yes it did work at one point
currently out on a trip but back at home the codebase should still exist somewhere

Any tried to successfully train using some custom loss function ? Tried to adjust lots of parameters, still loss increasing.

You can try reducing the value of K (truncation steps), maybe try setting
it to 1 and that could make the loss landscape easy to optimize, and
obviously play with the learning rate too.
On Sat, Nov 16, 2024 at 5:50 PM Karun @.***> wrote:

Any tried to successfully train using some custom loss function ? Tried to
adjust lots of parameters, still loss increasing.
—
Reply to this email directly, view it on GitHub
https://github.com/mihirp1998/AlignProp/issues/4#issuecomment-2480837299,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AE4C5LAYFVFBOVQCK5RCKID2A7D3FAVCNFSM6AAAAAA54Y25ACVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIOBQHAZTOMRZHE
.
You are receiving this because you were mentioned.Message ID:
@.***>

I did tried lots of combination in Hypeparameters space, including your suggestion above, still the loss seems to be increasing

So does the AlignProp scripts support SDXL-Turbo now ?

@Xynonners can u just release it if you have it somewhere, honestly i dont have the bandwidth to add this support unfortunately.

@Xynonners or @Xerxemi can u please release it if you have it somewhere, unfortunately i dont have the bandwidth to add this support.

Sure, I can go ahead and try and dig it up if I have the time. Currently quite busy though so it might take a while.

Thanks that means a lot!
On Mon, Nov 25, 2024, 20:03 Xynonners @.***> wrote:

@Xynonners https://github.com/Xynonners or @Xerxemi
https://github.com/Xerxemi can u please release it if you have it
somewhere, unfortunately i dont have the bandwidth to add this support.
Sure, I can go ahead and try and dig it up if I have the time. Currently
quite busy though so it might take a while.
—
Reply to this email directly, view it on GitHub
https://github.com/mihirp1998/AlignProp/issues/4#issuecomment-2499342780,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ARZTQIN2IJWRHKOBWWSDG232CPCEVAVCNFSM6AAAAAA54Y25ACVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIOJZGM2DENZYGA
.
You are receiving this because you commented.Message ID:
@.***>

Hey @Xynonners, you got a chance to check with the code ?


Run on Windows

I've failed miserably to run it on windows.
Are there any binaries for windows?
I'm very novice at running and debugging all those CLI commands.
Thanks.

windows support is absolutely abmyssal, way too hard to get running

Hey @metheofanis, @nikshepsvn - could you try opening an issue in the JAX repo? IMO the more interest they see around running JAX on Windows, the more likely they are to invest time supporting it!
Happy to answer any questions regarding Whisper JAX here.

Hey @sanchit-gandhi, I've managed to run it in Windows Subsystem for Linux.
My GPU is 3060 12GB RAM.
The performance is ~1X for the first audio and ~3X for the second!
Is that normal? Did I miss something?
I guess the advertised 70X speed is for cloud GPU and TPU setups?
Thanks!

When you run it, is it utilizing the GPU in performance monitor? I had a similar issue as I couldn't get CUDA to behave, wasn't able to resolve it.

@aardvarkoncomputer Maybe you are missing this:
https://docs.nvidia.com/cuda/wsl-user-guide/index.html
In step 3, option 1 there is a link to:
https://developer.nvidia.com/cuda-downloads?target_os=Linux&target_arch=x86_64&Distribution=WSL-Ubuntu&target_version=2.0&target_type=deb_local
After following these, it worked from GPU!

Yes, I am interested in running it on Windows 10/11 as well, but have not had any success with the installation instructions. I am not averse to learning how it works, but I also happy to install it without knowing how it works (as long as it works) :) so a set of commands for copy and pasting at the CL or even a Windows bat file is good for me. Thanks!


Add test for handling of suite-level failures

While upgrading the JUnit Foundation dependency of agent-java-junit, I discovered that we couldn't handle suite-level (@BeforeClass) failures. The notifications generated for such failures are associated with the class, not a specific JUnit test of the class. However, the AtomicTest class had no way to represent the description for a JUnit class.
I modified this class so it can handle non-test elements, although this is definitely not what clients are likely to expect. These "atomic non-tests" have no identity and no particle methods. I could potentially attach the specific configuration method that caused the failure, but this may only lead to confusion.
At the least, I need to add at least one unit test to verify that suite-level configuration method failures are handled properly.

Resolved by #107
Prior to the merge of PR #107, we actually have a unit test that covered the general scenario, but this test lacked verification of the "atomic test" object that was supposed to be included with the failure notification. We now explicitly verify that the notification includes a non-test "atomic test" object.


Update Content Landing page template

Disclaimer: this requires further deliberation and a bit of conceptual thinking.
Update Content Landing page template to increase content importance in "above the fold" area. Currently it only shows Hero image and page title, to get to the content user has to browse to the bottom of the page.

Moved to Azure Devops: https://dev.azure.com/undp-online-digital/Acquia/_workitems/edit/8423