Dynamic Styles

I've been playing with dynamic styles recently to allow an app to change between light and dark colour schemes without restarting.
What i've noticed though is you can't dynamically change the screenBackgroundColor which can result in weird effects.
Here is what i'm dealing with.
The app runs in light mode by default and the screen background colour is set as white.
When changing to dark mode the screen background remains white but as the view itself has a black background you can't tell that the actual screens background colour is still white as the views background renders over that.
But say you open the keyboard? you'll actually see the screens background colour flash up for a second.
Basically creating an undesired effect when dark mode uses a different background colour.
Would it be possible to have the option as dynamic?

已支持动态更新  screenBackgroundColor

screenBackgroundColor wasn't in the dynamic options list and doesn't seem to be working, possible bug?

在的，文档未更新。
garden.updateOptions({
    screenBackgroundColor: '#F8F8F8',
})

Ahhhhhh my bad didn't realise you added it to the supported list, absolutely amazing, thank you 👍🏻
I do have another question, is there any way to have the top bar right buttons tint colour set globally as an override?
I'm trying to have a higher order component essentially deal with all the theming in one place, pretty much everything works now apart from that.
As far as i can tell if a screen uses the right buttons then it would have to re-define the top buttons when they are gonna change colour?

Also found a bug with the top left and right buttons.
When changing topBarColor from white to black the buttons touch effect doesn't work anymore unless i change the theme back to white or re-render the screen.
Seems to only happen when the button touch colour is the same after each background colour change.
Both white and black backgrounds make the buttons have the dark grey like touch effect colour.
But if i change to a different background colour like something bright then the touch effect colour becomes light white and then it works fine when the background colours are changed.
Could screen record to show, just a minor detail really 😃

Ahhhhhh my bad didn't realise you added it to the supported list, absolutely amazing, thank you 👍🏻
I do have another question, is there any way to have the top bar right buttons tint colour set globally as an override? I'm trying to have a higher order component essentially deal with all the theming in one place.
As far as i can tell if a screen uses the top right buttons then it would have to re-define the top buttons when they are gonna change colour?

更改按钮颜色，topBarTintColor 无法满足你的需求吗？
garden.updateOptions({
  topBarTintColor: '#00FF00',
})

可以单独改变 button 的颜色，不需要重新定义整个 button
garden.setRightBarButtonItem({
      tintColor: '#FF0000',
 })

Also found a bug with the top left and right buttons. When changing topBarColor from white to black the buttons touch effect doesn't work anymore unless i change the theme back to white or re-render the screen.
Seems to only happen when the button touch colour is the same after each background colour change. Both white and black backgrounds make the buttons have the dark grey like touch effect colour. But if i change to a different background colour like something bright then the touch effect colour becomes light white and then it works fine when the background colours are changed.
Could screen record to show, just a minor detail really 😃

可以录个屏

topBarTintColor seems to change the button colour rather than the actual button press effect colour.
Will try and record something.

Just realised after recording, the button effect is changing but it seems to be changing to the wrong colour 😆 sorry i am a little blind.
Will try and get the right button updating working and report back, thanks for that 👍🏻

Found another issue as well in relation to the header buttons changing colour.
If i have more than 1 right button then when changing from dark mode to light mode they won't change colour.
Even if i'm updating the topBarTintColor but if i only have 1 right button then it does indeed change colour.
Is that a bug or is there another way to update multiple buttons without recreating them?

Alright so i solved that issue by using garden.setRightBarButtonItems and just only using the tintColor property per defined button for the update process.
As for the button press effect, that is still an issue but mostly just ignored it for now.


kexec-installer: disable channel in unstable

depends on https://github.com/NixOS/nixpkgs/pull/263974

@mergify refresh

@mergify queue


alsaUtils: 1.1.5 -> 1.1.6

Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools.
This update was made based on information from https://repology.org/metapackage/alsa-utils/versions.
These checks were done:

built on NixOS
ran ‘/nix/store/kg9h54hxdg6hxs3agkfadacx5z8gaxiz-alsa-utils-1.1.6/bin/arecord -h’ got 0 exit code
ran ‘/nix/store/kg9h54hxdg6hxs3agkfadacx5z8gaxiz-alsa-utils-1.1.6/bin/arecord --help’ got 0 exit code
ran ‘/nix/store/kg9h54hxdg6hxs3agkfadacx5z8gaxiz-alsa-utils-1.1.6/bin/alsamixer -h’ got 0 exit code
ran ‘/nix/store/kg9h54hxdg6hxs3agkfadacx5z8gaxiz-alsa-utils-1.1.6/bin/alsamixer --help’ got 0 exit code
ran ‘/nix/store/kg9h54hxdg6hxs3agkfadacx5z8gaxiz-alsa-utils-1.1.6/bin/alsamixer help’ got 0 exit code
ran ‘/nix/store/kg9h54hxdg6hxs3agkfadacx5z8gaxiz-alsa-utils-1.1.6/bin/amixer -h’ got 0 exit code
ran ‘/nix/store/kg9h54hxdg6hxs3agkfadacx5z8gaxiz-alsa-utils-1.1.6/bin/amixer --help’ got 0 exit code
ran ‘/nix/store/kg9h54hxdg6hxs3agkfadacx5z8gaxiz-alsa-utils-1.1.6/bin/amixer help’ got 0 exit code
ran ‘/nix/store/kg9h54hxdg6hxs3agkfadacx5z8gaxiz-alsa-utils-1.1.6/bin/amixer -v’ and found version 1.1.6
ran ‘/nix/store/kg9h54hxdg6hxs3agkfadacx5z8gaxiz-alsa-utils-1.1.6/bin/amixer --version’ and found version 1.1.6
ran ‘/nix/store/kg9h54hxdg6hxs3agkfadacx5z8gaxiz-alsa-utils-1.1.6/bin/amidi -h’ got 0 exit code
ran ‘/nix/store/kg9h54hxdg6hxs3agkfadacx5z8gaxiz-alsa-utils-1.1.6/bin/amidi --help’ got 0 exit code
ran ‘/nix/store/kg9h54hxdg6hxs3agkfadacx5z8gaxiz-alsa-utils-1.1.6/bin/amidi -V’ and found version 1.1.6
ran ‘/nix/store/kg9h54hxdg6hxs3agkfadacx5z8gaxiz-alsa-utils-1.1.6/bin/amidi --version’ and found version 1.1.6
ran ‘/nix/store/kg9h54hxdg6hxs3agkfadacx5z8gaxiz-alsa-utils-1.1.6/bin/aplay -h’ got 0 exit code
ran ‘/nix/store/kg9h54hxdg6hxs3agkfadacx5z8gaxiz-alsa-utils-1.1.6/bin/aplay --help’ got 0 exit code
ran ‘/nix/store/kg9h54hxdg6hxs3agkfadacx5z8gaxiz-alsa-utils-1.1.6/bin/speaker-test -h’ got 0 exit code
ran ‘/nix/store/kg9h54hxdg6hxs3agkfadacx5z8gaxiz-alsa-utils-1.1.6/bin/speaker-test --help’ got 0 exit code
ran ‘/nix/store/kg9h54hxdg6hxs3agkfadacx5z8gaxiz-alsa-utils-1.1.6/bin/alsaloop -h’ got 0 exit code
ran ‘/nix/store/kg9h54hxdg6hxs3agkfadacx5z8gaxiz-alsa-utils-1.1.6/bin/alsaloop --help’ got 0 exit code
ran ‘/nix/store/kg9h54hxdg6hxs3agkfadacx5z8gaxiz-alsa-utils-1.1.6/bin/alsabat -h’ got 0 exit code
ran ‘/nix/store/kg9h54hxdg6hxs3agkfadacx5z8gaxiz-alsa-utils-1.1.6/bin/alsabat --help’ got 0 exit code
ran ‘/nix/store/kg9h54hxdg6hxs3agkfadacx5z8gaxiz-alsa-utils-1.1.6/bin/aplaymidi -h’ got 0 exit code
ran ‘/nix/store/kg9h54hxdg6hxs3agkfadacx5z8gaxiz-alsa-utils-1.1.6/bin/aplaymidi --help’ got 0 exit code
ran ‘/nix/store/kg9h54hxdg6hxs3agkfadacx5z8gaxiz-alsa-utils-1.1.6/bin/aplaymidi -V’ and found version 1.1.6
ran ‘/nix/store/kg9h54hxdg6hxs3agkfadacx5z8gaxiz-alsa-utils-1.1.6/bin/aplaymidi --version’ and found version 1.1.6
ran ‘/nix/store/kg9h54hxdg6hxs3agkfadacx5z8gaxiz-alsa-utils-1.1.6/bin/arecordmidi -h’ got 0 exit code
ran ‘/nix/store/kg9h54hxdg6hxs3agkfadacx5z8gaxiz-alsa-utils-1.1.6/bin/arecordmidi --help’ got 0 exit code
ran ‘/nix/store/kg9h54hxdg6hxs3agkfadacx5z8gaxiz-alsa-utils-1.1.6/bin/arecordmidi -V’ and found version 1.1.6
ran ‘/nix/store/kg9h54hxdg6hxs3agkfadacx5z8gaxiz-alsa-utils-1.1.6/bin/arecordmidi --version’ and found version 1.1.6
ran ‘/nix/store/kg9h54hxdg6hxs3agkfadacx5z8gaxiz-alsa-utils-1.1.6/bin/aseqdump -h’ got 0 exit code
ran ‘/nix/store/kg9h54hxdg6hxs3agkfadacx5z8gaxiz-alsa-utils-1.1.6/bin/aseqdump --help’ got 0 exit code
ran ‘/nix/store/kg9h54hxdg6hxs3agkfadacx5z8gaxiz-alsa-utils-1.1.6/bin/aseqdump -V’ and found version 1.1.6
ran ‘/nix/store/kg9h54hxdg6hxs3agkfadacx5z8gaxiz-alsa-utils-1.1.6/bin/aseqdump --version’ and found version 1.1.6
ran ‘/nix/store/kg9h54hxdg6hxs3agkfadacx5z8gaxiz-alsa-utils-1.1.6/bin/alsaucm -h’ got 0 exit code
ran ‘/nix/store/kg9h54hxdg6hxs3agkfadacx5z8gaxiz-alsa-utils-1.1.6/bin/alsaucm --help’ got 0 exit code
ran ‘/nix/store/kg9h54hxdg6hxs3agkfadacx5z8gaxiz-alsa-utils-1.1.6/bin/alsaucm help’ got 0 exit code
ran ‘/nix/store/kg9h54hxdg6hxs3agkfadacx5z8gaxiz-alsa-utils-1.1.6/bin/alsatplg -h’ got 0 exit code
ran ‘/nix/store/kg9h54hxdg6hxs3agkfadacx5z8gaxiz-alsa-utils-1.1.6/bin/alsatplg --help’ got 0 exit code
ran ‘/nix/store/kg9h54hxdg6hxs3agkfadacx5z8gaxiz-alsa-utils-1.1.6/bin/alsa-info.sh -h’ got 0 exit code
ran ‘/nix/store/kg9h54hxdg6hxs3agkfadacx5z8gaxiz-alsa-utils-1.1.6/bin/alsa-info.sh --help’ got 0 exit code
ran ‘/nix/store/kg9h54hxdg6hxs3agkfadacx5z8gaxiz-alsa-utils-1.1.6/bin/alsa-info.sh help’ got 0 exit code
ran ‘/nix/store/kg9h54hxdg6hxs3agkfadacx5z8gaxiz-alsa-utils-1.1.6/bin/alsaconf -h’ got 0 exit code
ran ‘/nix/store/kg9h54hxdg6hxs3agkfadacx5z8gaxiz-alsa-utils-1.1.6/bin/alsaconf --help’ got 0 exit code
ran ‘/nix/store/kg9h54hxdg6hxs3agkfadacx5z8gaxiz-alsa-utils-1.1.6/bin/alsactl -h’ got 0 exit code
ran ‘/nix/store/kg9h54hxdg6hxs3agkfadacx5z8gaxiz-alsa-utils-1.1.6/bin/alsactl --help’ got 0 exit code
ran ‘/nix/store/kg9h54hxdg6hxs3agkfadacx5z8gaxiz-alsa-utils-1.1.6/bin/alsactl -v’ and found version 1.1.6
ran ‘/nix/store/kg9h54hxdg6hxs3agkfadacx5z8gaxiz-alsa-utils-1.1.6/bin/alsactl --version’ and found version 1.1.6
found 1.1.6 with grep in /nix/store/kg9h54hxdg6hxs3agkfadacx5z8gaxiz-alsa-utils-1.1.6
directory tree listing: https://gist.github.com/325af09e0dbb84a155838bdb37c5f89a

cc @AndersonTorres for review

Success on aarch64-linux (full log)
Attempted: alsaUtils
Partial log (click to expand)
gzipping man pages under /nix/store/y6agqsnpbdcs7zfplmwhhai2aw0590jd-alsa-utils-1.1.6/share/man/
strip is /nix/store/gp7fylxwn18b7pl2c18ks89hsiaxyfvf-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/y6agqsnpbdcs7zfplmwhhai2aw0590jd-alsa-utils-1.1.6/lib  /nix/store/y6agqsnpbdcs7zfplmwhhai2aw0590jd-alsa-utils-1.1.6/bin  /nix/store/y6agqsnpbdcs7zfplmwhhai2aw0590jd-alsa-utils-1.1.6/sbin
patching script interpreter paths in /nix/store/y6agqsnpbdcs7zfplmwhhai2aw0590jd-alsa-utils-1.1.6
/nix/store/y6agqsnpbdcs7zfplmwhhai2aw0590jd-alsa-utils-1.1.6/sbin/alsabat-test.sh: interpreter directive changed from "/bin/bash" to "/nix/store/a4qslf0yfs44mhnbagarn232sjnckhy0-bash-4.4-p19/bin/bash"
/nix/store/y6agqsnpbdcs7zfplmwhhai2aw0590jd-alsa-utils-1.1.6/sbin/alsaconf: interpreter directive changed from "/bin/bash" to "/nix/store/a4qslf0yfs44mhnbagarn232sjnckhy0-bash-4.4-p19/bin/bash"
/nix/store/y6agqsnpbdcs7zfplmwhhai2aw0590jd-alsa-utils-1.1.6/sbin/alsa-info.sh: interpreter directive changed from "/bin/bash" to "/nix/store/a4qslf0yfs44mhnbagarn232sjnckhy0-bash-4.4-p19/bin/bash"
checking for references to /build in /nix/store/y6agqsnpbdcs7zfplmwhhai2aw0590jd-alsa-utils-1.1.6...
moving /nix/store/y6agqsnpbdcs7zfplmwhhai2aw0590jd-alsa-utils-1.1.6/sbin/* to /nix/store/y6agqsnpbdcs7zfplmwhhai2aw0590jd-alsa-utils-1.1.6/bin
/nix/store/y6agqsnpbdcs7zfplmwhhai2aw0590jd-alsa-utils-1.1.6

No attempt on x86_64-darwin (full log)
The following builds were skipped because they don't evaluate on x86_64-darwin: alsaUtils
Partial log (click to expand)

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.


TCP/UDP Proxy

Why do you need it?
Is your feature request related to a problem? Please describe in details
Using  higress supports 4 lays proxy for tcp/udp.
Thanks.
How could it be?
A clear and concise description of what you want to happen. You can explain more about input of the feature, and output of it.
Other related information
Add any other context or screenshots about the feature request here.

We will support this using the Gateway API.

How to config TCP/udp proxy  with standalone mode?

How to config TCP/udp proxy with standalone mode?

You can create corresponding resources in Nacos or your config folder, depending on your chosen configuration method.


Make gslab_python compatible with Python 3

Goal: Update repo to run using Python 3.
This primarily consists of making standard Python 2 -> 3 compatibility changes. See Cheat Sheet: Writing Python 2-3 compatible code for an outline of the primary differences for an outline of most of the issues that will need to be addressed. For better or worse, these changes will be made manually, rather than using an automated tool.

Completed in 21f22708c209db06aceadbe0415986e67206b017, although somehow managed to botch the message on the squash merge.


Week View

Hello,
Are there any plans to implement a week view in the near future?

Hi @rs658726 - do you mean something like this?

If so, my answer is: we don't have plans to support that right now, but if there's enough people asking for this, then maybe 🙂

Yes, that's it.
Thanks for the quick response.

+1, I would like to see this as well. JTAppleCalendar has some big issues with how it does layout, and this is the only feature stopping me from switching right now.

+1, I need this too.

For full transparency, there are no plans to support this. My recommendation would be to build this single-row view as just a horizontally-scrolling collection view. The code for it should be pretty simple, and you should be able to accomplish it using flow layout or compositional layout. You could even reuse DayView.swift and DayOfTheWeekView.swift to ensure that the stylings are the same, if you're doing transitions between HorizonCalendar and your custom single-row view.

Any minds changed regarding this feature @bryankeller ?


Setup ameriflux simulations

Added global parameter files for Ameriflux simulations that will be part of the VIC 5 science testing infrastructure.

global parameter file for Ameriflux forcings for VIC 4.2

global parameter file for Ameriflux forcings for VIC 5.0

@dgergel - should this be closed in lieu of #544?

@jhamman, yep, all of this has gone into #544.


Update Copy of Swagger Spec [Timebox]

Clean up some of the copy
Shorten descriptions in the sidebar and make them consistent

Fill out as many core descriptions as possible

Fix escaping

For the \, you just need to wrap the string in " to avoid having to escape the '.


Make zookeeper service enabled for RedHat

@JasonGiedymin
It's already enabled for Debian https://github.com/AnsibleShipyard/ansible-zookeeper/blob/master/tasks/Debian.yml#L26 but somehow missed on RedHat.

Good catch


As Master user, when clicking on appointment make the group you clicked on appear.

Realized this issue was somewhat vague. When you click on an event it takes you within the appointment editor and within there it currently doesn't show the groups when you click on an event. It would be nice if it would do that.


B #6710: (FSunstone) keep_me_logged variable fix

Description
Sync variable name with RSunstone and FSunstone's code
Branches to which this PR applies

[X] master
[X] one-6.10

[ ] Check this if this PR should not be squashed

We'll make sure to add this into master, thanks for the heads up @antalvrom !
Unfortunately we cannot take this to one-6.10 since we don't change conf files in maintenance releases, but we'll add a note in the documentation


[breaking][libra framework] decouple AccountLimits and Balance

Currently, a ParentVASP needs to have an AccountLimits resource before allowing a child to publish a balance in CoinType. This is confusing and not needed given that AccountLimits are U64_MAX at launch.
This PR removes the need to do this. Instead, LibraRoot can send an AdminScript to add AccountLimits to any VASP on which limits need to be imposed.
This simplifies the flows for creating new child accounts and adding new currencies (see smaller specs/fewer comments and error codes). I also was able to remove the partial aborts_if for the add_currency script.
Also eliminated the tx scripts for updating account limits, since this can now be done via the admin script that installs them.

Breaking changes

This is a breaking change in the sense that it changes the bytecode of a few modules and the transaction script allowlist.
This is not a breaking change for clients, although the add_currency_to_account script and create_child_vasp script will now succeed in some cases that would previously have failed (e.g., creating a child VASP with add_all_currencies=true from a parent that only has a balance in LBR. This convenience is the primary motivation for the change.

 See details.

I've seen this failure too after my PR(#5469 ) got merged, and I can't reproduce it locally. Can you reproduce it @sblackshear?

I did do something

[move-prover] Move Prover test (language/move-prover/cargo test) on commit d47cc50 did fail. See details.

I've seen this failure too after my PR(#5469 ) got merged, and I can't reproduce it locally. Can you reproduce it @sblackshear?

I did accidentally break peer_to_peer_with_metadata in d47cc50, but fixed it in 028d647 (works locally as well).

Love red diffs! This looks good to me. cc @moeziniaf for visibility about the removal of the two scripts in case it has AOS implications.

Thanks - which admin script will be used to add AccountLimits after this PR?

Love red diffs! This looks good to me. cc @moeziniaf for visibility about the removal of the two scripts in case it has AOS implications.

Thanks - which admin script will be used to add AccountLimits after this PR?

We do not have a script for this yet, but it should be as simple as calling AccountLimits::publish_new_window.

/land

Love red diffs! This looks good to me. cc @moeziniaf for visibility about the removal of the two scripts in case it has AOS implications.

Thanks - which admin script will be used to add AccountLimits after this PR?

We do not have a script for this yet, but it should be as simple as calling AccountLimits::publish_new_window.

Is there some limit address which holds default limits? I'm guessing there's a default and after MVP we will want to be able to create/modify new limits (but for now just publish and point an account window to the default limits address?)


Entities ArrayIndexOutOfBoundsException

Hi!
I am having trouble to parse first map of https://www.hltv.org/matches/2352464/astralis-vs-godsent-pgl-major-stockholm-2021-challengers-stage
It's crashing on ArrayIndexOutOfBoundsException and can be replicated in clarity-examples with anything using the @UsesEntities annotation.
java -jar target/entityrun.one-jar.jar ./astralis-vs-godsent-m1-nuke.dem
Caused by: java.lang.ArrayIndexOutOfBoundsException: 3413
        at skadistats.clarity.model.state.ClientFrame.getEntity(ClientFrame.java:24)
        at skadistats.clarity.processor.entities.Entities.processPacketEntities(Entities.java:368)
        at skadistats.clarity.processor.entities.Entities.processAndRunPacketEntities(Entities.java:331)
        at skadistats.clarity.processor.entities.Entities.onPacketEntities(Entities.java:320)
        at skadistats.clarity.event.AbstractInvocationPoint.invoke(AbstractInvocationPoint.java:86)
        at skadistats.clarity.event.Event.raise(Event.java:41)
        at skadistats.clarity.processor.reader.InputSourceProcessor.processEmbedded(InputSourceProcessor.java:247)
        at skadistats.clarity.event.AbstractInvocationPoint.invoke(AbstractInvocationPoint.java:86)
        at skadistats.clarity.event.Event.raise(Event.java:41)
        at skadistats.clarity.processor.reader.InputSourceProcessor.processSource(InputSourceProcessor.java:174)
        at skadistats.clarity.event.AbstractInvocationPoint.invoke(AbstractInvocationPoint.java:86)
        at skadistats.clarity.event.Event.raise(Event.java:41)
        at skadistats.clarity.processor.runner.AbstractFileRunner.initAndRunWith(AbstractFileRunner.java:39)
        at skadistats.clarity.processor.runner.SimpleRunner.runWith(SimpleRunner.java:33)
        at skadistats.clarity.examples.entityrun.Main.run(Main.java:17)
        at skadistats.clarity.examples.entityrun.Main.main(Main.java:27)
        ... 6 more

I found out version 2.4.1 process it without a crash but since 2.5 it's crashing.
Do you know if I am doing something wrong or what could be the cause?

Sorry, forgot to answer earlier.
Seems like the replay is corrupted. Might have a look later.

I was also thinking that it might be corrupted.
I am wondering why it's working with the older version of clarity.

Tested again today, works with Version 2.7.5.


Host Finite State Third Party Upload Plugin

Repository URL
https://github.com/FiniteStateInc/third-party-upload-jenkins
New Repository Name
finite-state-third-party-upload-plugin
Description
The Finite State third-party-upload allows you to easily integrate the Finite State Platform into Jenkins.
GitHub users to have commit permission
@cpfarherFinitestate
Jenkins project users to have release permission
finitestateinc
Issue tracker
GitHub issues

Security audit, information and commands
The security team is auditing all the hosting requests, to ensure a better security by default.
This message informs you that a Jenkins Security Scan was triggered on your repository.
It takes ~10 minutes to complete.
Commands
The bot will parse all comments, and it will check if any line start with a command.
Security team only:

/audit-ok => the audit is complete, the hosting can continue :tada:.
/audit-skip => the audit is not necessary, the hosting can continue :tada:.
/audit-findings => the audit reveals some issues that require corrections :pencil2:.

Anyone:

/request-security-scan => the findings from the Jenkins Security Scan were corrected, this command will re-scan your repository :mag:.
/audit-review => the findings from the audit were corrected, this command will ping the security team to review the findings :eyes:.
	It's only applicable when the previous audit required changes.

Only one command can be requested per comment.

(automatically generated message, version: 1.28.6)

/request-security-scan

The Jenkins Security Scan did not find anything dangerous with your plugin, congratulations! :tada:

:bulb: The Security team recommends that you are setting up the scan in your repository by following our guide.

The Jenkins Security Scan did not find anything dangerous with your plugin, congratulations! :tada:

:bulb: The Security team recommends that you are setting up the scan in your repository by following our guide.

/hosting re-check

/hosting re-check

Hey @cpfarherFinitestate,
I took a brief look over your hosting request and have some feedback for you:

https://github.com/FiniteStateInc/third-party-upload-jenkins/blob/main/.github/CODEOWNERS should match your <artifactId>-developers
Links in the README should point to the jenkinsci organization
https://github.com/FiniteStateInc/third-party-upload-jenkins/blob/5a1990ff27f92acd7340d1d21b123835a64db20c/pom.xml#L48 The bom version specified should match your jenkins.version, in this case, 2.440.x
https://github.com/FiniteStateInc/third-party-upload-jenkins/tree/main/src/main/java/com/finitestate/thirdpartyupload your path doesn't match your specified GAV coordinates. Please move them to io.jenkins.plugins.<artifactId>
https://github.com/FiniteStateInc/third-party-upload-jenkins/blob/5a1990ff27f92acd7340d1d21b123835a64db20c/pom.xml#L56-L72 instead of shading the dependency yourself, you can depend on the Jenkins plugin providing the API for you: https://plugins.jenkins.io/docker-java-api/dependencies/
Please remove all dependencies from your pom.xml, your plugin doesn't depend upon.
https://github.com/FiniteStateInc/third-party-upload-jenkins/blob/5a1990ff27f92acd7340d1d21b123835a64db20c/src/main/resources/com/finitestate/thirdpartyupload/ThirdPartyUploadRecorder/config.jelly#L62-L84 inline JS is banned within CSP. Take a look at the deprecatin note of onclick, on how to address the issue. https://reports.jenkins.io/core-taglib/jelly-taglib-ref.html#checkbox

Hey @cpfarherFinitestate,
I took a brief look over your hosting request and have some feedback for you:

https://github.com/FiniteStateInc/third-party-upload-jenkins/blob/main/.github/CODEOWNERS should match your <artifactId>-developers
Links in the README should point to the jenkinsci organization
https://github.com/FiniteStateInc/third-party-upload-jenkins/blob/5a1990ff27f92acd7340d1d21b123835a64db20c/pom.xml#L48 The bom version specified should match your jenkins.version, in this case, 2.440.x
https://github.com/FiniteStateInc/third-party-upload-jenkins/tree/main/src/main/java/com/finitestate/thirdpartyupload your path doesn't match your specified GAV coordinates. Please move them to io.jenkins.plugins.<artifactId>
https://github.com/FiniteStateInc/third-party-upload-jenkins/blob/5a1990ff27f92acd7340d1d21b123835a64db20c/pom.xml#L56-L72 instead of shading the dependency yourself, you can depend on the Jenkins plugin providing the API for you: https://plugins.jenkins.io/docker-java-api/dependencies/
Please remove all dependencies from your pom.xml, your plugin doesn't depend upon.
https://github.com/FiniteStateInc/third-party-upload-jenkins/blob/5a1990ff27f92acd7340d1d21b123835a64db20c/src/main/resources/com/finitestate/thirdpartyupload/ThirdPartyUploadRecorder/config.jelly#L62-L84 inline JS is banned within CSP. Take a look at the deprecatin note of onclick, on how to address the issue. https://reports.jenkins.io/core-taglib/jelly-taglib-ref.html#checkbox

I have some questions:
1- About the change of docker-java to docker-java-api. Is there any way to use the docker-java-api dependency without modifying a lot of things in the code? When I tried to switch I found a lot of things that I need to change.
2- When you said: "Please remove all dependencies from your pom.xml, your plugin doesn't depend upon.". I'm a bit confused because I used credentials and in this case docker-java or docker-java-api. So on that case, I need to keep it the dependencies right?.

Hello from your friendly Jenkins Hosting Checker
It looks like you have everything in order for your hosting request. A member of the Jenkins hosting team will check over things that I am not able to check(code review, README content, etc) and process the request as quickly as possible. Thank you for your patience.
Hosting team members can host this request with /hosting host

Apologies for my noise on this hosting issue.  I used it as a test case to check a pull request that proposes to switch the repository permissions updater to use Java 21.

/request-security-scan

The Jenkins Security Scan did not find anything dangerous with your plugin, congratulations! :tada:

:bulb: The Security team recommends that you are setting up the scan in your repository by following our guide.

/hosting re-check

/hosting re-check

NotMyFault I have some questions that I appreciate if you could answer it: 1- About the change of docker-java to docker-java-api. Is there any way to use the docker-java-api dependency without modifying a lot of things in the code? When I tried to switch I found a lot of things that I need to change. 2- When you said: "Please remove all dependencies from your pom.xml, your plugin doesn't depend upon.". I'm a bit confused because I used credentials and in this case docker-java or docker-java-api. So on that case, I need to keep it the dependencies right?.
I'm working on the other points and I will try to merge a PR ASAP. Thanks for your help.

For 1, the docker-api-plugin bundles the maven artifact and contains the same source code as  before, no changes to your code should be needed.
For 2, the default pom ships a plenty of dependency plugins commonly don't need. This point encourages you to go over each and check whether you actually need them or not.

NotMyFault I have some questions that I appreciate if you could answer it: 1- About the change of docker-java to docker-java-api. Is there any way to use the docker-java-api dependency without modifying a lot of things in the code? When I tried to switch I found a lot of things that I need to change. 2- When you said: "Please remove all dependencies from your pom.xml, your plugin doesn't depend upon.". I'm a bit confused because I used credentials and in this case docker-java or docker-java-api. So on that case, I need to keep it the dependencies right?.
I'm working on the other points and I will try to merge a PR ASAP. Thanks for your help.

For 1, the docker-api-plugin bundles the maven artifact and contains the same source code as before, no changes to your code should be needed. For 2, the default pom ships a plenty of dependency plugins commonly don't need. This point encourages you to go over each and check whether you actually need them or not.

Hey, thanks for you comments. After some investigation and fighting to change the code I realized that I didn't need to use it, and I found a workaround that works for our case without the some dependencies. Last changes were pushed to the main branch.
I think I tackle all the main points. Please, LMK if this works for you.
Thank You!

/request-security-scan

/hosting host


Add proxy information to FAQ.

Fixes #160.

Seems like there is a problem with the AWS dependencies.

Thanks Klaus - have merged this now


[Feature Request] Batch tag changing

Problem: Unable to tag multiple photos.
Solution: Add feature that allows all selected photos to be tagged instead of just one at a time.
Replicate current situation:
We can select groups of photos with ctrl or shift to move them from folder to folder, but if you select multiple photos and then change the tag by hovering and selecting it from the drop down menu then it ONLY changes on the clicked photo instead of all the actively selected photos.

Already supported.
https://github.com/zanllp/sd-webui-infinite-image-browsing/wiki/Change-log


Fixed issue #15

This need at least 5.10 to build.

Added support for older versions of Qt and also fixed memory leak. DeferredFuture must be moved to the main thread, since that's the only thread that's guaranteed to be running an event loop such that the deleteLater works properly.


NullPointerException in mock provided class

Hi,
I am trying to provide a mock implementation of a Retrofit RestAdapter for my unit test.  However, restAdapter.build(); keeps throwing this exception

Cannot return null from a non-@Nullable @Provides method

What should I do to resolve this?
Thank you,
Igor

Closing as not an issue related to this repo.
Please post your question on stackoverflow.

Yes thanks.  My mistake was that I tried to mock RestAdapter with Mockito.
On Aug 27, 2015 11:51 AM, "Fernando Cejas"<EMAIL_ADDRESS>wrote:

Closed #41
https://github.com/android10/Android-CleanArchitecture/issues/41.
—
Reply to this email directly or view it on GitHub
https://github.com/android10/Android-CleanArchitecture/issues/41#event-394173710
.


The 'Function app on Azure App Service plan.' github template link points to the vm-simple-linux sample template

The link in https://docs.microsoft.com/en-us/azure/azure-functions/functions-infrastructure-as-code#deploy-on-app-service-plan is pointing to the wrong sample template.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: a1ba8817-3e01-7e84-6c71-b98b131f2927
Version Independent ID: a7703386-9e83-1075-72ef-f9e63f3dc4de
Content: Automate function app resource deployment to Azure
Content Source: articles/azure-functions/functions-infrastructure-as-code.md
Service: azure-functions
GitHub Login: @ggailey777
Microsoft Alias: glenga

Thanks for the feedback! We will review and get back to you shortly.

I have assigned the issue to the doc author to update appropriately.

@kwill-MSFT thanks for letting us know about this bad link.


style(readme): formatting

Pull Request Test Coverage Report for Build 1725

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 63.793%

Totals

Change from base Build 1724:
0.0%

Covered Lines:
101

Relevant Lines:
152

💛  - Coveralls


Check for shard key or sort key before creating the temporary command

Summary:
This PR addresses a compatibility issue in Singlestore for incremental models using shard_key or sort_key. Previously, attempting to use these keys would fail due to an incorrect assumption that temporary tables are rowstore, which is not supported by Singlestore for CLUSTERED COLUMNAR indexes.
Details:

Problem: Models with shard_key or sort_key couldn't be deployed as incremental tables because the system tried to create them as rowstore temporary tables, conflicting with Singlestore's requirements.
Solution: We've updated the logic to dynamically set the storage type for temporary tables. If a model has shard_key or sort_key, it's created as a "temporary" table (compatible with these keys), otherwise, it defaults to "rowstore temporary".
Benefits: This update ensures that all incremental models, regardless of their key configurations, can be deployed successfully in Singlestore.

Hi @jvelezmagic! Thank you for bringing this to our attention. In SingleStore, the SORT KEY()is not allowed when using CREATE ROWSTORE TABLE. However, there is no such restriction for shard keys. Therefore, I suggest retaining only the sort key check in the if-statement. If you encounter any issues with shard keys, could you please share the version of the adapter you're using and a model that triggers the problem?

added sort key check in #28


(#462) Prepend OS-pid and platform thread-ID to assert message.

To better debug assertion failures, this commit extends the assert message to prepend the OS-pid and thread-ID (index) of the running Splinter thread that encountered the assertion.
A sample output from this amended assertion message looks like:
OS-pid=2235, Thread-ID=0, Assertion failed at tests/unit/misc_test.c:110:...

Couple of existing test cases are mildly amended to cope with these new fields in the assert message printed.
Existing debug_assert() also gains this functionality as it's a wrapper around platform_assert().
Currently, seeing OS-pid may not be helpful as we are running in single-process multiple-thread execution model.
In future, when we support multiple processes connecting to Splinter, this extra OS-pid information will be very helpful to debug signals / assertions / failures.

@rosenhouse , Rob @rtjohnso , has passed this fix. It's fairly straightforward but I wanted your opinion too.
What we have now with this fix is a bit verbose. I had a re-think, even while doing this work, that probably the new fields should be output in a way that they are more easily programmatically accessed.
So rather than:
(1) OS-pid=%d, Thread-ID=%lu, Assertion ...
Should we go for ':'-separated fields for the two number fields, like so:?
(2) %d:%lu:Assertion ...
I like the verbose output as it's self-documenting, however, there is a valid reason to go to the alternate format.
No one is parsing assertion messages right now, so probably current verbose output is acceptable.
And as this is a message from a failed assertion, I thought a verbose (1) is preferable.
Do you have a strong preference for (1) or (2)? If not, I'd like to stay with (1).


Update Front Matter across SCBs and specific language in the Defender SCB to match OCC approved language

🗣 Description

OCC originally disapproved the consolidated baseline update document and SCBs for the Iceberg / Jellyfish release due to concerns that the SCBs may imply that CISA is telling the audience to upgrade their licenses to  higher tier. The updates found in this PR include SCB changes to the front matter to address this concern.
💭 Motivation and context

Change is required for the consolidated change document and the SCBs to be approved for the version 1.4.0 release.
Closes #1393
🧪 Testing
N/A
✅ Pre-approval checklist

[x] This PR has an informative and human-readable title.
[x] PR targets the correct parent branch (e.g., main or release-name) for merge.
[x] Changes are limited to a single goal - eschew scope creep!
[x] Changes are sized such that they do not touch excessive number of files.
[x] Related issues these changes resolve are linked preferably via closing keywords.
[x] All relevant type-of-change labels added.
[x] All relevant project fields are set.
[x] All relevant repo and/or project documentation updated to reflect these changes.
[x] All relevant functional tests passed.
[x] All automated checks (e.g., linting, static analysis, unit/smoke tests) passed.

✅ Pre-merge checklist

[ ] PR passed smoke test check.

[ ] Feature branch has been rebased against changes from parent branch, as needed
Use Rebase branch button below or use this reference to rebase from the command line.

[ ] Resolved all merge conflicts on branch

[ ] Notified merge coordinator that PR is ready for merge via comment mention

✅ Post-merge checklist

[ ] Feature branch deleted after merge to clean up repository.
[ ] Verified that all checks pass on parent branch (e.g., main or release-name) after merge.

Note: The SCBs language changes are expected to be reviewed by the lead lawyer at OCC on November 4th then routed to EAD (front office) for final review. This SCB update cannot be merged into MAIN until all parties above approve the updates!

@mitchelbaker-cisa added in @adhilto's additional links and resources, updated the implementation steps for DEFENDER.6.3v1, and added his note on log retention in the license requirements sections for Defender and EXO. Please take a look at all of the above and make any changes. Once approved will add to the consolidated change document to get routed up to EAD.

current status: routed back to CB Comms to go through final approvals on 11/7

@nanda-katikaneni & @schrolla Just got word from Chad that the SCBs have been approved! good to merge and add to 1.4.0 release!


problem dropping epochs by visual inspection

Found a problem regarding dropping epochs. You can try it with the data of the read epochs example.
Plotting epochs and selecting bad epochs by hand results in a reduction of the total number of epochs. This does not work plotting only the epochs corresponding to a certain event_id.
Doing it for the whole set:
epochs
Out[2]: <Epochs  |  n_events : 55 (all good), tmin : -0.199795213158 (s), tmax : 0.499488032896 (s), baseline : (None, 0), ~17.5 MB, data loaded>

epochs.plot()
Out[3]: <matplotlib.figure.Figure at 0xc8afda0>Dropped 5 epochs
Channels marked as bad: []

epochs
Out[4]: <Epochs  |  n_events : 50 (all good), tmin : -0.199795213158 (s), tmax : 0.499488032896 (s), baseline : (None, 0), ~16.3 MB, data loaded>

5 epochs are marked as bad -> the total number of epochs is reduced by five
Plotting only epochs corresponding to an event_id:
epochs['1']
Out[2]: <Epochs  |  n_events : 55 (all good), tmin : -0.199795213158 (s), tmax : 0.499488032896 (s), baseline : (None, 0), ~17.5 MB, data loaded>

epochs['1'].plot()
Out[3]: <matplotlib.figure.Figure at 0xa250978>Dropped 5 epochs
Channels marked as bad: []

epochs['1']
Out[4]: <Epochs  |  n_events : 55 (all good), tmin : -0.199795213158 (s), tmax : 0.499488032896 (s), baseline : (None, 0), ~17.5 MB, data loaded>

5 epochs are marked as bad -> the total number of epochs stays the same

Doing epochs[...] will make a copy, not a reference to the original object. So to do what you want, you'd need to use epochs.selection and do things manually I think.
Is there somewhere in the docs we can make this clearer?

I tried this:
epochs[epochs['1'].selection].plot()
But it doesn't work either, same problem. Is there any way to work on a subset of epochs instead of plotting all at once?

yes it also makes a copy.
what do you mean work? plot? if so we would need to add a param to plot to
only plot a subset of epochs

By work I mean selecting bad epochs.

you need to make new epochs per conditions and work individually.
you can concatenate back if you need.

According to your suggestion, this is my approach:
epochs_all = list()
counter = 0
for event_id in epochs.event_id:
    epochs_all.append(epochs[str(event_id)])
    epochs_all[counter].plot(picks=picks, scalings='auto', block=True)
epochs_all = mne.concatenate_epochs(epochs_all)

It works, but I lose the information about the original timing and indexation.

I wouldn't use concatenate_epochs (sorry @agramfort). It should be possible to use epochs.selection using array manipulation to get the indices back to the original Epochs instance. I see you tried above but it seems like it must be possible. If you're sick of trying I can give it a shot.

Currently, I have no further ideas how to apply the epochs.selection except as indices ...

Argh yes selection gets restricted. Fortunately we can use event numbers, though. See if this makes sense:
import numpy as np
import mne
raw = mne.io.read_raw_fif(mne.datasets.sample.data_path() +
                          '/MEG/sample/sample_audvis_raw.fif')
events = mne.find_events(raw, 'STI 014')
epochs = mne.Epochs(raw, events, event_id=dict(foo=1, bar=2), preload=True)
epochs.drop([1])
epochs_foo = epochs['foo']
# we can get indices back to the original using np.searchsorted
# based on the epoch sample numbers (because they're in order):
orig_idx = np.searchsorted(epochs.events[:, 0], epochs_foo.events[:, 0])
assert (epochs.events[orig_idx, 2] == 1).all()  # sanity check
# let's drop some in our copy
epochs_foo.drop([0, 1, 2])
# figure out which ones are still there
orig_idx_good = np.searchsorted(epochs.events[:, 0], epochs_foo.events[:, 0])
assert len(orig_idx_good) == len(orig_idx) - 3  # we removed 3
# figure out which ones we removed (in the original)
orig_idx_bad = np.setdiff1d(orig_idx, orig_idx_good)
assert len(orig_idx_bad) == 3
epochs.drop(orig_idx_bad)
# Did we drop the correct ones?
assert np.array_equal(epochs['foo'].events, epochs_foo.events)

Thanks for your help. I think it works that way, with only slight modifications:
        for event_id in epochs.event_id:
            epochs_event = epochs[event_id]
            # we can get indices back to the original using np.searchsorted
            # based on the epoch sample numbers (because they're in order):
            orig_idx = np.searchsorted(epochs.events[:, 0], epochs_event.events[:, 0])
            assert (epochs.events[orig_idx, 2] == int(event_id)).all()  # sanity check
            # let's drop some in our copy
            epochs_event.plot(picks=picks, scalings='auto',
                              block=True) # epochs_foo.drop([0, 1, 2])
            # figure out which ones are still there
            orig_idx_good = np.searchsorted(epochs.events[:, 0], epochs_event.events[:, 0])
            idx_bads = [idx for idx in range(len(epochs_event.drop_log)) \
                        if epochs_event.drop_log[idx] == ['USER']]
            n_bads = len(idx_bads)
            assert len(orig_idx_good) == len(orig_idx) - n_bads  # we removed 3
            # figure out which ones we removed (in the original)
            orig_idx_bad = np.setdiff1d(orig_idx, orig_idx_good)
            assert len(orig_idx_bad) == n_bads
            epochs.drop(orig_idx_bad, reason='USER_'+event_id)
            # Did we drop the correct ones?
            assert np.array_equal(epochs[event_id].events, epochs_event.events)

Nevertheless, is it conceivable that in future they will be a param to plot only a subset of epochs without copying? Furthermore, it would be nice if marked epochs would not be deleted immediately. Instead they could get annotated like it is done for segments in raw.


17: Add user persistence

#17

[x] 1) add personal info to logged in root
[x] 2) store user in mongodb
[x] 3) store session in mongodb

Completes #17


odo complains of failing to create ingress but URL gets created

What versions of software are you using?
Operating System: all
Output of odo version: master
How did you run odo exactly?
$ odo url create --host `minikube ip`.nip.io
 ✓  URL node-todo-8080 created for component: node-todo

To apply the URL configuration changes, please use `odo push`

$ odo url list
Found the following URLs for component node-todo
NAME               STATE          URL                                             PORT     SECURE     KIND
node-todo-8080     Not Pushed     http://node-todo-8<IP_ADDRESS>.156.nip.io     8080     false      ingress
There are local changes. Please run 'odo push'.

$ odo push

Actual behavior
odo push

Validation
 ✓  Validating the devfile [32094ns]

Creating Kubernetes resources for component node-todo
 ✓  Waiting for component to start [7s]
 ⚠  Unable to create ingress, missing host information for Endpoint http-8080, please check instructions on URL creation (refer `odo url create --help`)

Applying URL changes
 ✓  URL node-todo-8080: http://node-todo-8<IP_ADDRESS>.156.nip.io/ created

Syncing to component node-todo
 ✓  Checking files for pushing [568651ns]
 ✓  Syncing files to the component [188ms]

Executing devfile commands for component node-todo
 ✓  Executing install command "npm install" [20s]
 ✓  Executing run command "npm start" [1s]

Pushing devfile component node-todo
 ✓  Changes successfully pushed to component

$ kubectl get ingress
NAME                       CLASS    HOSTS                                  ADDRESS          PORTS   AGE
node-todo-8080-node-todo   <none>   node-todo-8<IP_ADDRESS>.156.nip.io   <IP_ADDRESS>   80      75s

In above output, odo complains Unable to create ingress, missing host information for Endpoint http-8080, please check instructions on URL creation (refer odo url create --help)
But ingress has been successfully created and I can also access the app on the URL that was created
Expected behavior
odo should not complain when things just work
/kind bug
/area url
/area UX

In above output, odo complains Unable to create ingress, missing host information for Endpoint http-8080, please check instructions on URL creation (refer odo url create --help``

The creation of URL http-8080 failed. It was the default URL in the devfile.yaml.

Applying URL changes
✓  URL node-todo-8080: http://node-todo-8<IP_ADDRESS>.156.nip.io/ created

The URL created was node-todo-8080.

In above output, odo complains Unable to create ingress, missing host information for Endpoint http-8080, please check instructions on URL creation (refer odo url create --help``

The creation of URL http-8080 failed. It was the default URL in the devfile.yaml.

But the original devfile for nodejs has port 3000. I changed it from 3000 to 8080 before doing odo push. So http-8080 isn't default in that case, no?

But the original devfile for nodejs has port 3000. I changed it from 3000 to 8080 before doing odo push. So http-8080 isn't default in that case, no?

http-8080 was the URL present when the component was created. It is the default endpoint in the nodejs devfile from the registry (https://github.com/odo-devfiles/registry/) https://github.com/odo-devfiles/registry/blob/0b0e73401e462324a8db32b60c625f56ad639391/devfiles/nodejs/devfile.yaml#L20. odo url create created a new URL in the devfile.

I think we both are talking about http-3000 and not http-8080. The link you shared has http-3000 as the endpoint in devfile. Am I missing something? :thinking:

While doing odo push, odo tries to create url from devfile.yaml, this message is generating during that,
Unable to create ingress, missing host information for Endpoint http-8080, please check instructions on URL creation (refer `odo url create --help`)

however, you already have created the url using odo url create  which is successful.
This behavior of odo url gets confusing for ingress, i mean we are auto creating url during odo push  which works ok for route case but not for ingress one, as we cannot provide host information in devfile.

checked the code, we are checking against endpoint name, before default creating against odo push

But the original devfile for nodejs has port 3000. I changed it from 3000 to 8080 before doing odo push. So http-8080 isn't default in that case, no?

@dharmit you have updated the port but have you changed endpoint name?

@dharmit you have updated the port but have you changed endpoint name?

Yes. I changed the port number as well the endpoint name. I just did sed -i s/3000/8080/' devfile.yaml on the default devfile that odo create pulls for me.

Yes. I changed the port number as well the endpoint name. I just did sed -i s/3000/8080/' devfile.yaml on the default devfile that odo create pulls for me.

hmm, then something is broken here :|

Don't see this any more against main branch.
/close


[ERROR TEMPLATE] Java - Cannot find symbol

Name
Type
Code
Language

Cannot find symbol
Compile-time Error
java.lang.SymbolNotFoundError
Java

Description
The compiler cannot find a referenced symbol (variable, method, class, etc.) in the code.
Sample Code
public class Program {
    public static void main(String[] args) {
        System.out.println(a);
    }
}

Sample Error Message
Program.java:3: error: cannot find symbol
        System.out.println(a);
                           ^
  symbol:   variable a
  location: class Program
1 error

Implementation Checklist

[ ] Implemented analysis
[ ] Implemented explanation translation
[ ] Implemented bug fix generation
[ ] Add tests

Currently under: Java.UnknownVariableError

Done implementing: #46, #47, #1


[BUG] NPE when queryResults.isEmpty() but hasAggs is true

Describe the bug
We have the following occuring;
If there is an empty result:
https://github.com/opensearch-project/OpenSearch/blob/8c9481a2ca5f172157ba7ce30dd03324b0527428/server/src/main/java/org/opensearch/action/search/SearchPhaseController.java#L465-L467
returns with an almost empty ReducedQueryPhase instance, which further on in
https://github.com/opensearch-project/OpenSearch/blob/8c9481a2ca5f172157ba7ce30dd03324b0527428/server/src/main/java/org/opensearch/action/search/QueryPhaseResultConsumer.java#L163-L165
creates an NPE if the query had aggregations.
It is probably related to the multi_terms aggregation.
To Reproduce
Steps to reproduce the behavior:

Start a new/empty OpenSearch 2.4 instance
create an index PUT http://localhost:9200/test_jh
run the following query:

{
	"aggregations": {
		"agg": {
			"date_histogram": {
				"field": "timestamp",
				"format": "date_time",
				"fixed_interval": "30m"
			},
			"aggregations": {
				"agg": {
					"multi_terms": {
						"terms": [
							{
								"field": "field1"
							},
							{
								"field": "field2"
							}
						]
					}
				}
			}
		}
	}
}

The following error occurs:
{
	"error": {
		"root_cause": [
			{
				"type": "response_handler_failure_transport_exception",
				"reason": "java.lang.NullPointerException: Cannot invoke \"org.opensearch.common.io.stream.NamedWriteable.getWriteableName()\" because \"namedWriteable\" is null"
			}
		],
		"type": "search_phase_execution_exception",
		"reason": "",
		"phase": "fetch",
		"grouped": true,
		"failed_shards": [
			{
				"shard": 0,
				"index": "test_jh",
				"node": "NbG0fKofQ5OOkIagnOIXvA",
				"reason": {
					"type": "response_handler_failure_transport_exception",
					"reason": "java.lang.NullPointerException: Cannot invoke \"org.opensearch.common.io.stream.NamedWriteable.getWriteableName()\" because \"namedWriteable\" is null",
					"caused_by": {
						"type": "null_pointer_exception",
						"reason": "Cannot invoke \"org.opensearch.common.io.stream.NamedWriteable.getWriteableName()\" because \"namedWriteable\" is null"
					}
				}
			}
		],
		"caused_by": {
			"type": "null_pointer_exception",
			"reason": "Cannot invoke \"org.opensearch.search.aggregations.InternalAggregations.getSerializedSize()\" because \"reducePhase.aggregations\" is null"
		}
	},
	"status": 500
}

Expected behavior
There should be no NPE, the empty result should be propagated as is.
Host/Environment (please complete the following information):

OS: macOS, Ubuntu 20.04
Version 2.4

Added example to reproduce problem.

@janheise You did most of the work to debug this! Thank you. Want to try to implement a unit test and maybe even a fix?

@dblock I am currently too busy to tackle it myself - and am surprised about the good first issue label. From what I've seen (but I did not look into it too deeply), you need a lot of context to decide where the problem actually starts and how a bugfix should look.

@janheise Thanks! @anasalkouz triaged it as such, I imagine because there's a request/response repro (thank you). I think a unit test is not too difficult based on this, but I agree that fixing the problem may be much more involved. Would value a PR that just has the unit test, it will get whomever wants to fix this one step further.

/assign

When I tried to debug, it turned out that queryResults has size of 1 and hence it doesn't goes into below condition
if (queryResults.isEmpty()) { // early terminate we have nothing to reduce             final TotalHits totalHits = topDocsStats.getTotalHits();             return new ReducedQueryPhase(
Instead, below is evaluates to null, because bufferedAggs list is empty.
final InternalAggregations aggregations = reduceAggs(aggReduceContextBuilder, performFinalReduce, bufferedAggs);

am surprised about the good first issue label. From what I've seen (but I did not look into it too deeply), you need a lot of context to decide where the problem actually starts and how a bugfix should look.
Agreed, will keep the label for the unit test

Hey @anasalkouz @janheise @dblock, I am going to pick this up since the previous assignee has left. Will reply here if I need any help

Hi @geetptl, it has been a while, are you actively working on this?

Could you give a rough estimate about when the issue could be solved or if someone actively works on it? We have some business decisions depending on that.

@z002Holpp I would say nobody is working on it unless it clearly says so, and looks like @geetptl isn't around to confirm they still are :( maybe you can help with some hands?

Het @dblock, I'm not working on this, feel free to take it up!


Add Organization.acronym

Monday Task

Let me get #1518 in first, since it provides a better foundation to continue adding organization form fields. I'll rebase this on that.

Ok I additionally have #1521 which fixes the weirdness with clearing text fields.
Separately I'm less convinced now of what the display UI should look like, so took a stab at something different. But I want to run it by product/design first.

Ok I additionally have #1521 which fixes the weirdness with clearing text fields.
Separately I'm less convinced now of what the display UI should look like, so took a stab at something different. But I want to run it by product/design first.

Just out of curiosity what is the business goal/reason for having avatarLetters and the acronym?  Is it basically giving the user the option to create a custom abbreviation when the code generated avatar letters are not exactly what is desired? Is there a business reason/use for having both fields that seem to do the same thing from a newbie's perspective?

Avatar letters just grabs the first letters of the words in the name. So it's naive. I'm not sure of its usefulness now that we have an actual field. That's what I want to ask about.


Remove .dir-locals.el

Motivation for this change
This file has been excruciatingly annoying to me. I don't personally want to save those dir-locals as trusted in my emacs config. So now every buffer I open prompts me "Do you really want to apply it?" This includes magit, which operates by opening buffers extremely frequently. Frankly, I think anyone who wants the behavior of this file should add it to their worktree themselves. I have to keep it deleted, which causes many git commands to fail because of unstaged changes, whereas adding the file to your worktree makes it untracked and git will basically never complain about it.

Well for one, I shouldn't have to change my emacs config and enable emacs features I don't care about to be able to productively contribute to nixpkgs. That's a silly thing to annoy any drive-by or first-time contributor with.
Also, my emacs config file is not writable, so I can't just get emacs to do it for me. I just home-manager to install the file from my dotfiles repo so it's a symlink to the nix store.

 It's just that I don't care about it, so I'd rather not have it cluttering my emacs file, plus I can't automatically add it anyway. And seeing "You must modify your emacs config to contribute to this repo" is a big annoyance to drive-by/first-time contributors=
13:23 <gchristensen> why must you modify your emacs config?
13:23  * gchristensen isn't _trying_ to be dense :)
13:24 <elvishjerricco> gchristensen: Because it's insanely frustrating to have every new buffer (including minor ones like magit UIs) also pop up this prompt "Would you like to save these things?"
13:25 <elvishjerricco> You can't tell it to *stop* asking (nor should you have to)
13:25 <gchristensen> elvishjerricco: I think I'm missing something, and I'm trying to understand what it is I'm missing -- not challenging that it is a frustrating experience
13:25 <gchristensen> elvishjerricco: dir-locals doesn't get dynamically loaded, but is instead appended to your emacs init.el or whatever?
13:26 <elvishjerricco> gchristensen: emacs asks if you'd like to apply the variables in every new buffer you open. Then, if you'd like it to stop prompting, your only option is to tell it to write to your emacs config that you trust these particular variables, so it'll open new buffers (and use the enabled features) without the prompt.
13:26 <gchristensen> ahh it has to write the trust status
13:27 <elvishjerricco> So with magit, you press one key per action you're trying to take. Each key you press opens this prompt
13:27 <gchristensen> makes sense

cc @matthewbauer who added this in June

FTR I was also annoyed by this new file because every time it asked me about these variables was not the time for me to review this file.
In the Coq project, we have decided to get rid of such .dir-local.el and instead provide a coqdev.el file that people can choose to load.
In Nix, there is indeed the EditorConfig file already for which I have installed the Emacs package (although I'm not quite sure what it does).

It could be indeed:
$ emacs --version
GNU Emacs 25.3.1

I'm using the version of Emacs that is distributed with NixOS 18.03. I see that 18.09 has just released though so I'll probably be upgrading very soon. What about you @ElvishJerricco?

Sorry about that! Yeah since emacs 25 is still in 18.03 it definitely shouldn't be forgotten about. Anyway bug-reference-regexp is not all that useful so it's fine to leave .dir-locals.el off for now.

Oh so there will be no prompting with emacs 26, even if I've never purposefully saved the locals? If that's the case, perhaps we can add this back after giving 18.09 some time for adoption. I'm still on 18.03 (emacs 25).


Add Closes to template

Describe your changes

Linked issues

Closes #127
Breaking changes

[ ] This issue contains breaking changes

Codecov Report
Base: 61.15% // Head: 61.15% // No change to project coverage :thumbsup:

Coverage data is based on head (a1194a5) compared to base (ae62833).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #128   +/-   ##
=======================================
  Coverage   61.15%   61.15%
=======================================
  Files          44       44
  Lines        1058     1058
  Branches       74       74
=======================================
  Hits          647      647
  Misses        393      393
  Partials       18       18

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Loading spinner component

Problem statement
As we start working with new test types or advanced filtering, users may experience a beat or two of load time. Create a reusable loading spinner/indicator that can work across RS.
What you need to know

As we're moving to React ... is there anything built in there that might be helpful with this? Theoretically things should be pretty swift with React anyway, right?
USWDS doesn't have a default spinner. We could use some of their default icons and animate with css or js?
Update: Mo added this as a stopgap solution for the time being Font Awesome has a default spinner class, but would invovlve adding some weight to the project and may duplicate some of the icons we already have with USWDS.
It also doesn't have to be a "spinner" either, investigate other loading indicators that may work.

Acceptance criteria

[ ] Users are able to see an indicator that something is loading on the page

To do

[ ] ...

@TomNUSDS I would second that! My latest PR does add the App-level spinner back because we did have that uncaught suspense warning happening. If that doesn't fix the "loading" message displaying on page refresh in Staging then we can report that as a separate bug.


Display message body and content

Hi! first of all I want to thank you for putting such a great effort into this amazing solution for command line users. Unencrypted email is unnaceptable nowadays so this really makes a difference for sysadmins and people with low end machines that can't afford a fancy GUI running on top.
That said, I wanted to ask you if there is a way to display the message body and content, because the inbox option only seems to show subjets. I'll really apreciatte any help.
Thanks for your time and please excuse my broken english, I'm not american. Goodbye!

@FEFB-tech Thank you for your message. It would be useful I agree, I'll try to find some time to add this feature.


Voice.py error

Hello, I am attempting to send SMS messages through nflgame but I receive the following error.
Error
Traceback (most recent call last):
  File "C:\Users\Marcello\Desktop\ip_change_alert.py", line 4, in <module>
    nflgame.alert.google_voice_login("gmailemail@gmail.com","Password")
  File "C:\Python27\lib\site-packages\nflgame\alert.py", line 123, in google_voice_login
    _voice.login(email, passwd)
  File "build\bdist.win32\egg\googlevoice\voice.py", line 70, in login
AttributeError: 'NoneType' object has no attribute 'group'

I am using Windows 7 Enterprise with python 2.7.11.
My code is:
import nflgame.alert

nflgame.alert.google_voice_login("email@gmail.com","pass")
nflgame.alert.sms("pass","Test")

I have tried the following:

Reinstalling the module
Reinstalling all dependencies
Using different email accounts.

It looks like a problem in the googlevoice package. Can't help you there, unfortunately. Honestly, I haven't used this part of nflgame in a few years, so I'm not surprised that it has rotted. I'll likely remove it in the future. Probably best to find another way. (Try sending SMS using email instead of Google Voice, but it will require knowing the service provider of the recipient.)

I have not tried it, though a cursory search does uncover https://github.com/pettazz/pygooglevoice, a package that a) has been recently contributed to and b) appears to follow pretty closely to the original pygooglevoice API.


Security Code Scanning - configuration files

This PR creates the Security scanning (CodeQL) configuration files for your repository languages.
We also just opened an informative issue in this repository to give you the context and assistance you need. In most cases you will be able to merge this PR as is and start benefiting from security scanning right away, as a check in each PR, and in the Security tab of this repository.
However, we encourage you to review the configuration files and contact us via #support-security on Slack if you have any questions.
We are here to help! :thumbsup:

Product Security Engineering.

Closed


Content Issue

[This page seems to have wrong content and image. Figure 2 seems to be wrong, as it does not show part E which is there in Figure 1. Moreover in Figure 2, ABC are shown as packaging items. If C is a packaging item, it should ideally be in sequence 30]

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 8edfe78b-6486-5678-a171-95f81d2715ef
Version Independent ID: 62a24546-bb3f-5194-43f0-0db144643ab7
Content: Phantom items - Supply Chain Management | Dynamics 365
Content Source: articles/supply-chain/production-control/phantom-items.md
Service: dynamics-365-supply-chain
GitHub Login: @johanhoffmann
Microsoft Alias: johanho

Bug 734216 has been logged to address this issue.

Thanks for your feedback. We are closing this issue because we are either unable to find relevant information or reproduce this. If you're still experiencing the issue described here, please reopen or create a new issue.


jsmn_init_parser is not found in the source code

README.md should be updated as jsmn_init_parser is not found in the source code.

Bitbucket: https://bitbucket.org/zserge/jsmn/issue/30
Originally reported by: HM Yoong
Originally created at: 2014-05-05T19:09:01.120

Duplicate of #40.

Original comment by: Serge Zaitsev

Hi Serge:
Thanks for the good work. I ported your code into
http://developer.mbed.org/users/yoonghm/code/jsmn/
Regards
Hor Meng

Original comment by: HM Yoong


Unable to build using --env.aot in shared app.

Environment
Provide version numbers for the following components (information can be retrieved by running tns info in your project folder or by inspecting the package.json of the project):
✔ Getting NativeScript components versions information...
✔ Component nativescript has 5.1.0 version and is up to date.
✔ Component tns-core-modules has 5.1.1 version and is up to date.
✔ Component tns-android has 5.1.0 version and is up to date.
✔ Component tns-ios has 5.1.0 version and is up to date.
Describe the bug
if I build the app without --env.aot I get no error. But, while building with --env.aot I get error as:
ERROR in : Type AppComponent in /src/app/app.component.tns.ts is part of the declarations of 2 modules: AppModule in /src/app/app.module.ts and AppModule in /src/app/app.module.tns.ts! Please consider moving AppComponent in /src/app/app.component.tns.ts to a higher module that imports AppModule in /src/app/app.module.ts and AppModule in /src/app/app.module.tns.ts. You can also create a new NgModule that exports and includes AppComponent in /src/app/app.component.tns.ts then import that NgModule in AppModule in src/app/app.module.ts and AppModule in /src/app/app.module.tns.ts.

Duplicate of https://github.com/NativeScript/nativescript-schematics/issues/140


Move the description of the core types into their own pages

This expands on some of the core type descriptions, and also makes it
easier to find the documentation for each type, at least on Unix, with
a simple call like "man OSSL_ALGORITHM".

This pull request is ready to merge


How can I change the mobile burger color ? The blue color do not match my design

Hi !
How can I chanfge the mobile burger color (or svg) ? The blue color do not match my design
Could you help me for that ?
Regards,
Michael

https://learn.getgrav.org/16/themes/customization#custom-css


Create reportho blog post

Blog post for reportho release

@netlify /blog/2024/reportho_intro

@nf-core-bot fix linting

@mashehu Added the links, is it okay now?

Almost, the link format in markdown is [label](url) not (label)[url]

Almost, the link format in markdown is [label](url) not (label)[url]

Oops, not enough hackathons. Fixed it now.

@nf-core-bot fix linting

Good to go now. hit merge whenever you want  🙂


refactor(api): remove results caching using redis

removes the caching of results using redis. HSDS contains its own cacheing, so this could help
reduce load on redis for other features like the queue.
closes #4222

:tada: This PR is included in version 9.6.4 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Setting additionalProperties: true does not generate map[string]interface{}

Problem statement
I specify a definition to be of type object with additionalProperties: true. I expect the generated client model to be of type map[string]interface{}. I see the resulting model instead has type interface{}
I would like to have a model generated as a type of map[string]interface{}, as I would like to define member functions on top of this model and cannot if it is of type interface{}
I have tried with 0.22, 0.23, and 0.17, but I continue to see this issue.
While changing it to
type: "object"
additionalProperties:
  type: "object"

does generate a map[string]interface{}, this is incompatible with the server definition as it is using javascript's swagger and will expect the values of each key to themselves be JSON, but my target is to have the values be any type. So I would like additionalProperties: true to generate map[string]interface{} so the client and server do not have contention issues.
I expected the behavior of map[string]interface{} given the following resources:
The documentation suggests this is the way to do it: https://goswagger.io/use/models/schemas.html (Ctrl+F for "additionalProperties: true", and it has an example suggesting that the addition of this causes the generated code to have the type map[string]interface{})
https://goswagger.io/faq/faq_model.html (Also says that if I add additionalProperties: true it will generate a map[string]interface{})
In addition, the following tickets all suggest this is a valid method of achieving the desired result:
https://github.com/go-swagger/go-swagger/issues/1450#issuecomment-385613822 (not stated outright but that is how I understood this comment)
https://github.com/go-swagger/go-swagger/issues/2081#issuecomment-541296380
Swagger specification
swagger: "2.0"
info:
  version: "1.0.0"
  title: "Swagger Petstore"
host: "petstore.swagger.io"
basePath: "/v2"
paths:
  /pet:
    post:
      operationId: "addPet"
      parameters:
      - in: "body"
        name: "body"
        schema:
          $ref: "#/definitions/Pet"
      responses:
        "405":
          description: "Invalid input"
definitions:
  Pet:
    type: "object"
    additionalProperties: true

Steps to reproduce
$ go-swagger generate client -t <outputDir> -f <aboveSnippet>
$ cat <outputDir>/models/pet.go
// Code generated by go-swagger; DO NOT EDIT.

package models

// This file was generated by the swagger tool.
// Editing this file might prove futile when you re-run the swagger generate command

// Pet pet
// swagger:model Pet
type Pet interface{}

I expect that since the Pet definition has additionalProperties: true, that the resulting model would be type Pet map[string]interface{}, not type Pet interface{}
Environment
swagger version: 0.22.0
go version: 1.13.1
OS:  MacOS High Sierra/Darwin

Duplicates #1450
The reason why this has never been fixed is that it introduces a breaking change in the generated code.
Maybe this should be added as "opt-in" so all existing generated code still behaves the same.


Update readme.md to include option how to create installer packages from build

Currently, the readme does not include information on how to create an installer package (debian). Update to include that information. More updates are coming on how to install using these packages and test with a local dev cluster environment

@bpm-ms  @vturecek ping


chore(deps): upgrade configuration

Upgrades project dependencies. See details in workflow run.

Automatically created by projen via the "upgrade-configuration-1.x" workflow

⚪ Backport skipped
The pull request was not backported as there were no branches to backport to. If this is a mistake, please apply the desired version labels or run the backport tool manually.
Manual backport
To create the backport manually run:
backport --pr 1724

Questions ?
Please refer to the Backport tool documentation


feat: allow scaling images

This adds support for scaling images. Images can, for now, only be scaled to a percentage of the screen width wise. To do this, use the notation ![image:width:50%](image-path) (shorthands are also image:width:50 or image:w:50). ~I will make the image: prefix configurable before merging this PR so you can have no prefix if you feel like it as well~ The prefix is configurable now. The reason for having a prefix is I've seen some people wanting to be able to pull presentations made with other tools so I don't want to make any assumptions about what those presentations have inside image tags.
@mikavilpas could you give this a shot and lmk your thoughts? I still need to add some stuff and polish this but it's functional already.
Fixes #260

Merging this. @mikavilpas please let me know if something looks off.


Info: the PS2 demo runs on real hardware

I've tried launching the PS2 version of this demo using uLaunchELF on my PAL PS2 slim, and it seems to work without any issues.
It might be worth adding that the PS2 demo was tested on real hardware as well. I can provide photos of it running as well if there's interest.

That's awesome! I could only test it in PCSX2 so I was worried that it wouldn't run at all on real hardware. I would be extremely interested into getting some photos. I am also curious about the performances: does it run smoothly?
Thank you!

It seems to run just fine. I'll upload photos later.

Here's the gallery of a couple photos I took: http://imgur.com/a/gsXXr

Thank you for testing and taking the photos, I will add these pictures to the readme and credit you!


Add option to preserve original file name

Is your feature request related to a problem? Please describe.
When uploading to a backend like azure blob storage it is not possible to change the key. The landscape using the files we upload use original file names. We like to use tus to upload very large files like 200gb. Now when we want to rename the key we need to copy the entire file again so we have the original file key. The uniqueness of the file is already taken care of based on the upload key we want to provide.
Describe the solution you'd like
An option to preserve or to configure a custom destination key for usage with blob storage or s3 like backends.  When a key already exists the file could be overwritten. When the meta data already exists the upload can be resumed etc.
Describe alternatives you've considered
Right now we are forced to upload the files to a static location and copy them to final destination with original filename as first step of our ETL workflow.
Can you provide help with implementing this feature?
We have some hours available from our employer (Dutch government Geological Survey agency: Kadaster) and we have colleagues working with go. We could sure spare some time to help implementing.

tusd v2, which was released two weeks ago, includes a feature to customize the upload ID (and hence the upload location) on the server-side during the initial stages of the upload. You can read more at https://github.com/tus/tusd/blob/main/docs/hooks.md, in particular the pre-create hook is relevant for your question.

tusd v2, which was released two weeks ago, includes a feature to customize the upload ID (and hence the upload location) on the server-side during the initial stages of the upload. You can read more at https://github.com/tus/tusd/blob/main/docs/hooks.md, in particular the pre-create hook is relevant for your question.

Great! I'm looking into it right now. We like the option to use TUSD programmatically like described here. How would you implement the pre-create hook in this case? Or is this not supported?

@Acconut Thanks for your tip! We implemented a test case like this:
func main() {

	azureConfig := &azurestore.AzConfig{
		AccountName:   "localazurite",
		AccountKey:    "localazurite",
		ContainerName: "test",
		Endpoint:      "http://<IP_ADDRESS>:10000/localazurite",
	}

	azureService, err := azurestore.NewAzureService(azureConfig)
	azureStore := azurestore.New(azureService)

	composer := handler.NewStoreComposer()
	azureStore.UseIn(composer)

	handler, err := handler.NewHandler(handler.Config{
		BasePath:                "/upload/",
		StoreComposer:           composer,
		NotifyCompleteUploads:   true,
		NotifyUploadProgress:    true,
		NotifyCreatedUploads:    true,
		PreUploadCreateCallback: preupload,
	})

	if err != nil {
		panic(fmt.Errorf("Unable to create handler: %s", err))
	}

	go func() {
		for {
			event := <-handler.CreatedUploads
			fmt.Printf("Upload %s Started\n", event.Upload.ID)
		}
	}()

	go func() {
		for {
			event := <-handler.CompleteUploads
			fmt.Printf("Upload %s Finished\n", event.Upload.ID)
		}
	}()

	http.Handle("/upload/", http.StripPrefix("/upload/", handler))
	err = http.ListenAndServe(":8080", nil)
	if err != nil {
		panic(fmt.Errorf("Unable to listen: %s", err))
	}

	//http.Handle("/files/", http.StripPrefix("/files/", fileService))
	//err = http.ListenAndServe(":8080", nil)
	//if err != nil {
	//	panic(fmt.Errorf("Unable to listen: %s", err))
	//}
}

func preupload(hook handler.HookEvent) (handler.HTTPResponse, handler.FileInfoChanges, error) {
	httpResponse := handler.HTTPResponse{}

	fileInfo := handler.FileInfoChanges{
		ID: "bla_test2",
		Storage: map[string]string{
			"Type":      "azurestore",
			"Container": "test",
			"Key":       "bla/bla_test2",
		},
	}

	return httpResponse, fileInfo, nil
}

This is great and extensible!

That looks correct, I am glad you figured it out :) I will close this issue then as it seems you question was answered. Feel free to continue here or open a new issue if there are other problems.


main.cpp:28 Plugin tests does not have function "run".

Not sure what I did wrong. It can compile and link correctly. But when I tested the program with ./gslam tests --gtest_filter=*, it reported this. I use Mac Catalina 10.15.1. Thanks.

I have the same issue. I think the previous implemented slam like dso and svo are based on the previsou GSLAM branch 2.4.2, which is different from current one.
Does anyone have a solution to transfer to current version of GSLAM framework?


Composite resource Phase-2

Phase-2 implementation of the composite resource will be based on the requirements outlined in the following google doc:
https://docs.google.com/document/d/1Hb18tUZyG7PHSwrclRHOmcYcEJvD0i9dQSmNdVckBUc/edit
The following is a list of requirements extracted from the above google doc for the purpose of tracking implementation progress. Note: The following list is not complete yet.

[ ] By default a physical file should not be associated with any logical file type.
[ ] Physical files for a given logical file must be put under a folder

I've added some notes. Primarily related to the new file extensions for
reference time series, ".refts.json" and sqlite files ".odm2.sqlite" that
are created by the CUAHSI Data Client and Resource Creator. Also, I still
think it is an extra and unnecessary burden to require the user to take the
extra step of right clicking on files to make HydroShare know what file
type they are. Dave has said many times that HydroShare is a cloud based
operating system. There is no other operating system that requires you to
tell it what your file types are. There was a clever solution to this that
was introduced about 40 years ago, it is called the file extension. ArcGIS
takes it further and looks not only for file extension but also for groups
of files with the right extensions. Please let's take care of this now
before we have to try to explain it to every confused user in every
training and every workshop. "Hey what's wrong with my resource?" "Well my
first guess is that you didn't right click on the files and tell HydroShare
what they are." Do we really want to be repeating that over and over again?
My two cents... - Dan
On Sat, Dec 2, 2017 at 12:52 PM Pabitra Dash<EMAIL_ADDRESS>wrote:

Phase-2 implementation of the composite resource will be based on the
requirements outlined in the following google doc:
https://docs.google.com/document/d/1Hb18tUZyG7PHSwrclRHOmcYcEJvD0i9dQSmNdVckBUc/edit
The following is a list of requirements extracted from the above google
doc for the purpose of tracking implementation progress. Note: The
following list is not complete yet.

By default a physical file should not be associated with any logical
file type.
Physical files for a given logical file must be put under a folder

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/hydroshare/hydroshare/issues/2502, or mute the thread
https://github.com/notifications/unsubscribe-auth/ADT89IEAhfW6xfV6U-bIGOEORZCrzbBbks5s8apkgaJpZM4QzcJa
.

I am not sure how HydroShare is any kind of operating system. It can be best described as some kind of a file management system only.

I think Dave has been calling it a "type of operating system" with file
storage, management, and apps that run on files. But indeed, it is
certainly not an actual operating system... :)
On Sat, Dec 2, 2017 at 1:41 PM Pabitra Dash<EMAIL_ADDRESS>wrote:

I am not sure how HydroShare is any kind of operating system. It can be
best described as some kind of a file management system only.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/hydroshare/hydroshare/issues/2502#issuecomment-348718672,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ADT89CsWHVjb1bgERaBRSVyujKiH1owoks5s8bYHgaJpZM4QzcJa
.

@pkdash I have added the label 3 for large effort here. Let me know if you disagree

Definitely large effort. However, I think this work is largely complete.

I noticed the Set Time Series option is "Timeseries" but we call it Time Series everywhere else on the site. Also, I may be out of the loop on this but I see a "Reference Timeseries" option...I thought that was deprecated..?

1.16 deploy


Fix #336 in #331

Describe your changes

Updated workflow to upload both libposeidon.dylib and libposeidon_jni.dylib. Previously only the later was present to fix #336
Support loading libs from local jar
Add :java:DepsTest
Add cairo 1 declaration to :javademo (#298)

Linked issues

Closes #336
Closes #298
Breaking changes

[ ] This issue contains breaking changes

Codecov Report
Attention: 13 lines in your changes are missing coverage. Please review.

Comparison is base (f8814b0) 69.93% compared to head (a81b52f) 69.73%.

Additional details and impacted files
@@                       Coverage Diff                        @@
##           feat/277-expand-android-demo     #347      +/-   ##
================================================================
- Coverage                         69.93%   69.73%   -0.20%
================================================================
  Files                                69       69
  Lines                              2528     2538      +10
  Branches                            223      225       +2
================================================================
+ Hits                               1768     1770       +2
- Misses                              685      693       +8
  Partials                             75       75

Files
Coverage Δ

...n/kotlin/com/swmansion/starknet/crypto/Poseidon.kt
97.87% <100.00%> (+0.04%)
:arrow_up:

...tlin/com/swmansion/starknet/crypto/NativeLoader.kt
25.00% <7.14%> (-4.04%)
:arrow_down:

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Creation of CAA records

Hi,
I am investigating the creation of CAA records with this Terraform Provider. It was suggested this was added in #97 where I could specify this as follows:
resource "cloudflare_record" "caa" {
  domain  = "mydomain.com"
  name    = "mydomain.com"
  data    = {
    flags = "0"
    tag   = "issue"
    value = "letsencrypt.org"
  }
  type    = "CAA"
  ttl     = 1
}

I cannot seem to find where the value parameter as part of the data map was added. Without this value parameter, no details can be passed as part of the record.
I tried to set both the data and value blocks together but both are conflicting
if valueOk == dataOk {
		return fmt.Errorf(
			"either 'value' (present: %t) or 'data' (present: %t) must be provided",
			valueOk, dataOk)
	}

Please can you help with an example implementation here?
Paul

Using the following setup, I'm unable to reproduce the issue.
variable "cloudflare_email" {}
variable "cloudflare_api_key" {}
variable "cloudflare_zone_id" {}
variable "cloudflare_domain" {}

provider "cloudflare" {
  email      = var.cloudflare_email
  api_key    = var.cloudflare_api_key
}

resource "cloudflare_record" "caa" {
  zone_id  = var.cloudflare_zone_id
  name    = "caa-test.${var.cloudflare_domain}"
  data    = {
    flags = "0"
    tag   = "issue"
    value = "letsencrypt.org"
  }
  type    = "CAA"
  ttl     = 600
}

$ dig caa-test.terraform.cfapi.net -t caa +short
0 issue "letsencrypt.org"

You shouldn't be using domain attribute as it is deprecated in favour of zone_id and the ttl cannot be 1 for a non-proxied record.

Hi @jacobbednarz
Thanks for confirming here - just a follow up question on this - how does this even work when value isn't a parameter available on the data struct?
Paul

It's kind of two part. The first is that nested or complex types in Terraform sometimes allow weird behaviour like not catching unexpected attributes (the case here) and the fact the provider iterates over the d.GetOk("data") to build the request.
When the d.GetOk("data") is ran here, the following line dumps the struct where you can see all the values present (again, despite one not having a place in the schema).
[DEBUG] Data found in config: map[string]interface {}{"flags":"0", "tag":"issue", "value":"letsencrypt.org"}

After that, the key/value pairs of the type are enumerated and the request is built which ends up marshaling into the JSON payload for creating the record.
To safe guard future changes, we should probably add the field to the schema to prevent it from randomly stop working.

Ah so it's kinda exposing the Map feature in the schema
Got it - I'll happily send a PR that adds the specific fields if you want me to?

👍 happy to review a PR for it

Hello here!
I try to use for_each with a module but it doesn't work because I can't set the data block to null in case where my DNS record is not a CAA. In the other way, if my record is a CAA type I want to use the data block and set value to null otherwise I'll have the error message below.
			"either 'value' (present: %t) or 'data' (present: %t) must be provided",
Do you have any solution for this issue?
Thanks a lot

Hi @jacobbednarz
Sorry it took so long to get back to you on this, I just opened https://github.com/cloudflare/terraform-provider-cloudflare/pull/866
Paul


If the terminal view is visible, a new terminal is not created on initial load in remote

Latest Insiders. Steps to Reproduce:

When connected to a remote, open the terminal view
Reload the window
A terminal is not created 🐛

This works in the previous stable release. I think I might have seen this in other cases, but this is my easy repro. Maybe related to terminal reconnection logic?
Video: https://memes.peet.io/img/20-12-ecc65942-93a3-475f-b541-d5da656a8305.mp4
Does this issue occur when all extensions are disabled?: Yes

@connor4312 Can you please help me with VS Code.I am an beginner and it says "exited with code=2" don't know what to do.Please response if you aren't busy.Thank You!

Please open a new issue using the instructions and details in the issue template

Hey Connor, thanks for bringing this to my attention. I'm not able to reproduce the issue with the latest insider's

The problem seems to only happen with "terminal.integrated.enablePersistentSessions": false. I probably added that to my settings during verification. If that toggle is going away this issue can probably be closed. @roblourens / @alexdima  fyi.

I think this issue can be closed even if that toggle remains, since, by definition, it will not persist when that is set (as expected). Correct?

I would not expect it to persist, but I would expect a new terminal to be started since the terminal view is visible (like it does locally)

Oh that makes sense


Possibility for links to point to package

Description
What I want to do:

Create Readme link around (from and to) package and of course contain it in the same package that readme is pointing at
Publish

Problem
Links cannot point to packages, only to links in packages

This is duplicate of https://github.com/deep-foundation/deeplinks/issues/256


Add scale docs

What type of PR is this?
/kind documentation
Special notes for your reviewer:
@ErikJiang
local test

/lgtm


CommandBus improvement

This PR builds on #228. The main idea is to move larger methods into helper classes.

Current coverage is 80.77% (diff: 94.11%)

Merging #229 into master will increase coverage by 0.12%

@@             master       #229   diff @@
==========================================
  Files           149        158     +9
  Lines          5614       5671    +57
  Methods           0          0
  Messages          0          0
  Branches        637        634     -3
==========================================
+ Hits           4528       4581    +53
- Misses          970        975     +5
+ Partials        116        115     -1

Powered by Codecov. Last update e8040af...5713fac

@armiol please pay attention to the commit on injection of CommandBus into CommandScheduler (a1bab4cc3d51c2c0178c0cb30209164405044356).
I discovered that we don't do this only by analyzing usages in IDEA. We don't have a test that checks that this wiring should be done. I have not added the test. Let's discuss first.

@alexander-yevsyukov regarding the injection.
I would say we should inject the instance of the CommandBus only in case it has not been injected previously by a Spine end-user. Otherwise we will override the rescheduling mechanism the user might set.
In particular, the rescheduling of command in GAE classic environment may be tricky — due to the request processing constraints (30 sec per HTTP request). So the best way would be to use a deferred task instead (10 mins to handle the deferred task).
The custom CommandBus instance may serve well — GAE-specific wrapper around the CommandBus — being injected into a rescheduler by a user.

@armiol PTAL

@alexander-yevsyukov LGTM.


[BUG] Screen turns grayish after start of scanning/building rocket.

Version of Advanced Rocketry

1.10.2-1.0.19

Have you verified this is an issue in the latest unstable build

[ ] Y
[ ] N
[x] N/A

Version of LibVulpes

1.10.2-0.1.19

Version of Minecraft

1.10.2

Does this occur without other mods installed

[ ] Y
[ ] N
[x] N/A

If Y, what is the MINIMUM set of mods required.

Description of the problem

After clicking scan or build the rocket, screen makes grayish.
It's grayish only when we're looking at the rocket/launch pad direction.
I've found only 2 posts about this issue and both didn't helped.
Im playing on expanded Age Of Engineering (130 mods) about 2-3 months after adding & removing last mod this issue happened, only mod that was changed in meanwhile was OptiFine, from E3 to H5. I've made a downgrade, but didn't helped.
(I've upgraded earlier OptiFine due to glitch/bug what was happening after turning off shaders)

1.10.2 Is unsupported. Please close this issue.


Narrow Json error types

JSON.parse and JSON.stringify only throw SyntaxError and TypeError respectively, so we can narrow the types in the Json module.
There is one custom error in stringify, but this is better represented as a TypeError anyway.

I like the proposal, I think though that we are missing a case?
JSON.stringify({x: 2n});
// TypeError: BigInt value can't be serialized in JSON

Should we handle both the TypeErrors messages rather than only cyclic references?

Having tried this out for a bit, these types are a bit problematic: TypeError and SyntaxError are just aliases of Error.
So, I'd probably say to create new error types, or just use Error (which is better than the original unknown).


The script launch_create_sdf_pix3d.sh is missing

Very good job！
The script launch_create_sdf_pix3d.sh is missing, how to get it？
The folder pix3d/filelists is missing, how to get it？
Looking forward to your reply!

Any updates on this?


[ASK] Use Load Balancer Client

When i use load balancer in my frontend app, the auth is not working properly and always return 401
{"code":401,"message":"An authentication exception occurred."}

I don't known, it is from symfony side or bundle side, may you can explain how that issue is producing and how to solve

Did you looked at How to Configure Symfony to Work behind a Load Balancer or a Reverse Proxy?
If it doesn't help, I suggest you to first disable the bundle and try another authentication listener (form_login, http_basic, ...) to be sure that the problem comes from the bundle doubt that your problem comes from the bundle. Anyway, better ask this on stackoverflow.
Thanks for your understanding.

@chalasr : Thanks for your answer but this is not Symfony App but Frontend App. I have multiple client with behind Load Balancer, the session is shared by redis and it work properly.
My problem is, when i use token (getting from the Symfony App use it bundle), The Symfony is always returning 401 like my first post.
That is the problem... I have no problem with Symfony Behind Proxy

@ad3n are you fixed ? and how ?

@ad3n are you fixed ? and how ?


AMAZING SCRIPT.... took me 15 minutes to have it running.

Now, since I was in such a hurry, i only set up the DNS to target to that particular server from AWS.
I am only using the INBOX per say, since on ThunderBird for Mac the outgoing email is setup through AWS SES.
I am getting some warning on my iPhone about NOT having the proper certificate for the incoming email... Where should I look for to get that info.
Thanks

Check the wiki: https://github.com/tomav/docker-mailserver/wiki/Configure-SSL


Convert testing/test-util.js to typescript

Addresses #1765

Note that StorageProviderBase now has testing methods...


Fix example as per discussion (should be port, not targetPort)

/kind documentation
NONE

/assign @danehans @robscott

having targetPort in the Service actually shows that the port is the ServicePort

I agree with this, but think this might be better to solve/document separately. Since this specific example is for upstream TLS, I think we should keep it as simple as possible.

Thanks!
/lgtm


Single Page Application

can anyone share the idea on how to achieve single page application with Orchard? thanks!

There is nothing specific to Orchard as far as I know. It's the same as MVC. Feel free to reopen the issue if you are more specific issues related to ORchard.


Users should be able to change the directory where VM needs to be created

`We cannot lose sight of what needs to be done and just go with a function in a library.
This needs to be fixed and there probably also needs to be a configuration setting for where this the machines will need to go that the user can modify if the default does not work for them. This is a serious issue.
I've reallocated space from other places thanks to lvm but this is a critical issue that needs to be included in the next release.
Completely unacceptable for the product to not have this flexibility.`  -- from Slack
Where is CC trying to build this new VM?

Added option in settings

Fixed in Master

Created a peer using different Vm storage. tried on all OSs.
Fixed in prod


Pick a publish target screenshot outdated

Using Visual Studio Enterprise 2019 Version 16.5.4. The following relates to section "Publish the project to Azure".
"Pick a publish target" (step 2 at time of writing) now has several choices, none matching the current screenshot on this page. The closest seems to be "Azure App Service Plan", and the next step I'd to click button "Create Profile" (not "Publish").

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 6e88ea08-81ef-2b5a-b9d6-539e85592672
Version Independent ID: f2d8b7b4-906a-d1f5-5201-fc22a7890955
Content: Quickstart: Create your first function in Azure using Visual Studio
Content Source: articles/azure-functions/functions-create-your-first-function-visual-studio.md
Service: azure-functions
GitHub Login: @ggailey777
Microsoft Alias: glenga

Hi @cfframe Thanks for your feedback. We will review and update as appropriate.

@cfframe thanks for reporting the issue. This should now be updated correctly as of VS2019 16.5.5. Please let us know if you are still seeing something different. #please-close


docs(guide/lifecycle-hooks): follow-up to #1654

Dart-side updates following #1654:

Updates to follow style guide
Enabled e2e tests
Fixes to ensure tests pass: in after_view_component.dart and
after_content_component.dart

Changed test over comment field in template to be:
*ngIf="comment.isNotEmpty"

Suites passed:

public/docs/_examples/lifecycle-hooks/dart
public/docs/_examples/lifecycle-hooks/ts

@kwalrath : ready for review.

LGTM aside from wondering whether a null comment will break this.

By design, comment will never be null (if/once non-null types are implemented, the analyzer will be able confirm claims like these :).


refactor(types): improve messages when type checking

Codecov Report
Attention: 68 lines in your changes are missing coverage. Please review.

Comparison is base (c8b54f1) 68.62% compared to head (8a56ee8) 67.48%.

Files
Patch %
Lines

yamlbasics/yamlbasics.go
0.00%
56 Missing :warning:

namespace/namespace.go
52.94%
5 Missing and 3 partials :warning:

patch/deckpatch.go
66.66%
2 Missing and 2 partials :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #146      +/-   ##
==========================================
- Coverage   68.62%   67.48%   -1.15%
==========================================
  Files          22       22
  Lines        3012     3072      +60
==========================================
+ Hits         2067     2073       +6
- Misses        797      851      +54
  Partials      148      148

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.