Visual Shader does not display Specular reflection from light source

Godot version:
3.2.2 stable
OS/device including version:
Windows 10 v2004
Lenovo y710 Cube
Intel i7 6700
Nvidia GTX1080
16GB RAM
Issue description:
Visual Shader will not show a specular reflection caused by directional, omni or spotlight. A Spatial Material with identical properties (Roughness 0.2, Specular 0.5 for example) will show the specular just fine.
I have experimented with roughness maps and assigning values to Albedo/Specular/Roughness/Metalness via scalar constants and uniforms, along with checking the light, world and project settings. Nothing seems to allow specular to appear on a VisualShader material.
Steps to reproduce:

Load the attached project
Load "Main Scene"
The "VisualShader" object DOES NOT show a specular for the directional light
The "Spatial Material" object DOES show a specular for the directional light
Both materials have identical settings for Specular and Roughness
Both materials reflect the default world environment just fine

Minimal reproduction project:
VisualShaderSpecular_Bug.zip

Update:
Blinn, Phong and other specular modes appear to work. SchlickGGX does not show a specular in any diffuse modes, whereas the others will.
It's also worth taking note that the default diffuse mode for VisualShaders is Lambert, whereas the default for PBR workflows and SpatialMaterial is Burley.

It looks like when you set diffuse to burley or specular to schlick_ggx the visual shader does not insert the render mode at all. However, the shader assumes that you will have at least one specular render mode set.
Im guessing something in the logic here is rejecting the first render_mode in the list:
https://github.com/godotengine/godot/blob/6b5102cf907c7c1bae1e866a794bae1cc02d0fae/scene/resources/visual_shader.cpp#L1248-L1273
CC @Chaosus

I've no idea about shader code so I won't be much help on that front, but very happy to test things if anyone takes a shot at a fix.

This looks like its related to this
https://github.com/godotengine/godot/pull/12091

Ok, I take a look

@WickedInsignia

To be honest, I don't see a difference between those two (Windows10/GTX1060), maybe a problem somewhere else?

@Chaosus You need to rotate the scene around so the sun is facing the camera.
The object on the right (SpatialMaterial) will show a specular for the sun. The object on the left (VisualShader) will not.
Something is not initiating the specular in Visual Shaders with GGX.


Library

Hello,
Could you clarify about convert the science library GNU GSL.
In according to flags in main function, we cannot give the big folder with many *.c, *.h.
Have you idea about - how to solve?
Thank you.

That's correct, it only supports the transpiling of one file at the moment. We have not come to a good solution for handling multiple files yet.
See https://github.com/elliotchance/c2go/issues/63. Please comment with your thoughts.


No more download links generated after BOLD downtimes

Note to myself:
When BOLD goes down / has a really bad connection for multiple hours (which happens a lot these days) the session drops the website login and stops generating correct download links. This is not handled at the moment, need to raise an exception if the number of download links does not match the query size, login again and repeat.

Fixed with 1.3.1


The configured game launcher sometimes opens when Windows boot up

Parsec evidently opens a UDP port during startup. Depending on timing, this can cause AutoGame to think there's an active parsec connection and start the game launcher. Pretty annoying.

This should be fixed in the next release with commit 26f830df488aafc5ae98d27c3fa0998b044b0e79.


add archi tech

@ElieOko Please provide us with:

the school official website URL
the school street address, including city and country
an URL of a page on the official website where the school offers an IT-related long-term (>1 year) course
a proof, which shows that the school recognizes the domain you are submitting as an official email domain for the students.

@ElieOko You might miss my previous comment. Please react.

@ElieOko I am sorry, this request remains unanswered for a while. I have to close it without merging. Please reopen and comment if you have an update regarding the aforementioned issue. Thank you for your understanding!


Fixed an issue with high-performance templates

The previous attribute name HIGH_PERFORMANCE caused an AttributeError.
Short description:
More details:
What this PR does / why we need it:
Which issue(s) this PR fixes:
Special notes for reviewer:
Bug:

HIGH_PERFORMANCE it's just the name of the arg, how come it fail something?

HIGH_PERFORMANCE it's just the name of the arg, how come it fail something?

The high-performance templates' label is workload.template.kubevirt.io/highperformance, so the workload attribute's value must be highperformance. On line 66 (in the function generate_template_labels) the uppercase of the workload name is assumed to be the attribute name, at which point its value is appended to the workload label. Thus, with the previous attribute name of HIGH_PERFORMANCE, an AttributeError is thrown any time the highperformance workload is used.

Got it
/lgtm

Note that you need to add a PR to fix any dependant tests code

Note that you need to add a PR to fix any dependant tests code

Noted, will do.


'Press any key to close the terminal' should be visually more distinct

The 'meta' output 'Press any key to close the terminal' should be visually distinct from the process output (see image below). I suggest to use a grey foreground color for the text, try a grey background color, or decorate the text with a prefix/suffix character <Press any...>.

// fyi @dbaeumer

You should be able to change the string that's send to xterm.js to include a background escape sequence like this: \x1b[41mtext\x1b[0m. It needs to use one of the terminal colors though, maybe a black background with white foreground?

It needs to use one of the terminal colors though, maybe a black background with white foreground?

this would work for me, is there a way to make this sensitive to the theme? Below is another example when using a dark theme? Also an empty line to separate the message would help to make the message more distinct.

An empty line is easy, and terminal colors are based on the theme so it should work fine doing that.

@egamma @dbaeumer what do you think? Could also just do bold text and the newline?

I would only do bold text with a newline and not change the background.

@dbaeumer :+1: merging

@Tyriar nice


Add previous URL info to router state

Change router state payload to include previous and current url info; replace feather-route-matcher with url-pattern and a small wrapper.
This is a breaking change.

Coverage decreased (-7.4%) to 89.063% when pulling 6209d64bf93748022f65cb3d8fc130d06e35c072 on feature/current-previous into 2196774e72043faa256fdedfd95127677be204e2 on master.


Design initial pricing

See the conversation in https://github.com/livepeer/ai-worker/issues/20#issuecomment-1948579246 for context.

Tracked internally in https://linear.app/livepeer-ai-spe/issue/LIV-320.


Hide the Right Side App

Can we have an option to hide the right side app menu? The arrow causes confusion with the compose and reminder buttons, and for those of us that don't use that side panel or those apps, can we just have it permanently hidden?

@AbidMHussain Sorry for the delay on this can you send a screenshot of what you are talking about in terms of the arrow? I may take a stab at this when I have some more time.

Closing as no response


Listing Non Consumable as Consumable in the Documentation

Looks like an invalid issue.
as the comment I basically for the consumable product comment link.

@godofredoc if this can be closed?

@stuartmorgan may be the right reviewer for this.

This report seems to misunderstand the location of documentation comments relative to methods.


Add option to actually downlaod all titles from Library

The idea
Add option to download a file with all the titles of the manga in the Library, even better if you can download small cover art ,author,artist,summary, multiple TLs of the title etc
Why this feature should be added to the app ?
It is very important to have a backup of all the manga you are reading because like other website if it shuts down you are fucked.

What I meant is that if I select the "library" option it just prints 10 lines of manga titles and you need to type next for the next 10, I wan t to download just the titles/names of all my manga in my library to a text file or CSV.
If I use the cover command I need to do it for every manga title in my library manually.

What I meant is that if I select the "library" option it just prints 10 lines of manga titles and you need to type next for the next 10, I wan t to download just the titles/names of all my manga in my library to a text file or CSV.

No, it won't happen. But, you can do some hacking using internal API with python if you want to.
Just a reminder that the internal API can be changed at any time without notice.
from mangadex_downloader.network import Net
from mangadex_downloader.iterator import IteratorUserLibraryManga

# Login first
Net.mangadex.login(username="YOUR USERNAME", password="YOUR PASSWORD")

fp = open("manga titles.txt", "w+")
for manga in IteratorUserLibraryManga():
    fp.writelines(manga.title + "\n")
fp.close()

1.I dont really understand why it cant be done. The API limits to 100 manga names/IDs per request cant your script just continue sending new requests till the total number of IDs in the Library of a user is reached ? I have aprox 3500 manga, so it would send 35 requests and put all that in a text file or something.
2. I also saw a limit  variable in some part of your code which equals to "10", isnt that the 10 entries you get when requesting "library?"

I dont really understand why it cant be done. The API limits to 100 manga names/IDs per request cant your script just continue sending new requests till the total number of IDs in the Library of a user is reached ? I have aprox 3500 manga, so it would send 35 requests and put all that in a text file or something.

Command library are using IteratorUserLibraryManga class which i demonstrated how to get all manga from the user library with internal API. So from techincal perspective, the application is capable of retrieving all manga from the user library. And yes it respect API limits, so it would send multiple requests if the user have tons of manga in the library.
However, i don't understand when you say "just to download titles only", not to mention the other optional informations such as small cover art, author, artist, summary, multiple TLs of the title, etc. It's like download a manga in .cbz file and then remove chapters and images and you would left with ComicInfo.xml and the manga cover. And you also mention your purpose is to backup all manga from your library, which is doesn't make sense at all.
I'm not trying to be rude here, but can you explain more details why you want this feature ?
If you want to use this feature for analysis things (like this https://github.com/mansuf/mangadex-downloader/issues/60) because you say you wanna save manga titles to CSV file, i can create a separate command just for that.

I also saw a limit  variable in some part of your code which equals to "10", isnt that the 10 entries you get when requesting "library" ? Cant that also be increased or set by the user(though that is not very important)?

The limit variable is for per page in library command, so when you using library command, you will be displayed first 10 manga that you have in the library, then if you want to see the next one, you could just type next and then it will display next 10 manga in the library.

What I suggested was to download JUST titles/name of the manga ,meaning only the text of the name that already appears in CMD, if you use the library command, in groups of 10.
The optional information, which I dont really care for but is nice to have, are what you and I already mentioned, but together with the titles(name/text) of each manga would make a more rich(cover,tags) backup of my library index.
And by index I mean just a list of strings for every manga title/name.
Basically the same thing that appears when I click on library in mangadex, but it has all 3500 titles instead of 100. Sorry for the misunderstanding.My original post wasnt clear enough.

If you want to use this feature for analysis things (like this https://github.com/mansuf/mangadex-downloader/issues/60) because you say you wanna save manga titles to CSV file, i can create a separate command just for that.

Yes, please.

The limit variable is for per page in library command, so when you using library command, you will be displayed first 10 manga that you have in the library, then if you want to see the next one, you could just type next and then it will display next 10 manga in the library.

Yes ,I understood that.

Alright, i will add this on my to-do list in v3.0.0 PR .
Keep in mind, i don't have ETA when this features is implemented, because i have to do other things (documentations, etc).

it works , but its only for individual manga urls. It was supposed to iterate over all the manga titles in library and save them all to a .csv.
**Basically the same thing that appears when I click on library in mangadex, but it has all 3500 titles instead of 100. Sorry for the misunderstanding.My original post wasnt clear enough.**

You just have to modify --manga-info-filepath to somewhere else if you want it one place. By default it placed each manga folders

Modifying the filepath doesnt change the fact that it only works for for one manga URL that I provide, Didnt we agree it was supposed to download all the info of each title in library. I tried using the library command but it doesnt work with create-info. Like the quote I posted earlier.

It works for library command and all other commands such as list, followed-list, random, etc
python -m mangadex_downloader "library" --login --login-username "REDACTED" --login-password "REDACTED" --create-manga-info --manga-info-filepath "./manga_info.{manga_info_format}" --input-pos "*" --path "G:\Test\Manga\DownloadTest"

Output:
manga_info.csv

I run your command and it start downloading the covers and creates a manga_info.csv but it fails on the second or third manga with the error :
Traceback (most recent call last):   File "E:\python\python310\lib\site-packages\mangadex_downloader\cli\__init__.py", line 87, in _main     download(args)   File "E:\python\python310\lib\site-packages\mangadex_downloader\cli\download.py", line 34, in download     url(args, args.type)   File "E:\python\python310\lib\site-packages\mangadex_downloader\cli\url.py", line 187, in __call__     self.func(self.id, args)   File "E:\python\python310\lib\site-packages\mangadex_downloader\cli\url.py", line 105, in download_manga     dl_manga(*args)   File "E:\python\python310\lib\site-packages\mangadex_downloader\main.py", line 200, in download     download_manga(manga, formatted_path)   File "E:\python\python310\lib\site-packages\mangadex_downloader\main.py", line 133, in download_manga     create_manga_info(path, m, replace)   File "E:\python\python310\lib\site-packages\mangadex_downloader\utils.py", line 363, in create_manga_info     manga_info.write()   File "E:\python\python310\lib\site-packages\mangadex_downloader\manga.py", line 320, in write     self.write_to_csv()   File "E:\python\python310\lib\site-packages\mangadex_downloader\manga.py", line 378, in write_to_csv     writer.writerow(row)   File "E:\python\python310\lib\csv.py", line 154, in writerow     return self.writer.writerow(self._dict_to_list(rowdict)) UnicodeEncodeError: 'cp932' codec can't encode character '\u2014' in position 104: illegal multibyte sequence

Fixed in https://github.com/mansuf/mangadex-downloader/commit/a0fe2c5fb8b08153ff9f034b554dce85e5eb8897
Installtion with Git & pip
pip uninstall mangadex-downloader
pip install -U git+https://github.com/mansuf/mangadex-downloader.git@a0fe2c5fb8b08153ff9f034b554dce85e5eb8897


Add destination.expirationTime to Query Job options

Writing query results to a destination table via Query Job is great; having to make a separate call to set the expiration time is not ideal.
Query Job options accepts a Table resource for the destination, would it be possible to add expirationTime to said resource?

Unfortunately the job resource in the API do es not accept an expiration time. I recommend filing an issue for the API at https://issuetracker.google.com
You may also be interested in the default expiration property on the BigQuery dataset resource.

I'm going to close this, but if for whatever reason the API team does not want to move forward with a feature like this, let us know and maybe we can look into adding it as a client feature.


Update soroban tutorials to use soroban contract init

Update the Soroban Get Started tutorials to use soroban contract init to initialize a new project
Documented here: https://github.com/stellar/soroban-tools/blob/main/docs/soroban-cli-full-docs.md#soroban-contract-init

Done


EDU-504 table plugin additional features

Closes https://educandu.atlassian.net/browse/EDU-504

We will add one more feature, closing this PR.


README: add a requirements section

This should make it a bit easier to get things up and running on a
clean machine (or docker-image).
This PR contains:

[x] Documentation

@Tapped: You might be interested in this, as #304 probably changes the required Mono-version.

By the way, this was inspired by a discussion with @mdavidsen, when setting up new Docker-based TeamCity agents, as well as recently setting up a new MacBook. I isolated the Windows requirements myself, using this Docker-container on Windows. For macOs, I just documented what I had to install. I might set up a macOS Docker-container for testing requirements in the future as well, as that turned out to be a useful hack.

@yupferris: If you have some concrete suggestions, sure. I think as-is the list is useful, and this is geared towards developers. But I guess I could add a line saying "The following software is required to be installed to use uno / fuselibs:" or something like that. I guess we could also say that it requires Windows or macOS itself also? :P

Haha fair, yeah, this is fine as-is I think.

Just to be clear: That smiley was really just meant for the last part, I wasn't trying to make fun of your feedback. I'm fine with adding a sentence, and I do agree that it looks a bit bare as-is.

I guess I could also consolidate the VCRedist 2010-lines into one line, and give separate x86 / x64 links instead.
Something like:

VCRedist 2010: x86, x64
VCRedist 2013

I guess that would make the list a bit less "in your face".


Watch tower

Creates a background task on iOS that runs every few days, and performs a simple watch tower operation.
Fixes issue #134
Requires https://github.com/ACINQ/lightning-kmp/pull/269

We'll have to make sure that the ~30 seconds window allocated by iOS to background jobs is long enough to make this watch tower reliable in real conditions.

If that's an issue, then we can always make this job do less work, by only checking if any of the funding txs has been spent (and not react upon it, just display a notification to the user. The closing would be done when the user manually start the app).


ktls feature

ktls have 30% speed improvement. possible to implement this?

you can new a issue on https://github.com/cloudwego/hertz


Show the comparaison between last ranking

Feature to add in the future

WIP

adding comparaison to last ranking
adding new custom emojis to show the place switch
be able to split the message if it is too long

Example:


EAGLE-543 Fix eagle server default config, fix eagle server deve dependency

JIRA
https://issues.apache.org/jira/browse/EAGLE-543
Changes

Add loaded application providers brief info log.
Fix ApplicationProviderClass bug
Remove duplicated dependency
Add eagle server request log config

Could you add more description about how you are fixing the issue?

@hsaputra thanks for reviewing, and added more description about the changes.


change detection is not working with lazy loading module

we are using angular 8 with single spa. we have implemented lazy loading and notice an issue when lazy loading module have multiple child routes and you navigate from one child route to another.
we have created a sample app using the microfronend demo app. https://github.com/joeldenning/coexisting-angular-microfrontends
Updated Repo (Added lazy loading module): https://gitlab.com/Hemendra.patel/coexisting-angular-microfrontends
Step 1: click on link-app1
step 2: click on 'Click To Toggle' button
Angular will update the 'test' property value
Step 3: click on 'Navigation to next route' button
it will redirect to widgetDetails
Step 4: click on 'Back' back button -
step 5 : click on 'Click To Toggle' button  again - now angular change detection will not working.
we can add  ChangeDetectorRef to manually trigger the change detection but we need to add it on each client event to get the update.

Duplicate of https://github.com/single-spa/single-spa-angular/issues/94. I'm closing this in favor of that issue - feel free to comment there.


Negative active connections during draining

Is this the right place to submit this?

[X] This is not a security vulnerability or a crashing bug
[X] This is not a question about how to use Istio

Bug Description
Hi, once istio-proxy is starting to drain connection before shutdown it'll hang until the timeout is reached with negative amount of connections reported:
{"level":"warn","time":"2024-02-06T17:09:20.121405Z","msg":"Envoy proxy is NOT ready: server is not live, current state is: DRAINING"}
"level":"info","time":"2024-02-06T17:09:20.552323Z","msg":"There are still -1 active connections"}

I'd expect Istio to shutdown whenever active connections <= 0.
Version
istio 1.13.4

Additional Information
No response

1.13.1 is EOL. Please upgrade to latest version. This has been fixed already


Update default server config

The default server config is most likely out of date at this point, and needs to be updated.

Looks like the config hasn't changed.


added syslog and IPv6 checking to ToDSCPCheck.pl

traffic_ops/app/bin/checks/IPv6.pm - new file, cannot be installed
by CPAN.
traffic_ops/app/bin/checks/ToDSCPCheck.pl

added IPv6 checking
incremented version
removed $hostn
changed the way autoflush is handled
added $cms_int var now required on the command line in jconf
removed $match because it was not being used
added $chck_lng_nm for syslog messages
I was going to put in to have it fail if the ‘checkPath’ wasn’t
defined but, opted not to. Left the code in but commented.
changed curl to use the -H option and the url now uses the IP
address
changed get_dscp to also return -1 so that if we can’t connect to
the server we will know.
added trim functions.

I should have mentioned that the IPv6.pm file needs to go in /opt/traffic_ops/lib/perl5/NetPacket/. There isn't a lib dir off traffic_ops until the install so I added to this dir.


Use case: User Friendly Keyword Searching

Title (Goal)
Keyword searching

Primary Actor
User

Scope
search

Story
I want to search the site using keywords and have the results find my search term anywhere in the metadata.

Source: ICG Report:

It is unclear if all fields are keyword searchable, which is something that we would like all fields to be. Where do we check to see if this is the case?

Which fields?  Solr fields or node/media/taxonomy fields?


Fix repository link typo in package.json

Some links in package.json seem broken

Thanks @medikoo !

:tada: This PR is included in version 1.12.3 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Do not cache cache-mgr itself

This is a follow-up to #4186 to bypass caching for cache-mgr.js
It is required so the registrant (cache-mgr.js) can actually register the updated Arcs Cache Manger (cache-mgr-sw.js).

@mmandlis Thanks for the review for #4186, this file change should have been together with #4186 but I missed it, sorry!

@csilvestrini I merged the PR even with a cross for copybara-feedback.
There is only single file change in this PR but the cl copybara-worker created includes 25 files changes (dunno why). The feedback error is not caused by this PR.

@csilvestrini I merged the PR even with a cross for copybara-feedback.
There is only single file change in this PR but the cl copybara-worker created includes 25 files changes (dunno why). The feedback error is not caused by this PR.

Thanks for checking. It's broken at HEAD, it wasn't your PR.


The speed limit becomes invisible when current speed is over 100km/s.

Not that important considering max speed limit in ATS and ETS2 is lower than 120.

Dunno how, but fixed.


Bake some commonly-used Spark options into SparkCommandLineProgram

These are options that we've found it necessary to use in order to
get hellbender tools to play nice with Spark.

For @lbergelson to review

:+1: Good magic.  Merge when tests pass.


Add a label on out

Hi again!
Would you accept a patch to add a list of labels specified in params under a put?  My use case is that my workflow needs to:

Do a build
Wait for a human to approve some output
Make some changes and merge the PR

I am accomplishing this by having two separate resources (since "wait for a human" isn't very cleanly supported in concourse).  One resource picks up on new PRs, and the other picks up on PRs which have had both the build and the human approval done.
I would like to be able to add a label at the end of the build so that people scrolling through the pull requests will know at a glance where they are in our somewhat-complex build process, and so that I can more easily filter out things which haven't been through the build from the resource which implements step 3.

How would the label be set? For example, would it be a file reference or a static value in a pipeline YAML.
It seems the label is just for clarification of a status. You are able to use search on pull requests for the status.

I'd prefer it as a static value, but I'd be willing to do file reference if you think that might be more broadly useful.
I agree, the label is useful to me as a clarification of status, because my second resource can filter on label, but can't filter on status.

I’d accept a pr on this.

I have merged your code, however, I am still having trouble with the last step of the concourse pipeline since taking it over. I intend to close this issue once I resolved that.


config.toml - modification of links in [[params.mainMenu]]

Excellent work - thank you very much.
I created a Docker container of the rendered files in the public folder according to this description in order to deploy the site to a Google Cloud Run instance. However, once the container is started, the links to the pages do not work.
After modifying the [[params.mainMenu]] links from link = "posts" to link = "/posts/" for example, the container is running perfectly. One note: GCR was not able to handle the video background on the main page.

Thank you for the information! I'm so glad you like the theme!


Clarify that user_data is neither set nor cleared

What do you think of being a little bit more explicit here?

Yep that looks good to me, that's a better way to say it.


PWA-402 fix is orderable

Pull Request Test Coverage Report for Build 687

2 of 5 (40.0%)  changed or added relevant lines in 3 files are covered.
42 unchanged lines in 8 files lost coverage.
Overall coverage decreased (-1.4%) to 32.121%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

pages/Product/components/AddToCartBar/components/AddToCartButton/index.jsx
0
1
0.0%

pages/Product/components/AddToCartBar/index.jsx
0
2
0.0%

Files with Coverage Reduction
New Missed Lines
%

pages/Product/components/AddToCartBar/components/AddMoreButton/index.jsx
1
66.67%

pages/Product/components/AddToCartBar/components/AddToCartButton/connector.js
1
50.0%

pages/Product/components/AddToCartBar/connector.js
1
66.67%

pages/Product/components/AddToCartBar/selectors.js
1
66.67%

pages/Product/components/AddToCartBar/components/CartItemsCount/components/Count/index.jsx
7
0.0%

pages/Product/components/AddToCartBar/index.jsx
8
0.0%

pages/Product/components/AddToCartBar/components/CartItemsCount/index.jsx
11
0.0%

pages/Product/components/AddToCartBar/components/AddToCartButton/index.jsx
12
0.0%

Totals

Change from base Build 686:
-1.4%

Covered Lines:
1196

Relevant Lines:
3583

💛  - Coveralls


respect a URL state parameter that specifies the initial global time window

This is part 1 of #99

Solved by #102


Reusable containers

Another implementation examples

https://node.testcontainers.org/features/containers/#reusing-a-container
https://java.testcontainers.org/features/reuse/

Should not be too difficult

Would be awful nice if someone wanted to make a stab at this. Requires some knowledge about docker.


Meta: Run pre-commit tests on Travis-CI

At present, we only run static_tests.sh script on Travis CI but it is
fairly straightforward to run gen_doc.sh and autofix.sh scripts as well.
This change adds those scripts to Travis build script so it should now
be able to detect fails from those scripts as well.
Test plan:
$ ./precommit.sh
Ensure that the builds pass on Travis CI with these set of changes on
current codebase.
Ensure that the builds fail if there's a missing doc update or autofix
issues after applying this patch.

These scripts won't return non-zero if they make some changes. In precommit.sh we use git diff --exit-code to detect subsequent changes and generate an error.
Maybe we should create a travis.sh that does this, ahead of trying to get travis to run precommit.sh successfully.

@aevri This is ready for review now. As we discussed earlier, I've added an option -e to exclude certain tests to precommit.sh and have excluded unit tests and smoke tests on travis.

@aevri Updated the PR to address your concerns (which are now lost btw since they were on specific commits).

Landed at 7dd979b, thanks!


Allow exclusion of certain properties

Thanks for the plugin, great job.
I ran into an issue where I was using certain custom properties during runtime. As they are technically unused during build time, the plugin went ahead and removed them (correctly so, given the current capabilities).
I'd love to have the option to exclude certain files and/or properties.

Great suggestion. I was just thinking I know I had written something just like this and where was it so I was poking around and I put it instead in a set of stylelint plugins that we'll be releasing soon from the @spectrum-tools namespace: stylelint-no-unused-custom-properties and stylelint-no-unknown-custom-properties.  Both plugins will support ignoreList and allowList properties. Shouldn't be too bad to work those into this plugin but if you wanted to tackle that, PRs are appreciated.
I'd love to approach it like:

allowList, type: string[], if this is set, only properties defined in this array will be evaluated.
ignoreList, type: string[], if this is set, any properties defined in this array will not be removed if found unused.

What do you think? Do those properties and definitions make sense?


CheveretoIntegration 2.0.7 issue

Install/upgrade from archive are not supported CheveretoIntegration 2.0.7 ZIP files.
Oops! We ran into some problems.
Could not process -ITM-CheveretoIntegration_2.0.7.zip: File does not appear to be a valid add-on archive as expected.

Re-Download and try again. The ZIP was corrupt.


can not find "workers_number option"

Hi,
I'm on Youtube-dlG v0.4, windows portable.
Could anybody please tell me where I could find the "workers_number option" for number of simultaneous downloads?
The following answer is in 2015, now there's no hint of "settings file" in options.

Currently you can change the number of simultaneous downloads by editing the workers_number option under your settings file. To find the path of your settings file start youtube-dl-gui and hit the options button. At the bottom of the General tab you should see the Settings File label which shows the absolute path to your settings file.

%appdata%\youtube-dlg\

%appdata%\youtube-dlg\
open settings.json

Thanks! Right on spot.

there's a current request to make this setting available in the options setting within the program
maybe you should ask for request in there as well.
Hope the programmer can implement it since it makes it more user friendly to change the number to what we want when we need to.
https://github.com/MrS0m30n3/youtube-dl-gui/issues/343


[SPARK-44776][CONNECT] Add ProducedRowCount to SparkListenerConnectOperationFinished

What changes were proposed in this pull request?
Add ProducedRowCount field to SparkListenerConnectOperationFinished
Why are the changes needed?
Needed for showing number of rows getting produced
Does this PR introduce any user-facing change?
No
How was this patch tested?
Added Unit test

Merged to master and branch-3.5.


Update packages and Terraform syntax

A lot has changed since 2017 when this project was released.
Updated to current (January 2020) npm packages
Simplified Babel configuration
Updated Terraform scripts to current standards

@medington thanks for refreshing this 👍

Happy to do it @cludden ! Thank you for contributing this project. It proved most helpful and educational.


Multiple disks label

I have 10 external disks attached and the agent has picked them all up, but there is no way to label them, so I just have a bunch of sbX drives that are difficult to identify. I'm wondering if there is an easy way to label them somehow, even if its an environment variable with a bunch of key/value pairs or something

Hello, we tried to solve the issue.
This is what we did:
This change adds support for custom filesystem labels using environment variables. It modifies the agent to read labels from the FILESYSTEM_LABELS environment variable and updates the frontend to display these labels.
You can review changes in this commit: https://github.com/mark-addams001881/henrygd-beszel-350/commit/90a70a95c3b6feb0fcdbba579b23b93ce6f79eea.

[!CAUTION]
Disclaimer: The concept of solution was created by AI and you should never copy paste this code before you check the correctness of generated code. Solution might not be complete, you should use this code as an inspiration only.

Latta AI seeks to solve problems in open source projects as part of its mission to support developers around the world. Learn more about our mission at https://latta.ai/ourmission . If you no longer want Latta AI to attempt solving issues on your repository, you can block this account.

Let's move conversation about this to #294 since it's a similar issue.
I think the best option is to use label values straight from the disk if available. Maybe add a manual env var mapping if you don't want to use disk labels for whatever reason.
If you have time, can you run the agent with LOG_LEVEL=debug and check the line containing DEBUG Disk I/O diskstats that's logged on startup?
It should show info for your disks including labels. I just want to make sure those label values come through properly.


useAsyncData break pages if multiple navigation during page change

Environment

Operating System: Windows_NT
Node Version:     v18.17.0
Nuxt Version:     3.6.5
Nitro Version:    2.5.2
Package Manager<EMAIL_ADDRESS>Builder:          vite
User Config:      -
Runtime Modules:  -
Build Modules:    -

Reproduction
https://stackblitz.com/edit/nuxt-starter-suvj1g?file=pages%2Fasyncdata.vue,pages%2Findex.vue,app.vue

click 10 time within a second on the link
don't get navigated and the page breaks
open your console
see an error

Describe the bug
when clicking a lot of time on a link with a navigation to a page which requires a long asyncData, nuxt breaks with an vue error when navigating and mounting the new page
Additional context
I think this issue can happens a lot on slow pages with users double/triple clicking on a nav link but not on pages that has a fast useAsyncData. It can also depend on the user network speed
Logs
No response

Let's track in https://github.com/nuxt/nuxt/issues/13309.

@danielroe This bug was introduced in v3.6.2. v3.6.1 with the same Vue version (v3.3.4) doesn't have this bug. It looks like it's related to Nuxt.

Yes, it did start then, but that's likely because we fixed an upstream bug, and began awaiting suspense resolution properly.
The root cause is upstream.

Yes, it did start then, but that's likely because we fixed an upstream bug, and began awaiting suspense resolution properly.
The root cause is upstream, as far as I can tell.
We're currently investigating a possible solution in Vue itself.

Perfect!!!

Has someone found a workaround for this issue?

Same issue

Same here

Same issue

Can you try disabling transitions?
You can see how to do that here:
https://nuxt.com/docs/getting-started/transitions#disable-transitions
This is possibly fixed by https://github.com/vuejs/core/pull/9309, but disabling the transitions should lead to the same result.

Can you try disabling transitions?
You can see how to do that here: https://nuxt.com/docs/getting-started/transitions#disable-transitions
This is possibly fixed by vuejs/core#9309, but disabling the transitions should lead to the same result.

Hello, I have tried but got the same result.
In my case I am using  inside the layout to load pages.
https://nuxt.com/docs/migration/pages-and-layouts
Thanks!

@Josepdal  It doesn't matter if usefetch or useasyncdata, the problem will be solved if the lazy feature is used. Do you know this?

@Josepdal It doesn't matter if usefetch or useasyncdata, the problem will be solved if the lazy feature is used. Do you know this?

Yes thanks, but I don't want to handle a pending state. I prefer getting the data before hydration.

@Josepdal It doesn't matter if usefetch or useasyncdata, the problem will be solved if the lazy feature is used. Do you know this?

Yes thanks, but I don't want to handle a pending state. I prefer getting the data before hydration.

I have the same problem and I couldn't find a solution.

Running into same error here o/ I could event reproduce it on https://nuxt.com if you navigate to fast on showcase or blog page from the navbar (-> be sure to don't have cachedData, you can downgrade you connexion with your browser to handle the error more simply).

This is still a major issue even with the latest release of Vue core ^3.3.10. Is this on the pipeline to be addressed?

@rylanharper The problem continues in vue 3.3.10, I did the tests.

I'm trying to explore the commits between v2.6.1 and v2.6.2 and find that since this commit, this bug started appearing.

I have the same problem, hope it can be fixed soon

this is now resolved in vue v3.4. 🥳


Can this method find out camera position in the situation when I took pictures going upstairs?

Thanks for your OpenSfM method ,i can find camera position in most situations indoors and outdoors,but there is a situation that when i took photos going upstairs,then use this method to find camera position,but it is always wrong,i try to find the reason but have not  had a result yet,can you give me some advice?Thank you very much!

What is the wrong with the result you get? is the reconstruction empty, or deformed, or tilted? Could you share the dataset?
Going upstairs is not a problem. The only expected inconvenience is that the model might end up tilted since the final alignment step assumes you move on the ground to guess the gravity direction.
If you get empty or deformed reconstructions, the most likely reason is that matching is not finding enough correspondences between shots.

No answer for a while, closing.


BUG FIX: Zero Valued Arrays Hash Incorrectly

Motivation and Context
Why is this change required? What problem does it solve?:
Upon adding a small set of property based tests, it was discovered that zero valued arrays in variable shaped arraysets could potentially hash to the same value if two arrays had the same size and/or itemsize but different shapes
Description
Describe your changes in detail:
>>> aset = co.arraysets.init_arrayset('aset', shape=(10, 10, 10, 10), dtype=np.float32, variable_shape=True)

>>> a = np.zeros(shape=(1, 1, 5, 1), dtype=np.float32)
>>> a.shape
(1, 1, 5, 1)
>>> b = np.zeros(shape=(1, 1, 1, 5), dtype=np.float32)
>>> b.shape
(1, 1, 1, 5)

>>> aset['a'] = a
>>> aset['b'] = b

>>> aset['a'].shape
(1, 1, 5, 1)
>>> aset['b'].shape
(1, 1, 5, 1)  # THIS IS INCORRECT!

This happens because
>>> a = np.zeros(shape=(1, 1, 5, 1), dtype=np.float32)
>>> b = np.zeros(shape=(1, 1, 1, 5), dtype=np.float32)
>>> a.tobytes() == b.tobytes()
True

>>> a_float = np.zeros(shape=(1, 1, 5, 1), dtype=np.float32)
>>> b_int = np.zeros(shape=(1, 1, 5, 1), dtype=np.int32)
>>> a_float.tobytes() == b_int.tobytes()
True

To fix this we now take the hash of the array bytes, with a binary struct composed of the ints making up each dimension shape and the numeric typecode of the array's dtype.
hasher = hashlib.blake2b(data, digest_size=20)
hasher.update(struct.pack(f'<{len(data.shape)}QB', *data.shape, data.dtype.num))
full_hash = hasher.hexdigest()

This means that any difference in type or shape (even if bytes are technically identical) will result in storage of that new array on disk and (more importantly) storage of the digest record (with corresponding variance in result spec) in the hashenv db.
In addition to including the hypothesis test which found this in the test suite, manual tests have been added which assert this result does not happen.
This is a BREAKING CHANGE for all future versions of hangar, data hashs will no longer be the same However, this is OK since that was going to happen in 0.4 anyways.
Types of changes
What types of changes does your code introduce? Put an x in all the boxes that apply:

[ ] Documentation update
[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[x] Breaking change (fix or feature that would cause existing functionality to change)

Is this PR ready for review, or a work in progress?

[x] Ready for review
[ ] Work in progress

How Has This Been Tested?
Put an x in the boxes that apply:

[ ] Current tests cover modifications made
[x] New tests have been added to the test suite
[ ] Modifications were made to existing tests to support these changes
[ ] Tests may be needed, but they are not included when the PR was proposed
[ ] I don't know. Help!

Checklist:

[x] My code follows the code style of this project.
[x] My change requires a change to the documentation.
[x] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[x] I have signed (or will sign when prompted) the tensorwork CLA.
[x] I have added tests to cover my changes.
[x] All new and existing tests passed.

@hhsecond please review asap.

Thanks for the quick review @lantiga. I'll hold off on merging this until we get a chance to talk this over in our weekly meeting.

Another solution would be to content-address using the hash computed from the bytes only, but verify that something has changed through the newer hash. This would save us from storing again after a change in shape,

I think theres some confusion on one of our ends, because this doesn't make much sense to me. Not sure if i'm missing your point, or if something about the actual implementation is getting lost.

It would be good to know how performance is impacted by this change - very likely negligibly.

The only time this could possibly affect performance are in two sections:

adding data -> when the full (cryptographic) digest of an input sample is actually calculated and stored.
transferring data between a client/server -> The cryptographic hash is calculated (once again) so that the receiver assures the transfered data is what the sender said it was going to send (god, that's a horrible way to phrase that sentence, sorry!)

When reading data, we don't recompute the cryptographic digest on every read (that would be far too inefficient). We use xxHash as an extremely fast, well distributed, vetted, but non-cryptographic method to validate that bytes out == bytes expected.
I'll run the benchmark suite (still need to propose that as a PR in master) but I'm expecting nearly no measurable change whatsoever. packing a tuple of python ints which is at most 33 elements long (the maximum number of dimensions we handle, plus the dtype num) - and which in the vast majority of cases will be less than 5 items long - into a C-struct is extremely efficient.
Your continual reminders about performance patterns and memory consumption has not gone un-noticed. It's seriously influenced the ways I develop for Hangar, and we're all better because of it! Thanks for brining up the concern though, I'll post the benchmarks when I have them run here.

adding data -> when the full (cryptographic) digest of an input sample is actually calculated and stored.
transferring data between a client/server -> The cryptographic hash is calculated (once again) so that the receiver assures the transfered data is what the sender said it was going to send (god, that's a horrible way to phrase that sentence, sorry!)

I never explained why these are areas where even if we take a hit, it's inconsequential...
For point (1), I've spent a serious amount of time profiling and tracing execution along this codepath. The vast majority of time spent in the add data method (well over 95%) is in compressing data and flushing it to disk. The other 5% is nearly completly spent calculating the digest of the array bytes. As arrays increase in size, this can go to something more like a 90%-10% split, but the execution is still dominated by the backend storage IO/compression. Since the hasher.update() call is an incremental update to the digest, and we are passing in very small amounts of data, this should be nearly an unmeasurable addition.
For point (2), the same logic as in point(1) applies (since you still need to save the data to disk after calculating the digest, but execution is absolutely dominated by network transfer speeds. Once the data is transferred to/from the client/server, the amount of time spent writing to disk is laughable compared to how long it took to transfer over a network.

And to asuade your fears, here is proof from the actual benchmark suite we have:
[:~ … hangar-benchmarks-local] [hangar-dev] 1 $ asv compare master property-based-testing

All benchmarks:

       before           after         ratio
     [8d9515bc]       [a0a14620]
     <master>         <property-based-testing>
            57.7M            57.5M     1.00  arrayset_sample_reads.HDF5_00.peakmem_read_float32_2000_samples
            55.6M            55.5M     1.00  arrayset_sample_reads.HDF5_00.peakmem_read_uint16_2000_samples
          2.09±0s          2.15±0s     1.03  arrayset_sample_reads.HDF5_00.time_read_float32_2000_samples
          1.53±0s          1.52±0s     1.00  arrayset_sample_reads.HDF5_00.time_read_uint16_2000_samples
            1.55G            1.55G     1.00  arrayset_sample_reads.NUMPY_10.peakmem_read_float32_2000_samples
             803M             803M     1.00  arrayset_sample_reads.NUMPY_10.peakmem_read_uint16_2000_samples
          926±0ms          926±0ms     1.00  arrayset_sample_reads.NUMPY_10.time_read_float32_2000_samples
          474±0ms          481±0ms     1.02  arrayset_sample_reads.NUMPY_10.time_read_uint16_2000_samples
          10.7±0s          10.5±0s     0.98  arrayset_sample_writes.HDF5_00.time_add_float32_samples(2000)
          6.26±0s          6.11±0s     0.98  arrayset_sample_writes.HDF5_00.time_add_uint16_samples(2000)
             165M             165M     1.00  arrayset_sample_writes.HDF5_00.track_repo_size_float32_samples(2000)
             111M             111M     1.00  arrayset_sample_writes.HDF5_00.track_repo_size_uint16_samples(2000)
          4.03±0s          4.06±0s     1.01  arrayset_sample_writes.NUMPY_10.time_add_float32_samples(2000)
          2.10±0s          2.08±0s     0.99  arrayset_sample_writes.NUMPY_10.time_add_uint16_samples(2000)
             1.5G             1.5G     1.00  arrayset_sample_writes.NUMPY_10.track_repo_size_float32_samples(2000)
             751M             751M     1.00  arrayset_sample_writes.NUMPY_10.track_repo_size_uint16_samples(2000)
         366±10ms          370±6ms     1.01  package.TimeImport.time_import

Any observed changes are well within a margin of error between test runs.


fix(anvil): calculate trace address acording to the spec

Motivation
Ref https://github.com/foundry-rs/foundry/issues/2656
Fixes traceAddress calculation. this will add the index of the call in the parent node instead of the parent's depth
@naddison36 mind giving this another try, the from issue should be fixed as well

Solution

Thanks for the quick turnaround @mattsse
I'm new to Rust so I may have compiled and run your branch incorrectly, but when I retested I got this error
trace_transaction
thread 'tokio-runtime-worker' panicked at 'child exists in parent', anvil/core/src/eth/transaction/mod.rs:1076:18
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
[1]    83664 abort      /Users/nicholasaddison/.cargo/bin/anvil --fork-block-number 15291050 -f

After setting RUST_BACKTRACE=full, I get
trace_transaction
thread 'tokio-runtime-worker' panicked at 'child exists in parent', anvil/core/src/eth/transaction/mod.rs:1076:18
stack backtrace:
   0:        0x103345625 - __mh_execute_header
   1:        0x1030d805b - __mh_execute_header
   2:        0x103322bf8 - __mh_execute_header
   3:        0x10334894d - __mh_execute_header
   4:        0x1033496f0 - __mh_execute_header
   5:        0x103349274 - __mh_execute_header
   6:        0x1033491e9 - __mh_execute_header
   7:        0x1033491a5 - __mh_execute_header
   8:        0x1033c4d93 - __mh_execute_header
   9:        0x1030db17b - __mh_execute_header
  10:        0x1030db12c - __mh_execute_header
  11:        0x1033c4f09 - __mh_execute_header
  12:        0x102fb5048 - __mh_execute_header
  13:        0x102fb3dad - __mh_execute_header
  14:        0x102e560ca - __mh_execute_header
  15:        0x102e3e687 - __mh_execute_header
  16:        0x10303e5b7 - __mh_execute_header
  17:        0x10302ff4a - __mh_execute_header
  18:        0x10302d1ef - __mh_execute_header
  19:        0x10306d8ae - __mh_execute_header
  20:        0x103069df4 - __mh_execute_header
  21:        0x102dd5067 - __mh_execute_header
  22:        0x102dd4d97 - __mh_execute_header
  23:        0x102dd4c27 - __mh_execute_header
  24:        0x102dd876b - __mh_execute_header
  25:        0x102dd5067 - __mh_execute_header
  26:        0x102dd4d97 - __mh_execute_header
  27:        0x102dd4c27 - __mh_execute_header
  28:        0x102dd876b - __mh_execute_header
  29:        0x102dd5067 - __mh_execute_header
  30:        0x102dd4d97 - __mh_execute_header
  31:        0x102dda574 - __mh_execute_header
  32:        0x102df77a5 - __mh_execute_header
  33:        0x102dd5067 - __mh_execute_header
  34:        0x102dd4d97 - __mh_execute_header
  35:        0x102df8ee1 - __mh_execute_header
  36:        0x102df9efa - __mh_execute_header
  37:        0x102dd5067 - __mh_execute_header
  38:        0x102db9969 - __mh_execute_header
  39:        0x102d8115f - __mh_execute_header
  40:        0x102db3a82 - __mh_execute_header
  41:        0x102db25a2 - __mh_execute_header
  42:        0x103360978 - __mh_execute_header
  43:        0x10335f9b4 - __mh_execute_header
  44:        0x103128dd8 - __mh_execute_header
  45:        0x103364727 - __mh_execute_header
  46:        0x1033658f4 - __mh_execute_header
  47:        0x10334a389 - __mh_execute_header
  48:     0x7ff81a22d4e1 - __pthread_start
[1]    83811 abort      /Users/nicholasaddison/.cargo/bin/anvil --fork-block-number 15291050 -f

nope that's on me
will turn your example into a proper test and debug this

BTW, the from address in the first call is now correct.
The from in the second delegatecall is incorrect, though. I noticed this yesterday but wanted to retest with https://github.com/foundry-rs/foundry/pull/2644 before raised it.
When I test against Nethermind, the action.from is the contract that is sending the delegatecall and not the sender of the transaction. That is, the action.to address of the first trace should be the action.from address of the second trace for tx 0x3255cce7312e9c4470e1a1883be13718e971f6faafb96199b8bd75e5b7c39e3a.
You can also check out the Parity trace on Etherscan https://etherscan.io/vmtrace?txhash=0x3255cce7312e9c4470e1a1883be13718e971f6faafb96199b8bd75e5b7c39e3a&type=parity#raw
The first 2 traces from Anvil
[
        {
            "action": {
                "callType": "call",
                "from": "0x2e4777139254ff76db957e284b186a4507ff8c67",
                "gas": "0x1ea7b",
                "input": "0x43bcfab60000000000000000000000006b175474e89094c44da98b954eedeac495271d0f0000000000000000000000000000000000000000000000e0bd811c8769a824b00000000000000000000000000000000000000000000000e0ae9925047d8440b60000000000000000000000002e4777139254ff76db957e284b186a4507ff8c67",
                "to": "0xe2f2a5c287993345a840db3b0845fbc70f5935a5",
                "value": "0x0"
            },
            "blockHash": "0x57fc41478973665020c3da3e26dc0cad4e975bff441a24674e4f89c273046b54",
            "blockNumber": 15291051,
            "error": null,
            "result": {
                "gasUsed": "0x1ea7b",
                "output": "0x0000000000000000000000000000000000000000000000e0e82ca52ec6e6a4d3"
            },
            "subtraces": 1,
            "traceAddress": [
                0
            ],
            "transactionHash": "0xe3f418d4fb9ded6f13481b47ca19d3454b039c7ec96ba0778e920d39f9029a31",
            "transactionPosition": 0,
            "type": "call"
        },
        {
            "action": {
                "callType": "delegatecall",
                "from": "0x2e4777139254ff76db957e284b186a4507ff8c67",
                "gas": "0x1ce41",
                "input": "0x43bcfab60000000000000000000000006b175474e89094c44da98b954eedeac495271d0f0000000000000000000000000000000000000000000000e0bd811c8769a824b00000000000000000000000000000000000000000000000e0ae9925047d8440b60000000000000000000000002e4777139254ff76db957e284b186a4507ff8c67",
                "to": "0x15b2838cd28cc353afbe59385db3f366d8945aee",
                "value": "0x0"
            },
            "blockHash": "0x57fc41478973665020c3da3e26dc0cad4e975bff441a24674e4f89c273046b54",
            "blockNumber": 15291051,
            "error": null,
            "result": {
                "gasUsed": "0x1ce41",
                "output": "0x0000000000000000000000000000000000000000000000e0e82ca52ec6e6a4d3"
            },
            "subtraces": 2,
            "traceAddress": [
                0,
                1
            ],
            "transactionHash": "0xe3f418d4fb9ded6f13481b47ca19d3454b039c7ec96ba0778e920d39f9029a31",
            "transactionPosition": 0,
            "type": "call"
        }

The first two traces from Nethermind
[
        {
            "action": {
                "callType": "call",
                "from": "0x2e4777139254ff76db957e284b186a4507ff8c67",
                "gas": "0x262b3",
                "input": "0x43bcfab60000000000000000000000006b175474e89094c44da98b954eedeac495271d0f0000000000000000000000000000000000000000000000e0bd811c8769a824b00000000000000000000000000000000000000000000000e0ae9925047d8440b60000000000000000000000002e4777139254ff76db957e284b186a4507ff8c67",
                "to": "0xe2f2a5c287993345a840db3b0845fbc70f5935a5",
                "value": "0x0"
            },
            "blockHash": "0xa47c8f1d8c284cb614e9c8e10d260b33eae16b1957a83141191bc335838d7e29",
            "blockNumber": 15291051,
            "result": {
                "gasUsed": "0x2131b",
                "output": "0x0000000000000000000000000000000000000000000000e0e82ca52ec6e6a4d3"
            },
            "subtraces": 1,
            "traceAddress": [],
            "transactionHash": "0x3255cce7312e9c4470e1a1883be13718e971f6faafb96199b8bd75e5b7c39e3a",
            "transactionPosition": 19,
            "type": "call"
        },
        {
            "action": {
                "callType": "delegatecall",
                "from": "0xe2f2a5c287993345a840db3b0845fbc70f5935a5",
                "gas": "0x23d88",
                "input": "0x43bcfab60000000000000000000000006b175474e89094c44da98b954eedeac495271d0f0000000000000000000000000000000000000000000000e0bd811c8769a824b00000000000000000000000000000000000000000000000e0ae9925047d8440b60000000000000000000000002e4777139254ff76db957e284b186a4507ff8c67",
                "to": "0x15b2838cd28cc353afbe59385db3f366d8945aee",
                "value": "0x0"
            },
            "blockHash": "0xa47c8f1d8c284cb614e9c8e10d260b33eae16b1957a83141191bc335838d7e29",
            "blockNumber": 15291051,
            "result": {
                "gasUsed": "0x1f6e1",
                "output": "0x0000000000000000000000000000000000000000000000e0e82ca52ec6e6a4d3"
            },
            "subtraces": 2,
            "traceAddress": [
                0
            ],
            "transactionHash": "0x3255cce7312e9c4470e1a1883be13718e971f6faafb96199b8bd75e5b7c39e3a",
            "transactionPosition": 19,
            "type": "call"
        }

fixed smol issue with traceAddress
does match the reference tx now. will fix delegate in a separate pr

this now also includes the fix for #2663
see openenthereum impl for from/to addresses
https://github.com/openethereum/openethereum/blob/6c2d392d867b058ff867c4373e40850ca3f96969/crates/ethcore/src/trace/types/trace.rs#L73-L90


Option to install/Add multiple connectors from filesystem

Description:
$subject
Currently we have to import one connector at a time unless it is available in the official connector store.
This will improve UX user base that develop their own connectors

This is a crucial usability improvement and appreciate a quick fix.


Labeled region

Labeled region is the head but not the helmet.
It's a trick? raise the mAP?
If labeled region includes only the helmet, would the model converge faster, or not?

@wujixiu
thanks.
great job!


[ZEPPELIN-5443] Allow the interpreter pod to request the gpu resources under k8s mode

What is this PR for?
Currently, the interpreter pod created by k8s/interpreter/100-interpreter-spec.yaml cannot request the GPU resources. So this PR adds two properties:

zeppelin.k8s.interpreter.gpu.type, to specify the type of GPU, e.g., nvidia.com/gpu.
zeppelin.k8s.interpreter.gpu.nums, to set the number of requested GPU.

Users can set these two properties directly in the interpreter settings, such as:
%spark.conf
zeppelin.k8s.interpreter.gpu.type nvidia.com/gpu
zeppelin.k8s.interpreter.gpu.nums 1

, which makes the interpreter pod be scheduled to a machine with GPU resources.
What type of PR is it?
[Improvement]
Todos

[ ] - Task

What is the Jira issue?

https://issues.apache.org/jira/browse/ZEPPELIN-5443

How should this be tested?

CI pass and manually tested

Screenshots (if appropriate)
Questions:

Does the licenses files need update? No
Is there breaking changes for older versions? No
Does this needs documentation? No

@Reamer Could you help review this ?

LGTM


support to connect via proxy server

https://github.com/kylebrowning/APNSwift/issues/104

im closing this in favor of adopting async-http-client for everything.


Ditch the Automatonic prefix

The first thing I would do is rename it, so why force it on others. HttpArchive should be sufficient.

Namespace/PackageId/Assembly name are all now HttpArchive


Still maintained?

There doesn't seem to have been any activity on this repo for a while @kuimono - are you still able to maintain it? I'd be happy to help or take it on if not

It looks like you've already started: https://github.com/mike-oakley/openapi-pydantic

Hi @hathawsh - yep indeed i've forked and updated the project. Happy to accept contributions there - if @kuimono does want to pick this back up i'd also be happy to merge back into this original (however I have started to make some perhaps opinionated decisions).
Re your points:

The README credits section and the License file do both give credit to this original implementation, however I'll update the README to mention earlier and with a specific version where the fork occurred.
The version number went to 0.x as part of my fork and updates (which made some changes to this original). Will look to cut a 1.x release once it has a little more use. I started versioning afresh to keep things simple for newcomers but appreciate its a little odd coming from this lib.
Will add a contribution guide asap 👍🏼


Tolerate JAX-RS 2.2 in swagger-core so that it can be deployed in Liberty alongside features which use 2.2

When using a Liberty container image such as icr.io/appcafe/websphere-liberty:<IP_ADDRESS>-full-java11-openj9-ubi and trying to use the swagger-core library we get a conflict due to two implementations of javax.xml.bind being available.
The features we need to use within Liberty only supply the 2.2 implementation.
Looking at swagger-core 2.2.9 we can see it has compile dependencies on jakarta.xml.bind-api 2.3.2 and so provides an implementation at 2.3. This then causes the conflict.
This issue is to request that swagger-core be updated in some way to change the toleration that ends up in the /META-INF/MANIFEST.MF file to be javax.xml.bind.annotation;version="[2.2,3)" instead of what it has today: javax.xml.bind.annotation;version="[2.3,3)".
Thanks.

Fixed by #4595


Added support for otherFiles and disableArchiveOutput in RobotFramework Plugin

I moved a couple more things than I should have because of my OC-ness.

Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests

Do not move things, it makes the review harder.

Got it. Updated my changes.


Input redesign

I know this would be a very big change on the external interface, but I think that at the end it would be good enought.
My idea is to change the way users prompt for input status. Now, this is achieved by using callbacks(one for each type of input: key callback, mouse button callback, mouse position callback...) and glfwGet* (getKey, getCursor...). My proposal is to unify all input events to just one type, this way all input could be prompted by using something like:
float glfwGetInput(unsigned long code, int mods);
The code paramter will be an identifier of keys, mouse buttons, mouse wheel, joysticks... Each key would have three identifiers, for example: KEY_ESCAPE_PRESS, KEY_ESCAPE_RELEASE and KEY_ESCAPE_PRESSING (the key has been pressed and it is not released). The returning float would be 1.0 if code is KEY_ESCAPE_PRESS and is the key pressed, 0.0 otherwise. For cursor and joysticks the returning float would be the position of the prompted axe.
A getAllInputs function (a function which returns an array of all events) would be very useful too.
I did an input module (a glfw wrapper), which do exactly this and it's only 200 lines long plus a 100 lines long hashmap module, so I think this can be achieved without bloating GLFW.
I think this would be a very good simplification. Moreover, it provides an easy to use interface for a mapping module (ie.: GLFW_KEY_ESCAPE_PRESS => INPUT_EXIT_PROGRAM). That's on my wrapper module too, but I guess that mapping would be considered outside the scope of GLFW.
I don't know a lot of GLFW internals, but I read some of the input system code and I think I could re-write, at least, the X11 module.

For cursor and joysticks the returning float would be the position of the prompted axe.

What about the scroll wheel. It has no absolute position, only relative deltas.
Would it return the accumulated relative delta since last query?
Can you link to your wrapper?

Would it return the accumulated relative delta since last query?
I think that would be ok.
Can you link to your wrapper?
Yes, I uploaded to github here. It was developed fast and some things are missing, but it works. However, mi idea is more like a rewrite-redesign, not an addition.

KEY_ESCAPE_PRESSING (the key has been pressed and it is not released)

I already tried to implement this in glfw, but unfortunately it seems to be not possible to get
always corresponding press/release events from the window manager reliably. IIRC there was missing release event by loosing/entering window focus, etc.

@capnm That cannot be resolved by automatically release all pressed keys in KEY_ESCAPE_PRESSING status when the window loose its focus?

Maybe ;-) I couldn't found an universal way, so I ended up implementing this at the app level (a ring buffer + bunch of workarounds).

I will not be taking the API in this direction, but I'll be happy to point people wishing for such an API to a small library that implements it on top of GLFW. I've done the same for the event queue style.

I will not be taking the API in this direction, but I'll be happy to point people wishing for such an API to a small library that implements it on top of GLFW. I've done the same for the event queue style.

That's neat! I've done something similar on top of GLFW too. It converts all inputs to pointers with buttons/axes/sliders and pushes them into one queue. See source here.
There's a web version you can try in your browser here. Just open the console (before navigating there).

@shurcooL That's pretty cool. Seemed to work in Firefox, too.


Fix wasm preview

Change Summary
Fixes the WASM Preview by resolving a dependency mismatch in typing-extensions. Since pydantic-core version 2.0.0 it seems, the built wheel used in this demo already specifies typing-extensions as a dependency, and there's no need in install a (mismatched) version via loadPackage in advance.
Related issue number
Fixes #834.
Checklist

[x] Documentation reflects the changes where applicable
[x] My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

I can confirm the WASM Preview is now working for me in chrome on MacOS. (And was not prior to merging this.)


Base: ezETH

Please review the following token assets:
📑 Description

Token Name: ezETH
Project Website: https://docs.renzoprotocol.com/docs/contracts/layer-2s
Explorer URI: https://basescan.org/address/0x2416092f143378750bb29b79eD961ab195CcEea5

✅ Checks

[x] I created a new folder with the token address, all in lowercase
[x] I added the token's logo as a 32x32 PNG file, named logo-32.png
[x] I added the token's logo as a 128x128 PNG file, named logo-128.png
[x] I added the token's logo as a SVG file, named logo.svg
[x] My SVG logo is a proper SVG and not some base64 stuff
[ ] My documentation/website clearly display the token address somewhere

Deployment logs show this token links to ezETH on Mainnet
ezETH Mainnet Docs: https://docs.renzoprotocol.com/docs/contracts/ethereum-mainnet

cc @ethzoomer


84 terrain changes to accomendate mapping

Change the spawn height.
:ballot_box_with_check: Definition of Done checklist

[ ] Meaningful title and valuable description in pull request
[ ] Code change tested manually if not covered by automated tests
[ ] Pull request linked to one or more issues/stories
[ ] Acceptance criteria of the linked stories satisfied
[ ] Code change comprehended by those who approved it
[ ] State of target branch maintained or improved after the code change

Good job Ahmed. I am just wondering why we added the empty space at the end of the parking lot (with the wall)


Resubmitting #14 - Adding callbacks for draft creation, update, and destroy

See discussion and comments at #14

Hey @chrisdpeters, thanks for merging #21 and #23.  If you'd like, I can rebase this and make sure it's a clean fast forward merge.

@npafundi No worries. I will be releasing v0.3.4 with your bug fixes soon. These new callbacks will go in v0.4.

@chrisdpeters I rebased this branch to match master again.  Are you still considering pulling this in?

@npafundi Thank you for the rebase. Yes, I would like to get this merged and released within a week or 2. I wanted to spend some time reviewing the tests just to make sure I understand everything fully. I'm sure it's fairly straightforward.

@npafundi Heck, let's merge now. This is next on the list.

Thanks @chrisdpeters!  Happy to explain anything, and if I'm missing any tests we can definitely add more.


Add usdc to mainnet configuration

@ted-palmer done. I had to bump the RK version to get the currencies prop on the BidModal. We'll run into conflicts but should be easy to handle


Implemented LaTeX printing of polynomials

Nice in e.g. Jupyter Notebook. Also fixed bug in printing of negative imaginary numbers.

This should be a nice addition, but writemime is now deprecated. Can you update this?

This should be addressed by #73, though slightly differently. Please re-open if the latex printing isn't as expected.


clean up sourceMap file after write

After sourcemaps.write() files should not have the sourceMap property or plugins that are gulp-sourcemaps aware will attempt to re-write the source maps even though they have already been written.
For example:
gulp.task('typescript', function() {
  return gulp.src('src/**/*.ts')
    .pipe(sourcemaps.init())
    .pipe(typescript()
    .pipe(sourcemaps.write())
    .pipe(babel())
});

In this case, babel, checking for file.sourceMaps will re-write the sourcemaps of the file, despite it being after the write.
For legacy and testing I have added and documented write({noClean: true}) which will maintain the old behavior. Outside of testing, I don't think it should be necessary for most users.
Thanks for all your work!

Actually, this still didn't solve my problem, so feel free to close / not merge :D


Add X509_STORE_CTX_verify, which takes the first untrusted cert as default target

This is a spin-off from #13735.
The idea came up that when calling X509_STORE_CTX_init(ctx, trust_store, <target cert>, chain)
it should be rather often the case that the chain already has <target cert> as its first element:
Then we could simply and conveniently take this as the default target certificate for ~X509_verify_cert()~X509_STORE_CTX_verify(),
such that calling X509_STORE_CTX_init(ctx, trust_store, NULL, chain) will be sufficient.
Checklist

[x] documentation is added or updated
[x] tests are added or updated

To restate my comments from elsewhere: this takes an error case (forgetting to specify the cert) and makes it something that works. Please do not do this for 3.0 as it will break (sic) broken programs.

it should be rather often the case that the chain already has  as its first element:

Rather often is excessive; I'd say "sometimes"  (At least in our experience at Akamai.)

To restate my comments from elsewhere: this takes an error case (forgetting to specify the cert) and makes it something that works. Please do not do this for 3.0 as it will break (sic) broken programs.

it should be rather often the case that the chain already has  as its first element:

Rather often is excessive; I'd say "sometimes"  (At least in our experience at Akamai.)

Please do not do this for 3.0

I had already labeled this 'Post 3.0.0'.

Please do not do this for 3.0

I had already labeled this 'Post 3.0.0'.

this takes an error case (forgetting to specify the cert) and makes it something that works.

Good point - so how about instead adding (after 3.0) a new function for explicitly handling the chain verification use case
where the target cert will be the first element of the chain contained in the context?
int X509_verify_chain(X509_STORE_CTX *ctx)

I agree that a new function to verify the chain and its first cert is more clear than overloading the existing function.

I've meanwhile changed this PR to add X509_verify_chain(), rather than extending X509_verify_cert().

Now thinking about this some more - IMO the X509_verify_chain() is a wrong name. It is quite confusing that it has only a single parameter which is not an X509* but X509_STORE_CTX*. So please also rename it to X509_STORE_CTX_verify_chain().

Good thought - and taking this even further, I suggest X509_STORE_CTX_verify(),
which is shorter and more to the point: the function can verify the cert or by default the chain.

The CI failures are unrelated.

This pull request is ready to merge

Merged - thanks @t8m and @richsalz


Retry logic is not used when creating a table

Hi there, we run several End2End tests in parallel. Unfortunately, we reach the maximum and we would exceed the limit.
Following error message is shown:
Google\Cloud\Core\Exception\ServiceException: {
  "error": {
    "code": 403,
    "message": "Exceeded rate limits: too many table update operations for this table. For more information, see https://cloud.google.com/bigquery/troubleshooting-errors",
    "errors": [
      {
        "message": "Exceeded rate limits: too many table update operations for this table. For more information, see https://cloud.google.com/bigquery/troubleshooting-errors",
        "domain": "usageLimits",
        "reason": "rateLimitExceeded"
      }
    ],
    "status": "PERMISSION_DENIED"
  }
}

/code/vendor/google/cloud-core/src/RequestWrapper.php:368
/code/vendor/google/cloud-core/src/RequestWrapper.php:207
/code/vendor/google/cloud-core/src/RestTrait.php:97
/code/vendor/google/cloud-bigquery/src/Connection/Rest.php:158
/code/vendor/google/cloud-bigquery/src/Dataset.php:294
[...]

We get this error when creating a table. This is the method we run: L280
My intention was to write a retry method with exponential backoff. However, I found that this library already uses a client that does exactly that. If a rateLimitExceeded happens, then it is simply tried again.

L125
Retry.php
RetryDeciderTrait.php

Except if it is e.g. the insert Table method:

Please note that by default the library will not attempt to retry this
call on your behalf.

-- createTable: [L261] (https://github.com/googleapis/google-cloud-php/blob/master/BigQuery/src/Dataset.php#L261)

The Retry logic has been introduced together with the exception for the createTable method with the following pull request.
Pull requests 686
The questions I do have:

whats the reason behind not using the retry method when creating the table by exceeding the limits?
what is the reason not to implement this retry logic in my application code?

Hi @lukas9393, thanks for bringing this up! I raised the issue with the BigQuery team, we're going to look into it a bit further.
In the meantime though, while the library disables retries by default, it does not prevent you from allowing them! You could provide retries with a value greater than 0 to enable retry:
$dataset->createTable($id, ['retries' => 3]);

I'd advise using caution with this for now. There's some context as to why retries were enabled that I don't have just yet, so there might be implications I'm not aware of. Be sure to test this carefully if you're going to use it outside a simple testing context.
Hope to have more detail for you soon.

The main resource that's problematic from a retry perspective is jobs, as they can mutate other resources in a non-idempotent fashion even when errors are present.
Table creation should be safe to retry. There's a consistency interaction with the streaming mechanism that may have triggered this logic change earlier, but that's not really resolved by disabling retries on table insertion.  Possibly there's something related to the retry predicate?  e.g. it's pointless to retry on duplicate, since the resource already exists.

Thank you @jdpedrie, I will use your solution. I didn't realise that ['retries' => 3] + ['retries' => 0] would make it to ['retries' => 3]. I thought that even if I change the retry logic via the option, the value will be overwritten to 0 again. Thanks for the hint.
Thanks to both of you, @jdpedrie and @shollyman, for taking time and effort for this ticket.

Glad to help! Yep, this is one of those times when PHP weirdness works to our advantage. ;)


Cannot hide new extension kinds 'user' and 'issue'

Testing #93739

the actual filtering isn't implemented 🤦♂


:book: move full stop out side of link

:rocket: deployment of profiles-pr-103 in nhsuk-dev succeeded (http://profiles-pr-103.dev.c2s.nhschoices.net)

:rocket: deployment of profiles-pr-103 in nhsuk-dev succeeded (http://profiles-pr-103.dev.c2s.nhschoices.net)

thanks, have moved that full stop too


Is there an arena.txt we can use for #3?

Looking for an arena.txt so I know how #3 works. RIght now it's just erroring out cause it doesn't have an arena.txt.

Hello,
Thanks for checking my projects. This specific issue you describe is for saving/loading a game state -> which you can do just creating an empty file named "arena.txt" on the project's root.
Hope this helps.


DRILL-4187: introduce a new query state ENQUEUED and rename the state PENDING to STARTING

@sudheeshkatkam please review

How should cancellation be handled when the query is ENQUEUED?

Cancellation is handled usual way after query is cancelled only after it has been started.

Addressed review comments.

Yes. cancellation remains the same, but it would be nice to be able to cancel when the state is ENQUEUED (interrupt the thread waiting on the semaphore).

1


sudo ros console command need to be enhanced

RancherOS Version: (ros os version)
v0.4.5-dev-1
Where are you running RancherOS? (docker-machine, AWS, GCE, baremetal, etc.)
baremetal
(1) the current output of the command sudo ros os list is
$ sudo ros console list
default
centos
debian
fedora
ubuntu

It is better that sudo ros console list should be show the status of the consoles eg
$ sudo ros console list
current: default
Disabled: centos
Disabled: debian
Disabled: fedora
Disabled: ubuntu

when we switch to ubuntu console, the output of the command should be
$ sudo ros console list
Disabled: default
Disabled: centos
Disabled: debian
Disabled: fedora
current: ubuntu

when we enable ubuntu console. and before reboot
$ sudo ros console list
current: default
Disabled: centos
Disabled: debian
Disabled: fedora
Enabled: ubuntu

(2) sudo ros console enable command should ensure only one console can be enabled.

(1) would definitely be a good change. I think matching the appearance of ros service list would be best (with the addition of the "current" option).
disabled amazon-ecs-agent
enabled  kernel-headers
disabled kernel-headers-system-docker
disabled open-vm-tools

(2) is actually done already. rancher.console is a string which means only one can be set at a time.

Thanks @joshwget ,(2) has indeed done. I would like to add (1) on the new version v0.5.0.

Verified with v0.5.0-rc1
$ sudo ros console list
disabled centos
disabled debian
disabled default
enabled  fedora
current  ubuntu


PIL-1116 #2 Pull Request  - after Revert

PIL-1116 #2 Pull Request  - after Revert

Srikanth Madduri.   14:58
https://jira.tools.tax.service.gov.uk/browse/PIL-1116 is ready to merge