Adding ansible command to README

Seems like ansible-galaxy install -r provisioning/requirements.yml is mandatory to install the VM. Otherwise, it throws error as mentioned in #442

@subhojit777 - That should not be required if you're using Drupal VM 3.2.x (or I think 3.1.x) with Vagrant 1.8.2 or later. Vagrant will install the roles automatically.


Fix duplicate chat messages

If the messageSubject existed previously already, we don't want to resubscribe to the message observable.
This has a potential downside, as we currently don't differentiate between different rooms, but only topics.
So two parallel rooms, using the same topic, would fail to work.
That's why I changed the mapId to consist of room.name + localParticipant.identity + topic. This gives us a unique identifier. However this approach falls short if the chat is being set up before the connection is established, as we only know the room name and identity once a user has connected.
Another option would be to monkey-patch the room object and have the topicSubjectMap with only the topic as the map id. This would be a solution that works under all circumstances, but monkey patching it feels wrong.

I think we can get around monkey patching by using the room obj as a map key. not elegant either, but does the job. updated the code accordingly


Cannot Undo within bottom panel when script view is active

Godot version: 3.3.2
This is not a new bug, I've definitely noticed this before.
OS/device including version: Win 64
Issue description:
Pressing Ctrl+Z to undo something in one of the bottom panels works when 2D and 3D viewports are active, but does not work when the script view is active. Even though the focus clearly is in the bottom panel when pressing Ctrl+Z, the Ctrl+Z event is captured by the script panel and suddenly the last action on the script panel is undone.
This is very unexpected behaviour and can easily go by unnoticed until you want to run your game and something is broken.
For the longest time I just thought the bottom panel had no "undo". I have tested this with the TextureRegion, Animation, Audio, SpriteFrames bottom panel. It's the same behaviour with all of them: Undo works in 3D, 2D but not with script view.
Steps to reproduce:

Make sure 2D or 3D view is active,
Add AnimationPlayer + New Animation + Track + Key, move the key around and press Ctrl+Z (works)
Switch to script view and type something,
then back to the Animation Panel and move the key around again. Hit Ctrl+Z and witness your script reverting even though the focus was on the Animation Panel.

This is already fixed in 4.0, but can't be backported.


Fix capitalization, punctuation

Changed "Coffeescript" to "CoffeeScript", and added a comma.

Thanks for this!


IChromelyContainer lost?

in the latest nuget package version 5.1.0 of Chromely.Core ,can not find IChromelyContainer,is any break change?

@kinshines yes.

Caliburn.Light Container is replaced by .NET Extensions Dependency Injection.

https://github.com/chromelyapps/Chromely/issues/225


Improve support for PRO edition

I'm trying to export from SystemData with a PRO edition (tested with version 8.0.0) and my local configuration show some PHP warnings or API failures on results :

Unknown constant ACL_ALLOW_SELECTED_TEAMS when I'm selecting Roles
Unknown table pmse_project when I'm selecting Awf

I'm going to make a pull request about this, feel free to comment :wink:

Hi Oberge,
Please see if this fixes your issues: https://github.com/sugarcrmlabs/SystemData/pull/11
Thanks!

Hi esimonetti
Thanks a lot for that support


Update debian.md

Proposed changes
Added workaround for apt-key deprecation errors.
The installation instructions for Debian use a plain sudo apt-key add - to
add the gpg fingerprint, resulting in errors when trying to install on newer
Debian builds, as detailed in #11625 . The workaround is copied from this comment.
Related issues (optional)
#11625

I noticed the workaround still make use of the deprecated apt-key tool.
I believe a more future-proof approach would be to discontinue use of apt-key altogether as described in Debian's wiki and summarized in this comment


deinit-devirtualization: completely de-compose non-copyable destroys

Even if the destroyed value doesn't have a deinit.
This fixes a false alarm when a non-copyable value ends its lifetime in a function with performance annotations.
rdar://117002721

@swift-ci test


Add tests

Description
.
Who will benefit from this feature?
No response
Anything else?
No response

What are you planning to use for testing? If it's jest i would like to learn and make an PR, if that's something you are looking forward.


Show how to use the save handler

This change explains how the save handler works a bit more clearly.

Also maybe include something about how to convert the document to JSON like this?
    let doc = params.editorSession.getDocument()
    let jsonConverter = new JSONConverter()
    let jsonStr = JSON.stringify(jsonConverter.exportDocument(doc))
    console.log(jsonStr);

Project looks fantastic by the way. I know you're in the middle of reworking it.

Hey good idea!
The challenge we face with the examples is keeping them minimal and not mix too many features into one example. It was tempting to demo saving as part of the image example because it includes file upload as part of a save action.
Merging this as it's a good addition. However, I think we should work towards a dedicated 'persistence' example. And a 'converter' example. If you want to help with that you are very welcome!

Cool! I feel like recording a video showing how it all works, but it's probably a little too early. Really like the way you use the sync/Promise.all to upload. It's really great.


fix(TDI-36042): Friendly connection error message

What is the current behavior? (You can also link to an open issue here)
previously there was an weird message. https://jira.talendforge.org/browse/TDI-36042
What is the new behavior?
The message is user-friendly now.
works well in TOS_DI-20210101_1939-V7.4.1 with components-parent version0.29.0-SNAPSHOT
Please check if the PR fulfills these requirements

[ ] The commit message follows Talend standard
[ ] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features) ?
[ ] The code coverage on new code >75%
[ ] The new code does not introduce new technical issues (sonar / eslint)

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build / CI related changes
[ ] Other... Please describe:

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information:
Was added the try/catch block in the SalesforceSourceOrSink and error.connectionFail in the properties. Have no idea why the error.expiredPassword was deleted and added again it was not being touched.

Pull request test result: failure :x:

Pull request test result: failure :x:


[FLINK-19158][e2e] Fix wget timeout mechanism and cache config

What is the purpose of the change
Increase stability of java e2e tests

Thanks for the review & approval.
I reported the build failure here: https://issues.apache.org/jira/browse/FLINK-21051

Thanks for the review & approval.
I reported the build failure here: https://issues.apache.org/jira/browse/FLINK-21051

Merging now

Merging now


Add background color to the play-tabs

The iframe may has non-white color, and made contents in bottom not able to be read.
This is what happens before this fix:

After:

maybe just make it white?

I just use the same color as the sidebar (rgb(247, 247, 247))

Let's just use white then.

Okay. Now it's white.


Production state?

Hello, I want to ask that is this package ready for production use? Thank you.

In my opinion better way is wait for more updates, but if you good developer you can use it in production, but if you find some issues, you will need fix it.

I use it in production; last couple months it was quite hard as we have to wait couple days for help, but version 0.11.9 is quite stable to use. http://camsolar-energy.com/

Voyager is still in alpha stage. So we can't guarantee stability, and breaking changes may be introduced.

Answers have been provided. Closing


04-lighting: should demo lighting effects

Can't be done until some of the following are implemented:

https://github.com/hurricanerix/shade/issues/8
https://github.com/hurricanerix/shade/issues/9
https://github.com/hurricanerix/shade/issues/10
https://github.com/hurricanerix/shade/issues/11

Fixed: https://github.com/hurricanerix/shade/commit/d47094e980f226f07cb0662326f8c94da12f5058


consider publishing gradle-ide-3.x.jar in artifact repository

I'm interested in extending the functionality of the Eclipse IDE plugin, which can be found in a Gradle installation in the plugins folder, e.g. ${gradle.home}/lib/plugins/gradle-ide-3.3.jar
From the package naming, it looks like the plugin is designed for extension (i.e. there is a distinction between internal and API classes)
The sources for this plugin are at subprojects/ide
Plugin developers can consume most Gradle dependencies from Artifactory, e.g. https://repo.gradle.org/gradle/libs-releases-local/ however from what I can gather Gradle plugins are not available there.  Poking around https://jcenter.bintray.com/org/gradle/ I can't seem to find the ide plugins either.
Would it be possible to publish gradle-ide-x.x.jar in Artifactory along with the rest of Gradle?  This would facilitate extensions and code reuse.

In case it helps, this is what I'm working on: https://github.com/greensopinion/gradle-android-eclipse

Thanks for the note and context @greensopinion. I know we discussed this a few times, and I need to remind myself why we haven't done this.

Thanks for the quick response.  Is there anything that I can do to help move this forward?

@greensopinion Is there a specific reason for _not) using gradleApi() to reference the IDE classes when writing the plugin? That's what I would do.

All of the examples of gradleApi() that I've seen are groovy-based.  Is there a way to make this work with plugins implemented in Java?

@greensopinion The Gradle API is written in Java. You should be able to implement the same logic as part of a Java-based plugin. Except maybe for some exceptions it should work as is. Can you give me an example?

@bmuschko sure,
see the FIXME in the pom here: https://github.com/greensopinion/gradle-android-eclipse/blob/master/pom.xml
you can see how the classes are referenced here:
https://github.com/greensopinion/gradle-android-eclipse/blob/master/src/main/java/com/greensopinion/gradle/android/eclipse/AndroidSdkLibraryDependenciesAction.java
https://github.com/greensopinion/gradle-android-eclipse/blob/master/src/main/java/com/greensopinion/gradle/android/eclipse/GenerateLibraryDependenciesAction.java
what am I missing?

Oh, you are building the Gradle plugin with Maven. Why did you decide to go with Maven here and not with Gradle?

Why did you decide to go with Maven here and not with Gradle?

Primarily familiarity.

OK, I'd go with Gradle and use the gradleApi() dependency. If you want to stick with Maven then there's no way to implement the functionality without use publishing the JAR file first. I'd encourage you to go with Gradle all the way.

That's fair, I'll switch to a Gradle-based build.  Feel free to close this as won't fix.
Thanks so much for your help.

Sounds good. Let us know if you need further assistance.

Well that was pretty painless!
If anyone's interested, I replaced the Maven build with this Gradle build script: https://github.com/greensopinion/gradle-android-eclipse/blob/master/build.gradle

If anyone's interested, I replaced the Maven build with this Gradle build script.
Small comment about your code. The Eclipse plugin configuration you have in there is not required. All of the values you set are defaults (please see relevant Javadocs).

Thanks for the tip!


Class model factsheet exists twice

Description of the issue
Class model factsheet exists twice!

Class OEO:00020031 has the editor note: Since a model facsheet is a model descriptor as well as a factsheet, this class is implemented as equivalent class to OEO_00000277. Is this really the proper way?
Can't we do something better like equivalentTo factsheet and (is about some model)?
Ideas of solution
If you already have ideas for the solution describe them here
Workflow checklist

[ ] I discussed the issue with someone else than me before working on a solution
[ ] I already read the latest version of the workflow for this repository
[ ] The goal of this ontology is clear to me

I am aware that

[ ] every entry in the ontology should have a definition
[ ] classes should arise from concepts rather than from words

Okay, I'll implement this


Fork synchronization

Following my comment at #384 it would be nice to clarify what is the selected way of synchronization with the https://github.com/alphagov/govuk-frontend repository. This should be either in the readme file or the contribution guide. For example can issues in the src/govuk directory be fixed here?

Hello, we are syncing with the govuk-frontend repository within every major release of id-sk-frontend, the next major release should be later this year. There is a branch called govuk-4.6-rebase where we keep the sync with the latest govuk-frontend (https://github.com/id-sk/id-sk-frontend/tree/feature/govuk-4.6-rebase). The issues you mentioned should be fixed in that branch.


Ability to import remote files

Added the ability to import remote files.
Fixed assertions with assert_equals to assert_nil
Fixed a signature error in a file.
Made tests pass :)

Hi @cbaykam ! Thanks for the heads up, lots of improvements to the (test)code 👍  I like your change from open to import, which is an improvement (although breaking change, but Workbook is still < 1.0 ;) ). If you can address the issues I mentioned I'll merge it with the existing code base and release a new version of the gem. Thanks again!

Sure will do. And as I get my hands dirty I will clean up the issues reported by hound too :)

Just don't overdo it ;) Thanks!

It should be ready.


Create meet-up for DataPalooza

Be sure to point to registration page

@jhibbets @ChrisTheDBA  Do you think it's worth making a MeetUp with the details of DataPalooza?


feat: add InputArray and InputMap

Closes goravel/goravel#233
📑 Description
Add InputArray and InputMap method, can test with gin/fiber's master branch.
✅ Checks

[x] My pull request adheres to the code style of this project
[x] My code requires changes to the documentation
[ ] I have updated the documentation as required
[x] All the tests have passed

ℹ Additional Information

Good idea! Could you please add these two methods to goravel/gin and goravel/fiber first? Otherwise, the goravel/framework will panic after this change.

use their master branch.


Update swagger codegen and templates to generate LR API with relations

It was implemented in scope of #324


feat: add unread count pastille on openLauncherMessage

fix: inputTextFieldHint #73
Proposed changes:

adding an unread messages count on the launcher
regroup messages in conversation by "sender" with className from-${sender} allowing better control over CSS --> https://github.com/mrbot-ai/rasa-webchat/issues/113

When the widget is closed and the user receives new messages, it allows to notify the user of new incoming messages. Once the widget is reopened, the count is reset to zero.
-> ./assets/unread_count_pastille.png
Status (please check what you already did):

[x] made PR ready for code review
[x] added some tests for the functionality
[x] updated the documentation
[ ] updated the changelog

J'ai oublié d'ajouter la propriété displayUnreadCount dans le ./index.js au plugin, je l'ajoute demain matin


nixos-install doesn't work within a nix-shell

Issue description
running nixos-install while inside nix-shell -p vim eventually yields an error, as first observed here
http://lists.science.uu.nl/pipermail/nix-dev/2016-April/020189.html
Steps to reproduce
install nixos. In particular, I reproduced this by following these instructions for setting up a Vultr vps https://www.vultr.com/docs/install-nixos-on-vultr
it reproduced with 14.12, 15.09, 16.03
Technical details

System: (NixOS: nixos-version, Ubuntu/Fedora: lsb_release -a, ...)
Nix version: (run nix-env --version)
Nixpkgs version: (run nix-instantiate --eval '<nixpkgs>' -A lib.nixpkgsVersion)

triage: can you still reproduce this?


feat: Support Context in Assertions API

The assertions API should allow specifying check requests with context.
Description

Added support assertion API for contextual tuples and context.
{
    "assertions": [
        {
            "tuple_key": {
                "object": "folder:test-folder",
                "relation": "viewer",
                "user": "user:anne"
            },
            "expectation": true,
            "contextual_tuples": {
                "tuple_keys": [
                    {
                        "user": "user:anne",
                        "relation": "viewer",
                        "object": "folder:test-folder"
                    }
                ]
            }
        }
    ]
}

curl -v -X PUT --header "Accept: */*" --header "Content-Type: application/json" -d @./no_condition.json http://localhost:8080/stores/01HYE30RYJ6ZJ3ZCD1ZWHJD2KJ/assertions/01HYE316Z4CNBFKFC8E9T45SXV
* Host localhost:8080 was resolved.
* IPv6: ::1
* IPv4: <IP_ADDRESS>
*   Trying [::1]:8080...
* Connected to localhost (::1) port 8080
> PUT /stores/01HYE30RYJ6ZJ3ZCD1ZWHJD2KJ/assertions/01HYE316Z4CNBFKFC8E9T45SXV HTTP/1.1
> Host: localhost:8080
> User-Agent: curl/8.6.0
> Accept: */*
> Content-Type: application/json
> Content-Length: 515
>

With Condition json:
{
    "assertions": [
        {
            "tuple_key": {
                "object": "folder:test-folder",
                "relation": "viewer",
                "user": "user:anne"
            },
            "expectation": true,
            "contextual_tuples": {
                "tuple_keys": [
                    {
                        "user": "user:anne",
                        "relation": "viewer",
                        "object": "folder:test-folder",
                        "condition": {
                            "name": "name_starts_with_alpha",
                            "context": {
                                "folder_name": "test"
                            }
                        }
                    }
                ]
            }
        }
    ]
}

curl steven.meadows$ curl -v -X PUT --header "Accept: */*" --header "Content-Type: application/json" -d @./condition.json http://localhost:8080/stores/01HYE3SW24P34DGXZ7ZF90GP0G/assertions/01HYE3T88BFZXBQZSHHTW4Z38W
* Host localhost:8080 was resolved.
* IPv6: ::1
* IPv4: <IP_ADDRESS>
*   Trying [::1]:8080...
* Connected to localhost (::1) port 8080
> PUT /stores/01HYE3SW24P34DGXZ7ZF90GP0G/assertions/01HYE3T88BFZXBQZSHHTW4Z38W HTTP/1.1
> Host: localhost:8080
> User-Agent: curl/8.6.0
> Accept: */*
> Content-Type: application/json
> Content-Length: 762
>
< HTTP/1.1 204 No Content
< Content-Type: application/json
< Openfga-Authorization-Model-Id: 01HYE3T88BFZXBQZSHHTW4Z38W
< Openfga-Store-Id: 01HYE3SW24P34DGXZ7ZF90GP0G
< Vary: Origin
< X-Http-Code: 204
< X-Request-Id: 4ca8118a-5807-4382-90b8-f0486175a2e6
< Date: Tue, 21 May 2024 17:45:15 GMT
<
* Connection #0 to host localhost left intact

References
https://github.com/openfga/openfga/issues/1353
https://github.com/openfga/api/pull/157
Review Checklist

[ ] I have clicked on "allow edits by maintainers".
[x] I have added documentation for new/changed functionality in this PR or in a PR to openfga.dev [Provide a link to any relevant PRs in the references section above]
[x] The correct base branch is being used, if not main
[x] I have added tests to validate that the change in functionality is working as expected

Regarding the changes to the API in https://github.com/openfga/api/pull/157. This line https://github.com/openfga/api/pull/157/files#diff-d3a74ea9ecaac0a46611253dc0c4bc9c402e2ad9eb255cd41d07266453e258f0R1564 we should avoid duplicating that stuttered field definition. Since this is a new addition to the API, let's follow the same pattern we did in ListUsers. See https://github.com/openfga/api/blob/main/openfga/v1/openfga_service.proto#L877. It stutters less. There's no need for the extra level of indirection.

Regarding the changes to the API in openfga/api#157. This line https://github.com/openfga/api/pull/157/files#diff-d3a74ea9ecaac0a46611253dc0c4bc9c402e2ad9eb255cd41d07266453e258f0R1564 we should avoid duplicating that stuttered field definition. Since this is a new addition to the API, let's follow the same pattern we did in ListUsers. See https://github.com/openfga/api/blob/main/openfga/v1/openfga_service.proto#L877. It stutters less. There's no need for the extra level of indirection.

Since it's been merged already, I will need to open another PR to fix.

This PR is titled "Support Context in Assertions API" but we're not adding Context to to the Assertions API. There is no corresponding PR in openfga/api that adds context field to the Assertion. We need to add https://github.com/openfga/api/blob/main/openfga/v1/openfga_service.proto#L823 to the Assertion definition.


don't save inputs/outputs buffer of FlashAttenFunc to reduce memory usage for inference mode

In inference mode, we don't need to save the inputs/outputs used by the training mode. This PR can reduce memory usage during LLM serving(such as vllm, it uses those flash attn APIs for a better performance).

@XiaobingSuper I found this PR make pytest (https://github.com/Dao-AILab/flash-attention/tree/main/tests) fail.
https://github.com/Dao-AILab/flash-attention/blob/0dfb28174333d9eefb7c1dd4292690a8458d1e89/flash_attn/flash_attn_interface.py#L455
torch.is_grad_enabled() always be False in the test script, which make backward cannot access ctx.saved_tensors

Sorry, it is my mistake, gradient computation is already disabled in custom autograd.Functions by default(https://discuss.pytorch.org/t/is-torch-no-grad-making-a-difference-in-custom-autograd-functions/186627), it need to check it before calling the customer op.

@rocking5566 I created a PR https://github.com/Dao-AILab/flash-attention/pull/1397 to fix this issue. Thanks.


Fails to start on AWS ECS Optimised Instance

When trying to run moby-container-exporter with the example configuration in the README the container fails to start and I get the following error message
Using the following AMI in eu-west-1 ami-95f8d2f3
2017-09-11T09:54:11Z [INFO] Sending task change module="eventhandler" event="TaskChange: <arn> -> RUNNING, Known Sent: NONE" change="TaskChange: <arn> -> RUNNING, Known Sent: NONE"
2017-09-11T09:54:11Z [INFO] Stopping container module="TaskEngine" task="monitoring-task:2 <arn>, Status: (RUNNING->STOPPED) Containers: [moby-container-exporter (RUNNING->STOPPED),node-exporter (STOPPED->STOPPED),]" container="moby-container-exporter(infinityworks/moby-container-stats:latest) (RUNNING->STOPPED)"
2017-09-11T09:54:11Z [INFO] Error retrieving stats for container fef842a224e3714512d841d6b9e150776ee1534661e2f8412209c4fdcd177e52: context canceled
2017-09-11T09:54:11Z [INFO] Container fef842a224e3714512d841d6b9e150776ee1534661e2f8412209c4fdcd177e52 is terminal, stopping stats collection
2017-09-11T09:54:11Z [INFO] Adding event module="eventhandler" change="ContainerChange: <arn> node-exporter -> STOPPED, Exit 2, , Known Sent: RUNNING"
2017-09-11T09:54:11Z [INFO] Sending container change module="eventhandler" event="ContainerChange: <arn> node-exporter -> STOPPED, Exit 2, , Known Sent: RUNNING" change="ContainerChange: <arn> node-exporter -> STOPPED, Exit 2, , Known Sent: RUNNING"
2017-09-11T09:54:12Z [INFO] Task change event module="TaskEngine" event="{TaskArn:<arn> Status:STOPPED Reason: Task:monitoring-task:2 <arn>, Status: (STOPPED->STOPPED) Containers: [moby-container-exporter (STOPPED->STOPPED),node-exporter (STOPPED->STOPPED),]}"
2017-09-11T09:54:12Z [INFO] Error retrieving stats for container 1022f56c4b4a7a1e8fb2442df6837039ae01c5ca8a1df84ac8a94585d2acdc45: context canceled
2017-09-11T09:54:12Z [INFO] Adding event module="eventhandler" change="ContainerChange: <arn> moby-container-exporter -> STOPPED, Exit 2, , Known Sent: RUNNING"
2017-09-11T09:54:12Z [INFO] Adding event module="eventhandler" change="TaskChange: <arn> -> STOPPED, Known Sent: RUNNING"
2017-09-11T09:54:12Z [INFO] Container 1022f56c4b4a7a1e8fb2442df6837039ae01c5ca8a1df84ac8a94585d2acdc45 is terminal, stopping stats collection
2017-09-11T09:54:12Z [INFO] Sending container change module="eventhandler" event="ContainerChange: <arn> moby-container-exporter -> STOPPED, Exit 2, , Known Sent: RUNNING" change="ContainerChange: <arn> moby-container-exporter -> STOPPED, Exit 2, , Known Sent: RUNNING"
2017-09-11T09:54:12Z [INFO] Redundant container state change for task monitoring-task:2 <arn>, Status: (STOPPED->STOPPED) Containers: [moby-container-exporter (STOPPED->STOPPED),node-exporter (STOPPED->STOPPED),]: moby-container-exporter(infinityworks/moby-container-stats:latest) (STOPPED->STOPPED) - Exit: 2 to STOPPED, but already STOPPED
2017-09-11T09:54:12Z [INFO] Redundant container state change for task monitoring-task:2 <arn>, Status: (STOPPED->STOPPED) Containers: [moby-container-exporter (STOPPED->STOPPED),node-exporter (STOPPED->STOPPED),]: moby-container-exporter(infinityworks/moby-container-stats:latest) (STOPPED->STOPPED) - Exit: 2 to STOPPED, but already STOPPED
2017-09-11T09:54:12Z [INFO] Sending task change module="eventhandler" event="TaskChange: <arn> -> STOPPED, Known Sent: RUNNING" change="TaskChange: <arn> -> STOPPED, Known Sent: RUNNING"

This may actually be not related to AWS ECS as first thought so will reopen if I get more information.


I can't craft in my celestial altar!

Its suddenly happened a week ago. There is no problem with the structure or the starlight levels. The crafting recipe can't be wrong because i copied it from JEI. Here is the photo:

This is the issue tracker for refined storage...
Are you lost?

This is the issue tracker for refined storage...
Are you lost?

Oh i see :D I did not saw the title


Disable warnings in generated code

Use a [@@@ocaml.warning] attribute in order to lighten the dune files
expected from the user.
Close #138

Let's remove the noise and just disable 26 and 27 then :-)


Analyze merging rotation gates for 1,2,3 bits into a single gate

Now we need to design gates for rotation throughout lanes, this may change


UI improvement: add a tooltip for "Transaction assurance security level" from settings

In the "Settings" tab from within a wallet, add a tooltip for "Transaction assurance security level".
Or add a link that says "What is this?" and takes you to https://cardanodocs.com/cardano/transaction-assurance/

@leeschmidt4 there is no more any concept of "Transaction assurance security level" in latest Daedalus version.


dateStrings and typeCast

event when dateStrings set as true, typeCast will still convert datetime string as date object

Hi @xycloud, unfortunately I cannot reproduce and our tests show it working just fine. Can you provide additional information to look into the issue? Please provide all the following:

Version of Node.js you are using.
Version of this module you are using.
Complete code I can copy and paste and run that reproduces the issue.
Instructions for how to run the code with a description of what happens with the issue and what you are expecting to happen.

Thank you!

@xycloud - One thing that may be confusing - and which I didn't realize until I started creating a test for a PR - is that this module will accept either a string OR Date object to send to MySQL. The dateStrings connection option affects how values are returned from MySQL. This behavior can be seen in the test I have attached to a pending PR: https://github.com/bbito/node-mysql/blob/master/test/integration/connection/test-datestrings-options.js

Hi @xycloud I'm going to close this issue since there hasn't been any response.


Update LinkedIn::Api::ShareAndSocialStream#add_share for Api v2

The path changed to /v2/ugcPosts
More attributes are required in the payload

Along with sending over the comment, you must send the user's "urn"
Example (updated):
client = LinkedIn::Client.new
client.authorize_from_access(token)
client.v2_add_share(urn, { comment: 'hi' })

https://docs.microsoft.com/en-us/linkedin/consumer/integrations/self-serve/share-on-linkedin?context=linkedin/consumer/context

@dsandstrom if you want to write a test for this I can review this and merge it and also cut a new gem.
Thanks!

Well the problem is this change breaks all other endpoints as they have not been updated for LinkedIn's API v2.  I just wanted to show other people what I got working.

We could do something like Linkedin::V2.add_share too. That way it wouldn't break for others

Not sure how you want to keep v2 methods separate, but this allows v1 endpoints to still work.  You said to do "something like Linkedin::V2.add_share", but that doesn't really make sense since we run
the methods on the LinkedIn::Client.  A possibility is to add a LinkedIn::V2::Client, then include the v2 methods into that class.

nice work! I just put a few comments, mostly nitpicks and question type things.
I'm wondering if we should do something besides the prefixing of the methods for v2_* requests.
I think it's ok, it just feels a bit weird is all since v1 is mostly deprecated at this point.

Prefixing with v2 was just temporary.  A V2 module needs to be set up.  See https://github.com/hexgnu/linkedin/pull/274#issuecomment-472236744

Yea Linkedin::V2::Client makes sense. if you want to do that.

@hexgnu @dsandstrom Just a heads up I added the email endpoint in a fork and opened a PR on @dsandstrom fork. https://github.com/dsandstrom/linkedin/pull/1. My company needs it for our auth flow.

@hexgnu @dsandstrom I ended up adding a little more to my pr it now includes the additions:

Default fields to the /me endpoint, which are now required by LinkedIn
Support for the v2 email address endpoint
Parsing of the raw JSON responses from me and email endpoints
Specs covering what was added above

https://github.com/dsandstrom/linkedin/pull/1

If you all want to combine forces feel free to do so :) will gladly review and merge in.

@dsandstrom @addbrick - great work! Thank you for doing this! If you all can get this in I can't wait to use it :)

Again happy to help merge this stuff in I just don't work with the linkedin API anymore so I'd be flying blind here :smile:.


github: allow manually running tests on specific Ubuntu releases

@tomponline this should be handy when you want to schedule tests against say 5.21/candidate which is known to not play well with 20.04 for example. See it live at https://github.com/simondeziel/lxd-ci/actions/runs/10478318542


FEATURE: Provide control to opt-in/opt-out of json path features

The JToken.SelectToken/SelectTokens APIs do not currently provide any mechanism to control the supported feature set. For instance, we will be hosting user-provided path selectors on a service and would like to disable the ability to utilize regular expressions in the selectors. You might imagine this as a simple method overload which accepts an optional enumeration value of supported features.

We are happy to contribute a PR which implements the feature if there is general agreement on the utility of such an API addition.


RemoteKeyboard is not compatible with W3C mode

What are you trying to achieve? (Expected behavior)
Using WebDriverAction to send keys to an element.
What do you get instead? (Actual behavior)
 Facebook\WebDriver\Exception\UnknownCommandException: unknown command: Cannot call non W3C standard command while in W3C mode

/home/runner/work/mink-panther-driver/mink-panther-driver/vendor/facebook/webdriver/lib/Exception/WebDriverException.php:150
/home/runner/work/mink-panther-driver/mink-panther-driver/vendor/facebook/webdriver/lib/Remote/HttpCommandExecutor.php:385
/home/runner/work/mink-panther-driver/mink-panther-driver/vendor/facebook/webdriver/lib/Remote/RemoteWebDriver.php:593
/home/runner/work/mink-panther-driver/mink-panther-driver/vendor/facebook/webdriver/lib/Remote/RemoteExecuteMethod.php:40
/home/runner/work/mink-panther-driver/mink-panther-driver/vendor/facebook/webdriver/lib/Remote/RemoteKeyboard.php:47
/home/runner/work/mink-panther-driver/mink-panther-driver/vendor/facebook/webdriver/lib/Interactions/Internal/WebDriverSendKeysAction.php:49
/home/runner/work/mink-panther-driver/mink-panther-driver/vendor/facebook/webdriver/lib/Interactions/WebDriverCompositeAction.php:59
/home/runner/work/mink-panther-driver/mink-panther-driver/vendor/facebook/webdriver/lib/Interactions/WebDriverActions.php:57
/home/runner/work/mink-panther-driver/mink-panther-driver/src/PantherDriver.php:473
/home/runner/work/mink-panther-driver/mink-panther-driver/vendor/behat/mink/src/Element/NodeElement.php:105
/home/runner/work/mink-panther-driver/mink-panther-driver/vendor/behat/mink/src/Element/TraversableElement.php:160
/home/runner/work/mink-panther-driver/mink-panther-driver/vendor/mink/driver-testsuite/tests/Basic/CookieTest.php:18

Details
It appears that the command DriverCommand::SEND_KEYS_TO_ACTIVE_ELEMENT does not exists anymore in W3C mode. Only DriverCommand::SEND_KEYS_TO_ELEMENT remains.

Php-webdriver version: 1.8.0@dev
PHP version: 7.4
Operating system: Ubuntu
Browser used + version: Chrome latest

Yeah, there is no such thing as "send keys to active element" in W3C.
I'm thinking about possible solution:

Implement some polyfill for this feature in W3C way - this probably means calling "get active element" first and the respective method like "send keys" pass to the returned element.
Mark the whole class deprecated and JsonWire only. I'm not that fan of providing some features in the library, which aren't part of the protocol... But @Lctrs maybe there is some usecase for the RemoteKeyboard class?

This is the workaround for W3C:
Instead of:
$this->driver->getKeyboard()->sendKeys('foo');

This should provide the same functionality:
$activeElement = $this->driver->switchTo()->activeElement();
$activeElement->sendKeys('foo');

So adding this to RemoteKeyboard is not difficult... But I don't know whether we should provide this kind of abstraction in php-webdriver :thinking: .

Here you go: https://github.com/facebook/php-webdriver/pull/699

@Lctrs The fix has been merged to community branch. Could you whether it works for you properly?

All works for me :+1:

Thanks !


2 Menus on the same page.

I want to use 2 slide-out menus on the same page, one on the left and one on the right. :hamster:

And i want it, but how we can do it?

+1

You could use two instances of Slideout.
https://github.com/Mango/slideout#how-to-open-slideout-from-right-side
Could you share (http://codepen.io/) the code of your example?

@pazguille I'm going to add a code pen for the people who are asking about how to achieve this. Working on this now.

Here is the pen... sorry I know it's a bit messy but shows that this works.
http://codepen.io/xstortionist/pen/GordGp
Here is the javascript:
$(document).ready(function() {
    var slideoutLeft = new Slideout({
        'panel': document.getElementById('panel'),
        'menu': document.getElementById('left-menu'),
        'padding': 256,
        'tolerance': 70
    });

    // Toggle button
    document.querySelector('#left-nav').addEventListener('click', function() {
        slideoutLeft.toggle();
    });

    var slideoutRight = new Slideout({
        'panel': document.getElementById('panel'),
        'menu': document.getElementById('right-menu'),
        'padding': 256,
        'tolerance': 70,
        'side': 'right'
    });

    // Toggle button
    document.querySelector('#right-nav').addEventListener('click', function() {
        slideoutRight.toggle();
    });

});

Here is the CSS:
#left-nav {
	float: left;
}

#right-nav {
	float: right;
}

#right-menu.slideout-menu {
	left: auto;
}

.slideout-menu {
  position: fixed;
  left: 0;
  top: 0;
  bottom: 0;
  right: 0;
  z-index: 0;
  width: 256px;
  overflow-y: auto;
  -webkit-overflow-scrolling: touch;
  display: none;
}

.slideout-panel {
  position:relative;
  z-index: 1;
}

.slideout-open,
.slideout-open body,
.slideout-open .slideout-panel {
  overflow: hidden;
}

.slideout-open .slideout-menu {
  display: block;
}

#127

there is a lingering issue on my example where both menu can show up side by side. I will fix this with CSS, very simple fix.

@xstortionist thank you for share your code! Anyway, I'll work on this feature to avoid create two instances of Slideout.

@pazguille no problem and sounds good. I still run into issue when I have other elements on page that utilize swipe effects. Is there way to ignore certain elements to not trigger the menu swipe.

See my gist:
https://gist.github.com/amir3code/b6a34c2ee4de6d9053d59a0a65ae06d5
I have done it side by side of vuejs.


[FEATURE_REQUEST] Full-Parameter Training/FT

Hi, opening this (as suggested by Daniel) just to request full-finetuning capability for Unsloth. Let's see if other people are interested.
Thanks.

+1

Oh it seems like Discord members have shown Unsloth can do 97% "partial" full finetuning, albeit the layernorms are not updated.


[SPARK-24489][ML]Check for invalid input type of weight data in ml.PowerIterationClustering

What changes were proposed in this pull request?
The test case will result the following failure. currently in ml.PIC, there is no check for the data type of weight column.
test("invalid input types for weight") {
   val invalidWeightData = spark.createDataFrame(Seq(
     (0L, 1L, "a"),
     (2L, 3L, "b")
   )).toDF("src", "dst", "weight")

   val pic = new PowerIterationClustering()
     .setWeightCol("weight")

   val result = pic.assignClusters(invalidWeightData)
 }

Job aborted due to stage failure: Task 0 in stage 8077.0 failed 1 times, most recent failure: Lost task 0.0 in stage 8077.0 (TID 882, localhost, executor driver): scala.MatchError: [0,1,null] (of class org.apache.spark.sql.catalyst.expressions.GenericRowWithSchema)
	at org.apache.spark.ml.clustering.PowerIterationClustering$$anonfun$3.apply(PowerIterationClustering.scala:178)
	at org.apache.spark.ml.clustering.PowerIterationClustering$$anonfun$3.apply(PowerIterationClustering.scala:178)
	at scala.collection.Iterator$$anon$11.next(Iterator.scala:409)
	at scala.collection.Iterator$$anon$12.nextCur(Iterator.scala:434)
	at scala.collection.Iterator$$anon$12.hasNext(Iterator.scala:440)
	at scala.collection.Iterator$class.foreach(Iterator.scala:893)
	at scala.collection.AbstractIterator.foreach(Iterator.scala:1336)
	at org.apache.spark.graphx.EdgeRDD$$anonfun$1.apply(EdgeRDD.scala:107)
	at org.apache.spark.graphx.EdgeRDD$$anonfun$1.apply(EdgeRDD.scala:105)
	at org.apache.spark.rdd.RDD$$anonfun$mapPartitionsWithIndex$1$$anonfun$apply$26.apply(RDD.scala:847)

In this PR, added check types for weight column.
How was this patch tested?
UT added
Please review http://spark.apache.org/contributing.html before opening a pull request.

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Test build #4489 has started for PR 21509 at commit c33d2ec.

Jenkins, retest this please

Jenkins retest this please.

LGTM pending Jenkins.

Test build #100748 has started for PR 21509 at commit b5e6deb.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/6642/
Test PASSed.

Test build #100748 has finished for PR 21509 at commit b5e6deb.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/100748/
Test PASSed.


How to reschedule a task ?

If I have run a task with schedule
notify_user(user.id, schedule=timedelta(minutes=20)) # 20 minutes from now
And later I realise I shoud run it at another time , how can I do it ?
Do we have a task id that returned that we can edit the schedule time  ?
Besides, I have a task to be run with different parameters value , can they be run as a different tasks ?
For example:
notify_user(user.id, schedule=timedelta(minutes=20)) # 20 minutes from now
notify_user(user.id, schedule=timedelta(minutes=60)) # 60 minutes from now
first notify_user & 2nd notify_user are different user tasks.
Basically , I need to provide a UI for user to schedule tasks , how can I allow change of schedule time if existing registered task ? Can we somehow unregister it and register again ?

Well, tasks are given a hash, under task_hash, as well as an ID in the database under the table called 'background_task'.
If you modify the entry in the database, you can change the run time, as well as task parameters, such as, repeat intervals, repeat_until, etc.
Unregistering would be deleting that task before it is processed. Registering would be calling that method again with the proper parameters.

Hi, thanks for your explanation.


bugfix: unresolved import

Checklist

[ ] Sensible git history (for example, squash "typo" or "fix" commits). See the Rewriting History guide for help.
[ ] Update the changelog (if necessary)

Hi, thanks for the PR!
I'm only at the phone right now and can't
verify it. I can't imagine that such an issue wouldn't be covered by our CI, at least from a first glance.
@nicholasbishop I won't have time to look into it until tomorrow. Can you have a look, please?

unsafe_protocol is not yet in a release on crates.io, so I'm guessing you're using a git reference in your Cargo.toml? E.g.
[dependencies]
uefi = { git = "git@github.com:rust-osdev/uefi-rs.git" }

If I have that right, you will also need to patch the uefi-macros dependency. Something like this:
[patch.crates-io]
uefi-macros = { git = "git@github.com:rust-osdev/uefi-rs.git" }

(See https://doc.rust-lang.org/cargo/reference/overriding-dependencies.html#the-patch-section for more info on patches.)
If that doesn't work, please feel free to reply with more details of how you are building your project and I'll try to help debug.


Migration from travis-ci.org to travis-ci.com

travis-ci.org will go down on December 31, 2020, see https://mailchi.mp/3d439eeb1098/travis-ciorg-is-moving-to-travis-cicom

Done. No change in the code.


chore(deps): upgrade configuration

Upgrades project dependencies. See details in workflow run.

Automatically created by projen via the "upgrade-configuration-1.x" workflow

⚪ Backport skipped
The pull request was not backported as there were no branches to backport to. If this is a mistake, please apply the desired version labels or run the backport tool manually.
Manual backport
To create the backport manually run:
backport --pr 1464

Questions ?
Please refer to the Backport tool documentation


feat(lint): Add double_parens

Summary 📌
This PR introduces a new lint double_parens that detects and removes unnecessary double parentheses, improving code readability.
Changes Made ⚡

Implementation of double_parens Lint

Added a new lint in plugin.rs to detect and fix double parentheses.
Implemented the fix logic in fix.rs, ensuring that unnecessary parentheses are removed while preserving the original code structure.
Added test_file! structure in tests.rs.

Test Coverage 🥷🏼

Added test cases in test_files/double_parens to validate the double_parens lint:

Basic case of double parentheses around a number.
Unnecessary parentheses around an arithmetic expression.
Ensured no modifications are made when parentheses are necessary.

Test Results ✅

Hi @0xLucqs I already add more test for this lint, 10 in total and I tested and it is working. Let me know if you need something else, thanks 🫡


Replace deprecated HttpClientTestingModule with new providers provideHttpClient()and provideHttpClientTesting()

HttpClientTestingModule is deprecated and should be replaced with the following two providers
provideHttpClient()
provideHttpClientTesting()
There are around 150 occurrences that need to be migrated
A working example can be seen on learning-path-lecture-unit.component.spec.ts

This is an example that I pushed to develop in 5739e960018b39313135983287a1e8618ac2530b
The patch is attached and needs to be applied 150x more times 😊
0001-Development-Replace-deprecated-HttpClientTestingModu.patch


not sure if this is really a bug or not

Describe the Bug
issue where during a raid, raid waves dont spawn and instead the bar just stays full or empties a little then SLOOOOOWLLLY fills back up like almost two days of time. no enemies ever spawn during this and villagers still run and hide the whole time
Reproduction Steps
1.literally just start a raid idk
2.
3.
...
Expected Result
a raid with the new enemies
Screenshots and Videos
No response
Crash Report or Log
No response
Operating System
Windows 10
Mod Version
1.0.3
Minecraft Version
1.19.2
Forge Version
43.2.0
Other Mods
wasnt a crash but heres the mod list

Additional Context
tried looking through config but nothing changed this

Something like this is happening in my mod pack. The raid started like normal, but there were like 1000 pillagers, that didn’t quite attack me like normal. I also noticed that it spawned pillager encampments and continuously spawned pillagers.


Building and running locally

Did someone manage to build and run this locally? It seems that proto.sh can't find SoyToJsSrcCompiler.jar.
I tried downloading it from the google closure template page, but it says that not all code is in Soy V2, and it refuses to compile it.
If someone did, can i know your system configuration?
Thanks

I have...though I extracted gameplay parts and abandoned Angular approach completely. Additionally, I implemented the game as application in my platform, called Karaqu. Below is a youtube clip...the code is open source
https://youtu.be/-Nd7oOHxaCE?si=oEEJ7El0wG2Wba6c


Locally random circuits

Problem
There are an increasing number of methods that depend upon executing families of closely related circuits. In particular, circuits with random Pauli gates inserted in various locations. This idea comes up in many places, such as the twirling operations in Randomized Benchmarking,  Randomized compiling, Pauli-frame randomization, and classical shadows.
While these circuit families seem increasingly important, they present a significant problem to execute because of the sheer volume of circuits involved when expressed in a way which can be efficiently executed on many hardware systems. The problem is effectively one where our typical framing of near-time vs real-time breaks down to some degree. Let me explain.
Say you want to execute circuits of a form like:
                ░ ┌───┐ ░            ░
q_0: ──■────────░─┤   ├─░───■────────░─
     ┌─┴─┐      ░ ├───┤ ░ ┌─┴─┐      ░
q_1: ┤ X ├──■───░─┤   ├─░─┤ X ├──■───░─
     └───┘┌─┴─┐ ░ ├───┤ ░ └───┘┌─┴─┐ ░
q_2: ─────┤ X ├─░─┤   ├─░──────┤ X ├─░─
          └───┘ ░ └───┘ ░      └───┘ ░

where the empty boxes in the middle should be filled by randomly sampling from circuits with each box is replaced by I, X, Y, or Z.
I can express such circuits as a parameterized circuit in OpenQASM by either connecting to a continuous parameter family for U gates or through control-flow operations that can be reduced to straight line code at compile time. If I choose to do the latter, I need to invoke the compiler for each circuit instance. The former may allow the compiler to be called only once, but I still need to send a parameter set to the quantum processor for each instance.
Some of the protocols linked in the first paragraph request that each circuit instance be executed only once (the single-shot regime). This puts an enormous demand on even a near-time system that sends just a set of parameters for each circuit, as the time to send even one set of parameters may be many times the execution time for a single circuit.
The question I have is whether this randomization can be sensibly expressed instead in the real-time domain.
Solutions??
What I have in mind is something like qubit-local random variables, somewhat akin to thread-local variables in other languages. With qubit-local variables we could invent some syntax that effectively amounts to a local choice among gates of equivalent duration, so that the circuit can be globally scheduled even without knowledge of the local randomness. I don't have great syntax ideas at the moment, but we could just go with something like:
qlocal bit[2] pauli_choice = rand(2); // produce 2 random bits
if (pauli_choice = "00") {
    id $0;
} else if (pauli_choice = "01") {
    x $0;
} else if (pauli_choice = "10") {
    y $0;
} else {
    x $0;
}

and let the compiler do all the work of realizing that the if blocks only depend on qubit-local variables. But, it would be nice to find an alternative which is more compact, and that more directly connects to this constraint of equivalent durations.

I don't understand why we need a special qlocal modifier if we are already relying on the variable being identified as local by the compiler we might as well define an extern qlocal_rand that is inherently identified as a local extern function in the compiled code for the specific target.
IMO what you are really identifying is the inherent inability of QASM to model all of the control system intricacies.

I also think we need extern here because we also need to specify the distribution to draw from.

@taalexander I was looking for something that didn't rely upon a sufficiently smart compiler, but instead allowed the programmer to be explicit about the parallelize-ability of blocks.
Some other ideas that came out of discussion with @levbishop and @ajavadia:

Just do this with box and an explicit duration around the control flow. That already signals to the compiler that the contents of the box have a fixed duration, allowing scheduling to proceed.

Find a way to put this inside of a defcal. i.e. you might have

defcal randpauli(qubit q) -> bit[2] {
   bit[2] pauli_choice = rand(2);
   if (pauli_choice == "00") {
     X q;
   elseif {
      // ...
   }
   return pauli_choice
}

which would get used in a program like a measurement operation. We have already said that control-flow is allowed within defcals for things like defining reset, so long as the duration of the defcal is always computable at compile time.


Add NGS (Next Generation Shell)

Change has been accepted (and you have been credited) in 6f2f48757357835b906ec0b851d77ba35e32648b. Thank you!


Fix logging documentation

The current logging documentation says use ENABLE_MACARON_REDIRECT by mistake instead of REDIRECT_MACARON_LOG
It's also somewhat awkward to have to set DISABLE_ROUTER_LOG in [server] section instead of the [log] section.
This PR fixes both these issues.

Codecov Report

Merging #6904 into master will decrease coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #6904      +/-   ##
==========================================
- Coverage   41.43%   41.43%   -0.01%
==========================================
  Files         432      432
  Lines       59541    59543       +2
==========================================
  Hits        24669    24669
- Misses      31634    31635       +1
- Partials     3238     3239       +1

Impacted Files
Coverage Δ

modules/setting/log.go
73.73% <100%> (+0.24%)
:arrow_up:

modules/process/manager.go
76.81% <0%> (-4.35%)
:arrow_down:

modules/log/file.go
75.52% <0%> (-2.1%)
:arrow_down:

models/gpg_key.go
56.66% <0%> (+0.83%)
:arrow_up:

modules/log/router.go
92.5% <0%> (+2.5%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d64a646...fc102ec. Read the comment docs.


GH2953: Feature addition target initializer msbuildsettings

Regarding the following (incomplete) PR which is now over 6 months old, https://github.com/cake-build/cake/pull/3721, I have rebased @sbwaggoner's original changes on to an up-to-date develop branch and made the change recommended by @devlead on 15 December 2021 during the PR review. Several unit tests have also been added to increase the code coverage of this area too.
Regarding the conditional StringSplitOptions approach recommended in the review, I tried implementing it as suggested but given .Net Core 3.1 StringSplitOptions enum doesn't include the StringSplitOptions.TrimEntries option, trimming still needed to be implemented manually in the code for that target framework. So the conditional compile logic didn't end up offering any benefit imho.

@FrankRay78 & @sbwaggoner  your changes have been merged, thanks for your contributions 👍


Support quick action in razor for adding using statements

From @danroth27 on May 22, 2017 22:19
It would be nice if you could use a quick action (ctrl-. or whatever) to add a using statement for a type in Razor.
Copied from original issue: aspnet/Mvc#6309

From @DamianEdwards on May 22, 2017 23:55
Log tooling requests in the aspnet/Razor repo

Note: This will have to be worked on in conjunction with the tooling team. The primary code changes to enable this do not exist in this repo.


Fix CodeCov

Describe the bug

Reporting inaccurate coverage (~3.8%) when coverage should be ~55% (running locally)
Also, if possible, if we can remove the codecov from our CI checks that would be ideal. Also, the badge could be fixed so it doesn't show unknown

Other information and links

I currently work on code coverage reporting for rust-fil-proofs. So I'll probably run into the same issue and will try to find a fix. So if this isn't urgent, feel free to wait and I'll report back.

For background info, the ~55% reported locally uses html as the coverage report whereas codecov coverage is using lcov INFO format. The HTML report hits ~14722 of 24630 lines (resulting in ~55% coverage), whereas codecov is reporting only ~~1,133 hits of 29,225 lines (resulting in ~3.xx%). Even if you include partially hit lines reported in codecov it still does not come close to the locally reported coverage.


Strange behavior when Border have an ImageBrush as background

Describe the bug
The behavior of the border with an image brush as background is unexpected.
To Reproduce
See the code below (thumbnail is a 170x113 image)
Expected behavior
A clear and concise description of what you expected to happen.
Screenshots
<Border CornerRadius="10" ClipToBounds="True"
		BorderThickness="10"
        Width="96"
        Height="96"
		BorderBrush="{DynamicResource ControlStrokeColorDefault}">
	<Border.Background>
		<ImageBrush Source="{Binding Thumbnail}" />
	</Border.Background>
</Border>

Why the image is stretched on right???

The Designed show something else

With UniformToFill
<Border CornerRadius="10" ClipToBounds="True"
		BorderThickness="10"
        Width="96"
        Height="96"
		BorderBrush="{DynamicResource ControlStrokeColorDefault}">
	<Border.Background>
		<ImageBrush Source="{Binding Thumbnail}" Stretch="UniformToFill" />
	</Border.Background>
</Border>

And in the Designer

The issue is may be in the Border AND in ImageBrush?
I implemented a custom border because I needed BackgroundSizing
<mui:Border CornerRadius="10" ClipToBounds="True"
		BorderThickness="10"
        Width="96"
        Height="96"
		BorderBrush="#77000000"
			BackgroundSizing="OuterBorderEdge">
	<mui:Border.Background>
		<ImageBrush Source="{Binding Thumbnail}" Stretch="UniformToFill" />
	</mui:Border.Background>
</mui:Border>

No problem with BackgroundSizing="OuterBorderEdge"

But here is what I get with BackgroundSizing="InnerBorderEdge"

The placement in my custom border is correct, but the imagebrush behavior is weird!
Desktop (please complete the following information):

OS: Windows 10 DpiScale 100%
Version Avalonia 11 preview 8

Additional context
Add any other context about the problem here.

Can you share the sample shown above to reproduce the exact same behavior?


Missing field "type" in MBusFrame

I think there is a typo in https://github.com/rscada/python-mbus/blob/master/mbus/MBusFrame.py#L21
the field stop is a duplicate and the second instance probably should be type, according to https://github.com/rscada/libmbus/blob/master/mbus/mbus-protocol.h#L91.
I tried redefining the field as:
diff --git a/mbus/MBusFrame.py b/mbus/MBusFrame.py
index 36358e8..1b9c677 100644
--- a/mbus/MBusFrame.py
+++ b/mbus/MBusFrame.py
@@ -1,4 +1,4 @@
-from ctypes import Structure, c_uint8, c_long, c_size_t, POINTER
+from ctypes import Structure, c_int, c_uint8, c_long, c_size_t, POINTER

 c_time_t = c_long

@@ -18,7 +18,7 @@ MBusFrame._fields_ = [
         ("stop",     c_uint8),
         ("data",     c_uint8 * 252),
         ("data_size", c_size_t),
-        ("stop",      c_uint8),
+        ("type",      c_int),
         ("timestamp", c_time_t),
         ("next",      POINTER(MBusFrame))
 ]

However, even with this change, I wasn't able to read the type of the MBusFrame (also tried c_uint8 for the type). I'm not that familiar with ctypes, so maybe there is another place where the C struct is mapped to the Python object MBusFrame?
For testing I called the function frame_type from the C library directly and it returned 4 while queryting the type attribute in Python always returned 0.

I just submitted pull request #23 for this fix. Both MBusFrame.type and  MBusLib.frame_type() give me the same result.


Optimize to_rarray to avoid recursion for simple inputs

Fixes #138 by adding methods for to_rarray on ::Number, ::AbstractArray{<:Number} and ::ConcreteRArray. Adds tests with JET to ensure type stability (which did not hold before).
Question: what should happen to a number going through to_rarray? If it keeps the same type, how can it be traced through the function?

Now that Adapt is a strong dependency, shouldn't we just overload adapt?

Now that Adapt is a strong dependency, shouldn't we just overload adapt? I don't get the different between to_rarray and adapt.

Well to_rarray predates adapt as a strong dep [which we might remove if we can work around later], but also are we sure that adapt correctly deals with recursive data structures?

Well to_rarray predates adapt as a strong dep [which we might remove if we can work around later], but also are we sure that adapt correctly deals with recursive data structures?

Not really. You need to opt-in for every custom structure

Well to_rarray predates adapt as a strong dep [which we might remove if we can work around later], but also are we sure that adapt correctly deals with recursive data structures?

Not really. You need to opt-in for every custom structure

But then, we could maybe overload Adapt.adapt_structure(::Type{ConcreteRArray}, x) to do what to_rarray is doing right now.

Now that Adapt is a strong dependency, shouldn't we just overload adapt? I don't get the different between to_rarray and adapt.

Well to_rarray predates adapt as a strong dep [which we might remove if we can work around later], ...

Yeah, but we introduced to_rarray just because we didn't want Adapt as a strong dep xD

What should we do about this PR?

What should we do about this PR?

I guess we can talk about this on Wednesday. Would you mind putting it in the agenda?


refactor: replace hono with hono/tiny and replace zod with valibot

Description
Replaces hono with hono/tiny and replaces zod with valibot for a reduced bundle size and increased startup time.
Fixes #536
How Has This Been Tested?
pnpm test

I ran this through [https://bundlejs.com/?q=github%3Ahttps%3A%2F%2Fraw.githubusercontent.com%2FItsWendell%2Fturborepo-remote-cache-cloudflare%2Fmaster%2Fsrc%2Findex.ts&treeshake=[*]&config={"cdn"%3A"+https%3A%2F%2Fesm.sh"}](https://bundlejs.com - build results?) and got result of Bundle size is 32.4 kB -> 11.2 kB (gzip)

Bundle size is 32.5 kB -> 11.2 kB (gzip)

@ItsWendell PR looks good, could you add a changeset file? You can do so by running npx changeset.
I think we can call this a major change. Feel free to add a nice description, it will be in the releases when I publish a new release.
FYI this is the makeup of your final build.


Run Python static analysis only in Web workflow

@uweseimet As far as I can tell, what happens when two Sonar analysis jobs runs on the same PR / branch, the one that finishes later will overwrite the one that finishes earlier in the Sonarcloud database. Namely, the C++ analysis will always overwrite the Python analysis, since the former takes a lot longer time.
If I'm not mistaken, this means that when the PR is later merged into develop, the develop branch report on Sonarcloud will only ever contain the analysis of the C++ code. This is not what we want, I think. I suggest we discard this PR in favor of https://github.com/PiSCSI/piscsi/pull/1280


improving agent inverting direction?

Sending this query to the ARS:
"message": {
        "query_graph": {
            "edges": {
                "e01": {
                    "object": "n0",
                    "subject": "n1",
                    "predicates": [
                        "biolink:entity_positively_regulates_entity"
                    ]
                }
            },
            "nodes": {
                "n0": {
                    "ids": [
                        "NCBIGene:23221"
                    ],
                    "categories": [
                        "biolink:Gene"
                    ]
                },
                "n1": {
                    "categories": [
                        "biolink:Gene"
                    ]
                }
            }
        }
    }

Results on the arax UI:
https://arax.ncats.io/?source=ARS&id=4f29cf84-53af-4099-b4fa-22e9b678eb90
The query is asking (?gene)-[entity_positively_regulates_entity]->(RHOBTB2)
But Improving Agent is returning inverted results, i.e. (RHOBTB2)-[entity_positively_regulates_entity]->(?gene)

@brettasmi & @suihuang-ISB  request for update

@brettasmi & @suihuang-ISB request for update

This is an artifact of older code to allow more answers to come back when things were less standardized, i.e. all our searches use undirected edges. This is usually not an issue given two different node types, but you've surfaced a case where a directed edge matters between two of the same node type.
I've created an issue to address this.

Asking for completion date, please update

Mid to late September

@brettasmi
This is not blocking the demo, so I'm removing the demoscript tag. I'm leaving it open as you may want to address it in the future.


mongodb_instance with different names using the same sysconfig file(which in turn force using the same mongo conf file)

I am creating a new mongo instance using the following recipe:
mongodb_instance "test_mongo" do
        port 11111
        dbpath "/mongo_data"
end

Running this recipe made following:
Created /etc/sysconfig/mongodb with content:
#
# Automatically Generated by Chef, do not edit directly!
#

CONFIGFILE="/etc/mongodb.conf"
DAEMON="/usr/bin/$NAME"
DAEMONUSER="mongod"
DAEMON_OPTS="--config /etc/mongodb.conf"
DAEMON_USER="mongod"
ENABLE_MONGO="yes"
ENABLE_MONGOD="yes"
ENABLE_MONGODB="yes"

Created /etc/mongodb.conf with content:
#
# Automatically Generated by Chef, do not edit directly!
#

bind_ip = <IP_ADDRESS>
dbpath = /var/lib/mongodb
fork = true
logappend = true
logpath = /var/log/mongodb/mongodb.log
nojournal = false
pidfilepath = /var/run/mongodb/mongodb.pid
port = 27017
rest = false
smallfiles = false

Created a /etc/init.d/test_mongo with usual content.
Here in the above generated files, the configs that I have mentioned(port and datapath) were not considered.
Also if I run the following recipe with new name test_mongo_new also the same files are created except a new init.d file is created. Other config files were same.
mongodb_instance "test_mongo_new" do
        port 11111
        dbpath "/mongo_data"
end

Is this the intended behaviour?
What is wrong here?

Yes, same here.

I'm adding this to the first bug-fix release (1.1.0) after the 1.0.0 rewrite, as to not make the rewrite an abolsolute slog.
If in the mean time you can rewrite some tests to cover this in inspec that'd be great!


Crossbuild to sbt 2.0.0 + Scala 3

sbt 2.0.0-M2 is available, so we can start cross-building this to 2.0 and add scala3 support.

https://github.com/sbt/sbt-dynver/pull/305 is in flight.

#305 encountered a bunch of test errors, and as far as I know it's been stuck at that state. It would be good if someone wants to take a fresh stab at it to investigate the underlying cause(s).

Fixed in https://github.com/sbt/sbt-dynver/pull/314


Jinja filters not working with Global Async Queries (GAQ)

I have a working installation of superset 0.38. In this I am able to use jinja's filter_values function successfully. While upgrading to version 1.1.0 on my local machine, I used docker-compose to start superset and enabled GAQ.
Expected results
GAQ should work with templates
Actual results
Not able to apply templates along with GAQ. When I remove filter_values function from my query then the chart works fine. Other variables like to_dttm are working fine.
Screenshots

This is error log from celery worker
Working outside of request context.

This typically means that you attempted to use functionality that needed
an active HTTP request.  Consult the documentation on testing for
information about how to avoid this problem.
Traceback (most recent call last):
  File "/app/superset/viz.py", line 534, in get_df_payload
    df = self.get_df(query_obj)
  File "/app/superset/viz.py", line 275, in get_df
    self.results = self.datasource.query(query_obj)
  File "/app/superset/connectors/sqla/models.py", line 1313, in query
    query_str_ext = self.get_query_str_extended(query_obj)
  File "/app/superset/connectors/sqla/models.py", line 772, in get_query_str_extended
    sqlaq = self.get_sqla_query(**query_obj)
  File "/app/superset/connectors/sqla/models.py", line 1040, in get_sqla_query
    tbl = self.get_from_clause(template_processor)
  File "/app/superset/connectors/sqla/models.py", line 800, in get_from_clause
    from_sql = template_processor.process_template(from_sql)
  File "/app/superset/jinja_context.py", line 318, in process_template
    return template.render(context)
  File "/usr/local/lib/python3.7/site-packages/jinja2/environment.py", line 1090, in render
    self.environment.handle_exception()
  File "/usr/local/lib/python3.7/site-packages/jinja2/environment.py", line 832, in handle_exception
    reraise(*rewrite_traceback_stack(source=source))
  File "/usr/local/lib/python3.7/site-packages/jinja2/_compat.py", line 28, in reraise
    raise value.with_traceback(tb)
  File "<template>", line 9, in top-level template code
  File "/usr/local/lib/python3.7/site-packages/jinja2/sandbox.py", line 462, in call
    return __context.call(__obj, *args, **kwargs)
  File "/app/superset/jinja_context.py", line 218, in safe_proxy
    return_value = func(*args, **kwargs)
  File "/app/superset/jinja_context.py", line 86, in filter_values
    form_data, _ = get_form_data()
  File "/app/superset/views/utils.py", line 139, in get_form_data
    if request.is_json and "queries" in request.json
  File "/usr/local/lib/python3.7/site-packages/werkzeug/local.py", line 347, in __getattr__
    return getattr(self._get_current_object(), name)
  File "/usr/local/lib/python3.7/site-packages/werkzeug/local.py", line 306, in _get_current_object
    return self.__local()
  File "/usr/local/lib/python3.7/site-packages/flask/globals.py", line 38, in _lookup_req_object
    raise RuntimeError(_request_ctx_err_msg)
RuntimeError: Working outside of request context.

This typically means that you attempted to use functionality that needed
an active HTTP request.  Consult the documentation on testing for
information about how to avoid this problem.
[2021-05-24 13:13:48,194: ERROR/MainProcess] Task load_explore_json_into_cache[a5324433-6abd-4d5b-a638-f5d8020ed324] raised unexpected: SupersetVizException("[{'message': 'Working outside of request context.\\n\\nThis typically means that you attempted to use functionality that needed\\nan active HTTP request.  Consult the documentation on testing for\\ninformation about how to avoid this problem.', 'error_type': <SupersetErrorType.VIZ_GET_DF_ERROR: 'VIZ_GET_DF_ERROR'>, 'level': <ErrorLevel.ERROR: 'error'>, 'extra': None}]")
Traceback (most recent call last):
  File "/usr/local/lib/python3.7/site-packages/celery/app/trace.py", line 412, in trace_task
    R = retval = fun(*args, **kwargs)
  File "/app/superset/app.py", line 116, in __call__
    return task_base.__call__(self, *args, **kwargs)
  File "/usr/local/lib/python3.7/site-packages/celery/app/trace.py", line 704, in __protected_call__
    return self.run(*args, **kwargs)
  File "/app/superset/tasks/async_queries.py", line 108, in load_explore_json_into_cache
    raise exc
  File "/app/superset/tasks/async_queries.py", line 86, in load_explore_json_into_cache
    raise SupersetVizException(errors=payload["errors"])
superset.exceptions.SupersetVizException: [{'message': 'Working outside of request context.\n\nThis typically means that you attempted to use functionality that needed\nan active HTTP request.  Consult the documentation on testing for\ninformation about how to avoid this problem.', 'error_type': <SupersetErrorType.VIZ_GET_DF_ERROR: 'VIZ_GET_DF_ERROR'>, 'level': <ErrorLevel.ERROR: 'error'>, 'extra': None}]

How to reproduce the bug

Enable GAQ.
Use filter_values function in sql template
It will result in error in celery worker container.

Environment
(please complete the following information):

superset version:  1.1.0
python version: 3.7.9
node.js version: 14

Checklist
Make sure to follow these steps before submitting your issue - thank you!

[x] I have checked the superset logs for python stacktraces and included it here as text if there are any.
[x] I have reproduced the issue with at least the latest released version of superset.
[x] I have checked the issue tracker for the same issue and I haven't found one similar.

Additional context
Add any other context about the problem here.

@robdiciuccio 🙏

Hi @robdiciuccio,  I have some requirements coming up that requires custom jinja macros to be used in sql. Any idea on timeline for the fix?

@robdiciuccio Any updates on this issue? I'm trying to use filter_values with GAQ enabled and seeing the same error.

I'll be looking into this in the next few days. PRs welcome in the meantime!

@himanshugarg574 @ramyarajasekaran can you please test this PR to see if the issue is resolved? https://github.com/apache/superset/pull/16412


How can I use the translation in the _document.tsx? (I'm using the custom server for SSR)

Hi guys,
How can I use the translation in the _document.tsx? I would like use the translation in the meta tags and open graph tags like description and title tags.
Thanks so much!

Internals pages as _app.js and _document.js are not involved with translations for now. There is an open issue for this: https://github.com/vinissimus/next-translate/issues/44
Maybe documentLang can help you, and depending on the language load one locale or another. The problem is that you need to import the JSONs for all the languages, but you can use a small JSON for just the _document.js. Something like:
import Document, { Html, Head, Main, NextScript } from 'next/document'
import documentLang from 'next-translate/documentLang'
import useTranslation from 'next-translate/useTranslation'
import I18nProvider from 'next-translate/I18nProvider'

import metainfoES from '../../locales/es/metainfo.json'
import metainfoEN from '../../locales/en/metainfo.json'

const namespaces = {
   es: metainfoES,
   en: metainfoEN,
}

export default class MyDocument extends Document {
  render() {
    const lang = documentLang(this.props)

    return (
      <Html lang={lang}>
        <I18nProvider lang={lang} namespaces={{ metainfo: namespaces[lang] }}>
           <CustomHead />
        </I18nProvider>
        <body>
          <Main />
          <NextScript />
        </body>
      </Html>
    )
  }
}

function CustomHead() {
  const { t } = useTranslation()
  const title = t`metainfo:title`
  const description = t`metainfo:description`

   return (
       <Head>
          <title>{title}</title>
          <meta name="description" content={description} />
      </Head>
  )
}

Thanks so much!

Cool, if this solves your problems, I'll close the issue, as there is already another one to better address the issue of translations in internal pages of next.js such as _app.js and _document.js.

Hello @aralroca, I am having the same issue. I would like to use and update the language in _document.tsx for HTML as soon as the user choose a new language.
I have trying using the documentLang and the cookies but don't thinks it's optimal. What is your idea for this?
Thanks a lot

@nathanguillaumin During the i18n routing the HTML lang is automatically handled.

@aralroca Thanks. How would you make it?
I am trying getting the lang with const { lang } = this.props.i18n; and then englobing my export as:
export default withTranslation(Document);
But get an error: TypeError: Document.renderDocument is not a function
Thanks a lot for your help

I meant that there is no need to do the <Html lang={documentLang()}> because the lang is already automatically placed inside the HTML tag.


'On Hold' status not available when a request is in a status of 'Response'

Describe the bug in current situation
When a request is in a status of 'Response', you are unable to change the request status to 'On Hold'.
Link bug to the User Story
User Story # 2691, Scenario 1
Impact of this bug
Describe the impact, i.e. what the impact is, and number of users impacted.
Medium
Chance of Occurring (high/medium/low/very low)
Medium
Pre Conditions: which Env, any pre-requesites or assumptions to execute steps?
TEST environment
Logged in with IAO analyst role
Request is in a status of 'Response'
A balance is remaining to be paid for the request (as noted on the CFR form).
Steps to Reproduce
Steps to reproduce the behavior:

Go to a request (in the TEST environment) which is in a status of 'Response', and there is balance remaining (or create a new one)
In the left nav, click the status field (which should be in a status of 'Response')
The status options of 'Response', 'Records Review' and 'Closed' are available to select, but 'On Hold' is not

Actual/ observed behaviour/ results
GIVEN an applicant owes a balance for their processing fees
AND the request state in Response
WHEN the IAO analyst clicks the state dropdown
THEN the On Hold status is not an option
Expected behaviour
GIVEN an applicant owes a balance for their processing fees
AND the request state in Response
WHEN the IAO analyst clicks the state dropdown
THEN On Hold will be an option
Screenshots/ Visual Reference/ Source

Hi @KyEggleston , could you please share the request number? The only condition written to show On Hold in the list is,

approved CFR form
balanceRemaining > 0

@divyav-aot - an example request in TEST would be - EDU-2022-00057. But the 'On Hold' button now appears for this request when it is in a 'Response' status.
If this was just recently fixed (prior to me commenting) feel free to drop this into Ready for QA pipeline and I can see if I find any edge cases on Monday.
Thanks!

@KyEggleston - we haven't pushed any changes. Could you please cross verify the request you were facing issue. May be the condition was not meeting.

@divyav-aot - I just gave this another test in TEST on EDU-2022-09812, and in TEST-Marshal on MMA-2022-662277, and the 'On Hold' status was an available option when the record is in a 'Response' status and balanceRemaining > 0. Therefore, I think this must have been my mistake (perhaps I forgot to confirm there was a balance remaining).
I will close this ticket, as I don't believe there is any bug, and it was likely due to me missing a precondition.


feat(@schematics/angular): generate new projects with tslint 6.1.0

tslint 6.1 adds support for TypeScript 3.8 syntax
See: https://github.com/palantir/tslint/blob/master/CHANGELOG.md#v610
Pr to update the package in the repo https://github.com/angular/angular-cli/pull/17202
See individual commits for more details.

A number of recommended rules have been removed in version 6, Should we add them in our tslint.json or not?
https://github.com/palantir/tslint/pull/4871/files and https://github.com/palantir/tslint/pull/4312/files

Discussed whether to preserve existing configs from previous version or accept new changes from TSLint.
New projects should include the new version and have a custom config with all the old rules from the previous TSLint version.
Existing projects in 9.x should have a migration allowing users to update to TSLint 6.1 if they choose to and include the old rules into their config.
In v10 we would enable the migration for everyone, need to consider how this works with Prettier as well.
This will prevent projects from backsliding on formatting. Once we get to ESLint migration, we can revisit how to best make that happen.

@alan-agius4 Thank you for considering my proposition!
I just reviewed the updated rules and it looks good to me, except one tiny nit: variable-name has been relaxed and now allows names with a leading underscore, whereas it wasn't previously.
So to be stricly similar to what we had, I think the CLI tslint should include:
    "variable-name": {
        "options": ["ban-keywords", "check-format", "allow-pascal-case"],
    },

@clydin PTAL


Updated code collation

Pull Request Test Coverage Report for Build 293

2 of 3 (66.67%) changed or added relevant lines in 3 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 90.211%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/main/java/seedu/address/logic/commands/ListEventCommand.java
0
1
0.0%

Totals

Change from base Build 292:
0.0%

Covered Lines:
2350

Relevant Lines:
2605

💛  - Coveralls


Update Filter, Analytics and Shortcuts items in User Guide

Motivation and context

This PR contains update of the text and images of the Filter, Analytics and Shortcuts items.
Hint section contents moved to Shortcuts section.
How has this been tested?

N/A
Checklist

[x] I submit my changes into the develop branch
[ ] I have added description of my changes into CHANGELOG file
[x] I have updated the documentation accordingly
[ ] I have added tests to cover my changes
[x] I have linked related issues (read github docs)
[ ] I have increased versions of npm packages if it is necessary (cvat-canvas,
cvat-core, cvat-data and cvat-ui)

License

[x] I submit my code changes under the same MIT License that covers the project.
Feel free to contact the maintainers if that's a concern.
[x] I have updated the license header for each file (see an example below)

# Copyright (C) 2020 Intel Corporation
#
# SPDX-License-Identifier: MIT

Pull Request Test Coverage Report for Build 5341

0 of 0   changed or added relevant lines in 0 files are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage decreased (-0.009%) to 65.668%

Files with Coverage Reduction
New Missed Lines
%

datumaro/datumaro/components/extractor.py
1
90.59%

Totals

Change from base Build 5337:
-0.009%

Covered Lines:
10838

Relevant Lines:
16101

💛  - Coveralls


Feat: Implement EnumerableSet (#242)

Summary
Implemented EnumerableSet, a data structure that is used throughout the project.
Also added basic test cases.
Background
EnumerableSet is used in many places in GMX v2 code but its implementation is not available yet in Cairo. We should have our own implementation of it.
Solidity implementation: https://github.com/OpenZeppelin/openzeppelin-contracts/blob/master/contracts/utils/structs/EnumerableSet.sol
Version control
Cairo - 2.2.0
Scarb - 0.7.0

Very clean :fire:
Could you just run scarb fmt to fix checks ?

Updated!