should eq vs should cmp

Hi,
I'm running Inspec 3.7.11 with Iggy 0.4.0  against AWS resources and a local terraform(0.11.11) state file.  I've found that the Inspec Iggy control file generated has 'should eq' for resources where that's needed. However, running that file has a lot of failures.
Is this a 'feature' of this version of Inspec 3.0 and this version of Iggy?  Is this is problem?
Apologies, I'm really new to Inspec and Iggy, so I'm not sure what the 'right' behaviour should be. Maybe 'should eq' is better than 'should cmp' and I'm missing trick?
Simon

In order to resolve this particular issue for me, I changed the file:
.inspec/gems/2.5.0/gems/inspec-iggy-0.4.0/lib/inspec-iggy/terraform/parser.rb
changing the entry from:
describe.add_test(attr, 'eq', value)
to
describe.add_test(attr, 'cmp', value)
Now I'm just left with the aws_route_table issue.

Thanks! The 'eq' is probably overly picky, I'll switch to 'cmp'. I'll include this update in the upcoming 0.5.0 release.


{variable} in url_pattern path

According to the documentation variables are used in v3 for query string  mandatories. In config v2 it was possbile to add variables in the path of an url_pattern.
v3
{
    "endpoints":[
        {
            "endpoint":"/rest/v1/{param}",
            "output_encoding":"json",
            "backend":[
                {
                    "url_pattern":"/?q={param}",
                    "host":[
                        "http://goji_rest:3000"
                    ]
                }
            ],
            "method":"GET",
            "extra_config":{}
        }
    ]
}

There are examples for v2 configurations with variables injected in url_patterns.
v2
{
    "endpoints":[
        {
            "endpoint":"/rest/v1/{param}",
            "output_encoding":"json",
            "backend":[
                {
                    "url_pattern":"/{param}",
                    "host":[
                        "http://goji_rest:3000"
                    ]
                }
            ],
            "method":"GET",
            "extra_config":{}
        }
    ]
}

This behaviour would be helpful with PostgREST. I could also use kong as API gate. I prefer to use krakend

NVM seems my krakend has parsing problems with my test backend


Usage with tokio

First off, the project looks awesome! I'm currently using mysql_async with tokio and not completely satisfied. I'd love to give this crate a try, but I saw you're using async_std. My question is: how much do you rely on it?
I would like to keep everything running on a single threadpool which I can control. I'm using other libraries bound to tokio, so I can't switch over. Would it be possible to decouple from async_std or perhaps provide some feature flags to support tokio aswell? Again, it depends on what functionality you're using it for.

We went with async-std because we wanted to use this lib in web apps built with Tide, which is now also on async-std.
It would probably be a pretty major refactor to support Tokio. We use async_std quite heavily. If they were Cargo features we would have to treat them as mutually exclusive which is an antipattern, and it would require spewing #[cfg(all(feature = "async-std", not(feature = "tokio")))] and vice versa all throughout the code, which is not an exciting prospect.
Tokio also doesn't have an MPMC + FIFO channel which Pool uses in its RAII implementation for connections (to release them back to the pool), but we could probably find a replacement for that.
We also want to use async_native_tls for supporting secured connections, the API of which is based on the I/O traits from futures, which async-std uses but Tokio doesn't.

I agree that it's not desirable to have a large amount of feature gated code. Perhaps we can list the specific features you require from async_std and see when any runtime independent alternatives become available. The split between tokio and async_std is unfortunate, I hope there will be some abstraction over runtimes soon.

Specifically we require the MPMC channels for our Pool implementation. See https://github.com/launchbadge/sqlx/blob/master/sqlx-core/src/pool/inner.rs#L26

Note that I believe we're okay with accepting a PR here but at the same time I know that I'm not going to spend any time on this due to a massive list of other things I'd like to see SQLx have that I find more interesting to work on.
For anyone interested though, I would expect two cargo feature flags, runtime-async-std and runtime-tokio with the former on-by-default ( for ease-of-use ). I would additionally expect an explicit compile error raised from the crate root if both features are on-by-default.

@mehcode the mpmc issue is easily fixed by using crossbeam, it has mpmc channels that are  stdlib API-compatible and have better performance than std::mpsc to boot.

Ah. I'm not aware of any channels (MPSC or otherwise) that are built on top of async infrastructure.


Inconsistent behaviour in the Authentication workflow due to background /auth/token API calls

The Authentication workflow of Nhost SDK is not found stable due to background API calls which stores refresh token and token expiry time in localstorage.
Once logged-in using nhost.auth.signIn function, the token gets expired in few minutes and the self called token api does not help to get the new token.
Also, when trying to login again, the SDK shows this info in console {message: 'User is already signed in', status: 100} and the login function never gets called.
Only after clearing localstorage manually and refreshing the page, it allows to call the login function.
All other function (signup) stops working and throws the same info in console if login is failed.
I've added a screen recording of the whole scenario explained above which will help to understand it better.
https://www.awesomescreenshot.com/video/8364543?key=6d34d3f6ae94d9442a67bbda9364ee7c

Hello Diksha,
Thanks for your message.
The first part or our issue (token refresh) is most likely related to this issue.
I watched your screen recording, which action your 'logout' button is calling? Is it calling nhost.auth.signOut()?
The login status is not determined by the presence or absence of the refresh token in localstorage, but is held in memory. The refresh token is persisted so it can be reused when opening a new page.

Hi @plmercereau ,
Yes the 'logout' button is using nhost.auth.signOut().
Are you stating that we should use the refreshToken (stored by /token API called in the background by Nhost SDK) to get the new access token every 2 minute around?
The /token API is using the new refreshToken and fetching the access token with other data but we are not able to access that response as we are not handling the call.

When setting the autoRefreshToken option of the NhostClient to true, which is its default value, the client is supposed to refresh the token automatically and keep an up-to-date access token (JWT) in memory.
In general terms, you shouldn't do any direct API call when using the SDK.
The access token is available through nhost.auth.getAccessToken(), or you can also listen to its changes through
nhost.auth.onTokenChanged((session) => {
  console.log(session?.accessToken)
})

I cannot reproduce your bug, if you could give more information about your setup, or even better the code or your project, that would help.
Side note: the access token (the JWT) should never be persisted in local storage for security reasons. When loading the page, the Nhost client is checking if there is a refresh token in the local storage and gets a new JWT with it on startup.

Now I'm able to understand the workflow how Nhost is treating and handling tokens.
One more question I have here is using nhost.auth.signOut() on logout do clear the localstorage but accessToken still exist in memory when tried nhost.auth.getAccessToken() to get the token.
Is this correct?

After running signOut() the access token is destroyed, so it shouldn't be available anymore through getAccessToken().
I found a bug thanks to your attention, it will be corrected in this PR https://github.com/nhost/nhost/pull/440
Thanks!

Hi @plmercereau could you help me understand/integrate social provider (Google / Facebook) login workflow?
I've integrated the v1 feature in my portal however in v2 the redirection has changed to /#refreshToken instead of ?refreshToken=XXX.
Is this handled by SDK? if yes then how to redirect to dashboard once it is successfully logged-In using Google?

Hello Diksha,
Yes, the refresh token is sent as part of the hash (#) instead of the search params (?), mainly for security as hashes are not transferred back to the server.
When creating the NhostClient, there is an option named autoSignIn which defaults to true. It looks for the refresh token in the url, and if the refreshToken is present in the hash, il will try to authenticate with it.
As a result, if a valid refresh token is in the hash, the user will be automatically signed in.
About how to capture the authentication state:

documentation when using React
documentation when using Vanilla

@plmercereau  The /token API is getting called using refresh token from the URL however the refresh token never gets authenticated and the 'isAuthenticated' value is always false when trying to login with social provider (Google/Facebook).
Direct login works as expected.
I see that you have pushed the fix for SignOut bug. Is it in a new version? I pulled the latest of @nhost/react and @nhost/nhost and still the issue of signOut remains as is for me. Am I missing something?

@plmercereau Did you see my comment above? Any clarity on that?

I'm still not getting the flow. I'm also experiencing this one: "User is already signed in". When using the .signOut() it doesn't destroy the tokens that were saved in the local storage. What is the proper flow if you want to really logout a user?
By the way, I'm handling my own localstorage variables like isLoggedIn because of this issue. Coz last time I used .getAuthenticationStatus() but cannot seem to implement properly when using Svelte. That's why I decided to create my own check locally. But the .signOut() is not "working" as well.


Webpack's parser error

Here is my sample project https://github.com/chicoxyzzy/real-world-react/tree/webpack (notice webpack branch)
When I run webpack I get error
ERROR in ./~/core-js/library.js
Module parse failed: /PATH_TO_MY_TEST_APP/node_modules/6to5-loader/index.js?optional=coreAliasing!/PATH_TO_MY_TEST_APP/node_modules/core-js/library.js Line 1149: Unexpected token .
You may need an appropriate loader to handle this file type.
|   // ES6 promises shim
|   // Based on https://github.com/getify/native-promise-only/
|   !(function (_core.Promise, test) {
|     isFunction(_core.Promise) && isFunction(_core.Promise.resolve) && _core.Promise.resolve(test = new _core.Promise(function () {})) == test || (function (asap, DEF) {
|       function isThenable(o) {
 @ ./src/index.js 7:28-54

source file comes to Esprima parser already broken. As you can see function parameter has comma in it

!(function (_core.Promise, test) { You can't have a . dot in a function definition's parameters.

Looks like a 6to5 bug...

6to5 works great with browserify (you can check master branch of my repo)
also I came here from 6to5's issue where @sebmck said it might be webpack's issue

@sokra The parser error is not coming from 6to5.

@sebmck The error isn't, but 6to5 generates invalid javascript
> to5.transform("!(function(Promise) {}())", {optional: ["coreAliasing"]}).code

returns
"use strict";

var _interopRequire = function (obj) {
  return obj && (obj["default"] || obj);
};

var _core = _interopRequire(require("core-js/library"));

!(function (_core.Promise) {})();

The last line is invalid javascript.

@sokra Oh right, I didn't read the syntax error properly, sorry! Fixed in 2.12.2. We weren't taking into account function parameters when checking if an identifier was referenced.

@sokra Oh right, I didn't read the syntax error properly, sorry! Fixed in 2.12.2. We weren't taking into account function parameters when checking if an identifier was referenced.

:smile:


try to fix racetest in nodeagent cache

https://github.com/istio/istio/issues/7517

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: quanjielin
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: diemtvu
If they are not already assigned, you can assign the PR to them by writing /assign @diemtvu in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

security/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

/cc @wattli @ostromart

I think error put in https://github.com/istio/istio/issues/7517 was fixed by this PR, to be safe, we may still need to monitor future test run for a while to make sure no other issues fails racetest.

You can also re-run the racetest from CircleCI several times to verify.

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: quanjielin, wattli
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

security/OWNERS [wattli]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


Fix build docs for non unix

Fix error found on building docs in https://github.com/gtk-rs/gdk/pull/194

:+1:

CI passed


Is there a way to show the current language automatically?

As stated. Many code highlighters are able to show the language of the block as an overlay. I've looked through the docs but I can't find such an option.
I'm using astro-extressive-code.

Hello and welcome!
Would this plugin solve your use case?
https://github.com/expressive-code/expressive-code/issues/153#issuecomment-2282218684

Thanks, I will give it a go and see if it works.


HTML code help

Hey. I apologize in advance for bad English.
I need to understand how you can call question bubbles and answer bubbles as easy as possible for example test ("123", question)
I plan to connect to the entire project ai speech kit. Unfortunately there is not enough knowledge to understand how to manually call tiles from html code.

What do you mean by "how to manually call tiles from html code" please?

The usual way to call any question/answer bubbles is with "chatWindow.talk(convo)".
Where "convo" is the conversation (which can be as simple as one question and one answer option).
Note that a "convo" is an data object. So, there is no thing as a single method "say("Hi are you?", question)".
The sample code in the quick start section gives a good impression what a very simple conversation would look like.
A most easy way would be probably:
chatWindow.talk(
{"ice": {"says": [ "How are you?" ],
      "reply" : [{"question" : "Good.",
          "answer" : "good"}]}
})

To connect with AI in the background you need to do a little more. Look at the code of example-3 to get an idea how keyboard input is processed.

Looks like this is solved, thank you Jens!


Button images do not work on Safari

@neoformit

:eyes:

Resolved with https://github.com/usegalaxy-au/galaxy-labs-engine/pull/17


Notification system

full feature branch

@dortheimer this is a WIP branch and very far from completion, not ready yet for review

Sure, but I think that some of my comments could have value for you going on.

Sure thing. very welcome to write comments (:

@dortheimer  here is the spec out of Notification feature: https://docs.google.com/document/d/1Y3a2hF48-8jCoN20y0eDtfQkkDnuwWHEbp4fdxYp4uI/edit?usp=sharing
I think it will answer some of your questions, feel free to comment if anything is not clear

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.2 out of 4 committers have signed the CLA.:white_check_mark: dortheimer:white_check_mark: jbesraa:x: TomerMe2:x: florporYou have signed the CLA already but the status is still pending? Let us recheck it.

@florpor  the problem with the crawler: geom = ST_GeomFromGeoJSON('{"type":"Polygon","coordinates":[[],[],[],[],[],[],[],[],[],[],[],[],[],[],[],[],[],[],[],[],[],[],[],[],[],[],[],[],[],[],[],[],[],[],[],[],[],[],[],[],[],[],[],[],[],[],[],[],[],[],[],[],[],[],[],[],[],[],[],[],[],[],[],[],[],[],[],[],[],[],[],[],[],[],[],[],[],[],[],[],[],[],[],[],[],[],[],[],[],[],[],[],[],[],[],[],[],[],[],[],[],[],[],[],[],[],[],[],[],[],[],[],[],[],[],[],[],[],[],[],[],[],[],[],[],[],[],[],[],[],[],[],[],[],[],[],[],[],[],[],[],[],[],[],[],[],[],[],[],[],[],[],[],[],[],[],[],[],[],[],[],[],[],[],[],[],[],[],[],[],[],[],[],[],[],[],[],[],[],[],[],[],[],[],[],[],[],[],[],[],[],[],[],[],[],[],[],[],[],[],[],[],[],[],[],[],[],[],[],[],[],[],[],[],[],[],[],[],[],[],[],[],[],[],[]]}')
the coordinates after parsing are empty. if you remove the guards(all line in line 38 and el.length > 0 in line 56) that I added in the parsing file(bookshelf-mysql-gis.js), you will get a different error.

@florpor this is good to go.
one thing we should check in order to make sure its working on production is the fact that we added new properties to some old tables(plan, person..),so maybe we need to do some migration. do we have staging env that we can test stuff on before we go to prod?

@florpor all of the above visited and fixed.
side note: Github actions are probably the worst CI I worked with. keep crashing for no reason. I strongly recommend to move to circleci/travis/.. something else
so sad that micr****t is ruining github ):

all green (:

@jbesraa great. see the two notes about geojson-validation and person status field, and also please add the new migration file(s?) to the pr

[ ] geojson validation
[ ] person status
[ ] migrations

@jbesraa i see that the static modifier of person's rules function simply makes it not be checked and so it works.. ☉ ‿ ⚆
i'll fix that another time and reinstate the skipped test.
is this pr ready to be merged?

@florpor yea the static basically makes the rules function irrelevant. I think it also emphasis the problematic structure that the DB have.
atm we have 4 sources of 'truth' regarding the db: 1) the db it self 2) migration files 3) bookshelf setup 4) test structs. that can make things very tricky in the (near) future
yea PR is ready. should I merge it and u can test it on staging?


:white_check_mark: Test: state unit tests

Description
Concise description of proposed changes
Testing
Explain the quality checks that have been done on the code changes
Additional Information

[ ] I read the contributing docs (if this is your first contribution)

Your ENS/address:

#1327  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @roninjin10 and the rest of your teammates on  Graphite


fix(root): implemented icon variant for back to top component

Added functionality that changes the variant of the back-to-top component based on the size of the device screen
Checklist

[ ] I have manually accessibility tested any changes, if relevant.
[X] I have raised this pull request against the develop branch

PR now stale.


Fix consistency of test dependencies

I've noticed that both flutter_test and test are used in the project. Usually, it's only required to use one of these packages, (since flutter_test uses test as it's core) and if they're both used at the same time, they may cause conflicts. It would be good to do a dependency cleanup for tests and leave only one of those
┆Issue is synchronized with this Jira Uncategorised by Unito

Closing this as a duplicate of #397


ID Token Read-only Permissions

What is the improvement or update you wish to see?
The Liveblocks read-only permissions example here: https://liveblocks.io/docs/rooms/permissions/id-token#permissions-levels-groups-accesses-example is a bit unclear.
Is there any context that might help us understand?
When I attempted to just pass in ["room:read"] as the array, I kept getting an exception. This leads me to believe that there's some validation that requires that ["room:presence:write"] be present in the permissions array if the type is "READ". A clarification here would be really helpful.

Hey! The reason for this is that presence in the room is always writable (because presence is like an individual sandbox for each user, so it can always be changed). Specifying just room:read, permissions, might be ambiguous as it may falsely suggest that it would also set presence to read-only, which is not the case (and would also not make sense). That’s why we ask to be explicit and specify room:presence:write at the minimum, so that potential confusion is avoided. Hope this helps!


it doesn't work in electron

I can run your demo normally
But when I run it in the electron main thread
import ActiveWindow, { WindowInfo } from '@paymoapp/active-window'
app.whenReady().then(() => {
  ActiveWindow.initialize({ osxRunLoop: true })
  ActiveWindow.requestPermissions()
})

(node:56708) UnhandledPromiseRejectionWarning: TypeError: ActiveWindow.initialize is not a function

Hi! Could you please provide a minimal reproducible example?
A git repo with your setup would be sufficient only containing your build setup and electron main.
It is probably some kind bundling error. If you use vite (or webpack or anything else), you have to explicitly exclude the library from the bundle (since it contains native code that should be loaded directly by node). To do this in vite for example you have to define the library as an external module (build.rollupOptions.external).
Also: Since you're using electron (and hence have a GUI window on the main thread with a working runloop), you can omit the osxRunLoop parameter (see: https://github.com/paymoapp/node-active-window#𝑓--initialize)

Thank you for your reply. I do use Vite. I will try it again based on your suggestion. If there are still any problems, I will report back.

Hi! Could you please provide a minimal reproducible example? A git repo with your setup would be sufficient only containing your build setup and electron main.
It is probably some kind bundling error. If you use vite (or webpack or anything else), you have to explicitly exclude the library from the bundle (since it contains native code that should be loaded directly by node). To do this in vite for example you have to define the library as an external module (build.rollupOptions.external).
Also: Since you're using electron (and hence have a GUI window on the main thread with a working runloop), you can omit the osxRunLoop parameter (see: https://github.com/paymoapp/node-active-window#𝑓--initialize)

minimal reproducible example:
https://github.com/ChurchTao/electron-active-window-demo
I tried again, and it really didn’t work. It seemed like the method was exported to npm incorrectly, and the real method could not be referenced.

When I click on the method in the compiled js, I cannot jump to the actual calling location.

I had some time to check out your repo and found the problem. There is a problem with esbuild (the bundler used by vite) about how it handles the default imports of CJS modules.
The library was accessible in your case, but you would have to use ActiveWindow.default.initialize() because of this.
To fix this, you have to go to your vite config and in the main section you have to add build.rollupOptions.output.interop = 'auto'.
I've updated the config you provided in your example repo:
import { resolve } from 'path'
import { defineConfig, externalizeDepsPlugin } from 'electron-vite'
import react from '@vitejs/plugin-react'

export default defineConfig({
  main: {
    plugins: [externalizeDepsPlugin()],
    build: {
      rollupOptions: {
        output: {
          interop: 'auto'
        }
      }
    }
  },
  preload: {
    plugins: [externalizeDepsPlugin()]
  },
  renderer: {
    resolve: {
      alias: {
        '@renderer': resolve('src/renderer/src')
      }
    },
    plugins: [react()]
  }
})

For more info see: https://rollupjs.org/configuration-options/#output-interop


Nws v4

Swapped preview image link for correct one (was not rendering in Workbench). Added to readme.

PR no longer applicable. Submitting up-to-date PR shortly.


expmeter_mean_winsor and expmeter_rms_winsor undefined in catch exception

https://github.com/RvSpectML/EchelleInstruments.jl/blob/98d5a94f72a863b2cd97cb0b582265e3d4dca96b/src/neid/io.jl#L146-L152

Fixed in fd41a59a


Cow: Watch hostnoc.com

Cow requests the watch of the watch_keyword hostnoc\.com. See the MS search here and the Stack Exchange search in text, in URLs, and in code.

hostnoc\.com has been seen in 1 true positive, 0 false positives, and 0 NAAs.

Approved by Jeff Schaller in Charcoal HQ


Fail to connect to RTSP server when SETUP message already has session ID

Client generate random session ID and use it to communicate with server
Test with other server success, but fail on this server.
Setup command like belowing:
SETUP rtsp://<IP_ADDRESS>:8554/mystream/trackID=0 RTSP/1.0
Transport: RTP/AVP/TCP;unicast;interleaved=0-1;mode=record
CSeq: 2
User-Agent: ESP32-RTSP-client 1.1.0
Session: 2494844

Server report:
2024/03/18 17:28:45 INF [RTSP] [conn <IP_ADDRESS>:49469] closed: connection is linked to another session

As spec show that
   The server generates session identifiers in response to SETUP
   requests. If a SETUP request to a server includes a session
   identifier, the server MUST bundle this setup request into the
   existing session or return error "459 Aggregate Operation Not
   Allowed" (see Section 11.3.10).

I think need memorize client session ID and build a map between client session ID and server session ID.

Hello, as mentioned in the specification, it's the server responsibility to generate a session ID, therefore, you shouldn't generate a random session ID on client side but use the one provided to you by the server.
Allowing the generation of session IDs on client side would generate a security issue since the cryptographic strength of those session IDs would vary depending on the client.


add legend

At first glance, its unclear what I'm looking at.
Include a legend for your default layers: population density and bike lanes. What do the colors mean?

Look for inspiration for a legend within this Leaflet tutorial.

I think I'll lead the coding team on Tuesday to pick this one up.

@rguico are we planning to add legend as a part of the map, or just a documentation ? what I was thinking is a way to make a static legend image, and then find a way to put that image in the map. what do you think.

Syed - we want to use http://leafletjs.com/examples/choropleth.html but
tonight we worked to generate a GeoJSON file that we can refer to as a
source for that map.
A dynamic solution would be nice because we can reuse it when we start
putting out other layers besides population density.
-Robert
On Tue, Mar 17, 2015 at 8:04 PM, SyedSufyan<EMAIL_ADDRESS>wrote:

@rguico https://github.com/rguico are we planning to add legend as a
part of the map, or just a documentation ? what I was thinking is a way to
make a static legend image, and then find a way to put that image in the
map. what do you think.
—
Reply to this email directly or view it on GitHub
https://github.com/zorostang/chicago_bike_equity/issues/6#issuecomment-82662456
.

@rguico sounds good, see ya guys next week, and finish this thing up :)

This is the wrong legend to add. We will be adding a different legend through another issue using @rguico's chloropleth map.


Add sudermanjr repository

The Artifact Hub is another place you can list your repos. To do that, you login (or create an account), create an organization, and list your repository. You can link it to a user or organization.

The Artifact Hub is another place you can list your repos. To do that, you login (or create an account), create an organization, and list your repository. You can link it to a user or organization.

Thanks. I'll check it out.


Enhancement: Add run.exe - a simple startup script tailored for Windows users

Currently, only run.sh exists, which is a pain to get running on Windows.
We see a need for a complementary run.exe file, to make DollarBot more accessible for Windows stakeholders.

Can we mark this as future work?

Closing after marking as future work


Fix blob attachment variable in getThreadHistory

Fixes #635

Thanks! (Would have merged sooner but was out of town for the week and didn't see)


WebSockets follow up

Websocket client was upgraded per #516. Lots of discussion there about minor follow ups and design improvements. Let's do the followup and capture the rest in the ADR:

[x] Test it with transactions / ensure its working for the ibc relayer
[x] Simplify/reduce number of features - #569
[ ] Send pings (keepalive) - https://github.com/informalsystems/tendermint-rs/pull/516#discussion_r488887940
Update ADR:

[x] Add concurrency diagram to clarify current concurrency model and how the components communicate with one another
[x] Clarify the pending states - https://github.com/informalsystems/tendermint-rs/pull/516#discussion_r488332911
[x] Add notes about possible alternative/future approaches to concurrency model eg.

Dropping the extra terminate channel and just using the cmd channel to communicate unsubsrciptions - https://github.com/informalsystems/tendermint-rs/pull/516#discussion_r488884183 - Implemented in #569!

[ ] Possibly eliminate async/await from the core, use a synchronous websocket with read/write routines, and wrap it in an async API for consumers that need it - https://github.com/informalsystems/tendermint-rs/pull/516#discussion_r488892954

ADR updates addressed in #576 but see https://github.com/informalsystems/tendermint-rs/pull/576#discussion_r493159561 re the need for pending.

Closing for https://github.com/informalsystems/tendermint-rs/issues/590 and #582


Unable to connect from Mac to Linux VPN server via L2TP

Prerequisites

[x] Can you reproduce?
[x] Are you running the latest version of SoftEtherVPN?

SoftEther version: softether-vpnserver-v4.41-9787-rtm-2023.03.14-linux-x64-64bit.tar.gz
Component: Server
Operating system: CentOS 7
Architecture: 64 bit
Description
Connect to VPN server from Mac OS
Expected behavior:
Connect success
Actual behavior:
Unable to connect
/var/log/ppp.log
publish_entry SCDSet() failed: Success!
publish_entry SCDSet() failed: Success!
l2tp_get_router_address
l2tp_get_router_address ***.***.***.*** from dict 1
L2TP connecting to server '**********' (************)...
IPSec connection started
L2TP error sending Hello (Connection refused)
Failed to send L2TP hello trigger. tried 6, max 10
L2TP error sending Hello (Connection refused)
Failed to send L2TP hello trigger. tried 10, max 10
L2TP error sending Hello (Connection refused)
Failed to send L2TP hello trigger. tried 4, max 10
IPSec connection failed

Steps to reproduce

Download source source code from download site
Extract source code and install into Cent OS 7 server
Start VPN server
Open VPN settings and setup server
Connect from Mac OS

I am also experiencing issues when connecting to the VPN server with Mac Bug Sur (11.6) when following this guide :
https://www.softether.org/4-docs/2-howto/9.L2TPIPsec_Setup_Guide_for_SoftEther_VPN_Server/5.Mac_OS_X_L2TP_Client_Setup
Example client (verbose) logs:
Fri May 12 18:43:36 2023 : IPSec connection started
Fri May 12 18:43:36 2023 : IPSec phase 1 client started
Fri May 12 18:43:46 2023 : IPSec connection failed
Fri May 12 18:45:59 2023 : publish_entry SCDSet() failed: Success!
Fri May 12 18:45:59 2023 : publish_entry SCDSet() failed: Success!
Fri May 12 18:45:59 2023 : l2tp_get_router_address
Fri May 12 18:45:59 2023 : l2tp_get_router_address <IP_ADDRESS> from dict 1
Fri May 12 18:45:59 2023 : L2TP connecting to server ‘xx.xx.xx.xx’ (xx.xx.xx.xx)...
Fri May 12 18:45:59 2023 : IPSec connection started
Fri May 12 18:45:59 2023 : IPSec phase 1 client started
Fri May 12 18:46:09 2023 : IPSec connection failed
(I can reach IP + port with telnet or similar just fine...)
No issues on Linux/Windows based OS-es ...
Tried various changes and tweaks - same results.

Has this issue been resolved? I am still running into this same issue?


Typing into date inputs types only on the yyyy section.

Trying to record typing into a date field doesn't work for me, it just types on the yyyy section of the date and ends up completely invalid.
What I've had work really well was replacing await page.type(selector, '2020-08-07'); with:
await page.focus(selector);
await page.keyboard.type('20200807');

Would it be within scope of the extension to recognize date inputs and use this alternative instead?

@ric2b thanks for mentioning. I would gladly take a PR that implements this.

Just checking, but since its been several months, is this still open?

Hi @noahsnowc, yes, this is still an open issue.

@ric2b @noahsnowc Hi, we are trying to get back on this.
I am testing this issue and could not reproduce it.
When I click the input and I type (or manually select a date), the value is properly generated.

Am I missing something? If so, can you provide more information/details on this?

@ric2b @noahsnowc Hi, we are trying to get back on this.
I am testing this issue and could not reproduce it.
When I click the input and I type (or manually select a date), the value is properly generated.

Am I missing something? If so, can you provide more information/details on this?

@ianaya89 The recording looks ok, it captures the whole date, but when I replay only the yyyy section is modified, at least on the test form I'm using which is this Google Form.

@ianaya89 The recording looks ok, it captures the whole date, but when I replay only the yyyy section is modified, at least on the test form I'm using which is this Google Form.

looks great
though My chrome just went corrupted qwq

looks great
though My chrome just went corrupted qwq

https://github.com/checkly/headless-recorder/issues/232


[Spark-43284] Switch back to url-encoded strings

What changes were proposed in this pull request?
Update _metadata.file_path and _metadata.file_name to return url-encoded strings, rather than un-encoded strings. This was a regression introduced in Spark 3.4.0.
Why are the changes needed?
This was an inadvertent behavior change.
Does this PR introduce any user-facing change?
Yes, fix regression!
How was this patch tested?
New test added to validate that the file_path and path_name are returned as encoded strings.

FileMetadataStructSuite.metadata struct (json): read partial/all metadata struct fields fails, @databricks-david-lewis

Oof. This is because of the following:
val p1 = new Path("file:///a")
val p2 = new Path("file:/a")
p1 == p2
p1.toString == p2.toString
p1.toUri == p2.toUri
// but...
p1.toUri.toString != p2.toUri.toString  // "file:///a" != "file:/a"

Before any of my changes, we were doing new Path(uriString).toString which would "normalize" the uri string.
Should we do the same here? Seems silly...
I could also update the  test to explicitly pass in file:/... ...
Thoughts @cloud-fan ?

@databricks-david-lewis let's just update the test

Updated @cloud-fan. How do we merge this to the 3.4 branch as well?

thanks, merging to master/3.4!


Share transaction details

Think about what details we can share and what - we can't

https://zpl.io/a3l75RW
https://zpl.io/2jMwm36 - this screen should be an image.
Flow:

user clicks on "share details" https://zpl.io/a3l75RW
generate img the same as on design https://zpl.io/2jMwm36 with transaction details
img can be sent in telegram, mail etc

The ability to share transaction details should be available in the following statuses(transaction stages):

https://app.zeplin.io/project/5b379c2c38cb39e73e5f8889/screen/5d0caf09627ac8566a69540a

Actual:

At the moment we can not correctly specify this information so it should not be displayed. the color background of the picture is supposed to be according to the network(masternet,testnet,mainnet)

checked


The use of HintShardingAlgorithm

Question
Can you give me a complete Java sample code.

I had implemented an one , i found it just as Tenant implemention，i want to know others implementtion too

the document maybe can help you
http://shardingsphere.io/document/current/en/manual/sharding-jdbc/usage/hint/

Thank you for answering my question,Here's my code:
public static DataSource getShardingDataSource(List dataSourcePropertiesList) throws SQLException {
ShardingRuleConfiguration shardingRuleConfig = new ShardingRuleConfiguration();
//shardingRuleConfig.getTableRuleConfigs().add(DebtTableRuleConfiguration.getPlanHintTableRuleConfiguration());
shardingRuleConfig.getTableRuleConfigs().add(DebtTableRuleConfiguration.getPlanTableRuleConfiguration());
shardingRuleConfig.getTableRuleConfigs().add(DebtTableRuleConfiguration.getTermTableRuleConfiguration());
shardingRuleConfig.getTableRuleConfigs().add(DebtTableRuleConfiguration.getEventTableRuleConfiguration());
Map<String, DataSource> dataSourceMap = DruidDataSourceBuider.build(dataSourcePropertiesList);
Map<String, Object> configMap = new HashMap<>(0);
Properties props = new Properties();
props.put("sql.show", true);
return ShardingDataSourceFactory.createDataSource(dataSourceMap, shardingRuleConfig, configMap, props);
}
The comment line 3 is working well, it can't be properly sliced without comment, and it can't force sharding.

the document maybe can help you
http://shardingsphere.io/document/current/en/manual/sharding-jdbc/usage/hint/

Thank you for answering my question,Here's my code:
public static DataSource getShardingDataSource(List dataSourcePropertiesList) throws SQLException {
ShardingRuleConfiguration shardingRuleConfig = new ShardingRuleConfiguration();
//shardingRuleConfig.getTableRuleConfigs().add(DebtTableRuleConfiguration.getPlanHintTableRuleConfiguration());
shardingRuleConfig.getTableRuleConfigs().add(DebtTableRuleConfiguration.getPlanTableRuleConfiguration());
shardingRuleConfig.getTableRuleConfigs().add(DebtTableRuleConfiguration.getTermTableRuleConfiguration());
Map<String, DataSource> dataSourceMap = DruidDataSourceBuider.build(dataSourcePropertiesList);
Map<String, Object> configMap = new HashMap<>(0);
Properties props = new Properties();
props.put("sql.show", true);
return ShardingDataSourceFactory.createDataSource(dataSourceMap, shardingRuleConfig, configMap, props);
}
The comment line 3 is working well, it can't be properly sliced without comment, and it can't force sharding.

I can't get your point. Did you mean but if you don't comment the 3rd line, it works well; if comment the 3rd line, it can't work , is it?

I can't get your point. Did you mean if you don't comment the 3rd line, it works well; but if comment the 3rd line, it can't work , is it?

Yes, line 3 is HintShardingAlgorithm.

I don't understand, if don't comment code is correct, why do you comment it?

I don't understand, if don't comment code is correct, why do you comment it?

sorry，I'm not good at English.Can I use Chinese?
对于同一个表：
只配置ComplexShardingStrategyConfiguration规则能够正确路由到对应的库跟表，
只配置HintShardingStrategyConfiguration规则能够正确路由到对应的库跟表，
如果同时配置ComplexShardingStrategyConfiguration、HintShardingStrategyConfiguration规则，如：
shardingRuleConfig.getTableRuleConfigs().add(HintShardingStrategyConfiguration);
shardingRuleConfig.getTableRuleConfigs().add(ComplexShardingStrategyConfiguration);
则通过HintManager指定库表的查询方式能够正确路由到对应的库跟表，
通过带分片键的查询方式不能够正确路由到对应的库跟表，而是笛卡尔积查询。

For English only, other languages will not accept.

If no response more than 7 days and we cannot reproduce it on current information, we will close it.


Vendor containers/buildah

Pull in fixes to build for single and two line Dockerfiles.
Fixes https://github.com/containers/libpod/issues/2248
Signed-off-by: Urvashi Mohnani<EMAIL_ADDRESS>

bot, retest this please

LGTM
@TomSweeneyRedHat @mheon @baude @vrothberg @giuseppe PTAL

/lgtm

/lgtm

/retry

/lgtm

I just noticed that this PR was not clean. When running make vendor on it, much more things are pulled in. Now, ./vendor/github.com/containers/buildah has files from two different commits.
I will revert this commit in https://github.com/containers/libpod/pull/2259. Once @baude's cobra PR is merged here, we can continue. Otherwise, builds will fail.


Disabling via ALEToggle does not disable ale_fix_on_save setting

VIM version
VIM - Vi IMproved 8.0 (2016 Sep 12, compiled Mar 13 2018 06:36:50)
macOS version
Operating System: macOS High Sierra Version 10.13.3
:ALEInfo

 Current Filetype: ruby
Available Linters: ['brakeman', 'rails_best_practices', 'reek', 'rubocop', 'ruby']
  Enabled Linters: ['brakeman', 'rails_best_practices', 'reek', 'rubocop', 'ruby']
 Linter Variables:

let g:ale_ruby_brakeman_options = ''
let g:ale_ruby_reek_show_context = 0
let g:ale_ruby_reek_show_wiki_link = 0
let g:ale_ruby_rubocop_executable = 'rubocop'
let g:ale_ruby_rubocop_options = ''
let g:ale_ruby_ruby_executable = 'ruby'
 Global Variables:

let g:ale_cache_executable_check_failures = 0
let g:ale_change_sign_column_color = 0
let g:ale_command_wrapper = ''
let g:ale_completion_delay = 100
let g:ale_completion_enabled = 0
let g:ale_completion_max_suggestions = 50
let g:ale_echo_cursor = 1
let g:ale_echo_msg_error_str = 'Error'
let g:ale_echo_msg_format = '%code: %%s'
let g:ale_echo_msg_info_str = 'Info'
let g:ale_echo_msg_warning_str = 'Warning'
let g:ale_enabled = 0
let g:ale_fix_on_save = 1
let g:ale_fixers = {'ruby': ['rubocop'], 'javascript': ['prettier', 'eslint']}
let g:ale_history_enabled = 1
let g:ale_history_log_output = 1
let g:ale_keep_list_window_open = 0
let g:ale_lint_delay = 200
let g:ale_lint_on_enter = 1
let g:ale_lint_on_filetype_changed = 1
let g:ale_lint_on_save = 1
let g:ale_lint_on_text_changed = 'always'
let g:ale_lint_on_insert_leave = 0
let g:ale_linter_aliases = {}
let g:ale_linters = {}
let g:ale_linters_explicit = 0
let g:ale_list_window_size = 10
let g:ale_list_vertical = 0
let g:ale_loclist_msg_format = '%code: %%s'
let g:ale_max_buffer_history_size = 20
let g:ale_max_signs = -1
let g:ale_maximum_file_size = 0
let g:ale_open_list = 0
let g:ale_pattern_options = {}
let g:ale_pattern_options_enabled = 0
let g:ale_set_balloons = 0
let g:ale_set_highlights = 1
let g:ale_set_loclist = 1
let g:ale_set_quickfix = 0
let g:ale_set_signs = 1
let g:ale_sign_column_always = 0
let g:ale_sign_error = '>>'
let g:ale_sign_info = '--'
let g:ale_sign_offset = 1000000
let g:ale_sign_style_error = '>>'
let g:ale_sign_style_warning = '--'
let g:ale_sign_warning = '--'
let g:ale_statusline_format = ['%d error(s)', '%d warning(s)', 'OK']
let g:ale_type_map = {}
let g:ale_warn_about_trailing_blank_lines = 1
let g:ale_warn_about_trailing_whitespace = 1
  Command History:

(executable check - failure) brakeman
(executable check - failure) rails_best_practices
(executable check - failure) reek
(started) ['/bin/bash', '-c', '''rubocop'' --format json --force-exclusion  --stdin ''/Users/dpowers/ab_testing/app/models/ab_test.rb'' < ''/var/folders/6_/rwhgkhd94c56zh4tpxct9ym80000gp/T/vEkVeA1/13/ab_test.rb''']
(started) ['/bin/bash', '-c', '''ruby'' -w -c -T1 ''/var/folders/6_/rwhgkhd94c56zh4tpxct9ym80000gp/T/vEkVeA1/14/ab_test.rb''']
(executable check - failure) brakeman
(executable check - failure) rails_best_practices
(executable check - failure) reek
(started) ['/bin/bash', '-c', '''rubocop'' --format json --force-exclusion  --stdin ''/Users/dpowers/ab_testing/app/models/ab_test.rb'' < ''/var/folders/6_/rwhgkhd94c56zh4tpxct9ym80000gp/T/vEkVeA1/15/ab_test.rb''']
(finished - exit code 0) ['/bin/bash', '-c', '''ruby'' -w -c -T1 ''/var/folders/6_/rwhgkhd94c56zh4tpxct9ym80000gp/T/vEkVeA1/16/ab_test.rb''']

<<<NO OUTPUT RETURNED>>>

(executable check - failure) reek
(finished - exit code 1) ['/bin/bash', '-c', '''rubocop'' --format json --force-exclusion  --stdin ''/Users/dpowers/ab_testing/app/models/ab_test.rb'' < ''/var/folders/6_/rwhgkhd94c56zh4tpxct9ym80000gp/T/vEkVeA1/17/ab_test.rb''']

<<<OUTPUT STARTS>>>
{"metadata":{"rubocop_version":"0.46.0","ruby_engine":"ruby","ruby_version":"2.0.0","ruby_patchlevel":"353","ruby_platform":"x86_64-darwin13.4.0"},"files":[{"path":"app/models/ab_test.rb","offenses":[{"severity":"convention","message":"Missing space after #.","cop_name":"Style/LeadingCommentSpace","corrected":false,"location":{"line":2,"column":1,"length":30}},{"severity":"convention","message":"Class has too many lines. [138/100]","cop_name":"Metrics/ClassLength","corrected":null,"location":{"line":4,"column":1,"length":7721}},{"severity":"convention","message":"Missing top-level class documentation comment.","cop_name":"Style/Documentation","corrected":null,"location":{"line":4,"column":1,"length":5}},{"severity":"convention","message":"Line is too long. [102/80]","cop_name":"Metrics/LineLength","corrected":null,"location":{"line":5,"column":81,"length":22}},{"severity":"convention","message":"Incorrect indentation detected (column 0 instead of 2).","cop_name":"Style/CommentIndentation","corrected":false,"location":{"line":15,"column":1,"length":79}},{"severity":"convention","message":"Use the new Ruby 1.9 hash syntax.","cop_name":"Style/HashSyntax","corrected":false,"location":{"line":21,"column":57,"length":14}},{"severity":"convention","message":"Use the new Ruby 1.9 hash syntax.","cop_name":"Style/HashSyntax","corrected":false,"location":{"line":23,"column":26,"length":14}},{"severity":"convention","message":"Use the new Ruby 1.9 hash syntax.","cop_name":"Style/HashSyntax","corrected":false,"location":{"line":23,"column":52,"length":9}},{"severity":"convention","message":"Use the new Ruby 1.9 hash syntax.","cop_name":"Style/HashSyntax","corrected":false,"location":{"line":26,"column":21,"length":14}},{"severity":"convention","message":"Use the new Ruby 1.9 hash syntax.","cop_name":"Style/HashSyntax","corrected":false,"location":{"line":26,"column":47,"length":14}},{"severity":"convention","message":"Line is too long. [111/80]","cop_name":"Metrics/LineLength","corrected":null,"location":{"line":26,"column":81,"length":31}},{"severity":"convention","message":"Use the new Ruby 1.9 hash syntax.","cop_name":"Style/HashSyntax","corrected":false,"location":{"line":26,"column":85,"length":9}},{"severity":"convention","message":"Incorrect indentation detected (column 0 instead of 2).","cop_name":"Style/CommentIndentation","corrected":false,"location":{"line":32,"column":1,"length":79}},{"severity":"convention","message":"Assignment Branch Condition size for RegisterTest is too high. [66.72/15]","cop_name":"Metrics/AbcSize","corrected":null,"location":{"line":38,"column":3,"length":3}},{"severity":"convention","message":"Cyclomatic complexity for RegisterTest is too high. [22/6]","cop_name":"Metrics/CyclomaticComplexity","corrected":null,"location":{"line":38,"column":3,"length":3}},{"severity":"convention","message":"Method has too many lines. [39/10]","cop_name":"Metrics/MethodLength","corrected":null,"location":{"line":38,"column":3,"length":2836}},{"severity":"convention","message":"Perceived complexity for RegisterTest is too high. [24/7]","cop_name":"Metrics/PerceivedComplexity","corrected":null,"location":{"line":38,"column":3,"length":3}},{"severity":"convention","message":"Use snake_case for method names.","cop_name":"Style/MethodName","corrected":null,"location":{"line":38,"column":12,"length":12}},{"severity":"convention","message":"Do not put a space between a method name and the opening parenthesis.","cop_name":"Style/SpaceAfterMethodName","corrected":false,"location":{"line":38,"column":24,"length":1}},{"severity":"convention","message":"Space inside parentheses detected.","cop_name":"Style/SpaceInsideParens","corrected":false,"location":{"line":38,"column":26,"length":1}},{"severity":"convention","message":"Space inside parentheses detected.","cop_name":"Style/SpaceInsideParens","corrected":false,"location":{"line":38,"column":44,"length":1}},{"severity":"convention","message":"Extra empty line detected at method body beginning.","cop_name":"Style/EmptyLinesAroundMethodBody","corrected":false,"location":{"line":39,"column":1,"length":1}},{"severity":"convention","message":"Prefer single-quoted strings when you don't need string interpolation or special symbols.","cop_name":"Style/StringLiterals","corrected":false,"location":{"line":44,"column":11,"length":27}},{"severity":"convention","message":"Prefer single-quoted strings when you don't need string interpolation or special symbols.","cop_name":"Style/StringLiterals","corrected":false,"location":{"line":45,"column":11,"length":25}},{"severity":"convention","message":"Line is too long. [82/80]","cop_name":"Metrics/LineLength","corrected":null,"location":{"line":51,"column":81,"length":2}},{"severity":"convention","message":"Line is too long. [110/80]","cop_name":"Metrics/LineLength","corrected":null,"location":{"line":52,"column":81,"length":30}},{"severity":"convention","message":"Line is too long. [89/80]","cop_name":"Metrics/LineLength","corrected":null,"location":{"line":54,"column":81,"length":9}},{"severity":"convention","message":"Line is too long. [96/80]","cop_name":"Metrics/LineLength","corrected":null,"location":{"line":55,"column":81,"length":16}},{"severity":"convention","message":"Line is too long. [97/80]","cop_name":"Metrics/LineLength","corrected":null,"location":{"line":56,"column":81,"length":17}},{"severity":"convention","message":"Avoid using `rescue` in its modifier form.","cop_name":"Style/RescueModifier","corrected":false,"location":{"line":58,"column":9,"length":81}},{"severity":"convention","message":"Use `%r` around regular expression.","cop_name":"Style/RegexpLiteral","corrected":false,"location":{"line":58,"column":33,"length":14}},{"severity":"convention","message":"Line is too long. [89/80]","cop_name":"Metrics/LineLength","corrected":null,"location":{"line":58,"column":81,"length":9}},{"severity":"convention","message":"Avoid using `rescue` in its modifier form.","cop_name":"Style/RescueModifier","corrected":false,"location":{"line":59,"column":9,"length":65}},{"severity":"convention","message":"Use `%r` around regular expression.","cop_name":"Style/RegexpLiteral","corrected":false,"location":{"line":59,"column":25,"length":14}},{"severity":"convention","message":"Line is too long. [91/80]","cop_name":"Metrics/LineLength","corrected":null,"location":{"line":61,"column":81,"length":11}},{"severity":"convention","message":"Line is too long. [116/80]","cop_name":"Metrics/LineLength","corrected":null,"location":{"line":63,"column":81,"length":36}},{"severity":"convention","message":"Align the operands of a condition in a `elsif` statement spanning multiple lines.","cop_name":"Style/MultilineOperationIndentation","corrected":false,"location":{"line":64,"column":11,"length":107}},{"severity":"convention","message":"Line is too long. [117/80]","cop_name":"Metrics/LineLength","corrected":null,"location":{"line":64,"column":81,"length":37}},{"severity":"convention","message":"Line is too long. [160/80]","cop_name":"Metrics/LineLength","corrected":null,"location":{"line":69,"column":81,"length":80}},{"severity":"convention","message":"Use 2 (not 3) spaces for indentation.","cop_name":"Style/IndentationWidth","corrected":false,"location":{"line":75,"column":7,"length":3}},{"severity":"convention","message":"Avoid the use of double negation (`!!`).","cop_name":"Style/DoubleNegation","corrected":null,"location":{"line":80,"column":30,"length":1}},{"severity":"convention","message":"Line is too long. [171/80]","cop_name":"Metrics/LineLength","corrected":null,"location":{"line":96,"column":81,"length":91}},{"severity":"convention","message":"Use the new Ruby 1.9 hash syntax.","cop_name":"Style/HashSyntax","corrected":false,"location":{"line":101,"column":11,"length":14}},{"severity":"convention","message":"Use the new Ruby 1.9 hash syntax.","cop_name":"Style/HashSyntax","corrected":false,"location":{"line":101,"column":33,"length":18}},{"severity":"convention","message":"Place the . on the next line, together with the method name.","cop_name":"Style/DotPosition","corrected":false,"location":{"line":101,"column":58,"length":1}},{"severity":"convention","message":"Use 2 (not 0) spaces for indenting an expression spanning multiple lines.","cop_name":"Style/MultilineMethodCallIndentation","corrected":false,"location":{"line":102,"column":5,"length":5}},{"severity":"convention","message":"Line is too long. [158/80]","cop_name":"Metrics/LineLength","corrected":null,"location":{"line":102,"column":81,"length":78}},{"severity":"convention","message":"Place the . on the next line, together with the method name.","cop_name":"Style/DotPosition","corrected":false,"location":{"line":102,"column":156,"length":1}},{"severity":"convention","message":"Use 2 (not 0) spaces for indenting an expression spanning multiple lines.","cop_name":"Style/MultilineMethodCallIndentation","corrected":false,"location":{"line":103,"column":5,"length":5}},{"severity":"convention","message":"Use the new Ruby 1.9 hash syntax.","cop_name":"Style/HashSyntax","corrected":false,"location":{"line":107,"column":11,"length":14}},{"severity":"convention","message":"Use the new Ruby 1.9 hash syntax.","cop_name":"Style/HashSyntax","corrected":false,"location":{"line":107,"column":33,"length":18}},{"severity":"convention","message":"Place the . on the next line, together with the method name.","cop_name":"Style/DotPosition","corrected":false,"location":{"line":107,"column":58,"length":1}},{"severity":"convention","message":"Use 2 (not 0) spaces for indenting an expression spanning multiple lines.","cop_name":"Style/MultilineMethodCallIndentation","corrected":false,"location":{"line":108,"column":5,"length":5}},{"severity":"convention","message":"Line is too long. [154/80]","cop_name":"Metrics/LineLength","corrected":null,"location":{"line":108,"column":81,"length":74}},{"severity":"convention","message":"Place the . on the next line, together with the method name.","cop_name":"Style/DotPosition","corrected":false,"location":{"line":108,"column":152,"length":1}},{"severity":"convention","message":"Use 2 (not 0) spaces for indenting an expression spanning multiple lines.","cop_name":"Style/MultilineMethodCallIndentation","corrected":false,"location":{"line":109,"column":5,"length":5}},{"severity":"convention","message":"Use the new Ruby 1.9 hash syntax.","cop_name":"Style/HashSyntax","corrected":false,"location":{"line":113,"column":11,"length":14}},{"severity":"convention","message":"Use the new Ruby 1.9 hash syntax.","cop_name":"Style/HashSyntax","corrected":false,"location":{"line":113,"column":33,"length":18}},{"severity":"convention","message":"Place the . on the next line, together with the method name.","cop_name":"Style/DotPosition","corrected":false,"location":{"line":113,"column":57,"length":1}},{"severity":"convention","message":"Use 2 (not 0) spaces for indenting an expression spanning multiple lines.","cop_name":"Style/MultilineMethodCallIndentation","corrected":false,"location":{"line":114,"column":5,"length":5}},{"severity":"convention","message":"Use the new Ruby 1.9 hash syntax.","cop_name":"Style/HashSyntax","corrected":false,"location":{"line":118,"column":11,"length":14}},{"severity":"convention","message":"Place the . on the next line, together with the method name.","cop_name":"Style/DotPosition","corrected":false,"location":{"line":118,"column":31,"length":1}},{"severity":"convention","message":"Use 2 (not 0) spaces for indenting an expression spanning multiple lines.","cop_name":"Style/MultilineMethodCallIndentation","corrected":false,"location":{"line":119,"column":5,"length":5}},{"severity":"convention","message":"Incorrect indentation detected (column 0 instead of 2).","cop_name":"Style/CommentIndentation","corrected":false,"location":{"line":124,"column":1,"length":79}},{"severity":"convention","message":"Redundant `self` detected.","cop_name":"Style/RedundantSelf","corrected":false,"location":{"line":127,"column":5,"length":18}},{"severity":"convention","message":"Redundant `self` detected.","cop_name":"Style/RedundantSelf","corrected":false,"location":{"line":131,"column":5,"length":18}},{"severity":"convention","message":"Line is too long. [100/80]","cop_name":"Metrics/LineLength","corrected":null,"location":{"line":134,"column":81,"length":20}},{"severity":"convention","message":"Assignment Branch Condition size for pick is too high. [19.34/15]","cop_name":"Metrics/AbcSize","corrected":null,"location":{"line":135,"column":3,"length":3}},{"severity":"convention","message":"Redundant `self` detected.","cop_name":"Style/RedundantSelf","corrected":false,"location":{"line":136,"column":23,"length":8}},{"severity":"convention","message":"Redundant `self` detected.","cop_name":"Style/RedundantSelf","corrected":false,"location":{"line":136,"column":52,"length":15}},{"severity":"convention","message":"Redundant `self` detected.","cop_name":"Style/RedundantSelf","corrected":false,"location":{"line":139,"column":14,"length":18}},{"severity":"convention","message":"Redundant `self` detected.","cop_name":"Style/RedundantSelf","corrected":false,"location":{"line":143,"column":37,"length":7}},{"severity":"convention","message":"Redundant `self` detected.","cop_name":"Style/RedundantSelf","corrected":false,"location":{"line":143,"column":53,"length":16}},{"severity":"convention","message":"Redundant `self` detected.","cop_name":"Style/RedundantSelf","corrected":false,"location":{"line":146,"column":41,"length":18}},{"severity":"convention","message":"Redundant `self` detected.","cop_name":"Style/RedundantSelf","corrected":false,"location":{"line":148,"column":22,"length":18}},{"severity":"convention","message":"Line is too long. [87/80]","cop_name":"Metrics/LineLength","corrected":null,"location":{"line":150,"column":81,"length":7}},{"severity":"convention","message":"Redundant `self` detected.","cop_name":"Style/RedundantSelf","corrected":false,"location":{"line":151,"column":8,"length":13}},{"severity":"convention","message":"Space between { and | missing.","cop_name":"Style/SpaceInsideBlockBraces","corrected":false,"location":{"line":151,"column":27,"length":2}},{"severity":"convention","message":"Space missing inside }.","cop_name":"Style/SpaceInsideBlockBraces","corrected":false,"location":{"line":151,"column":46,"length":1}},{"severity":"convention","message":"Redundant `self` detected.","cop_name":"Style/RedundantSelf","corrected":false,"location":{"line":152,"column":14,"length":18}},{"severity":"convention","message":"Redundant `return` detected.","cop_name":"Style/RedundantReturn","corrected":false,"location":{"line":155,"column":5,"length":6}},{"severity":"convention","message":"Redundant `self` detected.","cop_name":"Style/RedundantSelf","corrected":false,"location":{"line":155,"column":28,"length":18}},{"severity":"convention","message":"Space inside parentheses detected.","cop_name":"Style/SpaceInsideParens","corrected":false,"location":{"line":160,"column":26,"length":1}},{"severity":"convention","message":"Surrounding space missing in default value assignment.","cop_name":"Style/SpaceAroundEqualsInParameterDefault","corrected":false,"location":{"line":160,"column":34,"length":1}},{"severity":"convention","message":"Space inside parentheses detected.","cop_name":"Style/SpaceInsideParens","corrected":false,"location":{"line":160,"column":37,"length":1}},{"severity":"convention","message":"Redundant `self` detected.","cop_name":"Style/RedundantSelf","corrected":false,"location":{"line":161,"column":23,"length":7}},{"severity":"convention","message":"Redundant `self` detected.","cop_name":"Style/RedundantSelf","corrected":false,"location":{"line":164,"column":18,"length":14}},{"severity":"convention","message":"Redundant `self` detected.","cop_name":"Style/RedundantSelf","corrected":false,"location":{"line":167,"column":18,"length":30}},{"severity":"convention","message":"Redundant `self` detected.","cop_name":"Style/RedundantSelf","corrected":false,"location":{"line":167,"column":56,"length":10}},{"severity":"convention","message":"Redundant `self` detected.","cop_name":"Style/RedundantSelf","corrected":false,"location":{"line":171,"column":5,"length":10}},{"severity":"convention","message":"Assignment Branch Condition size for create_new_trial is too high. [17.61/15]","cop_name":"Metrics/AbcSize","corrected":null,"location":{"line":175,"column":3,"length":3}},{"severity":"convention","message":"Method has too many lines. [16/10]","cop_name":"Metrics/MethodLength","corrected":null,"location":{"line":175,"column":3,"length":548}},{"severity":"convention","message":"Space inside parentheses detected.","cop_name":"Style/SpaceInsideParens","corrected":false,"location":{"line":175,"column":24,"length":1}},{"severity":"convention","message":"Surrounding space missing in default value assignment.","cop_name":"Style/SpaceAroundEqualsInParameterDefault","corrected":false,"location":{"line":175,"column":32,"length":1}},{"severity":"convention","message":"Space inside parentheses detected.","cop_name":"Style/SpaceInsideParens","corrected":false,"location":{"line":175,"column":35,"length":1}},{"severity":"convention","message":"Redundant `self` detected.","cop_name":"Style/RedundantSelf","corrected":false,"location":{"line":176,"column":23,"length":7}},{"severity":"convention","message":"Redundant `self` detected.","cop_name":"Style/RedundantSelf","corrected":false,"location":{"line":179,"column":24,"length":7}},{"severity":"convention","message":"Line is too long. [84/80]","cop_name":"Metrics/LineLength","corrected":null,"location":{"line":188,"column":81,"length":4}},{"severity":"convention","message":"Redundant `self` detected.","cop_name":"Style/RedundantSelf","corrected":false,"location":{"line":196,"column":5,"length":10}},{"severity":"convention","message":"Redundant `self` detected.","cop_name":"Style/RedundantSelf","corrected":false,"location":{"line":196,"column":19,"length":23}},{"severity":"convention","message":"Redundant `self` detected.","cop_name":"Style/RedundantSelf","corrected":false,"location":{"line":201,"column":5,"length":14}},{"severity":"convention","message":"Line is too long. [85/80]","cop_name":"Metrics/LineLength","corrected":null,"location":{"line":204,"column":81,"length":5}},{"severity":"convention","message":"Redundant `self` detected.","cop_name":"Style/RedundantSelf","corrected":false,"location":{"line":206,"column":5,"length":14}},{"severity":"convention","message":"Line is too long. [87/80]","cop_name":"Metrics/LineLength","corrected":null,"location":{"line":226,"column":81,"length":7}},{"severity":"convention","message":"Extra empty line detected at class body end.","cop_name":"Style/EmptyLinesAroundClassBody","corrected":false,"location":{"line":228,"column":1,"length":1}}]}],"summary":{"offense_count":105,"target_file_count":1,"inspected_file_count":1}}
<<<OUTPUT ENDS>>>

(finished - exit code 0) ['/bin/bash', '-c', '''ruby'' -w -c -T1 ''/var/folders/6_/rwhgkhd94c56zh4tpxct9ym80000gp/T/vEkVeA1/18/ab_test.rb''']

<<<NO OUTPUT RETURNED>>>

(finished - exit code 1) ['/bin/bash', '-c', '''rubocop'' --auto-correct ''/var/folders/6_/rwhgkhd94c56zh4tpxct9ym80000gp/T/vEkVeA1/27/ab_test.rb''']

What went wrong
Disabling ALEToggle does not disable ale_fix_on_save setting.
Reproducing the bug
Steps for repeating the bug:

Open a file (in my case, a .rb file linted using rubocop).
Enter :ALEToggle in the buffer to toggle off ALE.
Write the file.

Result

ALE fixes the lint errors on save.

Expected Behavior

With ALE toggled off, the ale_fix_on_save setting would be ignored.

That's a command for toggling ALE linting, and it predates fixing files. If you want to disable fixing files, set g:ale_fix_on_save to 0.

You can also disable fixing automatically for particular files with the b:ale_fix_on_save variable, which you could set with g:ale_pattern_options.

Not if you read :help ALEDisable, which explains what the command does. Other people use that command to disable linting, while they still want to fix their files.

Documentation doesn't make it unsurprising.  Given the default behavior is to set "ale_fix_on_save" to enabled, this can produce a very jarring user experience when adopting ALE in a legacy codebase.
In the very least, I was surprised to not find any convenience helper to toggle that behavior.  It can be quite difficult to manage this when it corrupts an entire file for you unless you happen to have disabled the default behavior.  I can't wrap my head around "disable" not actually disabling the tool from rewriting my entire file on save nor the reasons it wouldn't be jarring to change the behavior wrt to "ale_fix_on_save" itself.
To be fair, this is the only wart I've experienced on ALE, which made it hurt.  Congratulations on a fantastically useful tool. :smile:


[Enhancement] Color converters / extensions

Summary
There's a lot of community code that we can bundle in this Toolkit. I would like to reach out to people in the community of things that we like and see if they're willing to PR it into the Toolkit. One such sample is this collection of extensions and converters related to colors:
https://blog.francois.raminosona.com/more-xamarin-forms-color-functions/
How do we feel about this strategy of reaching out to people to add useful snippets they might have into this NuGet? Also, how do we feel about the above sample? Is it something we think has a place in this Toolkit? I think it suits it and getting more people to contribute this way is definitely a goal I think we should want to strive for instead of just grabbing the code and pulling it in ourselves.

Regarding this one, I had a chat with François and he will take a look in the weekend :)

Re: this strategy. Yes! Definitely! I think it shows we are happy to collaborate and they will still get credit by putting it in here themselves. And I would hate anyone to think that we are taking code from people and assimilate it. Even if they don’t want to contribute themselves, I would always want to be in touch and get permission to put their code in or at least let them know we are doing something similar.
Of course to a certain extent. We can’t go out and trace all libraries that do remotely the thing we want to do. But I think we are aware of popular libraries and we want to make friends <3

Did @framinosona ever get back to this? :)

Hello, will this issue be available for Hacktoberfest ?

We already have some ColorHelpers in XE as you can see here. So we can see if this feature fits better in XE or here. If fits better here we can bring what we already have in XE to here and add more features.

@pictos looking at Essentials and this one there is no overlap. Essentials ones are all FromRgb etc. While these methods to ToRgb.
Also the PR that is opened has a lot of good stuff that is not in Essentials

I would like to implement it

There is already a PR open @Hackavist so I don't think that is going to work :)

okay sorry for the misunderstanding

@jfversluis yeah, they don't overlap. But my concern is about having a same feature in different packages and this can lead to code duplication in the future. As a mobile developer, I want to have all Color features in one place, that way I don't need to scan different namespaces and/or packages looking for the method that I want. Said that I think we keep the ColorHelpers in one place, can be here or in Essentials. Is that make sense to you?

That definitely is a good point.
I think the big difference is that the Essentials APIs don't use the Xamarin.Forms.Color while this one does?

@jfversluis... Well XE grabbed the XF implementation... I was there (Bilbo's voice)... You can see more about the implementation here

This one is merged!


Add detail and name to the new update event group

A new event group "update" was added for the amazon provider [0], we need to
also add the name and detail properties to the group in the main repo.
[0] https://github.com/ManageIQ/manageiq-providers-amazon/pull/415

Thx!

Changing to gaprindashvili/yes to match https://github.com/ManageIQ/manageiq-providers-amazon/pull/415

@miq-bot add_label fine/yes
/cc @simaishi https://github.com/ManageIQ/manageiq-providers-amazon/pull/415 needs to be backported too

Gaprindashvili backport details:
$ git log -1
commit 355c506013eb654a317c99b4775e2699a4e8027f
Author: Martin Povolny<EMAIL_ADDRESS>Date:   Fri Mar 16 15:04:43 2018 +0100

    Merge pull request #17164 from agrare/add_detail_and_name_to_new_update_event_group

    Add detail and name to the new update event group
    (cherry picked from commit 2adc8e15d6e7b4e8f597bf41d54c5e6e29e69f79)

    https://bugzilla.redhat.com/show_bug.cgi?id=1558594

Fine backport details:
$ git log -1
commit c23f98f46eaacc11138c1885fac45fe53201b6b6
Author: Martin Povolny<EMAIL_ADDRESS>Date:   Fri Mar 16 15:04:43 2018 +0100

    Merge pull request #17164 from agrare/add_detail_and_name_to_new_update_event_group

    Add detail and name to the new update event group
    (cherry picked from commit 2adc8e15d6e7b4e8f597bf41d54c5e6e29e69f79)

    https://bugzilla.redhat.com/show_bug.cgi?id=1558595


Update field mapping for 311, voting, and state questions

Done with commit https://github.com/smartchicago/kimball/commit/0c6a1b7e6548648c522303165c8ea29ee92379a9


chore: fix purgecss script

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.007%) to 79.041%

Totals

Change from base Build<PHONE_NUMBER>:
0.007%

Covered Lines:
6990

Relevant Lines:
8045

💛  - Coveralls


[WIP] Add graph canonize algorithm

This allows one to provide two graphs that are the same an check to see that the nodes/vertices in the graph are arranged in the same order. The idea behind this is to simplify the user experience. If you provide two molecules of the same type to votca, but the atoms are arranged differently in each molecule it is impossible to use the mapping functionality. This pull request helps to solve the problem by canonizing the order.

Some of the tests fail with clang-10, e.g.:
 22/277 Test  #22: unit_test_graphalgorithm ...........................***Failed    0.03 sec
 Running 6 test cases...
 is single network 1
 EDGE CHECK **************************************
 struct ID A Dist0labelaDist1labelaDist1labelaDist1labelbDist2labelb
 struct ID B Dist0labelaDist1labelaDist1labelaDist1labelbDist2labelb
 Print Sequence
 A     B    Cannonized A     Cannonzied B     Degree A   Degree B
 ================================================================
 2     3          a               a              3          3
 5     1          b               b              2          2
 3     2          a               a              2          2
 1     4          a               a              1          1
 4     5          b               b              2          2
 /builds/votca/tools/votca/tools/src/tests/test_graphalgorithm.cc(907): error: in "graphalgorithm_test/find_canonized_sequence_test": check sequence_A.at(2) == 1 has failed [3 != 1]
 /builds/votca/tools/votca/tools/src/tests/test_graphalgorithm.cc(908): error: in "graphalgorithm_test/find_canonized_sequence_test": check sequence_A.at(3) == 3 has failed [1 != 3]
 /builds/votca/tools/votca/tools/src/tests/test_graphalgorithm.cc(913): error: in "graphalgorithm_test/find_canonized_sequence_test": check sequence_B.at(2) == 4 has failed [2 != 4]
 /builds/votca/tools/votca/tools/src/tests/test_graphalgorithm.cc(914): error: in "graphalgorithm_test/find_canonized_sequence_test": check sequence_B.at(3) == 2 has failed [4 != 2]
 /builds/votca/tools/votca/tools/src/tests/test_graphalgorithm.cc(919): error: in "graphalgorithm_test/find_canonized_sequence_test": check gA.getDegree(sequence_A.at(2)) == 1 has failed [2 != 1]
 /builds/votca/tools/votca/tools/src/tests/test_graphalgorithm.cc(920): error: in "graphalgorithm_test/find_canonized_sequence_test": check gA.getDegree(sequence_A.at(3)) == 2 has failed [1 != 2]
 /builds/votca/tools/votca/tools/src/tests/test_graphalgorithm.cc(925): error: in "graphalgorithm_test/find_canonized_sequence_test": check gB.getDegree(sequence_B.at(2)) == 1 has failed [2 != 1]
 /builds/votca/tools/votca/tools/src/tests/test_graphalgorithm.cc(926): error: in "graphalgorithm_test/find_canonized_sequence_test": check gB.getDegree(sequence_B.at(3)) == 2 has failed [1 != 2]
 *** 8 failures are detected in the test module "graphalgorithm_test"

We will have to merge #222 first.

I'm well aware this fails, outputting the ids of a molecule in a unique sequence, that is specific to the molecule is not a trivial thing to do. With the current implementation it should fail which speaks to the importance of our testing framework. I have been working on fixing this but like I said this is not a straightforward problem to solve.

actually I'm not confused as to why the ci is passing.

actually I'm now confused as to why the ci is passing.

Clang-10 is part of Rawhide and Rawhide build are allowed to fail.

I feel the API is not optimal yet, as is some of the naming. I like the extensive testing. How to give values to Nodes we should discuss a bit further.

You are completely right, I need help with names, let me get this working first and then I could definitely use your help with improving the interface.

Replaced by https://github.com/votca/votca/pull/766


fixed incorrect display message in version issue #111

Codecov Report

Merging #113 (a26e16e) into develop (ede3172) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop     #113   +/-   ##
========================================
  Coverage    68.92%   68.92%
========================================
  Files           23       23
  Lines         1770     1770
========================================
  Hits          1220     1220
  Misses         541      541
  Partials         9        9

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ede3172...a26e16e. Read the comment docs.

Println is giving warning so, I replaced this with  Printf

Println is giving warning so, I replaced this with Printf

Yes actually Println doesn't support string Formatting, thus you can use, %s with it.
Instead, if required you can use Println like string concatenation, breaking string with + signs. like
greet := "world"
fmt.Println("hello" + greet)


After the reconnect timer has expired, I only get a connection again when I press deploy

I want to implement Modbus devices that can fail for 1 to 2 hours at any time.
After a short time the Modbus client should try to establish a connection to the device. After the reconnect timer has expired, I only get a connection again when I press deploy.

After the connection is lost, the node is in the init status. This status does not change even if the Modbus device can be reached again. The Modbus Node print the Message "Error: Client Not Ready To Read At State init"

Mobdus Client Connection

lost connection (I stop the modbus server for a few minutes)

after a short time change to init Status. I start the Modbus server and the status never changes

As soon as I restart the NodeRed or press the deploy button, everything works normally again (data is retrieved)
I've already tried increasing the interval of Inject(Timer). However, I couldn't see any improvement

My Version

I change my node red Version to 12.13.0 and my problem is fixed


Added indentation option

This adds the option to set (overrule) the indentation.
By default it will indent with 2 spaces.
You can now make the output use 4 spaces, or tabs, like:
$less = new Less_Parser(array('indentation' => "\t"));

This needs a rebase please.

Done


Feature request: Monday as first day of week

Is there a way to set Monday as first day of week?
If not, can it be done?
Thanks

If you consult with https://fullcalendar.io/docs/localization you can see the properties that you might use for configuring the calendar's display.  I think this'll get you what you're looking for!  Cheers & good luck!


wireguird: building go binary... Failed

Hi man!
Sorry my english a little bit broken. I haven't talk for ages on this language.
So I tried to compile your application but it didn't finished and it throw me this error massege.
../../go/pkg/mod/github.com/gotk3/gotk3@v0.4.0/gtk/accel.go:261:5: val.accel_flags undefined (type _Ctype_struct__GtkAccelKey has no field or method accel_flags) ../../go/pkg/mod/github.com/gotk3/gotk3@v0.4.0/gtk/accel.go:270:22: obj.accel_flags undefined (type *_Ctype_struct__GtkAccelKey has no field or method accel_flags)
I'm currently using Pop OS 20.10 (basically a ubuntu 20.10)

Hi,
the author/creator is having health issues so don't expect updates or help any time soon ; I hope he's better now.
I tried to compile it and had no errors with my Ubuntu 20.04 but didn't tried 20.10.
I don't use the compiled executable of 24.7 MB but use the deb package who gives in /opt/wireguird/ one of 17.1 MB.
Can't you install the deb package ? wireguird_amd64.deb

Hello!
Sad to hear :/  I also hope he will get better soon.
Sorry I haven't noticed the packaged version of the program. The package manager installed it without any problems. And It working fine on Pop OS 21.04 (I'm upgrded to the newest vession) . So this is a really cool and simple application :D . Although the add tunnel and edit tunnel buttons aren't working on my system, nevertheless I love it :D
Thanks  for the help!


#20 breaks subclassing jQuery

Unclear whether this is worth "fixing" (whatever that means), but I think it's worth at least discussing even if we decide just to document a workaround.
If you subclass jQuery with Pjs, many methods that aren't supposed to mutate this, like .appendTo(), will add elements to this: http://jsbin.com/faxifed/edit?html,console,output
This was causing exponentially growing jQuery sets in MathQuill (https://github.com/mathquill/mathquill/pull/629).
This is because jQuery internally calls this.constructor() which normally creates a whole new jQuery object, but for Pjs subclasses starting with #20 on v5.0.0 just returns this: https://github.com/jquery/jquery/blob/305f193aa57014dc7d8fa0739a3fefd47166cd44/src/core.js#L72-L84
Thanks @jwmerrill!

Seems like the main reason jQuery can be subclassed "idiomatically" (i.e. the reason Coffeescript and ES6 classes don't break here) is because they allow constructors to return objects: http://jsbin.com/qinare/edit?html,console,output


Revert "Implemented option to store token in named container"

This PR Reverts microsoft/azure-pipelines-agent#4607 due to agent configuration issue on latest ubuntu20/22:
[2024-02-01 17:51:16Z WARN VisualStudioServices] Basic issued token provider instance 31092027 requires an interactive prompt which is not allowed by the current settings
[2024-02-01 17:51:16Z ERR  VisualStudioServices] GET request to https://dev.azure.com/***/_apis/distributedtask/pools is not authorized. Details: VS30063: You are not authorized to access https://dev.azure.com/.
[2024-02-01 17:51:16Z INFO CommandSettings] Flag 'unattended': 'False'
[2024-02-01 17:51:16Z ERR  Terminal] WRITE ERROR (exception):
[2024-02-01 17:51:16Z ERR  Terminal] Microsoft.VisualStudio.Services.Common.VssUnauthorizedException: VS30063: You are not authorized to access https://dev.azure.com/.

/azp run

/azp run


activiti-cloud-query to 7.0.31

Promote activiti-cloud-query to version 7.0.31

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approvers:
If they are not already assigned, you can assign the PR to them by writing /assign  in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@almerico: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

promotion-build
91bdfb5c4b23e47b39cdbe3e94f8409d4281f13f
link
/test this

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


gdsfactory connections

The gf.component.connect method does not seem to reliably pass the verification process (I still get the error related to disconnected pins).

I'm sorry to hear that.  It will require someone to fix gdsfactory and/or the implementation of the EBeam PDK in gdsfactory. I suggest creating an issue there.


Error on build of sample

The Sample project throws an error if published:
$ git clone https://github.com/Elringus/DotNetJS.git
$ cd DotNetJS/Samples/HelloWorld/
$ dotnet publish
Microsoft (R) Build Engine version 17.0.0+c9eb9dd64 for .NET
Copyright (C) Microsoft Corporation. All rights reserved.

  Determining projects to restore...
  Restored /workspaces/DotNetJS/Samples/HelloWorld/Project/HelloWorld.csproj (in 428 ms).
CSC : warning CS8032: An instance of analyzer Generator.SourceGenerator cannot be created from /var/nuget/dotnetjs/0.9.1/analyzers/dotnet/cs/Generator.dll : Could not load file or assembly 'Microsoft.CodeAnalysis, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=31bf3856ad364e35'. The system cannot find the file specified.. [/workspaces/DotNetJS/Samples/HelloWorld/Project/HelloWorld.csproj]
/workspaces/DotNetJS/Samples/HelloWorld/Project/Program.cs(19,34): error CS8795: Partial method 'Program.GetHostName()' must have an implementation part because it has accessibility modifiers. [/workspaces/DotNetJS/Samples/HelloWorld/Project/HelloWorld.csproj]

dotnet --version
6.0.100

Nevermind, wasn't your fault: https://github.com/dotnet/sdk/issues/23972
Just added
        <PackageReference Include="Microsoft.Net.Compilers.Toolset" Version="4.1.0">
            <PrivateAssets>all</PrivateAssets>
            <IncludeAssets>runtime; build; native; contentfiles; analyzers;</IncludeAssets>
        </PackageReference>

until the fixed version will be installed on my machine.


snapshot_id

The ability to create a volume (CBS) from a snapshot was removed when the delete actions were added. Is there a reason for this, beyond the fact that you can't delete a volume with snapshots until you delete the snapshots? It's a quite useful function, essentially to clone an existing volume, when building servers to test ideas before putting them into production, and I hate to have it removed simply because of the link between volumes and snapshots.

Hi there -- I'll defer to @stevendgonzales on this one, as it looks like he was the one working on that code. For what it's worth, it looks like the functionality was only in master for about 5 days at most, as part of a bunch of refactoring commits.

Haven't managed to get the tests to run yet (keeps running into a permissions issue, probably a local artifact) but from some experimentation with the cloning function (source_volid attribute on the creation) create_and_attach suffers from the fact that the creation returns success while the data on the drive is still being cloned, leading to an error:
Invalid volume: volume '' status must be 'available'. Currently in 'creating'
and the prospect of pausing everything for several minutes (5-10 minutes for a 50GB SSD) might be daunting for some. Still, it's early days in my experimentation. I think I'll fork and create a branch that does this (because the potential wait doesn't bother me, it's fairly well defined for what I'm using it for) and test it as soon as I can get any of the tests running in my environment.
Ideally I'd rather use a snapshot, simply because the process allows for more data integrity than the clone, but I experimented with the clone because building from a snapshot takes twice as long.

OK, after some experimentation (tests are still failing with a permissions error for me, so no luck there) I have the snapshot_id working after some tweaks. Biggest issue was extending a timeout value for the looooong time it takes to build from a snapshot. Once I can get the tests working I'll be more sure it actually works.


Adding bootnodes tool and using it in wallet conf

Description

Adding contractkit tool to get list of bootnodes from cloud.
Using tool to configure wallet geth to using these bootnodes according to each network name.

Tested
I have an issue building contraction, cannot test enough. Will test with CircleCI.
Related issues

Fixes #3655

Backwards compatibility
Is backward compatible you just have to turn off network discovery putting USE_FULL_NODE_DISCOVERY to false on mobile/src/config.ts

@joigno is this PR still relevant?


tests: addition of test_example_app.py

Adds test_example_app.py. (closes #108)

Signed-off-by: Leonardo Rossi<EMAIL_ADDRESS>

ping @jirikuncar

@hachreak you can rebase now. Thanks!

ping @jirikuncar

@jirikuncar could you please have a look if it's ok.. them I'll change all PR for example apps as I did here


Allow cancellation of reindex job

Refactors the Reindex job into an instance of an abstract class encapsulating the re-entrant job pattern for long-running background processes, and adds checks to abort the reindex if the associated AsyncJob resource has been updated to cancelled status:

Once at the beginning of every iteration of the job
Updates to the AsyncJob resource are now done conditionally to ensure the update is applied to the latest version; if the status was updated to cancelled mid-execution it will be caught at this point before an update would clobber the cancelled status

Nice, do we want to deploy to staging for a test run?

One thing I noticed while running the reindex from UI on staging is that after the job is cancelled, we continue to poll the job and never indicate that we are no longer indexing (spinner)
We can address that in a separate PR but looks like the cancel worked as expected for the most part. The only weird thing I noticed is the AsyncJob did not end up with a transactionTime set, which might be useful just to know how long the whole job ran before being cancelled


Atom - script package problem

Im trying to run python 3 code. For some reason small things such as
print("hello")
but this just loads forever ....
import time
signs = ["|", "/", "-", "\\"]
while True:
    for i in range(4):
         print(signs[i].format(i), end = '\r', flush = True)
         time.sleep(.5)

I would be very pleased if someone could help me

Thanks for reaching out - since this is an issue with a community package, please report on the package repository if an issue for this problem doesn't already exist: https://atom.io/packages/script.


⚠ Secret Website 3 has degraded performance

In d869360, Secret Website 3 ($SECRET_WEBSITE_3) experienced degraded performance:

HTTP code: 200
Response time: 16986 ms

Resolved: Secret Website 3 performance has improved in 5dcb36e.


Update text of help command

Issue has been fixed in https://github.com/SecondThundeR/secondthunder-js-bot/commit/ac435b11c85e6733e7aaa5623a1878fc09c31c0b


Measure Area Fill

Implemented A fill mesh for Measurement Areas
Fixes AB#1716

The linked issue has a comment indicating that this model flickers and sometimes crashes, has this been fixed?

Yes, all fixed @samsinsane !


Tooltip background issue in the tutorial in Firefox

Hi there !
I just discovered this Hack thing and noticed a problem with the tutorial at http://hacklang.org/tutorial.html
In Firefox, the background of the tooltip is light grey, so I cannot read the text :(

That's Firefox 50.1 on Ubuntu. The popup is fine in Chrome on the same PC.
The culprit seems to be the background-color: infobackground; for the .CodeMirror-lint-tooltip class. Is that some new CSS variable not yet supported by Firefox ?

Interesting. Firefox 50.1.0 on a Mac seems ok.

So this could be an Ubuntu/Firefox thing as opposed to FireFox overall.

I did some more testing. I didn't know about that InfoBackground CSS color.
Windows is OK (yellow as well).
Problem persists with bare Ubuntu 16.04.1 installation with or without the Ubuntu Additions addon.
On Ubuntu it seems to return the following (found with inspection tools):

InfoBackground is #F2F1F0
InfoText is #FFFFFF

On Xubuntu it is working as expected, the popup has the colors of the system tooltip, black:

The rule is in this file. I believe this comes from https://github.com/codemirror/CodeMirror ?
It looks like they have gone back to using basic CSS colors in their version maybe do an update ?

@clarkwinkelmann Thanks for the information. Is this something you might be willing to submit a pull request for?

It seems the tutorial is using version 3.2 of the CodeMirror librairy (seen here https://github.com/hhvm/hacklang.org/blob/master/js/hack_tutorial/codemirror/lib/codemirror.js#L1)
The fix requires to update to at least version 5.15 https://github.com/codemirror/CodeMirror/blob/5.15.0/addon/lint/lint.css
The major version bump requires to check for compatibility, and I have no idea how it was coded (would require spending some time on the tutorial JS code). It would be quicker if the person who originally coded it had a look for compatibility issues :grimacing: Additionally, I have no idea how that CodeMirror library works...
Or, I could submit a PR where I only patch the css file with the latest version (only these two lines changed) but this may cause problems (or be erased) if the library is updated in the future (to v4 for example) !

I don't think we have plans on updating the CodeMirror library in the near-term. So maybe a short-term fix would be just fine. So I would submit the simplest PR as possible that fixes your issue (and doesn't break other browsers, of course :) ), assuming the CodeMirror library stays the same.