Compatibility with pytorch 1.0

Hi,
Any plan on updating the classes to be compatible with pytorch 1.0?

Is there any issue you have in mind? I have a slightly different version of the code that I've been using, and I was able to switch to PyTorch 1.0 without any changes.

Closing now since I think this is a non-issue. Feel free to open this again if you have issues with pytorch 1.0.


Add user_info to the bot object

Adds a dictionary from the users key of the auth response, indexed by id, and containing the information about users who are members of the chat room.
See line 75 of insultbot.js for an example.

This is generally a good idea: the RTM payload contains tons of useful information that, if cached, would remove the need to call the API to look up the info.
HOWEVER, it opens a small can of worms because the information becomes out of date as users change their info, or are added or removed from the team.
It would be great to see this PR include handlers for that type of change event so that this cache could be kept up to date.


[SP-2930][PDI-14278] Calculator step provides incorrect values when c…

…onverting time zones

hourOfDay calculation now considers valueMeta`s time zone
added compatibilty property switching off the fix
added unit test

Build Completed
:x: This pull request has errors. They will need to be addressed before it can be accepted. See below for more details. Some links are also available below for further assistance in addressing those issues.
Build Commands
ant -Dtestreports.dir=bin/reports/unit-test -f core/build.xml clean-all resolve jacoco && ant -Dtestreports.dir=bin/reports/integration-test -f core/build.xml jacoco-integration checkstyle publish-local

Cleanup Commands
rm -r ~/.ivy2/local || echo no publish local to remove

Changed files
  core/src/org/pentaho/di/core/Const.java
  core/src/org/pentaho/di/core/row/ValueDataUtil.java
  core/test-src/org/pentaho/di/core/row/ValueDateUtilTest.java

Unit test coverage change
These statistics help you identify how your changes have affected the coverage of the following files. If a file is not in this list, then its coverage was not affected by your changes. To get some help interpreting these metrics, please refer to Jacoco's documentation.
org.pentaho.di.core.row.ValueDataUtil

Branch Change:  + .80%
Complexity Change:  + 1.07%
Instruction Change:  + 1.53%
Line Change:  + 2.16%
Method Change:  + 2.97%

Checkstyle violations
The code submitted is not complying with one or more of our guidelines. To perform these checks locally, please use this tool.
/home/buildguy/project/core/test-src/org/pentaho/di/core/row/ValueDateUtilTest.java

:heavy_exclamation_mark: Using a static member import should be avoided - org.junit.Assert.assertEquals. at Line: 34

Build Completed
:white_check_mark: This pull request has passed all validations.
Build Commands
ant -Dtestreports.dir=bin/reports/unit-test -f core/build.xml clean-all resolve jacoco && ant -Dtestreports.dir=bin/reports/integration-test -f core/build.xml jacoco-integration checkstyle publish-local

Cleanup Commands
rm -r ~/.ivy2/local || echo no publish local to remove

Changed files
  core/src/org/pentaho/di/core/Const.java
  core/src/org/pentaho/di/core/row/ValueDataUtil.java
  core/test-src/org/pentaho/di/core/row/ValueDateUtilTest.java

Unit test coverage change
These statistics help you identify how your changes have affected the coverage of the following files. If a file is not in this list, then its coverage was not affected by your changes. To get some help interpreting these metrics, please refer to Jacoco's documentation.
org.pentaho.di.core.row.ValueDataUtil

Branch Change:  + .80%
Complexity Change:  + 1.07%
Instruction Change:  + 1.53%
Line Change:  + 2.16%
Method Change:  + 2.97%


Update weaver-cats to 0.6.5

Updates com.disneystreaming:weaver-cats from 0.6.0-M6 to 0.6.5.
GitHub Release Notes - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "com.disneystreaming", artifactId = "weaver-cats" } ]

labels: library-update, semver-pre-release

Superseded by #244.


Initial setup

This setup establishes all the networks we've enabled for set-v2-deployments
Also includes:

the helpers that have been developed at index-deployments to enable manager deployments
minimal example deployment script for each network at 001 (to validate setup)
eslint (replacing deprecated ts-lint)

:tada: This PR is included in version 1.0.0-t1.1 :tada:
The release is available on:

npm package (@test dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This PR is included in version 1.0.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


expose more functions from rust SDK

things that would be useful for me right now:

get_bonds_out_for_shares_in
get_shares_out_for_bonds_in
get_bonds_in_for_shares_out
get_shares_in_for_bonds_out

please put your suggestions below.

These are all private functions in the yieldspace.rs library. What is the use case for making them public?

should we add something like the measure_value function used here? https://github.com/delvtech/agent0/pull/1352/files#diff-588ee93bc3288ed7ed17a880e6ffdda7c986c72d22d289b23fbef3e2e0c07a4bR42

this predict function definitely feels like it should be in the rust SDK because it's very low-level https://github.com/delvtech/agent0/blob/a317f3d2fd0ece2627814a7d2368d6c87c52e9e4/src/agent0/core/hyperdrive/utilities/predict.py

closing in favor of https://github.com/delvtech/agent0/issues/1514


"./dspace solr-reindex-statistics" doesn't work in DSpace 7.x

Describe the bug
Reported on behalf of this thread: https://groups.google.com/g/dspace-community/c/xguccnJkrJM/m/UxcRrjcKBwAJ
The ./dspace solr-reindex-statistics script is broken in DSpace 7 because it attempts to access the Solr data in the old DSpace 6.x directory structure (instead of using SOLR_DATA_HOME or similar).
When running it in DSpace 7, you will receive an error similar to this:
# ./dspace solr-reindex-statistics
No index name provided, defaulting to "statistics".
Exception: Error from server at http://localhost:8983/solr: Path /dspace7/solr/statistics must be relative to SOLR_HOME, SOLR_DATA_HOME coreRootDirectory. Set system property 'solr.allowPaths' to add other allowed paths.
org.apache.solr.client.solrj.impl.HttpSolrClient$RemoteSolrException: Error from server at http://localhost:8983/solr: Path /dspace7/solr/statistics must be relative to SOLR_HOME, SOLR_DATA_HOME coreRootDirectory. Set system property 'solr.allowPaths' to add other allowed paths.
        at org.apache.solr.client.solrj.impl.HttpSolrClient.executeMethod(HttpSolrClient.java:681)
        at org.apache.solr.client.solrj.impl.HttpSolrClient.request(HttpSolrClient.java:266)
        at org.apache.solr.client.solrj.impl.HttpSolrClient.request(HttpSolrClient.java:248)
        at org.apache.solr.client.solrj.SolrRequest.process(SolrRequest.java:214)
        at org.apache.solr.client.solrj.SolrRequest.process(SolrRequest.java:231)
        at org.dspace.util.SolrImportExport.reindex(SolrImportExport.java:320)
        at org.dspace.util.SolrImportExport.main(SolrImportExport.java:189)
        at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
        at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
        at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
        at java.base/java.lang.reflect.Method.invoke(Method.java:566)
        at org.dspace.app.launcher.ScriptLauncher.runOneCommand(ScriptLauncher.java:277)
        at org.dspace.app.launcher.ScriptLauncher.handleScript(ScriptLauncher.java:133)
        at org.dspace.app.launcher.ScriptLauncher.main(ScriptLauncher.java:98)

The problem appears to be in this line of code, which still expects the Solr instance to be relative to dspace.dir: https://github.com/DSpace/DSpace/blob/main/dspace-api/src/main/java/org/dspace/util/SolrImportExport.java#L255-L256
Expected behavior
Either this script should work again, or we should document another way to perform the same reindex task.

Can we add a separate way to add the SOLR path in local.cfg file? Like -> solr.path='/opt/bin/solr'. This will be quick solution but will have to be documented as you mentioned.

@ammanabrolua : Yes, I think that'd be a perfectly reasonable solution to make the directory configurable in your local.cfg.  If you are interested in making this happen, I'd welcome it.  Just submit a Pull Request & link it back to this ticket, at which point I'll help find reviewers and hopefully we can get this into 7.3.  Thanks!

Notice that the suggested approach works only if Solr and DSpace are on the same host.  The general solution would be to ask Solr for the core's instance directory, e.g. "GET http://solr-host.example.com:8983/api/cores" and pick status.[corename].instancedir out of the returned JSON document.

I looked at this a bit, and @mwoodiupui is correct that the instanceDir can be obtained from the JSON status response.

Object solrInstanceDirObj = status.getCoreStatus(instanceIndexName).get("instanceDir");

But there's another issue with the data directory used for the temporary core. I'm still researching how that could be handled in a Solr instance that's on a different server than DSpace.
https://github.com/DSpace/DSpace/blob/ccd47b0ddd2df3cf7560678e29d5311e7e866ea2/dspace-api/src/main/java/org/dspace/util/SolrImportExport.java#L300-L318

Did a solr.path setting ever get added to local.cfg? It doesn't seem to work in our 7.6.2 instance. This ticket seems to have wandered away from its original purpose.


How to use...

let delegate: AudioPlayerDelegate = ...
What's supposed to go in replace of the ...?
thanks!

An instance of AudioPlayerDelegate that you have created.
https://developer.apple.com/library/content/documentation/Swift/Conceptual/Swift_Programming_Language/Protocols.html

I acutally spent the whole last week wrapping my head around protocols, not from a copy and paste standpoint but from actually knowing what and how to...I'm still not there...
Can you give an example to increase my understanding.
thank you!

can it be..... delegate: AudioPlayerDelegate = self  ?
If I conform a ViewController to AudioPlayerDelegate
class MyViewController: AudioPlayerDelegate {

       let delegate: AudioPlayerDelegate = self
}

@sirvon yes for sure it can.


feat: export API documentation

Not sure how to approach this yet, so suggestions are welcome
Essentially, the ability to do something ála npx sveltekit-zero-api export
Current implementation idea is an algorithm to check interfaces and return functions - where input/output examples will be comments in one way or another
I'm expecting to work on this towards early 2023

Currently considering this approach
// New
class Get {
	query = {
		length:  { type: Number, ex: 100, comment: 'The return length of documents' },
		offset:  { type: Number, ex: 0, comment: 'The offset, of which the document is fetched' },
		sortNew: { type: Boolean, ex: true, comment: 'Whether to sort by new' },
		// Enum like
		level:   { type: [['any', 'info', 'warn', 'error', 'assert']], ex: ['info'], comment: 'Which level of log to get' }
	}
}

// Current
interface Get {
	query: {
		length?:  number
		offset?:  number
		sortNew?: boolean
		level?:   LogLevel
		type?:    LogType
		filters?: Parameters<typeof Log.find>[0]
	}
}

Inspired from mongoose and typegoose. Having classes would allow the use of constructors to identify each item. The only downside would be the requirement of typing any objects below it.
For instance in
interface Post {
	body: {
		product: Proudct
	}
}

The product would also need a class. In typegoose this isn't an issue, since Zero API could just derive from the typegoose class which you create:
// Only contains the document input/output values.
class ProductProperties { ... }

// Contains model methods etc.
class Product extends ProductProperties { ... }

const ProductModel = getModelFromClass(Product)

Now sure the similarity compares to other databases.
Another selling point to this idea would be that
a) We can attach decorators for documentation items such as comments or example values
b) querySpread can make use of the class, to identify incorrect types for you
Ultimatively, Zero API would still allow a simple interface, if an exported documentation isn't an interest @ e.g. prototyping

Using TypeScript parser and an AST parser, I'll attempt to get the returned types of endpoints. The endpoint input and output will be exported locally to a JSON-file specified in the configs. This JSON file will contain all API Endpoints their input and output values, and examples if you provided them in your code.
Interfaces will stay the same as they are now. I'm planning for this feature to support ZOD.
I'm bringing this to life in 2023. I'm booked with work for a few months😬

I woke up after a very vivid dream (irrelevant) from my cat meowing - and literally quite out of nowhere got an idea how to handle API documentation.

My dream

I was finding myself on some mid-city grass plot where there was a weird structure. It's style was that of a brutalist metal working, Like the upper part of one of those many-flat-sided shaped spheres. Going up was a stage being set up for an event held by the commune. Going right was a very small door you can't fit through to the outside. Opening it, some kids thought they had to get down here, but I insisted I was there to do technical set-up for the stage above, which I was. (It's a dream, it doesn't need to make sense.)

The communal fogs were doing some communal thing. They dressed up, almost in religious looking clothes, had a big scene.... Anyways, I asked if I could sing and set-up my equipment and do some singing on stage afterwards, which I could.

I was setting up the microphone going up-stage to put it there. They had started. I snuck behind the back. What I found was extremely weird..

There was a big monkey- (I've been playing Bloon TD6 with my girlfriend, don't judge me) shaped machine * it was golden. It's arm which was circular in shape had a coin slot. The upper half could spin, and did so when you put a coin it in. The mayor was trying to get coins out of it, however it needed to be in a correct rotation for the upper-hal, and it just wouldn't work.

I offered the mayor my help. I took my laptop up, and created an AI for this monkey machine. The monkey now talked, looked at the mayor and said; "What can I help you with," he continued hesitantly; "Can you show me the coin box?". The monkey started to spin slowly,  "Sure, it has to be in juuust the right place".

While this was going down, I heard these "MEEOW, MEEEOOOW", and I was like, "Tykke" (my cats nickname), "not now I am working".  A second later I wake up from my cat jumping onto my chest.

Out of NOWHERE, after this vivid dream. I saw before my eyes how to handle this issue, clear as day. I have had no idea how to tackle this issue since it was posted may I add. So I feel like the bizzareness of waking up at 3am to come to 8 month a conclusion deserved a side-note.

Simply structure endpoints using a function:
import { endpoint } from 'sveltekit-zero-api'

export const POST = endpoint({
    // Documentation goes here
}, (event: KitEvent<...>) => {

})

The endpoint returns a function with a single argument. If the argument is of Symbol('documentation'), the function will return documentation. Otherwise return the actual endpoint.
If we're smart, we can get rid of KitEvent type and even avoid defining a interface Post by having it come from the structure within the documenting part:
export const POST = endpoint({
    body: { ... },
    queries: { ... },
    examples: [...],
    // etc... anything that documents
}, (event) => {

})

In terms of inferring objects and what not: I am developing x-classes which has been on my scope for a long time — and I will try to make them synergize without depending on each other.
For other libraries we may just have independent libraries that have functions to handle documentation; sveltekit-zero-api/zod, sveltekit-zero-api/class-validator.
The contents of documentation still needs to be thought through. I'll think about it for now.
The second parameter is either a function as you're used to, or be rest parameters that matches zero-apis pipe function:
export const POST = endpoint({ ... }, (event) => {

})

// or

export const POST = endpoint({ ... },
    authGuard('admin'),
    parseJSON<Post>,
    (event) => {
        ...
    }
)

I personally think this is a great idea. As soon as x-classes has gotten to where I am satisfied, I will probably return to this and follow through. Happy coding🦒

My last comments oversight is that we still need the response types, and are not easily inferred as a first argument to a function. There might be a need for example responses, which could be provided by that first argument.
I personally think inferring responses with their associated types would be neater. However, there's some complexity in inferring those types, and I don't have experience working with parsers as mentioned in https://github.com/Refzlund/sveltekit-zero-api/issues/3#issuecomment-1281950883
However, I still wish to see this come to life before the end of the year, so🦒🕺🤷

Rather than using a Simplify type, a ToJSON<T> that respects an Objects toJSON method (as described "for other objects" here), otherwise only uses the primitive types.


spawn wrap blocking release of 11.4.0

v11.4.0 was released with the dist-tag of next, but npm install picks up latest (default). I added a comment at https://github.com/istanbuljs/nyc/commit/e8225d5223a93fd7fcb37b9f3f8baa17a415d5d5#commitcomment-25987704 about this. Sorry for the duplicate, but I figured a GitHub issue would be more suitable for communicating this.
You need to fiddle with npm dist-tag add and npm dist-tag rm to remove the current tag on v11.4.0 and assign the correct one. This doc explains it well :)
Thanks a lot for your hard work!!

@astorije I haven't released v11.4.0 to latest yet, because there appears to be a Windows issue with spawn-wrap.

see: https://github.com/tapjs/spawn-wrap/issues/67

CC: @sridharmallela

Aaah, my bad, I could have sworn this was a npm publish snafu (this is far from an impossible situation to end up in!). Sorry for the patronization then :)

@bcoe as spawn-wrap, v1.4.2 resolves shebang issue, can you publish new nyc version, since 11.4 has  spawn-wrap as bundled dependency.

@sridharmallela @astorije @codler could you please give<EMAIL_ADDRESS>a try?

FYI @bcoe 11.4.0 was fine for me, the missing piece was the complete release.
Things still look 👌 on 11.4.1 :)


Unable to get results on repositories

Hi I'm experimenting problems to fetch data on https://github-trending-api.now.sh/repositories

Yes, the API seems down 😢

Apparently the problem is just when the API is trying to fetch all coding languages (language=''). This works https://github-trending-api.now.sh/repositories?language=vue

Hi guys, thanks for reporting. Will take a look later today

:tada: This issue has been resolved in version 1.3.1 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

Good job! Thanks!!


Add check and handle negative SearchRequestStats

Description
We identified a bug where negative search stats are causing an exception when processed using VLong in the following line:
https://github.com/opensearch-project/OpenSearch/blob/main/server/src/main/java/org/opensearch/index/search/stats/SearchStats.java#L89
out.writeVLong(current);

This issue occurs because VLong does not handle negative values, resulting in an exception.
Solution
We have implemented a temporary fix that adds a check for negative values before calling writeVLong. If a negative value is encountered, a warning is logged, and 0 is written instead of the negative value:
            if (current < 0) {
                logger.warn("current is negative: {}", current);
                out.writeVLong(0);
            } else {
                out.writeVLong(current);
            }

This fix addresses the immediate problem but does not solve the root cause. We will continue to investigate why search stats are negative in the first place.
Related Issues
https://github.com/opensearch-project/OpenSearch/issues/16598
Check List

[ ] Functionality includes testing.
[ ] API changes companion pull request created, if applicable.
[ ] Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Thanks @dzane17 , this looks pretty interesting. Are you tracking the investigation of this in another GitHub issue? I'm curious which search phase specifically you're seeing this one since having negative time values anywhere is quite concerning.

@jed326 Here is the github issue: https://github.com/opensearch-project/OpenSearch/issues/16598
Actually, current is a request counter. We have not yet seen the time statistic go negative. In either case though it is concerning.
Regarding this code block in SearchService, we will need to check exactly where in the search path it is invoked. The coordinator phase listener hooks (onPhaseStart, onPhaseEnd, onPhaseFailure), where search stats are updated, are in AbstractSearchAsyncAction.

I am wondering if we should have generic way of ignoring negative values (writeUnsignedLong), especially for stat type of use cases instead of handling it every place separately. Missing any occurrence can result in node drops which is never desirable IMO. @jed326 - Thoughts?

@jainankitk I'm actually a little apprehensive about ignoring the negative values at all. This PR is adding negative checking to both count and timeInMillis, both of which should not be possible to be negative. These numbers being negative is indicative of some other underlying problem, or at the very least indicates we have an incorrect assumption about the code flow somewhere. By ignoring the negative values we wouldn't be able to catch any such issues in the future as there wouldn't be any symptoms for any such issues.

These numbers being negative is indicative of some other underlying problem, or at the very least indicates we have an incorrect assumption about the code flow somewhere. By ignoring the negative values we wouldn't be able to catch any such issues in the future as there wouldn't be any symptoms for any such issues.

+1
I suspect a situation where both failure and success code are called (with rare failures) but wasn't able to find it in about an hour of searching.


DRILL-7970: Add URL Parameters to HTTP Plugin

DRILL-7970: Add URL Parameters to HTTP Plugin
Description
Many APIs require that arguments are passed as part of the URL.  For instance, github's API allows you to get information about an organization's repositories with the following URL:  https://api.github.com/orgs/{org}/repos
This PR adds a capability where filters can be pushed down into the URL from a query so that a user could execute a query:
SELECT *
FROM api.github
WHERE org='apache'

In this query, the value for the org parameter would be populated in the URL.
Documentation
Updated the README.md document.
To enable URL parameters, a user simply must add curly braces around a parameter which should be passed down.  Note that Drill will throw an exception in the event an API has a URL parameter and one is not supplied in the query.
Testing
Added two additional unit tests to testing class for the HTTP plugin as well as an additional test for the http client.

@jfmario, @jaltekruse, @Daddykong,
Could one of you take a look at this PR and see what you think?    Thanks!!

@paul-rogers Thanks for the review.  I believe I addressed all your comments.  I added the ability to specify a default value in the URL, as well as added a lot of new unit tests.  I fixed a small bug as well with the errorOn400 config option and added a test for that.
Some of your questions made me wonder how much "misuse" we should tolerate from a user.   For instance, putting the entire URL as a URL parameter...  This is perhaps foolish to do that, but I didn't think there was a risk here because in order to do that, the user would have to have admin access to the plugin configuration anyway.

@cgivre, thanks for the many improvements. Looking pretty good. A few minor comments.
Regarding the "misuse" of query parameters: I see such "misuse" as a feature, not a bug. Consider. Today I must create a new config for each new URL. But, I'm lazy, so I create a "universal" config: url="{url}". Now I can hit any URL and the magic of Drill's schema-on read will figure it out, assuming the returned data is of the right shape.
The goal of the original comment was to get us to realize, "hey, this might be useful. Lets a) document it and b) test it."

Gotcha!  👍 Makes sense.  I was debating putting some sort of URL validation on the config, but I think I'll leave it alone for the time being if you're ok with that.

@paul-rogers
Hey Paul,
I think I got everything.  Could you please take a look?  Thanks!


Remove other platfoms mozz2d libraries from our OS dependent builds.

For example we currently ship both linux and win mozz2d binaries with the Mac package.

They are not shipped anymore


Add altitude compensation handling and waiting for data.

Altitude compensation property.
Method waiting for data to be ready.
Fix set_measurement_interval as it doesn't return any value.
Add constants for the sensor commands.

Thanks @ivan-shaporov, I would appreciate those changes.


Allow to add extraParams to token request and refresh token request

I am using OAuth public client with authorozation code flow, refresh token and resource imdicators (RFC 8707).
The mentioned RFC adds the resource parameter to the authorization, token and refresh token requests. Unfortunatelly, it is not possible to pass the resource parameter to the token request and refresh token request.
The mentioned resource parameter can be a single string or an array of strings which brings additional issue. extraParams of type Record cannot hold multiple items with the same key. Moreover, serialization to query string using UrlSearchParams does not convert a Record with a property of type array os strings correctly
An example of such a Record is  { resource: [ "r1", "r2"]} which should be serialized to "resource=r1&resource=r2".

Hi, this is also needed for Microsoft Graph OAuth2 Auth Code Flow. We need to set the parameter resource=https%3A%2F%2Fgraph.microsoft.com
As of now, your lib does not work for Microsoft OAuth.

Thanks, helpful to know! Support specifically for resource is planned

Please let me know, if i can quickly test the "resource" param or support you there. I am working for a project that needs a dependency free flexible library, that also can be used with other applications like Atlassian Jira.
Do you think, it will feasible to be added in a week or so (again, can i help or test?). We are currently in the process of selecting a oauth client library approach, and i like this lib here very much. Probably i can only stick to it, if microsoft can be connected.

@evert great!

@larsilus A quick test would def help ! Let me know =)


this camera flutter need official guide to convert CameraImage to File，thanks！

Use case

Proposal
I need to convert CameraImage to image in file form in stream

I think this is similar to https://github.com/flutter/flutter/issues/26348 and a temporary solution is: https://github.com/flutter/flutter/issues/26348#issuecomment-453044033 which you can use and see if it works in your case.
Closing this in favor of linked issue. If you disagree, write in comments and I'll reopen it.


swego: init at 0.7

Motivation for this change
Swiss army knife Webserver in Golang. Similar to the Python
SimpleHTTPServer but with many features.
https://github.com/nodauf/Swego
Related to #81418
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[x] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

This is a semi-automatic executed nixpkgs-review. If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.
Result of nixpkgs-review pr 108106 run on x86_64-linux 1

1 package built:

swego

This is a semi-automatic executed nixpkgs-review. If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Should we exclude this package from darwin?

Should we exclude this package from darwin?

It could be an darwin issue but you can just set it broken for darwin.

Should we exclude this package from darwin?

It could be an darwin issue but you can just set it broken for darwin.

OK, marked as broken on darwin.

OK, marked as broken on darwin.


Large CupertinoActionSheetAction widget causes tests to fail due to intrinsic protocol contract violation

Steps to Reproduce
Create a Widget Test with the following contents:
import 'package:flutter/cupertino.dart'
    show
        CupertinoActionSheet,
        CupertinoActionSheetAction,
        showCupertinoModalPopup;
import 'package:flutter/material.dart';
import 'package:flutter_test/flutter_test.dart';

void main() {
  final buttonKey = 'buttonKey';
  final actionSheetKey = 'actionSheetKey';

  testWidgets('Example test', (tester) async {
    await tester.pumpWidget(
      MaterialApp(
        home: Builder(
          builder: (context) => SizedBox(
            key: Key(buttonKey),
            height: 50.0,
            child: RaisedButton(
              onPressed: () {
                showCupertinoModalPopup(
                  context: context,
                  builder: (BuildContext modalContext) => CupertinoActionSheet(
                    key: Key(actionSheetKey),
                    title: Text('Action Sheet Title'),
                    cancelButton: CupertinoActionSheetAction(
                      onPressed: () {
                        Navigator.of(modalContext).pop();
                      },
                      child: Text(
                        'Cancel',
                        style: TextStyle(color: Colors.red),
                      ),
                    ),
                    actions: <Widget>[
                      CupertinoActionSheetAction(
                        onPressed: () {},
                        child: Text('This is a very long action title'),
                      ),
                      CupertinoActionSheetAction(
                        onPressed: () {},
                        child: Text('Option 2'),
                      ),
                    ],
                  ),
                );
              },
              child: Text(
                'Add',
                style: TextStyle(
                  fontSize: 17.0,
                  color: Colors.white,
                ),
              ),
              color: Theme.of(context).primaryColor,
            ),
          ),
        ),
      ),
    );
    await tester.pumpAndSettle(Duration(seconds: 1));

    final addButtonFinder = find.byKey(Key(buttonKey));
    expect(addButtonFinder, findsOneWidget);
    await tester.ensureVisible(addButtonFinder);
    await tester.pumpAndSettle();
    await tester.tap(addButtonFinder);
    await tester.pumpAndSettle();

    final actionSheetFinder = find.byKey(Key(actionSheetKey));
    expect(actionSheetFinder, findsOneWidget);
    final actionSheet =
        actionSheetFinder.evaluate().single.widget as CupertinoActionSheet;
    print(actionSheet.actions);
  });
}

Expected results: Test should pass without issues.
Actual results: Fails while the test is running.
The top part of the error message in the logs is important:
The following assertion was thrown during performLayout():
The intrinsic dimension methods of the _RenderSingleChildViewport class returned values that violate
the intrinsic protocol contract.
The following failure was detected:
 * getMinIntrinsicHeight(584.0) returned a larger value<PHONE_NUMBER>3333334) than
getMaxIntrinsicHeight(584.0)<PHONE_NUMBER>3333331)

There seems to be a precise comparison of intrinsic heights here (minimum<PHONE_NUMBER>3333334 is larger than the maximum<PHONE_NUMBER>3333331).
The problem:
If the CupertinoActionSheetAction has a widget that's very wide, it seems to cause the problem. In my case, the Text widget with This is a very long action title was causing the problem. If I change the text from This is a very long action title to something shorter, like Option 1. That fixes the issues and the test passes.

Logs

══╡ EXCEPTION CAUGHT BY RENDERING LIBRARY ╞═════════════════════════════════════════════════════════
The following assertion was thrown during performLayout():
The intrinsic dimension methods of the _RenderSingleChildViewport class returned values that violate
the intrinsic protocol contract.
The following failure was detected:
 * getMinIntrinsicHeight(584.0) returned a larger value<PHONE_NUMBER>3333334) than
getMaxIntrinsicHeight(584.0)<PHONE_NUMBER>3333331)
If you are not writing your own RenderBox subclass, then this is not
your fault. Contact support: https://github.com/flutter/flutter/issues/new?template=BUG.md

The relevant error-causing widget was:
  CupertinoActionSheet-[<'actionSheetKey'>]
  file:///Users/ardatugay/Documents/degerly/degerly_app/test/temp.dart:24:59

When the exception was thrown, this was the stack:
#0      RenderBox.debugAssertDoesMeetConstraints.<anonymous closure> (package:flutter/src/rendering/box.dart:2016:11)
#1      RenderBox.debugAssertDoesMeetConstraints (package:flutter/src/rendering/box.dart:2028:6)
#2      RenderBox.size=.<anonymous closure> (package:flutter/src/rendering/box.dart:1745:7)
#3      RenderBox.size= (package:flutter/src/rendering/box.dart:1747:6)
#4      _RenderSingleChildViewport.performLayout (package:flutter/src/widgets/single_child_scroll_view.dart:498:7)
#5      RenderObject.layout (package:flutter/src/rendering/object.dart:1724:7)
#6      RenderProxyBoxMixin.performLayout (package:flutter/src/rendering/proxy_box.dart:105:13)
#7      RenderObject.layout (package:flutter/src/rendering/object.dart:1724:7)
#8      RenderProxyBoxMixin.performLayout (package:flutter/src/rendering/proxy_box.dart:105:13)
#9      RenderObject.layout (package:flutter/src/rendering/object.dart:1724:7)
#10     RenderProxyBoxMixin.performLayout (package:flutter/src/rendering/proxy_box.dart:105:13)
#11     RenderObject.layout (package:flutter/src/rendering/object.dart:1724:7)
#12     RenderProxyBoxMixin.performLayout (package:flutter/src/rendering/proxy_box.dart:105:13)
#13     RenderObject.layout (package:flutter/src/rendering/object.dart:1724:7)
#14     RenderProxyBoxMixin.performLayout (package:flutter/src/rendering/proxy_box.dart:105:13)
#15     RenderObject.layout (package:flutter/src/rendering/object.dart:1724:7)
#16     RenderProxyBoxMixin.performLayout (package:flutter/src/rendering/proxy_box.dart:105:13)
#17     RenderObject.layout (package:flutter/src/rendering/object.dart:1724:7)
#18     RenderProxyBoxMixin.performLayout (package:flutter/src/rendering/proxy_box.dart:105:13)
#19     RenderObject.layout (package:flutter/src/rendering/object.dart:1724:7)
#20     RenderProxyBoxMixin.performLayout (package:flutter/src/rendering/proxy_box.dart:105:13)
#21     RenderObject.layout (package:flutter/src/rendering/object.dart:1724:7)
#22     RenderProxyBoxMixin.performLayout (package:flutter/src/rendering/proxy_box.dart:105:13)
#23     RenderObject.layout (package:flutter/src/rendering/object.dart:1724:7)
#24     RenderProxyBoxMixin.performLayout (package:flutter/src/rendering/proxy_box.dart:105:13)
#25     RenderObject.layout (package:flutter/src/rendering/object.dart:1724:7)
#26     RenderProxyBoxMixin.performLayout (package:flutter/src/rendering/proxy_box.dart:105:13)
#27     RenderObject.layout (package:flutter/src/rendering/object.dart:1724:7)
#28     RenderProxyBoxMixin.performLayout (package:flutter/src/rendering/proxy_box.dart:105:13)
#29     RenderObject.layout (package:flutter/src/rendering/object.dart:1724:7)
#30     RenderProxyBoxMixin.performLayout (package:flutter/src/rendering/proxy_box.dart:105:13)
#31     RenderObject.layout (package:flutter/src/rendering/object.dart:1724:7)
#32     RenderProxyBoxMixin.performLayout (package:flutter/src/rendering/proxy_box.dart:105:13)
#33     RenderObject.layout (package:flutter/src/rendering/object.dart:1724:7)
#34     _RenderCupertinoAlert.performLayout (package:flutter/src/cupertino/action_sheet.dart:682:20)
#35     RenderObject.layout (package:flutter/src/rendering/object.dart:1724:7)
#36     RenderProxyBoxMixin.performLayout (package:flutter/src/rendering/proxy_box.dart:105:13)
#37     RenderObject.layout (package:flutter/src/rendering/object.dart:1724:7)
#38     RenderProxyBoxMixin.performLayout (package:flutter/src/rendering/proxy_box.dart:105:13)
#39     _RenderCustomClip.performLayout (package:flutter/src/rendering/proxy_box.dart:1232:11)
#40     RenderObject.layout (package:flutter/src/rendering/object.dart:1724:7)
#41     RenderFlex.performLayout (package:flutter/src/rendering/flex.dart:806:17)
#42     RenderObject.layout (package:flutter/src/rendering/object.dart:1724:7)
#43     RenderConstrainedBox.performLayout (package:flutter/src/rendering/proxy_box.dart:259:13)
#44     RenderObject.layout (package:flutter/src/rendering/object.dart:1724:7)
#45     RenderPadding.performLayout (package:flutter/src/rendering/shifted_box.dart:206:11)
#46     RenderObject.layout (package:flutter/src/rendering/object.dart:1724:7)
#47     RenderProxyBoxMixin.performLayout (package:flutter/src/rendering/proxy_box.dart:105:13)
#48     RenderObject.layout (package:flutter/src/rendering/object.dart:1724:7)
#49     RenderPadding.performLayout (package:flutter/src/rendering/shifted_box.dart:206:11)
#50     RenderObject.layout (package:flutter/src/rendering/object.dart:1724:7)
#51     RenderProxyBoxMixin.performLayout (package:flutter/src/rendering/proxy_box.dart:105:13)
#52     RenderObject.layout (package:flutter/src/rendering/object.dart:1724:7)
#53     RenderProxyBoxMixin.performLayout (package:flutter/src/rendering/proxy_box.dart:105:13)
#54     RenderObject.layout (package:flutter/src/rendering/object.dart:1724:7)
#55     RenderProxyBoxMixin.performLayout (package:flutter/src/rendering/proxy_box.dart:105:13)
#56     RenderObject.layout (package:flutter/src/rendering/object.dart:1724:7)
#57     RenderPositionedBox.performLayout (package:flutter/src/rendering/shifted_box.dart:392:13)
#58     RenderObject.layout (package:flutter/src/rendering/object.dart:1724:7)
#59     RenderProxyBoxMixin.performLayout (package:flutter/src/rendering/proxy_box.dart:105:13)
#60     RenderObject.layout (package:flutter/src/rendering/object.dart:1724:7)
#61     RenderProxyBoxMixin.performLayout (package:flutter/src/rendering/proxy_box.dart:105:13)
#62     RenderObject.layout (package:flutter/src/rendering/object.dart:1724:7)
#63     RenderProxyBoxMixin.performLayout (package:flutter/src/rendering/proxy_box.dart:105:13)
#64     RenderOffstage.performLayout (package:flutter/src/rendering/proxy_box.dart:3168:13)
#65     RenderObject.layout (package:flutter/src/rendering/object.dart:1724:7)
#66     RenderStack.performLayout (package:flutter/src/rendering/stack.dart:505:15)
#67     RenderObject._layoutWithoutResize (package:flutter/src/rendering/object.dart:1584:7)
#68     PipelineOwner.flushLayout (package:flutter/src/rendering/object.dart:844:18)
#69     AutomatedTestWidgetsFlutterBinding.drawFrame (package:flutter_test/src/binding.dart:977:23)
#70     RendererBinding._handlePersistentFrameCallback (package:flutter/src/rendering/binding.dart:283:5)
#71     SchedulerBinding._invokeFrameCallback (package:flutter/src/scheduler/binding.dart:1102:15)
#72     SchedulerBinding.handleDrawFrame (package:flutter/src/scheduler/binding.dart:1041:9)
#73     AutomatedTestWidgetsFlutterBinding.pump.<anonymous closure> (package:flutter_test/src/binding.dart:872:9)
#76     TestAsyncUtils.guard (package:flutter_test/src/test_async_utils.dart:69:41)
#77     AutomatedTestWidgetsFlutterBinding.pump (package:flutter_test/src/binding.dart:859:27)
#78     WidgetTester.pumpAndSettle.<anonymous closure> (package:flutter_test/src/widget_tester.dart:424:23)
#81     TestAsyncUtils.guard (package:flutter_test/src/test_async_utils.dart:69:41)
#82     WidgetTester.pumpAndSettle (package:flutter_test/src/widget_tester.dart:419:27)
#83     main.<anonymous closure> (file:///Users/ardatugay/Documents/degerly/degerly_app/test/temp.dart:69:18)
<asynchronous suspension>
#84     testWidgets.<anonymous closure>.<anonymous closure> (package:flutter_test/src/widget_tester.dart:124:25)
#85     TestWidgetsFlutterBinding._runTestBody (package:flutter_test/src/binding.dart:696:19)
<asynchronous suspension>
#88     TestWidgetsFlutterBinding._runTest (package:flutter_test/src/binding.dart:679:14)
#89     AutomatedTestWidgetsFlutterBinding.runTest.<anonymous closure> (package:flutter_test/src/binding.dart:1050:24)
#95     AutomatedTestWidgetsFlutterBinding.runTest (package:flutter_test/src/binding.dart:1047:15)
#96     testWidgets.<anonymous closure> (package:flutter_test/src/widget_tester.dart:121:22)
#97     Declarer.test.<anonymous closure>.<anonymous closure>.<anonymous closure> (package:test_api/src/backend/declarer.dart:171:27)
<asynchronous suspension>
#98     Invoker.waitForOutstandingCallbacks.<anonymous closure> (package:test_api/src/backend/invoker.dart:242:15)
#103    Invoker.waitForOutstandingCallbacks (package:test_api/src/backend/invoker.dart:239:5)
#104    Declarer.test.<anonymous closure>.<anonymous closure> (package:test_api/src/backend/declarer.dart:169:33)
#109    Declarer.test.<anonymous closure> (package:test_api/src/backend/declarer.dart:168:13)
#110    Invoker._onRun.<anonymous closure>.<anonymous closure>.<anonymous closure>.<anonymous closure> (package:test_api/src/backend/invoker.dart:392:25)
#124    _Timer._runTimers (dart:isolate-patch/timer_impl.dart:384:19)
#125    _Timer._handleMessage (dart:isolate-patch/timer_impl.dart:418:5)
#126    _RawReceivePortImpl._handleMessage (dart:isolate-patch/isolate_patch.dart:174:12)
(elided 32 frames from class _FakeAsync, package dart:async, package dart:async-patch, and package stack_trace)

The following RenderObject was being processed when the exception was fired: _RenderSingleChildViewport#45130 relayoutBoundary=up26 NEEDS-PAINT NEEDS-COMPOSITING-BITS-UPDATE:
  needs compositing
  creator: _SingleChildViewport ← IgnorePointer-[GlobalKey#fe1d3] ← Semantics ← _PointerListener ←
    Listener ← _GestureSemantics ←
    RawGestureDetector-[LabeledGlobalKey<RawGestureDetectorState>#1dce5] ← _PointerListener ← Listener
    ← _ScrollableScope ← _ScrollSemantics-[GlobalKey#76878] ← RepaintBoundary ← ⋯
  parentData: <none> (can use size)
  constraints: BoxConstraints(w=584.0, 0.0<=h<=474.7)
  size: Size(584.0, 128.3)
This RenderObject had the following descendants (showing up to depth 5):
    child: _RenderCupertinoAlertActions#a8616 relayoutBoundary=up27 NEEDS-PAINT NEEDS-COMPOSITING-BITS-UPDATE
      child 1: RenderPointerListener#09535 relayoutBoundary=up28 NEEDS-PAINT NEEDS-COMPOSITING-BITS-UPDATE
        child: RenderSemanticsGestureHandler#fa2e9 relayoutBoundary=up29 NEEDS-PAINT NEEDS-COMPOSITING-BITS-UPDATE
          child: RenderPointerListener#953ff relayoutBoundary=up30 NEEDS-PAINT NEEDS-COMPOSITING-BITS-UPDATE
            child: RenderConstrainedBox#35857 relayoutBoundary=up31 NEEDS-PAINT NEEDS-COMPOSITING-BITS-UPDATE
      child 2: RenderPointerListener#b0c2a relayoutBoundary=up28 NEEDS-PAINT NEEDS-COMPOSITING-BITS-UPDATE
        child: RenderSemanticsGestureHandler#0f496 relayoutBoundary=up29 NEEDS-PAINT NEEDS-COMPOSITING-BITS-UPDATE
          child: RenderPointerListener#4ab52 relayoutBoundary=up30 NEEDS-PAINT NEEDS-COMPOSITING-BITS-UPDATE
            child: RenderConstrainedBox#12ddb relayoutBoundary=up31 NEEDS-PAINT NEEDS-COMPOSITING-BITS-UPDATE

Analyzer returns no issues for the test file above.

[✓] Flutter (Channel stable, v1.12.13+hotfix.9, on Mac OS X 10.15.3 19D76, locale en-US)
    • Flutter version 1.12.13+hotfix.9 at /Users/ardatugay/flutter
    • Framework revision f139b11009 (10 days ago), 2020-03-30 13:57:30 -0700
    • Engine revision af51afceb8
    • Dart version 2.7.2

[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.0-rc1)
    • Android SDK at /Users/ardatugay/Library/Android/sdk
    • Android NDK location not configured (optional; useful for native profiling support)
    • Platform android-29, build-tools 30.0.0-rc1
    • ANDROID_HOME = /Users/ardatugay/Library/Android/sdk
    • Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_212-release-1586-b4-5784211)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 11.3.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 11.3.1, Build version 11C504
    • CocoaPods version 1.8.4

[✓] Android Studio (version 3.6)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin version 45.0.1
    • Dart plugin version 192.7761
    • Java version OpenJDK Runtime Environment (build 1.8.0_212-release-1586-b4-5784211)

[✓] Connected device (1 available)
    • iPhone 11 Pro • CD48D51E-3856-451D-A796-45CEE30D40C5 • ios • com.apple.CoreSimulator.SimRuntime.iOS-13-1 (simulator)

• No issues found!

I guess I can use a shorter Text for now as a workaround to get this test passed, but is there a better way to fix this problem?

Reproducible on the latest master 1.22.0-10.0.pre.281.

flutter doctor -v
[√] Flutter (Channel master, 1.22.0-10.0.pre.281, on Microsoft Windows [Version 10.0.19041.508], locale en-US)
    • Flutter version 1.22.0-10.0.pre.281 at C:\Development\flutter_master
    • Framework revision 511367aa5a (8 hours ago), 2020-09-21 15:33:32 -0700
    • Engine revision 4b8477d115
    • Dart version 2.10.0 (build 2.10.0-142.0.dev)

[√] Android toolchain - develop for Android devices (Android SDK version 30.0.1)
    • Android SDK at C:\Users\marku\AppData\Local\Android\sdk
    • Platform android-30, build-tools 30.0.1
    • Java binary at: C:\Users\marku\AppData\Local\JetBrains\Toolbox\apps\AndroidStudio\ch-0\193.6626763\jre\bin\java
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b01)
    • All Android licenses accepted.

[√] Chrome - develop for the web
    • Chrome at C:\Program Files (x86)\Google\Chrome\Application\chrome.exe

[√] Visual Studio - develop for Windows (Visual Studio Community 2019 16.6.5)
    • Visual Studio at C:\Program Files (x86)\Microsoft Visual Studio\2019\Community
    • Visual Studio Community 2019 version 16.6.30320.27
    • Windows 10 SDK version 10.0.18362.0

[√] Android Studio (version 4.0)
    • Android Studio at C:\Users\marku\AppData\Local\JetBrains\Toolbox\apps\AndroidStudio\ch-0\193.6626763
    • Flutter plugin version 47.1.2
    • Dart plugin version 193.7361
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b01)

[√] Connected device (5 available)
    • sdk gphone x86 arm (mobile) • emulator-5554 • android-x86    • Android 11 (API 30) (emulator)
    • Windows (desktop)           • windows       • windows-x64    • Microsoft Windows [Version 10.0.19041.508]
    • Web Server (web)            • web-server    • web-javascript • Flutter Tools
    • Chrome (web)                • chrome        • web-javascript • Google Chrome 85.0.4183.102
    • Edge (web)                  • edge          • web-javascript • Microsoft Edge 85.0.564.51

• No issues found!

Related to https://github.com/flutter/flutter/issues/49478 in some way?

I cannot reproduce this on latest master

flutter doctor -v
[√] Flutter (Channel master, 2.5.0-7.0.pre.83, on Microsoft Windows [Version 10.0.19041.1110], locale ru-RU)
    • Flutter version 2.5.0-7.0.pre.83 at C:\dev\src\flutter
    • Upstream repository git@github.com:nt4f04und/flutter.git
    • FLUTTER_GIT_URL = git@github.com:nt4f04und/flutter.git
    • Framework revision 06be7e5392 (4 hours ago), 2021-08-15 14:37:02 -0400
    • Engine revision 1af0a20793
    • Dart version 2.15.0 (build 2.15.0-15.0.dev)

[!] Android toolchain - develop for Android devices (Android SDK version 30.0.2)
    • Android SDK at C:\Users\danya\AppData\Local\Android\sdk
    X cmdline-tools component is missing
      Run `path/to/sdkmanager --install "cmdline-tools;latest"`
      See https://developer.android.com/studio/command-line for more details.
    X Android license status unknown.
      Run `flutter doctor --android-licenses` to accept the SDK licenses.
      See https://flutter.dev/docs/get-started/install/windows#android-setup for more details.

[√] Chrome - develop for the web
    • Chrome at C:\Program Files\Google\Chrome\Application\chrome.exe

[√] Visual Studio - develop for Windows (Visual Studio Community 2019 16.7.7)
    • Visual Studio at C:\Program Files (x86)\Microsoft Visual Studio\2019\Community
    • Visual Studio Community 2019 version 16.7.30621.155
    • Windows 10 SDK version 10.0.19041.0

[√] Android Studio (version 4.1)
    • Android Studio at C:\Program Files\Android\Android Studio
    • Flutter plugin can be installed from:
       https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
       https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b01)

[√] IntelliJ IDEA Community Edition (version 2020.3)
    • IntelliJ at C:\Program Files\JetBrains\IntelliJ IDEA Community Edition 2020.3.3
    • Flutter plugin can be installed from:
       https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
       https://plugins.jetbrains.com/plugin/6351-dart

[√] VS Code (version 1.59.0)
    • VS Code at C:\Users\danya\AppData\Local\Programs\Microsoft VS Code
    • Flutter extension version 3.25.0

[√] Connected device (4 available)
    • Redmi Note 5 (mobile)   • 40c9f14       • android-arm64  • Android 9 (API 28)
    • sdk gphone x86 (mobile) • emulator-5554 • android-x86    • Android 11 (API 30) (emulator)
    • Windows (desktop)       • windows       • windows-x64    • Microsoft Windows [Version 10.0.19041.1110]
    • Chrome (web)            • chrome        • web-javascript • Google Chrome 92.0.4515.131
    • Edge (web)              • edge          • web-javascript • Microsoft Edge 92.0.902.67

! Doctor found issues in 1 category.

I can't either so let's close it.

flutter doctor -v
[√] Flutter (Channel master, 2.5.0-7.0.pre.211, on Microsoft Windows [Version 10.0.19043.1165], locale en-GB)
    • Flutter version 2.5.0-7.0.pre.211 at C:\Development\flutter_master
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 56b681247d (5 hours ago), 2021-08-23 20:44:05 -0400
    • Engine revision 926ce0d855
    • Dart version 2.15.0 (build 2.15.0-43.0.dev)

[√] Android toolchain - develop for Android devices (Android SDK version 31.0.0)
    • Android SDK at C:\Users\marku\AppData\Local\Android\sdk
    • Platform android-31, build-tools 31.0.0
    • Java binary at: C:\Users\marku\AppData\Local\JetBrains\Toolbox\apps\AndroidStudio\ch-0\203.7621141\jre\bin\java
    • Java version OpenJDK Runtime Environment (build 11.0.10+0-b96-7249189)
    • All Android licenses accepted.

[√] Chrome - develop for the web
    • Chrome at C:\Program Files\Google\Chrome\Application\chrome.exe

[√] Android Studio (version 2020.3)
    • Android Studio at C:\Users\marku\AppData\Local\JetBrains\Toolbox\apps\AndroidStudio\ch-0\203.7621141
    • Flutter plugin version 59.0.2
    • Dart plugin version 203.8292
    • Java version OpenJDK Runtime Environment (build 11.0.10+0-b96-7249189)

[√] Connected device (2 available)
    • Chrome (web) • chrome • web-javascript • Google Chrome 92.0.4515.131
    • Edge (web)   • edge   • web-javascript • Microsoft Edge 92.0.902.78

• No issues found!


fix: Update go mod to fix CVE-2024-45338

Issue #, if available:
Description of changes:
Testing performed:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@coderbirju you forgot to do a go mod tidy in cmd/


widthOnly bug

if ((ourText.width()  > maxWidth) ||
(ourText.height() > maxHeight && !Opts.widthOnly))
Should be changed to.
if ((ourText.width()  > maxWidth) ||
(ourText.height() > maxHeight) && !Opts.widthOnly) {
If not the widthOnly option doesnt work

This was included in a pull request.


Port galgino to the CYD

This is a really cool looking project that already uses very similar hardware to the CYD, so it should be a relatively light lift to port.
https://github.com/harbaum/galagino

The biggest challenge of this from a hardware point of view is getting 5 buttons working using the broken out pins on the CYD. So that would be the first step I would think

This is merged into Galagino now
https://github.com/harbaum/galagino/pull/21


Improve error reporting to users

Rebase of #3244

Also, we talked a bit more on this. I'm pretty generally -1 on reporting tracebacks to users, so this should explore another method of giving us a way to reference the exception to the user without giving a traceback. We talked about using Sentry to reference a message that we apply a message id to. We can continue on this next week.


Make token Unlimited to expire

I am using oidc-client in an Angular project and our clients want to make the token unlimited, by umlimited I mean when a user log into the project, it never gets expired since they click on the sign-out button.
I was wonder to know how can I do this and also I searched for similar issues but couldn't find any.
Thanks in advance.

That's not a feature of the client library. That's something you'd need to configure in your token server.


endlessly trying to connect to an inaccessible resource

Dbeaver 7.1.1

Open SQL Editor with current connetion asu_prod
Do sql query "query1"
Switched to another programm
After 30minutes switched to Dbeaver. Do sql query "query1". Dbeaver trying to execute query  by very long time 2-7minutes.

And show modal window with error "asu_prod inaccessible"

I swiched database in this window of SQL Editor. But Dbeaver endlessly trying to connect to an inaccessible resource

I closed this SQL Editor window. Open new  SQL Editor window with another resource asu_dev, but Dbeaver endlessly trying to connect to an inaccessible resource asu_prod

access to database doing with the VPN

thanks for the bug report

Maybe check #8405, the symptoms seems rather similar.

in version 7.1.3 this problem not resolved

in version 7.1.4 this problem not resolved

in version 7.1.5 this problem not resolved
Dbeaver endlessly trying to connect to an inaccessible resource

in version 7.2.0 this problem not resolved
Dbeaver endlessly trying to connect to an inaccessible resource

closed as a duplicate of #6903


doc: Update the template fetch snippet

It creates an UndefinedVar error for me. Tested on Nix v2.3.10 and unstable version of Nix just to be sure.

Thanks for the report. Are your refering to:
nix-shell https://github.com/divnix/devos/archive/core.tar.gz -A shell \
  --run "flk get core"

?
If so, I cannot reproduce this error, even after a fresh garbage collection. What's your OS and Arch.

I think @foo-dogsquared means the one without quotes before the change:
 nix-shell -p cachix --run cachix use nrdxp

This one gives the error:
devos  cody 「↪ 𝚫 ⟫8 」  ⎔ on  (us-east-1)
✖1 ❯  nix-shell -p cachix --run cachix use nrdxp
error: --- UndefinedVarError ------------------------------------------------------------------- nix-shell
at: (1:103) from string

     1| with import <nixpkgs> { }; (pkgs.runCommandCC or pkgs.runCommand) "shell" { buildInputs = [ (cachix) (use) (nrdxp) ]; } ""
      |                                                                                ^

undefined variable 'use'
(use '--show-trace' to show detailed location information)


Hybrid List-Table View demo

A hybrid list-table is required to display large data sets in a usable, responsive format.
[@mcarrano to populate this issues with feature requirements for the list view demo]
In this issue, we will address what the requirements are for a content views as well as the visuals for that. Once these are completed, we will proceed with implementation.

[ ] Interaction design requirements
[ ] Visuals
[ ] First checkpoint complete and approved
[ ] CSS
[ ] React
[ ] Second checkpoint complete and approved

Contacts:

IxD @mcarrano
Visual @mceledonia
CSS

@mcarrano will you loop back around with me after you meeting to determine if we need simple table issue.

I have an initial draft of requirements and interaction requirements here for review: https://docs.google.com/document/d/1gyD2_Boy3gOHNl5KVo86274HTT_aqZMQz3coviJZIt8/edit?usp=sharing  There are still a number of requirements that require further elaboration.

@mcarrano React is interested in continuing to use https://reactabular.js.org/#/. Let's have a conversation about technical feasibility about how reactabular fulfills the requirements of this design and what might need to be customized.

Requirements and concept wireframes for data lists and data tables are outlined here: https://docs.google.com/presentation/d/1Ye5Vhj3AqQStZINtqUJ4Y8-mzKX3qBWRmlMQdP-lnwY/edit?usp=sharing.  More analysis is required on optional features including inline editing, row pinning, and Show, Hide, and Reordering table columns. Separate issues have been opened for these as noted above.
A technical feasibility review will be scheduled before handing off to visual design.

A technical feasibility review of current IxD proposal was held on 6/27 that included @andresgalante @dmiller9911 @priley86 @sjcox-rh and @kybaker .  While there are some concerns about the feasibility of the proposed responsive table approach from a CSS perspective, the general consensus was that the Reactabular component referenced above is flexible enough to accomodate this.
Agreed that next steps should be to move along to visual design and then have another feasibility review when high-fidelity mockups are available. We can then prototype and iterate as needed.

This has been broken down into smaller issues:

Data List #198
Data Table #513


Update kuttl tests for clowdjobs

Fixes unsupported event type "Error"

Can you revert the label changes here :) As we reverted :p

/retest

@BlakeHolifield We do need the sleep 90 there however :p


approval of private discussions

Users without permission to create normal discussions who create a private discussion will have their discussion held for approval. However the group having this permission will most likely not be able to access that discussion.
In comparison to Post level permission that we might need to whitelist (eg for Flagging), we need to whitelist the approval permission to access the discussion or allow auto approval or override the creation permission.. That last option might be easiest and fastest.

Fixed this for approvals, we're overriding the check from a Access policy.


Create header

Create a navigation bar with the following specs:

[x] Height 64px
[x] Name on the left
[x] Right contacts (redirect to portfolio)

Done


Migration Point Requirements not correct

On Server 2016, the State Migration Point requires IIS 6 Metabase Compatibility but it is not listed as a requirement on this page

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 9070eb9b-0e5f-a877-e02e-2d1cea2a2b38
Version Independent ID: df251762-f2d6-9f06-4fa9-ec5cea2cca0a
Content: Site prerequisites - Configuration Manager
Content Source: sccm/core/plan-design/configs/site-and-site-system-prerequisites.md
Product: configuration-manager
GitHub Login: @aczechowski
Microsoft Alias: aaroncz

Thanks @FISHMANPET for noting this. I did some research, and I don't know why that was never included. I have some work on this article in the near future and will pick this up at the same time.

After fighting with this for a few days, I discovered it also required asp.net 4.6 (which automatically selected isapi extensions, isapi filters, and .net extensibility 4.6)

I updated this with the 1806 content, which will publish soon. I'm closing this issue.


ci: Create a script to initiate an normal openshift admin user instead of system:admin

system:admin is created automatically when the infrastructure is defined in openshift ci, mainly for the purpose of enabling the infrastructure to interact with the API securely.
By default system:admin uses certificate not the token to login to the cluster. Which mean system:admin doesn't have a password or token like other normal users have.
This PR unblock: https://github.com/redhat-appstudio/e2e-tests/pull/63

/retest

/retest


missing main field in package.json

your package seems to fail resolution with eslint because it lacks a main field in package.json.
For example, on @tinyhttp/content-disposition, package.json should include "main": "./dist/index.js",
without the main field, normal imports do not work:
import { contentDisposition } from "@tinyhttp/content-disposition"; //eslint cannot find the module

but the following works:
import { contentDisposition } from "@tinyhttp/content-disposition/dist";

see import-js/eslint-plugin-import#2132 for eslint point of view:

A package just for the browser still needs node behavior, even if that’s “nothing”, so having it lack a main is a bug.

"main" field is for CommonJS
tinyhttp is ESM-only and uses "exports" instead.
so not planning on returning "main" back, it's an eslint-plugin-import issue not tinyhttp's, sorry :c

for future reference (I adhere to your point of view), there are issues on eslint-plugin-import to support exports:

import-js/eslint-plugin-import#1810
import-js/eslint-plugin-import#1868


Add a CHANGELOG.md

Hey @shama would you be open to me adding a changelog.md to the project?

Otherwise just telling here what the breaking changes from v4 -> v5 are would be useful

@bcomnes Yep! If you think it would be helpful. Feel free to do whatever you think is best for this project. Thanks a bunch for all your help!


Support arm64

Description

Support ARM64 build and tests
Review Procedure

Remarks
CI passed on arm64 runner.
https://github.com/autowarefoundation/AutowareTestCoreRepository/actions/runs/1433428112

Pre-Review Checklist for the PR Author
PR Author should check the checkboxes below when creating the PR.

[x] Read pull request guidelines
[x] Code follows coding guidelines
[ ] Assign PR to reviewer

Checklist for the PR Reviewer
Reviewers should check the checkboxes below before approval.

[ ] Commits are properly organized and messages are according to the guideline
[ ] Code follows coding guidelines
[ ] (Optional) Unit tests have been written for new behavior
[ ] PR title describes the changes

Post-Review Checklist for the PR Author
PR Author should check the checkboxes below before merging.

[ ] All open points are addressed and tracked via issues or tickets
[ ] Write release notes

CI Checks

Build and test for PR / build-and-test-pr: Required to pass before the merge.
Build and test for PR / clang-tidy-pr: NOT required to pass before the merge. It is up to the reviewer(s). Found false positives? See the guidelines.
Check spelling: NOT required to pass before the merge. It is up to the reviewer(s). See here if you want to add some words to the spell check dictionary.

This PR has been moved to https://github.com/autowarefoundation/autoware.universe/pull/154. Closing...


Add github-server-url option (and more)

This PR would...

[x] Add a github-server-url input option
[x] Change the description of repository to reflect that it's just user/repo now
[x] Change the descriptions in the readme to match
[x] Pass it in action.yml to the script
[x] Use it in the bash script
[x] Fix the test.yml token param that was still x:$TOKEN to just the default

This PR would also do

[x] Use gh CLI instead of plain git
[x] Use more GITHUB_* env vars to override/replace those from https://docs.github.com/en/actions/learn-github-actions/variables#default-environment-variables with the ones that the user wants (i.e. replace $GITHUB_TOKEN with $INPUT_TOKEN)
[ ] ❓ Use GIT_* env vars to override/setup git features as defined https://git-scm.com/book/en/v2/Git-Internals-Environment-Variables
[x] Remove git_exists.sh since we use catching-style instead of pretesting-style code for error handling
[x] Move src/index.sh to index.sh since having a folder for one file seems redundant. if we add more files in the future, re-add the src/ folder.
[x] Fix up some of the error print messaging >&2 stderr stuff when repo clone fails
these things were outside the scope of what i originally wanted to do, but just kinda happened as i made more changes...

using more $GITHUB_* env vars has the added benefit of interop-ing well with gh since gh sniffs $GITHUB_TOKEN for its auth token
closes #68
closes #67
closes #59 via using gh instead of rolling our own
closes #2 via using gh which handles that for us

@spenserblack requesting review
this is a pretty big pr

Btw do you know what the gh repo sync command does? Is it akin to git pull or git push or both? I'm confused
https://cli.github.com/manual/gh_repo_sync

Never actually used repo sync, since I just do pull/push. But it looks like it's similar to VS Code's sync. So it pulls if the repo is behind, and pushes if the repo is ahead. Personally I'd prefer to continue using pull/push, but I guess some would want a catch-all command before and after making changes :shrug:

I've been doing more github action wiki related stuff in https://github.com/Andrew-Chen-Wang/github-wiki-action/tree/jcbhmr

closing in favor or more prs for things from https://github.com/Andrew-Chen-Wang/github-wiki-action/issues/30 #73


Missing gdk_pixbuf_new_from_file()

There're a lot gdk_pixbuf missing it seems... I add them.

@GuillaumeGomez Great, thank you!

Take a look at #23.

And it's done.


Upgrade from 3.0.4 to <IP_ADDRESS>-beta failed with "This functionality is not implemented" exception

Bug
Version Number of Plugin: <IP_ADDRESS>-beta
Device Tested On:
Simulator Tested On: Emulator 8.1 720P 4.7 inch
Expected Behavior
Application launched and I can get the position
Actual Behavior
This functionality is not implemented in the portable version of this assembly.  You should reference the NuGet package from your main application project in order to reference the platform-specific implementation.
Steps to reproduce the Behavior
Application was launching correctly and I was able to get my position.
I just upgraded from 3.0.4 to <IP_ADDRESS>-beta.
Now I get this error above.

4.0 no longer support windows phone or store 8

Hello,
Do you mean 8.0 only or also 8.1 ?

Thank you.
Alek

I have it clearly defined on the main Readme. I am dropping support for Windows Phone 8, 8.1, and Windows Store 8.X as far as new features and including them in new packages. With Visual Studio 2017 out of the box the support has been removed and that is my main environment that I use for development. The old code will remain in the repo for reference, but no new work will be done and they will no longer ship with new packages. This is the first to drop support and all others to follow throughout the year.


Error: sdp-error DOMException: "Cannot create offer when there are no valid transceivers." RTCMultiConnection.min.js:15:26845

hi
when i use option:
connection.dontAttachStream = true;
connection.dontCaptureUserMedia = true;
then when orther user disconnect then chrome show error on receive and not audio
sdp-error DOMException: "Cannot create offer when there are no valid transceivers." RTCMultiConnection.min.js:15:26845

can you help me ?

@tinamore  we have been waiting some information from @muaz-khan  i think this is major problem.
wish to get information soon.


Nightly email reports

A core hypothesis for nyrkiö is that most users will want to be notified whenever change points are detected rather than and manually logging into the web app and looking at the dashboards. Users should be able to enable nightly reports via some setting on a profile page.
Open questions

How do we want to handle reporting about the same change points? For instance, if we detect a change point for a commit on day N, should we include that change point in every report for day N + 1, N + 2, ... etc? In the past we've "cropped" change points after 7 days to reduce the noise. Should we do the same?
Does it actually make sense to report if there are no change points? This is how the current hunter code works -- you'll get an email that says "Hunter did not detect any change points". Maybe yes if we hit the API endpoint but no if it's the period job running.
Should we allow users to generate reports for their results on demand? This is currently available via the /v0/report endpoint but might allow users to DoS our email provider and disrupt the email reporting mechanism for all users. We probably need some rate limiting in the future but can skip this problem for now.

Overview of changes required

Flesh out the nascent /v0/user/config endpoint which allows user's to configure their account. We will need validation of nightly email config.
Need to add minimal user profile pages. Can just have the one option for nightly reports for now.
Some internal periodic job that finds all users that have opted in to nightly reports and computes change points for all their tests and sends an email to their login email address if change points are found
Currently we only send email to<EMAIL_ADDRESS>This needs to be the user's registered email address.
The author of the reports needs to be something like<EMAIL_ADDRESS>and not<EMAIL_ADDRESS>We may need a new postmark account?

Testing

We can use the existing data for rocksdb or tigerbeetle, which already has change points, and forcibly trigger the email reporting via the /v0/report endpoint.
https://github.com/nyrkio/gh-scripts contains a replay-commits script (currently only for the rocksdb repo) that will cause CircleCI jobs to execute for every commit between a local HEAD and the upstream HEAD for the main branch. This is a long-term test which we can configure and leave running for a few weeks.

Future enhancements

Configure reporting at the organisation level
Configure reporting per-project (users may not want to get notifications for toy or dummy projects)
Rate limiting calls to /v0/report
Embed urls in the email so that users can click and be take straight to http://nyrk.io with the dashboard displayed.

Closing as unwanted for now. Can always reopen later.

Email reports are unwanted? :-D
Can someone take me back to the 90s please ...


Write docs on clustering inside Kubernetes

[ ] Provide sample k8s configs
[ ] Describe configs and release gotchas (-sname, ports, epmd, show sample docker container)

We use distillery, first we need to set custom vm.args file, this is done via rel/config.exs:
use Mix.Releases.Config,
  default_release: :default,
  default_environment: :default

environment :default do
  set pre_start_hook: "bin/hooks/pre-start.sh"
  set dev_mode: false
  set include_erts: false
  set include_src: false
  set overlays: [
    {:template, "rel/templates/vm.args.eex", "releases/<%= release_version %>/vm.args"}
  ]
end

release :my_app do
  set version: current_version(:my_app)
  set applications: [ # Don't forget to set your apps permanent :)
    gateway: :permanent
  ]
end

Sample rel/templates/vm.args.ex file:
## Name of the node
-name <%= release_name %>@${POD_IP}

## Cookie for distributed erlang
-setcookie ${ERLANG_COOKIE}

## Heartbeat management; auto-restarts VM if it dies or becomes unresponsive
## (Disabled by default..use with caution!)
##-heart

## Enable kernel poll and a few async threads
##+K true
##+A 5

## Increase number of concurrent ports/sockets
##-env ERL_MAX_PORTS 4096

## Tweak GC to run more often
##-env ERL_FULLSWEEP_AFTER 10

# Enable SMP automatically based on availability
-smp auto

-kernel inet_dist_listen_min ${LISTEN_DIST_MIN} inet_dist_listen_max ${LISTEN_DIST_MAX}

To export POD_IP env add to env of your pod spec:
- name: POD_IP
  valueFrom:
    fieldRef:
      fieldPath: status.podIP

Also you need to set Erlang magic cookie, we recommend to base64 encode it:
- name: ERLANG_COOKIE
   value: "cmFuZG9tQVNESmlqYXNkOTkzOENvb3NkbGtqc2RFcmxhbkNvb2sK"

Optionally you can set LISTEN_DIST_MIN and LISTEN_DIST_MAX environment variables.


Can't i replace the client_id with my client_id ?

i register a twitch developer account, and create an application. so i replace the smartbox client_id with my client_id.
it can access oauth, but gql request response 401. plz tell me how to get the correct client_id.

Hello there o/
This project isn't built with CLIENT_ID replacement in mind. Specifically, changing anything about it will break everything. This isn't some kind of a Twitch API wrapper, and you cannot use a "developer account" CLIENT_ID in it,
What exactly are you trying to do?


Alias file

It would be great if LIKO had an "alias" file where you can define aliases to common programs. This file would be a Lua file which returns a table containing the alias as key and the actual command as value.
return {
   dir = 'ls',
   world = 'hello -s"world"',
   complex = function (a1, a2)
       return "something -s".. a1 .." -j".. (a2 + 2)
   end
}

The OS would look for an alias here before actually looking into the Programs. If an alias is found and it is a string, then that string is used as command with the original arguments appended. If the value is a function it will be called like any other program, with it's arguments but the return value will be a command to execute.

To fundament some more, this is a really common feature in terminal applications, all Unix/POSIX systems support this, and even PowerShell does.
Also it will help to avoid duplicate commands as is the case of dir/ls and will help users to automate stuff by using shorter commands.

It's only some rare cases (dir/ls & shutdown/exit for now), It really doesn't worth it. "K.I.S.S"


Show fewer dots when downloading the wrapper

This would look a lot nicer than the 3367 dots we are currently printing:

With this change we would be printing one dot per downloaded megabyte, 64 altogether for the currently nightly.

How did you test your change exactly? Did you publish a snapshot of your change to a HTTP server?

@bmuschko I think you need to generate a wrapper with his changes.
So install, generate the wrapper with the installed version of Gradle using --gradle-version=3.5 (so it'll have a valid download link).  And then try that.
@lptr I think we should aim for ~100 dots (personal opinion)

@big-guy Thanks that does the job!
@lptr I agree with Sterling that a couple of dots more would maybe look a bit better.

I took that screenshot when I was running ./gradlew wrapper:check. We apparently have an integration test that fires up Terminal and does all this.

About the number of dots: the terminal in the screenshot can be a bit misleading, as it's 160x40 characters. I like the 64 dots printed currently, because it fits on an 80-wide terminal (the default in many cases) with some room to spare if the distro should grow bigger. It's also nice that currently each dot represents a megabyte.

Do we need anything before this can be merged? I can change the number of dots, but if you don't feel strongly about it, I'd keep it as it is.

It definitely looks better than before. +1 with moving ahead. We can see how the community reacts to it and tweak the number of dots as needed.


throwing an error for invalid periods (e.g. with a typo)

Is your feature request related to a problem? Please describe.
moment().add(1, 'montth');

This just returns the current time so it leads to bugs when I do a typo in the period name.
Describe the solution you'd like
I would like it to throw an error if the period is invalid. Maybe it should be done in a next major release.
Describe alternatives you've considered
At least a warning should be logged.
Additional context
It's related to https://github.com/moment/moment/issues/1805

Thanks for opening this request.
Probably, a solution will be handled like in #1805.
All the best.


Changing default behavior for RateLimiter

The current documentation describes the default behaviour for a RateLimiter, which returns a 429 (Too Many Requests)
extract from documentation
"The RequestRateLimiter GatewayFilter factory uses a RateLimiter implementation to determine if the current request is allowed to proceed. If it is not, a status of HTTP 429 - Too Many Requests (by default) is returned."
Can you please suggest a way to override this default behaviour or provide a custom implementation. I am looking to route the requests that exceed the Ratelimiting criteria to different instances.

The way you describe is the best way and per second is the only way to configure this.

If you would like us to look at this issue, please provide the requested information. If the information is not provided within the next 7 days this issue will be closed.

Closing due to lack of requested feedback. If you would like us to look at this issue, please provide the requested information and we will re-open the issue.


Wiki Documentation update needed for CLI command options listing

The freerdp CLI Options listed on..."

https://github.com/FreeRDP/FreeRDP/wiki/CommandLineInterface

Must be quite outdated as it does not list/describe many CLI options listed by executing:

$ xfreerdp3 --help

Just a couple examples.
The CommandLineInterface pages is completely missing these entirely:
 /gfx[: [[progressive[:on|off]|RFX[:on|off]|AVC420[:on|off]AVC444[:on|off]],
           mask:<value>,small-cache[:on|off],thin-client[:on|off],progressive[
           :on|off]]]                 RDP8 graphics pipeline
    /gfx-h264[: [[AVC420|AVC444],mask:<value>]]
                                      [DEPRECATED, use /gfx:avc420] RDP8.1
                                      graphics pipeline using H264 codec
    +gfx-progressive                  Enable [DEPRECATED, use /gfx:progressive]
                                      RDP8 graphics pipeline using progressive
                                      codec
    -gfx-small-cache                  Disable [DEPRECATED, use
                                      /gfx:small-cache] RDP8 graphics pipeline
                                      using small cache mode
    +gfx-thin-client                  Enable [DEPRECATED, use /gfx:thin-client]
                                      RDP8 graphics pipeline using thin client
                                      mode

+home-drive             Enable Redirect user home as share

@bmullan yes, best only rely on the docs directly from the binary.
the wiki is hopelessly outdated in some areas and I don´t have the time to  update all of it.
accepting pull requests / issuse with git bundles for improvement, but had to disable direct editing due to vandalism.


[Fix] prop-types: false positives since upgrading typescript-eslint to v8

Hello!
I'd like to start by thanking the amazing staff at this bookshop for all their hard work.
I'm thrilled to present my first contribution, which is a correction to the false positive of prop-types rule that have been raised since version v8 of typescript-eslint.
Since version v8, it seems that the typeParameters parameter no longer exists, so I've replaced it with the typeArguments parameter, which is equivalent and all without causing a breaking change.
Closes #3796

The change looks good, but I'd prefer not to add code to support v8 of typescript-eslint when we're not even testing on v6 yet (see #3629, which i think subsumes this PR)

Thanks for your reply, I was thinking more of this PR as a patch while waiting for full compatibility.
I see that your PR has been going on for a while and I understand perfectly that some things take time.
Now it's up to you to decide whether or not to add this modification.

Obsoleted by #3629.


Preprocessing.py load_image -> load_base64

I believe there might be an inconsistency in the logic of parsing for base64 encoded strings.
The format of input should be something like :
data:image/jpeg;base64,/9j/4AAQS....
where the image type is clearly indicated right before the comma.
The parser however does not consider this and, don't know how relevant is, could load any valid image while, for example, in streaming.py only jpg, jpeg, png are considered

Right, we should raise an error if type of base64 is not one of these types.

Closed with PR - https://github.com/serengil/deepface/pull/1059


[runtime] post_processor

This is a follow-up PR to issue https://github.com/wenet-e2e/wenet/issues/583 and PR https://github.com/wenet-e2e/wenet/pull/494.
Current post-processing pipeline (function PostProcessor::Process()):

process blank/space (done, this PR)
itn and punctuation (WIP, will open a new PR)

decoding test_clean(librispeech) with PostProcessor:
LM-tgmed(3-gram.pruned.1e-7.arpa.gz) + attention rescoring

Previous result:


Remove generated api-docs

Cleanup of apparently unused generated API docs checked into Git.
/cc @inteon
/cc @SgtCoDFish

/approve
/lgtm


Replace the type of fragments field with IntObjectMap in SctpMessageCompletionHandler.java.

Motivation:
The type IntObjectMap with the key of primitive int can help lower the cost of boxing and unboxing,  and improve performance. I think it's more suitable for fragments field in SctpMessageCompletionHandler.java.
Modification:
Just replace the type of fragments field with IntObjectMap.
Result:
Improve performance slightly while decoding sctp message.

@netty-bot test this please

@seedeed good catch!


chore: minor housekeeping changes

Issue #, if available:
Description of changes:
Changes:

child_exceptions should be a tuple
remove unecessary else statements
add pragma: no cover for overload functions
add test for an invalid DynamoDBPersistenceLayer

Checklist

[X] Meet tenets criteria
[X] Update tests
[X] Update docs
[X] PR title follows conventional commit semantics

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

All pretty minor and optional @heitorlessa

Codecov Report

Merging #912 (2a4c56b) into develop (849e003) will increase coverage by 0.11%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop     #912      +/-   ##
===========================================
+ Coverage    99.79%   99.90%   +0.11%
===========================================
  Files          118      118
  Lines         5262     5258       -4
  Branches       596      596
===========================================
+ Hits          5251     5253       +2
+ Misses           6        1       -5
+ Partials         5        4       -1

Impacted Files
Coverage Δ

aws_lambda_powertools/utilities/parser/parser.py
100.00% <ø> (+6.06%)
:arrow_up:

aws_lambda_powertools/utilities/batch/base.py
99.21% <100.00%> (+1.53%)
:arrow_up:

...ools/utilities/idempotency/persistence/dynamodb.py
97.33% <0.00%> (+2.66%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 849e003...2a4c56b. Read the comment docs.


[orientdb] put db conn stuff in sync method

All db connection and creation logic is the same, it is just pulled into
a synchronized method so that multiple threads run through the
connection process one at a time.
Fixes #571

Would there be issues here if multiple YCSB clients are run at once? This will only help fix multiple threads in one client correct?
Does the initdb need to create the db? Is it possible to make it necessary to have the db already exist as a prerequisite? Like the other bindings ie: Solr and Cassandra

We could add a note to the README for the folks who use multiple Client invocations, letting them know how to create it in advance?

@risdenk

Would there be issues here if multiple YCSB clients are run at once? This will only help fix multiple threads in one client correct?

Correct.

Does the initdb need to create the db? Is it possible to make it necessary to have the db already exist as a prerequisite? Like the other bindings ie: Solr and Cassandra

So, the OrientDB client is the only one that I am aware of that actually creates a database for you. All others require it to be present. I kept this functionality because it was there from the initial creation of the client. I'm ok with removing it, or just writing a note about that specific scenario.

Either a note or removal sounds fine by me.
Could also move the creation into a utility class that the README references. I think I've seen a couple of those.

I decided to keep the db creation functionality in place since 1) it works and 2) mongodb does "create" a database if it doesn't already exist, although in a much more passive way.
I added a note about it to the README

+1


chore: enable Dependabot v2

Description of changes:
https://github.blog/2020-06-01-keep-all-your-packages-up-to-date-with-dependabot/
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Closing since https://github.com/awslabs/smithy-typescript/issues/220 resolves this.


Don't show additional-flags token in usage if all flags are required

As completion- and help-flags are not ignored when parsed in FlagSummary(), [<flags>] token will always be displayed in usage line even if there are no more possible flags to choose from.

Thanks!


Return an error when requested ReadTimeout is larger than supported max of 25.5s

Took me a while of debugging to find out that timeouts given to ReadTimeout never go longer than 25.5 s. I work with a modem that can take 3 minutes to respond to certain commands.
Would by nice to have the init error out when a timeout higher than 25.5s is given, instead of silently limiting the min/max values of ReadTimeout.

I ran into the same. It would also be great to document why this limit exists in the first place. Could it be increased?


Compilation warnings handled

What kind of compilation warning is it for?

Below is the warning message i got:

warning: comparison between signed and unsigned integer expressions [-Wsign-compare]

@lu-wang-g : The code is updated now, please check and approve, Thanks!

For simplicity, please use "size_t i = 0 "instead

@lu-wang-g : Updated as per your comment, please check and approve, Thanks!

@lu-wang-g Could you PTAL and approve.

@lu-wang-g Could you PTAL and approve.

Nagging Reviewer @lu-wang-g, @lu-wang-g, @lu-wang-g, @miaout17: You have been added as a reviewer to this pull request. Please add your review or reassign. It has been 15 days with no activity and the awaiting review label has been applied.

Nagging Reviewer @lu-wang-g, @lu-wang-g, @lu-wang-g, @miaout17: You have been added as a reviewer to this pull request. Please add your review or reassign. It has been 30 days with no activity and the awaiting review label has been applied.


Add an option to override default gerrit http credentials

Thank you for the contribution! And sorry for the delay - I missed the notification about your pull request.
Regarding the change, I'd add a button "Test connection", similar to the way how it is implemented in the Gerrit Trigger.
If you have time, I'd be grateful if you can do it. Otherwise I'll do it myself, let me know.
I'll merge your change to the plugin shortly.

When job is running, a build object is passed to peform() method so you can get related gerrit information from it, but how to do that when we are configuring job?

The only way I've found is to allow user to choose a Gerrit server to be used for credentials check. Thank you for the contribution, this feature will be available in the next release


EnvoyGateway v1.0 release

Description:
Tracks everything needed for Envoy Gateway to be reach v1.0 giving users confidence to run it in production

[ ] Majority API Gateway features implemented and exposed using a stable API. Requires upstream Gateway APIs to be graduated (tracked with https://github.com/kubernetes-sigs/gateway-api/discussions/1801)
[ ] Day 2 operations in place

[ ]  Install
[ ]  Observability
[ ]  Triage
[ ]  Upgrade

[ ] Meets some criteria of performance when used at scale

When - TBD

@envoyproxy/gateway-maintainers please feel free to edit this description

Close by https://github.com/envoyproxy/gateway/issues/2249


fix: Crash due to NaN result in normalization

Fixes #14

@lincollincol review needed here

Hello, @thedroiddiv ! Thank you for fixing the issue with NaN in the normalize() function.
Sorry for the late review. I'm currently busy, so I don't have the opportunity to spend more time on my own projects :)
I appreciate any help, so feel free to open pull requests!


TabError: inconsistent use of tabs and spaces in indentation in test_strategy_backtest.py

There is an issue with test_strategy_backtest.py
It raises TabError: inconsistent use of tabs and spaces in indentation in test_strategy_backtest.py
see https://raw.githubusercontent.com/mhallsmoore/qstrader/master/examples/test_strategy_backtest.py
	# Use the TestCompliance component
	compliance = TestCompliance();

	# Use a simulated IB Execution Handler
	execution_handler = IBSimulatedExecutionHandler(
		events_queue, price_handler, compliance
	)

In addition to unit tests, runing in Travis random price generation and sample strategies will help to catch this kind of issue
see https://github.com/mhallsmoore/qsforex/issues/19

Closed by https://github.com/mhallsmoore/qstrader/pull/48


Data: Pro Matches Scheduled Dates/Times

Would it be possible to have the matches for Pro Leagues like Evil 8 and Arena 8 be made to be in the API.
This way our project could be made to be automatic as opposed to manually inputting the dates and times of the matches.
Thank you

+1. Also handy for tournament structure metadata to come along (ie. which event a match belongs to, where in the event the match is placed [bracket position, group stage vs playoffs, etc]).
Bonus would be including per-tournament standings (like the points system used in VG League Splits).

Just updating, this is blocked on some game changes.

Pro matches are there.  The tournament bracket (for now) isn't.  Closing this since it serves the request in the ticket.  @Kazastankas go ahead an make a new one for the bracket info if you like!


Testing project

If testing Entity CRUD functionality consider starting with this:
https://github.com/ChadIImus/Devoops/projects/1#card-78322688

Testing coverage needs to be captured by static analysis tools


Example of tf.scatter_nd contains Session, which is obselete

URL(s) with the issue:
https://www.tensorflow.org/versions/r2.0/api_docs/python/tf/scatter_nd
Please provide a link to the documentation entry, for example:
https://www.tensorflow.org/versions/r2.0/api_docs/python/tf/scatter_nd
Description of issue (what needs changing):
The Code,
with tf.Session() as sess:
      print(sess.run(scatter))

should be replaced with print(scatter), as the Sessions are no longer required in Tensorflow 2.x.
Correct links
Is the link to the source code correct? : NA
Parameters defined
Are all parameters defined and formatted correctly? : Yes
Returns defined
Are return values defined? : Yes
Raises listed and defined
Are the errors defined? No
Usage example
Is there a usage example? : Yes

@worldpeaceaspirer,
Thank you for identifying it. This should be fixed with this CL.

This is fixed with latest TF api docs https://www.tensorflow.org/api_docs/python/tf/scatter_nd
Thanks!


add email address

Added email address
Description

Types of change

Checklist

[x] I confirm that I have the right to submit this contribution under the project's MIT license.
[ ] I ran the tests, and all new and existing tests passed.
[ ] My changes don't require a change to the documentation, or if they do, I've added all required information.

This looks good, I will merge...


What I want to do with If / Else.

What I would like to do is to login to a site, but first check if I'm logged in already. Here's an example:
#SingleInstance Force
#Requires Autohotkey v2.0+
#Include <UIA>
#Include <UIA_Browser>
Run "chrome.exe https://google.com"
WinWaitActive "ahk_exe chrome.exe"
cUIA := UIA_Browser()
cUIA.ElementFromHandle()

if button := cUIA.ElementFromPathExist("VR0/")	; Name:"Google Account: Luis Piña III" button
button.Click()
else
cUIA.WaitElementFromPath("V5t").Click()		; Name:"Sign in"

Can what I want to do be done? If not then could you please consider adding something to this function to make it do so?

That is how you would do it, yes. You might also want to check the Name of the found element to check whether it actually is the correct one:
if (button := cUIA.ElementFromPathExist("VR0/")) && InStr(button.Name, "Google Account")
    button.Click() ; already logged in
else if (button := cUIA.ElementFromPathExist("VR0/")) && (button.Name == "Sign in)
    button.Click() ; click Sign in

GitHub issues is meant for issues with UIA-v2 or concrete feature request, not help requests. Please post your help requests on the AutoHotkey forums or Discord.


MTV-1695 | Add missing NIC for opaque network

Issue: When user has NSXT managed network it is represented as opaque network and the VM has opaque nic.
Fix: Add opaque network model mapping to inventory
Ref: https://issues.redhat.com/browse/MTV-1695

:warning: Please install the  to ensure uploads and comments are reliably processed by Codecov.
Codecov Report
Attention: Patch coverage is 0% with 27 lines in your changes missing coverage. Please review.

Project coverage is 15.63%. Comparing base (b75f9ab) to head (52eb343).
Report is 11 commits behind head on main.

Files with missing lines
Patch %
Lines

...controller/provider/container/vsphere/collector.go
0.00%
18 Missing :warning:

pkg/controller/provider/container/vsphere/model.go
0.00%
6 Missing :warning:

pkg/controller/provider/web/vsphere/network.go
0.00%
2 Missing :warning:

pkg/controller/plan/adapter/vsphere/builder.go
0.00%
1 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1209      +/-   ##
==========================================
- Coverage   15.65%   15.63%   -0.02%
==========================================
  Files         112      112
  Lines       23075    23097      +22
==========================================
  Hits         3612     3612
- Misses      19178    19200      +22
  Partials      285      285

Flag
Coverage Δ

unittests
15.63% <0.00%> (-0.02%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Create create/edit view for Service Account resource type

This PR addresses #5064 by adding a credit/edit view for Service Account resource type.

@neillsom Are there pending changes for this PR?


[master] Upgrade to latest dependencies

Cron. -knative-prow-robot
/cc we don't use Prow
/assign we don't use Prow
Produced via:
./hack/update-deps.sh --upgrade --release v0.21
./hack/update-codegen.sh

Details:
bumping knative.dev/eventing 47ee8fa...1c771ce:
  > 1c771ce Change broker spec to indicate brokerclass should be immutable (# 4827)
  > d7cf344 tracing fixed for apiserversource (# 4842)
  > 1efec2b expose ChannelReference in UnknownChannelError (# 4875)
  > 47d7a02 Update deps (# 4874)
bumping knative.dev/pkg e38bb89...448ae65:
  > 448ae65 Metric unit fixes (# 2018)

Codecov Report

Merging #194 (0195460) into master (3b2123e) will decrease coverage by 0.56%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #194      +/-   ##
==========================================
- Coverage   79.51%   78.95%   -0.57%
==========================================
  Files          20       20
  Lines         708      708
==========================================
- Hits          563      559       -4
- Misses        134      137       +3
- Partials       11       12       +1

Impacted Files
Coverage Δ

pkg/vsphere/adapter.go
62.69% <0.00%> (-3.18%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3b2123e...0195460. Read the comment docs.


Support chatty thread links

Gotta decide how to handle it (use tabs? inline? popup?)

Added a "view in shacknews" link to posts/replies now. Still thinking about how to view linked threads directly.

Added primitive version of this for now, more advanced features to come.


Migrate to profile service badge collection

Badge collection was previously handled by the UD e-commerce backend. That functionality has now been migrated to the profile service, and some adjustments can be made on the profile pages to reflect this change.

/gcbrun


Get User() return user object even  my sts server stopped

In my application  i have run web api and sts server.In running my web application i stopped sts server then reload my web angular application,still i am getting user object from getUser()..
i want to get error if my sts server stopped working.
Here is my code. Please review and getback with solution.
public getCurrentUserValue(): any {
return this.auth.getUser().then(user => {
        if (user && user.access_token && !user.expired) {
            return this.useInfo = user;
        } else if (user && !user.expired) {
            return this.auth.renewToken().then(userInfo => {
                this.getUpdatedUserDetail(userInfo);
                return this.useInfo = userInfo;
            });

        } else { this.onLogin(); }
    }).catch(() => {
        return false;

    });
}

StackOverflow is a better place for such questions. Thanks.