Add underscoreBetweenUppercaseLetters to knexSnakeCaseMappers

Fixes #1676

Coverage increased (+0.003%) to 97.076% when pulling 927ad1a785ab85ffe3607f6a297d7343fd69637b on brianmcd:configure-mapper-underscore into 5b76a4c1e0dee70649d32b8a59383021bb5d5927 on Vincit:master.

Coverage increased (+0.003%) to 97.076% when pulling 927ad1a785ab85ffe3607f6a297d7343fd69637b on brianmcd:configure-mapper-underscore into 5b76a4c1e0dee70649d32b8a59383021bb5d5927 on Vincit:master.

Thank you! Clean implementation and good tests! Wish I got more of these 💯

Thanks for the quick merge!  The up-to-date dev setup instructions, docker containers, and extensive test quite made it really easy to contribute.

This still needs documentation and typescript typings. I can do that, but I'm currently quite busy with my work so it will be a while. If you have more time, I'd be more than happy about a PR for those too.

Sure!  I'm happy to make those updates.  I think docs are missing for the underscoreBeforeDigits option, so I'll add those, too.
Are the relevant pages here and here?
For the TypeScript typings, I added the property here in this PR.  Is there another place I need to add it, or are we good on that part?

Oh sorry I missed the typing change in your PR. That's it for those 👍 And yep, those are the relevant pages. I'll release a new version as soon as the docs are updated.


Use interfaces instead of classes

Hi there,
Is there any way to use interfaces instead of classes on this module? If not, are you aware of a way to convert interfaces into classes programmatically?

Hi @fpereira1.
TypeScript interfaces only exist at compile-time. At runtime (when your code is executed) they do not exist.
There's no way to retrieve interfaces during that time.


Multiple video quality support in ios

Feature Request

Why it is needed
This is required for making the app similar as we are giving quality feature in  android through exoplayer

+1


M1 support

Parallels is working on support for M1 Macs. This is just a blanket issue to ensure compatibility (or document incompatibility) with the M1 version of Parallels. This should probably be parked until at least a beta of Parallels M1 is available.
BTW, I volunteer my M1s as guinea pigs if needed (MBP and DTK).

Since Parallels is now officially supporting Macbook M1 in version 16.5. Is there any update on this?

@alvint @tobernguyen Could you please elaborate - which exact use case are you interested in?
Docker Machine project has been put into the maintenance mode back in 2019 (https://github.com/docker/machine/issues/4537), so it is less likely that Apple M1 support will be added there.
Or, are you trying to use it with minikube (which also leverages our driver)?

@alvint @tobernguyen Could you please elaborate - which exact use case are you interested in?
Docker Machine project has been put into the maintenance mode back in 2019 (docker/machine#4537), so it is less likely that Apple M1 support will be added there.
Or, are you trying to use it with minikube (which also leverages our driver)?

Ah, my experience with Docker for Mac is it is still very slow and I just want to try if running the Docker in Ubuntu VM in Parallels could improve that.

You should be able to start Docker on an Ubuntu VM, using something like Vagrant rather than Machine:
https://boot2podman.github.io/2020/07/22/machine-replacement.html
http://parallels.github.io/vagrant-parallels/docs/
Otherwise you would need boot2podman for arm64, which is not available. But I'm working on a replacement.

Does parallells require something special for UEFI, or can it run the images right out-of-the-box ?
My normal target is Raspberry Pi, which uses SD cards and a special kernel, rather than an ISO.
But there is a renewed interest in making regular disk images, so swapped ISOLINUX for GRUB.
Basically I'm wondering if this minimal buildroot image works, after gunzip: disk-arm64.img.gz ?
With QEMU, we use something similar to:
qemu-system-aarch64 -M virt -cpu cortex-a53 -bios /usr/share/qemu-efi-aarch64/QEMU_EFI.fd ...

Does it also work, when run with Parallels ?

Basically I'm wondering if this minimal buildroot image works, after gunzip: disk-arm64.img.gz ?

Thanks for testing! It's related in the sense that the minikube.iso is based on buildroot, and it uses libmachine

Is there any update on this? Because I'm having the exact same issue

@mauricemojito

Is there any update on this? Because I'm having the exact same issue

Were you able to get any of the ISO running with Parallels, on Mac M1 ?
Some people are working over summer to make an arm64 minikube.iso.
We will assume that if it works with QEMU (+UEFI), it will also work here...
The main target is Docker's HyperKit, though. https://github.com/kubernetes/minikube/issues/11219

@afbjorklund

Were you able to get any of the ISO running with Parallels, on Mac M1 ?

Parallels Desktop for Mac with M1 boots operating systems from ISO-images successfully. Ubuntu, Fedora, Debian and others work nicely on arm64.
Can someone explain what could be done from docker-machine-parallels' side in scope of this ticket? Frankly speaking I'm a bid disoriented between all these arm64-related tickets in minikube project :-(

The main ticket (in minikube), is getting an arm64 version of the amd64 ISO.
Unfortunately it has been delayed, in that we don't even have a new amd64...
If docker-machine-parallels works OK with something like Ubuntu, then I guess
there is nothing more to do in the driver - the issue is on the OS and ISO side

Can someone explain what could be done from docker-machine-parallels' side in scope of this ticket?

You could start with building amd64 and arm64 versions of the binary, I suppose ?
https://github.com/Parallels/docker-machine-parallels/releases
docker-machine-driver-parallels
docker-machine-driver-parallels: Mach-O 64-bit x86_64 executable

Also, as indicated above, I would interested to know what is required for the arm64 ISO to boot...
Either what is wrong with the "hello world" ISO, or maybe just some pointers to working ones.

There is a CD version (.iso) now, in case it works better than the HD version (.img)
https://github.com/afbjorklund/minimal-buildroot/releases/tag/0.2 (it requires UEFI)

You can use this boot2docker-arm64.iso image for testing, if needed (should boot, without disk)

@afbjorklund
I run docker-machine create --driver=parallels --parallels-memory=16384 --parallels-disk-size=65536 --parallels-cpu-count=8 --parallels-boot2docker-url https://github.com/afbjorklund/boot2docker-debian/releases/download/a12e50d/boot2docker-arm64.iso prl-dev command
and the log shows:
Creating CA: /Users/hirakujira/.docker/machine/certs/ca.pem
Creating client certificate: /Users/hirakujira/.docker/machine/certs/cert.pem
Running pre-create checks...
(prl-dev) Image cache directory does not exist, creating it at /Users/hirakujira/.docker/machine/cache...
Creating machine...
(prl-dev) Downloading /Users/hirakujira/.docker/machine/cache/boot2docker.iso from https://github.com/afbjorklund/boot2docker-debian/releases/download/a12e50d/boot2docker-arm64.iso...
(prl-dev) 0%....10%....20%....30%....40%....50%....60%....70%....80%....90%....100%
(prl-dev) Creating SSH key...
(prl-dev) Creating Parallels Desktop VM...
(prl-dev) Starting Parallels Desktop VM...
(prl-dev) Waiting for VM to come online...

And then I get stuck in Waiting for VM to come online..., the host machine can't ssh into the docker VM. Do you know what I missed to configure? Thanks!

Do you know what I missed to configure? Thanks!

It is probably just missing the setup, the image is only half-done - it should boot and show a console, not sure about ssh yet

@hirakujira : Note that both docker-machine and boot2docker are dead upstream now
So any continued development would need a new name (moby?), in order to continue

It was supposed to look something like this:


fix: cleans ESLint issues with unused variables

Summary of Changes
Removes instances where we weren't using variables
Updates ESLint rules to fail from now on
Tests
Manually tested
Ran tests
CheckList
Make sure you have checked all steps below to ensure a timely review.

[ ] PR title addresses the issue accurately and concisely. Example: "Updates the version of Flask to v1.0.2"

In case you are adding a dependency, check if the license complies with the ASF 3rd Party License Policy.

[ ] PR includes a summary of changes.
[ ] PR adds unit tests, updates existing unit tests, OR documents why no test additions or modifications are needed.
[ ] In case of new functionality, my PR adds documentation that describes how to use it.

All the public functions and the classes in the PR contain docstrings that explain what it does

/retest


Update version to 0.17.10

Actually, looks like reference/changelog.md needs to be updated as well like in @lukehoban's PR: #1055. Since the CLI docs didn't change (other than the gen date), we could just take #1055 instead.

Since the CLI docs didn't change (other than the gen date), we could just take #1055 instead.

Went ahead and merged https://github.com/pulumi/docs/pull/1055, so will close this one out.


Dependency Updates + Releases

Greetings,
I'd love to use this operator in production environments.
Can we

(1) automate the dependency updates  with automatic merging ?
(2) have more frequent releases?

I'd be happy to contribute!

Hey @Breee I'm excited to hear about this.
In theory, there is an extensive (End-to-End) test suite to cover such automatic merges (and consequently, one could also create automated releases, e.g. in case there are vulnerabilities, as I've done in this workflow for a different project).
The main problem is that most Renovate PRs are broken, because of the poor choices I made regarding the different Golang projects in this repo, and how they are connected with each other, see e.g. https://github.com/MShekow/azure-pipelines-k8s-agent-scaler/blob/c6dbb5bd17ba0c758f6a8cb8390ae255376e1f63/go.mod#L6
I think this can be improved by removing these references to the same project, and instead use Golang's multi-module workspaces feature, but I've never gotten around to implement it, or learn how to use them.
If you're well versed in Go and multi-module workspaces, and are willing to help out, I can offer to set up a meeting to look at the code base together, give you contributor permissions, and let you get this project in shape.

Due to incompatibilities, I just released a few updates. There are still many open issues you could work on, let me know if you'd like to collaborate.

I noticed you already worked on feat/dependency-restructuring branch: I'm not Golang expert but happy to collaborate in any way...

Sorry for the radio silence and thanks for your reply!
I hava a bunch of other topics / puzzle pieces to cover before i will have dedicated time for this project - but i will be soon ready to deploy and test.
I'll be in touch as soon as possible.


Implement flag to run hexdump with su

This issue originated from #144.
We need to implement a new flag -g for deploy.sh and afk-daily.sh that will, when used, change the afk-daily.sh file to run hexdump with su -c. I imagine sed will be handy for this.

Mmh, why not just add a variable and a condition?
readHEX() {
    offset=$((DEVICEWIDTH * $2 + $1 + 3))
    if [ "$suhexdump" = true ]; then
        HEX=$(dd if="$SCREENSHOTLOCATION" bs=4 skip="$offset" count=1 2>/dev/null | su hexdump -C)
    else
        HEX=$(dd if="$SCREENSHOTLOCATION" bs=4 skip="$offset" count=1 2>/dev/null | hexdump -C)
    fi
    HEX=${HEX:9:9}
    HEX="${HEX// /}"
}

True, sed is definitely overkill here.

Don't expose the option as a flag for the user.
Just run at start of the script adb shell hexdump --help and check the resulting text for permisison denied. if it's found. just set that variable to true

I usually don't fancy changing code that may affect others, especially since I cannot validate it myself as I don't have the Permission denied error. So I prefer to add a flag, this way I'm sure existing users will continue having the same experience as before, and those who want to make use of the feature simply run it with the desired flag. The risk is in my opinion usually not high enough for me to not implement new features like these with a flag.
Even though after having said all that, I've decided to give it a try this time and hopefully it all goes well for existing users, as well for those who need to run hexump with su.


Integrate arkmsm optimizations

arkmsm reports an up to 2x speedup vs arkworks 3.0 on CPU. We currently use a fork of arkworks 4.0's MSM algorithm, with added optimizations for small scalars. Investigate whether the optimizations implemented in arkmsm yield a performance improvement for Jolt's workloads

Hey, I would like to take that


Migrate storage testbench to Python 3

Currently it only runs with Python 2.7 and that is going EOL soon.

The builds are failing, I think because some of the modules assume Python 3, staying on Python 2.7 has become untenable I think.


🌱 Add copyright headers to all files

kind/cleanup
What this PR does / why we need it:
Align/add copyright headers in all files of the repo

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #
Special notes for your reviewer:
Checklist:

[X] squashed commits into logical changes
[ ] includes documentation
[ ] adds unit tests
[ ] adds or updates e2e tests

We can also add a CI check to verify that headers are there

CI check to verify that headers are there

@alexander-demicev I checked and it seems we have these options:

https://github.com/denis-tingaikin/go-header - At first glance does not look like has been adopted by other projects but very simple
https://github.com/viperproject/check-license-header - same as above
https://github.com/hashicorp/copywrite - looks fine, mostly used with the hashicorp project GH org


Enable download of Maven Gav Reader using Gitlab virtual repository

We are using Gitlab and Gitlab Runner with no access to the internet. Hence we use JFrog Artifactory virtual repositories for downloading Maven dependencies.
Our company cannot use Frogbot at the moment since it tries to install maven-gav-reader from Maven Central.
We would like it to honour JF_DEPS_REPO instead.
So instead (alternative approach) of
if output, err = exec.Command("mvn", installProperties...).CombinedOutput(); err != nil {
in mavenpackagehandler.go and function installMavenGavReader we would like to consider using the code below instead if possible:
if output, err = mph.runMvnCommand(installProperties); err != nil {
In this way JF_DEPS_REPO would be honoured and the behaviour consistent with other maven or jf audit commands.
Thanks!

Hi @johanglarsson, thank you for bringing this issue to our attention. I have opened a pull request that should resolve this problem and enable the use of the JF_DEPS_REPO to download the maven-install-plugin from the Artifactory remote repository that proxies Maven Central. You can find the pull request here: https://github.com/jfrog/frogbot/pull/502.
I will notify you once it has been pushed, and I would appreciate your feedback once it's released. Thanks again!

Hello @johanglarsson,
We're pleased to inform you that Frogbot v2.15.0 has been released, and it includes the fix for this issue.
We look forward to hearing your feedback!

Hi,
I found the issue and registred a bug report.
https://github.com/jfrog/frogbot/issues/515
It seems that a fix has broken the maven-gav-reader:gav functionality. It started working when I commented back the code before the change.


XHPROF

The following PR was built off of https://github.com/docksal/service-cli/pull/163
This adds the xhprof extension to be used for performance monitoring and to be able to monitor where there may be hang ups in performance.

@sean-e-dietrich please rebase onto develop (#163 has been merged).

Merged. Thanks! We should also mention xhprof in docs now.


add instructions for Google Maps API key to readme

Looks good. Squash and merge.

README updated with new getting started instructions.


Avoid stack overflow in completions

In symbolCanBeReferfencedAtTypeLocation, telemetry reports that 3.1.3 has a stack overflow in the recursive case that checks exportedSymbols. I believe that the cause is a commonjs module with both export assignment and export property assignments via an alias [1], but I haven't been able to repro the crash since telemetry only reports a stack. Nevertheless, I think the correct fix is just to not recur in the case that an exported symbol is identical to its containing module.
// @Filename: module.js
exports.version = 'hi'
function alias() { }
module.exports = alias

// @Filename: use.js
var m = require('./module')
m.al/**/

I expected the overflow to happen when requesting completions at /**/ but it didn't.
Fixes #27872

The reason that doesn't reproduce the issue is it's not recursive -- you can reproduce this with a recursive module or namespace like namespace N { export import M = N; }. See #28295


SemaphoreCI - Remove  stream dependency in favor of embedding

Description
Due to the dependent streams, when running a big batch of SemaphoreCI pipelines, the airbyte-faros-destination connector is running out of memory and halting execution. More information in Slack thread
This PR removes the stream dependency and embed the project information into the pipeline stream for a more resource efficient data load.
Type of change

[X] Bug fix
[ ] New feature
[ ] Breaking change

I have read the CLA Document and I hereby sign the CLA


Multiple Bot Instances

Expected Behavior
You should be able to deploy multiple instances of the QnA Chatbot to AWS
Actual Behavior
When one instance is already deployed, deploy a new instance via the command line, and the bootstrap creation fails with the message "Export with name QNA-BOOTSTRAP-PREFIX is already exported by stack QNA-bootstrap-8"
Specifications
I am currently running a slightly older version of QnABot. If this issue has been recently fixed, please advise.

fixed in v2


[Auto-update] Should be turned off on 1809 and older

This is a pre-requisite for https://github.com/microsoft/PowerToys/issues/9417

Since we're going to remove old settings in 0.37, we're dropping support of Windows < 1903 starting from there (new settings app requires 1903).
That means we need to disable updating mechanism in 0.35 on <1903 systems and warn the users about the upcoming changes.
We also need to set installer and bootstrapper to require Windows >=1903 if a user with an older system downloads it directly.
For users that are updating from <0.35 directly to 0.37, they'll remain with an old version, since 0.37 bootstrapper should notify them and exit w/o uninstalling the old version.
We also need to keep autoupdating mechanism working for 0.35.X releases, in case we need to release a hotfix.
Considering all that, we're going to do the following:

For the autoupdate checking mechanism inside the runner:

if we're on <1903 system, the current minor version == 35 and the newly available minor version != 35: skip it
otherwise, continue as usual

For the Settings page "Check for updates button":

we don't need to do anything, since running the new settings page require >=1903

For the Bootstrapper:

if we're on <1903 system, the current minor version >= 37: show a msgbox "PowerToys v. A.B.C requires at least Windows 1903 to run." and exit

For the MSI:

if we're on <1903 system, the current minor version >= 37: use MSI built-in checking features and exit with a message.

Create an issue to delete the special logic described in 1) once we release 0.37, since it won't be possible to run that logic on <1903 systems. Also we should remove the if ver >=37 logic described in 3) and 4).

Let's keep it open until 0.35 is released

This has been resolved in the 0.35 release. https://github.com/microsoft/PowerToys/releases/latest


[pre-sve] TC-I-2.3 Add implementation for Trigger effect command on TI platform all-clusters application

Problem
Currently, the all clusters app on CC13x2x7 returns INVALID_COMMAND for TC-I-2.3 as it is missing a a def
system configuration

DUT used : CC13x2x7
app use: all-clusters-app
chip-tool commit id : https://github.com/project-chip/connectedhomeip/commit/425f1fb916ca154deeb75cd82cd5196778aba152 (pre-sve SHA)

Proposed Solution
Add default triggers trigger-effect

Cert Blocker Review: Assigning to @franck-apple to find an owner for this issue.

@woody-apple @franck-apple, I'm currently working on a fix for this issue which is specific to the cc13x2x7 platform.


feat: ingestion implementation v2

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license
Summary
Implement Ingestion server v2 including below changes:
1, Support Fargate and EC2 in V2
2, Separate ECS cluster and other resources(alb, aga) to two nest stack
3, Support protocol, endpoint path, auth/without auth, aga enable/disable, domain, certificate change.
4, Add unit test cases to cover all change
Implementation highlights
(describe how the merge request does for feature changes, share the RFC link if it has)
Test checklist

[x] add new test cases
[x] all code changes are covered by unit tests
[x] end-to-end tests

[ ] deploy web console with CloudFront + S3 + API gateway
[ ] deploy web console within VPC
[x] deploy ingestion server

[x] with MSK sink
[x] with KDS sink
[x] with S3 sink

[ ] deploy data processing
[ ] deploy data modeling

[ ] new Redshift Serverless
[ ] provisioned Redshift
[ ] Athena

[ ] deploy with reporting

Is it a breaking change

[ ] add parameters without default value in stack
[ ] introduce new service permission in stack
[ ] introduce new top level stack module

Miscellaneous

[ ] introduce new symbol link source file(s) to be shared among infra code, web console frontend, and web console backend

SonarQube Quality Gate Result

Result: :exclamation: Error
Triggered by @dengmingtong on pull_request

Metric
Status
Value
Error Threshold

Reliability rating
:white_check_mark: OK
1
> 1

Security rating
:white_check_mark: OK
1
> 1

Sqale rating
:white_check_mark: OK
1
> 1

Coverage
:white_check_mark: OK
83.60
< 80

Duplicated lines density
:white_check_mark: OK
5.20
> 30

Blocker violations
:white_check_mark: OK
0
> 0

Bugs
:white_check_mark: OK
0
> 0

Code smells
:white_check_mark: OK
13
> 40

Critical violations
:white_check_mark: OK
0
> 0

Major violations
:exclamation: Error
4
> 0

Security hotspots reviewed
:exclamation: Error
0
< 100

Vulnerabilities
:white_check_mark: OK
0
> 0

View on SonarQube
updated: 6/16/2024, 15:46:27 (UTC+0)

SonarQube Code Analytics
Quality Gate failed

Additional information
The following metrics might not affect the Quality Gate status but improving them will improve your project code quality.
Issues
 0 Bugs
 0 Vulnerabilities
 0 Code Smells
Coverage and Duplications
No data Coverage
No data Duplication

SonarQube Quality Gate Result

Result: :exclamation: Error
Triggered by @dengmingtong on pull_request

Metric
Status
Value
Error Threshold

Reliability rating
:white_check_mark: OK
1
> 1

Security rating
:white_check_mark: OK
1
> 1

Sqale rating
:white_check_mark: OK
1
> 1

Coverage
:white_check_mark: OK
83.70
< 80

Duplicated lines density
:white_check_mark: OK
5.20
> 30

Blocker violations
:white_check_mark: OK
0
> 0

Bugs
:white_check_mark: OK
0
> 0

Code smells
:white_check_mark: OK
13
> 40

Critical violations
:white_check_mark: OK
0
> 0

Major violations
:exclamation: Error
4
> 0

Security hotspots reviewed
:exclamation: Error
0
< 100

Vulnerabilities
:white_check_mark: OK
0
> 0

View on SonarQube
updated: 6/17/2024, 02:58:39 (UTC+0)

SonarQube Quality Gate Result

Result: :exclamation: Error
Triggered by @zxkane on pull_request

Metric
Status
Value
Error Threshold

Reliability rating
:white_check_mark: OK
1
> 1

Security rating
:white_check_mark: OK
1
> 1

Sqale rating
:white_check_mark: OK
1
> 1

Coverage
:white_check_mark: OK
83.70
< 80

Duplicated lines density
:white_check_mark: OK
5.20
> 30

Blocker violations
:white_check_mark: OK
0
> 0

Bugs
:white_check_mark: OK
0
> 0

Code smells
:white_check_mark: OK
13
> 40

Critical violations
:white_check_mark: OK
0
> 0

Major violations
:exclamation: Error
4
> 0

Security hotspots reviewed
:exclamation: Error
0
< 100

Vulnerabilities
:white_check_mark: OK
0
> 0

View on SonarQube
updated: 6/17/2024, 03:28:30 (UTC+0)

SonarQube Quality Gate Result

Result: :exclamation: Error
Triggered by @dengmingtong on pull_request

Metric
Status
Value
Error Threshold

Reliability rating
:white_check_mark: OK
1
> 1

Security rating
:white_check_mark: OK
1
> 1

Sqale rating
:white_check_mark: OK
1
> 1

Coverage
:white_check_mark: OK
83.80
< 80

Duplicated lines density
:white_check_mark: OK
5.20
> 30

Blocker violations
:white_check_mark: OK
0
> 0

Bugs
:white_check_mark: OK
0
> 0

Code smells
:white_check_mark: OK
14
> 40

Critical violations
:white_check_mark: OK
0
> 0

Major violations
:exclamation: Error
5
> 0

Security hotspots reviewed
:exclamation: Error
0
< 100

Vulnerabilities
:white_check_mark: OK
0
> 0

View on SonarQube
updated: 6/19/2024, 03:01:28 (UTC+0)

SonarQube Quality Gate Result

Result: :exclamation: Error
Triggered by @dengmingtong on pull_request

Metric
Status
Value
Error Threshold

Reliability rating
:white_check_mark: OK
1
> 1

Security rating
:white_check_mark: OK
1
> 1

Sqale rating
:white_check_mark: OK
1
> 1

Coverage
:white_check_mark: OK
83.80
< 80

Duplicated lines density
:white_check_mark: OK
5.30
> 30

Blocker violations
:white_check_mark: OK
0
> 0

Bugs
:white_check_mark: OK
0
> 0

Code smells
:white_check_mark: OK
10
> 40

Critical violations
:white_check_mark: OK
0
> 0

Major violations
:exclamation: Error
1
> 0

Security hotspots reviewed
:exclamation: Error
0
< 100

Vulnerabilities
:white_check_mark: OK
0
> 0

View on SonarQube
updated: 6/19/2024, 03:34:44 (UTC+0)

SonarQube Quality Gate Result

Result: :exclamation: Error
Triggered by @dengmingtong on pull_request

Metric
Status
Value
Error Threshold

Reliability rating
:white_check_mark: OK
1
> 1

Security rating
:white_check_mark: OK
1
> 1

Sqale rating
:white_check_mark: OK
1
> 1

Coverage
:white_check_mark: OK
83.80
< 80

Duplicated lines density
:white_check_mark: OK
5.10
> 30

Blocker violations
:white_check_mark: OK
0
> 0

Bugs
:white_check_mark: OK
0
> 0

Code smells
:white_check_mark: OK
11
> 40

Critical violations
:white_check_mark: OK
0
> 0

Major violations
:exclamation: Error
2
> 0

Security hotspots reviewed
:exclamation: Error
0
< 100

Vulnerabilities
:white_check_mark: OK
0
> 0

View on SonarQube
updated: 6/21/2024, 03:41:28 (UTC+0)

SonarQube Quality Gate Result

Result: :exclamation: Error
Triggered by @zxkane on pull_request

Metric
Status
Value
Error Threshold

Reliability rating
:white_check_mark: OK
1
> 1

Security rating
:white_check_mark: OK
1
> 1

Sqale rating
:white_check_mark: OK
1
> 1

Coverage
:white_check_mark: OK
83.80
< 80

Duplicated lines density
:white_check_mark: OK
5.10
> 30

Blocker violations
:white_check_mark: OK
0
> 0

Bugs
:white_check_mark: OK
0
> 0

Code smells
:white_check_mark: OK
11
> 40

Critical violations
:white_check_mark: OK
0
> 0

Major violations
:exclamation: Error
2
> 0

Security hotspots reviewed
:exclamation: Error
0
< 100

Vulnerabilities
:white_check_mark: OK
0
> 0

View on SonarQube
updated: 6/21/2024, 04:12:53 (UTC+0)

SonarQube Quality Gate Result

Result: :exclamation: Error
Triggered by @dengmingtong on pull_request

Metric
Status
Value
Error Threshold

Reliability rating
:white_check_mark: OK
1
> 1

Security rating
:white_check_mark: OK
1
> 1

Sqale rating
:white_check_mark: OK
1
> 1

Coverage
:white_check_mark: OK
83.80
< 80

Duplicated lines density
:white_check_mark: OK
5.10
> 30

Blocker violations
:white_check_mark: OK
0
> 0

Bugs
:white_check_mark: OK
0
> 0

Code smells
:white_check_mark: OK
10
> 40

Critical violations
:white_check_mark: OK
0
> 0

Major violations
:exclamation: Error
1
> 0

Security hotspots reviewed
:exclamation: Error
0
< 100

Vulnerabilities
:white_check_mark: OK
0
> 0

View on SonarQube
updated: 6/21/2024, 05:09:52 (UTC+0)

SonarQube Quality Gate Result

Result: :exclamation: Error
Triggered by @zxkane on pull_request

Metric
Status
Value
Error Threshold

Reliability rating
:white_check_mark: OK
1
> 1

Security rating
:white_check_mark: OK
1
> 1

Sqale rating
:white_check_mark: OK
1
> 1

Coverage
:white_check_mark: OK
83.80
< 80

Duplicated lines density
:white_check_mark: OK
5.10
> 30

Blocker violations
:white_check_mark: OK
0
> 0

Bugs
:white_check_mark: OK
0
> 0

Code smells
:white_check_mark: OK
10
> 40

Critical violations
:white_check_mark: OK
0
> 0

Major violations
:exclamation: Error
1
> 0

Security hotspots reviewed
:exclamation: Error
0
< 100

Vulnerabilities
:white_check_mark: OK
0
> 0

View on SonarQube
updated: 6/21/2024, 05:39:28 (UTC+0)

SonarQube Quality Gate Result

Result: :exclamation: Error
Triggered by @dengmingtong on pull_request

Metric
Status
Value
Error Threshold

Reliability rating
:white_check_mark: OK
1
> 1

Security rating
:white_check_mark: OK
1
> 1

Sqale rating
:white_check_mark: OK
1
> 1

Coverage
:white_check_mark: OK
83.80
< 80

Duplicated lines density
:white_check_mark: OK
5.10
> 30

Blocker violations
:white_check_mark: OK
0
> 0

Bugs
:white_check_mark: OK
0
> 0

Code smells
:white_check_mark: OK
9
> 40

Critical violations
:white_check_mark: OK
0
> 0

Major violations
:white_check_mark: OK
0
> 0

Security hotspots reviewed
:exclamation: Error
0
< 100

Vulnerabilities
:white_check_mark: OK
0
> 0

View on SonarQube
updated: 6/21/2024, 07:36:55 (UTC+0)

SonarQube Quality Gate Result

Result: :exclamation: Error
Triggered by @zxkane on pull_request

Metric
Status
Value
Error Threshold

Reliability rating
:white_check_mark: OK
1
> 1

Security rating
:white_check_mark: OK
1
> 1

Sqale rating
:white_check_mark: OK
1
> 1

Coverage
:white_check_mark: OK
83.80
< 80

Duplicated lines density
:white_check_mark: OK
5.10
> 30

Blocker violations
:white_check_mark: OK
0
> 0

Bugs
:white_check_mark: OK
0
> 0

Code smells
:white_check_mark: OK
9
> 40

Critical violations
:white_check_mark: OK
0
> 0

Major violations
:white_check_mark: OK
0
> 0

Security hotspots reviewed
:exclamation: Error
0
< 100

Vulnerabilities
:white_check_mark: OK
0
> 0

View on SonarQube
updated: 6/21/2024, 08:05:17 (UTC+0)

SonarQube Quality Gate Result

Result: :exclamation: Error
Triggered by @zxkane on pull_request

Metric
Status
Value
Error Threshold

Reliability rating
:white_check_mark: OK
1
> 1

Security rating
:white_check_mark: OK
1
> 1

Sqale rating
:white_check_mark: OK
1
> 1

Coverage
:white_check_mark: OK
83.80
< 80

Duplicated lines density
:white_check_mark: OK
5.10
> 30

Blocker violations
:white_check_mark: OK
0
> 0

Bugs
:white_check_mark: OK
0
> 0

Code smells
:white_check_mark: OK
9
> 40

Critical violations
:white_check_mark: OK
0
> 0

Major violations
:white_check_mark: OK
0
> 0

Security hotspots reviewed
:exclamation: Error
0
< 100

Vulnerabilities
:white_check_mark: OK
0
> 0

View on SonarQube
updated: 6/21/2024, 11:09:04 (UTC+0)

SonarQube Quality Gate Result

Result: :white_check_mark: OK
Triggered by @dengmingtong on pull_request

Metric
Status
Value
Error Threshold

Reliability rating
:white_check_mark: OK
1
> 1

Security rating
:white_check_mark: OK
1
> 1

Sqale rating
:white_check_mark: OK
1
> 1

Coverage
:white_check_mark: OK
83.80
< 80

Duplicated lines density
:white_check_mark: OK
5.10
> 30

Blocker violations
:white_check_mark: OK
0
> 0

Bugs
:white_check_mark: OK
0
> 0

Code smells
:white_check_mark: OK
9
> 40

Critical violations
:white_check_mark: OK
0
> 0

Major violations
:white_check_mark: OK
0
> 0

Vulnerabilities
:white_check_mark: OK
0
> 0

View on SonarQube
updated: 6/21/2024, 13:19:07 (UTC+0)


Inconsistancy in 2FA setups

When using the Exchange Online V2 powershell modules they do not behave the same on different machines.
On a non domained machine I can run connect-exchangeonline -userprincipalname<EMAIL_ADDRESS>and it authenticates correctly
On a domained machine where I have a normal account and an admin account if I run the same command I get this output
New-ExoPSSession : User<EMAIL_ADDRESS>returned by service does not match user<EMAIL_ADDRESS>in the request
Where<EMAIL_ADDRESS>is the account I am logged into the machine with.
If I use connect-exchangeonline  and manually enter in the username<EMAIL_ADDRESS>then it with authenticate
When connecting with the later method the command Get-EXOMailbox works as do most others I have tried but Get-EXOMailboxPermission fails
Get-EXOMailboxPermission : An error occurred while processing this request..
At line:1 char:1

Get-EXOMailboxPermission -identity<EMAIL_ADDRESS>
  + CategoryInfo          : ProtocolError: (:) [Get-EXOMailboxPermission], Exception
  + FullyQualifiedErrorId : One or more errors occurred.,Microsoft.Exchange.Management.RestApiClient.GetExoMailboxPe   rmission

This command works If I connect from a non domained machine so I think it's related to authetication.

@officedocsbot assign @yogkumgit

Hello @crass00, how are you? For your inquiry I need to kindly suggest opening a support ticket directly from your tenant's administration, they will be able to help you as here we are limited to documentation issues and improvements.
Support URL: https://docs.microsoft.com/microsoft-365/admin/contact-support-for-business-products.
Thank you!

@dariomws  Thank you very much for the contribution and sharing this explanation. @crass00 Hope this comment is helpful for you. Considering the nature of the issue, as advised, please open a service ticket in your tenant and follow with them for the resolution. We proceed here to close it.
We will be very happy if you can share the outcome or resolution with us if you see documentation update is required. We will certainly update this documentation with that valuable information. Thanks again, for taking out some time to open the issue. Appreciate and encourage you to do the same in future also


Failed to connect to the TCP server

Specs

Leon version: 1.0.0-beta.7 / 1.0.0-beta.8+dev
OS (or browser) version: Firefox 111.0.1 / Brave 1.42.88 Chromium: 104.0.5112.81
Node.js version: v16.16.0
Complete "leon check" (or "npm run check") output:

><EMAIL_ADDRESS>check
> babel-node scripts/run-check.js

Browserslist: caniuse-lite is outdated. Please run:
  npx browserslist@latest --update-db
  Why you should do it regularly: https://github.com/browserslist/browserslist#browsers-data-updating
⠋

.: CHECKING :.
ℹ  Leon version
✅ 1.0.0-beta.7

ℹ  node --version
✅ v16.16.0

ℹ  npm --version
✅ 8.11.0

ℹ  pipenv --version
✅ pipenv, version 2023.3.20

ℹ  pipenv --where
✅ /home/nice/git/leon/bridges/python

ℹ  pipenv run python --version
✅ Python 3.10.6

ℹ  pipenv run python bridges/python/main.py scripts/assets/intent-object.json
✅ {"domain": "leon", "skill": "random_number", "action": "run", "lang": "en", "utterance": "Give me a random number", "entities": [], "slots": {}, "output": {"type": "end", "codes": ["13"], "speech": "13", "core": {}, "options": {}}}

ℹ  Global resolvers NLP model state
✅ Found and valid

ℹ  Skills resolvers NLP model state
✅ Found and valid

ℹ  Main NLP model state
✅ Found and valid

ℹ  Amazon Polly TTS
⚠  Amazon Polly TTS is not yet configured

ℹ  Google Cloud TTS/STT
⚠  Google Cloud TTS/STT is not yet configured

ℹ  Watson TTS
⚠  Watson TTS is not yet configured

ℹ  Offline TTS
⚠  Cannot find bin/flite/flite. You can setup the offline TTS by running: "npm run setup:offline-tts"

ℹ  Watson STT
⚠  Watson STT is not yet configured

ℹ  Offline STT
⚠  Cannot find bin/coqui/huge-vocabulary.scorer. You can setup the offline STT by running: "npm run setup:offline-stt"

.: REPORT :.
ℹ  Here is the diagnosis about your current setup
✅ Run
✅ Run skills
✅ Reply you by texting
⚠  Amazon Polly text-to-speech
⚠  Google Cloud text-to-speech
⚠  Watson text-to-speech
⚠  Offline text-to-speech
⚠  Google Cloud speech-to-text
⚠  Watson speech-to-text
⚠  Offline speech-to-text

✅ Hooray! Leon can run correctly
ℹ  If you have some yellow warnings, it is all good. It means some entities are not yet configured

(if using Docker) Complete "npm run docker:check" output: -
(optional) Leon skill version:

Expected Behavior
Show chat in browser
Actual Behavior
loading animation in browser and "Failed to connect to the TCP server" in console
How Do We Reproduce?
install with git stable
Extra (like a sample repo to reproduce the issue, etc.)

Hi, can you please try the following?
npm install --global @leon-ai/cli@beta
leon create birth --develop
leon start

Then check if it works. If it still does not work, please share the report from:
leon check

The issue still exists, here is the check output:
leon check

><EMAIL_ADDRESS>check
> babel-node scripts/run-check.js

Browserslist: caniuse-lite is outdated. Please run:
  npx browserslist@latest --update-db
  Why you should do it regularly: https://github.com/browserslist/browserslist#browsers-data-updating
⠋

.: CHECKING :.
ℹ  Leon version
✅ 1.0.0-beta.7

ℹ  node --version
✅ v18.15.0

ℹ  npm --version
✅ 9.5.0

ℹ  pipenv --version
✅ pipenv, version 2023.3.20

ℹ  pipenv --where
✅ /home/nice/git/leon/bridges/python

ℹ  pipenv run python --version
✅ Python 3.10.6

ℹ  pipenv run python bridges/python/main.py scripts/assets/intent-object.json
✅ {"domain": "leon", "skill": "random_number", "action": "run", "lang": "en", "utterance": "Give me a random number", "entities": [], "slots": {}, "output": {"type": "end", "codes": ["33"], "speech": "33", "core": {}, "options": {}}}

ℹ  Global resolvers NLP model state
✅ Found and valid

ℹ  Skills resolvers NLP model state
✅ Found and valid

ℹ  Main NLP model state
✅ Found and valid

ℹ  Amazon Polly TTS
⚠  Amazon Polly TTS is not yet configured

ℹ  Google Cloud TTS/STT
⚠  Google Cloud TTS/STT is not yet configured

ℹ  Watson TTS
⚠  Watson TTS is not yet configured

ℹ  Offline TTS
⚠  Cannot find bin/flite/flite. You can setup the offline TTS by running: "npm run setup:offline-tts"

ℹ  Watson STT
⚠  Watson STT is not yet configured

ℹ  Offline STT
⚠  Cannot find bin/coqui/huge-vocabulary.scorer. You can setup the offline STT by running: "npm run setup:offline-stt"

.: REPORT :.
ℹ  Here is the diagnosis about your current setup
✅ Run
✅ Run skills
✅ Reply you by texting
⚠  Amazon Polly text-to-speech
⚠  Google Cloud text-to-speech
⚠  Watson text-to-speech
⚠  Offline text-to-speech
⚠  Google Cloud speech-to-text
⚠  Watson speech-to-text
⚠  Offline speech-to-text

✅ Hooray! Leon can run correctly
ℹ  If you have some yellow warnings, it is all good. It means some entities are not yet configured

I have the same issue but my leon chec produces an error that it cant find the leon-tcp-server file. I can see the file

This is the log from leon check https://report.getleon.ai/raw/oleforegec

leon update --develop fixed it somehow

For people having such issue, you can try the following:
npm install --global @leon-ai/cli@beta
leon create birth --develop
leon start

This will help you to use the 1.0.0-beta.8+dev version which uses compiled binaries, so there is no need to have a Python environment at runtime.
We are going to release the beta version 8 in the coming days.
Closing this issue as it has been solved.


Add more compatibility with xplat cli when there is no conflict

Description
For az vnet subnet operations -e is not used for any other existing argument - would be good for xplat migrations to support -e which it uses.
-e => --vnet-name
Would have submitted a PR, but wasn't clear how to do the register_alias in network.py with where it have cli_generic_update_command and similar. If you can point out an example of how to do this, I'll send a PR.

az network dns record-set add:
-l => --ttl
For that command, these are not shown in the help information, but do work:
-g => --resource-group
-n => --record-set-name
-z => --zone-name

az network nic create add:
-m => --vnet-name
-k => --subnet

For the DNS record commands the short options are listed in the help:
    az network dns record-set a add-record

Arguments
    --ipv4-address -a    [Required]: IPV4 address in string notation.
    --record-set-name -n [Required]: The name of the record set relative to the zone. Creates a new
                                     record set if one does not exist.
    --resource-group -g  [Required]: Name of resource group. You can configure the default group
                                     using `az configure --defaults group=<name>`.
    --zone-name -z       [Required]: The name of the zone.

We made a conscious choice not to lift short arguments from Xplat. As you point out, for one command, vnet-name is -e and another it is -m.  Neither makes any sense. If we choose a short option, we do so when the argument is used often and when the user can have a reasonable expectation that it will be consistent throughout the CLI, ideally globally (-g and -l), but at least throughout a module (short options in storage for example).
There may be no conflict today, but as we are already finding when we wanted to introduce a new global alias, there is a conflict with one random command group that decided to use that short option for something that it really didn't need to.

Ok, I can live with that since it was a conscious decision.
Now I can't reproduce what triggered my comment about the short items not being listed... strange. Maybe was confusing output of one cmd with another.

It might be that the usage string doesn't display the short options:
usage: az network dns record-set a add-record [-h]
                                              [--output {json,tsv,table,jsonc}]
                                              [--verbose] [--debug]
                                              [--query JMESPATH]
                                              --resource-group
                                              RESOURCE_GROUP_NAME --zone-name
                                              ZONE_NAME --ipv4-address
                                              IPV4_ADDRESS --record-set-name
                                              NAME

However the argparse error message does:
az network dns record-set a add-record: error: the following arguments are required: --resource-group/-g, --zone-name/-z, --ipv4-address/-a, --record-set-name/-n

Ah, yep. that was it! ty.


Use diff_method="device" to reduce cost of BYOC example

Issue #, if available:
Description of changes:
Improves the performance and cost of the BYOC example notebook by using adjoint gradient differentiation method (which is achieved by setting diff_method="device"). The change brings the cost of the notebook down to $0.15 (from $40) and the job runtime is now <10 minutes.
This change was suggested by @mbeach-aws.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Tested on NBIs, lgtm. Thanks!

Thank you @virajvchaudhari!


test: support comparison between InputRef specs and InputRef

InputRef from sdk schemas (specs) and InputRef from models (actual input) are now differents. We cannot compare them straight away. This PR introduce a method to convret from input to specs (removing additionnal fields)

/e2e --refs substra=feat/inputs_api

End to end tests: :hourglass_flowing_sand: STARTING

Something happened while processing your message: Unexpected inputs provided: ["testsBenchmark"]

gh bot is broken but sdk tests ran successfully here : https://github.com/owkin/connect-ci/actions/runs/3082307061

Could you add a changelog entry please?
Side note: IMO the test prefix does not make much sense in this specific repo as the whole purpose is about testing. In the case we fix a test, can we maybe use the fix prefix instead?

Closing as companion PR in substra has been closed.


Fix typos (create task with urlRequest instead of url)

let task = session.dataTask(with: url) -> let task = session.dataTask(with: urlRequest)
in Simple, Intermediate and Advanced

Thanks for doing this @wacumov!


Bug: COMException in AppThemeModeService.SetAppThemeMode

Description
System.Runtime.InteropServices.COMException

Steps To Reproduce
Unknown (presumably it's when changing a theme setting)
Requirements

Add error handling to prevent this crash

Files Version
v3.4
Windows Version
WINDOWS 10.0.19045
Log File
WinRT
ExceptionHelpers.<ThrowExceptionForHR>g__Throw|39_0 (Int32 hr)
Files.App.Services
AppThemeModeService.SetAppThemeMode (Window window, AppWindowTitleBar titleBar, Nullable`1 rootTheme, Boolean callThemeModeChangedEvent)
Files.App.Services
AppThemeModeService.ApplyResources ()
Files.App.ViewModels.Settings
AppearanceViewModel.set_AppThemeBackgroundColor (String value)
Files.App.ViewModels.Settings
AppearanceViewModel.set_SelectedAppThemeResources (AppThemeResourceItem value)
ABI.Microsoft.UI.Xaml
DependencyPropertyChangedCallback.Do_Abi_Invoke (IntPtr thisPtr, IntPtr sender, IntPtr dp)
WinRT
ExceptionHelpers.<ThrowExceptionForHR>g__Throw|39_0 (Int32 hr)
ABI.Windows.ApplicationModel.Core
IUnhandledErrorMethods.Propagate (IObjectReference _obj)
Microsoft.AppCenter.Utils
ApplicationLifecycleHelperWinUI.<ctor>b__0_3 (Object sender, UnhandledErrorDetectedEventArgs eventArgs)

It's really weird that this happens in this very method, which is almost the same as before in ThemeHelper.
Do you think it's fine to add try-catch to the method?
If failed, output the exception to the logger.

That should work, and we can log additional info to help debug in the future.


SCP1 Import Order

closes #2418

I tried to test with https://github.com/abapGit-tests/SCP1/pull/1 but that's a new pull request. We have to keep the existing SCP1 test since it's used in automated testing. Could you please create a new repo with your SCP1/TOBJ test?

@mbtools So no need of a test case in abapGit-tests?

https://github.com/abapGit-tests/SCP1_TOBJ created, can you close https://github.com/abapGit-tests/SCP1/pull/1, and do the pull request to the new repo instead?
would like to keep the simple test case

thanks 👍


Document now inspect

I couldn't find now inspect documented anywhere, the only way I found out about it was from an error message. 🤦♂

Would be great to be listed under now -h

The fact that it is now inspect is not shown in now help seems like a bug to me, Help screen should show all the available commands.

Massive oversight! Thanks @lorensr @DannyBen for pointing it out

In case you missed it, we already list the inspect command on the help list. Thank you for the suggestion!


New Feature: Add support for waiting for non-existence

This PR adds a new feature: wait_for_no_* methods to allow for waiting for non-existence and to mirror the rest of the functionality available for testing existence:
has_*
has_no_*
wait_for_*
wait_for_no_* <-- These methods were missing, and this PR adds these methods

Before:
@home.wait_for_loading_spinners nil, count: 0

After:
@home.wait_for_no_loading_spinners

Before reviewing got a couple of questions / statements. Please don't take offence to these. Genuinely what you've done is great.
#1 - Code principle wise I have no issue, no review points here
#2 - Should this exist. Yes to be honest. I think it's perhaps a little OTT, but what it does do is add symmetry to an area that was otherwise not symmetrical 👍
#3 - A lot of the coding styles you've copied are existing ones (No issue there)
However
On the whole a lot of this suite I wan't to refactor style wise. And as you've added a whole heap of new functionality. If you're ok, I might get you to do some tidying up in the area you're in.
If you're ok with doing that, then I'll put a couple of review points in where we can do this. If not I'll re-review the documentation and approve in a couple of days.

@luke-hill Thanks, yes I agree with your points.
I can help with cleanup of some of the suite. Let me know if it would be better to do the cleanup in another PR to make it clearer when changes to the overall suite were done.

One thing I noticed while working on #231:  I'm pretty sure the wait_until_*_invisible actually fulfills this functionality as well.  It actually waits until the element is either not visible or not present.  I maintained that behavior in 231.

Sounds good thanks @luke-hill

That's merged in. Thanks @ricmatsui - Will be released in the 2.13 gem


[ACP-77] Adjust nomenclature due to renaming of Avalanche Subnets -> Avalanche L1s

As stated in this Avalanche Academy Guide: Avalanche Subnets have been rebranded as Avalanche L1s.
To avoid confusion, the spec has been revised to account for this, including the following changes:
ConvertSubnetTx -> ConvertL1Tx
RegisterSubnetValidatorTx -> RegisterL1ValidatorTx
RegisterSubnetValidatorMessage -> RegisterL1ValidatorMessage
SetSubnetValidatorWeightTx -> SetL1ValidatorWeightTx
DisableValidatorTx -> DisableL1ValidatorTx
SubnetValidatorRegistrationMessage -> L1ValidatorRegistrationMessage
IncreaseBalanceTx -> IncreaseL1ValidatorBalanceTx

To Review:
ReadMe Preview
Nuance:

Subnet validator continues to refer to all validators created and controlled by Subnet Owners pre-Etna Upgrade, controllable by the AddSubnetValidatorTx and RemoveSubnetValidatorTx.
CreateSubnetTx is a pre-Etna transaction whose functionality and nomenclature will not change within this spec.
SubnetID is the transaction hash produced by a successful CreateSubnetTx and a parameter required by some of the new transaction types. This will not be renamed.

@dhrubabasu: I'm hesitant to do this rename within this ACP since CreateSubnetTx, AddSubnetValidatorTx, and RemoveSubnetValidatorTx will still be referenced and can be used before ConvertSubnetTx is issued

I addressed this in the PR's initial comment, saying:

Subnet validator continues to refer to all validators created and controlled by Subnet Owners pre-Etna Upgrade, controllable by the AddSubnetValidatorTx and RemoveSubnetValidatorTx.

as well as:

CreateSubnetTx is a pre-Etna transaction whose functionality and nomenclature will not change within this spec.

Subnets and L1s are functionally different from each other, and therefore must be properly defined, and identified by name. Any network controlled with AddSubnetValidatorTx and RemoveSubnetValidatorTx is a Subnet and should never be called an Avalanche L1. The opposite is also true.
RegisterSubnetValidatorTx is not registering a Subnet Validator; it is registering an L1 Validator.
I understand that some of the language of this ACP will need to change in response to this. This, however, should not block the development of the network, which is nearing completion in regards to this ACP.

superseded by https://github.com/avalanche-foundation/ACPs/pull/154

superseded by https://github.com/avalanche-foundation/ACPs/pull/154


throttled web ui is empty

Hello all,
Sorry if I'm missing something here... but my web ui is always empty, do I need to log myself to this area? or enable something maybe?
I'm running sidekiq (5.1.1) & sidekiq-throttled (0.8.2)

If you are running it with rails, you might need to eager load jobs in development environment.

Thanks very much! I'm not desperate for it in development mode really... was just testing, thanks again

So, just to explain. That tab shows "known" throttling rules. If jobs were not loaded - it won't know of them. :D

@ixti what do you mean by "known" throttling rules?

@danielgomezrico If code was not required/loaded, sidekiq_throttle line, naturally, will not be evaluated, so that rule will NOT be shown in UI. Files (by default) are lazy-loaded in development environment of Rails.

@ixti ok, thanks for answering.

@danielgomezrico @ixti We're experiencing the same issue in all environments (development and production).
Here is what our throttles look like:
Sidekiq::Throttled::Registry.add(:DefaultThrottle, {
  threshold: {
    limit: Rails.application.config.sidekiq_jobs_per_minute_per_org,
    key_suffix: -> (*args) { "organization:#{args[0]}" },
    period: 1.minute
  }
})

Sidekiq::Throttled::Registry.add(:EventThrottle, {
  threshold: {
    limit: Rails.application.config.sidekiq_events_per_minute_per_org,
    key_suffix: -> (*args) { "organization:#{args[0]}" },
    period: 1.minute
  }
})

Sidekiq::Throttled::Registry.add(:BatchThrottle, {
  threshold: {
    limit: Rails.application.config.sidekiq_batch_jobs_per_minute_per_org,
    key_suffix: -> (*args) { "organization:#{args[0]}" },
    period: 1.minute
  }
})

These throttles are attached to Sidekiq workers depending on the queue. Batch jobs process in the batch queue with the BatchThrottle, whereas Event jobs process in the events queue with the EventThrottle.
Throttles are working as expected, however, the UI is forever "empty".

 rails (5.1.6)
 sidekiq-throttled (0.10.0)
 sidekiq (= 5.2.7)

This is an important feature to have working and any advice would be greatly appreciated!


Design Meeting Notes, 10/26/2018

Spread types ({ re, ...{re, ...{re, ...{re, ...visited}}}})
#10727
https://github.com/Microsoft/TypeScript/pull/21316#issuecomment-359574388

After we did conditional types, it became almost possible to correctly type rest/spread on conditional types.

You can convince yourself that https://github.com/Microsoft/TypeScript/pull/21316#issuecomment-359574388 has a user-land spread that mostly "does the right thing"

Except that methods get turned into properties.

Today we have a heuristic that anything was declared as a method was probably a prototype method.

Except methods from object literals, because those don't actually have a method. Ugh, edge cases.

We'd effectively need an ownkeyof or ownkeysof operator to distinguish between all properties and what we can sort of model as "own" properties.

function f1<T>(t: T, x: { a: string, b?: string }) {
    let z = {} as Spread<typeof t, typeof x>;
    z.a; // has type 'string'
    z.b; // wait, this is an error?
}

Why is z.b an error?

Well you don't really know what b is going to be, so it seems strange that you'd know how to "do the right thing" with b.
Seems questionable that you can't access it; it could be Spread<typeof t, typeof x>["b"].
Weird.
It seems like users would expect this to just work.

But this is only overly-pedantic in the "higher order" (i.e. only comes up with generics).

In order to work on this, we found that there are some weird behaviors on accessing properties on mapped types:
function foo<T, K extends keyof T>(x: Pick<T, K>) {
    obj = { foo: 5 }; // error
    let x = obj.wat; // allowed: WAT?
}

So is the idea really to introduce ownkeyof?

Seems wonky and isn't fully accurate.

What about own T which would allow you to write keyof own T?
Want to make sure we're actually solving the problem.

Action item: want use bigtsquery

Except that we can't search .tsx files (@urish pls)

Private fields in nightly releases
https://github.com/Microsoft/TypeScript/issues/28152
(Crux of this recorded by @weswigham)
We've been working with Bloomberg for a while on implementing this proposal, but if you've been following the proposal repo for tc39, there has been mixed feedback about its behavior and syntax. So despite it being stage 3, it seems wise to be conservative in adopting an implementation. We want to validate the proposal with users, and Bloomberg still wants to actually trial a real implementation. In order to get feedback, we'd need something actually published so people can experiment.
It's difficult to maintain things for a long time outside of master, and it'd be useful to run experiments on nightlies. In the past, our problem with experimental flags was that the community took a hard dependency on the feature. Rather than releasing it like experimentalDecorators, what if we introduce a new flag that only works on nightly builds? This emulates how Rust or Chrome run experiments in their nightlies that never hit a public release. We're concerned about this because there are still people with concerns around syntax despite it being stage 3. But stage 3 is where we've said TypeScript will consider implementations for proposals...

If private fields are stage 3, it's stage 3. If the comittee changes it, we change it and it's out of our hands. We've said we'll support stage 3 features, so we should support them. Generally speaking I'd have no problem with implementing it, since if it breaks due to a spec change, it's not our fault.
But I don't think this is an ordinary stage 3 feature.
And it'll be a versioning hazard, since you'll be pinned to the TS version that we support.
Fine, we can have the switch but nothing strange nightly-only stuff. Then at least it can be toggled off/changed for the final version.
[*back and forth about stage 3 support and maintainability issues *]
There are alternate designs to achieve private fields. So we should verify what it is that solves users' issues. Would it make sense to have a different published "nightly" with the experiments? A differently labeled npm tag?
If we want to be impartial maybe we step back and just wait.

If we need an implementation, there's nothing wrong with a temporary fork on npm.

[Out of time]

In the end we followed up with our colleagues at Bloomberg and we realized that the idea of a separate fork published on npm could be seen negatively (even if it's not at all the intent). We'll continue working on https://github.com/Bloomberg/TypeScript and people can download and LKG'd version from there.

@DanielRosenwasser just to confirm - so the .tsx file search isn't urgent for now?


Tests wont run on CrossBrowserTesting re a syntax error

What is your Test Scenario?
I have a relatively simple integration test suite for a single React page. The page has a view toggle nav "Papers" and "Products". I am testing by clicking the nav to "Papers", making assertions as to what should be on the page, then navigating back to "Products". Then I'm opening filter options, and checking that two of the filters work. Aka, I click a filter and fewer products should show on the page etc.
What is the Current behavior?
the tests usually work when running against local browsers (chrome, firefox, safari), but sometimes when running locally and always when running remotely using "testcafe-browser-provider-crossbrowsertesting" the first few tests error with the following message:
1) A JavaScript error occurred on "http://localhost:3000/my/route".
      Repeat test actions in the browser and check the console for errors.
      If you see this error, it means that the tested website caused it. You can fix it or disable tracking JavaScript errors in TestCafe. To do the latter, enable the "--skip-js-errors" option.
      If this error does not occur, please write a new issue at:
      "https://github.com/DevExpress/testcafe/issues/new?template=bug-report.md".

      JavaScript error details:
      SyntaxError: JSON.parse
         at exports.parse (http://localhost:1337/hammerhead.js:17:11375)
         at h (http://localhost:1337/hammerhead.js:13:20510)

There are no errors in the console when I visit my locally running site, but there is a SSR related warning: index.js:1 Warning: Did not expect server HTML to contain a <div> in <div>.
What is the Expected behavior?
The tests run without error
What is your web application and your TestCafe test code?

Your complete test code (or attach your test files):

I have swapped any identifying information for fake generic info. If I mess up a data-id etc, it is in generalizing it here and not an actual issue with the test. I have watched and had all the tests passing successfully before.
import { Selector } from 'testcafe'
fixture`Detail Test`.page(`http://localhost:3000/my/route`)

const productsNav = Selector('#products-nav')
const papersNav = Selector('#papers-nav')
const filtersButton = Selector('[data-testid="filter-button"]')

test('should have the basic page data', async t => {
  await t.expect(papersNav).ok()
  await t.expect(productsNav).ok()
  await t.expect(filtersButton).ok('doesnt have filters button')
  const labels = await Selector('[data-testid="label"]')
  await t.expect(labels.count).eql(4)
  const categories = Selector('[data-testId="category-name"]')
  await t.expect(categories.count).eql(8)
})

 // links should contain number displayed
test('should have the same id displayed in link', async t => {
  const links = await Selector('a[data-testid|="link"]')
  const linkNodes = await links.count
  for (let i = 0; i < linkNodes; i++) {
    const linkId = await links.nth(i).id
    await t.expect(links.nth(i).textContent).contains(`${linkId}`)
  }
})

test('should have working papers navigation and links to papers on page', async t => {
  await t.click(papersNav)
  await t.wait(1000)
  const paperCount = await Selector('#paper-matches')
  await t.expect(paperCount).ok('didnt show paper count')
  const paperTitles = await Selector('[data-testid="paper-title"]')
  await t.expect(paperTitles.visible).ok()
  await t.expect(paperTitles.count).eql(5)
})

test('should navigate back to the products page from papers', async t => {
  await t.click(papersNav)
  const paperTitle = await Selector('[data-testid="paper-title"]')
  // verify I'm on the papers page
  await t.expect(paperTitle.length).lte(5)
  await t.click(productsNav)
  const title = await Selector('[data-testid="title"]')
  const infoLabels = await Selector('[data-testid="info-label"]')
  await t.expect(title).ok('no title')
  await t.expect(filtersButton).ok('no filters button')
  await t.expect(infoLabels).ok('no info labels')
})

test('should apply selected category filters correctly', async t => {
  await t.expect(filtersButton.visible).ok()
  await t.click(filtersButton)
  const categoryFilter = await Selector(
    '[data-testid="category-filter"]'
  )
  await t.expect(categoryFilter.visible).ok('Couldnt find filter')
  await t.click(categoryFilter)
  await t.click(filtersButton)
  const productCategories = await Selector('[data-testid="category-name"]')
  await t.expect(productCategories.count).eql(1)
})

test('should apply selected color filters correctly', async t => {
  await t.expect(filtersButton.visible).ok()
  await t.click(filtersButton)
  const colorFilter = await Selector(
    '[data-testid="color-filter-red"]'
  )
  await t.expect(colorFilter.visible).ok('Couldnt find filter')
  await t.click(colorFilter)
  await t.click(filtersButton)
  const productsListed = await Selector('[data-testid="products"]')
  const productNodes = await productsListed.count
  for (let i = 0; i < productNodes; i++) {
    await t.expect(productsListed.nth(i).textContent).contains('red')
  }
})

Your complete configuration file (if any):

runner file:
const createTestCafe = require('testcafe')
let runner = null
let testcafe = null

process.env.CBT_TUNNELS_USERNAME = my_user_name
process.env.CBT_TUNNELS_AUTHKEY = my_auth_key

createTestCafe('localhost', 1337, 1338)
  .then(tc => {
    testcafe = tc
    runner = testcafe.createRunner()
    return testcafe.createBrowserConnection()
  })
  .then(remoteConnection => {
    console.log('remote connection ready:', remoteConnection.url)

    runner
      .src('./integration-tests/*test*')
      .browsers(
         'crossbrowsertesting:Internet Explorer@11:Windows 7'
      )
      .run({
        selectorTimeout: 30000,
        assertionTimeout: 60000,
        pageLoadTimeout: 60000
      })
      .then(failed => {
        console.log('failed tests:', failed)
        testcafe.close()
      })
      .catch(error => {
        console.log(error)
      })
  })

Your complete test report:

(feature/testCafe-sample) $ yarn tc
yarn run v1.17.3
$ node ./bin/integration.js --skip-js-errors
remote connection ready: http://localhost:1337/browser/connect/9egz7G8
[2019-11-04T14:49:38.817] [INFO] default - Connecting as simpleproxy.
[2019-11-04T14:49:38.987] [ERROR] default - Your version of cbt_tunnels is out-of-date,  but still supported. In order to update it now exit this program and run:

         npm update -g cbt_tunnels
[2019-11-04T14:49:39.607] [INFO] default - Completely connected!
 Running tests in:
 - IE 11.0.0 / Windows 7.0.0

Detail Test
 ✖ should have the basic page data

   1) A JavaScript error occurred on "http://localhost:3000/my/route".
      Repeat test actions in the browser and check the console for errors.
      If you see this error, it means that the tested website caused it. You can fix it or disable tracking JavaScript errors in TestCafe. To do the latter, enable the "--skip-js-errors" option.
      If this error does not occur, please write a new issue at:
      "https://github.com/DevExpress/testcafe/issues/new?template=bug-report.md".

      JavaScript error details:
      SyntaxError: JSON.parse
         at exports.parse (http://localhost:1337/hammerhead.js:17:11375)
         at h (http://localhost:1337/hammerhead.js:13:20510)

      Browser: IE 11.0.0 / Windows 7.0.0

 ✖ should have the same id displayed in link

   1) A request to "http://localhost:3000/my/route" has failed.
      Use quarantine mode to perform additional attempts to execute this test.
      You can find troubleshooting information for this issue at "https://go.devexpress.com/TestCafe_FAQ_ARequestHasFailed.aspx".

      Error details:
      Failed to complete a request to "http://localhost:3000/my/route" within the timeout period. The problem may be related to local machine's network or firewall settings, server outage, or network problems that
      make the server inaccessible.

      Browser: IE 11.0.0 / Windows 7.0.0

 ✖ should have working Papers Navigation and links to papers on page

   1) A request to "http://localhost:3000/my/route" has failed.
      Use quarantine mode to perform additional attempts to execute this test.
      You can find troubleshooting information for this issue at "https://go.devexpress.com/TestCafe_FAQ_ARequestHasFailed.aspx".

      Error details:
      Failed to find a DNS-record for the resource at "http://localhost:3000/my/route".

      Browser: IE 11.0.0 / Windows 7.0.0

         25 |    await t.expect(links.nth(i).textContent).contains(`${linkId}`)
         26 |  }
         27 |})
         28 |
         29 |test('should have working Papers Navigation and links to papers on page', async t => {
       > 30 |  await t.click(papersNav)
         31 |  await t.wait(1000)
         32 |  const paperCount = await Selector('#paper-matches')
         33 |  await t.expect(paperCount).ok('didnt show paper count')
         34 |  const paperTitles = await Selector('[data-testid="paper-title"]')
         35 |  await t.expect(paperTitles.visible).ok()

         at <anonymous> (/detail.integration.test.js:30:11)
         at test (/detail.integration.test.js:29:1)
         at <anonymous> (/node_modules/testcafe/src/api/wrap-test-function.js:17:28)
         at TestRun._executeTestFn (/node_modules/testcafe/src/test-run/index.js:290:19)
         at TestRun.start (/node_modules/testcafe/src/test-run/index.js:341:24)

 ✖ should navigate back to the products page from peer papers

   1) A request to "http://localhost:3000/my/route" has failed.
      Use quarantine mode to perform additional attempts to execute this test.
      You can find troubleshooting information for this issue at "https://go.devexpress.com/TestCafe_FAQ_ARequestHasFailed.aspx".

      Error details:
      Failed to complete a request to "http://localhost:3000/my/route" within the timeout period. The problem may be related to local machine's network or firewall settings, server outage, or network problems that
      make the server inaccessible.

      Browser: IE 11.0.0 / Windows 7.0.0

         36 |
         37 |  await t.expect(paperTitles.count).eql(5)
         38 |})
         39 |
         40 |test('should navigate back to the products page from papers', async t => {
       > 41 |  await t.click(papersNav)
         42 |  const paperTitle = await Selector('[data-testid="paper-title"]')
         43 |  // verify I'm on the papers page
         44 |  await t.expect(paperTitle.length).lte(5)
         45 |  await t.click(productsNav)
         46 |  const geneTitle = await Selector('[data-testid="title"]')

         at <anonymous> (/detail.integration.test.js:41:11)
         at test (/detail.integration.test.js:40:1)
         at <anonymous> (/node_modules/testcafe/src/api/wrap-test-function.js:17:28)
         at TestRun._executeTestFn (/node_modules/testcafe/src/test-run/index.js:290:19)
         at TestRun.start (/node_modules/testcafe/src/test-run/index.js:341:24)

 ✖ should apply selected category filters correctly

   1) A JavaScript error occurred on "http://localhost:3000/my/route".
      Repeat test actions in the browser and check the console for errors.
      If you see this error, it means that the tested website caused it. You can fix it or disable tracking JavaScript errors in TestCafe. To do the latter, enable the "--skip-js-errors" option.
      If this error does not occur, please write a new issue at:
      "https://github.com/DevExpress/testcafe/issues/new?template=bug-report.md".

      JavaScript error details:
      SyntaxError: JSON.parse
         at exports.parse (http://localhost:1337/hammerhead.js:17:11375)
         at h (http://localhost:1337/hammerhead.js:13:20510)

      Browser: IE 11.0.0 / Windows 7.0.0

         50 |  await t.expect(infoLabels).ok('no info labels')
         51 |})
         52 |
         53 |test('should apply selected gene category filters correctly', async t => {
         54 |  await t.expect(filtersButton.visible).ok()
       > 55 |  await t.click(filtersButton)
         56 |  const categoryFilter = await Selector(
         57 |    '[data-testid="category-filter"]'
         58 |  )
         59 |  await t.expect(categoryFilter.visible).ok('Couldnt find filter')
         60 |  await t.click(categoryFilter)

         at <anonymous> (/detail.integration.test.js:55:11)

[2019-11-04T14:56:54.405] [ERROR] default - User requested ending this tunnel.
[2019-11-04T14:56:54.413] [ERROR] default - Disconnected from CBT server.

[2019-11-04T14:56:54.744] [INFO] default - Local connection disconnected.
[2019-11-04T14:56:54.745] [INFO] default - Bye!
✨  Done in 446.78s.

Screenshots:

Steps to Reproduce:

Your Environment details:

testcafe version:                   1.6.0
node.js version:                    v10.16.0
command-line arguments:  yarn script: "tc": "node ./bin/integration.js --skip-js-errors"
browser name and version: crossbrowsertesting:Internet Explorer@11:Windows 7
platform and version:         macOS 10.14.6
other:

Hello @ljones87,
Thank you for reaching out to us. I see that you pass the --skip-js-errors option as a command-line argument and use the programming interface at the same time. To make this option work, you need to add it to the options object of the run method as follows:
.run({
        selectorTimeout: 30000,
        assertionTimeout: 60000,
        pageLoadTimeout: 60000,
        skipJsErrors: true
})

Please let us know if this solves your issue.
I also noticed that you create a remote connection, but do not use it in the browsers method. If this is not related to corrections you've made in order to post your code here, you may not create the remote connection.


Only show file name

Need an option, when the option is true, only show the result of matching the file name and search word.
Like above, only show _nvimrc

You can use :Clap files ++finder=[YOUR FINDER] [YOUR FINDER ARGS] to meet your own need. See :h Clap-files.


handle diags that happen during repl code completion

This fixes the test/IDE/complete_tf_195.swift failure that occurred during the merge, by:

Reverting https://github.com/apple/swift/pull/22589, which was a temporary patch over the autocomplete crash.
Cherry-picking https://github.com/apple/swift/pull/22591, which is a correct fix for the autocomplete crash, which I am about to merge into upstream.

(This deletes test/IDE/complete_tf_195.swift because it's named test/IDE/repl_complete_with_error.swift in the upstream patch.)

@swift-ci please test tensorflow


Format wavefront aberration distribution

We now know that the wavefront aberration distribution, $W(x, y)$ is a function with dimensions, there could be many conventions but what I think we should adopt is the following:
$$W(x, y) = \sum K_{n\ell} U^\ell_n \quad \Rightarrow \varphi = \frac{2\pi}{\lambda} W(x, y)$$
then the fill phase of the aperture distribution (a.k.a., the pupil function) is given by the factor $\frac{2\pi}{\lambda}$, hence for the phase to be in radians, the aberration must have units of length, not important what value are since that information will be absorbed by. $K_{n\ell}$ set.

Then I suggest to do the following:
phi = (W / wavel.to_value(apu.m) + delta / wavel) * 2 * np.pi * apu.rad

instead of
https://github.com/astronomy-laboratory/pyoof/blob/0c42031452327384d656ba0c3ff8ca55b46def5e/pyoof/aperture/aperture.py#L431
so we expose the constant wavel.

You should also include the key parameter wavel in the phase function
https://github.com/astronomy-laboratory/pyoof/blob/0c42031452327384d656ba0c3ff8ca55b46def5e/pyoof/aperture/aperture.py#L256
or equivalently, you could force the system to return $W(x,y)$ with units of length, i.e.,
https://github.com/astronomy-laboratory/pyoof/blob/0c42031452327384d656ba0c3ff8ca55b46def5e/pyoof/aperture/aperture.py#L247-L253
hence,
return W * apu.m

whatever you think is more elegant, requires less modifications, and solves the problem. I agree that there's no clear solution path here ... in the future we should come up with a better way of defining the coefficients.

I made fits taking different amount of wavelengths from 250, 350 and 450 um. And compared the resulting Zernike Coefficients with the Real Zernike Coefficients of the simulation. In this graph I'm plotting the error in each of the K for the different test. it seems like the best fit is taking a single frequency of 450. Taking different frequencies seems to average to performance of the single frequency fits. below are the mean square errors for each of the wavelength combinations

mse at wavel (250,): 2.8924365404896213e-11
mse at wavel (350,): 1.602792976104331e-11
mse at wavel (450,): 1.6930642357025475e-11
mse at wavel (250, 350): 2.1127937234330985e-11
mse at wavel (250, 450): 2.0603551318572783e-11
mse at wavel (350, 450): 1.7808212820166247e-11
mse at wavel (250, 350, 450): 1.8814149956317777e-11

What do you mean with:

I'm plotting the error in each of the K for the different test.

Are taking the covariance matrix diagonal to obtain this value or is this something else?
Not sure if this is the best way to evaluate this. I would have done the following:

Take those same simulations and results
Compute the perpendicular displacement (i.e., the phase equivalent in perpendicular displacement units) for each case
Compute the RMS for each displacement map (which should be given a tolerance since the edges get ugly; i.e., evaluating in a radius r < pr * .8)
Then make this same plot but with the RMS results

That way you are comparing the overall fit and not only a few parameters isolated. Remember that even if this is a simulation the aperture is not super orthonormal and correlation among parameters will exist.

Maybe there's a relationship between the pr and the observing frequency?


progress on 2539-template download

Add indicator data to template with appropriate formatting.

I will be putting help text comments in eventually.  I'm going to leave the template export a little half-baked for now.  The import will share some fo the serializer and view infrastructure, and I want to be sure those are playing well together before finishing this off.


Ineffective OutputParser Implementation in PromptTemplate

Description
I have been testing the functionality of the PromptTemplate class and noticed that it includes a getter and a setter for an OutputParser variable. However, upon reviewing the code and conducting several tests, it appears that this variable is not being utilized as expected.
Issue Details
The current implementation of OutputParser in PromptTemplate does not seem to affect the template output. Setting a value to outputParser does not integrate the parser's format into the template.
According to the documentation, the correct way to use an OutputParser in a PromptTemplate is by incorporating {format} in the template string, which should reflect the value from outputParser.getFormat() in the model.
Proposals for Improvement

Remove the OutputParser from the PromptTemplate codebase to eliminate confusion, as it currently serves no operational purpose.
Enhance PromptTemplate by allowing OutputParser to be set either directly or through the constructor. The class should then automatically integrate the necessary format handling using outputParser.getFormat().

Steps to Reproduce

Instantiate a PromptTemplate.
Set a custom OutputParser with a specific format.
Generate output using the PromptTemplate.
Observe that the format specified in OutputParser is not reflected in the output.

I have same concern about PromptTemplate when learning how to use it. There is no reason for including outputParser property into it and maybe it should be removed?

I would be inclined to remove it.  This comes from the very early says where I was reviewing langchain and llamaindex and langchain had this design.  It is a mistake in retrospect.


IPAddressToInterface: primary_for_device was Removed, Left in Data Migration

primary_for_device was removed from the through table but was mistakenly left in the data migration and should be fixed (see: https://github.com/nautobot/nautobot/pull/3399/files#diff-5b80e8c4aec86a1835c0513142525508a775003912987e6285c4a31646d42c21R39)

Implemented by #4192


"Pin" instead of "Member ID" used on some front-page tables

Summary of the Bug
The "Most Rated Games (Past 12 Months)" and "Most Tournaments (Past 12 Months)" tables on https://agagd.usgo.org/ use an inconsistent term for the member ID column heading: "Pin" instead of "Member ID".

Changed settings and updates files to present a standard "members id" in the top ten lists.


NT sub-region update: Add retry

Sufficient for now. Can think of redesigning this if it gets properly integrated into Covid19CanadaETL.


final jet fixes

Codecov Report

Merging #72 (b931f95) into master (0d4ec26) will increase coverage by 0.06%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master      #72      +/-   ##
==========================================
+ Coverage   85.06%   85.12%   +0.06%
==========================================
  Files          15       15
  Lines        2230     2071     -159
==========================================
- Hits         1897     1763     -134
+ Misses        333      308      -25

Impacted Files
Coverage Δ

src/experimental/NoisyCircuits.jl
54.50% <ø> (-1.58%)
:arrow_down:

src/QuantumClifford.jl
88.58% <100.00%> (+0.64%)
:arrow_up:

src/entanglement.jl
100.00% <100.00%> (ø)

src/precompiles.jl
90.62% <0.00%> (-6.44%)
:arrow_down:

src/useful_states.jl
59.01% <0.00%> (-0.36%)
:arrow_down:

src/project_trace_reset.jl
92.33% <0.00%> (-0.33%)
:arrow_down:

src/enumeration.jl
96.93% <0.00%> (-0.31%)
:arrow_down:

src/graphs.jl
100.00% <0.00%> (ø)

... and 6 more

Help us with your feedback. Take ten seconds to tell us how you rate us.


Update demo gif image with new features

Our demo gif is out of date. We need to update it demonstrating our new features:

New welcome message
Invalid inputs prevention
Help command
Rocket events messages

I would love to work on this issue!

@elizabeth87 Great!! Go ahead! I'll assign to you!


Static building

Description
Numerous small fixes for issues discovered when statically linking on Windows.
Tests

Checklist:

[x] I have read the contribution guidelines.
[x] If this is more extensive than a small change to existing code, I
have previously submitted a Contributor License Agreement
(individual, and if there is any way my
employers might think my programming belongs to them, then also
corporate).
[ ] I have updated the documentation, if applicable.
[ ] I have ensured that the change is tested somewhere in the testsuite
(adding new test cases if necessary).
[x] My code follows the prevailing code style of this project.

A CI test for the static builds would be amazing, but I think it will be quite hard to set up.
On Windows (where I'm currently building a static OIIO) there is a lot of CMake mangling I am doing to point/trick all of the find_package scripts into working. Not to mention ensuring all the dependencies are built with the correct Debug/Release modes.


Mediapipe model, it can be run on a desktop with GPU support?

Mediapipe model, it can be run on a desktop with GPU support?

Hello @kuaashish, pls, show me about my output.
/usr/lib/python3/dist-packages/setuptools/dist.py:507: UserWarning: The version specified ('dev') is an invalid version, this may not work as expected with newer versions of setuptools, pip, and PyPI. Please see PEP 440 for more details.
  warnings.warn(
running bdist_wheel
running build
running build_py
running gen_protos
running generate_metadata_schema
error: [Errno 2] No such file or directory: 'bazel'

I am using mediapipe repository and getting bazel error...

Hello @Mr-Khans,
Would you please let us know the exact support you are looking from us, From the description and recent comment we are not able to get the things that you are trying build mediapipe on Desktop, GPU or Python, GPU? If, You can share the mentioned information then we will be glad to help on the issue you are facing. Thank you

Hola @kuaashish
I want to run mediapipe on gpu using win10 wsl Ubuntu 20.04, bazel 5.2.0, I want to run manual solution, I can't successfully build bazel, it throws build errors.
I want to create a GPU solution manually via bazel.

Hola @kuaashish
Is there an example of running mediapipe on the GPU using python or in a python environment, because this example uses .cc files, which means C++?


This policy creates an error on AWS: "Cannot exceed quota for PolicySize: 6144"

File: docker-for-aws/iam-permissions.md, CC @gbarr01

/cc @FrenchBen

I solved it.
The linked document (https://docs.docker.com/docker-for-aws/iam-permissions/) is what is supposed to to be the ideal policy. Error was "Cannot exceed quota for PolicySize: 6144" - which I've seen other issues about.
I fixed it by consolidating the policy, which fully resolves the issue. It's just too long. I haven't tried compressing, but that probably doesn't help?
Final, working solution (as modified from the docker resource), to those who surf:
{     "Version": "2012-10-17",     "Statement": [         {             "Sid": "Stmt1481924239005",             "Effect": "Allow",             "Action": [                 "cloudformation:*"             ],             "Resource": [                 "*"             ]         },         {             "Sid": "Stmt1481924344000",             "Effect": "Allow",             "Action": [                 "ec2:*"             ],             "Resource": [                 "*"             ]         },         {             "Sid": "Stmt1481924651000",             "Effect": "Allow",             "Action": [                 "autoscaling:*"             ],             "Resource": [                 "*"             ]         },         {             "Sid": "Stmt1481924759004",             "Effect": "Allow",             "Action": [                 "dynamodb:*"             ],             "Resource": [                 "*"             ]         },         {             "Sid": "Stmt1481924854000",             "Effect": "Allow",             "Action": [                 "logs:*"             ],             "Resource": [                 "*"             ]         },         {             "Sid": "Stmt1481924989003",             "Effect": "Allow",             "Action": [                 "sqs:*"             ],             "Resource": [                 "*"             ]         },         {             "Sid": "Stmt1481924989002",             "Effect": "Allow",             "Action": [                 "iam:*"             ],             "Resource": [                 "*"             ]         },         {             "Sid": "Stmt1481924989001",             "Effect": "Allow",             "Action": [                 "*"             ],             "Resource": [                 "*"             ]         },         {             "Sid": "Stmt1487169681000",             "Effect": "Allow",             "Action": [                 "elasticfilesystem:*"             ],             "Resource": [                 "*"             ]         },         {             "Sid": "Stmt1487169681009",             "Effect": "Allow",             "Action": [                 "*"             ],             "Resource": [                 "*"             ]         }     ] }

For those using the policy from @joeyslack above. Please be careful, as the policy gives full, unrestricted access to all services due to the last, and third to last blocks:
{
    "Sid": "Stmt1487169681009",
    "Effect": "Allow",
    "Action": [
        "*"   // No colon = all services
    ],
    "Resource": [
        "*"
    ]
}

You can change these to elasticloadbalancing:* and lambda:* for a slightly more restricted policy that will work with Docker For AWS
{
    "Version": "2012-10-17",
    "Statement": [
        {
            "Sid": "Stmt1481924239005",
            "Effect": "Allow",
            "Action": [
                "cloudformation:*"
            ],
            "Resource": [
                "*"
            ]
        },
        {
            "Sid": "Stmt1481924344000",
            "Effect": "Allow",
            "Action": [
                "ec2:*"
            ],
            "Resource": [
                "*"
            ]
        },
        {
            "Sid": "Stmt1481924651000",
            "Effect": "Allow",
            "Action": [
                "autoscaling:*"
            ],
            "Resource": [
                "*"
            ]
        },
        {
            "Sid": "Stmt1481924759004",
            "Effect": "Allow",
            "Action": [
                "dynamodb:*"
            ],
            "Resource": [
                "*"
            ]
        },
        {
            "Sid": "Stmt1481924854000",
            "Effect": "Allow",
            "Action": [
                "logs:*"
            ],
            "Resource": [
                "*"
            ]
        },
        {
            "Sid": "Stmt1481924989003",
            "Effect": "Allow",
            "Action": [
                "sqs:*"
            ],
            "Resource": [
                "*"
            ]
        },
        {
            "Sid": "Stmt1481924989002",
            "Effect": "Allow",
            "Action": [
                "iam:*"
            ],
            "Resource": [
                "*"
            ]
        },
        {
            "Sid": "Stmt1481924989001",
            "Effect": "Allow",
            "Action": [
                "elasticloadbalancing:*"
            ],
            "Resource": [
                "*"
            ]
        },
        {
            "Sid": "Stmt1487169681000",
            "Effect": "Allow",
            "Action": [
                "elasticfilesystem:*"
            ],
            "Resource": [
                "*"
            ]
        },
        {
            "Sid": "Stmt1487169681009",
            "Effect": "Allow",
            "Action": [
                "lambda:*"
            ],
            "Resource": [
                "*"
            ]
        }
    ]
}

Closing this ticket due to its age, and the impending refactor. If you think this is in error, feel free to reopen. Thanks!

For those using the policy from @joeyslack above. Please be careful, as the policy gives full, unrestricted access to all services due to the last, and third to last blocks:
{
    "Sid": "Stmt1487169681009",
    "Effect": "Allow",
    "Action": [
        "*"   // No colon = all services
    ],
    "Resource": [
        "*"
    ]
}

You can change these to elasticloadbalancing:* and lambda:* for a slightly more restricted policy that will work with Docker For AWS
{
    "Version": "2012-10-17",
    "Statement": [
        {
            "Sid": "Stmt1481924239005",
            "Effect": "Allow",
            "Action": [
                "cloudformation:*"
            ],
            "Resource": [
                "*"
            ]
        },
        {
            "Sid": "Stmt1481924344000",
            "Effect": "Allow",
            "Action": [
                "ec2:*"
            ],
            "Resource": [
                "*"
            ]
        },
        {
            "Sid": "Stmt1481924651000",
            "Effect": "Allow",
            "Action": [
                "autoscaling:*"
            ],
            "Resource": [
                "*"
            ]
        },
        {
            "Sid": "Stmt1481924759004",
            "Effect": "Allow",
            "Action": [
                "dynamodb:*"
            ],
            "Resource": [
                "*"
            ]
        },
        {
            "Sid": "Stmt1481924854000",
            "Effect": "Allow",
            "Action": [
                "logs:*"
            ],
            "Resource": [
                "*"
            ]
        },
        {
            "Sid": "Stmt1481924989003",
            "Effect": "Allow",
            "Action": [
                "sqs:*"
            ],
            "Resource": [
                "*"
            ]
        },
        {
            "Sid": "Stmt1481924989002",
            "Effect": "Allow",
            "Action": [
                "iam:*"
            ],
            "Resource": [
                "*"
            ]
        },
        {
            "Sid": "Stmt1481924989001",
            "Effect": "Allow",
            "Action": [
                "elasticloadbalancing:*"
            ],
            "Resource": [
                "*"
            ]
        },
        {
            "Sid": "Stmt1487169681000",
            "Effect": "Allow",
            "Action": [
                "elasticfilesystem:*"
            ],
            "Resource": [
                "*"
            ]
        },
        {
            "Sid": "Stmt1487169681009",
            "Effect": "Allow",
            "Action": [
                "lambda:*"
            ],
            "Resource": [
                "*"
            ]
        }
    ]
}

I need a policy in which all services (174 services)with only Read/List access.


e2e test for vault

We can spin it up using the compose file from sigstore: https://github.com/sigstore/sigstore
Then we have to enable transit and we should be good to go.

I think it has already done, you can close this issue @dlorenc 🙋🏻♂
https://github.com/sigstore/sigstore/blob/main/test/e2e/kms/vault_test.go


Fix box could not be found

After completing all required steps and trying to run vagrant up mysql I got the following error:
Bringing machine 'mysql' up with 'virtualbox' provider...
==> mysql: Box 'chef/ubuntu-14.04' could not be found. Attempting to find and install...
    mysql: Box Provider: virtualbox
    mysql: Box Version: >= 0
==> mysql: Loading metadata for box 'chef/ubuntu-14.04'
    mysql: URL: https://atlas.hashicorp.com/chef/ubuntu-14.04
The box you're adding has a name different from the name you
requested. For boxes with metadata, you cannot override the name.
If you're adding a box using `vagrant box add`, don't specify
the `--name` parameter. If the box is being added via a Vagrantfile,
change the `config.vm.box` value to match the name below.

Requested name: chef/ubuntu-14.04
Actual name: bento/ubuntu-14.04

Renaming config.vm.box to bento/ubuntu-14.04 fixed the issue.

@yourivdlans Thanks

:+1:


Internal Script Error! -opcode #38 when loading Resource derived class from disk

Godot version: 3.2.4 Beta 1

OS/device including version: Kubuntu 18.04

Issue description: When loading a resource it errors giving Internal Script Error! - opcode # 38 .

Steps to reproduce:

Create a script that extends Resource and assign a class name
Declare an exported variable

Create a resource of that type and save as .tres
load the tres in gdscript with the load() function

Minimal reproduction project: ResourceLoad.zip

Apologies if this already known, I had a search but couldn't find anything matching this issue.  I found this after trying out my latest released project in the beta.  It gave the error when loading a data class I use for enemies.  The code works no problems in 3.2.2.

Duplicate of https://github.com/godotengine/godot/issues/43042.

Apologies if this already known, I had a search but couldn't find anything matching this issue

I found the original issue by searching for "opcode 38".


Add gtk3 support

Chromium has recently landed minimal support for GTK3. This is optional and hidden under a build flag.  Would it be useful to take this into use as GTK3 should support wayland ? This should enable support for themes, dialog boxes etc in ozone-wayland

@michaelforney  @rakuco @joone @mcatanzaro @hobbitalastair  WDYT ?

Probably a good idea, but I guess we'd have the same problem as in #420...?

@kalyankondapally  which commits of Chromium support Gtk+3?

@kalyankondapally which commits of Chromium support Gtk+3?

He's probably referring to https://code.google.com/p/chromium/issues/detail?id=132847

@rakuco @joone Ya, thats the one

@mcatanzaro hmm true. Good point. Everything needs to be proxy in Browser process and actual handling done in GPU side.


[Draft]Move ClusterChangeListener to ReplicationEngine

Codecov Report

Merging #1892 (16edd99) into master (d533cf4) will decrease coverage by 58.56%.
The diff coverage is 0.00%.

@@              Coverage Diff              @@
##             master    #1892       +/-   ##
=============================================
- Coverage     74.00%   15.43%   -58.57%
+ Complexity     9634     2260     -7374
=============================================
  Files           689      689
  Lines         52955    52953        -2
  Branches       6587     6587
=============================================
- Hits          39187     8172    -31015
- Misses        11713    44300    +32587
+ Partials       2055      481     -1574

Impacted Files
Coverage Δ

.../com/github/ambry/cloud/VcrReplicationManager.java
0.00% <0.00%> (-72.65%)
:arrow_down:

...ry/replication/CloudToStoreReplicationManager.java
0.00% <0.00%> (-65.34%)
:arrow_down:

...om/github/ambry/replication/ReplicationEngine.java
0.00% <0.00%> (-82.82%)
:arrow_down:

...m/github/ambry/replication/ReplicationManager.java
0.00% <0.00%> (-89.81%)
:arrow_down:

.../src/main/java/com/github/ambry/router/Router.java
0.00% <0.00%> (-100.00%)
:arrow_down:

.../src/main/java/com/github/ambry/store/Message.java
0.00% <0.00%> (-100.00%)
:arrow_down:

...rc/main/java/com/github/ambry/named/PutResult.java
0.00% <0.00%> (-100.00%)
:arrow_down:

...rc/main/java/com/github/ambry/quota/QuotaMode.java
0.00% <0.00%> (-100.00%)
:arrow_down:

...rc/main/java/com/github/ambry/quota/QuotaName.java
0.00% <0.00%> (-100.00%)
:arrow_down:

...rc/main/java/com/github/ambry/rest/RestMethod.java
0.00% <0.00%> (-100.00%)
:arrow_down:

... and 545 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d533cf4...16edd99. Read the comment docs.


Generate MP4 representation for media that lacks one automatically

There are some GIFs and videos that lack MP4 representation. Here is one example from derpibooru: https://derpibooru.org/images/453941
That's problematic because the best would be if we could just transfer the media from the media platform to telegram without intermediate downloads and conversions. However, bugs do exist and some media may not have the necessary representation available, while some other representation does exist. For example, GIF and webm are likely to be available if MP4 isn't on derpibooru.

This was done in #47


Add basic testing: static analysis using flake8

Adds basic tests using static analysis provided by flake8 (which I prefer over pylint because it is not as complainy by default), and fix some whitespace and other style issues indicated by it.
Also add basic tests converted from the printouts of main branch of pyqtconsole/text.py.

Thanks :)


jupyterlab support

the current version of pdvega will not work in JupyterLab: the main reason is that the new MIME-based rendering used by JupyterLab is not yet supported in the vega3 library that pdvega depends on

Just wanted to clarify that this is correct, even with the vega3 jupyterlab extension?
If that is the case I guess this can be kept open to track any progress...

Yes, this is true that pdvega is incompatible with JupyterLab.
The fix will be to display plots using the tools in Altair 2.0 once it's released.

is there a rough guesss of Altair-2.0 release ? March 1rst ? April ? June ?

Well, I'm giving a PyCon tutorial on Altair 2, so I'd say... before that 😄

:tada:

ok: may the 4th be with us

Hi, just wanted to check if there was any update re: JupyterLab compatibility. I think this project fills a very useful niche, especially for notebook-heavy workflows, and would like to know if there's any progress and/or roadmap on this.

Yes, currently the master branch relies on Altair for rendering, and Altair rendering is compatible with Jupyterlab.

I think so


Generalize the "violators" policy, triggers, and display

One of the requirements (https://github.com/NAICNO/Jobanalyzer/blob/main/REQUIREMENTS.md#adm_misfits) generalizes the cpuhog use case that we currently have for the ML nodes to jobs that are not greedy (which is what the cpuhogs are) but too big, too small, too long-running.  Generalizing the notion of policy and how we discover violators fits in with eg #222; generalizing the display is another matter.

The display will be generalized in #292 and that will happen first.  For the present bug we only need to figure out how to expose new violators.  The violations need to be tagged with the policy they are violating; existing untagged violations can be assumed to be tagged "ml-cpuhog".  Eventually the tag will be exposed in the display, too.


Corrected little error in manual

serialization is a PRIVATE dependency of archiveExtras and not of archive as stated/written in the current version of the buildsystem cmake manual

Thanks.  Ported to GitLab MR 1097.  Please see CONTRIBUTING.rst for the preferred contribution path.