Add JsLIGO support

Description

Checklist:

[x] I am adding a new language.

[x] The extension of the new language is used in hundreds of repositories on GitHub.com.

Search results for each extension:

https://github.com/search?q=extension%3Ajsligo&type=code

[x] I have included a real-world usage sample for all extensions added in this PR:

Sample source(s):

https://gitlab.com/ligolang/contract-catalogue/-/blob/main/lib/fa1.2/FA1.2.jsligo

Sample license(s): MIT

[x] I have included a syntax highlighting grammar: [URL to grammar repo]
[ ] I have updated the heuristics to distinguish my language from others using the same extension.

Usage of this extension is too low at the moment with six users contributing all but 58 files

Can you please also update the OP to link to the source of the sample and explicitly stated the license of the file.

Can you please also update the OP to link to the source of the sample and explicitly stated the license of the file.

I did not completely understand, do you mean I need to add license information to the provided sample like
(MIT License Copyright (c) 2020 LigoLANG SASU ... ) ?

Nope. Just fill in this park of the template that you've left empty:

I have included a real-world usage sample for all extensions added in this PR:
Sample source(s):
[URL to each sample source, if applicable]
Sample license(s):

Hey @lildude I see in the search query some users are excluded https://github.com/search?p=6&q=extension%3Ajsligo+-user%3Aemacsmirror+-user%3Aligolang+-user%3Atezos-checker+-user%3Amarigold-dev+-user%3Asmart-chain-fr+-user%3ADiningPhilosophersCo&type=Code
Is this done to check community adoption of jsligo?

Yes. That's removing the biggest contributors so we can get a better idea of overall usage as GitHub's search is struggling at the moment. See https://github.com/github/linguist/issues/5756 for the temporary criteria were using.

@lildude I am surprise about the user list that you removed from the query. I mean I understand that you remove ligolang but what about the others ? can you elaborate ?
What would be the minimum number of users and code files required to accept the PR ? The guideline says 200 user/repo

@lildude It's been around a year since I raised this PR, I see now there are 237 files according to this search url.
I am not able to find the number of users using .jsligo files the search url says 106M, Do you have some internal tool with which you can find the number of users?
Also can current usage of .jsligo enough for this PR to be included into linguist (If yes I'll resolve the merge conflicts and make this PR ready)
Thanks.

Hey @lildude It's been around a year since I raised this PR, I see now there are 237 files according to this search url.

That's still very low, especially considering a repo can have multiple .jsligo files and as such isn't likely to meet our original requirements... even the temporarily relaxed requirements aren't be met.
Using the new search (it is still indexing repos from most recently active to least recently active so won't include everything yet) path:*.jsligo returns ~1.1k files. If we filter out just the two most prominent users as before path:*.jsligo -user:emacsmirror -user:ligolang
 things drop quite significantly to 470 files. If we filter out all the users as before path:*.jsligo -user:emacsmirror -user:ligolang -user:tezos-checker -user:marigold-dev -user:smart-chain-fr -user:DiningPhilosophersCo we're down to 159 files.

I am not able to find the number of users using .jsligo files the search url says 106M, Do you have some internal tool with which you can find the number of users?

I used to use a script but this is no longer possible due to problems with the old code search and the reason for the change in process as documented in https://github.com/github/linguist/issues/5756
So things are still not popular enough for inclusion.

Cool, Thanks for your response @lildude

Hi @lildude,
Checking for this topic.
Do we have an idea how indexation works on Github ?
Looks like your request with extension got partial result  for example this search result to 0 code, but this repo got jsligo file since 6 month.
Looks like I triggered manually indexation with path:*.jsligo repo:Laucans/Intezos-tutorial-1  :

But is the search request relevant ? Are you using another way to extract the number of distinct :user/:repo now ?

@Laucans No, I don't know how indexation works. This is maintained by a completely different team but I understand things will take time to index since we switched to using the new search functionality as active repositories are being prioritised with less active repos slowly being added as they're accessed or as the backlog is processed.

But is the search request relevant ? Are you using another way to extract the number of distinct :user/:repo now ?

The search is still relevant (it needs slight tweaking to exclude forks) and I'm still using the same temporary approach I previously referenced as there still isn't an easy way to calculate the distinct repos.


Pagenation component

This function solves the problem (这个功能解决的问题)
The pagination component lacks the function of returning to the first page and the last page, so it is expected to be added as a configurable item
Expected API (期望的 API)

firstEndIsShow controls whether the button to return to the end of the first page is displayed

First page & last page is always shown.


VMAlert: Infinite sync loop in ArgoCD when Replace=true

When Replace=true externalLabels in VMAlert are set to {} in desired manifest and completely lacking in target manifest. This causes infinite loop.
However adding dummy tags causes the TooHighChurnRate24h and TooManyLogs alerts.
Need a better fix

Trying to use ServerSideApply instead of Replace


random number generator

Please add a quick pseudo-random number sequences with a large cycle. It will be very useful to write generators landscape.

is that not ok https://github.com/mhsjlw/flying-squid/blob/master/src/lib/serverPlugins/world.js#L16 ?
also see https://github.com/mhsjlw/flying-squid/blob/master/src/lib/worldGenerations/diamond_square.js#L55
This seems to work anyway.

OK. thank

Originally we had a seed random number generator. The reason that was important was because the same world seed could be used to generate the exact same biomes and the same chunk seed could be used to generate the exact same chunk (and it was really easy too :P)

And we still do ?!

I mean, I was referencing that seed-random module or whatever it was

Ah yeah, well we might use that, but you were using it with a different seed for each chunk which didn't make sense.
It would probably be better to use that than to use Math.random() like you did there

Don't quote me on this but I'm pretty sure in vanilla chunk info (biome, height maps, generated structures, caves, etc) are generated by the seed and then everything else (adjusting the height map, trees, ores, grass, and other specific things) are all done randomly (meaning the same seed will never generate these things the same). If you want another seed so that you COULD get the exact same map, that's fine, however as far as I know, that's not how it's done in vanilla.


Export/Share characters

A way to export character sheets to other places (e.g. Google drive)

Added ability to share JSON files. This is required for #7
This is not the preview view in #24


api: Return the contents directly in Container Stdout/Stderr

This change removes the indirection stdout/stderr -> file -> contents.
Before:
ctr.Stdout.Contents(ctx)

After:
ctr.Stdout(ctx)

/cc @sipsma @shykes @kpenfound @helderco @vikram-dagger

Fixed all the errors, but I'm left with a valid error:
#17 119.5     container_test.go:410:
[2298](https://github.com/dagger/dagger/actions/runs/3501058891/jobs/5864313305#step:7:2299)
#17 119.5         	Error Trace:	/app/core/integration/container_test.go:410
[2299](https://github.com/dagger/dagger/actions/runs/3501058891/jobs/5864313305#step:7:2300)
#17 119.5         	Error:      	Expected nil, but got: ""
[2300](https://github.com/dagger/dagger/actions/runs/3501058891/jobs/5864313305#step:7:2301)
#17 119.5         	Test:       	TestContainerNullStdoutStderr

@sipsma Do you happen to remember if returning nil as a String (not a String!) returns nil or empty value?


[match] Enable importing developer ID certificates

Checklist

[x] I've run bundle exec rspec from the root directory to see all new and existing tests pass
[x] I've followed the fastlane code style and run bundle exec rubocop -a to ensure the code style is valid
[x] I've read the Contribution Guidelines
[ ] I've updated the documentation if necessary.

Motivation and Context
This update allows developer ID certificates to be imported via fastlane match import.
Description
I'm new to the fastlane codebase, but it appears that match tries to be helpful by verifying the certificates you are trying to import are available in the developer portal. It pulls down the certificates and then filters them by the type specified.
Currently, the only certificate types match import will filter with are development, distribution, and enterprise even though match supports developer_id certificates (source).
This change adds developer_id as a supported type that import can use to filter results from the developer portal.
Testing Steps
To see the error that prompted this PR you can apply this patch and then run bundle exec rspec match. The patch just reverts the change to import.rb to the current state.
original.patch.zip
I have added a new test that should provide coverage for this use case. You can verify this test passes by running bundle exec rspec match.

@googlebot I signed it!

Is there anything I need/can to do to help move this forward?

@joshdholtz Is there anything we an do to help get this reviewed faster? It would be really nice to get this into a release sooner than later.

I’m planning on getting this reviewed, merged, and pushed out today! Just hard to focus a lot right now on things with the state of the world 🤷♂

Understandable. Thank you!

Thank you! This feature is really important for automation of our Project.

@addisonwebb I've tested your changes and successfully uploaded developer_id provisioning profiles with certificates but I can't sync them back to the machine that will run CI actions.
When I run the command bundle exec fastlane match --verbose --readonly I get:
ERROR [2020-04-22 17:07:23.68]: No matching provisioning profiles found for 'Direct_com.***'
ERROR [2020-04-22 17:07:23.68]: A new one cannot be created because you enabled `readonly`
ERROR [2020-04-22 17:07:23.68]: If you are certain that a profile should exist, double-check the recent changes to your match repository
bundler: failed to load command: fastlane (/usr/local/bin/fastlane)

It seems like match expects some 'Direct_com.***' provisioning profiles and after uploading my I get:
certificates/profiles/developer_id_application/Developer_id_application_com.***

Moreover if to run command without --verbose match will generate some 'Direct_com.***' provisioning profiles at path:
certificates/profiles/developer_id/Direct_com.***

Please, notice the difference in folders: uploaded are located in developer_id_application and generated in developer_id.
Unfortunately I can't use generated one as they generates incorrectly for Catalyst app.
So my hope is on you)
P.S.: @joshdholtz you might be interested also.


hotelservice 2 - update error descriptions

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

:shipit:


Add StreamMessage.fromOutputStream()

Related Issue #3092
Motivation:
public HttpResponse serve(...) {
    var stream = StreaMessage.fromOutputStream(this:startBlockingService);
    return HttpRsponse.builder(headers)
                      .content(stream)
                      .build()
}

private void startBlockingService(OutputStream os) {
    // perform blocking operation
    var data0 = readDataFromSomeWhere0();
    // os.write() will be blocked if the subscriber of the returned HttpResponse hasn't consumed data0 yet.
    os.write(data0);
    var data1 = readDataFromSomeWhere1();
    os.write(data1);
    os.close();
}

See comment https://github.com/line/armeria/pull/4186#issuecomment-1211699740

We decide to introduce StreamMessage.fromOutputStream() on previous discussion

Modifications:

Add StreamMessage.fromOutputStream()

Result:

You can now use StreamMessage.fromOutputStream() to write on StreamMessage via OutputStream
✅ Close #3092 issue

Oops, could you check the test failure? 😄
https://github.com/line/armeria/actions/runs/3046441654/jobs/4909323803#step:7:873

ByteStreamMessageOutputStreamTest > writeAfterAborted() FAILED
    java.lang.AssertionError: expectation failed (did not expect: onNext({1B, hex=0d}))

Hmm.. I'll fix writeAfterAborted() test until tomorrow~!

Hmm.. I'll fix writeAfterAborted() test until tomorrow~!

Please, don't hurry. 😄

Hmm.. all tests success on my local 🤔

Hmm.. all tests success on my local 🤔

I found two problems:

onError() should be invoked in the EventExecutor.
onError() or onComplete()must be invoked only once but it seems possible to be double called. Becausesubscription.cancel()causes additional exception ifSubscriptionOption.NOTIFY_CANCELLATION` is specified.

How about using outputStreamWriter.abort(t) which might solve the two problems at once? The exception will eventually send back through an onError signal.
https://github.com/line/armeria/blob/cf9b4ffde6f724e7264d164d7f6058397ec17768/core/src/main/java/com/linecorp/armeria/common/stream/ByteStreamMessageOutputStream.java#L123

onError() should be invoked in the EventExecutor.

👍
Besides, we use try catch so os.close() is called before onError(e) is called. So the test fails because onComplete() is called beforehand.

@ikhoon , @minwoox nim, really thanks for catching problem! I couldn't find the problem by myself 😅

Awesome! 🎉 🎉 🎉  😄


Fix form translations

Hello,
I'm working with Python 3.4, so I use the Git version of django-helpdesk. And I noticed an annoying problem with the french translations (see attached screenshot). Here is the fix (and a small cleanup commit ;).

Merci beaucoup pour le fix @jflesch !


fixed

Codecov Report

Merging #9 (a52e7be) into master (856a7c1) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master       #9   +/-   ##
=======================================
  Coverage   99.75%   99.75%
=======================================
  Files          11       11
  Lines         400      401    +1
=======================================
+ Hits          399      400    +1
  Misses          1        1

Impacted Files
Coverage Δ

lib/widgets/reorderable_grid_view.dart
100.00% <ø> (ø)

lib/widgets/reorderable_grid_view_layout.dart
100.00% <ø> (ø)

.../widgets/reorderable_single_child_scroll_view.dart
100.00% <ø> (ø)

lib/widgets/reorderable.dart
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 856a7c1...a52e7be. Read the comment docs.


JS: Range analysis for dead code detection

This adds a query that detects dead code using range analysis. The original motivation was to find more results "out of the box" for when the security queries don't find anything interesting (before a round of tweaking, at least).
Commit-by-commit review strongly recommended.
Dead code criteria
The range analysis itself detects conditional that always return true or always return false. The last commit adds the "dead code criteria" so we only report conditionals that actually lead to dead code. This is to avoid noise from innocent defensive code, and focus on things that are more likely to be mistakes. It's not perfect, but it seems like the safe choice to avoid generating too much noise.
Here are a few "good" results we unfortunately lose to the dead code criteria:

vscode/monarchLexer.ts
A2Z-F15/ace
A2Z-F15/p5.sound
c9/editor
prettydiff/script.ts

It's a shame to lose those results; I'm open to suggestions here.
Evaluation

Results
Would-be results hidden by dead code criteria (last commit)
Updated performance (edit: original numbers)

Performance
The slowest project is node, I suspect mainly due to this file from hell. For the other slow-ish projects, the main culprit is actually hasUniquePredecessor, which I think might improve with QL-725. Alternatively, if we could somehow cache the inverse of localFlowStep that might help.
Relation to Java version
Like the range analysis in our Java suite, it builds a graph of inequalities, and uses the transitive nature of such a graph to infer additional inequalities. The implementations are quite different, though. Some parts of the Java implementation rely on IR features we don't have in JS, such as the ability to detect back-edges, and (I think) the chaining of variables uses. I'm not familiar enough with the JS IR to understand the fine points of the Java version, though.
Anyways, based on my cursory reading of the Java version, here are some differences. @aschackmull please comment if I misunderstood something.

The Java version can explicitly compute (a bound on) the difference between two variables. This version only looks for contradictions, by detecting negative-weight cycles, but doesn't actually tell you how large the difference between two variables is.
The Java version applies widening the second time a back-edge is used. This version uses a cycle-detection that doesn't require widening for termination (though we do require that weights are in the same order of magnitude to avoid blow-ups).
The Java version includes a special "zero" variable in the constraint system in order to encode unary constraints like x < 10. This version uses negated variables for that, so x < 10 is encoded at x - (-x) < 20. The "zero variable" approach doesn't work easily with the transitive rule used in this solution, as the a huge graph becomes connected to it, and a lot of uninteresting relationships are subsequently derived.
Some obvious differences due to the languages. JavaScript doesn't have type conversions or under/overflow. But we always have NaN and inexact arithmetic breathing down our necks, not that we're doing much to handle it, though.

I just tried running the "file from hell" through the java range analysis by running qltest on a java version of the file and the following query:
import java
import semmle.code.java.dataflow.RangeAnalysis
select count(Expr e, Bound b, int delta, boolean upper, Reason reason |
    bounded(e, b, delta, upper, reason)
  )

This resulted in 33573 tuples and the execution time was 9.5 seconds.  So this file doesn't appear to be problematic at all for the java implementation.

To comment a bit on the java implementation:
The interface is the predicate
predicate bounded(Expr e, Bound b, int delta, boolean upper, Reason reason)

which holds if e <= b + delta (for upper = true) where e is an expression and b is an abstract bound, which can be either zero, some Ssa variable, or some other "interesting" expression that we'd like to use as a bound.  So the analysis will give bounds on arbitrary expressions and not just variables.  And the resulting bounds are easily usable to identify conditions that are always true or always false - simply check that both sides of a comparison are upper resp. lower bounded by the same Bound and that the delta offsets are such that the comparison becomes constant (see UselesComparisonTest.ql).
As to the weakening that's used in the java implementation, it's easy to attribute to much to it.  In most cases weakening has no effect and the best possible bound is computed immediately.  This also holds for most loops.  The reason weakening is necessary is because it's possible to construct certain loops where say it's proven that x < bound in the first iteration, and then subsequently inferior bounds like x < bound + 1, x < bound + 2, etc. are computed in subsequent iterations.  But also in these cases the analysis tends to come up with the best bound first, and weakening simply stops the analysis from going into an infinite loop.
Negated variables (or negated bounds as it would correspond to in the java analysis) currently aren't in the java implementation, but should be easy to add, and it's something that I'm planning to look at at some point.  This would allow us to infer bounds on y based on bounds on x in an assignment y = -x;.

I've pushed two commits that improve on the performance, in particular for constant-comparisons. The big file from node.js now also takes around 9s assuming I did the benchmark correctly.
I can see the value in doing the path-finding like in the Java libraries since it gives a more general public API, but if we go that way I'd prefer to drive some changes to the IR first.

I've renamed the query to UselessComparisonTest as that's the closest match in the Java query suite.
As for the name "useless" - I'm not fond of it, but it's not something I want to change in this PR. If we want to change it, we should do so in a way that maintains consistency.

Did you want to take another look at performance (e.g., to gauge the effects recent optimiser/evaluator changes), or are you satisfied?

I'll look into performance a bit more.

Performance after pushing ce210df.

Fixed a rather egregious bug that warrants yet another perf run.

As per our offline discussion, I've reverted the change to hasUniquePredecessor accepting the cost.
Final performance numbers.

Thanks for the review @mc-semmle. The qhelp hadn't changed since your previous review, only the change note.

Right, let's try this out. Merging.


Add tip for opening logs directory

Also modified the --verbose-logs heading to include the succinct --verbose alternative as well

Looks good. Thank you for adding this @mdanish-kh!


All instances of Ichor are replaced with Blood from Tinker's Construct (1.12.2)

Nether EX version:  1.12.2-2.1.8
Naturally-generated pools of Ichor in the Nether are made of Blood from Tinker's Construct instead.
When attempting to place Ichor in the world, WAILA shows it as Blood from Tinker's Construct, and picking it up with a bucket gives a Bucket o' Blood.
However, while placing a Bucket o' Blood in the Nether causes it to evaporate like water (as it's presumably supposed to), placing Ichor in the Nether does not evaporate, even though it's supposedly also Blood?
Also, not sure if this is related, but buckets of Ichor do not exist in JEI or the creative inventory; only the square fluid texture can be found. Using tab-autocomplete for the /give command doesn't show any Ichor Buckets either.
The attached log has me loading a fresh world, going to the Nether, finding what should be a pool of Ichor (only it's blood), messing around with it, and spawning in what should be actual Ichor (only it places as Blood).
latest.log
Edit: Upon further experimentation, it seems Ichor also cannot be placed in any kind of tank (Open Blocks, EnderIO, etc.).

This issue has been fixed in the latest version.


style: Fix undefined variables (F821), etc.

Fixes all undefined variables violation of PEP8
F821. Also modified to fix other linting issues.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (960cfc0) 88.70% compared to head (e027fff) 88.80%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@               Coverage Diff               @@
##           update_pep8      #37      +/-   ##
===============================================
+ Coverage        88.70%   88.80%   +0.10%
===============================================
  Files               36       36
  Lines             1885     1903      +18
===============================================
+ Hits              1672     1690      +18
  Misses             213      213

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


update samples metadata with new names and descriptions

Fixes
https://issues.redhat.com/browse/DEVHAS-239
Description
Updates the samples to override names and descriptions. Also filters the .Net sample out.
Type of change

[ ] Feature
[x] Bugfix
[ ] Code style update (formatting, renaming)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] Documentation content changes
[ ] Other (please describe):

Screen shots / Gifs for design review

How to test or reproduce?
View samples catalog.
Browser conformance:

[x] Chrome
[ ] Firefox
[ ] Safari
[ ] Edge

/lgtm

/retest

/retest

/retest

/lgtm


Fix security groups and remove unused resources

Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement
Learn more about why HashiCorp requires a CLA and what the CLA includes
Have you signed the CLA already but the status is still pending? Recheck it.


Allow running the acceptance tests in pulumi/examples as part of the test suite

This change adds a new optional flag testPulumiExamples that can be set in .ci-mgmt.yaml. When set, the acceptance tests in pulumi/examples will be run as part of the test suite.
The goal is to increase test coverage in provider PRs or releases. pulumi/examples has a rich set of realistic programs that can be used for this via ProgramTest.
Providers don't necessarily need to gate PRs on these tests, they can be informational only.
This requires that the provider's test suite in examples/ is enabled for this. See pulumi/pulumi-azure#1717 for an example. It's not enough to just run the test suite in pulumi/examples because we want to use or inject the locally built provider and SDKs of the current PR.
I chose the approach using the test job's matrix because the new pulumi/examples tests should run concurrently to the regular ones, but to run them in a separate job would require copying the lengthy setup steps of the test job, or extracting the setup into a composite action which I thought could be avoided.
TODO: rename 'true' and 'false' to something more expressive, they're only used as strings anyway

I'm not particularly good at GH Actions, so it would be really helpful to see a demo run of this change.

The p-azure PR I linked, pulumi/pulumi-azure#1717, is the demo! Specifically, you can see the new test job [test (nodejs, pulumiExamples)](https://github.com/pulumi/pulumi-azure/actions/runs/7913493113/job/21601801140?pr=1717) running the p/examples tests for the azure-classic examples.
It also demonstrates part of the value - some examples are failing because the examples are outdated. It could also go the other way round: a provider change breaks a previously working example.

It looks like we want to take this change on PRs (run-acceptance-tests) but not master, release or cron. Is that the plan?

I hope we can run these tests for each PR, but we don't need to decide just yet. Running them on releases could also be valuable. Either way, we won't make their success required just yet, as the p-azure example shows.

I'm not particularly good at GH Actions, so it would be really helpful to see a demo run of this change.

The p-azure PR I linked, pulumi/pulumi-azure#1717, is the demo! Specifically, you can see the new test job [test (nodejs, pulumiExamples)](https://github.com/pulumi/pulumi-azure/actions/runs/7913493113/job/21601801140?pr=1717) running the p/examples tests for the azure-classic examples.

Great. That looks good.

It also demonstrates part of the value - some examples are failing because the examples are outdated. It could also go the other way round: a provider change breaks a previously working example.

It looks like we want to take this change on PRs (run-acceptance-tests) but not master, release or cron. Is that the plan?

I hope we can run these tests for each PR, but we don't need to decide just yet. Running them on releases could also be valuable. Either way, we won't make their success required just yet, as the p-azure example shows.

I'm trying to get at the purpose of the new tests here. If we run them only in PRs (run-acceptance-tests), then they will be ignored. Engineers have no way to verify if they broke the tests or if tests were already broken on master.
I generally believe that 90% of the use of tests here is gating, and if tests are allowed to be broken then they loose that ability. I'd rather that they run on PRs and master, and that they do block PRs. If the tests are sufficiently flakey that it is unsafe to block on, I'm skeptical they provide enough signal to make them worth running.

I'm not sure I agree, this sounds to me like an argument that says "we can't make the gating workflow ideal so we'll continue willfully shipping changes that break examples." Having examples evergreen (or almost) does not sound like something we should give up on already? If examples are evergreen, then a PR failing this check is an indication the PR has a problem, which is what we want.

If we have to enforce.. I would argue it'd be much more customer-centric to open P1s for when examples are broken than to open P1s for when CI workflows are broken as is our current practice.

Actually to take the step back, I'd like to ask if we can link Thomas' design doc and epic/unit of work here? I was under the impression that running these tests was what was agreed on in the multiple-round reviewed design doc, am I perhaps misremembering or there's some new information to reconsider?

Great points, @iwahbe and @t0yv0. The design doc is Test Coverage and Maintenance of Examples but it's Pulumi-internal.
We had indeed agreed to run these tests in order to increase test coverage, but there are still variables as to when and how we run them.
Ideally, as Ian said, we'd like to have an additional gate, at PR or release time, that prevents us from shipping regressions. Before adding the pulumi/examples tests in this way, however, we need to consider that this repo belongs to another team and gets new commits from all over Pulumi. If one of these is faulty - although theoretically that should be prevented by pulumi/example's own test suites - the provider gating its PRs on these examples is blocked from merging.
Some ways around this:

Fail the PR/release, and when investigation shows that p/examples is at fault, manually override the branch protection. However, not long ago we actually removed the manual overrides for increased safety.
Don't run the tests against the HEAD of pulumi/examples but a fixed version. That solves this problem but requires regular updates of the dependency or we'll test against old examples soon.
Don't require the pulumi/examples tests to pass, just have developers look at them before merging. As Ian pointed out, they might ignore the tests. It also doesn't compose with auto-merge.

Don't require the pulumi/examples tests to pass, just have developers look at them before merging

I thought this was the agreement and I still support this option, that's the only viable option IMO.

@thomas11 Let's get the tests in as advisory. We can always increase the impact of the tests once they are in place, and I don't want this work to bitrot while we discuss.

Sounds good, thanks! I just rebased it removed the last TODO. I need you or @t0yv0 to stamp it, though.


Support to update firewalls for workspace

@jerrychenhf Have modified the code to update the rules of firewalls without deleting action.

Looks good to me! Thanks for the code!


Add map name and uuid in save map service response

This PR adds the map name and uuid to the SaveMap service response.
Fixes #223.

LGTM!


feat: enhance multi pdf file upload

Implement new design for multi pdf upload, in previous branches related to upload we didn't know how it should look like

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

cursor is not pointer when I put it on it

 cursor is not pointer when I put it on it

also when you disable it, the cursor should be not-allowed

$disabled prop is not set so the cursor is still not okay

also can you add this margin only when there are files uploaded? (or use flex+gap or something similar)


Telemetry fixes

Fixing three issues

TACO hangs on VS dev comand prompts
Response to telemetry prompt is printed twice on Mac
Machine ID never read from the registry on Mac

All comments have been addressed.

looks good to me


Make S3 bucket public

We'll need to do this in order to serve assets directly from S3.

I think this is simply a matter of changing the acl argument on the bucket from "private" to "public-read". See the documentation for Terraform's aws_s3_bucket resource and S3 canned ACLs.

See https://github.com/alphagov/govuk-terraform-provisioning/pull/128.

We've made and merged the necessary change in https://github.com/alphagov/govuk-terraform-provisioning/pull/130. We're currently waiting for this change to be deployed to integration.

The changes in https://github.com/alphagov/govuk-terraform-provisioning/pull/130 have now been deployed to integration.
I've tested that the change is working as expected by uploading an attachment to a Manual Section (in Manuals Publisher) and requesting the uploaded asset with the redirect_to_s3=true querystring.

Based on @chrisroos' last comment, I'm closing this issue. @chrisroos: Please re-open if you think we've missed anything.


Is it possible to use namespaced functions in chain!()?

When using chain!(), using space works, but not nom::space: error: no rules expected the token ::``.
Would it be possible to support this, or is this impossible/too complicated with the current macro system and the way chain!() is built?  It would be nice to not have to use all functions to use in chain.
This is mostly a question of whether this is currently possible, it isn't really needed if it isn't possible.

Nevermind, found call!(), allows for exactly this!


Add erlang types to compiled record definitions

Dear Bashoers,
We have noticed that there is a lot of dialyzer related work going on in your codebase  at the moment. Cool.
To aid dialyzer we would very much like the type information that is present in .proto message definitions to transition over to the erlang world as erlang types.
I imagine the easiest place to start would be to make the types available in the protocol buffer record definitions.
Is this on your radar? We would rather avoid duplicating your work if this is something you are already working on. If it is not something you are working on, is this something you would like a pull request on?
Thanks!

+1

Currently the dilayzer warnings coming from .erl files generated by protoc are isolated and ignored (in the sense that they don't cause make dialyzer to fail). This is done by listing them in https://github.com/basho/riak_pb/blob/develop/dialyzer.ignore-warnings, in conjunction with some sed work in tools.mk.
In absence of this trick -- and supposing for a moment that all of riak code is dialyzer clean without exception or a need thereof -- the problem of missing specs and exported types in the protoc-generated files would indeed be more visible. As things stand, however, it seems to be just adequate enough a solution for now.

Hello @sebastian -

If it is not something you are working on, is this something you would like a pull request on?

This project is basically in maintenance mode. I am going through issues and PRs and merging those that have low impact to the code, while closing issues that are stale.
We will gladly accept a PR with tests for this feature, but do not plan on implementing it at this time. If a PR is provided, please reference this issue and re-open it. Thanks!


ASVs import method seems to create invalid import rings

I am not sure this is an ASV bug or can be avoided, but adding import numpy.distutils.cpuinfo to numpy/testing/nosetester.py broke the automatic tests as below, it seems that for some reason the wrong commands is imported (not global but ASV) upon doing that import.
Anyway, I will just move the warnings stuff elsewhere and be done with it, just to note.
+python /home/travis/build/numpy/numpy/builds/venv/bin/asv dev
· Discovering benchmarks
·· Error running /home/travis/build/numpy/numpy/builds/venv/bin/python /home/travis/build/numpy/numpy/builds/venv/lib/python2.7/site-packages/asv/benchmark.py discover benchmarks /tmp/tmpGBvoqo
             STDOUT -------->

             STDERR -------->
             Traceback (most recent call last):
               File "/home/travis/build/numpy/numpy/builds/venv/lib/python2.7/site-packages/asv/benchmark.py", line 658, in <module>
                 list_benchmarks(benchmark_dir, fp)
               File "/home/travis/build/numpy/numpy/builds/venv/lib/python2.7/site-packages/asv/benchmark.py", line 639, in list_benchmarks
                 for benchmark in disc_benchmarks(root):
               File "/home/travis/build/numpy/numpy/builds/venv/lib/python2.7/site-packages/asv/benchmark.py", line 624, in disc_benchmarks
                 for module in disc_files(root, os.path.basename(root) + '.'):
               File "/home/travis/build/numpy/numpy/builds/venv/lib/python2.7/site-packages/asv/benchmark.py", line 613, in disc_files
                 module = import_module(package + filename)
               File "/opt/python/2.7.9/lib/python2.7/importlib/__init__.py", line 37, in import_module
                 __import__(name)
               File "benchmarks/__init__.py", line 3, in <module>
                 from . import common
               File "benchmarks/common.py", line 3, in <module>
                 import numpy
               File "/home/travis/build/numpy/numpy/builds/venv/lib/python2.7/site-packages/numpy/__init__.py", line 180, in <module>
                 from . import add_newdocs
               File "/home/travis/build/numpy/numpy/builds/venv/lib/python2.7/site-packages/numpy/add_newdocs.py", line 13, in <module>
                 from numpy.lib import add_newdoc
               File "/home/travis/build/numpy/numpy/builds/venv/lib/python2.7/site-packages/numpy/lib/__init__.py", line 8, in <module>
                 from .type_check import *
               File "/home/travis/build/numpy/numpy/builds/venv/lib/python2.7/site-packages/numpy/lib/type_check.py", line 11, in <module>
                 import numpy.core.numeric as _nx
               File "/home/travis/build/numpy/numpy/builds/venv/lib/python2.7/site-packages/numpy/core/__init__.py", line 58, in <module>
                 from numpy.testing.nosetester import _numpy_tester
               File "/home/travis/build/numpy/numpy/builds/venv/lib/python2.7/site-packages/numpy/testing/__init__.py", line 13, in <module>
                 from .nosetester import run_module_suite, NoseTester as Tester
               File "/home/travis/build/numpy/numpy/builds/venv/lib/python2.7/site-packages/numpy/testing/nosetester.py", line 14, in <module>
                 import numpy.distutils.cpuinfo
               File "/home/travis/build/numpy/numpy/builds/venv/lib/python2.7/site-packages/numpy/distutils/cpuinfo.py", line 25, in <module>
                 from commands import getstatusoutput
               File "/home/travis/build/numpy/numpy/builds/venv/lib/python2.7/site-packages/asv/commands/__init__.py", line 12, in <module>
                 from .. import config
             ValueError: Attempted relative import beyond toplevel package
Traceback (most recent call last):
  File "/home/travis/build/numpy/numpy/builds/venv/bin/asv", line 9, in <module>
    load_entry_point('asv==0.1.1', 'console_scripts', 'asv')()
  File "/home/travis/build/numpy/numpy/builds/venv/lib/python2.7/site-packages/asv/main.py", line 36, in main
    result = args.func(args)
  File "/home/travis/build/numpy/numpy/builds/venv/lib/python2.7/site-packages/asv/commands/__init__.py", line 47, in run_from_args
    return cls.run_from_conf_args(conf, args)
  File "/home/travis/build/numpy/numpy/builds/venv/lib/python2.7/site-packages/asv/commands/dev.py", line 31, in run_from_conf_args
    return cls.run(conf, bench=args.bench, machine=args.machine, python=args.python)
  File "/home/travis/build/numpy/numpy/builds/venv/lib/python2.7/site-packages/asv/commands/dev.py", line 37, in run
    _machine_file=_machine_file)
  File "/home/travis/build/numpy/numpy/builds/venv/lib/python2.7/site-packages/asv/commands/run.py", line 197, in run
    benchmarks = Benchmarks(conf, regex=bench)
  File "/home/travis/build/numpy/numpy/builds/venv/lib/python2.7/site-packages/asv/benchmarks.py", line 285, in __init__
    for benchmark in benchmarks:
  File "/home/travis/build/numpy/numpy/builds/venv/lib/python2.7/site-packages/asv/benchmarks.py", line 325, in disc_benchmarks
    dots=False)
  File "/home/travis/build/numpy/numpy/builds/venv/lib/python2.7/site-packages/asv/environment.py", line 429, in run
    self._executable] + args, **kwargs)
  File "/home/travis/build/numpy/numpy/builds/venv/lib/python2.7/site-packages/asv/util.py", line 431, in check_output
    raise ProcessError(args, retcode, stdout, stderr)
asv.util.ProcessError: Command '/home/travis/build/numpy/numpy/builds/venv/bin/python /home/travis/build/numpy/numpy/builds/venv/lib/python2.7/site-packages/asv/benchmark.py discover benchmarks /tmp/tmpGBvoqo' returned non-zero exit status 1

asv version?
there used to be a bug like this, but it should be fixed in master

dup of gh-275 probably

Sorry, yes I am sure it is.


Update maven plugins. Fix javadoc error in BorderWrapper.

h1 tags are not allowed in javadoc causing the maven build to fail so changed to h2 in BorderWarpper
Update some maven plugin dependencies

This was quit some time ago, can it please be merged so that the project builds properly from maven when using jdk 11 or later?

Done :) Sorry for being so late :)


DPL-188 - Simplified Heron Request Graph (C=M, V=4)

User story
As a developer I would like to simplify the heron request graph in order to reduce the number of edge-cases in the Heron pipeline. (Note: This story also has limber requirements)

Heron submissions should build just the limber_heron request type (or possibly a V2 flavour?) [Edit: Yep, a V2 request type would make a seamless transition far easier]
This request type should now be flagged as for_multiplexing
This request should cover the entire library creation pipeline in limber
No longer create the final tube up-front (Will require a new tube purpose)
Remove the charge and pass step form the pool plate
Instead should charge and pass at end of pipeline and build sequencing requests then.

This change:

Avoids the need to explicitly know which RT plates will be processed together when building submissions
Removed the pain points where you can't easily jump back to a previous step
Avoids the need to 'charge and pass' before you get the QC data on the XP tube

Edit:
Note: Complexity high due to uncertainty. The actual core changes are fairly simple, and we may get lucky. But I'm anticipating a number of unknowns.
Who are the primary contacts for this story
James
Acceptance criteria

[x] Update LucidChart doc
[ ] Update Confluence "Limber mistakes" page
[ ] Communicate changes to Heron leads

I've created pull requests in Limber, SS and Integration Suite for this.
To remember: old submission templates will need updating to be marked as superseded by the new ones.
Have not yet updated the documentation or communicated anything to the Heron lab team.

Script for updating submission templates:
old_template = SubmissionTemplate.find_by(name: 'Limber - Heron LTHR - Automated')
new_template = SubmissionTemplate.find_by(name: 'Limber - Heron LTHR V2 - Automated')
raise "Can't find the relevant submission templates" unless old_template && new_template

old_template.update!(superceded_at: Time.zone.now, superceded_by: new_template)

Queries for after release - for checking whether there are still in-progress limber_heron_lthr requests, and therefore whether we can delete the old pipelines.
SELECT count(r.id), state
FROM requests r
JOIN request_types rt ON rt.id = r.request_type_id
WHERE rt.key = 'limber_heron_lthr'
GROUP BY state;

SELECT count(r.id)
FROM requests r
JOIN request_types rt ON rt.id = r.request_type_id
WHERE rt.key = 'limber_heron_lthr'
  AND r.state IN ('pending', 'started');


Fake hang on first install

Observed behavior
On first install the make appears to hang, but apparently is waiting for the answer to a prompt.
Steps to reproduce

Clone Doom
Copy init.example.el to init.el
Run make install
See this:

Installation completes after you press y<CR>.  The prompt to continue had scrolled off the screen.

System information

Click to expand
DOOM Doctor
Running Emacs v27.0.50, commit 5dacbb7cb1c6ac246a9ccd15e6c4290def67757c

shell: /bin/zsh
Compiled with:
  RSVG IMAGEMAGICK NOTIFY ACL GNUTLS LIBXML2 ZLIB TOOLKIT_SCROLL_BARS NS
  MODULES THREADS CANNOT_DUMP LCMS2
uname -a:
  Darwin crealab.local 17.7.0 Darwin Kernel Version 17.7.0: Thu Jun 21
  22:53:14 PDT 2018; root:xnu-4570.71.2~1/RELEASE_X86_64 x86_64 i386
  MacBookPro12,1 Darwin

Attempt to load DOOM: success! Loaded v2.0.9
Revision 5dacbb7cb1c6ac246a9ccd15e6c4290def67757c

Please switch to the develop branch. It is currently 3300+ commits ahead (I'm working on a big merge). This and many other issues have been fixed there.
Note that the install instructions have changed slightly. The README on the develop branch reflects this. Private configuration has been moved to ~/.doom.d (or ~/.config/doom, whichever it detects first).
We also have a Discord, if you need any more help.

Oh my, it has changed a lot!  :-)
I’ll check it out.  Thanks for the super quick response.
Keep up the good work.

On Sep 27, 2018, at 4:42 PM, Henrik Lissner<EMAIL_ADDRESS>wrote:
Please switch to the develop branch. It is currently 3300+ commits ahead (I'm working on a big merge). This and many other issues have been fixed there.
Note that the install instructions have changed slightly. The README on the develop branch https://github.com/hlissner/doom-emacs/tree/develop#quick-start reflects this. Private configuration has been moved to ~/.doom.d (or ~/.config/doom, whichever it detects first).
We also have a Discord https://discord.gg/bcZ6P3y, if you need any more help.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub https://github.com/hlissner/doom-emacs/issues/913#issuecomment-425235420, or mute the thread https://github.com/notifications/unsubscribe-auth/AABF03u3ZNCAINJnjfKUF_57hrfHVsZrks5ufTgqgaJpZM4W9apm.


Ensure even pending requests across servers

@thrawn01 you do not need to configure weighted, WRR is being used behind the scenes for loadBalancer. This is actually the change that I needed to port from v3 branch. In v2 branch RoundRobin load balancer from vulcand/oxy is used when loadBalancer is configured, whereas in v3 it is WRR.


Clientset code generation may be needed to refactor ingress and egress fuctions in openshift.go

The ingress and egress fuctions in openshift.go is using client.Client to access the runtime objects configv1.Ingress and configv1.network. We are unable to refactor them to use kubeclient or dynamic client.
Shall we generate the clientset code for the resources under
https://github.com/openshift/api/tree/master/config/v1

in order to get rid of the usage of client.Client in controller-runtime?
We need a folder for github.com/openshift/api like this.
@bbrowning @jcrossley3 @k4leung4 @greghaynes @trshafer  Thoughts?

We do not need it any longer, since I have figured out the way to refactor everything at https://github.com/knative/serving-operator/pull/146


vimgo cli script -p broken

For some reason the -p option does not work at all.
The $OPTARG will not pass into that ARG like very other one.

Fixed assessment order.
https://github.com/TheFynx/docker-vimgo/blob/master/install.sh#L27


the newsfeed url should point to a feed visualisation, not the url of the news itself

URL
No response
On what type of device(s) did you see this bug?
No response
On which operating system(s) are you seeing the problem?
No response
Other OS
No response
On which browser(s) are you seeing the problem?
No response
Other Browser
No response
Summary
The link pointed in this image will use the url of the newsfeed itself.

This will not let user read the whole feed entry and redirect to a strange url. The QGIS for peace URL redirects to the code of conduct page for instance.
my suggestion would be :

in feed.qgis.org, offer an url endpoint to visualize one entry
in qgis.org, redirect to this page
also add a small link "all news" redirecting to feed.qgis.org homepage

@timlinux @Xpirix @anitagraser any opinion here ?

I agree with this. For now, the link to the feed from the main website is not easy to find. I think it would be useful to add the "All news" link to the navigation bar (inside the "Project" menu, for example).
For the details page for each entry, I'm thinking about the same design as in the feed form. It will show either when clicking on the link on the news bar for qgis.org or from the feed list on feed.qgis.org:

We are working on the separated Hub, Planet, from the Plugins with a branding update to match the current QGIS.org. Perhaps we should also add the new links once migrated. What do you think?

We are working on the separated Hub, Planet, from the Plugins with a branding update to match the current QGIS.org. Perhaps we should also add the new links once migrated. What do you think?

we also have our venerable blog.qgis.org hosted on WordPress that partially overlaps newsfeed. I would vote in favor of using Hugo native blogging capabilities, only once the CI will be able to publish on merge. This would imply a content migration too.


Explicitly require gems scheduled for removal from ruby stdlib

Helps to avoid a warning:
nkf was loaded from the standard library, but will no longer be part of the default gems since Ruby 3.4.0. Add nkf to your Gemfile or gemspec

appearing in ruby 3.3

@misdoro Thank you for submitting this! Can you make the nfk dependency conditional to address the JRuby errors?

mutex_m is no longer used -- removed in #629
nkf can't be explicitly required right now without breaking jruby. i'm going to close this, and we can revisit it when there's a solution for jruby.


Create alle.gather-package-files

Should take 2 options:

packageDir
options
Some options are:

ignorePatterns array of RegExp.  Default value is ['./node_modules', '__tests__', '.*.test.jsx?']
matchPatterns array of RegExp.  Default value is ['.*\\.jsx?']

The return value is an array of file paths (strings).

Not needed now that alle isn't going to scan package files.


fix for ChatGPT is at capacity.

Verify latest release

[X] I verified that the issue exists in the latest chatgpt release

Verify webapp is working

[X] I verify that the ChatGPT webapp is working properly for this account.

Verify resrictions

[X] I verify that I've double-checked all of the restrictions.

Environment details
N/A
Link to the code that reproduces this issue
n/A
Describe the Bug
When ChatGPT is at its capacity, instead of throwing an error, have you considered refreshing the page until you get the login page? It is somewhat annoying when it shows the capacity message and the application stop working.
To Reproduce
Run any demo file.
Expected Behavior
async function checkForChatGPTAtCapacity(page: Page) {
  // console.log('checkForChatGPTAtCapacity', page.url())
  // let res: any[]
  //
  // try {
  //   res = await page.$x("//div[contains(., 'ChatGPT is at capacity')]")
  // console.log('capacity1', els)
  // if (els?.length) {
  //   res = await Promise.all(
   //     els.map((a) => a.evaluate((el) => el.textContent))
  //   )
   //   console.log('capacity2', res)
   // }
  // } catch (err) {
  // ignore errors likely due to navigation
  // }
  //
  // if (res?.length) {
  //   const error = new types.ChatGPTError('ChatGPT is at capacity')
  //   error.statusCode = 503
  //   throw error
  // }
  await delay(3000)
  let extractedText = await page.$eval('*', (el: any) => el.innerText)
  console.log(extractedText.includes('ChatGPT is at capacity right now'))

  while (extractedText.includes('ChatGPT is at capacity right now')) {
    await page.goto('https://chat.openai.com/auth/login')
    await delay(3000)
    extractedText = await page.$eval('*', (el: any) => el.innerText)
    if (!extractedText.includes('ChatGPT is at capacity right now')) {
      break
    }
  }
}

Thanks @anishniroula1; I just added support for similar retry logic in https://github.com/transitive-bullshit/chatgpt-api/releases/tag/v3.1.0
Let me know how that works for you.


geomyidae: init at 0.34

Motivation for this change
This adds a simple gopher daemon.
I registered myself as maintainer
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[X] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[X] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[X] Fits CONTRIBUTING.md.

I accidentally deleted the branch on my fork which closed the PR.

Result of nixpkgs-review pr 98851 run on x86_64-linux 1

1 package failed to build:

geomyidae

builder for '/nix/store/1xka1qyqm5zgirfqb6i0l5mndmwyfysd-geomyidae.drv' failed with exit code 1; last 10 log lines:                                                                            * [new tag]         v0.30      -> v0.30                                                                                * [new tag]         v0.31      -> v0.31
   * [new tag]         v0.31.1    -> v0.31.1
   * [new tag]         v0.32      -> v0.32
   * [new tag]         v0.32.1    -> v0.32.1
   * [new tag]         v0.32.2    -> v0.32.2
   * [new tag]         v0.33      -> v0.33
   * [new tag]         v0.34      -> v0.34
  fatal: empty string is not a valid pathspec. please use . instead if you meant to match all paths
  Unable to checkout refs/tags/0.34 from git://bitreich.org/geomyidae.
cannot build derivation '/nix/store/932ncp9i66lna9dr1fd0abr44q4gmvmy-geomyidae-0.34.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/ra3vkksfcnsm83rwzb3pr2y5zmhq09cc-env.drv': 1 dependencies couldn't be built


Task 204 improvement

Here is one comment that we got from cloud annotators:

Need definitions of genres because I don't know what they all mean. What's slate and oup?

I think the worker is right; the definition for some of these niche categories is not quite clear.

@aarunku5 wondering if you can help with addressing issue?

@yeganehkordi 's comment on this task:

In task 204, based on the paper, genres refer to the source of collecting the premises. I don't think if the classification of the sentences based on the genres is practical. For example, two-sided, telephone conversations that took place in 1990 or 1991 (TELEPHONE) and Collection of two-sided, in-person conversations that took place in the early 2000s (FACE-TO-FACE) are hard to distinguish.

Also, tasks 197 and 198 have the same problem with the genre.

@danyaljj i can take this on!

@RushangKaria checking if there are any updates on this thread?

@danyaljj Will put up the PR tomorrow.


Error in explode.js

While testing this amazing library I found an issue with explode and [matchBy] (https://github.com/ef4/liquid-fire/blob/master/app/transitions/explode.js#L127)
In my templates I've added a data attribute data-post-title.
And my transitions.js looks like this
  this.transition(
    this.fromRoute('posts'),
    this.toRoute('post'),
    this.use('explode', {
      matchBy: 'data-post-title',
      use: 'flyTo'
    }, {
      use: 'toLeft'
    }),
    this.reverse('toRight')
  );

This setup triggers Syntax error, unrecognized expression: [data-post-title=]
I would like to contribute and submit a PR to fix it.
I also think that it could be helpful being able to use classes and ids in addition to data-attributes.

Thanks, please do. It looks like we're probably not doing the right thing if we find an element in the old view that has the attribute present but null.
I agree that matchBy: 'class' and matchBy: 'id' would be good.
We should probably make them work in combination with pick/pickOld/pickNew so that you can use pick (or pickOld and pickNew) to limit the set of stuff that matchBy will search through.
So pick: '.post', matchBy: 'id' would first find everything with class="post" in both the old and new views, and then try to pair them up by ids.
I just pushed a docs update that explains how all of these work as of now: http://ef4.github.io/liquid-fire/#/transitions/explode

Cool. I'll work on that in the next few days.


Output Imgui widgets

Here a list of issues referring to the output option:

#105

Removing CLI option in favor of dedicated Imgui widgets


6.1 says MUST treat this as a connection error

Your test description is right, but the code was looking for a stream
level error
I'm not sure this is even working right. The output still looks like this:
  6.1. DATA
    × Sends a DATA frame with invalid pad length
      - The endpoint MUST treat this as a connection error of type PROTOCOL_ERROR.
        Expected: GOAWAY frame (ErrorCode: PROTOCOL_ERROR)
                  RST_STREAM frame (ErrorCode: PROTOCOL_ERROR)
                  Connection close
          Actual: DATA frame (Length: 16, Flags: 1)

but I think it should look like this:
  6.1. DATA
    × Sends a DATA frame with invalid pad length
      - The endpoint MUST treat this as a connection error of type PROTOCOL_ERROR.
        Expected: GOAWAY frame (ErrorCode: PROTOCOL_ERROR)
                  Connection close
          Actual: DATA frame (Length: 16, Flags: 1)

This is correct.
We have discussed this before. Please see #12.


Smoke Timer

https://user-images.githubusercontent.com/76704816/126461512-68507179-b5ce-4dd5-bca6-4c3fed6e9776.mov

screenshot?

screenshot?

done

cool!

Big thanks! yeah anyway, how to change the background alpha?

Thank You so much! It's helpful!

Big thanks! yeah anyway, how to change the background alpha?

in line
-->       drawList->AddRectFilled(rect_out.Min, rect_out.Max, IM_COL32_WHITE);
replace IM_COL32_WHITE
to remove bg, i made mine like this
-->       drawList->AddRectFilled(rect_out.Min, rect_out.Max, IM_COL32_BLACK_TRANS);

Big thanks! yeah anyway, how to change the background alpha?

in line
--> drawList->AddRectFilled(rect_out.Min, rect_out.Max, IM_COL32_WHITE);
replace IM_COL32_WHITE
to remove bg, i made mine like this
--> drawList->AddRectFilled(rect_out.Min, rect_out.Max, IM_COL32_BLACK_TRANS);

instead of IM_COL32_WHITE u can use IM_COL32(R, G, B, A) to setting color;

Big thanks! yeah anyway, how to change the background alpha?

in line
--> drawList->AddRectFilled(rect_out.Min, rect_out.Max, IM_COL32_WHITE);
replace IM_COL32_WHITE
to remove bg, i made mine like this
--> drawList->AddRectFilled(rect_out.Min, rect_out.Max, IM_COL32_BLACK_TRANS);

instead of IM_COL32_WHITE u can use IM_COL32(R, G, B, A) to setting color;

what about the timer color? black is kinda hard to see

Big thanks! yeah anyway, how to change the background alpha?

in line
--> drawList->AddRectFilled(rect_out.Min, rect_out.Max, IM_COL32_WHITE);
replace IM_COL32_WHITE
to remove bg, i made mine like this
--> drawList->AddRectFilled(rect_out.Min, rect_out.Max, IM_COL32_BLACK_TRANS);

instead of IM_COL32_WHITE u can use IM_COL32(R, G, B, A) to setting color;

what about the timer color? black is kinda hard to see

drawList->AddText({ pos.x - (textSize.x / 2), pos.y - (textSize.y / 2) }, IM_COL32_BLACK, text.str().c_str());
change IM_COL32_BLACK to IM_COL32(R, G, B, A)

Big thanks! yeah anyway, how to change the background alpha?

in line
--> drawList->AddRectFilled(rect_out.Min, rect_out.Max, IM_COL32_WHITE);
replace IM_COL32_WHITE
to remove bg, i made mine like this
--> drawList->AddRectFilled(rect_out.Min, rect_out.Max, IM_COL32_BLACK_TRANS);

instead of IM_COL32_WHITE u can use IM_COL32(R, G, B, A) to setting color;

what about the timer color? black is kinda hard to see

now u can change color in game

Big thanks! yeah anyway, how to change the background alpha?

in line
--> drawList->AddRectFilled(rect_out.Min, rect_out.Max, IM_COL32_WHITE);
replace IM_COL32_WHITE
to remove bg, i made mine like this
--> drawList->AddRectFilled(rect_out.Min, rect_out.Max, IM_COL32_BLACK_TRANS);

instead of IM_COL32_WHITE u can use IM_COL32(R, G, B, A) to setting color;

what about the timer color? black is kinda hard to see

now u can change color in game

big thanks!

damn that's really good work, well done

Bro can you help me?
I can't open cheat menu in game, do you know any fix for that?
If so, please let me know.
Thanks

Please help me i can't close menu in game after i coded smoke timer :(


Discussion: Rename ColumnDataType "Yes/No" to "True/False" or "Boolean?

I have thought about us naming Booleans Yes/No, and I think that it might be a bit misleading, since what this data type actually stores a not the words "Yes" and "No", but True and False.
I personally like "Boolean" the most, since that's what I know this datatype as and this naming is quite commonly used. If we expect Data Administrators to set up the table and column metadata, I would expect these users to know the boolean data type as well.
But, if Boolean is too technical a term, then maybe, we could use True/False, since this is what will be stored in columns with this datatype?
What do you think?

We (@K-Beicher, @lwjohnst86, and I) discussed this at an update meeting. We'll go with True/False


msgpack serialisation : float is treated as 64bit float, not 32bit float.

Example:
vector<float> buf(1024);
nlohmann::json j = {{"buf", buf}};
vector<uint8_t> msgpack = nlohmann::json::to_msgpack(j);
cout << msgpack.size() << endl;

I would expect this to print roughly ~ 5000, instead it is printing ~ 9000.
Going through GDB, it is treating the float type as 64bit.

For CBOR, you apply range checking like so
if (static_cast<double>(j.m_value.number_float) >= static_cast<double>(std::numeric_limits<float>::lowest()) and
                            static_cast<double>(j.m_value.number_float) <= static_cast<double>((std::numeric_limits<float>::max)()) and
                            static_cast<double>(static_cast<float>(j.m_value.number_float)) == static_cast<double>(j.m_value.number_float))
                    {
                        oa->write_character(get_cbor_float_prefix(static_cast<float>(j.m_value.number_float)));
                        write_number(static_cast<float>(j.m_value.number_float));
                    }
                    else
                    {
                        oa->write_character(get_cbor_float_prefix(j.m_value.number_float));
                        write_number(j.m_value.number_float);
                    }

So if your float is in a 32bit float range, cast it to a 32bit float. You don't do that in the  msgpack serialiser. Maybe it could? Or, in :
enum class value_t : std::uint8_t
{
    null,             ///< null value
    object,           ///< object (unordered set of name/value pairs)
    array,            ///< array (ordered collection of values)
    string,           ///< string value
    boolean,          ///< boolean value
    number_integer,   ///< number value (signed integer)
    number_unsigned,  ///< number value (unsigned integer)
    number_float,     ///< number value (floating-point)
    binary,           ///< binary array (ordered collection of bytes)
    discarded         ///< discarded by the parser callback function
};

we separate the number_float enum into 2 separate enums. Options...

Interestingly, i wanted to see if the CBOR serialisation was slower due to bounds checking, and it isn't, it's nearly 3x faster. I used the following code:
vector<float> buf(1024*1024);
    nlohmann::json j = {{"buf", buf}};

    int ntests = 100;
    uint64_t now = get_timestamp_ns();
    for (int i = 0 ; i < ntests ; i++)
        vector<uint8_t> msgpack = nlohmann::json::to_msgpack(j);
    now = get_timestamp_ns() - now;
    cout << "msgpack serialisation in " << now*1e-6/ntests << "ms" << endl;

    now = get_timestamp_ns();
    for (int i = 0 ; i < ntests ; i++)
        vector<uint8_t> cbor = nlohmann::json::to_cbor(j);
    now = get_timestamp_ns() - now;
    cout << "cbor serialisation in " << now*1e-6/ntests << "ms" << endl;

Which outputs
msgpack serialisation in 28.2028ms
cbor serialisation in 11.4229ms

So maybe adding bounds checking isn't going to affect performance...

We only recently added the code to the CBOR serializer to use 32-bit floats where possible. Not using the same approach in MessagePack was an oversight. I think adding this should be possible.

@pfeatherstone Could you please try with 88a37010d6cfa808ddfa9559a15285b8291ad187 whether everything works as expected? In your initial example, I got the output 5128.

Yep all works fine. Thanks for the quick fix

I still need to adjust the test suites, as the change affects existing tests. But then this should be ready for the next release.

marvelous

I would also add the solution proposed by @KonanM in issue 2175 to the next release as it looks oven baked to me.

I'm not sure about the release cycle. My usual approach is to wait until it feels "done". There are several issues that are nearly ready, so I will not rush anything because of this issue.

Cool


Introspection: Remove comments for unsupported fields

model Post {
  id           Int                     @id @default(autoincrement())
  title        String
  content      String?
  published    Boolean                 @default(false)
  authorId     Int?
  /// This type is currently not supported by the Prisma Client.
  polygonField Unsupported("polygon")? @unique
  /// This type is currently not supported by the Prisma Client.
  pointField   Unsupported("point")?
  User         User?                   @relation(fields: [authorId], references: [id])

  @@index([authorId], name: "authorId")
  @@index([polygonField], name: "polygonFieldIndex")
}

should rendered as
model Post {
  id           Int                     @id @default(autoincrement())
  title        String
  content      String?
  published    Boolean                 @default(false)
  authorId     Int?
  polygonField Unsupported("polygon")? @unique
  pointField   Unsupported("point")?
  User         User?                   @relation(fields: [authorId], references: [id])

  @@index([authorId], name: "authorId")
  @@index([polygonField], name: "polygonFieldIndex")
}

Why?

Unsupported already signals the field type is not supported
We can clarify in the documentation that fields of unsupported types are not surface in the client API

This is done.

This is done.


Problem with attribute quoting in ddl generation for h2.

After upgrading to the latest version of Reladomo, I see the new attribute quoting behavior. I'm generating ddl files to disk using the postgres database type, and then I load them into h2 inside tests. I realize this might not be a valid thing to do, but it's always worked in the past and CoreMithraDbDefinitionGenerator#setDatabaseType doesn't have an option for h2. Should it?
The quoting is happening a little differently in ddl files, idx files, and fk files.
In ddl files, the quotes appear escaped with slashes. H2 doesn't seem to like this syntax.
drop table if exists MYTYPE;

create table MYTYPE
(
    \"name\" varchar(256) not null,
    data varchar(100000) not null,
);

In fk files, there's no quoting. H2 is fine with this, at least for the identifier "name".
references MYTYPE(
    name
);

In idx files, there's quoting with no slashes. H2 is fine with this too.
alter table MYTYPE add constraint MYTYPE_PK primary key ("name");

I stepped through AbstractGeneratorDatabaseType a bit and see the places where getColumnNameWithEscapedQuote() and getPlainColumnName() are called, and I'm happy to help with a fix, but I'm not confident I understand the issue.

Let's first start with adding an H2 database type for ddl generation.
We can then review the quoting and ddl generation for H2 and other dbs.

Thanks for the quick response! I think H2GeneratorDatabaseType is basically a copy of PostgresGeneratorDatabaseType but with the override:
    @Override
    protected void generateNullStatement(PrintWriter writer, Attribute[] attributes, String attributeSqlType, int i)
    {
        writer.println("    " + attributes[i].getColumnName() + " " + attributeSqlType +
                (attributes[i].isNullable() ? "" : " not null") + ((i < attributes.length - 1) ? "," : ""));
    }


i can't lunch the docker correctly

when i execute the script : setup_bigdawg_docker.sh in docker i get the following error:
Hit enter to stop it...
Oct 09, 2018 2:43:53 PM org.glassfish.grizzly.http.server.NetworkListener shutdownNow
INFO: Stopped listener bound to [bigdawg-postgres-catalog:8080]
and the rest application doesn't start

Asma,
Which OS are you using?
Vijay
On Tue, Oct 9, 2018 at 11:22 AM Asma Zgolli<EMAIL_ADDRESS>wrote:

when i execute the script : setup_bigdawg_docker.sh in docker i get the
following error:
org.glassfish.grizzly.http.server.NetworkListener shutdownNow
and the rest application doesn't start
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/bigdawg-istc/bigdawg/issues/5, or mute the thread
https://github.com/notifications/unsubscribe-auth/AF0EO98XrahcIOUw6HlXKb3BPC5W3l0Oks5ujL9KgaJpZM4XTiX9
.

--
--vijay

I'm using Mac OS Sierra

Can you make one change to provisions/setup_bigdawg_docker.sh
https://github.com/mmucklo/bigdawg/commit/4139be9aee352436ef36d58b9478bad996087bac#diff-f44841106eee984b06c519507a5e9ab2
Add the flag "-it" to the near final line:
docker exec bigdawg-postgres-catalog java -classpath "
istc.bigdawg-1.0-SNAPSHOT-jar-with-dependencies.jar" istc.bigdawg.Main
bigdawg-postgres-catalog
to make it:
docker exec -it bigdawg-postgres-catalog java -classpath "
istc.bigdawg-1.0-SNAPSHOT-jar-with-dependencies.jar" istc.bigdawg.Main
bigdawg-postgres-catalog
On Tue, Oct 9, 2018 at 11:57 AM Asma Zgolli<EMAIL_ADDRESS>wrote:

I'm using Mac OS Sierra
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/bigdawg-istc/bigdawg/issues/5#issuecomment-428249051,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AF0EO60ZIBKnamV6p8geJ0uVp7WBi4b1ks5ujMdmgaJpZM4XTiX9
.

--
--vijay

It works !! thank you very much!


feat: (IAC-91) Support of Azure DB for PostgreSQL flexible server

Changes

Changes made to support the PostgreSQL flexible server for Azure using the terraform azurerm_postgresql_flexible_server
Default server_version value updated from 11 to 13. Variable postgres_server_defaults adjusted to map version value to 13.
The user can select any version between 11-14 to suite their SAS Viya deployment requirements.

Tests
Ran through the following deployment scenarios to test out PG

Scenario
Provider
K8s Version
PG Version
Order
Cadence
Deployment Stabilized
Notes

PostgreSQL V11
Azure
1.23.8
11.16
*
Fast:2020

TODO

PostgreSQL V12
Azure
1.23.8
12.11
*
Fast:2020
Yes

PostgreSQL V13
Azure
1.23.8
13.7
*
Fast:2020
Yes
New default, did not define server_version in .tfvars

PostgreSQL V14
Azure
1.23.8
14.4
*
Fast:2020

TODO

I ran terraform fmt on the files changed in this PR, which resulted into a lot of formatting updates unrelated to the flexible server change.


Merge editor: I can accept both sides?

Testing #150389

In that case I would have expected 2 lines, similar to VS:

This only works when both edits don't overlap.
There is a bug though that the UI doesn't reflect the new state.
Why is accepting both sides useful in this case?

Not sure the use case, I think it is also fine to only allow one or the other (though then arguably the UI element should be a radio box and not check box).
I guess some users might want to accept both changes to then go into the editor and manually merge it?

I guess some users might want to accept both changes to then go into the editor and manually merge it?

You can always copy it directly from input1/input2.

though then arguably the UI element should be a radio box and not check box

That's not such a bad idea actually.
In many cases both sides can be accepted though (especially when both sides are just insertions).

I think accepting both sides is useful. The most obvious use case for that would be new imports on the same line (you'd probably want both).

I think accepting both sides is useful. The most obvious use case for that would be new imports (or any additions really) on the same line - you'd probably want both.

This is supported. It is just not supported if both sides modify the same line in a conflicting way.

The described behavior is how it is expected to work. If you disagree, please explain what is expected and what is not in more detail. See also our issue reporting guidelines.
Happy Coding!

This should work now. This was a bug.


Added missing code

The example was not working at all. There was a lot of code missing in order to make it work. Especially the import statements as well as methods in the java classes. You further used RCTImageView which is areserved keyword from react-native. The example was very hard to follow. It shoud be easier now.

Had to revert this, in favor of https://github.com/facebook/react-native-website/pull/464


Use correct primary when selecting variables

This patch makes us use the correct primary number when selecting variable occurrences instead of using always 0.

Merged as bc026f1 and updated in 9e375f1


Chore: update precommit hooks to check working branch against content of KES

Warn if kes.user.js references a branch other than the current (main != testing, and vice versa)
Additional exclusions for patch branches

Resolved by 85060d43fdc7f12a02d6e9a04c1248dedfbff9ee


Set Config as env vars and fix weird party with weird people bug

This PR makes the use of env vars the default for rooms config.
Only step needed is to create a ROOMS_DATA var in heroku following this structure:
[
{
	"id":"room-1",
	"name":"Hall",
	"disableMeeting": true
},
{
	"id":"some-uuid",
	"name":"Café"
}
(.....more rooms here....)
]

Also, by coincidence just a few hours ago a fix to our todays problem was merged (https://github.com/ResultadosDigitais/matrix/pull/148)  to the main repository, by concatenating hostname to roomId when creating a call, and its being pushed here as well.

Cool! I've added you to Heroku to manage that.


No plugins found! - again

Hi all,
as far as I can see, the compiling process works without errors (DebianBuster).
However when I do "make install", only some librarys are copied to the target location:
Install the project...
-- Install configuration: ""
-- Up-to-date: /usr/local/include/ebur128.h
-- Installing: /usr/local/lib/libebur128.so.1.2.4
-- Up-to-date: /usr/local/lib/libebur128.so.1
-- Up-to-date: /usr/local/lib/libebur128.so
-- Up-to-date: /usr/local/lib/libebur128.a
-- Up-to-date: /usr/local/lib/pkgconfig/libebur128.pc
I then manually copied the loudness executable to /usr/local/bin: "No plugins found!"
ldconfig
I figured out that I have to copy all the libs to /usr/local/bin and then call loudness with the full installation path. Then it works, as expected.
This might be a workaround for me, although it's not that nice.
Does anyone have a hint for me how to fix this behavior?
Regards
Claus

I think, I solved the problem:

added "/usr/local/lib" to /etc/ld.so.conf.d/x86_64-linux-gnu.conf
copy all *.a and *.so from build to to /usr/local/lib
run ldconfig


fix spelling errors, and other misc errors.

Just went through and fixed some misc errors.

Never PR master
Docs are generated from code


Supabase CLI ignores --workdir flag for init command

Describe the bug
The init command should respect the --workdir flag and create the files in the current directory, i.e. awesome-project, but instead it creates a subdirectory called supabase which is specifically opposite of what the intention was.
To Reproduce
Steps to reproduce the behavior:

Make an empty directory
mkdir awesome-project

Change to the newly created directory
cd awesome-project

Initialize supabase
supabase init --workdir "."

Expected behavior
The Supabase CLI should respect the --workdir flag and create the files in the current directory, i.e. awesome-project, but instead it creates a subdirectory called supabase which is specifically opposite of what the intention was.
Desktop (please complete the following information):

OS: Windows 10 22H2
Version of CLI: 1.88.0

This is actually working as intended. The supabase subdirectory contains config.toml and migration files for setting up local dev environment. We cannot support arbitrary names for this path. The workdir flag refers to the project directory which is one level up from the config directory.

@sweatybridge So the Supabase subdirectory is something unavoidable?

AFAIK, yes because we need a predicable name to locate the config files.

@sweatybridge Thanks for the clarification.


Suggestion #133, markup language for bots

In response to #133  and similar requests, here I added simple parameters to change the text displayed by the chat bots.
This will allow the bot programmers more freedom to create even nicer bots.
The following commands are supported:
{font size="8" face="verdana" color="#AA0000"}A big red text{/font}
{mark}Marked{/mark}
{del}Deleted{/del}
{u}Underline{/u}
{i}Italic{/i}
{b}Bold{/b}
{sup}superscript{/sup}
{sub}subscript{/sub}

Working on more features

I added a clickable command where the text is not send immediately, but placed in the inputfield of the chatbox so the user can modify values:
Item2_Offer(offercommand:commandoffered)
added parameters to allow text allignment:
{aligncenter} Center Aligned{/align}
{alignleft} Left aligned {/align}
{alignright} Right aligned {/align}

Could you please move offercommand into a separate PR?  We definitely need it, not so sure about the rest.
I always prefer small focused updates as it is not easy to allocate time to something big.


MM-44763: allow direct dropdown editing again

Summary
We unintentionally required users to enter edit mode for checklist items to be able to change the owner or due dates, but these should have stayed accessible directly:

Ticket Link
Fixes: https://mattermost.atlassian.net/browse/MM-44763

(Going to merge this as I believe it's as required, and cut an updated v1.28. We still have time to pivot as needed.)

Sorry for the delay here @lieut-data. A couple of minor comments for the collapsed assignee chip:

There should be a background-colour (--center-channel-color-08) even in the default(non-hover) state.

There's no margin to the right of the arrow icon. Ideally, there should be about 8px space.

Ideal:

Current:

Thank you for following up, @abhijit-singh! I'm going to take a look at this in https://mattermost.atlassian.net/browse/MM-44899 to make sure we follow up.


Executing autogen.sh fails in Ubuntu 22.04

Trying fresh install in Ubuntu 22.04 by executing autogen.sh which fails with below error.

libbgpstream$ ./autogen.sh
Initializing submodules
Running autoconf
autoreconf: export WARNINGS=
autoreconf: Entering directory '.'
autoreconf: configure.ac: not using Gettext
autoreconf: running: aclocal --force -I m4
configure.ac:65: error: AM_INIT_AUTOMAKE expanded multiple times
/usr/share/aclocal-1.16/init.m4:29: AM_INIT_AUTOMAKE is expanded from...
configure.ac:49: the top level
/usr/share/aclocal-1.16/init.m4:29: AM_INIT_AUTOMAKE is expanded from...
configure.ac:65: the top level
autom4te: error: /usr/bin/m4 failed with exit status: 1
aclocal: error: /usr/bin/autom4te failed with exit status: 1
autoreconf: error: aclocal failed with exit status: 1

Looks like an issue with automake 1.16.5
Similar issues in other opensource projects
<EMAIL_ADDRESS>

This should now be fixed by 2bce0f679c1703ef154588782af250ccd30c012e, which is part of the 2.3.0 release. Let me know if you still have issues with the latest release.


Added KingfisherSource support for Kingfisher (branch:Swift-3)

Added KingfisherSource support for Kingfisher (branch:Swift-3)

Hi @feiin, thanks for the both pull requests! I'll review them and merge asap.


Add support for 'setParameter' service message to TeamCityProvider + …

In working with a legacy build process (converting to Cake), I noticed the absence of a method exposing the setParameter service message in TeamCity.
see: https://confluence.jetbrains.com/display/TCD9/Build+Script+Interaction+with+TeamCity#BuildScriptInteractionwithTeamCity-AddingorChangingaBuildParameter
Given the current implementation of TeamCityProvider (WriteServiceMessage) this was a simple addition that seems like it would be useful to more fully support TeamCity interop.

Hi @kcamp, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!
The agreement was validated by .NET Foundation and real humans are currently evaluating your PR.
TTYL, DNFBOT;

Relates to https://github.com/cake-build/cake/issues/1121

@kcamp thank you for your contribution to Cake.  To save you a job, I have rebased and merged this commit here: https://github.com/cake-build/cake/commit/2951f9daf4417c269b9670f3ec563b864ed2f83e
As a result, I am going to manually close this PR, however, your work has been correctly attributed.


trigger icon cut off on showcase filters

The trigger icon on the showcase page is cut off on the filter

resolved in #128


BLE support

It is not issue but limitation. I have two iConsole Devices. The eliptical is old and exercise bike is new. Eliptical is communication over BT and is working good, but exercise bike cannot be connected (it is not visible in BT list). This is probably (?) problem for many new devices.

As I don't have any such devices, I need someone to provide a patch. Sorry.


sync room when receive room events

Refer to https://github.com/Chatie/wechaty/issues/1552#issuecomment-413745564

Great, thanks!


build: extract all styles into a single stylesheet

Removes style-loader in favor of MiniCssExtractPlugin in order to extract all styles into a single stylesheet that consumers have to import alongside the actual component.

Bump pckg version please.

Hmm... looks like npm run release will do this for us: https://www.npmjs.com/package/standard-version/v/7.0.0


Have Serverpod auto-add custom SQL commands on initial migration

Is your feature request related to a problem? Please describe.
When creating an initial migration (initializing a database), I have to manually run additional SQL commands, to create tables and indexes that Serverpod doesn't yet know how to create (e.g. for Geolocation columns, or to create a partial index -- there are issues for each of these).
Describe the solution you'd like
It would be nice if there was a directory that custom .sql files could be put in, which are merged in with Serverpod's own SQL files when a migration is created.

Great suggestion, we have been discussing this in the team as well and are planning to expand the migrations system with the capability of adding custom SQL commands.

Thanks. The custom commands will have to be run after the Serverpod commands, because a user might have to override something due to lack of Serverpod support.
However, the table diff system is going to have to handle these sorts of manual modifications though, to avoid "the table is not like the protocol definition" type warnings, and migration problems.

I think there might be a need for one pre- and one post- SQL file. Imagine you have a manually managed model and you want to create a relation to it for example. Then the table must exist before the serverpod SQL is executed.

A possible solution is that the Serverpod Migration system generates four additional SQL files pre_database_setup.sql, post_database_setup.sql, pre_migration.sql and post_migration.sql.
The pre/post_database_setup.sql files are utilized if a database is created from scratch. Any SQL code contained in these files would be applied as a single transaction with the definition.sql contents. The pre_database_setup.sql contents would be inlined before the definition.sql contents and the postDatabaseSetup contents would be inlined after.
The pre/post_migration.sql files are utilized when the database is rolled forward. These files live inside of each migration. Any SQL code in these fields would be applied as a single transaction with the migration.sql contents. The pre_migration.sql contents would be inlined before the migration.sql contents and the post_migration.sql contents would be inlined after.
Modules
Special consideration would need to be taken for modules. Any custom commands added to modules would need to be inlined in the correct places as well. And if custom code is supported in modules, module changes would need to always be applied migration by migration in order to catch any custom code.


Lookup fails when DESCRIPTION is missing Author field

Steps to reproduce:

Visit http://api.citeas.org/product/https://github.com/mrc-ide/PlasmoMAPI

This is already fixed by f472475 but I just wanted to say thank you pre-empting my bug report and for all your work on CiteAs!


python310Packages.rpy2: 3.5.3 -> 3.5.4

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for python310Packages.rpy2 is: "Python interface to R"
meta.homepage for python310Packages.rpy2 is: "https://rpy2.github.io/"
meta.changelog for python310Packages.rpy2 is: ""
Updates performed

Ran passthru.UpdateScript

To inspect upstream changes
Impact

Checks done (click to expand)

built on NixOS
The tests defined in passthru.tests, if any, passed
found 3.5.4 with grep in /nix/store/qnmcgdssypiyjwpg84jrr1h44h84bhd0-python3.10-rpy2-3.5.4
found 3.5.4 in filename of file in /nix/store/qnmcgdssypiyjwpg84jrr1h44h84bhd0-python3.10-rpy2-3.5.4

Rebuild report (if merged into master) (click to expand)

4 total rebuild path(s)

4 package rebuild(s)

First fifty rebuilds by attrpath
python310Packages.rpy2
python39Packages.rpy2
sage
sageWithDoc

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/qnmcgdssypiyjwpg84jrr1h44h84bhd0-python3.10-rpy2-3.5.4 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A python310Packages.rpy2 https://github.com/r-ryantm/nixpkgs/archive/411a0f1fb8703af547f1fc478e3c08154e1a1b35.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/qnmcgdssypiyjwpg84jrr1h44h84bhd0-python3.10-rpy2-3.5.4
ls -la /nix/store/qnmcgdssypiyjwpg84jrr1h44h84bhd0-python3.10-rpy2-3.5.4/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

4 packages built:

python310Packages.rpy2
python39Packages.rpy2
sage
sageWithDoc

Maintainer pings
cc @joelmo for testing.

@ofborg build python310Packages.rpy2


async processing via new gutil.File() ?

I'm experiencing some Error: stream.push() after EOF errors when I run my gulp plugin:
        var embedder = new ResourceEmbedder(filepath);

        embedder.get(function (markup) {
            var f = new gutil.File({
                path: path.basename(filepath),
                contents: new Buffer(markup)
            });
            this.push(f);
            cb();
        }.bind(this));

but the codes below run successfully with no error:
        var embedder = new ResourceEmbedder(filepath);

        embedder.get(function (markup) {
            var f = new gutil.File({
                path: path.basename(filepath),
                contents: new Buffer(markup)
            });

            setTimeout(function(){
                this.push(f);
                cb();
            }.bind(this),3000)

        }.bind(this));

so I wonder if new gutil.File() was an async function and how to solve it?
p.s, embedder refer to resource-embedder

This has nothing to do with vinyl, this is a stream bug. Your problem is that your stream is ending before you have finished pushing all the files, use something like through2

hi @contra ,I DO use through2 already, and the gutil.File was just vinyl(here) itself.
btw here`s my whole codes:
'use strict';

var path = require('path');
var gutil = require('gulp-util');
var through2 = require('through2');
var PluginError = gutil.PluginError;
var ResourceEmbedder = require('./lib/resource-embedder');

module.exports = function (options) {
    return through2.obj(function (file, enc, cb) {

        var filepath = file.path;

        //file not exsists
        if (file.isNull()) {
            this.emit('error', new PluginError('gulp-embed', 'File not found: "' + filepath + '"'));
            return cb();
        }

        var embedder = new ResourceEmbedder(filepath);

        embedder.get(function (markup) {
            var f = new gutil.File({
                cwd: '',
                path: path.basename(filepath),
                contents: new Buffer(markup)
            });

            this.push(f);
            cb();
        }.bind(this));

    })
};

it`s weird that sometime it runs successfully but sometime runs with errors as Error: stream.push() after EOF

oh sorry its bug from lib/resource-embedder2 and Ive fixed it


Testing/Benchmarking

There is some future work pending
https://github.com/kubernetes-sigs/kube-network-policies/tree/main/docs/testing#future-work

/cc @therealmitchconnors


[DOCS] pipenv -> poetry

docs/development/getting-started.rst still makes lots of references to pipenv, but we use poetry instead now.

Oops, I just realised this is a dupe of #178, which is a wontfix.


How to use resizing by tap on smartphone or tablet?

I can resize an image by using mouse on PC. But can't do by tap on smartphone or tablet.
Could you tell me how can I enable it?

I also have the same problem


Default stream sort order suboptimal

Data streams as viewed within either a Feed or Pipeline are now sorted with the oldest at the top by default, requiring paging to the end to view the latest streams.
On the positive side, sorting by columns works, but not sure how practical this would be if there were many thousands of streams.

Changed, though the default sort order is still not evident in the UI.  This should be resolved.  New issue opened for this: https://github.com/gchq/stroom/issues/1534


[Bug]: The following routes were marked as prerenderable /manifest.webmanifest

Describe the bug
I cannot run npm run build due to an error with /manifest.webmanifest like this
(!) Some chunks are larger than 500 kB after minification. Consider:
- Using dynamic import() to code-split the application
- Use build.rollupOptions.output.manualChunks to improve chunking: https://rollupjs.org/configuration-options/#output-manualchunks
- Adjust chunk size limit for this warning via build.chunkSizeWarningLimit.
✓ built in 16.13s

node:internal/event_target:1090
  process.nextTick(() => { throw err; });
                           ^
Error: The following routes were marked as prerenderable, but were not prerendered because they were not found while crawling your app:
  - /manifest.webmanifest

See https://kit.svelte.dev/docs/page-options#prerender-troubleshooting for info on how to solve this
    at prerender (file:///Users/alr/devel/alphaess/evidence/node_modules/@sveltejs/kit/src/core/postbuild/prerender.js:495:9)
    at async MessagePort.<anonymous> (file:///Users/alr/devel/alphaess/evidence/node_modules/@sveltejs/kit/src/utils/fork.js:22:16)

Node.js v22.11.0

Build failed

file:///Users/alr/devel/alphaess/evidence/node_modules/@evidence-dev/evidence/cli.js:190
                        throw `Build process exited with code ${code}`;
                        ^
Build process exited with code 1
(Use `node --trace-uncaught ...` to show where the exception was thrown)

Node.js v22.11.0

System Info
System:
    OS: macOS 15.1
    CPU: (10) arm64 Apple M1 Pro
    Memory: 3.50 GB / 32.00 GB
    Shell: 5.9 - /bin/zsh
  Binaries:
    Node: 22.11.0 - ~/.local/state/fnm_multishells/26218_1732055397470/bin/node
    Yarn: 1.22.22 - /opt/homebrew/bin/yarn
    npm: 10.9.0 - ~/.local/state/fnm_multishells/26218_1732055397470/bin/npm
  Browsers:
    Brave Browser: <IP_ADDRESS>
    Chrome: 130.0.6723.92
    Edge: 119.0.2151.72
    Safari: 18.1
  npmPackages:
    @evidence-dev/bigquery: ^2.0.8 => 2.0.8
    @evidence-dev/core-components: ^4.8.3 => 4.8.13
    @evidence-dev/csv: ^1.0.12 => 1.0.13
    @evidence-dev/databricks: ^1.0.7 => 1.0.7
    @evidence-dev/duckdb: ^1.0.11 => 1.0.12
    @evidence-dev/evidence: ^39.1.10 => 39.1.17
    @evidence-dev/motherduck: ^1.0.2 => 1.0.3
    @evidence-dev/mssql: ^1.0.10 => 1.1.1
    @evidence-dev/mysql: ^1.1.3 => 1.1.3
    @evidence-dev/postgres: ^1.0.6 => 1.0.6
    @evidence-dev/snowflake: ^1.1.2 => 1.2.1
    @evidence-dev/sqlite: ^2.0.6 => 2.0.6
    @evidence-dev/trino: ^1.0.8 => 1.0.8

try deleting .evidence
then redo
npm run sources
npm run build

That was it. Thank you so much!


Automated Package Upgrade

:tada: This PR is included in version 25.3.499 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Respect the quiet flag.

When setting the kpod load -q flag, output was still going to the
screen.  This patch adds a check to not output to the terminal unless
there is an io.Writer specified, and then to write to the io.Writer.
Signed-off-by: Daniel J Walsh<EMAIL_ADDRESS>

@umohnani8 @TomSweeneyRedHat PTAL

@rh-atomic-bot r+


Control previous rectangle doesn't show or is mirrored while resizing

Operating system or device, Godot version, GPU Model and driver (if graphics related):
Godot 3.0 master https://github.com/godotengine/godot/commit/4f39ce32b9195405f934445b20059e86632b47f9
Issue description:

It doesn't show if the affected properties are the margin right/bottom.
It's get drawn mirrored (and updates each change) if the affected properties are the margin top/left.
Steps to reproduce:

Add a control
Resize

Definitely reproducible :)


Remove the React app

I added some tweaks, and overall looks great!

optimize script exec using npm-run-all
move babel config -> package.json

Things I need to look further.

Why run collectstatic as part of the watch?


Cloud Experts

Edition Community GAB 2023.
Lima, Peru

@thegameax It's missing the Index.md file. Can you please add that to the PR?
You can check an example here / https://github.com/globalazure/communities/blob/main/2023/azugpt/index.md


Don't raise click after drag and drop (closes #1516)

/cc @helen-dikareva

Tests are failed because there is some problem with the firefox-osx browser opening on BrowserStack. Since the pull-request is simple, it doesn't content any browser-related login and functional tests on AppVeyor are ok I merge this


Lift: Join Observer and Subscription into Subscriber

Tests are working, perf looks good.
This requires review. I hacked my way through Subject and ConnectableObservable. attn @trxcllnt
There is a lot that can be improved, but this is a good starting point.

Actually, perf is so fast, I have my doubts it's doing anything... 16x faster than what's in master? Doesn't seem right.

Oh... another note, I think I completely commented out fromEvent because it needed more refactoring and I didn't reimplement it. This is okay, IMO, because there were no tests for fromEvent anyhow. We should probably set up a seperate issue to add fromEvent with tests. (also fromEventPattern doesn't have tests)

This is an awful lot of commits now because I had to rebase lift from master and my branch from lift

Merging because it's just to the lift branch. Also, it works, where the lift branch does not, yet. I'd really like to get some review on what I've done in the lift branch prior to merging to master though.


lagged response over sshfs

I'm submitting a ...

[x] bug report
[ ] feature request
[ ] support request

Do you want to request a feature or report a bug?
Bug.

What is the current behavior?
Astronomically slow responses.

If the current behavior is a bug, please provide the steps to reproduce and if possible a minimal demo of the problem
Simply sshfs mount, change directories into the mount folder, then try running a command like ls (try it about 2 or 3 times) and it will wait about 60 seconds before replying

What is the expected behavior?
To reply almost instantly or relative to its computation time needed.

Please tell us about your environment:
Arch linux x86 Intel, 16GB RAM, 3.1 Ghz

Plugin Manager: oh-my-zsh
ZSH Version: 5.6.4

Other information (e.g. detailed explanation, stacktraces, related issues, suggestions how to fix, etc)

Fixed details and gave more information

Further investigation lead to the git plugin provided by oh-my-zsh. Closing issue due to it being solved. For anyone else with a similar problem. You may want to disable the git plugin.