Shadow dom

Currently this Web Component isn't shadowed. As I spend several times developing such components recently I'm thinking about migrating this Web Component to a shadowed one.
Reason is also that I noticed yesterday some problems when a none shadowed components would be use in other shadowed components.
Finally, as recently <slot/> have been added, these could become the main way to inject actions icon.
Probably something I could develop when I'll implement it DeckDeckGo https://github.com/deckgo/deckdeckgo-starter/issues/30

@fmendoza @tellibus any thoughts or would that be a problem for you?

@fmendoza I think so, I just read an article about it...which I actually wrote 😂😂😂
https://medium.com/stencil-tricks/a-practical-introduction-to-styling-a-shadow-dom-and-slots-879565a2f423 (chapter "styling slots")
so yep last time I tried out you could style slot from outside, I'll keep that in mind when I'll try to develop this, cool?

What a great post. Crystal.
Go shadow 😎

@fmendoza @abennouna FYI, it has been release in v5.0.0
this Web Component is now shadowed
https://github.com/fluster/web-social-share/releases/tag/v5.0.0


Please Brach to Version with Examples

Currently the project is too heavy for use only with the bower, it would be interesting to have a branch only for examples and leave the master with only the final version to include in the project

Personally, I would prefer the examples to just be placed on the website
like all the others.
On Sun, Sep 20, 2015, 4:09 PM Willian Ribeiro Angelo <
<EMAIL_ADDRESS>wrote:

Currently the project is too heavy for use only with the bower, it would
be interesting to have a branch only for examples and leave the master with
only the final version to include in the project
—
Reply to this email directly or view it on GitHub
https://github.com/formly-js/angular-formly-templates-ionic/issues/30.

Agreed, I need to do something with the example. I like the idea of an examples branch.
@movibe if you're using npm or bower, the examples should ignored via
https://github.com/formly-js/angular-formly-templates-ionic/blob/master/.npmignore
and
https://github.com/formly-js/angular-formly-templates-ionic/blob/master/bower.json#L23
Though there less example, and more just ways for me to test things :grin:
I'll add them to my .gitignore so they just stay with me


Allowed setters and getters to take additional arguments

Closes https://github.com/godotengine/godot-proposals/issues/6750.
Closes https://github.com/godotengine/godot-proposals/issues/3096.
Closes https://github.com/godotengine/godot-proposals/discussions/6107 (discussion).
Closes https://github.com/godotengine/godot/issues/74144.
addresses the following proposals:
https://github.com/godotengine/godot-proposals/issues/2817.
https://github.com/godotengine/godot-proposals/issues/2983.
https://github.com/godotengine/godot-proposals/issues/4867.
https://github.com/godotengine/godot-proposals/issues/4868.
For example, the following is now possible:
@tool
extends Node2D

@onready var sprite := $Icon as Sprite2D
@export var offset : Vector2 : set=set_sprite_property, get=get_sprite_property
@export var centered : bool : set=set_sprite_property, get=get_sprite_property

func get_sprite_property(property : StringName) -> Variant:
	return sprite.get(property)

func set_sprite_property(property : StringName, value : Variant) -> void:
	sprite.set(property, value)

Previously, one would have had to use a more verbose and tedious approach:
@tool
extends Node2D

@onready var sprite := $Icon as Sprite2D
@export var offset : Vector2 : set=set_sprite_offset, get=get_sprite_offset
@export var centered : bool : set=set_sprite_centered, get=get_sprite_centered

func get_sprite_offset() -> Variant:
	return sprite.get("offset")

func set_sprite_offset(value : Variant) -> void:
	sprite.set("offset", value)

func get_sprite_centered() -> Variant:
	return sprite.get("centered")

func set_sprite_property(value : Variant) -> void:
	sprite.set("centered", value)

TODO:

[x] Attach some GDScript tests.
[x] Require that the first argument of a 2-argument setter and a 1-argument getter be a StringName

I noticed the tests complained about "name" shadowing a class variable. I wrote a few lines like Variant name = p_name;. I changed them to Variant property_name = name, so hopefully that fixes the issue.

Thanks for the review @dalexeev :)
I applied your patch and pushed the changes, but I don't think I quite figured out the whole rebasing thing. I tried to squash my commits together and credit you as a coauthor, but got confused somewhere along the way...

I have prepared a squashed commit for you.
squashed-commit.patch.txt
# upstream is godotengine/godot, origin is nlupugla/godot.
git fetch upstream
git checkout set-get-variable-property
git reset --hard upstream/master
git am squashed-commit.patch.txt
rm squashed-commit.patch.txt
git push --force origin

Thanks for preparing the squashed commit! Unless there's a rush to get the PR accepted, I want to see if I can figure out how to do it on my own, just for self-education. If there is a rush, let me know and I'll go ahead and apply the patch :)

Alright, I think I managed to figure out how to squash the commits and credit you. Thanks for the help :)
Just so you know, I haven't had a chance yet to test the changes you made. Should I trust that your changes are good and remove my "draft" status or would you appreciate if I did some testing?

Alright, I think I managed to figure out how to squash the commits and credit you.

No, it doesn't look correct. You just rolled back to your old version and added my tests, but the rest of the changes were discarded (signature analysis, support for optional arguments, etc.). Also, Co-authored-by is incorrect.

Should I trust that your changes are good and remove my "draft" status or would you appreciate if I did some testing?

I ran the tests locally, on my PC they complete successfully. Also I tested manually, looks correct.
Sorry for making the review in the form of an "ultimatum patch", I respect your desire to figure it out on your own. I just want to help you and save time, yours and mine. In any case, I want to say that as a first contribution, your work is already impressive!

Thanks :)
I think I fixed it now.

Yes, it looks correct now. :+1: Except the commit message could be improved. I suggested the following in the patch:
Improve variable setters and getters

* Add support for name argument.
* Allow optional arguments.

You can use something else if you feel like it.
Also, Co-authored-by usually uses the real name if known (not the nickname). But it doesn't matter, GitHub recognized me anyway. :)

Nice. I'm recompiling on my machine just to test things out again. When I'm satisfied, I'll remove my draft status.

I did some brief testing on my end and everything seemed to check out. I removed the draft status from my PR.
I edited my original post so that it mentions being able to have optional arguments in the setters and getters. Should I edit the title of my PR as well, or will that mess something up?

Should I edit the title of my PR as well, or will that mess something up?

You can change the title to something more suitable, it will not change anything except the subject of email notifications.
Also please add this to your post:
Closes godotengine/godot-proposals#6750.
Closes godotengine/godot-proposals#3096.
Closes godotengine/godot-proposals#6107 (discussion).
Closes #74144.
Also this probably resolves or provides an alternative for the following proposals (we can not close them, but just write if/when this PR will be merged):
godotengine/godot-proposals#2817.
godotengine/godot-proposals#2983.
godotengine/godot-proposals#4867.
godotengine/godot-proposals#4868.

No, you need to repeat "Closes".

Looks good to me! There is only a minor suggestion for naming CallError variables. I think this PR is ready for review by the GDScript team.

Awesome :)
So should I name the call errors to err, ce, or call_err?
Also, what are the next steps for updating the documentation on setters/getters to reflect the changes? Should I start writing a PR to update the docs now, or wait until these changes are approved?

So should I name the call errors to err, ce, or call_err?

It seems to me that the name err is worse, since it is usually used for bool or Error codes. For CallError, the names ce, call_err, or the full call_error can be used. But in any case, it has the lowest priority. Things like renaming local/internal variables, fixing comment style, adding/removing blank lines are best done on a case-by-case basis, on adjacent lines, as long as it doesn't require a lot of effort and doesn't interfere with the perception of major changes. You are not required to bring the entire file to a single style, there is no point or benefit in this.

Should I start writing a PR to update the docs now, or wait until these changes are approved?

I don't think this is strictly regulated, but in practice PRs for docs and/or demo projects are usually opened after the PR in the main repository is merged. Since the docs cannot be updated before the main PR is merged. Plus, during the review process, you may be asked to make some changes, which will also require you to update the docs PR.
Therefore, in my opinion, it is better to wait for the final version, so as not to do extra work. It's normal for the documentation (Manual) to be a bit behind the current state, no one expects it to be updated the same day a feature is in master. The exception is the Class Reference, since it's in the main repository, we try to keep it up to date.

Yes, you can:
scons dev_build=true tests=true
bin/<godot executable> --test

But this is only for your platform. Tests on GitHub run for different platforms and compilation flags.

Ah, gotcha. There error was on Linux and I have Windows, so I guess there's not much I can do but hope it passes this time :)

This is a new feature and therefore unlikely to be included in 4.1, as we are in feature freeze, so chances are it will have to wait for approval until after the release of 4.1

Need a rebase after #77129.

You reset the branch to the base branch, which closes the PR automatically

Superseded by: #78991


namespace handling

I'm still new to the WoW APIs, but I understand some calls require namespaces, and some URIs can be identical other than the namespace.  While this feels like a rather badly written API where it's specifically not used for versioning...  there it is.
For instance, this call is easy to handle (which I will make a PR for later):
module RBattlenet
  module Wow
    class Battlepet
      def self.find_all
        uri = RBattlenet.base_uri("data/wow/pet/index")
        pp uri
        RBattlenet.get(uri, "namespace=static-#{RBattlenet.region}")
      end
    end
  end
end

This call returns a list of all pets, perhaps not in a super useful format.  It requires that specific namespace, so this call is likely easy to hard code.  What about those that do not?  Is there an overall plan on handling this?

Hey @skandragon, I haven't looked into the WoW APIs in a long time and unfortunately I don't really have time atm to get back into it,  thus there are no plans to address this :(
However, PRs are most welcome and appreciated 🙇
Sorry I can't be of more help at this point in time!

Good enough :) . It just means whatever I do, if I also find the time...  won't conflict with your plans.  Thanks!


support not passing params

this should fix https://github.com/MoOx/postcss-cssnext/pull/333

ping @jonathantneal

This was resolved in 3.0.1.


Editor: Dim UI when a WindowDialog is shown.

Darkens the editor on WindowDialog popups.
This adds the following new Editor settings:

interface/dim_editor_on_dialog_popup (true) # Enable/Disable editor dimming
interface/dim_amount (0.6) # Percentage of how much the editor will be darkened (0-1)
interface/dim_transition_time (0.11) # The duration (in seconds) of the color blending effect (0-1), 0 is instant.

Please test this thoroughly, I haven't yet seen a case where it fails to work properly but I'm sure I didn't test all windows of the editor :P
Closes #7900

I guess it would be nice if this could be used in games, but well, we can fake it ourselves if needed :wink:

This is sexy <3
Probably unrelated, but when a WindowDialog or Popup appears, why clicking anywhere outside of it makes it disappear? I thought "dialogs" are inherently modal. Or is it just me?

It's a very nice touch how the editor window is dimmed on the background when a modal view is shown, however I couldn't find a value that would look nice on my screen.
If Dim Amount is too high the borders of the dialog widow disappear on the background, and if it is too low the dimming effect is not noticeable.
I can only use values in the range 20% above and below 0.5, which makes de dimming effect a bit unpleasant to my taste. It might be a problem with my monitor though, some issue with the contrast or brightness, nevertheless I decided to replace the Dimming Amount by a color in the settings, and use a Control as an overlay to render the dimming effect.
Also, the dimming effect when the dialog is closed seemed too distracting to me, so I made the time of the dimming effect for closing the dialog equal to zero. Thant way, the dimming effect is only visible when the dialog is opening.
Here is a screen recording with how it looks.
The changes are in this commit, please let me know it you are interested to make a PR.
@Hinsbart keep up the good work!


A test method using Activator.CreateInstance that raises an exception is not failing and is showing a "Not Run" status.

Describe the bug
I'm testing a piece of code that uses Activator.CreateInstance. Although it fails, the test method status is showing as "Not Run".
Steps To Reproduce
[TestMethod]
public void CleanData_AnonymousObject()
{
    var input = new
    {
        Field1 = "StringWith\0Null",
        Field2 = "NormalString",
    };
    var cleanedObject = Activator.CreateInstance(input.GetType());
}

Expected behavior
The test fail and the status of the test is fail
Actual behavior
The test status is Not Run
Additional context
With XUnit the test fail because there is the following exception
Cannot dynamically create an instance of type '<>f__AnonymousType23[System.String,System.String,<>f__AnonymousType31[System.String]]'. Reason: No parameterless constructor defined.

I can repro under vstest using dotnet test + dll,
dotnet test S:\t\mstest145\bin\Debug\net9.0\mstest145.dll
VSTest version 17.11.0-preview-24265-01 (x64)

Starting test execution, please wait...
A total of 1 test files matched the specified pattern.
  Skipped TestMethod1 [28 ms]

None     - Failed:     0, Passed:     0, Skipped:     0, Total:     0, Duration: 145 ms - mstest145.dll (net9.0)

Running with straight testing platform does not repro:
dotnet test
Restore complete (0,4s)
You are using a preview version of .NET. See: https://aka.ms/dotnet-support-policy
  mstest145 succeeded (3,5s) → bin\Debug\net9.0\mstest145.dll
  mstest145 failed with 2 error(s) (1,2s)
    C:\Users\jajares\.nuget\packages\microsoft.testing.platform.msbuild\1.1.0\buildMultiTargeting\Microsoft.Testing.Platform.MSBuild.targets(228,5): error : Failed test 'TestMethod1', reason 'Cannot dynamically create an instance of type '<>f__AnonymousType0`2[System.String,System.String]'. Reason: No parameterless constructor defined.'
    C:\Users\jajares\.nuget\packages\microsoft.testing.platform.msbuild\1.1.0\buildMultiTargeting\Microsoft.Testing.Platform.MSBuild.targets(228,5): error : Tests failed: 'S:\t\mstest145\bin\Debug\net9.0\TestResults\mstest145_net9.0_x64.log' [net9.0|x64]

So this looks like vstest bridge bug on a first look.

Bug was introduced here in #2028: https://github.com/microsoft/testfx/commit/2c4fb9644b1fc69a5b4933fc10767ddb278a15b4#diff-f4f2349a95d58ad9b34b2f09112518eeadaaa8d897c38ada7def4c1f3a98ff33R260

The code does not check for hot reload mode, as far as I can see. And even in hot reload mode this issue would repro, because the test fails with method missing exception.

If you debug this, simply set BP to the test in VS, and once you hit it, go up until you reach the offending code.

@pablorivassanchez We had to postpone the release of v3.4 so I will have to postpone 3.5 too (probably end of June). Please let us know if that's critical for you so we can investigate releasing a patch for v3.4

The code does not check for hot reload mode, as far as I can see. And even in hot reload mode this issue would repro, because the test fails with method missing exception.

We should definitely fix the check for being in Hot Reload mode. For the other case, being already in Hot Reload, I think this is going to be tricky as we probably have no way to understand if that's expected or not.

@pablorivassanchez We had to postpone the release of v3.4 so I will have to postpone 3.5 too (probably end of June). Please let us know if that's critical for you so we can investigate releasing a patch for v3.4

it's ok for my only 1 of our set of tests is affected


DxDataGrid CellTemplate Not Working Properly

Hi,
When a dxTemplate is defined inside a dxDataGrid and the datasource is not ready before first load it fails drawing the grid. I hope that you can reproduce the issue introducing the dxDataGrid dataSource from a service or setting it inside ngAfterViewInit().
The error: n.owner is not a function at DxTemplate. (dx.all.js:10) from _cleanPreviousContent -> o.cleanData -> _cleanTemplates
It seems that you are cleaning content of nothing.
If the dataSource is ready then it works as expected. If you have a dataSource before first load and then you change it, it works too.
Thank You

¿#85?

Hello,
Yes, looks like #85 should fix it. We will research it as soon as possible.

It seems that #85 Fixed this.


Replace rust overlay with rustup package

Turns out things work just fine without the overlay. Please test this on your machines though in case I missed something when cleaning.
After a git clean and rustup self uninstall, the E2E env starts up in a pure shell (with no local Rust installation) and smoketests build & pass. The only errors I got were from forgetting to run the init.sh and make-bindings.sh scripts, but those are already mentioned in the READMEs 😅
One issue I can think of is if the Nix rustup version in an impure shell behaves in a way that conflicts with a local one. This seems unlikely, but I've reinstalled Rust locally & compiled other projects, then switched back to Snowbridge in an impure shell and the E2E stack still works.

an impure shell behaves in a way that conflicts with a local one

With the rust-toolchain.toml explicitly declared this is not a problem IMO.

@doubledup This is still missing a few things:

The scripts/init.sh script needs to explicitly install the rust toolchain as well a nightly for rustfmt.
Rustup is going to install the toolchains outside the nix env into the $HOME/.rustup, along with other toolchains that have nothing to do with the nix env. You should set RUSTUP_HOME in flake.nix so that the env has its own rustup dir.

We automatically install the stable toolchain when running web/packages/test/scripts/start-services.sh (I've tested this by removing my local rustup installation), but we do need to install the nightly version. Might as well make the installation explicit in init.sh.

Yes, I'd rather be explicit about installing the toolchain after initialising the nix env.

Installing toolchains in the project directory doesn't affect which versions are selected: the stable toolchain version is selected by the toolchain file and we don't have a way to lock the nightly version. This might help if there's some state kept in the rustup directory though.

Well the other problem is that if you run rustup toolchain list inside the nix env, it's going to show all toolchains, even those installed outside of the nix env. that's why I'd like to completely segregate Nix's rustup state from the outside world.

Unfortunately there's no explicit command for installing the version in the toolchain file: https://github.com/rust-lang/rustup/issues/2686
There are other commands that will implicitly install from the toolchain file, but there's talk of removing that behaviour: https://github.com/rust-lang/rustup/issues/1397
I'm seeing two options:

We can explicitly install a nightly version, but we need to duplicate the stable version in init.sh in order to install it explicitly. Here we need to update the Rust version in 2 places when upgrading Rust. If we miss this, fresh machines will install the old Rust version but will still use the correct version from the toolchain file.
We can use something like rustup show to implicitly install the version in the toolchain file. Then we need to look out for rustup's behaviour changing during an upgrade (via upgrading nixpkgs). If we miss this, fresh machines won't install the required toolchain in init.sh but it's likely that the cargo and rustc wrappers will.

In both cases, we use the toolchain file's version.
I'd prefer to duplicate the versions for now: it looks like inconsistencies in explicitly mentioned Rust versions are easier to detect than changes to rustup's behaviour that only affect fresh environments.


Implement Layer::on_record

Implements the Layer::on_record trait method which is called by span.record(field, value). This allows
let span = trace_span!("span", later = field::Empty);
span.record("later", "data known later");

to work.
Testing:
Added
demo_span.record("extra_arg", "Some Extra Data");
demo_span.record("regular_arg", "New Arg Data");

To tests/log.rs. As far as I can tell, the test doesn't actually verify the output, but we do see:
2024-12-29T20:05:42.782580Z TRACE ThreadId(02) demo_span{regular_arg="Arg data" extra_arg="Some Extra Data" regular_arg="New Arg Data"}: log: exit
2024-12-29T20:05:42.782588Z TRACE ThreadId(02) demo_span{regular_arg="Arg data" extra_arg="Some Extra Data" regular_arg="New Arg Data"}: log: close time.busy=1.00s time.idle=24.1µs
test write ... ok

appear in the log now.
We also see that the argument is successfully updated when viewed by perfetto:
$ traceconv json /tmp/test.pftrace 2> /dev/null | jq '.traceEvents | .[] | select (.name == "demo_span")'
{
  "args": {
    "extra_arg": "Some Extra Data",
    "regular_arg": "New Arg Data",
    "source_location": {
      "file_name": "tests/log.rs",
      "line_number": 24
    }
  },
  "cat": "",
  "dur": 1002889,
  "name": "demo_span",
  "ph": "X",
  "pid": 24755,
  "tid": -1454467392,
  "ts":<PHONE_NUMBER>309190
}

Thanks :)


Download all the files needed.

Onnxruntime built, repositories gitted.

Modified a typo in YOLOX.hpp and YOLOX.cpp


[WIP] Aux Command

This is a branch that @cmcquinn was working on.  It looks like it's ready to go, perhaps we should test it an merge it in?

@austinhurst and @jhb1993 This is the aux servo command stuff that should work for your servo drop

@cmcquinn, it would be great to get this merged in.  Do you think you have some time to help us get this synced back up with master?

Yes. I will get working on it.
On Thu, Sep 13, 2018 at 4:45 PM James Jackson<EMAIL_ADDRESS>wrote:

@cmcquinn https://github.com/cmcquinn, it would be great to get this
merged in. Do you think you have some time to help us get this synced back
up with master?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/rosflight/firmware/pull/286#issuecomment-421176136,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AHG-4Ll78FFlO745KhlBXBgd4iOt6RYUks5uauABgaJpZM4SQW7c
.

Hey @cmcquinn, I'm cleaning up the repo a bit, and I'm wondering what the status of this work is.

Tested aux_command by publishing on the /aux_command and viewing the values passed through to /output_raw.
Fixed some issues with matching array sizes - all output_raw related array references are now for length 14.
Modified mixer to include a PASSTHROUGH option - is the value chosen (11) acceptable or since this is more of a "special" option should it be grouped near ESC_CALIBRATION? The PWM update rate is set to 50 since this will likely be used with servos as well as ESCs.
The mixer currently uses 8 outputs for mixing, the remaining 6 can be set only with the aux_command. Is this the way you would like it, or should the mixers be modified to mix all 14 outputs?

The aux command is working properly. This branch has been merged into gps because of dependency issues.


Propagate generics to traits on collection classes

Hey Folks,
using PHPStan/Larastan on level 9 currently reports issues regarding the generics on the collection classes.
For example the following code gives an error:
/** @var DataCollection<int, TestData> $collection */
$collection = \App\DataObjects\TestData::collection([]);

$collection->each(function (\App\DataObjects\TestData $data) {
    echo $data->id;
});

PHPStan reports an error for the callback of the each method:
Parameter #1 $callback of method Spatie\LaravelData\DataCollection<int,App\DataObjects\TestData>::each() expects callable(mixed, (int|string)): mixed, Closure(App\DataObjects\TestData): void given.

This PR fixes these problems by annotating the used traits and by that propagate the types down to them.
It mimics how Laravel does the same thing for the Collection class.
Thank you for this and all the other great packages you provide!

Looking good!


Add single search page support

Fixed #42
Fixed #72
Fixed #74
Fixed #75
The single search page built-in UI share the same style as the Modal (auto complete).
It's designed to be theme-less, you can wrap it in your baseof template to fit your theme UI layout, and styling it with CSS variables.
TODO:

[x] Docs

@frankrenold  @ardacarofficial Hi, the single search page feature can be previewed now via the links above. Please feel free to test it and share your feedback if you're still interested in this.

@frankrenold @ardacarofficial Hi, the single search page feature can be previewed now via the links above. Please feel free to test it and share your feedback if you're still interested in this.

Excellent. Thank you for your time.

Merged, please file a new issue if you found one.


Fixture documentation error

https://bugs.launchpad.net/requests-mock/+bug/1583786

Thank you for contributing to openstack/requests-mock!
openstack/requests-mock uses Gerrit for code review.
If you have never contributed to OpenStack before make sure you have read the
getting started documentation:
http://docs.openstack.org/infra/manual/developers.html#getting-started
Otherwise please visit
http://docs.openstack.org/infra/manual/developers.html#development-workflow
and follow the instructions there to upload your change to Gerrit.


Things in ietf/static/ietf/doc need different homes

This directory has been inconsistently used as a place to capture various things. As far as I can tell, nothing references them.
However, being in static, they've been served as static assets by production for some time.
These should move to more appropriate documentation locations.

That directory seems to be gone now?


Crop rect position issue

Hi,
Thanks for a great lib, it is really excellent!
I am experiencing a problem when using CropImageView in my own layout. The problem is that the crop rect seems to be centered on some point off center initially and this means it stretches beyond the size of the image. First time I touch the view it corrects this error immediately. I have attached a photo of the problem below. Do you have some suggestions on how to solve this problem or do you need more information?

Hey, looks like a bug.
I'm on vacation now, let me try to reproduce it next week, if I can reproduce it I will fix and publish a new version, otherwise will require more info.
Thx.

I will try to isolate the problem in a minimalistic example in the mean time.
Have a nice vacation :-)
Regards
Martin

I think the crop view does not respond very well with weighted sizes. If I place the crop view with match_parent in a linear layout which has height = 0 and weight = eg. 1 then it works as expected. Heres a working layout snippet:
   <LinearLayout         android:id="@+id/cropImageViewLayout"         android:layout_width="match_parent"         android:layout_height="0dp"         android:orientation="vertical"         android:layout_weight="2"         android:visibility="visible">         <com.theartofdev.edmodo.cropper.CropImageView             android:id="@+id/cropImageView"             android:layout_width="match_parent"             android:layout_height="match_parent"/>     </LinearLayout>

I didn't handle resize of the view, I think I fixed it in v2.3.1, let me know if all good now as its a bit tricky.
Thank you!

@martinprevas ?

Hi, I tested it a couple of days ago and it seems to behave alright now. I will report back if I find any problems. Thanks for a great library and quick support :-)
Best regards
Martin

Awesome!
Thank you for reporting this issue and providing the info, it really helped me find the underline problem.


feat: QueryBuilder is now argument of handler

Current coverage is 100% (diff: 100%)

Merging #13 into master will not change coverage

@@           master   #13   diff @@
===================================
  Files           5     5
  Lines          50    51     +1
  Methods        11    11
  Messages        0     0
  Branches        0     0
===================================
+ Hits           50    51     +1
  Misses          0     0
  Partials        0     0

Powered by Codecov. Last update 1998c90...57104dc


Enable CircleCI for pull requests

It seems CircleCI is currently not enabled for pull requests and so we cna not see if everything is ok when we create a PR.

@DanielRuf Just saw this after I commented on your PR. I just enabled builds from PRs (I think). Let me know if that does the trick.

It did 👍 🎉


Add transformer method for service constructor expression node

Purpose
$subject
Fixes #23908
Check List

[x] Read the Contributing Guide
[ ] Updated Change Log
[ ] Checked Tooling Support (#)
[ ] Added necessary tests

[ ] Unit Tests
[ ] Spec Conformance Tests
[ ] Integration Tests
[ ] Ballerina By Example Tests

[ ] Increased Test Coverage
[ ] Added necessary documentation

[ ] API documentation
[ ] Module documentation in Module.md files
[ ] Ballerina By Examples

Codecov Report

Merging #23992 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #23992   +/-   ##
=======================================
  Coverage   14.59%   14.59%
=======================================
  Files          51       51
  Lines        1411     1411
  Branches      219      219
=======================================
  Hits          206      206
  Misses       1189     1189
  Partials       16       16

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0d023be...ac4a0bb. Read the comment docs.


make instances of access find frontend{-1}

well, i will make an entire PR about integrating {-1}frontend database i think....


Fixed wrong word in typescript data from Sidemenu

try yourself https://react-hook-form.com/ts and tap UseFormReturn  is not working that's why I decided to fix it to avoid error
I simply changed different string and only one variable
So I managed to fix it if there is any mistake please let me know

oh wow, thank you for looking into this! and the fix.


I have set restartPolicy: OnFailure for the workers, evaluator and chief. The tf-operator deployment is in a node pool with nodes that cannot be preempted.
It looks like some of the pods got restarted around the time of the preemption, but finally the job was stopped with the following status:
  Message:               TFJob myjob has failed because 1 Worker replica(s) failed.
    Reason:                TFJobFailed
    Status:                True
    Type:                  Failed
  Replica Statuses:
    Chief:
    Evaluator:
      Active:  1
    PS:
      Active:  4
    Worker:
      Active:  6
      Failed:  1

Is there something that needs to be done to make tfjobs handle pre-empted nodes?

I'd appreciate any help with this. I saw one error on a worker that was preempted, saying it did not have enough nvidia/gpu. So it sounds like the GPU was taken away from the instance, causing the worker to fail. And even though it has restartPolicy: OnFailure, it caused the whole tf-job to fail.
Note when there is a failure in the code, e.g. sys.exit(1), then workers are correctly restarted.

Can you provide logs of worker and controller? Is this similar to https://github.com/kubeflow/tf-operator/issues/366?
@richardsliu @gaocegege

Any tips on how to recreate this, so I can monitor everything as it happens? If I delete the VM instance, then everything works correctly. The workers on that node stop, a new node is scheduled, and they start back up again. Could there be something different that happens in a real preemption? (Are the GPUs sometimes detached from preemptible instances while the instances themselves keep running?)

Aha, it just happened.
On the dashboard I see worker-0 has failed with the message "Pod Node didn't have enough resource: nvidia.com/gpu, requested: 1, used: 0, capacity: 0"
Doing kubectl describe for the worker pod, I see:
Warning  OutOfnvidia.com/gpu  7m    kubelet, gke-train-model-gpu-pool-a83bc04b-nq3l  Node didn't have enough resource: nvidia.com/gpu, requested: 1, used: 0, capacity: 0
Status:             Failed
Reason:             OutOfnvidia.com/gpu
Message:            Pod Node didn't have enough resource: nvidia.com/gpu, requested: 1, used: 0, capacity: 0

The worker's logs do not have any error message, but are just cut off abruptly.
The chief has the error message that happens when one of the other workers or parameter servers goes down:
An error was raised. This may be due to a preemption in a connected worker or parameter server. The current session will be closed and a new session will be created. This error may also occur due to a gRPC failure caused by high memory or network bandwidth usage in the parameter servers. If this error occurs repeatedly, try increasing the number of parameter servers assigned to the job. Error: Socket closed
Doing kubectl describe tfjob I get:
Message:               TFJob job has failed because 1 Worker replica(s) failed.
    Reason:                TFJobFailed
    Status:                True
    Type:                  Failed

Here are the relevant logs from tf-job-operator at the time of the failure
{"filename":"tensorflow/controller.go:340","job":"default.job","level":"info","msg":"Reconcile TFJobs job","time":"2019-05-22T12:44:14Z","uid":"2a560be3-7c89-11e9-99d3-42010aa4004a"}
{"filename":"k8sutil/k8sutil.go:101","level":"info","msg":"Ignoring inactive pod default/job-worker-0 in state Failed, deletion time \u003cnil\u003e","time":"2019-05-22T12:44:14Z"}
{"filename":"tensorflow/status.go:57","job":"default.job","level":"info","msg":"TFJob=job, ReplicaType=PS expected=4, running=4, failed=0","time":"2019-05-22T12:44:14Z","uid":"2a560be3-7c89-11e9-99d3-42010aa4004a"}
{"filename":"tensorflow/status.go:57","job":"default.job","level":"info","msg":"TFJob=job, ReplicaType=Worker expected=12, running=11, failed=1","time":"2019-05-22T12:44:14Z","uid":"2a560be3-7c89-11e9-99d3-42010aa4004a"}
{"filename":"tensorflow/status.go:57","job":"default.job","level":"info","msg":"TFJob=job, ReplicaType=Chief expected=1, running=1, failed=0","time":"2019-05-22T12:44:14Z","uid":"2a560be3-7c89-11e9-99d3-42010aa4004a"}
{"filename":"tensorflow/status.go:57","job":"default.job","level":"info","msg":"TFJob=job, ReplicaType=Evaluator expected=1, running=1, failed=0","time":"2019-05-22T12:44:14Z","uid":"2a560be3-7c89-11e9-99d3-42010aa4004a"}
{"filename":"record/event.go:221","level":"info","msg":"Event(v1.ObjectReference{Kind:\"TFJob\", Namespace:\"default\", Name:\"job\", UID:\"2a560be3-7c89-11e9-99d3-42010aa4004a\", APIVersion:\"kubeflow.org/v1beta2\", ResourceVersion:\"3541041\", FieldPath:\"\"}): type: 'Normal' reason: 'TFJobFailed' TFJob job has failed because 1 Worker replica(s) failed.","time":"2019-05-22T12:44:14Z"}
{"filename":"tensorflow/job.go:120","level":"info","msg":"Updating tfjob: job","time":"2019-05-22T12:44:14Z"}
{"filename":"tensorflow/controller.go:284","job":"default.job","level":"info","msg":"Finished syncing tfjob \"default/job\" (16.277576ms)","time":"2019-05-22T12:44:14Z"}

thanks for any help

I wonder if this was the individual GPU running out of memory and failing (I was trying to push its limits). Before I had seen an error message about going out of memory, which I didn't see here.

@matthen If the resource is not enough, the pod cannot be scheduled and it may be failed. But we do not show the real reason in TFJob since we think it can be shown in pods. I am not sure if we need show the info in TFJob. You know, there are so many problems that can fail a pod.

@matthen If the resource is not enough, the pod cannot be scheduled and it may be failed. But we do not show the real reason in TFJob since we think it can be shown in pods. I am not sure if we need show the info in TFJob. You know, there are so many problems that can fail a pod.

The pod is killed and disappeared. So I think it would be useful to keep preempted status in the TFJob.

@cheyang
I am not sure how to implement it. Should we aggregate all status of all PS/workers into TFJob status?

@matthen When a gke gpu node is preempted, it is recreated. However, if the node is recreated shortly after being preempted (before the pods have been evicted ~5min), then upon node startup, the preexisting pods will still be running on the node, potentially before all system pods are finished setting up.
Thus there is a possibility for the GPU pods to be running on the node before the ndivida-driver-installer daemonset has installed the nvidia driver which makes the GPU devices available. Here is the relevant issue: https://github.com/kubernetes/kubernetes/issues/64632 and relevant PRs: https://github.com/kubernetes/kubernetes/pull/64784, https://github.com/kubernetes/kubernetes/pull/77699

Has anyone found a solution/workaround? The issue persists in gke version 1.16.0 which is supposed to include the commits made in the PRs mentioned above by @chardch

/area engprod
/priority p2

Is there any progress regarding this issue? Without solving this issue, distributed training using kubeflow and preemptible GPU nodes is impossible. Doesn't Kubeflow claim to do both?

+1 we have had to switch to non preemptible nodes for tfjobs to work

Quoting from https://cloud.google.com/kubernetes-engine/docs/how-to/preemptible-vms#kubernetes_constraint_violations
Node preemption shutdowns Pods ungracefully and ignores the configured Pod grace period. This means Pods shut down without notice.
According to the Pod disruption budget documentation, "The budget can only protect against voluntary evictions, not all causes of unavailability." Preemption is not voluntary, so you may experience greater unavailability than what is specified in the Pod disruption budget.

Are there any fixes for this, or can we not use kubeflow with preemptible GPUs? @jtfogarty @jbottum @jlewi

I think I have fixed this issue while refactoring the whole project
https://github.com/kubeflow/tf-operator/blob/master/pkg/controller.v1/tensorflow/status.go#L170
@gaocegege @Jeffwan is there a way to allow people to use latest tf-operator image?

(I ended up switching to regular k8s services + jobs, and adding logic in the workers + parameter servers themselves to make sure they exit successfully at the end of training)

@ChanYiLin Release infra and test-infra are blocked currently. We have to wait for a while or do manual release.

Is there any progress on this issue?


[bug]:

Background
I have several question with the below forced closed channel.

Why is it still in pending_force_closing_channels when the closing transaction 5a270e17d38653b30bf6a0f60a8045a5dc93df15084d72f3a10e4028209460de has been confirmed for ages.
Why limbo_balance is 2244 when local_balance is 2994185

    "pending_force_closing_channels":  [
        {
            "channel":  {
                "remote_node_pub":  "026c79920c8bdf86fd464c01e106ad84287ff6ee0d41d65e900d67e3ba91327f8a",
                "channel_point":  "b543e4454d03ddc60313ffc4f5c8db7aadf307686c1ec11a4e0cf0497c946add:1",
                "capacity":  "3000000",
                "local_balance":  "2994185",
                "remote_balance":  "0",
                "local_chan_reserve_sat":  "0",
                "remote_chan_reserve_sat":  "0",
                "initiator":  "INITIATOR_LOCAL",
                "commitment_type":  "ANCHORS",
                "num_forwarding_packages":  "0",
                "chan_status_flags":  "",
                "private":  false,
                "memo":  ""
            },
            "closing_txid":  "5a270e17d38653b30bf6a0f60a8045a5dc93df15084d72f3a10e4028209460de",
            "limbo_balance":  "2244",
            "maturity_height":  0,
            "blocks_til_maturity":  0,
            "recovered_balance":  "0",
            "pending_htlcs":  [
                {
                    "incoming":  false,
                    "amount":  "1914",
                    "outpoint":  "0b315cba26c3c69d2b1eec4a24e667c0b36312f4e983ebc64ab3c356b13e02d3:0",
                    "maturity_height":  816338,
                    "blocks_til_maturity":  -11246,
                    "stage":  1
                }
            ],
            "anchor":  "LIMBO"
        }
    ],

Your environment
lnd v0.17.3 on docker
Steps to reproduce
I don't know
Expected behaviour

The limbo balance should match the local balance.
The channel shouldn't be in the pending forced close channels anymore

Actual behaviour

The limbo balance of a forced close channel has a different amount from the local balance.
The forced close channel has the closing transaction confirmed but is still in the list.

It looks like this is correct behavior, the limbo balance refers to the value of the anchor output ("anchor": "LIMBO") plus the HTLC amount sitting in the first stage transaction (https://mempool.space/tx/999c6a9a7d86539f89894137a72374b6ce4f93c78e36040b8329fa03ab826ce5#vin=0). The HTLC output still sits there because it's uneconomical to spend. The to_local outpoint was already swept.


Cuphead - Some bug fixes

This patch fixes:

The King Dice (Boss) split. (used wrong level completion flag) (major issue)
King Dice for IL timing (needs to use some special cases, the reason the xml includes Level ids now). The level ID updated after the scene which meant it was checking the previous level's completion flag, now it checks that the level ID is what is expected.
0.01 on first loading screen (using some jank, might be an asl thing, I don't know)
onSplit is no longer necessary since we use gameTime now (and was causing some unintended behavior previously as it wasn't using inILMode)
pldm["levelObjects"] sometimes gave a "Sequence contains no matching element" error (don't know how to reproduce this consistently), so it was simply replaced with 0x10 which is it's offset in every version of Cuphead. link. It might be worth changing the .First in MonoClass[int] to .FirstOrDefault so that we can check for null and coalesce it to a default value if necessary.
No save slots exists before the orange intro screen which produced a lot of errors, now it just returns a null pointer and returns false in update in this case.

Thank you

And please make sure to test all of your changes once more.

That should be good - did end up finding another super minor bug with King Dice ILs that required me rebeat the whole fight for testing, which ended up taking a while


Error when compile loader.so

Compiling neon/data/imageset_decoder.so ...
g++ -w -O3 -shared -o neon/data/imageset_decoder.so -std=c++11 -fPIC neon/data/imageset_decoder.cpp $(pkg-config opencv --cflags --libs)
/usr/bin/ld: cannot find -lcufft

Any help? Please!

What version of gcc do you have?

Closing as there hasn't been a response in 3+ weeks.  If you are still seeing this issue please let us know.  Also this may be related or a dupe of #176


Very strange async problem

I'm getting a strange problem when the first use of chalk is in an async callback thread.
Node 0.12.6
[ReferenceError: builder is not defined]
ReferenceError: builder is not defined
    at Chalk.builder (c:\git\node-markdown-spellcheck\node_modules\chalk\index.js:40:27)
    at c:\git\node-markdown-spellcheck\es5\cli.js:221:58
    at c:\git\node-markdown-spellcheck\node_modules\async\lib\async.js:187:20
    at iterate (c:\git\node-markdown-spellcheck\node_modules\async\lib\async.js:265:13)
    at Object.async.forEachOfSeries.async.eachOfSeries (c:\git\node-markdown-spellcheck\node_modules\async\lib\async.js:284:9)
    at Object.async.forEachSeries.async.eachSeries (c:\git\node-markdown-spellcheck\node_modules\async\lib\async.js:220:22)
    at c:\git\node-markdown-spellcheck\es5\cli.js:219:26
    at c:\git\node-markdown-spellcheck\node_modules\async\lib\async.js:697:13
    at c:\git\node-markdown-spellcheck\node_modules\async\lib\async.js:52:16
    at done (c:\git\node-markdown-spellcheck\node_modules\async\lib\async.js:248:21)

I've looked at the code
	var builder = function builder() {
		return applyStyle.apply(builder, arguments);
	};

and I've no idea why it is going wrong - the function expression name should be exposed.
If I change the chalk code in my node_modules to...
	var builder = function () {
		return applyStyle.apply(builder, arguments);
	};

then it works.
If I add a dummy call to chalk before I start doing async things, it works
chalk.red("red"); // fix very weird bug

The only explanation I have is that its a weird V8 bug. I'm raising here in case there is something I missed, or you have seen it before or you had been thinking about removing the function name anyway.

I've tried reproducing with
var chalk = require("chalk");
setTimeout(function() {
"use strict";
chalk.red("red");
}, 100);

but no luck. It seems even in my node-markdown-spellcheck it only happens if it successfully reads a file before using chalk and async is fired async.

This sounds like a conflict with another package. Can you list the packages you're using, or do you have your package on NPM so I could take a look?

<EMAIL_ADDRESS>node_modules\async

<EMAIL_ADDRESS>node_modules\hunspell-spellchecker

<EMAIL_ADDRESS>node_modules\marked

<EMAIL_ADDRESS>node_modules\commander
└──<EMAIL_ADDRESS>
<EMAIL_ADDRESS>node_modules\chalk
├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS><EMAIL_ADDRESS>└──<EMAIL_ADDRESS><EMAIL_ADDRESS>
<EMAIL_ADDRESS>node_modules\glob
├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS><EMAIL_ADDRESS>├──<EMAIL_ADDRESS><EMAIL_ADDRESS>└──<EMAIL_ADDRESS><EMAIL_ADDRESS>
<EMAIL_ADDRESS>node_modules\inquirer
├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS><EMAIL_ADDRESS>├──<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>├──<EMAIL_ADDRESS>└──<EMAIL_ADDRESS>
Looking at the source code I cannot see how something else could cause this...

Unfortunately I cannot reproduce this.
var fs = require('fs');
var chalk = require('chalk');
require('async');
require('hunspell-spellchecker');
require('marked');
require('commander');
require('glob');
require('inquirer');

var file = fs.readFileSync('./foo');
setTimeout(function() {
  console.log(chalk.blue("Hi?"));
}, 500);

Successfully outputs a blue string.
 $ node --version
v0.12.6
$ node index.js
Hi?

Can you start chipping pieces away until you have a small piece of code that reproduces the error? Also, what platform are you on?

windows, node 0.12.6.
Looking at the source code it can only be a V8 bug in node 0.12.0 - the code is valid

I think more specifically, it could very well be a bug in the Windows build. Can you try downgrading to 0.12.0 to see if the bug is still present?

Having the same problem, mentioned here - https://github.com/sindresorhus/time-grunt/issues/66
Mac OS X, node v0.12.5.
Even if I removed time-grunt usage, now my uglify grunt task if failing,
Running "uglify:main" (uglify) task
[D] Task source: /Users/alexanderbeletsky/Development/Projects/mylorry/shift-planner-office/node_modules/grunt-contrib-uglify/tasks/uglify.js
Warning: builder is not defined Use --force to continue.
ReferenceError: builder is not defined
    at Chalk.builder (/Users/alexanderbeletsky/Development/Projects/mylorry/shift-planner-office/node_modules/grunt-contrib-uglify/node_modules/chalk/index.js:40:27)
    at /Users/alexanderbeletsky/Development/Projects/mylorry/shift-planner-office/node_modules/grunt-contrib-uglify/tasks/uglify.js:176:45
    at Array.forEach (native)
    at Object.<anonymous> (/Users/alexanderbeletsky/Development/Projects/mylorry/shift-planner-office/node_modules/grunt-contrib-uglify/tasks/uglify.js:63:16)
    at Object.<anonymous> (/Users/alexanderbeletsky/Development/Projects/mylorry/shift-planner-office/node_modules/grunt/lib/grunt/task.js:264:15)
    at Object.thisTask.fn (/Users/alexanderbeletsky/Development/Projects/mylorry/shift-planner-office/node_modules/grunt/lib/grunt/task.js:82:16)
    at Object.<anonymous> (/Users/alexanderbeletsky/Development/Projects/mylorry/shift-planner-office/node_modules/grunt/lib/util/task.js:301:30)
    at Task.runTaskFn (/Users/alexanderbeletsky/Development/Projects/mylorry/shift-planner-office/node_modules/grunt/lib/util/task.js:251:24)
    at Task.<anonymous> (/Users/alexanderbeletsky/Development/Projects/mylorry/shift-planner-office/node_modules/grunt/lib/util/task.js:300:12)
    at /Users/alexanderbeletsky/Development/Projects/mylorry/shift-planner-office/node_modules/grunt/lib/util/task.js:227:11

In uglify,
      grunt.verbose.writeln('File ' + chalk.cyan(f.dest) + ' created: ' +
        maxmin(result.max, output, options.report === 'gzip'));

That's pretty serious for me. Any help will be really appreciated.

The only fix I had was to edit the files in node_modules/xxx/chalk/index.js https://github.com/chalk/chalk/blob/6142553bb5d7b3e7fbcea76b8ccf876f373e1bf1/index.js#L39 and remove the name from the function expression.
it must be an obscure V8 bug effecting 0.12 and effecting chalk only in very specific scenarios.

I've made a PR with that fix. I can't see a reason not to fix it, since the code is equivalent, but doesn't randomly fail for at least people >= 2 .
@alexbeletsky I forgot the fix I put in my repo might help you too - https://github.com/lukeapage/node-markdown-spellcheck/blob/master/es6/cli.js#L37

hey @lukeapage thanks a lot for this! I hope PR is merged as soon as possible.

@lukeapage as I mentioned in the PR (and I'll mention here for completeness), can either you or @alexbeletsky provide some code that reproduces this?

@caitp, knowing you work on V8, does this bug ring a bell with you? I've searched the V8 issues and I can't see a named function expression bug that has been raised or fixed recently

Reproduced; like 90% sure this is indeed a V8/Node bug.

@lukeapage on phone but I'll take a look in a minute. I might need to see a bit more code

based on the snippets i'm seeing, it could be a V8 bug or it could be user error (more context is needed to be sure). If you give me instructions for reproducing, I can probably narrow it down a bit more

@caitp if you are interested,  thanks,  it seems pretty weird (though we do have a workaround).
the code creating the error is here:
https://github.com/chalk/chalk/blob/6142553bb5d7b3e7fbcea76b8ccf876f373e1bf1/index.js#L39
reproduce steps are on the pr, I've spent an hour trying to make a small reproduction repo without luck.

I'm interested enough to try something else if you have any pointers.

link to repro steps : https://github.com/chalk/chalk/pull/81#issuecomment-132716911

I can reproduce this in node 0.11 and 0.12, but not 3.0 --- so if this was a bug upstream, it seems to have been fixed at some point. It seems to work with flag --nolazy, so presumably this was a parsing bug.

Thanks @caitp


[BSO] Fixed minor errors in descriptions / messages. Like =ods description, nex+kk kc boosts.

Description:
Fixed some description / message inaccuracies.
Changes:
Changed boost messages in nex+kc so they say 50, 100, 200 instead of 200/200/200
Changed description of ODS from Barb assault to Ourania Delivery service.

Thanks!


Use kube-router upstream libraries to consume the netpol controller

Is your feature request related to a problem? Please describe.

We are copying a part of kube-router code to pkg/agent/netpol directory with modifications, from which the biggest one is tje consumption of k3s node config instead of kube-router config.
However, that approach makes it hard to follow new upstream versions. It's possible to use kube-router as a library, so it seems like a better way to do that.
Describe the solution you'd like

Import kube-router libraries instead
Describe alternatives you've considered

Nothing
Additional context

Backporting

[X] Needs backporting to older releases

We can verify we are running the newest code by checking the log "Starting the netpol controller" in journalctl. The old code did not have that

Validated using commit id 5233946c on master branch

Journalctl displays the expected log message

$ journalctl -u k3s|grep netpol
Feb 11 05:18:23 ip-172-31-14-23 k3s[1897]: time="2022-02-11T05:18:23Z" level=info msg="Starting the netpol controller"

Validated network policies work as expected.

Validated using k3s version v1.23.4-rc1+k3s1 (43b1cb48)
sudo journalctl -u k3s|grep netpol
Feb 22 23:18:02 ip-172-31-0-189 k3s[2240]: time="2022-02-22T23:18:02Z" level=info msg="Starting the netpol controller"


Signature with lockMode

Signature component now has a property: lockMode (boolean)
If lockMode is enabled, a small lock should appear and editing is only possible if "unlocked". If value is confirmed -> auto-lock.
This should temporary disable changing value to allow scrolling.

The following 2 properties have been added:
editLock -> On the bottom right corner is an edit button. This button must be pressed to allow editing.
Once editing is allowed: X button resets the painting, OK (✔) button confirms and locks again afterwards. If you dont want to confirm but want to disable painting again -> press x to clear then OK to confirm nothing.
saveLock -> If true, shows an open lock on the top left corner to show saveLock is active but not yet locked. Signature pad behaves the same. Once a value has been set, the lock is closed and no editing is possible. All edit buttons, even the editLock button, is hidden.


Last completion item is being wrongly selected

monaco-editor version: 0.20.0
Browser:: Chrome
OS:: Windows
Playground code that reproduces the issue:
completionItem.txt
Repro steps:

Open https://microsoft.github.io/monaco-editor/playground.html
Apply the code in the attached  completionItem.txt file
Open autocomplete with CTRL+Enter
Choose "Option 4"
Clear the text
Open autocomplete again with CTRL+Enter

Result:
"Option 4" is selected and it shouldn't .
When there are many results and a scroll bar is show, the scenario is worst because the option list jumps to the last selected item (and it's not easy to understand why)

You can pass in suggestSelection: "first" as part of your  IStandaloneEditorConstructionOptions to make it default to the first suggestion

Thanks a lot. It worked.


application for membership

I'm a member of the IBM Runtimes Infrastructure team in Hursley, and would like to contribute to AdoptOpenJDK.

I approve

I approve as well. @bblondin do you want to onboard @mwornast? https://github.com/AdoptOpenJDK/openjdk-infrastructure/blob/master/ONBOARDING.md

https://github.com/AdoptOpenJDK/openjdk-infrastructure/pull/216

@mwornast has now been on-boarded.


Not able to resolve Blender path

Not sure what I did wrong.
I keep getting an error such as the following for 3.10, 3.11, and 3.12
PS Z:\win-code\github\st2> b3denv
 _   ___   _
| |_|_  |_| |___ ___ _ _
| . |_  | . | -_|   | | |
|___|___|___|___|_|_|\_/ v0.0.15
Traceback (most recent call last):
  File "<frozen runpy>", line 198, in _run_module_as_main
  File "<frozen runpy>", line 88, in _run_code
  File "C:\Users\me\AppData\Local\Packages\PythonSoftwareFoundation.Python.3.12_qbz5n2kfra8p0\LocalCache\local-packages\Python312\Scripts\b3denv.exe\__main__.py", line 7, in <module>
  File "C:\Users\me\AppData\Local\Packages\PythonSoftwareFoundation.Python.3.12_qbz5n2kfra8p0\LocalCache\local-packages\Python312\site-packages\b3denv\__init__.py", line 392, in main
    vars = get_vars(None)
           ^^^^^^^^^^^^^^
  File "C:\Users\me\AppData\Local\Packages\PythonSoftwareFoundation.Python.3.12_qbz5n2kfra8p0\LocalCache\local-packages\Python312\site-packages\b3denv\__init__.py", line 96, in get_vars
    python_folder = os.path.join(parent, version, "python\\bin")
                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "<frozen ntpath>", line 149, in join
  File "<frozen genericpath>", line 164, in _check_arg_types
TypeError: join() argument must be str, bytes, or os.PathLike object, not 'NoneType'

I've tried setting the BLENDER_PATH.
I've also tried install 4.11 using the Blender installer, choosing the default installation path.
Nothing works.

where is your blender installed? (e.g. mine is installed at C:\Program Files\Blender Foundation\Blender 4.1)

In trying to get this to work, I've installed it in two places
One is the default "C:\Program Files\Blender Foundation\Blender 4.1"
The other is "C:\Program Files\WindowsApps\BlenderFoundation.Blender_<IP_ADDRESS>_x64__ppwjx1n5r4v9t\Blender assigned by the MS Store.

Are you able to see a python executable file in the file explorer at "C:\Program Files\Blender Foundation\Blender 4.1\4.1\python\bin\python.exe"?

Yes, it's there in both locations
PS Z:\win-code\github\st2> dir 'C:\Program Files\Blender Foundation\Blender 4.1\4.1\python\bin\python.exe'

    Directory: C:\Program Files\Blender Foundation\Blender 4.1\4.1\python\bin

Mode                 LastWriteTime         Length Name
----                 -------------         ------ ----
-a---           2/22/2024  2:22 PM          91136 python.exe

PS Z:\win-code\github\st2> dir 'C:\Program Files\WindowsApps\BlenderFoundation.Blender_<IP_ADDRESS>_x64__ppwjx1n5r4v9t\Blender\4.1\python\bin\python.exe'

    Directory: C:\Program
Files\WindowsApps\BlenderFoundation.Blender_<IP_ADDRESS>_x64__ppwjx1n5r4v9t\Blender\4.1\python\bin

Mode                 LastWriteTime         Length Name
----                 -------------         ------ ----
-a---           3/26/2024  1:30 PM          91136 python.exe

huh, not sure what the issue could be then, as that's exactly the same as on my windows computer where b3denv is working correctly.
I'm not sure why it'd be an issue, but the only thing I'm seeing different here is that you're running code from the Z drive (if i'm reading that correctly?). Could you try installing/running b3denv from the C drive instead? That might be a total garden path but I guess worth trying.

I think I see the issue (but don't know of the solution)
First,
Around line 86, parent is C:\Program Files\WindowsApps\BlenderFoundation.Blender_<IP_ADDRESS>_x64__ppwjx1n5r4v9t and NOT C:\Program Files\WindowsApps\BlenderFoundation.Blender_<IP_ADDRESS>_x64__ppwjx1n5r4v9t\Blender
    elif on_windows():
        version = "4.1"
        parent = os.path.dirname(blender)

        for p in os.listdir(parent):
            if os.path.isdir(os.path.join(parent, p)):
                name = os.path.basename(p)
                if re.match(r"[234]{1}\.[0-9]{1,2}", name):
                    version = name

        #### Parent is actually C:\Program Files\WindowsApps\BlenderFoundation.Blender_<IP_ADDRESS>_x64__ppwjx1n5r4v9t ####
        python_folder = os.path.join(parent, version, "python\\bin")

Second, it doesn't seem to listen to the environment variable I set for BLENDER_PATH:
PS Z:\win-code\github\st2> $BLENDER_PATH = "C:\Program Files\Blender Foundation\Blender 4.1"
PS Z:\win-code\github\st2> echo $BLENDER_PATH
C:\Program Files\Blender Foundation\Blender 4.1
PS Z:\win-code\github\st2> py -3.12 -m b3denv
C:\Users\jayliu\AppData\Local\Programs\Python\Python312\Lib\site-packages\b3denv\__init__.py:370: SyntaxWarning: invalid escape sequence '\_'
  """ _   ___   _
 _   ___   _
| |_|_  |_| |___ ___ _ _
| . |_  | . | -_|   | | |
|___|___|___|___|_|_|\_/ v0.0.15
Traceback (most recent call last):
  File "<frozen runpy>", line 198, in _run_module_as_main
  File "<frozen runpy>", line 88, in _run_code
  File "C:\Users\jayliu\AppData\Local\Programs\Python\Python312\Lib\site-packages\b3denv\__main__.py", line 4, in <module>
    main()
  File "C:\Users\jayliu\AppData\Local\Programs\Python\Python312\Lib\site-packages\b3denv\__init__.py", line 392, in main
    vars = get_vars(None)
           ^^^^^^^^^^^^^^
  File "C:\Users\jayliu\AppData\Local\Programs\Python\Python312\Lib\site-packages\b3denv\__init__.py", line 96, in get_vars
    python_folder = os.path.join(parent, version, "python\\bin")
                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "<frozen ntpath>", line 149, in join
  File "<frozen genericpath>", line 164, in _check_arg_types
TypeError: join() argument must be str, bytes, or os.PathLike object, not 'NoneType'

If I can force the parent to be the path including \Blender it can continue (into the next error)


Docs - start Run Report Guide page

https://github.com/open-contracting/kingfisher-scrape/issues/198

 Scrape: document how to interpret scrapy summary stats


feat(doc): fix links in oauth setup

While trying to set up your awesome project, I read through the docs and noticed that the links in OAuth 2 Login Guide are broken.

Thanks for your contribution :) I think it would actually make more sense if we add links to GitHub instead of relative paths. If we add relative links, it won't work on https://stonith404.github.io/pingvin-share.
Here is an example: ../../../backend/src/oauth/provider/oauthProvider.interface.ts --> https://github.com/stonith404/pingvin-share/blob/main/backend/src/oauth/provider/genericOidc.provider.ts
What do you think?

Sure thing, fixed and rebased

Great, thank you :)


test out building with no existing turbo cache

Overview

PR Checklist

[ ] Related to designs:
[ ] Related to JIRA ticket: ABC-123
[ ] I have run this code to verify it works
[ ] This PR includes unit tests for the code change
[ ] This PR includes testing instructions tests for the code change
[ ] The alpha package of this PR is passing end-to-end tests in all relevant Codecademy repositories

Testing Instructions

Don't make me tap the sign.
PR Links and Envs

Repository
PR Link
PR Env

Monolith
Monolith PR
Monolith Env

Portal
Portal Link
Portal Env

Another Repo
Another Link
Another Env

🚀 Styleguide deploy preview ready!https://62e2d9cde76f261c6016ce2a--gamut-preview.netlify.appDeploy Logs


Get group membership faster.

For members where we already know the DN, just create the grant instead of fetching the user. For group membership by user id, we still have to hit the LDAP server.

Summary by CodeRabbit

New Features

Introduced a streamlined process for creating grants, enhancing efficiency by minimizing redundancy.

Improvements

Simplified grant creation logic, improving maintainability and readability in the handling of user grants.

Error Handling

Maintained robust error logging during user retrieval, ensuring reliability in grant processing.

Our current CI tests do test granting/revoking group membership, so if this code did break that, the test would fail.


[Bug]: Window system compilation error Cannot find module 'webpack/lib/rules/BasicEffectRulePlugin'

Version
System:
OS: Windows 11 10.0.22631
CPU: (8) x64 12th Gen Intel(R) Core(TM) i3-12100
Memory: 1.77 GB / 15.78 GB
Browsers:
Edge: Chromium (128.0.2739.42)
Internet Explorer: 11.0.22621.3527
npmPackages:
@rsbuild/core: ^1.0.1-beta.6 => 1.1.0
@rsbuild/plugin-node-polyfill: ^1.2.0 => 1.2.0
@rsbuild/plugin-sass: ^1.0.1-beta.6 => 1.1.0
@rsbuild/plugin-vue2: ^1.0.1-beta.6 => 1.0.1
Details

I tried on several computers, but none of them worked. They all reported the same error. The node version is 16. How can I solve this problem?

What is the specific reason? Why doesn't the Mac system need to be installed separately? Does Windows need to be installed? How troublesome is that? Is there a solution?

webpack is vue-loader's peerDeps, it looks like you should install webpack.

There is another question. After packaging, all the styles are gone in the production environment. What is the reason?

webpack 未安装,或者webpack 低于 5.0 版本,需要升级新版本

After packaging, all the styles are gone in the production environment. What is the reason?

As this is an independent question, you can create a new issue and provide a reproduction repo, thanks.


Blender install issue

I am trying to install this plug in, but i keep getting this error, does anyone have any ideas on how to resolve it?

Because you’re on Blender 3.6? And this plugin works only on 3.3.x LTS ?


how to blend lualine winbar with colorscheme?

I want the filetype and name to blend in with the colorscheme like the in-file location does, i've moved it from the statusline to the winbar

You should check this issue

Thanks, I'll try out your solution


Mobile overlapping Snapshot text

I'm seeing overlapping text on proposals on mobile.
Originally posted by @azadikoff in https://github.com/decentdao/decent-interface/discussions/1863#discussioncomment-9524540

struggling to replicate this. Recommend we include in next bug bash.
If someone can replicate, please comment here and we'll move to ready

@tomstuart123 i am unable to replicate this on Safari on iOS (which it looks like is the env in screenshot).

lets keep this in backlog then until then

Close it


Speed up index_chains

The new index_chains function is not exactly fast. At the very least I should paralellize it, but maybe running a profiler will expose some low-hanging fruits.

Still ~3 hours for 8 million chains. Should be possible to do better than that.
But not as high priority anymore as before.

Probably needs a numba solution: https://github.com/scikit-hep/awkward/discussions/2392


apply not removing mounts

If you have a custom mount and then remove it by removing the whole mounts array in the config, running nitro apply will not delete the mount. I even tried running nitro restart, but that didn’t help either.
Steps to reproduce

Add a new mount to the config:
mounts:
  - source: /Users/brandon/Sites
    dest: /nitro/test

Run nitro apply

Verify that the new mount was added successfully.
$ nitro ssh
ubuntu@nitro-dev:~$ cd /nitro
ubuntu@nitro-dev:/nitro$ ls
sites  test
ubuntu@nitro-dev:/nitro$ exit

Delete the mount from the config

Run nitro apply

Expected behavior
The mount should be removed, as it’s no longer listed in the config.
Actual behavior
The mount remains, even after restarting the machine.

@brandonkelly can you try this in on the latest release? I just ran through a few scenarios locally and can't reproduce.

I'm pretty sure this was resolved when we tagged a beta release. I performed the following steps on my local using 1.0.0-beta.2:

Created machine called issue96 (nitro -m issue96 init)
Manually added a mount using nitro -m issue96 edit
Ran nitro -m issue96 apply
Verified the mount exists using nitro -m issue96 info
Manually removed the mount using nitro -m issue96 edit
Run nitro -m issue96 apply
Verified the mount was removed from the config using nitro -m issue96 context and the machine using nitro -m issue96 info

Here is the output of nitro -m issue96 context for step 3:
php: "7.4"
mounts:
  - source: /Users/jasonmccallister/dev
    dest: /nitro/test
databases:
  - engine: mysql
    version: "5.7"
    port: "3306"

@brandonkelly can you verify this on the latest beta release?

Ok, I narrowed this down.
When we remove a mount, multipass is leaving the directory in the virtual machine. The mount is actually removed from the machine - see the attached video link - but the dir staying in the machine causes issue with trying to mount it again.
https://drive.google.com/open?id=1WpS40EwojFAnE-9tySqZntjwlYwt9QYQ

Created a ticket in multipass to get some feedback: https://github.com/canonical/multipass/issues/1527

When unmounting in apply we should rm the directory from the vm.


User specific imports

Users can now add own imports without having to change the source code of pyforest. They can do so by changing  the ~/.pyforest/user_imports.py file, which will be automatically created by pyforest if this file doesn't exist.
User imports take precedence over pyforest standard imports, so user can overwrite lazy-imports if the want to.

Very nice! Thanks!


update carbon charts to 0.41.90

DON'T MERGE. there are style conflicts with the carbon modal itself


Remove Underscore

This is a small piece of the refactoring aimed at the decoupling discussed in #70: While underscore is not a critical dependency, there's nothing we do in this module which required the complexity of the underscore method implementations, and most methods could be easily replaced by native code supported in every version of node since 6.4. (This package is only tested against 8 and up in Travis, for reference). Removing the dependency simplifies future refactoring.
Note: This PR contains both #71 and #72. For an isolated diff of only the changes relevant to the removal of underscore, see kadamwhite/grunt-patch-wordpress#2

@ntwb I believe I've addressed all the feedback; thank you for the initial review, and back to you!


Estimate and filter functions

Dear Dr. Maih,
I'm following TaoZha econometrica example and I have two questions about the estimate and filter functions. To give more context, I'm running line 55 of examples\VariousModels\TaoZha\LWZ_Econometrica2013\master_switch.m.
[ms,filtration]=estimate(m,'data',data,...
        'estim_priors',priors,...
        'kf_presample',3,...
        'kf_init_variance',10,...
        'estim_nonlinear_restrictions',myNormalization);

The first one is a more general question. What algorithm is this function using to produce the filtration?
Now I try to do the filtration directly using the filter function with the same options. When I do this, there are small differences in the smoothed probabilities (see picture). Are these differences expected?
filt = filter(m, 'data', data,...
         'estim_priors', priors,...
         'kf_presample', 3,...
         'kf_init_variance', 10,...
         'estim_nonlinear_restrictions', myNormalization);

I appreciate any help or guidance you can give me.
Thank you,
Javier

Hi Javier,
If the model and the parameters are the same, then there should not be any
difference.
The estimated model is ms, which contains the estimated parameters. That is
the model you should run filtration with. If you use that model, you don't
need to add further options. All the information is already contained in ms.
The algorithm used to produce filtration is a variant of the Kim and Nelson
(1999) filter. The algorithm in RISE is more efficient.
J.
On Thu, Aug 10, 2023 at 3:28 PM javiertasso @.***>
wrote:

Dear Dr. Maih,
I'm following TaoZha econometrica example and I have two questions about
the estimate and filter functions. To give more context, I'm running line
55 of examples\VariousModels\TaoZha\LWZ_Econometrica2013\master_switch.m
.
[ms,filtration]=estimate(m,'data',data,...
'estim_priors',priors,...
'kf_presample',3,...
'kf_init_variance',10,...
'estim_nonlinear_restrictions',myNormalization);
The first one is a more general question. What algorithm is this function
using to produce the filtration?
Now I try to do the filtration directly using the filter function with the
same options. When I do this, there are small differences in the smoothed
probabilities (see picture). Are these differences expected?
filt = filter(m, 'data', data,...
'estim_priors', priors,...
'kf_presample', 3,...
'kf_init_variance', 10,...
'estim_nonlinear_restrictions', myNormalization);
[image: fig_smoothed_probabilities]
https://user-images.githubusercontent.com/92757360/259754625-2ac0565f-d612-4e17-88d4-cefd07014699.png
I appreciate any help or guidance you can give me.
Thank you,
Javier
—
Reply to this email directly, view it on GitHub
https://github.com/jmaih/RISE_toolbox/issues/181, or unsubscribe
https://github.com/notifications/unsubscribe-auth/AATKBTZO3B4SFO7NEL7PE2TXUTOYHANCNFSM6AAAAAA3LQI4MM
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

Thank you so much for your answer. I used the filter function with the estimated model as an input and I got exactly the same output.
Thanks again,
Javier


added utility for .env files

@RitikJaiswal75 pushing this file to repo, so that to use it as dependency.


Restructure

I think this change can be merged rather quickly, since it really only moves functions somewhere else, imports them and renames stuff where necessary.

I tested and it works like before on Kodi 18 and Kodi 19. So, I'm going to merge it.


fix: Invisible ripple effect on the language selector

Hi everyone,
The button to select the langague does have a Ripple effect, but on many screens, it's invisible.
This is easy to solve as a two-lines fix.
untitled.webm

Codecov Report

Merging #3994 (7219c1e) into develop (76762b1) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

@@             Coverage Diff             @@
##           develop    #3994      +/-   ##
===========================================
- Coverage    10.96%   10.96%   -0.01%
===========================================
  Files          265      265
  Lines        13090    13091       +1
===========================================
  Hits          1435     1435
- Misses       11655    11656       +1

Impacted Files
Coverage Δ

...app/lib/generic_lib/widgets/language_selector.dart
0.00% <0.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

thanks @g123k , merging


Livesitetoui

Motivation
Fixes #19
Checklist

[ ] Code follows coding conventions held in this repo
[ ] Automated tests have been added
[ ] Tests are passing
[ ] Docs have been updated (if applicable)
[ ] Temporary settings (e.g. variables used during development and testing) have been reverted to defaults

How to test
Go to home of one of the conferences > click 'Edit in Kentico Cloud' bottom of the page next to sponsors

I think it may be beneficial to complete Issue #1 prior to merging this branch to avoid conflicts.

take a look at the pull for #1 and once you merge it, see whether you can merge this afterwards with no issues


Actually use grains.get default value

Can you please review again? This will tackle all cases (if None, it will be replaced by empty string), then we check for the length (so if originally was empty string, we are also good).

What about?
{% if salt['grains.get']('domain', '')|length > 0 %}
      - CN: {{ grains['domain'] }}
 {% elif salt['pillar.get']('dns:domain', '')|length > 0 %}
     - CN: {{ pillar['dns']['domain'] }}
 {% else %}
     - CN: "kubernetes"
 {% endif %}

Let's play safe @inercia. Added that, thank you.


[BOT PR] to update dependencies of istio

This PR will be merged automatically once checks are successful.
none

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: wattli
Assign the PR to them by writing /assign @wattli in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@istio-testing: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
141a68f08bf315674c7d2c68d41abbc46792dc67
link
/test istio-pilot-e2e-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@istio-testing: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
141a68f08bf315674c7d2c68d41abbc46792dc67
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/e2e-bookInfoTests-v1alpha3.sh
141a68f08bf315674c7d2c68d41abbc46792dc67
link
/test e2e-bookInfo-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


[MapView] Ability to add an MKPolyline to a MapView

I was wondering if it is possible to add an MKPolyline to a MapView's overlay. I couldn't find anything in the docs so thought I should ask/suggest here!
It would also be awesome to be able to use MKDirections  but I guess that's too much?

Ps. Thanks for both react & react native :smile:

I'm not sure the state of who is working on MapView but it is likely no one. PRs for stuff like this are usually welcome.
@brentvatne is MapView community support status yet?

Yeah nobody is actively owning it at Facebook afaik so it's a community thing

The Ads Manager uses parts of Map but not these aux features. So it's sort of community + the book.

@ekonstantinidis Have you worked this at all?  I'll need this functionality for something soon.

No @chris-erickson.. I haven't at all.. Unfortunately not :disappointed:

@chris-erickson if you need PolyLine support checkout https://github.com/mapbox/react-native-mapbox-gl

@browniefed: Thanks - I gave it a solid test run, and it wasn't optimal.  At this time, performance seems like it needs work, and the API isn't too flexible for continually adding new coordinates to a PolyLine.  You have to redraw the map on any new point, as best I can tell, when live tracking your path.  I might just plow forward to get this working with iOS provided API's.

I am interested in this as well - and happy to work on a PR for it.
My proposal would be to add Polyline support as another type of annotation.  Ala:
this.state.annotations = [
{
"coordinates": [
{ "lat": 35.5, "lon": -5.5 },
{ "lat": 35.6, "lon": -5.6 },
...
],
"type": "polyline",
"strokeColor": "#FF0000",
"strokeWidth": 3,
"strokeAlpha": 0.5
}];
Annotations would be by default "placemarks" so as to be backwards compatible, and you would explicitly need to define other types, like "polyline" above.
@brentvatne @ide If you can confirm this proposal would be acceptable as a PR I can work on it.

If we go with something it should follow geojson spec!

@timfpark That's similar to what MapBox uses, and seemed fine when I used it.  Hopefully the native implementation is more performant though.  Every annotation addition redrew the map, which resulted in a noticeable flicker.  I'd be happy to help out/test it.

Added via https://github.com/facebook/react-native/commit/8911b72d9e78d78b6f8eb99efe21b1205047fd16


DXVK is not compatible w/ wine >=6.8

I've played Rocket League for a while now. I obviously use the Heroic Launcher, and since ~4 days, Rocket League does not launch anymore, as the terminal screenshot shows below. It is not a problem with Rocket League alone, because I have tried with other games as well – the same log appears, no matter the game. I also asked in winehq, and they said it was a DXVK issue and not a wine one, so that's why I'm asking here.
System information

GPU:AMD® Radeon(tm) vega 3 graphics
Driver:00:00.2 IOMMU: Advanced Micro Devices, Inc. [AMD] Raven/Raven2 IOMMU
Wine version: 6.8
DXVK version: 9

Apitrace file(s)

Put a link here

Log files

d3d9.log:

d3d11.log:

dxgi.log:

This isn't a DXVK issue. Your Vulkan driver setup is broken.

Probably just lavapipe issues again... nothing to do with wine 6.8.
We'll have a new release soon-ish that blacklists lavapipe for good, because somehow games keep picking that over actual GPUs for no real reason. In the meantime, use DXVK's DXGI, use DXVK_FILTER_DEVICE_NAME, or grab this build.

I also have problems with DXVK on wine 6.8>= . It occurs when trying to launch Steam either on Intel or Nvidia GPU. The logs are in here . Logs are for two graphics cards and with and without dxvk. Problem also manifests in other programs like Foobar2000 by crashing.

@maxiking01 and what problems do you have exactly?

The main issue is steam hangs in main window when I install dxvk. There aren't any crashes. It affects other programs as well. In case foobar2000 app crashes. When I don't install the dxvk steam starts normally. I looked at logs in both cases, but I couldn't notice anything suspicious. I'll provide additional logs if you need it.

Steam works fine here with wine-tkg 6.9 and it worked fine with 6.8.


Added Spotless Script to hack/run.sh

Currently, spotless formatting is triggered either when someone runs ./hack/update-codegen.sh or manually uses spotless. To simplify the process for contributors, this commit abstracts the formatting step away from contributors and enables them to run ./hack/run.sh format-java to automatically format all Java code.
#3331

/assign @Cali0707

/ok-to-test

/cc @creydr

/retest-required

/test upgrade-tests

/retest-required

/test channel-integration-tests-ssl


proxy_connect: connection error while connecting to upstream

nginx-1.17.7
proxy_connect_rewrite_101504.patch
error_log：
2020/01/12 17:47:32 [crit] 47561#47561: *157 connect() to [240e:83:205:59:0:ff:b09b:159e]:443 failed (99: Cannot assign requested address) while connecting to upstream, client: <IP_ADDRESS>, server: , request: "CONNECT www.baidu.com:443 HTTP/1.1", host: "www.baidu.com:443"
2020/01/12 17:47:32 [error] 47561#47561: *157 proxy_connect: connection error while connecting to upstream, client: <IP_ADDRESS>, server: , request: "CONNECT www.baidu.com:443 HTTP/1.1", host: "www.baidu.com:443"
proxy.conf
server {
listen 8090;
resolver <IP_ADDRESS>;
resolver_timeout 5s;
proxy_connect;
proxy_connect_allow 443;
proxy_connect_connect_timeout 10s;
proxy_connect_read_timeout 10s;
proxy_connect_send_timeout 10s;
location / {
proxy_pass $scheme://$host$request_uri;
proxy_set_header Host $host;
proxy_buffers 256 4k;
proxy_max_temp_file_size 0;
proxy_connect_timeout 30;
}
access_log /var/log/nginx/proxy_access.log main;
error_log /var/log/nginx/proxy_error.log;
}
Access on another machine
[root@zabbix ~]# curl https://www.baidu.com
curl: (56) Received HTTP code 502 from proxy after CONNECT
Sometimes normal, sometimes 502

You may remove
resolver_timeout 5s;
proxy_connect_connect_timeout 10s;
proxy_connect_read_timeout 10s;
proxy_connect_send_timeout 10s;
proxy_connect_timeout 30;

and try again

I deleted a few lines above, still a 502 error. Not very stable.

i am having the same issue and currently debugging it... i disabled the timers and it seems to work, but testing since 10 min... you may add an nginx worker as well... how many do you have ?

worker_processes  1;
I set one

worker_processes                                        10;

worker_processes 8;
sometimes 502，only one computer is currently testing

What is your configuration file？What is the version？

nope does not look to be solved yet...
83.x.x.x - - [14/Jan/2020:01:52:13 +0000] "CONNECT www.google.com:443 HTTP/1.1" 502 0 "-" "Mozilla/5.0 (Windows NT 6.1; rv:60.0) Gecko/20100101 Firefox/60.0"

2020/01/14 01:52:19 [crit] 25400#0: *71 connect() to [2a00:1450:4001:80b::2004]:443 failed (99: Cannot assign requested address) while connecting to upstream, client: 83.x.x.x, server:

proxy.server.com, request: "CONNECT www.google.com:443 HTTP/1.1", host: "www.google.com:443"

2020/01/14 01:52:19 [error] 25400#0: *71 proxy_connect: connection error while connecting to upstream, client: 83.x.x.x., server: proxy.server.com, request: "CONNECT www.google.com:443 HTTP/1.1", host: "www.google.com:443"

83.x.x.x - - [14/Jan/2020:01:52:19 +0000] "CONNECT www.google.com:443 HTTP/1.1" 502 0 "-" "Mozilla/5.0 (Windows NT 6.1; rv:60.0) Gecko/20100101 Firefox/60.0"

2020/01/14 01:52:22 [crit] 25400#0: *75 connect() to [2a00:1450:4001:825::2003]:443 failed (99: Cannot assign requested address) while connecting to upstream, client: 83.x.x.x, server: proxy.server.com, request: "CONNECT www.gstatic.com:443 HTTP/1.1", host: "www.gstatic.com:443"

2020/01/14 01:52:22 [error] 25400#0: *75 proxy_connect: connection error while connecting to upstream, client: 83.x.x.x, server: proxy.server.com, request: "CONNECT www.gstatic.com:443 HTTP/1.1", host: "www.gstatic.com:443"

i am also having an other critical issue where the connect function is not closed and lead to a buffer overflow...
yeah it look like it need some works...

i may find something here... do you have both ipv6 and v4 support on your proxy ?

Only ipv4，ipv6 is disabled. But I don't know why ipv6 is in the log

yeah same here only ipv4, v6 disabled.... i guess that we would need to enable ipv6 or find why ipv6 is coming along... i guess this is a DNS related thing i am checking that...

we are not alone lol
https://serverfault.com/questions/527317/disable-ipv6-in-nginx-proxy-pass

i was tight look like a dns thing
 resolver <IP_ADDRESS> ipv6=off;

yep, this was it, confirmed here...
close the issue if it did work for you as well

yes。thankyou

Hello I have this configuration:
resolver <IP_ADDRESS>  ipv6=off;
But still see those errors
`2020/01/14 01:52:22 [crit] 25400#0: *75 connect() to [2a00:1450:4001:825::2003]:443 failed (99: Cannot assign requested address) while connecting to upstream, client: 83.x.x.x, server: proxy.server.com, request: "CONNECT www.gstatic.com:443 HTTP/1.1", host: "www.gstatic.com:443"
2020/01/14 01:52:22 [error] 25400#0: *75 proxy_connect: connection error while connecting to upstream, client: 83.x.x.x, server: proxy.server.com, request: "CONNECT www.gstatic.com:443 HTTP/1.1", host: "www.gstatic.com:443"`
Any help? Using tengine-2.3.2

thank you


Lock icon not the best for readonly files

Testing #133743
I do not like the use of the lock icon for readonly files because:

We already use the Lock for Locking Output
Lock does not really represent read only for me
Lock icon makes me want to click it to unlock it. And this decoration is not clickable (unlike the Output lock button)

By googling "readonly icon" I found the following, which is more clear to me.
Did we consider using the crossed out pencil?

I am happy to change it to anything we can come up with but personally feel this icon is good, esp. since other IDEs also seem to be using such an icon.


fix: calico v3.22.4 config template image registry is not set

Signed-off-by: qinyer<EMAIL_ADDRESS>
What type of PR is this?

/kind bug
What this PR does / why we need it:
Which issue(s) this PR fixes:

Fixes #163
Special notes for reviewers:

Does this PR introduced a user-facing change?

Additional documentation, usage docs, etc.:

/lgtm
/approve


TPUEstimator uses CPU during generation

I am running a patched code on Ubuntu Docker with NVIDIA GPU support on an AMD Threadripper box with a Titan Xp card. The code does not engage GPU and entire inference runs on a CPU. The generation does work, but it is slow. What should I do to engage the GPU?

I'd love some more details here.
Did you use tensorflow-gpu==1.14? Are you able to run other CUDA-compatible codes in your environment? Can you paste your Dockerfile?

Seems like the problem was solved; reopen if not.


How to start openwebrtc ?

i managed to install openwebrtc by doing this
./cerbero-uninstalled -c config/linux.cbc package -f openwebrtc .  then i did
/cerbero-uninstalled -c conf/linux.config shell.
Now how do i start openwebrtc ? what is the next step ?

What are you trying to build?

https://github.com/EricssonResearch/openwebrtc/wiki/Running-and-Testing

well i managed to build on linux host with
./cerbero-uninstalled -c config/linux.cbc bootstrap

and it builds perfectly with no errors. and i am able to run the web sample
openwebrtc-examples/web/

over ssl too. but when i try to connect from my android to the web i get sdp error and the app crashes but with your own demo sdp seems to work fine.
http://demo.openwebrtc.org:38080/

how can i fix this sdp error ? what shouid i build or do ?
Thanks you

For the Android device, do you run the Chrome browser?

I run the native call which is in the examples. And Google Chrome works without a problem

@jamesbond12 to run openwebrtc-examples/web/ you need openwebrtc sources in specific location, because sdp.js is a symlink to sdp.js -> ../../../openwebrtc/bridge/client/sdp.js. This is what cause your problem. Easy way to fix that is:
cd openwebrtc-examples/web/
rm -rf client/sdp.js
wget https://raw.githubusercontent.com/EricssonResearch/openwebrtc/master/bridge/client/sdp.js -O client/sdp.js
nodejs channel_server.js


Listing succeeded tests

Right now, seems that this action is listing tests with errors, however, as a build user, I want to be able to review which tests were effectively analyzed so that it would be great if tests that ended with success will be also printed but with green indicator ;) It would be nice to have such an input parameter that will control that. Still, the way in which the action is working actually could remain as default.
I've got only:

I wonder how good that is gonna scale. as there are rate limits to keep in mind. and let's say you have 1000 tests, updating github with all of them will most likely fail due to the rate limit.

Hmm still having it as option to test if configured everything correctly might be considered useful. Now it is kinda black box 😁

Summary is rendered as markdown on the overview page. As a work around I create a markdown document with a table listing all tests and set this as a summary.
It's hacky as the markdown is multiline but output variables must be single line (therefore the conversions below).
  - name: Create Test Report Summary
    id: test_summary
    run: |
      # generate a markdown document called results.md

      export SUMMARY="$(cat results.md)"

      # we need to do some conversions in order to get a one-liner:
      SUMMARY="${SUMMARY//'%'/'%25'}"
      SUMMARY="${SUMMARY//$'\n'/'%0A'}"
      SUMMARY="${SUMMARY//$'\r'/'%0D'}"

      # save document in output variable which can be used in action-junit-report
      echo "::set-output name=summary::$(echo "$SUMMARY")"

  - name: Publish Test Report
    uses: mikepenz/action-junit-report@v2
    if: always() # always run even if the previous step fails
    with:
      report_paths: 'results.xml'
      check_name: Test Report
      fail_on_failure: true
      require_tests: true
      summary: ${{ steps.test_summary.outputs.summary }}

This is how it looks like:

I left out the generation of the markdown as my original report is from cargo test -- --format=json > results.json ... but just in case somebody has this same setup (this kind of makes it even more hackish, sorry :D )
      # cargo output has some nasty combination of escape characters which confuse bash
      sed -i.bak -e 's/\\"//g' results.json

      echo "|  |test  |duration|" >  results.md
      echo "|--|------|--------|" >> results.md
      while read line
      do
          echo "${line}"|jq -r 'if .event != "started" and .type != "suite" and .event == "ok" then ["|","✅|", .name,"|",(.exec_time|tostring),"s","|"]|add else empty end'
          echo "${line}"|jq -r 'if .event != "started" and .type != "suite" and .event == "failed" then ["|","❌|", .name,"|",(.exec_time|tostring),"s","|"]|add else empty end'
          echo "${line}"|jq -r 'if .event != "started" and .type != "suite" and .event == "ignored" then ["|","🙈|", .name,"|",(.exec_time|tostring),"s","|"]|add else empty end'
          echo "${line}"|jq -r 'if .event != "started" and .type != "suite" and .event == "timeout" then ["|","⌛|", .name,"|",(.exec_time|tostring),"s","|"]|add else empty end'
          echo "${line}"|jq -r 'if .event != "started" and .type != "suite" and .event == "allowed_failure" then ["|","🤷|", .name,"|",(.exec_time|tostring),"s","|"]|add else empty end'
      done < results.json >> results.md


Cross-platform scripts. Fixes #305

Let see if Travis pass. Can someone on OS X test it as well? Also another win32 wouldn't be bad!
If it works I can extend it for all scripts.

Looks awesome. If the tests pass, I'll pull it down, try it out and let you know. If that works, then you can update the PR to do this for all the scripts. That's awesome!

Ah! We're really close. It totally works, but it's a bit annoying. The output looks like this:
npm test

npm run build

When it should look like this:
npm test

npm run build

Also, if we could make a more generic function that would be great. There's a lot of duplicate code in those two script files.

The output looks like that because stdout is streamed directly to console.log.
Maybe directly using process.stdout can fix it.
I'll try again tomorrow ASAP, as I will optimize the code for all scripts :)

I fixed it accordingly, but the introduction of --config $npm_package_webpack breaks the script, how should be handled?

Ok, let me know if this works for you, so I can extend it for most scripts :smile:

This works awesome! I have an idea though... One sec...

Why don't we create a library for this? I want to use this in other projects. Here's the API I envision...
I install your library as a dependency. We'll call it better-npm-run for now... Then in my package.json, I do this:
{
  "scripts": {
    "build:dist": "better-npm-run",
    "test": "better-npm-run"
  },
  "betterScripts": {
    "build:dist": "NODE_ENV=development webpack --config $npm_package_webpack --progress --colors",
    "test": "NODE_ENV=test karma start"
  }
}

Or something like that? It would just be nice to have all my scripts right in the package.json.
And the library would manage ensuring that setting environment variables work cross-platform. What do you think?

Sounds good! Let me create a repo and a beta version of it :+1:

Would this kind arrangement look ok? or is it too verbose?
{
  "scripts": {
    "build:dist": "better-npm-run",
    "test": "better-npm-run"
  },
  "betterScripts": {
    "build:dist": {
    	"command": "webpack --config $npm_package_webpack --progress --colors",
    	"env": {
    		"NODE_ENV": "development"
    	}
    },
    "build:prod": {
    	"command": "webpack --config $npm_package_webpack --progress --colors",
    	"env": {
    		"NODE_ENV": "production"
    	}
    },
    "build": [
	    {
	        "run": "build:dist"
	    },
	    {
	        "run": "build:prod"
	    }
    ],
    //...
    "test": {
    	"command": "karma start",
    	"env": {
    		"NODE_ENV": "test"
    	}
    }
  }
}

Hmmm... That is a bit verbose, and it prevents me from doing this: NODE_ENV=something some-command && NODE_ENV=somethingElse some-other-command though there's a work-around... Hmmm... Probably would be fine to start with what you have :+1:

Sorry, by the way, I just fixed up a thing or two with package.json so that's why this can't merge anymore :-(

Okey, already created a draft version at github.com/benoror/better-npm-run.
Right now I don't have any project that could use it, but if you think it has potential to be used by angular-formly or anything-else in the future let me know.

Awesome! I'll take a look at it!

Hey man, just tried it out on my new library and it worked great for me. I didn't even notice a difference. :+1:

Hey that's great @kentcdodds! :smile: considering that I wrote the draft on-the-go this afternoon.
Anyway, please let me know if you have a particular use-case or idea for extending its functionality, I opened a general issue for brainstorming: https://github.com/benoror/better-npm-run/issues/1
Regards!

Thanks for building that! I've implemented it. Please test it out :-) 6fbaea258a1f3c5737f7d4276ad49c2a065988e3


WIP: Remove Aviation House IPs from the whitelist

According to our IT wiki[1] these were from Aviation House and have
been entirely shutdown.
[1] https://sites.google.com/a/digital.cabinet-office.gov.uk/gds-internal-it/news/aviationhouse-sourceipaddresses
What
Describe what you have changed and why.
How to review
Describe the steps required to test the changes.
Who can review
Describe who can review the changes. Or more importantly, list the people
that can't review, because they worked on it.

Closing this as it will be incorporated into https://github.com/alphagov/paas-cf/pull/1100


<EMAIL_ADDRESS>download via aria2 failed

this was the output,
PS C:\WINDOWS\system32> scoop install whatsapp
WARN  Scoop uses 'aria2c' for multi-connection downloads.
WARN  Should it cause issues, run 'scoop config aria2-enabled false' to disable it.
Installing 'whatsapp' (2.2123.7) [64bit]
Starting download with aria2 ...
Download: 06/25 22:16:40 [ERROR] CUID#8 - Download aborted. URI=https://web.whatsapp.com/desktop/winDownload: Exception: [AbstractCommand.cc:313] errorCode=1 Network problem has occurred. cause:A sockDownload: Download Results:
Download: gid   |stat|avg speed  |path/URI
Download: ======+====+===========+=======================================================
Download: 2c6cc6|ERR |       0B/s|C:/Users/souvik8/scoop/cache/whatsapp#2.2123.7#https_web.whatsapp.com_desktop_windows_release_x64_WhatsApp-2.2123.7-full.nupkg_dl.7z
Download: Status Legend:
Download: (ERR):error occurred.
Download: aria2 will resume download if the transfer is restarted.
Download: If there are any errors, then see the log file. See '-l' option in help/man page for details.

ERROR Download failed! (Error 1) An unknown error occurred
ERROR https://web.whatsapp.com/desktop/windows/release/x64/WhatsApp-2.2123.7-full.nupkg#/dl.7z
    referer=https://web.whatsapp.com/desktop/windows/release/x64/WhatsApp-2.2123.7-full.nupkg#/
    dir=C:\Users\souvik8\scoop\cache
    out=whatsapp#2.2123.7#https_web.whatsapp.com_desktop_windows_release_x64_WhatsApp-2.2123.7-full.nupkg_dl.7z

ERROR & 'C:\Users\souvik8\scoop\apps\aria2\current\aria2c.exe' --input-file='C:\Users\souvik8\scoop\cache\whatsapp.txt' --user-agent='Scoop/1.0 (+http://scoop.sh/) PowerShell/5.1 (Windows NT 10.0; Win64; x64; Desktop)' --allow-overwrite=true --auto-file-renaming=false --retry-wait=2 --split=5 --max-connection-per-server=5 --min-split-size=5M --console-log-level=warn --enable-color=false --no-conf=true --follow-metalink=true --metalink-preferred-protocol=https --min-tls-version=TLSv1.2 --stop-with-process=4632 --continue --summary-interval 0

turned off aria2, then it worked just fine.

Network error
Site is blocked (Great Firewall of China, Corporate restrictions, ...)
Antivirus settings could block URL or block downloaded file
Proxy configuration

network is fine,
In India, so firewall is not great of an issue,
absolutely no antivirus or defender,
no proxy