Allow failed requests to count twice

Essentially, the current options skipSuccessfulRequests and skipFailedRequests take boolean values which modify the counting behavior by either adding 0 or 1 to the counter. This could be taken a step further:
Introduce two new options:
successfulRequestWeight: number
failedRequestWeight: number

Deprecate the existing options:
skipSuccessfulRequests = true -> successfulRequestWeight = 0
skipSuccessfulRequests = false -> successfulRequestWeight = 1
skipFailedRequests = true -> failedRequestWeight = 0
skipFailedRequests = false -> failedRequestWeight = 1

Update the stores (in a backward-compatible way):
increment: (key: any, cb: (err: Error | null, current: number, resetTime: number) => unknown, amount: number = 1)
decrement: (key: any, amount: number = 1)

This would allow anyone to configure just how much successful or failed requests contribute towards the limit, while still keeping the options simple.
If you'd like this (or something similar), I'd be happy to provide a pull request for express-slow-down and/or express-rate-limit

Hey, sorry for the slow response, somehow notifications got turned off for this repo.
That's a cool idea, but I'm a little hesitant on it just because of the complexity it adds. I think some of the other rate-limiters out there do support request weights, though, so that might be a better choice in your case.

Going to go ahead and close this, since I don't think we're going to implement the feature.


Fix icon alignment

Align large icons in userstudy screens.
If not feasible, rollback to smaller icons.

@Turmac @hckum Things to address regarding icons:

#34
I think both the ID column and the name column use the same icon generation function. Which I think is creating problems. Not sure though. How much width does a number occupy as opposed to a character? Is it the same?

Whenever an icon is in the start or end, the alignment is awkward.

Yes, ID and name are using the same display function. At my environment character and digit has same width.


Add basic tox setup for the testing suite

I played a bit with the set of pytests to familiarize
myself with the code, and while working on it I came up
with this basic tox setup. This offers some benefits:

handling of python dependencies via virtual environment
(not a lot right now but they may be more in the future).
forcing tests to run with Python 3.7, or fail otherwise
(tried to run the suite on Debian Stretch with 3.5 I got
errors for subprocess.run for example).
Not sure if it makes sense or not, it doesn't change much
but in my opinion tox is a really nice to run test suites!

Another question that I have is where httpd logs its stderr when running the tests.. I got the trick of using apachectl -d test_directory but while debugging some issues that I had I didn't find where to check httpd logs (checked in the localhost "usual" places, plus in the output of pytest).

Thanks for the pointer to tox. As I understand it, it helps testing your python development in various python runtime setups, isolated from your local system installation. That's neat.
In mod_h2/mod_md test suite I do not see the benefit yet in bringing in another dependency. It is not python code we test, so varying the python versions brings no benefit. Or am I missing something?
If the test suite has problems with ancient python3 versions, it should check at startup. That's definitely helpful. +1 for finding this!

Yes yes my point was not to test multiple python version, but just to force the usage of one (in this case, python 3.7) and also run the test suite using a python virtual environment (rather than relying on system dependencies etc..). I had a problem running the test suite with 3.5 because IIUC the subprocess.run call that is used changed between 3.5 and 3.7, but I might have not got it right :)
Anyway, feel free to discard this pull request, I was only reviewing our (very nice) testing suite to see if it could have been re-used or proposed for httpd :)

I do not want to discard it. I think you have a point. I am just not certain how to best apply this. ;-)
What is the impact for someone sitting on a 3.6 system when she runs our test suite that requires a virtual env of 3.8? Will it then fail?

So in theory if somebody runs the test suite now with python < than 3.7 should get some failures due to parameters not recognized in subprocess.run, meanwhile with tox it should get a specific error that python3.7 is not available. If what I wrote is right, we could simply refactor subprocess.run to use the API available in 3.6, so everybody with any version of python3 will be able to run the suite. In theory tox can be configured to run on several versions of python, the if we add 3.4 and 3.6 the worst that can happen is that the user will see "python 3.x not present skipping.." until a python version is found. Otherwise fixing subprocess.run and keeping the current setting should do the trick :)


Is this a good time to think about the admin?

Hi.
This is not an issue. It is just a suggestion from an end user. I think that in the last meeting Sébastien said this is a valid channel for that.
Maybe now that you are questioning many parts of Orchard 1 it's a good time to think about how the admin should like in Orchard 2. So that in the case that the desired UI requires something implemented in a specific way you can know that in advance.
Orchard is a very developer friendly CMS, and I love that. But maybe we are a little biased here.
Probably it's time to devote some of the (precious) core developers time to polish-rethink the UI. After all, the user that will spend more hours in front of a Content Management System is the content manager. And the content manager probably does not know anything about extensibility points, shapes, json, etc..
And while the Orchard1 user experience was OK 5 years ago, right now maybe It's a little outdated.
In my particular case I'd like to see:

Fewer reloads ( maybe even a SPA ? ).
Fewer clicks needed to perform most common editor tasks.
More consistency in different parts of the UI, at least in the Core Modules. I know that Orchard is a very modular System and this makes difficult to achieve consistency in the UI, but now that we now what the core modules are going to be, it is possible to unify the look and feel: same buttons, same positions, same listboxes, "same everything" across admin pages :).
Responsive layout.

And finally one more suggestion about the workflow for this task: First let's do a technology agnostic prototype, then choose the right technology to implement it. I mean, first use Photoshop-Painter-whatever , then use Angularjs-Knockout-React-whatever, bootstrap-foundation-whatever, less-sass-whatever :)
This is what this people did for it's CMS and maybe the same will work for us (I mean the workflow, not the nodejs thing).
Again, I love Orchard, and It's wonderful that you are adapting it so fast to the coreclr.

My pet peeve: integrate workflow into everything to make it possible to replace processes, and implement custom logic easily. For example, you could imagine integrating a validation workflow right into the content creation process.

Also to use dynamic forms for define admin views would be a great advance for the ease of use.

I'm learning Drupal 8 and its theming system and think Drupal's take on theming could be good inspiration for improving consistency and visual-modularity (just made that up) in Orchard 2.
Also, thinking of the admin UI as an example of how to build anything in Orchard 2 would be beneficial. Make it something that site builders can imitate and is consistent with how theming happens outside the admin UI will help improve consistency both within and without the admin UI, benefiting the greater developer and designer community.
This is something I am interested in helping with, and have the experience to be helpful.

Would you mind sharing your ideas during a meeting with some demos? Whatever level you have reached is fine by us.
Even like during triage in 30 minutes

(I deleted my last post, clarified, and posted as this one so my changes wouldn't be missed. Sorry not trying to spam and not sure what the best etiquette is in that case.)
I think Drupal 8's take on organizing theme elements could be good inspiration for improving UI consistency and modularity in Orchard 2.
Also, thinking of the admin UI as an example of how to build anything in Orchard 2 would be beneficial. Make it something that site builders can imitate and is consistent with how sites are themed inside and outside the admin UI will help improve consistency everywhere, benefiting everyone.
I know I'm new here but I'm particularly interested in helping with consistent, compliant, accessible, and modular HTML5 and CSS in Orchard 2. Please reach out to me if you would like my help.

I'm actually working on the new admin theme, if you want to chat about it with us you can get into sfmskywalker/Orchard Gitter channel. Any kind of help is always appreciated.

SPA-framework and forms agnostic admin UI. Allow the theme to determine read and edit UI.
For example: The default admin theme might take the simplest approach and use HTML forms with server-side validation. Another theme could implement the same pages using react/ang/ko/whatever and submit JSON AJAX payloads to the same end-point via content negotiation.

Extendable content types.
Example: The User content type that comes with core consists of the minimum number of fields needed. Modules (in code), administrators (in browser), even themes if it makes sense, can add additional fields to the User content type that will be rendered in the appropriate places.

A content type can be created in code or visually in browser.
A created content type can be extended with code or administratively in browser.
In general, themes use content type information to render lists, read and edit UI, etc.

@jeremycook not sure what you're suggesting here, as this is pretty much what Orchard has always been doing. Can you explain?
On admin themes, keep in mind that most of the admin templates actually come from modules. Putting too much burden on the admin theme means limiting module extensibility. If the admin theme, on the other hand, concerns itself mostly with generic styling, and behavior is still provided by modules, then the theme author doesn't have to adapt to a fixed set of modules.

@bleroy sorry if I say silly things, I have little Orchard 1 experience.
If Orchard content types handle the behavior I described than awesome, and I look forward to trying it all out in Orchard 2. I take it the frowny face was because my content type request was redundant.
I'm not dismissing modules providing their own templates. I'm simply looking for more flexibility and consistency for theme and module makers:

The ability for theme designers, front-end folks, site-builders, and so on to have a great deal of natural control over not just visuals but behavior.
If a content type can fully describe the elements of the UI then module builders need not provide templates in many cases, or the templates can be quite bare with most of the rendering driven by the content type (like MVC EditorForModel() except I hope for something better).

Rendering driven by content type enables module developers to write less html/cshtml/etc. when their lists, views and forms are pretty standard, and allows theme designers to not have to worry about specific modules, and instead use the standard content type model to render UI.
I can't imagine that what I'm suggesting would limit module extensibility, but I'm all ears. It may be the case I don't know what "module extensibility" means to you.

@jeremycook the emoticon stands for "confused" (hover over it). Theme developers can override any shape template, so they do have control over behavior. It's just that it's a tricky road to take. Your point #2 is a good one, and in fact, there's a Forms API in Orchard 1 that enables modules to do away with templates in lots of cases, but not all. When a module does something a little bit more original (say, a goelocation module giving a map coordinate editor), it will always need custom templates. If the theme makes too many assumptions, it may cause degraded experiences for those "unexpected" modules. Also keep in mind that even basic building blocks such as parts and elements are provided by modules. I think Orchard 1 was providing exactly the right balance for this, so it's not quite clear what you're proposing.

@bleroy Thank you. All good points. It is sounding like most/if not all of what I have proposed can already be done in Orchard 1 and can be expected in Orchard 2. I have other thoughts and questions, but I'll wait until I have a chance to use Orchard 2, and familiarize myself more with the Orchard 1 features in 2.

It's been a little while since I worked with Orchard regularly, but one of my pet peeves was the inconsistency of the styling, classes etc of the Orchard Admin theme. I understand how it got to that point, and it is a community project, so I never complained. I did spend some time thinking about it though.
Having recently worked on several SPA projects, I've learnt that they quickly get out of hand and can be more trouble than what they're worth.
The admin really just needs to be consistent; for that, you need a comprehensive UI library which module authors can leverage without having to bring in their own scripts and styles (or at least minimise the amount required). There are many, many admin UI themes out there. Many of them are extremely comprehensive, and most of them are built on Bootstrap. For better or for worse, Bootstrap does provide a consistent UI, good documentation and there are few developers who haven't used it.
In addition, using a platform such as Bootstrap would make it quite simple to "drop in" a different theme depending on your use-case.
TL;DR
Let's not reinvent the wheel, or make this overly complicated. Admin UI has been done to death. Pick the most comprehensive (which has the right licensing) and move on to more important things.

Closing it for the moment.
Let's continue on other specific threads like #149, #468, ...


I have just added my repo file

okay!

Hlo! I have just changed the name of file as you said. Thank you for the guidence 👍


$toInt aggregation operator unavailable?

Is $toInt aggregation operator available?

let's say our document has already a 'price' (decimal) field, we can extract some new fields:
$builder = $dm->createAggregationBuilder(OurDocument::class);

// Caution: the single quotes are absolutely required here to allow the use of the $ sign:

$builder->addFields()
             ->field("to_int")
             ->expression(  ['$toInt' => '$price' ]  )
            ->field("double")
            ->expression(  ['$multiply' => ['$price', 2 ] ]  );

$result = $builder->execute();

All. available operators are detailed here : https://docs.mongodb.com/manual/reference/operator/aggregation/

That would make a nice addition to docs actually.

Awesome, thanks!

Using expression is the preferred way to use new operators that don't have a native method yet.
As for the $toInt operator itself, we will work on aggregation improvements in 2.1, which includes adding all new operators and new stages added since we last worked on aggregation here.


TypeScript bug in Proxy handler method

I made a video on this bug:
https://www.useloom.com/share/5f89ee1de6f84abbbf9703af3b34c00c
Code
  t.$inject = new Proxy(self.__inject, {
       set(target, property, value, receiver){
          throw new Error('cannot set any properties on t.$inject (in test cases).');
       }
  });

Expected behavior:
Expect throw to supercede API requirements
Actual behavior:
Need to return a boolean even after a throw call.
Here is a screenshot of the error message:

Duplicate of #16874.

cool +1


Project settings view

Description
The view is implemented with the intended functionality. There are slight differences between this implementation and the design - I tried to keep it consistent between the components and avoid unnecessary complications at this point.
The deletions do not trigger confirmation dialog. It seems unnecessary (as saving the changes requires clicking another button), but I might be mistaken on that part.
Linked issues
closes #197

@LostInStatic I have just fixed some leftover typing issues on the back-end that I noticed during the review but other than that looks great. 🚀


AUI-1815 Scroll shouldn't change while adding columns in layout builder

Just started reviewing :) :octocat: Sent from GH.

@mairatma updated!

Just started reviewing :) :octocat: Sent from GH.

Pull request merged.


cross_references.txt is 19 months out of date

The latest cross_references.txt from http://www.openbible.info/labs/cross-references/
is dated 2017-09-04
Your copy is dated 2016-02-01.

I'll see if anything needs to be updated, thank you.


Highlight negatives fix

Code cleanup, bug fixes and hopefully a Safari fix for #189.

I haven't been able to check Safari just yet, due to an issue (https://github.com/toolkit-for-ynab/toolkit-for-ynab/commit/966ca7599f9cb51d9f2414bda5129d6aa5781ae7), but once that gets resolved I'll double check. I'm crossing my fingers that my changes will take care of Safari's issues.

I'd like to hold off merging this until we handle currency formats a bit better. Will be a really quick fix. We'll release soon after I can pull these fixes in as I'm sure they're sorely needed.

Thanks. I've aded the currency format fix.

Awesome, thanks!


[compose-setup]: Use the current DOCKER_HOST value if already exists

The script is forcing the DOCKER_HOST value as the hostname of the current machine, but some people use a custom DOCKER_HOST.
This small fix will keep the DOCKER_HOST value if already exists or replace with the hostname -f if not.

Cool, thanks!


malloc: *** error for object when running on iPhone 6 (iOS 8.2)

I don't get the error when running in the Simulator on 8.2, bu when I build on my iPhone 6 (also running iOS 8.2) I get the following error.
malloc: *** error for object 0x170054100: Invalid pointer dequeued from free list
*** set a breakpoint in malloc_error_break to debug
XCode is also pointing to the following method :
//MARK: - Comparable
extension JSON: Comparable {}
public func ==(lhs: JSON, rhs: JSON) -> Bool {
switch (lhs.type, rhs.type) {
case (.Number, .Number):
    return (lhs.object as NSNumber) == (rhs.object as NSNumber)
case (.String, .String):
    return (lhs.object as String) == (rhs.object as String)
case (.Bool, .Bool):
    return (lhs.object as Bool) == (rhs.object as Bool)
case (.Array, .Array):
    return (lhs.object as NSArray) == (rhs.object as NSArray)
case (.Dictionary, .Dictionary):
    return (lhs.object as NSDictionary) == (rhs.object as NSDictionary)
case (.Null, .Null):
    return true
default:
    return false
}

}
and more precisely to line :
case (.String, .String):
return (lhs.object as String) == (rhs.object as String)

Ok

This issue has been inactive for a while so I'm gonna go ahead and consider it fixed. Please let us know if you want to reopen it.


Need help in debugging strange situation

Hi there!
Unfortunatelly, I'm unable to prepare minimal-reproducible config for the issue, I'm experience, so I need help in investigation.
If I set enable_autocmd in setup{} to true, I'm getting strange error when I open some file types (like "dockerfile" or "sh")
The error is:
Error detected while processing CursorHold Autocommands for "<buffer=1>":
Error executing lua callback: ...-commentstring/lua/ts_context_commentstring/internal.lua:126: attempt to index local 'match' (a function value)
stack traceback:
  ...-commentstring/lua/ts_context_commentstring/internal.lua:126: in function 'calculate_commentstring'
  ...-commentstring/lua/ts_context_commentstring/internal.lua:86: in function 'update_commentstring'
  ...-commentstring/lua/ts_context_commentstring/internal.lua:33: in function <...-commentstring/lua/ts_context_commentstring/internal.lua:32>

It seems like setting enable_autocmd is not enough by itself, and maybe something in my config is related as well, because it does not reproduce with minimal config from this repo.
But still, it reproduces every time with my config (if this option is enabled). And I'm not sure, what plugins/settings shuld I look for to add to the repro-config to make error reproduce there.
Can you give some advices?
Or, maybe, another ideas of the reasons why match can become a function instead of a table there?

I ran into this same issue and did some debugging. The issue is here:
https://github.com/JoosepAlviste/nvim-ts-context-commentstring/blob/1277b4a1f451b0f18c0790e1a7f12e1e5fdebfee/lua/ts_context_commentstring/internal.lua#L118-L123
The issue happens when language_config is a string and node_type is the name of a string method e.g., char.  Then doing language_config[node_type] returns the string function like so:
("")["char"] -- returns the string.char() function

The reason this only breaks sometimes is because if the node_type doesn't match the name of a string method then lua returns nil as expected:
("")["notastringmethod"] -- returns nil

Hey! Thanks for the debugging @1dr0z, that was exactly what was happening. It's especially noticeable if you use the autocmd because then we're constantly re-calculating the commentstring.
I've pushed a commit fixing this: https://github.com/JoosepAlviste/nvim-ts-context-commentstring/commit/9c74db656c3d0b1c4392fc89a016b1910539e7c0 and will close this issue.
Let me know if this wasn't fixed or comes up again!


Problem with live preview

Currently I am using the new version of brackets. I have been using brackets for long time and just few days back I started having problem with the live preview. It just fails to reload. I uninstalled the chrome and brackets and again installed them and then it worked. But when I shut my laptop and start it the same problem occurs. Is their any solution?

@suraj-kalu Could you share the files and snapshot of the issue. I am using brackets 1.12. At my end, for Getting Started folder, reload is working fine.

Hello ... i have problem with live preview ... when I use   and use css font like font-size: 2vw;
livepreview will be end and disabled .... can some one know how to fix this ??

@fz-sl Can you shares some snapshots of the behavior. At my end live preview is not disabled on making changes suggested by you.

I am also having the same problem. It just can't reload the live preview...

If you are having the problem with the css, then you can press ctrl + f5
and if it is with other problems, after some days it just started working
correctly. I have no idea how it occured.
On Mon, Jul 30, 2018 at 9:16 PM SMShovon<EMAIL_ADDRESS>wrote:

I am also having the same problem. It just can't reload the live preview...
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/adobe/brackets/issues/14162#issuecomment-408905233,
or mute the thread
https://github.com/notifications/unsubscribe-auth/Abtn4XJFNN_38bexwoOc-uTIEdWf0Bszks5uLya-gaJpZM4SusrI
.


propTypes no longer part of React.AbstractComponentStatics

One cannot reference propTypes on a ComponentType<*> since 2e7d5a26babe69f2b17cba25f6f62a524534c635.
Is this intended? If yes, do you have a suggestion for handling this?
Example code:
import * as React from 'react';

function testHoc<-Props>(Component: React.ComponentType<Props>, props: Props) {
	return class Wrapper extends React.Component<Props> {
      static propTypes = Component.propTypes; // Error here: property `propTypes` is missing in
`React.AbstractComponentStatics`

      render() {
      	return <Component {...props} />
      }
    };
}

Flow try

We intentionally did not include propTypes because the static tracking should get rid of the need to use propTypes. I understand that someone may want some runtime verification as well, since any exists. We could include it as propTypes?: any in the libdef, which is how we type it for classes.

I'd be willing to accept a PR that adds propTypes to AbstractComponentStatics

Thank you, will look into it.


Improve crosswalk from schema.org to oai_dc

Since OAI-PMH mandates the metadataPrefix oai_dc, there is a crosswalk
from schema.org to oai_dc via xslt in json_container2oai_dc.xslt
=> The crosswalk is currently very minimalistic and needs improvement.
This ressource gives background on crosswalks: https://doi.org/10.5281/zenodo.4420116
The minimalistic example we have is
<oai_dc:dc xmlns:dc="http://purl.org/dc/elements/1.1/" xmlns:json="http://denbi.de/schemas/json-container" xmlns:map="http://www.w3.org/2005/xpath-functions/map" xmlns:oai_dc="http://www.openarchives.org/OAI/2.0/oai_dc/" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://www.openarchives.org/OAI/2.0/oai_dc/ https://www.openarchives.org/OAI/2.0/oai_dc.xsd http://purl.org/dc/elements/1.1/ https://www.radar-service.eu/schemas/dc.xsd">
  <dc:identifier>https://massbank.eu/MassBank/RecordDisplay?id=MSBNK-Eawag-EQ358855#HHZIURLSWUIHRB-UHFFFAOYSA-N</dc:identifier>
  <dc:identifier>DOI</dc:identifier>
  <oai_dc:title>Nilotinib</oai_dc:title>
</oai_dc:dc>

I will have a look at it with Sandra!

Hi, to reproduce the issue / task, I have the following code snippet:
./any-jsonld2json_container.sh data/MSBNK-Eawag-EA00040-MolecularEntity.json | java -jar /usr/share/java/Saxon-HE-<IP_ADDRESS>.jar -xsl:json_container2oai_dc.xslt -s:-
which will create the following almost-oai_dc XML output:
<oai_dc:dc xmlns:dc="http://purl.org/dc/elements/1.1/"
           xmlns:oai_dc="http://www.openarchives.org/OAI/2.0/oai_dc/"
           xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
           xmlns:map="http://www.w3.org/2005/xpath-functions/map"
           xmlns:json="http://denbi.de/schemas/json-container"
           xsi:schemaLocation="http://www.openarchives.org/OAI/2.0/oai_dc/ https://www.openarchives.org/OAI/2.0/oai_dc.xsd http://purl.org/dc/elements/1.1/ https://www.radar-service.eu/schemas/dc.xsd">
   <dc:identifier>https://massbank.eu/MassBank/RecordDisplay?id=MSBNK-Eawag-EA000401#OUSYWCQYMPDAEO-UHFFFAOYSA-N</dc:identifier>
   <dc:identifier>DOI</dc:identifier>
   <oai_dc:title>Metamitron-desamino</oai_dc:title>
</oai_dc:dc>

I'd like to ask for two things from @febach or @stefanbozic or someone else:

please provide here in the issue a command line to validate that oai_dc XML output, and see what is actually broken. Maybe with an xmllint call against a oai_dc XSD ? And where to find that XSD ?
please suggest a fix to https://github.com/NFDI4Chem/oai4schemas/blob/main/json_container2oai_dc.xslt so that the validation succeeds.

Thanks in advance,
yours, Steffen


No INVITE CODE URL

install-cloud.sh ends with no INVITE CODE URL
Screenshot: http://imgur.com/Nrn9OEh

What version of docker?  The --build-arg flag is pretty recent

DigitalOcean installs CentOS 7.2.
yum install docker
Installing : docker-1.8.2-10.el7.centos.x86_64

Can you try a newer version of docker?  https://docs.docker.com/engine/installation/linux/centos/

docker -v
Docker version 1.10.2, build c3959b1
That runs to completion. But entering the INVITE CODE URL into Firefox produces the error:
Error: Bad Request
Your client has issued a malformed or illegal request.
Screenshot: http://imgur.com/RK9hl5W

Do you have uProxy installed on that browser?

Almost there. Nothing appears in the GET ACCESS window. Shouldn't there be my server there?
Screenshot: http://imgur.com/0Cemsjr

@trevj Any thoughts?

Here is /var/log/messages:
Screenshot: http://imgur.com/QSOjBO1

In the uProxy logs I see an error message:
cloud social W [2016-03-04T14:55:26.254Z] tunnel0: connection error: {"level":"client-tiUSER_ID_1out"}
cloud social D [2016-03-04T14:55:26.254Z] tunnel0: CONNECTING -> TERMINATED
Screenshot: http://imgur.com/x8tIdim

Ah, ok, two things:

Thank you for using uProxy, and filing an issue when it didn't work!

I think that when the script ran with the old version of docker, it left some bad state (namely, port mappings) that messed things up.  So run these commands:

docker rm -f uproxy-sshd
docker rmi uproxy-sshd
docker rm -f uproxy-zork
docker rmi uproxy/firefox-stable

And then re-run the install-cloud.sh script.
I'm testing a fix to the script that will check the docker version and upgrade it if needed.

It has something to do with the fact that I am testing on a Debian desktop PC with Iceweasel browser. On that same desktop, I have a Windows 10 virtual machine. When I test using Firefox in my Windows 10 vm, it works! :)
I've written a blog post giving the test procedure that works, in case other people want to try it:
<EMAIL_ADDRESS>

I started with a new CentOS 7 machine at DigitalOcean and installed Docker myself. When I ran the uProxy installer, I got the message about Docker being too old. Isn't that a bit aggressive, considering that I had just installed Docker direct from the Docker site?
Also, the suggested command "yum erase docker" gave an error message. I found "yum remove docker-engine" followed by a rerun of the uProxy script worked.

Docker 1.10 had some big changes, and old versions of docker were the cause of the prior script problem.  CentOS is pretty slow moving, and their packages are a bit behind.
I think for beta, it makes sense to make the cuts now for choosing between substantially different versions.
The yum remove didn't work? Ugh. Sorry.  I'll put up a new image and test that command properly.

Re client compatibility:
I have now tested uProxy with Ubuntu 16.04 and the Firefox that comes with it. It works!
Screenshot: http://imgur.com/SElyAFZ
Therefore there must be something about Debian 8 and its Firefox (Iceweasel) version that prevents uProxy from working on that platform. However I will not investigate further, since very few people run Debian on their desktops. Any Linux desktop users are far more likely to be running Ubuntu or one of its derivatives.

@dcamero Delighted this is working for you now! Thanks again for the report; FWIW, we're adding some checks to the install scripts:
https://github.com/uProxy/uproxy-docker/pull/57
That said, yes, users should stick with the (admittedly somewhat hazily defined for now) supported platforms and clients: Ubuntu, Firefox, and Chrome.


Update new html_url

Update the url to the new Corona page from Bern

@brunis83 thanks a lot for your contribution! I added some remarks in your changes...

@brunis83 thanks a lot for your contribution! I added some remarks in your changes...

@brunis83 LGTM, thanks a lot!

@brunis83 LGTM, thanks a lot!


Sorting and project-away

Splunk sort order can be influenced by placing a '-' directly before a field, or before all fields mentioned in the sort command:
| sort -Data.Hresult
This will sort decending. If you want to sort multiple fields decending, it works like this: | sort - field1 field2 (note the space between the '-' and the first field name)
For the project and project-away, in Splunk you use the fields command, not the table command. The table command's main purpose is to change event data into tabular data. It can (and often is) used to specify what fields to table, but the specific command for selecting / deselecting fields is the fields command:
| fields a b c (for selecting fields a, b and c)
| fields -d (for deselecting field d)

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 2f0e8681-ca6e-d90d-b54c-edd9f1ef2cbc
Version Independent ID: fb1837ef-c134-1433-c14c-7fc19c1859cd
Content: Splunk to Azure Monitor log query - Azure Monitor
Content Source: articles/azure-monitor/log-query/splunk-cheatsheet.md
Service: azure-monitor
Sub-service: logs
GitHub Login: @bwren
Microsoft Alias: bwren

Assigning @bwren for visibility, review and to help provide insights.

#label:"CreateAzMonWIFeb2021"

Thank you for your contribution to the Azure Monitor documentation. We have created a workitem for this issue in our internal backlog database. We will prioritize it and make any necessary changes as we are able.
#please-close


Add loading of multiple certificates from a single PEM file/buffer

Motivation:
It is only possible to load multiple certificates from a PEM file,
sometimes it is useful to load multiple certificates from a buffer.
Modifications:

Deprecate the .file source of loading a certificate, since it would
only load the first certificate in a file.
Provide methods for loading multiple certificates from a PEM file or
buffer.

Result:
Multiple certificates can be loaded from a PEM file/buffer.

See also: #121


Inconsistent documents.

Also the countdown timer can be set to any new countdown value at any time to reload the timer with a specific value.

How?
Not explained in the documents that I can see.

See example "Reloading the countdown timer". This reloads the timer register to an arbitrary value during the timer runs.

You need to edit that example.
inject 6 is not what it is doing.

@Just-another-pleb: Thanks for the feedback. Corrected with pull request #9.

Also see section "Input" in the README.md for an explanation.

I think I have now got what I want working.

Ok, I goofed.   It is now closed.


Make SA Mod Manager compatible with Windows XP and Vista

Since the 2004 SADX game is compatible with Windows XP, it would be great if you tried to backport it to XP and Vista.

We don't plan to make the Manager working on XP, if people manage to make some tweaks to get it to work, then that's good, but there is currently no plan for official support.
If you wish to play SADX modded on PC the legacy manager is made for that.

I would've tried to backport it, but because the new Manager is made in WPF and using .NET 7.0 it's unrealistic.
You can still use the legacy Manager with the latest Mod Loader on XP right now, in a bit of an awkward way - i.e. you have to update the loader DLL manually and delete the new Manager's folders, also you can't change any settings that were added after the new Mod Manager was released. No promises, but at some point I do want to update the legacy Manager so that you could use it with the latest Mod Loader and still be able to edit all new settings on XP.

and using .NET 7.0 it's unrealistic.

Note: .NET 7 and above don't officially support Win 7 either.
It'll boot, and probably work for a bit, but there's bugs involving the Garbage Collector there, stuff will eventually break.


Re-evaluate expressions at runtime issue

Describe the bug
We are trying to optimize syncing process in our app. We try to sync only limited amount of data using sync expressions. Later in runtime we modify properties to always return QueryPredicateConstant.all and we try to resync by stop-start as described in documentation(In order to have your expressions re-evaluated, you can execute Amplify.DataStore.clear() or Amplify.DataStore.stop() followed by Amplify.DataStore.start().)
Unfortunately it doesn't work as expected. New data will not show up in the app until you call Amplify.DataStore.clear(). The only workaround we found is set syncInterval to 0 what always force a fullSync but it's a bad solution for other reasons. It looks like deltaSync doesn't support changes in sync expressions. I found a PR with possible solution but there are no updates since February.
Steps To Reproduce
Steps to reproduce the behavior:
1. Create a table, fill with data
2. Create a sync expression that will limit some of data
3. Modify behaviour of sync expression in runtime.
4. Call Amplify.DataStore.stop()
5. Call Amplify.DataStore.start()
6. When syncing done do a query. There will be no new data.
7. Call Amplify.DataStore.clear()
8. Call Amplify.DataStore.start()
9. When syncing done do a query. New data will show up.

Expected behavior
Re-evaluate expressions at runtime should work as described in documentation. Calling Amplify.DataStore.stop() and Amplify.DataStore.start() should re-evaluate expressions and pull new data.
Amplify Framework Version
2.22.0
Amplify Categories
DataStore
Dependency manager
Swift PM
Swift version
5.9
CLI version
12.7.1
Xcode version
15.0.1
Relevant log output
<details>
<summary>Log Messages</summary>

INSERT LOG MESSAGES HERE

```
Is this a regression?
No
Regression additional context
No response
Platforms
iOS
OS Version
all
Device
all
Specific to simulators
No response
Additional context
No response

Hi @kubatatami, thanks for opening this issue.
The team will take a look and post here once we have an update.

Hi @kubatatami,
For the expected behavior, when stop and start to re-evaluate the new predicate expression, do you want to keep the old data which is evaluated by the previous predicate expression?

@5d Yes. Let's say we have a user with data from the last few months. User signs in and I want to let him use the app once the app synced data from the last 24h. Then I want to re-evaluate expressions to sync rest of data.

@5d @ruisebas I was also thinking about different strategy to observe syncing progress and let users use the app once the app synced data from the last 24h but I noticed that query Sync[tableName] requests(made internally by Amplify sdk) always returns data in pages from oldest to newest. Is there any way to change it on local or backend side and syncing data from newest to oldest?

Please try out the fix in lawmicha.ds-full-sync-expression-change https://github.com/aws-amplify/amplify-swift/pull/2757 and let us know if you are able to successfully change your sync expression and restart DataStore to do a full sync

Hey @lawmicha  fix in lawmicha.ds-full-sync-expression-change looks good. I am able to successfully change sync expression and restart DataStore to do a full sync. We continue tests but so far it looks very promising. Thanks 🙏

Hi @kubatatami, thanks for trying out the fix and letting us know.

Is there any way to change it on local or backend side and syncing data from newest to oldest?

We don't expose a way to change the sort order for the Sync Query API call performed internally but that sounds like it might be possible and would not impact the integrity of the data. What are some use cases you have in mind for sorting by newest to oldest? Is it so that you will display the most recently created/updated items first and let the oldest items eventually come in?

@lawmicha Yes, exactly. Now on lawmicha.ds-full-sync-expression-change we are able to sync last X days of data, let user to use the app and then we re-evaluate expressions to sync all of data in the background. It works ok but if we would be able to change the sort order for the Sync Query API we would be able to observe sync progress and let user to use the app when we synced last X days of data. This way we would not have to pull data for last X days twice and older data would be available in the app from newest to oldest what in most cases is more important for user.

This has been released in https://github.com/aws-amplify/amplify-swift/releases/tag/2.25.1


allow uploaded images instead of just linked images for noted

Storage APIs reference: https://docs.mainframe.com/docs/sdk#storage


Release strategy

We need an automated way to release a new version of the api-client to npm once the server has a new version published

Does it need to be automated? For example, when 1.1.0 comes out there may be new improvements that we want to incorporate before releasing.

I guess not automated but we just need a release strategy for this


feat(SpecialFunctions/Gamma): Deligne's archimedean Gamma-factors

Add Deligne's variants of the Gamma function used in functional equations of L-functions.

bors r+
Thanks Sebastian for the review!


Windows support

[ ] Pinning might already be working through libuv (see here). Check!
[ ] Figure out how to make threadinfo() work

[x] lscpu source replacement?

https://docs.microsoft.com/en-us/windows/win32/api/winbase/nf-winbase-setthreadaffinitymask
https://github.com/mkitti/ArrayAllocators.jl/blob/main/src/Windows.jl

Won't happen without external support.


google maps api not working

it says "Serving HTTP on <IP_ADDRESS> port 8000 ..."
but nothing happens, then when i type in "localhost:8000" in chrome it comes back with a 404 error,
and on the bot running my player it says "<IP_ADDRESS> - - [29/Sep/2016 20:46:49] "GET / HTTP/1.1" 404 366 0.001000"
i can only assume the 404 in quotes above means the 404 error im getting back.
then when i exit the bot but keep the python http server running it says stuff like this indefinatly
"<IP_ADDRESS> - - [29/Sep/2016 20:48:31] "GET /socket.io/?EIO=3&transport=polling&t=1475207310561-0 HTTP/1.1" 404 -
<IP_ADDRESS> - - [29/Sep/2016 20:48:32] code 404, message File not found
<IP_ADDRESS> - - [29/Sep/2016 20:48:32] "GET /socket.io/?EIO=3&transport=polling&t=1475207311072-0 HTTP/1.1" 404 -
<IP_ADDRESS> - - [29/Sep/2016 20:48:32] code 404, message File not found
<IP_ADDRESS> - - [29/Sep/2016 20:48:32] "GET /socket.io/?EIO=3&transport=polling&t=1475207311124-0 HTTP/1.1" 404 -
<IP_ADDRESS> - - [29/Sep/2016 20:48:32] code 404, message File not found
<IP_ADDRESS> - - [29/Sep/2016 20:48:32] "GET /socket.io/?EIO=3&transport=polling&t=1475207311201-0 HTTP/1.1" 404 -
<IP_ADDRESS> - - [29/Sep/2016 20:48:32] code 404, message File not found
<IP_ADDRESS> - - [29/Sep/2016 20:48:32] "GET /socket.io/?EIO=3&transport=polling&t=1475207311335-0 HTTP/1.1" 404 -
<IP_ADDRESS> - - [29/Sep/2016 20:48:32] code 404, message File not found
<IP_ADDRESS> - - [29/Sep/2016 20:48:32] "GET /socket.io/?EIO=3&transport=polling&t=1475207311620-0 HTTP/1.1" 404 -
<IP_ADDRESS> - - [29/Sep/2016 20:48:33] code 404, message File not found
<IP_ADDRESS> - - [29/Sep/2016 20:48:33] "GET /socket.io/?EIO=3&transport=polling&t=1475207312045-0 HTTP/1.1" 404 -
<IP_ADDRESS> - - [29/Sep/2016 20:48:33] code 404, message File not found"
again getting the 404 error,  but now when i refresh the localhost:8000 page the map finally pops up at
Biologisch-Ökologische Station der Universität Koblenz-Landau
Zum Horngraben 2
54533 Bettenfeld
Germany
. (keep in mind i am still running 2 other bots on different accounts using the same google maps api key, but they arent popping up on the map) and now the python server says:
"<IP_ADDRESS> - - [29/Sep/2016 20:51:45] "GET /socket.io/?EIO=3&transport=polling&t=1475207504598-0 HTTP/1.1" 404 -
<IP_ADDRESS> - - [29/Sep/2016 20:51:45] code 404, message File not found
<IP_ADDRESS> - - [29/Sep/2016 20:51:45] "GET /catchable-135692@nmusd.us,%20ccruttenden@netchemistry.com,%20fredfredwerd@gmail.com.json?1475207505497 HTTP/1.1" 404 -
<IP_ADDRESS> - - [29/Sep/2016 20:51:45] code 404, message File not found"
and stuff... idk what to do

fixed it nevermind


Ensure camel-quarkus-integration-wiremock-support is test scope

Argh, I think in the case of digital ocean it will be needed at runtime.


Place Rooms arbitrary

[x] Spawn Rooms
[x] Make sure rooms don't overlap
[x] Rooms should not go beyond the bounds of the boundary

Converted "Rooms should not go beyond the bounds of the boundary" into issue #6


proposal: cmd/test2json: provide stderr flag for output

Running the following test
package main

import (
	"testing"
)

func Test(t *testing.T) {
	panic(1)
}

either with go test -json or with go test -c && go tool test2json pkg.test -test.v produces json lines with the panic stacktrace. It is unclear thought whether the output is stdout or stderr from the json:
{"Time":"2023-08-08T20:00:03.64831+02:00","Action":"start"}
{"Time":"2023-08-08T20:00:03.727661+02:00","Action":"output","Test":"Test","Output":"--- FAIL: Test (0.00s)\n"}
{"Time":"2023-08-08T20:00:03.730158+02:00","Action":"output","Test":"Test","Output":"panic: 1 [recovered]\n"}
{"Time":"2023-08-08T20:00:03.730162+02:00","Action":"output","Test":"Test","Output":"\tpanic: 1\n"}
{"Time":"2023-08-08T20:00:03.730163+02:00","Action":"output","Test":"Test","Output":"\n"}
{"Time":"2023-08-08T20:00:03.730165+02:00","Action":"output","Test":"Test","Output":"goroutine 6 [running]:\n"}
{"Time":"2023-08-08T20:00:03.730166+02:00","Action":"output","Test":"Test","Output":"testing.tRunner.func1.2({0x100c58e80, 0x100c48598})\n"}
{"Time":"2023-08-08T20:00:03.730172+02:00","Action":"output","Test":"Test","Output":"\t/opt/homebrew/opt/go/libexec/src/testing/testing.go:1526 +0x1c8\n"}
{"Time":"2023-08-08T20:00:03.730176+02:00","Action":"output","Test":"Test","Output":"testing.tRunner.func1()\n"}
{"Time":"2023-08-08T20:00:03.730178+02:00","Action":"output","Test":"Test","Output":"\t/opt/homebrew/opt/go/libexec/src/testing/testing.go:1529 +0x384\n"}
{"Time":"2023-08-08T20:00:03.740272+02:00","Action":"output","Test":"Test","Output":"panic({0x100c58e80, 0x100c48598})\n"}
{"Time":"2023-08-08T20:00:03.740282+02:00","Action":"output","Test":"Test","Output":"\t/opt/homebrew/opt/go/libexec/src/runtime/panic.go:884 +0x204\n"}
{"Time":"2023-08-08T20:00:03.740295+02:00","Action":"output","Test":"Test","Output":"awesomeProject3.Test(0x0?)\n"}
{"Time":"2023-08-08T20:00:03.740297+02:00","Action":"output","Test":"Test","Output":"\t/Users/Andrei.Efanov/Projects/chore/awesomeProject3/sample_test.go:8 +0x2c\n"}
{"Time":"2023-08-08T20:00:03.740305+02:00","Action":"output","Test":"Test","Output":"testing.tRunner(0x14000003a00, 0x100c7b9d8)\n"}
{"Time":"2023-08-08T20:00:03.740306+02:00","Action":"output","Test":"Test","Output":"\t/opt/homebrew/opt/go/libexec/src/testing/testing.go:1576 +0x10c\n"}
{"Time":"2023-08-08T20:00:03.740308+02:00","Action":"output","Test":"Test","Output":"created by testing.(*T).Run\n"}
{"Time":"2023-08-08T20:00:03.740845+02:00","Action":"output","Test":"Test","Output":"\t/opt/homebrew/opt/go/libexec/src/testing/testing.go:1629 +0x368\n"}
{"Time":"2023-08-08T20:00:03.740883+02:00","Action":"fail","Test":"Test","Elapsed":0.093}

Writing tools to present the output, I would like to distinguish stderr to paint it in a different color in the user console. Please consider adding a flag to the output json event.

This is not feasible in general. The problem is that you can have either (A) stdout and stderr merged into one, preserving the relative ordering of writes to stdout and writes to stderr, or (B) separate stdout and stderr, losing information about the relative ordering of individual messages. Go has chosen (A), because often programs are not terribly consistent about stdout vs stderr and often you care a lot about not reordering the relative outputs.
There is not stdout and stderr; there is just "Output".

Makes sense, thank you.
Firstly I was confused with the current behaviour, since despite having a single output channel, the channel is different for different tools. For example, running a go program or a compiled test, everything printed with println or panic gets into stderr by default. But for the tools like test2json, the output channel is stdout.
What is the reason for that?

This proposal has been added to the active column of the proposals project
and will now be reviewed at the weekly proposal review meetings.
— rsc for the proposal review group

What is the reason for having stderr by default and stdout for test2json?

Mostly to separate the other non-JSON error output that the go command can print.

This proposal has been declined as infeasible.
— rsc for the proposal review group


Added Help and Defaults

Add uni --help to provide available use options in CLI
Assume default recipe owner if not provided (since there's currently only one, anyway) for ease of typing -- allows typing just uni bake yarn-install for example

Updated -- just as an FYI, the more text transformation we apply on the README, the more likely it may break if styling on the markdown is significantly updated, but I've tried to keep it as flexible as possible.

@jfgordon2 Looks great for me, thanks. I'll keep the same style in that readme. Just a few fixes more. uni bake how yarn-installis not affected by the default recipe feature. Can you please fix it? After this, just update this and this with your modifications and I can merge your pull request.

@daltonmenezes updated for your review

@jfgordon2 Well done. Thank you so much. :D


Animation flickering

Hello,
while using this menu I encountered a strange animation flickering. For example when you open menu and then decide to close, you can see flickering button layers on top of the "pieces" (for example using CircleMenu).

+3

This issue is related to Material design ( https://github.com/CosmicMind/Material ). When you use "Material design Navigation Controller" and this VHBoomMenuButton together, this issue occurs.
Used UINavigationController and this issue disappeared.

@AhmedShammala @edgar-zigis are you also using Material ?

No, I don't use it on any Navigation Controller and I don't use Material library.
I simply put it inside the view of simple UIViewController and it has no specific options or extensions which could cause side effects. Tried both using autolayout and simple rect frames - same result.

I am also having the same issue of Flickering animation.

@yasirmturk  no but it was bz i using "CRToast" and fix after change it .


In_App_Purchase - Not Retrieving Products

Issue
I'm trying to run the example and display the available in app purchases I created but it doesn't seem to be returning anything when I run the below code. My package version is currently 0.3.4 and I've tried all the basics such as flutter clean / doctor. I've also tried using the example code provided and running into the same error, even with the test IDs.
Apart from the product ID is there anything I need to do to point it to the specific product or should this run anyway?
Flutter Doctor

Results

[✓] Flutter (Channel stable, v1.17.2, on Mac OS X 10.15.4 19E287, locale en-GB)
    • Flutter version 1.17.2 at /Users/Thomas/Desktop/flutter
    • Framework revision 5f21edf8b6 (2 days ago), 2020-05-28 12:44:12 -0700
    • Engine revision b851c71829
    • Dart version 2.8.3

[!] Android toolchain - develop for Android devices (Android SDK version 29.0.3)
    • Android SDK at /Users/Thomas/Library/Android/sdk
    • Platform android-29, build-tools 29.0.3
    • Java binary at: /Library/Java/JavaVirtualMachines/adoptopenjdk-8.jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (AdoptOpenJDK)(build 1.8.0_252-b09)
    ✗ Android license status unknown.
      Try re-installing or updating your Android SDK Manager.
      See https://developer.android.com/studio/#downloads or visit visit https://flutter.dev/docs/get-started/install/macos#android-setup for detailed instructions.

[✓] Xcode - develop for iOS and macOS (Xcode 11.3.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 11.3.1, Build version 11C504
    • CocoaPods version 1.8.4

[!] Android Studio (not installed)
    • Android Studio not found; download from https://developer.android.com/studio/index.html
      (or visit https://flutter.dev/docs/get-started/install/macos#android-setup for detailed instructions).

[✓] VS Code (version 1.45.1)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.10.2

[✓] Connected device (1 available)
    • iPhone 11 • F58F633B-DE9E-4724-8227-859A231D5238 • ios • com.apple.CoreSimulator.SimRuntime.iOS-13-3 (simulator)

Google Play Console

Relevant Code
List<ProductDetails> products;
  getProducts() async {
    Set<String> _productID = <String>[
      /// Android
      'com.viscreo.simply_money',

      /// iOS
      'com.viscreo.simplymoney'
    ].toSet();
    final ProductDetailsResponse response =
        await InAppPurchaseConnection.instance.queryProductDetails(_productID);
    print(
        'Could not find ----> ${response.notFoundIDs.length}/${_productID.length}');
    setState(() {
      products = response.productDetails;
    });
  }

  @override
  void initState() {
    getProducts();
    super.initState();
  }

Print Results
'Could not find ----> 2/2'

You are initializing the connection with initPlatformState?
void inAppPurchaseInit(){
try {
      this._platformVersion = await FlutterInappPurchase.instance.platformVersion;
    } on PlatformException {
      this._platformVersion = 'Failed to get platform version.';
    }
    this.resultConnection = await FlutterInappPurchase.instance.initConnection;

    _connection = FlutterInappPurchase.connectionUpdated.listen(( ConnectionResult connected ) {

    });
}

Hi @DomingoMG, it looks like you're referring to the flutter_inapp_purchase package, whereas I am currently using in_app_purchase. I'd prefer to use the official Flutter plugin instead but I'll give the other one a go anyway.
Thanks,
Thomas.

Did you find any solution to this yet, since I'm having the same issue.


RSpec 2.6.0 deprecation warning

RSpec 2.6.0 is giving this warning when I run my specs:
*****************************************************************
DEPRECATION WARNING: you are using deprecated behaviour that will
be removed from RSpec 3.

You have set some configuration options after an example group has
already been defined.  In RSpec 3, this will not be allowed.  All
configuration should happen before the first example group is
defined.  The configuration is happening at:

  /path/to/my/project/spec/spec_helper.rb:50
*****************************************************************

This refers to this generated block:
RSpec.configure do |config|
  config.before(:each) do
    database_connections.each do |name|
      plsql(name).savepoint "before_each"
    end
  end
  config.after(:each) do
    # Always perform rollback to savepoint after each test
    database_connections.each do |name|
      plsql(name).rollback_to "before_each"
    end
  end
  config.after(:all) do
    # Always perform rollback after each describe block
    database_connections.each do |name|
      plsql(name).rollback
    end
  end
end

Thoughts?

Is it still valid after recent updates or can we close this one?

if we're unable to reproduce, and no one complains, can it be closed?

I don't see warnings either, using rspec 3.4. I'm closing the issue...


msg: Fix build in python3

We can afford a slower performance in this parsers with python2 to
keep compability with python3.
http://sebastianraschka.com/Articles/2014_python_2_3_key_diff.html#xrange

Thanks!


[Feature] animated scroll to top button

Description
the scroll to top button would be animating up-down when visible .
Screenshots
No response
Checklist

[X] I have checked the existing issues
[X] I have read the Contributing Guidelines
[X] I am willing to work on this issue (optional)
[X] I am a GSSoC'23 contributor

thanks @harshita-2003, you may start working this issue :)


[FEATURE REQUEST] Muskeg biome

https://en.m.wikipedia.org/wiki/Muskeg
Seems I accidentally ripped out the template for issues, but of note is that this refers to a specific type of bogland found in Canada and Alaska. Cold, swampy biomes do not get much representation in MC mods. This would be an ideal addition to add to the mod.
Of note is that Terrablender would need to be added as a dependency if this is done, due to Mojang’s changes to biomes.

Could we get a unique flower or two for this biome? There was a type of pitcher plant I proposed for it.


zeromq 2017 support

Current it is not possible to install zeromq using vcpkg for Visual Studi 2017
vcpkg install zeromq:x64-windows  yields following error:

Microsoft (R) Build Engine version 15.1.548.43366
Copyright (C) Microsoft Corporation. All rights reserved.

Build started 10.03.2017 00.31.03.
     1>Project "C:\vcpkg\buildtrees\zeromq\src\zeromq-4.2.0\builds\msvc\vs2015\libzmq\libzmq.vcxproj" on node 1 (default targets).
     1>C:\Program Files (x86)\Microsoft Visual Studio\2017\Enterprise\Common7\IDE\VC\VCTargets\Microsoft.Cpp.Platform.targets(57,5): error MSB8020: The build tools for v140 (Platform Toolset = 'v140') cannot be found. To build using the v140 build tools, please install v140 build tools.  Alternatively, you may upgrade to the current Visual Studio tools by selecting the Project menu or right-click the solution, and then selecting "Retarget solution". [C:\vcpkg\buildtrees\zeromq\src\zeromq-4.2.0\builds\msvc\vs2015\libzmq\libzmq.vcxproj]
     1>Done Building Project "C:\vcpkg\buildtrees\zeromq\src\zeromq-4.2.0\builds\msvc\vs2015\libzmq\libzmq.vcxproj" (default targets) -- FAILED.

Build FAILED.

       "C:\vcpkg\buildtrees\zeromq\src\zeromq-4.2.0\builds\msvc\vs2015\libzmq\libzmq.vcxproj" (default target) (1) ->
       (PlatformPrepareForBuild target) ->
         C:\Program Files (x86)\Microsoft Visual Studio\2017\Enterprise\Common7\IDE\VC\VCTargets\Microsoft.Cpp.Platform.targets(57,5): error MSB8020: The build tools for v140 (Platform Toolset = 'v140') cannot be found. To build using the v140 build tools, please install v140 build tools.  Alternatively, you may upgrade to the current Visual Studio tools by selecting the Project menu or right-click the solution, and then selecting "Retarget solution". [C:\vcpkg\buildtrees\zeromq\src\zeromq-4.2.0\builds\msvc\vs2015\libzmq\libzmq.vcxproj]

    0 Warning(s)
    1 Error(s)

Time Elapsed 00:00:00.69

Any way of fixing this?

As a workaround you can install VC++ 2015.3 v140 toolset

That may work (I just realized that 2017 was released yesterday).
Is this a issue at the library maintainers end or vcpkg?

This was an issue with the portfile, which @Mixaill has fixed with #763 (yay!).

Thanks! +1 And keep up the good work!


Fish Shell completions: aggregate is not included

I noticed that the aggregate command is not taken into account in the Fish Shell completions. (I couldn't find any reference of it in https://github.com/TailorDev/Watson/blob/master/watson.fish)
Steps to reproduce

Use Fish Shell
Type watson ag| + Tab (pipe indicates cursor)
Expected result: watson aggregate
Actual result: watson tags

Versions

watson --version: 1.7.0
fish --version: 3.0.2

Thanks for this project! :)

Thanks for the report! Maybe @andrewmeyer can help on this?

As long as I have a branch open, I'll look for any other missing completions

Thanks for fixing this :smiley:

Thanks @andrewmeyer :pray:


Updated html changes

a new pokemon  is added to the code (pikachu)

Kindly add a pokemon that was not present in the website. Thank you.

Please mark as invalid and spam, this is an obvious attempt to get a free t-shirt by 'contributing'(hacktoberfest)
This will also ban the user for trying to abuse the system by doing marginal effort


MudColorPicker, MudBaseDatePicker, MudTimePicker: Add localizable labels

Description

Part of #8901. They still need to be checked for keyboard navigation and other accessibility opportunities.
How Has This Been Tested?

Type of Changes

[ ] Bug fix (non-breaking change which fixes an issue)
[X] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation (fix or improvement to the website or code docs)

Checklist

[X] The PR is submitted to the correct branch (dev).
[X] My code follows the code style of this project.
[ ] I've added relevant tests.

@igotinfected Got another one for you! This time it's just ARIA labels.
Thoughts? Too many labels? Which resource names or labels should change?

@igotinfected Great, thanks for that! Very helpful to have two sets of eyes on this. I've stripped them down and plan to do another pass in the future with more documentation to go along with it.
@henon Ready for review

Thanks, good job!


Use ShortByteString for OneEraHash and ConvertRawHash

Since the Byron and Shelley hash types are ShortByteStrings under the hood,
switch over the representation of OneEraHash from Strict.ByteString to
ShortByteString too.
To avoid the intermediary Strict.ByteString in the conversion, add
toShortRawHash and fromShortRawHash to ConvertRawHash.
This avoids the memory overhead that a regular strict ByteString has.
According to the Haddocks of ShortByteString, using a
ByteString (unshared) for a 32 byte hash (which is the case for Byron and
Shelley) requires 72 + 32 bytes, but a ShortByteString requires only 32 + 32
bytes. This can make a noticeable difference in memory usage as we're keeping
lots of hashes in memory:

O(k) in the in-memory indices of the VolatileDB (hash and prev hash)
O(cached epochs * epoch size) in the secondary index caches of the
ImmutableDB
...

Glad to have this major performance penalty gone finally :smirk:

bors ping

bors merge


Pyglet support

Hi,
Do you have any advice as to how I can implement pyglet support for imgui_bundle?

Hi,
ImGui Bundle does not support pyglet by default.
As an alternative, pyimgui is another library that offers pythonbindings for ImGui. It has support for pyglet, however it does not support the docking features of ImGui, and does not provide the additional library that ImGui Bundle provides.
If you want to explore how support for pyglet could be added, here are some quick advices:

You should take inspiration from the example imgui_example_glfw_opengl3.py

Basically, you will have to adapt there all the call to glfw (and replace them by pyglet), and you may also have to also reimplement the OpenGL rendering.

Inspiration on pyglet usage with ImGui:
You can look at the pyglet.py file from pyimgui for inspiration

Inspiration on how to implement the OpenGL rendering
In the example, the OpenGL rendering is done via these lines:

        GL.glClear(GL.GL_COLOR_BUFFER_BIT)
        imgui.backends.opengl3_render_draw_data(imgui.get_draw_data())

I suspect this may also work with pyglet. However, if you need to implement the rendering yourself, you can take inspiration from opengl.py, also from the  pyimgui project.
Please keep me informed if you end up exploring this.

Hi,
There is now a working python backend for pyglet:
see https://github.com/pthom/imgui_bundle/blob/main/bindings/imgui_bundle/python_backends/pyglet_backend.py
and an example:
https://github.com/pthom/imgui_bundle/blob/main/bindings/imgui_bundle/python_backends/examples/example_python_backend_pyglet.py

This is great but I think you forget to implement on_mouse_drag:
https://github.com/pthom/imgui_bundle/blob/ba617dbe9bb92f18f9aadd7ff694d843cc34eac6/bindings/imgui_bundle/python_backends/pyglet_backend.py#L163
I just copied it from here:
https://github.com/pyimgui/pyimgui/blob/723022d87de8040d1c4a66f53288dcfd7d2274d3/imgui/integrations/pyglet.py#L144


Stop gap fix serde

Cc/ @dignifiedquire @tarcieri
serde skip requires a default for BoxedMontyParams associated n_params since it's not an option at RsaPublicKey

not needed anymore


Show notifications when both gd and imagick not installed.

Implemented in https://github.com/UniSharp/laravel-filemanager/commit/1b74578ec2698786df49d46e069ed6c49c8ba288.


LUCENE-10218: Extend validateSourcePatterns task to scan for LTR/RTL …

See https://issues.apache.org/jira/browse/LUCENE-10218

I added task graph ordering that enforces the validation runs prior to compilation (if they're both scheduled to run). This is safer than just scheduling module's tests after validation because you make sure classes from other modules have been validated too.


Revert "Update minor version"

Reverts ballerina-platform/module-ballerina-observe#93

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Broker Cache

Right now every query hitting broker will be scatter gathered to servers. We can make a simple caching layer in broker to keep the most recent query and response.
We can use com.google.common.cache.LoadingCache to handle request as well as cache results.
Some thoughts:

cache should have a configurable size and expire after a configurable time.
Some queries may not be cached (e.g. query without up-bound time value specified)
Current request metrics need to compile request first. Otherwise we don't which table this request will query.
In order to achieve 2, we need to compile the query, get table name, get time column from the table, and check query time range.

Few other thoughts

It would be great to include a flag or some property in the response to indicate that the response came from the cache. This will help in future debugging.
User should be able to bypass the cache by passing in a request flag / property.
Not sure what you plan to store in the cache, but consider the performance of serialization / deserizalation of objects in cache. Sometimes it might be better to store the raw serialized version from the server cache to avoid overhead. This is a perf optimization and can be prioritized for a later time.
What happens to cached rows if the underlying segments expire or gets deleted?
It will be good to list out the cache invalidation scenarios. May be to begin with it is purely time based?

Same as #656


Failed to load API definition [SWAGGER]

I followed every step of the tutorial mentioned in this medium article
Link:https://medium.com/worldsibu/automatically-generate-a-nodejs-api-backend-for-hyperledger-fabric-with-convector-3ee7f3318230
and was able to start the rest server. But when I browse to http//localhost:3000 or any other route then I get a NOT found definition error. Please if possible look into the matter as I have been stuck on this for days.

Hi, did you find any solutions for this issue?


Erratic r-linting failures

Working on #1398, hit this failure: https://github.com/opendp/opendp/actions/runs/8327661390/job/22785859499?pr=1398 ... resolved on re-run
Working on #1378, hit the same failure: https://github.com/opendp/opendp/actions/runs/8328906500/job/22789976615

Warning: file=R/accuracy.R,line=27,col=11,[object_usage_linter] no visible global function definition for 'parse_or_infer'

repeated 1250 times, for different functions.

Maybe a race condition? Is something only partially installed before we continue?
Since it only seems to be one linter that complains, just disable that one?
Google the error message?
Are there any errors earlier in the log that are the real root cause?

Perhaps this is a fix? https://github.com/r-lib/lintr/issues/1137
There are a number of reports of errors with this linter, so it may be worth doing from more research.


Start using GitHub Container Registry

Effective Nov 1st 2020, Docker is introducing a container image retention policy for inactive images.
An inactive image is a container image that has not been either pushed or pulled from the Docker Hub image repository in 6 or more months. Free plans will have a 6 month inactive image retention limit.
Backup existing images to a GitHub registry and start using GitHub as the primary registry for new images.
GitHub Container Registry is superseding GitHub Packages Docker registry.  During the beta of GitHub Container Registry, storage and bandwidth is free.

We now have the images on DockerHub and GitHub Container Registry. I haven't migrated all the versions on DockerHub since I'm on a really slow connection right now, but can retroactively do that if someone requests it.


Snap packaging

Is it possible to distribute this software as a snap package? So one could use it in Solus?

Unfortunately snap has limited support for FUSE (https://docs.snapcraft.io/the-fuse-support-interface/7816): The interface is not automatically connected, there is no support for unprivileged mounts, and mountpoints are limited to some directories.


Adding simple tutorial

@keilw I'm not sure how this fits here. This embedded tutorial walks through embedded caching capabilities using weather data as base for it. Your tutorial seems like a standard standalone one, just like the one we have here (which is already available under our simple tutorials repo).

Ok no worries, then I'll close the PR


mautrix-telegram: unstable-2023-02-16 -> 0.13.0

Changes: https://github.com/mautrix/telegram/compare/354b49d9e5f91f913b5fdf9288bc631a9a34d142...v0.13.0
Description of changes

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 218791 run on aarch64-linux 1

1 package built:

mautrix-telegram


Deployment custom user resource bundle failed in Github Actions

As a TREAdmin I want to deploy custom GPU virtual machine, it fails during GitHub actions deployment with the following error:
`    Usage: /home/vscode/AzureTRE//devops/scripts/register_bundle_with_api.sh [-c --current] [-i --insecure]
Options:
    -r, --acr-name                Azure Container Registry Name
    -t, --bundle-type             Bundle type: workspace, workspace_service, user_resource or shared_service
    -w, --workspace-service-name  The template name of the user resource (if registering a user_resource)
    -c, --current                 Make this the currently deployed version of this template
    -v, --verify                  Verify registration with the API
    --dry-run                     Don't submit the template to the API, just output the payload`

However, it works on a local machine, when running on Docker from Visual Studio Code with a custom make command: user_resource_bundle_custom
Steps to reproduce

Copy guacamole-azure-windowsvm folder into our repository

Rename it to guacamole-azure-windowsvm- gpu

Modify template_schema.json to include new os_image:

Modify porter.yaml to include new option.

Insert extra bundles into deploy_tre_reusable.yml file:

Modify Makefile

Looks like you are missing WORKSPACE_SERVICE_NAME - maybe add to line 607 - can see others on 600, 603 etc.

Thank you @marrobi we did not spot that, we are testing it now, once successful, I will close the issue.


feat: adopt flakes

I was trying to contribute to nc4nix but prefer flakes. Flakes make this even more reproducable.
I "flakified" the repo with gomod2nix.
The update removed   delve   libcap from shell.nix , but go build works without it ?
The stuff in default.nix I am not sure what it's about
I dont develop in go, go run seemed like the good command to start nc4nix but it does nothing both on main and in this branch ?

@Conni2461 can you please have a look at this? :)

Neither nix build nor nix-build are going through:
@nix { "action": "setPhase", "phase": "unpackPhase" }
unpacking sources
unpacking source archive /nix/store/ndsndqv0669y5y79fc7d8g6z040i61id-s2885l2hgi8i5qa91vzyvnwj93sxzrnq-source
source root is s2885l2hgi8i5qa91vzyvnwj93sxzrnq-source
@nix { "action": "setPhase", "phase": "patchPhase" }
patching sources
@nix { "action": "setPhase", "phase": "updateAutotoolsGnuConfigScriptsPhase" }
updateAutotoolsGnuConfigScriptsPhase
@nix { "action": "setPhase", "phase": "configurePhase" }
configuring
@nix { "action": "setPhase", "phase": "buildPhase" }
building
Building subPackage .
go: finding module for package github.com/hashicorp/go-version
main.go:14:2: cannot query module due to -mod=vendor

Only nix-shell works for me.
Do I need to run anything else or add some parameters?


set_text is not working properly

When I use the set_text method, the text isn't set to the clipboard. But when I add a little delay before the program exists it works. Here is the code
let clipboard = Clipboard::new();

match clipboard {
    Ok(mut clipboard) => {
        let text = clipboard.set_text("hello world 2".to_string());
        match text {
            Ok(_) => {
                println!("OK");
                //std::thread::sleep(std::time::Duration::from_millis(10));
            }
            Err(_) => {
                println!("Error");
            }
        }
    },
    Err(_) => {

    }
}

When I uncomment the std::thread::sleep(std::time::Duration::from_millis(10)); it works. But I guess this isn't the intended behaviour

Hi there @DodyAlkarkhi. What operating system and desktop environment are you seeing this behavior on?

Hi there @DodyAlkarkhi. What operating system and desktop environment are you seeing this behavior on?

Hi.
OS is Debian sid and desktop environment is KDE Plasma

It sounds like you may be running into the same problem that #39 with how the dropping Clipboard interacts with the X11 window server.
If you move the mut clipboard binding outside of the match i.e using .unwrap() for example, then the text should be available outside of that first Ok block.

Hey there again. I'm going to go ahead and close this one now that 3.0 is out with the wait function. If you need to access clipboard contents longer, I would recommend using this function or keeping the Clipboard struct around longer.


fix unused argument warning when input source files

Fix for SWDEV-230876 Warning messages observed while compiling tests
Tests for source files on command-line before setting flags
Also added test for -fuse-ld=lld to set ldflags

Adding @mangupta @yxsamliu for review

Ok @yxsamliu didn't check #2026 first.

master-next is a read only mirror of the internal branch. Please submit the change there instead.


Added support for identifier property for FreeFormArrivalsThreadGroup

When use many different FreeFormArrivalsTG, many times, it is required to change load profile for exact one TG.
With this issue, we can control complex profile with just using different properties for each unique TG.

Components in JMeter already have an identifier field. It is "Name". Why not use that field's value?

Don't think about it. Hmm. But Names can be with white spaces. Different TG
cab have same names. It will be not so convenient in test  development I
think. Well. Maybe I can create additional locked test field, where will be
displayed generated on TG name property? What do you think about it?
пт, 11 февр. 2022 г., 09:17 Andrey Pokhilko @.***>:

Components in JMeter already have an identifier field. It is "Name". Why
not use that field's value?
—
Reply to this email directly, view it on GitHub
https://github.com/undera/jmeter-plugins/pull/514#issuecomment-1035912350,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAXFH2QKRVAWVW75RU4WD2TU2SSYDANCNFSM5OAJMR7Q
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you authored the thread.Message ID:
@.***>

Ок. I will do it.
пт, 11 февр. 2022 г., 14:33 Andrey Pokhilko @.***>:

Don't change the code just now.
Can you share a screenshot of the updated UI?
Also, to make the feature complete, you'd need to update the documentation
to reflect this new feature.
—
Reply to this email directly, view it on GitHub
https://github.com/undera/jmeter-plugins/pull/514#issuecomment-1036111018,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAXFH2QFPI6JDPLN5JKJUHTU2TXYVANCNFSM5OAJMR7Q
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you authored the thread.Message ID:
@.***>

Hello. Sorry for late answer.
Here it looks like with identifier selected:

Without identifier set

Also:
When using idetifier - default timeunit is Seconds. To change it: you can use additional property: (current_idetifyer_property_value)+ ".timeunit". Awailible values: S, M
Known issues:

Current Thread schedule will be overriden by property configuration for information reason.
Load Graph is displayed, based on selected timeunit from UI. But it will be not used in real test. So - test duration will be calculated incorrect in UI. But it works fine in real tests:

Properties, that used for this test:
arrivals.property.one=spawn(1,10,1m) spawn(10,10,5m) spawn(10,1,1m)
arrivals.property.one.timeunit=S
arrivals.property.two=spawn(1,60,1m) spawn(60,60,5m) spawn(60,1,1m)
arrivals.property.two.timeunit=M

Looks like "useIdentifier" checkbox needs a better readable label. Like "use identifier".
Please make sure that by default, the behavior is like it is right now. Maybe it is already like that, I just making sure.
Please update the documentation to tell people what this feature do and how it works.

Done

Unable to check wiki syntax, Site required to autoload.php to run it in docker container correctly.

The website is dockerized, you can test it via Docker

The website is dockerized, you can test it via Docker

Missing file vendor/autoload.php - where can i get it?
Also:
I checked out https://github.com/undera/pwe inside ./site/vendor/undera/pwe

It is not working on clear environment.
I am install composer and perform: composer install
But still getting errors:

Thu Feb 17 10:30:43.979238 2022] [php7:notice] [pid 35] [client <IP_ADDRESS>:62826] PHP Notice:  Undefined index: REDIRECT_URL in /var/www/html/vendor/undera/pwe/index.php on line 72
[Thu Feb 17 10:30:43.980019 2022] [php7:notice] [pid 35] [client <IP_ADDRESS>:62826] PHP Notice:  Trying to access array offset on value of type null in /var/www/html/vendor/undera/pwe/PWE/Modules/PWEModulesManager.php on line 51
[Thu Feb 17 10:30:43.980049 2022] [php7:notice] [pid 35] [client <IP_ADDRESS>:62826] PHP Notice:  Trying to access array offset on value of type null in /var/www/html/vendor/undera/pwe/PWE/Modules/PWEModulesManager.php on line 51
[Thu Feb 17 10:30:43.980066 2022] [php7:notice] [pid 35] [client <IP_ADDRESS>:62826] PHP Notice:  Trying to access array offset on value of type null in /var/www/html/vendor/undera/pwe/PWE/Modules/PWEModulesManager.php on line 51

What am i do wrong?

composer check-platform-reqs
ext-json   7.4.3    success
ext-posix  7.4.3    success
ext-xml    7.4.3    success
php        7.4.3    success

[Thu Feb 17 10:30:43.980079 2022] [php7:notice] [pid 35] [client <IP_ADDRESS>:62826] PHP Notice:  Undefined index: !c in /var/www/html/vendor/undera/pwe/PWE/Modules/PWEModulesManager.php on line 51
[Thu Feb 17 10:30:43.980086 2022] [php7:notice] [pid 35] [client <IP_ADDRESS>:62826] PHP Notice:  Trying to access array offset on value of type null in /var/www/html/vendor/undera/pwe/PWE/Modules/PWEModulesManager.php on line 51
[Thu Feb 17 10:30:43.980097 2022] [php7:notice] [pid 35] [client <IP_ADDRESS>:62826] PHP Notice:  Trying to access array offset on value of type null in /var/www/html/vendor/undera/pwe/PWE/Modules/PWEModulesManager.php on line 51
[Thu Feb 17 10:30:43.980114 2022] [php7:notice] [pid 35] [client <IP_ADDRESS>:62826] PHP Notice:  Undefined index: !c in /var/www/html/vendor/undera/pwe/PWE/Modules/PWEModulesManager.php on line 51
[Thu Feb 17 10:30:43.980131 2022] [php7:notice] [pid 35] [client <IP_ADDRESS>:62826] PHP Notice:  Trying to access array offset on value of type null in /var/www/html/vendor/undera/pwe/PWE/Modules/PWEModulesManager.php on line 51
[Thu Feb 17 10:30:43.980148 2022] [php7:notice] [pid 35] [client <IP_ADDRESS>:62826] PHP Notice:  Trying to access array offset on value of type null in /var/www/html/vendor/undera/pwe/PWE/Modules/PWEModulesManager.php on line 51
[Thu Feb 17 10:30:43.980163 2022] [php7:notice] [pid 35] [client <IP_ADDRESS>:62826] PHP Notice:  Undefined index: !a in /var/www/html/vendor/undera/pwe/PWE/Modules/PWEModulesManager.php on line 159
[Thu Feb 17 10:30:43.982483 2022] [php7:notice] [pid 35] [client <IP_ADDRESS>:62826] PHP Notice:  Undefined index: link in /var/www/html/vendor/undera/pwe/PWE/Utils/PWEXMLFunctions.php on line 22
[Thu Feb 17 10:30:43.983069 2022] [php7:notice] [pid 35] [client <IP_ADDRESS>:62826] PHP Notice:  Undefined index: Lib in /var/www/html/vendor/undera/pwe/PWE/Modules/PWEModulesManager.php on line 51
[Thu Feb 17 10:30:43.983085 2022] [php7:notice] [pid 35] [client <IP_ADDRESS>:62826] PHP Notice:  Trying to access array offset on value of type null in /var/www/html/vendor/undera/pwe/PWE/Modules/PWEModulesManager.php on line 51
[Thu Feb 17 10:30:43.983091 2022] [php7:notice] [pid 35] [client <IP_ADDRESS>:62826] PHP Notice:  Undefined index: !c in /var/www/html/vendor/undera/pwe/PWE/Modules/PWEModulesManager.php on line 51
[Thu Feb 17 10:30:43.983098 2022] [php7:notice] [pid 35] [client <IP_ADDRESS>:62826] PHP Notice:  Trying to access array offset on value of type null in /var/www/html/vendor/undera/pwe/PWE/Modules/PWEModulesManager.php on line 51
[Thu Feb 17 10:30:43.983104 2022] [php7:notice] [pid 35] [client <IP_ADDRESS>:62826] PHP Notice:  Trying to access array offset on value of type null in /var/www/html/vendor/undera/pwe/PWE/Modules/PWEModulesManager.php on line 51
[Thu Feb 17 10:30:43.983134 2022] [php7:notice] [pid 35] [client <IP_ADDRESS>:62826] PHP Notice:  Undefined index: !c in /var/www/html/vendor/undera/pwe/PWE/Modules/PWEModulesManager.php on line 51
[Thu Feb 17 10:30:43.983145 2022] [php7:notice] [pid 35] [client <IP_ADDRESS>:62826] PHP Notice:  Trying to access array offset on value of type null in /var/www/html/vendor/undera/pwe/PWE/Modules/PWEModulesManager.php on line 51
[Thu Feb 17 10:30:43.983161 2022] [php7:notice] [pid 35] [client <IP_ADDRESS>:62826] PHP Notice:  Trying to access array offset on value of type null in /var/www/html/vendor/undera/pwe/PWE/Modules/PWEModulesManager.php on line 51
[Thu Feb 17 10:30:43.983180 2022] [php7:notice] [pid 35] [client <IP_ADDRESS>:62826] PHP Notice:  Undefined index: !c in /var/www/html/vendor/undera/pwe/PWE/Lib/Smarty/SmartyWrapper.php on line 23
[Thu Feb 17 10:30:43.983187 2022] [php7:notice] [pid 35] [client <IP_ADDRESS>:62826] PHP Notice:  Trying to access array offset on value of type null in /var/www/html/vendor/undera/pwe/PWE/Lib/Smarty/SmartyWrapper.php on line 23
[Thu Feb 17 10:30:43.983194 2022] [php7:notice] [pid 35] [client <IP_ADDRESS>:62826] PHP Notice:  Trying to access array offset on value of type null in /var/www/html/vendor/undera/pwe/PWE/Lib/Smarty/SmartyWrapper.php on line 23
[Thu Feb 17 10:30:43.983205 2022] [php7:notice] [pid 35] [client <IP_ADDRESS>:62826] PHP Notice:  Trying to access array offset on value of type null in /var/www/html/vendor/undera/pwe/PWE/Lib/Smarty/SmartyWrapper.php on line 24
[Thu Feb 17 10:30:43.983221 2022] [php7:notice] [pid 35] [client <IP_ADDRESS>:62826] PHP Notice:  Trying to access array offset on value of type null in /var/www/html/vendor/undera/pwe/PWE/Lib/Smarty/SmartyWrapper.php on line 24
[Thu Feb 17 10:30:43.984428 2022] [php7:notice] [pid 35] [client <IP_ADDRESS>:62826] PHP Notice:  Undefined offset: 0 in /var/www/html/vendor/undera/pwe/PWE/Core/PWECore.php on line 371
[Thu Feb 17 10:30:43.984506 2022] [php7:notice] [pid 35] [client <IP_ADDRESS>:62826] PHP Notice:  Undefined index: !c in /var/www/html/vendor/undera/pwe/PWE/Lib/Smarty/SmartyWrapper.php on line 23
[Thu Feb 17 10:30:43.984524 2022] [php7:notice] [pid 35] [client <IP_ADDRESS>:62826] PHP Notice:  Trying to access array offset on value of type null in /var/www/html/vendor/undera/pwe/PWE/Lib/Smarty/SmartyWrapper.php on line 23
[Thu Feb 17 10:30:43.984536 2022] [php7:notice] [pid 35] [client <IP_ADDRESS>:62826] PHP Notice:  Trying to access array offset on value of type null in /var/www/html/vendor/undera/pwe/PWE/Lib/Smarty/SmartyWrapper.php on line 23
[Thu Feb 17 10:30:43.984547 2022] [php7:notice] [pid 35] [client <IP_ADDRESS>:62826] PHP Notice:  Trying to access array offset on value of type null in /var/www/html/vendor/undera/pwe/PWE/Lib/Smarty/SmartyWrapper.php on line 24
[Thu Feb 17 10:30:43.984555 2022] [php7:notice] [pid 35] [client <IP_ADDRESS>:62826] PHP Notice:  Trying to access array offset on value of type null in /var/www/html/vendor/undera/pwe/PWE/Lib/Smarty/SmartyWrapper.php on line 24
[Thu Feb 17 10:30:43.987417 2022] [php7:notice] [pid 35] [client <IP_ADDRESS>:62826] PHP Notice:  Undefined index: link in /tmp/ac3af2300c29bed7f63db2e040c206a9311ccf17_0.file.plugins.tpl.php on line 113
[Thu Feb 17 10:30:43.987463 2022] [php7:notice] [pid 35] [client <IP_ADDRESS>:62826] PHP Notice:  Undefined index: link in /tmp/ac3af2300c29bed7f63db2e040c206a9311ccf17_0.file.plugins.tpl.php on line 119
[Thu Feb 17 10:30:43.987486 2022] [php7:notice] [pid 35] [client <IP_ADDRESS>:62826] PHP Notice:  Undefined index: !p in /tmp/ac3af2300c29bed7f63db2e040c206a9311ccf17_0.file.plugins.tpl.php on line 143
[Thu Feb 17 10:30:43.987560 2022] [php7:notice] [pid 35] [client <IP_ADDRESS>:62826] PHP Notice:  Undefined index: link in /var/www/html/vendor/undera/pwe/PWE/Utils/PWEXMLFunctions.php on line 22
[Thu Feb 17 10:30:43.987580 2022] [php7:notice] [pid 35] [client <IP_ADDRESS>:62826] PHP Notice:  Undefined offset: 1 in /var/www/html/vendor/undera/pwe/PWE/Core/PWECore.php on line 399
[Thu Feb 17 10:30:43.987685 2022] [php7:notice] [pid 35] [client <IP_ADDRESS>:62826] PHP Notice:  Undefined index: menu in /tmp/ac3af2300c29bed7f63db2e040c206a9311ccf17_0.file.plugins.tpl.php on line 207
[Thu Feb 17 10:30:43.987705 2022] [php7:notice] [pid 35] [client <IP_ADDRESS>:62826] PHP Notice:  Undefined index: selected in /tmp/ac3af2300c29bed7f63db2e040c206a9311ccf17_0.file.plugins.tpl.php on line 208
[Thu Feb 17 10:30:43.987724 2022] [php7:notice] [pid 35] [client <IP_ADDRESS>:62826] PHP Notice:  Undefined index: selected in /tmp/ac3af2300c29bed7f63db2e040c206a9311ccf17_0.file.plugins.tpl.php on line 208
[Thu Feb 17 10:30:43.987744 2022] [php7:notice] [pid 35] [client <IP_ADDRESS>:62826] PHP Notice:  Undefined index: selected in /tmp/ac3af2300c29bed7f63db2e040c206a9311ccf17_0.file.plugins.tpl.php on line 208
[Thu Feb 17 10:30:43.987773 2022] [php7:notice] [pid 35] [client <IP_ADDRESS>:62826] PHP Notice:  Undefined index: selected in /tmp/ac3af2300c29bed7f63db2e040c206a9311ccf17_0.file.plugins.tpl.php on line 208
[Thu Feb 17 10:30:43.987792 2022] [php7:notice] [pid 35] [client <IP_ADDRESS>:62826] PHP Notice:  Undefined index: selected in /tmp/ac3af2300c29bed7f63db2e040c206a9311ccf17_0.file.plugins.tpl.php on line 208
[Thu Feb 17 10:30:43.987807 2022] [php7:notice] [pid 35] [client <IP_ADDRESS>:62826] PHP Notice:  Undefined index: selected in /tmp/ac3af2300c29bed7f63db2e040c206a9311ccf17_0.file.plugins.tpl.php on line 208
[Thu Feb 17 10:30:43.987820 2022] [php7:notice] [pid 35] [client <IP_ADDRESS>:62826] PHP Notice:  Undefined index: menu in /tmp/ac3af2300c29bed7f63db2e040c206a9311ccf17_0.file.plugins.tpl.php on line 207

I will review it. Probably it got rusty over time.

It works fine for me like this:
docker build . -t jpgc && docker run -it -p 8080:80 -v `pwd`:/var/www/html jpgc

I think problem with php version and composer version and your cached docker layers.
Try this one:

FROM ubuntu:20.04
EXPOSE 80
RUN apt update && DEBIAN_FRONTEND=noninteractive apt install -y --force-yes apache2 php composer libapache2-mod-php php-xml mc less
WORKDIR /var/www/html
COPY . .
RUN a2enmod rewrite
RUN echo '<Directory "/var/www/html">' >> /etc/apache2/conf-enabled/99local.conf
RUN echo   'AllowOverride All' >> /etc/apache2/conf-enabled/99local.conf
RUN echo '' >> /etc/apache2/conf-enabled/99local.conf
RUN composer install
ENTRYPOINT service apache2 start && tail -f /var/log/apache2/*.log

Try using this Dockerfile with the command I showed above:
FROM ubuntu:20.04

EXPOSE 80

RUN apt update && DEBIAN_FRONTEND=noninteractive apt install -y --force-yes apache2 php libapache2-mod-php php-xml mc less php-curl

RUN a2enmod rewrite

RUN php -r "copy('https://getcomposer.org/installer', 'composer-setup.php');"
RUN php -r "if (hash_file('sha384', 'composer-setup.php') === '906a84df04cea2aa72f40b5f787e49f22d4c2f19492ac310e8cba5b96ac8b64115ac402c8cd292b8a03482574915d1a8') { echo 'Installer verified'; } else { echo 'Installer corrupt'; unlink('composer-setup.php'); } echo PHP_EOL;"
RUN php composer-setup.php
RUN php -r "unlink('composer-setup.php');"
RUN mv composer.phar /usr/local/bin/composer

RUN echo '<Directory "/var/www/html">' >> /etc/apache2/conf-enabled/99local.conf
RUN echo   'AllowOverride All' >> /etc/apache2/conf-enabled/99local.conf
RUN echo '</Directory>' >> /etc/apache2/conf-enabled/99local.conf

WORKDIR /var/www/html
ENTRYPOINT composer upgrade && service apache2 start && tail -f /var/log/apache2/*.log

# Implies we mount /site dir into /var/www/html

Tried your dockerfile and command. Same problem, same errors.
Maybe problem is not with docker, but my build? Do i need to do something else then mvn clean install -DskipTests?

And

Tried inside container:

composer check-platform-reqs
Checking platform requirements for packages in the vendor dir
ext-json   7.4.3    success
ext-posix  7.4.3    success
ext-xml    7.4.3    success
php        7.4.3    success

You are right, there was .htaccess file missing for PWE to work. I have fixed it:
FROM ubuntu:20.04

EXPOSE 80

RUN apt update && DEBIAN_FRONTEND=noninteractive apt install -y --force-yes apache2 php libapache2-mod-php php-xml mc less php-curl

RUN a2enmod rewrite

RUN php -r "copy('https://getcomposer.org/installer', 'composer-setup.php');"
RUN php -r "if (hash_file('sha384', 'composer-setup.php') === '906a84df04cea2aa72f40b5f787e49f22d4c2f19492ac310e8cba5b96ac8b64115ac402c8cd292b8a03482574915d1a8') { echo 'Installer verified'; } else { echo 'Installer corrupt'; unlink('composer-setup.php'); } echo PHP_EOL;"
RUN php composer-setup.php
RUN php -r "unlink('composer-setup.php');"
RUN mv composer.phar /usr/local/bin/composer

RUN echo '<Directory "/var/www/html">' >> /etc/apache2/conf-enabled/99local.conf
RUN echo   'AllowOverride All' >> /etc/apache2/conf-enabled/99local.conf
RUN echo '</Directory>' >> /etc/apache2/conf-enabled/99local.conf

WORKDIR /var/www/html
ENTRYPOINT ln -sf vendor/undera/pwe/.htaccess && composer upgrade && service apache2 start && tail -f /var/log/apache2/*.log

# Implies we mount /site dir into /var/www/html
# docker build . -t jpgc && docker run -it -p 8080:80 -v `pwd`:/var/www/html jpgc

It works now. Do i need to commit this updated dockerfile to this MR?

I have already committed it into main branch

So, does it match your expectation with regard to docs?

Closed due OpenModelThreadGroup released.


[BACKLOG-20717] Google Drive VFS pressing Close button throws an exception

@bmorrise Please Sir!

Build Completed
:x: This pull request has errors. They will need to be addressed before it can be accepted. See below for more details. Some links are also available below for further assistance in addressing those issues.
Build Commands
mvn -Dsurefire.runOrder=alphabetical -B -fn -f 'pom.xml' -pl 'plugins/pentaho-googledrive-vfs/core' -P '!assemblies' -amd clean install && mvn -B -f 'pom.xml' -pl 'plugins/pentaho-googledrive-vfs/core' -P '!assemblies' -amd site

Cleanup Commands
mvn -B -f 'pom.xml' -pl 'plugins/pentaho-googledrive-vfs/core' -P '!assemblies' -amd build-helper:remove-project-artifact

Changed files
  plugins/pentaho-googledrive-vfs/core/src/main/java/org/pentaho/googledrive/vfs/GoogleDriveFileSystem.java
  plugins/pentaho-googledrive-vfs/core/src/main/java/org/pentaho/googledrive/vfs/util/CustomDataStoreFactory.java

Unit Test Coverage
These statistics help you identify how your changes have affected the coverage of the following files. If a file is not in this list, then its coverage was not affected by your changes. To get some help interpreting these metrics, please refer to Jacoco's documentation.

:warning: Coverage Changes: -0.2% (click to expand)
org.pentaho.googledrive.vfs.GoogleDriveFileSystem

Branch Coverage: 0%
Complexity Change: -31.8% :small_red_triangle_down:
Instruction Change: -40.6% :small_red_triangle_down:
Line Change: -41.1% :small_red_triangle_down:
Method Change: -16.7% :small_red_triangle_down:

:new: org.pentaho.googledrive.vfs.util.CustomDataStoreFactory

Branch Coverage: 0% :exclamation:

Checkstyle violations
The code submitted is not complying with one or more of our guidelines. To perform these checks locally, please use this tool.
/home/buildguy/project/plugins/pentaho-googledrive-vfs/core/src/main/java/org/pentaho/googledrive/vfs/GoogleDriveFileSystem.java

:heavy_exclamation_mark: Using the '.' form of import should be avoided - org.apache.commons.vfs2.. at Line: 19

/home/buildguy/project/plugins/pentaho-googledrive-vfs/core/src/main/java/org/pentaho/googledrive/vfs/util/CustomDataStoreFactory.java

:heavy_exclamation_mark: Using the '.' form of import should be avoided - java.io.. at Line: 28

:heavy_exclamation_mark: Using the '.' form of import should be avoided - java.util.. at Line: 29

Build Completed
:fire: This pull request has some issues. It would be preferable to fix them in order for it to be just perfect. See below for more details. Some links are also available below for further assistance in addressing those issues.
Build Commands
mvn -Dsurefire.runOrder=alphabetical -B -fn -f 'pom.xml' -pl 'plugins/pentaho-googledrive-vfs/core' -P '!assemblies' -amd clean install && mvn -B -f 'pom.xml' -pl 'plugins/pentaho-googledrive-vfs/core' -P '!assemblies' -amd site

Cleanup Commands
mvn -B -f 'pom.xml' -pl 'plugins/pentaho-googledrive-vfs/core' -P '!assemblies' -amd build-helper:remove-project-artifact

Changed files
  plugins/pentaho-googledrive-vfs/core/src/main/java/org/pentaho/googledrive/vfs/GoogleDriveFileSystem.java
  plugins/pentaho-googledrive-vfs/core/src/main/java/org/pentaho/googledrive/vfs/util/CustomDataStoreFactory.java

Unit Test Coverage
These statistics help you identify how your changes have affected the coverage of the following files. If a file is not in this list, then its coverage was not affected by your changes. To get some help interpreting these metrics, please refer to Jacoco's documentation.

:warning: Coverage Changes: -0.2% (click to expand)
org.pentaho.googledrive.vfs.GoogleDriveFileSystem

Branch Coverage: 0%
Complexity Change: -31.8% :small_red_triangle_down:
Instruction Change: -40.6% :small_red_triangle_down:
Line Change: -41.1% :small_red_triangle_down:
Method Change: -16.7% :small_red_triangle_down:

:new: org.pentaho.googledrive.vfs.util.CustomDataStoreFactory

Branch Coverage: 0% :exclamation:


Replace QRegExp with QRegularExpression

Fixes https://github.com/bitcoin-core/gui/issues/578
Only made sure the code builds, not sure how to test.

Concept ACK.
As a preparation to Qt 6, I think this PR will benefit by incorporating of https://github.com/bitcoin/bitcoin/commit/f6adcadf643c3e3375d234ef0d0987f20bc9869b and https://github.com/bitcoin/bitcoin/commit/b649103d0554055470ea00cb46489c43c90796c9 in any reasonable way.

As a preparation to Qt 6, I think this PR will benefit by incorporating of bitcoin/bitcoin@f6adcad and bitcoin/bitcoin@b649103 in any reasonable way.

bitcoin/bitcoin@f6adcad is already part of c6b6106
the latter commit I just cherry-picked to this PR

It seems the CI is failing because it does not recognize filterRegularExpression and indeed it was introduced in Qt 5.12 while we still do support Qt 5.11.
I updated the second commit of the PR to use QT_VERSION check - see 54980a7994a13fa77b80503ba8574490e80c9649

Does it make sense to extract the "Extract first suffix from filter pattern..." functionality into a testable utility function?

not sure how to test.

Here is a branch with tests for the AddressBookPage class -- https://github.com/hebasto/gui/commits/220423-test-ab
And test fails for the 54980a7994a13fa77b80503ba8574490e80c9649 commit.

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Conflicts
Reviewers, this pull request conflicts with the following ones:

#593 (Getting ready to Qt 6 (8/n). Use QRegularExpression in AddressBookSortFilterProxyModel class by hebasto)
#592 (Drop wildcard support for address/label search in AddressBookPage by hebasto)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

🐙 This pull request conflicts with the target branch and needs rebase.
Want to unsubscribe from rebase notifications on this pull request? Just convert this pull request to a "draft".

I won't be able to work on this PR in the following days/weeks. Feel free to push into my branch (maintainers are allowed) or take over the PR completely if needed.

Picked up in #606


[BEAM-10334] Increase default grpc message length

The default limit of a grpc message is set low to 4 MB, and is not overridden in the sdk_worker.py for the _control_channel. This was first discovered when submitting a beam job via a flink operator orchestrated by kubernetes. This was fixed by modifying the options parameter to allow any size grpc message to be sent or received.

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[x] Choose reviewer(s) and mention them in a comment (R: @username).
[x] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
[ ] Update CHANGES.md with noteworthy changes.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

R: @charlesccychen

R: @lukecwik

Thanks @kshivvy!  This LGTM after lint.  Note that this issue was found while running benchmarks for TFX (https://github.com/tensorflow/tfx/tree/master/tfx/benchmarks) on Flink.

This LGTM.  Note that this logic is analogous to that here: https://github.com/apache/beam/blob/b83c06d47bd5e2e2905599297981353af234b034/sdks/python/apache_beam/runners/worker/sdk_worker.py#L701

Run Python PreCommit

Run PythonFormatter PreCommit

Run Python PreCommit

Run PythonFormatter PreCommit