flight_sql_client always failed with error "Received RecordBatch prior to Schema" when run a query

Which part is this question about

arrow-flight
Describe your question

I am using arrow-flightsql-odbc as a flightsql server. I am using flight_sql_client from arrow-rs/arrow-flight to act as a client to test it. It could connect to the server successfully. But when I run a simple query select 1, the client always failed with an error "Received RecordBatch prior to Schema". I am trying to figure out why this error could be generated. At server side I printed the RecordBatch value as below. It includes a schema and result in one RecordBatch. At client side the flight_data is also printed. We can see the FlightDataDecoder state is None which is causing this failure. From arrow-rs/arrow-flight/src/decode.rs we can see the flight data handle for RecordBatch. When the state is None, error "Received RecordBatch prior to Schema" is printed.  So my question is how I could make the state to be not None. The RecordBatch already included the schema,  should I send the schema in another standalone RecordBatch? The schema is already sent at the first FlightInfo message. Also the FlightInfo is handled at execute_flight of arrow-rs/arrow-flight/src/bin/flight_sql_client.rs. So I am not sure what is wrong. Could someone help here? Thanks in advance!
-- arrow-flightsql-odbc server side RecordBatch value.
[src/odbc_command_handler.rs:176] batch = RecordBatch {
    schema: Schema {
        fields: [
            Field {
                name: "",
                data_type: Int32,
                nullable: false,
                dict_id: 0,
                dict_is_ordered: false,
                metadata: {},
            },
        ],
        metadata: {},
    },
    columns: [
        PrimitiveArray<Int32>
        [
          1,
        ],
    ],
    row_count: 1,
}

--FlightInfo at client side
[arrow-flight/src/bin/flight_sql_client.rs:198] &info = FlightInfo {
    schema: b"\xff\xff\xff\xffx\0\0\0\x10\0\0\0\0\0\n\0\x0c\0\n\0\t\0\x04\0\n\0\0\0\x10\0\0\0\0\x01\x04\0\x08\0\x08\0\0\0\x04\0\x08\0\0\0\x04\0\0\0\x01\0\0\0\x14\0\0\0\x10\0\x14\0\x10\0\0\0\x0f\0\x04\0\0\0\x08\0\x10\0\0\0\x18\0\0\0 \0\0\0\0\0\0\x02\x1c\0\0\0\x08\0\x0c\0\x04\0\x0b\0\x08\0\0\0 \0\0\0\0\0\0\x01\0\0\0\0\0\0\0\0\0\0\0\0",
    flight_descriptor: Some(
        FlightDescriptor {
            r#type: Cmd,
            cmd: b"\nCtype.googleapis.com/arrow.flight.protocol.sql.CommandStatementQuery\x12\n\n\x08SELECT 1",
            path: [],
        },
    ),
    endpoint: [
        FlightEndpoint {
            ticket: Some(
                Ticket {
                    ticket: b"\nCtype.googleapis.com/arrow.flight.protocol.sql.CommandStatementQuery\x12\n\n\x08SELECT 1",
                },
            ),
            location: [],
        },
    ],
    total_records: -1,
    total_bytes: -1,
    ordered: true,
}

--flight_data at client side
[arrow-flight/src/bin/flight_sql_client.rs:210] &flight_data = FlightRecordBatchStream {
    headers: MetadataMap {
        headers: {
            "content-type": "application/grpc",
            "date": "Fri, 02 Feb 2024 22:30:31 GMT",
        },
    },
    trailers: Some(
        LazyTrailers {
            trailers: Mutex {
                data: None,
                poisoned: false,
                ..
            },
        },
    ),
    inner: FlightDataDecoder {
        response: "<stream>",
        state: None,
        done: false,
    },
}

-- code from arrow-rs/arrow-flight/src/decode.rs
impl FlightDataDecoder {
     ......
    /// Extracts flight data from the next message, updating decoding
    /// state as necessary.
    fn extract_message(&mut self, data: FlightData) -> Result<Option<DecodedFlightData>> {
        use arrow_ipc::MessageHeader;
        let message = arrow_ipc::root_as_message(&data.data_header[..])
            .map_err(|e| FlightError::DecodeError(format!("Error decoding root message: {e}")))?;

        match message.header_type() {
            MessageHeader::RecordBatch => {
                println!("Value of self.state before if: {:?}", self.state);
                let state = if let Some(state) = self.state.as_ref() {
                    state
                } else {
                    return Err(FlightError::protocol(
                        "Received RecordBatch prior to Schema",
                    ));
                };

-- FlightInfo handle at arrow-rs/arrow-flight/src/bin/flight_sql_client.rs
async fn execute_flight(
    client: &mut FlightSqlServiceClient<Channel>,
    info: FlightInfo,
) -> Result<Vec<RecordBatch>> {
    let schema = Arc::new(Schema::try_from(info.clone()).context("valid schema")?);
    dbg!(&schema);
    let mut batches = Vec::with_capacity(info.endpoint.len() + 1);
    batches.push(RecordBatch::new_empty(schema));
    info!("decoded schema");

    for endpoint in info.endpoint {
        let Some(ticket) = &endpoint.ticket else {
            bail!("did not get ticket");
        };

        let mut flight_data = client.do_get(ticket.clone()).await.context("do get")?;
        dbg!(&flight_data);
        log_metadata(flight_data.headers(), "header");

        let mut endpoint_batches: Vec<_> = (&mut flight_data)
            .try_collect()
            .await
            .context("collect data stream")?;
        batches.append(&mut endpoint_batches);

        if let Some(trailers) = flight_data.trailers() {
            log_metadata(&trailers, "trailer");
        }
    }
    info!("received data");

    Ok(batches)
}

Additional context

Running on Ubuntu 20.04 64-bit, I also updated  flightsql server proto files and arrow and arrow-odbc dependency to newest versions.

Hey @RoyZhang2022
I have left a comment on arrow-flightsql-odbc since I believe the error originates there, https://github.com/timvw/arrow-flightsql-odbc/issues/17#issuecomment-1925193622
Don't think this is an issue with how arrow-rs handles reading the FlightData

Closing this as looks to be issue in arrow-flightsql-odbc, see https://github.com/timvw/arrow-flightsql-odbc/issues/17#issuecomment-1928457997


On Freecen" search page: 500 result limit - still necessary?

Is the display limit of 500 results necessary? I would allow more then folk can choose to filter if they get too many.

Assigning @richardofsussex and taking myself off as he is working on this topic more widely

We can allow more than 500 search results.


Reserved bits in frame header

There are only 6 bits of unused flags that can accommodate changes introduced in future versions of this protocol. It will be good to have more "reserved" bits in the frame header (32 extra reserved). Thoughts?

That's a good question.
We never really now how much extra flags we'll need, the current design suppose that we won't heavily rely on those flags. That's why we only reserved for 8 of them.
That being said, if we end up with a lack of flags, we can always reserve the last bit as an indication for more flags present.

The negative of reserving extra bits is that it increases the length for every frame, so I would prefer sticking to the current 6 bit space for extra flags and I agree with @stevegury that we should not be relying on these flags much.

Remember that the flags are for the protocol operation and what it provides. This is different than the application need for flags, etc. Also, each frame type can have different flags. If a type needs more fields (flags or other fields), it can have them in other places after the Frame Header.

Considering this answered. Respond back if more to discuss.


Implementation of kernels on the edge space of graphs or simplicial complexes

This pull requests an implementation of kernels on the Edge space of a graph or a simplicial 2-complex.
I implemented the following:

the discrete space of edge space: written as a class in geometric_kernels/spaces/graph_edge.py, which allows backends based on numpy, pytorch and jax.
tutorials on this, as how graph kernel tutorial looks like. This includes:

numpy backend:

an example of the edge space of a graph, written in jupyter notebook in notebooks/EdgeSpaceGraph.ipynb
an example of the edge space of a simplicial 2-complex, written in notebooks/EdgeSpaceSimplicialComplex

jax and pytorch backends:

an example of the edge space of a graph, written in notebooks/backends/Jax_EdgeSpaceGraph.ipynb and notebooks/backends/PyTorch_EdgeSpaceGraph.ipynb
an example of the edge space of a simplicial 2-complex, written in notebooks/backends/Jax_EdgeSpaceSimplicialComplex and notebooks/backends/PyTorch_EdgeSpaceSimplicialComplex

testing on the space of GraphEdge: written in "tests/spaces/test_graph_edge.py"

Note that:

The above 8 files are the ones I wrote. All the modifications elsewhere are only about that I added few lines to look for the correct path of the geometric_kernels module (without installing it, since I need to test my own GraphEdge space).
The current implementation in fact does not contain Hodge-compositional kernels, instead, they are using the one set of kernel parameters on the whole eigenspace. To implement the Hodge-compositional kernels, we can define the three sets of eigenspaces individually, then allowing different sets of parameters.

Sorry for the late updates.
In this update, we have the following changes:

the space GraphEdge takes a graph and optional triangle list as inputs and builds a simplicial 2-complex. If no triangle list is provided, we look for all the 2-cliques. Of course, one can choose only using graph instead of simplicial 2-complex.
the space GraphEdge gives an eigenbasis together with their Hodge type specified, so to enable Hodge-compositional kernel
a Hodge-compositional kernel is enabled in a separate class MaternKarhunenLoeveKernel_HodgeCompositionEdge defined in geometric_kernels/kernels/karhunen_loeve.py which takes parameters for three subspaces as inputs.
minimal changes are made in geometric_kernels/kernels/matern_kernel.py, as well as in geometric_kernels/feature_maps/deterministic.py and geometric_kernels/sampling/samplers.py, to enable the option of using Hodge-compositional kernel.
tutorials in numpy, jax and pytorch are provided which gives how to define Hodge-compositional edge kernels in a simplicial 2-complex, as well as Hodge feature maps.

Please have a look at your convenience. Thanks :)

Thanks a lot, Maosheng! I plan to take a look in a week or two, after the deadline streak has passed.

Hi @cookbook-ms,
Thank you so much for implementing the Hodge compositional kernel!
I remember in the past we discussed a somewhat different design, which can hopefully relief the confusion of edges being implicitly oriented and which could better fit into the existing structure of the library. Please tell me if you would be willing to implement (perhaps some parts of) this proposal. What you won't do, I'll get around to doing myself in some time.
I'm copying a proposal from one of my old emails below. Well, rather a somewhat more detailed version of it.
GraphEdge space
— inputs are pairs (i, j) where i and j are indices of nodes. Internally, we have canonical orientation of edges and triangles (i < j and i < j < k), but interface-wise a user provides oriented edges as inputs and doesn't know of the internal orientation;
— by default (if no triangles are provided explicitly), triangles are all possible triangles;
— random samples edges as pairs (i, j), always in the canonical orientation (i.e. i < j);
— eigenpairs are ordered as usual, so the space is fully compatible with MaternKarhunenLoeveKernel, however,  we store a mask for div-free, curl-free and harmonic pairs, which can be used by HodgeCompositionalMaternKernel;
— goes together with the OrientedEigenfunctionsFromEigenvectors class.
OrientedEigenfunctionsFromEigenvectors eigenfunctions class
— inherits from EigenfunctionsFromEigenvectors, its __call__ calls the parent's __call__ with the right transform of X, X2 (so that they are converted from pairs (i, j) to the edge index in canonical orientation we use internally for the Laplacian).
HodgeCompositionalMaternKernel
— only works with the GraphEdge space;
— the kernel uses different hyperparameters for different groups of eigenfunctions,  using the mask.
In addition to the above classes, add a documentation page for theory of Hodge-compositional kernels on graphs/simplicial complexes.
Feel free to ping me if you want to discuss this more.

Hi Slava, please check my reply per item.

Hi @cookbook-ms,
Thank you so much for implementing the Hodge compositional kernel!
I remember in the past we discussed a somewhat different design, which can hopefully relief the confusion of edges being implicitly oriented and which could better fit into the existing structure of the library. Please tell me if you would be willing to implement (perhaps some parts of) this proposal. What you won't do, I'll get around to doing myself in some time.
I'm copying a proposal from one of my old emails below. Well, rather a somewhat more detailed version of it.
GraphEdge space — inputs are pairs (i, j) where i and j are indices of nodes. Internally, we have canonical orientation of edges and triangles (i < j and i < j < k), but interface-wise a user provides oriented edges as inputs and doesn't know of the internal orientation; — by default (if no triangles are provided explicitly), triangles are all possible triangles; — random samples edges as pairs (i, j), always in the canonical orientation (i.e. i < j); — eigenpairs are ordered as usual, so the space is fully compatible with MaternKarhunenLoeveKernel, however, we store a mask for div-free, curl-free and harmonic pairs, which can be used by HodgeCompositionalMaternKernel; — goes together with the OrientedEigenfunctionsFromEigenvectors class.

The space now takes a graph as the input where the orientations are not required, and the canonical orientations are given inside the class.
An extra option of using SC or not. If True: the edge space is in an SC; otherwise, in a graph.
The triangles are optional. If provided (and use SC), we use those to construct SCs; otherwise, we look for all possible triangles to construct SC.
Eigenpairs are ordered as usual now. I added an extra label which indicates the Hodge subspace it belongs to, so that it can be used for 'MaternKarhunenLoeveKernel_HodgeCompositionEdge'.
I didn't implement the 'random' sampling of edges as pairs of nodes. I'll fix this together with OrientedEigenfunctionsFromEigenvectors eigenfunctions class below.

OrientedEigenfunctionsFromEigenvectors eigenfunctions class — inherits from EigenfunctionsFromEigenvectors, its __call__ calls the parent's __call__ with the right transform of X, X2 (so that they are converted from pairs (i, j) to the edge index in canonical orientation we use internally for the Laplacian).
HodgeCompositionalMaternKernel — only works with the GraphEdge space; — the kernel uses different hyperparameters for different groups of eigenfunctions, using the mask.

'MaternKarhunenLoeveKernel_HodgeCompositionEdge' should be implemented as discussed already, which takes three sets of parameters as inputs.

In addition to the above classes, add a documentation page for theory of Hodge-compositional kernels on graphs/simplicial complexes.

I planned to do that after you pass the above.

Feel free to ping me if you want to discuss this more.

I see. I want to finish https://github.com/geometric-kernels/GeometricKernels/pull/149 asap, so, if that's okay, I'll take another look after you do

I didn't implement the 'random' sampling of edges as pairs of nodes. I'll fix this together with OrientedEigenfunctionsFromEigenvectors eigenfunctions class below.

I see. I want to finish #149 asap, so, if that's okay, I'll take another look after you do

I didn't implement the 'random' sampling of edges as pairs of nodes. I'll fix this together with OrientedEigenfunctionsFromEigenvectors eigenfunctions class below.

Now it samples random edges returning both the edges as pairs of nodes, also their indices. But it is much easier to use indices of edges to obtain the eigenvectors at the corresponding locations, thus computing the kernels. For this, I included a method to obtain the indices of given input edges.


Use Int/Long Consumer

As the title says

Just noting on this that this requires a recompile (not binary compatible) but given lambda use and recompile this should be no change (as opposed to a explicitly API change) ... just as it's a no change for the tests


v2.3.0-beta1: Plus button disappears from notes list

The plus button for creating notes vanishes from the notes list after archiving a note.
EDIT: it can't be brought back by any scrolling.
Android 10
Fairphone 3
Not rooted, no manipulations
Play Services 23.13.12
Webview 111.0.5563.116

The issue is a different one as it can be triggered by selecting and opening & closing the options drawer, already.

This is fixed in 2.3.0-Beta2.

Yup, that's no more, thanks!


should the default registry locations be changed?

the current default image locations are prefixed to gcr.io/cf-london-servces-k8s/bmo/, which might be @benmoss' personal account space. should this be moved to a location where other kubernetes-sigs/cluster-api related content lives? does such a place exist?
looks like some of the main cluster-api project images are at gcr.io/k8s-staging-cluster-api, that may be an option.

Yeah, probably! 😄

hi Ben! i'm going to bring this up at the cluster-api meeting this week, hopefully we can just use the staging.

Not sure how much work that would be to set it up but we could have a separate staging registry for kubemark, like we do for other providers eg. https://github.com/kubernetes-sigs/cluster-api-provider-azure/blob/master/Makefile#L102

/remove-lifecycle rotten

i am making some images available in my personal quay.io account at quay.io/elmiko/kubemark. i would like to propose using these images until we can find a better place. ultimately it would be beneficial to automate this process, but it requires building the various kubemark versions into images and i'm not sure where the proper place for this would be.

@elmiko looks like currently cr.io/cf-london-servces-k8s/bmo/cluster-api-kubemark/cluster-api-kubemark-controller:v0.2.2 is not present so because of which I m getting the following error
capk-system                         capk-controller-manager-77765c9d7d-dhjj4                         1/2     ImagePullBackOff   1          24h

will you be able to host this image in your namespace?

hey @gabhi , yes i have started to create images in my personal repo https://quay.io/repository/elmiko/kubemark?tag=latest&tab=tags
if everyone is ok with this, i can post a change to update the default location. it would be nice to ultimately find a home for the these images in a more "official" location, but currently the automation to build them all is slightly bespoke.

@elmiko do you who can help us in creating staging area? how should we proceed about this?

@elmiko May I know how I can use the code of https://github.com/kubernetes-sigs/cluster-api-provider-kubemark/blob/main/main.go#L56 to create mgmt cluster? Currently, it is stucked in "Back-off pulling image "gcr.io/cf-london-servces-k8s/bmo/cluster-api-kubemark/cluster-api-kubemark-controller:dev".

Thanks @elmiko for the detail info. I mixed kubemark image and kubemark-controller image before.  I use the dockerfile in this repo to build my own kubemark-controller image and live edit the capk-controller-manager  deployment to use the one I build. Now capk-controller-manager is running now.

i think we have answered this question, i am going to close this issue and create a new issue to capture the work. thanks everyone!

created #37


Error:Project :httpserver declares a dependency from configuration 'compile' to configuration 'default' which is not declared in the descriptor for project :libaums.

Apologies, if this is obvious. I'm not overly android savvy...
I get this error from within Android Studio.  Any advice on how to repair?  Thanks!
Error:Project :httpserver declares a dependency from configuration 'compile' to configuration 'default' which is not declared in the descriptor for project :libaums.

I have never seen this  are you trying the example app or are you including the libraries through Gradle in your project?

I literally just opened the app/build.gradle in Android Studio and it says “Gradle project sync failed. Basic functionality (e.g. editing, debugging) will not work properly”

On Oct 25, 2017, at 12:52 PM, Magnus<EMAIL_ADDRESS>wrote:
I have never seen this are you trying the example app or are you including the libraries through Gradle in your project?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

Try to open the top level build.gradle which is for the whole project (all modules).


ability to categories synth by wavetable, subtractive, additive, etc.

This is possible today for example:
https://studiorack.github.io/studiorack-site/instruments?category=synths&query=additive
Your query is matched against name, description or tags:
https://github.com/studiorack/studiorack-site/blob/main/lib/plugin.ts#L14
You can see that this plugin has additive in the description:
https://studiorack.github.io/studiorack-site/instruments/ryukau/vstplugins/iterative-sin-cluster


Solving merge conflicts

Merge Conflicts

Merge conflicts occur when competing changes are made to the same line of a file, or when one person edits a file and another person deletes the same file.
A merge can enter a conflicted state at two separate points. When starting and during a merge process.

Solving merge conflicts

The only correct way to solve conflicts is to pull new changes, create a new commit and push again.

Multiple ways to do this depending on how you use git: through command line, VS code, some GUI etc.

Written step by step: click here

Video tutorial for GitHub website: click here

Video tutorial for git command line: click here

Video tutorial for VS Code: click here

Looks Great, you can update the wiki with this information.
https://github.com/twindle-co/twindle/wiki/Resolving-merge-conflicts

Hi @sammjainn  I added the info into the wikipage, I didn't include the videos because they don't cover merge conflicts.


Edit Settings file seems to be ephemeral

Description
In the settings, under advanced option, when you click edit settings file, a file is opened with different options that you can change. When the changes are made and you save the file and restart files in order to take the new settings, this file is overwritten with the previous values.
So the settings file that we are changing seems to be ephemeral, or the actual settings file is somewhere else and not in the path that the files app opens.
Steps To Reproduce

go to settings -> advanced -> edit settings file
do some changes and save the file
restart files
open again the settings -> advanced -> edit settings file
you will notice that previous changes are discarded

Requirements
Settings file should be persistent for the user and not get overwritten.
Files Version
<IP_ADDRESS>
Windows Version
10.0.19045 Build 19045
Log File
debug.log

Thanks for the report, We're tracking this in #10935. You can check there or click subscribe in the right sidebar for updates.
You have to fully close Files for changes to save in the settings file, as Files runs in the background that would be with right clicking the system tray icon or finding files.exe in task manager.


"Călugăreni", "Căpșuna" are listed in the drop-down menu

Description:
When user writes ” Călugăreni” and "Căpșuna" the locations appear in the drop-down menu next to the comune and the county which is a part according to the law.
Precondition:
The website is up an running.

Step 1
Write in the search bar "Călugăreni"

Expected results
The location appears in the drop-down menu as "Sat Călugăreni, DÂMBOVIȚA (Cobia)".

Step 2
Press "x" button.

Expected results
The location was deleted from the search bar.

Step 3
Write in the search bar "Căpșuna"

Expected results
The location appears in the drop-down menu as "Sat Căpșuna, DÂMBOVIȚA (Cobia)".


Hard system crash when running: tf_cnn_benchmarks.py

So my system shuts off when I run the following command:
python3 tf_cnn_benchmarks.py --num_gpus=10 --batch_size=64 --model=resnet50 --variable_update=parameter_server --local_parameter_device=cpu
It happens during the warmup phase. I've got no logs as the crash kills the system and everything is lost when I turn back on. It's reproducible. I have rocm-smi running when it happens and the gpu aren't under a consistent load yet. They're still bouncing up and down from 20-90w and 0-100% load.
I'm on FC30 (kernel 5.1, amdgpu 3.30) with rocm 2.4 from the el7 repos. The system is an Epyc 7551p on a gigabye mz31. The GPUs are 5x Radeon Pro Duos that are power limited 100 watts per GPU from the factory.
My first thought was a power draw issues, but I'm using a single rail 1500w (thermaltake DPS) power supply and I ran a torture test without a crash, let alone a hard crash:
(1) Pegged all 32 cores / 64 thread.
(2) Constantly read from the drive.
(3) Ran an opencl(darktable) workload on my primary (nvidia p4000) gpu.
(4) Ran an eth mining workload(not ideal, but it was a way of making sure it wasn't rocm related) on all ten cards each drawing about (according to rocm-smi) ~80w.
I'm lost as to where I should start poking.

I switch my system from uma to memory numa modes and now that benchmark fails with a missing algorithm issue, but this runs fine:
python3 tf_cnn_benchmarks.py --num_gpus=10 --batch_size=16 --model=alexnet
How could that effect anything? it would appear that an address is not being translated correctly? I don't know. I guess I'm now, but maybe I can help track this bug down for the next user?

My system also experiences a system reset during the TF ResNet50 benchmark, though it depends on the benchmark settings. Using FP32 and a batch size of 64 has resulted in a reset 3 out of 4 times so far. Strangely enough the benchmark did complete correctly one time. As FP32/BS64 are the default settings in the ROCm TF quick start guide, perhaps a note could be added warning the user of a potential reset?
It is unclear to me if the reset is expected behaviour of TF or whether it is due to a bug in (the) rocm (TF port). I am willing to troubleshoot further, but would require guidance on how to proceed.
Details of my system setup:

rocm/tensorflow:rocm2.5-tf1.13-python3 docker image on an arch linux host system (5.1.8-arch1-1-ARCH kernel)
GPU: Sapphire Technology Limited Vega 10 XL/XT [Radeon RX Vega 56/64] -> Sapphire Radeon RX Vega 56 Pulse HBM2 - 8 Gb
Driver: amdgpu, /lib/modules/5.1.8-arch1-1-ARCH/kernel/drivers/gpu/drm/amd/amdgpu/amdgpu.ko.xz, srcversion:     ED0CB3420B32010EABFF1FF
Intel(R) Core(TM) i5-4670K (stable OC at 4GHz)
16GiB RAM

I've attached the logs of the following benchmark runs:
FP16/BS32 (no reset): python3 ./scripts/tf_cnn_benchmarks/tf_cnn_benchmarks.py --model=resnet50 --num_gpus=1 --batch_size=32 --summary_verbosity=1 --use_fp16
FP16/BS64 (no reset): python3 ./scripts/tf_cnn_benchmarks/tf_cnn_benchmarks.py --model=resnet50 --num_gpus=1 --batch_size=64 --summary_verbosity=1 --use_fp16
FP32/BS64 (3/4 reset): python3 ./scripts/tf_cnn_benchmarks/tf_cnn_benchmarks.py --model=resnet50 --num_gpus=1 --batch_size=64 --summary_verbosity=1 --nouse_fp16
tf-resnet50-benchmarks.txt

We have tried with ROCm2.5 on below details, not seeing the reported issue as mentioned by fvdnabee
Are you observing on UB 16.04.5 ( kernel as mentioned below) . If possible, can you give a try.
Looks like you are using "5.1.8-arch1-1-ARCH kernel" higher kernel.
GPU : Radeon RX Vega 64
Intel(R) Core(TM) i7-5960X CPU @ 3.00GHz
16GiB RAM
lsb_release -a
No LSB modules are available.
Distributor ID: Ubuntu
Description:    Ubuntu 16.04.5 LTS
Release:        16.04
Codename:       xenial
Kernel : 4.15.0-39-generic
Command : python3 ./scripts/tf_cnn_benchmarks/tf_cnn_benchmarks.py --model=resnet50 --num_gpus=1 --batch_size=64 --summary_verbosity=1 --nouse_fp16
Docker : rocm/tensorflow:rocm2.5-tf1.13-python3


Better options for spot instances: Support aws_ec2_fleet or aws_spot_fleet_request

I have issues
I'm submitting a feature request.
What is the current behavior?
No option of having a worker group run on either aws_ec2_fleet or aws_spot_fleet_request.
What's the expected behavior?
We should support this!
Current implementation using ASG/LC or ASG/LT are not as good and lack some of the advanced scheduling options that are available in aws_ec2_fleet and aws_spot_fleet_request. For example, specifying instance by number of CPUs instead of instance type.
It's super useful to run spot instances because:

You can save a load of money
AWS is pushing this too, e.g. 1, 2
Using k8s-spot-termination-handler will drain your nodes gracefully when prices change
The nature of k8s itself is well positioned for dealing with instances coming and going anyway
You can save a load of money!

Are you able to fix this problem and submit a PR? Link here if you have already.
Not sure just yet, still investigating

The definition of spot instances is visible here https://github.com/terraform-aws-modules/terraform-aws-eks/blob/master/examples/eks_test_fixture/main.tf#L73 and here https://github.com/terraform-aws-modules/terraform-aws-eks/blob/master/workers_launch_template.tf#L17
Is it helpful for you?

Is it helpful for you?

Not really 😃
That example will launch spot instances of only 2 instance types. That's great but I don't think 2 is enough to provide diversity for when AWS terminates the instances. Sometimes they will claim back instances or the price will suddenly rise for a single instance type or in a single AZ.
It would be ideal if this module could support between 2-6 instance type overrides per ASG. But I don't think it's possible to have them optional due to this issue: https://github.com/terraform-providers/terraform-provider-aws/issues/8475
And then supporting aws_ec2_fleet or aws_spot_fleet_request would allow for us to not even specify the instance type as you can just specify something like "I want instances with 4 CPUs", which is even more flexible.

I will close this now as with TF 0.12 we can support any number of instance overrides: https://github.com/terraform-aws-modules/terraform-aws-eks/blob/4369f0271b12cd3f98f705df036662f0660efa4b/workers_launch_template.tf#L124-L134


docs: update server docs link

Minor broken link on the docs homepage, go to /docs and check the link to server docs.

Just saw there's an earlier PR with a different fix in https://github.com/daytonaio/docs/pull/88.
Feel free to close this one if needed. 🏓

Thanks, @Tpuljak @nkkko! 💚

Thank you!


Luks with systemd-cryptenroll panics after a reboot

See https://github.com/Nitrokey/nitrokey-3-firmware/issues/283#issuecomment-1581517261

Environment:

Arch Linux
latest version of available packages: gpg 2.2.41, kwallet 5.106.0, kwalletmanager 23.04.1 at this very moment
full disk encryption with unlocking using FIDO token, the token was enrolled using systemd-cryptenroll
KDE wallet encrypted using GPG keys
GPG keys reside on Nitrokey 3A NFC
FW version is 1.5.0, but the same was observed with 1.4.0 as well

if I unlock the wallet in KDE successfully and then reboot the machine without replugging the token, the token panics with red LED on disk FIDO decryption.

Unlocking the KDE wallet requires GPG, there seems to be some conflicts between GPG and FIDO-authenticator

I can also confirm this issue with token panic on a freshly installed system on a different machine.

Like #283 it was fixed by https://github.com/Nitrokey/nitrokey-3-firmware/pull/289


Mac App Icon Does Not Match Big Sur Design Language

Currently, the version on the mac App Store does not have an icon appropriate to the Big Sur design language.
Steps to reproduce:

Install app from the mac App Store
View icon, e. g., in dock or in the launchpad compared to others.

Expected behavior:
Having an icon which is compliant with the guidelines from Apple.
Actual behavior:
The icon looks, compared to the others, out of place.
Server Setup Information:
multiple, irrelevant in this context.
Client Setup Information:
Desktop App or Browser Version: App from the mac App Store, 3.0.3
Operating System: macOS Big Sur 11.4

Thanks for moving the issue.
Additionally: Can I expect that the Mac App Store Version will receive the update soon or is this version abandoned and I should just install it manually?

Bumping on this. I am surprised that whoever handles publishing the MAS app bothered to put in the app privacy info, but didn't bother to update the app binary at all. Is it dead in the water?

We will be working in updating the Apple Store version.
For now, please keep using the Github releases page for install it.

The Apple Store version is updated, you can install it from there right now.


[fix docs compiler warnings] Glutton pallet

This PR fixes 7 missing doc warnings in the Glutton pallet

Please also add #![deny(missing_docs)], otherwise this will get out-dated.

bot merge


Drop office=administrative

Would it be possible to drop the office=administrative preset?
The tag has been marked as 'discouraged' http://wiki.openstreetmap.org/wiki/Tag:office%3Dadministrative after a discussion on the tagging mailinglist and a vote on the wiki in 2016: http://wiki.openstreetmap.org/w/index.php?title=Proposed_features/Government_offices
The main issue was that the meaning of this tag is not clear. The tag is often used for offices of national or local governments, for which office=government is more explicit.

Sounds good to me, thank you for linking to the relevant discussion about the tag 👍


Pipe and echo logging output off by 1 character

When piping output to the slog functions, text is offset by 1 additional character compared to when passing the text as a parameter.

Missing space between level text and log message when output is to both screen & log and log message passed as parameters to the Slog* function.  Picked up with pipes.sh where SlogLevel uses SlogConfig to log the logging level and then pipes log messages.


Include enriched sparse lexical retrieval methods

First, a thank you. The paper and repo have been fantastic resources to help conversations around out-of-domain retrieval!
Second, a feature request. I think it would be very interesting to see some of the document/index enrichment approaches added to the benchmark and paper discussion, as extensions to sparse lexical retrieval. You mention both doc2query and DeepCT/HDCT in the paper but don't provide benchmark data for them. Since they are trained on MS MARCO, it would be interesting to see if they perform well out-of-domain and in-comparison to both BM25+CE and ColBERT which perform very well out-of-domain.

Hi @joshdevins,
I also find this feature interesting and it's already planned to be added to the BEIR repository in the future.
I have started to integrate with Pyserini and we currently have Anserini-BM25 and RM3 expansion added in BEIR.
Doc2query would be the next to be added to the repository and should be easy to add to the repo.
Regarding DeepCT, I would need to have a look at the original repository and check how easily it can be integrated with BEIR repo. Hopefully, it should not be difficult to integrate.
I shall update you once both methods have been added to the BEIR repository.
Kind Regards,
Nandan

Ok that sounds great @NThakur20. I'm definitely more interested in doc2query as it performs much better in-domain than DeepCT, so even that additional datapoint in the benchmark would be really useful.

Hey @NThakur20, a colleague pointed me to a new paper that might also be interesting that kind of fits into the sparse lexical retrieval category. Looks like they have model checkpoints already but the indexing and retrieval is using custom indices (as far as I can tell).
COIL: Revisit Exact Lexical Match in Information Retrieval with Contextualized Inverted List
https://github.com/luyug/COIL

Hi @joshdevins,
Thanks for mentioning the resource. The paper you mentioned was presented in NAACL and I had a long chat with the paper authors regarding the same. We are in talks to integrate the COIL paper into the BEIR repository.
Kind Regards,
Nandan

Hi @joshdevins,
I've added code to evaluate docT5query with the BEIR benchmark. You can a sample code here to run and evaluate it using Pyserini-BM25 - (link).
Kind Regards,
Nandan Thakur

I'm gonna have a look at this this week. Can I add results here for inclusion in the Google Sheets "leaderboard"?

Hi @joshdevins,
Yes, I haven't been able to get time to run docT5query for all BEIR datasets, as you mentioned it takes time.
Also, finally, I have a working example up for DeepCT. The original DeepCT repository is quite old and only worked with TensorFlow 1.x, Had to modify it to the latest TensorFlow versions. You can find a sneak peek here: https://github.com/UKPLab/beir/blob/development/examples/retrieval/evaluation/sparse/evaluate_deepct.py
I would merge it with the main branch soon! I enjoyed your debate in Berlin Buzzwords 2021.
Kind Regards,
Nandan

I'm running most of the docT5query examples now, but I won't have access to a couple datasets since they require accepting dataset use agreements. I'll post results for what I can run here.

Sounds good, Thanks @joshdevins!
I look forward to the results 😊
Kind Regards,
Nandan

Note that some datasets we don't have access to due to usage restrictions so they have been excluded.

dataset
baseline
score
+/-

msmarco
0.228
0.5064
🔼

fever
0.753
0.6926
🔽

climate-fever
0.213
0.1772
🔽

hotpotqa
0.603
0.5441
🔽

dbpedia-entity
0.313
0.3012
🔽

nq
0.329
0.3412
🔼

webis-touche2020
0.614
0.5246
🔽

trec-covid
0.656
0.6609
🔼

quora
0.742
0.7821
🔼

cqadupstack
0.316
0.2937
🔽

fiqa
0.236
0.2433
🔼

scidocs
0.158
0.1558
🔽

scifact
0.665
0.6599
🔽

I don't understand the msmarco result though. Something seems to be off on that one. I have the pyserini.jsonl in case you want to have a look.


fixes #34

Description
Fixes #34
Type of change
Please delete options that are not relevant.

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[x] This change requires a documentation update

How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

[ ] Self Code Review
[x] Tested on example project

Checklist:

[ ] My code follows the style guidelines of this project
[ ] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[ ] Changed the example project to contain the new feature (only if applies)

https://github.com/BrunoJurkovic/flip_card/issues/34#issuecomment-842272631
doesnt work yet

@HannesGitH Any update regarding this?

@HannesGitH Any update regarding this?

sadly not, and im kinda busy currently..
i might come back to this in the future if it still persists then
feel free to close this PR for now


How do i generate a csv file for the data collected in CARLA Simulator version 0.9.5

You can use the csv Python module. Just save the data you are interested in (velocity, steering angle, etc.) within arrays for each frame and store all the information in a csv file after the simulation is done.


fix(RadioButtonGroup): Fix RadioButtonGroup design bugs

Status :
Ready

Description :
Fix design related bugs

Related Issues :
#287
Todos

[x] Tests
[x] Documentation

:tada: This PR is included in version 1.0.1 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


add deploykit

1、paddle2onnx新增了部署模块

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.wangsiyuan06 seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


Failed to get ntoskrnl.exe ( Windows 11 24H2 )

It says Failed to get ntoskrnl.exe

Something weird is going on..

https://github.com/TheCruZ/kdmapper/issues/120

Fixed https://github.com/TheCruZ/kdmapper/commit/5c83427142f0b6f6d72302d1e6c618bc875c3489


Axis panel needs to show axis values

With options for:

user values
normalized values
normalized hex
normalized as integer between -16384 and +16384

Fixed in ff875c54c9cf99e02d5de4fca870946ea7cc2dd9


Contract managment with users and organization teams.

Try our other post , which is the follow up on the fratenate page, it is for the engineering enviorment, however the long term intention is a contract builder , difficult to explian , but i suspect may be what your are looking to achieve.
https://heavy-lifting.herokuapp.com/

p.s it is definitly a work in progress.

Yes, it very well may be, could save me a lot of time on defining more of the routing logic, table display, and mongo models which has been the most challenging part for me. Thank you very much! I will look into re-building directly from Heavy Lifting most likely.
My recaptcha always thinks I'm a robot as well, would you have any links with info on that? I've not found anything, I already added localhost to my allowed URL.

the domain needs to read "localhost"
the .env file needs to be changed to have your secret etc included.
Then likley the issue , the page with the recaptch div needs to have the correct sitekey!

Just a note on the heavy-lifting site , it is really a alpha version , and you will likley get stuck, I am planning on completing the team managment first , then rebuilding it from scratch with the integrated team managment and commercialization .

That's okay, I'm fine with experimenting, this is half a learning exercise for me. I can tell it's more alpha, but I may pull what I want from both projects. Thank you for the excellent boilerplate!
The recaptcha "works", I get the images to click, it just then always kicks me to /signup and it says I'm a robot. I'll keep googling.

https://github.com/Raltrwx/mercetplace2
If you're curious, just quickly smashed them together. Thanks again.


Set a variable that can be used in any command

So let's say I have an URL like Given I am on "/some-url-that-might-change-from-time-to-time".
This is used 50 times in 50 different scenarios. So when that URL is invalid I need to replace it. Is there a way to use a variable for that string. E.g.: Given I am on "$url_var"?
This would be very helpful for me.
And I know I could extend or write my own Given I am on "/some-url-that-might-change-from-time-to-time" function that contains that variable. But I don't want to write more custom function that I need to.

'''gherkin
Given I am on "Account Index" page
'''
and then mach this to url or even to route

You can have a look at the extension https://github.com/edno/codeception-gherkin-param

Ahh right, via return $url; correct. Thank you.


Add Temurin download buttons

Add example buttons that link to the Temurin download page

Part of https://github.com/adoptium/website-v2/issues/395


Add reasoning to each section

I wonder if it would be good to add, directly in the spec, reasoning for each section. This might add more extraneous content to the spec, but it might make it clearer why certain choices have been made. Thoughts?

IETF RFCs add a section at the beginning saying that X Y and Z should be interpreted as described by some other spec, so that there isn't anything ambiguous. I like what it offers but dislike the implementation cause it is too verbose.
An idea:
Each time there is a word that has a meaning on the standard-readme space, you could add a special char (like ⊛) and add a link to this repo, on the section that describes that word meaning in the context.

Hmm. I was not clear enough.
I mean, should there be justifications for decisions made in sections - not in the case of confusing terminology, but in the case of "Why did you put the Contribute section here?", or, "Why README and not readme?" This could also be discussed in the issues, and perhaps that is a better place to do it.

I am going to not do this. I think that any questions can happen in the issues, and trying to a priori predict them is bound to be suboptimal.


Update for Flarum beta 8

Changes made:

Modified all the JS directories accordingly
Updated bootstrap.php to utilize new Extenders

Renamed to extend.php

Removed unnecessary Listeners
Update icons for FontAwesome 5
Updated content modifier to use new interface

ConfigureWebApp is now in the Frontend extender

Rename assets -> resources and move less & locale -> resources

Flarum copies assets folder in extension roots, so it was copying the HTML files that had no reason to be copied

Updated & simplified .gitattributes & .gitignore

Looking great! Thanks for the hard work.


Generate Samples for the targeted platforms

I've used this wizard to create a new kmp library project structure, but I spent some time setting up samples for the platforms I target in the library just to have a small demo.
It would be great to generate a sample for each platform target that can be run directly from the IDE.
I can help with a PR if this something is welcome to generate samples for: Android, Desktop, and possibly Web(JS & Wasm), but I'm not on mac, and I lack experience with IOS, so, I'm not sure if I can add a sample for it, but this should be trivial to add by someone else.

done


[Enhancement] Working directory setting enhancements for KCL CLI with compile setting files

Enhancement
When the compilation working directory of KCL CLI is not set, the directory where the compilation configuration file such as kcl.yaml is located is used as the working directory instead of pwd.

Close with #430

Close with #430.


Medium clue - This particular clue does not tell you the second emote you must do

https://i.imgur.com/mddhHhF.png
https://i.imgur.com/P90UM3K.png
its the same clue as mentioned before that didn't have the floor tile. P.S took me 10 minutes or more to figure out that i needed to wave before talking to the guy lool

Fixed in #1428


getting an error while running the code.

can you please help me solve the error.

hello, do you solve the error?


Update README.md

Updating the npx command from fe-fwk to fe-fwk-cli as described in Issue #66.

Thanks @jyousefi !


Adjustments for sequencing

Hi Patrick, thank you for the great tool!
We have some questions on the old CITE-seq-Count that had "Bad Antibody structure" output vs the current one, and how to adjust for our current sequencing platform.
We now sequence TotalSeqA libraries on their own now using a Next-seq kit. Because the Next-seq handles low complexity libraries poorly. After the 15bp barcode(+B) gets sequenced we now get either PolyA or G. The G is outputed if it repeated encounters the same nucletoide across all transcripts (which is A) in consecutive cycles. In other words does the current CITE-seq counter assume 15bp-B-GGG as an error so throws it out? If doesn't throw it out, great. If it throws it out, how would you adjust the parameters to permit counting them in using your package? We use totalseqA + v3 kit.
Kind regards,
Moore

Hello @danmoore1987
The new versions don't check for the bad structure anymore. This was a legacy constraint when the technology was still young. The base "B" is not checked anymore. It's just the 15bp mapping or not and it doesn't care about the GGG or AAA after the 15th base.
bad_struct is replaced by unmapped and incloses any read which doesn't map or has too many errors.
I suggest you run the new version on the old dataset and compare it with the new to see how different it is.
One thing you will see is that the number of UMI will decrease since now we do umi and barcode correction.
Let me know how it compares.

Hi @Hoohm,
Thank you for the prompt reply! Will test out.

Hello @danmoore1987,
any news regarding this issue?

Closing this for now, feel free to reopen.


How to add customConnections attribute

@Xairoo Great point. Something I actually completely overlooked.
However, there is a more "noob-friendly" way to get the server id/url via the media info "View XML". Dev tools (while often faster) can get very busy if you have access to multiple servers, you you might end up grabbing the wrong server id.
I added a detailed steps to initially add the custom access URL (24716ae0b3b5bd3f41bc3d31bb9616b7bbce6298).
Cheers for the PR (and sorry for only getting to it now)!


'Cannot parse JSON' error

This issue is to report that a 'cannot parse JSON' error is returned for the Features functionality in ICEES DILI, I'm not entirely convinced that it is a Swagger UI issue because it is only affecting the ICEES DILI dev instance (not the ICEES Asthma dev or ICEES PCD dev instances). See #223.

Update: The JSON parse error occurs when the same query is run on the ICEES DILI dev instance on ebcr0 (https://icees.renci.org:16341/apidocs#) and the ICEES DILI prod instance on Sterling (https://icees-dili.renci.org/apidocs).

I did notice this when using DILI data to debug ICEES locally and I actually spent some time debugging into the code and added Json parser code to parse the generated JSON output and it succeeded without any problem, yet Swagger UI complains it cannot parse the same JSON output. So I concluded it is the Swagger UI issue. I also noticed Swagger UI can parse some JSON output from some query, but cannot from some other query. The fact that the same json output can be parsed using JSON library makes me think it is a Swagger UI issue.

I independently stumbled into this. I don't think it's a swagger issue. We seem to be returning invalid JSON. This happens when some calculations return NaN and theses are not properly serialized to null. Here is a query that will return invalid JSON.
{
  "message": {
    "query_graph": {
      "edges": {
        "e00": {
          "subject": "n00",
          "object": "n01",
          "predicates": [
            "biolink:correlated_with"
          ]
        }
      },
      "nodes": {
        "n00": {
          "ids": [
            "PUBCHEM.COMPOUND:132508376"
          ]
        },
        "n01": {
          "categories": [
            "biolink:NamedThing"
          ]
        }
      }
    },
    "knowledge_graph": {
      "nodes": {},
      "edges": {}
    },
    "results": []
  }
}

The interesting/bad/NaN part is returned for a particular edge. In the below I have quoted the NaNs so that they parse and look nice on GitHub, but in the returned JSON they are not quoted.
{
  "MESH:C070076_UNII:ME6U10SD7D_3f5adc9e": {
    "predicate": "biolink:correlated_with",
    "subject": "MESH:C070076",
    "object": "UNII:ME6U10SD7D",
    "attributes": [
      {
        "attribute_type_id": "contigency:matrices",
        "value": [
          {
            "feature_a": {
              "feature_name": "TLR4_AGE",
              "feature_qualifiers": [
                { "operator": "=", "value": "0-2" },
                { "operator": "=", "value": "3-17" },
                { "operator": "=", "value": "18-34" },
                { "operator": "=", "value": "35-50" },
                { "operator": "=", "value": "51-69" },
                { "operator": "=", "value": "70-89" }
              ],
              "year": null,
              "biolink_class": "biolink:PhenotypicFeature"
            },
            "feature_b": {
              "feature_name": "Avg24hAcetaldehydeExposure_2",
              "feature_qualifiers": [
                { "operator": "=", "value": 1 },
                { "operator": "=", "value": 2 },
                { "operator": "=", "value": 3 },
                { "operator": "=", "value": 4 },
                { "operator": "=", "value": 5 }
              ],
              "year": null,
              "biolink_class": "biolink:SmallMolecule"
            },
            "feature_matrix": [],
            "rows": [
              { "frequency": 0, "percentage": "NaN" },
              { "frequency": 0, "percentage": "NaN" },
              { "frequency": 0, "percentage": "NaN" },
              { "frequency": 0, "percentage": "NaN" },
              { "frequency": 0, "percentage": "NaN" }
            ],
            "columns": [
              { "frequency": 0, "percentage": "NaN" },
              { "frequency": 0, "percentage": "NaN" },
              { "frequency": 0, "percentage": "NaN" },
              { "frequency": 0, "percentage": "NaN" },
              { "frequency": 0, "percentage": "NaN" },
              { "frequency": 0, "percentage": "NaN" }
            ],
            "total": 0,
            "p_value": 1.0,
            "chi_squared": 0.0
          }
        ]
      }
    ]
  }
}

@kennethmorton Thanks for all the specific details. I must have looked into a wrong query result or something when I debugged this, since I printed out the query results and put them into a JSON parser and it parsed it without issues. I will look into this further trying to resolve it.

FWIW, I think Kenny's explanation might explain why the error surfaced only when testing ICEES DILI, not ICEES Asthma or ICEES PCD.

I failed to mention above, but that query is for the Asthma instance.

I noticed, but I still think your explanation may explain the error I received with the queries I was testing.

Per Kenny: We may want to try a more rigorous JSON serializer, perhaps orjson.

Hong is implementing a fix to change the formatting of the ICEES tables such that queries will return valid JSON even for NaN/null values.

Closing issue after extensively testing non-KG and KG endpoints for ICEES Asthma, DILI, and PCD instances.


Add NormalizePath() to IntrinsicFunctions

Rather than just "fix" the file path, this normalizes it and fixes the directory separators.  I did not make a unit test because FileUtilities.NormalizePath() is well tested.
Closes #55

FileUtilities.NormalizePath() can throw, what happens when use in a project file causes an exception?

Excellent question.  If you pass it an empty string, you get an error during your build:
Microsoft (R) Build Engine version 15.1.418.63065
Copyright (C) Microsoft Corporation. All rights reserved.

Build started 11/30/2016 8:10:23 AM.
Project "C:\Users\jeffkl\Desktop\55.proj" on node 1 (default targets).
C:\Users\jeffkl\Desktop\55.proj(11,14): error MSB4184: The expression "[MSBuild]::NormalizePath(*<>)" cannot be evaluated. Illegal characters in path.
Done Building Project "C:\Users\jeffkl\Desktop\55.proj" (default targets) -- FAILED.

Build FAILED.

"C:\Users\jeffkl\Desktop\55.proj" (default target) (1) ->
(Build target) ->
  C:\Users\jeffkl\Desktop\55.proj(11,14): error MSB4184: The expression "[MSBuild]::NormalizePath('')" cannot be evaluated. Parameter "path" cannot have zero length.

    0 Warning(s)
    1 Error(s)

Time Elapsed 00:00:00.26

If you have invalid characters you get this:
error MSB4184: The expression "[MSBuild]::NormalizePath(*<>)" cannot be evaluated. Illegal characters in path.

Invalid UNC path:
error MSB4184: The expression "[MSBuild]::NormalizePath(\\??\\)" cannot be evaluated. The UNC path should be of the form \\server\share.

But if you specify a path that's too long, you get a very strange error:
C:\Users\jeffkl\Desktop\55.proj(12,14): error MSB4184: The expression "[MSBuild]::NormalizePath(12345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890
1234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890)" cannot be evaluated.<PHONE_NUMBER>123456789012345678901234567890123456789012
34567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678
901234567890

I'll figure out what that is all about.  Do the other errors seem like they are a good user experience?

@jeffkl put a non-digit character in there--we may be trying to coerce it to an int or something?

Okay I fixed the PathTooLongException message so now it says:
error MSB4184: The expression "[MSBuild]::NormalizePath(12345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890
1234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890)" cannot be evaluated. The specified path, file name, or both are too long.
 The fully qualified file name must be less than 260 characters, and the directory name must be less than 248 characters.

@rainersigwald

put a non-digit character in there--we may be trying to coerce it to an int or something?

A number doesn't appear to matter:
<Message Text="Result: '$([MSBuild]::NormalizePath(123))'" />

  Result: 'C:\Users\jeffkl\Desktop\123'

Anything else I should try?

  Before I spent any time looking into it I figured I'd ping you just in case you knew what the problem is or where to start.

@jeffkl I filed #1409 since in my feature branch I just disabled it. Would really like to get to the bottom of it, though.

@jeffkl: my best guess, since the failure is deep within libgit2sharp in reading a tree object, is that the git commit is corrupted/invalid, or that the server didn't initialize the .git directory correctly.
My first suggestion is to try to build again on a clean agent (that has no prior git clone).
My second suggestion is run git fsck on a clone with that commit in it to see if it's invalid somehow.

@AArnott thanks a lot, I'll see what I can figure out.

@AArnott I was able to figure out that our CI build definition changed recently to do a shallow clone and so GitVersioning obviously wouldn't be able to calculate commit height.  I changed the setting back in the build definition and everything is working again.  Just a heads up in case anyone else hits the issue.  Thanks again for pointing me in a direction.

@dotnet-bot test Windows_NT Build for Desktop please

I decided to add a NormalizeDirectory() as well which can be used to combine, normalize, and ensure a trailing slash.  Passing in an empty directory will return String.Empty rather than throwing an error.

@jeffkl Thanks for letting me know what it was. NB.GV does document that shallow cloning isn't supported, but it would be interesting for me to test this further so that instead of a strange failure like this it could give a more helpful message to reduce time like yours spent investigating. I've filed https://github.com/AArnott/Nerdbank.GitVersioning/issues/92 to track.


rspec version

Hi.
There a dependency on rspec 3.3, but there used a config option silence_filter_announcements that was introduced only in 3.4 version
https://github.com/rspec/rspec-core/blob/master/Changelog.md

Pushed a new version to Rubygems


metrics(ticdc): fix tikv_cdc_min_resolved_ts_no_change_for_1m

What problem does this PR solve?

Issue Number: close #10354
What is changed and how it works?
Check List
Tests

Unit test
Integration test
Manual test (add detailed scripts or steps below)
No code

Questions
Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?
Release note
Please refer to [Release Notes Language Style Guide](https://pingcap.github.io/tidb-dev-guide/contribute-to-tidb/release-notes-style-guide.html) to write a quality release note.

If you don't think this PR needs a release note then fill it with `None`.

/retest

/check-issue-triage-complete

/retest

/retest

/retest

/retest


VF: Force no-prompt upgrade to grub-pc on U18

Fixes: #1344
Fixes an issue specific to the Vagrant box that we use, where grub-pc needs to be upgraded with the DEBIAN_FRONTEND=noninteractive variable, to stop a prompt coming up on the apt-get upgrade task in the playbook.
In draft until I can run it through VPC properly.

https://askubuntu.com/a/147079
The first reply to this answer mentioned that if sudo is put after, it won't set the variable properly. It worked when ir an it on my mac :-)

https://ci.adoptopenjdk.net/view/Tooling/job/VagrantPlaybookCheck/OS=Ubuntu1804,label=infra-softlayer-ubuntu1804-x64-1/637/console
Works! 👍


Convert LaunchConfiguration to a LaunchTemplate

This positions us to use the same config for an ASG as a SpotFleet. See https://aws.amazon.com/about-aws/whats-new/2017/11/introducing-launch-templates-for-amazon-ec2-instances/ for some more context.

Argh, unfortunately I can't find a way to specify a spot price for ASG's with LaunchTemplates.


Skipped distrbuted tests show up as passed (return 0)

          Note that this can be very misleading because a skipped test also returns 0, so it can make it seem like a test passed when it didn't run

Originally posted by @carmocca in https://github.com/Lightning-AI/lightning-thunder/pull/130#discussion_r1551712686

@t-vi adds:

Seems like Python 3.12 fixes that in unittest ( https://github.com/python/cpython/issues/106584 ), so there probably is a canonical "what to do" but I am not sure if there is an easy way to do this for pytest, too.

https://stackoverflow.com/questions/31538941/pytest-overall-result-pass-when-all-tests-are-skipped has some suggestions via pytest's conftest.py


fix(common): ensure target exists

Hello,
This PR handles the situation where you are trying to create a new page in a crashed browser.
Stack trace related: https://sentry.io/share/issue/5cc5151149fd4bb18126dd470311f4ed/
I'm not sure if the target check should be done as well at:

https://github.com/puppeteer/puppeteer/blob/87fe99a54ae5b9e7eff541b9ce794adc2d746e4a/src/common/Browser.ts#L297
https://github.com/puppeteer/puppeteer/blob/87fe99a54ae5b9e7eff541b9ce794adc2d746e4a/src/common/Browser.ts#L308

Could you add a test?

Could you add a test?

@mathiasbynens yes, although I'm not familiar with puppeteer testing scaffolding.
Maybe can you point me where is the current test for target._initializedPromise, then I can extend it?

@mathiasbynens yes, although I'm not familiar with puppeteer testing scaffolding.
Maybe can you point me where is the current test for target._initializedPromise, then I can extend it?

https://github.com/puppeteer/puppeteer/blob/main/test/target.spec.ts seems like a reasonable place to add the new test. You can probably use chrome://crash in the test to trigger a crash. Make sure the test fails without your change, and succeeds with it.

@jschfflr Can you help @Kikobeats?

Yeah sure, happy to help!
What do you mean by:

@mathiasbynens I tried to add the test but it was pretty hard for to me keep the project running on my local :(

Could you elaborate on the challenges you are facing?

@jschfflr essentially still I need to add the test to finally land this

Let me know if I can help with the tests!

I tried to write a test for reproducing the issue:
const { page, browser } = getTestState();
page.goto('chrome://crash').catch(() => {});
await waitEvent(page, 'error');
process.kill(browser.process().pid, 'SIGKILL')
console.log('creating page')
const newPage = await browser.newPage()

but even in the worst scenario looks like the internal target._initializedPromise is present.
Also looks like the original error traced expired, so I'm going to close for now, revisit in the future if needed.

@Kikobeats Thanks for updating the bug. Feel free to open it again if the problem comes up again!


Cloud functions delete deploy

think that it will be effective here to use streaming uploading.
http://docs.python-requests.org/en/master/user/advanced/#streaming-uploads
@mik-laj : We are already using streaming :) -> requests.put is also streaming the upload - it's just different HTTP method used than in the documentation of streaming (PUT instead of POST)

Nit: I would drop the exclamation.
Also, grammatically better form would be:
The mutually exclusive fields X and Y, belonging to the union Z, are both present. Please remove one.
@dejwk : Fixed in 3722a2be480c6d8080fc60491e8fa431b7eb6590


It's not compatible with version 3.3.5

It is a wonderful add-on.But it is not compatible with version 3.0.4 and latest version.Is will get a fix in future?

It works fine. You need to re-install processing-java via the menu in Processing.


Better typescript support

Resolves this issue https://github.com/maierfelix/nvk/issues/36
Changes:

Better imports using typescript standards
Auto link platform declarations on npm install

There is a post install script that creates a system link between the platform specific index.d.ts and the index.d.ts currently being used.

For some reason the declare statement does not work within index.d.ts, I think node js core features are overriding it So to get access to the 2 functions
fromAddress: (ptr: bigint, size: number) => ArrayBuffer;
getAddress: (data: ArrayBuffer) => bigint;

Put this at the top of your typescript code
import { CustomArraybufferConstructor } from "nvk";
declare var ArrayBuffer: CustomArraybufferConstructor;

LGTM, could you change CustomArraybufferConstructor to CustomArrayBufferConstructor?

Okay it should be updated now :)


Simple website for project

Implemented in https://github.com/inplacecli/inplacecli.github.io/commit/7ce2a1407e59f3f499796a92aa240f8e94972724


Regarding the delay introduced by octave band filterbank

Hello,
In the irStats script you decomposed the room impulse response into octave bands. Then, you compute the reverberation time RT in each band. My issue is regarding the time delay introduced by each filter, should we compensate for that delay when we compute the reverberation time in each band.
Thank you for your help.

No. The function automatically determines the start point in each band as the peak of the squared impulse response.

You computed the peak with respect to the full band room impulse response (RIR) as stated in irStats:
peak = find(x(:,n).^2==max(x(:,n).^2));
If you filter RIR and there is a time delay introduced by the filter then the location of the peak will be different from that of the full band RIR.

The octave-band decay measures don’t use the position of the initial peak directly. They measure the time separating the fit points.

You are correct if we assume linear phase of filters within their passband.
What about the frequency dependent direct-to-reverberation ratio (DRR). It depends on the position of the initial peak in each frequency band.

ISO 3382 makes certain requirements of the octave-band filters. The filters were designed to meet those requirements.
DRR is not calculated in each octave band, only for the entire response, per the ISO 3382 standard.


Feature switch combined with choice option results in None when prompted for value

When using a feature switch as a shortcut for a required choice option with prompting enabled, the validated value is None if provided via the prompt, but only if the feature option decorator occurs after the choice option. Regardless of the order of the decorators, the value is not normalized when provided via the choice option.
Expected Behavior
When executing the example below, if the --fix feature switch or the --action fixed option are provided, then action should be 'Fixed'. If neither option is used, then a prompt is provided for the user to enter a value, which is then validated. If fixed is provided as the prompt input, then action should be normalized to 'Fixed'.
import click

ACTIONS = 'Added', 'Changed', 'Deprecated', 'Fixed', 'Removed'

@click.command()
@click.option('-a', '--action', required=True, prompt=True,
              type=click.Choice(ACTIONS, case_sensitive=False))
@click.option('--fix', 'action', is_flag=True, flag_value='Fixed')
def main(action):
    print('action =', repr(action))

if __name__ == '__main__':
    main()

Actual Behavior

When no options are given and fixed is input at the prompt, action is None instead of 'Fixed'
If --action fixed is given, action is 'fixed' instead of the normalized 'Fixed'
Swapping the option decorators (moving --fixed above --action) fixes the first issue, but not the second

Environment

Python version: 3.7.7
Click version: 7.1.2

I turns out that if I add expose_value=False to the feature switch that everything works as expected. Maybe all that is needed is a little help in the documentation, which is already exceptional.
I love click and almost never use argparse anymore. Thanks for such an awesome library.


Using Zip disk images

Info

Which version of Pi are you using:
Which github revision of software:
Which board version:
Which computer is the RaSCSI connected to:

Describe the issue
On Keith Meiere's Llamamusic page are some Zipdisk files for the W30 which I would like to try. How do I upload and assign them to a SCSI ID on RaSCSI? http://llamamusic.com/s50s550/ZIPdisk-1_TOC.html

It appears that these zip disks can also be used as hard disk images. You should be able to download these zip files, then attach them in RaSCSI as if they were hard disks.
Note that the Github issues are generally to request features/updates/fixes to the RaSCSI software itself. For support, I'd recommend connecting to Discord: https://discord.gg/PyS58u6 There is a large community of sampler users who are extremely helpful in answering questions.
Thanks!
-Tony

Closing this issue, since it is a support request, not an issue with the RaSCSI.


improve non api related errors

What happens?
Currently when a user makes a request that doesnt actually send an http request, we throw no error and it silently fails
What did you expect to happen?
we should showcase the error in the response section!
How can we reproduce the issue?
send a request to localhost:1234
OpenAPI Document
No response

@hwkr is your work on #2764 fix this by any chance?

@hwkr does your work on #2764 is fixing this by any chance?

Yep! We should show all errors now :)


504 timeout error when loading large MRI studies

I am experience 504 timeout error when loading MRI studies from orthanc with approx. 20 series and 1000 images. The issue is even with smaller size of 500-600 images.
The viewer starts loading for sometime and then goes blank. The error in devtools show 504 gateway timeout.
Attached screenshot of the error, can anyone advise how to resolve this issue?
I am using OHIF with Orthanc on reverse proxy in nginx.

Hey, how did you manage to fix this issue? I'm getting the same error. Thanks in advance.

I worked with studies that had 1-2k images in them and they could be loaded. This type of problem could have many different causes like VM unavailable because it's scaling in the middle of the request or something.
Not sure if it's your case but after merging, exponential backoff could potentially help these kinds of scenario: https://github.com/OHIF/Viewers/pull/2408

Thanks for the info and quick reply! In our case, we're on a pretty old version but it seems to work by removing Nginx from the equation (probably a timeout setting or something).


chore: update packages

Codecov Report
All modified lines are covered by tests :white_check_mark:

Comparison is base (365f074) 91.25% compared to head (46c50e1) 91.25%.
Report is 1 commits behind head on master.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1584   +/-   ##
=======================================
  Coverage   91.25%   91.25%
=======================================
  Files          17       17
  Lines         240      240
  Branches       44       44
=======================================
  Hits          219      219
  Misses          8        8
  Partials       13       13

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


installation warning

I run into the following installation warning using miniconda3 with python 3.6. [let me know if you need more details].
In file included from /root/miniconda3/lib/python3.6/site-packages/numpy/core/include/numpy/ndarraytypes.h:1809:0,
                 from /root/miniconda3/lib/python3.6/site-packages/numpy/core/include/numpy/ndarrayobject.h:18,
                 from /root/miniconda3/lib/python3.6/site-packages/numpy/core/include/numpy/arrayobject.h:4,
                 from lie_learn/spaces/spherical_quadrature.c:579:
/root/miniconda3/lib/python3.6/site-packages/numpy/core/include/numpy/npy_1_7_deprecated_api.h:15:2: warning: #warning "Using deprecated NumPy API, disable it by " "#defining NPY_NO_DEPRECATED_API NPY_1_7_API_VERSION" [-Wcpp]
 #warning "Using deprecated NumPy API, disable it by " \
  ^
gcc -pthread -shared -L/root/miniconda3/lib -Wl,-rpath=/root/miniconda3/lib,--no-as-needed build/temp.linux-x86_64-3.6/lie_learn/spaces/spherical_quadrature.o -L/root/miniconda3/lib -lpython3.6m -o build/lib.linux-x86_64-3.6/lie_learn/spaces/spherical_quadrature.cpython-36m-x86_64-linux-gnu.so

This seems to be a harmless compiler warning: https://github.com/scipy/scipy/issues/5889


Zero width glitches on 'intg_err_o' output of _reg_top.sv (regtool generated file)

When using this signal, intg_err_o. in the AST code, we faced an issue that this signal is setting the alert with no
apparent reason.  After some debug, we suspected that the signal has zero width glitches. The glitched happens
on the clock rizing edge after a write ( assign enable_err = !en_i && or_tree[0]; is generating the glitch )..
De-glitching the signal with a FF solved the issue (see intg_err signal in the waveform).
I whould expect that this output of the regtool will be glitch free...
@tjaychen @arnonsha @sha-ron

@tjaychen Please assign the propare person to this issue.

All the alerts are set asyncronusly (some has no clock). The one that are clocked were assumed to be glitch free or we de-glitch the before use. In the case of the regtool output we assumed it is glitch free...

i'm not sure why ast made that assumption, it was not the assumption made for the rest of OpenTitan (although to be fair this was not explicitly documented, it's just that intg_err were fed into prim_alert_sender which did the de-glitching for us).
The reason it was not immediately de-glitched is before use is because there is a fair amount of synchronous logic that immediately react to the error on the next cycle.
I would recommend that ast de-glitch the error in this case.  Or if you prefer we can add a parameter for you to flip on for ast.

I already de-glitched the intg_err_o as intg_err in the waveform. Documentation is needed! But I think the logic creating the glitch, reg_wr_err, can be fixed.

ah i can let @msfschaffner comment more on that one. But that is actually a specific defense added to FI attacks (discovered by a security lab) to ensure we don't write to registers we did not intend to write.
The thing is, all of these errors are done during the command phase (reg_we_err and intg_err) so we can immediately respond during the dataphase (with a transactional error). If we want to make sure we latch these, to keep things consistent, we will need to move the error stage a cycle back, then everything will be flopped.
Are you sure you don't want me to add a parameter to the regtool to flop the error output?
To your point, definitely documentation needs to be improved. I am very guilty of that...

@Jacob-Levy the intg_err_o is a synchronous signal, meant to be latched by a register in the same clock domain as the bus interface (main clock input for the reg_top module). The alert senders within comportable IPs are typically attached to the same clock, hence no synchronization / deglitching is needed.
I suggest to either place all alert handling logic within AST into the bus clock domain (similarly to how comportable IPs do it), or manually deglitch the signal.
Note that we typically assume that signals are synchronous to their local clock, unless otherwise specified. Hence, we would document it if the signal was meant to be used as an async signal, and not the other way round.

@msfschaffner the intg_err_o goes to the AST registers as a synchronous tlul clock signal. A status bit it set and it is added to OTO alert source.

This is OK and expected. As I mentioned, if the AST alert handling logic is NOT in the same clock domain as the reg_top, you need to manually deglitch/synchronize it outside the reg_top. It sounds like you already did that, hence I think we can close this issue (feel free to reopen if there  is more to discuss).

@msfschaffner It is highly recomended that
a FF will added on the _reg_top to deglitch the  intg_err_o  since an error signal should not be combinatorial.

@Jacob-Levy I think I agree with your statement  if the error is something that actually leaves the module boundary, since we can't make assumptions about how the outside world consumes.
But within the block, all but AST consume the error synchronously, so I don't think this is an important thing to fix for now.  Maybe we should add some caveats in the documentation to not use these as asynchronous sets/resets.
For now, let us tag this with future release.

@tjaychen The issue was found as a result of not consuming the signal synchronously.
The signal is bus cllk and the alert is in clk_ast_alert_i.

that's right. But what i'm trying to say is that this is somewhat unique to ast because ast split its comportable front end into sensor_ctrl.
If sensor_ctrl logic were inside ast, it is very likely you would not have this problem since the clock driving the alert senders and the bus clock would be one and the same.  The alert sender then handles any async crossing with the alert modules natively.
That's why i'm saying all the other modules do not experience this issue because they all have a comportable front end.  AST is kind of unique in that we made the choice to split this up (perhaps incorrectly).  See #7978

I don't agree with that statement. At least in terms of opentitan's current comportability requirements, it is not meant to be used that way. We made an exception for AST, one that we should not have in hindsight.
We expect the primary bus interface, the interrupts, the alert senders and the register block to all be in the same domain.  In fact, the modules have a concept of "primary" clock for that reason.

Some of the alerts in the AST are not generated by the bus clock for a good reason,
and some not related to any of the clocks (fully asynchronous)....

The issue of the glitch in the *_reg_top.sv was not fixed and the integ_err_o is not glitch free.
The issue was fixed in the AST by adding a flop to deglitch the integ_err_o.

Closing as this has been addressed inside AST.


key "Pelvis" not found'

Hello，I have some question,I can not solve it. Can you help me? Thanks!!!
Python: Traceback (most recent call last):   File "/home/guo/Downloads/CharacterDriven-BlenderAddon-master (1)/CharacterDriven-BlenderAddon-master/blender/Beta.blend/Text", line 42, in modal   File "/home/guo/Downloads/CharacterDriven-BlenderAddon-master (1)/CharacterDriven-BlenderAddon-master/blender/Beta.blend/Text", line 98, in process_poses KeyError: 'bpy_prop_collection[key]: key "Pelvis" not found' location: <unknown location>:-1

Hello，I have some question,I can not solve it. Can you help me? Thanks!!!
Python: Traceback (most recent call last): File "/home/guo/Downloads/CharacterDriven-BlenderAddon-master (1)/CharacterDriven-BlenderAddon-master/blender/Beta.blend/Text", line 42, in modal File "/home/guo/Downloads/CharacterDriven-BlenderAddon-master (1)/CharacterDriven-BlenderAddon-master/blender/Beta.blend/Text", line 98, in process_poses KeyError: 'bpy_prop_collection[key]: key "Pelvis" not found' location: <unknown location>:-1

You should make Armature active,which means you have to select the Armature.

Hello，I have some question,I can not solve it. Can you help me? Thanks!!!
Python: Traceback (most recent call last): File "/home/guo/Downloads/CharacterDriven-BlenderAddon-master (1)/CharacterDriven-BlenderAddon-master/blender/Beta.blend/Text", line 42, in modal File "/home/guo/Downloads/CharacterDriven-BlenderAddon-master (1)/CharacterDriven-BlenderAddon-master/blender/Beta.blend/Text", line 98, in process_poses KeyError: 'bpy_prop_collection[key]: key "Pelvis" not found' location: <unknown location>:-1

I fixed the bug, download the repo and try again.


Add 0.14.1 to CHANGELOG

Also, the tag for 0.14.1 hasn't been pushed to the repository, so the "changes" link is invalid – currently, you'd need https://github.com/jlongster/prettier/compare/0.14.0...efc3ee0488f72ddecda6c3605061327b737f1c22.

Thanks!


add recommendation features

#26
Relevant items related to query are provided.

did you add the files to be committed using git add .??? Are the files in .idea related to this function?


I trained instance segmentation,but I don't have bbox

HI, thanks for your code.
I used instance segmentation to train custom data, but I don't have bbox and bbox score.
I demo my test picture have no bbox too.
Why I just have mask and mask score.
thank you!

Instance segmentation is not object detection and thus does not require bbox predictions. But you can always draw a bbox around mask, check issue: https://github.com/facebookresearch/Mask2Former/issues/10#issuecomment-992868148

@bowenc0221 Thanks you!!

@FrankFang0813 Hi . I want to do a training with my own efficiency, but I have no idea how to do it. How should your data set be and can you share the training codes with me?

@yasarniyazoglu Hi,I not sure what you mean.You can't train your custom dataset? Or you have same problem that just have mask AP but don't have bbox AP?

@bowenc0221 Hi, I have bbox score.Thank you!
I want to ask a question. where should I set confidence-threshold when I demo my dataset?I set the confidence-threshold=0.5 in demo.py, but always detected 100 instances in one Image.It seems an invalid parameter?

@yasarniyazoglu Hi,I not sure what you mean.You can't train your custom dataset? Or you have same problem that just have mask AP but don't have bbox AP?

I can't train with private data. and I don't know how to do it either. Do you have training codes?

@bowenc0221 Hi, I have bbox score.Thank you! I want to ask a question. where should I set confidence-threshold when I demo my dataset?I set the confidence-threshold=0.5 in demo.py, but always detected 100 instances in one Image.It seems an invalid parameter?

Hello, I met the same problem.  I want to ask a question. where should I set confidence-threshold when I demo my dataset?I set the confidence-threshold=0.5 in demo.py, but always detected 100 instances in one Image.It seems an invalid parameter?

Its not obvious to me that confidence-threshold actually does something. I cannot find it being used anywhere in the code.

If you want to set a score to filter the predictions, you can consider doing like below

You can also do instances = instances[instances.scores > SCORE_THRESHOLD]

You can also do instances = instances[instances.scores > SCORE_THRESHOLD]

No matter how many instances there are, the size of the model prediction output is always 100.

@SEUZTh
Hi.
Do you know of any method to make the model prection output have less than 100 instances?
Cheers

I have solved this issue. here is my solution:
`
     num_instances = mask_array.shape[0]
        scores = predictions["instances"].scores.cpu().numpy()
        for i in scores:
            if i < args.confidence_threshold:
                num_instances -= 1
                num_instances = max(num_instances, 0)
        print('num_instances:', num_instances)

`

@SEUZTh Hi. Do you know of any method to make the model prediction output have less than 100 instances?
Cheers

if "instances" in predictions:
    instances = predictions["instances"].to(self.cpu_device) # 类型: <class 'detectron2.structures.instances.Instances'>
    # 取得分大于阈值的实例
    instances_ = Instances(instances.image_size)
    flag = False
    for index in range(len(instances)):
        print(instances[index].scores)
        score = instances[index].scores[0]
        if score > 0.75: # 置信度设置
            if flag == False:
                instances_ = instances[index]
                flag = True
            else:
                instances_ = Instances.cat([instances_, instances[index]])
    vis_output = visualizer.draw_instance_predictions(predictions=instances_)

More information, you can refer to my blog: https://blog.csdn.net/qq_44324181/article/details/126242948

@SEUZTh Hi. Do you know of any method to make the model prediction output have less than 100 instances?
Cheers

if "instances" in predictions:
    instances = predictions["instances"].to(self.cpu_device) # 类型: <class 'detectron2.structures.instances.Instances'>
    # 取得分大于阈值的实例
    instances_ = Instances(instances.image_size)
    flag = False
    for index in range(len(instances)):
        print(instances[index].scores)
        score = instances[index].scores[0]
        if score > 0.75: # 置信度设置
            if flag == False:
                instances_ = instances[index]
                flag = True
            else:
                instances_ = Instances.cat([instances_, instances[index]])
    vis_output = visualizer.draw_instance_predictions(predictions=instances_)

More information, you can refer to my blog: https://blog.csdn.net/qq_44324181/article/details/126242948

Sorry, where did you define the "Instances"? thanks
the error message shows: NameError: name 'Instances' is not defined


ERC1155SupplyUpgradeable conflicts with ERC1155BurnableUpgradeable

If both features are enabled for a contract: an attempt to burn tokens leads to other revert reason than expected.

💻 Environment

Hardhat
Ethers
Solidity 0.8.4

📝 Details

There is the following code in ERC1155BurnableUpgradeable:
function _burn(
        address from,
        uint256 id,
        uint256 amount
    ) internal virtual {
        require(from != address(0), "ERC1155: burn from the zero address");

        address operator = _msgSender();

        _beforeTokenTransfer(operator, from, address(0), _asSingletonArray(id), _asSingletonArray(amount), "");

        uint256 fromBalance = _balances[id][from];
        require(fromBalance >= amount, "ERC1155: burn amount exceeds balance");
        unchecked {
            _balances[id][from] = fromBalance - amount;
        }

        emit TransferSingle(operator, from, address(0), id, amount);
    }

So _beforeTokenTransfer happens before require(fromBalance >= amount, "ERC1155: burn amount exceeds balance");.
But function ERC1155SupplyUpgradeable._beforeTokenTransfer contains the following
if (to == address(0)) {
            for (uint256 i = 0; i < ids.length; ++i) {
                _totalSupply[ids[i]] -= amounts[i];
            }
        }

As a result the following error happen: Error: VM Exception while processing transaction: reverted with panic code 0x11 (Arithmetic operation underflowed or overflowed outside of an unchecked block)
Insted of: ERC1155: burn amount exceeds balance
🔢 Code to reproduce bug

Create a contract 1155 which is burnable and support supply calcs. After attempt to burn more NFT than present - this error will happen.

Hello @PhantomYdn
First, I do believe that the behavior you are describing is not specific to the upgradeable contracts, and would also apply to the non-upgradeable version that is transpiled into the upgradeable version. If that is the case, we should open an issue to fix that there, and as a result it would be transpiled to here.
Before we do that, I want to make sure I understand the issue correctly.
It appears that it is not an issue with a correct operation reverting (which would be critical) but rather with an incorrect operation falling with an unexpected error message. When someone transfers more than the total supply (which is obviously more than their balance), then the total supply decrement gives an arithmetical error BEFORE the balance is checked.
Does that interpretation/rewording match your issue?

@Amxx - yes - your interpretation is correct. It's, IMHO, minor issue which might lead to misunderstandings and misinterpretation on 3rd party code.


Add documentation on how to manually update Firestore fields

E.g., to update a participant's workingOnStage if they are stuck.
Could start another .md in docs/ for this?

I'd rather do it in application-structure.md, as the doc is now empty


Replace  tags to  and  tags to

Description
This changes all b and i tags to strong and em, read the issue linked below.
Resolves: https://github.com/privacytools/privacytools.io/issues/2202
Check List

[x] I understand that by not opening an issue about a software/service/similar addition/removal, this pull request will be closed without merging.

[x] I have read and understand the contributing guidelines.

[x] The project is Free Libre and/or Open Source Software

This is, I'm sorry to say, the exact opposite of what was requested. <strong> and <em> are preferred.

Oh well... doing it ASAP.

What about now?

Looks better, however there are still some strong->b diffs.

I think I found and replaced all of them...

Fixed all of them. I apologize

This is, I'm sorry to say, the exact opposite of what was requested. <strong> and <em> are preferred.

That was always my understanding.


Add helper to convert component to styled component without styles inside template literal

It's nice to have ability to convert ReactClass or StatelessComponent to styled component without adding template literal empty quotes.
Currently i should do this:
export const SomeComponent = styled(
    ({children, className}) => (
        <div className={className}>
            {children}
        </div>
    )
)``; // <- template literal quotes

This styled SomeComponent has no styles but it can be styled inside other component by reference:
styled(SomeOtherComponent)`
    width: 100px;

    ${SomeComponent} {
        display: flex; // <- here we can style SomeComponent with specific for SomeOtherComponent styles
    }
`;

But this approach requires to add empty template literal quotes to styled call.
It would be nice to have a way to convert component to styled component without adding template literal empty quotes.

So, we probably won’t be adding this and the reason for that is that our recommended best practice approaches regarding your patterns are:

avoid wrapping any React component that is not a styled component, and instead use styled components as basic presentational components, I.e. as lead components in the bottom of the component tree
use reverse component selectors so that a styled component is aware of the parent, and not a making parent style a child

There’s more explanations here: https://github.com/styled-components/styled-components/issues/1302#issuecomment-342788554

I think it's not good when component knows about parents.
For example common componens (styled) that we using like lego blocks and they can be in any place of JSX in many places.
It's impossible to describe in reverse way all styles rof each common component inside for each parent, because parents can be the same in different pages, but parents of parents can be different.

@sanex3339 sure, for common, reusable components, like layouting you could use props to abstract their special behaviour in different places as well.
Or create more specialised components for wrappers in other places. Like flex box wrappers; they don’t necessarily have to be 100% reusable but can also just be created as needed

I'm also interested in referencing non-styled components in my css blocks.
Could a babel-plugin solve this by detecting components referenced in css template literals and wrap them into a styled component if they're an instance of React.Component? (I have no idea if it's possible)
This feature with https://github.com/satya164/babel-plugin-css-prop would be a killer combo!


feat: rename managed identifier

I believe this was only added to signifypy following WebOfTrust/keria#218.

I will merge this one now since it seems like no one has any objections to the API.


Deblur Model

Hi Guys,
Thanks for your work and I want to do some comparison on image deblurring with your work.
How could I run the code on GoPro dataset? and could you release the model to us, I haven't see the deblur model in the GoogleDrive. Thanks

We have not planed to release the model for now.
The code for deblurring:
python main.py --dir_data $DATA_PATH --pretrain $MODEL_PATH --data_test GoPro --scale 1 --deblur --n_feats 9 --patch_dim 8 --patch_size 256

为什么调用过程中会出现PermissionError: [Errno 13] Permission denied: '/cache'错误，谢谢解答

为什么调用过程中会出现PermissionError: [Errno 13] Permission denied: '/cache'错误，谢谢解答

你好，你的/cache目录没有权限访问，可以尝试将数据和模型放在其他位置。


vscode git diff should highlight the correct code block on traversing the changes

In VSCode when i do changes and open the Git diff view to see the changes done, the editor opens the compare mode and highlight all the changed blocks of code.
Using the top right arrow buttons, we can traverse the blocks.
But, this traversal is not really highlighting which block is currently being focused.
If cursor is placed in the editor,  then cursor is being moved correctly, otherwise there is no way to know which block is being highlighted.
VSCode 1.18.1
OS: Win 7

The VS Code actions move the cursor to the next diff. They do not highlight the next diff. Also, please create VS Code issues at the VS Code repository at https://github.com/Microsoft/vscode