Fix warnings reported by Verilator

Verilator reports following warnings. Fix them.

SystemVerilog RTL
%Warning-WIDTH: rtl/apb/block_0.sv:167:37: Operator AND expects 32 bits on the RHS, but RHS's CONST '1'h1' generates 1 bits.
                                         : ... In instance top.u_block_0
  167 |       if (!(((32'h0001ffff) >> __i) & 1'b1)) begin : g
      |                                     ^

%Warning-WIDTH: /work/rtl/rggen-sv-rtl/rggen_default_register.sv:5:37: Operator VAR 'OFFSET_ADDRESS' expects 8 bits on the Initial value, but Initial value's CONST '32'h30' generates 32 bits.
                                                                     : ... In instance top.u_block_0.g_register_10.g[0].u_register
    5 |   parameter bit [ADDRESS_WIDTH-1:0] OFFSET_ADDRESS  = '0,

%Warning-WIDTH: /work/rtl/rggen-sv-rtl/rggen_register_common.sv:57:57: Operator SUB expects 32 bits on the LHS, but LHS's FUNCREF 'calc_start_address' generates 8 bits.
                                                                     : ... In instance top.u_block_0.g_register_0.u_register.u_register_common
   57 |     return ADDRESS_WIDTH'(calc_start_address(index + 1) - 1);

%Warning-WIDTH: /work/rtl/rggen-sv-rtl/rggen_or_reducer.sv:20:27: Operator ASSIGN expects 16 bits on the Assign RHS, but Assign RHS's VARREF 'half_n' generates 32 bits.
                                                                : ... In instance top.u_block_0.u_adapter.u_adapter_common.u_mux.g.u_reducer
   20 |         list[list_index]  = half_n;
      |                           ^
%Warning-WIDTH: /work/rtl/rggen-sv-rtl/rggen_or_reducer.sv:26:27: Operator ASSIGN expects 16 bits on the Assign RHS, but Assign RHS's VARREF 'current_n' generates 32 bits.
                                                                : ... In instance top.u_block_0.u_adapter.u_adapter_common.u_mux.g.u_reducer
   26 |         list[list_index]  = current_n;
      |                           ^
%Warning-WIDTH: /work/rtl/rggen-sv-rtl/rggen_or_reducer.sv:29:19: Operator SUB expects 32 bits on the RHS, but RHS's SEL generates 16 bits.
                                                                : ... In instance top.u_block_0.u_adapter.u_adapter_common.u_mux.g.u_reducer
   29 |       current_n   -= list[list_index];
      |                   ^~

%Warning-WIDTH: /work/rtl/rggen-sv-rtl/rggen_adapter_common.sv:50:51: Operator ADD expects 32 bits on the LHS, but LHS's VARREF 'BASE_ADDRESS' generates 16 bits.
                                                                    : ... In instance top.u_block_0.u_adapter.u_adapter_common
   50 |       end_address   = ADDRESS_WIDTH'(BASE_ADDRESS + BYTE_SIZE - 1);

%Warning-WIDTH: /work/rtl/rggen-sv-rtl/rggen_register_common.sv:114:33: Operator ASSIGNW expects 64 bits on the Assign RHS, but Assign RHS's VARXREF 'value' generates 32 bits.
                                                                      : ... In instance top.u_block_0.g_register_0.u_register.u_register_common
  114 |   assign  register_if.value     = bit_field_if.value;

%Warning-WIDTH: /work/rtl/rggen-sv-rtl/rggen_apb_adapter.sv:24:29: Operator ASSIGNW expects 7 bits on the Assign RHS, but Assign RHS's VARXREF 'paddr' generates 16 bits.
                                                                 : ... In instance top.u_block_1.u_adapter
   24 |   assign  bus_if.address    = apb_if.paddr;

%Warning-WIDTH: /work/rtl/rggen-sv-rtl/rggen_external_register.sv:74:33: Operator ASSIGNW expects 64 bits on the Assign RHS, but Assign RHS's VARXREF 'read_data' generates 32 bits.
                                                                       : ... In instance top.u_block_0.g_register_15.u_register
   74 |   assign  register_if.value     = bus_if.read_data;
      |

%Warning-WIDTH: /work/rtl/rggen-sv-rtl/rggen_apb_bridge.sv:14:27: Operator ASSIGNW expects 16 bits on the Assign RHS, but Assign RHS's VARXREF 'address' generates 8 bits.
                                                                : ... In instance top.u_bridge
   14 |   assign  apb_if.paddr    = bus_if.address;
      |                           ^

%Warning-CMPCONST: /work/rtl/rggen-sv-rtl/rggen_address_decoder.sv:27:33: Comparison is constant due to limited range
                                                                        : ... In instance top.u_block_0.g_register_15.u_register.u_decoder
   27 |         (i_address[WIDTH-1:LSB] <= END_ADDRESS[WIDTH-1:LSB]  )
      |                                 ^~

Verilog RTL
%Warning-WIDTH: rtl/apb/block_0.v:192:33: Operator AND expects 32 bits on the RHS, but RHS's CONST '1'h1' generates 1 bits.
                                        : ... In instance block_0
  192 |     if (!((32'h0001ffff >> __i) & 1'b1)) begin : g

%Warning-WIDTH: rtl/apb/block_0.v:2130:59: Operator AND expects 8 bits on the RHS, but RHS's REPLICATE generates 2 bits.
                                         : ... In instance block_0
 2130 | (((REGISTER_10_BIT_FIELD_1_INITIAL_VALUE) >> ((2) * (j))) & {(2){1'b1}})),
      |                                                           ^

%Warning-WIDTH: /work/rtl/rggen-verilog-rtl/rggen_default_register.v:5:33: Operator VAR 'OFFSET_ADDRESS' expects 8 bits on the Initial value, but Initial value's CONST '32'h30' generates 32 bits.
                                                                         : ... In instance block_0.g_register_10.g[0].u_register
    5 |   parameter [ADDRESS_WIDTH-1:0] OFFSET_ADDRESS  = {ADDRESS_WIDTH{1'b0}},
      |                                 ^~~~~~~~~~~~~~

%Warning-WIDTH: /work/rtl/rggen-verilog-rtl/rggen_bit_field.v:4:25: Operator VAR 'INITIAL_VALUE' expects 2 bits on the Initial value, but Initial value's CONST '8'h0' generates 8 bits.
                                                                  : ... In instance block_0.g_register_10.g[0].g_bit_field_1.g[0].u_bit_field
    4 |   parameter [WIDTH-1:0] INITIAL_VALUE             = {WIDTH{1'b0}},
      |                         ^~~~~~~~~~~~~

%Warning-WIDTH: /work/rtl/rggen-verilog-rtl/rggen_register_common.v:59:42: Operator ADD expects 32 bits on the LHS, but LHS's VARREF 'OFFSET_ADDRESS' generates 8 bits.
                                                                         : ... In instance block_0.g_register_0.u_register.u_register_common
   59 |     calc_start_address  = OFFSET_ADDRESS + BUS_BYTE_WIDTH * index;
      |

%Warning-WIDTH: /work/rtl/rggen-verilog-rtl/rggen_or_reducer.v:77:41: Operator FUNCREF 'get_sub_n_list' expects 16 bits on the Function Argument, but Function Argument's VARREF 'N' generates 32 bits.
                                                                    : ... In instance block_0.g_register_6.u_register.u_register_common.u_read_data_mux.g.u_reducer
   77 |   localparam  [16*N-1:0]  SUB_N_LIST  = get_sub_n_list(N);
      |                                         ^~~~~~~~~~~~~~

%Warning-WIDTH: /work/rtl/rggen-verilog-rtl/rggen_adapter_common.v:67:19: Operator ASSIGN expects 8 bits on the Assign RHS, but Assign RHS's SUB generates 32 or 9 bits.
                                                                        : ... In instance rggen_axi4lite_adapter.u_adapter_common
   67 |     end_address   = BASE_ADDRESS + BYTE_SIZE - 1;
      |

%Warning-CMPCONST: /work/rtl/rggen-verilog-rtl/rggen_address_decoder.v:49:31: Comparison is constant due to limited range
                                                                            : ... In instance block_0.g_register_15.u_register.u_decoder
   49 |         (address[WIDTH-1:LSB] <= END_ADDRESS[WIDTH-1:LSB]  );
      |                               ^~
%Warning-UNSIGNED: /work/rtl/rggen-verilog-rtl/rggen_address_decoder.v:48:31: Comparison is constant due to unsigned arithmetic
                                                                            : ... In instance block_0.g_register_0.u_register.u_register_common.g_decoder[0].u_decoder
   48 |         (address[WIDTH-1:LSB] >= START_ADDRESS[WIDTH-1:LSB]) &&
      |                               ^~

%Warning-UNOPTFLAT: rtl/apb/block_0.v:150:17: Signal unoptimizable: Feedback to clock or circular logic: 'block_0.w_register_value'
  150 |   wire [1599:0] w_register_value;
      |                 ^~~~~~~~~~~~~~~~
                    rtl/apb/block_0.v:150:17:      Example path: block_0.w_register_value
                    rtl/apb/block_0.v:860:10:      Example path: ASSIGNW
                    rtl/apb/block_0.v:760:17:      Example path: block_0.g_register_4.w_bit_field_value
                    rtl/apb/block_0.v:781:8:      Example path: ASSIGNW
                    rtl/apb/block_0.v:150:17:      Example path: block_0.w_register_value

%Warning-WIDTH: /work/rtl/rggen-sv-rtl/rggen_default_register.sv:5:37: Operator VAR 'OFFSET_ADDRESS' > expects 8 bits on the Initial value, but Initial value's CONST '32'h30' generates 32 bits.
                                                                     : ... In instance > top.u_block_0.g_register_10.g[0].u_register
    5 |   parameter bit [ADDRESS_WIDTH-1:0] OFFSET_ADDRESS  = '0,

This check on a localparam declaration is not evaluated. Therefore, this warning can be resolved by introducing a localparam showing a offset address.

%Warning-WIDTH: rtl/apb/block_0.sv:167:37: Operator AND expects 32 bits on the RHS, but RHS's CONST > '1'h1' generates 1 bits.
                                         : ... In instance top.u_block_0
  167 |       if (!(((32'h0001ffff) >> __i) & 1'b1)) begin : g
      |

To resolve this warning, change the macro definition like below.
`ifndef rggen_tie_off_unused_signals
  `define rggen_tie_off_unused_signals(WIDTH, VALID_BITS, RIF) \
  if (1) begin : __g_tie_off \
    genvar  __i; \
    for (__i = 0;__i < WIDTH;++__i) begin : g \
      if ((((VALID_BITS) >> __i) % 2) == 1)begin : g \
        assign  RIF.read_data[__i]  = 1'b0; \
        assign  RIF.value[__i]      = 1'b0; \
      end \
    end \
  end
`endif

%Warning-UNOPTFLAT: rtl/apb/block_0.v:150:17: Signal unoptimizable: Feedback to clock or circular > logic: 'block_0.w_register_value'
  150 |   wire [1599:0] w_register_value;
      |                 ^~~~~~~~~~~~~~~~
                    rtl/apb/block_0.v:150:17:      Example path: block_0.w_register_value
                    rtl/apb/block_0.v:860:10:      Example path: ASSIGNW
                    rtl/apb/block_0.v:760:17:      Example path: > block_0.g_register_4.w_bit_field_value
                    rtl/apb/block_0.v:781:8:      Example path: ASSIGNW
                    rtl/apb/block_0.v:150:17:      Example path: block_0.w_register_value

It's difficult to fix this warning so -Wno-unoptflat switch is needed.


Php Cheatsheet

Hey @Suryansh1720001, I want to add a php cheatsheet in your repository. It will be really great if you kindly assign me the task.

Hello @faria-karim-porna
Go for it. And go through the readme and contributing file first before sending the pull request.
( Also please keep this in mind - don't send any Plagiarized content. )
Thank you

h


Only first embedded image get correctly resolved to media/branch

Im am writing this issue because #10484 and #10506 are closed but the issue isn't fixed.
Description
When you embed images only the first embedded image is shown.
E.g.:
![Coverage Branches](./coverage/badge-branches.png)
![Coverage Lines](./coverage/badge-lines.png)
![Coverage Functions](./coverage/badge-functions.png)
![Coverage Statements](./coverage/badge-statements.png)

Only my Coverage Branches gets resolved to media/branch the other images are resolved to a src/branch URL.
I didn't had this problem with old versions from Gitea, but since i upgraded to version 1.11.5 i have this problem too ... (i think i hadn't had this problem with 1.10.4)
Screenshots

#10515 and the file gitea/modules/markup/html.go should be interesting for debugging i think either visitNode() don't get called on the following elements (with the wrong url path) or some condition in visitNode() is wrong?!
I don't know how big a node is and what the delimiters are which make a node but maybe the block without a break is one node and because there is strings.Replace(prefix, "/src/", "/media/", 1) it only replaces one URL (because of the "1" in the function call)?!

@CMiksche does this occur on try?

@CMiksche does this occur on try?
What do you exactly mean?

I haven't looked further into debugging but i can definitely say there is a problem with the html markup creation. The first element also gets a link around it:

<a href="/<my repo>/media/branch/master/coverage/badge-branches.png" rel="nofollow"><img src="/<my repo>/media/branch/master/coverage/badge-branches.png" alt="Coverage Branches">

But the markdown is exactly the same on all lines:
![Coverage Branches](./coverage/badge-branches.png)
![Coverage Lines](./coverage/badge-lines.png)
![Coverage Functions](./coverage/badge-functions.png)
![Coverage Statements](./coverage/badge-statements.png)

No I mean do you have an example on try.gitea.io where this does not work.
For example both test cases on the PRs you quote above work on try.gitea.io.]
I'm trying to determine if this is fixed on master/1.12 already.

This is fixed on 1.12 - the issue is that #10515 is not backported to 1.11 - I'll open a backport for it now.

I created a test at https://try.gitea.io/cmiksche/test-multiple-local-badges/src/branch/master/README.md

I used the same markdown code which i use to display the badges next to each other on my current gitea instance and on github. Why are the badges displayed below each other?!

I used the same markdown code which i use to display the badges next to each other on my current gitea instance and on github. Why are the badges displayed below each other?!

Okay, i got it - i have to write the markdown in the next version next to each other to get that result ...
@zeripath Thanks for fixing :-)

The problem is https://github.com/go-gitea/gitea/pull/11162 switched us to use hard breaks by default.
Looking at it I suspect that selection was incorrect - we should try to render as much as we can like GH.

Yup I think that PR is incorrect.

OK it looks like GH has two different styles - Markdown files have Soft breaks, comments have Hard breaks. I've put up a PR to fix this.

I tested the new version and my problems are fixed. I close this issue now ;-)


fix(): #455 flash message not shown properly in login page (#528)

Co-authored-by: Prashant Khadka<EMAIL_ADDRESS>

attempting to fix the issue here: https://github.com/restarone/violet_rails/pull/524

@alis-khadka please see the issue below. Reminds me of that simpsons episode where homer is pulling the blinds


DOC: update the MAPIE homepage

Description
Propose to update the MAPIE homepage to reflect the entire library as well as the latest features.
Fixes #335
Type of change

This change requires a documentation update

Checklist

[ ] I have read the contributing guidelines
[ ] I have updated the HISTORY.rst and AUTHORS.rst files
[ ] Linting passes successfully : make lint
[ ] Typing passes successfully : make type-check
[ ] Unit tests pass successfully : make tests
[ ] Coverage is 100% : make coverage
[ ] Documentation builds successfully : make doc

Codecov Report
Patch has no changes to coverable lines.
:loudspeaker: Thoughts on this report? Let us know!.

Also, I'm not sure if we still need the part about split vs. CV. We explain this later, and I don't think it helps make a friendly home page.


Support WASAPI Data Transfer API

Support basic WASAPI data transfer api, per:
https://github.com/WASAPI-Community/data-transfer-apis/tree/master/general-specification

Initial first pass for WASAPI is in this branch: https://github.com/webrecorder/webrecorder/tree/wasapi-work
It includes the /webdata endpoint at /api/v1/download/webdata and individual WARC download endpoints at: /api/v1/download/<user>/<coll>/<filename>
Only 'committed' recordings are included, so an active recording will not be included in the listing.
The main thing we're missing is checksum computation and, for s3-backed deployments, such as webrecorder.io itself, we may want to consider just have pre-signed s3 url. The S3 backend is the more important one to support WASAPI use on webrecorder.io,
Perhaps it might make sense to precompute and store in Redis (or filesystem) a checksum for all WARC files that are in 'committed' (finished) recording sessions?
Local backend:

[ ] Support checksum computation. Possible compute on the fly, or cache in redis?

S3 backend:

[ ] Use S3 ETag as md5 hash
[ ] For download urls, return a pre-signed url (https://boto3.amazonaws.com/v1/documentation/api/latest/guide/s3-presigned-urls.html) as an alternative to the /api/v1/download/<user>/<coll>/<filename> endpoint


Cmake

Why not use CMake?

We are very reluctant to add any build dependency, given the wide number of platforms.  We're looking at revamping the build system.

I got the same question and wonder why not replace the Perl dependency with CMake?

perl's more portable for us (e.g., VMS is a supported platform)

Perl is already extensively used for numerous scripts so it wouldn't be replacing the Perl dependency with cmake, but adding cmake as a dependency. We try to avoid adding new dependencies as much as possible due to the wide number of platforms and environments that we need to build under.

Guys, should we make this an FAQ item?

Sure, but generic like “why don’t you use cake or {other build tool}?”


⚠ ClamAV has degraded performance

In 5fae714, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 487 ms

Resolved: ClamAV performance has improved in 6d88495.


Nextjs app fails to build SSR with error  UnexpectedParameter: Unexpected key 'ResponseHeadersPolicyId'

Before opening, please confirm:

[X] I have checked to see if my question is addressed in the FAQ.
[X] I have searched for duplicate or closed issues.
[X] I have read the guide for submitting bug reports.
[X] I have done my best to include a minimal, self-contained set of instructions for consistently reproducing the issue.

App Id
d2cn4htefwf90t
Region
ap-south-1
Amplify Hosting feature
Backend builds, Build settings
Describe the bug
NextJS application used to work previously. But initial configuration was using latest version of NextJS. So, I thought latest release of NextJS causing the failure, so I changed it to specific version(12.1.0 as my local machine) but SSR build is still failing with following error:
2022-04-27T09:13:39.482Z [INFO]: λ  (Server)  server-side renders at runtime (uses getInitialProps or getServerSideProps)
                                 ○  (Static)  automatically rendered as static HTML (uses no initial props)
2022-04-27T09:13:39.765Z [INFO]: Starting SSR Build...
2022-04-27T09:16:17.312Z [ERROR]: MultipleValidationErrors: There were 6 validation errors:
                                  * UnexpectedParameter: Unexpected key 'ResponseHeadersPolicyId' found in params.DistributionConfig.DefaultCacheBehavior
                                  * UnexpectedParameter: Unexpected key 'ResponseHeadersPolicyId' found in params.DistributionConfig.CacheBehaviors.Items[0]
                                  * UnexpectedParameter: Unexpected key 'ResponseHeadersPolicyId' found in params.DistributionConfig.CacheBehaviors.Items[1]
                                  * UnexpectedParameter: Unexpected key 'ResponseHeadersPolicyId' found in params.DistributionConfig.CacheBehaviors.Items[2]
                                  * UnexpectedParameter: Unexpected key 'ResponseHeadersPolicyId' found in params.DistributionConfig.CacheBehaviors.Items[3]
                                  * UnexpectedParameter: Unexpected key 'ResponseHeadersPolicyId' found in params.DistributionConfig.CacheBehaviors.Items[4]
                                  at ParamValidator.validate (/root/.//node_modules/aws-sdk/lib/param_validator.js:40:28)
                                  at Request.VALIDATE_PARAMETERS (/root/.//node_modules/aws-sdk/lib/event_listeners.js:132:42)
                                  at Request.callListeners (/root/.//node_modules/aws-sdk/lib/sequential_executor.js:106:20)
                                  at callNextListener (/root/.//node_modules/aws-sdk/lib/sequential_executor.js:96:12)
                                  at /root/.//node_modules/aws-sdk/lib/event_listeners.js:86:9
                                  at finish (/root/.//node_modules/aws-sdk/lib/config.js:386:7)
                                  at /root/.//node_modules/aws-sdk/lib/config.js:404:9
                                  at SharedIniFileCredentials.get (/root/.//node_modules/aws-sdk/lib/credentials.js:127:7)
                                  at getAsyncCredentials (/root/.//node_modules/aws-sdk/lib/config.js:398:24)
                                  at Config.getCredentials (/root/.//node_modules/aws-sdk/lib/config.js:418:9)
                                  at Request.VALIDATE_CREDENTIALS (/root/.//node_modules/aws-sdk/lib/event_listeners.js:81:26)
                                  at Request.callListeners (/root/.//node_modules/aws-sdk/lib/sequential_executor.js:102:18)
                                  at Request.emit (/root/.//node_modules/aws-sdk/lib/sequential_executor.js:78:10)
                                  at Request.emit (/root/.//node_modules/aws-sdk/lib/request.js:688:14)
                                  at Request.transition (/root/.//node_modules/aws-sdk/lib/request.js:22:10)
                                  at AcceptorStateMachine.runTo (/root/.//node_modules/aws-sdk/lib/state_machine.js:14:12)
                                  at Request.runTo (/root/.//node_modules/aws-sdk/lib/request.js:408:15)
                                  at /root/.//node_modules/aws-sdk/lib/request.js:797:12
                                  at new Promise (<anonymous>)
                                  at Request.promise (/root/.//node_modules/aws-sdk/lib/request.js:783:12)
                                  at updateCloudFrontDistribution (/root/.//node_modules/@sls-next/aws-cloudfront/dist/index.js:218:53)
                                  at processTicksAndRejections (node:internal/process/task_queues:94:5)
                                  at async CloudFront.default (/root/.//node_modules/@sls-next/aws-cloudfront/dist/component.js:60:30)
                                  at async NextjsComponent.deploy (/root/.//node_modules/@sls-next/-component/dist/component.js:576:35)
                                  at async fn (/root/.npm/_npx/780a6c1398234b48/node_modules/@/template/utils.js:280:41)
                                  at async Promise.all (index 0)
                                  at async executeGraph (/root/.npm/_npx/780a6c1398234b48/node_modules/@/template/utils.js:294:3)
                                  at async Template.default (/root/.npm/_npx/780a6c1398234b48/node_modules/@/template/.js:67:38)
                                  at async Object.runComponents (/root/.npm/_npx/780a6c1398234b48/node_modules/@/cli/src/index.js:222:17) {
                                  code: 'MultipleValidationErrors',
                                  errors: [
                                  UnexpectedParameter: Unexpected key 'ResponseHeadersPolicyId' found in params.DistributionConfig.DefaultCacheBehavior
                                  at ParamValidator.fail (/root/.//node_modules/aws-sdk/lib/param_validator.js:50:37)
                                  at ParamValidator.validateStructure (/root/.//node_modules/aws-sdk/lib/param_validator.js:77:14)
                                  at ParamValidator.validateMember (/root/.//node_modules/aws-sdk/lib/param_validator.js:88:21)
                                  at ParamValidator.validateStructure (/root/.//node_modules/aws-sdk/lib/param_validator.js:75:14)
                                  at ParamValidator.validateMember (/root/.//node_modules/aws-sdk/lib/param_validator.js:88:21)
                                  at ParamValidator.validateStructure (/root/.//node_modules/aws-sdk/lib/param_validator.js:75:14)
                                  at ParamValidator.validateMember (/root/.//node_modules/aws-sdk/lib/param_validator.js:88:21)
                                  at ParamValidator.validate (/root/.//node_modules/aws-sdk/lib/param_validator.js:34:10)
                                  at Request.VALIDATE_PARAMETERS (/root/.//node_modules/aws-sdk/lib/event_listeners.js:132:42)
                                  at Request.callListeners (/root/.//node_modules/aws-sdk/lib/sequential_executor.js:106:20)
                                  at callNextListener (/root/.//node_modules/aws-sdk/lib/sequential_executor.js:96:12)
                                  at /root/.//node_modules/aws-sdk/lib/event_listeners.js:86:9
                                  at finish (/root/.//node_modules/aws-sdk/lib/config.js:386:7)
                                  at /root/.//node_modules/aws-sdk/lib/config.js:404:9
                                  at SharedIniFileCredentials.get (/root/.//node_modules/aws-sdk/lib/credentials.js:127:7)
                                  at getAsyncCredentials (/root/.//node_modules/aws-sdk/lib/config.js:398:24)
                                  at Config.getCredentials (/root/.//node_modules/aws-sdk/lib/config.js:418:9)
                                  at Request.VALIDATE_CREDENTIALS (/root/.//node_modules/aws-sdk/lib/event_listeners.js:81:26)
                                  at Request.callListeners (/root/.//node_modules/aws-sdk/lib/sequential_executor.js:102:18)
                                  at Request.emit (/root/.//node_modules/aws-sdk/lib/sequential_executor.js:78:10)
                                  at Request.emit (/root/.//node_modules/aws-sdk/lib/request.js:688:14)
                                  at Request.transition (/root/.//node_modules/aws-sdk/lib/request.js:22:10)
                                  at AcceptorStateMachine.runTo (/root/.//node_modules/aws-sdk/lib/state_machine.js:14:12)
                                  at Request.runTo (/root/.//node_modules/aws-sdk/lib/request.js:408:15)
                                  at /root/.//node_modules/aws-sdk/lib/request.js:797:12
                                  at new Promise (<anonymous>)
                                  at Request.promise (/root/.//node_modules/aws-sdk/lib/request.js:783:12)
                                  at updateCloudFrontDistribution (/root/.//node_modules/@sls-next/aws-cloudfront/dist/index.js:218:53)
                                  at processTicksAndRejections (node:internal/process/task_queues:94:5)
                                  at async CloudFront.default (/root/.//node_modules/@sls-next/aws-cloudfront/dist/component.js:60:30)
                                  at async NextjsComponent.deploy (/root/.//node_modules/@sls-next/-component/dist/component.js:576:35)
                                  at async fn (/root/.npm/_npx/780a6c1398234b48/node_modules/@/template/utils.js:280:41)
                                  at async Promise.all (index 0)
                                  at async executeGraph (/root/.npm/_npx/780a6c1398234b48/node_modules/@/template/utils.js:294:3)
                                  at async Template.default (/root/.npm/_npx/780a6c1398234b48/node_modules/@/template/.js:67:38)
                                  at async Object.runComponents (/root/.npm/_npx/780a6c1398234b48/node_modules/@/cli/src/index.js:222:17)

Expected behavior
Build is passing locally and on vercel but failing on amplify.
Reproduction steps

Build NextJS application with following package.json

{

  "name": "spotme",
  "version": "0.1.0",
  "private": true,
  "scripts": {
    "dev": "next dev",
    "build": "next build",
    "start": "next start",
    "lint": "next lint"
  },
  "dependencies": {
    "@svgr/webpack": "^6.2.1",
    "antd": "^4.19.2",
    "csv-loader": "^3.0.3",
    "formik": "^2.2.9",
    "google-map-react": "^2.1.10",
    "next": "12.1.0",
    "react": "17.0.2",
    "react-dom": "17.0.2",
    "sass": "^1.49.11",
    "yup": "^0.32.11"
  },
  "devDependencies": {
    "eslint": "8.11.0",
    "eslint-config-next": "12.1.0"
  }

 }

Build Settings
version: 1
frontend:
  phases:
    preBuild:
      commands:
        - npm ci
    build:
      commands:
        - npm run build
  artifacts:
    baseDirectory: .next
    files:
      - '**/*'
  cache:
    paths:
      - node_modules/**/*

Additional information
Using custom image: node:15
Next.js version: 12.1.0

facing same issue !! any progress ?

Any update on this issue? Our production build is failing b/c of this. We can't release new changes. Otherwise, we will have to move out of amplify.

@navdeep710 can you share your app ID as well please?

hey @hloriana d2cn4htefwf90t, thanks again for looking into it 🙏 , quick help will be super appreciable

Hi @hloriana any updates on this issue? We've been trying every avenue to resolve it without much success. Thank!

Hi @dominguez-gaston thank you for your update. If you can provide your app ID as well it can help us figure out this build issue. We are not able to reproduce this behavior but we are investigating. We appreciate your patience.

Hey @hloriana dlyqnfuuk0fox, thanks so much! Any guidance here would be extra helpful


EXPERIMENTAL: Check if browsing_context/navigate/error.py is still flaky

Bug: #463

@sadym-chromium Ran 5 times and it's stable (https://github.com/GoogleChromeLabs/chromium-bidi/actions/runs/5050400084/jobs/9061074658?pr=757). Should we merge this again?


Upgrade to vault-ruby 0.2.0

Includes some handy retry/backoff logic.

The PRs #7, #9, and #10 were all tested with hashicorp/vault-ruby#48

Nice to know @abooitt. I'll make a PR to bump the version!


File Creation Listener

Is there any Listener to get the file creation status in the pending state.
For fast internal storage the creation time is very short but i know in slow SD cards, the creation takes a long time, So it would be a good way to notify what's taking so long.

Sorry, there is no such listener to do that thing. For FileDownloader, it just needs to create a temp file before the real downloading, just a normal file operation.
So are you sure that the operation on SD cards takes too much time? Or you just have a guess and you want to confirm it?

Yes i guess that it will take time to create it proportional to sdcard speed..
Do you think that doesn't require much time whatever the memory write capacity is ?
I will try a very large file on a slow card and let you know.

I mean FileDownloader just creates a empty temp file during pending status, so I think it will not be a problem anyway. But FileDownloader will write file all the time during progress status, you can provide the log of FileDownloader and I can check whether the file operation takes too long or not.
On the other hand, there is Output performance test in PerformanceTestActivity in our demo, you can use it to have a test and tell me the result.

If you have any new discovery, please reopen this issue.


[SPARK-25468]Highlight current page index in the history server

What changes were proposed in this pull request?
This PR is highlight current page index in the history server
https://issues.apache.org/jira/browse/SPARK-25468
How was this patch tested?
Manual tests for Chrome, Firefox and Safari
Before modifying:

After modifying:

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Yes. I hit this issue also.

Hi @Adamyuanyuan ,
Please specify the code changes in your PR description. I take a quick check and you have added
 .paginate_button.active {
    outline: none;
    background-color: #2b2b2b;
  }

Personally I feel that the color is not good looking. Currently we change the background to this color when the mouse pointer is over the element. Maybe we can set another color for this highlight for distinguish from that?
Or we can change the border color only instead of the background.

@gengliangwang Thanks for reminder, I also think this color is not good looking. I tried to change the background color before, but I'm not sure which is better, please give me some opinion to choose:
1.

2.

3.

I prefer scheme 1 or scheme 3, scheme 3 is which I‘m borrowing from Spark UI of Stages Tab:

@Adamyuanyuan Thanks for the update!
+1 for the option 1 :)

Rather than modify jquery, can we override this in Spark-specific CSS? otherwise we might lose customizations when updating jquery.

Rather than modify jquery, can we override this in Spark-specific CSS? otherwise we might lose customizations when updating jquery.

Thanks for your advice, I think override is a better way.

Hi, @srowen, I find in SparkUI, the problem still exists:

I had moved ".paginate_button.active > a" to spark specific  webui.css.  And manual tests for Chrome, Firefox and Safari.

Another way is create a new css file such as historypage-specific.css, and add link in dataTablesHeaderNodes from UIUtils.scala, make new file only loaded when the table are used, like this:
  def dataTablesHeaderNodes: Seq[Node] = {
    <link rel="stylesheet"
          href={prependBaseUri("/static/jquery.dataTables.1.10.4.min.css")} type="text/css"/>
    <link rel="stylesheet"
          href={prependBaseUri("/static/dataTables.bootstrap.css")} type="text/css"/>
    <link rel="stylesheet" href={prependBaseUri("/static/jsonFormatter.min.css")} type="text/css"/>

    <link rel="stylesheet"
          href={prependBaseUri("/static/historypage-specific.css")} type="text/css"/>

    <script src={prependBaseUri("/static/jquery.dataTables.1.10.4.min.js")}></script>
    <script src={prependBaseUri("/static/jquery.cookies.2.2.0.min.js")}></script>
    <script src={prependBaseUri("/static/jquery.blockUI.min.js")}></script>
    <script src={prependBaseUri("/static/dataTables.bootstrap.min.js")}></script>
    <script src={prependBaseUri("/static/jsonFormatter.min.js")}></script>
    <script src={prependBaseUri("/static/jquery.mustache.js")}></script>
  }

But I think it's a bit redundant.

I think the change is fine, if it works and if it maybe causes the same behavior in the whole UI.

@dongjoon-hyun OK, modified.

Merged to master/2.4


feat: Adding initial base code for Oracle connector plugin

Description
The code changes are an initial commit which are limited to base code changes for incorporating oracle database connector plugin. The oracle plug-in works with prepared statements as well.
The code has been implemented by following the plugin creation guidelines, and this is just the first version.
Fixes #10096
Type of change

New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Unit test cases have been written, this is yet to be tested thoroughly. In this version of code only the basic oracle database connectivity had been planned, queries and prepared statements have been tested successfully with unit tests. More tests will be added in the subsequent PRs.

Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes

@sumitsum Can we take ownership of this PR & merge it in? This will ensure that the effort gone into this code till now will not be in vain.

@mohanarpit agree, we should take it forward. cc: @rohan-arthur

Hi @mohanarpit @sumitsum , I have incorporated most of the changes suggested in the earlier review, 4 more review points need to be resolved. I'm already working on it. Hence requesting you to please give me a couple of days to work on those and commit my changes.

@mohanarpit @sumitsum Please find more details about handling SSL for Oracle connections using thin driver in this source document and few reference links
https://www.oracle.com/technetwork/database/enterprise-edition/wp-oracle-jdbc-thin-ssl-130128.pdf
https://docs.oracle.com/javadb/<IP_ADDRESS>/adminguide/cadminsslclient.html
https://blogs.oracle.com/developers/post/ssl-connection-to-oracle-db-using-jdbc-tlsv12-jks-or-oracle-wallets-122-and-lower
There are a couple of things in SSL part which are WIP, and few more TCs need to be added as suggested by @sumitsum in the PR review. I'll continue to work on these.

@ahmediqbal3012 Thanks a lot for your contributions so far. We appreciate the effort that has gone into this PR till date. In the interest of time, we’ll start making commits to this branch so that we can drive this to closure. We will give full credit for this feature to you by celebrating you in our release notes. I hope that works for you.

@sumitsum, sure. I'm glad that I got a chance to contribute towards this. Thank you.

Really excited to test this feature , hope it is comin soon

Closed?

@guidogabriel sorry, I should have mentioned it in the comment when closing this pull request, we closed this pull request because we are pushing the changes through other pull requests using this pull request as a reference. The integration is still in progress.


v2 alpha - please make actionssdk proto file available

Hi
Please can someone from Google commit the actionssdk protocol buffers proto file to this repository.
Specifically I mean the protobuf file that is use to generate this:
https://github.com/actions-on-google/actions-on-google-nodejs/blob/v2.0.0-alpha/src/service/actionssdk/api/v2.ts
This would make it easier for users of the actionssdk library to store a history of received and sent messages in binary protobuf format instead of json, and would allow the community to more easily build client libraries in other languages.
I personally would be happy with just a copy of the protobuf file. I don't think this repository needs to contain the canonical protobuf file and entire build chain to produce the v2.ts file - just the protobuf file copied next to that file would be a great help.
Thanks

Hey, thanks for the feedback!
I filed a request to do this internally with your use cases and comments.
I will let you know of any updates on this.

Thanks a lot.

Due to more than 6 months of inactivity, this issue is being closed.
If you think the resolution is in error, please re-open the issue with fresh information.


[        ] -> +file:///Users/michalsikora/.flutter_sdk/flutter/packages/flutter/lib/src/services/clipboard.dart
[        ] -> +file:///Users/michalsikora/.flutter_sdk/flutter/packages/flutter/lib/src/services/font_loader.dart
[        ] -> +file:///Users/michalsikora/.flutter_sdk/flutter/packages/flutter/lib/src/services/haptic_feedback.dart
[        ] -> +file:///Users/michalsikora/.flutter_sdk/flutter/packages/flutter/lib/src/services/keyboard_key.dart
[        ] -> +file:///Users/michalsikora/.flutter_sdk/flutter/packages/flutter/lib/src/services/keyboard_maps.dart
[        ] -> +file:///Users/michalsikora/.flutter_sdk/flutter/packages/flutter/lib/src/services/message_codec.dart
[        ] -> +file:///Users/michalsikora/.flutter_sdk/flutter/packages/flutter/lib/src/services/message_codecs.dart
[        ] -> +file:///Users/michalsikora/.flutter_sdk/flutter/packages/flutter/lib/src/services/platform_channel.dart
[        ] -> +file:///Users/michalsikora/.flutter_sdk/flutter/packages/flutter/lib/src/services/platform_messages.dart
[        ] -> +file:///Users/michalsikora/.flutter_sdk/flutter/packages/flutter/lib/src/services/platform_views.dart
[        ] -> +file:///Users/michalsikora/.flutter_sdk/flutter/packages/flutter/lib/src/services/raw_keyboard.dart
[        ] -> +file:///Users/michalsikora/.flutter_sdk/flutter/packages/flutter/lib/src/services/raw_keyboard_android.dart
[        ] -> +file:///Users/michalsikora/.flutter_sdk/flutter/packages/flutter/lib/src/services/raw_keyboard_fuchsia.dart
[   +6 ms] -> +file:///Users/michalsikora/.flutter_sdk/flutter/packages/flutter/lib/src/services/raw_keyboard_linux.dart
[   +1 ms] -> +file:///Users/michalsikora/.flutter_sdk/flutter/packages/flutter/lib/src/services/raw_keyboard_macos.dart
[        ] -> +file:///Users/michalsikora/.flutter_sdk/flutter/packages/flutter/lib/src/services/system_channels.dart
[        ] -> +file:///Users/michalsikora/.flutter_sdk/flutter/packages/flutter/lib/src/services/system_chrome.dart
[        ] -> +file:///Users/michalsikora/.flutter_sdk/flutter/packages/flutter/lib/src/services/system_navigator.dart
[        ] -> +file:///Users/michalsikora/.flutter_sdk/flutter/packages/flutter/lib/src/services/system_sound.dart
[        ] -> +file:///Users/michalsikora/.flutter_sdk/flutter/packages/flutter/lib/src/services/text_editing.dart
[        ] -> +file:///Users/michalsikora/.flutter_sdk/flutter/packages/flutter/lib/src/services/text_formatter.dart
[        ] -> +file:///Users/michalsikora/.flutter_sdk/flutter/packages/flutter/lib/src/services/text_input.dart
[        ] -> +file:///Users/michalsikora/.flutter_sdk/flutter/packages/flutter/lib/src/widgets/animated_cross_fade.dart
[        ] -> +file:///Users/michalsikora/.flutter_sdk/flutter/packages/flutter/lib/src/widgets/animated_list.dart
[        ] -> +file:///Users/michalsikora/.flutter_sdk/flutter/packages/flutter/lib/src/widgets/animated_size.dart
[        ] -> +file:///Users/michalsikora/.flutter_sdk/flutter/packages/flutter/lib/src/widgets/animated_switcher.dart
[        ] -> +file:///Users/michalsikora/.flutter_sdk/flutter/packages/flutter/lib/src/widgets/annotated_region.dart
[        ] -> +file:///Users/michalsikora/.flutter_sdk/flutter/packages/flutter/lib/src/widgets/app.dart
[        ] -> +file:///Users/michalsikora/.flutter_sdk/flutter/packages/flutter/lib/src/widgets/async.dart
[        ] -> +file:///Users/michalsikora/.flutter_sdk/flutter/packages/flutter/lib/src/widgets/banner.dart
[        ] -> +file:///Users/michalsikora/.flutter_sdk/flutter/packages/flutter/lib/src/widgets/basic.dart
[        ] -> +file:///Users/michalsikora/.flutter_sdk/flutter/packages/flutter/lib/src/widgets/bottom_navigation_bar_item.dart
[        ] -> +file:///Users/michalsikora/.flutter_sdk/flutter/packages/flutter/lib/src/widgets/container.dart
[        ] -> +file:///Users/michalsikora/.flutter_sdk/flutter/packages/flutter/lib/src/widgets/debug.dart
[        ] -> +file:///Users/michalsikora/.flutter_sdk/flutter/packages/flutter/lib/src/widgets/dismissible.dart
[        ] -> +file:///Users/michalsikora/.flutter_sdk/flutter/packages/flutter/lib/src/widgets/drag_target.dart
[        ] -> +file:///Users/michalsikora/.flutter_sdk/flutter/packages/flutter/lib/src/widgets/draggable_scrollable_sheet.dart
[        ] -> +file:///Users/michalsikora/.flutter_sdk/flutter/packages/flutter/lib/src/widgets/scroll_notification.dart
[        ] -> +file:///Users/michalsikora/.flutter_sdk/flutter/packages/flutter/lib/src/widgets/editable_text.dart
[        ] -> +file:///Users/michalsikora/.flutter_sdk/flutter/packages/flutter/lib/src/widgets/fade_in_image.dart
[        ] -> +file:///Users/michalsikora/.flutter_sdk/flutter/packages/flutter/lib/src/widgets/focus_manager.dart
[        ] -> +file:///Users/michalsikora/.flutter_sdk/flutter/packages/flutter/lib/src/widgets/focus_scope.dart
[        ] -> +file:///Users/michalsikora/.flutter_sdk/flutter/packages/flutter/lib/src/widgets/focus_traversal.dart
[        ] -> +file:///Users/michalsikora/.flutter_sdk/flutter/packages/flutter/lib/src/widgets/form.dart
[        ] -> +file:///Users/michalsikora/.flutter_sdk/flutter/packages/flutter/lib/src/widgets/framework.dart
[        ] -> +file:///Users/michalsikora/.flutter_sdk/flutter/packages/flutter/lib/src/widgets/gesture_detector.dart
[        ] -> +file:///Users/michalsikora/.flutter_sdk/flutter/packages/flutter/lib/src/widgets/grid_paper.dart
[        ] -> +file:///Users/michalsikora/.flutter_sdk/flutter/packages/flutter/lib/src/widgets/heroes.dart
[        ] -> +file:///Users/michalsikora/.flutter_sdk/flutter/packages/flutter/lib/src/widgets/icon.dart
[        ] -> +file:///Users/michalsikora/.flutter_sdk/flutter/packages/flutter/lib/src/widgets/icon_data.dart
[   +5 ms] -> +file:///Users/michalsikora/.flutter_sdk/flutter/packages/flutter/lib/src/widgets/icon_theme.dart
[        ] -> +file:///Users/michalsikora/.flutter_sdk/flutter/packages/flutter/lib/src/widgets/icon_theme_data.dart
[        ] -> +file:///Users/michalsikora/.flutter_sdk/flutter/packages/flutter/lib/src/widgets/image.dart
[        ] -> +file:///Users/michalsikora/.flutter_sdk/flutter/packages/flutter/lib/src/widgets/image_icon.dart
[        ] -> +file:///Users/michalsikora/.flutter_sdk/flutter/packages/flutter/lib/src/widgets/implicit_animations.dart
[        ] -> +file:///Users/michalsikora/.flutter_sdk/flutter/packages/flutter/lib/src/widgets/inherited_model.dart
[        ] -> +file:///Users/michalsikora/.flutter_sdk/flutter/packages/flutter/lib/src/widgets/inherited_notifier.dart
[        ] -> +file:///Users/michalsikora/.flutter_sdk/flutter/packages/flutter/lib/src/widgets/layout_builder.dart
[        ] -> +file:///Users/michalsikora/.flutter_sdk/flutter/packages/flutter/lib/src/widgets/list_wheel_scroll_view.dart
[        ] -> +file:///Users/michalsikora/.flutter_sdk/flutter/packages/flutter/lib/src/widgets/localizations.dart
[        ] -> +file:///Users/michalsikora/.flutter_sdk/flutter/packages/flutter/lib/src/widgets/media_query.dart
[        ] -> +file:///Users/michalsikora/.flutter_sdk/flutter/packages/flutter/lib/src/widgets/modal_barrier.dart
[        ] -> +file:///Users/michalsikora/.flutter_sdk/flutter/packages/flutter/lib/src/widgets/navigation_toolbar.dart
[        ] -> +file:///Users/michalsikora/.flutter_sdk/flutter/packages/flutter/lib/src/widgets/navigator.dart
[        ] -> +file:///Users/michalsikora/.flutter_sdk/flutter/packages/flutter/lib/src/widgets/nested_scroll_view.dart
[        ] -> +file:///Users/michalsikora/.flutter_sdk/flutter/packages/flutter/lib/src/widgets/notification_listener.dart
[        ] -> +file:///Users/michalsikora/.flutter_sdk/flutter/packages/flutter/lib/src/widgets/orientation_builder.dart
[        ] -> +file:///Users/michalsikora/.flutter_sdk/flutter/packages/flutter/lib/src/widgets/overlay.dart
[        ] -> +file:///Users/michalsikora/.flutter_sdk/flutter/packages/flutter/lib/src/widgets/overscroll_indicator.dart
[        ] -> +file:///Users/michalsikora/.flutter_sdk/flutter/packages/flutter/lib/src/widgets/page_storage.dart
[        ] -> +file:///Users/michalsikora/.flutter_sdk/flutter/packages/flutter/lib/src/widgets/page_view.dart
[        ] -> +file:///Users/michalsikora/.flutter_sdk/flutter/packages/flutter/lib/src/widgets/pages.dart
[        ] -> +file:///Users/michalsikora/.flutter_sdk/flutter/packages/flutter/lib/src/widgets/performance_overlay.dart
[        ] -> +file:///Users/michalsikora/.flutter_sdk/flutter/packages/flutter/lib/src/widgets/placeholder.dart
[        ] -> +file:///Users/michalsikora/.flutter_sdk/flutter/packages/flutter/lib/src/widgets/platform_view.dart
[        ] -> +file:///Users/michalsikora/.flutter_sdk/flutter/packages/flutter/lib/src/widgets/preferred_size.dart
[        ] -> +file:///Users/michalsikora/.flutter_sdk/flutter/packages/flutter/lib/src/widgets/primary_scroll_controller.dart
[        ] -> +file:///Users/michalsikora/.flutter_sdk/flutter/packages/flutter/lib/src/widgets/raw_keyboard_listener.dart
[        ] -> +file:///Users/michalsikora/.flutter_sdk/flutter/packages/flutter/lib/src/widgets/routes.dart
[        ] -> +file:///Users/michalsikora/.flutter_sdk/flutter/packages/flutter/lib/src/widgets/safe_area.dart
[        ] -> +file:///Users/michalsikora/.flutter_sdk/flutter/packages/flutter/lib/src/widgets/scroll_activity.dart
[        ] -> +file:///Users/michalsikora/.flutter_sdk/flutter/packages/flutter/lib/src/widgets/scroll_configuration.dart
[        ] -> +file:///Users/michalsikora/.flutter_sdk/flutter/packages/flutter/lib/src/widgets/scroll_context.dart
[        ] -> +file:///Users/michalsikora/.flutter_sdk/flutter/packages/flutter/lib/src/widgets/scroll_controller.dart
[        ] -> +file:///Users/michalsikora/.flutter_sdk/flutter/packages/flutter/lib/src/widgets/scroll_metrics.dart
[        ] -> +file:///Users/michalsikora/.flutter_sdk/flutter/packages/flutter/lib/src/widgets/scroll_physics.dart
[        ] -> +file:///Users/michalsikora/.flutter_sdk/flutter/packages/flutter/lib/src/widgets/scroll_position.dart
[        ] -> +file:///Users/michalsikora/.flutter_sdk/flutter/packages/flutter/lib/src/widgets/scroll_position_with_single_context.dart
[        ] -> +file:///Users/michalsikora/.flutter_sdk/flutter/packages/flutter/lib/src/widgets/scroll_simulation.dart
[   +2 ms] -> +file:///Users/michalsikora/.flutter_sdk/flutter/packages/flutter/lib/src/widgets/scroll_view.dart
[        ] -> +file:///Users/michalsikora/.flutter_sdk/flutter/packages/flutter/lib/src/widgets/scrollable.dart
[        ] -> +file:///Users/michalsikora/.flutter_sdk/flutter/packages/flutter/lib/src/widgets/scrollbar.dart
[        ] -> +file:///Users/michalsikora/.flutter_sdk/flutter/packages/flutter/lib/src/widgets/semantics_debugger.dart
[        ] -> +file:///Users/michalsikora/.flutter_sdk/flutter/packages/flutter/lib/src/widgets/single_child_scroll_view.dart
[        ] -> +file:///Users/michalsikora/.flutter_sdk/flutter/packages/flutter/lib/src/widgets/size_changed_layout_notifier.dart
[        ] -> +file:///Users/michalsikora/.flutter_sdk/flutter/packages/flutter/lib/src/widgets/sliver.dart
[        ] -> +file:///Users/michalsikora/.flutter_sdk/flutter/packages/flutter/lib/src/widgets/sliver_persistent_header.dart
[        ] -> +file:///Users/michalsikora/.flutter_sdk/flutter/packages/flutter/lib/src/widgets/sliver_prototype_extent_list.dart
[        ] -> +file:///Users/michalsikora/.flutter_sdk/flutter/packages/flutter/lib/src/widgets/spacer.dart
[        ] -> +file:///Users/michalsikora/.flutter_sdk/flutter/packages/flutter/lib/src/widgets/status_transitions.dart
[        ] -> +file:///Users/michalsikora/.flutter_sdk/flutter/packages/flutter/lib/src/widgets/table.dart
[        ] -> +file:///Users/michalsikora/.flutter_sdk/flutter/packages/flutter/lib/src/widgets/text.dart
[        ] -> +file:///Users/michalsikora/.flutter_sdk/flutter/packages/flutter/lib/src/widgets/text_selection.dart
[        ] -> +file:///Users/michalsikora/.flutter_sdk/flutter/packages/flutter/lib/src/widgets/texture.dart
[        ] -> +file:///Users/michalsikora/.flutter_sdk/flutter/packages/flutter/lib/src/widgets/title.dart
[        ] -> +file:///Users/michalsikora/.flutter_sdk/flutter/packages/flutter/lib/src/widgets/transitions.dart
[        ] -> +file:///Users/michalsikora/.flutter_sdk/flutter/packages/flutter/lib/src/widgets/unique_widget.dart
[        ] -> +file:///Users/michalsikora/.flutter_sdk/flutter/packages/flutter/lib/src/widgets/value_listenable_builder.dart
[        ] -> +file:///Users/michalsikora/.flutter_sdk/flutter/packages/flutter/lib/src/widgets/viewport.dart
[        ] -> +file:///Users/michalsikora/.flutter_sdk/flutter/packages/flutter/lib/src/widgets/visibility.dart
[        ] -> +file:///Users/michalsikora/.flutter_sdk/flutter/packages/flutter/lib/src/widgets/widget_inspector.dart
[        ] -> +file:///Users/michalsikora/.flutter_sdk/flutter/packages/flutter/lib/src/widgets/will_pop_scope.dart
[        ] -> +file:///Users/michalsikora/.flutter_sdk/flutter/packages/flutter/lib/widgets.dart
[        ] -> +file:///Users/michalsikora/Dev/copy_paste_bug/lib/main.dart
[        ] -> 0186867b-b304-4207-8c16-db564bca7b2b build/app.dill 0
[        ] Updating files
[ +202 ms] DevFS: Sync finished
[   +1 ms] Syncing files to device FRD L09... (completed in 2,344ms, longer than expected)
[        ] Synced 0.8MB.
[   +2 ms] Sending to VM service: _flutter.listViews({})
[   +4 ms] Result: {type: FlutterViewList, views: [{type: FlutterView, id: _flutterView/0x770edb6218, isolate: {type: @Isolate, fixedId: true, id: isolates/129222732, name: main.dart$main-129222732, number: 129222732}}]}
[   +1 ms] <- accept
[        ] Connected to _flutterView/0x770edb6218.
[   +2 ms] 🔥  To hot reload changes while running, press "r". To hot restart (and rebuild state), press "R".
[        ] An Observatory debugger and profiler on FRD L09 is available at: http://<IP_ADDRESS>:54710/k18vyxeEiF4=/
[        ] For a more detailed help message, press "h". To detach, press "d"; to quit, press "q".
[+5507 ms] I/hwaps   (20836): JNI_OnLoad
[ +206 ms] I/HwSecImmHelper(20836): mSecurityInputMethodService is null
[  +16 ms] E/SpannableStringBuilder(20836): SPAN_EXCLUSIVE_EXCLUSIVE spans cannot have a zero length
[        ] E/SpannableStringBuilder(20836): SPAN_EXCLUSIVE_EXCLUSIVE spans cannot have a zero length
[   +3 ms] E/SpannableStringBuilder(20836): SPAN_EXCLUSIVE_EXCLUSIVE spans cannot have a zero length
[        ] E/SpannableStringBuilder(20836): SPAN_EXCLUSIVE_EXCLUSIVE spans cannot have a zero length
[+5991 ms] I/HwSecImmHelper(20836): mSecurityInputMethodService is null
[  +24 ms] I/HwSecImmHelper(20836): mSecurityInputMethodService is null
[   +6 ms] I/HwSecImmHelper(20836): mSecurityInputMethodService is null
[   +3 ms] I/HwSecImmHelper(20836): mSecurityInputMethodService is null
[   +4 ms] I/HwSecImmHelper(20836): mSecurityInputMethodService is null
[   +4 ms] I/HwSecImmHelper(20836): mSecurityInputMethodService is null
[   +3 ms] I/HwSecImmHelper(20836): mSecurityInputMethodService is null
[   +3 ms] I/HwSecImmHelper(20836): mSecurityInputMethodService is null
[   +4 ms] I/HwSecImmHelper(20836): mSecurityInputMethodService is null
[   +3 ms] I/HwSecImmHelper(20836): mSecurityInputMethodService is null
[   +5 ms] I/HwSecImmHelper(20836): mSecurityInputMethodService is null
[   +3 ms] I/HwSecImmHelper(20836): mSecurityInputMethodService is null
[+7774 ms] E/SpannableStringBuilder(20836): SPAN_EXCLUSIVE_EXCLUSIVE spans cannot have a zero length
[        ] E/SpannableStringBuilder(20836): SPAN_EXCLUSIVE_EXCLUSIVE spans cannot have a zero length
[  +39 ms] E/SpannableStringBuilder(20836): SPAN_EXCLUSIVE_EXCLUSIVE spans cannot have a zero length
[        ] E/SpannableStringBuilder(20836): SPAN_EXCLUSIVE_EXCLUSIVE spans cannot have a zero length
[+9874 ms] E/SpannableStringBuilder(20836): SPAN_EXCLUSIVE_EXCLUSIVE spans cannot have a zero length
[        ] E/SpannableStringBuilder(20836): SPAN_EXCLUSIVE_EXCLUSIVE spans cannot have a zero length
[+1387 ms] I/HwSecImmHelper(20836): mSecurityInputMethodService is null
[  +20 ms] I/HwSecImmHelper(20836): mSecurityInputMethodService is null
[   +1 ms] I/HwSecImmHelper(20836): mSecurityInputMethodService is null
[   +7 ms] I/HwSecImmHelper(20836): mSecurityInputMethodService is null
[   +8 ms] I/HwSecImmHelper(20836): mSecurityInputMethodService is null
[   +7 ms] I/HwSecImmHelper(20836): mSecurityInputMethodService is null
[+2390 ms] W/IInputConnectionWrapper(20836): getExtractedText on inactive InputConnection
[   +1 ms] W/IInputConnectionWrapper(20836): getTextBeforeCursor on inactive InputConnection
[+4391 ms] W/IInputConnectionWrapper(20836): finishComposingText on inactive InputConnection
[   +1 ms] W/IInputConnectionWrapper(20836): reportFullscreenMode on inexistent InputConnection
[   +6 ms] W/IInputConnectionWrapper(20836): finishComposingText on inactive InputConnection
[+1098 ms] Service protocol connection closed.
[        ] Lost connection to device.
[   +2 ms] DevFS: Deleting filesystem on the device (file:///data/user/0/com.example.copy_paste_bug/code_cache/copy_paste_bugGIIAGR/copy_paste_bug/)
[        ] Sending to VM service: _deleteDevFS({fsName: copy_paste_bug})
[ +257 ms] Ignored error while cleaning up DevFS: TimeoutException after 0:00:00.250000: Future not completed
[   +3 ms] "flutter run" took 73,560ms.
[        ] "flutter run" took 73,560ms.

flutter analyze
Analyzing copy_paste_bug...
No issues found! (ran in 7.6s)

flutter doctor -v
[✓] Flutter (Channel unknown, v1.6.3, on Mac OS X 10.14.5 18F132, locale en-PL)
    • Flutter version 1.6.3 at /Users/michalsikora/.flutter_sdk/flutter
    • Framework revision bc7bc94083 (8 weeks ago), 2019-05-23 10:29:07 -0700
    • Engine revision 8dc3a4cde2
    • Dart version 2.3.2 (build 2.3.2-dev.0.0 e3edfd36b2)

[✓] Android toolchain - develop for Android devices (Android SDK version 28.0.3)
    • Android SDK at /Users/michalsikora/Library/Android/sdk
    • Android NDK location not configured (optional; useful for native profiling support)
    • Platform android-28, build-tools 28.0.3
    • ANDROID_HOME = /Users/michalsikora/Library/Android/sdk
    • Java binary at: /Users/michalsikora/Library/Application Support/JetBrains/Toolbox/apps/AndroidStudio/ch-0/183.5692245/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_152-release-1343-b01)
    • All Android licenses accepted.

[!] iOS toolchain - develop for iOS devices (Xcode 10.2.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 10.2.1, Build version 10E1001
    ✗ Verify that all connected devices have been paired with this computer in Xcode.
      If all devices have been paired, libimobiledevice and ideviceinstaller may require updating.
      To update with Brew, run:
        brew update
        brew uninstall --ignore-dependencies libimobiledevice
        brew uninstall --ignore-dependencies usbmuxd
        brew install --HEAD usbmuxd
        brew unlink usbmuxd
        brew link usbmuxd
        brew install --HEAD libimobiledevice
        brew install ideviceinstaller
    • ios-deploy 1.9.4
    • CocoaPods version 1.7.2

[✓] Android Studio (version 3.4)
    • Android Studio at /Users/michalsikora/Library/Application Support/JetBrains/Toolbox/apps/AndroidStudio/ch-0/183.5692245/Android Studio.app/Contents
    • Flutter plugin version 37.0.1
    • Dart plugin version 183.6270
    • Java version OpenJDK Runtime Environment (build 1.8.0_152-release-1343-b01)

[✓] VS Code (version 1.36.1)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.2.0

[✓] Connected device (1 available)
    • FRD L09 • 73QDU16B24003748 • android-arm64 • Android 7.0 (API 24)

! Doctor found issues in 1 category.

I think this is a duplicate of https://github.com/flutter/flutter/issues/35998.
Thanks for posting this though.  I changed the title of the other issue a bit to be more obviously related to this one.


checkstyle: check for star imports #228

fixes #228
Ready for review.

@m133225 any input on this PR?

@chao1995 I added a commit message body. In future, remember to add a commit message body explaining the rationale for the change.


OutOfMemory w/100+GB free

Issue:
ArangoDB crashed reporting the following lines, "out of memory".
Even tough there are 100+GB of free RAM
2016-07-12T21:17:30Z [1] INFO file-descriptors (nofiles) hard limit is 1048576, soft limit is 524288
2016-07-12T21:17:30Z [1] INFO Authentication is turned off
2016-07-12T21:17:30Z [1] INFO ArangoDB (version 2.8.9 [linux]) is ready for business. Have fun!

#
# Fatal error in Scavenge promotion failed
# Allocation failed - process out of memory
#

Context:
Connecting w/gremlin as:
c=new ArangoDBConfiguration("arango", 8529);
g=new ArangoDBGraph(c, "mysuperdb", "V", "E")

Collection V and E was previously imported with arangoimp.
Size on disc of the json file: 46GB

Hi,
This is an error message of the V8 garbage collector. Parts of the blueprints API had been implemented using Javascript.
In general the future save and recommended way of working with Graphs in ArangoDB is to work with pattern matching traversals through AQL, which are implemented natively and thus are able to utilize all available resources of your machine.

Hi @dothebart ,
Thank you for answer.
ArangoDB will not be the only graph database I'll to talk to...that's why I choose gremlin ...
There is no way to make it work without go native?

Hi Martin,
the current gremlin definition doesn't fit well to ArangoDBs internal data model - thus the blueprints wrapper layer available in ArangoDB 2.8. Similar to ORMs on top of classical relational databases you won't get the maximum out of your system if you use the Tinkerpop wrapper.
We evolved the  ArangoDB graphing features a lot with the pattern matching traversals to give users more power over their data. The result is a very well readable syntax within AQL where you can freely combine document queries with graph queries - which enables you to effectively work with your data inside of ArangoDB and fetch the results with the ArangoDB Java Driver.
In the future we may see a better ArangoDB Tinkerpop3 implementation, but to be honest, I can't give you any ETA if and when this is going to be available.
So, the answer currently is - yes, if you want to work with big graphs in ArangoDB you have to use AQL.

Ok, got it!
Thank you so much!


Provide ability to sync to multiple storages

Hey,
It would be awesome if we could do something like this:
  withStorageSync({
    key: 'my-key,
    select: (state: AppState) => ({ propertyToStoreInSession: state.propertyToStoreInSession }),
    storage: () => sessionStorage,
  }),
  withStorageSync({
    key: 'my-key',
    select: (state: AppState) => ({ propertyToStoreInLocal: state.propertyToStoreInLocal }),
    storage: () => localStorage,
  }),

But this results in SignalStore members cannot be overridden. Trying to override: clearStorage, readFromStorage, writeToStorage
Would it be an option to to set something like:
{
   clearStorage: 'clearLocalStorage',
   readFromStorage: 'readFromLocalStorage'
   writeToStorage: 'writeToLocalStorage'
}

as config value so that it would be possible to overwrite the provided method names?

Hey Rainer,
your are right we are talking about a single SignalStore, but is there any reason, why I could not use  SignalStores on all Levels of my application, meaning: root-layer (AppState), domain-layer (domain-state), feature-layer (feature-state), component-layer (component-state).
From my understanding I can implement a SignalStore depending on my needs furthermore I would like to use a single kind of store implementation (not "normal" store and signal store) to have better code consistency and easier readabilty.


[ENHANCEMENT] Update troubleshooting for compiling mex function

Depending on the operating system and compiler, the mex function, run_dynamics_fast, needs to be compiled with or without the -g flag. By default, the em-core/matlab/RUN_mex.m script uses the -g flag for windows PC and not the flag for other operating systems. However, @lydiaZeleke using MacOS and the Clang compiler (  Apple clang version 12.0.5 (clang-1<IP_ADDRESS>) required compiling with the -g. While the function should compile without or without the flag, when executing MATLAB can hard crash.
The em-core documentation should provide troubleshooting guidance to try removing or adding the -g flag if MATLAB hard crashes when using run_dynamics_fast.

Issue no longer related due to pull request #8


Bump version for opensearch 1.1.0 release

Description
Bump version for opensearch 1.1.0 release
Issues Resolved
[List any issues this PR will resolve]
Check List

[ ] New functionality includes testing.

[x] All tests pass, including unit test, integration test and doctest

[ ] New functionality has been documented.

[ ] New functionality has javadoc added
[ ] New functionality has user manual doc added

[x] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Codecov Report

Merging #24 (8172ac0) into main (ca400bc) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #24   +/-   ##
=======================================
  Coverage   95.30%   95.30%
=======================================
  Files           5        5
  Lines         149      149
  Branches       45       45
=======================================
  Hits          142      142
  Misses          7        7

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ca400bc...8172ac0. Read the comment docs.


Convert match

The conversion of Match.hs is done. The only thing not done yet is to try executing it.

Looks plausible...

CI says yes! Thanks - I await an actual test of it.

Yes, there is at least one known bug and more PRs to follow but for now, here is the first bit of proof positive.


Luminea WLAN LED Bulb ZX-2831-675

I'm trying to convert the mention WiFi LED bulb (is listed as compatible devices) but I have no success.
The script come to "Waiting for the upgraded device to appear" and I get a lot of ........
Some how the device cannot be find.
When the bulb in paring mode (flashing on regular basis (switch on/switch off) I can see the bulb AP. IS this OK?
I used the latest version of tuya-convert.

The device needs to be in EZ Config mode, not AP Config mode. It should blink quickly and no AP should appear from the device.

Thank you. Managed to convert. To help others: to put the bulb in EZ Config mode the switch on/off needs to be really quick (5 time at least).


Convex contain

Implementation of convex_contain is too long and not so fast. Replace two binary search by only one binary search.

Reimplemented and tested.


fixing url encode for %QUERY placeholder

There is a new release that contains your pull request:
https://github.com/WebPaperElements/paper-input-autocomplete-chips/releases/tag/0.30.2


tf.train.range_input_producer computes "limit" argument more than once

Hello, I have an issue with unexpected behavior of range_input_producer. It recomputes its "limit" argument more times than needed.
`
import tensorflow as tf
limit = tf.Print(tf.constant(5, dtype=tf.int32), [0], "compute limit")
range = tf.train.range_input_producer(limit, shuffle=False, num_epochs=1)
idx = range.dequeue()
with tf.Session() as ss:
ss.run(tf.initialize_all_variables())
ss.run(tf.initialize_local_variables())
coord = tf.train.Coordinator()
threads = tf.train.start_queue_runners(sess=ss, coord=coord)
while True:
print(ss.run([idx]))
`
When num_epoch=1, the output will have "compute limit" twice. I expect it to appear only once.
When num_epoch=None, the output will have infinitely many "compute limit" messages. But I am expecting, that it should read limit only once and then cycle through generated range infinitely.
Things get important when "limit" is coming from previous queue, which after getting empty produces OutOfRange and for some reasons it is not handled by range_input_producer.
Environment info
Operating System: Fedora 24
Installed version of CUDA and cuDNN:
(please attach the output of ls -l /path/to/cuda/lib/libcud*):
/usr/local/cuda/lib64/libcudadevrt.a       /usr/local/cuda/lib64/libcudnn.so
/usr/local/cuda/lib64/libcudart.so         /usr/local/cuda/lib64/libcudnn.so.5
/usr/local/cuda/lib64/libcudart.so.8.0     /usr/local/cuda/lib64/libcudnn.so.5.1.5
/usr/local/cuda/lib64/libcudart.so.8.0.44  /usr/local/cuda/lib64/libcudnn_static.a
/usr/local/cuda/lib64/libcudart_static.a
If installed from binary pip package, provide:

A link to the pip package you installed:
https://storage.googleapis.com/tensorflow/linux/gpu/tensorflow-0.11.0-cp35-cp35m-linux_x86_64.whl
The output from python -c "import tensorflow; print(tensorflow.__version__)".
0.11.0

Automatically closing due to lack of recent activity. Since this issue is old at this point, please reopen the issue if it still occurs when tried with the latest version of Tensorflow. Thank you.


Issue with 'redux-form/immutable'

Getting below error when used with Immutable JS,
import { Field, reduxForm } from 'redux-form/immutable'
error:
Super expression must either be null or a function, not object
at _inherits (SubmissionError.js:17)
at SubmissionError.js:20
at Object. (SubmissionError.js:32)
at webpack_require (bootstrap cdd944b…:680)
at fn (bootstrap cdd944b…:105)
at Object. (handleSubmit.js:13)
at webpack_require (bootstrap cdd944b…:680)
at fn (bootstrap cdd944b…:105)
at Object. (reduxForm.js:43)
at webpack_require (bootstrap cdd944b…:680)

Please provide a minimal, working example. Start here: https://jsfiddle.net/gustavohenke/48814zsq/

ping @maheshambiga

I have found that problem is caused by
mainFields: [
  'jsnext:main',
  'main',
],

in webpack.config. Something wrong with redux-form 'jsnext:main'.
My solution is,
mainFields: [
  'main',
  'jsnext:main',
],

I think this is not the best solution but it works.


Autoformat closes gvim

I have cloned the repo in my plugins and when i do Autoformat, it will close gvim.

Interesting. What is you vimrc? What is the formatter you executed? How did you execute Autoformat? Can you get hold of the messages output right before it shuts down?

I found the vimrc line that causes the issue: set nocompatible | filetype indent plugin on | syn on
I then tried just: syntax enable
And this causes it to close too.

Weird. Does this mean you have fixed it?

No.  If I take out that line, AutoFormat works, but then i do not have syntax highlighting.  I can't work without syntax highlighting, so at this point i unfortunately can't use autoformat.

Still, extra information would be necessary to solve this issue, since it just works for most people WITH syntax highlighting. So:
What is you vimrc? What is the formatter you executed? How did you execute Autoformat? Can you get hold of the messages output right before it shuts down?

Hi,
Chipping in for future reference and maybe help you with the problem.
I had the exact same behavior with gVim on windowsn. My problem was due to python.
If entered the command ":python print 1", gvim would crash hard.
Turns out my PYTHONPATH environment variable was not set and thus making vim crash.
Once PYTHONPATH was set, I could run the python command without problem. And Autoformat started to work without problems.
Reference: http://stackoverflow.com/questions/35597157/gvim-crashes-when-running-python
Thank you.

AWESOME.  Autoformat is working now.  Thanks @slam02


Fix resource leak in TsFileOutputFormat

@qiaojialin PTAL

Hi, please merge the master branch, the ci is fixed~


Front End

Do something visual with the data :D.
Look into some frameworks that can be used.

Might need to transform this into a real back-end

Why was this closed?

Changed this repo to a package.
FE will be in a separate repo


Download and play áudio message

I saw that you have the option to save media but how to play an audio for example?

Example for download in :
https://github.com/mukulhase/WebWhatsapp-Wrapper/blob/master/sample/log_all.py

This solved all my problems https://green-api.com
WhatsApp API 30 days free trial and only $10/month


Incorrect RPO on comparison page

On our database comparison page, we have a rather large typo.  For the "Automated Repair and RPO" category, we have "Automated Repair RPO <10 sec" for CockroachDB.   This should say "Automated Repair, RPO = 0".  For CockroachDB RTO is < 10 sec and RPO is 0.  This should be a quick fix.
https://www.cockroachlabs.com/docs/stable/cockroachdb-in-comparison.html

We should change the title for that line item to: "Database Repair and RPO"? And if we add RTO, should we add that to both the title and values to all of the entries?

Another change for the comparison page: Add Aurora info.

The comparison page is maintained by Product Marketing so alerting @jaymce to this.


Failed to send push with Recipient time zone (iOS)

Environment

Xcode version: Any
Firebase SDK version: 5.10.0
Firebase Component: Messaging
Component version: 3.2.0

Problem
Failed to send  "Recipient time zone" push on devices with non 24-hours locale.
How to reproduce:
Send push on device with non 24-hours locale with recipient time zone enabled from Messaging console.

Fixed by #1947


Packaged WinUI app can not be installed on ARM64

Describe the bug
WinUI 2 in UWP or WinUI 3 in desktop app packages created for ARM64 contain dependencies for ARM that can't be installed.
Steps to reproduce the bug

Create a Blank App, Packaged with Windows Application Packaging Project (WinUI 3 in Desktop) project.
Project > Publish > Create App Packages...
Select Sideloading.
Select ARM64.
Install the created app package by running Install.ps1.

Found bundle: \Test.WinUI (Package)_<IP_ADDRESS>_Debug_Test\Test.WinUI (Package)_<IP_ADDRESS>_arm64_Debug.msixbundle
Installing app...
Found dependency package(s):
\Test.WinUI (Package)_<IP_ADDRESS>_Debug_Test\Dependencies\x86\Microsoft.VCLibs.x86.Debug.14.00.appx
\Test.WinUI (Package)_<IP_ADDRESS>_Debug_Test\Dependencies\x86\Microsoft.VCLibs.x86.Debug.14.00.Desktop.appx
\Test.WinUI (Package)_<IP_ADDRESS>_Debug_Test\Dependencies\x86\Microsoft.WindowsAppRuntime.1.0.msix
\Test.WinUI (Package)_<IP_ADDRESS>_Debug_Test\Dependencies\arm\Microsoft.VCLibs.ARM.Debug.14.00.appx
\Test.WinUI (Package)_<IP_ADDRESS>_Debug_Test\Dependencies\arm\Microsoft.VCLibs.ARM.Debug.14.00.Desktop.appx
\Test.WinUI (Package)_<IP_ADDRESS>_Debug_Test\Dependencies\arm64\Microsoft.VCLibs.ARM64.Debug.14.00.appx
\Test.WinUI (Package)_<IP_ADDRESS>_Debug_Test\Dependencies\arm64\Microsoft.WindowsAppRuntime.1.0.msix
Add-AppxPackage : Deployment failed with HRESULT: 0x80073D10, The deployment operation failed because the package targets the wrong processor architecture.

Windows cannot install package Microsoft.VCLibs.140.00.Debug because the package requires architecture ARM, but this computer has architecture ARM64.

Expected behavior
No response
Screenshots
No response
NuGet package version
1.0.0
Packaging type
Packaged (MSIX)
Windows version
Windows 11 (22000)
IDE
Visual Studio 2022
Additional context
No response

This issue is not unique to the Windows App SDK, but is a problem with the Add-AppDevPackage.ps1 generated by the app packaging logic.  This script is invoked by install.ps1, and explicitly attempts to install arm dependencies on an arm64 device:
line 467:
        if (($ProcessorArchitecture -eq "arm" -or $ProcessorArchitecture -eq "arm64") -and (Test-Path (Join-Path $DependencyPackagesDir "arm")))
You can work around this in two ways:

avoid the install.ps1 script and instead install the msixbundle directly on the target device, along with any arch-specific dependencies
as others have done, delete the arm dependency folder so that Add-AppDevPackage.ps1 doesn't find it and attempt to install it

I would also recommend opening a Visual Studio bug.  Note that the site is currently experiencing network errors.


Reorganize backend service and e2e test for incoming rest config logic

This commit provides the basic code structure to implement REST mmf support #442

/gcbrun


Add more error explanations in the BMP image loader

This closes #32166 and closes #30629.

modules/bmp/image_loader_bmp.cpp:55:117: error: conversion from 'size_t' (aka 'unsigned long') to 'const Variant' is ambiguous
                                        vformat("1-bpp BMP images must have a width that is a multiple of 8, but the imported BMP is %d pixels wide.", width));
                                                                                ^~~~~

You should probably cast to int.

Thanks!

Cherry-picked for 3.2.3.


subfolder for nginx 404 even use rewrite url

my nginx conf:
server {
    listen       80;
    server_name  site.com;
    client_max_body_size 50M;

    #charset koi8-r;
    access_log  /var/log/nginx/access.80.log;

    location / {
        root   /var/www/tools.site.com;
        index  index.html index.htm;
        try_files $uri $uri /index.html;
    }

    location /grav/ {
        root   /var/www/tools.site.com/grav;
        index  index.html index.php;
        rewrite ^/grav/(.*)+$ /grav/index.php?$1;
        try_files $uri $uri/ /grav/index.php?$query_string;
    }

    ## Begin - PHP
    location ~ \.php$ {
        # Choose either a socket or TCP/IP address
        fastcgi_pass unix:/var/run/php/php7.0-fpm.sock;
        # fastcgi_pass unix:/var/run/php5-fpm.sock; #legacy
        # fastcgi_pass <IP_ADDRESS>:9000;

        fastcgi_split_path_info ^(.+\.php)(/.+)$;
        fastcgi_index index.php;
        include fastcgi_params;
        fastcgi_param SCRIPT_FILENAME $document_root/$fastcgi_script_name;
    }
    ## End - PHP

    error_page  404              /404.html;

    # redirect server error pages to the static page /50x.html
    #
    error_page   500 502 503 504  /50x.html;
    location = /50x.html {
        root   /usr/share/nginx/html;
    }
}

the grav root folder is /var/www/tools.site.com/grav
still got 404 error if access http://site.com/grav, did I missed anything?

Based on the most basic nginx.conf file:
server {
    #listen 80;
    index index.html index.php;

    ## Begin - Server Info
    root /home/USER/www/html;
    server_name localhost;
    ## End - Server Info

    ## Begin - Index
    # for subfolders, simply adjust:
    # `location /subfolder {`
    # and the rewrite to use `/subfolder/index.php`
    location / {
        try_files $uri $uri/ /index.php?$query_string;
    }
    ## End - Index

    ## Begin - Security
    # deny all direct access for these folders
    location ~* /(\.git|cache|bin|logs|backup|tests)/.*$ { return 403; }
    # deny running scripts inside core system folders
    location ~* /(system|vendor)/.*\.(txt|xml|md|html|yaml|yml|php|pl|py|cgi|twig|sh|bat)$ { return 403; }
    # deny running scripts inside user folder
    location ~* /user/.*\.(txt|md|yaml|yml|php|pl|py|cgi|twig|sh|bat)$ { return 403; }
    # deny access to specific files in the root folder
    location ~ /(LICENSE\.txt|composer\.lock|composer\.json|nginx\.conf|web\.config|htaccess\.txt|\.htaccess) { return 403; }
    ## End - Security

    ## Begin - PHP
    location ~ \.php$ {
        # Choose either a socket or TCP/IP address
        fastcgi_pass unix:/var/run/php/php7.2-fpm.sock;
        # fastcgi_pass unix:/var/run/php5-fpm.sock; #legacy
        # fastcgi_pass <IP_ADDRESS>:9000;

        fastcgi_split_path_info ^(.+\.php)(/.+)$;
        fastcgi_index index.php;
        include fastcgi_params;
        fastcgi_param SCRIPT_FILENAME $document_root/$fastcgi_script_name;
    }
    ## End - PHP
}

You should really only need to change the location block to include the grav path..
location /grav {
   try_files $uri $uri/ /grav/index.php?$query_string;
}

root should just be the main root, ie root /var/www/tools.site.com/

try
location / {
   try_files $uri $uri/ /grav/index.php?$query_string;
}

instead, and leave the other stuff as originally recommended - you may want to adjust system/config/system.yaml as well. :)


toolbox: new script gpu-operator/must-gather.sh

This PR creats a must-gather plugin image for the GPU Operator.
The first patch is focused on collecting all the relevant information.
The second patch is the must-gather entrypoint (see here and there) and image recipe.

/test gpu-operator-e2e

/test gpu-operator-e2e

/test gpu-operator-e2e

/test gpu-operator-e2e

/test gpu-operator-e2e

/test gpu-operator-e2e

/test gpu-operator-e2e

/test gpu-operator-e2e

/test gpu-operator-e2e

/test gpu-operator-e2e

/test gpu-operator-e2e
On Tue, Apr 20, 2021 at 10:19 AM openshift-ci[bot] @.***>
wrote:

@kpouget https://github.com/kpouget: The following test failed, say
/retest to rerun all failed tests:
Test name Commit Details Rerun command
ci/prow/gpu-operator-e2e fa8c3fa
https://github.com/openshift-psap/ci-artifacts/commit/fa8c3fa1b3b6c36db31675b771bd192d31377180
link
https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/openshift-psap_ci-artifacts/111/pull-ci-openshift-psap-ci-artifacts-master-gpu-operator-e2e/1384403074671448064 /test
gpu-operator-e2e
Full PR test history
https://prow.ci.openshift.org/pr-history?org=openshift-psap&repo=ci-artifacts&pr=111.
Your PR dashboard
https://prow.ci.openshift.org/pr?query=is:pr+state:open+author:kpouget.
Instructions for interacting with me using PR comments are available here
https://git.k8s.io/community/contributors/guide/pull-requests.md. If
you have questions or suggestions related to my behavior, please file an
issue against the kubernetes/test-infra
https://github.com/kubernetes/test-infra/issues/new?title=Prow issue:
repository. I understand the commands that are listed here
https://go.k8s.io/bot-commands.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/openshift-psap/ci-artifacts/pull/111#issuecomment-823078882,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABZVQIT6UELUBO3VHDEQ5ETTJU2FNANCNFSM43BQB2DA
.

/test gpu-operator-e2e

/test gpu-operator-e2e

/test gpu-operator-e2e

/test gpu-operator-e2e

/test gpu-operator-e2e

/test gpu-operator-e2e

/test gpu-operator-e2e

/test gpu-operator-e2e

/hold

/test gpu-operator-e2e

/test gpu-operator-e2e

/approve

/hold cancel

Part of https://github.com/openshift-psap/ci-artifacts/issues/104

@ArangoGutierrez or @dagrayvid it you have some time to review this PR, would be appreciated :)

Hello @jmencak, if you're good with the PR, it's ready for merging from my POV
/label tide/merge-method-rebase

/lgtm
Looks good to me, Kevin. Thank you for the PR.

thanks @jmencak :)


fix: move enhanced punctuation section to top of features doc

Summary by CodeRabbit

New Features

Introduced an "Enhanced punctuation" feature for improved transcription accuracy and naturalness.
Added the punctuation_enhanced parameter to enable this feature in transcription requests.

Documentation

Updated documentation to include details about the new punctuation feature and its integration with existing functionalities.

Cleaning in another PR


CONFIGURATION-805 - Use try with resource

@dependabot rebase

@arturobernalg May you please rebase on master?

HI @garydgregory
Done
TY


Set $STBT_CONFIG_FILE to an absolute path

So that stbt will find it no matter which directory you run stbt
from.

Yep, looks good to me.


Updated My Username, twitter and linkedIn profile

Oh, that was your file previously, OK, thanks for your PR.


Remove external download dependency for country-specific carbon cost

See SSL issue in #47. Rather than downloading it, we should cache it in our repo for reproducibility and prevent networking issues

Fixed in #51

Fixed in #51


full width doesn't work if returned ruler width value is 0

was totally sold on the full width section thing when i saw the screenshot
didn't work out of the box though, the ruler width was zero so the math was off.
looked into it and saw you're returning the first value from the ruler positions array
i changed it to make sure the value is not zero, opened a pr #3

You're right, didn't assume it could be zero. Merging 👍


Performance comparison of OT top-level block vs. Silver Oak

Issue #469

LGTM

For the final analysis we need to complete the implementation fo the AES control block.

FWIW, at least initially we won't support 128/192 AES (only 256) which should mean we will use less resources.

Noted. I keep forgetting about this.

W

LGTM

For the final analysis we need to complete the implementation fo the AES control block.

FWIW, at least initially we won't support 128/192 AES (only 256) which should mean we will use less resources.

Noted. I keep forgetting about this.

Perhaps we can easily tweak the OT design to remove the 128/192 behviour.

W

LGTM

For the final analysis we need to complete the implementation fo the AES control block.

FWIW, at least initially we won't support 128/192 AES (only 256) which should mean we will use less resources.

Noted. I keep forgetting about this.

Perhaps we can easily tweak the OT design to remove the 128/192 behviour.

The 192 can be disabled through a SystemVerilog parameter (at least the parameter is there, I haven;t tested), 128 would require modification. I'll also try to estimate how much additional work for us to support 128/192


Overwriting a scene doesn't update all instances of that scene until I reload the main scene

Godot version
v4.1.stable.mono.official [970459615]
System information
Godot v4.1.stable.mono - Windows 10.0.19045 - Vulkan (Forward+) - dedicated NVIDIA GeForce RTX 3060 Ti (NVIDIA; <IP_ADDRESS>79) - AMD Ryzen 5 5600 6-Core Processor (12 Threads)
Issue description
Overwriting a scene doesn't update all instances of that scene. Restarting Godot or simply closing and reopening the root scene fixes the issue.
Steps to reproduce
Create a new project and a 3D scene and save it
Add a CanvasLayer
Add a Control as a child to the CanvasLayer
Add a Button to the Control and resize it
Set the Button's text to "A"
Save the Control as control.tscn
Add a second instance of control.tscn (node named Control2) to the CanvasLayer and move it to a different location (so it doesn't cover the first one)
Select the first Control and "make local".
Select the Button on it and resize it, so that it is now smaller than the second one
Change the text on this button to "B"
Now you see two buttons: a small button that says "B" and a big button that says "A"
Save the Control and overwrite control.tscn
Expected result: both controls should have small buttons that say "B"
Actual result: the first control is a small button with B on it, and the second one is a large button with A on it
Save the root scene and close it
open the root scene again
Now both controls have small buttons that say "B"
Minimal reproduction project
bugtest3.zip
(here the root scene is node_3d.tscn)

I am experiencing the same problem. Reloading the scene containing the instance works
Godot Engine 4.3.stable.arch_linux


[BUG] Get-PnPGroupPermissions: Object reference not set to an instance of an object.

Reporting an Issue
Get-PnPGroupPermissions raises "Object reference not set to an instance of an object" exception when using existing group title as Identity.
Expected behavior
Expecting to get permissions for a group identified by its title.
Actual behavior
Command raises a NullReferenceException when specifying a group name (existing or not).
Notice that no exception occurs when passing a group object or its Id... and of course no results either.
Steps to reproduce behavior
Connect-PnPOnline -Url $url -Credentials $credentials
$group = Get-PnPGroup -AssociatedOwnerGroup
Get-PnPGroupPermissions -Identity $group.Title

What is the version of the Cmdlet module you are running?
PnP.PowerShell version 1.3.19-nightly (same with 1.2.6-nightly)
Which operating system/environment are you running PnP PowerShell on?

[x ] Windows
[ ] Linux
[ ] MacOS
[ ] Azure Cloud Shell
[ ] Azure Functions
[ ] Other : please specify

Regarding seeing no results: there was a change in the underlying API that was not reflected in the cmdlet. We just merged a fix and it will be available in the 1.3.23 nightly release.
Regarding the fact that if you specify the title of the group you receive an error: is there something specific in the group title that might cause this? Like special characters or diacritic characters?

@erwinvanhunen , the group names are default team site group names on the site I used to reproduce the problem, but in french.
For example, the owner group is : Propriétaires de Demande n°1

Then I'm almost sure the French characters are causing the issue. I'll debug this to find out what's causing this.

@erwinvanhunen ,
I checked with a member group without any french character and it's the same :
Get-PnPGroupPermissions -Identity "Demande n°1 - Membres"

There is however still a special character in there: °
My assumption is that we do not encode certain values in the Core SDK behind the scenes correctly.

I just checked with the latest build on my machine and with the change I merged earlier groups will special characters will return the data correctly. If no permissions where set in the currently released build you would have received an exception. I changed that behavior to return nothing now. Please check tomorrow the 1.3.23-nightly build.

Ok, I'll check.
Thank you.

can confirm the very same problem with get-pnpgrouppermissions and set-PnPGrouppermissions with german umlaut characters. As long as our groups do not contain the letters: ä, ü, ö, ß - there is no issue. But one of these letters in the group name throws the excpetion.

Why is this issue being closed? Problem still exists with PnP.Powershell 1.5.0 - should I reopen a new issue?

Might potentially also be linked with issue #574

After more debugging we potentially found the issue in this case. It seems to be related to the way the Core SDK handles URLs with diacritic characters. We will forward this issue to that repo so we can take care of if there.


Scale energy sensor values by a factor of 10

Scale total and current energy sensor values by a factor of 10.
Hopefully resolve #230

This is pretty hacky and should probably be resolved in msmart-ng eventually.


Add @ngx-env/builder to the list of builders

First of all, thanks for this project. It was an inspiration and a good resource for me to build the @ngx-env/builder.
I suggest to add @ngx-env/builder 👇 to the list of builders.
Usage

Add @ngx-env to your CLI project

ng add @ngx-env/builder

Define Environment Variables in .env

NG_APP_ENABLE_ANALYTICS=false
NG_APP_VERSION=$npm_package_version
NG_APP_COMMIT=$GITHUB_SHA

Use in TS and HTML

@Component({
  selector: "app-footer",
})
export class FooterComponent {
  version = process.env.NG_APP_VERSION;
  branch = process.env.NG_APP_BRANCH_NAME;
  commit = process.env.NG_APP_COMMIT;
  analyticsFlag = process.env.NG_APP_ENABLE_ANALYTICS;
}

<!-- Same output in the spans -->
<span> {{ 'process.env.NG_APP_BRANCH_NAME' | env }} </span>
<span> {{ 'NG_APP_BRANCH_NAME' | env }} </span>
<span> {{ branch }} </span>

<!-- index.html -->
<head>
  <title>NgApp on %NG_APP_BRANCH_NAME%</title>
</head>

Run your CLI commands

npm start
NG_APP_BRANCH_NAME=$GITHUB_HEAD_REF ng test
NG_APP_BRANCH_NAME=`git branch --show-current` npm run build

Documentation

README
InDepth Article

Links

npm package
GitHub repository

And please let me know if you think about any good feature to add to the project. 💙

Thank you @chihab, can you raise a PR for the same.


Feature/remove v1 and rename

Fixes #29
Remove v1 related API and test

There is a decision for AFS SDK divided to function developing.
This project will be for models function.
I thought it is a good time to implement the new structure.
I close this PR, and start to apply #27 .


Use and display panels in rich.columns

Type of changes

[ ] Bug fix
[ ] New feature
[ ] Documentation / docstrings
[ ] Tests
[x] Other

Checklist

[x] I've run the latest black with default args on new code.
[ ] I've updated CHANGELOG.md and CONTRIBUTORS.md where appropriate.
[ ] I've added tests for new code.
[x] I accept that @willmcgugan may be pedantic in the code review.

Description
Use and display panels when run python -m rich.columns

That was a throw-away piece of code for testing columns. There's not much point in maintaining any code in main blocks unless I've mentioned it in the docs...


add react-helmet integration to update title tags for different pages

When the user navigates to a sound, the page's title should update to something like FreeSound Player - Mustang Engine. Right now it just says FreeSound Player. React helmet makes that easy to do in react. It provides a declarative API for the imperative document.title DOM API
https://github.com/nfl/react-helmet

Whoa! I didn't know the NFL had GitHub repositories.


Investigate OSC support in Extempore

https://github.com/digego/extempore

Hey!

https://github.com/digego/extempore/blob/master/src/OSC.cpp

Hrm, reading that code ... it seems that it's for integrating with other OSC services.

However, there is this!

https://extemporelang.github.io/docs/overview/using-extempore/ - "Extempore's Compiler-as-a-Service"

Connecting via OSC isn't an option.


Reopen notebook in smaller window than previously opened feels broken

Issue Type: Bug

Open a notebook do some work
Scroll all the way to the bottom cell. Then close the notebook and resize the window to be smaller
When you open the notebook again I find that you will have been scrolled so that no content is on your screen and it feels as if the notebook didn't load at all since the scroll bar disappears.

VS Code version: Code - Insiders 1.55.0-insider (b353f063393226ffc0e70f6b1afe3f362734071e, 2021-03-17T08:48:26.411Z)
OS version: Darwin x64 20.3.0

System Info

Item
Value

CPUs
Intel(R) Core(TM) i7-1068NG7 CPU @ 2.30GHz (8 x 2300)

GPU Status
2d_canvas: enabledgpu_compositing: enabledmetal: disabled_offmultiple_raster_threads: enabled_onoop_rasterization: enabledopengl: enabled_onprotected_video_decode: unavailable_offrasterization: enabledskia_renderer: disabled_off_okvideo_decode: enabledwebgl: enabledwebgl2: enabled

Load (avg)
3, 4, 4

Memory (System)
32.00GB (0.09GB free)

Process Argv
--crash-reporter-id 7170f6db-7270-442f-945e-4508c02991d4

Screen Reader
no

VM
0%

Extensions (17)

Extension
Author (truncated)
Version

vscode-track-build-errors
aes
0.0.3

vscode-eslint
dba
2.1.19

gitlens-insiders
eam
2021.3.1104

EditorConfig
Edi
0.16.4

codespaces
Git
0.8.4

vscode-pull-request-github
Git
0.24.0

rainbow-csv
mec
1.8.1

python
ms-
2021.4.661730536-dev

jupyter
ms-
2021.4.641214696

remote-containers
ms-
0.164.1

remote-ssh
ms-
0.65.1

remote-ssh-edit
ms-
0.65.1

vscode-remote-extensionpack
ms-
0.20.0

js-debug-nightly
ms-
2021.3.1617

vscode-github-issue-notebooks
ms-
0.0.72

vscode-markdown-notebook
ms-
0.0.14

debugger-for-chrome
msj
4.12.12

A/B Experiments
vsliv695:30137379
vsins829:30139715
vsliv368cf:30146710
vsreu685:30147344
python383cf:30185419
pythonvspyt602:30263608
vspor879:30202332
vspor708:30202333
vspor363:30204092
vstry244:30244315
pythonvsdeb440:30224570
pythonvsded773:30223139
pythonvspyt875:30259475
pythonvsnew554:30265444
pythontb:30258533
pythonvspyt943:30277000
vscoresta800cf:30265948
vsc_aacf:30263846
vspre833cf:30267465
vsfjg287:30275553
vshan820cf:30276953

Good point, we should never show a full viewport of whitespace to users.


respond with "no results" given non-existent card name

Fixes #93
#92 was not a suitable fix. The tests passed (erroneously) because the command for creating fixtures was missing the --location flag for following redirects.
@CBXZero, could you verify that this change works for you?

@davidchambers This change fixed the issue I was having, and after feeding a few cards through my service everything seems to be working still.

@davidchambers This change fixed the issue I was having, and after feeding a few cards through my service everything seems to be working still.

Thanks for testing this change, @CBXZero. I'll merge this pull request and publish a patch release shortly.


BUG: Issue in twitter link in footer

When clicking the twitter icon it redirects to the linked in page instead of twitter I can fix this
https://github.com/itsmohit097/medi-hub/assets/154724111/e991d73c-745e-490c-9760-170ee148d620

@itsmohit097 can u assign me this?


[ADD] CSS Resources in Tools Section

Issue Description
Add more css resources to tools sections.

I would like to work on this, please assign this issue to me


Timelion and splines

Hello,
I would need to use math function splines in timelion. How can I do? Is it supported? There is an alternative way to smooth the angles of line chart in timelion?
thank you very much for help me!!

timelion is part of core kibana. The best place for questions about kibana functionality is in the forums at https://discuss.elastic.co/c/kibana.


Updated the repo links of all meetups

Caused by https://github.com/devstaff-crete/DevStaff-Heraklion/pull/354

@sonaht thanks! It seems that this one was a really old issue. Somehow at May of 2016 2 meetups took place!


Increase text handle size to 48 by 48

Fixes https://github.com/flutter/flutter/issues/17618
Padding is only added to the "left" and "bottom" sides to bring total area to 48 by 48.  This is done prior to the rotation so it works for both RTL and LTR.

Woops, thought I submitted this


ContextMenu not open on click between grid controls

    <Grid RowDefinitions="*,Auto" Margin="10" Width="150" Height="300">
      <TextBlock Grid.Row="0" Text="First text"/>
      <TextBlock Grid.Row="1" Text="Second text"/>
      <Grid.ContextMenu>
        <ContextMenu>
          <MenuItem Header="MenuHeader"/>
        </ContextMenu>
      </Grid.ContextMenu>
    </Grid>

When click on TextBlock - menu opened
When click on free space between controls - menu not opened
Test on  0.8.1-cibuild0003134-beta

Try setting <Grid Background="Transparent" ..., I think that the Background is null by default, so hit test ignores it.

Thanks, Background="Transparent" help.
Its not intuitive, need i close issue?

That's the expected behavior

I agree it's not really intuitive, I also had that problem and had to read the source to understand what was happening. But I also think it makes sense not to hit test visuals with Background == null. Maybe leave this open to add that to the docs?

That's the expected behavior

But when its ListBox and this Grid selected as item (has visual selection), but context menu clicked sometimes -- look very bad.

This is the same behavior that WPF and UWP have too, as far as I know.

Test WPF - work fine in all grid (blue border) area:

This seems to be that although the TextBlock is filling the first grid row, the hit-test area is limited to the area that actually contains text. In WPF, the hit-test area is the whole of the TextBlock.
We should change our behavior to match that of WPF's.

This seems to be because WPF's TextBlock overrides HitTestCore: https://github.com/dotnet/wpf/blob/b71b8b339ce667d6e49ff08aea3bc8d148a1c851/src/Microsoft.DotNet.Wpf/src/PresentationFramework/System/Windows/Controls/TextBlock.cs#L1717-L1733
We don't have an equivalent mechanism for overriding hit-testing at the moment I don't think. In the meantime you could just set your TextBlock's background to Transparent and it should work.

@grokys thanks.
Because Background =" Transparent " helps, I close the issue.


Setting new kubeconfig file don't change available contexts list

Describe the bug
When setting up new kubeconfig file in configuration contexts list don't change.

In this file there is only one context
Desktop (please complete the following information):

OS: iOS
Version 1.9.1

It is fixed on version 1.10.0, Now we are getting new release @exu


feat(schema4): update WMG pipeline to exclude non-tissue "tissue_type" cells from the generated cubes

Data portal will be dropping (organoid) or (cell culture) from the names of cell culture and organoid tissues with schema 4. We'll instead need to use a new field tissue_type. In addition to making this change to the WMG pipeline, we'll also need to see if there's any additional downstream dependencies that need to be updated.
Slack context thread

@atarashansky not urgent--does WMG already do this? As in, is this ticket a new feature for 4.0.0 or translating an old feature to use the updated tissue_type field?

@nayib-jose-gloria WMG doesn't already do this. This would be a new feature that I believe has been requested as early as August of this year, but the schema 4 tissue_type field makes it a bit easier to implement.