server.connector is not parsed

Hi all,
I'm trying to deploy an app on Heroku using Dropwizard and Gradle. Below is my yaml file:
server:
  type: simple
  connector:
    type: http
    port: 8080
database:
  # the name of your JDBC driver
  driverClass: org.postgresql.Driver
  # the username
  user: process.env.JDBC_DATABASE_USERNAME
  # the password
  password: process.env.JDBC_DATABASE_PASSWORD
  # the JDBC URL
  url: process.env.JDBC_DATABASE_URL
  # any properties specific to your JDBC driver:
  properties:
    charSet: UTF-8
  # the SQL query to run when validating a connection's liveness
  validationQuery: "/* Test Database Health Check */ SELECT 1"
  # the minimum number of connections to keep open
  minSize: 8
  # the maximum number of connections to keep open
  maxSize: 32
  # whether or not idle connections should be validated
  checkConnectionWhileIdle: false
  # how long a connection must be held before it can be validated
  evictionInterval: 10s
  # the maximum lifetime of an idle connection
  minIdleTime: 1 minute
logging:
  level: INFO

Here's the procfile that would invoke this:
web: java $JAVA_OPTS -Ddw.server.connector.type=http -Ddw.server.connector.port=$PORT -Ddw.database.user=$JDBC_DATABASE_USERNAME -Ddw.database.password=$JDBC_DATABASE_PASSWORD -Ddw.database.url=$JDBC_DATABASE_URL -jar build/libs/project-1.0.jar server config.yaml

Unfortunately the files cause this error when trying to deploy the app:
2016-08-22T02:50:46.914027+00:00 app[web.1]:   * Unrecognized field at: server.connector
2016-08-22T02:50:46.914033+00:00 app[web.1]:
2016-08-22T02:50:47.011379+00:00 heroku[web.1]: Process exited with status 1
2016-08-22T02:50:47.024697+00:00 heroku[web.1]: State changed from starting to crashed

Is there anything I should change in the yaml file, or the procfile? Thank you in advance for your help

Hello @BethyDiakabananas!
Please, check that your YAML configuration file specifies a server with the simple type. A server with the default type has 2 types of connectors: applicationConnectors and adminConnectors, so the Jackson databinder in that case will throw an error for connectors as an unrecognized field. The file you provided looks correct, so make sure the configuration file on a Heroku machine is the same.
Another possible option is that for a some reason the last command line argument is stripped, and a process is launched as project-1.0.jar server with the default properties.

@BethyDiakabananas, #I'm optimistically assuming the non-response means this problem is solved, so I'm closing the issue. Feel free to respond with more info if the problem persists.


“Use Default Excludes” Checkbox

The reason for this changes is to address a edge case where we needed to include a ".gitignore" files as part of the deployment.
The core logic change is to call to the alternate DirScanner.Glob method setting and passing the useDefaultExcludes parameter.  Additionally logic in the DataConstructor was added to set the default behavior to useDefaultExcludes = true for backwards compatibility.
To the UI, a "Use Default Excludes” checkbox was added allowing operators to control the the behavior.  One anomaly exists with the new checkbox, that is for exist jobs created with previous version, the checkbox will not default to true (checked) even though it is initialized to true by the DataConstructor.
For the list of files patterns to exclude see https://ant.apache.org/manual/dirtasks.html#defaultexcludes

Hi!
Thanks for the contribution.
Did you perform any testing as part of the changes? If so it'd be helpful to include that in the PR.
Are you OK with submitting this contribution under the Apache License 2.0?


feat(MPM-384): Option to parse schema before exporting

There was still the issue with namespaces when embedded schema uses embedded schema, namespaces that are the same were not removed so I added additional Avro::parse() before exporting schema to a file.
I used the same option that was added before, maybe naming is not appropriate anymore, @nick-zh what do you think?

@bajdzun thx i will look into it as well, to see how we can best solve this. I was thinking about some improvements yesterday evening myself, but i need to do some more elaborate testing. I am on the road and busy today, so i will have to get back to you this evening, latest tomorrow morning :v:
Things i have in my mind:

validating the end Avro with Avro::parse,  same as you did (not sure yet though what lib should do the namespace replacing)
from what i understand from your statement, Avro::parse will remove same namespaces, so i assume this is a spec and the lib currently does not adhere to it (meaning we should probably fix that properly as default behaviour and release as major)
check what happens with namespaces that are in a different "space"
need to check what other changes we have after Avro::parse for different usecases (maybe i missed something else)

So i quickly checked in the the spec and found this: https://avro.apache.org/docs/current/spec.html#names
References to previously defined names are as in the latter two cases above: if they contain a dot they are a fullname, if they do not contain a dot, the namespace is the namespace of the enclosing definition.

So even though they do not state that it must be like this, i think it is safe to assume that this should be the convention:

same namespace of embedded type will be ignored

My proposal would be:

this lib correctly uses namespaces according to spec (they were mostly added for the merging anyway to avoid naming conflicts)
this lib uses Avro:parse to validate that the result is the same (if that is possible and there are not other deviation that make this complicated), but uses its own result

What do you think, any additional thoughts @healerz? I am glad to propose a PR as well that you can verify, lmk :v:

So i quickly checked in the the spec and found this: https://avro.apache.org/docs/current/spec.html#names
References to previously defined names are as in the latter two cases above: if they contain a dot they are a fullname, if they do not contain a dot, the namespace is the namespace of the enclosing definition.

So even though they do not state that it must be like this, i think it is safe to assume that this should be the convention:

same namespace of embedded type when same, shall be omitted

That's right, I did some testing with flix-tech/avro-php library and they follow that convention, if namespaces are the same, they ignore them, if they are different, they don't remove them

Changes have been implemented as discussed in (#14). Thanks a lot again @bajdzun for the help and the collaboration :pray:


Audi Q6 preheater missing

Describe the bug
from time to time, the reported data from the car is not shown, all have unknown state.
But I really miss the option to start the preheater. If possible, it would also be
home-assistant_audiconnect_2024-11-22T15-13-25.287Z.log
helpful to know is there is a service or update needed.
To Reproduce
Steps to reproduce the behavior:
It is just not there nothing need to be done
Expected behavior
at least, I would be happy if I could switch on the preheater. Nice would be to have the same option as in the app.
setting the Mode Comfort or Economy. and if I would like to switch on the seat heating for all 4 seats.
Screenshots
If applicable, add screenshots to help explain your problem.
Logfile
attached
Your Vehicle Details
Model: Audi Q6 e-tron
Year: 2024
Type (Electric):
Region (EU/US/CA/CN): DE
home-assistant_audiconnect_2024-11-22T15-13-25.287Z.log

If you mean the climatisation you can try this in your yaml file.. It works for my Q4 2024.
The following is line 548 to 574. This is the fix from issue #450
I was lucky enough to download the beta that was cancelled again because it could break the climatisation for other models.
    async def set_climatisation(self, vin: str, start: bool):         if start:             data = '{ "targetTemperature": 23, "targetTemperatureUnit": "celsius", "climatisationWithoutExternalPower": true, "climatizationAtUnlock": false, "windowHeatingEnabled": true, "zoneFrontLeftEnabled": false, "zoneFrontRightEnabled": false, "zoneRearLeftEnabled": false,  "zoneRearRightEnabled": false }'             headers = { "Authorization": "Bearer " + self._bearer_token_json["access_token"] }             res = await self._api.request(                 "POST",                 "https://emea.bff.cariad.digital/vehicle/v1/vehicles/{vin}/climatisation/start".format(                     vin=vin.upper(),                 ),                 headers=headers,                 data=data,             )          else:             data = ''             headers = { "Authorization": "Bearer " + self._bearer_token_json["access_token"] }             res = await self._api.request(                 "POST",                 "https://emea.bff.cariad.digital/vehicle/v1/vehicles/{vin}/climatisation/stop".format(                     vin=vin.upper(),                 ),                 headers=headers,                 data=data,             )
After that you can start climatisation via:
tap_action:
action: perform-action
perform_action: audiconnect.execute_vehicle_action
data:
vin: XXXXXXYOUR-VIN-HEREXXXXX
action: start_climatisation
And stop:
hold_action:
action: perform-action
perform_action: audiconnect.execute_vehicle_action
data:
vin: XXXXXXYOUR-VIN-HEREXXXXX
action: stop_climatisation
You will have to change the yaml to change the settings for the climatisation though.
Setting zoneFrontLeftEnabled/zoneFrontRightEnabled/zoneRearLeftEnabled/zoneRearRightEnabled to true enables the seat heating.
is also set the "climatizationAtUnlock" to true so it heats when i unlock it.
And also "climatisationWithoutExternalPower" to true so it also heats up without the car plugged in.
Still a big thanks to pergolafabio for sharing this code, it already helped me out a lot these colder days :)


Add support for Gradle

The Elasticsearch people started with https://github.com/elastic/forbidden-apis-gradle-plugin.
I think this should be included directly into the forbidden-apis tool. Basically this is more or less the Maven tool, just implemented as Gradle's DefaultTask extension. This can be implemented in pure Java, this is what I would prefer.
As usual all would be packaged in the same JAR file because there are no conflicts between the tools.

I added a new branch: https://github.com/policeman-tools/forbidden-apis/compare/issue68

Looking good, thank you!
Could you possibly make the plugin work with all sourceSets? This would allow eg. adding a new testInteg which is also checked?

Hi @rjernst,
The problem with all sourcesets is that Gradle has no "process-classes" like Maven. To ensure that it starts, you need some task where you can add it as dependency. For unknown sourcesets this does not work (no defined)
In that case you would need to configure the task on your own, which should work with plain gradle/groovy. The class is there, you just have to define 2 things: classesDir + classpath.
By the way, the current version that was committed to the branch works correct now. I have several Gradle projects from the examples shipped with gradle extended by this plugin, works.
Are there any plans to switch Elasticsearch builds to Gradle?

This is an example (modify Gradle's samples/java/quickstart example):
apply plugin: 'java'

buildscript {
  repositories {
    mavenLocal()
  }
  dependencies {
    classpath 'de.thetaphi:forbiddenapis:1.9-SNAPSHOT'
  }
}

apply plugin: 'de.thetaphi.forbiddenapis'

sourceCompatibility = 1.5
version = '1.0'
jar {
    manifest {
        attributes 'Implementation-Title': 'Gradle Quickstart',
                   'Implementation-Version': version
    }
}

repositories {
    mavenCentral()
}

dependencies {
    compile group: 'commons-collections', name: 'commons-collections', version: '3.2'
    testCompile group: 'junit', name: 'junit', version: '4.+'
}

test {
    systemProperties 'property': 'value'
}

forbiddenApis {
  signatures = ['java.lang.String']
  bundledSignatures = ['jdk-unsafe','jdk-deprecated']
  failOnViolation = false
}

testForbiddenApis {
  signatures = ['org.gradle.Person']
  bundledSignatures = ['jdk-unsafe','jdk-deprecated']
  failOnViolation = false
}

uploadArchives {
    repositories {
       flatDir {
           dirs 'repos'
       }
    }
}

I changed the task dependencies in the branch a bit (after sleeping about it):
the new forbidden tasks are now dependencies of the "classes" and "testClasses" generic tasks. This is similar to Maven. So every task that requires class files gets the checked ones. Our tasks only depend on java compilation tasks.
I am currently investigating why the forbidden-checks run all the time although there are no changes. I tried to add outpus == inputs, but this did not help.

I refactored the task now, so inputs/outputs work correctly. The issue was that annotation don't work correctly on fields without getters. I also changed the task to be PatternFilterable, so it now behaves similar to other tasks taking input files,

Why not just install the tasks and let he user decide what should depend on them? It is really simple for the user to eg add it to check:
check.dependsOn forbiddenApis, testForbiddenApis

In my particular case, I want to add a precommit task, and have forbidden apis as part of that, and precommit be part of check. This would allow eg forbidding System.out.println, but still be able to run the tests directly when debugging with print outs. But a full build or check call would still do the forbidden checks. I realize you could do this through setting a system property to the failOnViolation, but why restrict the user to a single way of using the api, instead of allowing them to easily customize how they want to use it?

Hi,
I did it the way how it is at the moment mostly because the current Maven plugin's MOJO is also located in the phase called "process-classes".
My proposal would be: As many people already complained about that (or changed the defaults in ther Maven config to use the "validate" phase), I would do the following:

release the Gradle plugin as forbiddenapis 2.0 (instead 1.9)
change the Maven plugin to use the validate phase by default
In the Gradle plugin let "check" (is same as "validate" phase in Maven) depend on forbidden-apis. This brings more convention as Gradle proposes and its ran by default. To disable the automatic assignement, we could add a parameter to the plugin initialization, so you can disable this. But for new users we really should "automatically" configure dependency tree correctly (just later phase).
Maybe add the usafe signatures as default for Maven and Gradle (not sure about this). This would help for new users, too (you can just enable the plugin and it will work asap).

What do you think?

FYI: PMD says in https://docs.gradle.org/current/userguide/pmd_plugin.html: "The plugin adds a number of tasks to the project that perform the quality checks. You can execute the checks by running gradle check."

Hmm... Maven's validate is executed before classes are compiled, Uwe -- this means you'd be verifying last run's output. Does it make sense?

Maybe I mixed up the name. I mean the phase after test.

You mean 'verify'. I personally think the way it was bound (process-classes) makes a lot of sense -- an early warning signal rather than delayed check.

I personally think the way it was bound (process-classes) makes a lot of sense

Most projects I have seen changed this to verify. Also Elasticsearch did it very late for long time.

Well, if "majority is right" is the argument then sure... :) Note that 'verify' is executed after packaging to you can build the package with invalid method calls. To me this is a no-no.
But people can change the binding anyway if they like, so up to you.

But "install" or "deploy" requires to run "verify"... So you cannot publish in Maven Central without that passing (yes you can copy the JAR files away from target/ folder...).
In any case, a later stage also helps Gradle. If you bind it as dependency for "check", it is easy for anybody to just add another dependency. Removing the current dependency on "classes"/"testClasses" is almost impossible in "clean & nice groovy code".

@uschindler The groovy plan sounds good to me.

Yes, but if you're using maven and wish to stay sane you wouldn't install to a local repo, even for deployment (you'd redirect the repo to a temp. dir).
Anyway, it's just a different opinion, I don't care either way.

Could you possibly make the plugin work with all sourceSets?

Now I can maybe do this. When the plugin installs itsself it would register a task for every sourceSet, for "main" and "test" it would depend on the corresponding compile tasks, but not for others.

@uschindler In terms of @rjernst's request, you can depend on the SourceSet's SourceSetOutput from the tasks. A SourceSetOutput is a Buildable, which can be depended upon. I chose not to do it because I was focused on making the plugin work properly with inputs/outputs and the phases, but it was the planned next step once we had another source set to test against.
I tried to setup the dependencies so that it would short circuit a build if the Forbidden APIs were used (by making jar depend on forbiddenApis and test depend on testForbiddenApis to prevent it from getting far with forbidden usage). I don't think there's much hope for that dynamically discovered ones, but I like the idea of making them all depend upon check. You can also have the task marked with @ParallelizableTask so that parallel execution can run them together.

You can also have the task marked with @ParallelizableTask so that parallel execution can run them together

Without upgrading to Java 1.6 this is impossible (because I have to compile against Gradle 1.x if I want to stay on 1.5 for the plugin). See my comment above. For 2.0 I would drop Java 5.

In terms of @rjernst's request, you can depend on the SourceSet's SourceSetOutput from the tasks

Thats already in the process of changing - I noticed that, too :-)

@uschindler Is there any reason to maintain support for even Java 6? I chose to support Java 7 as a minimum because I know a lot of people still use it, but Java 6 has not been supported for years. I'm certainly only referring to 2.0 of the plugin.

No need for Java 7, so I stay with Java 6. You cannot use NIO.2 anyways because thats incompatible with any build tool outside.

I started to refactor plugin initialization. Don't ask why I did it that way, but that simplifies things enormous...

Another small suggestion: set the group on the created tasks to Verification. This will have it show up when running gradle tasks with the other check tasks like test.

Or maybe it doesn't matter. I was concerned it would show up in the "Other" category when running gradle tasks. But I think since it is a dependency of check it won't show up at all. So nevermind! I think I like that behavior better: no need to see details unless you want to (with gradle tasks --all).

I implemented now the task for all source sets. This now works using same logic like the other check tasks (PMD, CheckStyle).
// initializes the plugin and binds it to the lifecycle

import org.gradle.api.plugins.PluginInstantiationException;
import org.gradle.api.tasks.TaskContainer;

if (!project.plugins.findPlugin("java")) {
  throw new PluginInstantiationException("Forbiddenapis only works in projects using the 'java' plugin.");
}

def tasks = project.getTasks();
def checkTask = tasks.getByName("check");

// Define our tasks (one for each SourceSet):
def forbiddenTasks = project.sourceSets.collect { sourceSet ->
  tasks.create(sourceSet.getTaskName(FORBIDDEN_APIS_TASK_NAME_PREFIX, null), CheckForbiddenApis.class) { task ->
    task.classesDir = sourceSet.output.classesDir;
    task.classpath = sourceSet.compileClasspath;
    task.description = "Runs forbiddenApis checks on '" + sourceSet.name + "' classes.";
    // task.group = checkTask.group;
    task.dependsOn(sourceSet.output);
  }
}

// Add our tasks as dependencies to chain
checkTask.dependsOn(forbiddenTasks);

I commented out the task's group for now. Adding it would make it show up next to "check".
The output now is:
Verification tasks
------------------
check - Runs all checks. [forbiddenApisMain, forbiddenApisTest, test]
forbiddenApisMain - Runs forbiddenApis checks on 'main' classes. [classes]
forbiddenApisTest - Runs forbiddenApis checks on 'test' classes. [classes, testClasses]
test - Runs the unit tests. [classes, testClasses]

Please note, the task name changed a bit, the new one is automatically generated from the SourceSet method.

I did some testing already:
With the current code it is perfectly possible to declare own sourceSets, but you have to do this before loading the Plugin:
apply plugin: 'java'

sourceSets {
    dummy {
        java {
            compileClasspath = main.compileClasspath
            runtimeClasspath = main.runtimeClasspath
        }
    }
}

buildscript {
  repositories {
    mavenLocal()
  }
  dependencies {
    classpath 'de.thetaphi:forbiddenapis:1.9-SNAPSHOT'
  }
}

apply plugin: 'de.thetaphi.forbiddenapis'

If you load the plugin before, it would not create the tasks, because the sourceSets are not there at time of plugin loading. I chcked this: It behaves exactly the same for Checkstyle and PMD and all other check plugins (they all chare the same superclass).
The only thing that is missing currently is a ForbiddenApisExtension that can be used to define defaults. This extension looks like a task ("forbiddenApis") in the DSL, but its settings are just copied over into the task implementations. So you can define the bundledSignatures.
Without the extension, the above build script would fail, because you also have to add the task settings for the new (automatically defined) "forbiddenApisDummy" task.
I will look into this, it works with a mechanism called "ConventionMappings".

I implemented extension:
forbiddenApis {
  signatures = ['java.lang.String']
  bundledSignatures = ['jdk-unsafe','jdk-deprecated','jdk-system-out']
  ignoreFailures = true
}

forbiddenApisTest {
  signatures += 'org.gradle.Person'
}

The forbiddenApis closure refers to the extension and defines all defaults. The tasks inherit those. In the test task, you see that it is possible to add further signatures using standard groovy syntax (adding stuff to lists).

I also tested recently that the plugin also works if you have a groovy-only project. If you setup a Groovy project and one of your source code files (implemented in Groovy) uses forbidden apis (after compilation with Groovyc) it also fails :-)
:forbiddenApisMain
Forbidden class/interface use: java.io.File
  in Test (Test.groovy:4)

I added a pull request as all main features are working now: #70


Rancher compose restart results in a panic: runtime error for a non-existant service

**Rancher Version:**V1.1.0-dev1
OS and where are the hosts located? (cloud, bare metal, etc): : ubuntu:14.04.2, Cloud
Environment Type: (Cattle/Kubernetes/Swarm/Mesos): Cattle
**Steps to Reproduce: **

Set up rancher-compose environment
Issue a restart command
./rancher-compose -f dc1.yml -r test1.yml -p stack1 restart

Note: dc1.yml file contains service test3 although it was not created (does not exist in the set-up ):
test2:
  image: ubuntu:14.04.2
  stdin_open: true
test3:
  image: sangeetha/testnewhostrouting
  stdin_open: true

test1.yml contains:
test2:
  scale: 3
test3:
  scale: 2

===============================================
Results:
The restart functionality works correctly. All the containers of test2 stop and start again.
But there is a panic: runtime error as follows:
soumyas-MacBook-Pro:rancher-compose-v0.8.0 soumya$ ./rancher-compose -f dc1.yml -r test1.yml -p stack1 restart
INFO[0000] Project [stack1]: Restarting project
INFO[0000] [0/2] [test3]: Restarting
INFO[0000] [0/2] [test2]: Restarting
panic: runtime error: invalid memory address or nil pointer dereference
[signal 0xb code=0x1 addr=0x0 pc=0x1c1aed]
goroutine 50 [running]:
panic(0x6b5f60, 0xc82000e0b0)
/usr/local/go/src/runtime/panic.go:464 +0x3e6
github.com/rancher/rancher-compose/vendor/github.com/rancher/go-rancher/client.(*ServiceClient).ActionRestart(0xc82002d5e0, 0x0, 0xc8203058f0, 0x0, 0x0, 0x0)
/go/src/github.com/rancher/rancher-compose/vendor/github.com/rancher/go-rancher/client/generated_service.go:240 +0x11d
github.com/rancher/rancher-compose/rancher.(*RancherService).Restart(0xc8203b4cc0, 0x0, 0x0)
/go/src/github.com/rancher/rancher-compose/rancher/service.go:508 +0x12b
github.com/rancher/rancher-compose/vendor/github.com/docker/libcompose/project.(*Project).Restart.func1.1(0xe09118, 0xc8203b4cc0, 0x0, 0x0)
/go/src/github.com/rancher/rancher-compose/vendor/github.com/docker/libcompose/project/project.go:209 +0x36
github.com/rancher/rancher-compose/vendor/github.com/docker/libcompose/project.(*serviceWrapper).Do(0xc82032c380, 0xc82034aa50, 0xd, 0xe, 0x92ae00)
/go/src/github.com/rancher/rancher-compose/vendor/github.com/docker/libcompose/project/service-wrapper.go:100 +0x202
github.com/rancher/rancher-compose/vendor/github.com/docker/libcompose/project.(*Project).Restart.func1(0xc82032c380, 0xc82034aa50)
/go/src/github.com/rancher/rancher-compose/vendor/github.com/docker/libcompose/project/project.go:210 +0x49
created by github.com/rancher/rancher-compose/vendor/github.com/docker/libcompose/project.(*Project).startService
/go/src/github.com/rancher/rancher-compose/vendor/github.com/docker/libcompose/project/project.go:373 +0x5a8

@joshwget can you look at this issue?

@alena1108 Yeah, no problem!

Verified with v0.9.3-rc1 that there is no panic.
INFO[0000] [0/2] [test3]: Restarting
INFO[0000] [0/2] [test2]: Restarting
ERRO[0000] Failed Restarting test3 : Failed to find test3 to restart
ERRO[0000] Failed to start: test3 : Failed to find test3 to restart
INFO[0014] [0/2] [test2]: Restarted
Failed to find test3 to restart


Error doing job: Task exception was never retrieved (None)

Hi,
I have those two errors showing every time I try to update one room. The integrations read correctly the info from the A/C when home assistant start, but then I can't modify, and it's a pity because it was working very well. I tried to reconfigured it setting the timeout to 15 seconds instead of 5 as it was before, but nothing has changed.
those are the errors:
Logger: homeassistant
Source: custom_components/koolnova_bms/sensor.py:149
integration: Koolnova BMS Modbus RS485 (documentation, issues)
First occurred: 10:50:23 PM (1 occurrences)
Last logged: 10:50:23 PM
Error doing job: Task exception was never retrieved (None)
Traceback (most recent call last):
File "/usr/src/homeassistant/homeassistant/helpers/update_coordinator.py", line 258, in _handle_refresh_interval
await self._async_refresh(log_failures=True, scheduled=True)
File "/usr/src/homeassistant/homeassistant/helpers/update_coordinator.py", line 453, in _async_refresh
self.async_update_listeners()
File "/usr/src/homeassistant/homeassistant/helpers/update_coordinator.py", line 168, in async_update_listeners
update_callback()
File "/config/custom_components/koolnova_bms/sensor.py", line 149, in _handle_coordinator_update
for _cur_engine in self.coordinator.data['engines']:
~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^
TypeError: 'NoneType' object is not subscriptable
Second:
Logger: custom_components.koolnova_bms.coordinator
Source: helpers/update_coordinator.py:354
integration: Koolnova BMS Modbus RS485 (documentation, issues)
First occurred: 10:50:23 PM (3 occurrences)
Last logged: 10:51:23 PM
Unexpected error fetching koolnova_bms data
Traceback (most recent call last):
File "/usr/src/homeassistant/homeassistant/helpers/update_coordinator.py", line 354, in _async_refresh
self.data = await self._async_update_data()
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/src/homeassistant/homeassistant/helpers/update_coordinator.py", line 271, in _async_update_data
return await self.update_method()
^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/config/custom_components/koolnova_bms/koolnova/device.py", line 408, in async_update_all_areas
self._areas[_idx].order_temp = v['order_temp']
^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/config/custom_components/koolnova_bms/koolnova/device.py", line 126, in order_temp
raise OrderTempError('Order temp value must be between {} and {}'.format(const.MIN_TEMP_ORDER, const.MAX_TEMP_ORDER))
custom_components.koolnova_bms.koolnova.device.OrderTempError: Order temp value must be between 15.0 and 35.0
Thanks in advance

Hi, thanks for your prompt reply. The integration was working fine, but
since I use it mostly in summer, I don't know since when it's not working.
The only thing I modify is the rooms names.
I've done the modification suggested, this is the error:
Log details (ERROR)
This error originated from a custom integration.
Logger: custom_components.koolnova_bms.coordinator
Source: helpers/update_coordinator.py:382
integration: Koolnova BMS Modbus RS485 (documentation
https://github.com/sinseman44/koolnova-BMS-Integration, issues
https://github.com/sinseman44/koolnova-BMS-Integration/issues)
First occurred: 12:44:53 PM (9 occurrences)
Last logged: 12:48:53 PM
Unexpected error fetching koolnova_bms data
Traceback (most recent call last):
File "/usr/src/homeassistant/homeassistant/helpers/update_coordinator.py",
line 382, in _async_refresh
self.data = await self._async_update_data()
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/src/homeassistant/homeassistant/helpers/update_coordinator.py",
line 279, in _async_update_data
return await self.update_method()
^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/config/custom_components/koolnova_bms/koolnova/device.py",
line 408, in async_update_all_areas
self._areas[_idx].order_temp = v['order_temp']
^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/config/custom_components/koolnova_bms/koolnova/device.py",
line 126, in order_temp
raise OrderTempError('Order temp value ({}) must be between {} and
{}'.format(val, const.MIN_TEMP_ORDER, const.MAX_TEMP_ORDER))
custom_components.koolnova_bms.koolnova.device.OrderTempError: Order
temp value (0.0) must be between 15.0 and 35.0
I see that there is one room at 0 degree.So there is probably an issue
on my koolnova System. This evening I will perform a reset and I will
let you know.
Il giorno lun 11 nov 2024 alle ore 09:28 sinseman44 <
@.***> ha scritto:

Hi @Lk1975 https://github.com/Lk1975,
I have those two errors showing every time I try to update one room. The
integrations read correctly the info from the A/C when home assistant
start, but then I can't modify, and it's a pity because it was working very
well.
It's stange ! It was working and now you have this errors ? what's change ?
Traceback (most recent call last):
File "/usr/src/homeassistant/homeassistant/helpers/update_coordinator.py",
line 258, in _handle_refresh_interval
await self._async_refresh(log_failures=True, scheduled=True)
File "/usr/src/homeassistant/homeassistant/helpers/update_coordinator.py",
line 453, in _async_refresh
self.async_update_listeners()
File "/usr/src/homeassistant/homeassistant/helpers/update_coordinator.py",
line 168, in async_update_listeners
update_callback()
File "/config/custom_components/koolnova_bms/sensor.py", line 149, in
_handle_coordinator_update
for _cur_engine in self.coordinator.data['engines']:
For the first error, the integration can't retreive informations
(callback) from Koolnova to update Engine throughput value. This
integration have a coordinator to update all read values each 30 seconds.
It's mean that It call the function device.async_update_all_areas each 30
seconds => see the second error !
Traceback (most recent call last):
File "/usr/src/homeassistant/homeassistant/helpers/update_coordinator.py",
line 354, in _async_refresh
self.data = await self._async_update_data()
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/src/homeassistant/homeassistant/helpers/update_coordinator.py",
line 271, in _async_update_data
return await self.update_method()
^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/config/custom_components/koolnova_bms/koolnova/device.py", line
408, in async_update_all_areas
self._areas[_idx].order_temp = v['order_temp']
File "/config/custom_components/koolnova_bms/koolnova/device.py", line
126, in order_temp
raise OrderTempError('Order temp value must be between {} and
{}'.format(const.MIN_TEMP_ORDER, const.MAX_TEMP_ORDER))
custom_components.koolnova_bms.koolnova.device.OrderTempError: Order temp
value must be between 15.0 and 35.0
In this second error, when the async_update_all_areas function is called,
the integration can't update the "order temp value" because it's not in the
range 15°C and 35°C. Why ? Do you try to update an area order temperature ?
which value ?
in the file custom_components/koolnova_bms/koolnova/device.py, line 126,
can you modify this:
raise OrderTempError('Order temp value must be between {} and {}'.format(const.MIN_TEMP_ORDER, const.MAX_TEMP_ORDER))
by this:
raise OrderTempError('Order temp value ({}) must be between {} and {}'.format(val, const.MIN_TEMP_ORDER, const.MAX_TEMP_ORDER))
and restart your Home Assistant. Normally, we should find the same error
but with the temperature value sent by the Koolnova controller, via mobus
registers.
—
Reply to this email directly, view it on GitHub
https://github.com/sinseman44/koolnova-BMS-Integration/issues/12#issuecomment-2467521899,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/BCTQICGPOJVG4GP46CMEY6D2ABTBFAVCNFSM6AAAAABRQT3GRWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINRXGUZDCOBZHE
.
You are receiving this because you were mentioned.Message ID:
@.***>

Hi,
I found the issue, very easy. One of my wired thermostat was not properly fitted in, so it was reading zero degrees from that room, that was causing the errors. Once I’ve reinstalled it correctly and rebooted home assistant everything started to work again.
Maybe you could add an exception to consider this kind of issue. If one thermostat is removed all the system is down.
thanks

Il giorno 11 nov 2024, alle ore 14:46, Luca Scotti @.***> ha scritto:
Hi, thanks for your prompt reply. The integration was working fine, but since I use it mostly in summer, I don't know since when it's not working.
The only thing I modify is the rooms names.
I've done the modification suggested, this is the error:
Log details (ERROR)
This error originated from a custom integration.
Logger: custom_components.koolnova_bms.coordinator
Source: helpers/update_coordinator.py:382
integration: Koolnova BMS Modbus RS485 (documentation https://github.com/sinseman44/koolnova-BMS-Integration, issues https://github.com/sinseman44/koolnova-BMS-Integration/issues)
First occurred: 12:44:53 PM (9 occurrences)
Last logged: 12:48:53 PM
Unexpected error fetching koolnova_bms data
Traceback (most recent call last):
File "/usr/src/homeassistant/homeassistant/helpers/update_coordinator.py", line 382, in _async_refresh
self.data = await self._async_update_data()
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/src/homeassistant/homeassistant/helpers/update_coordinator.py", line 279, in _async_update_data
return await self.update_method()
^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/config/custom_components/koolnova_bms/koolnova/device.py", line 408, in async_update_all_areas
self._areas[_idx].order_temp = v['order_temp']
^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/config/custom_components/koolnova_bms/koolnova/device.py", line 126, in order_temp
raise OrderTempError('Order temp value ({}) must be between {} and {}'.format(val, const.MIN_TEMP_ORDER, const.MAX_TEMP_ORDER))
custom_components.koolnova_bms.koolnova.device.OrderTempError: Order temp value (0.0) must be between 15.0 and 35.0
I see that there is one room at 0 degree.So there is probably an issue on my koolnova System. This evening I will perform a reset and I will let you know.
Il giorno lun 11 nov 2024 alle ore 09:28 sinseman44 @.*** @.***>> ha scritto:

Hi @Lk1975 https://github.com/Lk1975,
I have those two errors showing every time I try to update one room. The integrations read correctly the info from the A/C when home assistant start, but then I can't modify, and it's a pity because it was working very well.
It's stange ! It was working and now you have this errors ? what's change ?
Traceback (most recent call last):
File "/usr/src/homeassistant/homeassistant/helpers/update_coordinator.py", line 258, in _handle_refresh_interval
await self._async_refresh(log_failures=True, scheduled=True)
File "/usr/src/homeassistant/homeassistant/helpers/update_coordinator.py", line 453, in _async_refresh
self.async_update_listeners()
File "/usr/src/homeassistant/homeassistant/helpers/update_coordinator.py", line 168, in async_update_listeners
update_callback()
File "/config/custom_components/koolnova_bms/sensor.py", line 149, in _handle_coordinator_update
for _cur_engine in self.coordinator.data['engines']:
For the first error, the integration can't retreive informations (callback) from Koolnova to update Engine throughput value. This integration have a coordinator to update all read values each 30 seconds. It's mean that It call the function device.async_update_all_areas each 30 seconds => see the second error !
Traceback (most recent call last):
File "/usr/src/homeassistant/homeassistant/helpers/update_coordinator.py", line 354, in _async_refresh
self.data = await self._async_update_data()
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/src/homeassistant/homeassistant/helpers/update_coordinator.py", line 271, in _async_update_data
return await self.update_method()
^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/config/custom_components/koolnova_bms/koolnova/device.py", line 408, in async_update_all_areas
self._areas[_idx].order_temp = v['order_temp']
File "/config/custom_components/koolnova_bms/koolnova/device.py", line 126, in order_temp
raise OrderTempError('Order temp value must be between {} and {}'.format(const.MIN_TEMP_ORDER, const.MAX_TEMP_ORDER))
custom_components.koolnova_bms.koolnova.device.OrderTempError: Order temp value must be between 15.0 and 35.0
In this second error, when the async_update_all_areas function is called, the integration can't update the "order temp value" because it's not in the range 15°C and 35°C. Why ? Do you try to update an area order temperature ? which value ?
in the file custom_components/koolnova_bms/koolnova/device.py, line 126, can you modify this:
raise OrderTempError('Order temp value must be between {} and {}'.format(const.MIN_TEMP_ORDER, const.MAX_TEMP_ORDER))
by this:
raise OrderTempError('Order temp value ({}) must be between {} and {}'.format(val, const.MIN_TEMP_ORDER, const.MAX_TEMP_ORDER))
and restart your Home Assistant. Normally, we should find the same error but with the temperature value sent by the Koolnova controller, via mobus registers.
—
Reply to this email directly, view it on GitHub https://github.com/sinseman44/koolnova-BMS-Integration/issues/12#issuecomment-2467521899, or unsubscribe https://github.com/notifications/unsubscribe-auth/BCTQICGPOJVG4GP46CMEY6D2ABTBFAVCNFSM6AAAAABRQT3GRWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINRXGUZDCOBZHE.
You are receiving this because you were mentioned.


Blog/Topic suggestion page

Description:
Implement a dedicated page where users can submit blog post ideas or topic suggestions. This feature will allow our community to actively participate in shaping the content direction and ensuring that we're addressing topics that are of interest to our audience.
Proposed features:

Suggestion form: A simple form that allows users to submit their ideas, including:

Title or topic idea
Brief description or outline
Any relevant links or references

Public feedback: A mechanism for community members to upvote or downvote suggestions, providing valuable feedback on their popularity and potential impact.

Benefits:

Community engagement: Encourages user participation and fosters a sense of ownership.
Content relevance: Ensures that we're producing content that aligns with the interests of our audience.
Idea generation: Provides a platform for fresh and innovative ideas.

Considerations:

User experience: The suggestion form should be easy to use and intuitive.
Moderation Wworkflow: Establish clear guidelines for moderating suggestions and provide timely feedback to users.

There are sites that sell this kind of services. We can look at those for some inspiration or even for integrate that kind of services.
Example: https://canny.io
We could look for an open source alternative

F2Z converse could be used for this? .. but also Github Issues? but also zPages ... I'm not sure we need another model? Maybe converse can be adapted for this or use tags/categories in zpages?

#115

F2Z converse could be used for this?
Yeah1, could be, and we save time. As you said we could just only adapt convers, making kind of a tag like "Post suggestion". And also let users know they can now suggest blog topics trough converse. Shouldn't be difficult

Converse comments currently have tags but we don't reveal them on the frontend.


python311Packages.fakeredis: 2.17.0 -> 2.18.0

Diff: https://github.com/dsoftwareinc/fakeredis-py/compare/refs/tags/v2.17.0...v2.18.0
Changelog: https://github.com/cunla/fakeredis-py/releases/tag/v2.18.0
Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 249302 run on x86_64-linux 1

12 packages built:

baserow
baserow.dist
python310Packages.celery-redbeat
python310Packages.celery-redbeat.dist
python310Packages.fakeredis
python310Packages.fakeredis.dist
python310Packages.fastapi-mail
python310Packages.fastapi-mail.dist
python311Packages.fakeredis
python311Packages.fakeredis.dist
python311Packages.fastapi-mail
python311Packages.fastapi-mail.dist

Result of nixpkgs-review pr 249302 run on x86_64-linux 1

12 packages built:

baserow
baserow.dist
python310Packages.celery-redbeat
python310Packages.celery-redbeat.dist
python310Packages.fakeredis
python310Packages.fakeredis.dist
python310Packages.fastapi-mail
python310Packages.fastapi-mail.dist
python311Packages.fakeredis
python311Packages.fakeredis.dist
python311Packages.fastapi-mail
python311Packages.fastapi-mail.dist


Hfss.export_results() docstring

Before submitting the issue

[X] I have searched among the existing issues
[X] I am using a Python virtual environment

Description of the bug
export_results() is inherited from Analysis and the docstring for many input paramters is difficult to understand and not applicable to HFSS.

length: The meaning of this paramter is not clear from the documentation nor for HFSS users.

Steps To Reproduce
This is a documentation issue.
Which Operating System are you using?
Windows
Which Python version are you using?
3.7
Installed packages
Not related to usage or execution.

Documentation has been improved to mention applicability of the method for Q3D, Q2D, etc.

@dcrawforAtAnsys Did you improve the documentation? I don't see any modification regarding the applicability of the parameter 'length' for Q2D designs.

@Samuelopez-ansys : It looks like the docstring was updated by @maxcapodi78 on 08-March-23.


[DNM] Test travis

I guess this complements https://github.com/JuulLabs-OSS/mynewt-travis-ci/pull/92. Please rebase this PR on latest master.

@kasjer Those commits regarding DA1469x VBUS should be a PR on their own, no?

@utzig Yes, I'm just trying out this fix on changes that are failing. Once it completes I will prepare this PR to be merged.


README.md wrong install code

go get https://github.com/Xamber/Varis

This code get error package https:/github.com/Xamber/Varis: "https://" not allowed in import path, please remove https://

@ahme-t thank you for help. Fixed.


Adaptation for static linking

Hereby I am asking for the code review first (while doing the git rebase in between).

Hi Miro. Generally I think that you submit the PRs way too early. But I understand why.
The earlier the better for you since you get feedback earlier before all that coding.
The later the better for me since the product is more converged.
Difficult balance but in general please let the code first ripe on your fork
for few days/weeks to debug the corner cases. You don't need the code to immediately
enter the central repo thanks to distributed version control. You can develop multiple
features at the same time without the features entering immediately the central repo.
What is the central repo anyway in Git?
Comments:

Shouldn't the LINKING_STUFF (please use a better name) be taken care of inside math_libs.cmake? Then it would be more transparent.
Please describe what all the packages that we apt-get install in .travis.yml are for. New developers 5 years from now have to be able to understand why all those packages are installed. I don't know what all those packages are for.

Hi Rado,
when my code is working on branch, and I foresee no substantial changes in the future, why waiting ? Both fresh and ripe codes will undergo review anyhow, and I don't believe that an 'old' code will have less referee comments than a 'fresh' one, as is this one.
Answer to comments:
i) I renamed LINKING_STUFF to MATH_LIBS_EXT in corresponding CMakeFiles.txt files.
I am against putting the LINKING_STUFF -> MATH_LIBS_EXT variable into math_libs.cmake as for static linking it differs from compiler to compiler, from library to library (and even from version to version). Let the MATH_LIBS variable provides the very core for static linking, and remaining adaptations for various cases of static linking are to be done on user's side. Such is my experience with combination of Intel, PGI, GNU compilers / MKL,ATLAS, SYSTEM_NATIVE math libraries.
Even I was shaking with "holy awe" before modifying math_libs.cmake for static linking. Yes, I modified this file, in the minimalist and IMHO sufficient way.
ii) Packages added to .travis-ci.yml are aimed to ensure proper static linking on CI testing servers. Especially the fc_lapack static linking is non-trivial. After experimenting (how many commits were shot for that !) I had to resort to the static ATLAS library, and had switch linking order to "lapack-blas" in math_libs.cmake. One important case : only the binutils-gold package is able to ensure proper static linking on Linux (fortunately it exists on travis-ci Linux server(s), on my clusters I had to install it manually).
With all these proposed changes for autocmake I am heading to the new static autocmake-DIRAC software to be used for multinode grid computing. I am sure the "autocmaked" DIRAC is better starting point in comparison to what I had before.

Hi Miro, just one thing about the waiting: You typically implement something that you need and you use. It is normal and typical that you discover bugs while using the new feature. It would be extremely atypical to code something that is just ready and bugfree and does not require refactoring or small or large changes. Therefore it is good to wait with the PR and use the code that you have written for some time before submitting it for a PR.

Fine, I am going to perform all-combinations tests on this new feature and will display results in tabular form.

Hi Miro, you don't have to do it for me. I don't need any "executive summary". I just recommend
that you use the feature that you have implemented for few days before filing a PR (unless
it is a trivial change).

The test CMake sources should IMO be "thin". If all the static lib adaptations are in the test sources
but not in CMake modules that we tests, then I am not sure what we test in them. So either it can be done in a portable way and then it needs to be in a module or it cannot be done and then I think we should not even attempt it.

Currently what is working is static linking  combination of  gfortran+ATLAS/SYSTEM_NATIVE/MKL, ifort+ATLAS/SYSTEM_NATIVE/MKL,  pgf90+ATLAS/SYSTEM_NATIVE.
The wanted (as prerequisite for static-DIRAC-for-grid) combination of **pgf90+MKL+static ** is not working due to this error:
ilias@login.grid.umb.sk:~/Work/qch/software/software_projects/autocmake_devel/autocmake_miroi/test/fc_blas/build_static_pgf90_mkl/.m
Linking Fortran executable ../bin/example
IPA: no IPA optimizations for 1 source files
/mnt/apps/intel/composer_xe_2013_sp1.1.106/mkl/lib/intel64/libmkl_core.a(mkl_aa_fw_load_orsl_lite_lib.o): In function `mkl_aa_fw_load_orsl_lite_lib':
../../../../serv/offload/framework/core/mkl_aa_fw_load_orsl_lite_lib.c:(.text+0xbe): warning: Using 'dlopen' in statically linked applications requires at runtime the shared libraries from the glibc version used for linking
/usr/lib64/libpthread.a(libpthread.o): In function `sem_open':
(.text+0x774d): warning: the use of `mktemp' is dangerous, better use `mkstemp'
/usr/bin/ld: dynamic STT_GNU_IFUNC symbol `strcmp' with pointer equality in `/usr/lib64/libc.a(strcmp.o)' can not be used when making an executable; recompile with -fPIE and relink with -pie
child process exit status 1: /usr/bin/ld
make[2]: *** [bin/example] Error 2
make[1]: *** [src/CMakeFiles/example.dir/all] Error 2
make: *** [all] Error 2
milias@login.grid.umb.sk:~/Work/qch/software/software_projects/autocmake_devel/autocmake_miroi/test/fc_blas/build_static_pgf90_mkl/.

I made quite heavy adaptation of the test's src/CMakeFiles.txt files . Maybe there is a space for moving some local cmake commands into the common  static_linking.cmake module. But first I would like to fix pgf90+mkl+static , later trying to make static tests thin.
Comments, please ?

Whatever works is fine. If this helps you achieving your goal then it is a good route.
Later you can refactor.

Hi,
finally I got PGI+MKL+static working !. I strived to keep minimum changes into modules/math_libs.cmake, so that the complexity of various compilers/libraries/linking options remains at user's src/CMakeFiles.txt side. There is no other way, IMHO.
All 9 combination of static linking (pgf90,ifort,gfortran/ATLAS,SYSTEM_NATIVE,MKL) is working (my "execution summary" on Linux cluster)!
I am missing the ACML library (3 more possibilities to check, maybe 6 with the ilp64 mode, or in total 12 when testing both dynamic and static linking) and the OpenBLAS library (another bunch of combinations for testing...). Also one should test it with IBM XL/ESSL, SYSTEM_NATIVE .... damn, another testing options...
So I am asking for this PR as I have serious plans with the static autocmake-DIRAC. The Slovak (empty) Grid environment is waiting.

Sorry my changes force you to rebase and resolve but the conflicts should be trivial.

Rebased.Any other changes?

Hi Miro, this is very important work. Thank you for that. The only thing that I don't like about
this change is that the tests carry all the workarounds and not the modules. This means that the tests
pass but if a user wants to use the module for static-linking it will then not work and one would need
to reintroduce the workarounds every time. Isn't there a way to hide those away in a module?
The test sources should ideally be free of hacks and workarounds otherwise there is IMO no point
for these tests. The tests now test themselves and not the modules.

Fine,then Iet us wait,more iterations of this PR are to be done.I hope a lot of "hacks" will go to the mathlibs.cmake.

Comments please ?

I think this is good. We want the test sources to be thin. The reason is that we want users to be able
to plug CMake functionality with writing minimum CMake code on their side.

Really good ? And concerning https://github.com/scisoft/autocmake/pull/54#discussion_r36615453 ?

Green tests; merge ?

Thanks Miro!
I am not 100% happy that we so heavily modify link flags that come from CMake
but perhaps we have to live with it for a while. Perhaps there is no other way.
I hope there is but we can explore it with the code in.
Why is the [explicit] block needed in fc_blas test?

fixed and rebased

Hi Miro, can you please try one more thing:?
Currently we "brutally" erase all link flags with
set(CMAKE_SHARED_LIBRARY_LINK_Fortran_FLAGS)

Can you please try whether this works also:
list(REMOVE_ITEM CMAKE_SHARED_LIBRARY_LINK_Fortran_FLAGS "offending-flag")

This would be more gentle and more explicit.

Hi,
works.
In general, for cases as this one I would prefer an automatic CDash testing. PGI/Intel/GNU/mathlibs/int64/static libs give too many combinations alltogether. We can not rely only on CI tests with free compilers and libs. Other projects, candidates for utilizing Autocmake, would  prefer the best compilers/libraries at hand, and these are usually commercial.

Thanks Miro. I have nothing against automated CDash testing in addition to the Travis/Appveyor CI.
But my ambition is to work towards a portable compiler-independent Autocmake which
can be tested by Travis/Appveyor.


Collaborating on a FastAI port?

Hi @lorenzoh,
A group of us interested/working with DL in Julia have been trying to get a community initiative off the ground for creating a fast.ai (v2) equivalent in the Flux ecosystem. The initial plan is to port the tutorials in the fastai v2 book so that folks new to the community are able to get up-and-running quickly. This would also help to identify bugs and pain points in Flux to pass on to the core team.
Given how a) actually usable and b) close to the fast.ai Python API FluxTraining and co. are, I was wondering if this package wouldn't be a great foundation for such an initiative! I'll also note that we've connected with and received support from the Flux core team, so this may also be an opportunity to influence some development upstream :)
If you're interested, most of the discussion is happening in
https://julialang.zulipchat.com/#narrow/stream/237432-ml-ecosystem-coordination. We also have a general list of ideas for general areas of improvement in Julia ML/DL at https://github.com/JuliaCommunity/ML-Coordination-Tracker.
Thanks for your work on these packages as well! I've been trying out DataLoaders.jl with great success so far.

For posterity, we've started work at https://github.com/FluxML/FastAI.jl!

Hey @ToucheSir,
unfortunately I didn't see your earlier post.
I'd be really interested in collaborating! Let's connect on Zulip and have a chat


tests: write integration tests for creating pacts

Please add tsconfig to tests folder and remove rootDir option from tsconfig in root directory to remove type check error:
TS6059: File 'C:/Users/hpawefaj/IdeaProjects/pact-gen-ts/tests/int/mocks/mockPactsConfigForTestCase.ts' is not under 'rootDir' 'C:/Users/hpawefaj/IdeaProjects/pact-gen-ts/src'. 'rootDir' is expected to contain all source files.


keep the selected item of dropdown menu as the dropdown "title"

nah, looks better with the logo pinned up top


Uptime-Kuma

Setup monitoring via Uptime-Kuma.
Probably best as a standalone container outside of the cluster.
persistent storage mapped to TrueNAS nfs mount point.

She's up. See /img


(4.4.dev2) Inspecting an exported typed dictionary while editing a script grabs the focus away from the script editor

Tested versions
4.4.dev2
System information
Windows 11 - Godot 4.4.dev2 - Vulkan(Forward+)
Issue description
If you have typed dictionary open in the inspector (so you can edit the values), it will grab the focus away from script editor everytime it has done checking for errors.
Here's a video I am experiencing
Steps to reproduce

Create a script with export variable that is any kind of typed dictionary.
Attach it to a node and click the node so you can see the exported typed dictionary.
In inspector, open the dictionary so the keys and values are shown in the inspector.
Edit script in the script editor in any way and wait for the script editor to check for errors.
The typed dictionary's "New Value" should grab the focus away from the script editor.
This is very noticeable if you change the "text_editor/completion/idle_parse_delay" in EditorSettings to a very low value.

Minimal reproduction project (MRP)
dictionary_issue.zip

Haven't confirmed but should be caused by this code:
https://github.com/godotengine/godot/blob/83d54ab2ad476ae265b323c2b88f4623b922f4c6/editor/editor_properties_array_dict.cpp#L1178-L1183
But can't see how it is affected specifically by typed dictionaries, but confirmed that non-typed dictionaries won't trigger this

@AThousandShips The problem is in grab_focus itself. It is always called as there are unsaved changes, regardless if the dictionary is typed or not. It has a mechanism that early returns if the focusable is empty to avoid grabbing focus. This of course only happens when the dictionary has no type.
void EditorProperty::grab_focus(int p_focusable) {
	if (focusables.is_empty()) {
		return;
	}

	if (p_focusable >= 0) {
		ERR_FAIL_INDEX(p_focusable, focusables.size());
		focusables[p_focusable]->grab_focus();
	} else {
		focusables[0]->grab_focus();
	}
}

Do you mind if I try fixing it?

I was about to open an issue but I've seen this one.
Also happens when saving the script containing the exposed variable, and when saving the whole project as well.
https://github.com/user-attachments/assets/1bbfe41b-db9a-44ec-b02d-ae1ab2d25625
I don't know whether the proposed fix solves this issue.


[FEATURE] A circle progress bar

Description of the requested feature
I try make it by myself, just with css and xml, but no luck. While looking if someone tried the same, I found a repo of the implementation with GTK in vala.
Proposed configuration syntax
May use
 <progress circle="true" />

Additional context

Repo of phastmike

Oooo, that is a nice example

working on this woo

Will be closed by #328 (read: elkowar please link lol)

Was indeed implemented by #328!


BC Ukrainian Content: Welcome to B.C-Personal Safety (Missing text)

This text seems missing in the Ukrainian content.

That section is missing in the Ukrainian pdf of the newcomers guide


[utfcpp] Update to 3.2.1 version

https://github.com/nemtrif/utfcpp/releases/tag/v3.2.1

Utfcpp was providing GTest as a submodule, and the patch used the vcpkg port instead to build the library. Since the 3.2 version, the author switched from GTest to his own unit test framework, rendering this patch obsolete : https://github.com/nemtrif/utfcpp/commit/fe79d14ae764e0da411078927b1c60ea9271e408

Utfcpp was providing GTest as a submodule, and the patch used the vcpkg port instead to build the library. Since the 3.2 version, the author switched from GTest to his own unit test framework, rendering this patch obsolete : nemtrif/utfcpp@fe79d14

Thanks for your clarification

Cool, thanks @RT222 :)


Expose Endpoint Info timeout parameter

Signed-off-by: Ben Ye<EMAIL_ADDRESS>

[x] I added CHANGELOG entry for this change.
[ ] Change is not relevant to the end user.

Changes
Fixes https://github.com/thanos-io/thanos/issues/5450

Expose info timeout param so that users can configure it based on their use case use.
For our use case, we have Thanos Query at cloud control plane and Thanos Sidecars at edge across the world (like Asia, Africa, etc). Due to the physical location distance and network issues, 5 seconds timeout is not sufficient for all cases.
Verification

Good to know we have WIP work on that. If that's the case yeah definitely better than adding this new flag separately.


Invalid code when names have spaces

When game object in hierarchy have names like "Some Button" generated code template has
[code]
Button Some Button {get; set;}
[/code]
which causes compliation errors. Simple that comes to mind is to a trim and replace whitespaces with "_" in the names before generating identifiers. Could provide a PR over the weenekend

Oh, you're right.
When variable names are created, they now replace all but the _ symbol with a space.
Try updating Packages/packages-lock.json by changing the relevant part to b4fd64ec4c9e018e68c80a256916ef974c84f6b3

Just tested the fix and now generated the code is ok but it seems it does not actually replace spaces with "_" but just removes them meaning "Some Button" in hierarchy becomes "SomeButton" in the generated template.

I was torn between deleting the space or changing it to an underbar, but I prepared a version that would change it to an underbar.
f7ad62eea88fa11a9c794b8a5042c37b48e24299
I would have liked to be able to choose the option, but it's an auxiliary feature, so that's good.

Fine for me either was as long as the generated code is fine :)

OK, this change will go into v1.1.0.
(If you are using PackageManager, you can use origin/master and it has already been applied.)


pulsar: binary not found

Describe the bug
[davidak@gaming:~]$ nix run nixpkgs#pulsar
error: unable to execute '/nix/store/apvf9nj79kvvh6j23qzlawxhzlxwjhc2-Pulsar-1.103.0/bin/Pulsar': No such file or directory

Steps To Reproduce
Steps to reproduce the behavior:

...
...
...

Expected behavior
just run it
Additional context
Change the package name to lowercase to match the binary.
This is also required by policy:

The pname and the version attribute must not contain uppercase letters — e.g., "mplayer" instead of“MPlayer”`.

https://nixos.org/manual/nixpkgs/stable/#sec-package-naming
Notify maintainers
@colamaroro
Metadata

system: "x86_64-linux"
host os: Linux 6.2.8, NixOS, 22.11 (Raccoon), 22.11.3408.a575c243c23
multi-user?: yes
sandbox: yes
version: nix-env (Nix) 2.11.1
channels(root): "home-manager-22.11.tar.gz, nixos-22.11, nixos-hardware, nixos-unstable"
nixpkgs: /nix/var/nix/profiles/per-user/root/channels/nixos

Could you try nix run github:nixos/nixpkgs/unstable#pulsar ?
As far as I can see, Pulsar hasn't been backported to 22.11

Ah, nice catch. I will make a small PR to fix the issue.
(I'll take the opportunity to clean up a bit more the update script)

Could you try nix run github:nixos/nixpkgs/unstable#pulsar ?

Same issue since the command uses unstable by default i think.
[davidak@gaming:~]$ nix run github:nixos/nixpkgs/nixos-unstable#pulsar
error: unable to execute '/nix/store/apvf9nj79kvvh6j23qzlawxhzlxwjhc2-Pulsar-1.103.0/bin/Pulsar': No such file or directory

Just a quick heads up, I've not forgotten this issue, I'm waiting for the 1.104 release, which is probably going to happen on the 15th :slightly_smiling_face:


Inaccurate description of LSO completion

Before a miniport driver completes the send of a large TCP packet that it has segmented into smaller packets by using LSO, the driver writes the number of TCP payload bytes that it sent in the segmented packets in the TcpPayload member of NDIS_TCP_LARGE_SEND_OFFLOAD_NET_BUFFER_LIST_INFO.

This is relevant to LSOv1 only.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 813a24f1-06fd-85ee-a6cd-74566bac6cad
Version Independent ID: 3b7c30bc-ec0f-0160-9010-d3a8b29fea05
Content: Accessing TCP/IP Offload NET_BUFFER_LIST Information
Content Source: windows-driver-docs-pr/network/accessing-tcp-ip-offload-net-buffer-list-information.md
Product: windows-hardware
GitHub Login: @tedhudek
Microsoft Alias: windowsdriverdev

Hi @I-gor-C, looks like you're correct. The actual NDIS_TCP_LARGE_SEND_OFFLOAD_NET_BUFFER_LIST_INFO page backs this up, too. Thanks for finding this! I'll make the change, and the updates should be live later today.


Investigate support of Commenting/Discussions for individual resources

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is.
Describe the solution you'd like

We would like to enable scientists to view from Fusion when a discussion is ongoing about a specific KG entity.
It should be possible for a scientist to start a new discussion.
evaluate integration with JIRA/GitLab to benefit from their equivalent features. JIRA likely preferable since scientists are already using it and it has an API.

Questions to be addressed:

Single ticket or multiple tickets ?
Data model to link entity to it's discussion
UI mockups (plugin?)
Need for a Delta plugin ?
Authentication (same token as Nexus ?)
if JIRA: which project do we create a ticket into

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.

Hey team! Please add your planning poker estimate with ZenHub @bogdanromanx @imsdu @nicwells @dhaneshnm @smitfire

Duplicate of #3025


Breaking change: Remove dependencies on external gems

v0.9.3 introduced two new features that required reliance on external
libraries. Installing these libraries through our Traveling
Ruby-packaged executable has introduced issues for users. Some users
reported permissions issues related to now-deprecated Bundler behavior
that is still in use on the version of Bundler used by Traveling Ruby
(Ruby 2.2.2 is still locked to Bundler 1.9.x).
After spending considerable time attempting to work through packaging
problems I now think that the potential benefits from these dependencies
are not worth the trouble. We can accomplish most of the needed
functionality without help from external gems.
This commit makes the following changes to Parity:

BREAKING CHANGE Remove the dotenv gem and stop loading ERB. We
were previously using dotenv and erb to allow users to define
their database name in development dynamically in a database.yml.erb
file that included environment variables. This configuration is an
edge case that doesn't warrant adding non-trivial complexity to
accommodate.
Remove the git gem. This gem parsed Git remotes, allowing parity to
determine the application name and pass the confirmation argument for
applications named differently than the local development directory.
This functionality has been retained by leveraging Heroku CLI's info
command to get the application name.
Remove packaging changes previously made to convey gems along with
parity for Traveling Ruby packaging.

While I suspect I may have been the only user to make use of environment
variables to specify the name of the development database, these changes
will require a major version update as they break backwards
compatibility.
Fix #91, #93, #96.

Great simplification and commit message! Agreed on the major bump. LGTM


test: Cypress - Helpers update

Added helper method:

to validate tooltip text
to assert if the class name contains "disabled"
dragNDrop to public
to search and open an application

/ok-to-test

/ok-to-test


Upgrade to Jena 5.1.0

One minor code change around use of deprecated APIs
Dependency exclusion to fix bug apache/jena#2593

Seems to be one other Jena API change that hasn't been accounted for, needs further work before ready for review


Upgraded service still has service links in "active" state.

Rancher Server - Build from master
Rancher compose version - V0.2.2
Steps to reproduce the problem:
Have a service S1 with scale 4 which links to another service - S2.
Upgrade service S1 to S3.
After upgrade is successful, all instances of service S1 is deleted. But the service link to S2 is still in "active" state. Should this service link be removed as part of upgrade process?

This is as designed.  We should leave S1 alone in case they need to rollback.  The user can manually remove this or we can support some flag in the future to automatically delete the service.


@conda-forge-admin, please update circle

Issue:
cirlceci ran prior to the r-swfscmisc dependency being available via conda-forge

Hi! This is the friendly automated conda-forge-webservice.
I just wanted to let you know that I updated the circle-ci deploy key and followed the project.


add a badge for known vulnerabilities

Disclaimer: I am a snyk employee.
Disclaimer: I am a user of this repository.
Seeing all these badges on the top of the readme, I find I'd also like to know the latest version is free of known vulnerabilities, which is what this badge is all about.

Hi @aviadatsnyk thanks for the suggestion! Our badges are a fixed set, as specified in https://github.com/expressjs/express/blob/master/Readme-Guide.md#top-level-items to make our READMEs uniform. We can certainly consider adding a new badge, but would need to discuss this first, so opening a PR is probably premature. I would suggest opening an issue in https://github.com/expressjs/discussions/issues to bring up the discussion.
The main evaluation points we have used for badges in the past are the following:

Does the badge inform the user of something important?
Is the badge only updated with a direct response to a contributor action (i.e. pushing to the repo)?
If the badge changes on it's own, does the underlying service provide a minimum of 24 hours notice prior to altering the badge state such that the contributors can take action?

Hi @dougwilson - thank you for the great comment.
I'll take it to discussions.

moved to https://github.com/expressjs/discussions/issues/57


Changes made!

I think yours looks good. Make sure to review and comment on Nishchith's pull request so you can get full credit. After y'all have done that for each other, you can merge your own commit to main.
Just a side note, do you know why you had a 3rd file added, .DS_Store? I don't think it will hurt anything, I am curious about what it is.

Christian I'm confused! Do i need to approve Nishchith's request by removing the conflict (those yellow part alone) or what do i need to do?

I think yours looks good. Make sure to review and comment on Nishchith's pull request so you can get full credit. After y'all have done that for each other, you can merge your own commit to main.
Just a side note, do you know why you had a 3rd file added, .DS_Store? I don't think it will hurt anything, I am curious about what it is.
Christian I'm confused! Do i need to approve Nishchith's request by removing the conflict (those yellow part alone) or what do i need to do?

Merged!


Corrections: allow to ignore dead pixels with an empty repair environment

In some cases, the list of invalid pixels fed into correct can only be determined automatically. For example, if each frame needs to be corrected independently with different invalid pixels, and we have many frames, the invalid pixels need to be determined by some heuristic. In case the parameters for the heuristic were chose poorly, they may not transfer well to a stack of detector frames, and select too many pixels. This may be quite user-unfriendly, for example if the user is doing an expensive calculation on a large dataset and the last frame happens to have wildly different content (for example if there is junk at the end of the acquisition)
Here, it may make sense to remove any pixels from the correction list that have an empty environment.
@uellue what do you think? Could this be an alternative to throwing a hard error? Could we instead log some warnings about how many empty environments were removed? Maybe make this configurable?

Fixed by #890 - CorrectionSet has an allow_empty parameter now.


Add SignalR resource

API change check
APIView has identified API level changes in this PR and created following API reviews.
Azure.Provisioning


Remove placehold.it from design patterns CSP

fixed in
https://github.com/textpattern/server-config/commit/31e08f0dafc0a77a4fbf284c8b197f7281e817aa


[Bug] Progressive loading and comlink proxy issue

Seems like we have some issue with comlink and proxy in htj2k in some settings
The following fix it apparently
addRequest(request, streamingData = {}) {
        const { imageId, stage } = request;
        const baseOptions = this.listener.getLoaderImageOptions(imageId);
        if (!baseOptions) {
            return;
        }
        const { retrieveType = 'default' } = stage;
        const { retrieveOptions: keyedRetrieveOptions } = this;
        let retrieveOptions = keyedRetrieveOptions[retrieveType] || keyedRetrieveOptions.default;
        if (retrieveOptions) {
            retrieveOptions = JSON.parse(JSON.stringify(retrieveOptions));
        }
        const options = {
            ...baseOptions,
            retrieveType,
            retrieveOptions,
            streamingData,
        };
        const priority = stage.priority ?? -5;
        const requestType = stage.requestType || RequestType.Interaction;
        const additionalDetails = { imageId };
        imageLoadPoolManager.addRequest(this.sendRequest.bind(this, request, options), requestType, additionalDetails, priority);
    }

The issue stems from using a RenderingEngine object that resides within a Vue reactive object, in this case a ref() that was being used to track state. This was causing the retrieveOptions object passed to the ProgressiveRetrieveImagesInstance class to be a Proxy object, which is not serializable. This would then be passed to the image decode worker, throwing an error.
You could JSON.parse(JSON.stringify()) the options object to account for this, but in my case it is probably better to not store the RenderingEngine object in a reactive object and pass that object through the app using other means.
Explaining this all here in case someone else runs into a similar issue later.
For searchability, the error looks like this:
DataCloneError: Failed to execute 'postMessage' on 'Worker': #<Object> could not be cloned.


Make it possible to copy the Godot version identifier by clicking it

I managed to sort out the alignment issues mentioned in https://github.com/godotengine/godot/issues/24317#issuecomment-576074059. The appearance is now almost identical to the original, except that version identifiers are now clickable in the Project Manager, the editor's bottom panel and About dialog. All three buttons will copy the same text (full version identifier with hash for Git builds).
This closes #24317.

I looked at the code and it looks ok, but it would be useful to have the PR rebased, so it can be tested.

Thanks!


Synthesis refactor

This (draft, currently) PR is the refactor of Synthesis, Metamer, and MADCompetition, to make them simpler and easier to understand. It's currently unfinished, with MADCompetition not working and the notebooks not updated, but Metamer should be stable and its associated tests should work.
This PR involves:

stripping out a lot of the unnecessary code from Metamer and MADCompetition to make them easier to understand, and reducing their attributes.
Synthesis has been reduced to a very small class, with only the things we think it shares across methods. That's just save, load, and to, plus requiring an implementation of synthesis.
adds SimpleMetamer, a very straight-forward metamer method to demonstrate the basics of synthesis (without the bells and whistles that Metamer has for coarse-to-fine and storing progress to allow for animating) with an associated notebook testing-new-synthesis. That notebook should either be reworked (if we think it's useful to have around) or deleted by merge.
The display code has all been moved into plenoptic/synthesize/metamer.py as individual functions (not methods) that take a Metamer object as their first instance, which cleans up its namespace greatly.

Codecov Report

Merging #136 (c4a55ad) into main (720b10c) will decrease coverage by 48.09%.
The diff coverage is 10.56%.

@@             Coverage Diff             @@
##             main     #136       +/-   ##
===========================================
- Coverage   78.39%   30.29%   -48.10%
===========================================
  Files          33       33
  Lines        2971     2812      -159
  Branches      593      560       -33
===========================================
- Hits         2329      852     -1477
- Misses        465     1901     +1436
+ Partials      177       59      -118

Impacted Files
Coverage Δ

plenoptic/synthesize/synthesis.py
16.66% <ø> (-58.34%)
:arrow_down:

plenoptic/tools/__init__.py
100.00% <ø> (ø)

plenoptic/tools/display.py
7.74% <5.55%> (-62.18%)
:arrow_down:

plenoptic/synthesize/metamer.py
9.13% <8.20%> (-78.87%)
:arrow_down:

plenoptic/synthesize/simple_metamer.py
26.19% <26.19%> (ø)

plenoptic/tools/optim.py
42.10% <40.00%> (-45.00%)
:arrow_down:

plenoptic/synthesize/__init__.py
100.00% <100.00%> (ø)

plenoptic/synthesize/mad_competition.py
9.76% <100.00%> (-76.55%)
:arrow_down:

plenoptic/tools/straightness.py
11.11% <0.00%> (-82.23%)
:arrow_down:

plenoptic/synthesize/eigendistortion.py
17.33% <0.00%> (-77.34%)
:arrow_down:

... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 720b10c...c4a55ad. Read the comment docs.


Display missing pathway information about reactions

Complete once https://github.com/KarrLab/datanator_rest_api/issues/33 is finished.

This appears to be almost done except the reaction pages often don't display pathways. E.g., http://localhost:3000/reaction/D-Glucose 1-phosphate-->D-Glucose 6-phosphate/Colibacter doesn't play any pathways although KEGG shows 4 pathways https://www.genome.jp/dbget-bin/www_bget?ec:<IP_ADDRESS>.

This appears to be almost done except the reaction pages often don't display pathways. E.g., http://localhost:3000/reaction/D-Glucose 1-phosphate-->D-Glucose 6-phosphate/Colibacter doesn't play any pathways although KEGG shows 4 pathways https://www.genome.jp/dbget-bin/www_bget?ec:<IP_ADDRESS>.

This is from my end. I was filling in kegg_meta fields for all the documents in sabio_rk collection but the operation timed out half way through. I started the second half of the filling operation. The problem should resolve itself once that is done.

See #209  for further comments.

Some reactions still don't display pathways e.g., http://localhost:3000/reaction/D-Glucose 1-phosphate-->D-Glucose 6-phosphate/Colibacter. @lzy7071 should the pathway information be returned by the RES API now?

Some reactions still don't display pathways e.g., http://localhost:3000/reaction/D-Glucose 1-phosphate-->D-Glucose 6-phosphate/Colibacter. @lzy7071 should the pathway information be returned by the RES API now?

Looking into it now.

Some reactions still don't display pathways e.g., http://localhost:3000/reaction/D-Glucose 1-phosphate-->D-Glucose 6-phosphate/Colibacter. @lzy7071 should the pathway information be returned by the RES API now?

Looking into it now.

Instead of relying on kegg_meta in documents, it will now look up kegg ortholog information directly from kegg_orthologg collection in MongoDB. The link should have pathway information withinkegg_meta object once the latest API is deployed.

This seems to be fixed.


Scale up in manual optimiaztion mode fails if there is zero vms already running

https://github.com/dice-cyfronet/atmosphere/blob/master/app/providers/atmosphere/optimization_strategy/manual.rb#L41
fails.

If there is no vms already running invoke the new_vms_tmpls_and_flavors_and_tenants method.


[EventHubs]: Adding appropriate identifiers to array properties

ARM API Information (Control Plane)
MSFT employees can try out our new experience at OpenAPI Hub  - one location for using our validation tools and finding your workflow.

Azure 1st Party Service can try out the Shift Left experience to initiate API design review from ADO code repo.  If you are interested, may request engineering support by filling in with the form https://aka.ms/ShiftLeftSupportForm.
Changelog
Add a changelog entry for this PR by answering the following questions:

What's the purpose of the update?

[ ] new service onboarding
[ ] new API version
[ ] update existing version for new feature
[ ] update existing version to fix swagger quality issue in s360
[ ] Other, please clarify

When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
By default, Azure SDKs of all languages (.NET/Python/Java/JavaScript for both management-plane SDK and data-plane SDK, Go for management-plane SDK only ) MUST be refreshed with/after swagger of new version is published. If you prefer NOT to refresh any specific SDK language upon swagger updates in the current PR, please leave details with justification here.

Contribution checklist (MS Employees Only):

[ ] I commit to follow the Breaking Change Policy of "no breaking changes"
[ ] I have reviewed the documentation for the workflow.
[ ] Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist

Applicability: :warning:
If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

Change to data plane APIs
Adding new properties
All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

[ ] Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review.  Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.

Adding a new service
Adding new API(s)
Adding a new API version
-[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki.

[ ] Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

[ ] If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist
If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.
NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)
Please follow the link to find more details on PR review process.

Hi @damodaravadhani could you fix the failed checks?
Please refer to this comment and the details on those pipelines for guidance.

@ArcturusZhang, according to https://github.com/Azure/autorest/tree/main/docs/extensions#x-ms-identifiers, we have provided for an identifier in format "/properties/subnet/id". But LintDiff says this is invalid, can you help figure out what might be wrong with this format ? Thanks in advance.

@ArcturusZhang , any help here would be appreciated ? Thanks !


prefixed the vars, added resizefs, since first post PXE task is alway…

…s resize the PXE created LVs and FS.
Feel free to test with infra_testpr. There's a snapshot ready for reverting-to (name of snap is self documenting).

I've opened #12 which can be tested alongside this. Overall there should be no change since these are either variable renames, rearrangements of tasks, or variable changes which should not have an effect on existing systems.

@manics: okay with the last changes?


Added odometer-digit-added event

I needed a way to set the odometer's width in order to smoothly animate it when the number of digits increased/decreased, so I ended up adding an odometer-digit-added event which is triggered every time a digit is inserted to the DOM.
You can check the JSFiddle I created in order to showcase the end result (I included the compiled JS result code in the commit only to be able to use it from the JSFiddle as an external resource).
There might probably be a better way to handle this, but I don't know the source code well enough to determine that.

I try many times to Connect  with my digital odometer But it just not working.


font changed and comments added

I added the custom font to the project and added some comments for future fixes

I like the new font style. It's great work you did.


no font error

when i use sh scripts/gen_synth.sh
i got an error "RuntimeError: There is no font: .//resources/100fonts" what should i do?

You could download fonts from google fonts and put them in this folder; we provided a list of fonts we used in this file synthgenerator/resources/100fonts/chosen_fonts.json


Read API for Package

I think this already partly implemented but wanted to check through all items:
/api/package/{publisher}/{name}

GET returns roughly the contents of the DB package table shorn of anything "private" (not sure we have anything at the moment):
id
name
publisher
readme
descriptor
...

QUESTION: should we use graphql approach - cf #63

@rgrp Can I have more clarifications on (for tests):

shorn of anything "private"

What does this mean?

@zelima private stuff would be something like an email address on a user. Often for the API we just taking a database object and turning it into json. When you do that you would want to check you are not pushing any private. With the Package object as it is at the moment I don't think we need to worry.

@rgrp Great, we don't revile anything private for now. Closing


Add GetProtocolStateSnapshotByBlockID and GetProtocolStateSnapshotByHeight endpoints

Add GetProtocolStateSnapshotByBlockID and GetProtocolStateSnapshotByHeight to the SDK that were implemented for Access API.
Related issue: https://github.com/onflow/flow-go-sdk/issues/749

Closed as part of #141


spring1 ticket2

Phabricator:
Notes

Test Steps

Screenshots/Videos

This PR also contains the solution for Spring 2 ticket 1 = Page Issues ticket (border and icon)


Add capability for users to include their own custom CSS overrides.

This should address #33, though in a somewhat different way than pitched there.
(and this time I did it in its own branch :)

Omg. I am so sorry that I let this be stale. Let me review it when I'm not on mobile. This seems like a good contribution!

Correct. And if you put the CSS files in static/css/custom.css (for example) then the corresponding config line would be custom_css = ['css/custom.css'].

Fixes #33


Add WaitUntil

I have created WaitUntil function. This cloud be useful for logging and improving response time. I've also added an example so could you confirm that it works right?
Docs
https://developers.cloudflare.com/workers/runtime-apis/fetch-event/#waituntil

This feature has been released as v0.11.0!


Layers in component write access break systems

SnapshotGenerator.zip
default_launch.zip
spatialos.UnityGameLogic.worker.zip
We are accepting issues and we want your feedback.

Description
Specifying a layer as write access for an entity's components makes it not working.
Expected behaviour
Since the "UnityGameLogic" worker is responsible for the "game_logic" layer, components with "game_logic" write access should behave the same as before.
Current behaviour
The inspector shows no "Authoritative Workers" on the entities. The SendCreatePlayerRequestSystem sporadically activates with a chunk (about once per second). The HandleCreatePlayerRequestSystem never activates. Other entities such as the Spinners are never spawned so this might also affect the GameObjectCreation module.
Possible solution
Steps to reproduce

Modify "default_launch.json" and "spatialos.UnityGameLogic.worker.json" with the contents of the attached files.
Modify "SnapshotGererator.cs" so that each "WorkerUtils.UnityGameLogic" write access is replaced with "game_logic" layer (modified file attached for convenience).
Add "game_logic" string to the list "AllWorkerAttributes" in "WorkerUtils.cs".
Generate the snapshot.
Launch locally.
Go in Sample scene and Play.

Environment

Use the new layers to create entities instead of the old approach with specific workers.

Running basic diagnostics suite
Network Access Checks
Google Storage APIs Reachable: PASSED
Spatial Website Reachable: PASSED
Spatial Auth Server Reachable: PASSED
Spatial Maven Reachable: PASSED
Spatial API Reachable: PASSED
Spatial Secure Customer Proxy Reachable: PASSED
Can Bind to Local Port: PASSED
Spatial Proxy Reachable: PASSED
Spatial Website TLS and GRPCTLS Ports Reachable: PASSED
Spatial Auth TLS and GRPCTLS Ports Reachable: PASSED
Spatial Maven TLS and GRPCTLS Ports Reachable: PASSED
Spatial API TLS and GRPCTLS Ports Reachable: PASSED
Spatial Deployments Reachable: PASSED
Spatial Logs Reachable: PASSED
Spatial Monitoring Proxy Reachable: PASSED
Spatial Locator Reachable: PASSED
Maven Central Repo Reachable: PASSED
Sonatype OSS Repo Reachable: PASSED
All checks successful

Windows 10 64 bit, Unity 2018.3.0b10

Fixed by specifying
"options": {
     "manual_worker_connection_only": true
}

in default_launch.json


I cannot import these packages into flutter project

import 'package:mapmyindia_gl_example/model/feature_list.dart';
import 'package:mapmyindia_gl_example/place_symbol.dart';
import 'package:mapmyindia_gl_example/samples/add_marker.dart';
import 'package:mapmyindia_gl_example/samples/add_polyline_wdget.dart';
import 'package:mapmyindia_gl_example/samples/camera_feature.dart';
import 'package:mapmyindia_gl_example/samples/current_location_widget.dart';
import 'package:mapmyindia_gl_example/samples/location_camera_option.dart';
import 'package:mapmyindia_gl_example/samples/map_click_event.dart';
import 'package:mapmyindia_gl_example/samples/map_long_click.dart';
import 'package:mapmyindia_gl_example/samples/marker_dragging_widget.dart';
import 'package:mapmyindia_gl_example/utils/color.dart';
import 'package:mapmyindia_gl_example/utils/feature_type.dart';
import 'package:mapmyindia_gl_example/full_map.dart';

@joshuajennysibbu
Please try our sample app in flutter:
https://github.com/MapmyIndia/flutter-mapmyindia-gl

@joshuajennysibbu
Please try our sample app in flutter:
https://github.com/MapmyIndia/flutter-mapmyindia-gl

Thank for your reply its work...
But i got another error....
MapmyIndiaMap(
initialCameraPosition: CameraPosition(
target: LatLng(25.321684, 82.987289),
zoom: 14.0,
),
onMapCreated: (map) =>
{
mapController = map,
},
),
I run your sample code..... I get undefined mapController error... even I try datatype with a variable like 'MapmyIndiaMapController mapController = map,'
name but it does not work for me........


[ci] fix R linting job (fixes #3873)

Attempting to fix #3873.

Warning message:
package ‘lintr’ was built under R version 3.6.3
[1] 49 R files need linting
Error in loadNamespace(j <- i[[1L]], c(lib.loc, .libPaths()), versionCheck = vI[[j]]) :
namespace ‘xfun’ 0.15 is being loaded, but >= 0.19 is required
Calls:  ... namespaceImportFrom -> asNamespace -> loadNamespace
Execution halted

There might be a mistake somewhere in lintr's feedstock on conda-forge or in one of its dependencies. {xfun} is not a direct dependency of {lintr} (https://github.com/conda-forge/r-lintr-feedstock/blob/master/recipe/meta.yaml), so it must be a dependency of a dependency (or deeper :laughing: ). For now, I'm just going to try forcing conda install to get a newer version.

It seems like this fix did fix the lint job! https://github.com/microsoft/LightGBM/pull/3877/checks?check_run_id=1785176162

It seems like this fix did fix the lint job! https://github.com/microsoft/LightGBM/pull/3877/checks?check_run_id=1785176162

Should we report this in conda-forge repo?

Should we report this in conda-forge repo?

Should we report this in conda-forge repo?

yes, I will

Should we report this in conda-forge repo?

yes, I will

should we report this in the conda-forge repo

Created https://github.com/conda-forge/r-lintr-feedstock/issues/12

should we report this in the conda-forge repo

Created https://github.com/conda-forge/r-lintr-feedstock/issues/12

It seems that lint is passing, and all other CI jobs are passing except the ones we know are broken and waiting on other PRs (https://github.com/microsoft/LightGBM/pull/3876#issuecomment-769163119), so I'm going to merge this.

It seems that lint is passing, and all other CI jobs are passing except the ones we know are broken and waiting on other PRs (https://github.com/microsoft/LightGBM/pull/3876#issuecomment-769163119), so I'm going to merge this.

@jameslamb

Created conda-forge/r-lintr-feedstock#12

Thank you very much! Hope this will allow us revert the workaround eventually.

@jameslamb

Created conda-forge/r-lintr-feedstock#12

Thank you very much! Hope this will allow us revert the workaround eventually.


Feature - Suggesting filename based on the content in the file

Instead of suggesting untitled-x in the filename it will suggest a filename based on the content entered in the file.

Not sure about this change. Is there an issue discussing this already?

This is a new feature (Rather than suggesting filenames as Untitled-N, we are suggesting a dynamic filename based on the content entered in file.)

I don't really think we should do this, I have never wanted to name a file based on its content. And it could just cause issues if the line is very long, etc. But I will assign to @bpasero for feedback. I recommend that next time you open an issue first so we can discuss whether we want a feature, before you do the work to implement it.

ok sure. Thanks @roblourens

I think what I would rather expect is a setting that - once enabled - changes the filename of the untitled to the first line content (probably capped) and then when I save this editor the suggested file name is is simply taken from there. Please search for the existing issue, I am sure we have one.

Since I did not hear back, I am going ahead and close this.


create create-indices

hello, i have error
2023/11/07 14:02:41 Waiting for: https://opensearch-01:9200
2023/11/07 14:02:41 Received 200 from https://opensearch-01:9200
going to use protocol: https
going to use elastic headers based on username and password
not using any prefix
datahub_analytics_enabled: true

GET _ilm/policy/datahub_usage_event_policy response code is 400
failed to GET _ilm/policy/datahub_usage_event_policy ! -> exiting
2023/11/07 14:02:41 Command exited with error: exit status 1

can you please help me how to debug it?

solved with USE_AWS_ELASTICSEARCH


[perflint] Add PERF401 and PERF402 rules

Summary
Adds PERF401 and PERF402 mirroring W8401 and W8402 from https://github.com/tonybaloney/perflint
Implementation is not super smart but should be at parity with upstream implementation judging by: https://github.com/tonybaloney/perflint/blob/c07391c17671c3c9d5a7fd69120d1f570e268d58/perflint/comprehension_checker.py#L42-L73
It essentially checks:

If the body of a for-loop is just one statement
If that statement is an if and the if-statement contains a call to append() we flag PERF401 and suggest a list comprehension
If that statement is a plain call to append() or insert() we flag PERF402 and suggest list() or list.copy()

I've set the violation to only flag the first append call in a long if-else statement for PERF401. Happy to change this to some other location or make it multiple violations if that makes more sense.
Test Plan
Fixtures were added with the relevant scenarios for both rules
Issue Links
Refers: https://github.com/astral-sh/ruff/issues/4789

Sorry, I meant to get to this and the other perflint PR tonight, but I ran out of time. No action needed, I'll review + merge these when I can.


foldDyn freezes reflex-dom with ghcjs

When I use foldDyn in my reflex-dom code, compiled to a web page using ghcjs, the event system on the web page no longer seems to work: keypress events no longer have any effect where they did before.
For example: adding foldDyn (:) [] ev where ev is a _textInput_keypress has this effect. Please let me know if you would like a full example.
I mostly use the branch hamishmack-master, in order to use ghcjs 0.2. I also tried https://github.com/k0001/reflex-dom/tree/develop-ghcjs-0.2.0 which includes some more recent patches, but this did not help.

Hi @ariep; it would be great to see the full example.

This example illustrates the problem: key presses in the input field do not change the texts.
module Main where
import Reflex.Dom
main :: IO ()
main = mainWidget $ do
  t <- textInput def
  let newItemE = fmap show $ _textInput_keypress t
  el "div" $ do
    dItem <- holdDyn Nothing $ fmap Just newItemE
    dText <- mapDyn show dItem
    dynText dText
  items <- foldDyn (++) "Items:" newItemE
  -- items <- holdDyn "Items: " $ fmap show newItemE
  dynText items
  return ()

It is minimal in the sense that either
• commenting out the 4 lines of the el "div" do-block; or
• swapping in the other definition of items
fixes it.

That example works for me on the develop branch of try-reflex, in both ghci and ghcjs.  The hamishmack-master branch and ghcjs 0.2 haven't been tested with reflex-dom, yet - and it looks as though you may have found an issue with them.  Is it possible for you to switch to the develop branch?

That example works fine for me on ghcjs-0.2(compiled from Oct 1). Maybe your compiled ghcjs has a broken base or shims

@luigy I installed a new ghcjs today from git master, and it works now. Thanks!
This is still with the reflex-dom from k0001's repo, because current develop of reflex-dom needs ghcjs-dom < 0.2, but that does not compile with recent ghcjs.
@ryantrinkle I don't feel inclined to downgrade ghcjs, especially given the fact that apparently major bugs are still being fixed (even if older versions of reflex-dom did not trip it up).

@ariep Glad your issues were resolved!  Thanks for the update!


GRID ids in the title

Here's an example raw affiliation string: {0000 0004 0482 7128grid.48507.3eYerevan Physics InstituteYerevanArmenia}
GRID ids have a known deterministic mapping to ROR ids. We should:
(1) regex for GRID id
(2) if found, map to ROR
Should be easy and high precision.

This will be fixed in #11 - and also gets ISNI strings


basic tower test

This introduces a basic test utilizing Tower directly. In order to facilitate Tower, some changes are made to the body type signature. This should be backwards compatible and means that this library is accessible outside the direct context of Axum.

Very nice idea @maxcountryman, also thanks for fixing the fmt problem!
If you have any other ideas for tests (maybe some unit tests?) share those as issues and I'd gladly help :)

Thanks @Czocher! It might be helpful to add tests for the role behavior. There might be other things I'm not thinking of too, so any additional coverage that increase our confidence the library is doing what it should would be good. 😃