Route pgbouncer logs to virtio-serial

virtio-serial is much more performant than /dev/console emulation, therefore, is much more suitable for the verbose logs inside vm. This commit changes routing for pgbouncer logs, since we've recently noticed it can emit large volumes of logs.
Should help with https://github.com/neondatabase/cloud/issues/19072

@sharnoff I'm not sure if this is the right approach, but I think it should work? Will try to test it on staging after CI will build a compute image.

Tried to run this on staging, worked well. When I tried to kill pgbouncer, I saw logs like this:

2024-10-25 14:12:59.297	2024-10-25 14:12:59.057 UTC [2556] LOG C-0x1abb9d0: neondb/neondb_owner@<IP_ADDRESS>:4404 login attempt: db=neondb user=neondb_owner tls=no
2024-10-25 14:12:59.297	2024-10-25 14:12:59.053 UTC [2556] LOG C-0x1abb720: neondb/neondb_owner@<IP_ADDRESS>:45436 login attempt: db=neondb user=neondb_owner tls=no
2024-10-25 14:12:59.297	2024-10-25 14:12:59.050 UTC [2556] LOG C-0x1abb470: neondb/neondb_owner@<IP_ADDRESS>:45434 login attempt: db=neondb user=neondb_owner tls=no
2024-10-25 14:12:59.297	2024-10-25 14:12:59.048 UTC [2556] LOG C-0x1abb1c0: neondb/neondb_owner@<IP_ADDRESS>:45430 login attempt: db=neondb user=neondb_owner tls=no
2024-10-25 14:12:59.047	2024-10-25 14:12:59.046 UTC [2556] LOG C-0x1abaf10: neondb/neondb_owner@<IP_ADDRESS>:45422 login attempt: db=neondb user=neondb_owner tls=no
2024-10-25 14:12:59.047	2024-10-25 14:12:59.044 UTC [2556] LOG C-0x1abac60: neondb/neondb_owner@<IP_ADDRESS>:38632 login attempt: db=neondb user=neondb_owner tls=no
2024-10-25 14:12:59.047	2024-10-25 14:12:59.038 UTC [2556] LOG C-0x1aba9b0: neondb/neondb_owner@<IP_ADDRESS>:38622 login attempt: db=neondb user=neondb_owner tls=no
2024-10-25 14:12:58.546	2024-10-25 14:12:58.467 UTC [2556] LOG C-0x1aba9b0: (nodb)/(nouser)@<IP_ADDRESS>:4398 closing because: failed cancel request (age=0s)
2024-10-25 14:12:58.546	2024-10-25 14:12:58.465 UTC [2556] LOG C-0x1aba9b0: neondb/neondb_owner@<IP_ADDRESS>:4390 closing because: client close request (age=0s)
2024-10-25 14:12:57.795	2024-10-25 14:12:57.776 UTC [2556] LOG C-0x1aba9b0: neondb/neondb_owner@<IP_ADDRESS>:4390 login attempt: db=neondb user=neondb_owner tls=no
2024-10-25 14:12:57.795	PG:2024-10-25 14:12:57.773 GMT ttid=470b0db88a5edcd9fbd38f9e76a68c42/5d8d0dca8f2366edc7faa8aef3d7e579 sqlstate=00000 [2633] LOG:  connection received: host=<IP_ADDRESS> port=45250
2024-10-25 14:12:57.795	2024-10-25 14:12:57.772 UTC [2556] LOG S-0x1ac33d0: postgres/cloud_admin@<IP_ADDRESS>:5432 new connection to server (from <IP_ADDRESS>:45250)
2024-10-25 14:12:57.795	2024-10-25 14:12:57.771 UTC [2556] LOG C-0x1aba9b0: (nodb)/(nouser)@<IP_ADDRESS>:4390 registered new auto-database: postgres
2024-10-25 14:12:57.795	2024-10-25 14:12:57.770 UTC [2556] LOG C-0x1aba9b0: (nodb)/(nouser)@<IP_ADDRESS>:4390 registered new auto-database: neondb
2024-10-25 14:12:21.713	2024-10-25 14:12:21.580 UTC [2556] LOG process up: PgBouncer 1.22.1, libevent 2.1.12-stable (epoll), adns: evdns2, tls: unsupported
2024-10-25 14:12:21.713	2024-10-25 14:12:21.580 UTC [2556] LOG listening on unix:/tmp//.s.PGSQL.6432
2024-10-25 14:12:21.713	2024-10-25 14:12:21.579 UTC [2556] LOG listening on <IP_ADDRESS>:6432
2024-10-25 14:12:21.713	2024-10-25 14:12:21.577 UTC [2556] LOG kernel file descriptor limit: 1048576 (hard: 1048576); max_client_conn: 10000, max expected fd use: 10012
...
2024-10-25 14:12:21.712	PG:2024-10-25 14:12:21.479 GMT ttid=470b0db88a5edcd9fbd38f9e76a68c42/5d8d0dca8f2366edc7faa8aef3d7e579 sqlstate=00000 [2085] LOG:  disconnection: session time: 0:02:59.251 user=neondb_owner database=neondb host=::1 port=39946
2024-10-25 14:12:21.712	2024-10-25 14:12:21.478 UTC [205] LOG got SIGTERM, fast exit
2024-10-25 14:12:20.711	/bin/sh: 1: cannot create /dev/virtio-ports/tech.neon.log.0: Device or resource busy
...
2024-10-25 14:11:53.404	/bin/sh: 1: cannot create /dev/virtio-ports/tech.neon.log.0: Device or resource busy
2024-10-25 14:11:52.402	Terminated
2024-10-25 14:11:45.388	2024-10-25 14:11:45.266 UTC [205] LOG C-0xc4e0d0: neondb/neondb_owner@<IP_ADDRESS>:53522 closing because: client close request (age=71s)
2024-10-25 14:11:45.138	2024-10-25 14:11:44.936 UTC [205] LOG C-0xc4cb50: (nodb)/(nouser)@<IP_ADDRESS>:53414 closing because: failed cancel request (age=0s)
2024-10-25 14:11:45.138	2024-10-25 14:11:44.934 UTC [205] LOG C-0xc4cb50: neondb/neondb_owner@<IP_ADDRESS>:52530 closing because: client close request (age=70s)
2024-10-25 14:11:44.646	2024-10-25 14:11:44.589 UTC [205] LOG C-0xc4e380: (nodb)/(nouser)@<IP_ADDRESS>:49742 closing because: failed cancel request (age=0s)
2024-10-25 14:11:44.646	2024-10-25 14:11:44.588 UTC [205] LOG C-0xc4e380: neondb/neondb_owner@<IP_ADDRESS>:56222 closing because: client close request (age=67s)

What happened here is that I probably killed /bin/sh (at 2024-10-25 14:11:52) instead of pgbouncer and started to see logs like Device or resource busy.
Then I killed pgbouncer (at 2024-10-25 14:12:21.478 UTC) and inittab restarted it properly? After that it looks like it's working fine.

What happened here is that I probably killed /bin/sh (at 2024-10-25 14:11:52) instead of pgbouncer and started to see logs like Device or resource busy.
Then I killed pgbouncer (at 2024-10-25 14:12:21.478 UTC) and inittab restarted it properly? After that it looks like it's working fine.

Yeah, that sounds about right. As long as we can't end up with only some of pgbouncer running, then it should be fine.


Minimal functionality when using reset after power cycling camera

Hi, @MarkRivers !
I have found that when we power cycle a GigE camera, the reset process seems to work and it can acquire frames, but most of the parameters do not work. They get reset to 0 / No / N.A., so we can't see what the values on the camera are, and setting things has no effect, for example AcquireTime, although the readbacks update in the IOC.
Is this something you have seen before?
We are running a version based on R2-1

I don't believe I have tested power-cycling the camera without restarting the IOC.
I will try it soon.  It seems strange that you can't set parameters.
In terms of restoring the current settings to the device after a power-cycle, it is a more general problem in EPICS, not just restricted to GigE cameras or ADAravis.  When a device is power-cycled without rebooting the IOC we need to push the most recent EPICS PV values down to the device.  I have been thinking that this is probably something we could use the autosave module for.  The autosave file is designed to have all of the important settings that need to be pushed to the device to restore operation on an IOC reboot.  It seems like we could just use autosave to read that file (before it gets corrupted with the new values) and push to the device without doing a reboot.
I believe that Michael Davidsaver's branch of aravisGigE had a fix for rebooting GigE cameras, but specific to that driver.  I want a more general solution.

Hello,
I have the same problem with a Prosilica camera (the reconnect button has no effect on a disconnected camera), and additionally, if reconnect is pressed whilst the camera is connected, it locks up the camera parameters.  Images are still streamed, but parameter changes no longer have an effect.  When this happens the following error message appears in the IOC console:
(process:29661): GLib-GObject-^[[1;33mWARNING^[[0m **: ^[[34m08:47:17.193^[[0m: invalid unclassed pointer in cast to 'ArvGcFeatureNode'
** (process:29661): ^[[1;35mCRITICAL^[[0m **: ^[[34m08:47:17.193^[[0m: arv_gc_feature_node_is_available: assertion 'ARV_IS_GC_FEATURE_NODE (gc_feature_node)' failed

I can confirm that the reconnect functionality works with the same camera when using the aravisGigE module.
Thanks,
James

I can confirm that the reconnect functionality works with the same camera when using the aravisGigE module.

What version of the aravisGigE module are you using?  Is it the master branch or one of the releases in https://github.com/areaDetector/aravisGigE, or is it a branch from Michael Davidsaver?

It appears to be a very old version from March 2015.  It is using a Diamond release number (0-3-5dls6) so I am not sure how well it maps to the versions from GitHub.  Looking in the git log, the merges seem to come from the master branch.

I have changed the master branch of ADAravis and ADCore so that one can now do the following without restarting the IOC:

Power-cycle the camera
Reconnect the ADAravis driver to the camera
Download all of the current EPICS settings to the camera so that it operates the same as before the power-cycle

ADAravis required the following changes:

Added arvFeature::initialize() and an std::vector of arvFeatures to allow re-initializing when the camera reconnects.
Add autosave command create_manual_set(ADAutoSaveMenu.req, ...) to iocBoot/iocAravis/st.cmd.base.

This can be used to save and load the camera and plugin PV when the camera reconnects.
It can also be used to save and load different configurations for different setups.

ADCore required the following changes:

New file ADAutoSaveMenu.req to be used with the configMenu utility in autosave.

It saves all of the camera and plugin settings defined in iocBoot/iocXXX/auto_settings.req.
This allows manually saving and loading different configurations for different setups with the same IOC.
It also allows saving and then loading the settings when a camera is reset or restarted,
without restarting the IOC.

Modified ADPlugins OPI sub-screen.

Added a related display "Plugins/Other 2/AS configMenu" which allows manually saving and loading
configurations that use ADAutoSaveMenu.req described above.

The following steps are needed to do this:

Power cycle the camera
Wait a few seconds for the camera to finish initializing, and then press the "Reset camera" button on this screen:

At this point ADAravis can control the camera again.  However, many camera settings will no longer match the EPICS settings.
Open this screen from "ADAravis/Plugins/Other 2/AS configMenu"

On this screen you can name different configurations you want to save, in this case just test1 and test2.
Press the Save button for the configuration name you want to save.  This will save all of the camera and plugin settings to a file called ADAutoSave_test1.cfg.  It will also create a backup of the current settings before creating the new file with a name like ADAutoSave_test1.cfg_210628-133135, where the end of the file name is the current date and time.
Press the Load button for the same configuration you just saved.  This will download all of the EPICS camera settings to the camera.  It will also set all of the plugin settings to the same values you just loaded, so they should not actually change.
This tool can also be used to save multiple configurations with different settings, for example different binning or camera orientation with NDPluginTransform.  It provides a convenient way to then reload these configurations at a later date.

Thanks @MarkRivers this is working great! The beamline and can now move their cameras around as they please and then reconnect in the IOC with no issues.
Using autosave to restore settings on reconnect is a nice addition, but just being able to reconnect is a already huge UX improvement in our case.

I have changed the master branch of ADAravis and ADCore so that one can now do the following without restarting the IOC:

Power-cycle the camera
Reconnect the ADAravis driver to the camera
Download all of the current EPICS settings to the camera so that it operates the same as before the power-cycle

ADAravis required the following changes:

Added arvFeature::initialize() and an std::vector of arvFeatures to allow re-initializing when the camera reconnects.

Add autosave command create_manual_set(ADAutoSaveMenu.req, ...) to iocBoot/iocAravis/st.cmd.base.

This can be used to save and load the camera and plugin PV when the camera reconnects.
It can also be used to save and load different configurations for different setups.

ADCore required the following changes:

New file ADAutoSaveMenu.req to be used with the configMenu utility in autosave.

It saves all of the camera and plugin settings defined in iocBoot/iocXXX/auto_settings.req.
This allows manually saving and loading different configurations for different setups with the same IOC.
It also allows saving and then loading the settings when a camera is reset or restarted,
without restarting the IOC.

Modified ADPlugins OPI sub-screen.

Added a related display "Plugins/Other 2/AS configMenu" which allows manually saving and loading
configurations that use ADAutoSaveMenu.req described above.

The following steps are needed to do this:

Power cycle the camera
Wait a few seconds for the camera to finish initializing, and then press the "Reset camera" button on this screen:

At this point ADAravis can control the camera again.  However, many camera settings will no longer match the EPICS settings.
Open this screen from "ADAravis/Plugins/Other 2/AS configMenu"

On this screen you can name different configurations you want to save, in this case just test1 and test2.
Press the Save button for the configuration name you want to save.  This will save all of the camera and plugin settings to a file called ADAutoSave_test1.cfg.  It will also create a backup of the current settings before creating the new file with a name like ADAutoSave_test1.cfg_210628-133135, where the end of the file name is the current date and time.
Press the Load button for the same configuration you just saved.  This will download all of the EPICS camera settings to the camera.  It will also set all of the plugin settings to the same values you just loaded, so they should not actually change.
This tool can also be used to save multiple configurations with different settings, for example different binning or camera orientation with NDPluginTransform.  It provides a convenient way to then reload these configurations at a later date.

Dear Mark,
It seems that you directly used the configMenu adl file shipped with autosave, but there are no database-related changes made. Should people add lines like the following in the commonPlugins.cmd file of ADCore?
dbLoadRecords("$(AUTOSAVE)/db/configMenu.db","P=$(PREFIX),CONFIG=ADAutoSave,ENABLE_SAVE=0")
Best regards,
Wu-Cheng Chiang

Should people add lines like the following in the commonPlugins.cmd file of ADCore?
dbLoadRecords("$(AUTOSAVE)/db/configMenu.db","P=$(PREFIX),CONFIG=ADAutoSave,ENABLE_SAVE=0")

@devilkingsatan666 thanks for pointing that out.  I had added configMenu.db to my local commonPlugins.cmd, but not to EXAMPLE_commonPlugins.cmd.  I have now added that and made some other minor fixes and pushed to the master branch.

Might it be a good idea to include "configMenu_settings.req" in "ADAutoSaveMenu.req"?

I was including configMenu.req rather than configMenu_settings.req in ADAutoSaveMenu.req.  This is the difference between those files:

corvette:~/devel/autosave/db>diff -U2 configMenu.req configMenu_settings.req
--- configMenu.req      2021-03-12 14:38:47.823241034 -0600
+++ configMenu_settings.req     2021-03-12 14:38:47.818241066 -0600
@@ -1,2 +1,5 @@
 $(P)$(CONFIG)Menu:currName
 $(P)$(CONFIG)Menu:currDesc
+$(P)$(CONFIG)Menu:enableSave
+# configMenu will search for .cfg files, so no need to autosave them
+#file configMenuNames.req P=$(P),CONFIG=$(CONFIG)

So the difference is that configMenu_settings.req also saves the enableSave PV, while configMenu.req does not.  Since that PV is present and exposed in the OPI "more" screen I have changed ADAutoSaveMenu.req to include configMenu_settings.req instead.

This issue is resolved, closing it.


time format issue

Hi,
I am new to python. I'm trying to write a csv file to influxdb using cmd prompt in windows 10 and i am receiving the following error, please help me.
csv-to-influxdb.py: error: unrecognized arguments: %H:%M:%S'
C:\Users\admin\AppData\Local\Programs\Python\Python37\Scripts>python csv-to-influxdb.py --dbname test --input D:\mydata\FL_insurance.csv --tagcolumns policyID --fieldcolumns tiv_2011 -tc timestamp -tf '%d-%m-%y %H:%M:%S'
usage: csv-to-influxdb.py [-h] -i [INPUT] [-d [DELIMITER]] [-s [SERVER]]
[-u [USER]] [-p [PASSWORD]] --dbname [DBNAME]
[--create] [-m [METRICNAME]] [-tc [TIMECOLUMN]]
[-tf [TIMEFORMAT]] [-tz TIMEZONE]
[--fieldcolumns [FIELDCOLUMNS]]
[--tagcolumns [TAGCOLUMNS]] [-g] [-b BATCHSIZE]
csv-to-influxdb.py: error: unrecognized arguments: %H:%M:%S'
my csv time format is d-m-y

If your csv time format is 'd-m-y', you need to use -tf '%d-%m-%y'

Thank you, the issue was with the date format in my csv. Works fine now.
Cheers!!


[Event Request] Codeunit 7110 Analysis Report Management - Procedure DrillDownQuantity - OnBeforeDrillDownQuantity

Describe the request
Please add the event OnBeforeDrillDownQuantity in procedure DrillDownQuantity in Codeunit 7110 Analysis Report Management.
local procedure DrillDownQuantity(var ItemStatisticsBuf: Record "Item Statistics Buffer"; Invoiced: Boolean)
var
    ValueEntry: Record "Value Entry";
    ItemLedgEntry: Record "Item Ledger Entry";
    ItemAnalysisViewEntry: Record "Item Analysis View Entry";
begin
    OnBeforeDrillDownQuantity(ItemStatisticsBuf, IsHandled); // <---- New Event
    if IsHandled then
        exit;

    if ItemStatisticsBuf.GetFilter("Source No. Filter") = '' then
        ItemStatisticsBuf.SetRange(ItemStatisticsBuf."Source Type Filter");

    ItemStatisticsBuf.SetRange(ItemStatisticsBuf."Entry Type Filter");

    if AnalysisLineTemplate."Item Analysis View Code" = '' then begin
        if Invoiced then begin
            FilterValueEntry(ItemStatisticsBuf, ValueEntry);
            PAGE.Run(0, ValueEntry, ValueEntry."Invoiced Quantity");
        end else begin
            FilterItemLedgEntry(ItemStatisticsBuf, ItemLedgEntry);
            PAGE.Run(0, ItemLedgEntry, ItemLedgEntry.Quantity);
        end;
    end else begin
        FilterItemAnalyViewEntry(ItemStatisticsBuf, ItemAnalysisViewEntry);
        if Invoiced then
            PAGE.Run(0, ItemAnalysisViewEntry, ItemAnalysisViewEntry."Invoiced Quantity")
        else
            PAGE.Run(0, ItemAnalysisViewEntry, ItemAnalysisViewEntry.Quantity);
    end;
end;

[IntegrationEvent(false, false)]
local procedure OnBeforeDrillDownQuantity(var ItemStatisticsBuf: Record "Item Statistics Buffer"; var IsHandled: Boolean)
begin
end;

Additional context
We need to handle alternative quantities similar to our previous event requests.
Event 3/4
Internal work item: AB#561384

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.
Build ID: 28412.


Installing devpy

Would it be possible to add installation instructions to the README? Currently doing pip install devpy appears to install an unrelated package, so even if this tool is not yet on PyPI it would be worth telling people to not install devpy from PyPI?

That's a good point; we're in the process of obtaining that package (the owner said they're willing to hand it over, but communication has been slow).  In the mean time, I will update the README as you suggest.

@astrofrog the package os being renamed to spin, since we could not get the PyPi name. We're making a new release, probably tomorrow.


How to permanently fail a job even if there are more attempts

Hi,
I am using Kue 0.8.9 and my jobs have 5 attempts by default.
When processing a single job on some conditions I want to move the job to a "failed" state where no more attempts should be done. How to do it?
I already tried to manipulate the attempts() (e.g. job.attempts(1).save()) but it didn't work.
I had the same result when manipulating the state, _max_attempts, _attempts and so on.
Thanks for your help,
Paulo

It looks like that a combination of sets do the job
job.error(new Error(''Error message'));
job.failed();
job.set('max_attempts', 1);

Doesn't it make sense to add a failJobWithNoMoreAttempts() shortcut?

I expect
job.attempts( 1 ).save( function(){
  done( err );
});

to do the trick.
The above code is not a good practice, you are recommended to call done(err) to fail a job properly, and it's better to update job (max_attempts, attempts, ..) before that not after :)

I checked the code, max_attempts is set only on creating the job: https://github.com/Automattic/kue/blob/master/lib/queue/job.js#L732
This should be moved to update, for my proposed code to work, I should fix this :)

@behrad thanks for your feedback.
I had seen that max_attempts was being set on constructor only but I thought it was a "security measure".
To be honest (and I am available to implement it) I would create something more fluent to fail a job before reach max_attempts (e.g. done(err).withNoMoreAttempts()).
Let me know if you think I can help/contribute.
Cheers,
Paulo A. Silva

@PauloASilva

why add a new api?

I can't see what withNoMoreAttempts is proposed to do?

done() is not easy to cascade with .something()

To make it fluent
Use case

    On job first attempt a pre-requirement is not fulfilled.
    The job must
    * completed with error OR
    * failed with error
    No more more job attempts should be done.

I can't see what withNoMoreAttempts is proposed to do?

I mean the implementation?

I would say
job._max_attempts = job._attempts
or
job._attempts = job._max_attempts
making them equal will do it (it's a matter of meaning)

we can add a Job#noMoreAttempts which sets job._max_attempts = job._attempts
then
job.noMoreAttempts().save( function(){
  done(err);
});

It sounds great!
Em 13/05/2015 19:19, "Behrad"<EMAIL_ADDRESS>escreveu:

we can add a Job#noMoreAttempts which sets job._max_attempts =
job._attempts
then
job.noMoreAttempts().save( function(){
done(err);
});
—
Reply to this email directly or view it on GitHub
https://github.com/Automattic/kue/issues/612#issuecomment-101765863.


ClickOnView(solo.getView(id)) is not working on a widget layout

From<EMAIL_ADDRESS>on May 20, 2014 21:11:09
What steps will reproduce the problem? 1. Launched the Android application through automation script, and waits until the main activity is launched, clicks on a link for which an overlay appears
2. On this overlay I have tried almost everything to click on a element, using clickOnView, clickOnButtonById , clickLongOnText, clickOnButton, clickOnScreen, clickOnText, but nothing is working. Is there any issue with clicking on elements on overlay
I have also tried below code
LinearLayout submitBtn = (LinearLayout) solo.getView(id);
assertNotNull(submitBtn);
submitBtn.performClick();
and
ImageButton imageButton = (ImageButton) solo.getView(R.id.x);
solo.clickOnView(imageButton);
but nothing works What is the expected output? What do you see instead? Should click but it is not clicking and instead searching for element by scrolling till the end
Used code solo.clickLongOnText("text", 1, false); to avoid scroll but this is also not identifying the element What version of the product are you using? On what operating system? Android 4.4.2 platform and emulator is Nexus 5 Please provide any additional information below.
Original issue: http://code.google.com/p/robotium/issues/detail?id=608

From<EMAIL_ADDRESS>on May 20, 2014 21:14:00
I have tried with text view and id of the element but nothing works.
I cannot share the details of the application.

From<EMAIL_ADDRESS>on May 20, 2014 23:25:05
Thanks for reporting this issue. The problem your experiencing is due to the overlay opened not running in the same process as the start activity. Due to Android restrictions the tests is only allowed to interact with the app under test. Unfortunately there is no way around this.
Status: Invalid
Owner<EMAIL_ADDRESS>

From<EMAIL_ADDRESS>on May 21, 2014 03:07:46
But I'm able to view the element on that overlay using hierarchy viewer and can get the ID as well.
Please let me know if there is any particular click code for elements on overlay.
Thanks..

From<EMAIL_ADDRESS>on May 21, 2014 03:09:22
Its the same click methods everywhere. As long as the view belongs to the app under test the  View will be available to Robotium.

From<EMAIL_ADDRESS>on May 21, 2014 03:34:10
Ok so the click does not fail. Please see:
Why do text and button clicks get wrong? https://code.google.com/p/robotium/wiki/QuestionsAndAnswers

From<EMAIL_ADDRESS>on May 21, 2014 04:15:25
<uses-sdk
android:minSdkVersion="8"
android:targetSdkVersion="19"/>
\<supports-screens android:anyDensity="true"/>

Adding these two - Does not work. Please specify if we have any other workarounds for this?

From<EMAIL_ADDRESS>on May 21, 2014 04:17:44
This needs to be added to the AndroidManifest.xml of the app under test.

From<EMAIL_ADDRESS>on May 21, 2014 04:37:41
Tried adding the same to AndroidManifest.xml of the app under test. But this doesn't help

From<EMAIL_ADDRESS>on May 21, 2014 04:38:21
Would it be possible for you to share the apk?

From<EMAIL_ADDRESS>on May 21, 2014 04:40:32
:(

From<EMAIL_ADDRESS>on May 21, 2014 05:58:21
Anyways this issue has been solved , when clicked by index e.g: solo.clickOnView(solo.getView(TextView.class, 13));
Don't understand why passing the id does not work e.g:
solo.clickOnView(solo.getView("id_of_the_element"));

From<EMAIL_ADDRESS>on May 21, 2014 05:59:51
Great. If you use solo.getView(String name) it should only be the simple name and not the whole com.x.x.x. but "my_id".

From<EMAIL_ADDRESS>on May 21, 2014 07:07:00
Yes, was trying with solo.getView("my_id") only,
Not with solo.getView("com.packageName.x:id/my_id");


chore(master): release 1.4.0

:robot: I have created a release beep boop
1.4.0 (2023-03-15)
Features

add more deps (#30) (9b4e56f)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/wayofdev/docker-rabbitmq/releases/tag/v1.4.0 :sunflower:


async for message in self._websocket_client is blocking the event loop

Have a question of the simple snippet code. New to the asyncio so maybe missing something basic here. The read message is for getting the real time prices flowing and is an infinite loop as the server will not disconnect it. Also need to continuously receive the messages that the server is sending.
uvloop.install()

loop = asyncio.get_event_loop()
loop.run_until_complete(alice_blue_obj.init_websocket_connection())
loop.run_until_complete(alice_blue_obj.read_messages())
loop.run_forever()

asyncio.run(alice_blue_obj.subscribe(instrument1, "full_snapquote"))
asyncio.run(alice_blue_obj.subscribe(instrument2, "full_snapquote"))

**async def read_messages(self):**
        print('in read_messages')
        async for message in self._websocket_client:
            print(message)

asyncio.run creates another event loop. You cannot use the same connection from different event loops. Probably that's the issue. Restructure your program to have exactly one asyncio.run call and no loop.run_* calls.

Hi thanks for the quick reply @aaugustin. One followup question here would be if a thread outside wants to send subscription message on the same socket for a different instrument, that code won't be part of asyncio.run. So how is that normally done?

https://websockets.readthedocs.io/en/stable/howto/faq.html#why-am-i-having-problems-with-threads

oh awesome. That really helps.


Quality control check

Please check I've done everything properly!

looks good, only adding an orthoprofile seems possible and easy, so useful.

Yes, looks good. I took a stab at adding an orthography profile here #2

Looks great, thanks.
I just realised that we should try to force the implementation of iter_raw_lexemes, and use that in install rather than read_tsv directly.


Dark mode

Currently only a light mode is offered, a dark mode would also be nice

It will be supported sooner or later

Hello @sunner  I am using 1.28 and I cannot find the feature.

Hello @sunner I am using 1.28 and I cannot find the feature.

Too much to do. It takes time.....

done in caadd03cb828ec619c01786e3f09948c3cfee461 by @tanchekwei


SSO integration

[BLOCKED] Pending PM approval.
Trello ticket
This feature includes:

Adding a link to the login page to enable SSO through the existent MOJ SSO application
Adds configurations to setup the MOJ SSO integration for the different environments

@alan Could you please review?

@alan ♻  with suggested improvements.


Translations update from Weblate

Translations update from Weblate for ioBroker Adapters/mihome-vacuum.
Current translation status:

@MeisterTR Translations can now also be managed via Weblate and come then as PRs ... simple merge them (no squash&Merge or such please). I leave check for you and merge


NTR: Ethnicities for RIMDAMAL

new terms needed for ethnicities are as follows:
I am not sure what to do about Mixed and Other?
Bobo
Djan
Bwaba
Other
Mixed
Dioula
Mossi
Peulh
Samos
Dafins
Dagaris
Lobire
Birifor

mixed ethnicity

Thanks @zhengj2007 so I found this paper about RIMDAMAL, the study that is associated with the study I am working on.
https://www.thelancet.com/journals/lancet/article/PIIS0140-6736(18)32321-3/fulltext
It mentions the ethnicities in there, let me know if this of use and if not I can try and look for something else!

Thank you for this @zhengj2007 , I will chat with the clinepi team and report back on this!

@zhengj2007 we are none the wiser on the definitions so we are happy to go with whatever you see best!

@SAK22 The HANCESTRO developers told me most of the terms are covered in the African Population Ontology. However, "Djan" and "Samos" are not recorded. Could you please provide more information about "Djan" and "Samos"? You mentioned the RIMDAMAL study paper. But I cannot find the "Djan" and "Samos". Thanks!

Hmmm because the data for RIMDAMAL II is not published I can't find any info and yes you are right they did not come up in that RIMDAMAL publication....I am not sure what to do. Shall I ask the providers?

Shall I ask the providers?
@SAK22 That would be great. Thanks

@zhengj2007 can we just add placeholders for these for now please?

@SAK22 I think it is a clinEpi dataset. You can work on the mappings. We will assign the placeholder IDs when we make the OWL file. Since the clinEpi projects generally need many new terms, you don't need to submit NTRs for the projects. But it would be great if you can provide the definitions in the mapping file.

@SAK22 Although we can add the terms as placeholders now, we need to make the terms available in the ontology eventually. Could you please contact the data provider for the definition/description of "Djan" and "Samos"?


Associated constants in trait functions

This is a weird one & may not be an issue with async-trait, so please close if needed.  When trying to use associated constants in macros (such as debug! or println!) it appears to trip up the compiler.
This standard trait compiles:
pub trait Example {
    const ASSOCIATED: &'static str;

    fn associated(&self) {
        println!("Associated:{}", Self::ASSOCIATED);
    }
}

This decorated trait does not compile:
#[async_trait]
pub trait Example {
    const ASSOCIATED: &'static str;

    async fn associated(&self) {
        println!("Associated:{}", Self::ASSOCIATED);
    }
}

I get the following error message:
error[E0401]: can't use generic parameters from outer function
  --> src/example.rs:16:35
   |
16 |         println!("Associated:{}", Self::ASSOCIATED);
   |                                   ^^^^^^^^^^^^^^^^
   |                                   |
   |                                   use of generic parameter from outer function
   |                                   can't use `Self` here

However, the trait impl works fine if you let bind it:
#[async_trait]
pub trait Example {
    const ASSOCIATED: &'static str;

    async fn associated(&self) {
        let associated = Self::ASSOCIATED;
        println!("Associated:{}", associated);
    }
}

The workaround appears to be OK for my use case.

Thanks for the nice minimal repro. I published 0.1.25 with a fix.


coveralls 2.2.0 fails with KeyError: 'service_job_id'

Since a few days, coveralls 2.2.0 fails as follows, at least on Python 3.5 and 3.11.
We use coveralls 2.2.0 in order to avoid issue #252 , and up until recently that has worked fine.
Submitting coverage to coveralls.io...
Traceback (most recent call last):
  File "/opt/hostedtoolcache/Python/3.11.3/x64/bin/coveralls", line 8, in <module>
    sys.exit(main())
             ^^^^^^
  File "/opt/hostedtoolcache/Python/3.11.3/x64/lib/python3.11/site-packages/coveralls/cli.py", line 85, in main
    result = coverallz.wear()
             ^^^^^^^^^^^^^^^^
  File "/opt/hostedtoolcache/Python/3.11.3/x64/lib/python3.11/site-packages/coveralls/api.py", line 225, in wear
    self.config['service_job_id'], random.randint(0, sys.maxsize))
    ~~~~~~~~~~~^^^^^^^^^^^^^^^^^^
KeyError: 'service_job_id'

coveralls is run in Gthub Actions without --service=github.

Sorry, I don't have the bandwidth to support reports against older versions over coveralls unless a user wants to contribute a backportable fix. Closing this ticket.
Note that if #252 is an issue for you, there are various solutions in that thread which should work with the latest version of coveralls!


[rxjs v6] fromPromise not exported from index.d.ts

RxJS version:
6.0.0-rc.0
Code to reproduce:
import { fromPromise } from 'rxjs';
Expected behavior:
exported fromPromise
Actual behavior:
Module '".../node_modules/rxjs/index"' has no exported member 'fromPromise'

Seems like you're supposed to use import { from } from 'rxjs'; instead.

@larrifax yup, as far as I can see this isnt mentioned in the changelog

refer https://github.com/ReactiveX/rxjs/pull/3391 , I think it's just missing changelog.

/cc @benlesh to confirm and close if so.

Yes. Use from. Will have an updated migration guide soon.


refactor(hsds): fixed typo in docs strings

:tada: This PR is included in version 6.0.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Handle naming conflicts in MaterialX source includes for OSL

Currently there is an mx_funcs.h as well as other include files with some custom identifiers and functions.
When included in code their names could cause generated code to conflict with it.
An example is logged here (https://github.com/AcademySoftwareFoundation/MaterialX/issues/1106) for instance.
The current proposal is to at least rename possible conflicts to start with mx_ consistently, though the side-effects of this
are unknown. This is a similar naming approach taken in general for "MaterialX" source code additions.
Additionally these names need to be added to the list of restricted keywords in for OSL
This causes a unique name to be generated. Note that if this is for reference implementation generation and an
a definition's argument identifier conflicts it will be renamed, and hence will no longer match the nodedef's input name.
This is a orthogonal issue brought up to have control over this naming but conflicts must still be avoided.
Note that some of these would not be required and should be removed if they become intrinsics (color4 seems to be in the plan)
to avoid conflict with intrinsics.

Thanks for this report, @kwokcb, and this issue has been addressed as part of #1184.

Thanks for this report, @kwokcb, and this issue has been addressed as part of #1184.


Filter Account owned Packages by deprecated vs non-deprecated

Related Problem
Looking at the https://www.nuget.org/account/Packages view of packages on our account, we have 128 in varying states. I need to update some of them to point to others...
While I can sort, I can't filter this list to look for a common root. Or I can't separate it out based on deprecated or non-deprecated packages like I can with listed/unlisted packages...
The Elevator Pitch
It'd be nice as a package owner to have a greater ability to view a subset of packages that I need to work on either by filtering out by a search term within the page and by removing entirely deprecated packages from my view like I can with unlisted ones.
Additional Context and Details
No response

Probably we could have more filters other than deprecated.
cc @JonDouglas

Should this issue track multiple types of filters or should we have an issue for each one?
As filtering the list down based within the name of the package would be helpful too.

Should this issue track multiple types of filters or should we have an issue for each one?
As filtering the list down based within the name of the package would be helpful too.

Just 1 would be suffice, you can edit the original text description to add more

The ability to filter out deprecated packages would help my team as well. I'd love to provide Azure SDK customers this list, minus the deprecated packages. It's an easy way to show the list of packages we recommend they use. I've often wanted to apply the same filter within VS' NuGet Package Manager.


Plugin doesn't do anything anymore

Atom version: 1.17.0
MacOS version: 10.12.5
Current Remote-FTP version: 1.0.0
I updated from Remote-FTP version 0.10.7 (wich worked) to Remote-FTP version 1.0.0 since I saw it supported the new Atom Dock (From Atom version: 1.16.0). However, the plugin doesn't work anymore.
It doesn't toggle, it doesn't create a new (S)FTP config file in a project.
I have tried several times by reinstalling the plugin, restarting Atom, restarting macOS, but won't work. Problem is reproducible.
I have tried the (possible) solution provided here: https://github.com/mgrenier/remote-ftp/issues/824#issuecomment-306384144, but that doesn't work.

I have fixed this issue for myself, I downloaded the 0.10.7 release from GitHub (.zip), placed these files in ~/.atom/packages/RemoteFTP, but it gave me a error "FS-plus" module not found (something like that). So, I updated it to 1.0.0 trough Atom's package updater and replaced all files in ~/.atom/packages with the files from 0.10.7.
Now it works.

Write something on the dev tool?
View > Developer > Toogle Developer tool
And please check "incompatible-packages".
I check MacOS 10.12 and Atom 1.17.2

Failed to require the main module of 'Remote-FTP' because it requires one or more incompatible native modules (binding, binding, binding, binding, binding, binding).
Run `apm rebuild` in the package directory and restart Atom to resolve.

Thrown in events.js:110 listeners[i].call(self, arg1);
Possible duplicate of https://github.com/mgrenier/remote-ftp/issues/802

I have fixed this issue for myself, I downloaded the 0.10.7 release from GitHub (https://github.com/mgrenier/remote-ftp/archive/v0.10.7.zip), placed these files in ~/.atom/packages/RemoteFTP, but it gave me a error "FS-plus" module not found (something like that). So, I updated it to 1.0.0 trough Atom's package updater and replaced all files in ~/.atom/packages with the files from 0.10.7.

You must specify such a command: npm install (Missing node_modules folder)

I have fixed this issue for myself, I downloaded the 0.10.7 release from GitHub (https://github.com/mgrenier/remote-ftp/archive/v0.10.7.zip), placed these files in ~/.atom/packages/RemoteFTP, but it gave me a error "FS-plus" module not found (something like that). So, I updated it to 1.0.0 trough Atom's package updater and replaced all files in ~/.atom/packages with the files from 0.10.7.

 Fresh install of 1.0.0 gives https://github.com/mgrenier/remote-ftp/issues/839#issuecomment-309367553

It must be rebuilt this package, because changes dependencies, which requires the build. This is not necessarily the fault of the code.
For me, Atom immediately offered this opportunity in editor.
If it fails command apm rebuild try remove node_modules folder:
rm -rf ~/.atom/packages/Remote-FTP/node_modules

Thank you so much, it work for me ;)

It must be rebuilt this package, because changes dependencies, which requires the build. This is not necessarily the fault of the code.
For me, Atom immediately offered this opportunity in editor. (Incompatible-packages view)

Worked!

Atom version: 1.18.0
MacOS version: 10.12.5
Current Remote-FTP version: 1.0.0
Solution is not working here.
apm rebuild doesn't actually appear to do anything but also throws no errors, Incompatible-packages displays the same
`Remote-FTP 1.0.0
binding@unknown – Cannot find module '/Users/lmacinnes/.atom/packages/Remote-FTP/node_modules/fsevents/lib/binding'
binding@unknown – Cannot find module '/Users/lmacinnes/.atom/packages/Remote-FTP/node_modules/fsevents/lib/binding'
binding@unknown – Cannot find module '/Users/lmacinnes/.atom/packages/Remote-FTP/node_modules/fsevents/lib/binding'
binding@unknown – Cannot find module '/Users/lmacinnes/.atom/packages/Remote-FTP/node_modules/fsevents/lib/binding'
binding@unknown – Cannot find module '/Users/lmacinnes/.atom/packages/Remote-FTP/node_modules/fsevents/lib/binding'
binding@unknown – Cannot find module '/Users/lmacinnes/.atom/packages/Remote-FTP/node_modules/fsevents/lib/binding'`
but does not present a rebuild button

I tried apm rebuild with makes Incompatible-Packages to report success, but now I get this error:
[Enter steps to reproduce:]

Start Atom
That's it.

Atom: 1.18.0 x64
Electron: 1.3.15
OS: Mac OS X 10.12.5
Thrown From: Remote-FTP package 1.0.0
Stack Trace
Failed to load the Remote-FTP package
At Cannot find module 'fs-plus'

Error: Cannot find module 'fs-plus'
    at Module._resolveFilename (module.js:455:15)
    at Module._resolveFilename (/Applications/Atom.app/Contents/Resources/electron.asar/common/reset-search-paths.js:35:12)
    at Function.get_Module._resolveFilename (/Applications/Atom.app/Contents/Resources/app/src/module-cache.js:354:58)
    at Module.require (Applications/Atom.app/Contents/Resources/app/static/index.js:40:43)
    at require (/Applications/Atom.app/Contents/Resources/app/src/native-compile-cache.js:66:33)
    at /packages/Remote-FTP/lib/remote-ftp.js:11:15)
    at Module.get_Module._compile (/Applications/Atom.app/Contents/Resources/app/src/native-compile-cache.js:106:36)
    at Object.value [as .js] (/Applications/Atom.app/Contents/Resources/app/src/compile-cache.js:239:29)
    at Module.load (module.js:473:32)
    at tryModuleLoad (module.js:432:12)
    at Function.Module._load (module.js:424:3)
    at Module.require (Applications/Atom.app/Contents/Resources/app/static/index.js:47:45)
    at require (internal/module.js:20:19)
    at customRequire (/Applications/Atom.app/Contents/Resources/app/static/<embedded>:96:26)
    at Package.module.exports.Package.requireMainModule (/Applications/Atom.app/Contents/Resources/app/src/package.js:887:35)
    at /Applications/Atom.app/Contents/Resources/app/src/package.js:158:34
    at Package.module.exports.Package.measure (/Applications/Atom.app/Contents/Resources/app/src/package.js:99:21)
    at Package.module.exports.Package.load (/Applications/Atom.app/Contents/Resources/app/src/package.js:144:18)
    at PackageManager.module.exports.PackageManager.loadAvailablePackage (/Applications/Atom.app/Contents/Resources/app/src/package-manager.js:565:22)
    at /Applications/Atom.app/Contents/Resources/app/src/package-manager.js:479:25
    at Config.module.exports.Config.transact (/Applications/Atom.app/Contents/Resources/app/src/config.js:321:22)
    at PackageManager.module.exports.PackageManager.loadPackages (/Applications/Atom.app/Contents/Resources/app/src/package-manager.js:473:25)
    at /Applications/Atom.app/Contents/Resources/app/src/atom-environment.js:812:34

@reneruiz If cannot find, then wrong installed. Try re-install.

Re-install fixed it. 👍

I can't seem to get the
Failed to require the main module of 'Remote-FTP' because it requires one or more incompatible native modules (binding, binding, binding, binding, binding, binding). Run apm rebuild in the package directory and restart Atom to resolve.
message to go away, even with the above suggestions. (apm rebuild in package directory, blowing away node_modules directory, etc.) I've also tried uninstalling and reinstalling Remote-FTP with no luck. Same message every time in developer console. Package simply isn't working for me right now. Any other ideas anyone? Thanks!
macOS Sierra 10.12.5 with Atom 1.18.0 x64

@Meloncon try this
apm remove remote-ftp
apm install remote-ftp

Thanks @icetee for the suggestion. However, it didn't seem to help. Same error message as before. :(

Did you try that?

Still getting
Failed to require the main module of 'Remote-FTP' because it requires one or more incompatible native modules (binding, binding, binding, binding, binding, binding).
Run `apm rebuild` in the package directory and restart Atom to resolve.

I've tried leaving Atom open and running (in the Remote_Ftp dir) rm -rf node_modules, apm rebuild. It didn't work but I didn't look for the error.
Quit Atom, ran apm remove remote-ftp, app install remote-ftp. Restarted and checked the console and got above error. Ran app rebuild. Same error. rm-rf node_modules and app rebuild. node_modules folder didn't come back. On macOS 10.11.6

I've tried all of the above "solutions". I'm still getting:
Failed to require the main module of 'Remote-FTP' because it requires one or more incompatible native modules (binding, binding, binding, binding, binding, binding).
Run `apm rebuild` in the package directory and restart Atom to resolve

@blacRose @iktw @nicolasroger17
Have you seen the original solution?
https://github.com/icetee/remote-ftp/issues/839#issuecomment-309366257
If it does not work then try it apm rebuild-module-cache

Just tried it. Still no.

Just tried it. Still no.

Can I look at Team Viewer?
(Email address in my profile)

It's my work laptop, I don't have the permission to do that sorry.
I can give you more logs if you tell me how to get to them.

Please try this
CMD + Shift + P (Commad palette) and type Incompatible packages and try to there build again

Incompatible Packages
Some installed packages could not be loaded because they contain native modules that were compiled for an earlier version of Atom.Rebuild Packages
Package Settings
Remote-FTP 1.1.1

binding@unknown – Cannot find module '/Users/blabla/.atom/packages/Remote-FTP/node_modules/fsevents/lib/binding'
binding@unknown – Cannot find module '/Users/blabla/.atom/packages/Remote-FTP/node_modules/fsevents/lib/binding'
binding@unknown – Cannot find module '/Users/blabla/.atom/packages/Remote-FTP/node_modules/fsevents/lib/binding'
binding@unknown – Cannot find module '/Users/blabla/.atom/packages/Remote-FTP/node_modules/fsevents/lib/binding'
binding@unknown – Cannot find module '/Users/blabla/.atom/packages/Remote-FTP/node_modules/fsevents/lib/binding'
binding@unknown – Cannot find module '/Users/blabla/.atom/packages/Remote-FTP/node_modules/fsevents/lib/binding'

There is a rebuild button there. Try it when done you will have a restart button.

Now it's throwing when I launch atom.
Error: Cannot find module 'fs-plus'
at Module._resolveFilename (module.js:455:15)
at Module._resolveFilename (/Applications/Atom.app/Contents/Resources/electron.asar/common/reset-search-paths.js:35:12)
at Function.get_Module._resolveFilename (/Applications/Atom.app/Contents/Resources/app/src/module-cache.js:354:58)
at Module.require (file:///Applications/Atom.app/Contents/Resources/app/static/index.js:40:43)
at require (/Applications/Atom.app/Contents/Resources/app/src/native-compile-cache.js:66:33)
at Object. (/Users/nicolas/.atom/packages/Remote-FTP/lib/remote-ftp.js:11:15)
at Module.get_Module._compile (/Applications/Atom.app/Contents/Resources/app/src/native-compile-cache.js:106:36)
at Object.value [as .js] (/Applications/Atom.app/Contents/Resources/app/src/compile-cache.js:239:29)
at Module.load (module.js:473:32)
at tryModuleLoad (module.js:432:12)
at Function.Module._load (module.js:424:3)
at Module.require (file:///Applications/Atom.app/Contents/Resources/app/static/index.js:47:45)
at require (internal/module.js:20:19)
at customRequire (/Applications/Atom.app/Contents/Resources/app/static/:96:26)
at Package.module.exports.Package.requireMainModule (/Applications/Atom.app/Contents/Resources/app/src/package.js:887:35)

Okay, now the node_modules folder is missing / deficient.
apm uninstall remote-ftp
apm install remote-ftp

Sweet. It's working now. Thx.

Sweet. It's working now. Thx.

Cheers!

Shift-Command-P, Incompatible Packages, and Rebuild Packages worked for me, too. Many thanks from the ice cream gallery.

I close this issue. The 2.0.0 version supported Atom Filesystem Watcher. No need for chokidar package.


fix(android): error compilation from ccde819

There is a compilation error for Android integrated with commit ccde81
Here is a fix for the compilation

Thanks @RignonNoel!


How to test client-unsupported commands via client.Do()

It seems as though there is no way to test code which uses client-unsupported commands via:
client.Do(ctx, "cmd", ...args)
There definitely seems to be no example and I see no Issues filed which mention it, and there is no immediately obvious way to set an expectation for an arbitrary Cmd when looking at the source code.  This prevents testing of any code which uses a custom redis module to provide commands not natively supported by the redis client, which seems like a relatively common use case, so I'm wondering if this is an oversight in the documentation and example code?

I should elaborate - my code actually uses a pipeline to execute multiple custom commands.
	cmd := pipe.Do(ctx, "CL.THROTTLE", req.key, req.maxBurst, req.limit, req.period*time.Second, 1)

which is eventually executed via:
	cmders, err := pipe.Exec(ctx)

Given the example code for testing pipeline, I would imagine that if Do() were supported, pipelining Do() would also be supported by setting an expectation for each pipelined command.


API v2

Right now our v1 API is based on OpenAPI 2.0, and could really use some reorganization and standardization:

Endpoint re-naming, re-categorization
Field standardization: There's camel case and snake case all over the API, we should stick to one, and be consistent with variables that are reused. My preference is camelCase
Definition reorganization. OpenAPI 3.0 would allow us to organize our API definitions a lot more efficiently. This has downstream dependencies though: connexion update and probably others

I've looked into updating to OpenAPI 3.0 without a specific v2 bump of the API and there is non-trivial work to support that in connexion and our API stack. I think we should track a move to OpenAPI 3.0 independently of an update to our API. Both could occur at the same time but there is no strict dependency


networkminer: init at 2.8

Description of changes

The Open Source Network Forensic Analysis Tool (NFAT) https://www.netresec.com/?page=NetworkMiner
Closes #233414
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

@KCynk would you please test let me know if you run into any issues :)

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-already-reviewed/2617/999


Drb implementation with Celluloid

These days I was looking into DRb & it's a really cool library to work. Any ideas to improve DRb with Celluloid? I created some sample Client Server applications using DRb @digitalextremist

Where is your sample code?
Both DCell and ECell go far beyond DRb, but were lightly inspired by it.

I have created a sample ChatServer & a ChatClient
I thought ECell is a extended version of DRb


detectindent doesn't use indent_size from settings plugin when restoring a workspace at startup

I'm not sure whether this is the correct repository for this issue. It's the result of an interaction between the settings plugin here and the detectindent and workspace plugins in the main repository, and it's not obvious to me that any one plugin is doing anything wrong.
I've set tab_type = 'hard' and indent_size = 4 through the settings plugin's UI, which means that they're stored in user_settings.lua, not init.lua. When Lite-XL starts up (or reloads), and workspace reopens my files from before, any files that are detected as using tabs end up rendering those tabs at the default width of 2 spaces instead of the 4 spaces that I specified. If I close one of those files and reopen it, or open another file that uses tabs, it uses the correct width.
It looks like what's happening is something like:

core.init is called.

config is filled with default values.
My init.lua is loaded, but doesn't do much of anything yet because I've been using the settings plugin instead.
settings plugin loads (priority 0).

It replaces core.run with its own wrapper function.
It reads user_settings.lua, but does not merge it into config yet. indent_size still has its default value of 2.

detectindent plugin loads.

It hooks into Doc.

workspace plugin loads.

It replaces core.run (which is actually settings's wrapper) with its own wrapper function.

core.run (actually workspace's wrapper) is called.

workspace opens the documents from last time.

detectindent does its thing, using the still-default value of indent_size.

workspace then calls the 'original' core.run (actually settings's wrapper).

settings merges the values from user_settings.lua into config.

indent_size is finally set to 4, but the documents that have already been opened don't know that, and keep using the 2 that detectindent returned earlier.

settings calls the original core.run (probably the real one this time).

Running Lite XL 2.1.1 (macOS, 'addons' package), with whatever versions of those plugins are included.

I guess a simple solution for now would be for the workspace core plugin to save the indent style on exit, and restore it on load.
Sadly the settings plugin needs to do some hacks to work, and those don't always work.
I'll move this to core, as a feature request to have workspace save the indent style (maybe it could also save things like the language plugin currently being used).


Updated core version

@rultor release, tag is 0.1.5

@rultor release, tag is 0.1.5

@pollyvolk OK, I will release it now. Please check the progress here

@rultor release, tag is 0.1.5

@pollyvolk Done! FYI, the full log is here (took me 7min)


Add logging expected errors

Description

Change to log the expected errors.
Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have added tests to cover my changes.
[x] All new and existing tests passed.

Do these need to be logged? mod.js:20 packageUtil:80

I think they should be logged in the file which uses them.
It would be better for them to throw errors.


[Authorization] Missing permission for voting

The current version of the "web backend" service allows any user to vote as long as they are logged-in through EPFL's SSO "tequila".
This doesn't match the requirements, as each election will require a different set of users who are allowed to vote depending on the election.
A new permission "Can vote" is needed on the object level.
So a user A should have a "can vote" permission on form/election "X".
This will also modifications to the current Authorization framework as it's not currently configured to allow object-level permissions.
ToDo:

[x] Add a "can vote" permission on an object level.
[x] Add ability to assign a user a "can vote" permission on a specific election/form from the CLI
[x] Validate that logged-in user has "can vote" permission on an election/form before allowing the user to vote on an election/form.

Extra:

[ ] Use the 3 roles Admin, Operator, Voter in the backend using Casbin library

Note:
We use the Casbin library to implement Authorization

Last item is still not done yet!

From your experience already, do you think this is completed now, or should we do something else?

@ineiti @PascalinDe Do you think this is completed now, or should we do something else?

I'll close this, further improvements will be in new tickets


Store s3 bucket region on form

What problem does this pull request solve?
Trello card: https://trello.com/c/ToXPf8zb/
When using the AWS SDK for Ruby, it is required to provide the bucket region. If the region is different to the region the bucket was created in, we get the following error:
Aws::s3::Errors::PermanentRedirect - The bucket you are attempting to access must be addressed using the specified endpoint. Please send all future requests to this endpoint.
Add a column s3_bucket_region to the forms table to store the region for the S3 bucket to send form submission data to.
Things to consider when reviewing

Ensure that you consider the wider context.
Does it work when run on your machine?
Is it clear what the code is doing?
Do the commit messages explain why the changes were made?
Are there all the unit tests needed?
Has all relevant documentation been updated?

haven't run the rake task or checked against a bucket but the code looks good - I think we might want to consider a SubmissionType class in future...

Yeh we're adding quite a lot onto the form now. If/when we revisit this, it might be worthwhile.


feat(BTable)!: add multisort capabilities

Describe the PR
This is an update to #1835 with some progress.

I believe I have multisort working and reasonably documented (and added in the 'complete example' that I've been using for testing.
I've fixed the build errors, although there is an issue with BLink that I think might be a more fundamental problem.  But I don't use BLinks in the router scenario, so don't have enough of a sense of what's going on to understand the intent.
I have not fixed all of the tests.  I believe there is a fundamental issue with how defineModel works that is breaking the tests and causing other issues.

On the defineModel issue, it looks like the model isn't getting defined as expected.  I believe this may be the same issue that I saw in #1822 - According to the vue docs:

In dev mode, the compiler will try to infer corresponding runtime validation from the types. For example here foo: String is inferred from the foo: string type. If the type is a reference to an imported type, the inferred result will be foo: null (equal to any type) since the compiler does not have information of external files.

In dev mode I'm seeing errors like this: [Vue warn]: Invalid prop: type check failed for prop "modelValue". Expected Boolean, got Array for things like BFormCheckbox
And if I move the type declaration of BFormCheckboxProps into BFormCheckboxVue I get an error on the when using defineModel - `Duplicate key 'modelValue'. May cause name collision in script or template tag.
I've actually tried reverting back to useVModel  and the tests still fail.  Also trie reverting the versions of dependencies in package.json  I must be misunderstanding something about how the system builds/works because I would expect the combination of those two actions to get back to passing tests.

On multisort, there were a couple of bugs in the existing implementation, and I'm not 100% certain that I kept the spirit of what @VividLemon intended.  But I documented what I implemented, so hopefully, it's close enough and should be more obvious what the intent is if you want to move in a different direction.
The one thing I didn't do that I think might be worthwhile is to allow sortBy to be a single BTableSortBy value when multisort == false .  I think that would be somewhat more ergonomic for a developer to consume.
Small replication
A small replication or video walkthrough can help demonstrate the changes made. This is optional, but can help observe the intended changes. A mentioned issue that contains a replication also works.
PR checklist

What kind of change does this PR introduce? (check at least one)

[ ] Bugfix :bug: - fix(...)
[ ] Feature - feat(...)
[ ] ARIA accessibility - fix(...)
[ ] Documentation update - docs(...)
[ ] Other (please describe)

The PR fulfills these requirements:

[ ] Pull request title and all commits follow the Conventional Commits convention or has an override in this pull request body This is very important, as the CHANGELOG is generated from these messages, and determines the next version type. Pull requests that do not follow conventional commits or do not have an override will be denied

Closing -- commits pulled into https://github.com/bootstrap-vue-next/bootstrap-vue-next/pull/1842


src: added support for collections

This commit suggests adding support for getting
photos from collections.
Ref: https://github.com/unsplash/unsplash-source-js/issues/6

@dusansimic nice. Do you think you could add some tests here covering the collections?

Just wrote the tests.
Also added a small fix. Typo while copying the code.

Looks great thanks @dusansimic 👍


Cleanup DataType

Cleans up the DataType enum which I noticed could be simplified while investigating another issue.

Codecov Report

Merging #8214 (d44bbfc) into master (916d807) will decrease coverage by 8.38%.
The diff coverage is 91.89%.

@@             Coverage Diff              @@
##             master    #8214      +/-   ##
============================================
- Coverage     71.02%   62.64%   -8.39%
+ Complexity     4314     4232      -82
============================================
  Files          1626     1614      -12
  Lines         84929    84634     -295
  Branches      12783    12749      -34
============================================
- Hits          60325    53015    -7310
- Misses        20462    27724    +7262
+ Partials       4142     3895     -247

Flag
Coverage Δ

integration1
28.69% <0.00%> (-0.10%)
:arrow_down:

integration2
?

unittests1
67.34% <91.89%> (-0.05%)
:arrow_down:

unittests2
?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

...main/java/org/apache/pinot/spi/data/FieldSpec.java
82.41% <91.89%> (+1.02%)
:arrow_up:

...t/core/plan/StreamingInstanceResponsePlanNode.java
0.00% <0.00%> (-100.00%)
:arrow_down:

...pinot/controller/recommender/io/ConfigManager.java
0.00% <0.00%> (-100.00%)
:arrow_down:

...ore/operator/streaming/StreamingResponseUtils.java
0.00% <0.00%> (-100.00%)
:arrow_down:

...troller/recommender/io/metadata/FieldMetadata.java
0.00% <0.00%> (-100.00%)
:arrow_down:

...roller/recommender/rules/impl/BloomFilterRule.java
0.00% <0.00%> (-100.00%)
:arrow_down:

...oller/api/resources/PinotControllerAppConfigs.java
0.00% <0.00%> (-100.00%)
:arrow_down:

...ler/recommender/data/generator/BytesGenerator.java
0.00% <0.00%> (-100.00%)
:arrow_down:

...ager/realtime/PeerSchemeSplitSegmentCommitter.java
0.00% <0.00%> (-100.00%)
:arrow_down:

...er/recommender/io/metadata/SchemaWithMetaData.java
0.00% <0.00%> (-100.00%)
:arrow_down:

... and 284 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 916d807...d44bbfc. Read the comment docs.


No function for HFSS toolkit finite array beam angle calculator option in pyAEDT

Description of the current limitations

There isn't a way to use this GUI ability with pyAEDT
Code sample expected
No response
Useful links and references
No response

@libt-pyint  This is a python toolkit. It is not part of the AEDT API.
BUT, recently PyAEDT added a new set of farfield classes, which includes some of these capabilities.
https://aedt.docs.pyansys.com/version/stable/API/Visualization.html#farfield
For instance, if you have 3DComponent array, you can use this method and once you have the ffdata change the taper algorithm, the phase and magnitude of each element... everything computed in python:
https://aedt.docs.pyansys.com/version/stable/examples/02-HFSS/Array.html#sphx-glr-examples-02-hfss-array-py


[WIP] Fix random presto ut failure

Why is this PR needed?
What changes were proposed in this PR?
Does this PR introduce any user interface change?

No
Yes. (please explain the change and update document)

Is any new testcase added?

No
Yes

Build Failed  with Spark 2.4.5, Please check CI http://<IP_ADDRESS>:12602/job/ApacheCarbon_PR_Builder_2.4.5/3917/

Build Failed  with Spark 3.1, Please check CI http://<IP_ADDRESS>:12602/job/ApacheCarbon_PR_Builder_3.1/64/

Build Success with Spark 2.3.4, Please check CI http://<IP_ADDRESS>:12602/job/ApacheCarbonPRBuilder2.3/5661/

retest this please

Build Failed  with Spark 2.4.5, Please check CI http://<IP_ADDRESS>:12602/job/ApacheCarbon_PR_Builder_2.4.5/3922/

Build Success with Spark 2.3.4, Please check CI http://<IP_ADDRESS>:12602/job/ApacheCarbonPRBuilder2.3/5666/

Build Success with Spark 3.1, Please check CI http://<IP_ADDRESS>:12602/job/ApacheCarbon_PR_Builder_3.1/70/

retest this please

Build Success with Spark 2.3.4, Please check CI http://<IP_ADDRESS>:12602/job/ApacheCarbonPRBuilder2.3/5668/

Build Success with Spark 2.4.5, Please check CI http://<IP_ADDRESS>:12602/job/ApacheCarbon_PR_Builder_2.4.5/3924/

Build Success with Spark 3.1, Please check CI http://<IP_ADDRESS>:12602/job/ApacheCarbon_PR_Builder_3.1/72/

retest this please

Build Success with Spark 2.3.4, Please check CI http://<IP_ADDRESS>:12602/job/ApacheCarbonPRBuilder2.3/5674/

Build Failed  with Spark 3.1, Please check CI http://<IP_ADDRESS>:12602/job/ApacheCarbon_PR_Builder_3.1/78/

Build Success with Spark 2.4.5, Please check CI http://<IP_ADDRESS>:12602/job/ApacheCarbon_PR_Builder_2.4.5/3930/

Build Failed  with Spark 2.3.4, Please check CI http://<IP_ADDRESS>:12602/job/ApacheCarbonPRBuilder2.3/5675/

Build Success with Spark 2.4.5, Please check CI http://<IP_ADDRESS>:12602/job/ApacheCarbon_PR_Builder_2.4.5/3931/

Build Success with Spark 3.1, Please check CI http://<IP_ADDRESS>:12602/job/ApacheCarbon_PR_Builder_3.1/79/


VNext

Hello,
Do you plan to create a VNext client config extensions?

Yes, we have an open issue that is tracking it here: https://github.com/exceptionless/Exceptionless.Net/issues/28 We've been waiting for rc2 tooling before starting. We have been talking about this in our slack channel as well (please join us http://slack.exceptionless.com). With the recent decision of project.json and tooling we need to make sure we do the right work so we don't do something that won't be supported come end of June.
I'm going to close this as it's a duplicate of https://github.com/exceptionless/Exceptionless.Net/issues/28. I do know there is a third party pull request out there for this right now and we are working with them :).

Also, you should be able to use exceptionless today if you target the full clr of asp.net core (if you can't please let me know).

Sounds like a plan. Sorry, I missed the other ticket, I searched for "vnext." Will try the approach and let you know.


Ensure that effective min resolution is never higher than max resolution

Fix #10508

I agree that it is kind of ugly to sprinkle this check everywhere but I'm not sure your suggestion would work, as the View's multiWorld/extent options resolve to different maxResolution depending on the map size and that can be contolled by the user by resizing the browser window.
If you resize the map in the provided codesandbox the first map's View works fine once the map is small enough and the world does fit within the resolution constraint.

@MoonE Thanks for the explanation. I understand the problem now. What about clamping the resolutoin to the range from this.minResolution_ to this.maxResolution_ in View#getConstrainedResolution?
To verify the result, a unit test would also be great.

The way I implemented it here is that  extent / multiWorld is the 'winning' constraint if there is a conflict, because I think it is more important if set. With your suggestion there would be some wrap around / parts outside the configured extent visible on conflict, which could be seen as a bug itself.

I implemented your suggestion here (with added example from codesandbox), though it is not enough to fix the problem:
https://github.com/MoonE/openlayers/tree/view-zoom-glitch2

Thanks for that branch @MoonE. After #10865, the situation is different now. Maybe this allows for a more straightforward fix?

It might also be worth looking into #10892 when addressing this.

#10862 introduced a number of conflicts with these changes.  I've pushed a rebased, conflict-free version of your commits in 64a2f3681f32c21a2bda78b46ab9e2b1d749c7e9.
If you want to use this commit, you can do this:
git fetch openlayers
git reset --hard 64a2f3681f32c21a2bda78b46ab9e2b1d749c7e9
git push --force origin view-zoom-glitch

Thanks @tschaub


chore(tlsversion) : Add a minimum tls version in webhooks

Description:
Update controller-runtime to v0.10.2 and add a tls minimum version fro
webhooks
fixes #4165
Signed-off-by: Sneha Chhabria<EMAIL_ADDRESS>Affected area:

Functional Area

New Functionality
[ ]

CI System
[ ]

CLI Tool
[ ]

Certificate Management
[ ]

Control Plane
[ ]

Demo
[ ]

Documentation
[ ]

Egress
[ ]

Ingress
[ ]

Install
[ ]

Networking
[ ]

Observability
[ ]

Performance
[ ]

SMI Policy
[ ]

Security
[ ]

Sidecar Injection
[ ]

Tests
[ ]

Upgrade
[ ]

Other
[X]

Please answer the following questions with yes/no.

Does this change contain code from or inspired by another project? no

Did you notify the maintainers and provide attribution?

Is this a breaking change? no

Why is controller-runtime being updated? Is this a dependency to update the TLS version? If not, please keep this PR scoped to TLS version changes.

Yes it is, please refer to this issue for more details : https://github.com/openservicemesh/osm/issues/4165

Why is controller-runtime being updated? Is this a dependency to update the TLS version? If not, please keep this PR scoped to TLS version changes.

Yes it is, please refer to this issue for more details : #4165

We do not use controller-runtime for TLS, it's just used for creating JSON patches and hence there should be no dependency on updating controller-runtime in a PR that suggests the TLS version is being fixed.
Please make the controller-runtime change in a separate PR if necessary, as I do not believe it is related to TLS in any way.

I'd like to see this PR split up and scoped to the TLS version updates.
I don't believe controller-runtime needs to be updated, even though the issue suggests to update it, because we do not use controller-runtime other than for patching JSON.
Could you split this up and isolate this change to be specific to TLS config updates? Else it's just confusing to review.

I've updated this PR to just update the controller runtime, I will send the TLS min version in a follow up PR


project does not compile

need to upgrade to
testCompile "org.mockito:mockito-core:2.2.26"

Hi. Can you explain what you mean by "project does not compile"? It seems to be working fine for me with the latest stable version of Android Studio?


datapath: remove fakedatapath

As a follow up of #34250 that removed the datapath abstraction, this commit removes the corresponding fakedatapath.

/test


Update xcode 9.4

Motivation: Fix Xcode Project Settings Warnings
Test Plan
Should still build and pass all tests since project settings changes should be safe changes.
Related PRs
No documentation change is required
Release Notes
[IOS][MINOR][XcodeProjs] Upgraded Project settings to be compatible with Xcode 9.4

Warnings

:warning:

:clipboard: Release Notes - This PR may have incorrectly formatted Release Notes.

  Generated by :no_entry_sign: dangerJS

@hramos Thanks for helping out! I'm not exactly sure what is going on with the e2e ios_e2e tests--would appreciate any input you can provide.

@wangjoshuah rebasing should fix those e2e failures.


"Position:Fixed" inside off-canvas-content? (v6.3)?

Not sure this issue has been addressed but has anyone noticed a problem with fixed position elements or (.sticky) inside of the off-canvas-content? It seams that any fixed position element does not stay in place after the canvas has been opened (if inside the content area). Once opened, the fixed positioned element inside the content area moves in respect to the scroll position and is no longer visible if the position is set to "top:0".
The example below demonstrates the issue. If you scroll down a bit before opening the menu you can see the drop in nav will disappear.
EXAMPLE HERE
Is there anyway to achieve a fixed element when the off-canvas-content is both open and closed?

@jinch thanks for the bug report. I'm going to close this as its a duplicate of #9629 but please keep an eye on that issue, as @colin-marshall and myself are going to try and get a fix into the next release (fingers crossed!).


Poorly behaved on *_test files

I have been running interfacer with neomake whenever I save a golang file. This has been working fine, until I attempted to edit a _test.go file, where I recieved the following error:
$ interfacer smlr/http_test.go
smlr/http_test.go:22:12: undeclared name: HTTPWaiter

(where HTTPWaiter is declared in `smlr/http.go). Many other tools handle this discrepancy well, I wonder if interfacer could.
Unfortunately, I can't tell you what version of interfacer this is:
$ interfacer --version
flag provided but not defined: -version
Usage of interfacer:
  -v	print the names of packages as they are checked

Here is my neomake configuration, if that helps:
let g:neomake_go_interfacer_maker = {
    \ 'errorformat': '%f:%l:%c: %m'
    \ }
let g:neomake_go_enabled_makers = ['go', 'golint', 'govet', 'interfacer']

Interesting. I'll look into this, thanks!

Are you sure linters should be used this way? I've checked a few other linters, including @dominikh's unused, and most of them error. Or at least those using go/types like this one.

Tools such as unused or interfacer care about the whole package (they have to, in order to type-check it). Passing individual files to them will not work. Tools that do support it either only look at the AST (gofmt) or are fine with partial type information (go vet).

This is what I was thinking. Something we could do, though, is replace any number of source files with their package (in this case .) then only produce warnings for the wanted files. We're still parsing the whole package, but at least we'll be skipping the unwanted files from the fileset.

You can do that (buildutil.ContainingPackage), but be aware of these two use cases: having a single-file "package" that's not in a GOPATH at all, and specifying multiple files to explicitly omit files from a package. The former is much more common and easy to handle. I don't know how common the second use case is. It can probably be disregarded (though that'll mean that behaviour differs from, say, go build)

We already handle the first one, don't we?
I'm inclined to close this as wontfix, or rather, "can't fix in a way that doesn't overcomplicate things"`

If you switched to doing "replace any number of source files with their package" like you suggested, then you'd need to handle the first case explicitly, as that file won't have an import path.

I'm going to go with the lazy approach and not consider fixing this at the moment.


Task - Filter sources - Add batch update functionality

I need to add a lot of serials, and I do it manually one record in a time. I would like to use the batch update, similar to Geographic Area add to Collecting Event.

Just a thought that this one is significantly more dangerous/consequential as it hits Community data.

Yes, but in most cases I do restrict searches to the project only. As a bare minimum, I would need an option to open all selected sources as individual tabs, instead of using radial for each of them individually.

Serial update exists.
@jlpereira can we add another slice 'Author'.  There we can select authors as per role picker in create.  It needs a big bold warning "Updating in this fashion will delete all other Author information for this record, ensure all Authors in the source are in this list.".  Require a confirmation.


Enable SDL tools

Here's a test build: https://dev.azure.com/dnceng/internal/_build/results?buildId=2548198&view=results

Here's a test build: https://dev.azure.com/dnceng/internal/_build/results?buildId=2548198&view=results

There were various failures.

Looks like we need to add the config file for TSA.

Added the TSA options and scheduled another build: https://dev.azure.com/dnceng/internal/_build/results?buildId=2550292&view=results

All green, let's merge!


consider all optional brackets when splitting

I'm not married to this solution, I put it together in half an hour. This will likely cause some code churn, but hopefully for the better.
TODO:

[ ] fix tests
[ ] verify formatting changes on a (few?) large codebase(s)
[ ] add changelog
[ ] better commit message

Fixes #781.

Pull Request Test Coverage Report for Build 996

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at ?%

Totals

Change from base Build 989:
0.0%

Covered Lines:

Relevant Lines:
0

💛  - Coveralls

I'm running it on our code now. A couple of things I noticed:
-from qcore.asserts import assert_eq, assert_dict_eq, assert_is, assert_unordered_list_eq
+from qcore.asserts import (
+    assert_eq,
+    assert_dict_eq,
+    assert_is,
+    assert_unordered_list_eq,
+)

Here the old line was exactly 88 characters long. I'm guessing we add the parentheses, that pushes it over 88 chars, and then we split it into multiple lines. This issue is causing a lot of churn in our codebase.
-    assert isinstance(value, return_type), (
-        "Value is not in one of the exepected types. Type: %s. Value: %r"
-        % (type(value), value)
+    assert isinstance(
+        value, return_type
+    ), "Value is not in one of the exepected types. Type: %s. Value: %r" % (
+        type(value),
+        value,
     )

Here the old formatting seems better to me.

This diff shows more clearly that the optional parens are pushing the line over the limit:
-                    for experiment, settings in exp_settings.future_experiments.items():
+                    for (
+                        experiment,
+                        settings,
+                    ) in exp_settings.future_experiments.items():

The old line length was again exactly 88.
Also overall impact:
1559 files reformatted, 8134 files left unchanged.

I updated this PR with another iteration on this idea, which hopefully causes significantly less churn, and gets some pathological cases right. There are still two bugs to figure out though.

I tried it out again on our codebase. Here's a few notes:
                             assert (
                                 component[0] in VALID_DIRECTIVES
-                            ), "invalid directive %r" % (component,)
+                            ), ("invalid directive %r" % (component,))

These are just useless parens.
-        ] = self.detector.get_busy_time_proportion(None, time_us)
+        ] = (self.detector.get_busy_time_proportion(None, time_us))

Same here.
-        if not set(column_renames.keys()).issubset(columns_to_drop) or not set(
-            column_renames.values()
-        ).issubset(columns_to_add):
+        if (
+            not set(column_renames.keys()).issubset(columns_to_drop)
+            or not set(column_renames.values()).issubset(columns_to_add)
+        ):

This is great.
-            z += h.Button(
-                class_=["ui", "button"],
-                id="clear-search-button",
-                onclick="resetFilter()",
-            )(h.text("Clear"))
+            z += (
+                h.Button(
+                    class_=["ui", "button"],
+                    id="clear-search-button",
+                    onclick="resetFilter()",
+                )(h.text("Clear"))
+            )

Another unnecessary set of parentheses added.

Also in terms of churn the effect is similar:
2289 files reformatted, 10702 files left unchanged, 6 files failed to reformat.
The crashes are due to instability. IThe first pass is:
                 "share_data"
-            ] = yield a.app.view.share.mobile.get_native_share_action.asynq(share)
+            ] = (yield a.app.view.share.mobile.get_native_share_action.asynq(share))

And the second is:
-            data[
-                "share_data"
-            ] = (yield a.app.view.share.mobile.get_native_share_action.asynq(share))
+            data["share_data"] = (
+                yield a.app.view.share.mobile.get_native_share_action.asynq(share)
+            )

The eventual result is an improvement though. The other crashes are also cases where the first pass adds parentheses, and the second one rearranges the structure of an assignment + yield.

This latest one seems promising.
Most of the changes follow this pattern:
-        if not self.ignore_interrupt and isinstance(
-            sys.exc_info()[1], KeyboardInterrupt
+        if (
+            not self.ignore_interrupt
+            and isinstance(sys.exc_info()[1], KeyboardInterrupt)
         ):

Some asserts have changed as well:
-        assert isinstance(
-            types, collections.Iterable
-        ), "types must be iterable, is %r" % (types,)
+        assert isinstance(types, collections.Iterable), (
+            "types must be iterable, is %r" % (types,)
+        )

The most questionable changes are around manually split strings:
-        sql = "INSERT INTO status_type (type_name, seq)  " "VALUES ('{}', {})".format(
-            key, val
+        sql = (
+            "INSERT INTO status_type (type_name, seq)  "
+            "VALUES ('{}', {})".format(key, val)
         )

All in all, I think this PR makes the formatting better, so ready for review.

As for the amount of churn: on a codebase with half a million LOC across 3k+ files this PR generates
41 files changed, 188 insertions(+), 151 deletions(-)

I ran it on our codebase again. This one is a little questionable:
     def table_string(self):
-        return "%5d  %5d  %5d  %5d  %5d  %5d  %5d  %5d  %5d  %5d" % (
-            self.task_count,
-            self.delete_count,
-            self.suspend_count,
-            self.call_count,
-            self.send_count,
-            self.throw_count,
-            self.return_count,
-            self.cancel_count,
-            self.pause_count,
-            self.resume_count,
+        return (
+            "%5d  %5d  %5d  %5d  %5d  %5d  %5d  %5d  %5d  %5d"
+            % (
+                self.task_count,
+                self.delete_count,
+                self.suspend_count,
+                self.call_count,
+                self.send_count,
+                self.throw_count,
+                self.return_count,
+                self.cancel_count,
+                self.pause_count,
+                self.resume_count,
+            )
         )

On the other hand there are similar cases to this where the tuple after % fits on one line and it looks nicer, so maybe this is the price we have to pay.
This still inserts unnecessary parens:
         assert email_type not in {
             aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa,
             aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa,
             aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa,
-        }, "should not have xxxxxxxxxxxxxxxxxxxxxxx %s" % (email_type)
+        }, ("should not have xxxxxxxxxxxxxxxxxxxxxxx %s" % (email_type))

Overall impact: 604 files reformatted, 12022 files left unchanged.
I agree that most of the changes now are improvements, so I'd be OK with applying it (except for the unnecessary parens in the second diff snippet above).

I tried hard to remove the unnecessary parens you highlight, but I realized this is a bug that's better addressed in a separate issue. I'm reasonably sure the root cause is the same as with this one:
Black on master does this:
-        assert looooooooooooooooooooong in { looooooooooooooooooooooooooooooooooooooooooooooooooooooong}, "wot. a bug?!" % loooooooong
+        assert looooooooooooooooooooong in {
+            looooooooooooooooooooooooooooooooooooooooooooooooooooooong
+        }, ("wot. a bug?!" % loooooooong)

@zsol - I read your comment about fluent interfaces and came here to check this PR out. Could you share an example or two of how this PR might improve the formatting of fluent-style programs?
My team heavily uses Pandas, Apache Spark, and SQLAlchemy, so we are writing code in this style all the time. I would be very happy to see any improvements to how Black handles this style of code, since it would make it easier for me to sell Black to my team.

Rejected in favor of #1092. Maybe we'll revisit the approach in the future.


The same token/coin but in different currency

I recently attempted to host a coin, such as bitcoin, in both USD and EUR, but realized that only the USD ticker would work, and the EUR ticker would not because there is already a ticker named bitcoin in USD.
Is there a way to make this work? The only way I can think of is to run two instances, one for USD and the other for EUR.

@kakigorimochi yes you will need to run a second instance of the program to have multiple cryptos with different currencies.
This is due to using the name of the coin as the key in the database https://github.com/rssnyder/discord-stock-ticker/blob/master/ticker_request.go#L177

Hello @rssnyder, thank you for getting back to me.
I successfully set it up by repeating the steps I took to set up my first instance, with the exception of using a different port and adding "-eur" to the discord-stock-ticker and the service file.

discord-stock-ticker-eur.service

[Unit]
Description = discord-stock-ticker-eur
. . .
[Service]
SyslogIdentifier = discord-stock-ticker-eur
. . .
ExecStart = /etc/discord-stock-ticker/eur-instance/discord-stock-ticker-eur -address=localhost:8081 -frequency=10 -db=/etc/discord-stock-ticker/profile/instance-eur


Add Open Source Dependency Scan Report

Add license violation scanning and dependency vulnerability scanning.

@richiesebastian can we add those in github actions?

Added.


Send push notification from external client

It's possible to send push notification from outside power apps using some API?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: f2f754f6-4b2b-b1c8-6b84-f74f578821c8
Version Independent ID: 20df624c-87eb-0347-89f5-ef1d84b395af
Content: Send a push notification - Power Apps
Content Source: powerapps-docs/maker/canvas-apps/add-notifications.md
Service: powerapps
GitHub Login: @Kavishi
Microsoft Alias: kaagar

Thank you for reaching out. Available services for Power Apps Notifications:  Power Automate and Power Apps. More information: https://docs.microsoft.com/connectors/powerappsnotification/. For more help or to investigate an issue, please use Power Apps community forum or reach out with a support ticket.


test: utility methods for integration testing

Description
Utility methods for integration testing
Type of change
Please delete options that are not relevant.

[x] New feature

How Has This Been Tested?
Run python script on Nova instance and verified that requested changes were reflected in Kubernetes cluster
Checklist

[x] My commit message is conventional
[x] I have run pre-commit on all files before creating the PR
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[x] I have checked my code and corrected any misspellings

Codecov Report

Merging #407 (c86f806) into develop (56eb63f) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop     #407   +/-   ##
========================================
  Coverage    86.92%   86.92%
========================================
  Files           23       23
  Lines         1400     1400
========================================
  Hits          1217     1217
  Misses         183      183

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 56eb63f...c86f806. Read the comment docs.


feat: add bulk operation for resource updates

This PR...
Changes

Fixes

How to test it

Screenshots

Checklist

[ ] tested locally
[ ] added new dependencies
[ ] updated the docs
[ ] added a test

Also, this still doesn't work with the new feature of getting only the current select namespace resources and we have to fix it


why caliptra cpu can't exit from idle?

when I send a mailbox cmd from soc to caliptra, the notif_cmd_avail_sts bit has changed to 1 and mbox csr also can find the cmd. but according to my debug log, caliptra stay in idle and not exit from this state. if I use JLINK to halt and go, then this maibox cmd can go ahead and succeed.
caliptra stay below code, any other reg can be use to debug?

Can you confirm

What RTL version you are using?
What firmware you are using & how you are building it
What kind of environment you are using the run the tests (FPGA, verilator, some other simulation environment?)


Updated code to use the provided constant value instead of the hard-coded 3.

A constant was declared for the number of events to send, numEvents, replaced the 3 with the constant.

@mattruma : Thanks for your contribution! The author(s) have been notified to review your proposed change.

#sign-off


Refactor IrodsDataRequest creation/update

I seem to have ran into another yak shaving session here.. In IrodsDataRequestCreateView and IrodsDataRequestUpdateView, we do a lot of model updating stuff in form_valid(), when it should be done in the form instead. This was also the cause of #1864. I'll refactor when I have a bit of spare time.
It seems something similar also happens in the IrodsAccessTicket views, to be investigated.

Similar to #1907, postponing this to v1.0 as it's a purely internal refactoring thing.


Feature Request: Ring gradient delay correction

I would like to have a gradient delay correction for radial sampling in MRPro.
It assumes that the "dc" component of each spoke lies on an ellipse around the true dc k/space center and sovles a linear system to found the ellipse parameters.
(This might also help with possible confusion where exactly the k-space center is in the spokes in certain cases if we include a possible shift of the ellipse).

https://arxiv.org/abs/1805.04334

See also https://github.com/ckolbPTB/PtbPyRecon/blob/master/PTBRecon/Extensions/source/ring/ring.c (BART)


Document Cache Module

I noticed that the cache module doesn't have documentation, opening this issue as a notification of intent
see #5 for more details

Great! If you have any questions, please feel free to reach out.
The point of the scope feature is to manage the life of an item in memory when two different scenes want to use it. This could be a scene, and then a component. Or maybe something managed by the developer.
We don't want to load and unload the item repeatedly if it is still in use. So each process tries to "claim" the item in the cache. Doing so adds a "reference" that it is in use. It only gets cleaned up when all the refs go to zero.
The :global scope basically says to ignore all that and keep it in memory all the time.

@boydm should the items get cleared once refcount hits 0, or should we periodically be sweeping for 0 refcount items and clearing them as we get around to them?
Or am I misunderstanding how this should be working?


Zero all malleable fields before execution

Closes #542.
Also changes tx.receiptsRoot to only be updated after the tx has terminated, as the intermediate values are no longer useful. The speeds up and simplifies implementation of receipt-pushing opcodes.

Maybe it makes sense to remove the getter for malleable fields since they are zero all the time. We don't need to change the discriminant for values, we can leave gaps

Before merging this PR, I would suggest doing https://github.com/FuelLabs/fuel-core/issues/1620 first. It will help identify all problematic fields. Maybe we missed something here

CI not passing due to https://github.com/FuelLabs/fuel-specs/issues/547

For future reference, removing the intermediate receipt roots is possible now that we are going with a zk-hybrid proving approach.


Navbar styling

Requirement
There are currently 3 dropdown menus in the navbar - live events,join our community and the hamburger dropdown menu. Make the items inside the dropdown menus more beautiful and colourful.

I am interested in the issue. please assign this issue to me

I can solve this issue  , Assign me this role

i can solve this issue in 1 hour and even making it responsive, so please assign it to me if you want it done asap.


Bug: Typo in manifest

The latest version is showing as unknown compatibility because you have "verfied" instead of "verified" in the compatibility field.

Thanks for your report ! I just release version <IP_ADDRESS> which fix this typo.


chore: Add patch for Ayn Loki refresh rates in gamescope

This needs gamescope-session-plus edit in device-quirks to works, removing the panel being forced as external
If not it does nothing, so no harm done.

Thank you!


snipaste-beta: Update to version 2.7.1-Beta

Relates to #367

[ ] I have read the Contributing Guide.

Since my personal computer system crashed and I just initialized the system, the local environment has not been configured yet, so this Pr may not necessarily meet the project contribution specifications. I am sorry for it, because I don't have much time.
If possible, the owner is welcome to help me edit it，thank you very much!

Since my personal computer system crashed and I just initialized the system, the local environment has not been configured yet, so this Pr may not necessarily meet the project contribution specifications. I am sorry for it, because I don't have much time.
If possible, the owner is welcome to help me edit it，thank you very much!

/verify

/verify

/verify

/verify


Crash on Application.Quit after tilting

If I call Application.Quit() any time after having tilted (Cardboard.SDK.Tilted was true), then the app will crash with dialog "Unfortunately, -app- has stopped.".
If I haven't ever tilted, the app will quit without error.
Occurs in both our main project and an empty project consisting of just a camera.
Cardboard SDK v0.5.2
Unity 4.6.3p3
Android 4.4.2

Can confirm this, always wandered what caused this crash in my app, just tested it and found it to be the same.
Using Cardboard SDK 0.5.2 as well and Unity 5.2.3, Android 5.

The most likely cause is referring to "Cardboard.SDK" after the Cardboard object has been destroyed.  This can happen when unregistering the OnTilt event handler, for instance.  This is a definite bug that will be fixed in an upcoming release.  If this sounds like what is happening to you, avoid using the guilty Cardboard events for now.  If it is not the cause, then... more investigation is needed.  Is it easy to massage a test case?

Simple test case:
Create a new 3D project, add Cardoard to the camera, and add a script with the following update function:
void Update () {
        if (Time.realtimeSinceStartup > 10)
        {
            Application.Quit();
        }
}

Perform a tilt before it quits and observe crash.

Reproduced.  Interestingly you have to tilt the phone to the right.  This means it is not just an orientation change, but something to do with the OnTilt gesture specifically.

Just to note: I wonder it there could be some bad interaction with the
gesture that triggers experience exiting in the official cardboard app...
Le mar. 15 déc. 2015 08:48, smdol<EMAIL_ADDRESS>a écrit :

Reproduced. Interestingly you have to tilt the phone to the right. This
means it is not just an orientation change, but something to do with the
OnTilt gesture specifically.
—
Reply to this email directly or view it on GitHub
https://github.com/googlesamples/cardboard-unity/issues/125#issuecomment-164676015
.

Happens to me as well. I can use my app and if I don't tilt and just look around slowly it will work but if I tilt the cardboard and move it around fast then disable and re-enable it, the app will crash. I have tried instantiating the CardboardMain prefab and Destroying it each time but I don't think that is the best practice. Also I removed my quit button because application.quit would crash the app as well..
Any updates on this issue?
Thanks for your time.

Yes, the update is that the problem is down in the native code that monitors the sensors.  It has to be fixed there for an upcoming release.  It is being worked on.

Thank you sir, appreciate the update! :)

Looking forward to this fix!

v0.6 is out, and fixes the problem -- or rather, bypasses it.  The downside is that we had to stop reporting the "tilt" event.  If you are using Cardboard.SDK.Tilted or OnTilt, they will no longer report anything.  If you need this functionality, you can use Input.accel to implement it in C#.


WalletInfo dialog - ux/enhancement - Add 3 more important buttons to the dialog

Copy the address
Open on the block explorer
Disconnect

These are very common options of account dialogs on all the major platforms (Uniswap, sushiswap, pancakeswap, etc).
Here is Uniswap for example:

P.S:
I also believe the dialog is a bit big at the moment and could be smaller, but not the main topic of this issue. Something in the clean UI you can see in the screenshot I shared would be awesome IMHO

Just to add the prioritization IMHO:
Disconnect is by far the most important one.
Without it, the Dapp is forced to find a good place to have a disconnect button outside of rLogin, which is not a great experience.
Having it in the account info dialog is the perfect place and then the Dapp won't need to do anything around having a disconnecting button