Worldwide button on explore location chooser is broken right after you give permissions

Describe the bug
Right after granting location permissions on explore, for some reason, the worldwide button doesn't work. but it works when you navigate away from explore and come back
To Reproduce
Steps to reproduce the behavior:

On a fresh install of inat next, click the explore tab
Allow location access and let nearby suggestions load
tap "nearby" in the header to open the location chooser
tap the worldwide button, and notice how nothing happens (try as many times as you'd like)
tap to any other screen, then return to the explore tab
tap "nearby" in the header to open the location chooser
tap the worldwide button, and notice how it loads worldwide properly

Expected behavior
the worldwide button in the location chooser should work immediately after granting location permissions and loading nearby suggestions.
Context (please complete the following information):

iPhone 13 Pro, iOS 17.5.1, 0.40.0 (108)

I can't replicate this so I think it was fixed in the interim, maybe as a part of #1961


Create patch/content/secondary (based on feature/body) branch.

Create patch/content/secondary

Done!


[release-1.18] Fix traffic to terminating headless services

Manual cherrypick required.
#47379 failed to apply on top of branch "release-1.18":
Applying: Fix traffic to terminating headless services
Using index info to reconstruct a base tree...
M	pilot/pkg/model/endpointshards.go
M	pilot/pkg/model/service.go
M	pilot/pkg/serviceregistry/kube/controller/endpointslice.go
M	pilot/pkg/xds/eds_test.go
A	pilot/pkg/xds/endpoints/endpoint_builder.go
Falling back to patching base and 3-way merge...
CONFLICT (modify/delete): pilot/pkg/xds/endpoints/endpoint_builder.go deleted in HEAD and modified in Fix traffic to terminating headless services. Version Fix traffic to terminating headless services of pilot/pkg/xds/endpoints/endpoint_builder.go left in tree.
Auto-merging pilot/pkg/xds/eds_test.go
CONFLICT (content): Merge conflict in pilot/pkg/xds/eds_test.go
Auto-merging pilot/pkg/serviceregistry/kube/controller/endpointslice.go
Auto-merging pilot/pkg/model/service.go
Auto-merging pilot/pkg/model/endpointshards.go
CONFLICT (content): Merge conflict in pilot/pkg/model/endpointshards.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Fix traffic to terminating headless services
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

https://github.com/istio/istio/pull/47590

fixed


Dropdown more than one dropdown-toggle not work

If a dropdown contains more than one dropdown-toggle, only one work. Can this be improved? Here is the plunker

Questions of this nature belong on Stackoverflow, see the FAQ section here. You will need to prevent the click handler from bubbling up, see this forked plunk here.


R7xx

Made a comment on re4hd mentioning how R7xx could be connected to EM_LIST_BIO5 found in the PS2 symbols:
https://www.re4hd.com/?p=9649#comment-202588
Also made another comment there but not sure if it went through, maybe blog software/anti-spam swallowed it up:

Might have found a definite link between R7XX & BIO5, looks like that EM_LIST enum is actually included in the executable too as strings (you can even find them in the UHD exe):

Seems to match with all the EM_LIST entries I posted before, except BIO5 is changed to "biox" there, guess they probably didn't want it to show up as a string in the EXE :p
BIO5/biox are at index 9 into the list, seems there's also a function "checkEmListNo" in the game which takes a room number and returns the list index for it - you can maybe guess where I'm heading :)
Anyway, for room 6xx & 7xx:

So 6xx falls under 18 PS2ETC/ps2-tgs, and 7xx is under 9 BIO5/biox, pretty neat!
My guess is that maybe RE5 was being prototyped on the RE4 engine during the time between GC & PS2 release, and the files for that prototype ended up being left inside the RE4 source tree (original devs probably knew they could remove them before shipping the final PS2/Wii builds, but luckily for us X360/PS3 was done by a new team 😄)

Also found out that EM_LIST_BIO5 is tied to the emleon09.esl file, on GC/UHD that file seems to just contain enemies for some R1XX rooms, but the PS2 version of emleon09.esl actually seems to have enemies linked to both R703 & R702! Might be worth exploring some more once we can load in the R7XX maps properly.

The emleom09.esl file is also present in the gamecube version, in which there were no St5,6,7 yet. Judging by the IDs of the enemies and their subtypes, we can conclude that this file was saved in a very early build of RE 4.
This file was last modified no later than the American trial version.
For example, the value 15 01 spawns a ganado in a blue shirt,
already in the Japanese trial version, it was replaced by a female ganado with the identifier 15 0B, so the value 15 01 does not exist in the final version. The same can be said about other enemy IDs, for example, 16 00 in this file is not a ganado, but another unknown enemy type.
In earlier versions of RE 4, each individual ganado had its own unique ID. Ganados were later grouped into groups within the same archive with the same ID, but sometimes old enemy IDs are mentioned in the game.
Let's say the textures and folders of opponents in the PS2 version are numbered according to the old enemy numbering.


Rightclick to add sites does not work in Vivaldi

扩展版本 (extension version): 1.3.8
浏览器版本 (browser version): Vivaldi 1.15.1147.64 (Stable channel) (32-bits)
操作系统 (operating system): Windows 10 Pro
问题描述 (problem description): can not ad tabs to list with right click
实际行为 (actual behavior): no menu with "store tabs"
期望行为 (expected behavior): extended menu to store tabs
重现步骤 (reproduce step):

I can confirm this behavior still exists
扩展版本 (extension version): 1.4.5
浏览器版本 (browser version): Vivaldi 2.5.1525.46 (Stable channel) (64-bit)
操作系统 (operating system): Windows 10 Pro
问题描述 (problem description): Cannot add tabs to list with right click
重现步骤 (reproduce step): Right click extension icon
实际行为 (actual behavior): There is no menu item with "store tabs"
期望行为 (expected behavior): There is an extended menu, with store tabs as one option. This is the behavior on Chromium on KDE Neon (based on Ubuntu Linux).


Fixed inconsistencies and bugs in types + added missing fields

This PR fixes various inconsistencies in types.
It also adds missing fields summarized in #23.

@MaximeHeckel can you check this?

Hey @pilwon sorry for the delay, I'll check your changes

It's merged on staging see 59bd3bf9f237f72bd860f5fb6066f7b277ccbfbd

@MaximeHeckel :+1:


Update flags.py

I think that manifestparser belongs in flags.py as well. It is part of the "moz" suite of software that is listed in flags.py. See http://mozbase.readthedocs.io/en/latest/ and https://github.com/chhantyal/py3readiness/issues/22

Thanks


API code not received

I'm trying to obtain api code but is not getting responded because it require an URL, and I don't have any . What to do?

They discontinued the original API 1st Jan 2016 so you have to sign up via a different address: https://api.blockchain.info/v2/apikey/request/
Note that we had to submit 3 times and put in a support ticket to get a response

But they are asking for url of website or application? SO what should be specifies. As my website is not online yet


Sliders Number Problem

Hi. Flutter is a great project. But I came across something strange while using sliders. The numbers are rolling. Is this normal? I created it as a double. However, this sounded very strange. Is it normal to round the numbers?
https://i.ibb.co/yfD7FBp/sliderxcf.jpg
double sliders = 1;
        Text("Selected Sliders"),
        Slider(
          min: 0,
          value: sliders,
          max: 100,
          onChanged: (value) {
            setState(() {
              sliders = value;
            });
          },
          divisions: 100,
          label: sliders.toString(),
        ),

All done!
[✓] Flutter: is fully installed. (Channel stable, 1.20.4, on Linux,
locale tr_TR.UTF-8)
[!] Android toolchain - develop for Android devices: is partially
installed; more components are available. (Android SDK version
30.0.2)
[✓] Android Studio: is fully installed. (version 4.0)
[!] Android Studio: is partially installed; more components are
available.
[✓] Connected device: is fully installed. (1 available)

Hi @erenalpt,
What issue are you seeing exactly ? The screenshot you shared doesn't reveal much. I tried the official Slider example and was able to see the number slide properly without any issues.
Thanks.

Hi @erenalpt,
What issue are you seeing exactly ? The screenshot you shared doesn't reveal much. I tried the official Slider example and was able to see the number slide properly without any issues.
Thanks.

Yes it is slipping. It just doesn't increase 1 to 1. I think it should go 28-29-30. But it looks like 28.xxxxx instead of 29 as in the picture. This happens at intervals, not for every number.  I am using the Genymotion emulator.

@erenalpt I don't see the number slipping. Tested on latest beta using Slider official example as mentioned above.
66341.mov.zip
Can you try on a physical device and see if you get same behavior ? Also please try the Slider official example.
Thanks.

e
I'll look at the slider image example. Why am I facing such a situation with the above code. I wonder this.

Video:
https://streamable.com/sj0rzq

e
I'll look at the slider image example. Why am I facing such a situation with the above code. I wonder this.

Video:
https://streamable.com/sj0rzq

I tried it on Xiaomi Mi 8. I still have the same problem with the video. No code errors. Because my code, flutter is the same as the official document.

I am unable to replicate the issue on devices I tried, but it seems to be happening on certain devices. Keeping this issue open for further analysis.

I am unable to replicate the issue on devices I tried, but it seems to be happening on certain devices. Keeping this issue open for further analysis.

Devices I have tried: Xiaomi mi 8, Mi 8 lite (physical device ), and genymotion emulator Google Pixel (API 28 - 9.0), Nexus 4 (API 19 - 4.4), Amazon Fire HD 10 (API 28 - 9.0).

@erenalpt
Revisiting this issue, I used Sliders example running with latest stable version and on Pixel XL api 33 emulator with which I didn't observe the reported behavior. Can you please try the same at your end on listed devices you mentioned using latest stable to check if the behavior still persist or not ?


Add logging env variable to enable console logs

When used as external package it may be annoying getting console.logs while development

Could we also add the new variable to wrangler.toml so theres a default configuration for those not using as a library?

Sorry for the delay; thanks for the PR!


[SPARK-16628][SQL] Translate file-based relation schema when file schema is inconsistent with catalog schema

What changes were proposed in this pull request?
We will convert Metastore Orc tables (represented by MetastoreRelation) to datasource tables (represented by HadoopFsRelation) if spark.sql.hive.convertMetastoreOrc is enabled for better performance.
However, due to a Hive issue, an Orc table created by Hive does not store column name correctly in the Orc files. For these Orc tables, the converted relation has wrong schema.
To fix this, we assume the metastore schema dataSchema can match to physicalSchema by each column disregarding the column names. If not, we throw an exception that suggests users to disable the conversion of Hive Orc tables.
How was this patch tested?
Jenkins tests.

Test build #62875 has started for PR 14365 at commit f9fab59.

Test build #62880 has started for PR 14365 at commit cc953a3.

Test build #62875 has finished for PR 14365 at commit f9fab59.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/62875/
Test FAILed.

Test build #62880 has finished for PR 14365 at commit cc953a3.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/62880/
Test PASSed.

cc @cloud-fan @yhuai @liancheng @rxin Please review this change. Thanks.

Test build #62993 has started for PR 14365 at commit 0c17748.

Test build #62993 has finished for PR 14365 at commit 0c17748.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/62993/
Test PASSed.

Merged build finished. Test PASSed.

cc @yhuai @liancheng @rxin

@rxin @yhuai , is it worth adding this complex logic to work around this hive bug? This feature(convert Metastore Orc tables to data source table) is not a major feature and the broken case seems a corner case. I think it's ok to disable this feature when we meet this hive bug, what do you think?

@cloud-fan I've submitted a PR #14282 previously that disables the conversion if the schema is inconsistent.

Test build #63214 has started for PR 14365 at commit 5cfdff1.

Test build #63214 has finished for PR 14365 at commit 5cfdff1.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/63214/
Test PASSed.

@cloud-fan So do we have decision on this? A simpler approach to disable the conversion if the schema is inconsistent, or a complex one to work around this Hive bug?

ping @cloud-fan Can you have a decision about this? Are we going to have complex logic for this issue? Or just disable it?

I noticed that spark.sql.hive.convertMetastoreOrc is false by default, so this bug is not so critical.
And we may stop inferring file schema when reading ORC tables, for performance reasons(#16980), then we don't have the chance to detect the mismatch and disable this feature.
We may remove this feature entirely, or thinking harder to come up with a better fix. cc @yhuai

@cloud-fan actually, this conversion was disabled because of this bug.
btw, pr that @cloud-fan mentioned is https://github.com/apache/spark/pull/14690.
I think it is better to hold this change before we finish https://github.com/apache/spark/pull/14690.

Hi, @viirya , @cloud-fan , @yhuai .
#14690 and the parent issue SPARK-17861 seems to be resolved?
What about restarting this issue?

As we replace schema inferring with metastore schema completely by #14690 for converted Hive tables, we may not have the chance to detect the mismatch between Orc file's physical schema and metastore schema.

It seems to exist some cases like the following (on the current master).
On hive,
CREATE TABLE t1 (a string) PARTITIONED BY (b string) STORED AS ORC;
INSERT INTO TABLE t1 PARTITION (b='01') VALUES ('1');

On spark-shell,
scala> sql("select * from t1").show
+---+---+
|  a|  b|
+---+---+
|  1| 01|
+---+---+

scala> sql("set spark.sql.hive.convertMetastoreOrc=true").show
+--------------------+-----+
|                 key|value|
+--------------------+-----+
|spark.sql.hive.co...| true|
+--------------------+-----+

scala> sql("select * from t1").show
16/12/07 05:17:19 ERROR Executor: Exception in task 0.0 in stage 2.0 (TID 2)
java.lang.IllegalArgumentException: Field "a" does not exist.

@dongjoon-hyun yeah, I see. Because we directly use metastore schema of converted Orc table, when the physical schema in Orc file and metastore schema mismatch, this issue happens.

We have two options. First one is to map metastore schema to physical Orc schema like this. But we don't infer physical schema of Orc file now. I will update this to have this mapping in OrcFileFormat.
Another one is like #14282. But as we don't infer schema from Orc file now, we can't disable the conversion when the mismatch is detected. One possible is to throw exception in OrcFileFormat when detecting the mismatch before reading and show message to ask user to disable spark.sql.hive.convertMetastoreOrc.
@cloud-fan @yhuai @dongjoon-hyun What do you think?

Test build #69852 has started for PR 14365 at commit 2bb8368.

@cloud-fan @yhuai @dongjoon-hyun I've updated this as:

Assume metastore schema matches with physical Orc schema by column, disregarding column names.

Mapping required schema to columns in physical Orc schema.

If the length or data types of metastore schema and physical schema is not matched, throw an exception suggesting users to disable spark.sql.hive.convertMetastoreOrc.

Please let me know what you think about this approach. Thanks.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/69852/
Test FAILed.

retest this please.

Test build #69856 has started for PR 14365 at commit 2bb8368.

Test build #69856 has finished for PR 14365 at commit 2bb8368.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/69856/
Test PASSed.

Merged build finished. Test PASSed.

It looks good to me. Thank you for updating, @viirya !

ping @cloud-fan @yhuai May you take a look? Thanks.

Test build #70336 has started for PR 14365 at commit 141cb1d.

Test build #70336 has finished for PR 14365 at commit 141cb1d.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/70336/
Test PASSed.

Merged build finished. Test PASSed.


Add viAlias/vimAlias to options

Currently, this module does not supply options to provide viAlias and vimAlias. I saw that in https://github.com/NixNeovim/NixNeovim/blob/main/nixneovim.nix#L251 you enable the builtin neovim modules of home manager or nixos. Since both provide said options, could you expose them through the NixNeovim module? That would be great!

Implemented in #5e47f27.
Thanks for reporting

Thank you for adding these options in such a short amount of time!


Fix Zero pointBorderWidth still drawing border

This PR fixes the fact that a pointBorderWidth property of zero still draws a border around the point. It does this by checking if the pointBorderWidth is zero. If yes, it changes the stroke of the point to be completely transparent.
Before with a zero width red point border:
https://codepen.io/anon/pen/xpNbbN

After with a zero width red point border:

The PR description says "it changes the stroke of the point to be completely opaque". I'm guessing you meant "transparent" instead? Why draw it transparently instead of just not drawing it at all?

@jhaenchen just a reminder that there are some outstanding comments / questions on this PR that need your attention

@jhaenchen a reminder to take another look at this PR when you get a chance

@jhaenchen do you think you'll be able to update this PR? If not, we may close it as inactive

@benmccann I'll take a look tonight, sorry.

@jhaenchen just a quick reminder that there are some comments on this PR and the other one you have open as well

I'm guessing you meant "transparent" instead?

Yep, sorry.

Why draw it transparently instead of just not drawing it at all?

As far as I can tell, you cannot set a stroke width of zero, and so no matter what you have a stroke when drawing a point. Therefore, in order to draw the point, we also have to draw the stroke, so the next best thing is a completely transparent stroke.
Also, I've fixed your other comments. Thank you for your patience!

@benmccann would you like me to add that to this PR?

Yes, that would be great if you can do that

@jhaenchen would you be able to address Simon's comments?

@jhaenchen just a reminder that there's a comment that will need to be addressed before we can merge

@jhaenchen this PR will need to be rebased. Don't forget about Simon's comment either. We'd love to get this merged

@jhaenchen we'd love to merge this, but haven't gotten any response, so are going to close this PR as inactive. Please let us know if you're able to find the time to revisit and we can reopen this and work with you to get it in


net/tcp: add support for send timeout on buffer mode

Summary
net/tcp: add support for send timeout on buffer mode
Signed-off-by: chao.an<EMAIL_ADDRESS>Impact
N/A
Testing
iperf test

Depends on: https://github.com/apache/incubator-nuttx/pull/5524 https://github.com/apache/incubator-nuttx/pull/5525


Replacement for find scheduling conflicts or lack of resources feature

Legacy scheduling engine has a function that can tell witch bookings are not supported by resources any more or if there are resource conflicts or overbooking. For example if resource calendar has changed, or some equipment is out of order. New engine can't show "resource availability status" for existing booking so can't be positioned as a replacement for "legacy" engine.

@FixRM can you please mention which documentation topic you are referring to ?

@susikka Sorry, it's my fault: https://docs.microsoft.com/en-us/dynamics365/customer-engagement/customer-service/basics-service-service-scheduling#configure-entity-records-in-the-new-scheduling-experience.

@FixRM This seems like product feedback rather than documentation issue to me. Suggest that you raise this on https://experience.dynamics.com/ideas so Service scheduling feature team can respond to it.
Closing this issue. Feel free to reopen in case of any other clarifications.


Add pull request id

upload_pull_request_id@617 aka 20201106.6 vs master ewma over 50 builds from 464 to 615


Custom Visual Effects

@shogo4405  How VisualEffect works, can I register an effect while streaming and the video will be processed with that filter? Can I make my own VisualEffects?
Thanks in advance

How VisualEffect works

use GLLFView
RTMPStream.registerEffect(video YourEffects())

try Exsampe-iOS :)

can I register an effect while streaming ....

Yes.

Can I make my own VisualEffects?

Yes. Please see https://github.com/shogo4405/lf.swift/blob/master/Examples/iOS/VisualEffect.swift#L64
This VisualEffects architecture is CIFilter base. see also https://developer.apple.com/reference/coreimage/cifilter

@shogo4405 I will check it out and let you know. Thanks for your hard work.

Hey @shogo4405, the example uses the last version of the framework in Swift 3.0. Is there any way to test it in 0.4.1 version or including the visual effects into my current project so i can use Monochrome and Panorama effects?

oh... 0.4.x branch is here https://github.com/shogo4405/lf.swift/tree/0.4.x

VisualEffect Examples 0.4.x is here. https://github.com/shogo4405/lf.swift/blob/0.4.x/Examples/iOS/VisualEffect.swift#L64

git checkout 0.4.x


TOC not working

I have a working toc in my Google Document. When I place links to these headings in my google document they correctly send me to the right headings. However when I render the document to HTML (and use the 'Use HTML Headings/IDs') I get errors.

undefined internal link to this URL: "#heading=h.y0b8p6b0ylvv".link text: ....
?Did you generate a TOC with blue links?

Can you share a doc that shows this behavior?
Note: if you don't generate the TOC with the blue links, Docs to Markdown cannot pick up the link IDs. I don't believe the Use HTML Headings/IDs option makes any difference.


Replace .theme-one-dark-ui with .theme-one-light-ui

Replace .theme-one-dark-ui class with .theme-one-light-ui

@iryston Thanks for the PR, but the use of the .theme-one-dark-ui class isn't a typo.
The reason it's in here is because most files in the dark and the light version are identical. That makes it easier to update both. There are a few places where the styling should be a little bit different and for those places the .theme-one-dark/light-ui class gets used to target only one version.
Hope that makes sense.

@simurai thanks for the answer.
I regret for my carelessness.
Best regards.

No problem. It probably isn't that obvious.


View/Format > View As > Epoch Time (etc.) does not work on Results tab

When using View/Format > View As > Epoch Time on the Results tab, instead of getting the dialog to select the date format, I get the following menu, which is not valid for the context:

I am unable to view any ints as epoch time in this or any view other than the Table Data view, and my column preferences on the Table Data view are not persisted to the Results view.
This also affects all other items under the View As menu
On Mac OS High Sierra

I can't reproduce this (on MacOS  Sierra).
Maybe this happens only in certain circumstances. According to context menu I assume you are viewing results of custom SQL query + have extra results tab. Any other details?
Some short video maybe?

OK, I figured out how to reproduce it.  The issue occurs when the schema for the script is different than the schema that the tables actually live in and no schema is specified on the tables in the query.  For example, in our production database, there is a schema for my user, and a schema called SP.  If the script is set to execute in my personal schema, but no schema is specified on the table, somehow the query still executes (I'm not exactly sure how), but the date Epoch Date settings are not respected, and I am unable to access the View As > * menus.  If I switch the schema to the proper schema OR if I specify the schema in the query, it works as expected.  Granted, this is probably not a typical use case.  I'm not even sure exactly how it is looking up the correct table without the proper schema selected.
The following combination DOES NOT work as expected:

The following two combinations DO WORK as expected:

As you can see from the above screenshots, which I just noticed, as well, the foreign key hyperlinks are also not working properly in the first example.

Also, the above context menu

Maximize results panel
Set tab title

Appears whenever any other context menu is dismissed from the Results tab.  You can reproduce it by simply right clicking on any value in the Results tab, and then left clicking anywhere else on the screen to dismiss the context menu.

"View as" settings are saved per-table. If DBeaver can't properly resolve table (because schema is not specified) then settings aren't working. Not sure how exactly Oracle finds this table. Maybe this is a clue and we could use the same way in DBeaver.
Context menu problem is a known issue (#2864). It is Eclipse bug and it will be fixed once we'll migrate to Eclipse 4.8 (version 5.1.4 I guess).

OK, I now know how Oracle is finding these tables.  They are set up as synonyms in the other database.  So, the query is actually going against the synonym.  It seems DBeaver is not aware of these synonyms.
CREATE OR REPLACE NONEDITIONABLE PUBLIC SYNONYM "SPT_WORK_ITEM" FOR "SP"."SPT_WORK_ITEM";

Thanks for investigating this. Indeed DBeaver didn't check for Oracle synonyms.
Will be fixed in the next version.


Have the output summary be optional, and just generate a list of the errors as the default

Assume we just want to see errors and not the summary. Ties into #271.
OPTIONS:
    -s, --summary                    Show a small list detailing the query results.

So, the summary would not be shown by default?

Probably it can depend on whether STDOUT is a terminal or not, so show the summary by default, when it is a terminal, hence most likely an interactive call, and hide it otherwise, when it is most likely a CI call or similar, where indeed often errors are all that is needed. But then -S, --no-summary could be required as well, consequently 🤔.
-s, --scheme <scheme>... btw reserves that short form already. Probably -q, --quite serves as a common alternative?

Alternatively we could tie that into the verbose option: -v would give you the full status output, while by default it wouldn't. Not sure if I like that solution. 😅

Jep, through about that, then moving output for each checked link to next verbosity level -vv, but somehow a summary behind a verbose flag feels wrong. Especially on interactive calls usually one expects some output to know that the command did something 🙂.

So, the summary would not be shown by default?

The final summary table would not be shown. Valid links and what not would still be in the output.

There is a new, compact output format, which only shows a single summary line; see https://github.com/lycheeverse/lychee/pull/375.
Does that work for you? If not, we can add a --format=quiet or --format=raw option, which would get rid of the final status line as well. It would be an easy thing to do, but it depends on your use-case.

Ah, I re-read the original issue at #271. You mention machine-readable output. I guess --format=raw could work in this case and there is also --format=json.

Having both options available would be nice.

Summary for future reference:

[ ]  Add format=raw which skips the summary output.


Adding audio directly from code

Closes #85

This is great!! Could we now add the README example with music generation tho? 🥺

LGTM 🙏🏻 😎


USE RES.JSON INSTEAD OF RES.SEND

USE RES.JSON() INSTEAD OF RES.SEND()
Type of issue:

[x] Bug / Error
[ ] Idea / Feature
[x] Improvement detail

res.json() includes json.stringyfy which is a more preferable way for JSON in express

PR SENT

PR #125  Solved!!


Typescript definitions - move type definitions to separate file?

Because type definitions use export assignment, it's not possible to use any of the types explicitly. However, if classes and interfaces were moved out to separate file, it would be possible - although it a bit of a non standard way.
As an example, it could look something like this:
types/index.ts
import { IPublishPacket, ISubscribePacket, ISubscription, IUnsubscribePacket } from 'mqtt-packet'
import { Duplex } from 'stream'
import EventEmitter = NodeJS.EventEmitter

export enum AuthErrorCode {
  UNNACCEPTABLE_PROTOCOL = 1,
  IDENTIFIER_REJECTED = 2,
  SERVER_UNAVAILABLE = 3,
  BAD_USERNAME_OR_PASSWORD = 4
}

export interface Client extends EventEmitter {
// and so on, basically every other type exported from original index.d.ts

types/aedes.d.ts
/// <reference types="node" />

import { AedesOptions, Aedes } from './';

declare function aedes (options?: AedesOptions): Aedes

export = aedes

package.json
"types": "types/aedes.d.ts",

It could then be used like this:
import { Aedes } from "aedes/types";
import aedes = require('aedes');

let aedesInstance: Aedes;
aedesInstance = aedes()

I don't think it will break anything for users that use implicit typing already and it does allow explicit typing. I can prepare a pull request with it - just let me know if you open for such change.

After more digging I found this template which is way better way to achieve explicit typing with a single file. I'll close this issue and try to use an approach from this template.


chore: update readme with note about setKeepAlive

Fixes #18 by adding a warning to the README about unexpected behaviour of setKeepAlive() which causes empty messages to be passed to the piped stream if only one side of the connection calls setKeepAlive(). This can cause crashes in consuming streams, e.g. using Hypercore if one peer replicates with core.replicate({ keepAlive: false }) but the other peer replicates with core.replicate(), then it will result in a crash in Protomux due to the empty buffer being received.

Thx! Removed the mux part as thats easily solvable


AzureFileCopy@4 - Incorrect content type when copy file to azure storage blob in pipeline

Question, Bug, or Feature?
Type: Bug
Enter Task Name:  AzureFileCopy@4
Environment

Server - Azure Pipelines

Agent - Hosted
Pool: Azure Pipelines
Image: windows-latest
Agent: Azure Pipelines

Issue Description
Using AzureFileCopy@4 to copy MS office files(docs. excel, ppt) content type been incorrectly set as "application/zip"
Pipeline Task

Blob Content type

Task logs

Our task internally uses azcopy.exe and automatically setting content-type is feature provided by azcopy
https://docs.microsoft.com/en-us/azure/storage/common/storage-ref-azcopy-copy#advanced
we don not set content-type in task

Our task internally uses azcopy.exe and automatically setting content-type is feature provided by azcopy
https://docs.microsoft.com/en-us/azure/storage/common/storage-ref-azcopy-copy#advanced
we don not set content-type in task

Is that means bug in azcopy itself?
Standalone azcopy in local pc, copying the file with correct content-type. When its been used with pipeline it is getting incorrect.

Fixed the issue with below ref:
https://github.com/microsoft/azure-pipelines-tasks/pull/15594


net/http/httptest: http.Response.ContentLength not set in httptest.ResponseRecorder.Result()

Please answer these questions before submitting your issue. Thanks!
What version of Go are you using (go version)?
go1.7
What operating system and processor architecture are you using (go env)?
n/a.
What did you do?
If possible, provide a recipe for reproducing the error.
A complete runnable program is good.
A link on play.golang.org is best.
See https://play.golang.org/p/pWT6IMacni.
What did you expect to see?
Expected the Response.ContentLength to be set. Since a bytes.Buffer is used for recording the response body, the content length can be set using Buffer.Len.
What did you see instead?
As seen in https://github.com/golang/go/blob/master/src/net/http/httptest/recorder.go#L143-L188, the Response.ContentLength is never set.
I could write a patch if it would be accepted.

/cc @bradfitz


Text Extractor does not work on multiple screen setup.

Microsoft PowerToys version
0.69.1
Installation method
Microsoft Store
Running as admin
No
Area(s) with issue?
TextExtractor
Steps to reproduce
I have window open and spreads across two screen.  Text Extractor only activates on the primary screen and not the secondary screen.
✔ Expected Behavior
That all screens would allow Text Extractor to function.
❌ Actual Behavior
Screen only greys and activates TextExtractor on the primary screen.
Other Software
No response

For any software developer planning to fix/enhance Text Extractor, See Also: #25197

@TheJoeFin weren’t you looking into this?
would seeing how the monitors are laid out / DPis be helpful?

Yes I am looking into this

@thejoefin is this https://github.com/microsoft/PowerToys/issues/21676?

@crutkas I think it is probably the same issue

I face the same issue when I switch to NVIDIA GPU only mode in Advanced Optimus as the NVIDIA GPU is detected as a secondary monitor. Also faced this in dual monitor setup.

/dup #21676


"Delete" does not delete attachments

Seems like if you delete a page, the attachments should also get deleted, as that page is the access point for those attachments.

Closed in 0774329.


windows-latest workflows will use Windows Server 2022

Breaking changes
Windows Server 2022 is ready to be the default version for the "windows-latest" label in GitHub Actions and Azure DevOps.
Target date
This change will be rolled out over a period of several weeks beginning on January, 17. We plan to complete the migration by March, 6.
The motivation for the changes
Starting from November 2021 Windows Server 2022 with Visual Studio 2022 image is generally available for all customers. We have monitored customer feedback to improve the Windows Server 2022 image stability and now we are ready to set it as the latest.
Possible impact
⚠  CodeQL does not currently support analysis of compiled languages on Windows Server 2022 ⚠ Support for Windows Server 2022 has been added.
The Windows Server 2022 image has a different set of software than Windows Server 2019. The most significant changes are listed in the table below:

Tool name
Windows-2019
Windows-2022
Notes

Go lang
1.15.*
1.16.*
Go lang version bumped to the more recent one

Python
3.7.*
3.9.*
Python version bumped to the more recent one

Ruby
2.5.*
3.0.*
Ruby version bumped to the more recent one

Google Cloud SDK
latest
-
The software was removed due to maintenance concerns, consider using the official action https://github.com/google-github-actions/setup-gcloud

Innosetup
latest
-
The software was removed due to its low popularity and maintenance concerns

Parcel
latest
-
The software was removed due to its low popularity and maintenance concerns

Cloud Foundry CLI
latest
-
The software was removed due to its low popularity and maintenance concerns

Java
8(default)111317
8(default)1117
Due to our software guidelines we left only LTS versions on the image. If you need to use other versions of Java, consider using setup-java and Java tool installer tasks

Python toolcache
<IP_ADDRESS>.<IP_ADDRESS>
<IP_ADDRESS>.10
EOL python versions were removed

PyPy toolcache
<IP_ADDRESS>.8
<IP_ADDRESS>
Version 3.6 was deprecated as it won't receive any updates

Ruby toolcache
2.42.5(default)<IP_ADDRESS>
2.73.0(default)
Left only two recent versions

MySQL
5.7.*
8.0.*
The version was updated to the latest major one

.NET
<IP_ADDRESS>
3.15.0
Version 2.1 is EOL and was removed

Windows Driver Kit
10.0.*
-
VS2022 is not yet supported by the WDK

Az powershell module
1.0.0.zip1.6.0.zip2.3.2.zip2.6.0.zip3.1.0.zip3.5.0.zip3.8.0.zip4.3.0.zip4.4.0.zip4.7.0.zip5.5.0.zip5.9.0.zip6.5.0
6.5
Left only the most recent 6.* release

Android SDK build-tools and platforms
19 - 32
27 - 32
Android Platforms and build tools < 27.0 were removed from image. Consider installation in runtime using sdkmanager

Virtual environments affected

[ ] Ubuntu 18.04
[ ] Ubuntu 20.04
[ ] macOS 10.15
[ ] macOS 11
[ ] Windows Server 2016
[X] Windows Server 2019
[X] Windows Server 2022

Mitigation ways
If you see any issues with your workflows during this transition period:

File an issue in this repository
Switch back to windows-2019 by specifying the windows-2019 label in your workflow. We will continue to support Windows Server 2019 image.

Are there any known actions to install innosetup?

Are there any known actions that we can use to install innosetup?

Nah, I don't think that's possible from actions.

@tt2468 innosetup can be installed relatively fast in runtime. Please feel free to ask for help if needed

Why this was not done on the day of formally releasing visual studio 2022?
I always assumed Microsoft would follow the literal definition of 'latest' -  silly me.

What about LTS .NET 6.0?

@neman 6.0 is bundled in VS2022, so it's available on the image but not installed via part of .NET installation script

@miketimofeev  Shouldn't the list be updated to reflect net6.0 being available?

I'm seeing this warning

##[warning]windows-latest pipelines will use windows-2022 soon. For more details, see https://github.com/actions/virtual-environments/issues/4856

In all of my Windows pipelines, but none of my pipelines use windows-latest - they all use windows-2019.

Why this was not done on the day of formally releasing visual studio 2022?

Same for me! mairaw mentioned the issue I opend. I think that the name "windows-latest" is totally misleading. Something like "..-stable" would fit much better to the reality.

I'm seeing this warning

##[warning]windows-latest pipelines will use windows-2022 soon. For more details, see #4856

In all of my Windows pipelines, but none of my pipelines use windows-latest - they all use windows-2019.

Sorry for the inconvenience, this is a known issue and will be fixed next week.

Something like "..-stable" would fit much better to the reality.

-stable implies that it is more "stable" than other windows-* labels, which is not and would be even more misleading

Ok, good point, do you have a better idea?
With "-latest" I expect the "latest bits and bytes". Not that several month after the release of the actual .NET 6 it's not included. :(

the label windows-* pertains to Windows version, not software it includes
since windows-2019 is Windows Server 2019 and windows-2022 is Windows Server 2022, naturally, windows-latest is latest GA version of Windows Server

FWIW
I agree windows-latest implies the most recent GA versions of stuff. This would mean that as soon as windows-2022 was GA then the -latest version should have switched over the same day (or close to it) not 6 months later (windows 2022 was GA in Sep).
When you take into consideration that .NET 6 was not available on the -2019 image on release day either it was a bit frustrating being encouraged to update to the latest .NET asap and then having to find out that it actually required changes to pipelines because -latest doesn't mean latest 🥲 Acknowledging that the solution was to pin to -2022 so not the end of the world it still meant confusion and frustration when the expectation was for the latest bits to be available.
There was a similar thing with Azure Functions last year with a many month lag between .NET 5 and support for it in functions. They worked to ensure that .NET 6 was supported on day 1 when that came out in Nov. Maybe there's a lesson to be learned there?
@mikeKuester
Another possible option would be to simply not offer a windows-latest and only offer pinned versions then people would have to take control of their own versions. I accept that makes it slightly more painful for people managing windows versions and many pipelines but it does remove the ambiguity.

I agree windows-latest implies the most recent GA versions of stuff. This would mean that as soon as windows-2022 was GA then the -latest version should have switched over the same day (or close to it) not 6 months later (windows 2022 was GA in Sep).

It takes time to work out all the quirks of new software when it's released to not break environment. Switching over to windows-2022 on day 0 would break a lot of pipelines/workflows as well as it would require for GHA team to have it available on that time in Azure environment. I'll admit it is my fault that I didn't put * with clarification that latest OS requires additional work, thorough testing and customer feedback before it can be released "in the wild" and all that combined takes time.

When you take into consideration that .NET 6 was not available on the -2019 image on release day either it was a bit frustrating being encouraged to update to the latest .NET asap and then having to find out that it actually required changes to pipelines because -latest doesn't mean latest

The correct way is to use dotnet installation task (ADO | GHA) and not rely on specific bits installed on the host as much as possible.

It takes time to work out all the quirks of new software when it's released to not break environment. Switching over to windows-2022 on day 0 would break a lot of pipelines/workflows as well as it would require for GHA team to have it available on that time in Azure environment. I'll admit it is my fault that I didn't put * with clarification that latest OS requires additional work, thorough testing and customer feedback before it can be released "in the wild" and all that combined takes time. What I originally meant by GA is GA in sense of OS vendor and GitHub Actions.

Totally understand it takes time to ensure everything works it was more an observation of the fact that -latest implies a little risk because you're asking for the latest 😃 Thanks for the clarification though.

The correct way is to use dotnet installation task (ADO | GHA) and not rely on specific bits installed on the host as much as possible.

That's a fair point, on the flip side would it not make sense to have no .NET versions available on the image by default so that it's not possible for people to do it wrong? This would force people down the happy path when creating pipelines.
Keep up the good work 🍾

@neman 6.0 is bundled in VS2022, so it's available on the image but not installed via part of .NET installation script

Still might be good to add to the table. It confused me too.

That's a fair point, on the flip side would it not make sense to have no .NET versions available on the image by default so that it's not possible for people to do it wrong? This would force people down the happy path when creating pipelines.

Some versions of software that can be installed through actions/setup-* is kept in the image because of popularity (of version and not only) and (not sure if all since I didn't check all actions but) setup-* tasks will match against requested version and if it matches, it will skip installation (e.g. task requires version '5.0.x', '5.0.100' is installed - skips installation). I also don't want to speak as something given due to the fact I'm just a random contributor, so it's better to take GH Actions team words for mine but I do remember .NET being nightmare to maintain due to various issues (like installation time which I tried to help mitigate but for Ubuntu, ref: https://github.com/actions/virtual-environments/discussions/2367).

Totally understand it takes time to ensure everything works it was more an observation of the fact that -latest implies a little risk because you're asking for the latest

Another possible option would be to

use windows-current, it doesn't imply any (in)stability and/or version of software installed on the runner
although, I'm sure if that was or were to be used as the name it would confuse new/old users "why it's not latest anymore" and some could find current as inadequate choice of word for the tag (somehow), nature of language and conveying message in as few words as possible

use windows-current, it doesn't imply any (in)stability and/or version of software installed on the runner although, I'm sure if that was or were to be used as the name it would confuse new/old users "why it's not latest anymore" and some could find current as inadequate choice of word for the tag (somehow), nature of language and conveying message in as few words as possible

Naming is hard for sure 🤣

@tt2468 innosetup can be installed relatively fast in runtime. Please feel free to ask for help if needed

Would have run choco install innosetup.

@tt2468 innosetup can be installed relatively fast in runtime. Please feel free to ask for help if needed

Would have run choco install innosetup.

Is this what @tt2468 meant?

There are Windows SDKs and libraries (Spectre mitigation is the notable one for me) missing from the VS 2022 installation that were present in the 2019 image, are we to assume these won't be added to this image? I could install them at runtime but that takes a while :(

Personally, I'd suggest -default, although I'd be totally happy w/ -current.
-latest is clearly a misnomer.

Can we disable the warning without the need to update the pipeline yml to stick on windows-2022?

@micdenny do you use AzureDevOps? If yes — I'm afraid it's not possible at the moment.

@miketimofeev yes we use azuredevops, btw thank you for the reply.

Our existing pipeline, updated specifically to windows-2022 and VS 2022 now has an error that sn.exe can't be found trying to disable strong name validation. Suggestions?

Can we please get the upcoming change warnings disabled for distributions with -latest suffix? Anyone that uses -latest already made a decision about what they want to use.
I find perfectly normal to warn people that do not use latest about changes that may impact them.
Current behavior add noise to pull requests and distracts from other work.

@ssbarnea Arguably the message only wants to be shown to people that are using -latest as that's the only people that it affects. In our case it was a useful prompt as we then tested our builds against -2022 on a branch, discovered that they didn't work, and then pinned our builds to -2019. Without this warning we'd have been caught off guard when the change happened, and it would have need to have been a rushed and unscheduled change rather than part of a planned sprint.

@MatthewSteeples I am inclined to believe that most people will not do anything about it until the change is happening. Testing before change is happening requires human time, and based on what I see on ~100 project which I am watching/contributing is that it is quite uncommon for someone to go an "let's see what happens if I try to update to newer distro".
The reality is that yesterday I seen my builds failing just because Microsoft decided to use pipx to pre-install ansible-core using pipx instead of using the outdated ansible from Ubuntu. That was a change on the image and I do not blame them for doing that change, jut is an example that this warning is questionable and we should have a way to disable it.
It should not be so hard to add an entry to yaml to declare that you don't want to be notified about new releases. In the end, I am not aware of subscribing to a changelog to build images either, and I would find that far more useful than "asking user to test our new stuff". At least with email, i would be able to decide if latest changes worth testing or not and do not pile up on each CI run.
Should I also mention that the ... soon is extremely vague, is can be today, next week, next month on or even later. Nobody knows and we are all forced to see that "advertisement" annotation that we cannot control.
Just this morning I had to dig on the issue tracker to find an undocumented feature to disable warning when archive artifact does not have anything to archive. if-no-files-found: ignore was the solution, nice and simple.
I am only asking not to punish those that want to use/support/test with the latest version of a specific platform. They already made that statement by picking a label like that. Those that value stability more, can use specific versions.

The workaround today is to pin forward or pin backward. This is of course annoying because in either case one gets commit churn and in either case one has to unpin at some later date.
It'd certainly be nice if GitHub supported a repository/org secret that says DO_NOT_WARN_IF_WINDOWS_LATEST_IS_2022 with a specific cookie value (to be announced in a task like this one).
Relying on a cookie value would be necessary to prevent people from proactively setting DO_NOT_WARN_IF_WINDOWS_LATEST_IS_2023, DO_NOT_WARN_IF_WINDOWS_LATEST_IS_2024,  ... DO_NOT_WARN_IF_WINDOWS_LATEST_IS_2038.

Are there any issues tracking the update progress on the ubuntu-latest image?
I agree that the label -latest should alweays be the latest version available and not something we will update 4 to 5 months down the line...
For example my team has been having a lot of trouble moving our microservices from Net 5 to Net 6 because it's currently unsupported in the "latest" images. Forcing us to run our CI steps in containers which brings it's own problems.
Furthermore i just don't find it acceptable making us wait 4 to 5 months before we can upgrade to a new version when github has it available on day one. especially with Net 6 being an LTS.
The same went for XCode 13 support on MacOS, we just went months without building or testing our IOS version of our flutter app because we simply couldn't, while again github had it on day one.
Please introduce a actual "latest" image so people who want to move forward can move forward.

I feel @Joren-Thijs-KasparSolutions pain but I think the reason why we are on this unfortunate situation is because of a past naming mistake that was done.
My guess is that the team producing the system images imagined that they can easily release a fully working image soon after an operating system was released. The reality is that these images are, for good reasons, a kitchensink of tools and it would be close to impossible to get all of them compatible with newer operating system in time.
You cannot really expect to pass all the test suites on a new operating system, some changes will break some of the (build) tools on these platform, and I think that is something we should only get used to.
I do remember seeing delays of even more than 6 months in getting updates in the past but I seen some speed improvements too, it gets better.
Still, how about just updating the documentation in order to state that -latest counts as unstable and that many features are not guaranteed to work. If you want you can even add a new set of labels with -stable suffix which would point to versions of the operating system that passed the test of time.
Example of less confusing setup:

windows-2022 no confusions about what it represents, best of risk-sensitive ones
windows-stable an image change that points to a well tests/supported version of the platform. Newer may exist but they would likely have known bugs.
windows-latest point to newest available version of windows as a runner, even if that one may not contain or work with with all build tools. That is aimed to risk-takers

This is also a common naming pattern for container images so nobody should be confused by it.

The following step, described here, might be causing an error:

script: sqlpackage.exe /version
workingDirectory: C:\Program Files\Microsoft SQL Server\150\DAC\bin
displayName: 'get sqlpackage version'
##[error]Container path not found: 'C:\Program Files\Microsoft SQL Server\150\DAC\bin'

@rsouthworth the path has changed to the C:\Program Files\Microsoft SQL Server\160\DAC\bin. Sorry for the inconvenience.
I'll take a look at updating the docs.

Hi,
Inno Setup removal will break my Windows workflows, see for example here.
I guess I can download and install it as part of my workflows. The latest version of Inno Setup appears to have nearly 800,000 downloads, so its popularity doesn't seem that low. I'm just wondering if you could reconsider this decision, thank you

I also use Inno Setup in my workflows. It's not clear to me how the "low popularity" of Inno Setup was ascertained or what the "maintenance concerns" are, but consider this another vote to keep it alive.

@drakkan @dechamps would you mind opening an issue to add InnoSetup to the windows-2022 image?

@drakkan @dechamps would you mind opening an issue to add InnoSetup to the windows-2022 image?

done, #5006 thanks

Choosing "-latest" for something means all your builds are not reproducible/deterministic at all. (https://reproducible-builds.org/) This will maybe not even possible with "windows-", because things might are updated even on these machines.
But I agree with @ssbarnea: Everyone selecting "latest" chose the hottest available way already. It does not make a big difference if this is more or less tested by Microsoft or wait some months to allow people to prepare. Because people that wanted to prepare the switch already have a 2022 branch running and switch by merge that to their productive branch if working. All others maybe also chose "latest" because they don't care or never thought about these things. At the end its the responsibility of the development team to choose the right ingredient for the software.

Hi, thank you for the awesome work.
I would like to confirm: Is windows-latest workflows now using Windows Server 2022 on GitHub Actions? (I saw it was Windows Server 2019 yesterday, but it changes to use Windows Server 2022 just now)

Our existing pipeline, updated specifically to windows-2022 and VS 2022 now has an error that sn.exe can't be found trying to disable strong name validation. Suggestions?
##[debug]INPUT_SCRIPT: 'call "C:\\Program Files (x86)\\Microsoft Visual Studio\\2022\\Enterprise\\Common7\\Tools\\VsDevCmd.bat"
##[debug]sn -Vr *,31bf3856ad364e35'
##[debug]INPUT_WORKINGDIRECTORY: 'D:\a\1\s'
##[debug]Asserting container path exists: 'D:\a\1\s'
Generating script.
##[debug]AGENT_VERSION: '2.198.2'
##[debug]AGENT_TEMPDIRECTORY: 'D:\a\_temp'
##[debug]Asserting container path exists: 'D:\a\_temp'
##[debug]Asserting leaf path exists: 'C:\Windows\system32\cmd.exe'
========================== Starting Command Output ===========================
##[debug]Entering Invoke-VstsTool.
##[debug] Arguments: '/D /E:ON /V:OFF /S /C "CALL "D:\a\_temp\304ba344-c007-433b-8fad-d7ce519fe037.cmd""'
##[debug] FileName: 'C:\Windows\system32\cmd.exe'
##[debug] WorkingDirectory: 'D:\a\1\s'
"C:\Windows\system32\cmd.exe" /D /E:ON /V:OFF /S /C "CALL "D:\a\_temp\304ba344-c007-433b-8fad-d7ce519fe037.cmd""
The system cannot find the path specified.
'sn' is not recognized as an internal or external command,
operable program or batch file.
##[debug]Exit code: 1
##[debug]Leaving Invoke-VstsTool.
##[error]Cmd.exe exited with code '1'.

Any idea how I solve the problem of missing sn.exe?

Hi, thank you for the awesome work.
I would like to confirm: Is windows-latest workflows now using Windows Server 2022 on GitHub Actions? (I saw it was Windows Server 2019 yesterday, but it changes to use Windows Server 2022 just now)

As @miketimofeev said in the issue description, Window Server 2022 is available progressively on GitHub Actions since January, 17. They plan to complete this migration by March, 6.
My workflows are still using Windows Server 2019, so you are from the lucky ones. 😉

how do i fix this?

Should be close by #5093

It looks-like Windows 2022 is already the windows-latest version. Our builds started to fail with the latest available on GitHub version of Node.js (v16.13.2) at npm install command.
...
gyp ERR! find VS msvs_version not set from command line or npm config
gyp ERR! find VS VCINSTALLDIR not set, not running in VS Command Prompt
gyp ERR! find VS unknown version "undefined" found at "C:\Program Files\Microsoft Visual Studio\2022\Enterprise"
gyp ERR! find VS could not find a version of Visual Studio 2017 or newer to use
gyp ERR! find VS looking for Visual Studio 2015
gyp ERR! find VS - not found
gyp ERR! find VS not looking for VS2013 as it is only supported up to Node.js 8
gyp ERR! find VS
gyp ERR! find VS **************************************************************
gyp ERR! find VS You need to install the latest version of Visual Studio
gyp ERR! find VS including the "Desktop development with C++" workload.
gyp ERR! find VS For more information consult the documentation at:
gyp ERR! find VS https://github.com/nodejs/node-gyp#on-windows
gyp ERR! find VS **************************************************************
gyp ERR! find VS
gyp ERR! configure error
gyp ERR! stack Error: Could not find any Visual Studio installation to use
The issue could be in the Node.js version

Here is the **successful** output with Windows-2019:

...
gyp info find VS using VS2019 (16.11.32106.194) found at:
gyp info find VS "C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise"
gyp info find VS run with --verbose for detailed information
gyp info spawn C:\hostedtoolcache\windows\Python\3.7.9\x64\python3.exe
...

Looking at the [Readme](https://github.com/actions/virtual-environments/blob/win22/20220207.1/images/win/Windows2022-Readme.md), Microsoft Visual Studio 2022 should be there in the image 🤔

The version of npm in the image (8.1.2) includes a version of node-gyp that doesn't support vs2022 yet, so it looks for a maximum of 2019.
If you upgrade npm to v8.1.4 or later it will work, so I presume you could just do npm upgrade -g npm@latest (presuming npm is separate from Node on the image). If you want to upgrade node-gyp separately of npm, it's a bit more involved.

It looks-like Windows 2022 is already the windows-latest version.

Why you highlight the already? The post mentions clearly "This change will be rolled out [...] beginning on January, 17. We plan to complete the migration by March, 6." We have 17 February.
Regarding the "Microsoft Visual Studio 2022 should be there in the image" I see a "C:\Program Files\Microsoft Visual Studio\2022\Enterprise" in your message also. So yes it should and is there.
For me looks like related to https://github.com/nodejs/node-gyp/issues/2552 but not the the image itself.

After discovering about a week ago that my WSL pipeline gets stuck I was able to narrow down the culprit: windows-2022 runner is no longer able to use WSL1, while windows-2019 was able to run in few minutes. execution-example
The way it behaves is very weird, it gets so slow that it effectively times-out. That might have something to do with the fact that my codebase is on the /mnt/c and that this has a performance impact.
To get an idea about what kind of slowdown we are talking about, the 2019 jobs runs in less than 3 minutes, while 2022 times out after 30 minutes. Even increasing the timeouts does not help because it will likely take 2-3h+ to finish at its current speed.
The stuck happens while running tests with python (tox and a little bit of ansible syntax check as part of the tests).
Do we need a separated bug for this or we already have one?

@ssbarnea we haven't heard about such an issue. Feel free to open a new one and please make sure to provide some repro.

I've had some tests randomly start to timeout with "windows-latest", though no relevant code changes were made. Every time I would re-run the workflow it would be a different test that timed out. I suspected it is related to the switch to windows 2022, once I've set the version to "windows-2019" things seem to be back to normal.

@ssbarnea we haven't heard about such an issue. Feel free to open a new one and please make sure to provide some repro.

Something is clearly borked around windows-2022. While trying to make a simplified repo and workflow to reproduce the problems I ended up with https://github.com/actions/checkout/issues/702 -- please read it and check the outcomes.

The docs (https://github.com/actions/virtual-environments) still indicate that windows-latest is 2019, which is what led me here. Can that be brought up to date?

@usjpaq, see https://github.com/actions/virtual-environments/issues/4856#issuecomment-1034116799 and https://github.com/actions/virtual-environments/pull/5093#issuecomment-1042661742
They historically have been unwilling to change the documentation to say something like:

platform-latest is currently transitioning from platform-previous to platform-next and thus your builds may run on either; if you need deterministic behavior, you can specify either in the interim.

The docs team is fairly reluctant to make changes that only temporarily describe a state. However, on rare occasions it has been possible to convince them.

⚠ Did the VM move to Windows-2022 "today"?
My pure UWP/XAML project does not compile anymore. One project generates 41 errors. It works perfectly locally.
Is there a way to force the workflow on the previous working VM? Our process is stopped :/
15_Build the sideload solution.txt

⚠ Did the VM move to Windows-2022 "today"?
No the migration has started a month ago. Just as written in the initial post at the top of the discussion.
So the change is of course expected and no surprise.

Is there a way to force the workflow on the previous working VM? Our process is stopped :/
Of course and yes, by using windows-2019 instead windows-latest. Also as written in the initial post just at the top of the discussion.

@bormm My bad for not reading correctly the top post. After a discussion with Tim and Lance, apparently I need to install the UWP sdk of the specific versions in the workflow.

Visual Studio 2019 is now gone. We were using the direct path to Msbuild which is now missing.

Check out microsoft/setup-msbuild action to use

Sorry for the inconvenience, this is a known issue and will be fixed next week.

@miketimofeev  - Still seeing this when using windows-latest.

If I'm using windows-latest then I recognize that I want the latest and that that will change at times. I dont need to have a warning showing up in all the pipelines for this. Can you please just turn it off and find some other way to share this info that does not create a warning?

Sorry for the inconvenience, this is a known issue and will be fixed next week.

@miketimofeev - Still seeing this when using windows-latest.
If I'm using windows-latest then I recognize that I want the latest and that that will change at times. I dont need to have a warning showing up in all the pipelines for this. Can you please just turn it off and find some other way to share this info that does not create a warning?

The issue that was fixed was that the warning was showing up when windows-2019 was specified. Showing the warning for windows-latest was critical in figuring out why our build broke unexpectedly. There's no good reason to remove that.

GitHub migration completed!
Azure DevOps one is delayed and will be completed by the end of March or even the beginning of April.

@stijnherreman I don't understand the complaints about what windows-latest means. Surely it means the latest windows environment that github actions support, which github are at their own discretion regarding the timing of. It has nothing to do with the latest version of windows that exists, and I've never come across any CI platform that roll out an Image on day-zero of GA. 🤷

@sanking23

@GilesBathgate

I've never come across any CI platform that roll out an Image on day-zero of GA.

Neither have I, but we are not talking about day-zero.

Surely it means the latest windows environment that github actions support, [...]

Azure DevOps in my case, but yes, exactly! But even though windows-2022 has been available and supported for at least 3+ months, windows-latest points at an older version. Plenty of other people at https://github.com/dotnet/core/issues/6907 are also surprised by it.

BTW @miketimofeev It looks like this page needs updating (https://github.com/actions/virtual-environments)

Neither have I, but we are not talking about day-zero.

@stijnherreman Granted you might not be talking about day-zero, but at least one person was. (although visual-studio not windows)

Why this was not done on the day of formally releasing visual studio 2022?

The thing is I think some people (including myself) just put *-latest in a fire and forget sort of way. As such they don't want to actively change it windows-2022 and so it makes sense for that to be an experimental non stable version. When the environment is considered stable it makes sense to move latest over. As some have said windows-stable might be a better name, but a name is just a name, what it means should be documented: https://github.com/actions/virtual-environments

Showing the warning for windows-latest was critical in figuring out why our build broke unexpectedly. Removing the highly-visible warning would be a mistake IMO.

@NoahAndrews
Relying on the hosted images Microsoft provides as being stable is the mistake, but I know where you are coming from. I've opened many bug reports and general complaints about my build just starting to break one day because the maintainers did something like dropped python version 3.7 from the windows-2019 image without notice (and without updating the image inventory list for weeks after it had been done).  Or increasing the version of nodejs by two major versions without them even realizing it had happened. The hosts that MS provides are never going to have a fixed version of anything, especially when the image label is "latest". (Links to a few of these complaints that havent been wiped from GH: here and here and here )
What I've learned form these experiences and the response to them is primarily that if a particular pipeline must always have a stable build environment, I need to supply and control the host agent.  And if I can live with a slightly wobbly host agent using the "latest" versions of stuff, I dont need to have a silly warning on every build execution for several months telling me that the image is changing. Its repetitive and obvious.

Oh yeah, I totally agree. I think this transition was handled completely fine. I was just saying that getting rid of the warning would be a big step backwards.

If anyone observed a regression from windows-2019 to windows-2022 where the runner stops responding but the job/step still display are running until it eventually reach the job-timeout timeout, please check https://github.com/actions/virtual-environments/issues/5151
No logs are recorded at all and I can ensure that when this happens network connectivity with the runner is totally lost as I has tmate debugging session and they get dropped too right away.
Maybe unrelated to this but I also noted that running a ping google.com is a guarantee way kill a runner. It seems that in less than 10s your runner gets killed (not stuck like bug mentioned above). Localhost works but is not a reliable way to assert network connectivity of a machine.

@HuguesJ check the included software on the images. My guess is the SDK and/or toolset version you need is no longer on the windows-2022 images

I hope

I found a strange problem.
I have a CMake workflow using Visual Studio. On Windows Server 2022, if I use Visual Studio 16 2019, the x64 target ( X64) cannot be built (CMake cannot find the toolchain). But if I use Visual Studio 17 2022, the x86 target (Win32) cannot be built (toolchain not found, too).
My workflow definition:
        - name: "Windows x64"
          os: windows-latest
          cmake-args: -G "Visual Studio 17 2022" -A x64
          package-file: mmoteeworlds-win64.zip
          package-full-file: mmoteeworlds-win64-full.zip
          env:
            CFLAGS: /WX
            CXXFLAGS: /WX
            LDFLAGS: /WX

        - name: "Windows x86"
          os: windows-2019
          cmake-args: -G "Visual Studio 17 2022" -A Win32
          package-file: mmoteeworlds-win32.zip
          package-full-file: mmoteeworlds-win32-full.zip
          env:
            CFLAGS: /WX
            CXXFLAGS: /WX
            LDFLAGS: /WX

CMake error output:
CMake Error at CMakeLists.txt:20 (project):
  Generator

    Visual Studio 17 2022

  could not find any instance of Visual Studio.

-- Configuring incomplete, errors occurred!
See also "D:/a/Teeworlds-MRPG/Teeworlds-MRPG/release/CMakeFiles/CMakeOutput.log".
CMake Error:
  Generator

    Visual Studio 17 2022

  could not find any instance of Visual Studio.

CMake Error:
  Generator

    Visual Studio 17 2022

  could not find any instance of Visual Studio.

@StarOnTheSky Neither image contains both versions of Visual Studio.
windows-2019 contains Visual Studio 2019. So you'd use the CMake generator "Visual Studio 16 2019" on that image.
windows-2022 contains Visual Studio 2022. So you'd use the CMake generator "Visual Studio 17 2022" on that image.

@StarOnTheSky Neither image contains both versions of Visual Studio.
windows-2019 contains Visual Studio 2019. So you'd use the CMake generator "Visual Studio 16 2019" on that image.
windows-2022 contains Visual Studio 2022. So you'd use the CMake generator "Visual Studio 17 2022" on that image.

Oh, sorry. It's a silly typo of mine. Thanks.

It's not possible to build Analysis Services Projects using windows-2022 (only with windows-2019):
error MSB4226: The imported project "C:\Program Files\Microsoft Visual Studio\2022\Enterprise\MSBuild\Business Intelligence Semantic Model\1.0\Microsoft.AnalysisServices.VSHostBuilder.targets" was not found. Also, tried to find "Business Intelligence Semantic Model\1.0\Microsoft.AnalysisServices.VSHostBuilder.targets" in the fallback search path(s) for $(MSBuildExtensionsPath) - "C:\Program Files (x86)\MSBuild" . These search paths are defined in "C:\Program Files\Microsoft Visual Studio\2022\Enterprise\MSBuild\Current\Bin\msbuild.exe.Config". Confirm that the path in the <Import> declaration is correct, and that the file exists on disk in one of the search paths
Does this relates with the fact that the extensions for Analysis Services, Integration Services, and Reporting Services projects are not available for Visual Studio 2022 at this time?

What about LTS .NET 6.0?

Where did you get this? @neman

@allendewilzin It is in the issue description.

It's not possible to build Analysis Services Projects using windows-2022 (only with windows-2019): error MSB4226: The imported project "C:\Program Files\Microsoft Visual Studio\2022\Enterprise\MSBuild\Business Intelligence Semantic Model\1.0\Microsoft.AnalysisServices.VSHostBuilder.targets" was not found. Also, tried to find "Business Intelligence Semantic Model\1.0\Microsoft.AnalysisServices.VSHostBuilder.targets" in the fallback search path(s) for $(MSBuildExtensionsPath) - "C:\Program Files (x86)\MSBuild" . These search paths are defined in "C:\Program Files\Microsoft Visual Studio\2022\Enterprise\MSBuild\Current\Bin\msbuild.exe.Config". Confirm that the path in the <Import> declaration is correct, and that the file exists on disk in one of the search paths Does this relates with the fact that the extensions for Analysis Services, Integration Services, and Reporting Services projects are not available for Visual Studio 2022 at this time?

yes, they are not available for VS2022 at the moment https://docs.microsoft.com/en-us/sql/ssdt/download-sql-server-data-tools-ssdt?view=sql-server-ver15#changes-in-ssdt-for-visual-studio-2022

That's a fair point, on the flip side would it not make sense to have no .NET versions available on the image by default so that it's not possible for people to do it wrong? This would force people down the happy path when creating pipelines.

Some versions of software that can be installed through actions/setup-* is kept in the image because of popularity (of version and not only) and (not sure if all since I didn't check all actions but) setup-* tasks will match against requested version and if it matches, it will skip installation (e.g. task requires version '5.0.x', '5.0.100' is installed - skips installation). I also don't want to speak as something given due to the fact I'm just a random contributor, so it's better to take GH Actions team words for mine but I do remember .NET being nightmare to maintain due to various issues (like installation time which I tried to help mitigate but for Ubuntu, ref: #2367).

Totally understand it takes time to ensure everything works it was more an observation of the fact that -latest implies a little risk because you're asking for the latest

Another possible option would be to

use windows-current, it doesn't imply any (in)stability and/or version of software installed on the runner although, I'm sure if that was or were to be used as the name it would confuse new/old users "why it's not latest anymore" and some could find current as inadequate choice of word for the tag (somehow), nature of language and conveying message in as few words as possible

Two words might just be inadequate.
It's the current default version of windows determined by the team :) windows-default / windows-current-default ...

The migration is completed for everyone. The docs will be updated soon.

@zachpainter77 change your agents to windows-2019 and your scenario should be back to good.

This might not be the appropriate place to post this, but FWIW this warning message is now outdated and confusing (an updated warning of "windows-latest pipelines recently switched to use windows-2022" might have helped save me a little time figuring out why my build broke over night).

@zachpainter77 change your agents to windows-2019 and your scenario should be back to good.

@timheuer  Thank you, we did this and all is working.

This might not be the appropriate place to post this, but FWIW this warning message is now outdated and confusing (an updated warning of "windows-latest pipelines recently switched to use windows-2022" might have helped save me a little time figuring out why my build broke over night).

Sorry to hear that. We are going to change the message soon.

I have problem with building Windows App SDK on Windows 2022. 2019 works fine.
Error:
C:\hostedtoolcache\windows\dotnet\sdk\6.0.100\Sdks\Microsoft.NET.Sdk\targets\Microsoft.NET.Sdk.FrameworkReferenceResolution.targets(427,5): Error NETSDK1112: The runtime pack for Microsoft.Windows.SDK.NET.Ref was not downloaded. Try running a NuGet restore with the RuntimeIdentifier 'any'.
Is there any difference or did I missing something?

@JanRajnoha likely because the target Windows SDK is not on the image, you can see the versions:
windows-2022: https://github.com/actions/virtual-environments/blob/main/images/win/Windows2022-Readme.md
windows-2019: https://github.com/actions/virtual-environments/blob/main/images/win/Windows2019-Readme.md

@timheuer I'm using only 22000 SDK, I checked both VMs and are in all specific parameters same :/

@JanRajnoha I'd recommend switching back to windows-2019 of course while you debug to get you passing.  Might be good to open a new separate issue on this one.  My guess is that this is just due to a missing component that is no longer in the image.  If the Windows SDK you need is present it may be relying on an underlying ref pack (given the error) that points to windows-2022 not having that version of the .NET Framework -- you can try to enable this by getting it on the image if you can identify what is missing...or switching to 2019.

@miketimofeev how do we remove this warning? it causes our builds to fail as it generates a warning.

the warning is in place for the last two months. Does it cause your builds to fail all that time?
We are going to remove it next week.

Yes it does as we have 0 warning policy.

@retchegaraydev: In theory windows-2016, was scheduled to be removed on March 15, 2022: https://github.blog/changelog/2021-10-19-github-actions-the-windows-2016-runner-image-will-be-removed-from-github-hosted-runners-on-march-15-2022/
That didn't quite happen: https://github.com/actions/virtual-environments/issues/5238 -- at present (Apr 3), windows-2016 appears to be unavailable -- although it's possible it's another brownout as opposed to fully removed (certainly lots of the documentation and validation is still at the "it's not quite dead yet" stage).
While it seemed likely that they'd remove windows-2019 runners around the time that they make available the replacement for windows-2022, in theory they might do it earlier. Speculation seems to hint that a Windows Server 2025 could happen. But the EOL for windows-2019 is Jan 2024.
I think it's likely that they'd drop windows-2019 around Mar 2024/Apr 2024 just as they dropped windows-2016 a couple of months after it reached EOL.

I have a question with regards to our containers that we build. the containers required AzureML SDK and the latest python verion that it supports python 3.8 https://pypi.org/project/azureml-sdk/?msclkid=23fb8cfab55a11ecb682625f469f2675 the table published on this page mentions that win 2022 has python 3.9. so can I safely assume that It will not build our containers in the Azure Pipeline and we will have to stick to using windows-2019 as our agent pool ?

@sachinbdoshi python 3.9 is set as the default version but there are many other versions pre-installed, just use https://docs.microsoft.com/en-us/azure/devops/pipelines/tasks/tool/use-python-version?view=azure-devops task

Thank you, I will gove this option a try.
Regards,
Sachin Doshi

On 6 Apr 2022, at 4:42 pm, Mikhail Timofeev @.***> wrote:

@sachinbdoshi python 3.9 is set as the default version but there are many other versions pre-installed, just use https://docs.microsoft.com/en-us/azure/devops/pipelines/tasks/tool/use-python-version?view=azure-devops task
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.

@jozefizso the message has been disabled.

It seems that windows-latest is still pointing to windows-2019 instead of windows-2022. When I run my pipeline in Azure DevOps with the vmImage set to windows-latest, I see that the pool is set to windows-2019.

When I change to windows-2022, the pool is set to windows-2022.

According to the docs, windows-latest should be windows-2022.
I'm also confused as to why the docs say that for classic pipelines, the default is windows-2019. Shouldn't it be windows-latest?

@donatellijl, Could you check?
pool:
  name: Azure Pipelines
  vmImage: windows-latest

@donatellijl, Could you check?
pool:
  name: Azure Pipelines
  vmImage: windows-latest

I added "name: Azure Pipelines" and now instead of my first screenshot, I see windows-latest as the Image. Why is having the name a requirement?

Hello everyone, I hope you all are well.
I was trying to create a database with Microsoft hosted agent in yml pipeline. Can anyone please tell me if these agents offers any database server? This will be a great help 👍

Hello everyone, I hope you all are well.
I was trying to create a database with Microsoft hosted agent in yml pipeline. Can anyone please tell me if these agents offers any database server? This will be a great help 👍

Hello everyone, I hope you all are well. I was trying to create a database with Microsoft hosted agent in yml pipeline. Can anyone please tell me if these agents offers any database server? This will be a great help 👍

Complete list of software is available at the image definitions: https://github.com/actions/runner-images/blob/main/images/win/Windows2022-Readme.md (for windows-latest)


Unexpected top-level property "overrides[0].extends"

I am following this tutorial to add ESlint to my Angular 10 application but get the following error message in the ESLint plugin console:
 Error: ESLint configuration in <FILE> is invalid: 	- Unexpected top-level property "overrides[0].extends".
I have had a google but have not found anything to point to the root of the problem as the format in the ESlint config seems to be valid and I can run it from the CLI fine.

@SSmale does the validation happen correctly when you use eslint in the terminal. If this is the case can you please provide me with a GitHub repository I can clone that demos what you are experiencing.

Hi @dbaeumer,
yes it seems to be working fine in the cli. Unfortunately i can't provide the repo i am working in but will try to get a mini one up together later

Ok, so I reloaded the VS Code window and it just worked.... must have been a red herring....


[Compatibility] Updating numpy to 1.9 -> 1.9.5

Description of changes:
Updating to use the latest compatible numpy
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Job PR-917-1 is done.
Docs are uploaded to http://autogluon-staging.s3-website-us-west-2.amazonaws.com/PR-917/1/index.html


Smallest Common Multiple: Returning correct answer, but not receiving a check next to the test for [1,13]

var primes = [2, 3, 5, 7, 11, 13, 17, 19, 23.../TRUNCATED HERE AS THIS LIST CONTAINS ALL PRIMES UP TO 10,000...];

//this function takes a number and returns an array containing its prime factors or a 1 if it has none.
function pFact(n) {
  var factArr = [];
  var i = 0;
  while (n > 0) {
    while (i < primes.length) {
      if (n % primes[i] === 0) {
        factArr.push(primes[i]);
        n = n / primes[i];
        i = 0;
      } else {
        i++;
      }

    }
    factArr.push(1);
    break;
  }
  return factArr;
}

function smallestCommons(arr) {
  var primeFacts = [];
  var nums = [];
  var result = 1;
  var temp;
  var expoArr = [];

  var min = arr[0];
  var max = arr[1];

  if (min > max) {
    min = arr[1];
    max = arr[0];
  }
  //generate list of numbers
  for (var i = min; i <= max; i++) {
    nums.push(i);
  }

  //run through each number and find the prime factors of each
  //save the results in the primeFacts array as sub arrays.
  for (i = 0; i < nums.length; i++) {
    primeFacts.push(pFact(nums[i]));
  }

  //find the largest prime in the primeFacts array

  for (i = 0; i < primeFacts.length; i++) {
    max = 0;
    temp = primeFacts[i];
    for (var j = 0; j < temp.length; j++) {
      max = Math.max(max, temp[j]);
    }
  }
  //chop down the list of primes using the largest prime
  temp = primes.indexOf(max) + 1;
  primes = primes.slice(0, temp);

  //run through the now shortened primes list and find the max
  //number of times each prime is used in any given primeFacts
  //sub array.  Save this in expoArr.

  for (i = 0; i < primes.length; i++) {
    expoArr[i] = 0;

    for (var j = 0; j < primeFacts.length; j++) {
      temp = primeFacts[j];
      var count = 0;
      for (var k = 0; k < temp.length; k++) {
        if (temp[k] === primes[i]) {
          count++;
        }
        if (count > expoArr[i]) {
          expoArr[i] = count;
        }
      }
    }
  }

  //multiply the result
  for(i = 0; i < primes.length; i++){
    temp = Math.pow(primes[i], expoArr[i]);
    result = result * temp;
  }

  return result;

}

smallestCommons([1, 13]);

I'm not getting a check mark next to the test for 1, 13 when I run the above code.  I am, however, getting check marks next to the other tests.
So, this code doesn't seem to have a speed problem, since it uses the prime factorization method of finding the lowest common multiples, as opposed to brute forcing a large number of multiples until a common one is found.  Moreover, when I hit "Run Tests" I am getting the right returned values 360360 for [1,13] and 60 for [1,5].
What gives?

Type in console.log(arr, result, primes.length); just before you return the results for smallestCommons(). Notice that primes.length is 0 by the time it gets to the results of the test for smallestCommons([1, 13]).
Since primes is a global variable,  it doesn't get reset to its originally declared value every time smallestCommons() is run.
Note, that user-defined tests are run first and their results are what gets outputted to the console on the left. However, they are optional and their results don't determine whether or not the challenge will be passed, which is understandably confusing in this situation.

@alistermada Brilliant, thanks for that.  I hadn't considered that the FCC testing didn't re-initialize the program each time it ran a function call.  The fix turned out to be quite easy.


go/format: does not format comments correctly the first time

What version of Go are you using (go version)?

$ go version
go version go1.21.1 windows/amd64

Does this issue reproduce with the latest release?
Yes.
What operating system and processor architecture are you using (go env)?
go env Output
$ go env
set GO111MODULE=on
set GOARCH=amd64
set GOBIN=
set GOCACHE=C:\Users\icefl\AppData\Local\go-build
set GOENV=C:\Users\icefl\AppData\Roaming\go\env
set GOEXE=.exe
set GOEXPERIMENT=
set GOFLAGS=
set GOHOSTARCH=amd64
set GOHOSTOS=windows
set GOINSECURE=
set GOMODCACHE=C:\Users\icefl\go\pkg\mod
set GONOPROXY=
set GONOSUMDB=
set GOOS=windows
set GOPATH=C:\Users\icefl\go
set GOPRIVATE=
set GOPROXY=https://proxy.golang.org,direct
set GOROOT=C:/Program Files/Go
set GOSUMDB=sum.golang.org
set GOTMPDIR=
set GOTOOLCHAIN=auto
set GOTOOLDIR=C:\Program Files\Go\pkg\tool\windows_amd64
set GOVCS=
set GOVERSION=go1.21.1
set GCCGO=gccgo
set GOAMD64=v1
set AR=ar
set CC=gcc
set CXX=g++
set CGO_ENABLED=0
set GOMOD=D:\go-wargaming\go.mod
set GOWORK=
set CGO_CFLAGS=-O2 -g
set CGO_CPPFLAGS=
set CGO_CXXFLAGS=-O2 -g
set CGO_FFLAGS=-O2 -g
set CGO_LDFLAGS=-O2 -g
set PKG_CONFIG=pkg-config
set GOGCCFLAGS=-m64 -fno-caret-diagnostics -Qunused-arguments -Wl,--no-gc-sections -fmessage-length=0 -ffile-prefix-map=C:\Users\icefl\AppData\Local\Temp\go-build4212433334=/tmp/go-build -gno-record-gcc-switches

What did you do?
I tried to format some go code, at first formatting the comments are not correctly formatted. When i format again the correct result is produced.
I have no minimal example and i also could not create an easier example, hence the byte array.
// Auto generated file!

package wargaming

import (
	"context"
	"github.com/IceflowRE/go-wargaming/v4/wargaming/internal"
	"github.com/IceflowRE/go-wargaming/v4/wargaming/wgn"
)

// WgtvVehicles returns list of vehicles sorted by games and covered by videos.
//
// https://developers.wargaming.net/reference/all/wgn/wgtv/vehicles
//
// realm:
//
//	Valid realms: RealmAsia, RealmEu, RealmNa
func (service *WgnService) WgtvVehicles(ctx context.Context, realm Realm, options *wgn.WgtvVehiclesOptions) (*wgn.WgtvVehicles, *GenericMeta, error) {
	if err := validateRealm(realm, []Realm{RealmAsia, RealmEu, RealmNa}); err != nil {
		return nil, nil, err
	}

	reqParam := map[string]string{}

	if options != nil {
		if options.CategoryId != nil {
			reqParam["category_id"] = internal.SliceIntToString(options.CategoryId, ",")
		}
		if options.ProgramId != nil {
			reqParam["program_id"] = internal.SliceIntToString(options.ProgramId, ",")
		}
		if options.ProjectId != nil {
			reqParam["project_id"] = internal.SliceIntToString(options.ProjectId, ",")
		}
	}

	var data *wgn.WgtvVehicles
	var metaData *GenericMeta
	err := service.client.getRequest(ctx, sectionWgn, realm, "/wgtv/vehicles/", reqParam, &data, &metaData)
	return data, metaData, err
}

What did you see instead?
// Auto generated file!

package wargaming

import (
	"context"
	"github.com/IceflowRE/go-wargaming/v4/wargaming/internal"
	"github.com/IceflowRE/go-wargaming/v4/wargaming/wgn"
)

// WgtvVehicles returns list of vehicles sorted by games and covered by videos.
//
// https://developers.wargaming.net/reference/all/wgn/wgtv/vehicles
//
// realm:
//     Valid realms: RealmAsia, RealmEu, RealmNa
func (service *WgnService) WgtvVehicles(ctx context.Context, realm Realm, options *wgn.WgtvVehiclesOptions) (*wgn.WgtvVehicles, *GenericMeta, error) {
	if err := validateRealm(realm, []Realm{RealmAsia, RealmEu, RealmNa}); err != nil {
		return nil, nil, err
	}

	reqParam := map[string]string{}

	if options != nil {
		if options.CategoryId != nil {
			reqParam["category_id"] = internal.SliceIntToString(options.CategoryId, ",")
		}
		if options.ProgramId != nil {
			reqParam["program_id"] = internal.SliceIntToString(options.ProgramId, ",")
		}
		if options.ProjectId != nil {
			reqParam["project_id"] = internal.SliceIntToString(options.ProjectId, ",")
		}
	}

	var data *wgn.WgtvVehicles
	var metaData *GenericMeta
	err := service.client.getRequest(ctx, sectionWgn, realm, "/wgtv/vehicles/", reqParam, &data, &metaData)
	return data, metaData, err
}

I think this is from the \r in the indented line https://go.dev/play/p/E_YXQBvv0Uq

cc @griesemer

@seankhliao Thanks for the simplified example - very helpful. It does appear the the \r is causing this.
As an aside, we are aware that gofmt is not idemtpotent.

cc @mvdan (in case you're interested)

Indeed I am interested :)

As an aside, we are aware that gofmt is not idempotent.

Meaning that it's always been a known problem and you're okay with that limitation, or that there are idempotency bugs that should be fixed sooner than later?
I always worked under the assumption that gofumpt should be idempotent. In fact I have a number of idempotency issues open in gofumpt which worry me. Perhaps trying to fix those before we make gofmt properly idempotent wouldn't be a very good idea.
As a side note, I feel like fuzzing would be a helpful tool to find idempotency issues. Given any input which parses as valid Go, formatting a second time with go/format should result in zero changes.

It would be great if the idempotency bugs were fixed - but I think it's non-trivial to do so.
There may be a more targeted fix for this current issue, but I haven't looked into it.
Agreed that fuzzing should be helpful.


[FR] Support failure policy on data mapper tasks

Is your feature request related to a problem? Please describe.
It is possible to have a failure policy on the data mapper task. However, it is not supported as part of the  integrationcli scaffold command.
version - integrationcli version 0.77.0 date: 2024-11-13T17:33:30Z [commit: 77ba4c7]
Describe the solution you'd like
Add support for failure policy in the scaffold command
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.
Failure policy is part of error handling. It lets you decide how you want to handle errors in case there is any error during data mapping.

When I try to scaffold the integration as part of the ci/cd process, it it doesn't include the failure policy. However, when I manually download the integration I can see the failure policy
      "failurePolicies": [{
        "retryStrategy": "FIXED_INTERVAL",
        "maxRetries": 2,
        "intervalTime": "1970-01-01T00:00:30Z",
        "condition": "$`ExecutionMode`$ \u003d SYNC"
      }, {
        "retryStrategy": "FIXED_INTERVAL",
        "maxRetries": 2,
        "intervalTime": "1970-01-01T00:00:30Z",
        "condition": "$`ExecutionMode`$ \u003d ASYNC"
      }],
      "defaultFailurePolicy": {
        "retryStrategy": "RESTART_INTEGRATION_WITH_BACKOFF",
        "maxRetries": 2,
        "intervalTime": "1970-01-01T00:00:30Z"
      }
    }```

Fixed and released in v0.78.0


Create Login for Admin Panel

Description:

As Admin User for CLARISA, I want  log into admin panel using CGIAR and non CGIAR account so that want to create a user login through CGIAR AD and database admin users
Acceptance Criteria

[x] Given a CLARISA user, when  I set one CGIAR credentials ], then, the plaform wil indicates that login is sucessfull and redirect to users mangament panel

[x] Given a CLARISA user, when  I set wrong one CGIAR credentials ], then, the plaform wil indicates that login is not sucessfull and shows a error message indicating that is a wrong credentials

We found and issue during deploy on dev server with LDAP connection, we are checking how to proceed

we solved the Issue with LDAP connection. In addition we included the funtionality to access via username

We procced to close this issue after moving to dev envirnoment and test the funtionality


add ability to control temperature unit displayed on the AC

This is an issue that I face with my homebridge plugin as well. I currently don't know in which byte of the command the the flag is stored.

See https://github.com/mac-zhou/midea-ac-py/pull/23

I haven’t seen a setter for the display there, always only a getter. Or am I looking in the wrong place?

I found the bit to set which temperature unit is displayed on the display. Now I just need to fix the getTempUnit method since it turns out it doesn't really give us any result.

this bugfix may help: https://github.com/mac-zhou/midea-msmart/pull/17
On Mon, Jun 29, 2020 at 5:41 AM Tobias Timpe<EMAIL_ADDRESS>wrote:

I found the bit to set which temperature unit is displayed on the display.
Now I just need to fix the getTempUnit method since it turns out it doesn't
really give us any result.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/andersonshatch/midea-ac-lib/issues/7#issuecomment-651092711,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AADZ44X7TY5XRAL6JWD2HVDRZCDWBANCNFSM4NX5Y3NQ
.


Parse SDK Fails FB Login With No Error Code

Using:
Parse SDK 1.9.0
FB SDK 4.6
The following code snippit sometimes returns nil for both the user object and the error object.
NSArray* permissionArray = @[@"email", @"user_friends"];
FBSDKLoginManager *login = [[FBSDKLoginManager alloc] init];
[login logOut];

[PFFacebookUtils logInInBackgroundWithReadPermissions:permissionArray block:^(PFUser *user, NSError *error)

This is attached to a custom button in our app. When the user taps the button, the FB SDK works as expected (launches a Safari view, authenticates user, etc.), but when the call returns, both objects are nil.
We hypothesize that this is somehow related to this bug: https://developers.facebook.com/bugs/865668060184806/
However due to the fact that this problem seems to only affect users randomly, we're not sure and reliably duplicating this issue is more or less impossible. For example, on one device, we don't have problems logging in with a FB account, but on a different device, using the same FB account, the login will fail in this way.

Thanks for the report. This sounds really strange.
Firstly, to see if it's our issue and not FBDSKs, if you change to the BFTask version of the API, and continue on that, can you print out the description of the task that's returned? It will provide much more information than the block callback.

I'd bet dimes to doughnuts it is a FB SDK issue (we didn't have this issue specifically with 4.5.1 but there were other iOS 9 issues). We'll give your suggestion a try tonight and see if we can get the problem to occur.


fix(dev): only apply pretty types for objects

Closes: #

[ ] Docs
[ ] Tests

Testing Strategy:

Our GH actions bot is incorrect, this PR was not included in 1.17.1. Will be included in next release.


(chore) Update copy vacancy form to handle expiry time

Trello card URL:
https://dfedigital.atlassian.net/secure/RapidBoard.jspa?rapidView=21&view=planning&selectedIssue=TEVA-23
Changes in this PR:

Add expiry time parameters to the copy_controller
Extract the expiry time validator from application details form to reuse in copy form
Update the copy vacancy form spec and feature spec
Generalise expiry time field
Update the copy view to display time field

Screenshots of UI changes:
After

When a vacancy has a deadline time it copies the application deadline time

When a vacancy does not have a deadline time it prompts the user to enter

@C-gyorfi committed to exploring these two comments in a separate PR.


Purpose of keeping -UsageLogMaxSpaceGB parameter when it's not used by all SharePoint versions this page is applicable to

This article page applies to SharePoint Server 2010, 2013, 2016, and 2019.
-UsageLogMaxSpaceGB
The parameter is not used in SharePoint Server.
Applies to:
SharePoint Server 2010, SharePoint Server 2013, SharePoint Server 2016, SharePoint Server 2019
What's the point of keeping this parameter here when the parameter is totally inapplicable?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 9dc8a481-11f1-3808-dd61-efc74bbd4249
Version Independent ID: 524f48c5-f0ac-b3d3-575d-ee541c54bde1
Content: Set-SPUsageService (sharepoint-server)
Content Source: sharepoint/sharepoint-ps/sharepoint-server/Set-SPUsageService.md
Product: sharepoint-powershell
GitHub Login: @techwriter40
Microsoft Alias: kirks

@officedocsbot assign @yogkumgit

Thanks for noticing and reporting @desmondkung

Thanks for noticing and reporting @desmondkung

You're welcome!

@get-itips  Thank you very much for the contribution and updating the documentation with PR. @desmondkung Hope this update is helpful for you. Thanks for taking out some time to open the issue. Appreciate and encourage you to do the same in future also.


bin-sauce-connect needs to wait for pid file to disappear

When sc fails to connect due to timeout, it seems the next two attempts fail because the pid file is still hanging around. We need to make sure the next connect doesn't start until the pid file is gone (and maybe make sure to cleanup the pid file)

Done