Automator: update proxy@master in istio/istio@master

Generated by Automator - 2024-05-13T16:36:09+00:00

@istio-testing: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-telemetry-istiodremote_istio
5e823d02b2364bfa9e1699e785b860d401b682ca
link
true
/test integ-telemetry-istiodremote

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

/test integ-telemetry-istiodremote

@istio-testing: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-telemetry-istiodremote_istio
5e823d02b2364bfa9e1699e785b860d401b682ca
link
true
/test integ-telemetry-istiodremote

integ-telemetry_istio
5e823d02b2364bfa9e1699e785b860d401b682ca
link
true
/test integ-telemetry

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@istio-testing: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-telemetry-istiodremote_istio
5e823d02b2364bfa9e1699e785b860d401b682ca
link
true
/test integ-telemetry-istiodremote

integ-telemetry_istio
5e823d02b2364bfa9e1699e785b860d401b682ca
link
true
/test integ-telemetry

integ-telemetry-mc_istio
5e823d02b2364bfa9e1699e785b860d401b682ca
link
true
/test integ-telemetry-mc

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@istio-testing: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-telemetry-istiodremote_istio
5e823d02b2364bfa9e1699e785b860d401b682ca
link
true
/test integ-telemetry-istiodremote

integ-telemetry_istio
5e823d02b2364bfa9e1699e785b860d401b682ca
link
true
/test integ-telemetry

integ-telemetry-mc_istio
5e823d02b2364bfa9e1699e785b860d401b682ca
link
true
/test integ-telemetry-mc

integ-telemetry-discovery_istio
5e823d02b2364bfa9e1699e785b860d401b682ca
link
true
/test integ-telemetry-discovery

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

related to https://github.com/envoyproxy/envoy/pull/33912

@istio-testing: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-telemetry_istio
5e823d02b2364bfa9e1699e785b860d401b682ca
link
true
/test integ-telemetry

integ-telemetry-mc_istio
5e823d02b2364bfa9e1699e785b860d401b682ca
link
true
/test integ-telemetry-mc

integ-telemetry-discovery_istio
5e823d02b2364bfa9e1699e785b860d401b682ca
link
true
/test integ-telemetry-discovery

integ-telemetry-istiodremote_istio
5e823d02b2364bfa9e1699e785b860d401b682ca
link
true
/test integ-telemetry-istiodremote

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@istio-testing: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-telemetry_istio
5e823d02b2364bfa9e1699e785b860d401b682ca
link
true
/test integ-telemetry

integ-telemetry-mc_istio
5e823d02b2364bfa9e1699e785b860d401b682ca
link
true
/test integ-telemetry-mc

integ-telemetry-discovery_istio
5e823d02b2364bfa9e1699e785b860d401b682ca
link
true
/test integ-telemetry-discovery

integ-telemetry-istiodremote_istio
9c4a1db3d5e8231e00c0626365d6739997fe0e5a
link
true
/test integ-telemetry-istiodremote

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@istio-testing: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-telemetry_istio
5e823d02b2364bfa9e1699e785b860d401b682ca
link
true
/test integ-telemetry

integ-telemetry-discovery_istio
5e823d02b2364bfa9e1699e785b860d401b682ca
link
true
/test integ-telemetry-discovery

integ-telemetry-istiodremote_istio
9c4a1db3d5e8231e00c0626365d6739997fe0e5a
link
true
/test integ-telemetry-istiodremote

integ-telemetry-mc_istio
9c4a1db3d5e8231e00c0626365d6739997fe0e5a
link
true
/test integ-telemetry-mc

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@istio-testing: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-telemetry_istio
5e823d02b2364bfa9e1699e785b860d401b682ca
link
true
/test integ-telemetry

integ-telemetry-istiodremote_istio
9c4a1db3d5e8231e00c0626365d6739997fe0e5a
link
true
/test integ-telemetry-istiodremote

integ-telemetry-mc_istio
9c4a1db3d5e8231e00c0626365d6739997fe0e5a
link
true
/test integ-telemetry-mc

integ-telemetry-discovery_istio
9c4a1db3d5e8231e00c0626365d6739997fe0e5a
link
true
/test integ-telemetry-discovery

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@istio-testing: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-telemetry-istiodremote_istio
9c4a1db3d5e8231e00c0626365d6739997fe0e5a
link
true
/test integ-telemetry-istiodremote

integ-telemetry-mc_istio
9c4a1db3d5e8231e00c0626365d6739997fe0e5a
link
true
/test integ-telemetry-mc

integ-telemetry-discovery_istio
9c4a1db3d5e8231e00c0626365d6739997fe0e5a
link
true
/test integ-telemetry-discovery

integ-telemetry_istio
9c4a1db3d5e8231e00c0626365d6739997fe0e5a
link
true
/test integ-telemetry

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@istio-testing: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-telemetry-mc_istio
9c4a1db3d5e8231e00c0626365d6739997fe0e5a
link
true
/test integ-telemetry-mc

integ-telemetry-discovery_istio
9c4a1db3d5e8231e00c0626365d6739997fe0e5a
link
true
/test integ-telemetry-discovery

integ-telemetry_istio
9c4a1db3d5e8231e00c0626365d6739997fe0e5a
link
true
/test integ-telemetry

integ-telemetry-istiodremote_istio
90920db459b267129f411949a1edebc3bfeb40ee
link
true
/test integ-telemetry-istiodremote

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@istio-testing: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-telemetry-discovery_istio
9c4a1db3d5e8231e00c0626365d6739997fe0e5a
link
true
/test integ-telemetry-discovery

integ-telemetry_istio
9c4a1db3d5e8231e00c0626365d6739997fe0e5a
link
true
/test integ-telemetry

integ-telemetry-istiodremote_istio
90920db459b267129f411949a1edebc3bfeb40ee
link
true
/test integ-telemetry-istiodremote

integ-telemetry-mc_istio
90920db459b267129f411949a1edebc3bfeb40ee
link
true
/test integ-telemetry-mc

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@istio-testing: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-telemetry-discovery_istio
9c4a1db3d5e8231e00c0626365d6739997fe0e5a
link
true
/test integ-telemetry-discovery

integ-telemetry-istiodremote_istio
90920db459b267129f411949a1edebc3bfeb40ee
link
true
/test integ-telemetry-istiodremote

integ-telemetry-mc_istio
90920db459b267129f411949a1edebc3bfeb40ee
link
true
/test integ-telemetry-mc

integ-telemetry_istio
90920db459b267129f411949a1edebc3bfeb40ee
link
true
/test integ-telemetry

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@istio-testing: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-telemetry-istiodremote_istio
90920db459b267129f411949a1edebc3bfeb40ee
link
true
/test integ-telemetry-istiodremote

integ-telemetry-mc_istio
90920db459b267129f411949a1edebc3bfeb40ee
link
true
/test integ-telemetry-mc

integ-telemetry_istio
90920db459b267129f411949a1edebc3bfeb40ee
link
true
/test integ-telemetry

integ-telemetry-discovery_istio
90920db459b267129f411949a1edebc3bfeb40ee
link
true
/test integ-telemetry-discovery

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@istio-testing: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-telemetry-mc_istio
90920db459b267129f411949a1edebc3bfeb40ee
link
true
/test integ-telemetry-mc

integ-telemetry_istio
90920db459b267129f411949a1edebc3bfeb40ee
link
true
/test integ-telemetry

integ-telemetry-discovery_istio
90920db459b267129f411949a1edebc3bfeb40ee
link
true
/test integ-telemetry-discovery

integ-telemetry-istiodremote_istio
48a573462dc1e24bba654b30e3f34073c8841cf2
link
true
/test integ-telemetry-istiodremote

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@istio-testing: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-telemetry_istio
90920db459b267129f411949a1edebc3bfeb40ee
link
true
/test integ-telemetry

integ-telemetry-discovery_istio
90920db459b267129f411949a1edebc3bfeb40ee
link
true
/test integ-telemetry-discovery

integ-telemetry-istiodremote_istio
48a573462dc1e24bba654b30e3f34073c8841cf2
link
true
/test integ-telemetry-istiodremote

integ-telemetry-mc_istio
48a573462dc1e24bba654b30e3f34073c8841cf2
link
true
/test integ-telemetry-mc

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@istio-testing: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-telemetry_istio
90920db459b267129f411949a1edebc3bfeb40ee
link
true
/test integ-telemetry

integ-telemetry-istiodremote_istio
48a573462dc1e24bba654b30e3f34073c8841cf2
link
true
/test integ-telemetry-istiodremote

integ-telemetry-mc_istio
48a573462dc1e24bba654b30e3f34073c8841cf2
link
true
/test integ-telemetry-mc

integ-telemetry-discovery_istio
48a573462dc1e24bba654b30e3f34073c8841cf2
link
true
/test integ-telemetry-discovery

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@istio-testing: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-telemetry-istiodremote_istio
48a573462dc1e24bba654b30e3f34073c8841cf2
link
true
/test integ-telemetry-istiodremote

integ-telemetry-mc_istio
48a573462dc1e24bba654b30e3f34073c8841cf2
link
true
/test integ-telemetry-mc

integ-telemetry-discovery_istio
48a573462dc1e24bba654b30e3f34073c8841cf2
link
true
/test integ-telemetry-discovery

integ-telemetry_istio
48a573462dc1e24bba654b30e3f34073c8841cf2
link
true
/test integ-telemetry

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@istio-testing: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-telemetry-mc_istio
48a573462dc1e24bba654b30e3f34073c8841cf2
link
true
/test integ-telemetry-mc

integ-telemetry-discovery_istio
48a573462dc1e24bba654b30e3f34073c8841cf2
link
true
/test integ-telemetry-discovery

integ-telemetry_istio
48a573462dc1e24bba654b30e3f34073c8841cf2
link
true
/test integ-telemetry

integ-telemetry-istiodremote_istio
02707172125df771c2d8d45505fbf5576af4d0ca
link
true
/test integ-telemetry-istiodremote

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@istio-testing: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-telemetry-discovery_istio
48a573462dc1e24bba654b30e3f34073c8841cf2
link
true
/test integ-telemetry-discovery

integ-telemetry_istio
48a573462dc1e24bba654b30e3f34073c8841cf2
link
true
/test integ-telemetry

integ-telemetry-istiodremote_istio
02707172125df771c2d8d45505fbf5576af4d0ca
link
true
/test integ-telemetry-istiodremote

integ-telemetry-mc_istio
02707172125df771c2d8d45505fbf5576af4d0ca
link
true
/test integ-telemetry-mc

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@istio-testing: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-telemetry-discovery_istio
48a573462dc1e24bba654b30e3f34073c8841cf2
link
true
/test integ-telemetry-discovery

integ-telemetry-istiodremote_istio
02707172125df771c2d8d45505fbf5576af4d0ca
link
true
/test integ-telemetry-istiodremote

integ-telemetry-mc_istio
02707172125df771c2d8d45505fbf5576af4d0ca
link
true
/test integ-telemetry-mc

integ-telemetry_istio
02707172125df771c2d8d45505fbf5576af4d0ca
link
true
/test integ-telemetry

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@istio-testing: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-telemetry-istiodremote_istio
02707172125df771c2d8d45505fbf5576af4d0ca
link
true
/test integ-telemetry-istiodremote

integ-telemetry-mc_istio
02707172125df771c2d8d45505fbf5576af4d0ca
link
true
/test integ-telemetry-mc

integ-telemetry_istio
02707172125df771c2d8d45505fbf5576af4d0ca
link
true
/test integ-telemetry

integ-telemetry-discovery_istio
02707172125df771c2d8d45505fbf5576af4d0ca
link
true
/test integ-telemetry-discovery

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

PR needs rebase.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@istio-testing: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-telemetry-istiodremote_istio
02707172125df771c2d8d45505fbf5576af4d0ca
link
true
/test integ-telemetry-istiodremote

integ-telemetry-mc_istio
02707172125df771c2d8d45505fbf5576af4d0ca
link
true
/test integ-telemetry-mc

integ-telemetry_istio
02707172125df771c2d8d45505fbf5576af4d0ca
link
true
/test integ-telemetry

integ-telemetry-discovery_istio
02707172125df771c2d8d45505fbf5576af4d0ca
link
true
/test integ-telemetry-discovery

integ-basic-arm64_istio
02707172125df771c2d8d45505fbf5576af4d0ca
link
true
/test integ-basic-arm64

integ-pilot-istiodremote_istio
02707172125df771c2d8d45505fbf5576af4d0ca
link
true
/test integ-pilot-istiodremote

integ-ipv6_istio
02707172125df771c2d8d45505fbf5576af4d0ca
link
true
/test integ-ipv6

integ-pilot-istiodremote-mc_istio
02707172125df771c2d8d45505fbf5576af4d0ca
link
true
/test integ-pilot-istiodremote-mc

integ-operator-controller_istio
02707172125df771c2d8d45505fbf5576af4d0ca
link
true
/test integ-operator-controller

integ-ds_istio
02707172125df771c2d8d45505fbf5576af4d0ca
link
true
/test integ-ds

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@istio-testing: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-telemetry-istiodremote_istio
02707172125df771c2d8d45505fbf5576af4d0ca
link
true
/test integ-telemetry-istiodremote

integ-telemetry-mc_istio
02707172125df771c2d8d45505fbf5576af4d0ca
link
true
/test integ-telemetry-mc

integ-telemetry_istio
02707172125df771c2d8d45505fbf5576af4d0ca
link
true
/test integ-telemetry

integ-telemetry-discovery_istio
02707172125df771c2d8d45505fbf5576af4d0ca
link
true
/test integ-telemetry-discovery

integ-basic-arm64_istio
02707172125df771c2d8d45505fbf5576af4d0ca
link
true
/test integ-basic-arm64

integ-pilot-istiodremote_istio
02707172125df771c2d8d45505fbf5576af4d0ca
link
true
/test integ-pilot-istiodremote

integ-ipv6_istio
02707172125df771c2d8d45505fbf5576af4d0ca
link
true
/test integ-ipv6

integ-pilot-istiodremote-mc_istio
02707172125df771c2d8d45505fbf5576af4d0ca
link
true
/test integ-pilot-istiodremote-mc

integ-operator-controller_istio
02707172125df771c2d8d45505fbf5576af4d0ca
link
true
/test integ-operator-controller

integ-ds_istio
02707172125df771c2d8d45505fbf5576af4d0ca
link
true
/test integ-ds

unit-tests-arm64_istio
02707172125df771c2d8d45505fbf5576af4d0ca
link
true
/test unit-tests-arm64

integ-helm_istio
02707172125df771c2d8d45505fbf5576af4d0ca
link
true
/test integ-helm

gencheck_istio
02707172125df771c2d8d45505fbf5576af4d0ca
link
true
/test gencheck

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@istio-testing: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-telemetry-mc_istio
02707172125df771c2d8d45505fbf5576af4d0ca
link
true
/test integ-telemetry-mc

integ-telemetry_istio
02707172125df771c2d8d45505fbf5576af4d0ca
link
true
/test integ-telemetry

integ-telemetry-discovery_istio
02707172125df771c2d8d45505fbf5576af4d0ca
link
true
/test integ-telemetry-discovery

integ-basic-arm64_istio
02707172125df771c2d8d45505fbf5576af4d0ca
link
true
/test integ-basic-arm64

integ-pilot-istiodremote_istio
02707172125df771c2d8d45505fbf5576af4d0ca
link
true
/test integ-pilot-istiodremote

integ-ipv6_istio
02707172125df771c2d8d45505fbf5576af4d0ca
link
true
/test integ-ipv6

integ-pilot-istiodremote-mc_istio
02707172125df771c2d8d45505fbf5576af4d0ca
link
true
/test integ-pilot-istiodremote-mc

integ-operator-controller_istio
02707172125df771c2d8d45505fbf5576af4d0ca
link
true
/test integ-operator-controller

integ-ds_istio
02707172125df771c2d8d45505fbf5576af4d0ca
link
true
/test integ-ds

unit-tests-arm64_istio
02707172125df771c2d8d45505fbf5576af4d0ca
link
true
/test unit-tests-arm64

integ-helm_istio
02707172125df771c2d8d45505fbf5576af4d0ca
link
true
/test integ-helm

gencheck_istio
02707172125df771c2d8d45505fbf5576af4d0ca
link
true
/test gencheck

integ-distroless_istio
02707172125df771c2d8d45505fbf5576af4d0ca
link
true
/test integ-distroless

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@istio-testing: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-basic-arm64_istio
02707172125df771c2d8d45505fbf5576af4d0ca
link
true
/test integ-basic-arm64

integ-pilot-istiodremote_istio
02707172125df771c2d8d45505fbf5576af4d0ca
link
true
/test integ-pilot-istiodremote

integ-ipv6_istio
02707172125df771c2d8d45505fbf5576af4d0ca
link
true
/test integ-ipv6

integ-pilot-istiodremote-mc_istio
02707172125df771c2d8d45505fbf5576af4d0ca
link
true
/test integ-pilot-istiodremote-mc

integ-operator-controller_istio
02707172125df771c2d8d45505fbf5576af4d0ca
link
true
/test integ-operator-controller

integ-ds_istio
02707172125df771c2d8d45505fbf5576af4d0ca
link
true
/test integ-ds

unit-tests-arm64_istio
02707172125df771c2d8d45505fbf5576af4d0ca
link
true
/test unit-tests-arm64

integ-helm_istio
02707172125df771c2d8d45505fbf5576af4d0ca
link
true
/test integ-helm

gencheck_istio
02707172125df771c2d8d45505fbf5576af4d0ca
link
true
/test gencheck

integ-distroless_istio
02707172125df771c2d8d45505fbf5576af4d0ca
link
true
/test integ-distroless

release-test_istio
02707172125df771c2d8d45505fbf5576af4d0ca
link
true
/test release-test

macbuildcheck_istio
02707172125df771c2d8d45505fbf5576af4d0ca
link
true
/test macbuildcheck

release-notes_istio
02707172125df771c2d8d45505fbf5576af4d0ca
link
true
/test release-notes

lint_istio
02707172125df771c2d8d45505fbf5576af4d0ca
link
true
/test lint

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.


chore(plugin) remove dynamic name and make hardcoded like rest

@mikefero ouch... sorry for the sloppy fix. Was a quick one while running out the door into the weekend...

All good; have a good weekend my friend.


it's possible to preview?

it's possible to preview scheduled notifications?
i.e.  in Laravel 8 I can do something like to preview notifications:
Route::get('/preview', function () {
  $admin = User::find(1);
  $company = Company::find(1);
   return (new CompanyRegistration($company))->toMail($admin);
});

I.e. its possible to do something like...:
$notification = ScheduledNotification::find(1);
return $notification->getPreview();

?
thnks

my current solution for a preview is
        $n = DB::table('scheduled_notifications')->select('target','notification')->first();
        $notifiable = unserialize($n->target);
        $notification = unserialize($n->notification);

        return $notification->toMail($notifiable);


ci: add more tests for nvme spdk perf

Fixes #89
Signed-off-by: Boris Glimcher<EMAIL_ADDRESS>

for some reason this is not failing our test...
+ bash -c 'docker-compose -f docker-compose.xpu.yml  exec -T xpu-spdk /root/spdk/build/examples/perf     -r '\''traddr:<IP_ADDRESS> trtype:TCP adrfam:IPv4 trsvcid:4420'\'' -c 0x1 -q 1 -o 4096 -w randread -t 10'
TELEMETRY: No legacy callbacks, legacy socket not created
[2022-07-08 11:09:12.981526] posix.c: 526:posix_sock_create: *ERROR*: connect() failed, errno = 111
[2022-07-08 11:09:12.981601] nvme_tcp.c:1941:nvme_tcp_qpair_connect_sock: *ERROR*: sock connection error of tqpair=0x1678550 with addr=<IP_ADDRESS>, port=4420
[2022-07-08 11:09:12.981623] nvme_tcp.c:2148:nvme_tcp_ctrlr_construct: *ERROR*: failed to create admin qpair
[2022-07-08 11:09:12.981637] nvme.c: 705:nvme_ctrlr_probe: *ERROR*: Failed to construct NVMe controller for SSD: <IP_ADDRESS>
No valid NVMe controllers or AIO or URING devices found
Initializing NVMe Controllers


No Images are loaded when i build release apk -> RN Android

Recently when i buld my signed APK my Android App loads without any Images. I had this before too, but forgot how i fixed it :( . No idea anymore what the reason was...Maybe someone has an idea?
When i build the debug apk (react-native run-android) Images are loaded.....

I had the same problem.
You can see #4084
To create bundle and assets :
react-native bundle --assets-dest ./android/app/src/main/res/ --entry-file ./index.android.js --bundle-output ./android/app/src/main/assets/index.android.bundle --platform android -dev false

After, in android project on Android Studio, you can go to Build, Generated APK.
Finally, install your apk with :
adb install app-release.apk

Hi there! This issue is being closed because it has been inactive for a while.
But don't worry, it will live on with ProductPains! Check out its new home: https://productpains.com/post/react-native/no-images-are-loaded-when-i-build-release-apk-rn-android
ProductPains helps the community prioritize the most important issues thanks to its voting feature.
It is easy to use - just login with GitHub.
Also, if this issue is a bug, please consider sending a PR with a fix.
We're a small team and rely on the community for bug fixes of issues that don't affect fb apps.

cd android && ./gradlew assembleRelease should bundle the assets for you in recent releases of RN.
@facebook-github-bot stack-overflow

@PCharpentier "... -dev false" must change to "... -- dev false" or may get an err message. Test on rn 0.35


gh-371 Add filtering for classifier elements screen

gh-371 Updated the classifier elements screen to show a filter text box for the Type column. Updated the element-link component with a new config property to show a domain type without the DataType prefix as users would use DataType as a filter value when filtering the results, and the elements' type value is not prefixed with DataType.

I commented on the core PR about making the Type filter a dropdown (like the DataModel Data Types page filter) but have now noticed those dropdowns don't allow clearing properly so happy to leave that for now. I can raise a separate issue about that.

@joe-crawford  This is ready for re-review


error when trying to group by column

hey
try to group by word column in the link below. you'll see this error: undefined is not an object (evaluating 'newGroup.grouping')
https://codesandbox.io/s/material-table-starter-template-forked-u58ig6?file=/src/index.js
Thanks

Same Here!

Should be fixed with the next release

@Domino987 this is still not fixed. not the grouping is not working atunci all. drag a column in the group by section and is not added

Seems like draggable changed the id to force it to be a string. Will be fixed with the next release


Editor: Fix AssetLib is not updating size and stuck

This is an enhancement to the fix originally provided in #80555.
When I submitted the original PR I did not account for resizing the editor window at runtime, so the number of columns for asset lib search results was recalculating on resize, but the asset title truncation threshold was not being recalculated, so columns were not spacing correctly after resizing the editor.
I added a simple for loop to the NOTIFICATION_RESIZE event of the EditorAssetLibrary class that loops through the currently displayed assets and recalculates their title truncation length. I just used a for loop over the asset_items->get_child_count and fetched each EditorAssetLibraryItem with asset_items->get_child since I wanted to avoid explicit memory allocation inside the notification handler.
Please let me know if this is not a good solution or if the use of static_cast is discouraged.
I tested this solution locally, and it fixes the problems I mentioned in https://github.com/godotengine/godot/issues/84471#issuecomment-1832182508.
I think this will fix the scaling problem as reported in https://github.com/godotengine/godot/issues/84471#issuecomment-1793725120 since it forces recalculation of the asset titles, but I am unable to confirm for sure since I can't test this on Windows.

Forgot to run clang-format. :man_facepalming: Just amended with formatting fixed.

Okay, this should be ready for review now. The problem was that the clamp_width method was originally written with the assumption that it would be called on object initialization, so it was overriding the tooltip with the truncated version of the title text and wasn't handling the case of resizing to a larger size and un-truncating. I got this fixed and amended my commit.
I also updated the commit message with the details of the edits I made to the clamp_width method.
Please let me know if you have any questions about the implementation. Thanks!

@GrammAcc, It looks like it'll fix my issue on Linux using a tile manager. I'll keep you posted when it gets merged and 4.3 comes out. Thanks for putting in the work.

I realized this morning that there is a better way to ensure that we don't overwrite the tooltip text with the truncated text. I currently have an if check for it in the clamp_width method, but I think it would be best to just set it in the configure method where the title text is set and then not worry about it, so I will update this PR over my lunch break today with a better design.
Also, I am working through the Accelerated C++ book in order to improve my contribution efficiency and quality, so hopefully my future PRs will be easier to review. :)

I updated the PR with a better implementation. Details are in the commit message. I removed the full_title_text private member of the EditorAssetLibraryItem and used the tooltip text as the full text instead. By moving the set_tooltip_text call into the configure method, I don't have to worry about the tooltip accidentally getting updated during the clamp_width call, so this works fine as an invariant. Let me know if there are any problems with this approach. Thanks!

CI is failing on the MacOS template_export job for some reason. I have no idea why, but I'm working on this.

I'm closing this since #88761 was merged and seems to solve the same problem.


fix: don't ignore at_edge for floating windows

fixes #217
Before this PR, we never invoke the user's custom at_edge behavior for floating windows (see minimal repro). Instead, we return early.
This PR ensures that, for floating windows, we call handle_at_edge() just before returning early.
And since we now invoke that logic in two different places, I extracted it into its own function handle_at_edge(). So really, the only real of this PR is the additional logic introduced on line 410.
Off-topic

The noisy diff is largely due to the indentation change. Block out the noise using:
git config --global diff.colormoved dimmed-zebra
git config --global diff.colormovedws allow-indentation-change

Sorry for the delay. Been crazy at my day job.
I am pretty sure that ignoring at_edge on floating windows is intended behavior. There is a separate option float_win_behavior that controls the intended behavior for floating windows, since most users want them to be treated differently from normal windows.
See: #201 #202
I would be open to adding support for float_win_behavior = 'at-edge' to make the floating window behavior mimic the regular at-edge behavior.

I would be open to adding support for float_win_behavior = 'at-edge' to make the floating window behavior mimic the regular at-edge behavior.

That would be even better. :)


DataStore - multiple errors when generating models and running queries for the first time

Describe the bug
I have been using Appsync for some time and I tried to set up datastore today, I updated my API using the CLI and then ran the amplify codegen models command, which generated my models in JS. after running my app with a simple query for one of my models - it returned null (although there is data and that query should have returned a result), I got this error -
Possible Unhandled Promise Rejection (id: 0):
TypeError: null is not an object (evaluating '(_j === void 0 ? {} : _j).level')
http://localhost:8081/index.bundle?platform=ios&dev=true&minify=false:282924:45
forEach@[native code]
getAuthorizationRules@http://localhost:8081/index.bundle?platform=ios&dev=true&minify=false:282888:18
http://localhost:8081/index.bundle?platform=ios&dev=true&minify=false:283937:52
http://localhost:8081/index.bundle?platform=ios&dev=true&minify=false:283905:41
http://localhost:8081/index.bundle?platform=ios&dev=true&minify=false:284157:59
map@[native code]
http://localhost:8081/index.bundle?platform=ios&dev=true&minify=false:284156:166
step@http://localhost:8081/index.bundle?platform=ios&dev=true&minify=false:209567:27
http://localhost:8081/index.bundle?platform=ios&dev=true&minify=false:209497:22
http://localhost:8081/index.bundle?platform=ios&dev=true&minify=false:209469:75
tryCallTwo@http://localhost:8081/index.bundle?platform=ios&dev=true&minify=false:3753:9
doResolve@http://localhost:8081/index.bundle?platform=ios&dev=true&minify=false:3917:25
Promise@http://localhost:8081/index.bundle?platform=ios&dev=true&minify=false:3776:14
__awaiter@http://localhost:8081/index.bundle?platform=ios&dev=true&minify=false:209448:38
http://localhost:8081/index.bundle?platform=ios&dev=true&minify=false:284150:39
forEach@[native code]
http://localhost:8081/index.bundle?platform=ios&dev=true&minify=false:284149:31
forEach@[native code]
http://localhost:8081/index.bundle?platform=ios&dev=true&minify=false:284145:64
step@http://localhost:8081/index.bundle?platform=ios&dev=true&minify=false:209567:27
http://localhost:8081/index.bundle?platform=ios&dev=true&minify=false:209497:22
fulfilled@http://localhost:8081/index.bundle?platform=ios&dev=true&minify=false:209451:32
tryCallOne@http://localhost:8081/index.bundle?platform=ios&dev=true&minify=false:3744:16
http://localhost:8081/index.bundle?platform=ios&dev=true&minify=false:3845:27
_callTimer@http://localhost:8081/index.bundle?platform=ios&dev=true&minify=false:30720:17
_callImmediatesPass@http://localhost:8081/index.bundle?platform=ios&dev=true&minify=false:30759:17
callImmediates@http://localhost:8081/index.bundle?platform=ios&dev=true&minify=false:30976:33
__callImmediates@http://localhost:8081/index.bundle?platform=ios&dev=true&minify=false:3047:35
http://localhost:8081/index.bundle?platform=ios&dev=true&minify=false:2833:34
__guard@http://localhost:8081/index.bundle?platform=ios&dev=true&minify=false:3030:15
flushedQueue@http://localhost:8081/index.bundle?platform=ios&dev=true&minify=false:2832:21
flushedQueue@[native code]
invokeCallbackAndReturnFlushedQueue@[native code]

I think that this error comes from<EMAIL_ADDRESS>lines 204-207.
I also got two of these errors for one of my models that do not have an id field but a different primary key (I have multiple of those, but I only got error for this one which is named Provider) -
[WARN] 57:37.965 DataStore - subscriptionError Connection failed: {"errors":[{"message":"Validation error of type FieldUndefined: Field 'id' in type 'Provider' is undefined @ 'onDeleteProvider/id'"}]}

[WARN] 57:37.968 DataStore - Sync error Connection failed: {"errors":[{"message":"Validation error of type FieldUndefined: Field 'id' in type 'Provider' is undefined @ 'onDeleteProvider/id'"}]}

To Reproduce

Update your API using the Amplify CLI to use datastore
run amplify codegen models
Run a simple query in your app, doesn't matter which model
See error

Expected behavior
There shouldn't be that first JS error, and also I should be able to have models that have a different primary key rather than id.
Screenshots

What is Configured?
the fields that exist in the aws-exports file are
aws_project_region
aws_cognito_identity_pool_id
aws_cognito_region
aws_user_pools_id
aws_user_pools_web_client_id
aws_appsync_graphqlEndpoint
aws_appsync_region
aws_appsync_authenticationType
aws_user_files_s3_bucket
aws_user_files_s3_bucket_region
aws_mobile_analytics_app_id
aws_mobile_analytics_app_region

and the custom config for Amplify.configure looks like this
const config = {
  ...aws_exports,
  graphql_headers: async () => {
    try {
      const token = (await Auth.currentSession()).getIdToken().getJwtToken();
      return { Authorization: token };
    } catch (e) {
      console.error(e);
      return {};
    }
  },
  Auth: {
    storage: AmplifyCommunityAsyncStorage,
  },
  PushNotification: {
    appId: aws_exports.aws_mobile_analytics_app_id,
    requestIOSPermissions: false,
  },
};

Identified it's a code generation issue. Transferring to the appropriate team.

Not really a codegen issue. The problem is that in your schema you do not have an ID field defined, which is required by datastore. When using @key without a name, the primary key is changed to your custom field rather than ID and ID, the original primary key, will not be added in the built graphql schema. The reference is here https://docs.amplify.aws/cli/graphql-transformer/key#designing-data-models-using-key. To solve the issue, you can either add a name attribute in @key(which converts the field to a secondary key) or add id: ID! explicitly in the schema. Because of the unsupported custom primary key in datastore, this solution will cost more by adding additional partition keys. Once the custom primary key is supported in the datastore, this is no longer a problem then.

Closing based on response provided by @AaronZyLee
Please let us know if you need additional help on this issue.

Closing based on response provided by @AaronZyLee
Please let us know if you need additional help on this issue.


Compilation generates errors for stdio.h

Macbook Air Silicon
OSX 14.7
XCode 16.0
Compilation of  a simple "Hello World" C program produces multiple error messages like:
gprbuild -u -Ptest2.gpr
Compile
[C]            test.c
In file included from /System/Volumes/Data/C_Projects/test2/src/test.c:1:
/System/Volumes/Data/Ada_Source/GNAT/gcc-14.2.0-1-aarch64/lib/gcc/aarch64-apple-darwin21/14.2.0/include-fixed/stdio.h:83:8: error: unknown type name ‘FILE’
83 | extern FILE *__stdinp;
|        ^~~~
/System/Volumes/Data/Ada_Source/GNAT/gcc-14.2.0-1-aarch64/lib/gcc/aarch64-apple-darwin21/14.2.0/include-fixed/stdio.h:81:1: note: ‘FILE’ is defined in header ‘<stdio.h>’; this is probably fixable by adding ‘#include <stdio.h>’
80 | #include <sys/_types/_seek_set.h>
+++ |+#include <stdio.h>

Apple’s header files are sometimes not standard C, and the GCC build process has a 'fixincludes' phase where fixed-up versions of the header files are inserted before the manufacturer’s.
I’ve reported this, but for the moment I’m afraid the only fix is to revert to the previous Xcode (e.g. 15.3, or 15.4? I use the Command Line Tools).

Thanks Simon. I had to revert both XCode and Command Line Tools. Now build and runs OK.


New project does not have mIRC coloring

The project is here. It has mIRC coloring enabled, but messages in the channel contain no mIRC coloring. I'm using Quassel, which shows mIRC coloring from other users in this channel just fine, and I have no problem sending messages with mIRC coloring either.

Invalid. #magnum-engine has mode +c (strip formatting including colours).
It's also mlocked.
2015-01-18 19:29:16+0200 -- ChanServ: Information on #magnum-engine:
2015-01-18 19:29:16+0200 -- ChanServ: Founder    : mosra
2015-01-18 19:29:16+0200 -- ChanServ: Registered : Jan 18 10:24:22 2015 (7h 4m 54s ago)
2015-01-18 19:29:16+0200 -- ChanServ: Mode lock  : +ntc-slk
2015-01-18 19:29:16+0200 -- ChanServ: *** End of Info ***

Ah, OK. Sorry for the noise!


Update Sanity links in episode 440

The sanity links don't go anywhere. This PR fixes that!

The sanity links don't go anywhere. This PR fixes that!

Weird! Thanks for catching that. Some sort of Markdown issue in my copy paste I suspect.


Add (state) filter sidebar to order list view

Description
The order list view can only be filtered by affiliate code and campaign code which is not enough for most users.

We already implemented a sidebar-order-filter (by states) in our "orders" tab of the product detail view in our Pickware ERP Starter plugin:

Hence we could implement this feature for the order list view as well.
Example
Take a look at the order list view (/admin/sw/order/index) and compare it to the "orders" tab of any product in our demo shop that has Pickware ERP Starter installed: https://sw6demo.pickware.de/admin
There are already some issues about this:
https://issues.shopware.com/issues/NEXT-10480
https://issues.shopware.com/issues/NEXT-9261
https://issues.shopware.com/issues/NEXT-7375

I just updated the issue title and screenshot to match the current state of showpare/platform.

on the last boostday there was a similar topic for the product list
the outcome was to build a general filter sidebar which could be used in all modules
https://github.com/shopware/platform/issues/880 (for second boostday: https://github.com/shopwareBoostDay/platform/issues/55
https://github.com/shopware/platform/pull/948

to build a general filter sidebar

Are you suggesting that the current components (sw-sidebar, sw-sidebar-item with some select fields) should be combined in a general "filter sidebar" component that uses a unified interface (props, events) in all list views while the actual filter elements (select fields) vary from view to view?

yeah basically. like I already stated here: https://github.com/shopware/platform/issues/880#issuecomment-627400506
I'm not a frontend guy, so I don't know how easy/hard this is :smile:

Nothing is impossible 🌈 🙌

Hi,
thanks for the really great contribution idea.
We plan to implement filters for the product, customer and order module in the near future. I just want to avoid that we put in double work here.
Many greetings,
Marcel

Allright! I will close this issue then.


ruby: improve reproducibility of gem builds

Motivation for this change
By default, the gem build will leave a path like:
lib/ruby/gems/2.7.0/gems/racc-1.5.2/ext/racc/cparse/.gem.20210503-6-csuqdb
putting the build date in the output hurts the build reproducibility
efforts
see #123718
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[ ] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Great, I did a checkout and nokogiri + racc are now reproducible! I just looked at that folder and it's indeed empty (at least for nokogiri), so no harm in deleting it.
LGTM, regex should indeed only match that folder.

it's an upstream logic bug in rubygems.

closed in favor of #123748

Taking it upstream is indeed nicer :)


Opening data viewer from 2+ scopes in a debug session fails with NameError: name '_VSCODE_VariableImport' is not defined

This impacts all three debugging scenarios we currently support:

In Run By Line with v2021.6.780948196:

In interactive window debugging, you currently can't open the local variables from the variable explorer in the data viewer due to https://github.com/microsoft/vscode-jupyter/issues/5626. It looks like we used to disable the variable explorer when debugging in the interactive window, though we don't anymore and I don't remember why: https://github.com/microsoft/vscode-python/blob/c08ef0be557ed697ef96bfe12b3820d7e4ac2e8e/package.nls.json#L456. But the same problem likely applies for opening variables from the variable explorer, and does apply when using the View Value in Data Viewer context menu option in the variables window:

In Python file debugging:

I don't think this is a regression, it looks like we have always evaluated the imports once per debug session in the topmost frame. https://github.com/microsoft/vscode-jupyter/blob/2ac130e64993790bb8500e3227c0808487149213/src/client/datascience/jupyter/debuggerVariables.ts#L211-L241

Validated. I used #3 python file as the validation. From what I see of the fix that should suffice. But if you want I can test the other two as well.


Enable manual and automatic chip selection

The first 3 commits are already in master

I am aware. sorry I started this work before the other PR was approved. I will fix that before merge. Will add hotloading to this PR later today.
Would just be happy about some general input :)

@therealprof Try reviewing this: https://github.com/probe-rs/probe-rs/pull/20/files/48b70db976035273598413dfd139ca6dd3e45d30..aabba4991c3897b68d0ab3a0e58f6aa00b4c8769

I think it would be cleaner to do the error printing and exit(1) in a single place and bubble up errors from other functions via Result<_, Box<Error>> or something similar.

Good catch. I hope I caught them all.
Error bubbling was already implemented, sadly not pushed yet because some other parts wouldn't compile.
Hope the changes do the trick.

We would like to merge this for now, so work on other branches can continue properly without having a ton of future conflicts.
For this purpose I "relocated" autodiscovery on a future PR and have renamed this PR to reflect this change.

Why did you delete the Travis config?

Why did you delete the Travis config?

Because we are using GH actions :)


Invoice

Building off the work of @benphelps and @mscottford, this includes a minor tweak to invoices to add the path method required for fetching single records, and adds line_items to the fetched invoice properties.

@lthurston Looks good, just merged it. Thank you! ❤


Custom node draw with large nodes not clickable

When using with_custom_node_draw() for drawing rectangular (quite large) nodes with long text in it, the node is only clickable in the center. The outer part of the rect shape is not clickable and the edges start inside the rect:

Ok, this has 2 parts:

Node clickable in the center is a bug. I need to think about user implementing his own function is_inside(pos: Vec2) for custom drawn node, to check if cursor is inside node. And lib will use it to determine if click was inside, because now it does not account for custom node sizes
Second part can now be handled by custom edges drawing func. As when you draw custom node shape lib does not know where the bounds of the node and uses default round bounds. I will also think on this moment, but for now, you can handle it yourself in custom node drawing func.

I've forked it and already implemented "node_detect" and "with_custom_node_detect".

@patrik-cihal you can always file a pull request if you wish.
Overall my idea of solving this bug is to oblige users of the lib to implement two apis for their custom nodes
/// returns if provided position is inside the node boundaries.
/// could be used for proper node clicking and selection.
fn is_inside(&self, pos: Pos2) -> bool

/// returns point which lies on the node boundary between its center and the provided `target`.
/// could be used to bind edge starts and tips for the custom drawn nodes.
fn boundary_intersection_point(&self, target: Pos2) -> Pos2

We can think of the names for the methods but the idea covers the fix.

As it's right now implemented, you'd need more to detect these things. Like Settings Style and Metadata.
This is my implementation for reference:
fn default_node_detect<N: Clone>(meta: &Metadata, n: &Node<N>, pos_in_graph: Vec2, settings_style: &SettingsStyle) -> bool {
    let dist_to_node = (n.location() - pos_in_graph).length();
    dist_to_node <= n.screen_radius(meta, &settings_style) / meta.zoom
}

That is correct. I have the same in master
    /// Finds node by position. Can be optimized by using a spatial index like quad-tree if needed.
    pub fn node_by_screen_pos(
        &self,
        meta: &'a Metadata,
        style: &'a SettingsStyle,
        screen_pos: Pos2,
    ) -> Option<(NodeIndex, &Node<N>)> {
        let pos_in_graph = (screen_pos.to_vec2() - meta.pan) / meta.zoom;
        self.nodes_iter().find(|(_, n)| {
            let dist_to_node = (n.location() - pos_in_graph).length();
            dist_to_node <= n.screen_radius(meta, style) / meta.zoom
        })
    }

I 've edited my comment.
Your implementation does not cover custom drawn nodes, which can be not round and which need their own implementation the api I shown.

No, this is just the default function, my implementation allows for adding your own custom node detect function. But maybe doing it through traits may be better, as you say.

Ah, ok I see. Anyway, If you come to make a PR I would gladly explore your solution. For the moment I am planning to implement the one I've described.

implementing in this pr https://github.com/blitzarx1/egui_graphs/pull/108

The fix is in master along with the massive drawing updates. Please check custom_draw example for more info.


tx.gov.submitProposal

Got a problem with submitting a ParamChange proposal for: { subspace: "distribution", key: "secretfoundationaddress" }
Code:
const proposal = {
    content: {
        title: "Title",
        description: "Desc",
        changes: [
            {
                subspace: "distribution",
                key: "secretfoundationaddress",
                value: contract_info.contractAddress,
            },
        ],
    },
    initialDeposit: [{ denom: "uscrt", amount: "1000000000" }],
    proposer: contract_owner.account.address,
    type: ProposalType.ParameterChangeProposal,
};
let resp = await cli.tx.gov.submitProposal(proposal);

Got error:
{"rawLog":"failed to execute message; message index: 0: key: secretfoundationaddress, value: secret18j6kr2f6l8yvn62wsu35mrwucxrq239d388hey, err: invalid character 's' looking for beginning of value: failed to set parameter: invalid proposal content"}

Try
-                 value: contract_info.contractAddress,
+                value: `"${contract_info.contractAddress}"`,

The problem is with Amino encoding. For reference: https://docs.scrt.network/guides/governance.html#create-a-governance-proposal

always amino — taking a note of this issue so we can maybe do some validation.

Indeed, that's a very old problem with param change proposals... you don't know what type the SDK expects you to pass in


Create a Product item-5

One need to make this component using HTML and Tailwind CSS. I would suggest to use Tailwind Playgrounds to make things faster and quicker.
Here is a reference to the component.

After building the component please raise a PR with a screenshot of the component.
If you need to use any icon please use it from Hero Icons
Good luck.

Please assign me this issue

Yes. It has been merged  #310


[Question] Results.Merge() where TValue is a collection

I have a requirement to merge multiple results of type Result<IEnumerable<T>>. Here is an example of what Im trying to do:
Result<IEnumerable<SomeDto>> result = Result.Ok(Enumerable.Empty<SomeDto>());

if (someCondition)
{
    Result<IEnumerable<SomeDto>> dbResult = await CallSomeDbFunc();
    result = Result.Merge(result, dbResult);
}

if (result.IsSuccess && someCondition)
{
    // run another db function and merge with `result`
}

With the above code, Result.Merge is returning Result<IEnumerable<IEnumerable<SomeDto>>>>. What I would rather it return is the input's result type.
In order to achieve what I want, Im using ToResult to "unwrap" the return from Result.Merge.
Result.Merge(result, dbResult).ToResult(result => result.SelectMany(value => value));

Is this the recommended way or have I missed a method signature somewhere?

I'm interested in implementing this.  One question I have is should this be a different name than Merge?  Reason being once implemented and you go to merge the collections, you get an error saying that Merge is ambiguous between Merge<TValue> and Merge<IEnumerable<TValue>>.  To get around the ambiguity, the method could be called something else, or you can specify the result type when calling Merge.  Thinking this may be a small price to pay for keeping the public API clean.
@altmann what are your thoughts?  Below is my proposal.  Happy to submit a PR for this and will update docs.
var result1 = new string[] { "A", "B", "C" };
var result2 = new string[] { "D", "E", "F" };
var result3 = new string[] { "G", "H", "I" };

// Have to specify result type so compiler knows this is the IEnumerable version
var result = Result.Merge<string>(result1, result2, result3);

Console.WriteLine(String.Join(",", result.Value));

var result4 = Result.Ok("J");
var result5 = Result.Ok("K");
var result6 = Result.Ok("L");

// Do not have to specify result type
var result7 = Result.Merge(result4, result5, result6);

Console.WriteLine(String.Join(",", result7.Value));

@Kysluss Thank you for your preparation. I think I would call the new method with a new name. Maybe MergeFlat() or only Flat(). What do you think?
If I see it correctly the first three variables (result1, result2 and result3) are not real reasults, only array of strings. I think you mean Result.Ok(new string[] { ... });

Thanks @altmann
You are right, I was taking advantage of the implicit conversion for ease of creating a demo.  I think MergeFlat might a good name because it helps explicitly state the intention of the method.  I'll work on this and should have a PR either today or tomorrow for you.

Okay, so slight complication on this one.  I'm running into the error we discussed in #201 where you can't convert between things based on interface type.  It might be a little bit before I have that PR ready, but will keep working on it.

@altmann I have added #215 with a MergeFlat method and documentation.  Because of the discussion in #201, the method signature requires TValue and TArray to be able to correctly infer the type parameters.  For some reason, the compiler doesn't pick them up.  Below is an example usage.
var result1 = Result.Ok(new string[] { "A", "B" });
var result2 = Result.Ok(new string[] { "C", "D" });
var result3 = Result.Ok(new string[] { "E", "F" });

// Will contain ["A", "B", "C", "D", "E", "F"]
var mergedResult = Result.MergeFlat<string, string[]>(result1, result2, result3);


Map not showing

I've been using the icantbelieveitsnotvaletudo add-on for a while now but it stopped updating the map in home assistant.
Looking with mqtt explorer shows the following map data: https://hastebin.com/yuyeyodimu.json updated 10 minutes ago.
However, nothing shows in home-assistant, the ingress tab shows Not Found
These are the addon settings:
{
  "identifier": "rockrobo",
  "topicPrefix": "valetudo",
  "autoconfPrefix": "homeassistant",
  "broker_url"<EMAIL_ADDRESS>  "caPath": "",
  "mapSettings": {
    "drawPath": true,
    "drawCharger": true,
    "drawRobot": true,
    "border": 2,
    "scale": 4
  },
  "mapDataTopic": "valetudo/rockrobo/map_data",
  "minMillisecondsBetweenMapUpdates": 10000,
  "publishMapImage": true
}

The log shows:
[19:02:53] INFO: Setup config
[19:02:53] INFO: Start ICantVelieveItsNotValetudo

><EMAIL_ADDRESS>start /app
> node app.js

Loading configuration file: /app/config.json
Connecting to MQTT Broker
Webserver running on port 3000

I just re-installed the add-on, no change.
add-on version: 0.2.0-5
home-assisant info:
arch | x86_64
dev | false
docker | true
hassio | true
os_name | Linux
python_version | 3.7.6
timezone | Europe/Amsterdam
version | 0.104.3
virtualenv | false

host system: Ubuntu 19.10

You replaced the username and password in the broker_url ? And your Home Assistant is available under hassio.local?

Hmm, I replaced hassio.local with the real IP address and now it works, apparently it couldn't resolve? Thanks for the answer!


EMA update on CosineCodebook

The original VIT-VQGAN paper does not seem to use EMA update for codebook learning since their codebook is unit-normalized vectors.
Particularly, to my understanding, EMA update does not quite make sense when the encoder outputs and codebook vectors are unit-normalized ones.
What's your take on this? Should we NOT use EMA update with CosineCodebook?

Would you like to explain why esm does not work for unit-normalized codebook?

I found when using EMA for cosine code book, the l2-norm of the input to the vq module would grow gradually, from 22 -> 20000, leading to growing training loss. Has anyone met this problem?

@le4m yes i do think you may be correct
i just reread the vit-vqgan paper and they are only using a commitment loss with a weight of 0.25

I found when using EMA for cosine code book, the l2-norm of the input to the vq module would grow gradually, from 22 -> 20000, leading to growing training loss. Has anyone met this problem?

In case anyone else has this problem, I add a layernorm layer after the vq_in projection, and the growing norm problem is largely solved.

@Saltychtao  I also encounter a similar issue. Does vq_in refer to VectorQuantize.project_in?

@Saltychtao I also encounter a similar issue. Does vq_in refer to VectorQuantize.project_in?

Yes.

I found when using EMA for cosine code book, the l2-norm of the input to the vq module would grow gradually, from 22 -> 20000, leading to growing training loss. Has anyone met this problem?

In case anyone else has this problem, I add a layernorm layer after the vq_in projection, and the growing norm problem is largely solved.

Hi, just want to make sure that the current vesion of implementation here seems to put one normalization (l2norm) after the project_in. I also encounter the training loss explosion issue somehow at current version

@santisy want to try turning this on
let me know if it helps


Track down any missing spans in IR-gen

Similarly to what was done in https://github.com/FuelLabs/sway/pull/1250.. there may be other instances where errors are missing spans.

Under ir_generation, we seem to be using Span::dummy() for empty spans.

...but if there is a better span available which we aren't using we should switch.


Generics

Generics work - but only because they are ignored by JS.
Need to enforce rules e.g. can only add/set a String value into a List<of String>

This exists as the norm now


[SPARK-18120 ][SPARK-19557][SQL] Call QueryExecutionListener callback methods for DataFrameWriter methods

What changes were proposed in this pull request?
We only notify QueryExecutionListener for several Dataset operations, e.g. collect, take, etc. We should also do the notification for DataFrameWriter operations.
How was this patch tested?
new regression test
close https://github.com/apache/spark/pull/16664

cc @salilsurendran @vanzin @gatorsmile @sameeragarwal

Test build #73009 has started for PR 16962 at commit ce0e126.

Test build #73012 has started for PR 16962 at commit c0dcd24.

Test build #73009 has finished for PR 16962 at commit ce0e126.

This patch passes all tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
case class SaveIntoDataSourceCommand(

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/73009/
Test PASSed.

Test build #73012 has finished for PR 16962 at commit c0dcd24.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/73012/
Test PASSed.

LGTM except three minor comments.

Test build #73023 has started for PR 16962 at commit d35fac3.

LGTM

Test build #73023 has finished for PR 16962 at commit d35fac3.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/73023/
Test PASSed.

Merged build finished. Test PASSed.

thanks for the review, merging to master!


HtmlResponse received instead of SplashJsonResponse when run as a script

I played with https://docs.scrapy.org/en/latest/topics/practices.html#run-from-script
My spider uses Scrapy-Splash so I received a weird error on callback of a SplashRequest and turns out running a script while using Scrapy-Splash doesn't work as expected.
I will try to reproduce in a fresh project but not sure if I'll get time for this.

Where are you defining project settings? If you just use CrawlerProcess(), settings.py is not applied.


YARN-10744. add more doc for yarn.federation.policy-manager-params

NOTICE
Please create an issue in ASF JIRA before opening a pull request,
and you need to set the title of the pull request which starts with
the corresponding JIRA issue number. (e.g. HADOOP-XXXXX. Fix a typo in YYY.)
For more details, please see https://cwiki.apache.org/confluence/display/HADOOP/How+To+Contribute

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 35s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
markdownlint
0m  0s

markdownlint was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
34m 24s

trunk passed

+1 :green_heart:
mvnsite
0m 28s

trunk passed

+1 :green_heart:
shadedclient
48m 13s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 16s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
mvnsite
0m 18s

the patch passed

+1 :green_heart:
shadedclient
13m 24s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
asflicense
0m 33s

The patch does not generate ASF License warnings.

64m 39s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2934/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/2934

Optional Tests
dupname asflicense mvnsite codespell markdownlint

uname
Linux c3c482358b88 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 4f2f21572da5308fd4959ae4dea03329461d3783

Max. process+thread count
542 (vs. ulimit of 5500)

modules
C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2934/1/console

versions
git=2.25.1 maven=3.6.3

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.


Ensure nightly copies of data directory for database to Azure's storage server.

Use Case: Mount directory as a volume where the database contents will preside.  We need to copy the database from the production directory into a separate storage hosted by Azure (same as AWS S3 product).


Image replacment and duplicate select

Hi,
I use the js to tranform an  static nav.In this static nav, i use an image that is replace by empty space in the mobile selectnav.
How can i replace the image by some text, like the title or alt attribute ?
Second point, i have an issue on a duplicate select nav on mobile..no way to know about the guilt..
thanks

fixed by clear duplicate code.


⚠ Thumbnails API Endpoint has degraded performance

In 594c929, Thumbnails API Endpoint (https://thumbnails.roblox.com/v1/assets?assetIds=82738847&format=Png&isCircular=false&size=30x30) experienced degraded performance:

HTTP code: 200
Response time: 4436 ms

Resolved: Thumbnails API Endpoint performance has improved in 8201384.


Block failed unserializations from entering L1

This is already handled safely during sync, but a truncated entry in the database could also produce bad data. #32 prevents L2 caches from returning bad items during get calls, but the failure should be noisier.

#33 makes it appropriately noisy.


Add Idempotency test for virtual funding

https://github.com/statechannels/monorepo/issues/1603

included in https://github.com/statechannels/monorepo/pull/1631


Added README-QWIKLABS.md

Identical to README.md, without Prerequisites section.

/assign @chrislovecnm


feat: Store outbound messages

For https://input-output.atlassian.net/browse/ATL-5339

I'm going to merge
The CI tested passes and the integration tests we know it will fail


GPU OOM while fine-tuning MPT-7B

Hi,
I want to finetune MPT-7b and I get OOM error. This is what I run:
python ./llm-foundry/scripts/train/train.py ./llm-foundry/scripts/train/yamls/finetune/mpt-7b_dolly_sft.yaml train_loader.dataset.split=train eval_loader.dataset.split=test
I have changed the seq_length to 512.
And I have not changed anything in the yaml file since I want to fine tune it in the default dataset first. I use the gdn.12xlarge instance. Appreciate any input

I believe that AWS instance has 4xT4 ~= 64GB of VRAM. You want at least twice that. Also, this stack is mostly tested on AA100s and there have been reports in the Triton repo that Triton does not work (or does not work well) on T4s.

@samhavens thanks for your comment. I cannot even run it on g5.48xlarge with 768 memory!.  each gpu has 24gig ram I guess. I think for some reason it does not use 8 gpus and just uses 1 gpu!!!

@samhavens this is the detail of gpus:
GPU  Name        Persistence-M| Bus-Id        Disp.A | Volatile Uncorr. ECC |
| Fan  Temp  Perf  Pwr:Usage/Cap|         Memory-Usage | GPU-Util  Compute M. |
|                               |                      |               MIG M. |
|===============================+======================+======================|
|   0  NVIDIA A10G         Off  | 00000000:00:16.0 Off |                    0 |
|  0%   30C    P0    59W / 300W |      0MiB / 22731MiB |      0%      Default |
|                               |                      |                  N/A |
+-------------------------------+----------------------+----------------------+
|   1  NVIDIA A10G         Off  | 00000000:00:17.0 Off |                    0 |
|  0%   30C    P0    60W / 300W |      0MiB / 22731MiB |      0%      Default |
|                               |                      |                  N/A |
+-------------------------------+----------------------+----------------------+
|   2  NVIDIA A10G         Off  | 00000000:00:18.0 Off |                    0 |
|  0%   29C    P0    58W / 300W |      0MiB / 22731MiB |      0%      Default |
|                               |                      |                  N/A |
+-------------------------------+----------------------+----------------------+
|   3  NVIDIA A10G         Off  | 00000000:00:19.0 Off |                    0 |
|  0%   28C    P0    59W / 300W |      0MiB / 22731MiB |      0%      Default |
|                               |                      |                  N/A |
+-------------------------------+----------------------+----------------------+
|   4  NVIDIA A10G         Off  | 00000000:00:1A.0 Off |                    0 |
|  0%   29C    P0    60W / 300W |      0MiB / 22731MiB |      0%      Default |
|                               |                      |                  N/A |
+-------------------------------+----------------------+----------------------+
|   5  NVIDIA A10G         Off  | 00000000:00:1B.0 Off |                    0 |
|  0%   28C    P0    62W / 300W |      0MiB / 22731MiB |      0%      Default |
|                               |                      |                  N/A |
+-------------------------------+----------------------+----------------------+
|   6  NVIDIA A10G         Off  | 00000000:00:1C.0 Off |                    0 |
|  0%   28C    P0    59W / 300W |      0MiB / 22731MiB |      0%      Default |
|                               |                      |                  N/A |
+-------------------------------+----------------------+----------------------+
|   7  NVIDIA A10G         Off  | 00000000:00:1D.0 Off |                    0 |
|  0%   28C    P0    55W / 300W |      0MiB / 22731MiB |      0%      Default |
|                               |                      |                  N/A

@samhavens this is the detail:
after running nvidia-smi I get 8 gpus with these specification::
0  NVIDIA A10G         Off  | 00000000:00:16.0 Off |                    0 |
|  0%   30C    P0    59W / 300W |      0MiB / 22731MiB |      0%      Default

Do you get an OOM with the A10s as well, or a different error?

Yes I get OOM with A10 @samhavens 👍
This is the whole error:
/llm-foundry/scripts/train/tra │ │ in.py:268 in <module>                                                        │ │                                                                              │ │   265 │   │   yaml_cfg = om.load(f)                                          │ │   266 │   cli_cfg = om.from_cli(args_list)                                   │ │   267 │   cfg = om.merge(yaml_cfg, cli_cfg)                                  │ │ ❱ 268 │   main(cfg)                                                          │ │   269                                                                        │ │                                                                              │ │ /llm-foundry/scripts/train/tra │ │ in.py:210 in main                                                            │ │                                                                              │ │   207 │                                                                      │ │   208 │   # Build the Trainer                                                │ │   209 │   print('Building trainer...')                                       │ │ ❱ 210 │   trainer = Trainer(                                                 │ │   211 │   │   run_name=cfg.run_name,                                         │ │   212 │   │   seed=cfg.seed,                                                 │ │   213 │   │   model=model,                                                   │ │                                                                              │ │ /local_disk0/.ephemeral_nfs/envs/pythonEnv-51886180-d57b-46eb-82e9-4b389eeb2 │ │ c8b/lib/python3.10/site-packages/composer/trainer/trainer.py:957 in __init__ │ │                                                                              │ │    954 │   │   │   prepare_fsdp_module(model, optimizers, self.fsdp_config,  │ │    955 │   │                                                                 │ │    956 │   │   # Reproducibility                                             │ │ ❱  957 │   │   rank_zero_seed, seed = _distribute_and_get_random_seed(seed,  │ │    958 │   │   # If hparams is used to create the Trainer this function is c │ │    959 │   │   # which is okay because all runs with the hparams codepath wi │ │    960 │   │   reproducibility.seed_all(seed)                                │ │                                                                              │ │ /local_disk0/.ephemeral_nfs/envs/pythonEnv-51886180-d57b-46eb-82e9-4b389eeb2 │ │ c8b/lib/python3.10/site-packages/composer/trainer/trainer.py:288 in          │ │ _distribute_and_get_random_seed                                              │ │                                                                              │ │    285 │   │   raise ValueError(f'Invalid seed: {seed}. It must be on [0; 2* │ │    286 │                                                                     │ │    287 │   # using int64 to prevent overflow                                 │ │ ❱  288 │   rank_zero_seed = device.tensor_to_device(torch.tensor([seed], dty │ │    289 │   if dist.get_world_size() > 1:                                     │ │    290 │   │   dist.broadcast(rank_zero_seed, src=0)                         │ │    291 │   rank_zero_seed = rank_zero_seed.item()                            │ │                                                                              │ │ /local_disk0/.ephemeral_nfs/envs/pythonEnv-51886180-d57b-46eb-82e9-4b389eeb2 │ │ c8b/lib/python3.10/site-packages/composer/devices/device_gpu.py:59 in        │ │ tensor_to_device                                                             │ │                                                                              │ │   56 │   │   return module.to(self._device)                                  │ │   57 │                                                                       │ │   58 │   def tensor_to_device(self, tensor: torch.Tensor) -> torch.Tensor:   │ │ ❱ 59 │   │   return tensor.to(self._device, non_blocking=True)               │ │   60 │                                                                       │ │   61 │   def state_dict(self) -> Dict[str, Any]:                             │ │   62 │   │   return {
also this is at the begining if that helps:
1 %sh python /llm-foundry/scripts/train/train.py /llm-foundry/scripts/train/yamls/finetune/mpt-7b_dolly_sft.yaml train_loader.dataset.split=train eval_loader.dataset.split=test  2023-06-15 02:47:54.630018: I tensorflow/core/platform/cpu_feature_guard.cc:193] This TensorFlow binary is optimized with oneAPI Deep Neural Network Library (oneDNN) to use the following CPU instructions in performance-critical operations:  AVX2 FMA To enable them in other operations, rebuild TensorFlow with the appropriate compiler flags. /llm-foundry/scripts/train/train.py:131: UserWarning: FSDP is not applicable for single-GPU training. Reverting to DDP.   warnings.warn( Running on device: cuda
appreciate any input!

Hello @benam2 , this may be a clue:
UserWarning: FSDP is not applicable for single-GPU training

Are you using a launcher to create multiple processes, one for each GPU? If not, you may only be using 1 of the A10s in your node.

Closing as stale. Please open a new issue if you are still encountering problems.


Virtual table OData metadata caching

Per Microsoft Support case #<PHONE_NUMBER>000172, Dataverse caches the external OData metadata (columns, data types, etc.) for up to eight hours and there is no way to manually refresh the cache. Thus, if you have a working virtual table in production, for example, and you add a virtual column to the OData source and in Dataverse, it can take up to eight hours for Dataverse to recognize the new column. Until that time, attempting to display the virtual table's data results in an error. Please update this page to reflect what support has described as a "product limitation" in this area. Thanks.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 42ae2cb6-ce2a-21c7-cb81-b60e7b026753
Version Independent ID: 5a3cb7c0-6881-1d96-0dc3-639324a4568c
Content: Get started with virtual tables (entities) (Microsoft Dataverse) - Power Apps
Content Source: powerapps-docs/developer/data-platform/virtual-entities/get-started-ve.md
Service: powerapps
GitHub Login: @NHelgren
Microsoft Alias: nhelgren

Thanks for your comment, @tdutch1. This issue has been assigned to the doc author for review.


Emitting events when updating schema

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@90d2df9). Click here to learn what that means.
The diff coverage is 75.86%.

@@            Coverage Diff            @@
##             master    #2073   +/-   ##
=========================================
  Coverage          ?   69.37%
=========================================
  Files             ?      830
  Lines             ?    39707
  Branches          ?     5381
=========================================
  Hits              ?    27547
  Misses            ?    10313
  Partials          ?     1847

Impacted Files
Coverage Δ

...i/resources/PinotSegmentUploadRestletResource.java
50.51% <ø> (ø)

.../com/linkedin/pinot/controller/ControllerConf.java
43.96% <0%> (ø)

...data/manager/offline/AbstractTableDataManager.java
91.58% <100%> (ø)

...ller/api/resources/PinotSchemaRestletResource.java
44.44% <100%> (ø)

...m/linkedin/pinot/controller/ControllerStarter.java
59.37% <100%> (ø)

...i/events/DefaultMetadataChangeNotifierFactory.java
100% <100%> (ø)

...ller/api/events/DefaultMetadataChangeNotifier.java
66.66% <66.66%> (ø)

...ller/api/events/MetadataChangeNotifierFactory.java
75% <75%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 90d2df9...0897a59. Read the comment docs.


add TALC to news

I overlooked TALC when I was writing the news page. This should be added to the 3.0 release announcement.

PR #208 created that addresses this issue


Build error on linux

I did the
$ git submodule update --recursive --init
$ cargo build --release

And then it failed with this lengthy error:
https://mystb.in/IntentNaplesCut.sql

Having the same issue.

Having the same issue.

I have opened https://github.com/jpochyla/soundio-rs/pull/2 to be able to try psst out.
You can try the fix out by adding the following to the root workspace Cargo.toml:
[patch."https://github.com/jpochyla/soundio-rs"]
soundio = { git = "https://github.com/gferon/soundio-rs", branch = "lib64-prefix" }

Depending on your distribution, you might need to install libpulse-dev and libasound2-dev (Debian based) or libpulse-devel and alsa-lib-devel (Fedora).

I have opened https://github.com/jpochyla/soundio-rs/pull/2 to be able to try psst out.
You can try the fix out by adding the following to the root workspace Cargo.toml:
[patch."https://github.com/jpochyla/soundio-rs"]
soundio = { git = "https://github.com/gferon/soundio-rs", branch = "lib64-prefix" }

Depending on your distribution, you might need to install libpulse-dev and libasound2-dev (Debian based) or libpulse-devel and alsa-lib-devel (Fedora).

Can you please confirm that the merged soundio-rs PR fixes the issue? Thanks!

Can you please confirm that the merged soundio-rs PR fixes the issue? Thanks!

I am still getting an error on Arch Linux. I have libpulse installed.`
Output here

I am still getting an error on Arch Linux. I have libpulse installed.`
Output here

Confirmed.

Confirmed.

Oh, alright! In the longer term I was thinking about switching to miniaudio library, can you please test how the miniaudio branch acts on Linux? At least the build should be much simpler.

Oh, alright! In the longer term I was thinking about switching to miniaudio library, can you please test how the miniaudio branch acts on Linux? At least the build should be much simpler.

error[E0277]: the trait bound `miniaudio::Error: StdError` is not satisfied
   --> psst-core/src/audio_output.rs:119:33
    |
119 |         Error::AudioOutputError(Box::new(err))
    |                                 ^^^^^^^^^^^^^ the trait `StdError` is not implemented for `miniaudio::Error`
    |
    = note: required for the cast to the object type `dyn StdError + Send`

error: aborting due to previous error

error[E0277]: the trait bound `miniaudio::Error: StdError` is not satisfied
   --> psst-core/src/audio_output.rs:119:33
    |
119 |         Error::AudioOutputError(Box::new(err))
    |                                 ^^^^^^^^^^^^^ the trait `StdError` is not implemented for `miniaudio::Error`
    |
    = note: required for the cast to the object type `dyn StdError + Send`

error: aborting due to previous error

Oh, alright! In the longer term I was thinking about switching to miniaudio library, can you please test how the miniaudio branch acts on Linux? At least the build should be much simpler.

Still causing errors, albeit a different one.
error: failed to run custom build command for `minivorbis-sys v0.1.0 (/home/deep/work/rust/psst2/minivorbis-sys)`

Caused by:
  process didn't exit successfully: `/home/deep/work/rust/psst2/target/release/build/minivorbis-sys-d0333698c850c4c8/build-script-build` (exit code: 1)
  --- stdout
  TARGET = Some("x86_64-unknown-linux-gnu")
  OPT_LEVEL = Some("3")
  HOST = Some("x86_64-unknown-linux-gnu")
  CC_x86_64-unknown-linux-gnu = None
  CC_x86_64_unknown_linux_gnu = None
  HOST_CC = None
  CC = None
  CFLAGS_x86_64-unknown-linux-gnu = None
  CFLAGS_x86_64_unknown_linux_gnu = None
  HOST_CFLAGS = None
  CFLAGS = None
  CRATE_CC_NO_DEFAULTS = None
  DEBUG = Some("false")
  CARGO_CFG_TARGET_FEATURE = Some("fxsr,sse,sse2")
  running: "cc" "-O3" "-ffunction-sections" "-fdata-sections" "-fPIC" "-m64" "-I" "./minivorbis" "-Wall" "-Wextra" "-o" "/home/deep/work/rust/psst2/target/release/build/minivorbis-sys-1e86d7b261e275b1/out/./minivorbis.o" "-c" "./minivorbis.c"
  cargo:warning=./minivorbis.c:6:10: fatal error: minivorbis.h: No such file or directory
  cargo:warning=    6 | #include "minivorbis.h"
  cargo:warning=      |          ^~~~~~~~~~~~~~
  cargo:warning=compilation terminated.
  exit code: 1

  --- stderr

  error occurred: Command "cc" "-O3" "-ffunction-sections" "-fdata-sections" "-fPIC" "-m64" "-I" "./minivorbis" "-Wall" "-Wextra" "-o" "/home/deep/work/rust/psst2/target/release/build/minivorbis-sys-1e86d7b261e275b1/out/./minivorbis.o" "-c" "./minivorbis.c" with args "cc" did not execute successfully (status code exit code: 1).

How do I get minivorbis.h?

Oh, alright! In the longer term I was thinking about switching to miniaudio library, can you please test how the miniaudio branch acts on Linux? At least the build should be much simpler.

Still causing errors, albeit a different one.
error: failed to run custom build command for `minivorbis-sys v0.1.0 (/home/deep/work/rust/psst2/minivorbis-sys)`

Caused by:
  process didn't exit successfully: `/home/deep/work/rust/psst2/target/release/build/minivorbis-sys-d0333698c850c4c8/build-script-build` (exit code: 1)
  --- stdout
  TARGET = Some("x86_64-unknown-linux-gnu")
  OPT_LEVEL = Some("3")
  HOST = Some("x86_64-unknown-linux-gnu")
  CC_x86_64-unknown-linux-gnu = None
  CC_x86_64_unknown_linux_gnu = None
  HOST_CC = None
  CC = None
  CFLAGS_x86_64-unknown-linux-gnu = None
  CFLAGS_x86_64_unknown_linux_gnu = None
  HOST_CFLAGS = None
  CFLAGS = None
  CRATE_CC_NO_DEFAULTS = None
  DEBUG = Some("false")
  CARGO_CFG_TARGET_FEATURE = Some("fxsr,sse,sse2")
  running: "cc" "-O3" "-ffunction-sections" "-fdata-sections" "-fPIC" "-m64" "-I" "./minivorbis" "-Wall" "-Wextra" "-o" "/home/deep/work/rust/psst2/target/release/build/minivorbis-sys-1e86d7b261e275b1/out/./minivorbis.o" "-c" "./minivorbis.c"
  cargo:warning=./minivorbis.c:6:10: fatal error: minivorbis.h: No such file or directory
  cargo:warning=    6 | #include "minivorbis.h"
  cargo:warning=      |          ^~~~~~~~~~~~~~
  cargo:warning=compilation terminated.
  exit code: 1

  --- stderr

  error occurred: Command "cc" "-O3" "-ffunction-sections" "-fdata-sections" "-fPIC" "-m64" "-I" "./minivorbis" "-Wall" "-Wextra" "-o" "/home/deep/work/rust/psst2/target/release/build/minivorbis-sys-1e86d7b261e275b1/out/./minivorbis.o" "-c" "./minivorbis.c" with args "cc" did not execute successfully (status code exit code: 1).

How do I get minivorbis.h?

Did you run git submodule update --recursive --init?

Did you run git submodule update --recursive --init?

Yes

Yes

Did you run git submodule update --recursive --init?

Silly me, I deleted and re-cloned and then forgot to update the sub-module.
Now getting same as @JojiiOfficial

Did you run git submodule update --recursive --init?

Silly me, I deleted and re-cloned and then forgot to update the sub-module.
Now getting same as @JojiiOfficial

Yes

I think he was referring to my comment. Sorry for creating a confusion

Yes

I think he was referring to my comment. Sorry for creating a confusion

I think he was referring to my comment. Sorry for creating a confusion
I just didn't notice your comment :P

I think he was referring to my comment. Sorry for creating a confusion
I just didn't notice your comment :P

Edit: This is the only error. Replacing this with some StdError implementing error, it compiles.

Great, thanks! I've merged the miniaudio branch into master, I suppose that's the way forward now. Closing this issue, as it started as a libsoundio problem.

Edit: This is the only error. Replacing this with some StdError implementing error, it compiles.

Great, thanks! I've merged the miniaudio branch into master, I suppose that's the way forward now. Closing this issue, as it started as a libsoundio problem.

Still cannot build master even with latest merge:
   Compiling druid v0.7.0 (https://github.com/linebender/druid#ed4f9ef0)
error[E0034]: multiple applicable items in scope
   --> /home/cook/.cargo/git/checkouts/druid-f71533f3d81c0bc8/ed4f9ef/druid/src/text/editable_text.rs:200:19
    |
200 |         if !range.is_empty() || !new.is_empty() {
    |             ------^^^^^^^^--
    |             |     |
    |             |     multiple `is_empty` found
    |             help: disambiguate the associated function for candidate #2: `std::iter::ExactSizeIterator::is_empty(&range)`
    |
    = note: candidate #1 is defined in an impl for the type `std::ops::Range<Idx>`
    = note: candidate #2 is defined in an impl of the trait `std::iter::ExactSizeIterator` for the type `std::ops::Range<usize>`

error: aborting due to previous error

For more information about this error, try `rustc --explain E0034`.

Still cannot build master even with latest merge:
   Compiling druid v0.7.0 (https://github.com/linebender/druid#ed4f9ef0)
error[E0034]: multiple applicable items in scope
   --> /home/cook/.cargo/git/checkouts/druid-f71533f3d81c0bc8/ed4f9ef/druid/src/text/editable_text.rs:200:19
    |
200 |         if !range.is_empty() || !new.is_empty() {
    |             ------^^^^^^^^--
    |             |     |
    |             |     multiple `is_empty` found
    |             help: disambiguate the associated function for candidate #2: `std::iter::ExactSizeIterator::is_empty(&range)`
    |
    = note: candidate #1 is defined in an impl for the type `std::ops::Range<Idx>`
    = note: candidate #2 is defined in an impl of the trait `std::iter::ExactSizeIterator` for the type `std::ops::Range<usize>`

error: aborting due to previous error

For more information about this error, try `rustc --explain E0034`.

Sorry for the late response.

gradlew test succeeds with this tooltip screenshot so I'm guessing that means that the test is suceeding.
Tooltips in my actual project do not work at all now, and just briefly blink a black square before going away.

Sorry for the late response.

gradlew test succeeds with this tooltip screenshot so I'm guessing that means that the test is suceeding.
Tooltips in my actual project do not work at all now, and just briefly blink a black square before going away.

Latest Rust needed, rustup update.

Latest Rust needed, rustup update.

Latest Rust needed, rustup update.

Latest Rust needed, rustup update.