CalendarView entity in layout file not being processed properly

I have this Java code (in an AppCompatActivity class) and a layout file which works fine in a simple example, but fails when I try to add the CalendarView to a larger existing app:
    CalendarView cv;
    cv = findViewById(R.id.calendarView);
    // then initialise the CalendarView

and a layout file with this:
<com.kizitonwose.calendarview.CalendarView
    android:id="@+id/calendarView"
    ... />

I have an error in the java file "Type parameter T has incompatible upper bounds : View and CalendarView"
Explicitly casting: CalendarView calendarView = (CalendarView) findViewById(R.id.calendarView);
the error becomes "Inconvertable types: cannot cast 'android.view.View' to  'com.kizitonwose.calendarview.CalendarView'
It seems that somehow the CalendarView entity in the layout file is being treated as something else.
Interestingly, I cannot refactor/rename "@+id/calendarView" as the Refactor operation is greyed out. (I can refactor it if I change the XML to <CalendarView...) - is this a clue? Does it imply that the layout file is not being properly processed?
If I right-click on R.id.calendarView and click "Go to Declaration" I am correctly taken to the layout file. I appear to have added the library dependency correctly to build.gradle. No amount of cleaning or invalidating of caches have effects. I deleted the .gradle, build and app/build directories - no change.
What is happening and how do I fix it?

Have you migrated to AndroidX yet?

Yes, refactored to AndroidX, latest Gradle etc, AFAIK

Okay, try explicitly adding a dependency for recyclerview to your app level build.gradle and see if that fixes it.
implementation 'androidx.recyclerview:recyclerview:1.1.0-alpha06'

Also, are you on the latest version 0.2.0 which has some fixes?

Hi Kizito. Thanks for this. I tried both of your suggestions: the addition of the recyclerview dependency fixed the problem. (I had been using 0.1.2 but change to 0.2.0 did not fix the problem).
I guess you will update the readme.MD to include this advice.

I have figured this out. If you clean your Gradle cache now and resync version 0.2.0 you'll see that this is now resolved. You can continue using your workaround if you don't want to clean your Gradle cache. I guess this issue was not raised earlier because many projects already have RecyclerView dependency, including the sample project.
Will close this issue now.


enh: add initialize user recipe (added in building blocks) in all the other APIs

Time Spent

Date
Time

06/19/23
4.0

06/20/23
6.5

Total
10.5

[x] Content Management API
[x] Project Management API
[x] Classroom API
[x] Conversation API

PR: https://github.com/snowpal/pitch-content-management-sdk/pull/9

Recording
https://github.com/snowpal/pitch-building-blocks-sdk/assets/3121529/7734d50b-8a34-4fe4-95b8-1a8aca5164a4


Update feature-overview.md

Issue https://github.com/authzed/spicedb/issues/14 was closed in March - so updated docs to reflect that any OpenTelemetry Collector can be used.

I have read the CLA Document and I hereby sign the CLA

recheck

sorry for the delay, and thanks for the contribution!


Couldn't initialise replay: 16

Description
status,controller = cap.OpenCapture(rd.ReplayOptions(), None)
if status != rd.ReplayStatus.Succeeded:
raise RuntimeError("Couldn't initialise replay: " + str(status))
status=16, controller=None
python:3.6.4
Steps to reproduce
run example
path:  docs\python_api\examples\renderdoc_intro.py

Hi there, your issue has been closed again due to not correctly following the issue template. DO NOT open another issue that is badly formatted or I will temporarily block you.
Please read the documentation about filing issues and open a new issue which does follow the issue template. Do not reply to this issue with more information or with a correctly formatted issue, as that will only lead to confusion.
I try to address all github issues and fix bugs quickly, but badly formatted issues or poorly described bug reports especially are a significant drain on project resources. Taking a few minutes to file a good issue makes a huge difference and will get it addressed faster - everybody wins!
In github when you first create a new issue the form is pre-populated with a template which you should read over and follow. As linked above there is documentation going into more detail about what makes a good issue.

Hi there, your issue has been closed again due to not correctly following the issue template. DO NOT open another issue that is badly formatted or I will temporarily block you.
Please read the documentation about filing issues and open a new issue which does follow the issue template. Do not reply to this issue with more information or with a correctly formatted issue, as that will only lead to confusion.
I try to address all github issues and fix bugs quickly, but badly formatted issues or poorly described bug reports especially are a significant drain on project resources. Taking a few minutes to file a good issue makes a huge difference and will get it addressed faster - everybody wins!
In github when you first create a new issue the form is pre-populated with a template which you should read over and follow. As linked above there is documentation going into more detail about what makes a good issue.


feature #856: added ability to update comments

Created update in QuestionAnswerRepository
Created updateComment in PollService
Created PATCH teachers/comment/update endpoint
Created UpdateCommentDTO
Created InvalidTypeException
Added permission
Added Swagger documentation

closes fictadvisor/fictadvisor#71

closed as outdated


Update Escalator to use Go 1.12

Go 1.12.x has been released for a while. Since Go 1.10.x support has been removed from Escalator we should add Go 1.12.x support

We should bump to the latest version of 1.12 to mitigate the new CVEs

Needs to be at least 1.12.8 to get the fixes, but 1.12.9 came out today, so you may want to go to that. ;)


Strange input for error handler.

Scenario
I've got a class HttpError extends Error.
Then I am calling next() passing in an instance of HttpError.
What is expected
An instance of HttpError is received in my error handler.
What actually happened
An instance of Error is received in my error handler.
What I need
I need help with this issue. Why is this happening? How can I solve it? Thanks.

Hi @RedTailBullet sorry you're having an issue. This is strange as I don't know of anything in Express that would alter error objects. I tried to reproduce but was unsuccessful. Can you help by providing the following?

Version of node.js
Version of Express.js
Code we can run to reproduce the issue

Thanks!

Sorry for the late reply.
I just confirmed that this might be an Typescript issue rather than an Express.js issue. Will close this issue now. Thanks.


WVJB for Android

Review and consider merging in Android work done by @fangj in https://github.com/fangj/WebViewJavascriptBridge.

Exciting  features!

Excitied!

nice

此邮件来自易信
网易邮箱推出官方手机客户端--邮箱大师 马上体验
在2016年1月12日 16:59:10, lishaoping<EMAIL_ADDRESS>写道：
nice
—
Reply to this email directly or view it on GitHub.

waiting for the Android compatible implementation.

waiting！！！！！

If you build it and PR, I'll totally merge in :)
On Tue, Jan 26, 2016 at 2:11 AM, xiayong<EMAIL_ADDRESS>wrote:

waiting！！！！！
—
Reply to this email directly or view it on GitHub
https://github.com/marcuswestin/WebViewJavascriptBridge/issues/103#issuecomment-174866684
.

waiting too~

Any news on this feature?

There's https://github.com/marcuswestin/WebViewJavascriptBridge/pull/217, but it doesn't follow the API of the existing ObjC WebViewJavascriptBridge, and isn't very clean code. I'm still willing to accept a proper implementation.

@marcuswestin
I guess the long time between https://github.com/fangj/WebViewJavascriptBridge submitted the PR and you responding caused this to collapse.
Anyway, it seems a shame to not get this done as i am sure its really useful for many people.
i had a look at the code and also your request to a code cleanup.
I noticed that you also offered to document where you see things need to be changed to make the code clean. Would you will willing to do that still ?
I think its highly likely that me and hopefully others can do that work.

@gedw99 Yeah, having a kid, early stage startups and solo-maintaining multiple open source projects don't go together very well :)
I don't think fangj ever did a PR though, did he? The only Android PR I recall is this #217, which is a good start but not as good as fangj's I believe. Only looked closely enough to know it wasn't ready for primetime.
I would love that! If you take ownership I will make sure to be available for any discussions and questions with minimal turnaround time. How about I start with a rough sketch of what I think we'd need, and you start from there?
Let me know what you think!
Android WVJB - rough sketch
I think the guiding principle of an Android version should be to mirror the ObjC version, except when there are strong reasons not to (in which case we should consider reshaping the ObjC version to mirror the Android one). The motivation is two-fold: First, understanding one version should make it very simple to understand and navigate the other; and second, when we add features to one version it should be simple to also add it to the other. I believe there are five major areas where we need parity and similarity: API design, native code, javascript code, automated testing coverage, and documentation.
API design mirroring
The Android & ObjC APIs should basically be identical, excepting language-idiomatic differences. I haven't done much Android work for a while so I'm probably not the best person to say, but I'm guessing it would be something similar to this:
WebViewJavascriptBridge* bridge = WebViewJavascriptBridge.bridgeForWebView(webView);
bridge.registerHandler("getScreenHeight", (message, responseCallback) -> {
	responseCallback(message);
});

Native code mirroring:
This one is a bit of a stretch and may not make sense at the end of the day, but my guess is that the most appropriate implementation would look very similar in layout and structure to the ObjC WVJB base:

https://github.com/marcuswestin/WebViewJavascriptBridge/blob/master/WebViewJavascriptBridge/WebViewJavascriptBridgeBase.m

Javascript code mirroring:
The ObjC and Android code bases should use the same javascript code except if there are strong reasons not to. The two javascript pieces are:

bootstrap/setup snippet: https://github.com/marcuswestin/WebViewJavascriptBridge/blob/master/Example Apps/ExampleApp.html#L17
injected javascript API: https://github.com/marcuswestin/WebViewJavascriptBridge/blob/master/WebViewJavascriptBridge/WebViewJavascriptBridge_JS.m

I imagine it would make sense for the injected javascript API to be compiled from a shared source file at build time, but that's a small detail.
Automated testing mirroring
The Android version's automated testing would need to cover the same ground as the ObjC version, and be passing on travis-ci:

https://github.com/marcuswestin/WebViewJavascriptBridge/blob/master/Tests/WebViewJavascriptBridgeTests/BridgeTests.m
https://travis-ci.org/marcuswestin/WebViewJavascriptBridge

Documentation mirroring
There are a few sections in Readme.md that would need Android entries:

Installation instructions: https://github.com/marcuswestin/webviewjavascriptbridge#installation-ios--osx
Small usage guide: https://github.com/marcuswestin/webviewjavascriptbridge#usage
Java API: https://github.com/marcuswestin/webviewjavascriptbridge#objc-api
Example apps: https://github.com/marcuswestin/webviewjavascriptbridge#examples (always the easiest way to grok a new library)

I imagine the installation instructions would cover whatever the commonly used IDEs are, though they could of course be fleshed out with time.
Considering the Readme.md file would start getting a bit unwieldy at that point it may make more sense to have Readme.md just link to e.g Readme-apple.md, Readme-android.md and Readme-javascript.md.
Android version support
Finally, whoever takes on ownership of developing the Android version of WVJB would also take on support and maintenance, and/or involve other people who take it on. Roughly, that breaks down to responding to any android issues on GH, and manage, clean up and merge any android PRs.
Whoever takes this on would naturally get full r/w access to the repo!

Congrats! That's super exciting :)
Oh well, if/when you change your mind there's at least a clear direction to start in.
Cheers!

Congrats! That's super exciting :)
Oh well, if/when you change your mind there's at least a clear direction to start in.
Cheers!

Cattle people, how about Android?

Related: #217

That's too bad


RFC: *: a new option for configuring a coefficient of randomized election …

…timeout
This commit adds a new option --randomized-election-coefficient. The
value specified with the option will be used for calculating the
randomized election timeout in
raft.resetRandomizedElectionTimeout(). If the coefficient is low
(e.g. 0), randomness of the election will become low and split
vote will likely happen.
Of course, the split vote decreases availability and nobody wants
it. However, if we can cause the situation intentionally, it will be
useful for debugging the candidate state that is ephemeral in
realistic deployments.
Actually, letting the coefficient 0 in testing on a single machine
(just adding --randomized-election-coefficient 0.0 to entries of
Procfile) shows lots of split vote situation after killing a leader
node.
/cc @gyuho how do you think about this? I thought it would be useful for reproducing problems like https://github.com/coreos/etcd/issues/7239, those relate to the candidate state (the callstack of the issue shows stepCandidate()). Also, using this option from functional tester would increase a chance of hitting such bugs?

/cc @xiang90 @heyitsanthony

This is a lot of code churn for a debugging option. Maybe this can be done by checking an environment variable (RAFT_DEBUG_NORAND?) and overriding globalRand in the raft package's init()? /cc @xiang90

@heyitsanthony I feel using a special environmental variable is a little bit dangerous because accidentally turning on it harms availability. But if the new option isn't acceptable, I'll use the env var.

On the second thought, the split vote was invoked accidentally by my mistake in the change. It seems that reducing the election timeout doesn't cause the split vote on my environment (and possibly on realistic test environments). So I'm closing this.


Add 'countries' API endpoint and resource

This PR adds a new API resource Country that allows fetching, creating, updating and deleting instances of Shopware\Models\Country\Country. Furthermore it adds an API controller, which uses the new resource to provide all its operations via the REST API.
This PR does not introduce any breaking changes.

Hello,
thank you for creating this pull request.
I have opened an issue on our Issue Tracker for you. See the issue link: https://issues.shopware.com/#/issues/SW-14869.
Please use this issue to track the state of your pull request.

@svenmuennich The build is failing: https://travis-ci.org/shopware/shopware/jobs/125740822
unit-shopware-continuous:
     [exec] PHPUnit 5.3.2 by Sebastian Bergmann and contributors.
     [exec]
     [exec] Runtime:       PHP 5.6.5 with Xdebug 2.2.7
     [exec] Configuration: /home/travis/build/shopware/shopware/tests/phpunit.xml.dist
     [exec]
     [exec] .............................................................   61 / 1061 (  5%)
     [exec] .............................................................  122 / 1061 ( 11%)
     [exec] .............................................................  183 / 1061 ( 17%)
     [exec] .............................................................  244 / 1061 ( 22%)
     [exec] .............................................................  305 / 1061 ( 28%)
     [exec] .............................................................  366 / 1061 ( 34%)
     [exec] ..........PHP Fatal error:  Cannot use Shopware\Models\Country\Country as Country because the name is already in use in /home/travis/build/shopware/shopware/engine/Shopware/Components/Api/Resource/Translation.php on line 35
     [exec] PHP Stack trace:
     [exec] PHP   1. {main}() /home/travis/build/shopware/shopware/vendor/phpunit/phpunit/phpunit:0
     [exec] PHP   2. PHPUnit_TextUI_Command::main() /home/travis/build/shopware/shopware/vendor/phpunit/phpunit/phpunit:47
     [exec] PHP   3. PHPUnit_TextUI_Command->run() /home/travis/build/shopware/shopware/vendor/phpunit/phpunit/src/TextUI/Command.php:110
     [exec] PHP   4. PHPUnit_TextUI_TestRunner->doRun() /home/travis/build/shopware/shopware/vendor/phpunit/phpunit/src/TextUI/Command.php:159
     [exec] PHP   5. PHPUnit_Framework_TestSuite->run() /home/travis/build/shopware/shopware/vendor/phpunit/phpunit/src/TextUI/TestRunner.php:440
     [exec] PHP   6. PHPUnit_Framework_TestSuite->run() /home/travis/build/shopware/shopware/vendor/phpunit/phpunit/src/Framework/TestSuite.php:747
     [exec] PHP   7. PHPUnit_Framework_TestCase->run() /home/travis/build/shopware/shopware/vendor/phpunit/phpunit/src/Framework/TestSuite.php:747
     [exec] PHP   8. PHPUnit_Framework_TestResult->run() /home/travis/build/shopware/shopware/vendor/phpunit/phpunit/src/Framework/TestCase.php:801
     [exec] PHP   9. PHPUnit_Framework_TestCase->runBare() /home/travis/build/shopware/shopware/vendor/phpunit/phpunit/src/Framework/TestResult.php:685
     [exec] PHP  10. Shopware\Tests\Components\Api\TestCase->setUp() /home/travis/build/shopware/shopware/vendor/phpunit/phpunit/src/Framework/TestCase.php:841
     [exec] PHP  11. Shopware\Tests\Components\Api\TranslationTest->createResource() /home/travis/build/shopware/shopware/tests/Functional/Components/Api/TestCase.php:71
     [exec] PHP  12. spl_autoload_call() /home/travis/build/shopware/shopware/tests/Functional/Components/Api/TestCase.php:41
     [exec] PHP  13. Composer\Autoload\ClassLoader->loadClass() /home/travis/build/shopware/shopware/tests/Functional/Components/Api/TestCase.php:41
     [exec] PHP  14. Composer\Autoload\includeFile() /home/travis/build/shopware/shopware/vendor/composer/ClassLoader.php:301

The test were failing due to adding new countries and states to the database. I extended the new unit tests to remove all created data after testing.

We plan to implement this PR within the next days.
Can you add the new endpoint to the REST Api article in our devdocs?
https://developers.shopware.com/developers-guide/rest-api/

@janbuecker @MarcelSchmaeing I've created a PR for the dev docs: https://github.com/shopware/devdocs/pull/284

Thanks, i'll review your changes soon and merge both code and devdocs article.

PR merged with 8b1c3546694e00698bc272bce54c3a2cbaf42887.
I've added some small fixes, which were needed to manage areas of countries.

Awesome!


Uncaught TypeError: Cannot assign to read only property '_aborted' of #

The error is thrown when I click a link. It is "fixed" by making the following change in https://github.com/vuejs/vue-router/blob/master/src/directives/view/index.js#L49
previousRoute._aborted = true

To
previousRoute.$set('_aborted', true)

I'm not sure whether it's an actual fix though, as removing that line has the same effect.

Closing all pre-0.4.0 issues. Please open new ones if you are experiencing the same issue with the released version.


[WIP]wishbone.Connector class

Currently pull request as WIP:

First code for review
Further discussion in #18 on feature set of class
Connecting initiator bus with data width greater than data width of subordinate bus is not implemented. Would PR be acceptable without this implementation ?

* Connecting initiator bus with data width greater than data width of subordinate bus is not implemented. Would PR be acceptable without this implementation ?

Reason I ask is that I don't need this feature for my use case and implementation of it may take some time.

Reason I ask is that I don't need this feature for my use case and implementation of it may take some time.

In general my preference is to have a complete solution even if it takes a bit longer, but let's get the review started before you put more time into that.

We should also add support for memory maps. If the subordinate bus has a memory map, it should be exposed to the initiator bus. Something like this:
try:
    sub_map  = sub_bus.memory_map
    intr_map = MemoryMap(...)
    intr_map.add_window(sub_map, addr=0, sparse=False)
    self.intr_bus.memory_map = intr_map
except NotImplementedError:
    # Subordinate bus does not have a memory map.
    pass

Actually in the first version I even enforced a memory map on subordinate bus like the Decoder does. But I removed all memory map code after I got problems with the unit test for different granularity. I based the data_width of the memory maps o the granularity of each bus. Then you get an error when adding the subordinate memorymap to the initiator one due to different data_width.

Codecov Report

:exclamation: No coverage uploaded for pull request base (main@217d4ea). Click here to learn what that means.
The diff coverage is n/a.

:exclamation: Current head ec94f31 differs from pull request most recent head 1c7e14f. Consider uploading reports for the commit 1c7e14f to get more accurate results

@@           Coverage Diff            @@
##             main       #21   +/-   ##
========================================
  Coverage        ?   100.00%
========================================
  Files           ?         6
  Lines           ?       725
  Branches        ?       160
========================================
  Hits            ?       725
  Misses          ?         0
  Partials        ?         0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 217d4ea...1c7e14f. Read the comment docs.


sauce-connect 4.4.8

[x] brew cask audit --download {{cask_file}} is error-free.
[x] brew cask style --fix {{cask_file}} reports no offenses.
[x] The commit message includes the cask’s name and version.

Thank you for the contribution. It was merged directly as 2d61abbf8d1991565ba14d6e0331b71d4d68bafd. Your contribution is still credited to you.


[MRG] Fix plotting of annotations.

Closes https://github.com/mne-tools/mne-python/issues/3509.
I believe there was a problem with syncing the annotations when cropping and concatenating data with first_samp present. I'll still have to make some checks before merging.

I'm thinking that maybe we should prevent annotating segments outside the area of the data (it currently isn't). Now it is possible that this creates annotations in wrong positions when cropping and concatenating the data. This would mean that the data has to be concatenated before annotating split data, but I think that's okay.

+1

I think this finally works as it's supposed to. I had to make quite a bit of changes as it previously did not check whether the annotations were in the data range causing the concatenation to effectively break.

Otherwise LGTM, Travis errors seem unrelated

can you rebase to restart CIs?

Current coverage is 87.32% (diff: 94.38%)

Merging #3540 into master will increase coverage by 0.01%

@@             master      #3540   diff @@
==========================================
  Files           341        341
  Lines         60070      60222   +152
  Methods           0          0
  Messages          0          0
  Branches       9172       9237    +65
==========================================
+ Hits          52442      52586   +144
- Misses         4887       4898    +11
+ Partials       2741       2738     -3

Powered by Codecov. Last update 8aa4ad7...34daef0

All green now.

thx @jaeilepp


Keyboard accessibility and Audio description

It would be great to have access to the player controls with the keyboard. Another helpful feature would be an audio description to enhance the accessibility. Is there any chance that these features will be added?

I think you should reopen this one since audio description is still unavailable… It’s making MediaElement useless for anyone who needs to be WCAG 2.0 compliant.


[C++] parquet-arrow-test fails with undefined behaviour sanitizer

parquet-arrow-test fails with undefined behaviour sanitizer:

arrow/cpp/src/parquet/arrow/test_util.h:84:15: runtime error: signed integer overflow: 37 * 86400000 cannot be represented in type 'int'
arrow/cpp/src/parquet/arrow/test_util.h:223:15: runtime error: signed integer overflow: 49 * 86400000 cannot be represented in type 'int'

Reporter: Gawain BOLTON / @gawain-bolton
Assignee: Gawain BOLTON / @gawain-bolton
PRs and other links:

GitHub Pull Request #5929

Note: This issue was originally created as PARQUET-1707. Please see the migration documentation for further details.

Wes McKinney / @wesm:
Issue resolved by pull request 5929
https://github.com/apache/arrow/pull/5929


How to change git repository?

History:
I was working on some game (using blocks) and after few days I decided to start versioning my game.
So I had master and work in progres branch.
On second commit on work_in_progress branch I got error like "Opps, something went wrong, try next time".
After few tryings I lost half of blocks on my project (functions, onevents etc.).
I tried to pull master back but this did not help.
At the end I removed git repository and wanted to start from some part of left blocks but I do not see options to create new or switch to other repository. Why?
And why I am facing those issues with git repository, are branches not allowed?

Ok, I did another test on fresh project and:
after first commit another one is not possible due to that "opps" error.

@pelikhan

Can you share the git repo?

Here you are https://github.com/piotr-winiarski/sleza

Could you provide a precise list of actions to reproduce this issue? I tried:

create a new project
push some code changes to master
create work_in_progress branch
push code in work_in_progress branch

I will recheck this tomorrow, but I am wondering if browser type can be problematic? I am using Vivaldi. Tomorrow I will check other browser.

Our supported list of browsers is here: https://arcade.makecode.com/browsers

So, today I was playing with git on Chrome and Vivaldi and.. did not find that issue, which is strange. I am wondering if this problem can be related to have open project on PC browser and during comute on  android phone?
On very new project I do not connect it to git as I am afraid of that problem.

Ok, today I was happying working on new project, on which I connected it to git and after few hours I got "Oops" error on commit try :) ....
I checked browser console and got those errors:

Looks like related to github itself...

Now I suspect it is the utf8-Unicode encoding issues again. I need to check this when on a computer but are you using non-Latin characters by any chance?

From: piotr-winiarski @.>
Sent: Tuesday, January 4, 2022 5:20:47 AM
To: microsoft/pxt-arcade @.>
Cc: Peli de Halleux @.>; Mention @.>
Subject: Re: [microsoft/pxt-arcade] How to change git repository? (Issue #4484)
Ok, today I was happying working on new project, on which I connected it to git and after few hours I got "Oops" error on commit try :) ....
I checked browser console and got those errors:
[image]https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fuser-images.githubusercontent.com%2F62816626%2F148065130-bac05a76-dede-44c3-aa6b-9c4c519678c1.png&data=04|01|jhalleux%40microsoft.com|85409bb221b84b260c9708d9cf850591|72f988bf86f141af91ab2d7cd011db47|1|0|637768992516908772|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000&sdata=BKGmgRSOPm96IYPirQcZIItX7DnlX%2FNS93TI4fEm8xE%3D&reserved=0
Looks like related to github itself...
—
Reply to this email directly, view it on GitHubhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fmicrosoft%2Fpxt-arcade%2Fissues%2F4484%23issuecomment-1004805193&data=04|01|jhalleux%40microsoft.com|85409bb221b84b260c9708d9cf850591|72f988bf86f141af91ab2d7cd011db47|1|0|637768992516908772|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000&sdata=%2BNUGC3yk9wi6x6GjRZJHgDGGra9uyajxEI6rbNmkEF0%3D&reserved=0, or unsubscribehttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAA73QKO5JCBCAV5CP4EK2R3UULX27ANCNFSM5LFXFQDA&data=04|01|jhalleux%40microsoft.com|85409bb221b84b260c9708d9cf850591|72f988bf86f141af91ab2d7cd011db47|1|0|637768992516908772|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000&sdata=%2BKEn1o3zI5DmAyWfECLUtMzKwxrbPxhJyeI7hs%2BCE9M%3D&reserved=0.
You are receiving this because you were mentioned.Message ID: @.***>

You mean something like this:

I did few test with new project but was not albe to reproduce this with chars like "óżśłń".

No repro.


Expose original mouse event

Make Leaflet.utfgrid events extend the original events

This enables fetching other event-related metadata, like Ctrl/Shift modifier keys, off of the UtfGrid mouse event.
Also did a drive-by fix of a non-primitive-on-class-prototype bug, which causes multiple UtfGrid instances to share the same request queue, causing some grids to lose tiles.
Modified license comment to include @license annotation for better preservation by other dist-building tools. Wanted to have the uglifyjs version here do the same, but the current version is too old and didn't want to change the setup too much...
Rebuilt dist from source updates? Not sure if this should be done now or at new version/release time.

Minor code style thing:
We use a space between ) and {, so we would have () { not (){.
Normally dist rebuilds happen after merging, but if you can get the above fixed I'll merge this one so we should be ok.

Sure thing, I can back out the dist output here.
Regarding the ...){... in code, however, where did you see that?  I don't think I did that in my code changes, except for the dist update which seemed to catch something that was already on master.  Would be happy to fix it, but also raises a point:
Would you be OK with updating the dist after the merge?  In terms of the bower.json, it will pull in the dist, so the code changes won't be visible to bower consumers until that's updated.

Thanks, built.


Limit GPU binding with CUDA_VISIBLE_DEVICES or so

Hello, and, first all I'd like to thank you for project, it's still the best way we found to workaround NVIDIA cooling issues.
To the point. Thanks to latest NVIDIA drivers updates, now instead of usual primary contexts [with nwidia-smi tool] we have displayed all contexts created. So if earlier we've got output like this:
+-----------------------------------------------------------------------------+
| Processes:                                                                  |
|  GPU   GI   CI        PID   Type   Process name                  GPU Memory |
|        ID   ID                                                   Usage      |
|=============================================================================|
|    0   N/A  N/A      3541      G   /usr/libexec/Xorg                   8MiB |
|    1   N/A  N/A      3543      G   /usr/libexec/Xorg                   8MiB |
|    2   N/A  N/A      3544      G   /usr/libexec/Xorg                   8MiB |
|    3   N/A  N/A      3546      G   /usr/libexec/Xorg                   8MiB |
|    4   N/A  N/A      3548      G   /usr/libexec/Xorg                   8MiB |
|    5   N/A  N/A      3549      G   /usr/libexec/Xorg                   8MiB |
|    6   N/A  N/A      3550      G   /usr/libexec/Xorg                   8MiB |
|    7   N/A  N/A      3552      G   /usr/libexec/Xorg                   8MiB |
+-----------------------------------------------------------------------------+

...now we have:
+-----------------------------------------------------------------------------+
| Processes:                                                                  |
|  GPU   GI   CI        PID   Type   Process name                  GPU Memory |
|        ID   ID                                                   Usage      |
|=============================================================================|
|    0   N/A  N/A    400553      G   /usr/libexec/Xorg                   8MiB |
|    0   N/A  N/A    400554      G   /usr/libexec/Xorg                   0MiB |
|    0   N/A  N/A    400555      G   /usr/libexec/Xorg                   0MiB |
|    0   N/A  N/A    400556      G   /usr/libexec/Xorg                   0MiB |
|    0   N/A  N/A    400557      G   /usr/libexec/Xorg                   0MiB |
|    0   N/A  N/A    400558      G   /usr/libexec/Xorg                   0MiB |
|    0   N/A  N/A    400559      G   /usr/libexec/Xorg                   0MiB |
|    0   N/A  N/A    400560      G   /usr/libexec/Xorg                   0MiB |
|    1   N/A  N/A    400553      G   /usr/libexec/Xorg                   0MiB |
|    1   N/A  N/A    400554      G   /usr/libexec/Xorg                   8MiB |
|    1   N/A  N/A    400555      G   /usr/libexec/Xorg                   0MiB |
|    1   N/A  N/A    400556      G   /usr/libexec/Xorg                   0MiB |
|    1   N/A  N/A    400557      G   /usr/libexec/Xorg                   0MiB |
|    1   N/A  N/A    400558      G   /usr/libexec/Xorg                   0MiB |
|    1   N/A  N/A    400559      G   /usr/libexec/Xorg                   0MiB |
|    1   N/A  N/A    400560      G   /usr/libexec/Xorg                   0MiB |
|    2   N/A  N/A    400553      G   /usr/libexec/Xorg                   0MiB |
|    2   N/A  N/A    400554      G   /usr/libexec/Xorg                   0MiB |
|    2   N/A  N/A    400555      G   /usr/libexec/Xorg                   8MiB |
|    2   N/A  N/A    400556      G   /usr/libexec/Xorg                   0MiB |
|    2   N/A  N/A    400557      G   /usr/libexec/Xorg                   0MiB |
|    2   N/A  N/A    400558      G   /usr/libexec/Xorg                   0MiB |
|    2   N/A  N/A    400559      G   /usr/libexec/Xorg                   0MiB |
|    2   N/A  N/A    400560      G   /usr/libexec/Xorg                   0MiB |
|    3   N/A  N/A    400553      G   /usr/libexec/Xorg                   0MiB |
|    3   N/A  N/A    400554      G   /usr/libexec/Xorg                   0MiB |
|    3   N/A  N/A    400555      G   /usr/libexec/Xorg                   0MiB |
|    3   N/A  N/A    400556      G   /usr/libexec/Xorg                   8MiB |
|    3   N/A  N/A    400557      G   /usr/libexec/Xorg                   0MiB |
|    3   N/A  N/A    400558      G   /usr/libexec/Xorg                   0MiB |
|    3   N/A  N/A    400559      G   /usr/libexec/Xorg                   0MiB |
|    3   N/A  N/A    400560      G   /usr/libexec/Xorg                   0MiB |
|    4   N/A  N/A    400553      G   /usr/libexec/Xorg                   0MiB |
|    4   N/A  N/A    400554      G   /usr/libexec/Xorg                   0MiB |
|    4   N/A  N/A    400555      G   /usr/libexec/Xorg                   0MiB |
|    4   N/A  N/A    400556      G   /usr/libexec/Xorg                   0MiB |
|    4   N/A  N/A    400557      G   /usr/libexec/Xorg                   8MiB |
|    4   N/A  N/A    400558      G   /usr/libexec/Xorg                   0MiB |
|    4   N/A  N/A    400559      G   /usr/libexec/Xorg                   0MiB |
|    4   N/A  N/A    400560      G   /usr/libexec/Xorg                   0MiB |
|    5   N/A  N/A    400553      G   /usr/libexec/Xorg                   0MiB |
|    5   N/A  N/A    400554      G   /usr/libexec/Xorg                   0MiB |
|    5   N/A  N/A    400555      G   /usr/libexec/Xorg                   0MiB |
|    5   N/A  N/A    400556      G   /usr/libexec/Xorg                   0MiB |
|    5   N/A  N/A    400557      G   /usr/libexec/Xorg                   0MiB |
|    5   N/A  N/A    400558      G   /usr/libexec/Xorg                   8MiB |
|    5   N/A  N/A    400559      G   /usr/libexec/Xorg                   0MiB |
|    5   N/A  N/A    400560      G   /usr/libexec/Xorg                   0MiB |
|    6   N/A  N/A    400553      G   /usr/libexec/Xorg                   0MiB |
|    6   N/A  N/A    400554      G   /usr/libexec/Xorg                   0MiB |
|    6   N/A  N/A    400555      G   /usr/libexec/Xorg                   0MiB |
|    6   N/A  N/A    400556      G   /usr/libexec/Xorg                   0MiB |
|    6   N/A  N/A    400557      G   /usr/libexec/Xorg                   0MiB |
|    6   N/A  N/A    400558      G   /usr/libexec/Xorg                   0MiB |
|    6   N/A  N/A    400559      G   /usr/libexec/Xorg                   8MiB |
|    6   N/A  N/A    400560      G   /usr/libexec/Xorg                   0MiB |
|    7   N/A  N/A    400553      G   /usr/libexec/Xorg                   0MiB |
|    7   N/A  N/A    400554      G   /usr/libexec/Xorg                   0MiB |
|    7   N/A  N/A    400555      G   /usr/libexec/Xorg                   0MiB |
|    7   N/A  N/A    400556      G   /usr/libexec/Xorg                   0MiB |
|    7   N/A  N/A    400557      G   /usr/libexec/Xorg                   0MiB |
|    7   N/A  N/A    400558      G   /usr/libexec/Xorg                   0MiB |
|    7   N/A  N/A    400559      G   /usr/libexec/Xorg                   0MiB |
|    7   N/A  N/A    400560      G   /usr/libexec/Xorg                   8MiB |
+-----------------------------------------------------------------------------+

Is it possible to limit Xorg processes with something like CUDA_VISIBLE_DEVICES environment variable ( https://developer.nvidia.com/blog/cuda-pro-tip-control-gpu-visibility-cuda_visible_devices/ )?
I guess some minor changes are needed somewhere arond this line so each Xorg instance run like CUDA_VISIBLE_DEVICES=1 Xorg ... .

Lawd, that's a mess.
To triage this properly, are there any consequences other than nvidia-smi being very tall?
Also I'm unlikely to personally upgrade the drivers any time soon, and I don't like to fix bugs blind. I think the fix should be as simple as
p = Popen(xorgargs, env={'CUDA_VISIBLE_DEVICES': display[1:]})

Would you be able to make this change yourself and test it out for a few days? If this particular change fails, try adding a breakpoint() immediately before the line; it'll drop you into pdb and you can have a poke around.

Thank you! Sure, I'll check it out and report result here.

Lawd, that's a mess.
To triage this properly, are there any consequences other than nvidia-smi being very tall?
Also I'm unlikely to personally upgrade the drivers any time soon, and I don't like to fix bugs blind. I think the fix should be as simple as
p = Popen(xorgargs, env={'CUDA_VISIBLE_DEVICES': display[1:]})

Would you be able to make this change yourself and test it out for a few days? If this particular change fails, try adding a breakpoint() immediately before the line; it'll drop you into pdb and you can have a poke around.

Hi, I have tried the modification here but it didn't work.  I have found another workaround.
In the source of coolgpus, just replace
buses = gpu_buses()
with the specific gpu bus_id you would like coolgpus to take effect, e.g.
buses = ['00000000:65:00.0']
The bus id could be seen from the output of nvidia-smi. Hope this helps.


[MGR] Strict comparison to min_gain_to_split

I think the comparison to min_gain_to_split should be a strict comparison.
With the current non-strict comparison and with e.g. min_gain_to_split=0, a tree will keep on growing even if all the leaves are completely pure.

Could you please add a test for this change? Also, the code in the grower should be updated to be consistent:
diff --git a/pygbm/grower.py b/pygbm/grower.py
index ea77473..b8fb977 100644
--- a/pygbm/grower.py
+++ b/pygbm/grower.py
@@ -159,7 +159,7 @@ class TreeGrower:
             # compute the histogram.
             return

-        if node.split_info.gain < self.min_gain_to_split:
+        if node.split_info.gain <= self.min_gain_to_split:
             # Note: this also comprises the case where there is not enough
             # samples in left or right child: all the SplitInfo (including the
             # best one which is returned by find_node_split_xxx) would have a

There might be other places where the code needs to updated as well.

I would rather like to never use == on a float32 value :)
So maybe if node.split_info.gain < 0.

Merged!


Bypassing unknown genes stops analysis?

A user has observed that if gene.iobio bypasses unknown genes, the analysis of the remaining genes can stop and they have to click analyse all to get analysis to complete. In some cases they need to click individual genes to get them to analyse. Is this expected or repeatable behaviour?

Good point! This is an easy fix.


Rebranding @tailwindcssinjs to xwind

I have been made aware of tailwind brand guidelines.
In order to avoid confusion, I will be renaming this project.
Apologies for the inconvenience!

It took a month


fincas, badarian (logical-conflict)

This pull request was generated by the 'mq' tool

/trunk merge


Dotnet vstest producing console logging output out of sync

Description
Dotnet vstest is printing detailed test cases output out of sync on the console.
This issue is similar to issue #612 .
Steps to reproduce
Create a new XUnit Test project with a couple of test cases, some of them being failed and running the test command through the CLI.
dotnet vstest XUnitTestProject1.dll --logger:"console;verbosity=Normal"
Expected behavior
Basically, when the tests are run. ideally the vstest should print the output in a sync manner.
i.e. Show the test case result, along with the test case name and if it fails it should show the stacktrace, etc.
For eg:
[Passed] TestCase 1
[Failed] TestCase 2
Stacktrace......
[Passed] TestCase 3
[xUnit.net] Finished: TestProject
Actual behavior
It prints out of sync.

In between, it prints the error stack trace of a particular test case and again it prints the same stacktrace of the same test case.

Prints finished before showing the passed/failed test case names.

Environment
The original issue was observed on the project built using .NetCoreApp 2.0.
SDK: 2.1.201
NuGet packages:

Microsoft.NET.Test.Sdk 15.5.0
xunit 2.3.1
xunit.runner.visualstudio 2.3.1

.NET Command Line Tools (2.1.201)
Product Information:
Version:            2.1.201
Commit SHA-1 hash:  7932dc6179
Runtime Environment:
OS Name:     Windows
OS Version:  10.0.18363
OS Platform: Windows
RID:         win10-x64
Base Path:   C:\Program Files\dotnet\sdk\2.1.201\
Note: The same can be reproduced using 5.0.100 SDK with Microsoft Test Execution Command Line Tool Version 16.8.0 with the latest NuGet Packages.
Attached is the sample console output of the failed test cases.
Sample output.txt

Yep, pretty annoying. I am forwarding all logs into the test window, and you really can't say which log is related to which test. I feel there should be something like this
Starting Test XX.XX.XX
- log message
- log message
- console output
- etc.
Passed Test XX.XX.XX

@AndiRudi @ashewani I have run some tests locally using latest versions of xunit and test platform and it seems that the issue was fixed. I will proceed with closing this ticket but if you are still having some problems, please let me know.


[Snyk] Upgrade @mui/icons-material from 5.14.1 to 5.14.3

This PR was automatically created by Snyk using the credentials of a real user.Snyk has created this PR to upgrade @mui/icons-material from 5.14.1 to 5.14.3.
:information_source: Keep your dependencies up-to-date. This makes it easier to fix existing vulnerabilities and to more quickly identify and fix newly disclosed vulnerabilities when they affect your project.

The recommended version is 1 version ahead of your current version.
The recommended version was released 23 days ago, on 2023-08-01.

Release notes

Package name: @mui/icons-material

5.14.3 - 2023-08-01 Read more

5.14.1 - 2023-07-19 Read more

    from @mui/icons-material GitHub release notes

Commit messages

Package name: @mui/icons-material

2deea34 v5.14.3 (#38251)
e2d20f2 [docs] Update Joy UI's package README (#38262)
07fd0d3 [docs-infra] Small design polish to the Diamond Sponsor container (#38257)
a48d4b4 [core] Use native Node's fetch instead of node-fetch package (#38263)
33db566 [blog] Fix blog post slug Base UI (#38254)
2d32d91 [docs-infra] Show props in the table of content (#38173)
9c8fe9d Bump rollup to ^3.27.0 (#37890)
be80cd0 Bump typescript-eslint to ^6.2.1 (major) (#38234)
41a42c2 [docs][material] Revise and update Examples doc (#38205)
b63a7aa [docs][base-ui] Add new batch of coming soon pages (#38025)
ac3282b [docs] fix links to standardized examples (#38193)
d62a16c [docs-infra] Polish API page design (#38196)
ecde58c [docs-infra] Search with productCategory when product is missing (#38239)
644696d [core] Remove dead code
bd0aca0 [docs-infra] Remove leftover standardNavIcon (#38252)
543d7af [docs] Fix typo in notifications.json
7a7c130 [docs-infra] Remove sidenav icons (#38174)
3cfadb4 [website] Adding Rich Bustos Twitter handle in bio (#38213)
2c00e3c Bump uuid to ^9.0.0 (#38236)
f391b53 Bump eslint-plugin-import to ^2.28.0 (#38226)
de38693 [Box] Remove `component` from TypeMap (#38168)
5bac8b3 [docs] Prepare docs infra for Tree View migration to X (#38202)
c23d852 [website] Prepare importing data from HiBob (#38238)
d25b33a Bump google-auth-library to ^9.0.0 (#38227)

Compare

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open upgrade PRs.
For more information:
🧐 View latest project report
🛠 Adjust upgrade PR settings
🔕 Ignore this dependency or unsubscribe from future upgrade PRs

Resolved


执行构建agent代码的时候报错如下：Qwen2TokenizerFast has no attribute "get _token_id" . Did you mean:"sep_token_id"

Self Checks

[X] This template is only for bug reports. For questions, please visit Discussions.
[X] I have thoroughly reviewed the project documentation (installation, training, inference) but couldn't find information to solve my problem. English 中文 日本語 Portuguese (Brazil)
[X] I have searched for existing issues, including closed ones. Search issues
[X] I confirm that I am using English to submit this report (我已阅读并同意 Language Policy).
[X] [FOR CHINESE USERS] 请务必使用英文提交 Issue，否则会被关闭。谢谢！:）
[X] Please do not modify this template and fill in all required fields.

Cloud or Self Hosted
Self Hosted (Source)
Environment Details
python 3.10  fish-speech-1.5 windows
Steps to Reproduce
When I  python -m tools.api --llama-checkpoint-path checkpoints/fish-agent-v0.1-3b/ --mode agent --compile ,
AttributeError:     Qwen2TokenizerFast has no attribute "get _token_id" . Did you mean:"sep_token_id"
✔ Expected Behavior
No response
❌ Actual Behavior
No response

same error occured.

先用1.4版本

Self Checks

[x]  This template is only for bug reports. For questions, please visit Discussions.
[x]  I have thoroughly reviewed the project documentation (installation, training, inference) but couldn't find information to solve my problem. English 中文 日本語 Portuguese (Brazil)
[x]  I have searched for existing issues, including closed ones. Search issues
[x]  I confirm that I am using English to submit this report (我已阅读并同意 Language Policy).
[x]  [FOR CHINESE USERS] 请务必使用英文提交 Issue，否则会被关闭。谢谢！:）
[x]  Please do not modify this template and fill in all required fields.

Cloud or Self Hosted
Self Hosted (Source)
Environment Details
python 3.10 fish-speech-1.5 windows
Steps to Reproduce
When I python -m tools.api --llama-checkpoint-path checkpoints/fish-agent-v0.1-3b/ --mode agent --compile , AttributeError: Qwen2TokenizerFast has no attribute "get _token_id" . Did you mean:"sep_token_id"
✔ Expected Behavior
No response
❌ Actual Behavior
No response

Please use version 1.4 of the code, or you can refer to version 1.4 to modify the fish_stpeech/tokenizer. py file

Hello, fish-speech is an amazing library, and I truly appreciate your work. I have also encountered the same error with the latest version.
(fish-speech) root@3aac063e8786:/app/data/zhouwen/fish-speech# python -m tools.api_server --llama-checkpoint-path /app/data/zhouwen/fish-speech/checkpoints/fish-agent-v0.1-3b --mode agent --compile                      python -m tools.api_server --llama-checkpoint-path /app/data/zhouwen/fish-speech/checkpoints/fish-agent-v0.1-3b --mode agent --compile
INFO:     Started server process [3919003]
INFO:     Waiting for application startup.
Exception in thread Thread-1 (worker):
Traceback (most recent call last):
File "/app/data/zhouwen/Anaconda3/envs/fish-speech/lib/python3.10/threading.py", line 1016, in _bootstrap_inner
self.run()
File "/app/data/zhouwen/Anaconda3/envs/fish-speech/lib/python3.10/threading.py", line 953, in run
self._target(*self._args, **self._kwargs)
File "/app/data/zhouwen/fish-speech/tools/llama/generate.py", line 960, in worker
model, decode_one_token = load_model(
File "/app/data/zhouwen/fish-speech/tools/llama/generate.py", line 677, in load_model
model: Union[NaiveTransformer, DualARTransformer] = BaseTransformer.from_pretrained(
File "/app/data/zhouwen/fish-speech/fish_speech/models/text2semantic/llama.py", line 411, in from_pretrained
model = model_cls(config, tokenizer=tokenizer)
File "/app/data/zhouwen/fish-speech/fish_speech/models/text2semantic/llama.py", line 542, in init
super().init(config, init_weights=False, tokenizer=tokenizer)
File "/app/data/zhouwen/fish-speech/fish_speech/models/text2semantic/llama.py", line 176, in init
self.semantic_token_ids = [
File "/app/data/zhouwen/fish-speech/fish_speech/models/text2semantic/llama.py", line 177, in
tokenizer.get_token_id(SEMANTIC_TOKEN) for SEMANTIC_TOKEN in SEMANTIC_TOKENS
File "/app/data/zhouwen/Anaconda3/envs/fish-speech/lib/python3.10/site-packages/transformers/tokenization_utils_base.py", line 1104, in getattr
raise AttributeError(f"{self.class.name} has no attribute {key}")
AttributeError: Qwen2TokenizerFast has no attribute get_token_id
Following your previous responses, I tried using version 1.4.0, but the error still persists.
(fish-speech) root@3aac063e8786:/app/data/zhouwen/fish-speech-1.4.0# python -m tools.api --llama-checkpoint-path /app/data/zhouwen/fish-speech-1.4.0/checkpoints/fish-agent-v0.1-3b --compile
2024-12-09 06:17:49.674 | INFO     | main::403 - Loading Llama model...
Exception in thread Thread-1 (worker):
Traceback (most recent call last):
File "/app/data/zhouwen/Anaconda3/envs/fish-speech/lib/python3.10/threading.py", line 1016, in _bootstrap_inner
self.run()
File "/app/data/zhouwen/Anaconda3/envs/fish-speech/lib/python3.10/threading.py", line 953, in run
self._target(*self._args, **self._kwargs)
File "/app/data/zhouwen/fish-speech-1.4.0/tools/llama/generate.py", line 561, in worker
model, decode_one_token = load_model(
File "/app/data/zhouwen/fish-speech-1.4.0/tools/llama/generate.py", line 343, in load_model
model: Union[NaiveTransformer, DualARTransformer] = BaseTransformer.from_pretrained(
File "/app/data/zhouwen/fish-speech-1.4.0/fish_speech/models/text2semantic/llama.py", line 325, in from_pretrained
config = BaseModelArgs.from_pretrained(str(path))
File "/app/data/zhouwen/fish-speech-1.4.0/fish_speech/models/text2semantic/llama.py", line 87, in from_pretrained
return cls(**data)
TypeError: DualARModelArgs.init() got an unexpected keyword argument 'fast_attention_qkv_bias'
I look forward to your reply.

1.4.3

Thank you so much!!! It works now.

@AnyaCoder Hello, first of all, let me thank you for your support. I meet the same issue (AttributeError: 'Qwen2TokenizerFast' object has no attribute 'semantic_id_to_token_id'), when run agent-v0.1-3b, based on speech-1.5.
For Sever side, clone latest code so far, and copy tokenizer.tiktoken form speech-1.5 to agent-v0.1-3b
python -m tools.api_server --llama-checkpoint-path checkpoints/fish-agent-v0.1-3b/ --mode agent --compile
Error log was showed as below,
2024-12-26 15:19:02.000 | INFO     | tools.server.views:vqgan_encode:53 - [EXEC] VQGAN encode time: 467.96ms
INFO:     <IP_ADDRESS>:47610 - "POST /v1/vqgan/encode HTTP/1.1" 200 OK
INFO:     <IP_ADDRESS>:47610 - "POST /v1/chat HTTP/1.1" 200 OK
ERROR:    Exception in ASGI application
Traceback (most recent call last):
File "/home/harr/anaconda3/envs/fish/lib/python3.10/site-packages/uvicorn/protocols/http/h11_impl.py", line 403, in run_asgi
result = await app(  # type: ignore[func-returns-value]
File "/home/harr/anaconda3/envs/fish/lib/python3.10/site-packages/uvicorn/middleware/proxy_headers.py", line 60, in call
return await self.app(scope, receive, send)
File "/home/harr/anaconda3/envs/fish/lib/python3.10/site-packages/kui/asgi/applications.py", line 163, in call
await self.app(scope, receive, send)
File "/home/harr/anaconda3/envs/fish/lib/python3.10/site-packages/kui/asgi/applications.py", line 118, in app
return await getattr(self, scope_type)(scope, receive, send)
File "/home/harr/anaconda3/envs/fish/lib/python3.10/site-packages/kui/asgi/applications.py", line 142, in http
return await response(scope, receive, send)
File "/home/harr/anaconda3/envs/fish/lib/python3.10/site-packages/baize/asgi/responses.py", line 167, in call
chunk = await generator.asend(None)
File "/home/harr/anaconda3/envs/fish/lib/python3.10/site-packages/baize/asgi/responses.py", line 191, in render_stream
async for chunk in self.iterable:
File "/media/harr/King/fish-speech-1.5.0/tools/server/agent/init.py", line 37, in streaming_generator
for i in generator:
File "/media/harr/King/fish-speech-1.5.0/tools/server/agent/init.py", line 16, in execute_request
prompt, im_end_id = prepare_messages(request, tokenizer, config)
File "/media/harr/King/fish-speech-1.5.0/tools/server/agent/pre_generation_utils.py", line 41, in prepare_messages
prompt = conv.encode_for_inference(
File "/media/harr/King/fish-speech-1.5.0/fish_speech/conversation.py", line 185, in encode_for_inference
encoded = self.encode(tokenizer, add_shift=False)
File "/media/harr/King/fish-speech-1.5.0/fish_speech/conversation.py", line 138, in encode
encoded = message.encode(
File "/media/harr/King/fish-speech-1.5.0/fish_speech/conversation.py", line 76, in encode
[
File "/media/harr/King/fish-speech-1.5.0/fish_speech/conversation.py", line 77, in
tokenizer.semantic_id_to_token_id[i.item()]
AttributeError: 'Qwen2TokenizerFast' object has no attribute 'semantic_id_to_token_id'
For client side,
python -m tools.e2e_webui
Error log was showed as below:
File "/home/harr/anaconda3/envs/fish/lib/python3.10/site-packages/httpx/_transports/default.py", line 101, in map_httpcore_exceptions
yield
File "/home/harr/anaconda3/envs/fish/lib/python3.10/site-packages/httpx/_transports/default.py", line 271, in aiter
async for part in self._httpcore_stream:
File "/home/harr/anaconda3/envs/fish/lib/python3.10/site-packages/httpcore/_async/connection_pool.py", line 407, in aiter
raise exc from None
File "/home/harr/anaconda3/envs/fish/lib/python3.10/site-packages/httpcore/_async/connection_pool.py", line 403, in aiter
async for part in self._stream:
File "/home/harr/anaconda3/envs/fish/lib/python3.10/site-packages/httpcore/_async/http11.py", line 342, in aiter
raise exc
File "/home/harr/anaconda3/envs/fish/lib/python3.10/site-packages/httpcore/_async/http11.py", line 334, in aiter
async for chunk in self._connection._receive_response_body(**kwargs):
File "/home/harr/anaconda3/envs/fish/lib/python3.10/site-packages/httpcore/_async/http11.py", line 203, in _receive_response_body
event = await self._receive_event(timeout=timeout)
File "/home/harr/anaconda3/envs/fish/lib/python3.10/site-packages/httpcore/_async/http11.py", line 213, in _receive_event
with map_exceptions({h11.RemoteProtocolError: RemoteProtocolError}):
File "/home/harr/anaconda3/envs/fish/lib/python3.10/contextlib.py", line 153, in exit
self.gen.throw(typ, value, traceback)
File "/home/harr/anaconda3/envs/fish/lib/python3.10/site-packages/httpcore/_exceptions.py", line 14, in map_exceptions
raise to_exc(exc) from exc
httpcore.RemoteProtocolError: peer closed connection without sending complete message body (incomplete chunked read)
The above exception was the direct cause of the following exception:
Traceback (most recent call last):
File "/home/harr/anaconda3/envs/fish/lib/python3.10/site-packages/gradio/queueing.py", line 625, in process_events
response = await route_utils.call_process_api(
File "/home/harr/anaconda3/envs/fish/lib/python3.10/site-packages/gradio/route_utils.py", line 322, in call_process_api
output = await app.get_blocks().process_api(
File "/home/harr/anaconda3/envs/fish/lib/python3.10/site-packages/gradio/blocks.py", line 2047, in process_api
result = await self.call_function(
File "/home/harr/anaconda3/envs/fish/lib/python3.10/site-packages/gradio/blocks.py", line 1606, in call_function
prediction = await utils.async_iteration(iterator)
File "/home/harr/anaconda3/envs/fish/lib/python3.10/site-packages/gradio/utils.py", line 714, in async_iteration
return await anext(iterator)
File "/home/harr/anaconda3/envs/fish/lib/python3.10/site-packages/gradio/utils.py", line 819, in asyncgen_wrapper
response = await iterator.anext()
File "/media/harr/King/fish-speech-1.5.0/tools/e2e_webui.py", line 100, in process_audio_input
async for event in agent.stream(
File "/media/harr/King/fish-speech-1.5.0/tools/fish_e2e.py", line 230, in stream
async for chunk in response.aiter_bytes():
File "/home/harr/anaconda3/envs/fish/lib/python3.10/site-packages/httpx/_models.py", line 997, in aiter_bytes
async for raw_bytes in self.aiter_raw():
File "/home/harr/anaconda3/envs/fish/lib/python3.10/site-packages/httpx/_models.py", line 1055, in aiter_raw
async for raw_stream_bytes in self.stream:
File "/home/harr/anaconda3/envs/fish/lib/python3.10/site-packages/httpx/_client.py", line 176, in aiter
async for chunk in self._stream:
File "/home/harr/anaconda3/envs/fish/lib/python3.10/site-packages/httpx/_transports/default.py", line 270, in aiter
with map_httpcore_exceptions():
File "/home/harr/anaconda3/envs/fish/lib/python3.10/contextlib.py", line 153, in exit
self.gen.throw(typ, value, traceback)
File "/home/harr/anaconda3/envs/fish/lib/python3.10/site-packages/httpx/_transports/default.py", line 118, in map_httpcore_exceptions
raise mapped_exc(message) from exc
httpx.RemoteProtocolError: peer closed connection without sending complete message body (incomplete chunked read)
I look forward to your reply.

@AnyaCoder Hello, first of all, let me thank you for your support. I meet the same issue (AttributeError: 'Qwen2TokenizerFast' object has no attribute 'semantic_id_to_token_id'), when run agent-v0.1-3b, based on speech-1.5.
For Sever side, clone latest code so far, and copy tokenizer.tiktoken form speech-1.5 to agent-v0.1-3b
python -m tools.api_server --llama-checkpoint-path checkpoints/fish-agent-v0.1-3b/ --mode agent --compile
Error log was showed as below,
2024-12-26 15:19:02.000 | INFO     | tools.server.views:vqgan_encode:53 - [EXEC] VQGAN encode time: 467.96ms
INFO:     <IP_ADDRESS>:47610 - "POST /v1/vqgan/encode HTTP/1.1" 200 OK
INFO:     <IP_ADDRESS>:47610 - "POST /v1/chat HTTP/1.1" 200 OK
ERROR:    Exception in ASGI application
Traceback (most recent call last):
File "/home/harr/anaconda3/envs/fish/lib/python3.10/site-packages/uvicorn/protocols/http/h11_impl.py", line 403, in run_asgi
result = await app(  # type: ignore[func-returns-value]
File "/home/harr/anaconda3/envs/fish/lib/python3.10/site-packages/uvicorn/middleware/proxy_headers.py", line 60, in call
return await self.app(scope, receive, send)
File "/home/harr/anaconda3/envs/fish/lib/python3.10/site-packages/kui/asgi/applications.py", line 163, in call
await self.app(scope, receive, send)
File "/home/harr/anaconda3/envs/fish/lib/python3.10/site-packages/kui/asgi/applications.py", line 118, in app
return await getattr(self, scope_type)(scope, receive, send)
File "/home/harr/anaconda3/envs/fish/lib/python3.10/site-packages/kui/asgi/applications.py", line 142, in http
return await response(scope, receive, send)
File "/home/harr/anaconda3/envs/fish/lib/python3.10/site-packages/baize/asgi/responses.py", line 167, in call
chunk = await generator.asend(None)
File "/home/harr/anaconda3/envs/fish/lib/python3.10/site-packages/baize/asgi/responses.py", line 191, in render_stream
async for chunk in self.iterable:
File "/media/harr/King/fish-speech-1.5.0/tools/server/agent/init.py", line 37, in streaming_generator
for i in generator:
File "/media/harr/King/fish-speech-1.5.0/tools/server/agent/init.py", line 16, in execute_request
prompt, im_end_id = prepare_messages(request, tokenizer, config)
File "/media/harr/King/fish-speech-1.5.0/tools/server/agent/pre_generation_utils.py", line 41, in prepare_messages
prompt = conv.encode_for_inference(
File "/media/harr/King/fish-speech-1.5.0/fish_speech/conversation.py", line 185, in encode_for_inference
encoded = self.encode(tokenizer, add_shift=False)
File "/media/harr/King/fish-speech-1.5.0/fish_speech/conversation.py", line 138, in encode
encoded = message.encode(
File "/media/harr/King/fish-speech-1.5.0/fish_speech/conversation.py", line 76, in encode
[
File "/media/harr/King/fish-speech-1.5.0/fish_speech/conversation.py", line 77, in
tokenizer.semantic_id_to_token_id[i.item()]
AttributeError: 'Qwen2TokenizerFast' object has no attribute 'semantic_id_to_token_id'
For client side,
python -m tools.e2e_webui
Error log was showed as below:
File "/home/harr/anaconda3/envs/fish/lib/python3.10/site-packages/httpx/_transports/default.py", line 101, in map_httpcore_exceptions
yield
File "/home/harr/anaconda3/envs/fish/lib/python3.10/site-packages/httpx/_transports/default.py", line 271, in aiter
async for part in self._httpcore_stream:
File "/home/harr/anaconda3/envs/fish/lib/python3.10/site-packages/httpcore/_async/connection_pool.py", line 407, in aiter
raise exc from None
File "/home/harr/anaconda3/envs/fish/lib/python3.10/site-packages/httpcore/_async/connection_pool.py", line 403, in aiter
async for part in self._stream:
File "/home/harr/anaconda3/envs/fish/lib/python3.10/site-packages/httpcore/_async/http11.py", line 342, in aiter
raise exc
File "/home/harr/anaconda3/envs/fish/lib/python3.10/site-packages/httpcore/_async/http11.py", line 334, in aiter
async for chunk in self._connection._receive_response_body(**kwargs):
File "/home/harr/anaconda3/envs/fish/lib/python3.10/site-packages/httpcore/_async/http11.py", line 203, in _receive_response_body
event = await self._receive_event(timeout=timeout)
File "/home/harr/anaconda3/envs/fish/lib/python3.10/site-packages/httpcore/_async/http11.py", line 213, in _receive_event
with map_exceptions({h11.RemoteProtocolError: RemoteProtocolError}):
File "/home/harr/anaconda3/envs/fish/lib/python3.10/contextlib.py", line 153, in exit
self.gen.throw(typ, value, traceback)
File "/home/harr/anaconda3/envs/fish/lib/python3.10/site-packages/httpcore/_exceptions.py", line 14, in map_exceptions
raise to_exc(exc) from exc
httpcore.RemoteProtocolError: peer closed connection without sending complete message body (incomplete chunked read)
The above exception was the direct cause of the following exception:
Traceback (most recent call last):
File "/home/harr/anaconda3/envs/fish/lib/python3.10/site-packages/gradio/queueing.py", line 625, in process_events
response = await route_utils.call_process_api(
File "/home/harr/anaconda3/envs/fish/lib/python3.10/site-packages/gradio/route_utils.py", line 322, in call_process_api
output = await app.get_blocks().process_api(
File "/home/harr/anaconda3/envs/fish/lib/python3.10/site-packages/gradio/blocks.py", line 2047, in process_api
result = await self.call_function(
File "/home/harr/anaconda3/envs/fish/lib/python3.10/site-packages/gradio/blocks.py", line 1606, in call_function
prediction = await utils.async_iteration(iterator)
File "/home/harr/anaconda3/envs/fish/lib/python3.10/site-packages/gradio/utils.py", line 714, in async_iteration
return await anext(iterator)
File "/home/harr/anaconda3/envs/fish/lib/python3.10/site-packages/gradio/utils.py", line 819, in asyncgen_wrapper
response = await iterator.anext()
File "/media/harr/King/fish-speech-1.5.0/tools/e2e_webui.py", line 100, in process_audio_input
async for event in agent.stream(
File "/media/harr/King/fish-speech-1.5.0/tools/fish_e2e.py", line 230, in stream
async for chunk in response.aiter_bytes():
File "/home/harr/anaconda3/envs/fish/lib/python3.10/site-packages/httpx/_models.py", line 997, in aiter_bytes
async for raw_bytes in self.aiter_raw():
File "/home/harr/anaconda3/envs/fish/lib/python3.10/site-packages/httpx/_models.py", line 1055, in aiter_raw
async for raw_stream_bytes in self.stream:
File "/home/harr/anaconda3/envs/fish/lib/python3.10/site-packages/httpx/_client.py", line 176, in aiter
async for chunk in self._stream:
File "/home/harr/anaconda3/envs/fish/lib/python3.10/site-packages/httpx/_transports/default.py", line 270, in aiter
with map_httpcore_exceptions():
File "/home/harr/anaconda3/envs/fish/lib/python3.10/contextlib.py", line 153, in exit
self.gen.throw(typ, value, traceback)
File "/home/harr/anaconda3/envs/fish/lib/python3.10/site-packages/httpx/_transports/default.py", line 118, in map_httpcore_exceptions
raise mapped_exc(message) from exc
httpx.RemoteProtocolError: peer closed connection without sending complete message body (incomplete chunked read)
I look forward to your reply.

Try using command line script reasoning to see if the problem is repeated

@AnyaCoder Hello, first of all, let me thank you for your support. I meet the same issue (AttributeError: 'Qwen2TokenizerFast' object has no attribute 'semantic_id_to_token_id'), when run agent-v0.1-3b, based on speech-1.5.
For Sever side, clone latest code so far, and copy tokenizer.tiktoken form speech-1.5 to agent-v0.1-3b
python -m tools.api_server --llama-checkpoint-path checkpoints/fish-agent-v0.1-3b/ --mode agent --compile
Error log was showed as below,
2024-12-26 15:19:02.000 | INFO     | tools.server.views:vqgan_encode:53 - [EXEC] VQGAN encode time: 467.96ms
INFO:     <IP_ADDRESS>:47610 - "POST /v1/vqgan/encode HTTP/1.1" 200 OK
INFO:     <IP_ADDRESS>:47610 - "POST /v1/chat HTTP/1.1" 200 OK
ERROR:    Exception in ASGI application
Traceback (most recent call last):
File "/home/harr/anaconda3/envs/fish/lib/python3.10/site-packages/uvicorn/protocols/http/h11_impl.py", line 403, in run_asgi
result = await app(  # type: ignore[func-returns-value]
File "/home/harr/anaconda3/envs/fish/lib/python3.10/site-packages/uvicorn/middleware/proxy_headers.py", line 60, in call
return await self.app(scope, receive, send)
File "/home/harr/anaconda3/envs/fish/lib/python3.10/site-packages/kui/asgi/applications.py", line 163, in call
await self.app(scope, receive, send)
File "/home/harr/anaconda3/envs/fish/lib/python3.10/site-packages/kui/asgi/applications.py", line 118, in app
return await getattr(self, scope_type)(scope, receive, send)
File "/home/harr/anaconda3/envs/fish/lib/python3.10/site-packages/kui/asgi/applications.py", line 142, in http
return await response(scope, receive, send)
File "/home/harr/anaconda3/envs/fish/lib/python3.10/site-packages/baize/asgi/responses.py", line 167, in call
chunk = await generator.asend(None)
File "/home/harr/anaconda3/envs/fish/lib/python3.10/site-packages/baize/asgi/responses.py", line 191, in render_stream
async for chunk in self.iterable:
File "/media/harr/King/fish-speech-1.5.0/tools/server/agent/init.py", line 37, in streaming_generator
for i in generator:
File "/media/harr/King/fish-speech-1.5.0/tools/server/agent/init.py", line 16, in execute_request
prompt, im_end_id = prepare_messages(request, tokenizer, config)
File "/media/harr/King/fish-speech-1.5.0/tools/server/agent/pre_generation_utils.py", line 41, in prepare_messages
prompt = conv.encode_for_inference(
File "/media/harr/King/fish-speech-1.5.0/fish_speech/conversation.py", line 185, in encode_for_inference
encoded = self.encode(tokenizer, add_shift=False)
File "/media/harr/King/fish-speech-1.5.0/fish_speech/conversation.py", line 138, in encode
encoded = message.encode(
File "/media/harr/King/fish-speech-1.5.0/fish_speech/conversation.py", line 76, in encode
[
File "/media/harr/King/fish-speech-1.5.0/fish_speech/conversation.py", line 77, in
tokenizer.semantic_id_to_token_id[i.item()]
AttributeError: 'Qwen2TokenizerFast' object has no attribute 'semantic_id_to_token_id'
For client side,
python -m tools.e2e_webui
Error log was showed as below:
File "/home/harr/anaconda3/envs/fish/lib/python3.10/site-packages/httpx/_transports/default.py", line 101, in map_httpcore_exceptions
yield
File "/home/harr/anaconda3/envs/fish/lib/python3.10/site-packages/httpx/_transports/default.py", line 271, in aiter
async for part in self._httpcore_stream:
File "/home/harr/anaconda3/envs/fish/lib/python3.10/site-packages/httpcore/_async/connection_pool.py", line 407, in aiter
raise exc from None
File "/home/harr/anaconda3/envs/fish/lib/python3.10/site-packages/httpcore/_async/connection_pool.py", line 403, in aiter
async for part in self._stream:
File "/home/harr/anaconda3/envs/fish/lib/python3.10/site-packages/httpcore/_async/http11.py", line 342, in aiter
raise exc
File "/home/harr/anaconda3/envs/fish/lib/python3.10/site-packages/httpcore/_async/http11.py", line 334, in aiter
async for chunk in self._connection._receive_response_body(**kwargs):
File "/home/harr/anaconda3/envs/fish/lib/python3.10/site-packages/httpcore/_async/http11.py", line 203, in _receive_response_body
event = await self._receive_event(timeout=timeout)
File "/home/harr/anaconda3/envs/fish/lib/python3.10/site-packages/httpcore/_async/http11.py", line 213, in _receive_event
with map_exceptions({h11.RemoteProtocolError: RemoteProtocolError}):
File "/home/harr/anaconda3/envs/fish/lib/python3.10/contextlib.py", line 153, in exit
self.gen.throw(typ, value, traceback)
File "/home/harr/anaconda3/envs/fish/lib/python3.10/site-packages/httpcore/_exceptions.py", line 14, in map_exceptions
raise to_exc(exc) from exc
httpcore.RemoteProtocolError: peer closed connection without sending complete message body (incomplete chunked read)
The above exception was the direct cause of the following exception:
Traceback (most recent call last):
File "/home/harr/anaconda3/envs/fish/lib/python3.10/site-packages/gradio/queueing.py", line 625, in process_events
response = await route_utils.call_process_api(
File "/home/harr/anaconda3/envs/fish/lib/python3.10/site-packages/gradio/route_utils.py", line 322, in call_process_api
output = await app.get_blocks().process_api(
File "/home/harr/anaconda3/envs/fish/lib/python3.10/site-packages/gradio/blocks.py", line 2047, in process_api
result = await self.call_function(
File "/home/harr/anaconda3/envs/fish/lib/python3.10/site-packages/gradio/blocks.py", line 1606, in call_function
prediction = await utils.async_iteration(iterator)
File "/home/harr/anaconda3/envs/fish/lib/python3.10/site-packages/gradio/utils.py", line 714, in async_iteration
return await anext(iterator)
File "/home/harr/anaconda3/envs/fish/lib/python3.10/site-packages/gradio/utils.py", line 819, in asyncgen_wrapper
response = await iterator.anext()
File "/media/harr/King/fish-speech-1.5.0/tools/e2e_webui.py", line 100, in process_audio_input
async for event in agent.stream(
File "/media/harr/King/fish-speech-1.5.0/tools/fish_e2e.py", line 230, in stream
async for chunk in response.aiter_bytes():
File "/home/harr/anaconda3/envs/fish/lib/python3.10/site-packages/httpx/_models.py", line 997, in aiter_bytes
async for raw_bytes in self.aiter_raw():
File "/home/harr/anaconda3/envs/fish/lib/python3.10/site-packages/httpx/_models.py", line 1055, in aiter_raw
async for raw_stream_bytes in self.stream:
File "/home/harr/anaconda3/envs/fish/lib/python3.10/site-packages/httpx/_client.py", line 176, in aiter
async for chunk in self._stream:
File "/home/harr/anaconda3/envs/fish/lib/python3.10/site-packages/httpx/_transports/default.py", line 270, in aiter
with map_httpcore_exceptions():
File "/home/harr/anaconda3/envs/fish/lib/python3.10/contextlib.py", line 153, in exit
self.gen.throw(typ, value, traceback)
File "/home/harr/anaconda3/envs/fish/lib/python3.10/site-packages/httpx/_transports/default.py", line 118, in map_httpcore_exceptions
raise mapped_exc(message) from exc
httpx.RemoteProtocolError: peer closed connection without sending complete message body (incomplete chunked read)
I look forward to your reply.

Try using command line script reasoning to see if the problem is repeated

It's repeat 100%, when first record voice on Gradio WebUI, and can NOT get more useful information from script.
Start up server and WebUI, by follow docs/zh/start_agent.md.
Expectation: Successfully record voice on WebUI, then send voice to server to process.
Iusse: After startup Gradio WebUI and stop vocie record. 4 error display on multiple label. At the same time, get error related log in terminals.


Add unit test coverage checker before push

While doing 'gits push', this feature checks whether a certain threshold of unit tests in the repo to be pushed are passed

@harshitpatel96 has added the code coverage badge which would display the amount of code covered before pushing it to the repository.


Update cli.js

It looks like commander v7 changed the way to fetch args (now they are under cli.opts() )
Changed accordingly, plus updated  the default platforms check!

@Lucaszw I published a new version with your fixes, thanks again very much!
https://www.npmjs.com/package/cap-sync-version

No problem!!


[test] Remove old stubs no longer needed by the compiler.

Karoly removed the last use of _convertStringToNSString in #14046; the replacement is referenced by the runtime but not by the compiler. Doug had removed all the others from the stdlib in d92ae7707.
rdar://problem/35230338

@swift-ci Please smoke test and merge


No Compiler warning for missing case in Switch statement

Copy pasting the SafeSwitch example to project created via Visual Studio 2017 and compiling the project, no warning is being produced by the compiler.
Compiler Version:
# From Developer Command Prompt for VS 2017
>cl
Microsoft (R) C/C++ Optimizing Compiler Version 19.10.25019

Sample project:
BetterEnumTest.zip

That's not good!
I'm not immediately ready to reproduce this, but thanks for including the project. I'll have to look at it after some delay :/

That is fine.  Please let me know if you need any more info.

For some reason, the warning is off by default, see here. You need to add something like
#pragma warning(1 : 4062)  to enable it.

It seems that this can only be done by the user, so the code proper of Better Enums doesn't need to be modified.
However, we should probably document enabling this warning, perhaps by adding a short sentence and the link given by @JaapAap, to the tutorial and/or reference.

Yes, please document this issue. I spent 15 minutes trying to get this to fail, then I was about to complain about it and apparently it's a known issue! Imho either change the introduction page to mention that it needs enabling for all those people who are sadly on Visual Studio compilers, or remove the mentioning of the feature. Same for the tutorial page on the switch.

Enabling that feature is not always an option either, just FYI. Our project uses shared Libs and public headers and when I enabled the feature I also got warning related to Libs and headers that was not ours to begin with. I have picked up a work item to go take a look at how difficult it would be to fix all of them but I suspect it will be a time consuming effort.

Thanks for pinging. I updated the README and the switch tutorial page with notes about enabling warning C4062 on msvc. I hope that's enough, please let me know/PR if more warnings are needed.

That's great, thanks Aantron. It's indeed enough.


Console user/pass

Please add this feature so that we can give user and password in console when the task is ran and there is no username and password field defined in task config.
Writing down user name and password in text based files is not secure and makes issues when we want to share our grunt file with team members that don't have access too ftp.

If you don't have the authKey property defined in the configuration and run the task it will ask you for a username and a password.

Thanks for your response. Here is my configuration object:
    'ftp-deploy': {
      build: {
        auth: {
          host: 'server.com',
          port: 21
        },
        src: 'node_modules',
        dest: '/path/to/destination/folder',
        exclusions: ['path/to/source/folder/**/.DS_Store', 'path/to/source/folder/**/Thumbs.db', 'path/to/dist/tmp']
      }
    }

and this is what I get after running ftp task:

This is a firewall issue most likely.
On Sun, May 17, 2015 at 3:55 AM Iman Mohamadi<EMAIL_ADDRESS>wrote:

Thanks for your response. Here is my configuration object:
'ftp-deploy': {
  build: {
    auth: {
      host: 'server.com',
      port: 21
    },
    src: 'node_modules',
    dest: '/path/to/destination/folder',
    exclusions: ['path/to/source/folder/**/.DS_Store', 'path/to/source/folder/**/Thumbs.db', 'path/to/dist/tmp']
  }
}

and this is what I get after running ftp task:
[image: screen shot 1394-02-27 at 12 24 31]
https://cloud.githubusercontent.com/assets/4482199/7669578/afcffb26-fc8f-11e4-96a7-a8e4e2091e0e.png
—
Reply to this email directly or view it on GitHub
https://github.com/zonak/grunt-ftp-deploy/issues/96#issuecomment-102763607
.

Thank you very much, it's because I gave it a dummy host. Sounds like ftp deploy is smart enough to check if it can do it's job without a username and password so it does not ask for user/pass before checking remote server.


metal_device allow creation of spot device

Hi,
This is a feature request.
With the regular Metal Equinix API, it is possible to directly request a single machine. For my usage, this is a better API match. I generally am making a single one-off VM with a termination time. This would also make the process of getting the spot machine's IP address as an output attribute (whereas now there's seemingly no linkage between the spot_market_request and any actually instantiated instances (even with the wait_for_devices).
I think this would roughly constitute plumbing through these fields of the Create Device API:
    "spot_instance": "boolean",
    "spot_price_max": "number",

Additional thoughts were captured earlier in https://github.com/equinix/terraform-provider-equinix/issues/200


[Bug] Gray lines in volume reconstruction

Describe the Bug
Hello I hope you are well.
There is an error that appears when trying to do a multiplanar reconstruction with several images ( 300 +).
Some images are not displayed on the AXIAL view  and gray lines appear in SAGITTAL, CORONAL

In each refresh of the page the missing images are different, even sometimes all the images are loaded correctly
and when viewing the request in the browser inspector the following is shown.

Although the request has status 200 it appears that the request has not been completed.
This could be a browser problem with the number of simultaneous request.

So, We try change the number of maximum simultaneous requests and the problem disappears
  imageLoadPoolManager.setMaxSimultaneousRequests(RequestType.Interaction, 10);
  imageLoadPoolManager.setMaxSimultaneousRequests(RequestType.Thumbnail, 10);
  imageLoadPoolManager.setMaxSimultaneousRequests(RequestType.Prefetch, 10);

but it seems that the image prefetch made by the streaming-volume-loader is no longer fully respected because although I see in the network inspector that if the request for the middle image was made before the others, it is not displayed until that its index is reached.

Steps to Reproduce

You can use the example of crosshairs packages/tools/examples/crossHairs/index.ts
Set max simultaneous request to 1 or any value  < totalimages/2

  imageLoadPoolManager.setMaxSimultaneousRequests(RequestType.Interaction, 1);
  imageLoadPoolManager.setMaxSimultaneousRequests(RequestType.Thumbnail, 1);
  imageLoadPoolManager.setMaxSimultaneousRequests(RequestType.Prefetch, 1);

The current behavior
With limit of max simultaneous request (But in the end if it finishes loading all)

Without limit of max simultaneous request (but it does not load all the images)

The expected behavior
Show all images starting for the middle image

OS
macOs12.3 , Windows 10, Linux Mint
Node version
18.13.0
Browser
Chrome 90+

@mauricio-cdr I also experienced this situation， i  used  wadouri  in volume render.   Have you solved this problem yet

I have seen this before, but when I have the chrome devtools opened, I haven't seen it when it is closed though. What is your server? are you using dicomweb? are you using orthanc/dcm4chee? can you share the deidentified data?

I'm trying to replicate this or at least find a minimum number of steps to reproduce this constantly, no luck so far. Do you have reproducible steps? I tried orthanc too, throttled network and cpu, still loads fine

I also encountered this problem. But the positions that appear are random, and when positioned on the gray line, the axial display is also abnormal。

can use this method to resolve it.  [ ( imageLoadPoolManager.setMaxSimultaneousRequests(RequestType.Prefetch, 10); ]
but it will have new problem  when imageids.lenth  is even number .
like the photo,  it is always happen in center.

So we don't want to have CPU rendering on, since there is no volume viewport for CPU. I can spend time on this to be able to fix it, but at least I need some reproducible steps. Is this dicom web? what dicom web server you are using, can you create a repo and share it with me with bare minimum? (you can share private if you want)

So we don't want to have CPU rendering on, since there is no volume viewport for CPU. I can spend time on this to be able to fix it, but at least I need some reproducible steps. Is this dicom web? what dicom web server you are using, can you create a repo and share it with me with bare minimum? (you can share private if you want)

I did not use dicom web server. I finailly find the promblem ,But i do not think I get the best solution for it .
all the imageUrl will be send when call the volumeLoader.createAndCacheVolume(volumeId, {
imageIds,
});    this will triagger the xhrRequest of  dicomImageLoader. you can see all the request  is  sucessfully  call the function of  xhr.onloadstart.but not all of them  will call the function of  xhr.onloadend.  and both the gray line  is these(URL request) which do not arrive onloadend  . the solution of mine(But it seem like stupid).  first i  set a timeout for the request, and add a function  xhr.timeout  ,when timeout ,the  function of ontimeout will be called ,and recored these requests. then send these requests again  and  get  the response successfully  and send info to the main thread  there is some other image is already  for load(by postmessage).when the main thread get this message ,  call the volumeLoader.createAndCacheVolume(volumeId, {
imageIds,
});    again .  will get the successful diaplay or rebuild of MPR slice

if you found the issue that is great. if you create a mini repo with the issue showing i can certainly look at it


Doesn't appear to work with Leaflet 1.3.3

I have been using the default Leaflet package by importing like so:
import * as L from 'leaflet'
This works as expected.  However, when attempting to use VectorMarkers and create a marker:
let curIcon = L.VectorMarkers.icon({
    icon: 'coffee',
    color: '#000'
})

I receive Cannot read property 'Icon' of undefined in the console.  What am I missing?

I'm guessing you're missing an import. Try adding import 'Leaflet.vector-markers';

Hrm, appears that I shouldn't be importing Leaflet:
import * as L from 'leaflet'
...as it halts processing.  However when I skip import, it then complains about Invalid latLng as if it's expecting the object type from 0.7.x rather than the updated Array.  Would you mind providing updated instructions on full import, etc?


Ability to extend the possible fields set with custom fields

It would be great if one can easily extend this app with own custom fields. E.g. imagine I have a django app for storing sports results. For some reason I want to give my admin users the ability to define custom forms (thus I use this django app). Now there is a field they always need which is a dropdown with all recorded teams. Instead of manually adding all entries for every form (thus making it cumbersome to maintain) I'd like to create a new custom field type that includes data directly from the database.

That is already possible. Have a look at the ChoiceField
Happy to merge a PR if you come up with a generic implementation.

This can be closed, but I'd suggest to add some lines of documentation on how to do this. In my usecase I had to put the app 'dynamic_forms.apps.DynamicFormsConfig' as the last one, if you don't put it as last your fields will never be loaded because the 'loading process' already completed. For the rest one can simply reuse your decorator '@dynamic_form_field' and extend from 'BaseDynamicFormField'


ConnectionClosesWhenFinReceivedBeforeRequestCompletes failed

Failed https://travis-ci.org/aspnet/KestrelHttpServer/jobs/219866246
Failed   ConnectionClosesWhenFinReceivedBeforeRequestCompletes(listenOptions: http://<IP_ADDRESS>:0)
Error Message:
 Assert.Equal() Failure
          ↓ (pos 0)
Expected:
Actual:   HTTP/1.1 400 Bad Request\r\nConnection: clo···
          ↑ (pos 0)
Stack Trace:
   at Microsoft.AspNetCore.Testing.TestConnection.<ReceiveForcedEnd>d__14.MoveNext() in /home/travis/build/aspnet/KestrelHttpServer/test/shared/TestConnection.cs:line 120
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at Microsoft.AspNetCore.Server.Kestrel.FunctionalTests.RequestTests.<ConnectionClosesWhenFinReceivedBeforeRequestCompletes>d__27.MoveNext() in /home/travis/build/aspnet/KestrelHttpServer/test/Microsoft.AspNetCore.Server.Kestrel.FunctionalTests/RequestTests.cs:line 946
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
Skipped  RemoteIPv6Address
[xUnit.net 00:00:45.9547305]   Finished:    Microsoft.AspNetCore.Server.Kestrel.FunctionalTests

Here are what the logs look like when it fails:
Connection id "0HL3U8G4GDD9B" started.
POST / HTTP/1.1
TakeStartLine returned false
POST / HTTP/1.1
TakeStartLine returned false
POST / HTTP/1.1
TakeStartLine returned false
Connection id "0HL3U8G4GDD9B" bad request data: "Invalid request line."
Connection id "0HL3U8G4GDD9B" disconnecting.
Connection id "0HL3U8G4GDD9B" disconnecting.
Connection id "0HL3U8G4GDD9B" stopped.

This test is just racy in general but I'll fix it regardless.


ci: format checks

Summary

added CI script to check code format
added a cargo module that auto format term.toml, and have a --check flag that can be used for CI to check if all terms are sorted
resolve #1

Run check and panic if not sorted:
cd check_terms
cargo run -- --check

Auto formatting
cd check_terms
cargo run

Failing CI:

Thanks for adding the CI check and the formatting check. I added some feedback.
I noticed some duplicated logic in the check_terms/src/main.rs. Can we move them to src/main.rs?

Totally reasonable. I was paying attention ti the root crate.
Just added a --check flag into main.rs, and now we can just run cargo run -- --check on the root directory instead of switching between modules


Fix: app crash after sending first message in narrow.

Fix: messages not added in list if its narrow key is not present in messages reducer.
Fix: #1412

@borisyankov Thoughts of this
We need to fix this soon. App crashes when user sends first message in narrow (and sending first message in private narrow is very often)

Looks good. Will merge with the disabled move to bottom but continue trying to make it work.


PERF: avoid default_to_pandas

[ ] commit message follows format outlined here
[x] passes flake8 modin/ asv_bench/benchmarks scripts/doc_checker.py
[x] passes black --check modin/ asv_bench/benchmarks scripts/doc_checker.py
[x] signed commit with git commit -s
[ ] Resolves #?
[ ] tests added and passing
[x] module layout described at docs/development/architecture.rst is up-to-date
[ ] added (Issue Number: PR title (PR Number)) and github username to release notes for next major release

wtf why is this py38 test failing only on some builds

To fix [Test BaseOnPython execution, Python 3.8] apply the following patch:
diff --git a/modin/core/dataframe/algebra/default2pandas/default.py b/modin/core/dataframe/algebra/default2pandas/default.py
index e8e47c9c..1a13b926 100644
--- a/modin/core/dataframe/algebra/default2pandas/default.py
+++ b/modin/core/dataframe/algebra/default2pandas/default.py
@@ -87,14 +87,15 @@ class DefaultMethod(Operator):
                 and func != "to_numpy"
                 and func != pandas.DataFrame.to_numpy
             ):
-                # When applying a DatetimeProperties function, if we don't
+                # When applying a DatetimeProperties or TimedeltaProperties function, if we don't
                 # specify the dtype for the DataFrame, the frame might get the
                 # wrong dtype, e.g. for to_pydatetime in
                 # https://github.com/modin-project/modin/issues/4436
                 astype_kwargs = {}
                 dtype = getattr(result, "dtype", None)
-                if dtype and isinstance(
-                    df, pandas.core.indexes.accessors.DatetimeProperties
+                if dtype and (
+                    isinstance(df, pandas.core.indexes.accessors.DatetimeProperties)
+                    or isinstance(df, pandas.core.indexes.accessors.TimedeltaProperties)
                 ):
                     astype_kwargs["dtype"] = dtype
                 result = (

thanks @anmyachev looks like your suggestions fixed it

I changed the name and mentioned #4944 :)

is omnisci fail unrelated?

is omnisci fail unrelated?

yes, some other changes in conda environment led to this, investigating


Beta 15: Can't use "quick open scene" while editing scripts, The editor gets stuck

Godot version
v4.0.beta15.official [4fa6edc88]
System information
linux
Issue description
When I use Control+Shift+O to quick open scene, the editor gets stuck and I have to kill the process in order to get out of it.
However, this bug only seems to happen when I'm viewing the script tab.
Steps to reproduce
I have attached a video of the bug, I think it explains it
Minimal reproduction project
https://user-images.githubusercontent.com/80917990/214569805-a69ece5e-1803-464c-9025-ed1bfa66bf38.mp4

Duplicate of #72012


java.lang.UnsatisfiedLinkError dlopen failed: library "libhermes.so" not found

Hi, some users of our app are facing this repetetive crash on production. Here is some of the information we have gathered about this crash so far -

Our RN version is 0.72.8
Around 0.1% of our users are facing this
We do NOT have Hermes turned on, we are using JSC
Attaching a screenshot of the stack trace of the crash from Firebase Crashlytics
Based on the stack-trace, we have identified the function where we think the problem lies (attaching a snippet below), it's in the classReactInstanceManagerBuilder -> where hermes is being used as a fallback if loading JSC fails.

So the question now is, under what circumstances would loading JSC fail? And what can be done to fix this ? Any help or pointers in the right direction would be much appreciated.
`private JavaScriptExecutorFactory getDefaultJSExecutorFactory(String appName, String deviceName, Context applicationContext) {
if (this.jsEngineResolutionAlgorithm == null) {
FLog.w(TAG, "You're not setting the JS Engine Resolution Algorithm. We'll try to load JSC first, and if it fails we'll fallback to Hermes");
        try {
            ReactInstanceManager.initializeSoLoaderIfNecessary(applicationContext);
            JSCExecutor.loadLibrary();
            return new JSCExecutorFactory(appName, deviceName);
        } catch (UnsatisfiedLinkError var5) {
            if (var5.getMessage().contains("__cxa_bad_typeid")) {
                throw var5;
            } else {
                HermesExecutor.loadLibrary();
                return new HermesExecutorFactory();
            }
        }
    } else if (this.jsEngineResolutionAlgorithm == JSEngineResolutionAlgorithm.HERMES) {
        HermesExecutor.loadLibrary();
        return new HermesExecutorFactory();
    } else {
        JSCExecutor.loadLibrary();
        return new JSCExecutorFactory(appName, deviceName);
    }
}`

@waliahemanloop did you find any solution to fix the crash?

Having the same issue!


Tuyen/move genesis slot constant

Goal

Close #703
There are other changes regarding Eth1Data that should be addressed by #704

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.Tuyen seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

genesis state initialization spec tests failing

genesis state initialization spec tests failing

It's because we failed to verify deposits' signatures in that test. I notice that there are signature differences between data of spec test 0.10.0 vs 0.10.1-fix, let's revisit this issue in the newly created unit test deposit2.test.ts

Do we want to completely remove GENESIS_EPOCH constant?


Be able to filter output by more than one friend or tag

This commit allows you to use multiple --with or --tagged
flags in the following commands:

list friends
list activities
graph

Closes #88.
Hi there! Thanks so much for submitting a pull request!
Let's just make sure together that all of these boxes are checked before we
merge this change:

[x] The code in these changes works correctly.
[x] Code has tests as appropriate.
[x] Code has been reviewed by @JacobEvelyn.
[ ] All tests pass on Travis CI.
[ ] Rubocop reports no issues on Travis CI.
[ ] The README.md file is updated as appropriate.

Don't worry—this list will get checked off in no time!

Coverage increased (+0.02%) to 97.209% when pulling 01dce74e3ca69c82285c30c734a68453de9a5eb7 on many-many into 309bd1c976be22161f7e78de61f339d4112f1e6d on master.

Coverage increased (+0.02%) to 97.209% when pulling 6a209be9a6b84922063b335d64da4c7d0d0fdfc2 on many-many into 309bd1c976be22161f7e78de61f339d4112f1e6d on master.

Coverage increased (+0.02%) to 97.209% when pulling 6a209be9a6b84922063b335d64da4c7d0d0fdfc2 on many-many into 309bd1c976be22161f7e78de61f339d4112f1e6d on master.

Coverage increased (+0.02%) to 97.209% when pulling 6a209be9a6b84922063b335d64da4c7d0d0fdfc2 on many-many into 309bd1c976be22161f7e78de61f339d4112f1e6d on master.

Coverage increased (+0.02%) to 97.209% when pulling 6a209be9a6b84922063b335d64da4c7d0d0fdfc2 on many-many into 309bd1c976be22161f7e78de61f339d4112f1e6d on master.

Coverage increased (+0.02%) to 97.209% when pulling 6a209be9a6b84922063b335d64da4c7d0d0fdfc2 on many-many into 309bd1c976be22161f7e78de61f339d4112f1e6d on master.

Cool!

This is available in v0.30.