Remove db.user?

It seems to overlap with #731.
I'm not sure that db.user is an important default database metric attribute, and so we could remove it for now, and capture database user on spans in the future under the user.* namespace once #731 is resolved.

Once #731 AND https://github.com/open-telemetry/build-tools/issues/240 are resolved, we could re-introduce the user fields under the db namespace (if needed).
Similar to the conversation here https://github.com/open-telemetry/semantic-conventions/pull/564#discussion_r1549586908, I think we should avoid ambiguous user.* attributes that are not in a concrete context (i.e. parent namespace). As user is a very generic concept we should put it into a parent namespace whenever it is being used in a concrete context, to make clear what kind of user it is. Otherwise, if a signal has user.* fields it's not clear what kind of user it refers to (the OS user running the underlying process? the Web user that is authenticated with the service? The DB user? etc.). And, in fact a single signal could even have multiple different users associated.
+1 on removing db.user attribute for now, and potentially introducing the db.user.* namespace later again with #731 and https://github.com/open-telemetry/build-tools/issues/240

hi @jerry-shao! we definitely intend for there to be a replacement for capturing "database user", we're just not sure what the attribute name will be yet

would you mind opening a new issue to track this, i.e. how to capture database user?

Created a new issue to track this: https://github.com/open-telemetry/semantic-conventions/issues/1142


Add Stochastic to documentation

Add Stochastic and Dropout to the documentation.

Codecov Report

Merging #724 (d1d1ad4) into master (242e0f4) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #724   +/-   ##
=======================================
  Coverage   81.02%   81.02%
=======================================
  Files          55       55
  Lines        4347     4347
=======================================
  Hits         3522     3522
  Misses        825      825

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 242e0f4...d1d1ad4. Read the comment docs.

Thanks @AntoinePlumerault! While you're around, let us know -- how can we continue to make Flax better?


[OSPP]Multi-task Joint Inference for Ianvs

What this PR does:
The PR is the proposal of Multi-task Joint Inference for Ianvs.
The joint inference is better than single task. So we want to add an example named multi-task joint inference in Ianvs and verify the effectiveness in Object Detection.

Overall the proposal is good and practical, though more investigation on ianvs is needed with a minor revised in the current version.


HBASE-23380: General Cleanup of FSUtil

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 35s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  1s
The patch does not contain any @author tags.

-0 :warning:
test4tests
0m  0s
The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ master Compile Tests _

+1 :green_heart:
mvninstall
5m 40s
master passed

+1 :green_heart:
compile
0m 59s
master passed

+1 :green_heart:
checkstyle
1m 19s
master passed

+1 :green_heart:
shadedjars
4m 56s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 40s
master passed

+0 :ok:
spotbugs
4m 36s
Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
4m 34s
master passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
5m 35s
the patch passed

+1 :green_heart:
compile
0m 59s
the patch passed

+1 :green_heart:
javac
0m 59s
the patch passed

-1 :x:
checkstyle
1m 24s
hbase-server: The patch generated 3 new + 66 unchanged - 8 fixed = 69 total (was 74)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
shadedjars
4m 56s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
hadoopcheck
16m 54s
Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.

+1 :green_heart:
javadoc
0m 34s
the patch passed

+1 :green_heart:
findbugs
4m 20s
the patch passed

_ Other Tests _

-1 :x:
unit
147m 43s
hbase-server in the patch failed.

+1 :green_heart:
asflicense
0m 36s
The patch does not generate ASF License warnings.

207m 59s

Subsystem
Report/Notes

Docker
Client=19.03.5 Server=19.03.5 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-912/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/912

JIRA Issue
HBASE-23380

Optional Tests
dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile

uname
Linux 048aa45c03d4 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 GNU/Linux

Build tool
maven

Personality
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-912/out/precommit/personality/provided.sh

git revision
master / 9c82a65b29

Default Java
1.8.0_181

checkstyle
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-912/1/artifact/out/diff-checkstyle-hbase-server.txt

unit
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-912/1/artifact/out/patch-unit-hbase-server.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-912/1/testReport/

Max. process+thread count
4956 (vs. ulimit of 10000)

modules
C: hbase-server U: hbase-server

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-912/1/console

versions
git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 36s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

-0 :warning:
test4tests
0m  0s
The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ master Compile Tests _

+1 :green_heart:
mvninstall
6m 55s
master passed

+1 :green_heart:
compile
1m  4s
master passed

+1 :green_heart:
checkstyle
1m 42s
master passed

+1 :green_heart:
shadedjars
5m 38s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 44s
master passed

+0 :ok:
spotbugs
5m  7s
Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
5m  5s
master passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
6m 20s
the patch passed

+1 :green_heart:
compile
1m  6s
the patch passed

+1 :green_heart:
javac
1m  6s
the patch passed

+1 :green_heart:
checkstyle
1m 31s
hbase-server: The patch generated 0 new + 66 unchanged - 8 fixed = 66 total (was 74)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
shadedjars
5m 40s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
hadoopcheck
19m 40s
Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.

+1 :green_heart:
javadoc
0m 42s
the patch passed

+1 :green_heart:
findbugs
5m 10s
the patch passed

_ Other Tests _

-1 :x:
unit
147m 31s
hbase-server in the patch failed.

+1 :green_heart:
asflicense
0m 34s
The patch does not generate ASF License warnings.

217m 49s

Reason
Tests

Failed junit tests
hadoop.hbase.io.hfile.bucket.TestBucketCache

Subsystem
Report/Notes

Docker
Client=19.03.5 Server=19.03.5 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-912/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/912

JIRA Issue
HBASE-23380

Optional Tests
dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile

uname
Linux 4426cf392a7c 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux

Build tool
maven

Personality
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-912/out/precommit/personality/provided.sh

git revision
master / 8548463e74

Default Java
1.8.0_181

unit
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-912/2/artifact/out/patch-unit-hbase-server.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-912/2/testReport/

Max. process+thread count
4355 (vs. ulimit of 10000)

modules
C: hbase-server U: hbase-server

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-912/2/console

versions
git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@HorizonNet Thanks for the review! Much appreciated.

Rebased on master

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
2m  6s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

-0 :warning:
test4tests
0m  0s
The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ master Compile Tests _

+1 :green_heart:
mvninstall
5m 52s
master passed

+1 :green_heart:
compile
0m 56s
master passed

+1 :green_heart:
checkstyle
1m 23s
master passed

+1 :green_heart:
shadedjars
4m 44s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 41s
master passed

+0 :ok:
spotbugs
4m 16s
Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
4m 14s
master passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
4m 58s
the patch passed

+1 :green_heart:
compile
0m 57s
the patch passed

+1 :green_heart:
javac
0m 57s
the patch passed

+1 :green_heart:
checkstyle
1m 19s
hbase-server: The patch generated 0 new + 66 unchanged - 8 fixed = 66 total (was 74)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
shadedjars
4m 39s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
hadoopcheck
15m 43s
Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.

+1 :green_heart:
javadoc
0m 34s
the patch passed

+1 :green_heart:
findbugs
4m  9s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
156m 50s
hbase-server in the patch passed.

+1 :green_heart:
asflicense
0m 36s
The patch does not generate ASF License warnings.

216m 32s

Subsystem
Report/Notes

Docker
Client=19.03.5 Server=19.03.5 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-912/3/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/912

JIRA Issue
HBASE-23380

Optional Tests
dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile

uname
Linux 7a71b0a72cae 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux

Build tool
maven

Personality
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-912/out/precommit/personality/provided.sh

git revision
master / 82e155eb26

Default Java
1.8.0_181

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-912/3/testReport/

Max. process+thread count
4466 (vs. ulimit of 10000)

modules
C: hbase-server U: hbase-server

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-912/3/console

versions
git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 33s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

-0 :warning:
test4tests
0m  0s
The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ master Compile Tests _

+1 :green_heart:
mvninstall
5m 33s
master passed

+1 :green_heart:
compile
0m 56s
master passed

+1 :green_heart:
checkstyle
1m 21s
master passed

+1 :green_heart:
shadedjars
4m 37s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 37s
master passed

+0 :ok:
spotbugs
4m  8s
Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
4m  5s
master passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
5m  3s
the patch passed

+1 :green_heart:
compile
0m 55s
the patch passed

+1 :green_heart:
javac
0m 55s
the patch passed

+1 :green_heart:
checkstyle
1m 20s
hbase-server: The patch generated 0 new + 66 unchanged - 8 fixed = 66 total (was 74)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
shadedjars
4m 37s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
hadoopcheck
15m 46s
Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.

+1 :green_heart:
javadoc
0m 37s
the patch passed

+1 :green_heart:
findbugs
4m 20s
the patch passed

_ Other Tests _

-1 :x:
unit
169m 44s
hbase-server in the patch failed.

+1 :green_heart:
asflicense
0m 33s
The patch does not generate ASF License warnings.

227m 14s

Reason
Tests

Failed junit tests
hadoop.hbase.quotas.TestClusterScopeQuotaThrottle

hadoop.hbase.quotas.TestQuotaAdmin

Subsystem
Report/Notes

Docker
Client=19.03.5 Server=19.03.5 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-912/4/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/912

JIRA Issue
HBASE-23380

Optional Tests
dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile

uname
Linux 8deb41272a95 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 GNU/Linux

Build tool
maven

Personality
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-912/out/precommit/personality/provided.sh

git revision
master / 85a081925b

Default Java
1.8.0_181

unit
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-912/4/artifact/out/patch-unit-hbase-server.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-912/4/testReport/

Max. process+thread count
5107 (vs. ulimit of 10000)

modules
C: hbase-server U: hbase-server

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-912/4/console

versions
git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
2m  1s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

-0 :warning:
test4tests
0m  0s
The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ master Compile Tests _

+1 :green_heart:
mvninstall
5m 26s
master passed

+1 :green_heart:
compile
0m 56s
master passed

+1 :green_heart:
checkstyle
1m 20s
master passed

+1 :green_heart:
shadedjars
4m 40s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 37s
master passed

+0 :ok:
spotbugs
5m 22s
Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
5m 19s
master passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
5m 25s
the patch passed

+1 :green_heart:
compile
1m  0s
the patch passed

+1 :green_heart:
javac
1m  0s
the patch passed

+1 :green_heart:
checkstyle
1m 26s
hbase-server: The patch generated 0 new + 66 unchanged - 8 fixed = 66 total (was 74)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
shadedjars
4m 41s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
hadoopcheck
16m 43s
Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.

+1 :green_heart:
javadoc
0m 36s
the patch passed

+1 :green_heart:
findbugs
4m 25s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
157m 30s
hbase-server in the patch passed.

+1 :green_heart:
asflicense
0m 36s
The patch does not generate ASF License warnings.

219m 46s

Subsystem
Report/Notes

Docker
Client=19.03.5 Server=19.03.5 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-912/5/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/912

JIRA Issue
HBASE-23380

Optional Tests
dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile

uname
Linux 4dd2cd85eed6 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux

Build tool
maven

Personality
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-912/out/precommit/personality/provided.sh

git revision
master / 85a081925b

Default Java
1.8.0_181

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-912/5/testReport/

Max. process+thread count
5139 (vs. ulimit of 10000)

modules
C: hbase-server U: hbase-server

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-912/5/console

versions
git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@busbey Should be good to go here.  Thanks again for the reviews.  Please consider for inclusion into the project.

thanks!


Version update to 1.8.1

Update to 1.8.1 in parallel with boot2docker/boot2docker

Hi @timfallmk,
Thank you so much for your PR.
But I'm forcing on https://github.com/ailispaw/docker-root-xhyve now.
And I've been waiting for a response from Parallels at https://github.com/ailispaw/boot2docker/pull/1.
So I won't build a custom version of boot2docker here.

And also I'm waiting for https://github.com/docker/boot2docker.
It seems good for xhyve.

@timfallmk
Otherwise, if you don't mind building it on your side and upload it on your repo,
It would be my pleasure to point the download URL of boot2docker-xhyve to your repo.

Oh, you have already done that. :)

That's fine. I confirmed that the newest version of boot2docker already has the parallels tools disabled from the start.
As for DockerRoot, I do like Rancher, but Docker seems to be sticking with boot2docker (likely since they bought it) for platforms that don't support libcontainer directly.
If you want to somehow link people to my iso, that's also fine, but I think just pointing to upstream boot2docker should also before. Once xhyve has some more tooling available, none of these workarounds should be necessary.

Thank you.

I think just pointing to upstream boot2docker should also before.

What does this mean?

Sorry mistype. s/before/be fine.

Oh, I see. Thanks anyway.
I will point it to the new docker/boot2docker, once that is released.


How to use the set_always_send_heartbeats of Configuration

I'm building on a sample Proxy Mavlink with MAVSDK between QGC and PX4 (SITL).
I would like to know how to use the set_always_send_heartbeats of Configuration for Autopilot even if it is defined as false.
Mavsdk::Configuration custom_config(1, 1, false);  custom_config.set_always_send_heartbeats(false);  Mavsdk mavsdk_px4{custom_config};
This attribute is reset to true in MavsdkImpl::add_udp_connection when the add_any_connection is called (which seems to me to be a bug).

The configuration option is set internally depending on the connection you add. If you are sending UDP messages to another IP (instead of listening on a local port) you need to send something to initiate the connection and allow the counterpart to send anything back. Otherwise, the communication can't really start.
What are you trying to do exactly? What sort of connections are you adding?

@julianoes
I am creating a "MAVLink Proxy" using MAVSDK. The primary purpose of the Proxy is to act as a MAVLIN message broker between QGroundControl (QGC) and PX4 SITL. This proxy intercepts all MAVLink messages sent between the two components (QGC and PX4) via subscribe_message of MavlinkPassthrough. Later, when the other component connects, the message is forwarded to the destination.
The basic flow is:

QGC connects to the Proxy, but believes it is connected directly to PX4 (Mavsdk::Configuration mavsdk_px4{Mavsdk::Configuration{Mavsdk::ComponentType::Autopilot}};).
The PX4 connects to the Proxy, but believes it is connected directly to the QGC (Mavsdk mavsdk_qgc{Mavsdk::Configuration{Mavsdk::ComponentType::GroundStation}};).
The Proxy transparently forwards MAVLink messages between the two.

Challenges Found

Automatic HEARTBEAT Messages from the Proxy (MAVSDK):

When I configure MAVSDK for ComponentType::Autopilot, it sends automatic HEARTBEAT messages to initiate communication with the QGC.
These HEARTBEAT messages generated by the Proxy (with default values, such as type == 0) are mixed with the real messages from the PX4, causing problems in the QGC behavior. For example, the QGC constantly switches between the "PreFlight" and "Custom" states. That's why the QGC doesn't understand that the PX4 is ready for flight, releasing the Take Off commands, for example.

Internal Behavior of set_always_send_heartbeats:

I explicitly configured set_always_send_heartbeats(false) in Mavsdk::Configuration. However, when the add_any_connection function is called, the attribute is reset to true in the add_udp_connection method due to the internal logic of MAVSDK.
I understand the justification for sending HEARTBEAT when adding an outgoing UDP connection, but in this case, the Proxy should act as a passive (reactive) intermediary. In other words, it should not send HEARTBEAT messages automatically; it should just redirect the real messages from the PX4 to the QGC and vice versa.

My goal is to completely disable the sending of HEARTBEAT messages automatically generated by MAVSDK in the Proxy. I would like:

The Proxy is to send MAVLink messages to the QGC only when it receives a message from the PX4, and vice versa.
No HEARTBEAT messages are generated or sent by the Proxy in normal situations.

I see, thanks for the context. That's quite involved.
I can see how this automatic option does not work for you, but I also don't want to break the behavior for existing users.
One workaround I can think of is to intercept the outgoing messages and drop the heartbeats manually, using:
https://github.com/mavlink/MAVSDK/blob/v2.12/src/mavsdk/core/include/mavsdk/mavsdk.h#L422-L434
Would that work?

Thank you for the suggestion!
I tested the approach of intercepting outgoing messages and manually dropping the heartbeats using the intercept_outgoing_messages_async() method, and it worked perfectly for my use case. I implemented an MAVLink proxy that forwards messages between PX4 and QGroundControl while filtering specific messages as needed.
To help others with similar requirements, I have created an example and submitted it as a pull request: #2467. This example demonstrates how to set up an MAVLink proxy using MavlinkPassthrough and includes message interception and forwarding logic.
Thank you again for pointing me in the right direction!


snapshot: add --as and --as-group to support impersonation

What type of PR is this?
/kind feature
What this PR does / why we need it:
kubectl supports impersonation to uplift the default serviceaccount's privileges to operate some resources. Without populating this in snapshot export, users would be halted when scraping some resources like secret:
$ go run ./cmd/kwokctl/main.go snapshot export --kubeconfig /Users/weih/.kube/config --path /tmp/secret
ERROR Execute exit err="failed to list resource \"secrets\": secrets is forbidden: User \"xyz\" cannot list resource \"secrets\" in API group \"\" at the cluster scope"
exit status 1

This PR adds the support of --as and --as-group:
$ go run ./cmd/kwokctl/main.go snapshot export --kubeconfig /Users/weih/.kube/config --path /tmp/secret1 --as <user> --as-group <group>

Which issue(s) this PR fixes:

Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

- https://kubernetes.io/docs/reference/access-authn-authz/authentication/

/approve
/lgtm

This PR needs rebase

/lgtm


Merge macos/ios linking to include undefined symbols

Please select one of the following

[ ] I am removing an existing difference between facebook/react-native and microsoft/react-native-macos :thumbsup:
[ ] I am cherry-picking a change from Facebook's react-native into microsoft/react-native-macos :thumbsup:
[x] I am making a fix / change for the macOS implementation of react-native
[x] I am making a change required for Microsoft usage of react-native

Summary
In order to import the Linking library (libReact-RCTLinking-macOS.a) we need the RCTLinkingManagerCls symbol. To do so, we need part of the iOS implementation. The symbol itself is necessary for TurboModule support but we can use this as a reason to merge two year old macOS Linking manager with the iOS version for more of the recent features.
It looks like this file was excluded from macOS with this PR to get macOS running. We can clean up that shortcut now and have all the necessary symbols for both iOS and macOS to link downstream.
Changelog
[macOS] [Bug] - Fix downstream linker error for an undefined Linking symbol
Test Plan
Launched RNTester and opened a couple controls like button and text. They seem to operate as normal. If Linking were broken, we shouldn't see any views at all so it appears to be working.
Microsoft Reviewers: Open in CodeFlow

/azp run

/azp run

What does that do?

It tells azure to run the pipelines associated with this repo.
There was an incident where the pipelines were not working for a while, so some didn't automatically run.
In particular it looked like the android one hadn't kicked off, so I was manually triggering it.

ADO is having widespread problems now but Apple slices passed and this only touches Apple files so checking in.


Fix Regex not working with PathStrip

This gives prefix stripping with regex capability
It reuses the regex generated for the route path matching in mux.
To get this regex I exported it in the mux package, so you need to pull the changes in that package as well.
This will close issue #928.

Thank for the contribution, seems to be a duplicate of #1339

See https://github.com/containous/traefik/pull/1339#issuecomment-297019893


fix(intl-phone-input): fixed deletion of the selected range

https://jira.moscow.alfaintra.net/browse/PDS-1040

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

23 of 25 (92.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.2%) to 80.145%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

packages/intl-phone-input/src/component.tsx
23
25
92.0%

Totals

Change from base Build<PHONE_NUMBER>:
0.2%

Covered Lines:
7745

Relevant Lines:
8767

💛  - Coveralls


Is it possible to sort by an accessor for a resource?

@here @lindyhopchris

Can you define what you mean by "accessor" for a resource? If you could provide an example of how it would look using Eloquent's database query builder that would help.

Just added an accessor into the Model,
    public function getOnHandAttribute()
    {
        return $this->stocks()->sum('amount');
    }

the link you can read,
https://laravel.com/docs/8.x/eloquent-mutators#defining-an-accessor

Ok, yeah wasn't sure what you meant by sorting by it.
I'm going to close this issue for now as I don't think there's anything I need to do.


Playback on other clients fails to start if Plex server listens on port 80 or 443

Web App
System Details

Operating System: Linux
Web Browser name and version: Firefox 76.0.1

Plex Media Server details

Version: <IP_ADDRESS>64
Operating System (Windows/Linux/Mac): Linux
Running in Docker? (Yes/No): Yes
Location (Local/Remote): Remote
Remote Access Enabled (Yes/No)?: Yes, but through a reverse proxy

Plex Client details

Name: Plex Android
Version: <IP_ADDRESS>10
Network connection (Wired/Wifi): Wifi
Platform: Android

Issue information
To Reproduce
Steps to reproduce the behavior:

Have a Plex server behind a reverse proxy listening on a standard port (80/443)
Connect to a Plex client (I've attempted with Android and PMP)
Join a room and attempt playback

Describe your bug/issue
Enabling network logging on the Plex Android app gets me this:
05-16 08:42:39.232  i: [PlexDevice] PMS Setting https://<domain>:0 token: true types: [discovered] state: Unknown as the new active connection.
05-16 08:42:39.233  i: [pms] /<desktopIP>:37128 - OPTIONS /player/timeline/poll
05-16 08:42:39.236  i: [pms] /<desktopIP>:37126 - OPTIONS /player/timeline/poll
05-16 08:42:39.240  i: [pms] /<desktopIP>:37130 - GET /player/timeline/poll
05-16 08:42:39.245  i: [pms] /<desktopIP>:37132 - GET /player/timeline/poll
05-16 08:42:39.286  i: Fetching [method:GET] https://<domain>:0/?X-Plex-Token=<token>&includeExternalMedia=1
05-16 08:42:39.294  i: [pms] /<desktopIP>:37134 - GET /player/timeline/poll
05-16 08:42:39.294  i: Fetching [method:GET] https://<domain>:0/library/metadata/1612?X-Plex-Token=<token>&includeExternalMedia=1
05-16 08:42:39.299  e: An exception occurred: java.lang.ArrayIndexOutOfBoundsException: Array index out of range: 0
05-16 08:42:39.299  e: Stacktrace: java.lang.ArrayIndexOutOfBoundsException: Array index out of range: 0
	at java.util.Vector.get(Vector.java:748)
	at com.plexapp.plex.f.p0$a.a(SourceFile:12)
	at com.plexapp.plex.f.p0$a.doInBackground(SourceFile:1)
	at android.os.AsyncTask$3.call(AsyncTask.java:378)
	at java.util.concurrent.FutureTask.run(FutureTask.java:266)
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1167)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:641)
	at java.lang.Thread.run(Thread.java:919)

I noticed that the port the client tries is 0, and that "port=" in the HTTP request. So I modified it and resent with the port set to 443, which starts playback.
Looking through the code I found this:
https://github.com/samcm/synclounge/blob/aa7c8992f08a572b92e69d56f131515b6f1a6349/src/store/modules/plex/helpers/PlexClient.js#L311
Which I believe is the cause of the issue (introduced in #196).

@Lochnair I think I'm having the same issue. How did you modify the port the clients try to connect to?

The issue is likely with the chosenConnection of the server and it having a port of 0 if it the port is 0 in the query params

Right, I get it now. I usually allow external users to access my Plex server via a subdomain reverse proxy (at port 443), so hadn't set up a dedicated port for remote access in Plex, nor set up a port forward, so Synclounge was trying to connect to the server via port 0. Fixed now with a remote access port set and a port forward in place.


Cherry-pick: Fix a memory leak in json tuple (#10360)

Fixes #10404
Signed-off-by: Robert (Bobby) Evans<EMAIL_ADDRESS>(cherry picked from commit 73b3279330f16f7e1af664e1b7acf5f8762359fb)

build

Thank you  @gerashegalov and @revans2

build

First CI run failed due to #10227, Second CI run timed out on Scala2.13

build


Remove automatic conversion of vertical scroll to horizontal when holding shift

This was breaking binding behaviour too often, and is a pretty niche use case. ScrollContainer already automatically converts vertical scroll to horizontal, so this really doesn't do much for us.
Also in 092f28c0a, I've refactored ScrollContainer scroll delta handling logic to be more understandable
It was previously not clear the Y delta would be used if no X delta was present.
Note that this also adds considerations for precision scroll devices.  Without it, dual-axis scrolls could feel quite weird if the user happens to scroll a perfectly vertical line (would be unexpectedly converted to horizontal).

[ ] Before merging this, an osu! side PR should be made ahead of time migrating this for users which still have the default set:
https://github.com/ppy/osu/blob/15725fb18611925b70ed82396675bd419b848d70/osu.Game/Input/Bindings/GlobalActionContainer.cs#L104-L107

I've improved the tests in https://github.com/ppy/osu-framework/pull/5845. Any future changes to this PR should use and modify those tests. The PR intentionally doesn't change behaviour so it's non-controversial to merge and avoids merge conflicts with this PR.


Added missing mode="rb" argument to open() call in Client.post() example in docs.

The example for how to write a test that involves submitting a file involves uploading a binary file, but doesn't have a file access mode set. Since Python defaults to reading the file as text, this can result in UnicodeDecodeErrors.
This change adds an access_mode of 'rb' to the example thus causing Python to interpret it as a binary file.

@thorrak Thanks :+1:


net: lwm2m: Fix buffer overflow by using CONFIG_LWM2M_VERSION_1_0

By using CONFIG_LWM2M_VERSION_1_0, the function
lwm2m_engine_get_binding() returns the binding
and the queue mode bytes. Therefore the buffer
must be tree bytes long.
The issue is caused by the two inconsistent defines:
lwm2m_registry.c:
#define BINDING_OPT_MAX_LEN 3 /* "UQ" */
lwm2m_rd_client.c:
#define CLIENT_BINDING_LEN sizeof("U")
Signed-off-by: Peter Toenz<EMAIL_ADDRESS>

I think I have to reopen this PR over our company account (to comply with our company policy and your repository guidelines). But I have to wait until I have access to the company-github account

Sign-off issue resolved and rebased branch on the current master!


Avoiding spl_object_hash collision problem Gh 1017

This PR is about https://github.com/doctrine/mongodb-odm/issues/1017
The problem it is intended to solve is described in the issue above.
I am explaining it in a few words here too. UnitOfWork uses the spl_object_hash() values for documents as an internal identifier and stores document status and ID values in arrays indexed with these hash values.
Unfortunately, if EmbeddedDocuments are removed by garbage collection, their hash value is reused, so these internal metadata will be mixed up when a new document with matching hash is persisted.
This PR adds a new array to store new embedded documents until the UnitOfWork is cleared, so garbage collection doesn't destroy them, and the hash value won't be reused.

:+1:

Can you add a test for the problem you are trying to fix? I would like to see if it is fixed with #782. I don't feel like this is the right fix for the problem.

It is not trivial because it depends on when PHP wants to do a garbage collection and when does it reuse the same hash. But it has happened in our project quite similarly all the time so there is some chance that it is reproducible in a test.
Personally I didn't like my solution that much, because it locks in otherwise disposable the object in the memory just to avoid being their hash reused, but I didn't find other way.
I will try to create that test and let's see that #782 solves it.

@AronSzigetvari could you test #782 once again? I've rebased it to latest dev-master

Moving discussion to #782


Fix max_position_embedding error for Mixtral

PR 1202 is breaking Mixtral since it doesn't pass config.
This change fixes  both for Mixtral and Llama.

@jiminha Do we still need this change? https://github.com/huggingface/optimum-habana/pull/1202/files

no we don't need. I thought you already merged, so I removed that code in this PR.


getDeviceList hangs node.js

I am not certain if this has been reported before.
I am developing a project using node-usb and it is working great except that node.js will not exit without telling it to with process.exit(0)
I wrote a simple program that hangs.
const usb = require("usb"); usb.getDeviceList();
I am using

node v16.13.0
libusb 1.0.23-2build1  (ubuntu package)
Ubuntu 20.04
npm package: usb  ^1.9.1

I did notice but I'm not certain it is relevant from this page

You are expected to unreference all the devices when you are done with them, and then free the list with libusb_free_device_list(). Note that libusb_free_device_list() can unref all the devices for you. Be careful not to unreference a device you are about to open until after you have opened it.

It appears that libusb_free_device_list is being called at the end of getDeviceList and before it is opened.
But I am not certain what is causing the hang or how to work around it.

Can you confirm that this is actually a delay? In this case,  we are aware of an issue that the clean up of node-api code causes a 3-5 second delay on exit

I ran it for 3 minutes with no exit.   I can try longer if needed.

Excellent testing!
Not seen this issue before

I have some more info..
I started commenting out things in the C code until it freed up the exit.
This is what I found...
If I comment out these lines in uv_async_queue.h the above simple example will exit.
        void start(Napi::Env env) {
            Napi::Function empty_func = Napi::Function::New(env, [](const Napi::CallbackInfo& cb) {});
            //tsfn = Napi::ThreadSafeFunction::New(env, empty_func, "libusb", 0, 1);
        }

        void stop() {
            //tsfn.Release();
        }

Lines 15 and 19

It appears to never destroy the devices
~/Projects/node-usb-test$ node index.js
node-usb [../src/device.cc:Device() 25]: Created device 0x5a54790
node-usb [../src/device.cc:Device() 25]: Created device 0x5a544c0
node-usb [../src/device.cc:Device() 25]: Created device 0x593a460
node-usb [../src/device.cc:Device() 25]: Created device 0x59e71d0
node-usb [../src/device.cc:Device() 25]: Created device 0x5a4c9a0
node-usb [../src/device.cc:Device() 25]: Created device 0x59c5150
node-usb [../src/device.cc:Device() 25]: Created device 0x59abd50
node-usb [../src/device.cc:Device() 25]: Created device 0x5923710
node-usb [../src/device.cc:Device() 25]: Created device 0x59d84a0
node-usb [../src/device.cc:Device() 25]: Created device 0x5923830
node-usb [../src/device.cc:Device() 25]: Created device 0x593cb30
node-usb [../src/device.cc:Device() 25]: Created device 0x5a4fbf0
node-usb [../src/device.cc:Device() 25]: Created device 0x5938550
^C

It also appears to free them and exit if I expose GC and call it.

Thanks for investigating this.  It may also be the cause of https://github.com/node-usb/node-usb/issues/418
Any help creating a fix would be appreciated.

It looks like I have a fix.  I'm still testing but so far it looks promising.
I moved the start and stop of the completion queue to the open and close methods.
https://github.com/MikeColeGuru/node-usb/commit/8ffbfd15dddd3c367a0d9405b8c1cd3da8c0987a

Also, does there need to be a completion queue for every device?  In an experiment, I moved it out of Device and just passed a pointer to it in each Device::get.  Seems to work.

Here are some links that may help going forward.
Event Handling
http://libusbx.sourceforge.net/api-1.0/group__asyncio.html#asyncevent
Make Node.js exit regardless of a native module async call pending
https://stackoverflow.com/questions/58241265/make-node-js-exit-regardless-of-a-native-module-async-call-pending
libusb_context
https://libusb.sourceforge.io/api-1.0/group__libusb__lib.html#ga4ec088aa7b79c4a9599e39bf36a72833

It looks like I have a fix. I'm still testing but so far it looks promising.
I moved the start and stop of the completion queue to the open and close methods.
MikeColeGuru@8ffbfd1

Excellent work, your patch passes all the hardware tests and does indeed seem to fix this issue and #418
Could you open a PR, please?

Sure ...  https://github.com/node-usb/node-usb/pull/460

Fixed in #460


Please add xontrib and xonsh topics to the repository settings.

Hey! Thank you for this!
Please add xontrib and xonsh topics to the repository settings.

Done


Huge apps example and server side rendering

I've been trying to implement code splitting similar to the huge apps example in my app but am getting the following React error when refreshing a route which is loaded through require.ensure:
warning.js:44 Warning: React attempted to reuse markup in a container but the checksum was invalid. This generally means that you are using server rendering and the markup generated on the server was not what the client was expecting. React injected new markup to compensate which works but you have lost many of the benefits of server rendering. Instead, figure out why the markup being generated is different on the client or server:
 (client) <!-- react-empty: 1 -
 (server) <div class="root" dat

This error only occurs on routes which use require.ensure. I am guessing this is because react tries to do a first render on the client before require.ensure had time to load the route and therefore renders to an empty component. Is that correct? Would there be any way to tell React not to render anything if require.ensure still needs to load modules?

See the server rendering guide.

@olalonde Did you figure out the issue? I am facing the same issue, not sure though.

@manovagyanik1 I think I solved with this: https://github.com/ReactTraining/react-router/blob/master/docs/guides/ServerRendering.md#async-routes (async routes section)

If you are using es6 modules you can use System.import instead of require.ensure and its easy to do tree shaking and code splitting.

3.0 will let you return the Promise from System.import directly: #3719

Thanks guys. It worked :)

Does anyone know where the link is to the above file? Searching all over but keeping getting a 404.
Thank you!

@paolavness https://github.com/ReactTraining/react-router/blob/v3/docs/guides/ServerRendering.md#async-routes

@pshrmn thank you


[BUG] rpc error: code = InvalidArgument desc = ControllerPublishVolume Volume capability is not compatible:

In Linode K8s/
AttachVolume.Attach failed for volume "pvc-XXXXXXX" : rpc error: code = InvalidArgument desc = ControllerPublishVolume Volume capability is not compatible: volume_id:"2808205-XXXXXXXX" node_id:"444444" volume_capability:<mount:<fs_type:"ext4" > access_mode:<mode:MULTI_NODE_MULTI_WRITER > > volume_context:<key:"storage.kubernetes.io/csiProvisionerIdentity" value:"444444-555555-linodebs.csi.linode.com" >

This case is similar to https://github.com/BorisPolonsky/dify-helm/issues/8. If you want to use "local storage" for sharing data among api and worker, which are running on separate nodes, you have to create storage that support ReadWriteMany and define proper storage class through values.yaml. The log you provided suggest that ext4, which doesn't suit this purpose, were provisioned through the Container Storage Interface.
Alternatively you may also use externalS3 instead of "local volume".

Hello. Thanks for getting back to us. The case is that I am running on Linode's kubernetes service and it does not allow 2 pods to access the same disk. The disk is not the node that the 2 pods are on, but both cannot access it. Can I create a disk for each pod? If so.. where do I change this in the .yaml and which yaml do I change. Can you help me?

You need to consult linode support to find out the kind of storage class that supports ReadWriteMany.

I checked with Linode and the Kubernetes service does not actually support ReadWriteMany. :(
What I found was an option to create an NFS server in the same kubernetes network and change the class. (Same solution as EKS). https://startup2scalable.com/2024/02/read-write-many-volumes-on-lke-with-nfs/
But what do you suggest? S3 or NFS?
How do I integrate S3 into Helm?

I checked with Linode and the Kubernetes service does not actually support ReadWriteMany. :(
What I found was an option to create an NFS server in the same kubernetes network and change the class. (Same solution as EKS). https://startup2scalable.com/2024/02/read-write-many-volumes-on-lke-with-nfs/
But what do you suggest? S3 or NFS?
How do I integrate S3 into Helm?

Generally speaking, object storage (e.g. S3) demands less expense than file systems. You may check pricing from your cloud service provider for that.
I assume that you are familiar with altering helm configuration via values.yaml (e.g. helm install -f <your-values.yaml>). To use externalS3, fill in this section and set externalS3.enable=true

Thanks @BorisPolonsky ! Resolved with S3 Linode Service


Head bug

Full screen bug。

Please update to 1.40.2 and retest

Please update to 1.40.2 and retest

No such bug in version 1.40.2


Fix/18

I have updated the URL to display only internships from LinkedIn in the US and Canada, providing us with more relevant opportunities. Fixes https://github.com/acmcsufoss/acmOpportunities/issues/18 !

As we aim to make this platform more accessible for other clubs to use, I have taken into consideration the need for a simple setup. Now, users are reminded to call the create() function before they start using the platform. This information has been added to the README.md file and the main() function in main.py has been updated accordingly.

To ensure clarity and accuracy, I have made a minor improvement to the docstring on the GitHub internship function.

Based on feedback and to maximize the available character limit for descriptions in embed messages, I have increased the limit of opportunities by 5 (10 ➡ 15) for both internships and jobs.

We have some merge conflicts as well, I will take a look into those.
After this is reviewed, I can go ahead and close Issue #18!

Side note: This linting tool is amazing. .env had two empty extra lines and .env.example had only one empty extra line. check.yaml failed and when I fixed it, it passed. Super cool.

With updates to the code, it still works great.
Side Note: I did remember to comment out the functions which update the opportunities, as these opportunities need to be used in the discord server.


fix: Don't refresh session on each request

New option: rolling.
Checks if we force the session identifier cookie to be set on every response.
Default = true.
Same approach as express-session.
See: https://github.com/expressjs/session#rolling
Usage:
fastify.register(fastifySession, {
  ...
  rolling: false, // don't force the session cookie to be set on every response
  ...
});

Hope it helps!

Coverage decreased (-4.1%) to 95.89% when pulling e11198c4b8502f564831973edb577776c034bfbe on jack-y:options-rolling into e201f78fc9d7bd33c6f2e84988be7c8af4b5a8a3 on SerayaEryn:master.

Fixes #126

@jack-y Except the refactoring suggestion I have just made, the only other thing missing is changes to the TypeScript types, https://github.com/SerayaEryn/fastify-session/blob/master/types/types.d.ts to add the rolling option as a boolean to the Options interface.


OPENAI Data

I have a request, could you provide the data generated by the gpt-3.5?

I will organize and open all the GPT-generated texts and their corresponding embeddings later. Stay tuned.


改进调度器 disk 选择 storage 的逻辑:

这个 PR 实现什么功能/修复什么问题:

调度器选择 disk 对应一组 storages
主备机磁盘选择 storage
减少公有云选择 storage 的重复代码

是否需要 backport 到之前的 release 分支:

release/2.8.0

/cc @swordqiu @wanyaoqi

/cherrypick release/2.8.0

/area region scheduler

Codecov Report

Merging #453 into master will increase coverage by 0.34%.
The diff coverage is 0%.

@@            Coverage Diff            @@
##           master    #453      +/-   ##
=========================================
+ Coverage     7.4%   7.74%   +0.34%
=========================================
  Files         344     320      -24
  Lines       54021   51113    -2908
=========================================
- Hits         3999    3959      -40
+ Misses      49647   46780    -2867
+ Partials      375     374       -1

Flag
Coverage Δ

#aFlag
7.74% <0%> (+0.34%)
:arrow_up:

Impacted Files
Coverage Δ

pkg/compute/models/guestdrivers.go
18.18% <ø> (ø)
:arrow_up:

pkg/compute/models/guests.go
0.67% <ø> (ø)
:arrow_up:

pkg/compute/guestdrivers/virtualization.go
0% <0%> (ø)
:arrow_up:

pkg/compute/models/disks.go
0.78% <0%> (-0.01%)
:arrow_down:

pkg/compute/models/guest_actions.go
0% <0%> (ø)
:arrow_up:

pkg/compute/guestdrivers/openstack.go
5.49% <0%> (+0.44%)
:arrow_up:

pkg/compute/guestdrivers/aws.go
7.14% <0%> (+0.73%)
:arrow_up:

pkg/compute/models/helper.go
0% <0%> (ø)
:arrow_up:

pkg/compute/guestdrivers/aliyun.go
6.49% <0%> (+0.61%)
:arrow_up:

pkg/compute/guestdrivers/baremetals.go
1.75% <0%> (-0.02%)
:arrow_down:

... and 31 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ecb3ccb...7848a36. Read the comment docs.

/lgtm

/lgtm
/approve


feat: api command should extract source code of api elements

Closes #1106.
Summary of Changes
added an attribute code to functions and classes that contain the unformatted source code of the function or class
Testing Instructions
run package-parser api -p sklearn -o ./out and compare the output with the original file that the element contains.
package-parser annotations -a ../data/api/sklearn__api.json -u ../data/usages/sklearn_usages_counts.json -o ./out/annotations.json can verify that no error occur if the file is loaded.

Does it need tests?

A function like trim_code should have tests. However, in this case you might be able to simplify the code by using the as_string method of astroid.

Should the data folder be updated? (regarding the BSD 3-Clause "New" or "Revised" License from scikit-learn)

For the sake of easy (manual) testing, it makes sense to update the data folder. Just include the license file from scikit-learn as well in the data/api folder.

However, in this case you might be able to simplify the code by using the as_string method of astroid.

I compared output of the alternatives and found out that the as_string method ignores comments in the code, but it includes decorators. With a change from fromlineno to lineno decorators would be visible at the current process. Also, it seems that as_string() rearrange lines by removing comments.
Original sklearn.datasets._base.load_boston's last lines:
    return Bunch(
        data=data,
        target=target,
        # last column is target value
        feature_names=feature_names[:-1],
        DESCR=descr_text,
        filename=data_file_name,
        data_module=DATA_MODULE,
    )

and what as_string() converts it to:
    return Bunch(data=data, target=target, feature_names=feature_names[:-1], DESCR=descr_text, filename=data_file_name, data_module=DATA_MODULE)

If the comment line were removed in a new version, there would be a few new lines when we change to as_string().
So, I think we should keep the current procedure.

Let's discuss this tomorrow.

Please resolve conversations yourself once you are done with them.


get_completed_tasks Premium only?

Edit:
Issue solved.
I had the script running on my old server simultaneously so todoist obviously has a problem with two servers using this at the same time.

Closing this issue as @chris30o0 has resolved the problem. Thanks for the report.

Unfortunately I had a different issue in mind when editing my issue - meaning it is not actually resolved.
Is there a way I could restore my post / should I create a new one?
Maybe you got an email with the text I originally posted so I won't have to type it again, though it's not a lot :P

Re-opening as the original issue is still a problem.

Alright, thanks for reopening.
This is my script which reads all completed tasks in the specified project and writes them to a local file. This does work on one server but not on another.
#!/usr/bin/env python
import sys
import time
import subprocess
from pytodoist import todoist
api_token = 'mytokenhere'
user = todoist.login_with_api_token(api_token)
f = open('/root/scripts/tmp1', 'a')
torrents = user.get_project('Torrents')
completed_tasks = torrents.get_completed_tasks()
for task in completed_tasks:
        if task.content:
                f.write(task.content)
                f.write('\n')
                task.delete()

Here is the error code I get when running it on - let's call it - Server B
# ./todoist_get.py
Traceback (most recent call last):
  File "./todoist_get.py", line 10, in <module>
    completed_tasks = torrents.get_completed_tasks()
  File "/usr/local/lib/python2.7/dist-packages/pytodoist/todoist.py", line 1071, in get_completed_tasks
    _fail_if_contains_errors(response)
  File "/usr/local/lib/python2.7/dist-packages/pytodoist/todoist.py", line 175, in _fail_if_contains_errors
    raise RequestError(response)
pytodoist.todoist.RequestError: {"error_tag":"PREMIUM_ONLY","error_code":32,"error_extra":{},"error":"Premium only feature"}

Any idea on why this is happening on one server but not on another?
Both are running Ubuntu 14.04.3 with python 2.7.6

Just to be sure - are you using the same Todoist account on both servers? The get_completed_tasks method should only raise that exception if the user is not subscribed to Todoist premium.

I am using the same account and have never had a todoist premium account.

I'm really surprised that it works on one server if the associated Todoist account doesn't have a premium subscription membership.
The underlying API call requires that the user be a premium member. See the Todoist developer documentation for this here.
Unfortunately I don't think there is anything I can do here as it's an API limitation. In this case the error is expected.

Weird indeed.
Is the premium status checked by pytodoist or the API?
Maybe there is a Bug in the API but your Check prevents using it?

Just checked my pytodoist:
It works on version 1.0.0 which runs on my old server but not on 2.0.2 which for me is a hint it is indeed an issue with your code.

Version 1 is using the old (deprecated) Todoist API which may not have the premium restriction. This would explain why it works.
Version 2 onwards uses the latest API (version 6). I've done some debugging and found a couple of issues that cropped up recently so I'll be releasing an update soon. Unfortunately, I still don't think your issue will be fixed as premium is required for this API end-point.
I suggest you install version 1 on the new server in the mean time.

Too bad.
Simply copied pytodoist from my old to my new server which is working fine now.
So in fact Todoist changed its API, you adjusted pytodoist but the old API still works.
Weird, but since it's working..

Thanks for your help!

Well..
Today Todoist decided to not support the old API anymore so my script won't work anymore.
Since it's not worth 29€ to me I'll find a different way, most likely without pyTodoist.
Thanks for your work on this!

Thanks for letting me know. It's a shame you can no longer use the old version.
All the best!


RestAPI request fails

Hi,
I am using Sonar Gerrit Plugin to post score and comment from Jenkins to Gerrit. However, the plugin fails because of a Rest API exception. The exception is in the attached file : RestAPIException.txt
I am wondering what is the root cause of this ? Is there a way to get some logs ? Is it possible to know the user used ? Is it the one defined in Gerrit-Trigger configuration of Jenkins ?

@FloOows: The relevant line is:
Caused by: java.net.SocketTimeoutException: Read timed out
Most probably, your server is busy or not reachable at configured address / port.

I don't understand because when I am testing the Rest Connection under configuration page (JenkinsIP:8080/gerrit-trigger/server/Gerrit/) I got Success message

@FloOows: Can you reproduce this issue? Probably it also happens only for "heavy" requests like listing a lot of files?

Hi @uwolfer, It is 100% reproducible. I am working on a very small test project containing 2 files.
My config is : Gerrit on a linux server and Jenkins on a Windows server. I am able to ping linux server from windows one.

Is the testing of Rest API may be different than when a plugin try to post something onto gerrit ?

@FloOows: What do you mean with "testing of Rest API"? The button in Jenkins config UI?

@uwolfer Yes, using "Test REST Connection" button under Gerrit trigger configuration page

@FloOows: I cannot answer this question. I think you should ask the Jeninks Gerrit plugin authors. Please post any news here. Thank you.

I investigated a little bit more and I have a new question about this issue I still have. I agree with you that this plugin is probably not the root of my issue, but I need to understand something.
1/ Test Rest Connection works from Jenkins -> Manage -> Gerrit Trigger -> Rest Api section
This sends following request to Gerrit : "GET /a/projects/?d HTTP/1.1" 200 739 - "Apache-HttpClient/4.5.3 (Java/1.8.0_20)" and return Success into the interface.
2/ While using a tiers plugin, the code and up in your own function RevisionApiRestClient.files(). From here, you call GerritRestClient.getRequest() then GerritRestClient.requestJson() which raise Request Fail exception (main source : java.net.SocketTimeoutException: Read timed out).
My understanding : The request failed because of a time out exception, linked to my environment.
My question : Do you know why is it working when I used "Test Rest Connection" button but not in GerritRestClient.java ? Do you use the same mechanism used to send the request then in test button ?
For your information, the function launched when we click on the button is there.
It would be nice if you could explain this to me.
Thanks

Are you sure you are using this library? At least the user agent (Apache-HttpClient/4.5.3 (Java/1.8.0_20)) is not the one sent by this library. See this code: https://github.com/uwolfer/gerrit-rest-java-client/blob/master/src/main/java/com/urswolfer/gerrit/client/rest/http/GerritRestClient.java#L565
You could also look into webserver logs and try to execute the request which fails by your own with curl.
The link you have posted seems not to be related to this library?! I executes a HTTP request directly with HttpClient.

Your advice to test it with curl made me point out the issue. It was the classical proxy issue ...
Thanks for your answers.


Anchor presets not working

Godot version
4.0 beta 11
System information
Windows 10
Issue description
Anchors presets are ignored, sometimes they work if you manually modify the size of the node using the handles.
Steps to reproduce
Simple test, open new scene, base node is Control, try to set the full rect preset, nothing happens. then just try out different stuff with different nodes and hierarchies, it barely works.
Minimal reproduction project
.

Simple test, open new scene, base node is Control, try to set the full rect preset, nothing happens.

I can confirm this.

then just try out different stuff with different nodes and hierarchies, it barely works.

I cannot confirm this.

Anchors of the children of the "fixed" Control don't work, but they do if the nodes are put inside of a CanvasLayer, always after modifying the size beforehand.

What's a fixed control? Can you provide a reproduction project or at least a video?

anchors.zip
by "fixed" control I meant after resizing it manually, so the anchor presets start working
this is the test project, on the control.tscn scene, if you try to set full rect for all children, nothing happens, if you do the same with the canvas_layer scene, it works, but only after resizing them at least once.
If the project has been closed, you have to resize them again for the anchor presets to work

@venilark When you say it doesn't work, you mean using this panel?

yes

Thanks, I understand the problem now!


fix: copy vendor over for local dev

Closes https://linear.app/netlify/issue/FRA-53/netlify-dev-fails-to-run-middleware.
In https://github.com/netlify/next-runtime/pull/2302, we started vendoring Deno dependencies, but we forgot about copying them over for local dev. This PR fixes that.
The main change is a one-liner, but there was a problem within the way esm.sh bundles these two dependencies, and the way we import them via ../vendor:
https://github.com/netlify/next-runtime/blob/5d71bfbba214e88cf59ed335a786806c947a2109/packages/runtime/src/templates/edge/next-dev.js#L1-L2
This was fixed by registering the import_map.json created by Deno for local dev.  There was a bug in how that works though, that was only fixed in a recent release of the CLI. This means customers will need to update to that to get local dev working properly.
I've tested this locally with demos/middleware, and it's working well!

One weird thing is that when I go to http://localhost:8888/shows/100 in the demos/middleware site, Next shows me this:

I can't imagine how this would relate to my changes, so i'll assume this also exists on main. @orinokai is this a known thing?

Once we have the import map in place, we should be able to simplify the vendor.ts file a bit, and can make this change in a lot of our files:
-<EMAIL_ADDRESS>+<EMAIL_ADDRESS>
That'll be a small QoL improvement, since it'll make it easier to update versions of the imported files. Gonna do this in a follow-up!


Virtualization/Hyper-V: PowerShell parameter SMB

Description:
As concluded in issue ticket #2623 (The PowerShell command says "SMBTransport" but that generates an error), the PS command argument parameter "SMBTransport" does not work because it is incorrect.
Proposed changes:

replace "SMBTransport" with only "SMB"
remove redundant white space at the end of lines

Thanks to @VernAnderson for reporting the issue and to @Tajmaha for confirming that the simplified parameter works as intended.
issue ticket closure or reference:
Closes #2623

Yes, I know. The regular code view looks way too inclusive
because of the massive amount of line ending whitespace removal.
To see mostly only the effective changes, Rich Text Diff view gives a more manageable view:

https://github.com/MicrosoftDocs/windowsserverdocs/pull/3381/files?short_path=df9b3f8#diff-df9b3f8959f2bc83a7da5319100d176e


HTTP Request Cookies not correctly passed

Cookies sent by the browser are not correctly passed.
For example, a PHP script that does nothing else than a
print_r($_COOKIES);

with 3 cookies set, one gets:
Array
(
    [testcookie1] => Lorem Ipsum 1, testcookie2=Lorem Ipsum 2, testcookie3=Lorem Ipsum 3
)

Instead of
Array
(
    [testcookie1] => Lorem Ipsum 1
    [testcookie2] => Lorem Ipsum 2
    [testcookie3] => Lorem Ipsum 3
)

The http.Header of a request not performed using QUIC looks like this:
http.Header{
    "Cookie": []string{"testcookie1=Lorem+Ipsum+1; testcookie2=Lorem+Ipsum+2; testcookie3=Lorem+Ipsum+3"},
}

The http.Header of a request not performed using QUIC looks like this:
http.Header{
    "Cookie": []string{"testcookie1=Lorem+Ipsum+1", "testcookie2=Lorem+Ipsum+2", "testcookie3=Lorem+Ipsum+3"},
}

So, the QUIC HTTP Header contains more than one element in the string slice.

In h2quic.requestFromHeaders we take all values from the HPACK header and write them to a http.Header.
If there are multiple cookies, there'll be multiple hpack.HeaderFields with the key cookie.
However, the  HTTP Cookie Spec, Section 5.4 says there must only be one Cookie field in the HTTP header, thus we need to concatenate the values in the http.Header.


Add an OgmiosV6 backend based on ogmios-python

This requires bumping the python version to 3.10+, because ogmios-python requires this. I also refactored the chain backend to not have built-in kupo support but just provide it as an extension using kupo-wrappers. This way, both OgmiosV5 and OgmiosV6 directly have support for kupo.

This error occurs in mypy, not sure where it comes from
error: --install-types failed (no mypy cache directory)

Wow nice! Thanks a lot for adding this support. Will take a look at the error.
Regarding the min version bump, is it because of the dependency on ogmios = "^1.1.1"?

Yes unfortunately Ogmios does not support python 3.8 and 3.9

I had to bump the python version of mypy to "3.10" for this to run.
Here are few errors:
pycardano/backend/kupo.py:186: error: "KupoChainContextExtension" has no attribute "_extract_asset_info"  [attr-defined]
pycardano/backend/ogmios_v6.py:152: error: Argument "decentralization_param" to "ProtocolParameters" has incompatible type "None"; expected "Fraction"  [arg-type]
pycardano/backend/ogmios_v6.py:156: error: Argument "min_utxo" to "ProtocolParameters" has incompatible type "None"; expected "int"  [arg-type]
pycardano/backend/ogmios_v6.py:359: error: Argument 2 to "OgmiosV6ChainContext" has incompatible type "Network"; expected "int"  [arg-type]
Found 4 errors in 2 files (checked 31 source files)
make: *** [qa] Error 1

fyi, I tried to work with this branch and here's another error I encountered:
File ".../pycardano/backend/ogmios_v6.py", line 288, in _utxo_from_ogmios_result
Address.from_primitive(utxo.address),
AttributeError: type object 'Address' has no attribute 'from_primitive'
I guess in (at least) the following two places the pycardano.Address should be used instead of ogmios.Address:
https://github.com/Python-Cardano/pycardano/blob/0e285e5bfcb85e56d29cea5202fc910f94a59303/pycardano/backend/ogmios_v6.py#L272
https://github.com/Python-Cardano/pycardano/blob/0e285e5bfcb85e56d29cea5202fc910f94a59303/pycardano/backend/ogmios_v6.py#L288

Did anyone of you @pcjordan or @cffls encounter/resolve the weird mypy error in the CI?

Thanks for your support @cffls @pcjordan. Filed some issue at python-ogmios to achieve full 3.8/3.9 support again and then lets see about the unit tests (should ideally also add some unit tests for ogmios v6 and documentation here, maybe @cffls can help me out there?)

When this is ready to merge, I'll release the compatible version of ogmios-python (currently in the main branch).

Thanks @wrmarchetto ! @cffls I am running into an issue that docker-compose is not available in the CI build - do you happen to know where this comes from.

Thanks for fixing issues! FYI, I merged this branch (feat/add_v6_backend) to chang, and all tests are passing. I think it might be a good idea to push changes to chang branch going forward. wdyt?

Sounds good.


SQLLiteHandeler.py

There is code spread around the module that manages creation, insertion, and querying of SQLLite queries.
Put all of this code in one cohesive module to make code easier to maintain and debug

Thank you for taking care of this @AtharvaJadhav7 ! In the future so there isn't deduplication of effort, please comment on the issue with something like "I will take this on" so people know not to work on the issue since there is someone already working on it.
Thank again, code looks great!


isHidden getting set to undefined in some cases

I have yet to pin down the exact reason for this, but sometimes the componentWillReceiveProps function fires on page load and the isHidden state is set to undefined, which makes all the menus become visible at once.

Thanks @hartmamt


Need to update README with

A lot of the readme has specter2_0 but it's called specter_plus_plus.
Please also update the readme here, as it has the same issues: https://huggingface.co/allenai/specter_plus_plus
Finally, please merge: https://huggingface.co/allenai/specter/discussions/7

HuggingFace names have been updated to allenai/specter2* as in here and your update has been merged in the Specter model page as well.
Leaving the repo as it is since everything has already been pushed for Timo.


Disable Finger Tracking Toggle Not Working

Sorry to make another report, but the check box to disable finger tracking and attachmetn doesn't seem to work. Looking at the code, it looks like the bool is named differently in the attachableconfig script, but I'm not sure if that's the issue, as changing it didn't seem to make a difference

Yeah, I noticed that when working on U#1.0 support, I'll take a look this weekend.


How to read/set RTC

In Python Library, I don't see any way to read or set the Real Time Clock.
Am I missing something?

You have right, we will fix that.

Also, using the command line I did
megabas 0 rtcwr 12 21 21 09 31 00
it responded done
then
megabas 0 rtcrd
and it returned
00/00/00 00:00:00
Am I doing this incorrectly?

Looks like you do the right thing, let me know what is the firmware version of the card by issuing "megabas 0 board"

Firmware ver 01.01, CPU temperature 37 C, Power source 21.50 V, Raspberry 4.98 V

Please update your card firmware, instructions here: https://github.com/SequentMicrosystems/megabas-rpi/blob/master/update/README.md
Make sure no-one try to access the card during the update process.

Yeepee. That fixed it.
FYI

the spring clip was very loose for the battery
the megabas command help says megaind instead of megabas.
Thanks.

Thank you for the info will fix it except for the battery holder..

Thanks.
Is there an overlay to interface with the RTC? Or what is the best way to use the RTC?

Can I ask what you mean by overlay?
The only options are command line, python (soon), and NodeRed (i have to check but is duable).

the overlay is given in the config.txt file for the pi.
Here is a reference, mainly the first part. The reference talks about a specific RTC, but gives you the idea.
https://learn.adafruit.com/adding-a-real-time-clock-to-raspberry-pi/set-rtc-time

Thanks, I will take a look.

Did you come up with a way to have your RTC interact directly with Raspberry clock? By any chance is your RTC a DS 1307 look-alike?

Will be nice, but frankly I do not know when I start doing it..
Bottom line is that I can not give you a timeframe for it.

I understand completely. I just don't know how to use your RTC then. Is the idea to set the Raspberry clock on every boot from the RTC vial a megabas command?

That was the idea to read the RTC at power up when you have no internet  connectivity, otherwise if you are connected to the internet you can read your time from there.

Ok, I will work with that. It just takes a bit more to know (in code) that you don't have an internet connection.
Thanks for your help.

Can I get this functionality added to a node-red node?

You mean reading and setting the RTC?

It is good to set the RTC set and get are now available.
However - for rtcGet, the month is off by 1. For today, it reports the results as 2022 8 13 9 18 52
import megabas

year, month, day, hour, minute, second = rtcGet(0)

print(year, month, day, hour, minute, second)

Also, all the new I2C definitions of the address space aren't necessary. The definitions are already given at the  top of the module, just without the I2C prefix.


Add User-agent header to get.pharos.sh requests

Would be nice to have User-Agent header when requesting get.pharos.sh. Format could be for example: chpharos/<version> (<os>)

Already in #20

Doesn't report OS though

Now it does


v3 Release Candidate

Changes proposed in this PR

Add sonar integration
Change build process
Fix CSS breaks
Add gitlab release support

Checklist to be completed for PR

[ ] Have you added documentation where needed

Merged manually from command line


MAINT: style fix to have single space after bullet points in .md files

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.03%) to 91.342%

Totals

Change from base Build<PHONE_NUMBER>:
0.03%

Covered Lines:
178728

Relevant Lines:
195668

💛  - Coveralls


[qt5-base] build failure with manifests

Host Environment

OS: Windows
Compiler: Microsoft (R) C/C++ Optimizing Compiler Version 19.27.29112 for x86
CMake: 3.18.0
Vcpkg revision: 27a2418e91179d8607862348d7b498558e98a0ab

To Reproduce
Steps to reproduce the behavior:
1. Pull and bootstrap Vcpkg in `D:\vcpkg`.
1. Create a dummy CMake project in a directory on disk `C:`. Note the different disks.
1. Create `vcpkg.json` with dependencies from `qt5-base`.
1. Run CMake in the project distectory located on disk `C:` with `CMAKE_TOOLCHAIN_FILE` set to the `D:\vcpkg\scripts\buildsystems\vcpkg.cmake`.

Failure logs
CMake output:
-- Running vcpkg install
CMake Error at D:/vcpkg/scripts/buildsystems/vcpkg.cmake:386 (message):
  Running vcpkg install - failed

d:\vcpkg\buildtrees\qt5-base\stdout-x86-windows.log:
-- Installing x86-windows-dbg
-- Package x86-windows-dbg done
-- Building x86-windows-rel
-- Fixing makefile installation path x86-windows-rel
-- Installing x86-windows-rel
-- Package x86-windows-rel done
CMake Error at ports/qt5-base/portfile.cmake:332 (file):
  file RENAME failed to rename

    D:/vcpkg/packages/qt5-base_x86-windows/lib/cmake

  to

    D:/vcpkg/packages/qt5-base_x86-windows/share/cmake

  because: File exists

Call Stack (most recent call first):
  scripts/ports.cmake:79 (include)

Additional context
When not using manifest, vcpkg install qt5-base succeeds.
Although Vcpkg creates d:\vcpkg\packages\qt5-base_x86-windows\share\qt5-base, the directory D:/vcpkg/packages/qt5-base_x86-windows/share/cmake, it complains on, doesn't exist. At least after build ends.
Vcpkg uses d:\vcpkg\buildtrees\qt5-base for build, but it creates both d:\vcpkg\packages\qt5-base_x86-windows and c:\vcpkg\packages\qt5-base_x86-windows directories. (On two disks.)
Directory c:\vcpkg\packages\qt5-base_x86-windows\share\qt5-base doesn't exist as well.

cc @Neumann-A  @strega-nil

cc @Neumann-A, I don't even know where to start with this.

--debug output needed
and probably a run of
https://github.com/microsoft/vcpkg/pull/12877
with --trace or --trace-expand
It is probably a confusion between one of the VCPKG cmake variables.

Pushed some example code.
Will be happy to provide more data. I guess --debug, --trace, and --trace-expand are vcpkg command line arguments. How to you specify these arguments when installing a package from manifest?

Build log with --trace-expand: stdout-x86-windows.zip

Adding drive letters at this line makes the build to succeed:
diff --git a/ports/qt5-base/cmake/qt_fix_makefile_install.cmake b/ports/qt5-base/cmake/qt_fix_makefile_install.cmake
index 95831d29f..70006e49a 100644
--- a/ports/qt5-base/cmake/qt_fix_makefile_install.cmake
+++ b/ports/qt5-base/cmake/qt_fix_makefile_install.cmake
@@ -20,7 +20,7 @@ function(qt_fix_makefile_install BUILD_DIR)
     foreach(MAKEFILE ${MAKEFILES})
         file(READ "${MAKEFILE}" _contents)
         #Set the correct install directory to packages
-        string(REPLACE "(INSTALL_ROOT)${INSTALLED_DIR_WITHOUT_DRIVE}" "(INSTALL_ROOT)${PACKAGES_DIR_WITHOUT_DRIVE}" _contents "${_contents}")
+        string(REPLACE "C:$(INSTALL_ROOT)${INSTALLED_DIR_WITHOUT_DRIVE}" "D:$(INSTALL_ROOT)${PACKAGES_DIR_WITHOUT_DRIVE}" _contents "${_contents}")
         file(WRITE "${MAKEFILE}" "${_contents}")
     endforeach()
 endfunction()

Bump.
Project location: D:/MyProject/Sources/CMakeLists.txt
Toolchain location: E:/vcpkg/scripts/buildsystems/vcpkg.cmake
Error message:
1> [CMake] CMake Error at ports/qt5-base/portfile.cmake:387 (file):
1> [CMake]   file RENAME failed to rename
1> [CMake]     E:/vcpkg/packages/qt5-base_x64-windows/lib/cmake
1> [CMake]   to
1> [CMake]     E:/vcpkg/packages/qt5-base_x64-windows/share/cmake
1> [CMake]   because: File exists
1> [CMake] Call Stack (most recent call first):
1> [CMake]   scripts/ports.cmake:142 (include)

Vcpkg version: 2021-01-13-d67989bce1043b98092ac45996a8230a059a2d7e
HEAD is at 807a7987612bbd702be9d9b8069124be62aff857

Thank you!


update pixi lock file

I removed the old lock file, followed by pixi run install to install everything again.
This gets us new versions of our dependencies. Good to do every once in a while, preferable early in the release cycle in case issues with new versions of dependencies arise.

The CI doesn’t seem to be happy

I've pinned pandas and opened https://github.com/Deltares/Ribasim/issues/645
We should tackle this issue after @evetion's Ribasim Python refactor.


[BUG][WEBJS] - reply to a message via api is not working on some numbers

Describe the bug
We are sending a reply to a incoming message,. and we are using api to send reply. However that reply message is delivered as normal message, but it is not delivered as a reply message on whatsapp.
Version
{
  "version": "2023.12.2",
  "engine": "WEBJS",
  "tier": "PLUS",
  "browser": "/usr/bin/chromium"
}

To Reproduce Steps to reproduce the behavior:
POST api/reply
{"chatId":"919033XXXXX<EMAIL_ADDRESS>
Expected behavior
Ideally it should be sent as a reply on a whatsapp. But instead it is sent just like a normal message.
Engine I'm using WEBJS engine.
Docker Logs
No Exceptions in Logs
Screenshots
Expected Behaviour

Actual Buggy Behaviour

Whatsapp web shows the message like this, may be its useful information on why its not showing as actual reply.

Interesting, may be they have changed the way to reply on the message, will look a this!


Availability of FAL's versions of the model (heavy/light/portrait)

I was wondering if the weights of the models from FAL (heavy/light/portrait) are available to use

Duplicate of #65 - nvm


Fix Roster filename and imports.

Fixes #issue_number
What was changed?
Fixed Roster.js and Roster.css filenames and imports.
Here, describe what part of the application you changed (e.g. login page, database, etc.). If possible, mention what specific components were added, removed, or modified.
Fixes naming convention.
Why was it changed?
Had used wrong spelling, fixed it.
Here, describe the issue that you are fixing with this code, and why your code fixes it.
How was it changed?
Here, get into detail about what files you modified, and talk about the most important lines in regards to fixing the issue.
client_app/src/PastVolunteers.js, client_app/src/Roster.js, client_app/src/ShelterDashboard.js, client_app/src/ShiftContainer.js, client_app/src/styles/Roster.css
Screenshots that show the changes (if applicable):

hi @vakhil-98, could you please update it at the below lines as well
https://github.com/oss-slu/shelter_volunteers/blob/Fix_Roster_Filename/client_app/src/PastVolunteersContainer.js#L19
https://github.com/oss-slu/shelter_volunteers/blob/Fix_Roster_Filename/client_app/src/Roster.js#L5
https://github.com/oss-slu/shelter_volunteers/blob/Fix_Roster_Filename/client_app/src/Roster.js#L30
https://github.com/oss-slu/shelter_volunteers/blob/Fix_Roster_Filename/client_app/src/ShiftContainer.js#L2
https://github.com/oss-slu/shelter_volunteers/blob/Fix_Roster_Filename/client_app/src/ShiftContainer.js#L45
https://github.com/oss-slu/shelter_volunteers/blob/Fix_Roster_Filename/client_app/src/ShiftContainer.js#L47


Refresh ChEBI import.

Need to review these classification changes.

Not great, but these are the normal ChEBI issues. Some of the hierrchy is improved (for eg, removal of 'phosphorus metabolic process' as a parent of many terms).


gnu(1145181652101)=2950

gnu(1145181652101)=2950
GAP      4.8.3
GrpConst 2.5
Runtime: 641473 ms (10.68 min)
Isomorphic groups eliminated
In case this value is new, add the next line to data/gnudata.g
GNU_SAVE(<PHONE_NUMBER>101, 2950, WITH_GC );

gap>
System : Windows Vista

Thank you for submitting new gnu(n). We will recalculate it and add to the database if we get the same result.
Checklist for the reviewer:

[ ] checked and assigned labels "new (n<50000)" or "recomputation", if needed
[ ] set "replication needed" label (unless it starts immediately)
[ ] changed it to "replication in progress" label when the replication has been started
[ ] changed it to "replicated" after successful replication review
[ ] reproducible value of gnu(n)
[ ] no essential runtime differences
[ ] sufficient level of technical details

Checklist for the maintainer:

[ ] correct arguments of command to store data
[ ] correct location of new line in the data file
[ ] mention submitter and reviewer in the commit message
[ ] Close corresponding issue from the commit message

gnu(1145181652101)=2950
GAP      4.8.4
GrpConst 2.5
Runtime: 358155 ms (5.97 min)
Isomorphic groups eliminated
Replicated by @alex-konovalov on Ubuntu 16.04 on Azure cloud standard DS3 v2 instance (4 cores, 14 GB RAM)
In case this value is new, add the next line to data/gnudata.g
GNU_SAVE(<PHONE_NUMBER>101, 2950, WITH_GC );

Factors of<PHONE_NUMBER>101 are: 3, 3, 3, 103, 109, 127, 151, 197


Metrics is not available when using AWS EKS + Weavenet

Describe the bug
The metrics feature is not available when on EKS cluster with weavenet as the CNI used. This works fine on bare metal installation. After removing the AWS CNI from the EKS cluster, the installation of the Metrics server requires the networking to change to HostNetwork = true and communication IP = Internal. I have noticed that Lens uses its own Metrics server and Prometheus so there may be some additional tweaks required.
To Reproduce
Steps to reproduce the behavior:

Setup a cluster on AWS EKS
Remove AWS CNI
Install Weavenet
Connect using Lens and install the inbuilt metrics server

Expected behavior
Lens UI shows the metrics
Screenshots
Lens UI doesn't show metrics and complains " Metrics not available at the moment"
Environment (please complete the following information):

Lens Version: 3.5.1
OS: [e.g. OSX] Windows

Funny, I just replaced the AWS VPC CNI with Calico and had the same effect… Metrics don't work and the whole thing is generally more sluggish than before.

Exactly the same with EKS and Cilium. No metrics and a lot slower than before.
Lens 3.5.2 on Windows

Yes, after a few days using Lens with a EKS+CNI cluster it's pretty close to unusable actually :(
I wonder if it's so slow because it tries to always fetch some metrics which it can't?

Is it in overlay mode or the EKS standard CNI mode (every Pod get's a VPC routable adress)?
Secondary private IPs on your worker nodes mean you use the EKS CNI mode.

No it's a full replacement with overlay network. Pods get some 192.168.* addresses.

The issue still exists in 3.6

Problem still persist in 3.6.8

Workaround: just edit the StatefulSet of prometheus and add hostNetwork: true to the spec section
...
spec:
  replicas: 1
  selector:
    matchLabels:
      name: prometheus
  template:
    metadata:
      creationTimestamp: null
      labels:
        name: prometheus
    spec:
      volumes:
        - name: config
          configMap:
            name: prometheus-config
            defaultMode: 420
        - name: rules
          configMap:
            name: prometheus-rules
            defaultMode: 420
      initContainers:
        - name: chown
          image: 'docker.io/alpine:3.9'
          command:
            - chown
            - '-R'
            - '65534:65534'
            - /var/lib/prometheus
          resources: {}
          volumeMounts:
            - name: data
              mountPath: /var/lib/prometheus
          terminationMessagePath: /dev/termination-log
          terminationMessagePolicy: File
          imagePullPolicy: IfNotPresent
      containers:
        - name: prometheus
          image: 'docker.io/prom/prometheus:v2.17.2'
          args:
            - '--web.listen-address=<IP_ADDRESS>:9090'
            - '--config.file=/etc/prometheus/prometheus.yaml'
            - '--storage.tsdb.path=/var/lib/prometheus'
            - '--storage.tsdb.retention.time=2d'
            - '--storage.tsdb.retention.size=5GB'
            - '--storage.tsdb.min-block-duration=2h'
            - '--storage.tsdb.max-block-duration=2h'
          ports:
            - name: web
              hostPort: 9090
              containerPort: 9090
              protocol: TCP
          resources:
            requests:
              cpu: 100m
              memory: 512Mi
          volumeMounts:
            - name: config
              mountPath: /etc/prometheus
            - name: rules
              mountPath: /etc/prometheus/rules
            - name: data
              mountPath: /var/lib/prometheus
          livenessProbe:
            httpGet:
              path: /-/healthy
              port: 9090
              scheme: HTTP
            initialDelaySeconds: 10
            timeoutSeconds: 10
            periodSeconds: 10
            successThreshold: 1
            failureThreshold: 3
          readinessProbe:
            httpGet:
              path: /-/ready
              port: 9090
              scheme: HTTP
            initialDelaySeconds: 10
            timeoutSeconds: 10
            periodSeconds: 10
            successThreshold: 1
            failureThreshold: 3
          terminationMessagePath: /dev/termination-log
          terminationMessagePolicy: File
          imagePullPolicy: IfNotPresent
      restartPolicy: Always
      terminationGracePeriodSeconds: 30
      dnsPolicy: ClusterFirst
      serviceAccountName: prometheus
      serviceAccount: prometheus
      hostNetwork: true
      securityContext: {}
...

I confirm that problem still exists in 4.1.2 version. Using hostNetwork for prometheus it's not a problem but I also noticed that lens works slower with EKS + calico CNI. Why does the CNI have impact for lens performance? Does anyone know?

I've had issues with calico and EKS as well. I don't have a clue why it happens so but it eventually forced me reverting back to the VPC CNI. Ever since I did that everything works fine. I know it's not much of an input, just wanted to share that custom CNIs have problems on EKS and it's very much reproducible.

@PatTheSilent Could you tell me what kind of issues did you have with calico? I'm asking because I didn't noticed any issues besides these related with lens. I will appreciate if you share some details.

@randrusiak from what I could gather what I was experiencing had a chance of happening. I've mostly had issues with cross az traffic and connecting to stuff outside the cluster, like an RDS database. I'm not excluding I misconfigured something but I've spend quite some time on ENI adjustments, Security Groups, IAM permissions, calico docs and their GitHub issues to kinda be safe saying I didn't mess it up.

@PatTheSilent Maybe they improved calico or you misconfigured something as you said because I tested calico on my EKS cluster and everything working as expected. Of course, there is still a need to use hostNetwork for services that should be visible for the control plane such us metrics etc.

Is this still an issue for 4.1.4?

Hi,
Just leawe aws-node daemonset on plase. And setup calico-node too(calico
manifest from the AWS docs). You will get working calico policy and
possible EKS controll plane connections to the worker nodes. Calico
docummentation little wrong. You shouldn't delete aws-node.
чт, 25 мар. 2021 г., 21:56 Sebastian Malton @.***>:

Is this still an issue for 4.1.4?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/lensapp/lens/issues/561#issuecomment-807377425, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/ABZUL62HC2TE2EKAO3WJ2ILTFOIPNANCNFSM4ORRDBUQ
.

Okay thanks, so this sounds like it is resolved.

Hi, Just leawe aws-node daemonset on plase. And setup calico-node too(calico manifest from the AWS docs). You will get working calico policy and possible EKS controll plane connections to the worker nodes. Calico docummentation little wrong. You shouldn't delete aws-node.

Well, if you only care about the Policy, that's okay. BUT there are cases in which you want Calico CNI instead of AWS CNI. AWS CNI will consume IPs of your AWS Subnets per Pod.
I mean calico itself tells you about those options: https://docs.projectcalico.org/getting-started/kubernetes/managed-public-cloud/eks
I don't use Lens anymore so I can't tell if it's solved. But this ticket is especially about Calico CNI on EKS. And "Don't use Calico CNI" is not a valid resolution ;)

another workaround
apply a (possibly modified) version of the manifest below, and configure lens to point to "prometheus/haproxy:9090":

---
# haproxy config
apiVersion: v1
kind: ConfigMap
metadata:
  name: haproxy
  namespace: prometheus
data:
  haproxy.cfg: |+
    global
      log /dev/log  local0
      log /dev/log  local1 notice
      daemon

    defaults
      log  global
      mode  tcp
      option  tcplog
      option  dontlognull
            timeout connect 5000
            timeout client  50000
            timeout server  50000

    frontend haproxynode
        bind *:9090
        mode http
        default_backend backendnodes

    backend backendnodes
        mode http

        ##### your prometheus SERVICE
        server prometheus prometheus-foobar.prometheus.svc.cluster.local:9090 check
        ##### /your prometheus SERVICE

---
# haproxy for proxying to prometheus. key points:
#
#      dnsPolicy: ClusterFirstWithHostNet
#      hostNetwork: true
#
# also, this is outside the reach of the operator.
#
apiVersion: apps/v1
kind: DaemonSet
metadata:
  name: haproxy
  namespace: prometheus
spec:
  selector:
    matchLabels:
      app: prometheus-proxy
  template:
    metadata:
      labels:
        app: prometheus-proxy
    spec:
      containers:
      - image: haproxy
        imagePullPolicy: Always
        name: haproxy
        volumeMounts:
        - mountPath: /usr/local/etc/haproxy
          name: vol1
      dnsConfig: {}
      dnsPolicy: ClusterFirstWithHostNet
      hostNetwork: true
      restartPolicy: Always
      volumes:
      - configMap:
          defaultMode: 0777
          name: haproxy
          optional: false
        name: vol1
---
# service resource pointing to the
# haproxy. this service goes into
# the manual lens configuration
apiVersion: v1
kind: Service
metadata:
  name: haproxy
  namespace: prometheus
spec:
  clusterIP: None
  type: ClusterIP
  ports:
  - name: prometheus
    port: 9090
    protocol: TCP
    targetPort: 9090
  selector:
    app: prometheus-proxy


Dictionaries and tuples with AppFutures do not get implicitly resolved

Describe the bug
When passing a dict or tuple (or other iterable) with an AppFuture in it as the input to a PythonApp, Parsl does not implicitly know to block and resolve it before proceeding with the next task.
import parsl
from parsl import python_app
from pathlib import Path

parsl.load()

@python_app
def job1():
    return Path.cwd()

@python_app
def job2(t: tuple[Path, str]):
    Path(t[0], t[1]).touch()

job2((job1(), "hello")).result()

import parsl
from parsl import python_app
from pathlib import Path

parsl.load()

@python_app
def job1():
    return Path.cwd()

@python_app
def job2(d: dict[Path, str]):
    for k,v in d.items():
        Path(k,v).touch()

job2({job1(): "hello"}).result()

In both scenarios, you will get the same TypeError: expected str, bytes or os.PathLike object, not AppFuture because the AppFuture is not automatically resolved by the time it gets to the Path() call.

Note to self that we should also confirm the following works once the simpler case is resolved:
import parsl
from parsl import python_app
from pathlib import Path

parsl.load()

@python_app
def job1():
    return {"directory": Path.cwd()}

@python_app
def job2(t: tuple[Path, str]):
    Path(t[0], t[1]).touch()

job2((job1()["directory"], "hello")).result()

@yadudoc --- I'd be interested to get your thoughts on this one. It seems you have had similar ideas in prior issues, such as in https://github.com/Parsl/parsl/issues/1790#issuecomment-657710015. I would love to seem at least some degree of introspection, and I'm curious what your perspective is.

My proposal would be the following: if an object __contains__ an AppFuture, then Parsl should know to implicitly block and resolve. This would cover the keys of dictionaries, and first level of lists and tuples, among other iterables. It would not be recursive, but I'd argue that this is better than nothing at all.

Closed in #3111.


RevEng: Provide default context name when unspecified

The following command...
Scaffold-DbContext 'Data Source=(localdb)\MSSQLLocalDB;Initial Catalog=Northwind;Integrated Security=True' EntityFramework.SqlServer

...throws the following exception.
System.ArgumentException: The string argument 'dbContextClassName' cannot be empty.
   at Microsoft.Data.Entity.Utilities.Check.NotEmpty(String value, String parameterName)
   at Microsoft.Data.Entity.Relational.Design.ReverseEngineering.ReverseEngineeringGenerator.CheckOutputFiles(String projectPath, String relativeOutputPath, String dbContextClassName, IModel metadataModel)
   at Microsoft.Data.Entity.Relational.Design.ReverseEngineering.ReverseEngineeringGenerator.GenerateAsync(ReverseEngineeringConfiguration configuration, CancellationToken cancellationToken)
   at Microsoft.Data.Entity.Design.DatabaseOperations.ReverseEngineerAsync(String provider, String connectionString, String outputDir, String dbContextClassName, Boolean useFluentApiOnly, CancellationToken cancellationToken)
   at Microsoft.Data.Entity.Design.OperationExecutor.<ReverseEngineerImpl>d__19.MoveNext()
   at System.Linq.Buffer`1..ctor(IEnumerable`1 source)
   at System.Linq.Enumerable.ToArray[TSource](IEnumerable`1 source)
   at Microsoft.Data.Entity.Design.OperationExecutor.OperationBase.<>c__DisplayClass4_0`1.<Execute>b__0()
   at Microsoft.Data.Entity.Design.OperationExecutor.OperationBase.Execute(Action action)
The string argument 'dbContextClassName' cannot be empty.

@bricelam I'm not seeing it on my box. And it's weird - there are already a couple of layers of default - see https://github.com/aspnet/EntityFramework/blob/dev/src/EntityFramework.Relational.Design/ReverseEngineering/ReverseEngineeringGenerator.cs#L72 and https://github.com/aspnet/EntityFramework/blob/dev/src/EntityFramework.SqlServer.Design/ReverseEngineering/Configuration/SqlServerModelConfiguration.cs#L30

@lajones Were you using the DNX or NuGet commands? PowerShell might be supplying an empty string instead of null.

AH, DNX. Let me look into that.

Checked in with commit 1e6c8c9. Please re-open if any problems.

Note: further fix for issue #3047

Re-opening. Now I get the following.
public partial class  : DbContext
{
    // ...
}

P.S. Code file is correct--NorthwindContext.cs.

@lajones is this fixed now?

Signed off but not checked in. Per email am trying to include into beta-8 with table selection changes.

Fixed with PR #3356, commit 1c2916b.


what does this even mean

what does this even mean

Furqless Lua is the official defurqification project for the Lua programming language. It seeks to provide a productive environment for development of projects implementing a superset of the common Lua runtime.

what does this even mean

what does this even mean and why won't you fix it what's wrong with you
why are you like this


Video not getting dowloaded

Hi Sumeet.
Great work there!!
When I run the docker-compose up command, it is only downloading all content except videos. Can you please help me?
C:\Users\cheta\OneDrive\Desktop\Thinki-Downloader-main>docker-compose up
[+] Running 1/1
 ✔ Container ThinkiDownloader  Recreated                                                                                0.1s
Attaching to ThinkiDownloader
ThinkiDownloader  | THINKIFIC DOWNLOADER
ThinkiDownloader  | Revision 6.3.2 ~ 16th December 2023
ThinkiDownloader  | Author : SumeetWeb ~ https://github.com/sumeetweb
ThinkiDownloader  | Consider buying me a coffee at : https://www.ko-fi.com/sumeet
ThinkiDownloader  | Want to download only selected videos? Thinki-Parser Experimental is available!
ThinkiDownloader  | ----------------------------------------------------------
ThinkiDownloader  | Fetching Course Contents... Please Wait...
ThinkiDownloader  | Downloading Retail Project Code
ThinkiDownloader  | Downloading CICD Session 1
ThinkiDownloader  | No matches found for videos in HTML Item. Continuing...Downloading CICD Session 2
ThinkiDownloader  | No matches found for videos in HTML Item. Continuing...Downloading CICD Session 3
ThinkiDownloader  | No matches found for videos in HTML Item. Continuing...Downloading CICD Session 4
ThinkiDownloader  | No matches found for videos in HTML Item. Continuing...Downloading CICD Session 5
ThinkiDownloader  | No matches found for videos in HTML Item. Continuing...Downloading CICD Session 6
ThinkiDownloader  | No matches found for videos in HTML Item. Continuing...Downloading CICD Session 7
ThinkiDownloader  | No matches found for videos in HTML Item. Continuing...Downloading Running Notes
ThinkiDownloader exited with code 0

And the HTML downloaded has the following content;

[vdo otp=20160313versASE323lGr7c1DbkkoqlosLonxLLweUV0KFiFQL3KMDcg7YT33pZl playbackInfo=eyJ2aWRlb0lkIjoiMDg4ZWU1OGZkOGQ3NDY3YmI2NGViNmZlOTRjYWYwYTQifQ== tags=ultimate-interview-prep]

.env file look as below.
# For downlaoding all content, use the course link.
COURSE_LINK="<<site-name>>/api/course_player/v2/courses/continuous-integration-continuous-deployment-cicd"

# For selective content downloads, use the JSON file created from Thinki Parser.
# Copy the file to Thinki Downloader root folder (where thinkidownloader3.php is there).
# Specify the file name below. Ex. COURSE_DATA_FILE="modified-course.json"
COURSE_DATA_FILE=""

CLIENT_DATE="2023-12-30T09:31:47.532Z"
COOKIE_DATA="_thinkific_session=TEZ0NFNYRklCMjhKVzFXVS96SEU1WmlQRGJVRmxzY1BDZFo1OVB2a1BkcU1ucmdyWm03Sk0rbFIyVzFZaWhsNU96NkordXI1VTdpRDdSSFE0ZjEyOUU5RG4wdVRWckl0d1d2SGhZZmZJOXh5a3ZFREtQWGJtNjh6dnhicTJGMGNRUldVY09yc0ZpMEpsTzdJRS9EeGNNVWFFdTcvSFBHS2NuczhTa3UreW1WMnI5MGhWVTBGd25ubFpzTzZjcjl2MHMrN2M4TnBNMjd2MFpsY3BHOXNJMGxYSmxGb09WcjBISmJnaHJQRC9MZWlHdkMxV2ZoaUp2YS93cUR6TitneE9UMUFZdTM5S0JqbjhnbmU2S2txREkyNUwydnh3ZFlOL2kwbGxWWHlHTGJtdjlkL3hGdHVuMms0VlRrT0ZKNXRpYXlQdjIyYVB6UHllNWZDYTRncnlVWUgyMHdGemFDQVpLbDNDcUs0elRKU1pPdkJVMU5CaE4wUEN0aStLVmZYenNGTThSUzRHN1BpTTlENnUyK24rL1ZBbzY2bU5XYXQrdjR4TEtOanJILyszbUF0K1dFckhOY3pXaFRwdU5LaFg4b3hoVEdRc21BcGxIVU5ON3pGS2VzWVErcTZBdDFZMFVUb1hQVm9zVjA9LS1POHJnNUcxVHJqN3JWRVJqb1lOSVp3PT0%3D--fac7ad16ef776e2675ae8b029705ff14ff8fb949; path=/; secure; HttpOnly; SameSite=None"

# Quality Available: "Original File", "1080p", "720p", "540p", "360p", "224p"
VIDEO_DOWNLOAD_QUALITY="720p"

Am I missing something?
Thanks,
Chetan

Looks like videos are protected by www.vdocipher.com. I think those can't be downloaded.

Currently, the script supports downloading videos hosted on wistia only.