Add ability to make wishlists public/shareable

The existing wishlist functionality in Oscar is incomplete - the models allow for wishlists to be "public" or "shared", but the UI does not allow for making a wishlist public/shared.

Public wishlists - we should llow users to make wishlists "public" which means that they can share links to this with others. My feeling is that "public" in this case should still require the viewer to be logged-in, so that these views are not exposed to abuse and SEO implications. This should be relatvely straighforward to implement, and has a clear use case.

Shared wishlists - it seems the original intention behind this was to have lists that can collaboratively be managed by multiple users. The use case for this isn't clear to me, and I think needs elaboration before we can implement.

I've implemented the public wishlist in a project and one of the requirements is public wishlists can be shared by link and email with people without account (some kind of influencers' wishlists). So public wishlists is a really interesting feature.

This has been implemented in #3905


fix(entity): remove rewrite naming rules for relationships type #182

Don't forget to link the issue.


Use options field for Kaniko from Docker (in fallback case)

Is your feature request related to a problem?
Yes.
Options not inherited from images.app.build.docker.options when builder changed to Kaniko (as fallback for Docker).
Which solution do you suggest?
Inherit options for Kaniko from Docker in fallback case.
Which alternative solutions exist?
Copy images.app.build.docker.options to images.app.build.kaniko.options.

/kind feature

@saruman9 thanks for creating this issue! They actually should get copied by default, could you provide a sample devspace.yaml where this is not the case?

My fault: I don't test the case without the kaniko field.
Example of devspace.yaml, where Kaniko will not use options field from docker:
version: v1beta9
images:
  default:
    image: default
    build:
      docker:
        options:
          target: base
          buildArgs:
            TEST: test
      kaniko:
        snapshotMode: redo
        args:
          - --use-new-run

It's normal, that Kaniko don't run with base target and TEST build arguments, because images.default.kaniko.options is empty. But in cases where Kaniko will works as fallback engine I want to use additional options (snapshotMode, args for example).

@saruman9 Ah I see, that makes sense yes, we can implement that.

@saruman9 After some consideration, I don't think we should do this. In the case where no kaniko option is present, it makes sense to rewrite the docker config to use as kaniko config, however if an user explicitly defines a kaniko config, the expected behaviour for us is that DevSpace will use that config instead, otherwise its not really possible to override the build options and the config rewritting becomes quite unexpected.

After some days of testing I agree with you, user should explicitly set all settings for Kaniko (include options field). Btw, Kaniko is not suitable for my cases, because it has many issues if used multi-stage builds (see #1383).
Thank you for reviewing my request.


Updates package.json resolves #12 & #13

Updated package.json dependencies and ran appropriate tests to validate.
Compared bl v0.7.0 to v1.1.2 to ensure API compatibility, and it appears that the module has been optimized considerably since v0.7.0 whilst still remaining compatible.
Removed the branch and ran npm install followed by npm run test; all tests are passing as expected.

@andrewodri +1 for crafting the PR
@hughsk Hello, thank you very much for your work. Can you please take a look at this PR and merge it, the changes are adequate and it solves npm warnings and errors.
Everyone that relies on this package is currently getting warnings on install and errors on other commands. For example the npm shrinkwrap feature errors because this package requires an old version of the bl package which requires as peer dependency stream-browserify@* - considered invalid by npm.
Cheers.


Check string is nonempty before indexing

Submisison Checklist

[x] Run tests: ./runCmdStanTests.py src/test
[x] Declare copyright holder and open-source license: see below

Summary:
Resolves #1238. An unchecked indexing operation on an empty string introduced by #1228 causes a crash if compiled with -Wp,-D_GLIBCXX_ASSERTIONS, and possibly under other conditions
Intended Effect:
Resolves the crash
How to Verify:
Side Effects:
Documentation:
Copyright and Licensing
Please list the copyright holder for the work you are submitting (this will be you or your assignee, such as a university or company):
By submitting this pull request, the copyright holder is agreeing to license the submitted work under the following licenses:

Code: BSD 3-clause (https://opensource.org/licenses/BSD-3-Clause)
Documentation: CC-BY 4.0 (https://creativecommons.org/licenses/by/4.0/)

@serban-nicusor-toptal is there an easy way to set -Wp,-D_GLIBCXX_ASSERTIONS in our CI? Seems like it would catch things like this earlier.

I think the easiest way is to add that at the end of writeFile here https://github.com/stan-dev/cmdstan/blob/develop/Jenkinsfile#L11


libsForQt5.mauiPackages: 3.0.0 -> 3.0.1

Description of changes
https://mauikit.org/blog/maui-release-briefing-3/

Things done

Built on platform(s)

[ ] x86_64-linux
[x] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

duplicate of https://github.com/NixOS/nixpkgs/pull/252528


How to specify datatype and layout format to MIOpenDriver for bnorm

I have some bnorm cases were i am getting in correct results if i change datatype and format, is there any to specify datatype and format when running driver command
./bin/MIOpenDriver bnorm -n 5 -c 33 -H 27 -W 1 -m 1 --forw 2 -b 0 -s 1
For one of my case the above driver command is same for float32 and int8. But i am facing issue if i use int8 data.
Similarly,
./bin/MIOpenDriver bnorm -n 1 -c 32 -H 30 -W 1 -m 1 --forw 1 -b 0
above driver command is same for NCHW and NHWC . But i am facing issue with NHWC.
Could you please help me regarding this.

./bin/MIOpenDriver bnorm -n 5 -c 33 -H 27 -W 1 -m 1 --forw 2 -b 0 -s 1

This driver command executes FP32 BN. For FP16, use ./bin/MIOpenDriver bnormfp16 .... The library does not support INT8 for batchnorm yet.

./bin/MIOpenDriver bnorm -n 1 -c 32 -H 30 -W 1 -m 1 --forw 1 -b 0

This driver command works with NCHW layout. For now, the library does not support NHWC for batchnorm. As a workaround, you can use miopenTransformTensor() to switch from NHWC to NCHW and back.

WRT the question in the title, specifically:

How to specify datatype and layout format to MIOpenDriver for bnorm

The datatype is specified in the 1st argument of the driver, together with the primitive. For BN:

MIOpenDriver bnorm - FP32
MIOpenDriver bnormfp16 - FP16

Other options are primitive-specific. For example, the BN-specific options:
# ./bin/MIOpenDriver bnorm --help
MIOpenDriver bnorm --help
MIOpen Driver Input Flags:

      --alpha              -A        Alpha (Default=1.0)
      --beta               -B        Beta (Default=0.)
      --in_d               -D        Input Depth (Default=0)
      --forw               -F        Run Forward Train (off: 0, train: 1, inference: 2) Batch Normalization (Default=1)
      --in_h               -H        Input Height (Default=32)
      --printconv          -P        Print Convolution Dimensions (Default=1)
      --verify             -V        Verify Each Layer (Default=1)
      --in_w               -W        Input Width (Default=32)
      --back               -b        Backwards Propagation (off: 0, on: 1) Batch Normalization (Default=0)
      --in_channels        -c        Number of Input Channels (Default=3)
      --help               -h        Print Help Message
      --iter               -i        Number of Iterations (Default=1)
      --mode               -m        Normalization Mode (per-activation (0) or spatial (1)) (Default=0)
      --batchsize          -n        Mini-batch size (Default=32)
      --run                -r        Keep running mean and variance, or on inference, use these values. (Default=0)
      --save               -s        Save off mean and inverse variance, or on backprop, use these values. (Default=0)
      --time               -t        Time Each Layer (Default=0)
      --wall               -w        Wall-clock Time Each Layer, Requires time == 1 (Default=0)

As you can see, there is no option related to layout.
Generally, the driver supports only functionality supported by the library. Consequently, there is no INT8 BN or NHWC BN support in the driver yet.

@atamazov
Thankyou for the confirmation.

Hi @atamazov ,
Thankyou for the confirmation


Flashing scrollbar after a rebus has been answered correctly

When a rebus has been answered correctly and the confetti animation finishes - the scrollbar flashes.
Steps to Reproduce the Problem

Answer a rebus correctly.
Wait until the confetti animation finishes
Watch the scrollbar flash for a second

After looking into the issue, I found that the content of the div containing the confetti animation would sometimes grow larger than the browser window; causing the scrollbar to appear/disappear during the time of the animation.
I've created PR #186, which includes the adjustment of setting the overflow property value to hidden of the .app class to help address the issue.

@vanwykjd Nice catch, thanks for fixing this 🙂


https://musicaldown.com/en/ is your website?

https://musicaldown.com/en/ is your website?   if not, this way will be stopped at any time.

It is not my website, and if that happens I'll use new website.

Here there are many provides that you can use them https://github.com/hansputera/tiktok-dl/tree/dev/packages/core/src

Thanks Reply. i want to know the limits of this api. is there such a limit?

I didn't set a limit for TikTok api, also you can make a api like this using Heroku. However, there are limiting from heroku 4500 request in the hours. Thanks

ok fine. i find other way also can convert tiktok video.i will use several way to convert tiktok link. thank you very much for your reply.


Missing callback URL in Twitter app prevents tweeting

Hello,
after setting up your example for Twitter at first glance everything works fine with Twitter. But posting tweets ended in an exception:
 I/O error on POST request for "https://api.twitter.com/1.1/statuses/update.json": cannot retry due to server authentication, in streaming mode; nested exception is java.net.HttpRetryException: cannot retry due to server authentication, in streaming mode
After some research I finally found a solution. Your predefined Twitter app is not set up correctly in your samples context. A callback URL is mandatory for sending tweets. Please see https://spring.io/guides/gs/accessing-twitter/ .

Be sure to register a callback URL with Twitter (it has to be a valid URL, but it doesn’t need to be the URL of your app).

BR
Stefan

Hi , I'm facing the same issue could you please guide me to to solve this issue ?

Sorry, still open point with spring-social-twitter. I have implemented a workaround by extracting acquired access token received by spring-social-library and feed it to another library which makes POST without problems.


[Release] Update docs for RELEASE.2022-08-11T04-37-28Z

Release RELEASE.2022-08-11T04-37-28Z has changes that impact the docs:

[ ] The healing process for buckets or sites with replication is now prompted when running mc stat, mc cat, or mc ls. Update the site replication and bucket replication docs. PR #15501
[ ] New feature allows you to enable object locking when creating a bucket PR #15505

@kannappanr @harshavardhana it would be excellent if we could find a way via github actions to automatically create these tickets on release for issues that are marked as 'Documentation Needed' or something.
Manually reviewing release queues for our various products is somewhat inefficient.


Open Views/Shared/_Layout.cshtml ,type " <input asp-test="" " in the  tag and delete a double quote, the format is incorrect.

**REPRO CONFIGURATION:**Win10 x64 20H1 + SDK 6.0.rc1 + Feed
Latest SDK Version: 6.0.100-rc.1.21418.40
Latest Runtime Version: 6.0.0-rc.1.21418.9
INSTALL STEPS:

Clean machine: Win10 x64 20H1
Install the sdk 6.0.rc1 from: https://aka.ms/dotnet/6.0.1XX-rc1/daily/dotnet-sdk-win-x64.exe
Install VS Code from: https://code.visualstudio.com/Download
Install C# Extensions version: v1.23.15.vsix from: https://github.com/OmniSharp/omnisharp-vscode/releases
Apply feed: https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet6/nuget/v3/index.json

Testcases Affected
SimpleWebAppRazorEditingWithVSCode
Platform

[x] Windows
[ ] macOS
[x] Linux

Repro Steps

Open a normal Terminal Emulator
Create mvc project and open it using VS code

  md mvc
  cd mvc
  dotnet new mvc
  code .

Go to https://github.com/OmniSharp/omnisharp-vscode/releases > Download the csharp-1.23.15.vsix.
In VS Code and go to the Extensions Tab, select "Install from VSIX" > install the file you downloaded.
Open Views/Shared/_Layout.cshtml and type " <input asp-test="" " in the <body> tag, then delete a double quote, wait a few seconds, the format is incorrect.

Note:

This issue repro on the SDK 6.0 preview 7 +  v1.23.15.
This issue not repro on C# Extensions is v1.23.14.
On Linux OS, delete a double quote, wait a few seconds, it will pops up CodeLens references.

Actual Result

On Linux OS

Expected Result

@v-cazhang Would you mind filing another bug for the second issue you're seeing?


Codec fix

Adding 1 extra bit to codec representation for higher resolution

The bitshifting of the x-value by 1 is a fix for ATIS gen3 that isn't backwards compatible and instead needs to be fixed in the gen3 FPGA. #117 fixes the higher resolution camera support without introducing the bug.


Is possible to use with custom shape or aspect ratio?

I would like to use this for crop my image for target size. For this use case I must define target size or aspect ratio (and manually resize it).
It support any from my requirements?

It is already posible to add a custom shape & aspect ratio. Not sure what you are looking for exactly.
This is not yet supported.

Maybe you can give an example.


Hulu does not work

With the latest master branch, everything works fine at build time. Netflix also works fine (so far).
However, Hulu does not seem to work anymore. I get the Anonymous Proxy error when playing a video. Hulu works for me for other commercial unblockers, like unblocator.com

Have you read foot note [n2] in the README?

Yes, I've read it. What are our options? This means that we do not support Hulu?

If you can find a provider that Hulu hasn't blocked (good luck), then this will work just fine.

I am going to close this since there are no actions..
Cheers!


feat: updates from spectrum-tokens-studio-data

Created by Action: https://github.com/adobe/spectrum-tokens-studio-data/actions/runs/9322286458

Run report for e8772f7a
Total time: 30.2s | Comparison time: 30.7s | Estimated savings: 488.6ms (1.6% faster)

Action
Time
Status
Info

🟩
SyncWorkspace
0ms
Passed

⬛
SetupNodeTool(~20.12)
1.2s
Skipped

🟩
InstallNodeDeps(~20.12)
6.6s
Passed

🟩
SyncNodeProject(tokens)
0.2ms
Passed

🟩
SyncNodeProject(root)
0.2ms
Passed

🟩
RunTask(tokens:buildTokens)
19.1s
Passed

🟩
RunTask(tokens:buildManifest)
289ms
Passed

🟩
RunTask(root:test)
1.5s
Passed

🟩
RunTask(tokens:build)
0.2ms
Passed

🟩
RunTask(tokens:generateDiffResult)
2.7s
Passed

🟥
RunTask(tokens:test)
3.3s
Failed

Touched files
packages/tokens/src/icons.json
packages/tokens/src/semantic-color-palette.json


httplib.BadStatusLine: '' SOLVED!

Hi! I've been trying to use the following script to download some images but it gets stuck on the 31st image of the first search (Accordion). Any ideas on how to fix this?
SCRIPT:
{     "Records": [         {             "keywords": "Accordion",             "limit": 50         },         {             "keywords": "guitar",             "limit": 50         }     ] }
ERROR:
Traceback (most recent call last):   File "/usr/local/bin/googleimagesdownload", line 11, in <module>     sys.exit(main())   File "/usr/local/lib/python2.7/site-packages/google_images_download/google_images_download.py", line 888, in main     paths = response.download(arguments)  #wrapping response in a variable just for consistency   File "/usr/local/lib/python2.7/site-packages/google_images_download/google_images_download.py", line 843, in download     items,errorCount,abs_path = self._get_all_items(raw_html,main_directory,dir_name,limit,arguments)    #get all image items and download images   File "/usr/local/lib/python2.7/site-packages/google_images_download/google_images_download.py", line 709, in _get_all_items     download_status,download_message,return_image_name,absolute_path = self.download_image(object['image_link'],object['image_format'],main_directory,dir_name,count,arguments['print_urls'],arguments['socket_timeout'],arguments['prefix'],arguments['print_size'],arguments['no_numbering'])   File "/usr/local/lib/python2.7/site-packages/google_images_download/google_images_download.py", line 566, in download_image     response = urlopen(req, None, timeout)   File "/usr/local/Cellar/python/2.7.13/Frameworks/Python.framework/Versions/2.7/lib/python2.7/urllib2.py", line 154, in urlopen     return opener.open(url, data, timeout)   File "/usr/local/Cellar/python/2.7.13/Frameworks/Python.framework/Versions/2.7/lib/python2.7/urllib2.py", line 429, in open     response = self._open(req, data)   File "/usr/local/Cellar/python/2.7.13/Frameworks/Python.framework/Versions/2.7/lib/python2.7/urllib2.py", line 447, in _open     '_open', req)   File "/usr/local/Cellar/python/2.7.13/Frameworks/Python.framework/Versions/2.7/lib/python2.7/urllib2.py", line 407, in _call_chain     result = func(*args)   File "/usr/local/Cellar/python/2.7.13/Frameworks/Python.framework/Versions/2.7/lib/python2.7/urllib2.py", line 1228, in http_open     return self.do_open(httplib.HTTPConnection, req)   File "/usr/local/Cellar/python/2.7.13/Frameworks/Python.framework/Versions/2.7/lib/python2.7/urllib2.py", line 1201, in do_open     r = h.getresponse(buffering=True)   File "/usr/local/Cellar/python/2.7.13/Frameworks/Python.framework/Versions/2.7/lib/python2.7/httplib.py", line 1121, in getresponse     response.begin()   File "/usr/local/Cellar/python/2.7.13/Frameworks/Python.framework/Versions/2.7/lib/python2.7/httplib.py", line 438, in begin     version, status, reason = self._read_status()   File "/usr/local/Cellar/python/2.7.13/Frameworks/Python.framework/Versions/2.7/lib/python2.7/httplib.py", line 402, in _read_status     raise BadStatusLine(line) httplib.BadStatusLine: ''

ok, it was just my firewall settings LOL now it's working

Thanks. This should still give out a decent message instead of failing with this nasty. I will update the source accordingly. Closing this for now.

I am facing the same problem. Is the problem really solved?
Error: httplib.BadStatusLine: ''


Code conventions?

https://jitsi.org/Documentation/CodeConvention
404 not found

Will fix it, but from where did you get the link?
https://desktop.jitsi.org/Documentation/CodeConvention should be fine.

here https://github.com/jitsi/jitsi/blob/master/CONTRIBUTING.md


Can you use this in an Azure Pipeline?

Hi,
This is where the Q&A link on https://marketplace.visualstudio.com/items?itemName=bizeta.nsis-task&ssr=false#qna sent me, so I'm asking here. Can this be used in an Azure Pipeline? If so, how do you use it in the pipeline?
I've switched from AWS Codepipeline to Azure Pipeline because my new code signing certificate lives in Azure Key Vault. In AWS Codepipeline I just stored the makensis.exe in my repo and used it to compile the installers (i.e. ./makensis.exe /V1 "$(scriptname)" ). Azure Pipeline is blocking the execution of the binary for security reasons, but I found this plugin which seems like it could be used.
If it can indeed be used in Azure Pipeline, is there any chance you could provide an example of the yaml that is required and any additional setup steps required to get the pipeline to see this extension? There is some information in the readme, but it wasn't clear to me what I need to put to make it work.
One other thing that wasn't exactly clear to me was what you meant by the following:

Include NSIS as an environnement variable called NSIS_EXE that you can use in the following tasks.

Do you mean this?
variables:
  - name: NSIS
    value: NSIS_EXE

Thanks for the help!

@development-bizeta-mestre or @tomap do you know the answer to this?

Hi @mec07,
Yes this plugin can be used in azure pipeline, please check the sample code below:
  - task: bizeta.nsis-task.796c90b1-9f8c-424a-b03b-b789bb5945d3.nsis@2
    displayName: Nsis
    inputs:
      scriptFile: '{absolute-path-to-your-script}.nsi'
      arguments: '/V3 /DDISTDIR="{absolute-path-to-your-build-output}"'
      includeMorePlugins: yes
      includeCustomPlugins: yes
      includeCustomPluginsPath: '{absolute-path-to-your-plugins-folder}'

includeMorePlugins : yes | no, if you want to include the default plugins provided with task. Follow this link to check what they are: https://github.com/development-bizeta-mestre/nsis-extension/tree/master/nsis/plugins
includeCustomPlugins : yes | no, if you want to include more plugins that aren't provided as default, must be 'yes' if you want include your plugins
includeCustomPluginsPath : https://github.com/development-bizeta-mestre/nsis-extension#custom-plugins-path


[SPARK-33971][SQL] Eliminate distinct from more aggregates

What changes were proposed in this pull request?

Add more aggregate expressions to EliminateDistinct rule.
Why are the changes needed?

Distinct aggregation can add a significant overhead. It's better to remove distinct whenever possible.
Does this PR introduce any user-facing change?

No
How was this patch tested?

UT

Looks making sense otherwise. cc @gengliangwang and @cloud-fan FYI

Looks making sense otherwise. cc @gengliangwang and @cloud-fan FYI

ok to test

ok to test

Test build #133615 has started for PR 30999 at commit d1cd01d.

Test build #133615 has started for PR 30999 at commit d1cd01d.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/38204/

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/38204/

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/38204/

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/38204/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/38204/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/38204/

Test build #133615 has finished for PR 30999 at commit d1cd01d.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test build #133615 has finished for PR 30999 at commit d1cd01d.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/133615/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/133615/

Test build #133870 has started for PR 30999 at commit 5f9df99.

Test build #133870 has started for PR 30999 at commit 5f9df99.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/38459/

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/38459/

Test build #133872 has started for PR 30999 at commit 4b9d04b.

Test build #133872 has started for PR 30999 at commit 4b9d04b.

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/38459/

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/38459/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/38459/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/38459/

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/38461/

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/38461/

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/38461/

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/38461/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/38461/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/38461/

Test build #133870 has finished for PR 30999 at commit 5f9df99.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test build #133870 has finished for PR 30999 at commit 5f9df99.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/133870/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/133870/

Test build #133872 has finished for PR 30999 at commit 4b9d04b.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test build #133872 has finished for PR 30999 at commit 4b9d04b.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/133872/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/133872/

@tanelk ping.

@tanelk ping.

Test build #134514 has started for PR 30999 at commit f95fb8d.

Test build #134514 has started for PR 30999 at commit f95fb8d.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/39099/

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/39099/

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/39099/

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/39099/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/39099/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/39099/

Test build #134514 has finished for PR 30999 at commit f95fb8d.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test build #134514 has finished for PR 30999 at commit f95fb8d.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/134514/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/134514/

retest this please

Test build #135424 has started for PR 30999 at commit f95fb8d.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/40004/

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/40004/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/40004/

Test build #135424 has finished for PR 30999 at commit f95fb8d.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/135424/

Thanks! Merged to master.


Implement Bus Contract

Bus must be reconstructed with updated list of caches on every call of runAllSimulationCycles while maintaining its current state, including its own private Memory unit. This is to ensure that the Bus has the most up-to-date view of all the caches .
Implement Bus.acquire and Bus.release methods for a processor to lockdown the bus. Bus.isFree must report True if the bus is released.
Implement Bus.isBusy which indicates that the Bus is completing a memory operation and cannot be used.
Implement pattern matching for MESIBusRd, MESIBusRdX, DragonBusRd, DragonUpdate protocol events.

Points 1 - 3 are done in 40f4a4e - heads up to @AlvianPrasetya

Affirmative @frizensami , working on bus transactions...

:+1: am adding tests for the OtherInstructions part now to make sure we don't regress on that when we add the Protocol components

Travis CI added in https://github.com/frizensami/cs4223-as2/commit/2ca8e1d6ac9b7785865168e842f8771ef0bab90a

Changed to different implementation


Missing Object.is_null

Describe the bug
At the moment there are Callable.is_null and Signal.is_null but the Object.is_null is missing
Expected behavior
No response
Actual behavior
No response
How to Reproduce?
No response
Godot full version
4.2.1.stable
Orchestrator version
v2.0.rc2
Additional information
No response

Hi @GhostNr1, Godot does not really expose anything like Object::is_null, but what they do provide is is_instance_valid:

Does this solve the issue?

This is just reveresed but should solve this problem.


[com.google.fonts/check/interpolation_issues] forgot to display glyph name

Observed behaviour
As @colinmford has colourfully pointed out, the new updates to the interpolation_issues check (underweight, overweight, kink, etc.) do not report the name of the glyph in which the issue was found.
Expected behaviour
The error message should include the glyph name.

thanks, @simoncozens


Add null-safety support

Fix for #27

@vi-k please approve and publish a null-safety version. Thanks


Issue: Unable to install in Arch Linux

Cloned the repo and then ran the dependencies command (yay one) and then ran makepkg -si and I am running into the following error. I see a white windows on the top left and it immediately crashes. The link to the error is below. Please resolve ASAP.
https://rlim.com/t41WXC1XMT

The error log is showing issues with the runtime nwjs. I suspect it occurs not during makepkg -i but when you attempt to run pgAdmin after the installation. What happens if you run just nwjs?

https://github.com/merll/pgadmin4-nw/issues/7#issuecomment-2198233924

It says command not found: nwjs. I have installed the dependency as mentioned in the readme (yay command).

What happens if you run just nwjs?

It says command not found: nwjs. Weird since I have gone through the dependency list as stated in readme (yay command).


[v1.7.x] Fix CI error

Description
Fix the following CI error:
[2020-05-28T17:49:56.861Z] + ln -s /usr/bin/ninja-build /usr/bin/ninja

[2020-05-28T17:49:56.861Z] ln: failed to create symbolic link '/usr/bin/ninja': File exists

[2020-05-28T17:49:57.421Z] The command '/bin/sh -c /work/centos7_core.sh' returned a non-zero code: 1

@TaoLv @leezu @pengzhao-intel @ChaiBapchya

Hi @ciyongch, it seems that the reason for the CI failures in the v1.7.x branch are the same as in v1.x: the ninja package in CentOS now ships with the required symlink, which makes it unnecessary to create it manually. I fixed this issue in v1.x by removing the build step that creates the symlink: https://github.com/apache/incubator-mxnet/pull/18437

@nickguletskii Thanks for point it out for the fix:), would you mind to backport that PR into v1.7.x branch as well?
Regarding the rest of symlink change in this PR, I suggest to use ln -sf instead of ln -s, what do you think?

@nickguletskii Thanks for point it out for the fix:), would you mind to backport that PR into v1.7.x branch as well?
Regarding the rest of symlink change in this PR, I suggest to use ln -sf instead of ln -s, what do you think?

I've created a backport here: #18456 .
Concerning the other symlink changes: let's see if the CI passes without the ninja link first. Personally, I don't think overwriting symlinks managed by the system's package manager is a very good idea, even in containers, so unless the CI jobs fail without ln -sf, I don't think these changes are necessary.

Thanks for your help and comments @nickguletskii , let's just keep the rest as is if the CI passed. My initial thoughts was to handle all the potential of this kind of issue, as ln -sf is used widely in the current build script.

#18456


ci: Test all feature combinations

Instead of testing some packages' feature combinations, test them all with cargo hack --feature-powerset check. Only running cargo check should also be quicker than running tests.
depends on #1483, #1482, #1392

is this still being worked on?

is this still being worked on?

It's finished, just blocking on other PRs

Re-targeting onto next to avoid conflicts with #1684


[Website - Branding Resources on Swag ] Simplifying/ scaling community self printing MP t-shirt

I was thinking. How can we make it as easy as possible for MP contributors to purchase on their own MP swag and still find a way to control the branding/ quality?
https://teespring.com/ (there are many more similar sites we can pick that maybe be best for US and EU)
With this site you can upload designs (create mockups), decide colors, material it can be printed on, and manage how much you would like to charge (can set it to no profit).
Pretty much people can order what they want, how many they want and they will print it and send it to them. But having some control over the branding.
How it works:
https://community.teespring.com/training-center/how-does-teespring-work/
Thoughts?
Ryan

@aeiras

Maybe best way around all these logo discussions, allow only to print the front of the shirt with the MP logo

@rstjames,
The hoody version of the 2023 design is missing from the drive. https://drive.google.com/drive/u/0/folders/10HK2v2NVrploWgl66jE1o8B6YnYVAGc2
Can you please create those files and add them to the drive? Thanks!

Hoodie updated on the drive @aeiras

@aeiras A swag  section was added to the resource page. This give contributors access to the source data for printing MP swag on their own. This is a step before we set up a simple for people to order swag off a website.
https://microprofile.io/resources/#swag
As for  "self-printing"  I am going over these companies and seeing which ones are in the US and Europe
https://ecommerce-platforms.com/articles/best-print-on-demand-companies-in-europe
From there I think if we pick one we will need to do some test orders. To make sure we select the correct quality shirt/ color and price range.

@r

@rstjames,
I love how you organized the files and created the landing link on the branding page. Very efficient to navigate upon arriving at the branding page, exactly what was needed.   How about adding the USA vendor folder to that space as well?  the Link is below. I don't wish to touch the folder, thank you.
https://drive.google.com/drive/folders/1WVewzWuskwyWD_7ATQeEf_iHjERxAWCD

Updated both tickets.
Step one making the print data available ,
step two setting things up on a self print website.
Step Three test the website.
Step 4 (optional) integrate the shop onto our website. Making it so the visitor doesn't need to travel to the 3rd party site to buy what they want.

1 to all steps with #1 completed completed, the 2, 3 & 4 required research.  There is no rush on the completion of the task as we currently must complete the Projects' landing pages first.  ETA for swag improvement could be Q4 based on current priorities. Yet, if stuff can be done in parallel, that is also a positive.

You rock, Triber!


[BUG] Styles from scss, are ignored

Checklist before submitting an issue

[X] I have searched through the existing closed and open issues for eww and made sure this is not a duplicate
[X] I have specifically verified that this bug is not a common user error
[X] I am providing as much relevant information as I am able to in this bug report (Minimal config to reproduce the issue for example, if applicable)

Description of the bug
Background style from yuck file is ignoring background style from scss file.
https://user-images.githubusercontent.com/29358657/197986377-bad11aa3-8102-44da-a2ee-ee0a15e15c6f.mp4
Reproducing the issue
Create a box with background in yuck file and try to overwrite child blocks background from scss
Expected behaviour
Use background color from scss
Additional context
No response

I figured out something strange. It seems like it's not my title and artist blocks background
https://user-images.githubusercontent.com/29358657/197989770-fd12c3a3-a25e-4ed0-af0e-f5226dde8557.mp4

If I set the rendering mode "Picture", the problem is solved. But how to set it permanent?
https://user-images.githubusercontent.com/29358657/198052759-bf4a748d-672b-440b-a1b6-1e1d532bc88c.mp4

I realized that this is a rendering bug, because css has no effect on the appearance of these strange backgrounds. I also noticed that these backgrounds appear when the variables that use these elements are updated.
https://user-images.githubusercontent.com/29358657/199301729-dd14ec6a-a691-4278-883b-3fef0c979644.mp4
https://user-images.githubusercontent.com/29358657/199301894-ae0e9c81-ad1d-4db2-b86d-ad59a0ef157e.mp4
Also there is no such glitches when using "Image" rendering mode, as I said before

You sure you just didn't activate the show widget resize option of the inspector ? it makes any widget that changes size flash red

You sure you just didn't activate the show widget resize option of the inspector ? it makes any widget that updates flash red

Yes, I'm sure. Second video in previous message is with enabled "Show grafical update", I've enabled it to show that this glitches appears with similar timing as variables updates


[MNT] reimplement horizontal/vertical slicing and remove finalize from _constructor(_sliced)

Pandas is in the progress of deprecating to allow non-class returns from _constructor and _constructor_sliced (https://github.com/pandas-dev/pandas/pull/52420).
This in turn means that FastF1 needs to change its implementations for differentiating between horizontal and vertical slicing of dataframes.
Also, the __finalize__ call that is done as a patch to work around the incomplete implementation in pandas needs to be removed from the constructor properties.

To be clear, there is not agreement at all that we want to do this, and as such there are no concrete plans to actually deprecate this.
The actual discussion is at https://github.com/pandas-dev/pandas/issues/51772 (the mentioned PR is a bit premature).

This in turn means that FastF1 needs to change its implementations for differentiating between horizontal and vertical slicing of dataframes.

I am curious about this, can you point to the relevant code? (it's useful for us to better understand real-world subclassing use cases)
Looking at for example the Telemetry subclass, the _constructor function only seems to do the extra __finalize__ call (which is a good workaround for pandas failing to call it in some places, as you mention)

I know that there is no agreement on this yet. But I want to keep a close eye on this and therefore have opened this issue as a kind of reminder. If Pandas deprecates the callable constructor (and _metadata as well), important parts of how internal structures in FastF1 currently work will fall apart and need to be reimplemented in some way.
There are two ways in which FastF1 currently uses the callable constructor:

__finalize__ in the constructor as a catch-all workaround for incomplete metadata propagation (at a small performance cost).
__finalize__ would need to be called explicitly after every problematic operation.
horizontal and vertical slicing of dataframes, here is an example: https://github.com/theOehrly/Fast-F1/blob/f5446afa7b2ff0860fbc4be3109485496978cd35/fastf1/core.py#L2943-L2953
This could be implemented in __new__ as well, I guess, but only because the column names for basically all DataFrame-like objects in FastF1 are basically constant. So the reference to self.columns is not necessary. But it would then fail, as soon as users add their own columns to a DataFrame (which they can do).

Deprecating _metadata would be more problematic than deprecating the callable costructor, but I see this one happening sooner, potentially.

Thanks for the explanation, that's super useful!

Deprecating _metadata would be more problematic than deprecating the callable constructor, but I see this one happening sooner, potentially.

To be honest, I don't think this will happen any time soon. We also make use of this in GeoPandas, without easy ways around it (I am a maintainer of both pandas and GeoPandas)
For GeoPandas it is similar situation, I think: the ability to have a custom new function in _constructor is mostly convenient, but can be workaround somewhat (but at the same time I don't really see the benefit for pandas to actually disallow this). But _metadata is much more fundamental, and is a large part of what makes subclassing useful/working.


[Swift 4.2] Confirmed Linear Regression to work with Swift 4.2

Checklist

[x] I've looked at the contribution guidelines.
[x] This pull request is complete and ready for review.

Description
I've confirmed that the linear regression playground still works with Swift 4.2. I also removed a warning by renaming an unused loop variable to _.

Part of issue #748.

Thanks for the update 👍


Ports to other browser vendors

@smcgivern can you take a look?

Looks good, love a good makefile. Looks like the Travis build might need updating to point to the new Chrome unpacked extension directory.

Yeah I love how fast make is.
BTW also added a nice little installation and configuration website: http://rightscale.github.io/ui-previewer-button/

:heart_eyes:
That's awesome.


Comb all functions for incidences of site numbers being treated as numeric

Some functions may be treating site numbers as a numeric class and must be changed to character.

I have not found any more instances of this. closing


[Task]: Optimize Webpack bundler

Task description
Webpack has relatively slow bundling times, and while it would be best to upgrade the bundler entirely, it would also be worthwhile to explore optimizations we can make as an intermediary step.
Requirements

[ ] Look into using eval-cheap-module-source-map
[ ] Look into using swc-loader or esbuild-loader
[ ] Rely on IDE for type checking, removing it from the development build process

Creation checklist

[X] I have assigned this task to the correct people
[X] I have added the most appropriate labels
[X] I have linked the correct milestone and/or project

https://webpack.js.org/guides/build-performance/


Warning of empty body with Content-Type header

Prerequisites

[x] I have written a descriptive issue title
[x] I have verified that I am running the latest version of Nancy
[x] I have verified if the problem exist in both DEBUG and RELEASE mode
[x] I have searched open and closed issues to ensure it has not already been reported

Description
If a Content-Type header matching a deserializer, i.e. "application/json", is supplied with a GET request but the body is empty then when you try to do Model Binding you will get a ModelBindingException wrapping a TargetInvocationException wrapping a SerializationException "Invalid JSON string".
The check in SimpleJson.TryDeserializeObject(string json, out object obj) checks that json != null but it may be missing an empty string check perhaps? Or maybe this could be checked in the DefaultBinder.DeserializeRequestBody() before passing an empty context.Context.Request.Body? It is failing and that's good but the error could be more specific, i.e. "Missing JSON body".
Steps to Reproduce
A GET Request that set the Content-Type to something that will find a deserializer, i.e. "application/json", but doesn't have an Entity Body.
GET http://localhost:5000/AB/accounts
HTTP/1.1
Accept: application/json, text/javascript, /; q=0.01
Content-Type: application/json; charset=utf-8
System Configuration

Nancy version: clint-eastwood
Nancy host

[ ] ASP.NET
[ ] OWIN
[ ] Self-Hosted
[x] Other: Kestrel

Other Nancy packages and versions:
Environment (Operating system, version and so on): W10
.NET Framework version: dotnetcore 1.1
Additional information:

We hit the same problem. And we verified, this was working properly in 1.4.x
The following test passes in 1.4. Similar (with the new syntax) fails in clint-eastwood:
namespace NancyHeader
{
    using FluentAssertions;
    using Nancy;
    using Nancy.ModelBinding;
    using Nancy.Testing;
    using NUnit.Framework;
    public class Dto
    {
        public string Data { get; set; }
    }

    public class TestModule : NancyModule
    {
        public TestModule()
        {
            Get["/"] = o =>
            {
                var model = this.Bind<Dto>();
                return Response.AsJson(model);
            };
        }
    }

    public class Test
    {
        [Test]
        public void Should_bind_with_empty_body()
        {
            var br = new Browser(c => c.Module<TestModule>());
            br.Get("/", c=>c.Header("Content-Type", "application/json"))
                .StatusCode.ShouldBeEquivalentTo(HttpStatusCode.OK);
        }
    }
}

I would give it a try, but I'm not sure where to handle this. The JsonBodyDeserializer? Or higher, i.e. do not try to bind the body at all if it's empty.

After looking through the json deserializer in v1.4 I think that should have thrown an exception as well, but didn't due to the body being passed to a TextReader first. So even if the body was null/empty the TextReader wasn't and the code continued on and returned null JsonDeserializer.cs#L334-L372.
SimpleJson.cs#L531 could be updated like so to fix this:
diff --git a/src/Nancy/Json/SimpleJson.cs b/src/Nancy/Json/SimpleJson.cs
index eb1f255a..bd00636e 100644
--- a/src/Nancy/Json/SimpleJson.cs
+++ b/src/Nancy/Json/SimpleJson.cs
@@ -538,6 +538,11 @@ static SimpleJson()
         /// <returns>An IList<object>, a IDictionary<string,object>, a double, a string, null, true, or false</returns>
         public static object DeserializeObject(string json)
         {
+            if (string.IsNullOrWhiteSpace(json))
+            {
+                return null;
+            }
+
             object obj;
             if (TryDeserializeObject(json, out obj))
                 return obj;

Any updates on a fix for this?

@xt0rted care to take a stab at this? There is another proposed change to Content-Type header on #2769 - mentioning it to make it won't have an impact on the proposed change in here


GetObject / UpdateObject  with inherit_members

There is a bug (or lack of feature) in Redmine REST API "GET /projects/[id].xml". It doesn't return inherit_members field value of project (https://www.redmine.org/issues/32002). But this field can be updated by "PUT /projects/[id].xml".
When using redmine-net-api to update some properties of existing Redmine Project object at first we get it by GetObject and InheritMembers is always false. Even if it is set to true in Redmine. Next by executing UpdateObject we are updating Redmine Project and inherit_members is setting to false. And this is not right.
This is not a bug of redmine-net-api, but it's very uncomfortable.
Is there a way to get round this problem?
May be doesn't update InheritMembers with UpdateObject?

InheritMembers update will be disabled until the redmine issue will be fixed.

Zapadi, thank you.
Guys from Redmine will fix it in release 4.1.0


Add bookmark button to session details screen

@joreilly we should include the button in the speaker session list too. 😄

Ah, we may also want to include the room and the speakers (as a talk can have multiple speakers, it may be useful to see everyone that is involved). Basically, same content from the sessions list item.

@joreilly we should include the button in the speaker details sessions list too. 😄

Any suggestions on where to put the bookmark icon on the speaker details screen?

Hmm, I think it was added there already?

Hmm, I think it was added there already?

Just pulled the main, and I can't see it. I added it only for the session detail screen.

ah, sorry, I missed the word "speaker" (my brain on go slow here :) ).  I'm not sure if there's as much need to put on speaker details screen....you can always click through to the session and do it there.  We're a bit more limited on speaker screen with space....particularly given speaker can have multiple sessions.  wdyt?

Yeah, I think you are correct. Looking at the screen, at least on mobile, there is no that much space to add the bookmark in front of each speaker's talk.

will close this issue anyway and we can open another one if needed later


Attachements are not copying while creating Sales Order from Blanket Sales Order

Create a Blanket Sales Order with items.
Add attachements using Attachments factbox.
Click on Make Order action
Now blanket sales order will convert to sales order, But attachements are not copying to created Sales order.
This is working fine in Blanket Purchase Order.

I have checked in code and below are my findings
Codeunit 87 "Blanket Sales Order to Order"
Function CreateSalesHeader

For above highlighted publisher there is a subscriber in codeunit 1173

the above highlighted condition becomes true because of before calling publisher SalesOrderHeader No. is assigning with empty. see below image

beause of that it exists without executing rest of the code.
If you create a subscriber for OnBeforeSalesOrderHeaderModify then it will solve the issue.

Could you please check and solve this.

Hi @MaheshUppala .
Follow from you description it looks like a bug but not event request. Could be so kind to reach out to the relevant support channel for example https://support.microsoft.com/en-us/supportforbusiness/productselection?sapId=93d37907-ad94-d591-22e9-593cfa09dd3f and create support request there?

@MaheshUppala , any objections if we close current issue and you will open relevant support request?

No you can close it will create that issue in support link

Ok, thanks for collaboration.


[os-monit]: filesystem statistics error -- cannot parse device '/dev/gpt/rootfs'

Hey,
my system log gets spammed by the following message since weeks or even month:
Sep 14 10:59:07 | monit[53265]: filesystem statistics error -- cannot parse device '/dev/gpt/rootfs'
Sep 14 10:57:07 | monit[53265]: filesystem statistics error -- cannot parse device '/dev/gpt/rootfs'
Sep 14 10:55:07 | monit[53265]: filesystem statistics error -- cannot parse device '/dev/gpt/rootfs'
Sep 14 10:53:07 | monit[53265]: filesystem statistics error -- cannot parse device '/dev/gpt/rootfs'
Sep 14 10:51:07 | monit[53265]: filesystem statistics error -- cannot parse device '/dev/gpt/rootfs'
Sep 14 10:49:07 | monit[53265]: filesystem statistics error -- cannot parse device '/dev/gpt/rootfs'
Sep 14 10:47:07 | monit[53265]: filesystem statistics error -- cannot parse device '/dev/gpt/rootfs'

On ui/monit/status/ everything looks fine:
Monit 5.23.0 uptime: 8d 2h 58m

System 'opnsense.example.com'
  status                       OK
  monitoring status            Monitored
  monitoring mode              active
  on reboot                    start
  load average                 [0.42] [0.34] [0.27]
  cpu                          1.9%us 1.6%sy
  memory usage                 628.3 MB [15.5%]
  swap usage                   0 B [0.0%]
  uptime                       8d 3h 0m
  boot time                    Wed, 06 Sep 2017 11:47:53
  data collected               Thu, 14 Sep 2017 14:47:15

Filesystem 'RootFs'
  status                       OK
  monitoring status            Monitored
  monitoring mode              active
  on reboot                    start
  filesystem type              ufs
  filesystem flags             soft updates, noatime, local, rootfs
  permission                   755
  uid                          0
  gid                          0
  block size                   4 kB
  space total                  13.5 GB (of which 8.0% is reserved for root user)
  space free for non superuser 11.2 GB [82.8%]
  space free total             12.2 GB [90.8%]
  inodes total                 1845886
  inodes free                  1809716 [98.0%]
  data collected               Thu, 14 Sep 2017 14:47:15

The file however is there:
~ # ls -l /dev/gpt/rootfs
crw-r-----  1 root  operator  0x56 Sep  6 11:47 /dev/gpt/rootfs

Could this be a configuration import/export problem as in https://github.com/opnsense/plugins/issues/243?
OPNsense version strings:
OPNsense 17.7.2-amd64
FreeBSD 11.0-RELEASE-p12
LibreSSL 2.5.5

Hi woi,
We recently talked about this here, it seems to be a spurious log error in monit:
https://forum.opnsense.org/index.php?topic=5358.msg24789#msg24789
Reporting it upstream would probably be the best course of action.
Cheers,
Franco

What is upstream in this case: FreeBSD or Monit Project?

monit, looks like it tries to dispatch a command that freebsd doesn't support or dispatches it in a way that freebsd doesn't like.

Hi,
I reported it on freebsd
and on tildeshlash
Hopefully there'll be a (positive) reaction...
Maybe someone from here could support/enforce/confirm this? ;)
Cheers,
Stephan

Thanks a lot Stephan :)
I don't have a bitbucket account nor a FreeBSD bugzilla account. I'll wait a few days for an answer. If they don't show up, I'll get my self a login.
But may be you could already add links to the down- and upstream reports for FreeBSD? I guess this could be helpful.

hmm... ;)
well I also just created an account for this - sry I really have no experience regarding this :D
Maybe Franco could lend a helping hand...? ;)
Cheers

Let's give them a couple of days to react. The maintainer of the FreeBSD port is also a tildeslash dev so you will have the right person's attention in any case. Thanks guys.
Franco

Done: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=222312#c1 :-)

Here's our troublemaker:
// Parse the device path like /dev/da0p2 into name:instance -> da:0
static boolean_t _parseDevice(const char *path, Device_T device) {
        const char *base = File_basename(path);
        for (int i = 0; base[i]; i++) {
                if (isdigit(*(base + i))) {
                        strncpy(device->key, base, i < sizeof(device->key) ? i : sizeof(device->key) - 1);
                        device->instance = Str_parseInt(base + i);
                        return true;
                }
        }
        LogError("filesystem statistics error -- cannot parse device '%s'\n", path);
        return false;
}

so it's expecting "ada0", but gets "rootfs" and fails because the digit is missing on the label because it's not a traditional device node ;)

Ok, dunno what else they need this instantiation - probably we could comment out the LogError part for peace in the log? ;)

will be fixed in 5.24.0 according to Martin :)

Jep! :D

Closing this, better to assume this is fixed than not. We can always reopen. Thanks again guys :)

This will land in 17.7.4 on Wednesday.

Nice!


Implement Fred G Composite EAS modeling

composite_eas branch.

the main CompositeShowers class that is intended to be implement (light weight) is the one here
https://github.com/NuSpaceSim/nuSpaceSim/blob/eas_composite/src/nuspacesim/simulation/eas_composite/comp_eas.py
can help with this if needed.

Thanks! I'll bring @jfkrizmanic and @Jorgecvb1 onto the issue too.


Fix inconsistency in pod anti-affinity example.

It looks like a previous version of the anti-affinity code in this example had topologyKey: node. Since it's actually failure-domain.beta.kubernetes.io/zone, the parenthetical is no longer a hypothetical.

Signed it!

/assign @kbhawkey

bump

Page preview:
https://deploy-preview-21137--kubernetes-io-master-staging.netlify.app/docs/concepts/scheduling-eviction/assign-pod-node/#an-example-of-a-pod-that-uses-pod-affinity

/cc @kubernetes/sig-scheduling-pr-reviews

Bump


FoW fails to render on Mac with Firefox

As title says, using Firefox on Mac the scene FoW layer of SimpleFog fails to render and leaves the map unfogged:

This doesn't happen if using Brave browser on Mac.
These are the console errors:

I can also reproduce this issue on macOS with Firefox, though I don't have any errors reported in the console.

Is this still a thing? I seem to be seeing this still


fix incorrect change in CONTRIBUTING.md

I updated this in error - https does not work on this link

Yes, it's  broken


MSSQL Driver Issue - Eloquent save tries to set identity column on update REPOSTED

I've seen that this bug was fixed (https://github.com/laravel/framework/issues/532), but apparently reappeared in Laravel 5, because I just got that error when switched my database engine from MySQL to SQL Server.
This is error message that I get when I try to update model with Eloquent:
SQLSTATE[42000]: [Microsoft][SQL Server Native Client 11.0][SQL Server]Cannot update identity column 'id'.
Example code:
$m = new ModelName;

$m->name = 'Test model insert';
$m->save();

$m1 = ModelName::find( $m->id );

if ($m1) {
    $m1->name = 'Test model update';
    $m1->save();  // Error occured here.
}

Can you please provide more information? Namely the output of $m1->getDirty() and value of $m1->exists before save() is called.
The fix provided by @taylorotwell at https://github.com/laravel/framework/commit/db61c2b44a24702d8c5f94c095ec84a242db4a6d is still there, so maybe it is caused by something different
Also, a stack trace/profiler output would be nice to have if you want to have this fixed ASAP, since MSSQL is kind of a niche DB when it comes to PHP and there is fewer people with it - fewer contributors that could fix this.

Closing due to inactivity.

Am experiencing this issue too with laravel 5.2 @tjodalv Did you manage to get it working?

I ran into this issue this evening, so I figure I'll post the cause and solution here. In my case, the cause was trying to invoke Model::save() from within a Model "created" event handler. The use case was to generate and persist a Model attribute named "secret". Because the "created" event is fired by Model::performInsert() before Model::finishSave() (and subsequently, before Model::syncOriginal()), the auto-incremented id is considered to be a "dirty" attribute. So the call to Model::save() from within my event handler was triggering an UPDATE that included the id attribute. The fix was to switch from triggering my event on "created" events to "creating" events.
Alternatively, I guess I could have continued to use "created", but called Model::syncOriginal() before calling Model::save(). The only problem with that approach would have been that any events farther down the chain might depend on Model::syncOriginal() being called later...?
Anyway, generally speaking, if you're seeing this error from SQL server, the problem is that you're trying to call Model::save() before Model::syncOriginal() and after the model has already been persisted, leading to a dirty state that isn't really dirty.

@collegeman Thank you so much! I just ran into this issue, but for me it was enough to do Model::syncOriginalAttribute('id').

This error stills in Laravel 5.4 and on Laravel 5.5.
Apparently it just dont work with the use of Observers (I tried with saved and created), i got the next error:
Illuminate\Database\QueryException: SQLSTATE[42000]: [Microsoft][ODBC Driver 13 for SQL Server][SQL Server]Cannot update identity column 'paq_idr'. (SQL: update [paquete] set [paq_email] =<EMAIL_ADDRESS>[paq_total_comprados] = 1, [pago_idr] = 28, [fec_ult_act] = 2017-10-19 16:44:55, [fec_alta] = 2017-10-19 16:44:55, [paq_idr] = 34, [paq_codigo] = gtu3xq5d where [paq_idr] = 34)
But if i do it anyelse (No the observer) it just work fine.
I could fix it just calling the creating event and just updating the variable without saving it
public function creating($model) {
    $model->attribute = $value;
}

This is happening to me as well, I just have a created event and I'm trying to save() the mode in the listener and it's giving me Cannot update identity column 'id' exception


Work around some invalid cookies.

Internally, cookies are parsed by Girder using python's built-in http.cookies modules (or a backport of that module in Python 2).  This module is conformant to RFC specifications on cookies.  Some non-conformant processes can set cookies that do not parse with this module.  Specifically, in the field we've see cookies like "KEY=part1 part2" with a space in their value.  When the Python module finds particular types of invalid cookies, it refuses to parse any cookies.  This prevents Girder from working as expected.
This fix allows spaces to be in the cookie values and works around the immediate problem.  I think this shouldn't cause any risk, and will allow Girder to work in situations where it would otherwise fail.

We specifically saw this problem in the field where the Digital Slide Archive is being served from a subdomain where somewhere else in that domain the user was using an Oracle PeopleSoft application.  The Oracle webpage sets invalid cookies, which, since they are in the same domain, get sent to DSA, which then fails to parse them.
The correct solution would be to get offending software to set valid cookies (escaping whitespace, specifically), but as we don't expect that in a timely manner, I've made this work around.

tested


Improve Planning Time

Is your feature request related to a problem or challenge?
Follow on to https://github.com/apache/datafusion/pull/12950
@askalt added a benchmark for planning a benchmark with several aggregates. You can run it (with flamegraph) like
Some profiling
cargo flamegraph --root --bench sql_planner -- --bench physical_select_aggregates_from_200

As can be seen from the flame graphs, a significant amount of the physical planning time is spent on creating ProjectionMapping. However, there are many other interesting places that can probably be made faster too

Describe the solution you'd like
It would be very nice to make this benchmark faster by optimizing these codepaths
Describe alternatives you've considered
Physical Planning could likely be made faster by optimizing EquivalenceProperty calculations. However, since it is a small part of the overall planning time maybe LogicalPlanning / SQLPlanning are better places to start
Additional context
No response

I noticed this case has many aggregations (about 200). When planning an aggregation, the planner wraps a projection for it and creates the corresponding Column for the aggregation expressions. I guess it could be a potential bottleneck 🤔

See the flamegraph, I highlight two parts:

purple part: the planner spends much time building a large hash map for columnizing the expressions.
green part: Creating many columns from a schema that invokes many string clones also takes much time.

I did a simple POC #13018 to avoid building the hash map and reduce the clone.
The benchmark result like as below. all-after is optimized. all-before is main branch.
group                                         all-after                              all-before
-----                                         ---------                              ----------
logical_aggregate_with_join                   1.00  1113.2±38.87µs        ? ?/sec    1.01  1125.6±39.87µs        ? ?/sec
logical_plan_tpcds_all                        1.08   225.2±53.43ms        ? ?/sec    1.00    207.8±3.14ms        ? ?/sec
logical_plan_tpch_all                         1.00     17.5±0.50ms        ? ?/sec    1.04     18.1±1.10ms        ? ?/sec
logical_select_all_from_1000                  1.00      9.7±0.24ms        ? ?/sec    1.00      9.7±0.23ms        ? ?/sec
logical_select_one_from_700                   1.00   799.5±17.64µs        ? ?/sec    1.00   797.5±18.42µs        ? ?/sec
logical_trivial_join_high_numbered_columns    1.00   711.7±18.17µs        ? ?/sec    1.00   714.2±26.44µs        ? ?/sec
logical_trivial_join_low_numbered_columns     1.00   685.4±15.69µs        ? ?/sec    1.01   695.2±74.00µs        ? ?/sec
physical_plan_tpcds_all                       1.00  1683.8±19.94ms        ? ?/sec    1.02  1709.8±26.84ms        ? ?/sec
physical_plan_tpch_all                        1.00    106.3±2.50ms        ? ?/sec    1.01    107.5±2.07ms        ? ?/sec
physical_plan_tpch_q1                         1.00      3.6±0.11ms        ? ?/sec    1.01      3.6±0.10ms        ? ?/sec
physical_plan_tpch_q10                        1.00      5.1±0.14ms        ? ?/sec    1.01      5.2±0.16ms        ? ?/sec
physical_plan_tpch_q11                        1.00      4.5±0.12ms        ? ?/sec    1.00      4.5±0.16ms        ? ?/sec
physical_plan_tpch_q12                        1.00      3.8±0.11ms        ? ?/sec    1.01      3.8±0.19ms        ? ?/sec
physical_plan_tpch_q13                        1.00      2.6±0.13ms        ? ?/sec    1.00      2.6±0.06ms        ? ?/sec
physical_plan_tpch_q14                        1.00      3.1±0.08ms        ? ?/sec    1.00      3.2±0.09ms        ? ?/sec
physical_plan_tpch_q16                        1.00      4.6±0.17ms        ? ?/sec    1.00      4.6±0.12ms        ? ?/sec
physical_plan_tpch_q17                        1.00      4.2±0.11ms        ? ?/sec    1.00      4.2±0.11ms        ? ?/sec
physical_plan_tpch_q18                        1.00      4.8±0.13ms        ? ?/sec    1.01      4.8±0.15ms        ? ?/sec
physical_plan_tpch_q19                        1.00      7.8±0.23ms        ? ?/sec    1.01      7.9±0.28ms        ? ?/sec
physical_plan_tpch_q2                         1.01      9.1±0.53ms        ? ?/sec    1.00      9.0±0.26ms        ? ?/sec
physical_plan_tpch_q20                        1.00      5.6±0.16ms        ? ?/sec    1.00      5.6±0.17ms        ? ?/sec
physical_plan_tpch_q21                        1.00      7.3±0.24ms        ? ?/sec    1.02      7.5±0.33ms        ? ?/sec
physical_plan_tpch_q22                        1.00      4.0±0.11ms        ? ?/sec    1.04      4.1±0.35ms        ? ?/sec
physical_plan_tpch_q3                         1.00      3.7±0.14ms        ? ?/sec    1.01      3.8±0.11ms        ? ?/sec
physical_plan_tpch_q4                         1.00      2.8±0.07ms        ? ?/sec    1.00      2.8±0.06ms        ? ?/sec
physical_plan_tpch_q5                         1.00      5.3±0.15ms        ? ?/sec    1.00      5.3±0.15ms        ? ?/sec
physical_plan_tpch_q6                         1.00  1838.5±47.53µs        ? ?/sec    1.00  1842.0±33.97µs        ? ?/sec
physical_plan_tpch_q7                         1.00      6.9±0.20ms        ? ?/sec    1.01      7.0±0.21ms        ? ?/sec
physical_plan_tpch_q8                         1.00      8.3±0.22ms        ? ?/sec    1.00      8.3±0.25ms        ? ?/sec
physical_plan_tpch_q9                         1.00      6.4±0.19ms        ? ?/sec    1.00      6.3±0.16ms        ? ?/sec
physical_select_aggregates_from_200           1.00     33.7±0.92ms        ? ?/sec    1.17     39.4±0.86ms        ? ?/sec
physical_select_all_from_1000                 1.00     70.3±1.79ms        ? ?/sec    1.01     70.7±1.77ms        ? ?/sec
physical_select_one_from_700                  1.00      4.2±0.11ms        ? ?/sec    1.00      4.2±0.11ms        ? ?/se

Most queries don't be affected but we can see the case physical_select_aggregates_from_200:
group                                         all-after                              all-before
-----                                         ---------                              ----------
physical_select_aggregates_from_200           1.00     33.7±0.92ms        ? ?/sec    1.17     39.4±0.86ms        ? ?/sec

It reduces about 15% execution time.
I think it could be a point that we can improve 🤔

Thank you @goldmedal  -- this is a nice analysis

Here is another idea: https://github.com/apache/datafusion/pull/13018#issuecomment-2435068514

group                                         all-after                              all-before
-----                                         ---------                              ----------
logical_aggregate_with_join                   1.00  1113.2±38.87µs        ? ?/sec    1.01  1125.6±39.87µs        ? ?/sec
logical_plan_tpcds_all                        1.08   225.2±53.43ms        ? ?/sec    1.00    207.8±3.14ms        ? ?/sec
logical_plan_tpch_all                         1.00     17.5±0.50ms        ? ?/sec    1.04     18.1±1.10ms        ? ?/sec
logical_select_all_from_1000                  1.00      9.7±0.24ms        ? ?/sec    1.00      9.7±0.23ms        ? ?/sec
logical_select_one_from_700                   1.00   799.5±17.64µs        ? ?/sec    1.00   797.5±18.42µs        ? ?/sec
logical_trivial_join_high_numbered_columns    1.00   711.7±18.17µs        ? ?/sec    1.00   714.2±26.44µs        ? ?/sec
logical_trivial_join_low_numbered_columns     1.00   685.4±15.69µs        ? ?/sec    1.01   695.2±74.00µs        ? ?/sec

@goldmedal May I ask how you made this benchmark comparison? Seems really nice to select specific queries to benchmark like this.

@goldmedal May I ask how you made this benchmark comparison? Seems really nice to select specific queries to benchmark like this.

I used critcmp to do it. Save the baseline for each test, then you can compare them.

Thank you! Probably will be using it extensively in the future.


Update README.md

Revisions in response to October 2024 meeting

Would love to hear feedback on this revision! @eemeli @sffc

Seems consistent with what we discussed; don't see any major changes.


[bug] notification

Issue Label: [Bug,Feature,Enhancement]
BUG
Description of bug or feature enhancement:
The notification : "Your computer need a break" shows up like 100 times instantly
OS and OS version:
OS X EL CAPITAN 10.11.6
Version of Insomnia Application:
1.2.0
sometimes it's like this :

but sometimes its even worse : my screen become full of notifications in less than 2 seconds, and I need to quit Insomia...

Try updating to 1.3.0 and let me know if that still occurs


[Airbrake] [Production] Network Error

Airbrake error: #8534
Airbrake project: datanator_frontend
Error type: Error
Error message: Network Error
Where: <no information>
Occurred at: Jun 08, 2020 17:08:36 UTC
First seen at: Jun 08, 2020 17:08:36 UTC
Occurrences: 0 (0 since last deploy on <no information>)
Severity: error
URL: http://localhost:3000/stats
File: /PROJECT_ROOT/static/js/0.chunk.js
Backtrace:
/PROJECT_ROOT/static/js/0.chunk.js:109419:in createError
/PROJECT_ROOT/static/js/0.chunk.js:108914:in XMLHttpRequest.handleError

Several of the stats endpoints are failing such as

https://testapi.datanator.info/metabolites/summary/ymdb_conc_count/
https://testapi.datanator.info/metabolites/summary/ecmdb_ref_count

Several of the stats endpoints are failing such as

https://testapi.datanator.info/metabolites/summary/ymdb_conc_count/
https://testapi.datanator.info/metabolites/summary/ecmdb_ref_count

It may be intermittent because I got responses from the endpoints. Regardless, I changed them to return static numbers.


[Docs] Incorrect claim regarding /fakeApi/notifications response body

In  Redux Essentials, Part 6: Performance and Normalizing Data it says:

Our fake API is already sending back the notification entries with isNew and read fields, so we can use those in our code.

The fake API doesn't doesn't actually send back notification entries with those fields. The response body for /fakeApi/notifications has the following shape (taken from my network tab):
[
    {
        "id": "dRlbcYxqEfaHY7--PSjDP",
        "date": "2023-08-23T16:20:17.229Z",
        "message": "is glad we're friends",
        "user": "KEsh5ntGEPkFQuJ2faaD5"
    },
    {
        "id": "V35OKeoD09Bgo3KCAWezR",
        "date": "2023-08-23T16:19:22.420Z",
        "message": "sent you a gift",
        "user": "KEsh5ntGEPkFQuJ2faaD5"
    },
    {
        "id": "uPCHUku1wC4ZtraWz4tgn",
        "date": "2023-08-23T16:23:40.075Z",
        "message": "poked you",
        "user": "KEsh5ntGEPkFQuJ2faaD5"
    }
]

I've checked the network request, the source code in server.js and even searched the entire repo and there is no mention of those fields.

Duplicate of reduxjs/redux-essentials-example-app#20


Update mill-main to 0.11.9

About this PR
📦 Updates com.lihaoyi:mill-main from 0.10.15 to 0.11.9
📜 GitHub Release Notes - Release Notes - Version Diff
Usage
✅ Please merge!
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

⚙ Adjust future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "com.lihaoyi", artifactId = "mill-main" } ]

Or, add this to slow down future updates of this dependency:
dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "com.lihaoyi", artifactId = "mill-main" }
}]

labels: library-update, early-semver-major, semver-spec-minor, commit-count:1

Superseded by https://github.com/alexarchambault/mill-native-image/pull/109


Using ARKit as optional framework and SCNHitTestSearchModeAll

I'm using ARKit as optional framework for my app.
After recent update i've noticed that app started crashing under iOS 10.
dyld: Symbol not found: _SCNHitTestOptionSearchMode

After some research i've found that problem is caused by selector @(SCNHitTestSearchModeAll).
SCNHitTestSearchModeAll is available only in iOS 11. If i comment selector, everything starting ok.
- (NSDictionary *)getSceneObjectsHitResult:(const CGPoint)tapPoint  {
    NSDictionary *options = @{
                              SCNHitTestRootNodeKey: self.localOrigin,
                              SCNHitTestSortResultsKey: @(YES),
                              SCNHitTestOptionSearchMode: @(SCNHitTestSearchModeAll)
                              };
    NSArray<SCNHitTestResult *> *results = [_arView hitTest:tapPoint options:options];
    NSMutableArray * resultsMapped = [self mapHitResultsWithSceneResults:results];
    NSDictionary *result = getSceneObjectHitResult(resultsMapped, tapPoint);
    return result;
}

What's the best way to isolate this selector? and make it used only in iOS11?

you can use this: https://github.com/HippoAR/react-native-arkit/blob/8f872ea40d89e1f4b205a96e12ec93edf0079345/ios/RCTARKit.m#L241
this does a runtime check

I tried

- (NSDictionary *)getSceneObjectsHitResult:(const CGPoint)tapPoint  {
    if (@available(iOS 11.0, *)) {
    NSDictionary *options = @{
                              SCNHitTestRootNodeKey: self.localOrigin,
                              SCNHitTestSortResultsKey: @(YES),
                              SCNHitTestOptionSearchMode: @(SCNHitTestSearchModeAll)
                              };
    NSArray<SCNHitTestResult *> *results = [_arView hitTest:tapPoint options:options];
    NSMutableArray * resultsMapped = [self mapHitResultsWithSceneResults:results];
    NSDictionary *result = getSceneObjectHitResult(resultsMapped, tapPoint);
    return result;
    } else {
        return nil;
    }
}

but no luck, its still crashes at starutp, because once compiled runtime is searching for this symbol.
This code is not executed in iOS10 in any way, that's why run time check doesn't help.
I think we need to replace @(SCNHitTestSearchModeAll) with some dynamic import statement, but i'm not so good at Objective-C to figure out it myself.

it should work with this runtime check. Does xcode give you any warning, if you change the target to ios 10 or so?

@macrozone not sure about warnings, but this change solved issue:
  NSDictionary *options = @{
                              SCNHitTestRootNodeKey: self.localOrigin,
                              SCNHitTestSortResultsKey: @(YES),
                              @"SCNHitTestOptionSearchMode": @(SCNHitTestSearchModeAll)
                              };
    NSArray<SCNHitTestResult *> *results = [_arView hitTest:tapPoint options:options];
    NSMutableArray * resultsMapped = [self mapHitResultsWithSceneResults:results];
    NSDictionary *result = getSceneObjectHitResult(resultsMapped, tapPoint);
    return result;```


CALL_PHONE: UNKNOW & RECORD_AUDIO: UNKNOW when kill app.

My record_audio and Phone permissions will be unknow  when the app is completely killed on Android. @MrHertal

When app is closed and phone is locked - You Connects but no audio from Me
When app is closed and phone is unlocked - You Connects but no audio from Me

CLOSED
it involves setting RNCallkeep.setup atindex.js


Fixed typo and extend .gitignore (for Visual Studio)

:x: Build DaData.ApiClient 1.1.15 failed (commit https://github.com/Xambey/DaData.ApiClient/commit/9c4f71f042 by @)


Automate versioning

🐞 Problem
Making a release involves lots of steps, some of which are manual. One of these steps is the correct version bumping in all the required places. Some of them could be automatic.
Also, when someone installs poliastro from git, it's not clear which version it's using.
🎯 Goal
Make the version bumping, and hence the release process, less error prone, as well as development installations and error reporting.
💡 Possible solutions
Use versioneer.

📋  Steps to solve the problem

Comment below about what you've started working on.
Add, commit, push your changes
Submit a pull request and add this in comments - Addresses #<put issue number here>
Ask for a review in comments section of pull request
Celebrate your contribution to this project 🎉

Notice that development releases work a bit differently. For instance, we wouldn't have a permanent 0.12.dev0 release right after 0.11 anymore, but 0.11+... (referring to the previous version). This kind of makes sense because automatic systems don't really now what goes next.

For using the version in Sphinx, see https://github.com/warner/python-versioneer/issues/185.

versioneer does not work with trunk-based development:
https://github.com/warner/python-versioneer/issues/159
so we can explore other options, like setuptools_scm, but not for this release.

I don't think there are satisfying tools that support trunk-based development at the moment, so we will have to keep manually bumping the version number. Closing.


Potential DDoS on traefik instance (slowloris attack)?

Welcome!

[X] Yes, I've searched similar issues on GitHub and didn't find any.
[X] Yes, I've searched similar issues on the Traefik community forum and didn't find any.

What did you do?
I'm uncertain about the relevance of this observation, but I believe it's worth noting as it may indicate a potential issue.
How to Reproduce
Start traefik:
docker run --rm -p 8080:80 traefik --log.level=debug --certificatesresolvers.http.acme.httpchallenge.entrypoint=http
docker run --rm -p 8080:80 traefik:v3.0 --log.level=debug --certificatesresolvers.http.acme.httpchallenge.entrypoint=http

And then run:
time curl -v localhost:8080/.well-known/acme-challenge/non-existing-token

What did you see instead?
The 404 error code but  in a significant delay of up to approximately 50 seconds.
What version of Traefik are you using?

If applicable, please paste the log output in DEBUG level
No response

Hello @rjsocha,
Thanks for the bug, we were able to reproduce it and will be working on a fix soon!


Update Godot Engine typing

This is weird ... I thought we already added gradual as a valid typing here:
https://github.com/exercism/configlet/pull/842
@ErikSchierboom do I need to update the Configlet action?

The CI uses the latest release of configlet, which is 4.0.0-beta.16 from October 2023, but that predates the PR adding gradual. I think you'll need to wait until the next release of configlet, but I'm not privy to when that might be. Perhaps we can push a beta 17 release sooner than later?

Perhaps we can push a beta 17 release sooner than later?

We'll try and release ASAP

Yup, now it works! Thank you! :)


Initial version

This was the version we created on Monday

Sorry, forked the repo, and the default pull request wanted me to commit our changes back to you, not keep it in our repo...


MCS-1963 Added Support for Windows

Corresponding Python PR: https://github.com/NextCenturyCorporation/MCS/pull/701
See details on the Python PR.

@rartiss55 I expanded the if !UNITY_EDITOR so we don't bother trying to make the socket while running in the Unity Editor. That should prevent the errors from showing up.


Need to implement and Enforce Upgrades/Downgrades based on the Phase

For 1856 some tiles can be upgraded and downgraded:

The Yellow Single-Town Tiles can be Upgraded to Single-City Tiles where Track connects are maintained
The Yellow Single-Town Tiles can be Downgraded to Straight-Through Tiles that maintain the Track connections to the same two sides.
The Yellow Double-Town Tiles can be Upgraded to the Double-City Tiles (14 and 15) that maintain the Track connections

Data has been applied to the 1856 Tile Set XML File.
Code needs to be setup to restrict this only during the allowed Phases.

Applied code to examine the phase the upgrade is allowed in, and -disabling- the Put Down button if not allowed when it is selected to do the upgrade.
The Tile Tray will still highlight the Tile as a "Playable" Tile. and should be fixed to show it in a different color ("state", of something like "playable but not until Phase X or later", with that sort of ToolTip.

Functionality to perform the Downgrounds and upgrades of Single and Double Towns tested and appear to work correctly in 1856


MUMUP-2478 turn of old my.wisc

No longer overrides the back2classicURL and removes the footer url inviting users to go back to MtyUW old

Coverage decreased (-0.03%) to 28.116% when pulling 58e42045777981889faf762b70816ab113356c03 on noGoingBackToOld into f8bdcf29b393c1512cc477521393c166c9746a79 on master.

:+1: seems legit


Incorrect Branch Info for the given IFSCs

BKID0002111:
Shows "Infocity Gandhinagar". Should be "Thaltej Ahmedabad"

PUNB0408100
Shows "Prashant Vihar". Should be "Paschim Vihar"

The details come from the RBI website itself: https://rbidocs.rbi.org.in/rdocs/RTGS/DOCs/RTGEB0815.xlsx (Linked at https://www.rbi.org.in/scripts/FAQView.aspx?Id=65)
Can't do anything here, perhaps reach out to RBI or the banks to get this corrected.


Checksum files are not generated at upload

Checksum files are not generated when uploading to bintray.

+1


chhaajja -- videos pages integration.

Review still in progress, but just to confirm this PR isn't complete? I can't see any mention of auth service urls for login and regsitration

The flake8 errors can be viewed in travis. Currently there are 28 that will need to be fixed

A general comment on the layout: the easiest way to integrate this into molo-gem is to treat gem as one application, instead of having gem and chhaa jaa as two applications under molo-gem repository.
In this case, any models created would be in gem/models.py and all the templates created would be in gem/templates/chhaajaa.


Changed log level from [warn] to [debug] for "over-writing existing variables"

Description
Changed log level from warn to debug for over-writing existing variable '{}' with new value: {} since it's not really a warning and it increases the log size especially when executing performance test where we only want to check for actionable warnings.

Relevant Issues : 1523
Type of change :

[ ] New feature
[ ] Bug fix for existing feature
[x] Code quality improvement
[ ] Addition or Improvement of tests
[ ] Addition or Improvement of documentation

@workwithprashant should have been in develop branch which I missed but just fyi for next time

@ptrthomas Extremely sorry, this was my first time PR on github.com and I am used to PR to master branch at work. I will remember next time.


Fix _obtain_metadata in Profile class

Fixes errors in instaloader.Profile.from_username,  instaloader.Instaloader().check_profile_id where ProfileNotFoundException is raised by KeyError on graphql

Thanks for your Pull Request. What is it for? Does it address any reported bug?

Essentially #297, but keyError "graphql" , ProfilePage list in entry_data key is now an empty list, which raises this keyError

Essentially #297, but keyError "graphql" , ProfilePage list in entry_data key is now a list with an empty dictionary, which raises this keyError

Also fixed 429 errors for me. Instaloader is operational again. Kudos

Thanks for your Pull Request. What is it for? Does it address any reported bug?

Essentially #297, but keyError "graphql" , ProfilePage list in entry_data key is now a list with an empty dictionary, which raises this keyError

That makes no sense, #297 has been closed a year ago and the code does not look like it could fix a KeyError accessing 'rhx_gis'.

@aandergr you're right, I meant similar to #297. I should have created a separate issue for this, as it's very different from #297 as I mentioned before -  "keyError "graphql" , ProfilePage list in entry_data key is now a list with an empty dictionary, which raises this keyError".
Instead I have directly created the pull request to fix the issue, rather than creating/explaining the issue first.

This change also fixes #643 #654 , as it is related to broken _obtain_metadata in Profile

I don't know how many issues will be fixed by this I haven't went through all the issues, I'm able to find more as I go through them #641

#563 as well

This does NOT fix 643 or 654. With pip3 install instaloader, I get this output, and with your pull request, I get this. TLDR, redirected to the login page in both cases.
In both cases the server is just blocked by Instagram:
$ curl https://www.instagram.com/instagram/ -I -X GET
HTTP/2 302
location: https://www.instagram.com/accounts/login/?next=/instagram/
[...]

This block is not relieved by waiting 11 minutes. It has been in effect since around June 1st.
On my computer at home, which isn't blocked by Instagram, both instaloader from pip3 install instaloader and the branch of this pull request work.

Also fixed 429 errors for me. Instaloader is operational again. Kudos

@tskho — I expect that it fixed those errors because the block expired in the time gap between using the regular release and using this pull request. If you can, please briefly test with this pull request again, and if it is able to download, stop it and test using the regular release, and tell me if the regular release works.

@cloudrac3r Without logging in, both endpoints don't work. With login, __a=1 works for ~500 profiles, and then blocks for a while. Can you try with login?

I'm sorry, I don't wish to create an account. If you have a spare account that you use for testing, and it's safe to share credentials, feel free to direct those to one of my contact addresses and I'll use it to test ASAP.

Many of the here-mentioned supposedly fixed issues are already closed, are not even bugs, or do not seem in any way related to the proposed change. That makes no sense. We cannot introduce a so weakly legitimated change to Instaloader.

@tskho — I expect that it fixed those errors because the block expired in the time gap between using the regular release and using this pull request. If you can, please briefly test with this pull request again, and if it is able to download, stop it and test using the regular release, and tell me if the regular release works.

I cannot comment as to why this pull request works or if code is of acceptable quality but here's what I did:
$ pipenv --three install git+https://github.com/instaloader/instaloader.git#egg=instaloader
$ pipenv run instaloader --login=vtskho vtskho
Loaded session from /home/vitaly/.config/instaloader/session-vtskho.
Logged in as vtskho.
Profile vtskho does not exist.
The most similar profiles are: vtskho, vtskhovrebova, seniora_d_z_l_01, inessashekhovtseva, bykhovtsevakairova.
Trying again anonymously, helps in case you are just blocked.

HTTP redirect from https://www.instagram.com/vtskho/ to https://www.instagram.com/accounts/login/?next=/vtskho/
JSON Query to vtskho/: 429 Too Many Requests: redirected to login [retrying; skip with ^C]
HTTP error code 429 was returned because too many queries occurred in
the last time. Please do not use Instagram in your browser or run
multiple instances of Instaloader in parallel.
The request will be retried in 666 seconds, at 13:21.
GraphQL requests:
  other
    last 10 minutes: 1 requests
    last 11 minutes: 1 requests
    last 15 minutes: 1 requests
    last 20 minutes: 1 requests
    last 30 minutes: 1 requests
    last 60 minutes: 1 requests

and then right after that, using suggested pull request, fresh environment in different directory:
$ pipenv install git+https://github.com/kunwar31/instaloader.git#egg=instaloader
$ pipenv run instaloader --login=vtskho vtskho
Loaded session from /tmp/.instaloader-vitaly/session-vtskho.
Logged in as vtskho.
Stored ID<PHONE_NUMBER> for profile vtskho.
vtskho/2018-11-21_19-35-46_UTC_profile_pic.jpg
Retrieving posts from profile vtskho.
[ 1/20] vtskho/2020-06-03_20-26-23_UTC.jpg [Джунгли зовут!  #lucky to not…] json
[ 2/20] vtskho/2020-02-14_18-47-16_UTC.jpg [Well, hello] json
[ 3/20] vtskho/2020-01-13_11-41-48_UTC.jpg [Тяжелые отношения с Прагой. С…] json
[ 4/20] vtskho/2019-12-20_04-19-23_UTC.jpg [Americans need a little bit o…] json
[ 5/20] vtskho/2019-11-16_19-20-46_UTC.jpg [This tiny piece of paper stil…] json
[ 6/20] ^C
Interrupted by user.

Functionality difference is obvious to me. Perhaps there's something useful in this pull request?

Huh. Thanks for that log.

@tskho Thank you for testing and providing evidence for the proposed functionality


Added Anemia Prediction

Closes #192
Please approve my task.
Description:
I have added Anemia Prediction.

@AmrutaJayanti merged!


feat: Implement a simple stress test.

This change introduces two tests, both work similarly: (1) they run
multiple threads, each thread runs for N seconds, (2) the thread picks
an action, row key, and query size at random, (3) if the action is
"insert" the thread inserts (or updates) the row with the given key, (4)
if the action is "select" the thread reads (or selects) the randomly
selected query size rows starting at the randomly selected key.
The test counts the number of successes and failures and expects less
than 0.1% failures.
This stress test is executed as part of the CI build, but it only runs
each test for 30 seconds. We should run it manually (or nightly) with a
much higher setting, maybe "24 hours" or something similar.
This (I think, but let me know if you disagree) fixes #455

This change is

@devbww PTAL.

@devbww PTAL.


How to get data from frame?

Hi
I try to get data from frame by using a  function:
frameRX.getData();
but I can't get separate bytes from frame like for example byte [3] from frame.
I try something like this:
CAN.read(adresrx, datarx, sizeof(datarx));
but i have error:
`C:\Users\Fuller\Documents\Arduino\can_send\can_send.ino: In function 'void loop()':
C:\Users\Fuller\Documents\Arduino\can_send\can_send.ino:58:45: error: no matching function for call to 'CANController::read(uint16_t&, uint8_t [8], unsigned int)'
CAN.read(adresrx, datarx, sizeof(datarx));
^
In file included from c:\Users\Fuller\Documents\Arduino\libraries\AA_MCP2515\src/AA_MCP2515.h:11:0,
from C:\Users\Fuller\Documents\Arduino\can_send\can_send.ino:12:
c:\Users\Fuller\Documents\Arduino\libraries\AA_MCP2515\src/CANController.h:46:14: note: candidate: CANController::IOResult CANController::read(CANFrame&)
IOResult read(CANFrame &frame);
^~~~
c:\Users\Fuller\Documents\Arduino\libraries\AA_MCP2515\src/CANController.h:46:14: note:   candidate expects 1 argument, 3 provided
exit status 1
Compilation error: no matching function for call to 'CANController::read(uint16_t&, uint8_t [8], unsigned int)'`
Maybe you gives examples how to get bytes from data frame?

Just wanted to update you that I will add reply back here with an example asap.

Access data bytes in received frame.
CANFrame frame;
if (CAN.read(frame) == CANController::IOResult::OK) {
    const uint8_t * data = frame.getData();
    // now you can access each byte in data (data[0], data[1], ...)
}

You can also copy the data from the frame if required.
CANFrame frame;
uint8_t data[8];
if (CAN.read(frame) == CANController::IOResult::OK) {
    frame.getData(data, sizeof(data));
    // now you can access each byte in data (data[0], data[1], ...)
}

I will also add these getData() methods as an additional example.


[Question] How should the library path be set in WSL2?

First of all, thank Mango developers very much.
I am using Mango binary, downloaded from latest release, in WSL2, and it works well when I set the library path to a directory inside Linux file system. But it fails to work if I set it to a path referring to somewhere inside Windows file system, like /mnt/d/comic/ in WSL2, which means D:\comic\ in Windows. Mango did scan some entries once or twice, but not complete. And I did chmod recursively the library path to prevent permission issues.
Here is the log:
Mango - Manga Server and Web Reader. Version 0.27.0

[DEBUG]   2023/03/08 10:36:24 | Current version: 12
[DEBUG]   2023/03/08 10:36:24 | Target version: 12
[DEBUG]   2023/03/08 10:36:24 | Nothing to be done
[DEBUG]   2023/03/08 10:36:24 | Loading cached library from /home/zebartin/mango/library-e.yml.gz
[DEBUG]   2023/03/08 10:36:24 | Library cache loaded
[DEBUG]   2023/03/08 10:36:24 | We are in release mode. Using embedded static files.


Change coordinate system

Hi there, I've been playing around with this plugin. Recently I wrote a json importer that takes a hexmap generated from the application Tiled (https://www.mapeditor.org/) and imports it into godot with some very minor shaders.
My issue lies with how:

Axial coordinates use +x => NE; +y => N;

Tiled, unfortunately, only allows the origin to be in the top-left and +y => S and +x => E.
I created a map that looks like this in Tiled:

Unfortunately when I render it using get_hex_center(Vector2(x,y)) I get the map quite skewed:

I'm wondering if there is a method to adjust the coordinate system to align closer to something like Tiled.
My rendering code on load:
func build_grid(id, y, x):
        # ...
	var coord = HexGrid.get_hex_center(Vector2(x,y))
	tile.translation.x = coord.x
	tile.translation.z = coord.y
	tile.visible = true
	add_child(tile)

So I managed to 'fix' it somewhat by changing this line:
func obj_to_coords(val):
	# Returns suitable cube coordinates for the given object
	# The given object can an be one of:
	# * Vector3 of standard cube coords;
	# * Vector2 of axial coords;
	# * HexCell instance
	# Any other type of value will return null
	#
	# NB that offset coords are NOT supported, as they are
	# indistinguishable from axial coords.
	if typeof(val) == TYPE_VECTOR3:
		return val
	elif typeof(val) == TYPE_VECTOR2:
		return axial_to_cube_coords(val) # <- this line
	elif typeof(val) == TYPE_OBJECT and val.has_method("get_cube_coords"):
		return val.get_cube_coords()
	# Fall through to nothing
	return

to this:
return offset_to_cube_coords(val)
And wrote a func based off the redblog site to get an offset (oddq) coord:
func offset_to_cube_coords(val):
	# Sets position from a Vector2 of offset coordinates
	var x = int(val.x)
	var z = int(val.y) - (x - (x & 1)) / 2
	return Vector3(x, -x-z, z)

This results in the hex grid rendering correctly based off of offset_coords:

Getting close!
Unfortunately, this causes the get_hex_at method to kind of give me skewed results, it seems like it's attempting to give me a hex based on an axial lookup instead of an offset ie, moving the mouse cursor right gives me a hex lower and lower than it should be the further away from 0,0 I am.
The code:
	var plane_coords = self.transform.affine_inverse() * click_position
	plane_coords = Vector2(plane_coords.x, plane_coords.z)
	var hex_pos = HexGrid.get_hex_at(plane_coords).offset_coords

Any ideas?
Any ideas?

Most of the operations internally use the axial coordinate system, hence obj_to_coords(val) interprets val as axial coordinates if it is a Vector2.
Instead of changing this behaviour you can leave everything as is and extend the HexGrid class to allow querying of the hex center when supplying offset coordinates, i.e. add this to HexGrid.gd:
func get_hex_center_from_offset(offset):
	# Returns hex's centre position at the given offset coordinates
	var hex = HexCell.new()
	hex.offset_coords = offset
	return hex_transform * hex.axial_coords

and then your loading code could look something like this:
func build_grid(id, y, x):
        # ...
	var coord = HexGrid.get_hex_center_from_offset(Vector2(x,y))
	tile.translation.x = coord.x
	tile.translation.z = coord.y
	tile.visible = true
	add_child(tile)