Some display issues

https://docs.microsoft.com/en-us/windows-server/administration/windows-commands/diskcomp
Applies To: Windows Server 2016, Windows Server 2012 R2, Windows Server 2012 Compares the contents of two floppy disks. If used without parameters, diskcomp uses the current drive to compare both disks.

For examples of how to use this command, see Examples.

Should  display
Applies To: Windows Server 2016, Windows Server 2012 R2, Windows Server 2012

Compares the contents of two floppy disks. If used without parameters, diskcomp uses the current drive to compare both disks.For examples of how to use this command, see Examples.

https://docs.microsoft.com/en-us/windows-server/administration/windows-commands/chglogon
chglogon title display issus

fixed in  5679223 and 1af43cc


Bower support

Would be awesome if you would make it easier installing the script with bower. Thanks anyhow!

:+1:

added bower support. :thumbsup:

Awesome!


[BUG] Autoswitch to existing tab when previewing a link If Hover Edit plugin is active

Hi czottmann,
Thanks for making such a handy plugin. I've noticed an issue with mononote when used alongside the Hover Editor plugin. When both are active, previewing a link will automatically lead to a switch to an existing tab.

Thanks, @yan42685, I'll look into it! Good report, by the way, appreciate the effort you made 🙏🏼

@yan42685 The fix will be part of the upcoming v1.1, due soon!

Thank you for your great work on Mononote, which makes this plugin better! My apologies for the delayed response. I wanted to ensure that the new version of my plugin, Clever Search, was more refined before sharing it with you, as I didn't want to disappoint you despite it still being in the early stages. Clever Search has now launched its 0.1 version, supporting whole-library search. If you're interested, feel free to check it out!

Here is the link: https://github.com/yan42685/obsidian-clever-search


Do not add the suffix "Delegate" to a delegate as per https://docs.mi…

…crosoft.com/en-us/dotnet/standard/design-guidelines/names-of-classes-structs-and-interfaces#names-of-common-types
Summary
Fixed an issue I reported some time ago where the example delegate code doesn't follow naming convention for delegate classes. I didn't try to add "Callback" / "EventHandler" suffixes to all the example delegate types, but I did fix the one instance where the word "Delegate" was added as a suffix to a delegate type.
Fixes #12706

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: Jonathan727 sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: Jonathan727 sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.


possibility of customizing fonts in Adobe Spectrum

📝 Feedback

Dear Adobe Spectrum Team,
👋 I hope this message finds you well. I am writing to inquire about the possibility of customizing fonts in Adobe Spectrum.
I have been attempting to incorporate the OpenDyslexic typography into my project but have not yet found a clear solution. Despite trying various methods, including using Tailwind CSS and importing the font directly or using a custom theme provider, I have been unsuccessful.
Therefore, I would greatly appreciate any information or guidance you could provide on customizing fonts in Adobe Spectrum.
Thank you for your time and consideration, and I look forward to hearing back from you soon.
Best regards,
💻 Code Sample
import { defaultTheme } from "@adobe/react-spectrum";

const customTheme = {
  ...defaultTheme,
  fonts: {
    ...defaultTheme.fonts,
    sans: '"OpenDyslexic", sans-serif',
  },
  fontFamilies: {
    ...defaultTheme.fontFamilies,
    OpenDyslexic:
      "url('./fonts/open-dyslexic/OpenDyslexic-Regular.otf') format('opentype')",
  },
};

export { customTheme };

🌍 Your Environment

React  && Vite && Vitest
Tailwind CSS

Mind providing a codesandbox or a minimal reproduction? If you find that you want more freedom to customize the look of the React Spectrum components, you can check out React Aria Components too

Closing stale issue. I don't think we'll be adding support for customizing fonts in RSP since we implement the Spectrum design system. I think using React Aria Components like Daniel mentioned above would be a better fit for something like this.

There's a couple other issues that have come through in the past about customizing fonts, have a look through those as well. I think some of the suggestions were setting the font-face name in the CSS attribute to the same name as the Adobe fonts, so it'd just pick up your font instead.


Setup

Updates to make it more convenient to directly run hsds app.

The unix socket tests and docker tests will work with the new build. Besides the ADMIN_USER -> ADMIN_USERNAME change in the README, LGTM.

yes, no sure how the nargs got in there.
I've checked in a fix on master.


Approximating the Speed of an Object and its Distance using OpenCV in Python

Article checklist
Attention
Our Peer Reviewer and Content Moderator teams do NOT provide any revisions services. All revisions and edits should be completed on your own forked repo (as to not take up room in the queue) in order for our team to review them all in a timely manner.
ANY ARTICLE SUBMITTED WITH GLARING ERRORS WILL BE IMMEDIATELY CLOSED.

As a rule of thumb - please be sure to only submit articles (pull requests) that are fully polished and ready to be published. Be sure to go through our resources documents for extra and 3rd party (vetted) resources to help improve overall technical writing.

Pre-submission checks

Please ensure that you have only one open topic suggestion (issue) + in-review article (linked pull request) at a time. This will ensure that we complete the review process in a timely manner from inception to publishing

If you have not already, please go over our Resources Page for more tips and tricks on how to improve your overall technical writing so reviews are swifter, increase the chance of a payout and provide more value to our readers.

For first-time contributors and for more details on our submission guidelines, see our Contributing Guidelines.

Formatting and structure checks

[x] Have you used the correct folder and file structure? - see Contribution Guidelines

[x] Is your article properly formatted in Markdown? - see Github Markdown guide

[x] Have you used our preferred heading structure? - H3 (###) and up

[x] Does your article follow any of the suggested structure formats? - see example formats

[x] Is your article over 750 words? - Tool: Wordcounter.net

[x] Is the article you are submitting an in-depth and unique article? Does it go beyond what is in the official docs and what is covered in other blog sites. See these articles as examples.

[x] Does your article provide enough value and detail about your topic? - Articles should be clear, accurate, and fully explained.

[x] Can your article be understood by beginners? - Assume the audience is smart but has no prior exposure to the common terminology in your article.

[x] Have you included a hero image that is 600x400 pixels, under 300KB in size, and have the copyright to use it? - Tools: Pixlr Image Editor for resizing and Unsplash for Creative Commons images

Grammar & plagiarism checks

[x] Have you spellchecked and grammar checked your article? - Tools: Write&Improve - ProWritingAid - Grammarly
[x] Please place your article through a 3rd party plagiarism checker. We suggest using Quetext, this tool is free and has a daily limit. We typically accept articles with 10% or less.
[x] Have you checked your article for readability? - Tool: Hemmingway
[x] Have you added sources for quotes and images that aren't yours?

Technical checks

[x] Are your code snippets properly formatted for syntax highlighting - see Syntax guide
[x] Have you checked your code runs correctly and you've highlighted all necessary dependencies for installation?
[x] Are the software programs and packages you're highlighting in your article up to date, using current versions and not deprecated?

This closes #6316

@Dawe-7
Submitted a PR.

Hello @GeekEdmund,
Upon running your article through our 3rd party plagiarism checker it seemed to raise a few flags and the % was higher than we typically accept.
Please see attached PDF - and revisit the article to ensure we are contributing wholly unique and original content.
Be sure to see our resources page to see more info on plagiarism and what is considered as such.
Approximating the Speed of an Object and its Distance using OpenCV in Python #6630 Copyleaks Report.pdf

@lalith1403 fixed the requested changes

The article needs a lot of work. There are several grammatical, and formatting issues. Please go through the contribution guidelines, and make the necessary changes. I will be closing this PR for now to make room for other PRs.

@lalith1403 Done with the changes as requested.

@lalith1403
@section-engineering-education/content-moderator-team
Is anyone available to do a review on this?
If any other edits are required we can go ahead any close it to allow the proper time to proofread it.

There still appears to be several grammar errors and unreadable sentences. Please correct them @GeekEdmund . Thanks

Feel free to work on these idling and let us now once done. Thank you.

@Lalith I'm done with the changes, so I was requesting for reopening of the PR  to push the final changes so that we can complete the final review.

@WanjaMIKE Completed the requested changes, you may now proceed with your final review.

I am unable to view this PR on my computer. I seem to have an issue on my end.

jumping on this one

The article needs a lot of work. There are several grammatical, and formatting issues. Please go through the contribution guidelines, and make the necessary changes. I will be closing this PR for now to make room for other PRs.

At this point (your first closure), the article should have been re-submitted as a new PR for a duplicate label.
It seems it was closed and re-opened a few times. (and edits were made by both reviewers)
The % was pretty also high, which is a cause for concern that this topic may not be completely original.
This seems like a potential candidate for permanent closure.

@lalith1403
@WanjaMIKE
@GeekEdmund
This article was still not ready to be published. Any article of this caliber should be closed asap.


Bug: Cannot send to internet identifier with subdomain

I tried sending to<EMAIL_ADDRESS>(that's where I run satsdress), which worked fine with lntxbot, but gave me an "invalid lnurl" error with LNbits. Sending to<EMAIL_ADDRESS>(my manual implementation) was no problem.

I love this address thing but have not had time to investigate.
If anyone out there can implement into LNbits properly please do! (as I understand it we're only partly implemented)

This is fixed with #312, which also takes care of another issue.


Delete selected row doesn't remove the row from selectedRecords

Describe the bug
When I delete a selected row from state the row itself is removed in the table but the selected records is not updated and therefore the row after my deleted row exist in  selected rows
because I count the selected rows I found that it doesn't refresh
How can I remove the selected id from the list of selected rows?

Removing a record from the selectedRecords array falls within your responsibility as a developer.
You manage the selectedRecords array in the same manner you're managing the records state. For instance, here's a one-liner:
setSelectedRecords((selectedRecords) => selectedRecords.filter(({ id }) => id !== idToRemove));

If you're wondering why the records aren't removed automatically, that's because - for instance, when you're using pagination (in which case records only contains the active page), you might want to keep track of a selection spanning multiple pages, so you can batch an operation.
Think of how Gmail works: you can select some emails on a page, then move to the next page and select more emails, then delete all the emails you have selected, regardless of whether they are currently visible or not.
Does this answer your question?

Will close this for now.
Please feel free to reopen - or better yet - start a new discussion in Q&A if the above doesn't answer your question.
Thanks!


[BEAM-8499] Enable Dataflow workers to use private IPs

This adds a --no-use-public-ips flag to the Go SDK, modeled on the Python SDK one.

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[x] Choose reviewer(s) and mention them in a comment (R: @username).
[x] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

R: @lostluck

Do you know when will this be released?


Publish incrementals

Cannot really test since I lack write access, so Jenkinsfile will not be run from this PR. Needs someone with write access to file a copy as a draft PR.

$ mvn clean install -Dset.changelist -DskipTests -Denvironment=test -Ppackage-app,package-vanilla,jacoco && (cd ~/.m2/repository/io/jenkins/jenkinsfile-runner; find * -type f -name '*-rc*' | xargs du -h | sort -n)
…
1.3M	jenkinsfile-runner/1.0-beta-30-rc743.a1a459dc53b2/jenkinsfile-runner-1.0-beta-30-rc743.a1a459dc53b2.jar
1.3M	jenkinsfile-runner/1.0-beta-30-rc743.a1a459dc53b2/jenkinsfile-runner-1.0-beta-30-rc743.a1a459dc53b2.zip
4.0K	jenkinsfile-runner/1.0-beta-30-rc743.a1a459dc53b2/jenkinsfile-runner-1.0-beta-30-rc743.a1a459dc53b2-sources.jar
4.0K	packaging-parent-pom-resources/1.0-beta-30-rc743.a1a459dc53b2/packaging-parent-pom-resources-1.0-beta-30-rc743.a1a459dc53b2-assembly-zip-config.xml
4.0K	packaging-parent-pom-resources/1.0-beta-30-rc743.a1a459dc53b2/packaging-parent-pom-resources-1.0-beta-30-rc743.a1a459dc53b2-jenkins-properties.xml
4.0K	payload-dependencies/1.0-beta-30-rc743.a1a459dc53b2/payload-dependencies-1.0-beta-30-rc743.a1a459dc53b2-sources.jar
4.0K	vanilla-package/1.0-beta-30-rc743.a1a459dc53b2/vanilla-package-1.0-beta-30-rc743.a1a459dc53b2.jar
8.0K	bootstrap/1.0-beta-30-rc743.a1a459dc53b2/bootstrap-1.0-beta-30-rc743.a1a459dc53b2.pom
8.0K	jenkinsfile-runner/1.0-beta-30-rc743.a1a459dc53b2/jenkinsfile-runner-1.0-beta-30-rc743.a1a459dc53b2.pom
8.0K	packaging-parent-pom/1.0-beta-30-rc743.a1a459dc53b2/packaging-parent-pom-1.0-beta-30-rc743.a1a459dc53b2.pom
8.0K	packaging-parent-pom-resources/1.0-beta-30-rc743.a1a459dc53b2/packaging-parent-pom-resources-1.0-beta-30-rc743.a1a459dc53b2.pom
8.0K	packaging-parent-pom-slim/1.0-beta-30-rc743.a1a459dc53b2/packaging-parent-pom-slim-1.0-beta-30-rc743.a1a459dc53b2.pom
8.0K	parent/1.0-beta-30-rc743.a1a459dc53b2/parent-1.0-beta-30-rc743.a1a459dc53b2.pom
8.0K	payload/1.0-beta-30-rc743.a1a459dc53b2/payload-1.0-beta-30-rc743.a1a459dc53b2.pom
8.0K	payload-dependencies/1.0-beta-30-rc743.a1a459dc53b2/payload-dependencies-1.0-beta-30-rc743.a1a459dc53b2.jar
8.0K	payload-dependencies/1.0-beta-30-rc743.a1a459dc53b2/payload-dependencies-1.0-beta-30-rc743.a1a459dc53b2.pom
8.0K	setup/1.0-beta-30-rc743.a1a459dc53b2/setup-1.0-beta-30-rc743.a1a459dc53b2.pom
8.0K	vanilla-package/1.0-beta-30-rc743.a1a459dc53b2/vanilla-package-1.0-beta-30-rc743.a1a459dc53b2.pom
12K	payload/1.0-beta-30-rc743.a1a459dc53b2/payload-1.0-beta-30-rc743.a1a459dc53b2-sources.jar
20K	bootstrap/1.0-beta-30-rc743.a1a459dc53b2/bootstrap-1.0-beta-30-rc743.a1a459dc53b2-sources.jar
20K	payload/1.0-beta-30-rc743.a1a459dc53b2/payload-1.0-beta-30-rc743.a1a459dc53b2.jar
20K	payload-dependencies/1.0-beta-30-rc743.a1a459dc53b2/payload-dependencies-1.0-beta-30-rc743.a1a459dc53b2.hpi
24K	payload-dependencies/1.0-beta-30-rc743.a1a459dc53b2/payload-dependencies-1.0-beta-30-rc743.a1a459dc53b2-javadoc.jar
32K	bootstrap/1.0-beta-30-rc743.a1a459dc53b2/bootstrap-1.0-beta-30-rc743.a1a459dc53b2.jar
32K	setup/1.0-beta-30-rc743.a1a459dc53b2/setup-1.0-beta-30-rc743.a1a459dc53b2-sources.jar
44K	setup/1.0-beta-30-rc743.a1a459dc53b2/setup-1.0-beta-30-rc743.a1a459dc53b2.jar
60K	payload/1.0-beta-30-rc743.a1a459dc53b2/payload-1.0-beta-30-rc743.a1a459dc53b2-javadoc.jar
124K	bootstrap/1.0-beta-30-rc743.a1a459dc53b2/bootstrap-1.0-beta-30-rc743.a1a459dc53b2-javadoc.jar
124K	setup/1.0-beta-30-rc743.a1a459dc53b2/setup-1.0-beta-30-rc743.a1a459dc53b2-javadoc.jar

#450 suggests that jenkinsfile-runner-*.jar is not useful? But it is still being published e.g. as https://repo.jenkins-ci.org/releases/io/jenkins/jenkinsfile-runner/jenkinsfile-runner/1.0-beta-29/jenkinsfile-runner-1.0-beta-29.jar so this does not make sense. If no one is consuming it, the POM should be adjusted to not install or deploy it.

CC @daniel-beck @olblak @dduportal @MarkEWaite  Infra feedback is needed

@oleg-nenashev my understanding is that the artifactory hosting concerns were more related to download traffic than use of disc space.
Are the large artifacts likely to be downloaded from artifactory or will they be available from the Jenkins mirrors (as in https://get.jenkins.io/ )?  If only from artifactory, is there a way that we could distribute them through the Jenkins mirrors ?

If only from artifactory, is there a way that we could distribute them through the Jenkins mirrors ?

There is support for artifacts on GitHub Releases already in this repo. I would not move them to the mirrors unless there is a strong use-cases for that. Technically we could just stop big artifacts from being published on Artifactory at all. The builds are reproducible, and GitHub releases should be good enough as source of truth for distribution ZIPs

What is this 100Mb überjar?
I know of a project consuming three artifacts from here, via Artifactory:

jenkinsfile-runner.zip
payload.jar
setup.jar

which could presumably benefit from being able to pick up incremental releases of at least those. As you can see from https://github.com/jenkinsci/jenkinsfile-runner/pull/525#issuecomment-861067960, the only artifact of significant size not being consumed is jenkinsfile-runner.jar. As in https://github.com/jenkinsci/jenkinsfile-runner/pull/525#issuecomment-861077832, if there are no Maven consumers of that JAR, we could simply omit it from deployment (both incremental and regular releases).

Whatever. Let's merge and see. If there is high disk usage, we will adjust

Needs someone with write access to file a copy as a draft PR.

Looks like it worked after merge: https://repo.jenkins-ci.org/incrementals/io/jenkins/jenkinsfile-runner/jenkinsfile-runner/1.0-beta-30-rc748.178e51f2df47/


Suggestion: minetest

You are kidding us

@kapouer In which category this should go? The list includes only whole games, not engines.

Added in 43b8180.


Fix Balances contract commands

Currently transfer(dest, amount) resets the balance of dest. This is apparently not "transferring".
In order to create a transferable contract, we need:

Fix the semantic of transfer(dest, amount):

Check balance[origin] >= amount
balance[origin] -= amount
balance[dest] += amount

Initialize the contract with some balance. Let's issue some tokens to the built in account Alice ("d43593c715fdd31c61141abd04a99fd6822c8558854ccde39a5684e7a56da27d")

As you said, the transfer execution is a transferring behavior, not a transferring result.
I think there's  something wrong with that.
At the first of pruntime starts running, there is no accounts in pruntime or  all the accounts are zero.  You should give a result value of transferring to pruntime, not giving a transferring behavior to let the pruntime to calculate the result value.


Azure PowerShell task: Need information on how to get variables

There is zero documentation on how to actually get variables when passing files through to Azure PowerShell.  None, anywhere, and doesn't seem possible to do.  https://docs.microsoft.com/en-us/azure/devops/pipelines/tasks/deploy/azure-powershell?view=azure-devops
No amount of $env "$()" or uppercase, lowercase, mixedcase or anything works anywhere at all.

@craigmpeters -- Craig, thank you for your feedback. We are looking into it.
Meanwhile, here are a couple of options where you might consider asking your question:

Azure DevOps on Stack Overflow
Azure DevOps Support Bot

I have worked this out - for this it needs to go into the paramaters and then to use the parameter in the powershell script.
So lets say you have something called AzurePrincipalKey you add a paramater for AzurePrincipalKey=$(AzurePrincipalKey) and then in the script have:
Param(
[string]$AzurePrincipalKey
)


How to get total size of a docker image by docker API properly?

I want to get total size of a docker image by docker API, such as GET /v2/<name>/manifests/<reference> which is described here docker spec
I got a list of layers with size, such as this example, I add up these sizes but got a number which is smaller than docker images command show, as i know the docker registry stores image layers as gzipped tar files, so these sizes are smaller than the size which is reported in the docker deamon.
How to get the total image size properly by docker API?

You probably should file this issue to docker.. but when less busy we have plan to look into this too.

@reasonerjt OK, should i close this issue now?

let's leave it open, so in case anyone knows the answer he can update this issue..


[DL Edition] T037: E3 equivariant GNNs

Talktorial review
This PR template is suitable for adding new talktorials and extending existing talktorials (if you are doing the latter, answer bullet points w.r.t. your extensions).
Details

Talktorial ID: 037
Title: An introduction to E(3)-invariant graph neural networks
Original authors: Joschka Groß
Reviewer(s): XXX
Date of review: DD-MM-YYYY

Content

One line summary: XXX
Potential labels or categories (e.g. machine learning, small molecules, online APIs): XXX
Time it took to execute (approx.):
[x] I have used the talktorial template and followed the content and formatting suggestions there
[ x] Packages must be open-sourced and should be installable from conda-forge. If you are adding new packages to the TeachOpenCADD environment, please check if already installed packages can perform the same functionality and if not leave a sentence explaining why the new addition is needed. If the new package is not on conda-forge, please list them and their intended usage here.

torch (conda pytorch, channel `pytorch): deep learning library with tensors
torch_geometric (conda pyg, channel pyg): torch extentsions that cotnains QM9 dataset and GNN utils
torch_scatter (installed automatically as dependency of torch_geometric`, I also use it explicitly)

[x] Data must be publicly available, preferably accessible via a webserver or downloadable via a URL. Please list the data resources that you use and how to access them:

QM9 PytorchGeometric version: https://pytorch-geometric.readthedocs.io/en/latest/modules/datasets.html#torch_geometric.datasets.QM9

Content style

[x] Talktorial includes cross-references to other talktorials if applicable
[x] The table of contents reflects the talktorial story-line; order of #, ##, ### headers is correct
[x] URLs are linked with meaningful words, instead of pasting the URL directly or linking words like here.
[x] I have spell-checked the notebook
[x] Images have enough resolution to be rendered with quality, without being too heavy.
[x] All figures have a description
[x] Markdown cell content is still in-line with code cell output (whenever results are discussed)
[x] I have checked that cell outputs are not incredibly long (this applies also to DataFrames)
[ ] Formatting looks correctly on the Sphinx render (bold, italics, figure placing)

Code style

[x] Variable and function names follow snake case rules (e.g. a_variable_name vs aVariableName)
[x] Spacing follows PEP8 (run Black on the code cells if needed)
[ ] Code line are under 99 characters each (run black-nb -l 99)
[x] Comments are useful and well placed
[x] There are no unpythonic idioms like for i in range(len(list)) (see slides)
[x] All 3rd party dependencies are listed at the top of the notebook
[ ] I have marked all code cell with output referenced in markdown cells with the label # NBVAL_CHECK_OUTPUT
[ ] I have identified potential candidates for a code refactor / useful functions
[x] All import ... lines are at the top (practice part) cell, ordered by standard library / 3rd party packages / our own (teachopencadd.*)
[x] I have used absolute paths instead of relative pathsHERE = Path(_dh[-1])
DATA = HERE / "data"

Website
We present our talktorials on our TeachOpenCADD website (https://projects.volkamerlab.org/teachopencadd/), so we have to check as well if the Jupyter notebook renders nicely there.

[ ] If this PR adds a new talktorial, please follow these steps:

[ ] Add your talktorial to the complete list of talktorials here (at the end).
[ ] Add your talktorial to one or multiple of the collections here. Or propose a new collection section in your PR.
[ ] Add your talktorial's nblink file by running python generate_nblinks.py from within the directory teachopencadd/docs/talktorials.
[ ] Please complile the website following the instructions here.

[ ] Check the rendering of the talktorial of this PR.
[ ] Is your talktorial listed in the talktorial list?
[ ] Is your talktorial listed in the talktorial collections?

[ ] Add a picture for your talktorial in the collection view by following these instructions.

Your figure images/2d_rotation_equivariance.png is  missing.


remove variables from pacpmw calculation which are already in fcsht calc

Description

Closes #1874
Checklist
I confirm that I have completed the following checks:

[ ] I have justified any large differences in the regression tests caused by this pull request in the comments.
[ ] I have added new tests where appropriate for the changes I have made.
[ ] If I have had to change any existing unit or integration tests, I have justified this change in the pull request comments.
[ ] If I have made documentation changes, I have checked they render correctly.
[ ] I have added documentation for my change, if appropriate.

The stellarator regression test has not converged.  Any ideas?

Minor changes to two variables as expected.  No change in the power balance - the chnages only affect the power that is used to calculate the costs.


onUp() sometimes are not being triggered

onUp() sometimes are not being triggered. If this is beyond what the library can do at least onDrag should be giving 0 offset for us to identify if the stick is at the center. Reason? I need to have a command that send of "stop" but the only way to do it using bugstick is through onUp, so giving the ability to give 0 offset would be great :D

This is not beyond what the library should be able to do 😄
Could you please clarify in what situations you notice that onUp() is not being called? Can you reliably reproduce it, and if so, share a series of steps? Do you use the lock() feature of Bugstick?

False alarm! xD I just made series of experiment as well as confirmation to this issue. onUp() actually working fine the issue is on another mater. Please closed this issue and sorry for the inconvenience. Great library! I might be adding another issue for possible enhancements as well thanks again!

False alarm! xD I just made series of experiment as well as confirmation to this issue. onUp() actually working fine the issue is on another mater. Please closed this issue and sorry for the inconvenience. Great library! I might be adding another issue for possible enhancements as well thanks again!


when using cat, connectbot crash

When I use connectbot and use cat on /etc/services, connectbot got crash. But for ~/.profile it is working.
Connectbot 1.9.9

I didin't check in 1.9.9 but in 1.9.10-1-e3e2a89-main I tried on my VPS cat /etc/services many times and it works without crash.


workspace/tests request does not return swift-testing tests

Also symbol information is probably not enough information for each test. The following additional information would be useful

source: Did test come from xctest or swift-testing
label: swift-testing tests can have a label, displaying this in the UI would be good.

swift-testing tests can have a whole bunch more data attached to them but I'm not sure at this time if it is needed. It can always be added at a later date.

Tracked in Apple’s issue tracker as rdar://124058880


Duping with portable tank

Issue description
You can dupe any item using a portable tank that hold any amount of liquid in it.
Steps to reproduce

Fill a portable tank with a liquid
Put an item into it
Quit the GUI
Break the portable tank
Place the portable tank back, the item is still in it but as also been dropped

Minecraft version
1.21 (Latest)
Fabric loader version
0.16.0
Fabric API version
0.100.8
Oritech version
0.8.0
Other relevant versions
No response
If a (crash)log is relevant for this issue, link it here: (It's almost always relevant)
No response

Thanks for reporting this issue, I completely missed it when implementing the custom tank block drops. I just fixed it with this commit: https://github.com/Rearth/Oritech/commit/8ce278bfa3708ab43d0b98b998ba9fd595f2d201
The bugfix will be included in the next release (0.8.1)


Missing popup notification after uploading upgrade package is done (success/ failure)

Environment info

Version: 2.0.0-bed837c
Deployment: **AZURE **
Customer: NAME

Actual behavior

While uploading and testing an upgrade version we allow the user to continue working, assuming this might take a while but we do not notify the user when the first step is done.

Expected behavior

A popup notification should appear when the first step is done.

Steps to reproduce

Go to version upgrade > upload a file > leave upgrade page

Screenshots or Logs or other output that would be helpful

No longer relevant due to OVA deployment support removal. Upgrade will be done via k8s (either initiated by the user or not, it will still be an unmanaged path)


double-spend when closing channel

Connect to https://faucet.lightning.community/
Open channel from https://faucet.lightning.community/
Close channel using lncli close
Double spent transaction occurs:
https://live.blockcypher.com/btc-testnet/tx/0ccfa67b4f2a4b36f100ee4b9cee5e090c0e31ea4315de012c894a2fb7ccf1f2/

Can you elaborate on point 4? It's possible that if your fees differ, then both parties my broadcast a distinct closing transaction. This isn't an issue though, as we'll watch for all possible closes and reconcile our database state once one of them actually confirms.

Looks like the outputs of both transactions are P2WKH, so this means they somehow disagreed during close negotiation?

Even if they were p2wkh it's no issue (or should be) due to the way we watch for every signed state. Even if both sides broadcasted diff closing transactions, only one will get into the chain. That's the one that we should use to mark the channel closed using.

Yeah, but cooperative close means that they were able to agree on some final fee, right? Haven't looked at that logic in a while, but two different cooperative close transactions means that they both signed twice, which sounds buggy.

Could be same as #538

Fixed in #1017.


Install ASP.NET Core runtime

This will make sure the build script includes the ASP.NET Core runtime
when running on local .NET. The effect of this is that our test projects
and apps will 'roll forward' unto the newest runtime without us
hardcoding it.

Where is AspNetCoreRuntimeVersion defined? I don't see it in the code.

OK, I think I missed something then, am I supposed to define it and set it to the version I want? I assumed this was defined somewhere magic like https://github.com/aspnet/Blazor/blob/master/build/repo.props#L33

No magic. In fact, it looks like MicrosoftNETCoreApp20PackageVersion and MicrosoftNETCoreApp21PackageVersion are undefined too. Because MSBuild is awesome, I think it's just not adding a new item because those variables are empty

mmmmk. So those probably belong in dependencies. props then


docs: use webp image on tailwindplay

Summary
Update an image extension at chat bubble avatar on tailwindplay.
Description
The present tailwindplay uses jpg image at avatar.
However, jpg image doesn't load anymore.
Then I recreate new tailwindplay link (https://play.tailwindcss.com/wWndQ9FxeZ) which has webp image.
It shows a women face correctly.

Thanks!


ts-migration: convert some routes from js to ts

Issue Ticket Number:-

add issue ticket number here e.g #923

Description:
Change some files into typescript
Is Under Feature Flag

[ ] Yes
[x] No

Database changes

[ ] Yes
[x] No

Breaking changes (If your feature is breaking/missing something please mention pending tickets)

[ ] Yes
[x] No

Is Development Tested?

[x] Yes
[ ] No

Tested in staging?

[x] Yes
[ ] No

Add relevant Screenshot below ( e.g test coverage etc. )

Please add the issue number in description


Support Attribute Selector

Per discussion in #4 and continued discussion here. This PR adds support for querying react properties, and not html attributes. The following syntax works:

component.find('input[type="text"][value="1"])
component.find('label[htmlFor="button"]')
component.find('div[data-wrapper]')

wow, thanks for all this work!  I'm going to try and take a closer look tonight after we finish up this hackathon. Looks great!

Hey @blainekasten ,
I hate to give you more work to do... but i was hoping you could change this back to the original [prop] syntax. Jordan and I discussed the pros/cons of each syntax and we agreed that handling just [prop] and getting rid of {prop} syntax.
To recap, the syntax we would like is:

[prop="foo"] gets nodes with prop="foo"
[foo] gets nodes that have a foo prop defined
there will be no special mapping between props and html attributes such as htmlFor => for.

No worries. I want to see this land. I can do that. I agree with that API also honestly. Glad to have it sorted out. I'll finish it tomorrow :+1:

So. This is done. But coverage keeps getting worse as I add more tests... Any tips @lelandrichardson ?

wow, good work on the tests! Istanbul is becoming a bit of a pain since we are using babel... I need to figure out how to get istanbul working with the original source lines so that it makes more sense. just ignore for now if the percentage goes down.
I'm curious of a couple of things:

What's the behavior of numeric proptypes? Seems like something that we could also use the string selector for (or not?). Either way, the expectations should be tested.

const wrapper = shallow(
<Foo bar={2} />
);
expect(wrapper.find('[bar="2"]')).to.have.length(1);

Does the above pass?  (I'm not necessarily saying it should)

Also, what is the expected behavior for falsy but present props?

does
 match [foo]?
does <Foo visible={false} /> match [visible]?

Ahh good catch. I didn't think about non-string values.. I'll have to work on this a bit more.
Empty string currently works fine:

 matches [foo] or [foo=""]
<Foo visible={false} /> DOES match [visible], not sure if that's the right call or not?
I guess in the situation of non string prop values, I would think dropping the quotes would be the way to do it.
So <Foo visible={false} /> could match [visible=false] but not [visible="false"]

@ljharb what do you think? How should empty values be handled?  should [foo] match
?
I'm trying to think pragmatically, and it seems to me that if i look for [visible], I do NOT want <Foo visible={false} /> to match...

If we want to stick to querySelector syntax, a query of [foo] only looks for a node that has that attribute, irrelevant of the value.
Some new code that I have you could do this.
[visible=false] if you want the non-visible things.

That's a very good question - since this is a string-based API, it will already only work for a subset of prop values (and won't work for Symbol props). I think we can just draw a line and say that for this limited form of findWhere/filterWhere, [foo] should not match falsy values, and [foo=${bar}] should mean that a bar of a non-string value should never match anything.

Alternatively, I'd be totally fine with saying that [foo] matches any non-undefined value - and that might be more in line with people's expectations.

I think I like [foo] matching non-undefined-values.
That just leaves the non-string-based values...  in this case we could say that things have to be === to each other...  (so [foo="2"] would NOT match <Foo foo={2} />).

agreed. I think non-string values is for xWhere to handle.

Let's also add two tests describing its behavior for <Foo ref="foo" /> and <Foo key={1} /> since those are not treated the same as other props in react...

Feeling a little lost by the string of comments. Can you drop me a few examples of what tests you'd want to pass/fail?

I don't think adding support for ref makes much sense since React is moving away from the string ref api. It's almost guaranteed that in the coming months/year that react won't support a string for ref and only accept a fn.

Agreed. I don't want to support it... I just want to add a test that asserts that it's not supported so we know that that doesn't change at some point

Here's a list of JSX => selector => match/ not match:
Without values:

<Foo foo="bar" /> => [foo] => match
<Foo foo={null} /> => [foo] => match
<Foo foo={2} /> => [foo] => match
<Foo /> => [foo] => not match
<Foo foo={undefined} /> => [foo] => not match

With values:

<Foo foo="bar" /> => [foo="bar"] => match
<Foo foo="foo" /> => [foo="bar"] => not match
<Foo foo="2" /> => [foo="2"] => match
<Foo foo={2} /> => [foo="2"] => not match

Then, special react props: (I'm not strong feeling on these, but I think we should document how it behaves right now)

<Foo ref="foo" /> => [ref] => not match
<Foo ref="foo" /> => [ref="foo"] => not match
<Foo key="foo" /> => [key] => not match
<Foo key="foo" /> => [key="foo"] => not match

I'm really excited to see support for attribute/prop selectors, but it feels like this is coding to the wrong abstraction. Under the hood JSX is javascript and this solution seems right if this was html.
Instead of a CSS selector why not supply an object of props to search for?
<Foo foo="bar" /> => expect(wrapper.find({foo:"bar"})) => match
<Foo foo="bar" blah="sheep" /> => expect(wrapper.find({foo:"bar"})) => match?

@hartzis That's a great idea! I would love to see that syntax opened as a PR. I don't think this string-based selector syntax collides with anything object-based though, so the two should be able to work in harmony.

So you only want string based matching? You wouldn't want something like this?
<Foo foo={2} /> => [foo="2"] => not match
<Foo foo={2} /> => [foo=2] => match
I think it'd be nice to support non-string lookups. I understand this deviates from qSA but that API is dealing with DOM where everything is stringified, but react props are not. So I think this could work for this situation. What do you think?

I could be convinced for the string-based API to go with either a) only allow string values, or b) allow any non-symbol primitive (ie, booleans, null, undefined, numbers, strings with explicit quotes). What I wouldn't want is [foo=3] to match a string "3", nor [foo="3"] to match a number 3.
@lelandrichardson, any thoughts?

cc @lelandrichardson for continued discussion.

I agree with @ljharb that a 2 with quotes shouldn't match a numerical 2. I'd be open to letting other primitives match the non-quoted literal versions of them (ie, [foo=3] or [foo=true]). @hartzis proposed solution of .find({foo: 3}) and .find({foo: true}) is probably better suited for these things, and extends beyond primitives... BUT, you can't do something like input.foo-bar[boo="bam"] with an API like that. Though once you are getting that complicated of a selector, the .findWhere() API is likely your best choice.
For this PR, if we don't want to spend time implementing the primitives [foo=3], we can leave it undefined behavior and throw an unsupported selector error similar to what we do now for the attribute selectors, and decide whether we want to support it later.  It's up to you...  I will merge this in either way.

I have already pulled off the non-quoted version once, so I'll just rollback to that point and make sure it's all working. I'll get to it this afternoon.
Thanks for the feedback.

@blainekasten thanks for bearing with us for this whole conversation!

No prob! It's a pretty big api addition. Always gotta make sure it serves the right direction.

@lelandrichardson This is ready to go now! Thanks

@blainekasten one last request: can you squash your commits before I merge?

@blainekasten a rebase would be preferred over a merge

Yeah. I'm trying to rebase. I always struggle through the squashing process...

sadly github doesn't make it easy with a rebase button. on your branch, git fetch source; git rebase source/master where source is the git remote for this repo should do it tho?

Yeah.. it is too hard. I am not following exactly for that suggestion.
I tried git rebase -i HEAD~n and squashed the previous commits.. but it didn't squash them haha

Alternatively, you could make a brand new branch locally, recreate it manually by checking things out or cherry picking from the original branch, and then, force push the new local branch to the original remote branch, which will update the PR.

on your branch, figure out the total # of commits n that you have that you want to squash.  Run git rebase -i HEAD~n. In the menu, leave the first commit as pick <sha> <message>. For all of the following commits, change it to squash <sha> <message>.  Submit that screen (:wq if you're using vim), then in the next screen submit that screen as well, unless you want to change the commit message, which you can do.
After that, run git push -f

Are you guys happy enough with 2 squashedish commits? haha. I can fix it if you want. I just get so worried when I do this that I'll break something.

Oh boom. I got this down now. Alright, I think we're good to :)

This should be ready to go now. Thanks

hey @blainekasten it looks like it has some merge conflicts. Some stuff got merged in that must be conflicting. Can you rebase once more and resolve whatever conflicts show up?  Thanks!

Alright. Should be good again. Hopefully it can get merged before something else conflicts again :)

Awesome work. Thank you!

Thanks for merging! No problem. I'm excited about this project. Thanks for
starting it
On Sun, Jan 10, 2016 at 12:17 AM Leland Richardson<EMAIL_ADDRESS>wrote:

Awesome work. Thank you!
—
Reply to this email directly or view it on GitHub
https://github.com/airbnb/enzyme/pull/70#issuecomment-170317432.


side nav alignment - left instead of right

Updated the side nav so that it sits on the left instead of right.

will also have to update this in chameleon if we proceed with this change


[BugFix] Fixup typo of pipeline_dop adaptive adjusting

Fix typo introduced by https://github.com/StarRocks/starrocks/pull/31920
What type of PR is this:

[x] BugFix
[ ] Feature
[ ] Enhancement
[ ] Refactor
[ ] UT
[ ] Doc
[ ] Tool

Does this PR entail a change in behavior?

[x] Yes, this PR will result in a change in behavior.
[ ] No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

[ ] Interface/UI changes: syntax, type conversion, expression evaluation, display information
[ ] Parameter changes: default values, similar parameters but with different default values
[ ] Policy changes: use new policy to replace old one, functionality automatically enabled
[ ] Feature removed
[ ] Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

[ ] I have added test cases for my bug fix or my new feature
[ ] This pr needs user documentation (for new or modified features or behaviors)

[ ] I have added documentation for my new feature or new function

Bugfix cherry-pick branch check:

[ ] I have checked the version labels which the pr will be auto-backported to the target branch

[ ] 3.2
[ ] 3.1
[ ] 3.0
[ ] 2.5

[FE Incremental Coverage Report]
:disappointed: fail : 0 / 1 (00.00%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
com/starrocks/qe/scheduler/slot/LogicalSlot.java
0
1
00.00%
[166]

[BE Incremental Coverage Report]
:heart_eyes: pass : 0 / 0 (0%)


Crash when adding an existing location

High priority for v1 as it makes the app completely unusable.

Fixed in 73997314f976014657b9b032daf068f1a339fff8.


test: [M3-8197,M3-8150] - Cypress test for refactored events and placement group

Description 📝

Clicking "View all events" navigates to Events page at /events.
Test to confirm flow when selecting existing Placement Group.

Changes  🔄

Add assertion to confirm clicking "View all events" navigates to Events page at /events.
Add a new test to confirm flow when selecting existing Placement Group.

How to test 🧪
yarn cy:run -s "cypress/e2e/core/notificationsAndEvents/events.spec.ts"
yarn cy:run -s "cypress/e2e/core/placementGroups/create-linode-with-placement-groups.spec.ts"

As an Author I have considered 🤔
Check all that apply

[ ] 👀 Doing a self review
[ ] ❔ Our contribution guidelines
[ ] 🤏 Splitting feature into small PRs
[ ] ➕ Adding a changeset
[ ] 🧪 Providing/Improving test coverage
[ ] 🔐 Removing all sensitive information from the code and PR description
[ ] 🚩 Using a feature flag to protect the release
[ ] 👣 Providing comprehensive reproduction steps
[ ] 📑 Providing or updating our documentation
[ ] 🕛 Scheduling a pair reviewing session
[ ] 📱 Providing mobile support
[ ] ♿  Providing accessibility support

Volumn failure has been fixed in https://github.com/linode/manager/pull/10728


Doc: how do we import it?

imports are not mentioned in the documentation.
tried to import 'python-cli-ui' which seems strange!

The 'ui' prefix in virtually all the code samples should give you a clue, no ?
But yeah, we should document this somewhere :)

yes. but it seems strange for newcomers that the project name is not what you import.
if ui is available on pip it would make sense to use it.
cause anyway if you have python-cli-ui installed you cannot use the ui module for something else.

also... a little unrelated, but the documentation link (the most useful information) is at the bottom, can we move it to the top?

will do


Merge develop to master

Coverage remained the same at 100.0% when pulling 44a465888ce165ce5ef6f9dec6a259ae0c1ff5a3 on develop into de00a7c73ebb883ce79892f5e76583d757ab672c on master.

Coverage remained the same at 100.0% when pulling 0945526c4c73515dd2d9f4168e553770d4917765 on develop into de00a7c73ebb883ce79892f5e76583d757ab672c on master.


Images missing from pdf

The profile image is missing when saving to pdf in all templates.
Image works with print to pdf but other layout features brake then

Same for me. The Saved PDF is missing the profile image.
Platform info:
Installation: Docker container (host OS Debian Buster).
Browser: Safari 14.0.2 (MacOS Big Sur)

Closing this in favor of Reactive Resume v3 release.
If you continue to face this issue, please raise a new one and I'll have a look at it as soon as I can.
In the meantime, if you are able to, please consider donating to keep supporting the project: https://www.buymeacoffee.com/AmruthPillai :)
Thank you!


The server is not working

Hi,
The servers in your example are not working. Do you have different sites that I can use for testing? Thanks.
https://sb-fhir-stu3.smarthealthit.org/smartstu3/data
or
https://sb-fhir-dstu2.smarthealthit.org/smartdstu2/open

Apologies for the very slow response. I have not had a chance to work on this for a while. You should be able to find new sandbox information at https://dev.smarthealthit.org/#fhir-servers https://dev.smarthealthit.org/#fhir-servers.
-Rick

On May 1, 2019, at 11:49 AM, WU CHEN SU<EMAIL_ADDRESS>wrote:
Hi,
The servers in your example are not working. Do you have different sites that I can use for testing? Thanks.
https://sb-fhir-stu3.smarthealthit.org/smartstu3/data https://sb-fhir-stu3.smarthealthit.org/smartstu3/data
or
https://sb-fhir-dstu2.smarthealthit.org/smartdstu2/open https://sb-fhir-dstu2.smarthealthit.org/smartdstu2/open
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub https://github.com/Arborian/fhirstorm/issues/1, or mute the thread https://github.com/notifications/unsubscribe-auth/AABQBLZROU6KVEPJGT3NTADPTG3YDANCNFSM4HJULTWA.


Support CDAP SDK 3.4.3 installation

This adds the checksum for the CDAP 3.4.3 SDK artifact.

👍 lgtm


Added the spo listitem record declare command solving #769

Added the 'spo listitem record declare' command solving #769

Coverage decreased (-0.2%) to 99.775% when pulling 9be07695aea4d420de6d090e57d7d88ba724bc2d on arnieraju:feature/769-listitem-record-declare into 001ed310d74a45c557ae4cc5556aebdb00aa6d95 on pnp:master.

Thank you! I'll review it shortly!

Hey @arnieraju, would you mind resubmitting this PR to the dev branch? All PRs should go to dev as mentioned in https://github.com/pnp/office365-cli/blob/master/docs/guides/submitting-pr.md. Sorry I haven't caught it earlier.

Arrgh, I can't believe I missed that too.  Of course, I'll shoot that through now.

No problem and thank you for resubmitting it!


SAK-29118 add copyrightAlert to Content entity broker feed

Beth, please give us an hour or two to make sure the travis-ci build is correct and for any comments before merging!

There are a couple of things wrong with this.

It should be a one liner but there are formatting changes meaning the whole block is removed and readded.
The field is set directly, not via the setter, so the line of code for the setter is not used. In fact, it would be good if the other params are set correctly too via setters, ie item.isVisible and item.isHidden.


find symbol is slower than sublime text

VSCode Version: 1.5.2
OS Version: win10

Steps to Reproduce:

install python extension
open the same file in the same project in vscode and sublime text,
ctl+shift+o in vscode, and  ctl+r in sublime text,  vscode list all the symbol is slower than sublime text almost in 10 times.  and vscode can not list symbol in tree structure like sublime text doing.

vscode has debug tools is better than sublime text, sublime text is faster than vscode.
any improvement ?

Please file this in the appropriate extension repository. https://github.com/DonJayamanne/pythonVSCode/issues


Where should I put React Native UI Framework?

I found this Magnus UI - React Native UI Framework.
Magnus UI is the ultimate UI framework that helps you in building consistent user interfaces effortlessly in react native.
Link: https://magnus-ui.com/
Should I put it inside the React UI section? sorry if I mention this in the Issues.

Hey, can You can create new react native section and put it there?

Yeah, with pleasure ! Thank you for the permission 💪


Load systems selectively by maintaining a system-connections table

This introduces two main changes:

Allow :requires and :depends-on to differ from each other: this way, a connection system can now list another system or connection system as its dependency. Perhaps, this shouldn't actually be necessary.
Load the connected systems only for the "concerned" system, and in a particular order

This should fix https://github.com/lisp-maintainers/asdf-system-connections/issues/3
Before merging, we should atleast check that this does not break any system in quicklisp.
(ql:who-depends-on "asdf-system-connections")
;=> ("cl-containers" "cl-graph" "cl-variates" "dense-arrays" "extensible-compound-types-cl" "metatilities" "tinaa")

Even without this PR, in a clean portacle environment, with updated quicklisp dist:

cl-variates and cl-graph cannot be loaded simultaneously, both due to a symbol conflict as well as because of a dependency of the connection system on cl-mathstats.

quicklisp is actually using the cl-variates from gitlab.

07186aa leads to stackoverflow / control stack exhaustion while loading cl-graph

b9efa55 allows all to be loaded individually.
I will be ignoring extensible-compound-types-cl since it will be replaced by peltadot.
However, there are a large number of systems in quicklisp that depend directly or indirectly on cl-containers. Thus, if anything breaks, this can pose an issue to a large number of users.

The contents of this PR now live on a separate fork, and they should play nice with the existing asdf-system-connections and any existing systems that depend on it.


Can't find the Autoregressive module

Trying to run this but have not been able to download and install the Autoregressive module.
I have not been able to find where this module is on Github.

^I am also having this issue


Please increase google-oauth due to security issue

We use snyk tool to report security issues in our team.
This tools reported us that lib google-oauth-client used by google-cloud-bigquery  has vulnerability. Full snyk info:
Overview
com.google.oauth-client:google-oauth-client is a powerful and easy-to-use Java library for the OAuth 1.0a and OAuth 2.0 authorization standards.

Affected versions of this package are vulnerable to Improper Authorization. PKCE support is not implemented in accordance with the RFC for OAuth 2.0 for Native Apps. Without the use of PKCE, the authorization code returned by an authorization server is not enough to guarantee that the client that issued the initial authorization request is the one that will be authorized. An attacker is able to obtain the authorization code using a malicious app on the client-side and use it to gain authorization to the protected resource.

Remediation
Upgrade com.google.oauth-client:google-oauth-client to version 1.31.0 or higher.

Could you please use newer version of this lib?

cc/ @shollyman

This should have been fixed awhile ago.


hashcat: 4.2.1 -> 5.0.0

This introduces a dependency on xxHash. Unfortunately, hashcat's
build system wants to rebuild xxHash from the source code located
in <hashcat source root>/deps/git/xxHash, a Git submodule whose
contents are not included in the source tarball we currently
download.
This could be fixed by either using a recursive git clone instead
a tarball download, or patching the build files to use an existing
installation of xxHash (i.e. the one already provided by Nix). I
believe the latter is preferable since it avoids the situation in
which the xxHash version used by hashcat is different to the xxHash
version used by all other Nix packages.
Fortunately, this situation has been greatly improved since
release 5.0.0; the next release of hashcat should drop usage of
git submodules and provide better support for using existing
installations of dependencies.
Motivation for this change
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[x] Determined the impact on package closure size (by running nix path-info -S before and after)

Increase by 607 kB

[x] Fits CONTRIBUTING.md.

@GrahamcOfBorg build hashcat

@GrahamcOfBorg build hashcat

No attempt on x86_64-darwin (full log)
The following builds were skipped because they don't evaluate on x86_64-darwin: hashcat
Partial log (click to expand)

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

Success on aarch64-linux (full log)
Attempted: hashcat
Partial log (click to expand)
install -m 755 hashcat                                   /nix/store/q30wzh78c76bffy8pkykhncr72vx2glj-hashcat-5.0.0/bin/
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/q30wzh78c76bffy8pkykhncr72vx2glj-hashcat-5.0.0
shrinking /nix/store/q30wzh78c76bffy8pkykhncr72vx2glj-hashcat-5.0.0/bin/hashcat
strip is /nix/store/p9akxn2sfy4wkhqdqa3li97pc6jaz3r1-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/q30wzh78c76bffy8pkykhncr72vx2glj-hashcat-5.0.0/bin
patching script interpreter paths in /nix/store/q30wzh78c76bffy8pkykhncr72vx2glj-hashcat-5.0.0
/nix/store/q30wzh78c76bffy8pkykhncr72vx2glj-hashcat-5.0.0/share/doc/hashcat/extra/tab_completion/install: interpreter directive changed from "/bin/bash" to "/nix/store/dsyc1z7ck08ga7l0b1jcxx35wj69qcii-bash-4.4-p23/bin/bash"
checking for references to /build in /nix/store/q30wzh78c76bffy8pkykhncr72vx2glj-hashcat-5.0.0...
/nix/store/q30wzh78c76bffy8pkykhncr72vx2glj-hashcat-5.0.0

Success on x86_64-linux (full log)
Attempted: hashcat
Partial log (click to expand)
install -m 755 hashcat                                   /nix/store/blmkjlzzj6vy54q0dmsazc2hbr9ms34y-hashcat-5.0.0/bin/
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/blmkjlzzj6vy54q0dmsazc2hbr9ms34y-hashcat-5.0.0
shrinking /nix/store/blmkjlzzj6vy54q0dmsazc2hbr9ms34y-hashcat-5.0.0/bin/hashcat
strip is /nix/store/vcc4svb8gy29g4pam2zja6llkbcwsyiq-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/blmkjlzzj6vy54q0dmsazc2hbr9ms34y-hashcat-5.0.0/bin
patching script interpreter paths in /nix/store/blmkjlzzj6vy54q0dmsazc2hbr9ms34y-hashcat-5.0.0
/nix/store/blmkjlzzj6vy54q0dmsazc2hbr9ms34y-hashcat-5.0.0/share/doc/hashcat/extra/tab_completion/install: interpreter directive changed from "/bin/bash" to "/nix/store/r47p5pzx52m3n34vdgqpk5rvqgm0m24m-bash-4.4-p23/bin/bash"
checking for references to /build in /nix/store/blmkjlzzj6vy54q0dmsazc2hbr9ms34y-hashcat-5.0.0...
/nix/store/blmkjlzzj6vy54q0dmsazc2hbr9ms34y-hashcat-5.0.0

you can add yourself to the list for ofborg: https://github.com/NixOS/ofborg/pull/254


Project V.I.D - MonsterAudio&Templates - v1.5.3

ADDED CRAZY AUDIO PACKS AND USED CESAR'S AI ON THE BOT TEMPLATES.
Guys we have a game that low key works rn.

Have a new pull req version for this, cancelling this pull req.e


Fix prepend and postpend navbar links

Left clicking on the prepended or postpended external links in the navbar was not working because of this line excluding links with the external class. Adding external class to both link tags fixed the issue.

👍  thanks, you saved me some time with this

fixes #26


KYLIN-4577 Throws UnrecognizedPropertyException when server self discovery enables

Problem:
When server self discovery enables, it throws UnrecognizedPropertyException on some env, for example: cdh 5.7.
Root cause:
The json of ServiceInstance is incompatible, related to the issue of curator:  https://issues.apache.org/jira/browse/CURATOR-394
Proposed changes
Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue.
Types of changes
What types of changes does your code introduce to Kylin?
Put an x in the boxes that apply

[x] Bugfix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation Update (if none of the other choices apply)

Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

[x] I have create an issue on Kylin's jira, and have described the bug/feature there in detail
[x] Commit messages in my PR start with the related jira ID, like "KYLIN-0000 Make Kylin project open-source"
[x] Compiling and unit tests pass locally with my changes
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] If this change need a document change, I will prepare another pr against the document branch
[ ] Any dependent changes have been merged

Further comments
If this is a relatively large or complex change, kick off the discussion at user@kylin or dev@kylin by explaining why you chose the solution you did and what alternatives you considered, etc...

Pull Request Test Coverage Report for Build 6034

13 of 13 (100.0%)  changed or added relevant lines in 1 file are covered.
5 unchanged lines in 1 file lost coverage.
Overall coverage increased (+0.01%) to 27.979%

Files with Coverage Reduction
New Missed Lines
%

core-metrics/src/main/java/org/apache/kylin/metrics/lib/impl/MetricsSystem.java
5
60.0%

Totals

Change from base Build 6029:
0.01%

Covered Lines:
26110

Relevant Lines:
93319

💛  - Coveralls

LGTM

LGTM


addition of fypp

I added the generation of the subroutine check_overtake_ by fypp for a wide range of integer and real in the module mod_moa_take.
to generate moa_take.f90:
fypp take.fypp take.f90

The file common.fypp defines the different kinds. they need to be adapted for your case.

I modified completely gamma.f90 to gamma.fypp
Based on this I think you can try to finish take.fypp ;) Let me know if there are some issues.


Rewriting the User Guide

Hi all,
This is a first stab at unifying the user guide for effect estimation and gcm sub-package. This is an extremely early draft and will require a lot of iterations before we can put it into the right place. I'm already publishing it here to avoid going in the wrong direction and wasting time. To simplify iterations, I put everything into one big markdown. Once we're happy with the result, we'd move it into proper rst structure.
The basic idea behind this guide is that we identify commonalities and differences between effect estimation and gcm. The obvious common part is the causal graph usually defined using NetworkX in one way or another. This is covered in the Modeling Causal Relations sections.
After explaining the basic concepts of how systems can be modeled as graphs, we directly go to a task-based structure, i.e. we lead the reader through the difference parts of DoWhy by letting them focus on the specific causal task they want to perform.
Having this as markdown allows us to comment on very specific portions of the document.
For a better overview of how the sections are structured, see this TOC:

Agreed.  This structure is really great.  I like how it allows us to easily expand as we add new tasks.
Do you think we can we make the need for refutations/sensitivity analyses more prominent in the structure?

Hey @amit-sharma @emrekiciman, thanks for the positive feedback. I'm glad it's going in the right direction (realizing that this is still only the very beginning).

Do you think we can we make the need for refutations/sensitivity analyses more prominent in the structure?

@emrekiciman Definitely. It's actually one part where I would need help. If you or anyone else wants to give that a stab, that would be very helpful.

Since I expect this effort to cover many concepts across the library, I suggest that this PR can have the basic structure and stubs for each of the sections/pages. And then further PR can add details to the specific sections. What do you think?

@amit-sharma  Yes, that's also how I thought we could do this, now that we agree it's going in the right direction. I will initiate that effort.

This can now be viewed in a rendered version on https://petergtz.github.io/dowhy/main/user_guide/index.html
@emrekiciman @amit-sharma @bloebp This is the rough structure. I believe there are still a lot of rough edges and gaps. I will need your help here. I recommend to read it from cover to cover once to see where those edges and gaps are. Feel free to push changes to this branch directly, so we can review them together.

What about the miscellaneous sections, such as "draw samples" or "customized models". These are only (if at all) referenced in the text, but do not appear in the index list?

As a high-level comment, the only major section I may add is "Validating causal estimates". So the structure will look like,

Modeling causal relations
Performing causal tasks
Validating causal estimates
Miscellaneous

@amit-sharma Yes, that could make sense. I've been discussing this also back and forth with Patrick on how to integrate validation into the overall structure, because I haven't been happy with the current proposal. Your suggestion could be the solution 👍. Please discuss these changes with @bloebp, as it's my last day today. I'll be on leave starting next week.

@bloebp @emrekiciman I'm done with my edits on the user guide. I'm highlighting some todos that can be useful as you take a pass over the user guide.
Stub pages (need to add details)

learning causal structure is a stub. Needs to be expanded with dodiscover and causal-learn examples
Each page on identification strategy. Need to add conceptual details.
Almost all estimator pages are stubs (e.g., GLM page). Need to add details.
Direct and indirect effects page needs more details
Outlier attribution, unit change attribution and feature attribution is empty
Soft interventions and Predicting the value of outcomes as input change. is empty
Refuters description are stubs. Need to expand.

Content to add/Merge

Need to add details on how to interpret the output of identify_effect and estimate_effect methods
Merge text of user_guide/causal_tasks/estimating_causal_effects/effect_estimation_with_estimators.html with the user guide
on the CATE/CACE page, need to explain how the effect modifiers are set in the graph
Need to add png images to the simulation-based sensitivity analysis page

Example notebooks

Add image thumbnails for all notebooks

Compiling issues

two notebook do not show up in docs, need to execute and add to docs

refuting graph structure--notebook link does not work

Hey Amit,
I did some further modifications:

Docker container should work now with the newer poetry version (simply increased the version number)
Added user guide for anomaly attribution (changed naming from "Outlier Attributions" -> "Anomaly Attribution")
Added user guide for feature relevance (changed naming from "Feature Attribution" -> "Feature Relevance")
Various smaller changes and fixed across the user guide, mostly fixing links and smaller edits.
Removed the "Soft intervention" section and only kept one which already has version of a "soft intervention" (depends on the actual definition), where we have a "conditional intervention".

Few remarks/open questions from my side:

On the getting started page, the links below "Effect inference" and "Graphical causal model-based inference" are broken/outdated. Not sure what the plan here is to fix it?
With respect to the previous point, there is still a "gcm_based_inference/introduction.rst". Was this left on purpose (e.g. to have a more compact overview from the getting started page) or just an left over that can be deleted?
The follow up pages of the "Identifying causal effect" page (e.g. Backdoor) do not have a "next"-button somehow at the bottom. Do you know why?
The "Modeling causal mechanisms in addition to structure" section is the most crucial one introducing the GCM module, but it is not that prominent. It actually fits in the narrative of "Modeling Causal Relations", but seems a bit lost as one of many points there. What about we move it to the main level after "Modeling Causal Relations" and rename it to "Modeling Graphical Causal Models (GCMs)" as a compromise?

thanks @bloebp I have made those changes.

On the getting started page, the links below "Effect inference" and "Graphical causal model-based inference" are broken/outdated. Not sure what the plan here is to fix it?
Fixed

With respect to the previous point, there is still a "gcm_based_inference/introduction.rst". Was this left on purpose (e.g. to have a more compact overview from the getting started page) or just an left over that can be deleted?
I think most of the info has been moved to other sections. I still kept the page in case we missed any info for a future update.

The follow up pages of the "Identifying causal effect" page (e.g. Backdoor) do not have a "next"-button somehow at the bottom. Do you know why?
Not sure, I do see the Next button. Can you try with this latest version?

The "Modeling causal mechanisms in addition to structure" section is the most crucial one introducing the GCM module, but it is not that prominent. It actually fits in the narrative of "Modeling Causal Relations", but seems a bit lost as one of many points there. What about we move it to the main level after "Modeling Causal Relations" and rename it to "Modeling Graphical Causal Models (GCMs)" as a compromise?
Done!

Thanks, I did another round:

Fixed some broken links and references
Re-organized some guides (e.g., removed Miscellaneous and rather moved it as sub-sections to the GCM part)
I have revised the citation sections, both in the readme and the documentation, emphasizing to reference our both papers, given that things are quite merged together now and will likely be even more so in the future. Let me know what you think about this.

Something I noticed:

Some note books are not referenced according to the build warnings. The notebooks are: owhy_optimize_backdoor_example.ipynb, graph_conditional_independence_refuter.ipynb,  nb_casestudies_index.rst, dowhy_causal_prediction_demo.ipynb, tutorial-causalinference-machinelearning-using-dowhy-econml.ipynb
The "helloworld.rst" also doesn't seem to be referenced. Maybe we can remove this? I think it is already part of getting started?
As far as I see, the do-sampler has no reference in the documentation. Does it make sense to add it to the effect estimation section?
There is a warning: docs/source/example_notebooks/nb_index.rst:186: WARNING: unknown document: 'dowhy_ranking_methods'. Not sure what dowhy_ranking_methods is supposed to refer to.

@bloebp the text changes are good, but somehow poetry.lock is also changed with your commit and is breaking the build. It downgrades econml to 0.13 from 0.14.1. Also changes scikit-learn and versions of other libraries.
Can the poetry change be avoided?

Thanks for checking! I reverted the poetry changes.

Okay, did a final push. This should be ready to merge, assuming that the tests pass.

Included reference to two notebooks. dowhy_optimize_backdoor_example.ipynb, graph_conditional_independence_refuter.ipynb, nb_casestudies_index.rst are redundant now and can be deleted (perhaps later).
Agree, removed hello_world.rst
Good catch! Added do sampler.
Removed the ranking_methods notebook. It has a few build issues, perhaps that is why it is excluded in the conf.py

Looks good to me!
Small point: There is no do_sampler.rst, i.e., it doesn't link to anything (the link also doesn't appear). We can just leave this out for now or just put a link to an example notebook?


Set client-side encryption as the default mode for new emails, events, and files

Publish Date: Tuesday, December 5, 2023
Update Blog Link

@jkaufman-mitre defer to HG as discussed since this deals with client-side encryption.

This update is being deferred to the hardening guide. No changes needed.


feat(chat): auto-select just uploaded files in attach files window (Issue #1325)

Description:
Auto-select just uploaded files in attach files window
Issues:

Issue #1325

UI changes
<Please, provide Screenshots or Figma links>
Checklist:

[x] the pull request name complies with Conventional Commits
[x] the pull request name starts with fix(<scope>):, feat(<scope>):, feature(<scope>):, chore(<scope>):, hotfix(<scope>): or e2e(<scope>):. If contains breaking changes then the pull request name must start with fix(<scope>)!:, feat(<scope>)!:, feature(<scope>)!:, chore(<scope>)!:, hotfix(<scope>)!: or e2e(<scope>)!: where <scope> is name of affected project: chat, chat-e2e, overlay, shared, sandbox-overlay, etc.
[x] the pull request name ends with (Issue #<TICKET_ID>) (comma-separated list of issues)
[x] I confirm that do not share any confidential information like API keys or any other secrets and private URLs

/deploy-review

/deploy-review


[Fix] Allow mixed precision training with SimOTAAssigner

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.
Motivation
Enable 16-bit precision training on YOLOX with the SimOTAAssigner. Fixes #7474.
Modification
Cast the valid_pred_scores variable to float32 dtype in the F.binary_cross_entropy calculation.
Also added a unit test for SimOTAAssigner, though it's not exactly a good one. Wasn't sure how best to test this properly.
BC-breaking (Optional)
Does the modification introduce changes that break the backward-compatibility of the downstream repos?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.
Use cases (Optional)
If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.
Checklist

Pre-commit or other linting tools are used to fix the potential lint issues.
The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
If the modification has potential influence on downstream projects, this PR should be tested with downstream projects, like MMDet or MMCls.
The documentation has been modified accordingly, like docstring or example tutorials.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Please also fix lint issues so that we can merge this PR.


Update metadata client README.md

@johnnyaug sorry for the late review, forgot to submit my comments..


Sonar branches config

Pull Request Test Coverage Report for Build 44

0 of 0 (NaN%) changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build 41:
0.0%

Covered Lines:
62

Relevant Lines:
62

💛  - Coveralls


fix the --proxy-timeout-seconds flag description

Is there an existing issue for this?

[X] I have searched the existing issues

Current Behavior
Reported by @hbagdi as below:

The doc line needs work, I don’t know what Kong Client is (as a user):
flagSet.Float32Var(&c.ProxyTimeoutSeconds, "proxy-timeout-seconds", proxy.DefaultProxyTimeoutSeconds,
"Define the rate (in seconds) in which the timeout configuration will be applied to the Kong client.",

Expected Behavior
No response
Steps To Reproduce
No response
Kong Ingress Controller version
2.0.0-beta.2

Kubernetes version
n/a

Anything else?
No response

@tharun208 did you still want to work on this one?

@shaneutt can you give me the updated description help text?. So, that i can come up with a patch..

@tharun208 perhaps:
The number of seconds before requests to the Kong Gateway will time out.


Update github.com/gogo/protobuf to v1.3.2

Fix for CVE-2021-3121
Signed-off-by: Simon Pasquier<EMAIL_ADDRESS>

The frontend CI test has recently started to fail everywhere

yes I've noticed too as I was confused why this PR would break anything with the frontend :)

and yes to path release-0.21 first :)

Is what @roidelapluie said in https://github.com/prometheus/prometheus/pull/8446 also true for this PR? In that case, I'd say we shouldn't put it in a bugfix release.

To be honest, I have a hard time assessing how you can exploit the vulnerability and how the new version of the generated code is fundamentally different from what we have today. I'm looking for answers from our security team. Without further information, I agree that we don't have to patch v0.21.0.

Sorry for the screenshot, that was the more pratical I could find

As you can see, some of the code would be generate withot checking that index+skippy < 0.
I guess the change below was moving both checks skippy < 0  and index+skippy < 0 on the same line to avoid copy/paste omissions in the future.

@roidelapluie :bow: it was the missing piece to me, thanks a lot!

Just for the record: The generated code that is actually used in Alertmanager is not affected by CVE-2021-3121. Therefore, we don't need to cut a bugfix release for 0.21.


nsc-nextjs-08-423-add-dark-light-mode

Resolves #423
This PR will add dark and light modes (contrast polarity) to the front end, allowing users to choose their preferred mode.
Note:

The Wrapper Div component hasn't been applied because there is still CSS styling on pages. After implementing MUI we can apply Wrapper Div for consistency layout.
Since we have CSS styling, therefore the background color isn't consistent.
Removed unused SessionProvider.

Reference:
https://stackoverflow.com/questions/78170462/switching-between-system-dark-and-light-mode (similar to current approach)
https://www.davegray.codes/posts/light-dark-mode-nextjs-app-router-tailwind
Result:
Dark mode:

Light mode:

LGTM
Light:

Dark:


Provide default shapes.

Beyond the simple square and rectangle that are currently implemented, additional default shapes could be provided, such as circles, ellipses, rounded rectangles, etc.
Since those are not high in complexity they could just be stored in the shapes array initially, without having to load anything or having to call an explicit method.

Planned list of default shapes:

Square
Rectangle
Circle
Ellipse
Rounded Square
Rounded Rectangle
Star (5)
Bell


killedby is now always an array

This PRs remove some code needed to support plugins with and without support for disableBail.
Since most of the plugins support it now it is no longer necessary.
We keep behavior in jest where we only report the first failing test

@Edgpaez thanks for the work! We're going to merge this in the epic/esm branch (which is the Stryker v6 branch)


server: proxy: pf_context.c: Fix nla crash

Details in commit message

@akallabeth well, do you have any idea where this should be?
these pointers must be set to NULL, otherwise a double free occurs
and the copy is what causing the pointers duplication issue, so i though to reset the pointers to NULL here.

@akallabeth i'll move the set NLA = TRUE to pf_client_pre_connect.

@akallabeth rebased on master and did the change

@kubistika There seems to be some use after free left.
Try a clang scanbuild (just set CC=<path to>/ccc-analyzer before running cmake and build with scan-build -V cmake --build .

@akallabeth would you mind checking the changes?

@akallabeth tested and works perfect. If you want me to set NULL if length = 0 for the code to be more easy to understand, please let me know. My opinion: it is not needed..


build: build and publish docker image on release

Hi! Finally I figured out how to automatically build docker images on every new rustic release.
Closes  #1083
Completes tasks discussed in #969, #1008 and #1010.
Notes to the maintainers:

This requires setting Workflow permissions to write access for the GITHUB_TOKEN as described here: https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/enabling-features-for-your-repository/managing-github-actions-settings-for-a-repository#configuring-the-default-github_token-permissions
It makes sense to update the README (added docker install info) in the next rustic release (when the first image is built)

Thank you! 🚀


[BUG] Wrong logging format used in JacksonAdapter

https://github.com/Azure/azure-sdk-for-java/blob/532d427683d51fbd1e40bf9478cb69b3c7b57abd/sdk/core/azure-core/src/main/java/com/azure/core/util/serializer/JacksonAdapter.java#L503
http://www.slf4j.org/api/org/slf4j/helpers/MessageFormatter.html
It uses %s instead of {}:
2021-06-22 11:38:19,949 DEBUG [com.azure.core.util.serializer.JacksonAdapter] User setter %s on class %s to set header collection.

Thank you for submitting this issue @d-schmidt. I've filed a PR to resolve this error.


corrected a typo in the rt-task tutorial regarding tagging

A colon was missing after "correct_response", preventing the example from running. It's added in this commit.

thanks! 👍


Adopt upstream rename of MLIRGPUToSPIRVTransforms

Commit https://github.com/llvm/llvm-project/commit/cd93906f93e6ff8c6619e0551b86a55ff3f4eafc#diff-6635fa1a5b0b10edf6e511585c7c986d authored by @GMNGeoffrey and commited by @antiagainst introduced the upstream change. Required to unbreak the CMake build.
The same needed to be fixed in mlir-emitc and therefore the submodule is bumped as well.

Sorry I should've prepped the fix for IREE when I made that change. My bad


layer_id and map_id API improvements.

One thing that confused a hell out of me were seemingly magic numbers in public API. Only after reading the source I understood how these are handled.  I think it would be a good idea to clean this API to make it easier to understand and use correctly.
From my understanding layer_id sort of has 2 functions at the moment:

identifier of layer
translation.z (z_index)

There also seems to be bug related to how layer_id is currently handled see: https://github.com/StarArawn/bevy_ecs_tilemap/issues/134. For this issue I will be ignoring the translation part.
example code snippet that could be found in many examples and likely in any sort of use-case:
// initialize map
let map_entity = commands.spawn().id();
let map_id = 0u16;
let mut map = Map::new(map_id, map_entity);

// configure layer
let layer_settings = LayerSettings::new(
    MapSize(2, 2),
    ChunkSize(8, 8),
    TileSize(16.0, 16.0),
    TextureSize(96.0, 16.0),
);

// use one of the ways to set id to the layer.... pick your preferred way...

// set layer_id using public accessor on struct
layer_settings.layer_id = 1u16;
// set layer_id using setter api of settings struct
layer_settings.set_layer_id(1u16);

// use one of the ways to set map id to the layer.... pick your preferred way...

// set layer_id using public accessor on struct
layer_settings.map_id = map_id;
// set layer_id using setter api of settings struct
layer_settings.set_map_id(map_id);

// initialize layer builder repeating layer_id and map_id (repeating what we did above)
// you can clearly see that we pass these values twice
//    - as part of layer_settings
//    - as own argumnet
let (mut layer, layer_entity) =
        LayerBuilder::new(&mut commands, layer_settings, layer_settings.map_id, layer_settings.layer_id);

//  use builder in some way ...

// add layer to map...  repeating map_id one more time.
map.add_layer(&mut commands, layer_settings.map_id, layer_entity);

I think this can be more sensible. The clearest part is LayerBuilder::new which esentially takes both arguments twice (as part of LayerSettings struct and own argument. It actually just calls the setters on LayerSettings before using them: https://github.com/StarArawn/bevy_ecs_tilemap/blob/a19c563f5bc44a21b20825a4f38c64c872a0eea0/src/layer_builder.rs#L48-L49 another method with doing the similar thing is new_batch https://github.com/StarArawn/bevy_ecs_tilemap/blob/a19c563f5bc44a21b20825a4f38c64c872a0eea0/src/layer_builder.rs#L79-L80
For this case I think layer_id and  map_id either should be part of LayerSettings and then never be passed as own argument or they shouldn't be part of LayerSettings in first place. I think later might be more ergonomic in cases where user wants to easily reuse same settings for multiple layers. Also note that almost all examples that use layer_id other than default 0u16 seems to set this value twice.
Even map_id in add_layer would be IMO better to avoid. Especially since Map struct has this on self https://github.com/StarArawn/bevy_ecs_tilemap/blob/a19c563f5bc44a21b20825a4f38c64c872a0eea0/src/map.rs#L10.
Proposed API
This is how I would like to be able to write the code above:
// initialize map
let mut map = Map::new(&mut commands, 0u16);

// configure layer
let layer_settings = LayerSettings::new(
    MapSize(2, 2),
    ChunkSize(8, 8),
    TileSize(16.0, 16.0),
    TextureSize(96.0, 16.0),
);

// initialize layer builder. layer_id is set at this point.
// also notice no tuple - this would be new struct that holds entity & layer_id internally
let layer_builder =
        LayerBuilder::new(&mut commands, 1u16, layer_settings);

//  use builder in some way ...

// add layer to map... map_id is set here
map.add_layer(&mut commands, layer_builder);

I did not check how simple it would be to avoid setting map_id in any way before add_layer call but I believe at least layer_id part will be simple to implement.

I like this! The example code is much clearer. Given that we already have access to &mut commands in map.add_layer, why not just pass in the LayerSettings directly?

I like this! The example code is much clearer. Given that we already have access to &mut commands in map.add_layer, why not just pass in the LayerSettings directly?

In my own code I have few small wrappers that do this. Anyway LayerSettings is not really enough because add_layer also needs an entity which is returned from LayerBuilder::new(). Also what is missing in my example is part of code that actually uses builder to fill it with tiles. Anyway this is the code I use in my project. It simplifies things even further but it also does maybe a bit too much to be useful generally:
implementation:

struct MapTileSettings<'a> {
    src: &'a str,
    cols: usize,
    rows: usize,
    z_index: u16,
}

impl<'a> MapTileSettings<'a> {
    fn load(
        &self,
        cmds: &mut Commands,
        map: &mut Map,
        asset_server: &AssetServer,
        materials: &mut Assets<ColorMaterial>,
    ) -> MapLayer {
        let tiles = asset_server.load(self.src);
        let atlas =
            TextureAtlas::from_grid(tiles, Vec2::new(TILE_SIZE, TILE_SIZE), self.cols, self.rows);
        let atlas_material = materials.add(ColorMaterial::texture(atlas.texture));

        let mut layer_settings = LayerSettings::new(
            UVec2::new(MAP_SIZE, MAP_SIZE),
            UVec2::new(CHUNK_SIZE, CHUNK_SIZE),
            Vec2::new(TILE_SIZE, TILE_SIZE),
            Vec2::new(atlas.size.x, atlas.size.y),
        );
        layer_settings.set_layer_id(self.z_index);

        let (builder, entity) = LayerBuilder::new(cmds, layer_settings.clone(), 0u16, self.z_index);
        map.add_layer(cmds, self.z_index, entity);

        MapLayer {
            material: atlas_material,
            layer_settings,
            builder,
        }
    }

    fn get_index(&self, x: u16, y: u16) -> u16 {
        x + self.cols as u16 * y
    }
}

struct MapLayer {
    material: Handle<ColorMaterial>,
    layer_settings: LayerSettings,
    builder: LayerBuilder<TileBundle>,
}

impl MapLayer {
    fn set_tile(&mut self, tile_pos: UVec2, tile: TileBundle) -> Result<(), MapTileError> {
        self.builder.set_tile(tile_pos, tile)
    }
}

usage:
    let mut floor_layer = FLOOR_TILES.load(&mut cmds, &mut map, &asset_server, &mut materials);
    let mut wall_layer = WALL_TILES.load(&mut cmds, &mut map, &asset_server, &mut materials);
    let mut top_layer = TOP_TILES.load(&mut cmds, &mut map, &asset_server, &mut materials);

    /// set tile in some layer based on data...

     wall_layer.set_tile(
        loc, // coords
        TileBundle {
            tile: Tile {
                texture_index: FLOOR_TILES.get_index(2, 4);
                ..Default::default()
            },
            ..Default::default()
        },
    )

There I do quite a lof of stuff behind simple load which I use to define tile layers but I'm also making quite a few assumptions which I might not be appropriate to make in library. Anyway I simply do these things when initializing consts like:
const FLOOR_TILES: MapTileSettings<'static> = MapTileSettings {
    src: "textures/dungeon/floors.png",
    cols: 3,
    rows: 4,
    z_index: 0,
};

this does all the texture and material handling as well as creates layer and so on.
Anyway to support various use-cases I think it still makes sense to have settings decoupled from builder and use api:
declare Settings -> initialize builder -> use builder -> insert builder to map.

preferably I think it would nice if last step also forced move of the whole builder - That would add type level grantee it can't be used after it's inserted to map.

In my own code I have few small wrappers that do this. Anyway LayerSettings is not really enough because add_layer also needs an entity which is returned from LayerBuilder::new(). Also what is missing in my example is part of code that actually uses builder to fill it with tiles. Anyway this is the code I use in my project. It simplifies things even further but it also does maybe a bit too much to be useful generally:
implementation:

struct MapTileSettings<'a> {
    src: &'a str,
    cols: usize,
    rows: usize,
    z_index: u16,
}

impl<'a> MapTileSettings<'a> {
    fn load(
        &self,
        cmds: &mut Commands,
        map: &mut Map,
        asset_server: &AssetServer,
        materials: &mut Assets<ColorMaterial>,
    ) -> MapLayer {
        let tiles = asset_server.load(self.src);
        let atlas =
            TextureAtlas::from_grid(tiles, Vec2::new(TILE_SIZE, TILE_SIZE), self.cols, self.rows);
        let atlas_material = materials.add(ColorMaterial::texture(atlas.texture));

        let mut layer_settings = LayerSettings::new(
            UVec2::new(MAP_SIZE, MAP_SIZE),
            UVec2::new(CHUNK_SIZE, CHUNK_SIZE),
            Vec2::new(TILE_SIZE, TILE_SIZE),
            Vec2::new(atlas.size.x, atlas.size.y),
        );
        layer_settings.set_layer_id(self.z_index);

        let (builder, entity) = LayerBuilder::new(cmds, layer_settings.clone(), 0u16, self.z_index);
        map.add_layer(cmds, self.z_index, entity);

        MapLayer {
            material: atlas_material,
            layer_settings,
            builder,
        }
    }

    fn get_index(&self, x: u16, y: u16) -> u16 {
        x + self.cols as u16 * y
    }
}

struct MapLayer {
    material: Handle<ColorMaterial>,
    layer_settings: LayerSettings,
    builder: LayerBuilder<TileBundle>,
}

impl MapLayer {
    fn set_tile(&mut self, tile_pos: UVec2, tile: TileBundle) -> Result<(), MapTileError> {
        self.builder.set_tile(tile_pos, tile)
    }
}

usage:
    let mut floor_layer = FLOOR_TILES.load(&mut cmds, &mut map, &asset_server, &mut materials);
    let mut wall_layer = WALL_TILES.load(&mut cmds, &mut map, &asset_server, &mut materials);
    let mut top_layer = TOP_TILES.load(&mut cmds, &mut map, &asset_server, &mut materials);

    /// set tile in some layer based on data...

     wall_layer.set_tile(
        loc, // coords
        TileBundle {
            tile: Tile {
                texture_index: FLOOR_TILES.get_index(2, 4);
                ..Default::default()
            },
            ..Default::default()
        },
    )

There I do quite a lof of stuff behind simple load which I use to define tile layers but I'm also making quite a few assumptions which I might not be appropriate to make in library. Anyway I simply do these things when initializing consts like:
const FLOOR_TILES: MapTileSettings<'static> = MapTileSettings {
    src: "textures/dungeon/floors.png",
    cols: 3,
    rows: 4,
    z_index: 0,
};

this does all the texture and material handling as well as creates layer and so on.
Anyway to support various use-cases I think it still makes sense to have settings decoupled from builder and use api:
declare Settings -> initialize builder -> use builder -> insert builder to map.

preferably I think it would nice if last step also forced move of the whole builder - That would add type level grantee it can't be used after it's inserted to map.

regarding feasibility I tried to do 1st step - removing map_id and layer_id from LayerSettings struct. While doing so I also fixed several bugs in examples which were caused by confusion around this API (setting layer_id to some value but then overwriting it to 0 when initializing builder)
https://github.com/turboMaCk/bevy_ecs_tilemap/commit/60670e4de077b9f043d771c6b6ef15320307913d
Anyway I based my branch off v0.4.0 and not master since that's what I'm using.

regarding feasibility I tried to do 1st step - removing map_id and layer_id from LayerSettings struct. While doing so I also fixed several bugs in examples which were caused by confusion around this API (setting layer_id to some value but then overwriting it to 0 when initializing builder)
https://github.com/turboMaCk/bevy_ecs_tilemap/commit/60670e4de077b9f043d771c6b6ef15320307913d
Anyway I based my branch off v0.4.0 and not master since that's what I'm using.

One problem with the proposed API is the fact that map_id is required to do a reverse lookup of a tile. Look at code referencing TileParent. I have implemented some of the changes here:
https://github.com/StarArawn/bevy_ecs_tilemap/pull/139


@contentful/field-editor-rich-text depends on constate without specifying it in package.json

Missing dependency on constate in package.json means that npm i @contentful/field-editor-rich-text leads to an unusable install.
Node version v20.10.0
NPM version 10.2.3
Installation structure showcasing the constate install location, which isn't resolvable from @contentful/field-editor-rich-text:
> find node_modules -type d | fgrep constate
node_modules/@contentful/field-editor-reference/node_modules/constate
node_modules/@contentful/field-editor-reference/node_modules/constate/dist
node_modules/@contentful/field-editor-reference/node_modules/constate/dist/ts
node_modules/@contentful/field-editor-reference/node_modules/constate/dist/ts/test
node_modules/@contentful/field-editor-reference/node_modules/constate/dist/ts/src
node_modules/@contentful/field-editor-reference/node_modules/constate/src

Thanks for the report. This was fixed a day ago.


UTF-8 support for render_text algo

UTF8 decoder is from here, It is a simple and fast decoder, and will take some invalid utf-8 input. It should not be a problem, since FreeType will most likely not find such glyph. And it does not affect program stability.
It is still up to user to supply font which supports all the needed codepoints.

This basically LGTM, though I wonder if maybe utf8_to_unicode() should simply be in strutil.h and the implementation of decode be put in strutil.cpp, rather than making the new file utf8_dfa.h just for that?

Sure, I'll do that.
I just wanted to put code copyrighted by decode author into separate file.
Also I think decode function is small enough and is called for every char so it should probably be kept as inline in header.

Since utf8_to_unicode is public API now, so I decided to make it a bit simpler. OIIO is not about text encodings :)
Maybe render_text should be overloaded to take std::u32string, if available in complier?
But that would require detection of c++11 features in current compilers and std::* libraries, which is painful and error prone, and would be too much work for such a small feature.

If you #include "platform.h", there will be a macro OIIO_CPLUSPLUS11, which it's ok to conditionally compile with.
I like what you've done with the code. I'm not at all worried about the function not being inlined. In the context of any image-handling app that uses OIIO, it seems very unlikely that the function call overhead of the few times it needs to convert unicode characters is ever going to be the performance bottleneck.
I'l test this out andl merge it (with perhaps some extremely minor formatting tweaks).
Do you need this backported to 1.5, or is master sufficient for you?

Unfortunately not all compilers claiming to be c++11 support new strings, so that macro is not enough.
And master is enough. Thank you.

Merged, with some minor formatting changes, and addition of various docs updates.


[adoptium-1643] Download page lack checksum info

Description of change
This pull request is to fix the lack of checksum info on the download page reported in issue #1643
What it looks like:

Checklist

[x] npm test passes

That looks really good :) If @gdams has no comment on the JS code - I'm a JS noob :D - we should merge it.


Fix a bug where the result of rehash is unstable

Fixes #21028
The root cause is that the file entries targeted for rehash are not actually sorted.
Sort was skipped because the compare function was null.
So a compare function has been implemented to allow file entries to be sorted.
[Build]
Success
[Test]
test file list

certA-1.pem
certA-2.pem (same as certA-1.pem)
certB-1.pem
certB-2.pem (same as certB-1.pem)

rehash results : before patch
(The result is from my local system. It will change depending on OS file system.)

0a775a30.0 -> certA-1.pem
1001acf7.0 -> certB-2.pem

rehash results : after patch

0a775a30.0 -> certA-1.pem
1001acf7.0 -> certB-1.pem

Checklist

[ ] documentation is added or updated
[ ] tests are added or updated

I mistakenly thought this is a CLA: trivial submission.

This pull request is ready to merge

Merged to master, 3.1, and 3.0 branches. Thank you for your contribution.


Enable server and client logging to the database.

This allows arbitrary edit-replay of any issue discovered in production. However, it bloats the database; there should be some features to cull the database over time.

bors r+