Release 1.4.0.Beta6

Summary
Release contains:

https://github.com/quarkus-qe/quarkus-test-framework/pull/979
https://github.com/quarkus-qe/quarkus-test-framework/pull/991
https://github.com/quarkus-qe/quarkus-test-framework/pull/989
https://github.com/quarkus-qe/quarkus-test-framework/pull/990
https://github.com/quarkus-qe/quarkus-test-framework/pull/992
https://github.com/quarkus-qe/quarkus-test-framework/pull/993
https://github.com/quarkus-qe/quarkus-test-framework/pull/994
https://github.com/quarkus-qe/quarkus-test-framework/pull/995
https://github.com/quarkus-qe/quarkus-test-framework/pull/999
https://github.com/quarkus-qe/quarkus-test-framework/pull/998
https://github.com/quarkus-qe/quarkus-test-framework/pull/996
https://github.com/quarkus-qe/quarkus-test-framework/pull/997
https://github.com/quarkus-qe/quarkus-test-framework/pull/1000
https://github.com/quarkus-qe/quarkus-test-framework/pull/971
https://github.com/quarkus-qe/quarkus-test-framework/pull/1003
https://github.com/quarkus-qe/quarkus-test-framework/pull/1002
https://github.com/quarkus-qe/quarkus-test-framework/pull/1004
https://github.com/quarkus-qe/quarkus-test-framework/pull/1005
https://github.com/quarkus-qe/quarkus-test-framework/pull/1007
https://github.com/quarkus-qe/quarkus-test-framework/pull/1006
https://github.com/quarkus-qe/quarkus-test-framework/pull/1008
https://github.com/quarkus-qe/quarkus-test-framework/pull/1009

Please check the relevant options

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Dependency update
[x] Release
[ ] Refactoring
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] This change requires a documentation update
[x] This change requires execution against OCP (use run tests phrase in comment)

Checklist:

[x] Example scenarios has been updated / added
[x] Methods and classes used in PR scenarios are meaningful
[x] Commits are well encapsulated and follow the best practices

run tests


it doesn't work under (ubuntu18.04 captcha 0.3 pillow 6.0.0 python 3.6.7)

I am a fresh coder, I am already find it from google, but...
this is my question, how can i solve it?
code:
    image = ImageCaptcha(fonts=['./ihome/utils/captcha/fonts/actionj.ttf', './ihome/utils/captcha/fonts/Georgia.ttf'])
    str1 = 'abcd123efghijk45lmn6opqrst789uvwxyz0'
    text = ''
    for i in range(0, 4):
        text += str1[random.randrange(0, len(str1))]
    image_data = image.generate(text)

ERROR:
Traceback (most recent call last):
File "/home/icmelon/virtual_environment/flask/flask/lib/python3.6/site-packages/PIL/ImageFile.py", line 488, in _save
fh = fp.fileno()
AttributeError: '_idat' object has no attribute 'fileno'
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/home/icmelon/virtual_environment/flask/flask/lib/python3.6/site-packages/flask/app.py", line 2328, in call
return self.wsgi_app(environ, start_response)
File "/home/icmelon/virtual_environment/flask/flask/lib/python3.6/site-packages/flask/app.py", line 2314, in wsgi_app
response = self.handle_exception(e)
File "/home/icmelon/virtual_environment/flask/flask/lib/python3.6/site-packages/flask/app.py", line 1760, in handle_exception
reraise(exc_type, exc_value, tb)
File "/home/icmelon/virtual_environment/flask/flask/lib/python3.6/site-packages/flask/_compat.py", line 36, in reraise
raise value
File "/home/icmelon/virtual_environment/flask/flask/lib/python3.6/site-packages/flask/app.py", line 2311, in wsgi_app
response = self.full_dispatch_request()
File "/home/icmelon/virtual_environment/flask/flask/lib/python3.6/site-packages/flask/app.py", line 1834, in full_dispatch_request
rv = self.handle_user_exception(e)
File "/home/icmelon/virtual_environment/flask/flask/lib/python3.6/site-packages/flask/app.py", line 1737, in handle_user_exception
reraise(exc_type, exc_value, tb)
File "/home/icmelon/virtual_environment/flask/flask/lib/python3.6/site-packages/flask/_compat.py", line 36, in reraise
raise value
File "/home/icmelon/virtual_environment/flask/flask/lib/python3.6/site-packages/flask/app.py", line 1832, in full_dispatch_request
rv = self.dispatch_request()
File "/home/icmelon/virtual_environment/flask/flask/lib/python3.6/site-packages/flask/app.py", line 1818, in dispatch_request
return self.view_functionsrule.endpoint
File "/home/icmelon/virtual_environment/flask/flask/bin/ihome_project/ihome/api_1_0/verify_code.py", line 21, in get_image_codes
image_data = image.generate(text)
File "/home/icmelon/virtual_environment/flask/flask/lib/python3.6/site-packages/captcha/image.py", line 47, in generate
im.save(out, format=format)
File "/home/icmelon/virtual_environment/flask/flask/lib/python3.6/site-packages/PIL/Image.py", line 2007, in save
save_handler(self, fp, filename)
File "/home/icmelon/virtual_environment/flask/flask/lib/python3.6/site-packages/PIL/PngImagePlugin.py", line 896, in _save
[("zip", (0, 0)+im.size, 0, rawmode)])
File "/home/icmelon/virtual_environment/flask/flask/lib/python3.6/site-packages/PIL/ImageFile.py", line 502, in _save
l, s, d = e
TypeError: 'ImagingEncoder' object is not iterable
But pillow 5.0.0 can work!

Somewhat related to https://github.com/lepture/captcha/issues/33.
Seems like higher Pillow versions(>5.0.0) are not compatible to captcha.

0.5.0 works with Pillow 10.0.0

Ok. Will try.


Post install help

After the installer has run, the user should be given some information about what to do next, what commands are now available to them, etc.
This should include information about installing janus etc.

The installer should really just run the dotfiles-help command. With a message about the dotfiles command.


Multiple data binding of chart data

Hi,
I am passing multiple array of data in my chart, how can i render these 3 datasets in realtime?
My chart code:
<chartjs-line :bind="true" :data="datasets"/>
the vue data:
datasets: [ {  data: [] }, {  data: [] }, {  data: [] } ]

as i know you have to use the override with :datasets="datasets" not :data=...


attempt to fix reproducibility issue

let's try to set source date epoch to 0 to match what's being done on 4th gen
also, add -u to date to make it use universal time
Untested
Untested
Signed-off-by: randomhydrosol<EMAIL_ADDRESS>

This isn't the fix we want. It SHOULD use the source date like we do for 5th gen. We only did the 0 override for 4th gen to work around it not having this code.


chore(rev-parse) fix(bug) don't assume we have a .git folder

What does this PR do?
instead of assuming we have a local .git folder, just use git rev-parse --short=4 HEAD
This is because when we downstream this code, it breaks in https://github.com/redhat-developer/codeready-workspaces-images/tree/crw-2-rhel-8/codeready-workspaces-devworkspace-controller as the .git folder is a level up.
Added bonus is the SHA you get with --short=4 could be shorter (minimum 4 chars if that allows for a unique commit SHA) than the default full-length SHA
Change-Id: Id46685217e3d8048bee6a33df92ef73cab5a7943
Signed-off-by: nickboldt<EMAIL_ADDRESS>Screenshot/screencast of this PR
N/A
What issues does this PR fix or reference?
https://issues.redhat.com/browse/CRW-1734
How to test this PR?
N/A
PR Checklist
As the author of this Pull Request I made sure that:

[x] The Eclipse Contributor Agreement is valid
[x] Code produced is complete
[x] Code builds without errors
[ ] Tests are covering the bugfix
[x] The repository devfile is up to date and works, if one exists
[x] Sections What issues does this PR fix or reference and How to test this PR completed
[x] Relevant user documentation updated
[x] Relevant contributing documentation updated
[x] CI/CD changes implemented, documented and communicated

Reviewers
Reviewers, please comment how you tested the PR when approving it.

if approved this needs cherrypicking to 7.30.x

Hmmm.. this might not work as expected.
Running locally I get:
STEP 10: RUN make compile-devworkspace-controller
fatal: Not a git repository (or any of the parent directories): .git

Added bonus is the SHA you get with --short=4 could be shorter (minimum 4 chars if that allows for a unique commit SHA) than the default full-length SHA

Is this forward-compatible though? A 4 char SHA might be unique now, but does git resolve it correctly once it's no longer unique?

As to the sha length, at the point where there are enough commits that a 4-char char is no longer enough to uniquely id a comment, --short=4 returns a 5-char sha. Try it on the eclipse/che repo and you get a 6-char sha.
But anyway ... does the build really need a valid GIT_COMMIT_ID ? Because this change since 0.2.0 doesn't work in downstream. :( Can we maybe FIND the .git/HEAD file instead of assuming its location?


Special case Booleans

Quote from XRPC spec:

When encoding boolean parameters, the strings true and false should be used.
- https://atproto.com/specs/xrpc#lexicon-http-endpoints

By default, System.Boolean#ToString() returns True or False, I've patched the source generator to add a special case for this, avoiding using ToString() in case it runs into any issues with UI culture and the like.
While this appears to generate correctly in my local testing I don't have the complete set of schemas currently included in FishyFlip so I've not actually run the source generator on the repository, happy to do so but I will need pointing towards said schemas.

All good! Apologies I totally missed the shell script 😅


Relaxing restriction on how accum :result-binding can be used

I see the change from
https://github.com/rbrush/clara-rules/commit/ca68b9dc140dcb088c5236eb22d2cb6be5d4b5ac
is meant to prevent :result-bindings from being used my subsequent conditions within a rule LHS.
I'm not positive on the reason behind this, so I'd certainly like your feedback on it.  However, I am thinking that the reason for this is that Clara will re-order the conditions in a rule so that the order of conditions is: simple conditions -> negation conditions -> accumulator conditions -> test conditions.  I see this in the clara.rules.compiler/condition-comp function.
This restriction is interestingly not always applicable to simple conditions if the binding is not a direct field equality unification.
I this is best just demonstrated with an example.
Note: This example is obviously contrived to just make it as short as I could easily demonstrate.  I realize it doesn't make a lot of sense to do it.
This works:
(let [r (dsl/parse-rule [[?t <- (acc/max :temperature :returns-fact true) :from [Temperature]]
                        [Temperature (= (identity ?t) this)]]

                       (println "?t" ?t))
     s (mk-session [r])]
 (-> s
     (insert (->Temperature 1 "MCI"))
     fire-rules))

?t #clara.rules.testfacts.Temperature{:temperature 1, :location MCI}
;= #<LocalSession clara.rules.engine.LocalSession@764670aa>

This does not work:
(let [r (dsl/parse-rule [[?t <- (acc/max :temperature :returns-fact true) :from [Temperature]]
                        [Temperature (= ?t this)]]

                       (println "?t" ?t))
     s (mk-session [r])]
 (-> s
     (insert (->Temperature 1 "MCI"))
     fire-rules))

ExceptionInfo Using accumulator result bindings in other expressions in a rule left-hand side is currently not supported. Binding: :?t in production {:lhs [{:result-binding :?t, :accumulator (clara.rules.accumulators/max :temperature :returns-fact true), :from {:type clara.rules.testfacts.Temperature, :constraints []}} {:type clara.rules.testfacts.Temperature, :constraints [(= ?t this)]}], :rhs (println "?t" ?t)}  clojure.core/ex-info (core.clj:4403)

The reason (I believe) is that the difference in the condition constraint (= ?t this) vs (= (identity ?t) this).
When an seq-style expression is involved in the binding unification, the operation is "deferred" into a later :test condition.  With this, I believe some of the efficiency of the hash-based join may be lost, but I am not positive there.
--
In the case of negation conditions, I cannot find a way where I can successfully use a :result-binding from an accumulator at all.  However, the error message is for negation conditions hitting thi srestriction are more mysterious than the errors for simple conditions.
(let [r (dsl/parse-rule [[?t <- (acc/max :temperature :returns-fact true) :from [Temperature]]
                         [:not [Temperature (= (identity ?t) this)]]]

                        (println "?t" ?t))
      s (mk-session [r])]
  (-> s
      (insert (->Temperature 1 "MCI"))
      fire-rules))

ExceptionInfo Using variable that is not previously bound. This can happen when an expression uses a previously unbound variable, or if a variable is referenced in a nested part of a parent expression, such as (or (= ?my-expression my-field) ...).
Unbound variables: #{?t}  clojure.core/ex-info (core.clj:4403)

;;; As well as

(let [r (dsl/parse-rule [[?t <- (acc/max :temperature :returns-fact true) :from [Temperature]]
                         [:not [Temperature (= ?t this)]]]

                        (println "?t" ?t))
      s (mk-session [r])]
  (-> s
      (insert (->Temperature 1 "MCI"))
      fire-rules))

ExceptionInfo Using accumulator result bindings in other expressions in a rule left-hand side is currently not supported. Binding: :?t in production {:lhs [{:result-binding :?t, :accumulator (clara.rules.accumulators/max :temperature :returns-fact true), :from {:type clara.rules.testfacts.Temperature, :constraints []}} [:not {:type clara.rules.testfacts.Temperature, :constraints [(= ?t this)]}]], :rhs (println "?t" ?t)}  clojure.core/ex-info (core.clj:4403)

I haven't went into the details yet of why negation conditions are not behaving the same as the simple conditions here.

I think this behavior is somewhat confusing and the limitation has caused me some difficulty in rules that we do typically want to write.  I realize it can be worked around by separating the accumulated :result-binding rule from the rest of the logic that needs to reason about it.  This can be done via an intermediate fact to relay the accumulated result information to further conditions in another rule.
I'm curious if this restriction could be reconsidered and removed by moving the unification to a :test condition when a simple condition or negation condition wished to refer to the :result-binding of an accumulator.  I think this may be straight forward for simple conditions.  I'm not sure on negation conditions as I've mentioned above.
Thanks for the feedback on this!

This is a bug, in both the negation and the non-negation flow. I had disallowed using accumulator results in bindings because I didn't know of a need, and I didn't see a good way to support it when dealing with edge cases around the extraction of tests from conditions. But this is something we should support.
Looking at it now, I think we I see an approach that is simple and workable but I need to dig a bit deeper first. I'll do so and report back here.

These should be addressed in the above commits. The first removes the constraint on using accumulator results in other conditions, and the second fixes a bug in the negation logic that prevents it from seeing the result bindings of accumulators.
Merging in these fixes makes sense to me as they address the issue without any known regression, but it might also be worthwhile to clean up the logic around this in general. I logged issue #133 to track that.
Let me know if these don't fix the problem you ran into, or if you have any other suggestions in this space.

Hi.  Sorry for the delayed feedback.  I'm looking through these changes and testing them against the issues I was seeing originally.  I'll get back with feedback sometime today.  I appreciate the quick feedback and work on this.

Ok, I looked over this today and tested against my concrete situation I had where it came up recently.  It looks to me that everything is working as I'd expect in that situation with these changes in place.
I also do not see any regressions currently against the projects I have using Clara.
I do have a question on the changes @
https://github.com/rbrush/clara-rules/commit/1fde77b12bc952eaf5f8a6304ffa34bd1f305419#diff-00da05e66726186c05209662d990b97cR604
Initially this change worried me because I thought it meant if an accumulator changed what it returned it wouldn't propagate.  However, there would always be a retraction prior to that from what I can tell.
The more I played around with this, the more I thought it seemed to be alright.  My question on this really is what sort of situation is it meant to catch?  Perhaps just for my own understanding of the changes.
Thanks!

The "previous-result" variable could probably use a better name. That check isn't to compare it with the previous result of the accumulator, but with any other constraint that uses the same binding. For instance, a rule like this:
(defrule example
   [?temp <- Temperature (= ?t temperature)]
   [?t <- (acc/max :temperature) :from [Temperature]]
  =>
  (println ?temp "is the maximum temperature fact!"))

(This is contrived and a bad way to write this logic, of course.)
Notice that ?t is bound in the first condition, and re-bound as the result of the accumulator. So we'd only want the rule to fire if the ?t bound above matches the ?t resulting from the accumulator...which is what that check does. This wasn't necessary when we disallowed the use of accumulator results in other expressions, but now that we support it we have to make sure they are consistent.
It's also worth noting that we can put this logic in the accumulator node because we sort accumulators to be after other nodes in the network.

I went ahead and clarified the code comment on this topic a bit. Since this is working across multiple projects without regression and solves the problem, I went ahead and merged this into master as well.
We're tracking future improvements in issue #133, so I don't think there is anything left to do on this issue and will close it. We can reopen or create a new issue if you disagree.

Thanks for that explanation!  That makes sense to me now.  I also think the clarification to the commit you committed definitely helps as well.


Format data volume in the docker image

see the wiki page that I have created on my fork: https://github.com/MarcEtienneDery/docker-ubuntu-hadoop/wiki/To-start-hadoop-docker-using-persistence-stograge
resolves #5

@MarcEtienneDery  I agree, that's is little bit hackish
+RUN mkdir /data &&
+hdfs namenode -format
+VOLUME /data
@davidonlaptop  maybe, the script who start docker image can reset the format on disk as needed. Then it's possible to keep one location only for HDFS data.

My last comment is great if you want any persistence by default. But, if you only want one copy on write hdfs data-path then VOLUME and -v is not necessary. You can even restart last stopped container with same /data without  -v as argument or VOLUME on Dockerfile as presented on SequenceIQ Cloudera image : https://github.com/sequenceiq/docker-hadoop-ubuntu

I think the image should be as simple as possible to use in the README,
hence the VOLUME instruction. And then describe the better method in the
wiki.
On Sep 23, 2015 11:29 PM, "mikefaille"<EMAIL_ADDRESS>wrote:

My last comment is great if you want any persistence by default. But, if
you only want one copy on write hdfs data-path then VOLUME and -v is not
necessary. You can even restart last stopped container with same /data
without -v as argument or VOLUME on Dockerfile as presented on SequenceIQ
Cloudera image : https://github.com/sequenceiq/docker-hadoop-ubuntu
—
Reply to this email directly or view it on GitHub
https://github.com/GELOG/docker-ubuntu-hadoop/pull/25#issuecomment-142795401
.

I think the image should be as simple as possible to use in the README,
Agree.

hence the VOLUME instruction.
I don't really go trough my reflection : why you suggest to have persistence with VOLUME instruction ?

As I know, VOLUME instruction is useful mainly for volume sharing between docker image.

From my understanding, the task was to offer the user of this image a easier way to start this image with the removal of the step of formating the storage. These are the multiple use case that a user may have :

The user want to create a fast hdfs cluster to test it out. In this case he doesn't have to format the volume because the data inside is irelevent and doesn't need to be persistant.
The user want to create a hdfs cluster with persistant storage outside of the container. The user will need to format the volume because by using the -v comand, he will overwrite the content for the formated volume ()
The user is currently running a hdfs cluster without the storage outside of the container but still want to save it's data. The data is still available since it's located in a volume. he can upgrade his container using the --volume-from comand while creating a new container.

I put the VOLUME instruction after the mkdir and format because I want the volume to contain this data. Any step that modify the data within the volume after his declaration will be discarded (https://docs.docker.com/reference/builder/#volume)
if the usecase 3 is not desire, the volume statement is obsolete

Your understanding of the use cases is spot on.
I still don't get the benefits of putting the VOLUME instruction after the hdfs format command. The hdfs format command generates metadata in the /data folder; that's why I think the VOLUME instruction should come ideally before anything is written into that folder. Please correct me if I am wrong.

You need to put data into the volume before the instruction VOLUME, otherwise any modification of the data contains in the volume will be discarded. You can check the documentation of
Docker that I link in my post above.

This Dockerfile results in an image that causes docker run, to create a
new mount point at /myvol and copy the greeting file into the newly created
volume.

You got a point. ;-)
We used Docker since beta version. This behaviour  is new for us.
Good job

Hey I ran some tests and you're totally right: anything written to the path after the VOLUME instruction will be discarded!
Great work @MarcEtienneDery!


Missing initial instructions in evals/benchmark/README (and others)

In GenAIEval/evals/benchmark/README.md (and others), the first step in the instructions is,
pip install -r ../../requirements.txt

There's a non-stated assumption of the current directory before this step is executed.  How did the requirements.txt file get on the developer's computer?  There's no instruction to clone the GenAIEval repo locally, for example.

I agree with the above statement. I am also trying to use benchmarking tools but have problems to figure out how to...


feat: add tp and rrt code lookup proxies to pvdata

Adds a relationship and proxy to get code descriptions for TP and RRT status in the PVData model

FAO @George-D-S


No output in ST3

Just installed in ST3 and tried to start up guard but nothing happens. I can open the console but there's no output and I don't get any sort of visual feedback.
I'm running the dev builds of ST3 on OSX Mavericks. I know you probably need more information to troubleshoot this, but I'm not sure how to find that. Let me know if there's a way I can get you more details on this.

@edubkendo unfortunately, just using find_resources doesn't help us here, as we're trying to execute something in our zipped package. I've added the no-sublime-package file in pr #83


Using the project as template

Hi, I've been starting the scala on android thing just recently, so I may be quite dumb.
So my environment is set and I could use macroid to do a simple things. Now I have been intrigued by this project and I want to use it as a boilerplate.
When I try to fetch library dependencies but I keep getting error. I a bit puzzled.
Im using intelliJ to build the project..

After some cleaning and and removing resolvers and to just Resolver.sonatypeRepo("releases"),       "jcenter" at "http://jcenter.bintray.com" no snapshot or anything else, the sbt no longer complains.


for completions includes parenthesis but if/while/switch etc don't include parenthesis

I would think this should be kind of consistent maybe ?

Also, if I complete the for suggestion, the caret ends up here:

I would think caret should be one to the left, not sure if this is a webstorm issue ?

caret placement is WebStorm issue

@alexander-doroshko ah, okay, shouldn't it be better if the analyzer also gives information about where the caret should be after the completion.
I see that both atom, dartpad, and webstorm doesn't do the right caret position after completing this for statement. Also for things like completing:
import '' show ;<caret>

the caret ends up in this place in all 3 editors. It seems ideal to me that the analyzer can give information about where the caret should be after completing.

Analyzer gives this info but IDEs do not handle it correctly.

After discussion, we decided that client templates are more expressive and thus are removing the () from the for keyword suggestion along with the import suggestion variations. Instead, if the client wants something more than just the keyword inserted, they can detect a specific keyword suggestion and dynamically replace that with a template. For example, if the analysis server suggests the 'import' keyword, then the client could dynamically replace that suggestion with multiple import templates such as
import '';
import '' as ;
import '' show ;


provider method for iscairo1

Is your feature request related to a problem? Please describe.
We have now Cairo 0 and Cairo 1 accounts. A DAPP can collect an address of account, without the information of Cairo version.
It is possible to find the Cairo version, but it needs several lines of code.
Describe the solution you'd like
To propose  a dedicated method :
const isV1:boolean = provider.isContractV1(contractAddress);

We can even think to an auto completion of the Cairo Version of new Account, in case it is not provided.
Describe alternatives you've considered
Stay as it is, with no improvement of UX.
Additional context
It will be possible to remove this method after Regenesis of Starknet.
I would like to propose a small PR on this subject.

I had thoughts about 'auto' CairoVersion but it can't be implemented backward compatible, and side effect free.
Dev needs to provide CairoVersion on the constructor and the constructor does not allow side effects (read async).
There is another way by optional chaining initialization like:
let acc = new Account(provider, address, key)
await acc.setVersion();

where setVetsion(version) if not provided version will do "auto detect".
Regarding "auto detect" method implementation, I will put it into utils and not provider.
Also calling it
// get contract Cairo version, fullname getContractCairoVersion
getContractCairoVersion(provider, address): VersionMetadata

type VersionMetadata {
 compilerVersion:  '0' | '1' | '2' | ....
 cairoVersion: '0' | '1'
 // potentially some more metadata
}

It will return Cairo version for any contract deployed on address.
This method can then be used inside Account setVersion.
I did not proceed with this implementation as I didn't see real value in it as it will not auto fix user issue with Account versions, as that will still need to read about it in documentation same as that need to do with Account CairoVersion param.
Regarding getContractCairoVersion method there were some discussions regarding providing compiler version in deployed artifacts so that it can be read out, but i don't know is it done and can it be done some other way in the maintime

OK.
Will be detailed when rpc 0.5.0 will have to be implemented.

So we decided on by-weekly that this will be done so that async operation is called on usage and not on constructor.
So we can do as described just define CairoVersion on Execute when needed.

Do I take the opportunity to change default CairoVersion to "1"?


trying infinite scroll with this plugin

hey, first thanks for this plugin, I'm trying to do an infinite scroll effect with this plugin with ng-repeat, here's a plunker example on how I did it, but it has a bug the loading of additional data happen at the beginning of the load only when I set the offset to a positive number (+1 or 1) the loading happen after the first scroll to that offset and keep happening until last page is loaded, how can I make it so that it load only one page each time it reaches the bottom?

Note: I tried broadcasting the 'scrollpointShouldReset' event but that generated a new error and loaded one extra page.

Thanks, in advance.

ui-scrollpoint-action callback takes element and distance as arguments.  When distance < 0 it means your scrollpoint is out of view.
I tested with your code and it works with app.loadMore like this:
app.loadMore          = function loadMoreF(elem, distance) {
    if (app.users.isLastPage || distance < 0) {
        return;
    }
    Store.getUsers().then(setUsers, error);
};

:+1:

Just wanted to note that with PR #11 for ui-scrollpoint-edge="bottom" distance is relative to bottom of target.  A positive distance would mean the scrollpoint is below the bottom of target (not scrolled in yet).  So you would want to switch distance < 0 to distance > 0 in your loadMore function

Just wanted to note that with version 2.0.0 , there are a couple changes to the ui-scrollpoint-action callback (as noted in PR #11)...  the function parameters are reversed, so they are now function(distance, elem, edge)
Also in the case of ui-scrollpoint-edge="bottom" (more generally when edge parameter == 'bottom'), when distance <= 0 it means the scrollpoint has scrolled into view from the bottom.  This is more consistent with other functionality where values < 0 are "above" the scroll edge.
A full example of how I set up infinite scrolling with version 2.0.0 is like so:
<div ui-scrollpoint ui-scrollpoint-edge="{bottom:'top'}" ui-scrollpoint-action="loadMore"></div>
$scope.loadMore = function(distance, elem, edge){
    if(distance <= 0){
        // load more content
    }
}

ui-scrollpoint-edge="{bottom:'top'}" means trigger the hit when the top edge of the element hits the bottom edge of the scroll target.
ui-scrollpoint-edge="bottom" means trigger the hit when the bottom edge of the element hits the bottom edge of the scroll target.
Hope this helps, and sorry for the switcheroo on these features, but I think this method makes more sense and ultimately offers more flexibility.


Develop transactions extractor

Tool generates array of Components<TxSource> from the GraphQL endpoint.

Basec block extractor is imlpemented


add SNAT limitation

https://docs.microsoft.com/en-us/azure/firewall/logs-and-metrics#metrics

Currently, SNAT ports are added only for the first five public IP addresses.

@ShuheiUda : Thanks for your contribution! The author(s) have been notified to review your proposed change.

#sign-off


React Swiper Pause Autoplay on Mouse Hover

Discussed in https://github.com/nolimits4web/swiper/discussions/5537

Originally posted by burhan333 March 10, 2022
Is there anyway i can pause autoplay on mouse hover and start autoplay on mouse out in react swiper
pauseOnMouseEnter Event is not working

Your issue is closed because it is not filled correctly. Before you open an issue please review the contributing guideline.
Please fill the issue template correctly and:

Clearly describe the issue including steps to reproduce when it is a bug.
Make sure you fill in the earliest version that you know has the issue.
Provide live link or JSFiddle/Codepen or website with isssue

It will save a lot of time for other contributors to check your issue and fix it.


module Wobserver.Assets is not available

When freshly mix deps.compile wobserver this as a dependency, the compilation gives these warnings, and indeed I'm not seeing a Wobserver.Assets module in the project?
==> wobserver
Compiling 4 files (.ex)
warning: function Wobserver.Assets.html/0 is undefined (module Wobserver.Assets is not available)
  lib/wobserver/web/router/static.ex:21

warning: function Wobserver.Assets.css/0 is undefined (module Wobserver.Assets is not available)
  lib/wobserver/web/router/static.ex:32

warning: function Wobserver.Assets.js/0 is undefined (module Wobserver.Assets is not available)
  lib/wobserver/web/router/static.ex:38

warning: function Wobserver.Assets.license/0 is undefined (module Wobserver.Assets is not available)
  lib/wobserver/web/router/static.ex:43

Of course following the Hex install section, not the Manual install section.

Same error if following the Manual Install steps as well.

Which version of wobserver are you using? Can you check in the deps directory whether lib/wobserver/assets.ex exist?
I have trouble reproducing this problem. (I downloaded the 0.1.6 version and assets is included and compiles without problem even within a completely new project.)

I was using {:wobserver, github: "shinyscorpion/wobserver"}, (I move to hex.pm after initial testing is complete, always start with github).

Ahw, that explains a lot. The assets are not added to the repo in build form. So using wobserver directly from the repo does not work, since it will be missing assets.

Ahw, that explains a lot. The assets are not added to the repo in build form. So using wobserver directly from the repo does not work, since it will be missing assets.

Should add it to the compile step instead of a separate step.  ^.^

I'll look into that. (See: #20) Thing is it won't work if people don't do a npm install first, or have it installed at all.
For now I updated the readme to warn of the problem.

I'll look into that. (See: #20) Thing is it won't work if people don't do a npm install first, or have it installed at all.

Hmm, true, we need a simple Elixir javascript bundler, though most of your assets could be easily bundled regardless, hmm...


Do not append customized api-version if url already has one e.g LRO/p…

Do not append customized api-version if url already has one e.g LRO/paging URL returned by the service

API change check
API changes are not detected in this pull request.


How can we specify the segmentation class number?

Dear @kanezaki ,
Thanks for sharing the great work.
It seems the number of classes is determined by SLIC.
https://github.com/kanezaki/pytorch-unsupervised-segmentation/blob/8dbde7099dc789b2dcdb54095fe02cc96cd19a33/demo.py#L74-L77
How can we manually specify the segmentation class number?
e.g., I only want the method segments the input image into 3 classes.
Best regards,
Jun

Dear @JunMa11
Sorry for confusion, but the number of classes is actually not determined by SLIC. As you will see when you run the code, the number gradually decreases during training. The training stops when it reaches the minimum number of classes, which can be given by "--minLabels" command option. It is set to 3 by default, so I expect you would get your desired results by just running the code. :)
Best regards,
Asako

Got it. Thanks for your reply very much.


A lot of NAT bugfixes

Added check for TCP connection close.
Swap bytes of IP addresses.
Switched to two hash tables (improved performance and fixed correctness).
Improved cmd parameter parsing.
Improved debug diagnostics.
Fixed bug in pri2pub translation.

IF OKEY -> THAN OKEY!


Enhancing PolicyDiff to be able to handle non-ascii strings.

Should fix #670

Coverage remained the same at 60.323% when pulling 2ea87c55df32da6fbbbf049bc9d7a84c08098617 on issue_670_unicode_problems_policydiff into 30dc9d0e87c4ec24f4355079b0bd70b8bb9d047a on develop.


TC39 proposal cancellation

There are any plan for TC39 proposal cancellation?
If not:
Based on TC39:
user-controlled cancellation of asynchronous operations through the adoption of a set of native platform objects.
At first, we must have need to asynchronous operations as long as we can use cancelling asynchronous operations that cleared and consistent approach as below:

Asynchronous functions or iterators
Fetching remote resources (HTTP, I/O, etc.)
Interacting with background tasks (Web Workers, forked processes, etc.)
Long-running operations (animations, etc.)

Seems like a good addition once the proposal is more mature.


C: cleanup attribute not supported

The cleanup attribute does not seem to be supported. I get many many false positives for resource and mem leaks due to this.

cleanup (cleanup_function)
The cleanup attribute runs a function when the variable goes out of scope. This attribute can only be applied to auto function scope variables; it may not be applied to parameters or variables with static storage duration. The function must take one parameter, a pointer to a type compatible with the variable. The return value of the function (if any) is ignored.
If -fexceptions is enabled, then cleanup_function is run during the stack unwinding that happens during the processing of the exception. Note that the cleanup attribute does not allow the exception to be caught, only to perform an action. It is undefined what happens if cleanup_function does not return normally.
https://gcc.gnu.org/onlinedocs/gcc/Common-Variable-Attributes.html

Hi,
Thanks for reporting this. We haven't looked into the cleanup attribute yet, but would be happy to support it. Could you please give us some small example of how this attribute is used and what kind of false positive leaks you get?
Thanks,
Dulma

Hi,
Here is an example of how to use it. When a variable with the attribute goes out of scope the function specified with the cleanup attribute will be called. The typical usecase is for free'ing the variable. This saves us from manually freeing in all error cases etc.
#include <stdlib.h>
#include <string.h>

void my_cleanup_func(char **c)
{
  puts("debug: cleanup_func called");
  free(*c);
}

int main(int argc, char **argv)
{
  __attribute__ ((cleanup(my_cleanup_func))) char *s = NULL;

  s = strdup("demo string");

  return 0; /* s goes out of scope. Cleanup function called - no leak */
}

This is equivalent to C++ scope bound resource management, i.e. a class with a destructor.


Add LLOS Fields-Visibility toolset

Summary

[ ] Dsk, Pro - rewrite summary to remove passive voice, rewrite to ..."Adds height field to observer and target point features before being used in Linear Line of Sight (LLOS)."

Usage

[ ] Dsk, Pro - rewrite bullet points in this manner to correct for grammar and style
*Run this tool on Observer, and Target features BEFORE running Linear Line of Sight (LLOS).
*Adds a new field named height, and calculates a default value for all rows in the Input Observer Features and Input Target Features.
*The units of the height will be the elevation units of the surface against which LLOS will run. If the surface elevation is in METERS, these values are METERS. If the surface is in FEET, these values are FEET.
*Default height for Observers is 2.
*Default height for Targets is 0.
*_recommend completely omitting this entire bullet point_Linear Line Of Sight will use this value as an additional height above the surface to account for an observer standing 2 units above the surface and viewing a target that is on the surface (0 units).

[ ] Dsk, Pro - when stating default height for observers and targets, say just "2.", not "2.0 units" (drop off the word units as well, do the same for all others that say units)

[ ] Dsk, Pro - in the last line, either get rid of the line entirely, or at a minimum, change the "2.0" to just "2" and "0.0" to just "0".

Syntax

[ ] Dsk, Pro - explanation of Observer_height_above_surface, change "2.0 units" to "2."
[ ] Dsk, Pro - explanation of Target_height_abover_surface, change "0.0 units" to "0."

[ ] Dsk, Pro - take "line of sight" out of tags list
[ ] Dsk, Pro - no Credits
[ ] Dsk, Pro - no Use limitations

@dfoll
So first question: what should Credits and Use Limitations be?
I'm guessing you are expecting Credits should be Esri, Inc? A little difficult to tell as all of the system tools in core ArcMap/Pro do not have this section.

@mfunk good questions, sent an email to @nfeuerstein @lfunkhouser and @karlterrey about this ... waiting on a response


ACTS

Propy cannot access the version of sql this is one. We need to update this another way.

I think UDSH has the same issue.


feat(retry-plugin): allow fallback function to receive failed URL

Description

A very simple change allowing the fallback function to receive the failed URL to build the fallback one
Related Issue

New Feature: This was extremely useful to me on my project where I have multiple federated modules and the same host with different base paths depending on the federated module.
Types of changes

[X] Docs change / refactoring / dependency upgrade
[ ] Bug fix (non-breaking change which fixes an issue)
[X] New feature (non-breaking change which adds functionality)

Checklist

[X] I have added tests to cover my changes.
[X] All new and existing tests passed.
[X] I have updated the documentation.

@ciandt-crodrigues there are some conflicts, please rebase main  branch and i'will approval this pr.

@ciandt-crodrigues I think the latest version has solved this issue, please give it a try.

@danpeen The latestest version added the same change, just did not include tests.
your call if you close the PR or not, The actual funcionatily is there now

if we do not have tests, then we should merge this. Do docs need any update?


uws needs to be registered last in EventEmitter chain of http(s) server

Under very light load, when i'm serving socket.io over SSL using uws 0.4.1 and at the same time i'm making HTTP POST (to a middleware mounted on a different path, obviously), the POST sometimes just hangs until client times out.
This is something that appeared when i replaced ws by uws - and now i'm going to check that affirmation by going back to ws on the SSL service (which is idling all day anyway).

You can only have a bunch of uws servers attached to the same https server currently. The socket gets closed so any use of it is not really going to work. Try and register the uws oaths last in the chain and see if that works.

Sounds correct, i was registering it first. Maybe this should be documented somewhere ?

Or fixed, hehehe :wink:

@kapouer Could you try the lastest uws.js?

It seems to work as it should, it's still not 100% perfect though (it doesn't track removeListener for 'upgrade' but who cares, really).

I'll give it a shot before tomorrow.

Using<EMAIL_ADDRESS>for a week, i still can see the same problem on production servers, but much less often. It seems not directly related to current load. (It is not an immediate issue for the application i'm using - it just adds a delay before retrying, that's why i can keep testing it). Maybe your latest commits already fixed this... do you think i should try them ?

I haven't done anything more with this issue. If you register uws last, then it works?
How are you using the constructor of uws.Server? What options and in what order. HTTP POST should no be affected at all, we only register to 'upgrade' event and this fix I did only solves conflicts in the 'upgrade' event chain, not in anything else.

uws first through socket.io then some express post handler.
Options are ```
noServer: true,
clientTracking: false,
perMessageDeflate: false

This is the piece registering socket.io then some other post handler:
https://paste.gnome.org/pkrbyqdq1

I'll figure a way to register the post handler first and see if that makes the problem disappear.

Nothing of what I fixed applies to you. You pass noServer, so there is no communication with any HTTP server at all. If you look in uws.js you see that most of everything is ignored when passing noServer. The only way of controlling uws with noServer is via handleUpgrade which will close the socket (it will of course take ownership of that connection). So I cannot see any relation between your HTTP POST isues and uws, it depends on how handleUpgrade is being used, but I cannot see any possibility of using it in a way that would break anything.

What is the connection, the relation, between uws and your HTTP POST server? I don't think they are related at all? Where ins the code is there any intersection between the two pieces?


Feature/#1390

What does this pull request aim to achieve? 💯
FightPandemics does not support IE 11 and older IE browsers. This pull request displays an appropriate message to notify the user as well as guide them toward updated browser downloads for IE 11 and older IE browsers. This PR resolves #1390
Please be concise and link any related issue(s):

[✅] I have checked that no one else is working on similar changes.
[✅] I have read the latest README and understand the development workflow.
[✅] The name of this branch is: feature/<branch_name>, or hotfix/<branch_name> if this is a hotfix. The branch is created in a cloned version of this repo, not a forked repo.
[✅] This branch is rebased/merged with the latest staging (or the latest production if it is a hotfix).
[✅] There are no merge conflicts.
[✅] There are no console warnings and errors.
[✅] On the right hand side of this PR, I have linked the appropriate issue(s) under "Issues" and added a project progress under "Projects".

Tested in STG, and it works fine for IE11. Please see screenshot below,
thanks.

@ashminbhandari low priority but maybe also add the Brave browser logo which uses chromium.


NUnit - Omit generating [TestFixture] attribute

Is your feature request related to a problem? Please describe.

Beginning with NUnit 2.5, the TestFixture attribute is optional for non-parameterized, non-generic fixtures. So long as the class contains at least one method marked with the Test, TestCase or TestCaseSource attribute, it will be treated as a test fixture.

Source: https://docs.nunit.org/articles/nunit/writing-tests/attributes/testfixture.html
Describe the solution you'd like
I would like to have this attribute not be generated when it's not needed.
Note, this is very low priority, it's just a nice to have, saves 1 line of code :)

Sorry this took so long - PR going in for this now 👍


collaborate thru python only

I am not sure about dockers, can i colloborate through python code developement??

@orapradeep Docker is a convenient service for installing all packages and delivering software, however, if you are not sure about using it, you can install all packages manually and run the application by python.

Thx @mrn-mln any pointers on the structure will be helpful

@orapradeep
After Cloning the repo go to  neuralet/applications/smart-distancing/
For x86 devices open config-x86.ini file and set your config.
Run the app by this script python neuralet-distancing.py --config config-x86.ini
Note: For running the app you should install needed packages/frameworks/libraries such as flask,/ tensorflow, numpy ...
Please let me know if you have any issue.

@orapradeep Thanks for your willingness, feel free to collaborate and make PR's, just mention that you need help with the dockers.


Mark java package as shipped in APIView

Send a request to mark Java package as shipped in APIView after publishing the package.

/azp run java - core - ci

This change was tested by releasing azure-template packages using pipeline run https://dev.azure.com/azure-sdk/internal/_build/results?buildId=3795795&view=results


feat: add support for psbt requests

Try out this version of the Hiro Wallet - download extension builds.

This PR to implements a new psbtRequest method on the StacksProvider which allows apps to request that the wallet sign a Partially Signed Bitcoin Transaction (PSBT). There is a supporting PR up in Connect (linked below) with changes there to expose the new request method. The request accepts a required hex of the psbt and an optional signAtIndex and allowedSighash array. If an index is not provided then all inputs are signed. A hex is returned to the app of the signed PSBT.
A Bitcoin tab has been added to the test-app to test this and to provide an example implementation. Currently, the wallet assumes the app is providing witness data in the inputs, so a public key has been provided here thru the auth response for the app to use. Again, refer to the test-app example.
Open to feedback regarding implementation, and happy to change as needed.
PR in Connect: https://github.com/hirosystems/connect/pull/308 (merged/released)

Note: branch will be broken until I install the updated changes from Connect. I just have them working locally atm.

Todo items for me here:

[ ] Refactor so wallet adds the witness data to inputs
[ ] Add fees to when the wallet handles sign and broadcast
[ ] If tx is broadcast, pass txid back to the app
[ ] Add another button to the test-app to sign and broadcast
[ ] Decode hex to show psbt data in the UI so user can verify

Please comment here if I am missing something.

Would there be a way for not broadcasting the transaction on sign? actually, without be cool to have both signAndBroadcast; and signOnly (without broadcasting)

Feedback from @orenyomtov

i see you are using txHex as a parameter name which is confusing - because it is not a bitcoin tx in hex format - but a PSBT in hex format - which is a different thing - it's not crucial, but just semantics

Feedback from @orenyomtov

i see you are using txHex as a parameter name which is confusing - because it is not a bitcoin tx in hex format - but a PSBT in hex format - which is a different thing - it's not crucial, but just semantics

Yep, I agree here, I thought the same thing over weekend but haven't had much time to work on this again yet. I will change it to just hex or psbtHex.

@kyranjamie sorry, I think this was more in a draft state before but did some refactoring/renaming if want to review now. Hoping ready to be merged. Updated the micro-btc-signer library here and the nec Connect pkgs to make this work have been released/installed as well. All seems to be working.
Note: The request option txHex was renamed to hex.
@mica000 can you review the design bc the header title needed rewording...

hey folks, why isnt signAtIndex an array also? it should, shouldnt it? In case I wanna sign more than a single input (and dont want to sign all)

hey folks, why isnt signAtIndex an array also? it should, shouldnt it? In case I wanna sign more than a single input (and dont want to sign all)

I 2nd this

LGTM!

@kyranjamie for tom, it appears I'll need to add a way here to detect if the inputs are segwit or taproot bc when we sign the inputs they have to match? So, I'll need to pass taproot key thru auth too? And, I'll have to detect it somehow before signing?

hey folks, why isnt signAtIndex an array also? it should, shouldnt it? In case I wanna sign more than a single input (and dont want to sign all)

This is easy to change, np. I just didn't realize it was what apps would want. I'll have to make a change in Connect for the signAtIndex to accept and array of numbers but an easy fix. Let me know if there is anything else. Thanks for feedback.

@kyranjamie for tom, it appears I'll need to add a way here to detect if the inputs are segwit or taproot bc when we sign the inputs they have to match? So, I'll need to pass taproot key thru auth too? And, I'll have to detect it somehow before signing?

What taproot inputs are needing to be signed? Can you elaborate on that use case? For example, how does an app know which tr address to use? Inscription could be over many.

hey folks, why isnt signAtIndex an array also? it should, shouldnt it? In case I wanna sign more than a single input (and dont want to sign all)

This is easy to change, np. I just didn't realize it was what apps would want. I'll have to make a change in Connect for the signAtIndex to accept an array of numbers but an easy fix. Let me know if there is anything else. Thanks for feedback.

Can it be an optional field that if omitted, it signs all the inputs it has the key for?

Note here, the signAtIndex request option has been changed to an array.
Change in Connect: https://github.com/hirosystems/connect/pull/310

Can it be an optional field that if omitted, it signs all the inputs it has the key for?

Yep, it is optional or we sign all.

Awesome!
Right now the confirmation dialog shows the PSBT in hex - so it's kind of like blind signing.
I'm sure you have plans to add a beautiful UI to show the PSBT - but in the meantime - it would be great if you could show a JSON representation of the PSBT.
That way it's at least readable by a power-user.
P.S. any timeline you have in mind to release this?

Right now the confirmation dialog shows the PSBT in hex - so it's kind of like blind signing. I'm sure you have plans to add a beautiful UI to show the PSBT - but in the meantime - it would be great if you could show a JSON representation of the PSBT.

That's indeed our plan, to go from hex -> JSON -> carefully crafted display of what's happening as progressive enhancements here. JSON coming up next.

P.S. any timeline you have in mind to release this?

Unless @fbwoolf is tracking anything else missing here for a v1, it seems to me that we could release on Monday.

waiting eagerly to add this to my site.  This is lit. I tested it with oren's PSBT tx. it worked like a charm.

Unless @fbwoolf is tracking anything else missing here for a v1, it seems to me that we could release on Monday.

Releasing this with the JSON would be an easy change, but decoding it and making it look nice would be for v2. The JSON would list out pretty long for the record bc Uint8Arrays will list out vertically (see image as an example from an early test).

I suppose you can take a look at what unisat does. They display it quite nicely.

@kyranjamie I feel reluctant to merge this w/out an approval from you, but I know @markmhx wants me to get it merged and create a release PR so it is ready for you all in the morning. I am going to merge this, but please feel free to revert or make changes to it off dev in your AM if feedback comes back that we need to make changes or you feel it isn't the right implementation.

FYI we have some new docs for integrating PSBTs here: https://hirowallet.gitbook.io/developers/apis/sign-transactions/partially-signed-bitcoin-transactions-psbts


Support slashes in the external identifier for the storage service

[ ] Bags API: support requesting bags that have slashes in the external identifier, both as space/A/B/C and space/A%2FB%2FC (https://github.com/wellcometrust/storage-service/pull/415, https://github.com/wellcometrust/storage-service/pull/416)
[ ] Bag register
[ ] Replica aggregator
[ ] Verifier (probably okay already)
[ ] Replicator
[ ] Versioner (I think we accounted for this already)
[ ] Root finder (probably not an issue)
[ ] Bag unpacker (probably not an issue)
[ ] Ingests API: allow sending slashes in external identifier again

This is very doable within a week.

I spotted a sticking point when looking at slashes for the storage service: we have an endpoint /bags/:space/:id/versions. How do you distinguish between a request for a work with ID :id/versions and a work with ID :id?
We could add a bunch of code for this in the bags API… or we could change that endpoint so it's /bags/:space/:id?versions instead. Or something.

The bags API problem isn't insurmountable, it just adds a bunch of extra fiddly test cases and takes more time. If we're not strongly attached to the design of that endpoint, we can simplify it (and save ourselves a bunch of time).

Chatted to Jonathan in Slack; he's happy with changing the endpoint, or forbidding external identifiers with /versions on the end.
I'm going to try both; I suspect the former is simpler from a code perspective.

We might want to tweak the way we do IDs in DynamoDB, currently it's this slightly weird space:external-id thing with URL encoding. In the staging service we can just delete all the existing ingests (which we want to do at some point anywhere); prod is harder because we need to do it in-situ. Probably turning off the unpacker for a bit and waiting for queues to drain is the easiest way.
We are declaring a new rule that external identifiers can't contain slashes.

/s/a week/a day

This is done and deployed.


Add App Insights to Building Real-World Cloud Apps e-book #3873

Fixes #3873
Added note regarding application insights to telemetry doc

@isaac2004,
Thanks for having already signed the Contribution License Agreement. Your agreement was validated by .NET Foundation. We will now review your pull request.
Thanks,
.NET Foundation Pull Request Bot

@Rick-Anderson

@isaac2004  Really great job on this. Much appreciated.

Nice work as always, @isaac2004!


Lines separating splitted terminal disappear when enable/disable menu bar

VSCode Version:
$ code -version
1.37.0
036a6b1d3ac84e5ca96a17a44e63a87971f8fcc8
x64

OS Version:
$ lsb_release -a
No LSB modules are available.
Distributor ID: Ubuntu
Description:    Ubuntu 19.04
Release:        19.04
Codename:       disco

Steps to Reproduce:

use integrated terminal at right and splited
enable and disable menu bar
the lines separating the splitted terminal disappear (see figures)

Does this issue occur when all extensions are disabled?: Yes/No
Yes

This appears to happen only when the first row of the lower split pane sits on top of the sash. I guess it's a problem with the internals of the pane not sizing correctly.

This is caused by the border-top in split-view-view from this css rule
https://github.com/microsoft/vscode/blob/2d3727b3b19538e149b51d6c3f857636076c1e94/src/vs/workbench/contrib/terminal/browser/media/terminal.css#L83-L86
which isn't taken into account when calculating the height of the terminal
https://github.com/microsoft/vscode/blob/2d3727b3b19538e149b51d6c3f857636076c1e94/src/vs/workbench/contrib/terminal/browser/terminalInstance.ts#L432
Seems there's no easy way to get that value, maybe just always subtract 1 px from the total height const innerHeight = height - bottom - 1;


Solution of Searching in a rotated array in java

Hey , I am a java programmer and I can provide you the exact solution. Kindly assign me this task.


Handle gltf case when the gltf node is both a bone and a mesh.

From Lyuma:
If a skinned mesh has a child node, we should create a virtual child node with the skinned mesh itself, and leave the original node as a plain node
this is what blender does. it calls this virtual node "Mesh_1"
_parse_meshes() reads the mesh data
The case we need to handle is: "does a skinned mesh have a child gltf node?"

Fixes: https://github.com/godotengine/godot/issues/67773

Please wait for approval from Lyuma.

Updated the PR with a similar approach but switching which "virtual" node we create.
In cases where a skinned mesh has children, we end up with two scene nodes, both nodes will represent this single gltf node.
Because blend shape animations must target the mesh, adds a separate mapping for ImporterMeshInstance3D node references.
Still needs testing. We did add the check for !gltf_node->children.is_empty() so I believe this will reduce the chance that we interfere with existing already-working GLTF documents. This should only affect cases where mesh instances have a skin and also children, as in the OP example project.

Not ready yet to merge. Still fails some test cases from godot-tests/gltf_skeleton_tests.
ERROR: Can't add child 'Skeleton3D' to 'BoneAttachment3D', already has a parent 'BoneAttachment3D'.
   at: (scene\main\node.cpp:1130)
ERROR: Unable to cast node 9 of type Skeleton3D to ImporterMeshInstance3D
   at: (modules\gltf\gltf_document.cpp:6235)

I believe we need to account for cases where a skinned mesh is its own skeleton bone, and also has children and/or part of a skeleton.

Superseded by #72158

Superseded by: https://github.com/godotengine/godot/pull/72158


brew: remove HOMEBREW_ON_DEBIAN7

This is not used anymore, we are building on ubuntu 16.04 for our portable packages: https://github.com/Homebrew/homebrew-portable-ruby

[ ] Have you followed the guidelines in our Contributing document?
[ ] Have you checked to ensure there aren't other open Pull Requests for the same change?
[ ] Have you added an explanation of what your changes do and why you'd like us to include them?
[ ] Have you written new tests for your changes? Here's an example.
[ ] Have you successfully run brew style with your changes locally?
[ ] Have you successfully run brew typecheck with your changes locally?
[ ] Have you successfully run brew tests with your changes locally?

Nice cleanup, thanks @iMichka!

Review period skipped due to critical label.

@MikeMcQuaid I forgot to merge. What happened to CI here?

Done


webview_flutter: ^4.4.4 in ios not load url

Steps to reproduce
i have below code for ios app load URL in my webview but its not load
void _loadWebUrl() {

    print("_ :${settingResponse.webUrl}");

    if ((settingResponse.webUrl ?? "").isNotEmpty) {
      showLoader(value: true);
      webController
        ..setJavaScriptMode(JavaScriptMode.unrestricted)
        ..loadRequest(Uri.parse((settingResponse.webUrl ?? "")))
        ..setNavigationDelegate(
          NavigationDelegate(
            onPageStarted: (String url) {
              DebugLog.i('Page started loading: $url');
            },
            onPageFinished: (String url) {
              DebugLog.i('Page finished loading: $url');
              isApiLoading.value = false;
              showLoader(value: false);
            },
            onNavigationRequest: (NavigationRequest request) {
              return NavigationDecision.navigate;
            },
          ),
        );
    }
  }

Expected results
some url not load in ios web view using  webview_flutter: ^4.4.4 lib but in android its load and working so what is issue in lib , I have already update this lib version and check in iOS but still its not worked , can you please check, Thank you
Actual results
must be load url using webview_flutter: ^4.4.4 lib in ios device
Code sample
Code sample
[Paste your code here]

Screenshots or Video

Screenshots / Video demonstration
[Upload media here]

Logs
Logs
[Paste your logs here]

Flutter Doctor output
Doctor output
[Paste your output here]

Hi @anilthummar, kindly share the link and a full sample so that we can properly investigate this. Please also check with some webview apps on the App Store to see if they're able to open the link. If they cannot open the link, then this is not an issue with the plugin.
Thank you

Hi @anilthummar, kindly share the link and a full sample so that we can properly investigate this. Please also check with some webview apps on the App Store to see if they're able to open the link. If they cannot open the link, then this is not an issue with the plugin.
Thank you

Thank you @danagbemava-nc  for your reply,
I have used the below URL to load in web view as per I have mentioned web_view_flutter lib
Url I have used to load in ios device -https://jpstaging.usgme.club/
Thank you so much

Hi @anilthummar, the version of webview_flutter you're using is old. Please upgrade to the latest version (4.10.0) to see if you still experience this issue.
If you do, please also provide the version of [webview_flutter_wkwebview](https://pub.dev/packages/webview_flutter_wkwebview) from your pubspec.lock.
Thank you


fix(tabs): fix ink not showing on chrome 57

The ink bar was positioned absolutely in a display flex element, which no longer plays nice in Chome (beta, v 57). Moved the ink bar out of the display flex element. Also fixed issue for the nav bar, which did not always show the ink bar on first render.

I am using  "@angular/material": "^2.0.0-beta.3", which is the latest nom pulled .
My html looks like this
<md-toolbar>

    Home

</md-toolbar>

And here is how the tab is being rendered

Can you please tell me what am I doing wrong or this is still an issue that team is working on?

I am using  "@angular/material": "^2.0.0-beta.3", which is the latest nom pulled .
My html looks like this
<md-toolbar>

    Home

</md-toolbar>

And here is how the tab is being rendered

Can you please tell me what am I doing wrong or this is still an issue that team is working on?


Search should be accents-insensitive

If you index some page with accents like computación and search for it without accents (ie, computacion), the page doesn't get listed as a result.
We should make LunrJS insensitive to that.
See olivernn/lunr.js#16

After some experiments to include stemmers for different languages from https://github.com/MihaiValentin/lunr-languages, which are now in branch i18n, I opted for allowing the user to customise the pipeline, since lunr-languages was designed to handle a single language (as far as I understood).
Commit a58f1dbe623aeb7fa6d174c5b20766e4dc78bf09 on version 0.3.0 allows the user to inject a custom function like the following, that will keep all English based stemmers, but ignore accents when indexing and performing searches:
search.pipeline = {
    tildes: <<-JS
      function(token, tokenIndex, tokens) {
        return token
          .replace('á', 'a')
          .replace('é', 'e')
          .replace('í', 'i')
          .replace('ó', 'o')
          .replace('ú', 'u')
          .replace('Á', 'A')
          .replace('É', 'E')
          .replace('Í', 'I')
          .replace('Ó', 'O')
          .replace('Ú', 'U');
      }
    JS
  }


Marvel Heroic Roleplaying minor update mhrpg.css

Changes / Comments
increase size of input boxes for numbers
Roll20 Requests
Comments are very helpful for reviewing the code changes. Please answer the relevant questions below in your comment.

[x] Does the pull request title have the sheet name(s)? Include each sheet name.
[ ] Is this a bug fix?
[ ] Does this add functional enhancements (new features or extending existing features) ?
[ ] Does this add or change functional aesthetics (such as layout or color scheme) ?
[ ] If changing or removing attributes, what steps have you taken, if any, to preserve player data ?
[ ] If this is a new sheet, did you follow Building Character Sheets standards ?

If you do not know English. Please leave a comment in your native language.

Character Sheet Info Roll20 Internal Use only.


[SPARK-42115][SQL][PYTHON] Push down limit through Python UDFs

What changes were proposed in this pull request?
This PR is a followup of https://github.com/apache/spark/pull/37941 that proposes to enable pushing down the limit through Python UDFs by disabling PushProjectionThroughLimit if it has Python UDF.
from pyspark.sql.functions import udf

spark.range(10).write.mode("overwrite").parquet("/tmp/abc")

@udf(returnType='string')
def my_udf(arg):
    return arg

df = spark.read.parquet("/tmp/abc")
df = df.limit(10).withColumn("prediction", my_udf(df["id"])).explain()

Before:
== Physical Plan ==
CollectLimit 10
+- *(2) Project [id#3L, pythonUDF0#10 AS prediction#6]
   +- BatchEvalPython [my_udf(id#3L)#5], [pythonUDF0#10]
      +- *(1) ColumnarToRow
         +- FileScan parquet [id#3L] Batched: true, DataFilters: [], Format: Parquet, Location: InMemoryFileIndex(1 paths)[file:/tmp/abc], PartitionFilters: [], PushedFilters: [], ReadSchema: struct<id:bigint>

After:
== Physical Plan ==
AdaptiveSparkPlan isFinalPlan=false
+- Project [id#3L, pythonUDF0#10 AS prediction#6]
   +- BatchEvalPython [my_udf(id#3L)#5], [pythonUDF0#10]
      +- GlobalLimit 10, 0
         +- Exchange SinglePartition, ENSURE_REQUIREMENTS, [plan_id=35]
            +- LocalLimit 10
               +- FileScan parquet [id#3L] Batched: true, DataFilters: [], Format: Parquet, Location: InMemoryFileIndex(1 paths)[file:/tmp/abc], PartitionFilters: [], PushedFilters: [], ReadSchema: struct<id:bigint>

Why are the changes needed?
To restore the performance issue. This is a regression in the master branch.
Python UDF is very slow, and it is executed asynchronously and process data in batch. So, regardless of the parent limit, Python UDF at least processes one batch (e.g., one Arrow batch) which can potentially cause performance regression especially in a workload like machine learning.
Does this PR introduce any user-facing change?
Restore the performance.
How was this patch tested?

Closing it in favour of https://github.com/apache/spark/pull/39842


Implement web accessibility

Test the website with assistive technologies: Test the website with assistive technologies, such as screen readers or keyboard-only navigation, to ensure that it is accessible to people with disabilities.


feat: add a docker image for reproducible game extraction

I tried the setup.py but had some errors and wasn't sure if they were just warning.
This is a docker image for replicable extraction of game data.
In order to use it (replace variables if needed):
GAME_FOLDER="$HOME/PlayOnLinux\'s\ virtual\ drives/Fallout2_gog/drive_c/GOG\ Games/Fallout\ 2/"
OUTPUT="/tmp/"

docker build . -t darkfo:extractor
docker run -v $GAME_FOLDER:/game/ -v $OUTPUT:/output/ -ti darkfo:extractor

For reference, this is the output on my machine https://gist.github.com/Allsimon/bcd31c5bbce9589ab993c134671c3ab3

Were the errors you got locally different from the ones in the gist? What were they?
The python scripts should run on any machine with a standard Python/pillow+numpy installation, if it doesn't then that would be a bug.
Some errors are going to be present (I guess this should be noted in the README) because not everything is 100% supported (though most is, hence only a few fail.)

Haven't heard back on this so closing for now. The standard python script should work out of the box on any platform, if not those are new bugs.


ItemsAdder (CustomModelData) Support

Can you add support to ItemsAdder custommodeldata items?

This feature is currently being developed and will be present in the next update (No ETA for that though)


Improve liquid auto complete

Refactor liquid autocomplete
Remove nearly bawed grammar and introduce liquidjs tokenizer
Added autom complete support for multiple tags and objects, includnig properties and records
Added OOB liquid snippets to simplify writing liquid
Added support for auto completion of portal specific filters

Add telemetry after discussing with @ashishchoudhary001

Also, check the file name casing - its inconsistent for new files and folders


Add integration sanity tests for Rails

At the time of writing, we run our e2e test flows on test apps in Node and Python (Flask). We should expand coverage to include more frameworks (since different web frameworks occasionally use libc/syscalls in different ways). Please implement the existing tests for a basic Ruby on Rails app.

Just curious, since Flask was used instead of Django for testing Python, I'd love to learn more about the choice between Rails and Sinatra for Ruby. Thanks!

No real reason, we just figured Rails is more popular. We'd welcome Sinatra tests just the same.
The Flask choice was for a different reason - some users ran into issues with it specifically.

Got it. Thanks for the clarification!


drm: behavior relative to "rm -rf"

I will note that the docs for drm say "behaves like rm -rf", but that doesn't seem quite correct . . .  For plain old rm, the docs say the following:
"-f: Ignore nonexistent files and arguments, never prompt"
However, I am seeing that drm errors out on nonexistent arguments, i.e., if I type:
drm file1 file2,
and file1 doesn't exist, then file2 is not removed, which is . . . painful.  Is this intentional, or ???  Thx

Looks like the walk returns on the first error
https://github.com/hpc/mpifileutils/blob/0a4c530bca5dc2476418a3833a15ab812d636e78/src/common/mfu_flist_walk.c#L432-L437
Not immediately sure the best way to handle this since I think several utilities share this function


Refactored tasks files from project & core

This is regarding #3775.
Moved the mentioned tasks from projects/tasks.py to core/tasks.py.
Also made some changes in docs, tests & a few other files where the call was being made to projects/tasks.py.
Please have a look and let me know if something is wrong.

Thanks for taking a swing at this! I think we may have missed an opportunity to talk about this first, so we likely sent you down the wrong path. Hold up on changes here for now, I've raised issues in the underlying ticket for this PR.
A few other things:

Moving code and altering code makes this near impossible to review, so it might be best to split up the work to refactor that location with a separate PR with the code changes you applied. Alternatively, you can move code in one commit and change code in another commit, and mention that on the PR.
Tests appear to be broken, but I'd wait on more guidance on the underlying ticket before continuing to resolve the errors here, as reverting this will require more code changes

Deleted the branch as there was a lot of mess in the files. Created another branch to make changes as suggested.


Idea/suggestion for PoC - Collecting and structuring metadata with AI

Description
In order to gain interoperability between different platforms and solutions, we need good metadata about the data used in a service. This job with data classification and populating the data catalogues on data.norge.no has been lagging behind for years.
Could a simple AI application feed on raw data an achieve a >80% coverage on a dataset in the data-catalogue that could raise coverage and data quality in order to stimulate to data-driven services in A3, and with a more runtime approach to the data-registries at data.norge.
As a starter this could be done with data managerd/owned by digdir that is not yet described in FDK. If the case is valid, this approach could be used in mapping and compiling other metadata-classes that we dont have general overview on like for instance processing of personal data (could be scraped from the "personvernærklæring"), in order to create cool personal data management applications.
Additional Information
https://data.norge.no/
Reports that may be relevant in the regard of this case:
https://www.regjeringen.no/contentassets/0e36c85fcfe143a5b626c53cf292cb3b/altinns-innspill-vedlegg-1---konseptet-digitale-meg-2019.07.05.pdf
https://www.digdir.no/datadeling/innsynslosning-tekniske-og-juridiske-muligheter/3465
https://www.digdir.no/digital-samhandling/konseptskisse-realisering-av-en-innbyggerorientert-digital-assistent/2949

Ref. Datatilsynets rapport om co-pilot hos NTNU så er vel denne lett reaktualisert?


feat: add useLazyLoad hook

:tada: This PR is included in version 5.1.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


bpf: really only enforce bind rejection when in hostns

See commit msg.

test-me-please

test-me-please

Coverage increased (+0.04%) to 44.687% when pulling 63b1ea37e38c8522af368e128687124665cddbe9 on pr/bpf-host-lb-bind-fix into c0ef36f6e9c93f83aa2cf2a5e180c2910093f4c0 on master.


bypass java

The YARN REST API appears complete enough that, if we can use hdfs3 to manage file-based resources (i.e., a minimal python) and create tokens, the client and AM could both be completely python, but still be able to successfully manage delegation tokens (including their renewal)

This would be great.  Was this added recently?

Yes, this is a new idea. I don't yet know how much effort it would be, but certainly a rewrite of the current code. For the client portion, probably not too hard, and the AppMaster can maybe stay scala, since it necessarily lives on a cluster node.
The critical question is whether the kerberos support in hdfs3 is good enough for all circumstances. It might be simpler than trying to write a token-renewer service in scala. Simpler for me, that is.
If doable, it would also enable starting yarn jobs from off-cluster (if hdfs/kerberos is configured to allow that). Containers could probably not reach a dask scheduler running outside the cluster, so this idea raises a few open questions.
I should probably mark this issue as "abstract thought"

Lets ping @quasiben and @mariusvniekerk

The protobuf rcp defs that would need to be used by a python AM.

More details on the phases of this general goal, each with increasing uncertainty:

the current implementation calls the YARN CLI executable in a few places; these can certainly be replaced by HTTP calls, or, for logs-after-completion, directly on hdfs
the client java process currently launches and stays active; it should be closed after launching the AM, since the functions can either be done by HTTP (get status, kill) or by talking to the AM (add/remove containers)
the client process basically just instructs YARN to launch the AM; this can be done by HTTP with a JSON blob giving the AM spec, and hdfs3 upload of files. As I understand, this will work on unsecured clusters, or if writable HTTP access has been enabled (don't know if this is typical). Note that, if authorised, can access tokens, including renewal, over HTTP, and tokens give access to HDFS. Also, HDFS tokens probably give same access and hdfs3 can make them if its own SASL problems are ironed out.
the AM could be python rather than java, but it need to talk protobuf RCP as opposed to HTTP: so the SASL mechanism on the RCP channel needs to implement all possibly security that we might come across. If that auth mechanism is "token", perhaps it's simple?


Unable to remove REST and SOAP resource

The user is currently unable to remove both SOAP and REST resource when marking multiple resources that the user want to remove.

Issue has been resolved


x/net/idna: context validation

What version of Go are you using (go version)?

$ go version
go version go1.11.5 linux/amd64

Does this issue reproduce with the latest release?
Yes
What operating system and processor architecture are you using (go env)?
go env Output
$ go env
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOOS="linux"

What did you do?

I wrote an example to convert a-label to u-label an viceversa and also perform IDNA2008 validation based on the provided a-label.
I checked the results with other IDNA tools and found that with net/idna I am not getting context errors that other libraries are reporting.
Here is the main code of the example:
func main() {
	p = idna.New(
		idna.BidiRule(),
		idna.MapForLookup(),
		idna.StrictDomainName(true),
		idna.Transitional(false),
		idna.ValidateForRegistration(),
		idna.ValidateLabels(true),
		idna.VerifyDNSLength(true))
	alabel := os.Args[1]

	ulabel, error := p.ToUnicode(alabel)
	if error != nil {
		fmt.Printf("Error converting string: %v\n", error)
		os.Exit(1)
	}
	fmt.Println(alabel,ulabel)

	convertedAlabel, error := p.ToASCII(ulabel)
	if error != nil {
		fmt.Printf("Error converting string: %v\n", error)
		os.Exit(1)
	}

	if convertedAlabel != alabel {
		fmt.Printf("Provide a-label doesn't match converted a-label: %v\n", convertedAlabel)
		fmt.Println(convertedAlabel)
		os.Exit(1)
	}

}

Here are some label examples:
xn--diethealth-zp5i
xn--diy-ps4bb
xn--pfs-ps4bb

Can you please confirm if this is missing validation of IDNA2008?
Could it be possible to include one new method/flag to get full IDNA2008 validation with the function?
What did you expect to see?
Here are the errors reported for 2 other idna utilities:
 xn--diethealth-zp5i,string contains a forbidden context-o character,Codepoint U+30FB not allowed at position 5 in 'diet・health'
  xn--diy-ps4bb,string contains a forbidden context-o character,Codepoint U+30FB not allowed at position 2 in 'd・i・y'
  xn--pfs-ps4bb,string contains a forbidden context-o character,Codepoint U+30FB not allowed at position 2 in 'p・f・s'

What did you see instead?
xn--diethealth-zp5i diet・health
xn--diy-ps4bb d・i・y
xn--pfs-ps4bb p・f・s

/cc @mpvl, @vdobler

I would like to add another case of what appears to be a false negative (xn--03c4b1a). The program is reporting:
Error converting string: idna: invalid label "ิรืเ"
Other IDNA utilities successfully convert a-label to u-label an viceversa

@elmauromx can you confirm that this same issue happens on the latest version of Go? It looks like you are running on go1.11.5.

@katiehockman . It is the same behavior with go1.12.1 for the first case reported:
$HOME/go/bin/go version
go version go1.12.1 linux/amd64
xn--diethealth-zp5i diet・health
xn--diy-ps4bb d・i・y
xn--pfs-ps4bb p・f・s
For xn--03c4b1a it is working good on the new version:
xn--03c4b1a รืเ

Hi. Any update on this?

Is there any update on this? Any plans to fix it?

@mpvl have you had a chance to look into this? Or is there another person that can investigate?

FYI, calling idna.Transitional(false) is bugged; internally the flag is set to true regardless of which boolean value you pass. The only way to get false is to not call Transitional() at all.
Permalink to the method in current master; the method takes transitional bool, but the body of the function is o.transitional = true instead of o.transitional = transitional.

I looked into this. For now, the idna package implements UTS 46, which has no CONTEXTO requirement – though CONTEXTJ checks are widely deployed. We could certainly add a flag for CONTEXTO support though, for registration profiles. Here's what icu4j's documentation says about CONTEXTO:

This is for use by registries for IDNA2008 conformance. UTS #46 does not require the CONTEXTO check.

Fixed by https://golang.org/cl/360381.

Maybe fixed? Is the issue here just that idna.Transitional(false) didn't work (now fixed), or is there something in addition to that? I thought the former, but rereading the comments I'm no longer certain.

https://golang.org/cl/360381 only fixes part of the bug. The original bug here is the lack of CONTEXTO support, which is not yet added, and which should only be used for the Registration profile. Adding CONTEXTO support essentially means implementing the restrictions in Appendices A.3–9 in RFC 5892.
Notice that we already support CONTEXTJ through CheckJoiners, which is enabled by both ValidateForRegistration and MapForLookup (through ValidateLabels).


adb: error: failed to get feature set: more than one device/emulator

[x] I have read the FAQ.
[x] I have searched in existing issues.

Environment

OS: [Windows]
scrcpy version: [e.g. 1.13]
installation method: [Windows Zip]
device model: Samsung Galaxy S10
Android version: [10]

I read somewhere that adb.exe stays running in the background when you close your session. However It's preventing me from starting a new session until i close out of adb.exe from task manager.  I never had this issue back on version 1.12, so I wanted to bring it up here.
The only way I can get the session started is by going to task manager and manually ending the adb.exe process and starting fresh.
Does anyone know a fix to this?
INFO: scrcpy 1.13 <https://github.com/Genymobile/scrcpy>
adb: error: failed to get feature set: more than one device/emulator
ERROR: "adb push" returned with value 1
Press any key to continue...

Please do not post screenshots of your terminal, just post the content as text instead.

adb: error: failed to get feature set: more than one device/emulator

What is the result of adb devices?

This is the result.
List of devices attached
R58******GV     device   (my Android)
emulator-5566   offline

Then you have 2 devices listed (including an emulator).
You must pass the serial of the device (like for any adb command):
scrcpy -s R58******GV

Thank you, That did the trick. I was used to opening scrcpy from the .exe in the folder. Now I'll just have to open up cmd and type what you suggested (after navigating to the folder that is) and get there the old fashioned way.
I wonder what the emulator-5566 device is and why it starts up when I freshly open up scrcpy.exe.


Ideation added Primal Rage

Issue #436
@TusharAMD pls check and merge

@TusharAMD for writing ideation of game, how can one classify as plagiarized. When I am referring to the internet for details of the game and am trying to provide all necessary details in the readme for anyone who wants to work on it. Since I am obviously not the creator of the game, how will it be considered plagiarism?


Update index.md

[x] I have read freeCodeCamp's contribution guidelines.
[x] My pull request has a descriptive title (not a vague title like Update index.md)
[x] My pull request targets the master branch of freeCodeCamp.
[x] None of my changes are plagiarized from another source without proper attribution.
[x] My article does not contain shortened URLs or affiliate links.

If your pull request closes a GitHub issue, replace the XXXXX below with the issue number.
Closes #XXXXX

Hi @sahishnu
It seems that similar changes have already been accepted earlier for this article you're editing, sorry about that. 😓
If you feel you have more to add, please feel free to open up a new PR.
Thanks again! 😊

If you have any questions, feel free to reach out through Gitter or by commenting below. 💬


Unexpected setCurrentX behaviour

setCurrentX() does not behave as I expected when using report.print(). Instead of setting the x position for the next print, it is still aligned to the left of the page.
    rpt.setCurrentX(300)
    // does not print at x: 300
    rpt.print("test1")
    // prints where expected at x: 300
    rpt.print("test2", {x: 300})

I'm unsure whether this is by design, but it was not what I initially thought would happen when trying to create 2 columns of information in my header.

You are correct; this setCurrentX is being overridden as the print function starts.   I'll have to look into why this change was put into place and see if we have to leave it or if we can remove it safely.  :grinning:

This unexpected behavious doesn't only happen with print, but in general. The only way for me to display data dynamicaly over the x-axis of the report is to use the above "solution". Using setCurrentX([new coordinate]), addX([amount]), or currentX([new coordinate]) does not work at all for the display of data. It does however work for drawing a box.

We might need to add a flag to respect the last currentX location to the print routine. Would that be an acceptable solution?

Unfortunately print and band are special cases where they need to typically start at the left most margin for consistency, since they will follow other commands frequently; we want the
.print("1")
.print("2")

to be laid out properly on two lines at the left most column without any other changes....
So to handle you leaving print where it is at print now has a new option: useCurrentX: true to use the existing current X value; so you can pass that in now instead of using the {x: 300}...


Ban hash signs and delimiters in state names

As argued here, state names should not contain delimiters . (confuses hierarchical states with a single state with a delimiter in its names) nor hash signs # (confuses state names with IDs).
Optionally, ban white space too.
Optionally, ban wildcards * (no good reason to support this).
Options (with defaults)

camelCase: [a-zA-Z0-9] - default
PascalCase: [a-zA-Z0-9]
snakeCase: [a-z0-9_]
: [-a-zA-Z0-9_:]
allowUnicode: false
allowWhitespace: false
allowWildcard: false

:tada: This issue has been resolved in version 0.5.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Trying to get a 413 results in an empty message

Laravel Version
11.26.0
PHP Version
8.3.12
Database Driver & Version
Postrgres 15
Description
When trying to handle a 413 error, thrown by the ValidatePostSize middleware like described here does not seem to work.
https://laravel.com/docs/11.x/errors#customizing-the-exception-response
It appears that the session is not started (yet).
Steps To Reproduce
Create a handler for a 413 error response like https://laravel.com/docs/11.x/errors#customizing-the-exception-response
Post a huge file to a form. No error is shown.

Created a small reproducer
https://github.com/parijke/laravel-test-session-exception

Don't see that the reproducing repository uses ValidatePostSize? https://github.com/search?q=repo%3Aparijke%2Flaravel-test-session-exception ValidatePostSize&type=code

It uses it under the hood. The PostTooLargeException is throw by it

https://github.com/search?q=repo%3Alaravel%2Fframework PostTooLarge&type=code
PostTooLargeException is only thrown frommValidatePostSize middleware. This middleware is not included by default, so unless your applicate explicitly append this it will not be used in your application.

Hey @crynobone, I also think it is included by default in the global middleware stack:
https://github.com/laravel/framework/blob/bc5bd660b0a3079e3fb7f392bfac06e41d80b64b/src/Illuminate/Foundation/Configuration/Middleware.php#L403-L419

@parijke could you also check if your web server has a restricting limit for post / file size in the php.ini or the nginx configuration:

upload_max_filesize
post_max_size

The issue is not that I cannot set those values. The issue is that I cannot create a decent user message becase the session is not started yet, while the documentation says this should be the way

My bad @Jubeki @parijke
ValidatePostSize should be executed earlier than other middleware because if it does exceed max_post_size all values from $_POST and $_FILE  superglobals will be missing. It seems like the example in the documentation is only useful for any exception occurs after StartSession middleware.

The session is not started, because the session start is in the web group.
First run the global middleware and then the web middleware. Because ValidatePostSize runs before Starting the Session, the session of course is not started yet.
Can you show me, where in the docs it says, that the session is already started?

It doesn't state in the docs that it is started... it is implicitly because of the 419 example in the docs.
My point is if it should be considered to start a session before the ValidatePostSize middleware, as the post is almost certainly a user action?

A session is only used for browsers with cookies. You don't want to start a session, if you use for example API-Tokens, which are stateless.
That is the reason for the web and api middleware groups. global always run, the other depending for who the endpoint is intended for.

That sounds reasonable... not sure how to handle this into a form validation then. Any ideas?

Did you try catching Illuminate\Http\Exceptions\PostTooLargeException inside the render/report method? This is the exception which will be thrown by the middleware and probably be converted into the error page and status code 413.

@Jubeki Maybe I misunderstand, but this is in the same WithExceptions in the app.php, isn't it? Therefor, still no session is available to set the errors on.
Or do I mis the point here?

Sorry my bad, I now understand, that you want to write data to the session, a validation error, or another message. Yeah that is not possible in that way.
You could of course catch the PostTooLargeException then Start the Session manually, but this would be quite a workaround and I am not sure if that would be the best way to achieve your desired behaviour. (I am not sure how you start the session manually, but taking a look into Illuminate\Session\Middleware\StartSession could be worth while. You also have the option to write your own ValidatePostSize Middleware.


Add support for Makefile as build script and make as build tool

Makefile is often used as a generic build tool. In fact, Macaron itself uses Makefile to generate artifacts. We already have support for a number of build tools.
To support Makefile

we need to add a parser for Makefile to extract shell commands, similar to our bashparser.
add a new module for make similar to other build tools.

I poked around a little, and here are a few references. First off, It would be tricky to write a grammar for make, since the grammar is extremely context-dependent. (thread, similar questions here or especially here).
Having said that, I found the following attempts to come up with a Makefile grammar:

https://github.com/Icraus/MakefileGrammar
https://github.com/grammarjs/makefile (requires other repos from the same org)

It might also make sense to explore existing syntax highlighters like Pygments which support at least Makefile lexers.
@behnazh-w given a Makefile, it looks like you’re interested in extracting the Recipes from it?

@behnazh-w given a Makefile, it looks like you’re interested in extracting the Recipes from it?

Yes exactly. Our ultimate goal is to find shell commands that invoke build tools. For now we can limit the Recipes to bash scripts.


update hack/prepare-supervisor-on-kind.sh for GitHub IDPs

Release note:
NONE

merging without CI since this is only changing a hack script


Install without PGroonga fails

After #9506 unconditionally added CREATE EXTENSION pgroonga; to scripts/setup/postgres-create-db, and #12029 enabled ON_ERROR_STOP, the installer now fails when PGroonga is not enabled.
+ su postgres -c 'psql -v ON_ERROR_STOP=1 -e'
CREATE USER zulip;
CREATE ROLE
ALTER ROLE zulip SET search_path TO zulip,public;
ALTER ROLE
CREATE DATABASE zulip OWNER=zulip;
CREATE DATABASE
You are now connected to database "zulip" as user "postgres".
CREATE SCHEMA zulip AUTHORIZATION zulip;
CREATE SCHEMA
CREATE EXTENSION tsearch_extras SCHEMA zulip;
CREATE EXTENSION
CREATE EXTENSION pgroonga;
ERROR:  could not open extension control file "/usr/share/postgresql/9.5/extension/pgroonga.control": No such file or directory

Zulip installation failed!

The install process is designed to be idempotent, so you can retry after resolving whatever issue caused the failure (there should be a traceback above). A log of this installation is available in /var/log/zulip/install.log

@timabbott said:

OK, here are some conclusions:

Those lines were added in 8bf80f699f3ad937b681ec10b1952d2740997546
That was buggy in that they should have been conditional on whether we want pgroonga (we do for that Dockerfile)
It didn't cause a user-visible problem until we merged the ON_STOP_ERROR stuff.

We should just page Dockerfile-postgresql pass a INSTALL_PGROONGA type argument and check that for whether to run the CREATE EXTENSION code.  We don't need to run it except for the Docker postgres image.

@andersk do you have time to take care of this? We generally like to keep master installable from Git, which I think this breaks.  In any case adding the release blocker tag.

#12792 fixes this.


self is has unresolvedReference semantic token when using async-trait

Given this code:
#[async_trait::async_trait]
trait Foo {
    async fn foo(&self);
}

struct Bar {
    x: usize,
}

#[async_trait::async_trait]
impl Foo for Bar {
    async fn foo(&self) {
        let y = self.x;
        //      ^^^^ unresolvedReference
    }
}

self is marked as an unresolvedReference
However, type inference does appear to work, and we can see inlay hints display:

async_trait rewrites self accesses to use a new local __self, so our downmapping infra seems to break down here somewhere(as the attribute does properly set the spans for these).


Register package

@JuliaRegistrator register

@JuliaRegistrator register

Registration pull request created: JuliaRegistries/General/4577
After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.
This will be done automatically if Julia TagBot is installed, or can be done manually through the github interface, or via:
git tag -a v0.1.0 -m "<description of version>" 7e350472bfa4b9b8a4c7596c5b208c1a6da1c473
git push origin v0.1.0

@JuliaRegistrator register

Registration pull request updated: JuliaRegistries/General/4577
After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.
This will be done automatically if Julia TagBot is installed, or can be done manually through the github interface, or via:
git tag -a v0.1.0 -m "<description of version>" 0c3c0d82d0d71a4b439ba67e88fec48bf249445b
git push origin v0.1.0


Improve regex definition for the  validate_user function

Regex function has been modified to insure that username starts
with a letter.
The function has been simplified as the new regex can replace them
Test case has been added to prevent username from starting with a
digit
Doctest is used to validate the function against test cases
Closes: #1
Fixes #<issue_number_goes_here>

It's a good idea to open an issue first for discussion.

[ ] Tests pass
[ ] Appropriate changes to README are included in PR

No comment

@googlebot I signed it!