Add windows CI through Appveyor

#479 Was closed from some CI issues, reopening for comment.
The project will likely need to be activated by maintainers at https://ci.appveyor.com/projects
Also, it would be nice to have a status badge from https://ci.appveyor.com/project/docker/swarm/settings/badges added to the readme as well.

Coverage remained the same at 39.31% when pulling 6b1239b6d5556cb6c7de307b9e7265789065b979 on weswigham:patch-1 into b655cbb7c5acadd009410e37cee9dc4e64ac5e8c on docker:master.

Thanks @weswigham !
So we are actually thinking of using Docker's Jenkins infrastructure at https://jenkins.dockerproject.com/
There are already runners for both Linux and Windows therefore we would use the same CI configuration for both platforms.
Thoughts?

Depending on the tests ran in the CI, something like AppVeyor could just suffice. e.g. Distribution project right now uses CircleCI because it's simply bunch of unit tests with "go test ./..." and various other checks. Docker itself on the other hand requires far more complex environment to run the tests amd they take long. Core Maintainers can explain better why they switched from Drone.io to hosted Jenkins.

@ahmetalpbalkan We are actually already using Jenkins (https://jenkins.dockerproject.com/job/Swarm Master/) to run our integration test suite.
It launches docker engines to try out swarm with a real engine/CLI, just like integration-cli of Docker.

@aluzzardi I see now. Several questions to evaluate before testing on Windows:

Why are we testing Swarm on Windows?
Will swarm cli (e.g. join or manage) be supported on windows (can't see any reason why it should be until windows docker engine lights up)
What sort of tests are valuable on windows (eg in docker core we only run integration-cli on windows and many parts solely testing the engine in that suite is skipped in windows b/c there's no value —windows right now is a cli-only platform like Mac).

You should probably run tests on Windows simply because swarm manage functions on Windows pretty well already. It's probably not worth risking regressing what functionality you already have.

Upper left: swarm manage running on a windows host, upper right: docker daemon running on a linux host in the cluster, bottom: local windows machine running docker cli
I'm not sure why docker engine would actually be required. As far as usefulness goes, I'm pretty sure that compose and machine both run in Windows already, and there's certainly a use case, as a developer, to want to spawn up a bunch of containers in VMs using machine and/or compose and then use swarm to mask them all to my local (windows) box.

@weswigham I guess it really comes down to if maintainers want to have Windows as a supported platform to host Swarm Manager. If that's the case, I believe tests for Swarm include creating a cluster: which is forming a cluster of actual docker engines in the same machine (which don't work on Windows).
For testing Docker core on Windows, we have Windows CI boxes on Jenkins, running the integ-cli tests and they talk to a pre-configured Docker engine living on some other machine, exclusively dedicated to that Jenkins box. So for each Windows Jenkins machine we have a Docker engine sitting on some other machine independently. Problem with that is, somebody has to refresh engine binaries periodically because they don't get built along with the PR submitted itself.

My opinion is, right now, there's not much point in making Swarm Manager supported on Windows (as it'd be weird if people host their slaves on Linux and manage them on a Windows Server). Theoretically, this will definitely be useful when the Docker Engine for Windows comes up.
I believe there hasn't been any specific work or fixes taken to support Swarm on Windows. It just works simply because it doesn't depend on the operating system and is a cross-compiling Go program. Therefore it's less likely to regress or will be easier to fix when it does actually regress.
If you just want to make sure the compilation does not break on Windows, yeah it makes sense to have a CI with AppVeyor, however without running the integration test suite on windows, I don't think we actually gain a lot from that CI.

@ahmetalpbalkan for the "why", I have no idea :) I was just questioning the usage of Appveyor versus our existing Jenkins. The usefulness of running those tests is still questionable.
Unrelated to this PR: For the integration-cli stuff and stale binaries, we have kind of a solution for that. Basically, we run our integration tests against a Docker engine running as a container within a Docker.
We have docker-in-docker images for every release of docker since 1.0.0 (https://hub.docker.com/u/dockerswarm/dind) and also docker-in-docker images for the master branch of docker that gets rebuilt at every merge (https://hub.docker.com/u/dockerswarm/dind-master).
However those are not built along the PR, but it's close enough.

@aluzzardi Yes I'm aware of the library/docker effort. It might help a bit but the main problem with running the integ-cli tests for Windows CLI is most tests were relying on the fact that engine was running in the same machine, I had to send around 50 pull requests to clean that up and make most of it work against an engine running on a different host.
One solution to that might be running Boot2Docker on the Jenkins Windows machine, compiling docker (from PR) in there and making Docker CLI talk to Docker engine built from the same source code on the same machine (living in a b2d VM). But then another problem comes up: Jenkins machines are actually VMs on some cloud provider and VMs can't run VMs. :)

@ahmetalpbalkan How about building the Docker image as part of the Windows testing process and then running the integration-cli against a docker-in-docker?

@aluzzardi makes sense. In this case, the test runner must coordinate delivering this image to the engine running on a remote machine. And yes, dind help in this case. cc: @jfrazelle would be interested in this.

@ahmetalpbalkan If the cli supports build, then we could leverage that.
DOCKER_HOST=linuxbox
docker build -t integration-cli:$(UUID or something) -f Dockerfile.integration .
docker run integration-cli:$(THAT SAME UID) -p <doceker port>:<some random port> docker -d [...]
DOCKER_HOST=linuxbox:<that random port>
[run cli commands]

Yes windows CLI can build docker's Dockerfile.

As an aside, assuming that integration tests (and not just unit tests as this PR would have brought) can start getting run under windows, would the swarm integration tests need to be remade in a crossplatform manner, much like docker core's integration-cli?

just as an fyi, we're using appveyor to run compose unit tests on windows, and to build the windows binary: https://ci.appveyor.com/project/docker/compose
It has worked well for us so far.


Php 8

Can this be merged? Other things like #43 half-depend on this.

https://github.com/EdwinHoksberg/php-fcm


fix: Add smoothing values as props & Fix inaccurate linear value points

Add smoothing values as props in order to manage the values.
Fix inaccurate points when the min & max values are the same (if the points have all the same values).

@chrispader It seems this PR collided with my PR #43 that also added prop for customizing pan gesture timeout.


Move Remote app session state snippets to project in samples folder

Fixes #28549
Because the changes are small this PR contains the changes for each task in the linked issue.

Internal previews

📄 File
🔗 Preview link

aspnetcore/migration/inc/remote-session.md
Remote app session state

aspnetcore/migration/inc/session.md
ASP.NET to ASP.NET Core incremental session state migration

aspnetcore/migration/inc/wrapped.md
Wrapped ASP.NET Core session state

Awesome work @timdeschryver

1 more commit to move up to 84th place
@timdeschryver


Disscuss about hash algorithm in message queue selector.

What is the purpose of the change
Hash algorithm with hashmap of Java 8  is better, algorithm  is  hashcode ^ (hashcode >>> 16)
Brief changelog
Hash algorithm with hashmap of Java 8  is better, algorithm  is  hashcode ^ (hashcode >>> 16)
Verifying this change
XXXX
Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

[x] Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
[x] Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
[x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
[x] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
[x] Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test  to make sure integration-test pass.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

Coverage increased (+0.009%) to 50.641% when pulling d75de68f7d728004c30cca2a2c9bd246dc54f39c on xiaobing395845388:master into 40c255d6b55b03fbff8cd7c1d78af6f5edcab5fa on apache:master.

Could you please move this PR to develop branch?

Could you please move this PR to develop branch?

allready moved PR to develop branch  , in  #1269

See #1269


Window doesn't resize

After using QS on a high resolution monitor (and resizing the results window to its maximum) I return to my normal MacBook Pro Monitor with less resolution. NOw the results window does not automatically adjust its size, it is too long at the bottom. Thus the handle to resize the window is out of reach ...
Best, Dietmar

Might be fixed by #2183.


Scrollbars clip into symbols list text

Version and Platform (required):

Binary Ninja Version: 3.1.3615
OS: macOS
OS Version: 12.0.1
CPU Architecture: M1

Bug Description:
The symbols list has side scrolling but assumes the scrollbar does not have any width, so the last 3 characters of symbol names are cut off.
Steps To Reproduce:

Open binary with long symbol names
Find long symbol in sidebar
Scroll right
See lack of last few chars

Expected Behavior:
I expected to be able to scroll like 22px more
Screenshots:

Additional Information:
This likely applies to other views too. It used to happen to the Log though that might be fixed now.

Resolved with the migration to the new Symbols widget


Horizontal fields don't line up with radios

See upstream issue https://github.com/buefy/buefy/issues/852. This will have to wait until v0.7.0 of Buefy since v0.6.7 contains some breaking changes that can't be worked around.

Fixed by 06b44fb87ef2d3e795fe54ae1bd4ab17f39066cc


adjusted styling on login and commit

added less styling to the to the login form.  dropped the borders.   Deleted the register button below and substituted a sentence and a link for registration.   Styled the register page to look like the login page.

Thanks for the changes! Looks good!


Error after updating Clarity

Hi! I don't know if is a Clarity error or something else but after update to Clarity 0.9.20 I am getting this error "fixedAttrs.map is not a function"
console.log
vendor.bundle.js:111572 ERROR TypeError: fixedAttrs.map is not a function
    at elementDef (vendor.bundle.js:119669)
    at View_AppComponent_Host_0 (ng:///AppModule/AppComponent_Host.ngfactory.js:5)
    at proxyClass (vendor.bundle.js:97654)
    at resolveDefinition (vendor.bundle.js:119309)
    at<EMAIL_ADDRESS>(vendor.bundle.js:120422)
    at<EMAIL_ADDRESS>(vendor.bundle.js:113885)
    at<EMAIL_ADDRESS>(vendor.bundle.js:115320)
    at vendor.bundle.js:115098
    at Array.forEach (<anonymous>)
    at<EMAIL_ADDRESS>(vendor.bundle.js:115098)
defaultErrorLogger @ vendor.bundle.js:111572
vendor.bundle.js:69497 Unhandled Promise rejection: fixedAttrs.map is not a function ; Zone: <root> ; Task: Promise.then ; Value: TypeError: fixedAttrs.map is not a function
    at elementDef (vendor.bundle.js:119669)
    at View_AppComponent_Host_0 (ng:///AppModule/AppComponent_Host.ngfactory.js:5)
    at proxyClass (vendor.bundle.js:97654)
    at resolveDefinition (vendor.bundle.js:119309)
    at<EMAIL_ADDRESS>(vendor.bundle.js:120422)
    at<EMAIL_ADDRESS>(vendor.bundle.js:113885)
    at<EMAIL_ADDRESS>(vendor.bundle.js:115320)
    at vendor.bundle.js:115098
    at Array.forEach (<anonymous>)
    at<EMAIL_ADDRESS>(vendor.bundle.js:115098) TypeError: fixedAttrs.map is not a function
    at elementDef (http://localhost:4200/vendor.bundle.js:119669:46)
    at View_AppComponent_Host_0 (ng:///AppModule/AppComponent_Host.ngfactory.js:5:35)
    at proxyClass (http://localhost:4200/vendor.bundle.js:97654:29)
    at resolveDefinition (http://localhost:4200/vendor.bundle.js:119309:17)
    at<EMAIL_ADDRESS>(http://localhost:4200/vendor.bundle.js:120422:40)
    at<EMAIL_ADDRESS>(http://localhost:4200/vendor.bundle.js:113885:29)
    at<EMAIL_ADDRESS>(http://localhost:4200/vendor.bundle.js:115320:57)
    at http://localhost:4200/vendor.bundle.js:115098:81
    at Array.forEach (<anonymous>)
    at<EMAIL_ADDRESS>(http://localhost:4200/vendor.bundle.js:115098:44)
api.onUnhandledError @ vendor.bundle.js:69497

Environment details
@angular/cli: 1.4.7
node: 8.2.0
os: darwin x64
@angular/animations: 4.4.4
@angular/common: 4.4.5
@angular/compiler: 4.4.5
@angular/core: 4.4.4
@angular/forms: 4.4.5
@angular/http: 4.4.5
@angular/platform-browser: 4.4.5
@angular/platform-browser-dynamic: 4.4.5
@angular/router: 4.4.5
@angular/cli: 1.4.7
@angular/compiler-cli: 4.4.5
typescript: 2.3.4

npm outdated output if it helps
Package                      Current         Wanted      Latest  Location
@angular/animations            4.4.4          4.4.4       4.4.5  clarity-seed
@angular/core                  4.4.4          4.4.4       4.4.5  clarity-seed
@types/jasmine                2.2.34         2.2.34       2.6.0  clarity-seed
@types/node                   6.0.89         6.0.89      8.0.34  clarity-seed
angularfire2              5.0.0-rc.1     5.0.0-rc.1  5.0.0-rc.2  clarity-seed
bootstrap              4.0.0-alpha.5  4.0.0-alpha.5       3.3.7  clarity-seed
clarity-angular               0.9.20         0.9.20      0.10.9  clarity-seed
clarity-icons                 0.9.20         0.9.20      0.10.9  clarity-seed
clarity-ui                    0.9.20         0.9.20      0.10.9  clarity-seed
codelyzer                      2.0.1          2.0.1       3.2.1  clarity-seed
jasmine-core                   2.4.1          2.4.1       2.8.0  clarity-seed
jasmine-spec-reporter          2.5.0          2.5.0       4.2.1  clarity-seed
karma                          1.2.0          1.2.0       1.7.1  clarity-seed
karma-remap-istanbul           0.2.2          0.2.2       0.6.0  clarity-seed
protractor                     4.0.9          4.0.9       5.1.2  clarity-seed
ts-node                        1.2.1          1.2.1       3.3.0  clarity-seed
tslint                         4.5.1          4.5.1       5.7.0  clarity-seed
typescript                     2.3.4          2.5.3       2.5.3  clarity-seed
typings                        1.5.0          1.5.0       2.1.1  clarity-seed
webdriver-manager             10.2.5         10.2.5      12.0.6  clarity-seed

doesn't look like Clarity. I don't remember anyone else raising this issue. Could you please provide more info about the error? Does it only fail on 0.9.20? Is it possible to replicate this on a Plnkr?

@adityarb88 I do not have more info right now... In order to continue with my development I had to downgrade to 0.9.16. Sorry, I will update with more info soon!

@quetool: Were you able to figure out what the issue was? No one else has reported this issue and we definitely require more information to reproduce this. We are closing this issue assuming that this issue is specific to your application. Please feel free to reopen the issue if you have more info on how to reproduce this and we will take a look. Thanks!

no @adityarb88 I am sorry! I went forward with the development after downgrade to 0.9.16. Yes, I will definitely reopen the issue if necessary! Thanks and sorry!

I think you might need to check if your @ angualr/core and @ angular/compiler versions are the same, new version of angular's elementDef  function added a property called checkIndex, if you core and compiler's version are different, you will get this error.

@hippee-lee
Could you verify whether this is an issue for 0.10.17?

@mathisscott - yes, this will still be an issue for v0.10.17. @lingqiao1994 is correct in diagnosign the cause.
I used our seed app and could recreate it whit the version of angular posted in the issue. The fix is on the application side. The package.json should be checked to make sure that all the @angular dependencies are the same version.

@hippee-lee Thanks for that. That clue helped us figure out what was going on.
I'll add also, not only should your @angular dependencies bet the same version but check package-lock.json and double check that they're all the same there. Our package.json versions were all the same, but because the versions were ranges the @angular compiler was ahead by a few minor versions in the lock file vs the rest of the dependencies and that caused the problem. We fixed it by changing package.json to have strict version numbers.


Readme fixes

Thanks. The createFragment method was adapted from the sample, where I was passing intents to the fragments.


Update log

Please add update log

All commits are self-explanatory.

All commits are self-explanatory.

Yeah that is true. @uzdiiilekk  And most of the updates are optimizations anyhow. No new features have been added in a very long time. If there were any new features. The README documentation would be updated. Please close this issue.


Extra character when reading from BSA

When iterating through Skyrim SE BSA files, sometimes an extra character seems to be put in place around non-ASCII characters.
For example, the BSA from this mod: https://www.nexusmods.com/skyrimspecialedition/mods/58403
There is a file named: meshes\syerscote\goldpot01ÃÂ°.nif That unknown byte when I paste that path resolves to a comma when looking at the entry's name. What is weird is I can extract that file using bsa browser and save it on my filesystem and it does not have that unknown byte, but I see it as soon as I paste the filename into this issue. Also no extra char appears in BSA browser.
This might be an issue with the BSA itself and not the library given that I see this extra character when I paste the path here. If you have any insight that would be much appreciated!

You're looking at mojibake. The real string is meshes\syerscote\goldpot01苃냂.nif, which google translate tells me is korean. This string is a mixture of ascii and utf-16, but most software can't pick up on that and guesses windows-1252 instead. This library doesn't make any guarantees about encoding specifically because nonsense like this can happen, and the game will happily accept it.

Aha, thank you. I will try a different encoding then


Please invite me to the GitHub Community Organization

Name
Aqsa Kazi
Discord Username (if applicable)
ayekyuaise#2057
Additional Context
No response

Welcome, @aqsakazi to EddieHub 😄🎉We would be waiting for you in discord 🙂

Welcome to EddieHub, @aqsakazi! 😄🎉


feat(theme): add custom default values

EX-5717
Add custom default values to the plugin's theme

@diegopf Those were added afterwards by Cristina and she didn't tell me 😞
Thanks for pointing it out, tho. I'll include them.


CoC Agreement Check

CoC Agreement Check before creating / updating talk and tutorial proposal. Make a record after user agreed CoC.

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@a7a5d2e). Click here to learn what that means.
The diff coverage is 90.9%.

@@            Coverage Diff            @@
##             master     #659   +/-   ##
=========================================
  Coverage          ?   73.74%
=========================================
  Files             ?       72
  Lines             ?     2723
  Branches          ?        0
=========================================
  Hits              ?     2008
  Misses            ?      715
  Partials          ?        0

Impacted Files
Coverage Δ

src/users/urls.py
100% <ø> (ø)

src/users/views.py
86.86% <100%> (ø)

src/ccip/views.py
35% <50%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a7a5d2e...234fdaa. Read the comment docs.

Just tried this on staging and it works very well. Nice job!


Update edit taxonomy forms with updated scope

Is your feature request related to a specific problem?
In the original designs, the edit forms for each taxonomy type was the same. However, the updated scopes actually have each form being slightly different: https://github.com/ethyca/fides/issues/858#issuecomment-1219558924
Describe the solution you'd like
We need to split out EditTaxonomyForm.tsx which before covered all of the forms to instead give it a different form for each type (although DataCategory and DataQualifier can probably use the same form).
Describe alternatives you've considered, if any
A description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.

@mfbrown there are a few boolean fields which I'm not sure how we'd like represented in the form (they can be undefined, true, or false, so I'm not sure if just a checkbox would work). DataUse's "legitimate interest" field, and DataSubject's "automatic decisions or profiling" field. any ideas, or should I ask the design team?
Otherwise, I inferred what the other fields should be based on their type:

Created https://github.com/ethyca/fides/issues/1001 to cover the boolean fields, otherwise hopefully these new forms are okay!


operator external-secrets-operator (0.8.4)

bump external-secrets-operator 0.8.4
towards https://github.com/external-secrets/external-secrets/issues/2440

/merge possible

/merge possible

/merge possible


Fix DRMAACluster.scale_down and drop Adaptive._retire_workers

Fixes https://github.com/dask/dask-drmaa/issues/65
Replaces https://github.com/dask/dask-drmaa/pull/81
Rewrites DRMAACluster.scale_down to use DRMAA to terminate the workers. Also makes use of DRMAACluster.scale_down in DRMAACluster.stop_workers (where this code was pulled from). With this change, it should now be possible to drop Adaptive._retire_workers, which is already present in the Adaptive parent class.
cc @azjps

Have tested this on our cluster and in a couple testing Docker containers. Seems to work well.
Only minor thing is we are not seeing logging from this line in distributed. Since we do see logging messages about scaling down (added in this PR in the scale_down method), that line does get run somehow, but maybe not correctly. Since we did see the old retiring logging messages before and the only difference is the use of yield or not, think it may have something to do with our usage of a coroutine for scale_down, which is not explicitly included in the Cluster spec. Raised issue ( https://github.com/dask/distributed/issues/2004 ) to see if the Cluster spec could make scale_up and scale_down coroutines.

Should add stop_workers does behave correctly on this front and it does use yield with scale_down.

Looks good to me, code changes seem sensible and looked fine when I lightly tested with our cluster. Nice work cleaning it up :smiley:

Thanks for testing @azjps. Glad to hear it worked.
Generally am happy with this as well. Just on the fence about including the last commit. Any thoughts?


Improve AUTHORIZED_FETCH

Improves Authorized-Fetch #726
And refactors Application handling.
/cc @mediaformat @Menrath

Should we add a setting to enable/disable AUTHORIZED_FETCH?

Should we add a setting to enable/disable AUTHORIZED_FETCH?

Seems like we should, it's already an option for Mastodon admins IIRC? Since there may be some performance and compatibility tradeoffs, we should spell those out

I agree with @mattwiebe we should clearly articulate the performance trade offs.
Perhaps the option shouldn't just be a plain checkbox on the settings page, but inside a modal (confirmation) or disclosure element to make it explicit.

@pfefferle it looks fine, i can test if needed

@mediaformat resolved!


Caddyfile proxy isn't updated by ADV_HOST

Due to caddy don't resolve localhost properly, all landoop application fail to reach kafka,... REST endpoints.
As soon as localhost is replaced by an IP address everything works fine.
The Caddyfile uses localhost as target for all proxy statements.
e.g.
proxy /api/schema-registry localhost:8081 {
    without /api/schema-registry
}

I propose to use ADV_HOST parameter to replace localhost in Caddyfile.

Thank you for taking time to report this.
Can you please give me a bit more context on how you run fast-data-dev so I can replicate the bug? Maybe the docker command you use and your OS?
The thing is that replacing localhost with ADV_HOST there, will make the UIs fail more often. ADV_HOST purpose is when you want to access the Kafka broker from outside of your docker container's network, so the broker will advertise the address it should be accessible at.
Btw, could it be a port issue? I realized by your report, that we hardcode the REST ports in Caddy. I will fix this later today.

Ah, sorry, my bad, ports are set correctly. So I just need a way to replicate the bug so I can find a solution that works in most setups.

Lately I run it on windows using the following command:
docker run --rm -it --name landoop -v %cd%/source:/source -v %cd%/targets:/targets -p 2181:2181 -p 3030:3030 -p 8085:8081 -p8082-8083:8082-8083  -p 9581-9584:9581-9584 -p 9092:9092 -e ADV_HOST=<IP_ADDRESS> landoop/fast-data-dev

Port 8081 had to be changed due to a local service and -net host doesn't work due to docker on windows architecture.
I had the same issue on Fedora 25. On both systems I use the same command line.
What about adding a new parameter SERVICE_HOST, which point to the real location of all services? This would allow the GUI only mode to be more flexible?

I am having a very hard time replicating this (no windows machine, windows vm can't run docker, any linux distro I've tried works) and I really think it is a bad idea to make this address dynamic as the only thing we can be sure off, is that caddy and the other services' REST endpoints run on the same host (and bind to all addresses of this host).
A solution could be replacing localhost with a hardcoded IP, be it <IP_ADDRESS> or <IP_ADDRESS>.
Can you please test if these two addresses would work for you? Sorry to ask this, but I haven't any way to test myself.

I have the same issue on Fedora 25. I attach more detailed debug information.
1.Starting Docker
docker run --rm -it --net host  --name landoop landoop/fast-data-dev
2. Access Webfrontend
After a while the REST calls don't get resolved and the following error shows up in the caddy.log.
01/Apr/2017:08:14:20 +0000 [ERROR 502 /config] dial tcp <IP_ADDRESS>:8081: i/o timeout
::1 - [01/Apr/2017:08:14:20 +0000] "GET /config HTTP/1.1" 502 16

Localhost is defined in the file /usr/share/landoop/Caddyfile and resolves to the correct ip.
I have no clue where the ip <IP_ADDRESS> comes from as the local network is all at 192.168.*.
root@fast-data-dev / $ ping localhost
PING localhost (<IP_ADDRESS>): 56 data bytes
64 bytes from <IP_ADDRESS>: seq=0 ttl=64 time=0.122 ms
64 bytes from <IP_ADDRESS>: seq=1 ttl=64 time=0.194 ms

It looks like some error in Caddy itself...
Docker log: landoop.log.txt
Log of caddy inside of docker: caddy.log.txt
Output of docker inspect: container.txt

Thank you, this report helps much more! It indeed seems some issue with the way caddy resolves localhost.  Could you please give it a go with the two hardcoded IPs (<IP_ADDRESS> and <IP_ADDRESS>)?
It is easy to test, it will only take a couple minutes. Start fast-data-dev as you would normally do:
docker run --rm -it --net host --name landoop landoop/fast-data-dev

Then, as you already done, open a terminal in the running container, then install an editor if needed (vi is included by default), edit the caddyfile and kill (-9) caddy. Supervisord will restart it and it will use the new configuration.
In the edit step, just replace localhost with either <IP_ADDRESS> and <IP_ADDRESS>. Maybe you can use one for the Topics UI and the other one for the Registry UI, so you can test both in one go. You may also need to press CTRL+F5 instead of simple refresh in your browser to show any differences.
docker exec -it landoop bash
root@fast-data-dev / $ apk add --no-cache emacs-nox
root@fast-data-dev / $ vi /usr/share/landoop/Caddyfile
root@fast-data-dev / $ killall -9 caddy

It works using <IP_ADDRESS> as well as with <IP_ADDRESS>.
But supervisord don't restart caddy, so I had to start it myself.

Thank you very much. I appreciate the effort you put into solving this. I will make a release with <IP_ADDRESS> until Monday and if there are more reports we will add an extra flag that hopefully will be needed only by a tiny fraction of users.

Thanks again for resolving this one. I'm closing this ticket - as it seems everyone is quite happy regarding this one 👍


How do you get a textured/colored 3D model?

Since this model is built on top of NeUS, it should have both 3d geometry and appearance reconstructed. How do we obtain the textured model from the code?

Hi, the provided scripts for extracting mesh outputs vertex color by default.

Then, why does it output a grayscale 3D model? Also, in the reconstruction showcase (https://zju3dv.github.io/neuralrecon-w/), colored models are not displayed. Please let me know the modifications required to get an RGB model.  I had trained it but even though the script apparently shows to be generating vertex colors, the extracted mesh is colorless.


[Suggestion] One creative mode tab for all variant mods.

I need these mods as a creative builder, but I feel as if each individual mod does not add enough to warrant having their own creative tab, and it keeps me from downloading all of them. Are you willing to have one creative tab for all your variant mods? It'll definitely help reduce clutter for large amounts of creative mods.

I'm not even sure that's possible unless the mods are merged, which I'd prefer not to do.
I can look in to it though

I don't see why it wouldn't. You added the BetterNether Bookshelves into the BetterNether tab without having to merge the mods. I don't know modding like you do though. Regardless, I wish you luck, and you have my thanks.

I didnt add them, they are part of betternether, i disable mine when BN is present 😛

so the only way to do this is create a separate 'library mod' that all the mods would use a static field in to register the creative tab.
which I'm not prepared to do at this time.
creating extra library mods users have to download is not something I'm willing to do.
I try to keep my mods library free (apart from FAPI).
I'm regularly updating these 'variant' mods with new blocks and have a list of ones I want to do to get them on parity with the crafting table mod at least.
if you know of any that i've missed do let me know.

I see. Thank you anyway.


Go-back feature

Sometimes a user wants to go back to previous one.

As we already have history stack in background, we could provide a history view somehow.

It's too much to have a history view.
We just provide go-back. Proposed in #20 .

tag 22 still contains a bug in this feature.

#21 fixed this


Finding rooms and users

Is your feature request related to a problem? Please describe.
The Matrix protocol API enables us to perform a server-side search. This is handy for finding users and rooms on the server and should be implemented.
Describe the solution you'd like
The Matrix API provides a search function simply called "search". This should be used.

We are halfway there! Matrix.gd now supports this, but I will only close when it has been implemented in the GUI too.


NEXT-00000 - Allow admin-search to get aborted by new request

1. Why is this change necessary?

When using the top search bar in the administration and changing the search term quickly (especially with the elasticsearch search), some/several search requests to the server may accumulate
Since the old requests sent with an old search term are not aborted, the server tries to fulfill them and calculate the response, even though we no longer need the response, since the search term has already changed to something else
This change with the use of the "AbortController" saves processing power on the server

2. What does this change do, exactly?

Changed elastic function in search.api.service to abort the previous search on function call
Changed searchQuery function in search.api.service to abort the previous search on function call

3. Describe each step to reproduce the issue or behaviour.

Use normal or elasticsearch search in the administration for data that takes a while to load
Change your search term a few times
The server will try to fulfill all requests even though the response can no longer match the new search term

4. Please link to the relevant issues (if any).

/

5. Checklist

[X] I have rebased my changes to remove merge conflicts
[X] I have written tests and verified that they fail without my change
[X] I have created a changelog file with all necessary information about my changes
[X] I have written or adjusted the documentation according to my changes
[X] This change has comments for package types, values, functions, and non-obvious lines of code
[X] I have read the contribution requirements and fulfil them.

@jleifeld I added a test file for the search.api.service, fixed a null access error in http.factory and fixed the return data of the search functions when there is a CanceledError to not spam the console and not abort the script that called the search function.

Thank you for your contribution 💙


Update aws-crt to 0.28.12

About this PR
📦 Updates software.amazon.awssdk.crt:aws-crt from 0.28.8 to 0.28.12
Usage
✅ Please merge!
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

⚙ Adjust future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "software.amazon.awssdk.crt", artifactId = "aws-crt" } ]

Or, add this to slow down future updates of this dependency:
dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "software.amazon.awssdk.crt", artifactId = "aws-crt" }
}]

labels: test-library-update, early-semver-minor, semver-spec-patch, commit-count:1

Superseded by #1017.


Add Mutation Support for GraphQL Services

Purpose
$Subject
Fixes:
Examples
Checklist

[ ] Linked to an issue
[ ] Updated the changelog
[ ] Added tests

Closing this for now. Will create a PR once the blocker is fixed.


Add DeepStack Enhance API + Community contrib. Security Model

This PR adds the following changes

Documentation for /v1/vision/enhance endpoint
Add https://github.com/MikeLud/DeepStack-Security-Camera-Models to Custom Models Sample page.

This is perfect, lets get this merged once the next deepstack update is released.

Thanks @johnolafenwa


Update Code License

I've noticed that some parts of the code still made reference to Raedah Group when giving credits. I think we should:

Update the License file to mention Cryptopower developers (The Cyptopower Developers?)
All files should have any applicable License mentioned at the top
Copyright dates should be updated.

I'm not sure if we can take out the original license, seeing as the license allowed use of the source code as long as that license remains, i had this conversation with @itswisdomagain previously but we never reached a conclusion

I'm not sure if we can take out the original license

Yeah, I'm not suggesting to take it out in its entirety. We could just update the Copyright years and add our identity(Cryptopower Developers)?

alright then, sounds fine


Can't connect to anything with Gun adapter using HTTP proxy

Tesla and Gun both with latest commits from master branch, but the same can be seen with Tesla 1.4.4 and Gun 2.0.0-rc1.
gun_client = Tesla.client([], Tesla.Adapter.Gun)
Tesla.get(gun_client, "http://icanhazip.com", opts: [adapter: [timeout: 3_000, proxy: {{127, 0, 0, 1}, 8118}]])

Running this in IEX returns {:error, :recv_response_timeout} no matter what the URL is. SOCKS proxies work fine, the problem is only with HTTP.
https://github.com/ninenines/gun/issues/300 might be related, since the symptoms are similar (connection is created, but no request to end server is made).

Not a solution to your problem, but you can use httpc instead from Tesla v1.11:
def get_adapter(uri) do
  profile = uri |> to_string() |> String.to_atom()
  {:ok, _pid} = :inets.start(:httpc, profile: profile)
  :httpc.set_options([https_proxy: {{to_charlist(uri.host), uri.port}, []}], profile)
  {Tesla.Adapter.Httpc, profile: profile}
end


new errors in output template

[x] I've verified and I assure that I'm running youtube-dl 2018.02.08

ryan@pocketwee:~$ /usr/local/bin/youtube-dl --version
2018.02.08

[x] At least skimmed through the README, most notably the FAQ and BUGS sections
[x] Searched the bugtracker for similar issues including closed ones
[x] Checked that provided video/audio/playlist URLs (if any) are alive and playable in a browser

What is the purpose of your issue?

[x] Bug report (encountered problems with youtube-dl)

ryan@pocketwee:~$ /usr/local/bin/youtube-dl -v -f 251 -x --yes-playlist -o '/home/ryan/Downloads/%(playlist)/%(playlist_index) %(title).%(ext)' https://www.youtube.com/playlist?list=PLSGc8WaREMByawTmBy9qnEpIhpLs1wuLR
[debug] System config: []
[debug] User config: []
[debug] Custom config: []
[debug] Command-line args: [u'-v', u'-f', u'251', u'-x', u'--yes-playlist', u'-o', u'/home/ryan/Downloads/%(playlist)/%(playlist_index) %(title).%(ext)', u'https://www.youtube.com/playlist?list=PLSGc8WaREMByawTmBy9qnEpIhpLs1wuLR']
[debug] Encodings: locale UTF-8, fs UTF-8, out UTF-8, pref UTF-8
[debug] youtube-dl version 2018.02.08
[debug] Python version 2.7.14+ (CPython) - Linux-4.14.0-3-amd64-x86_64-with-debian-buster-sid
[debug] exe versions: ffmpeg 3.4.1-1, ffprobe 3.4.1-1, phantomjs 2.1.1, rtmpdump 2.4
[debug] Proxy map: {}
[youtube:playlist] PLSGc8WaREMByawTmBy9qnEpIhpLs1wuLR: Downloading webpage
[download] Downloading playlist: I Am An Elastic Firecracker
[youtube:playlist] playlist I Am An Elastic Firecracker: Downloading 12 videos
[download] Downloading video 1 of 12
[youtube] K6lOtZdadpI: Downloading webpage
[youtube] K6lOtZdadpI: Downloading video info webpage
[youtube] K6lOtZdadpI: Extracting video information
[youtube] {22} signature length 40.40, html5 player vflG9lb96
[youtube] {43} signature length 40.40, html5 player vflG9lb96
[youtube] {18} signature length 38.40, html5 player vflG9lb96
[youtube] {36} signature length 40.40, html5 player vflG9lb96
[youtube] {17} signature length 40.40, html5 player vflG9lb96
[youtube] {137} signature length 40.40, html5 player vflG9lb96
[youtube] {248} signature length 40.40, html5 player vflG9lb96
[youtube] {136} signature length 40.40, html5 player vflG9lb96
[youtube] {247} signature length 40.40, html5 player vflG9lb96
[youtube] {135} signature length 40.40, html5 player vflG9lb96
[youtube] {244} signature length 40.40, html5 player vflG9lb96
[youtube] {134} signature length 40.40, html5 player vflG9lb96
[youtube] {243} signature length 40.40, html5 player vflG9lb96
[youtube] {133} signature length 40.40, html5 player vflG9lb96
[youtube] {242} signature length 40.38, html5 player vflG9lb96
[youtube] {160} signature length 40.40, html5 player vflG9lb96
[youtube] {278} signature length 40.40, html5 player vflG9lb96
[youtube] {140} signature length 40.40, html5 player vflG9lb96
[youtube] {171} signature length 40.40, html5 player vflG9lb96
[youtube] {249} signature length 40.40, html5 player vflG9lb96
[youtube] {250} signature length 40.40, html5 player vflG9lb96
[youtube] {251} signature length 40.40, html5 player vflG9lb96
ERROR: Error in output template: unsupported format character '/' (0x2f) at index 32 (encoding: 'UTF-8')
Traceback (most recent call last):
  File "/usr/local/bin/youtube-dl/youtube_dl/YoutubeDL.py", line 699, in prepare_filename
    filename = expand_path(outtmpl).replace(sep, '') % template_dict
ValueError: unsupported format character '/' (0x2f) at index 32

...
<end of log>

Description of your issue, suggested solution and other information
The output template format:
-o '/home/ryan/Downloads/%(playlist)/%(playlist_index) %(title).%(ext)'
used to work fine.
Haven't used youtube-dl in a while, a couple months maybe.  Haven't changed the format I use.  In fact I had the format saved to copy-paste it when I want it.  Now it errors:
Error in output template: unsupported format character '/' (0x2f) at index 32 (encoding: 'UTF-8')
I also tried just:
-o '%(playlist_index) %(title).%(ext)'
and I get:
ERROR: Error in output template: incomplete format (encoding: 'UTF-8')

Incorrect output template, you are missing a conversion type for each sequence.

Help please?  I don't understand the difference between 'd' and 'i'.  They're both described as "Signed integer decimal" with no note.
Also why did it used to work without me ever adding this part?

There is no difference.
It never worked without conversion type.

Right, thanks so much for not helping, and for lying to me about the way I've been doing it forever.  Hey maybe you'll delete this comment too, or maybe the whole issue!  Good job.

Not helping?  And again: it never worked this way. Prove me wrong. Bother to grab some old youtube-dl version and provide verbose log of these command working.

Right.
Good job not knowing what "hypocrite" means.  When did you ask me for help, for which my not providing you with said help had rendered me a hypocrite?  Never.
I have always had the ytdl command and arguments above as one of my options in my Open With addon.  Any time I wanted to download a playlist, I just right-clicked anywhere on the page or tab, or on a link to the playlist, sent it to OW which sent it to ytdl and it always worked perfectly.   Always downloaded full playlists.
I'm literally sitting here right now learning about python conversion types which I've never used before, but no, the conversion types must have always been there, because as you say "it never worked" without them.  I guess they must have been inserted on-the-fly by OW.    But I guess it must have stopped inserting them on the fly and so now I have to insert them manually.

Then go and complain to OW addon. This is youtube-dl issue tracker not OW or whatever else 3rdparty stuff. I really don't care whether you used before it or not, the fact is that it's in youtube-dl from the beginning and it's the only way to use it.


Correctly parse complicated manifest files

Now we can't parse Cargo.tomls, which doesn't have [package] section (for instance, because of cargo workspaces).

Close this, as we no longer need to actually parse Cargo.tomls.
We gather all the needed information from the environment variables.


Merge in new roster data for June 01, 2021

It is slightly problematic but it is, unfortunately, how the data is provided to us. There may be a way to complete the unit descriptions programmatically by building a list of unit descriptions and completing the names ourselves, but I don't think it's really necessary because we have the unit code which is the important bit.


How should I report a security issue?

Sorry for asking in a regular issue, but I wasn't sure how to best contact the authors.

You can send an email to me<EMAIL_ADDRESS>or contact me in irc.mozilla.org @onur.

Thanks!

Thanks!


Add support for programmatic refresh

First, I just started using this control to replace CollectionView and it is awesome - really appreciate the work you have done here!
I have a couple of use cases where I want to perform a refresh of the list without user action but I would like to have the UI update to reflect the refresh is happening.  I have a branch where I have implemented this feature and added it to the test app and confirmed it works as expected in iOS and Android.  Would you be interested in a PR to add this feature?

I'm curious what this would be doing?  How does this differ from the Adapter.InvalidateData() call?

The functionality is about updating the Refresh view to show the activity indicator animation in the UI, when Adapter.InvaldiateData() is called programmatically.   Obviously if the user performs a pull gesture, that fires Adapter.InvalidateData() and we call the completion action which stop the activity indicator animation.  However, if I programmatically call Adapter.InvalidateData(), it does not trigger the refresh views animation indicator to show.  Hope that makese sense...let me know.

Ahhh yes I understand what you’re after now.
Definitely makes sense to implement. If you’re up for the challenge I’d welcome the pr.


standard_init_linux.go:190: exec user process caused "exec format error"

I am following the instructions on building snapcast on a raspberry pi from the README and getting the following error. What am I doing wrong? 👀
pi@raspberrypi:~/snapcast-pi $ docker run -it -v $(pwd):/home/buildroot/snapcast-pi -w /home/buildroot/snapcast-pi nickaknudson/buildroot /bin/bash
standard_init_linux.go:190: exec user process caused "exec format error"

Leaving these here incase it helps:
pi@raspberrypi:~/snapcast-pi $ uname -a
Linux raspberrypi 4.4.38+ #938 Thu Dec 15 15:17:54 GMT 2016 armv6l GNU/Linux

pi@raspberrypi:~/snapcast-pi $ docker info
Containers: 3
 Running: 0
 Paused: 0
 Stopped: 3
Images: 1
Server Version: 18.06.1-ce
Storage Driver: overlay2
 Backing Filesystem: extfs
 Supports d_type: true
 Native Overlay Diff: true
Logging Driver: json-file
Cgroup Driver: cgroupfs
Plugins:
 Volume: local
 Network: bridge host macvlan null overlay
 Log: awslogs fluentd gcplogs gelf journald json-file logentries splunk syslog
Swarm: inactive
Runtimes: runc
Default Runtime: runc
Init Binary: docker-init
containerd version: 468a545b9edcd5932818eb9de8e72413e616e86e
runc version: 69663f0bd4b60df09991c08812a60108003fa340
init version: fec3683
Kernel Version: 4.4.38+
Operating System: Raspbian GNU/Linux 8 (jessie)
OSType: linux
Architecture: armv6l
CPUs: 1
Total Memory: 434.7MiB
Name: raspberrypi
ID: SBSZ:DABD:CTMI:3JAS:I3W4:KCDS:HOJS:QIRE:HT2I:3LQB:3J6F:M6JA
Docker Root Dir: /var/lib/docker
Debug Mode (client): false
Debug Mode (server): false
Registry: https://index.docker.io/v1/
Labels:
Experimental: false
Insecure Registries:
 <IP_ADDRESS>/8
Live Restore Enabled: false

WARNING: No swap limit support
WARNING: No kernel memory limit support
WARNING: No cpu cfs quota support
WARNING: No cpu cfs period support
WARNING: No cpuset support

This is most likely because the docker image was not built for armv61.
The instructions provided here are for cross compiling an image that can be flashed to an SD card.

I installed Docker through curl -sSL get.docker.com | sh. Do you mean that this installation method is not supported with armv6l? Also I noted, perhaps a typo on your behalf, that you wrote armv61 but it is armv6l (an L not a 1).

Docker may run, but the image that you are trying to run (nickaknudson/buildroot) is not for ARM.
Again, the instructions provided here are for cross-compiling snapcast using buildroot. The instructions are meant to be run on your host machine and flashed to an SD card which will then run on the pi.


Form for the Submit A Request FOIA page

Added the Submit A Request page
Additions

Added a lot of markup for the submit a request page
Created a small function to show additional fields when a certain input is selected.
Added a utility: u-reset to get rid of additional formatting around the fieldset element that's added by normalize.css
Added input__long to have input fields fill the container they are given.

Testing

Visit /initiatives/submit-a-request/
Select "Yes" on "Requesting a fee waiver"
Both "Mail" and "Fax" in "requested response method" should also trigger more fields to open.

Review

@sebworks
@jimmynotjim
@anselmbradford

Preview

Preview this PR without the whitespace changes
Notes

This form doesn't submit to anything for this sprint

:+1:

Rather than commenting individually on issues, I finished up the second half of the comments just now. Give it another look, @jimmynotjim.

:+1: Nice work!


Extend linting tools

This is a continuation of #205 to add some more substantial framing for how we handle code structure in the boto projects. This PR is currently a draft for comment and may be broken up into smaller parts for easier review. The current proposal adds 3 new tools to ensure we're cleaning up old code and keeping what we have currently consistent. This also helps expedite PR review by removing the need for iterations on minor style fixes.
Proposed additions:

isort - This will order our imports and ensure consistent layout. This avoids duplicate imports by keeping everything in the same spot and makes it easier to find what's already available.
pyupgrade - This will automatically "upgrade" existing code to use the feature set configured for the lowest supported version (in this case Python 3.6). This is a more significant change that most version bumps because it's cleaning up all of our Python 2.6, 2.7 and 3.0-3.5 code.
black -  This is the last one and maybe most contentious. We're adopting black with two caveats, we're not going to enforce quote normalization for now, and we're going to keep line length at 79 for the time being.

Codecov Report

Merging #218 (cc87c45) into develop (031ed4a) will decrease coverage by 0.18%.
The diff coverage is 91.35%.

@@             Coverage Diff             @@
##           develop     #218      +/-   ##
===========================================
- Coverage    85.41%   85.23%   -0.19%
===========================================
  Files           16       16
  Lines         2764     2661     -103
===========================================
- Hits          2361     2268      -93
+ Misses         403      393      -10

Impacted Files
Coverage Δ

s3transfer/constants.py
100.00% <ø> (ø)

s3transfer/crt.py
0.00% <0.00%> (ø)

s3transfer/tasks.py
92.43% <80.00%> (-0.07%)
:arrow_down:

s3transfer/download.py
95.08% <92.30%> (-0.31%)
:arrow_down:

s3transfer/manager.py
96.50% <97.05%> (-0.29%)
:arrow_down:

s3transfer/__init__.py
99.35% <100.00%> (ø)

s3transfer/bandwidth.py
99.33% <100.00%> (-0.01%)
:arrow_down:

s3transfer/compat.py
76.31% <100.00%> (+6.54%)
:arrow_up:

s3transfer/copies.py
100.00% <100.00%> (ø)

s3transfer/delete.py
100.00% <100.00%> (ø)

... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 031ed4a...cc87c45. Read the comment docs.


rcnn_build fails

When I try to run rcnn_build(); I get the following errors:
> In rcnn_build (line 8)
Error using mex
/tmp/mex_7347092241600_14443/tron.o: In function `TRON::trcg(double, double*, double*, double*)':
tron.cpp:(.text+0x1ed): undefined reference to `dnrm2_'
tron.cpp:(.text+0x20e): undefined reference to `ddot_'
tron.cpp:(.text+0x242): undefined reference to `dnrm2_'
tron.cpp:(.text+0x280): undefined reference to `ddot_'
tron.cpp:(.text+0x2a7): undefined reference to `daxpy_'
tron.cpp:(.text+0x2b6): undefined reference to `dnrm2_'
tron.cpp:(.text+0x316): undefined reference to `daxpy_'
tron.cpp:(.text+0x32a): undefined reference to `ddot_'
tron.cpp:(.text+0x343): undefined reference to `ddot_'
tron.cpp:(.text+0x35c): undefined reference to `ddot_'
tron.cpp:(.text+0x413): undefined reference to `daxpy_'
tron.cpp:(.text+0x444): undefined reference to `daxpy_'
tron.cpp:(.text+0x473): undefined reference to `daxpy_'
tron.cpp:(.text+0x487): undefined reference to `ddot_'
tron.cpp:(.text+0x4a8): undefined reference to `dscal_'
tron.cpp:(.text+0x4c0): undefined reference to `daxpy_'
/tmp/mex_7347092241600_14443/tron.o: In function `TRON::tron(double*)':
tron.cpp:(.text+0x652): undefined reference to `dnrm2_'
tron.cpp:(.text+0x6de): undefined reference to `daxpy_'
tron.cpp:(.text+0x6f3): undefined reference to `ddot_'
tron.cpp:(.text+0x710): undefined reference to `ddot_'
tron.cpp:(.text+0x758): undefined reference to `dnrm2_'
tron.cpp:(.text+0x94b): undefined reference to `dnrm2_'
collect2: error: ld returned 1 exit status

Error in rcnn_build (line 8)
  mex -outdir . ...

All of the other toolboxes compile fine, and every step up to this point was fine. Any idea what's going on here?

See Issue #2 if it helps.

Ok I tried following your Oct 15 instructions, but when trying to do step 2
(make inside the liblinear-1.4/matlab directory) I get the following:
/usr/local/MATLAB/R2015a/bin/mex CC#g++ CXX#g++ CFLAGS#"-Wall -Wconversion
-O3 -fPIC -I/usr/local/MATLAB/R2015a/extern/include -I.." CXXFLAGS#"-Wall
-Wconversion -O3 -fPIC -I/usr/local/MATLAB/R2015a/extern/include -I.."
-largeArrayDims train.c ../tron.o ../linear.o linear_model_matlab.o
../blas/blas.a
~/rcnn-depth/eccv14-code/rcnn/external/liblinear-1.94/matlab/CC#g++ not
found; check that you are in the correct current folder, and check the
spelling of
'~/rcnn-depth/eccv14-code/rcnn/external/liblinear-1.94/matlab/CC#g++'.
make: *** [train.mexa64] Error 255
That CC#g++ looks like an error doesn't it?
On 29 July 2015 at 16:57, Varun Nagaraja<EMAIL_ADDRESS>wrote:

See Issue #2 https://github.com/s-gupta/rcnn-depth/issues/2 if it helps.
—
Reply to this email directly or view it on GitHub
https://github.com/s-gupta/rcnn-depth/issues/11#issuecomment-125998165.

Here's the commit where I fixed the Makefile.

@varun-nagaraja  this commit can't find ,i meet the same error as @tdiethe ,how can i do?

Sorry @zhaobaozi that I moved my repository. However, you can find the steps in the discussion here.

@varun-nagaraja i follow by your but i also have failed ..you use matlab 2014?

@varun-nagaraja I follow your commit ,but when i do the step2 i meet the error make: *** [train.mexa64] Error 255...how can i do?thanks!


Fix audio out of sync

I encountered a similar issue described in #28, but my videos are in English. I suspect it is related to the variable framerates of the video's recording device.
After some debugging, it turns out the output .wav audio file is out of sync with the original video. Thus, I added the -async 1 option to ffmpeg and it fixed the issue.
Also, becauseasync is a reversed keyword in Python, I replaced the call to ffmpeg with subprocess.run.

@RapDoodle Can you update this to use the newer aresample option instead? I believe this will also let us keep using ffmpeg directly

The ffmpeg module was replaced with the subprocess module due to conflicting argument name "async"
A new function get_audio() is added which extracts audio from a video file and returns its path
In main(), if --extract-audio flag is set, then extract audio using get_audio() instead of calling transcribe().

This is not a solution as the de-synchronization still happens

Following the discussion here https://github.com/openai/whisper/discussions/1888 I was able to greatly improve accuracy by adding the --word_timestamps True flag to the transcribe call.


Bug in Filemin File Manager Module

Webmin Version 1.763 on Debian Wheezy with Chrome browser on Windows 7.
If a folder name contains an apostrophe ( ' ), clicking on the folder to enter it fails with the following error:
Following errors occured while performing operation
Error opening directory /media/41991950-4d12-4475-86b8-ba54ec09323b/multimedia-content-d1/movies/Example's No such file or directory
Changing the offending apostrophe to a backtic ( ` ) is a good workaround.

There were some trouble of transferring HTML specific symbols in file/folder names. I'll look into it.
By now try updating to the latest Filemin version manually, it has some patches after Webmin dev release.

Thanks for the reply. I manually installed filemin-0.9.6.linux.wbm.gz, but the problem remains.

You could experience cache issue. Try restarting Webmin..

Thanks for the suggestion, but no joy.

Hi! I hope I'm not messing up the subject, but I've had a, maybe connecting, problem with scandinavian characters in file and folder names. They simply don't show and I get the following error message:
HTTP/1.0 500 Perl execution failed Server: MiniServ/1.760 Date: Wed, 23 Sep 2015 07:20:35 GMT Content-type: text/html; Charset=iso-8859-1 Connection: close
Error - Perl execution failed
utf8 "\xE4" does not map to Unicode at /usr/lib/perl/5.14/Encode.pm line 174.
Is this a problem with Filemin or a browser setting issue?
Ubuntu 12.04 Server LTS,  Win Vista x64 and Chrome browser latest version.
PS I really appreciate the Filemin. And despite the problem It is a great help! Thank You.

@berntkau I just think you need to make sure that you change language to UTF8 in Webmin->Webmin Configuration->Language. Make sure that Webmin->Language and Theme module doesn't override your global settings.

@qooob Thank you for your very quick respons. I changed the encoding to utf-8 in Webmin and then also in Chrome but no luck. Same error message keeps popping up. There is no hurry, but I hope a solution will be found.

I think it was caused by &urlize function, the same thing caused non ASCII file/folder names unusable.
After I removed urlize function from Filemin I can create folders with apostrophe in name.
I'm closing issue right now, changes will be in version 0.9.7.
Feel free to reopen issue if you encounter it after new release.

Thanks, I'll let you know.


上传了插件后在插件对话页面的插件列表中插件没有显示出来，导致对话出错

Search before asking

[X] I had searched in the issues and found no similar issues.

Operating system information
Linux
Python version information
3.10
DB-GPT version
latest release
Related scenes

[ ] Chat Data
[ ] Chat Excel
[ ] Chat DB
[ ] Chat Knowledge
[ ] Model Management
[ ] Dashboard
[X] Plugins

Installation Information

[X] Installation From Source

[ ] Docker Installation

[ ] Docker Compose Installation

[ ] Cluster Installation

[ ] AutoDL Image

[ ] Other

Device information
Dvice：cpu
Models information
llm：zhipu
embedding：m3e
What happened
插件上传成功后进行插件对话时插件列表中并没有展示出插件，进行对话时报错，“请选择代理”

What you expected to happen
出现这个问题的原因是啥呀，怎么解决呢
How to reproduce
1.克隆最新版（0.4.6）代码
2.修改.env文件后进入web页面上传插件
3.当插件上传成功后进行插件对话
Additional context
No response
Are you willing to submit PR?

[ ] Yes I am willing to submit a PR!

需要在数据库中插入元数据，可参考插入元数据

需要在数据库中插入元数据，可参考插入元数据

hi @xiaog929 , ok, we will figure out soon.
/assign @yhjun1026


Breng Publinova gelijk met Edusources

Things to consider:

[x] Should we make publinova.nl SITE_ID=3? No
[x] Should we remove any mention of environment in the site objects? Yes
[x] Can we separate all processes with --settings flag? Yes using DJANGO_SITE_SETTINGS

Steps to release:

[x] Revert Hanze migration
[x] Terraform apply (to move harvest task outside of normal celery containers)
[x] Build + promote
[x] APPLICATION_MODE=acceptance invoke aws.migrate harvester acceptance
[x] APPLICATION_MODE=acceptance invoke aws.migrate service acceptance
[x] APPLICATION_MODE=acceptance invoke hrv.index-dataset-version acceptance -d alpha
[x] Deploy
[x] Clean up aliases

This is a list of what needs to happen:

[x] Disable the harvest task and add AWS scheduled harvest
[x] Setup postgres shouldn't always add a MBO domain
[x] ElasticIndex should become a Site model instead of using educational_level to determine remote_name and alias
[x] index_dataset_version should take a site and educational_level argument. The harvest task should make switches on what to do.
[x] Sync metadata should iterate over available sites, not take site as an argument
[x] Base the metadata cache key on something else than the SITE_ID
[x] Create a sites-available and sites-enabled distinction within emperor/entrypoint configuration
[x] Add publinova.nl as a settings file and uwsgi site configuration (ignore this with flask8)
[x] Add publinova localhost domain to nginx configuration
[x] Sync indices site argument should be removed and sync_indices should iterate over sites instead
[x] Check port networking. How can nginx reach port 8001?
[x] Check that index_dataset_version is creating the correct indices
[x] Check that loading of metadata remains working
[x] Check that the MetadataTree remains working

Deze veranderingen waren strict technisch, dus ik keur ze zelf even goed @JohnMeurs


Add test notifications to travis

Actually, please double check that external users are able to send emails to this address.


Use system helm instead the packaged one

What would you like to be added:
A new config entry to set the path to helm binary.
Why is this needed:
Because you can provide more tiny application that don't need to include a 47MB binary.
Environment you are Lens application on:

Kubernetes distribution: AKS
Desktop OS: Arch Linux

Do you mean a setting similar to the one for kubectl or an option for not bundling helm3 with Lens?

Now I'm building package without helm using this:
make node_modules
make build-extensions
yarn dist:dir

But the only method that I found to avoid to have a copy of helm with lens is make a symlink into  resources/helm3/helm3 of my /usr/bin/helm. I think that an option like the one for kubectl is a great solution.
You can see my hack in Arch Linux pkgbuild.

Using built-in helm on M1 mac results an error:
/Applications/Lens.app/Contents/Resources/helm3/helm3: Bad CPU type in executable
Standalone helm works fine.

@jakolehm Can you investigate the "bad CPU type" issue?

This is caused because M1 has ARM architecure and in you must package the x86_64 binary in Lens.

@ogarcia Yes, but in https://github.com/lensapp/lens/pull/3700 shouldn't have introduced it


Senzing logger output could be a JSON-lines file

If we move:

Date
time
location
fields into JSON section of the log message, then we could construct a JSON-lines file from our log message which would make it easily parse-able

For line in file, something like:
_, filename, line, _ := runtime.Caller(1)

Pull requests:

https://github.com/Senzing/go-logging/pull/29


Merge SFDO-Tooling main into oddbird main

Includes:

new translations (and RTL support)
dependency updates
improved privacy

@jgerigmeyer I think I've adjusted things so that the scratch org feature will work with my changes to how the instance_url is handled, but I haven't had a chance to actually do functional testing.

@davisagli Okay, bugfixes submitted in PR against main (https://github.com/SFDO-Tooling/MetaDeploy/pull/1978). I'll merge this in anyway.


Create subfolders for covariates from different sources/purposes

It would be quite useful to separate model predictors into subfolders for different model builds.
e.g. the site series models derived only from DEM folder variables, the non-forest derived from DEM + canopy variables

dem: for SAGA derived covariates from the DEM
stucture: for stand structure variables from canopy height models
satellite: for variables from satellite imagery

This can help in the model builds (different models and different submodels), i.e  only DEM vs DEM + structure. Select the names in the folder to help subset


feat: LLamaRisk crvUSD Vault (Epoch 8)

Context

LlamaRisk crvUSD Vault (Epoch 8) - 13_514 CRV over 6 weeks
start:<PHONE_NUMBER>n, // Fri Nov 01 2024 17:05:08 GMT+0000
end:<PHONE_NUMBER>n, // Fri Jan 10 2025 17:05:08 GMT+0000

Merge conditions checklist

[x] Ensure there is at least one week between the PR submission and the start of the Program(s).
[x] Send funds to the URD; the PR will only be merged after the funds have been received.
[x] Transaction link(s) for the funds transfer(s) to URD(s): https://etherscan.io/tx/0x82ce18bce7e334826edc700e09fd688d414935bfdc5dc028b5e2cb53c13fefdf

Important: If the delay between the PR creation and the start of the Program(s) is less than one week, or if we do not see any funds sent to the URD, the PR will not be merged, and the Program(s) will not be created.

Ready to be merged


Invoking NotificationCompat.Builder's color() with a resolved color

fixes #29

It seems like Travis CI isn't ready for API level 23 yet:
 failed to find target with hash string 'android-23' in: /usr/local/android-sdk


execution aborted after plugin executed

having issues with the plugin integration executions abort after sending the card into teams. I'm arable to see the result in teams channels but not message on CI pipeline on why the execution aborted after sending the message
19:03:00]: Called from Fastfile at line 210
[19:03:00]: ```
[19:03:00]:     208:        )
[19:03:00]:     209:        UI.message("Version info fetched from app center sent teams notification")
[19:03:00]:  => 210:        teams_card(
[19:03:00]:     211:            workflow_url: 'https://bagelbrands.webhook.office.com/webhookb2/b4b4a293-f282-49e6-8c94-ecff704dffe3@7cb0fafb-74e6-4340-9e9d-d44120f832fd/IncomingWebhook/3d2ee84786884cedbeea24a2478c85e8/347e7b3b-635b-498d-9f68-a8e85b4c41a4/V2EFQRxIfPpbGoci56ypFd7gwD9-o6pzXRcfqykUMOvYk1',
[19:03:00]:     212:            text: " AppCenter build: #{appversion['id']} is ready for testing!",
[19:03:00]: ```
[19:03:00]: ⚠ An error occurred: 1

this is the config for the plugin
 teams_card(
        workflow_url: 'https://xxxx.webhook.office.com/webhookb2/-ecff704dffe3@7cb0fafb-d44120f832fd/IncomingWebhook/ask1',
        text: " AppCenter build: #{appversion['id']} is ready for testing!",
        image: "https://ba.com/wp-content/uploads/2020/07/#{options[:brand]}-logo-small1.png",
        image_title: "#{options[:scheme]}",
        open_url: "https://install.appcenter.ms/orgs/Cels/apps/#{options[:scheme]}/releases/#{appversion['id']}",
        facts: [
          {
            'title' => 'AppCenter build',
            'value' => "#{appversion['id']}"
          },
          {
            'title' => 'App version',
            'value' => "#{appversion['version']}"
          },
          {
            'title' => 'Build Number',
            'value' => "#{appversion['build_number']}"
          },
          {
            'title' => 'Releases Notes',
            'value' => "#{lastCommit[:message]}"
          }
        ]
      )
  end
the end is beached is nested into a bigger lane and it run the last. after the run it failed with above message.

I have just released a fix for this issue, please install plugin version 1.0.2. If you encounter still issues, please reopen this ticket.


Add and stylize a lightmode/darkmode toggle on our site!

Everyone LOVES darkmode anymore, so we figured we should hop on the bus! Add a toggle to switch our webpage into dark/light mode! This can be done several different ways, so choose the way you feel fits best! Dark mode styling should be somewhat consistent with the current color pallet, but location of toggle/styling beyond that is up to you!
Great resource link for dark/light mode toggles and styling!
Happy hacking!

Can i be asigned this for an outreachy contribution. Thanks

@caseynv  sure! I will assign you to this issue! Good luck!

@caseynv,
Are you still working on this Issue?

Hello, I'm Chaitanya and I've been asked to contribute to an open-source project for my Software Development course. I'd be interested to work on this issue and it'd be great if I could be assigned to this. Thank you.


Subscribe to Issues/PR

Correct me if I'm wrong. Currently when I open an Issue in gogs and another user comments, I get an e-mail notification, right?
If so would it be possible to subscribe to issues where I have not commented yet (like github does) and unsubscribe from issues when I don't want to get any emails?

BTW the same would apply for PR

Thanks your feedback!


homekit device_id cannot be set

Even if the device_id of the homekit item in the config file is set, it is not reflected.
When trying to use multiple sets with different device_id, the device_id is set to the same value and the second or later set cannot be registered to the iPhone.
Could this be due to the fact that the struct tag in internal/homekit/homekit.go:25-30 is json?
I think that keys with underscores or capital letters are not recognised correctly.
go2rtc_linux_mipsel version: v1.9.1
Below is the go2rtc.yaml.
log:
  level: info
  api: warn
  exec: debug
  ngrok: info
  rtsp: warn
  streams: error
  webrtc: fatal
streams:
  video0:
  - rtsp://localhost:8554/video0_unicast

rtsp:
  listen: ""

homekit:
  video0:
    pin: 12345678
    name: "camera1"
    device_id: "AA:BB:CC:DD:EE:FF"

Unfortunately, you're absolutely right. After the fix, anyone who changed these settings will need to re-add the cameras again.

https://github.com/AlexxIT/go2rtc/releases/tag/v1.9.2


Tool using with gemini

This seems to fail 50% with no completions from the server
from langchain_core.messages import AIMessage, HumanMessage, ToolMessage
from langchain_google_vertexai import ChatVertexAI

model = ChatVertexAI(model_name="gemini-pro")

messages = [
    HumanMessage(
        content=(
            "Repeat the given string using the provided tools. "
            "Do not write anything else or provide any explanations. "
            "For example, if the string is 'abc', you must print the "
            "letters 'a', 'b', and 'c' one at a time and in that order. "
            "\n\n type this: 'a'"
        )
    ),
    AIMessage(
        content="",
        additional_kwargs={
            "function_call": {
                "name": "type_letter",
                "arguments": '{"letter": "a"}',
            }
        },
        tool_calls=[
            {
                "name": "type_letter",
                "args": {"letter": "a"},
                "id": "abc123",
            },
        ],
    ),
    ToolMessage(
        name="type_letter",
        content="OK",
        tool_call_id="abc123",
    ),
]

result = list(model.invoke(messages))

It looks to be on the model's side, it returns an empty response like
usage_metadata {
  prompt_token_count: 71
  total_token_count: 71
}

We can probably raise a ValueError when there are no candidates in the response, wdyt?

@lkuligin Are we able to rule out the integration? Is it easy to reproduce with the vertex SDK directly? Could it be that we're sending some incorrect data via the integration and the API isn't validating inputs properly and then failing to produce a response?

@eyurtsev I've reproduced it with the native SDK only and raised an issue internally.

@lkuligin I've noticed that in the streaming context, we seem to consistently get an IndexError if we try to invoke a tool in a sequence more than two times. Here is an example:
import random

from langchain.agents import AgentExecutor, create_tool_calling_agent
from langchain_core.prompts import ChatPromptTemplate, MessagesPlaceholder
from langchain_core.tools import tool
from langchain_google_vertexai import ChatVertexAI

instructions = (
    "You are using a translation machine. "
    "You will be given a string. Input the characters one at a "
    "time into the machine. The machine will give you output for "
    "each character. When finished, provide the final output. "
    "For example, if the string is 'abc', you must input the "
    "letters 'a', 'b', and 'c' one at a time and in that order. "
    "The responses may be, for example, 'z', 'x', 'q'. You will then "
    "report the final output as 'zxq'. "
    "\n\n {input}"
)

prompt = ChatPromptTemplate.from_messages(
    [
        ("human", instructions),
        MessagesPlaceholder("agent_scratchpad"),
    ]
)

model = ChatVertexAI(model_name="gemini-1.5-pro-preview-0409")

@tool
def type_letter(letter: str) -> str:
    """Type the given letter."""

    alphabet = "abcdefghijklmnopqrstuvwxyz"
    return alphabet[random.randint(0, 25)]

tools = [type_letter]

agent = create_tool_calling_agent(model, tools, prompt)

executor = AgentExecutor(
    agent=agent,
    tools=tools,
    verbose=True,
)

res = executor.invoke({"input": "type this: 'ba'"})  # works (agent reports output)

res = executor.invoke({"input": "type this: 'bat'"})  # hits IndexError

If this is expected, one option is to return a message at this point, e.g., in https://github.com/langchain-ai/langchain-google/pull/162


fix: Re-enable some unit tests

Re-enable skipped tests.
Fixes #54

Closed and reopened to trigger CI as I've just turned on CI checks from forks


Adapt to ROS Enhancement proposal 145

After asking on ROS Answers I was pointed to ROS REP 145, which defines the standards for an IMU driver. Including which data to provide in which coordinate systems etc. See here: http://github.com/paulbovbel/rep/blob/master/rep-0145.rst
It is not yet official, discussion here (on hold until some "conversion tools" are ready): https://github.com/ros-infrastructure/rep/pull/95
It defines  which topics to use and a number of standard parameters that are not yet implemented by the LPMS driver.

Hi Tobi, thanks for digging up REP 145, it is exactly what we have been looking for :)
I have made PR #14 which adds some docs and addresses this issue partially. Please take a look and let me know what else should be done at this point. I'd say I need to remove the "-" signs when filling the orientation message.

Thank you for looking into this, what I've seen so far looks great. I'll have a closer look with the REP on my screen, time allowing either tomorrow afternoon (JST) or on Monday. I'm busy with a new version of LpSensor, I hope we can put that out soon to add a blocking interface & reduce CPU usage. After that, we will have a really nice package for ROS users :)
oh, and I didn't dig out that REP, it was dug out for me!

I don't have as much time as I wished for. I gave it a look-through, and I couldn't find anything that seemed off, but I don't have time to verify the conventions in detail.  That said, I'm very happy that you are doing this work!

Thanks! I'm also a bit pressed for time right now, but I'll get back to closing this issue as soon as my schedule clears up a bit.

No problem, please take your time, it's not like the ROS standard made any progress in the past few weeks, so we're still ahead :) We at LP are very happy that this is available, and I'm planning to spend a bit of time on it as soon as I can cut something out of my schedule.  After all, I promised you the blocking I/O in LpSensor (done, just needs to be pushed out). There are also lots of settings that could be handled by the driver, and I want to work on making at least the most basic ones available.

Long time no see. We have a new ROS driver for our sensors which should conform to enhancement proposal 145. It also uses our new OpenZen library to support all of our sensors, including the latest models. It is available from here. https://bitbucket.org/lpresearch/openzenros/src/master/
We expect a blog post in the next few days. Anyway, I think I can close this issue :D

Thanks for the update @TobiSchluter. OpenZen looks great! I guess it makes this repo obsolete, so maybe I can put a note in the readme that this is obsolete and point people to the OpenZen driver. Or is there some legacy hardware that is not supported by OpenZen but can still use this driver?

Thank you. OpenZen is meant to supersede LpSensor completely, and it supports all our past sensors. So I think it is a really good idea, if you could point to the new ROS driver. We actually have a pull request for the ROS distro in the works, so we are hoping the new library will become "official" soon, see  https://github.com/ros/rosdistro/pull/24458
Thank you for your work!


Non Printable Charaters

Is there a way to send Non printable characters?, I am looking for Line feed.

Thanks for your patience. Been a hectic couple of days.
I have added an update that will allow you to send ascii characters, which encompass the good ole Line Feed.
You will have to use its Html number notation, as the Plugin uses Html for its presentation.
You can find the value representation here:
https://www.ascii-code.com/
Line Feed =

Use case:


Select color scheme for application

Color suggestions
Main app theme colors

Text colors

Error colors

In case we need some green colors for validation this color schema may be used

Maybe we should use black color theme instead

Black color theme is to be used


[FEATURE] Support to keep the volume if Delete reclaim policy

What feature you'd like to add:
Currently, Delete reclaim policy triggers deleting volume whenever the PVC is deleted.
It looks good if I can decide whether to keep the volume or not. e.g. juicefs/keep-volume="true"
Why is this feature needed:
I’d like to keep my data even if the PVC is deleted.
I set the storage class with Retain reclaim policy. But, when the PVC is deleted, the PV still exists with "released" status.
https://kubernetes.io/docs/concepts/storage/persistent-volumes/#retain
the cluster-admin has to delete the PV with "released" manually. It’s annoying to the cluster-admin.
so, I want to set Delete reclaim policy with an option to keep the volume.

Skip deleting volume if retainVolume: true https://github.com/juicedata/juicefs-csi-driver/pull/1017

https://github.com/juicedata/juicefs-csi-driver/pull/1017#issuecomment-2216897336


automatically deploy to https://Fineract.dev [FINERACT-970]

see FINERACT-970

I'm going to self-merge this in order to be able to test FINERACT-970. We could always revert it if NOK.

Thanks. Looks good
One thing which may or may not be important is, why don't you use a stable
version of Ubuntu say 18.04 or 20.04 LTS than the Ubuntu-latest image?
 I don't know enough about GitHub
actions, just curious.
On Sat, May 16, 2020, 22:08 Michael Vorburger ⛑<EMAIL_ADDRESS>wrote:

Merged #899 https://github.com/apache/fineract/pull/899 into develop.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/apache/fineract/pull/899#event-3343954793, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/ADWPAYHVKPB7LNRHH6DPHRTRR36DVANCNFSM4NDCM6FA
.

One thing which may or may not be important is, why don't you use a stable version of Ubuntu say 18.04 or 20.04 LTS than the Ubuntu-latest image?

To be honest I just copy/pasted that line... I don't think it matters much - this is just for a very short lived container, to run an action. BTW GitHub Actions seems pretty cool!


First address in the address book is missing heading

To reproduce:

Create wallet with 3 accounts.
Open address book.

Result:

Expected:
All items should have heading.
Version:
1.1.0-qa.8

Phrase based wallet.


Add MCP73831/MCP73832 battery charge ICs

SUMMARY
These are two simple, cheap and widely used Li-Ion/Li-Po battery charging ICs.
Example application: Adafruit LiPo chargers https://learn.adafruit.com/adafruit-microlipo-and-minilipo-battery-chargers/overview
Datasheet: http://ww1.microchip.com/downloads/en/DeviceDoc/MCP73831-Family-Data-Sheet-DS20001984H.pdf
The difference between the two is the status output: The 73831 status output can directly drive LEDs, while the 73832 status output is open drain.
The "typical application" circuit replicated in LibrePCB:

OPEN QUESTIONS / UNRESOLVED ISSUES

If the status output of the two is electrically different, should there be two separate components?

CHECKLIST

[x] I have read and followed the library conventions.
[x] For packages, I followed IPC7351C (see details in library conventions).
[x] I'm the copyright owner of the added content (i.e. the changes are made by myself, not copied/imported from somewhere else).
[x] I agree to publish all my changes under the CC0 Public Domain License, allowing everyone to use and modify the content without any restrictions.

The two DFN package variants could be added as well, but that depends on the resolution of #17.

Generally everything looks good, but

If the status output of the two is electrically different, should there be two separate components?

I'd say yes since this is an important difference for the ERC. Although not yet fully supported by LibrePCB, I'd recommend to have separate components to avoid issues once LibrePCB supports to distinguish between push-pull and open-drain outputs.

@dbrgn I wanted to quickly apply the separation of the components (see discussion above; commits already pushed) but when I started to update the devices accordingly, I realized that there are actually a lot of different MPNs available for different battery voltages. Some time ago we decided to generally make separate devices for different MPNs and I think especially for this device this really makes sense since it is important to use the correct MPN (due to different electrical function). So I'd suggest to change the device name to the full MPN (just without the "T" for tape&reel).
Now the only questions are: Do you agree on this rename? And which exact MPN did you need when creating this PR (to allow re-using the current UUID without breaking your project)?

So I'd suggest to change the device name to the full MPN (just without the "T" for tape&reel).

Yeah, probably makes sense.

And which exact MPN did you need when creating this PR (to allow re-using the current UUID without breaking your project)?

I don't remember what project I used this with 😄 Adafruit seems to use the code KD4E according to this picture. That corresponds to the MPN MCP73831T-2ACI/OT.

Alright, renamed the device to "MCP73831T-2ACI/OT" (including "T" since "/OT" variants seem to be available only with tape&reel)!


redux form error

Hi, thanks for providing the great flow definitions for popular libraries.
I came across an error with redux-form 7.1.1, any of you also experiencing this?
yarn run v1.2.1
$ flow
Library type error:
flow-typed/npm/redux-form_vx.x.x.js:16
 16:     onChange: (eventOrValue: SyntheticEvent | string | boolean) => mixed,
                                  ^^^^^^^^^^^^^^ SyntheticEvent. Application of polymorphic type needs <list of 0-1 arguments>. (Can use `*` for inferrable ones)

Library type error:
flow-typed/npm/redux-form_vx.x.x.js:17
 17:     onUpdate: (eventOrValue: SyntheticEvent | string | boolean) => mixed,
                                  ^^^^^^^^^^^^^^ SyntheticEvent. Application of polymorphic type needs <list of 0-1 arguments>. (Can use `*` for inferrable ones)

Library type error:
flow-typed/npm/redux-form_vx.x.x.js:18
 18:     onBlur: (eventOrValue: SyntheticEvent | string | boolean) => mixed,
                                ^^^^^^^^^^^^^^ SyntheticEvent. Application of polymorphic type needs <list of 0-1 arguments>. (Can use `*` for inferrable ones)

I tried flow-typed install<EMAIL_ADDRESS>with no luck:
• Searching for 1 libdefs...
• rebasing flow-typed cache...
!! No libdefs found in flow-typed for the explicitly requested libdefs. !!

Consider using `flow-typed create-stub<EMAIL_ADDRESS>to generate an empty libdef that you can fill in.

I'm new to flow so maybe I'm not looking into the right direction.
Thanks for your help.

check this https://github.com/facebook/flow/blob/43695232364c5082b1e5a49acb4f415e60f26045/website/en/docs/react/events.md#L19

OK thanks, I updated my local definition according to the facebook documentation and no more error:
--- a/flow-typed/npm/redux-form_vx.x.x.js
+++ b/flow-typed/npm/redux-form_vx.x.x.js
@@ -13,9 +13,9 @@ declare module 'redux-form' {
     visited: boolean,
     autofilled: boolean,
     error?: string,
-    onChange: (eventOrValue: SyntheticEvent | string | boolean) => mixed,
-    onUpdate: (eventOrValue: SyntheticEvent | string | boolean) => mixed,
-    onBlur: (eventOrValue: SyntheticEvent | string | boolean) => mixed,
+    onChange: (eventOrValue: SyntheticEvent<> | string | boolean) => mixed,
+    onUpdate: (eventOrValue: SyntheticEvent<> | string | boolean) => mixed,
+    onBlur: (eventOrValue: SyntheticEvent<> | string | boolean) => mixed,
     onDragStart: Function,
     onDrop: Function,
     onFocus: Function,

I still don't understand why this is not included in the flow-typed repo.  Shall I submit my definition?

yep

Thanks for the explanation.  Looks like most of my dependencies are not in the flow-typed definition repo and I have to stub them.


compatibility flags may be incorrect

I'm working from h265 bitstreams which bares some similarities to your work here.  I don't think your'e correct in the compatibility value being between 0..32.
compatibility flags are a 32-bit hexadecimal value, where each bit indicates some level of profile compatibility. Each bit set indicates some specific profile that the stream has compatibility with. Can be a value between 0 and FFFFFFFF.    I'm referencing your below comment in the code.
https://github.com/dmnsgn/media-codecs/blob/eb06e09162dd7e2106d87978f9db6937a27d2e06/src/hevc.js#L32

You are right. That kind of make the possible list of codec strings blow up so I'll need to update my example too.
If you have any source to share on the spec for compatibility (and constraints), I am curious.


vscode macOS c++ debug external console does nothing

I am on vscode on mac trying to debug c++ In program where we have to input but it doesnt work as vscode launches external console(terminal) but nothing happens in the terminal.
I am using "externalConsole: true" the terminal launches but debugger doesnt work after launching terminal and nothing happens.
if "externalConsole: false" and program without input then it works perfectly.
I think its problem with latest vscode update for macos.I have windows too and there external console works perfectly while debugging.

VSCode Version:1.44.2
OS Version:10.15.4 MacOS Catalina

Does this issue occur when all extensions are disabled?: Yes

/causedByExtension
Please open an issue for the C++ extension: https://github.com/Microsoft/vscode-cpptools/issues.


python3Packages.uamqp: re-introduce darwin-fixing patch

Description of changes
ZHF: #172160
Patch previously removed in bf0f23274136ddb2b6b0fa91952e1453b990a88d, this fixes x86_64 darwin builds. Including in-repo as upstream rejected it and we shouldn't rely on github keeping the reference around.
Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[x] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[ ] Fits CONTRIBUTING.md.

@GrahamcOfBorg build python3Packages.uamqp

Result of nixpkgs-review pr 173026 run on x86_64-darwin 1

1 package failed to build:

sourcehut.hubsrht

26 packages built:

python310Packages.azure-eventhub
python310Packages.azure-servicebus
python310Packages.celery
python310Packages.django-raster
python310Packages.djmail
python310Packages.flower
python310Packages.kombu
python310Packages.uamqp
python39Packages.azure-eventhub
python39Packages.azure-servicebus
python39Packages.celery
python39Packages.django-raster
python39Packages.djmail
python39Packages.flower
python39Packages.kombu
python39Packages.uamqp
sourcehut.buildsrht
sourcehut.coresrht
sourcehut.dispatchsrht
sourcehut.gitsrht
sourcehut.hgsrht
sourcehut.listssrht
sourcehut.mansrht
sourcehut.metasrht
sourcehut.pastesrht
sourcehut.todosrht

Result of nixpkgs-review pr 173026 run on aarch64-darwin 1


syncserver: 1.8.0 → 1.9.1

This is work in progress attempt at fixing Firefox sync server. The latest version claims to support Python 3 but unfortunately, many of its dependencies don’t (e.g. mozsvc depends on umemcached, which has been abandoned). But we cannot simply use Python 2 because the versions of some dependencies in Nixpkgs no longer support that. That means we need to re-introduce them to python2Packages.
Previous effort to remove this package: https://github.com/NixOS/nixpkgs/pull/74725

I think it's fair to give up this PR in favor of #176835 that provides the maintained Rust version.


[FEATURE] Introduce a version of ? for a type

Add another method ? tlaType in the Builder. This will allow the user to pass the type without involving strings in the API.

I felt the urge to add this one, when refactoring the unit tests that involve types. Will do this one.

closed via #967


cache indexes and bloom filters in memory

This PR introduces in-memory cache for Bloom filters and Sst Indexes and removes the filter map in TableStore

@criccomini ready for another review

Merged! @vigneshc if there is something you want address, feel free to post here or submit a follow-on PR.


Setting too big icon for custom type can break the editor

Godot version
3.5 beta1 and probably master
System information
W10
Issue description

None of the icons adjust texture's size, so using too big texture results in this abomination.
"Fixing" this is probably unfeasible, so at least EditorPlugin.add_custom_type() description should mention a standard size for an icon.
Steps to reproduce

Have EditorPlugin with add_custom_type()
Use some very big texture for the icon

Minimal reproduction project
No response

Related to https://github.com/godotengine/godot/issues/20197.

Hope that this interacts with hidpi where the size might be 3x the normalized pixel size.

Ok I just discovered that, just like https://github.com/godotengine/godot/issues/20197, it doesn't happen with class_name.

Another example :)

We "just" need to enforce a max size I believe.


Lower the probability of hanging when shutting down Kafka storage

I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en
For changelog. Remove if this is non-significant change.
Category (leave one):

Bug Fix

Short description (up to few sentences):
Don't subscribe to topics without intent to poll any messages.

Should almost fix #5615


Documentation Code Sample Indentation

I appreciate we all have our coding styles but the way you've laid out your config JS in the documentation is horrible.  It creates a barrier to adoption.

Hi @lukebarton,
before I try to dig into your issue, would you please be so kind and post a screenshot of one of the code samples you're having troubles with? Just to make sure we're talking about the same display.
Thanks & cheers, Joschi

Thanks for this proof that we're talking about the same thing.
I'm sorry to hear that you're having trouble with the code formatting. In fact, this is the first time the layout gets criticized. On the contrary, I had quite some people praising the formatting in the past, and my whole developer team is totally used to layout code like this. I guess — as so often — it all depends on one's habits. Having said that, please understand that I will wait for some more complaints like your's before I consider changing the layout. In the meantime, you could use the editor of your choice to auto-reformat the code samples to your liking.
Cheers, Joschi

Is your whole developer team used to this layout because you imposed it on them, rather than selecting a commonly used coding standard that already exists?
The coding habits of the maintainer of an open source repository have an very important role to play when selecting an open source project to depend on. Quite obviously, you've chosen to ignore common conventions in favour of your own in this case and it begs the question: "What other off-piste stuff is going to crop up making this project difficult to work with, modify, or fix, in the future?"
Anyway, perhaps you don't value my point in any case.

I feel this discussion has a strong tendency towards getting pointless, so please excuse that I'm keeping it short.
My fellow developers and I evolved and silently agreed our way of formatting our sources because we like(d) it this way and it fits our needs best. I don't think I have to justify that further.
When I wrote my first answer to you yesterday, my neighbour happened to give me a visit. He is a developer as well, but we never worked together so far. I showed him the screenshots you posted without telling him what it was and asked him if he had any problems understanding it. "Not at all, quite the contrary!", he said. Then I told him that it was my code. He said that he had never seen source code formatted like this before, but he confirmed once more that he had no problems reading and understanding it. That's the typical reaction I had so far.
 You say you don't mean to offend anyone, but in fact that's what you do. You don't provide any constructive suggestion, you don't even explain what exactly troubles you so much (I suppose it's the alignment of values, right?), but you insist on complaining. Sorry mate, but as long as that is your strategy you're definitely not the kind of user I'm putting my spare time into these projects for.
Never mind. Cheers, Joschi

Suggestion: Leave arcane coding standards at home.

To put my complaint into more concrete terms:

The way you align all the values means that at short key depths, the values are far to far from the keys in comparison to the longest key.

Why is this a problem?
It's hard to understand a value's relation to a key because it's so far away from the other. You must scan back and forth left to right, with a huge chunk of whitespace in between, making it harder to track along a line.
Column aligning values manageable if you align ONE level of the structure, but you're aligning the entire structure's values at a shared level, regardless of depth (except for the closing brace, somehow you allow that to match the key, which isn't even in close proximity to it's opening brace).
Which segways nicely into:
2. Having the values independent of the object structure prevents you from easily understanding the context of the value within the data structure, or said another way: it's harder to understand the context of the value with relation to the data structure, because it's unrelated to the indentation level, unlike the key. Whilst scanning left and right across the whitespace, to understand the context of a value I have to manually parse the data's structure, looking at keys to understand the structure, trying to reconcile them with values (or opening braces, which contain all of the values underneath them, until I don't see anything then I have to scan all the way across to the left of the screen to hopefully find the closing brace of the type I'm expecting).

If someone adds a key which increases to the total indentation level, they'll need to indent the entire set of values to line them up with your new value column, meaning git blame now has their name against all these lines, because they wanted to add something as simple as one value to the structure. This makes code review harder, since a reviewer should check all the lines edited, where this edit could have been avoided since it's whitespace only. It's easy to spot a mistake if the change is obvious. Whitespace changes can give the impression of 'oh it's just a whitespace change' and the reviewer will gloss over it, missing a mistake which may have been introduced.

In this code example (from your docs), there is a parse error. Line 4 is missing an opening brace?
// «css» sprite with Sass stylesheet resource

var config                  = {
    mode                    :
        css                 : {         // Create a «css» sprite
            render          : {
                scss        : true      // Render a Sass stylesheet
            }
        }
    }
}

Would that not be more easy to spot if the code was formatted like this, more common, style:
// «css» sprite with Sass stylesheet resource

var config = {
    mode :
        css : {                // Create a «css» sprite
            render : {
                scss : true    // Render a Sass stylesheet
            }
        }
    }
}

We're talking about a very simple object here. If this mistake can be made (multiple times I might add) then consider a larger object with a more complex structure. It's not going to get any easier.
I submitted a pull request to update your docs.

I wasn't surprised that there was an issue raised about the formatting, it's really difficult to read if you aren't used to it.
+1 to adopting a more standard style of indentation.

+1 for the point about git blame. It's not practical for reviewing history.

lmao