Extension API:  'languageId' property of ConfigurationScope is ignored in  'WorkspaceConfiguration.update()' call

Does this issue occur when all extensions are disabled?: Extension API problem so Not-applicable

VS Code Version:  1.75.1
OS Version:  MacOS 12.5.1

Steps to Reproduce:

In an extension's activate function add the following:

vscode.workspace.getConfiguration('editor.semanticHighlighting', { languageId: 'xslt' }).update('enabled', true, vscode.ConfigurationTarget.Global);

Actual Result:
The user settings.json file is updated as follows:
{
...
   "editor.semanticHighlighting.enabled": true,
}

Expected Result:
The languageId property in the ConfigurationScope argument of the getConfiguration function should result in the setting being applied to the user settings.json file for just that language:
{
...
 "[xslt]": {
   "editor.semanticHighlighting.enabled": true,
 }
}

It's reasonable to expect WorkspaceConfiguration.update() to use the languageId to update a setting for a specified language in the same way as the corresponding WorkspaceConfiguration.get() function reads a setting for a specified language.

My error. I realise now the update() method takes an argument to control whether languageId is used.


What to do if Google Maps API usage limits are exceeded

The free tier for the Google Maps Javascript API has daily usage limits (25,000 map loads). Post initial launch, we should have a plan for the site if we exceed those limits. Some options:

An error screen ("Whoops, too many taco trucks today!")
Use a non-Google API mapping solution. Decause says: "the good news is, is that we have a #peeps-gis team, and the #proj-eventsmap team has done a non-google API maps base they have used before too"

(kielni, parking this one with you for now, to keep an eye on)

I don't expect this to be a problem: the daily limit is 25,000 and our 30 day usage is 2,226.


Confusing name for global configuration: "renderProfile"

Due to the lack of context of explorer.json; the field "renderProfile" doesn't communicate well what it does.

It's a 0. Could this mean a boolean value? Is this a disabled feature?
Does the "profile" there mean that this disables rendering of other user's Profiles?
After taking a look at what it does, it sets night mode as a default when it's set to 1.

I think this is going to be super tricky to understand in the future. After taking a look at what it does, it's an "aha! it's the default rendering profile to be used!". Let's fix this for more understandable configuration:

Change the name from "renderProfile" to "defaultDayNightMode", or "defaultEnvironmentalRenderingSetup" (avoiding Profile to prevent confusion with avatars or other people, avoiding Settings because of all the settings the user can select) for the name of the configuration, if we're looking to have more rendering profiles in the future.
Change the value from 0 or 1 to "day" and "night" (make it an enumeration in the config, not in the code)

TL;DR: Pay tech debt, turn this
{
  "renderProfile": 1
}

Into this:
{
  "defaultDayNightMode": "night"
}

So it's more understandable for someone modifying the client

I'm not very fond with the name defaultDayNightMode. The current night mode is a purplish halloween stylization. There's the potential of having many night modes, day modes, etc.
I'm leaning more towards defaultRenderStyle or defaultRenderEnvironmentStyle.
It's easy to agree with everything else.

So, let's go with defaultEnvironmentRenderingStyle and have the value 0 mapped to day and 1 to halloween.


Update index.md

another occurrence of the having the folder name given to prepare-environment
What this PR does / why we need it:
fixes the copy/paste to allow direct environment preparation
Which issue(s) this PR fixes:
Fixes #
Quality checks

[x] My content adheres to the style guidelines
[ ] I ran make test or make e2e-test and it was successful

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Hey @ydebaz this isn't strictly necessary right now due to this lab not requiring any setup but it could be in the future so I'll accept the PR. Thanks!


Update doc for local run and deploy edgex without compose file

Needs to add some configuration steps when running app-service and device-service tests.

Fixed on PR #400.


Tests currently fail on Windows

Might be something to do with using fsunit, which sometimes causes these kinds of problems. Seem to have NuGet 2.6.4 locally and something is expecting 2.6.3.
1) Test Error : Projekt.Tests.addFile should fail if file in project
   System.IO.FileLoadException : Could not load file or assembly 'nunit.framework, Version=2.6.
3.13283, Culture=neutral, PublicKeyToken=96d09a1eb7f44a77' or one of its dependencies. The loca
ted assembly's manifest definition does not match the assembly reference. (Exception from HRESU
LT: 0x80131040)
   at Projekt.Tests.addFile should fail if file in project()

why does a testing framework need to be strongly named? just don't get it.
gah. :)
On Sun, 5 Jul 2015 at 19:42 Robin Neatherway<EMAIL_ADDRESS>wrote:

Might be something to do with using fsunit, which sometimes causes these
kinds of problems. Seem to have NuGet 2.6.4 locally and something is
expecting 2.6.3.

Test Error : Projekt.Tests.addFile should fail if file in project
System.IO.FileLoadException : Could not load file or assembly 'nunit.framework, Version=2.6.
3.13283, Culture=neutral, PublicKeyToken=96d09a1eb7f44a77' or one of its dependencies. The loca
ted assembly's manifest definition does not match the assembly reference. (Exception from HRESU
LT: 0x80131040)
at Projekt.Tests.addFile should fail if file in project()

—
Reply to this email directly or view it on GitHub
https://github.com/fsprojects/projekt/issues/24.

Agreed... tiresome. It also works on fine on Mono, my favourite kind of issue, not.

Fixed by #31


configurable listen address for db server

Hi folks, this is a small change that allows the user to configure the listening address for the db server, besides the port.

Thank you for this contribution! Looks good.
You need to sign the contributor agreement, then I can land it:
https://github.com/attic-labs/noms/blob/master/CONTRIBUTING.md

Thank you for this contribution! Looks good.

My pleasure! Thanks for this awesome piece of software.

You need to sign the contributor agreement, then I can land it:
https://github.com/attic-labs/noms/blob/master/CONTRIBUTING.md

Done
I want to submit a couple of other PRs:

update to the latest go and deps.
replace log.Printf lines with some configurable logger. When using noms as a library the logging is inconsistent because noms uses its own logger.

Do you think these types of PRs would be accepted?

Yes, they would be accepted. We want those changes too. @phritz


docs: Fix typo in documentation

The localization page contains a small typo : manfiest.json -> manifest.json

@theovgl Thanks for the PR!


Centralized Scheduled Job Identity Management using IdentityPlugin

Description
Companion PR in core: https://github.com/opensearch-project/OpenSearch/pull/7573
Companion PR in security repo: https://github.com/opensearch-project/security
This PR uses the IdentityService from core to invoke the ScheduledJobIdentityManager if an implementation is provided via the IdentityService. The main idea is to centralize the identities that jobs are associated with in a single secure index owned by the security plugin. The current de-centralized management where plugins store identities of users associated with a job and inject the user's roles into the thread context at job execution is not a viable solution for an ecosystem with 3rd-party code where extensions cannot be implicitly trusted to inject the proper roles for privilege evaluation. The current concept of roles injection will not have an analogy in the extensions ecosystem.
In its place I am proposing a solution to centralize the management of identities associated with scheduled jobs and then call on the security plugin to perform the roles injection (in case of plugins) or issue an access token (in case of extensions). This is a more secure system where the identity cannot be overwritten by a plugin/extension, but management could be performed by a super admin or UX could be developed in the security-dashboards-plugin repo to change identities associated with jobs by modifying the index that identities associated with scheduled jobs are stored in.
This PR takes advantage of the fact that JobSweeper is an IndexOperationListener and hooks into preIndex and postDelete to create and delete entries in the centralized scheduled jobs identity index respectively.
In the security plugin, the implementation for scheduled job identity management introduces a convention for a plugin/extension to supply the identity they would like to associate with a scheduled job on job creation inside the job details document being indexed. Many plugins currently store jobs details and associated identities in system indices owned by the plugins. In order for a plugin to write to its system index it will stash the thread context and then index a document. Because of the thread context stashing, when indexing the document containing jobs details in the plugin's jobs index, there will be no User in the threadcontext during the time preIndex is called in JobSweeper. To solve for this issue, there is a new convention where the plugin can supply an operator field in the document.
i.e.
PUT /.hello-world-jobs
{
    "enabled_time":<PHONE_NUMBER>348,
    "last_update_time":<PHONE_NUMBER>348,
    "name": "hw",
    "lock_duration_seconds": 60,
    "enabled": true,
    "schedule":
    {
        "interval":
        {
            "unit": "Minutes",
            "period": 1,
            "start_time":<PHONE_NUMBER>348
        }
    },
    "operator":
    {
        "user":
        {
            "username": "Craig",
            "roles": "all_access",
            "backend_roles": "admin"
        }
    }
}

OR

{
    "enabled_time":<PHONE_NUMBER>348,
    "last_update_time":<PHONE_NUMBER>348,
    "name": "hw",
    "lock_duration_seconds": 60,
    "enabled": true,
    "schedule":
    {
        "interval":
        {
            "unit": "Minutes",
            "period": 1,
            "start_time":<PHONE_NUMBER>348
        }
    },
    "operator":
    {
        "token": "<encodedOnBehalfOfJwt>"
    }
}

Inside of preIndex the security plugin will read the operator field from the document and modify the document prior to being indexed to remove the operator being stored in the .hello-world-jobs index and instead store it in the .opendistro-security-scheduled-job-identity where there is referential integrity with all plugin jobs indices and the compound key is job_index and job_id.
See below for an example entry in the .opendistro-security-scheduled-job-identity index:
{
    "job_id": "xlkLeIgBMkyX7K74-JX3",
    "job_index": ".hello-world-jobs",
    "created_time":<PHONE_NUMBER>900,
    "last_update_time":<PHONE_NUMBER>900,
    "user":
    {
        "name": "Craig",
        "backend_roles":
        [
            "admin"
        ],
        "roles":
        [
            "all_access"
        ],
        "custom_attribute_names":
        [],
        "user_requested_tenant": null
    }
}

After the operator is removed from the document the plugin/extension is trying to index the resulting document stored in the jobs details index is:
.hello-world-jobs

{
    "enabled_time":<PHONE_NUMBER>348,
    "last_update_time":<PHONE_NUMBER>348,
    "name": "hw",
    "lock_duration_seconds": 60,
    "enabled": true,
    "schedule":
    {
        "interval":
        {
            "unit": "Minutes",
            "period": 1,
            "start_time":<PHONE_NUMBER>348
        }
    }
}

Issues Resolved
Related to: https://github.com/opensearch-project/security/issues/2528
Check List

[ ] New functionality includes testing.

[ ] All tests pass

[ ] New functionality has been documented.

[ ] New functionality has javadoc added

[ ] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@saratvemulapalli @joshpalis @vibrantvarun Would love to know your thoughts on this approach to securing scheduled jobs.

@cwperks Are data flow diagrams / trust boundary diagrams associated with this design?

Below is a diagram of the 1) Job Creation workflow to show how the Identity System intercepts the index operation when a plugin/extensions creates a job to store the identity info in the scheduled job identity index.

I am created 2 others as well for:

Job Execution
Job Deletion/De-scheduling

In this diagram the authz information is being stored in a different location.  While its slightly more secure to hold this information in a different spot that has limited access, it doesn't expand how AuthN/AuthZ information can be handled.
What would it take to augment this design to support external refresh?  By allowing assigning jobs to operate as principals other than the current principal this would be a huge upgrade to the manageability of these jobs.

@peternied The operator on the left hand side of the diagram is up to the plugin to supply when indexing the job details document. That operator does not necessarily need to be the creator of the job. For an extension, as long as that operator is a valid token then you can create the job for a user other than the creator.
When centralizing the identities associated with scheduled jobs in an index owned by the security plugin, its possible to create APIs to manage identities associated with the jobs.

@peternied To capture the problems with existing problems of storing authz outside of the security index I filed a campaign issue here: https://github.com/opensearch-project/security/issues/2846
IMO I would love to solve the problems around dangling references and come up with a strategic way of fetching most up-to-date authz at job execution time going forward but I think its unrealistic to expect that that would be ready for the targeted experimental release of 2.9.0. I think that this design of centralizing the identities so that they are not stored in indices owned by extensions is a good move forward for extensions security and does create a clearer path to removing dangling references to static user authz. It will include the authz initially (same as plugins do now), but in this model the security plugin will have the references in a single place which can then make it possible to update the information on changes to a user or deletion of a role by also updating this index storing the identities associated with scheduled jobs.

Closing for now. Will re-open at a later date with updates.


Added more Testimonials  #898

Fixes issue #898
Before:

After:

Hence Sucessfully added multiple testimonials  with the help of Cards.

Please see the conflicts . Resolve the conflicts . Ensure you pull all the latest changes before pushing your feature/bug fixes to the main branch. After resolving the conflicts, please open a new PR for review.
Thank you!


Sync modal issue on ios:

The sync is not good everywhere very laggy and does not stop for the user

Verified this issue on Tribe app v 2.4.0(629)


Request toolbar layout after drawable loads

Motivation
Fixes #11209
Updating action items in a ToolbarAndroid, or more specifically the native ReactToolbar, after the initial render presently will not always work as expected - typically manifesting itself as new action items not being displayed at all (under certain circumstances).
This seems to be happening because Fresco gets back to us asynchronously and updates the MenuItem in a listener. However when a keyboard is displayed the Toolbar is in a weird state where updating the MenuItem doesn't automatically trigger a layout.
The solution is to trigger one manually.
Test Plan
This is a bit wacky, so I created a sample project:
https://github.com/Benjamin-Dobell/DynamicToolbar
master demonstrates the problem. Run the project, the toolbar action item is scheduled to update every 2 seconds. It works fine until you give the TextInput focus. Once you give it focus the action item disappears and it never recovers (despite on-going renders due to state changes).
You can then checkout the fixed branch, run yarn again, and see that problem is fixed. This branch is using a prebuilt version of React Native with this patch applied. Of course you could (and probably should) also modify master to use a version of RN built by the Facebook CI (assuming that's a thing you guys do).

Works like a charm in my case! thanks very much.

I would really appreciate it if someone from Facebook could take a look at this.
This issue has been present for as long as I've been using React Native and it's a show stopper when trying to update the action bar dynamically on Android e.g. displaying/enabling a "check" (confirm) action item in response to valid text being entered in a text field.
 The test repository doesn't do anything complicated, I just needed to bundle up some action item images somewhere for testing. All the relevant test code is contained in one file:
https://github.com/Benjamin-Dobell/DynamicToolbar/blob/master/index.android.js
I've been having a lot of trouble making release builds with my current patched master-based fork (nothing to do with this patch, just seems to be due to master being a WIP), so I'd love to see this merged into an official release that I can rely on.
Thanks

Awww, 0.45 was released without this being considered. Please don't let this fix slip into obscurity...

@Benjamin-Dobell  Could you please rebase it on master?

@shergin Done.

any news why this isn't merged?

I can verify that this change also fixes #13780 - Please please please merge it.

@Benjamin-Dobell one question:
using your repro works well when I use the apk. but with "reac-native.cmd run-android" I get:

we see the same thing when we try to use your fork against our app. Do you know what that issue might be?

In https://github.com/facebook/react-native/pull/15120 I verified that this commit cherry-picked on master is green on CI. Please consider to merge and release it. It's really important for ud

Something is flaky with the Travis build. But seems unrelated

@forki Yeah, I just rebased in hope I'd see some green lights. 1 out of 2, that's not too bad :wink:
Regarding the packager issue you encountered; maybe just make sure you're using yarn (there's a yarn.lock but no npm-shrinkwrap.json) and clear the packager cache - otherwise I'm not too sure.

We use yarn and we did git clean -xdf
Anyway try to close and reopen the PR to rerun the Travis

@Benjamin-Dobell have you pushed your changes after rebasing? I don't see any new commits here. That should trigger Travis to run again.

Yes he did. But Travis is flaky with unrelated issues

@shergin what is the status here? Anything we can do to help?

💋

any chance this can be merge into 0.47-stable? It's still not in RN 047-rc5

@forki you should comment on https://github.com/facebook/react-native/issues/14840


cant stack gems after 1.2.2

hello so i have some gems from before the update, but they dont go to the same stack anymore

n case i wasnt clear enough, what i mean by that is that if i get the same gem from after the 1.2.2 update, it wont stack with the same gems from the update before


Sweet Berries do not give exp while crouching

If you collect a sweet berries while crouching, it doesn't give exp/money/points, but if you aren't crouching it works correctly.
Jobs version:
<IP_ADDRESS>
Server Type (Spigot/Paper/etc):
Universespigot (also tested on paper)
Server Version (using /ver):
This server is running UniverseSpigot version git-UniverseSpigot-"132b1fb" (MC: 1.20.4) (Implementing API version 1.20.4-R0.1-SNAPSHOT) (Git: 132b1fb on ver/1.20.4-plus-fix)
Relevant plugins (Delete if this isn't needed):
/

ad577e60ff2e5610137af62e7744392f9de74016


Access to inference service within cluster using cluster-local-gateway

This is a question for accessing inference service within cluster. The kfaka example is great but we don't need that in between our services to inference service.
Is it correct if I access the service like this? "default" is the namespace. Example in curl call. It'd be great if we have some documentations on this.
curl -H "Host: model-name-predictor-default.default.svc.cluster.local" \
http://cluster-local-gateway.istio-system.svc.cluster.local/v1/models/model-name:predict -v

@decewei you could directly call like this
curl http://model-name.default.svc.cluster.local/v1/models/model-name:predict

@decewei you could directly call like this
curl http://model-name.default.svc.cluster.local/v1/models/model-name:predict

Thanks!


schemaFile should allow to use any arbitrary location within project.rootDir

Right now, schemaFile always prepend ${project.rootDir}/src/${sourceSet}/schemas/xjc/ to the provided string value. I think it should be straightforward to allow to use any location within project.rootDir.

Hi @x80486 thanks for the comment! I appreciate the interest!
This is something I honestly sat on the fence about when I did the implementation. This plugin evolved over a period of time in my own personal projects and I always had the schemas located outside of any particular source set directory (something like a misc/resources folder). Over time I found that many of the teams I worked with kept asking to put the schemas somewhere within the source set that they belong to. I liked that idea so I went with it.
That being said I'm not opposed to allowing for additional flexibility if thats what the community wants. We'd have to figure out a way to do it that was backwards compatible.
My immediate thought (albeit without putting a whole lot of thought into it) would be to introduce another attribute on the schema DSL where you could specify a schema root directory, which would default to $project.rootDir/src. I'm open to thoughts/suggestions though.

I understand all of that...but I fail to comprehend why would these schemas (only used for code generation) are part of the project sources (or resources). I think about those as URIs: can be located anywhere.

I guess it's how you look at it. Nothing in src/$sourceSet/schemas is packaged with the application. There are many other libraries out there that use this paradigm (fabric8-maven-plugin comes to mind) where you can store kubernetes fragments in src/$sourceSet/fabric8. There are plenty of other conventions that use things like src/$sourceSet/config for things.
That being said I'm open to making a change so that it's more flexible if that's what's needed. I should have some cycles next week.
I'm open to contributions as well.

@x80486 I've implemented this one and will now work on the other one before publishing a new 1.1 version to the Gradle Plugin Portal.
Stay tuned!


Potential NPE case fix

Adding Null check  for  possible NPE Reported over crashlytics and
some other unit tests
@aaustin @Sarkar

:+1:


Adding to the chart list

This is a replacement for #62, as I had to re-fork this repository
Closes #62

@carolynvs I addressed your comments from https://github.com/Azure/helm-charts/pull/62. PTAL


Mac build of v1.8.7-hdcp-vmp1010 fails Gatekeeper acceptance

During our build we use spctl --ignore-cache --no-cache --assess --type execute "$APP_DIR" to verify Gatekeeper will be ok with the release.
With v1.8.7-hdcp-vmp1010 this fails with rejected (invalid destination for symbolic link in bundle). The link is Electron.app/Contents/Frameworks/Electron Framework.framework/Libraries/Libraries, so it's easy to remove.
To be honest I don't know enough about Gatekeeper to be sure of the effect of leaving the link in the app bundle. It might mean users would have to lower the security level to allow apps downloaded from anywhere - but it might mean it's just not valid for the app store and not be relevant.
This is more to document the issue than request a fix so please just close this unless you think I've missed something.

This again, it has happened before. I've never been able to reproduce it during a build though so I'm not sure what is causing it. I'll fix the package and update it, for starters.
I'll let you know once it is up.

The package has been updated, if you want to use the new build make sure to clear your electron-downloader caches.
I'll make another attempt to prevent these in the future, but since it appears to happen intermittently the cause is elusive.

I got lucky and came upon what is almost certainly the cause of this, so we should not be seeing this in future releases.


Better DAG creation Interface

Creating the DAG is currently more complicated than needed. It can be made more simple.

Resolved in release #26


Remove autoconfiguration for binders

Remove reliance on autoconfiguration for binders, preventing them to act on the main application's  dependencies.

squashed and merged as https://github.com/spring-cloud/spring-cloud-stream/commit/bf178360eebaf6eb00ff48bbbfc5c1a182b6f22b


Patch 0.8.3 to support pytorch-lightning 2.3.3

Checklist

[ ] Used a personal fork of the feedstock to propose changes
[ ] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[ ] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[ ] Ensured the license file is being packaged.

With recipe from https://github.com/conda-forge/autogluon.multimodal-feedstock/pull/48 as base, updated the pytorch-lightning constraint, and the build number, leaving everything else unchanged

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.
I do have some suggestions for making it better though...
For recipe/meta.yaml:

ℹ No valid build backend found for Python recipe for package autogluon.multimodal using pip. Python recipes using pip need to explicitly specify a build backend in the host section. If your recipe has built with only pip in the host section in the past, you likely should add setuptools to the host section of your recipe.
ℹ noarch: python recipes should usually follow the syntax in our documentation for specifying the Python version.

For the host section of the recipe, you should usually use python {{ python_min }} for the python entry.
For the run section of the recipe, you should usually use python >={{ python_min }} for the python entry.
For the test.requires section of the recipe, you should usually use python {{ python_min }} for the python entry.
If the package requires a newer Python version than the currently supported minimum version on conda-forge, you can override the python_min variable by adding a Jinja2 set statement at the top of your recipe (or using an equivalent context variable for v1 recipes).


Readme says poetry self:update instead of poetry self update

[x] I have searched the issues of this repo and believe that this is not a duplicate.

Issue
The updating poetry section of the README says that the command is poetry self:update but it's actually poetry self update (no :): https://github.com/sdispater/poetry#updating-poetry

Hello @ric2b ,
thanks a lot for the reminder. This is definitely something we had to change with the 1.0 release. I'm not sure if it's a good idea to do it know. I guess most people will have installed 0.12 before they are looking into the git. And there the syntax is correct.
Maybe we should include a note about the different syntax in the different versions :thinking: .
fin swimmer

At the moment, I think there should be a note for preview users. For example:
Note for preview users: The update syntax is different from the latest stable version. See poetry self --help for details.

I'm relying heavily on the preview version, and this has confused me before.
In my opinion, the Git master should always be coherent, so the README should always document the behavior for whatever you get when checking out the latest revision. This is the case for most projects I've come across.
If users want documentation for older or stable releases, they should look at the respective documentation website (https://poetry.eustace.io/docs/).
Probably it would even make sense to remove the duplication between the README and documentation. I think this has been mentioned in other places before. Then the README can purely focus on installation. An example for this is pyenv.

Maybe documentation could be versioned? With something like https://github.com/zayd62/mkdocs-versioning?

@pawamoy That makes a lot of sense and is what is commonly done in other projects.


Support iojs for $0 stripping

index.js:26 has this code:
if (~x.indexOf('node')) return;

this should be checking for 'iojs' as well. Otherwise, you get this:
• ./bin/gh-annotate --help
Usage:
../../../.nvm/versions/io.js/v1.6.2/bin/iojs bin/gh-annotate <file>
... | ../../../.nvm/versions/io.js/v1.6.2/bin/iojs bin/gh-annotate

@rstacruz https://github.com/bcoe/yargs/pull/139, does that branch do the trick for you?

yes!

@rstacruz sorry for the slow turn around, this should now be fixed in<EMAIL_ADDRESS>please let me know if it works for you.


Support both Swift 3 package manger, and Swift 4

I bet this is easier than all the swift beta faffing in #20

Nah, not worth it.


[DDW-488] Fix NumericInput Carrot Malfunction

This PR fixes two bugs in the NumericInput component.

The first fix addresses the scenario when a user enters numerical digits and then presses .. The cursor should move right to the decimal digits, but this intended behavior does not happen when a user enters exactly 4 digits and then presses .. It needs an additional press of . to move right.

The second fix addresses the scenario when a user enters ctrl-A + del on an amount being displayed in NumericInput, then enters a new amount. The new amount's digits are not in the correct order. For example, the user presses 12345 and gets 23451.

@DominikGuzei can you please take care of releasing this new version on npm so that we can use it in Daedalus? 🙏

@nikolaglumac @MarcusHurney just published 0.7.2 ready for consumption!

Thanks @DominikGuzei - I will bump the version in Daedalus and prepare the PR!

@DominikGuzei @MarcusHurney React-Polymorph version updated in Daedalus: https://github.com/input-output-hk/daedalus/pull/1173
My manual testing shows it works great 🎉
Thanks for the fix @MarcusHurney 👍


run tests via tox before publishing to pypi

added tox config for testing in a non-conda environment.

Hi @k-dominik Thanks for looking into this. Did you run pytest locally?
It would be nice to still have a requirements.txt file with all the versions pined for testing with CI.

Hi @k-dominik Thanks for looking into this. Did you run pytest locally?
It would be nice to still have a requirements.txt file with all the versions pined for testing with CI.

sure, I ran them locally. Why the pinning, Wei? I argue a single source of truth for deps. If we now start adding another file, with different dependencies.... Also what's the purpose? Tox will use setup.py...

Hi @k-dominik Thanks for looking into this. Did you run pytest locally?
It would be nice to still have a requirements.txt file with all the versions pined for testing with CI.

sure, I ran them locally. Why the pinning, Wei? I argue a single source of truth for deps. If we now start adding another file, with different dependencies.... Also what's the purpose? Tox will use setup.py...

@MartinHjelmare has more experiences in best practices for python projects, and recommended that to us for the ImJoy python projects (see our template). As I understand, pining all version in the requirements for CI testing is a recommended because it guarantees a stable and reproducible testing environment. E.g. we will save time in debugging if we have the exact test environment in the CI and locally, today and tomorrow etc. In general, we should not pin version in the setup.py, but for testing it's good to pin the versions.

I think that's overkill - especially with all those additional dependencies (that we don't even test via pip). It adds to maintenance burden and also to developers working on different environments than users see in production. I'd agree to test against something like this with a clear deployment target.

I will merge this for now!
We can continue discussion about whether we should pin, or delay it when we see issues related to that.

yeah let's discuss this in the next meeting.


enhance docker install steps

[x] add docker hub image link
[x] fix md format
[x] fix clone URL (https instead of ssh that is not accessible for everyone)
[x] name the container by adding --name dvga so it doesn't get a random name
[x] add -d to docker run to detach the container, we can still see stdout with docker logs
[x] rename the repository when git clone to avoid the overlong full name

Only one comment, otherwise looks good to me.

Thanks for your contribution <3


network_id parameter in security_groups.create()

The network_id parameter is optional in security_groups.create().
AWS does tie a security group to a network, but OS doesn't. Haven't checked GCE and Azure yet.
Should we remove it altogether or make it mandatory?

conclusion: make it mandatory


Allow setting default tx fee

Allow users to set a default fee amount when selecting "Custom" fee type.

I want to send all my transactions for super-cheap at 0.00001 ..... I keep having to re-type it for every transaction, it is a pain, fix it.

Added this functionality to the wallet at some point... user can enter minimum fee and select Custom to always use the specified minimum fee.


Added backup files

Codecov Report

Merging #202 (0d54715) into master (b2e9353) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #202   +/-   ##
=========================================
  Coverage     70.83%   70.83%
  Complexity      511      511
=========================================
  Files            81       81
  Lines          1577     1577
  Branches        218      218
=========================================
  Hits           1117     1117
  Misses          373      373
  Partials         87       87

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b2e9353...0d54715. Read the comment docs.


CLN: Move boxing logic to BlockManager

[x] closes #12741 closes #12772 closes #12469

[x] tests added / passed

[x] map related boxing

[x] quantile

[x] passes git diff upstream/master | flake8 --diff

added Series.asobject to return boxed object values

remove common/i8_boxer(), Series._maybe_box() (only used by .quantile())

If base direction looks OK, going to add some tests based on the spec.

@sinhrks this is awesome!!!!!
2 small comments.

further pls review: #12469 which I think can be closed upon merging this? and #10207 the underlying issue.

https://github.com/jreback/pandas/commit/0edf9b2d3c47e27238a01b8ed89cef0c22aba319
cleans up the datetime logic & coercion. and makes it more block friendly.
going to merge this, then can come back and fix the frame to use blocks. This is a bit of a special internal method as it is a reduction which we normally don't pass thru to the block manager (so using this raw kw). I have to think about how this works, but this is ok for now. Can clean up in a later PR.

thanks @sinhrks
I may do a PR to make the reductions be a little nicer.


Added preconnect link tag to speed up google font retrieval

Fixes #3328
Add preconnect link tag as suggested by lighthouse. The current SemanticUI configuration requests 4 different font files from this origin, this preconnect should help optimize the connection.

@pnicolli @sneridagh although this improves the current google fonts font loading I wish we could have  a pluggable section in the head to add any needed pre-fetching without having to customize HTML.jsx.
We miss the slots from plone classic main_template where you could of added many things without resorting to
any overrides.

@ichim-david agreed. We tried it in the past, but we can't use Pluggables here (they are not SSR-able).
I could imagine a setting with an array or Map() of components, then render them all in order? So multiple add-ons could subscribe to it?
/cc @tiberiuichim ?

We could use a similar model as the AppExtras, where we register in configuration components that will be rendered in that "slot".

@tiberiuichim oh sure, I didn't recall that we refactored the appExtras in such a way. 😅
The question that I have now is that if @pnicolli addition should go into such a slot, or has sense to be always there by its own.
However, I would like to have such a slot in place soon, tbh.

Slots can have "static" components as well. Maybe it's the moment to introduce them, at least the configuration and the static part? https://github.com/plone/volto/blob/slots_quanta_split_form_undo_prefix_path/src/config/slots.js#L4

This could be superseded by #3492 and #3493
I will either close or move this forward based on the result of those two.


Functional interfaces with default methods are not converted to functions

The generator does not properly recognize functional interfaces that have default methods in addition to one "functional" method. In general, defaultness of methods is lost when generating bindings - not ideal.

It turns out that GraalJS does not support this, and the types are correct.


Support for facet

Hi,
Thanks for the great solr connector!
I'm working on a project that needs to implement features with solr facet module by sending HTTP request. Will there be any support for facet in select API ?
Thanks!

You can always use http module for that. Your request would look like http://localhost:8983/solr/yourcore/select?q=*.*&fq.type="YOURTYPE&wt=json&indent=true&facet=true&facet.field=YOURFACETFIELD, which in Go you can always write like this:
u, _ := url.Parse("http://localhost:8983/solr/YOURCORE/select")
		search := url.Values{
			"q": []string{"*:*"},
			"wt":          []string{"json"},
			"indent":      []string{"true"},
			"facet":       []string{"true"},
			"facet.field": []string{"field_1", "field_2"}, // where fields are actual fields
			"fq":          []string{"type:\"YOURFILTERQUERY\""},
		}
		u.RawQuery = search.Encode()

		req, err := http.NewRequest(http.MethodGet, u.String(), nil)
		if err != nil {
			return errors.WithMessage(err, "service error: creating solr request failed")
		}

		resp, err := http.DefaultClient.Do(req)
		if err != nil {
			return errors.WithMessage(err, "service error: sending request failed")
		}
		defer resp.Body.Close()

		if resp.StatusCode != http.StatusOK {
			return errors.WithMessage(err, "service error: status code not ok")
		}

Not the cleanest way to do so, but works.

#59 I opened a PR adding Solr JSON Faceting Support. The addition is rather simple as much of the plumbing was already in place, but it should support the entire JSON faceting API.


Safe binary to term

Proposed Changes
Use the safe option in binary_to_term calls for SWC. Validate that MQTT topics are valid UTF8 strings in the parser. UTF8 validation is a breaking change, but it is required by the MQTT 3.1.1 and 5.0 specifications.
Types of Changes
What types of changes does your code introduce to this project?
Put an x in the boxes that apply

[x] Bugfix (non-breaking change which fixes non-compliance with MQTT specs)
[ ] New feature (non-breaking change which adds functionality)
[x] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation (correction or otherwise)
[ ] Cosmetics (whitespace, styles...)
[ ] DevOps (Build scripts, pipelines...)

Checklist
Put an x in the boxes that apply. You can also fill these out after creating
the PR. If you're unsure about any of them, don't hesitate to ask on the
mailing list. We're here to help! This is simply a reminder of what we are
going to look for before merging your code.

[x] I have read the CODE_OF_CONDUCT.md document
[x] All tests pass locally with my changes
[x] I have added tests that prove my fix is effective or that my feature works
[x] I have added necessary documentation (if needed)
[x] Any dependent changes have been merged and published in related repositories
[ ] I have updated changelog (At the bottom of the release version)
[x] I have squashed all my commits into one before merging

Further Comments

Great stuff, thank you. Will review as quickly as possible. Those topic tests really call for property based testing... :)

Yeah. I’d agree on the property-based tests. I’m just not sure what properties would have to hold.

Good point, maybe I can come up with some. Certainly not meant as a requirement for this PR.

Looks good.
Let's see whether we encounter any "bad arguments" from those safe binary_to_terms, then we'd know we created hidden atoms before :)

Yeah. If someone does an hot upgrade, a new record name could easily cause this. I’ll test some more this coming week.


Improve the ReflectionProbe class documentation (3.x)

3.x version of https://github.com/godotengine/godot/pull/55831.

Thank you!

Cherry-picked for 3.4.1.


feat(fscomponents): Replace all occurrences of "any" in LoginFormFK component

Description
Replace all occurrences of "any" in LoginFormFK component

@bweissbart Updated


Show small logo in header and also a bigger version in the upper part of the page

[ ] Show small logo in header
[ ] Show big logo in upper part of the page

Why?

Brand recognition
Images are awesome

Refs https://github.com/JabRef/jabref/issues/1177, follow up of  #39.

Done now!


List of matched MSA records

I am trying to figure out the matched records -- I understand it is species-wise MSA matching. (some may include padded MSA)
core.py has the following code (lines 601-602):
list_idx.append(
DCN(torch.einsum("pq,p->q", (gs_matching_mat, target_idx)))
)
During training I see the display (enclosed screen shot). - for two species. One with 2 MSA, another with 25.
I have also enclosed a screen shot of shuffled index (for the last 3 iterations of the training)
Question: Species X has 2 (MSA) seqs. Species Y has 25 seqs. How do I figure which of the 25 seq from chain A (left) got matched to the 25 seq in  chain B (right) of Species Y? (I assume the MSA sequences for each species are numbered 0 per the original MSA dataset) Thank you

I have a case where 5 different species are utilized. Each matrix is clearly shown. How do I pull the records from the (input_left, input_right) records so the final set of matched pair is available. Thank you.

gs_matching_mat / (out put list mats) has the data used to produce the above figures. How to take the index from this matrix to the original input_left / input_right data so I can get the "paired MSA"s. thanks


addition to the help commandHandler

help should additionally have the option of taking in command names as arguments and display the info about the specific command

Yep great idea 👍


[Python] Cannot installed pyarrow==3.0.0 for macos monterey(12.2)

There are currently no wheels available in pypi python3.6 or 3.8 for macos monterey(12.2). This means it's not possible to install versions 3.0.0 of arrow from pypi as the latest uploaded source release is 7.0.0
It would also be useful to upload source releases to pypi...
Reporter: Gideon Dirgahayu
Original Issue Attachments:

Screenshot 2022-02-15 at 14.10.14.png
WhatsApp Image 2022-02-15 at 14.08.12.jpeg

Note: This issue was originally created as ARROW-15686. Please see the migration documentation for further details.

Apologies for the lack of response. In the meantime, there are wheels available for the latest versions for macos 12+, so closing this issue.


Should large images get special treatment?

Is your feature request related to a problem? Please describe.
Currently a large image is placed in the documentation by resizing it down with a simple max-width: 100%; height: auto. For images containing text this can often leave the text unreadable, especially on smaller devices.
Should this be something that an author should be expected to handle (ie get them to supply a :target: to the image directive that links to the image, which would open the image in a new tab), or should the theme be able to handle the problem or at least assist with it?
Describe the solution you'd like
If the theme were to deal with it, my preferred approach would be option 1 as described below
Describe alternatives you've considered

Do a "simple zoom" when clicked on. For example: https://github.com/francoischalifour/medium-zoom
1a. This only really works for images up to a certain size but I don't think it's unreasonable for an author to have to deal with this situation.
Have a "zoom" button that shows over a resized image when hovered over. When clicked, the image is opened in some overlay. The downside here is that it would require some javascript in a theme that otherwise works well without it.
2a. Just opening the image sized to the window would be an improvement but this approach would inevitably lead to feature requests for adding zoom and pan controls.
Don't resize the image and instead have a max-height and overflow: scroll. I think that the scroll bars would add visual clutter though.
3a. This situation is difficult to deal with as an author because whether scroll bars are appropriate or not would vary depending on the image content, the size of the image, and the screen size. We could pick scrolls bars or not depending on the screen size, but I think it's impossible to map media queries to match all cases.

Additional context
None.

2. Have a "zoom" button that shows over a resized image when hovered over.

This won't help on small displays.

Should this be something that an author should be expected to handle (ie get them to supply a :target: to the image directive that links to the image, which would open the image in a new tab), or should the theme be able to handle the problem or at least assist with it?

For anyone wondering what they can provide to various directives: https://docutils.sourceforge.io/docs/ref/rst/directives.html#image
I think a good approach would be to create a Sphinx plugin that can be added into their documentation by projects that care. :)

Closing since I don't think that there should be any special casing in Furo, but doing it in an additional Sphinx plugin would be great!


Post release automated changes for commerce releases

Post release automated changes for azure-arm-commerce

API change check
API changes are not detected in this pull request.


Add live preview to CLI

Resolves GH-168. Might of ended up a bit over-kill but as a week-end project I tried to implement something along the lines of the live-server utility directly into the ModMark cli.
You can now use the command-line tool without providing a output file modmark myfile.md and a live updating preview will be served.  This CLI prints the address of a website where the document can be previewed. Changes made in the document will be updated without having to refresh the browser window. (I use Websockets to send messages to the browser about the new changes.)
This new system will also later allow us to send information about warnings and errors and inject them into the preview for a nicer writing experience were you don't have to keep an eye on the terminal.
I'm sure there are many bugs since I've never used tokio or warp before, but feel free to take a look and leave comments.
Screencast from 2023-03-20 15-20-23.webm

Haha that is really cool! Does it have the same behaviour as doing modmark --watch in.mdm out.html & live-server out.html?


Set Gateway.Status.Addresses

EG needs to set the Gateway.Status.Addresses field with the address that is bound for the Gateway (i.e. the Envoy LB service address). This is necessary in order to make progress with Gateway API conformance.
A related question: do all Gateways use the same address? Does this have the potential to cause any kind of conflict across Gateways/Routes?
xref #65

A related question: do all Gateways use the same address? Does this have the potential to cause any kind of conflict across Gateways/Routes?

For the time being, I suggest we start off simple and have all Gateways use the same Service. Therefore, all Gateways will have the same address. A conflict can occur if a user specifies a Gateway address but I suggest we state this limitation in the v0.2.0 release notes and enforce through validation. Thoughts @arkodg @LukeShu @youngnick?


Fix/react 18

What
Made React 18 the version React libraries and demos are compiled against.
Updated projects to compile with React 18/TypeScript: Included explicit children?: React.ReactNode to component props plus some other minor fixes.
react-client and react-ui libraries are thus built against React 18 while still allowing use with React 16, 17 and 18 via loose peerDependency definition. This should work fine as we're not using any React 18 features.
Why

Make the monorepo work with React 18 (latest) to take advantage of potential speedier rendering for demos.

Let's remember to release new versions of browser/react-ui (which ever is need) after the intro popup fix is merged 👍


meta: remove some outgoing codeowners

Change-type: patch
Signed-off-by: Matthew McGinn<EMAIL_ADDRESS>

@balena-ci I self-certify!

@balena-ci I self-certify!


Fix UE5.3 compilation

Class UBehaviorTreeGraphNode in UE 5.3 from launcher is not exposed to external use via API.
Small workaround to fix compilation

Thanks a lot 🙇
Hopefully this commit will make it's way to 5.4 then...


componentWillMount is deprecated

Hi! Thanks for trying out NativeBase!
Due to the overwhelming requests and issues/questions we ask you to add the following details with your issue.
Please check the existing open/closed issues for a possible duplicate before creating a new issue :)
Also DO fill out the below form to give us a better idea about your environment and help us debug it quicker. Issues without the required details will mostly be unattended to.
react-native: "react-native": "0.54.0"
native-base: "native-base": "2.4.1"
I am receiving the following warning:
YellowBox.js:82 Warning: componentWillMount is deprecated and will be removed in the next major version. Use componentDidMount instead. As a temporary workaround, you can rename to UNSAFE_componentWillMount.

Please update the following components: View

Learn more about this warning here:
https://fb.me/react-async-component-lifecycle-hooks

#1665


dSYM is not uploading anymore

We've started to get build failures due to dSYM upload error:
(_FirebaseCrashlyticsUploadDSymToFirebaseOnMac target) ->
  error : Failed uploading cSYMs due to error : Error Domain=com.twitter.FABCompoundOperation.error Code=4294967293 "(null)" UserInfo={com.twitter.FABCompoundOperation.error.user-info-key.underlying-errors=( [/Users/administrator/VSTSAgent2/_work/1/s/iOS/<MyApp>.iOS.csproj]
  /Users/administrator/VSTSAgent2/_work/1/s/packages/Xamarin.Firebase.iOS.Crashlytics.<IP_ADDRESS>/build/Xamarin.Firebase.iOS.Crashlytics.targets(59,3): error MSB3073: The command "'/Users/administrator/Library/Caches/XamarinBuildDownload/Fbrc-1.10.2/upload-symbols' -gsp '/Users/administrator/VSTSAgent2/_work/1/s/iOS/GoogleService-Info.plist' -p ios 'bin/iPhone/Dev-Release/<MyApp>.iOS.app.dSYM'" exited with code 8. [/Users/administrator/VSTSAgent2/_work/1/s/iOS/<MyApp>.iOS.csproj]

Can this be related to the Fabric shutdown?

Nevermind. That was a temporary issue. Somehow it just disappeared.

@alexshikov  Do you have any idea about this? I have the same issue.

@manjuy124 it was a Google server issue. After a few hours the error stopped to happen.

We are facing this issue from Last 24 hrs.
As this is after build script, build is not getting uploaded to app store on failure of upload dysm script.

Same thing for us, it stopped working on Friday

We're the same :)))

We are having the same issue as well. Any solution or advice is really appreciated.

Simply update the upload-symbols tool to the latest version. It worked for me.

FirebaseCrashlytics.zip
As mention above by @borysf use the latest version of upload-symbols tool. I have attached here latest one. It is working for me.

Hope it work with me

Works like magic 😘

I still observe this issue when I upload DSYM's by special directives in my *.csproj file:
   <FirebaseCrashlyticsUploadSymbolsEnabled>True</FirebaseCrashlyticsUploadSymbolsEnabled>     <FirebaseCrashlyticsUploadSymbolsContinueOnError>False</FirebaseCrashlyticsUploadSymbolsContinueOnError>
It was working a few month ago.

https://firebase.google.com/docs/crashlytics/get-deobfuscated-reports?platform=ios&authuser=0    From this, I got the answer.


feat(querybuilder): add regex operator to querybuilder

This PR was blocked by https://github.com/e-Spirit/fsxa-api/pull/121
it makes sense to review PR121 first since the changes from there have been merged


change execfile for  python2/3 compatibility

Description
Trying to run make with python3 results in an error:
mininet/examples/miniedit.py:3228: undefined name 'execfile'

Apparently, in execfile was removed in python3+:
$ python
Python 3.7.3 (default, Mar 27 2019, 16:54:48)
[Clang 4.0.1 (tags/RELEASE_401/final)] :: Anaconda, Inc. on darwin
Type "help", "copyright", "credits" or "license" for more information.
>>> execfile
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
NameError: name 'execfile' is not defined

Looking at this stack overflow link:
https://stackoverflow.com/questions/436198/what-is-an-alternative-to-execfile-in-python-3
and the source code for pythons lib 2to3 (https://docs.python.org/2/library/2to3.html):
https://github.com/python/cpython/blob/276a84a0a6c694ce227bf36ec2e2e6ec6686170f/Lib/lib2to3/tests/test_fixers.py#L1211-L1213
It seems:
execfile("somefile.py", global_vars, local_vars)

needs to be changed to:
with open("somefile.py") as f:
    code = compile(f.read(), "somefile.py", 'exec')
    exec(code, global_vars, local_vars)

This PR makes that change for parseCustomFile in examples/miniedit.py

I think MiniEdit has not yet been converted to Python 3.

Unfortunately MiniEdit isn't currently tested, so we have to test it manually.
Can you confirm that this change works properly under Python 2 and Python 3?


refactor: updated examples folder structure

created folders for each example
necessary for documenting each example
Description
Please provide a meaningful description of what this change will do, or is for. Bonus points for including links to
related issues, other PRs, or technical references.
Note that by not including a description, you are asking reviewers to do extra work to understand the context of this
change, which may lead to your PR taking much longer to review, or result in it not being reviewed at all.
Type of Change

[ ] Bug Fix
[ ] New Feature
[ ] Breaking Change
[x] Refactor
[ ] Documentation
[ ] Other (please describe)

Checklist

[ ] I have read the contributing guidelines
[ ] Existing issues have been referenced (where applicable)
[ ] I have verified this change is not present in other open pull requests
[ ] Functionality is documented
[ ] All code style checks pass
[ ] New code contribution is covered by automated tests
[ ] All new and existing tests pass

Converted to draft untill: https://github.com/cisco-open/pymultiworld/pull/36 is merged.


Prism 4.6 Returning "Bad Request" when Content-Type header is set

Describe the bug
After upgrading Prism from 4.5 to 4.6, requests that specify a content-type header return with the following error message: [6:24:06 AM] ›     [VALIDATOR] ✖  error     Violation: request Supported content types:
To Reproduce

Given this OpenAPI document (see attached)
swagger.txt

Run Prism

Make a request with Content-Type: application/json

The request will return a 400

Expected behavior
The request should return a 200
Additional context
We're running this on Docker with the public images. Rolling back to 4.5 works as expected (and thank you for such a nice product!)
Screenshots
Environment (remove any that are not applicable):

Library version: 4.6
OS: Mac OS (although Prism is running in the Docker images provided by Stoplight
Browser: Curl
Platform:

gz#8029(related to Zendesk ticket #8029)

I have been hitting the same issue, but after a bit of investigation I think the issue is caused by a dependency. When using the downloadable CLI built assets from https://github.com/stoplightio/prism/releases I see the behaviour described above with 4.6.0 & 4.6.1, but not any previous versions.
If I install using yarn I also see the above issue with 4.5.0 and 4.4.3 (I stopped trying to find the bottom at that point).
Hopefully this little bit of output will be helpful:
[20:46:05] › [HTTP SERVER] get /resource/1234 ℹ  info      Request received
[20:46:05] ›     [NEGOTIATOR] ℹ  info      Request contains an accept header: application/json
[20:46:05] ›     [VALIDATOR] ⚠  warning   Request did not pass the validation rules
[20:46:05] ›     [NEGOTIATOR] ⬤  debug     Unable to find a 415 response definition
[20:46:05] ›     [NEGOTIATOR] ⬤  debug     Unable to find a 422 response definition
[20:46:05] ›     [NEGOTIATOR] ⬤  debug     Unable to find a 422,400 response definition
[20:46:05] ›     [NEGOTIATOR] ⬤  debug     Unable to find a 'default' response definition
[20:46:05] › [HTTP SERVER] get /resource/1234 ✖  error

Additional context
Environment (remove any that are not applicable):

Library version: 4.4.3, 4.5.0, 4.6.0, 4.6.1
OS: Linux (Ubuntu 20.04)

Just wanted to chime in that I've been hitting the same issue. I was running version 4.5.0 mostly without issue. Updated to 4.6.1 and with no other changes start receiving 415 errors for "unsupported/invalid content type". I figured it was a breaking change so I rolled back to version 4.5.0 and the errors have persisted.
To me this aligns with a breaking dependency update. The same "newer" dependency is installed regardless of Prism's version, and this version provides this error status.
FYI we were running this within an Angular client if that matters. May be something not playing nice with the HTTP module.
Open to any suggested fixes or workarounds if possible. Thanks!

Same here with this issue. Me and my colleague have tried POST, PUT, PATCH on an endpoint and getting a 415 error response. We've tried specifying the content-type and also omitting the content-type in out openapi.json. Same error on both tries.
Also looking for any workarounds if anyone happens to discover one, thanks!

Update:
Weirdly, sending "null" works 🤔

Plan to fix:

if there is no body, do not look at the content-type header and do not try to parse the empty body

NOTE: XML seems to work this way so ensure others match

this was introduced as a feature request: https://github.com/stoplightio/prism/issues/1813

Should doc change of #1981 be reverted again due to this (nice) fix?


Docker support for 1:1 environment CI vs local

Docker file for 1:1 environment CI vs local. Note: Docker environment will be optional. We will still be able to run directly on local host machine, but we need a determinist setup to test with the same env that we on CI (for special cases - check clang 18 failure in #29 ).

[ ] Create Docker file which is identical to image that we exactly use on CI (e.g. , pull ubuntu-24.04 from Git Actions, run our scripts to install toolchains).
[ ] Add scripts to avoid duplication of comamnds in CI YMLs vs local flows.

The Makefile has most of the build scripting already.
We may want to explore using docker layers for the different LLVM versions. However, I'm pretty sure the full matrix might then consume all the disk on the SSD on my work laptop.
However, installing multiple compilers can leave some libraries shared between them.


Feature Request: Support eBPF on Windows nodes

Currently documentation says:
Hybrid clusters (with some eBPF nodes and some standard dataplane nodes) are not supported. (In such a cluster, NodePort traffic from eBPF nodes to non-eBPF nodes will be dropped.) This includes clusters with Windows nodes.

However eBPF support is now available for Windows using https://github.com/microsoft/ebpf-for-windows

I believe @song-jiang has started looking into eBPF for Windows - it's still very early days though.
CC @fasaxc

@olljanat Just to set expectations, the windows support for eBPF is moving quickly but it's a long way from having all the features we need.

@fasaxc OK that is nice to here anyway.
Btw what is actual reason that documentation is saying that hybrid clusters are not supported? Is that only because of overlay or does it apply also to envs where Calico is doing BGP peering with ToR switches and outgoing NAT is disabled?

The issue is with BPF's NodePort implementation; it uses an overlay and it requires that there's a BPF program at the destination to "catch" the packet and decap it.

The issue is with BPF's NodePort implementation; it uses an overlay and it requires that there's a BPF program at the destination to "catch" the packet and decap it.

Does that means Linux pod to Windows Pod communication should work ? Only NodePort services won't be routed to Windows nodes ?

Thanks for the enlightenment.
We have some mixed cluster, I soon as I can I'll do some tests.


Request Onboarding to OSC Data Commons

Requesting onboarding for github user: helena-intel
Onboarding resources:

Data Commons environment setup
credentials.env file

Onboarding checklist:

[x] new user invited to os-climate github org
[x] user invited to requested teams

@helena-intel  I have sent invite to os-climate, and added you to the AICoE-OSC-Demo team.
I am going to close this, but if you run into any problems feel free to re-open.

@erikerlandson could you please re-send the invite?

hi all - saw that the invite was still in expired status so just resent


S3 MultipartWriter capability to resume interrupted upload

Problem description
I'm using smart_open to write a big file directly into S3, and for that it has been working great. Thank you for the great package!
The issue is that sometimes the Python process gets killed and I'm left with an incomplete multi-part upload. At the moment I have the S3 bucket lifecycle rule to clean these up after a day, but ideally I wanted to resume the upload instead of just starting from scratch, making the most use of multi-part upload and saving some compute & storage.
After a quick glance at MultipartWriter.__init__, this looks impossible as self._client.create_multipart_upload is always invoked. I wanted to gauge how big of an effort would it be to support such scenario if I somehow am able to supply an UploadId to be used.
Versions
Please provide the output of:
macOS-14.5-arm64-arm-64bit
Python 3.10.12 (main, Sep 16 2023, 13:51:00) [Clang 15.0.0 (clang-15<IP_ADDRESS>)]
smart_open 7.0.4

Checklist
Before you create the issue, please make sure you have:

[x] Described the problem clearly (I tried!)
[x] Provided a minimal reproducible example, including any required data
[x] Provided the version numbers of the relevant software

The issue is that sometimes the Python process gets killed and I'm left with an incomplete multi-part upload.

fwiw, ff the process receives SIGTERM, the with-statement will exit with an exception and thus the terminate() method will be called to abort the multipart upload. so I guess we're only talking about SIGKILL here (e.g. kubernetes/docker killing a subprocess to prevent container PID 1 from going out of memory).

From my experience, recovering failed uploads is too much of a pain in the arse. It is far simpler to restart the upload from scratch. Of course, it's a waste of CPU time and bandwidth, but it's better than a waste of developer and maintainer effort.
That said, if you did want to recover a failed upload, you'd need to reconstruct the following:

The UploadId
The IDs of successfully uploaded parts
The position in the input byte stream from which to resume (so what got uploaded successfully, minus what was in the internal buffers at the time of the crash)

Of these, 3 is the trickiest, because it's not explicitly exposed anywhere. You can't infer 3 from 2 because the uploaded parts may be compressed differently to the input stream. Theoretically, you could have smart_open dump this information periodically to e.g. /tmp/smart_open/uploadid.json, as it uploads each part. If you're interested in a PR to do this, I'm open to that.
The somewhat ugly part would be implementing resume functionality as part of the API. How would this look in Python code?


Batch processing and ImageDataGenerator not parallelized?

Hi,
the way I understood it, I thought that the ImageDataGenerator generates/transforms a new batch while the GPU is processing the current batch.
I placed some print to confirm that, and I found out that everything is sequential:
idg = IDG_test.ImageDataGenerator()
gen = idg.flow_from_directory("./DatasetTest/1x52x52/", target_size=(50, 50), batch_size=4, color_mode='grayscale', class_mode='binary')

for i in range(5):
	print("Ask for data")
	sys.stdout.flush()
	X, Y = gen.next()
	print("Data received. Let's sleep.")
	sys.stdout.flush()
	time.sleep(3)

And here are the outputs:
Ask for data
Before lock
Lock passed
Transforming data
Data Transformed
Data received. Let's sleep.
Ask for data
Before lock
Lock passed
Transforming data
Data Transformed
Data received. Let's sleep.

If things were parallelized, this sequence Data received. Let's sleep... Ask for data would not have happened. In a parallelized mode, I should have got a Transforming Data in the middle of the previous outputs.
Am I right or is there something that I don't understand?
If I am right, how can I modify the ImageDataGenerator to generate and transform a new batch while Keras is working on the previous batch?
Regards,

It's paralyzed in fit_generator. ImageDataGenerator just creates the data.

Ok, thanks!
Is there a way to check that it's correctly parallelized? Because I need to modify the ImageDataGenerator for my own purposes, and I would like to make sure that I don't mess up with the parallelism.

You can use your own keras.utils.OrderedEnqueuer
enqueuer = OrderedEnqueuer(your_data,
                                                           use_multiprocessing=use_multiprocessing)
enqueuer.start(workers=workers, max_queue_size=max_queue_size)
gen = enqueuer.get()
for k in gen:
    # Your data is here
    ...

@Dref360: Thank you for your answer.
I have to test a data generator and I must make sure it's correctly parallelized.
I don't understand the variable your_data in the code your shared. My understanding is the ImageDataGenerator should handle the data. Am I wrong?
What are the workers in your code, how can I create one?


Version bump gradle java

Note: My WSL is not set up to run the viewer properly, so I only tested that Opt builds and that all tests are passing. Would be great to give it a run on a non-WSL setup.
Build changes:

updated build syntax to work with gradle 8+
rebuild the gradle wrapper

Dependencies:

added the guice dependency where appropriate
bumped guice version
bumped mockito version

Closes #86

Using this version bump to address #88 and switch to Java 21.
Established new branch accordingly.


Categorize by Movies/TV Shows

I'm submitting a ...

[ ] bug report
[x] feature request
[ ] support request

General information
Prerequisites

[x] Are you running the latest version?

Description
Would it be possible to make two main categories for Movies and TV Shows? Now when I select any of the entries in the main menu I get Movies and TV shows all mixed up. It also affects the active View type so it switches to the view according to the first entry on the list.
Context (Environment)
Installation

[ ] I installed the plugin via zip from the Releases page
[x] I´m using the Netflix Repo
[ ] I´m using a different source (Please tell which)

Operating System

[ ] Linux (x86/x64)
[ ] OSX (x86/x64)
[x] Windows (x86/x64)
[ ] Linux (ARM)
[ ] Android

Other information
Screenshots

Unfortunately you can't due to the fact the Netflix API is structured.
We do get the information for each item, but there is no way to build a UI like the
the Amazon plugin does.


Fix word wrapping in RST list-table

Remove ".wy-table-responsive table td" CSS stanza

The diff on this PR is gigantic because the CSS is minified.  The diff is effectively this:
$ diff -u theme.css-orig theme.css-new
--- theme.css-orig	2023-08-19 15:08:11
+++ theme.css-new	2023-08-19 15:08:22
@@ -1 +1 @@
-.wy-table-responsive table td,.wy-table-responsive table th{white-space:nowrap}
+.wy-table-responsive table th{white-space:nowrap}

This seems to fix #1505 for me, but I don't know if there's a historical or other deeper reason that that stanza is there in the CSS.

I am not an expert in front-end dev things, but it looks like theme.css might actually be generated, and the source of the wy-table-responsive CSS stanzas comes from https://github.com/snide/wyrm/blob/fd41b56978f009e8c33cb26f384dd0dfaf430a7d/sass/wyrm_core/_table.sass#L144-L151
Since this is not the ecosystem I typically work in, I'm not sure about the right way to proceed here.  Is there a way to get word wrapping enabled in sphinx_rtd_theme tables?


mantle: add a quirk to handle incorrect use of GR_IMAGE_STATE_TARGET_AND_SHADER_READ_ONLY

Battlefield 4 uses this state incorrectly when calculating global illumination, writing into stencil attachment, which causes lighting bugs.

The spec says:
Read-only depth-stencil view allows rendering with read-only access to the depth or stencil aspect of an image while it is also used for read access from the graphics pipeline shaders. Only one of the depth or stencil aspects can be designated as read-only, but not both at the same time. The read-only depth in a view is indicated by the `GR_DEPTH_STENCIL_VIEW_CREATE_READ_ONLY_DEPTH` flag and the read-only stencil is indicated by the `GR_DEPTH_STENCIL_VIEW_CREATE_READ_ONLY_STENCIL` flag at depth-stencil creation time.

If the depth or stencil aspect is used for simultaneous read access as a depth-stencil target and as an image view from the graphic shaders, it has to be in the `GR_IMAGE_STATE_TARGET_AND_SHADER_READ_ONLY` image state. The image subresources in a read-only depth-stencil view that are read from shaders should be transitioned to that state, as
well as this state should be used for binding image view and appropriate aspect for the depth-stencil target.

We're not handling this properly.

Should be fixed with: https://github.com/libcg/grvk/commit/cca3f54612977038aec3ecd18f203e3f592ceee8

Closing this due to the fix, actually the layout can be still VK_IMAGE_LAYOUT_READ_ONLY_OPTIMAL_KHR (on RADV at least), because only access flags do matter in this case.


MGMT-17050 Adds Fleet column in DeviceList entries

https://issues.redhat.com/browse/MGMT-17050
In the Device List page, adds a column to show the fleet that a device is associated to.

The match is done by matching the Fleet's "matchLabels" selector to the Device's labels - all labels should match.

The match is done by matching the Fleet's "matchLabels" selector to the Device's labels - all labels should match.

The device's owner is defined by the device.metadata.owner field.

Draft until we do the correct matching between the device and the fleet.


Pass custom dynamic wrappers and type in FormlyModule.forRoot - fails to recognize type in AOT/production Mode

I am using custom formly wrappers and types in my application and exporting it to constant file.
Then I am importing in my App Module as - FormlyModule.forRoot(formConfigConstant.APPLICATION_CONFIG)
export const APPLICATION_CONFIG: ConfigOption = {
wrappers:[],
types:[]
};
But this fails to recognize types and wrappers when I run application on AOT mode i.e.
ng serve application --aot
Is thr way I can acheive this by passing constant to FormlyModule.ForRoot dynamically?
Thanks

try with FORMLY_CONFIG provider:
import { FORMLY_CONFIG } from '@ngx-formly/core';

export function registerFormlyConfig(): ConfigOption {
  return  {
    wrappers:[],
    types:[]
  };
}

@NgModule({
  imports: [],
  providers: [
    { provide: FORMLY_CONFIG, multi: true, useFactory: registerFormlyConfig },
  ],
})
export class AppModule { }


esp_partition_find_first() is not returning flash_chip details  (IDFGH-5782)

Environment

Development Kit:      ESP32_MINI-1
Kit version :
Module or chip used:  ESP32
IDF version : v4.2.1
Build System:         [Make|CMake|idf.py]
Compiler version : xtensa-esp32-elf-gcc( crosstool-NG esp-2020r3 ) 8.4.0
Operating System:    Windows
(Windows only) environment type: ESP Command Prompt
Using an IDE?: Eclipse
Power Supply:        USB

Problem Description

esp_partition_find_first() does not return flash_chip details but it is required by next function call i.e esp_partition_mmap()  to validate the partition before memory mapping.
We required this while updating the esp_ota_set_boot_partition( ) function.
esp_ota_set_boot_partition() is calling esp_rewrite_ota_data() inside its function which is then calling read_otadata( ) function.
esp_partition_mmap()  is returning error( flash_chip is returning value 0x00 ) at highlighted line as shown in the below image

Expected Behavior

After calling esp_partition_find_first() flash_chip should return values which can be used by esp_partition_mmap()
Actual Behavior

But after calling esp_partition_find_first() flash_chip is returning 0x00 as shown in above image.
Steps to reproduce

We are fetching the partition table
calling the esp_ota_set_boot_partition() function

// If possible, attach a picture of your setup/wiring here.
Code to reproduce this issue
// the code should be wrapped in the ```cpp tag so that it will be displayed better.
#include "esp_log.h"

void app_main()
{
      const esp_partition_t *next_partition = NULL;
      next_partition = esp_ota_get_next_partition( NULL );
      esp_err_t err =  esp_ota_set_boot_partition( next_partition );
}

// If your code is longer than 30 lines, GIST is preferred.
Debug Logs
Debug log goes here, should contain the backtrace, as well as the reset source if it is a crash.
Please copy the plain text here for us to search the error log. Or attach the complete logs but leave the main part here if the log is *too* long.

Other items if possible

[ ] sdkconfig file (attach the sdkconfig file from your project folder)
[ ] elf file in the build folder (note this may contain all the code details and symbols of your project.)
[ ] coredump (This provides stacks of tasks.)

Thanks for reporting, will close due to short of feedback, feel free to reopen.


Can't Start the game. Error: "Failed to resolve adress for hash 0x1817231d"

README
Github is NOT here for support and general questions, it's designed for developers to discuss development and code. If your issue is unrelated to anything technical, do not make an issue, you will be blocked and your issue closed without an answer.
Bug
Operating system: Win10 pro
Game version: 2.13
CET version: 1.33
GPU: I5-12600k
Description
As the title says.
Expected behavior
The game won't start
Reproduction
Install mod with Vortex -> Start -> Error => No start of the game => Me cry ;_(

up

As the first lines of the template state:

Github is NOT here for support and general questions, it's designed for developers to discuss development and code. If your issue is unrelated to anything technical, do not make an issue, you will be blocked and your issue closed without an answer.

Therefore, you are redirected to the discord for support.


Fix unclickable switch center

This change fixes a long-standing issue with the white portion of the Off switch being not clickable.
Issues reported on it here:
https://github.com/Bttstrp/bootstrap-switch/issues/481
and here:
https://github.com/Bttstrp/bootstrap-switch/issues/628
and here, all the same bug, reported since couple of years
https://github.com/Bttstrp/bootstrap-switch/issues/467
Plunker to demonstrate bug (uses existing code)
https://plnkr.co/edit/wXJvctugqNAx00rgUfeg?p=preview
Plunker to demonstrate fix (uses this fork)
https://plnkr.co/edit/DY1Icvv4HyDi2D0PkfdU?p=preview
When using these Plunkers, set the switch to Off state.  Try clicking on the white part of the switch (the part that doesn't say "Off") - notice that it does not switch off in the first Plunker (with bug) and that it correctly switches off in the second Plunker (with my fix)

@hughanderson4 I'm doing some housekeeping after a long time. Can you solve conflicts so I can merge this in?

Hi @LostCrew I cancel old PR and make new one, it is easier for me.  See PR 675
https://github.com/Bttstrp/bootstrap-switch/pull/675
Have a nice day

Superseded by https://github.com/Bttstrp/bootstrap-switch/pull/675

Superseded by https://github.com/Bttstrp/bootstrap-switch/pull/675

hey dude, i took the time to make another pull, like u asked me to


implementation of code

Are you implementing speaker Encoder or speaker Adaptation Approach in the paper?

We have both the implementations, but as of now, only the speaker adaptation approach gives good results. The whole_model branch has the speaker adaptation approach.


Geolines: highcharter

geo_lines_plot() is not easy to support for highcharter with as much flexibility as provided by leaflet.
Planning to provide some support in the future, note requires better understanding of sp -> geo.json than I currently have.


XFAIL collection reflection tests

These tests are far too fragile while we're reworking the ABIs of these types. If the pre-merge CI checked all configurations they might be acceptable (though annoying), but as is this is just an easy way to break the build for little value.
I know @dabrahams considers these tests completely inappropriate altogether for relying on stdlib implementation details, but I'm not willing to make that call quite yet. There's arguably some value in these as a limited ABI checker. Even the names of fields and structs is relevant to lldb (for now?).

"Fixes" rdar://29127854 (reflect_multiple_types failing on 32-bit)

@swift-ci Please smoke test and merge

FYI, when you do this you want to open a bug assigned to the person responsible for the tests,  to get the XFAIL removed.

@Gankro Heh, looks like we can't win: https://ci.swift.org/job/swift-PR-osx-smoke-test/2818/consoleFull#611022238b011c97a-0462-424c-ac47-5640e6148d79 👅

@swift-ci Please smoke test and merge

To disable some test cases, REQUIRES: does the job.
Please open the bug first, then REQUIRES: SR-XXXX or REQUIRES: rdarXXXXXX.

@rintaro cool I didn't know that, thanks.

Woah, neat!

@swift-ci Please smoke test and merge

Changed it to a REQUIRES: rdar, with the relevant rdar being "have a stable ABI for collections"

@swift-ci Please smoke test and merge
(spurious linux failure?)

@Gankro IIRC sadly requests to the CI system have no effect if you say anything else in your comment

@swift-ci Please smoke test and merge

@swift-ci Please smoke test and merge

@Gankro Correct. Please do eyeball the size to make sure it was calculated correctly though.


如何在框架下实现半监督训练？

如题，是否需要额外的包？

@WandernForte I think you can refer to https://github.com/microsoft/SoftTeacher first

@WandernForte I think you can refer to https://github.com/microsoft/SoftTeacher first
谢谢，还有一个问题，我可以在没有标注文件的情况下训练半监督数据吗？（刚接触的小白确实不太懂）
thx, one more question, can i train semi-supervised data without ann_file?


Print statements inside kernel print incorrect value of int64 tensors

I came across a bug using int64 tensors. Here's a minimal reproduction.
MWE:
import torch
import triton
import triton.language as tl

@triton.jit
def ndscore_kernel(ptr):
    value = tl.load(ptr)
    print("value in kernel", value)
    tl.store(ptr, value + 1)

ptr = torch.tensor(42, dtype=torch.int64).cuda()
print("value before kernel", ptr.item())
ndscore_kernel[(1,)](ptr)
print("value after kernel", ptr.item())

Output:
value before kernel 42
pid (0, 0, 0) idx () value in kernel: 0
[...]
pid (0, 0, 0) idx () value in kernel: 0
value after kernel 43

Why does the kernel print 0 instead of 42?
Observations:

Changing the dtype of ptr to torch.int32 correctly prints pid (0, 0, 0) idx () value in kernel: 42

Thank you for the bug report, this looks real, I will see if I can have a look.

I am able to repro this and will work on fixing this.

The issue seems to be with the alignment for the store that sets up 'value' for the vprintf.
The llir for this store has an alignment of 4
store i64 %2, ptr %9, align 4
This results in the value being split across two ptx stores
@%p1 ld.global.b64 { %rd1 }, [ %rd2 + 0 ];
...
st.local.u32 	[%r4+12], %rd1;
shr.u64 	%rd6, %rd1, 32;
st.local.u32 	[%r4+16], %rd6;
I am still not clear about how this split results in 0 being printed.
I see that the alignment is 8 with NVCC
https://godbolt.org/z/Y81rafYPo
llir/ptx files
4060_i64.ptx.txt
4060_i64.llir.txt

Thanks for the detailed analysis! I suspect the alignment of the struct variable passed into vprintf might be wrong.
In your PTX code, the print format (variable printfFormat_0) has the value of
"pid (%u, %u, %u) idx () value in kernel: %llu\n"
which is passed in as the first parameter of vprintf. The second parameter is the address of the struct object, where the last field corresponds to the int64 value. But that field has an alignment of 4 and I think vprint expects 8, so the lower half of the value is actually considered as padding and only the higher part is printed.

The DataLayout passed used while translating to LLVMIR seems to have the wrong alignment for Int64.
If I print  llvmModule.getDataLayout().getABIIntegerTypeAlignment(64) inside mlir::translateModuleToLLVMIR(...), I see (llvm::Align) $2 = (ShiftValue = '\x02'). This means int64 alignment specified in the the DataLayout is 4. I am tracking down the cause for this.


Stops processing when blank results are returned

I'm using this filter to enhance reporting for suricata alerts, and I've recently discovered that when a blank result is returned, it appears to stop processing that particular event. Not sure if this is intended behavior, but if so, it could be beneficial to have a boolean that would allow the output variables to be set to, say, blank_result_returned when this happens.

This case is exactly what the default_hash is designed to cover.
Docs and tests - setup + assertion

Goodness, that's embarrassing that I didn't see that.
Closing issue, thanks!


Callback from animation tree gets called forever if in the end of an animation

Godot version:

3.2.1 stable
OS/device including version:

Windows 7, Intel 64bit, GLES2
Issue description:

If an animation comes from AnimationTree, and the track has a callback in the end of the animation, that callback will be called in repetition forever. If the animation is called from the AnimationPlayer directly it doesn't happen. If the callback is not in the end of animation, it doesn't happen as well. Only happens when called from AnimationTree and the key is in the end of animation. Tested with state machine root only.
Steps to reproduce:

Create AnimationPlayer
Create animation
Add callback track
Add keyframe invoking a callback in the end of the animation duration
Create AnimationTree
Setup for the AnimationPlayer and state machine
Add the animation as start animation

callback will be called in infinite loop
Minimal reproduction project:

In the example below two callbacks are set. The only difference is callback 1 key frame is in the middle of animation, callback 2 is in the end. Callback 1 gets called only once, callback 2 gets called forever.
AnimCallbackTest.zip

Here's a few results from my preliminary investigation:
In the Animation Tree code, there is a check that doesn't call the method if delta is zero :
https://github.com/godotengine/godot/blob/05395cb14fa0fbd270f6d8c63bcb7b80f45f4dfe/scene/animation/animation_tree.cpp#L969-L972
Seems great, however, delta is almost never 0 ; it still has a value set when going from 1 to 1 because it doesn't get updated line 106 here :
https://github.com/godotengine/godot/blob/05395cb14fa0fbd270f6d8c63bcb7b80f45f4dfe/scene/animation/animation_blend_tree.cpp#L88-L107
So far I've tried two things :

Change step to be the real delta (ie if we go outside the range of the animation by .2 with a delta of .3, it gets set to .1) > The method still gets called every frame
Force change step (to try) to be 0 if we go overbounds > Method never gets called; obviously.

To me the issue is that a new Animation State doesn't get created if we go from 1 to 1 (because it's not a change, so the blend_animation doesn't get called), and as we read the delta from the states, it always reads a value, so never skips the method call.

We could say that not triggering a method on the last frame of an animation is ok. So get a range that's [0 - End[. But that's dumb
I'll try looking into creating an Animation State that goes from 1 to 1 with a step of 0, but it doesn't seem super clean and I don't know if it could create other issues with other track types...
Calculate the delta in an other way and change the check in Animation Tree. But i don't know to what. Maybe recheck if time has changed and not trust the value in the animstate? But that would make the presence of delta in the animstate useless...
Or I'm probably just missing something obvious.


Refactor scripts/es-integration-test.sh

Which problem is this PR solving?

OpenSearch integration tests very frequently fail

Short description of the changes

Setup storage once before executing tests (not sure how token tests even worked since the main tests called teardown_es at the end)
Remove -rm from storage Docker commands so that the container is still available to do docker logs after the timeout
Change polling from 5s to 10s, for a total of 600sec
If storage is not reachable in 600sec then kill the container and retry two more times
Use trap to tear down storage (useful for local tests as otherwise container may remain if the tests fail)

@albertteoh fancy to review this too?


Signature Help Documentation is the xml and not human-readable

The signature help uses the xml data and not the summary tag for the documentation of the signature. The specification wants plain text or markdown instead.
Plain text is already used for parameters documentation, it should be the same everywhere. This issue was already raised during the implementation of Structured here, but it was not modified (I don't know why).
I confirmed that VS Code is not using the documentation field so changing it would not break their implementation, but I don't know about other editors, so should I PR or not?
For now on editors that don't do a custom thing for Roslyn, this is shown instead:

We don't use the 'Documentation' property in OmniSharp-vim, we use the StructuredDocumentation.

@AnonymusRaccoon Which OmniSharp host is being used in this scenario? The LSP or STDIO/HTTP? If it is the LSP, then the fix would go in the Handler for the signatureinfo requests. https://github.com/OmniSharp/omnisharp-roslyn/blob/0208ea2280fc1f721ac98c6901a680ae63a2b5a5/src/OmniSharp.LanguageServerProtocol/Handlers/OmniSharpSignatureHelpHandler.cs#L52

I use the lsp mode, but I think it would be better to return a human readable documentation on this field on every mode, since others fields are made for humans to read.

Okay, I will update the PR accordingly.

Replaced by #2392