Login improvements

Contribute to https://github.com/NASA-IMPACT/nasa-apt/issues/469
This PR adds the ability for the user to be logged in automatically once redirected from the hosted cofnito UI.
The library we're using to handle the congito comunication in the frontend (AWS Amplify) does not support being initialized with a token.
If it manages the whole process (login with user and pwd) then it works fine - this is the normal flow we have implemented.
If, on the other hand, cognito UI handles the login then Amplify will not pick up on the token. This is why the user was not logged in.
After quite some digging I found an issue that talked about this exact problem and provided a solution, albeit hacky.
The solution works and I was able to initialize the Amplify session from the provided token.
However this does not work when running localstack (our local aws instance) because it returns the wrong token format in the url.
✅ Cognito:
https://example.com/#id_token=123&access_token=abc&expires_in=3600&token_type=Bearer
❌ localstack:
https://example.com/?id_token=123#id_token=123
@leo Do you know anything about the above?
To test this, set the values in your config/local to the ones in the config/staging. Now that you're connected to the stanging env, go to:
http://localhost:9000/signin

Click Sign up and in the new page url replace /signup? with /login?.

 That makes a lot more sense!
Apparently I wanted to show my displeasure with Amplify 😂


How to distinguish which process the output stream line comes from

I have a output stream looking like this, however it doesn't work reliably because some lines simply do not have a prefix.
const outputStream = {
  write: (data) => {
    if (['[SDK]', '[bundle]', '[dts]'].some((str) => data.includes(str))) {
      sdkStream.write(data);
    } else if (data.includes('[Demo App]')) {
      demoStream.write(data);
    }
  },
};

May I know if there's any way I can tell reliably which process a line is coming form? Many thanks!

Not really. What you have is the best way right now.
However, we can change the output stream to have the command object alongside the text.
This would be a breaking change though.
PRs welcome, should be an easy change!


KNIFT - Extracting boundbox locations in the image

System information

OS Platform and Distribution : Linux Ubuntu 20.04.2 LTS to build aar and run on Android Studio with Gradle
MediaPipe version: v0.8.6
Bazel version: bazel 4.1.0
Solution (e.g. FaceMesh, Pose, Holistic): KNIFT
Programming Language and version ( e.g. C++, Python, Java): Java

GOAL:
As show in the multihands tracking demo/example app, I want to extract the pixel locations of the bounding box of the detected template.
For example if the 1 dollor note is detected - then I want to be able to get the float bounding box pixel locations - eg:
x:50, y:50, w:600 ,h:200 for every frame that it is detected in.
Work done until now:
I was able to make my own template and detect it on the video stream using the a build aar :) Just followed some additional steps than the steps specified on the MediaPipe website
Next up, I made some changes to the template_matching.pbtxt to include an output_stream from the TimedBoxListToRenderDataCalculator as follows: (pasting the graph as a quote)
input_stream: "input_video"
output_stream: "output_video"

output_stream: "labeled_detections"

node {
  calculator: "FlowLimiterCalculator"
  input_stream: "input_video"
  input_stream: "FINISHED:detections"
  input_stream_info: {
    tag_index: "FINISHED"
    back_edge: true
  }
  output_stream: "throttled_input_video"
}

node: {
  calculator: "GpuBufferToImageFrameCalculator"
  input_stream: "throttled_input_video"
  output_stream: "input_video_cpu"
}

node: {
  calculator: "ImageTransformationCalculator"
  input_stream: "IMAGE:input_video_cpu"
  output_stream: "IMAGE:transformed_input_video_cpu"
  node_options: {
    [type.googleapis.com/mediapipe.ImageTransformationCalculatorOptions] {
      output_width: 640
      output_height: 640
      scale_mode: FILL_AND_CROP
    }
  }
}

node {
  calculator: "ImagePropertiesCalculator"
  input_stream: "IMAGE:transformed_input_video_cpu"
  output_stream: "SIZE:input_video_size"
}

node {
  calculator: "FeatureDetectorCalculator"
  input_stream: "IMAGE:transformed_input_video_cpu"
  output_stream: "FEATURES:features"
  output_stream: "LANDMARKS:landmarks"
  output_stream: "PATCHES:patches"
}

node {
  calculator: "TfLiteInferenceCalculator"
  input_stream: "TENSORS:patches"
  output_stream: "TENSORS:knift_feature_tensors"
  node_options: {
    [type.googleapis.com/mediapipe.TfLiteInferenceCalculatorOptions] {
      model_path: "mediapipe/models/knift_float.tflite"
      delegate { xnnpack {} }
    }
  }
}

node {
  calculator: "TfLiteTensorsToFloatsCalculator"
  input_stream: "TENSORS:knift_feature_tensors"
  output_stream: "FLOATS:knift_feature_floats"
}

node {
  calculator: "BoxDetectorCalculator"
  input_stream: "FEATURES:features"
  input_stream: "IMAGE_SIZE:input_video_size"
  input_stream: "DESCRIPTORS:knift_feature_floats"
  output_stream: "BOXES:detections"

  node_options: {
    [type.googleapis.com/mediapipe.BoxDetectorCalculatorOptions] {
      detector_options {
        index_type: OPENCV_BF
        detect_every_n_frame: 1
      }
      index_proto_filename: "mediapipe/models/knift_index.pb"
    }
  }
}

node {
  calculator: "TimedBoxListIdToLabelCalculator"
  input_stream: "detections"
  output_stream: "BOX_LIST:labeled_detections"

  node_options: {
    [type.googleapis.com/mediapipe.TimedBoxListIdToLabelCalculatorOptions] {
      label_map_path: "mediapipe/models/knift_labelmap.txt"
    }
  }
}

node {
  calculator: "TimedBoxListToRenderDataCalculator"
  input_stream: "BOX_LIST:labeled_detections"
  output_stream: "RENDER_DATA:box_render_data"
  node_options: {
    [type.googleapis.com/mediapipe.TimedBoxListToRenderDataCalculatorOptions] {
      box_color { r: 255 g: 0 b: 0 }
      thickness: 5.0
    }
  }
}

node {
  calculator: "LandmarksToRenderDataCalculator"
  input_stream: "NORM_LANDMARKS:landmarks"
  output_stream: "RENDER_DATA:landmarks_render_data"
  node_options: {
    [type.googleapis.com/mediapipe.LandmarksToRenderDataCalculatorOptions] {
      landmark_color { r: 0 g: 255 b: 0 }
      thickness: 2.0
    }
  }
}

node {
  calculator: "AnnotationOverlayCalculator"
  input_stream: "IMAGE_GPU:throttled_input_video"
  input_stream: "box_render_data"
  input_stream: "landmarks_render_data"
  output_stream: "IMAGE_GPU:output_video"
}

Basically creating an output_stream called labeled_detections to be able to access the boundingbox packets.
Similar to how we are able to access the landmark packets from the output_stream in the demo/example applications.
I also changed some parts of the timed_box_list_id_to_label_calculator.cc to in-cooperate my changes:

TimedBoxListIdToLabelCalculator::GetContract
cc->Outputs().Tag("BOX_LIST").Set<TimedBoxProtoList>();

TimedBoxListIdToLabelCalculator::Process
cc->Outputs().Tag("BOX_LIST").Add(output_list.release(), cc->InputTimestamp());

Everything seems to be working, but I am stuck. Trying to access any data from the packet always leads to a crash.
List<DetectionProto.DetectionList> detectionLists = PacketGetter.getProtoVector(packet, DetectionProto.DetectionList.parser());
Crash log:
2021-08-11 14:24:17.294 21000-32015/com.my.mediapipe.apps.myapplication E/libc++abi: terminating with uncaught exception of type absl::lts_2020_09_23::BadStatusOrAccess: Bad StatusOr access

    --------- beginning of crash
2021-08-11 14:24:17.294 21000-32015/com.my.mediapipe.apps.myapplication A/libc: Fatal signal 6 (SIGABRT), code -1 (SI_QUEUE) in tid 32015 (Thread-6), pid 21000 (s.myapplication)

Would this be the correct approach to extract the bounding box locations when a template is matched? Please do guide me on the right track :)

Closing this since I was able to make progress! :D Continuing in #2438

hey, I have the same problem, could you share your solution?


feat: implement on:response hook

🔗 Linked issue
Resolves https://github.com/unjs/nitro/issues/1396

❓ Type of change

[ ] 📖 Documentation (updates to the documentation or readme)
[ ] 🐞 Bug fix (a non-breaking change that fixes an issue)
[x] 👌 Enhancement (improving an existing functionality like performance)
[ ] ✨ New feature (a non-breaking change that adds functionality)
[ ] ⚠ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description
WIP
There's a one issue with this implementation :
toNodeListener isn't compatible with defineNitroResponse, so the presets would need to be refactored to use localCall, or h3s toNodeListener would need to be updated to accept a callback function that can modify the response.
For the hook API name we could use extendResponse instead of modifyResponse
📝 Checklist

[ ] I have linked an issue or discussion.
[ ] I have updated the documentation accordingly.

I don't think implemeting hook this way would be the best idea. Also as you have noticed, only worker presets using localFetch could benefit this and this is against nitro goals.

We have render:response to modify the hook already to modify renderer responses. For genetic hook, if we ever gonna support it, it might be coming from h3. Let's keep the discussion under #1396.

Upstream: https://github.com/unjs/h3/issues/447


Add initial filtering capability and tests to listings service

Issue
CityOfDetroit/affordable-housing-app#63
Addresses # (issue)

[x] This change addresses the issue in full
[ ] This change addresses only certain aspects of the issue
[ ] This change is a dependency for another issue
[ ] This change has a dependency from another issue

Description
Adds an initial filtering capability to the listings service, and some basic tests
Details

Adds the ability to filter by neighborhood, using an exact string match. Other filter types will need to work differently
Adds test scaffolding to the Listings controller
Adds basic tests to the Listings service

Type of change

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Prototype/POC (not to merge)
[ ] This change is a refactor/address technical debt
[ ] This change requires a documentation update
[ ] This change requires a SQL Script

How Can This Be Tested/Reviewed?
Please describe the tests that you ran to verify your changes. Provide instructions so we can review. Please also list any relevant details for your test configuration

[ ] Run yarn test -t "listings" to run the new tests
[ ] Navigate to localhost:3100/listings?neighborhood=Fox%20Creek and observe that the listings are filtered. Try replacing with other neighborhood names (run select neighborhood, count(*) from property group by neighborhood; in the db to see them all)

Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[ ] I have reviewed the changes in a desktop view
[ ] I have reviewed the changes in a mobile view
[x] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[ ] Any dependent changes have been merged and published in downstream modules
[x] I have assigned reviewers
[ ] I have updated the changelog to include a description of my changes

One other question here: should the tests live in /backend/core/src or /backend/core/test? So far it looks like there are only e2e tests in /backend/core/test, but my instinct would be to add these unit tests to that test directory. There may be a good reason to include them in /backend/core/src, though?

@anders-schneider the other unit tests are in the same directory as the code under test, for example: https://github.com/CityOfDetroit/bloom/blob/main/backend/core/src/user/user.controller.spec.ts

Ah sorry I missed that, sounds good on including unit tests in the same directory like you have it!


Outdated version of growl susceptible to command injection

Version
2.6.10
Reproduction link
https://github.com/vuejs/vue
Steps to reproduce
Inspect JS dependencies
What is expected?
Latest version of growl
What is actually happening?
Outdated version of growl

Scanned with Nucleaus code scan

Thank you for your concern, however, Vue has no dependencies, this is all in dependencies of dev dependencies or dev dependencies directly. We will check this and fix it :)


chore: update addon dependencies

preview: https://svelte-dev-git-preview-cli-357-svelte.vercel.app/
this is an automated message

@AdrianGonz97 Marking this as draft, as I remember you saying somewhere that updating the drizzle deps requires further adjustments. Tests seem to be passing though

@AdrianGonz97 Thanks for updating. Is this PR good to go?


jest-runner doesn't work with jest "projects"

Summary
When using a jest config file with projects property, stryker run fails with Jest: Cannot use configuration as an object without a file path. Related: https://github.com/facebook/jest/issues/5421#issuecomment-363274999
Stryker config

module.exports = function(config) {
  config.set({
    mutate: ['src/**/*.(js|ts)?(x)', '!src/**/*@(.test).(js|ts)?(x)'],
    mutator: 'typescript',
    testRunner: 'jest',
    reporters: ['progress', 'clear-text', 'html'],
    coverageAnalysis: 'off',
    jest: {
      projectType: 'custom',
      config: require('./config/jest/jest.config.js'),
    },
  });
};

Test runner config

jest: {
      projectType: 'custom',
      config: require('./config/jest/jest.config.js')
}

Stryker environment

+--<EMAIL_ADDRESS>+--<EMAIL_ADDRESS>+--<EMAIL_ADDRESS>+--<EMAIL_ADDRESS>+--<EMAIL_ADDRESS>+--<EMAIL_ADDRESS>

+--<EMAIL_ADDRESS>
Test runner environment

jest -c config/jest/jest.config.js

module.exports = {
  rootDir: path.join(__dirname, '../../'),
  projects: [
    {
      ...common,
      displayName: 'Foo',
    },
    {
      ...common,
      displayName: 'Bar',
    },
  ],
};

Your Environment

software
version(s)

node
11.12.0

yarn
1.19.1

Operating System
MacOS 10.14.4

Add stryker.log
stryker.log

Hi @anilanar could you please create a small repository with a reproduction of this issue?

Hi! I'm closing this issue for now. If it still persists with Stryker version 4, please open a new issue. Thanks!


npm run build fails on npm v2

Works fine on npmv3, but:
$ npm install
$ npm run build

On npmv 2 yields:
$ npm run build

><EMAIL_ADDRESS>build /Users/rroemer/scm/fmd/builder-decks
> webpack --config webpack.config.dev.js

Hash: a868f206d3f2f91fbe56
Version: webpack 1.12.11
Time: 4215ms
   [0] multi main 40 bytes {0} [built]
    + 387 hidden modules

ERROR in ./~/spectacle/~/history/lib/createBrowserHistory.js
Module not found: Error: Cannot resolve module 'invariant' in /Users/rroemer/scm/fmd/builder-decks/node_modules/spectacle/node_modules/history/lib
 @ ./~/spectacle/~/history/lib/createBrowserHistory.js 9:17-37

ERROR in ./~/spectacle/~/history/lib/createHashHistory.js
Module not found: Error: Cannot resolve module 'invariant' in /Users/rroemer/scm/fmd/builder-decks/node_modules/spectacle/node_modules/history/lib
 @ ./~/spectacle/~/history/lib/createHashHistory.js 13:17-37

ERROR in ./~/spectacle/~/history/lib/createHashHistory.js
Module not found: Error: Cannot resolve module 'warning' in /Users/rroemer/scm/fmd/builder-decks/node_modules/spectacle/node_modules/history/lib
 @ ./~/spectacle/~/history/lib/createHashHistory.js 9:15-33

ERROR in ./~/spectacle/~/history/lib/DOMStateStorage.js
Module not found: Error: Cannot resolve module 'warning' in /Users/rroemer/scm/fmd/builder-decks/node_modules/spectacle/node_modules/history/lib
 @ ./~/spectacle/~/history/lib/DOMStateStorage.js 10:15-33

ERROR in ./~/spectacle/~/history/lib/createDOMHistory.js
Module not found: Error: Cannot resolve module 'invariant' in /Users/rroemer/scm/fmd/builder-decks/node_modules/spectacle/node_modules/history/lib
 @ ./~/spectacle/~/history/lib/createDOMHistory.js 9:17-37

ERROR in ./~/spectacle/~/history/lib/createHistory.js
Module not found: Error: Cannot resolve module 'deep-equal' in /Users/rroemer/scm/fmd/builder-decks/node_modules/spectacle/node_modules/history/lib
 @ ./~/spectacle/~/history/lib/createHistory.js 9:17-38

ERROR in ./~/spectacle/~/history/lib/runTransitionHook.js
Module not found: Error: Cannot resolve module 'warning' in /Users/rroemer/scm/fmd/builder-decks/node_modules/spectacle/node_modules/history/lib
 @ ./~/spectacle/~/history/lib/runTransitionHook.js 7:15-33

ERROR in ./~/spectacle/~/history/lib/deprecate.js
Module not found: Error: Cannot resolve module 'warning' in /Users/rroemer/scm/fmd/builder-decks/node_modules/spectacle/node_modules/history/lib
 @ ./~/spectacle/~/history/lib/deprecate.js 7:15-33

ERROR in ./~/spectacle/~/history/lib/parsePath.js
Module not found: Error: Cannot resolve module 'warning' in /Users/rroemer/scm/fmd/builder-decks/node_modules/spectacle/node_modules/history/lib
 @ ./~/spectacle/~/history/lib/parsePath.js 7:15-33

closing as a dupe of #4 , fixing in the core lib


fix grpc prometheus monitor is allways enabled

Signed-off-by: ningmingxiao<EMAIL_ADDRESS>

/ok-to-test

Can you update the commit description to describe the change?

after this commit will reduce about 6% memory of containerd


try to fix next/previous screen reader timing issue

cc @rperez030

Perfect. The experience is now consistent with the alerts that are sent when focus is in the editor.


NodeJS & Sqlite3 versions issue

The sqlite3 module works with Node.js v0.10.x, v0.12.x, v4.x, and v5.x.
quote from https://www.npmjs.com/package/sqlite3

We run Node v7 now.
Should downgrade version to support this middleware.
:)

on github it says they support v7.x as well
https://github.com/mapbox/node-sqlite3
most likely the details on npmjs are not up to date
if you had a specific problem with it, try installing the version from github instead to see if that fixes it

@OriHoch i see. so we can set package.json to pull this package from GitHub?
hence the Travis-CI failing log

@natekonimbo you can install from github (sqlite3 installation details how to do it) but I'm not sure that will solve the problem on travis
I don't see indication that the problem is related to node version..
I see a lot of other changes done to dependencies and installation process, sqlite3 worked fine in the past, I see no reason for it to stop working now

If I had to guess, I would guess the replacing of npm with yarn is a good candidate for causing this bug..

Fixed.
travis.yml missing node version


[ Tool ] Support Powershell v6+ to determine Windows version in flutter doctor

Powershell v6+ use the executable name pwsh.exe instead of powershell.exe. This change adds support for determining the Windows version on systems that solely use pwsh.exe and don't have powershell.exe on the PATH.
Fixes #156189.

LGTM


CB-18195 BlueprintUtilV4Endpoint.createRecommendationByCredCrn yields…

… bogus GW recommendation even if the blueprint explicitly contains KNOX_GATEWAY

Prefer the host group(s) of role KNOX_GATEWAY as the GATEWAY whenever possible, falling back to the former decision strategy based on host group name & cardinality in the lack of a proper KNOX_GATEWAY match.

A match in some host group is considered feasible only if its cardinality is positive. Matches with a zero cardinality are simply ignored.
In case of multiple feasible matches, the one with the smallest (positive) cardinality wins. If there are more than one such host groups, the choice among them is made based on the lexicographic order of their names (the smallest name picked from the ascending order).

Some code cleanup.
Testing:

Manual testing in local CB using DataEng HA 7.2.7, 7.2.8 and 7.2.15.
Added new UT and updated existing ones.

swagger-compatibility-test errors:
CB_VERSION=2.60.0-b83 CB_TARGET_BRANCH=CB-2.60.0 ./scripts/swagger-check.sh
Tue Aug 16 20:18:34 UTC 2022
Swagger check

Determine previous version number based on current version (which is 2.60.0 from input 2.60.0-b83),
where major version number is: 2, minor: 60, patch: 0
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed

  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
100  3275  100  3275    0     0   5287      0 --:--:-- --:--:-- --:--:--  5282
100  3275  100  3275    0     0   5284      0 --:--:-- --:--:-- --:--:--  5282
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed

  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
100  3773  100  3773    0     0   5363      0 --:--:-- --:--:-- --:--:--  5359
100  3773  100  3773    0     0   5359      0 --:--:-- --:--:-- --:--:--  5359
Target branch for swagger check: CB-2.60.0
Downloading cloudbreak 2.60.0-b83 swagger definition, if possible https://cloudbreak-swagger.s3.eu-central-1.amazonaws.com/swagger-2.60.0-b83.json
change is compatible
2.59.0-b74
Downloading cloudbreak 2.59.0-b74 swagger definition, if possible https://cloudbreak-swagger.s3.eu-central-1.amazonaws.com/swagger-2.59.0-b74.json

================ COMPATIBILITY BREAKS in cloudbreak ================
/usr/lib/python3.8/site-packages/swagger_spec_validator/validator20.py:49: SwaggerValidationWarning: Found "$ref: #/definitions/Images" with siblings that will be overwritten. See https://stackoverflow.com/a/48114924 for more information. (path #/definitions/CloudbreakImageCatalogV3/properties/images)
  warnings.warn(
/usr/lib/python3.8/site-packages/swagger_spec_validator/validator20.py:49: SwaggerValidationWarning: Found "$ref: #/definitions/ImageStackDetails" with siblings that will be overwritten. See https://stackoverflow.com/a/48114924 for more information. (path #/definitions/CloudbreakImageCatalogV3/properties/images/properties/base-images/items/properties/stack-details)
  warnings.warn(
/usr/lib/python3.8/site-packages/swagger_spec_validator/validator20.py:49: SwaggerValidationWarning: Found "$ref: #/definitions/StackRepoDetails" with siblings that will be overwritten. See https://stackoverflow.com/a/48114924 for more information. (path #/definitions/CloudbreakImageCatalogV3/properties/images/properties/base-images/items/properties/stack-details/properties/repo)
  warnings.warn(
/usr/lib/python3.8/site-packages/swagger_spec_validator/validator20.py:49: SwaggerValidationWarning: Found "$ref: #/definitions/Versions" with siblings that will be overwritten. See https://stackoverflow.com/a/48114924 for more information. (path #/definitions/CloudbreakImageCatalogV3/properties/versions)
  warnings.warn(
ERROR rules:
	[MIS-E001] Delete Endpoint: Endpoint(http_verb=<HTTPVerb.GET: 'get'>, path='/v4/{workspaceId}/image_catalogs/image/type/{type}/provider/{provider}/runtime/{runtime}', operation=Operation(getImageFromDefaultWithRuntime)) (documentation: https://swagger-spec-compatibility.readthedocs.io/en/latest/rules/MIS-E001.html)
	[MIS-E002] Changed type: #/paths//v4/{workspaceId}/recipes/name/{name}/delete/responses/200/schema/properties (documentation: https://swagger-spec-compatibility.readthedocs.io/en/latest/rules/MIS-E002.html)
	[MIS-E002] Changed type: #/paths//v4/{workspaceId}/recipes/name/{name}/get/responses/200/schema/properties (documentation: https://swagger-spec-compatibility.readthedocs.io/en/latest/rules/MIS-E002.html)
	[MIS-E002] Changed type: #/paths//autoscale/stack/crn/{crn}/get/responses/200/schema/properties/instanceGroups/items/properties/recipes/items/properties (documentation: https://swagger-spec-compatibility.readthedocs.io/en/latest/rules/MIS-E002.html)
	[MIS-E002] Changed type: #/paths//v4/{workspaceId}/recipes/delete/responses/200/schema/properties/responses/items/properties (documentation: https://swagger-spec-compatibility.readthedocs.io/en/latest/rules/MIS-E002.html)
	[MIS-E002] Changed type: #/paths//v4/{workspaceId}/recipes/post/parameters/1/schema/properties (documentation: https://swagger-spec-compatibility.readthedocs.io/en/latest/rules/MIS-E002.html)
	[MIS-E002] Changed type: #/paths//v4/{workspaceId}/recipes/post/responses/200/schema/properties (documentation: https://swagger-spec-compatibility.readthedocs.io/en/latest/rules/MIS-E002.html)
	[MIS-E002] Changed type: #/paths//v4/{workspaceId}/recipes/get/responses/200/schema/properties/responses/items/properties (documentation: https://swagger-spec-compatibility.readthedocs.io/en/latest/rules/MIS-E002.html)
	[MIS-E002] Changed type: #/paths//v1/distrox/post/responses/200/schema/properties/instanceGroups/items/properties/recipes/items/properties (documentation: https://swagger-spec-compatibility.readthedocs.io/en/latest/rules/MIS-E002.html)
	[MIS-E002] Changed type: #/paths//v4/{workspaceId}/recipes/name/{name}/internal/get/responses/200/schema/properties (documentation: https://swagger-spec-compatibility.readthedocs.io/en/latest/rules/MIS-E002.html)
	[MIS-E002] Changed type: #/paths//v4/{workspaceId}/stacks/{name}/cluster/put/parameters/2/schema/properties/hostgroups/items/properties/recipes/items/properties (documentation: https://swagger-spec-compatibility.readthedocs.io/en/latest/rules/MIS-E002.html)
	[MIS-E002] Changed type: #/paths//v4/{workspaceId}/recipes/{name}/request/get/responses/200/schema/properties (documentation: https://swagger-spec-compatibility.readthedocs.io/en/latest/rules/MIS-E002.html)
	[MIS-E002] Changed type: #/paths//v1/distrox/name/{name}/get/responses/200/schema/properties/instanceGroups/items/properties/recipes/items/properties (documentation: https://swagger-spec-compatibility.readthedocs.io/en/latest/rules/MIS-E002.html)
	[MIS-E002] Changed type: #/paths//v4/{workspaceId}/stacks/post/responses/200/schema/properties/instanceGroups/items/properties/recipes/items/properties (documentation: https://swagger-spec-compatibility.readthedocs.io/en/latest/rules/MIS-E002.html)
	[MIS-E002] Changed type: #/paths//v4/{workspaceId}/recipes/crn/{crn}/delete/responses/200/schema/properties (documentation: https://swagger-spec-compatibility.readthedocs.io/en/latest/rules/MIS-E002.html)
	[MIS-E002] Changed type: #/paths//v4/{workspaceId}/recipes/crn/{crn}/get/responses/200/schema/properties (documentation: https://swagger-spec-compatibility.readthedocs.io/en/latest/rules/MIS-E002.html)
	[MIS-E002] Changed type: #/paths//v1/distrox/crn/{crn}/get/responses/200/schema/properties/instanceGroups/items/properties/recipes/items/properties (documentation: https://swagger-spec-compatibility.readthedocs.io/en/latest/rules/MIS-E002.html)
	[MIS-E002] Changed type: #/paths//v4/{workspaceId}/stacks/{name}/get/responses/200/schema/properties/instanceGroups/items/properties/recipes/items/properties (documentation: https://swagger-spec-compatibility.readthedocs.io/en/latest/rules/MIS-E002.html)
	[MIS-E002] Changed type: #/paths//v4/{workspaceId}/stacks/crn/{crn}/get/responses/200/schema/properties/instanceGroups/items/properties/recipes/items/properties (documentation: https://swagger-spec-compatibility.readthedocs.io/en/latest/rules/MIS-E002.html)
	[MIS-E002] Changed type: #/paths//v4/{workspaceId}/stacks/internal/post/responses/200/schema/properties/instanceGroups/items/properties/recipes/items/properties (documentation: https://swagger-spec-compatibility.readthedocs.io/en/latest/rules/MIS-E002.html)
	[MIS-E002] Changed type: #/paths//v1/distrox/internal/post/responses/200/schema/properties/instanceGroups/items/properties/recipes/items/properties (documentation: https://swagger-spec-compatibility.readthedocs.io/en/latest/rules/MIS-E002.html)
	[MIS-E002] Changed type: #/paths//v4/{workspaceId}/recipes/internal/post/parameters/2/schema/properties (documentation: https://swagger-spec-compatibility.readthedocs.io/en/latest/rules/MIS-E002.html)
	[MIS-E002] Changed type: #/paths//v4/{workspaceId}/recipes/internal/post/responses/200/schema/properties (documentation: https://swagger-spec-compatibility.readthedocs.io/en/latest/rules/MIS-E002.html)
	[MIS-E002] Changed type: #/paths//v4/{workspaceId}/recipes/internal/get/responses/200/schema/properties/responses/items/properties (documentation: https://swagger-spec-compatibility.readthedocs.io/en/latest/rules/MIS-E002.html)
	[MIS-E002] Changed type: #/paths//autoscale/stack/crn/{crn}/{userId}/cluster/put/parameters/2/schema/properties/hostgroups/items/properties/recipes/items/properties (documentation: https://swagger-spec-compatibility.readthedocs.io/en/latest/rules/MIS-E002.html)
===============================================================================

Downloading freeipa 2.60.0-b83 swagger definition, if possible https://freeipa-swagger.s3.us-east-2.amazonaws.com/swagger-2.60.0-b83.json
change is compatible
2.59.0-b74
Downloading freeipa 2.59.0-b74 swagger definition, if possible https://freeipa-swagger.s3.us-east-2.amazonaws.com/swagger-2.59.0-b74.json
change is compatible
Downloading environment 2.60.0-b83 swagger definition, if possible https://environment-swagger.s3.us-east-2.amazonaws.com/swagger-2.60.0-b83.json
change is compatible
2.59.0-b74
Downloading environment 2.59.0-b74 swagger definition, if possible https://environment-swagger.s3.us-east-2.amazonaws.com/swagger-2.59.0-b74.json
change is compatible
Downloading datalake 2.60.0-b83 swagger definition, if possible https://datalake-swagger.s3.us-east-2.amazonaws.com/swagger-2.60.0-b83.json
change is compatible
2.59.0-b74
Downloading datalake 2.59.0-b74 swagger definition, if possible https://datalake-swagger.s3.us-east-2.amazonaws.com/swagger-2.59.0-b74.json

================ COMPATIBILITY BREAKS in datalake ================
/usr/lib/python3.8/site-packages/swagger_spec_validator/validator20.py:49: SwaggerValidationWarning: Found "$ref: #/definitions/Images" with siblings that will be overwritten. See https://stackoverflow.com/a/48114924 for more information. (path #/definitions/CloudbreakImageCatalogV3/properties/images)
  warnings.warn(
/usr/lib/python3.8/site-packages/swagger_spec_validator/validator20.py:49: SwaggerValidationWarning: Found "$ref: #/definitions/ImageStackDetails" with siblings that will be overwritten. See https://stackoverflow.com/a/48114924 for more information. (path #/definitions/CloudbreakImageCatalogV3/properties/images/properties/base-images/items/properties/stack-details)
  warnings.warn(
/usr/lib/python3.8/site-packages/swagger_spec_validator/validator20.py:49: SwaggerValidationWarning: Found "$ref: #/definitions/StackRepoDetails" with siblings that will be overwritten. See https://stackoverflow.com/a/48114924 for more information. (path #/definitions/CloudbreakImageCatalogV3/properties/images/properties/base-images/items/properties/stack-details/properties/repo)
  warnings.warn(
/usr/lib/python3.8/site-packages/swagger_spec_validator/validator20.py:49: SwaggerValidationWarning: Found "$ref: #/definitions/Versions" with siblings that will be overwritten. See https://stackoverflow.com/a/48114924 for more information. (path #/definitions/CloudbreakImageCatalogV3/properties/versions)
  warnings.warn(
ERROR rules:
	[MIS-E002] Changed type: #/paths//sdx/{name}/detail/get/responses/200/schema/properties/stackV4Response/properties/instanceGroups/items/properties/recipes/items/properties (documentation: https://swagger-spec-compatibility.readthedocs.io/en/latest/rules/MIS-E002.html)
	[MIS-E002] Changed type: #/paths//sdx/crn/{clusterCrn}/detail/get/responses/200/schema/properties/stackV4Response/properties/instanceGroups/items/properties/recipes/items/properties (documentation: https://swagger-spec-compatibility.readthedocs.io/en/latest/rules/MIS-E002.html)
===============================================================================

Downloading redbeams 2.60.0-b83 swagger definition, if possible https://redbeams-swagger.s3.us-east-2.amazonaws.com/swagger-2.60.0-b83.json
change is compatible
2.59.0-b74
Downloading redbeams 2.59.0-b74 swagger definition, if possible https://redbeams-swagger.s3.us-east-2.amazonaws.com/swagger-2.59.0-b74.json
change is compatible

Incompatible changes:
- cloudbreak:2.59.0-b74
- datalake:2.59.0-b74
make: *** [swagger-compare] Error 1

These have nothing to do with my changes. :smiling_imp:

integration-test failure in EnvironmentStartStopTest.testCreateStopStartEnvironment:
Cloudbreak await for flow EnvironmentTestDto[name: mock-test-52bc5f4141a940ad9d]: Test timed out, flow did not finish in time. Crn=crn:cdp:environments:us-west-1:cloudera:environment:51eec675-c1d8-4b43-9d84-84936dc97a44, FlowId=8c8ff918-29ee-4a8d-9d41-4bdf27a1bdd9, FlowChainId=null
com.sequenceiq.it.cloudbreak.exception.TestFailException: Test timed out, flow did not finish in time. Crn=crn:cdp:environments:us-west-1:cloudera:environment:51eec675-c1d8-4b43-9d84-84936dc97a44, FlowId=8c8ff918-29ee-4a8d-9d41-4bdf27a1bdd9, FlowChainId=null

SDX audit:
        "notificationType" : "STOPPED",
        "notification" : "Infrastructure successfully stopped",

No clue, retriggering the run.

https://github.com/hortonworks/cloudbreak/pull/13251/files#diff-d5ff8f1ca39a8136bf39603552ca064a33c28be50b2379866d4d7ec4018aed75R278
    return instanceCounts.entrySet().stream()
            .filter(e -> e.getValue().getMinimumCount() <= 1)

shouldn't it be >=1? this was the cause why compute group was selected for gateway because the minimum node count is 0

@sodre90 That whole fallback logic is nonsense; there is no justification to choose one host group over the other one, as we are simply picking the first one in lexicographic order whose count matches the the above condition. I think the idea was to consider a group a GATEWAY if its count is at most 1; multi-node gateways were completely out of scope when this logic was written. As of now, only the DataEng HA has a 2-node GATEWAY (and of course the Heavy Duty DL, but that is a different matter anyway :smile: ). Actually, the <= here possibly could even be replaced with ==, but then there might be custom blueprints that did not have any host groups with a cardinality of exactly 1.
The choice of compute was indeed for the above reason as you mentioned, but only because it did not consider the presence of Knox in the blueprint at all. With the present change, this will not affect any blueprints (custom or built-in) as long as they do explicitly include Knox. As for the ones that do not, I do not see what condition regarding the cardinality would be perfect here. :disappointed:

@lajosrodek I think >= 1 would be better because groups with 0 minimum counts are usually compute / executor groups, but we can do this in another commit.

Thanks, I will raise an improvement ticket for this! :smile:


Game simply crashes when i activate a mod

Describe your bug here. If you are modding, try testing your bug in a clean version of the engine instead. Also, if you're using an older version of JSE, please try the latest version/action build. Also, be sure to check the pinned 'JS Engine: Known Issues' issue, to check if your issue hasn't already been found!
So, I was about to play a mod, but when the game restarted, js engine simply crashed
Command Prompt/Terminal/Crash logs (if existing)
Null Object Reference
flixel/animation/FlxAnimationController.findByPrefix() [line 739]
TitleState.startIntro() [line 374]
TitleState.create() [line 232]
flixel/util/FlxTimer.onLoopFinished() [line 205]
flixel/util/FlxTimer.update() [line 295]
flixel/FlxGame.update() [line 747]
flixel/FlxGame.step() [line 679]
flixel/FlxGame.onEnterFrame() [line 558]
openfl/events/EventDispatcher.__dispatchEvent() [line 426]
openfl/display/DisplayObject.__dispatch() [line 1398]

Have you identified any steps to reproduce the bug? If so, please describe them below in as much detail as possible. Use images if possible.
No response
Are you modding a build from source or with Lua?
Lua
What is your build target?
Windows
Did you edit anything in this build? If so, mention or summarize your changes.
I didnt edit anything
If you use 1.12.0 or earlier, did you have Optimized Chart Loading turned on?
No
Did you check for any similar issues to what you're reporting? Check, then come back here. If there is a similar issue, then do not report the issue, otherwise it will be marked as a duplicate.
No

you deleted the title logo's xml, OR it couldn't find these animations:

I didn't delete the title logo xml

well then, a mod has a custom title logo xml, but it doesn't have these animations:
ENTER_IDLE
ENTER_FREEZE

Btw by title logo you mean the logobumpin file?

Btw by title logo you mean the logobumpin file?

yeah he means that

closing due to inactivity


BFE is Infinity when data connects to deterministic nodes

When an observation connects to a deterministic node, ReactiveMP counts its entropy but doesn't subtract it, leading to infinity value for BFE since the entropy of a PointMass variable is infinity. This problem doesn't happen to stochastic nodes.

That happens because the BFE procedure is divided into three steps:

Count entropies of all edges (including the clamped ones), this step adds a couple of infinities (from clamped PointMass) to the final value (we store them in a separate field) with the assumption that those infinities will cancel out in the second step
Compute factor bound free energy which includes computing an average energy term minus entropies of associated cluster. At this step we assume that the "minus entropy" will cancel out all infinities.
Check that all infinities have been cancelled out and if not, return Inf

For deterministic nodes the second step in the procedure differs, however. Instead of computing an average energy term minus entropies of clusters we simply compute the minus entropy of the inbound edges. This is according to the theory paper. This, however, does not account for the case when observation is connected directly to the outbound edge of the deterministic node. If that happens, the minus entropy of the inbound edges cannot not cancel out the entropy of the outbound edge and that causes problems in the third step. The assumption that all "problematic" entropies will be cancelled out does not hold anymore.
@ThijsvdLaar @ismailsenoz please discuss
What should we do in case if an outbound edge of a deterministic node is connected directly to an observation? Should it be special-cased? As far as I can recall the theory paper does not include this case.

@ismailsenoz @ThijsvdLaar, any thoughts on this one?


Support DNS round-robin balancing through Route53

Our codegen actions for adding/updating A records in Route53 only support single IP as a value. This PR makes them accept a comma-separated list, which will add an unweighted round-robin A record with multiple IPs.
Should also add WRR at some point probably, but I don't care nearly enough to do that.

Why not just use the libcloud DNS code? then at least you're not bound to R53

@tonybaloney I wasn't sure it would support round-robin (took a brief look at the docs and the code, but apparently need to dig deeper), and it was pretty easy to fix in the AWS pack since boto2 does support it for sure.
Overall, in production, especially with mixed environments, I would use libcloud for most things, but I'm still not ready to abandon the AWS pack because it'll feel neglected and sad :cry: There's also some value for the demo in particular: the less layers of abstraction to focus on, the better.

LGTM :+1:


Support gss_localname

Provides a mechanism to call out to gss_localname to translate an
authenticated name (principal) to a local name (e.g. username).
I've confirmed that this works against mit-krb5 1.15 (the commit which added it is from 7 years ago: https://github.com/krb5/krb5/commit/fe12e6f6da58abc3cc3e2d30d3925259ad1fbf6a) and I see that gss_localname was added to heimdal as of 7.1.

Coverage decreased (-0.4%) to 29.791% when pulling 3f49a05b07af5a638d1f86b067b32f595203dc89 on mkomitee:features/gss_localname into 5fb4217df13b8e6878046fe1e5c10e560e1b86dc on apcera:master.

Coverage decreased (-0.4%) to 29.791% when pulling 3f49a05b07af5a638d1f86b067b32f595203dc89 on mkomitee:features/gss_localname into 5fb4217df13b8e6878046fe1e5c10e560e1b86dc on apcera:master.

Coverage decreased (-0.4%) to 29.791% when pulling 3f49a05b07af5a638d1f86b067b32f595203dc89 on mkomitee:features/gss_localname into 5fb4217df13b8e6878046fe1e5c10e560e1b86dc on apcera:master.

I think that this will break builds on macOS.  While it's possible to install newer Heimdal, there's a copy which ships with the OS and, at least originally, the goal for this Go package was to not require the installation of extra system libraries.
Before this could be merged, I think that lib.go would need to add support for tags on the field members, to be able to mark an element as gss:",optional" and then the reflection loader would need to handle failure to resolve by checking for that tag, and if present then don't error out and instead just leave the pointer as nil, then LocalName(/*...*/) would need to check for a nil pointer and error out with "unsupported by library".  You'd probably also want a HasLocalname() bool function.
So there's a way forward, but there's more infrastructure work needed for that.
(I'm not with Apcera any more, I was asked to take a look at the patches).


Log

Hello,
I do not understand I create a webhook
I copy the id https://discord.com/channels/660949208496472074/1105299602044887040
I pass the command pocketcord ServerLog https://discord.com/channels/660949208496472074/1105299602044887040
result seem ok
Command output | [PocketCord] PocketCord is now setup!
but nothing appears in the hook :(
Can you help me please
I use the last PocketMine version
thanks

The latest push should correct this


Add replace xyzBuilder with unified 'outputsBuilder'

Also, not sure what happened to GitHub actions - but it does not show output for some reason :thinking: Anyways, there are two checks - one uses xyzBuilder, other outputsBuilder - they both result in exactly the same nix flake show
What needs to be tackled before merge:

Add @Pacman99 suggestion
Fix tests/examples to use outputsBuilder

If you guys wish to work on it - feel free to just push changes to this branch. But I'm pretty sure that ill find some time tomorrow to fix this up
On a totally unrelated note - @blaggacao thank you for talking me into adding devshell <3 It is so dam convenient

Nice!


Update npm dependencies

This does cause the warning about untested versions of googleapis, but I haven't run into any issues with that so far over the years.
All tests passed.

Seems legit. Thanks @dpogue


network optimization

Network optimization can be combined with deriving urban sewer network from graph

Discussion with Ruben: make the objective function generic, modular so that different Delft3DFm model (basin) can select different type of objective function.


file lacks file extension

After the installation, the file "unzip-http" was lacking the extension ".py". Because of this, the tool could not be used. After correcting this, the tool could be used.
I also have a question about the syntax that is separate from this issue . How are multiple filenames separated?

@oawd what platform are you working on?  The script works well for me on Linux, and I believe it works on OSX too.  Is the executable bit set?
Also, what do you mean about "multiple filenames"?  I think you just have to separate them with spaces?

Ah, yes, the standard CLI separator character.  Glad you got it working!

If you install the latest release with pip3 install unzip-http, there should now be support for unzip_http.py as an executable!


Feature: homewbrew formula

[X] I have read the CONTRIBUTING guidelines

Hi!
It would be very nice to have a homebrew formula, current way with shell script installation is very inconvenient for automatic provisioning.

Hi @pshirshov!
Using brew for installing SDKMAN! sounds like a good idea in theory but seems to pose a few problems in practice:

brew discourages tools that update itself (like SDKMAN! does)
brew by design never modifies files outside HOMEBREW_PREFIX, so you would have to manually modify your .bash_profile to source SDKMAN's init script

brew discourages tools that update itself (like SDKMAN! does)

Though many packages do that.

brew by design never modifies files outside HOMEBREW_PREFIX, so you would have to manually modify your .bash_profile to source SDKMAN's init script

It's possible to add a post-install message to a homebrew package. E.g. try to install JDK on Catalina - and brew will tell you what steps you must take in order to get it working.

Why not simply add sdkman as brew cask ? https://github.com/Homebrew/homebrew-cask/blob/master/doc/development/adding_a_cask.md

The main problem here is what @helpermethod stated above. SDKMAN updates itself, we would first have to do some development to disable this behaviour for brew installations. Also, sdkman has all it's files in user space (home folder), so it will probably be a problem for brew to manage these.

But I can install for example the Google Chrome browser as cask. It also updates itself and does all kinds of things. I don't think the self-update feature is a blocker for implementing sdkman for brew cask.

References https://github.com/Homebrew/brew/issues/10167.

Perhaps someone can create a custom tap for this in their own repo?  It doesnt need to be perfect to be useful.

Any news on this?

I guess now that SDKMAN! is distributed as an SDK itself, that should be doable. Wdyt @marc0der?

Sure. SDKMAN still updates itself once installed, so we probably need a config to turn that off. Also, during installation, we do a bunch of stuff like populating the /var folder and other initialisation tasks.

You can write a cask.

@benkeil Nope, not me. But maybe you can write that cask 😄

@benkeil Work on an initial Brew tap has started but requires some minor changes in sdkman-cli itself.

What happened to this tap. I used it to install SDKMAN and now it's gone?

Hi @iron,
we are currently moving the tap over to the official repository, and in the process I've made the repository private. I'll make it public until the migration is finished.
Sorry for the inconvenience!

Thank you, very much appreciated.

There is now an official Homebrew Tap for SDKMAN! updated automatically with every release.
Installation instructions can be found here:
https://github.com/sdkman/homebrew-tap

@helpermethod Thanks for all your effort. Fantastic work!


tests: add kfp-ui test case in repo level integration tests

Add a test case for reaching kfp-ui and getting back a 200 response.

NOTE: merge after #261

The bundle integration test seems to be failing because of #243, will re-trigger the CI once again.


Ignore tests after running

This is related to the discussion here and adds support for ignoring tests after they run.

Closing this since Fixie 2.0 supports the ability to mark a test case as skipped after it has otherwise executed.
See the documentation for the new test class lifecycle customization approach.
From with your convention's Execute(TestClass) method, within your RunCases block, you can call @case.Execute(...) and after that you can decide to call @case.Skip("Reason for the skip") to override the result of @case.Execute(...).


ci: fix flaky dns-systemd test by waiting a second before running

It appears that occasionally the test runs before DNS sentinel is applied and/or Resources updated.

LGTM. I wonder why, though. If we notify systemd after we've set up the interface and everything, you'd think all other threads on the system should see the interface as set up.

Maybe it's before the Resource is added? Though I thought that happened in the init message.


TEP-0111: Propagated Workspaces Migration to Stable

This issue tracks the migration of Propagated Workspaces to Beta, targeting v0.47.0.
Feature looking for Promotion

Propagated Workspaces
TEP: https://github.com/tektoncd/community/blob/main/teps/0111-propagating-workspaces.md
Docs:

https://github.com/tektoncd/pipeline/blob/main/docs/pipelineruns.md#propagated-workspaces
https://github.com/tektoncd/pipeline/blob/main/docs/taskruns.md#propagated-workspaces

Current Feature Version

enable-api-fields: beta
Raise Feature Version

enable-api-fields: stable
Pipeline Release

v0.40.0
Issues Reported by the Users

None yet (will update if issues are raised)
Dogfooding

None yet (will update if we dogfood)
Examples

Propagating Workspaces in PipelineRuns
Propagating Workspaces in TaskRuns
Propagating Workspaces in PipelineRuns with referenced resources

@chitrangpatel are you available to work on this? This is targeted for 0.47, thanks!

Yes, I will be able to.

/assign

Done in https://github.com/tektoncd/pipeline/pull/6432, thanks @chitrangpatel!
/meow
/close


Xamarin iOS Cycle 8 Service Release 0 issue cache?

I updated to Xamarin iOS Cycle 8 Service Release 0, and updated FFImageLoading from 2.1.7 to 2.1.8, and my images are not cached in the app. I thought it was due to the FFImageLoading update and some other changes I did, so downgraded back to 2.1.7 and it still didn't work.
So in Git I reverted back to the version that's out in the app store, with 2.1.7, and the same issue happens.
Hence why I am wondering it's an issue with Xamarin iOS Cycle 8 Service Release 0.
I am thinking of testing another physical device later, and if it's still exhibiting the same issue, downgrading Xamarin iOS.
Has anyone else experienced this?

Hi @michaeldimoudis,
What do you mean by saying that images are not cached? Could you give more details? I tested FFImageLoading with Xamarin iOS Cycle 8 Service Release 0 and everything works goos so far for me. Do you use any custom FFImageLoading config?

Hi @daniel-luberda
I've been doing some testing, and yea it seems images are re downloaded if the app is started cold, even though they are in the cache. To test this, I opened up my iOS simulator folder path to observe the cache.
I added DownloadStarted event handlers with break points, and confirmed that, even if the image is already in the cache, it downloads the image again when started from cold, and saves it as the same filename. If the app is in memory, and I scroll the list view or go to different pages with different images, if they are in the cache they don't re-download. But on a cold start they do.
I don't think this issue exists on Android. Looks like no one else is reporting it? So not sure why my set up is playing up, as I've been running FFImageLoading with the same config for a few months.
The only custom FFImageLoading config I have is HttpClient as we need an AuthenticatedHttpImageHandler, but exact same code works on Android.
Weird one :( when I have time I might download the repo and try to help solving this issue, see exactly where it's going wrong. Do you have any ideas?
Cheers.

My type: https://github.com/luberda-molinet/FFImageLoading/issues/239

Ohhhh that rings a bell now. I'm going to have to do that. Thanks for reminding me.

I'll change the path in 2.2. I didn't want to do it in 2.1 as it's kind of a breaking change (all images must be re-downloaded after this)

Do you have any suggestions where to put the new cache folder? And should I change anything on the Android side too? My app isn't heavily used yet, but will be in a couple of weeks time, so I can do a straight out change right now without a big impact.

You don't need to change anything on Android
var documents = Environment.GetFolderPath (Environment.SpecialFolder.MyDocuments);
var libdir = Path.Combine(documents,"..", "Library");

Hi @daniel-luberda
Unfortunately that didn't work. I believe I've always had issues with the cache in FFImageLoading, no matter how long I set the DiskCacheDuration, there always seems to be unnecessary web calls made to download already downloaded images.
I managed to get around this in my app and cached images are displayed near instant now.
The way I got around it was, my app supports people uploading photos from their device. So if they did that (I check if the file exists locally), I always set that Source to the locally stored file. Obviously when they download images the Source was always the URL. This as stated above doesn't work as expected for me. So I now also do a check if the file exists in the FFImageLoading disk cache, using MD5 filenames with a ".0" at the end (FYI mine are always .0). So now, if the image is locally, either uploaded by the user or locally in the FFImageLoading cache, I set Source to that file path. If not, only then I set the ImageSource to the url.
And now my app is extremely more faster with no unnecessary web calls made.
It's weird I've been experiencing this issue while others haven't.
So now I've set the disk cache to ~/Library/Caches/FFSimpleDiskCache with this technique, and also updated the Android app to use the same technique.
Thanks

@michaeldimoudis Look at this: https://github.com/luberda-molinet/FFImageLoading/blob/master/source/FFImageLoading.Shared/Cache/SimpleDiskCache.cs#L93
The part after . is cache validity duration in seconds. You have to set it to 0 somewhere (global config or per image view config).

According to https://github.com/luberda-molinet/FFImageLoading/wiki/Xamarin.Forms-API it says default cache duration is 90 days. So I'm not sure that the default is working properly, as I don't specify any cache duration in my images or config, as the 90 days suits my app fine.

Are you sure you didn't override that setting somewhere? eg. ImageService.Init method?

The newest alpha should solve those issues. Please reopen if it didn't work for you. Thanks. The default duration is 30 days, there's an error on wiki.


[Feature request] Possibility to customize highlight.js

Hi!
Would you consider adding the two following configuration parameters:

possibility to disable the default highlight.js build provided in order to include a richer one (with support for more languages) in the static/js folder.
highlighjsTheme : to be able to select one of the highlight.js bundled themes.

I started hacking on this myself and noticed that the highlightjs support in this theme is mostly hardcoded.
I'm looking into making those points customizable from the config.toml. If I come to a usable solution, I'll make a PR.

If you want to load a richer build of highlight.js, just put it in static/lib/highlight.pack.js at the root of your project.
Chroma is the default choice  in next release(4.0.0). This feature is already done in next branch (https://github.com/olOwOlo/hugo-theme-even/commit/77101032aa61cad251fbe02476aa6d1e0df24d74).

If you want to try the next branch, please note that there have been some breaking changes, and there may be more breaking changes afterwards. And you need to rebuild the theme.
# install dependencies
yarn
# build
yarn build


feat: drop Has* interface usage to ease fx adoption

Description

Drop Has* interface usage to ease fx adoption
Related Issue

Motivation and Context

Slowly migrating to cleaner fx integration
How Has This Been Tested?

Screenshots (if appropriate):
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[X] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[X] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[X] I have read the CONTRIBUTING document.
[X] I have added tests to cover my changes.
[X] All new and existing tests passed.

Also drops the deprecated loopback GRPC-JSON gateway

Theoretically, but that would bump to v2 and that requires a huge amount of changes. I've opened other PR's that fix any breaks.


@l2succes => News Panel on mobile /articles

Fetches recent news articles for mobile /articles route
Renders NewsPanel component after first article if user is admin and has News Articles
Adds unica font family to mobile /articles route

Reassigning to @l2succes ! Would be great to get more Grow folks involved in the Publishing-like PRs.

Looks good! And yes I'll definitely be around to help on some Publishing features after we're done with the Auth modals :)


sentence transformer version

Hello all,
Just wondering, is newer sentence transformer (2.3.0 or newer) compatible with the current h2ogpt? I upgraded it since I need to try out a new embedding model, "Salesforce/SFR-Embedding-Mistral". But afterwards gen.py and make_db.py got issue with hkunlp embedding model.
thanks,
C

There's some things in langchain etc. that required <2.3.0 so we  have:
reqs_optional/requirements_optional_langchain.txt:sentence_transformers>=2.2.2,<2.3.0

Thank you!


ECONNREFUSED but pigpiod is running?

Having this issue where homebridge-rpi is not connecting to the local device port. pigpiod is listening on 8888 but it keeps spitting out econnrefused. Any ideas what I'm doing wrong here?

Nevermind I figured it out. Had to kill pigpiod and restart.

I was having the same problem, thanks!


Add coverage for Blueprint request process methods

Add test to cover following methodss to the Blueprint object:
before_request, after_request, before_app_request,
before_app_first_request, after_app_request.
This PR increases the coverage of flask.blueprints by 6%.

I made another commit to include the teardown_request and teardown_app_request methods.


Actions Library Quickstart

Added actions libraries for LinkedIn, Twitter, Instagram, Opentable as well as an easy client interface to call these different actions and import the necessary helpers based on the apps to inject
For review by @grant

@zcsabbagh FYI, I added a patch to this PR. When working on this PR, first try this patch and ensure it works. Then merge that patch, then send this PR back for me for review.
Patch: https://github.com/anon-dot-com/examples/pull/50


Add rollup command

add command rollup to the root package.json

I'm pretty confident that this was working before so marking it as a bug.


(MODULES-3977) DSC - WMF 5.1 fix

The dsc module uses the PowerShell Manager code from the powershell
module. The powershell module was recently updated to work on WMF 5.1
and uses named pipes. This PR adds this fix to the dsc module.

@jpogran Looks like we'll need to update the spec tests as well.  Appveyor timed out.

@glennsarti I think we hit a temporary problem with appveyor. puppet 3.0 and ruby 1.9.3 took 1 min, but puppet 3.0 and ruby 2.0 took over 1 hour? re-kicking this


Typo in Chapter 3 documentation

There is a typo in the Wiki in Chapter 3:
It is faily simple to instance a PC sprite, I think it should be fairly not faily.

Fixed. Thanks for the reminder. <3


Remove CupertinoSystemColors in favor of CupertinoColors

Description
Making iOS 13 colors compile-time constants. Since we don't change the appearance of widgets based on the OS version, dynamically updating color values may not be the best strategy.
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

[x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[x] I signed the CLA.
[x] I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
[x] I updated/added relevant documentation (doc comments with ///).
[ ] All existing and new tests are passing.
[x] The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
[x] I am willing to follow-up on review comments in a timely manner.

Breaking Change
Does your PR require Flutter developers to manually update their apps to accommodate your change?

[x] Yes, this is a breaking change (Please read Handling breaking changes). Replace this with a link to the e-mail where you asked for input on this proposed change.
[ ] No, this is not a breaking change.

@HansMuller @justinmc should I apply /gray/grey/ to existing constant names (e.g. inactiveGray, darkBrackgroundGray) too?


[FEATURE] Restrict maximum spacing

Is your feature request related to a problem? Please describe.

Describe the solution you'd like

Additional context

About the issue
If a participant does poorly early on in a study, QUEST will suggest massive letter sizes. This causes stimuli to overlap with each other and/or fixation, or extend beyond the screen. The goal is to have stimuli be presented at up-to, but not exceeding, the maximum size at which all stimuli can be presented correctly.


Checkboxes in table

I have TableFilter applied to a table I pull back from a database. On each row there is a checkbox.
<input name="emailsend<%=orderlineno%>" type="checkbox" id="emailsend<%=orderlineno%>" value="TRUE"/>
On the header row I have another checkbox that enables the users to "select all checkboxes"
<input name="ticktoggle1" type="checkbox" id="ticktoggle1" onclick="selectall1();" />

<script type="text/javascript">
<!--
function selectall1() {

  for (var i = 0; i < document.forms['form1'].elements.length; i++) {
    var e = document.forms['form1'].elements[i];

    if ((e.name.charAt(0) == 'e') && (e.type == 'checkbox')) {
      e.checked = !e.checked;
    }
  }
}
-->
</script>

The problem is, if my table is filtered, it selects ALL the tickboxes regardless of the filter. Is there anyway for it to take the tablefilter into consideration.

Hi @emzipoo4u,
Please refer to this answer: https://github.com/koalyptus/TableFilter/issues/178#issuecomment-209471647
Cheers

Thank you, but no idea how to implement this.

OK, so I see we can get an array with a comma between values, again, no idea how to use this. I am not a JavaScript programmer.

@emzipoo4u,
I will try a certain point in the future to provide a demo showing how to implement that.
Please note, I don't provide general javascript support, issues raised here have to be closely related to the plugin (ie enhancement, bug fix, regression).
Cheers

@koalyptus  - yes please I think it would be much appreciated as that other person seems to be struggling too.

@koalyptus - How long would It take and how much would you charge for helping me integrate it ?

Sorry @emzipoo4u I don't have capacity for that at the moment, already too stretched :P

@emzipoo4u I just published the Custom checkbox selection demo that I hope will help you.
Cheers


Consider returning the default value instead of nil, when sending :first or :last to an empty collection

It is my understanding  that all these sorted collections rely ultimately on the behaviour of sorted array, which right now is returning nil always for an empty collection, regardless of the default configured value when the collection is instantiated. Besides of returning the default value, also consider adding first_if_empty(&block_closure) and :last_if_empty(&block_closure) and/or allowing to optionally pass an a block to :first and :last in the same manner as :fetch does.
By the way, thanks for publicly sharing this collection of collections in the first place. All of these should be included in the standard library.

@stormwatch That's an interesting idea.
It makes sense, but I'd need to weight it against the simplicity of keeping the API between the three containers the same. If it were to happen, it would be introduced in a 2.0.0 release because it's not backwards compatible. I'd want to see more interest or need for this change before moving forward.
If there is a situation where Hash returns the default value, but SortedHash doesn't, I would consider that a bug, as my goal is to match Hash's API as closely as possible.
Thanks for your insights and for the kind words about the library. I appreciate your support and feedback!


operator bug right at starting

Bug description
something isn't being proto'ed correctly.
Expected behavior
no display of problem.
Steps to reproduce the bug
Deploy Managed Istio in IKS.
first 20 lines of logs...
2019-11-24T22:11:52.060245Z     info    Reconciling IstioControlPlane
proto: tag has too few fields: "-"
2019-11-24T22:11:52.094644Z     error   json: cannot unmarshal string into Go value of type map[string]json.RawMessage

Version (include the output of istioctl version --remote and kubectl version and helm version if you used Helm)
1.4.0
How was Istio installed?
standalone operator 1.4.0 with ICP
Environment where bug was observed (cloud vendor, OS, etc)
IKS + Istio 1.4.0.

This is a side effect due to the structs being generated through protoc (specifically it's due to hidden fields being present). It's harmless and there's no easy way to get rid of this except for hacking the generated structs.


[WFCORE-5469] Add version 15 of the WildFly Elytron model and schema

https://issues.redhat.com/browse/WFCORE-5469

@darranl Just FYI, this is no longer a draft PR and is ready for review.

@jmesnil FYI I have added an approval on this one, if you agree I think we should just get it merged without waiting for a subsystem change.
In the unlikely event we don't make any changes to the Elytron subsystem during WildFly 25 development we can revert bit merging helps eliminate topic branches going stale and taking up space in the queue..


MM-40770: Edited indicator icon overlapping is fixed

Summary
Fixes an issue on "Edited" indicator icon overlaps text on certain browsers
Note for tests: please check it on all major browsers: Safari, Firefox, Chrome
Ticket Link
Fixes https://github.com/mattermost/mattermost-server/issues/19252
Screenshots

before
after

Release Note

@sinansonmez sadly this PR is not needed, which could have been prevented earlier.
see comment with my explanation here: https://github.com/mattermost/mattermost-server/issues/19252#issuecomment-1034605734

The issue will be fixed by upgrading related icon package. For this reason, I am closing the PR


Api ratelimit

Description of PR

Resolves #126
What component(s) does this PR affect?

[x] Back-End (Node.js, Next.js)
[ ] Front-End (React.js)
[ ] Theming (CSS, React theme)
[x] Build System
[ ] Docs

Does the PR require changes on other components? If yes, please mark the components:

[ ] Back-End (Node.js, Next.js)
[ ] Front-End (React.js)
[ ] Theming (CSS, React theme)
[ ] Build System
[ ] Docs

Related Issue

Resolves #
Solution

Type

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Docs update
[ ] None of the above

Checklist:

[ ] I have read the contributing guide and my code conforms to the guidelines.
[ ] This change requires a change in the documentation.
[ ] I have updated the documentation accordingly.

)`>>>)>

also it is better to convert to draft until the testing issue is solved (i.e., cypress tests the rate-limiting correctly). Thanks Alex!

https://www.npmjs.com/package/express-rate-limit
in the way it is currently implemented with a per-handler usage, does this mean that within the window, I can make max calls of any API endpoint (even a mix of calls, that together amount to max), or I can make in parallel max calls for each endpoint? E.g., within 15 minutes can I call login 20 times and as_sets 20 times or is the counter "in total"?

Nice question! It means that you can make 20 calls per 15 minutes at every endpoint. Not 20 calls in total


Unify GPTQ dataloader with fixed/unfixed length data

Type of Change
enhance
Description

move seqlen attribute to config. (Done)
unified the dataloader's form with unfixed/fixed sequence length. (Done)

Expected Behavior & Potential Risk
Normal functions in modified uts
How has this PR been tested?
PreCI
Dependency Change?
None

@YIYANGCAI  target v2.3 or not?

better in 2.3


OrbitStartUpWindow don't use blocking modal for open file dialog

This is to fix b/160928265
This uses the non modal version of a file picking dialog, because it turned out on windows a blocking modal starts its own event loop, which is then supposed to not dispatch any QTimers, but it turns out it does anyways. This resulted in a timeout being dispatched before the result of the ggp call is read, even though the call finished before the timeout.
Anyways, non blocking modal means no new event loop means bug is fixed.

This is to fix b/160928265
This uses the non modal version of a file picking dialog, because it turned out on windows a blocking modal starts its own event loop, which is then supposed to not dispatch any QTimers, but it turns out it does anyways. This resulted in a timeout being dispatched before the result of the ggp call is read, even though the call finished before the timeout.
Anyways, non blocking modal means no new event loop means bug is fixed.

I'm not sure if I totally understand what's happening. First of all, a dialog is "modal" when it's blocking all other windows in the same application. We definitely want that. It's a UX-thing, not a code-thing. But I guess that's just about wording, isn't it?
Second, an event-loop running in QFileDialog should behave exactly the same as the main event loop, at least as far as I know. If that's not the case we should fix the root cause. Why do you think it's not supposed to act on timer events? Do you have a hint in the docs? Maybe I'm wrong here...

This is to fix b/160928265
This uses the non modal version of a file picking dialog, because it turned out on windows a blocking modal starts its own event loop, which is then supposed to not dispatch any QTimers, but it turns out it does anyways. This resulted in a timeout being dispatched before the result of the ggp call is read, even though the call finished before the timeout.
Anyways, non blocking modal means no new event loop means bug is fixed.

can you please add this to the commit message it is rather not-readable atm.

can you please add this to the commit message it is rather not-readable atm.

I updated the commit message


"Secure transport setup failed with error 2" when running C# interop tests.

I see some strange logs when running ping_pong and client_streaming interop tests. The interop test eventually passes, but hangs at shutdown (on one of the threads in the thread pool, I don't receive the stutdown event from completion queue).
GRPC_TRACE=surface SSL_CERT_FILE=$HOME/github/grpc/etc/roots.pem mono Grpc.IntegrationTesting.Client.exe --use_tls --server_port=443 --server_host=grpc-test.sandbox.google.com --server_host_override=grpc-test.sandbox.google.com --test_case=client_streaming
grpc-test.sandbox.google.com
443
running client_streaming
E9/16/2015 9:29:10 AM<PHONE_NUMBER>29984 src/core/security/secure_transport_setup.c:189: Read failed.
E9/16/2015 9:29:10 AM<PHONE_NUMBER>29984 src/core/surface/secure_channel_create.c:85: Secure transport setup failed with error 2.
D9/16/2015 9:29:10 AM<PHONE_NUMBER>29984 src/core/transport/chttp2/frame_settings.c:230: adding 983041 for initial_window change
I9/16/2015 9:29:10 AM<PHONE_NUMBER>29984 src/core/surface/completion_queue.c:212: RETURN_EVENT[0x1c733d0]: OP_COMPLETE: tag:0x1e36510 OK
D9/16/2015 9:29:10 AM<PHONE_NUMBER>32480 src/core/transport/chttp2/frame_settings.c:230: adding 983041 for initial_window change
When running on docker, I see this message (and get hanged upon shutdown).
E09/16/2015 16:25:37<PHONE_NUMBER>01600 src/core/iomgr/tcp_client_posix.c:174: on_writable failed during connect
E09/16/2015 16:25:37<PHONE_NUMBER>01600 src/core/iomgr/tcp_client_posix.c:247: connect error to 'ipv6:[2607:f8b0:400e:c04::451]:443': Network is unreachable
I09/16/2015 16:25:37<PHONE_NUMBER>97856 src/core/surface/completion_queue.c:212: RETURN_EVENT[0x2a41fb0]: OP_COMPLETE: tag:0x2c1b620 OK
D09/16/2015 16:25:37<PHONE_NUMBER>01600 src/core/transport/chttp2/frame_settings.c:230: adding 983041 for initial_window change

If this is fixed by #3354, can we close this one ?

Interop tests have been partially fixed by #3354 and partially by other changes. Fine to close this one.


Improve polling for processing videos

Feature Request
Is your feature request related to a problem or unsupported use case? Please describe.
Instructors using Marsha have complained that encoding is too long.
In fact, media convert is as fast as can be... and it is the polling that seems to give them this impression. When uploading a very short video, the dashboard shows "processing" during a very long time eventhough the video is ready, as we can see by reloading the page.
Describe the solution you'd like
Improve polling for processing videos so that we show the video as soon as possible after processing completes. I think we should check every few seconds at the beginning, then every few minutes, etc. increasing the interval between polls when the time elapsed increases.
To determine how often we should poll, the question is: "how much waiting time is acceptable when compared to the time I have already waited".

If I have just started waiting : waiting for a few seconds extra is acceptable
If I have been waiting 5 minutes : waiting for 1 minute extra is acceptable
If I have been waiting 30 minutes : waiting for 5 minutes extra is acceptable
etc.

Describe alternatives you've considered
We could think of using Django channel or the new ASGI views to be notified as soon as encoding finishes... but this is probably overkill?

And what about implementing a websocket ? We don't poll anymore the backend but the backend will notice the front when an object is ready ?


Support json/jsx/tsx

fixes #14

Please merge this! @jamesohortle

@somarlyonks @technoabyss
Hello all,
Thanks for the pull request. It looks great. Before merging, my only requirement is to have files in src/test folder. You can use the same code points used for testing the other test files. Please add these test files to the merge request and I will merge.
Apologies for the delay in replying.

@jamesohortle added

@somarlyonks
Hi, I'm back in lockdown again so I finally have some time to look at this. I'm trying to debug locally and it looks like the tests for HTML entities aren't successful for .tsx and .jsx files. When I hover over, for example, ě I don't see a panel. Is this expected behaviour? I'm not a react developer, so I'm not sure if the tests are failing or if this test is testing a behaviour that shouldn't exist.

I'm going to go ahead and merge since it seems like there is demand for this PR. @somarlyonks if you realise that the tests are failing then please submit a new PR.


Add disk space output to debug occasional test failures

Despite freeing up disk space early on, we saw occasional failures like https://github.com/model-checking/kani/actions/runs/7030685174/job/19130721957 that look like running out of disk space.
This change should be reverted once we have diagnosed the problem.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.

The CI run here suggests that we do have 35 GB of free disk space, so should be fine. Given that we have these sporadic failures, I'd now ask for reviews to get this merged so that we have more diagnostics upon the next failure that we see.


New SSG Feature for palpatine: Support --config with Config File

Hi,
I would like to add a new feature to Palpatine SSG. Through this new feature, it would be able to support the Config file with the
--config flag.
Here is the list of all that I will implement as specified in the lab 4 instructions.

The -c or --config flags accept a file path to a JSON config file.
If the file is missing, or can't be parsed as JSON, exit with an appropriate error message.
If the -c or --config option is provided, ignore all other options (i.e., a config file overrides other options on the command line).
The program should ignore any options in the config file it doesn't recognize.
If the config file misses any options, assume the usual defaults. For example, use dist/ as the output directory if it isn't specified.

:) I will be reaching out through Slack with questions if any!

Hello,
As lab4 requires us to provide config file which is in json format, I need to use the following library nlohmann/json. Could you help me insert this library like the way you did for argaprser and termcolor? Thanks!

Hi! please see https://github.com/batunpc/palpatine/pull/12

Closes: https://github.com/batunpc/palpatine/pull/12


backdrop_filter_perf_ios__timeline_summary 90th_percentile_frame_rasterizer_time_millis  is bimodal

@godofredoc are the poorly performing metrics tied to a particular host?

Triage: looks good now.


Using a relative folder with -pack throws PA3001: Internal error. Invalid URI: The format of the URI could not be determined.

When using -pack with a relative source folder path, the following error is thrown:
PA3001: Internal error. Invalid URI: The format of the URI could not be determined.

This is caused by the new Uri(...) constructor call at the following line:
https://github.com/microsoft/PowerApps-Language-Tooling/blob/739698182d830fc3370590e3141c830b2fdd81c1/src/PAModel/Utility/Utility.cs#L153
When I specify the full Windows folder path (including drive letter etc.), it works fine.

Amazing Mike! Thanks a lot!


Opening the data dump in Mongo atlas

Hi,
Could you provide any support for loading the dataset in the Mongo atlas cluster?

Do you have a specific kind of problem?
Loading the data dump should work with Mongo atlas and mongorestore.


[move-stdlib/diem-framework] Support multiple error category modules

This PR adds support in error map generation for multiple Move modules to declare the error categories.
This PR then splits the Errors module two: one for the Move stdlib, and the other for the Diem Framework containing DF-specific error categories which will help with the split of the Move stdlib and Diem Framework.

@tzakian Can you comment about the compatibility of this? Is this really a drop-in replacement for the current error module? I don't have a particular concern but it's touching a bunch of files and it made me wonder.

@tzakian Can you comment about the compatibility of this? Is this really a drop-in replacement for the current error module? I don't have a particular concern but it's touching a bunch of files and it made me wonder

Yes, this is a drop-in replacement for the current error module. The reason a number of files changed is because wherever we had Errors::requires_roles(err) we now need to have DiemErrors::requires_role(err). But this is an internal/code-only change and should not effect end-users.

Overall it looks good to me.
I think this should also be moved into the Diem Framework
/// A limit on an amount, e.g. a currency, is exceeded. Example: withdrawal of money after account limits window
    /// is exhausted.
    const LIMIT_EXCEEDED: u8 = 8;

I can change the example, but I actually think this should stay in the Move Errors module as this is not a Diem-Framework-specific error condition, but generally applicable to Move programs. E.g., when performing arithmetic we frequently do something like:
// a and b are u64s
assert((a as u128)  + (b as u128) < U64_MAX,  Errors::limit_exceeded(...));
let x = a + b;

Also this one? (IMO capability is a pattern used by the Diem Framework, but I could be wrong)
/// The signer of a transaction does not have a required capability.
    const REQUIRES_CAPABILITY: u8 = 4;

I can remove it, the issue is in the Vault code which uses this, but it makes sense to not be there. I'll work on removing this.

This one's probably fine, but maybe we should not reference "signing key" here?
/// An argument provided to an operation is invalid. Example: a signing key has the wrong format.
    const INVALID_ARGUMENT: u8 = 7;

I'll update the comment :)

:exclamation: Invalid command

Bors help and documentation

Bors is a Github App used to manage merging of PRs in order to ensure that CI is always green. It does so by maintaining a Merge Queue. Once a PR reaches the head of the Merge Queue it is rebased on top of the latest version of the PR's base-branch (generally master) and then triggers CI. If CI comes back green the PR is then merged into the base-branch. Regardless of the outcome, the next PR is the queue is then processed.
General

This project's Merge Queue can be found here.
This project requires PRs to be Reviewed and Approved before they can be queued for merging.
Before PR's can be merged they must be configured with "Allow edits from maintainers" enabled. This is needed for Bors to be able to update PR's in-place so that Github can properly recognize and mark them as "merged" once they've been merged into the upstream branch.

Commands
Bors actions can be triggered by posting a comment which includes a line of the form /<action>.

Command
Action
Description

Land
land, merge
attempt to land or merge a PR

Canary
canary, try
canary a PR by performing all checks without merging

Cancel
cancel, stop
stop an in-progress land

Cherry Pick
cherry-pick <target>
cherry-pick a PR into <target> branch

Priority
priority
set the priority level for a PR (high, normal, low)

Help
help, h
show this help message

Options
Options for Pull Requests are configured through the application of labels.

          Option
Description

Indicates that the PR is high-priority. When queued the PR will be placed at the head of the merge queue.

Indicates that the PR is low-priority. When queued the PR will be placed at the back of the merge queue.

Before merging the PR will be squashed down to a single commit, only retaining the commit message of the first commit in the PR.

While first seeing this, I thought this is a fine pragmatic approach to the problem of error codes, but I'm not that sure any longer.
I tend to think that our current error code names like ROLE_REQUIRED are unnecessary specific. This should be instead ACCESS_DENIED or similar. The applications consuming these error codes don't care how we currently implement access control.
I wonder whether we can just generalize the error naming and then would not even need a DiemErrors module. A canonical error space is very beneficial, if it is possible.

While first seeing this, I thought this is a fine pragmatic approach to the problem of error codes, but I'm not that sure any longer.
I tend to think that our current error code names like ROLE_REQUIRED are unnecessary specific. This should be instead ACCESS_DENIED or similar. The applications consuming these error codes don't care how we currently implement access control.

Good point. I think doing this would make a lot of sense (REQUIRES_ROLE => ACCESS_DENIED, REQUIRES_CAPABILITY => NO_PERMISSION). I also agree on providing a canonical error space for these if possible.
However, one thing that I worry is that in the responses from json-rpc that contain the error explanations, the category name is provided. So I'm worried that changing the names of these variables would constitute a breaking change to clients.

@wrwg and @vgao I put up an alternate PR for this in #8587 that keeps a single errors category module, preserves backwards compatibility, and generalizes the category names (would be interested on any thoughts on if there is a better way to handle requires_capability in that PR).


fix(bitwarden/clients): Add supported_envs

bitwarden/clients only release assets for amd64.

Thank you always!

bitwarden/clients only release assets for amd64.

https://github.com/bitwarden/clients/releases?q=cli-&expanded=true
https://github.com/bitwarden/clients/releases/tag/cli-v2022.11.0

That's correct. Thanks.

Released. https://github.com/aquaproj/aqua-registry/releases/tag/v3.108.0


fix issue 587

Please makes sure these boxes are checked before submitting your PR, thank you!

@e1emeb0t please, merge it


#32 Create Top Navigator tab component

Create Top Navigator tabs
Change Summary
Create a top navtab component for later use
Change Form
Fill this up (NA if not available). If a certain criteria is not met, can you please give a reason.

[ ] The pull request title has an issue number
[ ] The change works by "Smoke testing" or quick testing
[ ] The change has tests
[ ] The change has documentation

Other Information
[Is there anything in particular in the review that I should be aware of?]
Related issue

Resolve #32

I think you can use the blue style penni-main from tailwind.config.ts. Reference the style definitions from tailwind.config.ts as many as possible

Thanks for the reminder. Committed a new version using the theme colour in the config.

component use case:
const tabData = [
{ name: 'Task Details', content: Content for Task Details },
{ name: 'Other Details', content: Content for Other Details }
];


fix(api-markdown-documenter): Don't render HTML multiline in Markdown tables

Fixes issue where HTML content being rendered inside of a Markdown table was being rendered across multiple lines, which is invalid Markdown syntax.
An example of how this might have appeared previously:
| Col 1 | Col 2 |
| --- | --- |
|

Some content

| Hello world |

Correct rendering:
| Col 1 | Col 2 |
| --- | --- |
|
Some content
 | Hello world |

The fix was to ensure no "pretty" formatting is used when rendering HTML content under a Markdown table context.
The changes include adding the ability to opt out of pretty formatting in the HTML renderer. Note: this degree of freedom has not yet been added to the public API for the HTML renderer.
This PR also updates the test suite to reproduce the situation.

Looked through most of it, looks correct overall. Why are tables so weird 😢 .

Yeah, tables in Markdown aren't great. The fact that they simply don't allow multi-line content is really disruptive.


[For SSR] Failed to resolve components from katex tag names such as ('mo', 'mi', 'msqrt') and resulted a Hydration mismatch

Describe the bug
I am working on a vite-ssr project according vite-plugin-ssr vue guide and encountered the bug.
[Vue warn]: Failed to resolve component: mi
If this is a native custom element, make sure to exclude it from component resolution via compilerOptions.isCustomElement.
  at <Index id="index" >
  at <Index.page id="index" >
  at <GlobalPageShell >
  at <App>
[Vue warn]: Failed to resolve component: mo
If this is a native custom element, make sure to exclude it from component resolution via compilerOptions.isCustomElement.
  at <Index id="index" >
  at <Index.page id="index" >
  at <GlobalPageShell >
  at <App>
...
[Vue warn]: Hydration node mismatch:
- Client vnode: math
- Server rendered DOM: <!---->
  at <Index id="index" >
  at <Index.page id="index" >
  at <GlobalPageShell >
  at <App>
[Vue warn]: Hydration node mismatch:
- Client vnode: math
- Server rendered DOM: <!---->
  at <Index id="index" >
  at <Index.page id="index" >
  at <GlobalPageShell >
  at <App>
...
Hydration completed but contains mismatches.

Is there any way to avoid resolve katex tags?

My inplemetation is here
The server render and client render using the same function importMd.
import { PageContextServer } from '../types'
import { h } from 'vue'

export { importMd }

async function importMd(url: string, pageContext: PageContextServer) {
  let component = await import(`../../assets/${url}.md`);
  const { pageProps } = pageContext
  return h(component.default, pageProps || {})
}

// index.page.client.ts render()
export { render }

import type { PageContextClient } from '@/types'
import { createApp } from '@/app'

import type { PageContextBuiltIn } from 'vite-plugin-ssr/types'
import { importMd } from '@/utils/renderMarkdown'

async function render(pageContext: PageContextClient) {
  const { Page, pageProps } = pageContext
  const { id } = pageProps
  const html = await importMd(id, pageContext)
  pageContext.markdownHTML = html
  const app = createApp(Page, pageProps, pageContext)
  app.mount('#app')
}

// index.page.server.ts render()
import type { PageContextBuiltIn } from 'vite-plugin-ssr/types'
import { importMd } from '@/utils/renderMarkdown'

export { onBeforeRender }

async function onBeforeRender(pageContext: PageContextBuiltIn) {
  const { id } = pageContext.routeParams
  const html = await importMd(id, pageContext)
  return {
    pageContext: {
      markdownHTML: html,
      pageProps: {
        id
      }
    }
  }
}

For Reproduction:
The repository is saved on gitlab instance in my school and may have unstable network access. I could upload it to github if needed
Reproduction
https://git.halzi.one:8929/Etavioxy/wiki-web
System Info
System:
    OS: Linux 6.5 Arch Linux
    CPU: (16) x64 AMD Ryzen 7 4800U with Radeon Graphics
    Memory: 5.29 GB / 14.99 GB
    Container: Yes
    Shell: 5.1.16 - /bin/bash
  Binaries:
    Node: 20.8.1 - /usr/bin/node
    npm: 10.2.1 - /usr/bin/npm
    pnpm: 8.6.12 - ~/.local/share/pnpm/pnpm

Used Package Manager
pnpm
Validations

[X] Follow our Code of Conduct
[X] Read the Contributing Guide.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] Check that this is a concrete bug. For Q&A, please open a GitHub Discussion instead.
[X] The provided reproduction is a minimal reproducible of the bug.

See https://vuejs.org/api/application.html#app-config-compileroptions-iscustomelement
You can mark those tags as custom element to avoid the warning


Cargo Scripts with -Zscript should override current_exe

Problem
std::env::args and std::env::current_exe return potentially confusing results when running cargo scripts with the -Zscript unstable feature. While ostensibly correct, returning the actual built executable path is generally less useful to scripts than returning the path to the cargo script file, and leads to antipatterns like using current_dir().join(SCRIPT_NAME) to find the script file. Running the executable from the containing directory and having current_dir() not be a prefix of current_exe() adds another layer of complexity.
#!/usr/bin/env -S cargo +nightly -Z script

use std::env::{args, current_dir, current_exe};

fn main() {
    println!("args: {:?}", args());
    println!("current_dir: {}", current_dir().unwrap().display());
    println!("current_exe: {}", current_exe().unwrap().display());
}

/tmp/test $ ./test.rs
warning: `package.edition` is unspecified, defaulting to `2021`
   Compiling test- v0.0.0 (/tmp/test)
    Finished dev [unoptimized + debuginfo] target(s) in 0.13s
     Running `/home/rhart/.cargo/target/8c/d68b704094916b/debug/test-`
args: Args { inner: ["/home/rhart/.cargo/target/8c/d68b704094916b/debug/test-"] }
current_dir: /tmp/test
current_exe: /home/rhart/.cargo/target/8c/d68b704094916b/debug/test-

Proposed Solution
It seems there are ~3 possible ways to go about this:

Leave it as is -- it is correct, despite being a little confusing compared to the typical bash "SCRIPT_DIR" one-liner.
Override the behavior of these functions somehow to return the path to the script. std::env::current_exe has a note that it may return the path of a symbolic link instead of a target of a symbolic link, or other platform specific behavior. Treating the script file as a symbolic link-equivalent whose path is returned instead of the actual executable using this escape hatch is the route I'd personally like best.
Provide a way of accessing the script environment separately from the executable environment.

Notes
Related to #3502 and #12207.

For unix-like systems, we have CommandExt::arg0 but I don't think there is an equivalent for Windows.

There could be, there's just not std function for it atm. However, current_exe gets the "real" application name and doesn't use the arguments passed to the program.

We have CARGO_MANIFEST_DIR, I wonder if a way to resolve this would be to add CARGO_MANIFEST_PATH.  It wouldn't be arg0 and it wouldn't be accessible if people directly run the binary but it would still make the original script accessible to the developer.

I like the idea, it really seems like if you're directly running the binary with Zscript you're doing it wrong, and the added simplicity of being able to env!("CARGO_MANIFEST_PATH") in the script would be pretty ergonomic.

sh: Relative shell script includes with realpath on FreeBSD is potentially related.