[Perf] Refactor TemplateBinder.GetValues to avoid an expensive copy of RouteValueDictionary

Reference Issue https://github.com/aspnet/Mvc/issues/4593
loadtest with 3000 requests for the home page of the MusicStore app
Before

After

4.8% saving in the total bytes allocated.

The following are the changes

TemplateBinder.GetValues() : Fail fast if any of the required parameter of the template doesn't have a value
TemplateBindingContext() : Lazily Initialize the AcceptedValues of the context with the new values. AcceptedValues will be initialized when any of the values has to be updated.For most of the common cases, AcceptedValues is same as the values. In such cases, this optimization saves one RouteValueDictionary allocation per GetValues call.
The AcceptedValues will not be changed in TemplateBinder.BindValues

What's the data motivating this change? Is this about making an unsuccessful link generation operation more efficient?

The MusicStore app has 3 route templates defined. For every action link when URLHelper.Action is called to get the URL for the link, it is noticed that TemplateBinder.GetValues is called two times for two different routes. For the first route, TemplateBinder returned null as there was no route value defined for required route template parameter "area" . This check failed at the end of the processing where it allocates RouteValueDictionary and copies all other values. We can refactor it to fail fast rather than determining at the end of the processing.

In most of the common cases, the AcceptedValues returned by TemplateBinder.BindValues is same as values. But in cases where the AcceptedValues is different, we don't want to update the values given by the user. We can be smarter here to optimize the common cases and postpone the creation of new RouteValueDictionary for AcceptedValues until it is different from values and has to be changed.

TemplateBinder.GetValues, TemplateBinder.BindValues should not change the input route values that were passed to them. This is made so that we can use the optimization mentioned above in point 2.

The perf data corresponding to this change.
For scenario reference: #4593
loadtest -k -n 3000 http://localhost:5000 (home page of the MusicStore app
Before

The net benefit of this and https://github.com/aspnet/Mvc/pull/4683 is
After

Total savings is 5.5% in total bytes allocated.
For MusicStore app home page scenario, saves 2 RVD, List (underlying arrays) per link to 0.

Thanks for the explanation, this is much clearer and a good improvement in the data!

:watch: unless I'm missing something major here https://github.com/aspnet/Routing/pull/314#discussion_r64644375 this isn't correct in a fairly common case. If all the tests are passing that's likely because some work is being done twice (once incorrectly).
I think you need to evolve the code a bit more. If working with the existing structure and context isn't a good fit then improve it.

This seems overall much better.

@mnltejaswini @rynowak do we want to take this for 1.1.0?

Yes

Okie dokie, then, assigned to you.

Code changes here look reasonable, there's a few small things to hammer out. :watch:

:up: :date:

Closing this as we want to have this fix as part of a bigger rewrite https://github.com/aspnet/Routing/issues/348


Pin ntp cookbook version to 1.10.1

This PR pins the NTP cookbook to 1.10.1 in order to avoid a dependency
on 'windows >= 1.38.0'.   We have a pre-existing pin to an older
windows cookbook, which I have no desire to re-examine.

LGTM.


python310Packages.pyxbe: 0.0.4 -> 1.0.0

Description of changes
Update to latest upstream release 1.0.0

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.11 Release Notes (or backporting 22.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 188126 run on x86_64-linux 1

10 packages built:

python310Packages.angr
python310Packages.angrcli
python310Packages.angrop
python310Packages.cle
python310Packages.pyxbe
python39Packages.angr
python39Packages.angrcli
python39Packages.angrop
python39Packages.cle
python39Packages.pyxbe

Result of nixpkgs-review pr 188126 run on x86_64-linux 1

10 packages built:

python310Packages.angr
python310Packages.angrcli
python310Packages.angrop
python310Packages.cle
python310Packages.pyxbe
python39Packages.angr
python39Packages.angrcli
python39Packages.angrop
python39Packages.cle
python39Packages.pyxbe


Highlighting video upon hover-over

Did we always have this effect on hover-over I just saw at https://tobira.opencast.org/lectures/d-infk/2019/autumn/263-3010-00L?

I'm not exactly sure I understand your question. But yes. We had that for a very long time already (since before 1.0).

Right, thanks. @dagraf, do you like this effect? I don't, even if they are symmetrical (cf. images), but this one even more because it's not.

I have no strong opinion here. Looking at the screenshot, I do not like it very much. But when actually hovering over a video and seeing the effect appear and disappear, I do like it more.

I'd argue that the element Lisa's comment was about is quite different from this situation here.
I not necessarily arguing for having such a flashy animation. In fact, some time ago (before 2.0 I think), I asked internally what people think of it, suggesting to make it less flashy. But the majority was in favor of keeping it.
I would probably argue against removing it now: it has been part of Tobira for a very long time. And it surely can't be that terrible if you only noticed now, right? And Lisa didn't say anything about this specifically. We could still ask her about this, right?

Lisa's answer:

Aus UX-Sicht sieht man so sehr deutlich welches Video gerade aktiv ist. Also super. Das vergrößern würde ich auf jeden Fall behalten. Die Kippung ist tatsächlich Geschmacksache. Es ist mal etwas anderes, sehr tobiraspezifisch und gibt der Plattform einen Touch Verspieltheit. Da es funktioniert und nicht stört, sehe ich hier allerdings keinen Handlungsbedarf.

So lets keep it and close this issue?

I guess... @dagraf?

I guess so, too.


PATCH 0014-Revert-WAF-schema-changes.patch

Tracking context on upstream patch 0014-Revert-WAF-schema-changes.patch here.

reduces recursion depth of statementSchema; possibly benign unless you get into very deep examples


nixos/tt-rss: small improvements

Fix logging by making it quiet by default and setting syslogIdentifier. Fixes #74427
Restart the daemon on failure

Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[ ] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[ ] Fits CONTRIBUTING.md.

cc tt-rss maintainers @globin @zohl

I don't see anyone explicitly saying they have tested this. Since there isn't a NixOS test is anyone able to confirm this works with a real quick run through before we merge?
ping @symphorien @ajs124

Ah I forgot to tick the boxes but yes I tested it, notably the "restart on failure" part.


Error using vuetify components

I have a project with vuetify. Vuetify is working well all across my project. But, when y try to use the date range piker (globally registered) it fails with the following errors:
vue.runtime.esm.js?2b0e:587 [Vue warn]: Unknown custom element: <v-list> - did you register the component correctly? For recursive components, make sure to provide the "name" option.
found in
---> <VDaterange>

vue.runtime.esm.js?2b0e:587 [Vue warn]: Unknown custom element: <v-subheader> - did you register the component correctly? For recursive components, make sure to provide the "name" option.
found in
---> <VDaterange>

Throws the same error with all vuetify components.
I have<EMAIL_ADDRESS>installed with Vue CLI 3 and initialized like that:
// /src/plugins/vuetify.js

import Vue from 'vue'
import Vuetify from 'vuetify/lib'
import 'vuetify/src/stylus/app.styl'
import VDateRange from 'vuetify-daterange-picker';
import 'vuetify-daterange-picker/dist/vuetify-daterange-picker.css';

Vue.use(Vuetify, {
  iconfont: 'md',
})

Vue.use(VDateRange);

I realized that if i change import Vuetify from 'vuetify/lib' to import Vuetify from 'vuetify', everything seems to work fine but i don't know what impact it will have in vuetify.

Hi!
It doesn't look like you are using À la carte mode with vuetify. So ideally, you should be doing
import Vuetify from 'vuetify'

instead of
import Vuetify from 'vuetify/lib'

As far as I can tell, nothing should break.

It breaks with vuetify installed as a plugin


Bug: Changelog page is out of date

Describe the bug
The changelog page in the docs site seems to be missing a lot of versions
To Reproduce
Steps to reproduce the behavior:

Go to https://next--upbeat-sinoussi-f675aa.netlify.app/api-intro/changelog/

Expected behavior
All versions and their changes are listed

It looks like the changelog is only out of date for next. It behaves as expected on the release version: https://react-magma.cengage.com/version/3.1.0/api-intro/changelog/


Alchemy language v1 target

This pull request migrates the AlchemyLanguage service to use our rest-kit architecture.
Pretty much everything was changed, so I expect there to be more than a few things I overlooked. Definitely ask about the reasons why I took the approaches I did and comment on the TODOs I left in there.

[Current coverage][cc-pull] is 85.79%

Merging [#297][cc-pull] into [master][cc-base-branch] will decrease coverage by 2.00%

3 files (not in diff) in ...ource/ToneAnalyzerV3 were modified. more

Misses +6
Hits -7

2 files (not in diff) in ...anguageTranslationV2 were modified. more

Misses -6
Hits -1

2 files (not in diff) in ...urce/AlchemyVisionV1 were modified. more

Misses -29
Hits +21

7 files (not in diff) in Source were modified. more

Misses -1
Hits -34

File .../RestUtilities.swift (not in diff) was deleted. more
File ...RestExtensions.swift (not in diff) was created. more

@@             master       #297   diff @@
==========================================
  Files           108        101      -7
  Lines          9053       7546   -1507
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
- Hits           7948       6474   -1474
+ Misses         1105       1072     -33
  Partials          0          0

Powered by Codecov. Last updated by [17e0b10...30bfa15][cc-compare]
[cc-base-branch]: https://codecov.io/gh/watson-developer-cloud/ios-sdk/branch/master?src=pr
[cc-compare]: https://codecov.io/gh/watson-developer-cloud/ios-sdk/compare/17e0b10e7a06cf8391654be5616905c25d5086b6...30bfa151849140d6275b27ca5ab710db29bca2c0
[cc-pull]: https://codecov.io/gh/watson-developer-cloud/ios-sdk/pull/297?src=pr


Help implementing something in jest-glamor-react

We're planning a breaking change and a release of the website soonish (hopefully in a week or two) and I would love some help implementing this breaking change in jest-glamor-react to go out at around the same time. Anyone wanna help with that?

Can I help with this ?

Someone's started working on it. Feel free to review this though :smile:

Any other fresh issues or something?
(I've plenty of time before my college starts so I'll be happy to help with anything)

Oh, that's awesome of you @nitin42! Check out this list :smile:
Also, if you're interested in another challenge, you might look into nps which is highly useful but could use a little love :smile:

This is done and released!


pod not available ?

For some reason, the latest Podspec does not appear to be on Cocoapods.org. I'm going to investigate that.
You can however use Tatsi right now by adding the following to your podfile:
pod 'Tatsi',  :git => 'git@github.com:awkward/Tatsi.git', :tag => '1.1'

Tatsi 1.1 should now be availabel using cocoapods.org: https://cocoapods.org/pods/Tatsi

Thanks a lot


[SMALLFIX] Remove invalid Property WORKER_FUSE_ENABLED

What changes are proposed in this pull request?
Now WORKER_FUSE_ENABLED is invalid.
Why are the changes needed?
improve code quality.
Does this PR introduce any user facing changes?
no.

alluxio-bot, merge this please.


Add concurrency explanation -> FAQ

I ran into this issue here:
$ lerna run test-types
lerna notice cli v3.22.1
lerna info ci enabled
lerna info Executing command in 8 packages: "yarn run test-types"
lerna ERR! yarn run test-types exited 1 in '@mdx-js/react'
lerna ERR! yarn run test-types stdout:
$ dtslint types
Installing to /home/runner/.dts/typescript-installs/3.8...
Installed!

Installing to /home/runner/.dts/typescript-installs/4.0...
Installed!

Installing to /home/runner/.dts/typescript-installs/4.2...
Installed!

Installing to /home/runner/.dts/typescript-installs/4.3...
Installed!

info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

lerna ERR! yarn run test-types stderr:
Error: Cannot find module '/home/runner/.dts/typescript-installs/4.5/node_modules/typescript'
Require stack:
- /home/runner/work/mdx/mdx/node_modules/dtslint/bin/lint.js
- /home/runner/work/mdx/mdx/node_modules/dtslint/bin/index.js
    at Function.Module._resolveFilename (node:internal/modules/cjs/loader:933:15)
    at Function.Module._load (node:internal/modules/cjs/loader:778:27)
    at Module.require (node:internal/modules/cjs/loader:1005:19)
    at require (node:internal/modules/cjs/helpers:94:18)
    at testDependencies (/home/runner/work/mdx/mdx/node_modules/dtslint/bin/lint.js:66:16)
    at /home/runner/work/mdx/mdx/node_modules/dtslint/bin/lint.js:26:28
    at Generator.next (<anonymous>)
    at /home/runner/work/mdx/mdx/node_modules/dtslint/bin/lint.js:8:71
    at new Promise (<anonymous>)
    at __awaiter (/home/runner/work/mdx/mdx/node_modules/dtslint/bin/lint.js:4:12)
error Command failed with exit code 1.

The failed invocation installed 3.8, 4.0, etc., a concurrent invocation installed 3.9, 4.5, etc. The failed invocation found the 4.5 directory but didn't wait for the 4.5 installation to complete and failed as a result (I surmise).
Solved with lerna --concurrency 1 run .... I suspect this is also the cause behind https://github.com/mdx-js/mdx/issues/1172 and #267.
Fixes #267

Thanks for the update. What do you think about the suggested change to the previous line?

Sounds good :+1: I've updated that line.
This FAQ is to do with installing one list of TypeScript versions, and testing another, which can only happen if you end up with two different @definitelytyped/typescript-versions (I think). I haven't investigated the current dtslint/dtslint-runner/typescript-versions relationship to confirm how that could happen ...
I do vaguely recollect encountering this in the past ... There are child worker processes involved if I remember, so maybe somewhere in there the process doing the installing uses one node_modules and the one doing the testing uses another ...


[fix] Doc de-duplication might exclude valid documents

Description
The ´TextNode´ class calculate an internal hash of the node that is eventually used to de-duplicated docuements retrieved from a retriever/vstore.
The hash is calculated once, over the text and metadata. The problem is the text field is mutable.
This could leads to lose documents with the same metadata in some cases.
An example is in the Cassandra vector store, whereas the TextNode#text value is set after the object creation. The net
Type of Change

[x] Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

[x] Added new unit/integration tests

LGTM

hmmm, weird, why did that cause tests to fail lol
I guess since it's validating on assignment now, a few other bugs popped up

yes @logan-markewich I was going to send the fix, you have been quicker! thanks


ERROR: No matching distribution found for torch==1.8.2+cu111

Unattainable Requirements.
pip install torch==1.8.2+cu111 torchtext==0.9.2 -f https://download.pytorch.org/whl/lts/1.8/torch_lts.html

# then error
ERROR: Could not find a version that satisfies the requirement torch==1.8.2 (from versions: 1.11.0, 1.12.0, 1.12.1, 1.13.0, 1.13.1, 2.0.0, 2.0.1)
ERROR: No matching distribution found for torch==1.8.2

Guidance on the installation of Pytorch can be accessed from
https://pytorch.org/get-started/locally/.
It's worth mentioning that the testing has been specifically carried out using Nvidia CUDA.
A potential solution to the issue of not finding a suitable version of torch==1.8.2 could involve trying the following steps:

Check Package Index: Ensure that you have the correct package index configured. You can run the following command to make sure you're using the correct index:
pip config set global.index-url https://download.pytorch.org/whl/torch_stable.html
This sets the index to the PyTorch package repository.

Python Version: Verify that you are using a compatible Python version. PyTorch versions have specific requirements for Python. For example, PyTorch 1.8.2 may require Python 3.6 or later.

Update pip: Ensure that you have the latest version of pip installed:
pip install --upgrade pip

Virtual Environment: If you are using a virtual environment, make sure it is activated before attempting to install PyTorch.

Network Connection: Confirm that you have a stable network connection, as the installation requires downloading packages.

Try Different Version: If torch==1.8.2 is not crucial, you can try installing a different compatible version of PyTorch, such as the latest stable version.
pip install torch

Build from Source: If none of the above solutions work, you might consider building PyTorch from source. Instructions for building from source can be found in the PyTorch documentation.

Guidance on the installation of Pytorch can be accessed from
https://pytorch.org/get-started/locally/.
It's worth mentioning that the testing has been specifically carried out using Nvidia CUDA.
A potential solution to the issue of not finding a suitable version of torch==1.8.2 could involve trying the following steps:

Check Package Index: Ensure that you have the correct package index configured. You can run the following command to make sure you're using the correct index:

   pip config set global.index-url https://download.pytorch.org/whl/torch_stable.html
Linux and Windows
CUDA 11.7
conda install pytorch==2.0.0 torchvision==0.15.0 torchaudio==2.0.0 pytorch-cuda=11.7 -c pytorch -c nvidia
CUDA 11.8
conda install pytorch==2.0.0 torchvision==0.15.0 torchaudio==2.0.0 pytorch-cuda=11.8 -c pytorch -c nvidia
CPU Only
conda install pytorch==2.0.0 torchvision==0.15.0 torchaudio==2.0.0 cpuonly -c pytorch
This sets the index to the PyTorch package repository.

Python Version: Verify that you are using a compatible Python version. PyTorch versions have specific requirements for Python. For example, PyTorch 1.8.2 may require Python 3.6 or later.

Update pip: Ensure that you have the latest version of pip installed:
pip install --upgrade pip

Virtual Environment: If you are using a virtual environment, make sure it is activated before attempting to install PyTorch.

Network Connection: Confirm that you have a stable network connection, as the installation requires downloading packages.

Try Different Version: If torch==1.8.2 is not crucial, you can try installing a different compatible version of PyTorch, such as the latest stable version.
pip install torch

Build from Source: If none of the above solutions work, you might consider building PyTorch from source. Instructions for building from source can be found in the PyTorch documentation.

I resolved this issue by replacing Python 3.10 with Python 3.9.


Doc about TLS security profile

Description
Doc about TLS security profile
Type of change

[ ] Refactor
[ ] New feature
[ ] Bug fix
[ ] CVE fix
[ ] Optimization
[x] Documentation Update
[ ] Configuration Update
[ ] Bump-up dependent library
[ ] Bump-up library or tool used for development (does not change the final image)
[ ] CI configuration change
[ ] Konflux configuration change

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 95.03%. Comparing base (be25e61) to head (23efc6e).
Report is 16 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1780      +/-   ##
==========================================
+ Coverage   95.01%   95.03%   +0.01%
==========================================
  Files          61       61
  Lines        2751     2757       +6
==========================================
+ Hits         2614     2620       +6
  Misses        137      137

see 2 files with indirect coverage changes

/override "Red Hat Konflux / ols-enterprise-contract / lightspeed-service"

/retest

/lgtm

/override "Red Hat Konflux / lightspeed-service-on-pull-request"

/hold


Support plugins

This PR implements plugin support. Any plugin that follows the JunoPlugin interface can plug into Juno.
type JunoPlugin interface {
	Init() error
	Shutdown() error // Todo: Currently this function will never be called.
	NewBlock(block *core.Block, stateUpdate *core.StateUpdate, newClasses map[felt.Felt]core.Class) error
	// The state is reverted by applying a write operation with the reverseStateDiff's StorageDiffs, Nonces, and ReplacedClasses,
	// and a delete option with its DeclaredV0Classes, DeclaredV1Classes, and ReplacedClasses.
	RevertBlock(from, to *BlockAndStateUpdate, reverseStateDiff *core.StateDiff) error
}

Whenever Juno syncs a new block, the block, state-update and classes are sent to the plugin. Specifically, NewBlock() is called
NewBlock(block *core.Block, stateUpdate *core.StateUpdate, newClasses map[felt.Felt]core.Class) error
Whenver Juno reverts a block, it will send the block and state-updateof the current height "N", the reverted height "N-1", as well as the "reverse state diff" that brings you from N to N-1. Specifically, RevertBlock() is called
RevertBlock(from, to *BlockAndStateUpdate, reverseStateDiff *core.StateDiff) error
Note: the code coverage is below the threshold. The main chunk of code that hasn't been tested is the Load() function. A simple plugin that only prints when a function has been called can be quite large (~37Mb+), so it doesn't seem feasible to include a dummy plugin/.so file for the purpose of increasing the code coverage. However, the Load function was tested manually and it seems to work just fine (see here for example plugin)

I'd suggest to add some documentations so that users are aware of this feature


new update

cant figure all that coding stuff out, anyone that can just drop a downloadable file in here for us that dont have the brains to figure out coding

https://github.com/brian8544/R3nzSkin/releases/download/v3.1.8/R3nzSkin.zip

appreaciate you dawg thank u

dont download this lmao XD its from a random. might as well just download trojan

HE LITERALLY POSTED A RAT XD

 HE LITERALLY POSTED A RAT XD

You can literally see all commits he did to his fork. Only offsets were changes.  Only offsets were changed. Do some research before lynching people on this site.

Appreciated! :)


Installation Problems

Hey Guys,
When I try to install (fresh server) I get the following output:
root@s16009678:/home/john# npm install xml-stream -g
npm http GET https://registry.npmjs.org/xml-stream
npm http 304 https://registry.npmjs.org/xml-stream
npm http GET https://registry.npmjs.org/iconv
npm http GET https://registry.npmjs.org/node-expat
npm http 304 https://registry.npmjs.org/node-expat
npm http 304 https://registry.npmjs.org/iconv
npm WARN<EMAIL_ADDRESS>dependencies field should be hash of <name>:<version-range> pairs
npm WARN<EMAIL_ADDRESS>devDependencies field should be hash of <name>:<version-range> pairs

><EMAIL_ADDRESS>install /usr/lib/node_modules/xml-stream/node_modules/node-expat
> node-waf configure build

Checking for program g++ or c++          : /usr/bin/g++
Checking for program cpp                 : /usr/bin/cpp
Checking for program ar                  : /usr/bin/ar
Checking for program ranlib              : /usr/bin/ranlib
Checking for g++                         : ok
Checking for node path                   : ok /usr/lib/node_modules/
Checking for node prefix                 : ok /usr
'configure' finished successfully (0.020s)
Waf: Entering directory `/usr/lib/node_modules/xml-stream/node_modules/node-expat/build'
[1/2] cxx: node-expat.cc -> build/Release/node-expat_1.o
../node-expat.cc:3:25: error: node_events.h: No such file or directory
../node-expat.cc:17: error: expected class-name before â{â token
../node-expat.cc: In static member function âstatic void Parser::Initialize(v8::Handle<v8::Object>)â:
../node-expat.cc:24: error: âEventEmitterâ has not been declared
../node-expat.cc: In static member function âstatic v8::Handle<v8::Value> Parser::New(const v8::Arguments&)â:
../node-expat.cc:63: error: âclass Parserâ has no member named âWrapâ
../node-expat.cc: In constructor âParser::Parser(const XML_Char*)â:
../node-expat.cc:68: error: class âParserâ does not have any field named âEventEmitterâ
../node-expat.cc: In static member function âstatic void Parser::StartElement(void*, const XML_Char*, const XML_Char**)â:
../node-expat.cc:264: error: âclass Parserâ has no member named âEmitâ
../node-expat.cc: In static member function âstatic void Parser::EndElement(void*, const XML_Char*)â:
../node-expat.cc:274: error: âclass Parserâ has no member named âEmitâ
../node-expat.cc: In static member function âstatic void Parser::StartCdata(void*)â:
../node-expat.cc:283: error: âclass Parserâ has no member named âEmitâ
../node-expat.cc: In static member function âstatic void Parser::EndCdata(void*)â:
../node-expat.cc:292: error: âclass Parserâ has no member named âEmitâ
../node-expat.cc: In static member function âstatic void Parser::Text(void*, const XML_Char*, int)â:
../node-expat.cc:302: error: âclass Parserâ has no member named âEmitâ
../node-expat.cc: In static member function âstatic void Parser::ProcessingInstruction(void*, const XML_Char*, const XML_Char*)â:
../node-expat.cc:312: error: âclass Parserâ has no member named âEmitâ
../node-expat.cc: In static member function âstatic void Parser::Comment(void*, const XML_Char*)â:
../node-expat.cc:322: error: âclass Parserâ has no member named âEmitâ
../node-expat.cc: In static member function âstatic void Parser::XmlDecl(void*, const XML_Char*, const XML_Char*, int)â:
../node-expat.cc:335: error: âclass Parserâ has no member named âEmitâ
../node-expat.cc: In static member function âstatic void Parser::EntityDecl(void*, const XML_Char*, int, const XML_Char*, int, const XML_Char*, const XML_Char*, const XML_Char*, const XML_Char*)â:
../node-expat.cc:353: error: âclass Parserâ has no member named âEmitâ
Waf: Leaving directory `/usr/lib/node_modules/xml-stream/node_modules/node-expat/build'
Build failed:  -> task failed (err #1):
        {task: cxx node-expat.cc -> node-expat_1.o}
npm ERR! error installing<EMAIL_ADDRESS>npm ERR! error installing<EMAIL_ADDRESS>
npm ERR<EMAIL_ADDRESS>install: `node-waf configure build`
npm ERR! `sh "-c" "node-waf configure build"` failed with 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>install script.
npm ERR! This is most likely a problem with the node-expat package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     node-waf configure build
npm ERR! You can get their info via:
npm ERR!     npm owner ls node-expat
npm ERR! There is likely additional logging output above.
npm ERR!
npm ERR! System Linux 3.0.0-14-server
npm ERR! command "node" "/usr/bin/npm" "install" "xml-stream" "-g"
npm ERR! cwd /home/john
npm ERR! node -v v0.6.8
npm ERR! npm -v 1.1.0-2
npm ERR! code ELIFECYCLE
npm ERR! message<EMAIL_ADDRESS>install: `node-waf configure build`
npm ERR! message `sh "-c" "node-waf configure build"` failed with 1
npm ERR! errno {}

npm ERR! Error: ENOENT, no such file or directory '/usr/lib/node_modules/xml-stream/node_modules/___iconv.npm/package/deps/libiconv/libcharset/tools/hpux-11.00'
npm ERR! You may report this log at:
npm ERR!     <http://github.com/isaacs/npm/issues>
npm ERR! or email it to:
npm ERR<EMAIL_ADDRESS>npm ERR!
npm ERR! System Linux 3.0.0-14-server
npm ERR! command "node" "/usr/bin/npm" "install" "xml-stream" "-g"
npm ERR! cwd /home/john
npm ERR! node -v v0.6.8
npm ERR! npm -v 1.1.0-2
npm ERR! path /usr/lib/node_modules/xml-stream/node_modules/___iconv.npm/package/deps/libiconv/libcharset/tools/hpux-11.00
npm ERR! fstream_path /usr/lib/node_modules/xml-stream/node_modules/___iconv.npm/package/deps/libiconv/libcharset/tools/hpux-11.00
npm ERR! fstream_type File
npm ERR! fstream_class FileWriter
npm ERR! code ENOENT
npm ERR! message ENOENT, no such file or directory '/usr/lib/node_modules/xml-stream/node_modules/___iconv.npm/package/deps/libiconv/libcharset/tools/hpux-11.00'
npm ERR! errno {}
npm ERR! fstream_stack Object.oncomplete (/usr/lib/node_modules/npm/node_modules/fstream/lib/writer.js:204:26)
npm ERR!
npm ERR! Additional logging details can be found in:
npm ERR!     /home/john/npm-debug.log
npm not ok

I figured it was something to do with node-expat so I installed the latest version of that:
root@s16009678:/home/john# npm install node-expat -g
npm http GET https://registry.npmjs.org/node-expat
npm http 304 https://registry.npmjs.org/node-expat

><EMAIL_ADDRESS>install /usr/lib/node_modules/node-expat
> node-waf configure build

Checking for program g++ or c++          : /usr/bin/g++
Checking for program cpp                 : /usr/bin/cpp
Checking for program ar                  : /usr/bin/ar
Checking for program ranlib              : /usr/bin/ranlib
Checking for g++                         : ok
Checking for node path                   : ok /usr/lib/node_modules/
Checking for node prefix                 : ok /usr
Checking for header expat.h              : yes
'configure' finished successfully (0.080s)
Waf: Entering directory `/usr/lib/node_modules/node-expat/build'
[1/2] cxx: node-expat.cc -> build/Release/node-expat_1.o
[2/2] cxx_link: build/Release/node-expat_1.o -> build/Release/node-expat.node
Waf: Leaving directory `/usr/lib/node_modules/node-expat/build'
'build' finished successfully (0.202s)
<EMAIL_ADDRESS>/usr/lib/node_modules/node-expat

I think [2/2] being yellow means it has a warning.. but it all reports ok.
I tried npm install xml-stream again and it gave be the same warning as before.
This is my first experience with node, so I am probably missing something.  Any chance you could help me get this working because I'm pretty confused?
Cheers,
John

I'm experiencing this too. Bumping the node-expat dependency to ~1.4.0 solves the problem for me.


Bug fix, version update/add, minor code cleanup

@yihhwang This is just a code review of the changes I've made; no need to be completely up-to-speed on how Parliament2 works. If you want to be completely up-to-speed, though, I can fill you in.

As CI has not been set up yet: note that this has passed the platform tests, including the case that created the bug in the first place

Thanks! I'm going to be busy for a short while onboarding the interns, but afterwards I'll talk to Andrew about it.


FIREBASE_CONFIG and GCLOUD_PROJECT environment variables are missing. Initializing firebase-admin will fail

After installing the "Search with Algolia" Firebase extension, the extension page has three tabs:
1- How this extension works
2- Extension configuration
3- APIs and resources
I followed the instructions in first tab "How this extension works". I've copied the instructions that I get on this page below for your reference.
After running npx firestore-algolia-search, the first lines of console logs are as follows.
{"severity":"WARNING","message":"Warning, FIREBASE_CONFIG and GCLOUD_PROJECT environment variables are missing. Initializing firebase-admin will fail"}
{"algoliaAppId":<YOUR_ALGOLIA_APP_ID>,"algoliaAPIKey":"********","algoliaIndexName":"nodesIndex","collectionPath":"nodes","fields":"admin,content,createdAt,nodeType,tags,title","severity":"INFO","message":"Initializing extension with configuration"}
WARNING: The back fill process will index your entire collection which will impact your Search Operation Quota.  Please visit https://www.algolia.com/doc/faq/accounts-billing/how-algolia-count-records-and-operation/ for more details.  Do you want to continue? (y/N):
I answered "y" to this question. Then, it generated a lot of logs but there is no index record generated on Algolia.

You can test out this extension right away:
Go to the Cloud Firestore tab.
If it doesn’t exist already, create a collection called nodes.
Create, update, or delete a document in the nodes collection. Go to Algolia’s dashboard and verify in Algolia that a record is created, updated, or deleted in the nodesIndex index for application id ................
Using the extension
This extension listens to the Cloud Firestore collection nodes. If you create, update, or delete a document within that collection, this extension will:
Indexes the document and send all the fields or configured fields defined in the extension.
or, removes the record from Algolia index if the document is deleted.
(Optional) Import existing documents or Reindex after configuration changes
This extension starts monitoring the nodes collection after a successful installation. Any existing documents created before the extension installation can be back-filled into your Algolia nodesIndex Index using the import script. Also, you will need to run the import script if you change the Indexable Fields, Index Name, Application Id, and/or API Key configuration.
The import script will read all existing documents in the nodes collection and insert them into the Algolia nodesIndex index.
Important notes
You must run the import script over the entire collection after installing the Search with Algolia extension; otherwise you will have missing records in your Algolia nodesIndex index.
lastmodified attributed is added to all Algolia records to eliminate race condition issues related from the Cloud Function cold start.
Run the script
The script will use the extension configuration before the import process starts.
Run the import process using npx.
Make sure that you’ve installed the required tools to run the import script:
To access the npx command tools, you need to install Node.js.
If you use npm v5.1 or earlier, you need to explicitly install npx. Run npm install --global npx.
The import script uses Application Default Credentials to communicate with Firebase.
Please follow the instructions to generate a key for your service account.
Execute the below command:
Update the path to the Google Application credentials.
Clear out the FIELDS param if it contains { unspecified parameter } in the command below since it’s an invalid value.
LOCATION=us-east4
ALGOLIA_APP_ID=<YOUR_ALGOLIA_APP_ID>
ALGOLIA_API_KEY=<YOUR_API_KEY>
ALGOLIA_INDEX_NAME=nodesIndex
COLLECTION_PATH=nodes
FIELDS=admin,content,createdAt,nodeType,tags,title
GOOGLE_APPLICATION_CREDENTIALS=</path/to/service/account/key>
npx firestore-algolia-search
Monitoring
As a best practice, you can monitor the activity of your installed extension, including checks on its health, usage, and logs.

Is the API key you are using have the correct permissions?

Yes, it is. The Algolia technical support team gave me instructions to create a new API key with the right permissions and after creating the new API key with the right permissions, I still get the same error.
In addition, I asked two other developers in our team to install the extension and try to use it on test apps. They got the same error.

Can you provide me the error you are getting?

I've put the error message in the very first post in this thread:
{"severity":"WARNING","message":"Warning, FIREBASE_CONFIG and GCLOUD_PROJECT environment variables are missing. Initializing firebase-admin will fail"}

It console logs the following for a really long time because our collection is large, but it does not create any Algolia index records.
WARNING: The back fill process will index your entire collection which will impact your Search Operation Quota.  Please visit https://www.algolia.com/doc/faq/accounts-billing/how-algolia-count-records-and-operation/ for more details.  Do you want to continue? (y/N): {"severity":"DEBUG","message":"[ 'field', 'admin' ]"}
{"severity":"DEBUG","message":"[ 'value', 'RJMaryala' ]"}
{"severity":"DEBUG","message":"[ 'field', 'content' ]"}
{"severity":"DEBUG","message":"[\n  'value',\n  'Park, E., Chiles, C., Cinciripini, P., Foley, K., Fucito, L., Haas, J., . . . Toll, B. (2020, October 13). Impact of the covid‐19 pandemic on telehealth research in cancer prevention and care: A call to sustain telehealth advances. Retrieved February 18, 2021, from https://doi.org/10.1002/cncr.33227'\n]"}
{"severity":"DEBUG","message":"[ 'field', 'createdAt' ]"}
{"severity":"DEBUG","message":"[ 'value',<PHONE_NUMBER>408 ]"}
{"severity":"DEBUG","message":"[ 'field', 'nodeType' ]"}
{"severity":"DEBUG","message":"[ 'value', 'Reference' ]"}
{"severity":"DEBUG","message":"[ 'field', 'tags' ]"}
{"severity":"DEBUG","message":"[\n  'value',\n  [ { title: 'SARS-CoV-2 (COVID-19)', node: 'uYgvhNdciHcuK7ioGZEv' } ]\n]"}
{"severity":"DEBUG","message":"[ 'field', 'title' ]"}
{"severity":"DEBUG","message":"[\n  'value',\n  'Impact of the COVID‐19 pandemic on telehealth research in cancer prevention and care: A call to sustain telehealth advances'\n]"}
{"severity":"DEBUG","message":"[ 'field', 'admin' ]"}
{"severity":"DEBUG","message":"[ 'value', 'sohineetsaha' ]"}
{"severity":"DEBUG","message":"[ 'field', 'content' ]"}
{"severity":"DEBUG","message":"[\n  'value',\n  'In late April 2020, the CDC confirmed the first cases of the virus among cats in the USA. Two cats of different households were tested positive in the state of New York. One cat had presumably been infected due to the owner having COVID-19. The other cat, however, had presumably been affected by an asymptomatic or an outside source as no household members tested positive.\\n' +\n    '\\n' +\n    '\\n' +\n    'In early June 2020, the first dog in the USA to test positive for the virus was a German Shepherd in the state of New York. The dog, Buddy, had been infected after one of his owner’s tested positive for the virus. Though he was expected to survive, Buddy died three months after experiencing life-threatening symptoms and one month after being confirmed positive for the virus. However, late awareness of Buddy’s condition with lymphoma currently leaves questions of his ultimate cause of death. \\n' +\n    '\\t\\t\\n' +\n    '\\n'\n]"}
{"severity":"DEBUG","message":"[ 'field', 'createdAt' ]"}
{"severity":"DEBUG","message":"[ 'value',<PHONE_NUMBER>755 ]"}
{"severity":"DEBUG","message":"[ 'field', 'nodeType' ]"}
{"severity":"DEBUG","message":"[ 'value', 'Relation' ]"}
{"severity":"DEBUG","message":"[ 'field', 'tags' ]"}
{"severity":"DEBUG","message":"[\n  'value',\n  [ { title: 'SARS-CoV-2 (COVID-19)', node: 'uYgvhNdciHcuK7ioGZEv' } ]\n]"}
{"severity":"DEBUG","message":"[ 'field', 'title' ]"}
{"severity":"DEBUG","message":"[ 'value', 'First Positive Cases in Cats and Dogs in USA' ]"}
{"severity":"DEBUG","message":"[ 'field', 'admin' ]"}
{"severity":"DEBUG","message":"[ 'value', 'Grae' ]"}
{"severity":"DEBUG","message":"[ 'field', 'content' ]"}
{"severity":"DEBUG","message":"[\n  'value',\n  'The process models approach considers information-seeking skills as a necessary piece to the information-seeking process. The lessons are geared more towards bolstering those skills and how to seek information using the library tools. '\n]"}
{"severity":"DEBUG","message":"[ 'field', 'createdAt' ]"}
{"severity":"DEBUG","message":"[ 'value',<PHONE_NUMBER>357 ]"}
{"severity":"DEBUG","message":"[ 'field', 'nodeType' ]"}
{"severity":"DEBUG","message":"[ 'value', 'Concept' ]"}
{"severity":"DEBUG","message":"[ 'field', 'tags' ]"}
{"severity":"DEBUG","message":"[\n  'value',\n  [ { title: 'Library Science', node: 'gRRpc1O61kMszcrW07lW' } ]\n]"}
{"severity":"DEBUG","message":"[ 'field', 'title' ]"}
{"severity":"DEBUG","message":"[ 'value', 'The Process Models Approach Instruction Model in ISP' ]"}
{"severity":"DEBUG","message":"[ 'field', 'admin' ]"}
{"severity":"DEBUG","message":"[ 'value', 'catgrillo' ]"}
{"severity":"DEBUG","message":"[ 'field', 'content' ]"}
{"severity":"DEBUG","message":"[\n  'value',\n  'Committed members of a community are more likely to provide meaningful content that other users value. Additionally,  commitment is an important building block for behavior regulation. Certain types of commitment can occur in online communities, the type of commitment you want will differ depending on your vision for the community. '\n]"}
{"severity":"DEBUG","message":"[ 'field', 'createdAt' ]"}
{"severity":"DEBUG","message":"[ 'value',<PHONE_NUMBER>565 ]"}
{"severity":"DEBUG","message":"[ 'field', 'nodeType' ]"}
{"severity":"DEBUG","message":"[ 'value', 'Concept' ]"}
{"severity":"DEBUG","message":"[ 'field', 'tags' ]"}
{"severity":"DEBUG","message":"[\n  'value',\n  [\n    {\n      node: 'nL5vJd6vfnRC5s9uGeRU',\n      title: 'CSCW (Computer-supported cooperative work)'\n    }\n  ]\n]"}

ok, so you created the key, but you did not specify the index.  I have updated your API key to give access to the nodeindex.

I ran the script again. I'm getting the exact same error message and all the logs. I see nothing in Algolia index records yet!

I need access to your Algolia account.  Please go https://www.algolia.com/account/support and give me read access so I can check the settings.

Were you able to figure out the issue?  Can I close this ticket?

Yes, it's fixed. Thank you.

Hey @ImanYZ, can you post your solution that fixed this issue

I just ignored that error message and let the script complete its execution. It seems working because it generated the records on my Algolia index.


Introduce ObjectContainer class

ObjectContainer is a container for a single value. It is either filled
with a value or empty.

@jwChung @mhyeon-lee GenerationResult 클래스의 공용 API 버전입니다.


Import a library ([starknet::component]) inside another library ([starknet::component])

Which component is your feature related to?
Forge
Feature Request

Trying to import LibAsset component in LibFees component, and getting this warning error. Please look into it.

Take a look at the file paths for both the 'LibAsset' and 'LibFees', check the export, it should look like that:
export { LibAsset };
When you try to import the 'LibAsset' , check the statement:
import { LibAsset } from 'path/to/LibAsset';
Your module resolution configuration should be set up correctly. For example, in a TypeScript project, check the tsconfig.json file for proper configuration.
Let me know if you found it useful

This seems like an issue related to either vscode extension, or a wrong cairo version, so either way unrelated to forge.
Please submit an issue in the cairo repo instead
Closing


Reviewed Ruby style guide

This is all still applicable.

@sihugh sorry I didn't respond to your review request here! Glad you found a reviewer.

@sihugh sorry I didn't respond to your review request here! Glad you found a reviewer.


Fix documentation regarding the removal of user_omniauth_authorise_path(:provider) method

it seems that
user_omniauth_authorise_path () generic method is removed. The documentation needs to be updated.

Fixed on 75959ca


anagram: Add test generator

For #605
I did not have a way to wake up #695 so I started a new one.
This generator mimics the output of the connect generator so the output is
a little nicer IMHO. I bumped the testVersion.

Did I break a check? The logs are pretty empty.

thanks @shaleh I'll have to have a proper look at this on Monday.

Did I break a check? The logs are pretty empty.

It looks like Travis is complaining about the testVersion. We've just removed all test versioning in the nextercism branch.
# github.com/exercism/go/exercises/anagram
exercises/anagram/anagram_test.go:22: undefined: testVersion
exercises/anagram/anagram_test.go:23: undefined: testVersion

Ah. I see. That is disappointing.

All better @robphoenix, thx

backlogged will review ASAP.

Found #847 while verifying this one. Looks ok in and of itself but this specific exercise does make the bug show up as it has a multiline most recent remote commit on its canonical-data.json file.

I don't see how this passes travis if #847 is a real bug. I'm gonna mess with the build a bit before committing this.

Oh I see why, I don't think Travis runs the generators!


fixes invisible inactive lightline bar

I decided to try lightline, and I couldn't figure out where the statusbar was when in bottom split.
OLD:

NEW:

Also
Be sure that this makes its way into the lightline repository .. because the only way I could fix it was by modifying ~/.vim/plugged/lightline.vim/autoload/lightline/colorscheme/nord.vim (rather than your ~/.vim/plugged/nord-vim/autoload/lightline/colorscheme/nord.vim).

Thanks for your contribution :+1:
Looks like I forgot to test the support for lightline & airline before merging #58 and only tested it for the vanilla status bar :smile:
I think the theme file bundled with lightline takes precedence over the file included in Nord Vim. I'll create a PR for it as soon as possible right after merging this one.


Adding support for --log-level and concurrent S3 get

This PR adds the following features:

Support for --log-level flag on command line to control the logging.

Optimizing the s3.getAllS3Buckets function to get S3 bucket properties (region,tags) concurrently as opposed to getting for each one - this was added because running S3 bucket deletion for an account > 50 buckets was too slow and was taking around 1 sec per bucket to get its properties - which would lead to linear increase as per the number of buckets.

s3.getAllS3Buckets now supports batchSize which is as per aws.MaxConcurrentGetSize in s3_types.go to get X buckets data concurrently (default value: 100)
Demo:

Before adding concurrent gets:

go run main.go aws --resource-type s3

INFO[2020-04-04T21:10:19+05:30] The following resources types will be nuked:
INFO[2020-04-04T21:10:19+05:30] - s3
INFO[2020-04-04T21:10:21+05:30] Retrieving active AWS resources in [eu-north-1, ap-south-1, eu-west-3, eu-west-2, eu-west-1, ap-northeast-2, ap-northeast-1, sa-east-1, ca-central-1, ap-southeast-1, ap-southeast-2, eu-central-1, us-east-1, us-east-2, us-west-1, us-west-2]
INFO[2020-04-04T21:10:21+05:30] Checking region [1/16]: eu-north-1
DEBU[2020-04-04T21:10:23+05:30] Checking - Bucket bucket-1
DEBU[2020-04-04T21:10:26+05:30] Checking - Bucket bucket-2
DEBU[2020-04-04T21:10:33+05:30] Checking - Bucket bucket-3
DEBU[2020-04-04T21:10:39+05:30] Checking - Bucket bucket-4

The "Checking -" log - gets bucket region, checks for valid tags and decides if the bucket should be deleted or not. This serial check slows down for accounts having large number of buckets i.e at least n seconds for n buckets.

After adding concurrent gets:

go run main.go aws --resource-type s3 --log-level debug
INFO[2020-04-04T21:13:50+05:30] The following resources types will be nuked:
INFO[2020-04-04T21:13:50+05:30] - s3
INFO[2020-04-04T21:13:52+05:30] Retrieving active AWS resources in [eu-north-1, ap-south-1, eu-west-3, eu-west-2, eu-west-1, ap-northeast-2, ap-northeast-1, sa-east-1, ca-central-1, ap-southeast-1, ap-southeast-2, eu-central-1, us-east-1, us-east-2, us-west-1, us-west-2]
INFO[2020-04-04T21:13:52+05:30] Checking region [1/16]: eu-north-1
DEBU[2020-04-04T21:13:57+05:30] S3 - creating session - region eu-north-1
DEBU[2020-04-04T21:13:57+05:30] S3 - creating session - region ap-south-1
DEBU[2020-04-04T21:13:57+05:30] S3 - creating session - region eu-west-3
DEBU[2020-04-04T21:13:57+05:30] S3 - creating session - region eu-west-2
DEBU[2020-04-04T21:13:57+05:30] S3 - creating session - region eu-west-1
DEBU[2020-04-04T21:13:57+05:30] S3 - creating session - region ap-northeast-2
DEBU[2020-04-04T21:13:57+05:30] S3 - creating session - region ap-northeast-1
.
.
.
INFO[2020-04-04T21:13:57+05:30] Getting - 1-88 buckets of batch 1/1

This run creates S3 bucket sessions in advance (required as each bucket needs its region's session object and we have to create them per region sessions in advance to avoid creating them multiple times).
The log Getting 1-88 buckets of batch 1/1 gets 88 buckets data in parallel subject to limit imposed by MaxConcurrentGetSize in s3_types.go and completes in 5-8 seconds as opposed to minimum of 88 seconds for 88 buckets when get operation is serial.

@brikis98 - thanks for the feedback - updated and replied to comments. Let me know if it looks good - will squash the commits.

Tests passed! Merging now.

https://github.com/gruntwork-io/cloud-nuke/releases/tag/v0.1.18

Thanks @brikis98 for the feedback and code review!


Use enhanced stereo in substructure search

Allows use of enhaced stereochemistry in substructure searching if SubstructMatchParameters.useEnhancedStereo is set.
The matching rules are pretty obnoxious, but a synopsis is (where < aka less than means that the left hand side is a substructure of the right hand side)

achiral < everything, because an achiral query means ignore chirality in the match
chiral < AND, because AND includes both the chiral molecule and another one
chiral < OR, because OR includes either the chiral molecule or another one
OR < AND, because AND includes whichever molecule the OR actually happens to mean.
one group of two atoms < two groups of one atom, because the latter is 4 different diastereomers, and the former only two of the four.

When the test cases fail, the messages look like this:
-------------------------------------------------------------------------------
Enhanced stereochemistry
AND and OR match their enantiomer
-------------------------------------------------------------------------------
/Users/wandschn/Documents/src/rdkit/Code/GraphMol/Substruct/catch_tests.cpp:216
...............................................................................

/Users/wandschn/Documents/src/rdkit/Code/GraphMol/Substruct/catch_tests.cpp:218: FAILED:
CHECK_THAT( *opposite_mol, IsSubstructOf(*mol_and, ps) )
with expansion:
CC[C@@H](F)[C@@H](C)O is not a substructure of CC[C@H](F)[C@H](C)O |&1:2,4|

/Users/wandschn/Documents/src/rdkit/Code/GraphMol/Substruct/catch_tests.cpp:219: FAILED:
CHECK_THAT( *opposite_mol, IsSubstructOf(*mol_or, ps) )
with expansion:
CC[C@@H](F)[C@@H](C)O is not a substructure of CC[C@H](F)[C@H](C)O |o1:2,4|

I made a few comments inline, but a larger thing is that I'm not convinced the logic is correct.
I'm not sure I have this right, but here's my understanding of what the relationships should be:

The general ideas are:

Things not specified in the query aren't used in the matching. So the flat query structure is a substructure of everything here.
The stereoisomers the query represents must be entirely contained within the stereoisomers of the target structure.

Does this seem right?

Greg - that does seem right. I emailed outside of git, let's talk about this tomorrow.

I think I've responded to most of the suggestions here. I also added a commit with some tweaks to the documentation.


Theming: allow list.focusForeground

VSCode Version: Code - Insiders 1.13.0-insider (5057c95e6b5a43ddecee0d6f663764b7c80f6c95, 2017-05-11T06:05:28.620Z)
OS Version: Darwin x64 16.5.0
Extensions:

Extension
Author
Version

ng-template
Angular
0.1.3

code-settings-sync
Shan
2.7.0

sort-lines
Tyriar
1.2.0

Bookmarks
alefragnani
0.14.1

project-manager
alefragnani
0.16.0

path-intellisense
christian-kohler
1.4.2

vscode-eslint
dbaeumer
1.2.8

vscode-html-css
ecmel
0.1.4

tslint
eg2
0.14.0

auto-rename-tag
formulahendry
0.0.11

Angular2
johnpapa
2.2.3

vscode-icon-theme
jtlowe
1.5.0

theme-karyfoundation-themes
karyfoundation
11.1.0

HTMLHint
mkaufman
0.3.3

vscode-autoprefixer
mrmlnc
2.0.0

vscode-stylefmt
mrmlnc
2.4.1

angular2-inline
natewallace
0.0.17

typescript-hero
rbbit
0.12.0

project-snippets
rebornix
0.5.0

stylelint
shinnn
0.24.0

darcula-extended
smlombardi
3.3.2

slime
smlombardi
2.4.1

theme-tesla
smlombardi
6.0.0

change-case
wmaurer
1.0.0

Steps to Reproduce:

When creating a workbench theme, I can them all the colors I need except the foreground color of the active menu item:

All I can find is the overall "editor.foreground" but I like the color of that, but I'd rather use a lighter gray or white for the text in the active menu item.  I can (and did) theme the background but there doesn't seem to be a corresponding foreground.

Duplicate of https://github.com/Microsoft/vscode/issues/26277

https://github.com/Microsoft/vscode/issues/26277


Link to navigate to a specific panorama scene inside a tour.

Hello all,
I would like to know if it is possible with JavaScript to manipulate if a user can start the tour in a specific page/panorama instead of the default/initial one.
This feature is currently exists for example in Walkinto.
However, they use the Google location to specify the exact panorama you want to target inside the tour (Link).

However, I don't know if this can be done with Marzipano.
Thank you for your support.
Best regards,
Stefanos

It is definitely possible! However it's not currently implemented in the output from the Marzipano tool if that's what you're looking for.
I'm doing this currently in our implementation by checking the 'sceneId' query parameter within the URL and using the Marzipano 'Scene.switchTo()' function to show that scene with the associated ID (from my specific implementation) when the page is opened. This will require web development knowledge and is not an off-the-shelf solution, however Marzipano makes it easy to implement if you have that knowledge.

next... how to do can we generate a link to a specific hotspot in a given scene.. then using LookTo() etc etc


skaffold: 1.35.1 -> 1.35.2

Motivation for this change

skaffold: 1.35.1 -> 1.35.2
add installCheckPhase

Things done

Built on platform(s)

[X] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[X] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[X] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 156230 run on x86_64-linux 1

1 package built:

skaffold


[#166056703] Remove certs that are no longer required

What
We have several certs in the pipeline that are no longer required, these include the Consul certs, which were left unused after https://github.com/alphagov/paas-cf/commit/7fbe371cfe4fe04fc54213b320d95d7fb27e6809 was merged. And, metron related certs that are no longer required due to changes in the loggregator sub-system.
This commit will remove these certs from the vars store and enable our cert checking tests to pass again. The test has been failing as these carts are no longer part of the cert rotation job and have been left in the vars store.
How to review
code review
download one of the prod cf-vars-store-yaml and modify the paths in the script and run it locally. then verify that the certs have gone in the cf-vars-store-updated.yml
Who can review
Anyone with prod access.

Lee and I talked about this, but for any other reviewers: this needs a bit more done otherwise more certs than necessary are deleted


change style sheet, design, logo, front end

test the new name works

Can you please use semantic, useful names for PRs and branches? Describe what it does and why you are opening the PR.

@ColeDCrawford Please review, thx cole

@lucyzsunshine Can you throw some screenshots in the description please? I don't plan on pulling this down locally to check out how it renders.

@lucyzsunshine Can you throw some screenshots in the description, please? I don't plan on pulling this down locally to check out how it renders.
I add it in JIRA, by feature: JIRA. not able to add image here.


Focus to another monitor which contains same application, it will focus the application on current monitor but not focus next/prev monitor.

From monitor A launch a browser(or other applications), and create a new window, move it to next monitor - monitor B. So far everything works perfect.
Now launch any other app on monitor A, focus that app window. Then try to focus monitor B. We focus brower. Try to focus monitor B again. We focus monitor B.
You have to focus on the cloned window at first, then could make a move.
I also tried run command on termianl to make a focus move. Same.
It's fine if I just use one monitor. I can focus other desktop as usual even if I open browsers on every desktop.

Duplicate of #101


Update how-to-access-external-data-with-rest-in-sharepoint.md

Q
A

content fix?
yes

New article?
no

Related issues?
fixes #X, partially #Y, mentioned in #Z

Changed "Netflix" ODATA source reference made to the correct Northwind reference

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. We will now review your pull request.
Thanks,
Microsoft Pull Request Bot

thx Ransher. Small thing, but absolutely good to get updated. Change should be though targeted staging branch to avoid immediate publishing to production. This is our safety measure around avoiding issues with updates. I'll close this now due this, but would request you to resubmit and target the change to 'staging' branch. Thx.

Thx Vesa. Sorry about the oversight! I submitted a new request for the 'Staging' branch instead of master.


integrate new version of stax-ex

we need 1.8.1.NEXT (either 1.8.2 or 1.9.0)

Created autoupdate job: https://jenkins.eclipse.org/metro/job/xmlstreambuffer-master-dependency-update/
1st run:

PR: https://github.com/eclipse-ee4j/metro-xmlstreambuffer/pull/27
Issue: https://github.com/eclipse-ee4j/metro-xmlstreambuffer/issues/28

Test run, closing.

Everything works as exected.


[Feature]: ee version of the eclipse plugin

I'm having a hard time using cassandra with a regular eclipse instance. Using dbeaver-ee everything  works fine but due to limited resources of the machine I have to work on I'd like to manage my cassandra db from within my eclipse ide. I tried moving the necessary parts but to no avail. Is there a possibility that you could release an ee version of the eclipse plugin?

Already done,
Ticket closed.


add color to the icons of footer

Add color to the hover effect of the icons in the footer.
@Vin205 please assign this task to me

@Anju-Narnolia assigned!

@skmirajulislam Please help me, I am not able to start the development server after installing the dependencies
.


fix bugs from nf_tower full benchmark run

Describe your changes
Fix bugs and update test scripts related to nf-tower full benchmark runs
Checklist before requesting a review

[x] I have performed a self-review of my code

Check the correct box. Does this PR contain:

[ ] Breaking changes
[ ] New functionality
[ ] Major changes
[x] Minor changes
[ ] Bug fixes

[ ] Proposed changes are described in the CHANGELOG.md

[ ] CI Tests succeed and look good!

Good idea! One minor change requested.


Adding the encoded (jwt) token to the socket

The JWT-Token is often required on the serverside after authentication (API Scenario) -In this approach it is  saved under socket.encoded_token.

This is a pretty good idea, but would not work with the handshake.
I created an more flexible approach based on your idea. Have a look at #118.


Performance fix for Android by enabling hardware acceleration

Overview

We were having a lot of issues with performance on android such as explained in #110 but also some other users are facing in #88. By enabling hardware acceleration (default is set to software and results in extremely poor performance) for the Android Canvas we managed to solve these issues entirely. The project ran at 60fps, similar to IOS.
Here is a video showing software and hardware in action:
Hardware Acceleration OFF - performance is so bad it's impacting the recording, sorry.
Hardware Acceleration ON
Test Plan

When lots of re-renders are happening to a screen, the default code has extremely poor performance (as seen in the video). You can test this by creating a simple screen with a few MaskedView views and animating a few elements (which require for constant re-rendering at 60fps). You will notice this will result in bad performance overall only on Android and no issues on IOS.
It's a simple fix but it gets the results we have been looking for in our project.

@Naturalclar this fixes some huge performance issues for Android users, would be nice if we can get this merged asap so I can get to work on an Expo PR, since that will take the necessary time as well.

Thanks for the approval @FonDorn 👏 can't wait to finally have this fix merged so I can start on the Expo PR

@k-ibr thanks you. Please go ahead

Thank you, what is your estimation for a release including this fix?

@FonDorn @Naturalclar can someone also please publish latest version to NPM? thanks!

@k-ibr done! Should be published on npm now, thanks for the change :+1:


Fix wrong autocorrect for Style/GuardClause when using heredoc without else branch

The correction is a syntax error: the end keyword must be removed.

I want to add an assertion to expect_correction that the correction is valid syntax, but first a few more fixes to come.

Before submitting the PR make sure the following are checked:

[x] The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
[x] Wrote good commit messages.
[ ] Commit message starts with [Fix #issue-number] (if the related issue exists).
[x] Feature branch is up-to-date with master (if not - rebase it).
[x] Squashed related commits together.
[ ] Added tests.
[x] Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
[x] Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

Thanks!


Plot doesn't show up

On running the following command:
psrecord 1330 --log activity.txt --plot plot.png
After we use ctrl+z to stop the process the activity.txt file is created but there is no plot.png file created.
Moreover, I don't want to use --duration here.
How can this be solved ?

Update. Should have used ctrl+c to stop the process. Now it shows up.

The reason ctrl+z didn't work is that it stops but does not terminate the process (that is, the process can be resumed or sent to the background).

Did anyone try to stop psrecord from inside a bash script? Sending SIGINT after recording leaves me with just a log file and no pliot file.


Is there any way that I can inject the dll before the target process gets started?

Here is the case: the target process I want to monitor lasts for a brief time. It ends before I start my program(EasyHook) to inject the dll. As a consequence, I wonder if there is a way that I can get the dll injected before the target process gets started. Any help will be appreciated!

You can use CreateAndInject. This will create the process with the main thread paused until you resume it manually after installing your hooks.


fixes #1107

When doing auth, add the path of "tuf URL" before "/v2" for ping client
For more details please refer to #1107
Signed-off-by: Tan Jiang<EMAIL_ADDRESS>

Can one of the admins verify this patch?

jenkins, test this please

The circleCI failures appear legitimate. It appears path.Join is causing the trailing / on the /v2/ to be dropped, while the existing code didn't do that. I believe that's causing a 404 from the server in the failing tests.

@endophage Thanks for the comment.
I'll fix it, sorry 'bout that.

Please sign your commits following these rules:
https://github.com/docker/docker/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:
$ git clone -b "fix-ping-v2" git@github.com:reasonerjt/notary.git somewhere
$ cd somewhere
$ git rebase -i HEAD~842354216160
editor opens
change each 'pick' to 'edit'
save the file and quit
$ git commit --amend -s --no-edit
$ git rebase --continue # and repeat the amend for each commit
$ git push -f

Amending updates the existing PR. You DO NOT need to open a new one.

@reasonerjt no worries, but it does make me think we should detect the presence of a trailing / on the initial base url and add it there if necessary, then just use net/url rather than path.

jenkins, test this please

LGTM pending Jenkins but fully expect it to pass.


Query Cancellation

Implement Command.Cancel() using "KILL QUERY "

[x] Get the Thread ID using "SELECT CONNECTION_ID()"
[x] Open a new connection and kill the above ThreadID

Complete.


Cannot find module 'request' ?

$ bible 'Genesis 1:1'

module.js:341
    throw err;
    ^

Error: Cannot find module 'request'
    at Function.Module._resolveFilename (module.js:339:15)
    at Function.Module._load (module.js:290:25)
    at Module.require (module.js:367:17)
    at require (internal/module.js:16:19)
    at Object.<anonymous> (/Users/Voyga/.bible/en/index.js:2:15)
    at Module._compile (module.js:413:34)
    at Object.Module._extensions..js (module.js:422:10)
    at Module.load (module.js:357:32)
    at Function.Module._load (module.js:314:12)
    at Module.require (module.js:367:17)

node version => v5.5.0
npm version => v3.5.3

@Voyga Whoups, looks like there is an issue when npm installing the dependencies. Check out the workaround here: https://github.com/BibleJS/BibleApp/issues/18#issuecomment-172739460

@IonicaBizau I solved it after running npm install in ~/.bible/en. And now I'm running into #17 issue...

@Voyga Hmm, what's the output of the following command (you have to have curl installed, otherwise just open the link in the browser)?
curl http://labs.bible.org/api/?type=json&passage=Genesis%201:29

@IonicaBizau I think its just because of my unstable internet. curl went fine and now the babel command works just fine. Thanks!

@Voyga Yeah, somewhere the error is not handled correctly. Basically, if the request fails (e.g. no internet), the app will just crash.

Hi, sorry for bringing up the issue. I was landed on the same issue, and I solved it by manually installing the request module.
cd $HOME/.bible/en
npm install --save request

@teddyaryono Thanks for that. I have on my list to update this module soon. 🚀

This should be fixed now.


Update the kp_viz() function

The MATLAB kp_viz() function was built to produce insight on the carbon isotopes for the data. The filename creation scheme needs to be updated to fit the new relative path scheme.
Old version:
% Save figure as .fig to working directory
fi       = sprintf("MATLAB_figs\\%s_%s_CH4_and_CO2_d13C_KP_sig_bar.fig",...
                    site_tag, ddmmmyyyy);
fig_file = working_dir+fi;

Due to the fact that the directories are now written as variables directly to the "MATLB_figs" directory, the new version needs to be:
% Save figure as .fig to working directory
fi       = sprintf("%s_%s_CH4_and_CO2_d13C_KP_sig_bar.fig",...
                    site_tag, ddmmmyyyy);
fig_file = fullfile(matlab_fig_dir,fi);

for all figures in the function.
Also, the input arguments need to be changed accordingly from:
function [fig09,fig10] = kp_viz(ChamON_data, nchams,                    ...
                                KP_Fits,                                            ...
                                KP_coeffs, KP_coeffs_ci,                ...
                                site_tag, ddmmmyyyy,                    ...
                                working_dir)

and changed to:
function [fig09,fig10] = kp_viz(ChamON_data, nchams,                    ...
                                KP_Fits,                                            ...
                                KP_coeffs, KP_coeffs_ci,                ...
                                site_tag, ddmmmyyyy,                    ...
                                matlab_fig_dir)

Checks are complete, issue closed


Tooltip timer does not reset between GUI controls

Even though you can set different hover timers on GUI controls, once any tool top becomes active on an item in a GUI then all other controls on that GUI will show their text as soon as the mouse enters them with no hover timer delay.

Not super familiar with Github, or how to actually submit a proposed fix, but to fix this behavior in guiCanvas.cc you can add two lines in with the onMouseLeave handling.  The updated function should look like this:
void GuiCanvas::findMouseControl(const GuiEvent &event)
{
   if(size() == 0)
   {
      mMouseControl = NULL;
      return;
   }
   GuiControl *controlHit = findHitControl(event.mousePoint);
   if(controlHit != static_cast<GuiControl*>(mMouseControl))
   {
	   if (bool(mMouseControl))
	   {
		   mMouseControl->onMouseLeave(event);
		   hoverControlStart = Platform::getRealMilliseconds();
		   hoverPositionSet = false;
	   }
      mMouseControl = controlHit;
      mMouseControl->onMouseEnter(event);

   }
}

Thanks, ParodyGames!  If you checked in the change you could create a pull request by following these instructions: https://github.com/GarageGames/Torque2D/wiki/Contributing#creating-a-new-branch-for-a-pull-request
Give it a try if you want.  Otherwise I will create a pull request in a few days with your suggested change.  Thanks for contributing!

I tested your fix and it works great.  I've merged the code and I'm closing this issue.  Thanks again for contributing!


Apple Java JVM does not recognize the "+OptimizeStringConcat" VM option

[cstamas@marvin bin]$ ./gatling.sh
GATLING_HOME not set, using default location (/Users/cstamas/Tools/gatling-bundle-1.1.0-SNAPSHOT)
Unrecognized VM option '+OptimizeStringConcat'
Could not create the Java virtual machine.
[cstamas@marvin bin]$ java -version
java version "1.6.0_29"
Java(TM) SE Runtime Environment (build 1.6.0_29-b11-402-11M3527)
Java HotSpot(TM) Client VM (build 20.4-b02-402, mixed mode)
[cstamas@marvin bin]$ uname -a
Darwin Marvin.local 11.2.0 Darwin Kernel Version 11.2.0: Tue Aug  9 20:54:00 PDT 2011; root:xnu-1699.24.8~1/RELEASE_X86_64 x86_64
[cstamas@marvin bin]$

?!
It does recognize +OptimizeStringConcat on my MBP (this option appeared in 1.6.0_20).
MacBook-Pro-de-Stephane-Landelle:~ stephanelandelle$ java -version
java version "1.6.0_29"
Java(TM) SE Runtime Environment (build 1.6.0_29-b11-402-11M3527)
Java HotSpot(TM) 64-Bit Server VM (build 20.4-b02-402, mixed mode)
MacBook-Pro-de-Stephane-Landelle:~ stephanelandelle$ uname -a
Darwin MacBook-Pro-de-Stephane-Landelle.local 11.2.0 Darwin Kernel Version 11.2.0: Tue Aug  9 20:54:00 PDT 2011; root:xnu-1699.24.8~1/RELEASE_X86_64 x86_64 i386

Hm, client vs server VM?

Aha, adding "-server" to the very beginning of the JAVA_OPTS (and returning the "+OptimizeStringConcat") makes it work...
Busted.

You probably have something messed up in your java installation. I'm not sure I can help...
You can remove  -XX:+OptimizeStringConcat from gatling.sh but that would solve the real problem.

No, I don't have messed up anything, I just love 32bits ;) And I modified my env to have 32bits the default VM using Java Preferences.app (do NOT ask why, it has NOTHING with eclipse) :D

I didn't know OptimizeStringConcat was a server mode only option.
I'll add it to the shells in the master and the 1.1 branch.
Thanks!


How can I create a index that allows me to search across csv and txt data?

How can I create an index that allows me to search and give results based on the different data sources accurately?
Right now, just using a GPTVectorStore doesn't give me the correct results from the csv file when I ask it to query the average data for a column.

vector store index only retrieves best matched chunks of data, so won't be able to handle average query well.

Create a query tool per index and use a data agent 👍🏻
https://gpt-index.readthedocs.io/en/latest/core_modules/agent_modules/agents/modules.html


Export seekToSeconds method

I've been trying to do this but still I haven't figured out how to make it work.
on my RCTYouTubeManager.m:
RCT_EXPORT_METHOD(seekTo:(NSString *)seconds) {

    float fseconds = [seconds floatValue];

   [[RCTYouTube alloc] seekToSeconds:fseconds allowSeekAhead:@YES];

}

on my react native file:
 seekToSeconds(fractionValue){

        console.log(fractionValue);

        var seconds = fractionValue * this.state.duration;

        console.log(seconds);
        console.log(NativeModules);

        NativeModules.YouTubeManager.seekTo(seconds);

    }

In the manager, you have to pull out the view from the UI registry, and from React you'll have to pass the React tag.
RCT_EXPORT_METHOD(seekTo:(NSNumber *)reactTag seconds:(NSNumber *)seconds)
{
    [self.bridge.uiManager addUIBlock:
     ^(__unused RCTUIManager *uiManager, RCTSparseArray *viewRegistry){
         RCTYouTube *youtube = viewRegistry[reactTag];
         if ([youtube isKindOfClass:[RCTYouTube class]]) {
             [youtube seekToSeconds:seconds.floatValue allowSeekAhead:@YES];
         } else {
             RCTLogError(@"Cannot seek: %@ (tag #%@) is not RCTYouTube", youtube, reactTag);
         }
     }];
}

NativeModules.YouTubeManager.seekTo(
 React.findNodeHandle(this),
 5
);

Ah thank you!! I was able to make it work, so I had a few errors at the beginning but I was able to solve:
I had to change to this on RCTYouTubeManager your code to make it work:
- (dispatch_queue_t)methodQueue
{
    return _bridge.uiManager.methodQueue;
}

Then I had to create a ref on my react youtube tag because I'm using a slider to trigger the seek functionality:
 seekToSeconds(fractionValue){
        var seconds = fractionValue * this.state.duration;
        NativeModules.YouTubeManager.seekTo(
            React.findNodeHandle(this.refs.youtubeplayer),
            parseFloat(seconds)
        );
    },
    render(){
        return(
        <View  style={styles.container}>
            <NavBar downBtn={true} backBtn={false} fwdBtn={false} logoType={true} transparentBackground={false}/>
            <YouTube
                videoId={this.state.entryUid} // The YouTube video ID
                play={this.state.isPlaying}           // control playback of video with true/false
                hidden={false}        // control visiblity of the entire view
                playsInline={true}    // control whether the video should play inline
                onReady={(e)=>{this.setState({isReady: true})}}
                onChangeState={(e)=>{this.setState({status: e.state})}}
                onChangeQuality={(e)=>{this.setState({quality: e.quality})}}
                onError={(e)=>{this.setState({error: e.error})}}
                onPlayTime={(e)=>{this.setState({playTime: e.playTime, progress:e.playTime/e.duration, duration:e.duration})}}
                style={styles.youtubePlayer}
                ref="youtubeplayer"
                />
            <Slider
                value={this.state.progress}
                onValueChange={(value) => this.seekToSeconds(value)}
                 />

I still don't understand pretty well the UiManager stuff but I'll get there. (complete objective-c noob)

Yes, will keep both the issues open so these can be included in the project.

Merged in #28.


Fixed a bug in css.html not defaulting media attribute to 'all'.

The documentation for the extra_context option says:

For CSS, if you do not specify extra_context/media, the default media in the  output will be media="all".

Related Issue: https://github.com/jazzband/django-pipeline/issues/684

@cyberdelia Would you mind taking a look at his when you have some time or assign another maintainer to review it? Thanks in advance 👍

Coverage remained the same at 82.133% when pulling 8a4cea91b9caf194b8401de133890200882beecd on KFoxder:fix_css_html_tempalte into 3cd2f93bb47bf8d34447e13ff691f7027e7b07a2 on jazzband:master.

Coverage remained the same at 82.133% when pulling 8a4cea91b9caf194b8401de133890200882beecd on KFoxder:fix_css_html_tempalte into 3cd2f93bb47bf8d34447e13ff691f7027e7b07a2 on jazzband:master.

Coverage remained the same at 82.133% when pulling 8a4cea91b9caf194b8401de133890200882beecd on KFoxder:fix_css_html_tempalte into 3cd2f93bb47bf8d34447e13ff691f7027e7b07a2 on jazzband:master.


Binary Exponentiation in dart

Description
implement binary-exponent in dart
Related Issues or Pull Requests
closes #5618

Add a repl.it link as well

https://replit.com/join/cwzgewtw-ashutoshkhandua


Add support for local raster datasets and remote COGs using localtileserver

Built upon the amazing localtileserver package by @banesullivan, leafmap now supports loading local raster dataset and remote Cloud Optimized GeoTIFF (COG) with only one line of code.
It supports both the ipyleaflet and folium plotting backends. Use either import leafmap or import leafmap.foliumap as leafmap. The remaining code stays the same.
Add a local raster dataset
import leafmap
m = leafmap.Map()
m.add_local_tile('dem.tif', palette='matplotlib.Viridis_10', layer_name="DEM")
m

Add a remote COG
import leafmap
m = leafmap.Map()
url = 'https://opendata.digitalglobe.com/events/california-fire-2020/pre-event/2018-02-16/pine-gulch-fire20/1030010076004E00.tif'
m.add_remote_tile(url, layer_name="CA Fire")
m

Local tile:

Remote COG:

Note that band selection for multi-spectral imagery is not yet supported. Stay tuned for https://github.com/banesullivan/localtileserver/issues/22

So awesome!!! Please be aware though that I may have to change the arguments to get_*_tile_layer() when implementing multi-band support for https://github.com/banesullivan/localtileserver/issues/22. It will likely be a breaking change and I will denote it as such during the release.
FWIW, you may want to pin localtileserver<0.4.0 in your dependencies/installation instructions to prevent this from breaking when that release comes out until you have time make any necessary adjustments.

@banesullivan No worries. I am watching your repo and will make changes accordingly. Thanks a lot for adding all my requested features so quickly. I have been looking for an alternative to xarray-leaflet (which does not support Windows and can't render large files) for a long time. So excited to find localtileserver! Awesome work!


eaglefiler update

Hey,
first of all, thanks for this really nice project. I´m sorry I don`t know how to submit a pull request.
I just wanted to let you know that eaglefiler was updated to 1.7.4 on January 10, 2017.
Would be nice to see the cask updated and working.
Thanks a lot

I´m sorry I don`t know how to submit a pull request.

It’s a single command away. See https://github.com/caskroom/homebrew-cask/blob/master/CONTRIBUTING.md.
This time being done in https://github.com/caskroom/homebrew-cask/pull/30669.


#1: add support for horses in database initiation

i just added an entry called horses in initiation menu - Randy

/paulo - can you please review this pull request?

/paulo - can you check now?


feat: data-provider-cascade package added

What does this PR introduce?

🚀 Feature
Added the data-provider-cascade package to implement upload functionality for the Cascade protocol.

PR Checklist

[ ] Wrote Tests

[x] Wrote & Generated Documentation (readme/natspec/dodoc)

[ ] Ran npm run lint && npm run lint:solidity (solhint)

[ ] Ran npm run format (prettier)

[x] Ran npm run build

[ ] Ran npm run test

@richtera are you good to merge this one? So we can also merge the one on the docs.

It will also be necessary to release

@mastercodercat Can you please make sure to use pnpm and keep the lockfile up to date. I am seeing a build failure. Maybe you were using yarn or npm?


Auto create root bucket if it doesn't exist.

Fixes #183

ftl.config.YamlConfigTest > assertGcsBucket FAILED

gcs requires a token which we can't use on a public job.  As a work around, we're using the if bitrise return check.

https://github.com/TestArmada/flank/blob/4e309c205103a0a13c50f12d0d08b145905f681e/cloud_testing/kotlin_poc/src/test/kotlin/ftl/android/AndroidCatalogTest.kt#L17

ftl.MainTest > mockedTestRun FAILED
com.google.cloud.storage.StorageException: Unknown project id: 0

It looks like the mocked test broke.


Cartoonify or Sketch Effect

Hi
Have been testing the framework and it works very well.
I am trying to acheive a cartoon like effect, can anyone point me a filter or sequence of filtres to acheive it?
Thanks

Any ideas on this?


Updated randomColor url

Fix #115

Thank you!

It's an interesting project. I would like to work on more issues :)


Type aliases don't work

(User-defined) type aliases seem to be broken/unsupported and should be fixed. This allows the e.g. the following:
type CUID = String @id @default(cuid())

Duplicate of #896


Z-Wave thermostat missing some features in 0.19

Home Assistant release (hass --version):
0.19
Python release (python3 --version):
3.4.2
Component/platform:
Thermostat (Z-Wave)
Description of problem:
In 0.18.2 and under, my thermostat was referenced via thermostat.<name> and showed both the current temperature and target temperature, as well as let you set the temperature when clicked.  In 0.19 it only shows one temp (not sure which), the entity_id has changed to hvac.<name>_fan_mode, and the target temp can no longer be set after clicking the thermostat component.
Expected:
It would be nice to specify or force the device to be recognized as the old thermostat component, or at least have a warning show up that the entity_id has changed.  Otherwise, the hvac component should allow setting the temperature and showing both the current + target temps.
Problem-relevant configuration.yaml entries and steps to reproduce:
customize:
  thermostat.2gig_technologies_ct100_thermostat_usa_mode_4:
    polling_intensity: 30

Using CT100 Z-Wave Thermostat (or similar), add device to Z-Wave network in HA 0.18.2.
Specify polling_intensity (optional) for device (as above).
Load home page and note that thermostat can be controlled, and shows both current temp as well as target temp.
Repeat steps 1 and 2 for HA 0.19.
Note that the temperature no longer shows on the component when clicked, and only current temp is shown.

Traceback (if applicable):

Additional info:

That thermostat should indeed not have been discovered as an HVAC entity but as a thermostat.
CC @turbokongen

That is really wierd. It should appear in both categories. But the name have changed to thermostat.2gig_technologies_ct100_thermostat_usa_<setpoint mode>_4 in a new card. check the <> for new devices.

Should be fixed in 0.19.2


Shelter Dashboard: Update 'Contact Past Volunteers' Feature to Include 'View All' Functionality (#143) fixed

Fixes #143
What was changed?
I changed the Shelter Dashboard.
Why was it changed?
It was changed so that when the user clicked on View all in the Contact Past Volunteers component, a list of past volunteers were displayed in a table.
How was it changed?
I added two files, which processed the list of volunteers and displayed the data in the table. I added the email field to the Volunteer object, which is used by the get_volunteers API. To get the final list, I extracted the worker and email fields from the API, pair the worker with their email and remove duplicates.
Screenshots that show the changes (if applicable):

You do have to have a key to render the list using map, however, you do not have to display it. I don't think we should display the column with the # and numbers. It doesn't really provide anything for the shelter as these are arbitrary numbers. Also if there are no volunteers it should just say the no volunteers message instead of rendering it across the table.

I think it is good to include the number column, so the shelter administrator will know how many past volunteers they have. Yes, I can make the message not rendered in the table.

I would just add a field that says the number of past volunteers then instead of that column
Get Outlook for iOShttps://aka.ms/o0ukef

From: Nhi Tran @.>
Sent: Monday, November 11, 2024 8:31:43 PM
To: oss-slu/shelter_volunteers @.>
Cc: Chloe Biddle @.>; Comment @.>
Subject: [External] Re: [oss-slu/shelter_volunteers] Shelter Dashboard: Update 'Contact Past Volunteers' Feature to Include 'View All' Functionality (#143) fixed (PR #145)
You do have to have a key to render the list using map, however, you do not have to display it. I don't think we should display the column with the # and numbers. It doesn't really provide anything for the shelter as these are arbitrary numbers.
You do have to have a key to render the list using map, however, you do not have to display it. I don't think we should display the column with the # and numbers. It doesn't really provide anything for the shelter as these are arbitrary numbers. Also if there are no volunteers it should just say the no volunteers message instead of rendering it across the table.
I think it is good to include the number column, so the shelter administrator will know how many past volunteers they have. Yes, I can make the message not rendered in the table.
—
Reply to this email directly, view it on GitHubhttps://urldefense.com/v3/__https://github.com/oss-slu/shelter_volunteers/pull/145*issuecomment-2469467194__;Iw!!K543PA!KDSvIp0-fbw_od6OoxorVFBj8F4qrvbH2zdBqGYXvPbXeStnc9TUcyIwXiSh2BBCN9qBJFH-b7djuMgD2zfi2b0Ueh4$, or unsubscribehttps://urldefense.com/v3/__https://github.com/notifications/unsubscribe-auth/A5KTIZNMEO6WGUH2K6SHP6L2AFSA7AVCNFSM6AAAAABRORA4VOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINRZGQ3DOMJZGQ__;!!K543PA!KDSvIp0-fbw_od6OoxorVFBj8F4qrvbH2zdBqGYXvPbXeStnc9TUcyIwXiSh2BBCN9qBJFH-b7djuMgD2zfiQUtLRoU$.
You are receiving this because you commented.Message ID: @.***>

I would just add a field that says the number of past volunteers then instead of that column Get Outlook for iOShttps://aka.ms/o0ukef
…
________________________________ From: Nhi Tran @.> Sent: Monday, November 11, 2024 8:31:43 PM To: oss-slu/shelter_volunteers @.> Cc: Chloe Biddle @.>; Comment @.> Subject: [External] Re: [oss-slu/shelter_volunteers] Shelter Dashboard: Update 'Contact Past Volunteers' Feature to Include 'View All' Functionality (#143) fixed (PR #145) You do have to have a key to render the list using map, however, you do not have to display it. I don't think we should display the column with the # and numbers. It doesn't really provide anything for the shelter as these are arbitrary numbers.  You do have to have a key to render the list using map, however, you do not have to display it. I don't think we should display the column with the # and numbers. It doesn't really provide anything for the shelter as these are arbitrary numbers. Also if there are no volunteers it should just say the no volunteers message instead of rendering it across the table. I think it is good to include the number column, so the shelter administrator will know how many past volunteers they have. Yes, I can make the message not rendered in the table. — Reply to this email directly, view it on GitHubhttps://urldefense.com/v3/__https://github.com/oss-slu/shelter_volunteers/pull/145*issuecomment-2469467194__;Iw!!K543PA!KDSvIp0-fbw_od6OoxorVFBj8F4qrvbH2zdBqGYXvPbXeStnc9TUcyIwXiSh2BBCN9qBJFH-b7djuMgD2zfi2b0Ueh4$, or unsubscribehttps://urldefense.com/v3/__https://github.com/notifications/unsubscribe-auth/A5KTIZNMEO6WGUH2K6SHP6L2AFSA7AVCNFSM6AAAAABRORA4VOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINRZGQ3DOMJZGQ__;!!K543PA!KDSvIp0-fbw_od6OoxorVFBj8F4qrvbH2zdBqGYXvPbXeStnc9TUcyIwXiSh2BBCN9qBJFH-b7djuMgD2zfiQUtLRoU$. You are receiving this because you commented.Message ID: @.***>

Since right now, we do not have the phone number column. It is better to include the # column there. In the future, when we already have the phone number field in the API, then we can remove it.


Failure to inline scope arrays when nested scopes

Input:
const x = {xx: 1}, y = x;
function outer(q) {
  let getX, getY;
  {
    const x2 = x;
    getX = ( 0, () => ( { x, x2, q } ) );
  }
  {
    const y2 = y;
    getY = ( 0, () => ( { y, y2, q } ) );
  }
  return { getX, getY };
}

export default {
  getX: outer(1).getX,
  getY: outer(2).getY
};

Output:
const x = {xx: 1},
  createScopeOuter = ( (x, y) => q => [
    x2 => () => ( {x, x2, q} ),
    y2 => () => ( {y, y2, q} )
  ] )(x, x),
  scopeOuter = createScopeOuter(1),
  scopeOuter$0 = createScopeOuter(2);
export default {
  getX: scopeOuter[0](x),
  getY: scopeOuter$0[1](x)
};

scopeOuter and scopeOuter$0 don't need vars - they could be inlined as they're only used once.
I suspect this problem may have been introduced in 41539d7c76261c7294db5892ece7a8b4e9f70407 which created dependencies between scope records and records for values in those scopes. Perhaps additional dependents have been introduced on scope records which prevent them being inlined.

Was not introduced by 41539d7c76261c7294db5892ece7a8b4e9f70407. Problem is evident as far back as v0.4.0 (didn't check any earlier versions - probably this problem has always existed, but went unnoticed).

Created fix on inline-scopes branch. Needs tests.


[DDIDO-674] Add compatibility with Elasticsearch 7.1

Motivation and Context

JIRA issue: https://digital-engagement.atlassian.net/browse/SDPA-
Changed

Adds checks for breaking ES change to total hits response in version 7.1 https://www.elastic.co/guide/en/elasticsearch/reference/7.10/breaking-changes-7.0.html#hits-total-now-object-search-response
Update elasticsearch client to 16.7.2
Adds configurable ES client version with SEARCH_API_VERSION env var

Screenshots

How Has This Been Tested?

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Improvement/refactoring (non-breaking change that doesn't add any features but makes things better)

Checklist

[ ] I've added relevant changes to the documentation.
[ ] I have added tests to cover my changes (if not applicable, please state why)
[ ] My change requires a template update for create-ripple-app.
[ ] I have added template update script for next release.

@GROwen is this PR still relevant for the work you're doing with es 7?

@GROwen just did a double check, I think there are some other places need to be updated/checked for the total fix in this PR:

https://github.com/dpc-sdp/ripple/blob/b04eafa8de4230e344ba0f5081add3cc13addc5e/packages/ripple-nuxt-tide/modules/search/lib/search/module.js#L75
https://github.com/dpc-sdp/ripple/blob/b04eafa8de4230e344ba0f5081add3cc13addc5e/packages/ripple-tide-search-api/services/tide-search.js#L70

@GROwen just did a double check, I think there are some other places need to be updated/checked for the total fix in this PR:

https://github.com/dpc-sdp/ripple/blob/b04eafa8de4230e344ba0f5081add3cc13addc5e/packages/ripple-nuxt-tide/modules/search/lib/search/module.js#L75
https://github.com/dpc-sdp/ripple/blob/b04eafa8de4230e344ba0f5081add3cc13addc5e/packages/ripple-tide-search-api/services/tide-search.js#L70

@tim-yao Done


added optional parameter for "full" option in getmessage

Added optional parameter for full option in getmessage. So that anyone can get parsed verification link or they can get full email body. full=1 returns full email body and full=0 returns only parsed verification link

Hello, thank you for your request.
I just added this feature in version 1.0.2. Use boolean values instead of numbers. If the server does not return the parsed value, the full message will be returned, because the server returns this data in one request.

Thanks a lot


Greenkeeper/express 4.17.1

Pull Request Test Coverage Report for Build 527

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 96.774%

Totals

Change from base Build 521:
0.0%

Covered Lines:
23

Relevant Lines:
23

💛  - Coveralls

Pull Request Test Coverage Report for Build 527

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 96.774%

Totals

Change from base Build 521:
0.0%

Covered Lines:
23

Relevant Lines:
23

💛  - Coveralls


Not able to publish context aware configuration

Required Information

[ ] AEM Version, including Service Packs, Cumulative Fix Packs, etc: AEMaaCS
[ ] ACS AEM Commons Version: 6.6.0
[ ] Reproducible on Latest? yes

Expected Behavior
Context aware configuration should be published and redirects added to it should work in Publish.
Actual Behavior
all redirects which are being added to /conf/global/settings/redirects is working fine in publish when published. Context aware configuration is not however.
logs:
2024/09/28 06:13:39:234 - INFO - Request accepted with distribution package PackageMessage(pubSlingId=a06abea1-ae79-4316-98b4-08daa75fe759, reqType=ADD, pkgId=dstrpck-1727504019153-aef3e5fe-7df8-45e8-a280-f3b12f6d5255, pkgType=journal_filevault, pkgLength=4672, pubAgentName=publish, userId=replication-service, paths=[/conf/xyz/settings/redirects], deepPaths=[], metadata={}) at offset=14648888, queueSize=1, queueSizeDelay=0
2024/09/28 06:13:50:793 - INFO - Successfully applied package with id dstrpck-1727504019153-aef3e5fe-7df8-45e8-a280-f3b12f6d5255, type ADD, paths [/conf/xyz/settings/redirects]
Steps to Reproduce
Open Redirect Manager --> Add redirects to context aware configuration (/conf/xyz) --> Change tab to Publish -> Publish
Links
Links to related assets, e.g. content packages containing test components

Did you add  the cq:confproperty to  your content tree and publish it?  AEM performs a lookup based on the content and its contextual cq:conf property to find the appropriate configuration, e.g.
/content/xyz
    + jcr:content
      - cq:conf = "/conf/xyz"

/conf/xyz
    + settings
      + redirects
        + rule-1
            - source = "/content/xyz/page1"
            - target = "/content/xyz/page2"
            - statusCode = 302

Wait, So cq:conf property needs to be available at all pages and not just root page? Then i need to add it at Template?

Wait, So cq:conf property needs to be available at all pages and not just root page? Then i need to add it at Template?

No, it needs to be on the root page only. Just make sure the root page is published.
I tested redirects in AEM CS 2024.6.16971.20240628T122619Z-240600 and 6.5.21 and all was working fine for me.

i manually added cq:conf property at a specific page(other than the root page) and then it works. my root page has it already.

It could be something wrong with your content tree.
You only need cq:conf on the root page and that page needs to be published. CAconfig goes up the tree until  this property is found.
You can use the "Sling / Context-Aware Configuration" plugin in the OSGi Console to test resolution and print the metadata.

I dont see any issue there. Everything looks fine as the metadata above.

are you checking on the publish instance?

In my local it works when i created a new replication agent. I am facing this issue in AEM Cloud. I have the same content hierarchy. I could also see that sling distribution logs as mentioned above.


chore(sqllab): Do not strip comments when executing SQL statements

SUMMARY
I realize there is merit for stripping SQL comments when parsing SQL to extract tables etc., i.e., to aid with simplification, however I'm not entirely sure why we do this when executing SQL especially given that numerous SQL dialects supports  optimizer hints in the form of comments:

MySQL
Spark SQL

This PR ensures when running SQL statements in SQL Lab we don't strip away the comments.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS
CI.
ADDITIONAL INFORMATION

[ ] Has associated issue:
[ ] Required feature flags:
[ ] Changes UI
[ ] Includes DB Migration (follow approval process in SIP-59)

[ ] Migration is atomic, supports rollback & is backwards-compatible
[ ] Confirm DB migration upgrade and downgrade tested
[ ] Runtime estimates and downtime expectations provided

[ ] Introduces new feature or API
[ ] Removes existing feature or API

(I restarted the flaky MySQL test for you.)