Closes #3284: Change Stream.objects.get() into get_stream()

Closes #3284
Stream.objects.get() has been replaced with get_stream() in tests.

@jajodiaraghav seems like the travis check errored. And also could you squash your commit and push again to restart the travis check ? Thanks.

@rafidaslam Could you please help me figuring out why the build is failing?
Also please check if i have squashed the commits correctly. I haven't squashed commit before.
Thanks

@jajodiaraghav Yeah, when I look at the travis log, pep8 reports a style issue which make travis-ci check failing.
+./tools/lint-all --pep8
zerver/tests/test_subs.py:323:21: E225 missing whitespace around operator

You could fix that very simple.
And about squashing commit, I think it's not squashed properly yet. You could use git rebase interactive git rebase -i to squash the commits into one commit. Also this tutorial maybe could help you https://ariejan.net/2011/07/05/git-squash-your-latests-commits-into-one/
If you using Linux, git rebase interactive is using vi text editor maybe you could learn about this, but in Windows I guess it using notepad.
If you're stuck, feel free to ask here :)

@rafidaslam Thanks a lot for helping me out here. Even though it was a naive issue, i learnt a few things here. Please see if this fixes the issue. Thanks again.

No problem :) , added a comment.
And also about your commits, if you want to update your branch that is you work on, don't do git pull, since that will make a Merge branch... commit, otherwise you could do git rebase which put your work on the top of the branch.
You may want remove that commit (Merge branch.. commit) with git reset --hard HEAD^ which reset your branch to one previous commit.
And about commit message. Yeah, I think squashing the commits make the commit message like this:
Fixes #3284: Change `Stream.objects.get()` into `get_stream()`

Fixes #3284: Change `Stream.objects.get()` into `get_stream()`

Fixes #3284: Change `Stream.objects.get()` into `get_stream()`

You could fix that commit message with git commit --amend (after you do git reset), I'd change the commit message to Fixes #3284..

@rafidaslam Please check. Thanks :)

@jajodiaraghav it looks like you're still calling get_stream() as though it takes keyword arguments -- it does not.   Can you fix your changes to just call it as get_stream(stream_name, realm)?

@timabbott Done.

This is looks good for me, @jajodiaraghav could you squash the commit again please, thanks!

Thanks for working on this @jajodiaraghav!  The code now looks great; I fixed the commit message and merged this as c8451097bebe8ffd9fdc051a8b3b892e8cfb5b66.  Please write your commit messages in that style in the future.  Check out the Zulip commit message guidelines for more details: https://zulip.readthedocs.io/en/latest/version-control.html#commit-messages


Bug with default location

@glouel When clicking the "reset to default" it still resets it to
Users/Library/Caches/Aerial
Hope this helps you👍🏻

Thanks for the report, this is as intended though.
"Default" gets computed as startup, and if your folder is in the old location (user directory), it will consider that as default. Same if global directory.

I deleted my Cache and changed it to the new default the clicked the "reset" and it reset it to that.

Actually, unless I'm wrong, what's on the left and that you maked is the name of your Mac/Hard drive, and not your user folder. So it's working as intended for you.

What does it show BEFORE you click ?

I re-tested and it is fine now.  Thank you again👍🏻


fix: fixing encoding issues

Use decoder instead of JSON unmarshaler to avoid default float conversion
Use base64 encoding for bytes field during indexing.

Codecov Report

Merging #397 (519204f) into main (d9f53fc) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main     #397      +/-   ##
==========================================
- Coverage   28.96%   28.95%   -0.01%
==========================================
  Files          70       70
  Lines        7372     7373       +1
==========================================
  Hits         2135     2135
- Misses       5005     5006       +1
  Partials      232      232

Impacted Files
Coverage Δ

server/services/v1/search_indexer.go
15.02% <0.00%> (-0.27%)
:arrow_down:

server/services/v1/search_reader.go
0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


x11: Only access XIM from the event loop thread

XIM isn't thread-safe at all. Any call made to it from another thread will result in the event loop freezing (this is why the old implementation of Drop for Window had that problem).
XIM is now confined to one thread, and the existing API is maintained using channels. In testing this with Alacritty, I initially thought the occasional slight lag on updating the spot location was due to this change, but it's present without it as well.

Since I didn't specify, this issue is encountered by trying to call send_xim_spot from another thread. The reason it seems that no one's ever had this problem is because there's presumably a lack of applications handling windows in separate threads that also support XIM.


fix do not work filters

revert the changes in #3476a39
https://github.com/Ceasar/staticjinja/commit/3476a3977a5dc67b24cd6a9eff874e2cfbc1d35d#commitcomment-18975660

I'm not able to reproduce this. Please re-open and provide a test case if I'm overlooking something.


Event Request - page 7336 "Whse. Shipment Subform" OnBeforeOnBeforeAssembleToOrder

🕮 Describe the request
HI,
On Page 7336 "Whse. Shipment Subform", can we add a new Event Request called OnBeforeAssembleToOrder at the beginning of action "Assemble to Order".
Additional context
            action("Assemble to Order")
            {
                AccessByPermission = TableData "BOM Component" = R;
                ApplicationArea = Assembly;
                Caption = 'Assemble to Order';
                Image = AssemblyBOM;
                ToolTip = 'View the linked assembly order if the shipment was for an assemble-to-order sale.';

                trigger OnAction()
                var
                    ATOLink: Record "Assemble-to-Order Link";
                    ATOSalesLine: Record "Sales Line";
                    // NEW +
                    IsHandled: Boolean;
                    // NEW -
                begin
                    // NEW +
                    IsHandled := false;
                    OnBeforeAssembleToOrder(Rec, IsHandled);
                    if IsHandled then
                        exit;
                    // NEW -
                    Rec.TestField("Assemble to Order", true);
                    Rec.TestField("Source Type", DATABASE::"Sales Line");
                    ATOSalesLine.Get(Rec."Source Subtype", Rec."Source No.", Rec."Source Line No.");
                    ATOLink.ShowAsm(ATOSalesLine);
                end;
            }

                // NEW +
                [IntegrationEvent(false, false)]
                local procedure OnBeforeAssembleToOrder(var Warehouse ShipmentLine: Record "Warehouse Shipment Line"; var IsHandled: Boolean)
                begin
                end;
                // NEW -

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.
Build ID: 11755.


Make healpix+smoc compilation optional

Yeah, I could really use this, I think. Our main database server is still RHEL 6.x, and I don't think there's a libhealpix for it. I'm not seeing a package for it at least.
I'm getting compilation errors when trying to compile the current master branch of this repo:
g++ -Wall -Wpointer-arith -Wendif-labels -Wmissing-format-attribute -Wformat-security -fno-strict-aliasing -fwrapv -O2 -fPIC -DPGSPHERE_VERSION=1.2.1 -I. -I./ -I/local/postgres/install/15.3/include/server -I/lo
cal/postgres/install/15.3/include/internal  -D_GNU_SOURCE    -c -o src/process_moc.o src/process_moc.cpp
src/process_moc.cpp:17:26: error: healpix_base.h: No such file or directory
src/process_moc.cpp: In function 'size_t get_moc_debug(const char**, void (*)(const char*, int))':
src/process_moc.cpp:69: error: expected type-specifier before 'PlanckError'
src/process_moc.cpp:69: error: expected ')' before '&' token
src/process_moc.cpp:69: error: expected '{' before '&' token
src/process_moc.cpp:69: error: 'e' was not declared in this scope
src/process_moc.cpp:69: error: expected ';' before ')' token
src/process_moc.cpp:69: error: expected primary-expression before 'catch'
src/process_moc.cpp:69: error: expected ';' before 'catch'
src/process_moc.cpp: In function 'void moc_debug_log(void (*)(const char*, int), const char*, ...)':
src/process_moc.cpp:84: error: expected type-specifier before 'PlanckError'
src/process_moc.cpp:84: error: expected ')' before '&' token
src/process_moc.cpp:84: error: expected '{' before '&' token
src/process_moc.cpp:84: error: 'e' was not declared in this scope
src/process_moc.cpp:84: error: expected ';' before ')' token
src/process_moc.cpp:84: error: expected primary-expression before 'catch'

etc.
Any short-term workarounds that I can employ?

Any short-term workarounds that I can employ?

I hacked away at the Makefile using https://github.com/postgrespro/pgsphere/pull/13 as a guideline and managed to get it to compile, install, and crushtest OK. Whew!

@esabol I did that PR but I had a talk with our colleagues from ivoa (I guess). They wanted to make some changes in Makefile till the end of June. I've postponed my changes to avoid conflicts. I will ask them again at the beginning of next week and proceed with it.

Oh, I was going to submit a PR for this, but I'll defer to yours.

Dear @msdemlei, @df7cb. We spoke about some cleanup in Makefile. It was told that there are some changes are planning from your side in Makefile stuff (https://github.com/postgrespro/pgsphere/pull/8#issuecomment-1596674535). It least I've understood so. How is your progress going? I would like to continue with optional healpix but I'm still waiting some changes from your side to avoid potential conflicts.

Hi, we aren't ready with that yet, so please just go ahead with your changes and we'll cope afterwards. Thanks!

@esabol If you are already have a prepared patch, please, create a PR (may be after PARALLEL SAFE). Otherwise, I will plan to do it. Thank you!

The issue is done. @esabol Thank you very much!


beautify font size adjustment

Made animation smoother
Changed font color

https://user-images.githubusercontent.com/24537483/214120785-38c0c19d-7112-49f9-852d-e82f34058a5a.mp4

In my option the "Aa" is too close to the score diagram. What do you think? Maybe you should keep one of the paddings that you deleted.

In my opinion the animation still looks quite buggy. I think having a an overlayed small "bubble" like the confirmation dialog that opens would look way nicer.

I would also love to see a bubble as described by @botrufus!

In my option the "Aa" is too close to the score diagram. What do you think? Maybe you should keep one of the paddings that you deleted.

Yes I accidentally removed it, will add it back.

I would also love to see a bubble as described by @botrufus!

This wasn't in the problem statement (at least how I understood it), but will gladly do it 👍

Changes from the latest commit (now with popover):
https://user-images.githubusercontent.com/24537483/214156412-24a458a7-0537-4b0b-8a7e-86e4be0d4725.mp4


Unable to ignore external package

I don't know what I'm doing wrong, but I can't seem to be able to tell Webpack to not include the entire jQuery library. I understand that there is an externals option, but I supplied it, and it doesn't seem to have any effect on the resulting output.
Any help?
module.exports = {
  entry: {
    app: ['./src/browser.js']
  },
  output: {
    libraryTarget: 'umd',
    library: 'QueryInput',
    path: './build',
    filename: 'bundle.js',
    sourceMapFile: 'bundle.map'
  },
  externals: [
    {
      "jquery": {
        root: "jQuery"
      }
    }
  ],
  devtool: 'source-map',
  module: {
    loaders: [
      { test: /\.js$/, exclude: /node_modules/, loader: 'babel-loader'}
    ]
  }
};

Never mind. Figured it out.

In case any one wonders, it's either CommonJS or Webpack that is case insensitive. I used camelCase for loading up jQuery (jQuery), where as I set the Webpack configs to load up a lower-case version of the module name (jquery). And so, Webpack didn't think jQuery was the same as jquery, and so, it went ahead and included it in the bundle.


Fbs 53 calcular a execucao de um no

What type of PR is this?
/kind feature
What this PR does / why we need it:
Add 2 new routes:

Retrieve the nodeSpec for the specified state (GET /states/:id/spec)
Calculate the execution data of the specified state (GET /states/:id/execution)

Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?:

Additional documentation e.g., usage docs, etc.:

:tada: This PR is included in version 2.4.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Added affinity option to helm charts

Added affinity options to charts for multi-cluster deployment cases (win + linux)
fixes #329

approved. Thanks for your PR!


networkmanager: Enable ipv6 privacy extensions by default

This means the IPs will be randomized on stateless configuration? That's what Windows is doing, +1


AbstractNode.java:40-41: Implement and unit test Mapping node. Se...

The puzzle 7-9899ae24 in src/main/java/com/amihaiemil/camel/AbstractNode.java (lines 40-41) has to be resolved: Implement and unit test Mapping node. See specification: http://yaml.org/spec/1.2/spec.html#mapping//
The puzzle was created by amihaiemil on 30-Dec-16.
Estimate: 60 minutes, role: DEV.
If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code.

done


WASM userland

Emscripten is pretty bulky, and it only really provides a couple of good env functions. I've already ripped out the array translators so maybe we can wholly replace its runtime.
The hardest part is finding a working libc. Emscripten has special musl bindings.
Major dependencies:

[x] stdint — I believe latest Clang supports this natively
[ ] malloc — since we only need it for initting the cart + fundude struct, we should be able to get away with a dirt simple allocator
[x] printf
[ ] memcpy

About malloc:

Use static memory. Cart data can get up to 4 MB, so we would need to embed at least this much into the executable. This sounds a bit wasteful in the context of the Gameboy, but it is super tiny relative to a modern machine...
Use wasm memory. I'll need to embed the memory.grow instruction.
Try an external library: https://github.com/rustwasm/wee_alloc is Rust, but if wasm compatibility is half as good as I think it is, we should be able to use it.

WASI-Sysroot just works!

Fixed by https://github.com/fengb/fundude/commit/acb97c74a39407f2aff01f3eb471d6861f6bd3d8


Auto merge TestMergeBot:12.0-automerge-225ad62409ce1860e63d0f4506f75a51ad59971d-12.0

This is auto merge from TestMergeBot:12.0-automerge-225ad62409ce1860e63d0f4506f75a51ad59971d to 12.0

I'd prefer to don't merge it with latest @ilmir-k 's commits. Something seems wrong here

No problem


Merging servant-rawm into servant ?

There is some interest for shipping the RawM combinator as part of servant, see:
https://github.com/haskell-servant/servant/issues/1544
https://github.com/haskell-servant/servant/pull/1551
This would, for example, allow native support in servant-auth, without the need for a separate servant-auth-rawm package or user-defined orphan instances.
Would you be open to this idea, or do you prefer maintaining servant-rawm as a separate package ?

OK, let's take this road then !


Provide .net standard nuget packages

Hi,
is it possible you provide Nuget packages targeting .net standard?
I saw the NtApiDotNet.Core.csproj but couldn't find a corresponding nuget package.

Yes, I've not released core packages as in my experience I've not had a good reason to, the build was more to support PowerShell Core which works fairly okay with just .NET framework assemblies. However, with .NET5 maybe it's time to finally do so. I've noticed alas that the current release (1.1.29) doesn't actually build, so I need to fix that but I'll sort out of a build for that version with quick tweaks and upload it as a separate NtApiDotNet.Core package.

I've released a .NET standard 2.0 build of the library on NuGet. Hope that's useful.

Sorry, here's a link. https://www.nuget.org/packages/NtApiDotNet.Core/


Witness chunking

Describe how to rebuild a trie from a witness split into "chunks".

Hi, I am currently thinking about if we can integrate the witness specification (as experimental) into or along our Merkle Tree implementation, a description on this would be really helpful for some design decisions on an eventual implementation.

Right now it is very much in flux, our current approach that is described in the spec is not to chunk witnesses at all.
Basically, you extract a witness from the state trie and then send it full to another node.


Only delete the old key after secret successfully updated on github

This covers the corner case where for some reason (e.g. invalid github key), updating secret fails.
With the current code, the old key will already be deleted and other workflows that use the secret will stop working.
With the proposed code, both the new and the old keys will still exist and other workflows will continue working. If the failure is not handled, the next rotation will also fail because it will have >1 keys.

Thanks! This was on my to-do list.

@kapcod I'm planning to release this with https://github.com/kneemaa/github-action-rotate-aws-secrets/pull/3


methods relative to a point should be ask for refs

Meaning stuff this:
sled.set_at_dist_from(pos, 5.0, color);

should become this:
sled.set_at_dist_from(&pos, 5.0, color);

To eliminate unnecessary copying.

Vec2's are the same byte size as a reference, so no real benefits.


JSX Interpolation Issue with Embedded JavaScript Expressions

VSCode Version: 1.42.1
OS Version: macOS Catalina 10.15.2

Steps to Reproduce:

Create a JavaScript file
Paste in the following code:

const someJSX = (

{

)

Add the closing curly brace for the expression.

Expected result:
const someJSX = (

{}

)

Actual result:
const someJSX = (

{}

)

I noticed this come up sometime within the last month. I found others with the same issue here and here.

Does this issue occur when all extensions are disabled?: Yes
I have tested this without extensions. I have also tested this with both javascript and javascriptreact language modes. I have a very minimal set of user settings shown below:
{
    "workbench.startupEditor": "newUntitledFile",
    "editor.fontSize": 13,
    "editor.hover.enabled": false
}

Thanks for taking a look.

I ran some tests on my end, and this issue seems to have first come up in version 1.40 (October 2019. Everything worked as expected in version 1.39 and 1.38.

As a partial workaround, set "editor.formatOnType": true. This still de-dents on } but then immediately re-indents things

Yeah. It's a little jumpy, but it does indeed work. For the moment, I'll stick with 1.39.

If I got some direction on where to start looking I would be glad to help with that.

I was digging around in extensions/javascript/, but I have no idea if that's the right place or not.

This probably needs to be fixed in core VS Code. I suspect our indentation rules have a bug around mixed language files (we have different indentation rules for inside jsx tags and for regular JS)
@rebornix Do you have any suggestions on where someone would start investigating this issue?

Glad somebody brings this up. It isn't a huge issue but it does throw people off when something suddenly indents your code.

I figured simply selecting "Advanced" in Editor: Auto Indent will resolve this issue

I was going to report this issue too. Hopefully a fix can be committed soon. I've tried the Auto Indent: Advanced workaround, and it seems to work without unwanted side effects in JS and JSX. I am worried about the impact of the setting on other language, as it will vary based on how they define their own indentation rules.

As a supplement, can the closing curly brace be typed automatically in jsx/tsx?

I pushed a change to stop any auto indentation if the line contains multiple languages (in this case it's jsx and typescript).

@rebornix this doesn't look like expected behavior. am I doing something wrong?

@meganrogge You need to be in the javascript react language mode for this to work. Otherwise JSX expressions are not fully supported.
You can either change the language manually or use .jsx files
Marking as verified based on my testing


Only some pixels on 2d sprite stretch when moving against an object (KinematicBody2D)

Godot version
3.4.stable
System information
Windows 10, Gtx 1050 ti
Issue description
I have a pixel art sprite, moving around with kinematic body. When I scale the screen the screen to something that isn't a perfect integer scale, there's a gap in between the sprite and another object. If I move against the object, some pixels of the sprite will move over a bit, and some pixels will stay, until I let go of the movement, and it goes back to normal. I have stretch mode to 2d, and aspect to keep. I've tried enabling gpu pixel snap, but it doesn't help. I believe this has been a bug for a while now, and I'm not sure why it happens. Images are imported with 2d pixel preset.
This isn't just a problem with my project, either. I tested it on a tutorial project from heartbeast, and while it's not noticeable while a sprite is animating, if the sprite is still, it happens. This really isn't nice for pixel games.
Here's a video
https://user-images.githubusercontent.com/31216671/141687285-01fdd3ff-4288-4c47-b9d6-fab3afc8059e.mp4
Steps to reproduce
Make a simple kinematicbody2d with sprite and collision, and use a low resolution, something like 256x240, and set test scale to something higher. Set stretch mode to 2d, and aspect to keep. Make a simple staticbody2d object to test against. While playing, stretch the window larger than the default, and walk against a staticbody, and the bug should happen.
Minimal reproduction project
No response

When I scale the screen the screen to something that isn't a perfect integer scale

When doing this with Filter disabled, you will always run into issues. The solution is to force integer scaling or export your sprites at a higher resolution and enable filtering on them.

When I scale the screen the screen to something that isn't a perfect integer scale

When doing this with Filter disabled, you will always run into distortion and other issues. The solution is to force integer scaling. Alternatively, if you don't mind some blurriness, you can export all your sprites at a higher resolution (with nearest-neighbor scaling), enable Filter on the sprites and increase the camera zoom (to make the camera sit back further away).

I know that it will lead to distortion, but it's usually not as noticeable as the one in the video, the pixel-art pixels, stretch multiple screen pixels over when I try to move right. Why do the pixels stretch, even when the character shouldn't be moving?

I've come across gamemaker games that have no trouble with this, even when resizing to non-integer scale.

I still don't understand what's going on in the video I posted, though.

The jitter likely happens because the character is moving in sub-pixel increments.

I still don't understand what's going on in the video I posted, though.

The jitter likely happens because the character is moving in sub-pixel increments while trying to move against a solid object. Due to floating-point precision error, this can cause visible jitter even if GPU pixel snap is enabled.

But shouldn't move_and_slide detect that I'm not able to move, and just not show even the slightest movement? It's like when I press right, I'm trying to move into the collider, and when I let go, it pushes me back. Should that be happening?

But shouldn't move_and_slide detect that I'm not able to move, and just not show even the slightest movement?

In theory, yes. In practice, no because of the nature of collision detecting and floating-point precision not being pixel-perfect.
If you want pixel-perfect collisions, you need to implement your own physics in GDScript or C#.

It's best to move in floating point precision, and draw to the nearest rounded integer pixel coordinate on the screen.
I have this little hack in my game to force the canvas to always draw at pixel coordinates, no matter the camera position. Unfortunately this doesn't help much when scale is applied, but maybe it will help you.
var root

func _ready():
    root = get_tree().get_root()

func _process(delta):
    # Remove jittering caused by objects drawn at non-integer positions
    root.canvas_transform.origin = Vector2(round(root.canvas_transform.origin.x), round(root.canvas_transform.origin.y))


Add ability to set a placeholder hint for TextInput widgets

It's a tiny commit, but it fixes an issue I've been having with TextInput widgets. Currently, the example recommends using the set_text() method to prepopulate the text field, but this means that a user must first delete the set text before they can add their own. This PR allows the setting of a 'hint' during TextInput creation through the use of the HTML5 placeholder attribute.
The hint appears as so:

As soon as the user begins to enter text, the hint disappears automatically. Deleting all text redisplays the hint.

Can you squash the three commits together?
hint: you don't need to re-open the pull request, just force-push to your add-hint branch

Done. Thanks for the help, I'm inexperienced in this contribution business!

Thanks!


Ignore exception if elasticsearch already installed

Currently the tests fail if elasticsearch was already installed. This PR ignores the error if the elasticsearch was already installed.
https://build.weblogick8s.org:8443/job/weblogic-kubernetes-operator-kind-new/8818/

LGTM


[iOS] Native crash:  NSRangeException: *** -[__NSArray0 objectAtIndex:]: index 0 beyond bounds for empty NSArray

Environment
Library version: 3.0.2
OS version: iOS 14-16
Affected platforms

[ ] Android
[X] iOS

Current behavior
Facing native crash on prod env. Happens when it tries to get the root view, the array of subviews is empty for some reason. What is curious it happens only once per user.
NSRangeException: *** -[__NSArray0 objectAtIndex:]: index 0 beyond bounds for empty NSArray
  File "AvoidSoftInputObjCPPUtils.mm", line 30, in +[AvoidSoftInputObjCPPUtils getReactRootViewWithRootViewController:]
  File "AvoidSoftInputManager.swift", line 107, in AvoidSoftInputManager.softInputHeightWillChange
  File "AvoidSoftInputImpl.swift", line 151, in AvoidSoftInputImpl.softInputHeightWillChange
  File "<compiler-generated>", in AvoidSoftInputImpl.softInputHeightWillChange
  File "main.m", line 7, in main

Unfortunately can't reproduce it on dev env.
Expected behavior
No crashes because of the reason.
I've made a patch with an additional condition to check if the array of subviews is empty and am wondering if it's suitable for you as a general solution.
{
  if ([
        viewController.view isKindOfClass:[
#ifdef RCT_NEW_ARCH_ENABLED
        RCTFabricSurfaceHostingProxyRootView
#else
        RCTRootView
#endif
        class]] &&  viewController.view.subviews.count > 0)
    {
    return viewController.view.subviews[0];
  }

  return viewController.view;
}

Reproduction

Hey @max-kim , thx for reporting the issue! Could you make a PR with that patch? I would be very happy to merge it

Thx so much 🎉 the fix is included in version 3.0.4


something is happening

Describe the bug
when I talk on one side with dvc and the other with simple vc it works for a few seconds then stops working
To Reproduce
Steps to reproduce the behavior:

join the server on one account with simple voice chat
join the server on a account that doesn't have simple voice chat
on the second account do the command '/dvc start'
talk on both ends
then it stops working

Expected behavior
I expected it to work
Screenshots

Logs
[18:36:07] [voicechat-discord: Reset Thread #1/INFO]: [voicechat-discord] [DEBUG 2] resetting sender for player with UUID 00000000-0000-0000-0009-01f32d9e2e9c
[18:36:15] [voicechat-discord: Reset Thread #1/INFO]: [voicechat-discord] [DEBUG 2] resetting sender for player with UUID 00000000-0000-0000-0009-01f32d9e2e9c
[18:36:17] [voicechat-discord: Reset Thread #1/INFO]: [voicechat-discord] [DEBUG 2] resetting sender for player with UUID 00000000-0000-0000-0009-01f32d9e2e9c
[18:36:22] [VoiceChatPacketProcessingThread/INFO]: [voicechat-discord] [DEBUG 3] packet is a EntitySoundPacketImpl
[18:36:22] [VoiceChatPacketProcessingThread/ERROR]: [voicechat] Uncaught exception in thread VoiceChatPacketProcessingThread
java.lang.NoSuchMethodError: 'org.bukkit.command.CommandSender net.minecraft.world.entity.Entity.getBukkitSender(net.minecraft.commands.CommandSourceStack)'
at voicechat-discord-paper-3.0.5.jar/dev.amsam0.voicechatdiscord.PaperPlatform.getEntityPosition(PaperPlatform.java:59) ~[voicechat-discord-paper-3.0.5.jar:?]
at voicechat-discord-paper-3.0.5.jar/dev.amsam0.voicechatdiscord.PaperPlatform.getEntityPosition(PaperPlatform.java:84) ~[voicechat-discord-paper-3.0.5.jar:?]
at voicechat-discord-paper-3.0.5.jar/dev.amsam0.voicechatdiscord.DiscordBot.handlePacket(DiscordBot.java:285) ~[voicechat-discord-paper-3.0.5.jar:?]
at voicechat-bukkit-2.5.25.jar/de.maxhenkel.voicechat.plugins.PluginManager.onListenerAudio(PluginManager.java:126) ~[voicechat-bukkit-2.5.25.jar:?]
at voicechat-bukkit-2.5.25.jar/de.maxhenkel.voicechat.voice.server.Server.sendSoundPacket(Server.java:383) ~[voicechat-bukkit-2.5.25.jar:?]
at voicechat-bukkit-2.5.25.jar/de.maxhenkel.voicechat.voice.server.Server.broadcast(Server.java:431) ~[voicechat-bukkit-2.5.25.jar:?]
at voicechat-bukkit-2.5.25.jar/de.maxhenkel.voicechat.voice.server.Server.processProximityPacket(Server.java:379) ~[voicechat-bukkit-2.5.25.jar:?]
at voicechat-bukkit-2.5.25.jar/de.maxhenkel.voicechat.voice.server.Server.processMicPacket(Server.java:316) ~[voicechat-bukkit-2.5.25.jar:?]
at voicechat-bukkit-2.5.25.jar/de.maxhenkel.voicechat.voice.server.Server.onMicPacket(Server.java:303) ~[voicechat-bukkit-2.5.25.jar:?]
at voicechat-bukkit-2.5.25.jar/de.maxhenkel.voicechat.voice.server.Server$ProcessThread.run(Server.java:269) ~[voicechat-bukkit-2.5.25.jar:?]
[18:36:25] [voicechat-discord: Reset Thread #1/INFO]: [voicechat-discord] [DEBUG 2] resetting sender for player with UUID 00000000-0000-0000-0009-01f32d9e2e9c
[18:36:32] [voicechat-discord: Reset Thread #1/INFO]: [voicechat-discord] [DEBUG 2] resetting sender for player with UUID 00000000-0000-0000-0009-01f32d9e2e9c
[18:36:39] [voicechat-discord: Reset Thread #1/INFO]: [voicechat-discord] [DEBUG 2] resetting sender for player with UUID 00000000-0000-0000-0009-01f32d9e2e9c
[18:36:42] [voicechat-discord: Reset Thread #1/INFO]: [voicechat-discord] [DEBUG 2] resetting sender for player with UUID 00000000-0000-0000-0009-01f32d9e2e9c
[18:36:50] [voicechat-discord: Reset Thread #1/INFO]: [voicechat-discord] [DEBUG 2] resetting sender for player with UUID 00000000-0000-0000-0009-01f32d9e2e9c
[18:36:57] [voicechat-discord: Reset Thread #1/INFO]: [voicechat-discord] [DEBUG 2] resetting sender for player with UUID 00000000-0000-0000-0009-01f32d9e2e9c
[18:36:59] [voicechat-discord: Reset Thread #1/INFO]: [voicechat-discord] [DEBUG 2] resetting sender for player with UUID 00000000-0000-0000-0009-01f32d9e2e9c
[18:37:16] [voicechat-discord: Reset Thread #1/INFO]: [voicechat-discord] [DEBUG 2] resetting sender for player with UUID 00000000-0000-0000-0009-01f32d9e2e9c
[18:37:29] [Server thread/INFO]: .Lets_game6531 issued server command: /dvc stop
[18:37:29] [voicechat-discord: Bot Stop for 00000000-0000-0000-0009-01f32d9e2e9c/INFO]: [voicechat-discord] [DEBUG 1] waiting for reset thread to end
[18:37:29] [voicechat-discord: Reset Thread #1/INFO]: [voicechat-discord] [DEBUG 1] reset thread 1 interrupted
[18:37:29] [voicechat-discord: Reset Thread #1/INFO]: [voicechat-discord] [DEBUG 1] reset thread 1 ending
[18:37:29] [voicechat-discord: Sender Thread #1/INFO]: [voicechat-discord] [DEBUG 1] sender thread 1 ending
Versions (please complete the following information):

Minecraft: 1.21.3
Loader (paper, purpur, fabric, quilt, etc): paper
Simple Voice Chat: voicechat-bukkit-2.5.25.jar
Simple Voice Chat Discord Bridge: voicechat-discord-paper-3.0.5.jar

Thank you for the logs. I don't know when I'll have time to fix this, but I'll keep it in mind.

when will you do the next update? and when will you update the plugin to 1.21.4?

#75. Pestering me about it makes me less likely to update it.

Closing as a duplicate of #76


Default value given as input to Order or Limit functions

Describe the feature
Order and Limit should behave like gorm v1, where given an empty string or zero, it just ignores and return immediately. Now when the type's default value is given, invalid SQL is generated.
Motivation
Easier for the user of the library and makes chaining functions possible, like it was in v1.
c := conn.Set("gorm:auto_preload", true).
	Where(params.FilterExp, params.FilterArgs...)

if params.Limit > 0 {
	c = c.Limit(params.Limit)
}

if params.Sort != "" {
	c = c.Order(params.Sort)
}

return c.First(out).Error

vs
return conn.Set("gorm:auto_preload", true).
    Where(params.FilterExp, params.FilterArgs...).
    Limit(params.Limit).
    Order(params.Sort).
    First(out).Error

Related Issues

My team is trying to add support for gorm.io/gorm to our internal libraries, and restoring the behavior of DB.Order from the original gorm API would be really appreciated. I'm willing to write the PR, since it should be relatively simple.


bondage.js crashes when accessing a node that has "-" in its title

It seems to be triggered by the node title containing "-" in the title
Yarn loses the color syntax when you use "." or "-" in the title, but if that ever becomes available in bondage.js I can update yarn to allow it too :)

another further action I can take is to sanitize the title input field of nodes- so users cant enter anything but [A-z0-9]

The sanitisation approach would be easier for me to do, because I already wrote a method to validate titles of nodes and mark them red when they already exist in other nodes. I can just add another check to that, but it will have smaller benefits as compared to being able to handle symbols in the title


Add initial Travis config

Scripts and config are mostly copied from github.com/bazelbuild/bazel-skylib

@devangrose Please take a look at this change.

@tomasz-wiszkowski PTAL


Using the sidebar exported by this plugin, the Prev Next Links of this page cannot be automatically generated?

Describe the bug A clear and concise description of what the bug is.
To Reproduce Steps to reproduce the behavior:
Expected behavior A clear and concise description of what you expected to happen.
Screenshots If applicable, add screenshots to help explain your problem.
Desktop (please complete the following information):

OS: [e.g. Windows 10]
Browser [e.g. Chrome, Safari]

Additional context Add any other context about the problem here.

Hello, thank you for using vitepress-sidebar.
Please fill in the issue details about what issue you are experiencing and how to reproduce it. The issue title alone will not help us to resolve the issue.
Generally speaking, automatically created links support creating prev/next links. If you are not seeing prev/next links, it is possible that you have a different directory structure or the URLs are being handled incorrectly.

Not responding to the answer, please open a new issue with a detailed description if the issue is still reproduced.


That's not how to enable an entity for access teams

Hello, the steps to enable an entity for access teams is not correct.
https://docs.microsoft.com/en-us/power-platform/admin/create-team-template-add-entity-form#enable-an-entity-for-access-teams
The described procedure is to open Power Platform Admin Centre then...

Select an environment and go to Settings > Users + permissions > Teams.
Select the check box for a team.
On the command bar, select More Commands (...).
Select Customize Entity.

These steps are incorrect. You can't change the settings for an entity (now called a table, BTW) from the Power Platform Admin Center or by opening a team.
The correct steps are to open the appropriate table from the Power Apps Maker Portal and to enable the 'Auto create access teams' check box for the table.
[Enter feedback here]

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 1579637e-7845-9830-1d8f-40d371d28587
Version Independent ID: 6f00c801-369f-01e4-df15-36ad10c5f1bd
Content: Create a team template and add to an entity form - Power Platform
Content Source: power-platform/admin/create-team-template-add-entity-form.md
Service: power-platform
Sub-service: admin
GitHub Login: @paulliew
Microsoft Alias: paulliew

@Customery
Thanks for the feedback. We revised this back in September. Forgot to close this issue.


Create Flux plugin

A Flux plugin would be very useful for all users of flux who would like a UI for it and who could also benefit from having it integrated in a generic K8s UI like Headlamp.

The progress on this is tracked here https://github.com/headlamp-k8s/plugins/pull/75
The plugin should look for Flux installation on the Cluster and show different views related to Flux.

[x] Application List View is Done
[x] Application Detail View Lists basic detail about a Kustomization or a HelmRelease
[x] Application Detail View has Sync With Source and Sync Without Source action buttons
[x] Application Detail View has Suspend action button
[x] Application Detail View also lists The inventory and links them to the correct K8s resource view on Headlamp
[x] Source List View is Done
[x] Source Detail View shows basic detail About a GitRepository or  OCIRepository or Buckets or HelmRepos and HelmCharts
[x] Source Detail View Allows suspending and resuming reconciliation
[x] Notification List View is done
[] Notification Detail View is done
[x] Image Automation List View is done
[x] Image Automation Detail View shows basic details for Image Repo or Image Policies or Image Update Automations
[x] Flux Runtime View Lists all the flux related controllers and CRDs
[ ] Flux Runtime shows the running version of flux

I've got this running in a cluster now:

looking good! I need to add some flux artifacts, there may be one or more possibilities for how to detect the Flux Runtime version. I am seeing a label on each of my controllers, for example:
  labels:
    app.kubernetes.io/component: helm-controller
    app.kubernetes.io/instance: cozy-fluxcd
    app.kubernetes.io/managed-by: flux-operator
    app.kubernetes.io/part-of: flux
    app.kubernetes.io/version: v2.3.0
    control-plane: controller
    fluxcd.controlplane.io/name: flux
    fluxcd.controlplane.io/namespace: cozy-fluxcd

This is a managed flux, via flux-operator, so this may differ (?) from how it looks on a flux installed via flux boostrap or flux install - need to double check

So I have a declarative (HelmRepository/HelmRelease) YAML to install Headlamp with the Flux plugin now, and it's working, but:

There's the HelmRelease, it installed successfully, I can see the events at the top level, but clicking through to see the details of the HelmRelease results in an error:

I think it would be beneficial to plug it into a dev container or okteto CLI next, so we can iterate on the in-cluster version without building a new container every time we want to test a change... but I'm going to stop now because this is great progress, and the Flux dev meeting is in about 15 minutes, people will have gut reactions and feedback there I'm sure!
(fluxcd.io/community/#meetings if you want to join us, all the information is there)

I see the more centralized discussion is ongoing here:
https://github.com/headlamp-k8s/plugins/pull/75

That's interesting! I am a bit biased by my love for K9s, and my vengeance against click-ops, but I can definitely see some use cases for a read-only UI. It is quite easy to explain GitOps at a high-level, but when you dive into it, it can be a different story. So having a UI that could be pulled out to help alleviate that would be nice.
How does it compare/place it self to e.g.

https://github.com/gimlet-io/capacitor
[https://github.com/weaveworks/weave-gitops?tab=readme-ov-file](Weave GitOps)

The last one might be a dead project too 🤷🏻♂

@kingdonb thank you again.
I have tried using the Helm release with init container values, but the pod is stuck in a pending state as follows,
kl -n kube-system my-headlamp-567fc4bfdb-h49dp
Defaulted container "headlamp" out of: headlamp, headlamp-plugins (init)

It's likely pending because of a persistent volume claim that is unfulfilled, I had to change mine from ReadWriteMany to ReadWriteOnce but depending on your environment you may not have a CSI driver for storage classes at all


What's the cost of expected-lite vs an exception?

Is expected-lite much more expensive than using exceptions? It's very practical and would lead to significantly cleaner code than exception handling but what is the runtime cost?

Bump

I have not investigated it. The answer likely is: it depends -- on the specifics of how/where you use it.
Would be nice if you could shed some light on it !

@ruipacheco At the ACCU 2017 Conference, Niall Douglas did a talk on std::expected:
Mongrel Monads, Dirty, Dirty, Dirty - Niall Douglas [ACCU 2017]
57 minutes in is a section Benchmarking performance; Why not just throw exception and save all this hassle?

Will check it asap.


Changelog for the 2.0.1 release

Includes updating the VERSION constant in the Autoload class.

Release checklist
Functional

[x] Confirm that the most recent PHPUnit changelogs have been checked and that the library is still feature complete for those versions supported within the PHPUnit version constraints.
[x] Update the VERSION constant in the phpunitpolyfills-autoload.php file. - PR #166
[x] Composer: check if any dependencies/version constraints need updating. - PR #163

Release

[x] Add changelog for the release - PR #166
Verify that a release link at the bottom of the CHANGELOG.md file has been added.
[ ] Merge this PR.
[ ] Make sure all CI builds are green.
[ ] Tag the release (careful, GH defaults to 2.x!).
[ ] Create a release from the tag (careful, GH defaults to 2.x!) & copy & paste the changelog to it.
Make sure to copy the links to the issues and the links to the GH usernames from the bottom of the changelog!
[ ] Close the milestone.
[ ] Open a new milestone for the next release.
[ ] If any open PRs/issues which were milestoned for the release did not make it into the release, update their milestone.

Announce

[ ] Tweet about the release.
[ ] Toot about the release.

coverage: 95.679%. remained the same
when pulling 42c0c72fda01c05606c0f52d731494cae30c9efd on feature/changelog-2.0.1-release
into 17f46e2f5a2627be600672dbc7087418c5bf3bbe on 2.x.

Release toot: https://phpc.social/@jrf_nl/112219623460573138
Release tweet: https://twitter.com/jrf_nl/status/1776290271807799341


ubi check fails despite running against ubi-based image

@komish
I just ran a test with the new one. PTAL at my observations below:

When I marked the host level access in my project as "Unprivileged"

preflight-linux-amd64 check container </path/to/myregistry/image> -d /run/user/1000/containers/auth.json --pyxis-api-token=<mytoken> --certification-project-id=<mycertid>
Login Succeeded!
time="2022-07-26T19:37:44-04:00" level=info msg="certification library version 1.3.3 <commit: 6c30f7caae731ecc2faeaebd78c6d3981c708fe6>"
time="2022-07-26T19:38:05-04:00" level=info msg="check completed: HasLicense" result=PASSED
time="2022-07-26T19:38:05-04:00" level=info msg="check completed: HasUniqueTag" result=PASSED
time="2022-07-26T19:38:05-04:00" level=info msg="check completed: LayerCountAcceptable" result=PASSED
time="2022-07-26T19:38:06-04:00" level=info msg="check completed: HasNoProhibitedPackages" result=PASSED
time="2022-07-26T19:38:06-04:00" level=info msg="check completed: HasRequiredLabel" result=PASSED
time="2022-07-26T19:38:06-04:00" level=info msg="detected empty USER. Presumed to be running as root"
time="2022-07-26T19:38:06-04:00" level=info msg="USER value must be provided and be a non-root value for this check to pass"
time="2022-07-26T19:38:06-04:00" level=info msg="check completed: RunAsNonRoot" result=FAILED
time="2022-07-26T19:38:16-04:00" level=info msg="check completed: HasModifiedFiles" result=PASSED
time="2022-07-26T19:38:16-04:00" level=info msg="check completed: BasedOnUbi" result=FAILED

Problem:
Now, I expect the RunAsNonRoot to fail, because my container runs as root (inside). But, why did BasedOnUbi fail? My container is 100% based on UBI.

When I marked the host level access in my project as "Privileged"

preflight-linux-amd64 check container </path/to/myregistry/image> -d /run/user/1000/containers/auth.json --pyxis-api-token=<mytoken> --certification-project-id=<mycertid>
Login Succeeded!
time="2022-07-26T19:42:46-04:00" level=info msg="certification library version 1.3.3 <commit: 6c30f7caae731ecc2faeaebd78c6d3981c708fe6>"
time="2022-07-26T19:43:06-04:00" level=info msg="check completed: HasLicense" result=PASSED
time="2022-07-26T19:43:07-04:00" level=info msg="check completed: HasUniqueTag" result=PASSED
time="2022-07-26T19:43:07-04:00" level=info msg="check completed: LayerCountAcceptable" result=PASSED
time="2022-07-26T19:43:07-04:00" level=info msg="check completed: HasNoProhibitedPackages" result=PASSED
time="2022-07-26T19:43:07-04:00" level=info msg="check completed: HasRequiredLabel" result=PASSED
time="2022-07-26T19:43:17-04:00" level=info msg="check completed: HasModifiedFiles" result=PASSED

Problem:
All tests passed and I expect the RunAsNonRoot test to be skipped.
But why did it also skip BasedOnUbi test?
Also, as described above, my images are 100% based on ubi8. So,
a.) Shouldn't it be running the BasedOnUbi test when the project is marked as Privilged as well? and;
b.) it should pass the BasedOnUbi test because my image is in fact based on ubi.

Can you upload the output from:
podman image inspect quay.io/bcrochet/container-passes | jq '.[].RootFS'

Here:
{
  "Type": "layers",
  "Layers": [
    "sha256:3c9205208d5414d089f6885fba43ae3c843b08f2a5ea0731f402c922ecc128d3"
  ]
}

{
  "Type": "layers",
  "Layers": [
    "sha256:3c9205208d5414d089f6885fba43ae3c843b08f2a5ea0731f402c922ecc128d3"

If your image is based on UBI than please do not squash layers to single one.
You can squash layers which you use for building your images.
But layers for parent/base UBi iamge must be unchanged.

@imperialguy Like @lslebodn mentioned, you cannot modify UBI layers/files/etc, please see the follow link for all of the container certification polices to make sure your image complies.

Okay, assuming I don't squash them, will this check also be added to Privileged containers?

@imperialguy Yes, UBI check was missed in a refactor, it's been added back to main. If you want to build from main to test, feel free. We should have a release with this in the next few days.

Gotcha. Cool. just tested with layers intact. it passes. will wait for the next release to test against privileged. Thanks.

@imperialguy We have released a fix to add back in the UBI check for Privileged containers. Let us know if you have any more issues.

Relates: #746


Realm: not registering ib_rsize with the GPU

Currently Realm will not attempt to register ib_rsize with the GPU, so if we need to copy an instance from node A's framebuffer to node B's framebuffer, the DMA system will always have to introduce an intermediate hop:
fsizeA -> ib_zsizeA -> ib_rsizeA -> ib_rsizeB -> ib_zsizeB -> fsizeB

If Realm tried (and succeeded) to register ib_rsize with the GPU, then the same transfer could be done with fewer hops:
fsizeA -> ib_rsizeA -> ib_zsizeB -> fsizeB

@eddy16112 Is this still relevant?

We are not registering the ibrsize with the GPU, but when I run the memspeed, we never go through the ibzsize.
[0 - 7fad78012c40]    0.516986 {2}{app}: copy 1e00000000000002 -> 1e00010000000002: bw:3.82905 lat:222275, num_hops_full_copy:3, num_hops_short_copy:3
[0 - 7fad78012c40]    0.516998 {3}{app}: Copy path for full copy:
[0 - 7fad78012c40]    0.517002 {3}{app}: From:[1e00000000000002], to:[1a00000000000002], channel:6
[0 - 7fad78012c40]    0.517007 {3}{app}: From:[1a00000000000002], to:[1a00010000000002], channel:12
[0 - 7fad78012c40]    0.517011 {3}{app}: From:[1a00010000000002], to:[1e00010000000002], channel:5

The 1a00000000000002 is ibrsize.


fix: use thread subscription set endpoint

As I used the new unsubscribe feature, I discovered an annoying little idiosyncrasy - the set thread subscription endpoint encompasses more thorough functionality than the delete thread subscription endpoint.
Essentially - both endpoints can mute all future notifications for a conversation until you comment on the thread or get an @mention. However, the delete endpoint includes this caveat:

If you are watching the repository of the thread, you will still receive notifications.

Which sort of nerfs a lot of the reasons one would unsubscribe from a notification in the first place. To unsubscribe regardless of watch status, one should actually hit the set thread subscription endpoint with a PUT call and pass ignore: true in the call body, which is what this PR does.
cc @manosim

Great catch @codebytere - thank you for explaining and fixing it too 🎉


Added a blog on SkyWalking Application Monitor

Hey @siddhantprateek, please, update the date in heading to match todays date (or whenever you finished the task).
Also author name should match the file name. In your case, the name is siddhant-prateek.

can u tell me which time I should mention on, is it PST or GMT or I should follow my country's time

@siddhantprateek I believe this is not important as long as the date is correct :) you can use your local time.

@sakows (or @sakomws) we can merge this PR and let @siddhantprateek share his post :)


Generated feed does not validate on validator.w3c.org

Discovered this issue while looking into another issue. An example: https://validator.w3.org/feed/check.cgi?url=b-side.donny.io%2Ffeed.xml

Based on the validation report, the errors seem to be because of en_US set as lang attribute.
This is actually defined in your config file.
Therefore, edit your config file to:
_config.yml

lang: en
locale: en_US

Consequently, do edit the layouts and includes of your site to reflect the change above.

Great, edited the issue and now my feed validates. It was my mistake after all, thanks!


Gracefully shutdown on SIGINT / SIGUSR2

When shutting down the application, it would be nice to gracefully disconnect all connected clients, and then dispose of the rooms.

Listen to SIGINT / SIGUSR2 (triggered by nodemon)
Disconnect all connected clients

Ensure onLeave is called for each of them, onLeave can be an async function.

Dispose of all spawned rooms

Ensure onDispose is called for each room, onDispose can be an async function.

Shutdown after previous steps are finished.

Pull-request: https://github.com/gamestdio/colyseus/pull/108

This still won't work with the latest version of ts-node. Only works using node / .js files for now.


Adding return type into autocompletion list details

Showing return type in autocompletion list would be very helpful.
![Autcompletion screenshot]
(http://s9.postimg.org/r36ax0prj/Screen_Shot_2016_04_09_at_3_34_11_PM.png)

Hi @dopare, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution!

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. Real humans will now evaluate your PR.

TTYL, DNFBOT;

master is locked down at the moment. I'm going to go ahead and rebase this against dev and resubmit. Thanks @dopare!

OK. Rebased and resubmitted as #195.


[calibre] new chart

Description of the change
Calibre chart with webbased acces to the desktop app. Very handy!
Checklist

[x] Chart version bumped in Chart.yaml according to semver.
[x] Title of the PR starts with chart name (e.g. [home-assistant])
[x] (optional) Chart is using our common library as a dependency.
[x] (optional) Variables are documented in the README.md

Just noticed this the version mistake on wikijs too, I opened a PR for that here https://github.com/k8s-at-home/charts/pull/666
I had to bump the version to 3.0.0 because we cannot "downgrade" a version.

@all-contributors please add @rolfberkenbosch for code


fix(mobile): Rework topbar buttons in chat when in mobile view

What this PR does 📖

Rework the topbar buttons in chat for the mobile view. Fixes things like buttons being too crowded or going out of the screen.
Buttons are now hidden behind a "More" button that when clicked will show those additional options

Which issue(s) this PR fixes 🔨

Resolve #1341

needs layout change

even though i dont think that pinned thing fits in this pr i still added it if thats ok.

Along with what @XileHorizon said we should probably do the same for the Edit Groups
Another thing I noticed is the call button should say "Call" when user has experimental flagged on

wondering @XileHorizon if you have a figma or some ideas for edit groups layout?

Along with what @XileHorizon said we should probably do the same for the Edit Groups
Another thing I noticed is the call button should say "Call" when user has experimental flagged on

wondering @XileHorizon if you have a figma or some ideas for edit groups layout?

If the Groups issue is a little out of scope of the Pr and youd rather just fix the call button and handle the groups in a new ticket that works for me Just lemme know 👍 😄

since i already did the pinned msg thing i would just do this in this pr too


[h2.client]: call error handler when the server closes the connection

fixes #177

@ansiwen @dinosaure could you provide some feedback on this one?

Will do soon! 👍


Plans for including functional/method level coverage ?

In ruby 2.5.* , functional level coverage is implemented by the underlying Coverage library.
But as of SimpleCov v0.17.1 , functional coverage reporting is not supported by SimpleCov.
Are there plans to support this ?

Hi there @amitSA,
so you mean method level coverage? (not sure what you mean with "functional").
Yes it is planned, I just didn't have the time to do so by now. That said it's not on the top of my list, first it's getting branch coverage in and then some rails integration problems. If I have time after that method level coverage will be implemented, albeit after branch coverage is in it should hopefully be rather easy.
I'll have a lot more time to dedicate to simplecov starting in December so I might be able to do some feature catch up then.
Cheers,
Tobi

Hi @PragTob
Yes I meant method level coverage! And i appreciate you dedicating your free time on simplecov.  Helps all of us :)
I'll close the issue now.


Doesn't work on Mozilla

I already open my PHP port on localhost:8000 but why it is still doesnt work? ,
thank you :)

There could be a million reasons and with the little information you gave it is impossible to help you. I would appreciate more information.
For example:
What server do you use?
When following the Setup point by point, did you have any problem?
Did you make sure to load your application on the server path and check that it worked?


'microsoft.substrateConnectors.externalGroup' could not be resolved by the model

Hi, am trying to create an external group, but this isn't working.
Reference Docs: https://docs.microsoft.com/en-us/graph/api/externalconnection-post-groups?view=graph-rest-beta&tabs=http
I have created a connection, schema with some properties. I need to create an externalGroup to restrict access to items for certain users.
I've tried this in postman for example,
POST https://graph.microsoft.com/beta/external/connections/now/groups ("now" is my connection id)
Request Body:
{
<EMAIL_ADDRESS>"#microsoft.graph.externalGroup",
  "id": "testgroup",
  "displayName": "Test Group",
  "description": "Test Group"
}

but it doesn't work, I get a 400 Bad Request error with following response Body
Response:
{
  "error": {
    "code": "InvalidRequest",
    "message": "The request is malformed or incorrect.",
    "innerError": {
      "code": "DeserializationError",
      "message": "A type named 'microsoft.substrateConnectors.externalGroup' could not be resolved by the model. When a model is available, each type name must resolve to a valid type.",
      "date": "2021-03-14T18:41:29",
      "request-id": "60af803c-30e3-4bd7-8d38-0e2fb45f0a0b",
      "client-request-id": "60af803c-30e3-4bd7-8d38-0e2fb45f0a0b"
    }
  }
}

Is this the right way to query this?
Similar Issue can be seen for externalGroupMembers as well. https://docs.microsoft.com/en-us/graph/api/externalgroup-post-members?view=graph-rest-beta&tabs=http
AB#8595

Confirmed with product group that removing the<EMAIL_ADDRESS>line is the proper approach.  We'll update the documentation to reflect this.  Thanks for reporting.
Expected payload syntax for request body:
{
  "id": "testgroup",
  "displayName": "Test Group",
  "description": "Test Group"
}


custom draw group names exhibit inconsistent order behavior

TO REPRODUCE THE ISSUE, FOLLOW THESE STEPS:

open https://mapzen.com/tangram/play/?scene=https%3A%2F%2Fgist.githubusercontent.com%2Fanonymous%2F3357ad94337126f25e4142eace7de740%2Fraw%2Fc09ca185bdf1cc4f6bcedb6523e38aad58ae8c5a%2Fscene.yaml#16/40.6998/-73.9891
comment out lines 19-20:

_highwayStyle:
    style: lines

uncomment line 21:

# lines:
RESULT:
The order changes, and the _highwayStyle layer is drawn on top of the other roads instead of beneath them.
EXPECTED RESULT:
The ordering will be the same as before.
(99% certain this is a syntax misunderstanding and not a bug)

When the _highwayStyle draw group is present, you are drawing the lines twice: once for the inherited lines group, and once for _highwayStyle.
_highwayStyle is given order: 0 so you see the red lines underneath with gray lines on top (lines at order: 1).
When you comment out _highwayStyle, the lines are only rendering once, for lines. They are still in fact rendered underneath (you can see other gray lines over them). You don't see the second set of gray lines overlaid on them, because they are only being drawn once, and their color and width are being overridden by _highwaySubLayer.
Every unique draw group name will cause the geometry in that layer to be drawn another time. This is also why I think it is generally not a good idea to use custom draw group names like _highwayStyle unless you really intend to draw the same geometry multiple times -- if you use the default style names, it's harder to do this unintentionally (you can only have one lines key).

:+1: Thanks!


How to search from current version

How to search only from the current version，
http://ganpc.gitee.io/julien/

This is supported in v0.27.0


break points do not work

the break points do not work even on demo https://xuopled.github.io/react-responsive-masonry/
using chrome Version 63.0.3239.84 (Official Build) (64-bit) and macOS Sierra

It's working now https://cedricdelpoux.github.io/react-responsive-masonry/. Scroll to see the responsive masonry


Raise NegativeArraySizeException with requiring huge memory size when reading a specific record in a query on s390x Linux

OrientDB Version: 3.1.15 / 3.1.20
Java Version: OpenJDK Runtime Environment (Red_Hat-<IP_ADDRESS>.8-2.el8_6) (build 11.0.17+8-LTS)
OS: Linux version 4.18.0-425.19.2.el8_7.s390x<EMAIL_ADDRESS>(gcc version 8.5.0 20210514 (Red Hat 8.5.0-16) (GCC))
Expected behavior
Returns the desired result when using a unique index in the docker both on x86 Linux and s390x Linux.
Actual behavior
In the docker on the S390X Linux, when a query SQL goes through the unique index, raises java.lang.NegativeArraySizeException: -2057971028 and the log shows the record size=1677747200 bytes which is wrong.
But the same operation runs OK in the docker on the x86 Linux.
Here is the log during query:
2023-04-21 05:58:29:670 FINE  {db=Demo} Read record #52:2 v.2 size=1677747200 bytes [OLocalPaginatedStorage]
2023-04-21 05:58:29:671 WARNI {db=Demo} Invalid type index: 97 [OType]
2023-04-21 05:58:29:679 FINE  {db=Demo} Sent run-time exception to the client /<IP_ADDRESS>:49358: java.lang.NegativeArraySizeException: -2057971028 [ONetworkProtocolBinary]
2023-04-21 05:58:29:682 FINE  {db=Demo} Request id:1 type:5 [ONetworkProtocolBinary]
2023-04-21 05:58:29:682 FINE  {db=Demo} Disconnecting connection OClientConnection [id=1, source=/<IP_ADDRESS>:49358, since=1682056707935]... [OClientConnectionManager]
2023-04-21 05:58:29:682 FINE  {db=Demo} onClose [OLuceneIndexFactory]
2023-04-21 05:58:29:682 FINE  Disconnected connection OClientConnection [id=1, source=/<IP_ADDRESS>:49358, since=1682056707935] found 1 channels [OClientConnectionManager]

Here is the log for writing data on #52:2 :
2023-04-21 08:12:17:890 FINE  {db=Demo} 34 Committed transaction 95 on database 'Demo' (result=[ORecordOperation [record=Program#52:2{id:******,source:***,date:2022-01-04T03:08:50Z,label:******,name:***,description:null,group:null,****,language:null,displayName:***,type:***} v1, type=CREATE]]) [OLocalPaginatedStorage]

At the same time, when we try to use the condition 'id = "*****"' to execute a query on the native UI or in the console mode, both failed.
Steps to reproduce
In the docker on the s390x Linux.
<1> Raise Exception

We load 26 data file, less than 10MB, into the OrientDB 3.1.15.
We execute a query using the tinkergraph-gremlin with parameters direction=both&&depth=3, most of those data should be returned. But it is failed during reading the #52:2, there are 3778 pieces of data of the same type.
We  execute a query on the native UI or inner the console mode using the SQL statement select * from program where @RID="#52:2", both are failed.

The detail log shows above.
<2> Runs OK
For the sake of data confidentiality, we cannot provide specific test data, so we try to minimize the scope for error data.

We just load only 1 data file, which is related to the previous #52:2
The data is stored on the same position #52:2
It runs OK using the SQL statement select * from program where @RID="#52:2".

Hi,
This is a bit strange also because seems architecture dependent, what kind of index are you using for this data ? also looking at the log I see Invalid type index: 97 [OType] for that kind of index type we have just up to 23 so there is clearly something wrong.
As far as I understood all the operations and the creation of the database is done on the same "machine" with the same architecture, do you confirm ?!
Also is the client application using similar CPU architecture ?
The architecture itself should not have an impact on the logic in the way the data is stored, OrientDB databases should be portable across architectures.
The specific error "NegativeArraySizeException"  should have been sent to the client application, so you should be able to locate it, in the application log, and find the full stack trace, that would be really useful to pin-point where the error come from.
At last, we do have more recent version of the 3.1.x series released (as time of writing 3.1.20) also the 3.2.x version is available, consider to check a more recent version as well, this may be already solved.
Bye

What kind of index? I don't have idea about it, can you give me more hints?
Let me make some more clarification about our test environment：

we have two machine, one x86 Linux and one s390x Linux
we package an all-in-one image including PostgreSQL, OrientDB and our application
the PostgreSQL and OrientDB use different image for different architecture, but our application is same, it's Java application
we use the same test data and perform the same operation

And here is more information about what we have tried:

we have tried the OrientDB 3.1.20 on the s390x Linux, it's same to 3.1.15
we have tried the IBM JDK, it's same the OpenJDK
Assume the data stored on #52:2 is program A, we have checked that it only has 1 edge. So we have tried to reload those data without the program A and its edge. After trying the same operation, another error raises, but the error can only be seen in our application's log

java.lang.IllegalStateException: The property does not exist as the key has no associated value for the provided element: v[#50:3]:id
	at org.apache.tinkerpop.gremlin.structure.Property$Exceptions.propertyDoesNotExist(Property.java:155) ~[gremlin-core-3.4.6.jar:3.4.6]
	at org.apache.tinkerpop.gremlin.structure.Element.lambda$value$1(Element.java:94) ~[gremlin-core-3.4.6.jar:3.4.6]
	at org.apache.tinkerpop.gremlin.structure.Property.orElseThrow(Property.java:101) ~[gremlin-core-3.4.6.jar:3.4.6]
	at org.apache.tinkerpop.gremlin.structure.Element.value(Element.java:94) ~[gremlin-core-3.4.6.jar:3.4.6]

What we can see in the OrientDB's log seems that the client disconnect the connectioin
2023-04-24 08:55:02:398 FINE  {db=Demo} Read record #34:0 v.2 size=176 bytes [OLocalPaginatedStorage]
2023-04-24 08:55:02:418 FINE  {db=Demo} Request id:10 type:5 [ONetworkProtocolBinary]
2023-04-24 08:55:02:418 FINE  {db=Demo} Disconnecting connection OClientConnection [id=10, source=/<IP_ADDRESS>:43630, since=1682326500922]... [OClientConnectionManager]
2023-04-24 08:55:02:419 FINE  {db=Demo} onClose [OLuceneIndexFactory]
2023-04-24 08:55:02:419 FINE  Disconnected connection OClientConnection [id=10, source=/<IP_ADDRESS>:43630, since=1682326500922] found 1 channels [OClientConnectionManager]

Hope this information helps

It also appears on 3.2.20.

Hi,
This problem seems due to some serialization alignment, do you have any instructions to run tests on this architecture? or if you can you could run yourself a mvn clean install of this project on that environment and see if there are any failing tests.
Maybe is even possible to run the CI on this architecture if it's available as docker image that can be used from github actions.
We should be agnostic from the architecture, so this is for sure a bug.
Regards

I'm sure that we run the mvn clean install and docker build on the same s390x Linux machine.

Hi,
Just check our Dockerfile, we download the tar file from the orientdb-community, then extract the orientdb and set bin PATH.
The DOWNLOAD_URL is https://repo1.maven.org/maven2/com/orientechnologies}/orientdb-community/$ORIENTDB_VERSION/orientdb-community-$ORIENTDB_VERSION.tar.gz

@tglman I work with @kxc1573 . This zLinux issue -- as well as the other one @kxc1573 reported -- are a major pain point for some of our customers.
When I pull the latest release code (3.2.26) and run mvn clean test on a zLinux system, I get failures in the OrientDB Tests bucket that look very similar to the issue reported here.
I am attaching the build output and the test report files here.
OrientDB-3.2.26_on_zLinux.tar.gz
Can you provide us with an outlook for when these issues might be fixed?
What other information / resources do you need from us to be able to proceed?

Hi,
This should be fixed from 3.2.30, could you try again and check?
Regards

Yes, I know it.
We will have a new release soon, which will include OrientDB 3.2.30. I will close it after the integration testing is completed.

Hi @kxc1573,
Can we consider this closed ?


fix(build): update dependencies

:tada: This PR is included in version 0.20.3 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Include Xcodeproj files in initial Flutter app template

When we generate a new Flutter app in our tools, we could also generate all the necessary Xcodeproj files. This could help our new Flutter devs get started on iOS easier/faster.

cc @chinmaygarde

We might have both filed the same bug? https://github.com/flutter/flutter/issues/391

Dupe of #391. Closing.


[FLINK-4458] Replace ForkableFlinkMiniCluster by LocalFlinkMiniCluster

This PR is based on #2449. Thus, only the commits 5a2c70f and e07ad44 are relevant.
The PR refactors the LocalFlinkMiniCluster and the TestingCluster so that they can replace the ForkableFlinkMiniCluster. The LocalFlinkMiniCluster now starts all distributed components under a random port. This is possible with #2449.
The difference of the TestingCluster compared to the LocalFlinkMiniCluster is that it starts the testing components (e.g. TestingJobManager, TestingTaskManager, etc.) instead of the plain ones. It also allows to start the JobManager in a synchronous mode. Furthermore, it offers some operations like restarting the leading JobManager under the same port.

I think these changes are good.
As a very personal and biased statement: I think the code overdoes it a bit with the "every parameter on a new line" policy. We have beautiful wide screens and I get sore fingers from scrolling up and down again to figure out enough context of a code passage ;-)
Also, the style breaks the "visual" separation between different parts of statement, like "members of a return tuple" vs. "function parameters", or "clauses of an if statement" and "body of the if statement". I know the idea of that pattern was to improve code readability, but I am getting the feeling this is approaching a "verschlimmbesserung" (an improvement that makes things worse).

Thanks for the review @StephanEwen.
I agree that we've different style preferences concerning method parameters. I also agree that the one parameter per line is a little bit more verbose and requires more vertical scrolling. The best approach would probably be to reduce the number of method parameters by grouping them.

Will rebase on the latest master and #2449 to run the travis tests again.

Builds are passing on Travis (own repository). Would like to merge this PR if there are no objections.

Quick question: The ForkableFlinkMiniCluster was something semi-public, in the sense that it was part of the flink-test-utils project and used by quite a few users. So this would be a breaking change.

Yes that is true. However, the flink-test-utils have not been guaranteed to be stable if I'm not mistaken. The changes one has to apply is to replace the ForkableFlinkMiniCluster with the LocalFlinkMiniCluster.

I will re-introduce the ForkableFlinkMiniCluster which is simply extending the LocalFlinkMiniCluster.

I've re-introduced the ForkableFlinkMiniCluster. However, this time it only starts the normal distributed component classes (e.g. JobManager instead of TestingJobManager, etc.). This implies that the testing messages are no longer supported when using the ForkableFlinkMiniCluster.
I think the user should not meddle with the testing components in the first place. Therefore, it seems to be fair to offer the user a mini cluster to run his tests but not one which instantiates testing components. The recommended cluster is the LocalFlinkMiniCluster from now on. However, in order to not break all existing test code, we still maintain the ForkableFlinkMiniCluster.
Not having to start the testing classes allows to move them back into the test scope of flink-runtime, since they are no longer required by the flink-test-utils module.

Rebasing on the latest master and letting Travis run. If it gives green light, I will merge the PR.


embassy-net: add async wait_config_up

This PR adds a function wait_config_up to the embassy_net Stack.
It will check whether is_config_up is true and if not register a waker that is woken in apply_static_config (e.g. by DHCP).
I added a not-working example to the docstring. Not sure whether we can make this run somehow.

Updated examples are tested on STM32H743


Can't run this on 0.26 - naming collision

Hi,
I have tried it on 0.26 today and I couldn't make the "npm start" and it throws me an error as below,
Failed to build DependencyGraph: @providesModule naming collision:
Duplicate module name: ReactDOMOption
Paths: /home/sid/react/pepperoni-app-kit/node_modules/react/lib/ReactDOMOption.js collides with /home/sid/react/pepperoni-app-kit/node_modules/react-native-mock/node_modules/react/lib/ReactDOMOption.js
This error is caused by a @providesModule declaration with the same name accross two different files.
Error: @providesModule naming collision:
Duplicate module name: ReactDOMOption
Paths: /home/sid/react/pepperoni-app-kit/node_modules/react/lib/ReactDOMOption.js collides with /home/sid/react/pepperoni-app-kit/node_modules/react-native-mock/node_modules/react/lib/ReactDOMOption.js
This error is caused by a @providesModule declaration with the same name accross two different files.
at HasteMap._updateHasteMap (/home/sid/react/pepperoni-app-kit/node_modules/react-native/node_modules/node-haste/lib/DependencyGraph/HasteMap.js:160:15)
at /home/sid/react/pepperoni-app-kit/node_modules/react-native/node_modules/node-haste/lib/DependencyGraph/HasteMap.js:125:25

running npm start I had something similar today, after upgrading my project (which is base on pepperoni-app-kit) to react-native 0.27.2:
Failed to build DependencyGraph: @providesModule naming collision:
  Duplicate module name: ReactPerf
  Paths: <PROJECT_ROOT>/node_modules/react/lib/ReactPerf.js collides with <PROJECT_ROOT>/node_modules/react-native-mock/node_modules/react/lib/ReactPerf.js

This error is caused by a @providesModule declaration with the same name accross two different files.
Error: @providesModule naming collision:
  Duplicate module name: ReactPerf
  Paths: <PROJECT_ROOT>/node_modules/react/lib/ReactPerf.js collides with <PROJECT_ROOT>/node_modules/react-native-mock/node_modules/react/lib/ReactPerf.js

This error is caused by a @providesModule declaration with the same name accross two different files.
    at HasteMap._updateHasteMap (<PROJECT_ROOT>/node_modules/node-haste/lib/DependencyGraph/HasteMap.js:162:15)
    at <PROJECT_ROOT>/node_modules/node-haste/lib/DependencyGraph/HasteMap.js:127:25

I fixed it doing:
rm -fr node_modules
npm install
npm start #again

Hopefully this will fix your issue as well

I tried but no luck, it' still keep on getting stopped due to naming collision issue with react/lib, react-native-mock/node_modules/react/lib.
Failed to build DependencyGraph: @providesModule naming collision:
Duplicate module name: react
Paths: /home/sid/react/pepperoni-app-kit/node_modules/react/package.json collides with /home/sid/react/pepperoni-app-kit/node_modules/react-native-mock/node_modules/react/package.json
This error is caused by a @providesModule declaration with the same name accross two different files.
Error: @providesModule naming collision:
Duplicate module name: react
Paths: /home/sid/react/pepperoni-app-kit/node_modules/react/package.json collides with /home/sid/react/pepperoni-app-kit/node_modules/react-native-mock/node_modules/react/package.json
This error is caused by a @providesModule declaration with the same name accross two different files.
at HasteMap._updateHasteMap (/home/sid/react/pepperoni-app-kit/node_modules/react-native/node_modules/node-haste/lib/DependencyGraph/HasteMap.js:160:15)
at /home/sid/react/pepperoni-app-kit/node_modules/react-native/node_modules/node-haste/lib/DependencyGraph/HasteMap.js:138:25

could you paste dependencies from your package.json?

@fabriziomoscon, I am copying my package.json content here,
{
"name": "PepperoniAppTemplate",
"author": "Futurice",
"description": "React Native App Starter Kit for Android and iOS",
"license": "MIT",
"homepage": "http://getpepperoni.com",
"bugs": "https://github.com/futurice/pepperoni-app-kit/issues",
"repository": {
"type": "git",
"url": "https://github.com/futurice/pepperoni-app-kit"
},
"keywords": [
"React Native",
"Starter Kit",
"Bitrise",
"Redux",
"Auth0"
],
"version": "1.0.0",
"private": false,
"scripts": {
"start": "node node_modules/react-native/local-cli/cli.js start",
"bundle:ios": "node ./node_modules/react-native/local-cli/cli.js bundle --platform ios --entry-file index.ios.js --bundle-output ios/PepperoniAppTemplate/main.jsbundle --dev=false --minify --verbose",
"test": "mocha src//*.spec.js",
"test:watch": "chokidar 'src//.js' 'test/**/.js' -c 'npm test'",
"coverage": "rimraf coverage && istanbul cover --i=src//*.js _mocha -- src//*.spec.js",
"check-coverage": "istanbul check-coverage"
},
"dependencies": {
"bluebird": "^3.3.5",
"es6-symbol": "^3.0.2",
"immutable": "^3.7.6",
"lodash": "^4.11.0",
"moment": "^2.12.0",
"react": "15.0.2",
"react-dom": "15.0.2",
"react-native": "^0.26.2",
"react-native-gifted-spinner": "0.0.4",
"react-native-lock": "futurice/react-native-lock#feature/customizedTheme",
"react-redux": "^4.4.5",
"redux": "^3.4.0",
"redux-logger": "^2.6.1",
"redux-loop": "^2.1.0",
"redux-promise": "^0.5.3",
"redux-thunk": "^2.0.1"
},
"devDependencies": {
"babel-cli": "^6.9.0",
"babel-core": "^6.9.0",
"babel-eslint": "^6.0.2",
"babel-polyfill": "^6.9.0",
"babel-preset-react-native": "^1.7.0",
"babel-preset-stage-0": "^6.5.0",
"chai": "^3.5.0",
"chokidar-cli": "^1.2.0",
"enzyme": "^2.2.0",
"eslint": "^2.8.0",
"eslint-plugin-babel": "^3.2.0",
"eslint-plugin-react": "^4.3.0",
"istanbul": "1.0.0-alpha.2",
"mocha": "^2.4.5",
"react-addons-test-utils": "15.0.2",
"react-native-mock": "^0.2.2",
"rimraf": "^2.5.2",
"sinon": "^1.17.4"
}
}

what is your npm version?

It's 2.15.1

Well, I bet that is the problem then. You should really consider upgrading to npm 3, that is a superior version which fixed many problems with v2.

Yes, I have managed to replicate this by using npm2 - the problem is that the react-native-mock component needs to define same module names as react-native itself, and this causes duplicate module entries.
I will document this in the setup guide.


Allow late binding of callbacks for views

It would be nice to be able to create View (eg Button) without specifying callback at initialization time and bind callback later. For example, I wold create the whole screen structure in ::new() of my struct and then bind specific callbacks later when the self is ready.

Thanks for the report!
Indeed, Button (and probably a few others) are missing set_callback to re-define a callback function.
You'll still need to give a callback when creating it, but it can be a dummy closure that does nothing.

f608073bf5c58ef22cc37aa4dd5c6353e55d333f includes Button::set_callback to define a new callback after the button was created.


UnitOfWork::isScheduledForDelete ignores UnitOfWork::$orphanRemovals

The UnitOfWork::isScheduledForDelete returns false for entity that will be deleted by orphan (contains in UnitOfWork::$orphanRemovals)
There is no accessors to UnitOfWork::$orphanRemovals variable

We wouldn't add accessors for UnitOfWork#$orphanRemovals anyway.
Could you check if any API is relying on Doctrine\ORM\UnitOfWork#isScheduledForDelete(), and can we add orphan removals to that particular API, eventually?
Also suggested: check if the Gedmo softdeleteable extension provides a way to soft-delete orphan removals (and where it is done): it may give you hints about possible workarounds

orphanRemovals are fully hidden inside onFlush events.
but it is still scheduled deletions so getScheduledEntityDeletions and isScheduledForDelete must see it.


[neeto-kb-frontend/production] TypeError: Cannot read properties of undefined (reading 'nodeType')

Backtrace
View full backtrace and more info at honeybadger.io

Ref: https://github.com/bigbinary/neeto-kb-web/issues/7359


setBindGroup is missing optional dynamicOffsets

Please, can you update webgpu-types to include third param dynamicOffsets to setBindGroup?
@kainino0x

oops, my bad. Updating

Done in v0.0.10


refactor(): cleaner support of windows filesystem

Use slash library instead of custom code.

Awesome, thanks for the pr!


Three.js example no work in main branch now

This issue suggest that the module is not loaded correctly, I am closing it for now but if you have a small reproduction, I will reopen it immediately.

The current main branch can reproduce this problem. I see similar problems in the issue.


In o'clock hours calendar operations doesn't show minutes in calendar view

Hi.
Using Calendar operations if I create an entry with  o'clock hour in the from field, for example 10:00, in calendar doesn't show the minutes, only the hour.
an example of two entries, one at 10:00 and another at 10:01

I think it should always show the time in the same format "h:i" instead

By the way, this new calendar feature has saved me many hours of work, thank you!

Hello @miquelangeld
You should be able to configure that using slotLabelFormat property: https://fullcalendar.io/docs/slotLabelFormat
You should be able to change that configuration using: CRUD::setOperationSetting('javascript-configuration', []);
Let me know if that helps.
Cheers

Hello @pxpm thanks!!   sorry I should have read the documentation more carefully.
I think  slotLabelFormat   only affect  the slots in the day view:

I have achieved it with this configuration:
CRUD::setOperationSetting('javascript-configuration', [
            'views' => [
                'dayGridMonth' => [
                    'eventTimeFormat' => [
                        'hour' => 'numeric',
                        'minute' => '2-digit'
                    ]
                ]
            ]
        ]);

I close the issue


Smart contracts functions with return values

Is there a way of modeling contract functions with return values in the configuration? I did not see this mentioned in the docs anywhere and all the samples don't have return values in the contract functions.

There is not at this time. The model for workbench is to deliver state back to properties that are exposed within the contract when you want to display them in the UX.
If you want to use functions with returns outside of the UI - intra-contract or contract-contract , don't include them in the config and they should work fine.


update wget command to not cache files

added --no-cache to wget command

This is unnecessary as there are only a small windows of time where there might be a cached version of the script.


ShellMate crashes when using Warp

I use Warp and it causes ShellMate to crash.
I already uninstalled ShellMate but get this error when opening a terminal window:
Unable to find application named 'ShellMate'
How do I get rid of that error?
Thanks.

Hey @pmcarrion
To fix your 'Unable to find application named "ShellMate"' message error, you can follow these steps:
Option 1: Uncheck the 'Auto-open' ShellMate option from the settings page (note: you'll need to reinstall the app to do this).

Option 2: Manually fix this by accessing the ~/.zshrc file if you're using zsh, or ~/.bashrc if you're using bash. Remove the line that says open -a ShellMate from the file, and this should resolve your issue.
Let me know if you encounter any other problems.


node-jx to 0.0.2

Promote node-jx to version 0.0.2

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approvers:
If they are not already assigned, you can assign the PR to them by writing /assign  in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@abd6982: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

promotion-build
5ee0228e537b84c9a2fc8d57c1970971db91210e
link
/test this

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


Suggestion for USB plugin

Hi I use the graphics and audio plugins which are excellent but USB is still a pain point for me so I have a suggestion for a USB plugin which could really help people. For example, my hack would crash on sleep until I limited to 14 ports with a SSDT, which I generated with a script I found on GitHub however it isn't supported and has a bug with 13 instead of 14 ports being enabled so missing 1. Also running the script again requires making a decision about every port rather than just making a change, requiring cross-referencing every port ID with my notes.
A USB kext plugin could be packaged as an installer pkg. When ran it could scan ioreg for USB ports and then writes them to clover/kexts/others/USBPorts.plist with an array and a bool for each one for on or off. By default the first 14 Ports are on. Each port would also have a description field which the user can edit to  a note to identify the port like lower left USB 3. And it also installed the USBPorts.kext to the same dir. So now to change the ports that are enabled, say I move a device from one internal usb header to another, it's just a case of editing the plist and rebooting. The design of the kext is to check the plist for the port config and only enable the ones that are marked on, up to a limit of 14.
Maybe also we can share the USBPorts plist for each motherboard so the users can get a config plist with the description fields pre-filled to help them with quickly enabling the ports they want. The model of motherboard will be a top level item in the plist. These could all be bundled with the installer and then the user could choose their board from a list, unless there is an ID that could be used to automatically identify it.
What do you think?

Hi,
The actual problem with usb is that limit of 14 ports, which is quite artificial. Unfortunately you cannot patch it with Lilu due to the time XHC kext loads, so you either have to write a plist-only kext with specific ports to use or perform binary patching to increase the limit.
Without making a patch that unlocks all the ports you cannot really determine which ports need to be used, and thus you cannot really automate this project. In fact in most cases you even have to manually try each port. Due to a large amount of motherboards and different revisions of each motherboard a database would also not work well enough.
Even though your intentions might be nice in theory in practice it is not really doable. Sorry.


Allow web install over prior version

This PR lets users install updates to the Allsky website via ~/allsky/website/install.sh.  It saves their timelapse, keograms, startrails, and configuration files, then restores them after the update.

@EricClaeys: I'm sorry but I can't review/test this. I haven't done anything with this part yet


[Interop] Rebuild dart image

The last time it was rebuilt, the base image (dart:stable) seems not to have been updated. grpc-dart is now requiring newer dart version and is currently failing: https://github.com/grpc/grpc-dart/issues/705

Copybara didn't actually commit the full changes from this PR. Created https://github.com/grpc/grpc/pull/36562 to fix it.


Add a new 'dpi' field to include the printer's DPI resolution

Greetings!
We are adding some new features to the python-escpos library that makes use of this great escpos-printer-db capabilities database.
One of this new features will be the ability to match the sizes of hardware and software-generated bar-codes by rendering bar-code images of the same resolution as the printer's native resolution, but in order to make the appropriate calculations we previously need to know the printer’s DPI value that varies between the different models.
Our request is that a new field named dpi would be added into the media group of the profiles to include the DPI resolution of the listed printers so this information can be fetched by any client.
The idea is that the default.yml profile would contain the inheritable media: dpi: Unknown items, so that each profile can be overloaded with the right value when known.
I’d be glad to start a PR with the necessary changes, as soon as I have the time, if you agree with this proposal.
Thanks in advance.

@mike42 What do you think about this? As far as @belono has described it, the value could be guessed from media sizes, but this is not very reliable since the printable area varies from printer to printer. An actual dpi value would help with this change (but in the end also with other changes where you try to scale something to a certain size)


Bring custom Wagtail admin templates up to date with v1.7

We have a number of Wagtail admin templates that have been overridden (at cfgov/templates/wagtailadmin) to support things like page sharing and disabling the ability to delete pages.
These templates haven't been kept up to date as we've upgraded Wagtail, and so are lacking some useful features that we'd otherwise have. This PR brings them up to date with Wagtail 1.7.
See below for screenshots and descriptions of the new features this exposes.
Additions

Added new custom template at wagtailadmin/pages/listing/_button_with_dropdown.html to achieve hiding of the delete button in the explorer view.

Removals

Removed custom wagtailadmin/home.html template in favor of just using the built-in settings.WAGTAIL_SITE_NAME.
Removed custom wagtailadmin/pages/listing/_page_title_explore.html, wagtailadmin/pages/listing/_parent_page_title_explore.html, and wagtailadmin/shared/main_nav.html templates in favor of Python code.

Changes

Minor change to .gitignore to properly ignore certain root directories instead of any directory with the name images or documents.
Moved custom template logic for the Django admin link and the unshare button in the explorer into the register_admin_menu_item and register_page_listing_more_buttons Wagtail hooks, respectively.

Testing

Explore Wagtail with a production data dump and try out the various new features.

Screenshots
The landing page header banner is slightly different due to a code simplification:

(The sidebar also appears slightly differently, with a collapsible settings/logout section.)
The Wagtail editor will now warn you if you navigate away from a page with unsaved changes, whether creating a new page or editing an existing one:

You can now see a link to revisions on the right side of the footer when editing a page:

There's now a dropdown menu in the page explorer view that includes a link to see all revisions (and also hides "delete" and shows "unpublish" and "unshare" when appropriate):

You can now review a list of page revisions including who created them and when, and preview or review each one:

You can now also restore old revisions, either as a new current draft or directly by sharing or publishing them:

Checklist

[X] Changes are limited to a single goal (no scope creep)
[X] Code can be automatically merged (no conflicts)
[X] Passes all existing automated tests
[X] Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)
[X] Reviewers requested with the Assignee tool :arrow_right:

Getting a 'Page' object has no attribute 'shared' error on:
Users/bellamys/.virtualenvs/cfgov-refresh/lib/python2.7/site-packages/wagtail/wagtailadmin/templates/wagtailadmin/pages/listing/_buttons.html

Thanks @sebworks, that error should be fixed in 4318f83.

@chosak, got another error:  'bool' object has no attribute 'widget'
wagtail/wagtailadmin/templates/wagtailadmin/block_forms/stream_member.html, error at line 10

Actually, I get this error when running tox on this branch --
  File "../.tox/py27/bin/coverage", line 11, in <module>
    sys.exit(main())
  File "/Users/agarwalr/apps/cfgov-refresh/.tox/py27/lib/python2.7/site-packages/coverage/cmdline.py", line 753, in main
    status = CoverageScript().command_line(argv)
  File "/Users/agarwalr/apps/cfgov-refresh/.tox/py27/lib/python2.7/site-packages/coverage/cmdline.py", line 469, in command_line
    concurrency=options.concurrency,
  File "/Users/agarwalr/apps/cfgov-refresh/.tox/py27/lib/python2.7/site-packages/coverage/control.py", line 141, in __init__
    did_read_rc = self.config.from_file(config_file)
  File "/Users/agarwalr/apps/cfgov-refresh/.tox/py27/lib/python2.7/site-packages/coverage/config.py", line 217, in from_file
    files_read = cp.read(filename)
  File "/Users/agarwalr/apps/cfgov-refresh/.tox/py27/lib/python2.7/site-packages/coverage/config.py", line 29, in read
    return configparser.RawConfigParser.read(self, filename, **kwargs)
  File "/Users/agarwalr/apps/cfgov-refresh/.tox/py27/lib/python2.7/site-packages/backports/configparser/__init__.py", line 704, in read
    with open(filename, encoding=encoding) as fp:
LookupError: unknown encoding:
ERROR: InvocationError: '/Users/agarwalr/apps/cfgov-refresh/.tox/py27/bin/coverage erase'

Nevermind, apparently I get that on master too.

@richaagarwal and for future reference, a workaround for that error is to add
export LANG=en_US.UTF-8

to your ~/.bashrc file (thanks @higs4281 for figuring this out). I'm not sure exactly what/how that fixes the issue (something to do with the file encoding) but it got tests working locally for me.


Usage of ndims(mesh) at many avoidable places

We often dispatch functions based on the spatial dimensionality of the mesh, see for instance
https://github.com/trixi-framework/Trixi.jl/blob/288d41d61fa357df6fa10dbfe1db514f6be6a59b/src/callbacks_stage/positivity_zhang_shu_dg1d.jl#L8-L9
Nevetheless, in these functions the dimensionality of the mesh is still often queried:
https://github.com/trixi-framework/Trixi.jl/blob/288d41d61fa357df6fa10dbfe1db514f6be6a59b/src/callbacks_stage/positivity_zhang_shu_dg1d.jl#L30
While the overhead for this is hopefully negligible due to optimizations, this is (in my opinion) bad style, as this code suggests some variability in the method which is not there.

It should be compiled away since it just returns a compile-time constant. In the specific case you mentioned, it makes it much clearer how the magic numbers appear there. For example, it would be hard for me to see how to generalize it if I just saw  / 4 in the 2D case.
Having said that, it would be great if you could make some concrete suggestions on how to clarify and improve the code.

I would suggest to put the dimensionality right there and leave the usage of this function for the places where the mesh is actually generic.
If this leads to confusion, one could think about adding comments (in the example above, there is for instance already a comment explaining the 2.)

See discussion in #2081


Pack musl-wrapper into musl-toolchain

Solve the version dependency problem of musl-toolchain and musl-wrapper

@DubbleClick Sorry to bother you, but if you have time, I recently encountered some situations when solving this issue.
I saw that gcc has a major version update, and musl-libc has also been upgraded by a version. Do we need to upgrade musl-toolchain to the latest?
Currently I try to build musl-toolchain based on gcc-14 and musl-1.2.5 locally, but segmentation faults will occur when using them to compile php and intl extensions, while the current old version will not, and I haven't researched why yet.

Do we need to upgrade musl-toolchain to the latest?

I think we should. I won't be around to take a look at it until I'm back from vacation in two weeks though. I'll set myself a reminder to figure things out.

Currently I try to build musl-toolchain based on gcc-14 and musl-1.2.5 locally, but segmentation faults will occur when using them to compile php and intl extensions, while the current old version will not

Yeeeeah, I ran into that issue before. I believe I created an issue in the php-src repository and there was some progress. PHP plans to make musl-libc a first class citizen in the future too, worst case we will have to wait with a toolchain upgrade until some more if these issues are ironed out.

Edit: https://github.com/php/php-src/issues/13877#issuecomment-2315701771
It's only for php 8.4+


Managed resource handling

tested on euphoria streaming server (resolved file resources)

Codecov Report

Merging #64 into master will decrease coverage by 0.83%.
The diff coverage is 54.42%.

@@             Coverage Diff              @@
##             master      #64      +/-   ##
============================================
- Coverage     50.91%   50.08%   -0.84%
+ Complexity      236      230       -6
============================================
  Files            51       50       -1
  Lines          1206     1230      +24
  Branches        135      137       +2
============================================
+ Hits            614      616       +2
- Misses          534      561      +27
+ Partials         58       53       -5

Impacted Files
Coverage Δ
Complexity Δ

...s/commons/file/config/SpringConfigCommonsFile.java
100% <ø> (ø)
1 <0> (-1)
:arrow_down:

...commons/file/business/api/FileResourceService.java
0% <0%> (ø)
0 <0> (ø)
:arrow_down:

...mmons/file/backend/api/FileResourceRepository.java
0% <0%> (-75%)
0 <0> (-2)

...l/managed/ManagedFileResourceRepositoryConfig.java
100% <100%> (ø)
5 <5> (?)

...resolved/ResolvedFileResourceRepositoryConfig.java
100% <100%> (ø)
3 <3> (?)

...impl/resolved/ResolvedFileResourceServiceImpl.java
30.76% <30.76%> (ø)
2 <2> (?)

.../file/backend/impl/FileResourceRepositoryImpl.java
34.61% <38.88%> (-15.98%)
9 <2> (-21)

...mpl/managed/ManagedFileResourceRepositoryImpl.java
41.11% <41.11%> (ø)
8 <8> (?)

...s/impl/managed/ManagedFileResourceServiceImpl.java
44.44% <44.44%> (ø)
2 <2> (?)

...l/resolved/ResolvedFileResourceRepositoryImpl.java
67.39% <67.39%> (ø)
20 <20> (?)

... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dba8786...38f652b. Read the comment docs.


Regenerate generated API.

Generated based on:
https://github.com/TileDB-Inc/TileDB-Cloud-API-Spec/tree/0b3e487c419e2f3cc2da4d53c6e51b3e2ed5fb76

@thetorpedodog where is the story for this?