Service Mesh Sidecar Proxy

Not an issue, just a question...
Say RabbitMQ server and clients are running in separate containers in a Kubernetes environment with a service mesh/sidecar proxies.
First, would this library work in this situation?
If yes...
Which sidecar proxy has been most commonly used?
How would the connection to server work?
How would it work if libevent is used for all the I/O?

I don't understand your question.
The AMQP-CPP library just speaks the AMQP protocol. If there is a RabbitMQ server at the other end of the connection, it works. And the network architecture that lies underneath it, is, as far as I see, further not relevant. Whether a program runs in Kubernetes or Docker, LXC or on bare metal or whatever, or whether there are routers or IP tables or TCP tunnels or whatever else in between, is for AMQP-CPP not responsibility or a concern.


⚠ Bofrost.be has degraded performance

In bff5c59, Bofrost.be (https://www.bofrost.be) experienced degraded performance:

HTTP code: 200
Response time: 2059 ms

Resolved: Bofrost.be performance has improved in 7a25d7b after 6 minutes.


[add] http proxy

➜  tcping git:(master) go run . -h
tcping is a ping over tcp connection

Usage:
  tcping host port [flags]

Examples:

  1. ping over tcp
        > tcping google.com
  2. ping over tcp with custom port
        > tcping google.com 443
  3. ping over http
        > tcping -H google.com
  4. ping with URI schema
        > tcping http://hui.lu

Flags:
  -c, --counter int              ping counter (default 4)
  -D, --dns-server stringArray   Use the specified dns resolve server.
      --head                     Use HEAD instead of GET in http mode.
  -h, --help                     help for tcping
  -H, --http                     Use "HTTP" mode. will ignore URI Schema, force to http
  -I, --interval string          ping interval, units are "ns", "us" (or "µs"), "ms", "s", "m", "h" (default "1s")
      --post                     Use POST instead of GET in http mode.
      --proxy string             Use HTTP proxy
  -T, --timeout string           connect timeout, units are "ns", "us" (or "µs"), "ms", "s", "m", "h" (default "1s")
      --user-agent string        Use custom UA in http mode. (default "tcping")
  -v, --version                  show the version and exit

http proxy
➜  tcping git:(master) ✗ go run . https://www.google.com
Ping https://www.google.com:443 - failed: Get "https://www.google.com:443": context deadline exceeded (Client.Timeout exceeded while awaiting headers)
Ping https://www.google.com:443 - failed: Get "https://www.google.com:443": context deadline exceeded (Client.Timeout exceeded while awaiting headers)
Ping https://www.google.com:443 - failed: Get "https://www.google.com:443": context deadline exceeded (Client.Timeout exceeded while awaiting headers)
Ping https://www.google.com:443 - failed: Get "https://www.google.com:443": context deadline exceeded (Client.Timeout exceeded while awaiting headers)

Ping statistics https://www.google.com:443
        4 probes sent.
        0 successful, 4 failed.
Approximate trip times:
        Minimum = 0s, Maximum = 0s, Average = 0s

➜  tcping git:(master) ✗ go run . https://www.google.com --proxy http://<IP_ADDRESS>:7890
Ping https://www.google.com:443(<IP_ADDRESS>:7890) - https is open - time=513.324ms method=GET status=200 bytes=14132
Ping https://www.google.com:443(<IP_ADDRESS>:7890) - https is open - time=383.545ms method=GET status=200 bytes=14178
Ping https://www.google.com:443(<IP_ADDRESS>:7890) - https is open - time=456.555ms method=GET status=200 bytes=14128
Ping https://www.google.com:443(<IP_ADDRESS>:7890) - https is open - time=377.08ms method=GET status=200 bytes=14160

Ping statistics https://www.google.com:443
        4 probes sent.
        4 successful, 0 failed.
Approximate trip times:
        Minimum = 377.08ms, Maximum = 513.324ms, Average = 432.626ms

socks5 proxy
go run . https://www.google.com:443 --http-proxy socks5://<IP_ADDRESS>:7890
Ping https://www.google.com:443(<IP_ADDRESS>:7890) - https is open - time=634.114ms method=GET status=200 bytes=14196
Ping https://www.google.com:443(<IP_ADDRESS>:7890) - https is open - time=889.359ms method=GET status=200 bytes=14104
Ping https://www.google.com:443(<IP_ADDRESS>:7890) - https is open - time=393.565ms method=GET status=200 bytes=14191
Ping https://www.google.com:443(<IP_ADDRESS>:7890) - https is open - time=393.004ms method=GET status=200 bytes=14165

Ping statistics https://www.google.com:443
        4 probes sent.
        4 successful, 0 failed.
Approximate trip times:
        Minimum = 393.004ms, Maximum = 889.359ms, Average = 577.5105ms

看起来代码与描述的不符合，至支持了 http proxy，没有支持 socks5

注意看 example.2，是支持了socks5 的

是我疏忽了，把go的http_proxy参数当成了自己的

 ./tcping --proxy socks5://<IP_ADDRESS>:7890 https://google.com
Ping https://google.com:443(<IP_ADDRESS>:7890) - https is open - time=888.447ms method=GET status=200 bytes=15233
Ping https://google.com:443(<IP_ADDRESS>:7890) - https is open - time=736.187ms method=GET status=200 bytes=15282
Ping https://google.com:443(<IP_ADDRESS>:7890) - https is open - time=769.856ms method=GET status=200 bytes=15290
Ping https://google.com:443(<IP_ADDRESS>:7890) - https is open - time=733.187ms method=GET status=200 bytes=15246

Ping statistics https://google.com:443
        4 probes sent.
        4 successful, 0 failed.
Approximate trip times:
        Minimum = 733.187ms, Maximum = 888.447ms, Average = 781.91925ms

我不这么认为


Breakpoint with stackframe should use debugStackframeDot

Followup from https://github.com/microsoft/vscode/issues/208343
The icons for a breakpoint with stackframe is debug-stackframe-dot.
Currently, the code uses circleSmallFilled. On codicons that's the same icon, on other product icon theme that could be a separate icon.

To verify:

download
product-icon-theme-sample-0.1.0.vsix.zip, rename .vsix.zip to .vsix
install, switch to the Product icon theme VS Code 1.0 icons
create a python program

for i in range(5):
    print("Hello World!")

set breakpoint at hello world

run to the breakpoint

the breakpoint icon should turn into a smiley

fyi @connor4312


xfoil_module not found

Hi Leal,
I recently installed aeropy to use with a problem I've been trying to solve, but I've run into a problem. Every time I try to call the xfoil_module, python states it doesn't exist, like so:
>>> from aeropy.xfoil_module import find_coefficients Traceback (most recent call last):   File "<stdin>", line 1, in <module> ModuleNotFoundError: No module named 'aeropy.xfoil_module'
I'm not sure if the problem is trivial and I'm missing something obvious, but I would really appreciate some help on the matter.
Thank you,
Azam

Never mind, I figured out the problem

Hi @ABham2997! Having the same problem over here, haven't yet been able to find out how to solve it... would you mind sharing how you did it?

Hi @AzamBham
As I'm experiencing the same issue, I am curious as to how you solved this issue.

@ckanaar this should be indicative that you didn't install the library properly. Did you follow the instructions on the project description and installed the library via 'pip install .'?

Same issue here, I first installed through anaconda with pip install. Then I uninstalled and re-installed following the project description but I'm still getting the same error.
If anyone know's how to fix this, I'd appreciate the advice.

@NasonZ This seems to be a problem not specific to Aeropy (see here), but from having anaconda or multiple Python versions on the same computer.
I just installed the library utilizing the vanilla version of Python 3.6 (as provided on the Python website) and I can import it. Perhaps you need to start from scratch (no Python libraries installed).


PR is no longer created on copy (at least within 10 minutes)

Previously created multiple repositories from fastpages template and something changed.
Now when I follow step 1
"Generate a copy of this repo by clicking on this link. Name your repo anything you like except {your-username}.github.io."
Step 2
"GitHub Actions will automatically open a PR on your new repository ~ 30 seconds after the copy is created. Follow the instructions in that PR to continue."
either does not happen or takes way longer (10 minutes passed).
I tried with both "copy all branches" (which I don't think is needed) just in case; same result.
see for example:
https://github.com/h17/fastpages-test

Please refresh your browser. the PR was opened https://github.com/h17/fastpages-test/pull/1


[UT] Fix unit-test cases in 3.0

What is the purpose of the change
Fix test cases in the following modules :

dubbo-qos
dubbo-metadata-api
dubbo-config-api
dubbo-rpc-*
dubbo-registry-api

Fix some bugs :

invalid filter for consumer in rpc interface refer ( make remote rpc context fetch available )
unused import in dubbo-rpc-triple
add asf license header in dubbo-rpc-triple

Codecov Report

:exclamation: No coverage uploaded for pull request base (3.0@c132438). Click here to learn what that means.
The diff coverage is n/a.

@@          Coverage Diff           @@
##             3.0    #7175   +/-   ##
======================================
  Coverage       ?   57.39%
  Complexity     ?      357
======================================
  Files          ?      983
  Lines          ?    40081
  Branches       ?     5982
======================================
  Hits           ?    23004
  Misses         ?    14395
  Partials       ?     2682

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c132438...82dac7b. Read the comment docs.


GH-498 Improve NodePath dialogs for nodes and properties

Fixes #498

Applied to main (=2.1) and branch 2.0.


[vcpkg] Improve bootstrap detection of VS2015 version

https://github.com/Azure/azure-batch-software-entitlement/blob/fbac30d55bf8c3cef48dad87d0ee3da55a5b3519/docs/build-guide.md#troubleshooting
We should detect the VS2015 version during bootstrap and notify the user that they need at least Update 3.

This issue hasn’t been updated in a year, if it is still an issue, please reopen.


"Minimize hotbar" option shifts UI up

FVTT Build 315 Version 11 Stable
Pf2e: 5.13.6
Dorako UX: 1.3.2
Steps to reproduce:

Go to any tab.
Click on "Chat Messages" tab.

Also, have the "Minimize hotbar" option enabled.

I've removed the code for this feature, might bring it back at some point, but there's enough stuff that happens related to hotbars that it might not be worthwhile.


Adding README and Contribution Guidelines

Hey, i just saw your old bfxr Project and thought: This would be a great fit for a WebApp when i immediately saw, that you are actually working on one 😄 .
Are you accepting PRs, Issues / Issue Comments, etc, or is this Repo more private and right now just for testing and playing around?
If it already is open for contributions, i would recommend to add a README (maybe after the real initial structure of the project has been found -> React, Vue, Svelte, VanillaJS, Electron or whatever Stack you want to use) and some contribution guidelines, editorconfig, prettier configuration for formatting, etc.

Hey, yeah thanks for your comments. It's super early on still (right now stagnating a bit), not really fit for third-party contributions just now 😅

Yeah ofcourse, i'll wait then haha 😄. Hope my comments still help you in your decisions :).


Show progress of endpoint action

From @richard-cox on December 11, 2017 15:24
When we're connected/disconnecting/deleting an endpoint show a progress icon in the endpoint's 'status' section.
We should also show the same spinner when we're updating all cnsis.. store.select(cnsisStatusSelector).map((cnsis => cnsis.loading))
Copied from original issue: SUSE/stratos#70

@KlapTrap I think this is done?

Done


Should PROJECTS_ROOT and PROJECT_SOURCE be reserved environment variables?

There's a couple environment variables that the devfile spec defines:

$PROJECTS_ROOT: A path where projects sources are mounted
$PROJECT_SOURCE: A path to a project source, including the project root (${PROJECTS_ROOT}/<project-name>)

It's assumed that these environment variables will be set to the proper values and available in the containers defined in a devfile.
In addition to the sourceMapping field, odo currently allows the projects root to be changed by overriding the PROJECTS_ROOT environment variable in the container spec, e.g.:
components:
- name: runtime
  container:
    image: quay.io/eclipse/che-java11-maven:nightly
    memoryLimit: 768Mi
    mountSources: true
    sourceMapping: /test
    command: ['tail']
    args: [ '-f', '/dev/null']
    env:
    - name: PROJECTS_ROOT
      value: /mycustom/path/

We had some discussion last week on $PROJECT_SOURCE and decided that it wasn't valid for odo to allow it to be overridden by users, as it relies on both the value of $PROJECTS_ROOT (see https://github.com/openshift/odo/issues/3781 for some discussion) and where the source code is located.
So, I guess I have a couple questions:

Should we update the devfile spec to formally not allow $PROJECT_SOURCE to be overridden in the container spec by users?
Should we do the same for $PROJECTS_ROOT too? Given that the project root can still be changed by configuring sourceMapping

It was decided we're going to explicitly mention in the devfile spec that these ENVs are going to be reserved.


AzOps - Push pipeline - deployment failed with permissions error

Describe the bug
The below error occurs with the push pipeline following the successful pull pipeline of the AzOps Accelerator run in Azure DevOps. This has only happened when there are changes to the AAD subscription. On the first occasion, all subscriptions updated successfully apart from this subscription. This change updated the location from current named region to [deployment().location].
New-AzManagementGroupDeployment: The deployment 'AzOps-microsoft.management.managementgroups-xxxxxxxxx' failed with error(s). Showing 2 out of 2 error(s). Status message: (Code:) Status Message: At least one resource deployment operations failed. Please list deployment operations for details. - (Code: DeploymentFailed)  - {  "error": {    "code": "BadRequest",   "message": "User does not have permission to view role assignments on subscription xxxxxxxxx", "details": "The current subscription type is not permitted to perform operations on any provider namespace. Please use a different subscription."
The SPN has been given privileges over the root management group and still has the directory readers role in AAD.
Apologies I am new to AzOps and logging issues in GitHub. Please could you advise if this is expected behaviour? or where this change came from? Thanks

Thank you for submitting the issue.
Can you please elaborate on what changes you are trying to push?
Also, if possible, can you share a correlationId from the failed push job?

Closing as per offline conversation.


feat: make endpointOverride configurable by DataAddress (#1903)

What this PR changes/adds
see eclipse-edc/Technology-Aws#24
Why it does that
see eclipse-edc/Technology-Aws#24
Further notes
IMHO, further refactoring for the creation of the S3Client in S3DataSourceFactory.createSource() and S3DataSinkFactory.createSink() is required.
List other areas of code that have changed but are not necessarily linked to the main feature. This could be method signature changes, package declarations, bugs that were encountered and were fixed inline, etc.
Linked Issue(s)
eclipse-edc/Technology-Aws#24
Checklist

[ ] added appropriate tests?
[ ] performed checkstyle check locally?
[ ] added/updated copyright headers?
[ ] documented public classes/methods?
[ ] added/updated relevant documentation?
[ ] assigned appropriate label? (exclude from changelog with label no-changelog)
[ ] formatted title correctly? (take a look at the CONTRIBUTING and styleguide for details)

This change does not solve the main problem.

reopening, as this may have merit

this PR should be re-created in the Technology-Aws repository, it cannot be merged here.


[Feature Request] Add Config.NewtonsoftUserSecrets

Since Config.UserSecrets is using Config.Json and Config.Json used to work with Newtonsoft.Json, is it a good idea to also have a user secrets config which is working with Newtonsoft.Json?

I would consider UserSecrets' usage of JSON to be an implementation detail. I think the only supported way to read/write from that file is using the dotnet user-secrets command line tool and using the Configuration APIs. Whether it's stored in a JSON file, a database, the Windows registry, or somewhere else, is all hidden (but not very well hidden :smile: )


MAINT: Fix doc date

Back in https://github.com/mne-tools/mne-python/pull/7532 I broke the Last updated tag at the bottom of the website, and it has read "Last updated on 2020-03-27." ever since. With this PR I now get "Last updated 01/25/2021, 11:32 AM EST" and each person should get the equivalent datetime in their own timezone.

I have a fix for this already in #8757 that just uses one line in conf.py
https://github.com/mne-tools/mne-python/pull/8757/files?file-filters[]=.py#diff-e170e9a7d787c21095c6c11bb25f0f1ff0294a42a46d45ba6fb5ed794e457624R47
and one line in _templates/layout.html
https://github.com/mne-tools/mne-python/pull/8757/files?file-filters[]=.html&hide-deleted-files=true#diff-ee53b5b8ace34aceb7fd64220d4892db846fdf385d75b096628272fb1d02da8dR44

I have a fix for this already in #8757 that just uses one line in conf.py
https://github.com/mne-tools/mne-python/pull/8757/files?file-filters[]=.py#diff-e170e9a7d787c21095c6c11bb25f0f1ff0294a42a46d45ba6fb5ed794e457624R47
and one line in _templates/layout.html
https://github.com/mne-tools/mne-python/pull/8757/files?file-filters[]=.html&hide-deleted-files=true#diff-ee53b5b8ace34aceb7fd64220d4892db846fdf385d75b096628272fb1d02da8dR44

EDIT oh, I see you're actually doing the same thing, just with a bunch of (unnecessary?) javascript to put the last updated timestamp into the user's local time zone?

Yes the difference is that the javascript localizes to both the user's time zone and their local date expression, which is to me much nicer than UTC's very long formatting in time zone that is often not the viewer's

EDIT oh, I see you're actually doing the same thing, just with a bunch of (unnecessary?) javascript to put the last updated timestamp into the user's local time zone?

Yes the difference is that the javascript localizes to both the user's time zone and their local date expression, which is to me much nicer than UTC's very long formatting in time zone that is often not the viewer's

UTC's very long formatting in time zone that is often not the viewer's

I guess the long formatting only really matters if you include the time. I think it's nice to have in there as a dev but maybe users don't need it. And I guess we could localize the date at least, but this is probably a bit overkill since the YYYY-MM-DD format is probably okay, and weird stuff like the site showing an updated-date that is ahead of your actual date should be rare. So I can just change this to be your solution for a quicker merge to master and backport if you prefer @drammock ...

UTC's very long formatting in time zone that is often not the viewer's

I guess the long formatting only really matters if you include the time. I think it's nice to have in there as a dev but maybe users don't need it. And I guess we could localize the date at least, but this is probably a bit overkill since the YYYY-MM-DD format is probably okay, and weird stuff like the site showing an updated-date that is ahead of your actual date should be rare. So I can just change this to be your solution for a quicker merge to master and backport if you prefer @drammock ...

I'm starting to see the value of having the timestamp in there, for devs.  WDYT about YYYY-MM-DD hh:mm:ss (basically follow ISO 8601 but replace T with a space) and always render time in UTC (no timezones)?

I'm starting to see the value of having the timestamp in there, for devs.  WDYT about YYYY-MM-DD hh:mm:ss (basically follow ISO 8601 but replace T with a space) and always render time in UTC (no timezones)?

Especially if it's for devs then having the timezone is useful, though. If I see some date in UTC I don't know the conversion immediately and I can never remember if it changes during the year due to daylight savings. Even if I teach myself the rules and internalize them then every dev needs to keep track of this if they want to actually know the date/time that something changed.
Another hint that this formatting is useful/standard is if you look at this commit on GitHub and mouseover the date that says "4 hours ago", for example on my machine it says "Jan 25, 2021 8:04 AM EST" not UTC. I'm assuming this is localized to each viewer.

Especially if it's for devs then having the timezone is useful, though. If I see some date in UTC I don't know the conversion immediately and I can never remember if it changes during the year due to daylight savings. Even if I teach myself the rules and internalize them then every dev needs to keep track of this if they want to actually know the date/time that something changed.
Another hint that this formatting is useful/standard is if you look at this commit on GitHub and mouseover the date that says "4 hours ago", for example on my machine it says "Jan 25, 2021 8:04 AM EST" not UTC. I'm assuming this is localized to each viewer.

... looks like on GitHub this is done with:
<relative-time datetime="2021-01-25T13:04:35Z" class="no-wrap">Jan 25, 2021</relative-time>

and after the page loads something (presumably JavaScript?) adds a title="Jan 25, 2021, 8:04 AM EST" to get this mouseover effect. So we are really doing something similar to GitHub, just actually replacing the text itself rather than adding a title.

... looks like on GitHub this is done with:
<relative-time datetime="2021-01-25T13:04:35Z" class="no-wrap">Jan 25, 2021</relative-time>

and after the page loads something (presumably JavaScript?) adds a title="Jan 25, 2021, 8:04 AM EST" to get this mouseover effect. So we are really doing something similar to GitHub, just actually replacing the text itself rather than adding a title.

Looks like GitHub uses probably {dateStyle: "medium", timeStyle: "long"} because when I use this I get the same formatting as GitHub. If you don't like this formatting you can complain to your country's standards-setting organizations :)

Looks like GitHub uses probably {dateStyle: "medium", timeStyle: "long"} because when I use this I get the same formatting as GitHub. If you don't like this formatting you can complain to your country's standards-setting organizations :)


Is anyone having the hair pulling issue of Govee device switching to Bluetooth and forgetting the wifi connection, this causes the device to be unavailable in HA

Version of the custom_component

Configuration

Add your logs here.

Describe the bug
A clear and concise description of what the bug is.
Debug log

Add your logs here.

To me, this sounds like a Govee issue, not HA.
Also, your description is fully missing.
@LaggAt provably should be closed.

Same.  Started maybe two weeks ago.  I can launch the Govee Home app on my phone, and it'll show wifi disconnected from every. single. device.
Refreshing or just waiting and it will show all devices connected to wifi again.  THEN I can run any automations or scenes.   All other smart home devices (Kasa/TPLink, Aqara, Yolink) are rock solid.
I run a mesh wifi, and often the Govee devices are within feet of the wifi nodes.

I have the same issue. Can't get Govee devices to work reliably either HA but they never have an issue with the Govee app.

I also have this problem!
Devices always offline in HA, but available by Bluetooth in the Govee App, and disconnected from my Wifi for whatever reason.
I've swapped to Kasa's new light strips for IP lights, very happy so far.

Seeing the same thing here as well - I opened an issue with Govee but not holding my breath.  But since the devices are not on WIFI my automations will not run and for space heaters that’s not good.

Same problem here. Is there any solution with your openend issue by govee @BlueThunder93 ?

Same Problem here. I can see the Govee in the WiFi and I see traffic to the cloud but in HA with the correct API key the device is not reachable.


removed extra "the" in the localization.md

Fixes #34656
Description
the extra "the" is removed by this PR.

@divya-mohan0209 Can I make different PR on this same issue?
Actually there are another issue in that same file.
__
  Summary: :question: I have a question

@bishal7679 : No. If the changes are in the same file, I'd request you to incorporate them in another commit to this PR.

@divya-mohan0209 Actually I have made that first PR from website not via cloning.
then how can I make another commits into that same PR.
Can you please check out this PR also #34658 fixed all the mistakes in that file.
__
  Summary: :hammer_and_wrench: This code needs a fix

/lgtm
/approve


EntityFramework Components Timeout setting consistency

We currently have 5 EF components:

Npgsql
SqlServer
Oracle
MySql
Cosmos

2 of these components have a int? Timeout setting:
https://github.com/dotnet/aspire/blob/f07a34179c6078b8965e110a16ba2b7005dfb3c0/src/Components/Aspire.Microsoft.EntityFrameworkCore.SqlServer/MicrosoftEntityFrameworkCoreSqlServerSettings.cs#L54-L57
https://github.com/dotnet/aspire/blob/f07a34179c6078b8965e110a16ba2b7005dfb3c0/src/Components/Aspire.Oracle.EntityFrameworkCore/OracleEntityFrameworkCoreSettings.cs#L46-L49
But the other 3 don't.
We should make this consistent across all EF providers. Either we have this setting on all of them, or we remove it from these 2.
cc @sebastienros @DamianEdwards @roji @AndriySvyryd

Also consider renaming them to CommandTimeout to distinguish from other, like connection timeout


Need help with Rumble

I can't get Rumble to post no matter if I select user or channel. Has anyone else run into this issue? Otherwise, everything else seems to be running fine.
Thanks

Hey @eggovereasyinc sorry your having issues. Ill have to take a look at this still all a work in progress.


Azure V4 Function Multi-Response Output Binding failing when function async.

Hi Folks,
I just raised this as a bug, but not sure if I am also doing something incorrectly.
I am using VS2022 17.8.4. to develop an Azure v4 function running using the isolated worker process.  The application is using C# in .Net 8.0 running locally using the CosmosDB emulator.
The issue is that when I make the function async, the CosmosDB output fails with an error message:

IFeatureCollection has been disposed

The error occurs after the function return statement but before the client receives the response. The HttpResponse portion is successfully returned to the client.
The function returns a multi-response class defined below which is used to write out the data to the local cosmosDB emulator and return a copy to the calling client in the http response.
public class MultiResponse {
  [CosmosDBOutput(databaseName: "mytestdb", containerName: "testContainer", partitionKey = "/myPart", Connection="myConnectionStr", CreateIfNotExists = true)]
public MyDoc Item {get; set;}
public HttpResponseData HttpResponse {get; set;}
}

public class MyDoc {
public String Id {get; set;}
public String Name {get; set;}
}

The function definition is defined as
[Function("MyTestFunc")]
public async Task<MultiResponse> Run([HttpTrigger(AuthorizationLevel.Function, "get", "post", Route = null)] HttpRequestData req )
{
    MultiResponse resp = new MultiResponse
    {
        HttpResponse = req.CreateReponse(HttpStatusCode.OK),
        Item = new MyDoc() { Id = 1234, Name="Bob"}
    };

   resp.HttpResponse.Headers.Add("Content-Type", "Text/plain; charset=utf-8");
   await resp.HttpResponse.WriteStringAsync(JsonConvert.SerializeObject(resp.Item);  // copy for client.
   return resp;
}

When I change the Task to just MultiResponse in the function definition and make the contents of the function synchronous, it appears to work as expected and my CosmosDB instance contains the  record.
Edit: Update with further info.
I found that if I removed the async and task keywords from the Run() function making it synchronous I received the AllowSynchronousIO warning which is ok as that is what it is for.
I then tried with just removing the async keyword and leaving Task and after removing any await keywords (and replacing with Task<Response<...>> and Task.Result calls) where I had a call to read some data (not shown) I found that it works, I get both the HTTPResponse and CosmosDB gets updated.
So I am now wondering what I might be doing incorrectly with the async/await syntax as above.

I am experiencing the same issue.

I have discovered the problem I'm having, at least, is when setting the HttpResponseData property type of my return type, using await WriteAsJsonAsync(...), the content-length response header is not being set. When I set that header manually, it's working as expected.

To add more info, here.. I got the Http response to go, as I mentioned before, but now I'm getting..

System.ObjectDisposedException: IFeatureCollection has been disposed.

..for, in my case, sending a ServiceBus message. Here is my function signature/binding:
[Function("MyFunction")] public async Task<MyOutput> Run([HttpTrigger(AuthorizationLevel.Anonymous, "post")] HttpRequestData req)
And here is my "MyOutput" class:
`public class MyOutput
{
[ServiceBusOutput(queueOrTopicName: "MyServiceBusTopic")]
public MyServiceBusMessage MyMessage { get; set; }
public HttpResponseData HttpResponse { get; set; }

}`
Thanks

I have the same problem.
As soon as I do something asynchronously, I get the same error (IFeatureCollection has been disposed), it is enough, for example, to just do await Task.Delay(200) before I return.
Example that works
public class MultiResponse
{
    [QueueOutput("myqueue-items")]
    public QueueData? QueueData { get; set; }
    public HttpResponseData? Response { get; set; }
}

public class QueueData
{
    public string? Name { get; set; }
    public DateTime? Time { get; set; }
}

[Function("Function1")]
public async Task<MultiResponse> Run([HttpTrigger(AuthorizationLevel.Function, "get", "post")] HttpRequestData req)
{
    var response = req.CreateResponse(HttpStatusCode.OK);
    await response.WriteAsJsonAsync(new { Message = "Welcome to Azure Functions!" });

    return await Task.FromResult(new MultiResponse
    {
        QueueData = new QueueData { Name = "MyName", Time = DateTime.Now },
        Response = response
    });
}

Example that doesn't work
[Function("Function1")]
public async Task<MultiResponse> Run([HttpTrigger(AuthorizationLevel.Function, "get", "post")] HttpRequestData req)
{
    await Task.Delay(200);

    var response = req.CreateResponse(HttpStatusCode.OK);
    await response.WriteAsJsonAsync(new { Message = "Welcome to Azure Functions!" });

    return new MultiResponse
    {
        QueueData = new QueueData { Name = "MyName", Time = DateTime.Now },
        Response = response
    };
}

@AndyWDev @ntomasn
Are you getting this "IFeatureCollection has been disposed" error when using the ASP.NET Core integration ? Can you confirm things are working when you do not use this feature (Update your program.cs code to call ConfigureFunctionsWorkerDefaults instead of ConfigureFunctionsWebApplication  and remove the nuget package reference to Microsoft.Azure.Functions.Worker.Extensions.Http.AspNetCore ?

 I went to quadruple-check Program.cs and I had the asp.net core integration model enabled. Mine is working, now, async and all.

@kshyju  - thank you for the tip above. I was getting this error IFeatureCollection has been disposed - and it was driving me nuts. Your proposed solution works..
Is there more information on ConfigureFunctionsWorkerDefaults vs ConfigureFunctionsWebApplication  and the pros/cons. I used the code generated by Visual Studio - and it had ConfigureFunctionsWebApplication. When would I use each one - and what is recommended.

I also encountered the same error, but @kshyju provided the solution. Thank you!
It seems there was a documentation about running dotnet in isolated worker, @ahmedsza


[BEAM-4651] Add bundle-ready SQL shell using application plugin

This is a self-contained custom build for the SQL shell. Example build and use:
$ ./gradlew -p sdks/java/extensions/sql/shell -Pbeam.sql.shell.bundled=':beam-runners-google-cloud-dataflow-java,:beam-runners-flink_2.11,:beam-sdks-java-io-kafka,:beam-sdks-java-io-google-cloud-platform' installDist

$ ./sdks/java/extensions/sql/shell/build/install/beam-sdks-java-extensions-sql-shell/bin/beam-sdks-java-extensions-sql-shell

Welcome to Beam SQL 2.6.0-SNAPSHOT (based on sqlline version 1.3.0)
0: BeamSQL>

You can also use distZip and distTar to just build the bundle for whatever uses you desire. I inspected the zip to confirm the expected stuff was in it. I also tried it out with Pubsub and got to a bug that I am currently diagnosing (and this will help me do it faster).

Follow this checklist to help us incorporate your contribution quickly and easily:

[x] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
[x] If this contribution is large, please file an Apache Individual Contributor License Agreement.


Update README files

Proposed changes
Follow-up from https://github.com/pulumi/docs/pull/6788. Removing some old information which was already not accurate based on how things were before the aforementioned PR was merged.
Related issues (optional)
pulumi/registry#237

Ping


Improve the unhandled request strategy API

Prerequisites

[X] I confirm that none of the open issues match my proposal
[X] I confirm that my proposal is not yet available in the latest version of Zimic (see the documentation and the releases)

Scope
Improves an existing behavior
Compatibility

[X] This is a breaking change

Context
The current API to declare how unhandled requests should be processed is inconsistent comparing httpInterceptor.create and httpInterceptor.default.onUnhandledRequest.
httpInterceptor.create accepts a literal object or a function expression:
const interceptor = httpInterceptor.create<Schema>({
  // ...
  onUnhandledRequest: { log: false },
});

const interceptor = httpInterceptor.create<Schema>({
  // ...
  onUnhandledRequest: async (request, context) => {
    const url = new URL(request.url);

    // Ignore only unhandled requests to /assets
    if (!url.pathname.startsWith('/assets')) {
      await context.log();
    }
  },
});

On the other hand, httpInterceptor.default.onUnhandledRequest is a method that should be called with the default strategy:
httpInterceptor.default.onUnhandledRequest({ log: false });

httpInterceptor.default.onUnhandledRequest(async (request, context) => {
  const url = new URL(request.url);

  if (!url.pathname.startsWith('/assets')) {
    await context.log();
  }
});

The abstraction await context.log() is also a bit cumbersome and not very intuitive.
Finally, it may be unclear for users that local interceptors always bypass requests, while remote interceptors always reject them, except for the dedicated section in the docs.
Feature description
To improve consistency when declaring unhandled request strategies and prepare the terrain for https://github.com/zimicjs/zimic/issues/387, I propose a more intuitive API:
const interceptor = httpInterceptor.create<Schema>({
  type: 'local',
  onUnhandledRequest: { action: 'bypass' }
});

const interceptor = httpInterceptor.create<Schema>({
  type: 'remote',
  onUnhandledRequest: { action: 'reject' }
});

Users would be able to enable logging with a property logWarning?: boolean, whose default is true:
const interceptor = httpInterceptor.create<Schema>({
  type: 'local',
  onUnhandledRequest: { action: 'bypass', log: false }
});

const interceptor = httpInterceptor.create<Schema>({
  type: 'remote',
  onUnhandledRequest: { action: 'reject', log: false }
});

A factory would also be supported:
const interceptor = httpInterceptor.create<Schema>({
  onUnhandledRequest(request) {
    return { action: 'bypass', log: !request.url.includes('localhost' }
  },
});

The same API could be used for the defaults, separating local and remote defaults:
httpInterceptor.default.local.onUnhandledRequest = { action: 'bypass', log: false }
httpInterceptor.default.remote.onUnhandledRequest = { action: 'reject', log: false }

httpInterceptor.default.local.onUnhandledRequest = (request) => {
  return { action: 'bypass', log: !request.url.includes('localhost' }
},
httpInterceptor.default.remote.onUnhandledRequest = (request) => {
  return { action: 'reject', log: !request.url.includes('localhost' }
},

Development checklist

[ ] Migrate the httpInterceptor.create factory to handle the new onUnhandledRequest structure
[ ] Migrate dependent types, handlers, tests, and documentation
[ ] Migrate the httpInterceptor.default.onUnhandledRequest to the new structure
[ ] Migrate dependent types, handlers, tests, and documentation


Test suite modifications

moved tests; made them run standalone; added testset env

bors try

bors try

bors r+


Fix DubboProtocol state & Fix NPE when destroy

What is the purpose of the change
Brief changelog
Verifying this change

Checklist

[x] Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
[ ] Each commit in the pull request should have a meaningful subject line and body.
[ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
[ ] Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
[ ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
[ ] Add some description to dubbo-website project if you are requesting to add a feature.
[ ] GitHub Actions works fine on your own branch.
[ ] If this contribution is large, please follow the Software Donation Guide.

Codecov Report

Merging #8809 (3c34524) into 3.0 (e4bd941) will decrease coverage by 0.13%.
The diff coverage is 65.51%.

@@             Coverage Diff              @@
##                3.0    #8809      +/-   ##
============================================
- Coverage     63.94%   63.80%   -0.14%
  Complexity      314      314
============================================
  Files          1159     1159
  Lines         48841    48850       +9
  Branches       7324     7327       +3
============================================
- Hits          31232    31170      -62
- Misses        14221    14276      +55
- Partials       3388     3404      +16

Impacted Files
Coverage Δ

...ava/org/apache/dubbo/rpc/model/FrameworkModel.java
90.56% <0.00%> (-5.59%)
:arrow_down:

...in/java/org/apache/dubbo/rpc/model/ScopeModel.java
67.74% <50.00%> (-12.59%)
:arrow_down:

...e/dubbo/registry/integration/RegistryProtocol.java
60.27% <50.00%> (-0.06%)
:arrow_down:

...a/org/apache/dubbo/rpc/model/ApplicationModel.java
79.25% <75.00%> (-1.20%)
:arrow_down:

...n/java/org/apache/dubbo/rpc/model/ModuleModel.java
84.84% <100.00%> (+0.47%)
:arrow_up:

...nt/metadata/StandardMetadataServiceURLBuilder.java
90.69% <100.00%> (ø)

...dubbo/rpc/protocol/dubbo/CallbackServiceCodec.java
84.41% <100.00%> (+0.10%)
:arrow_up:

...va/org/apache/dubbo/registry/RegistryNotifier.java
82.05% <0.00%> (-17.95%)
:arrow_down:

...ubbo/registry/client/AbstractServiceDiscovery.java
87.50% <0.00%> (-12.50%)
:arrow_down:

...in/java/org/apache/dubbo/common/utils/JVMUtil.java
81.13% <0.00%> (-11.33%)
:arrow_down:

... and 34 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e4bd941...3c34524. Read the comment docs.


add probe for "grandma" attack

The semiotics of including brits in MARGINALIZED_GROUPS are definitely, uh, polysemous - both unacceptable and hilarious. We've had a hard couple of decades (I hear).


Errors with Docker Swarm

Scope project does not permit to display all networks in case of Swarm mode enabled.

@ronny35 Can you elaborate? What were you expecting to see? What errors are you getting?

I use docker in Swarm Mode and, using Weave Scope, I would like to obtain graphical state of my cluster when I deploy a new service in specific network.
Today, I have only some containers of this new service (in case of running in single node) and I have not link between containers in the same network.

@ronny35 Can you share a screenshot and explain what you were expecting to see?
Are there any tcp connections between the containers for which you expect and edge? Edges represent actual connections happening between them not a network-belonging relationship.

It means if one container A (backend) need to connect to container B (database), the edge must be present in UI Scope ?

Is there an existing TCP connection between those two containers? Did you get a confirmation by other means? (e.g.. netstat)

Again, there must be a TCP connections between the containers for Scope to show an edge.

What's more, the connection needs to be TCPv4 (we don't track TCPv6 connections yet).

I have deployed two services with tcp connections between us (inside the same network) and edges are not present.

Alright. I am going to need a way to reproduce.
Can you get me the Scope report? (</> button in the bottom left corner) and the output of netstat -tn in each container?
Please make sure that the report doesn't contain any sensitive information before forwarding it.

Closing this due to lack of reproducibility. Please re-open when there is further info.


fix 1st child currentActivity overflow for progress bar

Pull Request Template
Description
Add a summary that address the following:

motivation/purpose for the feature
fix the style issue with the overflow of the READ element when currentActivity is active.

What were those changes
uses a pseudo class for the 1st child element with a class of currentActivity and repositions this element to fit inside the progress bar.

What issues were fixed
READ element on the progress bar fits nicely inside, without clipping or hiding the nice pulse animation.

Provide the link to the user story it is referencing in Trello board or other supporting document
https://trello.com/c/sDa4n7ub

PRs needs to be reviewed by at least 2 team members

TPL is the 3rd reviewer
Lots of comments and suggestions, please!

Pull Request Rubric

 Child Dashboard - Styling on READ Solid Green - Needs to be rounded not overlay


Updated PL translation

Thanks, pal! You're not using latest (13.05) language file!
You're version is missing:

settings_right_hotkey_custom_options_description=Custom links enable you to use digits from 1 to 9 in order to quick-access any valid Webmin/Usermin/Virtualmin/Cloudmin URL. The URL can be extracted from the currently opened right frame content page, by reading its source. It's important that URL has no slash at the begining and doesn't use prefixes. For example, to quick-switch to Apache, set to custom link 1 field apache. If the default hotkeys modifier set to Alt, clicking Alt+1, will open you Apache module.
settings_hotkey_custom_1=Custom link 1
settings_hotkey_custom_2=Custom link 2
settings_hotkey_custom_3=Custom link 3
settings_hotkey_custom_4=Custom link 4
settings_hotkey_custom_5=Custom link 5
settings_hotkey_custom_6=Custom link 6
settings_hotkey_custom_7=Custom link 7
settings_hotkey_custom_8=Custom link 8
settings_hotkey_custom_9=Custom link 9

settings_hotkey_sysinfo=Hotkey for System Information

Please be kind mergin with the latest branch and then add those lines too correspondingly.

Before committing, please update to the latest 13.10. There are few more strings added.

Okay, I'll fix it and send another pull request.


No README.md

How can excited Contributors understand the goals of the repository and run it locally without a README ? :/

@MichaelHofbeck


there is another little bug I found out.

as showed in pic ,when I use i+=1;in an for loop, after optimized, it will disappear,but when I changed it to i++; ,it works well
I don't know why , what I can do is just submit a new issue =)

Thanks - I was able to reproduce the problem. I'll let you know what I find.

This was a bug with singleUseCopyProp - so you should be able to work around it by turning that off.
Here's a minimal repro.
function bug(i) {
  System.println(i);
  i += 1;
  System.println(i);
  i++;
  return i;
}

The problem is that the optimizer doesn't see the i++ as a "use" of i, so it thinks that the result of i += 1 is only used in one place, and the optimized code ends up as:
function bug(i) {
  System.println(i);
  // the optimizer incorrectly thinks the result of i += 1 is only used in one place,
  // and substitutes i+1 in the following line
  System.println(i + 1);
  // here it correctly sees that the result of i++ is only used in one place,
  // and substitutes i+1. But the value of i is wrong because it deleted the first i+=1.
  return i + 1;
}

In your example its the i++ in the for loop causing the same issue (and changing that to i+=1 fixes it). Note that eventually, the optimizer replaces that i++ with i += 1 anyway; but that doesn't happen until its already deleted the other i += 1.
I think there's an easy fix - I just have to run tests to make sure it doesn't introduce any new problems.

This was a bug with singleUseCopyProp - so you should be able to work around it by turning that off.
Here's a minimal repro.
function bug(i) {
  System.println(i);
  i += 1;
  System.println(i);
  i++;
  return i;
}

The problem is that the optimizer doesn't see the i++ as a "use" of i, so it thinks that the result of i += 1 is only used in one place, and the optimized code ends up as:
function bug(i) {
  System.println(i);
  // the optimizer incorrectly thinks the result of i += 1 is only used in one place,
  // and substitutes i+1 in the following line
  System.println(i + 1);
  // here it correctly sees that the result of i++ is only used in one place,
  // and substitutes i+1. But the value of i is wrong because it deleted the first i+=1.
  return i + 1;
}

In your example its the i++ in the for loop causing the same issue (and changing that to i+=1 fixes it). Note that eventually, the optimizer replaces that i++ with i += 1 anyway; but that doesn't happen until its already deleted the other i += 1.
I think there's an easy fix - I just have to run tests to make sure it doesn't introduce any new problems.

got it ! thank you !


YAML last step of any simulated test case seem to get skipped

Reproduction steps

Simulated test
Pair DUT to TH
Saw a strange issue where the last step of any simulated test case seem to get skipped, I even duplicated the last test step in one of the script and it gets executed only once.

Added diff link:
https://github.com/project-chip/connectedhomeip/compare/master...manjunath-grl:connectedhomeip:Simulated_Last_Step_Error
Bug prevalence
Eveytime
GitHub hash of the SDK that was being used
7b284c027bd5499ca3c5be00d51f83715e8969d6
Platform
other
Platform Version(s)
No response
Anything else?
YAML file:
Test_TC_ACT_3_1_Simulated.zip
Execution logs:
ACT_3_1_DUT.zip
In line no: 1529  ./out/debug/standalone/chip-tool bridgedactions read setup-url 0x654321 0

The execution log shows operational discovery failure when trying to read the setup-url, after there is no response to the first message send.  Did the server side get shut down during that operation or something?  Or did it crash?  @manjunath-grl

It shut down during that operation when i send the command to red the setup-url attribute
attached CTRL log for reference:
Uploading ACT_CTR.zip…

@vivien-apple Could you take a look?  Presumably the issue is that a read is processed async on the server or something?  I don't know where the simulated test setup lives and what would make the app quit like that....


Can I have ticking when using a custom date?

I'm passing in a date that I'm basing on a gmtDifference value I have access to.
If I don't pass in a date and use ticking={true} I get the desired effect: the time is the current date and the ticking happens once per second.
If I DO pass in a date and use ticking={true}, I get no ticking effect.

Hi @ttracey93
Let me investigate if I can help you.
Would you please provide a code example here if possible?

<Clock date={'1997-12-31T14:15:23+01:00'} format={'HH:mm:ss'} ticking={true} />

@ttracey93  @zenio this issue is fixed in v3.0.0,
You can take a look on the demo page, last example: https://pvoznyuk.github.io/react-live-clock/

i have same issue, when passing props date no ticking effect

What version are you using?

i'm using version 5.2.0

but, i'm trying downgrade to v4.0.5 ticking it's work for pass date custom

I don't have time to debug it at the moment, due to lots of work. But I will reopen the Issue.

This should be refixed in 5.5.0


Adjust max colour stretch values in PSRA maps

Some PSRA maps look like a 'sea of cream colour' it appears the max value of the colour stretch is too

Here are appropriate global max values for
CSD level
Average Annual Fatalities baseline = 0.902588
Average Annual Fatalities retrofit = 0.378745
Annual Probability of Fatality baseline = 0.000007
Annual Probability of Fatality retrofit = 0.000005
Annual Building and Contents Economic Loss baseline = 72955761.703502
Annual Building and Contents Economic Loss retrofit = 52512144.431167
Annual Building and Contents Economic Loss Ratio baseline = 0.001840
Annual Building and Contents Economic Loss Ratio retrofit = 0.001449
Buildings with Slight Damage over 50 years baseline = 10158.395161
Buildings with Slight Damage over 50 years retrofit = 9462.957636
Probability of Buildings with Slight Damage over 50 years baseline = 0.656037
Probability of Buildings with Slight Damage over 50 years retrofit = 0.510192
Buildings with Moderate Damage over 50 years baseline = 1283.647850
Buildings with Moderate Damage over 50 years retrofit = 1081.433265
Probability of Buildings with Moderate Damage over 50 years baseline = 0.151228
Probability of Buildings with Moderate Damage over 50 years retrofit = 0.094374
Buildings with Extensive Damage over 50 years baseline = 438.398155
Buildings with Extensive Damage over 50 years retrofit = 343.500585
Probability of Buildings with Extensive Damage over 50 years baseline = 0.070198
Probability of Buildings with Extensive Damage over 50 years retrofit = 0.040815
Buildings with Complete Damage over 50 years baseline = 806.128925
Buildings with Complete Damage over 50 years retrofit = 386.938465
Probability of Buildings with Complete Damage over 50 years baseline = 0.136453
Probability of Buildings with Complete Damage over 50 years retrofit = 0.073975
Collapsed Buildings over 50 years baseline = 60.637667
Collapsed Buildings over 50 years retrofit = 29.549729
Probability of Collapsed Buildings over 50 years baseline = 0.011617
Probability of Collapsed Buildings over 50 years retrofit = 0.005918
SAUID level
Average Annual Fatalities baseline = 0.027641
Average Annual Fatalities retrofit = 0.007526
Annual Probability of Fatality baseline = 0.00299
Annual Probability of Fatality retrofit = 0.000008
Annual Building and Contents Economic Loss baseline = 1655867.52502
Annual Building and Contents Economic Loss retrofit = 1434621.120156
Annual Building and Contents Economic Loss Ratio baseline = 0.004127
Annual Building and Contents Economic Loss Ratio retrofit = 0.004127
Buildings with Slight Damage over 50 years baseline = 285.468515
Buildings with Slight Damage over 50 years retrofit =  256.700495
Probability of Buildings with Slight Damage over 50 years baseline = 1.61836
Probability of Buildings with Slight Damage over 50 years retrofit = 1.31683
Buildings with Moderate Damage over 50 years baseline = 61.33992
Buildings with Moderate Damage over 50 years retrofit = 57.530215
Probability of Buildings with Moderate Damage over 50 years baseline = 0.29881
Probability of Buildings with Moderate Damage over 50 years retrofit = 0.26333
Buildings with Extensive Damage over 50 years baseline = 30.541315
Buildings with Extensive Damage over 50 years retrofit = 29.895915
Probability of Buildings with Extensive Damage over 50 years baseline = 0.143125
Probability of Buildings with Extensive Damage over 50 years retrofit = 0.139465
Buildings with Complete Damage over 50 years baseline = 42.49942
Buildings with Complete Damage over 50 years retrofit = 41.5053
Probability of Buildings with Complete Damage over 50 years baseline = 0.25127
Probability of Buildings with Complete Damage over 50 years retrofit = 0.19617
Collapsed Buildings over 50 years baseline = 3.782255
Collapsed Buildings over 50 years retrofit = 1.740192
Probability of Collapsed Buildings over 50 years baseline = 0.026762
Probability of Collapsed Buildings over 50 years retrofit = 0.01544

ready to review

Looks better, waiting on fixed PSRA tiles to before we can close

New max updates:
CSD level
Average Annual Fatalities baseline = 0.9026128279
Average Annual Fatalities retrofit = 0.3787599068
Annual Probability of Fatality baseline = 0.0000071514
Annual Probability of Fatality retrofit = 0.0000050413
SAUID level
Average Annual Fatalities baseline = 0.0276407533
Average Annual Fatalities retrofit = 0.0110009004
Annual Probability of Fatality baseline = 0.0000146418
Annual Probability of Fatality retrofit = 0.0000075126

@phil-evans There was a mistake with some of these values

I am experimenting with changing the "Max legend value" etc. inside WordPress, using only baseline maximum, as follows:
Average Annual Fatalities: /wp-admin/post.php?post=561&action=edit&lang=en

CSD: Max legend value: 0.99 → 0.9026128279
SAUID: Max legend value: 0.0032 → 0.0276407533  ← this seems to turn more areas into cream colour?

Annual Probability of Fatality: /wp-admin/post.php?post=562&action=edit&lang=en

CSD: Custom Scale Values: 1: 0, 2: 0.000001, 3: 0.000002, 4: 0.000003, 5: 0.000004, 6: 0.000005, 7: 0.000006, 8: 0.000007
→ Max legend value: 0.0000071514
SAUID: Custom Scale Values: 1: 0, 2: 0.0004, 3: 0.0008, 4: 0.0012, 5: 0.0016, 6: 0.002, 7: 0.0024, 8: 0.0028, 9: 0.0032
→ Max legend value: 0.0000146418

The very last change (max value for SAUID for Annual Probability of Fatality does make it look more colourful.  Example for Victoria:

I probably should follow @phil-evans's Custom Scale Values to make the numbers in the bottom scale legend (?) look more even?  What do you think @drotheram and @wkhchow?

I think the change looks good as you can now see the differences much more clearly. Does the bottom legend scale automatically change once you adjust the max values?


Hoover to resize is behind text and not at the end of the title cell

As seen on the screenshot the resize area is behind the text and not at the end of the cell (as expected).

Hi Danny,
thanks for the report. This issue was fixed with a recent commit (c90ab0e8807ff30a9ab58e9aa3515cf427dd6e86) and the fix will be available in next release.


Events? Eg: On portal ignite?

Is there any way to listen to an event for when the portal is ignited? I'd like to do an event/spawn mobs ect. around the portal when ignited.

Beta53 for 1.19 includes two new events. One that triggers before the portal is lit, and one after. See the builder


Streamdal Shim

I am working on some updates to protos that will require this PR to get updated; leave as-is - I will get it updated and merged tomorrow.


Advanced Tunnels

Maybe allow 1:n connections instead of just 1:1 connections.
Not sure whether I want to support this yet.

Wouldn't this be kind of difficult (and potentially confusing) when trying to map capability access from outside to inside?

Yes, we would need something that allows configuring the transfer mode, i.e. round-robin, distribute, priority based and so on.

I won't add this for now. Usually there are ways to handle this inside the machine using other blocks. Yes it would be nice, but it would also make all of this way more complicated and introduce a lot of corner cases, e.g. network-style capabilities (1 to all of them) would need to be handled differently than item-style capabilities (1 to one of them).


improve drag & drop

can be closed and opened in new issue for updates for v2
Originally posted by @fo0 in https://github.com/fo0/ScrumTool/issues/19#issuecomment-656330681

fixed


Improve error message TS1210

Changes error message TS1210 from:
Invalid use of '{0}'. Class definitions are automatically in strict mode.

to
Code contained in a class is evaluated in JavaScript's strict mode which does not allow this use of '{0}'. For more information, see https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Strict_mode.

as suggested.
Fixes #44765

Maybe we can say something like

Code contained in a class is evaluated in JavaScript's strict mode which does not allow this use of the legacy built-in variable '{0}'. The name '{0}' is reserved in strict mode. For more information, see https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Strict_mode.


device->SetProperty() returns hr = E_NOTIMPL Not implemented.

I have an old USB joystick (steering wheel) and I can run the DirectInput/Joystick example with it.
But if I try to run the Force Feedback one, I'm getting E_NOTIMPL from some calls like FFConst.cpp:239.
if (FAILED(hr = g_pDevice->SetProperty(DIPROP_AUTOCENTER, &dipdw.diph)))

If I just disable that one, then the error goes down to FFConst.cpp:273
if (FAILED(hr = g_pDevice->CreateEffect(GUID_ConstantForce,
        &eff, &g_pEffect, nullptr)))

I could test that joystick's "force feedback" from a "ForceTest.exe" tool I found from somebody that implemented force feedback in some Flight Simulator versions, but I can't tell how exactly the tool accesses the joystick as the tool is not open source.
Is this something with the joystick drivers? Where could I look up what they are missing developed in order to accept those calls? The driver installs OEMForceFeedback keys to the windows registry and (claims) it supports, for instance, constant force among other capabilities.

Okay, basically the problem for this is because my joystick doesn't have 64-bit drivers. If I compile it to 32-bit, I get a, better, E_INVALIDARG that must have been coming from something I changed in the code between my many attempts.

To confirm, I have somehow found a 64-bit version of the driver (although it is bugged), but after installing it, the E_NOTIMPL no longer triggered in 64-bit builds.

Ah, that would make sense. Glad you were able to resolve it.


Move overseas regions fixture out from migration

Description of change
When we added the OverseasRegion table, we had to create a
migration to load the data as well.
Now that all environments have this migration and therefore the
overseas region data, we can move this yaml out from the migrations
and into a fixture that we load using the loadinitialmetadata
command.
Checklist

[ ] Has a new newsfragment been created? Check changelog/README.rst for instructions
[ ] Have any relevant search models been updated?
[ ] Have any relevant fixtures (fixtures/test_data.yaml) been updated?
[ ] Have any relevant select-/prefetch-related field lists in the views and search apps been updated?
[ ] Has the admin site been updated (for new models, fields etc.)?
[ ] Has the README been updated (if needed)?

Discussed with @reupen and we're going to try keep the data migrations as migrations and see how it goes so I'm closing this for now.


Unable to run task with step named "init"

Pipeline version: v0.32.4
Triggers version: v0.19.0

After update(0.28? -> 0.32.4) when I try to run task with step named "init", my TaskRun fails with:
failed to create task run pod "lib-operator-database-0ftdo7-init": Pod "lib-operator-database-0ftdo7-init-pod" is invalid: spec.initContainers[1].name: Duplicate value: "step-init". Maybe missing or invalid Task platform/init-pipeline

I'd expect to be free in selection pipeline/task/step names, they should not be limited to not interfere with reserved words(may be internal steps could be named with some obfuscation - not "init" but "init-{{ somehash }}")

@vdemeester ^^^

@dbazhal can you share the Task definition ? (even redacted). This would not happen with more recent versions as the init container is not using init anymore, but it's just reporting the problem to another name.
I do agree we should make sure internal container do not interfere with any task step though.
/kind bug
/assign

/remove-lifecycle stale
/lifecycle frozen
sounds like an opportunity?)

/assign @renzodavid9

/assign

/unassign

/assign @ericzzzzzzz

The problem should be fixed by this change https://github.com/tektoncd/pipeline/pull/4826/files#diff-82b3e87876a8c03277b96958e0bbae05eda555b2196a54b02115a3268095fe31R419  The naming selections should be free for steps with tekton version >= v0.36.0, as when constructing task containers, tekton always prepends 'step' to the user-defined step name. And it's been a year since the last reply, probably it's safe to close the issue? @dibyom

yup, thanks for looking into this @ericzzzzzzz
/close


Roll up selected tags to only show selected descendants

Merged into cc/filter-ontology-ii as part of #2929.


Category Screen to Trivia Screen Transition Animation.

Applying Transition Animation when a user clicks on one of the categories to navigate to the Trivia Screen ( TriviaActivity ).
I have posted on slack some animations ideas to apply to transitions and others. Please check those out for a starting point.

I got this, and also the timer.

okay, you got it, i think joel wanted the UI part of the trivia screen enhancement. which includes the timer.but you guys should talk and decide that.


Prepare release 2.2.0

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (34fe636) 84.85% compared to head (7199a16) 84.85%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #218   +/-   ##
========================================
  Coverage    84.85%   84.85%
========================================
  Files           17       17
  Lines         2192     2192
========================================
  Hits          1860     1860
  Misses         332      332

Flag
Coverage Δ

unittests
84.85% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


The output is wrong

jdk1.8
os：win10
io.github.java-diff-utils
java-diff-utils
4.12

The correct output is:
first line：The correct one should be: |aaaa~b~|aaaac|                 Not at all:|~aaaab~|aaaac|
Third line: The correct one should be: |ttt~t~ttt|tttrttt|			   Not at all:|~ttttttt~|tttrttt|

You are using inline diff by word, aaaab is a word. You have to put an own splitter into it to achieve your result.
You have to use something like this. However now the complete input is treated single characters and you will get some unexpected results.
List<DiffRow> rows = DiffRowGenerator.create()
                .showInlineDiffs(true)
                //.inlineDiffByWord(true)
                .inlineDiffBySplitter(DiffRowGenerator.SPLITTER_BY_CHARACTER)
                .decompressDeltas(true)
                .oldTag(f -> "~")
                .newTag(f -> "**")
                .build()
                .generateDiffRows(
                        Arrays.asList("aaaab", "aaaaaa", "ttttttt"),
                        Arrays.asList("aaaac", "bbbbbb", "tttrttt"));

        System.out.println("|original|new|");
        System.out.println("|--------|---|");
        for (DiffRow row : rows) {
            System.out.println("|" + row.getOldLine() + "|" + row.getNewLine() + "|");
        }

original
new

aaaab
aaaac

~aaaaaa~
bbbbbb

tttttt~t~
tttrttt

For instance the first line is aaaab\n. So c inerts in fact here c\n , thats why the last b is suddenly in the second line.
JavaDiffUtils are having problems here due to linefeed handling. You could expect better results, when you only insert line by line.


letm as a syntactic sugar for let mut

i propose introducing a new keyword letm as a syntactic sugar for let mut. this saves 4 characters.

I don't think this is a good idea. There are many other places where you could save characters in the language. Rust already keeps a good balance of not writing too many characters but also not too few, so it's not a burden but also readable.

If typing it is an issue for you, you could propose autocompleting letm to let mut in code editors instead.
Also, there are many occurrences of mut for bindings (e.g. parameters, match, let Foo(mut field)) that you cannot save the character for, and possibly (citation needed) &mut is way more prevalent than let mut if you want to save characters somewhere.


Issue 956 - core-metadata Command: update query methods

Removed redundant assignments.
Converted GetCommandById().
Converted GetCommandByName().
Converted GetAllCommands().

Issue #956

As part of this PR @michaelestrin has changed the receiver of some methods to not use pointers. This is because no modification of the receiver's state is taking place. A follow up issue has been created to make this uniform throughout the mongo/metadata.go file.
https://github.com/edgexfoundry/edgex-go/issues/974


Update browser SDK with support for NIST-P256 curve

Why
Update browser SDK with support for NIST-P256 curve
Tested encrypted outputs in a cage
How
Describe how you've approached the problem

:tada: This PR is included in version 1.0.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


New event TransactionsReady, publish VidDisperseSend inside VID task

We should determine whether VidDisperseSend is supposed to be published in the transaction task as is now, or in the DA task, together with DAProposalSend. We may need to update the structure of the BlockReady event.

I'd appreciate an opinion here from @bfish713 when he returns from vacation.

Yesterday we discussed an idea to create a new task for VID to separate it from the DA and transactions tasks. The idea is: transactions task collect transactions, publish BlockReady event. Both DA and VID tasks listen for this event, then do their jobs. All the ugly VID work is done inside the VID task.
Some complications:

BlockReady needs a BlockPayload, which is Committable, so we need the VID commitment at the beginning (ie. in the transactions task).
We could eliminate the need for the VID commitment at the beginning if we change BlockReady to include only a Vec<Transaction>. (Or if we somehow manage to remove Committable from BlockPayload). Buuuuuuuuut.......
The DA task also needs the VID commitment because that's what's signed as part of the DA proposal it creates. Soooooo....
Seems like we're stuck in a situation where we need the VID commitment inside the transactions task. I see no way to avoid this situation.

Where to publish the VidDisperseSend event?
I suggest we continue to publish VidDisperseSend in the transactions task until we get a new task for VID. At that time, it might make sense to move publication of this event to the new VID task. But it's complicated. I explain this complexity below, then I present a new proposal.
Recall discussion from https://github.com/EspressoSystems/HotShot/issues/1817#issuecomment-1741192171 :

DA task needs the VID commitment
Thus, VID commitment must be included in BlockReady event.
Thus, VID commitment must be computed before BlockReady event is published.
BlockReady event is published inside the transactions task, so VID commitment must be computed inside this task.
VID commitment is expensive, but it comes for free when we compute VID disperse data.
Thus, we should compute all the VID disperse data inside the transactions task, too.
Because we compute all the VID disperse data inside the transactions task, the natural thing to do is publish the VidDisperseSend event inside the transactions task.

Given the above, the choice of whether to publish VidDisperseData inside the transactions task vs the VID task is largely a cosmetic choice. In all cases, VID disperse data is computed inside the transactions task. If we prefer to publish the VidDisperseEvent outside the transactions task then we could (for example) include this data in the BlockReady event---then the VID task could read this data from that event and publish VidDisperseData. None of this changes the fact that all the VID work is done inside the transactions task---the only question is whether to publish VidDisperseData at the moment we compute it inside the transactions task, or to push the data somewhere else so we can instead publish it from the VID task.
Proposal: new event
Currently the DA task listens for BlockReady from the transactions task. Instead, I propose the following flow:

VID task listens for BlockReady from the transactions task.
VID task computes VID commitment + disperse data, then publishes 2 events: (i) the VidDisperseSend event as usual, and (ii) a new BlockReadyWithVidCommitment event (but choose a better name). This new event includes (i) block payload data from BlockReady, and (ii) VID commitment.
DA task does not listen for BlockReady. Instead DA task listens for BlockReadyWithVidCommitment, which has all the info it needs.

Advantages:

All VID-specific computation is done inside the VID task.
The transactions task reverts to its original minimal purpose.

Maybe rename BlockReady to TransactionsReady since it's building the transactions only, and BlockReadyWithVidCommitment could be BlockReady.

This workflow needs to be changed. We recently discussed that the DA committee in fact does not need the VID commitment. Why? Because they can't trust it anyway. Instead each DA committee member must re-compute the VID commitment C for itself and then sign an attestation to C.
New workflow proposed by Jeb
So the workflow can be like: transactions task builds block and encodes to bytes.  Emits a TransactionsSequenced event
VID task - listens for TransactionsSequenced, calculates VID upon receiving that event. Emits BlockReady event
VID task - listens for BlockReady, then sends out the VIDProposalSend event
DA task - listens for TransactionsSequenced, creates DA proposal upon receiving that event. Emits DAProposalSend

Do we still expect the transactions task to calculate the block payload?
I think this makes the most sense as the DA task also requires the block payload and metadata - but just making sure.

Do we still expect the transactions task to calculate the block payload?

I say yes. This is dead easy though: just call the trait method BlockPayload::build.

Do we still expect the transactions task to calculate the block payload?

I say yes. This is dead easy though: just call the trait method BlockPayload::build.

+1! Btw it's BlockPayload::from_transactions after the renaming.


statuses

Should my status show up in the status feed?
user@machine:~/.local/bin$ ./socl status post "first status? or do they expire?"
Successfully posted a new status
user@machine:~/.local/bin$ ./socl status feed

user@machine:~/.local/bin$

I think that the status shows up in the me command. Or if someone visits your profile. Like so.
C:\Users\lined>socl status post "This is amazing!"
Successfully posted a new status

C:\Users\lined>socl me

********** akodakim **********

Slogan:         None
Website:        None
Interests:      None
Skills:         None

Status:         This is amazing!
Groups:         None

Followers:      0
Following:      0

C:\Users\lined>socl user dmonn

********** dmonn **********

Slogan:         The creator.
Website:        https://dmonn.ch
Interests:      Computers, Reddit, Tech
Skills:         Python, Swift

Status:         You tell me
Groups:         Reddit
                Supporters
                Area51
                happy_nerds
                Developers
                Socialize

Followers:      6
Following:      5

Yes, the status feed only includes posts from people you follow. Your own current status gets displayed on your profile.


Consul secretapi

For issue #40

Current coverage is 81.03%

Merging #76 into master will increase coverage by +2.48% as of a2c9aa4

@@            master     #76   diff @@
======================================
  Files           30      25     -5
  Stmts          373     385    +12
  Branches        16      23     +7
  Methods          0       0
======================================
+ Hit            293     312    +19
  Partial          0       0
+ Missed          80      73     -7

Review entire Coverage Diff as of a2c9aa4

Powered by Codecov. Updated on successful CI builds.

@tejom this consul secret store is large enough now, i think it deserves to be in its own namespace'd folder.

how is this going @tejom?


Coda daemon crashed

exn: "("connection attempt timeout" <IP_ADDRESS>:12222 src/tcp.ml:120:11)"
2019-10-01 09:06:42 UTC [Error] Broadcasting message "snark pool diff" to $peer failed: $error
peer: {
"host": "<IP_ADDRESS>",
"discovery_port": 12223,
"communication_port": 12222
}
error: "("connection attempt timeout" <IP_ADDRESS>:12222 src/tcp.ml:120:11)"
2019-10-01 09:08:04 UTC [Error] RPC call raised an exception: $exn
exn: "("connection attempt timeout" <IP_ADDRESS>:12222 src/tcp.ml:120:11)"
2019-10-01 09:08:04 UTC [Error] Broadcasting message "snark pool diff" to $peer failed: $error
peer: {
"host": "<IP_ADDRESS>",
"discovery_port": 12223,
"communication_port": 12222
}
error: "("connection attempt timeout" <IP_ADDRESS>:12222 src/tcp.ml:120:11)"
^Z
[1]+  Stopped                 coda daemon -peer filet-mignon.o1test.net:8303 -propose-key keys/my-wallet
root@vmi300810:~# coda daemon -peer filet-mignon.o1test.net:8303 -propose-key keys/my-wallet
2019-10-01 09:08:14 UTC [Info] Coda daemon is booting up; built with commit "78e066cd487ab2ec16594d6b3bf489deffe140c3" on branch "master"
2019-10-01 09:08:14 UTC [Info] Daemon will expire at "2019-10-08 14:00:00-07:00"
2019-10-01 09:08:14 UTC [Info] Booting may take several seconds, please wait
Secret key password:
Wrong password! Please try again
Secret key password:
2019-10-01 09:08:34 UTC [Fatal] Unhandled top-level exception: $exn
Generating crash report
exn: "(monitor.ml.Error\n  (Failure\n    "IO error: While lock file: /root/.coda-config/trust/LOCK: Resource temporarily unavailable")\n  ("Raised at file \"stdlib.ml\", line 33, characters 17-33"\n    "Called from file \"lib/rocksdb/database.ml\", line 16, characters 34-63"\n    "Called from file \"lib/trust_system/peer_trust.ml\", line 50, characters 15-44"\n    "Called from file \"app/cli/src/coda.ml\", line 569, characters 28-65"\n    "Called from file \"src/deferred0.ml\", line 56, characters 64-69"\n    "Called from file \"src/job_queue.ml\" (inlined), line 131, characters 2-5"\n    "Called from file \"src/job_queue.ml\", line 170, characters 6-47"\n    "Caught by monitor coda"))"
☠  Coda daemon crashed. The Coda Protocol developers would like to know why!
Please:
Open an issue:
https://github.com/CodaProtocol/coda/issues/new

I could be wrong, but it looks like you started the daemon, then suspended it (with ctrl-z), then started another, and the second one crashed because of a lockfile in .coda-config/trust.
One thing you could try is only running one daemon at a time, for now (if you need to run more than one, you can specify non-conflicting .coda-config directories and ports).
We could definitely stand to improve this error message though, thanks!


Ability to set a priority to cookies in setCookie options

Hono's setCookie did not have Priority and I recently needed that option so I forked hono and added it. Nothing's serious been changed—succesfully tested locally.

It may be necessary to write a simple test on this.

It may be necessary to write a simple test on this.

My bad—added priority to the seralization tests (3f0e470575488931eea72722af51125e89b4e0a8):
...
 ✓ src/utils/cookie.test.ts (27)
...
 Test Files  9 passed (9)
      Tests  414 passed | 3 skipped (417)
...

Hi @Beyondo
Thank you for the PR. Looks good. I'll merge this later and induce this change in the next patch release.

Now, the time has come. I'll merge it.


Add hourly and monthly periodicities

To the expected file update frequency

https://github.com/unchartedsoftware/PLUTO/pull/428


Map zoom is different with provider="google" in iOS

Is this a bug report?
yes
Have you read the Installation Instructions?
yes
Environment
react-native: 0.52.0
react: 16.2.0
expo: 25.0.0
react-native-maps: 0.19.0 or<EMAIL_ADDRESS>
Steps to Reproduce
Add a Map to a View
<MapView     style={{ height: 400, width: ‘100%’ }}     provider="google"     initialRegion={{         latitude: 45.463908,         longitude: 9.19788,         latitudeDelta: 0.0922,         longitudeDelta: 0.0421     }} />
Expected Behavior
I'd expect the same map zoom in both iOS and Android.
Screenshot in iOs 11.2.6

Screenshot in Android 8

Actual Behavior
iOS ignores the longitudeDelta and latituteDelta when using provider="google" values and map is zoomed out.
Reproducible Demo
snack.io

I spent hours and hours trying to solve the longitudeDelta to discover minutes ago that there is a bug on ios when using google as provider , thank you for opening this issue

We merged #2131 two days ago, can you try with the last master (so the git version).

We merged #2131 two days ago, can you try with the last master (so the git version).

how did you solve this issue please because I am using google maps in my app and the zoom level differs between the IOS and the android


[BUG] - Export-PnPTermGroupToXml and Import-PnPTermGroupFromXml not working for pinned terms

Reporting an Issue or Missing Feature
Pinned terms are not being handled in the Export-PnPTermGroupToXml. It is working for reused terms, but not pinned terms.
Expected behavior
Pinned Terms are being pinned correctly.
Actual behavior
The terms are not being pinned correctly in the target term set.
Steps to reproduce behavior

Create a Term Set and add a Term.
Create another Term Set and pinned the term from the step 1 to the current Terms
Export-PnPTermGroupToXml -Out test.xml
Import-PnPTermGroupFromXml -Path .\test.xml

What is the version of the Cmdlet module you are running?
1.11.102
Which operating system/environment are you running PnP PowerShell on?

[x] Windows
[ ] Linux
[ ] MacOS
[ ] Azure Cloud Shell
[ ] Azure Functions
[ ] Other : please specify

@natpdeee  - Can you please update to the latest release 2.1.x however you will need PS 7.2 or later to benefit from all the bug fixes and improvements, and let us know.
PS5 support has been dropped in the new release. Thanks

Closing as no response.

Hi @veronicageek ,
I am now using 2.1.64-nightly release in PS  7.3.4 and still got the same issue. Can you confirm whether IsPinned (documentation) is supported when Exporting and Importing term groups?


ProviderEnum types should be consistent with djangoflow-django-openapi generated openapi

Currently, in djangoflow_openapi we have ProviderEnum for social auth related operations. Which is generated via djangoflow-django-openapi repository.
And in bistronix, we have the same thing but in different name as SocialTokenObtainProviderEnum
or also in https://github.com/djangoflow/djangoflow-examples/tree/main/simple_auth/backend-django
The problem basically is that
In every django backend projects we have SocialObtainTokenProviderEnum, but in djangoflow_openapi it is ProviderEnum which creates inconsistency and compile time errors.
Desired:
All of the project's model should be consistent with naming and they should match the ones in https://github.com/djangoflow/flutter-djangoflow/blob/main/packages/djangoflow_openapi

solved in djangoflow_openapi: 0.0.16


Replace Common protocol with SecureChannel

Problem
Common protocol was being used synonomously with SecureChannel, even though the spec does not currently define anything to exist in a Common protocol.
Some StatusReport code is currently defined as part of Common protocol when it should be SecureChannel.
This is also a pseudo-follow-up to #5359
Summary of Changes
- remove references to Common protocol and replace with SecureChannel
- change SecureChannel protocol ID to 0
- move StatusCode definitions to
src/protocols/secure_channel/Constants.h
- fix bug in SecureSessionMgr that incorrectly parsed some messages as
having SecureChannel message IDs

Fixes #5379

@bzbarsky-apple @yufengwangca In the most recent commit I add the default-initialization of PayloadHeader with kProtocol_NotSpecified. I also tried this change with the original code from SecureSessionMgr.cpp and a bunch of unit tests failed. Which means sometimes
if (payloadHeader.HasMessageType(Protocols::SecureChannel::MsgType::MsgCounterSyncReq)

is probably still evaluating as true unintentionally sometimes

and a bunch of unit tests failed

Which ones?  I just tries this locally and it seemed to work, but it's possible that the tests involved are disabled on my platform...

and a bunch of unit tests failed

Which ones? I just tries this locally and it seemed to work, but it's possible that the tests involved are disabled on my platform...

I just tried it again and they passed... It's possible I just didn't save my changes or maybe I should have done a clean build first. I'll upload another commit resetting the changes for that file


insert zeros on symmetric matrix diagonal

This PR addresses #653.  This change inserts zeros on the diagonal of a distance matrix instead of  NANs.

@jlaura should have a look as I don't remember the original motivation for the nan fill?

As far as I can tell there is no benefit  to have NaN instead of float(0.0) on a distance-based matrix.

J

On Jul 10, 2015, at 4:38 PM, Sergio Rey <notifications<EMAIL_ADDRESS>wrote:
@jlaurahttps://github.com/jlaura should have a look as I don't remember the original motivation for the nan fill?
—
Reply to this email directly or view it on GitHubhttps://github.com/pysal/pysal/pull/660#issuecomment-120516354.

I can think of one for generic distance matrices.
Imagine where we make a network for potential spatial interaction situations where a point is a valid origin but not a destination.
In that case, the self-distance should not be 0, but np.nan.  Right now, if we make them nan, we can't remask from zero. But, if nan, it's simple to use builtin masking tools to make nan's zeros.
In general distance matrices, we need to preserve a way to differentiate nonsymmetric origin-destinations. This commit does this. But, we need to remember this.
If zero masking is currently burning someone's use case, we should totally merge. This commit only affects symmetric matrices, which is the point of using zero and not nan. For a symmetric matrix, @jGaboardi is def right.

Also, was thinking about this the other day. For some distance matrix dist, it's very convenient to be able to call things like dist.min(axis=1) or np.argmin(dist, axis=1) to extract nearest neighbors from a pairwise distance matrix. Infilling diagonals with zeros removes this ability. Not sure if this is desirable.

These are good arguments for nan on the diagonal. I think that the rest of pysal assumes zeros on the diagonal, unless explicitly stated otherwise. My interpretation of the earlier design decision was that most of the downstream functions were expecting zeros (or some numeric value) in all slots, so that was the default. The function weights.util.insert_diagonal() was written for the non-typical cases. Sounds like the typical (or better) case for network is nan.


Add ECSTargetGroupObject to the configuration reference documentation

What this PR does / why we need it:
I added ECSTargetGroupObject as it was not documented.
I didn't know to what extent I should add the document, so I added it only to the latest version first.
Please let me know if you need to add it to docs-dev or any other ver.
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?:

How are users affected by this change:
Is this breaking change:
How to migrate (if breaking change):

@ouchi2501 Nice catch 🙏
Please also update the docs file under /docs-dev with the same content 🙏

@khanhtc1202
Thanks for the comment 👍🏼
Also updated /docs-dev.


Fixed indexing bug in ModelGrid and bumped h5py and numpy

Upgraded h5py and numpy and fixed indexing bug in ModelGrid that popped up after upgrade.

Just pushing this one through since it's just about getting the builds to pass. #sorrynotsorry