BlockBlobURL.CommitBlockList error code?

When I call resp, err := BlockBlobURL.CommitBlockList(......) with an invalid block list, the error variable gets set as expected. However, this err is just the http response object.
This is not very helpful, because resp is a nil pointer when an error is returned. This is strange since resp is of type *BlockBlobCommitBlockListResponse which has an ErrorCode() function which in this case should return InvalidBlockList, and this is the behaviour that I want.
How can I get the error code from a resp, err := BlockBlobURL.CommitBlockList(......)  call?
===== RESPONSE ERROR (ServiceCode=InvalidBlockList) =====
Description=The specified block list is invalid.
RequestId:82724516-501e-00a4-30b1-f8fb57000000
Time:2020-03-12T20:59:02.5159931Z, Details:
   Code: InvalidBlockList
   PUT ......./bpla54856bg0uticgme0?comp=blocklist&timeout=61
   Authorization: REDACTED
   Content-Length: [134]
   Content-Type: [application/xml]
   User-Agent: [Azure-Storage/0.7 (go1.14; linux)]
   X-Ms-Blob-Cache-Control: []
   ......
   X-Ms-Version: [2018-11-09]
   --------------------------------------------------------------------------------
   RESPONSE Status: 400 The specified block list is invalid.
   Content-Length: [221]
   Content-Type: [application/xml]
   Date: [Thu, 12 Mar 2020 20:59:01 GMT]
   Server: [Windows-Azure-Blob/1.0 Microsoft-HTTPAPI/2.0]
   X-Ms-Error-Code: [InvalidBlockList]
   X-Ms-Request-Id: [82724516-501e-00a4-30b1-f8fb57000000]
   X-Ms-Version: [2018-11-09]

Which version of the SDK was used?
go get github.com/Azure/azure-storage-blob-go/azblob
Which platform are you using? (ex: Windows, Linux, Debian)
MacOS 10.15

Hi @sanderdekoning, thanks for reaching out.
Please refer to our sample on error handling.

Thank you @zezha-msft, that helps me out a lot. I appreciate your time.


e2e: remove debug log

Type of change:

[ ] Bugfix
[ ] New feature provided
[x] Improve performance
[ ] Backport patches

What this PR does / why we need it:

#1148

Pre-submission checklist:

[ ] Did you explain what problem does this PR solve? Or what new features have been added?
[ ] Have you added corresponding test cases?
[ ] Have you modified the corresponding document?
[ ] Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

Codecov Report

Merging #1358 (4fd7b59) into master (3619b74) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1358   +/-   ##
=======================================
  Coverage   40.62%   40.62%
=======================================
  Files          75       75
  Lines        7006     7006
=======================================
  Hits         2846     2846
  Misses       3847     3847
  Partials      313      313

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Test create mnemonic

This function proved to be difficult to test. The only way to test the failures of the NewEntropy and NewMnemonic function calls was to use dependency injection in createMnemonic. This provided a way to pass in mock versions of these functions that would fail.

Coverage increased (+0.2%) to 58.898% when pulling 4f72ebde1c828deb3eb16b1d61b94c38728d5413 on davalb:test-createMnemonic into 05c3b946fe7be48740bb0dffa3cd8be6b341e0c7 on OpenBazaar:master.

Coverage increased (+0.2%) to 58.898% when pulling ea7d7548eed4d87dc2df815ee686ba51e78e5cfb on davalb:test-createMnemonic into 05c3b946fe7be48740bb0dffa3cd8be6b341e0c7 on OpenBazaar:master.

Looks good but I'm going to think abut it some. I think I should have made bip39.NewMnemonic take a bytesize and return a securely random mnemonic, and have a separate bip39.NewMnemonicFromEntropy. That would move these tests to that repo. I'm not sure; I'll think about it. It's certainly not a major concern either way, just a bit of refactoring.
@davalb @cpacia any thoughts there?

Ok. I think that's my preference but not worth the time right now.
@davalb Thanks for another great PR!


Wrong type hint for kwargs

Describe the bug
The type hint given for kwargs in methods search search_all search_iter_page download download_all of class EODataAccessGateway is dict, but should probably be something like int | str | bool in order to avoid IDEs complaining about types.
Code To Reproduce
gateway = EODataAccessGateway()
results = gateway.search_all(
    productType='S2_MSI_L2A_MAJA',
    start="2021-09-01",
    end="2021-09-02"
)
gateway.download_all(results, outputs_prefix="output")

Output

Environment:

Python version: 3.10.1
EODAG version: 2.3.4
IDE : PyCharm 2021.2.3

Thanks for reporting this issue @LoicViennois !


bug: Next.js Video in Ad Hoc classes -> GSOC Section Fails to Load Due to Media Error

Describe the bug
The Next.js video in the Ad Hoc classes -> GSOC section/folder is unavailable. When attempting to play the video, the following error is logged: "The media could not be loaded, either because the server or network failed or because the format is not supported."
To Reproduce
Steps to reproduce the behavior:
Navigate to the Ad Hoc -> GSOC section/folder in Cohort 2 (0-100).
Attempt to play the Next.js video.
See the error: "The media could not be loaded, either because the server or network failed or because the format is not supported."
Expected behavior
The video should load and play without any issues.
Screenshots or GIFs

Info (please complete the following information):
Browser: Chrome
Version:
Additional context
The issue could be related to server availability or unsupported media format. Please check the media file's compatibility and server settings.

Sorry for this. I'll report it to the mods. Will update, when it's back online.
Thanks for reporting.

Hey @x15sr71 please mention this issue in Discord & tag Rookie or Ankur bro. I'm sure they can help with this.
Once the problem is solved, please feel free to close the issue.

Ok @avparadox , I will be raising this issue on Discord as suggested. Closing it here for now.


Document Objective-C extensions with DocC

Feature Name
Document Objective-C Extensions
Description
Implement #210, but this time for Objective-C.
Motivation
I have a project which is basically an extension on NSObject. Without the documentation on extended Objective-C objects, the doc generated by DocC is completely useless for my project.
Importance
I think this feature is relatively important. I am trying a very ugly workaround for the time being, but this would simply not work for a bigger project.
Extension-only frameworks are not uncommon and documenting them should, IMHO, be possible, even for Objective-C projects, especially since DocC has official support for Objective-C.
Alternatives Considered
For now I’m trying a workaround with a separate target where a custom object, subclass of NSObject is created and the extension on NSObject are done on this custom object just for the documentation.
It’s ugly and absolutely not scalable, and I’m currently not even sure it’ll work.

@daniel-grumberg does this issue belong somewhere in the clang repo or here?

https://github.com/llvm/llvm-project/issues/92240


chore(deps): update common-dev-assets digest to 88ba41d

This PR contains the following updates:

Package
Update
Change

common-dev-assets
digest
b5ce6b5 -> 88ba41d

Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.

[ ] If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

:tada: This PR is included in version 2.1.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


OC-197 Sets Interceptor to first in HttpClientBuilder

SonarQube analysis reported 1 issue
Note: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:

 WebServiceTemplateFactory.java#L75: Constructor has 8 parameters, which is greater than 7 authorized.

All is well.


Reduce friction of adding new plugins to the hub

Migrated from GitLab: https://gitlab.com/meltano/hub/-/issues/192
Originally created by @therebbie on 2022-02-02 15:18:28

Getting new plugins added is relatively slow as we have to support so many other things. Is there a way to focus more to get the most important stuff done?

View 5 previous comments from the original issue on GitLab


Bump Python GAX version

Corresponds to https://github.com/googleapis/gax-python/pull/122

Current coverage is 88.56% (diff: 100%)

Merging #81 into master will not change coverage

@@             master        #81   diff @@
==========================================
  Files             3          3
  Lines           717        717
  Methods         150        150
  Messages          0          0
  Branches        106        106
==========================================
  Hits            635        635
  Misses           82         82
  Partials          0          0

Powered by Codecov. Last update 61e5c26...bfb8406

@bjwatson @jmuk PTAL -- there have been some changes to the Java templates, and the Python dependencies have been bumped, so it would be good to have a new release.

LGTM


Cannot start Docker Container: SESSION_MANAGER environment variable not defined

First of all, I would like to thank everyone who came up with the Bot record Zoom solution
I'm trying to run the docker image version on docker hub and got this error, hope to get some feedback and help.
OS: MacOS
Docker: Docker version 20.10.22, build 3a2c30b
Start script:
docker run
-e TZ=Asia/Ho_Chi_Minh
-v $(pwd)/recordings:/home/zoomrec/recordings
-v $(pwd)/example/audio:/home/zoomrec/audio
-v $(pwd)/example/meetings.csv:/home/zoomrec/meetings.csv:ro
-p 5901:5901
--security-opt seccomp:unconfined
kastldratza/zoomrec:latest
Container Log
DISPLAY = :1
VNC_COL_DEPTH = 24
VNC_RESOLUTION = 1024x576
VNC_IP = <IP_ADDRESS>
VNC_PORT = 5901
Connect to <IP_ADDRESS>:5901
Start script..
Failed to connect to session manager: Failed to connect to the session manager: SESSION_MANAGER environment variable not defined

@ThanhTungRedAnt did you manage to solve this issue?


Pencil icon not shown in editable columns

In editable columns:

Pencil icon not shown in editable columns.
Column widths change on mouse over(probably trying to show icon above).

Expected behavior and actual behavior:

Pencil icon should be shown in editable columns.
Column widths have to be the same with and without icon.

Steps to reproduce the problem:
Create table with 1 or more editable columns. Width of column is a bit more than width of it's content.
Screenshots (optional, but very helpful):
Code examples help us better understand the issue - follow the appropriate codepen for the component by going to https://predix-ui.com, finding the component in question, and clicking on the pencil icon under the demo.
    http://codepen.io/anon/pen/xRNKEq?editors=1011

PS: fix for icon consists in changing prefixes for icons(polymer-font-awesome => fa) in _getCellIcon method in px-data-table-cell.html to:
_getCellIcon: function(showEditIcon, editing, valid){
if(valid) {
if(showEditIcon) {
return 'fa:fa-pencil';
}
}
else {
return 'fa:fa-warning';
}
}

Hi,
Thanks for the issue. Working for me fine here: https://www.predix-ui.com/px-data-table/px-data-table/px-data-table-column-demo.html (build from latest release of px-data-table).
Can you please check the link above and close if it works for you, thanks!

Sorry, cannot close. Yes, with this demo it works, but you can easily reproduce the issue wth this demo:

click on the pencil icon in this demo to go to codepen(right bottom corner of screen)

change table-data={{data}} with table-data='[{"first":"Valentine","last":"Meyer","email":"valentinemeyer@scentric.com"},{"first":"Silva","last":"Alexander","email":"silvaalexander<EMAIL_ADDRESS>

change only 1 column shown to following 3:

The issue is reproducible...

This would explain why it is not showing up in the CodePen. Do you see this issue anywhere other than the CodePen?

Ok, this really explains codepen issue. But I have the same behavior locally with latest table component. As I've said before fixing prefix to 'fa' solves the issue. All iron-icon components, that I've seen, use this prefix. Only here there's other one - 'polymer-font-awesome'.
In px-polymer-font-awesome/polymer-font-awesome-all.html and px-polymer-font-awesome/polymer-font-awesome.html:
iron-iconset-svg id="fa" name="fa"
Maybe there's some code, that performs translation?
BTW I have latest version of px-polymer-font-awesome -  1.1.0

Hi @simonovdenis
Thanks for the issue - this should be fixed in v1.15.4


Add authentication [WIP]

Adds the ability to require authentication

I like this solution, What I suggest is to create some built in authentication functions, for example:
options.IsAuthenticated = UseBearerToken;


Write unit tests for lib/eth_client/abi.ex

To merge on https://github.com/lambdaclass/ethereum_war_game_tooling/pull/75


always send tail output - regardless of pipeline & step status

@blinktag tested with demo-client. Seems to work fine.


Draft mode

Hello, I'm trying to build an app that relies on draft mode and I just cannot get it to work on cloudflare using edge runtime. It seems that edge is missing some environment variables that get set in vercel.
In particular I've tracked it down to these:
'__NEXT_PREVIEW_MODE_ENCRYPTION_KEY',
'__NEXT_PREVIEW_MODE_ID',
'__NEXT_PREVIEW_MODE_SIGNING_KEY',

This is the method that uses them: https://github.com/vercel/next.js/blob/canary/packages/next/src/server/web/get-edge-preview-props.ts
Any ideas if I'm just missing some sort of setup from my side? Or is it missing support from cloudflare side? Thanks!

Hey @RokasVCheckatrade,
I have a similar use case where I use cookies to enable a service but in the current state the adapter doesn't support the middleware and routing behavior that next.js uses. But @vicb said they have plan to do this and I think once that is done, draft mode should work automatically or get it working with a small sweak :)
I hope this helps :)

Hi @RokasVCheckatrade, I'm not sure if it will fix your problem because it might be due to middleware, but I've got a PR up that will define these environment variables on process.env.
Could you try out the prerelease in https://github.com/opennextjs/opennextjs-cloudflare/pull/97#issuecomment-2408726331 and see if that helps you at all?


rmi doesn't remove all images if an error occurs

Print out the error if unable to remove image due to multiple tags
or due to it being used in a container and continue to remove all
the other images.
Signed-off-by: umohnani8<EMAIL_ADDRESS>

@rhatdan @mheon PTAL

LGTM

@rh-atomic-bot r+


github actions install failure

I don't know why but github actions ubuntu-latest fails install packages.
This is one of the errors:
https://github.com/redboltz/mqtt_cpp/pull/558/checks?check_run_id=346888168#step:3:65

I guess that CI environment or package repository updated.
Other projects' github actions scripts have the same trouble too.

I don't try it yet but it could be a temporary fix:
https://github.community/t5/GitHub-Actions/ubuntu-latest-Apt-repository-list-issues/td-p/41122/page/2

Fixed by github.


Extend output of command "cf space-users" with origin of the user

Please provide details on the following items. Failure to do so may result in deletion of your feature request.
The UAA allows the existence of the very same username in multiple origins (e.g. uaa, ldap, someSamlProvider, someOidcProvider). The command "cf space-users" list the usernames of the users that have some org roles assigned (SPACE MANAGER, SPACE DEVELOPER or SPACE AUDITOR). If an username exists in multiple origins (e.g. uaa and ldap) it is not clear which user actually has the corresponding role assigned. It could be either the user with origin ldap or the one with origin uaa. The request is to extend the output of the command by the origin of the user, e.g. "myuser (uaa)".
What's the user value of this feature request?
The value is that the output of both, username and origin, identifies the user uniquely. This is currently not the case as only the username is provided.
Who is the functionality for?
Everybody who uses the command "cf space-users" and more than one origin for users.
How often will this functionality be used by the user?
Every time a user executes "cf space-users".
Who else is affected by the change?
No breaking change.
Is your feature request related to a problem? Please describe.
Yes, the problem that a user cannot identified uniquely by the output of command "cf space-users".
Describe the solution you'd like
The output of the command "cf space-users" may look as follows (as an example):
Getting users in org myorg / space myspace as myuser

SPACE MANAGER
  somemanageruser (uaa)

SPACE DEVELOPER
  myuser (uaa)

SPACE AUDITOR
  someauditoruser (ldap)

Note that the username "myuser" in the first line can stay as it is as the user knowns with which origin he logged in.
Describe alternatives you've considered
There are no alternatives that I am aware of. If a user is listed by the command "cf space-users" you may try to assign him the same role again. If this does not work, he probably has the role already. But even such approaches do only work if the username is only listed once.

Proposed workflow for adding this feature: https://docs.google.com/document/d/1wFXhxkh0a5UttNnPcx37o7ByAczGciCVJqVZ2D2lJGg/edit


the namespace 'myApp' already contains a definition for 'Program'

Problem encountered on https://dotnet.microsoft.com/learn/dotnet/hello-world-tutorial/run
Operating System: macos
Provide details about the problem you're experiencing. Include your operating system version, exact error message, code sample, and anything else that is relevant.

You probably ran the command twice and dotnet is telling you that it already exists. You can either pass --force to overwrite the existing project, or delete the folder and start over. Let us know if this helps.

thanks


various view delta improvements

Description
Fixes a bug in expected view delta where sorting didn't happen correctly, and changes the view delta entity change type to be an enum
Primary reviewers
@samiwh @jessicafalk

damn you prow


Buildrun controller tries to proceed even if build status is registered=false

Steps to reproduce:

Create a build with a spec.output.credentials.name that references a non-existing secret -> the build will be registered=false
Create a buildrun with spec.serviceAccount.generate set to false

The buildrun controller now updates the pipeline (if existing) or default service account and adds the non-existing secret to the service account. The service account from now on is broken. Even if the build and buildrun are deleted and created with a correct secret, the service account will continue to reference the non-existing secret.
Suggested fix: the buildrun controller should check the build's registered status. If this is false, it should not try to work on service account and tekton taskrun.
Another scenario to be investigated: use an existing secret in a build that gets added to a service account. Then later delete the secret. Is it somehow removed from the service account or not?

Agree. We should stop buildrun process if the build is not registered.
I think we can add after this build fetch:
https://github.com/redhat-developer/build/blob/master/pkg/controller/buildrun/buildrun_controller.go#L137-L143
And report an error if the register is false

more bugs please! we need them

@routerhan will be working on this


?

[Enter feedback here]

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 6367067e-e9ce-6c2a-dd5d-a9de54735e78
Version Independent ID: 18564fed-2285-8cab-39a0-e3f1c2407c19
Content: Tutorial: Build a .NET console app to manage data in Azure Cosmos DB SQL API account
Content Source: articles/cosmos-db/sql/sql-api-get-started.md
Service: cosmos-db
Sub-service: cosmosdb-sql
GitHub Login: @kirankumarkolli
Microsoft Alias: kirankk

Hello @AGauchat As the query is incomplete,
We will now proceed to close this thread. If there are further questions regarding this matter, please tag me in your reply. We will gladly continue the discussion and we will reopen the issue.
Please also do visit Microsoft Q&A the home for technical questions and answers at Microsoft.


Incorrectly rendered table

The API docs for multiple pages in keras.applications are not rendered properly, see the tables on:
https://www.tensorflow.org/api_docs/python/tf/keras/applications/nasnet
https://www.tensorflow.org/api_docs/python/tf/keras/applications/mobilenet_v2
https://www.tensorflow.org/api_docs/python/tf/keras/applications/mobilenet
Fixes https://github.com/keras-team/keras/issues/16727

Please fix the lint errors.

This issue still persists!


Switch from cmake to cc in build script

This builds on the work done by @kureuil  in PR #10 and #13.  #13 has not been merged yet and merging this branch should merge that PR as well.  From PR #13, this will update our dependency on civetweb to v1.10 and bumps our civet and civet-sys version numbers.
My new commit switches from a dependency on the cmake crate to the cc crate.  cc will use the appropriate system compiler for the platform and I've confirmed that this builds and passes tests on Ubuntu 17.10 and Windows 10 1710 (Fall Creators Update).  I'm not able to try this out on Mac, but I believe this will close issue #12.
Fixes #12

@jtgeibel Your PR works flawlessly on my Windows system (on both cmd.exe and the WSL) ! I closed my PR in favor of yours.

@alexcrichton it would be nice to have merged and included in a new release.  I'm working on updating dependencies for crates.io and this should fix the linking issues on Linux and Mac.

@jtgeibel I'm unfortunately not maintaining this crate any more, you'd want to contact @wycats to get access to the repo or perhaps fork it for crates.io at this point

Thanks @alexcrichton.  I pinged you because it looks like you are the only owner listed on crates.io at the moment.  Would you be willing to add me, or possibly the crates-io-pushers team, as an owner?  For reference, the only public reverse dependencies on this crate are:

git2-curl requires ^0.8
conduit-static requires ^0.9
cargo-registry requires ^0.9

It looks like there is a similar situation with conduit, where git2-curl, cargo-registry, and all the other conduit-* crates are the only public reverse dependencies.  (And it looks like cargo is the only public crate depending on git2-curl.)  Long term I'd like to move crates.io to a different backend, but for now I'm looking to clean up some dependencies.  For example, bumping to a new version of cookie will require publishing a minor update to conduit-cookie.
Since it seems like civet and the conduit-* crates are all in maintenance-only mode, with cargo and cargo-registry as the only applications depending on this ecosystem of crates, I'm wondering if you want help maintaining the conduit-* crates as well.

Ok! I've added you as an owner of the crates.io crate

Thanks @alexcrichton!
@wycats would you prefer to add me as a collaborator on this repo, or that I clone and point the crate to that?

@alexcrichton sorry to bother you again.  I finally got around to merging this and trying to publish a new version.  I'm an owner on civet, but not civet-sys.  Would you add me as an owner on civet-sys as well?  Thanks!

Done!

Alright, I've released this fix in 0.11.0 and have migrated the repository to jtgeibel/rust-civet.


RuntimeError: t == DeviceType::CUDA INTERNAL ASSERT FAILED

I met the above error message when I was trying to apply quantize_embeddings() and QuantEmbeddingBagCollectionSharder() to a model using "gloo" backend. I'm not sure if this is a bug or not. I report the bug here since I was asked to. I copied a reproduction code snippet and the output traceback below.
I was using pytorch 1.12.0, torchrec 0.2.0, and fbgemm-gpu 0.2.0.
Reproduction Code
import os

import torch
import torch.distributed as dist
import torch.nn as nn
import torchrec.distributed as trec_dist
from torchrec.distributed.embeddingbag import EmbeddingBagSharder
from torchrec.distributed.model_parallel import DistributedModelParallel
from torchrec.distributed.planner import EmbeddingShardingPlanner, Topology
from torchrec.distributed.test_utils.test_model import ModelInput
from torchrec.distributed.types import ShardingEnv
from torchrec.modules.embedding_configs import EmbeddingBagConfig
from torchrec.modules.embedding_modules import EmbeddingBagCollection

def setup():
    os.environ["RANK"] = "0"
    os.environ["WORLD_SIZE"] = "1"
    os.environ["LOCAL_WORLD_SIZE"] = "1"
    os.environ["MASTER_ADDR"] = str("localhost")
    os.environ["MASTER_PORT"] = str("12345")
    os.environ["NCCL_SOCKET_IFNAME"] = "lo"

    device = torch.device("cpu")
    backend = "gloo"
    try:
        dist.init_process_group(backend=backend)
    except:
        pass
    return device

device = setup()

class TestModel(nn.Module):
    def __init__(self):
        super().__init__()

        table_params = [
            [776, 908],
            [430, 40],
        ]

        self.tables = [
            EmbeddingBagConfig(
                num_embeddings=table_params[i][0],
                embedding_dim=table_params[i][1],
                name="table_" + str(i),
                feature_names=["feature_" + str(i)],
            )
            for i in range(len(table_params))
        ]

        self.sparse = EmbeddingBagCollection(
            tables=self.tables,
            is_weighted=False,
        )

    def forward(
        self,
        input: ModelInput,
    ):
        sparse_r = self.sparse(input.idlist_features)
        return sparse_r

def shard_model(device):
    model = TestModel()

    input = ModelInput.generate(
        batch_size=10,
        world_size=1,
        num_float_features=1,
        tables=model.tables,
        weighted_tables=[],
    )

    from torchrec.inference.modules import quantize_embeddings
    model = quantize_embeddings(model, dtype=torch.qint8, inplace=True)
    model.to(device)

    pg = dist.GroupMember.WORLD
    assert pg is not None, "Process group is not initialized"
    env = ShardingEnv.from_process_group(pg)

    planner = EmbeddingShardingPlanner(
        topology=Topology(
            local_world_size=trec_dist.comm.get_local_size(env.world_size),
            world_size=env.world_size,
            compute_device=device.type,
        ),
    )

    from torchrec.distributed.quant_embeddingbag import QuantEmbeddingBagCollectionSharder
    sharders = [QuantEmbeddingBagCollectionSharder()]
    plan = planner.collective_plan(model, sharders, pg)
    print(device)
    dmp = DistributedModelParallel(
        module=model,
        init_data_parallel=False,
        device=device,
        sharders=sharders,
        plan=plan,
    )

    return dmp(input[0])

shard_model(device)

Traceback
Traceback (most recent call last):
  File "others/reproduce_quant_gloo.py", line 106, in <module>
    shard_model(device)
  File "others/reproduce_quant_gloo.py", line 103, in shard_model
    return dmp(input[0])
  File "/opt/conda/envs/tr02/lib/python3.7/site-packages/torch/nn/modules/module.py", line 1130, in _call_impl
    return forward_call(*input, **kwargs)
  File "/opt/conda/envs/tr02/lib/python3.7/site-packages/torchrec/distributed/model_parallel.py", line 276, in forward
    return self._dmp_wrapped_module(*args, **kwargs)
  File "/opt/conda/envs/tr02/lib/python3.7/site-packages/torch/nn/modules/module.py", line 1130, in _call_impl
    return forward_call(*input, **kwargs)
  File "others/reproduce_quant_gloo.py", line 61, in forward
    sparse_r = self.sparse(input.idlist_features)
  File "/opt/conda/envs/tr02/lib/python3.7/site-packages/torch/nn/modules/module.py", line 1130, in _call_impl
    return forward_call(*input, **kwargs)
  File "/opt/conda/envs/tr02/lib/python3.7/site-packages/torchrec/distributed/types.py", line 433, in forward
    return self.compute_and_output_dist(ctx, dist_input)
  File "/opt/conda/envs/tr02/lib/python3.7/site-packages/torchrec/distributed/quant_embeddingbag.py", line 215, in compute_and_output_dist
    input,
  File "/opt/conda/envs/tr02/lib/python3.7/site-packages/torchrec/distributed/quant_embeddingbag.py", line 212, in <listcomp>
    for lookup, dist, features in zip(
  File "/opt/conda/envs/tr02/lib/python3.7/site-packages/torch/nn/modules/module.py", line 1130, in _call_impl
    return forward_call(*input, **kwargs)
  File "/opt/conda/envs/tr02/lib/python3.7/site-packages/torchrec/distributed/sharding/tw_sharding.py", line 428, in forward
    return self._dist.forward(local_embs)
  File "/opt/conda/envs/tr02/lib/python3.7/site-packages/torchrec/distributed/dist_data.py", line 758, in forward
    self._cat_dim,
  File "/opt/conda/envs/tr02/lib/python3.7/site-packages/torch/_ops.py", line 143, in __call__
    return self._op(*args, **kwargs or {})
RuntimeError: t == DeviceType::CUDA INTERNAL ASSERT FAILED at "/home/ec2-user/miniconda/envs/build_binary/lib/python3.7/site-packages/torch/include/c10/cuda/impl/CUDAGuardImpl.h":24, please report a bug to PyTorch.

Hey @jiannanWang - thanks for reporting. Could check if using fbgemm-gpu-cpu works? You'd need to pip uninstall fbgemm-gpu first, and then pip install fbgemm-gpu-cpu. My hunch is that fbgemm-gpu always places some things on cuda devices

Hi, thank you for your reply! I tried to uninstall fbgemm-gpu 0.2.0 and then install fbgemm-gpu-cpu 0.2.0, and I got the error message below.
One thing I'm curious about is since I was using gloo backend, I was under the assumption that I'm using CPU instead of GPU. Why does this error message mention running with CUDA backend? Does the quantization only work with CUDA backend?
Traceback (most recent call last):
  File "reproduce_quant_gloo.py", line 106, in <module>
    shard_model(device)
  File "reproduce_quant_gloo.py", line 103, in shard_model
    return dmp(input[0])
  File "/opt/conda/envs/tr02cpu/lib/python3.7/site-packages/torch/nn/modules/module.py", line 1130, in _call_impl
    return forward_call(*input, **kwargs)
  File "/opt/conda/envs/tr02cpu/lib/python3.7/site-packages/torchrec/distributed/model_parallel.py", line 276, in forward
    return self._dmp_wrapped_module(*args, **kwargs)
  File "/opt/conda/envs/tr02cpu/lib/python3.7/site-packages/torch/nn/modules/module.py", line 1130, in _call_impl
    return forward_call(*input, **kwargs)
  File "reproduce_quant_gloo.py", line 61, in forward
    sparse_r = self.sparse(input.idlist_features)
  File "/opt/conda/envs/tr02cpu/lib/python3.7/site-packages/torch/nn/modules/module.py", line 1130, in _call_impl
    return forward_call(*input, **kwargs)
  File "/opt/conda/envs/tr02cpu/lib/python3.7/site-packages/torchrec/distributed/types.py", line 433, in forward
    return self.compute_and_output_dist(ctx, dist_input)
  File "/opt/conda/envs/tr02cpu/lib/python3.7/site-packages/torchrec/distributed/quant_embeddingbag.py", line 215, in compute_and_output_dist
    input,
  File "/opt/conda/envs/tr02cpu/lib/python3.7/site-packages/torchrec/distributed/quant_embeddingbag.py", line 212, in <listcomp>
    for lookup, dist, features in zip(
  File "/opt/conda/envs/tr02cpu/lib/python3.7/site-packages/torch/nn/modules/module.py", line 1130, in _call_impl
    return forward_call(*input, **kwargs)
  File "/opt/conda/envs/tr02cpu/lib/python3.7/site-packages/torchrec/distributed/embedding_lookup.py", line 663, in forward
    embeddings.append(embedding_lookup(sparse_features_rank))
  File "/opt/conda/envs/tr02cpu/lib/python3.7/site-packages/torch/nn/modules/module.py", line 1130, in _call_impl
    return forward_call(*input, **kwargs)
  File "/opt/conda/envs/tr02cpu/lib/python3.7/site-packages/torchrec/distributed/embedding_lookup.py", line 574, in forward
    embeddings.append(emb_op(features))
  File "/opt/conda/envs/tr02cpu/lib/python3.7/site-packages/torch/nn/modules/module.py", line 1130, in _call_impl
    return forward_call(*input, **kwargs)
  File "/opt/conda/envs/tr02cpu/lib/python3.7/site-packages/torchrec/distributed/quant_embedding_kernel.py", line 162, in forward
    offsets=features.offsets().int(),
  File "/opt/conda/envs/tr02cpu/lib/python3.7/site-packages/torchrec/sparse/jagged_tensor.py", line 825, in offsets
    _offsets = _maybe_compute_offsets(self._lengths, self._offsets)
  File "/opt/conda/envs/tr02cpu/lib/python3.7/site-packages/torchrec/sparse/jagged_tensor.py", line 65, in _maybe_compute_offsets
    offsets = _to_offsets(lengths)  File "/opt/conda/envs/tr02cpu/lib/python3.7/site-packages/torchrec/sparse/jagged_tensor.py", line 36, in _to_offsets    return torch.ops.fbgemm.asynchronous_complete_cumsum(lengths)  File "/opt/conda/envs/tr02cpu/lib/python3.7/site-packages/torch/_ops.py", line 143, in __call__
    return self._op(*args, **kwargs or {})
NotImplementedError: Could not run 'fbgemm::asynchronous_complete_cumsum' with arguments from the 'CUDA' backend. This could be because the operator doesn't exist for this backend, or was omitted during the selective/custom build process (if using custom build). If you are a Facebook employee using PyTorch on mobile, please visit https://fburl.com/ptmfixes for possible resolutions. 'fbgemm::asynchronous_complete_cumsum' is only available for these backends: [Dense, UNKNOWN_TENSOR_TYPE_ID, QuantizedXPU, UNKNOWN_TENSOR_TYPE_ID, UNKNOWN_TENSOR_TYPE_ID, UNKNOWN_TENSOR_TYPE_ID, UNKNOWN_TENSOR_TYPE_ID, UNKNOWN_TENSOR_TYPE_ID, SparseCPU, SparseCUDA, SparseHIP, UNKNOWN_TENSOR_TYPE_ID, UNKNOWN_TENSOR_TYPE_ID, UNKNOWN_TENSOR_TYPE_ID, SparseVE, UNKNOWN_TENSOR_TYPE_ID, NestedTensorCUDA, UNKNOWN_TENSOR_TYPE_ID, UNKNOWN_TENSOR_TYPE_ID, UNKNOWN_TENSOR_TYPE_ID, UNKNOWN_TENSOR_TYPE_ID, UNKNOWN_TENSOR_TYPE_ID, UNKNOWN_TENSOR_TYPE_ID].

CPU: registered at /home/ec2-user/actions-runner/_work/FBGEMM/FBGEMM/fbgemm_gpu/src/sparse_ops_cpu.cpp:2435 [kernel]
BackendSelect: fallthrough registered at /opt/conda/conda-bld/pytorch_1656352464346/work/aten/src/ATen/core/BackendSelectFallbackKernel.cpp:3 [backend fallback]
Python: registered at /opt/conda/conda-bld/pytorch_1656352464346/work/aten/src/ATen/core/PythonFallbackKernel.cpp:133 [backend fallback]
Named: registered at /opt/conda/conda-bld/pytorch_1656352464346/work/aten/src/ATen/core/NamedRegistrations.cpp:7 [backend fallback]
Conjugate: registered at /opt/conda/conda-bld/pytorch_1656352464346/work/aten/src/ATen/ConjugateFallback.cpp:18 [backend fallback]
Negative: registered at /opt/conda/conda-bld/pytorch_1656352464346/work/aten/src/ATen/native/NegateFallback.cpp:18 [backend fallback]
ZeroTensor: registered at /opt/conda/conda-bld/pytorch_1656352464346/work/aten/src/ATen/ZeroTensorFallback.cpp:86 [backend fallback]
ADInplaceOrView: fallthrough registered at /opt/conda/conda-bld/pytorch_1656352464346/work/aten/src/ATen/core/VariableFallbackKernel.cpp:64 [backend fallback]
AutogradOther: fallthrough registered at /opt/conda/conda-bld/pytorch_1656352464346/work/aten/src/ATen/core/VariableFallbackKernel.cpp:35 [backend fallback]
AutogradCPU: fallthrough registered at /opt/conda/conda-bld/pytorch_1656352464346/work/aten/src/ATen/core/VariableFallbackKernel.cpp:39 [backend fallback]
AutogradCUDA: fallthrough registered at /opt/conda/conda-bld/pytorch_1656352464346/work/aten/src/ATen/core/VariableFallbackKernel.cpp:47 [backend fallback]
AutogradXLA: fallthrough registered at /opt/conda/conda-bld/pytorch_1656352464346/work/aten/src/ATen/core/VariableFallbackKernel.cpp:51 [backend fallback]
AutogradMPS: fallthrough registered at /opt/conda/conda-bld/pytorch_1656352464346/work/aten/src/ATen/core/VariableFallbackKernel.cpp:59 [backend fallback]
AutogradXPU: fallthrough registered at /opt/conda/conda-bld/pytorch_1656352464346/work/aten/src/ATen/core/VariableFallbackKernel.cpp:43 [backend fallback]
AutogradHPU: fallthrough registered at /opt/conda/conda-bld/pytorch_1656352464346/work/aten/src/ATen/core/VariableFallbackKernel.cpp:68 [backend fallback]
AutogradLazy: fallthrough registered at /opt/conda/conda-bld/pytorch_1656352464346/work/aten/src/ATen/core/VariableFallbackKernel.cpp:55 [backend fallback]
Tracer: registered at /opt/conda/conda-bld/pytorch_1656352464346/work/torch/csrc/autograd/TraceTypeManual.cpp:295 [backend fallback]
AutocastCPU: fallthrough registered at /opt/conda/conda-bld/pytorch_1656352464346/work/aten/src/ATen/autocast_mode.cpp:481 [backend fallback]
Autocast: fallthrough registered at /opt/conda/conda-bld/pytorch_1656352464346/work/aten/src/ATen/autocast_mode.cpp:324 [backend fallback]
Batched: registered at /opt/conda/conda-bld/pytorch_1656352464346/work/aten/src/ATen/BatchingRegistrations.cpp:1064 [backend fallback]
VmapMode: fallthrough registered at /opt/conda/conda-bld/pytorch_1656352464346/work/aten/src/ATen/VmapModeRegistrations.cpp:33 [backend fallback]
Functionalize: registered at /opt/conda/conda-bld/pytorch_1656352464346/work/aten/src/ATen/FunctionalizeFallbackKernel.cpp:89 [backend fallback]
PythonTLSSnapshot: registered at /opt/conda/conda-bld/pytorch_1656352464346/work/aten/src/ATen/core/PythonFallbackKernel.cpp:137 [backend fallback]

Hi, hope you're doing well! Seems like others are meeting the same issues as well. I just want to check if there're any updates on this issue. Thanks!


Render WebRTC media stream in to ExternalTexture

Hello there, I am trying to develop an AR app to help visual impaired people to make better their access conditions to a computer.
I am investigating on how AR can help HCI for visual disabilities, so, the application is using WebRTC to get computer Desktop to be magnified at AR environment using Sceneform.
I have successfully used the Sceneform example  https://github.com/google-ar/sceneform-android-sdk/tree/master/samples/chromakeyvideo, but, I have no idea of how to render the WebRTC stream directly to a ExternalTexture. -> https://github.com/judicapo/MUITSS-ARBE/tree/master/SampleApps/ARCK
Thank you all for your replies, hope some one has any idea.

Hello, is there any updates about this question? Thank you all.

Hello there, is been a lot since I opened this issue.
Would you guys mind having a look on it?
Thanks.

Keep following this issue. Do you have any update?
thank you


[Web] - Uncaught TypeError: Cannot read property 'toString' of null

we are using quill and Editor are working fine but when we start to deploy on web then it's getting issue.
#Issue
main.dart.js:72075 Uncaught TypeError: Cannot read property 'toString' of null
Please find Screenshot

closing due to no repro


high vulnerabilities for this package

https://www.npmjs.com/advisories/1002590
mentioned this package has vulnerabilities. Any plan to have a fix

README.md


[Compression] Fix ByteBuffer allocate error in the AirliftUtils

Fixes #9666
Motivation
The compressed data length may be bigger than the original data length (e.g. the source text is not repeated, such as "abcde"), so we can't use the uncompressed length as the allocated length to initial the ByteBuffer.
Modifications
Use the capacity of the ByteBuffer instead of the uncompressed length as the allocated length.
Verifying this change
Update the existing tests.
Does this pull request potentially affect one of the following parts:
If yes was chosen, please highlight the changes

Dependencies (does it add or upgrade a dependency): (no)
The public API: (no)
The schema: (no)
The default values of configurations: (no)
The wire protocol: (no)
The rest endpoints: (no)
The admin cli options: (no)
Anything that affects deployment: (no)

/pulsarbot run-failure-checks


[SPARK-28343][SQL][TEST] PostgreSQL test should enable cartesian product

What changes were proposed in this pull request?
This pr enables cartesian product for PostgreSQL test.
How was this patch tested?
manual tests:
Run test.sql in pgSQL directory and in inputs directory:
cat <<EOF > test.sql
create or replace temporary view t1 as
select * from (values(1), (2)) as v (val);

create or replace temporary view t2 as
select * from (values(2), (1)) as v (val);

select t1.*, t2.* from t1 join t2;
EOF

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/12635/
Test PASSed.

@maropu I didn't enable spark.sql.parser.ansi.enabled because:
spark-sql> set spark.sql.parser.ansi.enabled=true;
spark.sql.parser.ansi.enabled	true
spark-sql> select 1 as false;
Error in query:
no viable alternative at input 'false'(line 1, pos 12)

== SQL ==
select 1 as false
------------^^^

spark-sql> select 1 as minus;
Error in query:
no viable alternative at input 'minus'(line 1, pos 12)

== SQL ==
select 1 as minus
------------^^^

Is this we expected?

Test build #107509 has started for PR 25109 at commit 86ca933.

ur, looks bad.... I checkd the reserved keywords in Postgresql again;
https://www.postgresql.org/docs/current/sql-keywords-appendix.html
FALSE is reserved, but the qyery works well in postgresql;
postgres=# select 1 as false;
 false
-------
     1
(1 row)

How about Oracle and the other databases? Can they accept that query, too?

Test build #107509 has finished for PR 25109 at commit 86ca933.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/107509/
Test FAILed.

Teradata, Vertica, Oracle, SQL Server and DB2 can accept these queries.

retest this please

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/12647/
Test PASSed.

Test build #107521 has started for PR 25109 at commit 86ca933.

oh, I see. If so, I think Spark might need to accept these queries if ansi=true...

IMO we need to make spark compatible with these DBMSs with ansi=true. So, how about setting ansi=true for the PostgreSQL tests by default and turning off the ansi mode for these queries like this?
set ansi=false;
select 1 as false;
set ansi=true;

Then, filing a jira for these unsupported behaviours?

Test build #107521 has finished for PR 25109 at commit 86ca933.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/107521/
Test PASSed.

Test build #107626 has started for PR 25109 at commit 45af58f.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/12756/
Test PASSed.

Test build #107626 has finished for PR 25109 at commit 45af58f.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/107626/
Test PASSed.

Test build #107628 has started for PR 25109 at commit 4a66a89.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/12758/
Test PASSed.

Test build #107628 has finished for PR 25109 at commit 4a66a89.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/107628/
Test PASSed.

Thank you for swift update, @wangyum !
If we add SPARK-28349 comment explicitly, the others looks good.
(If we forgot to add that comment, the future developers will ask about that.)
cc @gatorsmile and @maropu .

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/12764/
Test PASSed.

Test build #107634 has started for PR 25109 at commit 8ce7af4.

Test build #107634 has finished for PR 25109 at commit 8ce7af4.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/107634/
Test PASSed.


Associate WAF ACL

Hi,
This PR is a work on top of @athal7 #214 PR, which aim to fix the panic and finish the work. I couldn't contribute to @athal7's original PR, so I had to open a new one.
It is rebased on top of latest master and has been proof-tested on a live aws k8s cluster.
It would awesome if any of you could take the time to review it and possibly merge it.
Let me know if there's anything I need to do.
Thanks,
Brice

cool with me. i dont really have WAF experience to test against. i

Just checking to see if there has been any success in testing this? Would love to use this functionality!

@kodytrinnier as I said in the original ticket, we're using this patch along with #279 in production for more than 3 months now without any (apparent) issue.
Of course YMMV.

@bigkraig I will rebase and fix conflicts ASAP.
I'll add a check in delete at the same time.


Fails to start on Python 3.10

The following error occurs on startup when running in the python 3.10 runtime.
[ERROR] Runtime.ImportModuleError: Unable to import module 'scan': cannot import name 'Iterable' from 'collections' (/var/lang/lib/python3.10/collections/__init__.py)Traceback (most recent call last): | [ERROR] Runtime.ImportModuleError: Unable to import module 'scan': cannot import name 'Iterable' from 'collections' (/var/lang/lib/python3.10/collections/__init__.py) Traceback (most recent call last):
-- | --

Resolved after completion of https://github.com/winterlightlabs/bucket-antivirus-function/pull/17


[Feature] We need a Hypertrons component for case study report.

We may need a Hypertrons component for case study report.
The files in the repo may include:

A folder contains all case study files include a report template and a config file for the case study.
A folder contains all SQL components for all case study report under SQL folder.

And the component should run every day to update all case study reports and create PR to submit all the reports. May refer to https://github.com/X-lab2017/github-analysis-report/tree/master/.github/hypertrons-components/auto_update_report .

/self-assign

Closed by #255


Fixed bug where squaring values wouldn't enforce positivity

I can't think of example where squaring a number would give negative value except comples numbers, eg. sqrt(-1). Could you provide an example, please?

I'll be honest this was a year ago and I don't have any of the data I was running through at the time, so I don't have an example (or any specific idea of what caused negative values.) A complex number being produced by the pipeline makes sense as to why negative values would get thrown out by squaring though.

Obviously there is probably no audio waves with complex numbers but I came to the idea that your array could have been square-rooted before processing :)

I was about to suggest closing this pull request, as even the original author cannot verify where or why the code failed.
Then I found a thread that may throw some light on the issue.
Might it be that there was overflow during taking a root of a signal, as discussed here.
If not, then maybe closing this PR is appropriate.

I thought I had closed it, sorry about that.


Adding new event taskAssigned whenever there will be atomicChanged

This is required to support AIM specific Agent Scheduler, because we are already maintaining current client in DDS after this SB will won't use another DDS to do the same.

@Dhoot Can you elaborate on the intended usage?  In general, the AgentScheduler's design intentionally tries to mask the election process and the status of other clients.  We may choose to alter this election process in the future (reducing null writes, staggering volunteer timing, etc.) which today would be invisible to the user but with this change would result in a customer-visible behavior change.

@ChumpChief : currently AgentScheduler only emits to client who has picked the task and to share leader information with all another clients we need to keep leader's information in DDS.
but, for read-only leader selection we are implementing IAgentScheduler but here we can't use DDS that's why we need to emit taskAssigned to all connected clients, also keep getTaskClientId as public se that instead of keeping leader information in DDS for any taskId we can directly fetch it from AgentScheduler  which is already maintaining this information in consensusRegisterCollection

I'd suggest you consider writing a separate task assignment tool from AgentScheduler for that purpose.  As I mentioned above, AgentScheduler's design is to explicitly try to mask the selection process for write clients, so the requirement for read clients to inspect the selection process is fairly counter to its goal.
Aside from growing the API surface to maintain, the exposure of the selection process would cause improvements to that selection process to become breaking changes.  For instance, it would be easy for some customer to develop a dependency on null client signifying a task being released.  However we'd like to reduce or eliminate the null client behavior to reduce COGS, which would then break those downstream customers.
Ultimately AgentScheduler is just an API wrapper around a ConsensusRegisterCollection, so if inspection of the collection is a goal then you can probably devise a more ergonomic API wrapper for your scenario (e.g. directly emitting events to signify that no eligible owner is present).

forking Agent Scheduler as required changes might create problem with future development in it.


'weave ps' fails with "Cannot find weave bridge: Link not found"

... even if the weave bridge exists:
weave     Link encap:Ethernet  HWaddr 06:c2:01:12:41:d5
          inet addr:<IP_ADDRESS>  Bcast:<IP_ADDRESS>  Mask:<IP_ADDRESS>
          inet6 addr: fe80::4c2:1ff:fe12:41d5/64 Scope:Link
          UP BROADCAST RUNNING MULTICAST  MTU:1410  Metric:1
          RX packets:732925 errors:0 dropped:0 overruns:0 frame:0
          TX packets:1016150 errors:0 dropped:0 overruns:0 carrier:0
          collisions:0 txqueuelen:0
          RX bytes:597366797 (597.3 MB)  TX bytes:2877166348 (2.8 GB)

This happened when running a local instance of the scope service (kubernetes anywhere).
Running with bash -x I get:
+ docker run --rm --privileged --net=host -v /var/run/docker.sock:/var/run/docker.sock --pid=host -e DOCKERHUB_USER=weaveworks -e WEAVE_VERSION -e WEAVE_DEBUG -e WEAVE_DOCKER_ARGS -e WEAVEPROXY_DOCKER_ARGS -e WEAVEPLUGIN_DOCKER_ARGS -e WEAVE_PASSWORD -e WEAVE_PORT -e WEAVE_HTTP_ADDR -e WEAVE_CONTAINER_NAME -e WEAVE_MTU -e WEAVE_NO_FASTDP -e WEAVE_NO_BRIDGED_FASTDP -e WEAVE_NO_PLUGIN -e DOCKER_BRIDGE -e DOCKER_CLIENT_HOST= -e DOCKER_CLIENT_ARGS -e PROXY_HOST=<IP_ADDRESS> -e COVERAGE -e CHECKPOINT_DISABLE weaveworks/weaveexec:1.5.2 --local ps
Cannot find weave bridge: Link not found

Output when running the docker command above with WEAVE_DEBUG=1: https://gist.github.com/2opremio/cfe5c7fa236854e9963dda0f8afc5754
Some details about my system:
$ uname -a
Linux vagrant-ubuntu-wily-64 4.2.0-36-generic #42-Ubuntu SMP Thu May 12 22:05:35 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux

$ docker version
Client:
 Version:      1.10.2
 API version:  1.22
 Go version:   go1.5.3
 Git commit:   c3959b1
 Built:        Mon Feb 22 21:40:35 2016
 OS/Arch:      linux/amd64

Server:
 Version:      1.10.2
 API version:  1.22
 Go version:   go1.5.3
 Git commit:   c3959b1
 Built:        Mon Feb 22 21:40:35 2016
 OS/Arch:      linux/amd64

@2opremio Are you able to reproduce the issue? Maybe you have an output of dmesg?
From inspecting the netlink library, I can see that "Link not found" might be returned only in two cases and by the same function. The second case is more interesting, because it might not necessary mean that a link does not exist.

I can't reproduce with my computer in Spain (different Docker/Weave versions). I can reproduce systematically with my laptop in London but I would have to wait until Monday.
In the mean time, I think @jml can (he shows exactly the same error in https://github.com/weaveworks/scope/issues/1599 )

As I've already mentioned in Slack, the root cause is the WithNetNS function.
During execution of work() or before defer netns.Set(oldNs), due to e.g. blocking syscall, the Go runtime might create an OS thread (child) via clone(2) w/o CLONE_NEWNET, which means that the child is going to reside in the same network namespace as its parent. The child is used to schedule go-routines and thus, any go-routine run by the child will be in the "wrong" network namespace.
In the Linux kernel, each netdev is associated only with exactly one network namespace.  Therefore, the "weave" bridge cannot be seen from a container which network namespace != host network namespace.
The error you get is due to https://github.com/weaveworks/weave/blob/v1.6.0/common/utils.go#L108 being executed on a thread which entered container network namespace which is not associated with the "weave" bridge netdev.
As an evidence, please check the following strace output:
<...>
[pid  3361] openat(AT_FDCWD, "/proc/17526/ns/net", O_RDONLY) = 61
[pid  3361] getpid()                    = 3357
[pid  3361] gettid()                    = 3361
[pid  3361] openat(AT_FDCWD, "/proc/3357/task/3361/ns/net", O_RDONLY) = 62
[pid  3361] setns(61, CLONE_NEWNET)     = 0
<...>
[pid  3361] <... clone resumed> child_stack=0x7f19efffee70, flags=CLONE_VM|CLONE_FS|CLONE_FILES|CLONE_SIGHAND|CLONE_THREAD|CLONE_SYSVSEM|CLONE_SETTLS|CLONE_PARENT_SETTID|CLONE_CHILD_CLEARTID, parent_tidptr=0x7f19effff9d0, tls=0x7f19effff700, child_tidptr=0x7f19effff9d0) = 3365
<...>
[pid  3365] sendto(65, "\x2c\x00\x00\x00\x12\x00\x05\x00\x75\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x0a\x00\x03\x00\x77\x65\x61\x76\x65\x00\x00\x00", 44, 0, {sa_family=AF_NETLINK, pid=0, groups=00000000}, 12) = 44
[pid  3365] getsockname(65, {sa_family=AF_NETLINK, pid=3357, groups=00000000}, [12]) = 0
[pid  3365] recvfrom(65, "\x40\x00\x00\x00\x02\x00\x00\x00\x75\x00\x00\x00\x1d\x0d\x00\x00\xed\xff\xff\xff\x2c\x00\x00\x00\x12\x00\x05\x00\x75\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x0a\x00\x03\x00\x77\x65\x61\x76\x65\x00\x00\x00", 4096, 0, {sa_family=AF_NETLINK, pid=0, groups=00000000}, [12]) = 64
[pid  3365] close(65)                   = 0
[pid  3358] <... select resumed> )      = 0 (Timeout)
[pid  3365] write(2, "Cannot find weave bridge: Link not found\n", 41

The 3365 process does the RTM_GETLINK rtnetlink request for the "weave" bridge interface which is not found. The 3365 process is created by the 3361 process which entered the /proc/17526/ns/net network namespace (of some container) before cloning, therefore the 3365 process is running in the /proc/17526/ns/net netns as well.

To reproduce the issue (on my machine - 4.6 / 1.11.2), I start 32 containers (for i in $(seq 1 32); do docker $(weave config) run --name "c$i" -td alpine /bin/sh; done) and runweave ps multiple times (for i in $(seq 1 100); do weave ps; done).

This is basically the same as https://github.com/docker/libnetwork/issues/1113, which any Go program calling Syscall(SYS_SETNS) will (eventually) fall victim to.

I found this via https://www.weave.works/blog/linux-namespaces-and-go-don-t-mix.
This snippet:
     runtime.LockOSThread()
     defer runtime.UnlockOSThread()
     hostNetNs, _ := netns.Get()
     netns.Set(ns)

     links, _ := netlink.LinkList()
     fmt.Println(filterAttachedLinks(links, indexes))

     // Return to the host network namespace
     netns.Set(hostNetNs)

is a perfect illustration of erroneous usage of runtime.UnlockOSThread (as described in https://github.com/golang/go/issues/20458).
netlink.LinkList is most likely unlocking your thread, so the second netns.Set may be switching threads when you don't expect it.

@bcmills we think the most likely explanation is the one we observed: a new OS thread is started inside the locked region, which inherits the changed namespace, and when other goroutines are then scheduled onto that thread they are in the that other namespace.


Reduce the scope of the variables and make one of them immutable

Why? I think it’s highly likely that this doesn’t change anything speed/memory wise?

Yeah, I don't know. I usually think it is better to reduce the scope of the variables to make it easier to understand the code.
Especially the one that can be immutable.
In any case, I was just reading the code for my enjoyment. So feel free to leave this open or close this PR.

It’s like this because it’s like the C version: https://github.com/wooorm/levenshtein.c/blob/ca084af84e591ec126093dc1607c235fbf00d6db/levenshtein.c#L27-L33

Thanks!


Console error: ProjectTable received an unexpected slot "default".

Describe the bug
While looking at the console on the org page, I noticed a console error <ProjectTable> received an unexpected slot "default".
I think I know what's causing this and it will be a quick fix, but I'm in the middle of a different PR that I want to wrap up first.
To Reproduce
Steps to reproduce the behavior:

Go to http://localhost/org/292c80e6-a815-4cd1-9ea2-34bd01274de6
Open the console

Finished the other code I was working on, so fixed this rather than leave it hanging.


Add (dev) discussion space for Wegue project

Currently the contact for information/support for Wegue is an email address. In order to engage at least developers, having some kind of common discussion space would be nice.
A mailing list is IMHO a bit old-fashioned. I use/like Gitter a lot, as it can be coupled to a single GH repo, also listing repo-activities like commits etc. But also Slack or even Telegram-groups are used these days.  @chrismayer you can make a choice what suits you if you think such a discussion space is useful.

I agree that a dev talk space besides an email-adress for the project would be nice.
I am a bit afraid that a kind of chat implies immediate responses all the time. Email-List are more asynchronous and no one would expect to have an immediate response. Reason is that I cannot hang around at the chat channel all the time. The question is: Will it be expected or can such a chat platform like gitter also used more asynchronous or will it frustrate people, who are writing there?
From the technical side: I did not use any of the platforms you listed. So I would be happy if you could recommend something. The integration of gitter into github (or vice versa) sounds good. Any disadvantages?

Ok, understood. I think Gitter is mostly geared at developers and more relaxed in that folks don't expect immediate responses (as they are all busy developers!) like in regular chat channels, also since the history is largely preserved. Plus any GH activity (e.g. commits, issues) can be displayed as option, so one can see that something is going on.My thought was that it would maybe even save you time, for e.g. announcements (like e.g. you are working on personal  branch for 1.0), instead having 1-1 emails.

OK, thanks for the details. Sounds like it would be worth a try using gitter.

I just created a gitter community for Wegue. @justb4 you should have received an invitation.

Super, joined! You may want to add now or later a badge to the README.md like

[![Join the chat at https://gitter.im/wegue/community](https://badges.gitter.im/Join%20Chat.svg)](https://gitter.im/wegue/community)

and you may want to couple GitHub events to the Gitter room, in Settings.

Badge is added to the README.
I also registered some events. Not sure if it works correctly since we had no events so far. But we will see...

Good! Events work, seen mention of your last comment. Closing this issue, ok? Trying get some (Heron-) devs engaged. Let's see how this goes.


iOS / macOS Safari Push API Support

Hi!
What is the status of support notification delivery using W3C standards-based Web Push for iOS and macOS Safari?

macOS Ventura / Safari 16.1 and up have support.
iOS 16.4 (currently beta) Safari added support recently.

Per the guidance from Apple here, it looks like the websites should move forward with adapting the W3C standard notification implementation (even though Safari on macOS supports both)
In my testing on iOS 16.4 beta, Apple did not add the old Safari-specific APIs (window.safari.pushNotification is not defined).
When playing around with the newest @pusher/push-notifications-web libraries, I ran into the following issues:

2.0.0-beta.2: Works as intended on macOS Safari, but does not work on 16.4 beta iOS Safari (since it seems to use the old safari notifications APIs)
2.0.1: Doesn't work on either iOS or macOS, since the library identifies via the user-agent that the browser is Safari, and leaves a console warning identifying lack of support.

As an attempted workaround, I spoofed the user-agent to match a few different supported browsers, but receive an error Push service endpoint not supported. The push subscription might be from an unsupported browser. The API call to fetch the web-vapid-public-key seems to work just fine, but the subsequent call to https://instance_id.pushnotifications.pusher.com/device_api/v1/instances/instance_id/devices/web fails with a 400 BAD_REQUEST.

Obviously this stuff takes time to build, and these changes are pretty new on Apple's part, so this is all to be expected. I was just looking to open a discussion and share what I've found so far.

I just want to pop in to ask the team if there's any update on this at all? This is a massive update for PWA on iOS and we'd love to know whether this will be supported by Pusher or not.
We still get Could not add Device Interest. SDK not registered errors when using this on MacOS and iOS.

At this time we are not able to commit to support for Push API support on iOS / Safari.

Why is this? Firebase FCM looks like it has support for this already which we will probably have to move to as an alternative.
I've also noticed macOS Safari notifications aren't working since upgrading to Ventura. Could this be due to macOS Safari now using the Push API instead of the old Safari notification API?


[melodic] Compatibility fix for OGRE 1.10.4 and up.

A recent lint fix causes a build break when building RViz with OGRE v1.10.4 and up.
This pull request is attempting to make the RViz to be compatible with  OGRE 1.10.4 and up again. And here is some context:
Since OGRE v1.10.4, the signature of OgreMovableObject::getName is no longer a virtual function. To accommodate that, conditionally declare the matched signature of getName() for rviz::MovableText.

@rhaschke This is ready for review and merge. Thanks!

Thanks for this fix, @seanyen. However, I applied it to the noetic-devel branch only, as only there we have guarantee compatibility with newer versions of Ogre (and we can use the OGRE_VERSION_CHECK macro).


Alvr v14.2.1 Oculus Quest 2 not working

Every time I try to use ALVR v14.2.1 on my Oculus Quest 2, this message pops up and Steam VR just doesn't work. Can someone please help! I have attached the error message and my computer stuff.

hello what graphic card do you have ?

hello what graphic card do you have ?

How do I find this on Windows 10?

hello what graphic card do you have ?

Nevermind, I found it, it is an "Intel(R) UHD Graphics 620"

does ALVR crash on launch or on connect ? is there any log on the log file (crash.log or something like this).

ALVR does not support Intel GPUs.

does ALVR crash on launch or on connect ? is there any log on the log file (crash.log or something like this).

It crashes when I start the server.

ALVR does not support Intel GPUs.

Oh. well that stinks, but thanks!

ALVR does not support Intel GPUs.

Oh. well that stinks, but thanks!

we know ... it is a decoder problem.


UpdateBuilder use Nonparametric statement cause sql injection problem

This is my code
 UpdateBuilder<AudioFile, String> updateBuilder = AudioFileDao.getDao().updateBuilder();
 updateBuilder.updateColumnValue(AudioFile.PERCENTAGE, 100);
 updateBuilder.updateColumnValue(AudioFile.EXTRACT_TIMESTAMP, System.currentTimeMillis());
 updateBuilder.updateColumnValue(AudioFile.PROGRESS_STATUS, AudioExtractUtil.PROGRESS_STATUS_EXTRACT_FINISHED);
 updateBuilder.updateColumnValue(AudioFile.AUDIO_FILE_URL, model.getAudioPath());
 updateBuilder.where().eq(AudioFile.ID, model.getId());
 updateBuilder.update();

and the value of
 model.getAudioPath()

is
/storage/emulated/0/Android/data/wudao.com.chinadance.video/files/audio东方舞《EhtartMa'ak》异域风情太柔美了-【单色舞蹈】(成都)晋阳路馆东方舞兴趣班展示(2021991824)21836.mp3
and the sql injection problem is caused by ' in《EhtartMa'ak》
the following code is the sql which generated by UpdateBuilder
UPDATE `AudioFile` SET `percentage` = 100 ,`extractTimestamp` =<PHONE_NUMBER>572 ,`progressStatus` = 3 ,`audioFileUrl` = '/storage/emulated/0/Android/data/wudao.com.chinadance.video/files/audio东方舞《EhtartMa'ak》异域风情太柔美了-【单色舞蹈】(成都)晋阳路馆东方舞兴趣班展示(2021991947)8710.mp3' WHERE `id` = '90A4F941483C4DCB9C787761A67D6319'

and from my research this sql is generated by com.j256.ormlite.stmt.StatementBuilder.buildStatementString

I don't see how this is related to Ormlite? It seems the model's data is what you wrote, so the getter (of the model) returns that value.

I'm not 100% sure what you are asking but I think you need to use the SelectArg class.  Just had another question like this here: https://github.com/j256/ormlite-core/issues/219

What I encountered was the SQL injection problem that occurred when the user input string (including ') was updated to the database through UpdateBuilder, and SelectArg was the correct way to solve this problem, thank you for your help


fix: Determine local time as early as possible

The offset between local time and UTC can only be determined when
only a single thread is running. If it's done with multiple threads,
it will fail.
This PR changes all tools to determine the offset once at the beginning,
and then store it.

Changelog check fails because the main probe-rs changelog is untouched, this issue only touches the binary tools.


Xero - Strange animation after dismissing 2FA setup RHP and not here page on LHN

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 9.0.8-1
Reproducible in staging?: Y
Reproducible in production?: N
Found when validating PR : https://github.com/Expensify/App/pull/44059
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team
Action Performed:
Precondition:

User has a workspace.
The workspace is connected to Xero.
User has not set up 2FA.

Go to staging.new.expensify.com
Log out if logged in.
Log in to the account from precondition.
Click Enable two-factor authentication.
Click the back button on 2FA set up RHP.
Navigate between Account settings, Search and Inbox.

Expected Result:
App should throw 2FA set up modal again if user exits 2FA set up flow.
Actual Result:
In Step 5, when clicking on back button on 2FA setup RHP, the RHP dismissal has a weird animation.
In Step 6, after switching between sections, not here page shows up on the left hand panel.
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

Screenshots/Videos
https://github.com/user-attachments/assets/f5c50571-fcb7-453e-b0b5-dd15cf31ec23

View all open jobs on GitHub

We think this issue might be related to the #collect project.

Commented on the offending PR https://github.com/Expensify/App/pull/44059

The issue is present after reverting this PR too. its unrelated to the PR and related to navigation

Ok thanks for checking!

The issue is present after reverting this PR too.

@rushatgabhane if we revert this PR, then the 2FA modal doesn't show up and looks like issue is not reproducible?

@MonilBhavsar let me rephrase what i mean - this same issue is present on production also. The PR above did not make any changes to how back navigation was handled

Go to https://new.expensify.com/settings/security/two-factor-auth?backTo=home
Click back

https://github.com/user-attachments/assets/a228ff3e-5722-40cb-adb2-a0c31277ac4d

Ok thanks for clarifying. Makes sense

im happy to help, but i don't have the fix yet

Proposal
Please re-state the problem that we are trying to solve in this issue.
Dismissing 2FA RHP gives weird animation and shows not here page on LHN.
What is the root cause of that problem?
When we press back, we will use the backTo as the fallback route.
https://github.com/Expensify/App/blob/c82183bca6338758888ca9e43591fc1f11234928/src/pages/settings/Security/TwoFactorAuth/Steps/CodesStep.tsx#L57
The fallback route is set to HOME.
https://github.com/Expensify/App/blob/c82183bca6338758888ca9e43591fc1f11234928/src/Expensify.tsx#L272
Using HOME as the fallback route will lead to the weird animation and it's a known issue which is previously fixed in https://github.com/Expensify/App/pull/36050 where we remove all HOME from the fallback route.
What changes do you think we should make in order to solve the problem?

Since users can manually edit the backTo to home as shown in the comment here, I think the best solution is to set the fallback to an empty string if it's HOME.
if (fallbackRoute === ROUTES.HOME) {
    fallbackRoute = '';
}

or if the fallback route is HOME, we pop every screen on the stack

@bernhardoj Thanks for the proposal.
Both your solutions not back me to home page. The first back me to settings/security, and the second using StackActions.popToTop() back to settings/profile. Did I missed something?

In this case, we want to take the user to home page

Do we want to navigate the user back from the 2FA page?

Yes, I think that.

are we fixing the animation issue somewhere?

The issue in not only in animation, the center pane also seems empty because the route /home doesn't redirect to last opened report

the center pane also seems empty because the route /home doesn't redirect to last opened report

Our navigation currently prioritizes the UP type which will replace the current route with the destination route. In this case, the 2FA RHP is replaced with HOME, which is a BOTTOM TAB SCREEN (LHN), that's why the report screen is blank.
if (type === 'UP') // change the action to REPLACE
else if (destination === bottom tab screen) {
    // 1. Push the bottom tab screen
    // 2. Push the matched central pane screen, in this case, a report screen
}

Because we want the HOME to show when the backTo is home, we can fix this by moving down the `type === 'UP' condition and also handle it inside the bottom tab condition.
if (destination === bottom tab screen) {
    // 1. Push the bottom tab screen
    // 2. If type is UP, replace the current screen with the matched central pane screen
    // Else, push the matched central pane screen
} else if (type === 'UP) // change the action to REPLACE

However, there is another issue. After navigating to the LHN/HOME, pressing the settings page again will show a blank profile page. The profile page exists and is active in the nav stack, but it is just blank and you can see the tooltip never hides and there is no hover color at all. I remember seeing the blank issue that is caused by the react-compiler, but I can't find the issue link.
https://github.com/user-attachments/assets/0cf4fc9c-c95b-4d63-880f-9f9c298f40fb

i suggest that we hold on

i can't reproduce on it

https://github.com/Expensify/App/pull/46087 was merged into main, and the issue is still reproduced on latest main

Waiting on proposals

Waiting on proposals

Waiting on proposals

Waiting on proposals

Are we not evaluating @bernhardoj's?

Sorry, I missed giving feedback on the last comment.

I remember seeing the blank issue that is caused by the react-compiler, but I can't find the issue link.

@bernhardoj Do you found the issue link? We need to confirm the blank profile screen is fixed and not a regression from your solution.

I can't find the one that I meant, but there is a new issue created that is very similar https://github.com/Expensify/App/issues/47041

@bernhardoj I retest your fix again today, and it seems the blank issue is not reproduced now with your fix and last main. Can you confirm?
The tooltip freezing issue still reproduced, but it also reproduced on the last main if you keep "security" screen opened and jump to tab "inbox" then tab "profile settings"
Your fix now works fine, can you please test it well, and it doesn't cause any errors on other navigations, then update your proposal?

@bernhardoj bump for https://github.com/Expensify/App/issues/45572#issuecomment-2278059375

and it seems the blank issue is not reproduced now with your fix and last main. Can you confirm?

Yeah, same.

Your fix now works fine, can you please test it well, and it doesn't cause any errors on other navigations, then update your proposal?

Since the changes affect navigating to BOTTOM TAB screens with the type of UP, I searched for all usages of goBack with the fallback route of each bottom tab route (SETTINGS, HOME, SEARCH) or navigate with a type of UP.
For HOME, there is another usage other than what we have in this issue.
https://github.com/Expensify/App/blob/86da342bdc00960903cb5a5b75730f8b07b7f667/src/libs/Navigation/AppNavigator/Navigators/OnboardingModalNavigator.tsx#L47-L49
But the fallback route is never used because we pass shouldPopToTop as true.
https://github.com/Expensify/App/blob/86da342bdc00960903cb5a5b75730f8b07b7f667/src/libs/Navigation/Navigation.ts#L198-L204
For SETTINGS,

About page
https://github.com/Expensify/App/blob/86da342bdc00960903cb5a5b75730f8b07b7f667/src/pages/settings/AboutPage/AboutPage.tsx#L138
The fallback route is never used because isFirstRouteInNavigator is false.
https://github.com/Expensify/App/blob/86da342bdc00960903cb5a5b75730f8b07b7f667/src/libs/Navigation/Navigation.ts#L222-L225

Troubleshoot page
https://github.com/Expensify/App/blob/86da342bdc00960903cb5a5b75730f8b07b7f667/src/pages/settings/Troubleshoot/TroubleshootPage.tsx#L113
Same as above

Wallet empty state
https://github.com/Expensify/App/blob/86da342bdc00960903cb5a5b75730f8b07b7f667/src/pages/settings/Wallet/WalletEmptyState.tsx#L44
Same as above

For SEARCH,
2 usages in the search page itself, both for large (SearchPage) and small screen (SearchPageBottomTab)
https://github.com/Expensify/App/blob/86da342bdc00960903cb5a5b75730f8b07b7f667/src/pages/Search/SearchPage.tsx#L38-L41
https://github.com/Expensify/App/blob/86da342bdc00960903cb5a5b75730f8b07b7f667/src/pages/Search/SearchPageBottomTab.tsx#L54-L56
But I don't know how to trigger the not found page here.
However, when I test to open the 2FA and change the backTo to settings, it does nothing. It's because, if we are trying to navigate to the same bottom tab screen, it will do nothing.
https://github.com/Expensify/App/blob/86da342bdc00960903cb5a5b75730f8b07b7f667/src/libs/Navigation/linkTo/index.ts#L153-L157
https://github.com/Expensify/App/blob/86da342bdc00960903cb5a5b75730f8b07b7f667/src/libs/Navigation/linkTo/getActionForBottomTabNavigator.ts#L36-L38
Maybe we can ask SWM to add support of fallback route to bottom tab screen.

@bernhardoj Thanks for all the context and details.

Maybe we can ask SWM to add support of fallback route to bottom tab screen.

I think we need to do that. Although using push instead replace will display the correct route, it will push a new route, and if the user click on browser arrow back button, it will back again to 2FA modal
https://github.com/user-attachments/assets/6d1d6422-d2de-46bd-97b1-daeaf0e7a03c
@MonilBhavsar what do you think of asking SWM to handle this?

@VictoriaExpensify @MonilBhavsar we don't have accepted proposals yet, I think we can share this issue with SWM instead of waiting for new proposals, They always handle the navigation issues.

Waiting on proposals.

@VictoriaExpensify @MonilBhavsar we don't have accepted proposals yet, I think we can share this issue with SWM instead of waiting for new proposals, They always handle the navigation issues.

CC @adamgrzybowski

what do you think of asking SWM to handle this?

Let's get some thoughts 👍  I see you have tagged Adam Grzybowski

Hey guys, we are currently working on some changes to the navigation that will influence how the goBack works. My question is how urgent is this fix?  We can work on some solution, but it will probably be discarded after these changes.
BTW Maybe as a simple fix, we can just not use the HOME as a param for the goBack function? We could use a combination of dismissModal and navigate to HOME?

Not overdue, we are still discussing the solution

@MonilBhavsar What do you think https://github.com/Expensify/App/issues/45572#issuecomment-2307184808

Not overdue

@MonilBhavsar What do you think https://github.com/Expensify/App/issues/45572#issuecomment-2307184808?

bump @adamgrzybowski :

Yeah I don't think this is urgent @adamgrzybowski . I think it makes sense to put this on the back-burner and revisit it once the other navigation changes are in place. Do you have a GH for those changes that we can reference here?

we are currently working on some changes to the navigation that will influence how the goBack works. My question is how urgent is this fix? We can work on some solution, but it will probably be discarded after these changes.

What changes are these, and can you link an issue? I don't think this is super pressing, but If we're putting it on hold, let's make sure that's reflected in the issue title.

Ok I think this is the issue @adamgrzybowski was referencing - https://github.com/Expensify/App/issues/47534
He's gone ooo and that issue has been changed to monthly, so I think we're safe to put this on hold for now

Not OD, this is on hold

As above. Making this a monthly as that's what the related issue is

Proposal
Please re-state the problem that we are trying to solve in this issue.
Xero - Strange animation after dismissing 2FA setup RHP and not here page on LHN
What is the root cause of that problem?
First let split this problem into 2 issues.

Why the sidebar had strange animation moving from right to left
Why only sidebar is displaying and where is the main chat?

When we have a backTo param inside our url which is HOME, currently we're showing Sidebar component for HOME page inside BottomTabNavigator.tsx file
https://github.com/Expensify/App/blob/3047c1baa21f47825f5c1ffd652184341dd22256/src/libs/Navigation/AppNavigator/Navigators/BottomTabNavigator.tsx#L26-L29
But why we see a strange animation for Home sidebar since we disabled it here: https://github.com/Expensify/App/blob/3047c1baa21f47825f5c1ffd652184341dd22256/src/libs/Navigation/AppNavigator/Navigators/BottomTabNavigator.tsx#L16-L19
Because we invoked the BottomTabNavigator inside AuthScreens and enabled the animation here
https://github.com/Expensify/App/blob/3047c1baa21f47825f5c1ffd652184341dd22256/src/libs/Navigation/AppNavigator/AuthScreens.tsx#L223
https://github.com/Expensify/App/blob/3047c1baa21f47825f5c1ffd652184341dd22256/src/libs/Navigation/AppNavigator/AuthScreens.tsx#L412-L416
https://github.com/Expensify/App/blob/3047c1baa21f47825f5c1ffd652184341dd22256/src/libs/Navigation/AppNavigator/getRootNavigatorScreenOptions.ts#L125-L127
We can see here that the animation is enabled, I've tried disabling the animation and it solved the first issue (sidebar strange animation)
https://github.com/Expensify/App/blob/3047c1baa21f47825f5c1ffd652184341dd22256/src/libs/Navigation/AppNavigator/getRootNavigatorScreenOptions.ts#L21-L27

Why the main chat is not displaying?, because we use getMatchingCentralPaneRouteForState function to display the central pane route for bottom tab navigator i.e for HOME page we will display Report chat.

And for navigation i think we use linkTo function and we invoke the  getMatchingCentralPaneRouteForState inside the linkTo function if it does not match these 3 conditions
https://github.com/Expensify/App/blob/3047c1baa21f47825f5c1ffd652184341dd22256/src/libs/Navigation/linkTo/index.ts#L95
https://github.com/Expensify/App/blob/3047c1baa21f47825f5c1ffd652184341dd22256/src/libs/Navigation/linkTo/index.ts#L122
https://github.com/Expensify/App/blob/3047c1baa21f47825f5c1ffd652184341dd22256/src/libs/Navigation/linkTo/index.ts#L130
If the above 3 conditions are false we will invoke the getMatchingCentralPaneRouteForState inside this condition
https://github.com/Expensify/App/blob/3047c1baa21f47825f5c1ffd652184341dd22256/src/libs/Navigation/linkTo/index.ts#L151
But when pressing the go back button we use the goBack function which uses the CONST.NAVIGATION.TYPE.UP type which leads this condition to true
https://github.com/Expensify/App/blob/3047c1baa21f47825f5c1ffd652184341dd22256/src/libs/Navigation/linkTo/index.ts#L122
https://github.com/Expensify/App/blob/3047c1baa21f47825f5c1ffd652184341dd22256/src/libs/Navigation/Navigation.ts#L235 and here
https://github.com/Expensify/App/blob/3047c1baa21f47825f5c1ffd652184341dd22256/src/libs/actions/TwoFactorAuthActions.ts#L21-L24
and will not invoke the getMatchingCentralPaneRouteForState function
What changes do you think we should make in order to solve the problem?
Instead of using goBack function we can use navigate here
Navigation.navigate(backTo)
https://github.com/Expensify/App/blob/3047c1baa21f47825f5c1ffd652184341dd22256/src/libs/actions/TwoFactorAuthActions.ts#L21-L24
Result
https://github.com/user-attachments/assets/3fce7d44-c741-4358-966a-8f186c3625be
What alternative solutions did you explore? (Optional)

@ahmedGaber93 Can you please kindly take a look at my proposal

@NJ-2020 use navigate instead of goBack is already proposed by adamgrzybowski here https://github.com/Expensify/App/issues/45572#issuecomment-2307184808 as a workaround, but we decide to wait for fixing goBack https://github.com/Expensify/App/issues/45572#issuecomment-2316788510.

@VictoriaExpensify I think we need to add monthly label because we hold it for monthly issue https://github.com/Expensify/App/issues/47534

@VictoriaExpensify bump https://github.com/Expensify/App/issues/45572#issuecomment-2397601319

Adjusted label, thanks!


Policy on signed documents after signature key is revoked

We support key revocation.
We have many documents that we host that are signed using those keys. These include:

Presentation Request
Credential Manifests
Credentials
Schemas
(unsure if there are more).

We need to decide what to do with those documents once the key used to sign them was revoked. Some alternatives include:

Revoking the documents (if they support a revocation mechanism).
Resigning the documents (e.g. credentials have the refreshService).
Delete the docs.
Do nothing.
Retain them but not return them (sof delete).

related to #451


Fix default name of device connection cache

Type of change

Bugfix

Description

Checklist

[ ] Update/write design documentation in ./documentation/design
[ ] Write tests and make sure they pass
[ ] Update documentation
[ ] Check RBAC rights for Kubernetes / OpenShift roles
[ ] Try your changes from Pod inside your Kubernetes and OpenShift cluster, not just locally
[ ] Reference relevant issue(s) and close them after merging
[ ] Update CHANGELOG.md

@enmasse-ci run tests profile=iot testcase=InfinispanDeviceRegistryTest crc

:heavy_check_mark: Test Summary :heavy_check_mark:
TEST_PROFILE: iot
TEST_CASE: InfinispanDeviceRegistryTest
TOTAL: 30
PASS: 28
FAIL: 0
SKIP: 2
BUILD_NUMBER: 643
BUILD_ENV: crc


Uncaught Error: Cannot find module 'flash'

Error in rtmp.min.js
Browser: Chrome 44
Pepper Flash is disabled (built-in 'click to flash'), but is installed. In other players I see gray block with text "Press Ctrl+Click to enable Flash module", but in this case Clappr with RTMP-module crashes. Native Clappr (w/out RTMP plugin) works fine.

Having same problem. Saw on another issue that this plugin is not compatible with 0.2.x version yet.
is that the cause for this issue?

This plugin is broken with latest version of Clappr, try:
<script type="text/javascript" src="http://cdn.clappr.io/0.1.13/clappr.js"></script>

instead.

hey @ebuildy and @sc0rp10, thanks to @dayvson we have an updated version of the plugin. You can use http://cdn.jsdelivr.net/clappr.rtmp/latest/rtmp.min.js to point to the plugin and you'll get 0.0.7 which is compatible with latest clappr!