azd up hangs on importing api definitions

Please provide us with the following information:

This issue is for a: (mark with an x)
- [x] bug report -> please search issues before submitting
- [ ] feature request
- [ ] documentation issue or request
- [ ] regression (a behavior that used to work and stopped in a new release)

Minimal steps to reproduce

Fork repo
Clone to local machine
azd auth login
az login
azd up

Any log messages given by the failure

No failure messages. Simply hang for a very long time and does not complete. 19 total resources provision successfully including APIC and APIM. APIC has 3 APIs. APIM has 1. An Entra ID app registration exists without a corresponding principal. Also noticed that the APIC portal has deployed however, when signing on to it, no APIs show up.

Expected/desired behavior

azd up completes and user has access to APIC portal APIs, then exercises the APIC analyzer feature.

OS and Version?

Windows 10 Pro for Workstations. Version 10.0.19045

Versions

PowerShell 7.4.3, AZ 2.46.0, ACD 1.9.5

Mention any other details that might be useful
I attempted this multiple times.

Thanks! We'll be in touch soon.

Thanks @jharbieh we'll reproduce the error on our end.

@jharbieh I wasn't able to reproduce the same error. Have you tried again after that?

Hey @justinyoo I did on 3 tenants. 2 of them stuck on API import as shown above. The 3rd tenant did not, however, it did not import the API. I assume it was trying to import the APIM USPTO API definition from APIM into APIC. API Center still had 3 APIs. It did actually give me a message. What I can do is azd down and then up and see if I get the message again.

@jharbieh There have been recent updates on the sample

The former will disappear with the latest az apic-extension. Would you please update your az CLI to the latest? az upgrade --allow-preview true
The latter happens with the role assignment. Does your account have enough permissions to assign roles?

Thanks @justinyoo Just ran the CLI upgrade. It seems to have the latest. I will re-do and report back.

As far as permissions, I will run this on another tenant where I am Global Admin and report back. I am a Subscription Owner on where I am trying this out.

Thanks!

Hi @justinyoo I redeployed the reference repo using a Global Administrator account in Entra. The Import API part worked. USPTO API was imported from APIM successfully. Prior to azd up, I made sure the AZ CLI and APIC-Extension are updated.
Other than the need to be a Global Admin for the deployment, we should be good to go here.
Thoughts?
Thanks!

Because you should have permissions to run this command:
https://github.com/Azure-Samples/APICenter-Reference/blob/1f7e1fb7fd1b7e17e579e1b81ffc71d98b7794f7/infra/hooks/postprovision.ps1#L46-L49
I think you should have either "Application Administrator" or "Application Developer" role. The "Application Admin" role can update apps generated by others while the "App Dev" role is only able to update the app generated by themselves.

I confirm that, given that I've only got the "application developer" role, I was successfully able to run azd up with no issue.

Thanks @justinyoo great to know! Thanks for looking into this and confirming RBAC role required for the command.


Allow XHR to file:// and allow local file (upload) handling

Until there is a better solution to setting this property, this solves the XHR and local file api issues.
This issue is described further in https://bugs.webkit.org/show_bug.cgi?id=154916.
Platforms affected

[x] iOS

What does this PR do?

[x] Prevents "Security DOM 18 error" while manipulating files, such as handling file uploads
[x] Prevents "NetworkError (DOM Exception 19):  A network error occurred." while loading files through XHR from file://

What testing has been done on this change?

[x] XHR and file handling

Checklist

[ ] Reported an issue in the JIRA database
[ ] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
[ ] Added automated test coverage as appropriate for this change.

Although I replied to you jokingly on Twitter, let me explain why this is not a good idea, and I'm 100% sure will not be approved by the committers on Apache Cordova based on precedent of trying to add unsupported methods to Cordova from before.
The key word is "unsupported". Apache Cordova cannot rely on an API that is not officially approved by Apple and may go away at any time without a deprecation period, and may cripple existing apps after an iOS update. There is even a warning by an Apple employee (Anders) at the end of that Webkit bug also.

I'm aware of the unsupportedness but I don't think we should give up on this. We all know that 1000s of developers are relying on UIWebView rather than WKWebView just because of this issue.
Honestly I don't understand why the webkit bug hasn't been addressed with higher importance by the Cordova developers...

@rubenstolk:
First, thanks for the contribution!
However, in this instance, I agree with @shazron; the fix may work, but due to the unsupported and undocumented nature of this, it puts all apps built with this engine at far too much risk (both for rejection and future failure). This isn't "giving up", but when Apple says 'don't do it that way', we have to figure something else out. You might try this, which might help in your case.
Of course, the community is free to fork the repository and add the code themselves. If the suggestion above doesn't work, that would be my next suggestion, but of course, that doesn't mean you might not get a rejection from Apple when submitting to the store. For Enterprise stuff that wouldn't matter, but the app might stop working in the future should Apple change how that setting works.

Replaced by https://github.com/apache/cordova-plugin-wkwebview-engine/pull/30


Help with taskbar

I cant right click on my taskbar apps and my taskbar is constantly covering stuff I am on. how can I fix this?

sounds like an os issue, make sure your device is updated

This doesn't sound like an issue from the debloater. In any case, if you found a fix, please close this issue


Add data-bs-dismiss="dropdown" to close dropdown on button click

We have similar options for modal, offcanvas and alert, where components can be dismissed on button click. But there's no way to close dropdown menu with data-bs-auto-close="inside" from the dropdown itself. A simple example would be individual action button like Apply or Close/Cancel in dropdown with a form - user can fill out the form and click Apply to submit the form and close the menu. In that scenario, having an option to dismiss the menu by clicking the button that has data-bs-dismiss="dropdown" would be super handy.

Hi,
I would love to work on this. I'm a first time contributor. Can you help me?

I am not sure it is a valid request.
CC/ @mdo, @rohit2sharma95  your opinions please

I am not sure it is a valid request.

I would disagree, if i may. Now with data-bs-auto-close="inside" we can use dropdowns instead of modals more often, especially when we need to display forms (filters, login/registration forms etc). And "Cancel" or "Close" buttons work as intended in modals and offcanvas, where we also can show same forms. So the ability to click "Close" button within dropdown menu is quite a good thing for more complex use cases

@mdo  Looking forward to this feature.
I have a similar case, I have used dropdown for notifications and want to use it as a fullscreen mobile view. Now I have to close the dropdown from inside then there is no option currently to close the dropdown.

It seems a very unique requirement @Kopyov 😅
But that can be achieved via a small script by attaching the event on the button inside the dropdown menu. Bootstrap already provides javascript methods for flexibility and these kinds of requirements.

Well, closing modals and alerts can be also achieved via a small script, but we have data-dismiss thing for some reason. Why don’t we have it also for dropdowns? 😁

Closing as a won't fix. If folks have suggestions for demos and snippets to add to the docs to show this though, we'd be happy to review and merge.


Permissions do not stay consistent.

Every time the bot restarts, the perms get reset.
EDIT
Custom reactions are all gone too.

O.o Make sure you're not in any of the folders, or have some files or db open in the nadekobot folder. I'm using installer on global Nadeko and it does not overwrite anything.

Ok thanks, I will test around and check to make sure.

We put the command in a while : loop and she is told to start back up 5 seconds after it stops.
Also
.restart is broken. It errored because I would have to give it a filename.

yea restart is removed.
Fearnlj01 is looking into data loss when db is opened.


chore: Update table path param to be a query param

Partially addresses https://github.com/electric-sql/electric/issues/1771

Great thanks! I'll give this a through go over later & double-check docs, examples, etc. and then merge it in

Yeah root_table is useful in Elixir to be really clear about what table it is but since only one table is allowed in a shape request, just calling it "table" everywhere else is cleaner.

Ok, this is ready to go — all examples are tested & gave another look over docs.
Per https://github.com/electric-sql/electric/pull/1796#pullrequestreview-2388639969 we'll just either need to decide on the order of merging.

Not sure where those typescript errors are from — not reproducing locally.

So everywhere we have table in the URL we need to switch to table as a param? Can you shout when this is merged so we can update parallel PRs like deployment docs and Elixir client.

The docs are already updated as part of this PR — we can just release it right away when we merge.

Superseded by #1900


Fix #29 Consolidate target framework between projects and packages

I have updated sources from your repo and ask nuget to reinstall all packages, visual studio did the reset

Thanks for doing this.

 And thank you for VSColorOutput


#448 - Fixed structure of all projects

Description

[x] Added all images into the img folder and also synced the path of the images in the file

List is here:
1.Cool-Front-End-Templates\Apple Webiste UI Clone
2.Cool-Front-End-Templates\Bloggers template
3.Cool-Front-End-Templates\basic_sigin_form
4.Cool-Front-End-Templates\Blog Page for any site
5.Cool-Front-End-Templates\ComingSoon
6.Cool-Front-End-Templates\Covid-19
7.Cool-Front-End-Templates\E commerce shopping website template
8.Cool-Front-End-Templates\Facebook Login Page Clone
9.Cool-Front-End-Templates\Food Website Template
10.Cool-Front-End-Templates\Food-Blog
11.Cool-Front-End-Templates\Food_Template
12.Cool-Front-End-Templates\Github_Homepage_Clone
13.Cool-Front-End-Templates\Glassmorphic Profile Card
14.Cool-Front-End-Templates\glassmorphism-form
15.Cool-Front-End-Templates\Home design
16.Cool-Front-End-Templates\Hotel Website
17.Cool-Front-End-Templates\Instagram Clone Frontend
18.Cool-Front-End-Templates\light-dark-LandingPage
19.Cool-Front-End-Templates-master\Maroom - Interior Design Landing Page
20.Cool-Front-End-Templates\Meet Landing Page
21.Cool-Front-End-Templates\Microsoft-Clone
22.Cool-Front-End-Templates\Neomorphic Portfolio
23.Cool-Front-End-Templates\netflixclone
24.Cool-Front-End-Templates\Newsletter
25.Cool-Front-End-Templates\Obatin - Medicine Landing Page
26.Cool-Front-End-Templates\Personal Website Landing Page
27.Cool-Front-End-Templates\portfolio Avinash
28.Cool-Front-End-Templates\PortFolio Template
29.Cool-Front-End-Templates\Price
30.Cool-Front-End-Templates\Profile-Tree (Linktree Alternative)
31.Cool-Front-End-Templates\Restaurant_Template
32.Cool-Front-End-Templates\simple dark form
33.Cool-Front-End-Templates\Social Media Dashboard
34.Cool-Front-End-Templates\Tourism Template
35.Cool-Front-End-Templates\Tailwind Portfolio
36.Cool-Front-End-Templates\Travel website template-1
37.Cool-Front-End-Templates\We design and develop
38.Cool-Front-End-Templates\web dev proj1 gym
39.Cool-Front-End-Templates\Welcome to lucknow
40.Cool-Front-End-Templates\Whatsapp
41.Cool-Front-End-Templates\Yoga template
42.Cool-Front-End-Templates\Yoga Template 2

[x] Changed image format where preview was in .jpeg/other image format to .png format

[x] Added images where preview.png was not there

List is here:
1.Cool-Front-End-Templates\Apple Webiste UI Clone
2.Cool-Front-End-Templates\ArtGalleryWebsite
3.Cool-Front-End-Templates\Auditions_Page
4.Cool-Front-End-Templates\basic_sigin_form
5.Cool-Front-End-Templates\Blog Page for any site
6.Cool-Front-End-Templates\Bloggers template
7.Cool-Front-End-Templates\Bootcamp Template
8.Cool-Front-End-Templates\Carousel_Landing_Page
9.Cool-Front-End-Templates\Digital Banking
10.Cool-Front-End-Templates\E commerce shopping website template
11.Cool-Front-End-Templates\Facebook Login Page Clone
12.Cool-Front-End-Templates\Food-Blog
13.Cool-Front-End-Templates\Footer-Template
14.Cool-Front-End-Templates\Game_Landing-master
15.Cool-Front-End-Templates\Github_Homepage_Clone
16.Cool-Front-End-Templates\Home design
17.Cool-Front-End-Templates\Instagram Clone Frontend
18.Cool-Front-End-Templates\light-dark-LandingPage
19.Cool-Front-End-Templates\Loaning Website
20.Cool-Front-End-Templates\login and signup page
21.Cool-Front-End-Templates\Meet Landing Page
22.Cool-Front-End-Templates\Microsoft-Clone
23.Cool-Front-End-Templates\Neomorphic Portfolio
24.Cool-Front-End-Templates\Netflix Home Page
25.Cool-Front-End-Templates\Personal Website Landing Page
26.Cool-Front-End-Templates\PortFolio Template
27.Cool-Front-End-Templates\Portfolio-Aryan
28.Cool-Front-End-Templates\Price
29.Cool-Front-End-Templates\Profile-Tree (Linktree Alternative)
30.Cool-Front-End-Templates\project2
31.Cool-Front-End-Templates\restaurant template
32.Cool-Front-End-Templates\Space Agency Template
33.Cool-Front-End-Templates\Starbucks Template
34.Cool-Front-End-Templates\Template Mobile Development Company
35.Cool-Front-End-Templates\Tourism Template
36.Cool-Front-End-Templates\tourism-portal\tourism
38.Cool-Front-End-Templates\Travel website template-1
39.Cool-Front-End-Templates\web dev proj1 gym
40.Cool-Front-End-Templates\WebsiteTemplate
41.Cool-Front-End-Templates\Welcome to lucknow
42.Cool-Front-End-Templates\Whatsapp
43.Cool-Front-End-Templates\Yoga template
44.Cool-Front-End-Templates\ZomatoClone

[x] Added 1st letter of project capital and changed it in json file also

Fixes # (448)
Type of change

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[x] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[x] This change requires a documentation update

Explain the Testing instructions
Test Configuration:

Operating system: Windows
Version: 10
Text-editors used: VS-Code

Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[x] Any dependent changes have been merged and published in downstream modules

@TG922 pull the latest changes and push them

@TG922 pull the latest changes and push them

Ok

I recently checked that the below 3 conflicts created a new issue after the first PR for this issue !!

For the above 3 projects Image path is not synced!!
Results are shown below
Project 1: Cool-Front-End-Templates\AmolShelke-portfolio

Project 2: Cool-Front-End-Templates\Pizza Corner

Project 3: Cool-Front-End-Templates\GymWebsite

I'm Sending PR after updating this

[x] Changed Starting Letter of the project to Capital Name in json files

List is here:

"name": "Engineers Copied Web",
"link": "engineers copied web/index.html"

2."name": "Glassmorphism-Form",
"link": "glassmorphism-form/index.html"
3."name": "Online Grocery- store",
"link": "online grocery- store/index.html"
4."name": "Portfolio Avinash",
"link": "portfolio Avinash/index.html"
5."name": "Simple Dark Form",
"link": "simple dark form/index.html"
6."name": "Netflix Clone",
"link": "netflixclone/index.html"

"name": "Gym Website",
"link": "gymWebsite/index.html"

"name": "Sneaker Storefront",
"link": "sneaker-storefront/index.html"

Only This Project 3: Cool-Front-End-Templates\GymWebsite is having weird messages should I fix this @arpit456jain ??
Style.css File

**Index.html File

[x]  Changed Starting Letter of the project to Capital Name in json files

List is here:

"name": "Engineers Copied Web",
"link": "engineers copied web/index.html"

2."name": "Glassmorphism-Form", "link": "glassmorphism-form/index.html"
3."name": "Online Grocery- store", "link": "online grocery- store/index.html"
4."name": "Portfolio Avinash", "link": "portfolio Avinash/index.html"
5."name": "Simple Dark Form", "link": "simple dark form/index.html"
6."name": "Netflix Clone", "link": "netflixclone/index.html"

"name": "Gym Website",
"link": "gymWebsite/index.html"
"name": "Sneaker Storefront",
"link": "sneaker-storefront/index.html"

Only This Project 3: Cool-Front-End-Templates\GymWebsite is having weird messages should I fix this @arpit456jain ??
Style.css File

**Index.html File

@TG922   make sure that name and link must be same
like u have
"name": "Engineers Copied Web",
"link": "engineers copied web/index.html"
it should be
"name": "Engineers Copied Web",
"link": "Engineers Copied Web/index.html"
and must check the link of all templates it should not be broken

@TG922 and add name and links of template which are not in json file yet

@TG922

In the Products Page folder, preview.png is not present.
Some folder names are not in the capital.
Look at the gym website; some code is written on the frontend.
In some folders like AmolShelke-portfolio, Mmm collections, Tailwind Portfolio, Travel website template-1, Gallery page of the Art gallery website, images are not linked correctly and are missing.
Check all the templates whether images are linked correctly or not.

[x]   Changed Starting Letter of the project to Capital Name in json files

List is here:

"name": "Engineers Copied Web",
"link": "engineers copied web/index.html"

2."name": "Glassmorphism-Form", "link": "glassmorphism-form/index.html"
3."name": "Online Grocery- store", "link": "online grocery- store/index.html"
4."name": "Portfolio Avinash", "link": "portfolio Avinash/index.html"
5."name": "Simple Dark Form", "link": "simple dark form/index.html"
6."name": "Netflix Clone", "link": "netflixclone/index.html"

"name": "Gym Website",
"link": "gymWebsite/index.html"
"name": "Sneaker Storefront",
"link": "sneaker-storefront/index.html"

Only This Project 3: Cool-Front-End-Templates\GymWebsite is having weird messages should I fix this @arpit456jain ??
Style.css File

**Index.html File

@TG922 make sure that name and link must be same
like u have
"name": "Engineers Copied Web", "link": "engineers copied web/index.html"
it should be "name": "Engineers Copied Web", "link": "Engineers Copied Web/index.html"
and must check the link of all templates it should not be broken

Ok @arpit456jain

@TG922

In the Products Page folder, preview.png is not present.
Some folder names are not in the capital.
Look at the gym website; some code is written on the frontend.
In some folders like AmolShelke-portfolio, Mmm collections, Tailwind Portfolio, Travel website template-1, Gallery page of the Art gallery website, images are not linked correctly and are missing.
Check all the templates whether images are linked correctly or not.

Ok I will see

@TG922 take ur time there is no hurry .
if this works well u can do same in other 2 repos with lvl 3 label

Do check the Missing project mentioned in the JSON file
{
"name": "Artica",
"link": "Artica/index.html"
},
There were 2 Netflix Clone, so I renamed 2nd one as Netflix Clone-2

Colon ":" Named Folder not allowed so replaced it with "-" on both the JSON and folder
{
"name": "Moninfo:Indian Monuments Template",
"link": "Moninfo:Indian Monuments Template/index.html"
},
Do check this Image folder!! Don't know for which file it belongs to

Mmm Collections have uploaded the wrong online image URL

[x] make sure that name and link must be same

@TG922

In the Products Page folder, preview.png is not present.
Some folder names are not in the capital.
Look at the gym website; some code is written on the frontend.
In some folders like AmolShelke-portfolio, Mmm collections, Tailwind Portfolio, Travel website template-1, Gallery page of the Art gallery website, images are not linked correctly and are missing.
Check all the templates whether images are linked correctly or not.

[x] Changes Done

@TG922 1. In Food Website Template main background image is missing, see the preview.png.
2. In money website one header color is not matching with preview.png
3. Tailwind Portfolio men images ka problem hai.
4. Technology page men header header match nhi ho raha preview se.
5. In gym website code is written in frontend.
Kindly make these changes.

@TG922 do this changes asap and then we are good to go

Ok I will do it today I was having exam

@TG922

OK I'm on it will send PR within some hour

I don't know you are really a girl but I would really like to appreciate @DEEPALI-SUK and @DEEPIKA-SUK  for pointing out issues !! It is not easy to point out issues in all projects.
Most of the time I was surprised with the issues Are ye kaise reh gaya??


OCM-11407 | fix: Error msg for editing nodepool; autoscaling+ 0 replicas

Error msg was wrong for editing HCP nodepool with autoscaling + <1 replicas. Changed to correct msg and tested

/retest

/lgtm

/cherrypick release_1.2.46


Fix

not ideal, but we have a dep on ring that is blocking musl building. Need to debug that and then move to musl for a single linux static bin


Filter out constraint tuple class constructors in hasNoTypeClasses

A rough sketch.  I don't know what I'm doing. See #74.

Thanks, decent start, I can clean up it a bit before merging. But I’ll wait for the discussion in #74, to see if all your issues can be resolved.

I'm additionally filtering out heqTyConName and eqTyConName, because both appear in my code, I think. Now inspection-testing no longer complains about ~ classes spotted, so it seems to work. Let me know if that's a bad idea.

I've reverted the last change --- it works great with ''(~) --- I had no idea to try something like that.

Can you do it for the tuples as well? (Mostly curious, it might still be good to do so by default)

Any idea how to try? I did try adding ''(%,,,,,,,,%) to the list and ''$d(%,,,,,,,,%) and ''d(%,,,,,,,,%) and each is rejected with "parse error on input ‘,’".

I would have expected the first to work. Nevermind, not that important.

I don't think I will have any more actionable input for now.
Your tool, after patching, helped me manually specialize my code much more, to the point I've discovered a new bug in GHC and/or plugins (https://gitlab.haskell.org/ghc/ghc/-/issues/23866), which makes GHC 9.4 unusable for me. I still have one GHC version that works correctly, GHC 9.2, though it probably doesn't specialize as well  --- I can't tell, because I needed to add as exceptions all classes that constrain existential variables, so I can't easily detect failures to eliminate these dictionaries in non-existential contests (the lack of an explicit exists quantifier in Core and in Haskell surface language doesn't help, either):
inspect $ hasNoTypeClassesExcept 'revRankedListProd [''GoodScalar, ''KnownNat, ''OS.Shape, ''AstSpan, ''Show, ''Ord, ''Numeric, ''Num, ''RowSum, ''Typeable, ''IfDifferentiable, ''NFData, ''RealFrac, ''Integral, ''Fractional, ''RealFloat, ''Floating]

BTW, I've also just discovered, using your tool, than GHC 9.8.1-alpha1 specializes worse than GHC 9.4, even in its unsound -fpolymorphic-specialisation mode (https://gitlab.haskell.org/ghc/ghc/-/issues/23874).

So, does it have a chance to get merged? :)

Oh, yes, the CI fails, because I cheated for the old GHCs. :)

Thank you!


add range check support for snarkyrs

Adding support to use range checks in snarkyrs

@fabrizio-m can you make the CI happy please? :)


Add support for actual things

For example, a plant or a room.

Maybe too out of scope for now, will revisit this idea soon though.


General Funky Usage

Hey there,
so I have a few issues with the way persistent works
First of all, if I make a Map or Array persistent, it becomes readonly, in Svelte, in Astro, wherever, the persistent modules become readonly if they are an array or object. An example
export type XYZ = [x: number, y: number, z: number];
export const progressBarActiveScale: WritableAtom<XYZ> = persistentAtom<XYZ>('progressBarActiveScale', [1, 1.1, 1], {
    encode: (unencoded: number[]) => JSON.stringify(unencoded),
    decode: (encoded: string) => JSON.parse(encoded),
});

this is the configuration for my Threlte (Svelte ThreeJS) scene, I store it this way because my brother is going to OBS capture it, so between different loads I want the data to stay the same. Now the issue is, when I use it, it becomes readonly

so that's one issue, I don't know why it's readonly
The second issue is as someone else previously mentioned, and a more general Nanostores issue
      let tOnePBC = teamOneProgressBarColors.get();
      let tTwoPBC = teamTwoProgressBarColors.get();
      if (typeof tOnePBC === "string") {
        tOnePBC = JSON.parse(tOnePBC);
      }
      if (typeof tTwoPBC === "string") {
        tTwoPBC = JSON.parse(tTwoPBC);
      }

what the heck is the point of using encode and decode values if I still have to decode the stringified local value? That's confusing and I don't understand what's going on there.

The map value’s is readonly is to prevent popular mistake of changing key directly in subscrlibe callback:
$store.subscribe(store => {
  store.initialized = true // This line will lead to unexpected behaviour
})

The problem is that changing key in store’s value will change the store, but will not notify the subscribers.
We didn’t plan to explicitly ban replacing the variable in Svelte, it is just side effect of this DX fix for pure JS subscribe() types.
If you know a way to keep protection from mistake and make it easier to write Svelte code, send PR.


fails to build on Atom beta 1.12.0-beta 3

Here is the error:
Installing<EMAIL_ADDRESS>failed.Hide output…

<EMAIL_ADDRESS>install /private/var/folders/1k/vshtb0x17bbf30mgmmb78ncm0000gn/T/apm-install-dir-116920-65836-hwugor/node_modules/git-blame/node_modules/runas
node-gyp rebuild

building file list ... done
sent 193942 bytes  received 20 bytes  35265.82 bytes/sec
total size is 124109638  speedup is 639.87
/private/var/folders/1k/vshtb0x17bbf30mgmmb78ncm0000gn/T/apm-install-dir-116920-65836-hwugor
`-- (empty)
gyp WARN download NVM_IOJS_ORG_MIRROR is deprecated and will be removed in node-gyp v4, please use IOJS_ORG_MIRROR
gyp WARN download NVM_IOJS_ORG_MIRROR is deprecated and will be removed in node-gyp v4, please use IOJS_ORG_MIRROR
gyp WARN download NVM_IOJS_ORG_MIRROR is deprecated and will be removed in node-gyp v4, please use IOJS_ORG_MIRROR
make: *** build: No such file or directory.  Stop.
gyp ERR! build error
gyp ERR! stack Error: make failed with exit code: 2
gyp ERR! stack     at ChildProcess.onExit (/Applications/Atom Beta.app/Contents/Resources/app/apm/node_modules/node-gyp/lib/build.js:276:23)
gyp ERR! stack     at emitTwo (events.js:87:13)
gyp ERR! stack     at ChildProcess.emit (events.js:172:7)
gyp ERR! stack     at Process.ChildProcess._handle.onexit (internal/child_process.js:200:12)
gyp ERR! System Darwin 16.0.0
gyp ERR! command "/Applications/Atom Beta.app/Contents/Resources/app/apm/bin/node" "/Applications/Atom Beta.app/Contents/Resources/app/apm/node_modules/.bin/node-gyp" "rebuild"
gyp ERR! cwd /private/var/folders/1k/vshtb0x17bbf30mgmmb78ncm0000gn/T/apm-install-dir-116920-65836-hwugor/node_modules/git-blame/node_modules/runas
gyp ERR! node -v v4.4.5
gyp ERR! node-gyp -v v3.4.0
gyp ERR! not ok
npm WARN enoent ENOENT: no such file or directory, open '/private/var/folders/1k/vshtb0x17bbf30mgmmb78ncm0000gn/T/apm-install-dir-116920-65836-hwugor/package.json'
npm WARN apm-install-dir-116920-65836-hwugor No description
npm WARN apm-install-dir-116920-65836-hwugor No repository field.
npm WARN apm-install-dir-116920-65836-hwugor No README data
npm WARN apm-install-dir-116920-65836-hwugor No license field.
npm ERR! Darwin 16.0.0
npm ERR! argv "/Applications/Atom Beta.app/Contents/Resources/app/apm/bin/node" "/Applications/Atom Beta.app/Contents/Resources/app/apm/node_modules/npm/bin/npm-cli.js" "--globalconfig" "/Users/flavioc/.atom/.apm/.apmrc" "--userconfig" "/Users/flavioc/.atom/.apmrc" "install" "/private/var/folders/1k/vshtb0x17bbf30mgmmb78ncm0000gn/T/d-116920-65836-13vbjik/package.tgz" "--runtime=electron" "--target=1.3.6" "--arch=x64" "--global-style"
npm ERR! node v4.4.5
npm ERR! npm  v3.10.5
npm ERR! code ELIFECYCLE
npm ERR<EMAIL_ADDRESS>install: node-gyp rebuild
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>install script 'node-gyp rebuild'.
npm ERR! Make sure you have the latest version of node.js and npm installed.
npm ERR! If you do, this is most likely a problem with the runas package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     node-gyp rebuild
npm ERR! You can get information on how to open an issue for this project with:
npm ERR!     npm bugs runas
npm ERR! Or if that isn't available, you can get their info via:
npm ERR!     npm owner ls runas
npm ERR! There is likely additional logging output above.
npm ERR! Please include the following file with any support request:
npm ERR!     /private/var/folders/1k/vshtb0x17bbf30mgmmb78ncm0000gn/T/apm-install-dir-116920-65836-hwugor/npm-debug.log
npm ERR! code 1

Confirming fails to build on 1.12.0 (non beta).

Works for me in v1.12.0 but it started crashing a lot on my end.

I don't know if this is related, but I had to rebuild my atom packages -- seems to be working fine for me now. Figured I'd add an update.

The install failed. I was running Atom 1.11. Upgraded. But still fails in Atom 1.12.5. My error is not exactly the same as the one posted above, but pretty similar:
><EMAIL_ADDRESS>install /private/var/folders/2c/pqvq3ntx57x9h4q3mklw52400000gn/T/apm-install-dir-1161023-83951-1tgh4qv/node_modules/git-blame/node_modules/runas
> node-gyp rebuild

/private/var/folders/2c/pqvq3ntx57x9h4q3mklw52400000gn/T/apm-install-dir-1161023-83951-1tgh4qv
└── (empty)

gyp WARN download NVM_IOJS_ORG_MIRROR is deprecated and will be removed in node-gyp v4, please use IOJS_ORG_MIRROR
gyp ERR!  System Darwin 16.1.0
gyp ERR! command "/Applications/Atom.app/Contents/Resources/app/apm/bin/node" "/Applications/Atom.app/Contents/Resources/app/apm/node_modules/.bin/node-gyp" "rebuild"
gyp ERR! cwd /private/var/folders/2c/pqvq3ntx57x9h4q3mklw52400000gn/T/apm-install-dir-1161023-83951-1tgh4qv/node_modules/git-blame/node_modules/runas
gyp ERR! node -v v4.4.5
gyp ERR! node-gyp -v v3.4.0
gyp ERR! This is a bug in `node-gyp`.
gyp ERR! Try to update node-gyp and file an Issue if it does not help:
gyp ERR!     <https://github.com/nodejs/node-gyp/issues>
npm WARN enoent ENOENT: no such file or directory, open '/private/var/folders/2c/pqvq3ntx57x9h4q3mklw52400000gn/T/apm-install-dir-1161023-83951-1tgh4qv/package.json'
npm WARN apm-install-dir-1161023-83951-1tgh4qv No description
npm WARN apm-install-dir-1161023-83951-1tgh4qv No repository field.
npm WARN apm-install-dir-1161023-83951-1tgh4qv No README data
npm WARN apm-install-dir-1161023-83951-1tgh4qv No license field.
npm ERR! Darwin 16.1.0
npm ERR! argv "/Applications/Atom.app/Contents/Resources/app/apm/bin/node" "/Applications/Atom.app/Contents/Resources/app/apm/node_modules/npm/bin/npm-cli.js" "--globalconfig" "/Users/nene/.atom/.apm/.apmrc" "--userconfig" "/Users/nene/.atom/.apmrc" "install" "/private/var/folders/2c/pqvq3ntx57x9h4q3mklw52400000gn/T/d-1161023-83951-d1081l/package.tgz" "--runtime=electron" "--target=1.3.9" "--arch=x64" "--global-style"
npm ERR! node v4.4.5
npm ERR! npm  v3.10.5
npm ERR! code ELIFECYCLE

npm ERR<EMAIL_ADDRESS>install: `node-gyp rebuild`
npm ERR! Exit status 7
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>install script 'node-gyp rebuild'.
npm ERR! Make sure you have the latest version of node.js and npm installed.
npm ERR! If you do, this is most likely a problem with the runas package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     node-gyp rebuild
npm ERR! You can get information on how to open an issue for this project with:
npm ERR!     npm bugs runas
npm ERR! Or if that isn't available, you can get their info via:
npm ERR!     npm owner ls runas
npm ERR! There is likely additional logging output above.

npm ERR! Please include the following file with any support request:
npm ERR!     /private/var/folders/2c/pqvq3ntx57x9h4q3mklw52400000gn/T/apm-install-dir-1161023-83951-1tgh4qv/npm-debug.log
npm ERR! code 1

Have you tried apm rebuild?

Tried apm rebuild which however failed:
npm WARN prefer global<EMAIL_ADDRESS>should be installed with -g
npm WARN prefer global<EMAIL_ADDRESS>should be installed with -g
http node-sass install Downloading binary from https://github.com/sass/node-sass/releases/download/v3.12.2/darwin-x64-46_binding.node
http node-sass install Download complete
info node-sass install Binary saved at /Users/nene/work/xr-agent/xr-web-ui/node_modules/node-sass/vendor/darwin-x64-46/binding.node
info node-sass install Caching binary to /Users/nene/.atom/.apm/node-sass/3.12.2/darwin-x64-46_binding.node
info node-sass build Binary found at /Users/nene/work/xr-agent/xr-web-ui/node_modules/node-sass/vendor/darwin-x64-46/binding.node
info node-sass build Testing binary
info node-sass build Binary is fine
node-pre-gyp ERR! Tried to download: https://fsevents-binaries.s3-us-west-2.amazonaws.com/v1.0.15/fse-v1.0.15-electron-v1.3-darwin-x64.tar.gz
node-pre-gyp ERR! Pre-built binaries not found for<EMAIL_ADDRESS>and<EMAIL_ADDRESS>(electron-v1.3 ABI) (falling back to source compile with node-gyp)
gyp WARN download NVM_IOJS_ORG_MIRROR is deprecated and will be removed in node-gyp v4, please use IOJS_ORG_MIRROR
gyp ERR!  System Darwin 16.1.0
gyp ERR! command "/Applications/Atom.app/Contents/Resources/app/apm/bin/node" "/Applications/Atom.app/Contents/Resources/app/apm/node_modules/.bin/node-gyp" "configure" "--fallback-to-build" "--module=/Users/nene/work/xr-agent/xr-web-ui/node_modules/fsevents/lib/binding/Release/electron-v1.3-darwin-x64/fse.node" "--module_name=fse" "--module_path=/Users/nene/work/xr-agent/xr-web-ui/node_modules/fsevents/lib/binding/Release/electron-v1.3-darwin-x64"
gyp ERR! cwd /Users/nene/work/xr-agent/xr-web-ui/node_modules/fsevents
gyp ERR! node -v v4.4.5
gyp ERR! node-gyp -v v3.4.0
gyp ERR! This is a bug in `node-gyp`.
gyp ERR! Try to update node-gyp and file an Issue if it does not help:
gyp ERR!     <https://github.com/nodejs/node-gyp/issues>
node-pre-gyp ERR! build error
node-pre-gyp ERR! stack Error: Failed to execute '/Applications/Atom.app/Contents/Resources/app/apm/bin/node /Applications/Atom.app/Contents/Resources/app/apm/bin/../node_modules/.bin/node-gyp configure --fallback-to-build --module=/Users/nene/work/xr-agent/xr-web-ui/node_modules/fsevents/lib/binding/Release/electron-v1.3-darwin-x64/fse.node --module_name=fse --module_path=/Users/nene/work/xr-agent/xr-web-ui/node_modules/fsevents/lib/binding/Release/electron-v1.3-darwin-x64' (7)
node-pre-gyp ERR! stack     at ChildProcess.<anonymous> (/Users/nene/work/xr-agent/xr-web-ui/node_modules/fsevents/node_modules/node-pre-gyp/lib/util/compile.js:83:29)
node-pre-gyp ERR! stack     at emitTwo (events.js:87:13)
node-pre-gyp ERR! stack     at ChildProcess.emit (events.js:172:7)
node-pre-gyp ERR! stack     at maybeClose (internal/child_process.js:827:16)
node-pre-gyp ERR! stack     at Process.ChildProcess._handle.onexit (internal/child_process.js:211:5)
node-pre-gyp ERR! System Darwin 16.1.0
node-pre-gyp ERR! command "/Applications/Atom.app/Contents/Resources/app/apm/bin/node" "/Users/nene/work/xr-agent/xr-web-ui/node_modules/fsevents/node_modules/.bin/node-pre-gyp" "install" "--fallback-to-build"
node-pre-gyp ERR! cwd /Users/nene/work/xr-agent/xr-web-ui/node_modules/fsevents
node-pre-gyp ERR! node -v v4.4.5
node-pre-gyp ERR! node-pre-gyp -v v0.6.29
node-pre-gyp ERR! not ok

npm ERR! Darwin 16.1.0
npm ERR! argv "/Applications/Atom.app/Contents/Resources/app/apm/bin/node" "/Applications/Atom.app/Contents/Resources/app/apm/node_modules/npm/bin/npm-cli.js" "--globalconfig" "/Users/nene/.atom/.apm/.apmrc" "--userconfig" "/Users/nene/.atom/.apmrc" "rebuild" "--runtime=electron" "--target=1.3.9" "--arch=x64"
npm ERR! node v4.4.5
npm ERR! npm  v3.10.5
npm ERR! code ELIFECYCLE
npm ERR<EMAIL_ADDRESS>install: `node-pre-gyp install --fallback-to-build`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>install script 'node-pre-gyp install --fallback-to-build'.
npm ERR! Make sure you have the latest version of node.js and npm installed.
npm ERR! If you do, this is most likely a problem with the fsevents package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     node-pre-gyp install --fallback-to-build
npm ERR! You can get information on how to open an issue for this project with:
npm ERR!     npm bugs fsevents
npm ERR! Or if that isn't available, you can get their info via:
npm ERR!     npm owner ls fsevents
npm ERR! There is likely additional logging output above.

npm ERR! Please include the following file with any support request:
npm ERR!     /Users/nene/work/xr-agent/xr-web-ui/npm-debug.log

Looks like the problem is in fsevents.

Still have this issue with Atom Beta 1.13.0-beta8 , any suggestions to fix it please?

@jefe-spain @nene this appears to be an issue with node-gyp possibly.  renaming the app and reinstalling the command line tools as noted in this thread worked for me. https://github.com/atom/apm/issues/499#issuecomment-254695325

I guess I don't really have much interest in giving this git-blame package a try any more. I filed this bug report when I was trying out various blame packages. Then settled with blame package which has worked just fine for me (and judging from screenshots, seems to have better UI anyway).


Rename clang-tools binaries for Windows

Codecov Report

Merging #13 (4c5f86c) into main (0fdee8a) will decrease coverage by 2.62%.
The diff coverage is 22.22%.

@@            Coverage Diff             @@
##             main      #13      +/-   ##
==========================================
- Coverage   76.51%   73.88%   -2.63%
==========================================
  Files           6        7       +1
  Lines         149      157       +8
==========================================
+ Hits          114      116       +2
- Misses         35       41       +6

Impacted Files
Coverage Δ

clang_tools/install.py
52.77% <12.50%> (-4.80%)
:arrow_down:

clang_tools/__init__.py
100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


CI/CD: Use Jenkins and configure auto deploy

CI/CD: Use Jenkins and configure auto deploy

Please ignore this issue. It was supposed to be created on my repo.
Thank you for understanding.


Prisma Memory Leak

Bug description
In our (closed source) project, we added a lot of test for a new feature. That resulted in memory problems in our ci.
We found, that Prisma is might be one of the problems.
I created a minimal reproduction https://github.com/adrian-goe/prisma-nestjs-memory-leak-repoduction
There is one test without using prisma app.controller.spec.ts
and one using prisma app-prisma.controller.spec.ts
running both test with node --expose-gc and jest --detectLeaks results in jest finding memory leaks in the test with prisma.
It might be possible, that this leaks also happens while running the application, but I didn't test that.
It could be possible, that this is a nestJs problem as well, but we ware only be able to reproduce this with Prisma, but no other dependency or module.
How to reproduce
https://github.com/adrian-goe/prisma-nestjs-memory-leak-repoduction
Expected behavior
No response
Prisma information
see https://github.com/adrian-goe/prisma-nestjs-memory-leak-repoduction
Environment & setup

OS: [macOS, Windows, Debian] might be more
Database: [PostgreSQL] only tested with postgres
Node.js version: v16.18.0

Prisma Version
prisma                  : 4.10.1
@prisma/client          : 4.10.1
Current platform        : darwin-arm64
Query Engine (Node-API) : libquery-engine aead147aa326ccb985dcfed5b065b4fdabd44b19 (at<EMAIL_ADDRESS>Migration Engine        : migration-engine-cli aead147aa326ccb985dcfed5b065b4fdabd44b19 (at node_modules/@prisma/engines/migration-engine-darwin-arm64)
Format Wasm             : @prisma/prisma-fmt-wasm 4.10.1-1.80b351cc7c06d352abe81be19b8a89e9c6b7c110
Default Engines Hash    : aead147aa326ccb985dcfed5b065b4fdabd44b19
Studio                  : 0.481.0

In our internal project, this was also an issue with Prisma 4.1.1

Hi @adrian-goe. One problem I find with you reproduction - I don't see prisma.$disconnect call. This is necessary for prisma to clean up all associated resources. Ensure it is gets called after every test suite where prisma is used.
Second problem: when node run with --expose-gc Jest has a known memory leak. This is not prisma-specific problem. Couple of workarounds are suggested in that thread. Most reliable seems to be adding --no-compilation-cache option to node.

@SevInf oh i forgot the app.close call in the test. I will add that alter. But in our production code we have this in every that case.
The jest problem you mentioned, wouldn't this also affect the other test as well?

@SevInf also, i have a prisma Service class. This is provided in the module that extends the OnApplicationShutdown hook from nestjs, so it should correctly shut down, when nestJs shuts down.
Might not be the case in my reproductio, since i forgot the explicit app.close() call.

@adrian-goe PrismaService class in your reproduction does not call $disconnect either. I am not NestJS expert by any means, but I am pretty sure it does not know anything about Prisma and won't call it automatically for you. If that's not the case in your production app and $disconnect is called there, please, update the reproduction to reflect that. Also, try --no-compilation-cache flag to test for Jest leak as well. I, unfortunately, can't tell if it should happen with the other test. We've seen quite a dramatic memory usage spike in our own test suite when --expose-gc is used, however. We could not reproduce it outside of Jest sandbox so we have all reason to believe that the issue I've linked is the reason.

@SevInf I added the --no-compilation-cache flag, the issue remains.
I also added the app.close()in the after all block. Also, I added console.logs to the onApplicationShutdown method, in my prisma service. This method is called. Since my service extends the PrismaClient class, the await this.$disconnect(); should disconnect prisma correctly, as you mentioned.

So I can confirm that the reproduction outputs the following message:
gitpod /workspace/prisma-nestjs-memory-leak-repoduction (main) $ npm run test:leak

><EMAIL_ADDRESS>test:leak
> node --expose-gc ./node_modules/.bin/jest --config=apps/prisma-memeory-leak/jest.config.ts --verbose --no-compilation-cache --detectLeaks --runTestsByPath ./apps/prisma-memeory-leak/src/app/app-prisma.controller.spec.ts

  console.log
    before prisma close

      at Proxy.<anonymous> (src/app/prisma/prisma.service.ts:6:13)

  console.log
    after prisma close

      at Proxy.<anonymous> (src/app/prisma/prisma.service.ts:8:13)

 FAIL   prisma-memeory-leak  apps/prisma-memeory-leak/src/app/app-prisma.controller.spec.ts
  ● Test suite failed to run

    EXPERIMENTAL FEATURE!
    Your test suite is leaking memory. Please ensure all references are cleaned.

    There is a number of things that can leak memory:
      - Async operations that have not finished (e.g. fs.readFile).
      - Timers not properly mocked (e.g. setInterval, setTimeout).
      - Keeping references to the global scope.

      at onResult (../../node_modules/@jest/core/build/TestScheduler.js:190:18)
      at ../../node_modules/@jest/core/build/TestScheduler.js:316:17
      at ../../node_modules/emittery/index.js:260:13
          at Array.map (<anonymous>)
      at Emittery.emit (../../node_modules/emittery/index.js:258:23)

Test Suites: 1 failed, 1 total
Tests:       0 total
Snapshots:   0 total
Time:        2.355 s
Ran all test suites within paths "./apps/prisma-memeory-leak/src/app/app-prisma.controller.spec.ts".
Segmentation fault

I also sent a PR to make the reproduction actually work out of the box.

Hey guys I'm currently debugging a memory-leak on our production app (which is not using NestJS but a similar approach of extending PrismaClient + typedi package).
I've noticed from your reproduction that if I print out heapUsed before the query and after the query on the latest version of prisma it's really leaking by fraction of a megabyte.
However if I downgrade to<EMAIL_ADDRESS>the memory goes down after the query (the test still fails because there might be some open handles or some other stuff).

To reproduce follow the steps in README.md and adjust the file apps/prisma-memeory-leak/src/app/app-prisma.controller.spec.ts to the following:
import { Test, TestingModule } from '@nestjs/testing';
import { AppController } from './app.controller';
import { PrismaModule } from './prisma/prisma.module';
import { AppPrismaController } from './app-prisma.controller';
import { AppPrismaService } from './app-prisma.service';

describe('AppPrismaController', () => {
  let app: TestingModule;

  beforeAll(async () => {
    app = await Test.createTestingModule({
      imports: [PrismaModule],
      controllers: [AppPrismaController],
      providers: [AppPrismaService],
    }).compile();
  });

  afterAll(async () => {
    await app.close();
  });
  describe('getData', () => {
    it('should return "Welcome to prisma-memeory-leak!"', async () => {
      const appController = app.get<AppPrismaController>(AppPrismaController);

      console.log(
        `before querying ${
          Math.round((process.memoryUsage().heapUsed / 1024 / 1024) * 100) / 100
        } MB`
      );
      expect(await appController.getData()).toEqual({
        message: 'Welcome to prisma-memeory-leak!',
      });

      console.log(
        `after querying ${
          Math.round((process.memoryUsage().heapUsed / 1024 / 1024) * 100) / 100
        } MB`
      );
    });
  });
});

Then run the following commands:
npm i --save<EMAIL_ADDRESS><EMAIL_ADDRESS>npx prisma generate

see the memory increase:
before querying 203.91 MB
after querying 206.72 MB

then downgrade to<EMAIL_ADDRESS>npm i --save<EMAIL_ADDRESS><EMAIL_ADDRESS>npx prisma generate

and run the tests again:
before querying 212.83 MB
after querying 202.25 MB

The changelog between 3.0.2 and 3.1.1 versions can be found here: https://github.com/prisma/prisma/releases/tag/3.1.1

So I can confirm that the reproduction outputs the following message:
gitpod /workspace/prisma-nestjs-memory-leak-repoduction (main) $ npm run test:leak

><EMAIL_ADDRESS>test:leak
> node --expose-gc ./node_modules/.bin/jest --config=apps/prisma-memeory-leak/jest.config.ts --verbose --no-compilation-cache --detectLeaks --runTestsByPath ./apps/prisma-memeory-leak/src/app/app-prisma.controller.spec.ts

  console.log
    before prisma close

      at Proxy.<anonymous> (src/app/prisma/prisma.service.ts:6:13)

  console.log
    after prisma close

      at Proxy.<anonymous> (src/app/prisma/prisma.service.ts:8:13)

 FAIL   prisma-memeory-leak  apps/prisma-memeory-leak/src/app/app-prisma.controller.spec.ts
  ● Test suite failed to run

    EXPERIMENTAL FEATURE!
    Your test suite is leaking memory. Please ensure all references are cleaned.

    There is a number of things that can leak memory:
      - Async operations that have not finished (e.g. fs.readFile).
      - Timers not properly mocked (e.g. setInterval, setTimeout).
      - Keeping references to the global scope.

      at onResult (../../node_modules/@jest/core/build/TestScheduler.js:190:18)
      at ../../node_modules/@jest/core/build/TestScheduler.js:316:17
      at ../../node_modules/emittery/index.js:260:13
          at Array.map (<anonymous>)
      at Emittery.emit (../../node_modules/emittery/index.js:258:23)

Test Suites: 1 failed, 1 total
Tests:       0 total
Snapshots:   0 total
Time:        2.355 s
Ran all test suites within paths "./apps/prisma-memeory-leak/src/app/app-prisma.controller.spec.ts".
Segmentation fault

I also sent a PR to make the reproduction actually work out of the box: adrian-goe/prisma-nestjs-memory-leak-repoduction#1
Note: Even though this is now on confirmed, it does not mean there has to be a problem at Prisma. We will keep investigating that.

I've created a new issue where there's a reproduction with no other dependency but Prisma.

https://github.com/prisma/prisma/issues/18934

Technically I cannot call it a memory leak but I am for sure calling it a memory mismanagement.
My feeling is that the following commit is causing it: https://github.com/prisma/prisma/commit/f395abad8eb85739a1df35071caa9e5050993696 but that's just a feeling since I know the prisma infrastructure is super complex and I'm not a Rust developer.
I hope it helps in your investigation.

I kinda believe this might be related to the effects cascade I'm observing in https://github.com/vercel/next.js/issues/49623

we face same issue with Prisma and nestjs, even calling prisma.collection.delete catch memory leak and invalid pointers etc...

@adrian-goe I notice both of us use arm64
Is it related to that bug?

Has anyone come across a workaround for this? I'm noticing a very slow memory leak in my production server that causes a crash after 1-2 weeks. In my local debugging Prisma seems to come up pretty often in my heap dumps.

Same problem
We're also seeing a slow rss increase in a long days by prometheus, the maximum difference between Shallow Sizeand Retained Size in heapdump snapshot point to<EMAIL_ADDRESS>and I found there is a WeakRef in LibraryEngine.ts
I'm not sure if it is this WeakRef cause the memory leak.

I can confirm there is some memory leak in the Prisma query engine. It affects all our apps which use Prisma and make a lot of DB calls regardless of whether they are read-only apps or the ones fetching external data and storing it to the DB.
I thought Prisma 5 might solve this problem but after I updated the dependencies today, I can see the issue is still there.
The memory used by our apps slowly grows day-by-day until they eventually run out of memory and their containers are restarted.
Below I show some examples what this problem looks like in both library and binary mode. In these cases, I simply hit some of our API endpoints that make really heavy DB calls so I can reproduce the issue more quickly.
Library
When we use library engine type, the issue is only visible as the difference between rss memory usage.
You can clearly see there's no memory leak in our app or in Prisma client because the heap size remains stable.
Before Heavy Load
{
  "rss": 336392192,
  "heapTotal": 33280000,
  "heapUsed": 27778056,
  "external": 17858813,
  "arrayBuffers": 51654
}

After Heavy Load
{
  "rss": 571432960,
  "heapTotal": 30396416,
  "heapUsed": 26941400,
  "external": 17875669,
  "arrayBuffers": 39294
}

Binary
When we use binary engine type, it is clearly visible that the query engine uses a lot of memory.
Used memory is shown as percentage below. But it's easy to calculate how much memory those processes use since the machine where the app runs has 1GB RAM.
I only made a single set of heavy DB calls. But I can repeat this over and over again with the very same calls and I always end up with more and more memory used by the query engine.
After Start
After I start the application, the Node.js memory usage looks like this:
{
  "rss": 154386432,
  "heapTotal": 30298112,
  "heapUsed": 26703576,
  "external": 18142813,
  "arrayBuffers": 56092
}

...and relevant system processes like this:
USER       PID %CPU %MEM    VSZ   RSS TTY      STAT START   TIME COMMAND
apps        76  7.9 15.3 21784396 161136 ?     Sl   09:03   0:05 /layers/heroku_nodejs-engine/nodejs/bin/node --inspect=<IP_ADDRESS>:9221 --heapsnapshot-signal=SIGUSR2 build/server.js
apps        88  0.6  4.7<PHONE_NUMBER>0 ?        Sl   09:03   0:00 /workspace/node_modules/.prisma/client/query-engine-debian-openssl-1.0.x --enable-raw-queries --enable-metrics --enable-open-telemetry --port 0 --engine-protocol json

After Heat Up Period
I let the application run for a while but there's nothing going on except for regular health checks (which also connect to the DB).
{
  "rss": 158240768,
  "heapTotal": 31870976,
  "heapUsed": 28238904,
  "external": 18340681,
  "arrayBuffers": 65628
}

USER       PID %CPU %MEM    VSZ   RSS TTY      STAT START   TIME COMMAND
apps        76  4.1 14.7 21783536 154532 ?     Sl   09:03   0:40 /layers/heroku_nodejs-engine/nodejs/bin/node --inspect=<IP_ADDRESS>:9221 --heapsnapshot-signal=SIGUSR2 build/server.js
apps        88  2.4 14.5<PHONE_NUMBER>92 ?       Sl   09:03   0:22 /workspace/node_modules/.prisma/client/query-engine-debian-openssl-1.0.x --enable-raw-queries --enable-metrics --enable-open-telemetry --port 0 --engine-protocol json

After Heavy Load
{
  "rss": 207368192,
  "heapTotal": 80367616,
  "heapUsed": 69357296,
  "external": 18272118,
  "arrayBuffers": 63632
}

USER       PID %CPU %MEM    VSZ   RSS TTY      STAT START   TIME COMMAND
apps        76  5.3 19.3 21823728 202508 ?     Sl   09:03   1:03 /layers/heroku_nodejs-engine/nodejs/bin/node --inspect=<IP_ADDRESS>:9221 --heapsnapshot-signal=SIGUSR2 build/server.js
apps        88  3.2 29.6<PHONE_NUMBER>60 ?       Sl   09:03   0:37 /workspace/node_modules/.prisma/client/query-engine-debian-openssl-1.0.x --enable-raw-queries --enable-metrics --enable-open-telemetry --port 0 --engine-protocol json

After Cool Down Period
When I wait for a while after the heavy DB calls, I can see that GC kicks in and cleans up the heap. However, the memory used by the Prisma query engine doesn't go down.
{
  "rss": 158236672,
  "heapTotal": 32133120,
  "heapUsed": 27977328,
  "external": 18275459,
  "arrayBuffers": 52850
}

USER       PID %CPU %MEM    VSZ   RSS TTY      STAT START   TIME COMMAND
apps        76  5.0 14.7 21783792 154528 ?     Sl   09:03   1:05 /layers/heroku_nodejs-engine/nodejs/bin/node --inspect=<IP_ADDRESS>:9221 --heapsnapshot-signal=SIGUSR2 build/server.js
apps        88  2.9 29.6<PHONE_NUMBER>60 ?       Sl   09:03   0:37 /workspace/node_modules/.prisma/client/query-engine-debian-openssl-1.0.x --enable-raw-queries --enable-metrics --enable-open-telemetry --port 0 --engine-protocol json

This issue appears to be pervasive (and likely related to #17171). I am seeing both in my tests, as well as in production. I have to restart my containers every 1-2 days as it grows consistently over time.
Is there any way to flag this bug as a priority? Seems like a pretty big problem.

We are experiencing this issue in production as well. For now, we're having to restart our containers nightly to avoid OOM errors. Similar to other users, we are able to consistently reproduce this by running queries and observe that the NodeJS heap size is stable while the process's overall memory is increasing as we run queries.

It's worth noting that the existing memory leak tests will not detect this issue because they're examining only the NodeJS heap size; it's likely that the existing test suite could be adjusted to catch this class of issue by using process.memoryUsage().rss to capture total memory usage, rather than heapUsed here: https://github.com/prisma/prisma/blob/main/packages/client/tests/memory/_utils/createMemoryTest.ts#L63

Just to give you an idea what this memory leak look like in another app when we keep it running for a day:
apps        83  6.8 19.6 21958328 205820 ?     Sl   Jul29 142:00 /layers/heroku_nodejs-engine/nodejs/bin/node build/worker.js
apps        94 10.7 51.3 1267276 538512 ?      Sl   Jul29 223:34 /workspace/node_modules/.prisma/client/query-engine-debian-openssl-1.0.x --enable-raw-queries --enable-metrics --enable-open-telemetry --port 0 --engine-protocol json

This app is a job executor that works all the time without any break since there are always more jobs than it can process. And the Node.js app itself still consumes just 196 MB of RAM while Prisma query engine consumes 513 MB which is constantly growing until the container eventually runs out of memory and is restarted.

Looks like the problem is in version >=4.8.2. Try downgrade<EMAIL_ADDRESS>

This issue is keeping us from upgrading past 4.8, since our containers die after around a day. There's lots of features in 5.0 i'm looking on with envy until this gets resolved.

same here, it's a slow memory leak, and we're restarting the containers after it crosses the 95% memory usage. it grows regardless of how much traffic the server is getting

Noticing the same on my app. It's a Express + Next.js App. Memory slowly continues increasing.
Today I upgrade from  version 4 to 5.2.0 hoping it's fixed.

Ok, this issue is a mess with dozens of possibly completely unrelated reports - and only 1 actual reproduction that can help us understand what is going on, from @adrian-goe 🙇. I'll try to untangle that a bit.

@livthomas, or anyone else who is using engineType = "binary", please open a new issue. Your problem is not related to what the normal Prisma Query Engine might be experiencing - so it does not make sense to mix your problem with this one. I will hide your messages here to clean up the noise a bit, but please do open that new issue and share your information in there - optimally with a reproduction. We definitely want to look into that as well, but here is not the right place. Thanks.

For everyone posting here, it would be amazing if you could edit your message and add the answers to the following questions:
You are using the normal library engine, correct?
What Node version?
What OS?
What database and version?
Can you reproduce the problem locally?
Is your app running any special queries? Promise.all, or any other parallelism?

@rickitan Can you help us by providing a reproduction in any way that we can run? What "memory" exactly is increasing? RSS usage? While the app is doing what exactly?
@pocesar Can you isolate the problem into a reproduction? Sounds like you have a pretty good understanding of your situation, so that would be most helpful.
@whalesync-ryder Any other information you can provide?
@benweissmann https://github.com/prisma/prisma/pull/20861
@xlmnxp Can you provide any information that helps us reproduce and understand the problem? (We never backport any fixes, and I do not understand what most of your other messages mean. Please elaborate.)
@calvinl What helps us prioritize issues, are good reproductions and investigations. We need to be able to see the problem, in as many variants as possible, to hopefully be able to to figure out what is going on. Most probably many of these reports are unrelated and caused by different things - but with only 1 reproduction we can not connect the dots.
@eJayYoung Can you elaborate what you mean with " the maximum difference between Shallow Size and Retained Size in heapdump snapshot point to<EMAIL_ADDRESS>@RisbergAdam Could you help us pinpoint it by testing these versions in between 4.3.1 and 4.12.0 to figure out where exactly it started? I suggest starting with 4.8.0, and then again in the middle depending if it is affected or not - that should lead to a result in ~3 or 4 tries. That would be super helpful. Thanks!
@Nickersoft Any additional information you can provide that helps us understand this?
@Durisvk Your observation turned out to be normal GC behavior, correct? So should I hide your messages here as they were actually not about the same problem?

my production server crashes every 2 days due to a memory leak, goes over 95% then poof. i have to restart it nightly
since doing some new commits, it now shoots up from ~350mb-400mb before a restart in 2 days, to ~650mb in just a few hours (master branch) !
i can reproduce this locally every time using my unit tests, you can too if you clone & run the prisma seeder https://github.com/dotabod/backend
this is the package that crashes https://github.com/dotabod/backend/blob/master/packages/Dockerfile.dota
here's the docker compose https://github.com/dotabod/backend/blob/master/docker-compose.yml#L65
here's the prisma https://github.com/dotabod/backend/blob/master/packages/prisma/src/postgres.prisma

Our team ran into a similar issue with our NestJS application.
The memory leak is very slow (about 800MB in 48 hours).
Approximate server load information:

2.5K inserts per second
22K selects per second
2.2K deletions per second
280 updates per second

We tried several options to localize the memory leak. Here is the result we got. When running the application with engineType "library" nodeJS process keep on consume memory. When using engineType "binary" nodeJS application uses memory correctly but the prisma-query-engine process continues to consume memory.
When comparing 2 different launch methods, engineType "library" leaks about twice as fast compared to engineType "binary".
We are using prisma version 5.2.0, node v16.18.1.
OS info: Linux 5.4.179-1.el8.elrepo.x86_64 #1 SMP Thu Feb 10 10:14:12 EST 2022 x86_64 x86_64 x86_64 GNU/Linux
Memory usage:

Prisma info:

Facing same issues on Next.js.

serious memory leak, i used prisma 4.11.0 (memory used 20GB)
downgrade prisma 4.8.1 (memory used  200mb)

Can you help us reproduce the problem @tuwibu? The more apps we have that are experiencing this, especially if it is somewhat simple to reproduce, the easier it will be to understand and fix this.
I assume your screenshot refers to mem = 23.gb for the api service? How long did that run to get into that state?

Can you help us reproduce the problem @tuwibu? The more apps we have that are experiencing this, especially if it is somewhat simple to reproduce, the easier it will be to understand and fix this.
I assume your screenshot refers to mem = 23.gb for the api service? How long did that run to get into that state?

I cant reproduce problem.
My api only select random into 600k record, 500 request/s
It will consume up to 20gb of memory after 1-2 days

I wrote a very simple sample app and left it running over the weekend and I believe it repros the issue.
The code is here: https://github.com/whalesync-ryder/prisma-leak-demo
Here's the memory over 27 hours:

Let me know if you have any questions, hope that helps!

In case folks missed it, this looks like its related to using Prisma on Node 16/18. Updating to Nodejs v20 fixed the memory leak for my team.

@mmmeff I tested it with the reproduction, i posted. That did not fix it.
Node: 20.6.1
Prisma: 5.2.0
@janpio I pushed it on a seperate branch https://github.com/adrian-goe/prisma-nestjs-memory-leak-repoduction/tree/node20

Thanks for anticipating my next question @adrian-goe and delivering the answer 🙇
Can you do the same @whalesync-ryder maybe?

@whalesync-ryder This is what 6 hours on Node.js 18.17.1 look like for me with your reproduction, run on GH Actions: https://github.com/janpio/prisma-leak-demo/actions/runs/6171034510/job/16748486361:

Slight increase over time in RSS.

@janpio Thanks for running it, i had a background task running this morning that found similar results. It's 10x better on node 20:
Node 16.13.0: Increases at 47. MB/hour
Node 20.6.1: Increases at 4.4 MB/hour

My result for 6 hours of node 16.13.0:

@janpio Very interesting! So you're not seeing any difference. Maybe I had something else going on to explain the 10x difference in leak speed between my two runs. I can't imagine what it would be.

I believe that we are also experiencing this - I can't give source code publicly, but I am happy to add a few developers to our repo for research purposes if that helps.

Thanks for the offer, but we have a few general apps that run out of memory with "just keep it running with normal production level traffic" - that is super hard to reproduce for us. Optimal would a minimal reproduction that clearly shows how memory is leaking. The more obvious, the easier it is for us to figure out what is going on.

I'm sorry I know this is not a particularly helpful comment, but we're definitely getting the same issues as described above in production too.
For now we're also restarting everything regularly with pm2.
Can't share too much other info about our setup on here, but if someone from prisma wants to reach out I can spare some time.

using Prisma 5.3.1 and Node.js 20.6 decreased the amount of restarts per day to 0.25, which is a major improvement from the daily / twice restarts

I needed to run a script to import around 12 million records.
await db.record.findUnique({
    select: {
      id: true,
    },
    where: {
      id: key,
      updatedAt: { gte: lastModifiedDate },
    },
  })

Runing this query on Prisma 5.4.1 and NodeJS 18.12.0 was causing a memory leak. A simple script running only this query would consume all server memory and crash. Optimizing it with $queryRaw didn't help. Then I tried calling the raw query with pg 8.11.3 on Nodejs 18.12.0 and got normal memory consumption so the problem was with Prisma 5.4.1 on NodeJS 18.12.0. I upgraded to NodeJS 20.8.0 and tested the original findUnique on Prisma 5.4.1 - this solved the problem. The server is running Debian GNU/Linux 10 (buster), but the same thing was happening on Mac OS X.

Hello 👋🏼 I'm working through posts here and reproductions attempts.
Note for @adrian-goe
I tried to run your repro using a Codespace on GitHub, using the Node.js version from nvmrc https://github.com/adrian-goe/prisma-nestjs-memory-leak-repoduction/tree/node20?rgh-link-date=2023-09-13T08%3A39%3A57Z
But the "proof" which is supposed to not leak memory, is actually reporting a leak, see below

@janpio Very interesting! So you're not seeing any difference. Maybe I had something else going on to explain the 10x difference in leak speed between my two runs. I can't imagine what it would be.

@whalesync-ryder It looks similar for my results, not much difference between different versions of Node.js
Since your last comment, do you have any update, maybe?
Here is some fresh data below.

Using a fork of (https://github.com/janpio/prisma-leak-demo)
I ran a matrix of different Node.js versions for 6 hours.
This first run is using Prisma 5.2.0
https://github.com/Jolg42/prisma-leak-demo/actions/runs/6722787722

Here is the data from these runs, they all seem to, approximately, start at ~150 and end at ~180 after 6 hours.

prisma-leak-demo - Node v16.13.0

prisma-leak-demo - Node v16.20.2

prisma-leak-demo - Node v18.18.2

prisma-leak-demo - Node v20.9.0

This second run is using Prisma 5.5.2
https://github.com/Jolg42/prisma-leak-demo/actions/runs/6731468387

Here is the data from these runs, they all seem to, approximately, start at ~150 and end at ~180 after 6 hours.

prisma-leak-demo - Node v16.13.0

prisma-leak-demo - Node v16.20.2

prisma-leak-demo - Node v18.18.2

prisma-leak-demo - Node v20.9.0

I wrote a very simple sample app and left it running over the weekend and I believe it repros the issue. The code is here: whalesync-ryder/prisma-leak-demo
Here's the memory over 27 hours:
Let me know if you have any questions, hope that helps! Edit: forgot to mention running on node v16.13.0. (which we need to upgrade from but you know)

@whalesync-ryder I could reproduce finally using Node.js v16, the reproduction in GitHub Actions was missing yarn prisma db push at first, so previous reproductions were actually not executing any queries, they were all failing because the database didn't exist.
Did you upgrade to v18 or v20 already? This problem looks only related to Node.js v16 (which is "end of life") to me at the moment, see results:
Note:

I used --max-old-space-size to show how rss is actually reclaimed and growing rss is not a problem in itself, as long as it's reclaimed when there is some memory pressure.

Using nest start
Upgrade all + Prisma 5.5.2 + --max-old-space-size=150 - Node v16.20.2
https://docs.google.com/spreadsheets/d/14-9DFfkW_DD_dAdj3WTsQ4kTm_HONd0fgE1rgUgGljo/edit?usp=sharing
🔴 There is definitely a leak here!

Upgrade all + Prisma 5.5.2 + --max-old-space-size=150 - Node v18.18.2
Actually ran out of memory at nest start, see next section for results
Upgrade all + Prisma 5.5.2 + --max-old-space-size=150 - Node v20.9.0
https://docs.google.com/spreadsheets/d/1eSGaXS34aMqWJUW9r-oFjX5IU8ojQ5lAhSHHMsRJzQ4/edit?usp=sharing

Using yarn run build and then node dist/main
Notes:

nest start appears to consume a lot of memory when starting, so I switched to building and starting the server with Node.js instead.

Upgrade all + Prisma 5.5.2 + --max-old-space-size=150 + node dist/main - Node v16.20.2
https://docs.google.com/spreadsheets/d/1BQJLIMGl3xCQSFMNfYUgzdcAUhxaxHc8JnZqlFWJJJg/edit?usp=sharing
🔴 There is definitely a leak here!

Upgrade all + Prisma 5.5.2 + --max-old-space-size=150 + node dist/main - Node v18.18.2
https://docs.google.com/spreadsheets/d/1rDRyzjWi15ZC4az2-Hz0mULcskx98xfQ8ODoAYkGV7E/edit?usp=sharing

Upgrade all + Prisma 5.5.2 + --max-old-space-size=150 + node dist/main - Node v20.9.0
https://docs.google.com/spreadsheets/d/16hOzvpRsdtt3eay8xejz3ukTFByjPkm0t_6d1d_cFoY/edit?usp=sharing

I am in the process of upgrading my node right now, so i should be able to confirm pretty soon if that resolved it for me. Thanks for the info.

Can confirm: Upgrading to Node v20 and Prisma v5.5.2 fixed the leak for me. Previously, memory usage would increase to 2GB within a few hours. Now, it remains at approximately 600MB over the same time span.

Same here, my issues have been resolved since the node upgrade.
5.5.2 & Node 18.18.2
Thanks to whoever fixed it, accidentally or on purpose!

Same - had a few weeks without issue since the upgrade, seems to be fixed!

I still experience memory leaks with Prisma 5.5.2 on both Node.js 18.18.2 and 20.10.0.

Hey @livthomas we'll need further information to be able to help you at all.
Ideally, a minimal reproduction repro of the issue would be best (schema, js/ts code, query data). It would be greatly beneficial if you could share what exactly is going wrong, specific error messages, specific outcomes you're running into, and if possible, any graphs / data that indicate a memory leak (or high memory usage). Here's an example of what I mean per graphs / data for profiling such issues.

Hello here, thanks for the updates! We're very happy to see that Upgrading to Node.js v18 solved the issue for you 🙌🏼
We will now close this, here are a some notes about some things that were discussed here.
Like we found in https://github.com/prisma/prisma/issues/13575, about Jest --detectLeaks, it is an experimental feature, which is undocumented, and from our experience it's too often unreliable. You can see that similar results can be obtained without using Prisma.
Note that Prisma 5 got big performance improvements, like the internal protocol switch, which uses less RAM, for more details see https://www.prisma.io/blog/prisma-5-f66prwkjx72s
So we definitely recommend everyone to upgrade to Prisma 5.
The memory leak in this issue was confirmed when using Node.js v16, which is now End-Of-Life.
So we recommend everyone to upgrade to Node.js v18 or better v20, as it is the current LTS.
If you have a reproduction where a memory leak can be observed with a recent version of Prisma, please open a new issue with a reproduction, we will be happy to investigate and try to reproduce.
If it's related to using Jest, make sure to compare using Prisma and without Prisma, as the problem might be visible without using Prisma.
As a general note, when creating an issue, let us know if what you see is excessive memory usage or something that looks like a memory leak.

In case of a memory leak, the memory usage would steadily go up when repeating the same query many times.
In case of excessive memory usage, the memory usage would not increase over time, but only spike when the query is running. In this case, it could be that too much data is returned from the database and using a limit like take: 10 to specify how many objects should be returned.

I hope I can create a code template in the future with some guidelines to help with identifying potential memory leaks in the future (to be done).

This seems to have some effect on me, thank you all

@GrinZero Just curious, could you give some details about what you modified, and what effect you see?

@GrinZero只是好奇，您能否详细说明您修改的内容以及您看到的效果？

Update somethings:

NestJs ^8 => ^10
Prisma ^3 => ^5
Node ^16 =>^20

I use prom-client and grafana to monitor memory.
Before Update：

After Update：


Add seed argument to EnsembleSampler

This was previously opened as #332, but because of branch renaming issues we had to reopen it. This is @OriolAbril's work, but @carlosgmartin might also be interested. I'll try to summarize where we stand from the previous thread shortly, but I think we were just about there. Anything in particular that was missing?

The tests are failing because we need to change
import packaging

to
import packaging.version

The tests are failing because we need to change
import packaging

to
import packaging.version

@OriolAbril: If you check the "allow edits from maintainers" checkbox, then I can take over from here.

@OriolAbril: If you check the "allow edits from maintainers" checkbox, then I can take over from here.

I don't have the option too, but I can give both you and @carlosgmartin access to my fork.

I don't have the option too, but I can give both you and @carlosgmartin access to my fork.


Update Python live task to 24a shipping feature

With the Python live task now shipping in 24a, it might be good to remove the dependency to the GitHub repo implementing it, while leaving this option open for those who are still on an older release

I thought I had, which is why there are two versions of most of the scripts. When you load the project, the proper instructions for the version of MATLAB that you are running should appear on your path and the others should be placed in Utilities/OldFiles. Can you tell me where you ran into the dependency?

Hello Emma, my mistake, I was judging based on the screenshot of the live task on the README file

But I can see you have indeed upgraded the live script.
I had to search a little bit, but I found the version prior to 24a though: https://www.mathworks.com/matlabcentral/fileexchange/116490-programming-a-starter-project-using-matlab-and-python


discord.js crashing on update

Please describe the problem you are having in as much detail as possible:
I have been using the latest npm version of discord.js, but since Playing statuses don't work anymore, I tried to update to the latest commit on master. It's crashing, and I don't even use voice:
/root/claimclaim/node_modules/discord.js/src/structures/VoiceChannel.js:17
    this.members = new Collection();
                 ^

TypeError: Cannot set property members of [object Object] which has only a getter
    at new VoiceChannel (/root/claimclaim/node_modules/discord.js/src/structures/VoiceChannel.js:17:18)
    at Function.create (/root/claimclaim/node_modules/discord.js/src/structures/Channel.js:91:23)
    at ClientDataManager.newChannel (/root/claimclaim/node_modules/discord.js/src/client/ClientDataManager.js:48:29)
    at Guild.setup (/root/claimclaim/node_modules/discord.js/src/structures/Guild.js:187:68)
    at GuildCreateHandler.handle (/root/claimclaim/node_modules/discord.js/src/client/websocket/packets/handlers/GuildCreate.js:12:15)
    at WebSocketPacketManager.handle (/root/claimclaim/node_modules/discord.js/src/client/websocket/packets/WebSocketPacketManager.js:103:65)
    at WebSocketConnection.onPacket (/root/claimclaim/node_modules/discord.js/src/client/websocket/WebSocketConnection.js:332:35)
    at WebSocketConnection.onMessage (/root/claimclaim/node_modules/discord.js/src/client/websocket/WebSocketConnection.js:294:22)
    at WebSocketClient.internalOnMessage (/root/claimclaim/node_modules/uws/uws.js:103:17)
    at native.client.group.onMessage (/root/claimclaim/node_modules/uws/uws.js:57:15)

Further details:

discord.js version: latest from GH master branch (2aa2f73)
node.js version: v8.4.0
Operating system: Ubuntu 16.04 LTS
Priority this issue should have: medium
Full code: moriczgergo/claim!claim

#1794 will fix this.

@iCrawl Thanks, ETA on when that will be merged?

Pretty much now :P


Nav Bar Tabs Flash on Load

While investigating #1524 I saw this issue but thought it was not happening in production. Well, it is. But it's only visible in light-mode, and only appears to be happening on some of the nav bar tabs i.e `API Reference.
I'll attempt to fix and submit a PR.
https://github.com/expressjs/expressjs.com/assets/14151974/b9be041a-147f-4842-9901-519daae5ed36
a

We can close this issue, it seems to me that the problem has already been resolved

How did this get fixed??


Off-canvas sticky attribute

This PR adds the new attribute to the side table-of-contents so it gets pseudo fixed on opening a push off-canvas on the foundation-sites docs page
It refers to this PR:
https://github.com/zurb/foundation-sites/pull/10381

@SassNinja This PR is a bit old (sorry for not reviewing it sooner). Could you check it is still required, and resolve conflicts if so ?

@ncoden it refers to a PR of mine that is still open https://github.com/zurb/foundation-sites/pull/10408
I will check that Off-canvas sticky PR asap. But as it will probably be moved to v7 (new feature since missing sticky support is not a bug here imo) I'll close this docs update.
It's most likely the selector will change when the features gets reworked.


feat(DCOS-16435): Add package disclaimer

DCOS-16435 This PR is only for the disclaimer.
Because the button configuration new design isn't implemented yet the button looks a little off when on small screens.
before

after

Checklist

[x] Did you add a JIRA issue in a commit message or as part of the branch name?
[ ] Did you add new unit tests?
[ ] Did you add new integration tests?
[ ] If this is a regression, did you write a test to catch this in the future?

The link leads to 404 is it expected behaviour?

@nLight Looks like they are changing that because yesterday was working fine. If you go to the Jira ticket we can see the links asked to be added here are the same and 404.
I will reach out to see if they are changing the links but that should't block you from reviewing the rest/functionality. Thanks

@weblancaster can you please sit with @leemunroe tomorrow morning to verify behavior at various screen sizes and lowercasing of "Deploying". Thank you 💯

Here are the mockups for reference:

Some things I'm noticing:

Change the "Configure" button style to outline
Change the "Deploy" button to primary (purple) rather than green (this is something we're trying to gradually roll out so we're not using "Success" buttons)
Change "Deploying" to "deploying" (lower case d)
The text "By deploying you agree..." is ideally vertically aligned with the "Certified 3.1x" text and be the same size and color as the version text
The link for "terms & conditions" is ideally the same grey text so it isn't drawing too much attention
Do you have a mobile screenshot? Not overly concerned about the mobile styles and alignments as long as the links and buttons are accessible

@leemunroe @MatApple the PR updated to follow the new style changes.
desktop

mobile

Beautiful 🎨
Ship it 🚢

retest please

retest this please


Research and implement monitoring of services

In order to measure operational feasibility, we need to gather data about the health of services. To that end, we need a monitoring system in place go gather such data and to provide us with a way to become aware of and react to service outages and resource contention.

Having researched the landscape a bit, I've identified a few options.
OSS

Nagios
Icinga
Sensu

CLOSED

Datadog

Given our past experiences with Nagios/Icinga, and our current experiences with Sensu, we've decided to give Datadog a try, to quickly get something useful up to speed. There is a free tier we can start with to evaluate before needing to spend any money.


SDK function to detect isTDF() and to detect the format

As an end-developer, given bytes I want to know is this a TDF and what type of TDF so I can call the appropriate methods for decryption.

check for the zip header 0x04034b50 and then unzip and then check for a file element called 0.manifest.json

for nano check the nanotdf header for magic number L1L


fix macos + example/main

@kakzaki Can you push new changes especially this PR, I need to this on the host [pub.dev].
Thanks in advance

@kakzaki Can you update the package with this PR on the host


batch API request

Hi,
If we add functionality to create batch request for commvault REST APIs, it will be beneficial for invoking multiple API requests in one batch. Currently we have to call each API one by one. If we have a function to create a batch of a specific number of API requests say 10 or 25 then the user can create a batch of all the requests and then execute at once. A unique string identifier can be provided by the user for each API request and the same identifier will be returned with the response so that user will be able to identify which response is associated with which API request. We can add a method like "batch_request" in commcell.py.

Nice idea.
You can make the enhancement and open a Pull Request on the dev branch.

Is there any progress on this?

Closing this issue, as there has been no progress on this in long time.


Charging with elli charger stops immediately after connecting (since V0123.2)

Describe the bug
After connecting the car (Cupra Leon) to the elli wallbox (with charger meter shelly-pro-3em) loading starts and terminates immediately. It worked before V0123.2.
Steps to reproduce

Connect car to charger
UI reports "charging"
After one or two seconds UI reports "connected"

Configuration details
# open evcc at http://evcc.local:7070
network:
  schema: http
  host: evcc.local # .local suffix announces the hostname on MDNS
  port: 7070

log: info
levels:
  cache: error

# unique installation id
plant: ...

interval: 10s # control cycle interval

meters:
- type: template
  template: sma-energy-meter
  usage: grid
  host: <IP_ADDRESS>
  name: EnergyMeter
- type: template
  template: sma-inverter
  usage: pv
  host: <IP_ADDRESS>
  password: ...
  name: PvGarage
- type: template
  template: shelly-1pm
  usage: pv
  host: <IP_ADDRESS>
  name: PvBalkon
- type: template
  template: shelly-1pm
  usage: pv
  host: <IP_ADDRESS>
  name: PvPavillon
- type: template
  name: ChargerMeter
  template: shelly-pro-3em
  usage: charge
  host: <IP_ADDRESS>

chargers:
- type: template
  template: elliconnect
  ski: ...
  ip: <IP_ADDRESS>
  name: Wallbox

vehicles:
  - name: Cupra
    type: template
    template: seat
    title: Cupra Leon
    user<EMAIL_ADDRESS>    password: ...
    vin: ...
    capacity: 13
    phases: 1

loadpoints:
- title: Garage
  charger: Wallbox
  vehicle: Cupra
  meter: ChargerMeter
  mode: minpv
  phases: 3
  mincurrent: 6
  maxcurrent: 16

tariffs:
  currency: EUR # (default EUR)
  grid:
    # static grid price
    type: fixed
    price: 0.4228 # [currency]/kWh

  feedin:
    # rate for feeding excess (pv) energy to the grid
    type: fixed
    price: 0.1183 # [currency]/kWh

site:
  title: Mein Zuhause
  meters:
    grid: EnergyMeter
    pv:
      - PvGarage
      - PvBalkon
      - PvPavillon

eebus:
  certificate:
      private: |
          -----BEGIN EC PRIVATE KEY-----
          ...
          -----END EC PRIVATE KEY-----
      public: |
          -----BEGIN CERTIFICATE-----
          ...
          -----END CERTIFICATE-----

Log details
Dec 29 15:26:35 smarthome evcc[7518]: [lp-1  ] INFO 2023/12/29 15:26:35 car connected
Dec 29 15:26:35 smarthome evcc[7518]: [lp-1  ] INFO 2023/12/29 15:26:35 start charging ->
Dec 29 15:26:35 smarthome evcc[7518]: [lp-1  ] WARN 2023/12/29 15:26:35 charger out of sync: expected disabled, got enabled
Dec 29 15:26:45 smarthome evcc[7518]: [lp-1  ] WARN 2023/12/29 15:26:45 charger logic error: current mismatch (got -1A, expected 2.2A)
Dec 29 15:27:05 smarthome evcc[7518]: [lp-1  ] INFO 2023/12/29 15:27:05 stop charging <-

What type of operating system are you running?
Linux
Version
0.123.2

It seems that the firmware update of the shelly pro 3em produced the problem. After reconfiguring (and restarting) it evcc works as expected.


Add ccdb5-ui npm infrastructure

Additions

Adds ccdb5-ui template to the CCDB complaint landing page infrastructure.
Removes ccdb5-ui wheel and replaces it with npm module.

Changes

Update complaint app name to ccdb-complaint.

How to test this PR

Pull branch and run gulp clean && gulp build.
Visit http://localhost:8000/data-research/consumer-complaints/search/ and compare to production.

Holding this till more of data products is back in the office after the holidays, in case something goes wrong.


fix: pymupdf version

This PR allows the PyMuPDF version to be 1.18.15 for in-house compatibility issues.
Any feedback is welcome!

It is indeed not working with 1.18.11, it works since the 1.18.13


Add data/rand-many-types

This adds a file in Arrow IPC stream format containing 100,000 rows x 20 columns of random data exercising many different Arrow data types, and the Python script used to generate the file. I will use this in some new http examples.

There are a number of similar files in arrow-testing that are similar (and sorted vaguely by type category) here: https://github.com/apache/arrow-testing/tree/master/data/arrow-ipc-stream/integration/1.0.0-littleendian . Is it worth using those for any part of the experiment?

If this were intended for long-term use or if it required significant effort to create, then I would have looked at reusing an existing asset instead of creating a new one here. But as is, I think the convenience of having this in the same repo and the ability to easily use this to test type-related issues with Arrow-over-HTTP outweigh the benefits of reuse.

The only thing I would request for the here-and-now would be to ensure there's a seed set so that the next person who runs this gets the same result.

Done in e1e43ca. Thanks!


SILGen: Emit references to noncopyable global storage directly as a borrow.

Later analyses are too conservative to remove a copy, but it should be fairly safe to elide the copy for noncopyable globals, since accesses are tightly scoped and dynamically checked, so consumes aren't possible, and borrows and inout accesses of mutable globals are dynamically guarded and not subject to exclusivity checks. rdar://114329759

@swift-ci Please test

@swift-ci Please test


Mutliple entities and dependencies  in one sentence

Hello,
I have multiple entities and dependencies in one sentence and I'm using the PretaggedCandidateExtractor. For example, I have predefined dependencies  [chemical A-disease A] and [chemical B-disease B] in one sentence. However, if I use "chemical" and "disease" as key words, the model will also add dependencies [chemical A-disease B] and [chemical B-disease A]. Is there a way to remove the extra dependencies?
I'd appreciate it very much if someone can provide suggestions.

The PretaggedCandidateExtractor currently iterates through all entities to create these pairs here.  You can edit the tagger as needed!

Hi @ylizi, we've moved the information extraction version of Snorkel (v0.7) to https://github.com/snorkel-team/snorkel-extraction. Feel free to reopen this issue there!


Add support for hosting Blazor Web components directly in WPF (.NET Core)

To simplify some common scenarios we should add support for directly hosting Blazor Web components in WPF (.NET Core) applications. This would use Edge WebView2 directly but still re-use many of the same APIs and patterns used elsewhere in Mobile Blazor Bindings.
The work is to:

Factor out much of the hybrid-related code into a new Microsoft.MobileBlazorBindings.Hosting project
Change existing MBB to use the new shared Hosting project
Create a new Microsoft.MobileBlazorBindings.WPF project that uses WebView2 and the shared Hosting logic

Ideally this wouldn't change or break any existing MBB applications because all the old APIs should still exist. But there could be a namespace change here or there. We'll see, but not a big deal.

This is what a simple sample app looks like:
XAML:
    <DockPanel Margin="6">
        <StackPanel Margin="6" Orientation="Horizontal" DockPanel.Dock="Top" Background="CadetBlue">
            <Label>This is native WPF UI</Label>
            <Button Click="Button_Click" Padding="6" Margin="3">Click to see counter value</Button>
        </StackPanel>
        <blazorwpf:BlazorWebView HorizontalAlignment="Stretch" VerticalAlignment="Stretch" x:Name="MyBlazorWebView" />
    </DockPanel>

Screenshot: (top blue-ish section is WPF XAML, bottom section is Blazor Web rendering HTML into a WebView2):

So this removes the need for Xamarin?
Also, how difficult is this to port to .Net 5 (if it isn't already).
Keep up the great work @Eilon !!!

@RChrisCoble thanks! Yes this is .NET Core 3.1 + WPF + Blazor, so it should work fine on .NET 5 as well. It's only for Blazor Web components. This doesn't have the ability to use Blazor to write native UI (which I think isn't what you were wanting to use right now anyway).

WPF sample app is here: https://github.com/xamarin/MobileBlazorBindings/tree/master/samples/WpfBlazorSample/WpfBlazorSample
And it uses this standard Razor Class Library (RCL) as its web content: https://github.com/xamarin/MobileBlazorBindings/tree/master/samples/SharedProjects/RazorClassLibrarySample

If I try to use it with .NET 5
  <PropertyGroup>
    <OutputType>WinExe</OutputType>
    <TargetFramework>net5.0-windows</TargetFramework>
    <LangVersion>latest</LangVersion>
    <UseWPF>true</UseWPF>
  </PropertyGroup>

  <ItemGroup>
    <PackageReference Include="Microsoft.MobileBlazorBindings.WPF" Version="0.6.69-preview" />
  </ItemGroup>

it throws this exception:
System.TypeLoadException
  HResult=0x80131522
  Message=Method 'BeginInvokeJS' in type 'Microsoft.MobileBlazorBindings.Hosting.BlazorHybridJSRuntime' from assembly 'Microsoft.MobileBlazorBindings.Hosting, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=null' does not have an implementation.
  Source=Microsoft.MobileBlazorBindings.Hosting
  StackTrace:
   at Microsoft.Extensions.DependencyInjection.BlazorHybridServiceCollectionExtensions.AddBlazorHybrid(IServiceCollection services)
   at WpfBlazorSample.MainWindow.<>c.<.ctor>b__0_0(HostBuilderContext hostContext, IServiceCollection services) in C:\WpfBlazorSample\MainWindow.xaml.cs:line 25

The only change I made to the WpfBlazorSample was to remove every use of RazorClassLibrarySample

Mobile Blazor Bindings currently requires .NET Core 3.1. It will eventually require .NET 6 due to some changes that will be required. It could be that with .NET 5 there are some breaking changes that are not accounted for.
@Jinjinov - can you log a new issue for the exception that you're seeing so that we can take a look?

@Eilon Added #339
Approximately when will MBB nightly builds start using .NET 6? In a few days / weeks / months?

@Jinjinov thanks for logging the new issue!

Approximately when will MBB nightly builds start using .NET 6? In a few days / weeks / months?

Probably weeks. I just discussed this a few minutes ago with my Blazor colleagues and once we get a few more things up and running in the official .NET 6 repo I will start the upgrade to .NET 6!

Is the dotnet5 branch sample "WpfNewBlazorSample" already supposed to to something useful? It compiles without problems but no razor component will be shown.

@b-straub that's where we were experimenting with the new .NET 6 work, which is now in the ASP.NET Core repo here: https://github.com/dotnet/aspnetcore/tree/main/src/Components/WebView
The remaining work (non-trivial) is to change this repo to depend on .NET 6 and use the new abstractions. I'm working on some related areas right now, such as enabling .NET MAUI, and that should pave the path towards moving this repo to .NET 6.

@Eilon at the link that you provided there is Microsoft.AspNetCore.Components.WebView.WebView2.IWebView2Wrapper that wraps Microsoft.Web.WebView2.Core.CoreWebView2 - do you have plans to also support the WebView2 control on macOS and Linux? Would it be hard to get a working proof of concept?

Hi @Jinjinov when there's full support for WebView2 on non-Windows platforms it's definitely something we will take a look at.

Thanks @Eilon for the link to the sample code. Yesterday I got something working by pulling out the WinForms example and the Microsoft.AspNetCore.Components.WebView.WebView2 + Microsoft.AspNetCore.Components.WebView.WindowsForms project. My complex Razor page appeared, but using RCL and third-party components didn't work well (had to manually include the static assets) and some other issues with JS and CSS (isolation) were also present.
In the latest Nightly builds, the relevant packages are now released, but I can't even get the WinForms example to work again. The WebView loads, but instead of the content it comes up with an ERR_ADDRESS_INVALID (https://<IP_ADDRESS>).
I assume it is work in progress and still a bit too early for serious testing.

@Eilon please check Exception thrown from StaticContentProvider._manifestProvider

For those that land here looking for the latest on the WPF and WinForms BlazorWebView, it arrived today with .NET 6.0 Preview 3:
https://devblogs.microsoft.com/aspnet/asp-net-core-updates-in-net-6-preview-3/

@Eilon Looking at https://github.com/dotnet/aspnetcore/tree/main/src/Components/WebView/Samples - thank you for your hard work!
There are many duplicate files in the BlazorWinFormsApp and BlazorWpfApp folders.
Just out of curiosity, which files could be moved to WebviewAppShared?
I am guessing that Index.razor, Other.razor and AppState.cs could go to WebviewAppShared without a problem?
What about app.css, index.html, _Imports.razor and Main.razor?
Could any of them be moved to WebviewAppShared? That would be very convenient for my Blazor PWA as I could make a Windows desktop app easier :)

@Eilon There is a bug with the WinForms sample: https://github.com/dotnet/aspnetcore/issues/31691


Fix federation

🗣 Description
q92_plan.txt

🔨 Related Issues

⛓💥 Breaking Change

[ ] "Breaking Change" label added if this PR is a breaking change

📄 Documentation Updates

🤔 Concerns

Closed in favor of https://github.com/spiceai/spiceai/pull/3909


Non colorised masks

Where can I find the non-colorised labels or masks?

Hi, the official dataset of NYUDv2 provides non-colorised labels/masks.


Change klog info messages after a strategy is exited into error messages

Builds on top of https://github.com/kubernetes-sigs/descheduler/pull/407

/lgtm

/test pull-descheduler-verify-master


Replicating mining studies with SOFAS

http://ieeexplore.ieee.org/xpl/articleDetails.jsp?arnumber=6624050

Data used from git hub API


[Doc] Divider - Fixes form example to use showUnderline prop instead of underlineStyle

Forgot to update this example after implementing optional underline for TextField.

@newoga Nice :+1:.


Saving Naive Bayes Classifier

Hi!
Does anyone know if there is a way to save a Naive Bayes Classifier (like to a file)? I have a static training set, so it would be great if I didn't have to recreate the same classifier every time the program runs.
Thanks!

@chenc17 what is the library that you are using to build the classifier?

@vmesel I'm using the textblob.classifiers module (i.e. "from textblob.classifiers import NaiveBayesClassifier"). Thanks for the link, I will look into that!


Implement Onboarding Screen

See the design of the app in the readme file of this repo and implement on boarding  screens as it is shown.

please assign this to me as id like to work on it

I'm on


[Suggestion] Hide table button labels on Mobile

Suggestion
By hiding the labels of action buttons on Mobile there are more space for other important columns.
Also, since it's mobile, I would make the buttons a little bit larger.

If you guys find it useful I can make a PR for this.

Hmm... I don't know, I'm not a big fan of buttons without a clear label, but I guess I could be convinced otherwise. Here's why:
Problem no 1)

showing no label would be visually (and cognitively) ok for buttons like Edit, Delete, Preview - the default buttons;
but it wouldn't work as well for custom buttons - the icons are rarely perfect for the action; so a "moderate" or "launch" or "publish" button would still need the label, even on mobile, for the best experience; so it might end up looking something like this, which makes it look like that button is more important than the rest, which is not necessarily true; added cognitive load + visual inconsistency;

Problem no 2)

what happens when the buttons get hidden from the datatables, and are then only shown in the modal? there's no need to hide the text then - there's enough space there to show the label - and it's more intuitive to do so; zero cognitive load;

In my experience, the default responsive behaviour (show the actions column if all buttons with labels fits the viewport) provides a really good UX. But I'm definitely biased on that one.
@promatik , what's your opinion on the problems above?
Cheers!

We implemented "label free" actions for a client (even on desktop version, but bigger and colored):

The client and the employees are happy about this. But I'm not sure whether no labels should be standard on mobile.

@tswonke I think that's nice. Color-codes on point, and definitely help. Admins could get used to this, I think. But I don't think it's very intuitive. Sure, you know what each button does after you use it once. But not from the first second. Which... I think is a mistake most admin panels make... Wouldn't want us to do it too... For the moment, I think keeping the labels would be better...
Let me know if you feel otherwise - let's leave this open to gather more feedback.
Cheers!

I use dropdown for list action buttons in few of my project. 4 or more buttons occupies a lot of space from the table row even if there is no label on them.

For buttons whitout label I suggest bootstrap tooltips on hover.
Also it would be nice if we move the action buttons to the top of the table from the bottom and render as a dropdown (or split dropdown). In my opnion this solution would be nice for the export buttons too.


Release artifacts for release v0.0.1

Release artifacts for release v0.0.1
Signed-off-by: Amine Hilaly<EMAIL_ADDRESS>By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

/hold

/unhold