WebUI instance types in aws an gcp should be dropdown

Make them dropdowns, with value of actual instance type, but name containing type, CPU,RAM count and price.

Done


Unfollow_Everyone.js

This script unfollows everyone in your following regardless if they were followed by this bot or not

Mmmm is a dangerous action to perform this days.


Setting BorderTop(false) disappears entire border

Hi all!
I'm having a blast with Bubbletea and Lipgloss, but I misunderstood something.
leftOnly = lipgloss.NewStyle().
		BorderStyle(lipgloss.Border{Left: "   new             "}).
		BorderTop(false). //these are the problem
		BorderRight(false). //
		BorderBottom(false).   But as soon as I call one of these the border disappears entirely. I would have expected that the respective border would not have been rendered?
(I don't think it has anything to do with the hack I used to display the text "new" vertically in the left border.)

Good catch! I'd classify this as a bug. This also begs reexamining the behavior here in general:
Right now, if a style has a border set, but no specific top/bottom/left/right rules, the border applies to the entire box. As soon as one of the sides has a border true value, the other borders are treated as false.
Irrespective of breaking API changes, do we think this type of logic still makes sense?

In general, I would like to have more control over the borders (I'm massively biased because I'm trying to create a 'cyberpunk' feel to the interface I'm writing).
In that sense, the behaviour you are describing would be suboptimal. (To paraphrase you in order to check if I understand correctly: if you use a border with a true value (via BorderBottom(true) for example) the other borders disappear.
I would like the ability to true off and on each individual border.
On a slightly related note: adding Blink(true) to a border didn't have any effect. Perhaps intentional?

Oh, to clarify, you can always turn borders back on once they’re auto-set to false. What I’m describing is just default behavior which can always be overridden.
As for blink, it won’t affect borders however it is possible to make borders blink (with a little work) using Bubble Tea.


Create migrate-2019 for 4.1-RC

Refactor migrate-2017 to reduce code duplication
Split large files into multiple small ones
Move Service item filtering to separate transformation
Service is an item, not a property (bugfix)
Remove duplicates from input paths (e.g. when globbing like **\* a single project could be added twice: from actual glob search and from solution traverse)
Update MSBuild.Sdk.Extras versions for both .NET Core 2.x & 3.x
Update AppVeyor configuration (fix #254)

@hvanbakel one more NuGet package is required for the new dotnet migrate-2019 global tool. We can't reuse legacy .Console API key for obvious reasons.

@mungojam related to your comment https://github.com/hvanbakel/CsprojToVs2017/pull/243#issuecomment-487751092:
That's strange. My response on that thread was incorrect. You don't need to set target execution moment on your pre/post-transforms passed through ConversionOptions, they are executed separately from topologically sorted ones. I believe the reason you saw what you saw on your screenshot is that you've added the same transforms to TransformationSet. It's not necessary. Moreover, this makes your custom pre/post transforms run twice (as part of transformation set and separately from ConversionOptions).
I'd deprecate PreDefaultTransforms and PostDefaultTransforms at all, and force everything to be part of one transformation plan graph (that is, via ITransformationSet). This would remove such ambiguities.

@andrew-boyarshin, by that point I had given up on trying to use the conversion options route as the transforms would get run twice due to the way the Facility class processed things (sorry can't remember exact reason at the moment).
I think the concept of pre and post transforms covers a lot of scenarios, but as long as the way I have put in the readme still works then I'm ok with dropping the ConversionOptions pre/post in order to simplify the logic.

I’ll have a look at it over the weekend, I just tot an email about an expiring NuGet api key anyway so I’ll create the 2019 one too.
The downside from creating a completely new tool though is that users will need a new package to install. And since the problem is not remotely as big as it was for 2015 to 2017 I don’t expect a lot of people to install that. Should we maybe check if one package can contain multiple commands?

@hvanbakel as long as we recommend using migrate-2019 instead of migrate-2017 (e.g. in README.md) no further action will be needed. migrate-2019 is as functional as migrate-2017, transformation sets differ only by a single WPF/WinForms transformation, 99% of the code is shared and reused. It is possible to migrate from 2010 to 2019 in a single migrate-2019 command.

OK then, pending new NuGet package for 4.1 release. Meanwhile, I'll update the README and add some [Obsolete] annotations.

New keys are here:
https://github.com/hvanbakel/CsprojToVs2017/commit/ff1c66c179c526120b4b046aa227d33e18fe8e8f
The 2019 key is in comment to be uncommented here.


Support arbitrary datacontenttype in publish/subscribe

In what area(s)?

/area runtime
Describe the feature

Today if Content-Type header in publish request has value different from application/json the runtime sets datacontenttype property of cloud event envelope to text/plain. That prevents users from annotating their event payload with semantic content types e.g. application/xml, etc.
It shouldn't be an issue if dapr runtime would use the Content-Type header value as is.

You can still pass entire CE payload with the different data content type. - https://github.com/dapr/components-contrib/blob/e5a50cb2daa50d53709bf9fbdf2b3f59cf744b16/pubsub/envelope.go#L73-L92
@mchmarny looks like we might not document how to pass the user CE payload. Have we documented how to use user CE payload?

To prevent the implicit "conversion" you've outline, wrap whatever payload you want to be delivered to your subscribing apps as CloudEvent. Starting with Dapr v0.9 we no longer wrap published content into CloudEvent if the payload itself is already a CloudEvent. Here is how you can see how this works.
Assuming your have some XML payload (really can be any format):
<note>
   <to>User1</to>
   <from>user2</from>
   <message>hi</message>
</note>

You wrap it into CloudEvent, like this:
{
    "specversion" : "1.0",
    "type" : "some.other.message",
    "source" : "https://domain.com/message/sender",
    "subject" : "test message",
    "id" : "id-1234-5678-9011",
    "time" : "2020-09-23T06:23:21Z",
    "datacontenttype" : "text/xml",
    "data" : "<note><to>User1</to><from>user2</from><message>hi</message></note>"
}

When you post that to Dapr like this
curl<EMAIL_ADDRESS>\
     -H "Content-type: application/json" \
     "http://localhost:3500/v1.0/publish/your-component-name/messages"

The content fo the data delivered to your subscribing app will be:
== APP == event - PubsubName: your-component-name, Topic: messages, ID:id-1234-5678-9011, Data: <note><to>User1</to><from>user2</from><message>hi</message></note>

Note, I'm using the go-sdk here so your logs may look differently

I got a full working example of that here. Will make sure we document how to do this in Dapr docs.

@mchmarny can we move this issue to dapr/docs to follow up documentation ?

I talked to @maksimkim about this offline, he wants the ability to change the datacontenttype without being forced to compose the entire CloudEvents envelope.

@yaron2 can you elaborate on the feedback some more? Supporting any content type while keeping CE are kind of not mutually compatible... short of some hack with "special" header property that switches the flow of event and prevents CE from being used at all maybe.

I just tested publishing with JSON and XML and the content-type is not propagated correctly for the XML case:
curl --location --request POST 'http://localhost:3500/v1.0/publish/pubsub/Topic2080' \
--header 'Content-Type: application/json' \
--data-raw '{ "hello": "world"}'

curl --location --request POST 'http://localhost:3500/v1.0/publish/pubsub/Topic2080' \
--header 'Content-Type: application/xml' \
--data-raw '<root></root>'

←[94;1m== APP == <IP_ADDRESS> - - [07/Oct/2020 17:23:49] "←[37mPOST /A HTTP/1.1←[0m" 200 -
←[0m
←[94;1m== APP == {'id': '7a671c05-cd4b-44dd-9597-c49d9053d7c1', 'source': 'Raverviolet-Cowl', 'type': 'com.dapr.event.sent', 'specversion': '1.0', 'datacontenttype': 'text/plain', 'data': '<root></root>', 'subject': '00-2bae582ef46841c69e5b11c3ec97c0fe-9b8f7cdeea36c57f-01', 'topic': 'Topic2080', 'pubsubname': 'pubsub'}
←[0m
←[94;1m== APP == <IP_ADDRESS> - - [07/Oct/2020 17:28:40] "←[37mPOST /A HTTP/1.1←[0m" 200 -
←[0m
←[94;1m== APP == {'id': 'b8fdc779-e6af-4e7b-b7b9-a64778f0c517', 'source': 'Raverviolet-Cowl', 'type': 'com.dapr.event.sent', 'specversion': '1.0', 'datacontenttype': 'application/json', 'data': {'hello': 'world'}, 'subject': '00-de857738daa1da44e6d8d773aba19686-a84a5bd3f8941f02-01', 'topic': 'Topic2080', 'pubsubname': 'pubsub'}

@yaron2 @mchmarny  it seems that we need to make Dapr handle content-type correctly for other types, not only JSON.


(PUP-10712) Add JSON terminus for node and report

Added JSON termini for node and report.

jenkins please test this with servertests on redhat7-64a,ubuntu1604-64a,windows2019-64a

CLA signed by all contributors.

Not sure if not overriding Terminus#save for report will cause https://tickets.puppetlabs.com/browse/PUP-10325 problem for the json terminus

Not sure if not overriding Terminus#save for report will cause

That's a good point, I had forgotten about that issue. So maybe we should override the save method in cases where the location on disk can be configured as a setting, as a custom mode could be set via key = value { owner => etc }? So keep lib/puppet/indirection/node/json.rb like you have it now, and set lib/puppet/indirection/report/json.rb to how you had it before?

Agreed, overriding Terminus#save just for report terminus


MirRakibHossain- 14-09

Take home Assessment.
From Mir Rakib Hossain

dragAndDrop, dropDown, dynamicContent, dynamicControls, fileDownload, iFrame, jsError assertions are missing.

dragAndDrop, dropDown, dynamicContent, dynamicControls, fileDownload, iFrame, jsError assertions are missing.

Thank you for taking your time to see my code.
i believe all the test are there, that you are looking for. It started from line 99 in my Test Class.
Please see the attached link for my G-Drive for the screenshot. Thank you.
https://drive.google.com/file/d/1P6xK40CTZ7eN8DGl0-oHALJH6dofiHsz/view?usp=sharing

dragAndDrop, dropDown, dynamicContent, dynamicControls, fileDownload, iFrame, jsError assertions are missing.

Thank you for taking your time to see my code.
i believe all the test are there, that you are looking for. It started from line 99 in my Test Class.
Please see the attached link for my G-Drive for the screenshot. Thank you.
https://drive.google.com/file/d/1P6xK40CTZ7eN8DGl0-oHALJH6dofiHsz/view?usp=sharing

Tests are there but actual assertions are missing.

Please check my code for all the missing quote. thank you


wireshark: 3.2.1 -> {2.6.12, 3.0.7, 3.2.1}

Motivation of restoring 2.x is:

libwiretap has breaking API changes in 3.0
2.4 and 2.6 branches are active upstream
2.4.16 is two months old, 2.6.11 is 5 days old

cc @teto

Regarding the motivations, we don't seem to have packages that depend on wiretap ?
and even if old packages are maintained, it doesn't mean, we need  to provide them, wireshark 3 should be superior in every way to wireshark 2.
The motivation seem to be https://github.com/NixOS/nixpkgs/pull/56776#issuecomment-531850596 .  Can't panda upgrade to the latest wireshark ?
The increased complexity looks fine/manageable but better if we could do without it.

wireshark 3 should be superior in every way to wireshark 2

only in a way as a GUI program, not a as an incompatible C library
kind of superiority of gtk 3 over gtk 2

Although I do not mind if the GUI program (wireshark-qt) will be only 3.0 to save Hydra cycles.
All I need is from wireshark 2 is dev files

rebased

is that ok to merge a merge ? as in nixos policiy, I am afraid it will break some workflows. I tend to prefer rebased commits.
Do you need the 2.4 too ? trying to save hydra cycles should be necouraged, if someone needs the 2.6 gui we can revisit.

Since the 2.4 branch is not listed on the Wireshark download page and with 3.0 listed as stable and 2.6 as old stable, I would prefer if we don't add 2.4 at all.
Apart from that the PR looks good, thanks! We probably should also backport this to ease backporting package bumps in the future.

Yes, it must be {2.6.12, 3.0.6, 3.1.0} now
It would be nice if @r-ryantm updates PRs too :)

sorry i intended to merge this but  the merge of master into it is an issue. Please use a rebase instead ? and I'll merge

the duplication of hashes between the Qt and CLI variants is ugly.

The very existing of Qt and CLI variants (and thus identical wireshark-cli.dev and wireshark-qt.dev) built from the same sources are ugly, there should be a single multiple-output derivation with
wirestark3.cli, wireshark3.qt, wireshark3.dev (and another with wirestark2.cli, wireshark2.qt, wireshark2.dev)

@volth Since it doesn't seem to be needed in nixpkgs, how about maintaining the 2.x version you need outside of nixpkgs? NUR could be used if other people are interested in such an older version too.

Well, how about at least fixing optionalString withQt login in postInstall ?
currenly wireshark.dev has no include files
Or wireshark.dev doesn't seem to be needed in nixpkgs too?

Oh the fixes are great. I'm just talking about the part of this PR that adds the older versions, which apparently some people don't like. Though after reconsideration, I think an older version should be fine in this case, given that at least @volth is in need of it, which probably means other people are too, in addition to the fact that it's maintained upstream. And a package being used in nixpkgs was never a requirement for including packages in nixpkgs anyways.
@fpletz @jtojnar Would you reconsider? I think it would be fine to add at least one older version, given the circumstances
Though I don't get why 3.0.7 would be needed, can you explain @volth? Having multiple versions is a burden, so we shouldn't introduce them without good reasons.


XCreds banner when exiting out of encrypted preboot (sometimes indicating 14 day license expiration)

XCreds version 5.0 and various macOS versions (e.g. 14.7 and 15.1 RC). Jamf JSON schema built from 5.0 compatible manifest. It's been noticed recently that XCreds will display banner at bottom of screen while exiting out of encrypted preboot, at times w/ added messaging about 14 day trial (we have working license file in place). This is only present for a brief period (1-2 seconds) and disappears. This isn't a blocking/breaking issue, but is aesthetically confusing should a user witness it. I've sent a log file via Slack. Slack discussion link/thread: https://macadmins.slack.com/archives/C03GBF2DE7P/p1727427941855859

Perhaps let some other folks test/validate as well before closing this out, but PreBeta-XCreds_Build-7261_Version-5.1 does indeed seem to correct this issue. Many thanks!

Not sure what changed, but closing :)


Debug mode compilation does not include debug symbols

Debug symbols are missing from the CONFIG=Debug compiled artifacts.

CC: @TT-billteng

is this fixed with the gdb 14.2 upgrade?

Helloooooo update? @mywoodstock

You use default compiler for gcc on tracy for this one PR I saw from you

You use default compiler for gcc on tracy for this one PR I saw from you

That was a workaround for a different issue (compilation errors with tracy enabled.)
@vtangTT any update on this issue/eta?

Is GDB 14.2 able to pick up the debug symbols? It should be available in our docker image now.

Is GDB 14.2 able to pick up the debug symbols? It should be available in our docker image now.

yes, looks like its working now with 14.2 :)
I guess we can close this? @vtangTT

Sounds good to me 👍


Text is overlapping their cells when generating the pdf in different screen size, or when using zoom.

Hello,
The issue has already been opened and no answer was provided, i'm in a real need of a solution to get this blocking point done.
I used JSPdf in my app and it seems to be working correctly, but when i tried it on a different machine with a different screen size, the result is a pdf with some text overlapping their cells, i think there is a request with the same issue and there is some screenshot of the issue, hopefully i can get an answer to this.
Here's the issue : https://github.com/MrRio/jsPDF/issues/879

This sounds to me that it is most likely a pdf reader issue.
@MrRio
Please mark it as duplicate.

facing this same issue, overlapping on small screens or bigger screens.


Update hacl-star 0.2

https://github.com/project-everest/hacl-star/blob/fstar-master/README.EverCrypt.md
https://github.com/project-everest/hacl-star/releases/tag/v.0.2.0
EverCrypt added the Vale code, which brings simd support to hacl-star.

The team behind EverCrypt is also interested in having good Rust bindings. It might make sense to combine the effort here. Would you be interested in that?
PS: I think EverCrypt is the combination of HACL* and Vale, so the assembly code from Vale lives alongside the C code from HACL*.

Of course! I'm interested in this!
EverCrypt API is completely different, so progress is currently stalled. :(

Great!
I tried to reach out to you on Wire (by guessing your username), maybe we can continue the conversation there (for a bit at least)?

Sorry, my network cannot access wire. :'(
Do you use irc or matrix? You can reach me using quininer at freenode or @quininer:mozilla.org .


[WIP] bots: Improve and refactor docs to use Markdown macro framework.

@timabbott, @showell, @derAnfaenger: This is a starting point for how we can improve and render docs in the main repo and the disadvantages associated with doing so. I think I'd like to start a longer discussion about this tomorrow at the integrations meeting, so this is largely a WIP. Once we reach consensus on how to move forward, I can accelerate this project! :) Thanks!

@eeshangarg did you have more questions about this, or should I merge it?  It looks reasonable.

@timabbott: These commits are good to be merged! I was thinking I would push more commits here to the same PR as I work on other bots, but I think I'll make individual PRs for individual bots just to avoid confusion as to when something is a WIP and when it isn't. Thanks! :)

Merged, thanks @eeshangarg!  I think we may want to pause before writing docs for more of these, to figure out whether there are pieces we can automate (e.g. the "--help") piece from @neiljp's PRs.


[enhancement]  Option "always on top"...

Search tab box, tab counter, new tab button -
always on top (doesn't scroll with a tabs list).

Hi! Thanks for your interest in the extension!
Do you mean you would like them to scroll with a tab list?


Generate constructors taking custom scopes for TokenCredential

Describe the issue or request
@azure-tools/typespec-csharp: 0.2.0-beta.20231212.1
When OAuth2Auth is used for auth in TypeSpec, autorest generates the following constructor overloads that takes TokenCredential. But the authentication scope is hardcoded and cannot be modified by caller. In some cases, caller wants to send request against a different URL with a different authentication scope such as request against a testing environment.
public class MyClient
{
    public MyClient(Azure.Core.TokenCredential credential) { }
    public MyClient(System.Uri endpoint, Azure.Core.TokenCredential credential, Microsoft.Learn.MyClientOptions options) { }
}

Describe your ideas for solutions
Generate an additional constructor that takes a scope parameter, or add the scope parameter to ClientOptions
public class MyClient
{
    public MyClient(Azure.Core.TokenCredential credential) { }
    public MyClient(System.Uri endpoint, Azure.Core.TokenCredential credential, Microsoft.Learn.MyClientOptions options) { }
    public MyClient(System.Uri endpoint, Azure.Core.TokenCredential credential, string[] scopes, Microsoft.Learn.MyClientOptions options) { }
}

Additional info
scopes are customizable in autorest.typescript with:
    const client = MyClient(new DefaultAzureCredential(), {
        credentials: {
            scopes: ['foo/.default']
        }
    })

Duplicated with https://github.com/Azure/autorest.csharp/issues/3432

Close as duplicate.


Document error behavior for SQS based events

The existing examples for SQS message lamba invocations are very simple.
https://github.com/aws/aws-lambda-go/blob/master/events/README_SQS.md
It would be useful to add 2 additional examples.
Failing all messages for retry
Assuming multiple SQS messages are received, is it possible to return an error such that they are retried?  I assume this is the default behavior, but it is not called out clearly in the examples.
Failing single messages/Acking individual messages
Assume 3 messages are received.  The first message succeeds, the second fails, and the third succeeds.   Can the lambda client use the SQS SDK in conjunction with the SQSMessage.Handle to delete messages 1, and 3 directly, causing only message 2 to be retried?
The above use cases are valid use cases in SQS queue consumption, but the documentation in lambda invocation is not clear on how to accomplish these use cases.  If they could be added, it would be very helpful for new users.

@bmoffatt I am looking around this repo for issues I can possible contribute to. Is this issue still something that can be picked up?


Error when deleting a model from a project

I removed all model sources from a model, and now want to delete the model from the project. However, I'm getting an error with the following stack trace:
time="2023-06-23 10:07:09,231" level=DEBUG function=dispatch client="<IP_ADDRESS>:51244" trace_id="OLI8C0H33O" method="DELETE" path="/api/v1/projects/<project>/models/<model>" user="<me>" message="request started"
time="2023-06-23 10:07:09,269" level=ERROR function=dispatch client="<IP_ADDRESS>:51244" trace_id="OLI8C0H33O" method="DELETE" path="/api/v1/projects/<project>/models/<model>" user="<me>" message="(psycopg2.errors.NotNullViolation) null value in column "model_id" of relation "model_restrictions" violates not-null constraint
DETAIL: Failing row contains (66, null, f).
[SQL: UPDATE model_restrictions SET model_id=%(model_id)s WHERE model_restrictions.id = %(model_restrictions_id)s]
[parameters: {'model_id': None, 'model_restrictions_id': 66}]
(Background on this error at: https://sqlalche.me/e/20/gkpj)"
Traceback (most recent call last):
File "/tmp/backend/capellacollab/core/logging.py", line 75, in dispatch
  return await call_next(request)
         ^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/local/lib/python3.11/site-packages/starlette/middleware/base.py", line 84, in call_next
  raise app_exc
File "/usr/local/lib/python3.11/site-packages/starlette/middleware/base.py", line 70, in coro
  await self.app(scope, receive_or_disconnect, send_no_error)
File "/usr/local/lib/python3.11/site-packages/starlette/middleware/base.py", line 108, in __call__
  response = await self.dispatch_func(request, call_next)
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/tmp/backend/capellacollab/core/logging.py", line 86, in dispatch
  response: fastapi.Response = await call_next(request)
                               ^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/local/lib/python3.11/site-packages/starlette/middleware/base.py", line 84, in call_next
  raise app_exc
File "/usr/local/lib/python3.11/site-packages/starlette/middleware/base.py", line 70, in coro
  await self.app(scope, receive_or_disconnect, send_no_error)
File "/usr/local/lib/python3.11/site-packages/starlette/middleware/base.py", line 108, in __call__
  response = await self.dispatch_func(request, call_next)
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/local/lib/python3.11/site-packages/starlette_prometheus/middleware.py", line 57, in dispatch
  raise e from None
File "/usr/local/lib/python3.11/site-packages/starlette_prometheus/middleware.py", line 53, in dispatch
  response = await call_next(request)
             ^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/local/lib/python3.11/site-packages/starlette/middleware/base.py", line 84, in call_next
  raise app_exc
File "/usr/local/lib/python3.11/site-packages/starlette/middleware/base.py", line 70, in coro
  await self.app(scope, receive_or_disconnect, send_no_error)
File "/usr/local/lib/python3.11/site-packages/starlette/middleware/exceptions.py", line 79, in __call__
  raise exc
File "/usr/local/lib/python3.11/site-packages/starlette/middleware/exceptions.py", line 68, in __call__
  await self.app(scope, receive, sender)
File "/usr/local/lib/python3.11/contextlib.py", line 222, in __aexit__
  await self.gen.athrow(typ, value, traceback)
File "/usr/local/lib/python3.11/site-packages/fastapi/concurrency.py", line 36, in contextmanager_in_threadpool
  raise e
sqlalchemy.exc.IntegrityError: (psycopg2.errors.NotNullViolation) null value in column "model_id" of relation "model_restrictions" violates not-null constraint
DETAIL: Failing row contains (66, null, f).
[SQL: UPDATE model_restrictions SET model_id=%(model_id)s WHERE model_restrictions.id = %(model_restrictions_id)s]
[parameters: {'model_id': None, 'model_restrictions_id': 66}]
(Background on this error at: https://sqlalche.me/e/20/gkpj)

Thanks for reporting @Wuestengecko.
@dominik003 This is most likely the reason for the one null value in the model_id column model_restrictions that we found one of the production databases.
How to reproduce:

Create a new model
Try to delete it

Seems like this affects all of our models.


The 3 second timeout is dead in code(HttpClientPluginConfiguration)

I set a 5 second timeout in admin. I want to test the functionality ,but my request always timeout at 3 second. I check code ,find The 3 second timeout is dead in code(HttpClientPluginConfiguration):
c.addHandlerLast(new WriteTimeoutHandler(properties.getWriteTimeout(), TimeUnit.MILLISECONDS));
c.addHandlerLast(new ReadTimeoutHandler(properties.getReadTimeout(), TimeUnit.MILLISECONDS));

I want to know if I can del this timeout config,Will there be a problem？ because we will use it in prod

It can work, please don't delete it.Please see the line 93 in org.apache.shenyu.plugin.divide.DividePlugin

I know, but if "exchange.getAttributes().put(Constants.HTTP_TIME_OUT, ruleHandle.getTimeout());" the ruleHandle.getTimeout() > 3000 ,It doesn't work

Hello @dengliming, did you have any suggestion.

Hi , I think The 3 second timeout in code(HttpClientPluginConfiguration) is the global Configuration, it‘s means The http readTimeout is 3 second,if you want set timeout > 3000,you should set the global timeout > 3000,then  you can set the  ruleHandle timeOut

ye I know,I just hope this can dynamic configuration or more obvious in shenyu subsequent versions. I hope shenyu  better and better.


pom: Update developers in pom xml file

To keep in sync with OWNERS.
Signed-off-by: JP Simard<EMAIL_ADDRESS>

ptal @buildbreaker


Add offer window not working after posting N items, possibly related to changing max offers

TangoTracer writes:

If you use the keybind or context menu to add offer to flea market from stash directly, it will eventually bug out and freeze the game with these windows opened. ALT+F4 is the only way to fix I've found. Happens after 5 or so offers I think but wasn't counting either time it happened. I have SVM set to 20 offers, maybe it gets locked after default number of offers is exceeded?

can't repro yet...


initialEditorState not working on LexicalComposer

Lexical version: 0.3.5, react.
With recent updates from 0.3.3 to 0.3.5 I now get this warning in the console:
initialEditorState on RichTextPlugin is deprecated and will be removed soon. Use LexicalComposer initialEditorState instead

So I went to github and the documentation website, searching for information on initialEditorState.
But found nothing.
So I thought: Well, let's just try doing what the warning says.
I moved
initialEditorState={value ? JSON.stringify(value) : undefined}

from RichTextPlugin to LexicalComposer.
Now the warning disappears, as expected. But initial state is not set. Which is unexpected.
The value I am passing in was created with state.current?.toJSON() from state updated with the newState returned by the onChange of the OnChangePlugin. This works fine in the RichTextPlugin.
Please help me find the documentation, so I can try to solve this. Or could it be a bug?
The only thing I found was the pull-request. From what I can tell in the code, simply moving the initialEditorState declaration should work.

CC @zurfyx

I am experiencing the same bug, which is why I keep the initialEditorState at the RichTextEditor, and now we have to live with the deprecation warning. I am quite confident, that this is a bug. We are experiencing this in a ClojureScript project:
;; Works, but keeps deprecation warning
[:> LexicalComposer {:initialConfig initial-config}
 [:> RichTextPlugin {:initialEditorState (initialize-editor-state)}]]

;; Warning disappears, but there is no initial state
[:> LexicalComposer {:initialConfig initial-config
                     :initialEditorState (initialize-editor-state)}
 [:> RichTextPlugin ,,,]]

Maybe they've moved that option into initialConfig?
https://github.com/facebook/lexical/blob/60e06fd11608c2935d1e57063a646befbd7a8405/packages/lexical-react/src/LexicalComposer.tsx#L51-L59
This worked for me.
const initialConfig = {
  theme,
  editorState,
};

<LexicalComposer initialConfig={initialConfig}>
...
</LexicalComposer>


AlkylStructureFragmenter Implementation

First steps for a complete alkyl structure fragmentation.
Currently only contains fragmentation logic for cyclic structures and non-cyclic side-chains.

One general thing: Do i see it correctly that right now, there are settings offered in the GUI for the fragmenter that are actually without function, just mocks? Please, comment them out remove them. It cannot go to the master branch in this state.

@Mila1004 what does the new setting do? Does it turn the fragmentation of alkyl chains on/off?

Note: this PR points to main branch

@Mila1004 we will look at the merge conflicts together.

I guess the instance variables in your test class are creating problems.
You can try fixing that by adding a static initializer setting the default locale to English to your test class:
static {
        Locale.setDefault(Locale.of("en", "GB"));
    }

If I do that, I am "only" getting file not found exceptions because the test resources are not imported correctly.

@Mila1004, when you have time, please merge the current production branch into your branch and adjust your code to the changes made there in the meantime.

@Mila1004 where did you get the example molecules in the MOL and SD files from? There should be a source/reference given somewhere.

@Mila1004 please merge the production branch into your current branch when you have time.


Fix QuotaSpec crash

Fixes https://github.com/istio/istio/issues/24264
I have no strong confidence this works, as we clearly have no end to end tests or this would have been caught. Apparently no one has used QuotaSpec with istiod since this should be broken since 1.5.0
Basically the issue is we are using the golang proto struct instead of gogo proto struct.

@howardjohn: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

lint_istio
5fdf235da23d1e970a4d445a5b23f028b9f1194c
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

lint_istio
5fdf235da23d1e970a4d445a5b23f028b9f1194c
link
/test lint_istio

gencheck_istio
5fdf235da23d1e970a4d445a5b23f028b9f1194c
link
/test gencheck_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

lint_istio
5fdf235da23d1e970a4d445a5b23f028b9f1194c
link
/test lint_istio

gencheck_istio
5fdf235da23d1e970a4d445a5b23f028b9f1194c
link
/test gencheck_istio

unit-tests_istio
5fdf235da23d1e970a4d445a5b23f028b9f1194c
link
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn : I thought we hade ratelimiting tests running in post submit?
We would have to change mixer.go too.. pilot/pkg/networking/plugin/mixer/mixer.go.. that's using mpb "istio.io/istio/pilot/pkg/networking/plugin/mixer/client"....

@gargnupur the problem is the CRD reading library only supports gogo proto and XDS only supports golang protobuf. We run pure envoy tests for rate limitting but none that go through the full pilot pipeline


Fix issue with SwiftyBeaver log format

This solves the issue I have reported (#16). I just modified the regular expression that was parsing the line in the log.

Now it is working in the example I posted in the issue.

@frankdilo can you try @samsonjs version and see if it still fixes your issue?

@krzysztofzablocki Yes. I will try later today 👍

Tried what @samsonjs was suggesting and it works great. You can see it in the last commit.

Awesome, thanks for contributing!


non-latin characters (such as japanese) and Markdown preview anchor

VSCode Version: Code 1.9.1 (f9d0c687ff2ea7aabd85fb9a43129117c0ecf519, 2017-02-08T23:31:51.320Z)
OS Version: Darwin x64 16.4.0

This issue is recognized as not a problem of vscode itself, but because it is used in Markdown extension.
PR: markdown-it-named-header custom slugify for non-latin characters #20628
PROBLEM:
I want to realize an in-page link by using an anchor in Markdown Preview, but it does not work with non-latin characters.
If the header is written in non-latin characters (such as Japanese), it is judged to be an invalid character, so the value of the id attribute is empty.
BACKGROUND:
Markdown-it-named-headers (mdnh) generates an id attribute from Markdown's header element and uses the slug() function provided by strings.js to convert the text to valid URL slug.
example:
# Example Header   -->
Example

There is a problem with non-latin characters.
If the header is written in non-latin characters (such as Japanese), it is judged to be an invalid character, so the value of the id attribute is empty.
As a result of investigation, processing of non-latin characters can not be performed correctly.
(However, it may be correct in the sense that it deletes a character string that can not be used in the URL.)

string.js: slugify

slugify russian (non-english) words #43

truncate doesn't work with non-latin characters (Japanese) #201

Sample Markdown:
* [test](#test)
* [さくら](#さくら)
* [さくら 桜](#さくら-桜)
* [🌸](#🌸)

## test
## さくら
## さくら 桜
## 🌸

Rendered HTML:

test

さくら

さくら 桜

🌸

test

さくら
      <--- here

さくら 桜
   <--- here

🌸
         <--- here

In Markdown extension, there is a process of creating an href link from a header when anchor (#anchor) is specified and rendering  tag.
In this process, the non-latin characters appear to be encodeURI.
I think it is a very good process.
Markdown-it-named-headers has an option to define custom slugify.
So, when a non-latin character was written in the header, I decided to define its custom slug() function.
.use(mdnh, {
	slugify: function (header: string) {
            return encodeURI(header.trim()
 							.toLowerCase()
							.replace(/[\]\[\!\"\#\$\%\&\'\(\)\*\+\,\.\/\:\;\<\=\>\?\@\\\^\_\{\|\}\~]/g, '') //remove symbol
							.replace(/\s+/g, '-')) // Replace spaces with hyphens
							.replace(/\-+$/, ''); // Replace trailing hyphen
					}
})

HTML rendered with custom slugify applied:

test

さくら

さくら 桜

🌸

test

さくら

さくら 桜

🌸

Screenshot:

This is the best for me. Please tell me if there is any other better way.

Fixed by #20628

@mjbvz
Thank you! I will review and report.
After that, your commit was very helpful for me.
Thanks

@mjbvz
perfect!
Thanks.

Marking as verified given @satokaz assessment.


Any examples?

Subj
Server connected, up and running. What next? No manual/examples provided

python -m websockets ws://localhost:8080/
throws error
websockets.exceptions.ConnectionClosedError: no close frame received or sent

I think this project may be dead. I never did get the web server to work. @banderlog


No GUI interface for Debian install

Upon installing I am told:
"This package is run from the terminal, type: kalite"

I just installed through https://launchpad.net/~benjaoming/+archive/ubuntu/ka-lite, and you don't even get that... :D

I know that people who install on Linux are generally pretty knowledgeable, but I believe some indication of how to proceed should be included.

Currently, a prerequisite of fetching the .deb or adding the PPA is to read the docs :) The docs will soon say to run kalite manage setup, I'm adding that in a few minutes.

Sounds good enough! :)

The above message is still there because it's auto-generated by Software Center. However, it's leveraged by a couple of our own debconf messages.
During installation, users are informed of the init.d script and option of installing ka-lite-gtk
Until we start adding in ka-lite-gtk to the .deb itself, we have to live with this. Once we have a desktop shortcut included in the package, we can get rid of the Software Center message... so it'll be solved when ka-lite-gtk is okay'ed and bundled.


Recover sender from signedTxHash

When working with the gas relayer, we receive a signed transaction hash that was signed by the "unknown" paymaster. In my case, this paymaster was not funded. I needed to extract the sender to fund the account. This utility method might be useful in the future.
Problems
Although this unit test demonstrates the viem implementation agrees with ethers. It doesn't agree with what someone else got (in CA Telegram). In fact, trying to relay this transaction with eth_sendRawTransaction resulted in an "INSUFFICIENT_FUNDS" error -- even after the public key of this was extracted.
Note that, from the
signedTxHash:
0x02f872611c847735940085174876e800825208940c0a71335cc50b821570f6f8b302b248d0e56ed4870eebe0b40e800080c080a0d490e3ce4e974cae1f89c4b328bf4dc7ecba7b1cef9838be6282ca92fd5a8127a01c032f8bfa93bd48fb5215813e4f3a21f8e5da015ebd52b4daa945bcc2d4749e
we recover
Incorrect Sender: 0x909BaB1A50EBd17c0E771b8B0BF2A95fEB34B205
While someone else got
Correct Sender: 0x993944ce7ed881a353b7e34f63a37242041629fb.
The "correctness" is concluded by the following observation: Funding the 0x909... account still resulted in INSUFFICIENT_FUNDS, while funding 0x993 resulted in a successful tx with:
txHash: 0x2da68d8765521fdbb331d2696cf51e4bab0ca37e21161350f7f03ec35eb8a540.
Unfortunately

This transaction is still not visible in the block explorer (after more than an hour).
Neither accounts funds have changed.
The very same node that the tx was sent to returns null when requesting eth_getTransactionReceipt, but says Already Exists when trying to resubmit the transaction.

Relevant RPC Requests
Send Signed Transaction
curl https://bsc-testnet.public.blastapi.io \
  -X POST \
  -H "Content-Type: application/json" \
  --data '{"jsonrpc":"2.0","method":"eth_sendRawTransaction","params":["0x02f872611c847735940085174876e800825208940c0a71335cc50b821570f6f8b302b248d0e56ed4870eebe0b40e800080c080a0d490e3ce4e974cae1f89c4b328bf4dc7ecba7b1cef9838be6282ca92fd5a8127a01c032f8bfa93bd48fb5215813e4f3a21f8e5da015ebd52b4daa945bcc2d4749e"],"id":1}'

Get Transaction Receipt
curl https://bsc-testnet.public.blastapi.io \
  -X POST \
  -H "Content-Type: application/json" \
  --data '{"jsonrpc":"2.0","method":"eth_getTransactionReceipt","params":["0x2da68d8765521fdbb331d2696cf51e4bab0ca37e21161350f7f03ec35eb8a540"],"id":1}'

According to this online tool:
https://rawtxdecode.in/ the sender is different.
and this rust implementation: https://github.com/near/multichain-gas-station-contract/blob/master/gas_station/tests/tests.rs#L515

No longer necessary since #23


Pods that never get an IP can never get cleaned up

A pod may never get an IP address assigned, e.g. because it is deleted early during initialization, or because it references a volume that does not exist. But the nomasq agent cleanup fails if the pod does not have an IP:
https://github.com/MaterializeInc/k8s-eip-operator/blob/fe4a5365a0b637ed0f3fc5afc7f1068f84552c5e/cilium_eip_no_masquerade_agent/src/main.rs#L117-L120
This results in pods with stuck finalizers that can never get cleaned up.
I've seen this happen a few times now in our production clusters. Often the result of a failure to issue a certificate for an environment, which results in a certificate reference that doesn't exist, which results in a stuck pod.

Here's ane xample from the logs:
2022-07-30T04:56:40.670264Z  INFO reconciling object{object.ref=Pod.v1./environmentd-0.environment-95434ebd-d8d6-4239-861b-b43b5ed3add2-0 object.reason=error policy requested retry}:reconcile_pod:cleanup_pod: cilium_eip_no_masquerade_agent: Cleaning up pod. pod_name=environmentd-0
2022-07-30T04:56:40.670287Z ERROR reconciling object{object.ref=Pod.v1./environmentd-0.environment-95434ebd-d8d6-4239-861b-b43b5ed3add2-0 object.reason=error policy requested retry}:reconcile_pod:cleanup_pod: cilium_eip_no_masquerade_agent: error=Pod does not have an IP address.
2022-07-30T04:56:40.670309Z ERROR reconciling object{object.ref=Pod.v1./environmentd-0.environment-95434ebd-d8d6-4239-861b-b43b5ed3add2-0 object.reason=error policy requested retry}:reconcile_pod: cilium_eip_no_masquerade_agent: error=failed to clean up object: Pod does not have an IP address.
2022-07-30T04:56:40.670358Z ERROR cilium_eip_no_masquerade_agent: Pod reconciliation error. err=reconciler for object Pod.v1./environmentd-0.environment-95434ebd-d8d6-4239-861b-b43b5ed3add2-0 failed

Should we assume that if it doesn't have an IP during cleanup, that it never had one?

I think we have to make that assumption, yeah. Not sure what else we could do.


Add jest unit tests

npm ci didn't change the package-lock.json at all 😕 I think it's an unavoidable diff, since adding jest as a dev dependency inevitably adds packages we depend on.


⚠ SceneTime has degraded performance

In 3aa5ca1, SceneTime ($ST) experienced degraded performance:

HTTP code: 200
Response time: 2681 ms

Resolved: SceneTime performance has improved in aa720ed after 6 minutes.


Improve Java observability documentation

Add SAP Cloud Logging for java logging
Use approved terminology for SAP Cloud Logging

Where it ended up: https://cap.cloud.sap/docs/java/observability


Add conanfile.py

This moves all hardcoded dependencies out of CMake code and into conanfile.py. Python code is responsible for conditionally adding dependencies, based on options passed to CMake.
This puts all the dependencies in one place, and makes the conditional dependency additions simpler to understand. According to Conan documentation, this is the recommended way to handle conditional dependencies.
Supersedes #124 and #65

@ddalcino @aminya OK, I blocked myself out of this one, but forcing 2 code reviews for each PR, including for admins. We'll see how it goes. Also note that I moved the base to main as I've made that the new default branch.


Fix yahoo 500 error

Fixes #218
Checklist

[x] I have read the Contribution & Best practices Guide and my PR follows them.
[x] My branch is up-to-date with the Upstream master branch.
[x] I have added necessary documentation (if appropriate)

Changes proposed in this pull request:
For getting queries from yahoo search engine it was giving 500 error and the error was generating while replacing few strings. So now it is fixed and working fine.

LGTM


How to submit a PR for content changes

Here is how to submit content fixes/changes to content from this book

find the page you want to edit, for example 21.From-Audio/From-Audio.md

click on the 'Edit this file' button

which will open the content (written in Markdown) in the GitHub online editor:

make the content changes

it is usually a good idea to preview the changes (by clicking on the 'Preview changes' button)

when you are done, go to the end of the page, enter a commit title and message

chose the 'Create a new branch for this commit and start a pull request.' option (note that if this is the first time you are doing this, you will get a text which is a little bit different. It will mention the creation of a Fork)

click on the 'Propose file change',  This will open the Pull Request page, where you can just click on the 'Create pull request' button

and that's it, your change is now a Pull Request, which will be reviewed, and if all is ok, merged into the main content

Good example of content changes submitted via GitHub
https://github.com/DinisCruz/Book_Software_Quality/pull/26/files


Add an intro / TOC page

We should have a "landing page" of sorts so that readers are guided through / pointed at appropriate places to start learning about Seattle. The Trac wiki start page could be a starting point.

Fixed in 7085bd772937e68318c26713ee2ce55c80a699a1.

The landing page lists Justin's old poly.edu email address.  Not sure if this older email address still works, but it might be safer to use<EMAIL_ADDRESS>A link to the group page might also be convenient:
https://groups.google.com/forum/#!forum/seattle-users

Are you planning to add an installation/build section to the landing page that outlines how users are expected to build the different Seattle components?  For example: https://github.com/SeattleTestbed/buildscripts#buildscripts
I think the build instructions should be prominently displayed on the landing page somewhere.  They might be there, but they didn't jump out to me.

f25b51e6f46904b397a5ab42f7e9bd02d4752a4a addresses Justin's email and the Google Groups link. Thanks!
Re build instructions, it's difficult to add everything that we think is relevant to that page already. Currently, I'm linking off to the contributor's sub-page in the list of topics right on top of the README. I'm not settled yet in terms of who we think the biggest target audience for this landing page will be. (I for one am fine with pointing folks to pages lower down in the hierarchy, and assume the landing page is mostly for total newcomers / passer-bys.)

Perhaps using a project email (or even Albert's email) would be better...
On Fri, May 6, 2016 at 12:22 PM, Vladimir Diaz<EMAIL_ADDRESS>wrote:

The landing page lists Justin's old poly.edu email address. Not sure if
this older email address still works, but it might be safer to use:
<EMAIL_ADDRESS>A link to the group page might also be convenient:
https://groups.google.com/forum/#!forum/seattle-users
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub
https://github.com/SeattleTestbed/docs/issues/5#issuecomment-217489603


Fix generation of multi-platform images, and signing of the multi-platform manifest

Fix #1943

Codecov Report
Base: 54.51% // Head: 29.80% // Decreases project coverage by -24.71% :warning:

Coverage data is based on head (c4cd758) compared to base (2f49fd9).
Patch has no changes to coverable lines.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1942       +/-   ##
===========================================
- Coverage   54.51%   29.80%   -24.72%
===========================================
  Files         179      179
  Lines       14523    14523
===========================================
- Hits         7917     4328     -3589
- Misses       5578     9592     +4014
+ Partials     1028      603      -425

Flag
Coverage Δ

acceptance-api
27.81% <ø> (-18.31%)
:arrow_down:

acceptance-cli
?

unittests
8.26% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

 Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

Manual trigger of release-qa flow - https://github.com/epinio/epinio/actions/workflows/release-qa.yml
looks good (no error), results under inspection now

:boom: is #1936, and associated PR #1938 (in review)


Join a user from chat list

A user should be able to either double-click on the "in lobby" symbol or right click and select "Join game" of a user in order to join his game.

Additional tasks:

[ ] Refactor code for joining games (extract into helper)
[ ]  Notify when entered password is wrong
[ ]  Enhance password dialog (ok, abort)


Frontend - UI Changes for Landing, Auth Pages 🛠

Change 1

Take a look at the width of the input boxes on the right, i want the same width for the input box, headings on the left for User Register Page
Change 2

For all the Login/Logout pages i want the placeholder to be visible only for mobiles
I want the button, forgot password etc left aligned for the DESKTOP

Change 3

I want the first box to go up by some pixels with increased font size
I want the second box  (buttons) to go up by some pixels too, no changes in font

Hey @IAmTamal  I'm on it

Go for it @RXBlade , make sure you pull this up within the next 3 days because these are crticial UI bugs that needs to be solved soon !


Success callback only called once (android)

There is a mention of this near the bottom of closed issue (#29) but the problem still persists, so I'm opening a new one.
The success callback fires the first time send is called (as expected) - but not on subsequent calls. This problem only occurs on android. The callbacks fire every time as expected under IOS.

Please see issue #53

@samkuhn if it is still a valid issue, please open a new one on https://github.com/cordova-sms/cordova-sms-plugin


Improve Kotlin Binding Support

This is a remake of https://github.com/xamarin/XamarinComponents/pull/685
For some reason the PR passed, but the merge to master fails consistently. Something about duplicate kotlin methods... Only on Windows, and sometimes mac locally... Sounds legit.

/azp run

After all that, still no idea why it fails sometimes. A rerun makes it work. A rebuild makes it work. I can also do a git clean and it will work.
The part that is failing is basically:
https://github.com/xamarin/XamarinComponents/blob/46153434590ea5324a7bc795bd3cf16eaf6df924/Util/Xamarin.Kotlin.BindingSupport/native/src/main/kotlin/xamarin/binding/kotlin/bindingsupport/Processor.kt#L354
Sometimes Kotlin can't locate the member - when I have it already...
This is a bit worrying in that I am not sure what else is going wrong, but at least we can ignore the errors and move on.


Change gorp to borp

Configures borp as a Go module, fixes the tests to work with the latest version of onpar, removes Postgres dialect support, replaces instances of gorp with borp, and updates the README.
I've split this into somewhat independent commits for better reviewing. In particular the big s/gorp/borp/ is its own commit so you can review the other (smaller) ones independently.

it's unclear why some dialects we don't use (postgres, snowflake) are removed, while others we don't use (oracle) remain.

Rather than ripping out all unused dialects (and unused functions) in this PR, I wanted to keep it somewhat manageable in size. I ripped out postgres because it had its own large-ish test that needed updating based on the API changes in onpar, so ripping it out saved work. Similarly, Snowflake was causing some build/test errors and it was easier to remove than fix. I considered ripping out oracle and sqlite as well but worried that was going to cascade into ever-bigger changes.

it's unclear why some dialects we don't use (postgres, snowflake) are removed, while others we don't use (oracle) remain.

Rather than ripping out all unused dialects (and unused functions) in this PR, I wanted to keep it somewhat manageable in size. I ripped out postgres because it had its own large-ish test that needed updating based on the API changes in onpar, so ripping it out saved work. Similarly, Snowflake was causing some build/test errors and it was easier to remove than fix. I considered ripping out oracle and sqlite as well but worried that was going to cascade into ever-bigger changes.

If fully removing support for other DBs is a desirable end-state that's worth the effort then we should file an issue to do so.

Looks like CI is failing across the board.

That may have been GitHub outage-related. I re-ran and now they're passing.


New author page should render

When a user visits the new author page
Then the page should render
You need to create an AuthorsController with a new action and set-up the appropriate routes. See the Rails guide for help.
Got NameError: undefined local variable or method `new_author_path' for #RSpec::ExampleGroups::NewAuthorPage:0x00000004cb4568

When a user visits the new author page
Then the page should render
You need to create an AuthorsController with a new action and set-up the appropriate routes. See the Rails guide for help.
Got NameError: undefined local variable or method `new_author_path' for #RSpec::ExampleGroups::NewAuthorPage:0x0000000601e388

When a user visits the new author page
Then the page should render
You need to create an AuthorsController with a new action and set-up the appropriate routes. See the Rails guide for help.
Got NameError: undefined local variable or method `new_author_path' for #RSpec::ExampleGroups::NewAuthorPage:0x000000071b2ab8

When a user visits the new author page
Then the page should render
You need to create an AuthorsController with a new action and set-up the appropriate routes. See the Rails guide for help.
Got NameError: undefined local variable or method `new_author_path' for #RSpec::ExampleGroups::NewAuthorPage:0x00000007b48f00

When a user visits the new author page
Then the page should render
You need to create an AuthorsController with a new action and set-up the appropriate routes. See the Rails guide for help.
Got NameError: undefined local variable or method `new_author_path' for #RSpec::ExampleGroups::NewAuthorPage:0x00000007d02cb0

When a user visits the new author page
Then the page should render
You need to create an AuthorsController with a new action and set-up the appropriate routes. See the Rails guide for help.
Got NameError: undefined local variable or method `new_author_path' for #RSpec::ExampleGroups::NewAuthorPage:0x0000000798b348


find_stocks/stock_news_sentiment.py - Not working out of the box

Greetings,
in my case the code does not work out of the box.

HTTP 403 when reaching Finviz: changed the user agent and solved.
NLTK missing dictionary errror: added the download in the code
Error on the date because it was "Today" and not in a date format: added the code to managed it.

Below the code that worked for me:
# Import necessary libraries
import pandas as pd
from bs4 import BeautifulSoup
from urllib.request import urlopen, Request
from nltk.sentiment.vader import SentimentIntensityAnalyzer
import nltk
from datetime import datetime

nltk.download('vader_lexicon')

# Define parameters
num_headlines = 3  # the number of article headlines displayed per ticker
tickers = ['AAPL', 'TSLA', 'AMZN']  # list of tickers to analyze

# Get data from finviz website
finviz_url = 'https://finviz.com/quote.ashx?t='
news_tables = {}

for ticker in tickers:
    url = finviz_url + ticker
    req = Request(url=url, headers={'user-agent': 'Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/58.0.3029.110 Safari/537.36'})
    resp = urlopen(req)
    html = BeautifulSoup(resp, features="lxml")
    news_table = html.find(id='news-table')
    news_tables[ticker] = news_table

# Display recent news headlines for each ticker
try:
    for ticker in tickers:
        df = news_tables[ticker]
        df_tr = df.findAll('tr')

        print('\n')
        print('Recent News Headlines for {}: '.format(ticker))

        for i, table_row in enumerate(df_tr):
            a_text = table_row.a.text
            td_text = table_row.td.text.strip()
            print(a_text, '(', td_text, ')')
            if i == num_headlines - 1:
                break
except KeyError:
    pass

# Extract and parse news data
parsed_news = []
for ticker, news_table in news_tables.items():
    for row in news_table.findAll('tr'):
        text = row.a.get_text()
        date_scrape = row.td.text.split()

        if len(date_scrape) == 1:
            time = date_scrape[0]
            date = 'Today'
        else:
            date = date_scrape[0]
            time = date_scrape[1]

        ticker_name = ticker.split('_')[0]
        parsed_news.append([ticker_name, date, time, text])

# Perform sentiment analysis
analyzer = SentimentIntensityAnalyzer()

# Create dataframe of news headlines with sentiment scores
columns = ['Ticker', 'Date', 'Time', 'Headline']
news = pd.DataFrame(parsed_news, columns=columns)
scores = news['Headline'].apply(analyzer.polarity_scores).tolist()
scores_df = pd.DataFrame(scores)

# Join sentiment scores to news dataframe
news = news.join(scores_df)

# Convert date to datetime object
news['Date'] = news['Date'].apply(lambda x: datetime.now().date() if x == 'Today' else x)  # Substitute "Today" with current date
news['Date'] = pd.to_datetime(news['Date'])
news = news.drop(columns=['Headline'])

# Group news by ticker and calculate mean sentiment for each
unique_tickers = news['Ticker'].unique().tolist()
mean_sentiments = []
for ticker in tickers:
    dataframe = news[news['Ticker'] == ticker]
    mean = round(dataframe['compound'].mean(), 2)
    mean_sentiments.append(mean)

# Create and display dataframe of tickers with mean sentiment scores
sentiments_df = pd.DataFrame(list(zip(tickers, mean_sentiments)), columns=['Ticker', 'Mean Sentiment'])
sentiments_df = sentiments_df.set_index('Ticker')
sentiments_df = sentiments_df.sort_values('Mean Sentiment', ascending=False)
print('\n')
print(sentiments_df)

Thanks, I appreciate the heads up.
Updated the code in the repo - should be working now!


Live View - Save position of info pane split

Description
Currently every time you click a span to open the info pane it splits the screen directly in the middle.
It would be great if it remembered the last position/size. I find myself dragging it to about 1/3rd of the screen every time.

@slingshotvfx This enhancement is now live on the site


change Main#students implementation using StreamAPI

In order to reduce a bit code and to use functional programming i have replaced the for loop with a integer stream.
I create a stream out of the studentList, map over it to get the cps and reduce it by summing the stream.

i believe this is part of your solution for sheet 06, isn't it? please submit the pull requests against your fork, not against this upstream repo :) ... hence closing here.


[BUG] no cli parse output in my environment

test corkscrew version 0.10.0 to latest 0.13.0 , use devCloud01_10.7.2020.conf as input ,but there is no output for parse result,
 could you pls advise if i miss something. or how can i get more debug log? thanks

Hi @00mfg !  I never got any feedback on people using the CLI so i haven't been testing it through the updates.
If this is something you really need, I can work on getting it working again.  Can you help me understand your use case and the details your looking for?

Hi @00mfg ! I never got any feedback on people using the CLI so i haven't been testing it through the updates.
If this is something you really need, I can work on getting it working again. Can you help me understand your use case and the details your looking for?

hi @DumpySquare thx for reply. could you pls advise except CLI how to use this cooooool tools.  here is my use case, i 'd like to use tools like ntc-template to parse text config to json ，but as you may know just network device template there. so your tools seems meet my requirment, if i got json output then i can leverage it to do more automation。thanks

Hi @00mfg ! I never got any feedback on people using the CLI so i haven't been testing it through the updates.
If this is something you really need, I can work on getting it working again. Can you help me understand your use case and the details your looking for?

hi @DumpySquare thx for reply. could you pls advise except CLI how to use this cooooool tools.  here is my use case, i 'd like to use tools like ntc-template to parse text config to json ，but as you may know just network device template there. so your tools seems meet my requirment, if i got json output then i can leverage it to do more automation。thanks

completed in pending v1.1.0 release;
you probably need a newer version of node/npm, like v16/v8
check out the tests for latest usage.  will update documentation soon
tests/056_cli.tests.ts

cooooooool,thx @DumpySquare


Not empty on init

Hi, I have a strange problem.
A simple example script: https://jsfiddle.net/17rn50fz/2/
<link href="https://arendjr.github.io/selectivity/stylesheets/selectivity-jquery.css" rel="stylesheet">
<script src="https://arendjr.github.io/selectivity/javascripts/jquery.js"></script>
<script src="https://arendjr.github.io/selectivity/javascripts/selectivity-jquery.js"></script>

<select id="test">
    <option value="1">Test 1</option>
    <option value="2">Test 2</option>
    <option value="3">Test 3</option>
    <option value="4">Test 4</option>
</select>

<script type="text/javascript">
$('#test').selectivity({
    allowClear: true,
    placeholder: 'empty',
});
</script>

And is always selected first options by default. I want it to be empty. If I add an empty option , it will be selected and display clear icon, not placeholder.
Only selectivity('clear') method can set empty select.

The preselection of the first option is standard HTML behavior, so the option is already selected even before Selectivity is initialized. Once Selectivity is initialized it just takes over the value that was selected in the HTML select. I think imediately calling "clear" is a fine way around that.
Alternatively you could initialize a plain div element and set the options using Selectivity's items array, to avoid this altogether.
Hope that answered your question.

Oh, you might also try explicitly setting the value option to null. Does that override the value selected by the HTML select?


Do we want to keep (parts) of this project, or drop or archive it?

Original reason for the project
I think the big idea was that we "package up" the node-schedule repository and use it as a dependency in our renovate repository. This package would also be the source of truth for the node schedule data file that currently lives in the main renovatebot/renovate repository.
I and some others worked to get the node-schedule repository nearly ready to use.
What changed between project start and now
@JamieMagee made a nice GitHub Action for us, that updates these static data files:

https://github.com/renovatebot/renovate/pull/17080

We never got around to publishing a package, and using that package as a dependency for the Renovate bot project. Maybe that's an indicator that we don't really need the things in this repository?
Work to do on this project, if we keep it
We're not publishing any packages on this project. I meant for us to start using the semver release tooling, that we're already using on the main Renovate project:

#3

Summary
Do we want to keep (parts) of this project, or drop or archive it?

i think we should drop this

@JamieMagee do you agree?

I don't think I have the full context on this repo, but from what I can find it is a nicer packaged version of this?
https://github.com/renovatebot/renovate/blob/8bd77f747b3da59cc955b2fc4ba3301bcb680ea2/lib/modules/versioning/node/index.ts#L51-L60
I think we should move what we need into Renovate itself and archive this repository.

i don't see much value here beside the eol function. we only need  new script to download the schedule^1


add a watch mode friendly --stream

don't do summary
don't hog the logs (just pipe it!)

Thanks for the work on this project!
Am I correct in understanding that non-exiting commands aren't supported at all currently? I can't tell if the issue title/description means it's supported but needs improvements or that it's not implemented at all.
I just attempted to get lage set-up with commands that run file watchers and don't exit. It outputs the following:
Let's say we have pkgB that depends on pkgA. When I run lage, I get the following:
$ lage dev --scope pkgB
info Lage task runner - let's make it
info pkgA dev ▶ start

I would expect the following output:
$ lage dev --scope pkgB
info Lage task runner - let's make it
info pkgA dev ▶ start
info pkgB dev ▶ start


SERVICES > Unquoted Path not work as expected

I'm running the TryHackMe Windows PrivEsc machine,

and there is a service binary path is unquoted path:
C:\Users\user>sc qc unquotedsvc
[SC] QueryServiceConfig SUCCESS

SERVICE_NAME: unquotedsvc
        TYPE               : 10  WIN32_OWN_PROCESS
        START_TYPE         : 3   DEMAND_START
        ERROR_CONTROL      : 1   NORMAL
        BINARY_PATH_NAME   : C:\Program Files\Unquoted Path Service\Common Files\unquotedpathservice.exe
        LOAD_ORDER_GROUP   :
        TAG                : 0
        DISPLAY_NAME       : Unquoted Path Service
        DEPENDENCIES       :
        SERVICE_START_NAME : LocalSystem

C:\Users\user>C:\PrivEsc\accesschk.exe /accepteula -uwdq "C:\Program Files\Unquoted Path Service\"
C:\Program Files\Unquoted Path Service
  Medium Mandatory Level (Default) [No-Write-Up]
  RW BUILTIN\Users
  RW NT SERVICE\TrustedInstaller
  RW NT AUTHORITY\SYSTEM
  RW BUILTIN\Administrators

C:\Users\user>whoami /all

USER INFORMATION
----------------

User Name            SID
==================== ==============================================
win-qba94kb3iof\user S-1-5-21-3025105784-3259396213-1915610826-1000

GROUP INFORMATION
-----------------

Group Name                             Type             SID          Attributes
====================================== ================ ============ ==================================================
Everyone                               Well-known group S-1-1-0      Mandatory group, Enabled by default, Enabled group
BUILTIN\Users                          Alias            S-1-5-32-545 Mandatory group, Enabled by default, Enabled group
BUILTIN\Remote Desktop Users           Alias            S-1-5-32-555 Mandatory group, Enabled by default, Enabled group
NT AUTHORITY\REMOTE INTERACTIVE LOGON  Well-known group S-1-5-14     Mandatory group, Enabled by default, Enabled group
NT AUTHORITY\INTERACTIVE               Well-known group S-1-5-4      Mandatory group, Enabled by default, Enabled group
NT AUTHORITY\Authenticated Users       Well-known group S-1-5-11     Mandatory group, Enabled by default, Enabled group
NT AUTHORITY\This Organization         Well-known group S-1-5-15     Mandatory group, Enabled by default, Enabled group
NT AUTHORITY\Local account             Well-known group S-1-5-113    Mandatory group, Enabled by default, Enabled group
LOCAL                                  Well-known group S-1-2-0      Mandatory group, Enabled by default, Enabled group
NT AUTHORITY\NTLM Authentication       Well-known group S-1-5-64-10  Mandatory group, Enabled by default, Enabled group
Mandatory Label\Medium Mandatory Level Label            S-1-16-8192

PRIVILEGES INFORMATION
----------------------

Privilege Name                Description                    State
============================= ============================== ========
SeShutdownPrivilege           Shut down the system           Disabled
SeChangeNotifyPrivilege       Bypass traverse checking       Enabled
SeIncreaseWorkingSetPrivilege Increase a process working set Disabled

C:\Users\user>

but PrivescCheck said:
C:\PrivEsc>powershell -ep bypass -c ". .\PrivescCheck.ps1; Invoke-PrivescCheck"

...

+------+------------------------------------------------+------+
| TEST | SERVICES > Unquoted Path                       | VULN |
+------+------------------------------------------------+------+
| DESC | List registered services and check whether any of     |
|      | them is configured with an unquoted path that can be  |
|      | exploited.                                            |
+------+-------------------------------------------------------+
[!] Not vulnerable.

...

I'm not sure if there is a bug or if I run it in the wrong way.
I think this project is cool and powerful, and I would like to contribute to its improvement. However, I am not very familiar with PowerShell.

Hi!
Your analysis is correct, you did not do anything wrong. I think I might have introduced a regression in the code at some point. :grimacing:
No worries, you don't need to write code or submit a PR to contribute. Opening an issue with this level of detail is largely enough to help. :slightly_smiling_face:
Thanks for reporting this bug. I'll have a look at this. :+1:

🙏 Thank you for providing a detailed description of the issue and quickly resolving it. I will now close this issue. 🌟


Call JSON type converters recursively

What was changed
Properly call JSON type converters recursively. Also fixate the Poetry version in CI due to Poetry bug.
Checklist

Closes #289

Converting to draft while I fix CI


Compile from source on MacOS

Following the compile from source instructions on MacOS Sierra (Golang 1.8 was installed via Homebrew) I ran into the following error:
$ go run cmd/tusd/main.go
cmd/tusd/main.go:4:2: cannot find package "github.com/tus/tusd/cmd/tusd/cli" in any of:
	/usr/local/Cellar/go/1.8/libexec/src/github.com/tus/tusd/cmd/tusd/cli (from $GOROOT)
	/Users/per/go/src/github.com/tus/tusd/cmd/tusd/cli (from $GOPATH)

Fixed by running go get github.com/tus/tusd/cmd/tusd/cli

It's not uncommon for people to get the installation wrong, mostly because Golang has a more unconventional setup structure. However, I am glad to see that you got it working but I will revisit our instructions anyhow.


Standalone releases for v2.0.0+

rules_jvm_external makes use of the standalone jar for v1.1.0: https://github.com/bazelbuild/rules_jvm_external/blob/master/private/versions.bzl
However, it looks like the standalone jars aren't published for v2.0.0 onwards. Could they be published again please? It would greatly simplify rules_jvm_external's coursier integration.

There used to have a proguarded JAR of the cli being pushed to Central, but https://github.com/coursier/coursier/commit/089d5520581663eed7b47dbcaadd72024716ac85 discontinued it (using proguard could trigger its own class of bugs, so it kind of needed to be tested on the CI, but generating it there was taking around 10 minutes).
But a simple assembly could always be pushed there as a substitute. It's a bit more heavyweight (around 28 MB now), but generating it has very little overhead, so it would be fine generating it and testing it on the CI.

I see, thank you for the explanation! An unproguarded binary is fine. From Bazel's perspective, this standalone binary can also be fetched from GitHub releases, so it doesn't need to be on Maven Central.

Will this be available for the next 2.0.0 RC?

@jin Would GitHub release assets work fine for you? I'm planning on pushing more stuff there (graalvm launchers in particular), an assembly could be pushed along them.

Yes, that'll work equally well. We're just downloading the standalone jar off a URL

Woohoo thank you! We're now using v2.0.0-RC3. https://github.com/bazelbuild/rules_jvm_external/pull/215

@jin FYI, I'm seeing some regressions with 2.0.0-RC3 and 2.0.0-RC3-1 (that https://github.com/coursier/coursier/pull/1305 should fix)… You may want to be cautious with those versions of the CLI. 2.0.0-RC3-2 is on its way.

Thanks for the heads up. Are the standalone artifacts expected to be listed in this release

Yes, as soon as the CI is done building them.


[material-ui][Autocomplete] Custom end adornment placement differs from TextField

Steps to reproduce
Here's a sandbox of my 'bare-minimum implementation'.
Current behavior
Would it be possible to get the end adornment investigated with the 'standard' and 'filled' variant in mind? The spacing of the InputBase in the TextField is very different when wrapped in the Autocomplete.
If I miss something in my implementation, I'd be very grateful for support.
Expected behavior
The EndAdornment of the TextField having the same vertical placing as the EndAdornment of the Autocomplete.
Context
I've got a custom TextField component extending the TextField component of MUI. I'm trying to make the custom Textfield compatible with the Autocomplete of MUI. The 'filled' and 'standard' are surprisingly not behaving the same as 'outlined'.
Your environment

Search keywords: component:autocomplete

Additionally I'd like to mention that the end adornment of the AutoComplete creates more padding once a value has been selected. When hovered the clear button shows itself <> hidden with the same padding. Consequently, the end adornment also ends up having odd spacing from the right when it's not hovered. Somehow I can't believe I'm the only one facing this issue, but I truly could not find similar issues. Apologies if there are...

Just found this issue that may have something to do with this one:
https://github.com/mui/material-ui/issues/28465#issuecomment-1278773152

Hey, @steve-pennings. Thanks for the report, and sorry for the late reply.
As you mentioned, there's a difference between how the end adornment is handled in the TextField when inside Autocomplete. In this case, I recommend replacing the endAdornment completely and not relying on props.InputProps.endAdornment inside renderInput. Here's an example of what I mean that you can use as a workaround: https://codesandbox.io/p/sandbox/mui-autocomplete-textfield-filled-with-endadornment-forked-535q4g?file=%2Fsrc%2FApp.js
I believe there's room for improvement here, so the behavior is more consistent, so I'm adding it to the next major's milestone.

Amazing, appreciate your reply and your workaround, thank you! Good luck with the next major milestone.

This solution still makes the end adornment overlap the clear icon


Typo in html file and nav bar [Spelling]

"Recepies" should be "recipes" in html file name, nav bar, and sitemap. Please fix.

Fixed thank you


Raise minimum version of CMake to 3.5

This changelist raises the minimum version of CMake to 3.5, as earlier versions have been deprecated by the CMake developers.

May I ask why you chose 3.5 in particular? Are you committed to always supporting as far back as the CMake authors are still not disavowing?
You can see in the VFX Industry Build Matrix spreadsheet that a bunch of other software in our ecosystem use much more recent versions: OpenEXR requires 3.12. OIIO and OSL have required 3.12 for years and are in the process of moving to 3.15 as their new minimum. OpenColorIO and Alembic require 3.13. USD requires 3.14. OpenVDB and OpenTimelineIO require 3.18.
I think what I'm saying is, so much of the ecosystem requires much newer versions, I don't think you need to be shy about jumping much farther ahead. Anybody building MX from source very likely has to build some of those other packages, so they'll need to have a newer CMake available.
CMake 3.13's addition of -B and -S alone is worth the price of admission -- it's nice for new users to just be given a simple cmake command line and never again have to explain about the mkdir build ; cd build ; cmake .. dance.

I suspect you're right, @lgritz, and I may be reflexively maintaining too broad of a range of CMake versions.  The codebase that I was comparing against is PyBind11, which still maintains support for CMake 3.5, but you're right that OSL, OIIO, and USD are much meaningful reference points here.
I'll plan to bring this up with the MaterialX TSC, to get a better sense of whether these ancient versions of CMake are worthwhile to support at all, and if they're aligned then we can choose a more modern minimum.

I would probably refer to something like https://cliutils.gitlab.io/modern-cmake/chapters/intro/dodonot.html instead of Pybind11 for this, or like Larry said, the other ASWF projects.
As for OTIO, we went with 3.18 because that's the first version that had a decently working FindPython module.

@JeanChristopheMorinPerso It seems worthwhile for us to bring this up at an upcoming MaterialX TSC meeting, to get a sense of whether any studios still rely upon ancient versions of CMake.  Even as recently as two years ago, I've seen pipelines within production studios that defaulted to Python 2.7 and CMake 3.6, but I'm hopeful that the past couple of years have swept these legacy uses aside.


Inconsistent handling of ViroSpotlight between iOS and Android

Environment

Development OS: Mac
Device OS & Version: iOS 12.01 and Android 9.0.
Version: ViroReact 2.11.0; React Native 0.57.4.
Device(s): iPhone 6s (and Simulator) vs. Google Pixel XL.

Description
Directing a spotlight at a plane leads to different colors on Android vs iOS.  For example, under the parameters given in the repro below, an object with a pure white texture (#FFF) under the spotlight shows up as white on iOS, but on android shows up with a grayish color:

Reproducible Demo
Set up the scene with some ambient lighting:
      <ViroAmbientLight color="white" intensity={900} />
      <ViroSkyBox color="white" />

Now add the spotlight:
     <ViroSpotLight
         position={[1, 3, 1]}
         direction={[-1, -1, -1]}
         color="white"
         intensity={750}
         attenuationStartDistance={1}
         attenuationEndDistance={10}
         innerAngle={45}
         outerAngle={90}
         castsShadow
         shadowMapSize={2048}
         shadowNearZ={1}
         shadowFarZ={4}
         shadowOpacity={1.0}
       />

And an object:
        <Viro3DObject
            ignoreEventHandling
            scale={[1, 1, 1]}
            position={[0, -0.4, 0]}
            rotation={[0, 0, 0]}
            source={source}
            type={objectType}
        />

Hi @slycoder, thanks for the report. This may be related to tone-mapping, which may be perturbing the color on Android. Tone-mapping can be disabled by turning off HDR. We will investigate this as well.

Note that turning off HDR, PBR, and even shadows does not seem to have an effect.
I don't know if it's a coincidence but the color works out to be pretty close to what you'd see on iOS without the spotlight.

Hi @slycoder, I tried reproducing this with your settings above but with a ViroQuad, as I don't have the model you're using (and with HDR/PBR/shadows off). I wasn't able to reproduce, though. Any chance you can share the model you were using? If so, you can email it to<EMAIL_ADDRESS>or attach here. Otherwise, can you describe that model? Is it just a white plane with no texture, and Lambert lighting? Thanks!

It seems that in the model the surface is actually Phong shaded.  I'll try to get a model your way.

Closing due to inactivity.


fixed icon missing issue

Description
Fix missing icon issue.
Screenshots
Before

After

Hey @ibulmer   -- thanks for catching this!   Some thoughts,  though
1/  for consistency,  I would expect the icon foreground to be white.
2/  Rather a A lot of tests failed - are they failing on your local?
3/  It looks like you're adding a new gem just to add this icon --  that might be overkill.   Is there something in fontawesome (which I believe is where the other icons come from) that might give the idea of organizations?

Hey @ibulmer -- thanks for catching this! Some thoughts; 1/ for consistency, I would expect the icon foreground to be white. 2/ Rather a A lot of tests failed - are they failing on your local? It looks to me like they are related to the added gem. 3/ It looks like you're adding a new gem just to add this icon -- that might be overkill. Is there something in fontawesome (which I believe is where the other icons come from) that might give the idea of organizations? (Edit: maybe institution? )

Hey @cielf good idea! I like that idea much more! Going to update this pr.

Thanks!


Error processing "stepIn": Can only perform operation while paused.

Testing #26557

Using the smoke test repository https://github.com/Microsoft/vscode-smoketest-express. Change the launch config to use the inspector protocol
set a break point at index.js line 6
F5
navigate to localhost:3000
use F11 to step quickly into the code (hold F11 pressed)

[node-debug2] Error processing "stepIn": Can only perform operation while paused.: Error: [node-debug2] Error processing "stepIn": Can only perform operation while paused.
    at file:///C:/Program Files (x86)/Microsoft VS Code Insiders/resources/app/out/vs/workbench/electron-browser/workbench.main.js:28:2148932
    at Object.v [as _notify] (file:///C:/Program Files (x86)/Microsoft VS Code Insiders/resources/app/out/vs/workbench/electron-browser/workbench.main.js:28:70090)
    at Object.enter (file:///C:/Program Files (x86)/Microsoft VS Code Insiders/resources/app/out/vs/workbench/electron-browser/workbench.main.js:28:73591)
    at n.Class.derive._oncancel._run (file:///C:/Program Files (x86)/Microsoft VS Code Insiders/resources/app/out/vs/workbench/electron-browser/workbench.main.js:28:74912)
    at n.Class.derive._oncancel._error (file:///C:/Program Files (x86)/Microsoft VS Code Insiders/resources/app/out/vs/workbench/electron-browser/workbench.main.js:28:74429)
    at file:///C:/Program Files (x86)/Microsoft VS Code Insiders/resources/app/out/vs/workbench/electron-browser/workbench.main.js:28:1941224
    at g.e.dispatch (file:///C:/Program Files (x86)/Microsoft VS Code Insiders/resources/app/out/vs/workbench/electron-browser/workbench.main.js:28:1942575)
    at g.e.handleData (file:///C:/Program Files (x86)/Microsoft VS Code Insiders/resources/app/out/vs/workbench/electron-browser/workbench.main.js:28:1942083)
    at Socket.<anonymous> (file:///C:/Program Files (x86)/Microsoft VS Code Insiders/resources/app/out/vs/workbench/electron-browser/workbench.main.js:28:1941084)
    at emitOne (events.js:96:13)

This error is coming from the node2 debug adapter thus forwarding to @roblourens
Since it is a common use case that users quickly press step I suggest we simply swallow the error when you are not paused.

@isidorn It looks like vscode will send stepIn requests constantly without waiting for the debug adapter to be paused. In which case, yes I should just swallow the error from Chrome.

@roblourens yes vscode will send stepIn requests as user successfully clicks on them.
In the perfect scenario I would disable the stepIn until the debugger is paused, but I do not change state until I get a response from the debugger, thus the user can press StepIn 10 times before the first response is back and the debugger is no longer stopped.
Bottom line I think you should just swallow the error from Chrome :)


use GitHub Actions to run unit tests

This is a prerequisite for adding ECN support. Closes #2327.
To read the ECN bits, we'll need to have OS-specific code for Linux, Mac and Windows.
Travis doesn't support IPv6 unless you run a specific arm64 image, which then messes up the IP mapping for localhost (see my issues https://github.com/travis-ci/travis-ci/issues/10458 and in the community forum, which have been unresolved for an entire year now.
AppVeyor is annoying and doesn't seem to receive a lot of development work anyway, so it might not be a bad idea to replace it with something more modern.
@lucas-clemente Please disable AppVeyor for this repository when approving this PR.

Appveyor disabled.


feat: outlier detection workflow

A notebook exploring the capabilities of YData Fabric's Outlier Engine and how you can harness it to quickly detect, cluster and visualise outliers in your dataset.

You can also specify an Axis object as a parameter from the Matlibplot library to further customise the graph.

There is no example of that.

You can also specify the score threshold (0 by default), so that any point with at least one feature beyond 2σ will be reported as an outlier.

There is no example on how to do that. Spoiler: it is not possible without https://ydata.atlassian.net/browse/SD-594

bespoke_pipeline.plot(dataset, non_outliers={'color': 'green'})

The 'non_outliers' is an optional parameter that allows to control the color of the non-outliers. This should be documented as well.
I suggest a section on how to customize the plot with ax and non_outliers parameters.


feat: Customize the S3 putObject presigned URL to include S3 metadata

Issue #
#892
Description of changes

Creates a middleware that inserts S3 metadata into the query string of S3 putObject presigned URLs before code signing, and inserts that middleware into the operation stack for the putObject URL presigner.
Adds codegen tests to verify the correct modifications to putObject URL presigning.
Modifies the S3 integration test for presigned putObject URLs to verify the writing of metadata along with an S3 object.

New/existing dependencies impact assessment, if applicable
No new dependencies were added to this change.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

/test


Fixing a security issue for VotePost

Adds a validation to VotePost that checks if the submitted VoteOptions belong to the associated Vote

Would be great to add a test case for the vote_options not belonging to the election either.

Would be great to add a test case for the vote_options not belonging to the vote either.

I tried to do that, but could not get the test to do what i wanted... :angry:


add delete anomaly results API

Description
With historical analysis, user can generate much more anomaly result in a short time, especially for HC detector. AD plugin will roll over anomaly result index if its doc count reaches some limit, and will delete roll-over index after some period (30 days by default). So if user run historical analysis, it may generate too many AD results and speed up the rollover and AD result index cleanup.
This PR adds delete anomaly result API. User can use this API to delete anomaly results with specific query like delete all anomaly results of one detector/task.
Sample request
DELETE _plugins/_anomaly_detection/detectors/results
{
  "query": {
    "bool": {
      "filter": [
        {
          "term": {
            "detector_id": {
              "value": "6tZminoBaXxjTubPk0k6"
            }
          }
        }
      ]
    }
  }
}

Issues Resolved
[List any issues this PR will resolve]
Check List

[x] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

A high level comment, do we need to consider FGAC with delete api?

Yes, check DeleteAnomalyResultsTransportAction.java line 79
addUserBackendRolesFilter(user, request.getSearchRequest().source());


[Bug]: RunInference with automatic refresh using a global window side inputs takes too long to update sometimes

What happened?
Sometimes, a global window side input takes too long to update on a Dataflow job.
The automatic model refresh feature of RunInference uses a pattern WatchFilePattern which uses a global windowed side input to fetch the latest model path. If the pipeline using this feature launches a dataflow job and there is an update to the model path, it could take long time to update the model since sometimes the workers are busy dealing with backlog.
The code I used to run is at https://github.com/apache/beam/blob/11e2bae4cbee4cc4f9d200a71511d921e8591dcd/examples/notebooks/beam-ml/automatic_model_refresh.ipynb
The work around I found is to increase the num_workers>1, I usually set it to 5.
Issue Priority
Priority: 2 (default / most bugs should be filed as P2)
Issue Components

[X] Component: Python SDK
[ ] Component: Java SDK
[ ] Component: Go SDK
[ ] Component: Typescript SDK
[ ] Component: IO connector
[ ] Component: Beam YAML
[ ] Component: Beam examples
[ ] Component: Beam playground
[ ] Component: Beam katas
[ ] Component: Website
[ ] Component: Spark Runner
[ ] Component: Flink Runner
[ ] Component: Samza Runner
[ ] Component: Twister2 Runner
[ ] Component: Hazelcast Jet Runner
[X] Component: Google Cloud Dataflow Runner

Does this reproduce on runners other than Dataflow? Can we isolate it to the SDK harness (possibly a cache that keeps getting its invalidation re-upped?) or is it runner-specific?
Maybe CC @lostluck regarding Prism's ability to get repro this. (global window triggered side input never updating as long as worker kept busy)

Triggers are not yet implemented in Prism, so a global window side input will not re-execute. (The pipeline will fail before starting presently.) Triggers are last thing to implement since they have the most complicated effects on downstream computations.

I don't know how RunInference is implemented, but if it's not adding the trigger itself, then the linked code as written won't execute RunInference at all, since the global window side input will never complete, and the consuming transform won't start until the side input is ready.

Ok, so it's WatchFilePattern applying a AfterProcessingTime trigger.

I believe this is a long-standing bug within the python sdk. Side inputs within the global window are cached in PerWindowInvoker without respecting the side input cache token.
This is part of the bundle processor which is reused across bundles. The side input values are otherwise attempted with reset here or by the runner by modifying the side input cache token.
Since bundle procesors are cached as long as there is a steady rate of input so that the last accessed time is less than 60 seconds here, this can lead to extended periods where the captured global side input value is used without refresh.
I think that we should remove the caching at the invoker level as it does not respect the cache token and the StateBackedSideInput supports caching itself.  This may be a performance regression as the state cache is currently disabled by default though.

Nice find! I have seen quite a few disconnected issues around side input refresh in Python. I hope this is the real root cause.

@AnandInguva Can you verify the above fixes your issue? It does for my separate testing pipeline

@liferoad - Could this be closed?

Asked @AnandInguva to confirm this.

Note that the fix was put behind an experiment due to potential performance concerns in cases where refreshing was undesired and the short time frame to get the original PR in for the release. See https://github.com/apache/beam/commit/bcb40cf4e4a9b9045b51162edab09cf245456038
I hope to verify there is no significant regression or improve the logic on caching to take into account side input generation triggering and was keeping the the issue open until the experiment was not required.
The experiment is disable_global_windowed_args_caching

Without the sdk cache enabled (not on by default), removing the PerWindowInvoker cache mans that there is lots of FnApi traffic to fetch side inputs which contributed to latency in Dataflow runner. This could be a noticable regression without improved functionality for pipelines that don't actually refresh the global window side input.
I think that we should postpone making this always on until the sdk cache is enabled by default. If that is too far out we could modify this to not clear after every bundle but modify finish_bundle to clear it only after some timeout. Or perhaps we can somehow access the triggering of the side input to observe if it refreshes or is calculated once.
Enabling the sdk cache will let the runner control the refresh via the side-input cache token.