Java 22 crashes on linux

Type
Crash or hang
Operating System
Linux
OS Version
Arch Linux
Bug description
Client occasionally crashes when hovering a player lookup hiscore, such as kc or skill xp. Only appears to occur after I've been logged in and playing for >30 minutes. Launched using Bolt Launcher. Crash has happened with all plugins disabled, but could not find how to launch in safe mode on Linux to confirm.
Screenshots or videos
No response
RuneLite version
RuneLite v<IP_ADDRESS>
Launcher v2.7.1
Logs
client.log
launcher.log
jvm_crash_pid_30109_r.log

Java 22 has shown to be unstable on Linux. I don't think anyone has looked into why, it might be a Java bug. If you do have steps to reproduce it that might be useful for someone looking at this later. We do not actually support 22 or really even try to make RuneLite work on it. I recommend downgrading to either 17 or 11.

thanks for the info. is it possible to set a launch flag for runelite to use 11/17 and keep 22 installed alongside?

sudo archlinux-java set java-17-openjdk

I had this issue occur shortly after this issue was posted, so thanks for reporting it and for the feedback on how to remedy the crashing issue.
As far as something actionable to prevent this from happening to people in the future, could we have Runelite display a warning if we're using a version of Java which is unsupported by Runelite? @Adam-


Frontend feature

More personalizations for business recommendations.

NICE smelling the artemis :")

For the case where the business is not yet digitalized, can we also display the suitable platform?
So currently the message is:
Start digitalizing your business by opening a seller account! Based on our analysis, your business will thrive on this platform.
The this platform can be replaced with the suitable platform too right? Like the Your business's category is Food and Groceries and the best store platform for that according to our data is Tokopedia.

Oh right I forgor okay I'll try


Migrate to the JsonSchemaElement API

When defining tools, use the new JsonSchemaElement API instead of JsonSchemaProperty.
See https://github.com/quarkiverse/quarkus-langchain4j/issues/1036#issuecomment-2457557006 for some details. This needs to be put on hold a bit until the next upstream LangChain4j release, as it contains some things that are needed.

I've already started work on this and have some things stashed, so once the next LangChain4j release is out and taken by the extension then I can complete this work.

🙏🏽

I will take this up now that #1075 has been done.

Now is the time :)

I'll try to get to this next week

🙏🏽


External still rquired

Type of Issue
[ x ] Bug Report
[ ] Feature Request

Description
I still need to add primeng to "lib.externals" even though it is a peerDependency and im using latest ng-packagr version.
I get :
BUILD ERROR
'GrowlModule' is not exported by node_modules\primeng\primeng.js
adding "primeng/primeng": "primeng" to lib.externals solves the issue.
How To Reproduce
Create an angular-cli app using<EMAIL_ADDRESS>Install primeng as peerDepndency
Import Growl in app.component
try to pack using latest ng-packgr version.
Expected Behaviour
ng-packagr should create the package.
Version Information
ng-packagr: 2.0.0-rc.7
@angular/*: 5.1.2
typescript: 2.4.2
rxjs: 5.5.6
node: 6.9.5
npm/yarn: 1.3.2
prineng: 5.0.2

Fixed in rc8

@dherges  When is rc8 released?

"soon" 🎁


Change mc-sgx-core-types::ReportBody to use TryFrom

Previously mc-sgx-core-types::ReportBody used the from trait for a
fixed size slice. Now the mc-sgx-core-types::ReportBody uses the
TryFrom trait on a dynamically sized slice.
The fixed sized slice required copying from a dynamic buffer into a
temporary fixed sized buffer in order to fullfil the compile
time constraint of the fixed size.

Current dependencies on/for this PR:

main

PR #193

PR #194

PR #195

PR #196   👈

This comment was auto-generated by Graphite.

Graphite Merge Job
Current status: ⏳ Queued to merge
This pull request is currently queued to be merged as part of a stack.
This comment was auto-generated by Graphite.

Job Reference: yIELMGRp3yYkMM34LUYh


support --skip-no-token

In some situation, the GitHub Access Token isn't exposed to the environment variable for the security.
For example, on Drone Secrets are not exposed to pull requests by default.
https://docs.drone.io/secret/repository/

Secrets are not exposed to pull requests by default.
This prevents a bad actor from sending a pull request and attempting to expose your secrets.

github-comment requires the GitHub Access Token, so it fails to run github-comment post and github-comment exec.
This issue proposes to add the option --skip-no-token to prevent the failure.
If the GitHub Access Token is set, this option is ignored.
If the GitHub Access Token isn't set, this option works like --dry-run.

--skip-no-token is a little long, so we want a good alias.

add the configuration option skip_no_token
test
update README


#135 Remove invalid function call to indexof

#135 Remove invalid function call to indexof and replace with object notation
Still not really thrilled with this design, and I may look at a new module using the jenkins cli when the typescript port is complete. But this will work for us in the short term.

[x] Related GitHub issue(s) linked in PR description
[x] Destination branch merged, built and tested with your changes
[x] Code formatted and follows best practices and patterns
[x] Code builds cleanly (no additional warnings or errors)
[x] Manually tested
[x] Automated tests are passing
[x] No decreases in automated test coverage
[/] Documentation updated (readme, docs, comments, etc.)
[x ] Localization: No hard-coded error messages in code files (minimally in string constants)

Thanks for cleaning this up, @dylanjustice!


F1: Try to fetch Formula1.com driver/race/constructor links.

Description
Updates extension to try to link driver/constructor/races to their respective Formula1.com page. It does this by making a request to the standings' respective formula1.com page and crawling the result 😅
I've also passed all of the assets through ImageOptim, hence the high number of changed files.
Screencast
https://user-images.githubusercontent.com/1155589/160470772-aaeba4ed-90ec-4ed7-a616-47e93f0bc3ca.mov
Checklist

[x] I read the extension guidelines
[x] I read the documentation about publishing
[x] I ran npm run build and tested this distribution build in Raycast
[x] I checked that files in the assets folder are used by the extension itself
[x] I checked that assets used by the README are placed in the metadata folder

@sxn Thx. Great addition
But I would be careful when using official F1 Assets (the icon in the action section). I heard that they are not the nicest guys when it comes to copyright.

good point @csigritz. Checking the FIA's guidelines https://www.formula1.com/en/toolbar/guidelines.html it indeed seems like we're probably not allowed to use the logos. Weird, since it's the favicon, but yeah let's change it. I'll use the extension's logo for the empty view, and the flag icon for the Formula1.com action 🤔 unless you have other suggestions of course!

The F1™ logo should be gone now, and added the new icon you made:
https://user-images.githubusercontent.com/1155589/160768057-5a46aaf7-021a-40c3-9214-556321d1d3b0.mov

F1™ logo's now gone. I've also replaced the command-icon with the new one you made, and used (a smaller version of) it on the empty view as well.
https://user-images.githubusercontent.com/1155589/160768752-3156f086-f94a-4f5e-bd04-9bcaca36af03.mov

Looks good now. I only found one small thing. The Wiki Action in RaceSchedule is still titled "Open in Browser". In Driver and Constructor Standings it is called "View on Wikipedia.org". Should we align the titles?
Race Schedule:

Driver Standings:

oops - good catch! should be fixed now 😅


entityManager.getEntity not working with string in production mode

Hello,
i have TS project with webpack 2.
when i use entityManager.getEntity('user') it works in dev mode, but after compile it breaks
i need to use entityManager.getEntity(User) ie. the function class directly
seems to be caused by minification, because the User gets renamed to t and the aurelia-orm seems to not find the class from string "user" afterwards

@natrim As described in the readme, you need to set the name of the entity in your decorators when using aggressive minifying processes: https://github.com/SpoonX/aurelia-orm#bundling


cargo-make tasks DATE

Feature Description

provide cargo_make_time env variable like date (and options .e.g +%Y%m%d) in bash
Describe The Solution You'd Like

Code Sample
/// paste code here

you can run a command and put its last outline line as the value, so you can do something like:
[env]
CURRENT_DATE = { script = ["date"] }

see more at: https://github.com/sagiegurari/cargo-make#script-1

@noahlin27 does this resolve your issue?

closing due to lack of feedback and solution provided

@noahlin27 so you can load different env script per OS

either use load_script - https://github.com/sagiegurari/cargo-make#load-scripts - which do support duckscript and you can do if is_windows and stuff like that.
another option is to have a task with OS override - https://github.com/sagiegurari/cargo-make#usage-platform-override - and define the env in that task differently per OS. and have that task as a pre task for all scripts - https://github.com/sagiegurari/cargo-make#usage-init-end-tasks


Add a check for MOM6 parameter filenames defined in input.nml

In this branch, I've tagged on some code that runs at the end of Mom6.setup() that checks if files listed in parameter_file of MOM_input_nml and SIS_input_nml namelists in input.nml, are included in mom6's hard coded config_files or optional_config_files.
If the file is not present, I've added a warning, added the file to config_files and then copied the file to the workpath.
Or is just a warning/error printed out during setup sufficient? If not, should the files be treated as config_files or optional_config_files - i.e. raises an exception if file not found or not?
From what I can tell, the only usages of optional_config_files and config_files are:

to be added to the runlog manifest (which happens during Experiment.run())
config files are copied from the control path to the work path (at Model.setup())

Should close #325

Hello @jo-basevi! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

In the file payu/models/mom6.py:

Line 83:80: E501 line too long (82 > 79 characters)
Line 86:59: E203 whitespace before ','
Line 86:80: E501 line too long (94 > 79 characters)
Line 88:52: E261 at least two spaces before inline comment
Line 92:80: E501 line too long (143 > 79 characters)
Line 93:1: W293 blank line contains whitespace
Line 94:55: E261 at least two spaces before inline comment
Line 94:77: W291 trailing whitespace
Line 95:1: W293 blank line contains whitespace

coverage: 41.895% (-0.1%) from 42.016% when pulling 631a372da0946109042d42e30a9a59d2de9ddecc on jo-basevi:325-read-mom6-parameter-filenames into 2d16f18ea24d764b07a41cbcb934cecb7646eaa9 on payu-org:master.

I would have asked @angus-g for a review, but he wasn't a team member. Have added him, so he should be able to review this.

I've pinged you for a review @angus-g


Cannot do further entry-related actions when username has been changed

When you change your username, the username is updated in the database. However, the current login session only remembers the name you inputted at the login screen. This makes it so you cannot update your user settings, because the password does not match the username - the username that does not exist in the system anymore.
A fix is possible, but not prioritized. In the meantime, to avoid this, log out when you have changed your username.

Issue has been resolved. Only one signle line of code was needed. Niclas, if you see this, I beg you to download the new version.


mbedtls: Backport Windows fix to use bcrypt for entropy

We had a slightly older version of it for UWP, as the wincrypt API isn't allowed there. We removed this with UWP in #81416, but since this was enabled inconditionally before, this actually changed behavior for Windows compared to Godot 4.1 and earlier. Backport of https://github.com/Mbed-TLS/mbedtls/pull/8047 (included in mbedtls 3.5.0), which the upstream version of their older unmerged PR 1453 we had backported for years.
This change is also needed to properly supported Windows Store.
Follow-up to #81416, only relevant for 4.2+.

Cherry-picked for 4.1.4.


[CodeGen] Disable -mfloat-abi hard option for LLVM < 6.0

The -mfloat-abi hard option does not work for LLVM < 6.0 as it is ignored. This adds a fatal error when using unsupported LLVM versions so that the failure
is not silent.

Thanks @mbarrett97 !

@mbarrett97 which LLVM version works with -mfloat-abi hard option. I use LLVM 8.0 with "mfloat-abi=hard", the result was still not as expected.

In what way was it unexpected? If you print out the assembly source are the correct registers being used?

@mbarrett97 the output, test mobile-net, same input but the output don't match with the tflite's result (verify by np.testing.assert_allclose()).
android version is OK, on yocto platform, toolchain is hard float,can't change to soft float. Inference result isn't right, but don't know which op cause the problem.
As you said on https://github.com/dmlc/tvm/issues/4072 "only 6.0 gives the correct result." I'll try LLVM 6.0.

@mbarrett97 test LLVM6.0,8.0,9.0,  all failed, it cause by op depthwise_conv2d_nchw. but not failed everytime, also relate to the schedule config.

This issue was specifically related to an problem in the LLVM compilation which resulted in layers such as softmax giving nonsense results. It was fully resolved for me by upgrading from LLVM 4.0 to LLVM 6.0 for all the networks I tested. I wouldn't expect this issue to affect depthwise_conv2d, so it sounds like you have a different problem.


Add WhatsApp to prerender bots

WhatsApp has currently link previews in their app, we want to show them the prerendered version of the page. I checked for their user agent and it looks like this
WhatsApp/2.12.15/i

So the keyword whatsapp should be good enough.

Looks perfect, next can merge.


Tests interposition

Tests
Use SPACK to test this interposition libary on many MPI flavors and versions.

Write some simple tests representing expected behavior
Combine with spack support to validate on many configurations

Make sure your request matching technique works as it is a tricky point.
See https://tinyurl.com/37bnyu96

Tested with OpenMPI (v4.1.3), MPICH (v4.0.2) and MPC (v4.1.0).


Add negation on needsForecast else case

Quantlib source gives:
Real f = timeSeries()[latestNeededDate];
return (f == Null());
which will return "true" when the latestNeededDate isn't found

Error Message:
Assert.Fail failed. ZC index does not forecast correctly for date 7/2/2007 from base date 6/1/2007 with fixing 207.3, correct:<PHONE_NUMBER>10232, fix: 206.1, t 0.0833333333333333
Stack Trace:
at TestSuite.QAssert.Fail(String message) in c:\projects\qlnet_develop\tests\QLNet.Tests\Utilities.cs:line 194
at TestSuite.T_Inflation.testZeroTermStructure() in c:\projects\qlnet_develop\tests\QLNet.Tests\T_Inflation.cs:line 314

hello,
is the test correct as I just followed the Quantlib logic...?

I'm testing too , seems something wrong on the test schedules

Think I solved it.
In https://github.com/amaggiulli/QLNet/blob/develop/tests/QLNet.Tests/T_Inflation.cs#L155 : remove the extra 2 indices (check QuantLib test).
In https://github.com/amaggiulli/QLNet/blob/develop/tests/QLNet.Tests/T_Inflation.cs#L160 :
Use fixData.Length instead of rpiSchedule.Count (check QuantLib test)


Remove IRC from from code

IRC is in code and documentation and needs to be removed.

Think that's all of 'em.


CVMFS_RELOAD_SOCKETS required

The current driver fails with CVMFS_RELOAD_SOCKETS required error.
logs-from-csi-cvmfsplugin-in-csi-cvmfsplugin-jhn68.txt

This error is thrown if you accidentally mount over /etc/cvmfs removing all its original contents (including its other conf files)


feat(sequencing): convert ThinStateDiff to CentralStateDiff

This change is

#2998  👈 (View in Graphite)
main

This stack of pull requests is managed by Graphite. Learn more about stacking.


Update WinUI 3 tutorials for C++

C# sample code is converted to C++. Some explanation are added for supporting C++ development.
Bug
In last section "Bind the GridView to the Images collection", it throws an exception about access violation. Binding RatingControl Value property to ImageFileInfo::ImageRating has problem. Please review the code and check it.

@stevewhims
Can you review the proposed changes? Note that the changes are extensive and will need to be moved into the private repo for staging and automated checks. Let us know if you'd like help doing that.
When the changes are ready for publication, add a #sign-off comment to signal that the PR is ready for the review team to merge.
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

Hi, @sotanakamura, and thank you so much for this PR! :)
I've made a start applying the changes here over into my own pull-request. Because there are a lot of changes I'd like to make, so doing the transfer like that (rather than editing this PR) is going to be a better workflow for me.
I don't know how long it'll take me to finish my PR. I need to switch over to some higher priority work, but I'll come back to this soon. In the meantime, so that it's not accidentally merged, I'll close this PR. But I'll continue to work from the changes in the Files tab.
Thanks again! :)
-Steve

Thanks again! The topic is now updated, and live: Tutorial: Create a simple photo viewer with WinUI 3. Binding the rating seems to work ok now.
-Steve

Thank you for reviewing and merging my PR. I tested updated C++/WinRT sample code, but I still have the same bug on binding RatingControl after binding as ItemsSource="{x:Bind Images}  in Step 13. Please check it.

The updated sample code is missing const reference. I created PR #4365.

Thank you for reviewing and merging my PR. I tested updated C++/WinRT sample code, but I still have the same bug on binding RatingControl after binding as ItemsSource="{x:Bind Images} in Step 13. Please check it.

Thanks, @sotanakamura. Yes, it seems like that last step doesn't work for the C++ case, so I've marked it in the topic as C#-only. I can work around the issue by changing the implementation of the rating property, but that seems like a step too far. Let's just leave it like this, and I'll revisit it in future if/when the platform changes.


node Agent support next.js?

hello
I've completed the Node agent setup for Next.js, but while resource usage is showing up, request data is not being traced
node version : 18.x.x
next.js version : 12.3.1
agent version : 0.8.0 / 0.8.1 / 0.8.2 / 0.9.0-next.0

Pinpoint Agent Debug log
[Pinpoint Agent][testagentID] Init Started
sendAgentInfo pAgentInfo: {"hostname":"M1.local","ip":"<IP_ADDRESS>","ports":"","servicetype":1400,"pid":20409,"agentversion":"0.9.0-next.0","vmversion":"","endtimestamp":0,"endstatus":0,"container":false}
The scheduler is scheduled to run every 86400000ms
sendApiMetaInfo pApiMetaData: {"apiid":1,"apiinfo":"Node Server Process","line":-1,"type":100}
sendApiMetaInfo pApiMetaData: {"apiid":2,"apiinfo":"Asynchronous Invocation","line":-1,"type":200}
The scheduler is scheduled to run every 5000ms
The scheduler is scheduled to run every 300000ms
sendPing pPing: {"wrappers_":null,"arrayIndexOffset_":-1,"array":[],"pivot_":1.7976931348623157e+308,"convertedPrimitiveFields_":{}}
[Pinpoint Agent][testagentID] Init Completed
GrpcBidirectionalStream stream data. pingStream on(data):
sendStats pStatMessage: {"agentId":"testagentID","agentStartTime":1693406513102,"timestamp":1693406519125,"collectInterval":1000,"memory":{"heapUsed":164954176,"heapTotal":215793664},"cpu":{"user":0.004979481533805039,"system":0},"activeTrace":{"schema":{"typeCode":2,"fast":1000,"normal":3000,"slow":5000},"typeCode":2,"fastCount":0,"normalCount":0,"slowCount":0,"verySlowCount":0}}
send full stats at1693406519125
I added  -r pinpoint-agent option like blow
  script: 'node_modules/next/dist/bin/next',
  node_args: ['-r', 'pinpoint-node-agent'],
  args: 'start',

Did you test pinpoint-node-agent with PM2 v5.x? It is right. You can use below PM2 ecosystem file.
"io": {
   "conf": {
         "metrics": {
              "http": false
          }
    }
}

thank you. Problem solved.


BUG: linkifyStr doesn't work with apostrophe and an alphabetical character

I am using Deno.
I work with a technology called nostr, and the following string nostr:npub1gujeqakgt7fyp6zjggxhyy7ft623qtcaay5lkc8n8gkry4cvnrzqd3f67z is converted to patrick.
However, if the string I just mentioned has an apostrophe plus another character it doesn't work.
Like this: nostr:npub1gujeqakgt7fyp6zjggxhyy7ft623qtcaay5lkc8n8gkry4cvnrzqd3f67z's
I actually created a new repository just dedicated for this issue, in the line 32 you can change the argument so it becomes the variable in the line 27 or 28.
Link: https://github.com/patrickReiis/linkify-mention
I could try to fix this on my own, since I have a specific parser with {render: {url: <specific-parser>}}, but I think it should work under the hood already, without me having to worry about it.

@patrickReiis apologies for the delayed reply, the fix for this is now available in the latest v4.2.0 release.

Thanksssssss


Ionic Push - Icon notification different than icon app / Plugin configuration

Hi all,
I would like to know if it's possible to have an app icon different than the notification icon.
I followed this link, created a hook which copy my file(notif.png) into the android platform folder.
Everything will be copied into the res/mipmap-* folders. In these folders, there are my app icon too.
I would like to know if it's possible to have an icon for the notification (i.e notif.png) and an icon for my app (icon.png) in these folders.
In my app, i tried to configure the phonegap-plugin-push plugin through the ionicCloudProvider like this:
.config(function($ionicCloudProvider) {
  $ionicCloudProvider.init({
    "core": {
      "app_id": "XXXXX"
    },
    "push": {
      "sender_id": "YYYYYY",
      "pluginConfig": {
        "android": {
          "icon": "notif",
          "iconColor": "blue"
        }
      }
    }
  });
})

The color is blue, but the icon is still a blank square.
Should i have to configure the phonegap-plugin-push independently with PushNotification.init() method ?

Well it seems it is a phonegap-plugin-push issue according to this post. The plugin doesn't use the mipmap folders with<EMAIL_ADDRESS>so i have to downgrade to<EMAIL_ADDRESS>and it's ok.

Thanks for the update @Lestt -- I'm closing this out but linking to phonegap/phonegap-plugin-push#1314 for future reference. 👍


allow variables in the color-theme definition file for workbench color

Description
For feature request described in #105247
Mainly there are two new features proposed here

Allow theme file to have a color palette, and the vars can be used to define a color for the workbench color item. EDIT 2023-12-15: also for syntax and semantic token.
Add snippets and suggestion for the colors, which include all the defined variables in the palette

This does NOT include the following

EDIT 2023-12-15 ~Usage of the palette var for token colors (I am interested to explore this, but would like to hear feedback first)~
Usage of the palette var in Setting #56855, EDIT 2023-12-15 ~as this needs to change the colorRegistry, which may affect many other things. (I would also love to explore this option, depending on the feedback)~

Some technical details

The syntax using $ is based on this comment by @aeschli
The parsing happens right when loading theme data. Any other service etc that uses color from the theme will always see the parsed hex, never the palette var.
For the snippets/suggestion/validation, I cannot use workbenchColorsSchemaId because modifying it would affect many other things. So instead I create a new JSON Schema based on that (here), so it will be isolated, only in theme file. However, if there is no palette, there will essentially be no modification to the schema, it is just copied as it is.
For the snippets/suggestion/validation, the palette needs to be loaded first, meaning that if there is any change in the palette, VSCode needs to be restarted after the change. However, I think it is safe to assume that a palette change, especially the change of the keys, only happens rarely.

How to test
I prepared a unit test for the parsing in themeColorParsing.test.ts

I think the direction you are taking is good.
Please try to make the change as minimal as possible. That simplifies the review.

Hi, thank you for the feedback! Sure, I'll try to minimize the changes.

Thanks @d-mahard for all the work!
I don't like the solution chosen to use a dynamic schema for the validation. Schemas are intended to be static resources, identified by an resource URI. You try to validate a document with a schema that is dynamically generated based on the document being validated. I don't see how his will work when opening a random theme file. Or when you open multiple theme files at the same time.
If you want to add validation and completions, do that in code in the extension extension-editing. Or leave that to an external extension.

remove the dynamic schema code. The only schema changes are to add the new property and allow $/w+ besides color-hex
the palette should also work in tokenColors and semantic colors.
variables are local to a theme file. Make sure that the schemas for workbench.colorCustomizations, editor.colorCustomizations and editor.semanticTokenColorCustomizations are not affected and don't allow variables
when using a color that is not defined (e.g. because of a typo in the color name), I suggest to default to #f00 (red) as color, so that the problem is easy detectable

thank you @aeschli for the review!
I understand your points. I will leave the dynamic schema validation/suggestion of the variable enumeration out of this PR.
User will just need to satisfy the $\w+ pattern beside the color-hex, and if it is not in the var list, it will default to red for easy debugging.
Regarding the following two points:

remove the dynamic schema code. The only schema changes are to add the new property and allow $\w+ besides color-hex
Make sure that the schemas for workbench.colorCustomizations, editor.colorCustomizations and editor.semanticTokenColorCustomizations are not affected and don't allow variables

In my understanding, to allow both requirement we still need the dynamic schema. The reasons are the following:
Schemas for setting are controlled here. In line 84 below, we need to use workbenchColorsSchemaId, in which the color-hex format schema is defined.:
https://github.com/microsoft/vscode/blob/4fce419132bb1521d219d5c28e13c6098bda824e/src/vs/workbench/services/themes/common/themeConfiguration.ts#L81-L90
For the theme, the schema is (in the current main branch) as follows. In line 229 below, we need to also use workbenchColorsSchemaId, in which the color-hex format schema is defined.
https://github.com/microsoft/vscode/blob/4fce419132bb1521d219d5c28e13c6098bda824e/src/vs/workbench/services/themes/common/colorThemeSchema.ts#L222-L253
The color-hex limitation is defined in line 139 below, (and then the whole schema is registered in line 687 of the same file.)
https://github.com/microsoft/vscode/blob/4fce419132bb1521d219d5c28e13c6098bda824e/src/vs/platform/theme/common/colorRegistry.ts#L136-L153
We cannot simply just change the schema of the theme, because the color-hex limitation is not defined there. But if we add the $\w+ to where it is defined (line 139 above), then it will definitely affect the setting.
So my proposal would still be using the dynamic schema, together with the scheduler, but removing the variable enum. So something like the following:
for (const key in workbenchColorSchemaForTheme.properties) {
		const property = workbenchColorSchemaForTheme.properties[key];
		delete property.format;

		property.anyOf = [
			{
				pattern: '^\\$\\w+', errorMessage: nls.localize('error.invalidFormat.colorEntryWithPalette', "Color must either in hex format (e.g. `#ffffff`) or one of the palette (e.g. `$accentName`)")
			}, // here, instead of using `$ref: themePaletteEnumSchemaId` like before, I just add the `$\w+` pattern
			{ format: 'color-hex' },
		];
	}

and of course themePaletteEnumSchemaId and all related logic everywhere will be removed.
(for completeness): The reason why I think even the scheduler is still needed is like I mentioned in my other comment:

This scheduler is necessary because the color items are contributed not just from the "core" items in colorRegistry.ts but from some other locations, and it seems (from my observation at least) the loading/registering of those colors happen in parallel also with the loading of the theme itself. I tried calling the registerColorThemeSchemas() only once (without the scheduler), and as a result some of the colors in the theme file were linted as not allowed in the schema (i.e. the newly schema, modified from the workbench scheme). I concluded that when the function was called, not all color-items had already been registered. So it has to be repeated when there is new color registered.

Is my understanding correct or did I miss something here?

@d-mahard So as you say, we can no longer have a single schema to describe colors for workbench.colorCustomizations and for colors in the theme file.
I think the proper approach is to have two different schemas, e.g. 'vscode://schemas/workbench-settings-colors' and `'vscode://schemas/workbench-theme-colors'.
I would suggest to collect two different schemas in the ColorRegistry: https://github.com/microsoft/vscode/blob/c5874782c5127953ecb2daf5ba4e15819815e7a7/src/vs/platform/theme/common/colorRegistry.ts#L128
The trick with these schemas is that they are modified while new colors come in. So you can not just take a copy of it.

@aeschli thank you for the hint!
I made the changes based on your suggestions:

all error parsing now defaults to red
dynamic schema validation/suggestion of the variable enumeration is no longer in this PR
expanded the feature to cover tokenColors and semantic colors. The approach is the same with workbench color: parsing happens when theme data is loaded, so any other thing that uses the data will not see the variable.
a new separate schema is collected from the colorRegistry for the workbench theme.
the same approach is also used for semantic token (separate schema for setting and theme), because I noticed that it is also updated every time there is a new semantic token rule added
however for the token color, it seems not to be the case. So I just make a copy of the schema-for-setting and make the necessary changes for the theme schema
I adjusted the unit test to cover also the parsing of token color and semantic token
I wanted to add a unit test for the schema using something like ajv, but could not really figure out how module importing works in this project, so I decided to skip that one. If you can give me a hint I will try to create that.

In any case I tested the schema validation, see below:

in settings, variable is not allowed

in theme file, it is possible
A little caveat:
The newly added warning (#200052) still works if we use hex, but when use variable there won't be any warning even when the color of that var is not transparent

@d-mahard Thanks for all your work! It's nicely done, I also tested it.
But now, seeing all the changes and talking about it with my co-workers, I'm hesitating to merge. I'm not happy with the added code complexity and added runtime memory around the schema generation. In the end, the color palettes are 'nice to have' but not essential. I'm not even sure that it will be good enough for ambitious theme authors, that probably want functions of colors.
So again I think this should better done as a tool on top on top of theme files. A tool that generates color themes from it's own syntax.
I'm sorry that I didn't stop you earlier from doing all the work. I was hoping it's ending up to be a simple change, but I don't see any other approach than what you just implemented.
So I'm planing to close the PR and I hope for your understanding.

@aeschli
Thank you for taking the time to test and give feedback, really appreciated it.
I can totally understand the consideration. In any case, that was a good practice on my side. 👍


StyleGAN3-NADA pretrained models

Hi there! Thanks for your awesome work!
I was browsing through the StyleGAN3-NADA branch with hope to find some pretrained StyleGAN3 models for different style effects, but the only ones that I found are for StyleGAN2. I was wondering if you could provide some of the pretrained  StyleGAN3-NADA models that you used for your project or maybe give a hint of where I can find them?
Thanks in advance!

What is StyleGAN3-NADA? I only know about StyleGAN2-ADA.

I can try collecting some models and upload them to the repository. But our results with StyleGAN-NADA were obtained without modifying the original code that can be found here: https://github.com/rinongal/StyleGAN-nada/tree/StyleGAN3-NADA
Since training is quick, you could try training some of your own models in the meantime.
The code should work out-of-the-box.

Thank you so much! Will be looking forward to your models. I will try to train some models by myself as well the way you suggested!

I just finished uploading a handful of models for multiple generators. Take a look here:
https://github.com/yuval-alaluf/stylegan3-editing#stylegan-nada
Enjoy :)


Error in documentation

Hello,
I follow the first steps of documentation 'CHatterbot Tutorial' and received this error:
Traceback (most recent call last):
  File "/home/marco/Desktop/.idea/TeRiehBot.py", line 12, in <module>
    database='./database.json',
  File "/usr/local/lib/python2.7/dist-packages/chatterbot/chatterbot.py", line 39, in __init__
    self.validate_adapter_class(storage_adapter, StorageAdapter)
  File "/usr/local/lib/python2.7/dist-packages/chatterbot/chatterbot.py", line 85, in validate_adapter_class
    if not issubclass(import_module(validate_class), Adapter):
  File "/usr/local/lib/python2.7/dist-packages/chatterbot/utils/module_loading.py", line 12, in import_module
    module = importlib.import_module(module_path)
  File "/usr/lib/python2.7/importlib/__init__.py", line 37, in import_module
    __import__(name)
ImportError: No module named storage

Hi @Marcogb81, what editor are you using? I see that there is a .idea directory in the trceback and I am wondering if this error is occurring because of the configuration of this editor.

Hi Gunther,
Do not worry, finally I found my error: I do not use virtualenv and mi actual versión of Ubuntu 16.04 is a big disastre. Finally I can run the code.
Mi IDE is PyCharm.
Best regards,
MGB

De: Gunther Cox<EMAIL_ADDRESS>Enviado: lunes, 29 de mayo de 2017 21:40
Para: gunthercox/ChatterBot
Cc: Marco Garcia Baturan; Mention
Asunto: Re: [gunthercox/ChatterBot] Error in documentation (#742)
Hi @Marcogb81https://github.com/marcogb81, what editor are you using? I see that there is a .idea directory in the trceback and I am wondering if this error is occurring because of the configuration of this editor.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/gunthercox/ChatterBot/issues/742#issuecomment-304720670, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AGuBASTygq6IIZlBzozGSp64YknKDdFNks5r-x81gaJpZM4Nboe5.

@Marcogb81 It seems to you have resolved your issue. Please feel free to reopen this issue if you found any issue?


Order report totals for each item type

It would be helpful to have a report (maybe a csv?) that has each item type with a corresponding total number of orders for each item. For example, I want to know that I've sold 200 full price tickets, 150 discount price tickets, 10 size small t-shirts, 20 size medium t-shirts, 30 size large t-shirts, etc. without having to check each order separately to see which items it includes.

Is that "Sales Summary" in the event summary insufficient? Or rather, would it be insufficient if it displayed things in a sensible order? I am not sure how it is currently ordered but it looks as though it would more useful if it were organized by item.

Ooh, yes, that's exactly what I'm looking for, thank you! It would be nice to be able to sort by item or alphabetical or whatever I wanted, but not essential. What would be even more helpful would be to have some sort of export of the summary table, preferably as a csv.

Can you not get what you need by summing things from the other data export? I have never looked at what those output, tbh.
Note also that those are links, in that summary, and they take you to a list of the relevant orders!


API server build parameters in phase2

Shouldn't api-server bind to "<IP_ADDRESS>" instead of "<IP_ADDRESS>"?

This is correct. --address is an alias for --insecure-bind-address which listens on http without auth.
https://github.com/kubernetes/kubernetes/blob/master/pkg/genericapiserver/options/server_run_options.go#L358-L360


Update static/scripts/dashboard/dashboardCtrl.js to remove the hubspot integrations from the $scope.vm.addonsForm list

https://github.com/Shippable/pm/issues/9796

this is done.


Parse cloud code date and time conversion to GMT

From client code:
Date:  Sun Dec 20 2015 00:00:00 GMT+0530 (IST)
Time:Sun Dec 20 2015 16:24:00 GMT+0530 (IST)
This is getting converted into GMT format on Parse Cloud like this:
// Logging the same object that I sent, via request.params
Date: 2015-12-19T18:30:00.000Z //Surprisingly it is one day behind now ?
Time:2015-12-20T10:54:00.000Z // Time is -5:30 hours but surprisingly it has not changed date to a day behind
How do I prevent it?

This is designed in such a way so that its universal.
I suggest using momentjs library and moment-tz  so you can work with any timezone.
This is NOT a bug.

I will try it out

Closing this as by design. As @jeveloper notes, dates in GMT are considered universal. In JavaScript, dates have no inherent time zone. They are simply represented internally as a number of milliseconds from the Unix Epoch. Browsers and JS server environments print dates in the local timezone, and methods such as getMonth(), getDate(), and getFullYear() are relative to the timezone of the execution environment. MDN has a great reference for all of the functionality / methods of Date objects, and I definitely recommend using a library like moment.js for managing dates.

I am not getting it. Is there any rules / guidelines that I have to follow while using dates on Parse?
Right now I am just passing a date object to the cloud. It is getting converted there. So, what format should I pass / convert before performing save operation?
In my case, I will be retrieving rows based on date value.

@srameshr You should really read the guide for parse documentation, it does describe that dates are stored in GMT.
As mentioned there are many ways of adjusting them to any timezone.
In javascript i use moment + moment.tz which is super easy.
Also querying dates is pretty simple, just assume that you need to convert a passed date in GMT timezone , so if you're in India , just convert date to (-5 hours).

I think I did that already. I am facing some weird issue in conversion. If I just add moment.tz(date).format() I get 400 Bad request. If I do the same on my browser it just works fine.
I cant figure out where am I going wrong

@srameshr you need to include the moment.js library in your /cloud directory, so that you can require it. You'll either need to fetch it from their web site, or from npm.

@andrewimm I have included it. The moment version was 1.7.2 so I have included the latest version and did require('moment-2.8') and require('moment-tz-master')

Finally! This answer helped me in understanding: http://stackoverflow.com/questions/18014341/how-to-convert-time-correctly-across-timezones


Auto-addition of the icon depending on the type

Hi!
Isn't it possible to add auto-addition of the default icon depending on the type - folder or file? Without this, there is no point in using this wonderful extension...

You might check out our custom rules implementation. Does this solve your problem?

Custom rules are tied to folder and file NAMES (I only see the setting using a regular expression)
I'm talking about defining a rule BY the TYPE of object - is it a file or a folder

Custom rules are tied to folder and file NAMES (I only see the setting using a regular expression)
I'm talking about defining a rule BY the TYPE of object - is it a file or a folder

There is the functionality of setting the type of object:

Yes, it really worked! Thanks!
I previously Googled here: https://forum.obsidian.md/t/how-to-auto-add-icon-to-folders-and-notes/51809/2 - and as you can see, the people also did not understand how to do it...
I think it would be nice to modify the documentation, otherwise I could not find an answer to such a simple request on my own (

Yes, it really worked! Thanks! I previously Googled here: https://forum.obsidian.md/t/how-to-auto-add-icon-to-folders-and-notes/51809/2 - and as you can see, the people also did not understand how to do it...
I think it would be nice to modify the documentation, otherwise I could not find an answer to such a simple request on my own (

Good thought! Could you please describe quickly what Regex you've used and what options you've applied? Then I'll adapt the README accordingly.

@FlorianWoelki of course!
just dot-s))0

This solved my issue

@FlorianWoelki of course!
just dot-s))0

This solved my issue

Was kind of obvious :D I've adapted the README to explain how to set a default icon.


Unable to get the left and the right infrared streams from D435 with Paython

The color and depth is working fine.
Even when i only want 1 input of infrared.
But when the output / video is running -> only the right IR channel is used.
how do i get both?
And the depth map is working over both left and right ...

i tried this one .. but that doesnt work!
config.enable_stream(rs.stream.infrared, 1, 640, 480, rs.format.y8, 6)
config.enable_stream(rs.stream.infrared, 2, 640, 480, rs.format.y8, 6)
The Error says: Runtime Error: Couldnt resolve requests

Perhaps the camera is not in advanced mode?
Please open the Viewer and select one of the presets. If a popup will appear, say yes, the camera will restart and enable Infrared2 formats.

is there a opportunity to change that in the code? i mean activate the advanced mode and activate the second infrared stream?

This seems related to my issue https://github.com/IntelRealSense/librealsense/issues/3878

i dont know why it is working now but this one is working fine for me:
pipeline = rs.pipeline()

config = rs.config()
config.enable_stream(rs.stream.infrared, 1, 640, 480, rs.format.y8, 30)
config.enable_stream(rs.stream.infrared, 2, 640, 480, rs.format.y8, 30)
config.enable_stream(rs.stream.color, 640, 480, rs.format.bgr8, 30)
config.enable_stream(rs.stream.depth, 640, 480, rs.format.z16, 30)

colorizer = rs.colorizer()
pipeline.start(config)

profile = pipeline.get_active_profile()
infrared_profile = rs.video_stream_profile(profile.get_stream(rs.stream.infrared, 2))
infrared_intrinsics = infrared_profile.get_intrinsics()
depth_profile = rs.video_stream_profile(profile.get_stream(rs.stream.depth))
depth_intrinsics = depth_profile.get_intrinsics()

print(infrared_profile)
print(infrared_intrinsics)
print(depth_profile)
print(depth_intrinsics)

while True:

    frames = pipeline.wait_for_frames()

    infrared_frame_zero = frames.get_infrared_frame(1)
    infrared_frame_one  = frames.get_infrared_frame(2)
    depth_frame = frames.get_depth_frame()
    color_frame = frames.get_color_frame()

    infrared_colormap_zero = np.asanyarray(colorizer.colorize(infrared_frame_zero).get_data())
    infrared_colormap_one = np.asanyarray(colorizer.colorize(infrared_frame_one).get_data())
    depth_colormap = np.asanyarray(colorizer.colorize(depth_frame).get_data())
    colormap = np.asanyarray(colorizer.colorize(color_frame).get_data())

    images = np.hstack((depth_colormap, colormap))

    cv2.imshow('RealSense', images)

    if cv2.waitKey(25) == ord('q'):
        break
pipeline.stop()
cv2.destroyAllWindows()

Hi PhilippRay,
Thanks for the update. Close this one.

@RealSenseCustomerSupport: PhilippRay's code does not work for me. Same problem.
@dorodnic : As I mention in https://github.com/IntelRealSense/librealsense/issues/3878, advanced mode is enabled in my case, and both IR streams can be recorded via Realsense Viewer, but not via the Python interface.


Enhancement:

pls, get the improved health heads from fps plus or the week 7 update because these ones are just all weird and they don't even go with the beat.

heads are the exact same as in week 7, not only that they zoom in every beat
https://github.com/KadeDev/Kade-Engine/blob/eaaa585393549f63f3144fcfd8fcf91790413ce5/source/PlayState.hx#L4202
https://github.com/KadeDev/Kade-Engine/blob/eaaa585393549f63f3144fcfd8fcf91790413ce5/source/PlayState.hx#L4261-L4262


azimuthal/radial/box Averager missing

While an external averager like PyFAI can be recommended, a basic reference implementation would not be amiss for testing and checking. I can provide one if necessary, but they're not too hard to write either, as long as one eschews the nonsense of pixel splitting ;).
An averager determines between each set of (log- or lin-spaced) bin boundaries:

mean value for I, the dependent variable
standard error on the mean🍺 for the above
propagated uncertainty estimates for the above
mean value for Q, Phi, Qx, Qy, two theta or whatever is used for the independent variable(s)
standard error on the mean for those too
propagated uncertainty estimates for the above.
mean value for the scaling factors
standard error on the mean🍺 for the above
propagated uncertainty estimates for the above

So the averaging step actually produces quite a few "uncertainties", which can then be mixed-and-matched however people see fit. I usually take the largest uncertainty estimator as the one to feed the user, but the remainder can be stored for traceability.
Creating a single uncertainty estimator from multiple feed values could be a good separate processing step.
Additionally (ok, so this isn't as straightforward as I initially envisioned), I use this binning to merge data from multiple detectors and configurations. When I do that, I weigh their contributions by the datapoint uncertainty: datapoints with a small relative uncertainty weigh more to the average than datapoints with a higher uncertainty. Details: https://lookingatnothing.com/index.php/archives/2650
This weighting should probably be left optional.

Whilst it would be nice to have a set of reference reduction / reconstruction sets it may be outwith the scope of this project, as we aim to transform raw detector data into a corrected frame and nothing more. I haven't yet tested how PyFAI works with numcertain, if this is unsuccessful we can look at up-streaming a issue to one of these or in the worst case, develop a separate library which works with uncertainities.


feat: add custom updater toasts

This check is passing locally for me, no idea why it would fail in CI


Fix few links, formatings and rename index to summary

Signed-off-by: Krasi Georgiev<EMAIL_ADDRESS>

Pull Request Test Coverage Report for Build 391412372

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.05%) to 36.318%

Totals

Change from base Build 390381561:
0.05%

Covered Lines:
1525

Relevant Lines:
4199

💛  - Coveralls


[Bug] Installing sanic-ext breaks sanic

Describe the bug
After pip install sanic-ext, this happens:
sanic server.app --dev
[2023-02-09 01:55:08 -0500] [39063] [INFO]
  ┌────────────────────────────────────────────────────────────────────────────────────────────────────────┐
  │                                             Sanic v22.12.0                                             │
  │                                   Goin' Fast @ http://<IP_ADDRESS>:8000                                   │
  ├───────────────────────┬────────────────────────────────────────────────────────────────────────────────┤
  │                       │        mode: debug, single worker                                              │
  │     ▄███ █████ ██     │      server: sanic, HTTP/1.1                                                   │
  │    ██                 │      python: 3.10.9                                                            │
  │     ▀███████ ███▄     │    platform: macOS-12.3.1-x86_64-i386-64bit                                    │
  │                 ██    │ auto-reload: enabled                                                           │
  │    ████ ████████▀     │    packages: sanic-routing==22.8.0, sanic-testing==22.12.0, sanic-ext==22.12.0 │
  │                       │                                                                                │
  │ Build Fast. Run Fast. │                                                                                │
  └───────────────────────┴────────────────────────────────────────────────────────────────────────────────┘

[2023-02-09 01:55:09 -0500] [39063] [DEBUG] Creating multiprocessing context using 'spawn'
[2023-02-09 01:55:09 -0500] [39063] [DEBUG] Starting a process: Sanic-Server-0-0
[2023-02-09 01:55:09 -0500] [39063] [DEBUG] Starting a process: Sanic-Reloader-0
[2023-02-09 01:55:09 -0500] [39068] [INFO] Sanic Extensions:
[2023-02-09 01:55:09 -0500] [39068] [INFO]   > injection [0 dependencies; 0 constants]
[2023-02-09 01:55:09 -0500] [39068] [INFO]   > openapi [http://<IP_ADDRESS>:8000/docs]
[2023-02-09 01:55:09 -0500] [39068] [INFO]   > http
[2023-02-09 01:55:09 -0500] [39068] [ERROR] typing.Tuple[str, ...] is not a module, class, method, or function.
Traceback (most recent call last):
  File "/usr/local/anaconda3/envs/test-env/lib/python3.10/site-packages/sanic/app.py", line 1177, in _listener
    maybe_coro = listener(app)  # type: ignore
TypeError: blueprint_factory.<locals>.build_spec() missing 1 required positional argument: 'loop'

The error message goes on, but the relevant part is ^^^.
Removing sanic-ext "fixes" the issues:
pip install sanic-ext

To Reproduce
Install sanic-ext
Expected behavior
That sanic-ext will not break sanic
Environment (please complete the following information):

OS: macOS-12.3.1-x86_64-i386-64bit
Browser: n/a
Version: 22.12.0

Additional context
I'm not sure if it is relevant, but I installed sanic via conda-forge.

I did some poking around. it looks like the culprit is <file:ext=jpg>, as described here:
https://sanic.dev/en/guide/basics/routing.html#ext
where using that input format breaks the auto-documentation.
If I remove that, the sanic-ext + sanic works.
I guess the workaround is just to parse that regex manually and not rely on the ext routing type.

What does your app look like? I've got many apps running both and have been doing so for months in development and have not seen this. Any minimal code example that produces this will be helpful.

This is a minimal example that breaks with sanic-ext installed:
from sanic import Request, Sanic
from sanic.response import HTTPResponse, raw, text

app = Sanic("HelloWorldApp")

@app.get("/<file:ext=jpg|png>")
async def hello_world(request: Request, file: str, ext: str) -> HTTPResponse:
    return text(f"Hello, world. {file}.{ext}")


Annotations for Load Balancer when deploying workload into Azure

What kind of request is this (question/bug/enhancement/feature request):
Feature Request
Steps to reproduce (least amount of steps as possible):
Select a project / Switch to Project context in the GUI
Select Resources menu then Workloads
Click deploy
Fill in mandatory fields with test info
Then select the + add port button
Select Layer-4 Load Balancer
The request is for annotations to be allowed as optional for use on the Azure Load Balancers
Result:
Customer can deploy Load Balancers using the 'Import yaml' button, however would like to be able to do this using Workloads on the Rancher Interface
Other details that may be helpful:
Environment information

Rancher version (rancher/rancher/rancher/server image tag or shown bottom left in the UI): 2.3.2
Installation option (single install/HA): HA RKE

Cluster information

Cluster type (Hosted/Infrastructure Provider/Custom/Imported):
Machine type (cloud/VM/metal) and specifications (CPU/memory):
Kubernetes version (use kubectl version):

(paste the output here)

Docker version (use docker version):

(paste the output here)

You could create Layer-4 Load Balancer with annotations in creating service discovery page.


Fix config.go

Without this i got
./config.go:461:41: constant<PHONE_NUMBER> overflows int
./config.go:467:37: constant<PHONE_NUMBER> overflows int

This commit should fix it https://github.com/imgproxy/imgproxy/commit/bf64a4878330d533d1b944066a75824edd1b4e0d


PowerShell has been updated. Please restart your shell to reflect changes

So PowerShell got updated from 7.4.2 to 7.4.3 and this message appears:
PowerShell has been updated. Please restart your shell to reflect changes
but how ? reboot doesn't work.

the profile uses winget as source for upgrade, and 7.4.3 isn't available in winget yet.

Yeah it worked now, was too early.


Sender input field does not allow space character

Would it be possible to allow spacing into the sender input ?

I have updated it, can you recheck that everything is fine and then I close it?

Thx it's perfect!

Definitely. I added trimming thinking it could help avoid sender mistakes
but spaces are allowed in alphanumeric so makes sense to have it.
I can push the update tonight if that s ok
On Wed, 11 May 2022, 15:18 jackwedi, @.***> wrote:

[image: image]
https://user-images.githubusercontent.com/36620818/167859111-8d731dbf-51a4-4005-9146-6ca671374126.png
Would it be possible to allow spacing into the sender input ?
—
Reply to this email directly, view it on GitHub
https://github.com/evanTheTerribleWarrior/Twilio-Outbound-Messaging/issues/2,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AM674NXBIXKRHT64WLBABDDVJOXQ3ANCNFSM5VU5BQRQ
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>


Broken smoke tests with Go Buildpack v1.8.28

Hi there,
Hope you're doing well!
With recent cf-deployment v5.4.0 (Go Buildpack version 1.8.28), I get this error when running the CF-related smoke-tests errand:
           Downloaded app package (730.4K)
           -----> Go Buildpack version 1.8.28
           -----> Checking Godeps/Godeps.json file
           -----> Installing godep 80
                  Download [https://buildpacks.cloudfoundry.org/dependencies/godep/godep-v80-linux-x64-cflinuxfs2-06cdb761.tgz]
           -----> Installing glide 0.13.2
                  Download [https://buildpacks.cloudfoundry.org/dependencies/glide/glide-v0.13.2-linux-x64-cflinuxfs2-b50997e2.tgz]
           -----> Installing dep 0.5.0
                  Download [https://buildpacks.cloudfoundry.org/dependencies/dep/dep-v0.5.0-linux-x64-cflinuxfs2-52c14116.tgz]
                  **ERROR** Unable to determine Go version to install: no match found for 1.6.x in [1.8.6 1.8.7 1.9.6 1.9.7 1.10.3 1.10.4 1.11 1.11.1]
           Failed to compile droplet: Failed to run all supply scripts: exit status 16
           Exit status 223

Indeed, support for Golang version 1.6.x was removed in Go Buildpack v1.8.28, as specified in the release notes: https://github.com/cloudfoundry/go-buildpack/releases/tag/v1.8.28
Could you please update the smoke test application so that it can support recent version of the Go Buildpack?
Thank you!
Best,
Benjamin

Hi @bgandon,
thank you for heads-up!
The issue you are referring to is related to smoke-tests job from logsearch-for-cloudfoundry repo.
Moreover, in that repo the code itself is attached from logsearch-smoke-tests.
Anyway, we're going to fix that, no need to re-create the issue ;-)


add MultiTaskLassoCV and MultiTaskLasso

@mathurinm I tried to add MultiTaskLassoCV and MultiTaskLasso to help @ja-che with his experiments but the test does not end. It seems like it's not converging.
@mathurinm can you have a look?
also you'll see that mtl_path is not consistent in API with sklearn lasso_path
wdyt?

I removed fit_intercept=True testing (not supported yet, do you need it for this project?)
I used the datafit scaling by n_samples in the cython code to harmonize with both celer's lasso and sklearn's MTL.
Now the tests pass locally.
By the way do you know why Travis is not triggered?

I will configure travis to trigger builds for fork's PR. It is ongoing maintenance so I will do it later. Thank you @agramfort

works for me !
do you want to activate CIs before merging to avoid breaking something?

yes :)

push an empty line and let's see?

Codecov Report

Merging #114 into master will increase coverage by 2.04%.
The diff coverage is 94.20%.

@@            Coverage Diff             @@
##           master     #114      +/-   ##
==========================================
+ Coverage   79.17%   81.22%   +2.04%
==========================================
  Files          11       11
  Lines         658      719      +61
  Branches       97       98       +1
==========================================
+ Hits          521      584      +63
+ Misses        105      104       -1
+ Partials       32       31       -1

Impacted Files
Coverage Δ

celer/homotopy.py
81.29% <60.00%> (+3.35%)
:arrow_up:

celer/dropin_sklearn.py
96.22% <92.85%> (-1.28%)
:arrow_down:

celer/tests/test_lasso.py
100.00% <100.00%> (ø)

celer/tests/test_mtl.py
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update be79116...55b4e46. Read the comment docs.

Thanks for the help @mathurinm. In our experiment, we only need fit_intercept=False.

@ja-che I am trying your code with the new code but so far not clear how
much it helps.
I may need @mathurinm to look :(

Keep me posted about the numericq if I can give it a more detailed look


GitHub: Update code of conduct

📄 Description

Update code of conduct and other related community documents with better spelling/more accurate links.
✅ Tasks

📋 Update community documents

[x] Update code of conduct
[x] Remove privacy policy

[x] Remove references to privacy policy

[x] Add code of conduct to settings page
[x] Fix merge conflicts

😕

I can't resolve these commits on the command line on my laptop

Finally! 😌 I managed to merge it using a series of very unintuitive powershell commands after a lot of trial and error.

@0x5bfa please review my merge commit as I didn't do it very well.

@0x5bfa do you want the licence to be a markdown file?
I'd say yes because it looks better on GitHub.

Can we just ignore these? @0x5bfa

I'm tired of working on this PR especially because it makes my old laptop very slow (due to changes across so many files)

Sure

Is this ready for merge?

Wait!

Is this ready for merge?

You changed the name to LICENSE
I need to update the references to it everywhere

Is this ready for merge?

Yes

Oh wait @0x5bfa you need to force merge it because CodeFactor is a required status check

Changed the rule

Thank you!


[DOCS] Update references to github.com/lyft to be github.com/amundsen-io

Expected Behavior
Update the github references to be correct (i.e. under github.com/amundsen-io)
Current Behavior
There's a bunch of places in docs, etc. where there are references to github.com/lyft.
Possible Solution

Steps to Reproduce

Screenshots (if appropriate)
Context

Your Environment

Also, btw, PRs will need to wait before we fix the Travis/PyPi setup to ensure tests are running.

databuilder: https://github.com/amundsen-io/amundsendatabuilder/pull/323

Thanks for picking this up, Dorian! Marking it here so I don't forget.
Repositories include all github.com/amundsen-io/amundsen* repositories (including github.com/amundsen-io/amundsen-io.github.io)
Regex'es that I can think of:
github.com/lyft/amundsen* -> github.com/amundsen-io/amundsen*
lyft.github.io/amundsen -> amundsen.io/amundsen
cc @Golodhros @feng-tao

I took a stab at the amundsen repo: https://github.com/amundsen-io/amundsen/pull/619

common: https://github.com/amundsen-io/amundsencommon/pull/51

mdl: https://github.com/amundsen-io/amundsenmetadatalibrary/pull/174

sl: https://github.com/amundsen-io/amundsensearchlibrary/pull/133


[bug]: Issue with Tabs and Switch component inside an Astro Component

Describe the bug
Currently when using UI elements such as a Switch in Astro, one has to specify it as client:visible to work. Otherwise its not working at all. Also using Tabs gives TabsContent must be used within Tabs though I am using it within Tabs context.
astro.config.mjs
import { defineConfig } from 'astro/config';
import tailwind from "@astrojs/tailwind";
import react from "@astrojs/react";
// https://astro.build/config
export default defineConfig({
  site: <your_url>,
  integrations: [tailwind({
    applyBaseStyles: false,
  }), react()]
});

tsconfig.json
{
  "extends": "astro/tsconfigs/base",
  "compilerOptions": {
    "jsx": "react-jsx",
    "baseUrl": ".",
    "paths": {
      "@/*": [
        "./src/*"
      ]

    }

  }
}

components.json

{
  "$schema": "https://ui.shadcn.com/schema.json",
  "style": "default",
  "rsc": false,
  "tsx": true,
  "tailwind": {
    "config": "tailwind.config.mjs",
    "css": "./src/styles/globals.css",
    "baseColor": "slate",
    "cssVariables": true,
    "prefix": ""
  },
  "aliases": {
    "components": "@/components",
    "utils": "@/lib/utils"
  }
}

Affected component/components
Switch,  Tabs
How to reproduce

Install Tabs component with the default config for tsconfig and astro configuration.
Use the Switch component without giving the client:visible prop to it inside an Astro component. It will be unresponsive.
Use the Tabs component inside an Astro component, the below error will occur:

Codesandbox/StackBlitz link
No response
Logs
No response
System Info
OS: Windows 11
Browser: Chrome

Before submitting

[X] I've made research efforts and searched the documentation
[X] I've searched for existing issues

I have the same problem

Still happening

I have the same problem

I got the Tabs working with client:visible and a workaround for Accordions described in this issue https://github.com/AREA44/astro-shadcn-ui-template/issues/66
So basically wrap shadcn Tabs in another Tabs component. So Tabs inside of Tabs of Tabs ;). Then your new Tabs Component could be used with client:visible. And if you need dynamic tab content, just pass your data with props.
Not sure if this is a stable solution though?


Ensure only directories are added to FilesCategoryNode's internal directories array

I noticed that in certain circumstances GitFileChangeNodes on the root were getting disposed of and never completely reinitialised. I think this was because they were sometimes being treated as though they were DirectoryTreeNodes

This change breaks the file tree for PRs where the file that has been changed is at the root:

How it should look:

Do you have an example of the issue you were seeing?

Ah, it's been a while. I'll open this back up if/when I get a chance to look at the original issue again 👍


Patch

The Hook event and Patch seem to be correct but, the event are not Raise, same for the old event already present.

Player:
[x] [ ] PlayerDeath
[x] [ ] WarHeadInteract
[x] [ ] DropItem
[x] [ ] Heal
[x] [ ] Join
[x] [ ] BulletHole
[x] [ ] WarHead Button
[x] [ ] WalkOnHazardEvent WalkOnSinkholeEvent..WalkOnTantrumEvent
[x] [ ] StartWorkStationEvent
[x] [ ] UpdateDisplayNameEvent
[x] [ ] Player Ban
[ ] [x] CallVanillaElevatorEvent
[ ] [x] SendPlayerDataEvent
[ ] [x] SpeakSecondaryEvent
[ ] [x] DoorInteractEvent
Item:
[x] [ ] DisarmEvent
[ ] [x] FlipCoinEvent
[ ] [x] RadioUseEvent
[ ] [x]ReloadWeaponEvent
[ ] [x] ShootEvent
[ ] [x] ThrowGrenadeEvent
[ ] [x]MicroUseEvent
Map:
[ ] [x]Scp914UpgradeEvent
[x] [ ]GeneratorEngageEvent
[ ] [x]ElevatorMoveContentEvent
[ ] [x]TriggerTeslaEvent
[x] [ ]CancelWarheadEvent
Round:
[ ] [x]RoundCheckEndEvent
[ ] [x]SelectTeamEvent
[ ] [x]SpawnTeamEvent
SCP:
[-] [x] Scp049AttackEvent //Patch do but bugged
[-] [x] Scp0492AttackEvent //Patch do but bugged
[-] [x] Scp096AttackEvent //Patch do but bugged
[-] [x] Scp173AttackEvent //Patch do but bugged
[x] [ ]Scp939AttackEvent
[ ] [x] Scp173ObserveEvent
[x] [ ]106 Caputure player
[x] [ ] PlaceTantrumEvent
[x] [ ]ActivateBreakneckSpeedEvent
[x] [ ]ReviveEvent
Rmoved ContainScp106Event
Rmoved CreatePortalEvent
[ ] [x]LeavePocketEvent
[ ] [x] ObserveScp096Event
[ ] [x]ContainScp079Event
[ ] [x] SwitchCameraEvent
[ ] [x] Scp079DoorInteractEvent
[ ] [x] Scp079LockDoorEvent
[ ] [x] Scp079StartSpeakerEvent
[ ] [x] Scp079StopSpeakerEvent


I can't Solve This error : vs code not open .. No network

i search a lot on github and google for solved this error but can't find any solution ...
i find this links but not help me :
https://github.com/Microsoft/vscode/issues/61044
https://github.com/Microsoft/vscode/issues/59477
https://github.com/Microsoft/vscode/issues/59634
https://github.com/Microsoft/vscode/issues/58830
https://github.com/Microsoft/vscode/issues/56623
realy what i can do .......................?
error :
dns.js:246
this._handle = new ChannelWrap();
^
Error: EFILE
at new Resolver (dns.js:246:20)
at dns.js:377:25
at dns.js:431:3
at NativeModule.compile (bootstrap_node.js:606:7)
at NativeModule.require (bootstrap_node.js:550:18)
at net.js:45:13
at net.js:1730:3
at NativeModule.compile (bootstrap_node.js:606:7)
at NativeModule.require (bootstrap_node.js:550:18)
at internal/child_process.js:6:13
VS Code version: Code 1.29.1 (bc24f98b5f70467bc689abf41cc5550ca637088e, 2018-11-15T19:13:36.375Z)
OS version: Windows_NT x64 10.0.17763

System Info

Item
Value

CPUs
Intel(R) Core(TM) i7-2670QM CPU @ 2.20GHz (8 x 2195)

GPU Status
2d_canvas: enabledchecker_imaging: disabled_offflash_3d: enabledflash_stage3d: enabledflash_stage3d_baseline: enabledgpu_compositing: enabledmultiple_raster_threads: enabled_onnative_gpu_memory_buffers: disabled_softwarerasterization: unavailable_softwarevideo_decode: enabledvideo_encode: enabledwebgl: enabledwebgl2: enabled

Memory (System)
7.91GB (4.40GB free)

Process Argv

Screen Reader
no

VM
0%

Extensions (11)

Extension
Author (truncated)
Version

vscode-eslint
dba
1.7.0

tslint
eg2
1.0.40

code-runner
for
0.9.5

beautify
Hoo
1.4.7

python
ms-
2018.11.0

cpptools
ms-
0.21.0-insiders

csharp
ms-
1.17.1

vsliveshare
ms-
0.3.1005

debugger-for-chrome
msj
4.11.1

LiveServer
rit
5.3.1

vscode-icons
rob
7.28.0

bad bad and vs code is bad  error  always error : vs code 👎
dns.js:246
this._handle = new ChannelWrap();
^
Error: EFILE
at new Resolver (dns.js:246:20)
at dns.js:377:25
at dns.js:431:3
at NativeModule.compile (bootstrap_node.js:606:7)
at NativeModule.require (bootstrap_node.js:550:18)
at net.js:45:13
at net.js:1730:3
at NativeModule.compile (bootstrap_node.js:606:7)
at NativeModule.require (bootstrap_node.js:550:18)
at internal/child_process.js:6:13
giv me a video a file any things for this issues .. set ELECTRON_ENABLE_LOGGING=true   not help meeeeeeeee

Help Me..............................

(Experimental duplicate detection)
Thanks for submitting this issue. Please also check if it is already covered by an existing one, like:

Crash at launch when no network (#61044)
cannot start VSCode when offline (#61652)
Cannot start  VSCode without network (#62535)
Not opening  (#61302)
code fails to launch if DNS is unavailable since 1.29.1 (#63585)

giv me a video a file any things for this issues .. set ELECTRON_ENABLE_LOGGING=true not help meeeeeeeee
i cant't find any way ... help me

same issue here!

Which company in the world launch a program that doesn't launch? Funny Microsoft! 😂


amp: bucket encryption

optional ability to encrypt buckets by default
update design docs to include new field for buckets/storage

closed by PR #112


Move all oh-my-zsh completions out plugins

There are many plugins with just completions, I suggest that we have all the completions moved to $ZSH/completions. Then we add the zsh completion plugin from here. This simply addition of plugins, reduce the duplication of work in completion and also make a common place for all completions reducing the plugins we need to use
PS: If possible, move the completion to zsh-completions

I'd actually suggest that completions should if possible be contributed to zsh itself or to the upstream project for which the completions apply. Zsh includes a large number of completions and by contributing them there, they would benefit all users of zsh who run compinit. The only exception would be for things like _cargo that are copies of completions from upstream projects: having them in omz makes sense because sometimes the Linux distribution packages are lax about installing them.
I don't really understand what the point of zsh-completions is.

That zsh completion plugin does, it maintains completions that are missing in zsh or upstream.

it maintains completions that are missing in zsh or upstream.

That isn't an explanation of what the point of it is. What is its reason for existing? In other words, why were the functions not simply contributed to zsh or to upstream. My guess is that someone perceived the mailing list as being too intimidating or something like that.

This projects aims at gathering/developing new completion scripts that are not available in Zsh yet. The scripts may be contributed to the Zsh project when stable enough.
Copied from the readme. It's also part of zsh users which are close to upstream zsh. Let's put it this way. So they are not afraid of the mail information list rather I believe they share the mailing zsh itself. Also upstream may not accept it.

Won't fix. The way it's now guarantees that we only load completion from the plugins enabled.


Report RUSTSEC vulnerability for issue #206

The release notes describe issue #206 as a security vulnerability: https://github.com/BLAKE3-team/BLAKE3/releases/tag/1.2.0 .  If true, could you please report a RUSTSEC vulnerability, to help notify users?
https://rustsec.org/contributing.html

https://github.com/rustsec/advisory-db/issues/1666


ripgrep 14.1.0

Destination channel: main
Links

PKG-3672
Upstream repository

Explanation of changes:

Add feedstock's license
Reset the build number to 0
Add cargo-bundle-licenses

README.md is a bit short on detail?

README.md is a bit short on detail?

@ifitchet Fixed

Is this ok?
INFO       rust:                  1.76.0-h313beb8_0
INFO       rust_osx-arm64:        1.71.1-h313beb8_0
...

INFO :: The inputs making up the hashes for the built packages are as follows:
                   INFO   {
                   INFO     "ripgrep-14.1.0-h15d1925_0.tar.bz2": {
                   INFO       "recipe": {
                   INFO         "channel_targets": "defaults",
                   INFO         "rust_compiler": "rust",
                   INFO         "rust_compiler_version": "1.71.1",
                   INFO         "target_platform": "osx-arm64"
                   INFO       }
                   INFO     }
                   INFO   }

Details

Is this ok? It's not using rust v1.76 in the end? same for other platforms
INFO       rust:                  1.76.0-h313beb8_0
INFO       rust_osx-arm64:        1.71.1-h313beb8_0
...

INFO :: The inputs making up the hashes for the built packages are as follows:
                   INFO   {
                   INFO     "ripgrep-14.1.0-h15d1925_0.tar.bz2": {
                   INFO       "recipe": {
                   INFO         "channel_targets": "defaults",
                   INFO         "rust_compiler": "rust",
                   INFO         "rust_compiler_version": "1.71.1",
                   INFO         "target_platform": "osx-arm64"
                   INFO       }
                   INFO     }
                   INFO   }

Yeah, conda-build takes the rust version from the base cbc.yaml https://github.com/AnacondaRecipes/aggregate/blob/3752638c76c79b1b54c822b0a01e4cc047561146/conda_build_config.yaml#L38
I put a local cbc.yaml with rust 1.76.0 to the recipe.

@danpetry Now it's built against rust 1.76.0:
  "ripgrep-14.1.0-h594256b_0.tar.bz2": {
    "recipe": {
      "channel_targets": "defaults",
      "rust_compiler": "rust",
      "rust_compiler_version": "1.76.0",
      "target_platform": "linux-64"
    }


Add attributes

fix for #18.
I'm not sure I cover all attributes case. But the most obvious that I have found are covered.

See my comment on #18


Release python package src

The PyPI package misses test files needed by test in Gentoo ebuild that I'm writing. So I need python package src release containing these files, thanks!

Good idea! Seems that the official packaging guide is also recommending adding tests to sdists.

In particular, wheels should never include tests and documentation, while sdists commonly do.

Please have a check at<EMAIL_ADDRESS>to see whether it can be of use for you.

Thanks!


fix(docs): List v0.12 in Cargo.toml snippet

Currently the latest version is not listed in the Cargo.toml snippet. This causes the trivial example to fail as it requires the command wrapper listed in d159e875aee71841198c67cd1a4e848b8bb9e465.

Thanks!
To make sure this doesn't happen again, we could update the release.toml to updater the readme like predicates does
See https://github.com/assert-rs/predicates-rs/blob/master/release.toml

(I'll try to remember to do that but you are welcome to submit another PR)


Item's inner bindings are not disposed when removed

Originally raised against knockout but appears to be an issue with fast-foreach
See console output of this fiddle (click remove):
http://jsfiddle.net/c3zqLmrb/
Vs console output of this fiddle (click remove):
http://jsfiddle.net/0or1xhme/

Thanks Adam.

Thanks for the great report @AdamWillden  - I think I know where this is occurring. Let me think about it and tinker for a bit.

@AdamWillden What we want to be calling is ko.removeNode or ko.cleanNode to remove or clean the node before removal.
Will update when the code when I get a chance, but please feel free to flip a PR along these lines.
Cheers


@NotNull instead of @GraphQLNonNull

Hi there!
Would be possible to allow graphql-spqr to work with @NotNull the same it works with @GraphQLNonNull? It would improve code readability, increase code compatibility with 3rd party validation tools, and would reduce code verbosity.
We have a lot of not null on our graphql/service methods, so this would help a lot.
Best regards,
Rafael Pacheco.

I just tested with @NotNull and it works as expected :sweat_smile:

Yup, it does :) Both @NotNull and @NonNull work, and so do the JetBrains annotations.

In case this is useful for anyone: @NotNull annotation works only with javax.validation > 2.0.0.
With javax.validation 1.1.0 the @NotNull annotation is not picked up by spqr.
A test demonstrating the issue: https://github.com/josemduarte/graphql-spqr/commit/9a0ddb20729aee78c3b17ff03d8f1eab3d9fad56

@josemduarte This is to be expected... In  javax.validation 1.x, @NotNull can not be applied to type (it doesn't have ElementType.TYPE_USE as target), while in javax.validation 2.x it does.
What this means is that in your example the annotation is being applied to the method, not the return type of the method. And SPQR does not (and should not) consider the method annotations in this context.

Yup, I see how this can easily lead to confusion...
There are ways to still take method annotations into account, with some customization, but if upgrading javax.validation is an option, I'd still go for that.


Prepare 2.8.3 release

Proposed 2.8.3 release
Changes
2.8.3 (2022-04-04)

[UPGRADED] @ibm-cloud/cloudant dependency to version 0.1.1.
[NOTE] Move retry-axios and ibm-cloud-sdk-core to peerDependencies.

Thank you for reviewing! I am about to merge this.


Introduce project event webhook

What this PR does / why we need it:
This PR implements document creation and document removal events for a new project event webhook. Currently, users who uses Yorkie as a SaaS are not always aware of document status changes. By introducing project-level events—rather than relying solely on doc-level events like attach or push-pull—we can more clearly represent the lifecycle of documents and make those events available to external systems.
Which issue(s) this PR fixes: Fixes #1002
Special notes for your reviewer:

Project event webhook

The original issue suggested a DocEvent, but instead, I'm introducing a Project Event. We already have DocEvent events (DocumentChanged DocumentWatched, DocumentUnwatched, broadcast), and using the same naming might be confusing.
Additionally, doc-level events(e.g., attach, document-changed, watched, unwatched) don't clearly convey CRUD semantics. For instances:

Create: A document is automatically created when a user attaches to a non-existent document. documentAttached alone doesn't explicitly indicate creation.
Read/Update: push-pull may imply either reading or updating a document, and it's not always obvious which. (A Change can contain both presence and operations; if it only has presence, it might not mean a real update of document's content.)
Delete: Yorkie's removeDocument function only marks a document as "removed" without fully deleting it. In contrast, the removeDocumentByAdmin function permanently deletes the document. When a removeDocument action occurs, Yorkie sends webhook events, allowing the customer's server to decide the next steps—such as moving the document to a recycle bin or directly deleting it using removeDocumentByAdmin.

Add HMAC signature in request header

For the authentication webhook, we provide a token so the receiver can validate the request. However, for the project event webhook, the endpoint may not know which service is calling.
To address this, I introduced an HMAC signature in the X-Signature header, generated using the project's secret key. The receiving server can verify this signature to ensure the request is from Yorkie.
In another approach, we could set our public key in projectKey in our request attributes.

type WebhookAttribute struct {
        ProjectKey string `json:"projectKey"`
	DocumentKey string `json:"documentKey"`
	ClientKey   string `json:"clientKey"`
	IssuedAt    string `json:"issuedAt"`
}

Handling timeouts and unreachable events

Asynchronous work: Authentication must be verified before proceeding, so the auth webhook is synchronous. In contrast, a project event occurs after some action is completed, so it can be handled asynchronously without impacting user response times.
Unreachable events and replay: If an endpoint is down or encounters an error, we need a way to track failed events. In this PR, we only log these failures; in the future, the Yorkie dashboard could handle or additional recovery steps.
More relaxed timeouts: Currently, the auth webhook uses exponential backoff with a base of 200ms and a maximum wait of 3 seconds. This PR applies the same settings for consistency, although we might later adopt a more extended retry schedule(e.g., Liveblocks' approach: [immediately, 5s, 5m, 30m, 2h, 5h, 10h], etc.).

Add an HTTP client with timeout

Since http.POST does not allow specifying a request timeout directly, using an HTTP client with a configurable timeout is more predictable. Although the auth webhook still uses http.POST, we may consider migrating it to an HTTP client for consistency.

In this PR
This design proposal differs somewhat from the original issue’s requirements. If the idea seems sound, I’ll proceed with the remaining tasks:

Add config validation and tests
Add event_webhook tests
Update the admin server’s UpdateProjectRequest API spec
Integrate the auth webhook’s exponential backoff logic into pkg/webhook

In a subsequent PR

Introduce a document-changed event (with caching)

Does this PR introduce a user-facing change?

Additional documentation
There are four configuration options related to timeouts, which can be confusing. Below is a brief explanation:

EventWebhookRequestTimeout: How long to wait for a response before timing out
EventWebhookMaxRetries: Number of retry attempts
EventWebhookBaseWaitInterval: Base interval for exponential backoff
EventWebhookMaxWaitInterval: Maximum interval between retries

N/A

Checklist

[ ]  Added relevant tests or not required
[ ]  Addressed and resolved all CodeRabbit review comments
[x]  Ensured no breaking changes

I notice that the RemoveDocument feature has more context discussed in issue #484. In that PR, three tasks were outlined:

Implement a basic document deletion API that sets the RemovedAt date in docInfo.
Decide whether to include removed documents in the ListDocuments API, which is used by the Dashboard and CLI (Admin).
Create a housekeeping background process to physically delete documents (is_removed = true) and their related data.

The first task has been completed, and work on the third task is ongoing in PR #718.
Given this, I think it makes sense to publish the documentRemoved webhook as part of the third task, which physically removing documents. So I'll remove the publishing removeDocument event.


FLAKE<EMAIL_ADDRESS>windows failure

Relevant error from the log seems here:
I0302 20:15:01.048000000  6964 src/core/ext/filters/client_channel/subchannel.cc:1055] New connected subchannel at<PHONE_NUMBER>4C7140 for subchannel<PHONE_NUMBER>1F6440
D0302 20:15:01.049000000  6964 test/core/end2end/tests/simple_request.cc:176] server_peer=ipv6:[::1]:52929
D0302 20:15:01.049000000  6964 test/core/end2end/tests/simple_request.cc:181] client_peer=ipv6:[::1]:5973
I0302 20:15:01.050000000  6964 src/core/ext/transport/chttp2/transport/chttp2_transport.cc:1769] ipv6:[::1]:52929: Sending goaway err={"created":"@1583180101.050000000","description":"Server shutdown","file":"src/core/lib/surface/server.cc","file_line":323,"grpc_status":0}
I0302 20:15:01.051000000  6964 src/core/ext/transport/chttp2/transport/chttp2_transport.cc:1769] ipv6:[::1]:52928: Sending goaway err={"created":"@1583180101.051000000","description":"Server shutdown","file":"src/core/lib/surface/server.cc","file_line":323,"grpc_status":0}
I0302 20:15:01.052000000  6964 test/core/end2end/tests/simple_request.cc:40] Running test: test_invoke_simple_request/chttp2/simple_ssl_fullstack
D0302 20:15:01.052000000  6964 test/core/end2end/fixtures/proxy.cc:97] PROXY ADDR:localhost:5975 BACKEND:localhost:5976
D0302 20:15:01.057000000  6964 test/core/end2end/tests/simple_request.cc:131] client_peer_before_call=localhost:5975
I0302 20:15:01.063000000  9100 src/core/ext/filters/client_channel/subchannel.cc:1055] New connected subchannel at<PHONE_NUMBER>1F0CB0 for subchannel<PHONE_NUMBER>1F6010
I0302 20:15:01.070000000  6964 src/core/ext/filters/client_channel/subchannel.cc:1055] New connected subchannel at<PHONE_NUMBER>4B3E10 for subchannel<PHONE_NUMBER>3ABFD0
D0302 20:15:01.070000000  6964 test/core/end2end/tests/simple_request.cc:176] server_peer=ipv6:[::1]:52931
D0302 20:15:01.070000000  6964 test/core/end2end/tests/simple_request.cc:181] client_peer=ipv6:[::1]:5975
I0302 20:15:01.071000000  6964 src/core/ext/transport/chttp2/transport/chttp2_transport.cc:1769] ipv6:[::1]:52931: Sending goaway err={"created":"@1583180101.071000000","description":"Server shutdown","file":"src/core/lib/surface/server.cc","file_line":323,"grpc_status":0}
I0302 20:15:01.071000000  9100 src/core/ext/transport/chttp2/transport/chttp2_transport.cc:1769] ipv6:[::1]:52930: Sending goaway err={"created":"@1583180101.071000000","description":"Server shutdown","file":"src/core/lib/surface/server.cc","file_line":323,"grpc_status":0}
I0302 20:15:01.072000000  6964 test/core/end2end/tests/simple_request.cc:40] Running test: test_invoke_simple_request/chttp2/simple_ssl_fullstack
D0302 20:15:01.072000000  6964 test/core/end2end/fixtures/proxy.cc:97] PROXY ADDR:localhost:5977 BACKEND:localhost:5978
D0302 20:15:01.077000000  6964 test/core/end2end/tests/simple_request.cc:131] client_peer_before_call=localhost:5977
I0302 20:15:01.083000000  6244 src/core/ext/filters/client_channel/subchannel.cc:1055] New connected subchannel at<PHONE_NUMBER>37FB40 for subchannel<PHONE_NUMBER>1F6010
I0302 20:15:01.089000000  6964 src/core/ext/filters/client_channel/subchannel.cc:1055] New connected subchannel at<PHONE_NUMBER>4ACA00 for subchannel<PHONE_NUMBER>1F6190
D0302 20:15:01.089000000  6964 test/core/end2end/tests/simple_request.cc:176] server_peer=ipv6:[::1]:52933
D0302 20:15:01.090000000  6964 test/core/end2end/tests/simple_request.cc:181] client_peer=ipv6:[::1]:5977
I0302 20:15:01.090000000  6964 src/core/ext/transport/chttp2/transport/chttp2_transport.cc:1769] ipv6:[::1]:52933: Sending goaway err={"created":"@1583180101.090000000","description":"Server shutdown","file":"src/core/lib/surface/server.cc","file_line":323,"grpc_status":0}
I0302 20:15:01.091000000  6964 src/core/ext/transport/chttp2/transport/chttp2_transport.cc:1769] ipv6:[::1]:52932: Sending goaway err={"created":"@1583180101.091000000","description":"Server shutdown","file":"src/core/lib/surface/server.cc","file_line":323,"grpc_status":0}
I0302 20:15:01.091000000  6964 test/core/end2end/tests/simple_request.cc:40] Running test: test_invoke_simple_request/chttp2/simple_ssl_fullstack
D0302 20:15:01.092000000  6964 test/core/end2end/fixtures/proxy.cc:97] PROXY ADDR:localhost:5979 BACKEND:localhost:5980
D0302 20:15:01.096000000  6964 test/core/end2end/tests/simple_request.cc:131] client_peer_before_call=localhost:5979
I0302 20:15:01.102000000  9148 src/core/ext/filters/client_channel/subchannel.cc:1055] New connected subchannel at<PHONE_NUMBER>4669F0 for subchannel<PHONE_NUMBER>38D090
I0302 20:15:01.107000000  6964 src/core/ext/filters/client_channel/subchannel.cc:1055] New connected subchannel at<PHONE_NUMBER>4CC840 for subchannel<PHONE_NUMBER>4AD830
D0302 20:15:01.108000000  6964 test/core/end2end/tests/simple_request.cc:176] server_peer=ipv6:[::1]:52935
D0302 20:15:01.108000000  6964 test/core/end2end/tests/simple_request.cc:181] client_peer=ipv6:[::1]:5979
I0302 20:15:01.109000000  6964 src/core/ext/transport/chttp2/transport/chttp2_transport.cc:1769] ipv6:[::1]:52935: Sending goaway err={"created":"@1583180101.109000000","description":"Server shutdown","file":"src/core/lib/surface/server.cc","file_line":323,"grpc_status":0}
I0302 20:15:01.109000000  9148 src/core/ext/transport/chttp2/transport/chttp2_transport.cc:1769] ipv6:[::1]:52934: Sending goaway err={"created":"@1583180101.109000000","description":"Server shutdown","file":"src/core/lib/surface/server.cc","file_line":323,"grpc_status":0}
I0302 20:15:01.110000000  6964 test/core/end2end/tests/simple_request.cc:40] Running test: test_invoke_simple_request/chttp2/simple_ssl_fullstack
D0302 20:15:01.111000000  6964 test/core/end2end/fixtures/proxy.cc:97] PROXY ADDR:localhost:5981 BACKEND:localhost:5982
D0302 20:15:01.115000000  6964 test/core/end2end/tests/simple_request.cc:131] client_peer_before_call=localhost:5981
I0302 20:15:01.121000000  6504 src/core/ext/filters/client_channel/subchannel.cc:1055] New connected subchannel at<PHONE_NUMBER>382FA0 for subchannel<PHONE_NUMBER>38D090
I0302 20:15:01.128000000  6964 src/core/ext/filters/client_channel/subchannel.cc:1055] New connected subchannel at<PHONE_NUMBER>4AD070 for subchannel<PHONE_NUMBER>39CC30
D0302 20:15:01.128000000  6964 test/core/end2end/tests/simple_request.cc:176] server_peer=ipv6:[::1]:52937
D0302 20:15:01.128000000  6964 test/core/end2end/tests/simple_request.cc:181] client_peer=ipv6:[::1]:5981
I0302 20:15:01.129000000  6964 src/core/ext/transport/chttp2/transport/chttp2_transport.cc:1769] ipv6:[::1]:52937: Sending goaway err={"created":"@1583180101.129000000","description":"Server shutdown","file":"src/core/lib/surface/server.cc","file_line":323,"grpc_status":0}
I0302 20:15:01.130000000  6504 src/core/ext/transport/chttp2/transport/chttp2_transport.cc:1769] ipv6:[::1]:52936: Sending goaway err={"created":"@1583180101.130000000","description":"Server shutdown","file":"src/core/lib/surface/server.cc","file_line":323,"grpc_status":0}
I0302 20:15:01.130000000  6964 test/core/end2end/tests/simple_request.cc:40] Running test: test_invoke_simple_request/chttp2/simple_ssl_fullstack
D0302 20:15:01.131000000  6964 test/core/end2end/fixtures/proxy.cc:97] PROXY ADDR:localhost:5983 BACKEND:localhost:5984
D0302 20:15:01.136000000  6964 test/core/end2end/tests/simple_request.cc:131] client_peer_before_call=localhost:5983
I0302 20:15:01.142000000  1040 src/core/ext/filters/client_channel/subchannel.cc:1055] New connected subchannel at<PHONE_NUMBER>4E1270 for subchannel<PHONE_NUMBER>1EE1D0
I0302 20:15:01.148000000  6964 src/core/ext/filters/client_channel/subchannel.cc:1055] New connected subchannel at<PHONE_NUMBER>4D8E40 for subchannel<PHONE_NUMBER>1F6660
D0302 20:15:01.149000000  6964 test/core/end2end/tests/simple_request.cc:176] server_peer=ipv6:[::1]:52939
D0302 20:15:01.149000000  6964 test/core/end2end/tests/simple_request.cc:181] client_peer=ipv6:[::1]:5983
I0302 20:15:01.149000000  6964 src/core/ext/transport/chttp2/transport/chttp2_transport.cc:1769] ipv6:[::1]:52939: Sending goaway err={"created":"@1583180101.149000000","description":"Server shutdown","file":"src/core/lib/surface/server.cc","file_line":323,"grpc_status":0}
I0302 20:15:01.150000000  6964 src/core/ext/transport/chttp2/transport/chttp2_transport.cc:1769] ipv6:[::1]:52938: Sending goaway err={"created":"@1583180101.150000000","description":"Server shutdown","file":"src/core/lib/surface/server.cc","file_line":323,"grpc_status":0}
I0302 20:15:01.151000000  6964 test/core/end2end/tests/simple_request.cc:40] Running test: test_invoke_simple_request/chttp2/simple_ssl_fullstack
D0302 20:15:01.151000000  6964 test/core/end2end/fixtures/proxy.cc:97] PROXY ADDR:localhost:5985 BACKEND:localhost:5986
E0302 20:15:01.173000000  6964 src/core/ext/transport/chttp2/server/secure/server_secure_chttp2.cc:81] {"created":"@1583180101.173000000","description":"No address added out of total 2 resolved","file":"src/core/ext/transport/chttp2/server/chttp2_server.cc","file_line":397,"referenced_errors":[{"created":"@1583180101.173000000","description":"Failed to add port to server","file":"src/core/lib/iomgr/tcp_server_windows.cc","file_line":512,"referenced_errors":[{"created":"@1583180101.173000000","description":"OS Error","file":"src/core/lib/iomgr/tcp_server_windows.cc","file_line":203,"os_error":"An attempt was made to access a socket in a way forbidden by its access permissions.\r\n","syscall":"bind","wsa_error":10013}]},{"created":"@1583180101.173000000","description":"Failed to add port to server","file":"src/core/lib/iomgr/tcp_server_windows.cc","file_line":512,"referenced_errors":[{"created":"@1583180101.173000000","description":"OS Error","file":"src/core/lib/iomgr/tcp_server_windows.cc","file_line":203,"os_error":"An attempt was made to access a socket in a way forbidden by its access permissions.\r\n","syscall":"bind","wsa_error":10013}]}]}
E0302 20:15:01.175000000  6964 test/core/end2end/fixtures/h2_ssl_proxy.cc:48] assertion failed: grpc_server_add_secure_http2_port(s, port, ssl_creds)
Abort handler called.
*** 0: 00007FF77950E07C  -<PHONE_NUMBER>000000
*** 1: 00007FF77950DC83  -<PHONE_NUMBER>000000
*** 2: 00007FFC4AB1D09B raise - 00007FFC4AB1CEC0
*** 3: 00007FFC4AB1E131 abort - 00007FFC4AB1E100
*** 4: 00007FF7793D1AA9 abort - 00007FFC4AB1E100
*** 5: 00007FF779419506 abort - 00007FFC4AB1E100
*** 6: 00007FF7793D1CA2 abort - 00007FFC4AB1E100
*** 7: 00007FF77941064E abort - 00007FFC4AB1E100
*** 8: 00007FF77940FA81 abort - 00007FFC4AB1E100
*** 9: 00007FF7793DE069 abort - 00007FFC4AB1E100
*** 10: 00007FF7793D248F abort - 00007FFC4AB1E100
*** 11: 00007FF7795ABEBD abort - 00007FFC4AB1E100
*** 12: 00007FFC4FBC4034 BaseThreadInitThunk - 00007FFC4FBC4020
*** 13: 00007FFC63A33691 RtlUserThreadStart - 00007FFC63A33670

https://source.cloud.google.com/results/invocations/26269be7-9418-40af-86c6-d2d8cc296669/targets/%2F%2Ftest%2Fcore%2Fend2end:h2_ssl_proxy_nosec_test@simple_request/log

see on 1.28.x branch in https://github.com/grpc/grpc/pull/22205

Hopefully this will be fixed by https://github.com/grpc/grpc/pull/22363.

#22363 was merged.


Style memory game page

I would  like to update the memory game home page by adding CSS to it. @nilisha-jais Please assign me this under LGM-SOC'21.

/assign

Hey @Sukhseerat-Kaur your issue is same as #95 .So it would be better if you don't start working on it now. After the issue #95 is solved, if you like to do further enhancement open an issue in that case :)


Add connection_required marker to Pythonz install test

It seems also this test cannot run without network connection.

Thank you! (I was travelling, so I merged this only now)

No problem, thanks for merging


Bug when generating SQL

I have an Expression tree that is generating incorrect SQL.
First, here is an example that works correctly.  The following expression tree:
{e => (((((e.RecommendationId == 20c1330e-8467-472f-b9d2-2f212394f508) Or (e.RecommendationId == 3e155765-e0de-43ba-be60-602f06a8c09a)) Or (e.RecommendationId == 6abda0ce-0721-4dba-b826-0be331e4adfa)) Or (e.RecommendationId == ba0d5d50-4063-4b95-84d1-f9b53f12a0a8)) Or (e.RecommendationId == f14bace9-6732-403b-9a56-694efe64bf6d))}

Correctly generates the following SQL:

SELECT {removed}
FROM {removed} AS [e]
WHERE ((((CASE
    WHEN [e].[RecommendationID] = '20c1330e-8467-472f-b9d2-2f212394f508'
    THEN CAST(1 AS BIT) ELSE CAST(0 AS BIT)
END | CASE
    WHEN [e].[RecommendationID] = '3e155765-e0de-43ba-be60-602f06a8c09a'
    THEN CAST(1 AS BIT) ELSE CAST(0 AS BIT)
END) | CASE
    WHEN [e].[RecommendationID] = '6abda0ce-0721-4dba-b826-0be331e4adfa'
    THEN CAST(1 AS BIT) ELSE CAST(0 AS BIT)
END) | CASE
    WHEN [e].[RecommendationID] = 'ba0d5d50-4063-4b95-84d1-f9b53f12a0a8'
    THEN CAST(1 AS BIT) ELSE CAST(0 AS BIT)
END) | CASE
    WHEN [e].[RecommendationID] = 'f14bace9-6732-403b-9a56-694efe64bf6d'
    THEN CAST(1 AS BIT) ELSE CAST(0 AS BIT)
END) = 1

Please note the "=1" at the end of the SQL query.
Now if I simply add to the original expression tree so that it looks like this:
{e => ((((((e.RecommendationId == 20c1330e-8467-472f-b9d2-2f212394f508) Or (e.RecommendationId == 3e155765-e0de-43ba-be60-602f06a8c09a)) Or (e.RecommendationId == 6abda0ce-0721-4dba-b826-0be331e4adfa)) Or (e.RecommendationId == ba0d5d50-4063-4b95-84d1-f9b53f12a0a8)) Or (e.RecommendationId == f14bace9-6732-403b-9a56-694efe64bf6d)) AndAlso Invoke(e => ((e.ClientId == value(Epreop.Data.Repository+<>c__DisplayClass2422_0).clientId) AndAlso (e.DeleteFlag == False)), e))}

Then the "=1" gets removed from the generated SQL, and a SQL error occurs.  The new generated SQL is:
SELECT {removed}
FROM {removed} AS [e]
WHERE ((((CASE
    WHEN [e].[RecommendationID] = '20c1330e-8467-472f-b9d2-2f212394f508'
    THEN CAST(1 AS BIT) ELSE CAST(0 AS BIT)
END | CASE
    WHEN [e].[RecommendationID] = '3e155765-e0de-43ba-be60-602f06a8c09a'
    THEN CAST(1 AS BIT) ELSE CAST(0 AS BIT)
END) | CASE
    WHEN [e].[RecommendationID] = '6abda0ce-0721-4dba-b826-0be331e4adfa'
    THEN CAST(1 AS BIT) ELSE CAST(0 AS BIT)
END) | CASE
    WHEN [e].[RecommendationID] = 'ba0d5d50-4063-4b95-84d1-f9b53f12a0a8'
    THEN CAST(1 AS BIT) ELSE CAST(0 AS BIT)
END) | CASE
    WHEN [e].[RecommendationID] = 'f14bace9-6732-403b-9a56-694efe64bf6d'
    THEN CAST(1 AS BIT) ELSE CAST(0 AS BIT)
END) AND (([e].[ClientID] = @__clientId_0) AND ([e].[DeleteFlag] = 0))

Again, note that the "=1" was removed, resulting in invalid SQL.

@joshmouch could you try using OrElse instead of Or?
@smitpatel looks like this is a bug regardless of whether this works with OrElse, but we can discuss the priority if it does.

@divega I'm not sure I'd know how to easily do that.  I'm using a simple LinqKit method to add to the Expression.

possible dupe of #7271

duplicate of #7271
PR #7331 resolves this too.


fix: mjs, cjs module resolution to account for es6 node libraries

This PR will enable Class Variance Authority to work with metro bundler for expo web.

@mrzachnugent, Out of curiosity, any reason not to use tailwind-variants by Vercel? Looks like the same API.

@mrzachnugent, Out of curiosity, any reason not to use tailwind-variants by Vercel? Looks like the same API.

I didn't even know about that library before now to be honest. And cva is what's used in ui.shadcn.com. I'll look into it later, thanks.


fix(interaction): 修复刷选不显示预选框, 行列多选功能异常等交互问题

👀 PR includes

🐛 Bugfix

[x] Solve the issue and close #0

📝 Description
修复 https://github.com/antvis/S2/pull/944
https://github.com/antvis/S2/pull/944/files#diff-d947b89145acaac6eced6156a5a5aad0e6837759768fd083643405b5044bcb69L338 导致的刷选不显示预选框, 行列多选功能异常等交互问题
🖼 Screenshot

Before
After

🔗 Related issue link
ref #944

🔍 Self Check before Merge

[x] Add or update relevant Docs.
[x] Add or update relevant Demos.
[x] Add or update relevant TypeScript definitions.

:tada: This PR is included in version @antv/s2-v1.8.0-alpha.4 :tada:
The release is available on:

npm package (@alpha dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This PR is included in version @antv/s2-react-v1.8.0-alpha.5 :tada:
The release is available on:

npm package (@alpha dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


[question] Is there always a solution?

In another words, are the mazes always generated in such a manner that we can be absolutely sure that there is a solution within the allowed number of steps?
Great game btw, thanks!

The board is generated totally at random, it isn't guaranteed that there will always be a solution. Determining the optimal solution for a board is incredibly computationally expensive (it's NP-hard if I recall correctly), which means there's no feasible way to ensure boards are always solvable in the given number of steps.
Glad you're enjoying the game :smile:

Thank you, this way I won't bang my head to the wall if I can't solve a maze for the 30th time :smile: