Second Contribution by Chinenye Ibegbunam

PROJECTS: PySAL pysal.org | PyTorch pytorch.org
Project 1: PySAL -- https://github.com/pysal/governance
Project 2: PyTorch -- https://pytorch.org/docs/master/community/governance.html
OVERVIEW
PySAL also known as The Python Spatial Analysis Library is an open-source project designed to support geospatial data science by simplifying native python functions into packages that can be used to analyze data. The solutions they build are also referred to as Packages.
PyTorch is an open-source project that democratizes state-of-the-art tools, libraries and other components to make AI & Deep machine Learning innovations accessible to everyone. The PyTorch framework is one that enables fast and flexible experimentation, and efficient production through a user-friendly front-end design, distributed training, and an ecosystem of tools and libraries for the easy application and integration of machine learning across different industries. PyTorch’s source development language is rooted in Python.
Having covered the basic background of both projects, here's a quick analysis of the both projects, and some key takeaways.
Analysis of PySAL's and PyTorch's Governance Models: Similarities, Differences, and Takeaways.
Some Similarities Include:

Both projects are open-source and are heavily reliant on python as a source language.
Both projects have similar governance and leadership structure and anyone can be a contributor to both projects.
Both PyTorch & PySAL acknowledge BDFL as the overall authority on the project.
Membership in both PyTorch’s Module and Maintainer groups and PySAL’s Council is given to individuals based on merit after they have demonstrated a strong commitment to the project through contributions, reviews and discussions and are aligned with how the component fits in the overall project vision/direction.

Some Key Differences Include:

PySAL Package Maintainers are heavily dependent on the Steering Council when it comes to decision-making, but PyTorch Module Maintainers have some level of autonomy that allows them to make their own decisions/guide their maintainer groups, and only revert to the Core Maintainers when needed.
There are no term limits for module maintainers or core maintainers in PyTorch, but the term limit for PySAL is a one-year frame.
In PyTorch, there's a light criterion of moving module maintainers who haven’t actively participated over a long period of time to ‘emeritus’ status and each module maintainer group may define the inactive period that’s appropriate for that module. If a PySAL Council Member becomes inactive in the project for a period of one year, they will be considered for removal from the Council. Although, before removal, the inactive Member will be contacted to see if they plan on returning to active participation any time soon. If not they will be removed immediately upon a Council vote.

Takeaways:
In summary, while it is evident that both projects share several similarities between them, there are also some significant differences in how they operate & how the projects govern themselves on some levels, and in light of that, I wouldn't categorically say that the governance system of one is better than the other because they are both unique in their own light, and have been designed the way they are to cater to the needs of the entire community & drive the progress of the entire project. While I appreciate the flexibility of PyTorch's governance in adopting an open ended approach as regards inactive contributors and the subtle easing into "emeritus" status after inactivity for a long period of time, maybe because they want to maintain "retention", I also appreciate PySAL's time framed model for inactive members because I believe it keeps contributor on their toes, encourages activeness and creates a chance for other contributors to serve as council members. In the same vein, while it is commendable that the decision making power remains within the reins of PySAL's Steering Council & BDFL to probably ensure order and uniformity, PyTorch's flexibility in granting some level of autonomy to Module Maintainers that allows them to make their own decisions/guide their maintainer groups, and only revert to the Core Maintainers when the need arises is also very commendable. So, in all, I'd say whatever the governance model may be or how it is designed, as long as it's fitting and caters to the participants/communities in focus, that should be about all that matters.

@arliss-NF here's my second contribution, kindly review. Thank you


Using the DivIcon icon, the top left corner is more than one, which is the style. The leaflet-div-icon adds background color and borders

How to reproduce

Leaflet version I'm using:
Browser (with version) I'm using:
OS/Platform (with version) I'm using:
step 1
step 2

What behaviour I'm expecting and which behaviour I'm seeing
Minimal example reproducing the issue

[ ] this example is as simple as possible
[ ] this example does not rely on any third party code

Using http://playground-leaflet.rhcloud.com/ or any other jsfiddle-like site.

Specify the className of the icon


API to manipulate instruments

From #208 the following requirements are identified:

A way to hide unneeded instruments.
A function to change the order of the instruments.
Functions to hide/show/move instruments.

I will take the opportunity to review current methods and to start re-organizing, defining and documenting the API for score manipulation.

@hugbug The "hide/show" instrument operation is not related to the score model but it is an operation at presentation level. I mean, the operation does not change the score internal model, that still will contain the instrument, but tries to change how the score is rendered at display or audio levels.
Therefore, this operation should be moved to other place, perhaps at View level, at Sound Player level or at other places, and this should be studied and decided with care. Do you currently need this operation or it is enough for now if you can remove instruments from the score?

Currently the workaround with manipulation of instruments works well for me.
Please take your time to define proper API.
Is it possible to have multipel views for the same score in Lomse? If yes, then it makes even more sense to show/hide instruments at the presentation level. That would make it possible to have one view with all instruments and another view with only one (or more) instruments. I don't need this in my app but can imagine such functionality in a more versatile score editor app.

Is it possible to have multipel views for the same score in Lomse?

Yes

I don't need this in my app

Ok, thanks. Then I will postpone implementing these "hide/show" methods in the API

I've been looking at your code, related to this issue, and I think that PR #242 provides the necessary support methods to avoid having to deal with lomse library internals.
More or less this is the list of things to change in conpianist:
Access to Document
Replace:
Document* doc = m_presenter->get_document_raw_ptr();
ImoDocument* imoDoc = doc->get_im_root();

By
ADocument doc = m_presenter->get_document();

Document methods

All methods to set page margins now include the word page in the method name. Access to ImoPageInfo object is no longer needed:
e.g., replace:
ImoPageInfo* pageInfo = imoDoc->get_page_info();
pageInfo->set_top_margin(500);

By
ADocument doc = m_presenter->get_document();
doc.set_page_top_margin(500);           //names changed by adding '_page'

All getter methods have been renamed to suppress the get_ prefix:
e.g., replace:
m_docScale = imoDoc->get_page_content_scale();
imoDoc->set_page_content_scale(1.0); // reset scale

By
ADocument doc = m_presenter->get_document();
m_docScale = doc.page_content_scale();
doc.set_page_content_scale(1.0);    // reset scale

Access to document content and, in particular, to scores:
e.g., replace:
ImoScore* score = dynamic_cast<ImoScore*>(imoDoc->get_content_item(0));
if (!score) return;
m_scoreId = score->get_id();

By
ADocument doc = m_presenter->get_document();
AScore score = doc.first_score();
if (!score.is_valid()) return;
m_scoreId = score.object_id();

Get scoreId and advance user marks:
e.g., replace:
SpInteractor interactor = m_presenter->get_interactor(0).lock();
Document* doc = m_presenter->get_document_raw_ptr();
ImoScore* score = dynamic_cast<ImoScore*>(doc->get_im_root()->get_content_item(0));
TimeUnits timepos = ScoreAlgorithms::get_timepos_for(score,
	loop.begin.measure > 0 ? loop.begin.measure - 1 : loopStart.measure - 1,
	loop.begin.measure > 0 ? loop.begin.beat - 1 : loopStart.beat - 1);
loopStartMark = interactor->add_fragment_mark_at_note_rest(m_scoreId, timepos);

By
SpInteractor interactor = m_presenter->get_interactor(0).lock();
ADocument doc = m_presenter->get_document();
AScore score = doc.first_score();
TimeUnits timepos = score.timepos_for(
		loop.begin.measure > 0 ? loop.begin.measure - 1 : loopStart.measure - 1,
		loop.begin.measure > 0 ? loop.begin.beat - 1 : loopStart.beat - 1);
loopStartMark = interactor->add_fragment_mark_at_note_rest(m_scoreId, timepos);

Score methods

Access to instruments and remove an instrument. When an instrument is deleted it is automatically removed from any group. Therefore, you can now ignore groups when removing instruments. Groups will auto-reorganize and a group will be automatically removed when only one instrument left in it:
e.g., replace:
while (score->get_num_instruments() > 0)
{
	ImoInstrument* instr = score->get_instrument(0);
	score->get_instruments()->remove_child(instr);
}

By
while (score.num_instruments() > 0)
{
    score.delete_instrument_at(0);

        //or
	AInstrument instr = score.instrument_at(0);
	score.delete_instrument(instr);
}

Specific methods for re-ordering instruments have been added. You no longer need to save instruments and groups to restore the score before deleting it. See https://lenmus.github.io/lomse/classAScore.html#ad392638c71061468fb7ef0c53e1ae9a1
e.g.:
score.move_up_instrument(instr);

Access to groups of instruments, remove group:
e.g., replace:
while (score->get_instrument_groups() &&
	score->get_instrument_groups()->get_num_items() > 0)
{
	ImoInstrGroup* group = (ImoInstrGroup*)score->get_instrument_groups()->get_child(0);
	score->get_instrument_groups()->remove_child(group);
}

By
score.delete_all_instruments_groups()

    //or
while (score.num_instrument_groups() > 0)
{
    score.delete_instrument_group_at(0);

        //or
	AInstrGroup group = score.instrument_group_at(0);
	score.delete_instrument_group(group);
}

Instrument methods

Access to instrument MIDI info (IMPORTANT: API MIDI methods now require and return valid MIDI values (1 based) instead of 0 based values used by internal lomse objects):
e.g., replace:
ImoInstrument* instr = score->get_instrument(0);
int midiChannel = instr->get_num_sounds() > 0 && instr->get_sound_info(0)->get_midi_info() ?
	instr->get_sound_info(0)->get_midi_info()->get_midi_channel() + 1 : 0;

//or, more verbose:
instr->get_num_sounds() > 0
ImoSoundInfo pSoundInfo = instr->get_sound_info(0)
ImoMidiInfo pMidi = pSoundInfo->get_midi_info()
int midiChannel = pMidi->get_midi_channel() + 1;

By
AInstrument instr = score.instrument_at(0);
int midiChannel = instr.sound_info_at(0)->midi_info()->channel();

//or, more verbose:
instr.num_sounds() > 0
ASoundInfo sound = instr.sound_info_at(0)
AMidiInfo midi = sound.midi_info()
int midiChannel = midi.channel();

Change instr. names and abbrev:
e.g., replace:
instr->set_name(m_instrNames[num]);
instr->set_abbrev(m_instrAbbrevs[num]);

By
instr.set_name_string(m_instrNames[num]);
instr.set_abbreviation_string(m_instrAbbrevs[num]);

Hope this helps.

Thank you for the new API and all the tips regarding my app.
Actually I don't need to delete instruments. All I wanted was to hide/unhide instruments (plus rearrange). In my app after the song and score are loaded the user can select an instrument to play. Then all other instruments from the score are hidden. The user can then select another instrument, then the previously hidden instrument must be shown again but all others must be hidden.
I used deletion of instruments as a workaround. With the new API the deleted instrument is probably gone for good and cannot be restored. Is this correct? In that case I need to load the score from the disk again, which I'd like to avoid because this costs time.

Hide/unhide instruments is a fuctionality related to presentation and, thus, it is something that should be controlled at View level. I will include this functionality there.

With the new API the deleted instrument is probably gone for good and cannot be restored. Is this correct?
Yes, that's correct. AScore::delete_instrument() removes the instrument from the score and deletes it. Lost forever!


add readData.RDS

awesome!

Coverage remained the same at 0.0% when pulling c758841bb69550273dbc0d39750c5a0b78c1558c on lindsaycarr:master into c73f645b298aa0fccf6aa9c4d1ceecb7d2a78f92 on USGS-VIZLAB:master.


Loading first page of a PDF file

Hi,
Thank you for this great tool !
I want to load only the first page of pdf files. I found that for a file named "myfile.pdf" it's possible to use filename='myfile.pdf[0]', but I don't know how to deal with binary blobs.
Best regards

Use the format= kwarg to trick the constructor.
with Image(blob=my_binary_blob, format="PDF[0]") as img:
    assert len(img) == 1
    # ... do work ...

Works like a charm. Thank you !


Script to search midi files and some bug fixes

Coverage increased (+31.0%) to 49.763% when pulling 6ced6aeb19d45d5fbcc4c06e4972bbe849d944d3 on indexing into 63a7068c8c6ba7af3fdb98eba606e9701115a15b on master.


skaffold doesn't build arm64 image

I am building on a Macbook pro with an Intel chip architecture. I am trying to build and deploy a container on a remote arm64 cluster. It looks like skaffold detects the target platform but says it doesn't support it. "WARN[0000] builder for artifact "" doesn't support building for target platforms: "linux/arm64". Building for supported platforms "linux/amd64" instead.  subtask= task=Build
Cleaning up...
Here is my skaffold.yml.
apiVersion: skaffold/v4beta3
kind: Config
metadata:
name: spring-boot-jib
build:
artifacts:
- image:
buildpacks:
builder: gcr.io/buildpacks/builder:v1
manifests:
rawYaml:
- kubernetes/springboot-jib-deploy.yaml
- kubernetes/springboot-jib-ingress.yaml
deploy:
kubectl: {}
I can build the image using Maven and deploy it locally.  The problem is skaffold. It won't build arm64 images.
Any help would be appreciated.

Jib will make arm64 images. Note: the envTemplate requires that the VERSION be defined in the environment:
export VERSION=0.0.1
apiVersion: skaffold/v4beta3
kind: Config
metadata:
  name: spring-boot-jib

build:
  tagPolicy:
    envTemplate:
      template: "{{.VERSION}}"
  artifacts:
    - image: <your-repo>/<your-id>/springboot-jib-skaffold-arm64
      jib:
        type: maven
        fromImage: registry-1.docker.io/sapmachine:19.0.2@sha256:899093ed8b230b827dd2eac415ef84b9d0af3d42142b7f3b4906375906cba676

manifests:
  rawYaml:
    - kubernetes/springboot-jib-deploy.yaml
    - kubernetes/springboot-jib-ingress.yaml

deploy:
  kubectl: {}

The fromImage uses sapmachines Java19 arm64 image as a base. The build command is:
skaffold build
That should do it.


Fix version type in vhea table

We had specified this as MajorMinor (essentially a packed pair of u16s) but the type in the spec is Version16Dot16, which has its own special representation.

Yea, this one is particularly weird. It seems pretty obvious from the spec that Version16Dot16 is soft-deprecated, so really no clue how it snuck into this table.


WRONGTYPE - Key with colons

Hello,
I am encountering WRONGKEY errors under the following circumstances:

redis-cli trying to read keys added by redis-py (key = 'frontend:test.ufam.jp')
redis-py client trying to read keys added by redis-cli (key = 'frontend:test.ufam.jp')

Each client is able to successfully read keys they created.  Here is a simplified example showing a call to keys() then using the value in a call to lrange() which causes an error.
Any suggestions or insight as to what may be going wrong would be much appreciated.
Environment:

Ubuntu: Ubuntu 16.04.1 LTS
Python Redis version: redis (2.10.5)
redis-server: 3:3.0.7-1chl1~precise1

WRONGKEY indicates that you tried to to perform an operation on a value of a different type. In your example, it looks like you're trying to perform the list operation LRANGE on a key, but the error indicates that the value stored at that key isn't a Redis list.

You are correct sir.  Using p.type(k.pop()) (line 6) indicates it is a 'string', but a Type check in redis-cli indicates it is a 'list'.
I am not sure they redis-cli and redis-py would return different types for the same key.

In your example you're using Python's builtin type() on the key name which will always be a string. To see the same value that redis-cli shows you'd want to use r.type(keyname) instead.


Failed builds in "Merge group checks requested"  still allow a merge

here's an example of it happening... I don't think it should occur:
#190
https://github.com/ublue-os/nvidia/actions/runs/7795059098

I created a custom action to do this, and it now works well.  I copied took inspiration from Keycloak
https://github.com/rsturla/eternal-main/blob/main/.github/actions/check-jobs-success/action.yml
Where's best to PR the action to so it's hosted in ublue?

@p5 see #197  for the simple solution I had in mind when creating this issue.
I'm not sure why the job I committed the months ago was broken, I apparently was lazy in copy/paste or testing or something.
I'm interested in your idea about having a shared action for doing this, but not sure where to put it off hand and wanted to knock this out in a way we have used elsewhere in the project.


Playground sandbox

I should work better (that's why I've added it). But it'll also enable other samples to work.


Function read_parquet throws an error for an 'and' clause in the partition_filter parameter

Describe the bug
Can't use an 'and' condition in the partition_filter parameter when reading a parquet file
How to Reproduce
Succeeds
    df = wr.s3.read_parquet(path="s3://bucket/folder,
                            boto3_session=session,
                            dataset=True,
                            partition_filter=lambda x: x["year"] == "2018" or x["month"] == "1")

Fails
    df = wr.s3.read_parquet(path="s3://bucket/folder,
                            boto3_session=session,
                            dataset=True,
                            partition_filter=lambda x: x["year"] == "2018" and x["month"] == "1")

Error received
NoFIlesFound: No files found on s3://bucket/folder
Expected behavior
and conditions would perform the same as an or clause
I also tried to match the format of the documentation to no avail.

Your project
No response
Screenshots
No response
OS
Linux/Windows
Python version
3.8.5
AWS DataWrangler version
2.14.0
Additional context

Wrangler throws an error after listing the bucket if there are no objects matching your criteria. Looks like there are just no files in /year=2018/month=1/ partition


Added feature to pre-label elements

#2

@mefengl Actually this will still return the wrong button if coder uses chatgpt.getSubmitButton() somewhere in his script and user has scripts installed that change button order, since chatgpt.getSubmitButton() is not relying on the newly assigned IDs

And users would naturally type var sendButton = chatgpt.getSubmitButton() and not deal with IDs, so the functions themselves need to work instead (I fixed the submit one already)


GRAD2-1966 : task is complete.

GRAD2-1966 : task is complete.

Good question.  OverWrite flag is in the payload for saving transcript and certificate.  No need to have another endpoint to delete those.


Add feedback buttons to pages

Addresses #506

Confirmed I was able to click one of the feedback buttons on the white paper page 🙌
Not sure which pages should/should not have them so will leave that for the lead review, but very happy to see this implemented! 🎉

It's currently set to show the buttons on blog posts, contribute section pages (of which there currently aren't any), and whitepaper pages. Note that it won't show on any list pages which are those that have the filename _index.md. I think some of those actually should just be regular pages, with filename index.md.


Microsoft EDGE - Update Adapter.js

I was studying Web RTC (using Adapter.js ) and Microsoft Edge works .
However , their examples I THINK it is not with the Adapter updated.
Here source that can serve as a reference:
https://raw.githubusercontent.com/webrtc/adapter/master/adapter.js

Are you running Windows Insider Preview Build 10532?
Known issues in Windows Insider Preview Build 10532
Initial groundwork for the Object RTC API is in this build, but is not yet functional. This may trigger feature detection for Object RTC. A working implementation will be available in preview builds soon.
Partial support for Async Functions (ES2016) is in this build, but there are known issues with the implementation which should be fixed in the next Insider release.
It's something to keep an eye on definitely.


Feature merged pull requests from forked oauth project (97, 95, 88, 85, 79)

Talked to the maintainer and I was asked to help with trying to merge some of these pull requests. This is what this all about.

thank you and sorry for late merge, my mailbox was overrun with messages and I was not able to clean it enough to notice your message till today

No prob. Thanks!


Replace the raw C string handling with Rust strings

Replace the raw C string handling with Rust strings - in particular in the Shader parsing code. The end goal would be to delete all the functions beginning with Str i.e. StrDup in libphx/src/internal/Memory.rs
UPD. I'm going to replace all string related code generated by c2rust to rust String/str types.
This can introduce some overhead at places where we send string to C code (i.e. Lua since it works with C-style strings) but it should not be significant (or we will address this later during benchmarking).

Something to bare in mind is that we need to be careful that the raw C strings we return through the no_mangle C API has the correct lifetime. For example, we may need to return a string that gets freed the next time the function is called. An example if this is Device_ToString in Device.rs.
The string ffi helper functions in libphx/src/internal/ffi.rs may also come in use.

I just checked mlua and from the description looks like it supports LuaJIT.
If we can use it, it would solve a lot of issues. But it should be investigated how usable it is.

Yeah, I will concentrate here only on fixing strings.
I was just wondering if we can simplify integration with Lua by using mlua. I didn't look yet deep into the internals of mlua/luajit so don't know how optimal it works. Will take a look at it when I have more time.

I'm not sure mlua will be much help unfortunately (but I would encourage further investigation!)
What might be possible is perhaps a way to generate the Rust -> C interop code using a macro? Perhaps given a struct and a method, it generates a C function wrapper for it, converting the types where appropriate using traits or something?

Yes, we can think about some proc macro to automatically generate C/Lua bindings for functions and types (structs, enums, etc).
So it could look something like:
#[bind_lua]
pub fn Device_ToString(this: &mut Device) -> String {
    ...
}

so macro will generate proper extern "C" wrapper.
I have some experience writing proc macros, so I'll think about it later.

Sounds great! Currently, a lot of things kind of work already. For example this: Option<&mut Device> will be ABI compatible with Device* this in C, but it would be super cool if we could receive Rust strings as arguments or return them.

I think things are not so simple because of conversion we have to do: C-string (ASCII) <-> Rust string (UTF-8).
So we convert input C-string parameters to Rust string. We can do this in the wrapper so it will drop Rust string at the end. Input C-string should be managed by Lua.
Output strings should be managed the way you suggested with some modification:

Rust String/&'static str should be converted to C-string.
Original Rust String will be destroyed by Rust drop in the wrapper.
&'static str will remain since it's static.
C-string should be destroyed by Lua

I think this is most logical way. There are quite some conversion/copying here but I don't think we can avoid it if we are going to use standard Rust strings.

Agreed, I don't think the copying is a big deal, and we can probably do some shortcuts like assume that all C strings are valid UTF-8 strings, like:
pub fn PtrAsSlice<'a>(ptr: *const libc::c_char) -> &'a str {
    unsafe { str::from_utf8_unchecked(CStr::from_ptr(ptr).to_bytes()) }
}


test(travis): Add Testing for Node 5

Added Node 5 to the .travis.yml, but allowed failures. Since Node v5 uses npm 3 there's some work to be done to support it.
Since the build is currently failing on Node 5, I added a note to the README under the prerequisites to make clear that Node 5 is not supported at this time.

@codydaig @lirantal why don't we just merge this in now?

@ilanbiala I'm not opposed.

LGTM


Referencing issues from commit messages is now possible.

Code-wise: the fixing-part of the code now doesn't reference the issue any more, because this is done by the referencing-part of the code, which is called just before.
Fixes #462, #668, #732.

Thanks your PR!
Simple question:
Would this will produce one reference and one close actions if commit message is fix #1?
Because based on the patterns, it seems like reference pattern will also match strings that should be only matched for fix/fixes etc. patterns?

It references and closes, yes. This was already the case, and, since a "close" does not reference to an issue, this is what you'd want.

Cool, I see. Will merge soon in terms of other matters.
BTW, how's your dinner going? :smile:

Merged, thanks again!


Sign Windows .exe file

Sign binary for safer auto-updates and fewer install warnings upon first install.
I'm currently in the process of getting a cert. Bought one for $90. They want me to get an in person notary to prove that I'm who I say I am before they will issue the cert.
Will continue update this issue with the progress.

Getting the notary tomorrow morning at 10am.

Sent to notary forms to Comodo today. Hopefully I'll get the cert by Friday, but we'll see.

You should write a blog about all the trouble you're going through for these auto-update certs!

@ungoldman Hah, good idea.

I finally got the cert earlier this week, but had trouble figuring out where the private key was stored. It was the weirdest process I've ever seen!
The CA required the order to be placed from Firefox. The private key and CSR (certificate signing request) were generated in the browser. I think it wasn't possible (or easy) to copy the private key out, so I assumed that they were just going to keep a copy of it, which seemed really sketchy.
It turned out that they stored the private key in Firefox's local storage. They just got the CSR. After the weeks of verification, I got an email saying that the cert was ready. If you click the link in any browser but the original one where the order was placed, the certificate will be downloaded, without the private key.
But if you go back to the original Firefox browser, then an alert shows up saying that a certificate was installed in Firefox -- WITHOUT a user prompt! It just installed itself automatically. What?
At this point, you can export the combined cert and private key file (.p12 /.pfx) to use for signing.


docs: info about ssh keys

Description
Information about how to generate SSH keys.
Addresses https://github.com/terraform-ibm-modules/terraform-ibm-issue-tracker/issues/47
Check the relevant boxes:

[ ] Bug fix (nonbreaking change that fixes an issue)
[ ] New feature (nonbreaking change that adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Examples or tests (addition or updates of examples or tests)
[x] Documentation update
[ ] CI related update (pipeline, etc.)

Checklist

[ ] If relevant, a test for the change has been added or updated as part of this PR.
[ ] If relevant, documentation for the change has been added or updated as part of this PR.

Merge

Merge using "Squash and merge".
Make sure to use a relevant conventional commit message that is based on the PR contents. The commit message determines whether a new version of the modules needs to be released, and if so, which semver number to use).

:tada: This PR is included in version 1.11.0 :tada:
The release is available on:

GitHub release
v1.11.0

Your semantic-release bot :package::rocket:


[FLINK-3943] Add support for EXCEPT operator

Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into consideration.
If your changes take all of the items into account, feel free to open your pull request. For more information and/or questions please refer to the How To Contribute guide.
In addition to going through the list, please provide a meaningful description of your changes.

[x] General

The pull request references the related JIRA issue ("[FLINK-XXX] Jira title text")
The pull request addresses only one issue
Each commit in the PR has a meaningful commit message (including the JIRA id)

[x] Documentation

Documentation has been added for new functionality
Old documentation affected by the pull request has been updated
JavaDoc for public methods has been added

[x] Tests & Build

Functionality added by the pull request is covered by tests
mvn clean verify has been executed successfully locally or a Travis build has passed

Renamed UnionITCase to SetOperationsITCase as suggested here: https://github.com/apache/flink/pull/2159

Hi @mushketyk, I think we should remove duplicate records in CoGroup instead of using distinct. Others looks good to me.

Updated documentation as suggested.

Hi @mushketyk, thanks for the PR! I added a few comments inline.
Best, Fabian
@wuchong, thanks for reviewing!

@fhueske Thank you for the detailed review! I've updated my code according to your comments.
I noticed that @wuchong is performing some type conversions in his INTERSECT implementation: https://github.com/apache/flink/pull/2159/files#diff-a6c2112ca46d26fcf49f1edba1c73f75R121
Should I do something similar in the EXCEPT case? If yes, does it mean that my test coverage is not sufficient and does not cover some particular case?

@fhueske Hey. Sorry for bothering you. Do I need to change something else in this PR?

@mushketyk Thanks for the PR.
I also reviewed the current status. I think it's good to compare your code with #2159 before you rework it.

@twalthr Thank you for your review! I've update the PR according to your comments.

@twalthr Updated PR according to your commits and rebased on top of the master branch to avoid merge conflicts.

Thanks for updating the PR. I reviewed the code again. There were still some issues regarding the documentation and also expectedType handling in DataSetMinus, I fixed them myself and will merge now...

@twalthr Thank you for accepting my changes!


Support for Concurrency Segments IndexSearch and parallel DrillSideways

It could be great lucenenet support for Better Segment To Thread Mapping Algorithm and A parallel DrillSideways implementation for better concurrency implementation. I also like to know more about Lucenenet concurrency.

In general, LuceneNET has great concurrency support.  The parallel DrillSideways implementation you mentioned is specifically for facets.  That particular feature wasn't added until Lucene 9.  As such it won't be added to LuceneNET 4.8.
However, it is currently hoped that after LuceneNET 4.8 has a production release, we will begin working on catching up LuceneNET to the latest version of Java Lucene.

In general, LuceneNET has great concurrency support. The parallel DrillSideways implementation you mentioned is specifically for facets. That particular feature wasn't added until Lucene 9. As such it won't be added to LuceneNET 4.8.

parallel DrillSideways implementation is added back in Lucene 7 and Better Segment Thread Map algo is part of Lucene 9 expecting both the improvements added to LuceneNet 4.8.

However, it is currently hoped that after LuceneNET 4.8 has a production release, we will begin working on catching up LuceneNET to the latest version of Java Lucene.

Coming back to LuceneNet concurrency is not supported for Async also some of the concurrency works rely on Dedicated ThreadPool with the help of TaskScheduler APIs like IndexSearch, ConcurrentMergerScheduler and etc.., To handle this kind of scenario LuceneNet uses LimitedConcurrencyLevelTaskScheduler.cs.

cc: @NightOwl888 , @laimis


🐛 Bug Report: It is unclear that feature flag toggle requires refresh

📜 Description
When turning feature flag on or off, a page refresh is required to make it take effect
👍 Expected behavior
Switching feature flag on or off should re-render the current page
👎 Actual Behavior with Screenshots
Feature flags don't affect the current state of UI before page is refreshed
👟 Reproduction steps

Add a feature flag to the application
Make one of the menu items to be behind a feature flag
Go to user settings
Toggle feature flag on
Menu item is not visible until page refresh

📃 Provide the context for the Bug.
No response
🖥 Your Environment
No response
👀 Have you spent some time to check if this bug has been raised before?

[X] I checked and didn't find similar issue

🏢 Have you read the Code of Conduct?

[X] I have read the Code of Conduct

Are you willing to submit PR?
None

This is very intentional, as it makes it significantly easier to implement feature flags at any point in the app or plugins. We could add some form of API for watching feature flag state, but the worry then is that some flags will work that way and others wont, and the user has no idea. To be able to do this I think we need to attack that problem directly, with some way to register a feature flag as "live", and then inform users whether they need to reload the page after changing a flag or not.

Yeah, at least informing the user to refresh the page when changing a flag would be a good thing. It would work as a first step before jumping into the implementation of "live" flags

Yep, totally! Let us know if you want to submit a PR for that, I've opened it up either way

Hey @Rugvip :wave:
Seems fairly straightforward, are you thinking of some kind of message here in the UI with what @drodil mentions?
:point_right: https://demo.backstage.io/settings/feature-flags
I.e. maybe a message in the card saying Please refresh the page when enabling feature flags
LMK?

Yes that would be the correct place. Even better would be changing the phrasing to Please refresh the page when toggling feature flags as it also applies to disabling those. And in implementation POV the message should only be shown when toggle is changed, what do you think?

Sounds good to me, is this something you want to raise a pr for @drodil? Otherwise, I have some spare time today/tomorrow I could give it a shot :muscle:
Also of course if @Rugvip agrees :wink:

I could but not sure when I have time so go ahead if you do :)

Very K.I.S.S approach (always the best) :smile:

Will make a PR later today, what do you think @Rugvip, @drodil?
Thanks!

Message added by @Parsifal-M , will close this issue now.


feat: introduce client for CDN

Inspired on https://github.com/fal-ai/fal-js/pull/96 but with token management

Closing in favor of #111 that addresses both new CDN via presigned urls and also multipart uploads


[BUG] failed to create upgrade image

Describe the bug
Failed to create the upgrade image, and the backing image shows an error with context canceled.
To Reproduce
Steps to reproduce the behavior:

Import an upgrade image that is hosted locally
the upgrade contains an error of

Download Upgrade Image99%
failed to finish file /data/tmp/harvester-system-harvester-iso-mm9dz-0609df09.tmp and /data/tmp/harvester-system-harvester-iso-mm9dz-0609df09 processing: context canceled

Expected behavior

Support bundle

Environment:

Harvester ISO version: v1.0.1-rc2
Underlying Infrastructure (e.g. Baremetal with Dell PowerEdge R630):

Workaround
You can start over by deleting the upgrade resource via logging in to one of the Harvester node.
╰─$ kubectl get upgrades.harvesterhci.io -n harvester-system
NAME                 AGE
hvst-upgrade-5bqm6   97s
╭─ ~/codes/try-harvester
╰─$ kubectl delete upgrades.harvesterhci.io hvst-upgrade-5bqm6 -n harvester-system

How's going on this bug? Got fix anyhow?

I also met context canceled error, but I didn't have any "upgade" in harvester-system

I found this error log in longhorn-csi-plugin pod. Don't know if it is related


add types

Adds TS types for ./packages

:rocket: PR was released in<EMAIL_ADDRESS><EMAIL_ADDRESS>:rocket:

:rocket: PR was released in<EMAIL_ADDRESS>:rocket:


Yorkie installation fails which causes Vue CLI to fail

Version
3.2.1
Environment info
Environment Info:

  System:
    OS: Linux 4.9 Debian GNU/Linux 9 (stretch) 9 (stretch)
    CPU: (4) x64 Intel(R) Core(TM) i5-8600K CPU @ 3.60GHz
  Binaries:
    Node: 11.3.0 - /usr/local/bin/node
    Yarn: 1.12.3 - /usr/local/bin/yarn
    npm: 6.4.1 - /usr/local/bin/npm
  Browsers:
    Chrome: Not Found
    Firefox: Not Found
  npmGlobalPackages:
    @vue/cli: 3.2.1

Steps to reproduce
vue create myapp
choose "default" setup
(Also tried the manual setup, which doesn't work either...)
What is expected?
Vue installs successfully
What is actually happening?

<EMAIL_ADDRESS>install /data/denni/Documents/git/cateroo-frontend/what/node_modules/yorkie
node bin/install.js
fs.js:122
throw err;
^
Error: EINVAL: invalid argument, open '/data/denni/Documents/git/cateroo-frontend/what/node_modules/yorkie/package.json'
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR<EMAIL_ADDRESS>install: node bin/install.js
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>install script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

Comments
I tried to install yorkie with npm install yorkie. That fails with the same error message, so it seems it is a problem with yorkie. Why is Vue depending on this? Yorkie doesn't even have an issues tab on GitHub. Is Vue just using latest available version of dependencies? Seems like a great cause for failure.

@dentych
Why was this closed?
Did you find a solution?

@ginomempin Hey there! As far as I remember, I was trying to run VueCLI in a Docker container running either Alpine or Ubuntu (most likely I was using Alpine, but can't remember for certain). I tried installing Node on my system instead, without using Docker, and it seemed to work.

I tried installing Node on my system instead, without using Docker, and it seemed to work.

You mean you installed it globally?
It does seem to work if you install packages globally.
I got the same error and it is still not working for me, though.
In case you are interested, I created a new ticket at #3466.

You mean you installed it globally?

I mean, instead of installing Node inside a Linux Docker container, I installed it on the Windows host (the system that was running Docker). It seemed to work.
The architecture I used in the Docker container was Linux amd64

I am facing the same issue trying to run vue-cli inside a container if I let vue create use npm; it works with yarn, though. I could confirm that npm install<EMAIL_ADDRESS>fails, while yarn add<EMAIL_ADDRESS>works. If relevant, I am not working as root in the container, but as a simple user.

The same error occurs using node:10.15.1-slim (note the -slim) while node:10.15.1 does not.

Solved issue by using latest node image for container FROM node:latest

I was facing the same error while trying to create a Vue project from inside a Docker container. My Dockerfile was as follow:
FROM node:lts-alpine

# Working directory and mount volume
ARG PROJECT_DIR=/srv/app
RUN mkdir -p $PROJECT_DIR
WORKDIR $PROJECT_DIR
VOLUME $PROJECT_DIR

# Install Vue CLI
RUN npm install -g @vue/cli

I build the Docker image and connect to the Docker container with these commands:
$ docker build -t vue-app-setup:latest .
$ docker run -it --rm -v "C:\my_path\vue-app-setup:/srv/app" vue-app-setup sh

In the Docker container, I run vue create my_project.
I got the error message:

Failed at the<EMAIL_ADDRESS>install script

Same as @stepansib, I solved my issue with FROM node:latest instead of FROM node:lts-alpine in my Dockerfile

No idea why it's closed if it is still failing on Docker

This error<EMAIL_ADDRESS>is related to the security attributes of the project-vuejs folder. So, create your projects outside the root / folder, make Linux updates (Ubuntu ...) and success to everyone!

Updating npm to latest fixed it for me.
npm install -g npm@latest

When trying to use in a Dockerfile FROM php:7.3-fpm

Updating npm to latest fixed it for me.
npm install -g npm@latest

When trying to use in a Dockerfile FROM php:7.3-fpm

I had the same problem with Error: Cannot find module '../../package.json'. Was using the linux subsystem. This article says it might be a problem with permissions: https://www.programmersought.com/article/58086441997/
Switching user in the subsystem did not get me along. Running the vue create command in the plain windows cmd with newest npm version solved it.


[Tooling] VS Code Ballerina Project Overview Enable Tests Grouping

It would be helpful if the Ballerina Project Overview in VS Code would group together functions that belong to a test.

In this example image, the afterFunc, afterSuiteFunc, beforeFunc, beforeSuiteFunc, testFunction functions belong to the testing suite, and should be grouped together.
This will make it easier to navigate the overview and reduce clutter.

Moved to https://github.com/wso2/ballerina-plugin-vscode/issues/93


bosh create release should take private.yml credentials as arguments

Could we please provide private.yml credentials as arguments to bosh create release? This would make providing credentials via CI (ie Concourse) much easier, as we don't need to template a file.

@DanielJonesEB what do you think about specifying path to private.yml via cli flag. then you could do --private <(something here). or do you think private.yml should remain in the repo and just work with -l flag to interpolate variables?
cc @vito

Thanks for taking the time to consider this, @cppforlife.
There are only three supported blobstore types at present, is that correct? Atmos, S3 and Local? If so, I think the user experience would be nicest if there was the option to specify the relevant values purely by command line --blobstore-type s3 --access-key foo --secret-key bar, although I can see that leads to three branches of 'special case' code.
Failing that, the variable interpolation would be cool. I'm not familiar with the -l flag: is that something new?

we are planning to add --private-conf flag that can be used with bash's standard pipe redirect:
$ bosh create-release --final --private-conf <(lpass ... or may be bosh build-manifest ... -l ...)

@cppforlife is Atmos still supported in bosh cli V2?

@bonzofenix s3 and local are the currently supported types: https://github.com/cloudfoundry/bosh-cli/blob/bb528b8072d38785e29cd1e5d19cdb53a4b46409/releasedir/provider.go#L101-L108
cc @cppforlife

Hi @DanielJonesEB!
I simply want to check with you if this issue is still relevant to you. If that's still the case, I will have a deeper discussion on it with the engineering team. Please let me know.

Thanks for following up! It's not causing any acute pain at the moment.


chore(devtools-server): replace preferred-pm with package-manager-detector

PR Checklist
Please check if your PR fulfills the following requirements:

[x] The commit message follows our guidelines: https://refine.dev/docs/guides-concepts/contributing/#commit-convention

Bugs / Features

[x] Related issue(s) linked
[ ] Tests for the changes have been added
[ ] Docs have been added / updated
[x] Changesets have been added https://refine.dev/docs/guides-concepts/contributing/#creating-a-changeset

What is the current behavior?
preferred-pm pulls in 24 dependencies, which is unnecessary for what it does: https://npmgraph.js.org/?q=preferred-pm
What is the new behavior?
ref https://github.com/refinedev/refine/issues/6242
package-manager-detector has no dependencies: https://npmgraph.js.org/?q=package-manager-detector
Notes for reviewers

Oops. not sure how I missed adding the package. It's been updated now
If it's okay, could we keep this PR to just the @refinedev/devtools-server and do the CLI separately?


[CHM309] add km-link component

km-link component
complete km-link function , contains:
km-add-link
km-add-file

change to one link table

add space between buttons, button and table.


Revise initializers for depthwise and pointwise kernels

This PR addresses #11773, the issue of initializers described in the "Requests for contributions". I checked the scales of initial weight values of three layers (Conv2D, DepthwiseConv2D, SeparableConv2D) with six initializers. I set the hyper-parameters of the 3 layers in order to have the same mapping: (n, 32, 32, 64) -> (n, 28, 28, 128).
In results, the current implementation assigns the different scales of weight values if a kernel is pointwise kernel or an initializer is fan_out, as shown in the "as-is" figure. Thus, I proposed one of the possible solutions as this PR. The solution can make all the initiali values have the same scales, as shown in the "to-be" figure.
Test codes
import numpy as np
import matplotlib as mpl
import matplotlib.pyplot as plt

from keras.models import Model
from keras.layers import Input, Conv2D, SeparableConv2D, DepthwiseConv2D
from keras.initializers import VarianceScaling

f, axarr = plt.subplots(6, 4, figsize=(10, 10))

inputs = Input(shape=(32, 32, 64))
weights = []

for (i, init) in enumerate(['glorot_uniform', 'lecun_uniform',
                            'glorot_normal', 'he_normal', 'he_uniform',
                            VarianceScaling(mode='fan_out')]):
    x = [Conv2D(128, 5, kernel_initializer=init)(inputs),
         DepthwiseConv2D(5, depth_multiplier=2, depthwise_initializer=init)(inputs),
         SeparableConv2D(128, 5, depthwise_initializer=init, pointwise_initializer=init)(inputs)]
    models = [Model(inputs=inputs, outputs=_x) for _x in x]
    weights.append([model.get_weights() for model in models])
    axarr[i, 0].set_ylabel(init if isinstance(init, str) else 'fanout')
    axarr[i, 0].hist(weights[i][0][0].reshape(-1))
    axarr[i, 1].hist(weights[i][1][0].reshape(-1))
    axarr[i, 2].hist(weights[i][2][0].reshape(-1))
    axarr[i, 3].hist(weights[i][2][1].reshape(-1))

    if i == 0:
        axarr[i, 0].set_title("Conv2D\n(%s)" % list(weights[i][0][0].shape))
        axarr[i, 1].set_title("DepthwiseConv2D\n(%s)" % list(weights[i][1][0].shape))
        axarr[i, 2].set_title("Separable\nin SeparableConv2D\n(%s)" % list(weights[i][2][0].shape))
        axarr[i, 3].set_title("Pointwise\nin SeparableConv2D\n(%s)" % list(weights[i][2][1].shape))

plt.show()

As-is

To-be

Closing outdated PR.


Auto refresh loop on landing page

Environment

Local only

Steps to Reproduce

Start the webapp server locally
Go to http://localhost:3000/ on any browser(chrome incognito included) other than chrome

Current Behaviour
The web page auto refreshes itself indefinitely by trying to reach the url below, each refresh has a different state param

http://localhost:3000/#error=login_required&state=7378a922-ca94-4e34-b52f-a376f356f483

Expected Behaviour

No refresh

Fixed wit FAM


feat(motion_velocity_smoother): cherry pick force acceleration and slow driving

Description
Cherry-pick force acceleration and slow driving
https://github.com/tier4/autoware.universe/pull/1329
https://github.com/tier4/autoware.universe/pull/1409
Related links
https://github.com/tier4/FieldOperatorApplication/pull/701
https://github.com/tier4/autoware_launch/pull/529
How was this PR tested?
None
Notes for reviewers
None.
Interface changes
Topic changes
Additions and removals

Change type
Topic Type
Topic Name
Message Type
Description

Added
Srv
/planning/scenario_planning/velocity_smoother/adjust_common_param
std_srvs::srv::SetBool
Change parameter for force acceleration

Added
Srv
/planning/scenario_planning/velocity_smoother/slow_driving
std_srvs::srv::SetBool
Set velocity limit for slow driving

Effects on system behavior
None.

@shmpwk
Spelling miss corrected in def5cadc81177563c515fb82dbacd63cb3552853

Thank you so much!


Barcode Component crash the App os iOS 10.0

I was using your component on iOS 9.3 and all works fine. When I target the application to new iOS 10.0, and I open the barcode reader, my App Crash unsespectedly. Could you review that? Thank you a lot.

I'm having the same issue.
Sadly I cannot give you error logs as none are to be found (strangly)
Was working on 9.3
On 10 it instantly crashes

https://github.com/Redth/ZXing.Net.Mobile/issues/421 solved it for me

I have a scenario where it works on iPhone 6 but crashes on iPhone 5

have you tried to had this to your info.plist ?:
NSCameraUsageDescription
The app need to access the camera

Solved for me updating info.plist

Thanks for reporting this issue!  Unforunately it took me way too long to respond 😭.  Sorry, I apologize!  Recently the source code for this project was completely refactored to modernize it.  Many PR's were included in this effort, and many bugs were hopefully fixed.  Please try out the latest 3.x series of NuGet packages (currently in prerelease).  To try and make the project more maintainable in my spare time going forward, I've decided to close all existing issues to start with a clean slate.  If you're still experiencing this issue on the newest version, please open a new issue with as much detail as possible.  Thank you for your patience and understanding!  Happy scanning!


feat: add NodeJS version select + use @discordjs/builders + better types

Use @discordjs/builders wherever applicable for markdown output.
Add types for MDN
Add types for Node
Add "version" option to Node which uses options to select between 12, 14 and 16 (default)
Changed the docs Algolia query to send API app/key with headers

This also means this PR supersedes #19. Sorry for stealing your PR @KrishAgarwal2811 but I had this planned for a while... lol

Wow that's a great change @Favna. I just had a temporary fix 😂.


when_all's completion signatures are subtly wrong

The set_error_t signatures should decay_t<Error>&& similar to the set_value_t signature. Also, if decay-copying any of the values or the errors can throw an exception, we need to add a set_error_t(exception_ptr&&).

this is already addressed in the latest wording


Node Module is not working after packaging the application

Hi,  I install node module with NPM and its working fine in development environment, but getting " Cannot find module"  error in application after packaging it.

Found any fix getting same issues?

🎉🚀 New Electron.NET version 23.6.1 released 🚀🎉
With native Electron 23 and .NET 6 support. Your problem should be fixed here. If you continue to have the problem, please let us know. Please note the correct updating of your API & CLI. Info in the README. Have fun!

Same issue here, 23.6.1.


current playlist not working

When you queue a season or tv series it will go to current playlist but when you click on any item on the list the entire playlist just disappears

fixed


Add UID and GID variable

In Unraid its important of being able to set UID and GID to 99:100. I tried it through the following docker flag:
--user=99:100

But the NPM docker container isn't happy with it:
s6-mkdir: warning: unable to mkdir /var/run/s6: Permission denied

Some containers solve this by using additional variables:
https://hub.docker.com/r/linuxserver/mariadb#:~:text=boot and setup.-,Usage,-Here are some
    environment:
      - PUID=1000
      - PGID=1000

Nope.

Please also see this: https://github.com/jlesage/docker-nginx-proxy-manager/issues/271
I don't know what repo that is, but it does support docker --user params.
Personally I prefer to use this (original) one, but I do need to save data files as my own user.

There is a s6-applyuidgid directive to do this after init. The jslesage repo seems to be quite a behind, also would not recommend using another source for your reverse proxy.
Writing everything as root on the host can interfere with common backup strategies, RAID setups and remote monitoring. Would love to see this get picked up soon.

Yes me too; I don't want to use the jslesage repo either. So for me it's a must-have. Unfortunately I don't have the time nor skills to apply it in this repo. :(

Waiting for this too!

This is working for me: https://hub.docker.com/r/jc21/nginx-proxy-manager
    environment:
      PUID: $PUID
      PGID: $PGID

Sorry to re-open this thread but the issue has changed a bit...
Since the environment have been added, The PUID and PGID work fine for the 2.10.2 and 2.10.3 but it is not working with the latest 2.10.4.
Has it been removed?

Sorry to re-open this thread but the issue has changed a bit... Since the environment have been added, The PUID and PGID work fine for the 2.10.2 and 2.10.3 but it is not working with the latest 2.10.4.
Has it been removed?

Same issue

thank you @vdrover. I can confirm this is working fine on latest and solved the bunch of errors about file permission at startup under unraid.

Dear All,
this is my docker-compose.yml:
services:
  nginx-proxy-manager:
    image: 'jc21/nginx-proxy-manager:2.12.1'
    container_name: nginx-proxy-manager
    environment:
      PUID: 1000
      PGID: 1000
      TZ: Europe/Rome
    restart: unless-stopped
    ports:
      - 80:80
      - 81:81
      - 443:443
    volumes:
      - ./data:/data
      - ./letsencrypt:/etc/letsencrypt

and I get:
-------------------------------------
 _   _ ____  __  __
| \ | |  _ \|  \/  |
|  \| | |_) | |\/| |
| |\  |  __/| |  | |
|_| \_|_|   |_|  |_|
-------------------------------------
User:  npm PUID:1000 ID:1000 GROUP:1000
Group: npm PGID:1000 ID:1000
-------------------------------------

❯ Starting nginx ...
❯ Starting backend ...
nginx: [warn] the "user" directive makes sense only if the master process runs with super-user privileges, ignored in /etc/nginx/nginx.conf:4
[12/14/2024] [11:24:06 PM] [Global   ] › ℹ  info      Using Sqlite: /data/database.sqlite
[12/14/2024] [11:24:06 PM] [Global   ] › ℹ  info      Creating a new JWT key pair...
...

But folders get different UID and GID:
drwxr-xr-x 7<PHONE_NUMBER>99 4096 14 dic 23.24 data
drwxr-xr-x 2<PHONE_NUMBER>99 4096 14 dic 23.21 letsencrypt

can you tell me why, please?
Thank you so much!
Marco

Just a bit of a stab in the dark, but have you added your user to the docker group?
https://docs.docker.com/engine/install/linux-postinstall/

Just a bit of a stab in the dark, but have you added your user to the docker group?
https://docs.docker.com/engine/install/linux-postinstall/

Yes, I've added.

https://github.com/NginxProxyManager/nginx-proxy-manager/issues/3252
I report also this issue that is rely on my problem.
Any help about this @vdrover @jc21 ? Thank you so much!

Seems this issue where it does not respect the PGUID set and changes the folder ownership on boot is causing SSL acquisition to fail


[Support] Wireguard VPN appears to connect, but has no network access. Also can't re-install as OpenVPN

In raising this issue, I confirm the following:
{please fill the checkboxes, e.g: [X]}

[X] I have read the documentation
[X] I have read and understood the contributors guide.
[X] The issue I am reporting can be replicated.
[X] The issue I am reporting can be is directly related to the pivpn installer script.

Have you searched for similar issues and solutions?
([yes]/no / which issues?)

Has your install failed?
yes/[no]

Please provide your system information
What type of hardware are you running PiVPN at?

Raspberry Pi 3 Model B Rev 1.2

Output of uname -a
  Linux oro 5.15.32-v7+ #1539 SMP Fri Apr 1 11:38:09 BST 2022 armv7l GNU/Linux

Output of cat /etc/os-release
  PRETTY_NAME="Raspbian GNU/Linux 9 (stretch)"
NAME="Raspbian GNU/Linux"
VERSION_ID="9"
VERSION="9 (stretch)"
VERSION_CODENAME=stretch
ID=raspbian
ID_LIKE=debian
HOME_URL="http://www.raspbian.org/"
SUPPORT_URL="http://www.raspbian.org/RaspbianForums"
BUG_REPORT_URL="http://www.raspbian.org/RaspbianBugs"

If install failed Please provide the console output of  curl -L https://install.pivpn.io | bash
    % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100   162  100   162    0     0    231      0 --:--:-- --:--:-- --:--:--   231
100 82818  100 82818    0     0  78258      0  0:00:01  0:00:01 --:--:--  425k
:::
::: sudo will be used for the install.
::: Hostname length OK
::: Verifying free disk space...
:::
::: Package Cache update is needed, running apt-get update -y ...
 done!
:::
::: Checking apt-get for upgraded packages.... done!
:::
::: Your system is up to date! Continuing with PiVPN installation...
:::    Checking for git... already installed!
:::    Checking for tar... already installed!
:::    Checking for curl... already installed!
:::    Checking for grep... already installed!
:::    Checking for dnsutils... already installed!
:::    Checking for whiptail... already installed!
:::    Checking for net-tools... already installed!
:::    Checking for bsdmainutils... already installed!
:::    Checking for bash-completion... already installed!
:::    Checking for apt-transport-https... already installed!
:::    Checking for dhcpcd5... already installed!
:::    Checking for iptables-persistent... already installed!
Reading package lists... Done
Building dependency tree
Reading state information... Done
0 upgraded, 0 newly installed, 0 to remove and 0 not upgraded.
::: Using User: pi
:::
::: Checking for existing base files...
:::    Checking /usr/local/src/pivpn is a repo... not found!
:::    Cloning https://github.com/pivpn/pivpn.git into /usr/local/src/pivpn... done!
::: Using VPN: WireGuard
::: Installing WireGuard from Debian package...
:::    Checking for wireguard-tools... already installed!
:::    Checking for qrencode... already installed!
Reading package lists... Done
Building dependency tree
Reading state information... Done
0 upgraded, 0 newly installed, 0 to remove and 0 not upgraded.
  [i] Listening on all interfaces, permitting origins from one hop away (LAN)
  [✓] Restarting DNS server
::: Backing up the wireguard folder to /etc/wireguard_2022-04-23-121042.tar.gz
::: Server Keys have been generated.
::: Server config generated.
::: Install Complete...
::: Restarting services...
:::    Checking for unattended-upgrades... already installed!
Reading package lists... Done
Building dependency tree
Reading state information... Done
0 upgraded, 0 newly installed, 0 to remove and 0 not upgraded.
::: Setupfiles copied to /etc/pivpn/wireguard/setupVars.conf
::: Installing scripts to /opt/pivpn...
 done.
::: Flushing writes to disk...
::: done.
:::

Issue

I am having a couple of problems that may or may not be related. I initially tried to setup and install PiVPN as a WireGuard installation. I didn't have any issues until it came time to connect the clients to the VPN. The clients say that they connect, but do not have any internet access, and pivpn -c shows them as not having been connected to the server before.
I wondered if maybe there was an issue with Wireguard, so I tried re-installing PiVPN as an OpenVPN server. However, whenever I try re-running the installation script, it skips the step where it asked me whether I want to set up Wireguard or OpenVPN, and skips straight to configuring it as a Wireguard server.
I tried uninstalling and reinstalling PiVPN a few times, have done an installation repair, tried re-installing with the same settings and with new settings. I'm assuming there's some configuration file or environment variable that's not getting cleared on uninstallation that tells it to setup as Wireguard. I think I need support in either getting Wireguard working or re-installing PiVPN as OpenVPN.
Console output of      curl -L install.pivpn.io | bash
    % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100    17  100    17    0     0     45      0 --:--:-- --:--:-- --:--:--    45
100   162  100   162    0     0    172      0 --:--:-- --:--:-- --:--:-- 40500
100 82818  100 82818    0     0  67871      0  0:00:01  0:00:01 --:--:-- 67871
:::
::: sudo will be used for the install.
::: Repair option selected.
::: Hostname length OK
::: Verifying free disk space...
:::
::: Package Cache update is needed, running apt-get update -y ...
 done!
:::
::: Checking apt-get for upgraded packages.... done!
:::
::: Your system is up to date! Continuing with PiVPN installation...
:::    Checking for git... already installed!
:::    Checking for tar... already installed!
:::    Checking for curl... already installed!
:::    Checking for grep... already installed!
:::    Checking for dnsutils... already installed!
:::    Checking for whiptail... already installed!
:::    Checking for net-tools... already installed!
:::    Checking for bsdmainutils... already installed!
:::    Checking for bash-completion... already installed!
:::    Checking for apt-transport-https... already installed!
:::    Checking for dhcpcd5... already installed!
:::    Checking for iptables-persistent... already installed!
Reading package lists... Done
Building dependency tree
Reading state information... Done
0 upgraded, 0 newly installed, 0 to remove and 0 not upgraded.
::: PiVPN Automated Installer
::: This installer will transform your Raspbian host into an OpenVPN or WireGuard server!
::: Initiating network interface
::: Using interface: eth0
::: Skipping setting static IP address
::: pi will hold your ovpn configurations.
:::
::: Checking for existing base files...
:::    Checking /usr/local/src/pivpn is a repo... OK!
::: Repairing an existing installation, not downloading/updating local repos
::: WireGuard will be installed
::: Installing WireGuard from Debian package...
:::    Checking for wireguard-tools... already installed!
:::    Checking for qrencode... already installed!
Reading package lists... Done
Building dependency tree
Reading state information... Done
0 upgraded, 0 newly installed, 0 to remove and 0 not upgraded.
::: Using port 51820
::: Using DNS <IP_ADDRESS>
::: Using public IP <IP_ADDRESS>
::: Backing up the wireguard folder to /etc/wireguard_2022-04-23-121437.tar.gz
::: The Server Keys will now be generated.
::: Server Keys have been generated.
::: Server config generated.
::: Install Complete...
::: Restarting services...
::: Enabling unattended upgrades
:::    Checking for unattended-upgrades... already installed!
Reading package lists... Done
Building dependency tree
Reading state information... Done
0 upgraded, 0 newly installed, 0 to remove and 0 not upgraded.
::: Setupfiles copied to /etc/pivpn/wireguard/setupVars.conf
::: Installing scripts to /opt/pivpn...
 done.
::: Flushing writes to disk...
::: done.
::: Installation Complete!
::: Now run 'pivpn add' to create the client profiles.
::: Run 'pivpn help' to see what else you can do!

::: If you run into any issue, please read all our documentation carefully.
::: All incomplete posts or bug reports will be ignored or deleted.

::: Thank you for using PiVPN.
::: It is strongly recommended you reboot after installation.
:::

Console output of      pivpn add or pivpn add nopass
  Enter a Name for the Client: macbook-air
::: Client Keys generated
::: Client config generated
::: Updated server config
::: Updated hosts file for Pi-hole
::: WireGuard reloaded
======================================================================
::: Done! macbook-air.conf successfully created!
::: macbook-air.conf was copied to /home/pi/configs for easy transfer.
::: Please use this profile only on one device and create additional
::: profiles for other devices. You can also use pivpn -qr
::: to generate a QR Code you can scan with the mobile app.
======================================================================

Console output of      pivpn debug

  ::: Generating Debug Output
::::		PiVPN debug		 ::::
=============================================
::::		Latest commit		 ::::
Branch: master
Commit: f80b0a7962d91862132c0a4abd65c1e67bd37bd7
Author: 4s3ti
Date: Fri Dec 3 21:41:13 2021 +0100
Summary: Update Changelog
=============================================
::::	    Installation settings    	 ::::
PLAT=Raspbian
OSCN=stretch
USING_UFW=0
IPv4dev=eth0
dhcpReserv=1
IPv4addr=<IP_ADDRESS>/24
IPv4gw=<IP_ADDRESS>
install_user=pi
install_home=/home/pi
VPN=wireguard
pivpnPORT=51820
pivpnDNS1=<IP_ADDRESS>
pivpnDNS2=
pivpnHOST=REDACTED
INPUT_CHAIN_EDITED=0
FORWARD_CHAIN_EDITED=0
pivpnPROTO=udp
pivpnMTU=1420
pivpnDEV=wg0
pivpnNET=<IP_ADDRESS>
subnetClass=24
ALLOWED_IPS="<IP_ADDRESS>/0, ::0/0"
UNATTUPG=1
INSTALLED_PACKAGES=()
=============================================
::::  Server configuration shown below   ::::
[Interface]
PrivateKey = server_priv
Address = <IP_ADDRESS>/24
MTU = 1420
ListenPort = 51820
### begin macbook-air ###
[Peer]
PublicKey = macbook-air_pub
PresharedKey = macbook-air_psk
AllowedIPs = <IP_ADDRESS>/32
### end macbook-air ###
=============================================
::::  Client configuration shown below   ::::
[Interface]
PrivateKey = macbook-air_priv
Address = <IP_ADDRESS>/24
DNS = <IP_ADDRESS>

[Peer]
PublicKey = server_pub
PresharedKey = macbook-air_psk
Endpoint = REDACTED:51820
AllowedIPs = <IP_ADDRESS>/0, ::0/0
=============================================
:::: 	Recursive list of files in	 ::::
::::	[4m/etc/wireguard shown below	 ::::
/etc/wireguard:
configs
keys
wg0.conf

/etc/wireguard/configs:
clients.txt
macbook-air.conf

/etc/wireguard/keys:
macbook-air_priv
macbook-air_psk
macbook-air_pub
server_priv
server_pub
=============================================
::::		Self check		 ::::
:: [OK] IP forwarding is enabled
:: [OK] Iptables MASQUERADE rule set
:: [OK] WireGuard is running
:: [OK] WireGuard is enabled (it will automatically start on reboot)
:: [OK] WireGuard is listening on port 51820/udp
=============================================
:::: Having trouble connecting? Take a look at the FAQ:
:::: https://docs.pivpn.io/faq
=============================================
:::: WARNING: This script should have automatically masked sensitive       ::::
:::: information, however, still make sure that PrivateKey, PublicKey      ::::
:::: and PresharedKey are masked before reporting an issue. An example key ::::
:::: that you should NOT see in this log looks like this:                  ::::
:::: YIAoJVsdIeyvXfGGDDadHh6AxsMRymZTnnzZoAb9cxRe                          ::::
=============================================
::::		Debug complete		 ::::
:::
::: Debug output completed above.
::: Copy saved to /tmp/debug.log
:::

Have you taken any steps towards solving your issue?
  I tried uninstalling and reinstalling PiVPN a few times, have done an installation repair, tried re-installing with the same settings and with new settings.

I followed the Troubleshooting FAQ. I had issues installing tcpdump while following it:

Reading package lists... Done
Building dependency tree
Reading state information... Done
Package tcpdump is not available, but is referred to by another package.
This may mean that the package is missing, has been obsoleted, or
is only available from another source

E: Package 'tcpdump' has no installation candidate

This is what I meant by "appears to connect":

However, any attempts to ping or navigate to an internet resource just hangs. This is the output of pivpn -c when my laptop says it's connected.
Name             Remote IP      Virtual IP      Bytes Received      Bytes Sent      Last Seen
macbook-air      (none)         <IP_ADDRESS>        0B                  0B              (not yet)
::: Disabled clients :::```

Debug log looks fine.

This is what I meant by "appears to connect":

That's how wireguard works: it doesn't "connect", you just activate the interface. You can infer that it's working by looking at data sent and received. In your case some data is sent but you receive none.
Have you forwarded the port 51820 udp?

I followed the Troubleshooting FAQ. I had issues installing tcpdump while following it.

I'm not running stretch at the moment so I can't check why it's not available, perhaps you can post the output of apt-cache show tcpdump and apt-cache policy to learn more?

That's how wireguard works: it doesn't "connect", you just activate the interface. You can infer that it's working by looking at data sent and received. In your case some data is sent but you receive none.
Have you forwarded the port 51820 udp?

Ah, I see. Yes, I've tried both forwarding the port individually and forwarding all ports to the raspberry pi. I've been running PiHole and nginx on this device for a long time, and am able to confirm that the IP address assigned by the router to the pi is static and that HTTP, SSH, and SFTP ports are forwarded correctly as I can connect to them over a tethered connection.

apt-cache show tcpdump:

Version: 4.99.0-2
Architecture: armhf
Maintainer: Romain Francoise<EMAIL_ADDRESS>Installed-Size: 962
Depends: adduser, libc6 (>= 2.11), libpcap0.8 (>= 1.9.0), libssl1.1 (>= 1.1.0)
Suggests: apparmor (>= 2.3)
Breaks: apparmor-profiles-extra (<< 1.12~)
Replaces: apparmor-profiles-extra (<< 1.12~)
Multi-Arch: foreign
Homepage: https://www.tcpdump.org/
Priority: optional
Section: net
Filename: pool/main/t/tcpdump/tcpdump_4.99.0-2_armhf.deb
Size: 375908
SHA256: 56f04a408b1822d50b4c0a0f23e128d0551e9b94ee80cf9e13452c2a5591f7a0
SHA1: 26cbbe2ae91b17bdc6cff8054535af73160ed3f1
MD5sum: 8b8feec766e1f7610e067096b7689a29
Description: command-line network traffic analyzer
 This program allows you to dump the traffic on a network. tcpdump
 is able to examine IPv4, ICMPv4, IPv6, ICMPv6, UDP, TCP, SNMP, AFS
 BGP, RIP, PIM, DVMRP, IGMP, SMB, OSPF, NFS and many other packet
 types.
 .
 It can be used to print out the headers of packets on a network
 interface, filter packets that match a certain expression. You can
 use this tool to track down network problems, to detect attacks
 or to monitor network activities.
Description-md5: f01841bfda357d116d7ff7b7a47e8782

apt-cache policy:

Package files:
 100 /var/lib/dpkg/status
     release a=now
  -1 http://raspbian.raspberrypi.org/raspbian bullseye/rpi armhf Packages
     release o=Raspbian,a=stable,n=bullseye,l=Raspbian,c=rpi,b=armhf
     origin raspbian.raspberrypi.org
  -1 http://raspbian.raspberrypi.org/raspbian bullseye/non-free armhf Packages
     release o=Raspbian,a=stable,n=bullseye,l=Raspbian,c=non-free,b=armhf
     origin raspbian.raspberrypi.org
  -1 http://raspbian.raspberrypi.org/raspbian bullseye/contrib armhf Packages
     release o=Raspbian,a=stable,n=bullseye,l=Raspbian,c=contrib,b=armhf
     origin raspbian.raspberrypi.org
  -1 http://raspbian.raspberrypi.org/raspbian bullseye/main armhf Packages
     release o=Raspbian,a=stable,n=bullseye,l=Raspbian,c=main,b=armhf
     origin raspbian.raspberrypi.org
Pinned packages:
     wireguard-dkms -> 1.0.20210219-1 with priority 100
     wireguard-tools -> 1.0.20210223-1 with priority 100
     wireguard -> 1.0.20210223-1 with priority 100

I'm not running stretch at the moment so I can't check why it's not available

I also tried updating from stretch to bullseye to see if maybe there was some incompatibility on wireguard with stretch. I'm not sure that the update worked. I didn't get any error messages, but cat /etc/os-release says "stretch" while uname -a says "5.15.32-v7+" which correlates with bullseye.

I also tried updating from stretch to bullseye to see if maybe there was some incompatibility on wireguard with stretch.

Upgrade stretch -> bullseye without reinstall? I think it's not supported.
Judging from the apt-cache policy I believe the pivpn installer accidentally blocked the Raspberry Pi from installing any package. Do you have the files /etc/apt/sources.list.d/pivpn-bullseye-repo.list and /etc/apt/preferences.d/pivpn-limit-bullseye? What's the content of /etc/apt/sources.list?

Judging from the apt-cache policy I believe the pivpn installer accidentally blocked the Raspberry Pi from installing any package. Do you have the files /etc/apt/sources.list.d/pivpn-bullseye-repo.list and /etc/apt/preferences.d/pivpn-limit-bullseye? What's the content of /etc/apt/sources.list?

Yes, I should note I backed up and removed the files in /etc/apt/sources.list.d/pivpn-bullseye-repo.list. While attempting to either fix or re-install PiVPN. Here is the ls:
ls /etc/apt/sources.list.d/
pivpn-bullseye-repo.list.bak  raspi.list.bak

cat /etc/apt/preferences.d/pivpn-limit-bullseye:
Package: *
Pin: release n=bullseye
Pin-Priority: -1

Package: wireguard wireguard-dkms wireguard-tools
Pin: release n=bullseye
Pin-Priority: 100

cat /etc/apt/sources.list
deb http://raspbian.raspberrypi.org/raspbian/ bullseye main contrib non-free rpi
# Uncomment line below then 'apt-get update' to enable 'apt-get source'
#deb-src http://raspbian.raspberrypi.org/raspbian/ stretch main contrib non-free rpi

Yes, I should note I backed up and removed the files

Correct, remove /etc/apt/preferences.d/pivpn-limit-bullseye too. apt-cache policy will show priority 500 instead of -1 and you should be able to install tcpdump or other packages. /etc/os-release showing stretch might still be a problem (in general).

Sorry, I forgot to update but after the latest suggestion and re-installing pivpn, I got everything working. Feel free to close this issue, unless the problem where my installation got "stuck" in wireguard mode might affect more people. Thanks for your help!


Immigrate to Support Libraries.

Please use support libraries as Fragment is now deprecated.

Duplicate of #451


Make i18n translator resolver full generic

Make a few types more specific especially Scopes. Now we get proper types for available scopes and added support for nested scopes such as for example app.test

There are too many changes to the scope/chained/proxy functionality. Please just limit it to adding the generic for parameters when necessary.

I know, that's because of the now nicely working scope api. To get all the types right was really a challange and involved hours of hard work, so please can we also merge this 👉👈

@BierDav  can you fix this as well? :)

Everything seems to be working as before. on solid-site too.
I added a little test for the generic resolver types.
Could you add tests for the improved functionality of scopes?

Sorry oversaw the pr. I've added a test that should ensure that nested translation works, the other part with the types could also be checked by typechecking the test files, don't know if that is already done or not.

Is there anything else needed for this feature? The templates are pretty limited as of now, compared to some other i18n libraries where you can e.g. pluralization in the templates, like: no apples | one apple | {count} apples (vue i18n)

This is not supported out of the box, but you can implement your own resolver which would allow you to support that syntax

@thetarnav is this ready to merge?


Lazier license checks

Description of changes
This makes certain top-level attributes evaluate by deferring license checks into drvPath/outPath using lib.extendDerivation:

androidsdk_9_0
gams
neoload
sc2-headless

Things done

[x] Checked that each attribute evaluates with nix-instantiate --eval -A <attr>, but fails with nix-instantiate -A <attr> (since this evaluates the outPath)

Add a :+1: reaction to pull requests you find important.

There really ought to be a consistent pattern for how to require licenses.


The link to knit output path not easy to open

Knitting any rmd document will result in showing a link to the file surrounded by vsc delim ---vsc---, making the link not easy to open.

Output created: _book/test.html

---vsc---/Users/ken/Workspaces/test/rbook/_book/test.html---vsc---
[VSC-R] main.Rmd process exited with exit code 0

Follow link will try to open the incorrect path:
/Users/ken/Workspaces/test/rbook/_book/test.html---vsc---

A related issue is where the output ends up as:
---vsc---
/Users/ken/Workspaces/test/rbook/_book/test.html
---vsc---

causing the progress bar to never close. Might need to rethink how to display this for both cases.


Editor Context Menu will do the actions on mouse up evnet

VSCode Version: 1.39.0
OS Version: ubuntu 14.04 LTS

Steps to Reproduce:
1.Mouse  right button press down pop out the menu.
2.Do not move the mouse, and hold a short time.
3.Releasing the right button, if there is a item be selected, it will do the selected item actions.

Does this issue occur when all extensions are disabled?: Yes

Holding the mouse button down is trying to explain the problem.
In fact, I was selected the code and trying to copy it, but as clicking the mouse it do the paste.
That was feeling bad.

@sbatten

@rhdlilj can you check your setting for window.titleBarStyle

@sbatten "window.titleBarStyle": "custom"
I try "native", it's find, no this issue.


Stoped sending message in chat if irc is not connected but irc mode i…

…s on

oh yeah i forgot to push the change , i sent the fixed version for red but i didnt upload it here


Thank you

Hi there
Are you still working on this?
Regards
Balint

Hi! Yes, sure, I'm going to continue to work on this.

@nkurylenko
I am not sure on what OS are you working on; but if you would like some help to test it under Windows i can provide it.

I am working on Windows. Thank you! I appreciate that.


Chore/node upgrade

closes #165

There's something wrong with the little green dot that should be like this screenshot from prod.

On the new version, it looks like this:

the svg images have a width and height of 0.
To investigate: next.js release notes for 13 and the image handling


The "manage roles" for a user does not work.

Describe the bug
When i click the manage user roles, it returns a http 500 error saying that localhost cannot handle the request.
To Reproduce
Steps to reproduce the behavior:

Login as superadmin, go to admin settings and click on users.
Click on "Action", then click on "manage roles"
and wait for the page to open.
See error

Expected behavior
The page should display the content of the roles.
Screenshots
If applicable, add screenshots to help explain your problem.
Desktop (please complete the following information):

OS: [e.g. iOS]
Browser [e.g. chrome, safari]
Version [e.g. 22]

Smartphone (please complete the following information):

Device: [e.g. iPhone6]
OS: [e.g. iOS8.1]
Browser [e.g. stock browser, safari]
Version [e.g. 22]

Additional context
Add any other context about the problem here.

i just tried to reproduce this error and i can not reproduce it.
i'm logged in as Super Admin
i click on Super Admin -> Settings -> then in the NavPanel to the left i click on Admin Settings, then Users. Then i see Basic User -> Action -> Manage Roles -> the View opens. I also gave the Basic User the Moderator Role -> Save -> saved without an issue.
i believe this Issue can be closed.


[Event Request] Table 246 "Requisition Line" - procedure CalcStartingDate - OnCalcStartingDateOnBeforeValidateOrderDate

Please add an Event OnCalcStartingDateOnBeforeValidateOrderDate in procedure CalcStartingDate in Table 246 "Requisition Line"
procedure CalcStartingDate(LeadTime: Code[20])
var
IsHandled: Boolean; <-- NEW VAR
    begin
        OnBeforeCalcStartingDate(Rec, LeadTime);

        case "Ref. Order Type" of
            "Ref. Order Type"::Purchase:
                if LeadTime = '' then
                    LeadTime :=
                      LeadTimeMgt.PurchaseLeadTime(
                        "No.", "Location Code", "Variant Code", "Vendor No.");
            "Ref. Order Type"::"Prod. Order",
            "Ref. Order Type"::Assembly:
                begin
                    if RoutingLineExists then
                        exit;

                    if LeadTime = '' then
                        LeadTime := LeadTimeMgt.ManufacturingLeadTime("No.", "Location Code", "Variant Code");
                end;
            "Ref. Order Type"::" ":
                exit;
        end;

        "Starting Date" :=
          LeadTimeMgt.PlannedStartingDate(
            "No.", "Location Code", "Variant Code", "Vendor No.", LeadTime, "Ref. Order Type", "Ending Date");

        IsHandled := false;
        OnCalcStartingDateOnBeforeValidateOrderDate(Rec,LeadTime,IsHandled); <-- NEW EVENT
        If not IsHandled then
            Validate("Order Date", "Starting Date");

        if "Ref. Order Type" = "Ref. Order Type"::Transfer then
            CalcTransferShipmentDate;
    end;

    [IntegrationEvent(false, false)]
    local procedure OnCalcStartingDateOnBeforeValidateOrderDate(var Rec: Record "Requisition Line"; var LeadTime: Code[20]; var IsHandled: Boolean)
    begin
    end;

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.
Build ID: 44362.


Sanity check for QuicServerCodecBuilder options

A few days back I accidentally caused it to crash and burn with a rust panic -- but I couldn't repro it with the maven SNAPSHOT. However while playing around with the options trying to remember what I did the other day that broke it (it was a null pointer), I found a different one by setting initialMaxStreamsBidirectional to -1. Trying to initChannel like that resulted in the following:
thread '<unnamed>' panicked at 'internal error: entered unreachable code', src/octets.rs:656:9
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
fatal runtime error: failed to initiate panic, error 5
Subprocess failed (exit code: 134)

No java stacktrace, and the jvm exited too.
Of course this isn't something one'd do accidentally. Should I put up a pr to add some more option validations?

Yes a PR would be awesome to check for negative values etc

@valerauko I had a few minutes... Check https://github.com/netty/netty-incubator-codec-quic/pull/79

Awesome, thanks! Sorry I wasn't able to put up a fix quicker...

Don't worry ... most important was that you made me aware of it


Migrate 3.0.0 to EtixLabs/cameradar-app

[x] Migrate issues
[x] Migrate labels
[x] Migrate milestone
[x] Migrate board
[x] Migrate code

Fixed in https://github.com/EtixLabs/cameradar/pull/134


Stronghold Crusader Extreme UnofficialPatch too

I've installed it the latest patch for crusader from this page, but i realize there only works for the normal Crusader and not for the Extreme version. It would be awesome if the patch had the compatibility to this version too, like the bugs fixes, improvements, change color, etc. Thanks you guys!

The patcher will also edit Extreme now in the upcoming version 2.10.


Remove isort + fix pyproject to sort

There's some ambiguity with graphlib, as it moved from external to internal in 3.11, but Ruff doesn't support the isort py_version argument. Broadly I think this is actually okay, I'm not fussed with it's placement, as long as it's not inconsistently moved.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

:exclamation: No coverage uploaded for pull request base (main@36006cb). Click here to learn what that means.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #211   +/-   ##
=======================================
  Coverage        ?   90.65%
=======================================
  Files           ?        4
  Lines           ?      428
  Branches        ?        0
=======================================
  Hits            ?      388
  Misses          ?       40
  Partials        ?        0

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Looks good, but linting is failing at the mo, not sure if just a glitch or if something is inconsistent between local and CI environment?


Data preparation

Please tell how to generate spectrograms and set segmentation parameters.

allthe parameters you are interested in are in the generateSpectrograms.py file. To run the file and generate the actual spectrograms run like :
python generateSpectrograms.py <path_to_data> <path_to_data_for_augmentation>
if no augmentation is needed just add "" as a second attribute

What about post processing? How did you convert npy output to RGB image?


chore: move cache to global dir

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

#384  👈
#383
#382
#381
#379
#378
#377
#376
#375
#349
#374
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @NathanFlurry and the rest of your teammates on  Graphite


Changed yarn test-prod to yarn test --prod in contributing guide

Minor update to the contributing guide. yarn test-prod is deprecated and displays and error message to use yarn test --prod instead. This is true at least as far back as yarn 1.10 (sorry couldn't figure out how to install yarn versions earlier than that one).
🏠 > yarn test-prod
yarn run v1.10.1
$ yarn test --deprecated 'yarn test --prod'
$ node ./scripts/jest/jest-cli.js --deprecated 'yarn test --prod'

Please run: `yarn test --prod` instead.

✨  Done in 1.74s.

@dwesty17 Thanks!

@dwesty17 Thanks!

No problem! Thanks for the quick review @eps1lon 🙏

No problem! Thanks for the quick review @eps1lon 🙏


wilcoxon() rejection direction is unclear for one-sided test

<<Please describe the issue in detail here, and for bug reports fill in the fields below.>>
As mentioned here by @abhinavkgp :

... it is still not possible to determine one-sided result (whether x-y>0 or y-x>0) using this two-sided statistic, due to the following:
Code:
T = min(r_plus, r_minus)
r_plus = np.sum((d > 0) * r, axis=0) #Always positive
r_minus = np.sum((d < 0) * r, axis=0) #Always positive
Reasoning:
So, if you swap x and y, T will still be the same, z statistics will still be the same
Final Thoughts:
We should also aim to return in some way that whether r_plus was used or r_minus was used (through a flag maybe) in order to know the result of a one-sided tailed test

Reproducing code example:
A = [10,10,10,10,15,11]
B = [30,30,30,30,31,32]

wilcoxon(A, B) == wilcoxon(B,A)

Scipy/Numpy/Python version information:
1.0.1 1.14.3 sys.version_info(major=3, minor=6, micro=5, releaselevel='final', serial=0)

The test only returns the two-sided p-value, so the order of x and y does not matter. I don't think there is a bug.
Is this a feature request to have a one-sided test?

Once could transform the p-value directly into a one-sided p-value by diving by 2. So, yes, it is either a feature request or a request for providing a flag for rejection direction in case of a one-sided test.


Updating the Folder Structure

Pull Request Description
Summary:
This PR reorganizes the folder structure to enhance clarity and consistency across all repositories. The following changes have been made:

Renamed and Reorganized Folders:

01_slides is now 01_materials containing slides.
02_assignments and 03_homeworks are now inside of 02_activities as assignments and homework.
06_instructional_team is now 03_instructional_team.
07_cohort_three is now 04_cohort_three.
05_sql and 04_data are now inside of 05_src as sql and data

Updated Descriptions to the below template

New Folder Structure:
.
├── .github
├── 01_materials
│   ├── slides
│   └── labs
├── 02_activities
│   ├── assignments
│   ├── exercises
│   └── homework
├── 03_instructional_team
├── 04_cohort_three
├── 05_src
│   ├── sql
│   ├── logs
│   ├── data
│   └── requirements.txt
├── .gitignore
├── LICENSE
├── README.md
└── steps_to_ask_for_help.png

Details:

.github: Contains issue templates and pull request templates for the repository.
materials: Module slides and interactive notebooks (.ipynb files) used during learning sessions.
activities: Contains graded assignments, exercises, and homework to practice concepts covered in the learning module.
instructional_team: Resources for the instructional team.
cohort_three: Additional materials and resources for cohort three.
src: Source code, databases, logs, and required dependencies (requirements.txt) needed during the module.
.gitignore: Files to exclude from this folder, specified by the Technical Facilitator
LICENSE: The license for this repository.
README: This file.
steps_to_ask_for_help.png: Guide on how to ask for help.

Please review the changes and provide feedback. Thank you!
Checklist

[X] I can confirm that my changes are working as intended

@danielrazavi , broadly these changes are fine, but let me remind you that every time links change, I have to update tons of supplement materials to reference them -- it's a lot of labour wasted if we're doing it every cohort

@mrpotatocode I'm making sure every single one of these links work and making sure that you are not bothered by them. These changes are not something we are expecting to happen every cohort, they are simply some lessons learned from cohort 2.

There are non-GH supplementals -- like the Etherpad for example

If the changes are needed on the Etherpad side, then you're right, it will create some manual work. That being said, as previously mentioned, this is most likely the last great change on our repos. On the Github, side we will make sure to update all links and addresses so that they are functional. We're sorry for the inconvenience.

All good. More of a reminder/request to keep big restructures to a minimum, which I think we've done well at, but I'm not sure what we'll end up doing with like a cohort 4 folder, etc. Just little questions to figure out :)
Hope you're enjoying summer!

We'll make sure to create the necessary actions for the cohort 3 folder. As of right now, two solutions come to mind: one, we simply add a cohort 4 folder and ask TF to populate it accordingly, setting a precedent for following cohorts to do the same; or two, we rename the cohort 3 folder to "extras" and allow TFs to have full control of the folder, establishing this as the new precedent.

For now, we will merge the changes to match other repos.


Recursive SARIF file detection from upload-sarif sarif_file parameter

I created a workflow that runs Clang scan-build with the -sarif parameter, to output SARIF format, and the -o build/sarif argument to put the output in the directory build/sarif.
When it is run, scan-build puts the actual SARIF files in a sub-directory of the specified output directory.
The output from scan-build is:
scan-build: Analysis run complete.
scan-build: Analysis results (sarif files) deposited in '/home/runner/work/libcyaml/libcyaml/build/sarif/2020-09-18-110804-4323-1'

And the sarif files are in the randomly named sub-directory:
$ find build/sarif
build/sarif
build/sarif/2020-09-18-110804-4323-1
build/sarif/2020-09-18-110804-4323-1/report-B4xj3N.sarif
build/sarif/2020-09-18-110804-4323-1/report-yK7dxl.sarif
build/sarif/2020-09-18-110804-4323-1/report-SrmlCl.sarif
build/sarif/2020-09-18-110804-4323-1/report-QPrVcF.sarif
build/sarif/2020-09-18-110804-4323-1/report-67tbyT.sarif
build/sarif/2020-09-18-110804-4323-1/report-OfHm5E.sarif
build/sarif/2020-09-18-110804-4323-1/report-T8GZn7.sarif
build/sarif/2020-09-18-110804-4323-1/report-NKjLYw.sarif
build/sarif/2020-09-18-110804-4323-1/report-z81jQ7.sarif
build/sarif/2020-09-18-110804-4323-1/report-bmXRUK.sarif
build/sarif/2020-09-18-110804-4323-1/report-6aH1dl.sarif
build/sarif/2020-09-18-110804-4323-1/report-iK7eHK.sarif
build/sarif/2020-09-18-110804-4323-1/report-vnqcCF.sarif
build/sarif/2020-09-18-110804-4323-1/report-aATCA3.sarif

You can see the CI run for this here: https://github.com/tlsa/libcyaml/runs/1133489433
At the moment, with
    - name: upload scan-build
      uses: github/codeql-action/upload-sarif@v1
      with:
        sarif_file: build/sarif

I get the following error:
#[error]No SARIF files found to upload in "build/sarif".
Error: No SARIF files found to upload in "build/sarif".
    at Object.upload (/home/runner/work/_actions/github/codeql-action/v1/lib/upload-lib.js:114:19)
    at run (/home/runner/work/_actions/github/codeql-action/v1/lib/upload-sarif-action.js:29:46)

Could the sarif_file directory parameter be changed to a recursive search through the directory for SARIF files?

This sounds like a reasonable change to me. Shouldn't have any unintended side-effects as I highly doubt anyone is currently relying on the behaviour is specifically not being recursive.

Yeah, I hoped that would be the case!

Please allow me to share more use cases specifically for Java projects. With a multi-module Gradle project, static analysis tools like Checkstyle and Detekt can generate one or more reports per module. Therefore recursively walking through the directory is fairly common, at least for all gradle projects. I hope this issue can be addressed soon.
I did some quick search and it looks like the change is within this function upload-lib.js (https://github.com/github/codeql-action/blob/main/lib/upload-lib.js#L69). My Javascript skill is a bit rusty, but I can give it a try if this issue left unattended for a long time.

@chao2zhang Thanks for implementing this!  Confirmed it works with my original clang scan-build output use case.

Did this make it work for you?
I'm always getting
  Error: Code Scanning could not process the submitted SARIF file:
  rejecting SARIF, as there are more runs than allowed (147 > 15)
  Error: Code Scanning could not process the submitted SARIF file:
  rejecting SARIF, as there are more runs than allowed (147 > 15)
      at Object.waitForProcessing (/home/runner/work/_actions/github/codeql-action/v2/lib/upload-lib.js:337:19)
      at async run (/home/runner/work/_actions/github/codeql-action/v2/lib/upload-sarif-action.js:56:13)

@Trass3r, please raise a new issue for this. You are seeing a different problem than was originally reported. Your workflow is producing too many sarif runs. You will need to upload them in batches of 15 or less and use a different (but consistent) category name for each upload.
More information about categories.

@Trass3r Yes, something changed and the server now rejects the SARIF output generated by Clang scan-build.

scan-build simply produces 1 sarif file per source file.
Even though most are empty 15 is still a pretty low limit.
It can be mitigated a bit via
npx -y @microsoft/sarif-multitool merge csa/*/*.sarif

But I can't say yet whether that really fixes the problem.


release: uefi-raw-0.5.0, uefi-macros-0.13.0, uefi-0.26.0, uefi-services-0.23.0

Once this is merged we see what breaks :)

Checklist

[ ] Sensible git history (for example, squash "typo" or "fix" commits). See the Rewriting History guide for help.
[ ] Update the changelog (if necessary)

Well, to my astonishment it seems to have worked: https://github.com/rust-osdev/uefi-rs/actions/runs/6843032467/job/18605174163

https://crates.io/crates/uefi-raw/0.5.0
https://crates.io/crates/uefi-macros/0.13.0
https://crates.io/crates/uefi/0.26.0
https://crates.io/crates/uefi-services/0.23.0


Toggling off Awake does not stop Awake

Microsoft PowerToys version
0.51.1
Running as admin

[X] Yes

Area(s) with issue?
Awake
Steps to reproduce

I toggle Awake on to keep my system awake so that my screens do not shutoff after a few minutes of inactivity.

The only way to get out of this mode is to exit PowerToys. Then I can re-launch PowerToys with Awake toggled off and the screens will then shutoff as expected when I lock the computer with Win-L.
Other Software
No response

cc @dend

There is a known bug that awake isn't closed/killed correctly.

Has this been fixed?
I updated to PowerToys 0.53.1 prior to 1/7/2022. This did not fix the issue.
I had to reboot my machine due to Windows updates on 1/8/2022.
Before the reboot, I had Awake toggled off in PowerToys.
After the reboot, Awake was toggled ON in PowerToys.
I opened Task Manager and found the PowerToys.Awake process in the Details tab.
I then toggled Awake off in PowerToys. I observed that the PowerToys.Awake process went away.
I locked my screen and after a few minutes, my screens shutoff.
So, this seems to be working for me at the moment. Was that expected?

@nextstate - following-up on this issue, I can't reproduce the behavior, and it seems like Awake acts correctly. How were you toggling Awake - through Settings or the tray? Also, what is the OS version you're running?

@dend As I mentioned in a previous comment, it started working for me. I mentioned that it started working after a Windows update. In my comment I was asking if this was fixed. Maybe something in the Windows updated fixed it?

Still an issue on Win 11 x64 clean, not domain-joined.
Power mode is and always was : Balanced
I'm wondering if there isn't a global issues with the toggle buttons inside Powertoys.
For example, toggeling "Keep screen on" in the PowerToys Settings / Awake UX doesn't seem to trigger the "tick" on the task bar. Same thing with the task bar buttons, doesn't update what's in the main UX even when changing panel (going onto another page and going back to "Awake", it doesn't update the toggles).

@zotabee can you please confirm if the issue is still there with the latest release of Awake?

@dend It seems the UI is correctly triggering the settings and it updates the taskbar awake UI ticks.
But the reverse, changing settings from the taskbar doesn't seem to impact UI toggles...
Any news in the changelog that would suggest it has been fixed in the meantime?

That is currently by design, but I would say that it's something that needs to change. Let me see if I can push this through in #24183.

Consolidating the conversation on this in #12126.