Add FindByModels method to RssEntryRepository and implement related t…

…ests

Pull Request Test Coverage Report for Build<PHONE_NUMBER>4
Details

6 of 6 (100.0%)  changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.5%) to 82.738%

Totals

Change from base Build<PHONE_NUMBER>0:
0.5%

Covered Lines:
139

Relevant Lines:
168

💛  - Coveralls


Venafi issuer setup: verify access token

Fixes #5154
This is the first PR that fixes the immediate problem: a Venafi Issuer does not verify its access token.
This PR changes the Venafi Issuer to remotely verify its access token with a TPP server during setup. An invalid (expired, malformed) access token will result in the Issuer setting Ready=False.
A follow-up PR will add functionality to periodically verify the token, to handle token expiration or revocation.
Follow-up issue here: https://github.com/cert-manager/cert-manager/issues/5201
Kind
bug

Release Note

Fixed a bug where the Venafi Issuer would not verify its access token before becoming ready. Venafi Issuers will now remotely verify the access token via the TPP API. (#5154, @jahrlin)

/test all

/test all

/test all

/test pull-cert-manager-e2e-v1-23

/test pull-cert-manager-issuers-venafi-tpp

/test pull-cert-manager-issuers-venafi-tpp

/test pull-cert-manager-issuers-venafi-tpp

/test all

/test pull-cert-manager-e2e-v1-23

/test pull-cert-manager-e2e-v1-23

/test pull-cert-manager-e2e-v1-24

/test pull-cert-manager-e2e-issuers-venafi-cloud
/test pull-cert-manager-issuers-venafi-tpp

/test pull-cert-manager-e2e-issuers-venafi-cloud
/test pull-cert-manager-issuers-venafi-tpp

/test pull-cert-manager-issuers-venafi-tpp

/test pull-cert-manager-e2e-issuers-venafi-cloud
/test pull-cert-manager-issuers-venafi-tpp

/test pull-cert-manager-e2e-v1-24
/test pull-cert-manager-issuers-venafi-tpp

I have added a couple comments. I'm a little uneasy with adding TPP-specific code at the top to be run for both VaaS and TPP issuers. I think ideally we should have some generic functionality that check auth for Venafi issuer and runs the TPP-specific bits in TPP-specific blocks so we don't have to expose TPP-specific fields at top level. I also think that ideally these calls should be instrumented, not sure if achieving both goals will be easy. Let me know what you think.

✅  I have added a generic function to verify the credentials for both Cloud and TPP issuers, including tests
❌  Using the instrumentedclient is not doable without a "larger" rewrite, which is something we can do but in a separate PR. The issue is we are depending on vcerts' endpoint.Connector-interface in a few places and I can't see a straightforward path to extending the instrumentedclient with this functionality without a "larger" rewrite.

Additionally I think the issuer's Ready condition should definitely be set to False if this check fails- do I understand it correctly that currently the code is not doing that? (I am not even sure if we want to return an error in the reconciler- I imagine that in most cases this is an error that will require changes to the Secret resource which will then cause a resync. But perhaps there are some edge cases where this failure can be fixed by changing something in TPP?)

✅ The issuers Ready condition will be set to False if this check fails.

A very minor nit: we don't really have a policy for this, but it subjectively I think that it might be good to squash the commits here. I personally usually utilize rewriting commits and force pushing quite heavily to ensure that each commit is one logical change

✅ I prefer squashing as well, ideally letting GitHub do it for me - I can hold this and squash myself when approved.

Question: have we tested this? Given that the e2e tests actually don't test with TPP token at all it could be nice to add to the PR description a screenshot or something that shows this functionality in action

✅ Yes, I've tested this locally using an access token both manually and while running e2e tests.

Also it looks like this is currently broken for VaaS https://prow.build-infra.jetstack.net/view/gs/jetstack-logs/pr-logs/pull/cert-manager_cert-manager/5185/pull-cert-manager-e2e-issuers-venafi-cloud/1535290360698245120

✅ Should be happy now

Thanks for adding the checks for VaaS and username/password auth and the extra tests @jahrlin !
I've read through the code and this all makes sense to me.
I think we might want to update the release note and the PR description to include the fact that TPP username/password and VaaS access key will also be checked.

Using the instrumentedclient is not doable without a "larger" rewrite, which is something we can do but in a separate PR. The issue is we are depending on vcerts' endpoint.Connector-interface in a few places and I can't see a straightforward path to extending the instrumentedclient with this functionality without a "larger" rewrite.

Yes that makes sense, I think we probably will have to do that though. Probably worth creating an issue for this.
/lgtm
/approve

I think we might want to update the release note and the PR description to include the fact that TPP username/password and VaaS access key will also be checked.

✅  Done!

Using the instrumentedclient is not doable without a "larger" rewrite, which is something we can do but in a separate PR. The issue is we are depending on vcerts' endpoint.Connector-interface in a few places and I can't see a straightforward path to extending the instrumentedclient with this functionality without a "larger" rewrite.

Yes that makes sense, I think we probably will have to do that though. Probably worth creating an issue for this.

✅ Done: https://github.com/cert-manager/cert-manager/issues/5210

Fixed in https://github.com/cert-manager/cert-manager/pull/5212


allow '-testnames' option to work with '-xmlpathinjar'

When '-testjar' and '-xmlpathinjar' are used, the '-testnames' option is ignored. This patch will have it work the same as if '-testnames' was used for xml suite files given on the command line. Thanks!

:+1:


plik: 1.3.4 -> 1.3.5

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/root-gg/plik/releases.
meta.description for plik is: "Scalable & friendly temporary file upload system"
meta.homepage for plik is: "https://plik.root.gg/"
meta.changelog for plik is: ""
Updates performed

Golang update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact

Checks done (click to expand)

built on NixOS
The tests defined in passthru.tests, if any, passed
Warning: no invocation of /nix/store/jcamqq1rnh5hzfvmzh3h6ygdri6dd5f0-plik-1.3.5/bin/plik had a zero exit code or showed the expected version
0 of 1 passed binary check by having a zero exit code.
0 of 1 passed binary check by having the new version present in output.
found 1.3.5 with grep in /nix/store/jcamqq1rnh5hzfvmzh3h6ygdri6dd5f0-plik-1.3.5
found 1.3.5 in filename of file in /nix/store/jcamqq1rnh5hzfvmzh3h6ygdri6dd5f0-plik-1.3.5

Rebuild report (if merged into master) (click to expand)

3 total rebuild path(s)

2 package rebuild(s)

2 x86_64-linux rebuild(s)
1 x86_64-darwin rebuild(s)

First fifty rebuilds by attrpath
plik
plikd

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/jcamqq1rnh5hzfvmzh3h6ygdri6dd5f0-plik-1.3.5 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A plik https://github.com/r-ryantm/nixpkgs/archive/ba27973aaf3ec2ec589077947aad18df7f5d0652.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/jcamqq1rnh5hzfvmzh3h6ygdri6dd5f0-plik-1.3.5
ls -la /nix/store/jcamqq1rnh5hzfvmzh3h6ygdri6dd5f0-plik-1.3.5/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

2 packages built:

plik
plikd

Maintainer pings
cc @freezeboy @kalbasit for testing.

@ofborg test plikd

Version is not reported correctly by the binary.
$ ./results/plik/bin/plik --version
Plik client v0.0.0

And another package version is defined in default.nix

1.3.6 is out now, so this one may be closed.
the version is injected from the git tag, as there is no git repo during the build and no way to by pass it, maybe we could patch the makefile

Ok I have a local build of 1.3.6 with the --version flag working correctly, I'll push a PR

Done by 8dd18c109013d8cb7ffff5ecbf4a13cd6d02f00b.


i18n(es): update 5-astro-api/4

Description (required)
Updates 5-astro-api/4 based on this commit f51952706b3c16b8924a6cb837d77da48b7e59be

Related issues & labels (optional)

Closes # N/A
Suggested label: i18n

Lunaria Status Overview
🌕 This pull request will trigger status changes.

Learn more
By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.
You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

Locale
File
Note

es
tutorial/5-astro-api/4.mdx
Localization changed, will be marked as complete.

Warnings reference

Icon
Description

🔄
The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.


Cache not invalidated when using a PlaceholderField outside the CMS

Description
Since v3.6.0, when using a PlaceholderField outside the CMS, the cache is not invalidated when updating the placeholder content.
On this commit, the value of the clear_cache attribute changed from True to False, and the clear_cache method is never called in this case.
Related resources

https://github.com/divio/django-cms/commit/99880979884de94b1f2784bb830ad5cf6d7bdea7#diff-5c9765ac0e61c2e87b3cea96392a6df2L1117
https://github.com/divio/django-cms/blob/release/3.7.x/cms/models/placeholdermodel.py#L499
https://github.com/nephila/djangocms-blog/issues/484

Steps to reproduce

Create a custom model containing a PlaceholderField

class MyModel(models.Model):
    body_placeholder = PlaceholderField("Body")

Activate CACHE on the CMS

CMS_CACHE_DURATIONS = {
    "menus": 3600,
    "content": 3600,
    "permissions": 3600
}

Create a MyModel instance, a view and template to display it

Edit the my_model_object placeholder field content within a template using the render_placeholder template tag:

{% render_placeholder my_model_object.body_placeholder %}

Open the MyModel instance view in a private session to compare the content.

Repeat steps 4 and 5 twice if the content doesn't differs.

Expected behaviour
The contents are always the same between the two browser sessions.
Actual behaviour
The contents differs as the cache is not invalidated when updating the body_placeholder content.

Suggested correction
In the mark_as_dirty method, force clear_cache when the attached model is not a Page or a StaticPlaceholder.
Checklist

[x] I have opened this pull request against develop
[ ] I have updated the CHANGELOG.rst
[ ] I have added or modified the tests when changing logic

Coverage remained the same at 78.215% when pulling c9a80df7bba861a7c7ee744f26b717b95bc1d4a3 on pierreben:fix-placeholderfield-cache-clear into 01f53e46cba3cf9e78e683cfccb561e11875091b on divio:release/3.7.x.

@pierreben please make sure to have a look at the checklist :)

@pierreben I think the branch should be recreated including commit https://github.com/django-cms/django-cms/pull/6912/commits/c9a80df7bba861a7c7ee744f26b717b95bc1d4a3 only

I've didn't submit the correct branch.
I've created a new PR (https://github.com/django-cms/django-cms/pull/6956) with tests and only one change of 2 lines against develop.


[text] artist thumbnail issues

image on artist thumbnail seems extremely zoomed in, like this :

instead normally look like this (vanilla spotify) :

OS: [Windows 10]
Spotify version [<IP_ADDRESS>1.gbf202593]
Spicetify version [2.23.0]
Theme name : [text]

@darkthemer


Change tab name to SafeSwap

📘 Issue Description
Update Browser Tab Placeholder to "SafeSwap"
When running the project locally, the browser tab currently displays a placeholder text. Update this placeholder to display "SafeSwap" for better branding and clarity.
Task Details:

Locate the configuration or HTML file where the placeholder for the browser tab is set (e.g., <title> tag in the index.html or equivalent file).
Replace the current placeholder text with "SafeSwap".
Verify that the change reflects correctly when running the project locally.

Can I work on this? @danielcdz

@danielcdz kindly assign
attached is a screenshot of the implementation
ETA <= 5mins

@danielcdz can i work on this?

Hello! i’m From Costa Rica and i have over 5 years of experience in front-end.
I’m part of the Dojo team ⛩
I’m really interested on contribute to this issue, i will find the HTML title tag and replace it with the one you preferred!
Thank you!

Hello! i’m From Costa Rica and i have over 5 years of experience in front-end.
I’m part of the Dojo team ⛩
I’m really interested on contribute to this issue, i will find the HTML title tag and replace it with the one you preferred!
Thank you!

Hello! i’m From Costa Rica and i have over 5 years of experience in front-end.
I’m part of the Dojo team ⛩
I’m really interested on contribute to this issue, i will find the HTML title tag and replace it with the one you preferred!
Thank you!

Hello! i’m From Costa Rica and i have over 5 years of experience in front-end.
I’m part of the Dojo team ⛩
I’m really interested on contribute to this issue, i will find the HTML title tag and replace it with the one you preferred!
Thank you!

I would like to work on this issue

Could I take over this issue?I can comfortably handle this issues

My Background and How It Can Be Leveraged
Hello, my name is Derian Rodríguez. I am a passionate software engineer with over one year of experience. I am part of the Dojo Coding Community and have been actively contributing to open-source projects through OnlyDust. I have experience in frontend development using JavaScript/TypeScript, React, and Next.js. I would love to contribute and support the development of this project.
How I Plan on Tackling This Issue
I will locate the layout file where the metadata object is defined.
I will change the title value to "SafeSwap" and adjust the description to improve the brand image and SEO of the application.
I will run the project locally to ensure the updated title appears correctly in the browser tab.

I'd like to handle this task.
I am a Full Stack Developer with a strong background in blockchain and extensive experience in Next.js/React, TypeScript, and Rust. I’ve made over 45 contributions to over 15 projects in the OnlyDust ecosystem, solving complex issues and delivering efficient, scalable solutions.

Hello I am Joseph I am a frontend developer and blockchain developer and I am also an active contributor here on only dust here is my profile https://app.onlydust.com/u/josephchimebuka. This is my first time to contribute to this repo ill appreciate the opportunity to contribute. this is a couple of frontend and blockchain projects i have built https://metacrypt.vercel.app/ https://mattedsgn.com/
May I try this one?

Could I grab this task?

Can I contribute to this one?

Can I take care of this issue?
i'm a frontend dev and a blockchain dev kindly assign :)

Could I grab this task?

Can I take care of this issue?

Mind if I try this one?

Can I get this issue?
My approach:
Will start by locating the title tag and will replace with the name as provided.
Will run it to check whether its running properly

Can I contribute to this one?
May I take this issue on?
My name is Gideon Bature, a Software Engineer with experience using TypeScript. If assigned this issue, I should be able to send my first PR within 12 hrs.
Thank you!

Hello can i be assigned this issue, i am a new contributor with experience in typescript would love to work on this , my ETA is >20 Hours and ill create a draft PR in 10 hours time. Thank you for this opportunity. :)

Can I be assigned to this?  I am an experienced frontend developer with 3 years of experience.

Hello,
My name is Leo, and I'm a junior software developer from Costa Rica. This will be my first Hackathon, and I am excited to apply for this issue.
I have experience working with C#, JavaScript, Node.js, some TypeScript, CSS and HTML I believe this issue will be a fantastic opportunity to enhance my coding skills.
Currently, I am also learning about Web3 technologies.
Thank you for considering my application.
Best regards,
Leo

Thanks for assigning the issue to me. I'll make the PR for it ASAP.


Fix status-bar test

This is actually how I originally meant to write this test :grimacing:

That makes way more sense!


skeleton quart client integration

This is a work-in-progress of #429 .
It sort of "works", but is intended as an illustration to accompany the issue.
The only changes from the existing flask_client are the change in imports and the addition of async to some methods in QuartRemoteApp.
What kind of change does this PR introduce? (check at least one)

[ ] Bugfix
[X] Feature
[ ] Code style update
[ ] Refactor
[ ] Other, please describe:

Does this PR introduce a breaking change? (check one)

[ ] Yes
[X] No

[X] You consent that the copyright of your pull request source code belongs to Authlib's author.

@jonathonfletcher Hi, can you add tests for this client?


Added an make install option

This pull request introduces an make install option to all files pertaining to this project, closing #52. It makes building a static lib optional, as it is not strictly needed in the build process (although it remains on by default). I'm not really sure if I did the make install part of the examples correctly, but this path was recommended to me by https://github.com/Homebrew/homebrew-core/pull/17230#discussion_r135399677. Installing the examples is optional, as downloading the git project already downloads them to your computer, but for example Homebrew needs a location outside of the build/git folder to make them available to the user.

Any good pointers on how to cleanup this big list of unmerged commits:? I could try a new repo

Would it help to shorten my list of unmerged commits if I were to rebase my repo? (I read somewhere that you should not rebase public repo's or something)

If you want to create a new feature, you branch from my ’master’ and commit the changes in that branch. This makes it easier to merge it back into ’master’, since you won't divert that much.
See (https://www.atlassian.com/git/tutorials/comparing-workflows#feature-branch-workflow)[https://www.atlassian.com/git/tutorials/comparing-workflows#feature-branch-workflow] for example.


Home manager fails to activate on pristine installation

Given the following configuration.nix:
{ config, pkgs, lib, ... }:
let
  home-manager-19_09 = builtins.fetchGit {
    url = "https://github.com/rycee/home-manager.git";
    rev = "0d1ca254d0f213a118459c5be8ae465018132f74";
    ref = "release-19.09";
  };
in
{
  imports = [(home-manager-19_09 + "/nixos")];

  boot.loader.grub.device = "nodev";
  fileSystems."/".device = "/dev/sda";
  networking.hostName = "test-hm";

  security.sudo.enable = true;
  security.sudo.wheelNeedsPassword = false;

  services.journald.console = "/dev/ttyS0";
  services.mingetty.autologinUser = "roos";

  system.stateVersion = "19.09";

  users.mutableUsers = false;
  users.users.roos = {
    shell = pkgs.bashInteractive;
    password = "roos";
    isNormalUser = true;
    extraGroups = ["wheel"];
  };

  home-manager.users.roos.home.sessionVariables.foo = "bar";
}

when running in a VM:
~$ NIXOS_CONFIG="$(readlink -f configuration.nix)" nixos-rebuild build-vm && (rm -fr *.qcow2 || true) && ./result/bin/run-*-vm -chardev stdio,mux=on,id=char0,signal=off -mon chardev=char0,mode=readline -serial chardev:char0 -snapshot

(warning: the command above will remove any *.qcow files in the current directory).
The unit home-manager-roos.service fails to activate with error:
[roos@test-hm:~]$ systemctl status home-manager-roos.service | cat
● home-manager-roos.service - Home Manager environment for roos
   Loaded: loaded (/nix/store/2g118k39c8jkja2zdaj3v34aa3yw3ns0-unit-home-manager-roos.service/home-manager-roos.service; enabled; vendor preset: enabled)
   Active: failed (Result: exit-code) since Sun 2020-03-29 23:11:21 UTC; 25s ago
  Process: 603 ExecStart=/nix/store/jsws5iz9vk3bcw0iay8m7fz7bw6ppwcl-activate-roos (code=exited, status=1/FAILURE)
 Main PID: 603 (code=exited, status=1/FAILURE)
       IP: 0B in, 0B out
      CPU: 20ms

Mar 29 23:11:21 test-hm hm-activate-roos[603]: Activating home-manager configuration for roos
Mar 29 23:11:21 test-hm hm-activate-roos[603]: Starting home manager activation
Mar 29 23:11:21 test-hm hm-activate-roos[603]: find: ‘/nix/var/nix/profiles/per-user/roos’: No such file or directory
Mar 29 23:11:21 test-hm systemd[1]: Starting Home Manager environment for roos...
Mar 29 23:11:21 test-hm systemd[1]: home-manager-roos.service: Main process exited, code=exited, status=1/FAILURE
Mar 29 23:11:21 test-hm systemd[1]: home-manager-roos.service: Failed with result 'exit-code'.
Mar 29 23:11:21 test-hm systemd[1]: Failed to start Home Manager environment for roos.

Duplicate of https://github.com/rycee/home-manager/issues/948, closing...
/close


PrivateKey refactor

This is a pretty big one. What we want is to make signatures with your library, but now necessarily passing a private key, just a signing function.
How I tentatively implemented that is by making PrivateKey the following interface
type PrivateKey interface {
	Sign(hashed []byte, alg uint8) ([]byte, error)
	String(alg uint8) string
}

The usual {rsa|dsa|ecdsa}.PrivateKey are now wrapped in a PrivateKey, and Sign and String are implemented for them. But if you want to define your own PrivateKey that uses for example PKCS#11 for Sign, you can and then use it with RRSIG.Sign().
What I like of this is that it moves the signing and exporting code and switches out of the logic.
I should not be breaking any interface, and all code that did not inspect PrivateKey should keep working.
I also fixed a couple critical bugs in RSA key export.

Looks good. I will go over it in some more detail.
Good you split of the moves from keygen.go -> dnssec_keygen.go and friends in a separate PR?

Just split the PR into two commits, the first is a minimized diff for review: https://github.com/FiloSottile/dns/commit/e9faa971b320961a208a7ab53c7805d4f280f809
The second is strictly code moved from place to place.
The resulting changeset is the same.


Fix note alert rendering

Why:
This PR provides a fix for a Note alert rendering in the this article.

Closes: none

What's being changed (if available, include any code snippets, screenshots, or gifs):

Check off the following:

[x] I have reviewed my changes in staging, available via the View deployment link in this PR's timeline (this link will be available after opening the PR).

For content changes, you will also see an automatically generated comment with links directly to pages you've modified. The comment won't appear if your PR only edits files in the data directory.

[x] For content changes, I have completed the self-review checklist.

Thank you again! Coincidentally I fixed this in a PR I have yet to merge internally, but I'm happy to merge this now 😄


feat(ui/input): add autofocus of input

Checklist

[ ] Fix linting errors
[ ] Tests have been added / updated (or snapshots)

Change information

https://github.com/varletjs/varlet/issues/587

Codecov Report

Merging #595 (6c0089b) into dev (e97e869) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##              dev     #595   +/-   ##
=======================================
  Coverage   95.82%   95.82%
=======================================
  Files         217      217
  Lines        5267     5269    +2
  Branches      990      992    +2
=======================================
+ Hits         5047     5049    +2
  Misses        213      213
  Partials        7        7

Impacted Files
Coverage Δ

packages/varlet-ui/src/input/props.ts
100.00% <ø> (ø)

packages/varlet-ui/src/input/Input.vue
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e97e869...6c0089b. Read the comment docs.


Generate parameter types

This PR introduces type generation for parameters field that makes autocomplete work for resolver parameters, mutation and useLazyReference arguments.
There are a couple of open questions though:

We need to filter out __typename variables from mutation inputs and I'm not sure where is the good place for it
Should we generate parameters for a client field type when it's used as a parameter? It's just 2 lines of code, but what's a use case for it?
In the github-demo, inside HomeRoot there is a parameter that is used as a lazyLoadReference parameter, but is absent in the Query.HomePage field. It resides deeper in the child component RepositoryList. Should we expose all children parameters in the parent component then?
encountered_fields in SelectableServerFieldId::Object are not sorted and field order is not stable for now. Can we replace HashMap with BTreeMap for encountered_fields?

Re: GitHub Demo

Ooh interesting, that's actually indicative of a bug. The reason this currently validates is that the first parameter is optional, so passing null is fine
We should review whether we want optional parameters, though. TBH it seems like a footgun. It seems more explicit to have a default value of null.
And we currently don't validate unused parameters, but we should: #134
So we have some weird behavior! We send the first parameter to the backend, and it is used by the watchers and pullRequests field, but we alias that field as if it has a null parameter:

So uh, bugs all around, but coincidentally, not broken in practice in this specific case.

The fix:

validate no unused fields
that will force us to thread the first field down to the appropriate subfield, or drop it
that will cause us to not have a mismatch between what the reader thinks we're doing (i.e. it thinks we're passing null), and what the server sees (us passing first: 15)

Separately, that first field is doing exactly nothing, so for now, I'll remove that field in master

RE: encountered fields BTreeMap, yes, 100%, we should (probably) almost always be using BTreeMap/Set everywhere instead of HashMap/Set. And we should always use the BTree version if we're writing the output to a file or to an error message, or otherwise relying on order
So go ahead and make that change, please!

RE: encountered fields BTreeMap, yes, 100%, we should (probably) almost always be using BTreeMap/Set everywhere instead of HashMap/Set. And we should always use the BTree version if we're writing the output to a file or to an error message, or otherwise relying on order
So go ahead and make that change, please! (Bonus points if it is a separate PR that lands independently, but no big deal either way)

Sure, I'll make a separate one. But it should be merge first or checks is going to be failed

Re 2: I'm not sure what this would mean, quite yet! So let's continue to panic if we encounter that. This should not be possible to do, I think, so panicking is the appropriate behavior


brian.analyze multiMessage

Modify decorator to take in file path inputs
Grab both .yml and .yaml files for sqars
Update Analyze subcommand to return proper results for filepaths
Return additional info in response and format output data
New template for multi-message outputs

sample formatted output


Add OpenRGB

[x] I have checked that this app does not already have a pending request and has not previously been declined.
App Name: OpenRGB
Download URL: https://gitlab.com/CalcProgrammer1/OpenRGB/-/releases or https://openrgb.org/releases.html
Website URL: https://openrgb.org
App Summary: Open source RGB lighting control that doesn't depend on manufacturer software. For Windows, Linux, MacOS.

I'm working on it.

#264 was now opened.


compiling with std=c99 causes inclusion failure

Building tpm2.0-tools with CFLAGS=-std=c99 causes:
In file included from /usr/local/include/sapi/tpm20.h:46:0,
from src/debug.c:31:
/usr/local/include/sapi/tss2_tcti.h:66:2: error: #error Info: Platform not supported for TCTI_POLL_HANDLES
#error Info: Platform not supported for TCTI_POLL_HANDLES
It appears as though the if defined linux || defined unix is not working. Testing locally seems to indicate that linux should be used instead, or included in the ifdef switch.

The logic there is a little weird. Not sure why we define that type for the TCTI_POLL_HANDLES stuff at all there if we're just going to #error out. I guess that's a separate issue all together though. Back to your point:
linux is an obsolete symbol (not POSIX) for Linux systems. It should be __linux__. Similarly unix should be __unix__. Our use of __linux is equally broken. https://sourceforge.net/p/predef/wiki/OperatingSystems/
I spent a few minutes with this and the __linux__ stuff is pretty easy to fix. Other stuff goes sideways with <time.h> stuff in criticalsection.h.

Looks like  gcc compiles with -std=gnu89 by default, might be better to go to -std=gnu99 instead of straight to -std=c99. This stuff won't compile with -std=c89 after all.

Yeah I figured we could flip this later if we want. The C build for tpm2.0-tools was the one htting this #define include issue when I was flipping that over.

Gotcha. I've already started playing around with this so I figure cleaning it up a bit is a good idea since I'm already halfway there. I'll update the default CONFIG_SITE file to include -std=gnu99 and fix up the __linux/linux to __linux__.
Do you have an opinion on ifdef __blah__ vs if defined(__blah__)?

I guess '#ifdef' is limited to a single conditional (can't append logical operators) so maybe it's best to go with #if defined so we can handle the logical or.

Yeah ifdef as you pointed out is limited, so for compound statements #if defined() is the choice.

@williamcroberts : got a PR over in #310

Looks like the gnu99 stuff merged in #310 was sufficient to address this. If no feel free to reopen this issue.


Embed currencies in go code #7

See Issue #7

Thanks for PR,
I updated your solution and pushed it to v0.2.0 version.
https://github.com/Rhymond/go-money/pull/9


The player sprite doesn't show up when you return to the main menu

Summary of the bug
The player sprite doesn't show up when you return to the main menu and you click again in the new game button
Type
Sprites
Steps to reproduce the behavior
Open the game, new game, esc to show the pause menu, click on return to the main menu, click on new game and spawn again de player.
Expected behavior
It should show the player sprites
Actual behavior
It shows the text of the main menu buttons.
Build
0.2.0
Date
25/03/2019
Additional comments

JAJAJAAJAJAJA cunde aixo de les issues


[bug] Form onSubmit isn't called

Describe the bug
Form onSubmit isn't called when FormTrigger element is pressed
To Reproduce

Basic form as per the docs
Tried with both Form.Trigger and FormTrigger

Versions

Tamagui 1.7.2
Expo 48

in anatomy, missing asChild on Form.Trigger for work with Button, if only test, thios should work as expected

Did you pass the asChild prop?

Any news ? @rub1e

I ran into this myself today. Passing asChild to <Form.Trigger> solves the issue

Docs are improved, asChild is the right way!


Framework 'XXX' not found

Steps to reproduce
I have removed the plugins that are no longer in use, but during build or debug, it still prompts that these Frameworks are needed, as if the references in the project were not deleted. I’ve tried modifying the Other Linker Flags in Xcode, but when I run flutter build ipa again, they are regenerated. Can someone help me find out the cause?
On Android it’s fine, only iOS has the issue.
Actual results
Unable to build successfully.
Logs
Error (Xcode): Framework 'TLPhotoPicker' not found

Error (Xcode): Linker command failed with exit code 1 (use -v to see invocation)

Encountered error while archiving for device.

Flutter Doctor output

Doctor output

[✓] Flutter (Channel stable, 3.22.3, on macOS 14.5 23F79 darwin-arm64, locale zh-Hans-CN)
[!] Android toolchain - develop for Android devices (Android SDK version 34.0.0)
    ✗ cmdline-tools component is missing
      Run `path/to/sdkmanager --install "cmdline-tools;latest"`
      See https://developer.android.com/studio/command-line for more details.
    ✗ Android license status unknown.
      Run `flutter doctor --android-licenses` to accept the SDK licenses.
      See https://flutter.dev/docs/get-started/install/macos#android-setup for more details.
[✓] Xcode - develop for iOS and macOS (Xcode 15.0)
[✓] Chrome - develop for the web
[✓] Android Studio (version 2022.3)
[✓] VS Code (version 1.90.2)
[✓] Connected device (5 available)
[✓] Network resources

! Doctor found issues in 1 category.

Did you try flutter clean?

Yes, I also tried deleting the Pod file, Podfile.lock, .symlinks, Runner.xcworkspace, and any other cache interference I could think of. but The issue still persists.@amorenew

@no-chili Are you using hl_image_picker? Does the issue only happen if you add that plugin to the project? Please provide the output of flutter run -v.

I am no longer using it and have deleted the relevant code, but when I remove it from pubspec.yaml, the project cannot run. I have to add it back to work normally. The same error occurs when removing other unused plugins, so it should not be an issue with a specific package. Below is my Podfile and the running log.

Podfile
ENV['COCOAPODS_DISABLE_STATS'] = 'true'

project 'Runner', {
  'Debug' => :debug,
  'Profile' => :release,
  'Release' => :release,
}

def flutter_root
  generated_xcode_build_settings_path = File.expand_path(File.join('..', 'Flutter', 'Generated.xcconfig'), __FILE__)
  unless File.exist?(generated_xcode_build_settings_path)
    raise "#{generated_xcode_build_settings_path} must exist. If you're running pod install manually, make sure flutter pub get is executed first"
  end

  File.foreach(generated_xcode_build_settings_path) do |line|
    matches = line.match(/FLUTTER_ROOT\=(.*)/)
    return matches[1].strip if matches
  end
  raise "FLUTTER_ROOT not found in #{generated_xcode_build_settings_path}. Try deleting Generated.xcconfig, then run flutter pub get"
end

require File.expand_path(File.join('packages', 'flutter_tools', 'bin', 'podhelper'), flutter_root)

flutter_ios_podfile_setup

target 'Runner' do
  use_frameworks!
  use_modular_headers!

  flutter_install_all_ios_pods File.dirname(File.realpath(__FILE__))
  target 'RunnerTests' do
    inherit! :search_paths
  end
end

post_install do |installer|
  installer.pods_project.targets.each do |target|
    flutter_additional_ios_build_settings(target)
    target.build_configurations.each do |config|
        config.build_settings['BUILD_LIBRARY_FOR_DISTRIBUTION'] = 'YES'
        config.build_settings["EXCLUDED_ARCHS[sdk=iphonesimulator*]"] = "arm64 i386"
    end
    if target.name == "geolocator_apple"
      target.build_configurations.each do |config|
        config.build_settings['GCC_PREPROCESSOR_DEFINITIONS'] ||= ['$(inherited)', 'BYPASS_PERMISSION_LOCATION_ALWAYS=1']
      end
    end
  end
end

flutter_run_log.txt

The same error occurs when removing other unused plugins, so it should not be an issue with a specific package.

It looks like an issue with specific configurations. Can you provide a completed and minimal reproducible code sample that doesn’t include 3rd party plugins or complex production code so that I can try running it on my end to reproduce the issue?


Make ListWrapper public so it can be used by consumers

Currently if you want to assign an IList to Source have to use the SetSource method
because the SourceProperty is actually of type IListDataSource.
But when implementing DataBinding that means you need to convert IList to IListDataSource
and you do this by wrapping the IList into an IListDataSource implementation.
For example, here I define 2 bindings, one for a Label the other for a ListView
var ustringConverter = new UStringValueConverter();
var listWrapperConverter = new ListWrapperConverter();

var labelBinding = new Binding(this, "Text", label2, "Text", ustringConverter);
var listBinding = new Binding(this, "Heroes", listView, "Source", listWrapperConverter);

Looking at the code for the converter:
public class ListWrapperConverter : IValueConverter
{
    public object Convert(object value, object parameter = null)
    {
        var wrapper = new CustomListWrapper((IList)value);
        return wrapper;
    }
}

All it does it wrap the IList into a CustomListWrapper instance.
But this CustomListWrapper class is just a 1:1 copy of the internal ListWrapper class.
Id would be nice to just write var wrapper = new CustomListWrapper((IList)value);

I think if you override ToString() on your list element types you can do without the ListWrapper class

@kbilsted not sure we are talking about the same thing.
I may not have explained it properly.
Imagine we have a List<Person> called people and a ListView called theList.
 //This way, the render process will call ToString() on every instance of Person
 theList.SetSource(people);

So to customize what gets rendered, you can just override ToString() that is true.
Im creating a Binding` class which takes

a Source instance of type object
a SourceProperty property of type string
a Target instance of type object
a TargetProperty property of type string
an optional instance of IValueConverter

When the Source value is changed the Target is updated by setting the TargetProperty
on the Target:
var targetProperty = Target.GetType().GetProperty(TargetPropertyName);
targetProperty.SetValue(Target, finalValue);

Since the Binding does not know the difference between a Label and a ListView it does not
know about ListView.SetSource(IList source) so it tries to ListView.Source = value;
But the type of ListView.Source is IListDataSource so a IValueConverter is required:
public class ListWrapperConverter : IValueConverter
{
    public object Convert(object value, object parameter = null)
    {
        var wrapper = new CustomListWrapper((IList)value);
        return wrapper;
    }
}

And since ListWrapper is a private subclass I cannot just pass a new instance of it.
Instead I had to copy the source code to CustomListWrapper.

+1 I was too fast :)

The PR has been merged


Added appropriate/missing changelog entries

Pull Request Checklist
Is this in reference to an existing issue?
General

[ ] Update Changelog following the conventions laid out on Our CHANGELOG Guidelines

[ ] Update README with any necessary configuration snippets

[ ] Binstubs are created if needed

[ ] RuboCop passes

[ ] Existing tests pass

New Plugins

[ ] Tests

[ ] Add the plugin to the README

[ ] Does it have a complete header as outlined here

Purpose
Known Compatibility Issues

@Seji64 thanks for following up on this.


Uncaught TypeError: Arguments to path.join must be strings

[Enter steps to reproduce below:]

I just opened Atom

Atom Version: 0.170.0
System: Mac OS X 10.10.1
Thrown From: linter package, v0.9.1
Stack Trace
Uncaught TypeError: Arguments to path.join must be strings
At path.js:390

TypeError: Arguments to path.join must be strings
  at Object.exports.join (path.js:390:15)
  at LinterJsYaml.Linter.getNodeExecutablePath (/Users/rahul286/.atom/packages/linter/lib/linter.coffee:114:10)
  at LinterJsYaml.Linter.getCmdAndArgs (/Users/rahul286/.atom/packages/linter/lib/linter.coffee:90:25)
  at LinterJsYaml.Linter.lintFile (/Users/rahul286/.atom/packages/linter/lib/linter.coffee:122:24)
  at /Users/rahul286/.atom/packages/linter/lib/linter-view.coffee:138:18
  at Array.forEach (native)
  at /Users/rahul286/.atom/packages/linter/lib/linter-view.coffee:137:18
  at Object.oncomplete (fs.js:93:15)

Commands

Config
{
  "core": {
    "disabledPackages": [
      "autoclose-html",
      "atom-html-preview"
    ]
  },
  "linter": {}
}

Installed Packages
# User
autocomplete-plus, v1.1.0
hex, v0.3.10
jsonlint, v0.4.0
linter, v0.9.1
linter-js-yaml, v0.1.3
minimap, v3.5.4
tabs-to-spaces, v0.8.0

# Dev
No dev packages

/cc @atom/core

Dupe of #329 which was fixed in v0.10.0. Please upgrade.

Thanks for quick followup.


Tooltip configuration does not work

Tooltip configuration does not work.
The following code shall render tooltip which is orange, and text is red. It does work with vanilla ChartJS lib (live sample: https://jsfiddle.net/q84hfwsm/2/), but does not work with this coreusi-react-chartjs library.
options = {{
  plugins: {
    tooltip: {
      bodyColor: 'red',
      backgroundColor: 'rgba(249, 231, 159, 1)'
    }
  }
}}

#7


travisci integration

this repo should be connected to travisci for continuous integration testing.

travis ci integration is now working.


sync.Lock stuck after a time.Ticker receive

I get the same behaviour with "go1.5rc1 linux/amd64" and "go1.4.2 linux/amd64".
Steps to reproduce
The following program sometimes gets stuck using a bit of CPU (around 40% consistantly):
// Undetected dead lock.
package main

import (
	"fmt"
	"sync"
	"time"
)

type myType struct {
	mu     sync.Mutex
	kill   chan struct{}
	ticker *time.Ticker
}

func New(interval time.Duration) *myType {
	t := &myType{
		kill:   make(chan struct{}),
		ticker: time.NewTicker(interval),
	}
	go func(m *myType) {
		for {
			select {
			case <-m.kill:
				m.ticker.Stop()
				return
			case <-m.ticker.C:
				fmt.Printf("ticker locking\n")
				m.mu.Lock()
				fmt.Printf("tick\n")
				m.mu.Unlock()
				fmt.Printf("ticker unlocked\n")
			}
		}
	}(t)
	return t
}

func (m *myType) Close() {
	fmt.Printf("closing\n")
	m.mu.Lock()
	m.kill <- struct{}{}
	m.mu.Unlock()
	fmt.Printf("closed\n")
}

func main() {
	// Close acquires the lock but the ticker goroutine gets a ticker event
	// and tries to acquire the lock as well: program uses 100% cpu and is stalled
	// using nanoseconds to emphasize the issue
	// got the issue with tickers using 100ms
	m := New(time.Duration(10) * time.Nanosecond)
	// sleeping for a little while helps on go1.5rc1 in reproducing the problem
	time.Sleep(time.Duration(20) * time.Nanosecond)
	m.Close()
}

Expected results
The ticker may or may not print "acquiring lock", "tick", "lock released" without getting stuck trying to get the lock.
Actual results
Depending on the run, one of the following:

no output
ticker locking
tick
ticker unlocked
closing
closed
closing
closed
closing
ticker locking

The last output hangs.
Additional information
I purpotedly sleep and tick for a tiny small amount of time to increase the chances of the issue occuring. In my original program, I had a ticker ticking in the range of 100ms to 300ms and had my program sometimes getting stuck for no reason.

This is a bug in your program (you're Locking twice, and blocking inside one of your locked regions; make your kill channel buffered). Send SIGQUIT to your program (Control-) to see the deadlock. The deadlock detector is not guaranteed to tell you about everything. It only works for pretty simple cases.
Unlike some projects on Github, we don't use the Go issue tracker for Q&A, since we started with a mailing list. I recommend you post this to golang-nuts@ if you have further questions.

Thanks Brad. It makes sense now, I should have figured it out.
I still think the deadlock detector should have spotted it though :).

+1@bradfitz


Add size parameters to control thumbnail size

width (default=320)
height (default=180)

Has there been a solution to this yet? How can I control the size of the thumbnail?

Thanks for the update. Are you currently working on it by any chance? I ask because when I embed YouTube videos using your project, the link (e.g., https://markdown-videos.deta.dev/youtube/MtSMa02I1Co) takes me to a page that says "Service No Longer Available" (and it used to be working). It'd be great if this could be fixed soon

@David-davidlxl I'm not atm... I'm busy with house renovations and work atm, but when that's done I will look at fixing markdown-videos again.
The reason it's not working atm is that deta just deprecated Deta Cloud, so I have to migrate to Deta Space... more info here: https://github.com/Snailedlt/Markdown-Videos/issues/27

Could you add instructions in README on how to pass the width and height parameters in GitHub Markdown? With an example? Thank you

@David-davidlxl Yeah good idea. I'll do that next time I work on this :)
Until then you can see examples here: https://markdown-videos.vercel.app/docs

@David-davidlxl Does this look like an okey solution? #38

@Snailedlt Thank you! This is much better, but I have a couple of suggestions:

use "width=320" and "height=180" in the examples just to be consistent with the default values
add another example (maybe outside the table) showing how to set both parameters simultaneously (it took me a while to find your example in https://github.com/Snailedlt/Markdown-Videos/issues/37 to figure out how to do it); setting only one parameter to a nondefault value would leave the image distorted, so it would be most useful if the user knows how to set both

@David-davidlxl Thanks for the suggestions. Setting multiple parameters is the same for pretty much every REST API, which is why I didn't include an example for it. If you need examples you can always look at the docs.
That said, I agree that the default width and height should be more clear, so I'll add a "default" column to the parameters table (see #38 ) :)


[release-1.14] Fix release-commit.sh to use release-1.14 branch instead of master

Please provide a description of this PR:
Release integration test uses this file and it should be updated to use the proper branches

@jacob-delgado: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

release-test_istio_release-1.14
df6689f21ea3530cae7ae4d3fd4667e162ab5bc8
link
true
/test release-test_istio_release-1.14

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jacob-delgado: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

release-test_istio_release-1.14
df6689f21ea3530cae7ae4d3fd4667e162ab5bc8
link
true
/test release-test_istio_release-1.14

release-notes_istio_release-1.14
df6689f21ea3530cae7ae4d3fd4667e162ab5bc8
link
true
/test release-notes_istio_release-1.14

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest-required

@jacob-delgado: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

release-test_istio_release-1.14
df6689f21ea3530cae7ae4d3fd4667e162ab5bc8
link
true
/test release-test_istio_release-1.14

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


pre-commits

starting with adding pre-commits checks from scverse defaults if useful, consider also using https://results.pre-commit.ci/ for CI linting, feel free to close @ilan-gold

@keller-mark I like the changes ruff made vs. autopep8 / flake and pre-commit runs automatically including backfilling with commits.  Feel free to close if you just want to keep things as-is


Extreme mimic spawn

Extreme Mimic spawn in caves. Every cave near a players home get absolutely filled with mimics after few hours of gameplay. Also the command "/dangerouscaves kill mimic" doesn't seem to work "There's no mob's type called mimic!" and no error on console.
Screenshot:
Mimic spawns:
https://ibb.co/rxJPb5d [.]
Command not working:
https://ibb.co/xMcT20w [.]
Config:
https://pastebin.com/MfDRXpbt [.]
Additional information

Server version: 1.16.5
Plugin version: Dangerous-Caves-2.2.14-SNAPSHOT
Server core name: Tuinty

Sorry, as for now Mimic mob is still rather experimental. I'm thinking of ways dealing with it, but as for now it's disabled by default because of this exact reason.
I'll eventually fix the issue, but for now, consider disabling this mob by setting its priority to 0.

Looking forward to that update. How about setting the priority to 1? Would that minimize the spawn or would that be same?
Also how will I de-spawn already spawned mimics since the command is not working?

The problem is that mimics are not considered as a mob after transformation. The only solution I can think of right now - just use WorldEdit.
I can add a command that will scan loaded chunks and delete Mimics, but it'll take sometime because I'm not able to do so right now.
Also, as I said before, it's not recommended to turn mimics on right now. If you really want this mob on your server - go ahead tho.

Yes, I already disabled it.
And I'll try using world edit. But the command would be handy in the future, yes.

Temporarily added a new command /dcaves mimeremove [radius] [me|all]. /dcaves mimeremove 3 all will remove all mimic chests in 3 chunk radius around all the players. Just /dcaves mimeremove removes mimics in 1 chunk radius around executor(around everyone if used from console)
I didn't test it - sorry, can't do that rn. At least it will not delete player's chests in any case.

is it tab complpeted? :)

@CloudeLecaw nah. I could do that if you really want to, but I hope that this command will eventually be deleted...

Hello, I put the last version, the command works but it doesn't seem to remove anything even if by doing the command I have according to the chosen radius of deletion infos like "Removing 2560 mimic chests" I don't see anything disappearing around me! it's the horror and I can't remake a world from 0 nor recover an old version there was too much thing built on it since the times when I had activated the minics!
What do I have to do?

Hello, would it be possible to have a permission to authorize my admin moderator and guide to use the command to remove the mimic, all alone I will never get out of it:
/dcaves mimeremove 0 all

Currently you just have
dangerous.caves.command what allows you to use the whole commands of this plugin.

Thank you, I will put it in place for all the Staff to try to reduce the mimic as much as possible

It didn't work, the other staff accounts with the "dangerous.caves.command" permission can't run the command in OP it's ok without OP there is this line that is written once the command is run "/dcaves mimeremove 0 all"

Hello, thanks to this update my admin and others can use the command "/dcaves mimeremove 0 all" with the permission "dangerous.caves.command"

Still would be nice to have the mimiremove in tabcomplete :)


Automated cherry pick of #9351: feat(cloudid): support aliyun saml auth

Cherry pick of #9351 on release/3.5.
#9351: feat(cloudid): support aliyun saml auth

Codecov Report

Merging #9380 (8b09d00) into release/3.5 (6a15e02) will increase coverage by 11.92%.
The diff coverage is 9.52%.

@@               Coverage Diff                @@
##           release/3.5    #9380       +/-   ##
================================================
+ Coverage         5.98%   17.91%   +11.92%
================================================
  Files              796       85      -711
  Lines           125693     8921   -116772
================================================
- Hits              7522     1598     -5924
+ Misses          117504     7151   -110353
+ Partials           667      172      -495

Flag
Coverage Δ

aFlag
17.91% <9.52%> (+11.92%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

pkg/apigateway/handler/auth.go
0.00% <0.00%> (ø)

.../monitor/alerting/conditions/suggestrulereducer.go
0.00% <0.00%> (ø)

pkg/monitor/alerting/conditions/suggestquery.go
2.00% <2.00%> (ø)

pkg/util/seclib2/seclib.go
80.39% <55.55%> (-5.66%)
:arrow_down:

pkg/multicloud/ucloud/storagecache.go

pkg/compute/models/instance_snapshot_joint.go

pkg/multicloud/ucloud/image.go

pkg/compute/models/zonequota.go

pkg/compute/models/secgroupcache.go

pkg/cloudcommon/db/quotas/quotas.go

... and 635 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b95299b...8b09d00. Read the comment docs.

这个需要合并到 3.5 吗？
/hold


A fatal error occurred while trying to run gluten pre-build binary on E5-2650

Describe the bug
A fatal error occurred while trying to run gluten pre-build binary on E5-2650：

To Reproduce
Steps to reproduce the behavior:
Expected behavior
please correct this error and provide a new gluten pre-build binary that can be run on E5-2650.
Additional context
Add any other context about the problem here.

This could be an issue since our 0.5.0 binary is based on skylake server with -march=native enabled and some cpu flags cannot support with E5 processor.
We should use a more flexible flag when release Gluten's binary.


Restructuring of code into modules

This is quite a large PR, and the point of opening it is to ask if the changes are of interest for you.
In order to use the code in a personal project I restructured the code into several modules. One benefit is that the longest file (expressions.rs) at just over 700 lines. All the types and methods used by fzn2lp are re-exported from the top-level so that it compiles without any changes.
This PR represents a work in progress state, and names of modules and the number of modules is not fixed nor intended to be final.
Some additional changes are updating to nom 7.0.0-alpha2 (no changes needed to the code), separating out dev-dependencies, and some minor fixes. Parsing strings with escaped characters is also added, fixing issue #4.
As said, this PR is intended to see if the changes might be of interest to you as well.
All formatting done by cargo fmt.

Thank you. I've not checked the PR in detail, but judging from your description I think I would be happy to accept your PR.

Cool. Then I will take a second run through what I've done and make sure I think it looks reasonable after thinking about it more. Main thing is to recheck that all elements are in reasonably named modules and that the module division feels natural.

I've done a second pass through, and I did some additional changes to the structure. I'm feeling happy with the current structure.
Instead of nesting almost everything inside the statements-module, the sub-modules were brought up to the top-level. In addition, for parameters, predicates, and variables their corresponding _declarations and _types module were moved to be in modules {parameters,predicates,variables}/{declarations,types}.rs instead. This gives a nice symmetry to the three parts in my view.
Please don't hesitate to ask for any desired additional changes or modifications to make this suitable addition.

Updated locally, could reproduce compilation fail, and pushed the changes.

Pushed update now that nom 7.0.0 is released.

Thanks. I reorganized the includes here 5f6dab75966e32e90ad4e19c8d084e4b7ab3e85a.

All changes are included in https://github.com/potassco/flatzinc/pull/20
Closing this. Thank you.


Upload FTI NEWS Token (TECH)

Also, you can use these graphics to say that your ERC20 token fully compatible with Trust Wallet (https://trustwallet.com/logo-assets). Tokens will show up automatically once the user receives them.
Feel free to share this on social media and tag Trust Wallet:

Twitter: @trustwalletapp

Facebook: @trustwalletapp

Thank you, kolya182.


Using filesystem instead of classpath for certificates from target/certs

fixes https://github.com/apache/camel-quarkus/issues/6355
This PR  changes default location of generated certificates to target/certs
and changes the way of reading the certificates by using filesystem (instead of classpath resource)

@jamesnetherton Thanks for the suggestions, I fixed them all.
I think that the PR can be merged.


multipart_upload_test fails

Describe the bug
graphql/test/multipart_upload_test fails at line 161 because application/json is returned instead of multipart/form-data.
To Reproduce
Steps to reproduce the behavior:

cd graphql-flutter/packages/graphql
pub run test_coverage
Interrupt as soon as .test_coverage.dart is generated.
Run test manually using:
dart --pause-isolates-on-exit \
--enable_asserts \
--enable-vm-service=8787 test/.test_coverage.dart

The relevant section of the test output is as follows:
00:01 +64 -1: upload upload success [E]
  Expected: 'multipart/form-data'
    Actual: 'application/json'
     Which: is different.
            Expected: multipart/ ...
              Actual: applicatio ...
                      ^
             Differ at offset 0

  package:test_api/src/frontend/expect.dart 153:30              fail
  package:test_api/src/frontend/expect.dart 147:3               _expect
  package:test_api/src/frontend/expect.dart 59:3                expect
  test/multipart_upload_test.dart 161:7                         main.<fn>.<fn>

Desktop (please complete the following information):

OS: Ubuntu 18.04
Version 2.1.1-beta.5

Additional context

Test coverage full output

Likely related:
https://github.com/dart-lang/http/issues/351
Might be a bug in http 0.12.0+3 and fixed in 0.12.0+4?

Amazing work @knaeckeKami.

I had a feeling it had to do with the HTTP module, but their changelog just had documentation changes the past couple of releases. Thanks for finding that!!

This issue has been fixed by #530, should be released to beta over the next 24 hours.

:tada: This issue has been resolved in version 3.0.0-beta.3 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:

:tada: This issue has been resolved in version 3.0.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Add Copy to prevent release immediately when open code optimization

When Xcode project set Code Generation Optimization Level and also the user defines a custom getter selector name for the PAPreferences subclass's property, it will crash!!! Because when the gettername was reassigned a new value , the name will release immediately for code optimize.

Do you have an example project that demonstrates the crash?
It doesn't look to me like it should crash since the getterName is used later in the block.

use this project's  iOS example .

set Optimization Level "Fastest, Smallest[-Os]" for Debug Scheme.

3.then define a custom getter selector name.

run this example and click the "Press Me!" button.

the reason for that is when you reasign a new value to "getterName" property,  the old value will release and also the local variable "name" will release immediately too for code optimize.

Thanks. It seems like a compiler bug but your workaround certainly fixes it.


Decode AAC without  ADTSDemultiplexer

Hello.
How I can decode aac to wav without adts?
Regards,
Paul

To better understand how to use this without the ADTS header, you can take a look here: https://github.com/jimm98y/SharpRTSPtoWebRTC/blob/159427fddb79792b542061d8fd6af9d8a82b3ed8/src/SharpRTSPtoWebRTC/WebRTCProxy/RTSPtoWebRTCProxy.cs#L316


Add support for pluggable ITypeConverterFactory

(See discussion in https://github.com/remkop/picocli/issues/1707)
There are cases where applications want programmatic control of the type converter used.
The use case mentioned in #1707 is a single type converter for many Enum classes.
Another potential use case is a single type converter for all implementations of an interface.
The proposed interface is as follows:
/**
 * Interface that allows customization of what type converters to use for specific types
 * and options or positional parameters.
 * If a type converter factory is set for a command, then this factory is first queried to produce a type converter.
 * If no type converter factory is set, or the factory returns a null type converter,
 * then the default picocli logic is used to attempt to find a type converter.
 * @since 4.x
 */
interface ITypeConverterFactory {
    /**
     * Returns a type converter for the specified type for the specified option or positional parameter,
     * or returns {@code null} if the default converter should be used.
     *
     * @param type the type (or supertype) for which to return a type converter
     * @param argSpec the option or positional parameter for which to return a type converter
     * @return a type converter or {@code null}
     * @since 4.x
     */
    ITypeConverter<? extends T> createTypeConverter(Class<T> type, ArgSpec argSpec);
}

As is the convention with other getters/setters, applications will be able to install a custom type converter factory for the full command hierarchy via a getter and setter in CommandLine:
/** Sets the specified type converter factory for this command and all subcommands. */
CommandLine::setTypeConverterFactory(ITypeConverterFactory) : void

/** Returns the custom type converter factory for this command, or {@code null} if none was set. */
CommandLine::getTypeConverterFactory() : ITypeConverterFactory

As is the convention with other getters/setters, applications will be able to install a custom type converter factory on a per-command basis via a getter and setter in CommandSpec:
/** Sets the specified type converter factory for this command only. */
CommandSpec::typeConverterFactory(ITypeConverterFactory) : void

/** Returns the custom type converter factory for this command, or {@code null} if none was set. */
CommandSpec::typeConverterFactory() : ITypeConverterFactory

There is no default implementation, that is, by default, CommandLine::getTypeConverterFactory() returns null.
If a type converter factory is set, and it returns a non-null type converter, then this converter is used, otherwise the default picocli logic is used to attempt to find a type converter.
@garretwilson Thoughts/feedback?

@remkop I think that provides the functionality needed to hook into type conversion for all enums types.
One potential problem is that it isn't very flexible. That is if someone else installs their own type converter factory, even just to handle a single type that I'm not even interested in, then it would completely blow away my custom type converter factory. One workaround is that a library could need to find the current type converter factory (if any), and then if the new type converter factory didn't handle the type, it could delegate to whatever was installed before. Of course this relies on everybody following this convention, and it would break if someone tries to uninstall their type converter factory and re-install the previous one (which would blow away any later registrations).
Obviously we don't expect to have many libraries dipping in and registering type converter factories independently. However this hypothetical scenario I think illustrates that this approach has some drawbacks.
Instead of having a single get/set type converter variable, then, it might be better to keep an internal list. Users would use addTypeConverterFactory() and removeTypeConverterFatory() (or "register"/"unregister); this would simply add the type converter to a list (or a linked hash set to prevent duplicates). Then picocli could simply iterate this list backwards and choose the first non-null response from the registered type converter factories. This approach several benefits:

It plays just fine with multiple sources/libraries adding type converter factories; they don't "trample" each other. Simply the last one registered takes precedence.
You can now have different type converter factories for different types. I can have one for enums, and another for the FooBar interface. I don't have to stick all the logic in one type converter factory (which I wouldn't want to do anyway).
And this way you can actually extract the current "built-in" type conversion logic (I mentioned this in #1707) into an ITypeConverterFactory that sits at position 0 in the list—it always has the last fall-back priority, and it can never be removed. Suddenly your existing code is more modularized, more consolidated, and more elegant.

Lastly I haven't looked into what's in the ArgSpec, but if I don't need it I'm sure it doesn't hurt to pass it.

One other potential confusion (not to deter you; just to mention it) is that you'll still have the per-type registration system, and if someone registers an overriding ITypeConverterFactory it could potentially "mask" the per-type registration. It would seem obvious once someone realizes it, but you might mention it in the docs to prevent potential confusion.

Lastly I haven't looked into what's in the ArgSpec, but if I don't need it I'm sure it doesn't hurt to pass it.

From the ArgSpec, one can get the CommandSpec, which in turn gives access to everything, including the ParserSpec; this is where parser configuration settings are held, which includes things like caseInsensitiveEnumValuesAllowed, which may be relevant/necessary for type conversion implementations.
Anothere benefit of passing the ArgSpec is that it allows the factory to produce different type converters for different options/positional params, regardless of the type they are associated with.

I am not opposed to the idea of having a list of type conversion factories, with add and remove methods instead of get/set methods, iterating backwards, and having the existing logic at position 0 as the last fall-back factory.
Overall, I am having some second thoughts about this whole endeavor in the sense that it feels like a lot of infrastructure for a relatively small benefit.

Overall, I am having some second thoughts about this whole endeavor in the sense that it feels like a lot of infrastructure for a relatively small benefit.

Whatever you decide, just tell me what I need to do in my base application to convert the case of enums automatically. Currently the case of enums do not match the convention used by other parts of the application. Currently it seems to me impossible to change. I don't feel that copying and pasting essentially your entire source code just to change a line or two to effect this functionality is reasonable.
Sheesh if getEnumTypeConverter(final Class<?> type) was marked protected then I could at least subclass CommandLine (that's the class it's in, right?). But right now it's basically impossible for this functionality.
And the fact that getEnumTypeConverter(final Class<?> type) even exists is code smell indicating that there was an issue requiring a "special case" for enums in the first place.
But just tell me how to work around this. I only need to do it once. You don't have to create a new ITypeConverterFactory infrastructure if you don't want to. But we need something! Right now we've got nothing.

I will probably make getEnumTypeConverter(final Class<?> type) protected in 4.8.
And I don't agree that the existence of that method is a code smell. Enums are special because no converter needs to be registered for them, whereas all other types need type-specific converters.


allow running without securityContext.procMount=Unmasked (BuildKit v0.4)

When /proc is not mountable, img now automatically disables process sandbox (PID namespace isolation).
Note that this allows build containers to kill(2) (and potentially ptrace(2) when seccomp is unavailable) the img process.
To run img in a Docker container, you no longer need to specify --privileged, but you still need to specify --security-opt seccomp=unconfined --security-opt apparmor=unconfined (which are unconfined on Kubernetes by default).

@jessfraz @tonistiigi

@jessfraz could you take a look?

Thanks!!!


Remove websocket url from args

the websocket url arg doesn't have any effect in code

Codecov Report

Merging #815 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #815   +/-   ##
=======================================
  Coverage   60.26%   60.26%
=======================================
  Files          71       71
  Lines       12026    12026
  Branches     1907     1907
=======================================
  Hits         7247     7247
  Misses       4154     4154
  Partials      625      625

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8c10844...453e4bd. Read the comment docs.


Whether it can support the mobile GPU well?

I learned from the Adreno GPU optimization manual(https://developer.qualcomm.com/download/adrenosdk/adreno-opencl-programming-guide.pdf?referrer=node/6114):
Avoid using the function called async_work_group_copy. It is often tricky for the compiler to generate the optimal code to load local memory, and better for developers to write code that manually loads data into local memory
Can you do some special optimization for mobile GPUs?
Thanks~~

Sorry for the slow response; been on vacation.
We only use builtin async_work_group_copy(3D3D) when compiling for OpenCL; in the C version, a hand-written async_work_group_copy is used, and in fact for OpenCL builds that do not support async_work_group_copy we do similar.
See defining TTL_COPY_3D
Are you talking about not using async_work_group_copy in the OpenCL environment, if so, then I guess we need to provide some way of redirecting.
Maybe
#ifndef HostLocalTransfer
#define HostLocalTransfer async_work_group_copy3D3D
#endif
Something like this?
On the second question, what sort of optimizations? We want to keep it as something that supports a broad church, but obviously, anything that helps we would be happy to try and add.


Fix menubar widget top padding

@keybase/react-hackers Adding padding to the folders view also affected the menubar widget, which I missed in the visdiff output.  Bad cjb!

:mag_right: The commits 723d8a4a4cb0...bd3e7695fff7 introduced some visual changes:

Changed: Menubar-Public_Truncated (before) (after)

Changed: Menubar-Public_Normal (before) (after)

Changed: Menubar-Public_Menu_Showing (before) (after)

Changed: Menubar-Private_Truncated (before) (after)

Changed: Menubar-Private_Normal (before) (after)

Changed: Menubar-Private_Menu_Showing (before) (after)

👍


Waiting for a response..." times out

Waiting for response then times out.

Yes - sorry, the openai api has undergone significant changes since the last update of this package. I will try to attend to this when I can find time - but if anyone else wants to try their hand at a PR to update to the current api, it 'should' be relatively straightforward.
Thank you for the alert!


Zip not appearing on S3

From what I can gather in the docs, if I provide a s3_bucket in the config I should expect the deployment zips to be stored there. My code is deploying fine to lambda but isn't uploading to the S3 bucket.
Am I doing something wrong here or have I misunderstood what the bucket is used for?

The zip in the simply s3 bucket gets deleted by Zappa after deployment/update is finished simply to save on the cost of storing it. It's not used for anything once the function is registered. Is that a feature you need? It could be made into an optional flag I suppose but I don't see the point.

My use case for keeping them is an artefact history, like the existing flag for not deleting the local zip. Afaik you can only download the latest code bundle from Lambda, it'd be nice to have a versioned archive on S3.
Couple this with a feature I've just suggested #254, if Zappa could delete old versions I would still want a way to download old artefacts. No point rolling some custom artefact storage if Zappa is already putting them on S3 and the delete could just be disabled.

What do you need them for? I think the rollback command should work even if they're not on S3 still.

If I start deleting old versions as suggested in #254 I doubt the rollback will work.
I need them for auditing, if a package introduces a bug but the version has been deleted, it'd be easy to get a zip off s3 and ensure the package runs on lambda exactly as it did at the time. It's not the end of the world to not have it, but it'd just be a nice feature for enterprise style deployments where there are artefact requirements.

If you think this is all a bit outside the scope of Zappa it'll be easy to just upload them to S3 after Zappa is done. If you think it makes sense to have, I'm happy to put it in and make a PR.

Auditing is a great use case to consider, then I suggest that we split the current delete_zip advanced setting into delete_local_zip and delete_s3_zip, default true for both.

Also, coherent filenames for the zips -- perhaps timestamps?

I think they're already unix epoch timestamps..

Sounds perfect :)

Thanks for this suggestion and solution. As a new user, I had expected that disabling the 'delete_zip' setting would leave the .zip on S3. It took a while before I realized it referred to the local .zip - so I think splitting it into two settings makes sense.

Fixed by @mcrowson ! :D


institution_id registration of NTU

institution_id = NTU
institution = National Taiwan University, Taipei 10650, Taiwan

@rceclccr is the existing TaiESM1 registration against the AS-RCEC institution remain unchanged?

yes

@rceclccr NTU is now registered. Please take a look at CMIP6_institution_id.html and let me know of any further tweaks required

Many thanks!


[WIP] Add TSM app observability content

Closes #826
Signed-off-by: Andrew J. Huffman<EMAIL_ADDRESS>

This PR is pretty outdated at this point. With the latest redesign, don't want to risk merging. If we need to reopen, we can revisit.


docs: fix broken links closes #1779

What/Why/How?
Fixes two broken links. These links don't exist.
Reference
Closes #1779
Security

[x] Security impact of change has been considered
[x] Code follows company security practices and guidelines

I think the content does exist though? Is it that we need to update the links to point to the new locations?

Never mind, looks like we removed the information about how to get these values so I agree that there's nowhere else to link to.


Compute Engine > Numeric evaluation

It appears there's an inconsistency since the first and last lines differ. Can you clarify which one is accurate? Also expr.N().numericValue.toNumber() gives me an error saying it's not a function.

It appears there's an inconsistency since the first and last lines differ.
They differ because the input is different. The first is a numeric expression, the last is a symbolic expression. As the text above this screenshot explains:

To access a JavaScript machine number approximation of the result use
valueOf(). If numericValue is a machine number or a Decimal object,
valueOf() will return a machine number approximation. Otherwise it returns
a string serialization of the MathJSON representation of the expression.

Also expr.N().numericValue.toNumber() gives me an error saying it's not a function

It's impossible to say for sure without having access to the code you use, but that's probably because the value of numericValue is not a Decimal number. Did you try to look at that value?

numericValue.toNumber() only applies if the result is a Decimal. Again, I don't know what input you gave, so I can only speculate, but the result of your calculation appears to be a number, not a Decimal.

This is admittedly a bit tricky to do. In order to do this you would need access to the Decimal symbol representing the Decimal class. The tricky thing is that this symbol is not exported and if you imported the decimal.js library you would get a different instance with the same name, which would not work.
I'm going to add a isBignum() and isComplex() methods to the ComputeEngine class, which should solve this.

yes, but expr.isComplex and expr.isExtendedComplex indicate if the expression is in the domain of the Complex numbers. It doesn't say anything about the value of expr.numericValue. Ok, well, that's not exactly right. If expr.isComplex is true it is likely that ce.isCompelx(expr.numericValue) will be true as well, but not certain. For example, you could declare that z is a Complex number. ce.box("z").isComplex would be true, but ce.numericValue would be null, since it does not have a value.

Done in 0.12.6


Details of training P

Dear authors, Could you share some details of training P, including 1) training iteration, 2) learning rate, 3) weight initialization ?

Found in the paper :)


[FEATURE] Added new jsbase theme filled only with javascript and cha…

…nged extension of responsive theme, removed js from responsive theme
Description
Added new Theme including only the javascript files. This enhances the process of creating new themes based on responsive theme, cause you don't need to copy and paste all the JS from one theme to another.
It increases maintainability of custom themes, cause the JS will be updated from you (Shopware) and no need to recopy and paste the updates JS in own custom theme.
I also updated the karma/jasmine tests to work with the new theme and added the dev dependencies for karma, jasmine, phantomJS, ...
Branch was: https://github.com/shopware/shopware/pull/980
Now for version 5.3

Questions
Answers

BC breaks?
no

Tests pass?
yes

Related tickets?
No related ticket

How to test?
npm install in new BaseJs Theme, grunt and npm run test

@shopwareBot there is already a ticket for that. I updated the referring links
https://issues.shopware.com/issues/SW-17845.

@wolv-dev thanks for updating your contribution :+1:
the ticket seems to be planned for the next sprint :blush:

@wolv-dev Thank you for the PR! I startet testing it but received an error message in the frontend. Would be great if you can take a look at it:

@jenskueper Thanks, fixed it. And changed to 5.4

Something similar was added with version 5.4. Pull Request closed.


Videos with HDR, other pixel formats like prores and yuva444p12le are not displayed in ffplay

Today I performed a video test in AV1 and VP9 SMPTE ST 2086 HDR10.
But then I only realized that players like VLC, MPV, PotPlayer and MPC-BE perform the display quality for these pixel formats for the image.
I also realized that it is a little difficult or almost impossible to convert video formats in MP4, WebM and MKV to SMPTE ST 2085 HDR 10 color.
If possible, can you send me the code to convert the video to MP4 H.264 in this quality?
I want to use HDR10 from SMPTE 2086 but it is as a test base, and see how the images look and how much they improve.
I searched on Google, forums on FFmpeg Reddit and I did not find the solution to convert to this format of video quality and pixel.
And about prores and yuva444p12le, they also don't play in the ffplay master version that I always use to download videos with yt-dlp on Windows 11 that I use here.
My video card is an AMD R5 220, fortunately VLC and other video playback software play well, but I do believe that FFmpeg and ffplay have the best and most advanced codecs and updated versions that can play video and audio in sync in the best possible quality.
I believe it is a patch that has not yet been added to FFmpeg and ffplay to play videos in HDR, prores and yuva444p12le.
If I'm wrong, can you send me a code or give me information on how to play videos in prores and HDR SMPTE ST 2086?
For MP4, WebM or MKV video formats, which I have here.
Thanks in advance
Furthermore, I believe it is my video card that does not support HDR or prores in ffplay using Windows.
Or a patch that has not yet been released to reproduce it.
Thanks in advance.

I don't quite understand what you're asking. But it does not sound related to the builds.
Please direct usage questions to the appropiate channels, like the ffmpeg-users mailing list, or #ffmpeg on libera.chat.


I cannot reproduce the experiments due to 'No module named unimat' error, and seems there is no such a library function.

May I ask how this problem was resolved? I encountered the same error message


update sitepoint link

Q
A

Is bugfix?
❌

New feature?
❌

Breaks BC?
❌

Fixed issues
https://github.com/yiisoft/yii2/issues/19440

👍🏻


Proposal: Windows.UI.ViewManagement.ProjectionManager availability

Proposal: Windows.UI.ViewManagement.ProjectionManager availability

Summary
Allow applications written with WinUI to easily stream to other screens, using the Windows.UI.ViewManagement.ProjectionManager framework.
Rationale

Allow easy creation of apps that are capable of streaming to other screens.
If streaming to other screens through WinUI is extremely easy, WinUI could become the default choice when wanting to write an application that's capable of sharing content on a different screen.
With the addition of the MS-MICE protocol in Windows, Windows is poised to
The API and functionality already exists. It "merely" needs to be made generally available.

Important Notes

The API already exists and is documented at https://docs.microsoft.com/en-us/uwp/api/windows.ui.viewmanagement.projectionmanager .
Sample code is available at https://github.com/microsoft/Windows-universal-samples/blob/master/Samples/AdvancedCasting/cs/05_Multi_View_Media_Application.xaml.cs
However the API is limited to UWP applications.
I'm looking to implement a feature in an existing application, to make it capable of streaming parts or all of my application to another screen. It seems that the Windows.UI.ViewManagement.ProjectionManager framework is exactly what I'm looking for, however it's not possible to rewrite my application to use UWP. Instead, it would be great if this framework was available for general application use.
I am unsure whether this is the right place to raise this feature request. But, as the feature already exists inside Windows.UI, I figured it might not be far off :)

Thanks for filing this, we can certainly help route this request to the right team.

@FredeJ, thanks for filing this issue.  This class isn't part of WinUI, but since I couldn’t find a good place to route this request to, I decided to chat with some folks internally on what our plans are here.
The short answer is that ProjectionManager is actually on path to be deprecated in the future, but the functionality it provides is being planned to be built into the new AppWindow class.  When built, the plan is to provide that for Win32 apps as well—not just UWP apps.  So basically, the goal is to enable what you’re asking for, but via AppWindow.
I'll wait a bit and then close this issue down, but I'll keep it open for a bit first in case you have any other questions I can help with.

Thanks a lot for getting back to me! That certainly sounds like the right path - I'm looking forward to seeing.
Any chance you can lift the lid a little bit for when I can expect this? I get that you probably don't want to commit to a timeline or anything similar, but it would be nice to know if it's this year, for example.
From my point of view the question is: Should i wait for this to be implemented or should I explore other options?

Oh, and specifically I would want to render a 3D model. Do you know if there's any planned support for that?

Oh, and specifically I would want to render a 3D model. Do you know if there's any planned support for that?

Check out #686.

@FredeJ Yeah, I definitely don't want to commit to a timeline (and actually, it's not even my timeline to commit to since I don't own this :)  My best guess is sometime next year--that is a guess, and not a particularly informed one.
Definitely check out #686 though, as Jevan linked.  (@GeorgeS2019 might be able to provide an update on how that is progressing over on that issue)

There has been progress made with #686. Members who are interested on gITF 3D model viewer do contribute new issues to #686


Implement BlockArray(::PseudoBlockArray) and vice versa

These would be useful to convert between the two formats.

Should be almost trivial. I'll try do it on the plane :)


where is the BasketballDrive_1920x1080_50.yuv

where can i find BasketballDrive_1920x1080_50.yuv to make data

The sequences come from the standard community. The official material can refer JVET-Z0004 (https://jvet-experts.org/doc_end_user/current_document.php?id=11537).


Lines prop takes up more space than it needs in Text component

First of all, I'd like to thank you for all the hard work on smooth-ui. It's one of my favorite component libraries!
🐛 Bug Report
<Text lines={10}>
  Short text fitting in one line
</Text>

Is taking up 10 lines of space. Most of which are rendered as white space.
To Reproduce
Go to the docs and increment the value of the lines prop. You'll see white space being added.
In the example from the docs, two lines look great.

When incrementing the value, more whitespace is added.

Expected behavior
I expected the line prop to only take up as much space as the text needs or cut it off.
Env
"@smooth-ui/core-sc": "^11.1.5",

## System:
 - OS: Windows 10 10.0.17763
 - CPU: (12) x64 Intel(R) Core(TM) i7-8700 CPU @ 3.20GHz
 - Memory: 18.50 GB / 31.92 GB
## Binaries:
 - Node: 12.9.1 - C:\Program Files\nodejs\node.EXE
 - Yarn: 1.22.0 - C:\Program Files\nodejs\yarn.CMD
 - npm: 6.10.2 - C:\Program Files\nodejs\npm.CMD

This is the expected behaviour. If you specify a number of lines it measure the number of lines. It is not possible to implement what you are asking for without JavaScript. You should probably use a library to crop text and add ....

<Text> is a React component so adding some more JS shouldn't be a problem.

@CodingDive yeah if it is perf I am open for a PR to fix it!


Version Scheduling Goals and Conditions

Tickets addressed: Closes #1277
Review: By commit
Merge strategy: Merge (no squash)

Description

Sister PR to #1278.
Overview of changes:

The Scheduling Conditions table has been split into a metadata and definitions table. BREAKING CHANGE
Likewise, the Scheduling Goals table has been split into a metadata and definitions table. BREAKING CHANGE
Definitions are only editable by admin users.
Public and private toggles have been added. See #1278 for a breakdown of what this toggle does
A model spec for conditions and goals has been added. Because this spec does not require tracking additional metadata, there are only two associations. A model specification is a recommended set of goals/conditions and their versions for all plans using the model. Unlike in constraints, plan scheduling specs are not prepopulated due to being unable to know what a plan's model is. This can be resolved after #1311 is completed.
Scheduling Requests now record additional scheduling spec data in order to mirror Simulation Requests. Additionally, analysis_id has been officially made the pkey. This column has been a unique identifier for a while but was not officially changed until now.
The unusable "InMemoryStore" configuration has been removed. This code is completely unsupported, and the Scheduler uses a separate Mock implementation for tests.
The Scheduling Services have been simplified. Specifically, SpecificationService and SchedulerService have been flattened to their single real implementation, which defers to the implementation of their repositories. Additionally, some tweaks have been made to the PostgresRepository implementation to remove some unneeded calls to the DB.

Verification

DB Tests and Scheduling E2E Tests were updated to reflect the schema changes and for simplification.
SchedulingTests for versioning and enabling/disabling goals were added
Documentation

Docs ticket to be created
Future work

After #1311 is completed, add a prepopulate trigger for plan specs.

Change pushed adds priority to the model goal spec, as per discussion with @dandelany

Changes pushed were both metadata, specifically:

There was an analyses relationship from Goals to the Goal Analysis table that was skipped when writing the new metadata for the split goal tables. This relationship has been restored.
Back in #711, the relationship from Plan to Scheduling Specifications went from an array to an object relationship, but the metadata was not updated. Because this PR specifically is for updating the Scheduling Specification, I have included fixing this relationship here, however, I am fine moving this change to its own PR, as it technically does not depend on anything here and is breaking.

👍 finished testing the UI with @duranb - merging this and aerie-ui/1149 together.


[Usability issue] Highlighted and completely selected strings have the same highlighting color

VSCode Version: Code 1.13.0 (376c52b955428d205459bea6619fc161fc8faacf, 2017-06-08T16:43:13.058Z)
OS Version: Windows_NT ia32 6.1.7601
Extensions: disabled

Steps to Reproduce:
GIF
https://user-images.githubusercontent.com/8361299/27085882-347ad584-5059-11e7-96bf-ff978954e4a8.gif

find some text
go to result
Click on search request and drag the result. It is graggable, because result is selected.
The color, which is used for selection and highlighting is the same. It is impossible to discern the difference in these cases.
Please fix it.

Which theme are you using?

Hi
Any default theme. For example Dark(Visual Studio)
Highlighting is not overridden by text selection.

the issue is solved by new high contrast theme.
But in anyway you can change text selection(partial) color for highlighted text.
What I mean:

@Alex-302 I don't know who is the author of the blue background theme you show above (perhaps try to contact them?), but the root cause is that the theme defines a find match color that is opaque, instead of using some transparency.
I can look into rendering the selections always on top of the decorations, but the theme author needs to account for multiple decorations being superimposed and consider using non-opaque colors.

@alexandrudima Hi. I tried all default themes. I don't remember about blue, but it has the same issue I don't use it at the moment.

I can look into rendering the selections always on top of the decorations

I hope you fix it) High contrast theme works good(look at the screenshot above), but it is too contrast for me)

Same problem with Dark+ theme.
Steps:

Create new file with content:
//
test
test
test
//
Press Ctrl-F and enter "test"
Select middle "test" word (Double click on it)

Expected: Selected text has another color, than others.
Actual: Selected text has almost same color compare to others. Try to detect where is selection? :)

All our built-in themes use transparent colors for editor decorations by design. If one customizes the color scheme and choses opaque colors the decorations will be rendered on top of each other.
@aeschli Is there a way to show warnings in the settings where opaque colors are defined for editor decorations ?

@alexandrudima
// Place your settings in this file to overwrite the default settings
{
    "editor.insertSpaces": false,
    "editor.detectIndentation": false,
	"editor.renderIndentGuides": false,
	"editor.autoClosingBrackets": false,
	"editor.minimap.enabled": false,
	"workbench.editor.tabCloseButton": "off",
	"workbench.editor.closeOnFileDelete": false,
	"search.useIgnoreFilesByDefault": true,

    "git.confirmSync": true,
	"git.enableSmartCommit": true,

	"gitlens.defaultDateFormat": "YYYY-MM-DD HH:mm",
	"gitlens.codeLens.enabled": false,
	"gitlens.blame.line.enabled": false,
	"gitlens.annotations.file.gutter.format": "${message|40?} ${date}",
	"gitlens.annotations.file.gutter.hover.details": false,
	"gitlens.annotations.line.trailing.format": "${author} • ${date} • ${message}",
	"gitlens.statusBar.format": "${author}, ${date}",

	// for PHP validator
	"php.suggest.basic": false,
    "php.validate.executablePath": "D:/max/programs/EditPlus/tools/bin/php/php.exe",

	// for Python
	"python.linting.pylintArgs": ["--indent-string=''"],

	// Powershell Git-posh:
	// Setup permissions: Set-ExecutionPolicy RemoteSigned -Scope CurrentUser
	// Install Git-posh: Install-Module posh-git -Scope CurrentUser
	// Update Git-posh: Update-Module posh-git
	"terminal.integrated.shellArgs.windows": [
											"-NoExit",
											"-Command", "Import-Module posh-git"
											],
	"search.exclude": {
		"**/node_modules": true,
		"**/bower_components": true,

		"**/*.2remove/": true,
		"**/*.2remove.php/": true,
		"**/!prev/": true,

		"direct/static/css/*.css": true,
		"direct/static/js/*.js": true,
		// temp files after merges
		"*.orig": true,
		// ignore all tmp/ except some files.
		// if use /tmp/* or /tmp/** will be ignored exclude also :/
		"tmp/**/*": true,
		"admin/tmp/**/*": true,
		".encoding/temp/**/*": true,
		".encoding/bin/openssl/.rnd": true
	},

	//"editor.disableMonospaceOptimizations": false,
	"workbench.startupEditor": "newUntitledFile"
}

@alexandrudima We could add a validator to the color definition to warn users. Please file a feature request, ideally with the list of colors that need transparency ;-)

@SailorMax it doesn't look good, but the color is different:

#6D4B37 vs #665350

@alexandrudima
I did not say the color is same:

Selected text has almost same color compare to others.

It hard to recognize.

I believe this has been improved (by someone else) in the meantime.
#603219 vs #655350
These colors can be tweaked via user settings if necessary e.g.:
    "workbench.colorCustomizations": {
        "editor.findMatchBackground": "#ff0000",
        "editor.findMatchHighlightBackground": "#ff0000",
        "editor.selectionBackground": "#ff0000"
    }


Docker container logs

Is there a possibility to send only the logs from a specific docker container to telegram with logram?
Thank you!

This is not currently possible, but I will get around to implementing it in the short term.
Thanks for this feature request!

Nice, thank you for the fast reply and for sharing this project!
In the meantime i worked around it by sending the docker logs for that particular container to journald and logram picked them up.


openssl engine command example does not parse

Found in  OpenSSL 1.1.1a
The example provided README.ENGINE for probing the list of command by "foo" engine does not match the parsing code.
Provided example is
openssl engine -vvvv dynamic
...

While a command that actually works has the order changed
openssl engine dynamic -vvvv
...

Reproducing the problem requires an engine, for example tpm2tss.
Fix Notes
Fix should either

Change the example command and the usage of openssl engine -help consistent with the parsing code.
Change parsing code to be consistent with example command and usage.

Can't say which option is correct.

I checked that with 1.1.1d just now, and it accepts both variants.


Path for cd32 chd files

Hi,
Thank you for maintaining this project.
I have a question which is not really clear in the documentation, but where do we put the cd32 chd files? I'm using a MiSTer.

Wherever you want. MiSTer defaults to the games/Amiga directory when you mount a disc, but e.g. I put mine in a separate  AmigaCD32 directory.

Since you have a file browser in the drive select dialog, you can put them anywhere you want.


[.NET] ActivityWatcher.GetServerLocation() Http optimization

Changed GetServerLocation() to only make a single request to ipinfo.io to retrieve the needed location information

@bluepilledgreat Did we already know about this? I could've sworn there was a reason we avoided using this when we first implemented it.

@bluepilledgreat Did we already know about this? I could've sworn there was a reason we avoided using this when we first implemented it.

¯_(ツ)_/¯

Please actually bother to build and test the build or I'm closing the PR.

I'm currently doing that

Looks good, let me make some more changes.

Looks good, let me make some more changes.

Have you tested it?

Yeah, it all works.


php: add support for configuration via environment variables

I've three notes. Firstly, I want to mention that the project structure looks like a mess because the tests are separated into their own files. Unlike other examples, I can't store all the tests in a single file, see https://github.com/sebastianbergmann/phpunit/issues/4105 ¯\_(ツ)_/¯. Secondly, the test recipe is slightly incorrect due to the project structure. I'll "fix" it later. Thirdly, I've kept the previous implementation of the configuration manager because of the formats. I've another task related to this, so I'll take care of it later.

Pending #423, but is ready to be tested, if #423 isn't in question.

Pending #423, but is ready to be tested, if #423 isn't in question.

I have a warning on the main page: Deprecated: str_ends_with(): Passing null to parameter #1 ($haystack) of type string is deprecated in ...\php-integration\common\URL.php on line 112.  I used PHP 8.1.
And i still got warning filemtime(): stat failed for ...\php-integration\storage\<IP_ADDRESS>\new.docx in C:\OpenServer\domains\php-integration\functions.php on line 505 when i try to create a new file.

I have a warning on the main page: Deprecated: str_ends_with(): Passing null to parameter #1 ($haystack) of type string is deprecated in ...\php-integration\common\URL.php on line 112. I used PHP 8.1.
And i still got warning filemtime(): stat failed for ...\php-integration\storage\<IP_ADDRESS>\new.docx in ...\php-integration\functions.php on line 505 when i try to create a new file.

The first one is my mistake. PHPUnit didn't display deprecation messages by default, so I didn't notice it while running the tests. Fixed it.
Regarding the second one, it seems that the error occurred in the tryGetDefaultByType function. The function itself appears to be fine, so the issue might be with the submodules in the assets directory. May you please check if they are outdated or empty? If they're, please reinitialize the submodules and retry to create a new file.

The first one is OK now, no more deprecation messages.
About the second. Assets are in place, as in other examples using this submodules, I added them. It seems this error only occurs when we don't initially select a user and there is no fileExt in the request. But this already looks like a separate PR, I guess.