Add a sql LIMIT clause for acquire next triggers

In the case where database has a lot of soon-to-be-fired-jobs, the query can be slow as it needs to do extra sort by next_fire_time, priority, the sql LIMIT clause should enable database to be more efficient.
In submitting this contribution, I agree to the current Software AG contributor agreement as referred to here:
https://github.com/quartz-scheduler/contributing/blob/main/CONTRIBUTING.md
This PR...
Changes

Checklist

[x] tested locally
[ ] updated the docs
[ ] added appropriate test
[x] signed-off on the above mentioned SoftwareAG contributor agreement via git commit -s on my commits.
(If you're not using command-line, you can use a browser extension )

Fixes #

Not all databases support LIMIT, MS SQL Server for example.
In .NET version we override in delegate and add suitable extra: https://github.com/quartznet/quartznet/blob/28b5faec68aa7f3227b3e744780617ada0f0eb6f/src/Quartz/Impl/AdoJobStore/SqlServerDelegate.cs#L37

@lahma Thanks! I've no knowledge of MS SQL Server, I've updated PR to only apply LIMIT for Postgres

@jhouserizer can you check if this change makes sense when you have some time?


feat(metal-lexer): Implement metal-lexer.

#9  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @elenakrittik and the rest of your teammates on  Graphite


PyTorch op_context support

https://github.com/pytorch/android-demo-app/blob/master/PyTorchDemoApp/app/src/main/assets/mobilenet_v2.pt
https://github.com/pytorch/android-demo-app/blob/master/PyTorchDemoApp/app/src/main/assets/resnet18.pt

resnet18.zip


not working with new versions

Hi,
for a code/repo example I can provide this blog post:
https://medium.com/@zeeshanalamkhan/integrating-hashicorp-vault-with-spring-boot-2-x-7a1be1365d8b
I tried to use example from https://docs.spring.io/spring-cloud-vault/docs/current/reference/html/#quick-start but I see it uses 2.4.0.RELASE which does not exists in mvnrepository.
in short it works fine with older versions of spring-boot-starter-parent ie: 2.13.2.RELASE but not for 2.6.4,
( also there is upgrade needed for spring-cloud 2021.0.1 otherwise we have errors: Caused by: java.lang.NoClassDefFoundError: org/springframework/boot/context/properties/ConfigurationBeanFactoryMetadata )
but well in short, 2.13.2.RELASE -> 2.6.4 and Hoxton.SR12< -> 2021.0.1, no code, config changes at all, just upgraded libs. And I get nulls instead of real values.
Not sure if its a bug, maybe there is needed some other change in code/config.
If you could help me, please.
thanks!

Hi there,
We ran into the same issue. Most of the examples out there were done with releases before 2.4. With 2.4 there was a change regarding properties processing. See https://github.com/spring-projects/spring-boot/wiki/Spring-Boot-2.4-Release-Notes#config-file-processing-application-properties-and-yaml-files .
We switched to spring.config.import and then it works as expected.
application.yml example
spring:
  cloud:
    vault:
      uri: https://<vault_fqdn>
      authentication: TOKEN
      token: s.XXXX
      fail-fast: true
      kv:
        enabled: true
        backend: <backend-mount-path>
        default-context: <path-to-secret>
  config:
    import: vault://

I just wanted to share this because I suspect you and probably others are struggling with it. I'm not a developer and the solution may not be perfect, but it works.


ci: try gosec

Description
What does this PR do?
Purpose
Why is this PR important?

This has been a draft for a while. Is it still relevant, @jgimeno?


cleanup of readme (issue #53)

reformulation of readme, adding TOC
adding a markdown file with properties from the ontology for easier inspection

@cysouw Which browser did you use to visit http://cldf.clld.org/v1.0/terms.rdf ? At least with firefox the linked XSLT stylesheet will be used to render the Ontology as HTML page, which is at least half-way to your properties.md. I'm still not against including this additional file here, but ideally it - at least the property list - should be created automatically from the Ontology.

Oh, that is neat! Chrome and Safari both just download the ref-file, so that is not helpful. But this view of Firefox is really great! Yes, you can just remove the properties.md again, and make a note in the readme to view the terms.rdf with Firefox.


⚠ Bofrost.de has degraded performance

In 8e697c6, Bofrost.de (https://www.bofrost.de) experienced degraded performance:

HTTP code: 200
Response time: 1099 ms

Resolved: Bofrost.de performance has improved in db0c798.


Skeleton fallback loading component and Error Status Icon state

New

<Skeleton>

Basic loading component that can be configured with a width and height, custom class and includes a "circle" variant for status icon placeholders.

Added "error" status to ProjectStatusIcon. When status="error" the icon will display as a red exclamation point in the list and toolbar.

Changes

Added fake "loading" timers to IllustrationList and ProjectToolbar just to test the loading skeleton.
The skeleton for ProjectList works correctly since there is a buffer between loading the archive list.

Fixes

action.getProjectsArcive() now properly filters out local projects for its list
<ProjectList> state now only sets itself from projects since it will always be an array

Added to #73


Add UCSE model, converter and integration test

Pull Request summary:

Add UCSE model
Add UCSE Converter
Add integration test

Description of changes:
[Add more in depth analysis of what changed, provide logs, examples of usage]
Checklist:

[X] Make sure to run pre-commit before committing changes
[X] Make sure all checks have passed
[X] PR description is clear and comprehensive
[X] Mentioned the issue that this PR solves (if applicable)
[X] Make sure you test the changes

This issue was migrated from an old repository: https://github.com/CiscoDevNet/catalystwan/pull/518


bug: Error when open ask window

Describe the bug
When opening the ask window (by the default keybinding aa) I get this error:
Error detected while processing ModeChanged Autocommands for "*:i":
Error executing lua callback: deserialize error: missing field `filepath`
stack traceback:
        [C]: in function 'render_mode'
        ...an/.local/share/nvim/lazy/avante.nvim/lua/avante/llm.lua:58: in function 'generate_prompts'
        ...an/.local/share/nvim/lazy/avante.nvim/lua/avante/llm.lua:120: in function 'calculate_tokens'
        ...local/share/nvim/lazy/avante.nvim/lua/avante/sidebar.lua:1836: in function 'show_hint'
        ...local/share/nvim/lazy/avante.nvim/lua/avante/sidebar.lua:1891: in function <...local/share/nvim/lazy/avante.nvim/lua/avante/sidebar.lua:1889>

This error also re-occures on every keystore in the chat window.
To reproduce
This is my config:
  return {
    "yetone/avante.nvim",
    event = "VeryLazy",
    lazy = false,
    version = false, -- set this if you want to always pull the latest change
    opts = {
      provider = "claude",
      claude = {
        api_key_name = { "cat", "/home/nathan/.ANTHROPIC_API_KEY" },
      },
    },
    -- if you want to build from source then do `make BUILD_FROM_SOURCE=true`
    build = "make",
    -- build = "powershell -ExecutionPolicy Bypass -File Build.ps1 -BuildFromSource false" -- for windows
    dependencies = {
      "stevearc/dressing.nvim",
      "nvim-lua/plenary.nvim",
      "MunifTanjim/nui.nvim",
      --- The below dependencies are optional,
      "nvim-tree/nvim-web-devicons", -- or echasnovski/mini.icons
    },
  }

This is used within  a lazyvim setup.
Expected behavior
No error should appear.
Installation method
Use lazy.nvim:
{
  "yetone/avante.nvim",
  event = "VeryLazy",
  lazy = false,
  version = false, -- set this if you want to always pull the latest change
  opts = {
    -- add any opts here
  },
  -- if you want to build from source then do `make BUILD_FROM_SOURCE=true`
  build = "make",
  -- build = "powershell -ExecutionPolicy Bypass -File Build.ps1 -BuildFromSource false" -- for windows
  dependencies = {
    "nvim-treesitter/nvim-treesitter",
    "stevearc/dressing.nvim",
    "nvim-lua/plenary.nvim",
    "MunifTanjim/nui.nvim",
  },
}

Environment
NVIM v0.10.2
WSL2
LazyVim
Repro
No response

Removing my lazyvim installation and all plugins and re-installing fixed it.


How to run the container as root?

I tried -u root but not working.

You can set the USER_ID and GROUP_ID environment variables to 0.  ID 0 is root.


feat: add pass to lower asm instructions to ISema

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

152 of 166 (91.57%)  changed or added relevant lines in 12 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.9%) to 91.187%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

core/src/builder.rs
22
23
95.65%

tools/src/opt.rs
4
6
66.67%

core/src/region.rs
37
40
92.5%

core/src/operation.rs
18
26
69.23%

Totals

Change from base Build<PHONE_NUMBER>:
0.9%

Covered Lines:
2204

Relevant Lines:
2417

💛  - Coveralls


feat: added library methods for conformance testing

@ddelgrosso1 I still have to address the noted TODOs, but I would love an initial review on this.

Lint check is failing because these functions aren't called yet. There will be a separate PR for that implementation.

Took a look through and it looks like a solid start. Nothing stood out as note worthy to me.


⚠ Bofrost.at has degraded performance

In b49c9ce, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 1858 ms

Resolved: Bofrost.at performance has improved in c0f0c22.


[path_provider] Log errors in the example

When exceptions happen, they are silently dropped and do not show up in the logs (flutter/flutter#66593).
This PR prints them out to the console so that we can understand what went wrong.

@TimWhiting can you please take a look at this :)

Hi @jiahaog
I'm not a member of the flutter team, but did help with the linux implementation and example for this plugin.
I would defer to them for what they want to do with this.
The reason why I implemented it this way was because if one call throws then the rest won't execute leaving the other strings as null. I'm pretty sure it is best practice to catch errors rather than letting them crash leaving null scattered through the app. And we should encourage plugin users to catch errors so they don't run into problems like I mentioned with not initializing something because an error was thrown before it got to that point. However, instead of just assigning an error string in the catch block we could catch each error and then rethrow the last error at the end of initialization if there was an error. But I'm not sure the best way to handle this.

Thanks, that makes sense. I think to keep things simple we could also print the error to the console instead of just dropping it, I will send an update for this 🙂

@stuartmorgan can you help to take a look at this?

Updated the description. I don't think this will require a version update - if I understand correctly the example code is not shipped to users on pub. What do you think?

What do you think?

As I said, I don't know what the repo policy on that is. Someone more familiar with flutter/plugins will need to weigh in.

Checked with @cyanglaz and we need to update the version and changelog, so did that.

Thanks!


Add-SPOMasterPage Issue in 2.1.1602.0

Error when calling "Add-SPOMasterPage" with the following syntax in 2.1.1602.0.
Code was working in 2.0.1601.0
Add-SPOMasterPage -SourceFilePath "./common/common.master" -Title "Common" -Description "Common Master Page"
Error:
format-default : The collection has not been initialized. It has not been requested or the request has not been executed. It may need to be explicitly requested.
    + CategoryInfo          : NotSpecified: (:) [format-default], CollectionNotInitializedException
    + FullyQualifiedErrorId : Microsoft.SharePoint.Client.CollectionNotInitializedException,Microsoft.PowerShell.Commands.FormatDefaultCommand

Hi Mike,
You might notice that the actual cmdlet still work, regardless of the confusing error message. This is the same as reported here: #235 .
I propose a temporary solution in the replies there, and it's fixed in the upcoming release of the cmdlets (we will release a new version within a few days).

Thanks Erwin! Apologies for the duplication. I thought I did a search before I posted. The command does work but it stops any following commands from executing. I'll try the temp solution.
Cheers!


is it possible to build neural network with linfa?

I want to build and train a neural network  through gradient descent but with very flexible structure, Is it  possible to be with Linfa?

We only support classical ML methods, such as linear regression and logistic regression, not deep learning methods. This means neural nets are out of scope for this project.


Task 10, 11 completed

@Sachinrawal1109
Task -10
Code verified.
Task -11
Please review the file as it contains multiple workflows in UiPath.
Task -12
Code verified.
Task -13
Code verified.
Task -14
The file is not available in this PR

@Sachinrawal1109
It seems that there are conflicts in this pull request. Please review and resolve them
Task -11
Code verified. Execution Error.
Task -14
Code not available in this pr
Task -15
Code verified.
Task -16
Code verified.
Task -17
Code verified.

@Sachinrawal1109
Task -18
Code verified.
Task -19
Code verified. Default activity names

Task -20
Code verified.


Have a test/GHA to know when to remove hardcoded exceptions in pwrules

We might want to have a negative test that tests that json.NewDecoder fails when decoding the buggy entries in the password rules list, so that once it won't fail any more we'll be able to remove the hardcoded exceptions.
Sadly we might not want to download the file each time we run the build / test framework, so maybe it would be best to have a dedicated GHA that runs once in a while (maybe at each release?) to test that the hardcoded exception are still needed?
That would probably require another helper go program/test, along with a dedicated Github Action.
Originally in https://github.com/gopasspw/gopass/pull/2052#discussion_r760397168

Actually I think this should be fixed at the source, I have filed https://github.com/apple/password-manager-resources/issues/548 to suggest some improvements to their tooling.

Good point, let's track it here then. In the worst case we can do as proposed above.

We don't have a test but the upstream issue was fixed and I removed the workaround.


BulkWrite operations fails on references with extra fields

This was previously reported in alcaeus/mongo-php-adapter#101. Doing a BulkWrite update with certain documents causes the following warning: mongoc: WARNING > mongoc_bulk_operation_replace_one(): replacement document may not contain $ or . in keys. Ignoring document..
Looking into the error I've found that this occurs when doing a bulk write containing a reference that has an extra field before $ref:
$filter = ['x' => 11];
$replacement = ['test' => ['type' => 'test', '$ref' => 'collection', '$id' => 2]];

$operation = new ReplaceOne($this->getDatabaseName(), $this->getCollectionName(), $filter, $replacement);

This error does not occur when passing the extra field in the DBRef document at the end, e.g. ['$ref' => 'collection', '$id' => 2, 'type' => 'test'].
On the other hand, doing the very same thing in an update operation does not cause this error, the update goes through just fine. I'll be adding a pull request containing three tests for the scenarios: replace with an extra field after the reference, replace with an extra field before the reference and an update with an extra field before the reference.

Per the DBRef documentation:

The order of fields in the DBRef matters, and you must use the above sequence when using a DBRef.

Also, there is this definition from SERVER-12263:

DBRefs are objects whose first two fields must be $ref and $id (in that order). An optional $db field, if present, must appear third. Other fields may follow (they can't have a $ prefix, of course).

That said, I'm not sure why the server seems to allow this:
> db.foo.insert({_id:1})
WriteResult({ "nInserted" : 1 })
> db.foo.update({_id:1}, {$set:{ref:{a:"a","$ref":"b","$id":"c"}}})
WriteResult({ "nMatched" : 1, "nUpserted" : 0, "nModified" : 1 })
> db.foo.find()
{ "_id" : 1, "ref" : { "a" : "a", "$ref" : "b", "$id" : "c" } }
> db.foo.update({_id:1}, {$set:{ref:{"$ref":"b","$id":"c","a":"a"}}})
WriteResult({ "nMatched" : 1, "nUpserted" : 0, "nModified" : 1 })
> db.foo.find()
{ "_id" : 1, "ref" : DBRef("b", "c") }

The exception is most certainly due to the C driver's bson_validate() function, which walks a document before serializing it for a CRUD method. IMO, the validation is correct and drivers/applications should not be creating these malformed DBRef documents.
Is ODM creating these out-of-order values?

We create references with https://github.com/doctrine/mongodb-odm/blob/master/lib/Doctrine/ODM/MongoDB/DocumentManager.php#L667
We create them in order as far as I can tell.

It appears that it is actually our test that is broken. We have a test where the reference is manually created and it is created out of order.

Is ODM creating these out-of-order values?

From what I can tell, ODM creates them in the correct order, also mongo-php-adapter just loops over the document for conversion purposes, so no re-ordering should occur there.

IMO, the validation is correct and drivers/applications should not be creating these malformed DBRef documents.

Reading the DBRef documentation, this is indeed the case but seems to not be applied to documents being inserted or updated with update operators. If the exception occurs on replace, it most definitely should also occur on inserts and updates as well.

Based on @jwage's response above, this was caused by a test creating an invalid DBRef document. It's unfortunate that the server doesn't consider such documents invalid for insert/update, but I don't fault the driver here. This was only picked up because we need to check that BSON documents do not contain $-prefixed keys for replacement arguments (to comply with our CRUD specification). I've opened SERVER-23786 to request that the server start checking for this.

Great, thanks @jmikola!


non-deterministic check for signal external workflow

the non-deterministic check does not check for DecisionTypeSignalExternalWorkflowExecution so any code that send signal will fail in replay. This fix that.  Also relax the check for RequestCancelExternalWorkflowExecution to not check on the RunID.

Coverage decreased (-0.2%) to 67.134% when pulling 63bcbc883ce3dd3347e225db506b0f9dd833a56a on yiminc:replay_check_signal into 570324de7bb1008983846c97ee4d80d24e277854 on uber-go:master.


lexical semantics tasks

https://aclanthology.org/P16-1226.pdf
https://arxiv.org/pdf/1608.05014v3.pdf
https://aclanthology.org/N18-2035.pdf
https://aclanthology.org/P18-1111.pdf
https://arxiv.org/pdf/2004.14979.pdf

I'll try to create tasks from these papers.


segfault after ctrl+c

latest dev 31-august-24
https://discord.com/channels/435943710472011776/882956631514689597/1279224808248180809
his system appears to be a mac with apple silicon, he didnt experience this with the latest stable release on the releases page

cant replicate


Test version of diffusion kernel ported with GridTools.

Initial portation: experimental version.

Special cases not included
Results not verified

Checked!


[Bug] Dashboard cannot display metric values

Search before asking

[X] I had searched in the issues and found no similar issues.

What happened
I upgraded streamx to version 1.2.4 (build from dev) today, and replaced the 1.2.3 (release-1.2.3) yml with the current version to start, and found that some metric values on the dashboard could not be displayed, and the values in the http interface were all zero.
StreamX Version
1.2.4(dev)
Java Version
1.8
Flink Version
1.13.6
Scala Version of Flink
2.12
Error Exception
I added a few lines of logs to the FlinkTrackingTask.java. After recompiling and starting, I found that there were applications data in TRACKING_MAP before executing stopTracking. After executing the stopTracking method(), TRACKING_MAP was emptied, and in the schedule tracking method, TRACKING_MAP is always Empty, the application cannot get the latest status and the dashboard can not display the metrics.

Screenshots

Are you willing to submit PR?

[ ] Yes I am willing to submit a PR!

Code of Conduct

[X] I agree to follow this project's Code of Conduct

fixed.


WikiFile: add getAnon method

I discovered by chance that for a file uploaded by an anonymous user, an extra anon flag is returned with the imageinfo properties by the MW API. It indicates that the user field, containing the IP address, is not a username resembling an IP but an actual anon IP. The getAnon method should make this flag accessible to WikiFile users.

See #80.


Error compiling on Ubuntu 18.04 and likely earlier

When compiling under Ubuntu 18.04 I received the following error:
src/main.cpp:143:110: warning: format not a string literal and no format arguments [-Wformat-security]
){macrobacktrace();error_at_line(status,errnum,FILE,LINE,VA_ARGS);}
Not being real familiar with c++, I did some searches and found that I needed additional command line options.   I compiled it with the following and everything seems to work:
g++ src/main.cpp -std=c++17 -lcurl -lpthread -Wno-error=format-security -Wno-format-security

@markmay76  hmm, interesting, can you post the full output of g++ ? also please post the output of g++ --version

Full output of g++
mmay@panther:~/cacdrive$ g++ src/main.cpp -std=c++17 -lcurl -lpthread
src/main.cpp: In function ‘void cac_update_sectorcode(FILE*, uint64_t, const string&)’:
src/main.cpp:143:110: warning: format not a string literal and no format arguments [-Wformat-security]
){macrobacktrace();error_at_line(status,errnum,FILE,LINE,VA_ARGS);}
^
src/main.cpp:2545:3: note: in expansion of macro ‘myerror’
myerror(EXIT_FAILURE, original_errno,
^~~~~~~
mmay@panther:~/cacdrive$
The output of g++ --version
mmay@panther:~/cacdrive$ g++ --version
g++ (Ubuntu 7.3.0-16ubuntu3) 7.3.0
Copyright (C) 2017 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.  There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
From what I found online, I believe this change is something Ubuntu does different from the normal default.  I'm not familiar enough with c++ to track it down, but might be worth mentioning in case others run into it.

@markmay76 can you run git pull  and re-run g++ src/main.cpp -std=c++17 -lcurl -lpthread   and see if it still complains?

That solved it.
Thanks for writing this.  It is an interesting way to use some of the
storage space.
Thanks
Mark
On Thu, Sep 13, 2018 at 2:51 PM divinity76<EMAIL_ADDRESS>wrote:

@markmay76 https://github.com/markmay76 can you run git pull and re-run g++
src/main.cpp -std=c++17 -lcurl -lpthread and see if it still complains?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/divinity76/cacdrive/issues/2#issuecomment-421113310,
or mute the thread
https://github.com/notifications/unsubscribe-auth/APmMo6OENyA9fxyklyN_1L3fsSCXqLxZks5uaqk7gaJpZM4WneG0
.


Identity crashes when Google Play Services is out of date

Was just playing with this and it works fine. Likely issues were due to building with ANT instead of Gradle.


SQL : Print Prime Numbers

Write your MySQL solution to this problem of hackerrank :-
Problem link : Print Prime Numbers

hey @Riddhi9570 i want to work on this issue, pls assign me this

Hey @Riddhi9570 please assign me this issue ,If it is not solved yet!

Hello @Riddhi9570, If you are still accepting, Please assign me this issue, I will solve it in the optimized way than the current one, Assign me under hactoberfest


Setting root FMOD directory doesn't support parent directories.

When I attempt to set the main directory on AudioMgr.Init(), it appears to ignore relative parent paths, such as ".."
So when attempting to set the parent folder above where the exe is stored to be the main path it fails:
AudioMgr.Init(".."). It also appears to not support specific paths, like "C:\My Projects\Content".
Any insight on how to work through this would be appreciated!

It seems root path is passer to monogame's TitleContainer class.  But I dunno, why would you want to use an absolute path or a parent directory of your game as a root?

Gonna close this one, since there is nothing I can do about it, and it seems like a weird usecase. :V


VM dart:io connection failed SocketException reports unhelpful port number

Dart SDK version: HEAD/google3
import 'dart:io';

void main() {
  Socket.connect('localhost', 55432);
}

Expected: SocketException with port 55432
Actual behaviour: looks like it reports the send port, not the target port; so we get a SocketException with random port.
In debugging some end to end tests this send us on a long detour where we couldn't figure out why the test was trying to connect to a seemingly random port--when in fact it was trying to connect from a random port, and knowing the target port would have helped a lot :)
Thanks.

This is a duplicate of #12693, quite the old bug. I began fixing it in https://dart-review.googlesource.com/c/sdk/+/127465 but never found the cycles to get over the finish line with the breaking change request.

@sortie do you have cycles to take your CL thru the review and breaking change process and land it or do you want somebody else to takeover and work on it ?

closing this as a duplicate of #12693


Add authentication system using Clerk

Description
This PR implements a complete authentication and registration system using Clerk. Key features include:

Clerk Provider: Added to manage user authentication and registration flows.
Middleware for Protected Routes: Ensures only authenticated users can access specific routes.
User-Specific Dropdowns: Displays different navigation options for guests and logged-in users.
Logout Functionality: Enables users to securely log out of their accounts.

Type of Change

[x] New feature
[ ] Bug fix
[ ] Refactor
[ ] Documentation update
[ ] Other (please describe):

Checklist

[x] My code follows the project’s coding style
[x] I have performed a self-review of my code
[ ] I have added tests that prove my fix is effective or that my feature works
[x] I have updated the documentation as necessary
[x] My changes generate no new warnings or errors
[x] I have checked my code and corrected any misspellings
[ ] Any dependent changes have been merged and published in downstream modules

Related Issues
No related issues.
Additional Information
None.

:tada: This PR is included in version 1.10.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Valentina for browser global

Currently, this library only works with CommonJS and ECMAScript modules, but it should also support exporting to browser global, for people who are unable to use neither CommonJS, nor ECMAScript modules

This is just overkill.


[Bug]: unable to install requirements from requirements.txt

What happened?

requirements.txt available in same directory, still python unable to install it
using python 3.10
Expected Result
will install all requirements
Branch
master/main
What operating systems are you seeing the problem on?
Windows
Relevant log output
No response
Other information
No response

Hello,

you have 2 "\" in your path
execute this in real console, not in visual studio code, the VSC console is isolated from the system in a way.
execute in admin (not secure, i know) PowerShell or Windows PowerShell

cd D:\UDL
pip uninstall -r requirements.txt
pip install -r requirements.txt
exit

open console in you directory (D:\UDL according to your screenshot) in user (not admin) and execute

python main.py [OPTIONS]

the command is just wrong


[nri-bundle] global.nodeSelector has error

Hi,
Bug description
I use nri-bundle chart with below custom values.yaml
global:
  nodeSelector:
    node: infra

But this affected to newrelic-infrastructure.kubelet
kubelet is daemonset, so it does not use nodeSelector from global.
Version of Helm and Kubernetes
all version
Which chart?
nri-bundle chart version 5.0.2

Hi @Hokwang,
We are still triaging it but in case this issue exists it is in this repository as the chart affected is the infrastructure one.
I'll reach you again after triaging it :)

Hi @Hokwang,
I am sorry but we are not able to reproduce it.
helm template test prod-helm-charts/nri-bundle \
  --set global.cluster=test \
  --set global.licenseKey=test \
  --version 5.0.2 \
  -s charts/newrelic-infrastructure/templates/kubelet/daemonset.yaml | \
yq .spec.template.spec.nodeSelector

null

I create a test values file.

helm template test prod-helm-charts/nri-bundle \
  --set global.cluster=test \
  --set global.licenseKey=test \
  --version 5.0.2 \
  -s charts/newrelic-infrastructure/templates/kubelet/daemonset.yaml \
  -f values-test.yaml | \
yq .spec.template.spec.nodeSelector

node: selector

On the other hand, we were not testing this use case in our pipeline so I created PR #599 to add these test and it seems that tests are passing correctly so there is no further tests we can do.
The next best step is to visit New Relic Support, where you can engage the New Relic Support Community or open a support ticket depending on your support level. The support team is best positioned to assist with your specific needs.
Please provide a link to this GitHub issue when submitting your community post or support ticket.
Thanks!


Cannot be used in the new version

Cannot be used in the new version

in DSP <IP_ADDRESS>50

I have same issue. Always get the "Sorter too long" message where it used to work.


[Feature Request] Preserve Modification Date

Add a config flag that keeps the modification date when the VPX file is replaced.

Fixed with 3.9.0


Add a test to ensure that we can parse each file

Note that this has a non-spurious failure in ra_analysis/src/mock_analysis.
Probably fixes #195.
If my understanding is correct, fixes #214 and #225.

I don't know how to fix the parser without a large refactoring of type parsing (to pass allow_bounds around). Note that libsyntax uses that approach, so I think that should be the goal, but I want to check that that is OK before going further.

Let's see if this passes now...
bors r+

---- self_hosting_parsing stdout ----
thread 'self_hosting_parsing' panicked at 'assertion failed: `(left == right)`
  left: `[SyntaxError { kind: ParseError(ParseError("expected a block")), location: Offset(2109) }, SyntaxError { kind: ParseError(ParseError("expected expression")), location: Offset(2109) }, SyntaxError { kind: ParseError(ParseError("expected SEMI")), location: Offset(2112) }, SyntaxError { kind: ParseError(ParseError("expected SEMI")), location: Offset(2117) }]`,
 right: `[]`: There should be no errors in the file DirEntry("/home/travis/build/rust-analyzer/rust-analyzer/crates/ra_syntax/src/validation/byte_string.rs")', crates/ra_syntax/tests/test.rs:71:9

That is #214

Now we're blocked on #225.

Update - I think I've fixed #225, but the code in 4a7271c76c62e24b08ad6f8696b696f8bced95f3 is really ugly, so an idea of how to refactor this would be helpful. I'll see why CI is failing tomorrow (assuming it is of course).

The self_hosting_parsing test seems very slow, and I'm not sure if that can be improved at all. Any ideas?

test seems very slow,

I think it traversed /target and node_modules :D We could try to start the traversal at project_dir().join("/crates")? Also, it would be a good idea to check that we've parsed at least 30 files: if we change directory layout later, the test could suddenlty "work" by parsing zero files.

Yeah, I'll do that. :man_facepalming:. It did seem very high compared to gen-tests which is near instant and does the same job ish.

bors r+
Thanks!


[2488] - Run specs locally in parallel

Context
The work required to make these specs run in parallel is very similar to https://github.com/DFE-Digital/manage-courses-frontend/pull/742 however we now have a database to contend with.
Rationale for changes?

It's a pain to have to manually open up SimpleCov results right?

Changes proposed in this pull request
Adds:

the parallel_tests gem to speed up tests
the simplecov-console gem to print SimpleCov test output to the console

The default rake task has been amended so that parallel specs run by default (using 12 cores)
Guidance to review

to change the number of cores used when running the default Rake task bundle exec rake set a 'PARALLEL_CORES' env var to what ever your machine can handle.
to just run the tests in parallel run bundle exec rake parallel:spec
NOTE - a local bundle config has been added to address a known 'bundler' gem bug. See comments below. Thanks @timabell for helping to debug this 🥇

How fast are the tests now?
(utilising 12 cores)
Before:
160 seconds
After:
4 cores - 89 seconds
12 cores - 66 seconds
SimpleCov console output

Checklist

[x] Make sure all information from the Trello card is in here
[x] Attach to Trello card
[x] Rebased master
[x] Cleaned commit history
[x] Tested by running locally

I also see https://github.com/grosser/parallel_tests/issues/649 with these local changes to the PR:
diff --git a/Gemfile b/Gemfile
index 7dfea706..a877496f 100644
--- a/Gemfile
+++ b/Gemfile
@@ -140,7 +140,7 @@ end

 # For some reason some specs fail when running in parallel unless this group is commented out
 # https://github.com/grosser/parallel_tests/issues/649
-# group :development do
+group :development do
   gem "listen", ">= 3.0.5", "< 3.3"

   # Output scaffold commands based on schema
@@ -158,7 +158,7 @@ end
   gem "guard"
   gem "guard-rspec", require: false
   gem "guard-rubocop", require: false
-# end
+end

 group :test do
   gem "database_cleaner"

output:
tim@max:~/repo/dfe/manage/backend(2444-parallel-tests*)
$ be rake parallel:spec
logstash not configured, falling back to standard Rails logging
Raven 2.12.2 configured not to capture errors: DSN not set
   (0.8ms)  SELECT "schema_migrations"."version" FROM "schema_migrations" ORDER BY "schema_migrations"."version" ASC
4 processes for 194 specs, ~ 48 specs per process

An error occurred while loading ./spec/models/organisation_user_spec.rb. - Did you mean?
                    rspec ./spec/models/organisation_spec.rb
                    rspec ./spec/models/nctl_organisation_spec.rb

Failure/Error: require "rspec"

LoadError:
  cannot load such file -- rspec
# ./spec/models/organisation_user_spec.rb:16:in `<top (required)>'
Run options: include {:focus=>true}

All examples were filtered out; ignoring {:focus=>true}

Finished in 0.00008 seconds (files took 5.91 seconds to load)
0 examples, 0 failures, 1 error occurred outside of examples

Coverage report generated for (3/4) to /home/tim/repo/dfe/manage/backend/coverage. 2677 / 4836 LOC (55.36%) covered.
SimpleCov failed with exit 1Run options: include {:focus=>true}

All examples were filtered out; ignoring {:focus=>true}
Run options: include {:focus=>true}

All examples were filtered out; ignoring {:focus=>true}
...Run options: include {:focus=>true}

All examples were filtered out; ignoring {:focus=>true}
...............................................................................................................................................F........FFF.F..F....*.................

etc

The solutions reported here appears to work.
bundle config disable_exec_load true

The above command changes the value of the BUNDLE_DISABLE_EXEC_LOAD  variable. Further explanation be found here - https://bundler.io/v2.0/man/bundle-exec.1.html#Loading

Made some notes for the benefit of others https://github.com/grosser/parallel_tests/issues/649#issuecomment-550268246

$ be rake parallel:drop                                                                                {1}
rake aborted!
NameError: uninitialized constant SimpleCov
/home/tim/repo/dfe/manage/backend/config/application.rb:20:in `<top (required)>'
/home/tim/repo/dfe/manage/backend/Rakefile:4:in `require_relative'
/home/tim/repo/dfe/manage/backend/Rakefile:4:in `<top (required)>'

:thinking:

 Running test-suites locally in parallel: Manage-backend

Fixed pushed for this @timabell
https://github.com/DFE-Digital/manage-courses-backend/pull/970#issuecomment-550354578

I wrote up my understanding of the odd bundler issue that meant we needed BUNDLE_DISABLE_EXEC_LOAD here https://github.com/grosser/parallel_tests/issues/649#issuecomment-551008838 and don't plan to spend more time on it for now.

The current path in the readme doesn't quite work
rake db:setup
rake

results in failure because test db 2/3/4 aren't there

As discussed the current path in the readme doesn't quite work
rake db:setup
rake

results in failure because test db 2/3/4 aren't there

@timabell  - Parallel testing has now been removed form the default Rake task


Azure Access Control Retirement for SharePoint Add-ins impact is not valid anymore.

[Documentation needs to be updated,
Important
Azure Access Control (ACS), a service of Azure Active Directory (Azure AD), has been retired on November 7, 2018. This retirement does not impact the SharePoint Add-in model, which uses the https://accounts.accesscontrol.windows.net hostname (which is not impacted by this retirement). For more information, see [Impact of Azure Access Control retirement for SharePoint Add-ins]
---------------------------> this link is dead*. Can someone update this the updated link with impact and clarifying details on this retirement (https://developer.microsoft.com/office/blogs/impact-of-azure-access-control-deprecation-for-sharepoint-add-ins/). *********
For new tenants, apps using an ACS app-only access token is disabled by default. We recommend using the Azure AD app-only model which is modern and more secure. But you can change the behavior by running ‘set-spotenant -DisableCustomAppAuthentication $false' (needs the latest SharePoint admin PowerShell).
]

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 35a3017a-6d6c-237f-fc57-94247a8f7bf6
Version Independent ID: 93413445-18fa-9245-ea64-1c1d789dce1e
Content: Granting access using SharePoint App-Only
Content Source: docs/solution-guidance/security-apponly-azureacs.md
Product: sharepoint
GitHub Login: @VesaJuvonen
Microsoft Alias: vesaj

Fix updated - thanks for the note on this 👏


Surface fatal exceptions that stop the event loop

Request an app Shutdown so KestrelEngine gets disposed
Ensure Listener.Dispose doesn't deadlock before the engine
can be disposed
Rely on the existing logic to rethrow in the fatal error when
the engine gets disposed

@DamianEdwards @lodejard

:shipit:


MetaMars0114

want join

@MetaMars0114 Hey! Welcome to openAOD. I will be sending an invite to join the organization shortly. Feel free to join our Discord server: https://discord.gg/wZ83xSJSsN . If you have any questions regarding the project or about contributions do contact me. Cheers. Have a great day.


Add support for mapping java.util.Date ARRAY or List to PostgreSQL DATE[] and TIMESTAMP[]

I had to implement this on my actual project. Maybe this can be interested to share my work with community.
I can create a pull request and my implementation and had unit tests.

Do you want to add support for mapping a PostgreSQL DATE[] to a java.util.Date array or Collection?

Sorry i didnt specify. Yes, Postgres DATE[] to a java.util.Date array

Sounds great. Please send the PR.

Fixed.


Add "Messages behind" for Topics within Consumer group profile

Describe the bug
Add "Messages behind" for Topics within Consumer group profile
Set up
https://www.kafka-ui.provectus.io/
Steps to Reproduce

Steps to reproduce the behavior:

Navigate to Consumer group profile
Check the linked Topics list

Expected behavior
Should be displayed "Messages behind" for each Topic
Screenshots

I'd like to work on this.


Trace logging

We should offer a feature (trace, probably, or maybe log) that adds a runtime dependency on log and adds trace! macros to the conversion process. This should help with debugging without having to add manual implementations of FromPest all over the place to trace execution.

For pest proper, having a debugger is a huge quality of life thing. For a from-pest conversion, though, I don't know whether a dedicated debugger is practical.
If you're using a tui debugger, I think it should be possible to put breakpoints on <Node as FromPest>::from_pest, though I have to admit ignorance here. I both am spoiled by the IntelliJ Java visual debugger and on Windows, so I have never learned how to use a textual debugger (and really have no desire to).
printf debugging is basic, but simple. Once I can actually use a debugger on Windows (I have a JetBrains license so can use CLion, but have failed multiple times to set it up so far), maybe I can see about improving debuggability that way. But due to the distributed manner of pest-ast (annotations on individual types instead of one localized source of truth), a VM debugger doesn't seem practical.


Docker-color-feature migration + testing

Migrated docker color feature from settings screen to main screen
Added tests

Related issues: #26 #56.

Tested the Docker color migration. Performs as normal.
Followed these steps:
Opened app
Changed the docker color
Exited the app and closed it completely
Re-opened app and verified that the new color has persisted
Success.
Attempted the same steps twice with success in both situations.


new batches creation at the beginning of every epoch

I need to create batches from the dataset at every epoch, not only the initialisation. I need to call ordered_indices of the dataset every epoch to create a certain ordered indices. I am setting shuffle for both batches and the dataset to False because I do not want the dataset to shuffle. I am creating my own custom dataset and task.
So first how to call ordered_indices at the beginning of every epoch, how to achieve this?
Does setting shuffle to False create any performance issues? When setting the shuffle to False for both dataset and batches, the iterator for the second epoch seems ti be empty, is the shuffling the responsible for creating data for the epochs?

@lematt1991 can you help regarding this?

@myleott can you help regarding this please?


Misformatted linebreak at auto wrap and gutter blame

If using wordWrap, all automatic linebreaks are not indent when opening the gutter blame.
The said lines are starting all the way to the left making it very hard to read.

GitLens Version: 10.2.0
VSCode Version: 1.41.1
OS Version: Win 10 x64

Steps to Reproduce:

Enable Word-Wrap "editor.wordWrap": "on" (all wrap modes show the same behaviour)
Add text to a file
At least git add the file, a full commit shows the same behaviour
Open the gutter blame (Ctrl+Shift+G B)

Result:
Screenshot

This is a really simple file. If you have a different commit on every second line it is next to impossible to read this.
Expected:
All lines should be intented like the upper half of the image, which has manual linebreaks.

Unfortunately this is a VS Code limitation: https://github.com/microsoft/vscode/issues/90426


Where are user written snippets stored?

I'd like to be able to share snippets between computers via Dropbox, but my laptop does not pick up this extension if I share the ~/Dropbox/Application Support/brackets/extensions/user/edc.brackets-snippets folder from my dektop.

Digger around more, it looks like they are saved in brackets.json.

Yes you're right


More complete Unity Support

From @hadi77ir on December 18, 2015 22:48
It's just OmniSharp and C# support, not Unity integration. Even with using a Unity Editor Plugin, nothing changes: We have only C# support without UnityEngine.UI, UnityEngine.EventSystems, UnityEngine.* and UnityEditor namespaces!
Also we don't have any Boo or UnityScript support when we're using VS Code, So we had to switch back to the MonoDevelop.
What Unity Community wants from Visual Studio Code is:

Implementing UnityScript and Boo Support
Fixing assembly referencing problems (specially for UnityEngine.UI, but I think that it's a Unity problem, not an OmniSharp bug)
Intellisense for Boo and UnityScript (by using Roslyn, since they're .NET languages)

Copied from original issue: Microsoft/vscode#1461

From @egamma on December 20, 2015 18:29
@hadi77ir the feature request makes sense, but this is also a great opportunity for a Code contribution/extension from to the Unity community.

Nothing I am aware of. Maybe @hadi77ir knows?

They've officially dropped support for it.
AFAIK all of UnityScript code (compiler, MonoDevelop extensions, etc.) were available at Unity Technologies repositories, but now I can't find them. (I think they have deleted the repos instead of archiving).
But the community may revive it some day by writing a new compiler and plugging support into Unity, who knows? :)
@jrieken As of now, UnityScript is of no use. You may close this issue. :wave:

Thanks @hadi77ir. In future, Please let us know if there are any features that help Unity developers that might be interesting to take up for the C# extension.


Use newer list interface

What was the end-user problem that led to this PR?
The problem was that our specs emit a lot of deprecations about the list command.
What was your diagnosis of the problem?
My diagnosis was that we are using the deprecated interface to the list command everywhere.
What is your fix for the problem, implemented in this PR?
My fix is to start using the new interface. If we don't use it ourselves, how could we be in a position to tell our users to start using it?
Why did you choose this fix out of the possible options?
I chose this fix because we should do this, at same point, and doing it now simplifies enabling deprecations.

I still need to update the documentation of list to document the preferred interface, but given the amount of changes this required I'd like to make sure we are in the same page about this deprecation. The new interface is superior and way more clear, but I feel some of the old shortcuts could stay, such as bundle config as a shortcut to bundle list, or bundle config <key> <value> as a shortcut to bundle config set <key> <value>?

@janpio The azure build seems to be hanging? It sounds like a problem with Azure not being able to pickup the latest code after a force-push... maybe?
This is ready for a review, by the way. I updated the bundle config docs to document the new interface to the config command, and alos fixed an error message where the recommended command was not clear and would not work as specified. See https://github.com/bundler/bundler/pull/6974/commits/4bf058b56c8d9ab37f22dbd4a0c70b11a1950d2d.

@janpio The azure build seems to be hanging? It sounds like a problem with Azure not being able to pickup the latest code after a force-push... maybe?

Actually disregard this, looks like it was still running. Now it finalized properly :+1:.

Hm, Azure Pipelines taking longer than Travis is of course not good, I will try to get a few PRs in fixing test failures on Windows which should hopefully speed up the build.

Awesome, thanks!
@bundlerbot r+


Ghost blocks locals

Allow a 'tracked' or 'ghost' local variable declaration in 'exec' code, as long as it not initialized in exec code.
When proof blocks are erased, this will leave a single unused, uninitialized 'let' binding. With the existing macro-erasure scheme, the macro erases such 'let' bindings in order to avoid type errors; in a ghost-blocks future, an unused 'let' statement would just get optimized out.
A lot of the concurrency code is currently written in a style similar to this, so this change should make it easier to port that code to use the ghost-blocks restrictions.
I think this will probably let us simplify some of the pattern expansion code in the macro, but I haven't attempted to do that yet. I also think we can do "auto-unwrapping" of arguments so that arguments and locals can be handled uniformly (I made a janky prototype of this but it's not ready).
Specifically this PR:

Loosens the restriction on variable declarations in exec code
Adds a restriction on variable uses to make sure such variables are never read or assigned in exec-mode

This restriction caused some problems with invariant-blocks. I didn't attempt to figure out fully how erasure works for invariant blocks, so as a temporary workaround, I had modes.rs count the invariant block argument as a 'ghost block'.

Removes cell_old_style and ptr_old_style. Those were explicitly written to not use the ghost-blocks style, so it's time we got rid of them.
Adds let ghost x; to go along with the existing let tracked x; syntax. Previously, this wouldn't have had any use, but it does now that it makes sense to declare a ghost variable in exec code.

I'm deep in some code and would rather not context-switch right now. I trust you on this, and will try and take a look later; as far as I'm concerned, feel free to merge.

I have one comment: can you please add an example or two on how to use this to examples/syntax.rs? That is effectively our most complete documentation on the syntax right now, and we should keep it up to date.


Add app model_bakery

https://github.com/model-bakers/model_bakery

This looks done to me: https://github.com/wsvincent/awesome-django/blame/master/README.md#L136


feat: implement 0x9B - SWAP12 Opcode

Kakarot v0 implementation: https://github.com/kkrt-labs/kakarot/blob/main/src/kakarot/instructions/exchange_operations.cairo
Kakarot v0 tests: https://github.com/kkrt-labs/kakarot/blob/44dabfcab05a87f85bcfe0a457809059d11d83fb/tests/src/kakarot/instructions/test_exchange_operations.cairo#L107
EELS Implementation: https://github.com/ethereum/execution-specs/blob/fade6e95726c9c0b47b779fd8873b5737fbea3b3/src/ethereum/paris/vm/instructions/stack.py#L108
SinceGroupFrontierExchange OperationsIndex 1 is top of the stack. See PUSH.Stack inputa: value to swap.ignored value.ignored value.ignored value.ignored value.ignored value.ignored value.ignored value.ignored value.ignored value.ignored value.ignored value.b: value to swap.Stack outputb: swapped value.ignored value.ignored value.ignored value.ignored value.ignored value.ignored value.ignored value.ignored value.ignored value.ignored value.ignored value.a: swapped value.ExampleInputOutput1122003004005006007008009001000110012001321Reproduce in playground.Error casesThe state changes done by the current context are reverted in those cases:Not enough gas.Not enough values on the stack.

Important update: we are gathering some bugs in the Kakarot v0 codebase, we need to make sure each issue and each PR in Kakarot-ssj is aware of the lists of known bugs. Look at this link everytime you take an issue and check your issue isn't targeted by a known bug.

Important update: we are gathering some bugs in the Kakarot v0 codebase, we need to make sure each issue and each PR in Kakarot-ssj is aware of the lists of known bugs. Look at this tracking issue everytime you take an issue and check your issue isn't targeted by a known bug.


Multiple assignees

~Blocked by go-gitea/go-sdk#99~
This implements multiple assignees as of #1884. You can add and remove multiple assignees via the ui when creating issues or pull requests on the sidebar to the right as you do with labels.
I modified the api to reflect Github's API behavior while being backwards compatible.
Todo

[x] Unit tests for new functions
[x] Update go-sdk once it's merged

Codecov Report

Merging #3705 into master will decrease coverage by 0.04%.
The diff coverage is 27.62%.

@@            Coverage Diff             @@
##           master    #3705      +/-   ##
==========================================
- Coverage   35.79%   35.74%   -0.05%
==========================================
  Files         287      289       +2
  Lines       41496    41642     +146
==========================================
+ Hits        14854    14886      +32
- Misses      24454    24564     +110
- Partials     2188     2192       +4

Impacted Files
Coverage Δ

modules/auth/repo_form.go
33.76% <ø> (ø)
:arrow_up:

models/migrations/migrations.go
2.58% <ø> (ø)
:arrow_up:

models/repo.go
42.67% <0%> (ø)
:arrow_up:

routers/api/v1/repo/pull.go
6.5% <0%> (+0.17%)
:arrow_up:

models/webhook_discord.go
3.14% <0%> (-0.07%)
:arrow_down:

models/issue_mail.go
12.5% <0%> (-0.94%)
:arrow_down:

models/webhook_dingtalk.go
0% <0%> (ø)
:arrow_up:

models/migrations/v59.go
0% <0%> (ø)

models/webhook_slack.go
0% <0%> (ø)
:arrow_up:

models/user.go
39.56% <0%> (ø)
:arrow_up:

... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e64aa18...c06d758. Read the comment docs.

just to be clear, @thehowi is a copycat, not actually me

@kolaente Please resolve conflicts

@JonasFranzDEV done.

@appleboy fixed

Please resolve conflicts

@JonasFranzDEV Did most of the smaller fixes + merged with master. About the License header thing: IMHO we should add one with Gitea, but still keeping the one of gogs, as the original author was gogs in 2014, but we changed stuff in 2018. Or do you think we should simply replace "Gogs" with "Gitea" in the header?

Simply leave the license headers in place and only add a license header if you create a new file.

@JonasFranzDEV ok, but I think we should at least update it to some extend.

The site reloads by closing the 'Choose Assignees' dialogue even if I did not change anything.

The dropdown menu should indicate which user is selected.
Every user is selected:

conflicted

@JonasFranzDEV I've also re-done the UI, it should work now.

@JonasFranzDEV Thanks for pointing that out, I fixed it.

@kolaente Please fix the conflicts.

@appleboy done.

@kolaente
When I multiple times click on a user in the assignment menu, it creates a ton of comments (see picture) although I only closed it at the end (one time). The expected behaviour should be to create only one comment for all changes rather to create for every single click a comment.

@JonasFranzDEV I know, that happens because everytime you click on an entry in that list, it updates the assignees, thus creating a comment. So if you click multiple times, it'll assign/unassign/re-assign/unassign and so on. I know this could be done better, but I'd prefer to send a seperate PR which will add a dedicated endpoint for assignees to the api and the recreating managing assignees via the ui with that.
By the way, adding/removing/modifing labels behave exactly the same which is why I did it that way...

@lafriks @JonasFranzDEV @lunny could you please re-review/approve the changes I made?

@kolaente some slight changes.

@kolaente otherwise LGTM

need @lafriks and @JonasFranzDEV 's approvals.

@kolaente If I click on "Clear assignees" the assignees are cleared but no comment is created. The excepted behaviour should be that a comment gets created.

@JonasFranzDEV right, I fixed that.

Just tested and there is now problem when checking assignees in new issue form. It just redirects back to issue list

@lafriks This is intended, it shows all issues which are assigned to that user.

@lafriks weired, I cannot reproduce that on Firefox 61 nor chromium 66.0.3359.139. This seems to be a client problem,which browser are you using?

Set up the test instance: https://gitea-dev.kolaente.de/
@lafriks Can you reproduce the issue over there?

@lafriks I could not reproduce that issue at my localhost instance using Firefox 59.0.2 and Chrome 66.0.3359.139.

@kolaente yes now it is fixed, when I tested it was not. Now it works as one expect. There is still small cavet that if you add assignees and than clear them without saving that new issue it will still try to redirect and asks if I want to navigate away from that page and have unsaved data.

@lafriks great, I fixed that issue as well now.

@kolaente no I mean there is option to assign user to multiple issues from issue list, does it still work?

@lafriks Yes, this does still work, but only with one user at a time.

@kolaente maybe update docs to add this to feature list and change the comparsion.


custom view in menu is not displaying the page

Hi, Im trying to load a custom view from menu, following the instructions from the documentation.
'menu' => array( 		'users', 		'songs' => 		'page.administrator.students', 	),
When I refresh the page it displays a page with the headers of Adminstrator and a blank white page below on it. When I inspect element, i can see the html I wrote inside my page. Im also confused on where to write this one.
View::composer(array('administrator::layouts.default'), function($view)
{
   //first check if this is a custom page    if ($view->page === 'administrator.student')
`  {
      //add page-specific assets        $view->js += array(
        'highcharts' => '/path/to/highcharts.js'        );
    $view->css += array(
        'mycss' => '/path/to/my.css'
    );
}

});

When I inspect elements, the text that I was trying to display in view was at the back of the header. I gues css is not working.


Create the Map class

time estimate: 1d
This task is part of User stories:  #19 #18 #12 #11 #10

97484999f3f428f14cb85d1555c28fdb42dd3353


FR: please add kiali in the istio instalation

Feature request:
There is a super nice tool included in istio that called kiali, it is visualizing the traffic in istio.
Please add it to the istio app.

Please could you please at least add instructions how to add Kiali with helm! Thanks!

AFAIK kiali won't work with Istio v1.0.5 as included in microk8s by default

Istio has a helm chart that can be configured to also install kiali https://github.com/istio/istio/blob/master/install/kubernetes/helm/istio/values.yaml#L82 . We may want to refactor our microk8s.enable istio script at https://github.com/ubuntu/microk8s/blob/master/microk8s-resources/actions/enable.istio.sh to make use of that installtion method.

We just upgraded istio to 1.2.2 and kiali is included by default. Have a look:
sudo snap install microk8s --channel=edge --classic

It should reach stable soon.
Please reopen if you find any issues. Thanks.

@ktsakalozos Thank you very much! How is it being installed now? I'd like to install it the same way microk8s is doing it without upgrading to edge, but I cannot find it on the script you linked above.

@chauffer unfortunately it is not trivial to run the install script manually. If you do not want to witch to edge you should wait for the edge snap to be promoted to stable.


Fixed Easter holidays for Bulgaria

Coverage increased (+8.0e-05%) to 99.63% when pulling 21f3076cfa2367aa066695d655ae42d9a82ea95a on KJhellico:fix-bulgaria into db2eeff3d7ad100d117078156747baf2d64d5aa5 on dr-prodigy:beta.

Thank you very much @KJhellico! :+1:


Make batches replayable (intermediate data lake)

Since launching batch messages, we've had community members add S3 support and soon Parquet.
I've realized that we're only inches away from being able to create a data lake with rerunnable data ingestion.
What we have already:

Data files - land in cloud storage
JSON schema reference - sent to STDOUT.
File manifests - sent to STDOUT.

If we just upload items 2 and 3 to cloud storage, we'd end up with a durable, robust, self-describing, and replayable data lake.
Proposed implementation spec
The implementation proposal for this spec is basically to upload the contents of the Singer message stream to a set of files on the remote storage provider.

The tap will upload one or more .singer.jsonl files (i.e. the STDOUT steam contents) during sync to the same directory as provided by the batch_config's storage spec.
The tap will ensure all .singer.jsonl files are alpha-sorted in replay sequence.

This can be implemented via timestamped filesnames or (perhaps better) by using something like ULID to generate unique file IDs which are also timestamp-sortable.
By ensuring files have deterministic replay sequence in their filenames, the tap can ensure that files created by any of its runners can be consumed in timestamp order without the consumer needing to pre-parse each file.

The tap can accept an optional override config to send.singer.jsonl files to a different destination - for instance, to separate the raw data files from the Singer log stream. (If not specified, it defaults to the same directory as the batch files are saved to.)

Regardless of whether files are stored in the same or different output directories, the BATCH message manifest will contain absolute references, so there will be no challenge in referencing those from different S3 paths or even from different backend providers altogether.

Taps might override this implementation, but, by applying learnings from similar BATCH and STATE conversations in the SDK, a reasonable default upload cadence would be for the tap to upload .singer.jsonl based on the following logic:

Continual write. If the storage backend supports continual writes, and if it can handle interruption, then the tap can simply echo all singer messages to the file buffer as well as sending to STDOUT.
Batched write. If continual write is not available or desireable, use a batched write operation.

Whenever one or more STATE messages would be sent, upload a new file containing singer messages not yet uploaded.
Defer or ignore upload trigger if <2 minutes have passed since the last upload. (Prevents excessive overhead when STATE messages are emitted very frequently, such as several times per second for low-cardinality parent-child relationships.)
Always flush the message queue to the storage backend when the tap exits - whether or not job was successful or failed due to an error.

Other options considered
These options were considered and not chosen.

Details

Upload scheme and manifests to cloud storage as separate files during sync.
Use a new target (target-batch or target-data-lake) which add the additional files.

To me, option 2 seems like overkill and makes this harder to achieve as an inline byproduct.

A simpler solve is here:

https://github.com/meltano/sdk/issues/1246

We can close this item if we choose to implement #1246

A higher than expected number of folks (I didn't think this mattered to much, but I was wrong) have asked me about this, and they all tend to implement it themselves (They'd love this!)
I wanted to add that from a technical outsider view "backing up" the contents that goes from the tap to the target seems like the right architecture move. I've had this confirmed in 3-5 different companies asking this question in different ways.

If we just upload items 2 and 3 to cloud storage, we'd end up with a durable, robust, self-describing, and replayable data lake.

Now if we also did something like Kafka and added an id system of sorts to allow "full replayability" to folks that would be pretty epic. I'm not sure the id piece is the right way to go here, but just wanted to describe what folks have asked for.

@kgpayne, @visch - Thanks both for your thoughtful feedback. Based on your comments, I refined the issue description to prefer the .singer.jsonl file upload approach, which literally provides a sequence of Singer files which could then be replayed. Those files would inherently contain the SCHEMA message, theBATCH message (with manifest), and the STATE message.

@aaronsteers does that effectively merge this issue and "Support --output for taps, with support for cloud filesystems #1246"? It seems like --output could be made to serve both use cases, with the only difference being that BATCH messages trigger upload of each file in the manifest in addition to the raw message stream  🤔

@kgpayne - Good question. It doesn't fully merge them because this item still focuses on a config-based way to echo STDOUT also to a set of files, whereas the proposal in the --output is an implementation at the CLI which replaces STDOUT.
The other issue would be much easier after this one is implemented but the use cases are different. In this case, we end up with replayable output inline with a normal sync operation, whereas that one generates relatable output instead of the normal sync operation.
In theory, these could be done in any order, and either one makes the other easier.

@z3z1ma called this out in Office Hours today:
We probably should ensure programmatically that each file has a SCHEMA message for each stream mentioned.
So an ideal file could contain messages in this sequence:
SCHEMA message
BATCH message
STATE message

One benefit to having more files, each self-sufficient, would be the ability to for loaders to run ingest data with multiple workers.

As discussed in Office Hours this week (Jan 18), @kgpayne has done some great work in exploration on a potential spec for cloud storage of the Singer event stream here:

https://blog.kenpayne.co.uk/blog/2023-01-17.html

Ideally we'd reconcile these two so that the 'replayable batches' and 'singerlake' concepts are really just a single spec, optionally with toggleable setting as to whether the records would be stored inline (non-batch) or as directly consumable data files (batch mode).
cc @z3z1ma


Dual Page View Content Flow Display Issue (Split screen window dependant)

Thank you for creating this plug-in btw. Its very helpful as I like to do research and note taking right within obsidian.
Currently the page view is Dual Page view if opened in a window full screen. You can change that to single page by switch back and forth between files. But if the window size changes, the display will not reflow the text from dual page to single page and or back again.
Requesting #Feature to have controls to make changes to the visual display on the fly.

Please upgrade to v1.0.2.
Thanks.


Fix code generated from table with no primary key

Compilation was failing due to an unused import (fmt), and
an incorrect return value from Get().
This addresses https://github.com/mijia/modelq/issues/29

Thank you very much.


fix(keys): fix gpg signing

:tada: This PR is included in version 0.17.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


switch mocha-run to use compile instead of compilation-start

closes #44

Looks good to me. Thanks for the contribution.


Skin tone fix

Details

Fixed Issues

$ https://github.com/Expensify/App/issues/15805
PROPOSAL: GH_LINK_ISSUE(COMMENT)
Tests

Click on the text input field for chat to give it focus.
Type :+1: in the text input field.
Verify if the displayed emoji has the correct skin tone.
Change the emoji's skin tone setting.
Type :+1: in the text input field again.
Verify if the displayed emoji now has the updated skin tone.

Repeat the same steps for the message edit input field.

[x] Verify that no errors appear in the JS console

Offline tests

QA Steps

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web
https://user-images.githubusercontent.com/48593211/228169949-4ab8f934-7683-4023-aff2-0b07111fa099.mp4

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

@paulogasparsv Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

Hey @perunt, I see you linked the GH issue like this$ [GH_LINK](https://github.com/Expensify/App/issues/15805) but please make sure to always link it like this instead $ https://github.com/Expensify/App/issues/15805.
That's important so the original issue's team members are assigned to the P.R.
Let me fix that for you and assign @mountiny here!

I think there is a console error for users that don't have a preferred skintone (e.g. creating a new account in newDot and sending :+1: generates the warning at the first try. Does it also happen for you @perunt @mountiny?

Hey, just a suggestion, You could use the getEmojiCodeWithSkinColour method that is already present in the EmojiUtils.js
let emojiReplacement = getEmojiCodeWithSkinColor(checkEmoji.metaData, preferredSkinTone);

Also, this causes a crash when we try to edit a message
https://user-images.githubusercontent.com/77237602/228221649-d5915408-1bef-467d-8dca-5cc8a65c0a77.mov

I also found a way to fix the crash!
We should use initWithStoredValues: false with the onyx key so that the reference to this component is always available.
preferredSkinTone: {
    key: ONYXKEYS.PREFERRED_EMOJI_SKIN_TONE,
    initWithStoredValues: false,
},

@esh-g What crash is this supposed to fix?

It is currently crashing because we are focusing on the textInput here:
https://github.com/Expensify/App/blob/3f66c681cd1ad092507074799ba6400b58d1da85/src/pages/home/report/ReportActionItem.js#L106
But this.textInput is undefined as the ref is not yet ready due to onyx. Similar to this issue: https://github.com/Expensify/App/pull/15296#issuecomment-1456111698

It is currently crashing because we are focusing on the textInput here:
https://github.com/Expensify/App/blob/3f66c681cd1ad092507074799ba6400b58d1da85/src/pages/home/report/ReportActionItem.js#L106
But this.textInput is undefined as the ref is not yet ready due to onyx. Similar to this issue: #15296 (comment)

Yes, as we immediately focusing the textinput for edit message and onyx fetch won't allow to render the child immediately which will throw the undefined ref issue.

Okay, Just needed to add the condition to update the component on change to preferredSkinTone and the crash is fixed and works as expected
shouldComponentUpdate(nextProps, nextState) {
        return this.props.displayAsGroup !== nextProps.displayAsGroup
            || this.props.draftMessage !== nextProps.draftMessage
            || this.props.isMostRecentIOUReportAction !== nextProps.isMostRecentIOUReportAction
            || this.props.hasOutstandingIOU !== nextProps.hasOutstandingIOU
            || this.props.shouldDisplayNewMarker !== nextProps.shouldDisplayNewMarker
            || !_.isEqual(this.props.action, nextProps.action)
            || this.state.isContextMenuActive !== nextState.isContextMenuActive
            || this.props.preferredSkinTone !== nextProps.preferredSkinTone;
    }
    ```

Here is a summary of the changes I am suggesting:

Add initWithStoredValues: false to the preferredSkinTone key in ReportActionItemMessage.js
Add a condition in ReportActionItem.js shouldComponentUpdate, to have it update when the value of preferredSkinTone changes.

These changes will prevent the crash and also preserve the intended functionality.
https://user-images.githubusercontent.com/77237602/228252986-c12bf7e5-12f8-4d4d-b98a-d0e37e835a94.mov

Setting initWithStoredValues to false is not the correct approach.

Setting initWithStoredValues to false is not the correct approach.

@s77rt Could you please explain about this further?

The skin tone must be set correctly on first render (initWithStoredValues must be true) otherwise we will be using the default skin tone while editing messages.

Yes, in that case I think we need to focus the textInput only when it is rendered.

So, should we just increase the delay? Or is there some way to pause the rendering until onyx has that data and the ref?

There is no delay on Web. It would fix the bug but it's a hacky way to do so.

I think its an edge case when the onyx data is not ready yet by the time someone types the emoji. I thin kits fine to just use the default yellow skin tone if Onyx data is not loaded yet and move on

@mountiny It's not really an edge case. You can reproduce it all the time and may get reported as a bug.

Select any message
Go to edit mode
Refresh page
Type into the message that is already in edit mode
Emojis have default skin

Technically the issue we are encountering now is unrelated to the PR. Maybe we can just use initWithStoredValues: false until a proper fix is found.

On WEB, InteractionManager.runAfterInteractions() will fix it. However, I've encountered this issue with this approach on Android devices, and using setTimeout is not an optimal solution. To be honest, the multiple edit window method feels quite cumbersome. @mountiny have you considered incorporating the edit functionality directly into the composer? This would make it more intuitive and help prevent issues with multiple edit windows and UI jumping

On Web InteractionManager.runAfterInteractions is basically a setTimeout. Let's not use it

@mountiny have you considered incorporating the edit functionality directly into the composer? This would make it more intuitive and help prevent issues with multiple edit windows and UI jumping

I dont personally remember discussion around this but we would have to run this through the open source room for sure and P/S.
And agree with @s77rt lest not use the interactionManager. Could we use the initWithStoredValues: false approach mentioned above?
What would be the next steps @s77rt ?

Could we use the initWithStoredValues: false approach mentioned above?

Actually we can't, this will break emoji skin tone on edited messages
https://user-images.githubusercontent.com/16493223/228608806-4159db33-a93c-48bb-adf0-64599c94948c.mp4

@s77rt Have you also added the condition in shouldComponentUpdate?

@esh-g Yes. no effect.

As an alternative solution maybe we should pass preferredSkinTone as prop to ReportActionItemMessageEdit instead of using onyx: <ReportActionItemMessageEdit preferredSkinTone={this.props.preferredSkinTone} />

@perunt I really don't see why would we merge those files into one. Isn't this achieving the same results of propose alternative solution above ^

In this case, only the Message component would be re-rendered upon modifying the skin tone, while the ReportActionItem remains unchanged. This approach is not flawless, as it still involves some re-rendering.

Reviewer Checklist

[X] I have verified the author checklist is complete (all boxes are checked off).
[X] I verified the correct issue is linked in the ### Fixed Issues section above
[X] I verified testing steps are clear and they cover the changes made in this PR

[X] I verified the steps for local testing are in the Tests section
[X] I verified the steps for Staging and/or Production testing are in the QA steps section
[X] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[X] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[X] I checked that screenshots or videos are included for tests on all platforms
[X] I included screenshots or videos for tests on all platforms
[X] I verified tests pass on all platforms & I tested again on:

[X] Android / native
[X] Android / Chrome
[X] iOS / native
[X] iOS / Safari
[X] MacOS / Chrome / Safari
[X] MacOS / Desktop

[X] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[X] I verified proper code patterns were followed (see Reviewing the code)

[X] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[X] I verified that comments were added to code that is not self explanatory
[X] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[X] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[X] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[X] I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[X] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[X] I verified the JSDocs style guidelines (in STYLE.md) were followed

[X] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[X] I verified that this PR follows the guidelines as stated in the Review Guidelines
[X] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[X] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[X] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[X] If a new component is created I verified that:

[X] A similar component doesn't exist in the codebase
[X] All props are defined accurately and each prop has a /** comment above it */
[X] The file is named correctly
[X] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[X] The only data being stored in the state is data necessary for rendering and nothing else
[X] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[X] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[X] All JSX used for rendering exists in the render method
[X] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[X] If any new file was added I verified that:

[X] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[X] If a new CSS style is added I verified that:

[X] A similar style doesn't already exist
[X] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[X] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[X] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[X] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[X] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[X] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

https://user-images.githubusercontent.com/16493223/229512962-81f7cbbe-df24-4002-9de5-ac7093e02d1c.mp4

Mobile Web - Chrome

https://user-images.githubusercontent.com/16493223/229512939-a7a9c01d-1772-43c1-82e1-fbc470d06413.mp4

Mobile Web - Safari

https://user-images.githubusercontent.com/16493223/229512414-5a723a52-bb1d-4d49-8bb8-8d306f3a6743.mp4

Desktop

https://user-images.githubusercontent.com/16493223/229512378-50d58dd2-519a-4668-b601-60fb85b08338.mp4

iOS

https://user-images.githubusercontent.com/16493223/229512356-f09539ea-b3c6-4c55-8bf2-092eed8bfb3c.mp4

Android

https://user-images.githubusercontent.com/16493223/229512329-305d6ae3-ecdd-4645-9ffc-92c36fc29170.mp4

@s77rt can you do a final tests/check and approve the PR if all is good please?

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by https://github.com/mountiny in version: 1.2.94-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
failure ❌

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/thienlnam in version: 1.2.94-3 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


Tooltip is clipped from other Usercontrols

Is it maybe possible to give the Tooltip an Zindex of 100 maybe?
So it wouldnt be clipped from other Usercontrols.
I cant find the right place in the code.

It gets also clipped by the Window Boundries

#230  should fix this i think

https://giphy.com/gifs/3o6gEb20IdgtuEKncI

You PR was a nice try but it was not going to be enough, pelase see this alternative.
To solve this what we actually need to do is add  tooltip at the chart UI level, so we can always set a higher zindex that all the charts.
My idea was to wrap all the controls you need to force the tooltip to draw over, all the charts in this container must share this tooltip, also notice the tooltip will never go out the container, as you mentioned, it could overflow the window, with this method we also fix that.
For a fill example see https://github.com/beto-rodriguez/Live-Charts/tree/master/Examples/Wpf/CartesianChart/SharedTooltip
Here a code snippet
<Canvas Name="CanvasContainer">

    <!--
    the tooltip requires a canvas to move properly,
    so lets wrap our view where you need a shared tooltip
    with a Canvas container
    -->

    <lvc:DefaultTooltip Name="CurrentTooltip" Visibility="Hidden"
                        Panel.ZIndex="100"
                        Canvas.Left="0" Canvas.Top="0"
                        IsWrapped="True">
        <!--
        it needs to:
        1. Have an initial position
        2. Be hidden on startup
        3. to be wrapped in a Canvas, and say it with IsWrapped = true
        -->
    </lvc:DefaultTooltip>

    <Grid Height="{Binding ActualHeight, ElementName=CanvasContainer}"
          Width="{Binding ActualWidth, ElementName=CanvasContainer}">
        <Grid.ColumnDefinitions>
            <ColumnDefinition Width="*"></ColumnDefinition>
            <ColumnDefinition Width="*"></ColumnDefinition>
            <ColumnDefinition Width="*"></ColumnDefinition>
        </Grid.ColumnDefinitions>

        <lvc:CartesianChart Grid.Column="0" Background="White"
                        DataTooltip="{Binding ElementName=CurrentTooltip}">
            <lvc:CartesianChart.Series>
                <lvc:LineSeries Values="1,2,3,4,5" LabelPoint="{Binding LabelPoint}"></lvc:LineSeries>
            </lvc:CartesianChart.Series>
        </lvc:CartesianChart>
        <lvc:CartesianChart Grid.Column="1" Background="White"
                        DataTooltip="{Binding ElementName=CurrentTooltip}">
            <lvc:CartesianChart.Series>
                <lvc:LineSeries Values="1,2,3,4,5" LabelPoint="{Binding LabelPoint}"></lvc:LineSeries>
            </lvc:CartesianChart.Series>
        </lvc:CartesianChart>
        <lvc:CartesianChart Grid.Column="2" Background="White"
                        DataTooltip="{Binding ElementName=CurrentTooltip}">
            <lvc:CartesianChart.Series>
                <lvc:LineSeries Values="1,2,3,4,5" LabelPoint="{Binding LabelPoint}" ></lvc:LineSeries>
            </lvc:CartesianChart.Series>
        </lvc:CartesianChart>
    </Grid>
</Canvas>

From 0.9.2 and above this scenario is automatically supported, there is no need to wrap the tooltip in a container as it was in the previous versions, if you already did this in your code, your wrapping will be ignored but you code should compile correctly, there is no need to change your code, but I recommend you to do so just because it is now cleaner and this step is not necessary


create a unit test for #100

and figure out if content-length is needed for metrics responses

06ea1176dd98cac6b3fbbcb845ca4baa73cceadf


Cryptic error message when TLS key store password is incorrect.

Slack thread: https://line-armeria.slack.com/archives/C1NGPBUH2/p1560738924028700
When a user starts a TLS server without correct key store password, the server has to refuse to start. Currently, it starts up without an error and fails to serve a request with a cryptic error message such as NO_CERTIFICATE_SET and No available authentication scheme.
/cc @adriancole

We probably should also check the client side.

to be specific, the problem is if you accidentally set --armeria.ssl.key-password=123123 instead of --armeria.ssl.key-store-password=123123, the server will happily start and then give cryptic messages for each failed TLS session.
The failure messages will be different based on the runtimes in use. Examples below:
OpenSSL+TLS 1.2
default will result in a handshake  error client side with the following warning in the server log:
Ex.
2019-06-17 16:32:34.227  WARN 67893 --- [-worker-nio-2-1] c.l.a.s.HttpServerPipelineConfigurator   : [id: 0x036a56e2, L:/0:0:0:0:0:0:0:1:9411 - R:/0:0:0:0:0:0:0:1:52283] TLS handshake failed:

javax.net.ssl.SSLHandshakeException: error:100000b8:SSL routines:OPENSSL_internal:NO_SHARED_CIPHER
	at io.netty.handler.ssl.ReferenceCountedOpenSslEngine.sslReadErrorResult(ReferenceCountedOpenSslEngine.java:1224) ~[netty-handler-4.1.34.Final.jar!/:4.1.34.Final]

OpenSSL+TLS 1.3
adding --armeria.ssl.enabled-protocols=TLSv1.3 will result in a handshake error client side with the following warning in the server log:
Ex.
2019-06-17 16:35:21.924  WARN 68453 --- [-worker-nio-2-1] c.l.a.s.HttpServerPipelineConfigurator   : [id: 0xb05a91dc, L:/0:0:0:0:0:0:0:1:9411 - R:/0:0:0:0:0:0:0:1:52296] TLS handshake failed:

javax.net.ssl.SSLHandshakeException: error:100000ae:SSL routines:OPENSSL_internal:NO_CERTIFICATE_SET
	at io.netty.handler.ssl.ReferenceCountedOpenSslEngine.shutdownWithError(ReferenceCountedOpenSslEngine.java:973) ~[netty-handler-4.1.34.Final.jar!/:4.1.34.Final]

JDK+TLS 1.2
-Dcom.linecorp.armeria.useOpenSsl=false will result in a handshake exception client side with the following warning in the server log:
Ex.
2019-06-17 16:36:43.452  WARN 68933 --- [-worker-nio-2-1] c.l.a.s.HttpServerPipelineConfigurator   : [id: 0x7e5554cb, L:/0:0:0:0:0:0:0:1:9411 - R:/0:0:0:0:0:0:0:1:52300] TLS handshake failed:

javax.net.ssl.SSLHandshakeException: no cipher suites in common
	at sun.security.ssl.Alert.createSSLException(Alert.java:131) ~[?:?]
	at sun.security.ssl.Alert.createSSLException(Alert.java:117) ~[?:?]
	at sun.security.ssl.TransportContext.fatal(TransportContext.java:307) ~[?:?]
	at sun.security.ssl.TransportContext.fatal(TransportContext.java:263) ~[?:?]
	at sun.security.ssl.TransportContext.fatal(TransportContext.java:254) ~[?:?]
	at sun.security.ssl.ServerHello$T12ServerHelloProducer.chooseCipherSuite(ServerHello.java:460) ~[?:?]

JDK+TLS 1.3
-Dcom.linecorp.armeria.useOpenSsl=false with --armeria.ssl.enabled-protocols=TLSv1.3 will result in a OpenSSL SSL_connect: SSL_ERROR_SYSCALL client side with the following warning in the server log:
Ex.
2019-06-17 16:38:51.592  WARN 69483 --- [-worker-nio-2-1] c.l.a.s.HttpServerPipelineConfigurator   : [id: 0x15b8bc47, L:/0:0:0:0:0:0:0:1:9411 - R:/0:0:0:0:0:0:0:1:52311] TLS handshake failed:

javax.net.ssl.SSLHandshakeException: No available authentication scheme
	at sun.security.ssl.Alert.createSSLException(Alert.java:131) ~[?:?]
	at sun.security.ssl.Alert.createSSLException(Alert.java:117) ~[?:?]
	at sun.security.ssl.TransportContext.fatal(TransportContext.java:307) ~[?:?]
	at sun.security.ssl.TransportContext.fatal(TransportContext.java:263) ~[?:?]
	at sun.security.ssl.TransportContext.fatal(TransportContext.java:254) ~[?:?]
	at sun.security.ssl.CertificateMessage$T13CertificateProducer.onProduceCertificate(CertificateMessage.java:944) ~[?:?]

I tried to provide more useful exception message but it basically required me to look into the exception message and do some ugly pattern matching at the risk of false positives.
Instead, I'd like to make sure the server fails to start, so that a user can easily guess it's not an handshake issue but a configuration issue.

makes sense. thanks!
On Fri, Jun 28, 2019, 6:41 PM Trustin Lee<EMAIL_ADDRESS>wrote:

I tried to provide more useful exception message but it basically required
me to look into the exception message and do some ugly pattern matching at
the risk of false positives.
Instead, I'd like to make sure the server fails to start, so that a user
can easily guess it's not an handshake issue but a configuration issue.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/line/armeria/issues/1844?email_source=notifications&email_token=AAAPVV7LNKXUXMBVHDNRVIDP4XTGZA5CNFSM4HYUJ7ZKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODYZXSUQ#issuecomment-506689874,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAAPVVYQ7FBNVESEOZQXEFTP4XTGZANCNFSM4HYUJ7ZA
.

Hello, I will handle this issue :grinning:

Hello, I will handle this issue. Thank you 😃


Groq integration doesn't work

Before submitting your bug report

[X] I believe this is a bug. I'll try to join the Continue Discord for questions
[X] I'm not able to find an open issue that reports the same bug
[X] I've seen the troubleshooting guide on the Continue Docs

Relevant environment info
- OS:Windows
- Continue version: 10
Version: 1.96.0 (user setup)
Date: 2024-12-11T02:29:09.626Z
Electron: 32.2.6
ElectronBuildId: 10629634
Chromium: 128.0.6613.186
Node.js: 20.18.1
V8: 12.8.374.38-electron.0
OS: Windows_NT x64 10.0.19045
- config.json:

Description
I'm getting an error when trying to use groq API : Oops something went wrong
To reproduce
No response
Log output
No response

Thanks for reporting this @WezDev! It should now be solved in the latest pre-release for VS Code, but I'll leave this issue open until you can verify


HP ilo dashboard not showing data

Hi Guys,
Please help to advice when I check the dashboard was not showing data after a few hours. I had restarted the docker and the prometheus service but no luck. Is there any missing I did?
Thanks in advance
Jhony

@jhonyh  Please note that this repository has not been updatd by its owner in a long time. We have a new community version of exporter and if problem is not solved thre, please create an issue in this repository with more detailed information about your problem.
https://github.com/hpilo-exporter/hpilo-exporter


Add row limit setting of data viewer and support Apache Arrow Table

What problem did you solve?
close #944
Currently, when displaying a data frame in the data viewer, temporary files are written out and read in, which does not work well for huge data frames with more than a few million rows. (related to #619, #837)
I would like to add an option to limit the number of records loaded into the data viewer, as it is often enough to see some of the content without loading all the records into the data viewer.
I would also like to add support for the Apache Arrow Table, which is becoming a strong choice for data frame compatibility when dealing with large numbers of records.
By controlling the number of records to be displayed, a huge Arrow Table can be displayed in the data viewer without stress.

[x] Add a setting to limit the number of rows when displaying data frames and matrices in the data viewer.
[x] Support Arrow Table and RecordBatch (ArrowTabular).

(If you have)Screenshot

When I tried the data viewer with a huge data frame, I got the impression that limiting it to 100,000 records only waited a few seconds, but with 1 million records it wasn't clear if it was working.
It may be better to limit the default to around 100,000 records instead of unlimited.

Thank you for your review. I edited them.
It seems to have failed to check, but it may be a problem in GitHub Actions.


Consistently name the project in the documentation

The name of the project is not consistent throughout the Github site:

About: "Apache Daffodil VSCode"
"VS Code Daffodil Debug"

I think the project should be called "Apache Daffodil VS Code Extension".

"VS Code" is the way Microsoft writes the name of the editor.
The extension is more than just the debugger, so just call it an extension.

#24 is related and can be resolved at the same time.

I can work on this which do we prefer VSCode or VS Code?

I can work on this. The other extension from Apache uses VSCode so that is what I will go with unless advised otherwise

"VS Code" is the way Microsoft writes the name of the editor.


LUCENE-10421: use Constant instead of relying upon timestamp

All the other uses of System.currentTimeMillis (both java and test code) are no good, but i'd rather tackle them in a followup issue (I will make a JIRA). Eventually, we can ban use of wall clock time with forbidden-apis.
But for now, I'd just like to have nightly benchmarks again :)

Hard not to think of this XKCD. :)

Thanks @rmuir ! Are you okay to merge this? I got confused recently over a sometimes-reproducible test failure.