Newbie quick question about Original Signature and how to set the password

i got a few quick newbie questions, wondering if you can help! Thanks!
1.) I got a few NTAG 213, and the documents in NXP mentioned about Original Signature, wondering if you would have any experience in how to work with that? How would i detect if the signature is original or not(thru the NFC or this plugin)??
2.) Can i set/reset the password for the NTAG card, through this plugin?
2a.) Is the password protected area still visible if the password isnt correct. So it can only be read if the password is correct. I am thinking to hide an account ID within the password area, so i can totally avoid cloning. (The account ID will only be revealed (so it can only be copied) if the password entered is correct)
2a.) Is the password protected area still visible if the password isnt correct. So it can only be read if the password is correct. I am thinking to hide an account ID within the password area, so i can totally avoid cloning. (The account ID will only be revealed (so it can only be copied) if the password entered is correct)

I have not looked at that.
No, you can only send along the password for reading.
2a) The password protection seems a bit weak, i have read password protected tags with the NXP Taginfo app: https://play.google.com/store/apps/details?id=com.nxp.taginfolite&hl=en

ah, ok thanks. Thanks for the reply, i was just wondering about this as i am not sure how does one create a structure that protect against cloning.
I was simply thinking if i can have a strong password protected area that is only revealed when the password is correct then i can match against the Card id in the server db then i can verify the user. But it seems that doesnt work.
And with the Card id, a card emulator can replicate that....


Improve G2Loader in built help

Similar to G2Export, add meta var to show where paths/files needed.
Do once new G2Loader article and add link to the inbuilt help.

Should be an issue in https://github.com/Senzing/g2loader rather than this repository.

Moved to https://github.com/Senzing/g2loader/issues/42


Preprocess page is broken in Streamlit>=1.36

I get this error with the example files:
KeyError: 0
Traceback:

File "/home/stef/python/unraphael/.venv/lib/python3.12/site-packages/streamlit/runtime/scriptrunner/exec_code.py", line 85, in exec_func_with_error_handling
    result = func()
             ^^^^^^
File "/home/stef/python/unraphael/.venv/lib/python3.12/site-packages/streamlit/runtime/scriptrunner/script_runner.py", line 576, in code_to_exec
    exec(code, module.__dict__)
File "/home/stef/python/unraphael/src/unraphael/dash/pages/1_preprocess.py", line 196, in <module>
    main()
File "/home/stef/python/unraphael/src/unraphael/dash/pages/1_preprocess.py", line 184, in main
    processed_nobg, processed_mask = remove_background_widget(processed)
                                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/home/stef/python/unraphael/src/unraphael/dash/pages/1_preprocess.py", line 134, in remove_background_widget
    background_params['bgcolor'] = col1.radio(
                                   ^^^^^^^^^^^
File "/home/stef/python/unraphael/.venv/lib/python3.12/site-packages/streamlit/runtime/metrics_util.py", line 408, in wrapped_func
    result = non_optional_func(*args, **kwargs)
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/home/stef/python/unraphael/.venv/lib/python3.12/site-packages/streamlit/elements/widgets/radio.py", line 228, in radio
    return self._radio(
           ^^^^^^^^^^^^
File "/home/stef/python/unraphael/.venv/lib/python3.12/site-packages/streamlit/elements/widgets/radio.py", line 280, in _radio
    options=[str(format_func(option)) for option in opt],
                 ^^^^^^^^^^^^^^^^^^^
File "/home/stef/python/unraphael/src/unraphael/dash/pages/1_preprocess.py", line 137, in <lambda>
    format_func=lambda x: bgmap[x],
                          ~~~~~^^^

Python 3.12, Streamlit 1.37

Seems like it still works fine in 1.35

I installed the latest version of streamlit 1.38.0. The example files run fine. Perhaps move to 1.38.0?

I bumped the streamlit version to 1.40 in #100, this issue can be closed.


[Advice] Returns expired datetime in response

Hi,
I've used this project in a small project and it works fine. I've stored the returned token in browser's localStorage for logined user.
I'm thinking about how to validate token. For example, if token is expired, then the server will returns a HTTP 403 Forbidden message, so the browser can check the response body and search for expired string, then make another request with username/password to get a new token.
I think a better way to do this is, return the expired date time with token, then the browser can check the validation of token by hand instead of getting a HTTP 403 Forbidden.
How do you think about this?

What about returning a a HTTP_401_UNAUTHORIZED instead? Isn't that a good indicator of needed to Authenticate again?


Inconsistent transaction numbers

If you delete a few transactions and then create new ones, the new ones will have higher number then the last created. For example if the last transaction is 5 and I delete 3,4, and 5 and create a new one, the new one will have number 6. It is the same if I delete all transactions and don't close the app. But if I delete all transactions and restart the app, the new transactions will start from 1.

https://github.com/NickvisionApps/Denaro/releases/tag/2024.1.0


Added some of the missing game config entries

Source: disassembled and decompiled libc2ssmon.so

For some reason I didn't get the notification.
Sorry, and thanks.


Any reason why OCMock is included through Carthage?

In my opinion it doesn't make sense to include the OCMock.framework when installing through Carthage. Would love your input on this/ get it removed.

Hey @AndrewSB, thanks for the report.
OCMock is not included into public Cartfile (only the private one aka Cartfile.private), as a result it won't be installed when you use Carthage for dependency management.
Are you compiling the project from scratch using carthage build and a local checkout of the repo, or using your own Cartfile to manage dependencies?

I'm compiling using carthage update --no-use-binaries --platform iOS
my Cartfile is
# Helper
github "AndrewSB/Library" "master"
github "AndrewSB/Curly" "master"
github "Haneke/HanekeSwift"
github "hackiftekhar/IQKeyboardManager"
github "thii/SwiftHEXColors"
github "malcommac/SwiftDate"
github "duemunk/Async"

# Custom UI
github "AndrewSB/HMSegmentedControl" "master"
github "AndrewSB/KLCPopup" "master"

# Reactive
github "ReactiveX/RxSwift" ~> 2.0
github "AndrewSB/Parse-RxSwift" "master"
github "robrix/Box"

# Parse
github "ParsePlatform/Parse-SDK-iOS-OSX" "master"
github "flovilmart/ParseKit" "master"

and the relevant line in the update output is *** Building scheme "OCMock iOS" in Parse.xcworkspace

@AndrewSB, try removing "master" from your Cartfile, this might help very much.

Also, looks like you are using flovilmart/ParseKit, which might collide with official Parse support for Carthage. cc @flovilmart

@nlutsenko trying without master right now. Didn't notice that you had published a release with full Carthage support :smile:
ParseKit doesn't get built if I use the --no-use-binaries flag, so I'm 100% sure it's not affecting the build when I update as I am right now

Not targeting "master" seems to have done the trick!

Perfect! Glad it helped!


Progress flags system for tracking player progress

I am no longer sure if this is necessary, perhaps a "mission" component should take care of tracking player's progress
A very simple system that i totally didn't overthink and spent a day making with a single player game in mind before screwing my brain on right.
Stores a dictionary of String:bool pairs that can be used to keep track of what the player has done, like if he completed a certain mission or visited a certain area.
TODO:

[ ] ~Allow categorization of flags (basically another Dictionary layer)~

Feels like a wrong approach, some code could be salvaged but it otherwise seems to be a bit too "multi-purpose" for it's own good.


Distributed configuration

Zookeeper should be used to store configuration, so context changes will immediately be reflected by all edge servers vs. config template management via Chef et. all.
Templates could also be considered for storage in ZK.

I'd rather that administrators use what they're comfortable with vs. forcing yet another paradigm on them.


Adding Microsoft activities  to the project option is missing in intellij

Environment:
OS - Windows / Ubuntu 14.04
Plugin Version - 0.1.227 , Daily Build 300
IDE - Intellij 14.1.3, JRE 1.8
Authentication - Publish Settings file
Steps
Create a android  project in intellij.
Go to the app folder and right click on it.
Select New .
Microsoft activity option is unavailable in case of intellij .
Screenshot attached for intellij .

Although , in case of Android Studio , we can still add Microsoft activities as we used to add earlier.
Screenshot for Android Studio attached.

This issue is reproducible in the latest build.

Issue is not reproducible in build 0.1.239


rebuild 0.9.58

Do not perform pip check
MNT: Re-rendered with conda-build 3.21.8, conda-smithy 3.19.0, and conda-forge-pinning 2<IP_ADDRESS>.50.18
Bump build number

Checklist

[ ] Used a personal fork of the feedstock to propose changes
[ ] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[ ] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[ ] Ensured the license file is being packaged.

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.


Feature/wireframe changes

This is very clearly just a first pass, and there are several places where I've just put placeholders in that don't actually work, but think that's in keeping with what we were expecting for these two tickets.

Coverage decreased (-0.7%) to 89.68% when pulling a7863b9273b91f3177124e93cb0a44d3d19c29aa on feature/wireframe-changes into 54bcf7a84f1327ff97ae162c0303c170d5cee814 on develop.

Coverage decreased (-0.7%) to 89.68% when pulling a7863b9273b91f3177124e93cb0a44d3d19c29aa on feature/wireframe-changes into 54bcf7a84f1327ff97ae162c0303c170d5cee814 on develop.

Coverage decreased (-0.7%) to 89.755% when pulling 989cc7bd276323b8dda07bda6d7cd0adda00eadd on feature/wireframe-changes into 54bcf7a84f1327ff97ae162c0303c170d5cee814 on develop.

Coverage decreased (-0.5%) to 89.943% when pulling b3f55e10d64d39354662b5d81854cda8250bf804 on feature/wireframe-changes into 54bcf7a84f1327ff97ae162c0303c170d5cee814 on develop.

Coverage decreased (-0.5%) to 89.943% when pulling cb47dbdd3a3723f91cae711bc950456376d79e21 on feature/wireframe-changes into 54bcf7a84f1327ff97ae162c0303c170d5cee814 on develop.

Coverage decreased (-0.5%) to 89.943% when pulling ec651022feb8987c431454bed31a8b376f88ea85 on feature/wireframe-changes into 54bcf7a84f1327ff97ae162c0303c170d5cee814 on develop.


SVG CSS Block conflicts with LeafletJS

The SVG CSS:
svg {
width: 1.8em;
height: 1.8em;
fill: #fff; }
hides the polylines of LeafletJS. It probably should not be global.
I fixed it this way:
.sc-icon svg {
width: 1.8em;
height: 1.8em;
fill: #fff; }

Same issue here. I fixed in the same way.
Please fix the issue, so annoying.


add hyperloglog implementation (add and count)

Which issue does this PR close?
Related #1087 and serves as a pre-cursor to that pull request
Closes #.
Rationale for this change
I'm thinking of adopting Redis's hyperloglog implementation along with https://github.com/crepererum/pdatastructs.rs/blob/master/src/hyperloglog.rs for its code structure.
I don't necessarily want to use @crepererum pdatastructs as is because:

this way the code size of datafusion is well controlled and since we can make some reasonably good strong assumption on the usage pattern, we can skip some of the generics and adopt Redis's approach (e.g. precision = 14 with 16384 registers, but also each with u8 size instead of the raw byte array in C in order to save space, trading off with rather tricky bit shifting techniques - this way instead of max size of 12KiB we'll have 16KiB per HLL)
also we need to have either bincode serde so that merge can work across record batches

What changes are included in this PR?

Are there any user-facing changes?

@Jimexist  how do you think the current implementation compares with https://crates.io/crates/hyperloglogplus ?


EDAC: IBECC: Refactor tests for new API

Refactor tests for new ZTEST, using new helpers like Z_TEST_SKIP_IFNDEF. Make also all tests independent, suitable for shuffle.

@finikorg @nashif  I'm seeing a lot of calls to TC_PRINT in this test, my understanding was that TC_ macros are meant to be internal to the test subsystem to be able and keep an easy format, should these be logs instead?

@finikorg @nashif I'm seeing a lot of calls to TC_PRINT in this test, my understanding was that TC_ macros are meant to be internal to the test subsystem to be able and keep an easy format, should these be logs instead?

I added commit af9f5da replacing TC_PRINT to logging api. For the coverage test I source C file so I cannot change the same way.

@nashif could you review this PR


Set zoom level programatically

Hello! I've integrated SwiftyCam to my project and works awesome!
But I'm having an issue with the zoom and I'd need to find a way to reset the zoom level to the default when the camera appears.
override func viewDidAppear(_ animated: Bool) {
  super.viewDidAppear(animated)
  captureButton.delegate = self
  if let callback = onCameraReady {
    callback()
  }

  // would be great to call something like this
  self.resetZoomLevel()

  // or like this
  self.setZoomLevel(3)
}

Do you know how can we achieve this?

Just copied the source folder to my project and added this method to SwiftyCamViewController:

@objc public func setZoomLevel(zoom: CGFloat) {
        do {
            let captureDevice = AVCaptureDevice.devices().first
            try captureDevice?.lockForConfiguration()

            zoomScale = zoom

            captureDevice?.videoZoomFactor = zoomScale

            DispatchQueue.main.async {
                self.cameraDelegate?.swiftyCam(self, didChangeZoomLevel: self.zoomScale)
            }

            captureDevice?.unlockForConfiguration()

        } catch {
            print("[SwiftyCam]: Error locking configuration")
        }
    }


Remove NotImplementedError in resample with rule

This PR closes #6271

[x] Tests added / passed
[x] Passes black dask / flake8 dask

Test failure is unrelated. LGTM, merging. Thanks @abduhbm!

Congrats @abduhbm on your first PR in dask :)


Log files from previous day are missing

Issue Info

Info
Value

Platform Name
ios

Platform Version
11.3.1

CocoaLumberjack Version
3.4.2

Integration Method
cocoapods

Xcode Version
Xcode 9.3

Repro rate
all the time (100%)

Issue Description and Steps
I have this fileLogger config
fileLogger.rollingFrequency = -1  //don't rollout
self.fileLogger.maximumFileSize = 1024 * 1024 * 10 //10mb file size
self.fileLogger.logFileManager.maximumNumberOfLogFiles = 5

Logging seems to work fine but when I open app next day I see only 1 log file with size smaller then maximumFileSize which contains data only since app started that day. There are no archived log files. Any idea what can be problem? Did I miss something in config? Thanks

@vandzi thanks for your interest in CocoaLumberjack. Can you debug your case? Check maybeRollLogFileDueToSize and maybeRollLogFileDueToAge, see if they are called.

Closing - lack of response.


[Logistic] Sprint 2 goals planning

In this sprint, a few expectations should be met

A prototype app get implemented with all the fundamental features

[x] welcome page #12
[x] political "slider" #12
[x] player matching algorithm for 2 and 4 players #16 and #21
[x] content presenting with WKWebView #19
[x] real time chatting based on Firebase #11
[x] questionnaire #5
[x] result collecting #18
[x] (optional) profile page #18 , not created since it is trivial < 3hrs.

Server side matching algorithm
Beta testing workflow
Documentation for implemented features

[ ] use Wiki page: https://github.com/DukeMobileDevCenter/Jigsaw/wiki

@profRic Today I wrapped up #21 and it should call for Sprint 2. 🎉  Pretty hard to gather all the pieces and make the app running! 😪
Maybe we can set up another meeting to share the demo with clients next week, while I'll make small fixes this Sunday.


Fix for module building

The index.js isn't a great solution right now - I'd like to see that part properly generated but it's needed to import { module } from ngx-widgets

Can one of the admins verify this patch?


RDKTV-33096: Wpeframework crash with signature RDKShell::subscribeForSystemEvent and fingerprint 48714301

Reason for change: adding lock-unlock in
RDKShell::subscribeForSystemEvent() for proper synchronization Test Procedure: as mentioned in RDKTV-33096
Risks: Low
Priority: P1
Signed-off-by:Boopathi Vanavarayan<EMAIL_ADDRESS>

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


chore: upgrade<EMAIL_ADDRESS>

Closes https://github.com/FuelLabs/fuels-ts/issues/3051

Release notes
In this release, we:

Upgraded fuel-core to v0.35.0

Checklist

[x] All changes are covered by tests (or not applicable)
[x] All changes are documented (or not applicable)
[x] I reviewed the entire PR myself (preferably, on GH UI)
[x] I described all Breaking Changes (or there's none)

@maschad We have come conflicts to solve here


Input suggestions are sometimes hidden if the startSuggestion attribute is set

OpenUI5 version: 1.84.14
Browser/version (+device/version): Edge, Chrome, Windows 10
URL (minimal example if possible):
https://github.com/faow/sap.m.sample.InputSuggestionsOpenSearch
Steps to reproduce the problem:

Open the app

Type "pr"

Delete the "r" and type "c" -> no more suggestions

Delete the "c" and type "o"

Click outside of the field.
The suggestions get displayed each time.
What happens instead?
Sometimes the suggestion dialog is not displayed
Any other information? (attach screenshot if possible)
The app sap.m.sample.InputSuggestionsOpenSearch is extended with the attribute startSuggestion="2".
If the attribute is not set, it works.

Hello @faow ,
Seems this problem is specific for 1.84 and is not reproducible on master and on latest release.
So the issue is already fixed and I recommend an upgrade to the latest stable version.
If the upgrade for some reason is not possible and there is a good reason to stay on 1.84 - you can reopen the issue and we can discuss if downport is needed and possible.
Best Regards,
Alexandar Mitsev

Hello @alexandar-mitsev and thank you for your reply.
So if i got you right, even if that problem exists in the latest long-term maintenance version of UI5 and also affects SAPUI5 it wont get fixed on both sides.
How would i report this to the SAPUI5 team then? Open an issue at https://support.sap.com/en/index.html ?
Don't get me wrong here, but i thought the patches on the versions are identical
Best Regards,
Fabian Wolf

Hi @faow ,
It is already fixed in latest stable version 1.92 for OpenUI5 and 1.92 for SAPUI5.
With the monthly release it is best if you always upgrade to the latest stable version - 1.92 in this case.
If you have special circumstances which require you to use OpenUI5 1.84 or SAPUI5 1.84 and you think the problem has high impact - then we can consider a downport to 1.84. SAPUI5 is a superset of OpenUI5 so it will always receive the same fix.
Regards,
Alexandar Mitsev

Hello @alexandar-mitsev ,
thanks again for your reply.
We always use the latest long term maintenance version of SAPUI5 until the next one is released.
This has several reasons, for example productive use and loading the UI5 version on premise.
This behavior occurred for the first time with an implemented address search.
The search is performed only after the 3rd character of the street input to reduce the search queries and the amount of data in requests.
We have implemented a work-around that ensures the suggestion dropdown opens correctly but additionally wanted to report this bug as more people may be affected. (1.84.X is still the current on-premise version of the framework as far as i know)
I don't know to what extent this bug affects other customers/users or some of the Fiori applications running with the on premise version are also affected and if this is the right place to discuss this, as this issue is more related to SAP systems and the current on premise version.
Please provide brief feedback if this belongs more in SAP's OSS.

Keep up the good work,
Fabian Wolf

Hi @faow ,
Yes normally if you use SAPUI5 you must report in the customer ticket system or in the internal SAP ticket system. You should be familiar with at least one of them I guess.
Ok about the downport.
Regards,
Alexandar Mitsev

@alexandar-mitsev
Then I apologize for using the wrong end of the error reporting options.
I will re-open this bug report at SAP's OSS.
Thanks for your time.


[release-1.21] manifests: add gateways.securityContext option to custom gateway securityContext

Please provide a description of this PR:
Manual cherry of https://github.com/istio/istio/pull/51234
Fixes https://github.com/istio/istio/issues/51360

/retest

@nicole-lihui: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-basic-arm64_istio_release-1.21
1ad33859217ec38b674360d66c9ff47c55cf724e
link
true
/test integ-basic-arm64

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

/test integ-basic-arm64_istio_release-1.21


Creating Text Components: H1, H2, H3, H4 + Body 1 - 3

Could you also use these in the components where needed?


Accept room names for robot.messageRoom

[X] I've read and understood the Contributing guidelines and have done my best effort to follow them.
[X] I've read and agree to the Code of Conduct.
[X] I've been mindful about doing atomic commits, adding documentation to my changes, not refactoring too much.
[X] I've a descriptive title and added any useful information for the reviewer. Where appropriate, I've attached a screenshot and/or screencast (gif preferrably).
[X] I've written tests to cover the new code and functionality included in this PR.
[X] I've read, agree to, and signed the Contributor License Agreement (CLA).

PR Summary
Previous to hubot-slack 4.0.0, robot.messageRoom would accept room names.  This PR translates room names to room ids, in order to improve compatibility with existing hubot scripts.
Test strategy
Write a hubot script that sends a message to a room by name, e.g.:
module.exports = (robot) ->

  robot.respond /test messageRoom/, (msg) ->
    room = 'general'
    robot.messageRoom room, 'hi there!'

This will not work with hubot-slack 4.0.2.

Changes Unknown when pulling cfac95ac1756a6f87907aee3f7d41325e84e49ad on mdelagrange:accept-room-names into ** on slackhq:master**.

:+1:
Fixes: #349

Actually, personally I'd prefer this with the # channel prefix demarking the fact that it's a channel name, or using the RECOGNIZED_API_TYPE_PREFIXES to determine it's not an API prefix?

Actually, personally I'd prefer this with the # channel prefix demarking the fact that it's a channel name, or using the RECOGNIZED_API_TYPE_PREFIXES to determine it's not an API prefix?

Actually getChannelByName(room) works with or without the hash, so your example should work fine.

Changes Unknown when pulling 3ebbfd07299f8f8e6426483fd4ad844cc05f1411 on mdelagrange:accept-room-names into ** on slackhq:master**.

Channels begin with C not C0

Since Slack channels never have capital letters, I'm just testing for those now.  That should be a reliable test.

@mdelagrange I would expect that if I put in 'GENERAL'  that it would push to #general ?

That wasn't the behavior in hubot-slack < 4.0.0.  Channel names were case sensitive in previous versions.  I'd like to avoid an unnecessary API call, so that's my reason for sticking with case sensitivity.

LGTM

@DEGoodmanWilson: I just tested out this fix, which works great; but (and forgive me if I'm misunderstanding the process here) the package.json version number hasn't been updated. This means the latest version on NPM doesn't have this fix included. Is that intentional?

Right, I don't think I released this. Last two weeks have been a bit hectic :( Will look into this ASAP


Sync didn't timeout when no new data downloaded from sensor

Description:
S21 Ultra
Sensor with 3.31.1 fw
df 5
Syncing 10 days sensor data through GATT stalled at one point, Lauri waited for over 1 minute and there was no timeout.
Check that timeout occurs in 30 seconds if no new data can be downloaded from sensor.

Lauri will test again after Android OS update.

https://drive.google.com/file/d/1ADYk3UWqHd4EFgoQGStUQRmPgkvQPXPE/view?usp=sharing
This was tested by driving away from my house where the sensor was located.
There is no timeout, OS12.

This seems to be similar to IOS issue
https://github.com/ruuvi/com.ruuvi.station.ios/issues/1599
Easier way to duplicate :
This problem can be duplicated with a ruuvi with RSSI less then about -80dB
with a lot of history to sync. Get sync started then
place it on a MacBookPro keyboard then nearly closing the screen, as the aluminum case absorbs (or reflects?) the radio signal.

No timeout also confirmed on OS13, when returning back to vicinity of the sensor, app starts to read advertisements.

2.6.4 the issue is same. This was just recently fixed in iOS, I think Muzibur found a working solution.
Here are 2 videos of what happens:

Bluetooth sync started and moved away from sensor, waiting for timeout, which never happens
https://drive.google.com/file/d/10GZJlxdK54syp0mLs6IL9F9APuefUKWU/view?usp=sharing

Moved back to sensor range, sync didn't continue but Bluetooth started updating measurements
https://drive.google.com/file/d/109WjCcv9y44d2P6zto9EbtjjUIXoZzSA/view?usp=sharing

QA passed


Simplistic fix to hostname issue

Turns out that the "hostname" attribute isn't always available from ec2metadata.  It's also the case that not every Kafka cluster lives in AWS, so in the event that we can't get ec2metadata, let's still set the hostname.

thanks for making the change!