Message: Interface/AddOns/CraftSim/DB/itemRecipeDB.lua:44: bad argument #1 to 'pairs' (table expected, got nil)

Message: Interface/AddOns/CraftSim/DB/itemRecipeDB.lua:44: bad argument #1 to 'pairs' (table expected, got nil)
Time: Sat Apr 27 12:41:01 2024
Count: 1
Stack: Interface/AddOns/CraftSim/DB/itemRecipeDB.lua:44: bad argument #1 to 'pairs' (table expected, got nil)
[string "=[C]"]: in function pairs' [string "@Interface/AddOns/CraftSim/DB/itemRecipeDB.lua"]:44: in function Migrate'
[string "@Interface/AddOns/CraftSim/DB/DB.lua"]:49: in function Init' [string "@Interface/AddOns/CraftSim/Init/Init.lua"]:236: in function ?'
[string "@Interface/AddOns/CraftSim/Libs/GUTIL/GUTIL.lua"]:232: in function <Interface/AddOns/CraftSim/Libs/GUTIL/GUTIL.lua:232>
Locals: (*temporary) = nil
(*temporary) = "table expected, got nil"
=  defined =[C]:-1

2nd error in thos row:
Message: Interface/AddOns/CraftSim/DB/multicraftPreloadDB.lua:37: attempt to index field 'multicraftPreloadDB' (a nil value)
Time: Sat Apr 27 12:41:15 2024
Count: 1
Stack: Interface/AddOns/CraftSim/DB/multicraftPreloadDB.lua:37: attempt to index field 'multicraftPreloadDB' (a nil value)
[string "=[C]"]: ?
[string "@Interface/AddOns/CraftSim/DB/multicraftPreloadDB.lua"]:37: in function ClearAll' [string "@Interface/AddOns/CraftSim/Init/Init.lua"]:36: in function ?'
[string "@Interface/AddOns/CraftSim/Libs/GUTIL/GUTIL.lua"]:232: in function <Interface/AddOns/CraftSim/Libs/GUTIL/GUTIL.lua:232>
Locals: (*temporary) =  defined =[C]:-1

I've run into this as well.
Craftsim windows won't show, which prompted me to see if anything came up in bugsack.
No idea if the error is related to the addon not working for me, or not.

-> 16.1.5


Catching net::ERR_INTERNET_DISCONNECTED

Hello. I was wondering if someone can help me catch the specific error "net::ERR_INTERNET_DISCONNECTED".
This only happens if I were to run the code when my internet is not connected. What happens afterwards is that once I do try to run my code, functions such as "page.reload()" are completely non-functional. I spent some time myself to try resolving. And I'm not sure exactly how to catch this and some other specific errors. Ideally this scenario would never happen if I were to try and start it up, but if for some reason I do and I do not catch it at that time, I would like to make it so that it would somehow restart itself if possible.
I tried using "browser.on()" and "page.on()", but it seems that once it does not work without internet connection the first time, nothing will be able to interact with it.

@ProgramJack check this solution: https://github.com/puppeteer/puppeteer/issues/1454#issuecomment-945575831


Make std.range.choose{Among}? @safe & ctfe-able

also extracted the voldemort type to avoid enormous symbol names for chooseAmong.
The core idea:

Use a union to allow ctfe
Slightly abuse @trusted by relying on the constructor to be the only place that modifies r1Chosen, therefore allowing @trusted access to the correct member of the union from that point onwards.

Fixes https://issues.dlang.org/show_bug.cgi?id=14660

@andralex  This comment is not necessarily in the scope of this PR, but IMO a really useful enhancement for chooseX would be to implement the ability to choose between ranges according to a choice function that's evaluated every time popFront is called.

@quickfur what would be some good uses of that?

Functional reactive programming is full of examples. Have a look at the combining operators on this page: http://reactivex.io/documentation/operators.html for inspiration (the interactive diagrams in the docs are quite nice). I use FRP operators like Merge, CombineLatest and Switch quite often when dealing with event streams.

@andralex

Looking at the implementation it becomes clear that the use of union becomes a liability here. Let's do this:

Use simple direct members of types R1 and R2 plus a bool.

I have simplified the implementation but kept the union, it hasn't cost any complexity really.

By default the unused range is simply initialized to its init value. The other one is initialized appropriately.

Done.

If both ranges return a ref from front, back, and the index operators, the result should also return ref.

Done.

Seeing as there are all these lambdas I thought I should add tests for @nogc, done now.

@andralex are you happy with the changes I've made?

This is not meant to hold up merging of this PR, but just a note that since Rainer's symbol compression PR has been checked into dmd, we no longer need to put extra effort into pulling out Voldemort structs just to avoid symbol bloat overload.  Doing so still does save us some amount of space (on top of what Rainer's PR already does), but by a smaller margin, and the last consensus was that any fix in this direction ought to be automated in the compiler rather than hacked in Phobos.

@quickfur how is this related to symbol compression?

The first sentence in the PR description alludes to pulling out the Voldemort struct in order to avoid symbol bloat.


Update .env

Hi, your DarkSky API it is unique and assigned to you, it should not be shared with others.

PS - you should go to the DarkSky site and revoke the existing key and create a new one.


Reduce dio package pana analyzer to 90 points

:scroll: Description
Follow up #718
:bulb: Motivation and Context
#skip-changelog
:green_heart: How did you test it?
:pencil: Checklist

[ ] I reviewed submitted code
[ ] I added tests to verify changes
[ ] I updated the docs if needed
[ ] All tests passing
[ ] No breaking changes

:crystal_ball: Next steps
https://github.com/dart-lang/pana/issues/1020

Remember to increase it after publishing the next stable version. Then the issues should be gone.

dart-lang/pana#1020

Yep, See this as well: https://github.com/dart-lang/pana/issues/1020

Codecov Report

Merging #764 (b22fac9) into main (f4c06af) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #764   +/-   ##
=======================================
  Coverage   90.52%   90.52%
=======================================
  Files         105      105
  Lines        3378     3378
=======================================
  Hits         3058     3058
  Misses        320      320

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f4c06af...b22fac9. Read the comment docs.


Update generated source code

Automated PR triggered by new code generation.
Update generated source code
Generated SDK source code using:

Generator version 3.26.0
Specification version 1.0.0-dev0.0.30
Automation (cloudant-sdks) version 409f3f1

Thank you for reviewing @mojito317 !


nested expanding not working

I'm trying to create nested sidebar using expanding component.
But nested expanding components does not work.
While the inside expanding component was opened, the outside one won't expand
Any idea to make it work?
Thanks
<expanding>
   ...some list items
  <expanding>
    ..some list items
  </expanding>
</expanding>

here is my testing code, please help for this
thanks
<template>
    <expanding v-show="show1">

test item 1

test item 2

test item 3

test item 4

test item 5

test item 6

        <expanding v-show="show2">

test item 1

test item 2

test item 3

test item 4

test item 5

test item 6

        </expanding>

    </expanding>
    <button @click="show1 = !show1">show1</button>
    <button @click="show2 = !show2">show2</button>

</template>


Create Firebase account for likes and views

https://blowfish.page/docs/firebase-views/

Create a new account.


[BUG] Saving is trying to update fields from relationship

I have Table "Offers" which has two more relations (Client and Broker) which are not indexed into ES.
When I save the one thats indexed I get error "Bulk update error".
Checked the laravel log and noticed its trying to update the fields from one of the relationships.

Log file:
laravel-2022-10-28.log
Versions
Laravel: 9.6
Scout: 9.4
Scout Elasticsearch: 6.0
Elasticsearch: 8.4.3

https://laravel.com/docs/master/scout#configuring-model-indexes
Did you check what data contains your model when you call toArray method on it? Think about to configure toSearchableArray method

https://laravel.com/docs/master/scout#configuring-model-indexes Did you check what data contains your model when you call toArray method on it? Think about to configure toSearchableArray method

Yes I did, everything there was normal.
This is my toSearchableArray code:
`public function toSearchableArray()
{
$array = $this->toArray();
    // Load meta
    $offer_meta = AgencyOfferMeta::where('agency_id', $array['agency_id'])
        ->where('agency_offer_id', $array['id'])->get();

    foreach ($offer_meta as $meta)
    {
        if(in_array($meta['key'], $array)) continue;
        $array[$meta['key']] = $meta['value'];
    }

    return $array;
}`

I tried to also remove the loading of meta that I have there, it did not resolve the issue.
Since when i tried to remove the 2 relationships i mentioned above it resolved the problem, but I need them.

Maybe mappings for your data is wrong. You can try to log request that you're trying to send to elastic and then to check if it match to yours mappings. https://www.elastic.co/guide/en/elasticsearch/client/php-api/current/enabling_logger.html


[v14CE] copier copy error when try to run 'copier copy gh:Tecnativa/doodba-copier-template'

Invalid Version Error
When i try to run 'copier copy gh:Tecnativa/doodba-copier-template';
The error message below appear:
Traceback (most recent call last):
File "/home/maicondmenezes/.local/bin/copier", line 8, in
sys.exit(CopierApp.run())
File "/home/maicondmenezes/.local/pipx/venvs/copier/lib/python3.9/site-packages/plumbum/cli/application.py", line 639, in run
inst, retcode = subapp.run(argv, exit=False)
File "/home/maicondmenezes/.local/pipx/venvs/copier/lib/python3.9/site-packages/plumbum/cli/application.py", line 634, in run
retcode = inst.main(*tailargs)
File "/home/maicondmenezes/.local/pipx/venvs/copier/lib/python3.9/site-packages/copier/cli.py", line 71, in _wrapper
return method(args, **kwargs)
File "/home/maicondmenezes/.local/pipx/venvs/copier/lib/python3.9/site-packages/copier/cli.py", line 294, in main
self.parent._worker(
File "/home/maicondmenezes/.local/pipx/venvs/copier/lib/python3.9/site-packages/copier/main.py", line 620, in run_copy
src_abspath = self.template_copy_root
File "/usr/lib/python3.9/functools.py", line 969, in get
val = self.func(instance)
File "/home/maicondmenezes/.local/pipx/venvs/copier/lib/python3.9/site-packages/copier/main.py", line 593, in template_copy_root
subdir = self._render_string(self.template.subdirectory) or ""
File "/usr/lib/python3.9/functools.py", line 969, in get
val = self.func(instance)
File "/home/maicondmenezes/.local/pipx/venvs/copier/lib/python3.9/site-packages/copier/template.py", line 402, in subdirectory
return self.config_data.get("subdirectory", "")
File "/usr/lib/python3.9/functools.py", line 969, in get
val = self.func(instance)
File "/home/maicondmenezes/.local/pipx/venvs/copier/lib/python3.9/site-packages/copier/template.py", line 263, in config_data
result = filter_config(self._raw_config)[0]
File "/usr/lib/python3.9/functools.py", line 969, in get
val = self.func(instance)
File "/home/maicondmenezes/.local/pipx/venvs/copier/lib/python3.9/site-packages/copier/template.py", line 222, in _raw_config
for p in self.local_abspath.glob("copier.")
File "/usr/lib/python3.9/functools.py", line 969, in get
val = self.func(instance)
File "/home/maicondmenezes/.local/pipx/venvs/copier/lib/python3.9/site-packages/copier/template.py", line 439, in local_abspath
checkout_latest_tag(result, self.use_prereleases)
File "/home/maicondmenezes/.local/pipx/venvs/copier/lib/python3.9/site-packages/copier/vcs.py", line 109, in checkout_latest_tag
sorted_tags = sorted(all_tags, key=version.parse, reverse=True)
File "/home/maicondmenezes/.local/pipx/venvs/copier/lib/python3.9/site-packages/copier/vcs.py", line 107, in
lambda tag: not version.parse(tag).is_prerelease, all_tags
File "/home/maicondmenezes/.local/pipx/venvs/copier/lib/python3.9/site-packages/packaging/version.py", line 52, in parse
return Version(version)
File "/home/maicondmenezes/.local/pipx/venvs/copier/lib/python3.9/site-packages/packaging/version.py", line 197, in init
raise InvalidVersion(f"Invalid version: '{version}'")
packaging.version.InvalidVersion: Invalid version: 'v0.0.0-0-0'
To Reproduce
Just install the requirements and try to copy the template
Affected versions:
Steps to reproduce the behavior:
1.Install dependences:
https://github.com/Tecnativa/doodba-copier-template#install-the-dependencies

Install requirements:
python3 -m pip install --user pipx
pipx install docker-compose
pipx install copier
pipx install invoke
pipx install pre-commit
pipx ensurepath

Run copier template command:
copier copy gh:Tecnativa/doodba-copier-template

Expected behavior A clear and concise description of what you expected to happen.
Start's template copier wizard

This was fixed in #364
Have you checked again recently?

thanks i will check,
Do you have a full course about infrastructure and/or devops operations
with odoo and tecnativa template?
On Wed, Jan 25, 2023 at 4:26 AM Pedro M. Baeza @.***>
wrote:

This was fixed in #364
https://github.com/Tecnativa/doodba-copier-template/pull/364
Have you checked again recently?
—
Reply to this email directly, view it on GitHub
https://github.com/Tecnativa/doodba-copier-template/issues/367#issuecomment-1403198862,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/A2EZR2ZQ5QEBX5AQ3I2TDBDWUDITHANCNFSM6AAAAAAUFYRYYY
.
You are receiving this because you authored the thread.Message ID:
@.***>

I have exactly the same error now.
It's strange, #364 seems like it should have solved it but it doesn't.
Ubuntu 22.04
$ copier copy gh:Tecnativa/doodba-copier-template ~/Dev/doodba-test
Traceback (most recent call last):
  File "/home/quim/.local/bin/copier", line 8, in <module>
    sys.exit(CopierApp.run())
  File "/home/quim/.local/pipx/venvs/copier/lib/python3.10/site-packages/plumbum/cli/application.py", line 639, in run
    inst, retcode = subapp.run(argv, exit=False)
  File "/home/quim/.local/pipx/venvs/copier/lib/python3.10/site-packages/plumbum/cli/application.py", line 634, in run
    retcode = inst.main(*tailargs)
  File "/home/quim/.local/pipx/venvs/copier/lib/python3.10/site-packages/copier/cli.py", line 71, in _wrapper
    return method(*args, **kwargs)
  File "/home/quim/.local/pipx/venvs/copier/lib/python3.10/site-packages/copier/cli.py", line 298, in main
    ).run_copy()
  File "/home/quim/.local/pipx/venvs/copier/lib/python3.10/site-packages/copier/main.py", line 620, in run_copy
    src_abspath = self.template_copy_root
  File "/usr/lib/python3.10/functools.py", line 981, in __get__
    val = self.func(instance)
  File "/home/quim/.local/pipx/venvs/copier/lib/python3.10/site-packages/copier/main.py", line 593, in template_copy_root
    subdir = self._render_string(self.template.subdirectory) or ""
  File "/usr/lib/python3.10/functools.py", line 981, in __get__
    val = self.func(instance)
  File "/home/quim/.local/pipx/venvs/copier/lib/python3.10/site-packages/copier/template.py", line 402, in subdirectory
    return self.config_data.get("subdirectory", "")
  File "/usr/lib/python3.10/functools.py", line 981, in __get__
    val = self.func(instance)
  File "/home/quim/.local/pipx/venvs/copier/lib/python3.10/site-packages/copier/template.py", line 263, in config_data
    result = filter_config(self._raw_config)[0]
  File "/usr/lib/python3.10/functools.py", line 981, in __get__
    val = self.func(instance)
  File "/home/quim/.local/pipx/venvs/copier/lib/python3.10/site-packages/copier/template.py", line 222, in _raw_config
    for p in self.local_abspath.glob("copier.*")
  File "/usr/lib/python3.10/functools.py", line 981, in __get__
    val = self.func(instance)
  File "/home/quim/.local/pipx/venvs/copier/lib/python3.10/site-packages/copier/template.py", line 439, in local_abspath
    checkout_latest_tag(result, self.use_prereleases)
  File "/home/quim/.local/pipx/venvs/copier/lib/python3.10/site-packages/copier/vcs.py", line 109, in checkout_latest_tag
    sorted_tags = sorted(all_tags, key=version.parse, reverse=True)
  File "/home/quim/.local/pipx/venvs/copier/lib/python3.10/site-packages/copier/vcs.py", line 107, in <lambda>
    lambda tag: not version.parse(tag).is_prerelease, all_tags
  File "/home/quim/.local/pipx/venvs/copier/lib/python3.10/site-packages/packaging/version.py", line 52, in parse
    return Version(version)
  File "/home/quim/.local/pipx/venvs/copier/lib/python3.10/site-packages/packaging/version.py", line 197, in __init__
    raise InvalidVersion(f"Invalid version: '{version}'")
packaging.version.InvalidVersion: Invalid version: 'v0.0.0-0-0'

Does this happen for new scaffoldings or are you running it in an old one? Which version of copier do you have?

Just reinstalled ubuntu 22, and doodba with his requirements today and creating my first doodba test to try it.
Versions:
$ copier --version
copier 7.0.1
$ pre-commit --version
pre-commit 3.0.1
$ python3 --version
Python 3.10.6

And do you still have the same problem?

Yes
El ds., 28 de gen. 2023, 9:13, Pedro M. Baeza @.***> va
escriure:

And do you still have the same problem?
—
Reply to this email directly, view it on GitHub
https://github.com/Tecnativa/doodba-copier-template/issues/367#issuecomment-1407328382,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AIZRN2UF523RHQGI7PI46S3WUTIKTANCNFSM6AAAAAAUFYRYYY
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

It still happens.
Using clean debian10 installation, same process:
python3 -m pip install --user pipx
pipx install docker-compose
pipx install copier
pipx install invoke
pipx install pre-commit
pipx ensurepath
copier copy gh:Tecnativa/doodba-copier-template .

Changing LATEST_VERSION_WITHOUT_COPIER = "v0.0.0" yo v0.0.1 works for me in my fork.

Copier will keep using the latest released version, and the fix is not yet released.
You can use copier -r HEAD copy gh:Tecnativa/doodba-copier-template . in the mean time.

Ouch, I didn't remember about the releasing. Done.


Front - V1 - iOS - Display all newsletters

• Create the screen
Model :
• If we don't have newsletter : create the component with label text "No newsletter"

android implementation


Fix resolve of git dirs finding a parent non-bare repo if wd is a bare repo

This causes tests to fail if GIT_LFS_TEST_DIR is not set, since the bare repo tests actually cascade up to the git-lfs repo itself and start modifying config files in there. Might potentially affect other cases where a bare repo is inside a non-bare repo.
Resolution is to use git rev-parse to locate all dirs instead of manually recursing. Could potentially remove manual processing of GIT_DIR and GIT_WORK_TREE in future but have left as belt & braces for now.
Had to remove test for using relative GIT_WORK_TREE with no GIT_DIR, git rev-parse always fails in that case so it appears it's not supported by git even though man git-config claims it is.

:+1: Feels good to butcher recursiveResolveGitDir() :)


Fix non-existing targets when not using Visual Studio generators

This PR enable generator others than the Visual Studio family to build the MDL-SDK on Windows (e.g. Ninja).
In essence, this is duplicating some of LLVM CMake setup guard against referenced CMake targets.

Thank you for your contribution! I have merged your PR to our internal build, it will be part of the next push to Github.


Simplify slf4j reporting when logging is disabled

Avoid overhead when logging is disabled for the specified reporting log level or marker.

Thanks! Also pulled this into 3.1-maintenance.

Thanks for the quick review and merge @ryantenney!


charts version upgrade of jenkins-x/exposecontroller-service

change jenkins-x/exposecontroller-service to version 1.0.7

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: rajdavies
If they are not already assigned, you can assign the PR to them by writing /assign @rajdavies in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Hi @mortenv. Thanks for your PR.
I'm waiting for a jenkins-x member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.


Added a fix for mfa rule to only evaluate console users

This rule was evaluating cli users which don't have a console password and hence cannot use MFA login mechanism. Added a check to fetch user profile before deciding on the MFA attached status. For cli user's get_login_profile will throw an exception which we can use to skip over these users.

@gregjinkim I have added the changes you asked.

@gregjinkim any chances to merge this PR ?


Handle bad POSTs when StreamField has no form

Previously, attempted form POSTs on pages where the main content StreamField had no form were not correctly returning a 400 response. This change fixes that.
See errors from the evening of 5/31/20 documented at https://GHE/CFGOV/cfgov-alerts/issues/23 and Mattermost discussion at: https://MM/cfpb/pl/bdqukr8frtynbkimq43jbbgu5w
Changes

Moves result = form_module.block.get_result(…) into try/except block to ensure that an improperly-derived form_module doesn't throw a 500 there.

Testing
Tests pass; new test added for this particular scenario.
Checklist

[ ] PR has an informative and human-readable title
[ ] Changes are limited to a single goal (no scope creep)
[ ] Code can be automatically merged (no conflicts)
[ ] Code follows the standards laid out in the CFPB development guidelines
[ ] Passes all existing automated tests
[ ] Any change in functionality is tested
[ ] New functions are documented (with a description, list of inputs, and expected output)
[ ] Placeholder code is flagged / future todos are captured in comments
[ ] Visually tested in supported browsers and devices (see checklist below :point_down:)
[ ] Project documentation has been updated
[ ] Reviewers requested with the Reviewers tool :arrow_right:

This looks alright to me. Could we add a little more in the docstring on/around line 269 that if form_id is not a block that implements get_result() to process the POST that it will also return an error response?

Good call, @willbarton. Done! Merging when green.


Navigation bar fixed

Preview at http://shivangag.github.io/quadrotor-IITKgp.github.io/

Closed #18


Feature question

This is not an issue but a feature question. Are there any plans to have a horizontal navigation bar by default and switch to sidebar when Browser is resized? Or any idea for a start?
Thanks

Horizontal menu (Menu bar) would be great enhancement to current vertical menubar


Field insertion for Select

One thing that seems like it could become problematic is:
http://godoc.org/github.com/coopernurse/gorp#DbMap.Select
"Returns an error if one or more columns in the result do not match"
I think the common case will be someone writing
type Model struct {
  // many fields
}
dbm.Select(&models, "SELECT * FROM models WHERE ...")

Presently, as soon as a field is added to the table, the Select will start returning errors.  This requires the developer to type out the entire field list for every select to be correct, otherwise there is no way to alter the table without trouble.
Two solutions could be:

Don't return an error if you don't have a place for a returned column (bad, but easy)
Provide a syntax for inserting the list of fields that you expect (better)

The latter could work like this:
dbm.Select(&models, "SELECT ... FROM models")

or
dbm.Select(&models, "SELECT {} FROM models")

and that could be replaced by the list of fields expected in type Model.

#188 was merged. Closing this issue.

#188 didn't address the initial request, which is related to #133.


When checking EnPassant legality, why do you check if our king is behind our pawn?

When you check the legality of an en passant capture, except for this capture opening a horizontal check, you also have this interesting condition, which I don't understand why it's necessary.
As I understand the code, it seems to check that there's no friendly king behind the friendly pawn and looks like a rule "En passant cannot be used to avoid check", although this rule does not exist...
// check if
enemy pawn is controlling this square (can't use pawn attack bitboard, because pawn has been captured)
	for (int i = 0; i < 2; i++) {
		// Check if square exists diagonal to friendly king from which enemy pawn could be attacking it
		if (numSquaresToEdge[friendlyKingSquare][pawnAttackDirections[friendlyColourIndex][i]] > 0) {
			// move in direction friendly pawns attack to get square from which enemy pawn would attack
			int piece = board.Square[friendlyKingSquare + directionOffsets[pawnAttackDirections[friendlyColourIndex][i]]];
			if (piece == (Piece.Pawn | opponentColour)) // is enemy pawn
			{
				return true;
			}
		}
	}

Why is this condition necessary?

If there is a friendly king behind the pawn on the same file and the pawn captures en passant, and if there is an open file attacked by the enemy, then the move is illegal since the capture en passant revealed a check (basically a pin). But I've got to agree with you that I don't quite understand what this code does...

@kelsny Yeah but if a friendly king is behind the pawn (any squares far behind, not just one), then the pawn is pinned vertically and cannot capture at all (lines ~268-270). So I don't think that that is what this code was intended to do...

@FismanMaxim You could try taking that condition out and running Perft_Divide, comparing incorrect results with an engine like Stockfish. Then you can easily see what illegal moves this condition prevents. If it's the exact same, then the condition does nothing.


Config file in readme

I see a config file named .github/prosebot.yml in this GitHub repo readme, but the app says .github/write-good.yml, which is correct?

Hey @sc0ttkclark - I'm not seeing where the app points to .github/write-good.yml. I'm going to close this out, but feel free to reopen.

Fixed in this commit :) https://github.com/JasonEtco/prosebot/commit/c2c16bd87c7cce40fa2fd2ec0629e8c1294f883f#diff-04c6e90faac2675aa89e2176d2eec7d8

Ah nice, I'm a genius 😁 thanks for the report either way!

@JasonEtco I do see this on the GH marketplace app page. Not sure why or how to correct that, I assumed it would read from the default branch's readme.

@JasonEtco I do see this on the GH marketplace app page. Not sure why or how to correct that, I assumed it would read from the default branch's readme.


optimizing to extract goroutine id

extract the goroutine id from the stack trace formatted as text.

sourced: https://github.com/golang/net/blob/master/http2/gotrack.go

need  an optimal solution

https://notes.volution.ro/v1/2019/08/notes/23e3644e

https://stackoverflow.com/questions/32132064/how-to-discover-all-package-types-at-runtime
https://sitano.github.io/2016/04/28/golang-private/
https://github.com/funbytes/modern-go/tree/master/gls/g
https://github.com/cosmos72/gls

https://github.com/teh-cmc/go-internals/blob/master/chapter1_assembly_primer/README.md

https://go.dev/doc/asm#x86
https://github.com/chai2010/advanced-go-programming-book/blob/master/ch3-asm/ch3-08-goroutine-id.md


Group 1 - Solution for Language Detector

Group 1 Team members

Demetrios Koziris
Alonso Gutierrez
Andrew Lor

I'm curious why you outsourced your pattern matching to a separate function, although I used your list comprehension as inspiration for my personal solution to the problem.

We broke that part off into a function because it's a distinct sub-task (it returns the number of common elements in two lists). By encapsulating the code in a function (even if it's a one liner) it arguably improves readability since we get to give it a name (what that line does is more clear to a reader). As well, if we ever need to accomplish that task again (calculating the length of a list intersection) we can call that function instead of repeating code. It can also be helpful for testing our code. If we are getting unexpected behavior we can test if that function is behaving as expected (does it accurately find the number of common elements) and then move on to the rest of the code. Not sure how pythonic this is but these were our thoughts
There is a good discussion on this topic here: https://programmers.stackexchange.com/questions/99807/what-is-a-good-code-practice-of-when-to-make-a-function-method-for-small-repetit

That was my thought as well, and it's a good reason. Glad you thought it through.


feature-579

This pull request adds functionality to automatically initialize interfaces associated with the ResultServer if we are using VirtualBox machinery.
For other machineries this pull request adds more detailed error reporting if the error is related to  EADDRNOTAVAIL (cannot assign requested address).
Handling of exceptions while initializing the ResultServer is now done in a separate function called 'handle_init_exceptions'.
More discussion about the feature can be found here: https://github.com/cuckoobox/cuckoo/issues/579

Given this is specific to VirtualBox it would probably be more appropriate to handle such issues in modules/machinery/virtualbox.py. Yes, we're aware of this issue, and it's been bothering people for a while, but I think that with regards to the implementation we can do a slightly better effort.
Thanks for pushing in this direction though :)

Refactored the code to use default values from the config-files. Moved the interface initialization code to virtualbox.py.
After moving the code to virtualbox.py I realized that ResultServer() is called in cuckoo.py in cuckoo_init -function and machinery is initialized through the scheduler later on in cuckoo_main -function.
This means that ResultServer will fail to bind to the non existing interface before anything in virtualbox.py is called.
I'll ask for advice on IRC on how to implement this correctly :)


Trigger devfile registry deployment

What does this PR do / why we need it
Triggers deployment dispatch to verify CI account changes under devfile/registry.
Which issue(s) does this PR fix
Fixes #?
relates to https://github.com/devfile/api/issues/1572
PR acceptance criteria

[ ] Unit Tests
[ ] E2E Tests
[ ] Documentation
Update the sidebar if there is a new file added or an existing filename is changed

How to test changes / Special notes to the reviewer

/hold
Waiting until https://github.com/devfile/registry-support/actions/runs/10459851134 finishes.

/unhold


J goldman95 gamblepatch 1

Finally merging. Took a bit to figure out what needed fixing with the initial merge attempt.

O.o wat
We don't need this.

What is this tho? o.o


nixos: Data module imports

Motivation for this change
This extends the capabilities of NixOS modules to be able to import JSON or TOML configurations :)
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[ ] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[ ] Fits CONTRIBUTING.md.

I don't like the idea of adding such implicit behavior. How about an explicit usage like this instead:
{ lib, ... }: {
  imports = [
    (lib.modules.fromJSON ./path/to.json)
  ];
}

Which would be implemented like
{
  fromJSON = file: {
    _file = file;
    config = importJSON file;
  };
}

Great idea @Infinisil . Updated!

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/having-a-go-at-using-toml-to-configure-nixos/13897/1


"An error has occured in the target for an activation"

After i install the plugin, it is disabled in MB. After i click enable, that message is shown. I have tried both the latest version, and v1.1.
Worth noting is that it was enabled the first time i installed it (latest ver), but discord didnt show anything, so i re-enabled it or re-installed it (dont remember which one). Then this happend.

Feel free to try again with the latest binaries, make sure the dependencies aswell.


Question related to react/js/execution/es6

Lets consider the following screenshot:

Even after the control reaches the let assignment statement, the previous imports are undefined. Could anyone explain why is that so?
Also the following shows that the bundled internal variables are defined though:

Why does this behavior exist in javascript? Is this expected or something different.
Its in mozilla firefox browser (95.0.1)

It's right

Ok then if I call and run the rootSaga in the bottom of the file, it doesnt start the saga as the Saga stays undefined I guess. Why is this happening and when will all the imports have valid values? Pl give your answer in a more descriptive manner instead of just saying that this behavior is expected, which kind of triggers more questions.


Add missing curator names to collections

See wrangling.
The following collections are missing a curator name:
e9eec7f5-8519-42f6-99b4-6dbd9cc5ef03 is "Batuhan Cakir" per Jason.
 bf325905-5e8e-42e3-933d-9a9053e9af80 is "Batuhan Cakir" per Jason.
Batuhan is correctly assigned as a curator on other collections. Is he using multiple oauth providers - one which does not have a human readable name?

Added tech label so it's easier to find as on-call work.

I've set CollectionVersion.curator_name to Batuhan Cakir for both of the Collections mentioned and confirmed this comes through when fetching these Collections via the Discover API.

Is he using multiple oauth providers - one which does not have a human readable name?
Confirmed he used the same oauth identity for these collections as well as others; that was not the cause.

the curator name is pulled from the id token on the front end when using the UI to create a Collection via the portal API; the portal API handler requires a curator name. The curation API currently does not accept a curator_name field and simply instantiates a new Collection with an empty string as the curator_name value; I do not see anywhere that it ever gets updated.
I believe we can use the management API to query Auth0 to get the user name (which I assume is what the UI is using) with the Curation API handler. I'm not sure why we never did this... or if we did and it got scooped out during the redesign on accident...? Shall I create a ticket for this @brianraymor ?

@brianraymor @jahilton the curator_name gets filled in on publish (which occurs via the UI) for Collections that are created via the Curation API. If it is helpful, we can create a ticket as described above to use the management API to get the curator name and fill it in immediately on creation so that there won't be any Collections with an empty curator_name.

@danieljhegeman - I just published a collection on Dev. My curator name is "".  I believe that this was working back in the day when we tested the Discover API. Not sure if it's a regression.

If it is helpful, we can create a ticket as described above to use the management API to get the curator name and fill it in immediately on creation so that there won't be any Collections with an empty curator_name.

Please do. The curator name needs to be available in private collections.


Implement a clear cache operation for the PFS cache

This PR implements a clear cache operation for the PFS cache that operates on a tag prefix. Entries that are added to the PFS cache can now include an optional tag that can be used with the clear cache operation to control the lifetime of a cache entry. The LRU eviction policy still applies to the PFS cache, but providing a way to eagerly clear entries allows us to keep the storage under control while also allowing a high number of entries before evicting (cache entries are only kept around if they are needed). The current use case for this (and the PFS cache in general) is to clear job tasks. When a job reaches a terminal state or a pipeline is stopped / deleted, we want to clear the relevant entries from the cache. In this PR, we handle this through explicit calls to the clear cache gRPC at points where this occurs (worker master terminates job, job is stopped by a user, pipeline is deleted). This isn't the ideal long term solution because the clearing operation isn't captured in one place and we cannot guarantee completion without it being transactional (no-go because it can be large) or asynchronous with retries. We will eventually move to a model where this can be handled asynchronously and will probably be based on events for the state transitions of jobs. The solution we have in this PR is essentially a best effort to clear the cache, which will fallback on the LRU eviction policy in the worst case.

Clearing the cache during an upgrade makes sense, but it isn't necessary right now. Losing the caching of the upload task is unfortunate, but clearing the storage seems more valuable in the short term.


does not work

hello
i have installed like this
UI:

type: module
url: /community_plugin/sun-card/sun-card.js

file on the corresponding folder
created card with
type: 'custom:sun-card'
name: Sol
but does not work...returns unavaiable entity
what can i do

Hi, thanks for reporting the issue.
Could you tell me if you have sun.sun and time_date.time_utc entities available in your HA? They are available when you have sun and time_date components in your configuration. BTW, what entity is it complaining about?

hi
thanks for the feedback
sun.sun is available but not time_date

i will try to add it and give feedback

Ok now works !

Great, was the error message meaningful enough or it needs to be more descriptive?

well i thinks its enough at this time !
i do prupose that it is possible to increase sun size and have some different backgrounds

Hi, thanks for reporting the issue.
Could you tell me if you have sun.sun and time_date.time_utc entities available in your HA? They are available when you have sun and time_date components in your configuration. BTW, what entity is it complaining about?

I receive sun.sun and sensor.time_utc

This is still an issue I receive sun.sun and sensor.time_utc

This is still an issue
Could you create another issue for it? This will help tracking the work.


Functionality to return a list of all files that are failing schema validation

Is your feature request related to a problem? Please describe.
Users are asking for a list of files that are not making it into the datastore.
Describe the solution you'd like
Would be useful to have an api to return this data. Useful information to return is the file id and the publisher name
Describe alternatives you've considered
This could also happen via the validator. However, users will most likely be wanting to find the list whilst using the datastore.

We would like to add this listing to the 'failed' API for the schema validation and the datasets that are not being picked up by Datastore to inability to download, see #2471.
Requirement

Total list of files failing validation
Name of publisher
Publisher identifier
Dataset filename + identifier
Date and time of failed pickup (timestamp), only 5 latest attempts with timestamp
Type of error (see validator for error types)

[FORMAL]: ETA IS 1-2 DAYS, NEEDS CLEARANCE.

@amy-silcock please let us know if we can start this work. thanks.

We approve the work. Yes please to start work on it.

@amy-silcock you can see the endpoint here: https://test-datastore.iatistandard.org/api/datasets/fails/?format=json

Thanks Siem, looks good. Myself and Alex will take a proper look when we're back in the office on Monday.

Hi Siem, this looks good!
We've been playing with it and can see that it has some optional filters e.g. name and free text search
Would be good to know which ones you've included. Are publisher-id and iati-org-id there too?

If possible, lets get this live (I think you said it doesn't require a re-parse?) and we will have met the MA deadline

Hello Amy,
The functionality is live (url here)
Concerning filters, the same ones for the dataset endpoint should work, I verified and tested these ones:

(dataset) name
(dataset) id
(dataset) title
(dataset) filetype
publisher_id
(publisher_iati_id) publisher_identifier
publisher_title

If by  publisher_id you mean just a number(in example: 314) and by iati-org-id (publisher_identifier) you mean something like "BJ-IFU-6201810251129" then yes they are available.

Perfect! Thank you.
Would be great to see the details in the API documents. I confirm this working and delivered


Atom + hlint apply fails

Hi, I have ran into an issue with HIE + Atom
Issue
When applying hlint recommendations, the hint is not applied as expected. I have found two interesting cases:

With preceding comments: when the hlint suggestion is preceded by a single line comment -- some very useful text, a newline is inserted below the comment
When no preceding comments are found, nothing happens, the apply action just shows no effect (a multi-line comment preceding the hint has this effect as well)

Versions

stack: 2.1.3 with LTS 14.12 & GHC 8.6.5
HIE version: hie-8.6.5; version <IP_ADDRESS>.
OS: Windows 10 x86_64

Hi, can you run hie with the -d flag and send on the log file of messages? I'm not familiar with how atom records this. For VSCode it's in $TMPDIR/hie.log

Hello, I have been playing a bit more with this, and found some additional information.
I have made a new stack project to test with (stack new hiebugs, now I think of it, this did bump my LTS version to 14.14), where Lib.hs looks like
module Lib
    ( someFunc
    ) where

{- My Multiline -}
someFunc :: IO ()
someFunc = putStrLn myFunc

myFunc :: (String)
myFunc = ("Hello")

-- My single line

Interestingly, with this example, when applying the hint to the string literal, the action does have the intended effect (remove the redundant parentheses). However, it still inserts an additional newline after -- My single line, even though this line is after the applied hint!
Only when applying the hint to the type signature it does not lead to any effect (other than the inserted newline after the single line comment)!
The log files:

hie_type.log (when applying to the type signature)
hie_literal.log (when applying to the string literal)

Thanks for the report @JRikken. Another windows user here 😄
I suspect that apply refactors doesnt work in vscode neither but before hit the issue it has to keep hlint messages (#1447)

Hi, after last update to haskell-lsp, already used by hie, apply hlint hints is more reliable, @JRikken could you try again to check if it is fixed for you?

@JRikken i am gonna close this one cause it probably was fixed when merging the hie-bios branch, feel free to reopen if it is not the case

@jneira , sorry for the late reply. Fetched the latest version today, these are the findings:

Indeed, the fix for #1447 worked, hlint output does no longer disappear on vscode

So, this time I tested with both vscode and atom 😄, the next points apply to both editors.

The spurious newlines are no longer inserted when applying (any) hlint recommendations
Applying the hlint recommendation to the string literal works as expected
Applying the hlint recommendation to the type signature does not work as expected (no change is visible, e.g. (String) should become String, but is not changed)

The output of "Haskell HIE (hiebugs)" in vscode gives:
2020-01-06 11:50:15.8883593 [ThreadId 37] - applyHint:apply=[("C:\\Users\\jrk\\AppData\\Local\\Temp\\haskell-lsp16724\\Lib.hs-00000-1300647511.hs:9:11: Warning: Redundant bracket\nFound:\n  (String)\nPerhaps:\n  String\n",[Replace {rtype = Expr, pos = SrcSpan {startLine = 9, startCol = 11, endLine = 9, endCol = 19}, subts = [("x",SrcSpan {startLine = 9, startCol = 12, endLine = 9, endCol = 18})], orig = "x"}])]
2020-01-06 11:50:15.9061904 [ThreadId 37] - applyHint:diff=WorkspaceEdit {_changes = Nothing, _documentChanges = Just (List [TextDocumentEdit {_textDocument = VersionedTextDocumentIdentifier {_uri = Uri {getUri = "file:///C:/Users/jrk/Desktop/OLD6/bugReport/hiebugs/src/Lib.hs"}, _version = Just 0}, _edits = List []}])}
2020-01-06 11:50:15.907188 [ThreadId 37] - applyOneCmd:file="c:\\Users\\jrk\\Desktop\\OLD6\\bugReport\\hiebugs\\src\\Lib.hs"
2020-01-06 11:50:15.907188 [ThreadId 37] - applyOneCmd:res=Right (WorkspaceEdit {_changes = Nothing, _documentChanges = Just (List [TextDocumentEdit {_textDocument = VersionedTextDocumentIdentifier {_uri = Uri {getUri = "file:///C:/Users/jrk/Desktop/OLD6/bugReport/hiebugs/src/Lib.hs"}, _version = Just 0}, _edits = List []}])})

It appears that the line / column numbers indicated on the first line are correct, however from the second line on the action notes _changes = Nothing?

@JRikken somethings definitely going wrong! It could be the function we use to diff the changes between the hlint'ed file and the current file not handling that case. Is there a specific file that this always happens on?

😭 I started playing with the command-line versions of hlint & refactor (if I understood correctly, these are used as libraries for the linting / refactoring functionality of HIE?, using hlint <file> --refactor --refactor-options="--inplace"). This did appear to apply the hints correctly (both to type signature and string literal). However, this also changed the line endings in my test file from LF to CRLF (I am not certain if this is intended behavior, but I assume this is a bug on its own 🤔).
After which, the spurious newline problem returned...
So after some further testing:

In CRLF-ended file

Using HIE and vscode

Applying hints to type signatures does not work
Applying hints to string literals works
Both apply actions cause a single newline to be inserted after every single-line comment in the file

Using hlint <file> --refactor --refactor-options="--inplace"

Applying hints to type signatures works
Applying hints to string literals works
Applying any number of actions cause a single newline to be inserted after every single-line comment in the file

In LF-ended file

Using HIE and vscode

Applying hints to type signatures does not work
Applying hints to string literals works
No spurious newlines are inserted

Using hlint <file> --refactor --refactor-options="--inplace"

Applying hints to type signatures works
Applying hints to string literals works
No spurious newlines are inserted

My test file:
module Lib
    ( someFunc
    ) where

{- My Multiline -}

-- My Single line A
someFunc :: IO ()
someFunc = putStrLn myFunc

myFunc :: (String)
myFunc = ("Hello")

-- My single line B

I hope this helps pinpointing the location of the issue

Those newlines being inserted in a CLRF file sound like an upstream issue with either hlint or apply-refact, you might want to open an issue with them
As for applying hints to type signatures not working in hie, that’s definitely us. I’ll create a new issue for it and take a look at it later this evening
Thanks for all the detailed reporting, this is extremely useful

@JRikken this was caused by an upstream issue in hlint. I've opened a PR for it, hopefully it gets merged soon


Error: type mismatch: got 'seq[string]' for 'getDatas()' but expected 'SeqString = ref SeqString:ObjectType'`

If seq[string] is returned by a proc,
genny emits invalid code.
import genny

proc getDatas*(): seq[string] =
  result = @["a", "b", "c"]

exportSeq seq[string]:
  discard

exportProcs:
  getDatas

writeFiles("bindings", "ttt")
include bindings/internal

from generated internal.nim:
proc ttt_get_datas*(): SeqString {.raises: [], cdecl, exportc, dynlib.} =
  getDatas()

C:\Users\david\projects\gennyt\bindings\internal.nim(32, 11) Error: type mismatch: got 'seq[string]' for 'getDatas()' but expected 'SeqString = ref SeqString:ObjectType'
what works for me if i manual patch internal.nim
proc ttt_get_datas*(): SeqString {.raises: [], cdecl, exportc, dynlib.} =
  result = SeqString()
  result.s = getDatas()

Edit: Fixed import, removed nimja

Thanks for the report. I've confirmed the issue and am working on this.

Thank you for your issue! I think we have fixed it. Please pull head and try it again.
Feel free to reopen if you still have issues.

yes it compiles now, thank you!
I unfortunately still cannot use it. It excepts on field access.
I compile the above testfile with:
PS C:\Users\david\projects\gennyt> nim c --app:lib -d:release --gc:orc .\ttt.nim
Then load it in ipython:
In [2]: import ttt

In [3]: d = ttt.get_datas()

In [4]: len(d)
Out[4]: 3

In [5]: print(d[0])
---------------------------------------------------------------------------
OSError                                   Traceback (most recent call last)
Input In [5], in <module>
----> 1 print(d[0])

File ~\projects\gennyt\bindings\ttt.py:35, in SeqString.__getitem__(self, index)
     34 def __getitem__(self, index):
---> 35     return dll.ttt_seq_string_get(self, index)

OSError: exception: access violation reading 0x0000000000000000

Nim version:
Nim Compiler Version 1.6.0 [Windows: amd64]
Compiled at 2021-10-19
Copyright (c) 2006-2021 by Andreas Rumpf

active boot switches: -d:release

Out of curiosity i also tried it with a seq[cstring], this fails in a different way:
import genny

proc getDatas*(): seq[string] =
  result = @["a", "b", "c"]

exportSeq seq[string]:
  discard

proc getDatas2*(): seq[cstring] =
  result = @["a".cstring, "b", "c"]

exportSeq seq[cstring]:
  discard

exportProcs:
  getDatas
  getDatas2

writeFiles("bindings", "ttt")
include bindings/internal

PS C:\Users\david\projects\gennyt> nim c --app:lib -d:release --gc:orc .\ttt.nim
In [1]: import ttt
---------------------------------------------------------------------------
NameError                                 Traceback (most recent call last)
Input In [1], in <module>
----> 1 import ttt

File ~\projects\gennyt\bindings\ttt.py:124, in <module>
    121 dll.ttt_seq_cstring_len.restype = c_longlong
    123 dll.ttt_seq_cstring_get.argtypes = [SeqCstring, c_longlong]
--> 124 dll.ttt_seq_cstring_get.restype = cstring
    126 dll.ttt_seq_cstring_set.argtypes = [SeqCstring, c_longlong, cstring]
    127 dll.ttt_seq_cstring_set.restype = None

NameError: name 'cstring' is not defined

if you like i can put this into a new issue.

We do not support exporting cstring right now. It can be added but I'm not going to right now. Looking into at the access violation.

I see the issue. Seqs were not checking to see if they needed to do type conversions for import/export like procs were. Unfortunately for your testing, string is one of the few cases that need conversion so I've got that fixed now in a PR.

One small thing, I suggest using --tlsEmulation:off comple flag on Windows. It is a bad default to have that enabled and was fixed in 1.6.2 (https://nim-lang.org/blog/2021/12/17/version-162-released.html), but that regressed elsewhere.

For some reason for l in d: is reading past the end of the seq. I don't know why Python is doing that with that loop construct. Maybe there is some proc we need to override or something? Investigation needed.

Ok, figured out the issue. We need a custom Iterator + override iter on our Seq Python classes. Working on this quick now.

thank you @guzba it works fine now!


Chore: Refactor job and config manager

Refactor job and config manager to avoid problems
during deploy due to environment variables.

@molant done!


Minor doc fix for imstretch.

This makes the documentation correspond to the code: m is taken to the power too.
Since I wasn't sure whether the comment or the code was right, I tried to find a reference for this formula, but my google-fu fails me. Is there a reference? If you link it, I could add it to this PR before merge.

Thanks!
As for a reference, I don't have one. This function pre-dated my own involvement with julia (there was an images.jl file in a directory called examples/ in the main julia repository).

Wow git (and your memory) truly is awesome. It was easy to find that this was added by user @stefan-k in JuliaLang/julia@07117df16f17396865093a76a36522c91a5ce8c9. Stefan, any chance you remember a source for this formula?

Hellooo again!
I don't remember the source for this formula, but I guess it is from the "Image Processing in Matlab" (or something like that) book. The likelihood that I made a mistake is pretty high. I don't recall ever using it.
Hope this helps! :)


Where can i find the serverClientID? what is the difference between clientId and serverClientId?

i have the clientId from the OAuth 2.0 Client in google cloud platform, but what is the serverClientId? how can i get it?

Hello. You don't actually need to use them both. Use the only serverClientId and leave clientId empty. Hope that will help you


feat: Notification Settings Update Endpoint - Backend

Hello @Ruthiejayjay, the API works locally, but we had an issue with the database setup. They omitted the "id" when setting up the migration. We reached out to them but didn't get any response since yesterday.

The migration table should look like this.

Description
Create an endpoint to update user notification settings

Related Issue (Link to Github issue)
Link to the issue here

Motivation and Context

Users can tailor their experience by choosing how they want to receive notifications. This could be through email, push notifications, SMS, or a combination of these.
Notifications can help keep users engaged with timely updates about new features, updates, or important information.
Providing and respecting notification settings demonstrates a company’s respect for user preferences and privacy.
Sending SMS notifications or emails can incur costs. By allowing users to opt-out, companies can manage these expenses better by not sending unnecessary messages.

Testing

This code was tested using Postman and Unit Testing

Postman
User Table

Notification Preference Table

Successful login response

Notification Settings Update Endpoint
Route: PATCH /api/v1/notification-settings/{:user_id}
Successful Notification Update

user_id is valid and user notification settings have successfully been updated

Invalid Request and Error Response

user_id is invalid (not found) and user notification settings cannot be updated

request body contains invalid data

The user is unauthorized and cannot access the endpoint

Unit Test

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[x] I have added tests to cover my changes.
[x] All new and existing tests passed.

You have merge conflicts


Demeteorizing Vulcan and how you can help

Goal
Progressively transition from Meteor to Next app.

First being able to connect any type of JS frontend to a Vulcan backend
Then reuse Vulcan code in Next, both backend and frontend
Then use Next as our main framework

Some code will be specific to Next, however this transition will also allow to reuse Vulcan code in other type of React frameworks (eg Gatsby), at least for the frontend.
Things to get sorted out
Multi-environment NPM packages

[ ] How to create npm packages that works differently on the client and the server?
The idea is to provide fullstack package as we are used to do in Vulcan.

For Storybook I've created a specific Webpack handler, but it would be better to have some out-of-the-box pattern.
Usually NPM expect you to define a unique main field that points to your package built code (eg dist/index.js). Instead, we may want to point a directory (related SO question), maybe with `exports: { ".": "./dist"}. We could also put built file directly at the project root.
We probably will need to define Webpack loaders/config at least for client side imports, that can differentiate environments.
Mongo

[ ] How to handle the Mongo database? Probably a simple Docker command in development

Others

[ ] How to handle startup logic. On the client it's ok (see Storybook code in Vulcan) but on the server we don't really have a startup system. We might probably explicitely call a function in our Next app.
[ ] What kind of example app people want to see in 2020?
[ ] Easy deployment, including deploying a mongo database
[ ] Figure out npm link with Lerna, to allow a pattern similar to METEOR_PACKAGE_DIRS under development => calling lerna bootstrap or lerna link should work
[ ] ... others

Things to do
Steps to go from Meteor packages to NPM packages

[ ] Copy the package in the packages folder of vulcan-next-starter
[ ] Make it work in the Next application, demeteorize
[ ] When the package is ok, move it to the Lerna monorepo vulcan-npm (WIP: we need to add a Webpack config in this repo to handle multi-env package)
[ ] Update the Meteor packages to reuse the NPM packages as much as possible => from meteor/vulcan-core to @vulcan/core

The goal is to both allow to use Vulcan outside Meteor, in Next, and keep maintaining the Meteor version with a minimal amount of code.
To be done for most existing package, however note that packages may exist in Next already. Eg handling styled components. In this case no additional work is needed, it's user responsibility to install relevant packages.
Specific demeteorization tasks

[ ] Move to Mongoose for collections https://github.com/VulcanJS/Vulcan/issues/2479
[ ] Graphql Accounts issue PR
[ ] From Jest to Mocha (should not be too hard)

Documentation of equivalent patterns
Coming from Meteor, we need to get a grasp of equivalent patterns in Next.

[ ] npm link vs a 2-repo install with METEOR_PACKAGE_DIRS => lerna bootstrap should install and link. However npm i<EMAIL_ADDRESS>may sometime fails. Adding manually the package in package.json seems to work.
[ ] Handling environment specific settings , with next.config
[ ] Testing packages altogether
[ ] Create a new package in the monorepo: cd packages && mkdir vulcan-whatever && cd $_ && npm init, define index.server, index.common and index.client (or just index for only one environment). Or lerna create
...

Tooling

[ ] Setup Jest in the monorepo
[ ] Jest in the Next app
[ ] TypeScript in the monorepo
[ ] Export to JS when publishing on NPM
[ ] Eslint/prettier in Lerna
[ ] A webpack config in the monorepo able to handle NPM package with index.client and index.server to have 2 different build. For example @vulcan/core index.server.ts reexports @vulcan/users => it needs Webpack + our custom helper to know which index file to load from @vulcan.users automatically.

Feature-wise goals
In order to make the process easier, here are some intermediate goals. Each may need some of tasks listed above to be achieved beforehand.

[ ] Use @vulcan/users useCurrentUser hook in vulcan-next-starter: need to be able to connect to Vulcan OK, need a custom Webpack config in the Next app to load packages with environment-linked index files, need to be able to build our TypeScript code in the monorepo
Same but in Vulcan Meteor meteor/vulcan:core package, in order to start reusing the same code. Not sure how to import our multi-env NPM packages in Meteor though, we may need explicit @vulcan/core/index.[environment] imports.

Use case idea
Working on a simple business use case would allow us to create example more easily. We could for example develop a Job board, or an app similar to "Awesome Vulcan" to publish vulcan ressources.
[This document is a Work in Progress. It will be updated with additional questions, answers, and process to move from Meteor to Next]
Ressources

https://github.com/comus/react-vulcan-proposal
Lerna with TypeScript

Contribute
Post a comment on this issue if you want to help or take care of one of the tasks.

hello, something i tried to do it last year, but i didn't have time to finish it. really.
i just share what i did, for the "How to create npm packages that works differently on the client and the server?"
it s easier with webpack config. it's good to wrap it with next.config.js, just as withVulcan
config.resolve.mainFiles
for example
https://github.com/comus/react-vulcan-proposal/blob/master/src/withVulcan.js
and "Mongo database", i am not use mongodb now. but i have a solution for local development.
there is a node js library called 'mongodb-prebuilt', it can download the mongodb binary and run it.
i have a bin script: https://github.com/comus/react-vulcan-proposal/blob/master/src/bin/react-vulcan.js
with the bin, people can just type npx @vulcan/anyname mongo to launch a mongodb for development.

Thanks for the withVulcan helper. So it seems that you went for a specific loader too in order to handle both client and server. Maybe that's the only solution indeed.

I've made a first update of the monorepo to show how it could work: https://github.com/VulcanJS/vulcan-npm
I've only added Typescript, but we would also need to use Webpack in order to have transparent usage between server and client. It's not tested yet.
@comus I have reused your idea of using mainFiles to make a more generic helper in @vulcan/webpack package. It may be used in Next like you did but also in any kind of app that uses Webpack.
Since Node servers use Webpack less often, we could also consider that index.js is the default server export. So that you can still do  const whatever = require('@vulcan/core') in a server that do not use Webpack, it would be equivalent to const whatever = require('@vulcan/core/index.server').
We can safely consider that client side the developer is able to setup Webpack to import Vulcan, or explicitely call const whatever = require('@vulcan/core/index.client).
Don't know if I am clear but I think we will figure this out correctly.

@comus I've pushed a new test, sadly I could'nt have "multi-env" import to work. I have pushed a new commit with a demonstration (see _app.ts, it loads @vulcan/multi-env-demo).
It is weird because the "log" is correct, but I still have a build error, very weird.
Also, I made a test with Webpack in the monorepo and build did work. However we face a big problem: the text editor can't understand our index.client/index.server thing. It says that it does not find the package if you just type @vulcan/multi-env-demo, because it looks for an index, even when the build work.
There is no way for VS code to tell whether you are editing client code or server code. Note that it explains poor support of Meteor in text editors.
This may end up being too complicated. In which case we would be forced to do import '@vulcan/core/server and import '@vulcan/core/client depending on the environment, without relying on Weback.
To sum it up:

@vulcan/core would import only code that works on BOTH client and server
@vulcan/core/server code that works on BOTH client and server + code that work on server only
@vulcan/core/server code that works on BOTH client and server + code that work on client only

The example with resolvemainFiles try to be a bit smarter and select the right code automatically but it may raise too many issues.

It also means that we will lose the pattern of having 2 components with same name but different implementation in server and client, eg to handle components that do not support SSR.
But again not a big deal, it was seldom used and very Vulcan specific, we have other alternatives in Next (using NoSSR components for example, dynamic imports and so on)


add runtime=java for java apps

Purpose

Add parameter --runtime java to java apps
Assign MI to container env before used in container apps
Upgrade Application Insights to 3.5.4
some minor refines on doc

Does this introduce a breaking change?

[ ] Yes
[x] No

Pull Request Type
What kind of change does this Pull Request introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

How to Test

Get the code

git clone [repo-address]
cd [repo-name]
git checkout [branch-name]
npm install

Test the code

What to Check
Verify that the following are valid

...

Other Information

Thanks @vermegi , I do not have the privilege to merge the PR
would you please help update my role?


Add Crypto.randomUUID API

https://developer.mozilla.org/en-US/docs/Web/API/Crypto/randomUUID
Implemented in Node.js, Deno and Chrome/Edge 92

Thanks! If this isn't implemented in Firefox or Safari though I think it needs to be unstable?

Landed in Webkit too https://trac.webkit.org/changeset/281284/webkit
Firefox is working on it https://bugzilla.mozilla.org/show_bug.cgi?id=1723674
The specification is also going to be merged with the WebCrypto spec. https://github.com/WICG/uuid/issues/27
I think it's safe to be in stable?

"going to be merged" and "working on it" means that it's not finalized, and web-sys only supports finalized APIs by default.

Firefox 95 has shipped.

@alexcrichton is there an update on this or is this still considered unstable?

I do not follow web standards to the degree that I know whether this is ready to ship or not.

Sorry for the delay in switching to unstable, I tried earlier but it didn't work...will give it a shot again.

Ok great!


Default for mongoose update not really good (override true)

I just wondering if override at true for update of service is very good
Exemple:
i have in database
{id= 1111, field1:"exist",field2:"exists",toupdate:false}
If i do service.update(1111,{toupdate:true})
the result give me {id= 1111, toupdate:false}
So i loose in my dtb field1:"exist",field2:"exists"
i found the issue is due you put override true as a default option for mongoose
For me put override false will give me the appropriate result:
{id= 1111, field1:"exist",field2:"exists",toupdate:true}
Can you please answer it?
Regards

Why would you not use service.patch if you don't the entire record updated?

yes it what i did before in deed , but i found that update is less hard to code that patch only :)

This is by design for all database adapters and based on what a RESTful PUT is supposed to do. It is documented, e.g. in https://docs.feathersjs.com/api/services.html#updateid-data-params and https://docs.feathersjs.com/api/databases/common.html#service-methods
From the documentation:

update(id, data, params) -> Promise - replaces the resource identified by id with data.

If you would like a different behaviour, you can always change the behaviour by e.g. mapping .update to .patch in a before hook.


byte_buf append w/lookup does not alias

Description of changes:
Mark the arguments with restrict keyword to generate better assembly when strict-aliasing is enabled.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Does this break appending a buffer to itself?

Does this break appending a buffer to itself?

The documentation https://github.com/awslabs/aws-c-common/pull/304/files#diff-b6bf40e2dd7c2a450ad1dc0080df6979R309 says that they should not overlap.

... from and to should not be the same buffer (overlap is not handled) lookup_table must be at least 256 bytes


Add support for debian packaging to tac_plus

Hi Cooper, facebook Folks!
I wanted to use your fork of tac_plus on a TACACS+ server running Debian, and hence created some ability to package it for both Debian 8 (Jessie) and Debian 7 (Wheezy). It's getting some testing in the network I rolled it into.
I'm happy to maintain this in a separate repository, but I was wondering whether you'd be interested in merging it. No substantial code changes are made other than packaging  - and the binary packages for the amd64 architecture are at http://m.rob.sh/deb/.
Thanks!
r.

Hi SIr, Awesome to hear it's working for you. The more using this the better - We are by no means proud that we are using this code base but it gets the job done :P Will pull it on in after I take one more look.

It was just a larger refactor than building to binaries and I wanted to make minimal changes so I introduced minimal bugs. Got better things to do than play with tacacs+. E.g. making devices that don't need tacacs and can use normal Linux auth like our server fleet - FBOSS ftw.

We should file a seperate issue to track properly binding to v6 and v4

Agreed, looking at the code, supporting a tcp46 is going to take a significant refactor, probably best to either have it as two packages or a single package that provides two binaries (my preference would be the latter).

LGTM - Thanks Rob.

Thanks - I've just been testing this on our live TACACS+ servers, and was going to update today. Seems to be working well.
Thanks again for your work on this!


When will the code be released?

Dear author, thank you for your great work and I'm very interested in it. When will the code be released?

@monsoon235  Do you have any dates by which we can expect, as the plan was July？


fix: --- kubescape fix

Overview
As mentioned in the issue, in case of a --- being present in the beginning of the yaml manifest file the kubescape fix command doesn't seem to work properly and throws an error. This behavior has been fixed now.
Additional Information
The problem is related to the yaml/v3 dependency we use for parsing/writing yaml which it does by converting the yaml indents into corresponding yaml.Node objects of one of 5 possible types, but marshalling is only supported for 3 of those kinds, due to --- being present at the beginning the dependency assigns it a node kind which cannot be marshalled hence the error.
Best option would be to get Kubescape to ignore that initial --- while processing.
How to Test

Create a resource.yaml file like:

---
apiVersion: v1
kind: Pod
metadata:
  name: pod
spec:
  containers:
    - name: container
      image: image:latest

Run kubescape scan resource.yaml --format json --output output.json
Run kubescape fix output.json

Related issues/PRs:
Resolved #1255
Checklist before requesting a review

[x] My code follows the style guidelines of this project
[x] I have commented on my code, particularly in hard-to-understand areas
[x] I have performed a self-review of my code
[x] If it is a core feature, I have added thorough tests.
[x] New and existing unit tests pass locally with my changes

@vladklokun Have updated the PR with the requested changes.
Moved the sanitization functionalities to separate functions of their own, added test for a yaml file with --- as the beginning, also added tests for the abstracted sanitization functions.
Also found a typo? in the tests regarding the removals so fixed that too.
Let me know if there are any more changes required! Thanks! ;)

Since we already have test files in the hybrid test data folder now, I guess we can go ahead and remove the files I had added to the insert test data folder?

Great job, LGTM!
I apologize for making changes to your PR myself. We wanted to merge this promptly, so I wanted to skip the back-and-forth. That’s how important of a thing you have fixed :)
You did well, thank you for your contribution @XDRAGON2002!

Not a problem at all @vladklokun!
I was just going through the commits as you were making them, this to be honest is one of the best things about opensource, as a lesser experienced developer it allows me to directly glimpse into how a more experienced developer might think and make implementation decisions.
This was a great exercise for the same! Thanks a lot!

As for the function / struct that sanitizes the input YAML, you should have a self-contained unit test

@XDRAGON2002 lol just realized I might have given you mixed info on whether to have the unit test for the sanitizer function or not.
To clarify my point, it’s okay to write the unit test to help you develop a private function, class or whatever. Personally, I prefer to do it this way. But these tests should be removed before merging the changes since they make it more difficult to refactor code in the future. At least, that’s what the books say :)
There’s a great talk on Test-driven Development that covers this point of testing private and public things, I recommend watching it.

As for the function / struct that sanitizes the input YAML, you should have a self-contained unit test

@XDRAGON2002 lol just realized I might have given you mixed info on whether to have the unit test for the sanitizer function or not.
To clarify my point, it’s okay to write the unit test to help you develop a private function, class or whatever. Personally, I prefer to do it this way. But these tests should be removed before merging the changes since they make it more difficult to refactor code in the future. At least, that’s what the books say :)
There’s a great talk on Test-driven Development that covers this point of testing private and public things, I recommend watching it.

Ahh, makes a lot more sense know, because I was just puzzled regarding the fact that why were the tests removed since I was asked to add them XD


installing older version 1.6

Hi,
I want to install an older version of ROCM (v 1.6) to test the AMD gem5  GPU simulator since it mentions that as the official version supported. Could anyone help me get started on how to do this?. I need it for a project and would appreciate the help.
Thanks.
Best,
Trinayan

Hi Trinayan,
We have some documentation on the gem5 wiki about our GPU model: http://gem5.org/GPU_Models#Runtime_software_and_toolchain
We use the roc-1.6.x branch for the repos mentioned in the above link.
If you have any further gem5 questions we have a mailing list. gem5.org has more information.
Tony

@atgutier : Thanks Tony. Actually I tried to run the simulator and got errors. My question was posted a few days back(https://www.mail-archive.com/gem5-users@gem5.org/msg15909.html). But not sure if anyone has looked into it yet. One of the many reasons for the error mentioned there could be that the system I was using had rocm 1.8 instead. So just want to install the 1.6 version and try the simulator again. In case you think the error mentioned there points to some other potential problem please let me know. I am very interested in using the simulator for my research work and would be glad if i can get any assistance in setting the simulator up. Thank you.

Hi @trinayan
For reference, we keep old versions of our ROCm installation packages at http://repo.radeon.com/rocm/archive/
You can use these to create e.g. a local apt repo and install the binaries using that.
Beyond that, it looks like that question is actually related to gem5 rather than ROCm, so I recommend you follow up with that group in their mailing list.


Ability to load the resource details as a side panel on result selection

Users want to easily navigate the resources present in the table and switch between results. This should also work in other parts of the application, in the same way: Studios, Admin, Workflows, etc.
Acceptance Criteria:

The user clicks on a row of the table which opens the resource details view as a side panel
The resource details view will slide from the right side of the screen and overlay the table
The side panel should occupy no more than 60% of the screen on desktop screens, the minimal size is 40% of the screen

As an example, look at the Zenhub side panel (when opening an issue on the board page)

When clicking outside of the side panel but not on another row, the side panel closes.
When clicking on another row of the table, the side pannel updates with the new resource details view.

Selecting a row with the selection icon on the left side of the table will not open the side panel.

When clicking on the close button at the upper right corner of the side panel, the side panel closes.

Not in scope:

redesign of the resource view
opening the resource view by itself is not a side panel

Interactive mocks: https://xd.adobe.com/view/50ef3eb0-46be-4b49-8e1a-6232cedf127e-05bc/ to check sliding behavior

@adulbrich Hey team! Can you please add your planning poker estimates with ZenHub

@nicwells @smitfire @Stafeeva @umbreak @samuel-kerrien @imsdu @wwajerowicz Hey team! Can you please add your planning poker estimates with ZenHub

Responsive size side panel
Antd defines some breakpoints, i.e. widths which we can use to determine how a responsive layout behaves for different screen sizes. We'll use these to determine the width of the side panel such that is 100% width for smaller screens and 60% for larger screens.

Antd breakpoints and less variables from default.less
// Media queries breakpoints
// @screen-xs and @screen-xs-min is not used in Grid
// smallest break point is @screen-md
@screen-xs: 480px;
@screen-xs-min: @screen-xs;
// 👆 Extra small screen / phone
// 👇 Small screen / tablet
@screen-sm: 576px;
@screen-sm-min: @screen-sm;
// Medium screen / desktop
@screen-md: 768px;
@screen-md-min: @screen-md;
// Large screen / wide desktop
@screen-lg: 992px;
@screen-lg-min: @screen-lg;
// Extra large screen / full hd
@screen-xl: 1200px;
@screen-xl-min: @screen-xl;
// Extra extra large screen / large desktop
@screen-xxl: 1600px;
@screen-xxl-min: @screen-xxl;
// provide a maximum
@screen-xs-max: (@screen-sm-min - 1px);
@screen-sm-max: (@screen-md-min - 1px);
@screen-md-max: (@screen-lg-min - 1px);
@screen-lg-max: (@screen-xl-min - 1px);
@screen-xl-max: (@screen-xxl-min - 1px);


MatVirtualScroll Items are not rendered if height is not defind in pixel

I found a bug in MatVirtualScroll.
If I put this code all items are not displayed when I scrolled down (only 41 items are displayed instead of 73):
<MatVirtualScroll @ref="_lazyLoading" style="overflow-y: auto; height: 100vh" ItemType="DTO.MusteringCardholderDetails" Items="@FilteredCardHolders" ItemHeight="60">
Same thing if I put height like 300px the scrollbar is here but I cannot see all of my items (44 in this case instead of 73)
To fix it quickly in my code I decide to change the height by setting 100% instead of 100vh or XXXpx. And in this case no items are displayed. The scrollbar is displayed and the right place in allocate to the scrollbar but the component don't display anything. I try also to remove ItemHeight but same result.
The only way I found to display all results is to harcode a value which is bigger to my real size (in my case 4380px or higher). The problem is my list is my list is dynamic so it is definitely not a right way.
I also try something like that in the code but it does not compile:
style="overflow-y: auto; height:@(this.ScrollSize)px;"
private int ScrollSize => this.FilteredCardHolders.Count * 60;
Can someone take a lool at this ?
Thanks

I find a solution by fixing one stuff in the library.
My main problem was when scrollviewer + Lazy loading is enabled not all items are displayed.
I will do a pull request for that.
Thanks


factorio: experimental 0.17.6 → 0.17.11

Motivation for this change
Factorio is releasing a ridiculous number of bugfixes. I've finally had time to update the factorio package, so here it is.
Things done
Update the version and hashes.
I'm working on an autoupdater, but it's a little weird since the format is different than other packages.
I might want to request commit access to this repository so I can get my minor patches in before Wube releases too many more versions of factorio.

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Assured whether relevant documentation is up to date
[ ] Fits CONTRIBUTING.md.

cc @Baughn @elitak

LGTM.


allow to pass value as props

<FormatDate options={{date: 'short'}} >{date}</FormatDate>

can feel a bit awkward could this module also support  this api ?
<FormatDate value={date} options={{date: 'short'}} />

Hi,
Currently, whatever is passed in value gets overwritten by children (code below). We could change the below for not overwritten args[0] if children is falsy. so we enable both usages in your description.
// src/generator.js:
this.args[0] = this.props.children;

Would you like to submit a pull request with such change?

I'll do so !

Hi @fdecampredon. Are you still interested in working on this?

I had the same question. I'd love to see this implemented. Basically, use this.props.value if set, otherwise use this.props.children.

I actually think that you should only allow value= prop and deprecate the children format.

I actually think that you should only allow value= prop and deprecate the children format.

:+1:  to that

@gnarf I see you have a preference, but the motivation isn't clear to me. Using a value attribute instead of children might be convenient in the given example (I agree), but using the opposite (children instead of a value attribute) might be convenient in other cases like:
<FormatMessage>You’re receiving notifications because you commented</FormatMessage>

I hold my preference for "use this.props.value if set, otherwise use this.props.children". I don't see any problem with allowing both options this way.
PRs are still very welcome. Thanks

I agree with @rxaviers here. I am working on adding some initial tests to the repo (PR almost ready) and then I will add this "use this.props.value if set, otherwise use this.props.children" functionality along with additional tests


pnpm packaging not working

While working on #267, I could not get pnpm functionality to work.

pnpm stores it's deps in a subdirectory node_modules/.pnpm/ or some npm_reg folder for older versions with {package}@{version} folders so the rest of the packaging logic doesn't pull it into external.
It fails at the install command saying the lockfile is out of date.
The list deps command is very broken because the list command without a depth only shows its top level dependencies.

At this point the pnpm functionality does not work. Not sure if there was a version which this is actually compatible with @floydspace? If you are after this functionality please leave a comment below and I'll try and find some time to work on it.

Hey @samchungy, it was contributed by @lulzneko, to be honest, I haven't tested it and have never used it, maybe initially it worked. Please go ahead to fix it if possible.

Hey @samchungy, it was contributed by @lulzneko, to be honest, I haven't tested it and have never used it, maybe initially it worked. Please go ahead to fix it if possible.

Okay good to know 😛  I'll see if I can get to it if I have time but otherwise I'll leave this issue here in case someone actually tries to use it.

You can try with: installExtraArgs: --shamefully-hoist

Interesting, wasn't aware of that. tyvm I might be able to enable support with this in the future if I find some time

Are you planning to fix it? In the documentation/configuration pnpm is listed as possible packager, the reality is that it is broken and not safe to use.. 😞
At least support installExtraArgs: --shamefully-hoist as this is acceptable workaround

I had a first take last week and discovered the incompatibility with lambda and the symlinked structure. I would absolutely love to fix this. But ultimately this is just a volunteer thing for me and sometimes it's quite hard to pick up the tools after work

Is this fixed with v1.35.3? @samchungy


Error When Building C Platform:  failed to open file "platform/dynhost": No such file or directory (os error 2)

log:
🔨 Rebuilding platform...
An internal compiler expectation was broken.
This is definitely a compiler bug.
Please file an issue here: https://github.com/roc-lang/roc/issues/new/choose
thread '<unnamed>' panicked at crates/linker/src/lib.rs:556:29:
failed to open file "platform/dynhost": No such file or directory (os error 2)
stack backtrace:
   0:     0x6432f931df9b - <unknown>
   1:     0x6432f852b720 - <unknown>
   2:     0x6432f9319c03 - <unknown>
   3:     0x6432f931dd34 - <unknown>
   4:     0x6432f931f890 - <unknown>
   5:     0x6432f931f5af - <unknown>
   6:     0x6432f931fdae - <unknown>
   7:     0x6432f931fcb2 - <unknown>
   8:     0x6432f931e496 - <unknown>
   9:     0x6432f931fa20 - <unknown>
  10:     0x6432f841ae55 - <unknown>
  11:     0x6432f8c668de - <unknown>
  12:     0x6432f8c385bb - <unknown>
  13:     0x6432f8c628ec - <unknown>
  14:     0x6432f872f8d5 - <unknown>
  15:     0x6432f873b046 - <unknown>
  16:     0x6432f9325cc5 - <unknown>
  17:     0x760afb4a6ded - <unknown>
  18:     0x760afb52a0dc - <unknown>
  19:                0x0 - <unknown>
thread 'main' panicked at crates/compiler/build/src/program.rs:981:46:
Failed to (re)build platform.: Any { .. }
stack backtrace:
   0:     0x6432f931df9b - <unknown>
   1:     0x6432f852b720 - <unknown>
   2:     0x6432f9319c03 - <unknown>
   3:     0x6432f931dd34 - <unknown>
   4:     0x6432f931f890 - <unknown>
   5:     0x6432f931f5af - <unknown>
   6:     0x6432f931fdae - <unknown>
   7:     0x6432f931fcb2 - <unknown>
   8:     0x6432f931e496 - <unknown>
   9:     0x6432f931fa20 - <unknown>
  10:     0x6432f841ae55 - <unknown>
  11:     0x6432f841b3a3 - <unknown>
  12:     0x6432f87699e9 - <unknown>
  13:     0x6432f8766e02 - <unknown>
  14:     0x6432f888582e - <unknown>
  15:     0x6432f871af55 - <unknown>
  16:     0x6432f86f9323 - <unknown>
  17:     0x6432f86f9343 - <unknown>
  18:     0x6432f930fb5a - <unknown>
  19:     0x6432f871e0b5 - <unknown>
  20:     0x760afb439c88 - <unknown>
  21:     0x760afb439d4c - __libc_start_main
  22:     0x6432f84bfa2e - <unknown>
  23:                0x0 - <unknown>

Apologies for the lackluster issue details I just started using the language yesterday. Annd.. jumped right into writing a platform so its fairly likely this is something dumb I did that just happended to trigger an ICE. still worth reporting though, if there's some way to catch the issue a little cleaner.

I think this may be because the roc cli os trying to rebuild your platform. If you compile the platform to a library first and then use roc build --prebuilt-platfrom ... that might help.
I have a C template which may be helpful
https://github.com/lukewilliamboswell/roc-platform-template-c

Thank you that's exactly the issue :), I'll update the issue to be more relevant...


[Person tracking] Is the order of detected persons preserved from frame t to frame t+1 ?

Hi @yysijie,
Following  your scripts of kinetics skeletons generation https://github.com/yysijie/st-gcn/blob/master/tools/kinetics_gendata.py , l wonder :
1- If the order of 5 persons detected at each frame is preserved. In other term :  is person N°3  at frame t corresponds the person N°3 at time frame t+1. How do you do the tracking.
2- What if the persons at different frames are not the same ?
3- If you detect 5 persons at frame t and 3 persons at frame t+1 how do you track them ?
Thank you

@ahmedmazariML, thank you for your interests in our work.
In the scirpt you mentioned, we processed data offline by this data feeder module: https://github.com/yysijie/st-gcn/blob/master/feeder/feeder_kinetics.py.
This data feeder provided simple tracking strategy, but in the action recognition, we did not observe obvious improvement brought by it. Thus, the default setting is no tracking. To utilize person tracking,
plsase set pose_matching=True.
Instead of this, we sorted the pose in each frame according to their confidence score. It is simple but works. For more information, please refer to:
https://github.com/yysijie/st-gcn/blob/e7024ac16714d6d6ac911f7cfb2910aea1940b15/feeder/feeder_kinetics.py#L137-L142

If you detect 5 persons at frame t and 3 persons at frame t+1，so how many people are processing all the frames in the entire action sequence?

@jingong
Only num_person_out out of 5 or 3 will be process in the current implementation. You are free to modify it to run it on every person.

Hello, don't know if you have completed the task of this change. @yjxiong


Suggestion: Exotic Gardens support for the Growth Chamber

I think the growth chamber would be an amazing alternative to Advanced Androids for harvesting plants from exotic gardens. It would not only make it more compact to produce items, but certain items like exotic garden tree saplings could be implemented as it is difficult to harvest any of the trees with androids. Also I would appreciate the inclusion of Magical Plants, and maybe it would be fair to make the production rate slower than the rest of the plants for these.
Thanks in advanced!

Note to self. This also affects the Culinary Generator with ExoticGarden's Custom Foods.

Note to self. This also affects the Culinary Generator with ExoticGarden's Custom Foods.


Enable negative impls in test crates.

This change is

crates/cairo-lang-semantic/src/diagnostic_test_data/neg_impl line 36 at r2 (raw file):
Previously, orizi wrote…
don't we want to test the error as well?

I think it is not worth the effort.

corelib/cairo_project.toml line 11 at r2 (raw file):
Previously, orizi wrote…
should this work?

Done.


Fix token fetch not invoking callback for unchanged token

Fixes #3229.

@morganchen12 I might not be available in the next release, would you help paul on releasing the instanceID sdk with this change?

Please update https://github.com/firebase/firebase-ios-sdk/blob/master/Firebase/InstanceID/CHANGELOG.md with this fix.

Updated changelog.

Thanks! We should remove dates from these CHANGELOG's, but that is for another PR.


Documentation: autoTestDiscoverOnSaveEnabled seems to indicate it only works for the unittest framework

From https://code.visualstudio.com/docs/python/unit-testing#_test-discovery one can read:

With unittest, the "python.unitTest.autoTestDiscoverOnSaveEnabled" : true setting (true is the default), automatically performs test discovery whenever you save a test file. To disable this feature, set the value to false.

Reading that text, it seems that it is only possible to disable automatic test discovery for the unittest framework, but not for pytest or nose. However, reading https://github.com/Microsoft/vscode-python/issues/1490 and the fix https://github.com/Microsoft/vscode-python/issues/1037 it makes me believe that python.unitTest.autoTestDiscoverOnSaveEnabled also disables test discovery for the other frameworks.
However reading https://code.visualstudio.com/docs/python/unit-testing#_unittest-configuration-settings it seems to indicate the setting is only for the unittest framework.

Is it maybe so that some of the config under https://code.visualstudio.com/docs/python/unit-testing#_unittest-configuration-settings belongs to "unit test" in general but some of the config belongs to "unittest" (the actual framework that comes with Python)? If so maybe it should be split into two sections, one for General configuration and one for just the unittest framework?

I opened Microsoft/vscode-docs#2068 to fix the wording as it does work for all test runners.


Add CurseBoykott from Kerbal Stuff

This pull request was automatically generated by Kerbal Stuff on behalf of Thomas_Kerman, to add CurseBoykott to CKAN.
Please direct questions about this pull request to Thomas_Kerman.

The "mod" was deleted from KS (with that name, I doubt it was an actual mod anyway).


Update to 1.0.0 ?

When do you release something with 1.0.0 ? Not the beta..
Thanks!

A 1.0.0 release generally means that the library works as it should, and that the risk of some major undiscovered problem is small. Discovering these problems takes time, so it might just be a while before that happens.
I'm not saying the library is buggy though, it just might be :) There is a test suite that covers most of the basic functionality, so for day-to-day usage, you'll probably be fine.


fix(types): allow using functions on the PropTypes (#9692)

What kind of change does this PR introduce? (check at least one)

[x] Bugfix
[ ] Feature
[ ] Code style update
[ ] Refactor
[ ] Build-related changes
[ ] Other, please describe:

Does this PR introduce a breaking change? (check one)

[ ] Yes
[x] No

If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:

[x] It's submitted to the dev branch for v2.x (or to a previous version branch), not the master branch
[x] When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)
[x] All tests are passing: https://github.com/vuejs/vue/blob/dev/.github/CONTRIBUTING.md#development-setup
[x] New/updated tests are included

If adding a new feature, the PR's description includes:

[ ] A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

/cc @HerringtonDarkholme as you may be interested.


Global identifiers for HED terms

There has been some movement to submit HED and the HED score library in particular to INCF for consideration as a standard.
One of the requirements from INCF is that global identifiers be used.  For many of the existing standards INCF standards, the IDs are at a high level -- e.g. at the dataset level or the software package level.
HED by its nature is more fine-grained.  However, I think it makes sense to have IDs at the term level for HED
and I would like to begin discussion about what those IDS should be.
Since terms must be unique within a schema, this simplifies things. Here are some possibilities:

HED:sensory-event
HEDv8.1.0:sensory-event

and for libraries:

HEDSCORE:Intermittent-photic-stimulation
HEDSCOREv0.1.0:Intermittent-photic-stimulation

I prefer not to have the version number. We are committed to not remove terms once they are in, but to use a deprecated attribute if we don't want people to use them.  Terms can be moved within the schema however and attributes modified.
Only HED schema and HED library schema that are in the official repositories as released versions would be considered to have an official global ID.
Comments? @smakeig @dungscout96 @sappelhoff @arnodelorme @dorahermes @tpatpa @happy5214 @IanCa
@monique2208

@VisLab, where can I read more about global identifiers? I want to learn more about existing IDs and requirements/rules for defining an ID. Also, will the global identifiers be used as prefixes when annotating?

The INCF criteria can be found at https://incf.org/incf-standards-review-criteria-v20.
The main item of concern is FAIR#1. This would not affect tagging or analysis at all.
The main concern is having a standardized/persistent way of identifying terms in the schema.
One way is to assign ID numbers to each term in the underlying schema.  These ID numbers could then be used as keys in underlying databases.  However, upon thinking about it, that seems to be unnecessary and more trouble than it is worth, since HED 3G forces the terms themselves to be unique and persistent within the schema.
We just need to agree that we will deprecate terms rather than remove them from future schema.
(We allow terms to be moved within the schema without triggering a major version release.)

However, upon thinking about it, that seems to be unnecessary and more trouble than it is worth, since HED 3G forces the terms themselves to be unique and persistent within the schema.

indeed -- in 3G each term is an ID. I think deprecation rather than removing is a good idea. In many software packages however, deprecation might mean that in a future version of the software, previously deprecated items are no longer accessible at all. How would that be for HED?
Is the registration specifically for HED 3G, or HED in general? What happens with the INCF registration if HED 4G is released (if ever)?

Deprecation: I think we need to leave the terms in the schema so they will be persistent.
The HED Working Group has talked some about a kind of migration policy as people come up with better ways of expressing concepts.  Ideally, there would be a tool that could be run to replace deprecated terms with the new terms. Initially, we had such a tool for the transition from HED-2G to HED-3G, but once HED-3G become so different in philosophy, we decided it was easier just to re-tag directly.
HED3G versus HED4G:  I hate to think of it. I don't know.

The HED namespace and global IDS will be introduced in HED schema version 8.3.0 and specified in PR #576.

HED 8.3.0 will have hedId's --- the mechanisms and the embedding into a HED ontology are discussed in the new HED specification chapter on HED ontologies.