Annotate service does not always find the longest match

Example:
http://geoffrey.crbs.ucsd.edu:9000/scigraph/graph/OMIM:612555
The label field is
"Breast-Ovarian Cancer, Familial, Susceptibility To, 2"

When this label is plugged into
http://geoffrey.crbs.ucsd.edu:9000/scigraph/annotations/entities.json?content=Breast-Ovarian Cancer, Familial, Susceptibility To, 2&minLength=4&longestOnly=true
It finds a valid but shorter match
When finding all matches
http://geoffrey.crbs.ucsd.edu:9000/scigraph/annotations/entities.json?content=Breast-Ovarian Cancer, Familial, Susceptibility To, 2&minLength=4&longestOnly=false
It doesn't list OMIM:612555
Hypothesis: the weird comma and number nomenclature of OMIM is confusing things

This is actually just related to the maximum shingle count that the annotation processor will examine. When increased the expected entity is found. There's a performance trade off to inspecting longer sequences of shingles. Would just raising the limit a bit be acceptable?

It feels like the time taken to annotate a piece of text is much longer now. Opening for investigation. The following text often times out.
An alternative hypothesis is that this has nothing to do with shingles, and is in fact a result of adding genes for multiple species (each gene like 'Hsc70' now matches once for every ortholog)
Hsc70 with its cochaperone, either auxilin or GAK, not only uncoats clathrin-coated vesicles but also acts as a chaperone during clathrin-mediated endocytosis. However, because synaptojanin is also involved in uncoating, it is not clear whether GAK is an essential gene. To answer this question, GAK conditional knockout mice were generated and then mated to mice expressing Cre recombinase under the control of the nestin, albumin, or keratin-14 promoters, all of which turn on during embryonic development. Deletion of GAK from brain, liver, or skin dramatically altered the histology of these tissues, causing the mice to die shortly after birth. Furthermore, by expressing a tamoxifen-inducible promoter to express Cre recombinase we showed that deletion of GAK caused lethality in adult mice. Mouse embryonic fibroblasts in which the GAK was disrupted showed a lack of clathrin-coated pits and a complete block in clathrin-mediated endocytosis. We conclude that GAK deletion blocks development and causes lethality in adult animals by disrupting clathrin-mediated endocytosis.


How to Report Uncertainty Chapter

See issue #320  for discussion of these changes.
Release checklist

[x] Authors updated in cf-conventions.adoc?
[ ] Next version in cf-conventions.adoc up to date? Versioning inspired by SemVer.
[x] history.adoc up to date?
[ ] Conformance document up-to-date?

For maintainers
After the merge remember to delete the source branch.
Tags are set at the conclusion of the annual meeting; until then master always is a draft for the next version.

This looks very good, I appreciate all the work that went into it. I DO have a question (or 3) about how this could be applied to vectors (e.g. northward/eastward_sea_water_velocity or northward/eastward_wind), where there are uncertainties in both speed and direction, and the units for the directional uncertainty won't match the units for the vector. Unless I missed it, the proposal doesn't require that the units match, but I'd just like to double check that that wasn't assumed.
Also, can I include uncertainty as a percentage of a measurement?
The  document doesn't spell out (again, maybe this is assumed) that  a single set of uncertainty variables can be applied to more than one data variables, in this case both eastward and northward vectors.  Is there any problem with both northward_ and eastward_sea_water_velocity sharing an ancillary variable (or a group of them) for this purpose?
Thanks!

Great questions. Let me answer them in reverse order.
...
Does this help?

Yes, thanks very much, this answers all of my querstions!

It may be difficult to read the standard without running ASCIIdoc. To help reviewers here is the PDF of the pull request.
cf-conventions.pdf


use mapcap created_at as vizjson updated_at

Fixes #8444
Since the way the vizjson presenter chooses the updated_at is complex and we can shortcut by grabbing the mapcap created_at, I wen't for the uglier thing.
Let me know if you disagree.
Please CR @juanignaciosl !

@juanignaciosl I've done a bit of research. It turns out that map.vis_updated_at was created for the vizjson, and I believe it's safe to change. I've made it mapcap sensible.
I only affects the vizjson and a table controller, which will most likely never have a mapcap since it's table visualisation focused.
Let me know what you think.

Uhm, nice research! It looks safe and makes sense 👍


Return Result from EmailAddress::new()

When instantiating an EmailAddress, using new() is the most natural API; it
also allows the user not to care about which parsing algorithm is used under
the covers, providing less friction for the user. However, due to the use
of unwrap() inside new(), invalid email addresses will panic. Instead,
propagate out the Result type from the parser to new()'s caller.

Thanks!

Thanks for merging this, and the other improvements. 👍


Request: Could you make version 3.2.3 avaliable to install from the marketplace again?

I dislike the changes made in version 4.0.0, as for me at least it has the bugs of the bottom idle message not showing, and it updates the rich presence far more slowly. I had to format my system and was going to install that version again; but apparently it is gone from the marketplace? I could try building it from source but i have no idea how to tbh, i tried running the build but it always gives me errors
Edit: apparently it seems the bottom message not showing issue is solved / being solved - however i still dislike the newer version's slower responsiveness when updating user status

In answer to the topic of this issue, you can choose which version you want from the extensions tab in vscode.

The bottom idle message is not a issue, that feature has been put under a setting, and whoever wants to can activate it.
Release v4.3.0
Commit https://github.com/LeonardSSH/vscord/commit/a6e2c354bfb6c56440fe1f959207a5edd422d2ae
{
  // set to false if you want to appear in presence
  "rpc.removeLowerDetailsIdling": false
}

however i still dislike the newer version's slower responsiveness when updating user status

Can you give me more details?


[AutoPR storage/resource-manager] [SRP] Support Active Directory and regenerate kerb keys

Created to sync https://github.com/Azure/azure-rest-api-specs/pull/7506

This PR has been merged into https://github.com/Azure/azure-sdk-for-go/pull/6048


Allows you to force when you want to be halloween and config the luck like the drop.

I think I can do better than that, I would do a PR again at this precise moment.


Webpack issue involving fetch(), whatwg-fetch(), and polyfill loading

Have been having a strange problem over the last few days while trying to import and use any of the promise-based fetch() modules.  Here's the solution I found-- update the .structor/webpack.base.js file to reflect:
new webpack.NoEmitOnErrorsPlugin(), new webpack.ProvidePlugin({        // make fetch available       fetch: 'exports-loader?self.fetch!whatwg-fetch', }),
there are 2 changes, the first is that the -loader suffix was missing from exports, and second is the NoEmitOnErrorsPlugin needed updating after webpack was complaining about using a deprecated module.
Not sure if this is known or not, but I wanted to document it for anyone else that might be experiencing these issues.
Thanks again for your hard work!

My solution was to create a class.
import 'whatwg-fetch';

class ClientFetch {
  constructor(props) {
    this.fetch = this.fetch.bind(this);
    this.Headers = this.fetch.Headers;
    this.Request = this.fetch.Request;
    this.Response = this.fetch.Response;
  }
}

export default ClientFetch;


SourceMaps not working

I'm requiring a js file from my project, and I have devtools enabled with webpack. When I go to Chrome Devtools and I try to check the file, I only can see a compiled file like this:
module.exports = "[all-the-code]".
So... it's impossible to me to debug using devtools.

This is actually already implemented but hidden behind a debug flag.  If you're using webpack 2, one way to do this is add a plugin to the plugins array:
    new webpack.LoaderOptionsPlugin({
      debug: true
    })

I'm not sure why this isn't enabled by default 😕

I am using script-loader inline with webpack2.
I have the same problem.
I have tried both options, but it doesn't seem to work:
    // in webpack.js
    devtool: "sourcemap",
    plugins: [
        new webpack.LoaderOptionsPlugin({
              debug: true
            }),

My javascript file imports the relevant scripts inline as I only want to use script-loader for a few legacy scripts.
import "script-loader?sourceMap=true!../../sass/wrapkit-1.2/app/scripts/wrapkit/classie.js";

The result is inline module.exports = code without source maps that cannot be debugged.
module.exports = "(function(){\n  'use strict';\n  var WrapkitUtils = window.WrapkitUtils;\n\n  // slim scroll\n

any suggestions?

@jimmymain Check my little example: https://github.com/Rouche/webpack-test
You can find the file with Ctrl+P pattern is like script:///C:/[full path to file].js


Downloading file issues

Full file doesn't download. Avoid calling GofileFile.download()

commit e322498 and update v0.2.2 solved this issue


Remove unactive README notice

It appears that this project is now actively maintained, at least since April.
In March, I tried adding Station to awesome-mac, a Mac application list with over 60k stars, but the repo owner saw the ⚠ This project is not actively maintained notice. Might as well remove it, and I'll send another PR over so that more users can find this browser.

@viktor44 do you feel comfortable enough so that we can indeed remove this warning?

Sure

Thanks!


Explicitly use :latest images for system tests

By using X:latest images instead of just X, we avoid pulling all tags for
the given image. This should hopefully improve test speed and reliability,
since a lot of tests fail due to timeouts while pulling public images.

@davidxia @gimaker @rculbertson

@rohansingh Also here? https://github.com/spotify/helios/blob/master/helios-system-tests/src/main/java/com/spotify/helios/system/PredefinedPortImageDeploymentTest.java#L54

omg yes :+1:


Issues on UDS path binding

I think there are couple issues relate to the UDS path binding logic:

In the JNI netty_unix_socket_bindDomainSocket method, when the upper level passes in a longer-than-limit UDS path.
a. the unlink() is called on a different path than the one the code later bind to.
b. Netty is quietly truncating the path if user provides a over the limit path. This can be an issue if we have a non-Netty client which has a different path handling logic.

According to the manual, "a UNIX domain socket can be bound to a null-terminated filesystem pathname", but Netty is not doing anything about this requirement. Although there are some messes on handling this requirement, we should not simply ignore it. This is also an issue if we have a non-Netty client.

I am proposing a possible fix for all these issues. We can just validate the socketPath passed in and let Java throw exceptions if: 1) the socketPath is longer than sizeof(addr.sun_path), 2) or, the socketPath has the same length as sizeof(addr.sun_path) but the last byte is not '\0'. A similar thing also need to be done on the client side. This can ensure the UDS paths Netty can use have maximum compatibility with other UDS servers/clients.
I can send a PR if the change mentioned above is desirable. Thank you.

Sounds good . Will provide more feedback on the PR


Fortify fix

Change description
Fortify -scan fix changing the variable value other than "pass" word
Does this PR introduce a breaking change? (check one with "x")
[ ] Yes
[x] No

closing this as Fortify environment variable name was he issue and it has been now suppressed


Fatal error in ../deps/v8/src/handles.h, line 48

I keep getting this error while trying to save 40K nodes and 20K relationships (20K to other 20K) in a single transaction:

#Fatal error in ../deps/v8/src/handles.h, line 48
#CHECK(location_ != NULL) failed
==== C stack trace ===============================
1: ??
2: ??
3: ??
4: ??
5: ??
6: ??
Process finished with exit code 132

The nodes are small, each 3-4 properties, 10MB total size in JSON. The code looks like this (say movies and actors) :
var txn = db.batch();
movies.forEach(function (movie) {
    var movieNode = txn.save(movie);
    txn.label(node, "Movie");
    actors[movie.id].forEach(function (actor) {
        var actorNode = txn.save(actor);
        txn.label(actorNode, "Actor");
        txn.relate(actorNode, 'ACTS', node);
    })
}
txn.commit(function (err, results) {/*err handling*/})

Raising the memory limits with --max-old-space-size up to 4GB doesn't help. Activity monitor reports the process taking up 670m/850m for some 20sec and then it jumps to 1.2GB befire it dies with the msg printed. Any hints?
Node: v0.12.4
seraph: 0.13.1
OS X: 10.10.4

I have absolutely no idea, I've never run into this limit before. Might be something interesting worth exploring. In the mean time I would take a look at using cypher to input your data, using the transactional cypher endpoint. Unfortunately seraph doesn't have direct support for this yet, but it's possible to build the requests yourself using seraph as an aid. You can see an example of this here: https://github.com/brikteknologier/seraph-snapshot/blob/master/seraph-snapshot.js#L103 - and you can see the neo4j api documentation here - http://neo4j.com/docs/stable/rest-api-transactional.html

Could you create a reproduction snippet for this?  I tried creating a small program that simulates your input based on your description, but I do not get the same behavior.
This takes a very long time to run, but does not crash after 20 seconds:
var db = require('seraph')();

var movies = [];

for (var i = 1; i <= 20000; i++) {
  movies.push({
    "title": "Rocky " + i,
    "rating": ((1 / Math.sqrt(Math.sqrt(i))) * 10) >> 0,
    "budget": "$" + i + "000000"
  });
}

var actors = [
  { "name": "Sylvester Stallone" },
  { "name": "That Other Guy" },
  { "name": "Sylvester Stallone Again" },
  { "name": "Sylvester Stallone's left biceps" },
  { "name": "Taxi Driver Guy" },
  { "name": "Sylvester Stallone's right biceps" },
  { "name": "Bill Baldwin" },
  { "name": "Sylvester Stallone's Towel" },
  { "name": "Burt Young" }
]

var txn = db.batch();
movies.forEach(function (movie) {
    var movieNode = txn.save(movie);
    txn.label(movieNode, "Movie");
    actors.forEach(function (actor) {
        var actorNode = txn.save(actor);
        txn.label(actorNode, "Actor");
        txn.relate(actorNode, 'ACTS', movieNode);
    });
});

txn.commit(console.log);

@deestan sure, i'll try to package it up in a small project, hopefully this weekend.

ok, couldn't reproduce with 20k nodes in the stripped down version, but ~260K nodes and ~220K relationships (about 5MB of JSON files), and it crashes after a few minutes. @deestan could you try to run your example with 300K nodes?

here's a repo to reproduce this bug: https://github.com/mbsimonovic/seraph-issue-171
make sure you give neo4j enough ram (at least few gigs) so it doesn't runs out of memory. Running this on my laptop fails in about a minute, and seems like i missed the last log output line:

Illegal instruction: 4

@deestan hey, you managed to reproduce this?


chore: use GitHub package registry

Pull Request Test Coverage Report for Build 819311326

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 17.732%

Totals

Change from base Build 817467718:
0.0%

Covered Lines:
2031

Relevant Lines:
11749

💛  - Coveralls


[Bug] Invalid regular expression when loading bigscience/bloomz-3b with AutoTokenizer.

Describe the bug
Invalid regular expression when loading bigscience/bloomz-3b with AutoTokenizer.
How to reproduce
Paste in brower console:
await import("https://cdn.jsdelivr.net/npm/@xenova/transformers@1.4.2/dist/transformers.min.js");
let tokenizer = await AutoTokenizer.from_pretrained("https://huggingface.co/bigscience/bloomz-3b/resolve/main");

Logs/screenshots
tokenizers.js:872 Uncaught SyntaxError: Invalid regular expression: / ?[^(\s|[.,!?…。，、।۔،])]+/: Unmatched ')' (at tokenizers.js:872:31)
    at new RegExp (<anonymous>)
    at Function.pre_tokenize_text (tokenizers.js:872:31)
    at tokenizers.js:781:41
    at Array.map (<anonymous>)
    at Function.pre_tokenize (tokenizers.js:781:27)
    at tokenizers.js:1372:30
    at Array.reduce (<anonymous>)
    at Function.pre_tokenize_text (tokenizers.js:1371:32)
    at Function.pre_tokenize (tokenizers.js:783:27)
    at Function._call (tokenizers.js:794:21)

Environment

Transformers.js version: 1.4.2

It should be simple to fix this - looks like I'm missing a call to escapeRegExp :)

Update: It is not as simple as escaping the regex... 😅
I'm unable to parse that regex, even in python... I've also noticed that there is no python implementation of the BloomTokenizer in the transformers library (only a BloomTokenizerFast, which is implemented in rust).
I get the same error as you do (re.error: unbalanced parenthesis at position 21), in python and javascript.

Looks like it's a known issue: https://huggingface.co/bigscience/bloom/discussions/212

Here's an equivalent regex which seems to work:
 ?[^\s|.|,|!|?|\u2026|\u3002|\uff0c|\u3001|\u0964|\u06d4|\u060c]+

Ah, okay, thanks for your investigation!! Sounds like this issue should be closed.

No worries :) If you'd like you can submit an issue to the transformers/tokenizers repo, since it does appear to be an issue faced by others. I imagine it hasn't been fixed yet because most people use it through the Rust library (which seems to parse it correctly).
For now, it's probably fine to just replace the regex with what I posted above (it works on my side).


Handle dependency installation when both pyproject.toml and requirements are present.

Always do editable install first.
Do requirements install after.

Verification steps:

Check out this repo: https://github.com/karthiknadig/toml_req_test
Ensure you have python extension.
Run the Python: Create Environment Command
Select `venv', and any python version.
It should show you Optional dependencies selection from TOML.
After that it should show you requirements.txt.

Consider this verified if you see both selection quick picks for Toml and requirements.txt


Issue #46285: Placed locks into for-loops

Bugsquad edit: This closes https://github.com/godotengine/godot/issues/46285.

Thanks for opening a pull request!
 This way, people reading the Git log can easily figure out what's going on :slightly_smiling_face:


[Feature request] Keyboard shortcut to open the app

📝 Provide a description of the new feature
As a keyboard poweruser, I would like to be able to open/close the app with a keyboard shortcut (preferably customizable, can be disabled by default) to avoid using my trackpad/mouse.
➕ Additional Information
I didn't try it for now, but I think this is possible using electron global shortcuts API
If you think this could be a new feature, I'd like to work on it 😁

For sure a useful one! Yeah, feel free to work on it!


Process bar is added without any styling.

Great teamwork with Burak.

We have added a process bar to questionPage. We will add some CSS.


Does the pypi 0.4.0 version come from the master branch?

I have a small python module that I am using to test the mozilla web push api.  Version 0.2.0 worked fine; however after upgrading to 0.4.0, the code no longer works.  I took a look at the master branch and I couldn't find a change that would explain the failure.

0.4.0 tracks the latest spec, which includes a different padding size (2 octets instead of just 1).
I've just uploaded 0.4.1, which includes an extra argument, padSize, which you can use to set the smaller padding size.

And yes, I realize that I neglected to push.  Does 0.4.1 address the issue for you?

0.4.1 did not work for me.  I'm fine with pinning the version to 0.2.0 for now.

To use 0.4.1 with Firefox, you need to pass padSize: 1 in the parameters.

@jamaalscarlett, #15 has just landed with a fix that I think should fix your problem.

Thanks, I will try it and let you know.

0.5.0 released


GQUIC SNI

Hi,
I was wondering if there was any way to disable SNI processing in GQUIC connections. Our current setup is we have a proxy in the middle that does the SNI extraction and IP lookup itself, proxying the packet to the lsquic server engine. However, this seems to be causing problems because I cannot get the handshake to establish. It seems to fail on an SNI related method: get_sni_SSL_CTX,  some debug output:
14:28:30.866 [DEBUG] [QUIC:990F33050EB705C8] handshake: parse_hs tag 'CHLO' no error.
14:28:30.866 [DEBUG] [QUIC:990F33050EB705C8] handshake: handle_chlo_frames_data got data format error 2.
14:28:30.866 [DEBUG] [QUIC:990F33050EB705C8] event: lsquic_enc_session_handle_chlo returning HS_ERROR
14:28:30.866 [INFO] [QUIC:990F33050EB705C8] mini-conn: lsquic_enc_session_handle_chlo returned an error (-1)

presumably because it's trying to do the translation itself? I'm still in the process of reading the source myself, but is there any other easier solution here?
Thanks.

User error. Closing.


A simple minesweeper game-minesweeper[.cpp & .hpp]

remove swap() in putrect function;
graphics.cpp
It was slowing down the processing.

Created a basic interface for the keyboard.
keyboard.cpp
keyboard.hpp

@Jmallone Since this code doesn't really add any new kernel features (other than the keyboard driver, which I will likely cleanup and merge into dev), would you be alight if we added a "demo" section to the README with a link to your code? Once we get userspace working (which I will be working on this week, starting finishing the heap code and then allocating user pages), we can absolutely get a finalized version of this added to whatever programs / apps we have as part of the base system. Hopefully by then you could also work on the GUI / windowing code you wanted to do before. 🙂

@Kfeavel
Of course, you can put it as "demo" in the README
I can't wait for userspace, the GUI will be amazing too

Going to merge the demo section in #385. :+1:


FuzzyMatch by @nzeh

Provides a predicate 'fuzzyMatch' that is much more lenient in matching
completions in XMonad.Prompt than the default prefix match.  Also provides
a function 'fuzzySort' that allows sorting the fuzzy matches by "how well"
they match.
Not sure why wasn't it accepted.
Discussion: https://markmail.org/thread/kgrybzqarqzqiige

[x] I've read CONTRIBUTING.md

[ ] I tested my changes with xmonad-testing

[x] I updated the CHANGES.md file

At the time I guess it wasn't accepted since not many things actually used the searchPredicate and the documentation was therefore misleading.  But it seems that issue has been addressed since then (https://github.com/xmonad/xmonad-contrib/commit/0d4439b7a7990a1b3b42856740c487a7bc180307) and this looks good to me.

https://github.com/xmonad/xmonad-contrib/blob/d3d0818e9b9ef6e270b1b0e8c0e6ac683274da80/XMonad/Prompt/FuzzyMatch.hs#L58
-- > myXPConfig = def { searchPredicate = fuzzyMatch
--                    , sorter          = fuzzySort
--                    }

The Haddock example for this patch doesn't work, there is no field sorter in XPConfig.
@l29ah perhaps you meant to include the following patch too?
https://github.com/l29ah/xmonad-config/blob/master/patches/xmonad-contrib-prompt-sorter.patch

On Mon, May 28, 2018 at 12:42:38AM -0700, Sam Doshi wrote:

@l29ah perhaps you meant to include the following patch too?
https://github.com/l29ah/xmonad-config/blob/master/patches/xmonad-contrib-prompt-sorter.patch

Yes, i've missed it somehow.
--
()  ascii ribbon campaign - against html mail
/\  http://arc.pasp.de/   - against proprietary attachments

Added a PR with your patch and some fixup:
https://github.com/xmonad/xmonad-contrib/pull/282


proxy support

Adds support for the HTTPS_PROXY environment variable to configure py42.settings.proxies within the CLI.
Resolves #330

Ah thanks for taking a look at this, I was completely unfamiliar with how our proxy support currently worked. ⭐

can a new release be issued with this PR?
I've been waiting on this feature for a while and really excited to test it out.


add 12c sample to readme.md

Hi. everyone.
current version of readme.md describe 11g's express edition example.
Could you add 12c ee's example like below.

how to connect default cdb/pdb

sqlplus pdbadmin/password@localhost:1521/ORCLPDB1
sqlplus system/password@localhost:1521/ORCLCDB
sqlplus sys/password@localhost:1521/ORCLCDB as sysdba

thanks.

If those examples work (I'm not a Database person, so I've assigned this to @gvenzl), you should feel free to submit a pull request that adds those examples to the appropriate README.md. I'm sure @gvenzl would appreciate the assistance. :)

OK.
I have no time now, so I'll try later and send PR.

I'm not sure I fully understand the request.
The ReadMe of the Oracle Database Docker images already includes this information:
Once the container has been started and the database created you can connect to it just like to any other database:

sqlplus sys/<your password>@//localhost:1521/<your SID> as sysdba
sqlplus system/<your password>@//localhost:1521/<your SID>
sqlplus pdbadmin/<your password>@//localhost:1521/<Your PDB name>

The Oracle Database inside the container also has Oracle Enterprise Manager Express configured. To access OEM Express, start your browser and follow the URL:

https://localhost:5500/em/

Closing issue due to no response.


Demo Colab Link broken

I was looking to try out the demo and noticed the link to the colab for it leads to an image inpainting notebook, which is weird because I had clicked on it a few days ago and it brought me to the right notebook. Any help would be appreciated
Link it brought me to:
https://colab.research.google.com/github/SHI-Labs/FcF-Inpainting/blob/main/colab/FcF_Inpainting.ipynb

Hi @wardcarson; thanks for pointing this out!
The issue was with the link inside the demo directory's Readme. The link in the main readme works fine. Anyway, it's fixed now. Again, thanks for pointing it out.


ng build -bh /app/ does not work. However ng serv -bh /app/ works

[x ] bug report -> please search issues before submitting
[ ] feature request

Versions.
 When I use build I get 404.
The log given by the failure.
404
Desired functionality.
same as ng serve
Mention any other details that might be useful.

This sounds like a deployment problem. Please take a look at https://angular.io/guide/deployment for information about how to deploy your application.


Create CODEOWNERS

Why are you requesting Review and then merge without one @ryjones ? What are you trying to achieve here? I follow projects to stay on top of things, but without explanations why things are happening this is a bit hard and I'm tempted to unfollow TSC now...
IMO the sequence that usually gets everyone on board (consensus) is Issue->PR->Review->Merge (by more than 1 person executing all steps :-). Looks like you guys at LF don't do it this way, so some explanation to help me adapt to how you run things (t)here would be appreciated.

I have to say that I'm also surprised.

if you look here you will see no changes were applied to the org.

if you look here you will see no changes were applied to the org.

It's probably obvious to you what is shown there -- I don't understand it. Are you saying some tool is auto-generating PRs, Review requests and merges now, @ryjones ?

I said none of that. The merged PR resulted in no changes to the org.

Why then did you request a Review of us?

Hi @ryjones, there were some questions raised about this PR in yesterday's OQS developers call. Could you please provide an explanation about the purpose of the CODEOWNERS file? For example, is it to publicly reflect the current access rights in the org? Or is it a new way to do access control in OQS?
Please also be aware of the review and approval process we have in OQS before merging PRs. It would be much appreciated. Thanks.

@ryjones Going forward, please document your explanations publicly and not only in mailing lists that LinuxFoundation does not commit to retain for public consumption.
To do it for this issue, copying your mail here:
With regard to your questions on [PR6](https://github.com/open-quantum-safe/tsc/pull/6):

    Could you please provide an explanation about the purpose of the CODEOWNERS file?

The [CODEOWNERS](https://github.com/open-quantum-safe/tsc/blob/main/CODEOWNERS) file limits access to editing that one file to me and members of the TSC.
The [function of the file is outlined here](https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/about-code-owners). It also means that the people in that list will be pinged on

    For example, is it to publicly reflect the current access rights in the org? Or is it a new way to do access control in OQS?

Neither. It reflects access to that one file in that one repo. It is a GitHub feature.

[CLOWarden](https://github.com/cncf/clowarden) is a service provided by CNCF for managing org and repo access.
The [config.yaml](https://github.com/open-quantum-safe/tsc/blob/main/config.yaml) file CLOWarden uses is the file covered by the CODEOWNERS file.
CLOWarden provides a way to manage permissions to orgs and repos, and provides a public audit of changes. [Here is an example](https://clowarden.io/audit/?organization=hyperledger-labs&page=1).

    Please also be aware of the review and approval process we have in OQS before merging PRs. It would be much appreciated.

Mea culpa.

Ry Jones
Senior Community Architect
[Book a meeting](https://fantastical.app/rjones/hyperledger) [Chat on Discord](https://discord.com/servers/hyperledger-foundation-905194001349627914)

I appreciate you're employed by LinuxFoundation and accordingly, follow the orders of those companies; I also guess you have to juggle more projects than just OQS; nevertheless, it would be very much appreciated if you could explain rationale and mechanics of what you're doing also to the non-LF OSS community so we can follow and not spend hours wondering, barking up the wrong tree or just despairing. Thanks in advance!

Oh, and I still don't understand the contents of the config file that @ryjones added completely without PR: Its contents IMO do not reflect decisions of the TSC (that I recall) nor are representative of OQS' current maintenance and contributor state. I think this file could be used to implement whatever the TSC decides on #2, but I'm not sure: Allow me to reiterate the request for #7 @dstebila which might explain all of this (maybe this did get discussed/agreed and I just "didn't get it" -- along the same vain as the OQS-wide activation of DCO: I understand OQS no longer is an OSS project but an LF one, so they slap on their procedures -- but informing the community about it ahead of time would be courteous).

Oh, and I still don't understand the contents of the config file that @ryjones added completely without PR: Its contents IMO do not reflect decisions of the TSC (that I recall) nor are representative of OQS' current maintenance and contributor state. I think this file could be used to implement whatever the TSC decides on #2, but I'm not sure: Allow me to reiterate the request for #7 @dstebila which might explain all of this (maybe this did get discussed/agreed and I just "didn't get it" -- along the same vain as the OQS-wide activation of DCO: I understand OQS no longer is an OSS project but an LF one, so they slap on their procedures -- but informing the community about it ahead of time would be courteous).

That file represents the state of the access as configured in GitHub at the time I created it. If it does not represent the community, or the decisions made therein, please file an issue to document the changes required.


How to get real distance for labeled object given an image.

Hi Deng, thank you for sharing this code. I am wondering how ZoeDepth convert depth to real distance?

I'm not professional in that field and my current project don't have to get exact real distance so I didn't have much research on it. you have to forward this question to ZoeDepth https://github.com/isl-org/ZoeDepth  and they have link for their paper in that. Sorry about that

https://github.com/isl-org/ZoeDepth/issues/10#issuecomment-1643770289

Hi Deng, thank you for sharing this code. I am wondering how ZoeDepth convert depth to real distance?
https://github.com/isl-org/ZoeDepth/issues/10#issuecomment-1643770289
" , the model was trained with meters as units for depth. So the output is always supposed to be in meters."

Hi Deng, thank you for sharing this code. I am wondering how ZoeDepth convert depth to real distance?

https://github.com/isl-org/ZoeDepth/issues/10#issuecomment-1643770289
" , the model was trained with meters as units for depth. So the output is always supposed to be in meters."


fix #10958 and polish duplicates code

What is the purpose of the change
fix #10958 and polish duplicates code
Brief changelog
Verifying this change

Checklist

[x] Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
[ ] Each commit in the pull request should have a meaningful subject line and body.
[ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
[ ] Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
[ ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
[ ] Add some description to dubbo-website project if you are requesting to add a feature.
[ ] GitHub Actions works fine on your own branch.
[ ] If this contribution is large, please follow the Software Donation Guide.

Please fix uts

OK~

Please fix uts
好了,因为有好多单元测试和zookeeper 相关,但是单测这边并没有要求本地需要什么样的环境.....这个

抱歉少提交了文件

@AlbumenJ  all testcases bas been fixed

it bas been fixed

it bas been fixed

@AlbumenJ

Codecov Report

Merging #11102 (3c18fe2) into 3.1 (e219c1f) will decrease coverage by 4.79%.
The diff coverage is 86.66%.

@@             Coverage Diff              @@
##                3.1   #11102      +/-   ##
============================================
- Coverage     69.36%   64.56%   -4.80%
+ Complexity      126       14     -112
============================================
  Files          1496     1421      -75
  Lines         79326    59397   -19929
  Branches      14007     8733    -5274
============================================
- Hits          55023    38349   -16674
+ Misses        19527    16998    -2529
+ Partials       4776     4050     -726

Impacted Files
Coverage Δ

...n/java/org/apache/dubbo/metadata/MetadataInfo.java
77.41% <66.66%> (-2.40%)
:arrow_down:

...ient/metadata/ProtocolPortsMetadataCustomizer.java
88.88% <100.00%> (+6.53%)
:arrow_up:

...nt/metadata/ServiceInstanceHostPortCustomizer.java
63.63% <100.00%> (-23.64%)
:arrow_down:

...luster/router/script/ScriptStateRouterFactory.java
0.00% <0.00%> (-100.00%)
:arrow_down:

...he/dubbo/test/common/impl/GreetingServiceImpl.java
0.00% <0.00%> (-100.00%)
:arrow_down:

...zookeeper/curator/CuratorZookeeperTransporter.java
0.00% <0.00%> (-100.00%)
:arrow_down:

...nfigure/DubboRelaxedBinding2AutoConfiguration.java
0.00% <0.00%> (-100.00%)
:arrow_down:

.../apache/dubbo/test/spring/SpringXmlConfigTest.java
0.00% <0.00%> (-96.16%)
:arrow_down:

...egistrycenter/context/ZookeeperWindowsContext.java
0.00% <0.00%> (-81.82%)
:arrow_down:

...istrycenter/processor/FindPidWindowsProcessor.java
5.40% <0.00%> (-81.09%)
:arrow_down:

... and 490 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

it bas been fixed

good job


Idea: improve platform-specific parts of the docs

Just came across this sphinx plugin: https://sphinxcontrib-platformpicker.readthedocs.io/en/stable/usage.html - this looks nice and could clean up some platform-specific parts of our docs

Hey! I can manage this. Should I start a PR?

Hey! I can manage this. Should I start a PR?

@sayandip18 Sure, great! Just go ahead, let me know if I can help, and many thanks in advance!


Questions about the principle of packing

Windows was successfully installed after packaging, but only one electron shell，
Can you tell me about the packaging mechanism

but only one electron shell，
What do you mean by that?

That is to say, after packaging, running.Exe has electron process, but there is no window.


cranelift: Simplify StackAMode variants

Instead of describing how these address modes might be implemented (using a stack or frame pointer, say), describe what they represent. Also, remove the unused type fields from all variants and from gen_get_stack_addr.
The three kinds of stack addresses that we currently need to generate in a target independent way refer to either caller or callee argument areas, or refer to the spill slots and explicit stack slots within the frame.
It is a target-specific implementation detail whether the incoming argument area is indexed relative to the frame pointer, or whether the stack slots are located by tracking a "nominal" stack pointer offset.
So let's not muddy up the target-independent code by using names that refer to these target-specific concepts.

Looks to me like maybe a flaky test in the preview2 test suite, so I'm going to try re-submitting it and see if it goes through this time.


skip nova boot and ping tests for rhosp.

our RHOSP CI runs are intermittently failing at nova boot and ping test as router status is down. This PR is providing a temporary hack to skip these tests until we find a fix. We will revert this back once we fix the underlying issue.

retest


feat: abstract KleinFour into a class IsKleinFour.

This removes KleinFour in favor of a class IsKleinFour and proves that any two IsKleinFour groups are isomorphic via any identity-preserving equivalence. In addition, we prove that a group of order 4 is not cyclic if and only if it has exponent two.
There are several advantages:

this provides a general API accessible by other groups
we prove some generic facts about groups of exponent two
it is easy to @[to_additive] everything

If we want, we can always redefine an explicit KleinFour group, and give it an IsKleinFour instance. In that case we probably want to make a bespoke type for it, so that it can be to_additive-ized.

I deleted the KleinFour definition (and related material) primarily because it doesn't allow for a to_additive version. I'm happy to revert that deletion though if it's preferred.

Does this need to wait for 8723 or is it ready to go? Anyway thanks!
bors d+


Ochuman nb

Adding notebook

@FraPochetti LGTM. One minor change that I would do is to remove the pip instal ... output as it takes a lot of the screen real estate, and hide more important stuff that lays below it.
In the introduction, I would put this:
OCHuman(Occluded Human) Dataset
From the OCHuman repo:

This dataset focus on heavily occluded human with comprehensive annotations including bounding-box, humans pose and instance mask. This dataset contains 13360 elaborately annotated human instances within 5081 images. With average 0.573 MaxIoU of each person, OCHuman is the most complex and challenging dataset related to human. Through this dataset, we want to emphasize occlusion as a challenging problem for researchers to study.

Removed notebook in the root dir and addressed comment from Farid

Another PR! Here we go!! Thanks a lot Francesco!


XLNet tokenizer returns empty list instead of string for some indexes

🐛 Bug

Model I am using (Bert, XLNet....):
XLNet
Language I am using the model on (English, Chinese....):
English
The problem arise when using:

[ ] my own modified scripts: (give details)

The tasks I am working on is:

[ ] my own task or dataset: (give details)

To Reproduce
Steps to reproduce the behavior:

Create tokenizer: tokenizer = XLNetTokenizer.from_pretrained(path)
Try to decode index 4: tokenizer.decode(4)
You get empty list [] although expected is a string

Expected behavior
Decode method of the tokenizer should return a string and not a list.
Environment

OS:
Python version: 3.7
PyTorch version: 1.1.0
PyTorch Transformers version (or branch): 1.2.0

Hi,
tokenizer.decode() expect a sequence of ids as indicated in the doc/docstring: https://huggingface.co/pytorch-transformers/main_classes/tokenizer.html#pytorch_transformers.PreTrainedTokenizer.decode

well, as far as i see, the tokenizer can accept both - sequence or single index. For example:
tokenizer = XLNetTokenizer.from_pretrained('xlnet-base-cased')
tokenizer.decode(3)
produce '' as well as tokenizer.decode([3]).
And the problem happens in both cases:
tokenizer.decode([4]) produces empty string. And what is even more strange if index 4 is in the sequence the result is list instead of a string. For example:
tokenizer.decode([35,109]) gives 'I new', but tokenizer.decode([35,109,4]) generates list instead of a string ['I new']

ok, it looks like 4 is an index of a separation token and it turns one sequence into sequence of sequences each of which will be decoded into string. So if index 4 presents in the sequence, the result will be list of strings. This behavior is quite unintuitive. If it was created purposely, should be properly documented. I've got very strange bug in my code that was hard to track, since index 4 was predicted very rarely and out of 500 predictions 1 was buggy.

Thanks for the bug report. Indeed this was an unwanted behavior. Fixed on master now.


Prevent clashing chunk IDs

This PR solves the issue in #64
With a large enough data set, the clashing occurs relatively often. We can quickly solve this by adding a random bit into the hash function. Alternatively, we can explore using a set for ids instead of a list, which might compromise the data. (ie. what if you're trying to use the bot to make up its own language syntax and communicate via only 10 words)

The existing_ids = set(existing_docs["ids"]) call looks like it's useless, if there ever actually is a common id, the chroma db get will fail.
We need to be sure that ids = embeddings_data["ids"] is already unique and also make sure it's synced with documents and metadatas. So in the base chunker, we can do something like this:
chunk_id = hashlib.sha256((chunk + url).encode()).hexdigest()
if (chunk_id in ids):
      chunk_id = hashlib.sha256((chunk + url + str(random.getrandbits(128))).encode()).hexdigest()
ids.append(chunk_id)
documents.append(chunk)
metadatas.append(meta_data)

But the chunk_id in ids check is wasteful and will affect performance. So my question is why not have a random bit in every chunk to keep them unique?

Also running into this problem when I am trying to embed a large dataset. I think the random id would fix the issue, but won't we see it affect the retrieving functionality? Two chunks that are identical should not be embedded. The random id circumnavigates the root problem. Maybe we could check to see if the id already exists and if it does then skip to the next chunk? I'm happy to contribute, though I am new to the project and this tech.

I made a PR #165 that solves the issue

I don't think we should be ignoring the chunks that are duplicated. Ultimately, they get stored in the db and queried with 1 result
result = self.collection.query(
            query_texts=[input_query,],
            n_results=1,
        )

but there's an open PR that is looking to change that to an arbitrary n_results.
It's a question of prompt engineering as that's what these chunks ultimately become. To me there's no harm in having more data, especially if it's present naturally in the dataset.

I'd like to distinguish conversation history from database context here. In a conversation, yes you would want to keep repeats. However, in a vector db that stores things for you to look up, ideally, you'd want distinct chunks of information so you can have an LLM to pick which best provides context to the question. Identical chunks would take up tokens, and potentially make you miss out on important context that was edged out by the repeated chunks.
So, when chunking to store in vector db, you want to ignore repeats.
Also, I think the issue here was chunking large files like a book to embed in chroma db? Where are conversations coming in here?
Feel free to poke holes in my reasoning, or if I mischaracterized what you're saying :)

I'm not referring to a conversation, I'm referring to natural repetitions within a dataset. Having repeated chunks in the dataset can suggest to the model that a piece of information is more relevant. The repeated Leo: "Hey!" phrasing would have been present and highly repeated in the original dataset.

Gotcha. How would a model be able to discern that the chunks are distinct if they are identical and thus infer relevance? In actuality, I'd imagine the chunks would be larger than small repeated phrases, and those repeated phrases would be contained within a chunk that the LLM could then use.

Think of it this way. Here's my sample dataset, it's a PDF of a conversation:
Me: "I have something important to tell you!"
Leo: "Tell me!"
Leo: "Hello??"
Leo: "Hello??"
Leo: "Hello??"
Me: "Hi, sorry I was busy.

Assume for simplicity we end up chunking each line. With the salt, we'll end up with 6 chunks. With an in-array check, we end up with 4 chunks.
These get stored in the db. Now I come in with an input query to my bot "I have something important to tell you!" If we used the array check, the db will only think there is a single Leo: "Hello??" and it will not provide the prompt context that the bot could be repetitive in nature.
The prompt context (with n=4) will look like this:
Me: "I have something important to tell you!"
Leo: "Tell me!"
Leo: "Hello??"
Me: "Hi, sorry I was busy.

instead of
Me: "I have something important to tell you!"
Leo: "Tell me!"
Leo: "Hello??"
Leo: "Hello??"

The inference model will likely react differently given the two scenarios. And if for any reason you're trying to capture repetitive behavior, it will fail to do that as repetitions simply won't exist in the chroma context db. At the end of the day, the whole purpose of this chunking is to help create the prompt. In which case, I think we should keep as much data in it's original format as possible from the dataset provided.

Gotcha. How would a model be able to discern that the chunks are distinct if they are identical and thus infer relevance? In actuality, I'd imagine the chunks would be larger than small repeated phrases, and those repeated phrases would be contained within a chunk that the LLM could then use.

From what it looks like, chroma db just queries given an input
result = self.collection.query(
            query_texts=[input_query,],
            n_results=1,
        )

I imagine this means it will return n_results most similar in the embedding space, which should include repetitions if that is a characteristic of the original dataset. The model doesn't need to discern uniqueness from the dataset, the dataset should provide the most relevant embeddings as a prompt to the model. But yes you're probably right that we're oversimplifying how the chunks will look like,  but I think the idea still stands. As the purpose is for prompt creation, repeated chunks will create repeated context which could be intended by the user.

I understand your concern that in some cases you'd want to retain the identical chunks. Perhaps an ideal solution would be to create an option for the user to embed identical chunks, using your method of adding a random bit.

@cachho mentioned a good point about i just dump new stuff in there and click my train button. With the random bits, it would train the whole database every time, right. So it's not just inserting what's missing. So in that case random bits would cause issues.
Made modifications to make the ID duplicate finding more time efficient and also added a type cast, which would cause failures otherwise with that method

Removed the list metadata issue fix exposed by this change as that's solved in #110

This isn't as scary as it looks, @taranjeet green light from me if they fix the last complaint I posted. thanks.

tried your PR. it prevents inserting a chunk twice, which is a good way to handle the error.
The only concern that I have is user will want to refer some chunks above and some chunks below a particular chunk.
And in this case, if we insert a chunk only once, and then for all the other occurences of the chunk, pre/post context will be missing. Also for this we will have to introduce a concept of sequence id.
Right now merging this PR, but opening an issue to track this request.
We will have to introduce a concept of sequence id first, so that we can get 3 (for eg) chunks above the chunk and 3 below.
We will also have to figure out to insert repeating chunks into the db. We are skipping inserting repeating chunks and inserting only one time, but we need to figure out a way.

@Harin329 @cachho: good work on this. Merged and closed.


update current workflows

Updating workflows in order to: Separate PR branch image build from tests (to skip asset compilation ~ 9min). Currently doing it in pg12 tests.
This comes together with Terraform changes to update the existing Cloud Build triggers: https://github.com/CartoDB/infrastructure-as-code/pull/104
I'll apply TF changes just before merging

:robot: please make sure all the checks pass before merging @ibrahimmenem @alberhander


pull request for e2e test at 11/17/2016 05:26:06

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

optest/docs/updated_at.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


[SPARK-48121][K8S] Promote KubernetesDriverConf to DeveloperApi

What changes were proposed in this pull request?

This PR aims to promote KubernetesDriverConf to DeveloperApi
Why are the changes needed?

Since Apache Spark Kubernetes Operator requires this, we had better maintain it as a developer API officially from Apache Spark 4.0.0.
https://github.com/apache/spark-kubernetes-operator/pull/10
Does this PR introduce any user-facing change?

No
How was this patch tested?

Pass the CIs
Was this patch authored or co-authored using generative AI tooling?

No

One more thing. If you have some time, please review the following PR on Apache Spark K8s Operator repository.

https://github.com/apache/spark-kubernetes-operator/pull/11

Merged to master for Apache Spark 4.0.0-preview.
Thank you, @jiangzho .


Missing VERSION in MANIFEST.in

Leads to broken installation from PyPI.

Closed in https://github.com/benoitbryon/psykorebase/commit/95bfb87a723e07dbae0868f32607ae7ff511587a

Too fast :)


Remove Imports System, part 2

Related to: https://github.com/dotnet/samples/pull/1195
Same regex is used on these directories:

snippets/csharp
snippets/xml
snippets/visualbasic/api
snippets/visualbasic/how-to
snippets/visualbasic/System.DateTime
snippets/visualbasic/VS_Snippets_ADO.NET

@rpetrusha , I was wondering if all of the namespaces in the following image are imported by default ?

so, I may try to remove all of them too.

I think that there's a difference between Visual Studio and the command line, and we've typically written Visual Basic console applications so that they can be compiled from the command line. I'd be inclined to leave in all Imports statements other than for System and Microsoft.VisualBasic.


Can't compile

I  get the code of cdt1.4 from github.com, and I execute build.sh， it will create these errors. What's matter with it ? OS centos7

Fuck, nobody give response.


[Feature] Missing field from Orders

Is there an existing feature request for this?

[X] I have searched the existing issues

Describe the Feature
Hi,
First off, thank you for creating this package!  It's made bringing Shopify data into our data warehouse so much easier than I was expecting.
However, I've encountered a small issue.  There is a status tied to orders that shows if an order is open, archived or canceled.  It doesn't appear in the dataset I'm getting from the package and is causing some issues with reconciling reporting with what is available in the Shopify front-end.  I can't find any way to identify a manually archived order without this status field.
I'm wondering if the field can be added?
Describe alternatives you've considered
I'm pretty new to using dbt, so I'm not fully au fait with the process of altering a package for my own use.  I'm more than willing to make the change if you guys are able to provide assistance.
Are you interested in contributing this feature?

[ ] Yes.
[X] Yes, but I will need assistance and will schedule time during your office hours for guidance.
[ ] No.

Anything else?
Shopify's documentation in the field in question:  https://help.shopify.com/en/manual/orders/order-status

hey @nmcge thanks for the message!
You're right that there doesn't exist an order status field in our package. However I checked our connector ERD and looks like it doesn't exist at the source to begin with neither 🤔 I do though see a fulfillment_status, would that suffice?
In the meantime, you can pass this field through using the passthrough feature we have enabled in this package, see the guide in our readme linked below. You'll need to click into the collapsed section #6.
https://github.com/fivetran/dbt_shopify/blob/main/README.md#passing-through-additional-fields

Hi Reneeli, thanks for the response.  Unfortunately, while fulfillment_status is useful, order_status has a seperate use case, and we definitely needed.
I hadn't seen the custom field section in the readme!  Thanks for pointing it out to me, I'll see how I get on using that.
Cheers,
Neill.

Gotcha, thanks! Yeah, it doesn't look like status is a field in the order table that our connector syncs, which means this goes beyond our package. In this case, I would open up a ticket with our support team to address this with the right department!
https://support.fivetran.com/hc/en-us

Will be closing this out since this needs to be addressed at the connector level.


Add a license expression validator to LicenseExpressionParser and the command line tools

Requested by David Wheeler for the web validation project as a feature for the online tool.
To support this, we can add a method "validate" to the class LicenseExpressionParser which would return a string with any validation error message or return null if there are no validation errors.
We could add a new command to the command line tool "VerifyLicenseExpression" which would take a string as a parameter and return back any validation errors or "VALID" if correct.
Note that you can accomplish this today by calling the parse method in the LicenseExpressionParser.  If there is an invalid expression, an exception will be thrown with the exception method describing the validation error.

@goneall you could also consider using https://github.com/nexB/license-expression/ that does a more extensive validation. It should not be too difficult to package this as a Jython jar for Java.


feat: Cache CircleCI dependencies

Adds support for caching dependencies.

:tada: This PR is included in version 1.0.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Android Compilation Failed with 1.6.0

Compilation error on Android after upgrading from 1.5.4 to 1.6.0. Downgrading to 1.5.4 solves the issue.
We have a setup with Reanimated 2 and followed the instructions in the guide (don't seem to have changed for this release).
Have tried adding implementation project(':react-native-mmkv') to the gradle file as in the example app, to no avail.
  IDEs:
    Android Studio: 2020.3 AI-203.7717.56.2031.7784292
    Xcode: 13.2.1/13C100 - /usr/bin/xcodebuild
  Languages:
    Java: 11.0.13 - /Users/XXX/.sdkman/candidates/java/current/bin/javac
  npmPackages:
    @react-native-community/cli: ^6.1.0 => 6.3.1
    react: ^17.0.2 => 17.0.2
    react-native: ^0.67.0-rc.6 => 0.67.0-rc.6

        buildToolsVersion = "30.0.2"
        minSdkVersion = 21
        compileSdkVersion = 31
        targetSdkVersion = 30

/XXX/app/src/main/java/com/getpaired/app/PairedJSIPackage.java:7: error: package com.reactnativemmkv does not exist
import com.reactnativemmkv.MmkvModule;
                          ^
/XXX/android/app/build/generated/rncli/src/main/java/com/facebook/react/PackageList.java:91: error: package com.reactnativemmkv does not exist
import com.reactnativemmkv.MmkvPackage;
                          ^
/XXX/android/app/src/main/java/com/getpaired/app/PairedJSIPackage.java:15: error: cannot find symbol
        MmkvModule.install(jsContext, reactApplicationContext.getFilesDir().getAbsolutePath() + "/mmkv");
        ^
  symbol:   variable MmkvModule
  location: class PairedJSIPackage
/XXX/android/app/build/generated/rncli/src/main/java/com/facebook/react/PackageList.java:203: error: cannot find symbol
      new MmkvPackage(),
          ^
  symbol:   class MmkvPackage
  location: class PackageList

Hey Diego!
Hmm, that kinda looks like a cache issue though?
Did you try:
./gradlew clean
./gradlew assembleDebug

?
Also, check if node_modules/react-native-mmkv/android exists and has all of the source in there

Also run npx react-native config to see if react-native-mmkv is correctly detected to be autolinkable

I have tried to clean and assemble in different flavours but no luck.
"react-native-mmkv": {
      "root": "/Users/user/Code/GitHub/app/node_modules/react-native-mmkv",
      "name": "react-native-mmkv",
      "platforms": {
        "ios": {
          "sourceDir": "/Users/user/Code/GitHub/app/node_modules/react-native-mmkv/ios",
          "folder": "/Users/user/Code/GitHub/app/node_modules/react-native-mmkv",
          "pbxprojPath": "/Users/user/Code/GitHub/app/node_modules/react-native-mmkv/ios/Mmkv.xcodeproj/project.pbxproj",
          "podfile": null,
          "podspecPath": "/Users/user/Code/GitHub/app/node_modules/react-native-mmkv/react-native-mmkv.podspec",
          "projectPath": "/Users/user/Code/GitHub/app/node_modules/react-native-mmkv/ios/Mmkv.xcodeproj",
          "projectName": "Mmkv.xcodeproj",
          "libraryFolder": "Libraries",
          "sharedLibraries": [],
          "plist": [],
          "scriptPhases": [],
          "configurations": []
        },
        "android": {
          "sourceDir": "/Users/user/Code/GitHub/app/node_modules/react-native-mmkv/android",
          "folder": "/Users/user/Code/GitHub/app/node_modules/react-native-mmkv",
          "packageImportPath": "import com.reactnativemmkv.MmkvPackage;",
          "packageInstance": "new MmkvPackage()",
          "buildTypes": []
        }
      },
      "assets": [],
      "hooks": {},
      "params": []
    },

The code is all there in node_modules:
ls /Users/user/Code/GitHub/app/node_modules/react-native-mmkv/android
CMakeLists.txt    build.gradle      gradle.properties src

ls /Users/user/Code/GitHub/app/node_modules/react-native-mmkv/android/src/main/java/com/reactnativemmkv
MmkvModule.java        MmkvModulePackage.java MmkvPackage.java

is it because jcenter stopped operation and react-native-mmkv still uses jcenter??

Hey! Can you check if #273 solves the issue for you? Remember to do a clean and rebuild.

works fine now, thanks


[Bug]: interference with search function

Bug Description
Thank you for making this very useful plugin!
I just encountered a bug that was quite confusing to pin down. In short: the plugin interferes with typing inside of text boxes other than the main editor one
Hope this report helps to make the plugin even better!
Relevant Screenshot
No response
To Reproduce

set smarter quotation mark to the keys you use for the normal quotation mark (Shift 2 on my German keyboard)
try searching for "foo" in either current file search or global search
quotation marks will go inside your opened document, not into the search bar, as expected

Obsidian Version
0.13.23
Which editor are you using?

[X] New Editor
[ ] Legacy Editor

In which mode(s) does the problem occur?

[X] Source (Edit)
[X] Live Preview

Checklist

[X] I updated to the latest version of the plugin.

puh that is tricky, since I do not know to tell via Obsidian API which element is focussed. it should be somewhere in the API though 🤔

What you could do is use an editorCheckCallback and check whether editor.hasFocus() returns true. https://github.com/obsidianmd/obsidian-api/blob/c01fc3074deeb3dfc6ee02546d113b448735b294/obsidian.d.ts#L796

Btw, the view (the second argument the editorCallback has) provides the current TFile: view.file (Example)
https://github.com/obsidianmd/obsidian-api/blob/c01fc3074deeb3dfc6ee02546d113b448735b294/obsidian.d.ts#L1890
https://github.com/obsidianmd/obsidian-api/blob/c01fc3074deeb3dfc6ee02546d113b448735b294/obsidian.d.ts#L1202
Then you don't need to do this https://github.com/chrisgrieser/obsidian-smarter-md-hotkeys/blob/0711fd7513d0d991a31d1ddb95cfdd20e9381994/main.ts#L44

But then also, smart typography already handles this very well, so I'm not sure whether this feature is needed in this plugin.


Help, cant install

Hi,
I followed the instructions for the installation and I can't get it to work.
Someone could tell me if you have the same problem or tell me what to do to make it work.
Thank you,
Dan

Hello,
could you provide more details? Can you report what is the error you see? What is your configuration?
Thank you,
Giuliano


feat: Add _tag and _old,_new grouping to extr serializer

extr serializer changes

Add support for _tag and tags grouping.
Add support for _old,_new grouping IDs

I had already pushed my changes before dealing with Venu's comments.  I'll go ahead and push those corrections directly into extr-1.21 since this Pull Request is already closed.


Working with Tableview

I have tried it with the controller where it is below a table view. Upon showing keyboard it pushes the table view behind the navbar by some offset and you cannot scroll to that area.

You should have mentioned what fixed it for you :)


Windows 8.1 Store apps: Contents of the package manifest

Read https://msdn.microsoft.com/en-us/library/hh924767.aspx?f=255&MSPPError=-2147217396.

Set it like this in package.appxmanifest:
<Identity Name="SuriyaaKudo.SInterEdgeBrowser" Version="<IP_ADDRESS>" Publisher="CN=Suriyaa Kudo" />


[BUG] react-scripts v2 does not support npm i react-app-rewired --save-dev

I am doing in a new CRA app:
npm install react-app-rewired --save-dev

I have:
npm WARN<EMAIL_ADDRESS>requires a peer of<EMAIL_ADDRESS>but none is installed. You must install peer dependencies yourself.

hi, could you share how you fix this issue? thanks a lot

Sorry I am not sure because I don't remember. I think I did a mistake in my own installation and that's why the error was poping up.

It is a warning, not an error. If you have a version of react-scripts installed (or are using the --scripts-version to set the scripts to a different package like react-scripts-ts) it will still work.
It is because a new cra project uses react-scripts 2.x, which does not satisfy an npm peer dependency for >= 1.0.14 but < 2.0.0.
react-app-rewired is not being updated to cra 2.x. You can read about why in the 2.0 Discussion thread. The core functionality in react-app-rewired works for cra 2.x, but many of the existing rewires were written for a previous version of Webpack, are no longer maintained by their authors, and do not work correctly with cra 2.x.

@alvisyoung

It is a warning, not an error. If you have a version of react-scripts installed (or are using the --scripts-version to set the scripts to a different package like react-scripts-ts) it will still work despite the warning.
It is because a new cra project uses react-scripts 2.x, which does not satisfy an npm peer dependency for >= 1.0.14 but < 2.0.0.
react-app-rewired is not being updated to cra 2.x. You can read about why in the 2.0 Discussion thread. The core functionality in react-app-rewired works for cra 2.x, but many of the existing rewires were written for a previous version of Webpack, are no longer maintained by their authors, and do not work correctly with cra 2.x.

@dawnmist
I think my problem is I have no react-scripts installed, could you guide me how to install it? thanks

@alvisyoung If you used create-react-app to create your project, CRA will have added react-scripts (or a version of it depending on how you ran the create-react-app function) to your project automatically.
You can check if it is missing by reading the dependencies section of your project's package.json file - it should already be listed in that section. yarn add react-scripts or npm install react-scripts will install it if it is missing.
This warning message shouldn't be doing anything other than warning you that the peer dependency is not being met exactly. You should still be able to use yarn start/yarn build without issues. If this is not the case, your actual issue is likely to be something different.


Update information about the field "ports".md

Cxs are using the example on this article to deploy self managed Prometheus.
This YAML content is being used to create a PLS for Prometheus and other services running on AKS cluster and connected to Managed Grafana using Managed Private Endpoint. For example, the service "Loki" or some databases (like MySQL or PostgreSQL).
Bellow a test using all the configuration suggested in the doc:
Add a private link service to the Prometheus server
If i use this YAML file suggested, will be created a PLS with this structure: "external port + protocol + target port".

But, if you see the "selector", the service used "prometheus-kube-prometheus-prometheus" uses the configuration "external port + protocol + port name".

This is causing the communication failure when we create the managed private endpoint.

If we change the private link service to the same structure as the selector used:

It works!

The same for Loki service.
Fail if:

When i changed the PLS YAML:

It works!

@weng5e

Can you review this PR?
IMPORTANT: When this content is ready to merge, you must add #sign-off in a comment or the approval may get overlooked.

#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

Configuration is correct


feat(deploy): installed and enabled keel.sh.

Issue link
closes: #120
What does this PR do?

added keel installation manifest
updated Django application manifests with adding keel's annotations

(Optional) Additional Contexts or Justifications
Since we have already applied updated manifest to install keel.sh before merging this PR, we can do e2e testing with merging another PR, such as #203, where we would update images with push commit to main.
So we will merge this PR after confirmation that OCI image would be updated by commit push-triggered.

Summary by CodeRabbit

New Features

Introduced a comprehensive Kubernetes configuration for deploying the Keel application, including namespace, service account, role permissions, and deployment specifications.
Enhanced the Django application's deployment with annotations for continuous delivery integration, enabling a pull-based deployment strategy.

Bug Fixes

Removed outdated TODO comment regarding image tag replacement to promote a more stable image versioning strategy.

24-07-23 11:10:34 manifests/controllers [feat/120/keel] % kubectl apply -f keel.yaml
namespace/keel created
serviceaccount/keel created
clusterrole.rbac.authorization.k8s.io/keel created
clusterrolebinding.rbac.authorization.k8s.io/keel created
service/keel created
deployment.apps/keel created

24-07-23 11:18:10 manifests/controllers [feat/120/keel] % kubectl -n keel get all -o wide
NAME                       READY   STATUS    RESTARTS   AGE     IP          NODE                                         NOMINATED NODE   READINESS GATES
pod/keel-69896cc56-m6m29   1/1     Running   0          7m28s   <IP_ADDRESS>   gke-playgrounds-default-pool-dfe67b64-kre8   <none>           <none>

NAME           TYPE       CLUSTER-IP     EXTERNAL-IP   PORT(S)          AGE     SELECTOR
service/keel   NodePort   <IP_ADDRESS>   <none>        9300:30930/TCP   7m30s   app=keel

NAME                   READY   UP-TO-DATE   AVAILABLE   AGE     CONTAINERS   IMAGES               SELECTOR
deployment.apps/keel   1/1     1            1           7m29s   keel         keelhq/keel:0.19.1   app=keel,release=keel

NAME                             DESIRED   CURRENT   READY   AGE     CONTAINERS   IMAGES               SELECTOR
replicaset.apps/keel-69896cc56   1         1         1       7m29s   keel         keelhq/keel:0.19.1   app=keel,pod-template-hash=69896cc56,release=keel

@coderabbitai review

Applied metadata to application container, deployment/django.
# before
24-08-03 12:35:02 git/bennu-official [main] % kubectl -n bennuhp get deployments.apps django -o yaml
apiVersion: apps/v1
kind: Deployment
metadata:
  annotations:
    deployment.kubernetes.io/revision: "3"
    kubectl.kubernetes.io/last-applied-configuration: |
    # (...)
  creationTimestamp: "2024-03-07T14:08:04Z"
  generation: 6
# (...)

# apply to metadata for being managed by keel.sh
24-08-03 12:35:36 git/bennu-official [main] % kubectl apply -f manifests/django.yaml
deployment.apps/django configured
service/django unchanged

# after: deployment's generation was changed to 7
24-08-03 12:36:06 git/bennu-official [main] % kubectl -n bennuhp get deployment django -o yaml
apiVersion: apps/v1
kind: Deployment
metadata:
  annotations:
    deployment.kubernetes.io/revision: "3"
    keel.sh/policy: glob:*
    keel.sh/pollSchedule: '@every 1m'
    keel.sh/trigger: poll
    kubectl.kubernetes.io/last-applied-configuration: |
    # (...)
  generation: 7
  # (...)


add IsRunning method

The Cron.running field is private.
So when we want to check cron is running, we need create other flag and management it.
It's not simple.
This change add getter for Cron.running field.

Hi, thanks for the contribution!  This is not correctly synchronized though.  For example, if you're checking if cron is running, that implies that some other goroutine may have stopped it.  As currently implemented, it's a data race for one goroutine to Stop() the cron and another to call IsRunning().

Oh... You're right !!
I close this PR, thanks to your review.


Discuss: How to handle shared files with GDA

Currently there are a number of "config" files that GDA and artemis both need:

The lookup tables to detector distance to beam x/y (see https://github.com/DiamondLightSource/python-artemis/issues/29)
A lot of the nexus metadata that is hardcoded in https://github.com/DiamondLightSource/python-artemis/pull/52 is in json files in /i03-config/etc
Other stuff I've missed?

We should have a holistic discussion about how artemis should get this data, some potential options:

GDA passes the data to Artemis
GDA passes paths to Artemis of where the data is - actual files are still stored in GDA
GDA and Artemis both pull the data from a particular central place e.g. git repo or redis
Artemis also has the values in a file in this repo or hardcoded in this repo

Acceptance Criteria

We decide which to do and document it here, along with why

My two cents:

This makes Artemis fiddly to run standalone
Slightly less fiddly to run Artemis standalone but would still be annoying
This is my favorite option, will involve modifications to GDA though so holds some risk
This means if we have to change any of these parameters we would have to do so twice

FYI, I was pointed to ADRs as a lightweight but easily browsable way to document decisions made on a project, although I guess GitHub issues are even more lightweight.
Anyway, here's how I store them for ophyd.v2:
https://github.com/dls-controls/ophyd/tree/master/docs/explanations/decisions
And here's how they look in the docs:
https://dls-controls.github.io/ophyd/master/explanations/decisions.html
I went with RST to fit in with the sphinx project, but the original authors of ADRs used markdown which fits better with what you're doing.

Adding my two cents.
I am not a fan of the first two options, if you want to run Artemis separated from GDA. And considering we're mostly talking of hardcoded values, it just seems like you'd be adding an avoidable additional layer to the code.
So far I've been saving the values I need for Nexus writing in a local file, but I recognise it might not be the best option. It works well enough and it's convenient to have everything in the same place, although as @DominicOram mentioned, that means having to make changes twice if there's something to be fixed. It's not a huge issue, just an annoying one.
In theory, I do like the idea of pulling these config files from a central location for both GDA and Artemis. However, my understanding of GDA is probably too limited to have a clear idea of if and how this could work.

This is getting more important now that beamline parameters are being required for setting up snapshots, see https://github.com/DiamondLightSource/python-artemis/pull/121/

@callumforrester is there any discussion of how this will be handled in the new architecture in the future?

In general we want to be less reliant on files in the future where possible as they don't make for a great API, so I'm not a fan of 2 or 4. This is especially important in a multi-application land (e.g. Artemis + GDA). Agree with @noemifrisina on 1 and 2 so I would generally favour 3 and 5, particularly 3. Having a single source of truth should lead to a simple codebase and commissioning procedure.


Adjust colors based on window focus, like native apps

This will involve either using the desktop_lifecycle plugin or writing our own.
I've attempted this with desktop_lifecycle and it works quite well.
We'll need to add a dynamic color to MacosColors to represent inactive colors for the sidebar and toolbar (both use the same), and a style in MacosTypography that colors inactive text in the sidebar and toolbar. We'll also need inactive icon colors, and a utility to darken the primary color where appropriate.
We will need to determine whether to check if the window is active in each widget that needs to be adjusted, or do it top-level (like in MacosApp) and propagate the result of the check through the widget tree via MacosThemeData or another InheritedWidget.

macos_window_utils’s NSWindowDelegate can also be used to detect window focus events and since we’ll already be depending on that, it might be a better idea to use that, instead (assuming cross-platform support isn’t targetted, of course).

It works with the system's accent color:

It works with widgets that have the accent color already implemented. Currently, that only includes the buttons and the sidebar items, once #484 is merged.


fix: updated instrumentation to work in versions >= 13.3.1 as the methods we try to hook no longer have setters

Proposed Release Notes

Updated instrumentation to work in versions >= 13.3.1 as the methods we try to hook no longer have setters

Links
Closes #120
Details
renderHTML was on Server.prototype from the start and no need to instrument a different function that is called from renderHTML and runMiddleware has existed on Server.prototype since it became stable in 12.2.0.

@bizob2828 Did ./lib/context need to be deleted? It still seems to be referenced.


[SPARK-9140][MLlib] Replace TimeTracker by Stopwatch

jira: https://issues.apache.org/jira/browse/SPARK-9140
We can replace TImeTracker in tree implementations by Stopwatch. The initial PR could use local stopwatches only.
With the current API of MultiStopwatch:

The typical invoking sequence is not reenterable (causes exception)

  multiTimer.addLocal("total")
  multiTimer("total").start()
  ...
  multiTimer("total").stop()

Maybe we can have a new API combining

  multiTimer.addLocal("total")
  multiTimer("total").start()

just for simplification.
next: Shall we keep TimeTracker ?

Merged build triggered.

Merged build started.

Test build #39431 has started for   PR 7871 at commit 60366ac.

Test build #39431 has finished for   PR 7871 at commit 60366ac.

This patch fails Scala style tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Merged build triggered.

Merged build started.

Test build #39433 has started for   PR 7871 at commit 40f3931.

Test build #39433 has finished for   PR 7871 at commit 40f3931.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

@hhbyyh Could you post the exception you saw?

Oh I should have made it more clear. An example:
  def run(): Unit ={
    val conf = new SparkConf().setMaster("local").setAppName("ss")
    val sc = new SparkContext(conf)
    val multiTimer = new MultiStopwatch(sc)
    for(i <- 0 to 2) {
      someFunction(multiTimer)
    }
  }

  def someFunction(multiTimer: MultiStopwatch): Unit ={
    multiTimer.addLocal("total")
    multiTimer("total").start()
    // ...
    multiTimer("total").stop()
  }

will throw Exception in thread "main" java.lang.IllegalArgumentException: requirement failed: Stopwatch with name total already exists.
This is probably by design, yet it's not quite handy. Since users will have to:

avoid passing MultiStopwatch around as a parameter
or avoid invoking someFunction multiple times.

@hhbyyh thanks for the pull request. I'm going through a list of pull requests to cut them down since the sheer number is breaking some of the tooling we have. Due to lack of activity on this pull request, I'm going to push a commit to close it. Feel free to reopen it or create a new one.

@hhbyyh What is your opinion about adding

@hhbyyh What is your opinion about renaming addLocal to addOrGetLocal which returns a local stopwatch if it already exists? That should solve your concerns.


stack-clients flooding log files

A logging standard using log4j was previously set up - https://github.com/cambridge-cares/TheWorldAvatar/wiki/Logging.
Currently the stack clients uses slf4j and I'm using the logging framework (log4j) in my code. I built my code with the production profile to suppress the DEBUG level logging messages, but it's not easy to suppress the logging from stack-clients due to it using slf4j, I believe.

Looks like switching to the latest parent pom solves this, no longer seeing DEBUG level logging messages, just many from Jena which is a separate issue


Long-running Select When Expanding Prefix

Symptom:
We recently upgraded to 0.29.5.
After logging into Nipap and trying to expand the Prefix (eg. X.72.128.0/19), Nipap blocks for a really long time.
On the host I can see a long running SELECT generated in the OS Process List. Automatically stopping and starting Postgres resolves this (obviously). We are currently looking to simulate the process in our staging environment and will update this issue as we go.
If we do need to expand the prefix, we search for it through the UI, and then expand (+) works.
The Impact:
Unable to large expand prefixes.

Can you please quantify how large is a large prefix? Is x.72.128.0/19 a reservation? How many children does it have?

@plajjan It is a reservation. In terms of children, 70 or so. There are about 500 assignments (interspersed with some reservations). Replicating this on Demo maybe slightly hard unless we could inject a similar tree structure via the DB. Hopefully our staging environment will be up soon.

Aloha
I've resolved this by performance tuning Postgres.
Two things were changed:

Shared Buffers - Increased this from 128MB to 4GB.
Work Mem - Increased this from 4MB to 20MB.


do not panic in Drop when stream is in an error state

fixes #432
This causes a panic for us when a stream errors (we pass in a reqwest stream): https://github.com/prefix-dev/pixi/issues/799

Because this repo is no longer maintained, I've replaced this PR with https://github.com/zip-rs/zip2/pull/48.


service: Add a README.md to nydus-service

Add a README.md to nydus-service crate.

Let's delay this PR to v2.3?

Let's delay this PR to v2.3?

Ok. that's fine.

Please also backport to stable/v2.2. Thanks ~~~~

Ok


Support for primary key

Support for defining custom primary key may be useful in some cases.
Currently phinx add ìd` column as auto increment primary key.
It should be possible to override this behavior, so we can create tables w/out primary key, w/out auto increment.

'id'=>false,'primary_key' => 'foo' does not work as expected.
it indeed creates primary key but the AUTO_INCRMENT is lost.
        $this->table('api_token', ['id' => false, 'primary_key' => ['apt_id']])
            ->addColumn('apt_id', 'integer', ['length' => 10, 'signed' => false])

this creates:

CREATE TABLE `api_token` (
  `apt_id` int(10) unsigned NOT NULL,
...
  PRIMARY KEY (`apt_id`),
) ENGINE=MyISAM DEFAULT CHARSET=utf8

but i need it to be:

CREATE TABLE `api_token` (
  `apt_id` int(10) unsigned NOT NULL AUTO_INCREMENT,
...
  PRIMARY KEY (`apt_id`),
) ENGINE=MyISAM DEFAULT CHARSET=utf8

so far i've solved the problem by finding primary key and adding identity flag to it so AUTO_INCREMENT would be added to DDL.

    public function change()
    {
        $table = $this->table('api_token', ['id' => false, 'primary_key' => 'apt_id'])
            ->addColumn('apt_id', 'integer', ['length' => 10, 'signed' => false]);
        $this->getPk($table)->setIdentity(true);
        $table->create();
    }

    /**
     * Get Primary Key column from Pending Table Operations.
     * Hack for AUTO_INCREMENT being lost when defining custom Primary Key column
     *
     * @link https://github.com/robmorgan/phinx/issues/28#issuecomment-298693426
     * @param Table $table
     * @return Table\Column
     */
    protected function getPk(Table $table)
    {
        $options = $table->getOptions();
        if (!isset($options['primary_key'])) {
            throw new LogicException('primary_key column required');
        }

        $name = $options['primary_key'];
        $columns = $table->getPendingColumns();
        foreach ($columns as $column) {
            if ($column->getName() == $name) {
                return $column;
            }
        }
        throw new LogicException('primary_key column not found');
    }

$table->getPendingColumns() is gone, yet there's still no way to define custom primary key and have auto increment on it.
i.e the problem reported in this note: https://github.com/cakephp/phinx/issues/28#issuecomment-298693426

I believe, you'd want to do something like:
$this->table('api_token', ['id' => 'apt_id', 'signed' => false])->create();

As a string for the id key will cause the adapter to fall into this branch of code:
https://github.com/cakephp/phinx/blob/76c96c851b737f93598d7ae7765a5cd2cc99ae7a/src/Phinx/Db/Adapter/MysqlAdapter.php#L232-L242
which should give you a custom named auto increment primary key column.

currently i kept the previous hack, but needed to hack even more because the actions is not accessible.
https://github.com/eventum/eventum/pull/388/commits/eb121e3d8f37cd745a613782f32b663bd6354fba
i'll check your solution next.

okay. it works, but result is not identical
CREATE TABLE `api_token` (
  `apt_id` int(11) unsigned NOT NULL AUTO_INCREMENT,

the int(11) is incorrect, should be int(10), but it's kind of same to mysql anyway.

You can only specify the signed key there. You should be able to do this I believe to get what you want:
$this->table('api_token', ['id' => false, 'primary_key' => 'apt_id'])
    ->addColumn('apt_id', 'integer', ['limit' => 10, 'signed' => false, 'identity' => true])
    ->create();

@MasterOdin indeed. that works now as the changes are batched together. thanks!

i think this can be closed. at least problem i mentioned in comments is solved.


Added Blazorise components library

Hi.
I try to keep an alphabetical order, could you put your link between this two libraries 'Blazor Hotkeys' and 'Blazor LoadingBar' ?
Thank's!

(I could do it myself but you won't be considered as a contributor of this repository.)

done


25.0 release notes: batch 1

First batch of draft release notes for 25.0 for review.
This PR has:

[x] been self-reviewed.

Superseded by https://github.com/apache/druid/pull/13357 - see this PR for release notes review.


getting segfault while running train_cifar10.py program in example directory

I am trying to run this command:
python example/image-classification/train_cifar10.py
And getting the segfault. It is very consistent.
INFO:root:Epoch[0] Batch [20]	Speed: 18.95 samples/sec	accuracy=0.164807
INFO:root:Epoch[0] Batch [40]	Speed: 20.34 samples/sec	accuracy=0.246875
INFO:root:Epoch[0] Batch [60]	Speed: 21.66 samples/sec	accuracy=0.308984
INFO:root:Epoch[0] Batch [80]	Speed: 22.15 samples/sec	accuracy=0.328125
INFO:root:Epoch[0] Batch [100]	Speed: 22.38 samples/sec	accuracy=0.362500
INFO:root:Epoch[0] Batch [120]	Speed: 21.52 samples/sec	accuracy=0.378125
INFO:root:Epoch[0] Batch [140]	Speed: 22.96 samples/sec	accuracy=0.417969
INFO:root:Epoch[0] Batch [160]	Speed: 20.04 samples/sec	accuracy=0.426563
INFO:root:Epoch[0] Batch [180]	Speed: 18.58 samples/sec	accuracy=0.430078
INFO:root:Epoch[0] Batch [200]	Speed: 21.39 samples/sec	accuracy=0.443750
INFO:root:Epoch[0] Batch [220]	Speed: 17.69 samples/sec	accuracy=0.469531
INFO:root:Epoch[0] Batch [240]	Speed: 18.59 samples/sec	accuracy=0.469141
INFO:root:Epoch[0] Batch [260]	Speed: 21.68 samples/sec	accuracy=0.470313
INFO:root:Epoch[0] Batch [280]	Speed: 21.05 samples/sec	accuracy=0.487891
INFO:root:Epoch[0] Batch [300]	Speed: 22.30 samples/sec	accuracy=0.503125
INFO:root:Epoch[0] Batch [320]	Speed: 20.98 samples/sec	accuracy=0.534766
INFO:root:Epoch[0] Batch [340]	Speed: 15.53 samples/sec	accuracy=0.526172
INFO:root:Epoch[0] Batch [360]	Speed: 13.88 samples/sec	accuracy=0.528516
Traceback (most recent call last):
  File "example/image-classification/train_cifar10.py", line 79, in <module>
    fit.fit(args, sym, data.get_rec_iter)
  File "/Users/vikumar/incubator-mxnet/example/image-classification/common/fit.py", line 333, in fit
    monitor=monitor)
  File "/Users/vikumar/incubator-mxnet/python/mxnet/module/base_module.py", line 563, in fit
    next_data_batch = next(data_iter)
  File "/Users/vikumar/incubator-mxnet/python/mxnet/io/io.py", line 228, in __next__
    return self.next()
  File "/Users/vikumar/incubator-mxnet/python/mxnet/io/io.py", line 840, in next
    check_call(_LIB.MXDataIterNext(self.handle, ctypes.byref(next_res)))
  File "/Users/vikumar/incubator-mxnet/python/mxnet/base.py", line 252, in check_call
    raise MXNetError(py_str(_LIB.MXGetLastError()))
mxnet.base.MXNetError: [09:58:31] src/io/recordio_split.cc:29: Check failed: (reinterpret_cast<size_t>(end) & 3UL) == 0U (1 vs. 0)

Stack trace returned 10 entries:
[bt] (0) 0   libmxnet.so                         0x000000010ae2cf30 dmlc::StackTrace() + 272
[bt] (1) 1   libmxnet.so                         0x000000010ae2ccdf dmlc::LogMessageFatal::~LogMessageFatal() + 47
[bt] (2) 2   libmxnet.so                         0x000000010c68a01c dmlc::io::RecordIOSplitter::FindLastRecordBegin(char const*, char const*) + 444
[bt] (3) 3   libmxnet.so                         0x000000010c68d10c dmlc::io::InputSplitBase::ReadChunk(void*, unsigned long*) + 284
[bt] (4) 4   libmxnet.so                         0x000000010c68d230 dmlc::io::InputSplitBase::Chunk::Load(dmlc::io::InputSplitBase*, unsigned long) + 144
[bt] (5) 5   libmxnet.so                         0x000000010c6a0b8f dmlc::ThreadedIter<dmlc::io::InputSplitBase::Chunk>::Init(std::__1::function<bool (dmlc::io::InputSplitBase::Chunk**)>, std::__1::function<void ()>)::'lambda'()::operator()() const + 895
[bt] (6) 6   libmxnet.so                         0x000000010c6a071d void* std::__1::__thread_proxy<std::__1::tuple<std::__1::unique_ptr<std::__1::__thread_struct, std::__1::default_delete<std::__1::__thread_struct> >, dmlc::ThreadedIter<dmlc::io::InputSplitBase::Chunk>::Init(std::__1::function<bool (dmlc::io::InputSplitBase::Chunk**)>, std::__1::function<void ()>)::'lambda'()> >(void*) + 45
[bt] (7) 7   libsystem_pthread.dylib             0x00007fff903c293b _pthread_body + 180
[bt] (8) 8   libsystem_pthread.dylib             0x00007fff903c2887 _pthread_body + 0
[bt] (9) 9   libsystem_pthread.dylib             0x00007fff903c208d thread_start + 13

Environment info
build command -  make -j8 USE_DIST_KVSTORE=1
os: mac
What to do:
1. o/p of diagnose script:
88e9fe53272d:incubator-mxnet vikumar$ python /tmp/lk.py
----------Python Info----------
Version      : 3.6.5
Compiler     : GCC 4.2.1 Compatible Clang 4.0.1 (tags/RELEASE_401/final)
Build        : ('default', 'Apr 26 2018 08:42:37')
Arch         : ('64bit', '')
------------Pip Info-----------
Version      : 10.0.1
Directory    : /Users/vikumar/anaconda3/lib/python3.6/site-packages/pip
----------MXNet Info-----------
/Users/vikumar/anaconda3/lib/python3.6/site-packages/h5py/__init__.py:36: FutureWarning: Conversion of the second argument of issubdtype from `float` to `np.floating` is deprecated. In future, it will be treated as `np.float64 == np.dtype(float).type`.
  from ._conv import register_converters as _register_converters
objc[59758]: Class CaptureDelegate is implemented in both /usr/local/opt/opencv/lib/libopencv_videoio.3.4.dylib (0x10ada5938) and /Users/vikumar/anaconda3/lib/python3.6/site-packages/cv2/cv2.cpython-36m-darwin.so (0x1a17065ce0). One of the two will be used. Which one is undefined.
Version      : 1.3.0
Directory    : /Users/vikumar/incubator-mxnet/python/mxnet
Hashtag not found. Not installed from pre-built package.
----------System Info----------
Platform     : Darwin-16.7.0-x86_64-i386-64bit
system       : Darwin
node         : 88e9fe53272d.ant.amazon.com
release      : 16.7.0
version      : Darwin Kernel Version 16.7.0: Thu Jun 21 20:07:39 PDT 2018; root:xnu-3789.73.14~1/RELEASE_X86_64
----------Hardware Info----------
machine      : x86_64
processor    : i386
b'machdep.cpu.extfeatures: SYSCALL XD 1GBPAGE EM64T LAHF LZCNT PREFETCHW RDTSCP TSCI'
b'machdep.cpu.leaf7_features: SMEP ERMS RDWRFSGS TSC_THREAD_OFFSET BMI1 HLE AVX2 BMI2 INVPCID RTM SMAP RDSEED ADX IPT SGX FPU_CSDS MPX CLFSOPT'
b'machdep.cpu.features: FPU VME DE PSE TSC MSR PAE MCE CX8 APIC SEP MTRR PGE MCA CMOV PAT PSE36 CLFSH DS ACPI MMX FXSR SSE SSE2 SS HTT TM PBE SSE3 PCLMULQDQ DTES64 MON DSCPL VMX SMX EST TM2 SSSE3 FMA CX16 TPR PDCM SSE4.1 SSE4.2 x2APIC MOVBE POPCNT AES PCID XSAVE OSXSAVE SEGLIM64 TSCTMR AVX1.0 RDRAND F16C'
b'machdep.cpu.brand_string: Intel(R) Core(TM) i7-7660U CPU @ 2.50GHz'
----------Network Test----------
Setting timeout: 10
Timing for MXNet: https://github.com/apache/incubator-mxnet, DNS: 0.0115 sec, LOAD: 0.5897 sec.
Timing for Gluon Tutorial(en): http://gluon.mxnet.io, DNS: 0.0183 sec, LOAD: 0.2578 sec.
Timing for Gluon Tutorial(cn): https://zh.gluon.ai, DNS: 0.0227 sec, LOAD: 0.1714 sec.
Timing for FashionMNIST: https://apache-mxnet.s3-accelerate.dualstack.amazonaws.com/gluon/dataset/fashion-mnist/train-labels-idx1-ubyte.gz, DNS: 0.0186 sec, LOAD: 0.2626 sec.
Timing for PYPI: https://pypi.python.org/pypi/pip, DNS: 0.0141 sec, LOAD: 0.3084 sec.
Timing for Conda: https://repo.continuum.io/pkgs/free/, DNS: 0.0148 sec, LOAD: 0.0534 sec.

I am trying to build and repro on linux machine.

Thanks for reporting this issue @Vikas89
@mxnet-label-bot [Example, Bug]

I think there was a fix made in relevant area of code: https://github.com/dmlc/dmlc-core/commit/e3377de933d3e069635150fb330ce6cc33b57950#diff-855ba648d1f4003608aa37ba3d060043
I will retry this on latest code and check if I can reproduce this again. I will keep this thread updated.

I am not seeing this issue now, closing this

I encountered the issue again, sorry for the confusion.
If I revert the changes made in this commit in dmlc_core submodule, the issue is gone
https://github.com/dmlc/dmlc-core/commit/e3377de933d3e069635150fb330ce6cc33b57950#diff-855ba648d1f4003608aa37ba3d060043
My changes in dmlc-core/src/io/input_split_base.cc which fixes the problem
+  if (nread != max_size) {
+    *size = nread;
+    return true;
+  } else {
+    const char *bptr = reinterpret_cast<const char*>(buf);
+    // return the last position where a record starts
+    const char *bend = this->FindLastRecordBegin(bptr, bptr + max_size);
+    *size = bend - bptr;
+    overflow_.resize(max_size - *size);
+    if (overflow_.length() != 0) {
+      std::memcpy(BeginPtr(overflow_), bend, overflow_.length());
+    }
+
+    return true;
+  }
+    /* COMMENTOUT
   if (nread == olen) {  // add extra newline to handle files with NOEOL
     char *bufptr = reinterpret_cast<char*>(buf);
     bufptr[nread] = '\n';
     nread++;
+    LOG(INFO) << " Added extra line to the file";
   }

   const char *bptr = reinterpret_cast<const char*>(buf);
@@ -241,6 +258,7 @@ bool InputSplitBase::ReadChunk(void *buf, size_t *size) {
     std::memcpy(BeginPtr(overflow_), bend, overflow_.length());
   }
   return true;
+  */

@Vikas89 I was not able to reproduce the bug until I checkout the latest master for dmlc-core. Which commit hash for dmlc-core were you using when running the example?

@Vikas89 @piyushghai I created a minimal reproduction of the bug:
#include <dmlc/io.h>
#include <rabit/rabit.h>
#include <string>
#include <utility>
#include <vector>

int main(int argc, char** argv) {
  rabit::Init(argc, argv);
  std::unique_ptr<dmlc::InputSplit> source(
    dmlc::InputSplit::Create("./cifar10_train.rec",
    rabit::GetRank(), rabit::GetWorldSize(), "recordio"));
  source->BeforeFirst();
  dmlc::InputSplit::Blob rec;
  size_t sum = 0;
  while (source->NextRecord(&rec)) {
    sum += rec.size;
  }
  rabit::Finalize();
  return 0;
}

It shows that the bug came into existence since  dmlc/dmlc-core#452 is merged. For a running example, see https://github.com/hcho3/mxnet-issue12800-repro.

Submitted dmlc/dmlc-core#471, along with a test case.

@hcho3 Is this still an issue or has been fixed after your PR?

This is fixed.


No more deprecated tests, more API Tests

Now with even more awesome!

Changes made! :boom:

i am adding a check to only update the name and email if it is not a masqueraded session. we already pull the existing user in if they have one so this should just make it work :likeaboss:

:boom: :like: a :boss:


pntr_draw_circle

This adds a filled-circle drawing function.

Yay! :red_circle:  Thanks so much :large_blue_circle:


Quality of life improvements to system tests

[x] This contribution adheres to CONTRIBUTING.md.

What does this Pull Request accomplish?

Deploy once during Loopback test class execution

This is the largest change and required resetting the Acyclic Tx channel values to work with one deployment
Use new testing VI calls in globalSetUp and setUp VIs to retain class data

Delete scripted system definition files after tests execute to clean up generated assets
Fix bug in Generate VS Channels Info.vi connector pane / VI icon
Use an enum as a required input for selecting label type in Generate VS Channels Info.vi

Update all sub VIs that call this VI to change the input to the enum

Use a config file to specify PXI slot number

Why should this Pull Request be merged?
This PR is a sizable collection of quality of life improvements for this repo's system tests.
The biggest visible changes are 1) shorter test times and 2) not leaving scripted assets on disk after test runs.
What testing has been done?
Ran the automated tests to see a ~70 second time reduction by not deploying multiple times for the main loopback tests.

VI Tester results after changes

VI Tester results before changes

[ ]  Remove the breakpoint in test Acyclic Loopback Selective Triggers.vi.

When I went to remove the breakpoint in the VI, I found that I could not open any of the modified test VIs due to a LabVIEW crash (Fatal Internal Error 0xE59037CA: ...). This reproduced on another dev machine as well, so I checked out the files from main, updated the string constant to an enum, and added the sub VI in the acyclic test VIs.