.NET Core tools version check in build.psm1 blocks the build

Condition in build.psm1 seems to be looking for exact match with "2.0.0", while the tools (installed by Start-PSBootstrap) are of "2.0.2". This blocks the build.
$dotnetCLIRequiredVersion = "2.0.0"
...
    # Verify if the dotnet in-use is the required version
    $dotnetCLIInstalledVersion = (dotnet --version)
    If ($dotnetCLIInstalledVersion -ne $dotnetCLIRequiredVersion) {
        Write-Warning @"
The currently installed .NET Command Line Tools is not the required version.
...

Expected behavior:
Build succeeds.
Actual behavior
Build stops at warning:

Steps to reproduce
git clone --recursive https://github.com/PowerShell/PowerShell.git
Import-Module ./build.psm1
Start-PSBootstrap
Start-PSBuild

Environment data
Name                           Value
----                           -----
PSVersion                      5.1.17025.1001
PSEdition                      Desktop
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0...}
BuildVersion                   10.0.17025.1001
CLRVersion                     4.0.30319.42000
WSManStackVersion              3.0
PSRemotingProtocolVersion      2.3
SerializationVersion           <IP_ADDRESS>

Do you have a global.json file in the root of the repo?  It's contents should specify that PowerShell currently uses the 2.0.0 version of the SDK.  The gist is that the presence of this file should cause dotnet --version to return 2.0.0 if that command is run within the repo dir structure.  From that code snippet, I can't tell which dir the command is run from.  I suspect the dir isn't being set to the repo path which would cause this problem.

PS C:\github\PowerShell> dir global.json

    Directory: C:\github\PowerShell

Mode                LastWriteTime         Length Name
----                -------------         ------ ----
-a----       10/27/2017   1:34 PM             47 global.json

PS C:\github\PowerShell> gc .\global.json
{
  "sdk": {
    "version": "2.0.0"
  }
}
PS C:\github\PowerShell> dotnet --version
2.0.2
PS C:\github\PowerShell>

Hmm, that is not what I see but I have both 2.0.0 and 2.0.2 installed.  Which versions do you have in your C:\Program Files\dotnet\sdk folder?

PS C:\github\PowerShell> dir "C:\Program Files\dotnet\sdk"

    Directory: C:\Program Files\dotnet\sdk

Mode                LastWriteTime         Length Name
----                -------------         ------ ----
d-----       10/11/2017   3:05 PM                2.0.2
d-----       10/27/2017   2:38 PM                NuGetFallbackFolder

PS C:\github\PowerShell>

Anything in the C:\Users\anmenaga\AppData\Local\Microsoft\dotnet\sdk folder?

PS C:\github\PowerShell> dir C:\Users\anmenaga\AppData\Local\Microsoft\dotnet\sdk

    Directory: C:\Users\anmenaga\AppData\Local\Microsoft\dotnet\sdk

Mode                LastWriteTime         Length Name
----                -------------         ------ ----
d-----       10/27/2017   1:36 PM                2.0.0
d-----       10/27/2017   1:45 PM                NuGetFallbackFolder

Hmm, I wonder why dotnet is not seeing the sdk under you app data dir.  As an experiment, would you be willing to install the .NET SDK from here, restart PowerShell and then re-run dotnet --version from the PowerShell repo folder.  Does that still report 2.0.2?

Can't we optimize the version check in build.psm1 to do ordinal version comparison after validating the major version of the dotnet CLI?
PowerShell seems to compile just fine with version 2.0.2

There's definitely an argument to be made to simply let global.json inform of dotnet of the desired version of the SDK and let dotnet determine compatibility.
That said, it seems like there is a bug in dotnet because on my system with both 2.0.0 and 2.0.2, dotnet --version reports 2.0.0 in the PowerShell repo.  Not sure why the OP isn't seeing the same thing given they also have both the 2.0.2 and 2.0.0  SDK installed.

We decided to use a fixed version after a number of compatibility problems.
We now expect 2.0.3 version with important patches.

Maybe related https://github.com/dotnet/cli/issues/6836

It appears that perhaps the PowerShell build is installing the .NET Core SDK into a place that isn't ideal.  https://github.com/dotnet/cli/issues/7928#issuecomment-340522972

'dotnet' does not consider versions that were installed to the user's AppData folder; this is by design.
"That will install .NET Core 2.0.0 into the user's AppData folder" - consider changing this installation location.

@anmenaga This answers the question as to why you're seeing this error.  Installing the .NET Core 2.0 SDK from https://www.microsoft.com/net/download/core will get you around this issue.
Question for @PowerShellTeam, why does the build system install into the user's AppData folder instead of the normal program files location?  Because of the need to elevate?  As it stands now, the global.json file apparently will not help unless the user has installed .NET Core SDK ahead of time.

Thanks @rkeithhill
An interesting observation...
On my machine "Program Files\dotnet" location (with version 2.0.2) was in %PATH% system-wide env var. Looks like it was added there when I recently installed Visual Studio 2017 (I've confirmed on a clean machine that VS2017 adds to the %PATH% system-wide env var).
When I changed %PATH% env var to have AppData|2.0.0 location instead - things started working again.

Should we document this and/or add a check in Start-PSBootStrap?

We use the dotnet-install.ps1 script from 'dotnet/cli' repo to install dotnet sdk, and it install dontet to AppData folder by default.

Just verified on an AppVeyor builder. The dotnet SDK installed at C:\Program Files\dotnet has the following versions installed. That's why global.json fixed the CI runs.
PS C:\Program Files\dotnet\sdk> dir

    Directory: C:\Program Files\dotnet\sdk

Mode                LastWriteTime         Length Name
----                -------------         ------ ----
da----         4/8/2017   1:00 PM                1.0.1
da----         4/7/2017  10:10 PM                1.0.2
da----        4/10/2017  12:06 PM                1.0.3
d-----        5/28/2017  12:02 PM                1.0.4
d-----        8/15/2017   3:26 PM                1.1.0
d-----        8/15/2017  12:36 PM                2.0.0
d-----       10/17/2017   8:47 PM                2.0.2
d-----        11/2/2017   1:08 PM                NuGetFallbackFolder

Got this info from the dotnet/cli folks:

Set the environment variable MULTI_LEVEL_LOOKUP to false to disable it.
The install script is used to download a ZIP and it puts the contents of the ZIP in the path for your current shell session. We don't make any statements regarding the dotnet host being able to find the SDK in the default location that the install script installs the SDK.
Also note that if you use the install script, the expectation is that you will run dotnet.exe from where the script installed the SDK, and the host will find the SDK that is sitting right next to it.

It appears to me that this is likely to work correctly the first time the user bootstraps the build env as the install-dotnet script adds the download path (user's appdata dir) to the PowerShell process's path.  After that session is closed, the user is at the mercy of what they have officially installed AFAICT because the build script is executing dotnet  as in dotnet --version, dotnet restore, etc.  There is no attempt to use the version of dotnet that the bootstrapper installed.  This seems a bit perilous.
One option is to use the install-dotnet script to install into $env:ProgramFiles\dotnet (on Windows) but would require elevation.  Another option is to configure $dotnet as a path to the executable where that path is under the user's app data folder.  Finally, you could try setting $env:MULTI_LEVEL_LOOKUP="false" but I'm still a little fuzzy as to what that actually does.

I've been looking at how the PowerShellEditorServices does this. It installs into a .dotnet folder at the root of the repo.  You'd need to gitignore that but that is another option to consider.

OK did a bit more investigating into this. I removed the 2.0.2 SDK that was in my C:\Program Files\dotnet\sdk dir and also removed the one from my app data dir.  Then I bootstrapped and tried to build w/no joy:
14:109ms> ipmo .\build.psm1
15:88ms> Start-PSBootstrap
Installing PowerShell build dependencies
dotnet not present.  Installing dotnet.
dotnet-install: Downloading link: https://dotnetcli.azureedge.net/dotnet/Sdk/2.0.2/dotnet-sdk-2.0.2-win-x64.zip
dotnet-install: Extracting zip from https://dotnetcli.azureedge.net/dotnet/Sdk/2.0.2/dotnet-sdk-2.0.2-win-x64.zip
dotnet-install: Adding to current process PATH: "C:\Users\Keith\AppData\Local\Microsoft\dotnet\". Note: This change will not be visible if PowerShell was run as a child process.
dotnet-install: Installation finished

17:367ms> gcm dotnet

CommandType     Name                                               Version    Source
-----------     ----                                               -------    ------
Application     dotnet.exe                                         2.0.255... C:\Program Files\dotnet\dotnet.exe

18:133ms> Start-PSBuild
WARNING: The currently installed .NET Command Line Tools is not the required version.

Installed version: 2.0.0
Required version: 2.0.2

Fix steps:

1. Remove the installed version from:
    - on windows '$env:LOCALAPPDATA\Microsoft\dotnet'
    - on macOS and linux '$env:HOME/.dotnet'
2. Run Start-PSBootstrap or Install-Dotnet
3. Start-PSBuild -Clean

The problem is that the precheck method is looking for any dotnet in the path.  In this case, it finds the dotnet in C:\Program Files\dotnet which is not able to see the SDK that was just downloaded.
This can be fixed by having Find-Dotnet first check to see if dotnet is in the current path and if so, dos it have the required SDK version.  If it does then we use it.  Mostly likely this dotnet is the global dotnet in which case we avoided installing dotnet when it doesn't need to be installed.
More importantly though, we don't settle on a version of dotnet (global) that doesn't have the required SDK.  In the case the globally installed dotnet doesn't have the required SDK, we prepend the user's local path for dotnet.  If we can't find dotnet or the required SDK in the user's local dotnet dir, this triggers a user local installation of dotnet.
PR coming on this.


Clarification on backends section

It seems that there is a conceptual change here compared to Istio for example - every version of a service is a separate service with a completely separate name
check https://github.com/deislabs/smi-spec/blob/master/traffic-split.md#example-implementation
web-current and web-next - so the differentiation is merely textual in service names? so there is no one service with multiple versions, but several services with separate names?
Also, if we look at the required work process in this example, when a user wants to deploy the "web-next", the current version already should be running under the name web-current, or renamed to it.
And then the web-next will need at some point be renamed to web-current? isn't this more maintenance? Less filter/search abilities that can be done on labels rather than searching inside strings of a name?

This is not specific to Istio and a generic specification. Istio has been chosen to start implementing TrafficSplit first.

web-current and web-next - so the differentiation is merely textual in service names? so there is no one service with multiple versions, but several services with separate names?

The difference is mere textual in this config. But those k8s services are pointing to different versions of same application (which are deployed as different deployments as mentioned in https://github.com/deislabs/smi-spec/blob/master/traffic-split.md#workflow)

Probably checkout the working example of the TrafficSplit Istio implementation here https://github.com/deislabs/smi-adapter-istio/tree/master/docs/smi-trafficsplit and let us know your thoughts, if this still feels cumbersome to you?

Probably checkout the working example of the TrafficSplit Istio implementation here https://github.com/deislabs/smi-adapter-istio/tree/master/docs/smi-trafficsplit and let us know your thoughts, if this still feels cumbersome to you?

yes, it is still not intuitive.
the example also states :

Create a new deployment named foobar-v2, with labels: app: foobar, version: v2

So user does need to add a label with version in addition to a service with a different name?
there is something unclear in how users are guided to create multiple versions of the same service.
nor is it making it easy to filter by versions.

@abonas so basically all of the filtering is done in the k8s svc objects and being reused in TrafficSplit.
The user is responsible to name their deployments and services accordingly (ie, foobar-v1 deploy/svc, foobar-v2 deploy/svc, etc) while clients use the "root svc" with it's FQDN (e.g., http://foobar). All of the labels/selectors are still the same as in k8s w/o svc mesh.
In this approach, I honestly think it simplifies managing multiple versions of a service using the baked in k8s constructs.

As a +1 to @christian-posta, instead of creating an arbitrary new type of solution (like istio's VirtualService), we're purposely building on top of k8s native primitives. If we removed the extra service from the picture (for each leaf), the spec would be required to fully support selectors. That's extra functionality for implementations and users to get their heads around. Instead, by basing this on services and how all k8s applications talk to each other by default, we're able to make something that is easy to implement, works the way users expect k8s to work and is extremely configurable for testing (imagine sending requests to the v2 service before switching anything over instead of doing some crazy pod selector to do it).

If 2 separate services with different names are representing the same microservice (but its different versions), how are they expected to be recognized as versions of the same service? Is it by the 'app' label?

Yah, any label(s) that together identity the app, excluding any version-specific labels. Example:
svc/foobar-v1 with labels:
app=foobar
env=prod
version=v1
svc/foobar-v2 with labels:
app=foobar
env=prod
version=v1
the root svc:
svc/foobar with labels:
app=foobar
env=prod
All clients use svc/foobar
All normal traffic is controlled with SMI constructs affecting the root service (svc/foobar)
Then, you can do things like run smoke tests against svc/foobar-v2 directly without affecting traffic routing. You also eliminate the confusion of "well, v2 in the routing layer uses these selectors while v2 in the deployment layer really means this, and the k8s svc construct could mean something else", etc

Also, any traffic that does not originate from a mesh will work normally through svc/foobar (remember, load balancing is a client side concern and not a server side concern).


Mobaxterm and Windows 10 Ubuntu Bash

I use Mobaxterm all the time.  I was delighted when I saw that Microsoft is now offering something similar, let's call it W10Ub.  I like the Microsoft offering, but I am not ready yet to give up Mobaxterm.  I am sure you have used Mobaxterm, and you would do well to offer something which has similar functionality; it is very extensive.  I have found some things which to not work well from W10Ub which work well from Mobaxterm.  For example today I used ssh to build a tunnel to a database.  When I try to use the tunnel in W10Ub it fails to connect.  When I use it in Mobaxterm, it works.
I have had trouble with the compatibility of subversion.  This may be something to do with subversion.  However on both Mobaxterm and W10Ub it is up to date.
I am providing this feedback, as you said in the video that you welcome it.
Keep up the good work.   It is very impressive and well appreciated.
Alistair

@AlistairMills - Oh... I had never heard Mobaxterm and it's good to know that, but... Movaxterm and WSL have different purposes, I think. Movaxterm looks like terminal emulator and X server based on Cygwin and could connect to another machine, for example to linux box, but WSL is... rather similar that linux box. I guess... If https://github.com/goreliu/wsl-terminal or http://conemu.github.io/en/BashOnWindows.html embed X server, those might be similar to that situation in WSL world :)

Yeah dude mobaxterm is connecting to a HyperV or Virtualbox VM in your case I guess?

It appears to me that Mobaxterm is very similar to WSL when it comes to the user experience.  Using Mobaxterm or WSL feels like using a typical linux environment to operate on the local windows file system.  I realise that the implementation details are quite different.  Mobaxterm uses cygwin, WSL Canonical's versions of the tools and WSL routes the system requests to the underlying Windows-10.  Both environments provide an impressive user experience.
Whether you use either environment as a terminal emulator to access a remote linux instance is irrelevant to this discussion.

@AlistairMills - Quote from http://mobaxterm.mobatek.net/

MobaXterm X server and SSH client
MobaXterm is your ultimate toolbox for remote computing. In a single Windows application, it provides loads of functions that are tailored for programmers, webmasters, IT administrators and pretty much all users who need to handle their remote jobs in a more simple fashion.
MobaXterm provides all the important remote network tools (SSH, X11, RDP, VNC, FTP, MOSH, ...) and Unix commands (bash, ls, cat, sed, grep, awk, rsync, ...) to Windows desktop, in a single portable exe file which works out of the box.

As mentioned above, Mobaxterm is X server and SSH client; I and @fpqc pointed that's remote network tools part but you look like to want to discuss about Unix commands. Well... If so... we should compair between Cygwin and WSL, not between Mobaxterm and WSL, I think :).
FYI, https://askubuntu.com/questions/813848/what-are-the-differences-between-windows-bash-and-cygwin

I don't think that this discussion is leading anywhere.  I propose that we close it.   I use both environments.  I think that you are making comments without having tried mobaxterm.  I like the answer given in Ask Ubuntu.  Thanks for bringing this to my attention.

@AlistairMills - IMPOV, Mobaxterm is technically a ssh client like putty or a console progrom like mintty. I had ever used Cygwin and I'm still use Msys2, but didn't use this terminal program yet, you said. Hmm... you could close this issue by "close" button below text area, you know. I'm good to know Mobaxterm, thanks again :)

@AlistairMills MobaXterm is not an environment, it is a terminal emulator with a built-in ssh and telnet client.  Your environment is probably either a VM, Cygwin, or possibly a remote machine.
If it is cygwin, you should be able to compile the wslbridge project inside of cygwin to connect directly into WSL itself.

I think that this conversation is not addressing the original topic and I am therefore closing it.

@AlistairMills - I think... you might meet whole another replies if you pick a topic like "How can I build ssh tunnel on WSL, and why does it different on Mobaxterm?"  and ansered "Indian Empire, or no Indian Empire we cannot do with out Shakespeare!" Carlyle had written that for English, but what if you're an Indian? For English, "Will you give up the British Empire or Shakespeare?" could make sense.  might be an issue. But... compairing between India and Shakespeare might look like to be nonsense for someone, I think.

Thank you for this comment.  You are correct that I did not ask the correct question, so the conversation became a discussion of the difference between Mobaxterm and WSL.  I think it is a good idea to avoid discussing the British Empire, Shakespeare and India!  Thank you for your very kind words.  Your English is very good.  Well done!

@AlistairMills - Good. I think we all could be heros :). See you around and good luck!

@abalter Hi, abalter, I use moba to start the windows 10 linux subsystem too, but have you met the problem about the character shading?

Hello Zubairy - I use mobaXterm with wsl all the time (thanks to abalter) and I have not seen the behaviour which you have reported.

Yes @zubairy -- Can you give me an idea for how to reproduce? It looks like you may have some color settings on your terminal. Try selecting a stock theme and see if that helps.

Dear abalter and Alistair, yesterday I deleted my wsl session, and created a new one just after see your replies, and magically, it become very normal (I didn't even change the session configuration). Thanks for your replies.

i had mobaxterm and wsl (bash) working great, i could run the apps in gui and straight from wsl native bash (didnt have to open mobaxterm, i could just run cmd, then type bash, then type gedit and it worked great) but now when i try to do anything i get this error
"Failed to connect to Mir: Failed to connect to server socket: No such file or directory
Unable to init server: Could not connect: Connection refused
(gedit:40): Gtk-WARNING **: cannot open display: :0"
and now mobaxterm cannot "see" the bash install. everytime i try to add it is says an error along the lines of:
"an error has occured while starting the following mobaxterm subprocess: c:\users\user\onedrive\documents\mobaxterm\slash\bin\motty.exe. the operation was canceled by the users."
any help would be appreciated :)

i were able to fix my problems. what i did was open control panel->turn windows features on or off->deselect windows subsystem for linux->reboot later->recheck windows subsytem for linux->restart now.
when i rebooted, everything just worked ;)

Just had the same issue. Fixed it by shutting down WSL using cmd prompt, wsl --shutdown, and starting MobaXterm again. Hope this helps.

Please try restarting WSL  -
Run powershell with administrator privilege -
1>  wsl.exe --shutdown
2>  wsl.exe
Worked like charm !!


Overhaul power-up sequence document

Supersedes and closes #269
Fixes #294
Fixes #211
Provides a base for #309

Ready for review!

Suggestions corrected, and rebased for good measure.

Done with some of the items, others are to be discussed.

This looks very nice, thanks @ISSOtm ! :partying_face:


Script logging should show currently executing script and procedure name

This would make it much easier to track down scripting issues.

a71e1189c10e3e7e201b26a72d22d6074d9724aa makes it so that warnings show the script name, if given by the warn call.
I'd like the currently executing procedure name as well, but it requires either having a separate call stack for procedure names (properly pushed/popped with call/ret opcodes) or setting the current proedure name on call opcodes and reading the address stack for return values and mapping them to procedure names.
If this ends up being too involved, it's fine to drop it and just use the script name.


Rewrite weasel.user_input()

Rewrite the wrapper user_input() like this (pseudo-code)
cancel, width, A, B, operation = weasel.user_input(title="Settings for binary operation",
    {"type":"float", "label":"Filter width in pixels", "default":1.0}
    {"type":"list", "label":"Image A", "default":0,  "list": Images(0x0018, 0x0024)}
    {"type":"list", "label":"Image B", "default":0,  "list": Images(0x0018, 0x0024)}
    {"type":"list", "label":"operation", "default":3,  "list": ["A * B", "A / B", "A + B", "A - B"]}
    )
if cancel: return

@IMI-TRISTAN @JSousa-UoL
I have committed the wrapper weasel.user_input(). See Tutorial_UserInput.py for an example of how this is used.
I also brought all three layers of the user_input() together in one class UserInput.py. It includes inputWindow from DeveloperTools and inputDialog. The originals have not yet been deleted.
UserInput.py is fully stand-alone - no dependencies with the rest of Weasel so can be run and tested on itself.
inputWindow and inputDialog can still be retrieved from this and used as they were.
Instead of
import CoreModules.WEASEL.InputDialog as inputDialog
now write
import CoreModules.UserInput as inputDialog
and inputWindow can be imported as follows:
from CoreModules.UserInput import inputWindow
So the file inputDialog.py can be deleted, and inputWindow can be deleted from DeveloperTools.
Please have a look..


Resolve #70, bug fixes, and small visual adjustments

What's changed:

Button colours: slightly adjust button colours and add the shadow effect mentioned in #70.
Progress bar: adjust progress bar colours.
Fix tab behaviour: in Windows 7, when an inactive tab is clicked on, it will be switched to active as soon as the mouse button is down so I fixed that. However, the fix that I applied here doesn't distinguish between the left, right, and middle mouse buttons. (I'm not proficient enough in Javascript and I'm too lazy to google for a solution 👀)
Fix a tab bug: here's the bug.

I think it's good now.


How can two characters appear in the same image

I have tested the cartoon generation of two characters, may I ask whether it is possible to realize the simultaneous appearance of these two characters in a picture, for example, two people sitting together to eat face to face, or two people shaking hands face to face? How to realize this scene, I find that there are two people in the same scene in my prompt, but only one character(Tagged presence,like [Bob]) can be drawn

[Bob]  and [Alice]  in the house filled with  treasure, laughing, at night #He is overjoyed inside the house.


Allows items to be imported with no points specified

This delivers a few fixes.

Part of #1396 - allow import of gradebook items without points.
Fixes #3100, error message box should now be cleared between steps.
Fixes #2796, any type of column should be ignored if it starts with a #. Also the error messages are more granular.

Hi @steveswinsburg, seems that Travis doesn't like this.  To avoid wrath, I'll hold off on merging!

Ack, tests updated.

This was never merged to 11.x for the 11.1 milestone.


tox using self hosted runner. maxmemory check fix

Codecov Report
Base: 57.01% // Head: 58.23% // Increases project coverage by +1.22% :tada:

Coverage data is based on head (b0d9e05) compared to base (62e9098).
Patch coverage: 90.90% of modified lines in pull request are covered.

:exclamation: Current head b0d9e05 differs from pull request most recent head e226584. Consider uploading reports for the commit e226584 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #189      +/-   ##
==========================================
+ Coverage   57.01%   58.23%   +1.22%
==========================================
  Files          24       24
  Lines        2082     2088       +6
==========================================
+ Hits         1187     1216      +29
+ Misses        895      872      -23

Impacted Files
Coverage Δ

...edis_benchmarks_specification/__runner__/runner.py
68.96% <90.90%> (+6.70%)
:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Expressive 3.0.0alpha1 - PHP 7.1 updates

Based on #529

strict types
added typehints
added return types
removed redundant tags in PHPDocs

Closing in favour of #529
It's impossible to split these PRs right now, as we have many dev-v3 component which already use many PHP 7.1+ features, and we need them in the same PR where adding PSR-15 support.


cannot access ApplicationHelper

I've recently updated Draper to 1.2.0 but now I can't access ApplicationHelper methods
rails 3.2.11
draper 1.2.0
module ApplicationHelper
  def initials(text)
     [...]
  end
end

class AccountDecorator < ApplicationDecorator
    def officers_initials
        h.initials(officer.name)
    end
end

NoMethodError: undefined method `initials' for #<#<Class:0x000000081107f8>:0x00000009404620>
from /home/duke/.rvm/gems/ruby-1.9.3-p392@bigbang/gems/draper-1.2.0/lib/draper/helper_proxy.rb:29:in `block in define_proxy'

I had the same problem. In a project I work on, we are using a decorator within a model method (don't ask me why). The problem occurs when certain mailer specs (which do not use ApplicationHelper) are run before this model's spec. Adding Draper::ViewContext.clear! to the failing model spec fixes the problem.
@gaizka solution in https://github.com/drapergem/draper/pull/547 does not fix this problem, since the view context is set to the mailers view context without application helper, while it should be reset before the model spec (or after the mailer spec). Maybe we should run Draper::ViewContext.clear! both before and after each test? Or simply run Draper::ViewContext.clear! before each type of test?

It is still not clear how to deal with this problem. We are facing the issue that once the mailer specs run, the controller specs are failing precisely because of this. Draper should be automatically configured so that it clears any cached variables after each spec. If someone wants to optimize the speed of the specs by enabling that, they should have the option, but at their own risk!
I am trying to make it work by adding this to my spec_helper.rb:
  [:decorator, :controller, :mailer].each do |type|
    config.before(:each, type: type) { Draper::ViewContext.clear! }
  end

But it still does not work


New version: BrettMayson.HEMTT version 1.11.2

Pull request has been created with WinGet Releaser v2 :rocket:
Microsoft Reviewers: Open in CodeFlow

Automatic Validation ended with:

Executable C:\Users\validator\AppData\Local\Microsoft\WinGet\Packages\BrettMayson.HEMTT__DefaultSource\hemtt.exe returned exit code: 2
Executable C:\Users\validator\AppData\Local\Microsoft\WinGet\Links\hemtt.exe returned exit code: 2

(Automated response - build 857.)

@wingetbot waivers Add Validation-Executable-Error


Series.custom.renderItem return BezierCurve will fill color in the whole area instead of being a Curve.

Version
5.0.0-alpha.2
Steps to reproduce
Just copy and paste these in any echarts online editor.
const colors = ["#1576d2", "#d14a82", "#26c1f2", "#a166ff", "#9C2BB6"]
const radius = [0.7, 0.75]
const data = [{
name: 'Mon',
value: 35
},
{
name: 'Tue',
value: 35
},
{
name: 'Wed',
value: 35
},
{
name: 'Thu',
value: 35
},
{
name: 'Fri',
value: 35
}
]
const sum = data.reduce((prev, curr) => {
curr._start = prev
curr._end = prev   curr.value
return curr._end
}, 0)
function renderItem(params, api) {
const ceilAngle = Math.PI / 100 // 装饰的显示角度
const coordSys = params.coordSys
const coordRadius = coordSys.r
const val = api.value(0)
const index = api.value(1)
const r0 = coordRadius * radius[0]
const r = coordRadius * radius[1]
const startAngle = (data[index]._start * Math.PI * 2) / sum - Math.PI / 2
const endAngle = (data[index]._end * Math.PI * 2) / sum - Math.PI / 2
const points = api.coord([api.value(0), api.value(1)]);
return {
    type: "group",
    children: [{
        type: 'sector',
        shape: {
            cx: coordSys.cx,
            cy: coordSys.cy,
            r,
            r0,
            startAngle: startAngle,
            endAngle: endAngle
        },
        style: api.style({
            fill: colors[index],
            opacity: 0.5
        })
    },
    {
        type: 'bezierCurve',
        shape: {
            x1: points[0],
            y1: points[1],
            x2: points[0] >= coordSys.cx ? points[0]   100 : points[0] - 100,
            y2: points[1] >= coordSys.cy ? points[1]   100 : points[1] - 100,
            cpx1: points[0] >= coordSys.cx ? points[0]   50 : points[0] - 50,
            cpy1: points[1] >= coordSys.cy ? points[1]   60 : points[1] - 60,
            cpx2: points[0] >= coordSys.cx ? points[0]   50 : points[0] - 50,
            cpy2: points[1] >= coordSys.cy ? points[1] - 60 : points[1]   60,
            percent: 1
        },

        style: ({
            fill: colors[index],
        })
    }]
}

}
option = {
color: colors,
angleAxis: {
type: 'category',
show: true,
},
radiusAxis: {
show: true
},
polar: {
radius: "75%"
},
series: [{
type: 'custom',
data: data,
renderItem: renderItem,
coordinateSystem: 'polar'
}]
}
What is expected?
So basically the renderItem is supposed to print 5 different BezierCurves with different angles.
What is actually happening?
The Bezier curve requires 8 variables: x1, y1, x2, y2, cpx1, cpy1, cpx2, cpy2. These 4 points declare one Bezier curve, but here they were recognized by the renderItem as an area instead of a curve.

I was asked to change the Pie chart's labelLine from default to the Bezier Curves. I was trying to edit the source code and it worked perfectly. However, the build function was not working well, so I cannot run the build command and pack it up after editing. Thus, I have to draw this pie chart by custom series.
Would that be another option if I submit my source code version with an additional labelLine.isBezier API? Will the Echarts developers review and merge my function into the source code? How fast it can be?

Try stroke instead of fill please.


Upgrade beevik/ntp from v0.3.0 to v1.4.3

What does this PR do?
Upgrade the NTP client library that we use in the NTP check from v0.3.0 to v1.3.4.

Motivation
Potentially improve the calculation of the clock offset and the library's capabilities in general, it has been 4 years since we updated it.

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

/merge


Microsoft.Bot.Connector.Directline.ChannelAccount does not have Properties field

Currently I am using the Directline package for C# and I noticed that I cannot specify additional properties to be passed to my bot using ChannelAccount. Why is there a different implementation of ChannelAccount in Microsoft.Bot.Connector.Directline vs Microsoft.Bot.Schema?

Thank you for opening an issue against the Bot Framework SDK v3. As part of the Bot Framework v4 release, we’ve moved all v3 work to a new repo located at https://github.com/microsoft/botbuilder-v3. We will continue to support and offer maintenance updates to v3 via this new repo.
From now on, https://github.com/microsoft/botbuilder repo will be used as hub, with pointers to all the different SDK languages, tools and samples repos.
As part of this restructuring, we are closing all tickets in this repo.
For defects or feature requests, please create a new issue in the new Bot Framework v3 repo found here:
https://github.com/microsoft/botbuilder-v3/issues
For Azure Bot Service Channel specific defects or feature requests (e.g. Facebook, Twilio, Teams, Slack, etc.), please create a new issue in the new Bot Framework Channel repo found here:
https://github.com/microsoft/botframework-services/issues
For product behavior, how-to, or general understanding questions, please use Stackoverflow.
https://stackoverflow.com/search?q=bot+framework
Thank you.
The Bot Framework Team


closes #22

Updated Fleet_Model.php and Flight_Model.php to retrieve data from CSV files
Updated Welcome.php to retrieve numPlane and numFlight
Created API_Model.php to retrieve live data from WACKY Server
Added CSV_Model.php, DataMapper.php, Entity.php, Memory_Model.php, RDB_Model.php in core folder
Added _menubar.php in views folder
Patch needed in fleet page to display the Vehicle Information for selected VehicleID
Updated changelog.md

Approved!
Thanks 👍


Developing algorithm assignment

@Mosaddeq107 will do this part.

So I will be doing unit test and Pooja will be doing documentation part.


python 3.6 or 3.8

I followed the instruction, installed python 3.6 on windows and tried pip install -r requirements.txt
but it reminded me that 1.22.4 Requires-Python >=3.8
So I recreated a py3.8 environment and successfully installed all the packages required. I'm wondering that which version I should install and if there will be some problems to use py3.8？
thanks

Thank you for pointing out this issue. Python 3.8 is the correct version, and we have updated README.md.


it won't work

after importing PTP section into register ; after opening the firewall ports; after restarting the w32tm & after executing resync it would return:
 w32tm /resync
Sending resync command to local computer
The computer did not resync because no time data was available.

while the regedit shows explicitly my ptp server setup  it wouldn't be returned by the verbose output of the command below:
w32tm /resync
Sending resync command to local computer
The computer did not resync because no time data was available.
PS C:\Windows\system32> w32tm /query /status /verbose
Leap Indicator: 3(not synchronized)
Stratum: 0 (unspecified)
Precision: -23 (119.209ns per tick)
Root Delay: 0.0000000s
Root Dispersion: 0.0000000s
ReferenceId: 0x00000000 (unspecified)
Last Successful Sync Time: unspecified
Source: Local CMOS Clock
Poll Interval: 6 (64s)

Phase Offset: 0.0000000s
ClockRate: 0.0156250s
State Machine: 0 (Unset)
Time Source Flags: 0 (None)
Server Role: 0 (None)
Last Sync Error: 1 (The computer did not resync because no time data was available.)
Time since Last Good Sync Time:<PHONE_NUMBER>s

 w32tm /query /configuration
[Configuration]

EventLogFlags: 2 (Local)
AnnounceFlags: 10 (Local)
TimeJumpAuditOffset: 28800 (Local)
MinPollInterval: 6 (Local)
MaxPollInterval: 6 (Local)
MaxNegPhaseCorrection: 54000 (Local)
MaxPosPhaseCorrection: 54000 (Local)
MaxAllowedPhaseOffset: 1 (Local)

FrequencyCorrectRate: 2 (Local)
PollAdjustFactor: 5 (Local)
LargePhaseOffset: 50000000 (Local)
SpikeWatchPeriod: 900 (Local)
LocalClockDispersion: 10 (Local)
HoldPeriod: 5 (Local)
PhaseCorrectRate: 1 (Local)
UpdateInterval: 100 (Local)

[TimeProviders]

PtpClient (Local)
DllName: c:\windows\system32\ptpprov.dll (Local)
Enabled: 1 (Local)
InputProvider: 1 (Local)

NtpClient (Local)
DllName: C:\Windows\system32\w32time.dll (Local)
Enabled: 0 (Local)
InputProvider: 1 (Local)

NtpServer (Local)
DllName: C:\Windows\system32\w32time.dll (Local)
Enabled: 0 (Local)
InputProvider: 0 (Local)

VMICTimeProvider (Local)
DllName: C:\Windows\System32\vmictimeprovider.dll (Local)
Enabled: 0 (Local)
InputProvider: 1 (Local)

I also have this problem.

I have this problem also,
I suspect that w32time didn't get windows ptp provider, see the output here:
ReferenceId: 0x00000000 (unspecified)  //---------------> this should be 0x4D505450
Last Successful Sync Time: unspecified
Source: Local CMOS Clock
But how to change it ?

I found reference to a similar (maybe th
e same) problem under a different issue here; it appears that Microsoft's implementation only works when the PTP domain is 0.
Are either of you using a PTP server that is using a different domain?

actually, PTP service is ready enabled, in event viewer

we can see domain is 0 here. I didn't try different domain.
Req/Resp messages were showed on Wireshark tool.

but still shows error when run w32tm /resync
I total get confused about it

Hi, Guys
finally, I got the ptp4l works with w32tm. but it still has some problems, the phaseoffset should not be correct, it is so huge, and after sync, the time was changed to 1995, i don't know why, because in Wireshark, we checked the correction, it is no problem, but why W32TM shows show a huge gap, Does everyone know it?
attach some picture here

Who knows the reason?
Thanks

could you share all parameters that you are using starting ptp4l at linux server, please?
In my environment it would see the server messages, but wouldnt synchronize. at least it wouldnt indicate that sync happens in the terninal but would also throw error messages

hi all
As I mentioned, W32tm only supports unicast, so please use this command
./ptp4l -E -i (interface) -m -H -f ./configs/UNICAST-MASTER.cfg
you should modify the config as below:
[global]
hybrid_e2e                      1
inhibit_multicast_service       0
unicast_listen                  1
Hope it can help you.

@Kemler-J
Thank you for sharing!
Will try to get with this config https://github.com/richardcochran/linuxptp/blob/master/configs/UNICAST-MASTER.cfg with the mentioned modifications

@AndreV84
Did you receive Req/Resp messages  on Wireshark tool? And did you receive 512,513 messages in event viewer please?
I also tried to deploy the PTP client in Windows to complete the clock synchronization with LinuxPTP in Linux. Windows could only receive sync, follow up and Announce messages, but did not reply any messages(delay_req). What's the matter?

exactly!
receive Req/Resp messages on Wireshark tool also 512,513
however if you are not binded to ptp4l as I am you may use pre-configured ptpd that works but less desireable in certain situations

@AndreV84
Thank you for your replying.
It is a pity that Centos only support Linuxptp.
I also added the unicast_master configuration file as above

And run like this

But the windows did not receive any messages.

My guess is that the currentUtcOffsetValid-flag (aka PTP_UTC_REASONABLE) has to be non-zero, which is something that can be easily accomplished with PTPd, but is not a trivial thing to do with LinuxPTP.
Obviously, also the domain has to be '0' and the PTP_TIMESCALE-flag also has to be set.


⚠ ClamAV has degraded performance

In 142eb4d, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 576 ms

Resolved: ClamAV performance has improved in 23d57d3.


Adds Pubswap to apps.

Pubswap communicates directly with the IPFS network to deliver video content to its users.

Doesn't seem to be working (or at least it works in a very confusing way).

It could eventually use the local go-ipfs or the companion instead of forcing js-ipfs. Not sure if it is already doing that, but the experience is very bad. I guess it is because the content is not replicated enough in the network

It is said that more than 50% of modern content is consumed via a mobile device. Mobile devices that are or may not be connected to a home wifi network. Tethering the main functionality of the service to a local IPFS node would be a bad idea given this fact alone. Most visitors will also be just casual viewers and those that would not be willing to install an IPFS node anyway.
The upload functionality does use a local node and there is logic (that is currently disabled) that can pull the content from the HTTP gateway but this is not the intent of the service. There are specific reasons for each decision in this service. Having said all of that, the functionality is flawless for me. There is currently a delay at the beginning of playing each video due to this: https://github.com/ipfs/js-ipfs/issues/1706.
I thought it was lack of availability on the network as well but this doesn't make any sense given the websocket structure. js-ipfs does not communicate directly with the DHT yet so it relays through a websocket connection on the bootstrap nodes configured in the js-ipfs client. Basic troubleshooting led to the conclusion filed in the issue linked above. There seems to be a delay in the Readable Stream implementation in the client as the blocks stream in instantly but the stream does not advertise this for a number of seconds (sometimes upwards of 10 or more).
There is also another large requirement that any browser used must support the Media Source Extension given how the player works.
Pubswap was intended to be as decentralized as possible. A service that could be supported by the users themselves. No large data centers or racks of servers required. The only thing that is still centralized is the dataset of IPFS hashes linked to the textual data displayed on the site. IPFS doesn't really offer a solution for storing/indexing descriptive data for content or providing a real time full text search capability of that data.
Providing only a platform and not storing, processing or distributing the content allows the service to be hosted for much less cost and makes it much less vulnerable to de-platforming. For this, we must (for now) give up some functionality. The jury is still out on whether people are ready for such a service. Your responses here aren't very encouraging on the affirmative.

Your long response makes me feel that I hurt you. Sorry that was not my intention.
What I meant to say is: What if the user has an local already running ipfs node? Why don't you hook it into window.ipfs from the companion when it is available? This will help. 😄

Heh, no hurt. I like to use these opportunities to document the service as I know the documentation on the site is light. My focus is on functionality ATM but the docs will improve. I do have fallback logic to stream through a local IPFS node already and will enable it when the Media Source Extension is not available (possibly).
I have it disabled for now since this will require storing each video in numerous formats to support. The content needs to be in a specific format to stream in blocks over the websocket directly into the HTML video buffer but this format will not just play over HTTP without the corresponding manifest files. Tons of material is available on this topic if further understanding is desired.
Modifying manifest files to work with IPFS CDN is one potential option in the future but that is not in place yet. As for the browser plugin, it doesn't seem necessary and would be another prerequisite to install for the service to function properly. If/when I want to support streaming content over a local HTTP gateway, I would not need or benefit from the browser plugin.

To me it still looks you're offended and because of that failing to see that pubswap could be a really useful service if you accepted to use some of the existing centralized infrastructure we have today (like public gateways) instead of trying to achieve the impossible. You can always remove that later.
And obviously relying on the IPFS Companion when available is something you should do, and since you didn't address that in your response to @koalalorenzo maybe you don't know what is he talking about? https://github.com/ipfs-shipyard/ipfs-companion

I am using private gateways and still have no use for the browser plugin but thanks!
FYI, disagreeing with someone does not constitute offense. Why would I be offended that some have no clue what the service does or its purpose?


Error in 'ChartPlatform.swift' while compiling : Expected #else or #endif at the end of configuration block

I have installed iOS charts using cocoa pod
target 'MyPerformance' do
pod 'Charts', '~> 2.2'
use_frameworks!
end
and when compiling , getting this error. i am integrating this in existing Objective c project:
Error in 'ChartPlatform.swift' while compiling : Expected #else or #endif at the end of configuration block

Same here in a full Swift project, Xcode 7.1.1

You should compile with Xcode 7.2


some issue on build code

i got some trouble on build the code when i run make -Cbuild

if using MSYS2, update your gcc and mingw to latest by typing pacman -Syu --noconfirm
if using MSYS from official MinGW, try to get latest precompiled mingw-w64 package (from sourceforge downloads). if you don't know how to do this, just do MSYS2 fresh installation following instructions in README

if using MSYS2, update your gcc and mingw to latest by typing pacman -Syu --noconfirm
if using MSYS from official MinGW, try to get latest precompiled mingw-w64 package (from sourceforge downloads). if you don't know how to do this, just do MSYS2 fresh installation following instructions in README

i have updated my gcc and mingw and its show that is up to date and it still can't build.
there is some information.

Start a MinGW32 window (using mingw32.exe), not a MSYS window(using msys2.exe)
Please note that each .exe sets differecnt dev environment, MSYS2.exe is only for MSYS2 shell program development

seems like you are using gcc not g++ to do th link, don't know what is wrong
you can try to:

confirm you have g++ from mingw(which g++ returns /mingw32/bin/g++)
completely remove build folder and try it again
if still not working, try remove MSYS2's own gcc first(pacman -Rcns gcc) and redo step 2

tested by installing a clean MSYS2, found the thing is that something wrong in instruction:
you should install mingw-w64-i686-cmake not cmake, I have fixed it in README, sorry for my mistake.

it works, thx :)


Fix variable casing in Navigation documentation example

Fix inconsistent variable casing: 'backstack' -> 'backStack' to match original variable declaration
Another option would be standardizing to 'backstack' throughout.

Thanks!


Update preview-features.md

Updating to emphasize that several features will not appear on the portal and perhaps using CLI or Powershell will be a better solution

@mumian
Can you review the proposed changes?
Important: When the changes are ready for publication, adding a #sign-off comment is the best way to signal that the PR is ready for the review team to merge.
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

Create another PR to address this issue - https://github.com/MicrosoftDocs/azure-docs-pr/pull/291890
#please-close


[Bug]  rocketMQ-4.x-plugin causes memory leaks when project user old version cloud-stream-rocketmq-starter

Search before asking

[X] I had searched in the issues and found no similar issues.

Apache SkyWalking Component
Java Agent (apache/skywalking-java)
What happened
When project  use old version cloud-stream-rocketmq-starter, it will causes memory leaks.
ps: Higher versions do not have this problem
   <dependency>
        <groupId>com.alibaba.cloud</groupId>
        <artifactId>cloud-stream-rocketmq-starter</artifactId>
        <version>1.3.2</version>
    </dependency>

Issue source code
(MessageConcurrentlyConsumeInterceptor and MessageOrderlyConsumeInterceptor):
@Override
public Object afterMethod(EnhancedInstance objInst, Method method, Object[] allArguments, Class<?>[] argumentsTypes,
    Object ret) throws Throwable {

    ConsumeOrderlyStatus status = (ConsumeOrderlyStatus) ret;
    if (status == ConsumeOrderlyStatus.SUSPEND_CURRENT_QUEUE_A_MOMENT) {
        AbstractSpan activeSpan = ContextManager.activeSpan();
        activeSpan.errorOccurred();
        Tags.MQ_STATUS.set(activeSpan, status.name());
    }
    ContextManager.stopSpan();
    return ret;
}

cause
cloud-stream-rocketmq-starter encapsulation the method of messageListener.
protected class CloudStreamMessageListenerConcurrently extends RocketMQInboundChannelAdapter.CloudStreamMessageListener implements MessageListenerConcurrently {
    public ConsumeConcurrentlyStatus consumeMessage(final List<MessageExt> msgs, ConsumeConcurrentlyContext context) {
        Acknowledgement acknowledgement = this.consumeMessage(msgs);
        context.setDelayLevelWhenNextConsume(acknowledgement.getConsumeConcurrentlyDelayLevel());
        return acknowledgement.getConsumeConcurrentlyStatus();
    }
}

The interceptor to be triggered twice and an exception has occurred (java.lang.ClassCastException).

In addition, the MQ consumer get thread  from thread  pool. That the span can not stop, the class are alse not gc.

What you expected to happen
Although it's an issue with older versions, I think the robustness of the code can be enhanced.
Add type judgment in interceptor (MessageConcurrentlyConsumeInterceptor and MessageOrderlyConsumeInterceptor)
like:
public Object afterMethod(EnhancedInstance objInst, Method method, Object[] allArguments, Class<?>[] argumentsTypes,Object ret) throws Throwable {
    if (ret instanceof ConsumeConcurrentlyStatus) {
        ConsumeConcurrentlyStatus status = (ConsumeConcurrentlyStatus) ret;
        if (status == ConsumeConcurrentlyStatus.RECONSUME_LATER) {
            AbstractSpan activeSpan = ContextManager.activeSpan();
            activeSpan.errorOccurred();
            Tags.MQ_STATUS.set(activeSpan, status.name());
        }
    }
    ContextManager.stopSpan();
    return ret;
}

How to reproduce
user old version cloud-stream-rocketmq-starter
   <dependency>
        <groupId>com.alibaba.cloud</groupId>
        <artifactId>cloud-stream-rocketmq-starter</artifactId>
        <version>1.3.2</version>
    </dependency>

Anything else
No response
Are you willing to submit PR?

[x] Yes I am willing to submit a PR!

Code of Conduct

[X] I agree to follow this project's Code of Conduct

Feel free to open the pull request. We could discuss the details there.

One question would be, if this afterMethod is invoked twice,  why the beforeMethod doesn't?

One question would be, if this is invoked twice, why the doesn't?afterMethod``beforeMethod

beforeMethod also invoked twice. This means that ContextManager.createEntrySpan() was executed twice  that it need execute the stopSpan-method twice too(ContextManager.stopSpan());

So, what exactly happens? I am not following now. Once create and stop execute twice, it should be fine.

So, what exactly happens? I am not following now. Once create and stop execute twice, it should be fine.

two create and one  stop!
It missing one  stop due to an ClassCastException.

So, the type was different the some old versions only?

Yep

I can't find 1.3.2 from maven central, https://mvnrepository.com/artifact/com.alibaba.cloud/spring-cloud-starter-stream-rocketmq . The 2.0 was from 3 years ago.
How did you get this?

I can't find 1.3.2 from maven central, https://mvnrepository.com/artifact/com.alibaba.cloud/spring-cloud-starter-stream-rocketmq . The 2.0 was from 3 years ago. How did you get this?

Sorry, I wrote the groupId incorrectly.
https://mvnrepository.com/artifact/org.springframework.cloud/spring-cloud-stream/1.3.2.RELEASE
org.springframework.cloud.stream.binder.rocketmq.integration.RocketMQInboundChannelAdapter.CloudStreamMessageListenerConcurrently

Sorry, I wrote the groupId incorrectly. https://mvnrepository.com/artifact/org.springframework.cloud/spring-cloud-stream/1.3.2.RELEASE org.springframework.cloud.stream.binder.rocketmq.integration.RocketMQInboundChannelAdapter.CloudStreamMessageListenerConcurrently

But where does CloudStreamMessageListenerConcurrently locate? I don't think it is related to the spring-cloud-stream

So, what exactly happens? I am not following now. Once create and stop execute twice, it should be fine.

two create and one stop! It missing one stop due to an ClassCastException.

This is not the root cause.
This method https://github.com/alibaba/spring-cloud-alibaba/blob/b28e82dc3cf0d534dc98e78294412d2f05e11b8f/spring-cloud-stream-binder-rocketmq/src/main/java/org/springframework/cloud/stream/binder/rocketmq/integration/RocketMQInboundChannelAdapter.java#L170 is unexpectedly intercepted due to the incomplete method matcher in the definition if you check the comment,
https://github.com/apache/skywalking-java/blob/02dad132b2807cbecdb69c7c0fbce54d36bd6e3e/apm-sniffer/apm-sdk-plugin/rocketMQ-4.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/rocketMQ/v4/MessageConcurrentlyConsumeInterceptor.java#L28-L32

The only concern is, this is an old release, and dead version series.
Apr 19, 2019 is the last release date.
Meanwhile, instanceof operation costs resources. Is that worth all users to pay?

I don't think it's going to be changed, it's my own problem.
I will close this issue.
Thank you very much.


Consider adding cscope output append feature

Starscope is great in handling the languages it supports. When working with large mixed-language repository, however, it is desirable to generate a single cscope.out file that cscope -d mode can navigate among source files of all languages (e.g., C and Go). Other tools expecting a single cscope.out file would also be able to work on the entire code base.
Although cscope and starscope can separately index C and Go files, there currently lacks a way to merge their indexing result into a single cscope.out files. While this can be done in a new tool specifically created for this, it would be great if starscope can optionally read in a cscope.out file and simply append its indexing result to it, making starscope a perfect companion to cscope.

That's a great idea. Unfortunately, the cscope file format is not really "appendable", it has a header at the top which becomes invalid if you add more data, and is difficult to just recalculate.

By "append" I meant semantically, i.e., starscope, upon exporting to cscope, will optionally read in an existing cscope.out file, append its own indexing data to the existing data in memory, and write out a new cscope.out file containing the entire indexing data.
I assume it should be straight-forward for starscope to read in existing cscope.out files as it already knows how to write out to one.

Unfortunately not a true assumption, the support for writing a cscope file is pretty hacky and doesn't naturally invert to support reading. The first step would probably be extracting support for the file format into a proper library that did support reading and writing.

I see. Thanks for the explanation!


Vasil - Update min ada in UTXO

Modify min ada calculation logic due to inline datum and reference script support in Babbage era.

Curious if this issue is causing errors like this?
Transaction failed: Result{successful=false, response='{"error":"Bad Request","message":"\"transaction submit error ShelleyTxValidationError ShelleyBasedEraBabbage (ApplyTxError [UtxowFailure (UtxoFailure (BabbageOutputTooSmallUTxO [((Addr Testnet (KeyHashObj (KeyHash \\\"ff1f7d5044589c668f4ea8946a9cd96670a03082a626046f43f467bd\\\")) (StakeRefBase (KeyHashObj (KeyHash \\\"2711eac3b659022ada0b49cd720790c3e44722c5df165a4d4e8df1f9\\\"))),Value 168090 (fromList [(PolicyID {policyID = ScriptHash \\\"acf3057d8848a3c530225b8d276f4a0a3df6e1665449be9ad9693770\\\"},fromList [(54657374436f696e,250000)])]),NoDatum,SNothing),Coin 1172320)]))])\"","status_code":400}', code=400, value=TransactionResult{signedTxn=84a60081825820d90e7f4d58cb4155943b2e9026ce76921e89e39ec344b0a5bbcd8c2fe22f230500018282583900ff1f7d5044589c668f4ea8946a9cd96670a03082a626046f43f467bd2711eac3b659022ada0b49cd720790c3e44722c5df165a4d4e8df1f91a00118bd582583900ff1f7d5044589c668f4ea8946a9cd96670a03082a626046f43f467bd2711eac3b659022ada0b49cd720790c3e44722c5df165a4d4e8df1f9821a0002909aa1581cacf3057d8848a3c530225b8d276f4a0a3df6e1665449be9ad9693770a14854657374436f696e1a0003d090021a0002c6f1031a03c1aa58075820b001d5217d22e06c66cc52034231e99fd2c9ab9fb7b743bc53e93f24ad49d7f909a1581cacf3057d8848a3c530225b8d276f4a0a3df6e1665449be9ad9693770a14854657374436f696e1a0003d090a20082825820ba4b0f03ea2d69bd0550f460a9e23f9d5e4bba525ab73ccea7867eb4199d26a65840958efb650c904c1d23c101ef489fc909193845fe295eb11783712612ee29a78a29bdb9de5b0be94f973be716bfbde44e47d95a768524d10ba9a7c736e41244028258207268067ef8798a3f227caa270b3f6f57bd08b37b4b7d9dfb7d7b85bb56d500c95840fcd0260faecd94fa0605f32bcceb2946738e63025a84f6839598fe88c03de9dda6fc10d9dac1c8d119169b3c0ec94107c430acbe08350734174d30e4cb01930e01818200581c23010b13af9340aaed4c71db563b06b614e5350f20527d29f5f62e65f5a21a000bbfd1a265746f6b656e6a5465737420546f6b656e6673796d626f6c6454544f4b1a000bbfd28264746167316474616732, transactionId='null'}}
I had a working "Hello World" to mint an NFT about a month ago and when I came back to the project today I am seeing the error I posted above. Curious if they are related.

Yes, it seems min ada calculation logic needs to be updated. I found some parameter value change in babbage era. Like coins_per_utxo_size value is changed from 34482 to 4310 in epoch 215 (testnet). Though this parameter is fetched from node during min ada calculation, but it seems  calculation logic also needs to be updated.
Workaround
For now, if you are using high level MintTransaction  api to mint token, you can override ProtocolPrameterSupplier and update protocol parameter value in your code to old value. Add the following code snippet before calling feeCalculationService
 transactionHelperService.getTransactionBuilder().setProtocolParamsSupplier(new ProtocolParamsSupplier() {
            @Override
            public ProtocolParams getProtocolParams() {
                DefaultProtocolParamsSupplier protocolParamsSupplier =  new DefaultProtocolParamsSupplier(backendService.getEpochService());
                ProtocolParams protocolParams = protocolParamsSupplier.getProtocolParams();
                protocolParams.setCoinsPerUtxoWord("34482");
                return protocolParams;
            }
        });

But, if you are using composable functions or low level api, you can adjust the LOVELACE amount to some higer  amount in TransactionOutput (instead of 0)
https://github.com/bloxbean/cardano-client-examples/blob/c2bfb9f98f7ce4e692cbaea1bc76d3cf1bbf2fbe/src/main/java/com/bloxbean/cardano/client/examples/function/minting/MintTokenNFT.java#L70

In Babbage era, the min ada is calcuated according to following rule
(serSize txout + 160) ∗ coinsPerUTxOByte

According to https://hydra.iohk.io/build/15339994/download/1/babbage-changes.pdf
See on the page 9 getValue txout

Do you plan to include this in a release relatively soon?

A beta build should be out in a week or two.
Alternatively, you can also try  build from SNAPSHOT repository. You can found the SNAPSHOT build info here
https://github.com/bloxbean/cardano-client-lib#for-snapshot-binaries

Fixed in 0.3.0.


CSV export format

Hello,
it would be nice, if the export format of the csv files could be easily changed.
For now, I would be glad if there was an approach to achieve this by hand in the source code.
My usecase:
I created a dataset and exported as csv files.
Later I want to import them to GnuHealth.
An example of an unpleasant point is the row DESCRIPTION in the medications.csv file.
The content of this column looks f.e. like this: Warfarin Sodium 5 MG Oral Tablet.
This is bad for automated processing, since GnuHealth wants to know several pieces of information about a medication, like name, dose, supplyform etc.
So I would have to parse all information about the drug from the string.
It would be more handy if there would be multiple column for this.
F.e. NAME, DOSE, SUPPLYFORM etc.
Kind regards
Andreas

The DESCRIPTION is literally the RxNorm description, e.g. https://mor.nlm.nih.gov/RxNav/search?searchBy=RXCUI&searchTerm=855332, so you should consider it opaque and not try to parse it.
Usually we are not internally tracking dose, form, etc.
Synthea modules allow for this, e.g. https://github.com/synthetichealth/synthea/wiki/Generic-Module-Framework%3A-States#prescription.
But it is optional, and is not required in the Module Builder.
If you wanted to modify the CSV exporter, you might start here: https://github.com/synthetichealth/synthea/blob/6b5a8a92ade0e03d3e61b832d31dac77b77b1d7a/src/main/java/org/mitre/synthea/export/CSVExporter.java#L820-L902

Just a thought, but you could download RxNorm and use that to identify more granular metadata for the code that is included in the Synthea output.


no additional info showing up when pointer over the bar

When i hold the mouse pointer over the download bar i will see additional info about the file but on some sites i don't get any.

The pages it won't work on are https://uploadgig.com and https://www.digitalocean.com

This and #27 should be fixed in the latest beta.


fixed issue with useStringsForPicklists property in JUnit tests; back…

fixed issue with useStringsForPicklists property in JUnit tests; backported Date/Time solutions from later releases; added possibility to override types for picklist/multipiklists and date fields to specific other types.
To use new feature, simply append in pom.xml following section within "configuration" node (example):

Account
AccountSource
String

Case
ClosedDate
java.time.OffsetTime

@zregvart nevermind.

It's not really clear what are you trying to accomplish. If you need something backported to 2.21.x then raise a JIRA for it and we'll evaluate if it's feasible or not.


Type "com.pkware.zip-archive" was expected to be declared and imported

The toolbox started correctly, I try to test a fw update for a DFU device, I find it via ble, but when I choose the DFU Distribution package I see this error:

getting the same error, any update on this


Lung Cancer Detection Addition to the Project

I am a GSSoC 21 participant (DISCORD username:smoky237#5411 ), I can contribute to the Health Check project by adding a Lung  Cancer Detection  Route/section with a working model
The Dataset will be taken from Kaggle itself.
Kindly assign this work to me @kritikaparmar-programmer
#GSSoc

@ayush237 please share the dataset you want to work on

Any Update?

@ayush237 Please provide update regarding the issue.

Closing this issue because of inactivity for more than 14 days


SSH error when set multiple trial currency in remote trainingservice

When set trialcurrency >= 8, there will be ssh error.
(node:7677) ExperimentalWarning: The fs.promises API is experimental
{ Error: (SSH) Channel open failure: open failed
    at SSH2Stream.onFailure (/home/t-shya/.local/nni/node_modules/ssh2/lib/client.js:1203:13)
    at Object.onceWrapper (events.js:273:13)
    at SSH2Stream.emit (events.js:182:13)
    at parsePacket (/home/t-shya/.local/nni/node_modules/ssh2-streams/lib/ssh.js:3709:10)
    at SSH2Stream._transform (/home/t-shya/.local/nni/node_modules/ssh2-streams/lib/ssh.js:671:13)
    at SSH2Stream.Transform._read (_stream_transform.js:190:10)
    at SSH2Stream._read (/home/t-shya/.local/nni/node_modules/ssh2-streams/lib/ssh.js:253:15)
    at SSH2Stream.Transform._write (_stream_transform.js:178:12)
    at doWrite (_stream_writable.js:410:12)
    at writeOrBuffer (_stream_writable.js:394:5)
  name: 'Training service error',
  cause:
   { Error: (SSH) Channel open failure: open failed
       at SSH2Stream.onFailure (/home/t-shya/.local/nni/node_modules/ssh2/lib/client.js:1203:13)
       at Object.onceWrapper (events.js:273:13)
       at SSH2Stream.emit (events.js:182:13)
       at parsePacket (/home/t-shya/.local/nni/node_modules/ssh2-streams/lib/ssh.js:3709:10)
       at SSH2Stream._transform (/home/t-shya/.local/nni/node_modules/ssh2-streams/lib/ssh.js:671:13)
       at SSH2Stream.Transform._read (_stream_transform.js:190:10)
       at SSH2Stream._read (/home/t-shya/.local/nni/node_modules/ssh2-streams/lib/ssh.js:253:15)
       at SSH2Stream.Transform._write (_stream_transform.js:178:12)
       at doWrite (_stream_writable.js:410:12)
       at writeOrBuffer (_stream_writable.js:394:5) reason: 'ADMINISTRATIVELY_PROHIBITED', lang: '' } }

https://github.com/Microsoft/nni/pull/829

seems had fixed in PR 829, @sparksnail, please reopen it if there are still left work.

This issue is fixed with PR 829.


Loading Changed and Fixed

Description
This fixes the saving and loading functionality for both player and maps team, by fixing some bugs and making the code quality better so that the loading and saving system is more understandable. Furthermore major fixes have been made to the load button implementation in the menu and the functionality of the load button.
Fixes / Closes # (issue)
https://github.com/UQcsse3200/2024-studio-1/issues/406
#417
#420
Type of change
Please delete options that are not relevant.

[x] Bug fix (non-breaking change which fixes an issue)
[x] Feature Improvement

How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Menu components were implementation tested through multiple
Unit tests for map and character saving
Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[x] Any dependent changes have been merged and published in downstream modules

Fixed issue with loading pets from save files

Looks Good , some methods will have to be moved to gamearea from maingamearea like displayui() as refactoring is done that way but that could be done during merge too.

GameOptions.shouldLoad is never meaningfully used (never read from) now that the load button just loads immediately. Don't think you'll be using that anymore, you can probably delete it

GameOptions.shouldLoad is never meaningfully used (never read from) now that the load button just loads immediately. Don't think you'll be using that anymore, you can probably delete it

You can delete the boolean param from MainMenuActions.onPlayerSelect and the event invocation, if you're going to the player select screen in the first place then you're definitely not loading

GameOptions.shouldLoad is never meaningfully used (never read from) now that the load button just loads immediately. Don't think you'll be using that anymore, you can probably delete it

if you have not saved a game locally, you will not see the load button unless that has changed recently


Fixing wrong generator

Signed-off-by: Matthias Wessendorf<EMAIL_ADDRESS>avoid incorrect, hard-coded OCP version

/retest

I missed this the other day 🤦🏽♂ my bad
/lgtm


[BUG] In timer at Pomodoro Page

Description
Describe the bug:
I think there is a bug in the timer on the Pomodoro page, after resetting the timer it starts from 5 min, not from 25 minutes. If it is not the bug, do close the issue
Video
https://github.com/akshitagupta15june/Moksh/assets/100359818/4ca78e30-3c91-4094-ad2e-93ca209163b1
Additional Information
Device (please complete the following information):

OS: [e.g., Windows, macOS, Linux]
Browser [e.g., Chrome, Safari, Firefox]
Version [e.g., 22]

If this is the issue, kindly assign me under GSSoC 2023!

I would like to work on this issue @akshitagupta15june under GSSoC'23

I've recently worked on my own pomodoro web app, and would love to work on this too, you may assign this to me under GsSoc'23.

@Sar-thak-3 wait for some time we are cross-checking whether the issue isn't a duplicate or assigned, if neither is the case we will assign to you.

@Sar-thak-3 assigning the issue to you, pl adhere to time frame you have one week to submit your changes (Pull Request).


DOC Small fixes in 'Using the image layer'

Description

Small fix to finish a sentence in 'Using the image layer'
Fix alt text error in colormap example

Type of change

[ ] Bug-fix (non-breaking change which fixes an issue)

References

How has this been tested?

N/A
Final checklist:

[ ] My PR is the minimum possible work for the desired functionality
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] If I included new strings, I have used trans. to make them localizable.
For more information see our translations guide.

Thanks @melissawm @jni


Aqara humididy don't work with the last update

So, I’m not sure what’s actually wrong because I can’t read the card... can you elaborate?

HA don't receive humidity value


Comet Collision: Initial comet cleanup

Bunch of changes here, but mostly it’s rearrangement and documentation
work. MessageCometActor was renamed to MessagingCometActor in preparation
for the reworking of how CometActor is actually split up (into messaging and
then rendering layered on top of it).
Also split out a couple of distinct chunks into their own files (ListenerManager
and StatefulComet).
Merge is going to an integration branch; figured it would make it easier to
handle reviewing the actual changes to the structure of CometActor.

Whoops, this is probably going to blow up; forgot to do compilation checks to make sure all my imports were in order >_>

Looks good to me. +1

If travis signs off on the compilation fix I just pushed, I'm going to go ahead and merge this as I continue work on the rest.

Looks like some concurrency issues in LAFutureSpecs on master, but unrelated to this branch, so in we go.


Fix < and > in C_HEADER_DESCRIPTION

E.g. at top of https://dlang.org/library/core/stdc/stdlib.html:
from the standard C header <stdlib.h>.

The change here used to be wrong in ddoc, I don't know if that's changed recently but make sure it generates correctly in regular ddoc too.
(or deprecate ddoc and only use good generators but since this is the official website thing it gotta work there for now)

Something weird is happening, the original actually looks OK the way I generate the HTML. My change is wrong. In the online page linked in the description, the link text has this HTML (at least in Firefox):
&lt;stdlib<wbr>.h&gt;

So the entity characters are getting broken up into span'd punctuation characters.

Filed: https://issues.dlang.org/show_bug.cgi?id=23659


Fix "Plus" icon size in dashboard

Thanks your PR!
But we do not accept PR to master and we use .less to generate .css.


Rewrite TestApp using SwiftUI

This is a long-term issue.  Please use the https://github.com/readium/swift-toolkit/tree/swiftui branch to contribute in rewriting the TestApp using SwiftUI.
General

[x] Tab bar for navigating books, OPDS feeds, and about screens
[ ] Localization
[ ] Accessibility

Bookshelf

[x] Show a grid list of books that are ready for reading
[ ] Add a book by URL
[ ] Add a book by selecting a file on device
[ ] Remove one or multiple books

OPDS feeds

[x] Show a list of OPDS feeds
[x] Add a new feed
[ ] Rename a feed
[x] Remove a feed

OPDS Feed Detail

[x] Show list of navigation links for a single feed
[x] Show groups for the feed, with a grid view of publications in the group and a link to view all of the publications in that group.  Also show Navigation links for that group
[x] Show grid view of publications for the feed
[ ] Show Facet filters

About

[x] Show About screen

No more updates for swiftui?

@wisarmy Sorry, I've been busy with a new job and don't have time to continue with this right now. It was coming along though, OPDS is nearly finished, and adding books from a URL or on the device and removing them should be straightforward. I know @gatamar has a PR out for opening books.

Hey there just a heads up I'm going to try to take a stab at integrating the latest changes from main and will also try to get @gatamar's PR over the line. Just FYI in case anyone is also working on this branch ATM.

Sorry guys, I'm unavailable as of now.
Will be happy if my branch is useful in any way.
As far as I remember there were 2 main challenges: SwiftUI navigation and
rewriting some (Promise based?) code to async await. Regarding the first
challenge, I'm still not sure if SwiftUI is mature enough to easily do what
we wanted to achieve.
Regarding the second challenge, sorry for the unfinished code - I know how
to do it now, but have no time :)
On Mon, 22 May 2023 at 21:49, Jordan @.***> wrote:

Hey there just a heads up I'm going to try to take a stab at integrating
the latest changes from main and will also try to get @gatamar
https://github.com/gatamar's PR over the line. Just FYI in case anyone
is also working on this branch ATM.
—
Reply to this email directly, view it on GitHub
https://github.com/readium/swift-toolkit/issues/60#issuecomment-1557862597,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAOSN2O3LM4GCTXZF5RTQSDXHO7LHANCNFSM5YBIHSCQ
.
You are receiving this because you were mentioned.Message ID:
@.***>

@gatamar Thanks for summarizing the issues and taking a stab at it in the first place!
@jpollard-cs Sure, that would be welcome. But since it's complicated to get a full SwiftUI rewrite done in one go, I'm thinking we should change the strategy and do more incremental changes based on and synchronized with main. Here's a proposition:

Make the minimal changes in swiftui to be on par with main, feature-wise (doesn't need to be perfect regarding SwiftUI).
Merge swiftui into main.
Migrate existing Test App Promise/completion-block based APIs to async/await.

Better have plenty of small PRs for individual services/components instead of one huge PR changing this throughout the whole app.

Convert individual UIKit screens/views to SwiftUI, but keeping the navigation and containers as UIKit components

This should be split in at least one PR per modules: bookshelf, opds catalogs, reader. Could be split even further.

Investigate and convert the UIKit navigation to SwiftUI. Probably needs iOS 16+.

This part might need some refactoring in the services, especially related to opening a publication. See the discussions in @gatamar's PR.

Convert the rest of the app to be full SwiftUI-native (removing AppDelegate, etc.).

What do you think?

Apologies if this is the wrong place to ask, but is it possible to convert TestApp to async await with the current streamer.open API and strict concurrency checking? I'm having trouble doing so as Publication is not Sendable.

You might be able to pass it around with an async wrapper if you create a wrapping class or struct with @unchecked Sendable. I didn't try it though.
struct PublicationWrapper: @unchecked Sendable {
    let publication: Publication
}

Be careful as Publication is not thread-safe, you should not call its methods concurrently.

Thanks. My question was unclear. I was referring to your comment on May 23 where you noted the goal to "Migrate existing Test App Promise/completion-block based APIs to async/await."
I'm not trying to share Publications across threads, just create one using structured concurrency. In other words, I want to be able to let pub = await streamer.open(...). I tried to do this using withCheckedContinuation around streamer.open() and it fails with strict concurrency checking.

It should work if you use the technique I described in the previous comment, as long as you don't use any API on Publication concurrently.

I created a PR as a soft restart of this effort: #460. It does not incorporate anything from #240, but that PR would be a great place to continue moving forward.

I created a PR as a soft restart of this effort: #460. It does not incorporate anything from #240, but that PR would be a great place to continue moving forward.

To switch to the SwiftUI based UI, comment out @UIApplicationMain in AppDelegate.swift and uncomment out @main in TestApp.swift.
The TestApp now targets iOS 16, so we hopefully shouldn't encounter many more compatibility issues.


[Feature Request] Clear Reserved List on Recurring Games

Is your feature request related to a problem? Please describe.
My group and I schedule games every few days. I used to do this manually until you added the feature for recurring games. The recurring games feature made it a lot faster, but I still have to clear the reserved list each night once the game reschedules itself.
Describe the solution you'd like
Is it possible to add a checkbox in the Frequency section that has it clear the reserved list after every game?

Good idea! I will have that available soon.

Thank you! I just wanna say thank you for making this! It's made scheduling our games so much easier.


Enabled tenant metrics

Type of change

Enhancement / new feature

Description
Added a label to tenant specific metrics, allowing them to be scrape independently of system-admin metrics and provided sample service monitor to scrape only tenant metrics in docs.
Checklist

[ ] Update/write design documentation in ./documentation/design
[ ] Write tests and make sure they pass
[x] Update documentation
[ ] Check RBAC rights for Kubernetes / OpenShift roles
[ ] Try your changes from Pod inside your Kubernetes and OpenShift cluster, not just locally
[ ] Reference relevant issue(s) and close them after merging
[ ] Update CHANGELOG.md

Lgtm. Should the key be enmasse-tenants to make it more specific?

Yeah it should be. Thanks for spotting that

Fixed some typos that I noticed in the docs so review required again


I feel very confused，I can't find errors

After  configuring dingo and creating a route,I got result by executing php artisan api:routes as follows
+-----------------+----------+------------+------+---------+-----------+------------+----------+------------+
| Host            | Method   | URI        | Name | Action  | Protected | Version(s) | Scope(s) | Rate Limit |
+-----------------+----------+------------+------+---------+-----------+------------+----------+------------+
| api.laravel.app | GET|HEAD | /api/dingo |      | Closure | No        | v1         |          |            |
+-----------------+----------+------------+------+---------+-----------+------------+----------+------------+
and I got result by php artisan route:list
+--------+----------+-----+------+---------+------------+
| Domain | Method   | URI | Name | Action  | Middleware |
+--------+----------+-----+------+---------+------------+
|        | GET|HEAD | /   |      | Closure | web        |
+--------+----------+-----+------+---------+------------+
when I opened my browser and visited localhost:8000/dingo/api, server reponsed 404, I really don't know reasons;
I configured dingo as follows:
API_STANDARDS_TREE=vnd
API_SUBTYPE=laravel
API_DOMAIN=api.laravel.app
API_NAME=LaravelApi
API_CONDITIONAL_REQUEST=false
API_STRICT=false
API_DEFAULT_FORMAT=json
API_DEBUG=true
API_PREFIX=api
API_VERSION=v1

remove API_DOMAIN from .ENV. Works with me after digging in for a while, or look over here https://github.com/dingo/api/issues/570

as per documentation, You need to set either API_DOMAIN or API_PREFIX and not both. here. you are setting up both in env which is causing problem.


 When we toggle back on all rules after the
single line trailing comment we will override the previously turned
off rule as there's no good way to identify it was already on, and
that it needs to be disabled again on the same line we enable all
rules.

The intended behaviour is slightly unclear, and implementing this
feature will take a sizeable refactoring of the disabled rule index
system, which my colleagues and I did not feel comfortable
undertaking.

See further conversation here: https://github.com/jscs-dev/node-jscs/pull/1432#discussion_r32442520

You didn't forget :-), thanks!

:D

At this point only major and CST related bugs will be fixed.

Oh! I didn't realise it was merged into eslint. Wonderful :)


[icons] Sync new Google Material Icons

[x] I have followed (at least) the PR section of the contributing guide.

Sync recently added Google Material Icons. I didn't include 123, Medication Liquid, 6 feet apart icons, those three icons were causing errors in the build script.
Also running yarn docs:mdicons:synonyms didn't seem to have updated the synonyms.js?
Closes #29766

@michaldudak could you please check this before the release?

could you please check this before the release?

Yes, I'm on it. Looks like Google released even newer icons after I created my PR.

We can update the build scripts to use a single blacklist in a separate PR. In this one, however, IMO we should solve the MedicationLiquid problem so that we don't remove an icon that someone can depend on.

@michaldudak MedicationLiquid is failing when trying to extract the paths from the svg string.

@michaldudak What was the issue with that specific icon that was causing the issue?

It was the only icon that used xlink:href attribute. Since we were stripping the xmlns definitions, the svgo parser could not recognize the xlink:href.

Does it make sense in another PR to get rid of one of the ignored lists? I personally feel like consolidating ignored icons into the ignoredIconNames list in download.js makes the most sense so ignored icons aren't downloaded in the first place and when updating the synonyms, it won't pull those synonyms from Google.

Yes, we should. Would you like to prepare a PR with this?

Yes I can do that, you also think consolidating in to the ignoredIconNames in download.js makes more sense?

I don't know what was the original rationale behind multiple lists (perhaps @oliviertassinari could shed some light on it). I suppose we should be able to use just a single one.


Build snap as a confined

Currently this snap cannot be built in a confined way. It's because it uses subprocess to communicate with juju: LP#1941918
It needs to be modified so the snap could be published in a --strict to a snapcraft store.

Imported from Launchpad using lp2gh.

date created: 2021-08-27T19:40:24Z

owner: smigiel-dariusz

assignee: zzehring

the launchpad url

(by zzehring)
The tool now is built as a confined snap. See: https://code.launchpad.net/~zzehring/juju-backup-all/+git/juju-backup-all/+merge/409691


Provide build_info.json file for downstream builds

Provide a JSON file that lists files used in the build.
It will be used by downstream, non-bazel builds. For example, https://fxrev.dev/1100339 is one planned usage of this.
Emboss Issue: https://github.com/google/emboss/issues/152
Pigweed Bug: https://pwbug.dev/359386289
Change-Id: Id33d879cea95d86f6cc7a16cd395a8c1a4380cbf

Based on on how we land this will also file a follow-up issue to keep bazel and this new build_info.json in sync. Even without that, this change will make downstream, non-bazel usage much cleaner. If the file list is changed we just need to update it here and have downstream roll, this is much easier than having to sync changing the downstream's hard coded list with emboss's new actual list of files (or in case of Fuchsia having to coordinate Pigweed and Emboss rolls at the same time).


TensorFlow & DirectML & ROCm  performance and roadmap

The current DirectML library for GPU is more 2x slower than the TensorFlow CPU library.
When DirectML team will improve the performance of the library? Could you share a roadmap of DirectML?
Will DirectML team cooperate with ROCm team (https://github.com/RadeonOpenCompute/ROCm), Intel and Nvidia for improving performance?

We are already working closely with Intel, AMD and Nvidia to improve DirectML's performance and we currently have performance improvements in the pipeline. The performance work that we did for DirectML was originally focused towards inference, which is one of the reasons it is currently slower than the alternatives for TensorFlow.
Another reason is that DirectML has lower operator coverage than ROCm and CUDA at the moment. Because of this, more CPU <-> GPU copies are performed when using a DML device as opposed to the classic GPU device. The next pypi release of tensorflow-directml will have better operator coverage than the last one, so you can expect to see some performance gains depending on your model.
We don't have a roadmap to share at the moment, but we expect performance to get better as we release more TensorFlow pypi packages.

I hope the new version will support multi GPU :)
Is it a chance to get a new release at the end of the year?

We're currently planning work for the next several months, and we'll share more details as soon as it's possible. Here's some thoughts for now, though.
Performance is absolutely in the list of high-priority items; however, it would have been premature to optimize when we still have a functional gap relative to the existing GPU device. As Pat mentioned, the cost of inter-device copies can quickly ruin any chance at decent performance and must be resolved before focusing on individual operator performance. Once we can run all ops (or at least the high-frequency / critical-path ops) in model/script without falling back to CPU we can start to dive into individual operator performance and optimizations for tensor memory layouts. We're already aware of some of these issues and we're working on them.
The functional gap is closing, for sure, but TensorFlow has been adding operators for many years (over 1100 operators in TF1.15!). We won't be able to fill in absolutely everything, but we want to cover the most performance-critical and commonly used operators. We still have more work to do here, but we feel we have sufficient coverage to also start optimizing performance. I'd love to share the exact operators we're planning to implement and a rough timeline for this. Stay tuned.
We do expect to have at least one more release of tensorflow-directml in 2020 (most likely December, if things go well)! Our philosophy is to only push something to PyPI when tensorflow-directml is relatively stable (for a preview) and the included copy of DirectML is stable. We could push out new releases more frequently, but ultimately we think it would cause more harm than good since there are too many moving pieces right now. For devs that really want to test out the latest, there's always the option of building locally. That said, I do realize that building TF is not the most painless process and it's far more convenient to pip install something. :)
We also want to push out DML optimizations more rapidly. The challenge here isn't technical, it's more about ensuring a high bar for quality that users expect from libraries like DML. Two aspects to consider:

DML (like any other built-in Windows component) comes with a fundamental guarantee that the API will not have breaking changes: we cannot make changes to the API or ABI that would break apps/frameworks. This compatibility guarantee is obviously a good thing, but it does mean we have to be extra cautious when introducing new API to DirectML since it's effectively permanent. It can be a costly mistake to add a DML API that only serves TF, for example, but not ONNX Runtime or other frameworks.
We don't want dozens of unstable versions of DML floating out in the wild. This fragmentation would be bad for everyone, and apps/frameworks won't have the best performance if they can't easily roll forward to a new version of DML. It may sound unlikely, but in the past applications have relied on bugs in Windows components that prevented the component from fixing those bugs (see #1 above). Long-term dependencies on "preview" builds of DML are dangerous, so we try to avoid it entirely.

We've actively been working on additional ways to balance the conflicting needs of higher frequency updates and reliability. We do appreciate the patience and the enthusiasm on our efforts with DML and TF! We're working hard to deliver on this.

I'm ready to help your team with testing after your internal tests :)

Will DirectML team cooperate with ROCm team (https://github.com/RadeonOpenCompute/ROCm), Intel and Nvidia for improving performance?

We are working closely with multiple IHV including AMD on the performance of DirectML in TensorFlow training scenarios. As Justin was saying we've been making steady progress on this front and will continue to release updates to the community as they're available for broader usage, so stay tuned.

so at last, ROCm is faster then direct ML? what should i preffer for amd integrated GPU?......direct ML or ROCm?

Hey @talhazafarjutt, have you tried our latest package in April?
We're nearing our next build in the next few months. So if the April's code is still lacking, stay tuned.
Also, if you can share a repro and more detail on your ROCm configuration with the target AMD hardware, that would be very helpful too. It's hard to understand what problem you're referring to without any detail so far.

Hey @talhazafarjutt and @YuriyTigiev, have you tried our latest package in April?
We're nearing our next build in the next few months. So if the April's code is still lacking, stay tuned.
Also, if you can share a repro and more detail on your ROCm configuration with the target AMD hardware, that would be very helpful too. It's hard to understand what problem you're referring to without any detail so far.

I sold my pc.


fix: ensure click events are triggered on button edges

Fixes #317.
To fix the issue, all scale transforms are now applied to child elements of buttons/links rather than the interactive elements themselves. This ensures that hit areas remain consistent during transforms.
One additional case that needed to be handled is when elements become larger on hover, increasing their hit area. If the user moves their mouse to the edge of the enlarged hit area and then attempts to click, the click event isn't fired. To fix this case, this PR also introduces a set of CSS utils called increaseHitAreaForHoverTransform which has a class for each transform value, e.g. increaseHitAreaForHoverTransform.grow. This class is applied to the containing button/link element so its hit area becomes larger when it is active. This is done using an absolutely-positioned pseudo element that sits outside the bounds of the original hit area using the same scale as the nested element.
I resisted the urge to create an abstraction for this since it's not clear to me it would be an improvement, running the risk of obfuscating what's happening in the DOM. We may revisit this in the future.

awesome fix for this! 🤠
i would also add the border radius of the inner buttons to the containers to avoid this:


Implement MultipleGetObjects method

Reference: algolia/algoliasearch-client-python#379
Implement method on the client that lets the user retrieve multiple objects from multiple indices.

Closing this:
Issue solved #521


data view params are not being passed issue fixed

Should make similar changes in other SDKs as well since we're using similar logic there.


docs: Typos in MD

Signed-off-by: Fernando Miguel<EMAIL_ADDRESS>Description
fix typos
How Has This Been Tested?

[ ] I have updated at least one of the examples/* to demonstrate and validate my change(s)
[ ] I have tested and validated these changes using one or more of the provided examples/* projects

[ ] I have executed pre-commit run -a on my pull request

This PR is included in version 19.6.0 :tada:


Resize commands are triggering BufEnter event

Issue
I notice if we have some buffer with a BufEnter autocommand, like
au BufEnter term://* startinsert

When we use any resize command the BufEnter is triggered.
As far as I could investigate it seems to be caused by wincmd h|j|k|l| on lua/smart-splits/api.lua.
I tried to solve it preppending a noautocmd  on the beginning of wincmd, but for somereason it not works on this line lua/smart-splits/api.lua#L53 (a neovim bug maybe).
To reproduce
" mini.init.vim
noautocmd e aaa
noautocmd vs bbb

call plug#begin()
  Plug 'mrjones2014/smart-splits.nvim'
call plug#end()

map <space> :lua require('smart-splits').resize_left()<CR>

lua << EOF
require('smart-splits').setup({})
EOF

$ nvim -u mini.init.vim

When space is pressed in normal mode a message with aaa and bbb is displayed.
Additional info
" PlugSnapshot
silent! let g:plugs['smart-splits.nvim'].commit = 'c8d80d90f3c783ac0ea21f256c74d541a7b66a72'

" nvim --version
NVIM v0.8.0-1210-gd367ed9b2
Build type: RelWithDebInfo
LuaJIT 2.1.0-beta3
Compilation: /usr/bin/gcc-10 -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=1 -DNVIM_TS_HAS_SET_MATCH_LIMIT -DNVIM_TS_HAS_SET_ALLOCATOR -O2 -g -Og -g -Wall -Wextra -pedantic -Wno-unused-parameter -Wstrict-prototypes -std=gnu99 -Wshadow -Wconversion -Wdouble-promotion -Wmissing-noreturn -Wmissing-format-attribute -Wmissing-prototypes -Wimplicit-fallthrough -Wvla -fstack-protector-strong -fno-common -fdiagnostics-color=always -DINCLUDE_GENERATED_DECLARATIONS -D_GNU_SOURCE -DNVIM_MSGPACK_HAS_FLOAT32 -DNVIM_UNIBI_HAS_VAR_FROM -DMIN_LOG_LEVEL=3 -I/home/runner/work/neovim/neovim/build/cmake.config -I/home/runner/work/neovim/neovim/src -I/home/runner/work/neovim/neovim/.deps/usr/include -I/usr/include -I/home/runner/work/neovim/neovim/build/src/nvim/auto -I/home/runner/work/neovim/neovim/build/include
Compiled by runner@fv-az457-787

About the neovim I found out how to reproduce, so I created an issue on neovim repo https://github.com/neovim/neovim/issues/20450 .
Once it is fixed, do you think add a noautocmd on all vim.cmd calls could cause some undesired side effect?

Instead, I think a better approach is to just set eventignore before starting any smart-splits stuff, then reset it on complete. I can make the ignored events list customizable.

@alanoliveira does a246c4f7b386c435a286b18bcdd0fd4dfb929ab5 fix it for you?

Thank you very much, that was fast!
Could you make it run only for resize events?
Its because when I move to a terminal buffer I want it to run a startinsert, but when I'm just resizing I don't want it.

Yup, that makes sense, my mistake. Done.

Like a charm! thank you! :bow:


Added seconds functionality fix some minor bugs

One feature addition and some other bug fixes
Features
Added seconds

Second options now exist for all three timepicker interfaces.
Added needed functions and classes.
Modified functions that involve all aspects of the time picker (such as addAll() or time()) to now also involve the seconds.
This included making changes to the separators to distinguish between the HH : MM and MM : SS separators.

Bugs
Separators

The separators will now be added automatically when manually adding components to the spin timepickers.
This includes both the hour/min and min/second separator.

Time function hour reporting

If the the hour was setup using the addHours12() or addHours24() functions, the time() function would not properly report the time.
This was fixed by setting the self.hour_type value to the correct constant in the addHours12() or addHours24() functions

Hi, Thanks for creating this pull request, I am a bit busy this month, I'll come back and look into this when ever I get time.

No worries! I did it for myself and have the changes locally where I need
them, but thought it could be useful to others. Cheers!
On Tue, Jun 25, 2024, 19:34 PaulleDemon @.***> wrote:

Hi, Thanks for creating this pull request, I am a bit busy this month,
I'll come back and look into this when ever I get time.
—
Reply to this email directly, view it on GitHub
https://github.com/PaulleDemon/tkTimePicker/pull/10#issuecomment-2190355878,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AIUKU7R6GMFSIFR53ZEGEXLZJILC5AVCNFSM6AAAAABJULBHG2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCOJQGM2TKOBXHA
.
You are receiving this because you authored the thread.Message ID:
@.***>


pull request for e2e test at 11/13/2016 02:15:10

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

optest/docs/updated_at.md
:white_check_mark:Succeeded

Details

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.