FancyZones layout corrupt data

ℹ Computer information

PowerToys version: 0.25.0
PowerToy Utility: FancyZones
Running PowerToys as Admin: Yes
Windows build number: [run "winver"] 20H2

📝 Provide detailed reproduction steps (if any)

Window + `

✔ Expected result
Zone editor should open
❌ Actual result
Zone editor opens but reports corrupt data and my custom layout is gone :(
📷 Screenshots

@ajskew
we have a bug that may cause a layout to have invalid data.
Can you try to recreate it?

@enricogior
Just tried and issue no longer reproducing. And in case it helps, I'm still on v0.25.0.

Closing the issue in favor of https://github.com/microsoft/PowerToys/issues/5027 we need to change the current implementation to prevent the problem to happen.


DBC22-783: backend linting setup

Recreated this PR from https://github.com/bcgov/DriveBC.ca/pull/109.
This PR added backend linting capability by applying pylint on python code.
Please configure the dev IDE to enable pylint on VS Code or PyCharm.
How to Install Pylint in PyCharm:
pip install pylint
use "which pylint" (for mac) or "where pylint" (for windows) to get the Pylint installation path.
navigate to File->Settings->External tools.
Enter the installation path of pylint in the field 'Program', enter data for all other fields as desired, i.e., Arguments: the .pylintrc file path in the backend python code, Working directory: to the backend python code root directory.
right clicke on the python file, select Open in-> Terminal
Run command 'pylint fileName.py'
The .pylintrc file is generated by using command "pylint --generate-rcfile>.pylintrc", to make the linting rules customizable.
How to linting python in VS Code:
install pylint from extensions in VS Code.
pylint can be enabled/disabled by right click on the settings of pylint.
VS code has the ability to auto detect customizable .pylintrc file in the backend python root directory.
When open or save a changed python file, pylint will be reporting errors or warning in the code based on the default linting rules and customized linting rules.

The pylint plugin can be used for intelliJ IDEs.
After installation, restart and set Path to pylintrc e.g. /Users/ray/PycharmProjects/DriveBC.ca/src/backend/.pylintrc and hit apply/OK. There will be a new pylint tool windows available to run scans on single file, module or entire project. As well, real-time scans should be on by default.
Feel free to modify or make suggestions on the config.


smarter layout for purple nodes

When we click on an orange box node and display its components as purple nodes, they are spaced evenly around the circle, e.g., if there are three of them then they are spaced 120 degrees apart. This looks nice. But we can be even smarter. Consider this display:

The incoming averageLifespan link is very close to the outgoing timeRetrieve link. We can improve the layout by adjusting the phase of the purple nodes (defining "phase" as the angle of the topmost node relative to vertical) so that the incoming arrow from the box node falls exactly between two of the purple nodes.

Newest version of demo2.html should fix this version

Fix this issue*


V0.13.0rc3

Refactored and improved TLV API and handling. Implementation is also a bit more efficient
Improve structure of tests

Codecov Report

Merging #15 (a62d4c4) into main (0fce08f) will increase coverage by 0.24%.
The diff coverage is 96.57%.

@@            Coverage Diff             @@
##             main      #15      +/-   ##
==========================================
+ Coverage   96.57%   96.81%   +0.24%
==========================================
  Files          59       65       +6
  Lines        5027     5250     +223
==========================================
+ Hits         4855     5083     +228
+ Misses        172      167       -5

Flag
Coverage Δ

unittests
96.81% <96.57%> (+0.24%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

spacepackets/cfdp/__init__.py
100.00% <ø> (ø)

spacepackets/ecss/pus_verificator.py
87.23% <ø> (ø)

tests/cfdp/pdus/test_file_data.py
100.00% <ø> (ø)

tests/cfdp/tlvslvs/test_lvs.py
100.00% <ø> (ø)

spacepackets/util.py
91.57% <50.00%> (-1.96%)
:arrow_down:

spacepackets/cfdp/pdu/file_directive.py
93.75% <66.66%> (-0.66%)
:arrow_down:

spacepackets/cfdp/pdu/file_data.py
93.07% <75.00%> (-0.63%)
:arrow_down:

spacepackets/cfdp/pdu/header.py
93.04% <75.00%> (-0.40%)
:arrow_down:

spacepackets/cfdp/tlv.py
98.09% <96.00%> (+4.16%)
:arrow_up:

spacepackets/cfdp/lv.py
100.00% <100.00%> (ø)

... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0fce08f...a62d4c4. Read the comment docs.


Publishing APK to Google Play doesn't list current builds, only option is upload APK.

I have connected to the Google Play store but there doesn't seem to be a way to publish an APK from a build completed in appcenter. It is implying that I have to download the APK and the uploaded it back to be able to push it into the app store. What would be the benefit compared to downloading an uploading to Play?
Cheers
Steve

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: f8ccb786-5f74-9c47-f6fa-a22720f823ad
Version Independent ID: 3185af63-60df-aa2b-1d8c-b3db0ca3ad8c
Content: Upload a Build to Distribute via App Center - Visual Studio App Center
Content Source: docs/distribution/uploading.md
Service: vs-appcenter
GitHub Login: @JoshuaWeber
Microsoft Alias: JoshuaWeber

@stevehurcombe I'm glad you found your solution. I sent a link to the PM to see if a doc update is warranted.
In the meantime, App Center support is provided directly from within the App Center portal. Any time you need help, just click the blue chat button in the lower-right corner of any page and our dedicated support team will respond. For additional information, see the App Center Help Center.


Pinocchio 2.0

@jcarpent is preparing a major change of API. Here are some suggestions to prepare the release.

initial candidate release should be proposed as 1.99.x
propose a guideline to convert developments based on 1.3 to 2.0
don't move master to a 2.0 version until the main dependencies of Pinocchio have given their agreement.
during the transition phase, pinocchio/devel will be in 2.0, while pinocchio/master will be in 1.3. Bug fixes can be pushed to pinocchio/master during the transition phases. Parallel developments should enforce that the same bug fixes are pushed in pinocchio/devel.
as the master branch will diverge from the devel branch, we will have to revert possible commits in master before merging it to devel.
we shoul wait for a consensus among the users of Pinocchio before merging master to devel.

It is suggested to developers using Pinocchio to start moving their devel branch to API 2.0 when it is officially released. If possible, we would like to set up a dead line for the transition phase. Pinocchio/master will be merged to version 2.0 after this deadline.
In summary, here would be the agenda:
0. update pinocchio/master to the latest commit.

merge new API in pinocchio/devel and tag it 1.99.x
2.a validate pinocchio/devel and release it as version 2.0.0 when solid enough.
2.b during this period, master is staying in 1.3.x but can be added with bug fixes
once 2.0 is officially released, the software depending on pinocchio should move their devel branches to pinocchio/devel
at a given date (consensually defined), pinocchio/master is merged to pinocchio/devel (after reverting possible head commits). Pinocchio 2.0 becomes the official version.

From my side, I will merge the current devel branch into 2.0.0 to have an aligned history.
It would be nice to not modify the current devel branch in order to not add more stuff in my todo list.
The PR can remain open and would be merged in the new version by their authors.

I can take care of the robotpkg part

When merging devel, please follow the guidelines I described upper (or discuss it beforehand).

Yes, this is pretty standard. No worry!

By the way, I will release a new version of Pinocchio before proposing 2.0.0-beta.
This will add the last fixes already present in the current devel branch.

It was propose to release in 1.99.0 for the candidate.

1.99.0 or 2.0.0-alpha makes no difference in terms of semantics, but it does for the checking of the version.
When using the macro PINOCCHIO_AT_LEAST_VERSION(2,0,0), which what we have to use to ensure at compile time the current version of Pinocchio, is the correct of ensuring that we are the correct version, not PINOCCHIO_AT_LEAST_VERSION(1,99,0).
By the way, this is also how Eigen works.
So I will use 2.0.0-alpha for the pre-release version.

Is there currently a target date for this release?

I hope by the end of the next week.

As release 1.3.2 is buggy, I will make a new one called 1.3.3 with the fix.
Thanks to @aelkhour for raising this issue.

I've just opened a PR #569.
This PR should normally compile on Mac OS X and ubuntu 14.04. I did try on other systems yet.
I will test it on the Gitlab of LAAS.
I hope that all the algorithms will continue to work with most of the projects relying on Pinocchio.

I've just merged #569.
I also added the tag 2.0.0-alpha for this pre-release version

I confirm it is building on ubuntu 16.04


Step 3 - Main text

Add article and aside element.
Add style for each of elements.

Merged closed the issue.


HACS Installation no longer working

🐛 Describe the bug
Since Update to 1.5.4 the Integration can no longer correctly be installed by HACS. I got notified about an update today and it wants to downgrade to 1.2.0, and the newest available version is 1.4.1

💥 When did the bug occurred.*

[x] Installation / First-run
[ ] Configuration
[ ] Other

👣 To Reproduce
Steps to reproduce the behavior:

Go to 'HACS > Integrations > RKI Covid'
Click on 'Install this Repository in HACS'
See versions listed

🧐 Expected behavior
Except all Versions from Github to be available including previously available version 1.5.3 und new Version 1.5.4
💻 Versions (please complete the following information):

OS: Raspbian Buster 64bit with Homeassistant 2021.8.0 in Docker
Browser: Fails in all Browsers the same way

🗄 Logfiles (Configuration > Logs)
Could not find any error in log regarding installation and retreiving of versions

Issue has been reproduced on FreeBSD Truenas HACS Core installation.

Same for me on Debian 10 Supervised.
core-2021.8.5
supervisor-2021.06.8

Sorry, updating old releases isn't a good Idea. HACS is not searching for the newest version, it is just using the last updated 🤦


feat(filesystem): implement Google Drive source

Towards: https://github.com/dlt-hub/verified-sources/issues/308
I took the original implementation, moved it into the dlt repo and fixed several small problems, which were preventing the driver from working with Google Drive. Most of the original driver code is left untouched - even though I think some parts of it are not needed (file uploading, deleting, etc.)

There is a bunch of failures, but at the first glance they do not seem related. Checking...


Release cookbook v2.3.1?

I'm experimenting with the unreleased 2.3.1 version of this cookbook and it seems to be working pretty well with filebeat 6. Do you know when you plan to publish it?

@benthemonkey Released cookbook version v2.4.0.


Use search.$ in filter will result in Call stack exceeded error if the objects have properties that self reference

Create an object with properties that self-reference. Running a filter with search.$ as ng-model of an input will result in call stack exceeded fairly easily.

This is Won't fix / not core as explained in https://github.com/angular/angular.js/pull/6319#issuecomment-48421085


Docs: Corrected a typo in Maximum open connections description

Summary
Change typo in "Maximum open connections" option description from idle to open

Hello @DragorWW,
Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.
Per the Mattermost Contribution Guide, we need to add you to the list of approved contributors for the Mattermost project.
Please help complete the Mattermost contribution license agreement?
Once you have signed the CLA, please comment with /check-cla and confirm that the CLA check is green.
This is a standard procedure for many open source projects.
Please let us know if you have any questions.
We are very happy to have you join our growing community! If you're not yet a member, please consider joining our Contributors community channel to meet other contributors and discuss new opportunities with the core team.

/check-cla

/check-cla

Thanks, @DragorWW! We can move forward with your PR once you sign the CLA.

This PR has been automatically labelled "stale" because it hasn't had recent activity.
A core team member will check in on the status of the PR to help with questions.
Thank you for your contribution!

Hi @DragorWW! I wanted to follow up on this. We really appreciate your contribution - once the CLA is signed we can merged this PR.

This PR has been automatically labelled "stale" because it hasn't had recent activity.
A core team member will check in on the status of the PR to help with questions.
Thank you for your contribution!

Fixing docs issue via https://github.com/mattermost/docs/pull/6200


Censored text is still viewable

Describe the bug
The portal currently has the feature of scrubbing text from a request for privacy purposes. For example:

While the << ... >> scrubbing is present in the portal UI, the text is still visible on the request's RSS/XML feeds.

Example Affected Request:

https://uipa.org/request/correspondence-email-1/
https://uipa.org/request/correspondence-email-1/rss/

Expected behavior
Request text is not only scrubbed in the Web UI, but also in the RSS/XML Feeds.

This might not actually be an issue:

Hmm…I am not sure that is something that needs to be fixed.  In the end, those e-mail addresses would be disclosable as part of the public records.  If the system were disclosing the user’s name (when that person did not want to be identified), that would be a different story.  But I don’t think the requester’s name is disclosed in the RSS feed from what I saw of the screenshot.  In fact, I question why it scrubbed the e-mails at all because now you cannot tell whose correspondence has been requested, so someone searching later would not know what had been requested previously—unless they clicked on the attachment that had the responsive records.

If it's highly desirable to give users of UIPA.org confidence in what the system does then I think both the current behavior and the desired behavior should be clearly stated to prevent misunderstanding and unmet expectations.
Then if the current behavior isn't what's desired, further action should be taken to change the current behavior.

After talking to Brian, we should redact the xml feed as well


Feature/allow static raft cluster members

Add feature to allow the manual configuration of Raft Cluster Members
What?
Allows the static definition of members of the Raft cluster using the vault_raft_cluster_members variable.
e.g.
vault_raft_cluster_members:
  - peer: vault-host-1
    api_addr: https://vault-host-1:8200
  - peer: vault-host-2
    api_addr: https://vault-host-2:8200
  - peer: vault-host-3
    api_addr: https://vault-host-2:8200

Note: This variable defaults to the selecting hosts using the automatic method of selecting all hosts in the vault_raft_group_name group
Note: Also fixes setting no_proxy environment variable for API reachable check
Why?
Currently Raft cluster membership is controlled using vault_raft_group_name which will dynamically select hosts that are members of the vault_raft_group_name group. This means, however, that the role must be run against all the hosts of a cluster at once.
The ability to run the role against single members of the cluster is important for staged rollout etc.

What about running ansible with the „—limit“ parameter in order to control which node should be configured?

What about running ansible with the „—limit“ parameter in order to control which node should be configured?

@FalcoSuessgott This issue with this is that the current approach requires host vars from the other members of the cluster which aren't accessible when you use --limit. When you use limit the playbooks can only access the hostvars of hosts included by the limit

@lanefu Is something missing here to get this reviewed?


Not working at all

Hi,
I have a problem with this plugin which was working for me just fine. It's not working anymore since I have created a folder in my assets/ folder which I was targeting with this plugin as a destination folder. The folder structure was:
/assets/images (src)
/assets/images-to-min (dest)
originaly the dest folder was in:
/images
The configuration of the plugin is :
responsive_images: {
myTask: {
options: {
sizes: [{
name: "",
width: 320
},{
name: "medium",
width: 640
},{
name: "large",
width: 1024,
}]
},
files: [{
expand: true,
src: ['**/*.{jpg,gif,png}'],
cwd: 'assets/images/',
dest: 'images/'
}]
}
},
watch: {
		images: {
			files: ['assets/images/**/*.{jpg,png,gif}'],
			tasks: ['responsive_images']
		}, //end of watch

	}

Well it is very strange problem because I am positive everything was working fine until I created that folder in the same directory as a the source image folder. When I retracted my code to the original version it still didn't work until I erased that new folder. Than it worked for a while and than zip.
I was wondering if this plugin is caching anything? Than it would be possible to purge the cache and it might work again.
Thanks

After more testing it seems to be a problem with the grunt-contrib-watch as I am able to run this task manually.

The src looks slightly wrong.
src: ['*/.{jpg,gif,png}'], should be src: ['**/*.{jpg,gif,png}'],

Did fixing the config solve the problem?
I'd like to close this issue please.


refactor(mdc-chips): Make MatChipTextControl publically available.

Make the MatChipTextControl class available for implementation by other classes, so input fields other than input elements - eg. custom divs - can be used with mat-chip-grid (which currently assumes a matChipInputFor  is provided).

This seems reasonable to me. Question for @jelbourn should we also expose the src/material/chips version of `MatChipTextControl``?


feat(parser): allow using custom parser.

This is nice and a good idea!
I'm gonna fix the conflicts (probably because of the new directive), and rename Parser to TranslateParser please, and then I'll merge it.

see https://github.com/ocombe/ng2-translate/pull/345 for DefaultParser


[BUG] Incompatible with Better Totem of Undying

When I install this mod into my modpack where several other mods are using cloth config I get this message:

If I remove or add older cloth config version I get this message:

If I remove Better Totem of Undying or Forgotten Graves I get no error and the game loads. Not sure which mod is causing the issue.

Thanks for the report!
I'm pushing out an update to fix this and it should be on Modrinth and CurseForge within the next ~10-15 minutes.
It'd be appreciated if you could let me know if the update fixes your issue, thanks!


[bug]: have two video cards, always defaults to amd card

Is there an existing issue for this?

[X] I have searched the existing issues

OS
Linux
GPU
cuda
VRAM
6GB
What happened?
I commented out lines 168-171 and line 174 in the install script to get invoke AI to install and not try to use my AMD video card as it is a 590 and AMD has decided to drop ROCm support for it

during the install it fails at line 201

with "hipErrorNoBinaryForGpu: Unable to find code object for all current devices!"
I'm just not finding where else I need to comment out so that I can use my nvidia card... I'm presenting this as a bug as I know having two video cards is an edge case but having the ability to select which video card to run on would be nice
Screenshots
No response
Additional context
No response
Contact Details
<EMAIL_ADDRESS>

I had this trouble with a nvidia card but amd cpu had an apu,  i think they can fix it by changing the lsmod command to only using amd is a nvidia card isnt present.
Eg like i did with lshw in my script for unraid
if [[ $(lshw -C display | grep -i vendor) = AMD ]] && [[ $(lshw -C display | grep -i vendor) != NVIDIA ]]  ; then

I got past the configure_invokeai.py issue as it was renamed Configure_invokeAI.py and that case issue was making it not show up for the script

found the issue I ran
inxi -G and got
Graphics:
Device-1: AMD Ellesmere [Radeon RX 470/480/570/570X/580/580X/590]
driver: amdgpu v: kernel
Device-2: NVIDIA TU106 [GeForce RTX 2060 Rev. A] driver: vfio
v: N/A
Device-3: AMD Cezanne [Radeon Vega Series / Radeon Mobile Series]
driver: vfio-pci v: N/A
Device-4: Linux Foundation USB Webcam gadget type: USB
driver: snd-usb-audio
Display: x11 server: X.Org v: 21.1.6 driver: X: loaded: amdgpu,nvidia
unloaded: modesetting,nouveau dri: radeonsi gpu: amdgpu
resolution: 1920x1080~60Hz
API: OpenGL v: 4.6 Mesa 22.3.1 renderer: AMD Radeon RX 590 Series
went to /etc/mkinitcpio.conf and added nvidia in before vfio in the MODULES section rebuilt initramfs ( sudo mkinitcpio -P for me it might be update-initramfs -u for you ) rebooted and ran inxi -G again
Device-2: NVIDIA TU106 [GeForce RTX 2060 Rev. A] driver: nvidia
v: 525.60.11
ran invokeAI and it picked up my video card
hopefully this helps someone else get it working


feat(helm): Move requirements.yaml to Chart.yaml

To move requirements.yaml to Chart.yaml as a recommended way in helm 3.
Bump chart apiVersion to v2, and clean old attributes e.g. gotpl and
tillerVersion.
BREAKING CHANGE: This is breaking change as helm 3 must be used.
I have scanned the code base (docs, ci, etc), seems like helm 3 is recommended.
If it's the case, this PR is not really breaking change.
Closes #10478
Signed-off-by: Tam Mach<EMAIL_ADDRESS>feat(helm): Move requirements.yaml to Chart.yaml and set min. helm version to helm 3

Coverage decreased (-0.01%) to 36.919% when pulling 61da68076fe57d2f7003e5bdcd55dc64dba7dcb4 on sayboras:feature/helm-3 into 082e87932312311f50f6d165905b792ff729f41d on cilium:master.

test-me-please

We do presently state that Helm 2 can be supported in the install guides. This change would require modifying those guides to exclude Helm 2 support.
Here's one example: https://docs.cilium.io/en/v1.8/gettingstarted/k8s-install-etcd-operator/#deploy-cilium-cilium-etcd-operator


Add ability to pull trivy image from a mirror

Hi team,
I'd like to experiment this action for my company, but I'm facing the following issue :

the action builds a Docker image and starts by pulling the base image from ghcr.io
the pull is blocked because our company network is behind a proxy and our system team doesn't want to open the gates to all ghcr.io domain (which I can understand)

A possible solution for us would be to mirror the base image ghcr.io/aquasecurity/trivy to our internal registry, but we would then need the first line of the Dockerfile to be configurable to have something like this :
# Configurable base image with default value
ARG trivyBaseImage="ghcr.io/aquasecurity/trivy:0.31.2"

FROM ${trivyBaseImage}
...

And then adapt the action itself to support this new argument.
Would it sound like an acceptable feature ?
Thank you,
Adrien

This actually looks harder than I first thought, as the action.yaml may not support this.

hi @adriil - thanks for sharing this. I didn't know about this limitation of GitHub Actions. Would this help in anyway if we could adapt to use it with the Trivy Action somehow? https://aquasecurity.github.io/trivy/v0.31.3/docs/advanced/air-gap/

Hi @simar7
I think air-gap faces the same limitation as trivy is needed to download the database and ultimately run the scan if I understood. The only way I see to achieve this is by installing trivy on our runners (or runners hosts) directly, but then this action wouldn't be necessary anymore and we would miss the point of not having to care about the client at all.

Yeah I see your point. The best alternative I can think of is that you fork this action and modify the base image, while keeping it up to date with the upstream changes (this action repo). As much as I wish you wouldn't have to fork this repo, I don't see a way out considering the pull is blocked and GitHub does not allow passing custom build args.

I agree, forking the repo sounds like a suitable workaround until GitHub supports --build-arg. They clearly must add it :)
Thank you for your support.


feat: remove file type validation

File endpoint now supports more formats than just JSON/JSONL.

Released in version 2.3.0.


Mysterious codegen errors when trying to render map in changelist

Hello!
I'm trying to implement this app in my own project, to give my admin users a satisfying overview of all the location-based entities we maintain in our database.
I will also lead with the fact that I am using the GeoItem class in what may be a non-standard way, attaching it to an entity with a one-to-one key to a separate Location model (as I wish to see the map in admin pages for the prior entity).
The map renders like a charm in the individual change form for each entity, but I receive some strange errors in my client that seem to indicate that the JS is being generated incorrectly for the changelist-view map.
The first one I receive is Uncaught SyntaxError: Unexpected token ')' (at (index):993:15), and clicking through I see the following:

This seems to indicate to me that the recommended default value of the geomap_latitude/longitude properties (i.e., '') is appearing directly in this generated code. Changing this to other values like test or NaN seem to confirm this, but somehow the issue appears elsewhere (potentially in entities with no/null location).
The second error is Uncaught TypeError: map.addOverlay is not a function at (index):14861:5, to which I have no answer. I don't know whether it's correlated to the first one or not.
I see that this project is still in active developent; if possible, I would love to hop on a call with a developer and figure out the issue, and I would be happy to follow up this issue with detailed comments explaining what happened, for anyone else who might encounter these problems in the future.
Thank you, and please let me know if I can supply any more information.

This seems to indicate to me that the recommended default value of the geomap_latitude/longitude properties (i.e., '') is appearing directly in this generated code. Changing this to other values like test or NaN seem to confirm this, but somehow the issue appears elsewhere (potentially in entities with no/null location).

Thanks for your bug report, a fix for the case of an objects with missing coordinates will be released.
For a quick fix, you can add a filter to remove such objects from the changelist in the Django admin.
The implementation of the geomap_latitude / longitude properties given in the readme is just an example. You can implement any logic there according to the scheme of your models.

The second error is Uncaught TypeError: map.addOverlay is not a function at (index):14861:5, to which I have no answer. I don't know whether it's correlated to the first one or not.
I see that this project is still in active developent; if possible, I would love to hop on a call with a developer and figure out the issue, and I would be happy to follow up this issue with detailed comments explaining what happened, for anyone else who might encounter these problems in the future.
Thank you, and please let me know if I can supply any more information.

For this error, it is better to create a separate issue and provide additional information, as suggest CONTRIBUTING.md

This seems to indicate to me that the recommended default value of the geomap_latitude/longitude properties (i.e., '') is appearing directly in this generated code.

New in version 1.5
If at least one of geomap_longitude/geomap_latitude properties returns an empty string, then the corresponding object will not be displayed on the map. For example, objects that do not have coordinates or some kind of "secret" objects from your database.
Please update your project to version 1.5 of the library and and check for error in context of your project.
Please post your results here.

Hi Vitaly, thanks so much for the quick turnaround. I'm thrilled to say that, with a little extra finagling on my models (in particular the two properties), I was able to get the map to render in my changelist, and to respond to changes in the queryset filter via the URL params. Now to get to playing with all the other options. :)
Thank you!

Now to get to playing with all the other options. :)

Good luck, and write here about the problems that you will meet. It is advisable for each problem to create a separate issue and follow the recommendations from CONTRIBUTING.md
Can I consider the problems described in this issue solved in the version of the library 1.5 and close this topic?

Let's assume the problem is solved.


Moving around by arrow key without unfold any regions

The region folding feature that vscode provide is an awesome feature and I really like to use it. But there is one thing I feel uncomfortable, when using it, is that when I move around the file by my arrow key or (j, k, h, l in vim) it automatically unfold every region I go through. That's so annoying. Are there any ways that the regions only unfold itself when I want to like pressing "ctrl + shift + ]"?.

/duplicate of #63972


cloud: Abandon fork-join parallelism for thread-per-region

Before this patch the cloud provider code was mostly single-threaded,
but would fan out multiple threads when interacting with the
underlying provider.  This approach had two problems: First, the
performance was limited by the slowest region in the slowest cloud
provider.  Second, this approach added a bunch of unnecessary
complexity.
Instead, this patch makes a thread per region, both simplifying the
code, and making it feel snappier.

I'm super excited for this

Awesome!
Btw, this patch isn't the full solution I've been talking about for a while.  I've decided to break it into smaller more manageable pieces.  The rest of it will be trickling out over the next month or two.

Oh also note, the patch adds a bunch of thread management code that is hard to cover.  That's why the code coverage declined.  I don't think it's possible to write meaningful tests for this stuff, so I haven't.


Code gen

I wonder how this performs on code gen

I agree, needs to crawl all previous PRs and create a buffer of thoughts on past solved issues / problems perhaps suggesting which code files to look into or search for.
I prefer vector db of solutions rather than buffer of thoughts but whatever.
Needs to just consume an entire .git repo hope they can add that integration and compare and bench on swe-bench


Add driver and Python-based XVC server for Debug Bridge

Hello! I have found that debugging with ILAs and VIOs are still quite handy for developing overlays, so I ported the XVC server in XAPP1251 to the PYNQ library for an easy access to the debuggers through a Debug Bridge in AXI to BSCAN config.
I have tested it with a Zynq-7000 devboard with USB RNDIS connection. It could achieve a reasonable speed for simple debugging with >500Kb on the network interface, at the cost of one core maxed out for polling during transmissions.

Codecov Report

Merging #1363 (6666ec0) into image_v2.8 (0cdf6b9) will decrease coverage by 0.95%.
The diff coverage is 11.51%.

@@              Coverage Diff               @@
##           image_v2.8    #1363      +/-   ##
==============================================
- Coverage       46.49%   45.54%   -0.96%
==============================================
  Files              28       29       +1
  Lines            4955     5094     +139
  Branches          971      996      +25
==============================================
+ Hits             2304     2320      +16
- Misses           2594     2717     +123
  Partials           57       57

Impacted Files
Coverage Δ

pynq/lib/debugbridge.py
10.86% <10.86%> (ø)

pynq/lib/__init__.py
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0cdf6b9...6666ec0. Read the comment docs.


Pokemon card extention is added

Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes:  #585

Type of change
Addition of a new extension

[x] New feature (non-breaking change which adds functionality)

Checklist:

[x] I have made this from my own
[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] My changes generate no new warnings

ATTACH SCREEN-SHOTS / DEPLOYMENT LINK
https://github.com/Sulagna-Dutta-Roy/GGExtensions/assets/83546205/8ec0834e-5977-46b4-a9ba-1167e88a2125

Okay I will make a new Pr for this


(ISO 6709) PDF: code style font size should be identical as that of surrounding text

In list items, font size should be same as surrounding text:

In EXAMPLEs, the font size should be the same as surrounding text:

From: https://github.com/metanorma/iso-6709/issues/30

Fixed.

Confirm fixed! Thanks!


Buy Now Button bug fix

Buy Now button wasn't displaying text for some locales since the text was overflowing on the button's content area.
Solution:
Make the size of the unbranded button fit the actual text. So, now size varies according to the text.

Let's add a max-width: 100% too?


Add pull request template

I have added pull request template for better code validation and organization.
Closes #30

Thanks @Vinitvh!


New package: Atari800Win.PLus version 4.0

- [X] Have you signed the Contributor License Agreement?

[X] Have you checked that there aren't other open pull requests for the same manifest update/change?

[ ] Have you tested your manifest locally with winget install --manifest <path>?
[X] Does your manifest conform to the 1.6 schema?

Resolves #143431

Microsoft Reviewers: Open in CodeFlow

For moderators
This account is automated by Github Actions and the source code was created by CoolPlayLin. If you have any questions about any pull request, don't hesitate to ping Exorcism0666.

[!warning]
With the new version of Komac, numerous Pull Requests may contain bugs or unwanted elements. If such issues arise, please tag russellbanks so that these bugs can be addressed in future updates.

[!important]
Please carefully review these Pull Request before merging. If it is a Pull Request for removing incorrect content and the URLs are issue, free upon manual checking, please close this Pull Request directly. (It is best to inform Exorcism0666 of the closure.)

良い一日をお過ごしください！


ErrorHandler: cannot use errorAction for 3rd party Exceptions

I am trying to port Payum into a Yii2 extension, however the ErrorHandler in Yii2 is preventing me to correctly handle some exceptions thrown by Payum.
In Yii1 it was possible to attach an event handler to 'onException'.
In Yii2 no such event exists, so one must rely on ErrorHandler. ErrorHandler however ignores a custom errorAction because the exceptions that need to be handled are not children of UserException.
How should I handle this with an extension?

You can wrap the Payum call in try/catch block. Usually there is no need to change global error handling behavior.

I can do that, but not the extension users. Do I have to require them to wrap every component call in a try catch? That would be very inconvenient.
I guess I have to fix ErrorHandler, include it in the extension and tell the users to override the default one on controller init.

Create a wrapper that forwards calls and does try-catch internally. You have to somehow deal with error though.

You mean something like this (inside a Component)?
public function __call($methodName, $methodParams) {
    if (method_exists($this->payum, $methodName)) {
        return call_user_func_array(array($this->adLdapClass, $methodName), $methodParams);
    }
}

Is it ok to override a magic methods like that? I remember in Yii1 it was advised against it. Just wanna follow proper standards.

Either that or multiple methods for concrete API. It's OK to override magic methods overall but check if you need standard Yii behavior as well. If you do, run parent::__call.


[Do not merge] Add new extend logs editor

Due security reasons, we need to replace the current logs widget for the new extends logs editor.
See https://goextend.io/docs/libraries/logs-viewer

closing in favor of #11


Run only one instance, exit when parent process exits

Summary of the Pull Request
What is this about:
What is include in the PR:

Exit editor when parent process exited
Do not run more than one editor instance

How does someone test / validate:

Open an editor's window and exit PowerToys
Verify that the editor's window exit as well(It's not enough to just close settings window because we hide it and the settings process is still alive)
Try to start few single instances of the editor. Notice that the editor has mandatory cmd arguments
Verify that only the first one starts and there is warnings in the logs

Quality Checklist

[ ] Linked issue: #xxx
[ ] Communication: I've discussed this with core contributors in the issue.
[ ] Tests: Added/updated and all pass
[ ] Installer: Added/updated and all pass
[ ] Localization: All end user facing strings can be localized
[ ] Docs: Added/ updated
[ ] Binaries: Any new files are added to WXS / YML

[ ] No new binaries
[ ] YML for signing for new binaries
[ ] WXS for installer for new binaries

Contributor License Agreement (CLA)
A CLA must be signed. If not, go over here and sign the CLA.

After I close the editor window there is some random delay before I can open it again. It can take long, up to 30 seconds.

@SeraphimaZ @mykhailopylyp
could it be caused by the fact that at present the editor crashes because of the XamlISlands bug and that delays the release of the mutex?

@enricogior

could it be caused by the fact that at present the editor crashes because of the XamlISlands bug and that delays the release of the mutex?

Yes, it seems to happen because of that. Also, we have a lag in typing after closing an editor's window because the keyboard hook is not unregistered.

@mykhailopylyp

because the keyboard hook is not unregistered.

The one in the editor, right?
That should be an easy fix.

The one in the editor, right?

yes


Add Scatter to Topi/Relay/ONNX via hybrid script

cc: @jwfromm @tqchen @masahi
The actual hybrid script implementation is kind of gross, I can't seem to figure out a way to clean it up without causing very opaque errors in the hybrid script module. If anyone has suggestions on cleaning that up, I'd love to hear them.

@jwfromm @masahi @Laurawly @Huyuwei I finally found time to get back to this and fix the issues with GPU/i386. Could you take a look? Thanks!

Hi @mbrookhart ! Is this implementation of scatter the same as the one in pytorch here ? https://pytorch.org/docs/stable/tensors.html#torch.Tensor.scatter_
As I implemented pytorch's gather in #5716 , I planned to implement reverse operation scatter too.

@notoraptor I based it off ONNX, which seems to be doing the same thing as the Pytorch op, if I'm reading the docs correctly. So, I think so, yes.

@mbrookhart There is some issue with WASM build, can you try again?
cc @tqchen https://ci.tvm.ai/blue/organizations/jenkins/tvm/detail/PR-5619/9/pipeline

Thanks @mbrookhart


Support for mapping ObservableCollection

This is not working for me, and I have the last stable version. I am gettnig this error:
"Expression of type 'System.Collections.Generic.List1[WCF.WcfService.SaleLineItem]' cannot be used for assignment to type  'System.Collections.ObjectModel.ObservableCollection1[WCF.WcfService.SaleLineItem]'"
I only want to map this element:
public class Sale
{
    public IEnumerable<SaleLine> SaleLines { get; set; }
}

To this one:
public class SaleHeaderItem
{
    public ObservableCollection<SaleLineItem> SaleLineList { get; set; }
}

I am doing something like this:
        Mapper.Register<Sale, SaleHeaderItem>()
            .Member(dest => dest.SalesLineList, src => src.SaleLines);
        Mapper.Register<SaleLine, SaleLineItem>();

        Mapper.Compile();

When do you think you will upload a new release with this fixed?

Hey fcogutierrez,
It has already been fixed! New release will be around next week.

Fixed - will be included in 1.5 release

Thanks a lot mate!! :)


Facing issue with AMP Carousel

We are facing issue with the Carousel. Works correctly when used separately, but creates some issue while used with other AMP scripts. Image is not changing on clicking the forward navigation, it only works on double clicking the navigation. The same issue is with autoplay.

Hi,
ampbyexample is a website hosting samples, if you think there is a bug with the AMP library feel free to open an issue on https://github.com/ampproject/amphtml, and if possible, please also provide a sample URL.

Ok Sure, thank you


Added AutoEatPlugin

you should add auto pot to this too

What pots should u suggest. I would assume this will be another seperate plugin.

You can use AutoFighter with the auto eat option if you want this feature. We want to avoid to many plugins, this takes longer to load the client and makes it harder to find the plugin you need. Thanks for taking the time to make a PR. Feel free to join our discord and have a chat.
I'm also aware that S-1D has a QOL plugin, maybe we can add all those features in there.


Jsfiddle examples on tonejs.github.io/ use deprecated Time expression syntax

Specifically, these three use time expression strings such as '4n + 8n':

https://jsfiddle.net/yotammann/meodck51/7/?utm_source=website&utm_medium=embed&utm_campaign=meodck51
https://jsfiddle.net/yotammann/k0caxzwt/21/?utm_source=website&utm_medium=embed&utm_campaign=k0caxzwt
https://jsfiddle.net/yotammann/w39e6450/10/?utm_source=website&utm_medium=embed&utm_campaign=w39e6450

(cf. #348)

fixed this finally!


[RFC] Default pytest run mode to unit tests only

It was pointed out by @kartikayk that the current UX for our testing is a bit clunky. E.g. executing a single unit test without downloading from S3 necessitates running pytest tests/path/to/my_unit_test.py --without-integration --without-slow-integration. This is a bit annoying, especially given this is a very common way to test individual changes.
This PR makes the default mode for our test runs to be unit-test only. This means that pytest tests will now run only unit tests, and will not run recipe tests or regression tests. It will also not download any artifacts for those tests.
My hope is that this is more intuitive given that most people are only running unit tests. One gotcha is that e.g. pytest tests/recipes and pytest tests/regression_tests will now be essentially a no-op, so we will need to instead specify e.g. pytest tests -m integration_test or pytest tests -m slow_integration_test instead. Assuming this isn't too much cognitive load, I claim this change should be a net positive.
Test plan
Run a bunch of different commands and check (a) which assets (if any) are expected, and (b) which tests runs.
All unit tests
Should run only unit tests, so no artifacts are needed.
pytest tests
(no expected artifacts)
...
187 passed, 19 skipped, 5 warnings in 136.89s (0:02:16)

tests/recipes unit tests only
Runs all unit tests under tests/recipes. Since only unit tests are run, no artifacts are needed.
pytest tests/recipes
(no expected artifacts)
...
1 passed, 11 skipped, 1 warning in 2.11s (since recipe tests are skipped by default)

tests/recipes, recipe tests only
Runs all recipe tests under tests/recipes. Fetches tokenizer and small model checkpoints for recipe tests.
pytest tests/recipes -m integration_test
Expected artifacts for test run are:
small-ckpt-01242024
small-ckpt-tune-03082024.pt
small-ckpt-meta-03082024.pt
small-ckpt-hf-03082024.pt
...
11 passed, 1 deselected, 3 warnings in 125.10s (0:02:05)

Single file, unit tests only
Runs unit tests from a single file. No artifacts are needed.
pytest tests/torchtune/modules/peft/test_peft_utils.py
(no expected artifacts)
...
19 passed, 1 warning in 0.12s

Single (unit test) file, regression tests only
(Not an intended usage) This command runs only regression tests from a single file containing only unit tests.
As a result, the full 7B model and tokenizer are fetched, but no tests actually run.
pytest tests/torchtune/modules/peft/test_peft_utils.py -m slow_integration_test
Expected artifacts for this test run are:
Expected artifacts for test run are:
llama2-7b-torchtune.pt
tokenizer.model
...
19 deselected, 1 warning in 0.02s (none run because the file contains no regression tests)

Single (unit test) file, with regression tests
(Also not an intended usage) By using --with-slow-integration-test instead of -m slow-integration-test,
this test will run unit tests + regression tests instead of just regression tests (as in the last command).
Again the full 7B model and tokenizer will be downloaded, but in this case all the unit tests do run.
pytest tests/torchtune/modules/peft/test_peft_utils.py --with-slow-integration-test
Expected artifacts for this test run are:
...
19 passed, 1 warning in 0.12s (unit tests run by default)

Recipe tests only with -k flag
Finally, this command runs recipe tests only using a -k filter.
This will fetch recipe test models and tokenizers and run only recipe tests matching the wildcard string.
pytest tests -m integration_test -k 'test_training_state_on_resume'
Expected artifacts for test run are:
small-ckpt-01242024
small-ckpt-tune-03082024.pt
small-ckpt-meta-03082024.pt
small-ckpt-hf-03082024.pt
...
3 passed, 203 deselected, 1 warning in 55.25s

CI should be green as well

@ebsmothers generally the concept makes sense to me. One noob question I would have is whether it would make sense to have the following mapping with no flags?
pytest tests/torchtune -> Unit tests
pytest tests/recipes -> Integration tests
pytest tests/regression_tests -> regression tests
pytest tests/ -> doesn't do anything

This makes it so that we'll have to manually run each sort of tests, but I think the RFC does that anyways? But I dont have to worry about remembering which flags to use. Not sure if this is possible though, so disregard if it isn't.

@ebsmothers generally the concept makes sense to me. One noob question I would have is whether it would make sense to have the following mapping with no flags?
pytest tests/torchtune -> Unit tests
pytest tests/recipes -> Integration tests
pytest tests/regression_tests -> regression tests
pytest tests/ -> doesn't do anything

This makes it so that we'll have to manually run each sort of tests, but I think the RFC does that anyways? But I dont have to worry about remembering which flags to use. Not sure if this is possible though, so disregard if it isn't.

@kartikayk yeah good point. I think the reason I opted not to do this is because of the last case.
For a bit more info on how this all works: if we want to download assets on-demand for the test run, we need to define that at the directory level, and any test run we execute will move up the directory tree until it hits root, with configs being successively overridden the higher you go. So to do what you're suggesting, we could have separate test configs in tests/recipes and tests/regression_tests to download just those assets (as opposed to right now where I have a single test config at root that parses all the flags). One other minor thing is that there is not yet a 1:1 mapping between test type and directory (e.g. we have config tests that I would claim are unit tests that are in tests/recipes). So this also solves for that case, though if you say "we should just move the test" I certainly wouldn't argue with you.
As you point out, the no-flag approach means we can't just run pytest/tests, which I think is something that people tend to do (e.g. #484 was based on a bug manifesting when @RdoubleA was running pytest/tests). Also this precludes stuff like pytest tests -k 'some_unit_test'. But ultimately it depends on what people find most intuitive and easiest to remember. My assumption based on #296 was that adding these flags would be a net positive to the testing experience. But I wanna make sure this holds in practice, if folks on the team think they are actually adding too much cognitive load then we should scrap them.

@ebsmothers Oh no, the flags make a lot of sense to me. I definitely want to keep them. My main point was around optimizing the use of flags for the use cases we plan to run the most. In terms of what people generally do, I think we will need to educate them anyways, so I'd just recommend taking the approach which you think is best and not worry about general patterns there. Overall, I agree with this direction.

Seems that there have been some changes in how S3 permissions get handled in CI on PRs created from forks, causing signals here to be red. To unblock, I created a copy of this PR using the main repo in #573 so gonna close this one.


Convert clr-modal to cds-modal

What this PR does / why we need it:
Shifts usage of clr-modal to cds-modal. Minor style adjustments and additional accessibility features are gained from this update.
Which issue(s) this PR fixes

See https://kubernetes.slack.com/archives/CM37M9FCG/p1618414173115100

Special notes for your reviewer:
Places of interest;

Build and release information on the top right menu
Preferences
Quick switcher
Confirmation dialog when deleting an object (from datagrids and object summary pages)
a modal opened by a button

Signed-off-by: Sam Foo<EMAIL_ADDRESS>

Hi @GuessWhoSamFoo, I see that you have some conflicting files due to my previous merge, if you need help with the rebase, just let me know


One phrase to trigger two commands.

Any thoughts on how to trigger two commands with one phrase?

Desired Behavior
I would like to setup two separate commands such as "Turn on all lights." and "Play music." and then have them both triggered with the phrase "Turn on all lights and play music".
Current Behavior
Right now I have to create a separate command that will trigger both commands. This is fine if there are only or two combinations but gets extremely tedious if you have several dozen combinations.
Possible Solution
Perhaps there is a way to parse commands. I'm not really sure what a good solution could be at the moment.

Perhaps in each command check the whole speech said for 'and' and then parse the text after 'and' to check for another command?

I know what you mean @BetaStacks this reminded me of a question I had and found the answer (in my case, I wondered how could I use a single command in several languages.  I would think your best bet would be an answer similar to the one given about the languages (see below, link to full question "How to specify multiple languages": https://github.com/TalAter/annyang/issues/119).
In other words, you're better off defining one given function and then adding the commands as they grow.  Annyang WILL pick up both commands from the same phrase if you define the terms separately, (I have tested it on my own application and it worked). See the original answer screenshot:

https://github.com/TalAter/annyang/issues/119

The issue you are describing is something I feel I will also run into in the future with scaling and it's best dealt with via NLP algorithms. But that adds a different layer of complexity that is perhaps unnecessary, so unless you're building a 100% voice interface, using nlp might be too much of an investment, and annyang is really meant for simplicity, I think.

💯 👍
Well said.


speed up yaml parsing

Problem
When parsing yaml files we currently look for environment variables to interpolate in every single line. While this is a useful feature for configuration files (endpoints.yml, config.yml, credentials.yml) and e.g. also used for Rasa X, this makes the training data reading very slow as stated here.
Note that removing this would be a breaking change as some users might rely on it. We need some sort of smooth transition for it.
Note that I've not investigated how much this line also contributes to the slowness
Ideas for solutions:

disable environment variable interpolation for stories / nlu files by default
add a switch to disable it

Definition of Done

[ ] Environment variable interpolation no longer is a blocking factor when reading big training data files
[ ] investigate if this line is still needed / what it's impact is on training data loading time
[ ] document usage / migration path for environment variable interpolation

I have a much simpler idea — what if we just check if the file contains ${...} before parsing it and use a faster parser if there is nothing? In this case, the migration process for end users won't be needed at all.

@wochinge I have a much simpler idea — what if we just check if the file contains ${...} before parsing it and use a faster parser if there is nothing? In this case, the migration process for end users won't be needed at all.

That's also an option! Scanning a big file with open(...) as file should be quick, no?

yes! and we need to do this anyway — the YAML needs to be parsed no matter if it contains env variables or not


promotions configuration are not saved

Hi,
using the multi-branch pluging the promotions configuration are not saved.
Steps to reproduce it:

open the configuration page
select "Promote builds when..." option and fill the form with some data
save
re-open the configuration page: the option is deselected and the previous data are lost

is this a known bug?
Jenkins used version: 1.579
Thanks for the help

Probably fixed with the refactoring in 0.2.  I can reopen if it's still an issue.


Use RH reg

[TEST ONLY]

Codecov Report

Merging #653 (4416a7d) into release-next (ec1b3bc) will decrease coverage by 11.72%.
Report is 5 commits behind head on release-next.
The diff coverage is n/a.

:exclamation: Current head 4416a7d differs from pull request most recent head e114683. Consider uploading reports for the commit e114683 to get more accurate results

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
@@                Coverage Diff                @@
##           release-next     #653       +/-   ##
=================================================
- Coverage         48.96%   37.25%   -11.72%
=================================================
  Files                96      106       +10
  Lines             13090    14378     +1288
=================================================
- Hits               6410     5357     -1053
- Misses             6045     8288     +2243
- Partials            635      733       +98

Flag
Coverage Δ

e2e-test
34.99% <ø> (?)

e2e-test-oncluster-runtime
25.26% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed
Coverage Δ

pkg/builders/builders.go
40.00% <ø> (-40.00%)
:arrow_down:

... and 96 files with indirect coverage changes


Update mono to a14f41c

Recommended by @kumpera
It fixes #462, plus other issues tracked by Mono.

Merged so we can move towards a final RC build, but @rynowak @javiercn please do leave review comments if you have any or if you have concerns about including this.


Apple calendar doesn't handle HTML

Apple calendar doesn't handle HTML

We could introduce a plain text option to feed Apple
maybe to do with
 instead of
 ?

Tried to apply the HTML format to the ICS
https://icalendar.org/
https://stackoverflow.com/questions/31255125/using-x-alt-desc-applying-html-to-calendar-invites-in-outlook
Also tried inputting the
 as

.. but didn't seem to take it
Given up for now


RXNO neither reports a date nor a data_version in OBO

It would be useful for reproducibility purposes to include both of a date and data_version field at the top of the RXNO OBO file

I'm pleased to say that this has been fixed in the .obo version.

Thank you very much!


[Backport PR 7244] Time series based workload desc order optimization through reverse se…

Description
EDIT -> After incorporating comments/suggestions from Nick, Andriya & Andorss, we decided to limit this change only to @timestamp field indices and also we changed default segment search order for these indices as Descending (from latest to the oldest segments), and also safe guarded rare ASC queries on time series based workload not to traverse on default DESC order to avoid any regression. The perf gains still remains similar.
As described in issue OpenSearch-6814, desc order sort queries are taking more time (3x or more) compare to asc order queries on same data set (time series based).
That is because all latest documents in time series workload are in latest segments when our IndexSearcher search documents in order of oldest segments to newest segments.
In this PR, we changed the leafReaderContext (segments) order in ContextIndexSearcher in reverse if query type is descending order sort. This will by default behaviour for all type of workloads and not just for time series based workloads. However it will only benefit to workload which has ever increasing data values. And for other type of workload, it wont regress or impact since data is randomly distributed across all segments.
But as a precaution, in case any user/workload gets search latency hit, I have added index level setting to disable this optimization.
Optimization gains
We are seeing 3x to 5x gains on below configuration.

On http_logs workload with disabled force merge, so each shard has around 100-150  segments.
instance type, r6g.2xlarge.
units are in ms.

Sort Type
hits = 5
hits = 100
hits = 1000

Desc
150
462
621

Desc (with this change)
49
112
125

Issues Resolved
OpenSearch-6814
Next action item
On same segment of time series based workload, ASC queiry is faster compare to descending order. We need to look further to that.
Check List

[x] New functionality includes testing.

[x] All tests pass

[x] New functionality has been documented.

[x] New functionality has javadoc added

[x] Commits are signed per the DCO using --signoff
[x] Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Backport of #7244

Codecov Report

Merging #7457 (d7edeb7) into 2.x (c4a13dc) will decrease coverage by 0.02%.
The diff coverage is 46.66%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@             Coverage Diff              @@
##                2.x    #7457      +/-   ##
============================================
- Coverage     70.29%   70.28%   -0.02%
+ Complexity    59898    59829      -69
============================================
  Files          4873     4873
  Lines        288130   288170      +40
  Branches      41885    41897      +12
============================================
- Hits         202542   202530      -12
- Misses        68607    68623      +16
- Partials      16981    17017      +36

Impacted Files
Coverage Δ

.../main/java/org/opensearch/index/IndexSettings.java
85.45% <0.00%> (-0.68%)
:arrow_down:

...va/org/opensearch/index/engine/InternalEngine.java
74.85% <0.00%> (+0.76%)
:arrow_up:

...a/org/opensearch/test/OpenSearchIntegTestCase.java
54.95% <ø> (-0.64%)
:arrow_down:

...va/org/opensearch/cluster/metadata/DataStream.java
84.15% <22.22%> (-6.06%)
:arrow_down:

...va/org/opensearch/search/DefaultSearchContext.java
76.89% <22.22%> (-2.04%)
:arrow_down:

...ava/org/opensearch/index/mapper/MappingLookup.java
92.79% <50.00%> (-0.79%)
:arrow_down:

...ensearch/search/internal/ContextIndexSearcher.java
75.35% <66.66%> (-2.03%)
:arrow_down:

...in/java/org/opensearch/index/shard/IndexShard.java
69.53% <83.33%> (-0.55%)
:arrow_down:

...java/org/opensearch/index/engine/EngineConfig.java
98.50% <100.00%> (+0.04%)
:arrow_up:

...g/opensearch/index/engine/EngineConfigFactory.java
92.95% <100.00%> (+0.10%)
:arrow_up:

... and 489 files with indirect coverage changes


Compilation of tree-based recursive functions into a loop.

The JavaScript code generated for the  function size over type ExampleTree is incorrect.

Occurs on Zafir.FSharp version <IP_ADDRESS>-beta9

Example F# Code

type ExampleTree =
  | TLeaf of int
  | TNode of (ExampleTree * ExampleTree)
  | TLink of ExampleTree

let rec size (t : ExampleTree) : int Set =
  match t with
  | TLeaf(i) -> Set.empty
  | TNode(l,r) -> Set.union <| size l <| size r
  | TLink(i) -> size i

Generated JavaScript for size

size=function(t)
 {
  var $1,$2,r,l,i;
  while(true)
   {
    if(t.$==1)
     {
      r=t.$0[1];
      l=t.$0[0];
      t=l;
     }
    else
     if(t.$==2)
      {
       i=t.$0;
       t=i;
      }
     else
      return new FSharpSet.New$1(null);
   }
 };

The compiler is trying to optimise the function into a loop. In the case for TNode, where t.$ == 1,
the function  discards the result from the recursive call to the right branch t.$0[1];.  For some reason it seems to also completely remove the union during compilation.

In the WebSharper Set proxy source code I can't see where Set.union is proxied, so maybe that's why it's removing the call completely. I'll go ahead and try to add the proxy now and see if that fixes it!

I don't think it's tied to Set.union. The following happens with addition:
let rec size (t : ExampleTree) : int =
  match t with
  | TLeaf(i) -> i
  | TNode(l,r) -> size l + size r
  | TLink(i) -> size i

size=function(t)
 {
  var r,l,i;
  while(true)
   if(t.$==1)
    {
     r=t.$0[1];
     l=t.$0[0];
     t=l;
    }
   else
    if(t.$==2)
     {
      i=t.$0;
      t=i;
     }
    else
     return t.$0;
 };

@jack-williams Thanks for the report, it is indeed still a bug in tail recursion optimizer, it seems to focus in on the size l call and not recognize that it is not in tail position. Testing and fixing.

No problem, thanks for the quick responses @Jand42 @atadi96.


dependas

Resolves #743 google spreadsheet,
Resolves #742 aws,
Resolves #741 pdf-lib,
Resolves #735 fontawesome,
Resolves #729 tinymce,
Resolves #720 darkreader

@dependabot rebase

@dependabot rebase


[feature] User-type for Vector2, Vector3, etc

It would be nice to be able to use custom types for the Vector2, Vector3, etc types. Something like disabling them by surrounding the definition like it:
#ifndef RL_USERTYPE_VECTOR2
    // Vector2, 2 components
    typedef struct Vector2 {
        float x;                // Vector x component
        float y;                // Vector y component
    } Vector2;
#endif

The concrete case is integration with glm.

@Eren121 I'm afraid that's not possible, raylib require internally the raylib defined types, if types were externally defined they could break many internal parts of raylib.
raymath library should provide mostly the same functionality than glm but in C, actually I remembert some user porting some glm-based code to raymath and aligning both libraries.

I mean it would be possible of course if the raylib is compiled from sources, using the custom type. I have also done this and this works pretty well.

@Eren121 Well, it will only be possible if Vector2 in the second implementation was 2 floats but it could be 2 integers or 2 shorts or maybe multiple decomposed values. In all those cases it would break raylib.

Most of the time it will work, because there are no padding even this it is technically not guaranteed (the layout is the same).
But I see what you mean, this would make glm thightly coupled to the library and could not be guaranteed with any other math library. I  was just wondering this because ImGUI allow something similar.


[Change Request] 7024 Page "Prices Overview"

Describe the request
Hello, can you please move the AssetNoFilter and PriceAsset variables to protected?
var
        PriceSource: Record "Price Source";
        CurrPriceListHeader: Record "Price List Header";
        PriceListManagement: Codeunit "Price List Management";
        PriceUXManagement: Codeunit "Price UX Management";
        FilterRecordRef: RecordRef;
        AmountTypeFilter: Enum "Price Amount Type";
        ParentSourceNoEditable: Boolean;
        SourceTypeEditable: Boolean;
        SourceNoEditable: Boolean;
        ParentSourceNoFilter: Text;
        ParentSourceNoFilterEditable: Boolean;
        SourceNoFilter: Text;
        SourceNoFilterEditable: Boolean;
        AssetNoFilterEditable: Boolean;
        CurrencyCodeFilter: Text;
        StartingDateFilter: Text;
        EndingDateFilter: Text;
        PageCaption: Text;
        Description3Lbl: Label '%1 %2 %3', Locked = true;
        Description5Lbl: Label '%1 %2 %3 %4 %5', Locked = true;
        WithinFilterLbl: Label 'No %1 within the filter %2.', Comment = '%1 - the unique entity id, %2 - the filter string ';
        AssignToNoEditable: Boolean;
        AssignToParentNoEditable: Boolean;
        PriceTypeVisible: Boolean;
        AmountTypeIsEditable: Boolean;
        AmountTypeIsVisible: Boolean;
        PriceVisible: Boolean;
        DiscountVisible: Boolean;
        DiscountOnlyVisible: Boolean;
        SalesVisible: Boolean;
        PurchVisible: Boolean;
        ItemAssetVisible: Boolean;
        ResourceAssetVisible: Boolean;
        ItemAsset: Boolean;
        ResourceAsset: Boolean;
        PriceLineEditable: Boolean;
        AssetTypeEditable: Boolean;
        DiscountEditable: Boolean;
        PriceEditable: Boolean;
        LineToVerify: Boolean;
        SalesPriceLine: Boolean;
        SalesPriceVisible: Boolean;
        PurchPriceLine: Boolean;
        PurchPriceVisible: Boolean;
        AllowDiscVisible: Boolean;
        AllowUpdatingDefaults: Boolean;
        DateEditable: Boolean;
        VariantCodeEditable: Boolean;
        UnitPriceEditable: Boolean;
        LineDiscPctEditable: Boolean;
        LineExists: Boolean;
        UseCustomLookup: Boolean;
        VariantCodeVisible: Boolean;
        VariantCodeLookupVisible: Boolean;
        UoMVisible: Boolean;
        UoMLookupVisible: Boolean;
        WorkTypeCodeEditable: Boolean;

protected var
        PriceAsset: Record "Price Asset";
        AssetNoFilter: Text;

Additional context
The page variables AssetNoFilter and PriceAsset need to be visible in extension code for accessing and validation, in order not to disrupt existing functionality through filtering from additional variables.
Internal work item: AB#498958

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.
Build ID: 17192.


chore: test f16 embeddings end-to-end

Make sure that f16 embeddings works end to end, and discover performance bottlenecks.

Done in #1744


Change the Font and font-size of MOMOMIA on the navbar ROBOTO

Can you please assign this to me. I want to work on this

Sure Go ahead @ShishuSidharth

Thanks @RIKI-05

is this alright?

please assign me this issue

Hi @RIKI-05 I have changed the font and font size same as given in screenshots, please merge this PR under the label-hacktoberfest-accepted


There is no space between the icon and the name in the dropdown menu (mobile view)

This issue is solved right! we should close this issue?

@Hrithik5 this is still an issue on iPhone chrome mobile

I would like to work on this fix if possible.

I submitted the PR above to resolve the issue with the spacing. This is my first one but I don't think I missed anything while following the contribution guidelines. Please let me know if I did.

Great work tyson !


Login/SignUp page UI/UX

I want to make a UI/UX of Login/Sign Up page for counsellor app . I have attached some backened code also.
@thestarsahil Sir kindly assigned me these issue

@thestarsahil Sir please assign me these issue

It's already Done !
Try Something else

ok thanks


Chose an alternative Electric slip ring

It is not possible to buy the Electric slip ring in the link supplied.
Please check if one of the alternatives are suitable for you.

https://www.amazon.es/WayinTop-deslizante-eléctrico-alambres-CIRCUITOS/dp/B07GCNK2XY
https://www.amazon.es/BQLZR-500-rpm-hattype-antideslizante-electrónicos/dp/B01CJJNL46

We will expect your answer before to order it.
@Integrated-Project-2-UVic-UCC/eye-sphere

Hi,
I've been checking the links you send us, and unfortunately, they doesn't fit in our project.
I found another link that could be a good option:
https://www.amazon.es/dp/B085MFQC7X/ref=cm_sw_r_cp_apa_i_QTGR91SPD405WSQCWYE8
If is not possible to buy the product in the link above, feel free to chose another model but only if it has the following specifications:

4 wires
minimum 2A
recomended max speed 300rpm, but if it's less, we will adapt to it.

Thanks,
EyeSphere team.

Good, the ring arrived.  Finally we got this one.
https://www.amazon.es/WayinTop-deslizante-eléctrico-alambres-CIRCUITOS/dp/B07GCNK2XY
If data is not transmitted correctly, a Bluetooth communication is going to be used and added to the system.


Spring boot won't start with setting graphql.tools.schemaLocationPattern

When I add the following configuration snippet taken from GraphQL Java Tools...
graphql:
    tools:
        schemaLocationPattern: **/*.graphqls

...the spring boot jar initialisation phase is not Spring-like, terminating at the end of the provided log:
11:11:00.582 [background-preinit] DEBUG org.jboss.logging - Logging Provider: org.jboss.logging.Log4j2LoggerProvider
11:11:00.586 [background-preinit] INFO  o.h.validator.internal.util.Version - HV000001: Hibernate Validator 6.0.10.Final
11:11:00.596 [background-preinit] DEBUG o.h.v.i.e.r.TraversableResolvers - Cannot find javax.persistence.Persistence on classpath. Assuming non JPA 2 environment. All properties will per default be traversable.
11:11:00.601 [background-preinit] DEBUG o.h.v.i.xml.ValidationXmlParser - Trying to load META-INF/validation.xml for XML based Validator configuration.
11:11:00.602 [background-preinit] DEBUG o.h.v.i.xml.ResourceLoaderHelper - Trying to load META-INF/validation.xml via TCCL
11:11:00.602 [background-preinit] DEBUG o.h.v.i.xml.ResourceLoaderHelper - Trying to load META-INF/validation.xml via Hibernate Validator's class loader
11:11:00.603 [background-preinit] DEBUG o.h.v.i.xml.ValidationXmlParser - No META-INF/validation.xml found. Using annotation based configuration only.
11:11:00.762 [background-preinit] DEBUG o.h.v.m.ResourceBundleMessageInterpolator - Loaded expression factory via original TCCL
11:11:00.769 [background-preinit] DEBUG o.h.v.i.engine.ValidatorFactoryImpl - HV000234: Using org.hibernate.validator.messageinterpolation.ResourceBundleMessageInterpolator as ValidatorFactory-scoped message interpolator.
11:11:00.769 [background-preinit] DEBUG o.h.v.i.engine.ValidatorFactoryImpl - HV000234: Using org.hibernate.validator.internal.engine.resolver.TraverseAllTraversableResolver as ValidatorFactory-scoped traversable resolver.
11:11:00.769 [background-preinit] DEBUG o.h.v.i.engine.ValidatorFactoryImpl - HV000234: Using org.hibernate.validator.internal.util.ExecutableParameterNameProvider as ValidatorFactory-scoped parameter name provider.
11:11:00.769 [background-preinit] DEBUG o.h.v.i.engine.ValidatorFactoryImpl - HV000234: Using org.hibernate.validator.internal.engine.DefaultClockProvider as ValidatorFactory-scoped clock provider.
11:11:00.769 [background-preinit] DEBUG o.h.v.i.engine.ValidatorFactoryImpl - HV000234: Using org.hibernate.validator.internal.engine.scripting.DefaultScriptEvaluatorFactory as ValidatorFactory-scoped script evaluator factory.

Without the aforementioned configuration snippet the app initialises and runs as expected:
  .   ____          _            __ _ _
 /\\ / ___'_ __ _ _(_)_ __  __ _ \ \ \ \
( ( )\___ | '_ | '_| | '_ \/ _` | \ \ \ \
 \\/  ___)| |_)| | | | | || (_| |  ) ) ) )
  '  |____| .__|_| |_|_| |_\__, | / / / /
 =========|_|==============|___/=/_/_/_/
 :: Spring Boot ::        (v2.0.3.RELEASE)

11:12:15.633 [background-preinit] DEBUG o.h.v.m.ResourceBundleMessageInterpolator - Loaded expression factory via original TCCL
11:12:15.649 [background-preinit] DEBUG o.h.v.i.engine.ValidatorFactoryImpl - HV000234: Using org.hibernate.validator.messageinterpolation.ResourceBundleMessageInterpolator as ValidatorFactory-scoped message interpolator.
11:12:15.649 [background-preinit] DEBUG o.h.v.i.engine.ValidatorFactoryImpl - HV000234: Using org.hibernate.validator.internal.engine.resolver.TraverseAllTraversableResolver as ValidatorFactory-scoped traversable resolver.
11:12:15.649 [background-preinit] DEBUG o.h.v.i.engine.ValidatorFactoryImpl - HV000234: Using org.hibernate.validator.internal.util.ExecutableParameterNameProvider as ValidatorFactory-scoped parameter name provider.
11:12:15.649 [background-preinit] DEBUG o.h.v.i.engine.ValidatorFactoryImpl - HV000234: Using org.hibernate.validator.internal.engine.DefaultClockProvider as ValidatorFactory-scoped clock provider.
11:12:15.650 [background-preinit] DEBUG o.h.v.i.engine.ValidatorFactoryImpl - HV000234: Using org.hibernate.validator.internal.engine.scripting.DefaultScriptEvaluatorFactory as ValidatorFactory-scoped script evaluator factory.

Is there no stack trace or logging available that indicates a cause? Because the logging shown here is JPA/Hibernate related, which has nothing to do with graphql-tools. Perhaps adding that config snippet in application.yml inadvertently changed some other setting as well which is causing this? Are you able to share the version of that file that causes this error and ideally also the complete log?

The app started just fine when wrapped the value in quotes:
  tools:
    schemaLocationPattern: "**/*.graphqls"

Indeed, without the quotes it produces an invalid YAML file. My fault for relying blindly on the IDE and not validating the config file myself.

Thanks for the check and update! I'll update the README accordingly.


Private projects

Shouldn't it also disappear from the sidebar if you're not logged in and not an admin/employee? If I am logged out, I see the private project on the left.

Whoops, dat is nu gefixed


docs(api): update cli subcommands usage info

https://github.com/webpack/webpack-cli/pull/2576

It's not released in a new version right?

Yes, not yet released.

Released in webpack-cli v4.7.0


It is blocked by CORS policy

Hello everyone,
My website recently stopped loading instagram feed with Cross Origin error:
"Access to XMLHttpRequest at '(my-websiteurl)' from origin '(my-websiteurl)' has been blocked by CORS policy: No 'Access-Control-Allow-Origin' header is present on the requested resource."
Unfortunately, my website use VTEX store which don't allow me to manage Cross Origin headers, or better said, is a "Software as a service".
Host is defined as 'https://www.instagram.com' and even this way I'm getting CORS error.
What can I do?
Thanks in advance.

I'm seeing a CORS error intermittently as well - we just upgraded to version 2.0.2 to fix the Rate Limiting issue, I believe recently the repo was PR'd with a fix that created a 6 hour LocalStorage cache.
Several hours ago I tested refreshing the page many times and it seemed the cache was working, no longer getting a rate limit.
Now getting a CORS error, that disappeared when I switched browsers. Might be an on and off issue?

Yes. It can be an on and off issue. But I googled about it a bit, and people are saying that IG implemented new CORS policy on some of their servers and it's causing this intermittence. I don't know if some cache management will work, as instagramFeed loads intermittently. I downloaded the source code to take a look as well.

See https://github.com/jsanahuja/jquery.instagramFeed/issues/103#issuecomment-784362740

@jsanahuja Thank you for the update and than you for continuing to support this project!

Release 2.1.0 implementing GraphQL (with user_id parameter) is ready. We have also implemented request retries (limited by max_tries parameter) to avoid arbitrary CORS errors.


Add validate tool

Most of the validation logic is finished, it just needs to be wired up to a new tool.

Implemented in 4d7439f6585f986581f7a86e0a4faa887cf24d3e.


Revert "chore: add semgrep"

Reverts finisterra-io/terraform-aws-elasticsearch#2

This PR is included in version 1.0.1 :tada:


Regenerate

commit e93c6cf6aaec362df42af38263502116ad754224 (HEAD -> regen, master)
Author: Sebastian Dröge<EMAIL_ADDRESS>Date:   Sun Dec 3 11:21:11 2017 +0200
Regenerate with latest GIR

Fixes https://github.com/gtk-rs/gio/issues/67
Also includes https://github.com/gtk-rs/gir/pull/498

commit d36ecd286560fb6bc034494cd6edabd4d5cb364c
Author: Sebastian Dröge<EMAIL_ADDRESS>Date:   Sun Dec 3 11:20:26 2017 +0200
Update gir submodule

commit 02b182c6f4511851ca0dc5a1059bef452e4ee2c0
Author: Sebastian Dröge<EMAIL_ADDRESS>Date:   Sun Dec 3 11:19:47 2017 +0200
Set version for GSettingsSchemaKey to 2.40

Fixes https://github.com/gtk-rs/gio/issues/67

👍

This is actually all regens needed, the others that were needed (gdk/gtk/gtksourceview) were already done by @EPashkin

Thanks!


children of at the same level are not aligned

Describe the bug
children of different parents, at the same level, are not aligned if one of those parents has button content.
To Reproduce
Steps to reproduce the behavior:

Go to https://stackblitz.com/edit/web-platform-nmjezm?file=index.html
look for children at the same level, ( like the screenshot below, look for "Laura")

Expected behavior
children at the same level should be aligned.
Screenshots

Desktop (please complete the following information):

OS: Mac Ventura 13.4.1 (22F82)
Browser Version 118.0.5993.88 (Official Build) (x86_64)
Org chart Version - 3.1.1

Hi, they aren't on the same level. On the left nodes are one level up, that's the behavior of compact layout
You can set chart.compact(false) if you want non compact layout.

Hi,
I want to keep the compact layout but at the same time I need to get rid of the small 10px gap which making it look a little misaligned. Is there a way I can shorten the link by some amount? or change the start point of the link whenever there is an expand/collapse button?

Ah, in that case, you have to play with the following properties
https://github.com/bumbeishvili/org-chart/blob/61d458c028ffeb0e023dfe675f137b002a5209b2/src/d3-org-chart.js#L54-L58

conditionally changing the childrenMargin work.
.childrenMargin((d) => {           return d.children ? 45.5 : 60;         })


"Independența" is listed in the drop-down menu

Description:
"Independența" is listed in the drop-down menu alongside its corresponding county and commune, according to the law
Precondition:
The website is up an running.

Step 1
Type "Independența" in the search bar.

Expected results
The location is listed in the drop-down menu as "Comuna Independența, GALAȚI".

Step 2
Press "x" button.

Expected results
The location was deleted from the search bar.

Step 3
Type again "Independența" in the search bar.

Expected results
The location is listed in the drop-down menu as "Sat Independența, GALAȚI (Independența)".


Compiler fixes related to js.swc

Where was the toString() missing?   That change seems to be breaking the CreateJS externs build.  The classes generated from the externs generally don't include methods that are overridden from a base class, so the original code should have allowed a toString() in Object than needed to allow Number, int and uint to have custom toString() methods.
With your change, other classes are now being given toString() methods which is unexpected and fails.

toString() was missing in every class except Number, int, uint.  I've found the problem and will add another commit here shortly.  Sorry about that.

Wasn't toString() on Object?  Then it doesn't need to exist on most other objects.  But we do need to allow Number, int and uint to have their own toString() with different parameters.

Object.prototype.toString() is included in the es3.js extern file, but it has a different signature than Number.prototype.toString(opt_radix), so you cannot have it defined in Object.as and override in Number.as or any other file.  The original code had it working for Number/int/uint, but "new Date().toString()" was giving an error because it was not including the toString() function in the Date class.  "new Object().toString()" does not giving an error because Object uses the 'dynamic' keyword on the class definition.
One of the problems in createjs was that Filter.js documented toString() with @return {string} but ColorFilter (extends Filter) did not include a return type, so it became a void function and an incompatible override.  The other issue was that there was a hard-coded thing in MethodReference.java to output an "AS3" namespace for a toString() override.

Also, with the getStaticField/getInstanceField changes, 5 files of unit tests have compile errors.  They are: TestAnnotationEnum, TestConstructor, TestExternChrome, TestTypeExternals, TestTypeInheritance.
Can you fix those up as well?
Thanks

The other issue was that there was a hard-coded thing in MethodReference.java to output an "AS3" namespace for a toString() override.

Using the AS3 namespace for toString() is the correct behavior. It allows subclasses to reimplement the method without the override keyword.
In fact, if you look at the API Reference, you'll see that all methods defined on Object are in the AS3 namespace rather than public.

Hmmm... strangely, toString() is not marked with the AS3 namespace in the API reference. However, if I recall correctly, it is AS3 instead of public in the playerglobal.swc. I'll double-check.

Okay, it appears that Number and other classes with custom toString() methods put it in the AS3 namespace. You can see that with Number.toString() in the API reference and it's the same in playerglobal.swc. For some reason, I thought it was the other way around. Regardless, ActionScript uses the AS3 namespace to avoid conflicts in toString() and some other methods because, as Alex noted, ActionScript is stricter than JavaScript.

I'm pretty sure it is that way so your subclasses of Object can override toString() although they can't add parameters to toString().

Before the changes related to toString(), new Date().toString() was giving an error because the toString() function was missing from the generated Date.as.
When I include a toString() jn Object.as, I get a new error which does not normally occur in when compiling ActionScript:
Incorrect number of arguments.  Expected no more than 0
var test:* = (b2 & 0xF).toString(2);
I can define a toString() in a new class without using "override."  In fact, when I use "override" it's a compile error.  It does allow me to add parameters to my own toString().

I think where we want to end up is that Number, int and uint have toString(radix) in the AS3 namespace, and Date, Array, etc have toString().  The code may have to check that the super class is Object and not some subclass of Object and then emit the toString().  We may need to have Object's toString() be in the AS3 namespace as well, or just omit it and automatically add it to every class that extends Object directly.
You are right that Object.toString() does not allow the override keyword.  I'm not sure why that is but it is mentioned in the AS3 Language Reference.

This is outputting ActionScript code to correspond to the JavaScript APIs, so I don't think the requirement of an AS3 namespace on Number.prototype.toString() etc. is necessary. I would argue that it is better to have less special-case code in the compiler.  The patched code outputs toString() in all the generated AS files where it appears in the JS externs except Object.as, where before it only appeared in Number/int/uint.

I believe the patched code does the right thing. From the AS3 language reference:

Note: Methods of the Object class are dynamically created on Object's prototype. To redefine this method in a subclass of Object, do not use the override keyword. For example, a subclass of Object implements function toString():String instead of using an override of the base class.

Therefore, the generated Object.as should not define toString().
Also, here's the description of the AS3 namespace:

Defines methods and properties of the core ActionScript classes that are fixed properties instead of prototype properties. When you set the "-as3" compiler option to true (which is the default setting in Flex Builder 2), the AS3 namespace is automatically opened for all the core classes. This means that an instance of a core class will use fixed properties and methods instead of the versions of those same properties and methods that are attached to the class's prototype object. The use of fixed properties usually provides better performance, but at the cost of backward compatibility with the ECMAScript edition 3 language specification (ECMA-262).

It's a specific feature about gaining performance in Flash Player, and should not be a part of js.swc, which is meant to be an API for JavaScript.

On a side note; When i wrote this externc, I had the same opinion as @adufilie. It was about getting the javascript out of valid AS, that was it.
The externc compiler was in my view an "interpreter" that could bend rules and make things work.

I guess, since Object is dynamic, calling toString() should still compile if you try to call it on something typed as Object (even if it's not defined). That isn't ideal, since IDEs probably won't provide toString() as a code hint (and some might even show an error in the editor). If there's no compiler error, through, it seems like a workaround that we can live with.

Flash Builder does not show toString() in its content assist for Object, and there is no error in the editor. =)

Yes, I see that too. Weird.

What happens for some non-dynamic class that extends Object?  Does it get a toString() even if it doesn't define a custom toString() function?  Does the compiler let you call toString() explicitly on the instances of that class?  In es3.js, toString() has been declared for Array, Date, etc.  I want to make sure it behaves the way we want for other classes that may not have declared a toString().

ActionScript gives an error if you try to use toString() on a non-dynamic class that does not define it explicitly.  Is there a reason we should make it behave differently when using js.swc, considering that all the extern files define toString()?

No, we just want to make sure we have the same behavior that AS coders expect.  I'll try to apply the correct set of your patches and see what happens.

Still not working.  Maybe the patches didn't applied correctly, but createjs.Text.toString() is still being generated even though there is a createjs.DisplayObject.toString()

At one point I had it working, but you're right, it currently isn't.  I must've been modifying the wrong set of files when I was testing overriding toString().  Here's what I'm seeing now:
When creating a new class Test1, you can and define toString() however you want.  When you create Test2 extending Test1, you need to specify the override keyword.
The code is using multiple ways to determine whether or not a method is an override:

getClassReference().hasSuperMethod(qName)
getComment().isOverride()
getClassReference().getMethodOverrideFromInterface(this)

Ok, I've reworked and updated the patch. I managed to move all the toString-related special-case code into a single if statement. Please try again.

The one piece I didn't realize before was that since these classes are serving the purpose of an external interface, subclasses need not include override methods since they must have the same signature as the super methods anyway.  toString() is now absent from Object, present in EventDispatcher and Number, and absent from subclasses of EventDispatcher such as Text and DisplayObject.

Yes, there some subtle things to the extern compiler.  Thanks for sticking with it.  Everything passes for me and I pushed it to the repo.

I think the github integration scripts didn't quite work.  Can you manually close the pull request?

In my experience, there's two ways to automatically close the pull request:

including a comment: "This closes #5". (or whatever the pull request number is) when applying the patch.
Using the command line to merge the pull request directly.
The advantage of the second approach is that the commit keeps the contributor's name.

The patch didn't apply correctly. Commits were included that should have been replaced. I've created a new pull request to revert the bad commits and re-apply this patch.

@Harbs: Yes, that has been working for me, but for some reason, when I pulled the last set of changes there was a merge conflict and after resolving them, the system didn't close the PR.  Maybe I've been merging these changes incorrectly.  I just keep running git pull without reverting back to before the commits.   I could make a fake commit, but it seems better for Andy to just manually close this one.

I noticed that there was no merge commit after applying the patch. On the "Git for Apache Flex Guide" (https://cwiki.apache.org/confluence/display/FLEX/Git+for+Apache+Flex+Guide) it links to a description of your branching model (http://nvie.com/posts/a-successful-git-branching-model/) which suggests using "git merge --no-ff" to preserve the merge history and make it easier to roll back.  "git pull --no-ff" would also work, but revert is needed if you do it multiple times.

Sorry, I meant "git reset", not revert.


Builds take too long

Polaris takes quite some time to build. It's not terrible, but I feel we could do better.
Some low-hanging fruit is:

[x] using profile overrides to build proc macros in debug mode
[ ] avoiding some of the dependency duplication (e.g. right now we're building two versions of syn, each taking around 37 seconds to build
[ ] removing some of the less important proc macro dependencies (function_name) comes to mind
[ ] making the TLS support optional (for people that use a reverse proxy)
[ ] making the Last.fm support optional
[ ] maybe something related to the testing code?

Filed https://github.com/polyfloyd/rust-id3/pull/34 for derive-builder and the old syn.

Thank you for kickstarting this effort. I've been unhappy with the build times for a while and I haven't had a chance to dig into it. A few notes/questions:

profile-override
Merged! That's a huge win!

avoiding some of the dependency duplication
The syn improvement to rust-id3 is going to help a lot, good catch. For the rest of the tree, I think it's going to get a big shakedown when the next Rocket finally is released (or one of my experiments with other framework ends well enough to switch). The current Rocket release pulls a very outdated version of hyper, which is full of bugs and also brings in a bunch of duplicate dependencies.

function-name
I think the 5 seconds are a reasonable trade-off versus the headache of giving tests unique db file names. I don't know if that's possible but maybe it could be compiled only with tests (which is where it's used)?

Making TLS optional
I think all the heavy crypto stuff gets pulled in by cookie regardless, which is very much non-optional.  I would be open to a PR on this if I'm wrong though.

Making Last.fm optional
This one doesn't look like a big offender for compiler time. If we were to do this, it would have to come with a new API endpoint to query supported features so that clients don't show UI for features that don't exist. (+corresponding polaris-web and android client work). Feels like a bad ratio of effort to savings.

As a side note, how did you generate the graph above?

I'm also trying to remove regex from rust-id3, but we'll certainly pull it off from other crates, so it won't help.
You can make the graphs on nightly with cargo build -Z timings.

Regarding the database names, can we use in-memory databases instead? I'm not sure if the in works (the database is deleted when the connection is closed).

We also use regex to match album art file names with the user-configured regex.
Good ideas for the database names, I think either solution could work!

Ah, I just noticed that the tests are using .sqlite files from the repository. then my ideas don't work very well.

All the .sqlite files are throwaway that get created from scratch at the start of each test. I like having them linger because it makes it easy to troubleshoot test failures, but I haven't had to do that in a very long time so I could live without it.

Unfortunately we're still on that syn 0.15. It gets pulled in by Rocket's proc macros.

Build times have gotten significantly better since the migration away from rocket (+ various dependency updates).
I also just submitted a change to compile diesel with support for only 16-column tables which made a 25 seconds difference.
Timings for a clean debug build on my desktop:


Added TypeScript Definitions

These definitions are by no means complete. For full type-safety, we'd need to pass some definitions from the API (profile, for example). Still, this'll do the trick by way of dismissing that pesky Could not find a declaration file for module 'blockstack' error, and for providing param/return hints.

@harrysolovay Good news! We're aiming to move all of our js/flow projects over to Typescript.
Work in in progress nearly complete for this repo: https://github.com/blockstack/blockstack.js/pull/616
In the mean time, here is a full blockstack.d.ts based off blockstack.js v19.

@zone117x that's great news!

@zone117x thanks for moving this forward.


Add Sphinx doc frame, create docs.yml with support for Google doc strings

Stack from ghstack:

#192
-> #191

Squashed and reopened.


The filename, directory name, or volume label syntax is incorrect.

add ignite-cli, then wanna explore this ignite..
trying to create
ignite app1
ignite app2 --min
same happen, even i cant run with default install (with development screen) , if this ignite is DISCONTINUE, please tell the others..

Gotcha, so --min is not working?  or is both ignite app and ignite app --min?
Just trying to verify the ticket before we dig in.

right, both of them i cant use..
using --min or no when create new project..

here ignite doctor

i was able to eliminate all but one of the error messages by selecting "no" for each prompt -- see below:
C:\Users\user\apps>ignite new pizza2
(                  )   (
)\ )   (        ( /(   )\ )    *   )
(()/(   )\ )     )()) (()/(   )  /(   (   /(_)) (()/(    ((_)\   /(_))  ( )(_))  )\  (_))    /(_))_   _((_) (_))   (_(_())  ((_)  |_ _|  (_)) __| | \| | |_ _|  |_   _|  | __|   | |     | (_ | | . |  | |     | |    | |
||     _| ||_| ||    ||    |__|
An unfair headstart for your React Native apps.
https://infinite.red/ignite

🔥 igniting app pizza2
√ using the Infinite Red boilerplate v2 (code name 'Andross')
√ added React Native 0.50.4 in 244.35s
? Would you like Ignite Development Screens? No
? What vector icon library will you use? none
? What internationalization library will you use? none
? What animation library will you use? none
? Would you like to include redux-persist? No
√ added ignite-ir-boilerplate in 142.73s
The filename, directory name, or volume label syntax is incorrect.
√ configured git
√ ignited pizza2

could it be that this error arises from a lack of a package.json file?

UPDATE: i created an empty package.json in my default user's directory and i no longer get this error. YMMV, of course.

I'm encountering the exact same problem in a very similar Windows environment. I did an install of ignite-cli today, but I always get the "filename... " error. Even when I try the --min install:

When I try a regular install with selecting yes on all options, I get several mentions of the filename/directory/syntax error:

Here's the full log when running the command with --debug
ignite_run_debug_log.txt

When I install the app with max options, I end a basic startup-screen without dev screens (that is, after solving this first), so I assume that the steps that should install the extra options don't get executed:

Adding an empty package.json in my default user directory or in the directory I install from (I tried both) results in an error:

Any help greatly appreciated!

as far as i can tell, the only difference between what you're doing
and what i'm doing is the package.json and the boilerplate. i'm using
the expo fork:
https://github.com/jbosse/ignite-expo-boilerplate
i'm no longer seeing the "filename... " error.
On 4/24/18, andersfloor<EMAIL_ADDRESS>wrote:

I'm encountering the exact same problem in a very similar Windows
environment. I did an install of ignite-cli today, but I always get the
"filename... " error. Even when I try the --min install:

When I try a regular install with selecting yes on all options, I get
several mentions of the filename/directory/syntax error:

Here's the full log when running the command with --debug
ignite_run_debug_log.txt

When I install the app with max options, I end a basic startup-screen
without dev screens (that is, after solving
this
first), so I assume that the steps that should install the extra options
don't get executed:

Adding an empty package.json in my default user directory or in the
directory I install from (I tried both) results in an error:

Any help greatly appreciated!
--
You are receiving this because you commented.
Reply to this email directly or view it on GitHub:
https://github.com/infinitered/ignite/issues/1229#issuecomment-384032746

I ran this command twice :
ignite new milo --min

once in the root of C drive (windows installation drive) got the filename error
then in the root of D drive (not a windows installation drive) got no errors at all and the project successfully depolyed

This issue is pretty stale, so I'm closing it. Please let me know if you still need help with it. 🙂