fail to install runtime

Model Builder Version 17.17.2332602:
Visual Studio Version 17.6.4

Describe the bug

The error occurred while training the model

I clicked on the "Train" button and an error occurred. Here is the log.
2023-07-01 22:11:53.3878 DEBUG update TrainViewModel_35.RemainingTime (Microsoft.ML.ModelBuilder.Utils.Logger.Debug)
2023-07-01 22:11:53.4471 DEBUG Start AutoMLService pid: 4608 (Microsoft.ML.ModelBuilder.Utils.Logger.Debug)
2023-07-01 22:11:54.3485 INFO start text classification  (Microsoft.ML.ModelBuilder.Utils.Logger.Info)
2023-07-01 22:11:54.3727 DEBUG env:path: C:\Users\Admin\AppData\Local\Temp\ModelBuilder\torchsharp-cpu-0.99.5;C:\Program Files\Microsoft\jdk-<IP_ADDRESS>-hotspot\bin;C:\Program Files\Common Files\Oracle\Java\javapath;C:\WINDOWS\system32;C:\WINDOWS;C:\WINDOWS\System32\Wbem;C:\WINDOWS\System32\WindowsPowerShell\v1.0\;C:\WINDOWS\System32\OpenSSH\;C:\Program Files\Git\cmd;C:\Program Files (x86)\Intel\Intel(R) Management Engine Components\DAL;C:\Program Files\Intel\Intel(R) Management Engine Components\DAL;C:\Program Files\dotnet\;C:\Users\Admin\AppData\Local\Programs\Python\Python311\Scripts\;C:\Users\Admin\AppData\Local\Programs\Python\Python311\;C:\Users\Admin\AppData\Local\Microsoft\WindowsApps;C:\Program Files\JetBrains\PyCharm Community Edition 2022.3.2\bin;;C:\Users\Admin\AppData\Local\Programs\Microsoft VS Code\bin;C:\Users\Admin\AppData\Local\GitHubDesktop\bin;C:\Users\Admin\.dotnet\tools;C:\Users\Admin\.detaspace\bin;C:\Users\Admin\.deta\bin;C:\Users\Admin\.dotnet\tools (Microsoft.ML.ModelBuilder.Utils.Logger.Debug)
2023-07-01 22:11:54.3727 DEBUG C:\Users\Admin\AppData\Local\Temp\ModelBuilder\torchsharp-cpu-0.99.5\obj (Microsoft.ML.ModelBuilder.Utils.Logger.Debug)
2023-07-01 22:11:54.3727 INFO restore "c:\program files\microsoft visual studio\2022\community\common7\ide\extensions\aeowiwmr.5oo\AutoMLService\RuntimeManager\torchsharp.cpu.csproj" --configfile "c:\program files\microsoft visual studio\2022\community\common7\ide\extensions\aeowiwmr.5oo\AutoMLService\RuntimeManager\NuGet.config" -r win-x64 /p:UsingToolXliff=false /p:TorchSharpVersion=0.99.5 /p:TorchSharpCudaRuntimeVersion=<IP_ADDRESS> /p:TensorflowRuntimeVersion=2.3.1 /p:BaseIntermediateOutputPath="C:\Users\Admin\AppData\Local\Temp\ModelBuilder\torchsharp-cpu-0.99.5\obj" (Microsoft.ML.ModelBuilder.Utils.Logger.Info)
2023-07-01 22:11:54.3727 INFO publish "c:\program files\microsoft visual studio\2022\community\common7\ide\extensions\aeowiwmr.5oo\AutoMLService\RuntimeManager\torchsharp.cpu.csproj" -r win-x64 -c Release --no-self-contained -o "C:\Users\Admin\AppData\Local\Temp\ModelBuilder\torchsharp-cpu-0.99.5" --no-restore /p:UsingToolXliff=false /p:TorchSharpVersion=0.99.5 /p:TorchSharpCudaRuntimeVersion=<IP_ADDRESS> /p:TensorflowRuntimeVersion=2.3.1 /p:BaseOutputPath="C:\Users\Admin\AppData\Local\Temp\ModelBuilder\torchsharp-cpu-0.99.5\bin\\" /p:BaseIntermediateOutputPath="C:\Users\Admin\AppData\Local\Temp\ModelBuilder\torchsharp-cpu-0.99.5\obj\\" (Microsoft.ML.ModelBuilder.Utils.Logger.Info)
2023-07-01 22:11:54.3727 INFO start installing runtime in C:\Users\Admin\AppData\Local\Temp\ModelBuilder\torchsharp-cpu-0.99.5 (Microsoft.ML.ModelBuilder.Utils.Logger.Info)
2023-07-01 22:11:54.3882 DEBUG update TrainViewModel_35.RemainingSeconds (Microsoft.ML.ModelBuilder.Utils.Logger.Debug)
2023-07-01 22:11:54.3882 DEBUG update TrainViewModel_35.RemainingTime (Microsoft.ML.ModelBuilder.Utils.Logger.Debug)
2023-07-01 22:11:54.5133 INFO Failed to read environment variable [DOTNET_STARTUP_HOOKS], HRESULT: 0x800700CB (Microsoft.ML.ModelBuilder.Utils.Logger.Info)
2023-07-01 22:11:54.8822 INFO System.UnauthorizedAccessException: Access to the path 'C:\Users\Admin\.dotnet\7.0.304.toolpath.sentinel' is denied. (Microsoft.ML.ModelBuilder.Utils.Logger.Info)
2023-07-01 22:11:54.8822 INFO    at Microsoft.Win32.SafeHandles.SafeFileHandle.CreateFile(String fullPath, FileMode mode, FileAccess access, FileShare share, FileOptions options) (Microsoft.ML.ModelBuilder.Utils.Logger.Info)
2023-07-01 22:11:54.8822 INFO    at Microsoft.Win32.SafeHandles.SafeFileHandle.Open(String fullPath, FileMode mode, FileAccess access, FileShare share, FileOptions options, Int64 preallocationSize, Nullable`1 unixCreateMode) (Microsoft.ML.ModelBuilder.Utils.Logger.Info)
2023-07-01 22:11:54.8822 INFO    at System.IO.Strategies.OSFileStreamStrategy..ctor(String path, FileMode mode, FileAccess access, FileShare share, FileOptions options, Int64 preallocationSize, Nullable`1 unixCreateMode) (Microsoft.ML.ModelBuilder.Utils.Logger.Info)
2023-07-01 22:11:54.8822 INFO    at System.IO.Strategies.FileStreamHelpers.ChooseStrategyCore(String path, FileMode mode, FileAccess access, FileShare share, FileOptions options, Int64 preallocationSize, Nullable`1 unixCreateMode) (Microsoft.ML.ModelBuilder.Utils.Logger.Info)
2023-07-01 22:11:54.8822 INFO    at System.IO.File.Create(String path) (Microsoft.ML.ModelBuilder.Utils.Logger.Info)
2023-07-01 22:11:54.8822 INFO    at Microsoft.Extensions.EnvironmentAbstractions.FileWrapper.CreateEmptyFile(String path) (Microsoft.ML.ModelBuilder.Utils.Logger.Info)
2023-07-01 22:11:54.8822 INFO    at Microsoft.DotNet.Cli.Utils.FileAccessRetrier.RetryOnIOException(Action action) (Microsoft.ML.ModelBuilder.Utils.Logger.Info)
2023-07-01 22:11:54.8822 INFO    at Microsoft.DotNet.Configurer.DotnetFirstTimeUseConfigurer.Configure() (Microsoft.ML.ModelBuilder.Utils.Logger.Info)
2023-07-01 22:11:54.8822 INFO    at Microsoft.DotNet.Cli.Program.ConfigureDotNetForFirstTimeUse(IFirstTimeUseNoticeSentinel firstTimeUseNoticeSentinel, IAspNetCertificateSentinel aspNetCertificateSentinel, IFileSentinel toolPathSentinel, Boolean isDotnetBeingInvokedFromNativeInstaller, DotnetFirstRunConfiguration dotnetFirstRunConfiguration, IEnvironmentProvider environmentProvider, Dictionary`2 performanceMeasurements) (Microsoft.ML.ModelBuilder.Utils.Logger.Info)
2023-07-01 22:11:54.8822 INFO    at Microsoft.DotNet.Cli.Program.ProcessArgs(String[] args, TimeSpan startupTime, ITelemetry telemetryClient) (Microsoft.ML.ModelBuilder.Utils.Logger.Info)
2023-07-01 22:11:54.8978 INFO    at Microsoft.DotNet.Cli.Program.Main(String[] args) (Microsoft.ML.ModelBuilder.Utils.Logger.Info)
2023-07-01 22:11:54.9188 INFO clean up (Microsoft.ML.ModelBuilder.Utils.Logger.Info)
2023-07-01 22:11:55.0706 DEBUG update TrainViewModel_35.TrainStatus (Microsoft.ML.ModelBuilder.Utils.Logger.Debug)
2023-07-01 22:11:55.0706 DEBUG update TrainViewModel_35.IsResetTrainingEnabled (Microsoft.ML.ModelBuilder.Utils.Logger.Debug)
2023-07-01 22:11:55.0706 DEBUG update TrainViewModel_35.IsTrainingOptionEnabled (Microsoft.ML.ModelBuilder.Utils.Logger.Debug)
2023-07-01 22:11:55.0706 DEBUG update TrainViewModel_35.IsTrainingButtonEnabled (Microsoft.ML.ModelBuilder.Utils.Logger.Debug)
2023-07-01 22:11:55.0706 DEBUG update TrainViewModel_35.TrainButtonLabel (Microsoft.ML.ModelBuilder.Utils.Logger.Debug)
2023-07-01 22:11:55.0706 DEBUG update TrainViewModel_35.RemainingTime (Microsoft.ML.ModelBuilder.Utils.Logger.Debug)
2023-07-01 22:11:55.0706 DEBUG update TrainViewModel_35.IsTraining (Microsoft.ML.ModelBuilder.Utils.Logger.Debug)
2023-07-01 22:11:55.0706 DEBUG update TrainViewModel_35.IsCompleted (Microsoft.ML.ModelBuilder.Utils.Logger.Debug)
2023-07-01 22:11:55.0706 DEBUG update ModelBuilderDataContext_0.CreateConsumeTabViewModelAsync (Microsoft.ML.ModelBuilder.Utils.Logger.Debug)
2023-07-01 22:11:55.0706 DEBUG update ModelBuilderDataContext_0.CreateEvaluateTabViewModelAsync (Microsoft.ML.ModelBuilder.Utils.Logger.Debug)
2023-07-01 22:11:55.0706 DEBUG update ModelBuilderDataContext_0.GetCompletedTabAsync (Microsoft.ML.ModelBuilder.Utils.Logger.Debug)
2023-07-01 22:11:55.0706 DEBUG update TrainViewModel_35.TrainingDidNotSucceed (Microsoft.ML.ModelBuilder.Utils.Logger.Debug)
2023-07-01 22:11:55.0706 DEBUG fail to install runtime
   at Microsoft.ML.ModelBuilder.AutoMLService.RuntimeManager.InstallRuntimeAsync(CancellationToken ct) in /_/src/Microsoft.ML.ModelBuilder.AutoMLService/RuntimeManager/RuntimeManager.cs:line 53
   at Microsoft.ML.ModelBuilder.AutoMLService.TextClassificationExperiment.<ExecuteAsync>d__13.MoveNext() in /_/src/Microsoft.ML.ModelBuilder.AutoMLService/Experiments/TextClassificationExperiment.cs:line 53
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at Microsoft.ML.ModelBuilder.AutoMLEngine.<StartTrainingAsync>d__21.MoveNext() in /_/src/Microsoft.ML.ModelBuilder.AutoMLService/AutoMLEngineService/AutoMLEngine.cs:line 169 (Microsoft.ML.ModelBuilder.Utils.Logger.Debug)
2023-07-01 22:11:55.4027 DEBUG update TrainViewModel_35.RemainingSeconds (Microsoft.ML.ModelBuilder.Utils.Logger.Debug)
2023-07-01 22:11:55.4027 DEBUG update TrainViewModel_35.RemainingTime (Microsoft.ML.ModelBuilder.Utils.Logger.Debug)
2023-07-01 22:11:56.4166 DEBUG update TrainViewModel_35.RemainingSeconds (Microsoft.ML.ModelBuilder.Utils.Logger.Debug)

To Reproduce
Steps to reproduce the behavior:

I created a .NET Framework console project (because I want to create our learning model right away)

I add a machine learning element

I configure it

And an error when clicking the "train" button

Screenshots

Additional context
Add any other context about the problem here.

@D-I-M-A-git Are you using your visual studio under admin mode?

@D-I-M-A-git Are you using your visual studio under admin mode?

At that time, I was using Visual Studio without administrator rights. Now I tried to do it again with administrator rights.
As you can see, it shows me that I should not use Visual Studio with administrator rights.

Hmmm it's interesting to see this log. According to the log the error is because dotnet sdk doesn't have permission to write to C:\Users\Admin.dotnet. Can you confirm your account has access to that location?
If not, maybe you can set DOTNET_CLI_HOME to a place where your account has permission and launch again

I don't know how to check it all, so I decided to reinstall .NET and Visual Studio.
This helped to solve the problem.

I also encountered this problem. By looking at the source code of the InstallRuntimeAsync function, you can find that it detects the current system type and user level, and throws an exception directly if it is an Admin user.
Currently I am using the default Administrator account and no other non-Admin accounts are available, is there any necessary reason why this must be done?

The code after translating numbers into enumerations is shown in the figure

This code comes from Microsoft.ML.ModelBuilder.AutoMLService.dll
Another interesting fact is that this detection does not appear in the assembly from version 16.1500.123.22401 in dotnet tool

This check has been added since version 17.x, why do you want to do it?

@pedoc Because model builder will run dotnet restore to install torchsharp runtime. For security concerns model builder is only allowed to run this installation command under non-administrator permission.
@JakeRadMSFT @luisquintanilla maybe it's time to rethink about this restriction as I already see a few issues on failure to install runtime? Maybe we can throw a warning message or set up a flag to disable the admin-mode check?

Because model builder will run dotnet restore to install torchsharp runtime. For security concerns model builder is only allowed to run this installation command under non-administrator permission.

it's a reasonable motive.
Reminds me a while back that the nuget team added the restriction that https origins must be used 😂.
My personal opinion on this kind of restriction is that if it's beneficial, it can be turned on by default, but there should be a switch for people who don't need it to opt out.
For example, in our environment, I don't have the right to create other accounts and have to use the default administrator account, and most of the environments we deploy in batches are the same.
Then we will now have to discontinue use of .
Currently, I patch this dll file to remove this limitation, I hope to control it in the future.
Thanks

Оскільки конструктор моделей запустить відновлення dotnet, щоб встановити середовище виконання torchsharp. З міркувань безпеки конструктору моделей дозволяється запускати цю команду інсталяції лише з дозволом без прав адміністратора.

I also believe that it is necessary to add the ability to disable administrator verification (of course, with a warning that this may affect security).

Currently, I patch this dll file to remove this limitation, I hope to control it in the future.

I can share the patched dll if anyone has the same problem😊

@pedoc Because model builder will run dotnet restore to install torchsharp runtime. For security concerns model builder is only allowed to run this installation command under non-administrator permission.
@JakeRadMSFT @luisquintanilla maybe it's time to rethink about this restriction as I already see a few issues on failure to install runtime? Maybe we can throw a warning message or set up a flag to disable the admin-mode check?

I think it's time to fix it.I try it in Another PC but still this Error.Don't you know the default account in Windows is 'admin'???So are you sure that this tool developing for beginners?Why give user a BIG ERROR BOX but not a OPTION?

@Miltomo After discussing with @JakeRadMSFT and @luisquintanilla , we decided to add an environment variable so you can disable the error box manually by toggling that environment variable on. Unfortunately we still need to keep the default error prompt behavior because of compliance check.
Please let me know if that workaround works for you. Thanks

we decided to add an environment variable so you can disable the error box manually by toggling that environment variable on.

Hi,personally I'd prefer it to be a configuration option, with the default behavior being the same as now and people being able to opt-out of this behavior.because the environment variable configuration is more complex and needs to exist on all target running devices, this is impossible in some scenarios. Because we cannot ask customers to complete it by themselves.

@Miltomo After discussing with @JakeRadMSFT and @luisquintanilla , we decided to add an environment variable so you can disable the error box manually by toggling that environment variable on. Unfortunately we still need to keep the default error prompt behavior because of compliance check.
Please let me know if that workaround works for you. Thanks

@LittleLittleCloud  Sure.But please put it as a GUI OPTION in either "Tools-Option"menu or "Extension"menu. Don't leave it for users to configure themselves. At least for me, that's will not be pleasant. And, thank you.

@pedoc I understand that setting environment variables can be challenging in some situations but unfortunately it’s the best thing we can offer here due to compliance check restriction. In the meantime i am a bit confused by the scenario you described as “impossible for customer to made”. If you could provide an example that will help us to investigate other workarounds, thanks for your time in advance

Customers generally do not have computer expertise and do not understand what environment variables are. We cannot remotely set up each customer's computer, and controlling environment variables through a program would be a bit fussy.
Even UAC for Windows can be turned off by the user (it's not controlled by an environment variable), so I can't give any better advice for the compliance mentioned here.
If this is the only thing to do, let us say "yes".

I run into the same issue and have same limitation where I can't change my account type.
If someone can explain how to change the environment variable to get out of this issue it would be appreciated. Right now I'm in a dead end for using this tool..

@ooo1234567 The change is not released yet, we'll push a release some time next week and hopefully it would get you unblocked
For now is there a specific reason that you need to stick with admin mode, If not maybe try opening VS without elevating permission?
You can check if run as admin is enabled by default in the shortcut icon

@LittleLittleCloud, my issue is with Run as administrator turned off. I've tried it on an older VS2022 and it worked fine but on this one no...

We just release 17.18.2, which contains a fix to override elevation check by setting an environment flag
In the new release, the error message will look like this

You can set 'MODEL_BUILDER_ENABLE_ELEVATED_CHECK' to 'FALSE' in System Variable to bypass the check

[!Note]
the MODEL_BUILDER_ENABLE_ELEVATED_CHECK needs to be set in system variable

Then, reopen VS and the error will disappear

this is my problem, i have tried both adding variables to the environment and switching Admin

this is my problem, i have tried both adding variables to the environment and switching Admin

@HTWeathrt looks like you are using an old version model builder from the screenshot you shared. Can you try the latest model builder ?

I upgraded from version 17.15
Now it works fine, thank you for your support

help me to solve this error

@KashafRafiq show me the log

2024-05-10 00:40:46.7006 INFO Set log file path to C:\Users\ch computers\AppData\Local\Temp\MLVSTools\logs\MLModel2-EFUQO8.txt (Microsoft.ML.ModelBuilder.Utils.Logger.Info)
2024-05-10 00:41:02.2061 DEBUG Start AutoMLService pid: 5292 (Microsoft.ML.ModelBuilder.Utils.Logger.Debug)
2024-05-10 00:41:02.8471 DEBUG env:path: C:\Users\ch computers\AppData\Local\Temp\ModelBuilder\tensorflow-cpu.2.3.1;C:\app\dbhomeXE\bin;C:\WINDOWS\system32;C:\WINDOWS;C:\WINDOWS\System32\Wbem;C:\WINDOWS\System32\WindowsPowerShell\v1.0;C:\WINDOWS\System32\OpenSSH;C:\Program Files\dotnet;C:\Program Files\Azure Data Studio\bin;C:\Program Files\Microsoft SQL Server\Client SDK\ODBC\170\Tools\Binn;C:\Program Files (x86)\Microsoft SQL Server\150\Tools\Binn;C:\Program Files\Microsoft SQL Server\150\Tools\Binn;C:\Program Files\Microsoft SQL Server\150\DTS\Binn;C:\Program Files\Git\cmd;C:\Program Files\Git\mingw64\bin;C:\Program Files\Git\usr\bin;D:;C:\Users\ch computers\AppData\Local\Microsoft\WindowsApps;C:\Users\ch computers.dotnet\tools;C:\Program Files\Azure Data Studio\bin;D:\PyCharm Community Edition 2022.2.2\bin;;D:\Microsoft VS Code\bin;C:\Users\ch computers\AppData\Roaming\npm (Microsoft.ML.ModelBuilder.Utils.Logger.Debug)
2024-05-10 00:41:02.8471 DEBUG C:\Users\ch computers\AppData\Local\Temp\ModelBuilder\tensorflow-cpu.2.3.1\obj (Microsoft.ML.ModelBuilder.Utils.Logger.Debug)
2024-05-10 00:41:02.8581 INFO restore "C:\PROGRAM FILES\MICROSOFT VISUAL STUDIO\2022\COMMUNITY\COMMON7\IDE\COMMONEXTENSIONS\MICROSOFT\MODELBUILDER\AUTOMLSERVICE\RuntimeManager\tensorflow.cpu.csproj" --configfile "C:\PROGRAM FILES\MICROSOFT VISUAL STUDIO\2022\COMMUNITY\COMMON7\IDE\COMMONEXTENSIONS\MICROSOFT\MODELBUILDER\AUTOMLSERVICE\RuntimeManager\NuGet.config" -r win-x64 /p:UsingToolXliff=false /p:TorchSharpVersion=0.98.3 /p:TorchSharpCudaRuntimeVersion=<IP_ADDRESS> /p:TensorflowRuntimeVersion=2.3.1 /p:BaseIntermediateOutputPath="C:\Users\ch computers\AppData\Local\Temp\ModelBuilder\tensorflow-cpu.2.3.1\obj" (Microsoft.ML.ModelBuilder.Utils.Logger.Info)
2024-05-10 00:41:02.8581 INFO publish "C:\PROGRAM FILES\MICROSOFT VISUAL STUDIO\2022\COMMUNITY\COMMON7\IDE\COMMONEXTENSIONS\MICROSOFT\MODELBUILDER\AUTOMLSERVICE\RuntimeManager\tensorflow.cpu.csproj" -r win-x64 -c Release --no-self-contained -o C:\Users\ch computers\AppData\Local\Temp\ModelBuilder\tensorflow-cpu.2.3.1 --no-restore /p:UsingToolXliff=false /p:TorchSharpVersion=0.98.3 /p:TorchSharpCudaRuntimeVersion=<IP_ADDRESS> /p:TensorflowRuntimeVersion=2.3.1 /p:BaseOutputPath="C:\Users\ch computers\AppData\Local\Temp\ModelBuilder\tensorflow-cpu.2.3.1\bin\" /p:BaseIntermediateOutputPath="C:\Users\ch computers\AppData\Local\Temp\ModelBuilder\tensorflow-cpu.2.3.1\obj\" (Microsoft.ML.ModelBuilder.Utils.Logger.Info)
2024-05-10 00:41:02.8581 INFO start installing runtime in C:\Users\ch computers\AppData\Local\Temp\ModelBuilder\tensorflow-cpu.2.3.1 (Microsoft.ML.ModelBuilder.Utils.Logger.Info)
2024-05-10 00:41:04.7389 INFO   Determining projects to restore... (Microsoft.ML.ModelBuilder.Utils.Logger.Info)
2024-05-10 00:41:05.1698 INFO   All projects are up-to-date for restore. (Microsoft.ML.ModelBuilder.Utils.Logger.Info)
2024-05-10 00:41:05.7022 INFO MSBuild version 17.9.8+b34f75857 for .NET (Microsoft.ML.ModelBuilder.Utils.Logger.Info)
2024-05-10 00:41:05.7022 INFO MSBUILD : error MSB1008: Only one project can be specified. (Microsoft.ML.ModelBuilder.Utils.Logger.Info)
2024-05-10 00:41:05.7022 INFO     Full command line: 'C:\Program Files\dotnet\sdk\8.0.204\MSBuild.dll -maxcpucount -verbosity:m -target:Publish --property:_IsPublishing=true --property:UsingToolXliff=false --property:TorchSharpVersion=0.98.3 --property:TorchSharpCudaRuntimeVersion=<IP_ADDRESS> --property:TensorflowRuntimeVersion=2.3.1 --property:BaseOutputPath=C:\Users\ch computers\AppData\Local\Temp\ModelBuilder\tensorflow-cpu.2.3.1\bin\ --property:BaseIntermediateOutputPath=C:\Users\ch computers\AppData\Local\Temp\ModelBuilder\tensorflow-cpu.2.3.1\obj\ -property:PublishDir=C:\Users\ch -property:CommandLineDefinedOutputPath=true -property:SelfContained=False -property:CommandLineDefinedSelfContained=true -property:RuntimeIdentifier=win-x64 -property:CommandLineDefinedRuntimeIdentifier=true -property:Configuration=Release -property:DOTNET_CLI_DISABLE_PUBLISH_AND_PACK_RELEASE=true C:\PROGRAM FILES\MICROSOFT VISUAL STUDIO\2022\COMMUNITY\COMMON7\IDE\COMMONEXTENSIONS\MICROSOFT\MODELBUILDER\AUTOMLSERVICE\RuntimeManager\tensorflow.cpu.csproj computers\AppData\Local\Temp\ModelBuilder\tensorflow-cpu.2.3.1 -distributedlogger:Microsoft.DotNet.Tools.MSBuild.MSBuildLogger,C:\Program Files\dotnet\sdk\8.0.204\dotnet.dll*Microsoft.DotNet.Tools.MSBuild.MSBuildForwardingLogger,C:\Program Files\dotnet\sdk\8.0.204\dotnet.dll' (Microsoft.ML.ModelBuilder.Utils.Logger.Info)
2024-05-10 00:41:05.7022 INFO   Switches appended by response files: (Microsoft.ML.ModelBuilder.Utils.Logger.Info)
2024-05-10 00:41:05.7022 INFO Switch: computers\AppData\Local\Temp\ModelBuilder\tensorflow-cpu.2.3.1 (Microsoft.ML.ModelBuilder.Utils.Logger.Info)
2024-05-10 00:41:05.7022 INFO  (Microsoft.ML.ModelBuilder.Utils.Logger.Info)
2024-05-10 00:41:05.7022 INFO For switch syntax, type "MSBuild -help" (Microsoft.ML.ModelBuilder.Utils.Logger.Info)
2024-05-10 00:41:05.9482 INFO clean up (Microsoft.ML.ModelBuilder.Utils.Logger.Info)
2024-05-10 00:41:06.1022 DEBUG fail to install runtime
at Microsoft.ML.ModelBuilder.AutoMLService.RuntimeManager.InstallRuntimeAsync(CancellationToken ct) in //src/Microsoft.ML.ModelBuilder.AutoMLService/RuntimeManager/RuntimeManager.cs:line 56
at Microsoft.ML.ModelBuilder.AutoMLService.LocalImageClassificationExperiment.d__13.MoveNext() in //src/Microsoft.ML.ModelBuilder.AutoMLService/Experiments/LocalImageClassificationExperiment.cs:line 51
--- End of stack trace from previous location where exception was thrown ---
at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
at Microsoft.ML.ModelBuilder.AutoMLEngine.d__21.MoveNext() in //src/Microsoft.ML.ModelBuilder.AutoMLService/AutoMLEngineService/AutoMLEngine.cs:line 161 (Microsoft.ML.ModelBuilder.Utils.Logger.Debug)

@KashafRafiq Looks like you are running on an older version model builder, maybe upgrade model builder to latest version and try again?

@LittleLittleCloud

@LittleLittleCloud The extension is up to date anything else i can do to resolve this error??

@KashafRafiq From the log it seems to be from an older version model builder because it's installing runtime into temp folder..
Anyway, can you try manually run these commands to see what you get?
dotnet restore "C:\PROGRAM FILES\MICROSOFT VISUAL STUDIO\2022\COMMUNITY\COMMON7\IDE\COMMONEXTENSIONS\MICROSOFT\MODELBUILDER\AUTOMLSERVICE\RuntimeManager\tensorflow.cpu.csproj" --configfile "C:\PROGRAM FILES\MICROSOFT VISUAL STUDIO\2022\COMMUNITY\COMMON7\IDE\COMMONEXTENSIONS\MICROSOFT\MODELBUILDER\AUTOMLSERVICE\RuntimeManager\NuGet.config" -r win-x64 /p:UsingToolXliff=false /p:TorchSharpVersion=0.98.3 /p:TorchSharpCudaRuntimeVersion=<IP_ADDRESS> /p:TensorflowRuntimeVersion=2.3.1 /p:BaseIntermediateOutputPath="C:\Users\ch computers\AppData\Local\Temp\ModelBuilder\tensorflow-cpu.2.3.1\obj"

dotnet publish "C:\PROGRAM FILES\MICROSOFT VISUAL STUDIO\2022\COMMUNITY\COMMON7\IDE\COMMONEXTENSIONS\MICROSOFT\MODELBUILDER\AUTOMLSERVICE\RuntimeManager\tensorflow.cpu.csproj" -r win-x64 -c Release --no-self-contained -o C:\Users\ch computers\AppData\Local\Temp\ModelBuilder\tensorflow-cpu.2.3.1 --no-restore /p:UsingToolXliff=false /p:TorchSharpVersion=0.98.3 /p:TorchSharpCudaRuntimeVersion=<IP_ADDRESS> /p:TensorflowRuntimeVersion=2.3.1 /p:BaseOutputPath="C:\Users\ch computers\AppData\Local\Temp\ModelBuilder\tensorflow-cpu.2.3.1\bin\" /p:BaseIntermediateOutputPath="C:\Users\ch computers\AppData\Local\Temp\ModelBuilder\tensorflow-cpu.2.3.1\obj\"

@LittleLittleCloud

Oh I think I know where goes wrong. In the second publish commend, it’s missing a pair of “ “ for the -o flag. And because your user name contains a space that breaks the entire command line
We will push a fix for it and for the workaround you can manually add the “” to the publish command line
Get Outlook for iOShttps://aka.ms/o0ukef

From: KashafRafiq @.>
Sent: Friday, May 10, 2024 6:11:56 AM
To: dotnet/machinelearning-modelbuilder @.>
Cc: Mention @.>; Comment @.>; Subscribed @.***>
Subject: Re: [dotnet/machinelearning-modelbuilder] fail to install runtime (Issue #2737)
@LittleLittleCloudhttps://github.com/LittleLittleCloud
Screenshot.55.png (view on web)https://github.com/dotnet/machinelearning-modelbuilder/assets/113250485/1b50d7a6-757a-486c-9090-1bd02987b9f9
—
Reply to this email directly, view it on GitHubhttps://github.com/dotnet/machinelearning-modelbuilder/issues/2737#issuecomment-2104585850 or unsubscribehttps://github.com/notifications/unsubscribe-auth/AEAYLOTCWZFF2ZJW5IKRULLZBTBRZBFKMF2HI4TJMJ2XIZLTSOBKK5TBNR2WLJDUOJ2WLJDOMFWWLO3UNBZGKYLEL5YGC4TUNFRWS4DBNZ2F6YLDORUXM2LUPGBKK5TBNR2WLJDUOJ2WLJDOMFWWLLTXMF2GG2C7MFRXI2LWNF2HTAVFOZQWY5LFUVUXG43VMWSG4YLNMWVXI2DSMVQWIX3UPFYGLLDTOVRGUZLDORPXI6LQMWWES43TOVSUG33NNVSW45FGORXXA2LDOOJIFJDUPFYGLKTSMVYG643JORXXE6NFOZQWY5LFVEYTQNRZGE3TINJVQKSHI6LQMWSWS43TOVS2K5TBNR2WLKRRG44DIMJXHE4TMNVHORZGSZ3HMVZKMY3SMVQXIZI.
You are receiving this email because you were mentioned.
Triage notifications on the go with GitHub Mobile for iOShttps://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Androidhttps://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

@LittleLittleCloud Nothing happened, same error.

@LittleLittleCloud Same error , Nothing happened . I have changed my username what next to solve this error.

@KashafRafiq Looks like it's still related to the path. Let's start from the most basic publish command, please let me know if the following command works.
dotnet publish "C:\PROGRAM FILES\MICROSOFT VISUAL STUDIO\2022\COMMUNITY\COMMON7\IDE\COMMONEXTENSIONS\MICROSOFT\MODELBUILDER\AUTOMLSERVICE\RuntimeManager\tensorflow.cpu.csproj"

Once it work can you add the rest of options one by one and let me know which step it fails?

C:\Program Files\Microsoft Visual Studio\2022\Community>dotnet publish "C:\PROGRAM FILES\MICROSOFT VISUAL STUDIO\2022\COMMUNITY\COMMON7\IDE\COMMONEXTENSIONS\MICROSOFT\MODELBUILDER\AUTOMLSERVICE\RuntimeManager\tensorflow.cpu.csproj"
MSBuild version 17.9.8+b34f75857 for .NET
Determining projects to restore...
Failed to download package 'SciSharp.TensorFlow.Redist.1.14.0' from 'https://api.nuget.org/v3-flatcontainer/scisharp.
tensorflow.redist/1.14.0/scisharp.tensorflow.redist.1.14.0.nupkg'.
The download of 'https://api.nuget.org/v3-flatcontainer/scisharp.tensorflow.redist/1.14.0/scisharp.tensorflow.redist.
1.14.0.nupkg' timed out because no data was received for 60000ms.
Exception of type 'System.TimeoutException' was thrown.
Failed to download package 'SciSharp.TensorFlow.Redist.1.14.0' from 'https://api.nuget.org/v3-flatcontainer/scisharp.
tensorflow.redist/1.14.0/scisharp.tensorflow.redist.1.14.0.nupkg'.
No such host is known. (api.nuget.org:443)
No such host is known.
Failed to download package 'SciSharp.TensorFlow.Redist.1.14.0' from 'https://api.nuget.org/v3-flatcontainer/scisharp.
tensorflow.redist/1.14.0/scisharp.tensorflow.redist.1.14.0.nupkg'.
No such host is known. (api.nuget.org:443)
No such host is known.
Failed to download package 'SciSharp.TensorFlow.Redist.1.14.0' from 'https://api.nuget.org/v3-flatcontainer/scisharp.
tensorflow.redist/1.14.0/scisharp.tensorflow.redist.1.14.0.nupkg'.
No such host is known. (api.nuget.org:443)
No such host is known.
Failed to download package 'SciSharp.TensorFlow.Redist.1.14.0' from 'https://api.nuget.org/v3-flatcontainer/scisharp.
tensorflow.redist/1.14.0/scisharp.tensorflow.redist.1.14.0.nupkg'.
No such host is known. (api.nuget.org:443)
No such host is known.
C:\Program Files\dotnet\sdk\8.0.204\NuGet.targets(169,5): error : Failed to download package 'SciSharp.TensorFlow.Redis
t.1.14.0' from 'https://api.nuget.org/v3-flatcontainer/scisharp.tensorflow.redist/1.14.0/scisharp.tensorflow.redist.1.1
4.0.nupkg'. [C:\PROGRAM FILES\MICROSOFT VISUAL STUDIO\2022\COMMUNITY\COMMON7\IDE\COMMONEXTENSIONS\MICROSOFT\MODELBUILDE
R\AUTOMLSERVICE\RuntimeManager\tensorflow.cpu.csproj]
C:\Program Files\dotnet\sdk\8.0.204\NuGet.targets(169,5): error : No such host is known. (api.nuget.org:443) [C:\PROGRA
M FILES\MICROSOFT VISUAL STUDIO\2022\COMMUNITY\COMMON7\IDE\COMMONEXTENSIONS\MICROSOFT\MODELBUILDER\AUTOMLSERVICE\Runtim
eManager\tensorflow.cpu.csproj]
C:\Program Files\dotnet\sdk\8.0.204\NuGet.targets(169,5): error :   No such host is known. [C:\PROGRAM FILES\MICROSOFT
VISUAL STUDIO\2022\COMMUNITY\COMMON7\IDE\COMMONEXTENSIONS\MICROSOFT\MODELBUILDER\AUTOMLSERVICE\RuntimeManager\tensorflo
w.cpu.csproj]
Retrying 'FindPackagesByIdAsync' for source 'https://api.nuget.org/v3-flatcontainer/scisharp.tensorflow.redist/index.
json'.
No such host is known. (api.nuget.org:443)
No such host is known.
Retrying 'FindPackagesByIdAsync' for source 'https://api.nuget.org/v3-flatcontainer/scisharp.tensorflow.redist/index.
json'.
No such host is known. (api.nuget.org:443)
No such host is known.
Retrying 'FindPackagesByIdAsync' for source 'https://api.nuget.org/v3-flatcontainer/scisharp.tensorflow.redist/index.
json'.
No such host is known. (api.nuget.org:443)
No such host is known.
Retrying 'FindPackagesByIdAsync' for source 'https://api.nuget.org/v3-flatcontainer/scisharp.tensorflow.redist/index.
json'.
No such host is known. (api.nuget.org:443)
No such host is known.
Retrying 'FindPackagesByIdAsync' for source 'https://api.nuget.org/v3-flatcontainer/scisharp.tensorflow.redist/index.
json'.
No such host is known. (api.nuget.org:443)
No such host is known.
C:\PROGRAM FILES\MICROSOFT VISUAL STUDIO\2022\COMMUNITY\COMMON7\IDE\COMMONEXTENSIONS\MICROSOFT\MODELBUILDER\AUTOMLSERVI
CE\RuntimeManager\tensorflow.cpu.csproj : error NU1301: Failed to retrieve information about 'SciSharp.TensorFlow.Redis
t' from remote source 'https://api.nuget.org/v3-flatcontainer/scisharp.tensorflow.redist/index.json'.
C:\Program Files\dotnet\sdk\8.0.204\NuGet.targets(169,5): error : Access to the path 'C:\PROGRAM FILES\MICROSOFT VISUAL
STUDIO\2022\COMMUNITY\COMMON7\IDE\COMMONEXTENSIONS\MICROSOFT\MODELBUILDER\AUTOMLSERVICE\RuntimeManager\obj' is denied.
[C:\PROGRAM FILES\MICROSOFT VISUAL STUDIO\2022\COMMUNITY\COMMON7\IDE\COMMONEXTENSIONS\MICROSOFT\MODELBUILDER\AUTOMLSER
VICE\RuntimeManager\tensorflow.cpu.csproj]
@LittleLittleCloud

@KashafRafiq
Maybe add a nuget source?
dotnet publish "C:\PROGRAM FILES\MICROSOFT VISUAL STUDIO\2022\COMMUNITY\COMMON7\IDE\COMMONEXTENSIONS\MICROSOFT\MODELBUILDER\AUTOMLSERVICE\RuntimeManager\tensorflow.cpu.csproj" --configfile "C:\PROGRAM FILES\MICROSOFT VISUAL STUDIO\2022\COMMUNITY\COMMON7\IDE\COMMONEXTENSIONS\MICROSOFT\MODELBUILDER\AUTOMLSERVICE\RuntimeManager\NuGet.config"

Hi guys!
Faced the same problem....

VS version: 17.10.3
ML.NET Model Builder 2022: <IP_ADDRESS>5501
I am not a professional programmer, but I have read and tried the proposed solutions to the problem (set 'MODEL_BUILDER_ENABLE_ELEVATED_CHECK' to 'FALSE') - it's not working for me.
And yet, trying the options suggested above, I discovered that in my directory "C:\PROGRAM FILES\MICROSOFT VISUAL STUDIO\2022\COMMUNITY\COMMON7\IDE\COMMONEXTENSIONS\MICROSOFT" the MODELBUILDER folder is missing.
I don’t really understand, is it supposed to be like this or is it just me who has this problem?

The problem is solved.
By misunderstanding I set 'MODEL_BUILDER_ENABLE_ELEVATED_CHECK' to 'FALSE' in the settings of environment variables solutions in VISUAL STUDIO, but should have been installed in the OPERATING SYSTEM settings (System properties -> Environment variables)


Shadows in VoxelGI voxel scene that do not appear in the rendered scene

Godot version
4.1.3, 4.2.6
System information
Godot v4.2.beta6 - Windows 10.0.19045 - Vulkan (Forward+) - dedicated NVIDIA GeForce GTX 1650 (NVIDIA; <IP_ADDRESS>34) - AMD Ryzen 3 2200G with Radeon Vega Graphics (4 Threads)
Issue description
While using VoxelGI for indirect lighting, the voxel representation of the scene renders a shadow that isn't actually there in the real rendered scene. These non-existing shadows then lead to innaccurate global Illumination. This happens with both Spotlights and Omnilights. When shadow casting is turned off for the light, the non-existing shadows disappear (Along with, obviously all shadows).

Steps to reproduce

Open the scene "test_scene.tscn"
On the "Display Advanced..." options of the preview camera, click on "VoxelGI Lighting"
See the shadow being rendered in the voxel world that is not happening in the normal world.
Select the "Spotlight3D"
Disable the shadow casting option
See the glitched shadow disappear in the voxel world

Minimal reproduction project
ReproVoxelGI.zip

Looks like VoxelGI is very sensitive / buggy if its size is not an even box, possibly related to https://github.com/godotengine/godot/issues/62930. Simply setting VoxelGI size to 20x20x20 in the test project and rebaking seems to fix the main issue. Setting the size even a little uneven like 20x20.1x20 changes the visuals quite a lot.

Thanks for looking into it. Seems like voxelization is very sensitive to the offset of the transform too.


python312Packages.great-tables: add python312Packages.shiny for tests

Description of changes
The shiny python package is available for nixpkgs so I've added it for the tests. Also tested the build on Linux, it's working well!
fyi: @GaetanLepage
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.


Wrappers: Extend and document the makeNixvim function

The build function has be changed to the makeNixvim function. This also adds a full example of flake that allows to include nixvim.

I'll come back later to this PR, I first want to see if I can't revamp a bit the makeNixvim function.

As the changes to makeNixvim were quite small I added them to this PR, updating the title in consequence


fix(mux): nvim-wezterm panes not seamlessly switching while using wsl2

Issue
When using wsl in wezterm ( installed on windows ), the cursor does switch from wezterm to nvim, however it doesn't switch from nvim to wezterm.
Cause
As mentioned, the plugin is using wezterm cli for switching panes, however the command 'wezterm' is not recognized in WSL environment therefore the switching doesn't work.
Solution
Check if the environment is WSL and use the command 'wezterm.exe' instead of 'wezterm' ( note: this works only if the wezterm path on windows is set correctly on WSLENV ).

note: this works only if the wezterm path on windows is set correctly on WSLENV

I'm not familiar with Windows or WSL, could you explain what this means a bit more?

I also wonder if maybe we should just also allow the user to provide a custom path to the wezterm binary in case the CLI is not on $PATH

Oh, and as always, thank you for the PR!

I also wonder if maybe we should just also allow the user to provide a custom path to the wezterm binary in case the CLI is not on $PATH

Yes, that sounds good.
Based on my understand of this conversation and my knowledge ( based off of tinkering with nvim and the plugin ), I've added a way provide a custom path, if it can be improved please let me know.

Now the configuration part is completely on the user's end, let me know what you think.
For me it looks like this:

I ran into this same issue, and the snippet given above fixed it, so thanks @Mr-Hypocrite for the fix. Just commenting to note that things were not currently working out of the box for my wsl2 setup,


Add v_diffusion_pytorch model in shark/tank

This is working fine completely. I have tested it locally. It just needs this PR: https://github.com/llvm/torch-mlir/pull/1235


Revert "Convert dashboard templates to new format and add validations"

This reverts commit aeea037b8b725192522c972ad80290313f8351c7.
We need to revert these changes while troubleshooting an issue where only the last widget of a dashboard is shown.

fixed it in other magical ways.


Ctrl-C (Copy) when nothing is selected empties the clipboard and replaces it with the current line

I sometimes fat finger Ctrl-C when I'm trying to place the contents of my clipboard at the cursor location using Ctrl-V.  Unfortunately, when I do, Brackets replaces the contents of the clipboard with the current line of text.  For me, it would be beneficial to not copy anything to the clipboard when nothing is selected.  For me that would save time of having to undo, re-select text and paste.
If that feature is desired by some, perhaps consider making it optional in the brackets.json file.
Thanks.  I do love Brackets.

Duplicate of https://github.com/adobe/brackets/issues/9311. Closing.


Backend server won't start

when i start server i this got error:
[ERROR] 07:23:32 Error: Cannot register a type name as a singleton without a "to" token

Hello @gondfreecs, thanks for reporting this, ill look into it. Not entirely sure, but i believe you also need a database running to be able to run locally. If it is confirmed then I will update de documentation!

Yeah that is it @gondfreecs! My documentation on how to run needs to be updated, you see, there is a file in the src folder called .env.example which holds the environment variables this app needs to run. This file needs to be renamed to .env, and the variables set properly.
The provider is throwing that exception because you probably didn't renamed the file and so the env.STORAGE_DRIVER is null when it should be set to 'disk' locally, but you also would need a local database running, the same process needs to be done with the file ormconfig.json.example.
I'll update the documentation explaining the whole process better so you can run it.

Ho man, thank you for ur reactivity
i create an db redis but i don't really know which parameter i need and where i can find it
i use this command:
docker run --name redisimageName -p 6379:6379 -d -t redis:alpine

Well fixing documentation will take sometime (because it's really outdated), but to help you, considerer this:
This app uses 3 databases: mongo, postgres, and redis (for cache management).
The ormconfig file will only hold the info for postgres and mongo:
You will need to provide the 'username', 'password' and 'database' name of your local databases  for it to work, both for postgres and mongo. You can install them using docker, but i don't have the full command line for this at hand so ill write that down in documentation later but you can google that and fill the following fields, the 'name' is also a parameter when you install the using docker i guess.
[
  {
    "name": "",
    "type": "postgres",
    "host": "localhost",
    "post": 9999,
    "username": "",
    "password": "",
    "database": "",
    "entities": [
      "./src/modules/**/infra/typeorm/entities/*.ts"
    ],
    "migrations": [
      "./src/shared/infra/typeorm/migrations/*.ts"
    ],
    "cli": {
      "migrationsDir": "./src/shared/infra/typeorm/migrations"
    }
  },
  {
    "name": "",
    "type": "mongodb",
    "host": "localhost",
    "port": 9999,
    "database": "",
    "useUnifiedTopology": true,
    "entities": [
      "./src/modules/**/infra/typeorm/schemas/*.ts"
    ]
  }
]

For redis, you will have to provide the 3 environment variables in .env file:
REDIS_HOST=localhost
REDIS_PORT=YOUR LOCAL PORT NUMBER REDIS IS RUNNING
REDIS_PASSWORD=THE PASSWORD YOU SET UP WHEN INSTALLING REDIS
I am not 100% sure but the command should be:
docker run -d --name "YOUR REDIS SERVER NAME" -e REDIS_PASSWORD="A PASSWORD FOR YOUR REDIS SERVER" -p "SERVER PORT":"LOCAL PORT ON YOUR MACHINE" bitnami/redis:latest

You could try that without quotes, to get redis up and running.
I'll explain the process better once the documentation is updated, but maybe this can get your started.

Thank you a lot, actually i have a probleme to setup all my var env can i have a good sample of ormconfig.json and .env

Hey @gondfreecs, check out the readme inside backend's folder:

https://github.com/AlvaroIsrael/gobarber-app/blob/master/gobarber-backend/README.md
I updated the documentation (#136), hope it helps, if it does please leave a comment here so I can close this issue.

If it does not you can keep replying here. I will work on it until it works!
PS.: You will need to install docker on your local machine, so don't forget that because the tutorial does not cover a guide on how to install docker.

Well @gondfreecs I will be closing this issue for now because i didn't get a reply after 13 days. In the future, if you decide to revisit this project, let me know! Thanks!


Add javadoc to ConsoleIO

Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Make sure there is a JIRA issue filed for the change (usually before you start working on it).  Trivial changes like typos do not require a JIRA issue.  Your pull request should address just this issue, without pulling in other changes.
[ ] Each commit in the pull request should have a meaningful subject line and body.
[ ] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue.
[ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
[ ] Run mvn clean verify to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

@staslev Please review

Retest this please

Retest this please

@staslev changes made.

LGTM.
I'll merge this in once the tests pass.

Changes Unknown when pulling fd43fbbd7e780165cff5f94f0cf0777639712b1a on joeyfezster:consoleIO_javadoc_update into ** on apache:master**.

Just noticed that something is wrong with the formatting.
This looks a bit off:
      /**
       * Prints {@value #DEFAULT_NUM} elements from the {@link PCollection} to stdout.
       */
      public static <T> Unbound<T> out() {
      return new Unbound<>(DEFAULT_NUM);
    }

Could you please fix?
(You're welcome to use an auto-formatter)

Code rebased and formatted

Coverage increased (+0.006%) to 69.513% when pulling 04580c1e0c3882310f40606188b9161f471ff506 on joeyfezster:consoleIO_javadoc_update into 50532f0a92d7ce8dbbdc6c3179ab7b9efde6a746 on apache:master.

Coverage decreased (-0.01%) to 69.496% when pulling 04580c1e0c3882310f40606188b9161f471ff506 on joeyfezster:consoleIO_javadoc_update into 50532f0a92d7ce8dbbdc6c3179ab7b9efde6a746 on apache:master.

Squashed

Retest this please

Coverage increased (+0.003%) to 69.509% when pulling 3272265b41f8044afa0d5865b8ba94a5448193e0 on joeyfezster:consoleIO_javadoc_update into 50532f0a92d7ce8dbbdc6c3179ab7b9efde6a746 on apache:master.

@staslev  About the changes you saw before, they probably were committed between testing (twice because of the known fails).
Fresh rebase, updated to your latest remarks, and re-pushed.


Fix Art-peace

Description
We need to fix our Art-peace repo, that's need to correctly for on Sepolia Testnet.
Requirements to run the Art-peace part:
Run PWA in /apps/pwa
Test it in Mobile
Run Backend Golang in /backend
Add .env in /apps/pwa: NEXT_PUBLIC_CANVAS_STARKNET_CONTRACT_ADDRESS=0x1c3e2cae24f0f167fb389a7e4c797002c4f0465db29ecf1753ed944c6ae746e
Todo
UI:

[ ] Connect account fixed (you can directly place pixel without reload)
[ ] Fix Session Wallet
[ ] Fix Username store when logged
[ ] Everything work smoothly and LFG

Indexer:

[ ] When you click in a Pixel, that's need to create a TX : add the Art-peace address deploy, available in the /packages/common or here: 0x1c3e2cae24f0f167fb389a7e4c797002c4f0465db29ecf1753ed944c6ae746e
[ ] Check if Pixel are saved in Redis/DB
[ ] Fix indexer Art-peace

I am applying to this issue via OnlyDust platform.
My background and how it can be leveraged
Can I handle this task?

I am applying to this issue via OnlyDust platform.
My background and how it can be leveraged
I have been a developer for over 4 years and have been contributing to the Starknet ecosystem for more than a year. My recent contributions include work on cairo-lint and scaffold-starknet. I’m eager to participate in this project as I see a lot of potential in it and believe it adds valuable functionality to the Starknet ecosystem.
How I plan on tackling this issue
I would start by setting up the environment as outlined in the issue, ensuring both the PWA and backend are correctly running in Sepolia Testnet.
Add Contract and Connect Account: First, I will ensure that the correct contract is set in the PWA using the provided address, and then verify that the account connection works seamlessly by debugging the connection flow.
Handle Pixel Interaction: I will implement the logic that triggers a transaction whenever a pixel is clicked, utilizing the provided Art-peace contract address. This will involve connecting the frontend to the StarkNet wallet and creating a transaction to update the pixel data.
Pixel Persistence: After the transaction, I will verify if the pixel's data is correctly stored in the Redis/DB. If necessary, I will debug the integration with the backend services to ensure data is persistently saved.
Fix Indexer for Art-peace: Finally, I will review the indexer to ensure it's functioning correctly with the Art-peace contract and reflect any updates from the transactions made on the pixels. This will involve analyzing logs and traces to fix any issues with the current indexing mechanism.

I am applying to this issue via OnlyDust platform.
My background and how it can be leveraged
Backend Developer | Automation Enthusiast
I'm a backend developer driven by a passion for continuous learning. I focus on acquiring new skills either based on project needs or out of personal curiosity. My approach is centered on providing practical solutions to processes that take up too much time. If something can be automated, I rarely do it more than twice. I enjoy creating bash scripts to speed up my workflow.
I have experience in Go, JavaScript, Python, Docker, MongoDB, and I use Git for version control to ensure seamless development.
"Laziness is the mother of automation."
How I plan on tackling this issue
The first thing I do is analyze the potential impact. Then, I review the functions involved leading up to the issue. After that, I focus on the specific function, checking the logic that might be causing the problem.

hey @MSghais, can I work on this?

@MSghais can I work on this?  ETA<=24hrs

@MSghais I have gone through the description, and I can work on this!

I am applying to this issue via OnlyDust platform.
My background and how it can be leveraged
hello @ i'm an experienced frontend developer and a blockchain developer  i would love to work on this issue
Pleasee kindly assign :)

I am applying to this issue via OnlyDust platform.
My background and how it can be leveraged
i have experience in blockchain previously as personal projects and OS, so hoping to make use of them here and mark my first odhack contribution

I am applying to this issue via OnlyDust platform.
My background and how it can be leveraged
I am a rust dev. A new-comer here, willing and ready to contribute to contribute to solve the issue.

Can I start working on this?

Mind if I take this issue?

I’d like to work on this,
ETA: 2-3 days at max

Can I jump on this task?

Can I take this from here?

Is it okay if I take this?

I'd like to handle this task.

Can I take this from here?

Could I take a shot at this?

I’m interested in this one.

Can I jump on this task?

Could I take a shot at this?

Can I be assigned to this?

I’d like to help with this.

Can I start working on this?

Can I take this issue?


nixfmt-classic: Stop using the hackage package

Removes dependency on the hackage package so we can finally fix https://github.com/NixOS/nixfmt/issues/161 and also moves the entire package to pkgs/by-name.

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

cc @NixOS/nix-formatting

Add a :+1: reaction to pull requests you find important.

I don't think this is neccessary. Hackage is append only. nixfmt can never be removed there. I see no reason not to fetch the old version from there.
Or is the maintainer team planning to release updates for the classic version?

Thanks for that info, didn't know that. No, we (the formatting team) are not planning to release updates.


pythonPackages.pyslurm compilation fails on master (and older)

Issue description
I am trying to make a nox-review succeed on a slightly old checkout of master but for some reason it triggers the compilation of pyslurm which fails. I 've tried on latest master and the error persists; nix-build -A pythonPackages.pyslurm gives:
these derivations will be built:
  /nix/store/nz722nxxn86xhzzyvfnx7j77crjk8r50-python2.7-pyslurm-20171102.drv
building '/nix/store/nz722nxxn86xhzzyvfnx7j77crjk8r50-python2.7-pyslurm-20171102.drv'...
unpacking sources
unpacking source archive /nix/store/a1ba8sy4fpq4bnpg1hq92p0bcq2hy5q9-source
source root is source
setting SOURCE_DATE_EPOCH to timestamp 315619200 of file source/tests/test-topology.py
patching sources
configuring
building
INFO:root:Info:
INFO:root:Info: Building PySlurm (17.02.0)
INFO:root:Info: ------------------------------
INFO:root:Info:
INFO:root:Info: Cython version 0.27.3 installed

INFO:root:Info: Clean - checking for objects to clean
INFO:root:Info: Clean - completed
INFO:root:Info: Build - Detected Slurm include file version - 0x110b03 (17.11.03)
ERROR:root:Fatal: Build - Incorrect slurm version detected, require Slurm-17.02.00 to slurm-17.02.09
note: keeping build directory '/tmp/nix-build-python2.7-pyslurm-20171102.drv-3'
builder for '/nix/store/nz722nxxn86xhzzyvfnx7j77crjk8r50-python2.7-pyslurm-20171102.drv' failed with exit code 1
error: build of '/nix/store/nz722nxxn86xhzzyvfnx7j77crjk8r50-python2.7-pyslurm-20171102.drv' failed

For now I commented out the derivation but @veprbl could you fix it please ? I think  you can also get rid of the  name = pname + "-" + version;
Technical details
fails on current master in sandboxed mode :  453a60ed9556f4cbbd1d3868419abd0a6c35992b

Sure. But it will break soon again: #37117

ty !


Ping does not work after rclc_support_init is called

Description

Hardware description: Nucleo F746ZG
RTOS: Zephyr 3.1.99, Zephyr SDK 0.14.0
Installation type: micro_ros_zephyr_module
Version or commit hash: galactic
Transport: UDP IPv4
Agent: microros/micro-ros-agent:galactic docker image

It seems the rmw_uros_ping_agent always returns RMW_RET_ERROR after the rclc_support_init is called.
(Please correct me if this is not the right place for this issue)
Steps to reproduce the issue
Two tests were tried to reproduce the problem. The agent was kept alive during the test.

First, I tried the apps/micro-ros_reconnection from this repository.
Second, I tried to simplify that program to reveal the real cause. The simplified program is attached in the "Additional information" part below. What it does is to wait until the agent is available, initialize the rclc_support_t, and then check the agent's availability again with ping.

Expected behavior

For the first test (official demo), the state machine should stay at the AGENT_CONNECTED state.
For the second test (my custom test), it should keep printing loop 0|1|2|....

Actual behavior
The firmware keeps connecting to and disconnecting from the agent repeatedly.
The log from the first test (official demo)
[00:00:00.000,000] <inf> can_stm32: Init of CAN_1 done
[00:00:02.478,000] <err> eth_stm32_hal: Failed to enqueue frame into RX queue: -115
[00:00:02.480,000] <inf> uros_transport: Waiting for uROS agent.

[00:00:03.487,000] <inf> uros_transport: Connected to uROS agent and created entities.
[00:00:03.988,000] <inf> uros_transport: Disconnected from agent. Switching to waiting for uROS agent

[00:00:03.996,000] <inf> uros_transport: Waiting for uROS agent.

[00:00:05.004,000] <inf> uros_transport: Connected to uROS agent and created entities.
[00:00:05.504,000] <inf> uros_transport: Disconnected from agent. Switching to waiting for uROS agent

[00:00:05.513,000] <inf> uros_transport: Waiting for uROS agent.

The log from the second test (my custom test)
[00:00:00.000,000] <inf> can_stm32: Init of CAN_1 done
[00:00:02.393,000] <err> eth_stm32_hal: Failed to enqueue frame into RX queue: -115
[00:00:02.394,000] <inf> microros: Found the microros agent.
[00:00:04.396,000] <inf> microros: Disconnect from the microros agent
[00:00:05.397,000] <inf> microros: Found the microros agent.
[00:00:07.400,000] <inf> microros: Disconnect from the microros agent
[00:00:08.400,000] <inf> microros: Found the microros agent.
[00:00:10.402,000] <inf> microros: Disconnect from the microros agent
[00:00:11.403,000] <inf> microros: Found the microros agent.

Additional information
Test program
The program I used for the test is as follows.
#include <stdint.h>

#include "zephyr.h"
#include "zephyr/logging/log.h"

// microros
#include "microros_transports.h"
#include "rcl/rcl.h"
#include "rclc/rclc.h"
#include "rmw_microros/rmw_microros.h"

LOG_MODULE_REGISTER(microros);

#define RCCHECK(fn)                                              \
  {                                                              \
    rcl_ret_t temp_rc = fn;                                      \
    if ((temp_rc != RCL_RET_OK)) {                               \
      LOG_ERR("line %d: error %d.", __LINE__, (int)(temp_rc));   \
    }                                                            \
  }

void main() {
  rmw_uros_set_custom_transport(MICRO_ROS_FRAMING_REQUIRED, (void*)(&default_params), &zephyr_transport_open,
                                &zephyr_transport_close, &zephyr_transport_write, &zephyr_transport_read);
  while (true) {
    while (rmw_uros_ping_agent(100, 1) != RMW_RET_OK) {
      LOG_INF("Waiting for microros agent...");
      k_msleep(1000);
    }
    LOG_INF("Found the microros agent.");

    rcl_allocator_t allocator;
    rclc_support_t support;
    allocator = rcl_get_default_allocator();
    RCCHECK(rclc_support_init(&support, 0, NULL, &allocator))
    k_msleep(1000);

    size_t loop_count = 0;
    while (rmw_uros_ping_agent(1000, 1) == RMW_RET_OK) {
      LOG_INF("loop %d", loop_count++);
      k_msleep(1000);
    }

    RCCHECK(rclc_support_fini(&support))
    LOG_INF("Disconnect from the microros agent");
    k_msleep(1000);
  }
}

Agent log
The agent verbose level is set to 4, and the INFO level agent log is as follows.
[1656710159.408739] info     | UDPv4AgentLinux.cpp | init                     | running...             | port: 8888
[1656710159.408878] info     | Root.cpp           | set_verbose_level        | logger setup           | verbose_level: 4
[1656710160.147612] info     | Root.cpp           | create_client            | create                 | client_key: 0x57995EE5, session_id: 0x81
[1656710160.147740] info     | SessionManager.hpp | establish_session        | session established    | client_key: 0x57995EE5, address: <IP_ADDRESS>:19125
[1656710162.149116] info     | Root.cpp           | delete_client            | delete                 | client_key: 0x57995EE5
[1656710162.149203] info     | SessionManager.hpp | destroy_session          | session closed         | client_key: 0x57995EE5, address: <IP_ADDRESS>:19125
[1656710163.151464] info     | Root.cpp           | create_client            | create                 | client_key: 0x567B653D, session_id: 0x81
[1656710163.151542] info     | SessionManager.hpp | establish_session        | session established    | client_key: 0x567B653D, address: <IP_ADDRESS>:4599
[1656710165.152946] info     | Root.cpp           | delete_client            | delete                 | client_key: 0x567B653D
[1656710165.153018] info     | SessionManager.hpp | destroy_session          | session closed         | client_key: 0x567B653D, address: <IP_ADDRESS>:4599

Which version of the micro-ROS Agent are you using?


PackageManager Async methods occasionally never complete

The AddPackageAsync, RemovePackageAsync, and StagePackageAsync methods in the PackageManager class occasionally fail to complete, causing the application to be indefinitely stuck in a waiting state. This issue is related to the one reported in CsWinRT issue #1720, but we have identified additional problematic methods in PackageManager. I won't be surprised if all PackageManager async methods to suffer from this issue, so far all methods that we attempted to use are buggy.
How to Reproduce
Compile the provided code in Release mode. We haven't tried Debug but from our previous experience with  CsWinRT issue #1720 I might guess this is only Release build issue.
Execute the code, which repeatedly calls the StagePackageAsync, RegisterPackageByFamilyNameAsync, and RemovePackageAsync methods in a loop.
Observe that the task returned by StagePackageAsync frequently fails to complete, although RemovePackageAsync is also occasionally affected. When this happens a timeout exception is thrown, because of the CircuitBreaker. If you remove the CircuitBreaker the loop will be stuck on the await forever.
Observations
The issue typically reproduces at least once in every 500 iterations. Some machines exhibiting the problem more frequently than others.
Attaching a debugger reveals a worker thread perpetually waiting for task completion.
Attempts to resolve this by synchronously calling the async methods using GetAwaiter().GetResult() were unsuccessful.
The problem occurs on both Windows 10 and Windows 11 machines across various versions of the microsoft.windows.sdk.net.ref NuGet package.
Code Sample
<Project Sdk="Microsoft.NET.Sdk">

  <PropertyGroup>
    <OutputType>Exe</OutputType>
    <TargetFramework>net8.0-windows10.0.17763.0</TargetFramework>
    <ImplicitUsings>enable</ImplicitUsings>
    <Nullable>enable</Nullable>
    <Platforms>x64</Platforms>
  </PropertyGroup>

</Project>

using System;
using Windows.Management.Deployment;

namespace TestPackageInstall
{
    internal class Program
    {
        static async Task Main(string[] args)
        {
            string timestamp = DateTime.Now.ToString("HH:mm:ss");
            int numberOfSuccessfullInstallation = 0;
            int numberOfFailedInstallationWithTimeout = 0;
            int numberOfFailedInstallationUnknown = 0;

            while (true)
            {
                try
                {
                    // Create an instance of PackageManager
                    PackageManager packageManager = new PackageManager();

                    // Get the current time as a string in the format HH:MM:SS
                    timestamp = DateTime.Now.ToString("HH:mm:ss");

                    // Print the log messages with the timestamp
                    Console.WriteLine($"[{timestamp}] Number of successful installations: {numberOfSuccessfullInstallation}");
                    Console.WriteLine($"[{timestamp}] Number of failed installations, because of timeout: {numberOfFailedInstallationWithTimeout}");
                    Console.WriteLine($"[{timestamp}] Number of failed installations: {numberOfFailedInstallationUnknown}");
                    Console.WriteLine($"[{timestamp}] Staging...");

                    // Define the URI for the package
                    var uri = new Uri("https://storage.googleapis.com/ms-apps-bucket-exp/update/com.mobisystems.windows.appx.mobipdf/10.0.57990/full/MobiPDF.Package_10.0.57990.0_x64.msix");

                    // Attempt to stage the package
                    CircuitBreaker circuitBreaker = new CircuitBreaker();
                    await circuitBreaker.ExecuteAsync(async () => await packageManager.StagePackageAsync(uri, null).AsTask().ConfigureAwait(false), TimeSpan.FromMinutes(15)).ConfigureAwait(false);

                    timestamp = DateTime.Now.ToString("HH:mm:ss");
                    Console.WriteLine($"[{timestamp}] Register...");

                        // Register the package by family name
                        await packageManager.RegisterPackageByFamilyNameAsync("MobiSystems.MobiPdf_bvgb55c3tfatp", null, DeploymentOptions.ForceTargetApplicationShutdown, packageManager.GetDefaultPackageVolume(), null)
                            .AsTask(new ConsoleDeploymentProgress("RegisterPackage"))
                            .ConfigureAwait(false);

                    // Increment the success counter
                    numberOfSuccessfullInstallation++;

                    timestamp = DateTime.Now.ToString("HH:mm:ss");
                    Console.WriteLine($"[{timestamp}] Uninstall...");

                    // Remove the package
                    await packageManager.RemovePackageAsync("MobiSystems.MobiPdf_10.0.57990.0_x64__bvgb55c3tfatp")
                        .AsTask(new ConsoleDeploymentProgress("RemovePackage"))
                        .ConfigureAwait(false);
                }
                catch (TimeoutException)
                {
                    timestamp = DateTime.Now.ToString("HH:mm:ss");

                    Console.WriteLine($"*********************************************************");
                    Console.WriteLine($"*********************************************************");
                    Console.WriteLine($"*********************************************************");
                    Console.WriteLine($"*********************************************************");
                    Console.WriteLine($"*********************************************************");
                    Console.WriteLine($"*********************************************************");
                    numberOfFailedInstallationWithTimeout++;
                }
                catch (Exception ex)
                {
                    timestamp = DateTime.Now.ToString("HH:mm:ss");

                    Console.WriteLine($"[{timestamp}] Exception: {ex.Message}");
                    numberOfFailedInstallationUnknown++;
                }

                timestamp = DateTime.Now.ToString("HH:mm:ss");
                // Clear the console for the next iteration
                Console.WriteLine($"[{timestamp}] ===============================================================");
            }
        }

        public class ConsoleDeploymentProgress : IProgress<DeploymentProgress>
        {
            private readonly string operationType;

            public ConsoleDeploymentProgress(string operationType)
            {
                this.operationType = operationType;
            }

            public void Report(DeploymentProgress value)
            {
                // Get the current time as a string in the format HH:MM:SS
                string timestamp = DateTime.Now.ToString("HH:mm:ss");
                Console.WriteLine($"[{timestamp}] {operationType} progress: {value.percentage}");
            }
        }

        public class CircuitBreaker
        {
            public async Task<T> ExecuteAsync<T>(Func<Task<T>> asyncMethod, TimeSpan timeout)
            {
                using (var cts = new CancellationTokenSource())
                {
                    var task = asyncMethod();
                    var completedTask = await Task.WhenAny(task, Task.Delay(timeout, cts.Token)).ConfigureAwait(false);

                    if (completedTask == task)
                    {
                        // Cancel the delay task if the main task completes first
                        cts.Cancel();
                        return await task.ConfigureAwait(false); // Unwrap and return the result
                    }
                    else
                    {
                        throw new TimeoutException("The operation has timed out.");
                    }
                }
            }
        }
    }
}

Example call stack when the method freezes

We have identified additional details regarding this issue. By passing a CancellationToken to the affected methods, the freezing problem is resolved. Here is an example of how to implement this:
using(CancellationTokenSource cts = new CancellationTokenSource ())
{
await packageManager.StagePackageAsync(uri, null).AsTask(cts .Token)
}

Using this approach, we conducted thousands of package installations with AddPackageAsync and StagePackageAsync, and none of these operations froze, unlike when they were executed without a CancellationToken. We hope this information helps in addressing the issue or provides a viable workaround.

Hi thank you for your possible solution. But I do not get why it can solve the problem. Is there other place will call cts.cancel()?

We figure out that by performing tests. I have no idea why this work.

Ok thank you.


dita executable does not parse multiple DITAVALS on Windows 10 CLI

On Linux and MacOS, I can specify multiple DITAVAL files separated by a ":" (colon) to be processed. The following works fine with the sample files I have attached.
/Users/stanleydoherty/Desktop/dita-ot/bin/dita    --input=./test_006_cli-ditavals.ditamap    --format=html5 --output=output/html5    --filter=test_006_cli-ditavals_exclude-platform-red.ditaval:test_006_cli-ditavals_exclude-product-green.ditaval:test_006_cli-ditavals_exclude-audience-blue.ditaval
The dita executable does not parse the equivalent argument separation character for Windows, ";" (semicolon). Colon and comma do not work either.
Here's the Windows 10 command line.
C:\git\dita-ot-feature-tests>c:\dita-ot\bin\dita    --input=./test_006_cli-ditavals.ditamap    --format=pdf    --output=output\pdf --filter=test_006_cli-ditavals_exclude-platform-red.ditaval;test_006_cli-ditavals_exclude-product-green.ditaval;test_006_cli-ditavals_exclude-audience-blue.ditaval
The dita executable reports:
Error: Target "test_006_cli-ditavals_exclude-product-green.ditaval" does not exist in the project "DOST".
Here are my text files.
multiple-ditavals-cli_windows.zip
Stan Doherty
<EMAIL_ADDRESS>

I've found that I have to put the values in quotes when calling from the DOS command line (on both Windows 7 and Windows 10) -- so try the command like this:
--filter="test_006_cli-ditavals_exclude-platform-red.ditaval;test_006_cli-ditavals_exclude-product-green.ditaval;test_006_cli-ditavals_exclude-audience-blue.ditaval"
I had the same error you did at some point, tried the quotes, and didn't think more about it -- but seeing the question here I wonder if our docs need updating for this.

Stan confirmed that adding quotes resolved the issue.
I'm not sure if this has always been a requirement but I know I've been using it for quite a while.
@infotexture -- not sure how best to handle in the docs, would it be appropriate to add the quote requirement into the existing note after args.filter here? https://www.dita-ot.org/dev/parameters/parameters-base.html#base__args.filter

Assuming the quoted value will do no harm on macOS and Linux, I added the info to the args.filter parameter description and to the corresponding --filter entry in Building output using the dita command with dita-ot/docs@5e8d883.


Minor fixes + sitemap generation

#621 skip code eval for delayed pages
#599 remove quotes for anchor generation
#491 add sitemap generation
introduce aliases for common global variables

prefix => prepath
base_path => prepath
base_url => website_url

Sitemap generation
global vars

website_url (also used for RSS)
generate_sitemap true|false

local vars

sitemap_exclude false|true
sitemap_changefreq "monthly" | "always", "hourly", "daily", "weekly", "yearly", "never"
sitemap_lastmod (extracted from file last modification)
sitemap_priority 0.5 | [0, 1]

hfun
For a HTML page (e.g. landing page or other custom html page)
{{sitemap_opts exclude}}

or
{{sitemap_opts yearly 0.7}}

Awesome! Thanks for this one!


deb: improve process timing for safety and simplicity

Points

FROM-package just leaves tmp files if it supports the features.
TO-package trigger the features if there are those tmp files.
Thus, we don't need to check the version.
Make installing plugin and restarting the same condition.

Before

from-prerm(upgrade): Do nothing.
to-preinst(upgrade): Collect plugin-list. Confirm version.
Install TO-package
from-postrm(upgrade): Do nothing.
Uninstall FROM-package
to-postinst(configure): Install plugin and restart if need.

After

from-prerm(upgrade):

Check auto or not.
Leave plugin-list and pid if need.

to-preinst(upgrade): Set tmp files for TO-package.
Install TO-package
from-postrm(upgrade): Clean tmp files of FROM-package.
Uninstall FROM-package
to-postinst(configure): Install plugin and restart if need.

Thanks for your review!


Feature Request - Functionality _TZ3000_18ejxno0 - TS0012

Hello @JohanBendz ,
Is it possible to add the backlight feature to this Switch?
Please see the "backlight mode" section
https://www.zigbee2mqtt.io/devices/ZS-EUB_2gang.html
10x in advance.

@JohanBendz @shahzadsk any insights?

@WJGvdVelden can you also assist with this? I saw that you did the backlight for the 1 gang model.
10x in advance.

What I did with the 1 gang is in essence derived from the smart plug with metering, as this device also has an indicator light. I'm not an expert. What I do is by trial and error for the devices I own and can test thoroughly before I post a pull request. A 2 (and 3) gang device is a bit more complicated, although hints as to how this works can be found on Github (often in the home assistant repositories). So, sorry, no I can't help with this.

10x @WJGvdVelden  for the info, but at least can you provide some steps (baby steps) so i can try myself?
It's a shame not to activate this option, I have the devices but I don't have the right skill for this...


Update simpleclient, simpleclient_common to 0.10.0

Updates

io.prometheus:simpleclient
io.prometheus:simpleclient_common

from 0.8.1 to 0.10.0.
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "io.prometheus" } ]

labels: library-update, semver-minor

Superseded by #127.


Message/Content Length Limits to prevent long parsing (security)

Add some default Message Size limits for parsing. Make also seperate for Body sizes

full messages size now can be controlled.
UDP is parsed fully, so it only depends on your MTU size.


macOS: certain commands executed twice when focus is in webview

Extracted from https://github.com/Microsoft/vscode/issues/56988#issuecomment-419044926
When invoking a keybinding that also exists on the macOS native menu, while having focus inside a webview, the command is both triggered through the menu and our keybinding forwarder (here).
It looks like we could possibly use webContents.setIgnoreMenuShortcuts(true) to workaround this, but then any menu that is implemented with a :role will not work (e.g. cut, copy, paste).

I wonder if we can use the before-input-event here to avoid having the listener in the webview

@sbatten Suggested that #64228 may also be of interest

@mjbvz with your change, any command that is implemented with a :role does not work anymore inside the webview. For example, try to Cmd+C or undo/redo in an input field, it will not work because these commands only worked through the menu.

Actually since this issue is addressed, let's move that new issue to https://github.com/Microsoft/vscode/issues/65452


The way to read core's current frequency and temperature

Hi
I want to measure core frequency and temperature on Coral. (like vcgencmd in Raspberry Pi or tegrastats in TX board)
Is there any way to read core's current information?
Thanks

@pch0561 We currently don't have any nice tools for this task, but you can see the board's temperature using this command below:
$ cat /sys/class/thermal/thermal_zone0/temp

@pch0561
As Nam pointed out, you can read the temperature of the chip.  You can also read the dynamic frequency scaling registers:
https://coral.ai/docs/pcie-parameters/#configure-the-shutdownwarning-temperatures
point0_temp: 250MHz threshold
point1_temp: 125MHz threshold
point2_temp: 62.5MHz threshold
hw_temp_warn2: automatic shutdown threshold
You can access the current values of these registers with the sysfs interface like this:
cat /sys/module/apex/parameters/trip_point0_temp
To determine the current frequency , measure the temperature and compare it to the dynamic frequency settings:
if temp>=trip_point2_temp, the edge TPU is running at 62.5MHz
else if temp>= trip_point1_temp, the edge TPU is running at 125MHz
else if temp >= trip_point0_temp, the edge TPU is running at 250MHz
else the edge TPU is running at 500MHz


feat: add gRPC code and method columns

@makeavish we should maintain a new branch for each release like we have in signoz/signoz. For this repo, it can be signoz-v<IP_ADDRESS> to maintain signoz release?
@prashant-shahi please suggest.

@makeavish we should maintain a new branch for each release like we have in signoz/signoz. For this repo, it can be signoz-v<IP_ADDRESS> to maintain signoz release? @prashant-shahi please suggest.

@prashant-shahi Or should we merge to signoz-v0.43.0 and maintain different tag for different releases like <IP_ADDRESS>?

@ankitnayan Or we can have tags like 0.43.0-0.8.0 where suffix after - denotes the current query-service version with which otel collector is compatible

but I think query-service changes much faster than otel-collector. What should we do for that? Try to find any relevant discussion somewhere and @prashant-shahi might have some inputs on this

@ankitnayan @makeavish we need a separate branch which we set as default for the repository.
For the default development branch, we can go ahead with develop. We will merge the latest changes in that branch.
We will fork release branches from develop and make RC and stable release from the branch
Also, we can easily sync our main branch with OpenTelemetry Collector's particular release branch, and further we can locally rebase to develop and resolve merge conflicts if any arises.
For versioning format, <IP_ADDRESS> is not SemVer complaint versioning, however there are other tools which uses that format where the last number is used for "revision".
Other SemVer complaint versioning alternatives:

0.43.0-signoz0.7.6 or 0.43.0-signoz-0.7.6: If we make new SigNoz OtelCollector release if and only if there is new SigNoz release.
0.43.0-signoz.1 : build number which is ever incrementing
0.43.0-signoz.0.7 : separate major and minor versioning for the fork: for each release with non-compatible changes, we would bump up the major version, for every other release, we would only bump up the minor version

*Note: If we remove signoz keyword from the above SemVer complaint versions and they would still be valid.


How to upload artifacts

When using the artifacts clause in gitlab-ci.yml, the job gives the following message:

Missing gitlab-runner. Uploading artifacts is disabled.

Is there any method to preserve artifacts created on the remote VM before it is terminated?

The instance must contain gitlab-runner binary to upload artifacts. I use virt-customize utility to create a custom Openstack image with the required software:
virt-customize -v -a Fedora-Cloud-Base-34-1.2.x86_64.qcow2 --commands-from-file command_list.txt

cat command_list.txt
install git-core,git-lfs,podman,buildah,skopeo
copy-in /home/fedora/gitlab-runner:/usr/bin/
chmod 0755:/usr/bin/gitlab-runner
selinux-relabel

https://docs.gitlab.com/runner/executors/custom.html#prerequisite-software-for-running-a-job


Request Timeout / Taking too long

Checked other resources

[X] I added a very descriptive title to this issue.
[X] I searched the LangChain documentation with the integrated search.
[X] I used the GitHub search to find a similar question and didn't find it.
[X] I am sure that this is a bug in LangChain rather than my code.
[X] The bug is not resolved by updating to the latest stable version of LangChain (or the specific integration package).

Example Code
chain = LLMChain(
llm=self.bedrock.llm,
prompt=self.prompt_template,
)
chain_result = chain.predict(statement=text).strip()
Error Message and Stack Trace (if applicable)
No response
Description
I'm facing an issue similar to #3512 .
Using Langchain in a Flask App, hosted in an Azure Web App. Calling Anthropic Claude3 Haiku model in AWS Bedrock.
First Langchain request takes about 2 minutes to return. The following ones return smoothly. After about 7 idle minutes, first request takes too long again.
Can't reproduce this issue locally. It only happens in Azure environment.
When testing with boto3 AWS python SDK, the requests return fast every time, with no issues.
System Info
langchain==0.2.3
linux slim-bookworm
python:3.12.3
container image: python:3.12.3-slim-bookworm

If this is only happening in Azure Environment then the issue might not be langchain. please check your networking setting for Azure Web App and make sure that you don't have any firewall?

I'm gonna check the firewall. However, since the requests using boto3 are working fine, does it make sense to be a firewall issue? Both Langchain and boto3 are making requests to the same endpoints/services.


Update to Bootstrap 4?

Bootstrap is currently at 4.0.0 beta 3. This is the last beta and they're committed to not making anymore breaking changes before release.
There are several differences between Bootstrap 3 and 4. Does jasper intend to stay on track with Bootstrap versions?

@amberframework/contributors Is thid already solved?

Jasper still needs some updates, but Bootstrap 4 has long been released.


Exemplar Cities add ~700kb payload

This issue is intended to be used to evaluate our comfort with having exemplar cities become a de-facto requirement for ECMA-402 in light of it increasing the required payload size on all engines.
This has been flagged as a risk by anba in https://github.com/tc39/ecma402/issues/435#issuecomment-628094154 and confirmed in https://bugzilla.mozilla.org/show_bug.cgi?id=1720480 .

My understanding in UTS35 - the fallback could be exemplar cities when exemplar cities are available, but it does not mandate exemplar cities need to be available, nor which set of exemplar cities could be avaiable.

BTW https://tc39.es/proposal-intl-extend-timezonename/ does not mandate the shortGeneric or longGeneric to use the timezone data based on UTS35 fallback algorithm. Using UTS35 fallback is "A way" to implement it, but it does not mandate the implementaiton have to use UTS35 timezone fallback.

I believe nowhere in the ECMA402 mandate any fallback algorithm stated in UTS35- the implementation could fill the pattern based on what UTS35 stated, or NOT. From the pattern's point of view- there is always a pattern for that locale, and how the internal fallback from that pattern to a pattern in the resource is not stated in ECMA402. And that is what is in ECMA402 for years according to my understanding, at least for the DateTime part I believe that is the case (and probably also true for most other part of ECMA402)

@FrankYFTang Does the V8 implementation of this proposal use exemplar city names as fallback?

NO

Notice one thing we intentionally didn't change, by design, in this proposal is
https://tc39.es/ecma402/#annex-implementation-dependent-behaviour
In DateTimeFormat:
...
The set of supported date-time formats per locale beyond a core set, including the representations used for each component and the associated patterns (11.3.3)
Localized..., and time zone names (11.1.9)
The calendric calculations used for calendars other than "gregory", and adjustments for local time zones and daylight saving time (11.1.9)

The concept of "fallback" of timezone name really does not exist in the ECMA402 spec from my point of view -  such fallback is not an observable behavior and could only happen in the implementation optimization logic, not an observable behavior.

@FrankYFTang Does the V8 implementation of this proposal use exemplar city names as fallback?

NO

BTW- in ChromeOS, we do have those city names so it may use them on ChromeOS - not Chrome in general but only Chrome on ChromeOS.


how are open orders closed?

Hi, how is the order of closed trades in Account Protector?
for martingale systems (example: MG EA) the trade are open in this order:
0.01
0.02
0.04
0.08
If account protector close from first opened trade would be OK because the MG EA will not continue to open other trades.
If account protector close the trade from latest trade (example: 0.08), the MG EA will directly open an new trade with 0.08 if this trade is "no longer opened".

Hi!
For 'floating profit/loss' conditions, the AP closes trades from the most profitable/losing trades to the least profitable/losing ones. In all other cases, it closes trades in no particular order to attain maximum execution speed.

is possible to change the order from the oldest order by date to the most recent?
function to close orders is on line 4403 of Account Protector.mqh file?

You could change this line inside the void CAccountProtector::Close_All_Positions() function:
for (int i = total - 1; i >= 0; i--)
to:
for (int i = 0; i <= total - 1; i++)
But this won't guarantee any specific order of closing.

just that was my idea. what do you mean it does not guarantee closing in order or open trades?
because delays between mt4 and close on broker side?

No, because positions selected from history are selected in no specific order. MT4 doesn't guarantee that order. It may coincide with actual open time order, or it may not.

I see that it check if orders have been closed or not.
I will test next days and if i will face problem I will let you know.
Thanks very much.

You could change this line inside the void CAccountProtector::Close_All_Positions() function: for (int i = total - 1; i >= 0; i--) to: for (int i = 0; i <= total - 1; i++) But this won't guarantee any specific order of closing.

I got this when is trying to close the trades:
2022.03.16 20:43:27.125	Account Protector EURUSD,M5: array out of range in 'Account Protector.mqh' (4277,45)
is on this array:
if(!OrderSelect((int)PositionsByProfit[i][1], SELECT_BY_TICKET))
I tested it in normal way too with approx 100 trades for (int i = total - 1; i >= 0; i--)  but it is not reliable, because my ea start to reopen trades and account protector does not close them.
i have to see if put a loop to try 2-3 times to call CAccountProtector::Close_All_Positions()
what can you suggest to me?

You need to comment out both instances of ArrayResize(PositionsByProfit, i); in the CAccountProtector::Close_All_Positions() function. This will eliminate the error.
Also, if you are using profit/loss conditions, you need to comment out these lines there:
    if ((TriggeredCondition == Floating_loss_rises_to_perecentage) || (TriggeredCondition == Floating_loss_rises_to_currency_units) || (TriggeredCondition == Floating_loss_rises_to_points)) ArraySort(PositionsByProfit, WHOLE_ARRAY, 0, MODE_DESCEND);
    else if ((TriggeredCondition == Floating_profit_rises_to_perecentage) || (TriggeredCondition == Floating_profit_rises_to_currency_units) || (TriggeredCondition == Floating_profit_rises_to_points)) ArraySort(PositionsByProfit, WHOLE_ARRAY, 0, MODE_ASCEND);

You need to comment out both instances of ArrayResize(PositionsByProfit, i); in the CAccountProtector::Close_All_Positions() function. This will eliminate the error.
Also, if you are using profit/loss conditions, you need to comment out these lines there:
    if ((TriggeredCondition == Floating_loss_rises_to_perecentage) || (TriggeredCondition == Floating_loss_rises_to_currency_units) || (TriggeredCondition == Floating_loss_rises_to_points)) ArraySort(PositionsByProfit, WHOLE_ARRAY, 0, MODE_DESCEND);
    else if ((TriggeredCondition == Floating_profit_rises_to_perecentage) || (TriggeredCondition == Floating_profit_rises_to_currency_units) || (TriggeredCondition == Floating_profit_rises_to_points)) ArraySort(PositionsByProfit, WHOLE_ARRAY, 0, MODE_ASCEND);

commented the suggested values and added 3 times Close_All_Positions();
if(IsANeedToContinueClosingOrders)
{
Close_All_Positions(); //we try 4 times to close the trades
Close_All_Positions();
Close_All_Positions();
Close_All_Positions();
}
will test next days and if i will face problem I will let you know.
Thanks again


Hi Team - Do we have any plan to TeraData Database

Describe your feature request
Hi Team - I want to use connectorx for TeraData DW solution. Let me know if you planning to add TD as source or we can use ODBC connection.

Hi @akhilesh4183 , we don't have TeraData DW in our plan yet. We do have plan for supporting ODBC but we are currently lack of hands. Please feel free to add it in our discussion #61.


Merge main to stable

Hi @mssawant
DCO is failing.

@vaibhavparatwar , yes there are 2 commits that are having problems,
Commit sha: a5b9e42, Author: pavankrishnat, Committer: Mandar Sawant; Expected "pavankrishnat<EMAIL_ADDRESS>but got "pavankrishnat<EMAIL_ADDRESS>Commit sha: c97d54e, Author: mukul-seagate11, Committer: Mandar Sawant; The sign-off is missing.

Trying to resolve but looks like its not that trivial, I think it is better to pass DCO check explicitly for this one. We need to keep a watch for future PRs.


change style via options

i try set default settings:
$('.selectpicker').selectpicker({'container': 'body', 'size': 4, 'style':'btn-info'});
but on my page style not change to my variant and stay btn-light.

Cant reproduce, we did not change anything on the setStyle() behavior. Did you include the dist/js/bootstrap-select.js or dist/js/bootstrap-select.min.js? Or did you mean the actionbox buttons (select/deselect all) or done button?

Of course they are connected, I can see that the select works, but the styles assigned to it did not apply via 'style':'btn-info'. If they are assigned to each select in the template, then everything works.

Hey, why did you close this issue? Solved?


MapView.getMapBoundaries typescript declaration defines the wrong return type

Is this a bug report?
yes.
Have you read the Installation Instructions?
yes
Environment
  react: 16.8.6 => 16.8.6
  react-native: 0.59.5 => 0.59.5
  react-native-maps: 0.24.2
  using google maps

Steps to Reproduce
checkout react-native-maps and look at index.d.ts, specifically MapView.getMapBoundaries, it says it returns a {northEast: LatLng; southWest: LatLng}.  however, the implementation returns a Promise<{northEast: LatLng; southWest: LatLng}>
Expected Behavior
MapView.getMapBoundaries in the .d.ts file should return Promise<{northEast: LatLng; southWest: LatLng}>
Actual Behavior
MapView.getMapBoundaries  in the .d.ts currently returns {northEast: LatLng; southWest: LatLng}
Reproducible Demo

Closing as https://github.com/react-native-community/react-native-maps/pull/2828 is  merged

@rborn, when a new version of the package with this fix will be released?

@strdr4605 well, if somebody helps with the changelog maybe @christopherdro can push a release.


Remember window position

Remember the last window's position when allowed to drag it around.

I second this. Specially on multimonitor setups.
It would be awesome to have a setting to enable/disable this.


[B] Data structure: investigate in business logic being tracked in history table

From #950
[Data Structure] figure out which transactions are tracked incorrectly or not at all in the history table.

Follow-up: https://trello.com/c/QfbgCeig/1401-investigate-changes-tracked-in-history-table


Fixed dark mode styles for invisible text

See:

Problem with tables https://github.com/solid/authorization-panel/commit/fc235e9469fabed347158df05328bec8ba7fbfb1#r43301927
Problem with definition links https://github.com/solid/authorization-panel/commit/c7b2f5be3d0f13c13602c5378dc70dafb391a80c#r43342000

How is "dark mode" activated in your environment? Which OS, browser, extension? How can I replicate?
I've briefly tested on Firefox with https://addons.mozilla.org/en-GB/firefox/addon/dark-mode-webextension and https://addons.mozilla.org/en-GB/firefox/addon/dark-mode-by-albert-inc/ but neither showed the issues you're experiencing.

Macbook and iphone on firefox and safari.
The dark mode is triggered in system preferences > general > appearance > Dark
Website rendered at this address https://solid.github.io/authorization-panel/wac-ucr/
(screenshots are linked in my first comment)

I can't replicate in my environment but no particular conflict either to merge as a one off.
It'd best to propose these changes upstream on bikeshed.

We could have a quick call/screenshare if you want to pinpoint why your env behaves differently from mine.
On the bikeshed side, I would agree, but as far as I understand we introduced those style changes that break the UI in dark mode (as per linked commits).
I looked in bikeshed's codebase but couldn't find a way to have even table rows colored or links keeping the main text color. I'm not completely sure why those styles were introduced either, maybe something to discuss with @justinwb if worth opening an issue to try introducing those options/default styles to bikeshed?

@matthieubosquet There is a bikeshed setting for this so it doesn't need to be set directly. In the initial boilerplate section just add:
Boilerplate: style-darkmode off

I can't replicate in my environment but no particular conflict either to merge as a one off.
It'd best to propose these changes upstream on bikeshed.

I was running into the same thing on another document @csarven. The reason is because bikeshed just introduced darkmode - and the github action uses the most recent stable version every time, whereas a local version is likely to be a bit further behind unless you are auto-updated.

@matthieubosquet There is a bikeshed setting for this so it doesn't need to be set directly to avoid dark mode from being used at all. In the initial boilerplate section just add:
Boilerplate: style-darkmode off

Now this will essentially disable dark-mode altogether. I'm a bit on the fence about it - as I do run dark mode across my local operating environment, but also don't love spec documents needing to worry about two sets of styles. In the interop spec I turned it off for now with the above, but there's more custom styling in that one that one that was being affected.

@justinwb I like darkmode too and I'm probably more on the fence about adding a lot of custom styling to spec documents (from an accessibility/consistency perspective).
Unfortunately, figuring out what would be valuable to and accepted as standard bikeshed styling is not very high on my priority list.

Was that update moved to the Access Control Use Cases doc? I somehow had dark mode enabled on my mac constantly and some parts were unreadable.

@bblfish I created an issue on bikeshed for dark-mode to have a switch. https://github.com/tabatkins/bikeshed/issues/1806


Document more attributes for Azure Service Bus pubsub

What content needs to be created or modified?
ConsumerID is in the ASB pubsub component code but not documented in docs. There might be others too.
Describe the solution you'd like
All metadata attributes for ASB pubsub component are documented.
Where should the new material be placed?
https://docs.dapr.io/reference/components-reference/supported-pubsub/setup-azure-servicebus/
The associated pull request from dapr/dapr, dapr/components-contrib, or other Dapr code repos
Code is already live.
Additional context
Relates to: https://github.com/dapr/components-contrib/issues/378

@halspang Wanted to check in on this issue to see if you'd be able to get the metadata attributes documented for the Azure Service Bus (ASB) pubsub component.
I checked the docs for ASB , and it looks like we're missing these three metadata attributes in the docs:

MaxRetriableErrorsPerSec
MinConnectionRecoveryInSec
MaxRetriableErrorsPerSec

Once we get these attributes documented in the Spec metadata fields table this issue should be good to close.

@ItalyPaleAle is this something you can help @halspang with? You both touched these components the most.

👋 @nyemade-uversky ! Those metadata options are new for 1.8 and you can find them in the docs here: https://v1-8.docs.dapr.io/reference/components-reference/supported-pubsub/setup-azure-servicebus/
I went thorough the docs when I made the updates for the new service bus components landing in 1.8. However I am not excluding the possibility that I may have missed something!

@ItalyPaleAle Just checked and both MaxConnectionRecoveryInSec and MinConnectionRecoveryInSec are documented in the link you shared.
@greenie-msft and @msfussell This Issue can be closed, all ASB metadata attributes in the ASB metadata.go file are reflected in the 1.8 docs.

Resolved


Setting swipeable area instead of whole children in modal

Ask your Question
is it currently possible to swipe (to close modal) only portion of children view within modal to close the modal? At the moment I can swipe the whole component in modal.
What I would like to do is just make close handle so that users can only swipe by clicking on the handle only, not the whole child.

Modal will show and hide given the isVisible prop. You have to handle the animation yourself and toggle the isVisible prop.

Even if it's not in the plans, any idea how to have a temporary solution on the user side to modify the default behaviour?


Update test.md

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

Docset4/test.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

aaajjj

hahhh


Frontend Testing: The other half of backend sagas

Part of #581
Added tests for the following actions in backend sagas:

FETCH_GRADING_OVERVIEWS
FETCH_GRADING
UNSUBMIT_SUBMISSION
SUBMIT_GRADING

Pull Request Test Coverage Report for Build 2138

12 of 12 (100.0%)  changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+1.4%) to 29.766%

Totals

Change from base Build 2136:
1.4%

Covered Lines:
1529

Relevant Lines:
4490

💛  - Coveralls

Can this PR be rebased, and I'll check it out

PR has been rebased. Apologies for the lag time (i managed to bonk my linux partition again)

Putting this on hold because we're looking into revamping the requests file


Termial editor tab icon does not render initially

Steps to Reproduce:

Create a terminal editor
Realize there's no icon
Open a regular terminal
🎉 Icon appears

I think this is already fixed, correct me if I'm wrong

This is not fixed, you can see in my gif I build from sources. I just built from sources again and it still repros.

Works for me after pull:

There was this exact issue before but I fixed it in https://github.com/microsoft/vscode/commit/73f7d4d96507f4d25eddcfc70b3dd0d38998fa6a#diff-f1883fa148c75292499e7150b63a75610d76d58bb20cefff0213d1f5ec6b88fc, are you sure you pulled? @meganrogge have you seen this happen?

It happens less often, but still happens. Try these steps

Open a terminal editor
Close it
Cmd + q to hot exit
Restart OSS
open the terminal editor again
🐛 No icon

Something else I noticed is that if you quit with a terminal editor open, it won't restore but you'll see the tab flash briefly on screen before closing.

Can repro now, thanks 👍

@meganrogge I think this is happening because TerminalService's init is lazy now so for the first time it's possible to have terminal(s) without TerminalService being initialized. This seems pretty bad, I'll have a think about how to make sure it gets initialized.

Actually scratch that, it's happening because the terminal's icon isn't set when the styles are updating. Investigation more...