what's new entry for unpinning mpl

This PR is a follow-up to https://github.com/SciTools/iris/pull/3468, and adds a whatsnew entry highlighting that our matplotlib dependency is now unpinned.

@abooton Nice spot 👀 ... I've removed the superfluous "now".
Good question... line length doesn't matter here for the whatsnew contributions. The whatsnew aggregation process take care of line concatenation 👍

@abooton Thanks :tada:


RFP: Veeam Backup & Replication

REF: https://www.veeam.com/vmware-esx-backup.html
I started this a year or so ago with v9.0 and it's very complicated, so I put it aside. I thought someone else was working on it but can't find a reference to it.
The main problem I had was installing the multitude of programs in the correct order; also I tried installing some of the pre-reqs using existing Chocolatey dependencies but the versions never matched up right and it wouldn't work. :( It also takes 30-45 minutes to install even on a fast i7! So debugging it was a bear.
I don't have the time now to do this thougth I might look into it again at some point in the future.
If it helps, here's what I had for the chocolateyinstall.ps1, keep in mind it's for an outdated version and the programs aren't necessarily in the right order right now.
#$ErrorActionPreference = 'Stop'
$packageName = 'veeam-backup-and-replication'
$ToolsDir    = $(Split-Path -parent $MyInvocation.MyCommand.Definition)
$url         = 'https://download2.veeam.com/VeeamBackup%26Replication_<IP_ADDRESS>2.iso'
#$silentArgsEULA= '/qn /norestart ACCEPTEULA=`"YES`"'
#$silentArgs    = '/qn /norestart /l*v'
#$silentArgs2 = '/quiet /qn /norestart'
$validExitCodes = @(0, 3010, 1641)

# Documentation at https://www.veeam.com/pdf/datasheet/unattended_installation.pdf
# PS script at https://github.com/VeeamHub/powershell/blob/master/UnattendedInstall/Simple/90_simple_auto_install_all.ps1

Write-Host Downloading ISO and extracting... -foreground "magenta" –backgroundcolor "blue"
$packageArgs = @{
  packageName   = $packageName
  unzipLocation = $toolsDir
  fileType      = 'ZIP'
  url           = $url
  checksum      = '21F9D2C318911E668511990B8BBD2800141A7764CC97A8B78D4C2200C1225C88'
  checksumType  = 'sha256'
}
Install-ChocolateyZipPackage @packageArgs
if ($LASTEXITCODE -eq 0) {Write-Host "Failure downloading ISO and extracting!" -foreground "red" –backgroundcolor "blue"}
   else {Write-Host "Success downloading ISO and extracting!" -foreground "green" –backgroundcolor "blue"}

#create local admin
$computername = net user | ? { $_ -match "\\\\(.+)" } | % { $Matches[1] }
$username = "veeamsvc"
$password = ("Vmca12345")
net user $username $password /add /PASSWORDCHG:NO
wmic UserAccount where ("Name='{0}'" -f $username) set PasswordExpires=False
net localgroup  "administrators" $username /add
$fulluser = "$computername\$username"
write-host "Created user $fulluser  with password $password"

Write-Host Installing Veeam Backup Catalog... -foreground "magenta" –backgroundcolor "blue"
$fileLocation = "$env:ChocolateyInstall\lib\veeam-backup-and-replication\tools\Catalog\VeeamBackupCatalog64.msi"
$packageArgs = @{
  packageName   = $packageName
  fileType      = 'MSI'
  file          = $fileLocation
  silentArgs    = '/quiet /qn /norestart'
  validExitCodes= $validExitCodes
  softwareName  = 'Veeam Backup*'
}
#Install-ChocolateyInstallPackage @packageArgs
if ($LASTEXITCODE -eq 0) {Write-Host "Failure installing Veeam Backup Catalog!" -foreground "red" –backgroundcolor "blue"}
   else {Write-Host "Success installing Veeam Backup Catalog!" -foreground "green" –backgroundcolor "blue"}

Write-Host Installing Microsoft SQL Server 2012 Express Service Pack 1... -foreground "magenta" –backgroundcolor "blue"
$fileLocation = "$env:ChocolateyInstall\lib\veeam-backup-and-replication\tools\Redistr\x64\SQLEXPR_x64_ENU.exe"
$packageArgs = @{
  packageName   = $packageName
  fileType      = 'EXE'
  file          = $fileLocation
  silentArgs    = '/q /INDICATEPROGRESS /ACTION=Install /FEATURES=SQLEngine,SNAC_SDK /TCPENABLED=1 /INSTANCENAME=VEEAMSQL2012 /SQLSVCACCOUNT=`"NT AUTHORITY\Network Service`" /SQLSYSADMINACCOUNTS=`"$adminsGroupName`" /AGTSVCACCOUNT=``"NT AUTHORITY\Network Service`" /NPENABLED=1 /UpdateEnabled=0 /IACCEPTSQLSERVERLICENSETERMS'
  validExitCodes= $validExitCodes
  softwareName  = 'Veeam Backup*'      #need to update
}
#Install-ChocolateyInstallPackage @packageArgs
if ($LASTEXITCODE -eq 0) {Write-Host "Failure installing Microsoft SQL Server 2012 Express Service Pack 1!" -foreground "red" –backgroundcolor "blue"}
   else {Write-Host "Success installing Microsoft SQL Server 2012 Service Pack 1!" -foreground "green" –backgroundcolor "blue"}

#start-process -filepath "$fileLocation"  -ArgumentList "/Q /IACCEPTSQLSERVERLICENSETERMS /ACTION=install /FEATURES=SQLEngine,SNAC_SDK /INSTANCENAME=VEEAMSQL2012 /SQLSVCACCOUNT=`"NT AUTHORITY\SYSTEM`" /SQLSYSADMINACCOUNTS=`"$fulluser`" `"Builtin\Administrators`" /TCPENABLED=1 /NPENABLED=1 /UpdateEnabled=0"   -PassThru | Wait-Process

Write-Host Installing Microsoft SQL Server 2012 System CLR Types... -foreground "magenta" –backgroundcolor "blue"
$fileLocation = "$env:ChocolateyInstall\lib\$packageName\tools\Redistr\x64\SQLSysClrTypes.msi"
$packageArgs = @{
  packageName   = $packageName
  fileType      = 'MSI'
  file          = $fileLocation
  silentArgs    = '/quiet /qn /norestart'
  validExitCodes= $validExitCodes
  softwareName  = 'Microsoft System CLR Types*'
}
#Install-ChocolateyInstallPackage @packageArgs
if ($LASTEXITCODE -eq 0) {Write-Host "Failure installing Microsoft SQL Server 2012 System CLR Types!" -foreground "red" –backgroundcolor "blue"}
   else {Write-Host "Success installing Microsoft SQL Server 2012 System CLR Types!" -foreground "green" –backgroundcolor "blue"}

Write-Host Installing Microsoft SQL Server 2012 Management Objects... -foreground "magenta" –backgroundcolor "blue"
$fileLocation = "$env:ChocolateyInstall\lib\$packageName\tools\Redistr\x64\SharedManagementObjects.msi"
$packageArgs = @{
  packageName   = $packageName
  fileType      = 'MSI'
  file          = $fileLocation
  silentArgs    = '/quiet /qn /norestart'
  validExitCodes= $validExitCodes
  softwareName  = 'Veeam Backup*' #need to update
}
#Install-ChocolateyInstallPackage @packageArgs
if ($LASTEXITCODE -eq 0) {Write-Host "Failure installing Microsoft SQL Server 2012 Management Objects!" -foreground "red" –backgroundcolor "blue"}
   else {Write-Host "Success installing Microsoft SQL Server 2012 Management Objects!" -foreground "green" –backgroundcolor "blue"}

Write-Host Installing Microsoft Visual C++ 2010... -foreground "magenta" –backgroundcolor "blue"
$fileLocation = "$env:ChocolateyInstall\lib\$packageName\tools\Redistr\x64\vcredist100_x64.exe"
$packageArgs = @{
  packageName   = $packageName
  fileType      = 'MSI'
  file          = $fileLocation
  silentArgs    = '/q /norestart'
  validExitCodes= $validExitCodes
  softwareName  = 'Veeam Backup*' #need to update
}
#Install-ChocolateyInstallPackage @packageArgs
if ($LASTEXITCODE -eq 0) {Write-Host "Failure installing Installing Microsoft Visual C++ 2010!" -foreground "red" –backgroundcolor "blue"}
   else {Write-Host "Success installing Installing Microsoft Visual C++ 2010!" -foreground "green" –backgroundcolor "blue"}

Write-Host Installing Veeam Backup and Replication Server... -foreground "magenta" –backgroundcolor "blue"
$vpower = "c:\vpowernfs"
new-item  -ItemType Directory -path $vpower -ErrorAction SilentlyContinue
$fileLocation = "$env:ChocolateyInstall\lib\$packageName\tools\Backup\Server.x64.msi"
$packageArgs = @{
  packageName   = $packageName
  fileType      = 'MSI'
  file          = $fileLocation
  silentArgs    = '/qn /l*v `"$($env:TEMP)\$($packageName).$($env:chocolateyPackageVersion).MsiInstall.log`" ACCEPTEULA="YES" VBR_SERVICE_USER="$fulluser" VBR_SERVICE_PASSWORD="$password" PF_AD_NFSDATASTORE="$vpower" VBR_SQLSERVER_SERVER="$computername\VEEAMSQL2012"'
  #silentArgs    = '/qn ACCEPTEULA=`"YES`" VBR_SERVICE_USER=`"$fulluser`" VBR_SERVICE_PASSWORD=`"$password`" PF_AD_NFSDATASTORE=`"$vpower`" VBR_SQLSERVER_SERVER=`"$computername\VEEAMSQL2012`"'
  validExitCodes= $validExitCodes
  softwareName  = 'Veeam Backup*'      #need to update
}
Install-ChocolateyInstallPackage @packageArgs
if ($LASTEXITCODE -eq 0) {Write-Host "Failure installing Veeam Backup and Replication Server!" -foreground "red" –backgroundcolor "blue"}
   else {Write-Host "Success installing Veeam Backup and Replication Server!" -foreground "green" –backgroundcolor "blue"}

#backup server
#start-process -filepath msiexec -ArgumentList "/i `"$fileLocation`" /l*v $toolsDir\BandRS.txt /qn ACCEPTEULA=`"YES`" VBR_SERVICE_USER=`"NT AUTHORITY\Network Service`" VBR_SERVICE_PASSWORD=`"$password`" PF_AD_NFSDATASTORE=`"$vpower`" VBR_SQLSERVER_SERVER=`"$computername\VEEAMSQL2012`" " -PassThru | Wait-Process

Write-Host Installing Veeam Explorer for Active Directory... -foreground "magenta" –backgroundcolor "blue"
$fileLocation = "$env:ChocolateyInstall\lib\$packageName\tools\Explorers\VeeamExplorerForActiveDirectory.msi"
$packageArgs = @{
  packageName   = $packageName
  fileType      = 'MSI'
  file          = $fileLocation
  silentArgs    = "/qn /norestart /l*v `"$($env:TEMP)\$($packageName).$($env:chocolateyPackageVersion).MsiInstall.log`""
  validExitCodes= $validExitCodes
  softwareName  = 'Veeam Backup*'           #need to update
}
Install-ChocolateyInstallPackage @packageArgs
if ($LASTEXITCODE -eq 0) {Write-Host "Failure installing Veeam Explorer for Active Directory!" -foreground "red" –backgroundcolor "blue"}
   else {Write-Host "Success installing Veeam Explorer for Active Directory!" -foreground "green" –backgroundcolor "blue"}

Write-Host Installing Veeam Explorer for Exchange... -foreground "magenta" –backgroundcolor "blue"
$fileLocation = "$env:ChocolateyInstall\lib\$packageName\tools\Explorers\VeeamExplorerForExchange.msi"
$packageArgs = @{
  packageName   = $packageName
  fileType      = 'MSI'
  file          = $fileLocation
  silentArgs    = $silentArgs
  validExitCodes= $validExitCodes
  softwareName  = 'Veeam Backup*'      #need to update
}
Install-ChocolateyInstallPackage @packageArgs
if ($LASTEXITCODE -eq 0) {Write-Host "Failure installing Veeam Explorer for Exchange!" -foreground "red" –backgroundcolor "blue"}
   else {Write-Host "Success installing Veeam Explorer for Exchange!" -foreground "green" –backgroundcolor "blue"}

Write-Host Installing Veeam Explorer for SharePoint... -foreground "magenta" –backgroundcolor "blue"
$fileLocation = "$env:ChocolateyInstall\lib\$packageName\tools\Explorers\VeeamExplorerForSharePoint.msi"
$packageArgs = @{
  packageName   = $packageName
  fileType      = 'MSI'
  file          = $fileLocation
  silentArgs    = '/qn /norestart /l*v'
  validExitCodes= $validExitCodes
  softwareName  = 'Veeam Backup*'       #need to update
}
Install-ChocolateyInstallPackage @packageArgs
if ($LASTEXITCODE -eq 0) {Write-Host "Failure installing Veeam Explorer for SharePoint!" -foreground "red" –backgroundcolor "blue"}
   else {Write-Host "Success installing Veeam Explorer for SharePoint!" -foreground "green" –backgroundcolor "blue"}

Write-Host Installing Veeam Explorer for Microsoft SQL... -foreground "magenta" –backgroundcolor "blue"
$fileLocation = "$env:ChocolateyInstall\lib\$packageName\tools\Explorers\VeeamExplorerForSQL.msi"
$packageArgs = @{
  packageName   = $packageName
  fileType      = 'MSI'
  file          = $fileLocation
  silentArgs    = '/qn /norestart /l*v'
  validExitCodes= $validExitCodes
  softwareName  = 'Veeam Backup*'      #need to update
}
Install-ChocolateyInstallPackage @packageArgs
if ($LASTEXITCODE -eq 0) {Write-Host "Failure installing Veeam Explorer for Microsoft SQL!" -foreground "red" –backgroundcolor "blue"}
   else {Write-Host "Success installing Veeam Explorer for Microsoft SQL!" -foreground "green" –backgroundcolor "blue"}

Write-Host Installing Veeam Backup and Replication Console... -foreground "magenta" –backgroundcolor "blue"
$fileLocation = "$env:ChocolateyInstall\lib\$packageName\tools\Backup\Shell.x64.msi"
$packageArgs = @{
  packageName   = $packageName
  fileType      = 'MSI'
  file          = $fileLocation
  silentArgs    = '/qn /norestart ACCEPTEULA=`"YES`"'
  validExitCodes= $validExitCodes
  softwareName  = 'Veeam Backup*'       #need to update
}
Install-ChocolateyInstallPackage @packageArgs
if ($LASTEXITCODE -eq 0) {Write-Host "Failure installing Veeam Backup and Replication Console!" -foreground "red" –backgroundcolor "blue"}
   else {Write-Host "Success installing Veeam Backup and Replication Console!" -foreground "green" –backgroundcolor "blue"}

I made an Ansible playbook for this a couple weeks back I can try and take a stab at it.

I wrote an Ansible playbook for this a couple weeks back so I can try and take a stab at it.

I am working on this one right now.

A start has been made:

Veeam Backup & Replication ISO downloader
Veeam Backup & Replication Console
Veeam Explorer for Microsoft Active Directory
Veeam Explorer for Microsoft Exchange
Veeam Explorer for Microsoft SharePoint
Veeam Explorer for Microsoft SQL Server
Veeam Explorer for Oracle
And more to come.

Please consider a meta package to install them all.

Please consider a meta package to install them all.

Please have a look at Veeam Backup & Replication Management Console


Add open close and dehumidify command

Add open close command and dehumidify command

@gtfierro @jbkoh I have been getting this error a few times today and not sure of the cause. I originally thought it had something to do with rebasing, however it happened again here after creating a new branch.

I've been working on fixing this in the supporting tooling. I'll let you know when you should merge from master and that should (hopefully) fix it!


Tracing/Observability support for clientcore

[WIP] Client core observability plans:
Un-branded client core
Un-branded client core will rely on OTel instrumentation (or other instrumentations) for observability. Someone building client libraries on it may

provide instrumentation in custom HttpPipelinePolicy
or ask their users to use OpenTelemetry Java Agent or one of the HTTP client instrumentation libraries it relies on (opentelemetry-java-http-client, opentelemetry-okhttp-3.0)

We'll provide sample docs and guidance for library authors.  We'll recommend them taking a direct dependency on opentelemetry-api from individual libs as their tracing/metrics abstraction. We'll keep the door to possible core-level telemetry helpers open.
Azure-core-v2
Azure Core built on top of the un-branded core will provide instrumentation with Azure-specific features:

URL sanitization
Correlation with service telemetry using legacy x-ms-*request-id headers
Additional context about Azure (resource provider namespace and anything else we might need in future)

Instrumentation will provide distributed tracing, metrics, and fully structured logs for HTTP calls.
It will be done in a way similar to azure-core v1 with some minor differences:

We'll have SPI abstractions for Tracer and Meter along with their providers for internal use only
We'll keep TracingOptions and MetricsOptions for user-facing configurations specific to Azure SDKs
We'll have SPI implementations in azure-core*-opentelemetry plugin (instead of azure-core-tracing-opentelemetry and azure-core*-metrics-opentelemetry)
InstrumentationPolicy will be injected by default if configured OTel is detected at the client creation time.

Future Azure client libraries based on core v2
Today we don't trace public API calls in RestProxy which results in poor observability for complex operations.
We will

autogenerate basic tracing code based on annotations
document how to trace public APIs for hand-written methods
provide checks to validate it along with live testing

API-level observability will include distributed traces and metrics and follow new conventions established in OTel.

TODO:

[ ] Having tracer/meter abstractions in unbranded core would be nice
- If it turns out that we need to support tracing/metrics helpers in client core, we'd have to deprecate them in azure-core-v2.
- Annotation-based codegen for API surface methods would be awesome for any SDK and having super-thin abstractions is good.
[ ] One of the possible solutions could be to have otel as an invisible optional dependency (similar to slf4j) behind reflection shim (which has some limitations, but...)
[ ] Figure out how to do ClientLogger -> OTel events (no slf4j, no json string - pure structure over the wire)

Option 2:  observability abstractions in client-core, reused in azure-core-v2, compile-time codegen for azure and non-azure libs on the public APIs
Un-branded client core
Un-branded client core will provide optional HTTP instrumentation policy - libraries can add it to the pipeline if they want to.
It will be built on top of tracing/metrics/logging abstractions in client-core.
The policy will be capable of

URL sanitization
Support capturing additional information based on request/response and context

Tracing/metrics abstractions will be built on top of OTel in a slf4j-shim style. It will check if OTel is on the classpath and back of if it's not, otherwise use OTel via method handles. No dependencies will be added.
We'll add APIs for client-facing and lib-specific observability configuration.
Azure-core-v2
Azure-core v2 will customize client-core instrumentation policy to include azure-specific context:

Correlation with service telemetry using legacy x-ms-*request-id headers
Additional context about Azure (resource provider namespace and anything else we might need in future)

Azure-core will add instrumentation policy by default (if otel is detected and enabled).
Future Client libraries based on client core (or azure core v2)
We will

autogenerate basic instrumentation code wrapping public API surface based on annotations
document how to instrument public APIs for hand-written methods
provide checks to validate it along with recorded/live testing
API-level observability will include distributed traces and metrics and follow new conventions established in OTel.

Diff: Option1 limits observability story to Azure client libs recommending generic libs to use OTel directly. Option 2 provides observability for all libs
Option 2 pros:

Option 1 is a one-way door - once tracing abstractions are in azure-core, it'd be hard to move them down the stack
same solution for all libs
non-azure libs may still want some customizations specific to their endpoint, we can accommodate them with the new design


Sampler

add getStableDiffusionSamplers
add StableDiffusionSampler - name: string, value: number

value is for stablestudio-plugin-stability e.g. DDIM, 0 - same as proto
other plugins will probably just send sampler.name directly to the API

Note: If the reason for hardcoding DDIM was for SDXL this will need to be dealt with, either override the value before chainGenerate or override the samplers options when SDXL is selected.
Related issue(s):
#12

@hlky Thanks a bunch, this is great!
I made a few changes I wanted your feedback on...

Changed value to id for StableDiffusionSampler since other back-ends might not use proto/Enums
Added Generation.Image.Samplers which manages the samplers list via react-query so plugins can potentially return samplers via asynchronous functions

Let me know what you think, this looks really good and I think we can merge when @KAJdev gives a thumbs-up 👍

https://github.com/Stability-AI/StableStudio/issues/20
For when this is merged ^

LGTM.


update po lines in mod-orders-storage to createInventory

In this bit of code:
https://github.com/sul-dlss/folio-tasks/blob/2176fc99d8ab34b6f901b33d02e69b043367bac2/tasks/helpers/orders/po_lines.rb#L136-L148
we need to add "createInventory": "Instance, Holding, Item" for just the physical hash (not also the e-resource hash). This needs to be an update tasks to orders-storage for doing after all the orders are posted.

Note that this task to update the purchase order lines using the storage endpoint means that we should grab the orderlines data from FOLIO, update the createInventory field, then PUT to the storage endpoint. The reason is that FOLIO is creating some data from us when we POST to the business logic endpoint (such as encumbrance UUID associated with a financial transaction) and we'll be in a bad state if we don't PUT that back to the storage endpoint.


perf.yml files created with executable bit set

I've just spotted that my test.perf.yml are marked executable in git, which is surprising as they're YAML files (which aren't executable).
As far as I know, none of the the developers are using Windows (only a mixture of macOS and Linux), so I'm not expecting this to be a platform thing on our end.
Is this expected?

I don't believe django-perf-rec does anything that would make the files executable. All the modification code is here: https://github.com/adamchainz/django-perf-rec/blob/master/src/django_perf_rec/yaml.py .
If you delete a file and rerun the tests to generate it, does it return as executable? Are you running your tests with a local Python, rather than through Docker or a VM?

I'm running the tests with a local Python (3.5.9 on Ubuntu 18.04 LTS).
If I add a new test to the snapshot then the mode doesn't change, however if I regenerate the file then it does.
I agree from a quick look at that code that nothing stands out as likely to cause this, it's most odd.

Ah, it looks like os.open has a default mode of 0o777 -- that'll be what's causing this.

It looks like django.core.files.locks functions can be passed a file object (rather than specifically an fd) -- is there a reason not to do that? That feels like it would simplify the code too.

Pretty sure all that does under the hood is get the fd off the file object
IIRC, using os.open() is necessary to pass the right flags for creating the file without conflict.


Incorrect behaviour with files containing ?

Description
When gitsigns is running in a file whose path contains a question mark (?), and that file is not yet tracked by git, if there are files whose path is identical to that of the current file, but with the question mark replaced by any character, and one of those files is tracked by git, diff signs will be inacurate. This is very much an edge-case, and it's not a big deal, but I figured I should mention it.
Neovim version
NVIM v0.6.1
Operating system and version
5.16-arch
Expected behavior
No diff signs should be displayed, since the file is untracked, so there's nothing to compare it against.
Actual behavior

I expect this is the result of a shell or git expanding the ? character to indicate a wildcard, so we probably just need tweak the path escaping. I'm using the fish shell, in case that ends up being related.
Minimal config
vim.o.packpath = '/tmp/nvim/site'

local plugins = {
  gitsigns = 'https://github.com/lewis6991/gitsigns.nvim',
  plenary  = 'https://github.com/nvim-lua/plenary.nvim',
  -- ADD OTHER PLUGINS _NECESSARY_ TO REPRODUCE THE ISSUE
}

for name, url in pairs(plugins) do
  local install_path = '/tmp/nvim/site/pack/test/start/'..name
  if vim.fn.isdirectory(install_path) == 0 then
    vim.fn.system { 'git', 'clone', '--depth=1', url, install_path }
  end
end

require('gitsigns').setup{
  debug_mode = true, -- You must add this to enable debug messages
  -- ADD GITSIGNS CONFIG THAT IS _NECESSARY_ FOR REPRODUCING THE ISSUE
}

-- ADD INIT.LUA SETTINGS THAT IS _NECESSARY_ FOR REPRODUCING THE ISSUE

Steps to reproduce

nvim -nu minimal.lua (no configuration is necessary, other than having the plugin installed and enabled)
mkdir test && cd test
git init
touch 1234
git add 1234 && git commit
nvim 12\?4, then add a line and write the file. Diff signs will be shown, even though the file is untracked.

Gitsigns debug messages
No response

Thanks for the report. Will be sure to fix this.

I cannot reproduce this. Can you provide the output of Gitsigns debug_messages?

Sure, here's the output:
run_job: git --no-pager --version
setup_highlights: Highlight GitSignsAdd is already defined
setup_highlights: Highlight GitSignsChange is already defined
setup_highlights: Highlight GitSignsDelete is already defined
setup_highlights: Deriving GitSignsAddNr from GitSignsAdd
setup_highlights: Deriving GitSignsChangeNr from GitSignsChange
setup_highlights: Deriving GitSignsDeleteNr from GitSignsDelete
setup_highlights: Deriving GitSignsAddLn from DiffAdd
setup_highlights: Deriving GitSignsChangeLn from DiffChange
setup_highlights: Deriving GitSignsDeleteLn from DiffDelete
setup_highlights: Deriving GitSignsCurrentLineBlame from NonText
setup_highlights: Deriving GitSignsAddInline from TermCursor
setup_highlights: Deriving GitSignsDeleteInline from TermCursor
setup_highlights: Deriving GitSignsChangeInline from TermCursor
setup_highlights: Deriving GitSignsAddLnInline from GitSignsAddInline
setup_highlights: Deriving GitSignsChangeLnInline from GitSignsChangeInline
setup_highlights: Deriving GitSignsDeleteLnInline from GitSignsDeleteInline
setup_highlights: Deriving GitSignsAddLnVirtLn from GitSignsAddLn
setup_highlights: Deriving GitSignsChangeVirtLn from GitSignsChangeLn
setup_highlights: Deriving GitSignsDeleteVirtLn from GitSignsDeleteLn
setup_highlights: Deriving GitSignsAddLnVirtLnInLine from GitSignsAddLnInline
setup_highlights: Deriving GitSignsChangeVirtLnInLine from GitSignsChangeLnInline
setup_highlights: Deriving GitSignsDeleteVirtLnInLine from GitSignsDeleteLnInline
attach(1): Attaching (trigger=setup)
run_job: git --no-pager config user.name
run_job: git --no-pager rev-parse --show-toplevel --absolute-git-dir --abbrev-ref HEAD
run_job: git --no-pager --git-dir=[REDACTED]/.git -c core.quotepath=off ls-files --stage --others --exclude-standard --eol [REDACTED]/notes/ws?.md
watch_gitdir(1): Watching git dir
run_job: git --no-pager --git-dir=[REDACTED]/.git show :0:notes/ws4.md
update(1): updates: 1, jobs: 5
run_job: git --no-pager rev-parse --show-toplevel --absolute-git-dir --abbrev-ref HEAD

I'm still not able to reproduce this, which suggest this may be a platform or build specific issue, however I've found out about a --literal-pathspecs option which may work. I've added this in #527. @mtoohey31 are you able to test it?

Yep, that fixes it! ONce that's merged this can be closed.

Closed with d0b42c0fc7a3d6c27a3cfaf959cb59a949388633


Feature request: sentence case

Hi there, thanks for the crate!
Quick feature request: sentence case. Here, every character is lowercase except the first character which is uppercase.
use convert_case::{Case, Casing};

assert_eq!("My variable name", "My variable NAME".to_case(Case::Sentence));

This could easily be implemented by reusing the lower case functionality.
Since this is easy to create, this is a low priority feature request. Feel free to close this request if you think it's not worth adding it. Still I think it's more ergonomic to include it directly in the library.

Hi @Nick-Mazuk, thanks for showing interest in convert_case.  To be honest, I thought this was already implemented as a case!  I already have Pattern::Sentence, which made adding this very easy.  This was a great suggestion.  This will be added in 0.7.0.

Thanks for adding it! This is such a useful library, so also thanks a ton for continuing to maintain it!


Improve file generation naming and deletion

Codegenerated files are now prefixed by zz_generated. (similar to
how files generated by conversion-gen are prefixed). Additionally
there is a marker near the top of each code generated file stating
that it was code generated by our generator.
When deleting files, we only delete those which were generated
by our generator.
This fixes #122

Pull Request Test Coverage Report for Build 126464406

-93 of 93 (0.0%)  changed or added relevant lines in 3 files are covered.
190 unchanged lines in 4 files lost coverage.
Overall coverage decreased (-4.06%) to 28.384%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

hack/generator/pkg/astmodel/file_definition.go
0
1
0.0%

hack/generator/pkg/astmodel/package_definition.go
0
3
0.0%

hack/generator/pkg/codegen/code_generator.go
0
89
0.0%

Files with Coverage Reduction
New Missed Lines
%

pkg/zips/env.go
3
0%

pkg/zips/types.go
25
54.76%

pkg/zips/client.go
75
3.96%

pkg/zips/template.go
87
26.32%

Totals

Change from base Build 125270582:
-4.06%

Covered Lines:
1516

Relevant Lines:
5341

💛  - Coveralls


Add direct color

Hi,
It would be nice the possibility to add directly the color for the fab button and theme. Not only the resource id, the color itself.
Thanks

Good point I'll add it to the next major release.

Just to be clear you want to be able to pass a Color object (from com.android.paint package) correct?

Not the object, the color itself like many libs do, example:
void setColor(int color) {
...
}
The call:
setColor(Color.WHITE);
setColor(Color.rgb(255,5,7));
setColor(5667);
....

Ok, that's what I was hoping for. That should be an easy addition.

I think this was fixed in #38


Merge release-1.1 to master

Changes:
dd659b327 (Shriram Rajagopalan, 72 minutes ago)
Helm template updates for multicluster with gateways (#9776)
d01b4f007 (John Mazzitelli, 82 minutes ago)
Tell Kiali the namespace where Istio is deployed (#9762)
10da1a497 (Lin Sun, 86 minutes ago)
remove global enabled flag for mixer  (#9768)
80ee9662c (Enis Soztutar, 86 minutes ago)
Fix loadBalancerSourceRanges default value in the helm chart (#9727)
498135105 (Yossi Mesika, 88 minutes ago)
Make sure context is cancelled in various return paths (#9639)
45930796f (Chunlin Yang, 89 minutes ago)
add base path for kiali and jaeger (#9588)
7709330cc (Yossi Mesika, 2 hours ago)
Watch networks config file for changes (#9584)
0d136e728 (Venil Noronha, 2 hours ago)
Replace external link with a local one (#9807)
21de0b438 (Axel Siebenborn, 4 hours ago)
Rename identity-domain to trust-domain. (#9559) (#9740)
ad5b3a2f0 (Zhonghu Xu, 13 hours ago)
fix bug: ConfigUpdate called too many times (#9711)
389971bfc (Douglas Reid, 16 hours ago)
Remove config options for envoy prometheus port (#8878)
a1007ff99 (Daniel T, 17 hours ago)
rework galley dashboard to include new metrics (#9673)
33361b9ac (Venil Noronha, 19 hours ago)
Add sample YAMLs for weighted TCP echo routing (#9794)
9e5208747 (Yossi Mesika, 20 hours ago)
Omit security post-install on istio-remote (#9796)
a5d1d0b2e (Kuat, 21 hours ago)
add andy (#9795)
14772effc (Venil Noronha, 22 hours ago)
Add TCP echo sample (#9791)
2bb1e6a87 (Zhonghu Xu, 24 hours ago)
Set load_balancing_weight with a valid value (#9730)
1f3ac743d (Venil Noronha, 25 hours ago)
Enable proxy version check during access log setup (#9781)
938dd6f27 (Guilherme Baufaker Rêgo, 29 hours ago)
[Ansible Installer] Fixing Kiali Installation - Cherry Pickes #9525 to
release-1.1 (#9647)
3224ced86 (Venil Noronha, 2 days ago)
Update istio/proxy and envoyproxy/go-control-plane (#9750)
0c9f2e69a (Jason Young, 2 days ago)
make pilot, mixer, and citadel deployment rollout strategy more robust
(#9723)
cbb1fcf6c (Zhonghu Xu, 2 days ago)
set endpoint.LocalityLbEndpoints LoadBalancingWeight (#9627)
9b474fc4c (Lin Sun, 2 days ago)
enable to enable or disable policy or telemetry (#9722)
d6ad6b469 (Yossi Mesika, 2 days ago)
Added missing network support in multicluster controllers (#9753)
2dd1bfb1e (Yossi Mesika, 2 days ago)
Add a network value to the Istio charts (#9759)
d61a2be90 (Iris, 3 days ago)
support distribute for fs (#9629)
051bbf78b (Douglas Reid, 3 days ago)
Alter Mixer tracing to only generate spans when service tracespan exists
(#9615)
d581a0ace (Douglas Reid, 3 days ago)
Add doc commands to generate website docs for edge template (#9540)
3096dbb36 (Jeff Mendoza, 3 days ago)
Re-add Service Graph build to istio-docker.mk (#9677)
91d7504e6 (Shriram Rajagopalan, 3 days ago)
fix config corruption caused by mTLS conversion in dest rule (#9745)
cfbb2e61f (Jason Young, 3 days ago)
Inject: Encode labels as json similar to annotations (#9634) (#9678)
dc04b073a (Zhonghu Xu, 3 days ago)
MCP config support fs based config store (#9736)
c62ef7ecf (Zhonghu Xu, 4 days ago)
code cleanup (#9734)
9ccc2944a (Jason Young, 6 days ago)
wait for supported resource types to be ready before starting galley
(#9702)
c8765ed7b (Douglas Reid, 6 days ago)
Add helm option to control Prometheus scrape interval (#9541)
6ec25bd80 (Piotr Sikora, 6 days ago)
Use externalTrafficPolicy: Local for ingress (release-1.1). (#9704)
a409466b4 (Shriram Rajagopalan, 6 days ago)
Nits on SNI-DNAT: fixing helm, etc. (#9720)
8f4471066 (Gregory Hanson, 6 days ago)
filter hosts based on subset labels for ServiceEntry clusters (#9670)
172ffcc65 (Shriram Rajagopalan, 6 days ago)
use dns srv format for sni-dnat clusters (#9699)
43132df82 (Zhonghu Xu, 7 days ago)
Avoid panic when stopping gRPC Server if TLS configuration is present
(#9689)
421693a23 (Jonh Wendell, 7 days ago)
Use official httpbin image (kennethreitz/httpbin) (#9700)
1b7c2ec4d (Zhonghu Xu, 7 days ago)
Replace ISTIO_NETWORK with NETWORK (#9624)
3f1f935fc (Shriram Rajagopalan, 7 days ago)
use DNS srv format for istio sni names in mTLS connections (#9672)
96232ddc1 (Ozben Evren, 8 days ago)
Add Ingress resource support to Galley (#9652)
e4f85cf33 (Jason Young, 8 days ago)
Fix sync-complete issues in Pilot with Galley/MCP. (#9553)
ea222630d (Jason Young, 8 days ago)
Increase minimum required golang version to 1.10 (#9406)
9de4ffab8 (Iris, 8 days ago)
verify istio install status (#9628)
e47f4a537 (Jason Young, 8 days ago)
use pkg/filewatcher package for watching MCP credentials and accesslist
(#9622)
5d2a56ea8 (Jason Young, 8 days ago)
fix 1.0.3 => 1.1.0 upgrade with default helm options (#9569)
7705eb25c (Lin Sun, 8 days ago)
allow configure of proxy image (#9565)

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: rshriram
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [rshriram]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rshriram: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-simpleTests-cni.sh
dd659b327801b20edc59df09929a29409c40ceeb
link
/test e2e-simpleTests-cni

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rshriram: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-simpleTests-cni.sh
dd659b327801b20edc59df09929a29409c40ceeb
link
/test e2e-simpleTests-cni

prow/build-tests.sh
dd659b327801b20edc59df09929a29409c40ceeb
link
/test build-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rshriram: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-simpleTests-cni.sh
dd659b327801b20edc59df09929a29409c40ceeb
link
/test e2e-simpleTests-cni

prow/build-tests.sh
dd659b327801b20edc59df09929a29409c40ceeb
link
/test build-tests

prow/istio-integ-k8s-tests.sh
dd659b327801b20edc59df09929a29409c40ceeb
link
/test istio-integ-k8s-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rshriram: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-simpleTests-cni.sh
dd659b327801b20edc59df09929a29409c40ceeb
link
/test e2e-simpleTests-cni

prow/build-tests.sh
dd659b327801b20edc59df09929a29409c40ceeb
link
/test build-tests

prow/istio-integ-k8s-tests.sh
dd659b327801b20edc59df09929a29409c40ceeb
link
/test istio-integ-k8s-tests

prow/istio-pilot-multicluster-e2e.sh
dd659b327801b20edc59df09929a29409c40ceeb
link
/test istio-pilot-multicluster-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


Users can't send private messages to bots installed, even permissions are given properly.

I am using latest slack_sdk version, installed yesterday only and very happy to see slack bot.
I tried sending message to users and they are shown correctly in workspace, in Apps chat menu.
but I am not able to reply/send message to slack-bot, though permissions are given correctly.
how can I send message to slackbots?
Sending messages to this app has been turned off. is shown while sending reply to bot.
this solution from stack-overflow doesn't work.

Duplicate of #

The permissions this app requests have not been reviewed by Slack.
how can I get this permissions approved from slack?

See issue #1015.

Hi @ganesh-deshmukh, thanks for asking the question!
As @eddyg already mentioned, this question is answered at #1015 . Let me share a quick video demonstrating how you can change your Slack app configuration. After enabling the Allow users to send Slash commands and messages from the messages tab, your Slack end-users may need to refresh the Slack client app to reflect the Slack app setting changes.

As everything should be clear now, let me close this issue. Please feel free to write in if you have anything further to ask/discuss regarding this topic!

Thanks to @seratch and @Team-Slack.
for detailed video/gif of solution.


Question: Clean way to call Texter when User phone number is not a required field?

Perhaps this is a nit-pick, but currently we always have to do something like:
UserTexter.welcome(user).deliver_later if user.phone?

Since the call to #welcome will fail without an E.164 compliant phone number, we cannot handle this at the job level. Also, returning nil from #welcome such that we now call:
UserTexter.welcome(user)&.deliver_later

doesn't seem like much of an improvement. I'm wondering if this is consistent behavior in terms of the API for ActionMailer, and we just don't have to deal with this case because email is a field that does have a not-null constraint. What is the way that you would imagine handling calling Texter methods in an app where phone is allowed to be null?

I personally see no problem with you needing to guard against calling a method that will fail without a phone number. You wouldn't expect ActionMailer to send an email for an object without an email address, nor would you ask it to, so there should be no difference in Textris.
I'd also argue that UserTexter.welcome(user)&.deliver_later is just obscuring your intention.
Perhaps to make it even clearer, you should tell the job the arguments it needs rather than passing it an object to extract arguments from. The most obvious intention comes from something like:
UserTexter.welcome(user.email).deliver_later if user.phone?

Then your UserTexter just needs to receive an email address as an argument. Just an idea.

There hasn't been any comments since, so I assume this issue is resolved. Thanks @philnash!


Create batch upload script for citation form images

Related to #145 , #156 , #20

Done:

writable/import_images
http://signbank.science.ru.nl/dictionary/import_images

@Woseseltops Script works, thanks. Two requests for improvement:

Remove file from the source folder as soon as it's imported. This leaves a clean folder when things are all OK, and when the script stumbles upon an error (typically typos in our filenames leading to 'gloss not found' message) and the error is corrected, it doesn't re-import the ones that were already successful.
Better solution for the latter problem: Present a single log message without interrupting the process for the errors, with all errors in a list above the list of files that were imported correctly.
Same for import_other_media and import_videos, if you don't mind me adding this to this same issue :-)

Done. Now, the scripts no longer halts at errors, but makes a note and moves on. Furthermore, it deletes all files it has processed correctly. It only works for images and video so far (since they share the same code). If you're happy, @ocrasborn, I'll do the same for OtherMedia.

Yaaay! It works and it is such an improvement!

oh, not close issue yet, sorry: yet to implement for OtherMedia

Done


Termini editions based on autopsy

ISic 128, 163, 178, 206 (4 Files, 18 Aug)

First attempt at this, so please do let me know where I'm getting it wrong!

Thanks Jon. Changes made – fingers crossed I've gotten it right this time round.


Parse longer expressions first, to help ligatures in Editors

This helps with this issue in atom-typescript : https://github.com/TypeStrong/atom-typescript/issues/851
which I first wanted to fix here : https://github.com/TypeStrong/atom-typescript/pull/926

Hi @long-lazuli, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. I promise there's no faxing. https://cla.microsoft.com.

TTYL, MSBOT;

@long-lazuli, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR.
Thanks, MSBOT;

:+1: LGTM. Thanks!


fix: use correct prefix for ens entries

This change is

It would be good to add an integration test if possible to catch when this is changed again in the dependency.

@agazso It would be difficult to manage the test as it would depend on an existing ENS entry to be present. Not sure if we want that.
@acud

@agazso the spec hasn't changed in three years so I don't see a risk of this happening anytime soon. Adding an integration test here is also not so simple as it would involve using a production ENS with ethereum backend and would either need to do real ens updates or perform hardcoded checks to see whether a given ens entry resolves to some static value that should never change. The latter would be relatively simple, but would also depend on either exposing ENS resolution as a separate endpoint in bee to make sure that it resolves an entry correctly, or just testing the ens library we use separately. Not sure if this is time well spent

@agazso the spec hasn't changed in three years so I don't see a risk of this happening anytime soon.

Just FYI, there is this (hopefully) coming down the ENS pipeline that may impact the resolver library.  It will give more cost-effective, xdai-native, ENS update capability.
https://medium.com/the-ethereum-name-service/a-general-purpose-bridge-for-ethereum-layer-2s-e28810ec1d88

@agazso the spec hasn't changed in three years so I don't see a risk of this happening anytime soon.

It's true that the spec hasn't changed but the dependency Bee uses changed two months ago and that completely broke the ENS functionality. This is a regression and this is why I propose to have some testing facility that would avoid this in the future.

Adding an integration test here is also not so simple as it would involve using a production ENS with ethereum backend and would either need to do real ens updates or perform hardcoded checks to see whether a given ens entry resolves to some static value that should never change. The latter would be relatively simple, but would also depend on either exposing ENS resolution as a separate endpoint in bee to make sure that it resolves an entry correctly, or just testing the ens library we use separately. Not sure if this is time well spent

It would be good if adding integration tests like this were relatively simple and cheap, because I see more integration being built in Bee, not less. Then there will be cross-dependencies, like in this case, where it seems go-ens was bumped because go-ethereum was bumped as well. So the number of things that can possibly break in the future will increase and one of the most efficient way to avoid these issues is automated testing.

Yeah it's a fair point. I also inspected the commit that changed the go-ens library. In fact, it was never implemented according to the EIP standard until its recent update. Also, their version bump was a minor version bump and not a major. I have commented to the maintainer about this. Having said that I'm not entirely sure how to test this. Doing an integration test separately does not guarantee that we catch the regression (since the dependency would be vendored externally) and exposing the actual ENS resolution through bee implies more "features" to maintain. We could consider exposing this as a debug api functionality and just do an integration test through that API endpoint to see that the resolution is correct.
cc @janos would be happy for your input here.
also, another idea would be to ditch the library and just do the decoding ourselves. then just a unit test will do (the library is vendored to do 10 lines of code which unmarshal the multicodec to a swarm hash - definitely not rocket science)

@agazso So we actually have an integration test in the codebase which was not enabled in the CI. The test uses the endpoint https://goerli.infura.io/v3/59d83a5a4be74f86b9851190c802297b and checks for some entries which were probably created before. But this endpoint no longer works.
We have decided that this change can go in as-is and then we will work on enabling this integration test in CI.


LSH Implementation with TFIDF Dense Matrix

I am currently working on Documents similarity project. We are processing text documents to generate TFIDF Vectors for each document in the corpus. In a nutshell, we are working with DENSE DATA with the documents being the data points and TFIDF values of the terms occuring in the document as their features.
We succeeded in implementing LSH with sparse data but it's not quite efficient.
Is it possible to use FALCONN with dense data for LSH implementation?

Yes, FALCONN supports dense data. In fact, the support for dense data is better than for sparse data. But if your data is very high-dimensional, the dense approach might not be efficient. What dimension do you work with?

I am currently working with a dataset that stores the TF-IDF values for only those terms that occur in the particular document. So, every point will have different dimension.
What is your say on this?

In that case, using a sparse representation might be better.

can you explain the reason behind that? I am still wondering why sparse representation can perform better than the dense one!

With a dense representation, the code will be performing many unnecessary multiplications with zero.

I am extremely sorry! My understanding of dense and sparse representations was reversed.
I am currently using 20NewsGroup's training dataset of 10000 documents.
I am using Sparse Representation now, which is a typedef of a vector of std::pair where the pair contains the index and the non-zero value itself if I am not wrong.
I am having issues while finding the center of mass since the size of every SparseVector will be different.


Create GitHub Repo

Jira Description
Need to create a GitHub repo on the Ed-Fi account for all of the BI artifacts. Also assign write access to [~Malagari].
Jira Metadata
Created: 2017-03-15T14:48:03.000-0500
Reporter: Dan Malagari

Jira Comment
2017-03-15T15:18:48.933-0500
Jira Metadata
Created: [~cyjones] - I'm getting a 404 when trying to access it, mind taking a look at the permissions?
Commenter: Dan Malagari

Jira Comment
2017-03-16T09:23:30.250-0500
Jira Metadata
Created: Moved this to done - verified access yesterday.
Commenter: Dan Malagari


CAMEL-14626 : api maven plugin - Cannot load  class

refs #CAMEL-14626

Currently, if there is a class in type args which is not found, parameters are ignored and generic class is substitute with a raw class, i.e. List<T> -> List or Map<String, T> -> Map

Build failure is due: Maven repo download failed of one of the deps
shouldnt be a problem

Please do not merge, I will do some changes later.

Okay thanks, let us know when its ready.

@davsclaus Now should be fine.


[US] Data Displayed in the List View

As an application user, I want the data from the database to be displayed in the list view, in the appropriate table and columns, so that I can visualize all the data of my tables directly from the List View Display.

MoSCoW
Risk
Story Points

Must
Medium
5

Acceptance Criteria

Ability to display the data from the database in the appropriate table and columns in the List View.

Risks

Adding complexity to the Virtual Model Definition

Tasks

[x]  VMD can retrieve the data
[x] Data is frontend
[x] Unit testing

https://github.com/WillTrem/UInnovate/assets/92006009/99aa9514-70c8-4bd2-a896-af8d75263cf7

Roughly what was followed for design

Looks great!
Signing off!


predict.py running error

Hi, I have some issues when running 'predict.py'.
It seems can't find 'class_checkpoint' and 'seg_checkpoint'.
python predict.py -p Downloads/3g73.pdb -c first_model_fold1_best_test_auc_85001.pth.tar -s seg0_best_test_IOU_91.pth.tar -r 3

DeepPocket/predict.py:14: DeprecationWarning: the imp module is deprecated in favour of importlib; see the module's documentation for alternative uses
import imp
/home/park/miniconda3/envs/torchdrug/lib/python3.7/site-packages/Bio/pairwise2.py:283: BiopythonDeprecationWarning: Bio.pairwise2 has been deprecated, and we intend to remove it in a future release of Biopython. As an alternative, please consider using Bio.Align.PairwiseAligner as a replacement, and contact the Biopython developers if you still need the Bio.pairwise2 module.
BiopythonDeprecationWarning,
/home/park/miniconda3/envs/torchdrug/lib/python3.7/site-packages/Bio/PDB/StructureBuilder.py:92: PDBConstructionWarning: WARNING: Chain A is discontinuous at line 3096.
PDBConstructionWarning,
/home/park/miniconda3/envs/torchdrug/lib/python3.7/site-packages/Bio/PDB/StructureBuilder.py:92: PDBConstructionWarning: WARNING: Chain B is discontinuous at line 3097.
PDBConstructionWarning,
/home/park/miniconda3/envs/torchdrug/lib/python3.7/site-packages/Bio/PDB/StructureBuilder.py:92: PDBConstructionWarning: WARNING: Chain A is discontinuous at line 3098.
PDBConstructionWarning,
/home/park/miniconda3/envs/torchdrug/lib/python3.7/site-packages/Bio/PDB/StructureBuilder.py:92: PDBConstructionWarning: WARNING: Chain B is discontinuous at line 3146.
PDBConstructionWarning,
/home/park/miniconda3/envs/torchdrug/lib/python3.7/site-packages/Bio/PDB/StructureBuilder.py:92: PDBConstructionWarning: WARNING: Chain C is discontinuous at line 3177.
PDBConstructionWarning,
/home/park/miniconda3/envs/torchdrug/lib/python3.7/site-packages/Bio/PDB/StructureBuilder.py:92: PDBConstructionWarning: WARNING: Chain D is discontinuous at line 3218.
PDBConstructionWarning,
***** POCKET HUNTING BEGINS *****
mkdir: cannot create directory ‘Downloads/3g73_nowat_out/pockets’: File exists
***** POCKET HUNTING ENDS *****
Traceback (most recent call last):
File "DeepPocket/predict.py", line 87, in
class_checkpoint=torch.load(args.class_checkpoint)
File "/home/park/miniconda3/envs/torchdrug/lib/python3.7/site-packages/torch/serialization.py", line 579, in load
with _open_file_like(f, 'rb') as opened_file:
File "/home/park/miniconda3/envs/torchdrug/lib/python3.7/site-packages/torch/serialization.py", line 230, in _open_file_like
return _open_file(name_or_buffer, mode)
File "/home/park/miniconda3/envs/torchdrug/lib/python3.7/site-packages/torch/serialization.py", line 211, in init
super(_open_file, self).init(open(name, mode))
FileNotFoundError: [Errno 2] No such file or directory: 'first_model_fold1_best_test_auc_85001.pth.tar'

Plz help...!!
Thanks

you need to download the class and seg checkpoint files that you would like to use from the link given in the readme

Thanks!!


New Relic: add error for agent not being found

🚨 IMPORTANT: Please do not create a Pull Request without creating an issue first.
Any change needs to be discussed before proceeding. Failure to do so may result in the rejection of the pull request.
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes # https://github.com/n1ru4l/envelop/discussions/1419#discussioncomment-3262612
Type of change
Added a more readable error message with the New Relic agent is not found
Screenshots/Sandbox (if appropriate/relevant):
Adding links to sandbox or providing screenshots can help us understand more about this PR and take action on it as appropriate
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Disabled the new relic agent from being installed on my application, and ran the application locally.
Test Environment:

OS: macOS 12.4
@envelop/...:
NodeJS: 14.17.0

Checklist:

[x] I have followed the CONTRIBUTING doc and the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented on my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[x] Any dependent changes have been merged and published in downstream modules

Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

Thank you for your contribution and the discussion!
A couple of minor comments from me.
I think in this case it makes sense to use EnvelopError class.
import { EnvelopError } from '@envelop/core'

throw new EnvelopError('message')

cc @n1ru4l to confirm this.
As about the message, I would change it to "Agent unavailable. Please check your New Relic Agent configuration"

@santino Since this error message should probably not reach the client, I think just using Error is totally fine here!
@zawadzkip If you are ready with this PR, please change it status to "Ready for review" and also add a changeset as instructed in https://github.com/n1ru4l/envelop/pull/1457#issuecomment-1196976510

@n1ru4l @santino Thanks for the patience! I finally got around to adding the changeset. First time doing so, please let me know if I did it incorrectly.


num256 removal

WIP, there is a FIXME I need to resolve among other things

Turned draft off so CI runs


Fix typos. Add sentence on cadvisor.

Signed-off-by: Kurt Garloff<EMAIL_ADDRESS>

We have specific information and observations with respect to cadvisor that is worth documenting IMVHO.

thanks. Looks good to me.

Thanks, Felix!


fix: set promotion dialog not closeable in any way

:tada: This PR is included in version 0.5.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


NuGet package no longer aligned with the 'Getting Started' guide.

Version 1.5 of the NuGet package no longer has the PowerShell script that adds the .build folder; yet the 'Getting Started' guide still says to reference this folder if using NuGet to get MSBuildTasks.  Is there an alternative method to use MSBuildTasks via NuGet?  If so, the documentation should be updated.  Otherwise, reinstate the PowerShell script.

Facing the same issue. Any updates on this?

Looks like something like this will get you going
<PropertyGroup>         <MSBuildCommunityTasksPath>$(USERPROFILE)\.nuget\packages\msbuildtasks\<IP_ADDRESS>\tools</MSBuildCommunityTasksPath>     </PropertyGroup>
obviously change this to your current version, as it implies above I found my tasks target file here:
C:\Users\{username}\.nuget\packages\msbuildtasks\<IP_ADDRESS>\tools

The problem is using NuGet as Package reference. I this case there is no installation folder relative to solution, only a local folder mentioned by lcornejo. I solved this by copying task files to solution dir and modified paths is .csproj pointing to this dir.

my csproj ended up wit this...
<PropertyGroup>
    <MSBuildCommunityTasksPath>$(SolutionDir)\packages\MSBuildTasks.<IP_ADDRESS>\build</MSBuildCommunityTasksPath>
  </PropertyGroup>
<Import Project="$(MSBuildCommunityTasksPath)\MSBuildTasks.targets" />


Passing MASTER_KEY from client

Just a question really,
In the README.md under 'Authenticate the user (sign in):' is it not insecure to pass a master key from the client? or have I simply misunderstood the correct usage of it here?

MASTER_KEY protects endpoints when you don't have any other key to do the job (e.g. when creating a new user).
That said, the registration process must be done on the server side of your application so the key will not be exposed to the client. If it isn't possible, you should remove the master key protection and make some kind of ORIGIN verification on the API.

Thanks @diegohaz very useful info, perhaps it could be added to the README.md as a use case?

Sure. Would you mind to send a PR with that?

Of course

@diegohaz If I understood you correctly, this would mean most users probably wouldn't need to set a master key when going to /auth which means removing the call to master() from the generation api/auth/index.js, do you agree?

I agree, but we would need to provide a secure method of validating origin urls or some other kind of protection.
Leaving those endpoints without any protection is a security issue as one can use them to indefinitely create resources on our server.

OK, I think i'll leave the README.md as-is for now. Thanks!

@diegohaz Sorry to raise up the subject but I'm a bit puzzled too by this. Let's say I have your REST backend server and I have another server that serves the frontend. The login page is rendered client side so when the user clicks on the  "sign in" I have to send a request to the auth/ api of the REST backend which includes the MASTER_KEY. But I don't understand how I could do that without exposing the MASTER_KEY on the client side as you said before:

That said, the registration process must be done on the server side of your application so the key will not be exposed to the client.
You were talking about the registration process but it's also true for the authentication process if I decide to use the MASTER_KEY validation on the auth api.

First of all, @diegohaz thank you for this great project! It helped me start quickly and with best practices, and I love the generator.
I am also puzzled by the concept of master key. I know about the idea of using it between the services to access each other, e.g. server1 could use server2's mater key to access it. However, as soon as master key is sent to client, it is not a secret any more, which seems to defeat it's purpose. Even if you do server rendering, master key can still be obtained, correct? I don't see how is server rendering more secure in this case.
Thank you!

However, as soon as master key is sent to client, it is not a secret any more, which seems to defeat it's purpose.

Hi, @Martinsos. That's true and that's why you should not send the master key (I agree that the name could be better) to the client (I mean, the browser, the JavaScript bundle etc.).
If you do server rendering (with Rails, PHP, Node etc.), you are able to keep part of your code hidden from the client.

Could you please explain in more details how are you able to keep part of
your code hidden if you are doing server side rendering?
On Aug 30, 2017 2:02 AM, "Haz"<EMAIL_ADDRESS>wrote:
However, as soon as master key is sent to client, it is not a secret any
more, which seems to defeat it's purpose.
Hi, @Martinsos https://github.com/martinsos. That's true and that's why
you should not send the master key (I agree that the name could be better)
to the client (I mean, the browser, the JavaScript bundle etc.).
If you do server rendering (with Rails, PHP, Node etc.), you are able to
keep part of your code hidden from the client.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/diegohaz/rest/issues/67#issuecomment-325847393, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ABdyh91hHC84hmxcE2hAQVnP8huk1Bzhks5sdLSrgaJpZM4McUxf
.

@Martinsos Try the redux-ssr branch of this repo: https://github.com/diegohaz/arc
src/server.js is only executed on server side, thus none of its contents is exposed to the client.

@diegohaz Thanks! I am looking at it, but I am not sure what to conclude
from it -> what am I looking for? Could you just describe the concept
shortly in words? I dont see any master key being used here.
I am assuming that you maybe ment the following: we have two servers, one
serving the webapp and one serving the api server. Webapp server has the
master key, and when it serves the js/html, request from js/html goes
through the webapp server who then uses master key to make the actual auth
request to the api server? Is that it?
But in that case, it is just one extra step, again anybody can send that
request to webapp server. Except if it has CORS, but in that case you could
have also had CORS on the api server, so again there is no need for master
key. I hope I am not asking too much, but I would really like to understand
what is the thing with the master key!
On Wed, Aug 30, 2017 at 10:49 PM, Haz<EMAIL_ADDRESS>wrote:

@Martinsos https://github.com/martinsos Try the redux-ssr branch of
this repo: https://github.com/diegohaz/arc
src/server.js is only executed on server side, thus none of its contents
is exposed to the client.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/diegohaz/rest/issues/67#issuecomment-326129174, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ABdyh3nV8usOElVpSKrPDMqdcDs3SNPHks5sddjfgaJpZM4McUxf
.

Your thoughts were correct, except that you will not expose a public rest endpoint on your webapp server. Instead, you will render an html form using method=POST and action=/your_endpoint.
Then, in the webapp server, /your_endpoint will respond to the POST request. That's different than an usual rest api request. The content-type, for example, will be application/x-www-form-urlencoded or multipart/form-data, instead of the application/json you usually receive in a REST API.
Of course, one can still forge that request or even create a fake page with a form with action=https://yoursite.com/your_endpoint. This exploit is called CSRF and is very easy to avoid. If you are using Node+Express, for example, you can use https://github.com/expressjs/csurf to protect agains CSRF attacks making sure the form that sent the data was generated by the same server that is processing the request.

Also, CORS is a browser protection. You should not rely on it as one can always request your API using curl.

Alright great, I did not know all this! I knew about CORS (going by with
curl), but I did not know that I can make sure that the form that sent the
data was generated by the same server. I will explore this further to learn
more, thank you for sharing.
Concluding from this, I think it might be good to somehow mention this in
the project, to explain when to use the master key and when not to. I think
big part of people will just assume they should use master key directly
from their SPA, not really thinking too much about the cases in which it
actually makes sense -> this is a rest api server and often we think about
using it directly with the SPA that is served on who knows what kind of
simple server, without any server rendering.
On Thu, Aug 31, 2017 at 12:56 AM, Haz<EMAIL_ADDRESS>wrote:

Also, CORS is a browser protection. You should not rely on it as one can
always request your API using curl.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/diegohaz/rest/issues/67#issuecomment-326150918, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ABdyh9c_OJ3RlKHFBnMXnldKtd-YfN2nks5sdfabgaJpZM4McUxf
.

Yeah, I agree. I would really appreciate a PR adding it to README.
You can still use it with SPA, without server rendering, but you will need to implement some other kind of secure method. I'm not aware of one. This is a very desirable PR as well.

@diegohaz It seems like the MASTER_KEY should be removed by default. You mentioned that the registration endpoint will be insecure https://github.com/diegohaz/rest/issues/67#issuecomment-286531368, but the common solution for this is to add captcha and email verification.
I believe your generator prompted me to integrate SendGrid for password reset. Would it be a difficult PR to implement email verification with that as well?

After reading all of this, I believe that the master key requirement should be removed from the login section. In this way, a normal user can attempt to login from an SPA without the master key. This is a norm in most apps.

I see your point, @psotos. But if we were to remove that, we would need to provide an alternative protection out of the box (and I'm open for suggestions and PRs). Otherwise, anyone can log in your server from anywhere.
I know that most of people don't care about it. Most don't even know the security issues of unprotected endpoints. But having this as an opt out option (which is as easy as removing one line of code) at least makes them to think about it and choose consciously.

They would still need valid credentials. I am only talking about removing the master key need from the login  endpoint. There are other ways to make it harder to hack like blocking a username from its ability to login for 1 hour after 3 or 5 failed login attempts, etc.

I'm not a security master, so if you could tell us (explained) another way to protect those master keys endpoints I might be able to work on it @psotos
Regards

Dan,
The whole point is that you DON'T protect a login endpoint, otherwise, people can't login! You don't want to have to have users knowing a master key to log in. So take off the master key necessity from the login endpoint. Someone with a valid username and password SHOULD be able to log in.

Peter
The idea of the master key is to be used by the application (from wherever you consume your rest server), not for the users. I'm pretty sure you don't ask your end clients to curl into your server, instead you would write up a user interface to interact with.
The thing with removing the master key in the log in is to avoid unwanted crawlers trying to log in with countless combinations of emails + passwords in an indefinite way.
Instead I recommend you to consider the master key as part of your user faced application. Putting here an example using Axios, Redux and Electron:
// request.js
import axios from 'axios';
import { SubmissionError } from 'redux-form';
import { ipcRenderer } from 'electron';

import { LOG_IN, RECEIVED_USER } from '../actions/auth';

const API = process.env.NODE_ENV === 'development' ? 'http://localhost:9000/' : 'http://casacuesta.juancaspro.webfactional.com/';
// const API = 'http://localhost:9000/';
// const API = 'http://casacuesta.juancaspro.webfactional.com/';
const MASTER_KEY = process.env.MASTER_KEY || '1Qejzgqm7HMYh5D4n1mH0q4nzArEPQUR';
const email = process.env.EMAIL ||<EMAIL_ADDRESS>const password = process.env.PASSWORD || '123456';

axios.defaults.baseURL = API;

axios.interceptors.response.use(response => response, ({ response: { data, status } }) => {
  if ([400, 409].indexOf(status) >= 0 && (!data.type || data.type !== 'EeagerLoading')) {
    let errObj = {};

    if (data.errors) {
      Object.keys(data.errors).forEach(key => {
        errObj[key] = data.errors[key].message;
      });
    } else {
      errObj = {
        [data.param]: data[data.name] ? data[data.name] : data.message
      };
    }

    throw new SubmissionError(errObj);
  }

  // Do something with response error
  return Promise.reject(data);
});

export default axios;

export function auth(dispatch) {
  return axios.post('/auth', {
    access_token: MASTER_KEY
  }, {
    auth: { username: email, password }
  })
  .then(({ data: { token, user } }) => {
    dispatch({ type: LOG_IN, payload: token });
    return dispatch({ type: RECEIVED_USER, payload: user });
  })
  .catch(console.log);
}

export function setAuthToken(token) {
  ipcRenderer.send('set-auth-token', token);
  axios.defaults.headers.common.Authorization = `Bearer ${token}`;
}

Its a single page app that I am writing. It will be communicating directly with the API.
"The thing with removing the master key in the log in is to avoid unwanted crawlers trying to log in with countless combinations of emails + passwords in an indefinite way."
There are lots of ways to handle this but here is one reasonable and widely used approach:
Write an algorithm which locks out users who make multiple bad requests by banning their IP. I can go into the full algorithm if you like but for the most part its a user lock out/IP banning approach.
How do I write an SPA with this Master Key problem? You have to admit that this is not a standard approach taken by others which is why people like me keep bringing it up.

One last thought, are Google, Microsoft, Twitter, LinkedIn, or any other large company with a huge userbase, subject to massive attacks by hackers using your master key approach for securing login urls? No they are not. They have other mechanisms for sure, but not this highly unusual mechanism for secure an endpoint, which by definition needs to be open. Anyway, I'm not trying to be pushy or annoying just trying to debate what is the more accepted mechanism for login type urls.

There are lots of ways to handle this but here is one reasonable and widely used approach:

Write an algorithm which locks out users who make multiple bad requests by banning their IP. I can go into the full algorithm if you like but for the most part its a user lock out/IP banning approach.

PRs welcome 😃

How do I write an SPA with this Master Key problem?
I don't see it as a problem, and also this code is for a SPA

You have to admit that this is not a standard approach taken by others which is why people like me keep bringing it up.
I've seen it in different projects (old projects)

If this is really a problem for you all you need to do is remove the master() middleware on any endpoints you have it in

Dan,
The code that you are referring to appears to be "server based", so some middle ware which sits between the SPA and the Endpoint. I'm not going to have such middle ware.
It's all good though, I will just remove the master protection from the login. I suggest a flag for generating code with an unprotected login.
I will think of some anti-login-spamming techniques and eventually push them as a PR. Again this project is amazing and I am very appreciative of the work put into it so far.

@psotos if I am correct, that is Electron based app that reads master key from the environment. So while it is a client in a sense, it is not what you meant by client code, which is an SPA, where you can't provide master key through the environment or with any similar mechanism.

Yes @psotos , the consumer app should know the precious MASTER_KEY. You can put it in a variable or somewhere else, there I'm taking it from the env variables, but however you're building your SPA you can put it on any kind of variable or retrieve it in any way you want.

Dan,
But my SPA code will only be served by the host, and not read any environment variables, and definitely not deliver them to the client side app. This is where I am confused. How does the client app, while running in the clients browser, gain access to the Master Key? Also, if it did, that would be a huge security hole since it would be visible to the client via the browsers dev tools, and therefore exposed. This is why I used the word precious. :)

Peter
I get that. Of course I don't use that on production, that gets built and compiled to compressed code. The only way that the client app, while running in the clients browser will gain access to the Master Key is if you put it in the code explicitly. Such as window.MASTER_KEY = 'aosidjoqiwjeoiqjwd' or something like that.
As we've been mentioning, the only purpose of the MASTER_KEY is to protect the log in endpoint (or whatever endpoints you decide), so attacks would need a little bit more effort to attack your endpoints.

@DanMMX sorry to interrupt, but what do you use in production, for SPA, then? Can you give an exact example of how you use SPA with master key?
Because if you have it in your SPA code, it does not matter if it gets compiled, compressed, obfuscated or whatever, string values (and master key is string value) are always public at the end. You can make them in theory much harder to read, but they will always be readable in some way. So you can't consider that a security mechanism, quite the opposite, it gives false feeling of security.
But @diegohaz  was previously mentioning some different mechanisms, like serving a form directly from server, outside of SPA, so I thought that was the approach? Although I have to admit I don't really understand how would that solution go, I have not given enough time into researching what Diego said there.

@Martinsos I concur as his is exactly what I am saying. Having a master key for login from an SPA just doesn't make sense. Guys please put a flag in your tool to disable this "feature".

I'd prefer to have a log in endpoint protected by a MASTER_KEY (even when it's public) for some generic attacks instead of a completely public endpoint. As I've mentioned previously, I'm not an expert on security and PRs to improve security are gently accepted.

@DanMMX The problem is, in an SPA, the only way to implement this master key concept is to pass it to the browser, which as @Martinsos mentioned makes the app WAY less secure. How does a user, let's say our Russian Trollbot LOL, log into our app? Do we email him the master key? Pass it up to the browser? Both of these are wildy unsecure because we know our Master Key will end up on Wikileaks! As you can see, there is no secure way to get this Master Key to the user to ensure that they don't put it out in the wild. This is why no major websites are implementing this type of protection. If you want security from concentrated hacking attempts, people tend to implement ip blocking and or user account locking for repeated failed password attempts.

I'm sorry about the delay. I'm gonna try to explain some things.
Why does MASTER_KEY exist?
When exposing POST/PUT/PATCH endpoints - that is, endpoints that create or modify resources on your server -, you have to protect them somehow. Usually, that protection is a user token acquired via login.
For authentication (signin/signup) endpoints, though, we don't have that protection. So, MASTER_KEY is a trivial yet efficient way to cover that.
If you're doing SPA, you should definitely go for another approach. But, it's better to keep MASTER_KEY than having no protection at all, even in SPAs, even exposing the key on the browser. That's why we won't remove it from this generator by default, unless someone come up with a better and equally easy solution.
How can we protect authentication in SPAs?
I'm not a big fan of password authentication in SPAs. I prefer to render those forms via server when I need to provide them.
The easiest and most secure way to do auth in SPAs is to avoid the password method at all and rely on social authentication. When using this generator, you just need to make sure to set your Facebook app secret. This way you're delegating the protection to Facebook.
If you still want to do password authentication in SPA, I recommend you to find and implement another kind of protection. If you don't, keeping MASTER_KEY is better than nothing. And, again, that's why we won't remove it from this generator by default.
How do I remove MASTER_KEY protection on a specific endpoint?
Just remove this line:
https://github.com/diegohaz/rest/blob/83cc9c38fd14db10188b9d2e4bc485e6a7f803e7/generators/app/templates/api/auth/index.js#L31
How do I create server rendered forms in "SPA"?
It depends on the library/framework you're using. In React, you can use the same code for server and client and handle POST requests like you would do in a non-SPA.
This is an example of a form rendered on the server in React (disable JavaScript): https://arc.diegohaz.com/sample-page

This line is responsible for handling the POST request on the server.
That static method is called here, which is a similar approach to Next.js' static getInitialProps.
Since the form can be sent via HTML, we have to protect it against CSRF attacks (yes, every approach has its own kind of security concerns).
The CSRF token is set in a redux store (see the reducer and the action) and put in a field named _csrf in the form.
When receiving the POST request, the csurf express middleware will check that field.

MASTER_KEY will end up on Wikileaks!
Then you invalidate it and generate a new one. If you had no protection, you could do nothing anyway.
Why don't we do like Google, Twitter, Microsoft, LinkedIn etc.?
These companies have security experts working for them. I'd love to provide the same approaches they use here, but I'm not good enough, sorry. 😅
But, well, all those companies, at least on their main products, render their authentication pages on the server and handle form submits via HTTP request (not ajax).


multi country db

Creating a db with Spain+Portugal+Andorra+Canary Island get an exception:
[StreamProgress] information - Pass 1 - Relation[138000] @ 88801.37/s
[StreamProgress] information - Pass 1 - Relation[165000] @ 106175.55/s
[StreamProgress] information - Pass 1 - Relation[165000] @ 106107.42/s
Unhandled Exception: System.AggregateException: One or more errors occurred. ---> OsmSharp.Streams.Exceptions.StreamNotSortedException: Exception of type 'OsmSharp.Streams.Exceptions.StreamNotSortedException' was thrown.
at OsmSharp.Streams.Filters.OsmStreamFilterMerge.MoveNext(Boolean ignoreNodes, Boolean ignoreWays, Boolean ignoreRelations)
at OsmSharp.Streams.Filters.OsmStreamFilterMerge.MoveNext(Boolean ignoreNodes, Boolean ignoreWays, Boolean ignoreRelations)
at OsmSharp.Streams.Filters.OsmStreamFilterMerge.MoveNext(Boolean ignoreNodes, Boolean ignoreWays, Boolean ignoreRelations)
at OsmSharp.Streams.Filters.OsmStreamFilterDelegate.DoMoveNext()
at OsmSharp.Streams.Filters.OsmStreamFilterDelegate.MoveNext(Boolean ignoreNodes, Boolean ignoreWays, Boolean ignoreRelations)
at OsmSharp.Streams.OsmStreamTarget.DoPull(Boolean ignoreNodes, Boolean ignoreWays, Boolean ignoreRelations)
at Itinero.IO.Osm.Streams.RouterDbStreamTarget.OnBeforePull()
at OsmSharp.Streams.OsmStreamTarget.Pull()
at Itinero.IO.Osm.RouterDbExtensions.LoadOsmData(RouterDb db, OsmStreamSource[] sources, Boolean allCore, Boolean processRestrictions, IEnumerable1 processors, Vehicle[] vehicles)    at OptiRoute.Routing.DbManagement.<>c__DisplayClass14.<CreateDb>b__11()    at System.Threading.Tasks.Task1.InnerInvoke()
at System.Threading.Tasks.Task.Execute()
--- End of stack trace from previous location where exception was thrown ---

Ben,
I modified IDP so that I can create a multi county db. With the modified IDP I didn't get the error.

Can I close this issue? Or you can send me the code you use for the above, I can check why things are not working.

Now I'm using a modified version of IDP. I've added it the feature of loading more than one country. With this modified version of IDP I'm able to build a multi country router db succesfully.
But if I use my custom program (see below a snippet) I still have the exception reported.
It is quite strange.
`
                List<OsmStreamSource> progresses = new List<OsmStreamSource>();
                foreach (var source in sources)
                {
                    if (enableProgress)
                    {
                        var progress = new OsmSharp.Streams.Filters.OsmStreamFilterProgress();
                        progress.RegisterSource(source);
                        progresses.Add(progress);
                    }
                    else
                        progresses.Add(source);
                }

                Array.ForEach(vehicles, (vei) => { vei.Register(); });

                // build db from stream.
                routerDb = new RouterDb();
                Array.ForEach(vehicles, (vei) => routerDb.AddSupportedVehicle(vei));
                routerDb.LoadOsmData(progresses.ToArray(), true, processRestrictions, processor, vehicles);
            }

            // sort the network.
            routerDb.Sort();

`

@alecava58 Did you retest this?
There was a fix in OsmSharp that should have fixed this issue...

I'll test tomorrow morning.
2017-03-02 15:18 GMT+01:00 Ben Abelshausen<EMAIL_ADDRESS>
@alecava58 https://github.com/alecava58 Did you retest this?
There was a fix in OsmSharp that should have fixed this issue...
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/itinero/routing/issues/65#issuecomment-283664923, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ABtMQfdiRmFSkNHAJC93n0FCTtErn1HWks5rhs_QgaJpZM4LnG4X
.

--
Alessandro Cavalieri

The error is not exactly the same but anyway referred to sort:

@alecava58 Testing this now, this is one of the last open issues before I consider Itinero to be v1.0. Where did you get the file for the Canary Islands?

I usually use geofabrik
http://download.geofabrik.de/africa.html

Ah yes, sorry, missed than one... will try again with that data included...

Now is ok.
Thanks.

Ok, thanks, just tried again and thinks look ok.


[Update Request]:

What type of update are you requesting?
A new version of an existing package
Current Package Identifier
Microsoft.OneDrive.Enterprise
Package Version
23.002.0102.0006
Please describe the changes you would like to see
No response

This package is out of date.

@cpatrick006 This issue can be closed as "Completed".

The requested version is already included in winget
Package manifests is submitted by https://github.com/microsoft/winget-pkgs/pull/101886 , a month before this issue opened.


How to add headers?

Issue:
I am trying to use a proxy server to get around CORS images, however the proxy server must receive HEADERS otherwise the request will fail.
Is this even possible with this library?
I found this extension that seems to be able to do it. I just wanted to make sure that this library is, in fact, incapable of doing so.
Specifications:

html2canvas version tested with: 1.0.0-rc.7
Browser: Chrome
Operating system: macOS

If anyone is curious I ended up editing one file in node modules (2 lines of code, to be precise).
I needed to add headers, and also use withCredentials when fetching the image with proxy.
I used patch-package to make sure the changes will persist. This is the patch:
diff --git a/node_modules/html2canvas/dist/html2canvas.js b/node_modules/html2canvas/dist/html2canvas.js
index 210184e..030edad 100644
--- a/node_modules/html2canvas/dist/html2canvas.js
+++ b/node_modules/html2canvas/dist/html2canvas.js
@@ -2566,6 +2566,7 @@
             return new Promise(function (resolve, reject) {
                 var responseType = FEATURES.SUPPORT_RESPONSE_TYPE ? 'blob' : 'text';
                 var xhr = new XMLHttpRequest();
+                if (_this._options.authorization) xhr.withCredentials = true;
                 xhr.onload = function () {
                     if (xhr.status === 200) {
                         if (responseType === 'text') {
@@ -2584,6 +2585,7 @@
                 };
                 xhr.onerror = reject;
                 xhr.open('GET', proxy + "?url=" + encodeURIComponent(src) + "&responseType=" + responseType);
+                if (_this._options.authorization) xhr.setRequestHeader('Authorization', _this._options.authorization);
                 if (responseType !== 'text' && xhr instanceof XMLHttpRequest) {
                     xhr.responseType = responseType;
                 }

And I use is like this:
html2canvas(mainDiv, {
                logging: false,
                proxy: 'https://my-proxy-address',
                authorization: 'Bearer ' + csrf_token, // <-------
                onclone: cloned => {
                    const svgElements = cloned.getElementById("mainCanvasDiv").getElementsByTagName("svg");
                    Array.from(svgElements).forEach(svgElement => {
                        const bBox = svgElement.getBBox();
                        svgElement.setAttribute("width", bBox.width);
                        svgElement.setAttribute("height", bBox.height);
                    });
                }
            }).then(...);

@Dror-Bar  Can you do an PR for everyone :) ?


permission denied issue

When I try
Build, Run, and Debug:
Open server.go
Add a breakpoint (e.g. on line 22).
Press F5 to launch the app in the container.
I got blocked as below:
go build main: copying /tmp/go-build249607315/b001/exe/a.out: open /workspaces/vscode-remote-try-go/src/main/__debug_bin: permission denied
exit status 1
Process exiting with code: 1

It is permission issue , type 'sudo chmod 777 -R /workspaces/vscode-remote-try-go/' and resolved it.


Debian pre-built modules failing

Describe the bug
Hello,
After the release of v0.35.0 addressing this other bug affecting Debian #2374, we realized the pre-built modules are failing when loading them under Debian, raising this error during Kubernetes init process (falco-driver-loader)
* Found a prebuilt falco module at /root/.falco/5.0.1+driver/x86_64/falco_debian_4.19.282-1-amd64_1.ko, loading it insmod: ERROR: could not insert module /root/.falco/5.0.1+driver/x86_64/falco_debian_4.19.282-1-amd64_1.ko: Invalid module format
This message can be observed in the OS dmesg
falco: disagrees about version of symbol module_layout
How to reproduce it
Deploy https://github.com/falcosecurity/charts/tree/master/falco helm chart in a Kubernetes cluster using nodes with Debian (10 or 11)
Expected behaviour
The module should load ok
Environment

Falco version: v0.35.0
Cloud provider or hardware configuration: VMs with Vanilla K8s running in vmware
OS:
PRETTY_NAME="Debian GNU/Linux 10 (buster)" NAME="Debian GNU/Linux" VERSION_ID="10" VERSION="10 (buster)" VERSION_CODENAME=buster ID=debian HOME_URL="https://www.debian.org/" SUPPORT_URL="https://www.debian.org/support" BUG_REPORT_URL="https://bugs.debian.org/"
Kernel:
Linux kube1 4.19.0-24-amd64 #1 SMP Debian 4.19.282-1 (2023-04-29) x86_64 GNU/Linux
Installation method: Falco helm chart for K8s

Additional context
Issue #2374 is related, as https://github.com/falcosecurity/falco/issues/2374#issuecomment-1409850595 is having the same problem after the fix
Thanks in advance, best regards

cc @falcosecurity/driverkit-maintainers

For an ubuntu-aws example, see this:
We got both:

ubuntu-aws_5.19.0-1025-aws_26.ko
ubuntu-aws-5.19_5.19.0-1025-aws-5.19_26~22.04.1

driverkit configs (note: the latter is not even built because our test-infra regex is not smart enough), yet we resolve ubuntu-aws 22.04.1 to the former (ie: ubuntu-aws_5.19.0-1025-aws_26.ko) and it is giving the exact same issue.
This is something @therealbobo is working on.
I think it might deserve a bugfix release, since it will involve touching falco-driver-loader for sure.
Your problem instead seems a bit weirder because, as i said, we had people testing the fix and it worked fine; unless there are multiple debian 4.19.282-1 in this case too, i don't get why it should fail.
But i don't get why these distros hate us so much :laughing:

Another possibility is that we are using the wrong headers for some debian builds: https://falcosecurity.github.io/kernel-crawler/?arch=x86_64&target=Debian.
For example, if i search 4.19. there, i see that headers for:

4.19.282-1-amd64 are: 1) linux-headers-rt 2) linux-headers-common-rt 3) linux-headers 4) linux-headers-common 5) linux-headers-cloud 6) linux-kbuild
4.19.269-1-amd64 are: 1) linux-headers-common 2) linux-headers-cloud 3) linux-headers-common-rt 4) linux-headers 5) linux-headers-rt 6) linux-kbuild

Driverkit downloads all of them: https://github.com/falcosecurity/driverkit/blob/master/pkg/driverbuilder/builder/templates/debian.sh#L18, then uses a regex to match the correct one: https://github.com/falcosecurity/driverkit/blob/master/pkg/driverbuilder/builder/templates/debian.sh#L30, that resolves to KernelHeadersPattern = "linux-headers-*" + kr.Architecture.String().
So, i think it might be trying to use eg: an rt configuration instead of the normal one.
That would cause a breakage.
I will try a couple of things and come back later with more info!

So, i made some tests:
Using driverkit v0.13.0 (the one used by test-infra to build drivers), i re-built the kmod for your debian kernel; md5sums match:
7ecb5718117b373f6c58148bd1dc2fdf  /tmp/falco_debian_4.19.282-1-amd64_1.ko
7ecb5718117b373f6c58148bd1dc2fdf  falco_debian_4.19.282-1-amd64_1.ko

(the /tmp/ one is the one i built, the other is downloaded from download.falco.org).
Then i tried to use kernelurls with only rt entries (plus the kbuild one), and... magic! The results are exactly the same:
7ecb5718117b373f6c58148bd1dc2fdf  /tmp/falco_debian_4.19.282-1-amd64_1.ko
7ecb5718117b373f6c58148bd1dc2fdf  falco_debian_4.19.282-1-amd64_1.ko

So, we are building the rt configuration.
Finally, i tried to build using only the non-rt kernelurls and:
8421e03822e4dcda2d4065ead5e7760e  /tmp/falco_debian_4.19.282-1-amd64_1.ko
7ecb5718117b373f6c58148bd1dc2fdf  falco_debian_4.19.282-1-amd64_1.ko

They differ! I can share the kmod with you @glpfloss , can you test if you can inject it?
If that's the issue, the fix is to "simply" update kernel-crawler to generate multiple entries (one for normal, one for -rt, one for -cloud); that is a bug btw.
This should not even require a Falco patch release :)
falco_debian_4.19.282-1-amd64_1.ko.zip
:pray: let us know! Thank you!

Also, can you share your /etc/os-release file?

Also, falco-driver-loader patch to properly support cloud and rt debian kernel flavors: https://github.com/falcosecurity/falco/pull/2627.
This means that until Falco 0.36 (or possibly 0.35.1, but for now nobody ever asked us about rt and cloud flavors, therefore it's not a big deal to wait), we will only support normal debian kernel flavor, ie: the one you are using.

Whoa, thank you @FedeDP , im going to try to answer all your questions
Care to try using ebpf instead?
With epbf, falco-driver-loader ends ok:
* Trying to download a prebuilt eBPF probe from https://download.falco.org/driver/5.0.1%2Bdriver/x86_64/falco_debian_4.19.282-1-amd64_1.o
* Skipping compilation, eBPF probe is already present in /root/.falco/5.0.1+driver/x86_64/falco_debian_4.19.282-1-amd64_1.o
* eBPF probe located in /root/.falco/5.0.1+driver/x86_64/falco_debian_4.19.282-1-amd64_1.o
* Success: eBPF probe symlinked to /root/.falco/falco-bpf.o

But then, falco container fails with this error:
Thu Jun  8 16:57:44 2023: Enabled event sources: syscall
Thu Jun  8 16:57:44 2023: Opening 'syscall' source with BPF probe. BPF probe path: /root/.falco/falco-bpf.o
Thu Jun  8 16:57:44 2023: An error occurred in an event source, forcing termination...
Events detected: 0
Rule counts by severity:
Triggered rules by rule name:
Error: BPF probe is compiled for 4.19.0-24-rt-amd64, but running version is 4.19.0-24-amd64

They differ! I can share the kmod with you , can you test if you can inject it?
I can confirm if i inject that module to the falco-driver-loader it works:
* Found a prebuilt falco module at /root/.falco/5.0.1+driver/x86_64/falco_debian_4.19.282-1-amd64_1.ko, loading it
* Success: falco module found and inserted

Falco container is reporting healthy status after the init, so i guess this is good
Also, can you share your /etc/os-release file?
PRETTY_NAME="Debian GNU/Linux 10 (buster)"
NAME="Debian GNU/Linux"
VERSION_ID="10"
VERSION="10 (buster)"
VERSION_CODENAME=buster
ID=debian
HOME_URL="https://www.debian.org/"
SUPPORT_URL="https://www.debian.org/support"
BUG_REPORT_URL="https://bugs.debian.org/"

Please let me know if i forgot something, thank you for your quick support

Yay then my patch is ok! Thank you very much for the quick response!
We will fix the upstream artifacts (download.falco.org) asap, during next week!

Thank you @FedeDP , please if you don't mind, i would appreciate if you can leave a message here when modules are fixed in the bucket

Of course I will! Really thank you for helping us spot this issue!

News :loudspeaker:
We will be releasing a 0.35.1 Falco patch release that will include my fix :rocket:
/milestone 0.35.1
Sorry, we are still unable to fixup published artifacts because we are still waiting for kernel-crawler PR to get merged: https://github.com/falcosecurity/kernel-crawler/pull/147

I'll reopen this one because the issue is still alive. We need to replace debian artifacts for drivers 5.0.1+driver.
/reopen

@FedeDP: Reopened this issue.

In response to this:

I'll reopen this one because the issue is still alive. We need to replace debian artifacts for drivers 5.0.1+driver.
/reopen

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Ehy we finally took the time to republish all debian driver artifacts; the issue should now be solved; here is the new link to your driver: https://download.falco.org/driver/5.0.1%2Bdriver/x86_64/falco_debian_4.19.282-1-amd64_1.ko.
I checked and it has exactly same shasum as the one i shared with you a couple of weeks ago:

falco_debian_4.19.282-1-amd64_1.ko.zip

/close

@FedeDP: Closing this issue.

In response to this:

/close

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.


Change Loot tracker "Collapse / Un-collapse All" button tooltip text

Change the modal text to be the correct action on the collapse button. After looking at the logic I believe that the this change makes the most sense as the button state should be 'on' if all loot boxes are collapsed.
This should resolve #15111

fixed in #15118


Actions on pull request target

Users who only have Read permission cannot request a review. Therefore, when a pull request is created and opened (or ready-for-review) from a forked, @yukifuji san becomes a reviewer automatically. In addition, we also want to merge the pull request automatically when the review is completed.

Thanks for the review. I have fixed those.


VS 2019 + CodeCommit Integration + Git commands issue

Expected Behavior
It's expected that the command GIT PUSH ORIGIN MASTER uploads the file to the master branch without any error.
Current Behavior
Running the command GIT PUSH ORIGIN MASTER uploads the file to the master branch but the following error appear:
git : To https://git-codecommit.us-east-1.amazonaws.com/v1/repos/Myfirstrepo
At line:1 char:1

git push origin master

  + CategoryInfo          : NotSpecified: (To https://git-...pos/Myfirstrepo:String) [], RemoteException
  + FullyQualifiedErrorId : NativeCommandError

 f927b67..8fe9116  master -> master

Steps to Reproduce (for bugs)
git add
git commit -m "Commit message"
git push origin master
Your Environment

AWSSDK.Core version used:
Service assembly and version used:
Operating System and version: Windows Server 2019 Datacenter
Visual Studio version: VS Community 2016 - Version 16.0.1
Targeted .NET platform:

.NET Core Info

.NET Core version used for development:
.NET Core version installed in the environment where application runs:
Output of dotnet --info:
Contents of project.json/project.csproj:

I am closing this issue out due to lack of activity. If you are still experiencing a problem with how the AWS Toolkit for Visual Studio interacts with CodeCommit, please file a new issue explaining how you set up your CodeCommit repo/connection.


"Should we use prerelease versions?" doesn't parse response well

If I type "y" for the "Should we use prerelease versions?" prompt, it still doesn't use prerelease versions. It only does this if I type "Yes"

This bit me, too. i lazy. n type y

It's also a bit misleading because currently it influences the default choice of Plone version, but not the default choice of Volto version

Along with this UI/UX update, there are two other things that bug me, and I don't know whether to pile on this issue or create new ones, or whether to file issues in this repo or the templates repo.

Hyphenate "add-on"
Use sentence case in prompts instead of Word Case. The latter feels a wee bit shouty.

@stevepiercy Let's handle that separately because the prompt text itself is in cookieplone-templates, unlike the code that handles parsing this particular response. You'll find the prompts in the cookiecutter.json files in cookieplone-templates.
To test changes with a local clone of the templates, you can run COOKIEPLONE_REPOSITORY=~/path/to/cookieplone-templates uvx cookieplone


Update email address

I saw the flurry of activity today and thought I'd get in on it! I'm no longer with Zencoder so this change probably makes sense.

oh and I still have access to push the gem on rubygems, is that intentional?

I can remove it if you don't want it anymore. :)


handle same data, clusterChanged  was invoked more than one time

as a result , page will reload same data many times with content flickering in the scrollContainer .
anyone help?

hi
could you please provide an example at codepen?

Sorry mate, I can't reproduce
http://codepen.io/NeXTs/pen/EgXXoP?editors=1010
Which version do you use?
Make sure you are using at least v0.16.0, there was related fix. Of corse better would be to use latest v0.17.1

@NeXTs  bro,sorry I cann't give u all the code. becuase the data is so large . and I use vue .
you can see this codes:
log has a  watch function ,when log change ,update  cluster
    watch: {
      'logs': function(val) {
        clusterizeobj.update(val)
      }
    },

   clusterizeobj=new Clusterize({
        rows: data,
        scrollId : 'ScrollContainer',
        contentId : 'LogContainer',
        callbacks : {
          clusterChanged:  ()=> {
            console.log('invoked time', moment(new Date()).format('HH:mm:ss'), new Date().getTime())
          }
        }
      })

the log picture:

well, such behaviour may be caused by using it in pair with vue :\
I am not familiar with vue and I don't know which impact it has on DOM

if clusterizeobj.update(val)  this function execute successfully,  is there some conditions?

@NeXTs  you can use large data . every single item string 's length is more than 20 0r 30 or 40  。。maybe it occurs

I think would be better if you ask this guy
https://github.com/vue-comps/vue-clusterize
I'm sorry but I really can't help you with this. It works fine with pure js version

@NeXTs  thanks

I have the same problem but in javascript vanilla