Improve transfer UI

Right now, transferring works but is fairly non-intuitive. It would be cool to fix that.

Tranferring an item:

[ ] Make the transfer link a button in the order summary, to make it clear that it's not a statement describing the ticket

[ ] Possibly hide this in a settings dropdown if there are other settings we might like to make available. (e.g. changing to whom the item is assigned?) It's a little weird how prominent this option is.
[ ] Possibly make it say "Initiate transfer" so that it is extra clear that it is an action

[ ] Add panels for "Transfer Pending" and "Transferred" below the "Attendees" panel in the order summary. All panels only appear if they have contents.
[ ] "Transfer Pending" panel

[ ] Has attendee names as above (to make it clear which thing you would get back if you cancelled)
[ ] Has a "Cancel transfer" button in place of the transfer button

[ ] "Transferred" panel

[ ] Does not show attendee names, because they are no longer relevant
[ ] Shows a list of items and two whom they were transferred, with no links

Receiving a transfer

[ ] Add an alert that says that you are currently working on receiving a transferred item
[ ] Show from whom a transfer was received in the receipt, e.g. "Transfer from Naomi"


MaterialSpinner vs Espresso

I am trying to write instrumentation tests for my app. But I have faced strange problem when I run my tests.
android.support.test.espresso.PerformException: Error performing 'load adapter data' on view 'is assignable from class: class android.widget.AdapterView'.
at android.support.test.espresso.PerformException$Builder.build(PerformException.java:83)
at android.support.test.espresso.base.DefaultFailureHandler.getUserFriendlyError(DefaultFailureHandler.java:70)
at android.support.test.espresso.base.DefaultFailureHandler.handle(DefaultFailureHandler.java:53)
at android.support.test.espresso.ViewInteraction.runSynchronouslyOnUiThread(ViewInteraction.java:184)
at android.support.test.espresso.ViewInteraction.doPerform(ViewInteraction.java:115)
at android.support.test.espresso.ViewInteraction.perform(ViewInteraction.java:87)
at android.support.test.espresso.DataInteraction.load(DataInteraction.java:151)
at android.support.test.espresso.DataInteraction.perform(DataInteraction.java:128)
at project.ActivityTest.test2withoutSeason(EditAgroOperationActivityTest.java:54) <------
And here is code:
@Test
public void test2withoutSeason() {
onView(withId(R.id.operation_status_spinner)).
check(matches(isAssignableFrom(AdapterView.class)));
onView(withId(R.id.operation_status_spinner)).perform(click());
onData(allOf(instanceOf(String.class), is(R.string.planned))).perform(click()); <---------
}
So Espresso tries to check that MaterialSpinner is assignable from AdapterView when performing load and throws exception.
How can this be if    check(matches(isAssignableFrom(AdapterView.class))) runs correctly?

I replaced Espresso code with this
onData(anything()).inAdapterView(withId(R.id.operation_status_spinner)).atPosition(2).perform(click());
and it works fine

Thanks for the example @Daard. Closing since I understand it was a bug in Espresso and you managed to solve it.


Postgres surfacer metric filter bugfix

Hello,
during the initialisation of postgres surfacer options are never set but are later on used to check if metrics should be sent to Postgres database.
I added the options as a parameter of creating postgres surfacer.

Thanks so much @markoposavec for the fix!


Fix test_path_like_objects

add support for FsPath

Oh, FsPath is placed in os.rs but it is not compiled for wasm.
relocating them to a new file vm/src/function/fspath.rs or vm/src/function/mod.rs will be helpful.

@ilp-sys Hi, is this accidently closed? could you open it again?

I must have done something wrong with the git cli, reopened it .

I found refactoring FsPath is more complex issue than it looks like. Let me look in more for a few more days.

@ilp-sys #4782 is finally done! Could you please rebase this patch? I think removing the last commit will make the other 2 commits be rebase without conflict. And not that much changes will be needed.

test_basic_script_with_path_object is also succsesful


Increment version for deviceprovisioningservices releases

Increment package version after release of Azure.ResourceManager.DeviceProvisioningServices

API change check
API changes are not detected in this pull request.


[ReadPermission()] for multiples

What is the way to grant read to multiple permissions?
Say for example
[ReadPermission("GroupA")]
[ReadPermission("GroupB")]

Will create a duplicate entry. It might be because I am sleepy this morning.

There is no such thing. Either define a common permission, or implement manual check with Authorization.ValidatePermission etc.

Ok that makes sense then. I can do that. Thanks Volkan.


SCImageView does not take into account ContentMode while rendering

This used to be working properly in the past but I see this issue in later versions of this library.
The rendering seems to follow UIViewContentModeScaleToFill regardless of what scaleAndResizeCIImageAutomatically  value is and the output is stretched as a result.
Referring an old version I managed to fix this momentarily by replacing the following line in the method
- (void)glkView:(GLKView *)view drawInRect:(CGRect)rect { }

[_context.CIContext drawImage:image inRect:rect fromRect:image.extent];

with

[_context.CIContext drawImage:image inRect:[self processRect:rect withImageSize:image.extent.size] fromRect:image.extent];

- (CGRect)processRect:(CGRect)rect withImageSize:(CGSize)imageSize {

    rect = CGRectMultiply(rect, 1);

    if (self.contentMode != UIViewContentModeScaleToFill) {
        CGFloat horizontalScale = rect.size.width / imageSize.width;
        CGFloat verticalScale = rect.size.height / imageSize.height;

        BOOL shouldResizeWidth = self.contentMode == UIViewContentModeScaleAspectFit ? horizontalScale > verticalScale : verticalScale > horizontalScale;
        BOOL shouldResizeHeight = self.contentMode == UIViewContentModeScaleAspectFit ? verticalScale > horizontalScale : horizontalScale > verticalScale;

        if (shouldResizeWidth) {
            CGFloat newWidth = imageSize.width * verticalScale;
            rect.origin.x = (rect.size.width / 2 - newWidth / 2);
            rect.size.width = newWidth;
        } else if (shouldResizeHeight) {
            CGFloat newHeight = imageSize.height * horizontalScale;
            rect.origin.y = (rect.size.height / 2 - newHeight / 2);
            rect.size.height = newHeight;
        }
    }

    return rect;
}

This property helped me get things done in ## SCImageView.m at line 53 change the line to this _scaleAndResizeCIImageAutomatically = NO;
The preview picture should not be resized now :)

@renjithn can you raise a pull request for this so we can try and get it into a release?


(degiro) stock return computation

FIFO method implementation in degiro
NOTE: tests can be done by adapting IBKR stocks P&L summary

Create individual dataframes for each of the stocks. Use polars filtering and select methods!


Crash with items-opaque folder

I have added a file called chorus_fruit_0.png on assets/images/items-opaque on my addon, but when I use setIcon("chorus_fruit", 0); crashes BlockLauncher when I try to see the item.
Android: 4.4.2 and 5.0.2.
Processors: x86 and ARMv7
BL Version: latest Pro version from Google Play
MCPE Version: 0.14.0.b3
(Sorry by bad english, I'm brazilian!)

0.14 dont support mods

Yes, it supports mods, but only add-ons, no ModPE Scripts.

Oh :v

That's true

Why do you man? :new_moon_with_face:

[]
-[

@]gg

BlockLauncher for 0.14.0 doesn't support custom textures in packs at all right now (since the items.meta format is slightly different). Please reopen this when full version of 0.14.0 is released.


Will live-share be open sourced?

Just wondering will it be open sourced sometime down the road?

@Chuxel @lostintangent

@coodoo Hey! Thanks for reaching out. While Live Share is still in preview, the source is highly volatile 😄Because of this, we're not quite ready to accept contributions or support the APIs that folks might begin to depend on, and so we haven't open-sourced yet. For now, we're trying to focus on addressing all of the great feedback we've been getting during the preview, and make sure that we're nailing the collaboration experiences that we set out to.
We'll definitely share plans openly moving forward, so stay tuned, and let us know if you have any other questions. Thanks!

Hello, it’s been almost a year and I was curious if this is still the plan. Thanks!

Bump? @lostintangent


Mobile work offline mode

Overlay is behind menu bar and out of focus because of game in progress modal

Was fixed in https://github.com/Eddcakes/mini-golf-scores/pull/12


Nteract hides values in VSCode

Describe the bug
In the nteract cell output, hovering over a data point positioned at the upper half hides the values behind the cell edge (see the screenshot).
This is the case for most charts. It makes nteract unusable since the actual values are not obtainable.
Which version of .NET Interactive are you using?
1.0.221505+e29a5169b998976335b389d825d6a99a08d58654

OS

[x] Windows 10
[ ] macOS
[ ] Linux (Please specify distro)
[ ] iOS
[ ] Android

Frontend

[x] Jupyter Notebook
[ ] Jupyter Lab
[x] nteract
[x] Visual Studio Code
[ ] Visual Studio Code Insiders
[ ] Other (please specify)

Screenshots

The output is bounded by an IFRAME so this is a little difficult to fix in-place. One proposed solution that could work around this: https://github.com/microsoft/vscode/issues/143244


Joining voice chat always throw errors

joinVoiceChat is always throwing [ReferenceError: this is not defined]

Nevermind, it was my fault


Adding execute permissions to exe/rbpad

Add execute permission to exe/rbpad. This is because exe/rbpad is an executable file.

Thanks.
I did not recognize it.


Wrapping Text?

Sorry if this is just me badly misreading the documentation, but am I correct in my understanding that there's no currently supported way to flow text into an area on the page, with automatic line breaks when the text reaches the edge of the area?  And if that is the case, is there any particular reason not to support it?  Would you be receptive to a pull request adding a boundedText function?

try to use the split_text_to_size plugin.

Oh, that sounds perfect, thanks

Try it and if it is working for you then please close the issue ;)

Looks like that does exactly what I want.  The only thing I'd suggest is that it would be nice if the plugins could be rolled into the auto-doc, and if there was some kind of documentation somewhere about plugins/ and exactly what the distinction is between it and the core library (because it seems like they all just get merged into the jsPDF object in the distributed code?)


Fix launcher pid file lock inheritance issue (PEP446 workaround)

I am offering this PR to fix a bug in the current launcher.py affecting all python 3.4+.
Problem
Since PEP446 (Python 3.4+), file descriptors created by most of the Python API calls are non-inheritable which means they get closed on calls like os.exec*.
The launcher.py currently detects the liveness of the service (ie when calling launcher.py status) process by checking the flock on its PID file created as part of the launcher.py run invocation. If however, the PID file descriptor created during the run stage is not inheritable, the lock gets lost when the PID file is auto-closed upon doing the os.exec of the java process.
This means the service process invoked by launcher.py on Python 3.4+ cannot be further managed by the launcher as it doesn't see it alive (moreover it allows launching multiple instances).
Solution
The PEP446 provided a new method for setting the file descriptors inheritable (os.set_inehritable). Using this in the launcher would however be backward-incompatible for older Python versions. I propose to implement the workaround using the os.dup2 call which is (still after PEP446) creating inheritable descriptors and is fully compatible even for Python 2+.

@antonymayi thanks for your PR and especially for describing the underlying problem so well

Merged, thanks!

@antonymayi FYI on Presto slack there is #airlift channel.
See you there!


Custom Types Returned from Directives Not Working

Describe the bug
Our app uses a custom @email directive that does some extra validation and returns a type of Email
export class EmailType extends GraphQLScalarType {
  constructor(type: GraphQLScalarType) {
    super({
      name: 'Email',
      parseValue: (value) => {
        if (!validateEmail(value)) {
          throw new UserInputError('Email address failed validation');
        }

        return type.parseValue(value);
      },
      serialize: (value) => type.serialize(value),
      parseLiteral: (ast) => {
        if (ast.kind === Kind.STRING && !validateEmail(ast.value)) {
          throw new UserInputError('Email address failed validation');
        }

        return type.parseLiteral(ast, {});
      },
    });
  }
}

Our schema is defined like this:
input UserInput {
  email: String! @email
  firstName: String!
  lastName: String!
}

Codegen outputs types that look like:
export type CreateUserInput = {
  email: Scalars['String'];
  firstName: Scalars['String'];
  lastName: Scalars['String'];
};

This makes sense because it's the custom directive javascript code that returns the Email type.
Our problem is we use Apollo Studio and ApolloServerPluginSchemaReporting to report our schema to Apollo Studio. Apollo while running evaluates our UserInputType as:
input UserInput {
  email: Email
  firstName: String!
  lastName: String!
};

However in CI when we do schema validation we get failures because our graphql-codgen schema shows those types as simplyString and not type Email
I've done a lot of digging and I can't seem to find a proper way to remedy this. Can codegen convert @email directives to the correct interpolated type?

My GraphQL schema:

input UserInput {
  email: String! @email
  firstName: String!
  lastName: String!
}

My codegen.yml config file:

schema:
  - 'src/graphql/**/schema.ts'
  - 'src/graphql/**/regexp.ts'
  - 'src/graphql/directives/email.ts'
  - 'src/graphql/directives/length.ts'
generates:
  src/graphql/generated/graphql.ts:
    config:
      contextType: '@graphql/index#Context'
      enumsAsTypes: true
      noSchemaStitching: true
      # https://graphql-code-generator.com/docs/plugins/typescript-resolvers#mappers---overwrite-parents-and-resolved-values
      scalars:
        Cursor: ../scalar_types#Cursor
        Date: ../scalar_types#DayString
        DateTime: ../scalar_types#DateTimeString
        PositiveFloat: ../scalar_types#PositiveFloat
        PositiveInt: ../scalar_types#PositiveInt
        NonNegativeFloat: ../scalar_types#NonNegativeFloat
        NonNegativeInt: ../scalar_types#NonNegativeInt
        RegExp: RegExp
      useIndexSignature: true
    plugins:
      - add: |
          /* eslint-disable */
          /* THIS IS A GENERATED FILE, DO NOT EDIT. */
      - 'typescript'
      - 'typescript-resolvers'
  src/graphql/generated/schema.graphql:
    plugins:
      - schema-ast
    config:
      includeDirectives: true
  src/graphql/generated/schema.json:
    plugins:
      - introspection
    config:
      minify: false

Hi @mikefisher84 ,
This is a very specific use-case, where you use a directive to manipulate the schema? Where is it done? Because it seems like your are referring to a schemaDirective that changes the schema?
Btw, why not use a scalar called Email and do this kind of validation there? you'll get the same result with a statically defined type.

Hey @dotansimha thanks for getting back to me and I can't say I completely disagree with you regarding the custom Email scalar. However I'm basically following an example out of the Apollo documentation around custom directives verbatim, so I'm surprised I'm the first person to have this issue. Also while I only mentioned the @email use case in my ticket we also have an identical @length custom directive as described below.
If you look at the Apollo docs around implementing custom directives. They create a @length(8) directive to enforce a maximum length of a string.
Which they define like this
  type Book {
    title: String @length(max: 50)
  }

They have a class that creates the logic for the directive:
class LengthDirective extends SchemaDirectiveVisitor {
  visitInputFieldDefinition(field) {
    this.wrapType(field);
  }

  visitFieldDefinition(field) {
    this.wrapType(field);
  }

  // Replace field.type with a custom GraphQLScalarType that enforces the
  // length restriction.
  wrapType(field) {
    if (
      field.type instanceof GraphQLNonNull &&
      field.type.ofType instanceof GraphQLScalarType
    ) {
      field.type = new GraphQLNonNull(
        new LimitedLengthType(field.type.ofType, this.args.max),
      );
    } else if (field.type instanceof GraphQLScalarType) {
      field.type = new LimitedLengthType(field.type, this.args.max);
    } else {
      throw new Error(`Not a scalar type: ${field.type}`);
    }
  }
}

Then they have a class that returns a different type for anything that is decorated with the @length directive.
class LimitedLengthType extends GraphQLScalarType {
  constructor(type, maxLength) {
    super({
      name: `LengthAtMost${maxLength}`,

      // For more information about GraphQLScalar type (de)serialization,
      // see the graphql-js implementation:
      // https://github.com/graphql/graphql-js/blob/31ae8a8e8312/src/type/definition.js#L425-L446

      serialize(value) {
        value = type.serialize(value);
        assert.isAtMost(value.length, maxLength);
        return value;
      },

      parseValue(value) {
        return type.parseValue(value);
      },

      parseLiteral(ast) {
        return type.parseLiteral(ast);
      },
    });
  }
}

Specifically this line is where the new scalar is being created.
name: LengthAtMost${maxLength},
So you could see in this example it wouldn't be very scalable to make a custom scalar for every MaxLength type in the app as you'd have to create: MaxLength6, MaxLength8 so on and so forth for every potential argument your @length() directive could support. .

Got it. But still, it's a custom way to declare your schema. I do agree that it's needed, since you can't pass arguments to scalars. In case of an email, scalar fits perfectly.
In case of more complex examples, like the one you shared, it is needed.
To workaround that, you can tell codegen to load your schema from a code file, and tell it to ignore plucking. This will result in require to your file, and get the actual schema from your code (after all modifications).
Take a look at this page: https://graphql-code-generator.com/docs/getting-started/schema-field#code-files (note noPluck config).
Then, make sure to point codegen to a file (preferably, a single .ts file) that exports the ready, modified, GraphQLSchema object.

Thanks @dotansimha ! I'm working on implementing that solution but it seems when I add noPluck codegen throws cli errors.
src/graphql/generated/graphql.ts
    Failed to load schema from src/graphql/**/schema.ts,src/graphql/**/regexp.ts,src/graphql/directives/email.ts,src/graphql/directives/length.ts:

        Unable to load from file "/Users/mike/app/src/graphql/directives/length.ts": Cannot use import statement outside a module
        Error: Unable to load from file "/Users/mike/app/src/graphql/directives/length.ts": Cannot use import statement outside a module
    at tryToLoadFromExport (/Users/mike/app/node_modules/@graphql-tools/code-file-loader/index.cjs.js:143:15)

The top of my codegen yml now looks like this:
schema:
  # This glob pattern searches for all schema.ts files with gql tags to generate the schema.
  # We also need to include the custom regexs and directives to properly generate schema and types
  - 'src/graphql/**/schema.ts'
  - 'src/graphql/**/regexp.ts'
  - 'src/graphql/directives/email.ts'
  - 'src/graphql/directives/length.ts':
      noPluck: true

And my custom directive code for length looks like this:
import {gql, UserInputError, SchemaDirectiveVisitor} from 'apollo-server-express';
import {
  GraphQLInputField,
  GraphQLNonNull,
  GraphQLScalarType,
  isWrappingType,
  isNamedType,
} from 'graphql';
import {Kind} from 'graphql/language';

export const lengthTypeDef = gql`
  directive @length(min: Int, max: Int) on INPUT_FIELD_DEFINITION
`;

const validate = (value: string, args: {min: number; max?: number}): void => {
  const {min, max} = args;
  const lengthValue = value.length;

  if (max && lengthValue > max) {
    throw new UserInputError(`Password can't have more than ${max} characters`);
  }

  if (lengthValue < min) {
    throw new UserInputError(`Password must be ${min} characters or more`);
  }
};

interface LengthTypeArgs {
  min: number;
  max?: number;
}

export class LengthType extends GraphQLScalarType {
  constructor(type: GraphQLScalarType, args: LengthTypeArgs) {
    super({
      name: `LengthMin${args.min}${args.max ? `'Max' ${args.max}` : ''}`,
      parseValue: (value) => {
        validate(value, args);

        return type.parseValue(value);
      },
      serialize: (value) => type.serialize(value),
      parseLiteral: (ast) => {
        if (ast.kind === Kind.STRING) {
          validate(ast.value, args);
        }

        return type.parseLiteral(ast, {});
      },
    });
  }
}

class LengthDirective extends SchemaDirectiveVisitor {
  visitInputFieldDefinition(field: GraphQLInputField): void {
    this.wrapType(field);
  }

  wrapType(field: GraphQLInputField): void {
    if (field.type instanceof GraphQLNonNull && field.type.ofType instanceof GraphQLScalarType) {
      field.type = new GraphQLNonNull(
        new LengthType(field.type.ofType, this.args as LengthTypeArgs),
      );
    } else if (field.type instanceof GraphQLScalarType) {
      field.type = new LengthType(field.type, this.args as LengthTypeArgs);
    } else {
      throw new Error(`Not a scalar type: ${field.type}`);
    }

    const typeMap = this.schema.getTypeMap();
    let {type} = field;

    if (isWrappingType(type)) {
      type = type.ofType;
    }

    if (isNamedType(type)) {
      typeMap[type.name] = type;
    }
  }
}

export default LengthDirective;

Any ideas??

For the specific error you got, I think you need require field set because of TS. See: https://graphql-code-generator.com/docs/getting-started/require-field#typescript-support

Awesome thanks Dotan! Really appreciate the help. I'll give this a shot.

I think this issue is not solved and should be reopened.
I had the same problem with the package graphql-constraint-directive
E.g. for minimal input for a hello world query:
type Query {
  hello(name: String! @constraint(minLength: 3)): String!
}

I get  the custom scalar in my schema:
type Query {
  hello(name: name_String_NotNull_minLength_3!): String!
}

This causes the generator fail for my FE query
query Hello($name: String!) {
  hello(name: $name)
}

due to the mismatch of scalar:
Error 0: GraphQLDocumentError: Variable "$name" of type "String!" used in position expecting type "nameOrIco_String_NotNull_minLength_3!".

So my current solution is to define the scalar explicitly in the config to map it to string.
overwrite: true
schema: ${API_URL}/graphql
documents: 'src/graphql/**/*.graphql'
generates:
  src/generated/graphqlClient.ts:
    noPluck: true
    config:
      strictScalars: true
      scalars:
        Date: number
        nameOrIco_String_NotNull_minLength_3: string // HERE
    plugins:
      - 'typescript'
      - 'typescript-operations'
      - 'typescript-react-apollo'

I should not need to do such manual step...

I think this issue is not solved and should be reopened.
I had the same problem with the package graphql-constraint-directive
E.g. for minimal input for a hello world query:
type Query {
  hello(name: String! @constraint(minLength: 3)): String!
}

I get the custom scalar in my schema:
type Query {
  hello(name: name_String_NotNull_minLength_3!): String!
}

This causes the generator fail for my FE query
query Hello($name: String!) {
  hello(name: $name)
}

due to the mismatch of scalar:
Error 0: GraphQLDocumentError: Variable "$name" of type "String!" used in position expecting type "name_String_NotNull_minLength_3!".

So my current solution is to define the scalar explicitly in the config to map it to string.
overwrite: true
schema: ${API_URL}/graphql
documents: 'src/graphql/**/*.graphql'
generates:
  src/generated/graphqlClient.ts:
    config:
      strictScalars: true
      scalars:
        Date: number
        nameOrIco_String_NotNull_minLength_3: string // HERE
    plugins:
      - 'typescript'
      - 'typescript-operations'
      - 'typescript-react-apollo'

I should not need to do such manual step...

@MiroslavPetrik
I'm having the same issue - does adding this line
nameOrIco_String_NotNull_minLength_3: string // HERE

in the codegen config  allow you to keep your graphql query documents as
query Hello($name: String!) {
  hello(name: $name)
}

That is not currently my experience, I haven't been able to find a workaround yet


[DEV-1399] exchange history sync job

DEV-1386 add exchangeTx entity

DEV-1399 exchange history sync

DEV-1399 change exchange entity cols

DEV-1399 add import

DEV-1399 Refactoring

DEV-1399 fix service

DEV-1399 rename mapper

DEV-1399 Refactoring 2

Release Checklist
Pre-Release

[ ] Check migrations

No database related infos (sqldb-xxx)
Impact on GS (new/removed columns)

[ ] Check for linter errors (in PR)
[ ] Test basic user operations

Login/logout
Registration
Update user data
Create/delete payment routes

Post-Release

Test basic user operations
Monitor application insights log

Disable exchangeTx in prd env


Heartbeat padring example

This change adds a minimal example demonstrating how to use asictopflow to stitch macros together. There are two build scripts: one generates floorplans using the Python API, and one uses pre-built floorplan files which are committed in the example directory.
Leaving this as a draft so that we can address a couple of points:

Should we get the sky130 I/O and oh padring files from directories under third_party/, instead of placing them in the example directory? I couldn't find all of the required sky130 sources in our current submodules, and our oh submodule seems to be incompatible with the version used in the zerosoc repository.
I'd like to add a CI test for asictopflow using this example, but we'll need to merge #951 before that will pass.

Commit 0010262 contains only the new example files, if the padring/io commits are distracting.

Very cool.  We should defininitely use the original versions and not copy in versions. If there are problems in oh/skywater let's fix them.

Like we discussed, I moved the I/O files out of the example directory by updating the oh submodule and creating a new sky130io directory under third_party/pdks/. For now, I followed the zerosoc directory structure and put the wrapper files under the same sky130io/io directory as the LEF/GDS/etc files. But I would be open to moving some of the Verilog sources if that would make more sense.
I also added daily CI tests for the build.py and floorplan_build.py scripts, so I think this example is ready for review now.

Like we discussed today, I dropped the prim_sky130_clock_gating.v file, and the build scripts still work. I think this is ready to merge now.

This looks great! Thanks for going through the refactoring rounds to save duplication of files.


[SUPPORT] Async compaction & ingestion performance

Tips before filing an issue

Have you gone through our FAQs?

Join the mailing list to engage in conversations and get faster support at<EMAIL_ADDRESS>

If you have triaged this as a bug, then file an issue directly.

Describe the problem you faced
I have a spark structured streaming job writing to MoR in S3. Based on the docs here https://hudi.apache.org/docs/next/compaction#spark-structured-streaming , I have set the properties for async compaction. As per my understanding, the compaction runs asynchronously so that ingestion also takes place in parallel. But what I observed is that the spark assigns all the resources to the compaction job and only when it is finished, it continues with the ingestion even though both the jobs are running in parallel. Is there something like --delta-sync-scheduling-weight", "--compact-scheduling-weight", ""--delta-sync-scheduling-minshare", and "--compact-scheduling-minshare" for spark structured streaming for ingestion and compaction to run in parallel with resource allocation ?
To Reproduce
Steps to reproduce the behavior:

Expected behavior
I expect compaction and ingestion is happening in parallel
Environment Description

Hudi version : 0.13.0

Spark version : 3.1.2

Hive version :

Hadoop version :

Storage (HDFS/S3/GCS..) : S3

Running on Docker? (yes/no) : on spark operator on k8s

Here is the screenshot of the micro batches for the spark structured streaming job. Normally each batch takes 4-6 mins. But the batches immediately following compaction is taking some time.

Time taken for a normal batch = 206

Batch=207
Here you can see the last job 2961 is HoodieCompactionPlanGenerator which is adding 8.6 mins overhead to this batch.

Batch=208
Here you can see it starts with job 2963 but 2964-2972 is for compaction and you can see it continues with 2973 only after compaction jobs are finished even though it runs on a different thread(see below pic). And time taken for different stages like Load base files, Building workload profile and getting small files has drastically increased. Refer batch 206 for normal time taken.

compaction jobs (2964-2972)

Is there something that can be done to improve this performance?
Additional context
using hudi-spark3.1-bundle_2.12-0.13.0.jar along with hadoop-aws_3.1.2.jar and aws-java-sdk-bundle_1.11.271.jar.
job configs
"hoodie.table.name" -> tableName,
"path" -> "s3a://path/Hudi/".concat(tableName),
"hoodie.datasource.write.table.name" -> tableName,
"hoodie.datasource.write.table.type" -> MERGE_ON_READ,
"hoodie.datasource.write.operation" -> "upsert",
"hoodie.datasource.write.recordkey.field" -> "col5,col6,col7",
"hoodie.datasource.write.partitionpath.field" -> "col1,col2,col3,col4",
"hoodie.datasource.write.keygenerator.class" -> "org.apache.hudi.keygen.ComplexKeyGenerator",
"hoodie.datasource.write.hive_style_partitioning" -> "true",
//Cleaning options
"hoodie.clean.automatic" -> "true",
"hoodie.clean.max.commits" -> "3",
//"hoodie.clean.async" -> "true",
//hive_sync_options
"hoodie.datasource.hive_sync.partition_fields" -> "col1,col2,col3,col4",
"hoodie.datasource.hive_sync.database" -> dbName,
"hoodie.datasource.hive_sync.table" -> tableName,
"hoodie.datasource.hive_sync.enable" -> "true",
"hoodie.datasource.hive_sync.mode" -> "hms",
"hoodie.datasource.hive_sync.partition_extractor_class" -> "org.apache.hudi.hive.MultiPartKeysValueExtractor",
"hoodie.upsert.shuffle.parallelism" -> "200",
"hoodie.insert.shuffle.parallelism" -> "200",
"hoodie.datasource.compaction.async.enable" -> true,
"hoodie.compact.inline.max.delta.commits" -> "10",
"hoodie.index.type" -> "BLOOM"
Stacktrace
Add the stacktrace of the error.

Update: As per the suggestion given here in slack forum https://apache-hudi.slack.com/archives/C4D716NPQ/p1679068718111579?thread_ts=1678987926.576359&cid=C4D716NPQ (https://medium.com/@simpsons/efficient-resource-allocation-for-async-table-services-in-hudi-124375d58dc), I tried setting  the spark_scheduler_allocation_file. Still I see not much improvement in performance even though it goes to seperate pools.
The below job looking for files to compact goes to the sparkdatasourcewriter which is taking ~10 mins which increases the time of the streaming query

The other jobs go to the hoodiecompact pool

But still if you see the overall time taken for the queries remain as the same as above.

Hi, is there some insights on this?

@haripriyarhp Did you get any workaround for this? I have just onboarded the Hudi deltastreamer pipeline in production and I am also observing that during compaction no writes are happening.


fix: add codeowners file for openyurt

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:
/kind bug
/kind documentation
/kind enhancement
/kind good-first-issue
/kind feature
/kind question
/kind design
/sig ai
/sig iot
/sig network
/sig storage

/kind documentation
What this PR does / why we need it:
add codeowners file for enforcing Access Control Rules to secure the code base against attacks.
In the first step, I add Openyurt-Maintainers team as CODEOWNER for the whole repository.
and we will keep improve the CODEOWNER assignment during incubation.
Which issue(s) this PR fixes:

Fixes #
Special notes for your reviewer:

Does this PR introduce a user-facing change?

other Note

#2224 https://github.com/openyurtio/openyurt/issues/2223

/LGTM


Check for floor price existence in offers endpoint

Take this url for example.
You could see, that not all NFTs are listed and that breaks the function. This would fix it.
A workaround is to supply a URL with the buy_now filter enabled, like in this url.

I added commit#e15fb42 to this PR as well.
I am building a listing bot, and would need to have the displayImageUrl returned in the /offers endpoint as well. I think this is a useful feature to have

Added another commit regarding using the sort, see #2fc3143

hey @robertistok, great changes! Am reviewing...
Just one question, you provided two times the same link in your first comment, did you mean:
url1 with no "buy_now" filter enabled:
https://opensea.io/collection/boredapeyachtclub?search[sortAscending]=true&search[sortBy]=PRICE&search[stringTraits][0][name]=Background&search[stringTraits][0][values][0]=Purple&search[stringTraits][1][name]=Earring&search[stringTraits][1][values][0]=Silver Hoop&search[stringTraits][2][name]=Eyes&search[stringTraits][2][values][0]=Bloodshot
url2 with "buy_now" filter enabled:
https://opensea.io/collection/boredapeyachtclub?search[sortAscending]=true&search[sortBy]=PRICE&search[stringTraits][0][name]=Background&search[stringTraits][0][values][0]=Purple&search[stringTraits][1][name]=Earring&search[stringTraits][1][values][0]=Silver Hoop&search[stringTraits][2][name]=Eyes&search[stringTraits][2][values][0]=Bloodshot&search[toggles][0]=BUY_NOW
I can confirm that url1 breaks the offersByUrl function, but it still is broken in your update, or am I missing something? 🤔
But the improvements are great, so will merge, but can you check if the url1 bug also persists in your update? Just to be sure its not some weird behavior on my machine.
To fix the bug I would suggest to simply make the "BUY_NOW" mandatory and append it to the URL if it is missing:
const mandatoryQueryParam = "search[toggles][0]=BUY_NOW";
if (!url.includes(mandatoryQueryParam) {
  const joinChar = url.includes("?") ? "&" : "?";
  url += `${url}${joinChar}${mandatoryQueryParam}`;
}

Thanks for merging!
I think it makes sense to have my solution, as that removes the burden from the user. I can also use this function to just simply get a list of NFTs with a specific trait. Not all of them will be on the market, so it's good to take care of that case


Import key and cert

This addresses docker#731 by allowing the import of root certs in addition to root keys,  using the command-line argument --rootcert.  It builds on top of the pre-existing pull request at https://github.com/docker/notary/pull/801
This allows us to ensure that we only ever pull values from Notary that have been pushed by  trusted clients (who had access to a secret trust-pinning private key).  (See worked example below).
Synopsis:
notary init [--rootkey PRIVATE_KEY] [--rootcert CERT] GUN

Behavior:
  --rootcert   | --rootkey    |
   specified?  |  specified?  |
               |              |
---------------+--------------+-----------------------------------------------------
               |              |
      NO       |     NO       |    Both key and cert are generated by Notary
               |              |               (current behavior)
               |              |
---------------+--------------+-----------------------------------------------------
               |              |
      NO       |     YES      |    The key is imported, and the cert is generated
               |              |             by Notary from the key
               |              |
---------------+--------------+-----------------------------------------------------
               |              |
      YES      |     NO       |                   Error
               |              |
---------------+--------------+-----------------------------------------------------
               |              |
               |              |    The private key is compared with the public
               |              |      key of the cert.  If they do not form a
      YES      |     YES      |      valid keypair, an Error is thrown.
               |              |    Otherwise, the key and cert are used to
               |              |      initialize the collection.
               |              |
---------------+--------------+-----------------------------------------------------

Notes:
The PRIVATE_KEY specified as the argument to --rootkey must be encrypted.
If the environment variable NOTARY_DELEGATION_PASSPHRASE is set, its
value will be used as the passphrase to decrypt the key.  Otherwise, the
passphrase will be requested interactively.

Known issues:
The environment variable used to decrypt the private key should be
NOTARY_ROOT_PASSPHRASE rather than
NOTARY_DELEGATION_PASSPHRASE

Example of usage (combined with trust-pinning):
## Generate trust_pinning keypair that will sign all other GUN keypairs
##  the private key will be distributed only to clients authorized to push to Notary.
##  the public key will be distributed to any clients authorized to pull from Notary
> cd /root
> openssl genrsa -out trust_pinning.key 2048
> openssl req -new -sha256 -key trust_pinning.key -out trust_pinning.csr -subj "/C=XX/ST=XX/L=XX/O=XX/OU=XX/CN=XX"
> openssl x509 -req -days 1000 -in trust_pinning.csr -signkey trust_pinning.key -out trust_pinning.crt

## Generate a new child keypair to initialize Notary for this new GUN
###  Sign the cert with the trust_pinning keypair.
> openssl genrsa -aes128 -passout pass:my_passphrase 2048 > /tmp/new_gun.key
> openssl req -sha256 -passin pass:my_passphrase -new -key /tmp/new_gun.key -out /tmp/new_gun.csr -subj '/C=XX/ST=XX/L=XX/O=XX/OU=XX/CN=GUN_FROM_TRUSTED_CLIENT'
> openssl x509 -passin pass:my_passphrase -req -days 1000 -sha256 -in /tmp/new_gun.csr -out /tmp/new_gun.crt -CAkey /root/trust_pinning.key -CA /root/trust_pinning.crt -CAserial /root/trust_pinning.srl -CAcreateserial

## Create a GUN that uses the keypair we've just created, then publish to Notary
> NOTARY_DELEGATION_PASSPHRASE=my_passphrase  \
notary init --rootkey /tmp/new_gun.key --rootcert /tmp/new_gun.crt GUN_FROM_TRUSTED_CLIENT
> echo foo > /tmp/foo
> notary add GUN_FROM_TRUSTED_CLIENT foo /tmp/foo
> NOTARY_DELEGATION_PASSPHRASE=my_passphrase \
notary -s https://notary-server:4443 publish GUN_FROM_TRUSTED_CLIENT

## For comparison, create and publish another GUN that has an automatically generated keypair.
##  This GUN could have been created by an untrusted client that did not have access to the
##   secret trust-pinning key
> NOTARY_ROOT_PASSPHRASE=my_passphrase \
NOTARY_TARGETS_PASSPHRASE=targets \
NOTARY_SNAPSHOT_PASSPHRASE=shapshot \
notary init GUN_FROM_UNTRUSTED_CLIENT
> notary add GUN_FROM_UNTRUSTED_CLIENT foo /tmp/foo
> NOTARY_TARGETS_PASSPHRASE=targets \
NOTARY_SNAPSHOT_PASSPHRASE=shapshot \
notary -s https://notary-server:4443 publish GUN_FROM_UNTRUSTED_CLIENT

## Now set up trust pinning to require that all root certs be signed by the
##  master trust_pinning cert we created earlier
> echo '{ "trust_pinning": { "disable_tofu": "true","ca": { "":"/root/trust_pinning.crt" } } }' > /root/.notary/config.json

## Verify that read is successful on GUN_FROM_TRUSTED_CLIENT
> rm -fr /tmp/empty_dir; mkdir -p /tmp/empty_dir
> notary -s https://notary-server:4443 -d /tmp/empty_dir list GUN_FROM_TRUSTED_CLIENT
  NAME                                DIGEST                                SIZE (BYTES)    ROLE
----------------------------------------------------------------------------------------------------
  foo    b5bb9d8014a0f9b1d61e21e796d78dccdf1352f23cd32812f4850b878ae4944c   4              targets

## Verify that read fails on GUN_FROM_UNTRUSTED_CLIENT, because its root cert violates
##  the trust pinning config we set up earlier.
> rm -fr /tmp/empty_dir; mkdir -p /tmp/empty_dir
> notary -s https://notary-server:4443 -d /tmp/empty_dir list GUN_FROM_UNTRUSTED_CLIENT

* fatal: could not validate the path to a trusted root: unable to match any certificates to trust_pinning config

Can one of the admins verify this patch?

jenkins test this please

note: I plan on carrying this PR this week, and the environment variable issue should be fixed with https://github.com/docker/notary/pull/822 - thank you @dnwake for your help!

Please sign your commits following these rules:
https://github.com/docker/docker/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:
$ git clone -b "import_key_and_cert" git@github.com:dnwake/notary.git somewhere
$ cd somewhere
$ git rebase -i HEAD~3
editor opens
change each 'pick' to 'edit'
save the file and quit
$ git commit --amend -s --no-edit
$ git rebase --continue # and repeat the amend for each commit
$ git push -f

Ammending updates the existing PR. You DO NOT need to open a new one.

Please sign your commits following these rules:
https://github.com/docker/docker/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:
$ git clone -b "import_key_and_cert" git@github.com:dnwake/notary.git somewhere
$ cd somewhere
$ git rebase -i HEAD~3
editor opens
change each 'pick' to 'edit'
save the file and quit
$ git commit --amend -s --no-edit
$ git rebase --continue # and repeat the amend for each commit
$ git push -f

Ammending updates the existing PR. You DO NOT need to open a new one.

@dnwake just checking if you're going to get back to this. There have been a lot of changes so unless you're going to pick it up I'm going to close this and work can start anew in a different PR at some point.

@endophage I intend to get back to it, but haven't had time so far.

This has been superseded by #1144 and #1147


issue in upstream

comment in upstream

comment in upstream

comment in upstream

comment in upstream

comment in upstream

comment in upstream

comment in upstream

comment in upstream

comment in upstream

comment in upstream

comment in upstream

comment in upstream

comment in upstream

y of<EMAIL_ADDRESS>-->

comment in upstream

comment in upstream

comment in upstream

y of https://api.github.com/repos/federatedbookkeeping/github-dxos/issues/comments/2217094857 -->
comment in upstream

comment in upstream

comment in upstream

comment in upstream

comment in upstream

comment in upstream

comment in upstream

comment in upstream

y of<EMAIL_ADDRESS>-->

comment in upstream

y of https://api.github.com/repos/federatedbookkeeping/github-dxos/issues/comments/2217094857 -->
comment in upstream

y of<EMAIL_ADDRESS>-->

comment in upstream

m

comment in upstream

comment in upstream

comment in upstream

y of<EMAIL_ADDRESS>-->

comment in upstream

comment in upstream

y of https://api.github.com/repos/federatedbookkeeping/github-dxos/issues/comments/2217094857 -->
comment in upstream

y of<EMAIL_ADDRESS>-->

comment in upstream

comment in upstream

comment in upstream


When training R-Net, should the input image minus 'pixel_mean'?

We did not do any preprocessing for input images. All input image used to train R-Net have intensities range from 0-255, in BGR order.

Ok, but in many image process cases, the image will minus the 'pixel_mean' before sending to CNN, so have you tried this kind of process?

We did not try this preprocessing step in our experiments. Actually, I think minus it with pixel_mean is not necessary because network can learn this bias by itself.

Ok, well, I would like to have a try. Thank you.


Replying to him should have the same effect as mentioning him

It shouldn't because sometimes people use reply to react to its messages

I think this would be a great Idea, but it should be optional and by default off. Only groupadmins should be able to enable/disable this by a command. Probably you could implement a configurable cooldown, after x replys ignore for time x all replys.


Vertical Stitching issue with Firefox

When generating the document screenshot with Firefox, the browser never scrolls, which causes an image that just repeats the above the fold content.
I've been told that Firefox now has an API to take a full document screenshot instead of a viewport screenshot, which might be the issue if they replaced the API.

It seems like Firefox behaves now different when using saveScreenshot().
Firefox always takes a screenshot of the whole document which makes the whole stitching process useless.
If you are testing on Firefox you can use the following code snippet after initialization of webdrivercss to overwrite the stitching process:
var client = require('webdriverio');

/* ... initialize webdrivercss */

client.addCommand('saveDocumentScreenshot', function(path, callback) {
  client.saveScreenshot(path, callback);
}, true);
*/

Also this screenshotting method delivers much more stable results than before.


Add webmoney payment option

This pull request adds the Webmoney payment option to Spree.
A few notes:

Multi-card transactions in Komoju require PATCH instead of POST'ing to a resource. ActiveMerchant supports PATCH in the latest release, however, Spree 3.0.4 version locks ActiveMerchant @ 1.47.0. Because of this I've created a extension to connection.rb which is only required with ActiveMerchant == '1.47.0' which adds :patch
I ended up using Javascript instead of Coffescript. For some reason .js.coffee files were not being recognised. I think this is because assets are compiled in the vendor directory rather that into app/assets.

["camirb(main):001:0> ["camelmasa", "shioyama"].sample
=> "camelmasa"

@camelmasa Could you review :bow: :pray:

I checked It works that :smiley:

I'll add translation for japanese after merged it.

I needed to select WebMoney radio button everytime on payment page when insufficient funds error.
If possible, I think customers prefers that the radio button is selected WebMoney when insufficient funds error :wink:

@camelmasa Yes, will need some javascript to select the payment option again. This is not supported by Spree.

@rramsden no problem :+1:

@camelmasa I've namespaced it under Spree which I think should be fine. SpreeKomoju defines the engine, extensions, and exceptions.

@rramsden LGTM :sta


Adds separate itemized schemas for gen3

This PR:

separates itemized yaml schema for gen3 in schemas/gen3
bmeg schemas moved to schemas/bmeg
BodyStructure and Encounter added
Gen3 edges from Observation limited to Patient, ResearchStudy and Specimen

See https://github.com/bmeg/iceberg-schema-tools/pull/5

refer to https://github.com/bmeg/iceberg-schema-tools/pull/5

Ok LGTM now


Auto rest

Adding initial version of sdk for Azure RemoteApp

Can one of the admins verify this patch?

Hi @calexan, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!

It looks like you're working at Microsoft (calebal). If you're full-time, we DON'T require a contribution license agreement.

If you are a vendor, DO please sign the electronic contribution license agreement. It will take 2 minutes and there's no faxing! https://cla.azure.com.

TTYL, AZPRBOT;

@azuresdkci test this please

@azuresdkci add to whitelist

I've disabled non-passing tests for now and opened a bug to track them for fixing in the next few weeks. Builds successfully on my local machine with command "msbuild build.proj /t:build;package;test /p:scope=ResourceManagement\RemoteApp"


Helm chart to deploy gcs

I've been looking into building a helm chart to deploy gcs.
My hope is to break the dependency on Ansible so it's easier to get it running on clusters that aren't started with the kubespray templates in this repo. That should make it easier for people to try out on their personal clusters.
I will update this issue as things progress. It anyone else is interested, I'm happy to collaborate.

I might be able to help test.  Is this going to possibly run without the need for a first class PV? I’d love to have gluster replicated across ephemeral storage for persistent but not mission critical data.

@jayunit100 GD2 is currently consuming raw devices from /dev. If you don't want to use actual devices, you may be able to make loop devices on your host and expose those to the gluster pods for testing.


Get paired/bonded devices

Expose API method to retreive paired/bonded devices in iOS and Android.
List GetSystemPairedDevices();

Only relevant if called on android. Ios has no way of retrieving bonded devices.
1.1.0-beta5


ppwater: Watch dreamworkphotography.com

ppwater requests the watch of the watch_keyword dreamworkphotography\.com. See the MS search here and the Stack Exchange search in text, in URLs, and in code.

dreamworkphotography\.com has been seen in 1 true positive, 0 false positives, and 0 NAAs.

Approved by Mast in Charcoal HQ


reset position setpoints once altitude/position condition is reached

Currently if one is in the manual position control mode and accelerates upwards (or horizontally), the vehicle skips the altitude controller until the velocity is below some threshold. The position set-point reset occurs before the vehicle's velocity is below the threshold, which leads to an overshoot.
Resetting the position set-point once the vehicle is below that threshold leads to a smoother transition to position control without overshoot, but undergoes a breaking distance.

Yes I totally agree.
We have to test for which hold_max parameters this works best on a real world model but I presume defaults are already better than without this fix.
nitpick: is there a more readable was for magnitude of the 1x2 vector?

@MaEtUgR Can you use the Github review function to approve? Can you flight test today?
@Stifael Should this go into the current release?

I think it can go into current release once it is flight tested. in @MaEtUgR  and my opinion, it is more intuitive to have a break distance once releasing the throttle stick instead of having an overshoot.

@Stifael @MaEtUgR I don't see an issue with this PR, however, I don't quite see the issue which you have been describing. The reason why the position and altitude setpoints have not been reset at the location where you implemented it now is because they are always being reset if there is no position/altitude control lock (flag _pos_hold_engaged).
The only difference I see now is that you reset the setpoints with the most recent position value and not with the one from the last iteration which is perfectly fine.
Am I missing something?
In general I would prefer setting a fixed position setpoint after the user lets go of the sticks and to compute that setpoint based on the current velocity of the vehicle and other limiting factors. Then we also wouldn't need this ugly change between velocity and position control anymore.
Not that I propose this for the release but how do you guys see this in general?

@tumbili: you dont miss anything.
The reason why we added the reset once the vehicle is below the threshold is because then the vehicle does much less of an overshoot in terms of returning to the position that was set at the previous iteration. This is best apparent when flying with full speed upward (to see it even better, increase the max velocity upwards): the vehicle accelerates upwards and once the the user lets go the stick, the continues to accelerates upwards and then return to the last position reset. However, I would expect that the vehicle does not do that.
You are right, it would even be better to compute the position from the velocity, but for now this change already makes a difference, if the goal is to have a smooth transition from velocity to position control.

@Stifael Cool, thanks for the clarification.

@Stifael Can you install the pre-commit style checker hook? Please also keep regularly checking back on your PRs, thanks!

@julianoes Can you review again?


"Update actual value" function not working

Affects: Result form Actual value field.
Potentially relevant or irrelevant:

I've got language set to French.
I'm entering values between zero and one.

Issue
When I click "Update actual value", the old value cleared out but it was not updated with the current value.

@camgnostic Found an edge case:

Find or create a saved indicator that doesn't have values for at least one disaggregation.
Enter some disaggregated values that do NOT add up to the total.
Submit. You'll see the warning with button to update actual value.
Hit "Reset".

Here's what I'm seeing:

As expected, it empties out the disaggregated values you just added.

But the "correction" in the sum row remains. My expectation is that the message would go away, as no longer relevant.

If I try to submit again, the "correction" stays there, plus I get a "One or more fields needs attention" warnings at the top... I would not expect this message to appear, since disaggregated values are not required fields...

@jennyhavah  I've addressed the behavior in the above comment but found another bug with medium LOE and wanted to see if it was a release blocker or a nice to have:

Open a result that has disaggregated values OR actual value that is a truncated decimal (like 0.1 or 4.7 - the final zero is removed)
Hit "reset"
Notice that the trailing zeros have returned.

This is due to how HTML handles form resets, and while it's fixable it's medium LOE so I wanted to get a priority for this behavior (or find out if it's a bug at all in your eyes)

Above comment broken out and moved to #2256

@camgnostic Moved back to Failed until the update is merged. Will retest once it's available on QA.

Edge case fixed. Reset clears the form and warning / "reconcile these numbers" functions as expected.


Modal issues

Have a problem, I used to turn up for a slider widget:
When pressing on button first, slider Widgets do not appear
Then close the pop up and open the back, slider widgets appear.
This is my description video : https://drive.google.com/file/d/1gUMvG1eQoUnNRyZ74XlH3hHCY_IMAX5O/view?usp=sharing

I'm 99% sure this is your issue: https://github.com/angular-slider/angularjs-slider#my-slider-is-not-rendered-correctly-on-load 🙂


Installing errors on Mac OS X El Capitan

My npm-debug.log.
index.js:
var Git = require("nodegit");

And when i tried node index.js i see:
module.js:338
    throw err;
    ^

Error: Cannot find module 'nodegit'
    at Function.Module._resolveFilename (module.js:336:15)
    at Function.Module._load (module.js:286:25)
    at Module.require (module.js:365:17)
    at require (module.js:384:17)
    at Object.<anonymous> (/Users/arusakov/WebstormProjects/distbranch/index.js:1:73)
    at Module._compile (module.js:434:26)
    at Object.Module._extensions..js (module.js:452:10)
    at Module.load (module.js:355:32)
    at Function.Module._load (module.js:310:12)
    at Function.Module.runMain (module.js:475:10)

Did you npm install nodegit?

@thgaskell yes

It tries to compile the module from scratch and fails. Do you have Xcode installed?

We do have a prebuilt binary published, I'm wondering what version of Node?

@saper I have installed XCode.
@tbranyen node.js 4.1.1

Maybe we need to publish a binary for El Capitan?

Yeah, I haven't done that yet

I just updated to El Capitan and what's going on is that Apple moved away from OpenSSL in lieu of their own home-rolled TLS implementation. Looking into this further.

I just published binaries. Can you guys try again please?

@johnhaley81 Installation completed without errors, it's perfect. Thank you!

 Glad it's working for you.


Implement State-Persistence for Human Evaluation

Issue #1198

@bekossy is this ready ?

@bekossy is this ready ?

@mmabrouk Yes it is


Improvement/break 8 event add

Today what we want is to introduce a new alert when prometheus can't be queried , introducing a new state alters the existing metrics as when these errors happen the state is normally nominal. Introducing the cbError attribute's goal is to let backbeat know an error occured without altering the state / metrics.
Issue: BREAK-8

Hello benzekrimaha,
My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Available options

name
description
privileged
authored

/after_pull_request
Wait for the given pull request id to be merged before continuing with the current one.

/bypass_author_approval
Bypass the pull request author's approval
:star:

/bypass_build_status
Bypass the build and test status
:star:

/bypass_commit_size
Bypass the check on the size of the changeset TBA
:star:

/bypass_incompatible_branch
Bypass the check on the source branch prefix
:star:

/bypass_jira_check
Bypass the Jira issue check
:star:

/bypass_peer_approval
Bypass the pull request peers' approval
:star:

/bypass_leader_approval
Bypass the pull request leaders' approval
:star:

/approve
Instruct Bert-E that the author has approved the pull request.

:writing_hand:

/create_pull_requests
Allow the creation of integration pull requests.

/create_integration_branches
Allow the creation of integration branches.

/no_octopus
Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead

/unanimity
Change review acceptance criteria from one reviewer at least to all reviewers

/wait
Instruct Bert-E not to run until further notice.

Available commands

name
description
privileged

/help
Print Bert-E's manual in the pull request.

/status
Print Bert-E's current status in the pull request TBA

/clear
Remove all comments from Bert-E from the history TBA

/retry
Re-start a fresh build TBA

/build
Re-start a fresh build TBA

/force_reset
Delete integration branches & pull requests, and restart merge process from the beginning.

/reset
Try to remove integration branches unless there are commits on them which do not appear on the source branch.

Status report is not available.

Incorrect fix version
The Fix Version/s in issue BREAK-8 contains:

None

Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:

1.0.3

Please check the Fix Version/s of BREAK-8, or the target
branch of this pull request.

Waiting for approval
The following approvals are needed before I can proceed with the merge:

the author

one peer

I have successfully merged the changeset of this pull request
into targetted development branches:

:heavy_check_mark: development/1.0

Please check the status of the associated issue BREAK-8.
Goodbye benzekrimaha.
The following options are set: approve


Include several self-hosted github action runners

Currently Conocer y Triunfar is being deployed thanks to ubuntu-latest machines hosted by github and a single self-hosted machine which is actually the same one where the project runs publicly.
More self-hosted machines would decrease costs in time and monthly hour limit.
Since the runners can't run different tasks on parallel, almost as many processes as microservices deployed would be needed.

Done


Forward ClassEntry in create_object

See #138
The ce should be taken from the create_object. From that point on, everything else can carry on just about normal. the only thing that needs to change is the sanity check to make sure the ClassEntry for the object passed to the object handlers is a child as well as the direct class.

Ping @danog :)


extract SDP_WRITE_ADDR (_fcfb_origin) and SDP_JUMP_ADDR (_ivt_origin) from linker file

use sed to extract SDP_WRITE_ADDR (_fcfb_origin) and SDP_JUMP_ADDR (_ivt_origin) from linker file.
This helps to reduce the amount of manual work and magic number should we make changes to linker file.

Sorry for the delayed response.  There are some issues with this update.  The image runs after loaded but does not run from flash (RT1010 EVK).  Let me try to clean this up.  This PR should probably be reverted.

I think it would also be good to switch to spsdk (https://pypi.org/project/spsdk/) for loading, then we do not need to keep the sdphost binaries.  They can load it separately like pyocd.

Sorry for the delayed response. There are some issues with this update. The image runs after loaded but does not run from flash (RT1010 EVK). Let me try to clean this up. This PR should probably be reverted.

I tested with rt1010 evk and seems to work well. This PR essentially does not make any changes in the compile binary. It only add the sed script to extract the _fcfb_origin and _ivt_origin from the linker file. Which OS you are using, I haven't tested on windows, maybe adding this line to makefile to check if sed does its work correctly
$(error Write: $(SDP_WRITE_ADDR) Jump: $(SDP_JUMP_ADDR) )

I think it would also be good to switch to spsdk (https://pypi.org/project/spsdk/) for loading, then we do not need to keep the sdphost binaries. They can load it separately like pyocd.

Yeah, I agree, we could switch to spsdk in the future. If possible, please make an PR for it. I could do it as well if you don't have time.

I forgot that the RT1010 does not fit with debug logs enabled.  I think that was my problem.  It is working for me now.  I will submit a pull request with the SPSDK update.  It is mostly documentation, let me know if anything is unclear.

thank you for confirmation :)


Docs backport master to 16.x.x

See https://github.com/plone/volto/pull/3930#pullrequestreview-1187124476

Had to resolve conflicts and backport more changes from master. One more round of review, please?

Closing in favor of #3951 which has no conflicts and the better changelog entry.


NumericField: Hold spin buttons to keep increasing/decreasing

Feature request type
Enhance component
Component name
MudNumericField
Is your feature request related to a problem?
Adjusting a value is awkward on mobile because you have to keep tapping the spin buttons.
Describe the solution you'd like
If you hold the spin buttons the number should keep changing.
Have you seen this feature anywhere else?
https://www.w3schools.com/tags/tryit.asp?filename=tryhtml5_input_step
Describe alternatives you've considered
No response
Pull Request

[ ] I would like to do a Pull Request

Code of Conduct

[X] I agree to follow this project's Code of Conduct

@henon @ScarletKuro @igotinfected
Do you think this is a good UX feature for mobile users especially?
Would the API that enables holding a button be internal, regarding #7205?
https://github.com/MudBlazor/MudBlazor/assets/7112040/be920940-d093-47c3-a489-d5265157987b

Since the field is of type numeric, on mobile devices a numeric keyboard should show up (it does for me at least):

I think I'd personally prefer typing in a number manually versus using the up and down arrows, but I don't see anything that speaks against adding that feature. Even on mobile it should be usable if the field is not Dense.
Don't know how it is done today but I imagine you'd just need to hook up the mousedown event to the  up/down arrows?

Closing due to the lack of standard way of implementing it. Trying to get it aligned with all platforms will take too much time.


SCALAR_OPT_AS_EXPR

#906 ff.
It should either be scalar_as_exp or
scalar_opt_as-exp -> '$empty'
is missing.

Please provide a parser crash log and/or example SQL

This is either a confusing name or the empty-clause is missing.

Looking at the parsing file I suppose that
scalar_opt_as_exp
should be renamed to
scalar_as_exp
since for example:
opt_else -> '$empty'                                                                            : {}.
opt_else -> ELSE scalar_opt_as_exp                                                              : '$2'.

would not make much sense if scalar_opt_as_exp contains an empty-clause too.


localize metrics page's h2 title

[x] Have you followed the contributing guidelines?
[x] Have you explained what your changes do, and why they add value to the Guides?
[x] Have you enabled GitHub Pages Previews by pressing Enable GitHub Pages on the right sidebar to trigger a pages build for this PR?

Please note: we will close your PR without comment if you do not check the boxes above and provide ALL requested information.

localize /zh-cn/metrics metrics page's h2 title.

Thanks again @codinggirl!


Dropdown button takes a long time to load one lakh items

Hi Team,
I have implemented a dropdown button with one lakh items. It is taking a long time to load in the view. App gets stopped until the process is done.
Steps to Reproduce

Run the below sample.
Tap the Click to main page button
You could see the issue.

Expected results: Dropdown button should be loaded without any delay
Actual results: Taking a long time to load the dropdown button.

Code sample
import 'package:flutter/material.dart';

void main() {
  runApp(const MyApp());
}

class MyApp extends StatelessWidget {
  const MyApp({Key? key}) : super(key: key);

  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      title: 'Flutter Demo',
      theme: ThemeData(
        primarySwatch: Colors.blue,
      ),
      home: const MyHomePage(),
    );
  }
}

class MyHomePage extends StatelessWidget {
  const MyHomePage({Key? key}) : super(key: key);

  @override
  Widget build(BuildContext context) {
    return Scaffold(
      appBar: AppBar(),
      body: Center(
          child: TextButton(
        onPressed: () {
          Navigator.push(context,
              MaterialPageRoute(builder: (context) => MyDropdownButton()));
        },
        child: Text('Click to main page'),
      )),
    );
  }
}

class MyDropdownButton extends StatefulWidget {
  const MyDropdownButton({Key? key}) : super(key: key);

  @override
  State<MyDropdownButton> createState() => _MyDropdownButtonState();
}

class _MyDropdownButtonState extends State<MyDropdownButton> {
  int number = 0;

  @override
  Widget build(BuildContext context) {
    return Scaffold(
      appBar: AppBar(),
      body: Center(
        child: SizedBox(
          width: 130,
          height: 46,
          child: DropdownButtonFormField<int>(
            isExpanded: true,
            value: number,
            items: List<DropdownMenuItem<int>>.generate(
                100000,
                (index) => DropdownMenuItem<int>(
                    value: index, child: Text('Item $index'))),
            onChanged: (value) {
              number = value!;
              setState(() {});
            },
          ),
        ),
      ),
    );
  }
}

Logs

[√] Flutter (Channel stable, 3.0.5, on Microsoft Windows [Version 10.0.19044.1889], locale en-US)
    • Flutter version 3.0.5 at C:\Flutter\src\flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision f1875d570e (6 weeks ago), 2022-07-13 11:24:16 -0700
    • Engine revision e85ea0e79c
    • Dart version 2.17.6
    • DevTools version 2.12.2

Checking Android licenses is taking an unexpectedly long time...[√] Android toolchain - develop for Android devices (Android SDK version 32.1.0-rc1)
    • Android SDK at C:\Users\AshokKuvaraja\AppData\Local\Android\sdk
    • Platform android-32, build-tools 32.1.0-rc1
    • Java binary at: C:\Program Files\Android\Android Studio\jre\bin\java
    • Java version OpenJDK Runtime Environment (build 11.0.11+9-b60-7590822)
    • All Android licenses accepted.

[√] Chrome - develop for the web
    • Chrome at C:\Program Files\Google\Chrome\Application\chrome.exe

[√] Visual Studio - develop for Windows (Visual Studio Professional 2022 17.4.0 Preview 1.0)
    • Visual Studio at C:\Program Files\Microsoft Visual Studio\2022\Preview
    • Visual Studio Professional 2022 version 17.4.32804.182
    • The current Visual Studio installation is a pre-release version. It may not be supported by Flutter yet.
    • Windows 10 SDK version 10.0.22000.0

[√] Android Studio (version 2021.1)
    • Android Studio at C:\Program Files\Android\Android Studio
    • Flutter plugin can be installed from:
       https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
       https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.11+9-b60-7590822)

[√] VS Code (version 1.70.2)
    • VS Code at C:\Users\AshokKuvaraja\AppData\Local\Programs\Microsoft VS Code
    • Flutter extension version 3.46.0

[√] VS Code, 64-bit edition
    • VS Code at C:\Program Files\Microsoft VS Code
    • Flutter extension version 3.46.0

[√] Connected device (4 available)
    • sdk gphone x86 64 arm64 (mobile) • emulator-5554 • android-x64    • Android 11 (API 30) (emulator)
    • Windows (desktop)                • windows       • windows-x64    • Microsoft Windows [Version
      10.0.19044.1889]
    • Chrome (web)                     • chrome        • web-javascript • Google Chrome 104.0.5112.81
    • Edge (web)                       • edge          • web-javascript • Microsoft Edge 104.0.1293.63

Hello @ashok-kuvaraja. A DropDownButton is not meant to hold that many items. Why you're getting this performance issue is because it's trying to build all 100,000 items at once rather than only what is visible. In a case like this, it's better to implement it using a ListView.builder() and/or some searching logic for better UX.
Since this is working as expected, I am closing this issue. Thank you.


Seed gets set to "-1" if I queue multiple generations

If I wait until the previous generation is finished the random seed works fine, but if I press "Queue Prompt" multiple times or use "Batch Count" the seed value get's stuck at "-1" instead of creating a new seed, resulting in very fast generations of the same image from cache, as the seed is "-1" for all those images.

You can even trigger it with a very simple workflow like that, if you hammer the "Queue Prompt" button a few times after setting the "Batch Count" to a high number (to make sure it isn't finished before you press the button again):

Same problem for me, queue multiple time reset the -1 value to a fixed seed..

Same problem for me.
It appeared this week for me, I never had this problem before.

I'm assuming everyone here also has cg-use-anywhere installed (even if not used in the workflow?
I couldn't reproduce the "-1" sticking, but could reproduce a "real" seed sticking. I've rewrote the seed and changed some of the timing to better handle the changing from a seed back and forth. Please try now and let me know if this has fixed it!

I've tested with @JPS-GER's workflow from above (500x at only seed & console nodes) and get 500 random seeds. Going to close this. Let me know if you're still seeing anything odd (for instance, it could very well happen from an another extension that I don't have).

I still have this problem. When set to -1 it will mysteriously get stuck on a fixed seed... all the time. It doesn't take more than a few generations for this to happen. When using "Auto-Queue" I get a handful of unique images and then the same image over and over again.


PLUGIN-191: Sanitized output name when special characters are present

BigQuery Multisink fails on table names with special characters
JIRA Ticket: https://cdap.atlassian.net/browse/PLUGIN-191

lgtm. please squash commits

Commits squashed.

/gcbrun


how to get the audio from vido with the great project?

hi,dear,
glad to see the wonderful project,
I just wanna get the audio from the video,
how to deal with it ?
thx

You can use .audio property of input stream Ref : doc
Example:
input = ffmpeg.input('input.mp4')
audio = input.audio
out = ffmpeg.output(audio, 'output.mp4')


dAcTbox_c WIP

This is at 92% text, all data matches, 3 functions have very minor issues, dAcTbox_c::checkForLinkBonk() is floating point hell


Added login method to python client

Added login method to the python client to authenticate with the skydive
analyzer.
The authentication should be performed before the main loop is started.
The method returns a boolean specifying if the login succeeded. In case
it did, a cookie is kept and is sent with all the future requests.
Future work: detect cases in which the authentication is expired, and
raise a notification to the user or re-authenticate automatically.
Co-Authored-By: Omer Anson<EMAIL_ADDRESS>

ok to test

run python-tests

rerun functional-tests-backend-orientdb

rerun functional-tests-backend-elasticsearch

rerun functional-tests-backend-elasticsearch

@snapiri thanks for submitting this. Can you please bump the library version so that I could publish it via pypi ?

sure

Will 0.3.2 be sufficient or do you want 0.4.0 ?

run python-tests

I fine with both

rerun functional-tests-backend-orientdb

rerun functional-tests-backend-orientdb


Updated getImageData() and LoadImages() in accordance with API version

Fixes #149
Description

Updated getImageData() and LoadImages() by replacing the URL in accordance with the new API version and changed instances of provider and provider_code to source.
Checklist:

[x] My pull request has a descriptive title (not a vague title like Update index.md).
[x] My pull request targets the master branch of the repository.
[ ] My commit messages follow best practices.
[ ] I added tests for the changes I made (if applicable).
[ ] I added or updated documentation (if applicable).
[ ] I tried running the project locally and verified that there are no
visible errors.

Developer Certificate of Origin
Version 1.1
Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129
Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.
Developer's Certificate of Origin 1.1
By making a contribution to this project, I certify that:
(a) The contribution was created in whole or in part by me and I
have the right to submit it under the open source license
indicated in the file; or
(b) The contribution is based upon previous work that, to the best
of my knowledge, is covered under an appropriate open source
license and I have the right under that license to submit that
work with modifications, whether created in whole or in part
by me, under the same open source license (unless I am
permitted to submit under a different license), as indicated
in the file; or
(c) The contribution was provided directly to me by some other
person who certified (a), (b) or (c) and I have not modified
it.
(d) I understand and agree that this project and the contribution
are public and that a record of the contribution (including all
personal information I submit with it, including my sign-off) is
maintained indefinitely and may be redistributed consistent with
this project or the open source license(s) involved.

I don't really understand the problem, all I changed was the names. Could you point out my mistake and help me correct it?

Very sorry, did not see that error among the other unimportant ones like " 'require' is not defined ". I will fix it tomorrow itself.

Sorry, messed up while using rebase. Its Ok now right?


Clicking the search bar when loading a save/autosave crash the game

When clicking on the search bar after the game has loaded a save or autosave the game crashes (i.e. similar to issue #2 )

Fixed in this commits:

7023398b
699fb778
5d47ec12


timestamp column is millisecond but not date

Hello Expert,
in my dataset, the timestamp column is millisecond but not date. how can I initiate TimeSeriesDataFrame?
BR,

You can use Pandas to convert your dataset to millisecond datetimes.
This is however, not related to Autogluon.
But here's roughly how you could do it:
// Load your dataset into a pandas dataframe
import pandas as pd

df = pd.DataFrame(data)

df['timestamp'] = pd.to_datetime(df['timestamp'], unit='ms')

For more info:
https://pandas.pydata.org/docs/user_guide/timeseries.html
https://docs.python.org/3/library/datetime.html#timedelta-objects
https://pandas.pydata.org/docs/reference/api/pandas.to_datetime.html#pandas-to-datetime

You can use Pandas to convert your dataset to millisecond datetimes.
This is however, not related to Autogluon.
But here's roughly how you could do it:
// Load your dataset into a pandas dataframe
import pandas as pd

df = pd.DataFrame(data)

df['timestamp'] = pd.to_datetime(df['timestamp'], unit='ms')

For more info: https://pandas.pydata.org/docs/user_guide/timeseries.html https://docs.python.org/3/library/datetime.html#timedelta-objects https://pandas.pydata.org/docs/reference/api/pandas.to_datetime.html#pandas-to-datetime

Many thanks, it works.


QA Foundation pages

QA all pages under Foundation

[x] Accessibility

[ ]Assets: (should we write on the main page what assets are - what we mean here or not?)

[x]  Image placeholder

[x]  Logos

[x]  System icons

[x] Product icons

[ ] Design tokens: (write what design tokens is if time - if not hide)

[x]  Clickbounds (will add to accessibility)

[ ]  Colour (maybe add new colors and remove 2ndary infographic ones)  (also dark theme stuff)

[x]  Elevation

[x]  Grid

[x]  Shape

[x]  Spacing

[x]  Typography

[x]  Data viz (refer to new infographic colors?)

[ ] Patterns: (do we need to write on the main page what this is? )

[x]  Grid alignment

[x]  Inputs (see comment)

[x]  Placement and order

[x]  Writing?

QA all pages under Foundation

[ ] Accessibility
Assets:
[ ] Image placeholder
[ ] Logos
[ ] System icons
[ ] Layout
Design tokens:
[ ] Clickbounds
[ ] Colour
[ ] Elevation
[ ] Grid
[ ] Interaction states
[ ] Placeholder
[ ] Shape
[ ] Spacing
[ ] Typography
[ ] Utilities
[ ] BRAND
[ ] Data viz
[ ] icons
Patterns:
[ ] Grid alignment
[ ] Inputs
[ ] Placement and order
[ ] Writing?

Need to get feedback from with Lucas about the Inputs page since it references videos and images that aren't there.

Clickbound info looks good!

All the foundation pages we want in the first release or published. Will make a separate issue for design tokens, assets, patterns main pages.


How to stop infinity Loop

User Agent is: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/57.0.2987.98 Safari/537.36.
Please describe how to reproduce this issue, and include links to screenshots if possible.
Issues is that freeCodeCamp lauch script evry time page are loaded. I don't have time press reset button or clear code.
What I suppose to do?

Hello @dmkav thanks for reporting this issue.
Can you please tell us which challenge/section are you having this issues?
Does this loop leaves any error message on screen? If so can you please take a screenshot and paste it.
Lastly, can you please open the browser's developer console and see there which kind of error you see?
Thanks for your cooperation.

Hi @marmiz! This is simple Js algorithms, challenge - factorization. I wrote recurcy, but didn't put condition. It doesn't write any mistake in  freecodecamp's console and does not show any error, after few minutes it ask kill or wait process. I can't stop JS launches.
But I have just realize I could turn off JS and try to clear window code. How do you think?

By the way you've described the issue @dmkav, seems like you have wrote a broken function causing an infinity loop in the on-line editor.
If this is the case, simply reset the page and try again.
Also from now on please refer to the official forum or ask for help in one of the official chat rooms.

@marmiz, simple I can't reset the page. That's why I wrote here. If it was only about refresh and clear page I wouldn't write here.

@dmkav In case a simply close and opening the tab again don't work, in chrome you can open the developer console and pause the current function execution in the debugging area.
Then proceed to clean the code.
Regardless I feel that this is not a FCC related issue, since handling loops is the browser's job.

@dmkav sorry to hear you've run into an infinite loop. Please take a look at this forum post on dealing with infinite loops https://forum.freecodecamp.com/t/free-code-camp-infinite-loop-protection/19550. Happy coding!


Pedestrian plot and environment score plot: yet to be implemented?

The tutorial page (https://neuralet.com/docs/tutorials/smart-social-distancing/) mentions the output view, and presents two nice analytic graphs: the pedestrian plot and the environment score plot. Using the newest version of the master branch on a jetson nano with jetpack 4.3 I see the video stream with detections and the birds eye view, yet I do not see the pedestrian and environment plots. Are they yet to be implemented, or am I perhaps missing something? Any hints would be greatly appreciated!
Edit: In #25 I see a picture of the plot graph, strange, it is not displaying for me.

Hi @tychotdeback did you run the frontend on the Jetson Nano or on another device. For me it works fine on master branch when starting the frontend on my computer and setting the correct IP and port in the Processor section of config-frontend.ini

Hey, we just got around checking these old issues, sorry about the delay.
The project has changed significantly in terms of the logged analytics, and the old frontend has been deprecated for a newer one https://www.beta.lanthorn.ai/, there's information in the README.md regarding it.
I'm closing this issue as it is not relevant anymore. But analytics and metrics should work correctly in the current version :)

Hey, we just got around checking these old issues, sorry about the delay.
The project has changed significantly in terms of the logged analytics, and the old frontend has been deprecated for a newer one https://www.beta.lanthorn.ai/, there's information in the README.md regarding it.
I'm closing this issue as it is not relevant anymore. But analytics and metrics should work correctly in the current version :)


add image name to mount dir path

Describe what this PR does / why we need it
At present, our cluster image data is mixed with application image data and base image data, If we run multiple images at the same time, there will be conflicts.
all imagedata mount directory will under below directory:
/var/lib/sealer/data/mount/${imageName}/${platform}
all application imagedata rootfs directory will under below directory:
var/lib/sealer/data/${imageName}/rootfs/application/apps
all basefs  imagedata directory will under below directory:
var/lib/sealer/data/${imageName}/rootfs
Does this pull request fix one issue?

Describe how you did it
Describe how to verify it
Special notes for reviews

Codecov Report
Base: 21.65% // Head: 21.64% // Decreases project coverage by -0.00% :warning:

Coverage data is based on head (8d9c883) compared to base (f9cc112).
Patch coverage: 7.40% of modified lines in pull request are covered.

:exclamation: Current head 8d9c883 differs from pull request most recent head 7dc802d. Consider uploading reports for the commit 7dc802d to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1850      +/-   ##
==========================================
- Coverage   21.65%   21.64%   -0.01%
==========================================
  Files          72       72
  Lines        6586     6587       +1
==========================================
  Hits         1426     1426
- Misses       4974     4975       +1
  Partials      186      186

Impacted Files
Coverage Δ

pkg/cluster-runtime/apps.go
0.00% <0.00%> (ø)

pkg/cluster-runtime/installer.go
0.00% <0.00%> (ø)

pkg/cluster-runtime/scale.go
0.00% <0.00%> (ø)

pkg/infradriver/ssh_infradriver.go
38.91% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Tab's horizontal scroll bar is too thin to scroll

Issue Type: Feature Request
I'm not talking about the editor's horizontal scroll bar.there is a very thin scroll bar between the tabs and editor,that's what i'm talking about.
When you open too many tabs,some tabs are invisible so you need scrolling horizontally.
There's a scrollbar to scroll the tabs,but it's too thin.
Of course,this wasn't a big bug or what,and I can use "Ctrl+Tab" to switch tabs.
maybe this bar should be bigger or even disappear considering it's not helpful.
VS Code version: Code 1.32.3 (a3db5be9b5c6ba46bb7555ec5d60178ecc2eaae4, 2019-03-14T23:43:35.476Z)
OS version: Windows_NT x64 10.0.17763

Duplicate of #32192

Oops, tagged wrong issue.


[Flaky Test] os/kola/aws, arm: cl.ignition.{v2,v1}.btrfsroot

Which tests are flaking?

cl.ignition.v1.btrfsroot
cl.ignition.v2.btrfsroot

Description
The test flakes on AWS-ARM and passes on subsequent runs. In the #618 release, the test has not passed even after a couple of runs in Beta but passed on Stable. On Alpha, cl.ignition.v2.btrfsroot on the second run, but the other test kept failing.
Log from the tests (if any)
The instance freezes after throwing the given log in the console
EFI stub: Booting Linux Kernel...
EFI stub: EFI_RNG_PROTOCOL unavailable, KASLR will be disabled
EFI stub: Using DTB from configuration table
EFI stub: Exiting boot services and installing virtual address map...

This test also fails on equinix metal analysis shows the following:

first boot fails at ignition phase with:

[   12.992849] ignition[1317]: disks: createFilesystems: op(3): [finished] creating "btrfs" filesystem on "/run/ignition/dev_aliases/dev/disk/by-partlabel/ROOT"
[   13.008097] ignition[1317]: disks: op(4): [started]  waiting for udev to settle
[   19.471294] systemd-fsck[1343]: Failed to stat /dev/disk/by-label/ROOT: No such file or directory

this blocks the boot, waiting at emergency shell phase for 5 minutes.

after restart, ignition still needs to run but fails with:

[   16.116745] ignition[1118]: Ignition failed: failed to create filesystems: mkfs failed: exit status 1: Cmd: "/usr/sbin/mkfs.btrfs" "--label=ROOT" "--uuid=9aa5237a-ab6b-458b-a7e8-f25e2baef1a3" "--force" "/run/ignition/dev_aliases/dev/disk/by-partlabel/ROOT" Stdout: "btrfs-progs v5.15.1 \nSee http://btrfs.wiki.kernel.org for more information.\n\n" Stderr: "ERROR: non-unique UUID: 9aa5237a-ab6b-458b-a7e8-f25e2baef1a3\n"

Ignition has this nice comment right before udev settle that nicely explains that this kind of thing is unlikely but can happen: https://github.com/flatcar-linux/ignition/blob/flatcar-master/internal/exec/stages/disks/disks.go#L92-L115.

Yeah, these kind of races are common when modifying block devices. A udev settle means really nothing and only a proper waiter can tell whether the condition we wait for is reached or not.

One way out here would be a waiter directly after the mkfs call which checks that the new filesystem is up under /dev/disk/by-uuid/VALUE based on the expected new UUID. Another solution is to issue a tagged udev event when all mkfs actions are done and wait for it to be reported back, meaning the event queue got completely processed up to this point.

I think it should work to replace the udevadm settle with a udevadm trigger -w /dev/BLOCKDEV directly after the mkfs call.

Tried my luck here: https://github.com/flatcar-linux/ignition/pull/35

Please reopen if you see this race again


skip specific models for rake cequel:migrate

It's possible to skip some models for rake cequel:migrate?

@t33m, it is not possible. I think that would be a good feature to have, though.


Add ability to add a Things todo from Alfred

Thank you for making this workflow available. It would be great to also us this to add new Todo items to Things.

@felciano thanks for adding this, might add a few additions to your PR. Before I do that, is there any way to set the due date when creating a new within the Alfred workflow?

No clue -- I'll defer to @xilopaint to answer that. I'm just trying to document what I figured out by experimenting.

@areohbe no, set a due date while creating a new to-do is not currently possible. Have you ever taken a look at Thing's Quick Entry feature?

I really don't see how my workflow can be better than it for the purpose of creating new to-dos. Personally, I don't even use this workflow for adding new to-dos to Things.

@felciano what is this issue about? Is it about creating to-dos or improving README?


convenient-test-manager: init at 1.2.1

Description of changes
add convenient-test-manager
https://pub.dev/packages/convenient_test
https://github.com/fzyzcjy/flutter_convenient_test
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-ready-for-review/3032/1648

@SuperSandro2000 updated with your suggestions now.

@SuperSandro2000 done, once again.

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-ready-for-review/3032/1730


BugFix 3.5:  Some error results have messages that are not reporting

Discovered that some rocksdb error messages were not getting copied all the way to the client. The generic error number arrived, but not the specific error message. This updates code at the coordinator level to always report error messages retrieved from the agency updates.
[XX] Bug-Fix for at least devel and 3.4 ... considering 3.3
[XX ] The behavior in this PR can be (and was) manually tested (support / qa / customers can test it)
The behaviour change can only be verified via automatic tests
This change is a trivial rework / code cleanup without any test coverage.

@jsteemann Did a review on my screen ... need to force another reviewer into this so we can merge ...


Update "ember-changeset" and "ember-changeset-validations" versions

Hi @okachynskyy, first of all; again: Thanks for your PR!
Is this still a work in progress? If not, I'd be curious about why you had to roll back changeset-validations to 1.2.6?

@czosel, because in 1.2.7 there is a bug with validation messages:
https://github.com/DockYard/ember-changeset-validations/issues/139
It show "must be blank" instead of "can't be blank"

@okachynskyy I see - always good to have automated tests :smile:
I'll also add a "dependencies" badge to the README - thanks again for this PR!


Error with daemonise when trying to build

Hello,
I've just installed PHPCI on a local server and after finding the "build always null" issue in the documentation and reading about having to use a cron or the daemon for running builds, I tried the latter. However, as soon as I created a new build I saw this error in the daemonise.log file:
[2014-08-21 13:10:39] DaemoniseCommand.INFO: Finding builds to process
[2014-08-21 13:10:39] DaemoniseCommand.INFO: Found 1 builds
PHP Fatal error: Can't inherit abstract
function PHPCI\Helper\CommandExecutor::findBinary() (previously declared abstract in PHPCI\Helper\BaseCommandExecutor) in /var/www/phpci/PHPCI/Helper/BaseCommandExecutor.php on line 15
PHP Stack trace: PHP 1. {main}() /var/www/phpci/daemonise:0
PHP 2. Symfony\Component\Console\Application->run() /var/www/phpci/daemonise:22
PHP 3.
Symfony\Component\Console\Application->doRun() /var/www/phpci/vendor/symfony/console/Symfony/Component/Console/Application.php:124
PHP 4.
Symfony\Component\Console\Application->doRunCommand() /var/www/phpci/vendor/symfony/console/Symfony/Component/Console/Application.php:193
PHP 5.
Symfony\Component\Console\Command\Command->run() /var/www/phpci/vendor/symfony/console/Symfony/Component/Console/Application.php:887
PHP 6. PHPCI\Command\DaemoniseCommand->execute()
/var/www/phpci/vendor/symfony/console/Symfony/Component/Console/Command/Command.php:252
PHP 7. Symfony\Component\Console\Command\Command->run()
/var/www/phpci/PHPCI/Command/DaemoniseCommand.php:87
PHP 8. PHPCI\Command\RunCommand->execute() /var/www/phpci/vendor/symfony/console/Symfony/Component/Console/Command/Command.php:252
PHP 9. PHPCI\Builder->__construct() /var/www/phpci/PHPCI/Command/RunCommand.php:102
PHP 10. {closure}() /var/www/phpci/PHPCI/Command/RunCommand.php:0
PHP 11. include()
/var/www/phpci/bootstrap.php:29
PHP 12. {closure}() /var/www/phpci/bootstrap.php:0
PHP 13. include() /var/www/phpci/bootstrap.php:29 [2014-08-21 13:10:39] _.ERROR: ErrorException: 64:
Can't inherit abstract function PHPCI\Helper\CommandExecutor::findBinary() (previously declared abstract in PHPCI\Helper\BaseCommandExecutor) in
/var/www/phpci/PHPCI/Helper/BaseCommandExecutor.php line 15 (uncaught exception) at /var/www/phpci/PHPCI/Helper/BaseCommandExecutor.php line 15 {"exception":"[object] (ErrorException:
64: Can't inherit abstract function PHPCI\Helper\CommandExecutor::findBinary() (previously declared abstract in PHPCI\Helper\BaseCommandExecutor) in
/var/www/phpci/PHPCI/Helper/BaseCommandExecutor.php line 15 at /var/www/phpci/PHPCI/Helper/BaseCommandExecutor.php:15)"}
Any idea what it might be? I am running it on PHP 5.3.3
Thanks!

Do you still have this errors? Maybe we already fix it without knowing :)
And did you restart the deamon after enable plugins and a composer install?


Feature support

Screenshots under boot diagnostics

@mamccrea
Can you review the proposed changes?
When the changes are ready for publication, add a #sign-off comment to signal that the PR is ready for the review team to merge.
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

#sign-off


Minor Rewards Fixed

Enhancement 91756: Product details display if there is product details saved for the item
Enhancement 91754: When no image in reward display default image instead
Bug 91757: When text is too long use "..."
Enhancement 91758: Display only Close button when not enough fund

Any ideas why we have a check that fails @akash2017sky ?

Changes are implemented however button labelled Cancel, instead of Close. @BenGWeeks can it stay as it is or do you require to relabel it to be "Close"?