Do not set load_crypto_strings_inited when OPENSSL_NO_ERR is defined

Only set the load_crypto_strings_inited to 1 when err_load_crypto_strings_int was called.
This solves the following issue:

openssl is built with no-err
load_crypto_strings_inited is set to 1 during the OPENSSL_init_crypto call
During the cleanup: OPENSSL_cleanup, err_free_strings_int is called because load_crypto_strings_inited == 1
err_free_strings_int calls do_err_strings_init because it has never been called
Now do_err_strings_init calls OPENSSL_init_crypto
But since we are in the cleanup (stopped == 1) this results in an error:
CRYPTOerr(CRYPTO_F_OPENSSL_INIT_CRYPTO, ERR_R_INIT_FAIL);
which then tries to initialize everything we are trying to clean up: ERR_get_state, ossl_init_thread_start, etc

+1
@matbech do you agree with me that this is a trivial fix?

To be clear we can only accept contributions with a CLA, unless all parties agree that they are trivial.

@richsalz Yes it is a trivial fix and I have already signed the CLA.

commit a1f2b0e in master 3d04039 in 1.1.0; thanks!


[MEGA SUPER HIGH] Issue submitting Registration Form (for some people!)

A User emailed about this issue yesterday at 4:30 p.m. When trying to Register, the page just continues to load and will not submit the form. I chalked it up to User error since info@ has received other "New User" notification emails in the interim, even one as early as this morning.
However, I was able to replicate the issue when I tried to Register for the User this morning .
I tried on Windows 10 OS using Firefox and Chrome browsers and tested using different DOBs, email addresses, etc. I was not logged in to SDRT website when testing. Still unsuccessful.
The User was using a cell phone.
The Caldera Registration Form was edited yesterday, but don't see how that would make it impossible for a few users to not be able to submit the form and other users to be able to. The edits made:

Made 5 & 6 questions required
Changed wording of 6th question

@JasonTheAdams More people are reporting issues with the Registration Form not submitting. How is the migration to Gravity Forms looking?

I'm 95% finished with this. I just need to update a few things on production and then push the new code.

GREAT NEWS. KEEP ME POSTED!!!

Hi @dreazee!
Ok! I just pushed the new changes live. This took me a bit, but I put a lot of extra work into this to get us ready for migrating more of the forms, as well as starting to make general improvements to the codebase. Since this is so important, I did my best to test this out of the Dev environment, using the testing version of Checkr. It all worked for me. Nevertheless, please test this with a person as soon as you're able!
One quick improvement I thought of, but I wanted to get your thoughts on: On the Volunteer Registration page, when the user registers it reloads the page and replaces the form with the following text:
Hi {Name (First):1.3},

Thank you for registering with San Diego Refugee Tutoring! To finish your registration, please verify your email. You have been sent an email, simply click on the link provided in your email. You will then be provided with the steps to complete your background check.

Since the text on the page is so long it's pretty easy to not notice this, however. I thought about making a new page to send the user to so the content is very clear. So when the user submits the form it redirects them to the new page with instructions. But I wasn't sure if for some reason you wanted the user to stay on the volunteer page?

I thought a User wasn't going to need to verify their email address? And that a User would be "approved" automatically without anything else to do on a User side or Admin side... ?


WhichKey shows conflicts with default keybindings

WhichKey: checking conflicting keymaps

WARNING: conflicting keymap exists for mode "n", lhs: "gb"
INFO: rhs: <Plug>(comment_toggle_blockwise)
WARNING: conflicting keymap exists for mode "n", lhs: "gc"
INFO: rhs: <Plug>(comment_toggle_linewise)

Would be nice to add a hint how to disable this with note on the default keybindings.
see also https://github.com/linty-org/key-menu.nvim/pull/8 for the great effort.

Would be nice to add a hint how to disable this with note on the default keybindings.

I am not sure, what to disable here(?). As I don't use whichkey so I have no idea what to do here. But if you want, you can disable all the mappings by adding mappings = false to setup config

I have copied comment.lua from your config but still the mappings are not working!! What do I do? The plugin is not giving any errors? The path in the Packer config is also correct.
Code from comment.lua --> require('Comment').setup({
pre_hook = function(ctx)
return require('Comment.jsx').calculate(ctx)
end,
})

@Jetandarkumar What mappings are not? Are you talking about whichkey? If not please have a look https://github.com/numToStr/Comment.nvim/issues/115

I am closing this as this is not really a issue with the plugin.

@numToStr I think he is referring to the :checkhealth command where which-key tells you if any of your mapping has conflict and in this case this plugin seems to display a conflict.

So it is not really about changing your keymap but somehow something create a conflict there.


Add CONTRIBUTING.md

It's on your TODO list here: https://github.com/toxicFork/react-three-renderer/issues/2#issuecomment-186855445
I was trying to figure out how to contribute. Since I couldn't figure it out, I was left reading the code and searching through issues and pull requests. Most people won't even do that.
Specifically I wanted to build the code and documentation (the wiki). It looks like there's a Gulp task for that, but then there are a bunch of files in the docs/src folder that look autogenerated. It's hard to tell if I can modify those directly or if I should be modifying the generator.
I also didn't know GitHub supported a wiki/ directory. Is that all there is to it or do you magically upload the wiki some other way every time you want to publish the wiki?
Questions to cover in CONTRIBUTING.md
Think of this as a wishlist of all kinds of possible questions the CONTRIBUTING file could answer. Really we just need a bare minimum amount of information to be able to start figuring things out and then submitting them to you for review.
Even just pointing us to things in the code to read or useful PRs would be immensely helpful.
The answers to some of these questions might be related or even the same.

[ ] How is the code organized?
[ ] Where do I start to understand how the code works? (Which file? Helpful articles?)

This is important because of the highly custom nature of this library, it's completely different from most other react libraries

[ ] What does a complete PR look like? (Documentation, code, tests, etc.)
[ ] How do I generate documentation?
[ ] How do I write tests?

[ ] Where do tests go?
[ ] Can I see an example?

[ ] How do I contribute to the wiki?

[ ] Do I fork or use the Edit button?
[ ] Can I view my changes locally?
[ ] How does the wiki work?
[ ] Is it automatically generated?
[ ] Is the wiki folder uploaded somewhere or does GitHub actually support that?

Can't seem to find this on Google

Thank you very much for this template! I will create a PR for the doc and fill in the checkboxes :)

Adding a milestone to this so I'll have to do it :D

looks above oh past me, what have you done...
I'll try a different way, perhaps 30 minutes every day towards this should be better. Apologies.

@toxicFork no problem! I understand how busy things get. Thanks for taking the time!


Instead of modifying bashrc, add ~/.local/bin to PATH in .profile and persist that in dotfiles instead.

bashrc only works for terminals, it doesn't change the path when .desktops exec scripts. Bad.  I can delete this after my MR gets into Tails.

PATH assignment was merged into Tails.


Adding thisisnic and amol- as collaborators

Thsi gives thisisnic and amol- the ability to "assign, edit, and close issues and pull requests".  Given their help so far I think this should be pretty straightforward.

A bit late, but yet, certainly +1


Adds configuration parameter span_frame_to_ros_frame.

This configuration parameter will apply a VEHICLEBODYROTATION command
which rotates the Novatel SPAN frame 90 degrees counter-clockwise
about the Z axis and an APPLYVEHICLEBODYROTATION command to make
that rotation apply to the IMU and INS outputs. This converts the
Novatel SPAN frame (right-hand rule with Y forward) to a ROS frame
(right-hand rule with X forward).
Tested and works on OEM6 (should also work on OEM7 as the commands are the same).

Looks good to me, thanks!


Upgrade dependencies and adjust exceptions and logging

pub_server 0.1.5 enables the exception change, so that we can skip warning logs, and have info on client-side problems. Closes https://github.com/dart-lang/pub-dartlang-dart/issues/1456
memcache update addresses the exception in https://github.com/dart-lang/pub-dartlang-dart/issues/1547

although these seem like two independent changes

shall I separate them?

Nah, this is fine.


BUGFIX: IOBytes doesn't quite fulfil bytes-like contracts, but can be converted to something that does

Fix to: https://www.pivotaltracker.com/story/show/165185808

I have checked and if x is a bytes object that bytes(x) just returns the same object without performing a copy.

Latest change adds an implementation of __bytes__ to IOBytes. This ensures that for an IOBytes object x the call bytes(x) returns the bytes object that x maintains.


Json parsing error is occurred when the pound symbol is contained in body request.

Hello,
Please check my code and let me know how to solve this problem.
const API_URL = '...';
const KEY = '...';
const message = 'You sent £100 successfully';
export default function func1(tokens, message) {
const promises = tokens.map((token) => {
const body = {
...
notification: {
body        : message,
...
},
...
};
const bodyStr = JSON.stringify(body);
return request
.post(API_URL)
.set('Accept-Encoding', 'gzip,sdch')
.set('Content-Type', 'application/json')
.set('Content-Length', parseInt(bodyStr.length, 10))
.set('Authorization', key=${KEY})
.send(bodyStr);
});
return Promise.all(promises)
.then(() => console.info('success'))
.catch(e => console.info(e));
}
After running, the error occurred as following:
Error: Bad Request
at Request.callback (/node_modules/superagent/lib/node/index.js:649:11)
at Stream. (/node_modules/superagent/lib/node/index.js:846:18)
at emitNone (events.js:86:13)
at Stream.emit (events.js:185:7)
at Unzip. (/node_modules/superagent/lib/node/unzip.js:63:12)
at emitNone (events.js:91:20)
at Unzip.emit (events.js:185:7)
at endReadableNT (_stream_readable.js:973:12)
at _combinedTickCallback (internal/process/next_tick.js:74:11)
at process._tickDomainCallback (internal/process/next_tick.js:122:9)
status: 400,
response:
Response {
domain: null,
_events: {},
_eventsCount: 0,
_maxListeners: undefined,
res:
IncomingMessage {
_readableState: [Object],
readable: false,
domain: null,
_events: [Object],
_eventsCount: 3,
_maxListeners: undefined,
socket: [Object],
connection: [Object],
httpVersionMajor: 1,
httpVersionMinor: 1,
httpVersion: '1.1',
complete: true,
headers: [Object],
rawHeaders: [Object],
trailers: {},
rawTrailers: [],
upgrade: false,
url: '',
method: null,
statusCode: 400,
statusMessage: 'Bad Request',
client: [Object],
_consuming: true,
_dumped: false,
req: [Object],
setEncoding: [Function],
on: [Function],
text: 'JSON_PARSING_ERROR: Unexpected token END OF FILE at position 316.\n',
read: [Function] },

It looks to me like the issue is probably with sending a compressed response body but manually setting the Content-Length header based on the uncompressed body size, thus resulting in there being less data than declared due to compression. In both your client and server code, it is usually best to let your libraries handle Content-Length automatically as they will calculate it correctly. I doubt this has anything to do with the actual content of the request body in terms of pound sign.

Oh, I got it.
Thanks very much!! it works now


Add reference repo to CI

Adds reference repos.
These correspond to repos and download locations which can be seen in the Jenkins job which mirrors them.
Checklist

[x] Implement code

Codecov Report

Merging #980 into master will decrease coverage by 0.36%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master     #980      +/-   ##
============================================
- Coverage     63.55%   63.19%   -0.37%
  Complexity       85       85
============================================
  Files           250      247       -3
  Lines         11047    10102     -945
  Branches       1573     1335     -238
============================================
- Hits           7021     6384     -637
+ Misses         3622     3335     -287
+ Partials        404      383      -21

Impacted Files
Coverage Δ
Complexity Δ

...lastic/apm/agent/http/client/HttpClientHelper.java
0% <0%> (-67.4%)
0% <0%> (ø)

...client/AbstractAsyncHttpClientInstrumentation.java
43.75% <0%> (-5.62%)
0% <0%> (ø)

.../apm/agent/okhttp/OkHttpClientInstrumentation.java
19.23% <0%> (-4.58%)
0% <0%> (ø)

...apm/agent/okhttp/OkHttp3ClientInstrumentation.java
20% <0%> (-4.4%)
0% <0%> (ø)

...astic/apm/agent/impl/transaction/AbstractSpan.java
80.15% <0%> (-3.44%)
0% <0%> (ø)

.../apm/agent/report/serialize/DslJsonSerializer.java
90.76% <0%> (-2.32%)
0% <0%> (ø)

...ic/apm/agent/redis/jedis/JedisInstrumentation.java
61.11% <0%> (-2.23%)
0% <0%> (ø)

...va/co/elastic/apm/agent/impl/transaction/Span.java
77.52% <0%> (-2.04%)
0% <0%> (ø)

...astic/apm/agent/jdbc/StatementInstrumentation.java
32.5% <0%> (-0.84%)
0% <0%> (ø)

...nt/httpclient/HttpAsyncRequestProducerWrapper.java
0% <0%> (ø)
0% <0%> (ø)
:arrow_down:

... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update abba3eb...753aac3. Read the comment docs.

What does this do? Enable faster checkouts on CI?

@felixbarny That is correct. Here is a bit more information if you are curious: https://support.cloudbees.com/hc/en-us/articles/115001728812-Using-a-Git-reference-repository


[swagger]containerApps.listSecrets throws response code 204 as an error

@azure/arm-app:
*^1.0.0-beta.1:

Describe the bug
client.containerApps.listSecrets considers the 204 response code to be an error.  This happens if the container app pinged has no secrets associated with it.  It should probably just return an empty array rather than throwing an error.
To Reproduce
Steps to reproduce the behavior:

Call client.containerApps.listSecrets on a container app that has no secrets

Expected behavior
If the container app has a secret, return the array.  If it does not, return an empty array.
Screenshots
If applicable, add screenshots to help explain your problem.
Additional context
Add any other context about the problem here.

Label prediction was below confidence level 0.6 for Model:ServiceLabels: 'App Services:0.43074873,Storage:0.09991559,Container Instances:0.09626426'

Note: This also occurs with containerApps.beginDeleteAndWait which would also return 204 once the content is deleted.

Hi @MaryGao  Can you take a look at this issue ? Thanks

@nturinski I tried in my local, Are these behaviors expected from your side?

For the operation client.containerApps.listSecrets, it will throw the RestError with 204 header
For the operation containerApps.beginDeleteAndWait, it will return undefined and NOT throw any error with 204 header

Hi Nathan, thanks for reporting this and the first one is identified as an swagger issue and their swagger definition didn't take 204 as success status code and we are contacting the service team to fix it now!

As per the original issue, this also applies to some delete methods in the arm-appcontainers SDK. That includes:
managedEnvironments.beginDeleteAndWait containerApps.beginDeleteAndWait

@nturinski Could you create an issue for the package arm-appcontainers considering they are different packages so we could better track their status?

@nturinski  Yes, you are right and this is re-named package. Please edit your first comment to reflect them. Thanks!

As per the original issue, this also applies to some delete methods in the arm-appcontainers SDK. That includes:
managedEnvironments.beginDeleteAndWait containerApps.beginDeleteAndWait

@nturinski Could you suggest why you add the two deletion operations again?
After checking the original issue, I think we have an agreement that there is no change for containerApps.beginDeleteAndWait and  the below description is expected behavior:

For the operation containerApps.beginDeleteAndWait, it will return undefined and NOT throw any error with 204 header

I'd like to highlight that this would work for operation managedEnvironments.beginDeleteAndWait also.

@nturinski Could you suggest why you add the two deletion operations again?

I think I misunderstood the first time. Currently, beginDeleteAndWait doesn't return undefined and does throw an error.

'RestError: Received unexpected HTTP status code 204 while polling. This may indicate a server issue.\n\tat isUnexpectedPollingResponse (c:\\Users\\naturins\\Code\\vscode-azurecontainerapps\\node_modules\\@azure\\core-lro\\dist\\index.js:464:15)\n\tat isLocationPollingDone (c:\\Users\\naturins\\Code\\vscode-azurecontainerapps\\node_modules\\@azure\\core-lro\\dist\\index.js:549:13)\n\tat processLocationPollingOperationResult (c:\\Users\\naturins\\Code\\vscode-azurecontainerapps\\node_modules\\@azure\\core-lro\\dist\\index.js:552:63)\n\tat GenericPollOperation.poll (c:\\Users\\naturins\\Code\\vscode-azurecontainerapps\\node_modules\\@azure\\core-lro\\dist\\index.js:595:16)\n\tat processTicksAndRejections (node:internal/process/task_queues:96:5)\n\tat async GenericPollOperation.update (c:\\Users\\naturins\\Code\\vscode-azurecontainerapps\\node_modules\\@azure\\core-lro\\dist\\index.js:683:34)\n\tat async LroEngine.pollOnce (c:\\Users\\naturins\\Code\\vscode-azurecontainerapps\\node_modules\\@azure\\core-lro\\dist\\index.js:200:34)'

For the operation containerApps.beginDeleteAndWait, it will return undefined and NOT throw any error with 204 header

I think that this should be the expected behavior.

@nturinski  we reproduced the errors in local and these two deletions are identified as client errors. We are working on the fixes and will let you know once ready!
Please notice this error is different from the client.containerApps.listSecrets.

@nturinski Could you try to install the latest version ?
We fixed the DELETE issue in client side what's more we found that client.containerApps.listSecrets is fixed from server side. So please have a try and let us know if it works for you.

Verified that this is fixed. Thanks!

close it as issue addressed. Thanks


[Guided Setup Stage 2] Create videos

Task
For Stage 2 of Guided Setup, we're going to introduce different intro messages and tasks depending on what the user is trying to do in Expensify. The intro message and some of the tasks will have custom videos.
According to the doc, we need:

Intent-specific videos:

[ ] Track business spend for taxes
[ ] Get paid back by my employer
[ ] Manage my team's expenses
[ ] Track and budget personal spend
[ ] Chat and split bills with friends

Task-specific videos:

[ ] How to track expenses with Expensify
[ ] How to submit expenses with Expensify
[ ] How to approve and pay expenses with Expensify
[ ] How to track personal expenses with Expensify
[ ] How to chat/split money with friends with Expensify

Extra info

Design Doc (internal)
Slack channel - #wave-collect (internal)
Tracking issue (internal)
Figma project (internal)

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01e8e6232726cb302b
Upwork Job ID:<PHONE_NUMBER>265419264
Last Price Increase: 2024-03-15

This is all going to be managed internally, no need for a C+ review or Upwork job. Thanks!

Is TCW handling this or are we?

We're handling making storyboards then handing over to TCW for making of the final videos/GIFs

Nice! Where can I follow along?

Here's the Figma file I'm working from. cc @Expensify/design for viz

Post made here about updates

I'm finishing the intent videos this week. We decided to not go ahead with one-video-per-task, so this should simplify things.

@dubielzyk-expensify
The new API command for creating messages for guided setup requires a thumbnail for the video. Could You prepare it also for each video?

Yep, will do!  I'm finishing the storyboards today and sending to TCW early next week. Hoping it'll all be done by end of next week basically. Does that fit your timeline?

Made an update here

Yup, early next week suits me :)

Oh sorry. We're just doing a final internal look, then I'll upload them all here 😄

4 of 5 videos are handed over to TCW here.
Gonna do the last one tomorrow.
Hoping to get the video assets next week. Hope that works with the timeline

Just got back the first draft from TCW. Had only minor feedback. Expect to have the finished videos on Mon-Tue

Uploaded video to Dropbox. Here's the zip file.
Over to you @francoisl for compression and Web-Static upload 😄

Hi, I’m Michael (Mykhailo) from Callstack and I would like to work on this issue.

@rezkiy37 the videos are ready and available. Here are the direct links (where https://d2k5nsl2zxldvw.cloudfront.net is the constant CLOUDFRONT_URL in the codebase):
https://d2k5nsl2zxldvw.cloudfront.net/videos/guided-setup-track-business.mp4
https://d2k5nsl2zxldvw.cloudfront.net/videos/guided-setup-get-paid-back.mp4
https://d2k5nsl2zxldvw.cloudfront.net/videos/guided-setup-manage-team.mp4
https://d2k5nsl2zxldvw.cloudfront.net/videos/guided-setup-track-personal.mp4
https://d2k5nsl2zxldvw.cloudfront.net/videos/guided-setup-chat-split-bills.mp4

@francoisl @trjExpensify don't we have a video for the looking around (last one) case?

Confirming in thread, I can't see one in the doc. I also don't see one supplied by TCW (link for Expensifiers) in that Slack channel.

Making a note here about this discussion. Let's look into why the first frame isn't being displayed as the thumbnail.
Here's a video comparing a video I uploaded and the onboarding video, so you can see the difference:
https://github.com/Expensify/App/assets/16232057/5b401748-5391-43e6-aa11-12a11d837cec

Also making a note that we need to generate proper thumbnails for the videos, I'll do that after we figure out why no thumbnail is being shown at all.

I think we're done here though, right?

Looks like yes!

I believe this is done and shipped no?

Yes.


fix(plugin_api): wrong metric type enums

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area API-version

/area build

/area CI

/area driver-kmod

/area driver-bpf

/area driver-modern-bpf

/area libscap-engine-bpf

/area libscap-engine-gvisor

/area libscap-engine-kmod

/area libscap-engine-modern-bpf

/area libscap-engine-nodriver

/area libscap-engine-noop

/area libscap-engine-source-plugin

/area libscap-engine-savefile

/area libscap

/area libpman

/area libsinsp

/area tests

/area proposals

Does this PR require a change in the driver versions?

/version driver-API-version-major

/version driver-API-version-minor

/version driver-API-version-patch

/version driver-SCHEMA-version-major

/version driver-SCHEMA-version-minor

/version driver-SCHEMA-version-patch

What this PR does / why we need it:
Fixes wrong metric type enums, which are used to convert plugin metrics to libsinsp metrics.
It also resolves get_metrics symbol in plugins.
Which issue(s) this PR fixes:

Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?:

fix(plugin_api): wrong metrics type enums

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: mrgian
Once this PR has been reviewed and has the lgtm label, please assign molter73 for approval. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: incertum, mrgian
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [incertum]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

LGTM label has been added.  Git tree hash: f189d657c285f57d24903f6f96932698dd4f29bf

/milestone 0.18.0

New changes are detected. LGTM label has been removed.

Bumped PLUGIN_API_VERSION_MINOR :)

LGTM label has been added.  Git tree hash: 8226f3453afceed9b4598a717941899147df60ab

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: FedeDP, incertum, mrgian
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [FedeDP,incertum]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

/milestone 0.17.2

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: FedeDP, incertum, jasondellaluce, mrgian
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [FedeDP,incertum,jasondellaluce]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

/unhold


compilation error

I'm new to the project. I have cloned repository and try simply to compile. I'v got
Building j2objc jar
building jre_emul.jar
apache_harmony/classlib/modules/luni/src/main/java/java/util/EnumMap.java:155: error: incompatible types: Object cannot be converted to E
return type.get(new MapEntry(enumMap.keys[prePosition],
^
where E is a type-variable:
E extends Object declared in class EnumMapIterator
Note: Some input files use or override a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
Note: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.
1 error
make[1]: *** [/Users/alex/projects/j2objc/jre_emul/build_result/jre_emul.jar] Error 1
make: *** [jre_emul_jar_dist] Error 2

@tomball, I am getting this error.
Building libxalan.a
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/lipo -create /Users/alizain/Downloads/j2objc-master/xalan/build_result/objs-appletvos/libxalan.a /Users/alizain/Downloads/j2objc-master/xalan/build_result/objs-appletvsimulator/libxalan.a -output /Users/alizain/Downloads/j2objc-master/xalan/build_result/appletvos/libxalan.a
building j2objc_xalan.jar
Note: Some input files use or override a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
Note: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.

That's not a compilation error. You'll get the same notice building Xalan with javac, since the issue being reported is that Xalan uses or overrides deprecated API (which it does):
$ cd j2objc/xalan
$ javac -d /tmp/xalan -sourcepath third_party/android/platform/external/apache-xml/src/main/java `find third_party -name '*.java'`
Note: Some input files use or override a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
Note: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.

Closing this issue since this notice is reported by javac (which j2objc uses as its front-end) and since -Xlint:-deprecation doesn't suppress it.


Fix flickering OSD and refactor logic for volume slider.

This fixes the flickering/hiding of the display's OSD by readding errorRecoveryWaitTime: self.hideOsd ? 0 : nil which was removed.
Also, the volume slider now behaves the same way as the native macOS volume slider: It will only change the volume after a mouse-up event and it will also play the volume-changed sound.

volume is not being restored to the previous value

You're right, same for me. I'll look into it.

Should be fixed.

Also, @scorpiondev, I just tried switching from DispatchQueue.global(qos: .userInitiated) to DispatchQueue.main and performance gets worse for me.

I've spotted two issues with this build:

The "mute" OSD image now comes up intermittently or is completely wrong when toggling mute (see gif below):

When holding down the volume up key, when the volume gets to maximum, the volume pop sound continues to be played as long as you hold down the key instead of stopping once the volume hits maximum

Performance seems fine with the writes happening on the background thread, from what I can see, anyway.

Was there any development on this PR? Currently facing the same issue.

Closing this as it looks pretty abandoned, feel free to reopen :)


how to empty search box?

How would I empty search box if no selection is made?  Currently, the control would leave whatever a user types in or the highlighted item even when no selection is made.
Thanks,
Junlin Xu

clearSelected should do it

clearSelected should do it

clearSelected is ok when you want to clear the text after you selected an item from the suggested list.
What I would like to do is the following:

The selected text stays if I select an item from the the suggested list.
The text clears if I do not select from any of the suggested item list.  For example, if I type in something in the input box and I just highlight on one of the item list.  I do not want the highlighted text to stays in the input box after I click on somewhere else to dismiss the suggested popup.  Instead, I want the text to be cleared after input box lost focus.  Currently, I cannot reliably do that.
The reason I wanted to do like this is to use this component to replace a dropdown that has huge selection item list.

@feidong-zxzx had a similar problem, my work around was to null the required field... so something like this.
if (selected) {       this.required_field = selected.data } else {       this.required_field = null }
Would be great if there was an onBlur or something that would ether reset it back to the original selected value OR just clear the selection all together requiring the user to do something.

focus and blur events are supported but it might be a good idea to add clearSerach that will clear the input if a value was not selected

another option would be to have a clear option that gets: nothing or empty string as the default, all, selected or unselected

decided to go with clearUnselected because it's simpler


Android - Login - When entering the magic code and signing in, a gray and black screen appears.

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 1.4.63-0
Reproducible in staging?: y
Reproducible in production?: n
Issue reported by: Applause - Internal Team
Action Performed:

Open New Dot app
Enter any email> Continue
Enter magic code> Sign in
Check the screen before skeleton appears

Expected Result:
When entering the magic code and clicking the "Sign in" button, the LHN skeleton should appear.
Actual Result:
When entering the magic code and signing in, a gray and black screen appears.
Workaround:
n/a
Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[ ] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos
Add any screenshot/video evidence
https://github.com/Expensify/App/assets/93399543/07fbf2f3-3121-4e4f-a59d-84bdcc441ad0
View all open jobs on GitHub

This seems minor and not really a blocker

I see the black screen, IMO it is barely noticeable. Seeing at it is only affecting one platform I am going to close


grbl-panel does not connect to ramps1.4

I found I needed to add a sleep(1000) between the set dtr and clear dtr which is used to reset the arduino.
This cleared my hang on connect. The arduino needs time to completely reset before any commands are issued to it..
Nice program..  using it to control my Shapeoko 2
Thanks

Interesting, is that over and above the Start up Delay that is configurable on the Settings page?
Someone else had reported a problem with Mega2560, which is why I added that setting.

I was having the same issue this weekend using Grbl-Panel with a Mega2560 (running a custom 6-axis version of Grbl I'm testing out).
If I monitor the serial data, I can see the "?" status enquiries start immediately, rather than waiting based on the start up delay.
The fix was be pretty simple:  In GrblGui.vb subroutine btnConnDisconnect_Click, move the line "statusPrompt("Start")" one line down so it is after the Sleep().
After I did this, I had no problems connecting.

It is a trivial change, but I've created a pull request

Finally integrating this into a release. Should be done before Nov 10

Fixed in Release <IP_ADDRESS>
Thank you for your patience


Finalize Groups schema

Proposed format
In catalog/CHEM 1331:
Note: field "groups" is of type DocumentReference<Group>[]
{
  "department": "CHEM",
  "catalogNumber": "1331",
  ...
  "groups": [ "/groups/30" ]
}

In groups/30:
Note: field "courses" is of type DocumentReference<Course>[]
{
  "name": "Life & Physical Sciences",
  "identifier": "30",
  "courses": [ "/catalog/CHEM 1331" ],
  "keywords": [ ... ],
  "description": "Courses which satisfy the \"Life & Physical Sciences\" component in the UH Core Curriculum.",
  "courses_count": 1
}

Included in<EMAIL_ADDRESS>


Migrate to move v6 and u16, u32, u256 support

After ensuring Move v6 types are backward compatible and not breaking existing Sui, we're now ready to migrate to Move v6.
This enables newer features including new integer support like u16, u32, u256.
Follow up PRs will flesh out new integer support for Typescript modules & apps if needed.

@damirka I could use some feedback on the BCS TS module please.


update & simplify documentation

I updated the documentation and simplified it as much as possible. I removed the full examples we had, I think for someone having the first look they might be too much.
I would create a hosted documentation website using GitHub pages that contains:

Getting Started
Features
Examples (at least FastAPI + middleware, Pytest)
API Reference

So the GitHub Readme is just an overview with the most important information and more detailed stuff can be found in the hosted docs
resolves #19

Let's keep it simple. No hosted docs. People use it or they don't. We can't invest that much. At least as long as Tebuto isn't live 😄

docs

hmm yes the repo is probably not big enough to invest the effort 😄 Should we then just have the examples in an own folder with README.md files and link them in the main readme? Like
README.md
examples/
    fastapi/
       README.md
       app.py
       ...
   pytest/
       README.md
       conftest.py
       ...

I think having the examples as real subprojects is more beneficial than having them in the readme - it's more readable and people can fork it more easily


Bean validation annotation handlers don't use the defined registry

Having some classes annotated with bean validation annotations, I've imported the specific modules just to discover that @Digits is not supported.
Seing that, I've defined an explicit randomizer:
CustomRandomizerRegistry registry = new CustomRandomizerRegistry();
// we usually use a scale of 3 for BigDecimal
registry.registerRandomizer(BigDecimal.class, new BigDecimalRandomizer(Integer.valueOf(3)));

The problem seems to be that the annotation handlers don't use the registries, but create a new EasyRandom instance and configure that one.
Any way they can be made to use my registry?
Using version 4.2.0

Thank you for opening this issue. Indeed, @Digits is not supported (this is mentioned in the wiki as you might have seen).
Any reason for using CustomRandomizerRegistry  and not BeanValidationRandomizerRegistry? Looking at your code snippet, I see it no different than:
EasyRandomParameters parameters = new EasyRandomParameters()
         .randomize(BigDecimal.class, new BigDecimalRandomizer(Integer.valueOf(3)));

Bean validation annotation handlers are mapped by annotations, not by field type (see here). So if you want to add support for @Digits, you should be able to extend BeanValidationRandomizerRegistry and map your custom randomizer to the @Digits annotation. Unfortunately, this is not possible with v4.2 because the field BeanValidationRandomizerRegistry#annotationHandlers is private. I changed it to protected in<PHONE_NUMBER>87e2ecf16bcc1fd890564b0c4d3fcd where you can find an example of the described approach.
Is this what you are looking for? If yes, you can give it try with 4.3.0-SNAPSHOT and share your feedback. Otherwise, please share an example of what you are trying to achieve. Thank you upfront!

I've made a RandomUtils class at some point, to restore some of the lost functionality that we've had with the excludedFields part:
static <T> T random(Class<T> type) and static <T> T random(Class<T> type, String... excludedFields), so using a CustomRandomizerRegistry seemed the best way to add some limits to the randomizers.
I've come to this one by inspecting the code, so before this conversation, wasn't sure if it's the right decision.
Regarding BeanValidationRandomizerRegistry, I probably didn't discover it, since it's in a different module, but also not all of our modules use it, so I would have wanted to use something more generic anyway.
The current code looks like this:
import org.jeasy.random.EasyRandom;
import org.jeasy.random.EasyRandomParameters;
import org.jeasy.random.FieldPredicates;
import org.jeasy.random.api.RandomizerRegistry;
import org.jeasy.random.randomizers.number.BigDecimalRandomizer;
import org.jeasy.random.randomizers.range.LongRangeRandomizer;
import org.jeasy.random.randomizers.registry.CustomRandomizerRegistry;

import java.math.BigDecimal;
import java.util.HashMap;
import java.util.HashSet;
import java.util.List;
import java.util.Map;
import java.util.Set;

import static java.util.Arrays.asList;
import static java.util.stream.Collectors.toList;
import static org.apache.commons.lang3.ArrayUtils.isEmpty;

public class RandomUtils {

	private static final RandomizerRegistry DEFAULT_REGISTRY;
	private static final EasyRandom RANDOM;
	private static final Map<Set<String>, EasyRandom> EXCLUDED_FIELDS_RANDOMS = new HashMap<>();

	static final long MIN_UNSIGNED_INT = 0L;
	static final long MAX_UNSIGNED_INT = Integer.MAX_VALUE * 2L + 1;

	private RandomUtils() {
		throw new IllegalStateException("Thou shalt not instantiate!");
	}

	static {
		CustomRandomizerRegistry registry = new CustomRandomizerRegistry();
		// we usually have a Long for the version property of DTOs and that's generated by JAXB for xs:unsignedInt, which actually is limited to these values
		registry.registerRandomizer(Long.class, new LongRangeRandomizer(MIN_UNSIGNED_INT, MAX_UNSIGNED_INT));
		// we usually use a scale of 3 for BigDecimal and since @Decimals is ignored, let's hardcode it here
		registry.registerRandomizer(BigDecimal.class, new BigDecimalRandomizer(3));

		DEFAULT_REGISTRY = registry;

		RANDOM = new EasyRandom(randomParameters());
	}

	public static EasyRandomParameters randomParameters() {
		return new EasyRandomParameters().randomizerRegistry(DEFAULT_REGISTRY);
	}

	public static <T> T random(Class<T> type) {
		return random(RANDOM, type);
	}

	public static <T> T random(Class<T> type, String... excludedFields) {
		return random(getRandom(excludedFields), type);
	}

	private static EasyRandom getRandom(String[] excludedFields) {
		if (isEmpty(excludedFields)) {
			return RANDOM;
		}

		return EXCLUDED_FIELDS_RANDOMS.computeIfAbsent(new HashSet<>(asList(excludedFields)), RandomUtils::buildEasyRandom);
	}

	private static EasyRandom buildEasyRandom(Set<String> excludedFields) {
		EasyRandomParameters parameters = randomParameters();
		for (String field : excludedFields) {
			parameters.excludeField(FieldPredicates.named(field));
		}
		return new EasyRandom(parameters);
	}

	public static <T> T random(EasyRandom random, Class<T> type) {
		return random.nextObject(type);
	}

        // this one was also lost in the fire
	public static <T> List<T> randomListOf(int amount, Class<T> type) {
		return RANDOM.objects(type, amount).collect(toList());
	}
}

I'll try your suggestion a bit later today, thank you 🙂

Thinking about your suggestion, I think there's still a problem that the annotation handlers don't get a reference to the existing EasyRandom instance or RandomizerRegistry and they create an internal one.

The test classes that I use looks something like:
class Amount {
@XmlElement(name = "Amount", required = true)
    @NotNull
    @Digits(integer = 12, fraction = 3)
    protected BigDecimal amount;
    @XmlElement(name = "Currency", required = true)
    @XmlSchemaType(name = "string")
    @NotNull
    // this is an enum
    protected Currency currency;
}
class DiscountEffect {
    @XmlElement(name = "Percentage")
    @Digits(integer = 6, fraction = 4)
    protected BigDecimal percentage;
    @XmlElement(name = "Amount")
    @Valid
    protected Amount amount;
    @XmlElement(name = "Quantity")
    @Digits(integer = 12, fraction = 3)
    protected BigDecimal quantity;
    @XmlElement(name = "SetSize")
    @NotNull
    @DecimalMax("65535")
    @DecimalMin("1")
    protected Integer setSize;
}
class Discount {
    @XmlElement(name = "DiscountEffects", required = true)
    @NotNull
    @Size(min = 1)
    @Valid
    protected List<DiscountEffect> discountEffects;
    // others too
    protected String href;
}

And it gets invoked as RandomUtils.random(Discount.class, "href")

Just stumbled upon this very issue: had a prepared EasyRandom instance with cusom randomizers specified through EasyRandomParameters in my test fixture and started to get randomization exceptions when trying to generate a bean validation annotated object graph for the fields that should be processed by the mentioned custom randomizers.
Checked out the code for some annotation handlers and was astonished to see that bean validation module completely ignores whatever was configured and instead just uses new EasyRandom instances in its annotation handlers. As if easy-random-bean-validation is just a separate project with no connection to the structure of the main one.
This is very counter-intuitive, since the wiki leaves a complete impression that upon adding the dependency the bean validation functionality will be added to a user's EasyRandom config, not replace it.
There should be a way to make any new EasyRandom instance share the same user-defined parameters and customRegistry.

@andrei-ivanov
It seems that you are passing the value 3 as a seed instead of a scaling here:
// we usually use a scale of 3 for BigDecimal and since @Decimals is ignored, let's hardcode it here
registry.registerRandomizer(BigDecimal.class, new BigDecimalRandomizer(3));

This should be:
registry.registerRandomizer(BigDecimal.class, new BigDecimalRandomizer(Integer.valueOf(3)));

Is this the cause of your issue?
Probably I'm missing something, but I'm not able to reproduce the issue based on my understanding. Here is a test that passes (while it should fail according to the issue description):
@Test
void customRegistryTest() {
    // given
    class Amount {
        @NotNull
        @Digits(integer = 12, fraction = 3)
        protected BigDecimal amount;
    }
    class DiscountEffect {
        @Digits(integer = 6, fraction = 4)
        protected BigDecimal percentage;
        protected Amount amount;
        @Digits(integer = 12, fraction = 3)
        protected BigDecimal quantity;
        @NotNull
        @DecimalMax("65535")
        @DecimalMin("1")
        protected Integer setSize;
    }

    CustomRandomizerRegistry registry = new CustomRandomizerRegistry();
    registry.registerRandomizer(BigDecimal.class, new BigDecimalRangeRandomizer(new Double(5d), new Double(10d), Integer.valueOf(3)));
    registry.registerRandomizer(Integer.class, new IntegerRangeRandomizer(5, 10));

    EasyRandomParameters parameters = new EasyRandomParameters()
            .randomizerRegistry(registry);
    EasyRandom easyRandom = new EasyRandom(parameters);

    // when
    DiscountEffect discountEffect = easyRandom.nextObject(DiscountEffect.class);

    // then
    assertThat(discountEffect).isNotNull();
    assertThat(discountEffect.percentage).isBetween(new BigDecimal("5.000"), new BigDecimal("10.000"));
    assertThat(discountEffect.quantity).isBetween(new BigDecimal("5.000"), new BigDecimal("10.000"));
    assertThat(discountEffect.amount.amount).isBetween(new BigDecimal("5.000"), new BigDecimal("10.000"));
    assertThat(discountEffect.setSize).isBetween(5, 10);
}

@andrei-ivanov @unconditional Can you please provide a failing test that reproduces the issue?

Hi,
Had to look closely again at the code, since I've forgotten what this thing was about 😀
Using your test above, add this snippet to the end:
class Discount {
	@NotNull
	@Size(min = 1)
	@Valid
	protected List<DiscountEffect> discountEffects;
}
Discount discount = easyRandom.nextObject(Discount.class);
assertThat(discount.discountEffects)
	.isNotEmpty()
	.allSatisfy(discountEffectElement -> {
		assertThat(discountEffectElement).isNotNull();
		assertThat(discountEffectElement.percentage).isBetween(new BigDecimal("5.000"), new BigDecimal("10.000"));
		assertThat(discountEffectElement.quantity).isBetween(new BigDecimal("5.000"), new BigDecimal("10.000"));
		assertThat(discountEffectElement.amount.amount).isBetween(new BigDecimal("5.000"), new BigDecimal("10.000"));
		assertThat(discountEffectElement.setSize).isBetween(5, 10);
	});

With this I get this kind of errors:
  <1DiscountEffect@b07ae662> error:
Expecting:
 <0.723174202997146853277854461339302361011505126953125>
to be between:
 [5.000, 10.000]

Thank you for your feedback, indeed the test fails with those changes.
Bean validation handlers have been made aware of custom registries and the test is now passing.
The fix has been deployed in 4.3.0-SNAPSHOT, and I would be grateful if you could give it a try and share your feedback before  the upcoming 4.3 release. Thank you.

Initial test with the dependencies defined like

<dependency>
    <groupId>org.jeasy</groupId>
    <artifactId>easy-random-core</artifactId>
    <version>${randombeans.version}</version>
</dependency>

<dependency>
    <groupId>org.jeasy</groupId>
    <artifactId>easy-random-bean-validation</artifactId>
    <version>${randombeans.version}</version>
    <exclusions>
        <!-- somehow the version cannot be overridden, so excluded it since it's not used anyway -->
        <exclusion>
            <groupId>org.yaml</groupId>
            <artifactId>snakeyaml</artifactId>
        </exclusion>
        <exclusion>
            <groupId>javax.validation</groupId>
            <artifactId>validation-api</artifactId>
        </exclusion>
    </exclusions>
</dependency>

<dependency>
    <groupId>jakarta.validation</groupId>
    <artifactId>jakarta.validation-api</artifactId>
    <optional>true</optional>
</dependency>

leads me to a missing dependency:
Caused by: java.lang.NoClassDefFoundError: org.apache.commons.beanutils.BeanIntrospector
	at org.jeasy.random.EasyRandom.doPopulateBean(EasyRandom.java:137)

Not sure how it worked before as I think this was required anyway 🙂
After adding the dependency manually, I see the test still fails with the same errors... not sure why.
The dependency tree shows it should use the new version:
[INFO] +- org.jeasy:easy-random-core:jar:4.3.0-SNAPSHOT:compile
[INFO] |  \- io.github.classgraph:classgraph:jar:4.8.65:compile
[INFO] +- org.jeasy:easy-random-bean-validation:jar:4.3.0-SNAPSHOT:compile
[INFO] |  \- org.jeasy:easy-random-randomizers:jar:4.3.0-SNAPSHOT:compile
[INFO] |     \- com.github.javafaker:javafaker:jar:1.0.2:compile
[INFO] |        \- com.github.mifmif:generex:jar:1.0.2:compile
[INFO] |           \- dk.brics.automaton:automaton:jar:1.11-8:compile
[INFO] +- jakarta.validation:jakarta.validation-api:jar:2.0.2:compile (optional)
[INFO] +- commons-beanutils:commons-beanutils:jar:1.9.4:runtime
[INFO] |  \- commons-collections:commons-collections:jar:3.2.2:runtime

With the final release everything seems fine :)
I think the snapshots had some weird issues somehow.
Thank you


Jenkins resources

Added more resources for Jenkins

@abhay-agarwal can you rebase on top of ea2? Looks like you are bringing unwanted changes.

Done.

Why don't we make this configurable with default values using options.json?

we'll make a JIRA task for it. For now, these additional resources are necessary.

So i'll test the JAVA_OPTS changes and add the options.json changes as well into this PR.

@jsancio I updated the reqs. Please push this urgent fix. I added a JIRA for Jenkins configurability

Make sure you cherry pick this and create a PR against master.


ExecStart line is wrong created at using Arguments

When field 'Arguments' is added to 'Config', the program adds double quotes to every argument.
Looking at '/etc/systemd/system/foo.service', in field 'ExecStart':
ExecStart=/usr/bin/food "-env dev" "-run"

instead of:
ExecStart=/usr/bin/food -env dev -run

This is in line with systemd docs. Is it not working?
Bug in your example, env and dev should be separate args.

I tried separating args., and the result is:
ExecStart=/usr/bin/food "-env" "" "-d"

It is not working; to do it, the line should be
ExecStart=/usr/bin/food -env dev -run

I changed manually the file and it works

Sorry! You had reason.


Override Cell component

Hello,
I would like to add a link to the rows in the table because I have a detail page and I would like to support normal link instead of js link, is it possible somehow to add div to all the cell in one time? something like the customRowRender but for the cells?
Also is it possible somehow to retrive the data object passed to the table from customBodyRender?
many thanks

Are you talking about hash links? I would assume you could use customBodyRender with something like this:
Row #1
And then later have a link that looked like this:
Goto row1

Also is it possible somehow to retrive the data object passed to the table from customBodyRender?

Use customBodyRenderLite instead. It'll have the dataIndex property which you can use to look up the data value.

many thanks, this solved my problem. I have just one more question, the table has an inner state? I would like to have an edit button that show some textfield on the selected row, actually I'm doing this with customBodyRender because the updateValue function but I have few problem that maybe can be solved using customBodyRenderLite, can I edit directly my datasource? the idea is edit and make a request, then I'm not sure if I can change the datasource or if it is better to refetch the entire datasource, but I think this is the next step....
Any chance there is already an example with a way to edit the fields of a single row?

can I edit directly my datasource?

You can, but the table will need to re-render for the effect to be noticed.

ok, I tried but even if it works is not a good solution because it takes too much to update the table...is it possible with customBodyRender to render something custom or customBodyRenderLite based on the rowIndex?

Yes? You can render whatever you want. You customBodyRenderLite provides you with a dataIndex, so you could update your external data, and then when displaying the data in the table use customBodyRenderLite to read from your external data.


domd: linux: Turn on options for rswitch offloaf capabilities

Signed-off-by: Dmitry Semenets<EMAIL_ADDRESS>

This patches were made for spider-0.8.5 branch when we had 2 different products - L3 offload S4 proddevel and PCI passthrough S4 proddevel.
Now we have one common product, that already have all of the required options configured. Thus, this PR is not longer needed.


Change language of the prompt depending on the language of the video

Would it be possible to change the fixed parts of the prompt (e.g. Title, Transcription, etc..) depending on the language of the video?
Thanks for this tool!

Thanks @vrodriguezf for asking!
I'll figure out what the best way for all is :)
Please stay tuned!
In the meantime, you can download and modify this code by yourself!

It may be good to put a custom prompt, ir order to prompt things in our languages, and prompts like"Write an essay about the video",  etc.

Thanks! Will add an option page that users can set their custom prompt format, dark mode, etc :)
Does that sound good?

yeah, It would be great

an option to disable the auto-sending of messages would also be great for fixing this issue.


[nri-bundle] kube-state-metrics Repo Archive Notice

⚠ kube-state-metrics Repo Archive Notice
As of Nov 13, 2020, charts in this repo will no longer be updated.
For more information, see the Helm Charts Deprecation and Archive Notice, and Update.
Additional context
Helm stable/kube-state-metircs

Upstream is in search for a new home for this chart: kubernetes/kube-state-metrics#1153

The chart now lives here: https://github.com/prometheus-community/helm-charts/tree/main/charts/kube-state-metrics


Changes debug builds with Intel to just -g

This gets rid of debug build warnings with Intel compilers.

FreeBSD build successful! See https://ci.trafficserver.apache.org/job/freebsd-github/1575/ for details.

Linux build successful! See https://ci.trafficserver.apache.org/job/linux-github/1469/ for details.

Intel CC build successful! See https://ci.trafficserver.apache.org/job/icc-github/8/ for details.

clang-analyzer build successful! See https://ci.trafficserver.apache.org/job/clang-analyzer-github/140/ for details.

Failed at
In file included from P_EventSystem.h(40),
                 from EventSystem.cc(31):
P_IOBuffer.h(697): error #1011: missing return statement at end of non-void function "IOBufferReader::operator[]"
  }
  ^

I can open another pull request to fix it.


UX bug fix: rank numbers being hidden

Changed the CSS for the ranking so it shows the full number, as intended. There were however alignment issues because
"1111" takes less space than
"8888" making the avatars mis align. The only way I think I can counter this without setting a width (which would lead back to the previous issue) is using a monospace font for these numbers. It's not optimal that the rank is using a different font, but I think that's the best solution in this case and preferable to a constant misalignment.

No it wouldnt only be with an increase in amount of characters. It would be
constant small differences mainyl because 1 isnt as wide as the others.
On Thu, 5 May 2022 at 19:09, Penar Musaraj @.***> wrote:

@.**** approved this pull request.
Let's try it. (Avatar misalignment wouldn't be a big deal, either IMO,
given it will be most visible only when going from 1 to 2 digits, 3 to 4
and so on.)
Also, should the Cheers numbers use monospace too, for consistency?
—
Reply to this email directly, view it on GitHub
https://github.com/discourse/discourse-gamification/pull/25#pullrequestreview-963699482,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AYI4R54Y4UOKEBJPWQUUHJTVIP6EZANCNFSM5VEZ5DFA
.
You are receiving this because you authored the thread.Message ID:
@.***>


[cucumber-react] Extract Cucumber-React to separate sub project

Extracting this to a separate npm module makes it possible to use the React component in other
projects (such as Cucumber Pro).
/cc @jbpros @romaingweb @mattwynne @tooky @sebrose any comments?

We (@romaingweb and me) made another branch , built on top of the one here, that suggests improvements in the imports. We were not sure if we should push the commit to the current PR, make a new one or ...?


Add onboarding library (new functionalities tour)

First check the possibilities of adding this new tool and test if it works/fits in the dashboard. If the outcome is positive, proceed to implementation.

The Intro.js library has been tested and integrated into the dashboard. This feature will be deployed when a new functionality requiring a tutorial is implemented or if we decide to add a tutorial to an existing one.


Roll engine 591144dfef59..b6b54fd60631 (1 commits)

git@github.com:flutter/engine.git/compare/591144dfef59...b6b54fd60631
git log 591144dfef59..b6b54fd60631 --no-merges --oneline
2019-11-23<EMAIL_ADDRESS>PR
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC<EMAIL_ADDRESS>on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Auto-roller completed checks. About to merge.


docs: add missing jsdoc

:tada: This PR is included in version 2.0.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


test: presto engine spec tests

SUMMARY
Increase coverage for presto db engine spec
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TEST PLAN

ADDITIONAL INFORMATION

[ ] Has associated issue:
[ ] Changes UI
[ ] Requires DB Migration.
[ ] Confirm DB Migration upgrade and downgrade tested.
[ ] Introduces new feature or API
[ ] Removes existing feature or API

Hey! Could you look at it? @willbarrett @dpgaspar

Hey! Could you look at it? @willbarrett @dpgaspar

Codecov Report

Merging #12594 (87dbbb7) into master (0f243c6) will decrease coverage by 5.99%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #12594      +/-   ##
==========================================
- Coverage   66.75%   60.75%   -6.00%
==========================================
  Files        1015      529     -486
  Lines       49634    19673   -29961
  Branches     4839     4847       +8
==========================================
- Hits        33131    11952   -21179
+ Misses      16380     7524    -8856
- Partials      123      197      +74

Flag
Coverage Δ

cypress
?

javascript
60.75% <ø> (+0.01%)
:arrow_up:

python
?

Flags with carried forward coverage won't be shown. Click here to find out more.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0f243c6...87dbbb7. Read the comment docs.

Codecov Report

Merging #12594 (87dbbb7) into master (0f243c6) will decrease coverage by 5.99%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #12594      +/-   ##
==========================================
- Coverage   66.75%   60.75%   -6.00%
==========================================
  Files        1015      529     -486
  Lines       49634    19673   -29961
  Branches     4839     4847       +8
==========================================
- Hits        33131    11952   -21179
+ Misses      16380     7524    -8856
- Partials      123      197      +74

Flag
Coverage Δ

cypress
?

javascript
60.75% <ø> (+0.01%)
:arrow_up:

python
?

Flags with carried forward coverage won't be shown. Click here to find out more.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0f243c6...87dbbb7. Read the comment docs.


The content is out of sync with the code.

Type of issue
Outdated article
Description
The code downloaded from the link below is out of sync with the document.
https://github.com/dotnet/AspNetCore.Docs.Samples/tree/main/fundamentals/minimal-apis/samples/MinApiTestsSample
See more information here:
https://github.com/chanmmn/issue/blob/main/Create a minimal API with ASP.docx
Page URL
https://learn.microsoft.com/en-us/aspnet/core/tutorials/min-web-api?view=aspnetcore-7.0&tabs=visual-studio
Content source URL
https://github.com/dotnet/AspNetCore.Docs/blob/main/aspnetcore/tutorials/min-web-api.md
Document Version Independent Id
ab408035-6313-a183-9940-32de00e0e977
Article author
wadepickett

@chanmmn ... Please re-open this issue using the This page feedback button and form at the bottom of the English-US topic. Use of the This page feedback form adds metadata to your GitHub issue that cross-links the topic and automatically pings the author.

@guardrex That feedback control is no longer used - this issue was created by the feedback control that replaced it. It provides the page URL, source URL, doc ID, and author in the issue description like the old one did.

Woe! ... so that's why we're not getting labeling on issues. ... and without an "@" on our author, we don't get a ping.
It's off topic here, so I'll email the team about it so I can ask some questions.

@chanmmn, thanks for taking the time to point this out.
I will look through the samples site example and update.
The samples specific to the tutorial and where its code examples are pulled from is located here and have been updated to .NET 8, and the previous versions are there as well: https://github.com/dotnet/AspNetCore.Docs/tree/main/aspnetcore/tutorials/min-web-api/samples
So we could also help make that discoverable.


Null Reference Exception from ControllerActionInvoker Middleware

An unhandled exception occurs very rarely in this WebApp hosted in Kestrel.
I have attached a section of the stacktrace -  anything in between is just rethrowing of the exception.
Please let me know if this is an issue inside Mvc or if I should be handling it elsewhere.
 Microsoft.AspNetCore.Diagnostics.ExceptionHandlerMiddleware
	An unhandled exception has occurred: Object reference not set to an instance of an object.
	System.NullReferenceException: Object reference not set to an instance of an object.
    at lambda_method(Closure , Object , Object[] )
	at Microsoft.AspNetCore.Mvc.Internal.ControllerActionInvoker.<InvokeActionMethodAsync>d__27.MoveNext()
	--- End of stack trace from previous location where exception was thrown ---
    at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
	at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
	at Microsoft.AspNetCore.Mvc.Internal.ControllerActionInvoker.<InvokeNextActionFilterAsync>d__25.MoveNext()
	--- End of stack trace from previous location where exception was thrown ---
	at Microsoft.AspNetCore.Mvc.Internal.ControllerActionInvoker.Rethrow(ActionExecutedContext context)
	at Microsoft.AspNetCore.Mvc.Internal.ControllerActionInvoker.Next(State& next, Scope& scope, Object& state, Boolean& isCompleted)
	at Microsoft.AspNetCore.Mvc.Internal.ControllerActionInvoker.<InvokeNextResourceFilter>d__22.MoveNext()
	--- End of stack trace from previous location where exception was thrown ---
	at Microsoft.AspNetCore.Mvc.Internal.ControllerActionInvoker.Rethrow(ResourceExecutedContext context)
	at Microsoft.AspNetCore.Mvc.Internal.ControllerActionInvoker.Next(State& next, Scope& scope, Object& state, Boolean& isCompleted)
	at Microsoft.AspNetCore.Mvc.Internal.ControllerActionInvoker.<InvokeAsync>d__20.MoveNext()
	--- End of stack trace from previous location where exception was thrown ---
	at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
	at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
	at Microsoft.AspNetCore.Builder.RouterMiddleware.<Invoke>d__4.MoveNext()
	--- End of stack trace from previous location where exception was thrown ---

...more stuff...
 --- End of stack trace from previous location where exception was thrown ---
	at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
	at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
	at Microsoft.AspNetCore.Diagnostics.ExceptionHandlerMiddleware.<Invoke>d__6.MoveNext()Null'

@oofpez do you have anymore info on how to reproduce this?
@rynowak any idea what this could be?

That's this code https://github.com/aspnet/Mvc/blob/rel/1.1.2/src/Microsoft.AspNetCore.Mvc.Core/Internal/ControllerActionInvoker.cs#L1233
What comes to mind is if there is some kind of crazy unanticipated method signature.
Sporadic says that either there's one rarely used method that's causing issues or it's a race condition

Actually, I spaced on this part lambda_method(Closure , Object , Object[] ) - that's the generated expression thunk we use to call the controller method.

I can't reproduce it, I only got this error occasionally when running parallel integration tests on some compression middleware.  It might be some kind of race condition?
The error is rethrown at  await _next(context) where _next is the RequestDelegate.
            using (var buffer = new MemoryStream())
            {
                var body = context.Response.Body;
                context.Response.Body = buffer;

                try
                {
                    await _next(context);

                    using (var compressed = new MemoryStream())
                    {
                        using (var gzip = new GZipStream(compressed, CompressionLevel.Optimal, leaveOpen: true))
                        {
                            buffer.Seek(0, SeekOrigin.Begin);
                            await buffer.CopyToAsync(gzip);
                        }

                        context.Response.Headers.Add(ContentEncodingName, new[] { GzipEncodingType });

                        if (context.Response.Headers[ContentLengthName].Count > 0)
                        {
                            context.Response.Headers[ContentLengthName] = compressed.Length.ToString();
                        }

                        compressed.Seek(0, SeekOrigin.Begin);
                        await compressed.CopyToAsync(body);
                    }
                }
                finally
                {
                    context.Response.Body = body;
                }
            }

Getting same exception:
<IP_ADDRESS>  GET /file/163423/ - An unhandled exception has occurred: Object reference not set to an instance of an object. System.NullReferenceException: Object reference not set to an instance of an object.
   at lambda_method(Closure , Object , Object[] )
   at Microsoft.AspNetCore.Mvc.Internal.ControllerActionInvoker.<InvokeActionMethodAsync>d__27.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.ValidateEnd(Task task)
   at Microsoft.AspNetCore.Mvc.Internal.ControllerActionInvoker.<InvokeNextActionFilterAsync>d__25.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at Microsoft.AspNetCore.Mvc.Internal.ControllerActionInvoker.Rethrow(ActionExecutedContext context)
   at Microsoft.AspNetCore.Mvc.Internal.ControllerActionInvoker.Next(State& next, Scope& scope, Object& state, Boolean& isCompleted)
   at Microsoft.AspNetCore.Mvc.Internal.ControllerActionInvoker.<InvokeNextResourceFilter>d__22.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at Microsoft.AspNetCore.Mvc.Internal.ControllerActionInvoker.Rethrow(ResourceExecutedContext context)
   at Microsoft.AspNetCore.Mvc.Internal.ControllerActionInvoker.Next(State& next, Scope& scope, Object& state, Boolean& isCompleted)
   at Microsoft.AspNetCore.Mvc.Internal.ControllerActionInvoker.<InvokeAsync>d__20.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.ValidateEnd(Task task)
   at Microsoft.AspNetCore.Builder.RouterMiddleware.<Invoke>d__4.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.ValidateEnd(Task task)
   at Site.Web.Security.CookieAuthenticationMiddleware.<Invoke>d__6.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.ValidateEnd(Task task)
   at Site.Web.Security.ApiKeyAuthenticationMiddleware.<Invoke>d__6.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.ValidateEnd(Task task)
   at Microsoft.AspNetCore.Diagnostics.StatusCodePagesMiddleware.<Invoke>d__3.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.ValidateEnd(Task task)
   at Microsoft.AspNetCore.Diagnostics.ExceptionHandlerMiddleware.<Invoke>d__6.MoveNext()

Occurs randomly when executing random action. One of such actions looks like this:
[ HttpGet ]
[ Route("file/{file_id:int:required}") ]
public async Task<IActionResult> Default(int file_id, int snapshot_id = 0, string note = null) {
    ...
    return View("Default", model);
}

Maybe at ControllerActionInvoker.InvokeActionMethodAsync controller is null or became null somehow before calling
result = _executor.Execute(controller, orderedArguments);

or
result = await _executor.ExecuteAsync(controller, orderedArguments);

BTW using autofac as IServiceProvider but is seems no matter because controller is being created by DefaultControllerActivator

I suspect that the issue here is in https://github.com/aspnet/Mvc/blob/rel/1.1.2/src/Microsoft.AspNetCore.Mvc.Core/Internal/ObjectMethodExecutor.cs#L219

Keeping this bug to track the 2.0.0 issue, will add separate issues to port the fix to 1.0.X and 1.1.X

Can we expect a release in the 1.1.x cycle with this fix very soon?

@elangelo we are working to get this into our next patch release; no ETA on that right now unfortunately. But we're hoping for next month (there are several bug fixes we want to get in).


Crash when interacting with Advanced Rocketry Rocket Inventory

Mod Version:
DynamicSurroundings-1.12.2-<IP_ADDRESS>
OreLib-1.12.2-<IP_ADDRESS>
Forge Version:
<IP_ADDRESS>38
Link to client log:
https://paste.dimdev.org/ebuveneroz.rb
Link to crash log:
https://paste.dimdev.org/azerotumiq.mccrash
Description:
The client crashes when opening Advanced Rocketry's Satellite Bay on a built rocket's inventory to insert a packed space station, or the Guidance Computer to insert a Station Chip.  I am playing on the FTB Interactions modpack hosted on my own private server, using Advanced Rocketry version 1.5.0-139 and the latest version of Dynamic Surroundings.  I am also using VanillaFix, so the game doesn't crash to desktop, it just boots me out to the main menu.  The client is the only thing crashing, the server console does not seem to register any error stack traces.  I'm not sure if the  issue is related to DS or Advanced Rocketry, but the stack trace mentions dsurround directly so I thought I'd start here.  Let me know if I need to open an issue on the Adv Rocketry issue tracker instead.

Taking a look at this.  On the surface it looks to be a bug in Advanced Rocketry.  They are doing some weird things with worlds.  You can see from the trace where my capability handler is being spammed for some reason.

Maybe related to Advanced Rocketry temporarily switching the player to a temp world? https://github.com/Advanced-Rocketry/AdvancedRocketry/issues/1509#issuecomment-460113408


Encryption of actor state

Please consider supporting actor state encryption, actor state may have confidential or personal data that requires to be secured at rest and in transit by regional laws.  Dapr actor state should be encrypted when persisted or set over the wire to a node within the cluster using removing so to protect data for unauthorised parties and wiring sniffing

Thanks for starting a discussion @grahamehorner - if you're interested in this topic, it might be better to start a discussion on dapr/dapr - because it seems unlikely to me that we're going implement an encryption feature inside the .NET SDK.
Dapr already supports mutual TLS for data exchanged between sidecars, and many state stores will already have encryption at rest built in.
If there are any changes needed for Dapr to meet compliance requirements, the work is likely to originate from the runtime layer so that features can:

Apply to any language, including those without a rich SDK
Share as much of the implementation/behavior as possible

Thanks for starting a discussion @grahamehorner - if you're interested in this topic, it might be better to start a discussion on dapr/dapr - because it seems unlikely to me that we're going implement an encryption feature inside the .NET SDK.
Dapr already supports mutual TLS for data exchanged between sidecars, and many state stores will already have encryption at rest built in.
If there are any changes needed for Dapr to meet compliance requirements, the work is likely to originate from the runtime layer so that features can:

Apply to any language, including those without a rich SDK
Share as much of the implementation/behavior as possible

@rynowak Can we move this to dapr/dapr repo?

This is tracked in https://github.com/dapr/dapr/issues/1090

Closing

Maybe this can be closed.

Yup. ideally this is implemented in dapr runtime and the SDKs dont' need to do any work for you to use it.


is there any 3d model of the board to run on fusion360?

I'm wondering if there's any 3d model of the super6c board in order to use as a reference to build my own case?

sorry, there is no 3D model of the super6c board.


Encrypt keys in repo for GitHub actions CI

https://help.github.com/en/actions/configuring-and-managing-workflows/creating-and-storing-encrypted-secrets

I haven't got time to read that right now. I'll pick this up tomorrow.
Regards,
Bernard T. A. Baker
On Fri, Apr 17, 2020 at 8:14 PM un7c0rn<EMAIL_ADDRESS>wrote:

https://help.github.com/en/actions/configuring-and-managing-workflows/creating-and-storing-encrypted-secrets
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/un7c0rn/stopthevirus/issues/53, or unsubscribe
https://github.com/notifications/unsubscribe-auth/ADHNTTDXSX6RGYHWHFJP3CLRNCTA3ANCNFSM4MK7HNZQ
.


The tool is validating invalid SPDX documents

While generating spdx json documents from Tern, @maxhbr found a bug in the Tern SPDX JSON document that was not caught by the latest tools-java-1.0.2-jar-with-dependencies.jar release. He found the bug using jsonschema validation.
$ jsonschema -i tern.spdx.json  spdx-schema.json
Tool: tern-2.8.0: 'Tool: tern-2.8.0' is not of type 'array'
false: 'false' is not of type 'boolean'
true: 'true' is not of type 'boolean'
{'name': 'layer.tar', 'SPDXID': 'SPDXRef-0b40512829', 'fileName': '50445ea47417946f2e6f276a78dcf8 [...] , 'LicenseRef-884dc06']}: Additional properties are not allowed ('fileName' was unexpected)
false: 'false' is not of type 'boolean'
None: None is not of type 'string'

Specifically missed errors in the document (more details here):

creators is a string and not an array
filesAnalyzed is a "false" string instead of a boolean
One package name was using the fileName key but it should be packageFileName
Some package names are null instead of a string

I will fix this in Tern but also wanted to raise the issue here since we use this tooling suite to verify our documents are valid when we make changes to them.

Thanks @rnjudge for raising this issue.
Can you attach a JSON file which should have failed?
I was just working on some other validation related issues and it would be an ideal time to address these as well.

I have uploaded the JSON file generated with tern: tern.spdx.json.gz

Resolved with PR #37


Feature: optimize pan zoom

🚀 [ Resolves #88 ]
🚀 [ Resolves #90 ]
Preview

Without optimization (1 million pixels)
https://github.com/hunkim98/dotting/assets/57612141/8ec6c6cf-ff88-4001-9cfa-60b70d307622
With optimization (1 million pixels)
https://github.com/hunkim98/dotting/assets/57612141/9ecb0122-5e91-431a-a5f9-c425a87d7539

Changes

Optimize panning and zooming using Offscreen Canvas

[🎨Component] Use Offscreen Canvas for creating image bitmap when user has modified the grid canvas

Previously, changing offset of zoom scale called our render function. This inevitably made our component run through a nested loop everytime there is a slight change in offset or zoom scale
I found it unnecessary to call a nested for loop everytime we do a render.
I came up with an idea to create an image bitmap once a user's interaction finishes. Then I used that image bitmap when the user pans or zooms.
This highly upgraded the performance of panning or zooming for 1 million pixels!

Notes

There seems to be some lag at the moment user finishes interacting with the grid canvas. Maybe we should take a look into that issue

Next Up?

With this optimization, I believe we could try building Photoshop from scratch?🙀 @Lee-Si-Yoon @lerrybe

@Lee-Si-Yoon I have attempted to implement Worker logic to our Dotting. However, there were many synchronization problems due to the library having multiple canvases. Worker logic is asynchronous and thus, it seemed that many of our canvases did not sync together. Thus I decided to discard the Worker logic and stick to our original version of simply rendering all by javascript logic.
In the future, I believe implement worker logic will be impossible for Dotting due to its design of having multiple canvases 😥

@Lee-Si-Yoon I have attempted to implement Worker logic to our Dotting. However, there were many synchronization problems due to the library having multiple canvases. Worker logic is asynchronous and thus, it seemed that many of our canvases did not sync together. Thus I decided to discard the Worker logic and stick to our original version of simply rendering all by javascript logic.
In the future, I believe implement worker logic will be impossible for Dotting due to its design of having multiple canvases 😥

However I do believe we can add a worker logic to the DataLayer render where it renders through all the rows and data. However, I believe that is another issue unrelated with optimizing pan zoom, so I will not add any code using worker logic in this PR

I agree that implementing worker api is out of scope for this PR. Nice job let's merge this

discussed offline about capturedImageBitmapScale getting not initialized
just one last complain with responsibility, do we have to create fake canvas every time when onInteractionEnded is called

I agree that implementing worker api is out of scope for this PR. Nice job let's merge this

discussed offline about capturedImageBitmapScale getting not initialized
just one last complain with responsibility, do we have to create fake canvas every time when onInteractionEnded is called

I fixed the issue of capturedImageBtimapScale not being set correctly. Regarding creating fake canvas every time onInteractionEnded is called, I believe the logic would be more complex if we tried to separate parts for updating fake canvas and rendering pixel squares in them. Instead, I selectively rendered data layer and updated captured image only when data has been changed!


Bug 1765550: Set OSD memory limits and add config map

This change increases the memory limit for OSDs to 8GiB
and sets the memory usage cgroup limit for OSDs to 0.5.
Co-authored-by: Jose A. Rivera<EMAIL_ADDRESS>Signed-off-by: Elise Gafford<EMAIL_ADDRESS>

/cherry-pick approve


fix: Missing tagclass objects

This PR aims to close #9 and depends on https://github.com/SolidBench/rdf-dataset-fragmenter.js/pull/17 . Notice: normal blank nodes get inserted into the same file. This is not possible for the tagclass-typed objects because the objects get referenced from multiple files. To get the same semantics as with the SNB ttl file, I suggest to translate the blank node to a named one.

To finish this PR I should also change the graph in the readme. @rubensworks could you provide me with the source code of that graph?

I just realized it is part of another repository, and I don't know if I am confident enough to change it there. I can open this PR however :D

Could you also bump rdf-dataset-fragmenter here? CI will fail without it.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
116

Relevant Lines:
116

💛  - Coveralls


qemu: 2.2.1 ->  2.4.0

cc @viric @edolstra

try running NixOS tests with it.

Building the gnome3 nixos test:
install -d -m 0755 "/var"/run
install: cannot create directory '/var': Permission denied
Makefile:415: recipe for target 'install-localstatedir' failed
make: *** [install-localstatedir] Error 1
builder for ‘/nix/store/jlgxi0bnpm2s8hhk2a97h9c4aqr7dn14-qemu-2.4.0-x86-only.drv’ failed with exit code 2

Fixed with Bevaz/nixpkgs@0e0e3c0c08b77a64fc934795dc5d9647fbd58d42

Did run a couple of nixos tests and it seems to work fine. Let's see how it goes, thanks. cc @edolstra


Generate streamlined analysis workfile (CSV) from SCIO-DB

A streamlined CSV workfile will be very useful for SCA planning. The columns we need are listed below by SCTK runtime option using current SCTK CSV output column names. If there are multiple values in a JSON field we want all of the values in one cell ("flattened").
Info:
Resources:
type
name
base_name
extension
size
sha1
mime_type
file_type
programming_language
Copyrights:
copyright
copyright_holder
author
Licenses:
license_expression
license__key
license__score
license__category
license__owner
email
url
Packages:
package__type
package__namespace
package__name
package__version
package__primary_language
package__description
package__release_date
package__homepage_url
package__download_url
package__size
package__sha1
package__vcs_url
package__copyright
package__license_expression
package__declared_license
package__notice_text

@JonoYang has written this utility: https://github.com/nexB/spats/blob/develop/src/spats/scanpipe_results_to_xlsx.py that "flattens" the data how we normally expect it (\n characters separating multiple values) and supports package data.
@mjherzog I believe we want to support package data as well? This is on our normal work file alongside regular scancode detections.

@majurg My mistake to forget about packages. I updated the main text above with selected package fields.

The list of fields requested is my take on what is most useful for planning and simpler analysis tasks. My working assumption is that there will be other CSV workfile output variations.

Closing as the existing XLSX output should be used instead.


[Visibility] Fixed issue with infinite scrolling not triggering onBottomVisible

Visibility module was incorrectly using topPassed to determine if bottomVisible. It should use bottomPassed when making this determination.
Broken Fiddle Example: http://jsfiddle.net/miketalley/y1bu3Le0/
Working Fiddle Example: http://jsfiddle.net/miketalley/f6khxwqb/

Resolves #5289.

Can this get merged in the next minor release?  This basically breaks the entire component and it has been 4 months.  I have been waiting for the next minor release and was sad not to see this get merged in for 2.2.11.

I agree, please merge this into the next release.

Any news on this?
We'd greatly appreciate having this request merged into sUI.

Updated fiddles and fixed merge conflict.

Hi, this was fixed in https://github.com/Semantic-Org/Semantic-UI/commit/3bbaf137b575c660af12cc89d6b811a8ae15cb8c
The two JSfiddle from your first post are both working.
I notice the logic differs in our two fixes. I think the one in 3bbaf137b575c660af12cc89d6b811a8ae15cb8c is correct, as topVisible is specifically related to whether it is still on screen.


Analysis (DE and EN): Text adjustments

Some text adjustments for clarification.

@HelTob
I also noticed the typo that @larswmh mentioned so I used the Spell Right spell checker in VS Code and there is another typo in the file
https://github.com/corona-warn-app/cwa-website/blob/6fff7a3720a068dc73b408b116512337799cf1e1/src/data/analyse_en.json#L7
"calender" should be "calendar" in English. Maybe you could correct this line as well?

For future PRs it is better for git handling if you create a new branch in your fork for changes and not make the changes directly in your master branch. See https://github.com/corona-warn-app/cwa-website/blob/master/CONTRIBUTING.md#pull-request-checklist.
The checklist also recommends squashing commits if you make corrections to the same file. If you do that you do need to force push to GitHub afterwards.

@MikeMcC399 Thank you very much for your comment.
I tried to create a new branch in my fork and add the changes but it seems like I made something wrong and accidentally created a new PR (#2964).
Best regards
Tobias

@HelTob

You could close this PR #2963 and use only the new PR #2964 since it now covers all your changes.
If you do that, you would probably want to rename #2964.

@MikeMcC399
Thanks again, Mike. I will educate myself about not making changes directly in my master and squashing commits.
Best regards,
Tobias


Update Istio documentation with monitoring/tracing stuff

@feitnmore has added a bunch of great content on Istio/Ambassador, which can be the impetus for a refactoring of the documentation. Here's what he's written:
https://github.com/feitnomore/ambassador-istio
The current docs are at https://www.getambassador.io/user-guide/with-istio.
My thoughts on a new outline are:

Background (use current content)
Installing Istio & Ambassador (link to  https://www.getambassador.io/user-guide/install & the Istio equivalent) ... we should just have people start with the standard install. This reduces our doc maintenance.
Subsection on istio sidecar injection (since this is in the default config)
Then we have sections which add new configuration to the Ambassador / Istio config, bit by bit. Each section should have a clear purpose/goal. So something like:

Configuring Monitoring. In this section, I'd add the prom-statsd-exporter, the Ambassador monitor service, the Prometheus/Istio ConfigMap, etc. All this should go into this section so if the end user wants to enable monitoring, it's all in one place.
Configuring Grafana.
Configuring Tracing. Similar to the above.
Configuring mTLS. We can copy-and-paste the existing section for now.

What do you think?

I'll try to edit the document and we can see how it looks like.

I've made a copy of the docs and updated it. Available here:
https://github.com/feitnomore/ambassador-istio/blob/master/datawire-doc/with-istio-new.md

Done in https://github.com/datawire/ambassador/pull/734


Source code mistmatch

The code snippets 2 and 3, under "Write code to receive messages from the queue", do not match the code later under "Here is what your Program.cs file should look like:". Looks like the author refactored the code and didn't edit both areas to match.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 217f29ba-3552-f406-58d3-d2e0c3bd4d2c
Version Independent ID: 003342a6-6fc5-fae4-31f4-369b561cfd89
Content: Get started with Azure Service Bus queues
Content Source: articles/service-bus-messaging/service-bus-dotnet-get-started-with-queues.md
Service: service-bus-messaging
GitHub Login: @axisc
Microsoft Alias: aschhab

@dan80386 Thank you for your feedback! We will review and update as appropriate.

@dan80386 Thanks for reporting this and helping us drive improvements towards MS Docs! I've created a PR that updates step #2 and #3 to consistent with the full sample and the changes should be live shortly after my PR merges.
We will now proceed to close this thread. If there are further questions regarding this matter, please reopen it and we will gladly continue the discussion.