Unable to install the inplace_abn library due to CUDA error

Hi! Thanks for this repo. I am unable to install the inplace_abn library that is required to train your models. I have tried many ways to install and debug but it still shows the CUDA error. error: command '/usr/bin/nvcc' failed with exit status 1. Is it possible to train the model without using this library by making a few changes in the code?

Which branch do you use? master or pytorch-1.1.
And what's your Pytorch version, Cuda version?

Thanks for the reply. I downloaded the pytorch 1.1 branch and the versions in my local system are:
pytorch 1.2.0
torchvision 0.4.0
CuDNN 7.6.0
CudaToolkit 10.0.130

The versions are ok for compiling.
Can you post the detailed error message?

Sure, I will recompile now and post it here.

I installed the inplace_abn using pip and I got the following error. The complete stack trace is extremely very long. Here is the last 55 lines of the trace.
/usr/include/c++/6/tuple: In instantiation of ‘static constexpr bool std::_TC<<anonymous>, _Elements>::_NonNestedTuple() [with _SrcTuple = const std::tuple<at::Tensor&, at::Tensor&, at::Tensor&>&; bool <anonymous> = true; _Elements = {at::Tensor&, at::Tensor&, at::Tensor&}]’:
  /usr/include/c++/6/tuple:662:419:   required by substitution of ‘template<class ... _UElements, class _Dummy, typename std::enable_if<((std::_TC<(1ul == sizeof... (_UElements)), at::Tensor&, at::Tensor&, at::Tensor&>::_ConstructibleTuple<_UElements ...>() && std::_TC<(1ul == sizeof... (_UElements)), at::Tensor&, at::Tensor&, at::Tensor&>::_ImplicitlyConvertibleTuple<_UElements ...>()) && std::_TC<(std::is_same<_Dummy, void>::value && (1ul == 1)), at::Tensor&, at::Tensor&, at::Tensor&>::_NonNestedTuple<const tuple<_Elements ...>&>()), bool>::type <anonymous> > constexpr std::tuple< <template-parameter-1-1> >::tuple(const std::tuple<_Args1 ...>&) [with _UElements = {at::Tensor&, at::Tensor&, at::Tensor&}; _Dummy = void; typename std::enable_if<((std::_TC<(1ul == sizeof... (_UElements)), at::Tensor&, at::Tensor&, at::Tensor&>::_ConstructibleTuple<_UElements ...>() && std::_TC<(1ul == sizeof... (_UElements)), at::Tensor&, at::Tensor&, at::Tensor&>::_ImplicitlyConvertibleTuple<_UElements ...>()) && std::_TC<(std::is_same<_Dummy, void>::value && (1ul == 1)), at::Tensor&, at::Tensor&, at::Tensor&>::_NonNestedTuple<const tuple<_Elements ...>&>()), bool>::type <anonymous> = <missing>]’
  /home/sainatarajan/anaconda3/envs/tf_gpu/lib/python3.7/site-packages/torch/include/ATen/Functions.h:4128:229:   required from here
  /usr/include/c++/6/tuple:495:244: error: wrong number of template arguments (4, should be 2)
         return  __and_<__not_<is_same<tuple<_Elements...>,
                                                                                ^
  /usr/include/c++/6/type_traits:1558:8: note: provided for ‘template<class _From, class _To> struct std::is_convertible’
       struct is_convertible
          ^~~~~~~~~~~~~~
  /usr/include/c++/6/tuple:502:1: error: body of constexpr function ‘static constexpr bool std::_TC<<anonymous>, _Elements>::_NonNestedTuple() [with _SrcTuple = const std::tuple<at::Tensor&, at::Tensor&, at::Tensor&>&; bool <anonymous> = true; _Elements = {at::Tensor&, at::Tensor&, at::Tensor&}]’ not a return-statement
       }
   ^
  /usr/include/c++/6/tuple: In instantiation of ‘static constexpr bool std::_TC<<anonymous>, _Elements>::_NonNestedTuple() [with _SrcTuple = std::tuple<at::Tensor&, at::Tensor&, at::Tensor&>&&; bool <anonymous> = true; _Elements = {at::Tensor&, at::Tensor&, at::Tensor&}]’:
  /usr/include/c++/6/tuple:686:422:   required by substitution of ‘template<class ... _UElements, class _Dummy, typename std::enable_if<((std::_TC<(1ul == sizeof... (_UElements)), at::Tensor&, at::Tensor&, at::Tensor&>::_MoveConstructibleTuple<_UElements ...>() && std::_TC<(1ul == sizeof... (_UElements)), at::Tensor&, at::Tensor&, at::Tensor&>::_ImplicitlyMoveConvertibleTuple<_UElements ...>()) && std::_TC<(std::is_same<_Dummy, void>::value && (1ul == 1)), at::Tensor&, at::Tensor&, at::Tensor&>::_NonNestedTuple<tuple<_Elements ...>&&>()), bool>::type <anonymous> > constexpr std::tuple< <template-parameter-1-1> >::tuple(std::tuple<_Args1 ...>&&) [with _UElements = {at::Tensor&, at::Tensor&, at::Tensor&}; _Dummy = void; typename std::enable_if<((std::_TC<(1ul == sizeof... (_UElements)), at::Tensor&, at::Tensor&, at::Tensor&>::_MoveConstructibleTuple<_UElements ...>() && std::_TC<(1ul == sizeof... (_UElements)), at::Tensor&, at::Tensor&, at::Tensor&>::_ImplicitlyMoveConvertibleTuple<_UElements ...>()) && std::_TC<(std::is_same<_Dummy, void>::value && (1ul == 1)), at::Tensor&, at::Tensor&, at::Tensor&>::_NonNestedTuple<tuple<_Elements ...>&&>()), bool>::type <anonymous> = <missing>]’
  /home/sainatarajan/anaconda3/envs/tf_gpu/lib/python3.7/site-packages/torch/include/ATen/Functions.h:4128:229:   required from here
  /usr/include/c++/6/tuple:495:244: error: wrong number of template arguments (4, should be 2)
         return  __and_<__not_<is_same<tuple<_Elements...>,
                                                                                ^
  /usr/include/c++/6/type_traits:1558:8: note: provided for ‘template<class _From, class _To> struct std::is_convertible’
       struct is_convertible
          ^~~~~~~~~~~~~~
  /usr/include/c++/6/tuple:502:1: error: body of constexpr function ‘static constexpr bool std::_TC<<anonymous>, _Elements>::_NonNestedTuple() [with _SrcTuple = std::tuple<at::Tensor&, at::Tensor&, at::Tensor&>&&; bool <anonymous> = true; _Elements = {at::Tensor&, at::Tensor&, at::Tensor&}]’ not a return-statement
       }
   ^
  error: command '/usr/bin/nvcc' failed with exit status 1
  ----------------------------------------
  ERROR: Failed building wheel for inplace-abn
  Running setup.py clean for inplace-abn
Failed to build inplace-abn

I'm not sure how to solve this issue. But there is the same error which caused by the higher gcc version. https://github.com/open-mmlab/mmdetection/issues/422
Hope it helps.

@speedinghzl I just saw the requirements and found that it needs 4x12 GB GPU's. I thought to try CCNet and it was the same case there too =). I currently have only one 12 GB RTX 2080 Ti and I think it's not possible for me to run this model. Thanks for your help. I will close this issue now.


Candidates missing in the viewer

My candidates consist of a relation between a person and a number. So if I have 3 persons and 4 numbers in a sentence, I would expect there to be 12 candidates. Unfortunately the viewer didn't let me label all 12 combinations, only some of them. All persons and numbers were marked yellow, so all of them were at least part of one relation. When I deleted the database and started again, the viewer let me label different candidates than before, but again some were missing. Do you have an idea why that happens?

Hi @JoMynta sorry for the delayed response!
A few questions:

Are the relation mentions in the same sentence (by default we only extract intra-sentence candidates)?
If you get the length of the candidate set you're feeding into the viewer, is it 12 (i.e. is this a Viewer issue or an extractor issue)?

If you have a code snippet / example notebook that's helpful too!
Thanks,
Alex

Hi Alex,

the relation mentions are in the same sentence
the NER labels the numbers as numbers and the persons as persons
the problem is not in the viewer but with candidate extraction, the viewer shows all candidates that are extracted
if I delete the database and run the notebook again, I get different candidates, although there seems to be a pattern

This is my test sentence and the candidates I get:

This is a test sentence including Joe Brown, age 40, and his wife Jane, 35, and their daughter Mary (7), and an additional number 12.

First run:

Age(Span("Joe Brown", sentence=2, chars=[34,42], words=[6,7]), Span("40", sentence=2, chars=[49,50], words=[10,10]))
Age(Span("Joe Brown", sentence=2, chars=[34,42], words=[6,7]), Span("12", sentence=2, chars=[130,131], words=[31,31]))
Age(Span("Joe Brown", sentence=2, chars=[34,42], words=[6,7]), Span("35", sentence=2, chars=[72,73], words=[17,17]))
Age(Span("Joe Brown", sentence=2, chars=[34,42], words=[6,7]), Span("7", sentence=2, chars=[101,101], words=[24,24]))
Age(Span("Jane", sentence=2, chars=[66,69], words=[15,15]), Span("12", sentence=2, chars=[130,131], words=[31,31]))
Age(Span("Jane", sentence=2, chars=[66,69], words=[15,15]), Span("35", sentence=2, chars=[72,73], words=[17,17]))
Age(Span("Jane", sentence=2, chars=[66,69], words=[15,15]), Span("7", sentence=2, chars=[101,101], words=[24,24]))
Age(Span("Mary", sentence=2, chars=[95,98], words=[22,22]), Span("35", sentence=2, chars=[72,73], words=[17,17]))
Age(Span("Mary", sentence=2, chars=[95,98], words=[22,22]), Span("7", sentence=2, chars=[101,101], words=[24,24]))

Second run:

Age(Span("Jane", sentence=2, chars=[66,69], words=[15,15]), Span("35", sentence=2, chars=[72,73], words=[17,17]))
Age(Span("Jane", sentence=2, chars=[66,69], words=[15,15]), Span("7", sentence=2, chars=[101,101], words=[24,24]))
Age(Span("Jane", sentence=2, chars=[66,69], words=[15,15]), Span("40", sentence=2, chars=[49,50], words=[10,10]))
Age(Span("Jane", sentence=2, chars=[66,69], words=[15,15]), Span("12", sentence=2, chars=[130,131], words=[31,31]))
Age(Span("Mary", sentence=2, chars=[95,98], words=[22,22]), Span("7", sentence=2, chars=[101,101], words=[24,24]))
Age(Span("Mary", sentence=2, chars=[95,98], words=[22,22]), Span("40", sentence=2, chars=[49,50], words=[10,10]))
Age(Span("Mary", sentence=2, chars=[95,98], words=[22,22]), Span("12", sentence=2, chars=[130,131], words=[31,31]))
Age(Span("Joe Brown", sentence=2, chars=[34,42], words=[6,7]), Span("40", sentence=2, chars=[49,50], words=[10,10]))
Age(Span("Joe Brown", sentence=2, chars=[34,42], words=[6,7]), Span("12", sentence=2, chars=[130,131], words=[31,31]))

I also attached the notebook to this example:
joebrownexample.zip

Hi @JoMynta thanks so much for the notebook and for pointing this out!  Merging in a fix as soon as passes review.  In mean time, note you can also sidestep this bug by setting symmetric_relations=True.
Sorry for the trouble with this!


[decomp] gsound

Pull Request Test Coverage Report for Build 930456873

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 69.499%

Totals

Change from base Build 930070290:
0.0%

Covered Lines:
36250

Relevant Lines:
52159

💛  - Coveralls


@material-ui/icons not compatible with react-dom 16.0.0

[x] This is not a v0.x issue.
[x] I have searched the issues of this repository and believe that this is not a duplicate.

Expected Behavior

Icon components from the @material-ui/icons package should work with react-dom 16.0.0.
Current Behavior

Receiving "Error: Element type is invalid: expected a string (for built-in components) or a class/function (for composite components) but got: symbol." error when a icon component form the /icons package is rendered using react-dom 16.0.0.
Steps to Reproduce

Link: https://codesandbox.io/s/9oj89v66yw

npm install --save<EMAIL_ADDRESS><EMAIL_ADDRESS>@material-ui/icons
Import and render an icon somewhere in your app, e.g.:

import DeleteForeverIcon from '@material-ui/icons/DeleteForever';
...
<DeleteForeverIcon />

start app

Your Environment

Tech
Version

material-ui-core
3.0.0

material-ui-icons
3.1.0

react
16.3.0

react-dom
16.0.0

Browser
Chrome 69.0.3497.92

Fix
Upgrading to react-dom 16.3.0+ fixed the issue, but I thought I would bring this to attention in case someone has a project that needs to be at react-dom 16.0.0 for whatever reason (which may not be a realistic scenario--I don't know).

We have a peer dependency on React 16.3.0
https://github.com/mui-org/material-ui/blob/c683d683730c53129dc35d0ad3ac1a3c4f4866f6/packages/material-ui-icons/package.json#L41

Ah gotcha thanks, sorry I missed that


feat: commandOptionsParser util

@H01001000 Hey can you look at the issue here in deno unit test plz

@itohatweb ready to merge


file before-test.sql changed to before-run.sql

Rahul, please review and merge if no issue. Thanks.

pre-commit test passed. +1


Add into published metadata a commit SHA

Whenever you publish the plugin it should create a file with the current git commit sha and an indication of whether you have an unclean working directory/index.

It shouldn't just be an indication but prevent you from publishing if you
aren't synced to a commit where it was merged in to master. Also for the
publish step, that could be an extended version of all the tests at some
point.
On Sun, Aug 23, 2015 at 9:16 AM Advay Mengle<EMAIL_ADDRESS>wrote:

Whenever you publish the plugin it should create a file with the current
git commit sha and an indication of whether you have an unclean working
directory/index.
—
Reply to this email directly or view it on GitHub
https://github.com/j2objc-contrib/j2objc-gradle/issues/394.

Yeah my internal plugin assert fails on publishPlugins when git is unclean.
I'm publishing that plugin to plugins.gradle.org to reuse it here
it will take a few more minutes =)

Good idea... I think it makes to have that as a separate plugin. Send me an
email afterwards describing this. I think it would be great to share this
with Gradle. This could become a blog post or event part of their
"plugin-publish" if that's ok for you. I think it has value for a wider
community that uses Git and GitHub.
On Sun, Aug 23, 2015 at 3:48 PM Advay Mengle<EMAIL_ADDRESS>wrote:

Yeah my internal plugin assert fails on publishPlugins when git is unclean.
I'm publishing that plugin to plugins.gradle.org to reuse it here
it will take a few more minutes =)
—
Reply to this email directly or view it on GitHub
https://github.com/j2objc-contrib/j2objc-gradle/issues/394#issuecomment-133950678
.

Alright see #395 .
Plugin code is at https://github.com/madvay/git-build-info - it is standard Apache 2, so feel free.
I doubt Gradle will care though, I'm sure there's some swiss army knife-type plugin that does a billion things with this being one.  I just didn't look for one when it takes a hundred lines to write it and be certain what it does.


chore: add target framework override capabilities

@agneszitte-nventive yep that's what I'll do next  :)

@agneszitte-nventive yep that's what I'll do next :)

Thanks a lot @kazo0 !


PlayerCubeMap very slow with high render distance

With render distance 32 updateMountedMovingPlayer takes 1-3 seconds.

This doesn't seem to be an issue anymore (added async chunk loading)


[Analyzers][CPP] Turn on rule 26497

Turn on warning 26497
This function function-name could be marked constexpr if compile-time evaluation is desired.

PR Checklist

[x] Continues towards: #940
[x] Communication: I've discussed this with core contributors already. If work hasn't been agreed, this work might be rejected
[ ] Tests: Added/updated and all pass
[ ] Localization: All end user facing strings can be localized
[ ] Dev docs: Added/updated
[ ] New binaries: Added on the required places

[ ] JSON for signing for new binaries
[ ] WXS for installer for new binaries and localization folder
[ ] YML for CI pipeline for new test projects
[ ] YML for signed pipeline

[ ] Documentation updated: If checked, please file a pull request on our docs repo and link it here: #xxx

Detailed Description of the Pull Request / Additional comments
Turning on warning 26497 - This function function-name could be marked constexpr if compile-time evaluation is desired.
There is false positives or code that we don't want or don't need to run at compile time.

Validation Steps Performed
CI

@sosssego , can you please add some information about what this rule is in the description? That would make it easier to review the PR and understand the exceptions that were added to the code.

What's holding this - and the others - back?

These changes are not for 67. It should be merged after 67 is released.


Objectives & Key Results

We tried and failed (sorry) at this last fall, although we might be ready to try again. Want to hear y'alls thoughts on [Objectives & Key Results as outlined by Clef] (https://github.com/josephine/handbook/blob/master/Onboarding Documents/Objectives and Key Results.md).
Full disclosure, the OKR definitions they set are pretty standard, and Clef hasn't quite gotten OKRs to 'work' yet either, but they're on their second quarter of trying to improve at them.
I think some sort of goal setting should happen, open to other ideas or pared down/built up formats.

Objectives and Key Results (OKRs) is a method for defining and keeping track of goals and their outcomes. They organize our goals by breaking them into high-level aspirations (objectives) and the measurable results that determine whether or not we’ve reached them (key results). OKRs are set at the company and individual level to help everyone see how their personal goals align with Clef’s goals, and also see how other people in the organization are working for the same outcomes from a different perspective.

Other than changing Clef to Josephine (I just created a PR for that  in #35 :), this is :cool:

Examples
Objectives are the high level achievements you are shooting for, like:

Grow our audience in the Sacramento market

Onboard more cooks, faster!

Improve the first time experience of using Josephine (onboarding)

Speed up the test suite for our development team

Get more press

Develop better management skills

Key results are the measurable outcomes that define success for the objectives. Key results must be measurable on a scale from 0-10, so for the third example objective, the results might be:

Interview 20 users after they go through the onboarding experience (% completion)

Pick 3 places where we can make the biggest improvements and write specs for all three improvements by July 31 (-2 points for each day late)

Ship those improvements by September 15 (-3 points for each week late)

Increase conversion through signup process by 10%, starting at 50% (% completion)

^ I made some suggestions for changes here.
I can't say I fully understand the scoring team. We start with 10 and deduct, sure... but what about the $ completion stuff? :confused:

Setting OKRs
Everyone at Clef sets their OKRs quarterly, writing them in the first week of the quarter and then evaluating them in the last week. At a startup it’s easy to focus on the immediate problems, but by setting our goals quarterly we ensure that everyone spends some time thinking about the challenges at least 3 months out.
Each person should set 3 to 5 objectives for the quarter, and each objective should have a maximum of 4 key results. Each objective also has a Description explaining what it means and an Alignment that explains how it aligns with company-wide goals. Each key result should explain how it will be scored at the end of the quarter.
For every quarter, one goal should always be a learning or improvement objective. It should describe some skill or area of knowledge you want to expand, and then the concrete steps that you will complete in order to succeed at learning or improving it.

I like this, especially that "one goal should always be a learning or improvement objective."

Every employee should keep track of their OKRs in their own Google Spreadsheet in the OKRs Folder. Within the spreadsheet, there should be a new sheet for each new quarter.
OKRS should be talked about every week in 1:1s to consider how each objective is progressing, places where help may be necessary, and how well they reflect current objectives.

Fsho.

OKRs are scored at the end of the quarter, with a score generated for each Key Result. The average of the key results give a score for each Objective, and the average scores of the Objectives gives an overall score for the quarter.
A key result can be scored in any way that makes sense for the result, but there are a few common ways to score a Key Result:

% completion -- if the goal is to do some number of actions, or achieve some number of results (post 3 blog posts or get 300 views), then the Key Result can be scored according to the % that were completed. Posting 2 results out of 3 would earn a score of ⅔ x 10 (because 10 is the total possible number of points) or a 6.7.

Due date -- if a resource should be delivered on a given day, then a fixed number of points can be docked based on how many days late the resource is finished. The penalty should be set with the key result and should vary depending on how time-sensitive the result is. For instance, if my coworker needs me to finish something on time so that they can use it, then there should be a heavy penalty for being late. If the penalty for an item is -2 points per day, then finishing it 3 days late gives a score of 4.

Deviation -- if you are trying to hit a precise target, and do not want to go above or below it, then the score can be based on how far off you were.

The scoring method should be included with each key result. If two people independently evaluated your OKRs at the same time, they should be sure to get the same scores because the criteria for evaluation should be unambiguous.
OKRs should never be used in evaluating employee performance, and should be ambitious. An average score of 7 is ideal, and no one should ever get to a full 10. If they do, their goals were set too low.

Ahhhh okay I understand the scoring now. This is chill.

I also think it's worthwhile to give OKRs another go. It would be lovely to have more quantitative data to point to when we're reviewing a quarter. That said, I think we need to have more structure to OKR check-ins — I don't think 1:1s are the appropriate place to talk about OKRs since those conversations tend to be more emotional. Maybe a bi-monthly check-in by team? All-hands check-in once a month?

Bi-monthly team meeting makes a lot of sense.
All hands –– what do you think the goal of that would be?
On Wed, Jan 13, 2016 at 2:39 PM, Sika Gasinu<EMAIL_ADDRESS>wrote:

I also think it's worthwhile to give OKRs another go. It would be lovely
to have more quantitative data to point to when we're reviewing a quarter.
That said, I think we need to have more structure to OKR check-ins — I
don't think 1:1s are the appropriate place to talk about OKRs since those
conversations tend to be more emotional. Maybe a bi-monthly check-in by
team? All-hands check-in once a month?
—
Reply to this email directly or view it on GitHub
https://github.com/josephine/handbook/issues/19#issuecomment-171459929.

--
josephine.com // @talsafran http://twitter.com/talsafran

I was thinking one or the other. Benefit of all-hands is that every team will have a sense of how other teams are doing and/or can offer support in whatever way they can. For example, if the Cook Team isn't meeting onboarding OKRs because there aren't enough leads, Growth can step in and help the Cook Team reach their OKRs, which helps the whole company. I like the idea of this being collaborative as opposed to everyone operating in their own lanes to get to the common goal.

Word. So maybe we alternate?
Week 1 – Team
Week 3 – All Hands
Week 5 – Team
etc...
On Wed, Jan 13, 2016 at 2:44 PM, Sika Gasinu<EMAIL_ADDRESS>wrote:

I was thinking one or the other. Benefit of all-hands is that every team
will have a sense of how other teams are doing and/or can offer support in
whatever way they can. For example, if the Cook Team isn't meeting
onboarding OKRs because there aren't enough leads, Growth can step in and
help the Cook Team reach their OKRs, which helps the whole company. I like
the idea of this being collaborative as opposed to everyone operating in
their own lanes to get to the common goal.
—
Reply to this email directly or view it on GitHub
https://github.com/josephine/handbook/issues/19#issuecomment-171461133.

--
josephine.com // @talsafran http://twitter.com/talsafran

The team, allhands structure seems pretty cool. I have mixed feelings about OKRs, as often, they are written, and then not reviewed until the end of the quarter. If OKRs are to be useful, everyone needs to know about everyone else's OKRs, and we need to be reviewing them frequently.

If this is not a performance measurement tool, then OKR's are for creating a work plan? Do they ever tie in to performance? How do we then measure performance?
"OKRs should never be used in evaluating employee performance, and should be ambitious. An average score of 7 is ideal, and no one should ever get to a full 10. If they do, their goals were set too low."

I'm definitely in favor of clear goal setting and regular check-ins, both within and across teams. Agnostic as to whether this is OKRs or some other structure. I like the alternating team/all-hands check-ins.
One thing that I think we should account for in our OKRs assessment is the trade-offs that often happen given our resource limitations, shifting priorities, and unexpected challenges that come up. We might get a horrible "score" on one of our OKRs, because something (e.g. legal) came up unexpectedly and we dealt with that instead, which may be an overall win for the team and for the company. We should somehow acknowledge and account for that when we're assessing and/or setting these OKRs.

@talsafran the "one goal should always be a learning or improvement objective." is Clef specific - its' another manifestation of their 'be better today than you were yesterday' value. I'm cool with it as well, but I generally don't like copying the parts of the handbook that they wrote specifically for their team and their values.
@egustafson5 @talsafran @joyjding @sike13 No right or wrong answers for cadence on check in. My vote is for smaller, more nimble check ins amongst each team bi-monthly and then have team leaders summarize and post progress/set backs maybe in a slack channel or something for everyone to see? Fine will all hands as well, imagine that would look like a round table one at a time update type of meeting?
@terrybetts24 OKRs are meant as a goal setting tool. on one hand it lets people set goals and measure their progress against them, but on the second hand it allows for the organization to have goals that are representative of the sum of its' employees' and teams' goals.
Performance measurement at Josephine should always be a much more nuanced conversation since our impacts are more complex than any one metric of output/improvement.
It's a good question though, @josephine/team-josephine how do you all think we should approach performance assessment? Clef has dodged the question by saying the company is small enough to handle on a case by case basis and I somewhat tend to agree for Josephine. I think that the purpose of 1:1s and retros and our commitment to honest and emotionally vulnerable communication is so that we can identify issues between our relationships with Josephine as an entity and address them proactively.

@MattJorgensen you're onboard with OKRs, I'm assuming? @zeke any experience with this type of stuff from past companies?

Hi @josephine/team-josephine --
Along the lines of Emily's comment earlier about "the trade-offs that often happen given our resource limitations, shifting priorities, and unexpected challenges that come up" -- I'm wondering if it might make the most sense to set OKRs at a team level ?
My proposal for using our initiatives and setting tangible goals would be:

Quarterly initiatives list by team (just a complete download of what we did earlier this week) + OKRs also at a team level -- two tabs in same spreadsheet https://docs.google.com/spreadsheets/d/1HMse_dQXt-BXiQHd31DkwDGFjdZ__FkWQLqoz5-GnbE/edit#gid=485941023

-30-days-out prioritizations by team that can be kept track of in a Trello Board or whatever publicly viewable format is preferred by each team. Individual task owners probably make sense for business/cook teams, may not for product team? These can be re-prioritized at or after the bi-weekly OKR check-ins (I like the alternating Team/ All-Hands Format) https://trello.com/b/mLk5wq9t/business-team-q1-2016-roadmap
-Weekly prioritization / sprint planning like we already do by team
Thoughts? Would love to have OKR-setting done by mid-next-week!

raw notes, disregard for now.
'we're not formally including personal goal setting in the team organization and prioritization process but we do encourage each member of the team to set personal goals at the same time and discuss them with their manager and review them during 1:1s.'
1:1s are personal development best forum to be discussing those types of things. trying to separate personal emotional development and performance orient goal setting.
OKRs are about what's best for the company overall.
we'll create more formal personal goal documentation as we grow as a team.

A couple points here:

We're missing personal/development oriented OKRs, which I think are important and should be written down, measured, and discussed. The question would be where we document that, and when we measure and discuss.
Not setting personal OKRs is something that will only work for a short while. As the teams grow bigger the need for individual accountability will surely surface.

latest doc for review [here] (https://github.com/josephine/handbook/blob/master/Onboarding Documents/Objectives and Key Results.md)

These look great. No more comments.
We should get recurring meetings set to check-in on OKRs with team and all-hands

I liked the structure of the biz dev/cooks team mtg today where we walked through the OKR's as they relate between the two teams. Staying on track with the check ins and with quarter end evaluations (specifically to the cooks team and then in combo with biz dev), should be a priority so this good work doesn't go astray. Can we plot out regular meetings asap for the rest of the quarter?


Fix for nova >=4.28.

This pull request resolves two issues (including #189):

Both loading buttons and danger buttons are no longer present in Laravel Nova, instead buttons are being moved to the laravel-nova-ui package. I've copied the buttons from the current Laravel Nova views.
Resolves a potential issue when duplicating menu items. Due to the use of the ->toArray() call, appended attributes (enabledClass etc) and relational attributes (children etc) were being included, causing an unknown column issue when trying to insert the data into the database. Using a ->getAttributes() call resolves this issue while not breaking any existing functionality such as copying with children or as child.

I've not tested for backwards compatibility. This may need a Laravel Nova dependency minimum version bump, though in theory as this doesn't depend on Laravel Nova for the buttons anymore it may also be fine.

Awesome, thanks a ton for the PR! Everything seems solid and it's exactly how I've upgraded other packages as well since the laravel-nova-ui change in Nova. The release went out tagged at 7.1.5. Thanks again and good luck! :)


How can I set rx.Config to deploy self-hosting on Kubernetes (GKE)?

Discussed in https://github.com/orgs/reflex-dev/discussions/3251
I'd appreciate some tips on this! Please feel free to advise me

Originally posted by ppippi-dev May  9, 2024
Hi, I have some questions.
I want to deploy my app on Kubernetes using self-hosting.
But I have some problems.
My problem is this:
When I set the ingress as blah.blah.com, the pod is okay, but I can't find the backend server. I receive this error message:
Cannot connect to server: timeout. Check if server is reachable at ws://blah.blah.com:8000/_event

It's not the situation that I expected, I expected to route to http://localhost:8000/_event
However, when I set the api_url value and ingress to "http://blah-api.blah.com", it works well.
Why does it route to ws://blah.blah.com:8000/_event when I set api_url to http://localhost:8000?

I attaching my kubernetes deployment's code and python reflex rxconfig code
          env:
            - name: API_URL
              value: "http://localhost:8000"
            - name: DEPLOY_URL
              value: "http://localhost:3000"
          command: ["sh", "-c", "poetry run reflex run --env prod"]
          ports:
            - name: http
              containerPort: 3000
              protocol: TCP
            - name: api
              containerPort: 8000
              protocol: TCP

config = rx.Config(
    app_name="blahblah",
    api_url=os.getenv("API_URL", 'http://localhost:8000'),
    deploy_url=os.getenv("DEPLOY_URL", 'http://localhost:3000'),
    backend_host=os.getenv("BACKEND_HOST", '<IP_ADDRESS>'),
)
```</div>

I just fix it to use ingress host ...

@ppippi-dev
Can you share how you configure your ingress/deployment?


'Submitting Jobs' intro?

What slides, if any, are needed?
Walk through both Wordcount and mobile gaming?
If also mobile gaming, should we insert those slides/info as well (or can point people to that online, if advanced enough)?

@brucearctor to add docs for submitting jobs (from website) including pointers to Mobile Gaming if get the rest working for additional exercises.

@pabloem -- working through mobile gaming; it is not suitable for direct runner (takes a ton of time).


Hologram Click to Teleport bug

If you do /hologram list and click to a hologram in Folia, this error occurs:
https://mclo.gs/lFRc6vF

Fixed in build 15 https://fancyplugins.de/fancyholograms/download/
Thank you for reporting <3 !


Bump Kubernetes dependencies to 1.10.12

What this PR does / why we need it:
Bumps the patch version of Kubernetes from 1.10.0 to 1.10.12 in order to resolve some issues around the webhook.
This does not replace the bump for 1.13, but instead is a temporary stop gap that we can cherry pick into the v0.6 release.
Which issue this PR fixes: fixes #1220
Release note:
Bump Kubernetes apimachinery dependencies to v1.10.12

/milestone v0.6
/kind bug
/area important-soon
/cc @kragniz
cc @nixgadget @gordcorp

Is there an ETA for a release that would include this patch?

how would I get these changes? I am having the same problem as well.

Same by me. I just got blocked by this issue, so a patch release would help us.

The aggregation layer isn't working in EKS only due to this dependency, so a release if only with this patch would be helpful.

I had the same issue for  Cassandra API server on EKS,
I see the authentication layer code looking for a certificate from data (map) in extension-apiserver-authentication config map. Looking at the https://github.com/jetstack/navigator/blob/master/vendor/k8s.io/apiserver/pkg/server/options/authentication.go, if possible get the certificate from a service account and place it! (simple workaround).


Failure to respond to email to receive data

Hello and have a good time
I tried to receive the dataset with my university email and I have been waiting for a long time to receive it, but I have not received a response from you.
I am interested in doing research to work on your article, thank you for checking your email.
Thanks
University email<EMAIL_ADDRESS>

Hi @Fariba-azhdarpour
Thank you. I just replied to you yesterday.
By the way, please make sure your email title contains “Request of University1652 Dataset”

Hi @layumi
Yes that's right, I received the dataset
Thank you


Dispaly warning message in Grid view

Remove SDK Build Results section
Rename AQA Test Results section name to Build and AQA Test Results
Display the warning message if no JDK build job gets triggered

Resovles: https://github.com/adoptium/aqa-test-tools/issues/665
Signed-off-by: lanxia<EMAIL_ADDRESS>


Fix caching in netlify build.

Fixes the Netlify caching issue that we ran into here.
Signed-off-by: Hannah Troisi<EMAIL_ADDRESS>

@philkuz @vihangm - I confirmed that the deploy preview showed the test change to pxl_documentation.json, so I'm going to revert the change now.


Add special value in valuePath to return the model it self.

I want to use a component to have actions buttons. For the moment, I can pass the id to retrieve the the model but it can be useful to have something like this :
  columns: [
    {
      label: 'Actions',
      valuePath: 'self',
      sortable: false,
      cellComponent: 'kh-actions'
    }
  ]

What you think?

Im not sure I follow @GCorbel. Can you give me more information?

I think it's correct. I finally succeeded by using row.content. I did this :
import Ember from 'ember';

export default Ember.Component.extend({
  model: Ember.computed.alias('row.content'),

  actions: {
    delete(model) {
      this.get('tableActions').deleteUser(model);
    }
  }
});

I can be useful to have this alias builtin.

@GCorbel in your template, you can do something like this instead of all the code above:
<button {{action tableActions.deleteUser row.content}}>Delete User</button>

You're right, thanks. The alias still a valid suggestion but I close this issue because my problem is solved. Thanks.


Vesta-Finance Arbitrum subgraph issues

I'm using this issue to list likely issues the vesta-finance subgraph I came across as I work on the rewards:
Deployed subgraph: https://subgraphs.messari.io/subgraph?endpoint=messari/vesta-finance-arbitrum&tab=protocol

subgraph version: 1.0.0
schema version: 2.0.1
methodology version: 1.0.0

Issues

protocol.totalPoolCount = 1
protocol.mintedTokenSupplies = 805.005
market id is the address of underlying token, not the contract address of the market, e.g https://arbiscan.io/address/0x8d9ba570d6cb60c7e3e0f31343efe75ab8e65fb1#readContract
stabilityPool were not included

@tnkrxyz Was this resolved?

Rewards look accurate on the subgraph. Stability pools were added. This should be good to merge.

merged! @ishraq8


Adds service area validation methods to EsriClient

Description
This adds methods for for querying service layers and validating that a provided address location is in the service area.
Checklist
General

[x] Added the correct label: < feature | bug | dependencies | infrastructure | ignore-for-release >
[ ] Created tests which fail without the change (if possible)
[ ] Extended the README / documentation, if necessary

User visible changes

[ ] Wrote browser tests using the validateAccessibility method
[ ] Manually tested at 200% size
[ ] Manually evaluated tab order

New Features

[x] Add new FeatureFlag env vars to server/conf/application.conf
[ ] Conditioned new functionality on a FeatureFlag
[ ] Wrote browser tests with the feature flag off and on, etc.

Issue(s) this completes
Fixes #<issue_number>; Fixes #<issue_number>...

Codecov Report

Merging #4115 (f6a6764) into main (25e575c) will increase coverage by 0.07%.
The diff coverage is 84.21%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@             Coverage Diff              @@
##               main    #4115      +/-   ##
============================================
+ Coverage     79.35%   79.42%   +0.07%
- Complexity     2525     2527       +2
============================================
  Files           312      312
  Lines         10230    10310      +80
  Branches        681      687       +6
============================================
+ Hits           8118     8189      +71
- Misses         1846     1848       +2
- Partials        266      273       +7

Impacted Files
Coverage Δ

server/app/services/geo/AddressLocation.java
100.00% <ø> (ø)

server/app/services/geo/esri/EsriClient.java
87.87% <84.21%> (-3.62%)
:arrow_down:

...erver/app/services/program/predicate/Operator.java
98.21% <0.00%> (-1.79%)
:arrow_down:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


bump to pulsar 2.9 and resolves the incompatible issues

2021-11-09T00:54:58,877+0000 [main] INFO  org.apache.pulsar.broker.PulsarService - Starting function worker service: serviceUrl = pulsar://t-1-broker-2.t-1-broker-headless.kj-test-test.svc.cluster.local:6650, webServiceUrl = http://t-1-broker-2.t-1-broker-headless.kj-test-test.svc.cluster.local:8080, functionWebServiceUrl = http://t-1-broker-2.t-1-broker-headless.kj-test-test.svc.cluster.local:8080
2021-11-09T00:54:58,879+0000 [main] ERROR org.apache.pulsar.PulsarBrokerStarter - Failed to start pulsar service.
java.lang.AbstractMethodError: Receiver class io.functionmesh.compute.MeshWorkerService does not define or inherit an implementation of the resolved method 'abstract void initInBroker(org.apache.pulsar.broker.ServiceConfiguration, org.apache.pulsar.functions.worker.WorkerConfig, org.apache.pulsar.broker.resources.PulsarResources, org.apache.pulsar.common.conf.InternalConfigurationData)' of interface org.apache.pulsar.functions.worker.WorkerService.
	at org.apache.pulsar.functions.worker.service.WorkerServiceWithClassLoader.initInBroker(WorkerServiceWithClassLoader.java:69) ~[io.streamnative-pulsar-functions-worker-<IP_ADDRESS>-rc-1.jar:<IP_ADDRESS>-rc-1]
	at org.apache.pulsar.broker.PulsarService.startWorkerService(PulsarService.java:1531) ~[io.streamnative-pulsar-broker-<IP_ADDRESS>-rc-1.jar:<IP_ADDRESS>-rc-1]
	at org.apache.pulsar.broker.PulsarService.start(PulsarService.java:751) ~[io.streamnative-pulsar-broker-<IP_ADDRESS>-rc-1.jar:<IP_ADDRESS>-rc-1]
	at org.apache.pulsar.PulsarBrokerStarter$BrokerStarter.start(PulsarBrokerStarter.java:273) ~[io.streamnative-pulsar-broker-<IP_ADDRESS>-rc-1.jar:<IP_ADDRESS>-rc-1]
	at org.apache.pulsar.PulsarBrokerStarter.main(PulsarBrokerStarter.java:350) [io.streamnative-pulsar-broker-<IP_ADDRESS>-rc-1.jar:<IP_ADDRESS>-rc-1]

We need to move mesh worker service to a separate repo and align the mesh worker service's version with Pulsar version.


where is this file (from generate_prot_ply import compute_inp_surface) ?

I don't know where is it

./utils/masif/generate_prot_ply.py
You can simply to get this path by searching the keywords.


Having an option to ignore generator rule/statement

By default, ninja already ignore generator rules, but it does not work on CI sometimes, when doing a git clone, the timestamp is lost

I'm not sure I understand what you mean. Is your build manifest not in Git?

Suppose you have a rule
rule cpp
	command = cpp $in -o $out
        generator = true
build xx.c : cpp xx.c.in

And you check in generated files in general, but in CI you don’t have cpp binary installed, it should be fine if git clone
preserved time stamp, the rule is not triggered. However, from time to time, the time stamp is not preserved in various environments,
so the command cpp is still triggered, this would cause an error since cpp is not available (cpp is expected to be a dev dependency like re2c
used in ninja)

On Jun 5, 2019, at 4:24 AM, Jan Niklas Hasse<EMAIL_ADDRESS>wrote:
I'm not sure I understand what you mean. Is your build manifest not in Git?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub https://github.com/ninja-build/ninja/issues/1585?email_source=notifications&email_token=AAFWMK6WKMKDFBXSHOJXJ7DPY3FQDA5CNFSM4HQ2M5V2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODW5YPUQ#issuecomment-498829266, or mute the thread https://github.com/notifications/unsubscribe-auth/AAFWMK32FW5AGCST2GGJ2SLPY3FQDANCNFSM4HQ2M5VQ.

@bobzhang You're probably looking for a tool like git-restore-mtime to correct the time stamps of the repo after checkout for CI.
This doesn't seem to be an issue with ninja, since it is behaving as expected (regenerating outdated build objects when needed).

Or #1459 ;)

It is not ninja's fault, but in an imperfect world it would be nice to have ninja provide a work around. I could use tools like @bauen1 mentioned, but I had to make it available in CI first..
#1459 is similar but not exactly the same, ideally I want to have a way to skip the generator rules completely without relying timestamps.
I have a local patch, I would like to send a PR if you are interested


Crash!

conversation.delete()

it crashed without any message

Sorry, that's just not enough information to do anything.


Add changes to the new dev branch of the original repo

I'm tagging all of you here, but you don't have to really review this PR, it's more for keeping you posted about the steps we've already agreed on.

I'm adding to the dev branch all the changes we made in our neurogym fork. For details about them, you can have a look at the merged PRs here.
I renamed the former dev branch into dev_former, and you can find it here. Remember to fetch/pull changes locally, otherwise the name won't be updated on your local repository. Not sure whether you wanted to merge those changes into master, but in case you can always open a PR from the dev_former branch.
As a reminder, we will use from now on a Git Flow-inspired branching workflow for development. The repository will be based on two main branches with infinite lifetime:

master — (it will be renamed main, see #60) this branch contains production (stable) code. All development code is merged into main in sometime.
dev — this branch contains pre-production code. When the features are finished then they are merged into dev.

I will merge this PR with dev before the end of today.

In this case, it is fine, but please do not merge PRs that you didn't open (unless we explicitly agreed on that) @nacloos
Usually, we follow this flow, except for special cases:

who opens the PR, is the person who has to merge it
A PR is ready to be reviewed only when reviewers are tagged on the PR (not before)


Update tutorial-sql-server-containers-kubernetes-dh2i.md

$docker build -t  . ( should be sqlimage/latest since this is the tag we are using below)
az aks update -n myAKSCluster -g  --attach-acr  (fully qualified name of registry is not acceptable here, only short name)
image: .azurecr.io/sqldh2i:latest (this has to be sqlimage:latest since this is what we created above)

@birenshrestha : Thanks for your contribution! The author(s) have been notified to review your proposed change.

#label:"aq-pr-triaged"

These changes look good, we should change the image name to sqldh2i:latest everywhere instead of sqlimage:latest. Thank you @birenshrestha  for your feedback!

@birenshrestha could you make the requested changes and resolve the merge conflict so we can merge? Thanks.

Hey @birenshrestha - Thanks! I'm pulling your changes into a new PR to update all the tags per @amvin87's recommendation, and also fixing the merge conflict.
@amvin87 - Amit, please check the new PR: https://github.com/MicrosoftDocs/sql-docs-pr/pull/21609
I want to make sure this is correct:


I'm trying to add placeholder in Mui TextField select type but I'm not successfully added . how I can add it ( e.g ) Select payment Method in drop down placeholder

Duplicates

[X] I have searched the existing issues

Latest version

[X] I have tested the latest version

Steps to reproduce 🕹
Link to live example:
Steps:

<TextField
select
fullWidth
defaultValue="NL"
placeholder="Select Country"
value={state?.countryCode}
onChange={(e) =>
dispatch({ type: "COUNTRY_CODE", payload: e.target.value })
}
>

Select Country

{options.map((option, i) => (

{option.label}

))}

Current behavior 😯

Expected behavior 🤔

Context 🔦
No response
Your environment 🌎

npx @mui/envinfo
  Don't forget to mention which browser you used.
  Output from `npx @mui/envinfo` goes here.

Your code seems incomplete. In order for me to not assume anything, it would be better for you to provide a Codesandbox that reproduces the issue. You can fork this template: https://material-ui.com/r/issue-template-latest

Hey @sulemanahsancui
Were you able to fix this issue with placeholder?


Ethereum message signature V issue

Just for reference I have opened this issue https://github.com/trezor/trezor-mcu/issues/418

You mean this one here, or both?

This is confusing because in Java the array is indexed differently I think,

Yes that one :)

Yes that was the plan, I am trying to fix transactions at the moment. The signature is not correct.

I'm just testing on Android and will check in the fix.

The fix is in this NuGet:
https://www.nuget.org/packages/Trezor.Net/2.2.0
I can see why it went wrong now. It was a copy pasta mistake.

Let me know if this fixes it for you.

Oh I am working on the Trezor.Net source, so I can debug and tinker :)

No problem. It's committed in master.

Btw sorry about the slow response. I never get notifications about new issues. Best to email me if something is wrong.

ha ha it happens to me the same, and monitoring so many repos is a nightmare.. gitter is my main point of contact if I am not in the zone :)

@juanfranblanco this fix has actually solved a problem in the KeepKey library which is based on Trezor.Net. So, thanks. Can this ticket be closed now? Do you suspect there are other issues in reading and writing data to the Trezor? Have you seen #10 ?

Yes this is all working now :)


Don't always convert numbers to floats in validators.py.

Try to preserve existing numeric types.

This should be fixed now in https://github.com/robofab-developers/fontParts/commit/44f4347101fd5ca06f9c33d05df3af7263b50b1d
For the record, anything that is an angle or scale/transformation is still a float, as that seems like the right thing to do.


RFC: developer meta-environments

This week I needed to recreate my dev env. As you may know, I develop/contribute to several related packages, so I often want/need editable installs of many things and to have all the optional dependencies installed (so I can run their tests, build their docs, etc). This makes things... hard. For example:

MNE-NIRS isn't really installable: its dependency sphinx_rtd_theme requires docutils<0.21 and its other (nested) dependency readme-renderer requires docutils>=0.21.2
MNE-LSL forces installation of PyQt5, which can cause headaches if you choose/prefer to install MNE-Python with PyQt6 or PySide
MNE-Connectivity pins pytest<8 and pydata_sphinx_theme==0.14.1 (specially bad problem for me as I also develop that theme, but others may also want to do local MNE doc builds against current main of that theme)

Possible solutions (please suggest others!)

migrate currently maintained MNE tools into a monorepo with a unified environment spec / lockfile (this is possible with e.g. Rye; see https://rdrn.me/postmodern-python/#monorepo)
unify a few key things to reduce pain:

use the same Qt binding across mne-python, mne-lsl, and mne-qt-browser
use the same sphinx theme (and version) across mne-nirs (rtd), mne-lsl (furo), mne-conectivity (pydata==0.14.1) and mne-python (pydata). Ideally we'd also use it for mne-bids-pipeline but I don't expect to win that argument.

Do nothing, and make devs use different envs for different packages they work on (I do this too... but it feels weird to need different envs just for working on different MNE packages...)

thoughts?

... FWIW generally speaking my process is to use a single dev env for as much stuff as possible, and if there are outliers that don't get along with the general Scientific Python practices, I give those a special isolated env.

mne-lsl depends on qtpy, pyqt5 is installed as part of the doc and test extra-key because I do need a qt binding in the environment to run the doc-build and tests (actually need to be checked as the legacy viewer is neither tested through pytest or documented through sphinx-gallery, thus I might be able to entirely drop the qt binding from the extra-keys).
I also tend to use a single environment per project, and then I need an extra package installed in editable mode, I add it to the workspace and install it in the environment I want. I also tend to nuke my environments quite often because it's simpler and faster (especially with uv) to just start fresh than to bother with dependency conflict or to remember what was installed where and when.

FYI, uv pip install mne[full,test,test_extra,doc] reports:
(.venv) mscheltienne@D-1027100163:~/git$ uv pip install mne[full,test,test_extra,doc]
Resolved 265 packages in 187ms
Installed 260 packages in 65ms

Creating environments has never been so fast ;)


MAISTRA-1787 port MAISTRA-1456, MAISTRA-1681, MAISTRA-1697, MAISTRA-1…

…698, and MAISTRA-1699 to maistra-2.0
Signed-off-by: rcernich<EMAIL_ADDRESS>Please provide a description for what this PR is for.
And to help us figure out who should review this PR, please
put an X in all the areas that this PR affects.
[ ] Configuration Infrastructure
[ ] Docs
[ ] Installation
[ ] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure

I've verified that istiod (15012, webhook, dns) and proxies are configured correctly.

/test integration


[distributed][misc] use fork by default for mp

fixes https://github.com/vllm-project/vllm/issues/5637
fork is not safe after we create cuda context. we should already avoid initializing cuda context before we create workers, so it should be fine to use fork, which can remove the necessity of if __name__ = "__main__" in user's code.

Other advantages of fork are that it's faster and also ...

Agreed. In general fork is preferred. One exception is that we need to be careful when we have cuda context, which cannot be forked easily. e.g. pytorch explicitly bans forking when we have cuda context.

@njhill the blocker of this pr is that some tests are failing. It seems some tests will initialize cuda before launching vllm worker, which makes fork not possible.

@youkaichao for these ones we can add VLLM_WORKER_MULTIPROC_METHOD=spawn prior to the pytest command

for these ones we can add VLLM_WORKER_MULTIPROC_METHOD=spawn prior to the pytest command

it is just a workaround, i think we need to find out the root case and fix it.

too busy to do it now, left as a FIXIT :)

Hi.
Encountering the same issue. Is there a workaround?
VLLM_WORKER_MULTIPROC_METHOD=fork not working.

@yaronr you can open a new issue with detailed info.


MSID: 91258 Version: 1 DOI: 2<IP_ADDRESS>1600

"msas": "Neuroscience"
"msid": "91258"
"preprintDoi": "10.1101/2<IP_ADDRESS>1600"
"Reviewed Preprint posted": "2023-09-19"
"Sent for peer review": "2023-07-26"
"Posted to bioRxiv": "2023-08-04" (link: "Go to bioRxiv": "https://www.biorxiv.org/content/10.1101/2<IP_ADDRESS>1600v1/")
[PLACE PDF URL HERE WHEN AVAILABLE] See step 7
Step 1. Inform bioRxiv
Who can help: @QueenKraken, @nlisgo, @scottaubrey

[x] Manuscript is in data hub index (https://data-hub-api.elifesciences.org/enhanced-preprints/docmaps/v1/by-publisher/elife/get-by-manuscript-id?manuscript_id=91258)

Step 2. Create preview of manuscript
Who can help: @fred-atherden, @nlisgo, @scottaubrey

[ ] Manuscript is available for preview (https://prod--epp.elifesciences.org/preview/91258/v1)

[ ] Trigger import for staging: https://prod--epp.elifesciences.org/import
[ ] Sync data folder with s3://prod-elife-epp-data/data
[ ] Trigger import for staging: https://staging--epp.elifesciences.org/import
[ ] Sync data folder with s3://staging-elife-epp-data/data
[ ] Pull request created to enhanced-preprint-data
[ ] Post link to pull request below

Pull request: [PLACE LINK TO PULL REQUEST HERE]
Detailed instructions: https://github.com/elifesciences/enhanced-preprints-data#add-a-manuscript
Step 3: Awaiting public reviews and QC
Who can help: Production team

[ ] QC passed or QC not needed

Who can help: Editorial team

[x] Public reviews available on sciety (https://sciety.org/articles/activity/10.1101/2<IP_ADDRESS>1600)
[x] Manuscript and editor details at the top of this issue (Supplied by Editorial team)
[ ] Reviews returned by EPP - https://prod--epp.elifesciences.org/api/reviewed-preprints/91258/v1/reviews

Example
"msas": "Genetics and Genomics", "Neuroscience"
"msid": "84628"
"version": "1"
"preprintDoi": "10.1101/2<IP_ADDRESS>4241"
"articleType": "Reviewed Preprint"
"status": "Published from the original preprint after peer review and assessment by eLife."

"Reviewed Preprint posted": "2023-01-02"
"Sent for peer review": "2022-10-28"
"Posted to bioRxiv": "2022-11-21" (link: "Go to bioRxiv": "https://www.biorxiv.org/content/10.1101/2<IP_ADDRESS>4241v1")

Editors:
Reviewing Editor
Michael B Eisen
University of California, Berkeley, United States
Senior Editor
Michael B Eisen
University of California, Berkeley, United States

Step 4: Modify manuscripts.json (no PDF)

[ ] Reviewed preprint is published to EPP (https://elifesciences.org/reviewed-preprints/91258)

[ ] Pull request created to enhanced-preprint-client
[ ] Pull request switched to "Ready for review"
[ ] Post link to pull request below

[ ] Request that a doi be registered

[ ] Post link to #enhanced-preprint comment below

Pull request: [PLACE LINK TO PULL REQUEST HERE]
#enhanced-preprint comment thread: [PLACE LINK TO COMMENT HERE]

Instructions to modify manuscripts.json

Visit: https://github.com/elifesciences/enhanced-preprints-client/actions/workflows/publish-manuscript.yaml
Click: Run workflow
Complete the form and click "Run workflow"
A successful run should result in a new pull request at https://github.com/elifesciences/enhanced-preprints-client/pulls
Open the pull request and click the "Ready for review" button to trigger tests
Once the tests pass and you are happy with the changes the PR can be merged

Example pull request: https://github.com/elifesciences/enhanced-preprints-client/pull/334/files
Once the pull request is merged in it should be available a few minutes later.

Request that a doi
Post the following in #enhanced-preprint:
@Fred can you register a doi for https://elifesciences.org/reviewed-preprints/91258

Step 5: Awaiting search reindex

[ ] Reviewed preprint is avaliable on journal homepage (https://elifesciences.org)

The search reindex is triggered once an hour. We need the reviewed preprint to be indexed as the search application serves the journal homepage.

Additional info
If needed, the jenkins pipeline to reindex search can be triggered sooner.
https://alfred.elifesciences.org/job/process/job/process-reindex-reviewed-preprints/

Step 6: Published! Request PDF generation

[ ] Post the link to the PDF url at the top of the issue

[ ] Post link to #enhanced-preprint comment below

#enhanced-preprint comment thread: [PLACE LINK TO COMMENT HERE]
Post the following to the #enhanced-preprint on slack:
@Ryan Dix-Peek please can you generate a PDF for https://elifesciences.org/reviewed-preprints/91258

Step 7: Introduce PDF to data folder and git repo

[ ] PDF is avaliable at https://github.com/elifesciences/enhanced-preprints-data/raw/master/data/91258/v1/91258-v1.pdf

Detailed instructions: https://github.com/elifesciences/enhanced-preprints-data#add-a-pdf
Step 8: Add PDF url to manuscripts.json

[ ] Reviewed preprint PDF is available for download (https://prod--epp.elifesciences.org/reviewed-preprints/91258)

[ ] Pull request created to enhanced-preprint-client
[ ] Pull request switched to "Ready for review"
[ ] Post link to pull request below

[PLACE LINK TO PULL REQUEST HERE]

Instructions to add PDF url to manuscripts.json

Visit: https://github.com/elifesciences/enhanced-preprints-client/actions/workflows/add-pdf-url-to-manuscript.yaml
Click: Run workflow
Complete the form and click "Run workflow"
A successful run should result in a new pull request at https://github.com/elifesciences/enhanced-preprints-client/pulls
Open the pull request and click the "Ready for review" button to trigger tests
Once the tests pass and you are happy with the changes the PR can be merged

Example pull request: https://github.com/elifesciences/enhanced-preprints-client/pull/397/files
Once the pull request is merged in it should be available a few minutes later.

Step 9: Done!

[ ] Kettle is on!

Reviews unavailable

Thanks Naushin - it was probably put into this swimlane in readiness for publishing tomorrow (after the reviews were posted today).
Was it otherwise QC OK?

Reviews now showing - unblocking


how does the loss converge

Does the AMS loss have the similar converge curve with softmax loss? In my exps, the AMS loss (set m=1) changes little during training, even after lots of iters.

Loss is meaningless in AMS. Maybe you can output the accuracy, target logit etc to observe the convergence of the network.


We should measure and record Kani's memory consumption in CI

Proposed change: Need to figure out the best way to do this, but it would be great if we could measure the memory consumption of Kani (and its sub-processes) as part of our benchmarks.
Motivation: Memory consumption is often a bottleneck for finishing a proof. Metrics on memory consumption will help us measure the impact of changes to Kani.

Related to https://github.com/model-checking/kani/issues/1675


SDK-90: scheduler creation issue due to frequency format

Fix whitespace issues.

Is there any backwards incompatibility impact here?

in SchedulerApi.java apart from create all other functions return InvokableBuilder type.
here i changed create also to return the same.
so we donot need CreateScheduleCommandBuilder to extend InvokableBuilder anymore, as none of the functions there need this.

regarding spaces, can you please point out areas where to fix as i didnt find any discrepancy there.

Pointed out some examples of trailing whitespaces. There are a lot of others as well.

I pushed a new commit to master. If you pull that commit, it will fail the build when there are any whitespace issues.


Riak CS SetBucketPolicy

Hi,
I've been using golang with minio-go client (https://github.com/minio/minio-go) to Put and Get image objects to RiakCS, and it works splendidly.
But problem arised (I got Accessdenied error) when the object is accessed with url through browser hostname/bucketname/objectkey
*the object is put directly under the bucket
I've raised issue to minio-go (https://github.com/minio/minio-go/issues/894) and it's pointed out to me that Riak CS needs to implement SetBucketPolicy API Handler. It's Probably because Bucket ACL's are deprecated and instead Bucket policies are implemented as in  http://docs.aws.amazon.com/AmazonS3/latest/user-guide/add-bucket-policy.html
I hope you can help me with this problem, Best Regards ~

As I did that work for sure ( https://github.com/basho/riak_cs/pull/364 ), I think you may have misconfigured something either on the CS or on client side.

Hi, @kuenishi , maintainer from minio-go, @poornas , has been actively helping me to solve this issue.
it was pointed out to me that when minio-go client send API request to set a bucket policy :
---------START-HTTP---------
PUT /uploads/?policy= HTTP/1.1
Host: <IP_ADDRESS>:8080
User-Agent: Minio (linux; amd64) minio-go/4.0.4
Content-Length: 417
Authorization: AWS **REDACTED**:**REDACTED**
Content-Md5: d4Sj0xE9GbH0UsQ4mjtPjQ==
Date: Thu, 07 Dec 2017 00:29:34 GMT
Accept-Encoding: gzip

HTTP/1.1 415 Unsupported Media Type
Content-Length: 0
Content-Type: application/json
Date: Thu, 07 Dec 2017 00:26:30 GMT
Server: Riak CS
---------END-HTTP---------
415 Unsupported Media Type

It is not sending content-type as a compliance with s3 spec . maybe Riak is expecting content-type header and throwing an error ?


[Usable-Command Palette]-Keyboard shortcuts are not included in the sub menu of New Tab list item.

User Experience:
Shortcuts that are provided inside dropdown for these submenu controls should be appended in sub menu too. Visual and screen reader user experience should be consistent through out the app .
Test Environment:
App: Windows Terminal Preview
Feature: Command Palette
Screen Reader: Narrator
OS: Win 10 2004 Build (19041.508)
Repro Steps:
1.Open Windows terminal Preview app
2.Open Command Palette using shortcut (Ctrl+shift+p)
3.Search for New tab command in the search field
4.Navigate to New Tab list item having sub menu and activate it .
5.verify whether the shortcuts are appended with the list items in New tab are not.
Actual:
Keyboard shortcuts are not included in the sub menu of New Tab list item.
Expected:
Keyboard shortcuts should be included in the sub menu of New Tab list item like they are included in the drop down of windows terminal for the  same list items.
MAS Reference:
https://microsoft.sharepoint.com/:w:/r/sites/accessibility/_layouts/15/Doc.aspx?sourcedoc={64DD7C5C-AA62-4D53-886E-BCAEE5341C01}&file=Guideline 101 Recommended Assistive Technology Tools for MAS Testing of Microsoft Digital Properties_v3.docx&action=default&mobileredirect=true

This is by design, the sub-commands of the "New tab..." command only have shortcut text if the user has a keybinding specifically for that action. Note that there's a difference between the actions specified by
{ "command": { "action": "newTab", "index": 0 }, "keys": "ctrl+shift+1" },

and
{ "command": { "action": "newTab", "profile": "profile0" }, "keys": "ctrl+shift+1" }

Even if "profile0" is the first profile the user has. If the user has the second action in their settings, the shortcut text will appear for the nested menu item:

@Chandresh1007 @Priyanka-Chauhan123 @DasaradhaKamjula Since this is by design, can we close this issue?

Agree with the above comments as the shortcuts are appearing for the nested menu items and closing this bug.


Storybook: UX review of CSS components

The basic HTML components are migrated to storybook and require UX review. Here is a list of all components to review. If one component requires more discussion or has open todos, the task list entry can be converted to an issue which can be handled individually.
Also have a look at the tracker ticket to see if there are any open tasks or known issues.
What to look for:

Are there general issues with the component, does it look good?
Does this component exist in Figma?
Does it have the same name?
Are hover, focus and disabled states (if applicable) in sync?
Does the component have the same variants?
Do the variants have the same name?

### Foundation
- [ ] [Typography](https://next.design-system.post.ch/?path=/docs/foundations-typography--page) ([tracking board](https://github.com/orgs/swisspost/projects/4?pane=issue&itemId=14326740))
- [ ] [Color](https://next.design-system.post.ch/?path=/docs/foundations-color--page) ([tracking board](https://github.com/orgs/swisspost/projects/4?pane=issue&itemId=14020795))

### Components
- [x] [Alert](https://next.design-system.post.ch/?path=/docs/components-alert--default) ([tracking board](https://github.com/orgs/swisspost/projects/4?pane=issue&itemId=13177654))
- [x] [Badge](https://next.design-system.post.ch/?path=/docs/components-badge--default) ([tracking board](https://github.com/orgs/swisspost/projects/4?pane=issue&itemId=14017569))
- [x] [Blockquote](https://next.design-system.post.ch/?path=/docs/components-blockquote--default) ([tracking board](https://github.com/orgs/swisspost/projects/4/views/1?pane=issue&itemId=14021998))
- [x] [Button group](https://next.design-system.post.ch/?path=/docs/components-button-group--default) ([tracking board](https://github.com/orgs/swisspost/projects/4/views/1?pane=issue&itemId=23238777))
- [x] [Button](https://next.design-system.post.ch/?path=/docs/components-button--default) ([tracking board](https://github.com/orgs/swisspost/projects/4?pane=issue&itemId=14022288))
- [x] [Card](https://next.design-system.post.ch/?path=/docs/components-card--default) ([tracking board](https://github.com/orgs/swisspost/projects/4?pane=issue&itemId=14022774))
- [x] [Checkbox](https://next.design-system.post.ch/?path=/docs/components-checkbox--default) ([tracking board](https://github.com/orgs/swisspost/projects/4?pane=issue&itemId=14031687))
- [x] [Collapsible](https://next.design-system.post.ch/?path=/docs/components-collapsible--default)
- [x] [Heading](https://next.design-system.post.ch/?path=/docs/components-heading--default) ([tracking board](https://github.com/orgs/swisspost/projects/4?pane=issue&itemId=14349234))
- [x] [Text input](https://next.design-system.post.ch/?path=/docs/components-text-input--default) ([tracking board](https://github.com/orgs/swisspost/projects/4?pane=issue&itemId=14030413))
- [x] [Radio button](https://next.design-system.post.ch/?path=/docs/components-radio-button--default) ([tracking board](https://github.com/orgs/swisspost/projects/4?pane=issue&itemId=14097696))
- [x] [Range](https://next.design-system.post.ch/?path=/docs/components-range--default) ([tracking board](https://github.com/orgs/swisspost/projects/4/views/1?pane=issue&itemId=14098527))
- [x] [Select](https://next.design-system.post.ch/?path=/docs/components-select--default) ([tracking board](https://github.com/orgs/swisspost/projects/4/views/1?pane=issue&itemId=14033075))
- [x] [Switch](https://next.design-system.post.ch/?path=/docs/components-switch--default) ([tracking board](https://github.com/orgs/swisspost/projects/4/views/1?pane=issue&itemId=14099125))
- [x] [Table](https://next.design-system.post.ch/?path=/docs/components-table--default) ([tracking board](https://github.com/orgs/swisspost/projects/4/views/1?pane=issue&itemId=23239413))
- [x] [Textarea](https://next.design-system.post.ch/?path=/docs/components-textarea--default) ([tracking board](https://github.com/orgs/swisspost/projects/4/views/1?pane=issue&itemId=14321752))
- [x] [Toast](https://next.design-system.post.ch/?path=/docs/components-toast--default) ([tracking board](https://github.com/orgs/swisspost/projects/4/views/1?pane=issue&itemId=14011829))
- [ ] [Topic teaser](https://next.design-system.post.ch/?path=/docs/components-topic-teaser--default)

### Utilities
- [ ] [Lists](https://next.design-system.post.ch/?path=/docs/utilities-list--unordered-list) ([tracking board](https://github.com/orgs/swisspost/projects/4/views/1?pane=issue&itemId=14331616))
- [ ] [Text](https://next.design-system.post.ch/?path=/docs/utilities-text--font-family)

After a component has been reviewed, check the task as completed or close the ticket assigned to it. We can then replace the label with stable and update the status in the Component Status Tracker.

Ticket Storybook: UX review of CSS components #1266:

Links in Ticket do not get found!

Typography:
What is the Monospaced Font used for here? License?

Responsive font size:
There are still 17px / 13px Fonts here??

Color
Dark and Bright Accentcolors should be in Fade Out.

Button
No Accent Colors allowed
The Success Button Font should be white?
Is it correct that only the Animated Button is here?

Cards:
From my Perspective we mix Teasers with Cards here.
The Product Cards missing the Price Blue...

Checkbox
It seems the Hover State is not accordingly to the Figma behaviour... not Quite Shure here.

Radio Button
It seems the Hover State is not accordingly to the Figma behaviour... not Quite Shure here.

Range
Knob has no Hover State. Focus State has wrong color.

Table
Seems alright. Is it the same as Simple Table? Because the Simple Table in Figma seems way more sophisticated than the Storybook Table. The Select Functionality and the Filter Functionality in the Title Row are completly missing.

Topic Teaser

The Topic Teaser should only be on Yellow and Dark Grey BGs. No Accent colors.

@gfellerph could you please have a look into this ticket and tell us, what to do next?

Created a ticket to remove the monospace fonts, they are coming from bootstrap (MIT license) https://github.com/swisspost/design-system/issues/2888
Black/white alpha already added
Created ticket to deprecate accent colors (this is a breaking change and they will be removed with the next major version) https://github.com/swisspost/design-system/issues/2863
Deprecated old signal colors, updated the green value
Success button is already white
Deprecated portal components like price and product cards (https://github.com/swisspost/design-system/issues/2889)
Created a ticket for checkbox/radio button hover colors https://github.com/swisspost/design-system/issues/2890
Created a ticket to update the range slider hover state https://github.com/swisspost/design-system/issues/2891


Airdrop

Once I selected my airdrop, I don't see any amount of airdrops related to it.
How do I transfer my airdrops from greymass to fairy-wallet?

You can add airdrop from here. Press `+` button. And select airdrop you want to track.

Can I close it?

Hi Tarassh,
In the attachment you will see what I mean. I have included three airdrops and none of  these have the numbers of token that I have got.
Karma  (7291); Horus (910); IQ (4131)
So why my tokens aren’t there?
Thanks
F; IQ (4131)rom: tarassh<EMAIL_ADDRESS>Sent: September 5, 2018 14:38
To: tarassh/fairy-wallet<EMAIL_ADDRESS>Cc: Brian369<EMAIL_ADDRESS>Author<EMAIL_ADDRESS>Subject: Re: [tarassh/fairy-wallet] Airdrop (#10)
Can I close it?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub https://github.com/tarassh/fairy-wallet/issues/10#issuecomment-418836124 , or mute the thread https://github.com/notifications/unsubscribe-auth/AaF1UKIl2cEBX9A5Oc4CeGF_t3Jsappqks5uYBoTgaJpZM4WaxiV .  https://github.com/notifications/beacon/AaF1UJ6aWHFNYvQezjOxU2dIeww6cW0lks5uYBoTgaJpZM4WaxiV.gif

I don't see the attachment.
Could you also try change endpoint.

Here it is.
What do you mean by ‘try change endpoint’?
From: tarassh<EMAIL_ADDRESS>Sent: September 5, 2018 17:39
To: tarassh/fairy-wallet<EMAIL_ADDRESS>Cc: Brian369<EMAIL_ADDRESS>Author<EMAIL_ADDRESS>Subject: Re: [tarassh/fairy-wallet] Airdrop (#10)
I don't see the attachment.
Could you also try change endpoint.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub https://github.com/tarassh/fairy-wallet/issues/10#issuecomment-418890263 , or mute the thread https://github.com/notifications/unsubscribe-auth/AaF1UOyegZdT8ZBrdnTXFovgYdidDSTNks5uYERegaJpZM4WaxiV .  https://github.com/notifications/beacon/AaF1UIV5yC7IEV11lkZ3jS5hv0lYBMfVks5uYERegaJpZM4WaxiV.gif

Here is the list: https://github.com/tarassh/fairy-wallet/wiki/Connect-to-Mainnet

I know that list. It doesn’t say why I don’t see the amount of tokens related to each airdorps and to correct the situation.
Do you know why and how?
From: tarassh<EMAIL_ADDRESS>Sent: September 6, 2018 02:11
To: tarassh/fairy-wallet<EMAIL_ADDRESS>Cc: Brian369<EMAIL_ADDRESS>Author<EMAIL_ADDRESS>Subject: Re: [tarassh/fairy-wallet] Airdrop (#10)
Here is the list: https://github.com/tarassh/fairy-wallet/wiki/Connect-to-Mainnet
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub https://github.com/tarassh/fairy-wallet/issues/10#issuecomment-418976292 , or mute the thread https://github.com/notifications/unsubscribe-auth/AaF1UK1Dlq8Qh9MpVx2z3H9YQaJYyQeYks5uYLxtgaJpZM4WaxiV .  https://github.com/notifications/beacon/AaF1UBd2AjhBN0KGZPdy7jtKdJcpgTsuks5uYLxtgaJpZM4WaxiV.gif

The tokens are not visible by default. You have to add them, the functionality is similar to greymwass wallet.
And unfortunately I don't see the attachment, are you replaying from the GitHub directly?
Can you tell, what account name do you have?

How do I add them ?
The attachment shows 3 airdrops with 0:00 tokens which in fact I have a number of airdrops tokens in each of them.
What do you mean ‘are you replaying from the GitHub directly’?
From: tarassh<EMAIL_ADDRESS>Sent: September 6, 2018 04:40
To: tarassh/fairy-wallet<EMAIL_ADDRESS>Cc: Brian369<EMAIL_ADDRESS>Author<EMAIL_ADDRESS>Subject: Re: [tarassh/fairy-wallet] Airdrop (#10)
The tokens are not visible by default. You have to add them, the functionality is similar to greymwass wallet.
And unfortunately I don't see the attachment, are you replaying from the GitHub directly?
Can you tell, what account name do you have?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub https://github.com/tarassh/fairy-wallet/issues/10#issuecomment-419013391 , or mute the thread https://github.com/notifications/unsubscribe-auth/AaF1UH5FJ4IUbYpmx4pca4eWZ0-9JmAOks5uYN96gaJpZM4WaxiV .  https://github.com/notifications/beacon/AaF1UDBVjZ3pye6jlQAXGG3mOFnpy2KUks5uYN96gaJpZM4WaxiV.gif


feat(Topology/MetricSpace/Congruence): define congruence

Feat: Add congruence for Topology.MetricSpace.Congruence
This is a port of:
https://github.com/leanprover-community/mathlib/pull/18214

@jsm28 Here is the first PR from the bunch.  There wasn't any comments from you about this file in the previous PR.  Let me know if there are any modifications that you would like me to make to the port.

@newell can you explain why you are providing this definition of congruence? It seems very unnatural to me (i.e., the choice to represent sets as indexed families, which are not necessarily even injective!).
Why not just use actual Sets, and just require that there is a Set.BijOn function mapping one to the other which is distance preserving on that set?
As is, you have the strange phenomenon that if you have two different index sets with the same range, then you can't say they are congruent.

Perhaps @JovanGerb has something to say about this definition?

When talking about congruent or similar triangles, it's really important to distinguish triangle ABC from triangle ACB (the two are congruent only if the triangle is isosceles). I'm confident that indexed families are correct for defining congruences, and sets would not be correct.

There are (at least) two notions that are equivalent in a Euclidean space:

the one introduced in this PR, ∀ i j, edist (f i) (f j) = edist (g i) (g j)
∃ e : X ≃ᵢ Y, e ∘ f = g

I don't know which one is called "congruent" in general case.

There was a long discussion in the thread https://leanprover.zulipchat.com/#narrow/stream/217875-Is-there-code-for-X.3F/topic/Euclidean.20Geometry about the merits of the two approaches for defining congruence (equal pairwise distances versus existence of an isometric equivalence). Some evidence was found in that thread that the more general notion (equal pairwise distances) is indeed used in the literature between different metric spaces that don't have an isometric equivalence.
In any case, once things move from the general setup in metric spaces to more specific Euclidean applications, the fact that equal distances implies an isometric equivalence in Euclidean spaces with the same finite dimension (or various other such Euclidean cases) will be a natural result to prove early on (that thread has some discussion of how inner_weightedVSub / dist_affineCombination might be used to prove such results).

IMHO, this should be discussed in the docstring.

IMHO, this should be discussed in the docstring.

Doc-string updated.


pool the writebufferchan write timer for high load

Codecov Report

Merging #1496 (b689e2e) into master (416864e) will increase coverage by 0.05%.
The diff coverage is 60.00%.

@@            Coverage Diff             @@
##           master    #1496      +/-   ##
==========================================
+ Coverage   59.05%   59.11%   +0.05%
==========================================
  Files         332      333       +1
  Lines       26902    26911       +9
==========================================
+ Hits        15888    15909      +21
+ Misses       9256     9243      -13
- Partials     1758     1759       +1

Impacted Files
Coverage Δ

pkg/network/connection.go
41.13% <0.00%> (-0.08%)
:arrow_down:

pkg/network/timer_pool.go
75.00% <75.00%> (ø)

...ream/faulttolerance/regulator/default_work_pool.go
85.71% <0.00%> (-5.72%)
:arrow_down:

pkg/upstream/cluster/strict_dns_cluster.go
69.93% <0.00%> (ø)

pkg/module/http2/server.go
80.87% <0.00%> (+0.31%)
:arrow_up:

pkg/module/http2/transport.go
76.92% <0.00%> (+0.32%)
:arrow_up:

pkg/module/http2/frame.go
82.30% <0.00%> (+0.35%)
:arrow_up:

pkg/stream/xprotocol/connpool_pingpong.go
51.13% <0.00%> (+0.56%)
:arrow_up:

pkg/mtls/sds/subscriber.go
78.35% <0.00%> (+2.98%)
:arrow_up:

... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 416864e...b689e2e. Read the comment docs.

move to this PR
https://github.com/mosn/mosn/pull/1498


Password verification by prompting twice and comparing the responses

Is your feature request related to a problem? Please describe.
I have been using this library and noticed one feature that I was missing, namely the ability to verify secret output by prompting the user twice and comparing the responses. This is useful for making sure the password is correctly typed, especially when the hidden display type is used.
Describe the solution you'd like
The solution should prompt the user twice, rerunning all the same configuration for the prompt (validators, formatters, help messages, etc.), and collect the two responses. Then it should compare them and if they are the same, then exit and return the response. If not, an error message should state "The passwords don't match." and start over, prompting the user to try again. This will continue indefinitely until the passwords match or the user aborts (either by Esc or Ctrl-C).
Describe alternatives you've considered
I tried doing some hacks by using two prompts and comparing the results then, but then I have to loop and recreate the prompts each time, when the prompt itself is almost capable of this sort of thing via validators, but not quite. Also, I would like to hook into the error message functionality as well, so that is cleaned up properly as well when the prompt finishes. If I print the error message manually, then I would have to clean it up using ANSI escape codes, which is not always ideal (becomes complex to know if the user completed the prompt, or aborted for instance).
Additional context
I have implemented a POC in a fork which I opened as a PR (#77).

Released in v0.5.0 :)


Doc URL contains hard-coded version number

https://github.com/openshift-assisted/assisted-installer-ui/blob/322630e1276b254cfc10619d749f98cd5e46bf45/libs/ui-lib/lib/common/config/docs_links.ts#L62C1-L62C261
This URL will break if the doc version number changes and a specific redirect is not in place.
Please use an attribute for the version number to avoid maintenance issues.

@apinnick are you talking about the year in the URL?
https://access.redhat.com/documentation/en-us/assisted_installer_for_openshift_container_platform/**2024**/html/installing_openshift_container_platform_with_the_assisted_installer/expanding-the-cluster#checking-for-multiple-architectures_expanding-the-cluster

@ammont82 Yes

@apinnick and what do you suggest?Change the year dinamically?

I thought you could do it like you do in line 8:
export const ASSISTED_INSTALLER_DOCUMENTATION_LINK = https://access.redhat.com/documentation/en-us/assisted_installer_for_openshift_container_platform/${getYearForAssistedInstallerDocumentationLink()}/html/installing_openshift_container_platform_with_the_assisted_installer/index;

Jira task: https://issues.redhat.com/browse/MGMT-18242

Now in production: https://console.redhat.com/openshift/assisted-installer/clusters/~new


Switch group command not working as expected

Issue Type: Bug
When having Python interactive window open and try to switch to that group (normally with Cmd + 2), the cursor will disappear instead of going to the "command line" (the space to write commands). Then when trying to go back to editor with Cmd + 1, this won't work again so I need to use the mouse to click where I want to go. This is happening since the last update. It's important to mention that this problem is exclusive for Python Interactive. When using editors, it works fine.
VS Code version: Code 1.45.1 (5763d909d5f12fe19f215cbfdd29a91c0fa9208a, 2020-05-14T08:33:47.663Z)
OS version: Darwin x64 19.4.0

System Info

Item
Value

CPUs
Intel(R) Core(TM) i5-5257U CPU @ 2.70GHz (4 x 2700)

GPU Status
2d_canvas: enabledflash_3d: enabledflash_stage3d: enabledflash_stage3d_baseline: enabledgpu_compositing: enabledmetal: disabled_offmultiple_raster_threads: enabled_onoop_rasterization: disabled_offprotected_video_decode: unavailable_offrasterization: enabledskia_renderer: disabled_off_okvideo_decode: enabledviz_display_compositor: enabled_onviz_hit_test_surface_layer: disabled_off_okwebgl: enabledwebgl2: enabled

Load (avg)
1, 2, 2

Memory (System)
8.00GB (1.19GB free)

Process Argv
.

Screen Reader
no

VM
0%

Extensions (2)

Extension
Author (truncated)
Version

python
ms-
2020.5.78807

vim
vsc
1.14.3

Sounds like a webview issue to me. Maybe caused by extension, not sure.

I'm not sure. I disabled the extensions but this kept happening. I had to go back to version 1.44.2 for it to work again.

Hi @mjbvz 👋 I work on the Python extension data science team. We've had multiple users report this issue on our repo: #11808 and #12088.
This bug does not manifest with 1.44.2. In ^1.45, it appears that our webview within the panel doesn't receive focus when the user switches to a group containing it using the Ctrl+1/2 keyboard shortcut. Specifically, focus fires when the user directly clicks on the webview, but not with the keyboard shortcuts.
Would you happen to have an idea of when / how this can be fixed, and any workarounds we can use in the interim to ensure our webview receives focus with keyboard shortcuts?

@joyceerhl Are any other keyboard shortcut not working?

I've only been testing switching groups, so just Ctrl+1/2/3 etc. Sorry if my original comment was ambiguous!

This is a lower priority issue since those keyboard short cuts are not super heavily used.
It sounds like the core of https://github.com/microsoft/vscode-python/issues/11808 is that focus is not restored once the interactive window is refocused. I can repo this just by clicking away from the python interactive window and then clicking on the interactive window tab. I believe that needs to be fixed in the interactive window's implementation

Just to be sure I understand—you're recommending that when the webview panel is focused, we should also explicitly focus the webview? Could you point me to docs for managing focus changes for webview panels?

This is up to your extension. When a webview tab is focused, VS Code focused the webview element but it does not restore focus to any previously focused element within that webview
In your webview, you can just use:
window.addEventListener('focus', () => { });
window.addEventListener('blur', () => { });

to detect when focus is gained or lost

Will give that a try. Thank you!

Hi @mjbvz, I added listeners for focus and blur events on the window itself, and forced a focus on the input box when window receives focus. This did not resolve the issue.
Based on logging in the window focus / blur callbacks, it appears that if I select, unselect, then reselect the interactive window using keyboard shortcuts, on reselect, the webview window gets focus immediately followed by blur, which is what results in the interactive window becoming unresponsive. This still manifests after stripping out all the places in our codebase where we manually focus elements. We do not get the extra blur event if we click directly on the panel tab.
For this reason I think this bug is a result of a change in keyboard shortcut handling and listening for focus / blur on the window is insufficient, since we're getting an extra blur external to our code. Would you be able to suggest any workarounds we can implement while the keyboard shortcut issue is being resolved?

@joyceerhl I see that a focus event is always fired last:

It looks like there is an extra blur in between but the focus remains the last callback

focus is not restored once the interactive window is refocused. I can repo this just by clicking away from the python interactive window and then clicking on the interactive window tab.

I can repro this behavior with the standard Cat Coding demo extension, so I don't think this is our bug. Clicking on the tab for the webview results in a blur being the last callback, so focus gets trapped in the webview, after which I'm unable to navigate away using keyboard shortcuts.

This behavior affects accessibility. Is there a different keyboard-only combination that can enable the user to switch groups and set focus as the original user desires? If not, then I think the priority of this bug warrants a closer look.

Hi, just following up. Is there any fix to this yet? Thank you for looking into this.

Hey @mjbvz, we're getting more users reporting issues with our interactive window and Jupyter notebook viewer. I see that there's a 'help wanted' label on this--I'd be happy to work with you to submit a fix!

Here's the place where we try rebroadcasting keypresses from webviews: https://github.com/microsoft/vscode/blob/49f35453c456dd7189578895d81868e66ee3aab9/src/vs/workbench/contrib/webview/browser/baseWebviewElement.ts#L155
Try looking into why these keypresses are either not rebroadcast or why they are not handled properly as VS Code commands

Hi there, are there any updates, it's been silent here for 4 months? It totally breaks the Python extension workflow for me (and many others). Python is one of the main extensions and MS supported so it'd be fab if you could reconsider priority of this bug.

Just wanted to add that I also find this issue to be a major barrier to effectively using the Python interactive extension. It would be great if this could be prioritized higher.

I've done some debugging on this problem. I believe the root cause of the problem is the fix created by these two commits:
https://github.com/microsoft/vscode/commit/870700e95c18eff7f0827595b521a9d10a243274
https://github.com/microsoft/vscode/commit/88929c7a45ec3d1b0c570113cf222ff92a860f60
What I see happening is that the blur (from the second commit) is also async if the webview has focus already. Meaning it can happen at random times after the delayed focus trigger.
I'm going to submit a PR that I think fixes it and maintains the current behavior as well. This zip has a test extension (minus the gif for the cat) that I used to verify CTRL+1/2 works as expected.
cat-coding-0.0.1.zip

I can still reproduce this on Windows: https://memes.peet.io/img/21-01-8f0f0372-8296-45f8-b503-1d2098378704.mp4
I don't see any PRs on the jupyter side referenced, is there an update I need to take from there?

I can still reproduce this on Windows: https://memes.peet.io/img/21-01-8f0f0372-8296-45f8-b503-1d2098378704.mp4
I don't see any PRs on the jupyter side referenced, is there an update I need to take from there?

Latest bits from jupyter extension should be good enough.

Latest bits from jupyter extension should be good enough.

You might want to try the cat coding example I added to see if that repros for you.

You might want to try the cat coding example I added to see if that repros for you.

I'm on the latest published version of the Jupyter extension, 2020.12.414227025.
The focus works sometimes in the cat coding example, though it's inconsistent. Video: https://memes.peet.io/img/21-01-9e4f1c74-9140-4625-86e0-d722add628e9.mp4

I'm on the latest published version of the Jupyter extension, 2020.12.414227025.
The focus works sometimes in the cat coding example, though it's inconsistent. Video: https://memes.peet.io/img/21-01-9e4f1c74-9140-4625-86e0-d722add628e9.mp4

Yeah we have the same inconsistency in the jupyter extension. I can't repro the problem anymore myself.

Yeah we have the same inconsistency in the jupyter extension. I can't repro the problem anymore myself.

It sounds like this bug makes working in Python interactive mode on remote infrastructure, using only a keyboard, impossible. Is that correct?

@dynamicwebpaige impossible might be too strong a word, but it's certainly harder. When it doesn't work, you'll sometimes end up with focus elsewhere. You can then tab or hit CTRL+1 again to try a second time.

The interactive window now is built into VS Code instead of being a webview, so this issue should not longer happen for it
However I also tested this on Mac and Windows using a simple textarea inside a webview. On Mac, both cmd+# and ctrl+# work for me. On windows: ctrl+# and alt+# are also working for me
If you are still seeing this issue in any webview, please let me know specifically what type of webview you have opened and where you are focused when trying to trigger the shortcuts


Contextual title

So far, this moves the logic into the model as discussed and supports the new container title flag.
To Do:

[ ] Support the cache in the model to prevent flicker on reload
[ ] Support opt-out of contextual title

Issues:

The views themselves can override their static title (such as the folders view in explorer) meaning the model can't always be right. Testing this branch you will see Explorer: Folders instead of EXPLORER: VSCODE
Moving everything into the model means the hover text on the activity bar, the side bar title, and the panel title are all the same, but we've had a somewhat nicer experience with them being different in the merged case. e.g. Explorer: Folders is not as nice as Explorer for activity bar and Folders for Side Bar. Since we need consistency. I've opted for always doing Container: View in the merged case everywhere.

The views themselves can override their static title (such as the folders view in explorer) meaning the model can't always be right. Testing this branch you will see Explorer: Folders instead of EXPLORER: VSCODE

Right. We also have custom views those can update their titles. How about having the title to be updated using IViewDescriptorService ?

Moving everything into the model means the hover text on the activity bar, the side bar title, and the panel title are all the same, but we've had a somewhat nicer experience with them being different in the merged case. e.g. Explorer: Folders is not as nice as Explorer for activity bar and Folders for Side Bar. Since we need consistency. I've opted for always doing Container: View in the merged case everywhere.

Good point. I think ViewContainerModel shall have hasSingleView property based on which ViewPaneContainer can update the title. It means mergeViewWithContainerWhenSingleView remains with ViewPaneContainer options. What do you think?


Add property jobId to progressCallback

Fixed #67.
cc @cjdell.

This looks good to me, let's see if @cjdell will comment here too :) Else I will merge this in soon.


Fix osd_crush_location to prevent systemd error message

With ' in osd_crush_location, systemd will show this error:
ceph-osd-prestart.sh[2931]: Invalid command:  invalid chars ' in 'root=
Signed-off-by: Christian Zunker<EMAIL_ADDRESS>

can you rebase?

Done


dependency: update kube version dependency to v1.18.2

Signed-off-by: Humble Chirammal<EMAIL_ADDRESS>

I have included this in the update for CI jobs with PR #1024

I have included this in the update for CI jobs with PR #1024

You mean the travis/CI part , Isnt it?

@nixpanic any idea why travis didnt run on this PR ?

I have included this in the update for CI jobs with PR #1024

I've dropped the adding of 1.16.9 and 1.18.2 versions from that PR. Lets get them added through this one (as #1024 also addresses the removal).

Can you add the go mod ... commands that you used to update this in the commit message please?

I've dropped the adding of 1.16.9 and 1.18.2 versions from that PR. Lets get them added through this one (as #1024 also addresses the removal).

Ah, sorry, I thought you found issue #1023 and send this PR to test against kubernetes 1.18.2. Now I see that this is something else :+1:

if there is any bug fix that is required we can update it to a minor version.

I agree, if there is no need for us to update, why all the churn in the repo? The commit message (and PR) should explain what bugs are fixed that affect the cephcsi executable.

is there any bug fix in this version that is required for us? or else it's better to wait for 1.19 and than update it.
can we update the vendor only for kube major version? if there is any bug fix that is required we can update it to a minor version.

@Madhu-1 @nixpanic I dont really get the logic. :(. that said, we are not in parity or in the release schedule of Kubernetes, so updating only when the major version is available does not look correct to me.  The minor or patch release are in place with some bug fixes, enhancements..etc. so updating and catching up with what's available is actually a good idea. More or less, Kube ensures the backward compatibility, and also it's not going to break the things in a minor version for sure. We do have e2e ..etc in place to double confirm. can you let me know whats the real concern here ? is it about breakage of the code? or something else?

The main question that needs answering is:

Why update vendor/ to a new Kubernetes version.

If the new version fixes bugs in functions/features that we build into the cephcsi executable, it is of course a good thing. If there are no bugs fixed in the API that we consumer, there is no need to spend time on rebasing, testing and reviewing.
I agree that in general it is good to update to a new version, but I also hope it is done with a good reason. That reason should be explained in the PR and commit message(s).

is there any bug fix in this version that is required for us? or else it's better to wait for 1.19 and than update it.
can we update the vendor only for kube major version? if there is any bug fix that is required we can update it to a minor version.

@Madhu-1 @nixpanic I dont really get the logic. :(. that said, we are not in parity or in the release schedule of Kubernetes, so updating only when the major version is available does not look correct to me. The minor or patch release are in place with some bug fixes, enhancements..etc. so updating and catching up with what's available is actually a good idea. More or less, Kube ensures the backward compatibility, and also it's not going to break the things in a minor version for sure. We do have e2e ..etc in place to double confirm. can you let me know whats the real concern here ? is it about breakage of the code? or something else?

IMO we don't want to keep updating the vendor directory for each patch release at least. we can update the vendor directory if there is a major release or if there is a bug fix which we need

/retest ci/centos/containerized-tests

suppressed by https://github.com/ceph/ceph-csi/pull/1380


Itests failing on microk8s in main

When I try to run the integration tests on main (microk8s), I get:

I noticed that the CI only has LXD env tests. Is it an idea to include microk8s to the substrates on which to run the itests?
To reproduce:
checkout main
tox -vve integration
wait for the boom

I think you need charm to build reactive charms, do the tests work after installing charm?
sudo snap install charm --classic

Agree, it's not an issue with microk8s, but an issue with not having the required tools installed to run the integration tests.
charmed-kubernetes/actions-operator
I believe the integration tests test deploying a machine bundle(https://github.com/charmed-kubernetes/pytest-operator/blob/main/tests/integration/test_pytest_operator.py#L12-L47) into the model
Because of this, deploying into a kubernetes type model is yet to be supported for the integration tests.


some quesitons about the process of images that will input the net

in the "preprocess_image" function  of input_pipeline.py: image = image * 2 - 1
why did you do  this operation? I can't understand~could you tell me the reason?

The InceptionV4 model is pre-trained in this way.