using regex in filter?

Is there the ability to use regex in the filter field?  It would be handy if there is, especially in the case where we want to omit sampleLabels that we don't want to send to ES.
Thanks

Awesome!  Thank you @delirius325
Looking forward to using it in the next version.

Hi @triportland ,
Version 2.6.0 has been released and makes use of the possibility of adding regular expressions to the filter feature. Currently, the JAR is downloadable from the "Release" section on this repository.
Cheers!

Hi @delirius325
Is there any trick to using regex in the filter field?
I tried with this regex expression: (^[^000].*)
and my sample label paterns are:

Normal Sample Label
-000dontsendthissample
The goal is to filter out anything that starts with 000, but so far it's not doing the trick.

Thanks

Tested out the new 2.6.0 version and regex works great.
Thanks @delirius325

Glad to hear this ! @triportland


Create graph cli

Create a minimal cli that can run a graph.

look for graph.groovy by default
Load script as DelegatingScript with a graph as delegatearly
Add binding for graph variable as well
run script

Might be better to just use BaseScript transformation for now. Scripts can simply use grape and set the BaseScript so a graph can be the delegate of the script.


SPDM_DATA_REQ_BASE_ASYM_ALG appears to be dead code

It's in spdm_set_data and spdm_get_data but no other code uses it.

It is set to spdm_context->local_context.algorithm.req_base_asym_alg, which is used in spdm_requester_data_sign().

Ah I see. Thanks!


remove page_allocator and reflector Version

removed page_allocator, and use general purpose allocator
adn reflector the version, improved the readability of some codes
By the way, multiple memory leaks occurred in versions using page_allocator in the past.

This can ensure small-grained memory application without having to apply for a whole page every time.

OMG, bro, why are you still using c_allocator?

OMG, bro, why are you still using c_allocator?

That's a deprecated allocator 😅 when we still used libarchive for extracting. So good find, from your side.

The pr test also passed on Linux, and the segment fault error seemed to be fixed.
It can be merged currently

I think we can also remove linkLibC from the build process.


bump node 18 LTS

Applied mkpr on package.json
sed s/"node": ">=18\.6\.0"/"node": ">=18.7.0"/

:tada: This PR is included in version 1.10.153 :tada:
The release is available on:

npm package (@latest dist-tag)
v1.10.153
GitHub release

Your semantic-release bot :package::rocket:


Refactor and simplify component trampolines

Note that this is based on https://github.com/bytecodealliance/wasmtime/pull/6691

In poking at https://github.com/bytecodealliance/wasmtime/issues/6696 I felt that the amount of boilerplate for defining
new kinds of trampolines in the component model was getting a bit
excessive. There was already 6 different types and I was adding two more
and I had to touch just a few too many places to get this done. In the
end I decided to refactor how trampolines are handled in the component
model to make it much easier to add new kinds of trampolines.
To that end the type-specific counts/lists/etc are all gone now in favor
of a single concept of a trampoline. This means components now track
trampolines in-bulk rather than individually by type. For example
compiling trampolines is now a loop over "compile this list of
trampolines" where previously it was N loops for the N types of
trampolines. The Trampoline definition is where the enum and dispatch
happens where that contains all possible trampolines that a component
could require.
This ended up being a large refactor to the Cranelift component
integration, but there is not intended to be any functional change from
this refactoring. Additionally all trampolines are now removed from the
global initializers list since there's nothing preventing them from
being initialized earlier on during the instantiation process.
Overall this should drastically reduce the number of locations that need
to have trampoline-specific knowledge to translation, the dataflow
graph, and compilation. Nearly everything else can operate over
everything in bulk and forward between these systems.

Ok this should be good to go now that https://github.com/bytecodealliance/wasmtime/pull/6691 has landed

cc @pchickey on that last failure, it may be a spurious failure?
test preview2::pipe::test::sink_write_stream ... FAILED

failures:

---- preview2::pipe::test::sink_write_stream stdout ----
thread 'preview2::pipe::test::sink_write_stream' panicked at 'assertion failed: `(left == right)`
  left: `1024`,
 right: `0`', crates/wasi/src/preview2/pipe.rs:671:9
stack backtrace:
   0: rust_begin_unwind
             at /rustc/8ede3aae28fe6e4d52b38157d7bfe0d3bceef225/library/std/src/panicking.rs:593:5
   1: core::panicking::panic_fmt
             at /rustc/8ede3aae28fe6e4d52b38157d7bfe0d3bceef225/library/core/src/panicking.rs:67:14
   2: core::panicking::assert_failed_inner
   3: core::panicking::assert_failed
   4: wasmtime_wasi::preview2::pipe::test::sink_write_stream::{{closure}}
   5: tokio::runtime::context::runtime::enter_runtime
   6: wasmtime_wasi::preview2::pipe::test::sink_write_stream
   7: core::ops::function::FnOnce::call_once
   8: core::ops::function::FnOnce::call_once
             at /rustc/8ede3aae28fe6e4d52b38157d7bfe0d3bceef225/library/core/src/ops/function.rs:250:5
note: Some details are omitted, run with `RUST_BACKTRACE=full` for a verbose backtrace.

failures:
    preview2::pipe::test::sink_write_stream

test result: FAILED. 13 passed; 1 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.59s

error: test failed, to rerun pass `-p wasmtime-wasi --lib`


Create a timeline

Koong Chan Phong (Peter) - TimeLine

Academic Background

University: Sai Gon University
Degree: Bachelor of Software Engineer
Year: Junior (2021-2026)

Skills

Programming Languages: Java, JavaScript, Python, Latex, PHP
Technologies: Spring Boot, Node.js, Angular, SQL Server, MySQL, Django, Docker, ...etc
Languages: Vietnamese (Native), English (Basic communication), Chinese(Basic communication)

Projects

E-learning Website (Done)

Technologies: PHP MVC, Nodejs, HTML/CSS, Javascript, Docker-compose, AWS S3 storage course
Description: Created a basic e-learning website as a part of a student project. The platform included user authentication, course listing, shopping cart, and payment processing, course reviewing and more. The project also using S3 storage of Amazone to store video, image of a course, using Docker to containing the project in it.

Supermarket management (Done)

Technologies: Java Swing, Barocde Scanner, QR Autogenerative
Description: Created an POS machine in supermarket to scanning product customer bought and Prepare the bill. The platform included user authentication (Flexible delegation of authority), product listing, shopping cart, bill payment, order and payment with QR scanning or more options ....

E-commerce website (In proccess)

Technologies: Spring boot, Spring security, Spring oauth2, Spring cloud, Angular 17
Description: Created a full-stack e-commerce website as a part of a student project. The platform included user authentication, product listing, shopping cart, and payment processing. The project emphasized the integration of frontend and backend technologies to create a seamless user experience.

Achievements

Coding Competitions: Participated and ranked in various coding competitions such as Backend Hackathon 2023.

add a comment


APP-2545: Add key_id UUID to API keys and randomly generate key

APP-2545
Adds the new key_id field to CreateKeyResponse. This addresses Emily's comment here about not currently supporting authentication against resources other than the resource the key was created against. By adding a key_id, we can query against the key_id while passing the secret instead of against the specific resource.

what do you think of calling it id and key? (instead of key_id and key)

WFM!


Dark Mode

I mean this extension is intended for developers and there is no dark mode?
It burns my eyes. Until then I disable the extension.

@huchenme Any progress here?

@equal-l2 sorry was busy with something else, dark mode should be completed within a week 😉

Publishing v1.8.0 which adds dark mode support!


Declare limited support for virtual workspaces

Fixes #2793.
Was able to test creating/deleting function apps and slots. Unable to deploy or create a new function project since access to the local file system is limited. Debugging also seems to not be supported based on the limitations listed here.

Do you not have to declare which commands are and aren't compatible in the package.json? What happens when you try to run a command that's not supported in a virtual workspace?

Do you not have to declare which commands are and aren't compatible in the package.json? What happens when you try to run a command that's not supported in a virtual workspace?

Yes, you are correct. I just saw that in the document. Creating new function projects and deploying seem to be somewhat intuitive since you have to choose a project folder and you can't do that if you have a virtual workspace open. But it probably be good to declare those commands as incompatible. I am not completely sure if debugging would need to be declared since based off the documentation that should be a limitation for all virtual workspaces?

I was able to find a way to deploy via the cloud button and through the command palette which results in an error

But that being said, I don't know if I prefer making the commands disappear completely from context menus. It makes discoverability really difficult. Also, users would have no idea how much functionality that is absent in the virtual workspace compared to local extensions.
SWA declared limited support for virtual workspaces in a different part of the package.json that makes it look like this:

I will say I don't like that there's no hover-over tooltip about why they're disabled, but that's something that VS Code could fix.
This is how that is implemented:
https://github.com/microsoft/vscode-azurestaticwebapps/blob/main/package.json#L137-L144
I'm up for taking opinions on it, but I think we should be consistent between our extensions in how we declare limited support. I don't think we ever had a full discussion about it, but here are the guidelines Alex was following: https://github.com/microsoft/vscode-azurestaticwebapps/issues/380#issuecomment-896308988
Here's Alex's full PR for more context: https://github.com/microsoft/vscode-azurestaticwebapps/pull/489

I will say I don't like that there's no hover-over tooltip about why they're disabled, but that's something that VS Code could fix.

https://github.com/microsoft/vscode/issues/131205
Apparently the onus is on us by using title information. We can probably use conditional when clauses for that?

I agree, I think being consistent between extensions makes the most sense.

Some other commands that don't work:
azureFunctions.addBinding
azureFunctions.appSettings.decrypt
azureFunctions.appSettings.encrypt
azureFunctions.initProjectForVSCode
azureFunctions.installOrUpdateFuncCoreTools
azureFunctions.startJavaRemoteDebug
azureFunctions.startRemoteDebug
azureFunctions.uninstallFuncCoreTools


Implement Extend<A> for Array where A: AsRef<JsValue>

Collections are conventionally expected to implement both FromInterator and Extend traits. More specifically, I need Array to implement Extend in order to build one with futures::StreamExt::collect()

Thanks!


[UTILS-110] Add support for pushing reports to Coveralls.

Resolves #110. Also fixes the misuse of the Scoverage plugin and thus resolves #95.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/bdg-utils-prb/116/Build result: FAILURE[...truncated 8 lines...] > git fetch --tags --progress https://github.com/bigdatagenomics/utils.git +refs/pull/:refs/remotes/origin/pr/ > git rev-parse origin/pr/111/merge^{commit} # timeout=10 > git branch -a --contains ece22fd1f950f807f47b6ba100dd76bcc8eb8c99 # timeout=10 > git rev-parse remotes/origin/pr/111/merge^{commit} # timeout=10Checking out Revision ece22fd1f950f807f47b6ba100dd76bcc8eb8c99 (origin/pr/111/merge) > git config core.sparsecheckout # timeout=10 > git checkout -f ece22fd1f950f807f47b6ba100dd76bcc8eb8c99First time build. Skipping changelog.Triggering bdg-utils-prb ? 2.3.0,2.10,1.6.1,centosTriggering bdg-utils-prb ? 2.6.0,2.11,1.6.1,centosTriggering bdg-utils-prb ? 2.6.0,2.10,1.6.1,centosTriggering bdg-utils-prb ? 2.3.0,2.11,1.6.1,centosTriggering bdg-utils-prb ? 2.3.0,2.11,2.0.0,centosTriggering bdg-utils-prb ? 2.6.0,2.10,2.0.0,centosTriggering bdg-utils-prb ? 2.3.0,2.10,2.0.0,centosTriggering bdg-utils-prb ? 2.6.0,2.11,2.0.0,centosbdg-utils-prb ? 2.3.0,2.10,1.6.1,centos completed with result FAILUREbdg-utils-prb ? 2.6.0,2.11,1.6.1,centos completed with result FAILUREbdg-utils-prb ? 2.6.0,2.10,1.6.1,centos completed with result FAILUREbdg-utils-prb ? 2.3.0,2.11,1.6.1,centos completed with result FAILUREbdg-utils-prb ? 2.3.0,2.11,2.0.0,centos completed with result FAILUREbdg-utils-prb ? 2.6.0,2.10,2.0.0,centos completed with result FAILUREbdg-utils-prb ? 2.3.0,2.10,2.0.0,centos completed with result FAILUREbdg-utils-prb ? 2.6.0,2.11,2.0.0,centos completed with result FAILURE
Test FAILed.

Changes Unknown when pulling f8792e8f1a9ce7208bb05e2654237d44a780c774 on fnothaft:issues/95-110-coverage into ** on bigdatagenomics:master**.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/bdg-utils-prb/117/
Test PASSed.


Filter: account list

Filter the account list based on the amount of total balance > +100k, +50k, +10k, +5k, +1k , ...

@mog Do you have any idea about filtering accounts?
Where should I place filter option in the table?

I am surprised by the question ..filters usually always go above a table with search: https://grab.mogmachine.com/DOuPGoJd  ..you just need to look at taostats and you will see the search, filters etc.
All our tables are also missing page numbers ...you can go to next and previous ..but you can't go to last, or a specific.
I would LOVE the pagination to look and work EXACTLY the same as TaoStats ...is this possible under the same task

'show' top left
'search' top right
'pagination with numbers' bottom right
'current position and total rows' bottom left
'additional filters' top (if space in one row) or collapsable top row under 'show' called 'filter'


Package Manager: show link to the CRAN package page

Page can be used to access the package source repo and doc pages (even better if those links can be shown directly in the package manager)

Low priority


ENH: Git hooks were updated

f8badc3d66f782332e640b68a941d84541ebfa97 updated git hooks.
Bumping the version here to remind everyone to update.
Closes #3229.

Python package failure is unrelated.


Resizing an UIImageView via UIViewPropertyAnimator makes loaded image disappear and placeholder appear

Check List
Thanks for considering to open an issue. Before you submit your issue, please confirm these boxes are checked.

[x] I have read the wiki page and cheat sheet, but there is no information I need.
[x] I have searched in existing issues, but did not find a same one.
[x] I want to report a problem instead of asking a question. It'd better to use kingfisher tag in Stack Overflow to ask a question.

Issue Description
What
Resizing an UIImageView via UIViewPropertyAnimator makes loaded image disappear and placeholder appear. Only happens when image is not cached. I'm attaching sample code and a screen recording.

Reproduce
//
//  ViewController.swift
//  KingFisherResizing
//
//  Created by Martin Pittenauer on 16.02.24.
//

import UIKit
import Kingfisher

class ViewController: UIViewController {

    private lazy var imageView: UIImageView = {
        let imageView = UIImageView()
        imageView.translatesAutoresizingMaskIntoConstraints = false
        imageView.contentMode = .scaleAspectFill
        imageView.clipsToBounds = true
        return imageView
    }()

    lazy var widthConstraint: NSLayoutConstraint = { imageView.widthAnchor.constraint(equalToConstant: 200)
    }()

    override func viewDidLoad() {
        super.viewDidLoad()
        // Do any additional setup after loading the view.
        view.addSubview(imageView)
        NSLayoutConstraint.activate([
            imageView.leadingAnchor.constraint(equalTo: view.leadingAnchor),
            imageView.topAnchor.constraint(equalTo: view.topAnchor),
            imageView.heightAnchor.constraint(equalTo: imageView.widthAnchor, multiplier: 9/16),
            widthConstraint
        ])

        let imageUrl = URL(string: "https://res.cloudinary.com/dg-stage/image/fetch/w_2642/https://dg-stage-production-pictures.s3.eu-west-1.amazonaws.com/be9e66cd3f8fc57d008b5969ad87ce04c385bbbe.jpg?_a=AEABoAB0")!
        let placeholder = UIImage(named: "placeholder")

        imageView.kf.setImage(with: imageUrl, placeholder: placeholder, options: [.transition(.fade(0.4)), .forceRefresh])

        startTimer()
    }

    var fraction: Double = 0.0
    var change: Double = 0.02
    var timer: Timer?
    var animator: UIViewPropertyAnimator?

    func startTimer() {
        widthConstraint.constant = 900
        animator = UIViewPropertyAnimator(duration: 1.0, curve: .easeInOut) { [weak self] in
            self?.view.layoutIfNeeded()
        }
        animator?
            .pauseAnimation()

        timer = Timer.scheduledTimer(withTimeInterval: 0.1, repeats: true) { [weak self] _ in
            guard let self else { return }
            if self.fraction <= 0 {
                change = 0.02
            }
            if self.fraction >= 1 {
                change = -0.02
            }

            self.fraction = self.fraction + change
            animator?.fractionComplete = self.fraction
        }
    }
}

This is caused by the UIView.transition used by Kingfisher in makeTransition() still being part of the UIImageView and being triggered in reverse. It needs to be removed after it is finished.

Ummm...
I used the sample code to try to reproduce the issue, but was unsuccessful. There may be other factors causing the problem...
https://github.com/onevcat/Kingfisher/assets/1019875/7cf6b0b6-8532-4b6b-90e1-0b5789dde32d

Here's the complete reproduction Xcode project:
samplecode.zip


Add Python .dist-info

Description
Closes #1088

#1088

Add a .dist-info directory when cmake --installing the project with Python enabled. This effectively prevents a pip install from overwriting it, with caveats (see below).

[x] I have updated the release notes.
[x] I have updated all relevant user documentation.

Reviewer Notes
If this looks good, then I propose to simply duplicate it in OpenAssetIO-MediaCreation, rather than make it generic and portable and figure out a way for projects to share CMake libraries.  If we had more target projects, or there was expectation this feature would change frequently, then putting the effort in would be worthwhile.  But not for the sake of two projects.
The CI is structured differently than the rest of our workflows. For simplicity, it uses bash on all platforms, with the knock on effect of using the default CMake generator for the platform (see commit), and is roughly what I propose in #1114 .
CI only tests the effect we want, rather than deep tests of the dist-info structure. I propose to do that as part of #838, if needed.
Test Instructions
As noted above, CI tests are limited to checking that pip install fails as expected. You may wish to manually inspect the contents of the installed files under dist-info.
pip will warn when installing openassetio into an environment where the PYTHONPATH contains another copy of openassetio, e.g.

Not uninstalling openassetio at [...], outside environment

but will still install a competing copy.
However, if openassetio is installed into the Python environment directly, the we get an error, e.g.

ERROR: Cannot uninstall openassetio 1.0.0a14, RECORD file not found. Hint: The package was installed by cmake.

and pip fails to overwrite the CMake installed openassetio.

Oh,BUILDING.md needs updating too

Oh,BUILDING.md needs updating too

What's the specific issue with BUILDING.md?  The new CMake option was added.

Oh,BUILDING.md needs updating too

What's the specific issue with BUILDING.md? The new CMake option was added.

Lol, sorry don't know how I missed that! I may have been inadvertently looking at the tree for just one commnit 🙃 sorry about that. Ignore me.


[Extension Host] FetchError2: request to http://<IP_ADDRESS>:8080/completion failed

Before submitting your bug report

[X] I believe this is a bug. I'll try to join the Continue Discord for questions
[X] I'm not able to find an open issue that reports the same bug
[X] I've seen the troubleshooting guide on the Continue Docs

Relevant environment info
- OS: Linux Mint 21.3 "Virginia" Cinnamon Edition 64-bit
- Continue: v0.8.12
- IDE: 1.86.1
- Model: WizardCoder-7b (llama.cpp)

Description
Getting FetchError 2 in vscode when trying to run WizardCoder-7b (llama.cpp)
Bellow is the screenshot:

To reproduce
Add model to config.js
    {
      "title": "WizardCoder-7b",
      "model": "wizardcoder-7b",

      "requestOptions": {
        "caBundlePath": "/media/prath/Main Disk/Programming/FYP/MultiPDFchatMistral-7B/cert.pem"
      },

      "completionOptions": {},
      "provider": "llama.cpp"
    }

Note: I have read the troubleshooting page and added the certificate

I have generated the certificates like this:
sudo apt-get install openssl

openssl req -x509 -newkey rsa:2048 -keyout key.pem -out cert.pem -days 3650

openssl rsa -in key.pem -out nopassword.key

cat nopassword.key > server.pem
cat cert.pem >> server.pem

my folder dir looks like this

Log output
[Extension Host] FetchError2: request to http://<IP_ADDRESS>:8080/completion failed, reason: connect ECONNREFUSED <IP_ADDRESS>:8080
	at ClientRequest.<anonymous> (/home/prath/.vscode/extensions/continue.continue-0.8.12-linux-x64/out/extension.js:160783:14)
	at ClientRequest.emit (node:events:526:35)
	at Socket.socketErrorListener (node:_http_client:501:9)
	at Socket.emit (node:events:514:28)
	at emitErrorNT (node:internal/streams/destroy:151:8)
	at emitErrorCloseNT (node:internal/streams/destroy:116:3)
	at process.processTicksAndRejections (node:internal/process/task_queues:82:21)
notificationsAlerts.ts:42 Continue error: request to http://<IP_ADDRESS>:8080/completion failed, reason: connect ECONNREFUSED <IP_ADDRESS>:8080

@prathameshza is there a curl request to this same URL that you can get to succeed? And you are running llama.cpp's non-OpenAI ./server example, right?

@prathameshza is there a curl request to this same URL that you can get to succeed? And you are running llama.cpp's non-OpenAI ./server example, right?

I tried to ping the address which gives error.
Also I missed to configure the model, so i followed this steps:

But I am getting this error:
llm_load_print_meta: EOS token        = 2 '</s>'
llm_load_print_meta: UNK token        = 0 '<unk>'
llm_load_print_meta: LF token         = 13 '<0x0A>'
llm_load_tensors: ggml ctx size =    0.00 MiB
llama_model_load: error loading model: create_tensor: tensor 'token_embd.weight' not found
llama_load_model_from_file: failed to load model
llama_init_from_gpt_params: error: failed to load model 'models/ggml-vocab-llama.gguf'
{"timestamp":1708505822,"level":"ERROR","function":"load_model","line":380,"message":"unable to load model","model":"models/ggml-vocab-llama.gguf"}
terminate called without an active exception
Aborted (core dumped)

After this command:
./server -c 4096 --host <IP_ADDRESS> -t 16 --mlock -m models/ggml-vocab-llama.gguf

@prathameshza it looks like this might just have been an invalid gguf file, or an outdated format (I believe there were updates around this time). I'm going to close the issue, but I hope you've had the chance to solve this, and if not please don't hesitate to open another issue!


Propagate errors= keyword through dask.bytes

Previously we didn't pass the errors= keyword cleanly through dask.bytes
This affects db.read_text
cc @martindurant

Looks fair enough to me.

Thanks for the review


added az-dashboard

Issue #, if available: NA
Description of changes:

create az-dashboard
created observability stack that will create az-dashboard and multi-region connectivity dashboard*
removed separate multi region connectivity stack and integrated it into observability dashboard
added new ssm-parameters (alb, asg for ecs and eks)
moved few single ssm parameters that were created separately to bundled creation of ssm params (in services.ts)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@bach74  I don't see the update in the buildspec.

updated buildspec


Transactional AddMember

This pull request adds a new file teams/transactions.go that introduces AddMemberTx struct with methods. It can be used to add one or more member to a team that may or may not need to post multiple signatures to achieve the task, e.g.:

first cancel existing keybase-type invite, then add member with ChangeMembership (two sigs)
first remove existing member old UV, then add new member UV (one sig)
first remove existing member old UV, then add new keybase-type invite (two sigs).

AddMemberTx has payloads list of values that are either *SCTeamInvites or *keybase1.TeamChangeReq. When adding members, functions will either find existing payload of needed type, or add a new one. When tx.Post is called, payloads are transformed to SCTeamSections, and then chain of signatures is created to be posted using sig/multi. No serverside changes were needed to get this to work.

Sure!
When adding member to a team we have the following decisions to make:

If it's a PUKless user
a) See if there is already an invite for given uid%seqno.
If it's a crypto user
a) See if there is already a member with given uid%seqno
for both:
a) Remove old invites for uid
b) Remove old members for uid

Right now we add members using AddMemberByID (when triggered by user action), team.ChangeMembership in SBS handler, Seitan handler, and AddMemberBestEffort in open teams request handler.
AddMemberByID tries to execute this properly, but it will not try to remove old crypto memberships if user is a pukless user; and it won't remove old invites when adding crypto membership.
ChangeMembership does not do any of that, just posts a link, so callers have to figure things out on their own and usually do not do a good job either. SBS handler tries to remove old version of crypto members, but not old invites.
AddMemberBestEffort will remove old crypto members and old invites, but to its work sometimes it has to post two links (ChangeMembership and Invite), and it does not do this in transaction, it posts one, repolls team, and post the second one. If second one fails, there is no way to rollback first one.
Additionally, most of the code that tries to remove old versions will only remove one old version at most. So if there's an old team that has multiple uid duplicates (back when we did not care about that at all), only one at most will be cleared up. Transaction code does better job at sweeping old entries.
What this PR introduces is a flexible API to manage a chain of one or more signatures that would be posted using one API call, so adding both is atomic, API server will either append all or none. Right now only AddMemberByID is changed to use new transaction client API, but after this is more battletested, subsequent tickets can be created to change other member adders as well.
Is there anything specific I should also explain?

I talked with Max and basically I think this is good but am struggling to feel confident about the details. So he's going to take a look as well.

I see, thank you. We can also feature flag this and have regular users fall back to current way

Wiadomość napisana przez Miles Steele<EMAIL_ADDRESS>w dniu 02.02.2018, o godz. 14:31:
I talked with Max and basically I think this is good but am struggling to feel confident about the details. So he's going to take a look as well.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.


Bug: 表格组件（vxe-table）自定义单元格显示异常

Version
Vben Admin V5
Describe the bug?
使用表格组件自定义单元格渲染图片或者多个tag组件会被挤压导致显示不全
Reproduction
使用表格组件自定义单元格渲染图片或者多个tag组件会被挤压导致显示不全
System Info
System:
    OS: Windows 11 22631.3880
    CPU: 13th Gen Intel(R) Core(TM) i9-13900H   2.60 GHz
    Memory: 21.3 GB / 32.0 GB
  Binaries:
    Node: 22.11.0 - D:\Application\nodejs\node.exe
    npm: 10.9.0 - D:\Application\nodejs\npm.cmd
    pnpm: 9.14.2 - D:\Application\nodejs\pnpm.cmd
  Browsers:
    Chrome: 131.0.6778.87

Relevant log output
No response
Validations

[X] Read the docs
[X] Ensure the code is up to date. (Some issues have been fixed in the latest version)
[X] I have searched the existing issues and checked that my issue does not duplicate any existing issues.
[X] Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.
[X] The provided reproduction is a minimal reproducible example of the bug.

去看看VxeTable的文档。
gridOptions.showOverflow = false


flyTo doesn't properly center to the LngLat value of the marker

I'm trying to get the map to zoom in to level 14 when clicking on markers with a home icon. I have implemented it like this:
	<MarkerLayer
		applyToClusters={false}
		asButton
		on:click={(event) => {
			event.detail.map.flyTo({
				center: event.detail.marker.getLngLat(),
				zoom: 14
			});
		}}
	>

<Icon icon="mdi:home" />

	</MarkerLayer>

But for some reason when I zoom in from level 0 to level 14 in one go (which is a big zoom distance) the marker ends up off-center.  I've added a video which demonstrates the issue. Only when I click the marker again after the initial flyTo has completed, the map centers itself correctly around the marker.
https://github.com/dimfeld/svelte-maplibre/assets/51750966/d4777eb2-cc5d-4c8e-b783-fbd62a545c1c
Could this be a bug? Or am I implementing something wrong?

Hmm... that should work fine. I think there are 2 possibilties:

Maplibre itself is just imprecise when you do this
svelte-maplibre is interfering somehow

I'll take a look and get back to you on what I discover.

So it looks like the issue here is that MarkerLayer uses map.querySourceFeatures to get the features that it should be looking at, and there's some precision loss on the data that comes back from this.
Here's some output from a plain JS example I created just to make sure that I wasn't doing something weird:

One thing you could probably do is to use the ID of the feature (at event.detail.feature.id) that comes with the event to look up the feature in the original data and flyTo the exact coordinates there instead.
Unfortunately I don't think there's much I can do about this in the library itself, though let me know if you come up with some idea.

@dimfeld Thanks for your response! I went with your suggestion of using the feature id to get the original coordinates and it worked! The flyTo() function now centers the map correctly around the selected marker.
For anyone encountering the same problem in the future, here is my simplified implementation on how I fixed this issue:

<MarkerLayer
  applyToClusters={false}
  asButton
  let:feature
  on:click={(event) => {
	  const originalFeature = getOriginalFeature(event.detail.feature);
	  if (!originalFeature || originalFeature.geometry.type !== 'Point') return;

	  event.detail.map.flyTo({
		  center: [originalFeature.geometry.coordinates[0], originalFeature.geometry.coordinates[1]],
		  zoom: 14
	  });
  }}
>

<Icon icon="mdi:home" />

</MarkerLayer>

Glad to hear it!


Updated the SimMetrics somewhat

Hey, I noticed you're still using the old version. I've updated and upgraded it quite a bit, fixed a bucket of bugs too.

Urgh. Wrong way.


Navbar

Removed logo, added some CSS to make it look like the menu on the right.

This looks really clean, awesome!!
One of the image is broken in the preview, but I am going to assume this is a netlify weirdness.


update ui mod name

Update ui mod name to make PD can compile with tidb-dashboard.

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@e68ee4b). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff            @@
##             master   #1115   +/-   ##
========================================
  Coverage          ?   7.05%
========================================
  Files             ?      32
  Lines             ?    1943
  Branches          ?       0
========================================
  Hits              ?     137
  Misses            ?    1795
  Partials          ?      11

Flag
Coverage Δ

be_integration_test_v4.0.1
7.05% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e68ee4b...a0d68e0. Read the comment docs.


Fix #21: Fix importing without having to change system path manually.

Hey @MasterScrat, Could you take a look at this when you get the time? Thanks and cheers!

Awesome :grin:

Works for me, but I'm not sure how :-/ And IntelliJ complains about the imports.
How did you come up with this?

Basically hangouts.py is inside parsers/ so importing from parsers/ doesn't make sense to the program. If you do relative imports, they have to be in the place you said they are.
logging shouldn't be imported from init this way, but logging should be done in each file individually. Is that why your IDE is complaining?


Inquiry about the Possibility of Duplicate Retouching Operations in Reinforcement Learning Mode

Dear Dr. Hu,
I hope this message finds you well. I am writing to inquire about your reinforcement learning model designed for retouching images. Specifically, I am interested in understanding whether the model is capable of selecting duplicate retouching operations for a single image. For instance, I would like to know if the model can make decisions that result in the following sequence of retouching operations: gamma, contrast, exposure, contrast, with the contrast operation being repeated twice within this sequence.
Thank you for your time and consideration. I look forward to your response.

You can find the RL Parameters named filter_usage_penalty in config.
If you set it to 1 and each time the agent reuse a filter, a penalty is subtracted from the reward.
So the model will not make decisions you discribed.


provide more information for QueryException

Q
A

Bug Fix?
no

New Feature?
yes

BC Breaks?
no

Deprecations?
no

Fixed Tickets
#10

License
MIT

closes #10

A new inspection was created.

The inspection completed: 6 updated code elements

A new inspection was created.

The inspection completed: 6 updated code elements


Wranger generate errors with segmentation fault when installing cargo-generate

🐛 Bug report
Describe the bug
When running wrangler generate my-app https://github.com/cloudflare/worker-typescript-template I encounter a segmentation fault:
$ wrangler generate my-app https://github.com/cloudflare/worker-typescript-template
⬇   Installing cargo-generate v0.5.0...
Segmentation fault (core dumped)

Reproduce the bug
A list of steps to reproduce the bug.

Create a new empty folder
Inside folder run VS Code: code .
In VS Code, configure a new DevContainer. Select a Node-16 container, with Rust selected as an extra feature.
Once project is reopened in the container, open a new terminal and install wrangler: cargo install wrangler
Attempt to generate a typescript project: wrangler generate my-app https://github.com/cloudflare/worker-typescript-template

Expected behavior
Project template is generated, no segmentation faults
Environment and versions
Fill out the following information about your environment.

operating system: Debian Buster, running a Docker container with Debian Bullseye
output of wrangler -V: wrangler 1.19.5
output of node -v: v16.13.1
content of wrangler.toml: No such file exists - I am trying to generate it

Thanks for reporting this issue! Wrangler v1 is now deprecated and support is only being provided for critical updates or security concerns. As such, we are closing this issue.
New versions of Wrangler are maintained in the workers-sdk repo. If you are running into a similar issue with wrangler v2, please report it in the workers-sdk repo. For more info about wrangler v1 deprecation, please check out our blog post.


Fixes #1071. Toplevel.GetTopLevelSubviews (). Changed from HashSet to IList.

Unfortunately the feature to navigate through all Application.Top's subviews is not working on Unix because there are no way to get if the Control and Shift keys are pressed together with the Tab key.

Unfortunately the feature to navigate through all Application.Top's subviews is not working on Unix because there are no way to get if the Control and Shift keys are pressed together with the Tab key.

Here how Ctrl+Tab and Shift+Ctrl+Tab works on the WindowsAndFrameViews scenario:

Here how Ctrl+Tab and Shift+Ctrl+Tab works on the WindowsAndFrameViews scenario:

Nice work!

Nice work!


Fix failing dependencies

Reason
The packaces sqlite3 and oracledb are causing a lot of trouble when trying to run npm install on a lot of machines. For devices with apple silicon chips, there are no pre-built packages available, and manually building them does require some advanced knowledge
Measures
Moved sqlite2 and oracledb from depencies to optional-dependencies.
npm tries to install these, but doesn't fail the entire installation process, if one of these packages fails to install.
To make sure that the user has all the packages he needs to, I added a script that checks presence of the dependencies needed for the selected database type and aborts the run, if they are missing.
Tests
Tests did run fine, except for user logout route, which always fails on my machine.

I like this. This is useful

i may know why your logout route fails too. there's an issue with a specific line that renders errors for express, that produces an error. i have it commented out on all of my machines or you get 5xx errors and have to manually go to logout url to remove the session. i think i raised an issue with it regarding cloudflare/nginx, but they dont seem to be at fault

LGTM!


Basic example with a remote LiteLLM

Hi,
I'm trying to run the basic example using LiteLLM with ollama2 model running in a container pulling from: https://hub.docker.com/r/litellm/ollama but I don't get the to reach the LLM. It seems the request is created as http://<IP_ADDRESS>:8000/api/generate but the LLM is not reached properly and returns 404.
See more details below.
Any idea?
Thanks!
More details:
container is started with: docker run -p 8000:8000 --name ollama litellm/ollama
I ran a part of an autogen demo and the litellm container seems to work, I mean the server is reached and the llm server replies. Then autogen fails in another step, so I am trying CrewAI instead.
I am trying to run the CrewAI example as described in the README.md, these are the changes I made:

from crewai import Agent, Task, Crew, Process
from langchain.schema import HumanMessage
from langchain_community.chat_models import ChatLiteLLM
from litellm import litellm

ollama_chatlitellm = ChatLiteLLM(model="ollama/ollama2",api_base="http://<IP_ADDRESS>:8000", api_type="open_ai", api_key="")

researcher = Agent(
  role='Researcher',
  goal='Discover new insights',
  backstory="You're a world class researcher working on a major data science company",
  verbose=True,
  allow_delegation=False,
  llm=ollama_chatlitellm,
  debug_mode=True
)

#  ... the rest is the same as in the README.md

Client logs:
Working Agent: Researcher
Starting Task: Investigate the latest AI trends ...

> Entering new AgentExecutor chain...
kwargs[caching]: False; litellm.cache: None

LiteLLM completion() model= ollama2; provider = ollama

LiteLLM: Params passed to completion() {'functions': None, 'function_call': None, 'temperature': 1, 'top_p': None, 'stream': False, 'max_tokens': 256, 'presence_penalty': None, 'frequency_penalty': None, 'logit_bias': None, 'user': None, 'response_format': None, 'seed': None, 'tools': None, 'tool_choice': None, 'max_retries': None, 'logprobs': None, 'top_logprobs': None, 'custom_llm_provider': 'ollama', 'model': 'ollama2', 'n': 1, 'stop': ['\nObservation']}

LiteLLM: Non-Default params passed to completion() {'temperature': 1, 'stream': False, 'max_tokens': 256, 'n': 1, 'stop': ['\nObservation']}
self.optional_params: {'num_predict': 256, 'temperature': 1, 'stop_sequences': ['\nObservation']}
PRE-API-CALL ADDITIONAL ARGS: {'api_base': 'http://<IP_ADDRESS>:8000/api/generate', 'complete_input_dict': {'model': 'ollama2', 'prompt': "You are Researcher.\nYou're a world class researcher working on a major data science company\n\nYour personal goal is: Discover new insights\n\nTOOLS:\n------\nYou have access to the following tools:\n\n\n\nTo use a tool, please use the exact following format:\n\n```\nThought: Do I need to use a tool? Yes\nAction: the action to take, should be one of [], just the name.\nAction Input: the input to the action\nObservation: the result of the action\n```\n\nWhen you have a response for your task, or if you do not need to use a tool, you MUST use the format:\n\n```\nThought: Do I need to use a tool? No\nFinal Answer: [your response here]\n```This is the summary of your work so far:\nBegin! This is VERY important to you, your job depends on it!\n\nCurrent Task: Investigate the latest AI trends\n", 'num_predict': 256, 'temperature': 1, 'stop_sequences': ['\nObservation'], 'stream': False}, 'headers': {}, 'acompletion': False}

POST Request Sent from LiteLLM:
curl -X POST \
http://<IP_ADDRESS>:8000/api/generate \
-d '{'model': 'ollama2', 'prompt': "You are Researcher.\nYou're a world class researcher working on a major data science company\n\nYour personal goal is: Discover new insights\n\nTOOLS:\n------\nYou have access to the following tools:\n\n\n\nTo use a tool, please use the exact following format:\n\n```\nThought: Do I need to use a tool? Yes\nAction: the action to take, should be one of [], just the name.\nAction Input: the input to the action\nObservation: the result of the action\n```\n\nWhen you have a response for your task, or if you do not need to use a tool, you MUST use the format:\n\n```\nThought: Do I need to use a tool? No\nFinal Answer: [your response here]\n```This is the summary of your work so far:\nBegin! This is VERY important to you, your job depends on it!\n\nCurrent Task: Investigate the latest AI trends\n", 'num_predict': 256, 'temperature': 1, 'stop_sequences': ['\nObservation'], 'stream': False}'

Give Feedback / Get Help: https://github.com/BerriAI/litellm/issues/new
LiteLLM.Info: If you need to debug this error, use `litellm.set_verbose=True'.

Logging Details: logger_fn - None | callable(logger_fn) - False
Logging Details LiteLLM-Failure Call
self.failure_callback: []
Retrying langchain_community.chat_models.litellm.ChatLiteLLM.completion_with_retry.<locals>._completion_with_retry in 4.0 seconds as it raised APIConnectionError: {"detail":"Not Found"}.
kwargs[caching]: False; litellm.cache: None

LiteLLM completion() model= ollama2; provider = ollama

LiteLLM: Params passed to completion() {'functions': None, 'function_call': None, 'temperature': 1, 'top_p': None, 'stream': False, 'max_tokens': 256, 'presence_penalty': None, 'frequency_penalty': None, 'logit_bias': None, 'user': None, 'response_format': None, 'seed': None, 'tools': None, 'tool_choice': None, 'max_retries': None, 'logprobs': None, 'top_logprobs': None, 'custom_llm_provider': 'ollama', 'model': 'ollama2', 'n': 1, 'stop': ['\nObservation']}

LiteLLM: Non-Default params passed to completion() {'temperature': 1, 'stream': False, 'max_tokens': 256, 'n': 1, 'stop': ['\nObservation']}
self.optional_params: {'num_predict': 256, 'temperature': 1, 'stop_sequences': ['\nObservation']}
PRE-API-CALL ADDITIONAL ARGS: {'api_base': 'http://<IP_ADDRESS>:8000/api/generate', 'complete_input_dict': {'model': 'ollama2', 'prompt': "You are Researcher.\nYou're a world class researcher working on a major data science company\n\nYour personal goal is: Discover new insights\n\nTOOLS:\n------\nYou have access to the following tools:\n\n\n\nTo use a tool, please use the exact following format:\n\n```\nThought: Do I need to use a tool? Yes\nAction: the action to take, should be one of [], just the name.\nAction Input: the input to the action\nObservation: the result of the action\n```\n\nWhen you have a response for your task, or if you do not need to use a tool, you MUST use the format:\n\n```\nThought: Do I need to use a tool? No\nFinal Answer: [your response here]\n```This is the summary of your work so far:\nBegin! This is VERY important to you, your job depends on it!\n\nCurrent Task: Investigate the latest AI trends\n", 'num_predict': 256, 'temperature': 1, 'stop_sequences': ['\nObservation'], 'stream': False}, 'headers': {}, 'acompletion': False}

Server Logs
INFO:     <IP_ADDRESS>:61256 - "POST /api/generate HTTP/1.1" 404 Not Found
INFO:     <IP_ADDRESS>:61258 - "POST /api/generate HTTP/1.1" 404 Not Found
INFO:     <IP_ADDRESS>:61260 - "POST /api/generate HTTP/1.1" 404 Not Found

...

can you first test your LiteLLM with ollama2 model setup to make sure it works by itself? maybe it gives you a curl command to run to test the api endpoint ?

Thanks @fxtoofaan  I decide to run crewAI directly with ollama without using LiteLLM and it worked. I followed ollama docker image instructions:

docker run -d -v ollama:/root/.ollama -p 11434:11434 --name ollama ollama/ollama
docker exec -it ollama ollama run llama2

Best,


NuttX discovery fix.

This pull request fixes the compilation of the discovery profile in NuttX.

Build status:

Linux
Windows


Better way of locating the esp32-camera dependency in the cmake build script

The way it is done now it makes no assumptions as to the location of the component. It queries the IDF build system as to its location. This allows for adding the include paths to this project.

Hi Kevin,
I think our friend here does not do any updates anymore. That is why I restarted the project with an improved library: https://github.com/cnadler86/micropython-camera-API
I will take a look at your improvements in here for my cmake file in the next days/weeks.


Remove dead code

testing in jenkins

passed jenkins, good to review

Updated to switch to --bind-gpg-agent=false. We'll need to wait until the stable branch switches to this before removing the --experimental flag from cork


Videoview will transparent when start play the video.

setbackground for the video view

not work

try set background for the videoview parent


Object Store uses deprecated

Object Store option uses  deprecated
https://github.com/ibm-bluemix-mobile-services/bluemix-objectstorage-serversdk-swift.git
Will it be transitioning to Cloud Object Store?
Thanks

Hi. We do not currently have plans to release a Swift SDK for IBM Cloud Object Storage. You can use the REST API from your Swift application though - see https://console.bluemix.net/docs/services/cloud-object-storage/api-reference/about-compatibility-api.html#about-the-ibm-cloud-object-storage-api for more information.

Easier to say than do reliably, the REST API notes advises ....
It is not mandatory to use published S3 API SDKs; custom software can leverage the API to integrate directly with Object Storage. However, using published S3 API libraries provide advantages such as authentication/signature generation, automatic retry logic on 5xx errors, and pre-signed url generation. Care must be taken when writing software that uses the API directly to handle transient errors, such as by providing retries with exponential backoff when receiving 503 errors.


Remove inner and outer block mixins

Replace outer-block with new grid layout placeholder
%site-width-container
Remove inner-block as the left and right margins are now set by %site-width-container

When the template is compiled, the Sass warnings for the deprecated
grid mixins will no longer appear.

This is a good change, and one that should happen. My only worry is that it changes the width of any content which is added to the template in footer_top. For example on GOV.UK we will need to adjust the width of our footer links block. Wondering how many other people use that space.

.footer-categories on static needs to be updated to use grid columns before this can be merged (along with others?).

I don't think static blocks this PR. Updating .footer-categories only needs to be done when the govuk_template version is bumped on static.
My only concern echo's Edds, that this may affect other consumers using the footer in a similar way to us, but I think this is fine if we bump to 0.18.0 and make the CHANGELOG clear (and cross link this discussion).
Any objections to me merging?

None if you’re happy, go for it.
On Wed, Mar 2, 2016 at 11:05 AM, David Singleton<EMAIL_ADDRESS>wrote:

I don't think static blocks this PR. Updating .footer-categories only
needs to be done when the govuk_template version is bumped on static.
My only concern echo's Edds, that this may affect other consumers using
the footer in a similar way to us, but I think this is fine if we bump to
0.18.0 and make the CHANGELOG clear (and cross link this discussion).
Any objections to me merging?
—
Reply to this email directly or view it on GitHub
https://github.com/alphagov/govuk_template/pull/134#issuecomment-191189609
.

:clap:


Canvas.drawShadow needs to be multi-view compatible

Canvas.drawShadow requires DPR to calculate shadow length, and currently it gets the DPR implicitly from the first window:
// lib/ui/painting/canvas.cc
  SkScalar dpr = static_cast<float>(UIDartState::Current()
                                        ->platform_configuration()
                                        ->get_window(0)
                                        ->viewport_metrics()
                                        .device_pixel_ratio);

This is not compatible with multi-view, because in multi-view there might not be a window 0 if the platform disables implicit view. This DPR should come from the target view of this drawing command.
However, the drawShadow signature does not allow inserting a view ID or DPR anywhere. There's an elevation parameter, but it's a pre-DPR length.
  void drawShadow(Path path, Color color, double elevation, bool transparentOccluder);

To solve this in a non-breaking way, we can either

create a new drawShadowWithDpr that has an additional parameter float dpr, or
create a new drawShadowOnView that has an additional parameter int viewId.

Either way, we'll need to deprecate drawShadow afterwards.

cc @jonahwilliams

Please don't add drawing commands that accept view ids. Pictures/Layers should be display agnostic and encoding view id information into them will lead to confusing bugs down the line

@jonahwilliams Is your recommendation to create the shadow display list ops without using the device pixel ratio since dpr is display-specific? If so, this is a bit outside of our expertise and we will likely need help from engine folks.
From my understanding, Canvas::drawShadow uses the device pixel ratio to:

Create a DrawShadowOp or DrawShadowTransparentOccluderOp display list operation (here)
Update the op bounds (here)

To remove the first use, it seems DlSkCanvasDispatcher::DrawShadow and DlDispatcher::drawShadow would need to look up the device pixel ratio from their respective canvases. Is that possible?
The second one looks harder to fix. Would we need to switch to AccumulateUnbounded?

I would either take a device pixel ratio when the operation is recorded, or I would configured the backend to apply the dpr correction when rendering (my vote).
I wouldn't make the picture depend on a particular view ID. The picture may be recorded and then displayed much later on a different view, and the original view Id could be gone.

or I would configured the backend to apply the dpr correction when rendering (my vote).

I'd prefer this option too, but I think it might come down to a question that we have yet to answer: should DPR be counted as a property of DL, or a property to execute DL?  But since the canvas is view-agnostic (so that it can be applied to an image), if we don't include a pixel ratio in drawShadow, then it's impossible to draw the shadow properly onto an image.
So I think the two options are:

Make pixel ratio a DL property: Then we need a new drawShadow method that takes pixel ratio into account (either a new argument pixel_ratio, or elevation should be post-pixel-ratio).
Make pixel ratio a property to execute DL: Then we need toImage to provide a pixel ratio.

I cannot stress this enough: toImage provides a pixel ratio.

Deferring providing DPR requires the entire bound calculation

This is infeasible.

Isn't AccumulateUnbounded meant for these kinds of scenarios where the op bounds are unknown?

That works by marking drawing operations as taking up an unknown region of space, essentially pessimizing all rendering involving shadows. That seems like a terrible tradeoff to make to handle a questionable edge case in shadow rendering.

Isn't AccumulateUnbounded meant for these kinds of scenarios where the op bounds are unknown?

I see. Thanks. Let me see if we can make it using AccumulateUnbounded.

That works by marking drawing operations as taking up an unknown region of space, essentially pessimizing all rendering involving shadows. That seems like a terrible tradeoff to make to handle a questionable edge case in shadow rendering.

It is indeed the case. Without knowing the DPR, the entire corner against the direction of the light source is subject to shadow. Do you think it's a sufficient reason to decide on option 1 then?


Enable the use of redux dev tools if installed

https://github.com/zalmoxisus/redux-devtools-extension

at second thoght, I would rather integrate with : https://github.com/reduxjs/redux-devtools
Will push an update once this is ready for review


Proposed GitHub templates for bugs, feature requests, and pull requests

Purpose

New GitHub templates for bug reports, new feature requests, and pull requests.

Proposed Changes

[ADD] Template for bug reports
[ADD] Template for feature requests
[ADD] Template for pull requests

Testing

For live issue ticket examples, see: https://github.com/riverma/terraformly/issues/new/choose
For live pull request examples, this pull request itself is an example

FYI @galenatjpl


exec.Command passes the binary name, not the absolute Path, as argv[0]

What version of Go are you using (go version)?

$ go version
go version go1.16.4 linux/amd64

Does this issue reproduce with the latest release?
That is the latest release
What operating system and processor architecture are you using (go env)?
go env Output
$ go env
GO111MODULE="on"
GOARCH="amd64"
GOBIN=""
GOCACHE="/home/eloff/.cache/go-build"
GOENV="/home/eloff/.config/go/env"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOINSECURE=""
GOMODCACHE="/home/eloff/go/pkg/mod"
GONOPROXY=""
GONOSUMDB=""
GOOS="linux"
GOPATH="/home/eloff/go"
GOPRIVATE=""
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/usr/local/go"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/usr/local/go/pkg/tool/linux_amd64"
GOVCS=""
GOVERSION="go1.16.4"
GCCGO="gccgo"
AR="ar"
CC="gcc"
CXX="g++"
CGO_ENABLED="1"
GOMOD="/home/eloff/projects/xxx/go.mod"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build1579395567=/tmp/go-build -gno-record-gcc-switches"

What did you do?

cmd = exec.Command("psql", "host=<IP_ADDRESS> user=xxx")
cmd.Env = append(cmd.Env, "PGPASSWORD="+conf.Password)

fmt.Println(cmd.Args)
fmt.Println(cmd.Path)

What did you expect to see?

/usr/lib/postgresql/12/bin/psql
[/usr/lib/postgresql/12/bin/psql host=<IP_ADDRESS> user=xxx]

What did you see instead?

/usr/lib/postgresql/12/bin/psql
[psql host=<IP_ADDRESS> user=xxx]

I don't know if this is a bug. argv[0] can be any arbitrary name of the executable, it doesn't have to be the absolute path. However, psql at least expects it to be an absolute path and fails:

could not find a "psql" to execute
psql: fatal: could not find own program executable
psql exited with code 1

That leaves two questions:

Is it better to use the absolute path as argv[0]?
Can this be changed without breaking backwards compatibility?

If the answer to either of these questions is no, could we just document this behavior in the docs for Command? It's already documented that it will use LookPath, but not that it won't use that value as argv[0] - it uses the original value for name instead. That would have saved me a lot of effort.
The workaround here is simply to invoke LookPath first:

path, err := exec.LookPath("psql")
cmd = exec.Command(path, "host=<IP_ADDRESS> user=xxx")

Duplicate of #17536
and it is documented as:

Args[0] is always name, not the possibly resolved Path.

Nevermind, I'm blind. It is indeed documented.


Free RAM on IO

This saves about 1K of RAM on IO, bringing it back to the comfort zone (below with a 4-output mixer on fixed wing loaded).
Fix for #7142 .
@NaterGator Can you review / test?
WARN  [px4io] loaded
protocol 4 hardware 2 bootloader 3 buffer 64B crc 0x53a82816
8 controls 8 actuators 18 R/C inputs 2 analog inputs 0 relays
1128 bytes free
status 0x0f00 SAFETY_SAFE RC_FAIL FMU_FAIL MIXER_OK ARM_SYNC INIT_OK FAILSAFE
alarms 0x0030 FMU_LOST RC_LOST
vservo 106 mV vservo scale 10000
vrssi 1449
actuators 0 0 0 -10000 -25000 -25000 -25000 -25000
servos 1500 1500 1500 900 0 0 0 0
reversed outputs: [________] trims: r:   0.0000 p:   0.0000 y:   0.0000
0 raw R/C inputs
R/C flags: 0x0000
mapped R/C inputs 0x0000
ADC inputs 46 1830
features 0x0008 RSSI_ADC
arming 0x0434 FMU_DISARMED IO_ARM_DENIED MANUAL_OVERRIDE_OK INAIR_RESTART_OK ALWAYS_PWM_ENABLE OVERRIDE_IMMEDIATE
rates 0x0000 default 50 alt 400 sbus 72
debuglevel 0
controls 0: 0 0 0 0 0 0 0 0
controls 1: 0 0 0 0 0 0 0 0
controls 2: 0 0 0 0 0 0 0 0
controls 3: 0 0 0 0 0 0 0 0
input 0 min 1000 center 1500 max 2000 deadzone 10 assigned 255 options 0x0000
input 1 min 1000 center 1500 max 2000 deadzone 10 assigned 255 options 0x0000
input 2 min 1000 center 1500 max 2000 deadzone 10 assigned 255 options 0x0000
input 3 min 1000 center 1500 max 2000 deadzone 10 assigned 255 options 0x0000
input 4 min 1000 center 1500 max 2000 deadzone 10 assigned 255 options 0x0000
input 5 min 1000 center 1500 max 2000 deadzone 10 assigned 255 options 0x0000
input 6 min 1000 center 1500 max 2000 deadzone 10 assigned 255 options 0x0000
input 7 min 1000 center 1500 max 2000 deadzone 10 assigned 255 options 0x0000
input 8 min 1000 center 1500 max 2000 deadzone 0 assigned 255 options 0x0000
input 9 min 1000 center 1500 max 2000 deadzone 0 assigned 255 options 0x0000
input 10 min 1000 center 1500 max 2000 deadzone 0 assigned 255 options 0x0000
input 11 min 1000 center 1500 max 2000 deadzone 0 assigned 255 options 0x0000
input 12 min 1000 center 1500 max 2000 deadzone 0 assigned 255 options 0x0000
input 13 min 1000 center 1500 max 2000 deadzone 0 assigned 255 options 0x0000
input 14 min 1000 center 1500 max 2000 deadzone 0 assigned 255 options 0x0000
input 15 min 1000 center 1500 max 2000 deadzone 0 assigned 255 options 0x0000
input 16 min 1000 center 1500 max 2000 deadzone 0 assigned 255 options 0x0000
input 17 min 1000 center 1500 max 2000 deadzone 0 assigned 255 options 0x0000
failsafe 1500 1500 1500 900 0 0 0 0
disarmed values 0 0 0 1000 0 0 0 0

The decode tests fail as they have hardcoded failure counts and with different memory contents on start they arrive at different results. I need to validate if this is a bad test or if this is an issue for the decoder and I need to reset when the decoder is given the buffer.

Will be happy to test. I also implemented mixer loading from the FMU with dynamic memory that is managed during the mixer loading process which got me over the hill. I'll see about rebasing if / when this PR goes in.

There are definitely a few things incorrect here in the parsers. Some uses of sizeof() were against the array and are now against pointers. Trying to solve this with minimal changes with references, otherwise I'll have to re-audit the whole parser code for every operation.

@NaterGator, @LorenzMeier   Refactored here https://github.com/PX4/Firmware/pull/7167

This is the better version of it: https://github.com/PX4/Firmware/pull/7167


Fix ordering of spack compiler find, and move installs to separate layer

Do you want to add the caching to this PR (or are you doing it separately?)


NR-333358 Upgrading webpack and babel dependencies

JIRA : NR-333358

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


ubuntu 20.04 can't install esl-erlang for arm64

Installing esl-erlang according to the instructions at https://www.erlang-solutions.com/downloads/ began failing recently on my M1 Mac.
This Dockerfile reproduces the issue:
FROM ubuntu:20.04

RUN apt-get update \
  && apt-get install -y build-essential ca-certificates curl gnupg2

RUN curl -sSLO https://packages.erlang-solutions.com/erlang-solutions_2.0_all.deb \
  && dpkg -i erlang-solutions_2.0_all.deb \
  && apt-get update \
  && apt-get install -y esl-erlang

The error is: E: Unable to locate package esl-erlang
Not sure if this being blank is the issue: http://packages.erlang-solutions.com/ubuntu/dists/focal/contrib/binary-arm64/Packages

The arm64 package is no longer empty and the docker build is working again.

@gilacost curious why you re-opened this?

I blame terraform when managing issues, I might have use the wrong issue id, thanks for mentioning 😄 ❤


[Stable/mongodb] Allow to configure readiness and liveness probes for MongoDB chart

This PR adds support to the MongoDB chart to configure the liveness and readiness probes.

/lgtm


Tiebreakers

About the PR

Adds proper support for tiebreakers.
Media

[x] I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Changelog

:cl: eclips_e

add: Added a tiebreaker deathmatch for those who manage to tie for winning.

yay emo is awake


Linux compatibility

I don’t have any virtual machine running Linux so I can’t confirm that Apodimark runs on it.
If someone could launch the test suite (CommonMarkConformanceTests) and ensures that there is no compatibility issues, I would highly appreciate it 😊

@loiclec you could setup a travis box pretty easy, basically copy this:
https://github.com/vapor/vapor/blob/master/.travis.yml
then add travis to the repo and it'll run SPM tests on both environments.
Also wanted to say this looks like a cool project. We are using a cmarkdown parser right now, but would like to move to something in pure swift if it exists. If someone makes a 3rd party component that renders html (or if you change your mind about that feature), please tag me 👍

@LoganWright check out Hypertext :) I am just getting started cloning and bringing the two together

@LoganWright @sahandnayebaziz Right now, the API is unnecessarily complex for doing things like generating HTML. It would be great to write a wrapper with an interface similar to https://github.com/chriseidhof/commonmark-swift. So we would have one library for working with indices (this one, Apodimark), and another for working with strings (the wrapper). But I would like to get to 1.0 before working on that.
An other thing to keep in mind is that I don’t conform 100% to Commonmark, and probably never will. This might cause some issues during the migration.  So if you need a particular feature for your use case, I am more than willing to work on it.

@loiclec cool :) My first intuition was that somewhere, at the point that you have parsed markdown into an AST, that would be the right place for an HTML library to step through and read the tree to output HTML elements as it went.
Does that sound right to you?

@sahandnayebaziz yes, it does! :)


Backports 0.17 pr13

And we have the Qt creator instructions twice now but i guess that will be fixed by another backport?
Yeah, looks like that's done in pr14

And we have the Qt creator instructions twice now but i guess that will be fixed by another backport?

~Yeah, looks like that's done in pr14~
It's done in this PR. The qt stuff in build-osx.md is removed

Oh right 😅 rest looks good, utACK!

cherry-picked all. LMK if you want me to squash


merge from konsum-frontend-svelte

package.json

chore(deps): add ^8.3.17 remove ^8.3.16 (devDependencies.npm-pkgbuild)

.github/workflows/codeql_analysis.yml

chore: add<EMAIL_ADDRESS>(jobs.analyze.steps.uses)

.github/workflows/browser_ci.yml

chore: add<EMAIL_ADDRESS>(jobs.test.steps.uses)
chore: add<EMAIL_ADDRESS>(jobs.release.steps.uses)

:tada: This PR is included in version 1.31.14 :tada:
The release is available on:

v1.31.14
npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Add CMake install targets

This PR adds CMake install instructions for the library, executable and includes, in order to allow packaging piper-phonemize for linux distributions.

Thanks!


Using gdb from a different toolchain (e.g. arm-none-eabi-gdb)

Hi,
I tried to look around the configurations but I couldn't find a straightforward way to use gdb from a different toolchain (arm-none-eabi in my case), is it possible? If not, could it be made possible to configure which gdb executable to use? This would be useful when performing remote debugging on different architectures.

Genius! Why didn't I think of that?

Whoa, that was quick! Thanks a bunch :)

Gonna release in a bit, first going to fix #51

Should these settings be in user/project settings instead?
The paths would vary from user to user and wouldn't change per project.

Hm that's not really possible to get the debug extension talk to a regular extension. So I can't really access the user settings without manually reading the config json folders.

This seems like a common problem for debug extensions, but debug extensions probably aren't very common 😛
I'll do some digging on Microsoft/VSCode and raise an issue to see if it can't be resolved.

The debug extension is basically a standalone program without any dependency on vscode. There is some code in frontend using vscode APIs but that part is basically a completely separate second plugin. That frontend communicates with my debug extension afterwards using Unix Domain Sockets when its runnings. But at startup the launch config is all I can get without raw access to the file system


Unable to set custom source directory for MD pages

I think I may have found a bug with the CLI usage. On two separate computers (Windows 8.1 and 10), I cannot get version 1.2.4 to use anything other than the current directory as it's "source" folder.
The command I'm running is techy --src ./_pages, but regardless of my current folder structure, it always runs from the folder where I'm running the command. I can confirm this because the README.md file in my project root is also being converted to .html.
I discovered in a comment on #20 that this CLI parameter usage was added in 1.0.0, so I installed that version specifically to test and the issue doesn't exist there. This must have been something that went wrong since then. I should note here that the --dest parameter works correctly; the output definitely goes to the folder I specify. I can't confirm the --theme parameter though, since 1.2.4 doesn't seem to generate any themes folder as I see version 1.0.0 doing.
Unfortunately I can't find a list of releases, so I haven't been able to work out which specific release these issues in.. Please let me know if you need help with debugging this further.
Edit: I found a list of the versions using npm view, I'll see if I can work out which version broke this functionality and leave a comment if I find anything useful.

Hello @ZaLiTHkA,
Thank you for filing an issue here. I'll try finding some time next week for that.


General Update Pattern works with v3 but not with v4

The example http://bl.ocks.org/mbostock/3808221 was last updated February 8, 2016, so I guess it is still relevant. It works with v3, but not with v4. With version 4, the new elements from the enter() selection are not updated.
To analyze this, I modified the example, so it updates the data upon click. The initial update however reveals the issue already:
http://urban-hop.com/d3/update-enter.v3.htm
http://urban-hop.com/d3/update-enter.v4.htm
Condensed, this code reveals the different behavior:
<!DOCTYPE html>
<meta charset="utf-8">
<style>
    span {
        font: bold 12px monospace;
        margin: 6px;
        outline: solid 2px #333;
        padding: 4px;
        display: inline-block;
    }
    .enter {
        background: coral;
    }
    .update {
        background: yellowgreen;
    }
</style>
<body>
</body>
<script src="//d3js.org/d3.v4.min.js"></script>
<script>

    var c = d3.select("body").append("div").attr("id", "container");
    var data = "1234567890".split("");

    // DATA JOIN
    // Join new data with old elements, if any.
    var sel = c.selectAll("span")
        .data(data);

    // ENTER
    // Create new elements as needed.
    sel.enter().append("span")
        .attr("class", "enter");

    // ENTER + UPDATE
    // Appending to the enter selection expands the update selection to include
    // entering elements; so, operations on the update selection after appending to
    // the enter selection will apply to both entering and updating nodes.
    console.log("sel", sel);

    sel.text(d => d); // <<<<< does not work with v4. works with v3

</script>

workaround: do a fresh selection
c.selectAll("span").text(d => d)

The selection API has changed; please see the release notes.  Please see the new General Update Pattern 4.0 example. I will be updating the 3.x examples to 4.0 as I have the time.


Would you consider creating a COPR repository for this app?

Hello. Would you consider creating a COPR repository for this app? I ask because it would be nice to be able to update without having to remove the app every time I wish to upgrade to a new release of Fedora.

I do not intend to become a package maintainer, especially for the package system that I don't use.

I do not intend to become a package maintainer, especially for the package system that I don't use.

OK then, thank you anyways.


JSDoc - defferent behavior

Issue Type: Bug
/** @type {{a: {b: {c: number}}} & ({[k: string]: {y: number}})} */
let e = {a: {b: {c: 2}}};
/** @type {{a: {b: {c: number}}} & {a: {y: number}}} */
let c = {a: {b: {c: 2}}};
VS Code version: Code 1.46.0 (a5d1cc28bb5da32ec67e86cc50f84c67cc690321, 2020-06-10T08:59:06.977Z)
OS version: Darwin x64 19.4.0
Extensions (16)

Extension
Author (truncated)
Version

vscode-openapi
42C
3.2.0

swagger-viewer
Arj
3.0.1

vscode-simpler-icons
dav
1.6.5

vscode-eslint
dba
2.1.5

gitlens
eam
10.2.2

EditorConfig
Edi
0.15.1

json-tools
eri
1.0.2

php-intellisense
fel
2.3.14

code-runner
for
0.10.0

jsdoc
lll
1.0.3

prettify-json
moh
0.0.3

vscode-typescript-tslint-plugin
ms-
1.2.3

vetur
oct
0.24.0

vscode-yaml
red
0.8.0

vscode-icons
vsc
10.1.1

html-css-class-completion
Zig
1.19.0

I can't tell what you're trying to show here - what is the bug? Please provide more information in a follow-up report if needed using the TypeScript repo issue template. Thanks!


Outdated target framework

netcoreapp2.1 is not longer supported and must be updated.

updated to netcoreapp3.1


Update Xcode to 8.3

New Pull Request Checklist

[x] I have read and understood the CONTRIBUTING guide

[x] I have read the Documentation

[x] I have searched for a similar pull request in the project and found none

[x] I have updated this branch with the latest master to avoid conflicts (via merge from master or rebase)

[x] I have added the required tests to prove the fix/feature I am adding

[x] I have updated the documentation (if necesarry)

[x] I have run the tests and they pass

[x] I have run the lint and it passes (pod lib lint)

Pull Request Description
I updated Xcode to 8.3 and fixed warning in sample code to support Swift 3.1.
See SR-1882 for the language change about it.

Codecov Report

Merging #860 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #860   +/-   ##
=======================================
  Coverage   22.91%   22.91%
=======================================
  Files          18       18
  Lines        3958     3958
  Branches      283      283
=======================================
  Hits          907      907
  Misses       3049     3049
  Partials        2        2

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0a8b6b6...c68b1ed. Read the comment docs.


Transfer encryption metadata in the commit when DirectUpdateHandler2.closeWriter is called.

The problem is described in the corresponding issue.
It happens when documents are inserted but without commit, and the IndexWriter is closed, which triggers an auto-commit from DirectUpdateHandler2.closeWriter. Unfortunately this auto-commit does not really call the DirectUpdateHandler2.commit code but rather copies it, and we miss a call to DirectUpdateHandler2.shouldCommit to manage the encryption commit metadata.
Actually this requires to change DirectUpdateHandler2.closeWriter in the Solr project.
This PR shows the small required change (see comment in the DirectUpdateHandler2 copy), and verifies the fix with a test.
But I don't think I'll merge this PR. I'll rather change upstream and wait for the next release to upgrade here.

I suppose IndexWriter.commit() is risky for index encryption... we must always guarantee there is commit metadata?  It seems this is fragile right now. I did find-usages and I see two other callers, and would like your opinion:
CoreContainer.reload
SolrIndexSplitter.doSplit

@dsmiley why did you close this PR?
It seems you wrote some comments, but I don't see them anymore.

:embarrassed: totally an accident; sorry!  I saw it was closed (didn't notice it was me!), so I deleted my comment to shift it to  #109
I suppose IndexWriter.commit() is risky for index encryption... we must always guarantee there is commit metadata? This seems fragile; hard to guarantee, and with bad consequences.
I did find-usages and I see two other callers, and would like your opinion:

CoreContainer.reload
SolrIndexSplitter.doSplit

But finding all callers and adding protections, again, feels fragile.  Like if we do index encryption, maybe we need a stronger lower level guarantee that the metadata is there.  I haven't thought about this too much other than observing the fragility.

For the SolrIndexSplitter.doSplit, it is already handled in EncryptionUpdateHandler which extends DirectUpdateHandler2.split(). This method creates the SolrIndexSplitter and gives the Command which contains the metadata.
For CoreContainer.reload, I missed it. Good point.
I don't think there are other callers currently. But I agree this is fragile while Solr evolves. I hope that when this encryption module comes into Solr, we can encapsulate the Lucene IndexWriter in a way that it does the commit metadata transfer systematically at nearly the Lucene level.


Adding decline and reset button

Why do we need this?
We want reviewers to be able to decline themselves and others if they are on vacation or unnecessary on the review. If you get declined, you also want to be able to get reset (aka. re-added).
What does this change do?
Add decline and reset buttons. These post specially formatted comments on the review request that we later parse to add status UI for these users.

Declined users stay on the review request since only the owner of the request can remove them (because of permissions). They also get emails on declines and resets -- a good thing; we want to let our reviewers know when this happens to them so they can react if needed.
How was this tested?
Manual testing on Chrome and FireFox.
Checklist
If applicable:

[x] Runs in latest stable Chrome and Firefox without Javascript errors
[x] Does not report any issues with eslint (run npm run build -- the PR build will also check this)
[x] Increment version following semver
[x] All @require and @resource URLs must have SRI (use this hashing tool)
[x] Blocks of code are commented
[x] Included a screenshot in the PR
[x] Added docs to README.md
[ ] Linked issues

I could not see a notification or message saying that an email will be sent.
Maybe want to add an html checkbox  that is checked by default and disabled so it is obvious that you have to send the email; this mimics the review-board behaviour when you post a comment

I could not see a notification or message saying that an email will be sent.
Maybe want to add an html checkbox that is checked by default and disabled so it is obvious that you have to send the email; this mimics the review-board behaviour when you post a comment

How about this?

I opted out of the checkbox cause it looked weird, it isn't clear that it is disabled, and could be frustrating to someone trying to click it.

However, that checkbox doesn't appear everywhere...

For example, this dialog box has no option to send or not send emails.
So is this email text necessary in my dialog?

In general, I see giant functions that would be easier to understand if refactored into smaller, single-purpose functions. But that's not specific to this change, and it seems fine from what I can tell.

Agreed. I think a refactor would be good in a follow up PR.

So is this email text necessary in my dialog?

Well.. I prefer to be explicit about it, I think the an email notification will be sent is probably enough, maybe use bold text? or something to call attention; people may not read it.It would look cool if you added a ✉ emoji!!!!

For example, this dialog box has no option to send or not send emails.

Or use the same working on the button Publish Review that should make it explicit.
The way you have it now looks better!


Charging state does not update

If I charge overnight, disconnect plug in the morning, and then replug in the evening, the charge status does not update in HA. It properly updates during the initial charge and changes state once the charge has completed, but it stays in an available state when re-plugged in the following evening. Reloading the integration properly updates the charging state.

Are there any errors or warnings in your logs from the integration?


Add Windows support

Hi,
two small issues on Windows with gcc (gcc version 6.3.0 (GCC)). Both report missing headers which are typically not found on windows. I haven't looked at the implementation but I guess it is possible to work around these kind of issues. Not sure if you want support windows as platform at all.
First one - msys2 (bash environment)
[ome/src/github/Pinecone]>make
g++ -Wall -std=c++11 -O2 src/.cpp src/Actions/.cpp -o pinecone
src/msclStringFuncs.cpp:8:21: fatal error: termcap.h: No such file or directory
                 ^

compilation terminated.
make: *** [Makefile:6: build] Error 1
Second one Mingw and Windows console
c:\home\src\github\Pinecone>make
g++ -Wall -std=c++11 -O2 src/.cpp src/Actions/.cpp -o pinecone
src/msclStringFuncs.cpp:5:54: fatal error: sys/ioctl.h: No such file or directory
#include <sys/ioctl.h> // for terminal size detection
^
compilation terminated.
src/Actions/FunctionAction.cpp: In member function 'virtual void FunctionAction::addToProg(Action, Action, CppProgram*)'
:
src/Actions/FunctionAction.cpp:100:36: error: cast from 'ActionData*' to 'long int' loses precision [-fpermissive]
name="^func_"+to_string((long)&*action);
^~~~~~
make: *** [Makefile:6: build] Error 1

These problems shouldn't be terribly difficult to fix, but I believe there will be a number of more troublesome issues on windows even if it does compile. I will update the install tutorial to say that it does not currently work on windows so people don't waist their time. I do want to support windows soon, and it shouldn't be that big a job.

This will be the hub for updates on Windows support.

Just out of curiosity, what are the more troublesome issues you expect ? I agree the other ones should be easy to fix ... if I have time I can look into it ...

The two things I can think of are newline characters being two bytes on Windows and folder paths having backslashes. Idk how/if these will affect anything. I have't programmed on windows in a while, so I'm not sure what other issues there will be.

I think I have fixed the compile-time issues you were having (both those headers were used in determining terminal width, which is now just assumed to be 80 on windows). The changes are pushed to the develop branch. Let me know if it compiles, and, if so, what is broken when you run it.

Hello,
Not sure if I can be of a little help here for a temporary fix. If you are on Windows 10, there is a linux shell built in now by the Ubuntu developers, and simply requires activating in settings. This makes running Pinecone on Windows as easy as Linux. (This is obviously a temporary fix as not all Windows user will want to use WSL).
Link: https://msdn.microsoft.com/en-gb/commandline/wsl/install_guide
I will also attach a picture of the process I went through from start to finish of running Pinecone on WSL. Let me know if this is of any help.

Thanks, this shouldn't be required for long though. I will try to get native windows support working this weekend.

real time updates on windows support: https://twitter.com/01110111_illiam/status/848020191187394560

You can now try and use the windows_support branch. I got it to build and run at one point, and since then I have added windows support to the test system, but I couldn't test because my tool chain got screwed up or something. If anyone wants to help out, build Pinecone on Windows, run other/run_tests.pn and let me know what the output is. I will try to fix my build system tomorrow.

Thanks for the quick fix. Builds after commenting out termcap.h in  src/msclStringFuncs.cpp
(Windows 7, msys2, gcc 6.3.0)
here is the output you asked for:
pinecone v0.4.0
unit tests:
unit:
.	conditionals passed
.	constants passed
.	funcs passed
.	loops passed
.	operators passed
.	order_of_ops passed
.	strings passed
.	vars passed
regression:
.	multiple_left_inputs passed
.	no_newline_at_end passed
integration:
X	brainfuck failed

output:
enter your brainfuck code: Hello World!
instead of:
enter your brainfuck code: Hello World!

.	morse passed
.	queue passed
unfixed:
X	backslash_in_block_comment failed
X	bool_short_circuit failed
X	cpp_bad_escape_seq failed
X	cpp_global_and_local_same_name failed
X	crash_on_error_in_import failed
X	error_on_nonexistant_file failed
X	function_with_one_named_arg failed
X	if_as_ternary failed
tests done

short update everything in examples seems to work except snake (as I expected)

Cool. I'm sure Windows specific bugs will crop up now and then, but it should work for the most part.

how are you in the future @wmww

wat?

yesterday it said posted on April first @wmww

You can use Visual Studio IDE to develop it.
By install it, Windows SDK will install and you can use Windows.h to get console size, And you can use #include on c++17 for a cross-platform path resolving.
Visual Studio also supports linux target upon SSH, I have connected it to my WSL environment to compile my linux apps.

include < filesystem >

 2020: Still waitin

I'm not sure what you're waiting for. Last I remember it compiled and ran on Windows. Regardless, this project is unmaintained so don't expect any updates from me (or anyone else as far as I know).

@IbrahimTGD take a look at this. https://github.com/mmdmine/Winecone


Rye test is not scoped to workspace members

Steps to Reproduce

Create a new virtual rye project with one or more members.
Define additional python packages outside of the members directory.
Run rye test --all

At this point, rye is trying to run every test it can find, not just tests in my workspace members.
Example layout for a large monorepo
Structure:
project/
  crates/ # Rust crates published to Crates.IO
  pypi/ # Python wheels published to pypi
  tools/ # Random tools that I don't care about

Root toml:
[project]
name = "project"
version = "0.1.0"
description = "Add your description here"
authors = [
    { name = "Bob", email =<EMAIL_ADDRESS>}
]
dependencies = []
readme = "README.md"
requires-python = ">= 3.9"

[tool.rye]
managed = true
virtual = true
dev-dependencies = [
    "pytest>=8.0.2",
]

[tool.rye.workspace]
members = ["pypi/*"]

Expected Result
I expect that rye will only run the tests for project members in pypi/.
Actual Result
Rye is running every test file in the entire repo, including the tools directory.
Version Info
rye 0.28.0
commit: 0.28.0 (c44dc7ec8 2024-03-07)
platform: macos (aarch64)
self-python<EMAIL_ADDRESS>symlink support: true
uv enabled: false
Stacktrace
No response

Weirdly enough rye test --all and ``rye test` don't have the same behaviour

After self update this is 100% reproducible.

Version:
rye 0.29.0
commit: 0.28.0+6 (9484b1a81 2024-03-08)
platform: windows (x86_64)
self-python<EMAIL_ADDRESS>symlink support: true
uv enabled: true


Analytics - Investigate Flush Timer usability

We're currently using https://developer.apple.com/documentation/dispatch/dispatchsourcetimer

Make sure it is actually added to background queue.
Test the usability of the timer from a real app, possibly add this as part of the HostApp code.
Test deallocation crash
-- more details here: https://medium.com/over-engineering/a-background-repeating-timer-in-swift-412cecfd2ef9
-- "If the timer is suspended, calling cancel without resuming triggers a crash." so a wrapper is created for the timer and deinit does cancel + resume to ensure it doesn't crash

related PR is already in


Difficulting writing missing timeseries values with CDA

Does anyone know how to write a missing value with CDA? Seems like the jython DBAPI values of -340282346638528859811704183484516925440 and -901 don't write to missing with CDA.
I tried writing the missing qualifier as 4997 which did write the correct qualifier, but did not clear the value.  Deleting values by time frame not as convenient as just writing a missing.

if you right click is there a "set missing option" in the DVE? That should use the java Double -Infinity that indicates a missing value.

What's DVE? I guess I want to know if there is a set of characters or values that can be written via CDA to clear the value in the database.

"Data validation Editor", e.g. what you put in a screen shot of. Sorry, thought that initialism was more common throughout the community.

So basically right click on the row, should be a set missing that clears it, and try again. I suspect it may still not work but it would be something to go on.

Got it...should be able to see the behavior below.

yeah, and in that case it's just setting the flag not totally clearing out the value. I'm running a test in CDA now, and well, some how we forgot to account for null values.
I have now idea how given how much i've used "null" missing values, but there it is.

Okay, I found how how to let CDA process null values; we might have had a similar issue in OpenDCS but it uses "Double.NEGATIVE_INFINITY" in the java code as the actual database call expects double vs Double (the first one can't be null) so if the input value is null I set to that special value.
Having some annoyances buttoning down the change and test so likely next week, but will definitely be in for the final release.

... might have to check the negative infinity on the retrieve. sorry, more work to do, but start of testing is in place.

I did get it to work with Double.NEGATIVE_INFINITY but "-Inifinity" is returned instead of null which can be saved to the database.

Thanks @MikeNeilson for the breadcrumb in https://github.com/USACE/a2w-api/issues/85. Writing the value as "-Infinity" works, but then it causes issues with cwms-python because we are mixing string and numeric values. In some ways setting missing as"-Infinity" is more intuitive  than some numeric code, but then some catches would have to be built into cwms-python and maybe opendcs so type errors aren't triggered. Do you know if "-Infinity" causes OpenDCS CP errors? Sounds like you have a plan on what the null code should be though and it's not "-Infinity".
Tagging @Enovotny so he can track too.

date-time | value | quality-code
-- | -- | --
2023-09-14 19:00:00+00:00 |<PHONE_NUMBER>038.880859 | 4997
2023-09-14 19:15:00+00:00 |<PHONE_NUMBER>038.880859 | 4997
2023-09-14 19:30:00+00:00 | -Infinity | 4997
2023-09-14 19:45:00+00:00 | -Infinity | 4997
2023-09-14 20:00:00+00:00 | -Infinity | 4997

@MikeNeilson don't strangle me, but this does work in the current CDA version if you set the units to metric. Since I am using English units, the unit change occurred and then the null value was not written. I should've checked this sooner.

Fair question, but the null/-Float.MAX_VALUE check is performed before any unit conversions are performed. Your code should also leave null (None) or -Float.MAX_VALUE values as they are.

Fair question, but the null/-Float.MAX_VALUE check is performed before any unit conversions are performed. Your code should also leave null (None) or -Float.MAX_VALUE values as they are.

This occurs in the fix you did today, right? The current, production version of CDA will accept -Float.MAX_VALUE if you stay in SI.

Oh, well then. odd. will have to investigate more. Thanks for looking into that.
In theory with the new version (which hasn't been pushed anywhere yet) it shouldn't be an issue.

Ok, so it's not a unit thing. You have to set the value to -Float.MAX_VALUE (-340282346638528859811704183484516925440) and the quality code to missing (4997) for it to work in the current version. I think that is what you were getting it with setting the flag in the GUI. I'm not sure why I didn't catch it with the GUI test.

Oh yeah. I was looking at the code in the database. it may automatically add the missing code if the data is null. Otherwise you have to set the flag manually.
There's not really a good way to report that to the user as there's several conditions where it's not an error; at least to the database.

Yeah would be nice if it just would know if you feed it a missing value or a missing qualifier for it write it as missing because I can't think of a case where you would want one without the other.

We could do that at the API level, but given the database itself supports a setting I want to talk to Perryman about it first.
I agree with you, if it's not at the user level of choice, there should only be the "one way" to save and deal with missing.

Oh FYI the actually "missing value" quality is 5. or more correctly that that lower 3 bits all have to be set. I think 4997 just happens to meet that definition while encoding other information.


Add support for custom outcomes and use OkHttp3 for all network calls…

… on all devices

Use OkHttp3 for all network calls on all devices. The Http stack for Volley changes depending on the devices API version. Using OkHttp3 makes sure that all of the network requests are made using the same code. Also, it is often safer, faster, and more reliable than what Volley uses by default. Also also, you can use Android Studio's new network profiler with OkHttp3.

Maybe TODO:

Do a database migration for the new outcome values. For example, the app currently stores the voicemail outcome value as "vm", but the new custom outcome value is "voicemail". Work should probably be done so that all values in the database are "voicemail".
Use Enums for outcomes. They would probably be easier to maintain for associated properties.

All requested changes made.

All requested changes made.


Add giving null when there is no error

Refs: #12

@DzyubSpirit ok, let's use null, you can land it, but need to review the rest of code

Landed in d8a1cb5


Fix Example() function in TSDB

I was not aware of the example function format (see https://go.dev/blog/examples) and ended up changing it in the last commit in https://github.com/prometheus/prometheus/pull/9451 which makes it not render in godoc. This PR just reverts the changes done to that function. I will merge on green.
cc @Dieterbe

This technically fixed it (see https://pkg.go.dev/github.com/prometheus/prometheus@v1.8.2-0.20220111145625-076109fa1910/tsdb#pkg-overview), but the go mod issue bites us again.
go: finding module for package github.com/prometheus/prometheus/model/labels
go: downloading github.com/prometheus/prometheus v2.5.0+incompatible
go: finding module for package github.com/prometheus/prometheus/model/labels
prog.go:11:2: module github.com/prometheus/prometheus@latest found (v2.5.0+incompatible), but does not contain package github.com/prometheus/prometheus/model/labels


New docs structure

WIP
TODO, once we agree on structure:

write redirects
replace internal links
make sure existing guides still link together nicely (eg become a validator -> setup node -> start validating)
Edit docs home for a nice UX when landing on docs page

@jak-pan @SimonKraus

i'm okay with this approach.
Only thing is i would name the  "Snakenet" category "How-to" because most articles are  still valid after snakenet.
Maybe putting snakenetas  subsection of how-to.
We should do this  quick as  we have many translations ready to be published

Yeah nominating and validating guides will pass to mainnet. I'd not get them under a subsection if we're changing stuff. Maybe just make snakenet a single article under learn?

@vgantchev i talked to jakub and we agreed not to nest the documents in the filesystem for various reasons.
we do not want to deal with redirects
we need to be able to reorganize nav without messing around with redirects and file locations
so the documents will stay in the single directory (don't worry, we'll find what to edit).
We just edit the nav structure.
So we can do the following categories in the main nav:
"How-to" with claim, become a nominator, become a validator, connect to a site
"Learn" with Staking and Snakenet
"Maintain" with node-setup, performance bench, node monitoring
"Build" <= can be added later when content is available
@jak-pan please take a look once again and confirm :pray:

Yeah, the flat structure has multiple positives.

It's easier to i18n
If you update menu structure because it's no longer relevant (which happens a lot), you don't need to change all of the links and update every file, including i18n.
You will never need to make redirects
It's harder to duplicate stuff in a large knowledge base, everything is in the same place.

Now it does have some disadvantages but it's easy to overcome them by having proper on-point names for the files, using edit button to find the doc you're searching for, or using search of the editor you are using.

@vgantchev  let me know if i should apply the new nav structure

Thanks for the suggestions guys! I changed the navs and removed the file tree. For now I think we can have Snakenet under Intro, as both are not very informative (i will pick them up soon though)


bug fix: Clean up blue highlighting in the left corner.

In a96fdd18b1018bd37f2f88058d01d378ec21dd4d, I introduced a few
regressions related to the blue highlighting that happens
in the top left corner for Home, Private messages, Starred
messages, and @-mentions.  Basically, we weren't clearing
the highlighting when we thought we were, so Home would stay
blue too long and the other filters wouldn't turn blue.
We went a surprising long time before noticing the regression.
This fix adds a function called deselect_top_left_corner_items()
to clear the blue backgrounds, so that will happen more explicitly.
And then I restored a line of code to pm_list.js that puts the
blue in place when you are in an is:private narrow (vs. a
specific PM narrow).

Automated message from Dropbox CLA bot
@showell, it looks like you've already signed the Dropbox CLA. Thanks!

Merged, thanks @showell!!