How to tell if a table has successfully been deleted

Deleting a table is asynchronous so even though the REST endpoint returns as success the table might not actually be deleted at that point.

According to the docs, if the table is in process of being deleted, any future operations on that table will return a 409 (status conflict) with additional info that the table is being deleted.

Apparently there is some corner-case where GET will return a 404 (not a 409 as doc'ed) however when you subsequently try to recreate the table it fails with a 409 as the delete is still in progress.

@seankane-msft do you know if this has been fixed in aztables?

I'm not sure what the solution to this issue is. There is a slight delay by the service to delete a table, and you cannot create a table with the same name immediately afterwards. However, you can loop on a CreateTable call when the response is a 409, but there is not built in method in the SDK for retrying this operation.

Would it make sense to model Delete as an LRO?  What do the other languages do?

Other languages do not model delete as an LRO, we have the same implementation as other languages. I don't believe other languages have a built in way to do any polling for this method.

I've updated the docs for CreateTable and Delete to explain the nuance here.


Updated SQL file on Homework-3 branch

I added the codes for the questions in homework-3

What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)
I added SQL queries to answer the questions in homework-3, including aggregating data, filtering by date, and creating a temporary table with vendor data.
What did you learn from the changes you have made?
I learned how to use SQL functions like SUM(), GROUP BY, and HAVING to aggregate data, as well as how to use strftime() for filtering dates. I also learned how to create and insert into a temporary table.
Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?
I considered using subqueries for filtering, but using WHERE was a simpler solution for date filtering.
Were there any challenges? If so, what issue(s) did you face? How did you overcome it?
One challenge was understanding how to use the HAVING clause correctly with an alias, which I initially struggled with. I overcame this by reading documentation and testing the queries in SQLite.
How were these changes tested?
I tested the changes by running each query in the SQLite environment and checking the output to make sure it matched the expected results.
A reference to a related issue in your repository (if applicable)
There is no related issue in the repository for this homework.
Checklist

[x] I can confirm that my changes are working as intended

HW 3 marked.


Support Python 3.12

tasks

Develop

Remove distutils

#768
#769

Docs

Show in metadata #770

[x] Release

purpose
To fix #732 , support 3.12 instead of workarounds

https://github.com/Uberi/speech_recognition/releases/tag/3.11.0


Is It Possible to Run RenderCV not From The CLI?

I'm wanting to pass in JSON or YAML into rendercv from a web service. Is this possible currently?

Not at the moment, but we've got some plans in the works :) I will share the news with everyone soon.

Awesome! Excited for the announcement. 🎉

Please see the announcement: https://github.com/sinaatalay/rendercv/discussions/160
RenderCV has a web app and a web API now.


Generic refs

How about making refs generic as well (if possible) like we made models generic (#239, #242, 9be6e0f386547c7b5a58eedd3566bbfa6a63fece)? This would be useful for creating refs of generic models, so the generics can be passed down, e.g.:
const myRef = rootRef("some model type", <T>() => ({
  getId(target: unknown): string | undefined {
    // ...
  },
  onResolvedValueChange(
    ref: Ref<GenericModel<T>>,
    newValue: GenericModel<T> | undefined,
    oldValue: GenericModel<T> | undefined
  ) {
    // ...
  }
}))

Of course the same for custom refs.

Just wondering, how is that different from
const myRef1 = rootRef<GenericClass<any>>("some model type", {
  // ...
}))

const myRef2 = rootRef<GenericClass<number>>("some model type", {
  // ...
}))

?
I'm confused because with references you usually set the type as a type argument, not through inference.

Although the added value might not be as significant as for generic models, wouldn't it be nice to be able to have:
const genericModelRef = rootRef("GenericModel", <T>() => ({
 // ...
}))

const m = new GenericModel({ value: 1 }) // e.g. GenericModel<number> (inferred at construction time)
const mref = genericModelRef(m)          // e.g. Ref<GenericModel<number>> (inferred)

mref's type would be inferred as Ref<GenericModel<number>> instead of being fixed to, e.g., Ref<GenericModel<any>>, it would be a bit more precise in this case.

And from what part of the options to rootRef would it infer the type from? (both are optional)
Or you mean it should be inferred from the parameter to the constructor? though in that case I guess it wouldn't be type checked if you pass a wrong type.

Maybe a middle ground?
const genericModelRef = rootRef<GenericModel<any>>("GenericModel", {
 // ...
})

const ref = genericModelRef(new GenericModel({value: 1})) // creates a Ref<GenericModel<number>>

don't know if it is even possible yet though

Just checked, apparently it is :)

Good?
test("generic typings", () => {
  @model("GenericModel")
  class GenericModel<T1, T2> extends Model(<U1, U2>() => ({
    v1: prop<U1 | undefined>(),
    v2: prop<U2>(),
    v3: prop<number>(0),
  }))<T1, T2> {}

  const genericRef = rootRef<GenericModel<any, any>>("genericRef")

  const ref = genericRef(new GenericModel({ v1: 1, v2: "2" }))
  assert(ref, _ as Ref<GenericModel<number, string>>)

  const genericRef2 = rootRef<GenericModel<string, number>>("genericRef2")

  // @ts-expect-error
  genericRef2(new GenericModel({ v1: 1, v2: "2" }))
})

PR https://github.com/xaviergonz/mobx-keystone/pull/255

Perfect, that's an even better solution! Exactly what I was hoping to achieve. Thank you very much as always! 🙂

out in 0.59.0


Loading forever

Getting a bug in the checklist plugin where it keeps spinning and the tab never loads.
I disabled all plugins except the checklist one, and the error in the dev console is removeTagFromText. I'm guessing it's a syntax error in my checklists somewhere? Can you tell me more or how to identify?
Error:
TypeError: Cannot read property 'replace' of undefined
Stacktrace:

Hmm, I'm not sure what state of data could cause this error. I will try and add some checks around this in the next release, not sure how to reproduce for now though


Copilot in VS Code doesn't suggest code anymore

Copilot in VS Code doesn't suggest code anymore.

VS Code Version:
Version: 1.86.1 (system setup)
Commit: 31c37ee8f63491495ac49e43b8544550fbae4533
Date: 2024-02-07T09:08:20.941Z
Electron: 27.2.3
ElectronBuildId: 26495564
Chromium: 118.0.5993.159
Node.js: 18.17.1
V8: <IP_ADDRESS>-electron.0
OS: Windows_NT x64 10.0.22621

OS Version:

GitHub Copilot version: v1.159.0

Logs:

weird ya mine stopped today too. icon in the tray just spins.
Github Copilot Version: v1.159.0
VS Code Version: 1.86.1
macOS Version: 14.3.1 (23D60)

Just to pile on seeing the same behavior
## Copilot

- Version: 1.159.0
- Build: prod
- Editor: vscode/1.86.1

This is on Windows while developing in WSL2 on Ubuntu 20.04

Same here

Same thing is happening in Linux too, Working on Zorin 17 ( Based on Ubuntu ). Showing same result in output with no suggestions

Just to add some additional information a colleague has said this is still working in Jetbrains IDEs

Just to add some additional information a colleague has said this is still working in Jetbrains IDEs

oh great so I'm gonna have to hear about that from PHPStorm buddies too.

Just to add, issue persists with pre-release version as well.
v1.159.0 (pre-release)

It's like going back to the stone age without code complete 😆

seems to have been fixed, check it out

Still not suggesting for me - latest vscode latest version of the extension (not pre-release)

Not working for me too, tried installing/reinstalling, pre-release version, earlier versions, clearing workplace settings. Nothing seems to work

Also not working on Mac Visual Studio Code, I tried all the other versions, but didn't work. Btw, chat working well.

I get this:
[default] [fetchCompletions] engine https://copilot-proxy.githubusercontent.com/v1/engines/copilot-codex
Version:
Ubuntu 22.04.3 LTS
Visual Studio Code 1.86.1
Copilot v.1.159.0
Just started today, worked yesterday.

Yes! It is back. Good timing, I was starting to have withdrawal symptoms 😆

I see that this problem has now been resolved!

Hmm, sometimes it's working, sometimes not.

Same for me. Tried restarting vscode, updating vscode, reinstalling copilot, restarting computer. Nothing worked

Confirming, does not work on Mac Visual Studio Code, as of today.
Edit: works!

how did you fix it ?

Same here. Everything up to date, icon just keeps spinning. Chat works however.

I just reverting both vscode (i am using 1.84.2) and copilot(1.158) to previous version of copilot fix my issue

There's an ongoing incident regarding copilot completions.
https://www.githubstatus.com/
Please file issues with Ghost Text here


Updated MatchResult declarations

Previously: Missing getRightmostFailurePosition and getRightmostFailures.
Now: updated to have those two methods.
Additionally, corrected spelling error of iff to if.
I used the text from the documents for the JSDOC comments.

BTW, if you are using Ohm with TypeScript I'd love to hear if how your experience has been — my email address is in my profile.
I have actually been working on porting all of Ohm to TypeScript. It's a work in progress but if you're interested you can find it in this branch: https://github.com/harc/ohm/tree/ts-conversion.

Regarding the commented out area: it references NodeList which isn't itself declared. I'm not sure what NodeList was, so I couldn't/didn't add a declaration myself for it. I didn't mean to submit this with it comment out -- we can change that back. It's just been throwing errors at me in my projects so I keep it commented out (since I'm in Nodejs, I don't really need it).

I'll adjust those (or do you adjust them? Sorry this is both the first time I've used Github and the first pull request I've ever done in an open source project!)

Since I haven't explored Ohm internals too much, using it in Typescript has frankly been a breeze. I am using it to produce a Language Server.

Regarding the commented out area: it references NodeList which isn't itself declared. I'm not sure what NodeList was, so I couldn't/didn't add a declaration myself for it. I didn't mean to submit this with it comment out -- we can change that back. It's just been throwing errors at me in my projects so I keep it commented out (since I'm in Nodejs, I don't really need it).

Ah, right. Someone already raised this issue in #220. We should fix that, but yes, for now please uncomment that section for the purposes of this PR.

I'll adjust those (or do you adjust them? Sorry this is both the first time I've used Github and the first pull request I've ever done in an open source project!)

Cool! Happy to accept your first PR :-)
The usual way to do it would be that you make the changes in your branch, commit them, and then do a git push. The PR will be automatically updated to reflect the changes. Then, what I usually to do is to go through each of the comments from the reviewer and comment "Done" (or explain why the suggestion doesn't work, etc.) This way it's clear that everything has been considered and/or addressed.

Since I haven't explored Ohm internals too much, using it in Typescript has frankly been a breeze. I am using it to produce a Language Server.

Great, glad to hear that. BTW I will try to address #220 ASAP since it seems like at least a few people are running into the problem.


Trim redundant code

Closes: #154
Purpose
Clean up unnecessary/redundant elements
Description
In reviewing the codebase to address #154, I also found some other redundant code that has been fixed in this PR as below:

Streamlined  lookup_module() of ChannelMsg and PacketMsg
Trimmed the route() method and exposed it as the default implementation of the Msg trait.
(More viable pruning around Msg covered in #315)
Modified the output of MsgCreateClient::new() to return Self instead of Result<Self, ClientError>, as the error case is unreachable.
Removed redundant client_type() method of ConsensusState and Header traits since they have no clear usage (This was confirmed through a search for use cases in dependent projects such as Nomic, ComposableFi, and Penumbra)
Removed unnecessary PortReader implementation on DummyTransferModule struct
Cleared unused moderator dev dependency
Cleared redundant precludes

Additional to consider:

Clear PrettyDuration and PrettyOption structs here

PR author checklist:

[ ] Added changelog entry, using unclog.
[ ] Added tests.
[X] Linked to GitHub issue.
[ ] Updated code comments and documentation (e.g., docs/).
[ ] Tagged one reviewer who will be the one responsible for shepherding this PR.

Reviewer checklist:

[ ] Look for any out-of-scope side effects of clearing out these parts
[ ] Reviewed Files changed in the GitHub PR explorer.
[ ] Manually tested (in case integration/unit/mock tests are absent).

crate::utils::PrettyDuration is never used and should be deleted (as you identified)

Can we also remove crate::utils::PrettyOption? This also isn't used anywhere

Can we also remove crate::utils::PrettyOption? This also isn't used anywhere

Yes!

Just realized we should also update the module docstring in lib.rs (remove the references to the relayer module


refactor: minor update typings and internal imports

Description
internal import needs to be used by as so as to make to be "exported" from the module
Fixes #46
Type of change
Please delete options that are not relevant.

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds new typings)
[ ] Breaking change (fix or feature that would cause existing functionality not to work as expected)

:tada: This PR is included in version 0.2.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


doc: update documentation with general content from tutorial

I started moving more content from the TutorialNui into this repo. I believe that we should try to keep generic information about available widgets close to their implementation (to enable us updating the docs alongside with any code changes).
This PR includes the content from the following tutorial pages (enhanced with links to JavaDoc):

doc: incorporate core widget overview from tutorial
doc: format markdown with prettier
doc: incorporate content from Tutorial: Overview
doc: incorporate the tutorial content about layouts

Overall, I think the tutorial should become a guide on how to use NUI with Terasology, by explaining common scenarios such as how to layout inventory screens or typical UI elements for video games, such as a scrolling speech box.
I hope that we can find (simplified) examples in our core module line-up that we can explain in detail in the tutorial.

 Migrate TeraNUI docs from tutorial wiki into TeraNUI Guide


Support multi-level columns in pivot_table

This issue tracks DataFrame.pivot_table (#386)
The actual implementation can handle values as a list but it's disabled right now with this condition :
if isinstance(values, list) and len(values) > 1:
    raise NotImplementedError('Values as list of columns is not implemented yet.')

We need to implement multi-level columns before updating pivot_table

Hi @garawalid,
We recently added a basic multi-index support in columns (#590).
Does that help you submit a PR?

@ueshin thanks for notifying me!
I'll see what I can do.


asgi_redis silently fails to send with redis version < 2.6

If someone is running a redis version less than 2.6 then asgi_redis will fail silently in the send() call.
In the exception catch starting here https://github.com/django/asgi_redis/blob/master/asgi_redis/core.py#L107
There is no case for if a different error other than 'full' occurs.  Namely if "unknown command 'EVALSHA'" occurs which will happen for redis versions < 2.6.
This can cause users applications to fail to respond for unknown reasons as both the workers and daphne will connect to redis just fine but no information will be passed between them due to this failure.
Considering the default version of redis in EPEL is 2.4 this could cause many people to tear their hair out wondering what is going on.

I can reproduce the issue and will attempt to provide a fix this week.

I posted a potential fix in https://github.com/maikhoepfel/asgi_redis/pull/1. I'm happy to add a proper test against Redis 2.4 if we decide we want to run different Redis versions as part of the Travis test suite.

Fixed by #15.


Server Commands

How would I initiate a console command at a certain time or interval? For example, how would I run "examplecommand" every time the server starts, or every set number of seconds?

@smky At the bottom of GameServer.start do
var CommandList = require('./modules/CommandList');
var split; // What every you want. For example I could do {"mass", 1, 10000} to give mass of 1000 to id 1.
setInterval(function() {CommandList.CommandList.reset(this, split)}, 60 * 60 *1000) // Multiply the num of seconds times 1000. This is one hour

Thanks! (I'm aware of how time works in javascript)

Isn't that already a code sample? Just add it to the code and it should work fine.

Makes no sense to me can you give a example with board ? thanks

Why do you think I asked for an example, didn't make any sense @Tyler3D @MastaCoder @MineMooreALT

At the bottom of GameServer.js do
var CommandList = require('./modules/CommandList');
var split; // What every you want. For example I could do {"mass", 1, 10000} to give mass of 1000 to id 1.
setInterval(function() {CommandList.CommandList.reset(this, split)}, 60 * 60 *1000) // Multiply the num of seconds times 1000. This is one hour
Could the bolding not be any clearer?

 I can't spoon feed you all the code, go and spend time learning to code.

@MastaCoder I'm actually fluent in JavaScript, but i'm not familiar with Node.js or how MultiOgar/MultiOgar-Edited works.

mate the code you gave doesn't even work what do you expect I don't understand how multiogar functions really work. I'm a web developer, not a nodejs developer.

I'm with @MineMooreALT, the code doesn't work...

var CommandList = require('./modules/CommandList'); var split; // What every you want. For example I could do {"mass", 1, 10000} to give mass of 1000 to id 1. setInterval(function() {CommandList.CommandList.reset(this, split)}, 60 * 60 *1000) // Multiply the num of seconds times 1000. This is one hour makes no sense too, what is split supposed to be? is it supposed to be like var split = {"mass",1,10000}; please explain it better this should be a simple taskbut is proving difficult.

Also, @Tyler3D stated that it should be placed at the end of Game.prototype.start, while @MastaCoder sai it should be placed at the end of the GameServer.js itself.

Please respond with working answer


Does there exist a changelog or release notes?

Hi
I tried to find out what had happened between my currently installed version of KCache and the newest version, which differed with several minor versions. I couldn't find a changelog or release notes, so I was forced to try to do a git diff between the tag of my version and current. So I am wondering if there is a changelog or release notes somewhere that I didn't find?

+1


fix: allow configure message.timeout.ms and max.in.flight for kafka sink

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?

Expose message.timeout.ms and max.in.flight.requests.per.connection for kafka sink.
Change the default max.in.flight.requests.per.connection to 5, which is recommended in the confluent doc. Note that the previous default set by librdkafka is 1000000, which is not reasonable since it will create excessive produce requests that can potentially overload kafka broker and may cause a large number of duplicates on network blips.
Remove unused kafka sink option timeout and use_transaction

Checklist

[ ] I have written necessary rustdoc comments
[ ] I have added necessary unit tests and integration tests
[ ] I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features #7934).
[ ] My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
[ ] All checks passed in ./risedev check (or alias, ./risedev c)
[ ] My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)

[ ] My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

[x] My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

Expose message.timeout.ms and max.in.flight.requests.per.connection for kafka sink.
Change the default max.in.flight.requests.per.connection to 5.

See here for the meaning of these kafka client configs.

Should we also change the default batch.size for librdkafka in order to be conformed with confluent?
The current default is 1MB by the way.
In addition, since the number of in-flight requests sent by rdkafka is significantly changed, will this affect the current buffered FutureRecord? (Which is essentially the sent but not yet delivered (These records may be buffered in client, or may be in-flight) record.)

Should we also change the default batch.size for librdkafka in order to be conformed with confluent?
The current default is 1MB by the way.

1MB looks preferable to me because we prefer high throughput over low latency. We used to set it to 20MB in production so 1MB is reasonable in our case.

In addition, since the number of in-flight requests sent by rdkafka is significantly changed, will this affect the current buffered FutureRecord? (Which is essentially the sent but not yet delivered (These records may be buffered in client, or may be in-flight) record.)

The max.inflight controls the max inflight produce requests per destination broker. Since records are batched per topic partition using batch.size and produce request will further batch the record batches across different topic partitions per destination broker, I don't think setting max.inflight to 5 will significantly affect the production throughput. On the other hand, setting a large max.inflight may affect performance since record batches produced to the same topic partition are applied and persisted in order on the kafka broker. Having too many inflight record batches in the broker side can overload the broker and cause more delays.

LGTM! exposing batch.size is nice to have option

batch.size is already exposed via properties.batch.size


How can i redirect the user to registration link

Keycloak has register function to redirect the user to registration page.
keycloak.register({
redirectUri: redirectURI,
});
How can i acheive same thing with our library. Thanks in advance

From what I've checked, the UserManager which the library internally uses, does not provide a signupRedirect.
If I am missing something I am all ears! You can always build the url manually of course.

What about
const auth = useAuth(); auth.signinRedirect();
Gets you to provider login page.

What about const auth = useAuth(); auth.signinRedirect(); Gets you to provider login page.

signInReqirect() function will return you to Login Page. I want to show the registration page instead of Login Page to the user. Thank you

The issue arises as keycloak uses a non-default OIDC method for this. Looking at their JS adapter implementation (https://github.com/keycloak/keycloak/blob/e69031d411c981fa78b8320b9588771069b4b86d/js/libs/keycloak-js/src/keycloak.js#L846), they have coded a registration endpoint, which will throw an error on access when a default OIDC configuration is used.
                    register: function() {
                        return getRealmUrl() + '/protocol/openid-connect/registrations';
                    },

So looking farther, what is done is the normal createLoginURL (which is done in this library with the createSigninRequest(args) in the UserManager.ts) is wrapped and the options passed have the attribute "action" set to "register".  (https://github.com/keycloak/keycloak/blob/e69031d411c981fa78b8320b9588771069b4b86d/js/libs/keycloak-js/src/keycloak.js#L505)
This then causes that method to use the register endpoint instead of the authorize endpoint
        if (options && options.action == 'register') {
            baseUrl = kc.endpoints.register();
        } else {
            baseUrl = kc.endpoints.authorize();
        }

and deactivates the '&kc_action=' URL parameter, while "building" the final URL :
        var url = baseUrl
            + '?client_id=' + encodeURIComponent(kc.clientId)
            + '&redirect_uri=' + encodeURIComponent(redirectUri)
            + '&state=' + encodeURIComponent(state)
            + '&response_mode=' + encodeURIComponent(kc.responseMode)
            + '&response_type=' + encodeURIComponent(kc.responseType)
            + '&scope=' + encodeURIComponent(scope);
        if (useNonce) {
            url = url + '&nonce=' + encodeURIComponent(nonce);
        }
.....

So, essentially, this is IMO not in the scope of this library. However, if someone would want to support this feature, this is probably the things that need to be done:

Add 'register' endpoint to MetadataService
Either

Make the OidcClient.createSigninRequest aware of an alternative mode and add logic to use the register endpoint (instead of const url = await this.metadataService.getAuthorizationEndpoint();)
or create a new Method for handling registrations.

Extend the UserManager with a method to handle passing appropriate register flags AND/OR controlling that via custom field in CreateSigninRequestArgs.

This is just a first idea, but very likely out of scope for this library. Maybe there are better ways of implementing this. If I magically find time, I might try something.

No news on this feature ?

This issue (question) staled some time ago, closing it for now.


Enhance Docker Compose Volume Mounts: Read-Only Consistent

Modifying the docker-compose file to avoid the frequent support issue of container files being mounted as "directories" b/c the host file didn't exist, which occurred b/c the .env directory wasn't configured properly.
Enhancing documentation to require user to test their folder config prior to opt-ing in.

Modified this PR to only include the docs changes. @shrimalmadhur or @siddimore or @ian-shim please review when ready. Thank you.
Moving the docker-compose changes to a separate PR for testing "when we have time"


Travis config warnings

This is a very minor issue, but the travis dashboard lists some warnings for the config file:
root: deprecated key sudo (The key `sudo` has no effect anymore.)
cache: unknown key override ([npm ci, npm run cy ...])
root: missing dist, using the default xenial
root: missing os, using the default linux

I have a commit ready for PR that removes the unknown/deprecated lines and adds the missing ones.

@rcowsill Thanks..Also notices your message on Gitter regarding Github Actions. In case this is still relevant, please make a PR.

@rcowsill Thanks..Also notices your message on Gitter regarding Github Actions. In case this is still relevant, please make a PR.

@ckarande I submitted a PR (#223) as the change was ready to go. That said, it's not essential if the project is switched over to GitHub Actions CI. Feel free to close this issue and PR #223 in that case.

@ckarande I submitted a PR (#223) as the change was ready to go. That said, it's not essential if the project is switched over to GitHub Actions CI. Feel free to close this issue and PR #223 in that case.


fix query bug

What this PR does / why we need it:
fix query bug
Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story (FLPATH-xxxx):
Fixes #
Change type

[ ] New feature
[ ] Bug fix
[ ] Unit tests
[ ] Integration tests
[ ] CI
[ ] Documentation
[ ] Auto-generated SDK code

Impacted services

[ ] Workflow Service
[ ] Notification Service

Checklist

[ ] Subject and description added to both, commit and PR.
[ ] Relevant issues have been referenced.

jpa test added


ncu-ci: parse console text of the first failed phase

Previously we try to detect the type of the failed phase
and return a generic build failure when the job failed in a
non-test phase. This is not really necessary - the console
text parser is capable of detecting the actual build failure
from even the console text of the build phase. Also hard-coding
the test phase name makes the detection fragile when there
are configuration changes in the Jenkins. So we should just
skip the detection.
Fixes: https://github.com/nodejs/node-core-utils/issues/344

cc @nodejs/automation

@evenstensberg What do you mean by json side of things?

I’m just trying to understand the source of truth. New to the automation team so trying to get insight

@evenstensberg The source of truth is Jenkins. This tool adapts to the configurations there.

Okay so can't change output instead of removing the test?
CC @mhdawson for reviews

@evenstensberg There isn't anything actually removed here? It simply removes an false early return and always run the logic below no matter how the phases are named.

Okay gotcha, thanks for elaborating!


Form doesn't post Form.Input parameters on POST

Steps

Enter text in both fields
Click Submit
See only the username Input is included in the request.

<Form action="/endpoint" method="POST">
  <Form.Group widths='equal'>
    <Form.Input fluid label='Name' placeholder='Name' />
    <Input type="text" name="username" placeholder='Username' />
  </Form.Group>

  <Form.Button>Submit</Form.Button>
</Form>

Expected Result
I would expect the Form.Input to be included in the request.
Actual Result
Only Input is included. Is Form.Input intended to be strictly a control prop?
Version
0.75.1
Testcase
https://codesandbox.io/s/3485743nzp

Your inputs doesn't contain name, you should add them if you want form traditionally.
https://www.w3schools.com/tags/att_form_method.asp


Bad Request - IdentityRef type is not accepted for this request.

Hi,
I am running the tool to migrate from one org to another org. Process templates are both Scrum. When I run the tools I get the following error for each work item I try to migrate.
{"Message":"VS403426: IdentityRef type is not accepted for this request."}
I am not finding a solution that will work for me. Can anyone shed some light on the issue I am having?
Thanks,

Hi Paul,
I encountered this issue today. I used the remedy in Issue #25 and was able to get around it. Instead of "5.0-preview" I simply used "5.0" for api version in addition to setting the bypassRules=False


[a11y] Remove space/enter onKeyDown handling for open/close keyboard shortcuts panel

Summary
This is to fix an issue where trying to close the keyboard shortcuts panel with the Space and Enter keys doesn't work in Firefox or IE. Pressing space opens and closes the panel immediately and pressing enter seems to do nothing.
As far as I can tell it looks like the onKeyDown event is handled on the close button, but then because the focus is set to the "?" button that opens the panel, the corresponding onKeyUp event triggers an onClick and re-opens the panel.
So – I've removed the Enter and Spacebar handling from the close button's onKeyUp handler, which should just allow onClick to do its thing. Similarly, I removed the onKeyDown handler on the open button (if there's more context on disabling the enter key for that button let me know, but that seemed weird to me).
Gifs
Using keycastr to display keystrokes:

␣ = Space
↵ = Enter
⎋ = Esc

Before

After

Reviewers 🙏
@majapw @backwardok

Coverage increased (+0.02%) to 85.071% when pulling e42a33dd240793e0eb6568227af1df276606ad62 on cshaver:crit--keyboard-close-shortcuts-panel into 5a132cb2aacf469a898be4d097eea21d04726621 on airbnb:master.


fix: unpins schema-models version

closes #18

lgtm, I can bootstrap:
    'aind-data-transfer-models@git+https://github.com/AllenNeuralDynamics/aind-data-transfer-models@fix-18-unpin-models',
    'aind-data-schema==0.38.5'

Which should satisfy the watchdog library once this one gets merged.


Does BigText work with  links?

Hey man, loving this BigText JS. I've got it to work with your "span" demo but when I change the span to "a" anchor points it seems to break. Can I get it to work with a-href links?
Using "p" paragraphs instead of spans seems to work fine when I set the child selector to "> p". But changing it to "> a" as shown below doesn't want to work. The same happens if I try to use "ul" lists with links in them. Any help would be appreciated!

         project one
         project two
         project three
         project four
         project five

Figured it out!
I nested the span inside the anchor which seems to have worked. Then I called > a span on the child selector.

		project one
		this is project two
		example of three
		and four
		project five too
		maybe number 6


Blank flash message when trying to cancel the policy assignment for vm or template

Version:
master.20170813013530_81d444b
Steps:

Navigate to Compute->infrastructure->Virtual machines and select any vm or template.
From configuration click on policy->Manage policies
Click on cancel button

See attached screenshot:

@akarol please open an [UPSTREAM] BZ for this if not done already.


When tabs scroll buttons is hidden on mobile not all tabs can be clicked.

When tabs scroll buttons is hidden on mobile not all tabs can be clicked.

[x] This is not a v0.x issue.
[x] I have searched the issues of this repository and believe that this is not a duplicate.

Expected Behavior 🤔

And I make a quick fixed by following code.
scrollSelectedIntoView = () => {
    const { theme, value } = this.props;
    const { tabsMeta, tabMeta } = this.getTabsMeta(value, theme.direction);

    if (!tabMeta || !tabsMeta) {
      return;
    }

    if (tabMeta.left < tabsMeta.left) {
      // left side of button is out of view
      let nextScrollLeft = tabsMeta.scrollLeft + (tabMeta.left - tabsMeta.left);
      // if scroll buttons is hidden on mobile
      if (theme.breakpoints.down('xs')) {
        nextScrollLeft -= tabsMeta.clientWidth / 2 - tabMeta.width / 2
      }
      this.scroll(nextScrollLeft);
    } else if (tabMeta.right > tabsMeta.right) {
      // right side of button is out of view
      let nextScrollLeft = tabsMeta.scrollLeft + (tabMeta.right - tabsMeta.right);
      // if scroll buttons is hidden on mobile
      if (theme.breakpoints.down('xs')) {
        nextScrollLeft += tabsMeta.clientWidth / 2 - tabMeta.width / 2
      }
      this.scroll(nextScrollLeft);
    }
  };

It's not a perfect solution but better than nothing.
Current Behavior 😯

As you can see item5, item6 can't be clicked.

Steps to Reproduce 🕹

Link:

Check to https://material-ui.com/demos/tabs/
Use phone or scale browser down to xs size.

Context 🔦

Your Environment 🌎

Tech
Version

Material-UI
v3.9.3

You should be able to scroll horizontally to access the other tabs?

You should be able to scroll horizontally to access the other tabs?

 I test this on my phone and it work perfectly! I'll close this issue.


TODO: fix the wrong vertex_descriptor

https://github.com/NMBURobotics/vox_nav/blob/948391afeda9db0e14270ae0192b1195875546f0/vox_nav_planning/include/vox_nav_planning/plugins/optimal_elevation_planner.hpp#L166

addressed by https://github.com/NMBURobotics/vox_nav/commit/da370883a9b9aecb387c549666eb255a22d7277b


Can't provide max length for entering characters of Trumbowyg

Hi,
We are currently not able to restrict for number of characters for this editor.

It's hard to do, so I can't do that, sorry :/

See #316

But it won't stop typing after maxlength limit is reached.

That's not possible since the edit zone is not a form field but a contenteditable div.

We will likely validate server side ,but you can certainly use javascript to grab only the content of the html tags in the contenteditable and count the length.

Feel free to do it on your side, based on the tbwchange event :)


Enforce decision task start to close timeout upper limit

Force override decisoin task start to close timeout to 60s if input is larger
Increase passive task processing overdue threshold

Can you file a task to add validation in go client? Java client already has this validation.

Can you file a task to add validation in go client? Java client already has this validation.

https://github.com/uber-go/cadence-client/issues/801


Upgrade Open Amsterdam Project to Beckn Protocol 1.1 and ONIX Compliance

Description
The Open Amsterdam project previously utilized Beckn protocol v0.9, developed by the Automicle team, which set up buyer and seller apps for local businesses in Amsterdam. Two BPPs were used:

A Shopify adapter developed by Venky Mahadevan.
A BPP developed by the Plotch team.

The BAP was forked from FIDE's 0.93 version of Open Ams and modified for payment functionalities. The project has ended, and now, with the introduction of Beckn-ONIX, the Open Amsterdam project requires an upgrade to Beckn Protocol 1.1 and compliance with ONIX.
The next steps involve checking with the Automicle team to understand:

The current status of the project.
Whether any new buyers or sellers have been onboarded.
The Automicle team's readiness for utilizing the new Vendure BPP.
The necessity to upgrade the BAP due to the earlier version utilized.

A starter kit for Beckn-ONIX has been shared with the Automicle team to facilitate the upgrade process.
Goals

[ ] Conduct a status check with the Automicle team to understand the current state of the Open Amsterdam project.
[ ] Confirm if any new buyers or sellers have been onboarded since the project ended.
[ ] Assess Automicle’s readiness to utilize the new Vendure BPP in place of the earlier BPPs.
[ ] Plan for upgrading the BAP to be compliant with Beckn Protocol 1.1 and ONIX.

Expected Outcome

A clear understanding of the current status of the Open Amsterdam project.
A plan for upgrading the BPP to Vendure BPP and ensuring BAP is upgraded to Beckn Protocol 1.1.
Confirmation of whether new buyers or sellers have been onboarded and Automicle’s readiness to proceed with the upgrades.

Acceptance Criteria

[ ] The current status of the project is confirmed with the Automicle team.
[ ] Confirmation of whether any new buyers or sellers were onboarded.
[ ] The Automicle team’s readiness to integrate the new Vendure BPP is assessed.
[ ] BAP upgrade requirements are defined and the next steps planned for the upgrade.

Mockups / Wireframes
NA
Product Name
Open Amsterdam
Domain
Local Commerce Infrastructure
Tech Skills Needed

Beckn Protocol (v0.9 and v1.1)
BPP/BAP Knowledge
Shopify Adapter and Vendure BPP Integration
Beckn-ONIX Compliance

Complexity
High
Category
Project Upgradation
Sub Category
BPP/BAP Upgrade
Project View
Open Amsterdam Project
Project Name
Open Amsterdam

Viraj will be connecting with Sindhuja on the details. Meeting TBD.
@viraj89 @emmayank @faizmagic

On Sept 12, 2024, a meeting was held with Bharath, @viraj89, and @yesrag2309 for the Open Amsterdam project. Based on the requirements from Bharath, it is understood that the Open Amsterdam team requires the following support from FIDE:

Share the starter kit with the Open Amsterdam team.
Provide handholding for enabling the Open Amsterdam project to upgrade to protocol server 1.1.
Ensure the Open Amsterdam project is Beckn ONIX compliant.
Any fixes beyond this from FIDE are not part of the current scope.
A call with the Open Amsterdam team will be arranged once they have reviewed the starter kit, to provide technical support as needed.

cc @faizmagic @yesrag2309 @bharath-ganapathy

status and next steps:

Update: Oct 28, 2024
No update from Automicle team for the week of Oct 21-25 after the previous update, communicated to the team about the same via email. Proof below.
The following email was sent to the team stating there is no update or response from the Automicle team, this flow is de-priotized.
Closing this ticket for now.


Error 404 JSON Download of bible.tv

[x] I'm reporting a broken site support issue
[x] I've verified that I'm running youtube-dl version 2021.12.17
[x] I've checked that all provided URLs are alive and playable in a browser
[x] I've checked that all URLs and arguments with special characters are properly quoted or escaped
[x] I've searched the bugtracker for similar bug reports including closed ones
[x] I've read bugs section in FAQ

Verbose log
Provide the complete verbose output of youtube-dl that clearly demonstrates the problem.
Add the -v flag to your command line you run youtube-dl with (youtube-dl -v <your command line>), copy the WHOLE output and insert it below. It should look similar to this:
[debug] System config: []
[debug] User config: ['-o', './tubes/%(title)s.%(ext)s']
[debug] Custom config: []
[debug] Command-line args: ['-f', 'bestvideo[ext=mp4]+bestaudio[ext=m4a]/best[ext=mp4]/best', '-v', 'https://www.bibeltv.de/mediathek/videos/305315-pilot-1-2']
[debug] Encodings: locale UTF-8, fs utf-8, out utf-8, pref UTF-8
[debug] youtube-dl version 2021.12.17
[debug] Python version 3.8.10 (CPython) - Linux-5.4.0-132-generic-x86_64-with-glibc2.29
[debug] exe versions: ffmpeg 4.2.7, ffprobe 4.2.7, rtmpdump 2.4
[debug] Proxy map: {}
@Odin ~ $ youtube-dl -f 'bestvideo[ext=mp4]+bestaudio[ext=m4a]/best[ext=mp4]/best' -v "https://www.bibeltv.de/mediathek/videos/305315-pilot-1-2"
[brightcove:new] ref:305315: Downloading JSON metadata
ERROR: Unable to download JSON metadata: HTTP Error 404: Not Found (caused by <HTTPError 404: 'Not Found'>); please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; see  https://yt-dl.org/update  on how to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.
File "/usr/local/lib/python3.8/dist-packages/youtube_dl/extractor/common.py", line 634, in _request_webpage
return self._downloader.urlopen(url_or_request)
File "/usr/local/lib/python3.8/dist-packages/youtube_dl/YoutubeDL.py", line 2288, in urlopen
return self._opener.open(req, timeout=self._socket_timeout)
File "/usr/lib/python3.8/urllib/request.py", line 531, in open
response = meth(req, response)
File "/usr/lib/python3.8/urllib/request.py", line 640, in http_response
response = self.parent.error(
File "/usr/lib/python3.8/urllib/request.py", line 569, in error
return self._call_chain(*args)
File "/usr/lib/python3.8/urllib/request.py", line 502, in _call_chain
result = func(*args)
File "/usr/lib/python3.8/urllib/request.py", line 649, in http_error_default
raise HTTPError(req.full_url, code, msg, hdrs, fp)
Description
youtube-dl -f 'bestvideo[ext=mp4]+bestaudio[ext=m4a]/best[ext=mp4]/best' -v "https://www.bibeltv.de/mediathek/videos/305315-pilot-1-2"

The hydration JSON metadata says 'drm': true. Please check whether you can play the video in your browser with DRM disabled.

The service is geo-locked to German IPs; they check your IP address via
https://www.bibeltv.de/mediathek/api/geo
and if !=DE, you get:
Video nicht verfügbar
Dieses Video ist leider aus lizenzrechtlichen Gründen in Ihrem Land nicht verfügbar

If that hurdle is bypassed (whitelisted DE IP), you get below result if EME/DRM has been temporarily disabled:

If EME/DRM is enabled, you get served a MPEG-DASH manifest with cenc:
https://manifest.prod.boltdns.net/manifest/v1/dash/live-baseurl/bccenc/6415507950001/6920d62d-d995-46d8-8c86-318a0fe90cb7/6s/manifest.mpd?fastly_token=NjM4MWMzZWFfYjYyMzU2YTk4MjdjYjM4MmE4MDNjZWE5MDVhYzY2ZTk2MDMxMWJjMTM5N2ZhMzE3MzJhMmY2NjFkMzhkMjlmNQ%3D%3D

(supposedly, bccenc stands for BrightCove Common Encryption); as I have said in other "similar" issues, we have already entered the era of "DRM-everywhere" 😠 😡 ...
Unless some way is found to retrieve streams with softer encryption (ClearKey/AES128), this is another dead end as far as yt-dl is concerned...
OT: I used to be a fan of that series (Highway to Heaven) when it was current (mid to late 1980s) 😉 ...

Less OT, currently S1E16 on "Great!TV" (nothing newer than 2000 channel, formerly "Sony Channel") in the UK, possibly accessible from Central Europe: https://www.lyngsat.com/tvchannels/uk/Great-TV.html. Only "encrypted" by having no DE audio or subtitles.
OP may experience dissatisfaction with a search for the show auf Deutsch as the title matches a 2001 porno.
But apparently bibeltv.de is a no-go unless someone finds otherwise.


Fixes several memory leaks associated with destroying an actor

Summary of changes:
Creates a public method on actor that unobserves the collider and breaks the reference to the collider.
Removes mesh references to the actor to be destroyed
Removes material references to the actor to be destroyed
Added the ability to set the Collider layer using setCollider.
- Setting the collider when instantiating an actor creates a memory leak due the manner in which the collider is attached to the actor.  Left a TODO to resolve this, but did not want to introduce any code breaking changes.
Unobserves 'other' collider listeners when copying to a new collider.

I was able to identify and resolve the memory leak associated with calling _setCollider() from within actor.copy().
There was an existing reference to the collider through the collider geometry.
To resolve this, and to only call generateColliderGeometry once, I deferred generateColliderGeometry in setCollider() into _setCollider().  Due to the typing, I added an if/then/else block to re-assign size and center.  I then call generateColliderGeometry to create a new geometry, and re-assign it to the collider to break the references.
I removed the TODO comments as now you can instantiate an actor simultaneously with the collider without the memory leak.

I resolved some additional memory leaks stemming from not cleaning up animation references.

This PR is targeting the wrong branch.  Can you please retarget it to the red branch for further review?

@tombuMS - Thanks for pointing that out.  I believe I should have submitted another PR targeting the red branch, can you confirm that looks correct on your end?  We can close this PR request if it looks correct.


Drop boto 2 support

Codecov Report

Merging #731 (5ea639b) into master (4f70152) will increase coverage by 0.36%.
The diff coverage is n/a.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
@@            Coverage Diff             @@
##           master     #731      +/-   ##
==========================================
+ Coverage   89.94%   90.30%   +0.36%
==========================================
  Files          28       27       -1
  Lines        1790     1774      -16
  Branches      254      254
==========================================
- Hits         1610     1602       -8
+ Misses        145      137       -8
  Partials       35       35

Impacted Files
Coverage Δ

vcr/patch.py
89.56% <ø> (+1.13%)
:arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

@hartwork I didn't investigate to find out since when the tests don't run with boto. This looks more like a code cleanup to me, rather than a support removal, because this has already been done.
I don't think a new major version is needed.

rather than a support removal, because this has already been done.

@jairhenrique are we sure that support for boto 2 is currently unusable? If not, I'd consider it removal of a feature and hence a breaking change.

The trove classifiers for python support of boto2 and vcrpy only have python 3 listed as an overlapping dependency. The last boto2 release declares python 3.5 as its highest supported version; whereas vcrpy has a >3.8 python requirement. It could be argued that attempting to keep supporting boto2 is a uphill battle on that conflicting information alone.

I'm with the with two of you that boto 2 support should be dropped. The question if it's a backwards compatible change is tied to the question whether it's possible to use boto 2 with recent VCR.py. boto 2 does not prohibit use with Python >=3.8 in setup.py. The boto tests required an AWS account to run. Does one of you have an AWS account that could be used to run tests/integration/test_boto.py against to get a clear answer on that?

@hartwork @jairhenrique
Some tests work, some tests fail.
$ python -m pytest -s -v tests/integration/test_boto.py
========================================================================================= test session starts =========================================================================================
platform linux -- Python 3.11.1, pytest-7.4.0, pluggy-1.0.0 -- /home/epiphyte/.pyenv/versions/3.11.1/envs/vcrpy3111/bin/python
cachedir: .pytest_cache
rootdir: /home/epiphyte/PycharmProjects/vcrpy
configfile: pyproject.toml
plugins: asyncio-0.21.0, httpbin-2.0.0, cov-4.1.0
asyncio: mode=Mode.STRICT
collected 5 items

tests/integration/test_boto.py::test_boto_stubs PASSED
tests/integration/test_boto.py::test_boto_without_vcr FAILED
tests/integration/test_boto.py::test_boto_medium_difficulty FAILED
tests/integration/test_boto.py::test_boto_hardcore_mode FAILED
tests/integration/test_boto.py::test_boto_iam PASSED

============================================================================================== FAILURES ===============================================================================================

The failing tests rely on a public bucket boto-demo-1394171994. I do not think this bucket exists anymore?
The test referring to it came from https://github.com/kevin1024/vcrpy/commit/6bb67567f9d5d9ccb0adad8b4375ffe17e197cb3 which is 9 years old. @kevin1024 was this bucket removed?

IIRC (and it's been a long 9 years!) The bucket doesn't need to have anything in it for the tests to pass; it just needs to exist and the AWS creds need to have access to that bucket.

I think that whether or not the tests pass with the boto, it doesn't matter. We can think of it here as Python, the VCR still works with Python 3.7, but we stopped supporting it because it's a version that reached EOL. With BOTO it's the same thing, it may work, but the library is no longer supported. Those who use old versions, install old versions of dependencies.
I believe the big question here is which number should we increment the VCR to, 5.1.0 or 6.0.0, and I'm not sure if it's necessary to go up to a 6.0.0 version since at other times, things have been deprecated around here and just incremented the MINOR semantic versioning number.
What is your opinion about this?

@jairhenrique I consider these things interconnected. In my mind the two healthy options are:

a) Ignore whether boto support is functioning and do a major version bump (so that not even in theory working in-use support for boto can break for someone without a proper semver warning sign)
b) Prove boto support unusable, drop it, no major version bump

I'd be good with either of these, but would personally have trouble supporting a mixture. If the two of you — @jairhenrique and @kevin1024 — find something to agree upon in this context, I can be good with that though. I hope that's good enough.

a) Ignore whether boto support is functioning and do a major version bump (so that not even in theory working in-use support for boto can break for someone without a proper semver warning sign)

I vote for this one.  No need to break support if it’s working, but also no need to put in the effort to make sure it’s supported.  Let’s just document that support is dropped and do a major version bump.


Automated cherry pick of #7798: guest short desc add backup host id

Cherry pick of #7798 on release/3.2.
#7798: guest short desc add backup host id

/lgtm
/approve


Model

Would you mind sharing the weights of your trained BofN?

It will be made available as soon as possible. Thank you.


Web demo?

v86 would work well for a web demo...

I have tried to run ISObash on ArchLinux ( https://copy.sh/v86/?profile=archlinux ) but the performance is very poor. The best option for a web demo is convert code to javascript and run it directly.


feat: provide kafka-broker transfer streaming sample

What this PR changes/adds
Adds a streaming kafka-broker sample, that shows how to stream data through EDC with a custom DataFlowController without using the data-plane.
Why it does that
streaming
Further notes

removed the Checkstyle job in the ci as Build already runs checkstyle
cleanup FileTransferCommon, that contained a lot of unused methods

Linked Issue(s)
Closes #150
Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.

This is awesome!
Small question though, could the set of .json files be replaced by a Postman collection?
The advantage is that the placeholder values can be set as collection variables.
Also doing so it is possible to automate the process of extracting the value from a response to set a variable for the next request .

This is awesome! Small question though, could the set of .json files be replaced by a Postman collection? The advantage is that the placeholder values can be set as collection variables.
Also doing so it is possible to automate the process of extracting the value from a response to set a variable for the next request .

currently all the samples work with json files, because they can be used both in the sample manual process and in the automated tests. The postman thing could be proposed in a new issue eventually


Prevent animation reset on refresh layout

We set up a transition page with custom animation while loading the map.  We found that when using a transition page to hide the map being loaded, the current code (using display: none) resets the animations.  Using 'display: inline-block' has the same functionality but doesn't create a blip or reset.
I also found another solution... the following code does the exact same thing but is much less invasive and may have a lot less side effects since it doesn't effect the display of the body. This will trigger a hardware reset and then remove it for if they re-enter the map:
  document.body.style.transform = 'rotateZ(0deg)';
  document.body.style.transform = '';

Both methods have been tested and confirmed to work on iOS.
A similar method to the above is also noted on the stack overflow post you reference within the code block.
I am happy to create another pull request with the transform code block if desired.

Thanks


Aesthetic Cleanup and Lighting Improvements 👍 :)

awesome code! I've made some aesthetic changes and slightly improved the lighting mechanics so it can be smoother. these changes were made simply so future onlookers can have a better understanding of the code you have written here and to allow easier navigation and overall comprehension. code is cleaner following some "aesthetic" guidelines
changes:

I've improved the module system, removing the pubs and allowing easier navigation and comprehension for future onlookers of the code.

init() now has it's own file and has been renamed to "Rubik", this is because of the functions massive size and required variables. this can be found in: init.rs

color constants also have their own file now in: color.rs

lighting of the cube is slightly smoother, i added some lazy bias using OPs a, b, and c constants. however, it can definitely be way more tuned. I just didn't feel like writing a script to do so lol. maybe someone else can further improve upon it. can be tweaked in the luminance functions. this can ofc be reverted back to the original, until a solid improvement is implemented.

new functions implemented to avoid code repetition, the same can be done for init (now Rubik) , but i have to work on another project so OP or someone else can tackle that.

also worth nothing:
in the tests i've done, it seems the overall performance has slightly improved.

Thank you for your PR, it looks great so I will merge it.
Here are some thoughts:

Could you elaborate on "lighting of the cube is slightly smoother, i added some lazy bias using OPs a, b, and c constants. however, it can definitely be way more tuned."?
I noticed that you added this to the code and I'm not 100% sure of the purpose of dividing by a, b, and c.

    //added some simple maths so lighting is slighty smoother
    rotated_light_source.x = cos_d * cos_e * light_source.x
        + (cos_d * sin_e * sin_f - sin_d * cos_f) * light_source.y/a
        + (cos_d * sin_e * cos_f + sin_d * sin_f) * light_source.z/b;
    rotated_light_source.y = sin_d * cos_e * light_source.x
        + (sin_d * sin_e * sin_f + cos_d * cos_f) * light_source.y/a
        + (sin_d * sin_e * cos_f - cos_d * sin_f) * light_source.z/b ;
    rotated_light_source.z =
        -light_source.x/b * sin_e + light_source.y/a * cos_e * sin_f + light_source.z/c * cos_e * cos_f;

I agree with your decision to move large functions into modules as I'm currently working on GPU Acceleration and making the cube interactive which makes implementing this easier. Ideally, I would let the user decide on how rs-cube is rendered with a CLI arg/flag, however, that is a current work in progress.
Yes, one of the fundamental goals of rs-cube is performance so thank you for taking note of it.

Once again thank you for the PR and such a detailed report.

Hey! Im glad you like the changes.
Im guessing one of  my "git add ." calls didn't go through since I meant for it to be *a instead of /a. however the difference is near to none. the reasoning behind this is really just in hopes that the fluctuations between the shading parameters have less of a significant gap allowing the shading to seem "smoother". The optimal way of course is to further tweak and play with the values within the the light_source and rotated_light_source vectors.
Besides that, I'm looking forward to seeing future progress in your code!

Thanks, I will refactor the code to clean things up a bit and make sure that there are no naming conflicts for GPU Acceleration.
It makes sense so I will test both the original and your lighting and decide from there. I will also add your name to the next version's release notes if you're ok with that to credit you for your contribution.

Sounds good ! And of course, I don't mind.


docker.yml: also build image for arm64

Unfortunately, archlinux is only built for amd64.  I usually build with alpine, but they've stopped building streamlink packages due to an upstream issue.  Let me work on switching to a different distro so that I can re-enable multi-arch support.

Multi-arch are back!


Resetting state appropriately after errors

This will handle resetting state appropriately after errors have occurred in the modal

Looks good 👍

Reviewer @jfurrow

Looks great!


IDVA6-1181 check the details before you add the user page

Link to Jira:
https://companieshouse.atlassian.net/browse/IDVA6-1181
Changes:

Session utilities added
Check member details page created
Temporary code added to allow testing until the API is available

CI: No security warnings found

CI: No security warnings found

CI: No security warnings found


create_game_from_lobby null pointer access exception

We ran into a crash in create_game_from_lobby, very similar to issues 88656 and 85479 on the xbox one development forum.
Looking at the crash I see that sessionToCommitCopy on line 960 is null (which is where it crashed). The commitResult error is 412 and null payload. As the lobby only has 1 session property (joinable_by_friends) and doesn't have c_transferHandlePropertyName which means is_transfer_handle_state would have returned false, the empty payload was assigned to sessionToCommitCopy which resulted in this crash.
Adding a null check to the while statement will probably prevent this crash, but I'm not sure if this is the proper fix.

Thanks for the bug report

For completeness, we ran into an issue with a microsoft provided version (See dev forum 92324, NDA). I did not try it with source where commit b5d3a5f3ccd7567e1a915f4759c74f61164ee947 might had already fixed the issue. To be safe, we'll be using source with the nullptr check.

Closing since post references a potential fix. If this issue is still happening please reactivate.


allow do define a 'responsible' string per bp that can be used in the…

… trigger subcommand...
This change allows to define a 'responsible' field (handled as string) in the business Process definition which is passed to the resulting 'result set'. The 'result set' containing the responsible field can then be used in the template set for the trigger command which would allow for example to call up different organization units per business process... Which is nice if you have more than one entry point for "on-duty alerts".


Adds a verification model for OpenSSL

Signed-off-by: Felipe R. Monteiro<EMAIL_ADDRESS>Resolved issues:
N/A.
Description of changes:
Adds, as a sub-module, a verification model for OpenSSL for CBMC proofs. We use the same set of abstractions across multiple projects.
Call-outs:
N/A.
Testing:
N/A.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Codecov Report

Merging #2293 into main will increase coverage by 48.35%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             main    #2293       +/-   ##
===========================================
+ Coverage   39.07%   87.42%   +48.35%
===========================================
  Files         165      165
  Lines       12860    13720      +860
===========================================
+ Hits         5025    11995     +6970
+ Misses       7835     1725     -6110

Can the other directories be deleted as well?
https://github.com/awslabs/s2n/tree/main/tests/cbmc/include/openssl
https://github.com/awslabs/s2n/tree/main/tests/cbmc/sources/openssl

We weren't sure whether it was best to do that as one or two PRs.  Which would you prefer?

I thought it might be easier to track if it was in a single PR, but no strong preference for me as long as it gets cleaned up. :)

Codecov Report

Merging #2293 (1745697) into main (efbb48b) will decrease coverage by 1.04%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #2293      +/-   ##
==========================================
- Coverage   81.84%   80.79%   -1.05%
==========================================
  Files         268      266       -2
  Lines       18300    17942     -358
==========================================
- Hits        14978    14497     -481
- Misses       3322     3445     +123


Change default HTML extension from .xhtml to .html

The .xhtml extension will cause problems with older versions of IE (IE8 and lower) (the file will not open) so we should revert to the default .html extension.  The file itself will still be produced in XHTML

Sorry, I messed up the initial commit, the issues should be fully resolved now.


⚠ Turnos 24x7 has degraded performance

In 6057572, Turnos 24x7 (https://reservas-dev.alternativasinteligentes.com/) experienced degraded performance:

HTTP code: 200
Response time: 903 ms

Resolved: Turnos 24x7 performance has improved in 3e94007.


Moving Asset registration of lunar-panel css to Panel definition

Currently the registration of the lunar-panel.css is being within Filament:serving method which is triggered only on a Filament Panel request. So, this causes an issue of the assets registered within it not being published when php artisan filament:upgrade is being called. Since lunar-panel.css needs to only be served for the Lunar panel requests, it is ideal that the asset registration can be moved where the Lunar Panel is being setup.

Thanks @abishekrsrikaanth


ta_lib.go is too long

Couldn't open it with default vim configuration, please consider splitting.

Every editor I have ever used easily handles 5k lines. GitHub does as well. I realize it's rather large, but I prefer to keep it in one file to make it very easy to integrate directly into other projects if desired. You could simply strip out what you don't need and add the single file to your project. No need to install even.


make new release

you haven't made a new release after merging PR#21 please do this so the readme will be correct

Hi @bloohacked! We just shipped v1.2.4. Thanks for your support!


Keyboard navigation "sabotaged" by focus-reset functionality

Describe the problem
I am trying to implement key navigation in a Sveltekit app. The focused element is indicated by an outline, navigation is done by arrow keys and clicking by Enter or OK key. The problem is that focus is set to the body tag every so often.
In this file:
.svelte-kit/dev/runtime/internal/start.js
I found these lines:
// make it possible to reset focus
document.body.setAttribute('tabindex', '-1');

Describe the proposed solution
The workaround I have implemented now is the following: in onMount of __layout.svelte, I execute
document.body.removeAttribute('tabindex');
but this is an ugly hack.
Is there currently any better way to handle this? Otherwise I suggest a change to make Sveltekit more key-navigation-friendly. Perhaps a config parameter in svelte.config.js to enable disable tabindex on body? Or a flag in the app to use when switching between mouse and keyboard navigation.
Alternatives considered
No response
Importance
would make my life easier
Additional Information
With the growing demand and requirements for web app accessibility, where keyboard navigation plays a central role, this should be prioritised. In TV applications, keyboard navigation is used almost exclusively (with remote controls).

This is intentional, and is intended to improve accessibility. tabindex="-1" is set on the body element so that it can receive focus. Whenever SvelteKit navigates to a new page (via an <a> or by calling goto()), it resets focus to the body element. This is to simulate how the browser behaves when doing a full-page reload -- see https://github.com/sveltejs/kit/issues/307 for further explanation.
If you are using goto to navigate, you can set keepfocus to true to keep focus on the current element instead of resetting it. However, if you do this, you need to make sure that the current element will still exist so that focus is not lost.
goto('/newpage', { keepfocus: true });

If this is not enough to support your use case, please provide some sample code to show what you're trying to do.

Thank you! This is basically what I was looking for. I think this should cover my use case, unless there are any other scenarios in which focus is sent to body. I will test.

Closing this since it sounds like keepfocus: true should do what you need. Please reopen if that's not the case.


AttributeError: 'Solver' object has no attribute 'fit_weights'

I was following the learning guide in the docs and ran into this error. I'm using motile==0.1.3
I pip installed motile, maybe the published docs show features that are not yet available in the pypi package? Installing from github seems to have solved the issue (and downgraded from the version from 0.1.3 to 0.1.2)

hey @pattonw.  Strange, v0.1.3 on pypi was definitely released from main after https://github.com/funkelab/motile/pull/23 was merged...  let me look into it and I'll cut a new release

hey @pattonw, I just cut a new release.  At first I (a bit mindlessly) released as v0.1.4, but then I re-released the same version as v0.2.0 since there were enough changes to warrant that bump.  So v0.2.0 should be out in a moment and will solve this.


Quick spelling correction

Corrected spelling of the word "easier" in Chapter 4 Exercise 6, as well as changing measurmentStatus to measurementStatus in Exercise 7. One of our tasks for the course was to do a pull request...might as well make it meaningful!

Thanks! Always good to have more eyes on this.


Libnetwork documentation doesn't show calico-ipam with --subnet

Our Libnetwork Documentation doesn't show an example for launching a calico with Calico IPAM on a particular subnet.
We should provide information on it, including the known restriction that "the --subnet you specify must precisely match a pool you've created.

This issue was moved to projectcalico/calico#65