Download Playlist feature for www.xvideos.com.

Checklist

[x] I'm reporting a site feature request
[x] I've verified that I'm running yt-dlp version 2021.09.25
[x] I've searched the bugtracker for similar site feature requests including closed ones

Description
I am trying to download a xvideos playlist ("https://www.xvideos.com/favorite/79225393/yt-dlp") and yt-dlp gives error
yt-dlp https://www.xvideos.com/favorite/79225393/yt-dlp
[generic] yt-dlp: Requesting header
WARNING: [generic] Falling back on generic information extractor.
[generic] yt-dlp: Downloading webpage
[generic] yt-dlp: Extracting information
ERROR: [generic] Unsupported URL: https://www.xvideos.com/favorite/79225393/yt-dlp
please support playlist and channel downloads from xvideos in yt-dlp.
Note : I am completely aware yt-dlp can download the individual videos from xvideos.com but creating a text file full of links isn't the solution I want thus raising this issue on Github.
If there exists any other way to solve this problem then please let me know.

Came here looking for this, would really appreciate it fixed

I think they don't want to work for it. Although there is a simple way to do that. Just copy the links page by page into a text file and use it as batch download in yt-dlp.

Copying page by page is insane when there's multiple pages of content, and not ideal for people who want it to automatically check for new videos and download.
That is not a fix, just a tedious work around.

Copying page by page is insane when there's multiple pages of content, and not ideal for people who want it to automatically check for new videos and download. That is not a fix, just a tedious work around.

can you share the playlist link maybe I can help.


[Net] Fix WebRTC returning packets from peers too early.

Due to the async nature of WebRTC implementations, the multiplayer peer could end up having queued packets from a given connection before it is able to emit the "peer_added" signal.
This commit ensures that packets from peers which are not notified yet are skipped by get_packet and get_available_packet_count.
Fixes #41412 , closes #42017
3.x version here: #55953

Thanks!


feat(init): Add deno task config to start fresh

How about adding deno task config for start fresh project on initializing process?

Can you update the info in the docs and the readme too to use deno task?

✅ e2cb92d (#143)


add istioctl experimental pod to get logs of pod sidecar (#17186)

Please provide a description for what this PR is for.
Please refer to https://github.com/istio/istio/issues/17186
The purpose of this pr is to modify the log level of envoy sidecar for specified pod.
In addition, with -f option, we can get log stream.
# istioctl experimental pod -f --tail=10 productpage-v1-79f84797b5-hxmvl --log_level=debug
Update log level of pod productpage-v1-79f84797b5-hxmvl to debug
====
':status', '200'
'content-type', 'text/plain; charset=UTF-8'
'cache-control', 'no-cache, max-age=0'
'x-content-type-options', 'nosniff'
'date', 'Tue, 24 Sep 2019 09:02:24 GMT'
'server', 'envoy'

[2019-09-24 09:02:24.726][14][debug][connection] [external/envoy/source/common/network/connection_impl.cc:520] [C118] remote close
[2019-09-24 09:02:24.726][14][debug][connection] [external/envoy/source/common/network/connection_impl.cc:190] [C118] closing socket: 0
[2019-09-24 09:02:24.726][14][debug][main] [external/envoy/source/server/connection_handler_impl.cc:80] [C118] adding to cleanup list
[2019-09-24 09:02:25.643][23][debug][http] [external/envoy/source/common/http/conn_manager_impl.cc:247] [C6] new stream
[2019-09-24 09:02:25.643][23][debug][http] [external/envoy/source/common/http/conn_manager_impl.cc:620] [C6][S9964353507108744574] request headers complete (end_stream=true):
...

And to help us figure out who should review this PR, please
put an X in all the areas that this PR affects.
[ ] Configuration Infrastructure
[ ] Docs
[ ] Installation
[ ] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[ ] Security
[ ] Test and Release
[x] User Experience
[ ] Developer Infrastructure

@waret: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

lintmodern_istio
69042da541f7eee685afe3bae2a09d4d218aecf3
link
/test lintmodern

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@waret: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

lintmodern_istio
69042da541f7eee685afe3bae2a09d4d218aecf3
link
/test lintmodern

lint_istio
69042da541f7eee685afe3bae2a09d4d218aecf3
link
/test lint

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@waret: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

lint_istio
69042da541f7eee685afe3bae2a09d4d218aecf3
link
/test lint

lintmodern_istio
1baa158d8496612e9b441795613f5b572afa7998
link
/test lintmodern

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@waret: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

lintmodern_istio
1baa158d8496612e9b441795613f5b572afa7998
link
/test lintmodern

lint_istio
1baa158d8496612e9b441795613f5b572afa7998
link
/test lint

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest

Essentially, this pr provides integration of the following three commands:
istioctl dashboard envoy <pod-name>
curl -X POST http://localhost:<local-port>/logging?http=debug
kubectl logs -f --tail=0 <pod-name> -c istio-proxy

Actually I'm not quite sure if this feature is necessary.

@waret: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

lintmodern_istio
93f823978b3b45c3671cac84c930d26811c2c681
link
/test lintmodern

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Is there a proposal for this that the UX working group or any working group has approved?

don't known about that, only see the issue #17186

This command literally invokes kubectl logs -c istio-proxy. Users of Kubernetes already know how to do that and don't need an alternative syntax.
The POST to http://localhost:%d/logging?level=%s is useful. A subcommand to get and set the log level of Envoy seems useful. Having it also invoke kubectl is my concern.

I just hide the option, in case someone wants to use that.

/retest

@waret: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

integ-security-k8s-tests_istio
809cd44d8b5991d7d7604c148a85226d3e5f3d14
link
/test integ-security-k8s-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

I agree with @esnible. The idea is useful and reduces toil. However, I don't think we should wrap kubectl logs. I also don't think we should introduce a new pod command. Can we extend istioctl proxy-config with subcommands for modifying the envoy admin params?
e.g.
# set log level and tail it
$ istioctl proxy-config logging pod-foo  --log_level=debug && kubectl log pod-foo -f

# get the current log levels
$ istioctl proxy-config logging pod-foo
active loggers:
  admin: warning
  aws: warning
  assert: warning
  backtrace: warning
  # etc ...

We could also add some of the other admin options under proxy-config as needed, e.g. reset_counters, runtime_modify.

I aggree with @ayj.

@waret: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

lint_istio
c3af95ce0a8384591d66fa4e8982b97c1ee764e7
link
/test lint

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test lint

@waret: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

lint_istio
c3af95ce0a8384591d66fa4e8982b97c1ee764e7
link
/test lint

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@waret: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

lint_istio
c3af95ce0a8384591d66fa4e8982b97c1ee764e7
link
/test lint

integ-new-install-k8s-tests_istio
c3af95ce0a8384591d66fa4e8982b97c1ee764e7
link
/test integ-new-install-k8s-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

users can modify the default logging levels through helm flags - I can
point you to where that code is when im not on a phone
On Fri, Sep 27, 2019, 7:46 PM Waret<EMAIL_ADDRESS>wrote:

@waret commented on this pull request.
In istioctl/cmd/proxyconfig.go
https://github.com/istio/istio/pull/17339#discussion_r329293620:

	}

	_, _ = fmt.Fprint(c.OutOrStdout(), string(resp))

	return nil

},

}

levelListString := fmt.Sprintf("[%s, %s, %s, %s, %s, %s, %s]",

levelToString[TraceLevel],

levelToString[DebugLevel],

levelToString[InfoLevel],

levelToString[WarningLevel],

levelToString[ErrorLevel],

levelToString[CriticalLevel],

levelToString[OffLevel])

s := strings.Join(activeLoggers, ", ")
loggingCmd.PersistentFlags().BoolVarP(&reset, "reset", "r", reset, "Specify if the reset logging level to default value (warning).")

This default value of warning comes from command pilot-agent which has
proxyLogLevel flag with default value of warning(hard coded), and it then
passes this parameter to Envoy. Additionally, because there is no config
file like .kube for kubectl, I don't think users can change this default
value.
If users want to ship misc:error and everything else warning, I think
maybe we can support them to use istioctl pc log --level
all:warning,mis:error, with all:warning or warning in the front. Do you
think this is ok? Thx.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/istio/istio/pull/17339?email_source=notifications&email_token=AAEYGXPWMNPKMURQUFUS3YDQL3ARJA5CNFSM4IZ4637KYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCGHYCSQ#discussion_r329293620,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAEYGXLHBEIB4PLLYTHYTMLQL3ARJANCNFSM4IZ4637A
.

@waret: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

integ-new-install-k8s-tests_istio
c3af95ce0a8384591d66fa4e8982b97c1ee764e7
link
/test integ-new-install-k8s-tests

lint_istio
48e75a8a8ed5ea265021f1b03d0c15917974a9b4
link
/test lint

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@waret: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

integ-new-install-k8s-tests_istio
c3af95ce0a8384591d66fa4e8982b97c1ee764e7
link
/test integ-new-install-k8s-tests

lint_istio
48e75a8a8ed5ea265021f1b03d0c15917974a9b4
link
/test lint

unit-tests_istio
48e75a8a8ed5ea265021f1b03d0c15917974a9b4
link
/test unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@waret: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

integ-new-install-k8s-tests_istio
c3af95ce0a8384591d66fa4e8982b97c1ee764e7
link
/test integ-new-install-k8s-tests

lint_istio
48e75a8a8ed5ea265021f1b03d0c15917974a9b4
link
/test lint

unit-tests_istio
48e75a8a8ed5ea265021f1b03d0c15917974a9b4
link
/test unit-tests

racetest_istio
48e75a8a8ed5ea265021f1b03d0c15917974a9b4
link
/test racetest

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@waret: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

integ-new-install-k8s-tests_istio
c3af95ce0a8384591d66fa4e8982b97c1ee764e7
link
/test integ-new-install-k8s-tests

lint_istio
48e75a8a8ed5ea265021f1b03d0c15917974a9b4
link
/test lint

unit-tests_istio
48e75a8a8ed5ea265021f1b03d0c15917974a9b4
link
/test unit-tests

racetest_istio
48e75a8a8ed5ea265021f1b03d0c15917974a9b4
link
/test racetest

codecov_istio
48e75a8a8ed5ea265021f1b03d0c15917974a9b4
link
/test codecov

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@waret: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

lint_istio
48e75a8a8ed5ea265021f1b03d0c15917974a9b4
link
/test lint

unit-tests_istio
48e75a8a8ed5ea265021f1b03d0c15917974a9b4
link
/test unit-tests

racetest_istio
48e75a8a8ed5ea265021f1b03d0c15917974a9b4
link
/test racetest

codecov_istio
48e75a8a8ed5ea265021f1b03d0c15917974a9b4
link
/test codecov

integ-new-install-k8s-tests_istio
48e75a8a8ed5ea265021f1b03d0c15917974a9b4
link
/test integ-new-install-k8s-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@waret: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

lint_istio
48e75a8a8ed5ea265021f1b03d0c15917974a9b4
link
/test lint

racetest_istio
48e75a8a8ed5ea265021f1b03d0c15917974a9b4
link
/test racetest

codecov_istio
48e75a8a8ed5ea265021f1b03d0c15917974a9b4
link
/test codecov

integ-new-install-k8s-tests_istio
48e75a8a8ed5ea265021f1b03d0c15917974a9b4
link
/test integ-new-install-k8s-tests

unit-tests_istio
60e4a55e805b8db5e621ff0f95fe76e95e5eb43b
link
/test unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@waret: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

lint_istio
48e75a8a8ed5ea265021f1b03d0c15917974a9b4
link
/test lint

codecov_istio
48e75a8a8ed5ea265021f1b03d0c15917974a9b4
link
/test codecov

integ-new-install-k8s-tests_istio
48e75a8a8ed5ea265021f1b03d0c15917974a9b4
link
/test integ-new-install-k8s-tests

unit-tests_istio
60e4a55e805b8db5e621ff0f95fe76e95e5eb43b
link
/test unit-tests

racetest_istio
60e4a55e805b8db5e621ff0f95fe76e95e5eb43b
link
/test racetest

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@waret: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

integ-new-install-k8s-tests_istio
48e75a8a8ed5ea265021f1b03d0c15917974a9b4
link
/test integ-new-install-k8s-tests

unit-tests_istio
60e4a55e805b8db5e621ff0f95fe76e95e5eb43b
link
/test unit-tests

racetest_istio
60e4a55e805b8db5e621ff0f95fe76e95e5eb43b
link
/test racetest

codecov_istio
60e4a55e805b8db5e621ff0f95fe76e95e5eb43b
link
/test codecov

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

users can modify the default logging levels through helm flags - I can point you to where that code is when im not on a phone
…
On Fri, Sep 27, 2019, 7:46 PM Waret @.> wrote: @.* commented on this pull request. ------------------------------ In istioctl/cmd/proxyconfig.go <#17339 (comment)>: > + } + _, _ = fmt.Fprint(c.OutOrStdout(), string(resp)) + return nil + }, + } + + levelListString := fmt.Sprintf("[%s, %s, %s, %s, %s, %s, %s]", + levelToString[TraceLevel], + levelToString[DebugLevel], + levelToString[InfoLevel], + levelToString[WarningLevel], + levelToString[ErrorLevel], + levelToString[CriticalLevel], + levelToString[OffLevel]) + s := strings.Join(activeLoggers, ", ") + loggingCmd.PersistentFlags().BoolVarP(&reset, "reset", "r", reset, "Specify if the reset logging level to default value (warning).") This default value of warning comes from command pilot-agent which has proxyLogLevel flag with default value of warning(hard coded), and it then passes this parameter to Envoy. Additionally, because there is no config file like .kube for kubectl, I don't think users can change this default value. If users want to ship misc:error and everything else warning, I think maybe we can support them to use istioctl pc log --level all:warning,mis:error, with all:warning or warning in the front. Do you think this is ok? Thx. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#17339?email_source=notifications&email_token=AAEYGXPWMNPKMURQUFUS3YDQL3ARJA5CNFSM4IZ4637KYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCGHYCSQ#discussion_r329293620>, or mute the thread https://github.com/notifications/unsubscribe-auth/AAEYGXLHBEIB4PLLYTHYTMLQL3ARJANCNFSM4IZ4637A .

Thanks for the tips. I find it. Then I think there are still two jobs:

Get defaultOutputLevel from configmap istio-sidecar-injector;
Get all logger names by querying the target envoy.
Am I right?

@waret: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

unit-tests_istio
60e4a55e805b8db5e621ff0f95fe76e95e5eb43b
link
/test unit-tests

racetest_istio
60e4a55e805b8db5e621ff0f95fe76e95e5eb43b
link
/test racetest

codecov_istio
60e4a55e805b8db5e621ff0f95fe76e95e5eb43b
link
/test codecov

integ-mixer-k8s-tests_istio
60e4a55e805b8db5e621ff0f95fe76e95e5eb43b
link
/test integ-mixer-k8s-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@waret: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

racetest_istio
60e4a55e805b8db5e621ff0f95fe76e95e5eb43b
link
/test racetest

codecov_istio
60e4a55e805b8db5e621ff0f95fe76e95e5eb43b
link
/test codecov

integ-mixer-k8s-tests_istio
60e4a55e805b8db5e621ff0f95fe76e95e5eb43b
link
/test integ-mixer-k8s-tests

unit-tests_istio
5760654fc804fdd52951e42e2e87a221c97f6e3b
link
/test unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@waret: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

codecov_istio
60e4a55e805b8db5e621ff0f95fe76e95e5eb43b
link
/test codecov

integ-mixer-k8s-tests_istio
60e4a55e805b8db5e621ff0f95fe76e95e5eb43b
link
/test integ-mixer-k8s-tests

unit-tests_istio
5760654fc804fdd52951e42e2e87a221c97f6e3b
link
/test unit-tests

racetest_istio
5760654fc804fdd52951e42e2e87a221c97f6e3b
link
/test racetest

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@waret: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

integ-mixer-k8s-tests_istio
60e4a55e805b8db5e621ff0f95fe76e95e5eb43b
link
/test integ-mixer-k8s-tests

unit-tests_istio
5760654fc804fdd52951e42e2e87a221c97f6e3b
link
/test unit-tests

racetest_istio
5760654fc804fdd52951e42e2e87a221c97f6e3b
link
/test racetest

codecov_istio
5760654fc804fdd52951e42e2e87a221c97f6e3b
link
/test codecov

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@waret: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

unit-tests_istio
5760654fc804fdd52951e42e2e87a221c97f6e3b
link
/test unit-tests

racetest_istio
5760654fc804fdd52951e42e2e87a221c97f6e3b
link
/test racetest

codecov_istio
5760654fc804fdd52951e42e2e87a221c97f6e3b
link
/test codecov

lint_istio
027840534c700dd40f7f1e22d149338712935f20
link
/test lint

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@waret: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

integ-mixer-k8s-tests_istio
88a96f7e0d112f74e75a1363d8b910821ff4d569
link
/test integ-mixer-k8s-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest

@waret: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

integ-mixer-k8s-tests_istio
88a96f7e0d112f74e75a1363d8b910821ff4d569
link
/test integ-mixer-k8s-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@waret: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

integ-mixer-k8s-tests_istio
88a96f7e0d112f74e75a1363d8b910821ff4d569
link
/test integ-mixer-k8s-tests

lint_istio
bd2c4afe9b9033215943596ccd50a3720515318b
link
/test lint

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@waret: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

integ-mixer-k8s-tests_istio
88a96f7e0d112f74e75a1363d8b910821ff4d569
link
/test integ-mixer-k8s-tests

lint_istio
934f12f63e5e58635f61573297b9f624a28d859d
link
/test lint

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@waret: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

integ-mixer-k8s-tests_istio
88a96f7e0d112f74e75a1363d8b910821ff4d569
link
/test integ-mixer-k8s-tests

lint_istio
934f12f63e5e58635f61573297b9f624a28d859d
link
/test lint

racetest_istio
934f12f63e5e58635f61573297b9f624a28d859d
link
/test racetest

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@waret: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

integ-mixer-k8s-tests_istio
88a96f7e0d112f74e75a1363d8b910821ff4d569
link
/test integ-mixer-k8s-tests

unit-tests_istio
80d3df9312b635681cd734f677c4e2a5fba3bbc1
link
/test unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@waret: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

unit-tests_istio
80d3df9312b635681cd734f677c4e2a5fba3bbc1
link
/test unit-tests

integ-mixer-k8s-tests_istio
80d3df9312b635681cd734f677c4e2a5fba3bbc1
link
/test integ-mixer-k8s-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@waret: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

unit-tests_istio
80d3df9312b635681cd734f677c4e2a5fba3bbc1
link
/test unit-tests

integ-mixer-k8s-tests_istio
80d3df9312b635681cd734f677c4e2a5fba3bbc1
link
/test integ-mixer-k8s-tests

integ-security-k8s-tests_istio
80d3df9312b635681cd734f677c4e2a5fba3bbc1
link
/test integ-security-k8s-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


Fix clippy error in CI

Description
Quick fix CI error here.
Changes include:

Inlined all format args, see clippy hints here: e.g. format!("{:?}, error") -> format!("{error:?}") for better readability

reason why we didn't catch previously in CI or locally is because our CI is not running inside nix-shell, thus two CI runs might end up using different clippy and rust (based on upstream release), and there has been a new release 1.67.0 which add this clippy rule. No big deal.

temporarily use version = {workspace = true} instead of version.workspace = true syntax, due to https://github.com/DevinR528/cargo-sort/issues/47 (so that our precommit hook won't fail)

Post PR TODO:

[ ] re-tag 0.2.0

Thanks @alxiong ! There are still 2 clippy warnings in unchanged files. Could you help fix it? Thanks


Cannot create and upload drive files with names containing non-ASCII characters

Fluter 2.2
_discovery_commons 1.0.0
When using google drive v3 API to create request to create and upload a file to Drive storage:
driveApi.files.create(             drive.File()               ..name = fileName               ..parents = [dirId],             uploadMedia: drive.Media(myFile.openRead(), myFile.lengthSync()));
if the file name contains non-ASCII characters, an exception is thrown in multipart_media_uploader.dart: Future<http.StreamedResponse> upload().
The same happens if optional properties are used and they contain non-ASCII characters.
The reason is line 52:
 final bodyController = StreamController<List<int>>()       ..add(ascii.encode(bodyHead));
The exception is thrown because bodyHead contains filename, or other fields, containing non-ASCII characters.
Instead of ASCII encoding, we should use utf8 encoding and adjust the length calculation to account for that encoding:
`
final encodedBodyHead = utf8.encode(bodyHead);
final totalLength = encodedBodyHead.length +
    _lengthOfBase64Stream(_uploadMedia.length!) +
    bodyTail.length;

final bodyController = StreamController<List<int>>()
  ..add(encodedBodyHead);

`

Do a pub upgrade and you should be good~


Deploy issues, Code in file index.js can't be loaded.

[READ] Step 1: Are you in the right place?
I think so.
[REQUIRED] Step 2: Describe your environment

Operating System version: _____
Firebase SDK version: _____
Library version: firebase --version: 6.7.1
Firebase Product: _____ (auth, database, storage, etc)

[REQUIRED] Step 3: Describe the problem
Steps to reproduce:
English in not my mother language, I use google translate to describe my question.
Try to deploy cloud functions, getting syntax errors not in my code but in actions-on-google.
Deploy successful at morning but fail afternoon.
I think I didn't modify code.
Relevant Code:
=== Deploying to 'my_project_id'...

i  deploying database, functions, hosting
i  database: checking rules syntax...
+  database: rules syntax for database my_project_id is valid
i  functions: ensuring necessary APIs are enabled...
+  functions: all necessary APIs are enabled
i  functions: preparing functions directory for uploading...
i  functions: packaged functions (44.11 KB) for uploading
+  functions: functions folder uploaded successfully
i  hosting[my_project_id]: beginning deploy...
i  hosting[my_project_id]: found 4 files in public
+  hosting[my_project_id]: file upload complete
i  database: releasing rules...
+  database: rules for database my_project_id released successfully
i  functions: updating Node.js 6 function fakeauth(us-central1)...
i  functions: updating Node.js 6 function faketoken(us-central1)...
i  functions: updating Node.js 6 function smarthome(us-central1)...
i  functions: updating Node.js 6 function requestsync(us-central1)...
i  functions: updating Node.js 6 function reportstate(us-central1)...
!  functions[smarthome(us-central1)]: Deployment error.
Function failed on loading user code. Error message: Code in file index.js can't
 be loaded.
Is there a syntax error in your code?
Detailed stack trace: /user_code/node_modules/actions-on-google/node_modules/gax
ios/build/src/index.js:28
async function request(opts) {
      ^^^^^^^^

SyntaxError: Unexpected token function
    at createScript (vm.js:56:10)
    at Object.runInThisContext (vm.js:97:10)
    at Module._compile (module.js:549:28)
    at Object.Module._extensions..js (module.js:586:10)
    at Module.load (module.js:494:32)
    at tryModuleLoad (module.js:453:12)
    at Function.Module._load (module.js:445:3)
    at Module.require (module.js:504:17)
    at require (internal/module.js:20:19)
    at Object.<anonymous> (/user_code/node_modules/actions-on-google/node_module
s/gtoken/build/src/index.js:18:18)
!  functions[fakeauth(us-central1)]: Deployment error.
Function failed on loading user code. Error message: Code in file index.js can't
 be loaded.
Is there a syntax error in your code?
Detailed stack trace: /user_code/node_modules/actions-on-google/node_modules/gax
ios/build/src/index.js:28
async function request(opts) {
      ^^^^^^^^

SyntaxError: Unexpected token function
    at createScript (vm.js:56:10)
    at Object.runInThisContext (vm.js:97:10)
    at Module._compile (module.js:549:28)
    at Object.Module._extensions..js (module.js:586:10)
    at Module.load (module.js:494:32)
    at tryModuleLoad (module.js:453:12)
    at Function.Module._load (module.js:445:3)
    at Module.require (module.js:504:17)
    at require (internal/module.js:20:19)
    at Object.<anonymous> (/user_code/node_modules/actions-on-google/node_module
s/gtoken/build/src/index.js:18:18)
!  functions[reportstate(us-central1)]: Deployment error.
Function failed on loading user code. Error message: Code in file index.js can't
 be loaded.
Is there a syntax error in your code?
Detailed stack trace: /user_code/node_modules/actions-on-google/node_modules/gax
ios/build/src/index.js:28
async function request(opts) {
      ^^^^^^^^

SyntaxError: Unexpected token function
    at createScript (vm.js:56:10)
    at Object.runInThisContext (vm.js:97:10)
    at Module._compile (module.js:549:28)
    at Object.Module._extensions..js (module.js:586:10)
    at Module.load (module.js:494:32)
    at tryModuleLoad (module.js:453:12)
    at Function.Module._load (module.js:445:3)
    at Module.require (module.js:504:17)
    at require (internal/module.js:20:19)
    at Object.<anonymous> (/user_code/node_modules/actions-on-google/node_module
s/gtoken/build/src/index.js:18:18)
!  functions[requestsync(us-central1)]: Deployment error.
Function failed on loading user code. Error message: Code in file index.js can't
 be loaded.
Is there a syntax error in your code?
Detailed stack trace: /user_code/node_modules/actions-on-google/node_modules/gax
ios/build/src/index.js:28
async function request(opts) {
      ^^^^^^^^

SyntaxError: Unexpected token function
    at createScript (vm.js:56:10)
    at Object.runInThisContext (vm.js:97:10)
    at Module._compile (module.js:549:28)
    at Object.Module._extensions..js (module.js:586:10)
    at Module.load (module.js:494:32)
    at tryModuleLoad (module.js:453:12)
    at Function.Module._load (module.js:445:3)
    at Module.require (module.js:504:17)
    at require (internal/module.js:20:19)
    at Object.<anonymous> (/user_code/node_modules/actions-on-google/node_module
s/gtoken/build/src/index.js:18:18)
!  functions[faketoken(us-central1)]: Deployment error.
Function failed on loading user code. Error message: Code in file index.js can't
 be loaded.
Is there a syntax error in your code?
Detailed stack trace: /user_code/node_modules/actions-on-google/node_modules/gax
ios/build/src/index.js:28
async function request(opts) {
      ^^^^^^^^

SyntaxError: Unexpected token function
    at createScript (vm.js:56:10)
    at Object.runInThisContext (vm.js:97:10)
    at Module._compile (module.js:549:28)
    at Object.Module._extensions..js (module.js:586:10)
    at Module.load (module.js:494:32)
    at tryModuleLoad (module.js:453:12)
    at Function.Module._load (module.js:445:3)
    at Module.require (module.js:504:17)
    at require (internal/module.js:20:19)
    at Object.<anonymous> (/user_code/node_modules/actions-on-google/node_module
s/gtoken/build/src/index.js:18:18)

Functions deploy had errors with the following functions:
        fakeauth
        faketoken
        reportstate
        requestsync
        smarthome

To try redeploying those functions, run:
    firebase deploy --only functions:fakeauth,functions:faketoken,functions:repo
rtstate,functions:requestsync,functions:smarthome

To continue deploying other features (such as database), run:
    firebase deploy --except functions

my package.json:
{
  "name": "smarthome-washer",
  "description": "Codelab for controlling devices through the Google Assistant",
  "engines": {
    "node": "6"
  },
  "dependencies": {
    "actions-on-google": "2.6.0",
    "ajv": "^5.0.0",
    "cors": "^2.8.4",
    "firebase-admin": "^5.8.2",
    "firebase-functions": "^2.3.0",
    "googleapis": "^27.0.0"
  },
  "private": true,
  "devDependencies": {
    "eslint": "^4.19.1",
    "eslint-config-google": "^0.9.1"
  }
}

Myself as well faced the same issue, but I'm able to deploy to the cloud functions, and one of my function throwing the same error all the sudden, and it was working just fine before that.
ERROR
/user_code/node_modules/firebase-admin/node_modules/gaxios/build/src/index.js:28
async function request(opts) {
^^^^^^^^
SyntaxError: Unexpected token function

We managed to get around the issue for now by changing the node engine version in the package.json .
 "engines": {     "node": "8"   },

We managed to get around the issue by changing the node engine version in the package.json.
 "engines": {     "node": "8"   },

i  functions: updating Node.js 6 function fakeauth(us-central1)...
i  functions: updating Node.js 6 function faketoken(us-central1)...
i  functions: updating Node.js 6 function smarthome(us-central1)...
i  functions: updating Node.js 6 function requestsync(us-central1)...
i  functions: updating Node.js 6 function reportstate(us-central1)...

You're trying to use async/await syntax in Node 6. You have to use Node 8  for that. Solution suggested by @brettcallanan is correct.
Also note that Node 6 support is deprecated in Cloud Functions. Node 8 is the recommended runtime.


Tests for settings

Pull Request Test Coverage Report for Build 381940903

1 of 1 (100.0%)  changed or added relevant line in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+9.9%) to 62.292%

Totals

Change from base Build 379630450:
9.9%

Covered Lines:
183

Relevant Lines:
304

💛  - Coveralls


Fix etcd snapshots locations in S3

Etcd snapshots are now persisted with a s3 prefix "kube-aws/clusters//instances/<roo stack id/etcd-snapshots" rather than the former "kube-aws/clusters//exported/stacks/etcd-snapshots"
Closes #562

Codecov Report

Merging #590 into master will increase coverage by 0.07%.
The diff coverage is 89.47%.

@@            Coverage Diff             @@
##           master     #590      +/-   ##
==========================================
+ Coverage    37.7%   37.78%   +0.07%
==========================================
  Files          48       48
  Lines        3217     3221       +4
==========================================
+ Hits         1213     1217       +4
  Misses       1803     1803
  Partials      201      201

Impacted Files
Coverage Δ

core/controlplane/config/config.go
55.39% <100%> (ø)
:arrow_up:

core/controlplane/cluster/cluster.go
43.09% <50%> (-0.24%)
:arrow_down:

core/controlplane/config/stack_config.go
70.66% <93.33%> (+2.09%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c748850...cd3992b. Read the comment docs.


make blocksource trait async

In order to make the BlockSource trait compatible with wasm, it needed to be converted to an async trait. This requirement was identified while working in this PR: https://github.com/KomodoPlatform/atomicDEX-API/blob/4187ca90343d45d59343b77e7cab3781e90f6fc9/mm2src/coins/z_coin/storage/blockdb/blockdb_idb_storage.rs#L309-L318 . by doing this, the trait is able to be used effectively in wasm.
To ensure thread safety and enable the use of BlockSource in asynchronously manner, I modified both the BlockSource trait and the scan_cached_blocks function. Changes included allowing the scan_cached_blocks function to accept an Arc<Mutex<D>> parameter, which provided the necessary thread safety guarantees.

I have 3 concerns:
1- This effects whole implementations not only wasm.
2- For at least non-wasm targets, the execution flow was working in a lock-free way, but know there are a lot of threads/tasks spawning/blocking the execution flow. Which means more resource usage, less performance for the exactly same goal.
3- If we decide to stop maintaining this fork and move to stable upstream versions, this kind of changes will give us trouble because we are moving away from the original version.
Have you tried providing the compatibility on mm2 side for wasm?

I have 3 concerns:
1- This effects whole implementations not only wasm. 2- For at least non-wasm targets, the execution flow was working in a lock-free way, but know there are a lot of threads/tasks spawning/blocking the execution flow. Which means more resource usage, less performance for the exactly same goal. 3- If we decide to stop maintaining this fork and move to stable upstream versions, this kind of changes will give us trouble because we are moving away from the original version.
Have you tried providing the compatibility on mm2 side for wasm?

I understand your concerns and it seems I can make this work even without use Arc Mutex which then won't require locking etc.

Have you tried providing the compatibility on mm2 side for wasm?
Yes, tested and it works

@borngraced I think making with_blocks return a future can be a better solution that will make the changes very minimal, I already tried that, you can find the changes here https://github.com/KomodoPlatform/librustzcash/tree/with_blocks-fut
It would be even better to make the futures part an optional feature leaving the original code intact.


main.js code review

check for variables in lambdas
white spaces

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: gleissonmattos sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.


copy mode doesn't work

I was able to go to copy mode but the vim binding doesn't seem to work. I tried pressing 'v' in copy mode but it won't highlight the parts i want to copy. Also the top right box is stuck at 0/0.

Which version of tmux are you using?
I can see two reasons to your problem:

either you're using tmux HEAD in which they changed the way to configure bindings and I didn't updated this configuration yet
either before launching tmux, $VISUAL or $EDITOR is not set to vim

I did set $EDITOR to vim in ~/.bashrc. I'm using tmux 2.3.
I uncommented the lines and it works now. thank you.

Please read https://github.com/gpakosz/.tmux#enabling-the-powerline-look


TO: postinstall on new Centos 6.8 machine fails installing YAML

During postinstall,   I hit the error below.   Tracked down to a new dependency in the YAML perl module (Test::More) that isn't accounted for in the metadata.  This is not part of the carton (cpanfile) install,  it's done in .../install/bin/build_trafficops_perl_library.   Recommend adding cpan Test::More in that script prior to install of YAML.
Running make test
PERL_DL_NONLAZY=1 /usr/bin/perl "-MExtUtils::Command::MM" "-e" "test_harness(0, 'blib/lib', 'blib/arch')" t/*.t
t/000-compile-modules.t ... Can't locate Test/More.pm in @INC (@INC contains: /root/.cpan/build/YAML-1.17-Apkbir/blib/lib /root/.cpan/build/YAML-1.17-Apkbir/blib/arch /usr/local/lib64/perl5 /usr/local/share/perl5 /usr/lib64/perl5/vendor_perl /usr/share/perl5/vendor_perl /usr/lib64/perl5 /usr/share/perl5 .) at t/000-compile-modules.t line 2.

fix in hand..   testing it out now.

Fixed by #1585 on master and #1586 in 1.6.x


Add library linter rule to make sure every decorator in JS also has an extern declaration

Add to the library linter that a library can use to verify they are following the best practice when publishing a cadl library.

est: 5

Doing this now as we have too many decorators without and it makes it hard to do the valueof migration. Having the linter rule was easier than finding manually what was missing.


Cannot reach code.quarkus.io/api/extensions behind proxy

When there is a proxy server in the network, quarkus project cannot be created with the following notification message: Unable to reach http://code.quarkus.io/api/extensions.

@xorye do you think it's easy to fix that (I suppose we need to provide a new settings for that)

I'm having trouble reproducing this on my machine but we would probably have to change https://github.com/redhat-developer/vscode-quarkus/blob/f38f4caaf218cf9c6ce91e64a0d9cd632314a483/src/utils/requestUtils.ts#L68
Also, we need to be careful that there's no regression for https://github.com/redhat-developer/vscode-quarkus/pull/48. It would be great if we had vscode tests (not UI tests) for functions in https://github.com/redhat-developer/vscode-quarkus/blob/master/src/utils/requestUtils.ts

Any updates - I'm getting the same issue on vscode using redhat quarkus extension

@angelozerr Hi had suddenly that issue 2 days in the middle of a presentation, I'm not behind a proxy and I really struggle to fix. Even a reinstall of both vscode and the Quarkus extension did not help. Any idea ?

@sebastienblanc  thanks for reporting this issue. I can reproduce it and we need to investigate the problem. I suspect it's a SSL certificate problem.
It seems that it's the same issue than https://github.com/redhat-developer/vscode-quarkus/issues/401

@sebastienblanc could you try to use VSCode Insider with vscode-quarkus. It seems that it's a bug from vscode which should be fixed for next release. I tried (on Windows OS) and it works.

@angelozerr I still have the same issue, and it is neither fixed with VSCode 1.62.3, nor with 1.63.0-insider.
I'm not behind a proxy and I tried a newly installed VSCode and Quarkus Extension 1.9.0 on Windows 10.
When trying the default configured http://code.quarkus.io/api/extensions in browser, it redirects me to https and displays the JSON. Configuring https does not change anything.
How can I use the extension?

I'm having the same issue actually even using vscode insiders

Experiencing the same issue with version 1.64.2 of VS Code. Still not fixed!

Does the wizard fail immediately on activating it, on a particular step, or at the very end when all the options have been selected ?
I tried setting up a basic proxy with tinyproxy (http://localhost:8888) and I'm able to generate a Quarkus project with the wizard. Is there some publicly available proxy that could be used to test this out for which the behaviour is reproducible ?

@rgrunber Interestingly, now it works on my machine, I can go through the wizard and it generates a project.
Before, the wizard started and accepted input for build tool, artifact, ... but then failed at the step when selecting quarkus extensions would show.

I'm behind my company VPN and proxy and I have the same issue with VSCode version 1.92.2


Fix for cloud scheduler

It appears that the http-trigger requires request.get(force=True) according to https://stackoverflow.com/questions/53216177/http-triggering-cloud-function-with-cloud-scheduler

Thanks, could you add a comment linking to the Stack Overflow answer?

Thanks, could you add a comment linking to the Stack Overflow answer?

Sure. https://stackoverflow.com/questions/53216177/http-triggering-cloud-function-with-cloud-scheduler/60615210#60615210

I meant comment in the code :)

Like this?

yes, thanks!


try reverted transactions in tpool Update()

previously, transactions that were reverted did not get retried. Now every reverted transaction will be tried, oldest to newest, and if acceptTransactionSet succeeds, the reverted transaction will be added back to the pool.

Test ran too long on appveyor. At some point we should look into consolidating some of the longer tests. For now I guess switching to 15 minutes would be enough

I realized that this code is not actually correct. The tranasactions in the existing tpool and the sets in the existing tpool may depend on the transactions that got reverted from the blocks. That dependency is why we call purge() before figuring out which sets are still valid in the tpool.
You have to call purge() first, before you try to add the reverted transactions back into the tpool. I've gone ahead and fixed this up.

Except for any NDFs, I've cleaned this up and it should be ready for merge.


Add ClientInitialization usage for models

Clear and concise description of the problem
Right now getAllModels does not include models which have usage as none.  For the client initialization model the usage is none since it isn't used in any of the service operations.  We should introduce a new usage flag and apply it to the client initialization model so that it is returned by getAllModels.
Emitters who don't do anything with this model can easily ignore it by looking for this usage flag.
Checklist

[X] Follow our Code of Conduct
[X] Check that this issue is about the Azure libraries for typespec. For feature request in the typespec language or core libraries file it in the TypeSpec repo
[X] Read the docs.
[X] Check that there isn't already an issue that request the same feature to avoid creating a duplicate.

with this https://github.com/Azure/typespec-azure/pull/2027, tcgc deprecate the SdkInitializationType type and add SdkClientInitializationMethod. the options model should be language specific, so tcgc does not add that anymore.


Change node version ?

Is there a way to change the node version ?
I have install via npm n but I can not manage to change the node version.
Is there anyway you can do that since I can not bash into the image or ssh in ?

Hi!
I think the change to make this happen would be a bit complicated.
What's your use case? Do you just need a specific node version for a
project, or do you need to change node versions within a project that uses
Vessel?
On Mon, Dec 2, 2019 at 10:44 AM Daniel Gafitescu<EMAIL_ADDRESS>wrote:

Is there a way to change the node version ?
I have install via npm n but I can not manage to change the node version.
Is there anyway you can do that since I can not bash into the image or ssh
in ?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/shipping-docker/vessel/issues/128?email_source=notifications&email_token=AADSDU3766H72MPPRR4UKV3QWU3OBA5CNFSM4JTYVRHKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4H5KS3FQ,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AADSDU7SHVLU7UXJJFMXXJLQWU3OBANCNFSM4JTYVRHA
.

@fideloper there would be lots of reasons why a specific NPM or Node version is needed. there are quite a few libraries that aren't able to support the latest and greatest version right away, and plenty of legacy code out in the wild that still relies on some older versions, like node-sass and laravel-elixir


Switch ActionMailer to send via smtp to GMail, rather than directly from server.

Joe mentioned the verification emails getting stuck in people’s spam folders despite our burnished DMARC credentials.
I believe a good solution would be to send the emails out through GMail SMTP rather than directly from our own server. Although that sets up a technically unnecessary extra layer of routing, it will certainly certify the emails as valid, since Google owns the Internet.
I found this article about how to set up the config. The password, however, should be an “app password” which we would need to create in the GMail interface for<EMAIL_ADDRESS>More about Gmail "app passwords".
Maybe this is a good place to try our first use of Rails 6 credentials in production.

Coverage remained the same at 92.653% when pulling 3a852b4c022766809894128fb461d2d0a3c7cdf1 on nimmo-gmail-smtp into 19d20acb571d169e7299fb9aac8266c6b0d23cd6 on master.

What i did at Gmail/Google Workspace was

configure an SMTP relay at the workspace level, on admin.google.com . Private Gmail addresses don’t need to set up a relay, but workspace emails (like ours @mushroomobserver.org) do. Bonus: this allows us to potentially send to larger lists, although we should consult Gmail docs before doing, so we don’t get flagged by Google.)
activate 2FA for the webmaster@ account. 2FA is mandatory for an app password, and considering that i couldn’t get into the account anyway without being authorized by Nathan, it didn’t seem like much of a change. NOTE: you can add your own phone number as a verification method!
make an app password for webmaster@ (and news@ and no-reply@, just in case)
Notes:
The production ActionMailer config uses Rails 6 production-only credentials, with their own production.key (analagous to the master.key, that serves as a default for other environments). production.key currently exists only on the production server and on my local env - feel free to copy it locally. I chucked in some other credentials from consts-site.rb and gmaps_api into the encrypted production.yml.enc file, but am not using them anywhere, we can test them separately.
DKIM was correctly set up (by you!) for Gmail. The mystery we didn’t know was, in order to be usable by Ruby mail, we would have needed to add a DKIM gem and configure it, and possibly add a different, non-Google DKIM DNS record. (That’s because DKIM is a header added to all emails, that allows the recipient to check a key in the header against a TXT record on the domain DNS. Gmail's DKIM record seems to have a custom syntax.)
The Google tech said that even after this is merged and we’re sending via the SMTP relay, we probably still need to request removal from Hotmail’s blocklist.

Further notes:
AccountMailer now renamed ApplicationMailer,  re: Rubocop convention.
All mailer classes now renamed from *Email > *Mailer
To enable sending from two different smtp accounts, ApplicationMailer now loads two different SMTP configs from the production credentials, and these credentials are applied in each Mailer class via the after_action hook.
Production credentials are now to be found on the production server, under config/credentials. The production.key lives there too.
An entire hash of action_mailer.smtp_settings for each email account we send from, webmaster@ and news@, is now stored in the production credentials.

Fair enough.  Disregard my suggestion!
On Mon, Nov 7, 2022 at 7:59 PM Nathan Wilson @.***>
wrote:

@.**** commented on this pull request.
In .gitignore
https://github.com/MushroomObserver/mushroom-observer/pull/1174#discussion_r1016042189
:

@@ -33,3 +33,5 @@ coverage

Ignore master key for decrypting credentials and more.
/config/master.key
Also we should probably be running git secret in general and it would get
grumpy about that. Doesn't seem like a big deal to share around the
master.key outside of git as needed.
—
Reply to this email directly, view it on GitHub
https://github.com/MushroomObserver/mushroom-observer/pull/1174#discussion_r1016042189,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAYTNNO3U3GR6X7UOFBQJJLWHGQWFANCNFSM6AAAAAARGCS7VM
.
You are receiving this because you were mentioned.Message ID:
@.***
com>


DF Hotkeys: Allow default to be a static value, infer setting storage location, to HotkeySetting interface

While I feel like the current API for DF Hotkeys has a good balance between flexibility/power and simplicity, I feel that the current API could be slightly modified to cater to the most common use-cases.
Currently, the API requires function types for the get, set, and default members. I feel that, for 90% of use-cases, these fields are going to be something like this:
//  (stolen from the examples in the documentation)
hotkeys.registerShortcut({
	name: `${MODULE_SCOPE}.my-hotkey`,
	get: () => game.settings.get(MODULE_SCOPE, 'my-hotkey'),
	set: async (value: KeyMap) => await game.settings.set(MODULE_SCOPE, 'my-hotkey', value),
	default: () => { return { key: hotkeys.keys.KeyQ, alt: false, ctrl: false, shift: false }; },
	// ...
});

So, it would be convenient if the API optimized for the common use-case, and allowed something like:
hotkeys.registerShortcut({
	name: `${MODULE_SCOPE}.my-hotkey`,
	default: {
		key: hotkeys.keys.KeyQ,
		alt: false,
		ctrl: false,
		shift: false
	},
});

The library would default to using the name property to store and retrieve a setting for the hotkey in client-scoped settings, and allow a static value for the default property.
Some alternatives/idea:

Allow a 2-element array for name
Have a registerSettingBackedShortcut function (although the name is a tad long)

Yeah I initially was concerned about managing the settings myself, but it seems like something most people would likely prefer to save them hassle. I currently use a Settings helper that makes implementing this super simplistic, but certainly worth changing. I'll see if I can get this in with the next release, I'm going to be focusing on building a Shim for it that modules can include per the suggestion in #77


Add a replies table to store reply events

Currently we only store the reply ID in the NostrEvent table (which are basically the received events of Kind NIP_47_REQUEST) after publishing a reply. Now that we are using an SQLite DB with #217, it's best to add a table to store these reply events early on to avoid having to migrate later.
Additional reasons are also mentioned here: https://github.com/getAlby/nostr-wallet-connect/pull/230
This also helps us in multi_methods (https://github.com/getAlby/nostr-wallet-connect/pull/218) as there we don't just have one reply per NostrEvent but multiple.

@im-adithya we need to do this as part of https://github.com/getAlby/nostr-wallet-connect/pull/217 right? I will add a TODO there

Done here: https://github.com/getAlby/nostr-wallet-connect-next/pull/3


Add nonce support

Probably using https://npm.im/helmet like I do in my own website.

Hi Kent, could I try to help you on this?


R and RH oplocks can be granted for directories

This page needs updating - as per https://docs.microsoft.com/en-us/windows/win32/api/winioctl/ni-winioctl-fsctl_request_oplock, R and RH oplocks can now be granted on directories.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 1abb79eb-2db4-cbaa-0524-89acfe55c0f6
Version Independent ID: c08bc550-6b9d-1b87-8861-220b001340f8
Content: Granting Oplocks - Windows drivers
Content Source: windows-driver-docs-pr/ifs/granting-oplocks.md
Product: windows-hardware
Technology: ifs
GitHub Login: @lorihollasch
Microsoft Alias: loriwhip

Thanks for this issue, @maharmstone . I've removed the following sentence from the R and RH table sections: "If a directory, STATUS_INVALID_PARAMETER is returned."


Add fallbacks if providers.optimade.org is not available

I suggest the following order of determining a list of providers:

Request https://provider.optimade.org/v1/links
Request https://raw.githubusercontent.com/Materials-Consortia/providers/master/src/links/v1/providers.json
Use locally stored providers.json

Closed by #108


ngtests: test loading of cached metadata

Description of issue or feature request:
Taken from @jku's comment that summarizes it very well,  tests are needed which:

check that expected metadata is read from cache the expected number of times

wrapping open() should work fine here (see tests in #1593)

check if cached metadata is used to verify new metadata downloaded from remote

trickier but I suppose we can rely on negative tests here: tests that are expected to fail on that verification

Can I take this, please?

I think teodoras current approach of mocking open (in #1593) is pretty good: just implementing this in the relevant tests  is probably fine (so no test utilities needed).
The question is, which tests should test metadata file opens:

the test in #1593 should be extended so it checks files opened during refresh() as well
any other tests needed or is this one enough?

Maybe this single test is enough? @sechkova opinions?

What I imagined while writing the issue is potentially having a class that tests all weird cases of loading cached metadata. This would mean at least:
Step 1:  make a successful update of valid metadata which stores it in cache (by calling preferably Updater.get_targetinfo or in some special case Updater.refresh)
Step 2: Create a new updater and perform a second update while the metadata is already stored in cache (metadata dir)
Step 3:

test that a valid timestamp is loaded from cache (and is used to verify the new timestamp)
test that if a valid snapshot is loaded from cache a new snapshot is not downloaded
test that  if a valid targets is loaded from cache a new targets is not downloaded

Step 4:

test that an expired timestamp when loaded from cache is not stored as final but is used to verify the new timestamp
test that an expired snapshot when loaded from cache  is not stored as final but is used to verify the new downloaded snapshot
test that an expired targets when loaded from cache  is not stored as final but is used to verify the new downloaded targets

Step 5:

test that an invalid (incorrectly signed) timestamp when loaded from cache IS NOT used to verify the new timestamp
test that an invalid (incorrectly signed) snapshot when loaded from cache IS NOT used to verify the new timestamp
test that an invalid (incorrectly signed) targets when loaded from cache IS NOT used to verify the new targets

Step 3 can be based on the test in #1593 but I think a separate test case will be more clear. I haven't thought out well steps 4 and 5. Maybe start with 3 and re-scope the issue accordingly?

Forgot to mention that root as a special case should be already covered in test_updater_top_level_update.py but probably this claim should be confirmed.

oh yeah, validating that local metadata is actually used when downloaded metadata is verified (the second case in the description) is tricky. I think doing just the first case (validate that correct files are read from disk the correct number of times) is a good first step -- so that would be roughly steps 1-3 in your comment. I would argue it's mostly just augmenting the test function you wrote, but a new one is fine too

Which steps of the @sechkova comment should be tested to consider this issue closed?
If it is as @jku said - steps 1 to 3 do we want to create a separate issue for the rest?

What I imagined while writing the issue is potentially having a class that tests all weird cases of loading cached metadata. This would mean at least:
Step 1: make a successful update of valid metadata which stores it in cache (by calling preferably Updater.get_targetinfo or in some special case Updater.refresh)

@sechkova why it's preferable to call Updater.get_targetinfo  instead of directly calling refresh?
Maybe I am missing some context here.

@sechkova why it's preferable to call Updater.get_targetinfo  instead of directly calling refresh?
Maybe I am missing some context here.

Seems like I've had in mind refreshing both top-levels and delegated roles metadata when writing this. Updater.get_targetinfo calls refresh internally.

@sechkova why it's preferable to call Updater.get_targetinfo  instead of directly calling refresh?
Maybe I am missing some context here.

Seems like I've had in mind refreshing both top-levels and delegated roles metadata when writing this. Updater.get_targetinfo calls refresh internally.

As for steps 1, 2 and 4 implemented in https://github.com/theupdateframework/python-tuf/pull/1707 we need to test that only expired top-level roles have been used to verify metadata files, then I think we can just use refresh here.

test that an expired targets when loaded from cache  is not stored as final but is used to verify the new downloaded targets

Yes, I think I'm wrong in this sentence. Expired targets is always discarded, expired delegations too.

test that an expired targets when loaded from cache  is not stored as final but is used to verify the new downloaded targets

Yes, I think I'm wrong in this sentence, I edited the comment. Expired targets is always discarded, expired delegations too.

Looking at the code and testing it locally, if a local targets has expired we throw a ExpiredMetadataError https://github.com/theupdateframework/python-tuf/blob/bdf1cbbbb56839cd99b965fedae2661ed873c4a2/tuf/ngclient/_internal/trusted_metadata_set.py#L459
which inherits a RepositoryError and we will catch this exception in line 394 from here:
https://github.com/theupdateframework/python-tuf/blob/bdf1cbbbb56839cd99b965fedae2661ed873c4a2/tuf/ngclient/updater.py#L394.
Then, the update will continue and try to download and update the next version.
In conclusion: if a local targets has expired the update process won't stop, but it won't be verified and the update will continue.


Failed to activate the particle-dev-libraries package

[Enter steps to reproduce:]

...
...

Atom: 1.21.0 x64
Electron: 1.6.9
OS: Linux Mint
Thrown From: particle-dev-libraries package 0.2.23
Stack Trace
Failed to activate the particle-dev-libraries package
At ENOENT, node_modules/typescript/bin/lib.d.ts not found in /usr/share/atom/resources/app.asar

Error: ENOENT, node_modules/typescript/bin/lib.d.ts not found in /usr/share/atom/resources/app.asar
    at notFoundError (ELECTRON_ASAR.js:115:19)
    at Object.fs.readFileSync (ELECTRON_ASAR.js:514:9)
    at TypeScriptSimple.createService (/usr/share/atom/resources/app/node_modules/typescript-simple/index.js:71:73)
    at TypeScriptSimple.compile (/usr/share/atom/resources/app/node_modules/typescript-simple/index.js:60:43)
    at Object.exports.compile (/usr/share/atom/resources/app/src/typescript.js:54:53)
    at Object.compile (/usr/share/atom/resources/app/src/package-transpilation-registry.js:79:33)
    at compileFileAtPath (/usr/share/atom/resources/app/src/compile-cache.js:97:37)
    at Object.value [as .ts] (/usr/share/atom/resources/app/src/compile-cache.js:238:26)
    at Module.load (module.js:488:32)
    at tryModuleLoad (module.js:447:12)
    at Function.Module._load (module.js:439:3)
    at Module.require (/app.asar/static/index.js:47:45)
    at require (/usr/share/atom/resources/app/src/native-compile-cache.js:66:33)
    at /packages/particle-dev-libraries/lib/library_init.js:10:50)
    at /packages/particle-dev-libraries/lib/library_init.js:305:2)
    at Module.get_Module._compile (/usr/share/atom/resources/app/src/native-compile-cache.js:106:36)
    at Object.value [as .js] (/usr/share/atom/resources/app/src/compile-cache.js:239:29)
    at Module.load (module.js:488:32)
    at tryModuleLoad (module.js:447:12)
    at Function.Module._load (module.js:439:3)
    at Module.require (/app.asar/static/index.js:47:45)
    at require (/usr/share/atom/resources/app/src/native-compile-cache.js:66:33)
    at /packages/particle-dev-libraries/lib/index_loophole.js:8:58)
    at /packages/particle-dev-libraries/lib/index_loophole.js:60:11)
    at Module.get_Module._compile (/usr/share/atom/resources/app/src/native-compile-cache.js:106:36)
    at Object.value [as .js] (/usr/share/atom/resources/app/src/compile-cache.js:239:29)
    at Module.load (module.js:488:32)
    at tryModuleLoad (module.js:447:12)
    at Function.Module._load (module.js:439:3)
    at Module.require (/app.asar/static/index.js:47:45)
    at require (/usr/share/atom/resources/app/src/native-compile-cache.js:66:33)
    at /packages/particle-dev-libraries/lib/index.js:17:10
    at exports.allowUnsafeNewFunction (/packages/particle-dev-libraries/node_modules/loophole/lib/loophole.js:25:14)
    at Object.activate (/packages/particle-dev-libraries/lib/index.js:15:2)
    at Package.module.exports.Package.activateNow (/usr/share/atom/resources/app/src/package.js:253:25)
    at /usr/share/atom/resources/app/src/package.js:225:38
    at Package.module.exports.Package.measure (/usr/share/atom/resources/app/src/package.js:99:21)
    at /usr/share/atom/resources/app/src/package.js:218:32
    at Package.module.exports.Package.activate (/usr/share/atom/resources/app/src/package.js:215:40)
    at PackageManager.activatePackage (/usr/share/atom/resources/app/src/package-manager.js:690:42)
    at /packages/particle-dev-complete/node_modules/atom-package-deps/lib/index.js:37:35
    at Generator.next (<anonymous>)
    at step (/packages/particle-dev-complete/node_modules/atom-package-deps/lib/index.js:67:191)
    at /packages/particle-dev-complete/node_modules/atom-package-deps/lib/index.js:67:361

Commands
  2x -2:47.8.0 particle-dev:update-menu (atom-workspace.workspace.scrollbars-visible-always.theme-one-dark-syntax.theme-one-dark-ui)

Non-Core Packages
particle-dev 0.2.0
particle-dev-cloud-functions 0.2.0
particle-dev-cloud-variables 0.2.0
particle-dev-complete 1.0.2
particle-dev-libraries 0.2.23
particle-dev-profiles 0.2.3
tool-bar 1.1.0

Hi Patrick, this issue seems to be related to the Atom compile cache rather than Particle Dev Libraries. Could you try removing ~/.atom/compile-cache dir and restart Atom?

Hi.
I got the same error after installation of particle-dev package to the Atom.

[Enter steps to reproduce:]

Install package particle-dev
(Re)start Atom

Atom: 1.21.0 x64
Electron: 1.6.9
OS: Microsoft Windows 10 Pro
Thrown From: particle-dev-libraries package 0.2.23
Stack Trace
Failed to activate the particle-dev-libraries package
At ENOENT, node_modules\typescript\bin\lib.d.ts not found in C:\Users\Michal\AppData\Local\atom\app-1.21.0\resources\app.asar

Error: ENOENT, node_modules\typescript\bin\lib.d.ts not found in C:\Users\Michal\AppData\Local\atom\app-1.21.0\resources\app.asar
    at notFoundError (ELECTRON_ASAR.js:115:19)
    at Object.fs.readFileSync (ELECTRON_ASAR.js:514:9)
    at TypeScriptSimple.createService (~/AppData/Local/atom/app-1.21.0/resources/app/node_modules/typescript-simple/index.js:71:73)
    at TypeScriptSimple.compile (~/AppData/Local/atom/app-1.21.0/resources/app/node_modules/typescript-simple/index.js:60:43)
    at Object.exports.compile (~/AppData/Local/atom/app-1.21.0/resources/app/src/typescript.js:54:53)
    at Object.compile (~/AppData/Local/atom/app-1.21.0/resources/app/src/package-transpilation-registry.js:79:33)
    at compileFileAtPath (~/AppData/Local/atom/app-1.21.0/resources/app/src/compile-cache.js:97:37)
    at Object.value [as .ts] (~/AppData/Local/atom/app-1.21.0/resources/app/src/compile-cache.js:238:26)
    at Module.load (module.js:488:32)
    at tryModuleLoad (module.js:447:12)
    at Function.Module._load (module.js:439:3)
    at Module.require (/app.asar/static/index.js:47:45)
    at require (~/AppData/Local/atom/app-1.21.0/resources/app/src/native-compile-cache.js:66:33)
    at /packages/particle-dev-libraries/lib/library_init.js:10:50)
    at /packages/particle-dev-libraries/lib/library_init.js:305:2)
    at Module.get_Module._compile (~/AppData/Local/atom/app-1.21.0/resources/app/src/native-compile-cache.js:106:36)
    at Object.value [as .js] (~/AppData/Local/atom/app-1.21.0/resources/app/src/compile-cache.js:239:29)
    at Module.load (module.js:488:32)
    at tryModuleLoad (module.js:447:12)
    at Function.Module._load (module.js:439:3)
    at Module.require (/app.asar/static/index.js:47:45)
    at require (~/AppData/Local/atom/app-1.21.0/resources/app/src/native-compile-cache.js:66:33)
    at /packages/particle-dev-libraries/lib/index_loophole.js:8:58)
    at /packages/particle-dev-libraries/lib/index_loophole.js:60:11)
    at Module.get_Module._compile (~/AppData/Local/atom/app-1.21.0/resources/app/src/native-compile-cache.js:106:36)
    at Object.value [as .js] (~/AppData/Local/atom/app-1.21.0/resources/app/src/compile-cache.js:239:29)
    at Module.load (module.js:488:32)
    at tryModuleLoad (module.js:447:12)
    at Function.Module._load (module.js:439:3)
    at Module.require (/app.asar/static/index.js:47:45)

Commands

Non-Core Packages
language-ballerina 0.8.0
language-particle 0.3.5
particle-dev-cloud-functions 0.2.0
particle-dev-cloud-variables 0.2.0
particle-dev-complete 1.0.2
particle-dev-libraries 0.2.23
particle-dev-profiles 0.2.3
language-ballerina 0.8.0
tool-bar 1.1.0

This seems to be Windows specific error. We'll look into it!

I have the same error on Ubuntu 16.04 (or I have some dependencies not resolved).

@suda I tried your fix, deleted ~/.atom/compile-cache and restarted Atom but it didn't work. I'm running Linux Mint but I think the issue is cross platform here. Appreciate your help!

Same error on Ubuntu 17.04 using atom-0.6.2, definitely not just Windows affected.

Same error with Atom 1.21.2 on Windows 10 with fall creators update

Same error here, Ubuntu 17.10.
I reverted Atom to 1.20.1, seems to work fine there.

Yes, this seems to be a bug in Atom itself. The easiest solution for us would be to get rid of any TypeScript code in this package.

We just released v0.2.24 which should fix this issue. Can you confirm that it did?

particle-dev-libraries now installs without error for me

particle-dev-libraries now installs without error for me

worked for me as well, although i did have to disable Norton Security to get the installer to work


test summary behavior change with 6.15.0 release

👋 looks like 6.15.0 release has test summary behavior change as below (0 failed part got removed somehow and extra ) in the summary report)
- 2 requests processed (2 succeeded, 0 failed)
+ 2 requests processed (2 succeeded))

is that expected? Thankss!
relates to https://github.com/Homebrew/homebrew-core/pull/179991

Yes was expected. I added better  skipped and Errorerd Handling to cli. The summary got bloated. Now I only show the actual result status. I would recommend using Exit Code to get failed cli result. Is there a problem with the behavior?

it has two )) in the end, which seems a bit off, wdyt?

Ops. Yeah typo

thx

np, I saw it fixed now :)
https://github.com/Homebrew/homebrew-core/pull/182073


tmt run tries to run manual test cases (and fails)

Demonstration:
set -e

cd "$(mktemp -d)"

tmt init

cp path/to/tmt/examples/manual/* .

# optionally, add the following line to verify that the issue is not caused by
# having _only_ manual test cases
# echo '/auto: {manual: false, test: "echo hello from automated test"}' >>main.fmf

tmt run -avvv provision -h local

Output (redacted):
[...]
 errr /full
     output.txt: /var/tmp/tmt/run-076/plans/default/execute/data/full/output.txt
     content: /bin/sh: full.md: command not found

 errr /mini
     output.txt: /var/tmp/tmt/run-076/plans/default/execute/data/mini/output.txt
     content: /bin/sh: mini.md: command not found
summary: 2 errors

Shouldn't tmt somehow recognize the manual attribute and handle such tests differently
(or at least skip them)?
If not, I don't understand the purpose of the attribute (as documented).

Yes, manual tests should be skipped. Should be very easy to fix.


Please setNoDelay(true) on socket

After digging a weird bug, we found that Nodejs doc is wrong on Linux setNoDelay(), which is not use true by default.
At node_modules/nats/lib/nats.js Line 620, please add this.stream.setNoDelay(true)
    // Create the stream
    this.stream = net.createConnection(this.url.port, this.url.hostname);
    this.stream.setNoDelay(true)

also check this on nodejs issue 906

Did a quick test on a small cloud vm and found that performance indeed is a bit better on Linux. On other platforms (OS X) it actually is worse.
PUB
version           average   max   min   samples  rate
----------------  --------  ----  ----  -------  ----------------
1.0.0_tcpnodelay  1050.125  1079  1041  1000000  952,267 msgs/sec
1.0.0             1073.25   1103  1052  1000000  931,749 msgs/sec

PUBSUB
version           average            max   min   samples  rate
----------------  -----------------  ----  ----  -------  ----------------
1.0.0_tcpnodelay  1794.142857142857  1828  1762  1000000  557,369 msgs/sec
1.0.0             1843.375           1859  1818  1000000  542,483 msgs/sec

Actually did some testing.
var NATS = require('nats');
var nc = NATS.connect();

nc.on('connect', () => {
        var now = Date.now();
	nc.subscribe('foo', (m) => {
	  var end = Date.now() - now;
		console.log("took", end, "ms");
		process.exit(1);
	});
	nc.publish('foo');
});

I am getting about 1ms roundtrip without doing anything. Setting the setNoDelay(false), brings it to 38ms. So this must mean that at least on node 10, this value is set by default. Going to dig with more stats on different node versions.

These are runs in the same tiny machine at AWS using node 10 and 6.
off - setNoDelay(false)
on - setNoDelay(true)
or without setting it on or off.
version                    average  max   min   samples  rate
-------------------------  -------  ----  ----  -------  ----------------
1.0.0_tcpdelay_on_node10   1058.8   1076  1051  1000000  944,465 msgs/sec
1.0.0_node10               1076.7   1088  1067  1000000  928,763 msgs/sec
1.0.0_tcpdelay_off_node10  1079.2   1085  1072  1000000  926,612 msgs/sec
1.0.0_tcpdelay_off         1570.8   1681  1543  1000000  636,618 msgs/sec
1.0.0_tcpdelay_on          1572.8   1751  1530  1000000  635,808 msgs/sec
1.0.0                      1585.8   1613  1575  1000000  630,596 msgs/sec

PUBSUB
version                    average             max   min   samples  rate
-------------------------  ------------------  ----  ----  -------  ----------------
1.0.0_tcpdelay_on_node10   1789.4              1803  1778  1000000  558,846 msgs/sec
1.0.0_node10               1818.2              1855  1792  1000000  549,994 msgs/sec
1.0.0_tcpdelay_off_node10  1844.6              1925  1812  1000000  542,122 msgs/sec
1.0.0_tcpdelay_on          2270.3              2334  2229  1000000  440,470 msgs/sec
1.0.0_tcpdelay_off         2290.1              2339  2244  1000000  436,662 msgs/sec
1.0.0                      2297.1666666666665  2426  2223  1000000  435,318 msgs/sec

I am going to discuss this with the team.

Can you test it with Nodejs latest LTS v8.11.3 ?
We found this issue on version 8.11.x
Or expose a option noDelay  like preserveBuffers?

Still not seeing any significant change. As you know we do our own buffering of messages which reduces the number of syscalls we do and yields much better performance.
version                            average             max   min   samples  rate
---------------------------------  ------------------  ----  ----  -------  ----------------
1.0.0_noDelay_node_v10.6.0         1058.8              1076  1051  1000000  944,465 msgs/sec
1.0.0_node_v10.6.0                 1076.7              1088  1067  1000000  928,763 msgs/sec

1.0.0_noDelay_node_v8.11.3         1158.6              1258  1136  1000000  863,110 msgs/sec
1.0.0_node_v8.11.3                 1164.1              1184  1156  1000000  859,045 msgs/sec

1.0.0_remote_noDelay_node_v8.11.3  1346                1379  1294  1000000  742,942 msgs/sec
1.0.0_remote_node_v8.11.3          1308                1406  1248  1000000  764,525 msgs/sec

1.0.0_noDelay_node_v6.14.3         1572.8              1751  1530  1000000  635,808 msgs/sec
1.0.0_node_v6.14.3                 1585.8              1613  1575  1000000  630,596 msgs/sec

PUBSUB
version                            average             max   min   samples  rate
---------------------------------  ------------------  ----  ----  -------  ----------------
1.0.0_noDelay_node_v10.6.0         1789.4              1803  1778  1000000  558,846 msgs/sec
1.0.0_node_v10.6.0                 1844.6              1925  1812  1000000  542,122 msgs/sec

1.0.0_noDelay_node_v8.11.3         1867.8              1924  1854  1000000  535,389 msgs/sec
1.0.0_node_v8.11.3                 1871.5              1976  1851  1000000  534,330 msgs/sec

1.0.0_remote_noDelay_node_v8.11.3  1795.2              1864  1745  1000000  557,040 msgs/sec
1.0.0_remote_node_v8.11.3          1929.8              1978  1811  1000000  518,188 msgs/sec

1.0.0_noDelay_node_v6.14.3         2270.3              2334  2229 1000000 440,470 msgs/sec
1.0.0_node_v6.14.3                 2297.2              2426  2223 1000000 435,318 msgs/sec  ```

I think this issue is not about bench performance test.
Its about normal scenario sending two publish together, which lead latency.
Please check our issue here, 3 person test it with different platform, all result that Linux very slow.

The main issue is the number of system calls. The internal buffering takes care of that. The test should be simple:

Subscribe to an event. The handler records the time.
The 'connect' handler marks the start time and publishes an event.

The difference between the receive time and the start time is the latency, The way it is implemented, the first message will trigger the writing to the socket on the next event loop if the buffer is not full. Otherwise, the socket is written immediately. If publishing many events in a loop, the least number of system calls is used yielding greater throughput.
"use strict";

var fs = require('fs');
var NATS = require('nats');
var nc = NATS.connect();

var start;
nc.subscribe('foo', () => {
	var end = process.hrtime();
	var s = end[0] - start[0];
	var ns = end[1] - start[1];

	console.log(s*1000000 + ns/1000  + " µs");

	nc.close();
});

nc.on('connect', () => {
	start = process.hrtime();
	nc.publish("foo");
});


Indentation Lines extension making the block options background opaque

What is happening?
When indentation lines are enabled, the + and 6 dots options to the left of a block becomes opaque, the same colour as the theme background. Most noticeable when on top of coloured backgrounds.
I could not figure out any CSS to fix it, adding a transparent background simply overlays it on top of the existing opaque colour.
What should be happening?
The background should be transparent.
Screenshots (if applicable):
With indentation lines on:

With indentation lines off/unenhanced notion:

Operating system/browser name & version:
Windows 10 21H1
notion-enhancer and/or notion-repackaged version:
notion repackaged v0.11.0
notion-enhancer configuration (enabled/disabled mods and their settings):
indentation lines - all modes

this is intentional, otherwise the dots and lines overlap and can't be distinguished clearly.


Improve release note about RPM preinstall dependencies

What does this PR do?
Improves release note about RPM preinstall dependencies. This is backport of https://github.com/DataDog/datadog-agent/pull/11312 for 7.35.x.
Motivation

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

Reviewer's Checklist

[ ] If known, an appropriate milestone has been selected; otherwise the Triage milestone is set.
[ ] Use the major_change label if your change either has a major impact on the code base, is impacting multiple teams or is changing important well-established internals of the Agent. This label will be use during QA to make sure each team pay extra attention to the changed behavior. For any customer facing change use a releasenote.
[ ] A release note has been added or the changelog/no-changelog label has been applied.
[ ] Changed code has automated tests for its functionality.
[ ] Adequate QA/testing plan information is provided if the qa/skip-qa label is not applied.
[ ] At least one team/.. label has been applied, indicating the team(s) that should QA this change.
[ ] If applicable, docs team has been notified or an issue has been opened on the documentation repo.
[ ] If applicable, the need-change/operator and need-change/helm labels have been applied.
[ ] If applicable, the config template has been updated.

Since this is exactly the copy of https://github.com/DataDog/datadog-agent/pull/11312 which was already approved by the docs team, I'm merging this without waiting for their review.


logging: fix sentry proxy

Fixes a typo in sentry.py (app.extensions, not extension).

Signed-off-by: Sebastian Witowski<EMAIL_ADDRESS>

@switowski please rebase it for maint-2.0 and amend commit message headline. If you think it should be mentioned in RELEASE-NOTES add FIX label to your bullet point. Thanks

@jirikuncar done

@switowski please remove commits that are not yours

@jirikuncar I have fixed the copyright year


gapi authentication not working with Firebase token

I am trying to authenticate google drive API using a firebase authentication token using gapi.client.setToken(). But gapi not considering firebase token and giving Invalid Credentials error.
{
 "error": {
  "errors": [
   {
    "domain": "global",
    "reason": "authError",
    "message": "Invalid Credentials",
    "locationType": "header",
    "location": "Authorization"
   }
  ],
  "code": 401,
  "message": "Invalid Credentials"
 }
}

Complete code
const { email, stsTokenManager } = firestoreDatabase.auth().currentUser.toJSON();
const { accessToken } = stsTokenManager;

window.gapi.client
      .init({
        apiKey: config.apiKey,
        clientId: config.clientId,
        discoveryDocs: DISCOVERY_DOCS,
        scope: SCOPES,
        login_hint: email,
      })
      .then(async function () {
        const auth2 = window.gapi.auth2.getAuthInstance();

        if (auth2.isSignedIn.get()) {
          callback();
        } else {
          window.gapi.client.setToken({ access_token: accessToken })
        }
      });

Thanks for reaching out. This bug tracker is intended to report bugs in the Google API JavaScript Client. This looks like an issue with auth & firebase.
For support with those issues, please see https://developers.google.com/identity & https://firebase.google.com/. Firebase, for example, provides support in many ways. If you still need help, ask a question on Stack Overflow under the google-oauth and/or firebase tag.


Oracle Database 21c Premier Support update

Link to product page on endoflife.date
https://endoflife.date/oracle-database
Details of incorrect and correct details you have found
endoflife.date: 30 Apr 2024
Product documentation: Apr 2025 or  April 30, 2025
What is the source website for the product and for its version information?
https://www.oracle.com/us/support/library/lifetime-support-technology-069183.pdf
https://support.oracle.com/knowledge/Oracle Database Products/742060_1.html

Will be closed by #4485, thanks a lot @witchcraze !


[#72] Resolve templating bug and add unit tests to cover

Will close https://github.com/radian-software/el-patch/issues/72

Haha, well, the test appears to be failing because the example in the README does not work (maybe it never did?). Or at least when I evaluate it using el-patch-define-and-eval-template then it throws the same wrong-number-of-arguments error. I guess this is what I get for merging in features that I never tried myself.
I guess I'll have to track down the bug, or determine what is wrong in the sample usage. Maybe I can find examples from searching elsewhere on GitHub for people's Emacs configurations that use el-patch.

Aha: https://github.com/search?q="el-patch-define-template"&type=code


☂ Linter plugin configuration

Description
This issue tracks development of plugin configuration for the linter. This is merely about extending our configuration format and settings so that plugins can be configured. The actual loading or executing of plugins is considered out of scope here.
To see how this issue fits into our plugin efforts, please look at the overview here: https://github.com/biomejs/biome/issues/2463
How to Contribute
Everyone is welcome to contribute pieces here! If you'd like to tackle something, please leave a comment below this issue for which item(s) of the checklist below you'd like to pick up. We will create a separate issue and assign it to you to simplify tracking.

[!NOTE]
In order to have the issue assigned to you, you must comment on this issue.

Please only pick a single piece or group to work on at a time, and try to have time available to work on the piece when you select it so that we can keep progressing quickly. If you need any help or have any questions about our plugin efforts in Biome, feel free to ask in the #plugins channel in Discord.
Tasks

[ ] Add a linter.rulePlugins section to the configuration.

In a first iteration, this can probably be a single array of strings, each being the path to an individual plugin file.

[ ] Implement plugin resolution.

We probably want to use oxc_resolver so that package names can be used in place of direct paths to the plugins.

[ ] Extend configuration to include rule options.

We can probably take inspiration from how rule options are configured for built-in rules.
Keep in mind that the JSON schema cannot verify options for plugins, unlike built-in rules where we know the types.

Discussion

Do we want support for individual plugins that enable multiple rules? It seems unnecessary for a first release, but there might be advantages to supporting this. A downside would be the configuration would become more complex if we need to be able to enable/disable rules per plugin.

We should think about #689. Maybe we can work towards a unified proposal.

We should think about https://github.com/biomejs/biome/discussions/689. Maybe we can work towards a unified proposal.

A potential downside of unifying might be that it would be very hard for the schema to validate options for known rules. Not sure if there’s a clever way to avoid that?

I think plugins deserve a different section in our configuration.
Even though the discussion is about linting, I think we should force ourselves to see the big picture and the future.
What if a tomorrow someone will create a biome plugin for pug that parses, format and lints? I wouldn't expect users to fill three fields (parsing, formatting and lining) just to opt-in a plugin.
We envision just a field, and then Biome will enforce an interface to hook the different tools of the toolchain.

Even though the discussion is about linting, I think we should force ourselves to see the big picture and the future.
What if a tomorrow someone will create a biome plugin for pug that parses, format and lints? I wouldn't expect users to > fill three fields (parsing, formatting and lining) just to opt-in a plugin.

I can understand where you're coming from, but I'm not sure this is feasible in any near future. To create the kinds of plugins you're proposing means that our full CST structure would need to not only be accessible to plugins, but also able to be defined by plugins. If someone creates a plugin that defines a new language, how would any piece of strictly typed Rust code access the CST defined by that plugin? I have intentionally been trying to keep this out of scope for now, since frankly I don't see this happening within the next 2 years or more (in other words, at least one, but probably multiple major versions from now). If we try to design "everything plugins" from the start, I'm afraid we'll have such feature creep that we won't see the forest for the trees.

For now, we've settled on a top-level plugins field in the configuration. This is implemented, although the ability to pass options to plugins is not there yet.


Twemoji is not listed as one of the icon packs available for downloading

Only the 3 font-awesome and the one remix packs are listed.

That is correct. I may refactor the readme file. Right now, the Twemoji functionality is directly implemented and there is no need to download it.

Oh interesting. I followed the directions on my Mac and typed an emoji but got nothing as a result. Maybe I should have restarted Obsidian after installing the plugin.

On Mar 26, 2022, at 6:23 PM, Florian Woelki @.***> wrote:

That is correct. I may refactor the readme file. Right now, the Twemoji functionality is directly implemented and there is no need to download it.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.

Okay, restarting Obsidian did allow it to work correctly, but I agree that the README is confusing, in saying that it can be downloaded. I should know by now that Obsidian does not work correctly after installing a new plugin until it is restarted.

Okay, restarting Obsidian did allow it to work correctly, but I agree that the README is confusing, in saying that it can be downloaded. I should know by now that Obsidian does not work correctly after installing a new plugin until it is restarted.

Alright thank you for your feedback. I'll look into the problem with the restarting and change the readme.


Clarify Node version support policy for package, and test in all supported versions

Based on #3404, the four versions we support for the npm package are 8, 10, 11, and 12. Currently Node 8 is tested in our main build and Node 12 in main@node-latest. I added package-specific builds for 10 and 11.
We'll have to keep an eye on this as we fiddle with other builds. It could be easier if we added separate builds for each one, but having so many builds seems a bit unwieldy. Alternatively we could make a single build for the package, and use nvm or something like it to switch versions within that build.

Messages

:book:
:sparkles: Thanks for your contribution to Shields, @paulmelnikow!

:book:

Thanks for contributing to our documentation. We :heart: our documentarians!

  Generated by :no_entry_sign: dangerJS against 45ba20be13cc05a51654bd7314f127c97190a476

Happy to merge this as it is, but I think this in the long run it will be easier if the range of node versions we test against is explicitly defined as opposed to implicit.

Pretty much agreed with that.

FWIW, I don't see an issue with having an individual build for each node version.

My concern is that our build latency goes up even higher. (I think CircleCI gives us four simultaneous containers, which is why we often see "waiting behing your other queued builds".) Also scrolling through a long list in github is a bit harder.
Maybe we should attempt the nvm version?

if we can only run the package tests on all the node versions if the PR touches files in the gh-badges dir.

I'm not sure there's a way to do that in Circle without actually starting a container. Also the list of files might be hard to contain. There's the root package.json, package-lock.json, and anything else that might affect the test toolchain.

I think CircleCI gives us four simultaneous containers, which is why we often see "waiting behing your other queued builds"

I was wondering about this the other day too as it seems like the PR checks have been slower of late (although I know Circle had some platform issues recently too that may have been a factor). Do they offer any additional containers/benefits for OSS projects under any circumstances?
Also, should we look into seeing if we can skip the cypress binary download (or ensure it is cached with the other contents), outside the job that's running the e2e tests? It seems like the npm install step is often the longest step in those jobs (45-60 seconds), and I suspect that may be a factor

I'm not sure there's a way to do that in Circle without actually starting a container

I was thinking the same sort of thing as we do for the service tests, but you're right that initializing the container to decide whether to run the tests probably takes longer than running the tests in this case :D

Superseded by #3498.


Not working on SublimeLinter

I am currently working on a big upgrade to SublimeLinter.
Editing any file under the lint folder, e.g. lint/persist.py and then triggering reload via the command palette does not result in any reload of the respective file.
I assume this is not specific to the SublimeLinter package but a general shortcoming of Sublime Text, AutomaticPackageReloader or even the way python handles imports.

I cloned https://github.com/SublimeLinter/SublimeLinter3 and edited lint/persist.py.
AutomaticPackageReloader seems working to me.
[Package Reloader] begin ======================================================
reloading plugin SublimeLinter3.commands
[Package Reloader] reloading |-- SublimeLinter3
[Package Reloader] reloading |-- SublimeLinter3.commands
[Package Reloader] reloading | |-- SublimeLinter3.lint
[Package Reloader] reloading | | |-- SublimeLinter3.lint.highlight
[Package Reloader] reloading | | | |-- SublimeLinter3.lint.persist
[Package Reloader] reloading | | | | |-- SublimeLinter3.lint.util
[Package Reloader] reloading | | |-- SublimeLinter3.lint.linter
[Package Reloader] reloading | | |-- SublimeLinter3.lint.python_linter
[Package Reloader] reloading | | |-- SublimeLinter3.lint.ruby_linter
[Package Reloader] reloading | | |-- SublimeLinter3.lint.node_linter
[Package Reloader] reloading | | |-- SublimeLinter3.lint.composer_linter
reloading plugin SublimeLinter3.sublimelinter
[Package Reloader] reloading |-- SublimeLinter3.sublimelinter
[Package Reloader] reloading | |-- SublimeLinter3.lint.queue
SublimeLinter: debug mode: off
[Package Reloader] installing dummy package
reloading plugin _dummy_package
[Package Reloader] removing dummy package
unloading plugin _dummy_package
[Package Reloader] end --------------------------------------------------------

@randy3k Thanks for your fast response! Indeed I get the same output still the modification is not included.
You can just insert a print statement somewhere in linter.py to reproduce this error.
See whether the print output will appear in SublimeText's console after reloading then.
What other information would you require?

It prints as expected. What OS are you on?

I am on Linux Mint 18.x.
I'll see whether I can capture the behavior in an animated gif.

There is the print statement print("Old statement") in a new method of the class Linter in lint/linter.py. Below you can see the console pane open.
Statement is changed to print("New statement: Hello Randy!")
File is saved (see status bar message)
The command Automatic Package Reoader: Reload Current Package is called via command palette.
(See output in the console.)
The print statement remains unchanged.

Note this just an example. Any other changes to files in the lint subdir remain without effect before restarting Sublime Text, as well.

It is odd that Old Statement was printed after step 2. What was triggering the reload there?

The method is called from - and only from - get_view_settings.
But as I stated it does not matter where to put the print statement lint/linter.py will only update after a reload of ST itself.

I guess something is mysteriously reloading linter.py when it is modified. I said so because  "Old Statement" was printed after step 2.

@randy3k Some veterans on discord have been suggesting something along those same lines.
SublimeLinter is a complex beast.
So, as initially stated it might not necessarily be a bug in AutomaticPackageReloader.
If you do not have any clue what this may cause the issue or some handy work around, I can only
ask @braver or @groteworld (maintainers of SL) for any input on these matters.

It seems that SublimeLinter is handling the reloading to some extent. Perhaps, something in SublimeLinter is breaking the use of AutomaticPackageReloader.

I'd like to know how SublimeLinter's core devs are actually working.
I can not imagine I am the first one having this problem.
And I do not believe those guys are restarting ST for each modification they make.

Contributed linters have to import the SublimeLinter module to function. A restart may be necessarily in one want to see the effects of modifications on SublimeLinter to the linters.

Yeah, also, SL is old so most of it is maintenance and not like you’re overhauling the entire thing. Other than that I don’t think I’m in a position to tell you more about how reloading actually works here, any more than you already learned.

If @groteworld has nothing to contribute in this respect, we may close this issue.
I still wonder how anyone does development on the SublimeLinter package.