OIP-3: eWallet address format

Summary
Currently addresses are stored as UUID for wallets in the eWallet. This format is not really suited and was only meant as a temporary format. This OIP explores a few solutions to replace it with something more appropriate.
Specification
I'm not sure which one is best, but here are 7 formats that @unnawut and I came up with:
1. UUID
The first option is to keep it as is, but UUID are long, hard to type (including the dashes, and all the alphanumeric characters) and can't be copied with one click (which is something I'd like to see in the new format).
2. ULID
The second option is pretty simple: we use the same format used for every external ID in the eWallet. The format for addresses would look like adr_01ca2p8jqans5aty5gj5etmjcf.
Still hard to type for a user and a bit too long, also contains both letters and numbers.
3. xxxx_332493849383
Third option is using 16 characters (4 letters + 12 digits) to have a format that looks like abcd_111122223333 and could be shown to the user as abcd-1111-2222-3333 with 4 cases to fill (giving the same feeling as credit card, minus the 4 characters at the beginning).
Why use those 4 characters? To increase the potential number of addresses.
10^16 = 1E16 possibilities
4^26 * 10^16 = 4.56976E21 possibilities
4 characters are easy to remember and 12 digits is just two more than a phone number so with this, I believe anyone should be able to remember their address.
4. this-is-my-address-yo (or something-dirty... 👎  )
Another option is to use either an auto-generated "passphrase:" with 3 to 5 words that would be used as an address.
5. vvvv-mmmm-uuuu-uuu-c (3324-3239-8328-8438)
Credit card style, with digits for vendor identifier, user identifier, and check digit.
6. 324-3-234-1344
Bank account style (Thailand). What people are used to in Thailand.
More options?
If you guys have more ideas and think we should go with one of the format, let me know! I don't think there's a right answer, they all have their pros and cons, but let's try to find the best one for us!

Some considerations that I can think of that may influence the decision.

What are the consequences of a user entering an eWallet address incorrectly? In the crypto world, funds could be sent to an unspendable address.

Easier to type addresses have the tendency to have a lower global uniqueness. It becomes easier to accidentally type in someone else's valid address.

The two above points would be mostly
Option #3 + check digits is relatively good balance. Reminds me of https://en.wikipedia.org/wiki/International_Bank_Account_Number.
I think it's a great idea that @T-Dnzt mentioned where non-alphanumeric characters and whitespace could validly input by the user and subsequently stripped out.

@whoisjeremylam

If the address exists, the funds would be sent there. If it doesn't, the transaction would fails and no value would be sent. Adding a confirmation step where the owner of the receiving wallet is shown (either the receiving account name or the receiving user's username) could actually be done pretty easily right now to reduce the chance for wrong addresses (like bank transfers basically).

True! We need to find the right balance :)

I also like #3 and adding a check digit would be good (Just not sure how we can do it since we have letters there and the check digit on credit card is using calculations to generate it). Any idea? Only do it on the numeric part or use a different algorithm?

Was doing a little searching and the check digit calculation that IBAN uses is defined in ISO 7064.
We should be able to find our answer there!

I'm inclined towards these two:
1 .abcd_nnnnnnnnnnnn
Pros:

Supports even more addresses than credit card number format.
Allows a bit of playful UX help. E.g. ghub-1234-5678-9012, omgo-1234-5678-9012, appl-1234-5678-9012.

Cons:

Letters are harder to type than numbers (subjective).
Easier to abuse? Scammers could target by using 4-letter to misrepresent wallets of a large brand that they do not own?

2. vvvv-vvuu-uuuu-uuuc
Pros:

Numbers only. Numeric keyboard on mobile. Also easy typing with numpads.
General public are aware of this format and knows instantly it's to do with an account.

Cons:

Clash with credit card numbers. There are policies regarding storing, displaying and transmitting credit card numbers for those dealing with credit cards. This risks the confusion if it's a credit card number or a wallet address and probably will cause a lot of headache for all types of ewallet providers.
Confusion with credit cards anyway even without the policies/regulations.

Other considerations:

I'm assuming we will neglect non-alphanumeric characters so ewallet providers can format however they wish.

Do we need to fix the length? Can we make the length flexible and let each ewallet provider decides on their own? For example, omgo-1234-5678 might work for us, while others might want ghub-1234-5678-9012-3456 or more. Given that there's a check digit it's still possible to detect input completion without knowing the length.

Could this address format be future-proof? E.g. plan for digit expansion. Would we extend by prepending or appending? This might affect the check digit especially ISO 7064 that involves moving some digits from front to back as part of the check 😓.

Off-topic: For non-custodial wallets, i.e. the wallet has a blockchain address, this address format we're discussing could also be used as the alias to the blockchain address maybe? Given if the provider can provide provider address -> blockchain address discovery service for their users?

Nay:

UUID and ULIDs: They are hard to distinguish/comprehend visually, let alone input by hand. While it's great as record identifiers, I think we need something more user-friendly for wallet addresses that users will be interacting with them all the time.
Mnemonic phrases: I find them really slow to input and way too long to be used in user interfaces, both for displaying and inputting. They're okay as recovery phrases.
bbb-t-nnnnn-c Thai bank account format: I believe it's being obsoleted because of the limited space. And since our focus is not specifically Thailand, the credit card number variants are easily more superior.

If we want to go with numbers, might be worth revisiting how humans remember numbers

My preference would be Option 3 with check digits, but there are 2 considerations I'm trying to work out how to handle:
How are the addresses generated? If the addresses are generated at random, then that avoids the scam/abuse vector of people using the first 4 chars to claim to be someone they aren't, but it also means people can't legitimately use the 4 chars in a meaningful way either. If users are able to choose/request an address, how would that be maintained and managed in a public, trustless system?


fixed ImageBitmap memory leak

As helpfully noted by @deenns: https://github.com/mrdoob/three.js/issues/23953#issuecomment-1110742946, we had a memory leak due to GLTFLoader switching to ImageBitmap while we had not updated our dispose() method. That's done here, along with a package-lock update to pull in the latest three.js types.

Ugh, well I don't love merging things while our tests are timing out, but it's pretty clearly unrelated to our code changes, so I'm going to move on for now. Hopefully we get this BrowserStack stuff sorted soon.


weird xpath and wont autoclick.

Hi I just subscribe this extension and everything works fine. I just sometimes got xpath like this /html/body/main/div/div/button and it wont autoclick. But if I get soemthing like this //*[@id="activateLicenseButton"] it works perfectly. Any thoughts on /html/body/main/div/div/button ?

Yes. You can use //*[@id="activateLicenseButton"]
Please refer Wiki page for different Xpath)


Steamlit Text Box Covered by "Select RAG mode"

I just recently started exploring this project and I'm wondering if others have experienced the same issue as me:
On the support bot streamlit front end, the bottom text box where you type in your prompt is mostly covered by the RAG question. Anyone else experiencing this?

:hand: Same here. I haven't used Docker GenAI for a while, but I remember it showing up correctly at first.

Same for me!

Exactly the same for me — runing in ubuntu 22.04, tried both local firefox browser or NAT another chrome browser.

Ran into the same issue. Worked around the problem by giving the fixed position to the chatbox, instead of the "Select RAG  mode" pane. This is done by modifying the CSS style for Streamlit UI in bot.py file: 1) commenting out the "position: fixed" line for the '.element-container:has(aria-lable="Select RAG mode"' element, and 2) adding "position: fixed" line for the '.stChatFloatingInputContainer' element.
With these changes, the chatbox takes a fixed position at the bottom of the page, while the "Select RAG mode" pane becomes a floating element. So, the chatbox is no longer covered by the "Select RAG mode". This workaround allowed me to continue with the demo app successfully.
--- Streamlit UI style sheet modification in bot.py file ---
Streamlit UI
styl = f"""


Add a link setting

May I ask the author, can you add a function like privacy space, which can be associated with an application so that hidden applications can be seen?

Duplicate of #42


Pass JS BigInt to wire

Before, Dart BigInts would be passed directly to the wire without adjustment. However, with the latest wasm-bindgen release the behavior has changed and requires a proper JS BigInt.
Fixes #735.
Checklist

[x] An issue to be fixed by this PR is listed above.
[ ] New tests are added to ensure new features are working. End-to-end tests are usually in the ./frb_example/pure_dart example, more specifically, rust/src/api.rs and dart/lib/main.dart.
[x] The code generator is run and the code is formatted (e.g. via just refresh_all).
[ ] If this PR adds/changes features, documentations (in the ./book folder) are updated.
[x] CI is passing.

Remark for PR creator

New contributors will be blocked by GitHub from running CI, but you can use a trick to workaround this, and verify your code using CI by yourself.
If fzyzcjy does not reply for a few days, maybe he just did not see it, so please ping him.

Good job!


I use mac, and the file is written as _posts:0000-01-02-dmitrio03.md instead of _posts/0000-01-02-dmitrio03.md. This is because of a particular feature of my mac OS. I don't know how to get around this in the training material.


Language Pack Plugin - Wrong criteria used in language switcher limitation

Description:
I am not sure where to report this otherwise as using the account the plugin has no support, so I cannot report it and there is no option for that plugin here, so I am trying to do this this way.
In the language switcher the criteria uses the plugin name and checks for "English" or "Deutsch" to determine if the list NONE plugin installed languages.
That means any custom language created is not available in the language switcher once the plugin is installed, except if the are named English/Deutsch. The correct way would be to check if those languages have a related language pack entity associated with it which you do everywhere else in the admin interface.
Environment:
Steps to reproduce:

Install plugin
Create language "abc"
Check available languages in language selector.

Expected result:

"abc" to show up there.

Actual result:

"abc" does not show up.

[public] Shopware automated response: This issue is linked to the internal issue: LAN-57
[created from LAN-57, comment 514167]


tweak parseRootMargin util method

Description
This change to parseRootMargin in utils.js achieves few things:

provides default margin value, if omitted, instead of when falsy
type-checks rootMargin
trims the incoming string first, to handle strings like ' 0px' properly
caches the RegExp outside of function scope, not to create on every function call
uses destrucuting with default value to "simplify" handling shortcut

Motivation and context
I skimmed through the code and saw an opportunity for improvement

How has this been tested?
jest

Type of change

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] My code follows the code style of this project
[ ] My change requires a change to the documentation
[ ] I have updated the documentation accordingly
[x] I have read the CONTRIBUTING document
[x] I have added tests to cover my changes
[x] All new and existing tests passed

First off thanks for your proposal. I believe I'm lacking a bit of context for your changes.
Let me explain... The only purpose of this function is to obtain a 4-unit string for rootMargin whatever the entry is, so that we can compare it to the read-only prop of the IntersectionObserver instance and match it. Now, let's break it down to see what adds value here:

provides default margin value, if omitted, instead of when falsy

The argument can only ever be undefined or '' (the latter could be set by the user and bypass the propType validation). If we follow your change, the last case will throw an error.

type-checks rootMargin

Since we're validating rootMargin with PropTypes.string, it is not expected to be anything else.

trims the incoming stream first, to handle strings like 0px properly

Good, this is something that can prevent false positives. Plus, seems like in e.g.: Chrome only complains if it starts with a whitespace, but not in other cases, so this will help cover that too.

caches the RegExp outside of function scope, not to create on every function call

Good, it will help when creating a great number of <Observer /> elements within the same call stack.

uses destrucuting with default value to "simplify" handling shortcut

Good, since it helps reduce the size if you're using an es6-aware minifier. (We don't just yet).

The argument can only ever be undefined or '' (the latter could be set by the user and bypass the propType validation). If we follow your change, the last case will throw an error.

The current implementation of parseRootMargin will not always return 0px 0px 0px 0px for empty string:
parseRootMargin('');
> `0px 0px 0px 0px`

parseRootMargin(new String('')); // this will throw
> Error: rootMargin must be specified in pixels or percent
  ...

That's why I'd suggest throwing :)

Since we're validating rootMargin with PropTypes.string, it is not expected to be anything else.

Current approach is "loose" (will show PropTypes error, but will still work [fall back to '0px']) and will "parse" these values as 0px:

NaN
false
0 (number)
document.all
other falsy values?

Since this is not a helper method of the component itself, it's available "globally", so that's my reasoning behind "improving it".

Feel free do whatever you like with this PR, I'm fine with you cherry-picking the changes you like :)

You are right about these points, and I'm happy about the level of detail you provide.

Since this is not a helper method of the component itself, it's available "globally", so that's my reasoning behind "improving it".

It is a helper method for the Container, and it could potentially live there. Let me state again that it's only available globally because:

it's cleaner to have it in a separated file
exporting it allows for more granular testing

If you find a use case outside getPooled() I'd be happy to merge this PR as it is. Otherwise, this function is not intended to be standalone.
Throwing an error just for new String('') seems excessive, and if we expect devs ignoring propTypes for everything, we'd have to add a lot more checks throughout our codebases, increasing the bundle sizes. I'm fine with the code throwing on its own.
I'd gladly introduce your contribution when it comes to trimming and making the source more concise, would you be so kind as to leave those changes in?

I included your changes into a single commit: https://github.com/researchgate/react-intersection-observer/commit/8247f720cae25ed4778ec8b67139053515349643


Azure ServiceBus error - The format code '0x6E' at frame buffer offset '65772' is invalid or unexpected

Library name and version
azure-servicebus 7.12.3
Query/Question
We have our Azure ServiceBus streaming failing in the middle of data streaming process with the below error
azure.servicebus._pyamqp.error.AMQPLinkError: Error condition: amqp:decode-error
Error Description: The format code '0x6E' at frame buffer offset '65772' is invalid or unexpected.
When we worked with Microsoft, they suggested issue could be with payload but we haven't made any changes to payload. Only change we did is before we used to have 3 individual jobs streaming 3 types of data(All 3 are similar structure wise).
But since this is consuming 3X of RUs from our Cosmos, we merged all these 3 jobs into a single streaming job(Which now reads only once from Cosmos) which sends the data into 3 different ServiceBus topics
Issue behavior - Suppose if we have 10M data volume that needs to be sent into ServiceBus topics, this job which is failing runs for few hours, streams 4-6M and then fails with above error.
Any troubleshooting tips or experience with handling similar issue would be greatly appreciated
Environment
Azure ServiceBus

Hi @chandrakiranv ,
Would you be able to provide debug logs and a way to reproduce this error by following the steps below https://github.com/Azure/azure-sdk-for-python/tree/main/sdk/servicebus/azure-servicebus#troubleshooting
also as a mitigation for yall would you be able to downgrade to 7.12.2 while we try to resolve and troubleshoot?

Hi @kashifkhan
Yes we have observed this error after upgrading to the latest version of azure-servicebus but when we tested with the previous version also the same error is happening. I have attached the complete trace of the log related to this error
AMQP_error_Trace.txt
We have enabled the logging already as suggested above and the python version is 3.10.12

Hi @chandrakiranv ,
Given that this error is happening on both versions, I would lean towards something wrong with the body that is being sent across.

Would you be able to provide how your messages look?
From the attach stack track trace looks like there is more than just python involved and some combination of databricks + spark and a proxy of sorts ? Maybe some data is getting mangled in the mix and could be a databricks issue as well.
The attached stack trace is not what we are looking for. With logging set to DEBUG and logging_enabled set to True, the logs should look like the sample below
We would also like to see if there is a way to reproduce the issue on our end as that can help us narrow down the issue. The currently provided information is not enough to go further.

2024-09-24 15:30:20,214 | INFO | MainThread | azure.identity.aio._credentials.environment | No environment configuration found.
2024-09-24 15:30:20,215 | INFO | MainThread | azure.identity.aio._credentials.managed_identity | ManagedIdentityCredential will use IMDS
2024-09-24 15:30:20,636 | INFO | MainThread | azure.servicebus._pyamqp.aio._connection_async | Connection state changed: None -> <ConnectionState.START: 0>
2024-09-24 15:30:20,682 | DEBUG | MainThread | azure.servicebus._pyamqp.aio._connection_async | -> Header(b'AMQP\x00\x01\x00\x00')
2024-09-24 15:30:20,683 | INFO | MainThread | azure.servicebus._pyamqp.aio._connection_async | Connection state changed: <ConnectionState.START: 0> -> <ConnectionState.HDR_SENT: 2>
2024-09-24 15:30:20,684 | INFO | MainThread | azure.servicebus._pyamqp.aio._connection_async | Connection state changed: <ConnectionState.HDR_SENT: 2> -> <ConnectionState.HDR_SENT: 2>
2024-09-24 15:30:20,684 | DEBUG | MainThread | azure.servicebus._pyamqp.aio._connection_async | -> OpenFrame(container_id='SBSender-836965da-e1f0-4b0f-b376-0a8724f439b0', hostname='kashifksbprem.servicebus.windows.net', max_frame_size=1048576, channel_max=65535, idle_timeout=None, outgoing_locales=None, incoming_locales=None, offered_capabilities=None, desired_capabilities=None, properties={'product': 'azsdk-python-servicebus', 'version': '7.12.3', 'framework': 'Python/3.8.20', 'platform': 'Linux-<IP_ADDRESS>-microsoft-standard-WSL2-x86_64-with-glibc2.35', 'user-agent': 'azsdk-python-servicebus/7.12.3 pyamqp/2.0.0a1 Python/3.8.20 (Linux-<IP_ADDRESS>-microsoft-standard-WSL2-x86_64-with-glibc2.35)'})
2024-09-24 15:30:20,685 | INFO | MainThread | azure.servicebus._pyamqp.aio._connection_async | Connection state changed: <ConnectionState.HDR_SENT: 2> -> <ConnectionState.OPEN_PIPE: 4>
2024-09-24 15:30:20,686 | DEBUG | MainThread | azure.servicebus._pyamqp.aio._session_async | -> BeginFrame(remote_channel=None, next_outgoing_id=0, incoming_window=65536, outgoing_window=65536, handle_max=4294967295, offered_capabilities=None, desired_capabilities=None, properties=None)
2024-09-24 15:30:20,705 | INFO | MainThread | azure.servicebus._pyamqp.aio._session_async | Session state changed: <SessionState.UNMAPPED: 0> -> <SessionState.BEGIN_SENT: 1>
2024-09-24 15:30:20,705 | DEBUG | MainThread | azure.servicebus._pyamqp.aio._link_async | -> AttachFrame(name='0e4daa4f-abf5-41f6-a397-6caf80113aa6', handle=2, role=True, send_settle_mode=0, rcv_settle_mode=0, source=Source(address='$cbs', durable=None, expiry_policy=None, timeout=None, dynamic=None, dynamic_node_properties=None, distribution_mode=None, filters=None, default_outcome=None, outcomes=None, capabilities=None), target=Target(address='$cbs', durable=None, expiry_policy=None, timeout=None, dynamic=None, dynamic_node_properties=None, capabilities=None), unsettled=None, incomplete_unsettled=None, initial_delivery_count=None, max_message_size=None, offered_capabilities=None, desired_capabilities=None, properties=None)
2024-09-24 15:30:20,706 | INFO | MainThread | azure.servicebus._pyamqp.aio._link_async | Link state changed: <LinkState.DETACHED: 0> -> <LinkState.ATTACH_SENT: 1>
2024-09-24 15:30:20,706 | INFO | MainThread | azure.servicebus._pyamqp.aio._management_link_async | Management link receiver state changed: <LinkState.DETACHED: 0> -> <LinkState.ATTACH_SENT: 1>
2024-09-24 15:30:20,706 | DEBUG | MainThread | azure.servicebus._pyamqp.aio._link_async | -> AttachFrame(name='c91f4eda-758c-4cd5-86d6-c9c0c0a9e9ac', handle=1, role=False, send_settle_mode=0, rcv_settle_mode=0, source=Source(address='$cbs', durable=None, expiry_policy=None, timeout=None, dynamic=None, dynamic_node_properties=None, distribution_mode=None, filters=None, default_outcome=None, outcomes=None, capabilities=None), target=Target(address='$cbs', durable=None, expiry_policy=None, timeout=None, dynamic=None, dynamic_node_properties=None, capabilities=None), unsettled=None, incomplete_unsettled=None, initial_delivery_count=0, max_message_size=None, offered_capabilities=None, desired_capabilities=None, properties=None)
2024-09-24 15:30:20,707 | INFO | MainThread | azure.servicebus._pyamqp.aio._link_async | Link state changed: <LinkState.DETACHED: 0> -> <LinkState.ATTACH_SENT: 1>
2024-09-24 15:30:20,707 | INFO | MainThread | azure.servicebus._pyamqp.aio._management_link_async | Management link sender state changed: <LinkState.DETACHED: 0> -> <LinkState.ATTACH_SENT: 1>
2024-09-24 15:30:20,707 | DEBUG | MainThread | azure.servicebus._pyamqp.aio._connection_async | <- Header(b'AMQP\x00\x01\x00\x00')
2024-09-24 15:30:20,708 | INFO | MainThread | azure.servicebus._pyamqp.aio._connection_async | Connection state changed: <ConnectionState.OPEN_PIPE: 4> -> <ConnectionState.OPEN_SENT: 7>
2024-09-24 15:30:20,758 | DEBUG | MainThread | azure.servicebus._pyamqp.aio._connection_async | <- OpenFrame(container_id=b'be7bbb10e6164151aee6141b1ffcf95c_G34', hostname=None, max_frame_size=65536, channel_max=4999, idle_timeout=120000, outgoing_locales=None, incoming_locales=None, offered_capabilities=None, desired_capabilities=None, properties=None)
2024-09-24 15:30:20,759 | INFO | MainThread | azure.servicebus._pyamqp.aio._connection_async | Connection state changed: <ConnectionState.OPEN_SENT: 7> -> <ConnectionState.OPENED: 9>
2024-09-24 15:30:20,810 | DEBUG | MainThread | azure.servicebus._pyamqp.aio._session_async | <- BeginFrame(remote_channel=1, next_outgoing_id=1, incoming_window=5000, outgoing_window=65536, handle_max=255, offered_capabilities=None, desired_capabilities=None, properties=None)
2024-09-24 15:30:20,810 | INFO | MainThread | azure.servicebus._pyamqp.aio._session_async | Session state changed: <SessionState.BEGIN_SENT: 1> -> <SessionState.MAPPED: 3>

Steps to enable debug logging and frame level logging

Set logger to DEBUG for azure
pass in logging_enable=True kwarg in to constructor

import logging
import sys

handler = logging.StreamHandler(stream=sys.stdout)
logger = logging.getLogger('azure.servicebus')
logger.setLevel(logging.DEBUG)
logger.addHandler(handler)

...

from azure.servicebus import ServiceBusClient

client = ServiceBusClient(..., logging_enable=True)

Hi @kashifkhan
The reason we believe there is no issue with the body is we tested the same data with our old jobs and it processed the messages into ServiceBus topic without any issues.
We have enabled the logging and looking into our Log Analytics and Dynatrace logs to see if anything is captured through the ServiceBus logger when the error happened.


Project doesn't work with yarn + doesn't render anything when using NPM either

System
This is my system:

Yarn
When I do yarn install then do yarn api I get this error:
yarn api
yarn run v1.22.17
$ json-server --host <IP_ADDRESS> --port 6060 --watch json-server/db.json --routes json-server/routes.json
error An unexpected error occurred: "spawn E2BIG".
info If you think this is a bug, please open a bug report with the information provided in "/Users/arshankhanifar/spa_react_javascript_hello-world_react-router-6/yarn-error.log".
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

when I run yarn start I also get something similar:
(base) ➜  spa_react_javascript_hello-world_react-router-6 git:(main) ✗ yarn start
yarn run v1.22.17
$ cross-env PORT=4040 react-scripts start
error An unexpected error occurred: "spawn E2BIG".
info If you think this is a bug, please open a bug report with the information provided in "/Users/arshankhanifar/spa_react_javascript_hello-world_react-router-6/yarn-error.log".
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

Trying NPM
I deleted everything and reinstalled with npm, and this is what I see:
(base) ➜  spa_react_javascript_hello-world_react-router-6 git:(main) ✗ npm run api

><EMAIL_ADDRESS>api
> json-server --host <IP_ADDRESS> --port 6060 --watch json-server/db.json --routes json-server/routes.json

  \{^_^}/ hi!

  Loading json-server/db.json
  Loading json-server/routes.json
  Done

  Resources
  http://<IP_ADDRESS>:6060/api-messages-public
  http://<IP_ADDRESS>:6060/api-messages-protected
  http://<IP_ADDRESS>:6060/api-messages-admin

  Other routes
  /api/messages/public -> /api-messages-public
  /api/messages/protected -> /api-messages-protected
  /api/messages/admin -> /api-messages-admin

  Home
  http://<IP_ADDRESS>:6060

  Type s + enter at any time to create a snapshot of the database
  Watching...

And on the react-server side:
You can now view spa_react_javascript_hello-world_react-router-6 in the browser.

  Local:            http://localhost:4040
  On Your Network:  http://<IP_ADDRESS>:4040

Note that the development build is not optimized.
To create a production build, use npm run build.

webpack compiled successfully

Looks like the json-webserver is running and react-server is also running, but I don't see anything when firing up the browser:

Here's what the inspector window shows:

Too strict build-script rules
Debugging this became really hard because you've enforced prettier rules on every run of the react compiler. Is that really necessary for a code sample? I feel like it adds friction to the developers experimenting if anything.

I also get a black screen

Hello @ArshanKhanifar, welcome to the Auth0 Developer Center Resources.
You should use npm instead of yarn to run this code sample application.
Thanks for sharing your feedback. We've updated the code sample to remove the prettier rules to avoid just what you've mentioned.
The issue of a black screen that you're having could be because the environment variables that the application needs to run are not present. /cc @rgupta33
I invite you to take a look at the [React code sample page]("React/JavaScript + React Router 6 Code Sample: User Authentication For Basic Apps") on Developer Center Resources, which has detailed instructions on how to run this application.
Please let us know if this works well for you or if you need further assistance. We’re happy to help.

I got the black/blank screen fixed on my local:
• added .env by following the instructions here
• npm install
• npm start

Thank you @e10a!


remove discord channel

I’ve never been there either

I'm going to merge this; we can always revert if needed.


Chat -Auth GetAccountIDsByEmails returned an error message displayed in default workspace room

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Create a new workspace
Go to the default workspace room

Expected Result:
Default workspace room displayed without any error message
Actual Result:
"Auth GetAccountIDsByEmails returned an error" message displayed
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android / native
[ ] Android / Chrome
[ ] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[ ] MacOS / Desktop

Version Number: .3.45-5
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

https://github.com/Expensify/App/assets/93399543/920a7959-f34e-4877-9e13-db50974c7f0e
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
View all open jobs on GitHub

:wave: Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

Identify the pull request that introduced this issue and revert it.
Find someone who can quickly fix the issue.
Fix the issue yourself.

what Assignees mean ?will they only get a job

PR is in review https://github.com/Expensify/Web-Expensify/pull/38313

PR is deployed to prod!


[OSPRH-6400] Rename ceilometer proxy image

This is a part of a change to include the ceilometer proxy image into openstack-operator version. The rename makes it more consistent with other images, which also prepend the service name before the image.
rh-jira: https://issues.redhat.com/browse/OSPRH-6400

/lgtm


Async buffering can cause state reverts in rare circumstances

Async buffering is an API nicety, but the timing issues it causes aren't worth the hassle.
Right now if two changes can squeeze in rapid succession before a setTimeout(..., 0) can fire, then dendriform may push out an update that is stale compared to any state hooks that are tracking the same data in real time. This isn't the worst thing but can cause unavoidable cursor jumping if values are bound onto text inputs, and maybe worse.
Proposed solution

Make .set() not async by removing the setTimeout()
Add a batch() and flush() methods, and If someone wants to call 2 set() in a row they must call batch() first and finish with flush(). In dev mode we can warn if 2 sets get called too fast (less than setImmediate), and if flush isn't called fast enough (more than setImmediate)
Confirm all the deriving still works

Fixed in prerelease 2.0.0 alpha 3


Added reactive_file_selector package based on file_selector

file selector: https://pub.dev/packages/file_selector
I have also provided a common min/max validator
e.g.: FileSelectorValidators.limit(min: 1, max: 10)

cc @vasilich6107

I also forgot to add it to the readme

well, the package is still fairly new and doesn't even work on android yet, also still have some bugs.
but it's the "official" flutter package for picking files


Fix typo in config-override.exs

It needs to import Config, not config.

Already got merged via another pull request, closing.


Update license like Qiskit Terra

Summary
Update license like Qiskit Terra.

No license reference in the readme any more? We had it there so if you came into the readme you got a top level overview including licensing. Currently the software here is under a single license so maybe its fine. In aqua-chemistry there are files supplied, in the drivers, that are under other licensing and the readme calls this out specifically in the equivalent licensing section. In this regard the aqua and aqua-chemistry readmes were identical in having the licensing explicitly listed in them although of course aqua licensing is simpler in this regard.

@woodsp-ibm the explication by Diego, Chris & Jay here: https://github.com/Qiskit/qiskit-terra/pull/660#pullrequestreview-137945428

Sure I get explanation. I was pointing out that such implicit licensing will not apply aqua-chemistry. Maybe that will need to keep the link and then just be different from aqua readme. Maybe in aqua-chemistry it can become additional licensing when that gets changed (I assume you will be changing that shortly for its .github files etc)

Got it!
As you have assumed, yes, the idea is to homogenize the projects as much as possible.
For Qiskit Aqua Chemistry we can add a specific section about external/dependencies licenses.


Cannot find module '../../AppSync.js'

Hello,
The default file name used by the AWS console is AppSync.json.
In addition to changing line 3 of appsync.service.ts to
import appSyncConfig from '../../AppSync.json';
One needs to declare *.json modules in typings.d.ts
declare module "*.json" {
  const content: any;
  export default content;
}

make sure you select the Web tab to download the AppSync.js file

You're right. My bad.

Does Web not exist anymore? Looks like it's just iOS, Android and JavaScript.


Missing meeting updates and youtube links

The meetings page hasn't been updated with slides or relevant youtube videos. There's no designation between the NFT group and the Metadata subgroup either. There are 9 videos but only reference to 6 calls on the website.

@ericaconnell Let's figure out what we need to do to update this.

I see the Dec 10th meeting notes were updated but the subgroup summaries are still missing, right?

@okwme The summaries are in the repo (including a new update from our last call), but they aren't propagating through the CI/CD system. @deepanshutr  Do you know how to get the build & deploy triggered?

The build could be triggered through the actions tab on the repo. But yes the changes seem to not have propagated to the production website. @snj33v if you can pl have a look at the config and update if req.

The Build was failing because of missing  closing tags. Fixed in https://github.com/interNFT/documentation/pull/26. Added build checks on raising PR.

Slides and meeting video links still to be added.


Monitor Configuration (dual) not saved between logins

Lumina 0.9.0-Release
PC-BSD 10.3-RELEASE-p5 amd64 GENERIC on an Optiplex-9010 with twin Dell P2312H monitors
Right click on desktop -> Preferences -> Display gives "Monitor Configuration" dialog.
Initially the Add Screen tab is active, and allows "Enable Screen" to add the second available monitor to the right of the other one. "Apply Settings" allows expected behavior: mouse pointer can move off on screen, and over to the other monitor.
If I log out, then log back in, the original duplicated display configuration returns. Should there be a "Save Changes" button at the bottom of this dialog, as there is with the "Lumina Settings" one (Preferences -> Desktop)? It seems l recall having to explicitly push a save button somewhere, when I did that in KDE, also. What was/is the config file that button on the front-end modifies?

This is most likely caused by running the wrong binary to start your desktop.
You should be using the "start-lumina-desktop" binary, not the "Lumina-DE" binary, since the monitor reset routine is run at the beginning of the "start-lumina-desktop" routine.

So I should then file this bug with PC-BSD?
I didn't choose the binary. This is what got used/configured after installed the Lumina package via AppCafe, and I select Lumina from the login window desktop environment option.

Which version of PC-BSD?  There was an old .desktop file for Lumina that came bundled with PCDM which would use the "Lumina-DE" binary instead, but you should have a pkg for Lumina 0.9.1 in the repository instead of 0.9.0 which completely removed the "Lumina-DE" binary - invalidating that old .desktop overlay file. The 0.9.0 bug only impacted PC-BSD for a short while since 0.9.1 pkgs got rolled fairly quickly after that to fix this exact issue on PC-BSD/other OS's.

BTW: You could always delete that old overlay file from the system manually to ensure it uses the right one ("/usr/local/share/xsessions/02Lumina.desktop" or something like that). That should fix it instantly for you.

"Which version of PC-BSD?"
Please read the second line, of the first comment.
I accept all the package and system updates pushed for my PC-BSD system. "Lumina 0.9.0_3,1" is the one shown in my AppCafe. So that version is among presumed stable packages, despite not really being sufficiently usable (I just noticed I can't delete desktop shortcuts, also)?
Maybe I should track a more development build branch/package repo, if I wish to help test this experimental DE?

"Lumina-DE" is in my "/usr/local/share/xsessions/02Lumina.desktop". I can delete that file, but I thought I'd try and see if the updated package (0.9.1) would come if I installed via CLI. So I (from KDE) uninstalled Lumina via AppCafe. Then . . .
'''
pkg install lumina
Updating pcbsd-major repository catalogue...
pcbsd-major repository is up-to-date.
All repositories are up-to-date.
Checking integrity... done (0 conflicting)
The following 17 package(s) will be affected (of 0 checked):
New packages to be INSTALLED:
lumina: 0.9.0_3,1
qt5-multimedia: 5.5.1_1
xcompmgr: 1.1.7
gstreamer1-plugins-core: 1.4.0
gstreamer1-plugins-a52dec: 1.8.0
gstreamer1-plugins-ugly: 1.8.0
gstreamer1-plugins-dts: 1.8.0
gstreamer1-plugins-pango: 1.8.0
gstreamer1-libav: 1.8.0
gstreamer1-plugins-theora: 1.8.0
gstreamer1-plugins-dvdread: 1.8.0
gstreamer1-plugins-resindvd: 1.8.0
gstreamer1-plugins-png: 1.8.0
gstreamer1-plugins-vorbis: 1.8.0
gstreamer1-plugins-ogg: 1.8.0
gstreamer1-plugins-mad: 1.8.0
qt5-imageformats: 5.5.1_1
The process will require 31 MiB more space.
. . .
'''
So apparently "Updating pcbsd-major repository catalogue" doesn't bump it up to "0.9.1".
Do I need to ". .  . :/usr/ports # git pull" to have it get, or be able to build, that newer package?

I am looking now - apparently the packages for 10.3 have been failing to build for a little bit which might be why the newer version is not there yet.

Is/was it a good idea to list Lumina as "fully-supported", on the main PC-BSD page, if the stable package fails to even build for the latest OS release? :-)
Anyway, I AM pretty excited, from the little bit of Lumina I was able to see/try, vs KDE.
As of now (Fri Jul 22 11:55:26 EDT 2016), I'm still seeing "lumina: 0.9.0_3,1", when I try to get that package. I'd thought to try building from my updated ports tree. But if you are having building issue, I don't know if I could do better (maybe help troubleshoot?). And part of the goal, I think, is to also test the experience for the target desktop users. --who want their default desktop/packages to just work, without having to compile source.


Issue 12

Make sure these boxes are checked before submitting this pull request~!~ Thank you!!

[X] The test of the method you have fixed is passing
[X] You have written a new skeleton method for someone else to work on!

Fixes #12

I must be blind but I can't find what you mentioned! :P

Haha no worries! I went ahead and tagged the specific lines. Also I'm going to try to publish this to npm as often as I can, so if you ever want to see your work in action, the registry should be current with the codebase!

I really was blind! Thanks


Have a default "welcome" article that explains how to use the app (and how to edit/delete itself)

Even if nothing has been typed

Can be done with a store similar to drafts - called help or tutorial
Multiple posts, each explaining a different feature
After a post or draft is created, these posts can be accessed from left button -> nav list -> help/tutorial


Update modules and durable objects docs to reflect recent changes

Namely:

The addition of ctx to module fetch handlers
The changes to the custom builds configuration

Are modules part of https://github.com/cloudflare/workers-types yet? Having the fetch parameters in there would be handy for people that keep tripping up looking for waitUntil (on ctx). Although having these docs fixes most of that. :)

Are modules part of https://github.com/cloudflare/workers-types yet? Having the fetch parameters in there would be handy for people that keep tripping up looking for waitUntil (on ctx). Although having these docs fixes most of that. :)

Not yet, but we should put them in there soon. I'm not sure how we should handle the difference between modules and service-workers, perhaps we need to factor out the shared parts and make two packages or something like that?


[Question] Is there an issue with npm run test?

I followed the minimum path to awesome: Clone, npm i -> npm run build then npm test but it seems like there's an issue with the test runs. Is that just me?

Which version of Node are you using?

v10.20.1

Hey @BassemNKhalil  - As per the documentation Minimal Path to Awesome, we may need Node.js ?12.0.0 if we want to start running the build and test.
If you want to have multiple versions in the same machine, you can use Node Version manager through which you can juggle between multiple node versions. This would definitely be handy if you want to develop SPFx and M365 CLI in parallel.
You can watch THIS VIDEO where it has explained how to do that.
Let me know if you need any other help or have questions. Will be more than happy to help you on the same.

🤦  Yup - v12 sorted things out. Thanks @arjunumenon

🤦 Yup - v12 sorted things out. Thanks @arjunumenon

Awesome.... You are welcome... ✌


Request: Add data-uri encoding

It looks like DevToys is going to replace a lot of my current Alfred workflows. One tool that would be useful is encoding in data URI scheme (see "Data URI scheme" workflow by Igor Rzegocki for an example).

cage1016/alfred-devtoys: A Swiss Army knife for developers for Alfred

Please have a look. If this function fit your request and i will close this issue.


Update Kubebuilder/components versions

What this PR does / Why we need it

Follow this guide for upgrading to the recommended project directory structure:

upgrade dependency component versions
refactor/update some files/variables/import names etc to build and test successfully
the scaffolding coding style of the new project is quite different, but no code changes have been made in this PR, code refactoring will be done separately later

No functionality has been added or changed or removed in this PR

The CI check for PR size will be fixed after this PR is merged (probably). If not, then I'll investigate again later, but right now I think it is because the PR is trying to add more permissions to the github action (write permisisons for pull-request so that it can add labels). And the old workflow remains in queued status because the runner ubuntu-18.04 is deprecated and thus not available anymore.
Therefore, we will have to force merge this PR I think.

We should update the development docs.
$ git diff docs
diff --git a/docs/development.md b/docs/development.md
index 8badf90..538ea61 100644
--- a/docs/development.md
+++ b/docs/development.md
@@ -10,7 +10,7 @@ The default approach is to:
    $ export IMG=mercari/spanner-autoscaler:local
    $ make docker-build kind-load-docker-image
    $ make install deploy
-   $ kubectl apply -f config/samples
+   $ kubectl apply -k config/samples
    ```
 If there are any errors in the conversion or the validation of the sample CRs, then the `kubectl apply` command above, will fail with the corresponding errors.


Remove code downloading unused software

Can we remove downloading unused software like elasticsearch which is not currently used in our stack. There may be others as well which we can include to this list.
https://github.com/bloomberg/chef-bach/blob/master/build_bins.sh#L89
https://github.com/bloomberg/chef-bach/blob/master/build_bins.sh#L157
https://github.com/bloomberg/chef-bach/blob/master/build_bins.sh#L162

If we pull Elastic Search, I would like to pull the associated bits too:

elasticsearch.rb
fluentd.rb
haproxy.rb elasticsearch mentions

We will also need to remove kibana components along with elasticsearch.

Fixed as part of PR #126 . Thanks @cbaenziger .


Update to v0.15.0

Use es modules
Use spago
Update dependencies

@sharkdp this test failed and only passes with the change made. I am not sure whether this correct.

@sharkdp this test failed and only passes with the change made. I am not sure whether this correct.

well, that is.. unexpected? Are there some upstream changes that would indicate a breaking change?

@sharkdp this test failed and only passes with the change made. I am not sure whether this correct.

well, that is.. unexpected? Are there some upstream changes that would indicate a breaking change?

I haven't found anything... not sure what to think about this.
Apart from that, the 0.15 update is now complete

@sigma-andex Is this PR using<EMAIL_ADDRESS>now?
Also, mind adding a ToString for BigInt, which can reflect type-level Ints to a BigInt? Something like this should work:
import Prim.Int (class ToString)
import Data.Reflectable (class Reflectable)

reflectBigInt :: forall i. ToString i sym => Reflectable sym String => Proxy i -> BigInt
reflectBigInt p = fromString $ reflectType p

import Prim.Int (class ToString)
import Data.Reflectable (class Reflectable)

Not sure if this is possible, fromString returns a Maybe

import Prim.Int (class ToString)
import Data.Reflectable (class Reflectable)

Not sure if this is possible, fromString returns a Maybe

fromString has to return Maybe because it must work on all String types. However, if we can guarantee that the String type stores an integer, which it does in this case, then we don't need that Maybe.
So, we should actually just use fromBase here, but without the Maybe wrapper. In other words, exposing FFI to just this function and using that in the implementation.

This PR should now be ready to go.

Thx @JordanMartinez

https://pursuit.purescript.org/packages/purescript-bigints/7.0.1


resurrection of obsolete terms: GO:0016251

Using the example: GO:0016251
I know that reinstating obsoletions is rare, but for future reference, it is not good practice to unobsolete a class. A new ID should be created instead.

Hi @hattrill
Can you explain your objection ? I un-obsoleted the term (and a few others) because we thought the meaning was OK, and the reason for obsoletion was not justified.
Personally I find it very confusing when the same term exists as obsolete and non-obsolete, for example
GO:0030528    obsolete transcription regulator activity
GO:0140110   transcription regulator activity
(perhaps this is mostly a display issue, and by default, obsolete should not be shown).
Thanks, Pascale

It's a tracking issue and a database thing. Once something is obsolete, then it shouldn't be used again, even if the name is identical. This term was dead for a long time, everyone anotating to the revived term may be doing it differently or in the light of new knowledge - it is, in effect, "new" - even if the definition hasn't changed. For instance, if someone has a decade-old annotation file, the contexual knowledge has changed and that annotation would need to be reviewed.
Some databases do not expect direct unobsoletions as it is not expected practice and will not deal with them coorectly.

Adding editors' discuss to this because in the past I though we had decided to resurrect obsolete terms. I happened very infrequently. However, now that we are obsoleting so many terms I suspect it will be more common. The annotation points raised by @hattrill are interesting.

For what it's worth, Reactome never un-obsoletes (though obsoletion is rare) but we also don't pay any attention to the history of instances in others' data so unobsoletion there would probably be handled correctly at our end, except that the humans who had manually replaced an obsolete GO term and who now needed to consider restoring the old one might be annoyed.

Hi @hattrill. We discussed this a few weeks ago and decided that it was ok to resurrect the terms unless it is specifically breaking tools on your end. From a curation standpoint we decided it was less confusing for users to see a single term in the ontology rather than perhaps several examples of the same term string some of which are obsolete.

We are set up to check this now, so we can deal with resurrections.
I will note that " However, now that we are obsoleting so many terms I suspect it will be more common" makes me a little unhappy - every time a term is obsoleted, we lose curated information - if we constantly flip-flop, then we just end up with patchy, incomplete annotation sets.

Are these so common ? I have probably resurrected 4-5 terms (maybe I am mis-remembering).
Anyway, booth obsoletion and resurrection should be done very carefully.

@hattrill, you shouldn't lose any information. Suggested terms should be equivalent or improved. Do you have egs where you lose info?

What I am objecting to is that notion that the practice may become more common - the history of GO:0030528 obsolete transcription regulator activity shows the the "consider" is not always equivalent.
If an obsoleted term is resurrected, we are unlikely to go back and recurate all the re-housed annotations - or may be it should be a policy that we should reinstate the annotations as was prior to the obsoletion?

We'll document the procedure more clearly.

Hello,
I've added a very short section here:
http://wiki.geneontology.org/index.php/Principles_for_term_obsoletion

In rare cases, obsolete GO terms may be restored, if the original meaning is conserved. In this case, an ID that had been obsolete at some point becomes a valid ID.

@ukemi @hattrill @vanaukenk
Is that sufficient ?
Thanks, Pascale

That is sufficient for me - we've updated our pipeline to deal with this issue.
It would be good if a similar notice that given for an obsoletion was sent round, as we might want to shift our prevously rehoused annotations.

Good point! I've added this to our procedure: http://wiki.geneontology.org/index.php/Restoring_an_Obsolete_Ontology_Term
Thanks !


Add clone evidence functionality

To make adding evidence easier and faster, we would like to have the ability to clone existing evidence from a model.
This functionality would be an option in the right hand list and would present curators with a list of existing evidence codes, references, and With/From values where curators could select what they want to clone and add to their model.
@tmushayahama  - see the 'Clone other' feature for adding evidence in the graphical interface for an example of how this was implemented.

To Clone
Click the more options and click clone evidence

Select one or more evidence from the list. The recent evidence appears on top and there will be no duplicate of (evidence, reference and with) combination on the list

Note: 'with' and 'assignedBy' doesn't get copied


How to remove a device?

How can I remove a device?
Is that even necessary?
While testing I created a lot of different devices. Now I have some unused device instances. Should they be released or doesn't that matter?

If you go into the regular venus console, there should be an option at the bottom of the menu saying "Remove disconnected devices", that will partially clean things up. Unfortunately the persisted settings are permanent - that's just how Venus uses dbus. Only thing to do is create a clean install of Venus.

OK, thank you. I don't have that entry.
But doesn't matter. I Don't plan to have that much unused sensors on the production system.


Splitter component - Suggest a new feature

Prerequisites

[X] I have searched for duplicate or closed feature requests
[X] I have read the contributing guidelines

Proposal
Splitter component
Hello Bootstrapp team, i'd like to ask for splitter component - feature  for the next version of bootstrap
Motivation and context

It allows users to resize panes according to their preferences

We'll pass on this, thanks.


Missing setup commands to the guide for setting up the runner

Describe the enhancement
The issue provides a small list of missing commands that help set up the runner.
Install.sh cannot be run out of the box
Encountered error:
missing <priority> for update-alternatives

Currently applied fixes that sort of fixed the issue:
Appended a 1 at the end of update-alternatives --install /usr/bin/python python /usr/bin/python3

Missing commands when sshing into the coordinator instance
wget is not installed:
(For wgetting the installation script)
sudo apt install wget

After downloading the install script has to be made executable
(Something not as strong as 777 though)
chmod 777 ./install.sh

Code Snippet
N/A
Additional information
N/A
FYI @msaligane

Hey @erictaur, thanks for reporting the issue.
I fixed the installation script by adding the missing priority argument. Additionally, I added the command to install wget prior to downloading the aforementioned scripted (I tend to make an assertion that it is installed by default, but it turns out it's not 😄).
The chmod command is not necessary. Instead, one has to redirect wget's output to standard output -- then it works as intended (of course common sense has it that you should inspect the script before doing that).


ekf: disable xy accel bias learning before takeoff

As those biases are usually poorly observable before takeoff because
they are almost perpendicular to the gravity vector, learning is often
driven by noise and numerical issues. This results in incorrect bias
learning before takeoff when the drone is static on ground for a long
period of time.
Testing on Pixhawk4 by changing the "in_air" check by "at_rest". XY bias learning is correctly inhibited and the covariances are forced to 0

This implementation seems to assume that body XY is orthogonal to the gravity vector. What will happen if this is not the case, e.g. the user leaves the vehicle powered on at 90 degrees pitch before taking off?

This implementation seems to assume that body XY is orthogonal to the gravity vector. What will happen if this is not the case, e.g. the user leaves the vehicle powered on at 90 degrees pitch before taking off?

That's correct. I think I have to split the bias learning even further and toggle the inhibition based on some observability criteria (e.g.: angle between gravity vector and each axis)

yeah that is probably the way to go. Otherwise we risk having everything working fine until suddenly it doesn't

@CarlOlsson Ok, it should be easy using the DCM as a criteria to enable each component independently.

Note that ecl/EKF in air status is set from PX4/Firmware's land detector landed flag which is forced to true when disarmed.

@CarlOlsson Now it would work for all orientations: I did set an arbitrary value of 0.8 against the cos of the axis to the gravity vector as an observability criteria.
Interestingly enough, the unit test now fails for the initializeWithTilt case, because all accel biases are inhibited (note that I have the same failure if I enable MASK_INHIBIT_ACC_BIAS in master, so it's not a bug introduced by this PR)

Note that ecl/EKF in air status is set from PX4/Firmware's land detector landed flag which is forced to true when disarmed.

@dagar That's all good. I just want to have this feature working before takeoff

I'll bring the non-functional change that splits the accel bias learning first. This will make the merge process easier

Non-functional change in https://github.com/PX4/ecl/pull/817


Add observability for celery workers

Environment
Nautobot version: ^1.3

Proposed Functionality
Nautobot has changed to use celery workers instead of rq workers, therefore we need to enable task monitoring by using a specific option -E when we start the celery worker, in order to observe tasks in the redis queue that the celery worker is using. The following code is the way can do this in docker-compose.yml:
  celery:
    entrypoint: "nautobot-server celery worker -l INFO -E"
    depends_on:
      - "nautobot"
    healthcheck:
      disable: true
    <<: *nautobot-base

Then in the celery worker logs you will observe that task events are on:
-- ******* ---- Linux-4.19.0-18-amd64-x86_64-with-debian-11.3 2022-06-30 12:48:17
- *** --- * ---
- ** ---------- [config]
- ** ---------- .> app:         nautobot:0x7f7d359bb6d0
- ** ---------- .> transport:   redis://:**@redis:6379/0
- ** ---------- .> results:     redis://:**@redis:6379/0
- *** --- * --- .> concurrency: 24 (prefork)
-- ******* ---- .> task events: ON
--- ***** -----
 -------------- [queues]
                .> celery           exchange=celery(direct) key=celery

fixed by #194


Fix terrain painting in corner-only matching mode

Fixes an issue reported on reddit : https://www.reddit.com/r/godot/comments/ykhuor/the_godot_4_terrain_system_makes_no_sense_do_i/
In the "match corner" mode, terrain painting was only updating the tiles in the corners, while it should update all neighbors if needed (including sides).

Awesome! Thanks!

Thanks!


 Merge all changes from build definition #112 to build definition #45. Differences include:

[ ] Add the NuGetBuildBranch variable with value master
[ ] Add the ConfigurationName variable with value Dev-USNC. This should be settable at queue time
[ ] Update Phase 1 to enable Allow scripts to access the OAuth token
[ ] Add a new build step Import configuration with the following YAML:

steps:
- task: PowerShell@1
  displayName: 'Import configuration'
  inputs:
    scriptName: '$(Build.SourcesDirectory)\tests\Scripts\Import-Configuration.ps1'
    arguments: '-Instance "nuget" -Project "NuGetBuild" -PersonalAccessToken $(System.AccessToken) -Repository "NuGetBuild" -Branch "$(NuGetBuildBranch)" -ConfigurationName "$(ConfigurationName)"'

I think we should leave the legacy functional test suite (build definition 45) as-is and create a new one just for Azure Search.
This new one should be called during Azure Search deployment before staging slot swap along with the E2E test suite.


Add spring.cloud.kubernetes.enabled property

It seems like that property  spring.cloud.kubernetes.enabled is not provided. On my dev machine I would like to disable k8s aware but it is not possible. I tried this configuration:
spring:
  cloud:
    kubernetes:
      enabled: false # This property does not exist
      secrets:
        enable-api: false
      config:
        enable-api: false
        enabled: false

but when I start my application I have this exception:
2019-12-01 | 17:46:49.858 | 24868 |  WARN | [gateway,,,ASUS-ROG] | restartedMain | o.s.c.k.c.ConfigMapPropertySource | Can't read configMap with name: [gateway] in namespace:[dev]. Ignoring.
io.fabric8.kubernetes.client.KubernetesClientException: Operation: [get]  for kind: [ConfigMap]  with name: [gateway]  in namespace: [dev]  failed.
	at io.fabric8.kubernetes.client.KubernetesClientException.launderThrowable(KubernetesClientException.java:64)
	at io.fabric8.kubernetes.client.KubernetesClientException.launderThrowable(KubernetesClientException.java:72)
	at io.fabric8.kubernetes.client.dsl.base.BaseOperation.getMandatory(BaseOperation.java:229)
	at io.fabric8.kubernetes.client.dsl.base.BaseOperation.get(BaseOperation.java:162)
	at org.springframework.cloud.kubernetes.config.ConfigMapPropertySource.getData(ConfigMapPropertySource.java:95)
	at org.springframework.cloud.kubernetes.config.ConfigMapPropertySource.<init>(ConfigMapPropertySource.java:76)
	at org.springframework.cloud.kubernetes.config.ConfigMapPropertySourceLocator.getMapPropertySourceForSingleConfigMap(ConfigMapPropertySourceLocator.java:95)
	at org.springframework.cloud.kubernetes.config.ConfigMapPropertySourceLocator.lambda$locate$0(ConfigMapPropertySourceLocator.java:78)
	at org.springframework.cloud.kubernetes.config.ConfigMapPropertySourceLocator$$Lambda$395.000000008E0BF780.accept(Unknown Source)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1540)
	at org.springframework.cloud.kubernetes.config.ConfigMapPropertySourceLocator.locate(ConfigMapPropertySourceLocator.java:77)
	at org.springframework.cloud.bootstrap.config.PropertySourceBootstrapConfiguration.initialize(PropertySourceBootstrapConfiguration.java:98)
	at org.springframework.boot.SpringApplication.applyInitializers(SpringApplication.java:626)
	at org.springframework.boot.SpringApplication.prepareContext(SpringApplication.java:370)
	at org.springframework.boot.SpringApplication.run(SpringApplication.java:314)
	at org.springframework.boot.SpringApplication.run(SpringApplication.java:1226)
	at org.springframework.boot.SpringApplication.run(SpringApplication.java:1215)
	at fr.app.GatewayApplication.main(GatewayApplication.java:22)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.base/java.lang.reflect.Method.invoke(Method.java:566)
	at org.springframework.boot.devtools.restart.RestartLauncher.run(RestartLauncher.java:49)
Caused by: java.net.SocketTimeoutException: connect timed out
	at java.base/java.net.PlainSocketImpl.waitForConnect(Native Method)
	at java.base/java.net.PlainSocketImpl.socketConnect(PlainSocketImpl.java:107)
	at java.base/java.net.AbstractPlainSocketImpl.doConnect(AbstractPlainSocketImpl.java:399)
	at java.base/java.net.AbstractPlainSocketImpl.connectToAddress(AbstractPlainSocketImpl.java:242)
	at java.base/java.net.AbstractPlainSocketImpl.connect(AbstractPlainSocketImpl.java:224)
	at java.base/java.net.SocksSocketImpl.connect(SocksSocketImpl.java:403)
	at java.base/java.net.Socket.connect(Socket.java:591)
	at okhttp3.internal.platform.Platform.connectSocket(Platform.java:130)
	at okhttp3.internal.connection.RealConnection.connectSocket(RealConnection.java:263)
	at okhttp3.internal.connection.RealConnection.connect(RealConnection.java:183)
	at okhttp3.internal.connection.ExchangeFinder.findConnection(ExchangeFinder.java:224)
	at okhttp3.internal.connection.ExchangeFinder.findHealthyConnection(ExchangeFinder.java:108)
	at okhttp3.internal.connection.ExchangeFinder.find(ExchangeFinder.java:88)
	at okhttp3.internal.connection.Transmitter.newExchange(Transmitter.java:169)
	at okhttp3.internal.connection.ConnectInterceptor.intercept(ConnectInterceptor.java:41)
	at okhttp3.internal.http.RealInterceptorChain.proceed(RealInterceptorChain.java:142)
	at okhttp3.internal.http.RealInterceptorChain.proceed(RealInterceptorChain.java:117)
	at okhttp3.internal.cache.CacheInterceptor.intercept(CacheInterceptor.java:94)
	at okhttp3.internal.http.RealInterceptorChain.proceed(RealInterceptorChain.java:142)
	at okhttp3.internal.http.RealInterceptorChain.proceed(RealInterceptorChain.java:117)
	at okhttp3.internal.http.BridgeInterceptor.intercept(BridgeInterceptor.java:93)
	at okhttp3.internal.http.RealInterceptorChain.proceed(RealInterceptorChain.java:142)
	at okhttp3.internal.http.RetryAndFollowUpInterceptor.intercept(RetryAndFollowUpInterceptor.java:88)
	at okhttp3.internal.http.RealInterceptorChain.proceed(RealInterceptorChain.java:142)
	at okhttp3.internal.http.RealInterceptorChain.proceed(RealInterceptorChain.java:117)
	at io.fabric8.kubernetes.client.utils.BackwardsCompatibilityInterceptor.intercept(BackwardsCompatibilityInterceptor.java:119)
	at okhttp3.internal.http.RealInterceptorChain.proceed(RealInterceptorChain.java:142)
	at okhttp3.internal.http.RealInterceptorChain.proceed(RealInterceptorChain.java:117)
	at io.fabric8.kubernetes.client.utils.ImpersonatorInterceptor.intercept(ImpersonatorInterceptor.java:68)
	at okhttp3.internal.http.RealInterceptorChain.proceed(RealInterceptorChain.java:142)
	at okhttp3.internal.http.RealInterceptorChain.proceed(RealInterceptorChain.java:117)
	at io.fabric8.kubernetes.client.utils.HttpClientUtils.lambda$createHttpClient$3(HttpClientUtils.java:110)
	at io.fabric8.kubernetes.client.utils.HttpClientUtils$$Lambda$234.000000008D0CD880.intercept(Unknown Source)
	at okhttp3.internal.http.RealInterceptorChain.proceed(RealInterceptorChain.java:142)
	at okhttp3.internal.http.RealInterceptorChain.proceed(RealInterceptorChain.java:117)
	at okhttp3.RealCall.getResponseWithInterceptorChain(RealCall.java:229)
	at okhttp3.RealCall.execute(RealCall.java:81)
	at io.fabric8.kubernetes.client.dsl.base.OperationSupport.handleResponse(OperationSupport.java:404)
	at io.fabric8.kubernetes.client.dsl.base.OperationSupport.handleResponse(OperationSupport.java:365)
	at io.fabric8.kubernetes.client.dsl.base.OperationSupport.handleGet(OperationSupport.java:330)
	at io.fabric8.kubernetes.client.dsl.base.OperationSupport.handleGet(OperationSupport.java:311)
	at io.fabric8.kubernetes.client.dsl.base.BaseOperation.handleGet(BaseOperation.java:810)
	at io.fabric8.kubernetes.client.dsl.base.BaseOperation.getMandatory(BaseOperation.java:218)
	... 20 common frames omitted

I can use maven profiles to exclude Spring Cloud K8S dependencies but I need them for configuration.
To confirm the absence of  spring.cloud.kubernetes.enabled I also took a look here: https://cloud.spring.io/spring-cloud-static/Hoxton.RELEASE/reference/html/spring-cloud-hoxton-configprops.html and the property is not present.
Thanks

Updated documentation with d3700c5 and 98c7eb5. Will verify if it's a bug later tomorrow.

@akuma8 Can you confirm that this is happening during the bootstrap phase when spring-cloud-kubernetes-config is on the classpath?
If this is true, could you check if the stacktrace is gone when you add spring.cloud.kubernetes.enabled=false to bootstrap.properties|yml?

@TYsewyn This is my dependency:
 <spring-cloud.version>Hoxton.RELEASE</spring-cloud.version>

 <dependency>
       <groupId>org.springframework.cloud</groupId>
       <artifactId>spring-cloud-starter-kubernetes-all</artifactId>
          <exclusions>
              <exclusion>
                  <groupId>org.springframework.cloud</groupId>
                  <artifactId>spring-cloud-kubernetes-ribbon</artifactId>
              </exclusion>
          </exclusions>
  </dependency>

The property spring.cloud.kubernetes.enabled  does not exist actually so I can't set it in bootstrap.yml

What exactly do you mean with “does not exist”?
If you are referring to the code completion and hints within IntelliJ, that will be fixed alongside the documentation in the next release.
That property is used multiple times in the code base, it just wasn’t documented properly.

Going to close this as @TYsewyn should have fixed the documentation as well as the IDE bug with the commits above

What exactly do you mean with “does not exist”?
If you are referring to the code completion and hints within IntelliJ, that will be fixed alongside the documentation in the next release.
That property is used multiple times in the code base, it just wasn’t documented properly.

Sorry to answer lately, I am a bit busy.
Yes I did the test. I set the property to false and restart my application and still get the exception. Since it's a WARN message I ignore it.

Just because IntelliJ does not know about it doesn't mean it doesn't work.  @TYsewyn fixes will make IntelliJ pick them up once we do the next release.

@ryanjbaxter I agree with you but I still don't understand why setting that property does not have any effect and I still have the error message during the bootstrap phase.

Can you provide a sample that reproduces the error and problem?

@ryanjbaxter See a demo here: https://github.com/akuma8/demo
At the application startup you will see the warning message.

Like I already said, please add spring.cloud.kubernetes.enabled: false to your bootstrap.yml file.

Could you set this information in the documenation? I mean setting the property in  bootstrap.yml not in application.yml

We would gladly accept any PR for this.
Let me know if you want to take this up! 🙂

Yes, for a first contribution, documentation is the right place to start.
Please let me know how to contribute?

Still does not work.


flatcam: 8.5 -> unstable-2022-02-02

qt4 -> qt5
(cherry picked from commit 9ab75e0f1ca9cae1d52cf994f7e46c8748e234ba)

Extracted from #174634
because this can be PRed independently and can land earlier than the PR above.
Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

error: builder for '/nix/store/h1myk825hzv7v99xk6mpjpsarzvly2kp-flatcam-unstable-2022-02-02.drv' failed with exit code 2;
       last 10 log lines:
       > updateAutotoolsGnuConfigScriptsPhase
       > configuring
       > no configure script, doing nothing
       > installing
       > patching script interpreter paths in .
       > ./tests/canvas/prof.sh: interpreter directive changed from "#!/bin/sh" to "/nix/store/ir0j7zqlw9dc49grmwplppc7gh0s40yf-bash-5.2-p15/bin/sh"
       > ./assets/linux/flatcam-beta: interpreter directive changed from "#!/bin/bash" to "/nix/store/ir0j7zqlw9dc49grmwplppc7gh0s40yf-bash-5.2-p15/bin/bash"
       > install flags: SHELL=/nix/store/ir0j7zqlw9dc49grmwplppc7gh0s40yf-bash-5.2-p15/bin/bash USER_ID=0 LOCAL_PATH=/build/source/. INSTALL_PATH=/nix/store/8zjb0z5df61r01s99w0y9rkp2mqlsyhq-flatcam-unstable-2022-02-02/share/flatcam APPS_PATH=/nix/store/8zjb0z5df61r01s99w0y9rkp2mqlsyhq-flatcam-unstable-2022-02-02/share/applications install
       > Current python version is 3.10
       > Makefile:22: *** You must have at least 3.5 installed.  Stop.

🤔

Lol, does the makefile handle "3.10" as "3.1"? :laughing:

yup, they do

I am pretty sure that I broke flatcam on staging-next with the Python bootstrapping changes. Do you think this is close to getting across the finish line, or I can buy more time by merging https://github.com/NixOS/nixpkgs/pull/249849 first.

Go ahead with your PR, I am not sure what to do about the makefile issue here.

It seems that these lines can be commented out to avoid the version check.
https://bitbucket.org/jpcgt/flatcam/src/ebf5cb9e3094362c4b0774a54cf119559c02211d/Makefile#lines-20:23


Implement a non-bootstrapping unit testing framework

We should implement a unit testing framework for Vinum that doesn't depend exactly on a bootstrapping process.

We can reuse ecrTestSuite for this.


remove prohibition of unmanaged constructed types

rebased on the latest draft v8 branch on 9/26/2023

The title talks about unmanaged constructed types - the text seems to be about pointer types. (It looks like constructed types still count as managed.)
I think I need a bit more context to understand this change.

(@jskeet to have another pass at this - in this PR.)

And look for other places, e.g. 515.

Also (try to) remove the grammar as type parameters can be unmanaged - instead, make references to it specify that the type must be unmanaged. (Do this in a separate commit.)

We should talk about this again - I'm finding it hard to get my head back into it, so when we talk, let's make verbose notes.

The latest merge has undone all the changes here... suggest we revert the last commit.

OK, I went through the merge, tried to revert and that failed to make any sensible changes (the only change left was the revert of the links for the "pointer" restriction.
Tried a rebase as well, and the same issue remained.
I've tried looking at a reflog and I can't find the actual changes there either.

Here's the original proposal as an issue in C# lang:  dotnet/csharplang#1504


Add a first class event hubs picker

The experience for adding an event hubs connection string requires manual copying and pasting of connection strings. To make things worse, there are bugs that exist for certain variations of the connection string so if it was copied from the wrong place you can get bad results (such as your function app not scaling out). This issue tracks adding an experience where you can browse the event hubs in your subscription (perhaps in the same region) and select one.

Feature: should pick an existing Event Hub namespace.

@alrod Please chat with @Tuesdaysgreen about how feasible (and how much work) this is.

For this work, we should ensure that there's still a way to add a manual connection string, as otherwise it would degrade the IoT Hub experience.

Doesn't fit in Feb, moving out.


Add corresponding type to the block in  IO.pipe

Motivation
Fixes #7799
Test plan
See included automated tests.

We have a policy of testing changes to Sorbet against Stripe's codebase before
merging them. I've kicked off a test run for the current PR.  When the build
finishes, I'll share with you whether or how it failed. Thanks!
Stripe employees can see the build results here:
→ https://go/builds/bui_PuiFWe2WzVlVNh
→ https://go/builds/bui_PuiF5kpEm7XcSB
→ https://go/builds/bui_PuiF5lJpKIig7i


docs: additional info on binary paths

Replaces #107

Bro, I wanna a PR. Next time plz include that previous works. plz @mlegner


how to save a screenshot from code?

hey im trying to put some in game ai to my project but i dont know how to get a screen shot?

what im trying to do is to save the contents of a window to an image on disk

There's a nice example in docs for this:
Texture:newReadback

that part i have but i just dont know how to write it to the disk

nevermind

i tryes this method. and copied it all together. yet it does not saves anything to the disk it says its doing so but the image is nowhere. im using windows 11 i have given read/write pernissions to lovr and runnning it as admin

i printer the blob returned to the console it has rgb values in it so the image is not empty.

also i set the bg color but in the readback its semingly just black it print prints a tons of 0. this method is just getting wierder as it goes

Weird, it's working for me.  I pasted the example into main.lua, typed lovr . to run it, pressed p to take a screenshot, it printed "saved screenshot to screenshot.png".  I opened ~/.local/share/LOVR/default/screenshot.png and it's a transparent png with the "helooo" text in it.

Make sure to check the save folder, on Windows it's at %APPDATA%\LOVR

You can change the background color of the intermediate pass with pass:setClear(r, g, b, a).  If you use lovr.graphics.setBackgroundColor, it will change the background color of the window, but that example renders to an offscreen canvas and screenshots that, so you have to set the background of the offscreen canvas.


BAEL-7934 : improve https://www.baeldung.com/spring-cloud-gateway-bff-oauth2

Add Logout failure handlers to UI projects.
In the case of a misconfigured BFF (for instance a bad OAuth2 client secret), all 3 frontend projects were completely silent.
This PR:

specifies a specific route for the frontend when the authorization code flow fails on the backend
adds components to display the error provided by the backend
changes the default OAuth2 client secret to the value set by the build.sh

It also adds some sample unit & integration testing for the Spring services (BFF & resource server).

retest this please

@lor6 tests have finally passed.


Clarify in description if/and MFP works with Quest 2 version of the apps

I saw by searching in issues that it probably supports DeoVR on Quest 1/2, so can you please clarify which Quest apps does it work with (if any)

It does work, you just have to point DeoVR in MFP to your quest ip.


Is it possible to add json files directly to this

[ ] I'm reporting a bug, not asking for help
[ ] I'm sure this is a Leaflet.MarkerCluster code issue, not an issue with my own code nor with the framework I'm using (Cordova, Ionic, Angular, React…)
[x] I've searched through the issues to make sure it's not yet reported

How to reproduce

Leaflet version I'm using: latest version
Leaflet.MarkerCluster version I'm using: current version mentioned
Browser (with version) I'm using: chrome
OS/Platform (with version) I'm using: windows
step 1
step 2

What behaviour I'm expecting and which behaviour I'm seeing
Minimal example reproducing the issue

[ ] this example is as simple as possible
[ ] this example does not rely on any third party code

Using http://leafletjs.com/edit.html or any other jsfiddle-like site.

Hi, I'm closing this issue because the quality is not good enough. I suggest reading "How To Ask Questions The Smart Way" and "How to Report Bugs Effectively" so you can make good bug reports.


feat: add Content-Length headers when writing to a sphere.

First pass on this; we could also add length when linking, either the size of the pointer or 0

Just as a general comment, I want to call attention to https://github.com/subconsciousnetwork/noosphere/issues/498 . There isn't a strict path dependency here, but I think the overall priority if #498 is higher, and that a more wholesome solution to computing Content-Length would arise from fixing it.


How to search the direction using InterfaceGAN?

Hi, thanks for the great work!
I'm trying to reproduce the result of changing the pose on Human face and the Church (Figure 14).
As far as I understood, you use the InterFaceGAN to find the direction.
However, I looked into InterFaceGAN and found out they were built on StyleGAN instead of StyleGAN2.
Do you somehow adapt the weight to make the bonudary work with styleGAN2?
Or do you finetune the styleGAN in this case instead of StyleGAN2?
Thank you so much!

The InterFaceGAN method supports both StyleGAN1 and StyleGAN2. InterfaceGAN contains 3 steps:

Prepare data: Please use StyleGAN2 to generate a set of images. You could use the code from StyleSpace, and run

'''
dataset_name='ffhq'
python GetCode.py --dataset_name $dataset_name --code_type 'w'
python GetCode.py --dataset_name $dataset_name --code_type 's'
python GetCode.py --dataset_name $dataset_name --code_type 'images_100K'
'''
2. Predict Attribute Score: I use this  pose regressior.
3. Search Semantic Boundary: Same codes from InterfaceGAN
We aslo provide the pretrained models and pose direction in here.
The 'ffhq' model is parent model, 'ffhq_pose' is the pose direction in w space, and 'ffhq_church' is the child model. We alse provide the grandchild model 'ffhq_church_ffhq256' grandchild model for reproducing fig 34.
The 'ffhq512' is the parent model, 'ffhq512_pose' is the corresponding pose direction in w space, 'ffhq512_dog_bed' is the grandchild model for fig 14.

InterfaceGan needs stylegan_generator.py and stylegan_generator_model.py for generating a set of w vectors and corresponding images. If we have other ways to a set of w vectors and corresponding images, then we dont need stylegan_generator.py and stylegan_generator_model.py any more.
To achieve this goal, just do:
'''
Pick latent vector.
num_img=100_000
rnd = np.random.RandomState(5)
latents = rnd.randn(num_img, Gs.input_shape[1])
Generate image.
fmt = dict(func=tflib.convert_images_to_uint8, nchw_to_nhwc=True)
images = Gs.run(latents, None, truncation_psi=0.7, randomize_noise=True, output_transform=fmt)
'''

Hi @betterze ,
Thank you so much,
I think I now understand how to get it work.
I will play around a bit and see if I can recreate the results and then close this issue later.
Thanks again!

Hi @betterze,
I can reproduce the results now, it's pretty cool!
Thanks a lot for your help!
btw, in Readme, there is one section called "sauge". Is it a type for "usage"?

sorry, I just change it. Thx


Support change for Ember 3.24 LinkTo refactor

emberjs/ember.js#19223 made a breaking change to the private implementation of <LinkTo> which Engines relies on. This breaks any existing user of Engines which upgrade to Ember 3.24. We need to add a conditional handling for gte("3.24.0") to not apply the monkey-patch.

cc. @rwjblue @villander

With Ember 3.24 out, this is now blocking any app from upgrading which depends on Engines!

With Ember 3.24 out, this is now blocking any app from upgrading which depends on Engines!

It also breaks the pipelines before upgrading because of ember:try.

It also breaks the pipelines before upgrading because of ember:try.

Fixed in<EMAIL_ADDRESS>

Fixed in<EMAIL_ADDRESS>

Thanks so much, @rwjblue!

Thanks so much, @rwjblue!


Possible issue with the template-only-glimmer-components optional-feature

I couldn't reproduce this in an isolated test case. I have an application with "template-only-glimmer-components": true and ember-angle-bracket-invocation-polyfill 1.1.5 installed. (Ember and Ember CLI are all at the latest version.)
If I invoke a component using angle brackets like:
<FlashMessage class="some-class" data-foo="bar" />

I don't see the class or data- attribute added to the DOM element.
If I disable template-only-glimmer-components, it works as expected.
These components have JS classes (they're coming from an addon) so it's not due to actually using a template-only component. I just had a few simples in the host app where I wanted outer-HTML semantics and no extra files.

Thanks for reporting! What Ember version were you using?


New program and device IDs

Feature request
Hi! I managed to find a bunch of ID's. Most of them don't seem useful, but at least GLOBAL_EnumPrgId seems to fill the gaps for my oven.
I'm not sure how I would integrate the IDs into the repo. We can try to test which groups of IDs are correct and implemented those. Or it can be used as a reference on the wiki for people who are missing an ID.
These are the IDs: ids.txt
What version of the integration are you using?
0.1.13
Anything in the logs that might be useful for us?
No response
Additional information
No response

Thank you, this can definitely be useful as a reference when mappings are missing. I found a few device id:s for the semi-professional appliances. They are not officially supported by the API but nevertheless produce data when added to the user’s account.
Please describe what you miss with your oven and I can try to add it. Or feel free to make a PR.

I can add them! :slightly_smiling_face:. For my oven it was PHASE_OVEN_ENERGY_SAVE = 3084, but my microwave oven combo is missing everything. They could be mapped onto oven, or would it be a better idea to create a new constant altogether?
I also found ID's for washing machines, but they sadly don't match by a factor 10 (and maybe some modifier?). I couldn't find any code on how they are mapped. Maybe they can be useful in another way:
laundry_care_ids.txt

Hi, this is really interesting!
Thanks!
May I ask where did you find these values? 😄

Hi, this is really interesting! Thanks! May I ask where did you find these values? smile

Hi, from the Miele app!
I decoded the app with apktool d, then used this tool to unpack the xamarin blob. Finally I used an ILSpy fronted for linux to decompile the dll's. That last part was the hard part. I probably should've done that on Windows with a better frontend.

Wow! Thanks a lot :D

Stale issue - closing


chore: cleanup unused code

#46
#45
#44
#43
#42  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @jakim929 and the rest of your teammates on  Graphite


Improve error message for failed risk check because of missing internet / server timeout

Avoid duplicates

[ ] This enhancement request has not already been raised before
[ ] Enhancement request is specific for iOS only, for general issues / questions that apply to iOS and Android please raise them in CWA-Wishlist
[ ] If you are proposing a new feature, please do so in CWA-Wishlist

Current Implementation

The risk check consists of two phases:
(1) download the key files from the server.
(2) match the keys with the locally captured exposure traces (ENF) and post-process the resulting exposure windows.
If the first phase fails, I get a generic error message that the check failed, and the suggestion to retry. No hint in which phase the error happened.
Suggested Enhancement

The error message should indicate that it was the download that failed. In addition to a retry, the suggestion should be also to check the internet connectivity.
Expected Benefits

Better support for trouble-shooting for the user.
Note: I don't think that a hint to check internet is "too technical" for not-so-technical users (let's take my grandma). In most cases she will know somebody who supports her, and this person can act on the suggestion and check her internet, even with no deeper knowledge of cwa.
Example of current behavior
I give a detailed example with screenshots of the current behavior below in the comments.
(cwa 2.17.1 / iOS 15.1 / iPhone 13 pro).

Example of the current behavior
(cwa 2.17.1 / iOS 15.1 / iPhone 13 pro)
(1/4) This morning when I checked-out cwa, I saw an error message of the failed risk check, and the suggestion to retry.

(2/4) So I pressed the retry button, and it started the download. But then I again got the same error message. And now the retry button did not even have any visible effect.

(3/4) I had seen this behavior before, and I know that closing cwa and swiping it out of memory can recover the button. I did this, and could trigger the risk check - but again it failed with the same error message.

(4/4) Finally I noticed that our router had been down last night, and there was WLAN coverage but no internet.
So the remedy was to restart WLAN on my device.
An error message with more details would have helped me a lot.

I just noticed that the error message already contains a hint on the phase that failed
"Abgleich mit dem Server ist fehlgeschlagen..."
😅😅
So my request boils down to add a (more prominent) suggestion to check the internet

Thanks for your report @ndegendogo. We have created an internal ticket for it and will raise this topic internally.
Internal Tracking ID: EXPOSUREAPP-12057

Corona-Warn-App Open Source Team

will set to obsolete as the effect is only until  31.4.2023


+Added text entry date time based upon jQuery-Timepicker-Addon:

https://github.com/trentrichardson/jQuery-Timepicker-Addon
+Implemented combo button visualization
+Updated radio button to show currently selected value

Handled in separate PRs


Laravel: Invalid resource type: unknown type

Hey
I never had problems with uploading files but my laravel project started throwing this error everytime I upload a file: Invalid resource type: unknown type
The thing is, the actual file DOES get uploaded without any problems, but the error is still thrown.
The function throwing the error is: 'stream_for'.
When I dump the resources in the function, I get this:

The error is thrown at the last one (obviously), which is a closed resource.
What I suspect is that the resource is being closed too soon (or before the request is being made).
If I dump the types of these resources:

hence the 'unknown type' error.
Any idea on how to fix this?
ps: I never had this issue before, it worked without a problem for weeks...

Seems like a Guzzle update caused this problem... reverted back to older version to get rid of this error

What versions. If this is within the same major version, this is a bug, and should remain open.

Wonder if it's guzzle or PSR-7 issue though. I recall seeing some similar issues related to php://temp.

No worries, it was a mistake on my part... I change some of the code of 1 method and forgot about it.
I should always overwrite methods instead of changing the original ones... :D my bad, sorry for false positive issue!


[BUG] Interface 'Browser' incorrectly extends interface 'BrowserContext'

Environment

chrome-aws-lambda Version: 5.2.0
puppeteer / puppeteer-core Version: 5.2.1
OS: Mac
Node.js Version:  12.x
Lambda / GCF Runtime: nodejs12.x

Expected Behavior
TypeScript should compile without mismatched interface
Current Behavior
Upon compile, it seems interface Browser isn't typed properly.
node_modules/@types/puppeteer/index.d.ts:1814:18 - error TS2430: Interface 'Browser' incorrectly extends interface 'BrowserContext'.
  The types returned by 'targets()' are incompatible between these types.
    Type 'Promise<Target[]>' is missing the following properties from type 'Target[]': length, pop, push, concat, and 26 more.

1814 export interface Browser extends EventEmitter, TargetAwaiter {

Steps to Reproduce
{
  "devDependencies": {
    "@types/node": "^12",
    "@types/puppeteer": "3.0.1",
    "@typescript-eslint/eslint-plugin": "^3.6.1",
    "@typescript-eslint/parser": "^3.6.1",
    "aws-sdk": "^2.725.0",
    "eslint": "^7.4.0",
    "puppeteer": "^5.2.1",
    "typescript": "^3.9.7"
  },
  "dependencies": {
    "chrome-aws-lambda": "5.2.0",
    "puppeteer-core": "5.2.1"
  }
}

import chromium from "chrome-aws-lambda";
export async function example(): Promise<void> {
  const browser = await chromium.puppeteer.launch({
    executablePath: await chromium.executablePath,
    args: chromium.args,
    defaultViewport: chromium.defaultViewport,
    headless: chromium.headless,
    ignoreHTTPSErrors: true,
  });
}

Possible Solution
I'm honestly not sure if this is a bug or I'm doing something wrong. Please advise.

I'd be keen to help out with this if you can point me in the right direction.

I'm running into the same bug.  I'm new to typescript so I'm not exactly sure what is going on here, but simply commenting the block out in node_modules/chrome-aws-lambda/source/index.d.ts gets things building again (which I imagine is not the correct fix):
// declare module 'puppeteer' {
//   export interface Browser extends BrowserContext {
//     /**
//      * Returns a new page overloaded with browser-context methods.
//      *
//      * @param hooks - Optional hooks to apply on the new page.
//      */
//     newPage(...hooks: ((page: Page) => Page)[]): Promise<Page>;
//   }

//   export interface Page extends Chromium.Page {}
//   export interface Frame extends Chromium.Frame {}
// }

I'm running into the same bug.  I'm new to typescript so I'm not exactly sure what is going on here, but simply commenting the block out in node_modules/chrome-aws-lambda/source/index.d.ts gets things building again (which I imagine is not the correct fix):
// declare module 'puppeteer' {
//   export interface Browser extends BrowserContext {
//     /**
//      * Returns a new page overloaded with browser-context methods.
//      *
//      * @param hooks - Optional hooks to apply on the new page.
//      */
//     newPage(...hooks: ((page: Page) => Page)[]): Promise<Page>;
//   }

//   export interface Page extends Chromium.Page {}
//   export interface Frame extends Chromium.Frame {}
// }

Ok, thanks. I'll take a look at this hopefully within 12 hours

It seems like #157 could be a part of the problem (without using that branch with puppeteer-core 5.2.1 I got a unable to resolve module error when deployed to GCF), but it also looks like there could be an issue with the puppeteer types:
https://github.com/DefinitelyTyped/DefinitelyTyped/blob/736981c8f81a1c483abb50392c1d925cad03ad9e/types/puppeteer/index.d.ts#L1883-L1884
This typing doesn't seem to align to https://pptr.dev/#?product=Puppeteer&version=v5.2.1&show=api-browsertargets, which says that the correct return type is of Target[] instead of Promise<Target[]>.
Changing<EMAIL_ADDRESS>line 1884 to   targets(): Target[]; does get tsc happy as well.
Unfortunately, I still haven't gotten anything to work on Google Cloud Functions...  (I'm trying to use chrome-aws-lambda, puppeteer-extra, puppeteer-cluster, and TypeScript and it just isn't quite coming togeter...

Thanks for the extra info. Unfortunately I haven't had a chance to look at this.
I'll be able to spend some limited time on this starting tomorrow (it's Friday today in Australia).
I'll let you know how I go ASAP.

@benlongmire This should be handled now on the latest version (5.2.1).
The problem is @types/puppeteer is still lagging behind and puppeteer haven't yet shipped their typings. 🤷🏻♂


New strings for pt-BR language

Hi!
This adds the new strings for pt-BR.

Wow! That was fast
You're awesome


Mediation Adapters Updates and Pangle Consent Settings

Mediation Adapters Updates:
I would like to inquire about the update schedule for mediation adapters, specifically for Pangle, InMobi, Liftoff, and Meta. Can you provide information on when these adapters were last updated and the estimated dates for future updates?

Pangle Consent Settings:
I couldn't find the consent settings for Pangle in my Xcode iOS project. As a result, I set up the consent manually using the MethodChannel approach. However, the Ad Inspector still shows "no user consent provided".

My question is: How can Google Mobile Ads be aware of the consent information I manually provided to Pangle? Do you have any suggestions on how to resolve this issue?
Thank you for your assistance.

Hi @t3chno,

Those mediation adapters will have rolling updates in the coming weeks. Release information can be found on PubDev (For example, Meta's package url is https://pub.dev/packages/gma_mediation_meta). Estimating future updates are inherently difficult to have a predicable cadence as it depends on the third-party. That being said, we will try out best to update them after the third-party has updated their adapter.

Have you added Pangle as an ad partner in the AdMob UI? It's possible you have everything set up correctly but you need add the ad partner for consent to apply to them.

Hi @malandr2 ,
Thank you very much for your valuable feedback.

Regarding the mediation adapters updates:
We appreciate the information about the rolling updates in the coming weeks. We'll be sure to monitor the updates on PubDev. We understand that a precise schedule can't be provided due to third-party dependencies. If the updates take longer than expected, we might consider forking the code and making necessary changes ourselves as an option. However, for now, we'll continue to wait patiently. Thank you for your efforts on this.

Concerning the Pangle consent settings:
Your suggestion worked and solved our issue. We had overlooked adding Pangle as an ad partner in the AdMob UI. Thank you for this reminder. It was a small but crucial step that we should not have missed.

Once again, we appreciate your help and prompt response. This information is invaluable for our project.


add audio support

Now it's possible to download not only video but audio as well as resample the audio (currently supports output="files"). Audio is being saved as .mp3 file.

@marianna13 please let's try to keep this as small as possible, no unnecessary changes to other components, if you think something else should be changed let's discuss over discord and then make a different PR. If this PR is about "audio support" then the changes in the diff should reflect integrating audio support and not refactoring how we access the video link

I changed things significantly so I'm afraid this will need to be redone
could you try to implement these features:

reading local mp3 files
reading audio from yt-dlp

it would be great!

Sure!

Does it need to support only mp3 or other audio formats as well?
What do you mean by "reading audio from yt-dlp"? I can extract audio link (m4a or mp3 or whatever) and download audio from it or I could just download audio with yt-dlp.

all sounds great, but I figure start with something minimal and then we can expand on top

@marianna13 remember to merge in main

does this work fast?

Speed test (1 video, on CPU cluster):

only video (mp4): 8.223158836364746 seconds
only audio (mp3): 8.929118394851685 seconds
video + audio (mp4, mp3): 8.74603796005249 seconds

Lgtm

There's a few typos and bad variable names but not a big deal


estimate_probability_two_random_records_match fails in debug_mode

Possibly other methods also - root cause in _count_comparisons_generated_from_blocking_rule.
This occurs in chdb and Clickhouse server.
Issue is from here: select *, count_l, count_r, count_l * count_r as block_count from ... - engine is unhappy we are asking for count_l (and count_r) twice - once implicitly in *-expression, and once explicity.
As this only appears in debug_mode presumably the engine can handle this when it's part of a CTE. I think (though haven't looked closely) that we don't actually refer to these columns later in the pipeline, so I guess these selections are optimised away and hence never cause trouble.

I'm sure at some point I had written some kind of SQL-interception to handle this - I guess I forgot what the root cause was so ditched it at some stage.

I'm sure at some point I had written some kind of SQL-interception to handle this - I guess I forgot what the root cause was so ditched it at some stage.

Ditched in this commit for Clickhouse server - not sure I ever included for chdb

Easily fixed, but might be a case for adjusting upstream for clarity anyway


Fix brackets in the train.yaml file

The syntax for optional inputs command in yaml from [] to $[[]], as [] conflicts when using shell command with condition expression(s).
PR into Azure/mlops-v2
Checklist
I have:

[x] read and followed the contributing guidelines

Changes
Change the syntax for optional inputs command in yaml from [] to $[[]]. The fomer approach conflicts when using shell commands with conditional expressions.

@setuc @cindyweng what is the state of this pr request? The fix looks good and I've tested it independently but it isn't clear what checks are failing.