Tyler branch

Merging pull request from Tyler, which includes:

GPU/CUDA Engine
Game of Life CA
Invasive Species Dispersal CA
Several other improvements/bug fixes.


Code is not theme-agnostic

I would like to use this repository, but I would be unable to do so without overwriting several styles, because the styles are coupled to a default theme. Has any thought been put to having a file of "theme-agnostic" code, and a file with the default theme? A minimal definition of theme-centric properties inlcude any assignment of color.
Example:
wtf-forms.css
.control {
  position: relative;
  display: inline-block;
  cursor: pointer;
}

wtf-forms-theme.css
.control {
  padding-left: 1.5rem;
  color: #555;
}

Just adjust the default styles? Shouldn't be difficult to merge any future changes anyway. Decoupling in this case seems to provide unnecessary complexity rather than benefit in my opinion.

Okay. Will this repo still be maintained separately if the concept is
merged into Bootstrap?
On Feb 12, 2015 3:54 AM, "Rasmus Eriksson"<EMAIL_ADDRESS>wrote:

Just adjust the default styles? Shouldn't be difficult to merge any future
changes anyway. Decoupling in this case seems to provide unnecessary
complexity rather than benefit in my opinion.
—
Reply to this email directly or view it on GitHub
https://github.com/mdo/wtf-forms/issues/48#issuecomment-74044470.

Yeah, it'd be nice to decouple things more. This was more an exploration than anything else though and a cut-and-dry approach isn't all that useful or practical. For example, you might say border is presentation/theme, and I might say it's structural because it defines the boundaries of an element.
I'd suggest simply modifying the default styles for now.
@iosulfur Most likely, yes.


Annoying ecbuild warning message from ecbuild

This is not really important (and is part of #7) but I thought I'd ask @tclune and @aerorahul about it.
During the cmake step we see:
CMake Warning at @cmake/@ecbuild/cmake/ecbuild_log.cmake:158 (message):
  WARN - The linker does not support $ORIGIN at link-time, disabling
  dynamic symbol check when linking against shared libraries
Call Stack (most recent call first):
  @cmake/@ecbuild/cmake/ecbuild_check_os.cmake:295 (ecbuild_warn)
  @cmake/@ecbuild/cmake/ecbuild_system.cmake:245 (include)
  @cmake/esma.cmake:15 (include)
  CMakeLists.txt:33 (include)

Now, we can set ECBUILD_LOG_LEVEL=ERROR and we'd not see this. The question is: Should we? @aerorahul Does the JEDI project have an official thought on what level of ecbuild logging to use?

No - I don't think we should.   I just did a PR which is going to be very noisy with WARNING and want to use those to go (gradually) update all the places where things have gotten deprecated.   I suppose we could make it the default for regular users though.
Hiding DEBUG and INFO level is probably fine by default.
@aerorahul Your opinion?

@mathomp4 the -DECBUILD_LOG_LEVEL variable is typically set to its default value (OFF).
Anyways, the log is to debug/print info within ecbuild via MESSAGE command.  It is not a true CMake debug.
We (I) only use the debug when I am adding my own FindXYZ.cmake or updating a macro.  I don't think the JEDI project goes into ecbuild logging as part of their everyday development.

I don't have a really strong opinion, but OFF seems like it would hide issues for quite some time.   If WARNINGs don't really matter, why did anyone bother with the logic in the first place ...

Or, I suppose why

@mathomp4 the -DECBUILD_LOG_LEVEL variable is typically set to its default value (OFF).
Anyways, the log is to debug/print info within ecbuild via MESSAGE command. It is not a true CMake debug.

Actually, it looks like the default value is actually INFO:
if( NOT DEFINED ECBUILD_LOG_LEVEL )
  set(ECBUILD_LOG_LEVEL ${ECBUILD_INFO})

And INFO is the level just above DEBUG so we get most everything.


Project doesn't build locally without TypeScript Compiler on path

After cloning the repo, a local build causes two errors (in ChatSample and SocketsSample) when you don't have tsc on your path.

You can install it with:
 npm install -g typescript as globally so if you dont have npm (node package manager) you can install it from this url with below configurations then IDE or Editor restart may required!

You bet @gencebay, already PR'd to the readme.  @anurse asked me to file this so they can determine if they want to fix the error at a project level or via docs.


Update dependenciesWhitelist.txt to add objection

objection library is an external library that provides typings.

How to link to the DefinitelyTyped PR using this?
URL of my PR is: https://github.com/DefinitelyTyped/DefinitelyTyped/pull/25886

Could you link to the DefinitelyTyped PR using this?

@andy-ms could you please elaborate what do you mean?


parse does not parse escape codes, but stringify escapes backslashes

Describe the bug
Round-tripping a graph through parse and stringify ends up turning all literal \n into \\n.
To Reproduce
const inputGraph = `\
digraph {
  a [
    label="Hello\\nWorld!";
  ];
}`;
console.log(inputGraph);
const ast = parse(inputGraph);
const outputGraph = stringify(ast);
console.log(outputGraph);

Expected behavior
I expect the two console.log statements to print the same dot code (ignoring whitespace).
Instead, what is printed to the console is the following:
digraph {
  a [
    label="Hello\nWorld!";
  ];
}
digraph {
  a [
    label = "Hello\\nWorld!";
  ];
}

Additional context
Internally, the AST stores the attribute value as separate backslash and n characters. Then stringify escapes the backslash character. This can be fixed in two ways: either parse turns \n in the dot source into a newline character in the AST's string, or stringify stops escaping.
A workaround is to replace all \\ in the output of stingify with a single \.
Thank you for the library, by the way!

Hi, @haved
Thank you for reporting this issue and providing a detailed explanation along with steps to reproduce it. We appreciate your feedback and are glad to hear that you're finding the library useful.
We've investigated the problem you've described regarding the inconsistent handling of escape sequences when parsing and stringifying DOT graphs—specifically, the issue where a literal \n turns into \\n after round-tripping through parse and stringify.
To address this, we've created PR #1204, which introduces a new escape function to correctly handle string escaping in the DOT language. This fix ensures that characters like \n, \r, and \" are properly managed, preserving the intended formatting of your graphs.
The PR is currently under review, and we expect to release it soon. We believe this update will resolve the inconsistencies you've encountered.
Your detailed report was instrumental in identifying and fixing this issue. Once again, thank you for your valuable contribution to improving the library. If you have any further questions or run into any other issues, please don't hesitate to let us know.
Best regards,
kamiazya

@all-contributors please add @haved for bug


[VL] Fix linking simdjson error when building benchmark

What changes were proposed in this pull request?
As simdjson dependency is linked to libvelox.so, we don't need to specify it in dependency when building benchmarks. Also, found BUILDING_BENCHMARKS needs BUILDING_TESTS=ON due to the lack of a velox dependency. Just made them independent.
How was this patch tested?
Local test and modified static build CI to cover this.

===== Performance report for TPCH SF2000 with Velox backend, for reference only ====

query
log/native_3960_time.csv
log/native_master_12_11_2023_71ec720d4_time.csv
difference
percentage

q1
33.28
32.10
-1.185
96.44%

q2
26.09
24.79
-1.298
95.03%

q3
36.23
38.42
2.193
106.05%

q4
40.62
39.90
-0.713
98.24%

q5
72.03
72.41
0.377
100.52%

q6
5.29
7.02
1.731
132.74%

q7
86.42
85.38
-1.037
98.80%

q8
85.81
86.65
0.835
100.97%

q9
121.52
126.76
5.231
104.30%

q10
45.62
46.79
1.172
102.57%

q11
19.66
20.34
0.683
103.48%

q12
25.85
26.95
1.103
104.27%

q13
46.17
45.56
-0.610
98.68%

q14
18.66
18.31
-0.355
98.10%

q15
27.25
27.78
0.526
101.93%

q16
15.45
15.83
0.378
102.45%

q17
103.30
101.57
-1.729
98.33%

q18
150.96
151.54
0.587
100.39%

q19
15.38
12.91
-2.472
83.93%

q20
27.79
26.84
-0.949
96.59%

q21
224.25
228.06
3.816
101.70%

q22
13.96
13.81
-0.153
98.90%

total
1241.57
1249.71
8.131
100.65%


FUSETOOLS2-2440: Saving artefacts in Camel Version pipelines doesn't use camel version in name

commit message needs to be updated


Fix scope issue on convert_duration_to_seconds

Was having an issue with this locally, this seemed to correct it.  Tests pass but not sure if this is included in coverage.

Very odd. I've added a test to capture that specific code path. Even though the previous version should not work (the method was defined on parent module, not on the class), it does for me.
Your updated version works and is what I intended to write originally. Thanks for this! :confetti_ball:

@jnraine Could we get a new release cut for this? It's been over a year and this is still broken in the gem. In event that uses a duration without an end_date will have this problem.
Thanks!!

@ericboehs yikes, a year already? How time flies. Bumped and pushed. Enjoy!


Improve resource management

This PR improves the resource accounting setup, fixing a connection-related memleak and gracefully shutting down the ledger reader thread upon shutdown.
It also isolates a snarkos-utils crate which can host code applicable to any workspace member which might not depend on snarkos (in this case storage, but also e.g. the network crawler node impl).

In a future PR I'd like to extend this setup with named resources, which will allow us to shut the node down more quickly. I've already started prototyping it, but wouldn't want to enlarge this PR any further.

Rebased.


Scc

Remove component Join

Pull Request Test Coverage Report for Build 29

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.04%) to 87.538%

Totals

Change from base Build 28:
-0.04%

Covered Lines:
188

Relevant Lines:
206

💛  - Coveralls


Calling "New Page" fails after creating the context using "New Persistent Context" with recordVideo argument

Describe the bug
If the context is created using New Persistent Context and video recording is wanted by giving recordVideo argument a call to New Page using that context will fail.
To Reproduce
*** Settings ***
Library    Browser

*** Test Cases ***
Record Video with Browser.New Persistent Context
    &{recordVideo}=    Create Dictionary    dir=${OUTPUT_DIR}/videos
    Browser.New Browser    headless=False
    Browser.New Persistent Context    recordVideo=${recordVideo}
    Browser.New Page    https://google.com

Expected behavior
The call to New Page succeeds without any errors, taken that the arguments are correct.
Screenshots

Desktop (please complete the following information):

OS: Windows
Chrome
Browser library version 13.3.0

Additional context
The bug is in new_persistent_context method as it does not store the context uuid with the video size to the context_cache, as new_context does. And, _embed_video method called by new_page is expecting the video's context uuid to be in the context_cache to get the size of the video. This could be fixed by adding this call for example to the end of new_persistent_context method:
self.context_cache.add(response.id, self._get_video_size(params))

@mkorpela at al. Anyone looking into this? The bug is still valid with the latest versions:
robotframework==6.0
robotframework-browser==14.2.1


[Feature] Nonportable bucket maintenance

Feature Request
Is your feature request related to a problem? Please describe.
@TheRandomLabs has been absent for over a year, and most of his buckets are just maintained by CI. New PRs are not being reviewed for a long time, and as nonportable is an official bucket, I think this calls for a maintenance change.
Describe the solution you'd like
Move/Fork the nonportable bucket to this organization.
Describe alternatives you've considered
Or maybe someone active can take over the bucket.

I sent a ticket to Github to detach this repo from TheRandomLabs/scoop-nonportable.

As of https://github.com/ScoopInstaller/Scoop/releases/tag/v0.2.1, the buckets URL has been updated to point to this repo, and as such, this is now resolved.


Add unit tests on RDD class

added more tests with my last PR. but still not 100% covered.

I added coveralls to track test coverage here:
https://coveralls.io/github/wdm0006/DummyRDD


bitcoin: make Value.add/sub fluent

This commit allows these two functions to return self so the methods can be used in a fluent style. This simple fix allows for easier math operations such as:
const inputValue = Value.fromSats(10000);
const fees = Value.fromSats(255);
const outputValue = Value.zero().add(inputValue).sub(fees);

Closes #251

Codecov Report
Base: 94.03% // Head: 94.04% // Increases project coverage by +0.00% :tada:

Coverage data is based on head (b778e83) compared to base (cd4515b).
Patch coverage: 100.00% of modified lines in pull request are covered.

:exclamation: Current head b778e83 differs from pull request most recent head 49e4750. Consider uploading reports for the commit 49e4750 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #254   +/-   ##
=======================================
  Coverage   94.03%   94.04%
=======================================
  Files         197      197
  Lines        5401     5403    +2
  Branches      649      649
=======================================
+ Hits         5079     5081    +2
  Misses        179      179
  Partials      143      143

Impacted Files
Coverage Δ

packages/bitcoin/lib/Value.ts
96.42% <100.00%> (+0.27%)
:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Add logging to upgradeable and file secret store

cc @keybase/y2ksquad

cc @zapu how does this look? want to add anything to the logs?


soc: arm: nxp: ke1xf: add option for keeping watchdog enabled at boot

Add option for keeping the watchdog timer of the NXP Kinetis KE1xF SoC series enabled at boot with a configurable, initial timeout.
This removes the risk of failure from when z_arm_watchdog_init() disables the watchdog timer until the application code configures a timeout and re-enables the watchdog timer.
Signed-off-by: Henrik Brix Andersen<EMAIL_ADDRESS>

Need to rebase and fix the merge conflict

@MaureenHelm Thanks for reviewing. Rebased.


code not working

Message: TypeError: chats[i]._values is undefined
Failed to get unread messages

Hi can you attach a screenshot of what exactly you've done so that I can take a look at it!

Some more description would be helpful!


On posts, the feature image width 100% seems to be overridden

Description
First of all, love your work. Using a couple of your themes in my projects, thanks!
Not sure when I noticed this, but it seems that the img width 100% is getting overridden. Screenshot of the Dev Console:

I'm not great at debugging CSS but when I set width 100% the image spans the screen on desktop.

Environment

So Simple version: jekyll-theme-so-simple 3.1.1
Ruby gem or remote theme version:
Jekyll version: 3.8.3
Git repository URL: https://github.com/justwriteclick/docslikecode
Operating system: MacOS 10.13.6
GitHub Pages hosted (if yes provide URL to site): Netlify, https://docslikecode.com

Expected behavior
I like the image spanning the entire window, as shown below in the screenshot. Could you take a look?
Steps to reproduce the behavior
Current look:

Desired outcome:

Yup, looks like setting width: 100% to those images will scale them up. Potential downside of doing this would be that it will emphasize artifacts due to smaller (lower quality) images being enlarged.
But the following will do the trick if you want to keep it isolated to just cover images.
.page-image {
  img {
    width: 100%;
  }
}

Are you sure you're using the latest version of the theme and not overwriting any of the Sass (CSS)?
I just checked the theme's demo site and feature images are correctly getting width: 100%. When I checked "docs like code" site I'm not seeing that.

Looking at the DLC source I see this, which would imply it's using an much older version that likely doesn't have the feature image fix.
<!--
  So Simple Jekyll Theme 3.0.1
  Copyright 2013-2018 Michael Rose - mademistakes.com \| @mmistakes
  Free for personal and commercial use under the MIT license
  https://github.com/mmistakes/so-simple-theme/blob/master/LICENSE
-->

Gemfile.lock is showing the older theme gem too. Run bundle update and then verify it's at 3.1.1 and the problem should be fixed for you.


chore(release): create release v0.9.1

[x] I have cherry-picked any changes labelled needs-cherry-pick-vX.Y.Z

[x] I have made all of the following version and patch updates:

Updated the container image tag in charts/osm/values.yaml
Updated the chart and app version in charts/osm/Chart.yaml
Updated the image tags used in the demo manifests
Regenerated the Helm chart README.md

[x] I have checked that the base branch for this PR is correct as defined by the release guide

Is this a release candidate?

Codecov Report

Merging #3719 (ce1689b) into release-v0.9 (1e6e494) will increase coverage by 0.02%.
The diff coverage is n/a.

@@               Coverage Diff                @@
##           release-v0.9    #3719      +/-   ##
================================================
+ Coverage         66.51%   66.54%   +0.02%
================================================
  Files               169      169
  Lines              7945     7945
================================================
+ Hits               5285     5287       +2
+ Misses             2627     2625       -2
  Partials             33       33

Flag
Coverage Δ

unittests
66.54% <ø> (+0.02%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

cmd/cli/mesh_upgrade.go
45.83% <ø> (ø)

pkg/ticker/ticker.go
70.66% <0.00%> (+2.66%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1e6e494...ce1689b. Read the comment docs.


ItemUtil.compareItems showing different data for the same items

(Required) What is your Quests version / build number (do not say "latest")?
3.4.6
(Required) Please describe the problem and how to replicate it. Any console errors?
Create an Item for an Event using while holding one cocoa bean, give it a display name of Kitty Litter
Create a Quest with a Stage where you need to deliver this same item to an npc.
Add a breakpoint for the onNPCRightClick function in the NPCListener class, and step into ItemUtil.compareItems.
The items show that they have the same meta data, but their data is different, one shows Black Dye(0) the other shows LEGACY_INK_SAC(3).  I'm not sure that getData is even supposed to be used any more with the changes to materials. (It doesn't appear to be deprecated)
(Optional) Can you provide an example quest from quests.yml using Pastebin.com?
here is the quest in quests.yml
https://pastebin.com/00cYkbgw
Here is the event
https://pastebin.com/8Frk0RHx

This is the first time I've used Quests, starting with 1.13.
I used the commands within Minecraft itself to define the item for both the event and the Quest/Stage.
So I'm not sure what you mean when you mention updating the names.
I just tested your fix and it still does not work.
Perhaps you can do something similar to other plugins I've come across, regarding handling functions differently, based upon which version of Minecraft is being used.
You can throw something like this into one of your utility classes:
	public static final boolean v1_8, v1_9, v1_10, v1_11, v1_12, v1_13;

	static {
		String vers = Bukkit.getBukkitVersion(); // Returns in format like: 1.12.2-R0.1-SNAPSHOT
		v1_13 = vers.startsWith("1.13");
		v1_12 = vers.startsWith("1.12") || v1_13;
		v1_11 = vers.startsWith("1.11") || v1_12;
		v1_10 = vers.startsWith("1.10") || v1_11;
		v1_9 = vers.startsWith("1.9") || v1_10;
		v1_8 = vers.startsWith("1.8") || v1_9;
	}

Then, in your ItemUtil class you would reference the versions from the above:
	public static int compareItems(ItemStack one, ItemStack two, boolean ignoreAmount) {
		if (one == null || two == null) {
			return 0;
		}
		if (one.getType().name().equals(two.getType().name()) == false) {
			return -1;
		} else if ((one.getAmount() != two.getAmount()) && ignoreAmount == false) {
			return -2;
		} else if (!v_13 && one.getData().equals(two.getData()) == false) {
			return -3;
		}
		if (one.hasItemMeta() || two.hasItemMeta()) {
			if (one.hasItemMeta() && two.hasItemMeta() == false) {
				return -4;
			} else if (one.hasItemMeta() == false && two.hasItemMeta()) {
				return -4;
			} else if (one.getItemMeta().hasDisplayName() && two.getItemMeta().hasDisplayName() == false) {
				return -4;
			} else if (one.getItemMeta().hasDisplayName() == false && two.getItemMeta().hasDisplayName()) {
				return -4;
			} else if (one.getItemMeta().hasLore() && two.getItemMeta().hasLore() == false) {
				return -4;
			} else if (one.getItemMeta().hasLore() == false && two.getItemMeta().hasLore()) {
				return -4;
			} else if (one.getItemMeta().hasDisplayName() && two.getItemMeta().hasDisplayName() && ChatColor.stripColor(one.getItemMeta().getDisplayName()).equals(ChatColor.stripColor(two.getItemMeta().getDisplayName())) == false) {
				return -4;
			} else if (one.getItemMeta().hasLore() && two.getItemMeta().hasLore() && one.getItemMeta().getLore().equals(two.getItemMeta().getLore()) == false) {
				return -4;
			}
		}
		if (one.getEnchantments().equals(two.getEnchantments()) == false) {
			return -5;
		}
		if (one.getType().equals(Material.ENCHANTED_BOOK)) {
			EnchantmentStorageMeta esmeta1 = (EnchantmentStorageMeta) one.getItemMeta();
			EnchantmentStorageMeta esmeta2 = (EnchantmentStorageMeta) two.getItemMeta();
			if (esmeta1.hasStoredEnchants() && esmeta2.hasStoredEnchants() == false) {
				return -6;
			}
			if (esmeta1.getStoredEnchants().equals(esmeta2.getStoredEnchants()) == false) {
				return -6;
			}
		}
		return 0;
	}

I just implemented the above change locally and this fixes my issues with acquiring the quest through the gui and completing the delivery of the item.
This still leads to an issue with the reward. One other issue I've noticed, your representation of item meta data does not allow for specifying ItemFlags. (If I want to hide enchants on custom items, for example)
I can open that as a separate issue.

I see. Often times players upgrading from pre-1.13 files experience these issues, since many of the Material names have changed. Anyway, sorry to hear the patch didn't work. The recent death of VaultAPI is proving a challenge to work around.
There are a couple of concerns I have with the fix you've suggested. Firstly, there is no future proofing; it is my goal to minimize the amount of work that needs to be done for each protocol change. As it stands, only the NPC particle code must be updated per MC release and I'd prefer to keep it that way.
Secondly, the issue at hand indicates a deeper underlying problem, because even though getData() is unnecessary for 1.13+ materials, it should still return the same value for both items. Something along the way is producing different values for the same item (as well as the item name itself).
ItemFlag support would be a welcome addition. I see you've submitted #558 and will look at that shortly.

Well, I’m sure you’re aware that Spigot had a major overhaul to item names in 1.13 to match the material names used by mojang.  Not to mention the removal of data, because all items and blocks have their own material now.
I was under the impression that the behavior of getData in 1.13 was described as volatile or undefined.  Between creating different implementations or checking the version directly I don’t see how you can avoid the issue.  I did not see anything in your serialization that would allow me to specify what to assign to the data value.
Perhaps you could add a config flag that would indicate whether or not the data should be compared or used?

That's correct, and while the correct fix is to either manually update item names in the files or remake the quest through the editor, the temporary fix from the Spigot team is to prepend "LEGACY_" to any given item name that you wish to indicate is from the 1.12 naming scheme. However, I've been slow on taking advantage of this, hence e363cd4
LEGACY_ materials are deprecated in the same sense that getData is. It's simply a temporary way to maintain compatibility with older MC protocol and will undoubtedly be removed one day. When that day comes, Quests (and many other plugins) will have no choice but to cease supporting older protocol.
The things with getData is, it should return '0' on all 1.13 items, but you said that one cocoa bean is showing up as "LEGACY_INK_SAC(3)" which indicates that getData returned '3' instead. And since you say you have only started using Quests with 1.13 (so there's no way you made any of your quests pre-1.13), that tells me there is something deeply wrong with how Quests is processing your data.
Disabling material comparison would not be advisable. Let's say you want someone to deliver a enchanted Bow with lore to an NPC. If comparing items were disabled, nothing would stop the player from delivering a plain ol' Bow to complete the quest. The opposite is also true - a player might accidentally deliver a "rare" bow to an NPC that only needs a regular one.
On that note, I'll be pushing a commit shortly which address the ItemFlag thing. If you'd like to discuss that post-commit, please open a new issue about ItemFlags.

Right, I was simply referring to the data portion.

Likely duplicate of #402
I've come to realize the issue. The getData method at your breakpoint is indeed the problem. However, the values aren't wrong... that line of code should actually be using getDurability. Perhaps my brain is stuck back in Indev, when item IDs were commonplace and durability was commonly known as the data value, which caused me to mistake one method for the other.
Interestingly, the old Blackvein repo (from which this one was forked), has the getData method present, so it wasn't me whom introduced this bug. I'm unsure if maybe the Bukkit or Spigot team reused naming, or if this just wasn't an issue before, but regardless the method now refers to MaterialData which is not something we need to be checking (but hence why getData isn't deprecated).
The following commit and dev build will resolve the issue. Thanks for your patience!

http://ci.ac3-servers.eu/job/Quests/543/


bug: Folder structure issue

From @RIanDeLaCruz on February 11, 2016 13:42
Type: bug
Ionic Version: 2.x
Platform: all
Based on the documentation, the app folder should be inside the www folder. Instead, when I create a project, the app and www folders are siblings in the root folder.

Copied from original issue: driftyco/ionic#5412

From @adamdbradley on February 11, 2016 14:47
Sorry, we must have our docs outdated. Which page are you seeing that on? cc @mhartington

I am seeing it here: http://ionicframework.com/docs/v2/theming/theming-your-app/
and here: http://ionicframework.com/docs/v2/theming/overriding-ionic-variables/

Updated via https://github.com/driftyco/ionic-site/commit/b5492af9715baf1a68f8c8f646f0575ec5879ebf


Change fl.Slicing Implementation

The current interface for fl.Slicing currently has two flaws:
-> It follows Pytorch's  .narrow interface, which is confusing.
-> It cannot perform slices with implicit lengths like this x[1:].
In this PR, I propose to make fl.Slicing follow more closely what we could expect from a slice method with dim, start, end, and step keywords.

I think there is still an off-by-one error:
>>> import torch
>>> import refiners.fluxion.layers as fl
>>> data = torch.randn(2, 1000, 400)
>>> slice = fl.Slicing(dim=1, start=1)
>>> slice(data).shape
torch.Size([2, 998, 400])
>>> data[:, 1:, :].shape
torch.Size([2, 999, 400])

I think there is still an off-by-one error @limiteinductive:
>>> import torch
>>> import refiners.fluxion.layers as fl
>>> data = torch.randn(2, 1000, 400)
>>> slicing = fl.Slicing(dim=1, start=1)
>>> slicing(data).shape
torch.Size([2, 998, 400])
>>> data[:, 1:, :].shape
torch.Size([2, 999, 400])

Good catch! The default for the end param should be None and not -1. PR incoming


Update for libvips v8.14.4 and bindgen 0.66.1

The libvips library has moved to the new meson + ninja builder. I couldn't wait for crate to update myself, so I thought I'd suggest a PR. Let me know if there are any issues with this PR here.

@augustocdias could you please review and merge it?

I also upgraded num-derive to 0.4 to go to syn 2. Now the minimum MSVR is 1.56.

looks good to me but I'm not part of the organisation anymore. I can't approve/merge PRs.
I don't know if you want to tackle this, but a mistake I did was pushing the generated bidings from bindgen to github instead of always generating on build time. This will cause issues on different platforms as types has different types in each. If you're running on docker or linux (and probably mac as well) this should be fine, but on windows this will certainly fail.

@negezor would you mind creating a new repo for libvips and publishing it to crates.io (e.g. as vips)?

@augustocdias Do you still have contact to someone from the olxgroup-oss organization? It would be nice if this repository could still be maintained (by the community). Perhaps someone could be given the necessary access rights to this repository.
Otherwise I think a fork (and republishing) is necessary. It looks like vips name is already taken so one would have to find a new one

@bassco Look like that's it. Perhaps I'll come back later, as libvips version 8.15.0 is just around the corner 😄

@negezor - I'll publish the crate in the next few hours once I get onto the work machine
cc @BogdanVidrean


LayerService Unit tests

Added unit tests to ensure proper functionality of LayerService interface. During testing a bug in ConfigurableFactory was discovered in which ConfigrableProperty paths were being overwritten due to non-unique ConfigrableProperty names used in the HashMap. ConfigrableProperties now contain a UUID string, and that string is used as the hash key to prevent collisions. Minor refactoring of AnnotationServiceTests was included.

That sounds reasonable, I will make the change.


Grid row negative margin

Isn't a grid <Row /> suppose to have negative margin to cancel the horizontal padding added by <Col />'s gutter?

Yes it is fixed sorry!

Awesome, I just noticed the commits.


fix: typo and chinglish optimization

@kevwan @anqiansong help review this PR. Thx.

@kevwan @jinrenjie @anqiansong @chenquan kindly help review this PR. Thanks.


Power ON UA55M5500

Can i power on that TV using this library ?
Or, how i can know that TV support wake-on-lan ?

I don't think it's possible to turn on your TV with this lib. I turn my TV on (KS8000) with a wake on lan (WOL) packet. See https://www.cyberciti.biz/tips/linux-send-wake-on-lan-wol-magic-packets.html for example

hey bro @nickyromeijn , thanks for your link ! Great ! now i can wake up / powering on my TV using tutorial from your link ! big thanks 😄


[Question] Is there a Roadmap?

Just curious! (not a request)

None at the moment as I work on this on my spare time. If you have a suggestion, feel free to open an issue.


Only linux release? Could release dll for windows?

with title

and tdlight-java use libtdjni-linux-x86_64.so.1.6.9 ?

TDLight Java already includes the tdjni libraries for each OS and architecture.
I Can't release the standalone .dll for windows but you can build it following tdlib build instructions: https://tdlib.github.io/td/build.html

I mean when I run example, it show exception, I think it need tdjni.dll


Missing license

It would be great if you could add a license to this project.
TODO: Add your license here.

Sure


Refactor blog-navigation settings screen

Better markup
Cleaner CSS
Fixed icon implementation
New grab handle icon
Better mobile styles

Don't merge yet - found bug

Fixed


OKD 4.12.0-0.okd-2023-02-04-212953 IPI installation on Azure fails consistently

Describe the bug

Installing OKD 4.12 into Azure consistently fails with:
FATAL failed to fetch Metadata: failed to fetch dependency of "Metadata": failed to fetch dependency of "Bootstrap Ignition Config": failed to fetch dependency of "CVO Ignore": failed to fetch dependency of "Openshift Manifests": failed to generate asset "Image": stable/x86_64: No azure build found

Previously with 4.11, I could work around this by uploading the FCOS image to a Storage Account, and setting the image override with:
export OPENSHIFT_INSTALL_OS_IMAGE_OVERRIDE=https://okdimages.blob.core.windows.net/vhd/fedora-coreos-37.vhd

This changes the error slightly, although the end result is the same:
FATAL failed to fetch Metadata: failed to fetch dependency of "Metadata": failed to fetch dependency of "Bootstrap Ignition Config": failed to fetch dependency of "Worker Machines": failed to generate asset "Release": stable/x86_64: No azure build found

Version

How reproducible

Always
Log bundle

install-fail-no-override.log - no image override set
install-fail-override.log - with image override set

Dupe of https://github.com/okd-project/okd/issues/13#issuecomment-564692550

@vrutkovs given that the workarounds previously stipulated for this no longer work, is it the same issue?


Update maven-bundle-plugin to latest version

The maven bundle plugin version 5.1.2 generates a corrupt zip header.
This closes #5157.

[ ] have a concise title
[ ] close an accompanying issue if one exists
[ ] be against the correct branch
[ ] include migration scripts and documentation, if appropriate
[ ] pass automated tests
[ ] have a clean commit history
[ ] have proper commit messages (title and body) for all commits

The source of all evil was bnd from bndtools. Here's the fix https://github.com/bndtools/bnd/issues/4507 from early 2021 and here's the Apache Felix bug report from four days ago: https://issues.apache.org/jira/browse/FELIX-6622


Update Nestjs dependencies

Update nestjs dependencies to latest version

+1, allow @nestjs/* at version 10

Hİ @liaoliaots.
I submitted a pull request (#517). Please check and update the npm package.
Thank you all.

Hey @chunkhang
What peer dependencies are you talking about? There are also changes to the pnpm-lock.yaml file. Which ones are missing?

@mahsumurebe i think these files:

https://github.com/liaoliaots/nestjs-redis/blob/fc697638af9ecf80ad2992a923047c626f2bf95b/packages/redis-health/package.json#L49-L53
https://github.com/liaoliaots/nestjs-redis/blob/fc697638af9ecf80ad2992a923047c626f2bf95b/packages/redis/package.json#L43-L47

Any updates please ?

bump for dep bump

!518 is actually more acurate beacause it does not introsuce breaking change and is not changing something unnecessarily

It looks like the author has not been keeping up with the repository for some time. I just forked it to https://github.com/Songkeys/nestjs-redis and updated the NestJS dependencies to ^10.0.0.
The npm package is @songkeys/nestjs-redis and can be installed if you're blocked from migrating to NestJS 10 because of it. Once the author comes back, you can change it back to @liaoliaots/nestjs-redis.

Thanks @Songkeys. We're planning to use your package as it unblocks us and allows us to upgrade to Nest v10. Thanks a lot for your efforts.

Got a package for health as well, by chance?

@simplenotezy Yes. Try https://www.npmjs.com/package/@songkeys/nestjs-redis-health.

any updates?

any updates?

Any news?

Hoping this will be updated. For now, using @Songkeys fork - hopefully that one stays updated.. :)

Any news?

mentos1386

Thanks a lot!!! It works :)

Please check out the new version: version 10 of @liaoliaots/nestjs-redis.


ODHack: Create a Dashboard for User Analytics

Please add PRs to the update-P21 branch
Description:
Develop a dashboard to display user analytics, including metrics such as active users, transactions, and other key performance indicators.
Tasks:

Design Dashboard UI:

Create wireframes or mockups for the dashboard.
Ensure the design is intuitive and user-friendly.

Fetch Analytics Data:

Implement backend endpoints to fetch analytics data.
Ensure data is accurate and up-to-date.

Display Data in Charts and Graphs:

Use a charting library to display data visually.
Include charts for metrics like active users, transactions, and more.

Ensure Real-Time Updates:

Implement real-time updates for the dashboard using WebSockets or a similar technology.
Ensure data refreshes seamlessly without needing a page reload.

Test Dashboard Functionality:

Conduct thorough testing to ensure all dashboard features work correctly.
Verify the accuracy of displayed data and real-time updates.

Expected Outcome:

A functional and visually appealing dashboard displaying user analytics.
Real-time updates of key metrics.
Accurate and up-to-date analytics data.

Why This Is Important:
Providing user analytics helps understand user behavior and improve the application based on insights. It also aids in monitoring the health and performance of the application.

Hello Julian, I am looking to pick this up for the LamdaHackWeek.

I am applying to this issue via OnlyDust platform.
My background and how it can be leveraged
I have 4 years working in development environments, have encountered several challenges, requests and teams focusing in reusable and efficient code, so that gives me a better understanding of the code and how to solve problems efficiently.
How I plan on tackling this issue
First of all will look at the data sources and data available in order to understand what is required to be shown, according to that desing appealing dahsboards that show in an easy to understand format that data. After that work towards the backend structure in order to fetch data and be constantly updating it.
At the end, do the testing to make sure the implementations are working properly.

@Julian-dev28  If this isn't assigned to someone, I can jump on it. I am into UI design

I am applying to this issue via OnlyDust platform.
My background and how it can be leveraged
Hi, I'm Chiboka Emmanuel, a frontend-focused software engineer with over three years of experience. I'm proficient in CSS, Tailwind CSS, Next.js, React.js, TypeScript, and more. I've transformed complex designs into responsive, interactive web pages and integrated numerous third-party APIs for real-time data fetching. I excel in collaborative environments, ensuring seamless UI/UX and optimized codebases for high-performing web applications.
How I plan on tackling this issue
Designing the Dashboard UI: First, I'll start by creating wireframes or mockups using tools like Figma. My goal is to design a dashboard interface that is intuitive and user-friendly. I will make sure the design is consistent, accessible, and works well on different devices.
Fetching Analytics Data: Next, I'll set up backend endpoints with Node.js and Express.js to fetch analytics data from a database like MongoDB . I'll ensure the data is accurate and up-to-date and that the endpoints are secure and efficient.
Displaying Data in Charts and Graphs: Using a charting library like Chart.js or Recharts, I'll visually display the analytics data. I'll create various charts for key metrics, such as active users and transactions, to make the data easy to understand.
Ensuring Real-Time Updates: I'll implement real-time updates with WebSockets or a similar technology. By setting up WebSocket endpoints on the backend and integrating them with the frontend, I'll ensure that the dashboard data refreshes seamlessly without requiring a page reload.
Testing Dashboard Functionality:  Lastly, I'll thoroughly test the dashboard to ensure all features work correctly. This includes manual testing to verify data accuracy and real-time updates.

I am applying to this issue via OnlyDust platform.
My background and how it can be leveraged
With 3 years of solid experience in JavaScript, TypeScript, and React, I have developed a strong proficiency in creating intuitive and visually appealing user interfaces. My work on various projects, including browser extensions, has provided me with valuable insights into enhancing user experience and ensuring responsiveness across different devices. Here is my github profile https://github.com/devcollinss
How I plan on tackling this issue
Design UI:
I will start by sketching wireframes and mockups in Figma to outline the dashboard layout and user flow.
Then, I'll translate these designs into React components within your Next.js application, ensuring a seamless integration with the existing UI.

Fetch Data:
I’ll create API routes in Next.js (e.g., pages/api/analytics.js) to handle backend requests for fetching analytics data.
Next, I’ll  pull data from these endpoints and manage any data fetching errors gracefully.

Display Data:
I’ll integrate a charting library like Chart.js  to visualize the data effectively.
Then, I’ll implement these charts within Next.js pages, making sure they adapt responsively to different screen sizes using tailwindcss.

Real-Time Updates:
I will set up WebSocket connections using a library such as socket.io to enable real-time data updates.
Next, I’ll ensure that React components in Next.js properly handle these updates, reflecting changes in the UI without needing a full page reload.

Testing:
I’ll write unit tests for the React components using Jest and React Testing Library to ensure they work as expected.
Finally, I’ll conduct end-to-end tests with Cypress to verify the complete functionality of the dashboard, including real-time updates.

I am applying to this issue via OnlyDust platform.
My background and how it can be leveraged
I have a background in full-stack development, with extensive experience in creating intuitive and user-friendly interfaces using technologies like React and Angular. On the backend, I have worked with Node.js  and various database systems to develop robust and scalable APIs. My portfolio includes similar projects where I developed comprehensive analytics dashboards, which demonstrates my capability to deliver high-quality solutions for this issue.
References:
GitHub: https://github.com/coxmars
OnlyDust: https://app.onlydust.com/u/coxmars
Portfolio: https://marcox-portfolio.netlify.app/
How I plan on tackling this issue
Design Phase:

Start with creating detailed wireframes and mockups of the dashboard to ensure the UI is both intuitive and user-friendly.
Collaborate with stakeholders to refine the design and gather requirements for key metrics to be displayed.

Backend Development:

Develop API endpoints to fetch the necessary analytics data, ensuring that the data retrieval process is optimized for performance.
Implement data validation and error handling to maintain the accuracy and integrity of the data.

Frontend Development:

Use a charting library (e.g., Chart.js, D3.js) to create dynamic and interactive charts and graphs.
Ensure the frontend is designed to handle real-time data updates efficiently, using WebSockets for seamless data refresh without page reloads.

Integration and Testing:

Integrate the frontend with the backend APIs and implement real-time updates.
Conduct thorough testing, including unit tests, integration tests, and user acceptance testing, to ensure all features work correctly and data is accurate.

Deployment and Monitoring:

Deploy the dashboard to a staging environment for further testing and feedback.
Monitor the performance and usage of the dashboard, making iterative improvements based on user feedback and observed issues.

I am looking forward to your feedback and the opportunity to contribute to this project.

I am applying to this issue via OnlyDust platform.
Design Dashboard UI:
Create simple, clean wireframes for the dashboard layout.
Focus on intuitive, user-friendly design.
Fetch Analytics Data:
Coordinate with the backend team to set up the necessary API endpoints.
Ensure the data covers key metrics like active users, transactions, etc.
Display Data in Charts and Graphs:
Use a lightweight charting library like Recharts or ApexCharts.
Choose appropriate chart types to effectively visualize the data.
Implement Real-Time Updates:
Set up a WebSocket connection to enable seamless data updates.
Ensure smooth, instant updates without full page reloads.
Test and Refine:
Thoroughly test the dashboard functionality and data accuracy.
Gather user feedback and iterate on the design and features.

I am applying to this issue via OnlyDust platform.
My background and how it can be leveraged
I am a seasoned fullstack blockchain developer, with over 2 years of experience
I have contributed to many open source repositories and also to OnlyDust
How I plan on tackling this issue

Design Dashboard UI:

Create wireframes or mockups for the dashboard.
Ensure the design is intuitive and user-friendly.
Fetch Analytics Data:
Implement backend endpoints to fetch analytics data.
Ensure data is accurate and up-to-date.

Display Data in Charts and Graphs:

Use a charting library to display data visually.
Include charts for metrics like active users, transactions, and more.
Ensure Real-Time Updates:
Implement real-time updates for the dashboard using WebSockets or similar technology.
Ensure data refreshes seamlessly without needing a page reload.

Test Dashboard Functionality:

Conduct thorough testing to ensure all dashboard features work correctly.
Verify the accuracy of displayed data and real-time updates.

I am applying to this issue via OnlyDust platform.
My background and how it can be leveraged
I am a software engineer at Zscaler with a year of experience in providing cloud security solutions. My role involves developing secure, scalable cloud-based applications, which has honed my skills in cloud infrastructure, security protocols, and system architecture. Additionally, I have developed a blockchain project that connects multiple wallets, showcasing my proficiency in blockchain technology, smart contract development, and Dapp deployment. This project is deployed on Netlify and available on my GitHub profile. My expertise in cloud security ensures that blockchain projects are secure from various threats while being scalable and efficient. I excel in integrating blockchain networks, deploying applications, and maintaining them using CI/CD pipelines. My collaborative approach, problem-solving skills, and customer-centric mindset further enhance my ability to deliver innovative and secure solutions in both cloud security and blockchain domains.
How I plan on tackling this issue
To develop a User Analytics Dashboard, start by designing an intuitive and user-friendly interface using wireframing tools like Figma or Sketch. Implement a robust backend with Node.js and Express.js to create API endpoints that fetch accurate and up-to-date analytics data from a reliable source. Use React.js and a charting library such as Chart.js to display the data visually, incorporating charts for metrics like active users and transactions. Enable real-time updates with WebSockets to ensure dynamic data refreshes without page reloads. Thoroughly test the dashboard using Jest and React Testing Library to verify the accuracy of data and functionality, ensuring a seamless user experience that supports data-driven decision-making.

Hi @Julian-dev28 I will work asap on this issue, if I have questions I will let you know thanks 🫡

Hi @Julian-dev28 I will work asap on this issue, if I have questions I will let you know thanks 🫡

Unfortunately, due to other commitments, I am unable to complete this issue. I recommend reassigning the issue to someone else who can give it the attention it deserves, I appreciate the opportunity and hope to contribute to this project in the future.

My background and how it can be leveraged
I have 4 years working in development environments, have encountered several challenges, requests and teams focusing in reusable and efficient code, so that gives me a better understanding of the code and how to solve problems efficiently.
How I plan on tackling this issue
First of all will look at the data sources and data available in order to understand what is required to be shown, according to that desing appealing dahsboards that show in an easy to understand format that data. After that work towards the backend structure in order to fetch data and be constantly updating it.
At the end, do the testing to make sure the implementations are working properly.

hello @Julian-dev28 this is my first time on the repo I have made contribution to other repositories and I'm a frontend developer please I would love to contribute to this repository and work on this particular issue and would be giving you frequent feedback as I'm getting the work done!!

I am applying to this issue via OnlyDust platform.
My background and how it can be leveraged
I'm a web 3 blockchain developer who s contributing to old and new repositories and would be my first time on this repo  would love the opportunity to contribute to this project
How I plan on tackling this issue

Design Dashboard UI:
Create wireframes or mockups:
Use a design tool like Figma, Sketch, or Adobe XD.
Sketch the layout with sections for different metrics (active users, transactions, etc.).
Ensure it’s intuitive by following UI/UX best practices.
Fetch Analytics Data:
Set up your backend:
Choose a backend framework (Node.js with Express, Django, Flask, etc.).

const express = require('express');
const app = express();
const PORT = process.env.PORT || 3000;
app.get('/api/analytics', (req, res) => {
// Fetch data from your database or API
const data = fetchDataFromSource();
res.json(data);
});
app.listen(PORT, () => {
console.log(Server is running on port ${PORT});
});
function fetchDataFromSource() {
// Implement your data fetching logic here
return {
activeUsers: 120,
transactions: 45
};
}

Display Data in Charts and Graphs:
Set up your frontend:
Choose a frontend framework (React, Vue, Angular).

Install a charting library (Chart.js, D3.js, Plotly).
Example using React and Chart.js:
Connect to your data source (database or analytics API).
Write endpoints to fetch data. Example in Node.js:
npx create-react-app my-dashboard
cd my-dashboard
npm install chart.js react-chartjs-2 axios
// src/App.js
import React, { useEffect, useState } from 'react';
import { Bar } from 'react-chartjs-2';
import axios from 'axios';
function App() {
const [data, setData] = useState({});
useEffect(() => {
    axios.get('/api/analytics').then(response => {
        setData(response.data);
    });
}, []);

const chartData = {
    labels: ['Active Users', 'Transactions'],
    datasets: [{
        label: 'Metrics',
        data: [data.activeUsers, data.transactions],
        backgroundColor: ['rgba(75, 192, 192, 0.6)', 'rgba(153, 102, 255, 0.6)']
    }]
};

return (

User Analytics Dashboard

        <Bar data={chartData} />

);

}
export default App;

Ensure Real-Time Updates:
Implement WebSockets:
Use Socket.IO for real-time communication in Node.js.
npm install socket.io

// In your backend code
const http = require('http').Server(app);
const io = require('socket.io')(http);
io.on('connection', (socket) => {
console.log('a user connected');
// Emit data updates
setInterval(() => {
const data = fetchDataFromSource();
socket.emit('updateData', data);
}, 10000); // Update every 10 seconds
});
http.listen(PORT, () => {
console.log(Server is running on port ${PORT});
});
// In your React frontend
import { useEffect, useState } from 'react';
import io from 'socket.io-client';
const socket = io('http://localhost:3000');
useEffect(() => {
socket.on('updateData', (newData) => {
setData(newData);
});
}, []);
To ensure you complete the task correctly, follow these detailed steps for each phase of the project:

Design Dashboard UI:
Create wireframes or mockups:
Use a design tool like Figma, Sketch, or Adobe XD.
Sketch the layout with sections for different metrics (active users, transactions, etc.).
Ensure it’s intuitive by following UI/UX best practices.
Fetch Analytics Data:
Set up your backend:
Choose a backend framework (Node.js with Express, Django, Flask, etc.).

Connect to your data source (database or analytics API).
Write endpoints to fetch data. Example in Node.js:
javascript
Copy code
const express = require('express');
const app = express();
const PORT = process.env.PORT || 3000;
app.get('/api/analytics', (req, res) => {
// Fetch data from your database or API
const data = fetchDataFromSource();
res.json(data);
});
app.listen(PORT, () => {
console.log(Server is running on port ${PORT});
});
function fetchDataFromSource() {
// Implement your data fetching logic here
return {
activeUsers: 120,
transactions: 45
};
}
3. Display Data in Charts and Graphs:
Set up your frontend:
Choose a frontend framework (React, Vue, Angular).
Install a charting library (Chart.js, D3.js, Plotly).
Example using React and Chart.js:
bash
Copy code
npx create-react-app my-dashboard
cd my-dashboard
npm install chart.js react-chartjs-2 axios
javascript
Copy code
// src/App.js
import React, { useEffect, useState } from 'react';
import { Bar } from 'react-chartjs-2';
import axios from 'axios';
function App() {
const [data, setData] = useState({});
useEffect(() => {
    axios.get('/api/analytics').then(response => {
        setData(response.data);
    });
}, []);

const chartData = {
    labels: ['Active Users', 'Transactions'],
    datasets: [{
        label: 'Metrics',
        data: [data.activeUsers, data.transactions],
        backgroundColor: ['rgba(75, 192, 192, 0.6)', 'rgba(153, 102, 255, 0.6)']
    }]
};

return (

User Analytics Dashboard

        <Bar data={chartData} />

);

}
export default App;
4. Ensure Real-Time Updates:
Implement WebSockets:
Use Socket.IO for real-time communication in Node.js.
bash
Copy code
npm install socket.io
javascript
Copy code
// In your backend code
const http = require('http').Server(app);
const io = require('socket.io')(http);
io.on('connection', (socket) => {
console.log('a user connected');
// Emit data updates
setInterval(() => {
const data = fetchDataFromSource();
socket.emit('updateData', data);
}, 10000); // Update every 10 seconds
});
http.listen(PORT, () => {
console.log(Server is running on port ${PORT});
});
javascript
Copy code
// In your React frontend
import { useEffect, useState } from 'react';
import io from 'socket.io-client';
const socket = io('http://localhost:3000');
useEffect(() => {
socket.on('updateData', (newData) => {
setData(newData);
});
}, []);

Test Dashboard Functionality:
Testing:
Write unit tests for your backend endpoints using a testing framework like Jest.
Use frontend testing libraries like React Testing Library to test your components.
Conduct end-to-end testing using tools like Cypress.

Final Touches:
Ensure your dashboard is responsive.
Perform usability testing to get feedback from users.
Optimize performance to handle large data sets.

@Julian-dev28 , please can i be assigned this?

I am applying to this issue via OnlyDust platform.
My background and how it can be leveraged
Hi, I've been programming in web for about 2 years, I've also been interested in rust and i know most of the syntax, I'd love to be in this project.
How I plan on tackling this issue

Research websocket implementation for Rust backend
Implement real time data fetching for the rust backend
ensure correct functionality via unit tests and ensure all database secrets are secure before connecting to typescript UI
render typescript UI with websockets
finish dashboard components

hello @Julian-dev28 pls can i work on this issue

@Julian-dev28 pls can I get the contract-ID
--contract-id <CONTRACT_ID>

Hello @Julian-dev28 i tried messaging you telegram no response I would like clarification on certain things :
Backend Framework: I want to confirm if I’ll be using Next.js server-side capabilities for the backend, or if I’ll set up a separate backend service? If a separate backend is considered, what technologies I’m  I evaluating?
Data Storage: How will I store and manage the analytics data? I’m  I considering a dedicated database, and if so, which one (e.g., PostgreSQL, MongoDB)?
Events: I’m I going to setup the events listeners| indexer on the backend or what infra do you suggest here?


Write initial draft of MaaS Guide

Now that we have a workspace (Gitbook), lets write the initial draft of the MaaS Guide.
Task

create initial structure for MaaS Guide
write initial chapters, organized by stakeholder
publish work-in-progress chapters, so people can see incremental changes as they occur

The MaaS Guide has a good initial structure, and is ready for initial peer review.


fix databricks tests

Description & motivation
Fix #181
Checklist

[ ] I have verified that these changes work locally
[ ] I have updated the README.md (if applicable)
[ ] I have added an integration test for my fix/feature (if applicable)

@dbeatty10 can you check the profile-databricks context? Something must be borked there - you can see connection works as expected when I used my own private context https://app.circleci.com/pipelines/github/dbt-labs/dbt-external-tables/280/workflows/449f8e2a-7375-4078-b63c-39e7e61c2330/jobs/1253


Chapter 7 - link is broken

To dive into the details of the context data passed to different BPF
program types, check out this post by Alan Maguire on Oracle’s
blog.
The provided link points to https://elixir.bootlin.com/linux/v5.19.14/source/include/uapi/linux/bpf.h

The correct link should be https://blogs.oracle.com/linux/post/bpf-a-tour-of-program-types

Thanks, I've filed that update with O'Reilly's errata process


ROW_DELIMITER in COPY was lost.

We had noticed that older versions of the code (uwquickstep/quickstep-retire) had a ROW_DELIMITER specifiable as optional params for the COPY command. This helps load files that have special row delimiters, other than the default \n character.
For example, a file being loaded to the table with schema (id int, name varchar(20)):
1|marc|
2|mike|
3|matt|

has the row delimiter |\n.
The current repo does not have this feature. It should be re-added.

Looking into the issue, it seems like there might be an opportunity to reuse ParseKeyValue pairs here.

The ROW_DELIMITER, while potentially useful, wound up having poor
performance. A single-char delimiter, as in Postgres, can be scanned and
handled much more efficiently than any general string.
On Mon, Apr 18, 2016 at 10:51 AM Marc S<EMAIL_ADDRESS>wrote:

Looking into the issue, it seems like there might be an opportunity to
reuse ParseKeyValue pairs here.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub
https://github.com/pivotalsoftware/quickstep/issues/176#issuecomment-211499975

@craig-chasseur makes a good point, but we recently found that the load performance was far more dependent on a mutex that was acquired on each tuple being inserted. So, once that is fixed (@jianqiao is on it!) we should be in a good shape.
After that PR, I think the extra character overhead won't be a big issue, and I'm in favor of the suggestion that @cramja is making to make the system more robust to to input file formats. It is not uncommon to see that extra delimiter in practice (the code to generate the text output is simpler and my guess is that is why often text files have that extra delimiter).


Fixture tweaks

@jeffreyguo @tractorcow @benmanu Would you be able to peer review please?

Looks fine to me. :)


Dev dlangst

:tada: This PR is included in version 0.2.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Scheduler should be able to cancel a queued callback

Previously, once a callback was in the execution queue, it couldn't be
canceled. Now we check whether the callback was canceled before executing it.

lgtm.


Long Polling Request

Is it possible to create a long polling request? How do I go about it if possible?

Found another way to do it. Closing!


Terminal fills up with unicode garbage when debugger invoked

It could be that there is unicode garbage in the .toString of the object I'm trying to inspect, but judging by the screenshots in the documentation, it doesn't look like Ammonite prints the debugged object before you ask it to, so I'm not sure what's going on here.
This doesn't happen when the debug statement is not there.

It also doesn't stop and I can't kill it with Ctrl+C. Although maybe the latter is an sbt issue.

The same things happens when an EOF is read (#223), which should be fixed by PR #242. This may not be related however.

Can you provide a standalone repro I can look at?

Closing due to inactivity


fixed formatting on examples

Docs Build status updates of commit 8663cd0:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

articles/data-factory/data-flow-parse.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

@kromerm,
Can you review the proposed changes?
IMPORTANT: When the changes are ready for publication, add a #sign-off comment to signal that the PR is ready for the review team to merge.
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

#sign-off this is a simple indentation issue in the bullets being fixed.


Remove duplicate MemcachedException on fetch0 method

hi, my friend:
I find a small question in com.googlecode.xmemcached, the following method has two MemcachedException.
 net.rubyeye.xmemcached.XMemcachedClient
@SuppressWarnings("unchecked")
private final <T> Object fetch0(final String key, final byte[] keyBytes,
        final CommandType cmdType, final long timeout,
        Transcoder<T> transcoder) throws InterruptedException,
        TimeoutException, MemcachedException, MemcachedException {

Maybe this is no effetc for use it. But when I user bytebuddy(A bytecode manipulation framework, like asm javasist) to monitor the application,
I encountered a problem , in bytebuddy not allow one method has same exception. I have given a issue to bytebuddy  #https://github.com/raphw/byte-buddy/issues/347
I also hope com.googlecode.xmemcached can get optimized to obtain better development.
Thank you very much!

Hmm.. thanks for your PR. It's a mistake here.

Released xmemcached 2.4.0, but it may take sometime to be sync into central repo.


IRGen: Fix a non null terminated string error

Just use the StringRef as index to a string map. Using data() will fail
if the StringRef does not contain a null terminated string.
The problem is that we get the data of a StringRef (which is not null
terminated) to intialize a StringRef with char* which expects a null
terminated string.
Found by a ASAN bot.
rdar://56340563

@swift-ci Please test


Update brand guidelines for Zowe V1

Signed-off-by: John Mertic<EMAIL_ADDRESS>

@Joe-Winchester Can you approve this - somehow the brand guidelines didn't get updated correctly in your PR...

@jmertic - sorry but I missed your comment a couple of days ago.  Do you still need me to review this - it looks like it's been merged already

Nope - I figured you had done all the signoff so went ahead and merged. Thanks for all your work in driving this to completion!


Something went wrong with this request. Sleep 15 seconds and retry to request new posts.

Hi, I was trying to use the code below.
import facebook_crawler pageurl= "https://www.facebook.com/TaylorSwift" data = facebook_crawler.Crawl_PagePosts(pageurl=pageurl, until_date='2023-01-01') data.to_csv('data.csv', index=False, encoding='utf_8_sig')
But I got some errors.
TaylorSwift's pageid is: TaylorSwift's docid is:<PHONE_NUMBER>557024 Break Times 0: Something went wrong with this request. Sleep 15 seconds and retry to request new posts. REQUEST LOG >>  pageid: , docid:<PHONE_NUMBER>557024, cursor: RESPONSE LOG:  {"data":{"node":null},"errors":[{"message":"A server error missing_required_variable_value occured. Check server logs for details.","severity":"WARNING"}],"extensions":{"is_final":true}}
But when I tried to crawle the GROUP website, it worked for me.
Does anyone can help me to solve this problem?
Thanks in advancd!

I got same issue @tlyu0419 can you help us about it?


Update Composer dependencies (2023-09-28-00-10)

Visual regression test passed!
View the visual regression test report


Reduce and consolidate unsafe code

Codecov Report

Merging #44 (080c712) into main (f183959) will decrease coverage by 0.00%.
The diff coverage is 87.50%.

@@            Coverage Diff             @@
##             main      #44      +/-   ##
==========================================
- Coverage   96.33%   96.33%   -0.01%
==========================================
  Files           7        7
  Lines         873      872       -1
==========================================
- Hits          841      840       -1
  Misses         32       32

Impacted Files
Coverage Δ

src/arc_str.rs
92.21% <87.50%> (-0.04%)
:arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


when.caniuse this?

Hello,
Does caniuse have a notification system so that you can let me know when support for a feature reaches a certain level?  You could host such a service under "https://when.caniuse.com" and have a subscription button on each page. :-)
If not I'd be happy to make this, if you like!
Today I'd love to subscribe to css variables.  When IE gets round to supporting it I'd like to use them, but I don't have a hook to bring me back to your page as soon as the situation changes.  Absent minded mathematicians are forgetful y'know.
Many thanks for a great site.
Regards, Max

Approximate duplicate of #869?

Yes, looks like it.  Sorry for not finding the original. If it hasn't been built, are you OK with my making an e-mail or web-push implementation?

Someone made this about a year ago, sadly it's not running anymore:
https://web.archive.org/web/20150425094432/http://frontendhq.com/pinger
You're welcome to make a 3rd party service like this, absolutely. No plans to do it myself though.

Closing in favor of #869


Chat - No tool tip for download icon for docx file

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Issue was found when executing #4661
Action Performed:

Launch App and login
Send any docx file
Hover mouse to download sign

Expected Result:
The tooltip should be appeared
Actual Result:
No tooltips for download icon.
Workaround:
Unknown
Platform:

Where is this issue occurring?

Web
Desktop App

Version Number:
1.0.88-0
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:
Expensify/Expensify Issue URL:
https://user-images.githubusercontent.com/43996225/131057625-86a00a10-6756-4c42-9f06-84940ca135e7.mp4

View all open jobs on GitHub

Thanks for fixing this @akshayasalvi!! :)

🚀 Deployed to staging by @sketchydroide in version: 1.0.88-3 🚀

platform
result

🤖 android 🤖
cancelled 🔪

🖥 desktop 🖥
cancelled 🔪

🍎 iOS 🍎
cancelled 🔪

🕸 web 🕸
success ✅

🚀 Deployed to production by @roryabraham in version: 1.0.88-2 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
failure ❌

🕸 web 🕸
success ✅

🚀 Deployed to production by @roryabraham in version: 1.0.90-2 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
failure ❌

🕸 web 🕸
success ✅

@kadiealexander I am not sure if this requires payment. When I implemented my PR, I guess Tooltip work wasn't done. I covered it because I thought I'll complete the work.  Nevertheless, I've applied to the Upwork, I let you and the team decide on the payment part.

Thanks Akshaya!! I apologise for the confusion here. I've asked the team how we would usually deal with issues like this and will leave it up to the majority. Will let you know!

Thanks @kadiealexander. Appreciate your help

Hi @akshayasalvi, the team decided instead of dealing with this separately, we will add a $100 bonus to the initial Upwork post here for the additional work you did here. Thanks again!!

Thank you @kadiealexander. Appreciate it


Form reset support

When I hit a button with type="reset" the reqular form fields are being reset to their default / initial value. But the bootstrap-select selectbox is not.
Please provide a method to reset the bootstrap select element.
Patrick

Not working for me

@mayankit This reply is just for posterity, I found that wrapping the render inside a setTimeout() call would fix an order of operations issue that might explain why it wasn't working for you.

I'm using a plain hyperlink to reset the form. With the above code I had to click on it twice for it to work. So this is what's working for me now.
Reset Form
$('#resetme').click(function(event) {
	 event.preventDefault();
        url = $(this).attr("href");
	$(".selectpicker").val('').selectpicker('render');
});

also useful:
// this is to reset everything else
$('#eventForm')[0].reset();
// this is useful to hide stuff, in this case formvalidation.io feedback icons
$('.form-control-feedback').css('display','none');
$('.help-block').css('display','none');
$(".has-feedback").removeClass("has-error has-success");


Batch insert, gives warning when add multiple rows to one insert

Describe the bug
It is more a question, not sure if it is a bug
Steps to reproduce

Create prepared statement "insert into table (v1, v2, v3) values (?, ?, ?), (?, ?, ?), (?, ?, ?), (?, ?, ?)"
You will get a warning "Please consider to use one and only one values expression, for example: use 'values(?)' instead of 'values(?),(?)'."
What's wrong with this option? Please note, that ClickHouse recommends doing it exactly this way.

Expected behavior
Just no warning is expected
Configuration
Environment

Client version: com.clickhouse, clickhouse-jdbc, 0.4.6
Language version: openjdk version "17.0.9-ea"
OS: Linux Debian x86_64

clickhouse-jdbc/src/main/java/com/clickhouse/jdbc/internal/SqlBasedPreparedStatement.java

If I do the "ps.executeBatch();", is it executed internally as:

a long insert like "insert into table values (?, ?, ?), (?, ?, ?)" or
a series of many "insert into table values (?, ?, ?)"
and if it is the (2) option, may it decrease the performance compared to inserting it as a (1) option?
Assuming we may insert up to 5k rows at a time?

any update?

If I do the "ps.executeBatch();", is it executed internally as:
1. a long insert like "insert into table values (?, ?, ?), (?, ?, ?)" or

a long insert , all values will added within one insert.


kata-runtime: init at 3.7.0

Description of changes
This is the runtime needed by Kata Containers, a project providing lightweight virtual machines that behave like containers.
This is my second PR working toward enabling Kata Containers with K3S on NixOS. I have this working on my home cluster and am working on merging all the pieces to Nixpkgs.
The code is heavily based on https://github.com/colemickens/nixpkgs-kubernetes, which was a very helpful starting point. (CC @colemickens).
Things done

Built on platform(s)

[X] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[X] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[X] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[X] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Git commit message does not include the release notes in the commit message body. Please, include it.

Git commit message does not include the release notes in the commit message body. Please, include it.

I added a link to the Kata Containers release notes for this version.

Does this only build for amd64? I ask because the kata-images are only downloaded for amd64. Can/should this be reflected in meta.platforms somehow or can we also make this work on aarch64?

Kata also provides images for aarch64, PowerPC, and (for some reason) IBM System/390. I think we might as well support the aarch64 one, although I believe macOS lacks the virtualization support to run something like this. Some people run Kubernetes clusters on Raspberry Pis :P

Thank you both for the reviews so far! I've responded to everything now, and just added support for aarch64 images. How does it look?

Eval is failing.

Please, always squash commits.

Yes, I'll squash in a minute -- I just accepted your suggested change :). I'd like to see the eval error you mentioned.

Fixed the eval, and the hash for the aarch64 image. The *-darwin CI builds seem stuck, and I'm not sure why they're running at all as I only specified *-linux platforms.
Anyway, should be about ready.

@SuperSandro2000 Asking your review for your Go knowledge. Is the proposed solution right?

The commit message is not right. It should be a single commit message per package.
As kata-images is an inner component of kata-runtime, you could add kata-images package to kata-runtime.passthru and avoid the reference at top-level.
Then, you could make it a single commit, but the package would be kata-runtime: init at 3.7.0.

Okay, I moved kata-images to an internal package and exposed it through passthru. I also passed in the version so it can't get out of sync with kata-runtime.
Thanks for sticking through this one with me :)


chore: change logging

:tada: This PR is included in version 1.0.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Add: Command for reencrypting all files

The change-security CLI command is great, but it doesn't change the encryption of files that are already in the archive. I decided at the time that the action should be separate since it might be pretty slow.
So the time has come that we need a command to do the following:

Walk the file hierarchy
For each file that does whose encryptionAlgorithm does not match the defaultEncryptionAlgorithm

Connect the reader and writer streams.
Hope for the best? Technically the block should be read into RAM before its rewritten.. if not we might need a buffer of one block in memory. Need to be careful of things like block allocations.

Start with a function for re-encrypting a given file.

As of 972e159 we have a cli command for reencrypting specific files and some audit functionality in the change-security and show-security commands.
Now to add similar functionality for the GUI.


Fix drawing bug in OpenCV 3+

Minor drawing bug... that took 2 hours to find. :/

@homu r+

:pushpin: Commit c9977d6 has been approved by smo-key

:hourglass: Testing commit c9977d6 with merge 5b405a1...

:sunny: Test successful - status


Tests

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@63d2d0d). Click here to learn what that means.
The diff coverage is 100%.

@@            Coverage Diff            @@
##             master       #7   +/-   ##
=========================================
  Coverage          ?   26.31%
  Complexity        ?        6
=========================================
  Files             ?        5
  Lines             ?       57
  Branches          ?        0
=========================================
  Hits              ?       15
  Misses            ?       42
  Partials          ?        0

Impacted Files
Coverage Δ
Complexity Δ

...c/main/java/com/inna/shpota/company/WebConfig.java
100% <100%> (ø)
2 <2> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 63d2d0d...5528878. Read the comment docs.


Flatness

The makes a lot of the area flat, but retains some deep hills and valleys.

I want to rewrite the ways factors influence bock types now that flatness is a thing, but I want to make sure this is correct first.

It sounds like they both indeed control the same thing. Could we do that with a single value instead?


Geometric Types in Postgresql support

It seems diesel not support Geometric Types in postgresql feature currently. Any plan to support this ?

Duplicate of #491

Duplicate of #491

There are indeed third-party crates supporting the types, but they may not be maintained, add another layer of complexity and often require a number of workarounds. diesel_geometry for example has not seen any commits for three years. So it's understandable to wish for it.
That said, I realize that simply subsuming that functionality in diesel's core is wishful thinking as long as it remains a single dev's unpaid side project.

@Gearme I can understand the wish of having support for this in diesel itself, but I just don't have the capacity to do this. Anyway back to something we can probably solve: You've mention that this requires a number of workarounds. Could you give a bit more details about that, as this is probably something we could improve on from diesels side.

is this supported in any form in diesel


Specify Cluster

Small change to allow the ecs cluster name to be specified in drone.yml. Plugin currently always uses the  default cluster.

LGTM

Cool. Cheers!

LGTM

LGTM


Sales - DLC hidden with no filters applied

On /sales/, DLC on sale is hidden even when nothing is selected for "Filter by type" (i.e. the top option is selected). The expected behavior is that nothing at all is filtered out. If you'd like to keep DLC filtered out by default, then the default option should be renamed to make that clear. Or there could be a notice above the table that DLC is hidden. After using the page for months I only noticed recently that DLC is hidden by default, so I must've missed lots of sales.
Thank you!

Does "DLC for owned games" work? Doesn't for me, but could be because my profile is usually friends-only. Normally that's not an issue because I have the browser extension installed.
https://steamdb.info/sales/?min_discount=0&min_rating=0&displayOnly=OwnedGamesDLC

but could be because my profile is usually friends-only. Normally that's not an issue because I have the browser extension installed.

Your games have to be synced via the API, so your games list should be publicly visible.


Unable to remove resource reactadminamplifydem9cde0abfPreAuthentication

Hi,
I tried to setup and run the demo application and followed the setup instruction as mentioned in the ReadMe.
I am unable to remove resource reactadminamplifydem9cde0abfPreAuthentication.
When I try to run the demo, I land on the login screen, I am not getting redirected to dashboard after logging in.
Note: I created a new user in the Cognito User Pool (Confirmed User)

Hi, you won't be able to login if that preAuth function is here.
In order to remove it, you have to run amplify update auth and go through all the questions (it's a bit tricky).
Here are all the answers:
amplify update auth
Please note that certain attributes may not be overwritten if you choose to use defaults settings.

You have configured resources that might depend on this Cognito resource.  Updating this Cognito resource could have unintended side effects.

Using service: Cognito, provided by: awscloudformation
 What do you want to do? Walkthrough all the auth configurations
 Select the authentication/authorization services that you want to use: User Sign-Up, Sign-In, connected with AWS IAM controls (Enables per-user Storage features for images or other c
ontent, Analytics, and more)
 Allow unauthenticated logins? (Provides scoped down permissions that you can control via AWS IAM) Yes
 Do you want to enable 3rd party authentication providers in your identity pool? No
 Do you want to add User Pool Groups? No
 Do you want to add an admin queries API? No
 Multifactor authentication (MFA) user login options: OFF
 Email based user registration/forgot password: Enabled (Requires per-user email entry at registration)
 Please specify an email verification subject: Your verification code
 Please specify an email verification message: Your verification code is {####}
 Do you want to override the default password policy for this User Pool? No
 Specify the app's refresh token expiration period (in days): 30
 Do you want to specify the user attributes this app can read and write? No
 Do you want to enable any of the following capabilities?
 Do you want to use an OAuth flow? No
? Do you want to configure Lambda Triggers for Cognito? Yes
? Which triggers do you want to enable for Cognito
Removing resource reactadminamplifydem9cde0abfPreAuthentication...
Successfully removed resource

Then you have to push changes: amplify push
Do you get any error while following this process?
if so, please paste the answers you give like above + the error message.

In the last step, Which triggers do you want to enable for Cognito?
What needs to be selected?

You have to press space to unselect Pre Authentication then press enter.
If you only press enter it does not update!
I also made that mistake when I was beginning with the Amplify CLI :)

OK - Update
tried in Windows OS it worked
In MacOS its not removing, will try updating amplify cli

OK @webantz
I will reopen this issue if you still have the problem.


feat: add support for paused slides using <!-- pause -->

Changes Introduced

within each page, one now can use <!-- pause --> to pause
each page is broken down to contain the content so far until each pause

Oh this is super interesting, I almost wonder if we should use (+++):
+++
as the delimiter

I was mostly drawing inspiration from https://mfontanini.github.io/presenterm/guides/basics.html#pauses and I prefer it over +++ or *** because this only affects how the Markdown files is presented as slides by slides and the content stays unchanged when it is viewed by other Markdown viewers.


feat: Insert articles into replies

Adds page with instructions to set up the article insert feature

@nithindavid This PR is not complete, there is no way to access this page other than hitting the URL directly in the browser. Please add it to the sidebar.

@pranavrajs I have added the link to the sidebar with label "Insert Article"

Let me if we need to change this?

@nithindavid I would suggest to group this under help center and update the title to something like 'How to use articles in a conversation?'

@pranavrajs I have made the change.


Brute Force String Search is updated as "String.characters" is deprecated

Checklist

[x] I've looked at the contribution guidelines.
[x] This pull request is complete and ready for review.

Description

The current Brute-force String search algorithm is using string.characters method which is deprecated. I have updated the algorithm without changing any functionality.

Thanks for the review, I have updated the code as per your comments could you please look at it.


IMAGING-310 JpegImageParser.getImageInfo() Refactor colorType logic to first look at numberOfComponents

fix for IMAGING-310 JpegImageParser: Grayscale JPEG file with app14Segment returns ColorType.UNKNOWN

Thanks for the pull request and sorry for taking so long to review it @jephillips34 . Will try to get on it in the next days :+1:

Coverage remained the same at 76.839% when pulling fcfafb6efebb52d5f4566344970ba551350b5c69 on jephillips34:IMAGING-310-JpegImageParser-colorType into b6b4e9c739ffc22fa0cdad3d54dd203682a47960 on apache:master.

Rebased onto master and squashed commits. Let's start reviewing it :)

Closing: No reply.


AssertionError,when I use my own BVH file

Thanks to the author's outstanding work!
I encountered the following error when using the BVH file extracted by myself to drive the picture animation. Where can I correct it?

from animated_drawings import render
render.start('./examples/config/mvc/interactive_window_example.yaml')
CRITICAL:root:framenum specified (1482) and found (1483) do not match
CRITICAL:root:Error loading BVH: framenum specified (1482) and found (1483) do not match
Traceback (most recent call last):
File "D:\pythonProject\AnimatedDrawings\animated_drawings\model\retargeter.py", line 34, in init
self.bvh = BVH.from_file(str(motion_cfg.bvh_p), motion_cfg.start_frame_idx, motion_cfg.end_frame_idx)
File "D:\pythonProject\AnimatedDrawings\animated_drawings\model\bvh.py", line 162, in from_file
assert False, msg
AssertionError: framenum specified (1482) and found (1483) do not match

During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "", line 1, in
File "D:\pythonProject\AnimatedDrawings\animated_drawings\render.py", line 21, in start
scene = Scene(cfg.scene)
File "D:\pythonProject\AnimatedDrawings\animated_drawings\model\scene.py", line 30, in init
ad = AnimatedDrawing(*each)
File "D:\pythonProject\AnimatedDrawings\animated_drawings\model\animated_drawing.py", line 255, in init
self._initialize_retargeter_bvh(motion_cfg, retarget_cfg)
File "D:\pythonProject\AnimatedDrawings\animated_drawings\model\animated_drawing.py", line 317, in _initialize_retargeter_bvh
self.retargeter = Retargeter(motion_cfg, retarget_cfg)
File "D:\pythonProject\AnimatedDrawings\animated_drawings\model\retargeter.py", line 38, in init
assert False, msg
AssertionError: Error loading BVH: framenum specified (1482) and found (1483) do not match

Hi @Pythonpa,
BVH files contain some 'motion metadata' specifying the number of frames which should be present within the file. The error means the specified number and the actual number don't match. Did you use Rokoko to create your BVH? I encountered this issue when I did (though I neglected to mention it in the readme).
To resolve, open the BVH file with a text editor. Search for the string Frames: 1482, then update it to 1483 so it matches. Alternatively, you can delete the first frame of motion- it should be two lines below Frames: 1482.
Please close the issue if this answer resolves your problems.

Yes，it worked,thanks again~~


Exhibition captions list (a11y fix)

Who is this for?
Cardigan a11y flags

What is it doing for them?

Straight after the main <article> wrapper came <PlainList> (which is a ul), but no <li>. I've talked about it real quickly with David and we think it could just be removed, no styles seem to be affected. That's the very simple first commit.
On the second commit, I'm suggesting pulling out the Stop component in its own file as to simplify things (file was getting long). If we don't like it it can be rolled back!

I've noticed that sometimes the styled components live in another file again, especially in the identity app – do we have a consistent approach/rule for that?

I don't think we've talked it out much. When I first joined I made a draft ticket for it ("Review where styles live" in our backlog). Having ComponentName.styles.ts has been my way of working for a few years, but it's always a question of judgement. I don't find it useful when there's just a few styled components, but when the styles take up to a 100 lines I tend to just want to be able to see the component itself and its functionalities without having to scroll for it. (Same theory for creating a styled component for one line of style, not sure it's necessary, so might be a conversation to have!)


Installation issue

When I installed this on my machine, the package didn't seem to set itself up correctly.
I ran:
python setup.py install
to install my application. But it looks like my /usr/lib/python2.6/dist-packages directory only contains a django_mongoforms-0.2-py2.7.egg folder.  I expect it to contain a mongoforms/ folder as well. The mongoforms folder is hidden in the django_mongoforms-0.2-py2.7.egg folder.
Is this an issue with my installation or an issue with the packaging?
Thanks.

Please provide the output of the following command:
python -c "import mongoforms"

Also I need to note that mongoforms installation directory is usally located under /usr/lib/python2.6/site-packages.


Automate search-replace steps in recipe

Just like in PR #30, this PR tries to leverage the (macOS flavor of) find and sed to automate the execution of steps 5.1.1 and 5.1.2. in the recipe, ultimately merging both into a single step of 5.1.
Hopefully, this saves template maintainers a bit of time when executing those recipe steps, and seems less tedious to me than the manual process. It also loses the dependency on the text editor.

Thank you, much appreciated, This is exactly what I was looking for.
Do still want to analyze a bit to understand this better.

Thank you, love it, this works great!


test(abg): extract metadata and typings for all types of inputs

To be able to reuse it easily.

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

#1334  👈
#1333
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @krzema12 and the rest of your teammates on  Graphite

Merge activity

Mar 30, 6:09 PM EDT: @krzema12 started a stack merge that includes this pull request via Graphite.


cflinuxfs2-rootfs.trusted_certs should accept an array

For consistency with other parts of cf like the diego rep, the trusted_certs property should accept an array. It's also easier to manipulate arrays with tools like bosh-cli than concatenating strings.
cc @wjwoodson

@dgodd

@sclevine I leave this one for you. Is that normal across CF?

This work looks completed, closing.


[explorer] Image Pop Out

Adds functionality such that the image becomes larger when clicked.
Here's a video showing the functionality in action:
https://user-images.githubusercontent.com/11377188/183134589-6cd7db92-d583-4237-beb2-fb8161214803.mp4
[Edit 2022-08-05]: This video has been updated to reflect the latest deisgn that includes a 'Preview Media' button

@Andrew47 a few pieces of feedback

Could we keep the metadata text always aligned to the left edge of the image? Do you foresee any issue with that?
The metadata text style - size/color - seems off. Please double check that.
Is the overlay background color/opacity to spec? Seems a bit lighter than expected. May be it is just the video i am seeing.

@Andrew47 a few pieces of feedback
1. Could we keep the metadata text always aligned to the left edge of the image? Do you foresee any issue with that?

2. The metadata text style - size/color - seems off. Please double check that.

3. Is the overlay background color/opacity to spec? Seems a bit lighter than expected. May be it is just the video i am seeing.

Thank you for the feedback:

The text appears more to the left than usual because this is a particularly narrow image. This looks reasonable with the wider image used in the live API. Unfortunately the live API service was down at the time this PR was made.
2/3. Yes - this follows the Figma design.

Got it. Okay.
I have a few thoughts on how we could improve this experience in future. Design needs to provide all the breakpoint specific layouts.
For the current PR, things look okay. I would as usual like to play with the UI/UX myself to provide further feedback post merge. Kindly tag me when its ready.

@Jordan-Mysten / @mystie711 / @stella3d / @Jibz1 / @666lcz --> This PR is now ready for re-review. Note that substantial changes have been implemented to add the Preview Media button that also triggers the image to pop-out. The revamp also incorporates feedback from @Jordan-Mysten and @mystie711. This includes getting the text to align to the left of the image.

Figma with comments on what could be improved,
https://www.figma.com/file/YJt9Bs4eyhD9PmeZQbFTkf/dev-feedback?node-id=0%3A1

Thank you @stella3d for the above feedback. I've updated the comments to better explain how Full Screen mode in the component is connected with Full Screen mode outside the component.

Hi team,
I suggest eventually developing some user docs for the Explorer. The closest we have now is in the Devnet docs:
https://docs.sui.io/devnet/explore/devnet#mint-an-example-nft
With this page:
https://docs.sui.io/devnet/explore#sui-explorer
Instead linking to our README:
https://github.com/MystenLabs/sui/tree/main/explorer/client#readme
We might then reciprocally link from the Explorer to those docs. Just floating the idea here.

Hi team,
I suggest eventually developing some user docs for the Explorer. The closest we have now is in the Devnet docs:
https://docs.sui.io/devnet/explore/devnet#mint-an-example-nft
With this page:
https://docs.sui.io/devnet/explore#sui-explorer
Instead linking to our README:
https://github.com/MystenLabs/sui/tree/main/explorer/client#readme
We might then reciprocally link from the Explorer to those docs. Just floating the idea here.

Good idea - this is not the PR to discuss this. Perhaps make a GitHub issue with more details on: who will use the docs, where should the docs be and what should the docs cover. This content either goes into the Explorer README or the Docs Portal.

Hi team,
I suggest eventually developing some user docs for the Explorer. The closest we have now is in the Devnet docs:
https://docs.sui.io/devnet/explore/devnet#mint-an-example-nft
With this page:
https://docs.sui.io/devnet/explore#sui-explorer
Instead linking to our README:
https://github.com/MystenLabs/sui/tree/main/explorer/client#readme
We might then reciprocally link from the Explorer to those docs. Just floating the idea here.

Good idea - this is not the PR to discuss this. Perhaps make a GitHub issue with more details on: who will use the docs, where should the docs be and what should the docs cover. This content either goes into the Explorer README or the Docs Portal.

Good point. Doc issue filed here:
https://github.com/MystenLabs/sui/issues/3899


Add support for programmatically created Views

https://github.com/novoda/spikes/pull/326
@BraisGabin I've moved the conversation here (just about to move the code to this repo).
Thanks for your PR and your patience.
I acknowledge the issue you're facing.

I'd like to test whether using afterActivityLaunched has any other implications
would prefer a separate rule to avoid the unused field/unused ctor parameter in ViewTestRule

@braisGabin

convinced using afterActivityLaunched is legit since it'll be called before any of the tests and before any of the @Before methods too
rather than creating a separate rule, I tried extracting the view creation logic to a separate collaborator

Would this work for your case? https://github.com/novoda/espresso-support/compare/abstract_view_creation
I think it'd be like:
@Rule
public ViewTestRule<UserScreen> viewTestRule = new ViewTestRule<>(new ViewCreator<UserScreen>() {
    @Override
    public UserScreen createView(Context context, ViewGroup parentView) {
        return UserScreen.createScreen(context, parentView, activityComponentMock)
    }
});

I'd like to test whether using afterActivityLaunched has any other implications

I use this callback in this other library: https://github.com/21Buttons/FragmentTestRule and we don't have any issue so far.
I like the ViewCreator idea. Lambda rules!

nice one, I'll open the PR shortly. Thanks for your help!


[L02] Exchanger cancellations can be front-run

When a proposal is created in GrandaMento.sol, it can only be cancelled before it is approved by the approver role by calling the cancelExchangeProposal function. However this process can be front-run by the approver role, who can approve the proposal and prevent the user from cancelling it.
Consider informing exchangers that this is possible. Consider giving proposals a grace period in which the exchangers can cancel them before the approver can approve them.

After brief discussion, we believe informing exchangers this is possible is sufficient, and that implementing the grace period is not worth it. The approver is generally a trusted role, so realistically this is unlikely to happen, and governance can always change the approver & cancel the exchange proposal if this does occur. Exchangers are also expected to be very confident in their exchange by the time they create the proposal on-chain, so cancellations are unlikely.


test: experimental parallel run

Closing. This is not an acceptable approach. Too slow & too error prone. We should aim for sub tests tasks.
Such as

npm run test:ci:databases
npm run test:ci:frameworks

Then we can run these tasks in parallel.
We can even skip specific groups when nothing was modified.

Furthermore: reporters do not work with parallel modus.