Debugging insane delay sending files

Hello i just sent a file with this code:

It took more than 11 minutes too complete. (7 MB .mp3 File)
How can i start debugging this issue? Is Telegram limiting me because i sent too much at one day? It worked fine yesterday.

Maybe its also my Internet thats suddenly pretty bad, im not experienced in this.
Can someone point me where to start researching/debbuging this issue right know i cant do more than starr at an empty console.
Appreciate any help, also "google this and this"

You can try to upload a file with plain curl request. Maybe it would give you any hints.
As for Telegram limitations try to contact official support.


Should there be a push/pop surrounding the p5.scale call in draw-sketch! :image?

Relevant Code
As far as I know, p5.scale affects all subsequently drawn shapes: P5 Docs.
If I try to draw two images, the scale from the first will bleed into the second, which is unexpected.
(p/render game [[:image {:name "durr.png" :scale-x 2 :x 0 :y 0}]
                [:image {:name "hurr.png" :scale-x 2 :x 10 :y 10}]])

Fixed by your PR, thanks!


File is not defined

Hi bro, can you solve this problem?
form.append(null, new File([room.stopRecording()], `HBReplay-${RecSistem.getCustomDate()}.hbr2`, { type: "text/plain" }));
                                  ^
ReferenceError: File is not defined

I added var File = require('fs'); after then but says;
form.append(null, new File([room.stopRecording()], `HBReplay-${RecSistem.getCustomDate()}.hbr2`, { type: "text/plain" }));

TypeError: File is not a constructor

Learn NodeJS

Learn NodeJS

What is the solution to my problem?
Please tell me how should I do it.

@mertushka Maybe related to your used browser? Please find a solution.

@mertushka Maybe related to your used browser? Please find a solution.

Find a solution yourself. You can't achieve anything in life without effort. Just do research in the "right" way, not just copy and pasting.

Why you are so prejudiced, i have tried many things except copy paste.
Do have to be a developer to solve this problem? I asked you because you are a developer of this script.


Possibility to use RenderScript

This PR adds the possibility of using RenderScript for blurring. Sample has been updated with a checkbox to  enable RenderScript.

By default, the library does not use RenderScript.
API is backward compatible with identical behaviour.
I chose not to use RenderScript retrocompatibilty to API level >= 8, as it forces the developer of the final app to modify his build.gradle file (see http://android-developers.blogspot.fr/2013/09/renderscript-in-android-support-library.html), but it's up to you to change that if you want ;)

That could definitly be very useful (:
RenderScript will be available in the next release!
Thanks a lot :D


ADD: Issue templates added(pull request,bug,feature request).issue #120

This pull request introduces three new files under the .github folder - bug_report.md and feature_request.md and pull_request_template.md . These templates aim to standardize and enhance the issue reporting process within our repository. They provide a clear structure for submitting bug reports and feature requests, thereby improving clarity, ensuring completeness, and saving time for both contributors and maintainers. This contribution aligns with the suggestions and requirements outlined in issue #120.

Ok, I reviewed and it looks good.

@Yash-1511 let me know if you have thoughts on this, thanks

@joshbickett We've set up two issue templates for our project: a bug report template and a feature request template. Contributors can also create a blank issue if their concern doesn't fit these categories. We're planning to add more templates and are transitioning to YAML syntax for easier issue filing. Issues from each template are automatically labeled appropriately. this label configuration is added in markdown file.

Oh ok, I didn't see the blank issue button

There is no button. In bottom you can see create a blank issue link.


Updating jsoup

My users were seeing some NullPointerExceptions originating from the jsoup library.  Looking at the issues list for jsoup, several issues have been resolved in 1.10.3 so I updated Link-Preview to use that instead.

@thegnartist thanks.


[BAEL-3861] Introduction to Apache Beam

[BAEL-3861] Introduction to Apache Beam

retest this please


Nested 1.5 works but,,,

With nested 1.5 i was finally able to get castlevania 1 to work by using the same settings BUT i also changed vqram 0x4000 into 0x8000 sothat it will no longer crash during the demo session,
I also do get metroid finally working on the powerpak wich beforehand only worked on the everdrive with version 1.4,
HOWEVER i don’t get xevious to work all because of the mission option “memory emulation” wich are present in version 1.4.1 and 1.4.2
Because disabling memory emulation is required to get the game running,however with it’s previous versions of nested i got no sound,but somebody somehow manages to get it fully working with both 1.4.2 and 1.5 without changing anything complete with sound,i don’t understand that,
now the biggest icing on the cake is this,i tried mario 3 along with the recorded sram files from previous the version of nested hoping to get the game fully running with improvements,BUT nope despite it sees those calls,the game just has to reteach nested at how to run it(could it be that nested 1.5 only could deal with sram files from it’s own revision,could it not deal with generated sram files from nested 1.4 and beyond???)
Also mario 3 still does crash and the spade card game so why is that? Unless there are certain settings needed not listed in the compatibility list yet,in fact no mentions about nested 1.5 in the compatibility list yet,
BUT despites all that it’s a good start and let’s hope that dpcm audio is gonna be the next big thing.

The removed “memory emulation” settings were originally implemented to boost performance for mapper 0. Despite that, a few games saw improvement when disabling them. Investigating why they were helpful is going to be a focus for v1.6.
SRAM files are not forward compatible. Each one has a signature containing "Nested Emulator", version number and game profile name. Since the version number changed, the SRAM file is ignored by the different version. However, the profiles are forward compatible.
Spade game was fixed via patch available on the spreadsheet. I don't know how many versions SMB3 had but if the patch doesn't work, it's possible that you're using the wrong version.

WioooW these are interesting mentions,
Now for what i do know is there’re 2 revisions of ntsc super mario 3 in wich some languange issues were fixed that’s it,
But can you link me to the patch fix of mario 3? Also are you working to implement the dpcm channel update for version 1.6?
Again Thanks alot.

But can you link me to the patch fix of mario 3?

I already said where the patch is located. Please pay attention to what I'm saying.

Also are you working to implement the dpcm channel update for version 1.6?

Unlikely, I will be working on Project Nested more casually from now as I'll be focusing on a new project.

Well yes i do understand that that patch is in the spreadsheet but the ultimate question is were can i find that spreadsheet,is it on the website or is it inside nested 1.5 or wherever?
Or i may lived under a rock for a few day’s but Am spinning my head at were to find the spreadsheet to track down that smb3 patch ,mmmm.

There's a button titled "Compatibility" in the bottom left corner when you open the exe file.

Well i guess i found that patch of smb3 in the compatibility list of the website, saying with a number on it,i guess i have to copy paste it to edit patch option,so i tryed that but i do got an error massage saying  error on line 1,i tried it with both nested 1.4.1 ,nested 1.4.2 and nested 1.5 but i got the same error massage ,but i guess i did something wrong,phew

Well i guess i found that patch of smb3 in the compatibility list of the website, saying something with a weird number on it,i guess i have to copy paste it to edit patch option,so i tryed that but i do got an error massage saying error on line 1,i tried it with both nested 1.4.1 ,nested 1.4.2 and nested 1.5 but i got the same error massage ,but i guess i did something wrong,phew

remove the quotation marks in the code, some of the patch codes have quotes that aren't part of the patch code.

Well i tried to remove all quotation marks but that did not help,i tried to remove all symbols such as //#_ etc,,  as well but no luck, i also tried to remove the http://www.google.com at the beginning of the code but no luck either,i tried nested 1.5 for that,
So i am starting to feel me desperate and how to deal with this.

I tried copying from a different browser, one where I'm not allowed to edit, and I can't recreate the faulty copy-paste.
Can you explain what you did to copy the text in the patch column?

Well i tried to copy and paste the patch by copying the cell to it’s link BUT as expected that was the wrong way,so thos time i dit hit control c to copy it,then i pasted it in the edit patches option and wallaah,now i finally got it to work😁

1 question,are you about to give up on dpcm sound support or is that something you may consider for version 1.7?
for what i can remember is that you said a while back that you wanted to use 2 soundchannels of the snes to emulate 7bit pcm audio to allow dpcm,adpcm and pcm playback,despite most games don’t use 7bit pcm,
Bome games seems to also use a form of adpcm streaming ,
But i was thinking,what if the snes lacks the bandwide and processor power to support 7bit pcm,i was thinking,how about just redigitize 1bit dpcm and 4bit adpcm samples from supported games into BRR instead (same treatment as psg audio)and leave 7bit pcm support at all,am mean better having 1bit dpcm or 4bit adpcm then no digital audio at all,sure that will take alot of time and it probably will make nested huge in size wich may could have impact on the performance of running games,but if trunscating those supported games,then only all used samples should be put into the rom and not those unused once,but again that would probably also take long since nested then also has to know wich samples belonges to wich game in order to allow trunscating those games,but who ever knows.

I'm not giving up but changing where I put my time. I am working on a different project so the time I put on Project Nested will diminish. If you desperately want DPCM support now, just pay me. Otherwise wait for me to update it the way I want and the way my Patreon supporters want.
As for your last paragraph, there are a lot of misconceptions.

It's "bandwidth" and there's a good amount of it actually.  If the SPC700 CPU isn't busy at all. The main CPU can use HDMA to transfer data at a rate of 4 bytes per scanline, 239 scanlines per frame. For a total of 57360 bytes every 60 frames.
Using BRR samples was always my plan and I explained it before.
Converting audio to BRR won't "make Nested huge". Nothing even comes close to the amount of code reserved for indirect JMP (opcode $6C) at over 64KB of ROM.
Samples are already in ROM, in DPCM format. They can't and won't be in BRR format in ROM.

As I explained before (please take some notes so I don't have to repeat myself), each DPCM sample can be converted to BRR to be played in 2 channels not because I want to play 7-bit samples but because I want more than 4-bit samples. Using a single channel is an option and I recently decided to go with 1 channel at first. Samples only need to be translated once because there's a lot of unused ARAM (Audio RAM) on Project Nested.
BRR samples for DPCM will be cached. A cache is a limited memory used to access data at a faster rate than where the original is located. Since the cache memory is limited, each set of data in the cache is dated as to when it was last used. If new data needs to come into the cache but the cache is full, the oldest data is deleted until enough space is present for the new data. The SPC700's memory is isolated in both directions so the cache approach is the most viable option.

Hi, i have played today both versions of mario 3 to generate some extra srm files and i can confirm that both do get indeed passed 5-7 and both do got the roulette game work,HOWEVER i have discovered that the pal version of mario 3 still does crash on the memory game,all other versions just do get working fine once entering the momery,i say this so you will know that,once again thanks for the hard work,and if i know how to pay you,i will definitely pay you some day to courage you to keep on this project more and more😁

HOWEVER i have discovered that the pal version of mario 3 still does crash on the memory game

I told you that these patches would likely not work on other versions. However, you can fix spade game by disabling "native return address" but 5-7 executes a BRK which is the only unsupported official opcode. The game executes a BRK because of a mistake in their own code which went unnoticed due to having no visible side effects.

if i know how to pay you,i will definitely pay you some day to courage you to keep on this project more and more

There's a button titled "Patreon" just below "Compatibility" on the exe's main window.

Oh am sorry, i didn’t remember that that you told me that the patch would likely not work on other regions of that game,oh well now i am aware of it,
yes i saw that petreon button below compatibility,who ever knows i will try it someday to pay.

Oh am sorry, i didn’t remember that that you told me that the patch would likely not work on other regions of that game,oh well now i am aware of it,
yes i saw that petreon button below compatibility,who ever knows i will try it someday to pay.

Just curious but how does one create patches or search for them? is there a procedure that can be followed to find them?

Oh am sorry, i didn’t remember that that you told me that the patch would likely not work on other regions of that game,oh well now i am aware of it,
yes i saw that petreon button below compatibility,who ever knows i will try it someday to pay.

Just curious but how does one create patches or search for them? is there a procedure that can be followed to find them?

To find the patch,1,open the nested emulator and 2,click on the “compatibility” button wich will lead you to the compatibility list of the website,another option is to clock on the code button next to issue button on this website, then click on compatibility list below to go to that compatibility list,
3,Now click on game list and search for the game you want,on the right side you can see a spreadsheet wich possibly contains a patch for that game,4,if so click with the mouse on it,5,then hit control C to make a copy of it,6,now click on edit patches in nested and paste that copy of that patch into it and click on oke,7,then change the setting in accordance to the compatibility list of that game if needed,then hit save,hit make a profile,click on oke to confirm and you have a patched nes game to run on snes😁🙏

Oh am sorry, i didn’t remember that that you told me that the patch would likely not work on other regions of that game,oh well now i am aware of it,
yes i saw that petreon button below compatibility,who ever knows i will try it someday to pay.

Just curious but how does one create patches or search for them? is there a procedure that can be followed to find them?

To find the patch,1,open the nested emulator and 2,click on the “compatibility” button wich will lead you to the compatibility list of the website,another option is to clock on the code button next to issue button on this website, then click on compatibility list below to go to that compatibility list, 3,Now click on game list and search for the game you want,on the right side you can see a spreadsheet wich possibly contains a patch for that game,4,if so click with the mouse on it,5,then hit control C to make a copy of it,6,now click on edit patches in nested and paste that copy of that patch into it and click on oke,7,then change the setting in accordance to the compatibility list of that game if needed,then hit save,hit make a profile,click on oke to confirm and you have a patched nes game to run on snes😁🙏

No I mean how to find patches for games not listed in the compatibility page?!?

Oh am sorry, i didn’t remember that that you told me that the patch would likely not work on other regions of that game,oh well now i am aware of it,
yes i saw that petreon button below compatibility,who ever knows i will try it someday to pay.

Just curious but how does one create patches or search for them? is there a procedure that can be followed to find them?

To find the patch,1,open the nested emulator and 2,click on the “compatibility” button wich will lead you to the compatibility list of the website,another option is to clock on the code button next to issue button on this website, then click on compatibility list below to go to that compatibility list, 3,Now click on game list and search for the game you want,on the right side you can see a spreadsheet wich possibly contains a patch for that game,4,if so click with the mouse on it,5,then hit control C to make a copy of it,6,now click on edit patches in nested and paste that copy of that patch into it and click on oke,7,then change the setting in accordance to the compatibility list of that game if needed,then hit save,hit make a profile,click on oke to confirm and you have a patched nes game to run on snes😁🙏

No I mean how to find patches for games not listed in the compatibility page?!?

Phew,that’s a good question,maybe trough a google search or a certain website

Just curious but how does one create patches or search for them? is there a procedure that can be followed to find them?

I'm using a private SNES emulator to debug Project Nested. There's really nothing special about my SNES emulator so I never released it and it's bad in a lot of ways. One tool in particular is only found on my private emulator but someone can easily port it to Lua for Mesen-S, I can give directives if you're interested. I'm bad at Lua.
If you're familiar with reverse engineering games, find the address that you want to change and the new value that you want at this address.
There are 3 addressing modes for patches, all 3 refer to the NES game but from different perspectives. I prefer the third option (NES address format) which is an address from the NES's perspective. For example, "[16:c8ef] = 62" is "[bank:address] = value". Where bank is determined by the mapper, each mapper may have different bank sizes. All 3 numbers are in hex.
The value "62" in the patch above is actually a repurposed opcode. There are 12 repurposed opcodes in total, each one overrides an illegal opcode that locks (STOP) an original 6502 so they're guaranteed useless for programming on a 6502. Every opcode with a low nibble of 0 that affects the PC register (ie. 0x60) will change into a STOP if you change the low nibble to a 2.
I haven't documented the repurposed opcodes but I can do it today if you're interested.

yes please I would like to read all of that ty

https://github.com/Myself086/Project-Nested/blob/master/Documentation/Repurposed opcodes.txt
If you're interested in making patches, I'd like to see Kung Fu patched for proper scrolling splits.


travis: Run cargo-tarpaulin only on Linux

Coverage remained the same at 0.0% when pulling 1f79e149332039243cd1c7e68c4cde03817ac8d7 on lzutao:travis into 085bd5a283a94ea49136a8e58509a539bb1b2acc on gimli-rs:master.

I think it works now.


Deployment

This pull request contains the Ansible deployment scripts.  Currently the scripts support 2 deployment types:  deploying Metron to a single node VM (full install including Ambari and cluster) for development and testing purposes and deploying Metron to a cluster that already exists.  The Pcap source works end to end and other sources will be added in future iterations.

https://issues.apache.org/jira/browse/METRON-21

A significant part of this code is from another pending pull request from a different committer.  If you have additional code to use, pull the prior pull request into a branch thereby preserving the original author's commits, and you can commit on top of that.

Sorry was so focused on getting it to work that I wasn't even thinking about the commit history.  I will get this corrected asap.

This is no longer valid so creating a new pull request now that we have METRON-2 in the commit history.


Handle output on stderr

Fixes #4 🤞

Works for me!

Cool, thanks for testing. Really appreciate.
Do you know btw if clang uses stdout for anything?

I think it uses it only for normal compilation (informative) messages, compiler warnings and error are printed to stderr

Okay, thanks, thats for later. @braver released 4.3. 15 minutes before Munich-Madrid. 🙄

Oh shit, Munich-Madrid is today?

9 minutes


Add the windows task name attribute

Hello,
Can you add an attribute for windows scheduled task name in your next release?
Actually it is a constant "chef-client" resource name.
In some production case, we have to do with two configuration of chef and then two task concurrently.
Best Regards,

Hi,
Having this as an attribute wouldn't help as you can't apply the same recipe twice with different attribute values, one of the values will override the other.
The best thing to do is include this cookbook in a wrapper cookbook and make use of the chef_client_scheduled_task resource directly in your own recipe where you can give each instance of it a unique name.
Hope that helps!

This cookbook ships with a resource now for setting up the scheduled task. It defaults to just 'Chef Client'. Making that an attribute could be sort of problematic since changing it would result in 2 different tasks. Since it is a resource though you can just use that resource directly in your own cookbook and skip the task recipe entirely. That would allow you to call it whatever you want.


Build and help message fix

Currently the build can fail if the repository is checked out to a new machine. There is a folder 'gen' that cointains automatically generated files that can prevent jflex from creating all the necessary files.
This pull request just deletes the 'gen' folder (which is already in the .gitignore file).
Additionally, there is a small fix in the help message (the option -help does not exist, only --help and -h, replaced with --help).

Thanks @joaobispo


fix: double scroll bar Issue on Mobile Navbar

Description
This pull request addresses the issue of having a double scroll bar on the mobile navbar.
Related issue(s)
Resolves #2480

@omidNM24 any progress??

clsoing this as there is no update from the contributor


Closing multiple documents requires single answer per document.

Issue Type: Bug
Open alot of unsaved documents.
Choose Close All
You are prompted for each document being closed.
In SSMS, it gives you a list in a single dialog.
SQL Operations Studio version: sqlops 0.31.4 (e026ab85a72c190cc4ccc834503aa9fe36dd6407, 2018-07-18T02:14:21.826Z)
OS version: Windows_NT x64 10.0.17134

System Info

Item
Value

CPUs
Intel(R) Core(TM) i7-6600U CPU @ 2.60GHz (4 x 2808)

GPU Status
2d_canvas: enabledflash_3d: enabledflash_stage3d: enabledflash_stage3d_baseline: enabledgpu_compositing: enabledmultiple_raster_threads: enabled_onnative_gpu_memory_buffers: disabled_softwarerasterization: disabled_softwarevideo_decode: enabledvideo_encode: enabledvpx_decode: unavailable_softwarewebgl: enabledwebgl2: enabled

Memory (System)
15.89GB (6.21GB free)

Process Argv
C:\Program Files\SQL Operations Studio\sqlops.exe

Screen Reader
no

VM
0%

Extensions (3)

Extension
Author (truncated)
Version

agent
Mic
0.31.4

profiler
Mic
0.1.2

whoisactive
Mic
0.1.1

I agree that this is really annoying, though this is the behavior we inherit from VS Code.  Not sure why they do it this way.  Let's investigate a bit.

We should have a setting to disable the save prompt on unsaved files.

I agree that there should be a setting to disable the warning completely.
I don't understand why I would ever want to save a query after I have run it against the database.

The file close, save as prompts are implement upstream.  We would prefer to see this addressed by vscode and will pick up any improvements.  If you use the Open Editors view in the File Explorer it should allow closing all unsaved documents with a single prompt.  Thanks for reporting this suggestion!


Rename actor to worker

PR Description
This PR renames actor to worker
Does not include deployment related things in .github/workflows/release-containers.yml

@EricGustin resolve these conflicts?


Added Greek translation

could you pull from staging instead of new-design. currently it will merge new-design into staging


[CHECKLIST] Implement successful deposit flow

Overview
The goal of this checklist is to create a comprehensive list of tasks that collectively make up the successful and unsuccessful deposit flow for dApp users.
Deposit Flow
Note: Assumes a user has already connected their wallet and created their note account.
Deposit Scene-1 | Data Input

Selects token to deposit into bridge - if non-bridged asset (e.g. webbETH) then force deposit and wrap flow
Select destination chain
Select amount to deposit

Deposit Scene-2 | Confirmation

User confirms they have copied the new spend note
User selects 'Deposit'

Deposit Scene-3 | Deposit In-progress

Display the progress of the deposit
User can select 'New Transaction' that will move progress view into accordion component to the right side and display deposit scene-1

Right-sided component

Task Checklist

[x] https://github.com/webb-tools/webb-dapp/issues/705
[ ] https://github.com/webb-tools/webb-dapp/issues/717
[ ] [TASK] Fix notification card for deposits and wrap and deposit
[ ] [TASK] Validating deposit inputs (e.g. balance)
[x] [TASK] Improve leaf fetching and fix caching
[x] Implement Deposit Scene-1 | Data Input
[x] Implement Deposit Scene-2 | Confirmation
[x] Implement Deposit Scene-3 | Deposit In-progress
[x] Implement successful Deposit transaction
[x] Test deposits for each chain with bridged asset
[x] Test deposits for each chain with non-bridged asset (e.g. deposit and wrap flow)

Relevant Figma Links
Figma Prototype
Wireframe File

Closed in #719


feat(acvm_js): Execute program

Description
Problem*
Resolves #4645
Summary*
In order to have a recursive execute_circuit function we now have a recursive async call. This requires boxing a future and having to making execute_circuit immutable in order to attach the final main witness to the witness stack. In our normal execution flow we could move the ProgramExecutor after our recursive async call to execute_circuit, we now need a lifetime on self.
I also switched all execute_circuit methods in ACVM JS to use execute_program under the hood so that we do not have a breaking change yet but can still test execute_program using all of our already existing tests.
I then added a couple extra acvm js tests for multiple acir calls and full witness stack (de)/compression.
Additional Context
Documentation*
Check one:

[ ] No documentation needed.
[ ] Documentation included in this PR.
[X] [For Experimental Features] Documentation to be submitted in a separate PR.

PR Checklist*

[X] I have tested the changes locally.
[X] I have formatted the changes with Prettier and/or cargo fmt on default settings.

@TomAFrench Should we ready again


Recipe validation error should contain recipe

What problem are you trying to solve?
I'd like to understand which recipe actually caused which validation error. Sample output from the Maven plugin:
[INFO] Validating active recipes...
[ERROR] Recipe validation error in runtime: is required
[ERROR] Recipe validation error in runtime: is required
[ERROR] Recipe validation error in runtime: is required
[ERROR] Recipe validation error in runtime: is required
[ERROR] Recipe validation error in runtime: is required
[ERROR] Recipe validation error in org.openrewrite.java.security.OwaspTopTen.recipeList[6] (in jar:file:/C:/Users/Admin/.m2/repository/org/openrewrite/recipe/rewrite-java-security/2.0.4/rewrite-java-security-2.0.4.jar!/META-INF/rewrite/owasp.yml): recipe 'org.openrewrite.java.security.OwaspA010' does not exist.
[ERROR] Recipe validation error in scope: is required
[ERROR] Recipe validation error in builderType: is required
[ERROR] Recipe validation error in builderType: must not be blank
[ERROR] Recipe validation error in cveList: is required
[ERROR] Recipe validation error in runtime: is required
[ERROR] Recipe validation error in runtime: is required
[ERROR] Recipe validation error in runtime: is required
[ERROR] Recipe validation error in runtime: is required
[ERROR] Recipe validation error in runtime: is required

The problem stems from the validation just collecting a list of failure messages, without any relation to the recipe(s): https://github.com/openrewrite/rewrite/blob/7ef3ffcb9d659eb57437ad47dce3ed474b719117/rewrite-core/src/main/java/org/openrewrite/Recipe.java#L318
Describe the solution you'd like
make validateAll(...) return a Map<Recipe, Collection<Validated>> instead, such that every build tool can show recipe and failure.

Hello, I hope you're all doing well! I'm a newcomer, and I think I have the required abilities to solve this issue.
Could you please assign it to me?
It would be a pleasure to contribute to your project!


[FEATURE] change default questions in FeedbackDataset templates

Is your feature request related to a problem? Please describe.
I think the default questions for the FeedbackDataset.for_sentence_similarity and FeedbackDataset.for_retrieval_augmented_generation should be changed from ratingquestion to rankingquestion or labelquestion, as the ArgillaTrainer for sentence similarity only accept those, this way we can keep the flow.
Describe the solution you'd like
A clear and concise description of what you want to happen.
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.

Sure thing. But I guess RatingQuestion is highly used for sentence similarity though Ranking seems fine as well. Maybe they can both exist to be comprehensive and to ensure the flow. What do you think @davidberenstein1957 ?

In fact, I have some more thoughts about this, we can maybe discuss it tomorrow

@sdiazlor I will close this. Can you create a new one for the things we discussed.


fix: get_filters nil op

Description
If filters isn't a supplied a function for config's get_filters, do_filters tries to operate on the default nil
This commit

fixes with a pcall safety check on the operation
updates doc files (.jax, .txt) with default nil value (default set in config.lua)

Issue Resolutions

#82

Thank you so much.
It helped me a lot.

Thank you so much. It helped me a lot.

You're welcome.  Thank you for Lir !


No module named network

Net模块问题
通过pip install dayu_ffmpeg 命令行安装了0.5版本的dayu_ffmpeg，在测试时系统提示没有叫做network的模块，报错信息粘贴如下:
Traceback (most recent call last):

File "/Users/peacockblue_dit/Documents/CodingProjects/LaLaLand/Test.py", line 1, in
from dayu_ffmpeg import  *
File "/Users/peacockblue_dit/Documents/CodingProjects/LaLaLand/venv/lib/python2.7/site-packages/dayu_ffmpeg/init.py", line 7, in
from network import *
ImportError: No module named network

you can install this module by
pip3 install network

this is caused by missing packages in setup.py.
now fixed.


Doesn't record space

I had this data
12
99
12
97
And I wanted it to look like this
12 99
12 97
But it always came out like this
1299
1297

I'm confirmed the problem.

I fixed it.
I divided the processing of the space and the other key,　try version 0.1.1. please.

Thx, it really works now, you are amazing fast! :)


For certain record types, navigating to URLs for records that don't exist throws 500s, not 404s

Just for interest, I tried navigating to pages for record IDs that I know don't exist in the database. I found that doings so leads to a server error for field contacts, incidents, and IA complaints.
See, for example:

field contacts: https://www.wokewindows.org/field_contacts/1234567
incidents: https://www.wokewindows.org/incidents/1234567
IA complaints: https://www.wokewindows.org/complaints/1234567

It would be better to return "404 Not Found" in these cases, as we do for other record types.
Update either the controller or the show.html.erb view for each of the above record types so that navigating to a non-existent record leads to a 404 error, not a 500 error.

Ahh, I see the problem here. I need to use find_by! (with the bang) to look up the record. If it's not found, find_by! raises a ActiveRecord::RecordNotFound exception which ActionController will translate into a 404.

merged


[Backend API] Implement endpoint for list of deployment models

Based on #169
Implement the endpoint

찜!!

제가 한번 해보겠습니다!!


ORM mode: Add support for arbitrary class instances

My take on ORM support. @tiangolo please let me know if this would work for you?
This is just a WIP, will need more tests and docs but I want your opinion on it before I got any further.
Related issue number
replace #520
Checklist

[ ] Unit tests for the changes exist
[ ] Tests pass on CI and coverage remains at 100%
[ ] Documentation reflects the changes where applicable
[ ] HISTORY.rst has been updated

if this is the first change since a release, please add a new section
include the issue number or this pull request number #<number>
include your github username @<whomever>

Thank you!
Let me pull it and play with it.

Hmm, I'm probably not understanding how to use _decompose_class.
I tried replacing the example from above with both suggestions and testing it (with the same test in the comment above) and it didn't work (I got testing errors).
The single line version I can get working, not breaking skip_defaults functionality, is:
    @classmethod
    def _decompose_class(model, obj: Any):
        return {field.name: getattr(obj, field.alias, _missing) for field in model.__fields__.values() if getattr(obj, field.alias, _missing) is not _missing}

But that's quite long. And it doesn't have into account allow_population_by_alias.

Hmm, so __get_pydantic_fields__ would be something users would add to an ORM class?

I'll look throught the rest of what you've said when I get a chance.

Thank you.

I think you're confused here _decompose_class is implemented on the model, it takes an instance of the ORM class, not a pydantic model.
Here's an example of it working with sqlalchemy:
from typing import List
from devtools import debug
from sqlalchemy import Column, Integer, String
from sqlalchemy.dialects.postgresql import ARRAY
from sqlalchemy.ext.declarative import declarative_base
from pydantic import BaseModel, constr

Base = declarative_base()

class Company(Base):
    __tablename__ = 'companies'
    id = Column(Integer, primary_key=True, nullable=False)
    public_key = Column(String(20), index=True, nullable=False, unique=True)
    name = Column(String(63), unique=True)
    domains = Column(ARRAY(String(255)))

co = Company(id=123, public_key='foobar', name='Testing', domains=['example.com', 'foobar.com'])
debug(co, co.__dict__)

class CompanyModel(BaseModel):
    id: int
    public_key: constr(max_length=20)
    name: constr(max_length=63)
    domains: List[constr(max_length=255)]

debug(CompanyModel.parse_obj(co))

outputs:

Which is surely what you want?

_decompose_class is just converting a class (eg. an ORM item instance) into a dict which pydantic can process as it normally would. Aliases will work fine.

Ah, yes, I think I understand. The first parameter is the same Pydantic class itself (being a @classmethod) and the second parameter is the arbitrary object.
Generating a dict with whatever can be extracted from the object is more or less what I'm already doing in the jsonable_encoder in FastAPI, in fact, I have a bit of hacky/ugly code to omit those _sa attributes.
The jsonable_encoder, used that way, has created several problems:

Relationships are not fetched populated, even if declared as attributes in the Pydantic model.
Dynamic and hybrid properties don't work.
Some types of IDs (I think?) didn't work either.

In general, things that were fetched/generated by SQLAlchemy on attribute access, with __getattr__

Ok, what about this?
I'm now wrapping classes in GetterDict, which will mean converting an ORM instance to a dict is not longer eager and @property etc. should work.
Unfortunately there's no obvious way to check if something is an instance of some class to process or a simple variable why like int, so we have to project this feature behind orm_mode. There might be a better way of doing this.
Does this work better?
If so can you like with orm_mode config switch?

Hacky McHack face.
:joy:

This looks great, thank you!
I'm finishing a big uncommitted mess/work in progress in FastAPI, so I haven't been able to install it and test it locally with the changes in FastAPI I had created for it. But as soon as I finish this mess (commit/discard) I'll switch to that branch and test it.

I was finally able to test this properly for the last 2 hours or so.
With this, I can solve all the use cases I can imagine. Including SQLAlchemy hybrid properties and others.
That's awesome. Thank you! :tada: :rocket: :cake:
And yes, I think orm_mode is fine.

great news!
I'm going to release v0.27 since it's got cython on it, I don't want to add any more complication to it.
I'll then work on completing this and we an add it to the next release.

Cython! I'm pretty excited about that too. :rocket:

That's awesome! Thank you for this. I know you're not into ORMs, but thanks for putting the effort into finding a way to solve it :tada: :cake:
I think there's quite a bunch of people that will be excited about it :smile:

@tiangolo please review and let me know if you're happy with this.

Great! I'm on it.

:tada: This is great! Thanks!
I know several people that will celebrate it. :tada: :cake:


feat: add keys() and vals() for AssocList

Dear @dpanchenko,
In order to potentially merge your code in this open-source repository and therefore proceed with your contribution, we need to have your approval on DFINITY's CLA.
If you decide to agree with it, please visit this issue and read the instructions there. Once you have signed it, re-trigger the workflow on this PR to see if your code can be merged.
— The DFINITY Foundation

Resolves https://github.com/dfinity/motoko-base/issues/581

I don't know about the size requirement for keys() and vals(). Does anyone know if it is really O(1)?


Make network interface names predictable

Related issue
https://github.com/harvester/harvester/issues/1197
NOTE: The UX in the network config dialog needs to be improved.
It takes time to configure IPs, using a spinner will be better.

We used the mgmtInterface as the kube-vip.config.vip_interface in helmchartconfig. Need to evaluate the impact on vip side with this change @yaocw2020

additionally, the time to get the IP of each NIC is comparatively slow, can we either improve it or add spinner for now, thanks

We used the mgmtInterface as the kube-vip.config.vip_interface in helmchartconfig. Need to evaluate the impact on vip side with this change @yaocw2020

It is supposed to have no impact on the VIP.

Adding net.ifnames should also be included in the ipxe-examples.

Adding net.ifnames should also be included in the ipxe-examples.

https://github.com/harvester/ipxe-examples/pull/14
A PR is created, thanks!


Refactor: Optimize subnode cursor trie search

optimizes the CursorSubNode implementation and should increase performance when searching Trie
I think this coulde be made constant and further increase in performance if we use de bruijin sequence(https://en.wikipedia.org/wiki/De_Bruijn_sequence) for the trie traversal
This should are actually minor perf and most times the compiler should be able to predict them ahead of time but with increasing complexity, this should matter more.

can you share a benchmark showing the improvement? ty!

nice thx for taking time...can you share a benchmark showing the improvement? ty!

saw this late
the creation was slow significantly for new v2 compared to the old v1 apart from that all other methods were significantly faster, so I made no modifications to the he creation
makes the v2 efficent for workflows
Gnuplot not found, using plotters backend
CursorSubNode/v1/creation/10
time:   [173.27 ns 176.15 ns 179.84 ns]
change: [-16.041% -14.127% -12.196%] (p = 0.00 < 0.01)
Performance has improved.
Found 14 outliers among 100 measurements (14.00%)
3 (3.00%) low severe
2 (2.00%) low mild
6 (6.00%) high mild
3 (3.00%) high severe
CursorSubNode/v2/creation/10
time:   [193.31 ns 193.82 ns 194.39 ns]
change: [-30.076% -26.448% -22.925%] (p = 0.00 < 0.01)
Performance has improved.
Found 7 outliers among 100 measurements (7.00%)
1 (1.00%) low severe
2 (2.00%) low mild
4 (4.00%) high mild
CursorSubNode/v1/flags/10
time:   [18.298 ns 18.424 ns 18.585 ns]
change: [-22.675% -20.859% -19.190%] (p = 0.00 < 0.01)
Performance has improved.
Found 7 outliers among 100 measurements (7.00%)
1 (1.00%) low mild
4 (4.00%) high mild
2 (2.00%) high severe
CursorSubNode/v2/flags/10
time:   [12.541 ns 12.570 ns 12.599 ns]
change: [-15.280% -12.794% -10.302%] (p = 0.00 < 0.01)
Performance has improved.
Found 4 outliers among 100 measurements (4.00%)
1 (1.00%) low severe
2 (2.00%) low mild
1 (1.00%) high severe
CursorSubNode/v1/full_key_access/10
time:   [4.3963 ns 5.1150 ns 6.1200 ns]
Found 11 outliers among 100 measurements (11.00%)
2 (2.00%) low mild
1 (1.00%) high mild
8 (8.00%) high severe
CursorSubNode/v2/full_key_access/10
time:   [4.2726 ns 4.2893 ns 4.3057 ns]
Found 6 outliers among 100 measurements (6.00%)
5 (5.00%) low mild
1 (1.00%) high mild
CursorSubNode/v1/creation/100
time:   [1.4077 µs 1.4108 µs 1.4144 µs]
Found 4 outliers among 100 measurements (4.00%)
1 (1.00%) low mild
3 (3.00%) high mild
CursorSubNode/v2/creation/100
time:   [1.6494 µs 1.6530 µs 1.6569 µs]
Found 7 outliers among 100 measurements (7.00%)
3 (3.00%) low mild
2 (2.00%) high mild
2 (2.00%) high severe
CursorSubNode/v1/flags/100
time:   [183.28 ns 183.87 ns 184.46 ns]
Found 5 outliers among 100 measurements (5.00%)
4 (4.00%) high mild
1 (1.00%) high severe
CursorSubNode/v2/flags/100
time:   [117.33 ns 118.97 ns 121.57 ns]
Found 6 outliers among 100 measurements (6.00%)
4 (4.00%) high mild
2 (2.00%) high severe
CursorSubNode/v1/full_key_access/100
time:   [48.662 ns 49.426 ns 50.248 ns]
Found 15 outliers among 100 measurements (15.00%)
11 (11.00%) low severe
2 (2.00%) low mild
2 (2.00%) high mild
CursorSubNode/v2/full_key_access/100
time:   [46.455 ns 47.299 ns 48.104 ns]
Found 15 outliers among 100 measurements (15.00%)
2 (2.00%) high mild
13 (13.00%) high severe
CursorSubNode/v1/creation/1000
time:   [15.873 µs 16.212 µs 16.623 µs]
CursorSubNode/v2/creation/1000
time:   [17.846 µs 18.142 µs 18.460 µs]
Found 5 outliers among 100 measurements (5.00%)
2 (2.00%) high mild
3 (3.00%) high severe
CursorSubNode/v1/flags/1000
time:   [2.1929 µs 2.2260 µs 2.2651 µs]
Found 1 outliers among 100 measurements (1.00%)
1 (1.00%) high severe
CursorSubNode/v2/flags/1000
time:   [1.6790 µs 1.7216 µs 1.7599 µs]
Found 1 outliers among 100 measurements (1.00%)
1 (1.00%) high mild
CursorSubNode/v1/full_key_access/1000
time:   [447.02 ns 455.55 ns 467.90 ns]
Found 1 outliers among 100 measurements (1.00%)
1 (1.00%) high severe
CursorSubNode/v2/full_key_access/1000
time:   [435.66 ns 436.18 ns 436.70 ns]
Found 14 outliers among 100 measurements (14.00%)
3 (3.00%) low severe
5 (5.00%) low mild
5 (5.00%) high mild
1 (1.00%) high severe


(PUP-7225) Remove the Puppet binder

This PR must be merged after PR-5647. It contains the commits needed to remove the Puppet Injector/Binder and replace it with a much simpler mechanism for plugins that uses the Puppet context.

CLA signed by all contributors.

While the change "Let the PP parser return the AST model instead of a factory" is the right thing to do, it modifies an API that others use and it will require updates in a couple of places; Cory Osman's "Puppet Debugger", (and most likely) "Puppet Strings". There is also documentation related to the Parser API that needs an update. I think these changes are containable, but it does require new releases and we want Puppet 5.0.0 to have as little churn as possible.

ok, there are other AST changes that requires downstream to change (RGen Enums are Symbols vs. Pcore String values).

The commit "Add Rake task for generating the AST model from Pcore" talks about "hen and egg" - in English it is "chicken and egg" :-)


[CT-784] When using --log-format json, exceptions during query execution result in JSON Serialization errors

Describe the bug
When an Exception is raised during query execution, and the log format is set to json, a JSON serialization exception will be raised instead of the original Exception.
Steps To Reproduce
Create a dbt project with the following model:
select * from foo.bar

and run dbt --log-format json run
Expected behavior
The error message should be something along the lines of:
404 Not found: Table my-dataset:foo.bar was not found in location US"
Screenshots and log output
The actual error message (once parsed out of the "msg" field of the json logs: dbt --log-format-json run | jq .msg):
"Completed with 1 error and 0 warnings:"
"Compilation Error in macro statement (macros/etc/statement.sql)"
"  Object of type NotFound is not JSON serializable"
"  "
"  > in macro materialization_table_bigquery (macros/materializations/table.sql)"
"  > called by macro statement (macros/etc/statement.sql)"

System information
The output of dbt --version:
Core:
  - installed: 1.1.1
  - latest:    1.1.1 - Up to date!

Plugins:
  - bigquery: 1.1.0 - Up to date!

The operating system you're using:
macOS Catalina
The output of python --version:
Python 3.8.7
Additional context
This is happening because of this line: https://github.com/dbt-labs/dbt-bigquery/blob/main/dbt/adapters/bigquery/connections.py#L217
With the default log formatter, this Exception will be automatically stringified. The json log formatter instead just takes the raw exception and attempts to convert it to JSON.

@OwenKephart Thanks for opening, and for the clear explanation!

This is happening because of this line: https://github.com/dbt-labs/dbt-bigquery/blob/main/dbt/adapters/bigquery/connections.py#L217

This is exactly right.
I believe this is the same underlying issue as the one we caught here: https://github.com/dbt-labs/dbt-spark/pull/371. That is, this line is not appropriately stringifying a complex object that's passed into the AdapterLogger, which results in serialization errors. I'm going to open a dbt-core ticket to track that work accordingly. I'm not strictly opposed to the change in https://github.com/dbt-labs/dbt-bigquery/pull/207 as a temporary salve, but the real solution should live in dbt-core.

Hiya people on the thread.
Per this core PR, this JSON serialization bug should be solved across all adapters, although I specifically verified the bug & fix on a bigquery cluster. There's a lot of layers of indirection in the logger call stack, so finding the root cause of this error took us some concerted time. I should have corrected this while addressing similar JSON issues in our  core/dbt/events/ package.
I'd love to close this if (🤞) people report things working here.


Moved set PROPERTIES LANGUAGE HIP into cmake/dca_linking.cmake

Note: need to try using pinned host memory with HIP
see include/dca/linalg/util/allocators/vectors_typedefs.hpp


Force form_params to use & as fields separator

According to w3.org separator should always be &

Thanks!


LEGO: Pull request from lego/hb_04604851-bac4-4681-9f74-73de611d6e48_20210718093417348 to main

LEGO: Pull request from lego/hb_04604851-bac4-4681-9f74-73de611d6e48_20210718093417348 to main with localized lcls

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 42.566%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
26721

Relevant Lines:
56896

💛  - Coveralls


Replacing clear plugin with reset plugin

A quick glance suggests that the “clear” plugins you have defined could possibly be replaced with the reset plugin.
If you tried that out, and some feature was missing, then perhaps that missing feature could be backported into the core lib to reduce the amount of app code you need to write 🙂
Also, in the next release (2.5), you will be able to set the resource meta using built-in tools, so the meta plugin that you have can also be removed from the app :v:
Thanks for reading!

@jmeas Thanks, i'll try to use reset plugin, also will check new release.

Unfortunately we can't use this plugins, because we have indexedList plugin, since we need indexed list for react-virtualized.


Mangdian/drop decode

Same with Pr #2786

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.1 out of 2 committers have signed the CLA.:white_check_mark: yhcao6:x: mangdianYou have signed the CLA already but the status is still pending? Let us recheck it.


Incomplete contributors list

Describe the bug
It came to my attention that some code contributors do not appear in the list of contributors provided by GitHub.
Essentially, the output of
git shortlog -sne

differs from https://github.com/cta-observatory/ctapipe/graphs/contributors
This is apparently due to differences in emails that people use in their GitHub account and the ones used to commit code (thanks @maxnoe for the explanation).
The issue is that we currently rely on GitHub to provide the list of contributors to Zenodo when doing a release.
Moreover, we might also want to give credit to other contributors that did not commit code but still have made an important contribution.
To Reproduce
Steps to reproduce the behavior:

git shortlog -sne
Compare to https://github.com/cta-observatory/ctapipe/graphs/contributors
or to https://zenodo.org/record/7118605

Expected behavior
All contributors are credited.
Additional context
In the context of FAIRness, a complete metadata file should be included in the repository.
We have the same issue in basically all repository.

This problem would be lessened, if GitHub would actually use .mailmap, but it doesn't. So yes, we should add a .zenodo.json for the zenodo deployment.
@vuillaut you know better what the best way for that is: directly writing zenodo.json? Or using something else and then automatically creating it

For the past zenodo entries, @kosack can also edit the author list, if we wish to make that effort.

@maxnoe
Ultimately, yes we should write a .zenodo.json I think. I am considering different solutions here...
You are right, there is some kind of hidden magic here, but I don't think it's based on mailmap, I see no reference to mailmap in the zenodo backend code... 🧐

We should add updating AUTHORS.md to the release procude documented in the developer guide

Reopening since this got auto-closed, but there is still the issue of previous releases.  Should we edit one or more of the previous releases to include the correct authors, or just wait for the next release?

Also, perhaps we can do a CI check like using the git shortlog output and seeing if any entries are not in AUTHORS to avoid forgetting to add new contributors?


Have factotum fill nuker and power spawn

This Pull Request has been merged by GitConsensus.
Vote Totals

Yes
No
Abstain
Voters

3
0
0
3

Vote Breakdown

User
Yes
No
Abstain

tedivm
✔

dragoonreas
✔

PostCrafter
✔

Vote Results

Criteria
Result

Has Quorum
True

Has Votes
True


Integrated "versioning" for jobs

Currently, jobs can only be viewed in read-only mode. This means that debugging becomes harder as the code cannot (unless the user knows their way through the UUID structure in the file manager) be changed.
In a way a job is a certain version of the pipeline that is running, i.e. a "git commit". The user should then be able to open the job in the pipeline editor in order to facilitate debugging.

When thinking about a solution we should have a more extensive look at projects like DVC.

Idea: Instead of showing a date at "Snapshot created at" in the Job list view it could show a commit.

There is a good chance there will be more job snapshots than git commits. I.e. different snapshots will have uncommited changes that make it look like the same job is run because the commit it the same while the files have changed.
I feel like that’s pretty natural, you typically commit when you’re “done” or at some natural junction not for every idea you’re testing.
This becomes different if we auto branch+commit the working directory when a job is created.


Include security warning for 3rd party agents

Include security warning for 3rd party agents in the agent's overview page.

Thanks for adding the warning @eduarddfinity !


item click invalid in loop mode

loop模式 导致图片点击失效
item click invalid in loop mode

#28 #21

Hi.
I'm facing the same problem like described here and in #28 and #21. However, because I don't understand Chinese and even Google Translate didn't give me very good translation, I have to ask:
Is there any way how to make slider items clickable when the loop is set to true?
Or, if I switch the loop off, is there any other way how to create infinite slider, so after the last slide I will show the first one etc.?
Thanks for any hint...

@rkrejcii

close loop option
use custom event, like:

<swiper-slide @click.native="linkToSomePage(slide.link)">

@surmon-china : Thanks a lot for your quick reply.
However, it still doesn't work.
Could you please take a look on this Codepen https://codepen.io/rkrejcii/pen/yowqaX and tell me why two slides don't react on click event as all other do?
Thanks.

@rkrejcii
Because, if the loop option is enabled, the swiper will copy two dom nodes at the beginning and end, but the event will not be copied, so any event bound is invalid. In addition, the loop option will cause a lot of unpredictable problems, which is the swiper It is recommended to avoid the use; In addition, the final solution should be:
 <swiper :options="swiperOption" @click.native="slideClicked(swiper.activeIndex.slide.link)">
      <swiper-slide v-for="(slide, index) in [1, 2, 3, 4, 5, 6, 7, 8, 9, 10]">
        Slide {{ index }}
      </swiper-slide>
</swiper>

@surmon-china解决了。谢谢
<swiper :options="swiperOption" @click.native="slideClicked(swiper.activeIndex.slide.link)">       <swiper-slide v-for="(slide, index) in msg">         Slide {{ index }}       </swiper-slide> </swiper>
methods:{             slideClicked(index){                 let dataIndex = index%2 - 1                 console.log(this.msg[dataIndex])             }         }
this.msg中的下标即为点击的对象。可以继续执行下一步操作了。

This is the solution:

<swiper-slide onClick="_this.onSelected(this)" ...>
created () {
window._this = this
}
methods: {
onSelected (object) {
var index = object.attributes['data-swiper-slide-index'].nodeValue
console.log('you have selected slide' + index)
},
}


Skip test2

Added SKIP option.

@macpijan for the current I will leave open this PR - maybe someday we might rebase it and prepare the new upstream PR

It's in this "maybe" state for 4 years already.
Haven't you mentioned that the SKIP option was already added in more recent RF releases?

According to the docs, SKIP is available from RF 4.0. Taking this into account, I close the issue


[#fixtest] fix plugin test's version range

Codecov Report

Merging #6051 into master will decrease coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #6051      +/-   ##
==========================================
- Coverage   40.73%   40.71%   -0.03%
==========================================
  Files        3018     3018
  Lines       90488    90488
  Branches    11816    11816
==========================================
- Hits        36861    36839      -22
- Misses      50468    50484      +16
- Partials     3159     3165       +6

Impacted Files
Coverage Δ

...p/pinpoint/rpc/client/WriteFailFutureListener.java
56.25% <0%> (-18.75%)
:arrow_down:

...vercorp/pinpoint/rpc/packet/ServerClosePacket.java
52% <0%> (-16%)
:arrow_down:

...vercorp/pinpoint/rpc/packet/ClientClosePacket.java
55.55% <0%> (-11.12%)
:arrow_down:

...pinpoint/profiler/instrument/AccessorAnalyzer.java
57.14% <0%> (-8.58%)
:arrow_down:

...rc/main/java/com/navercorp/pinpoint/test/Item.java
66.66% <0%> (-6.67%)
:arrow_down:

...rp/pinpoint/rpc/server/PinpointServerAcceptor.java
84.1% <0%> (-4.64%)
:arrow_down:

...orp/pinpoint/rpc/server/DefaultPinpointServer.java
79.92% <0%> (-0.36%)
:arrow_down:

...m/navercorp/pinpoint/rpc/client/ConnectFuture.java
85% <0%> (ø)
:arrow_up:

...collector/receiver/grpc/ShutdownEventListener.java
25% <0%> (+25%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 63553a5...d0d9a33. Read the comment docs.


Results without Highlights / Snippets

I have a collection of documents, all of which have OCR'd text in the Item Type Metadata field named Text, which gets indexed by the SolrSearch plugin. Sometimes when I do a search, I get results which do not have a snippet, even though other items returned in the same query do have a snippet, from the same metadata field.
Has anyone else experienced a similar behavior before?

I haven't seen this, but I'll try to reproduce it.

Is there a log file I could check? I checked the query result with a debugger and there where indeed no highlight snippets returned.

Not that I can think of.
By the way, what version of Solr are you running? They sometimes change snippets calls, so I'd like to make sure I'm working with the same one.

Solr 4.10.2
The odd thing is that the same query returns both, results with and without snippets.

Thanks.
My experience has been that snippets are temperamental.

That makes me feel better ;)

@anuragji , I've been trying to replicate this, but I haven't been able to yet. If you have any PDFs that this is happening with, could you email them to me, please? That would be immensely helpful.
(And sorry it's taken me so long to get back to this. I'm hoping to push out a new release of this plugin in this summer.)

I am out of the office this whole week,  but will try to send you a PDF once I get back next week.
Thanks!

That sounds great! Thanks

Alas, I checked with the clients, since all the PDFs in question are part of a private collection and they do not want me to forward them to you. I am really sorry that I cannot be of more help.

Thanks for checking. I'll poke at it some more.

Hopefully your issue was just that the hits weren't close enough to the beginning of the document.
If that's the case, then when this is released, look for the option Extent of Document Highlightable on the Results configuration tab. Make its value larger.


Automated Build

https://goreleaser.com/ and GitHub Actions

Closed by #13
At least good enough for now


Add schema file name accessor to each DOM type C++ class

Desired behavior
Getting the schema file for each SDF DOM type element should be possible.
This should make initializing an element for loading standalone DOM types easier.
Without this format. I am doing something like this in my code to initialize a DOM type element so that I can get type checking
// Schema file type
template <typename T>
struct SdfTypeToSchemaFile {
  static const std::string kSchemaFile;
};

template <>
const std::string SdfTypeToSchemaFile<sdf::Surface>::kSchemaFile = "surface.sdf";
// Other definitions with template specialization.

template <typename T>
sdf::ElementPtr init_element_for_type(){
  auto element = std::make_shared<::sdf::Element>();
  sdf::initFile(SdfTypeToSchemaFile<T>::kSchemaFile, element);
  return element;
}

Ideally, I hope to do something like this for simplicity.
template <typename T>
sdf::ElementPtr init_element_for_type(){
  auto element = std::make_shared<::sdf::Element>();
  sdf::initFile(T::SchemaFile(), element);
  return element;
}

Alternatives considered
Implementation suggestion
Implement a static function for each DOM type. For example for Surface:
// sdformat/include/sdf/Surface.hh
class Surface{
  // Omitted details
  public: static const std::string& SchemaFile();
};

// sdformat/src/Surface.cc

static const std::string& Surface::SchemaFile(){
  static const std::string* kSchemaFile = new std::string("surface.sdf");
  return *kSchemaFile;
}

Additional context
Currently the schema file is hard coded in it's T::ToElement() for example:
https://github.com/gazebosim/sdformat/blob/c4bfe35bdaca8e667089bf9adf99b7930192ccaf/src/Surface.cc#L412

Hi, could you please assign this to me?
Just to confirm, what would be the list of all DOM elements which would need this feature?
Also would it be advisable to add a test for this in the default construction or is this unnecessary?
Thanks.

Hi, could you please assign this to me? Just to confirm, what would be the list of all DOM elements which would need this feature? Also would it be advisable to add a test for this in the default construction or is this unnecessary?
Thanks.

The schemas are in sdformat/sdf/1.11 for the current version. The DOM elements corresponding are mostly located in sdformat/include. The names roughly matches each other regardless of the casing(snake_case for sdf and CamelCase for class).

Hi @qingyouzhao, I may have implemented the required changes on my personal fork of the repository aagrawal05/sdformat on the schema_accessor branch.
Brief summary of the work I've done:

I've created a script format_sdf.py which reads from the /sdf/1.11 folder and generates/updates the source for all the relevant classes in the src/ and include/ directories as per the suggested implementation.
There were DOM elements  navsat.sdf and forcetorque.sdf for which the script does not work and I had to manually edit the script because their naming convention did not match the camel-case conversion (they would need to benav_sat.sdf and force_torque.sdf) This may be undesirable from a code style perspective but may be a breaking change—this is a minor point but I just wanted to point it out.
The code builds successfully, I have not thoroughly tested it but it does seem to work.
I can add tests for the SchemaFile in all the DOM element tests but I thought it might be overkill because the names are hardcoded in the method anyways. I can add it easily with the script if needed.

I can delete the format_sdf.py from the commit as well, if it's no longer useful. Or I could place it in the sdf 1.11 folder similar to the embedSdf.py—not sure if it's relevant.
Could you please take a look and let me know if anything needs to be changed—I'd be happy to make any edits.


AQCU-1599: estimated data display issues for UV Hydro

sort the estimatedPeriods by startDate before creating gaps for estimated periods, otherwise we lose data.

Coverage increased (+0.0004%) to 98.047% when pulling ce8b04fcdbdf02d3370c40f44e28cc85fcb4aee0 on mhines-usgs:AQCU-1599 into e678a3721ac62d8ac52cf281c8582168b76623e1 on USGS-R:master.

Coverage increased (+0.0004%) to 98.047% when pulling ce8b04fcdbdf02d3370c40f44e28cc85fcb4aee0 on mhines-usgs:AQCU-1599 into e678a3721ac62d8ac52cf281c8582168b76623e1 on USGS-R:master.

There is still a little work on the JIRA to eliminate an unwanted gap, but merging this would help Chuck with some testing now. @zmoore-usgs mind taking a quick look so I can merge?


Cuda out of memory: training patchcore on custom dataset

Training patchcore model (for classification task) quickly fills all GPU memory (32G) and throws an error:
RuntimeError: CUDA out of memory. Tried to allocate 8.29 GiB (GPU 0; 31.75 GiB total capacity; 24.92 GiB already allocated; 2.77 GiB free; 27.75 GiB reserved in total by PyTorch) If reserved memory is >> allocated memory try setting max_split_size_mb to avoid fragmentation.  See documentation for Memory Management and PYTORCH_CUDA_ALLOC_CONF
Epoch 0:   6%|▋         | 232/3612 [00:12<02:56, 19.15it/s, loss=nan]
Custom dataset consist of ~7000 256x256 RGB images for training. Changing bath size to a single image still ends with the same error. Training on mvtec dataset goes smoothly.

I also encounter the same error on my custom datasets. However, what I did was reducing the image_size to 128, 64 or 32 as well depending the algorithm used.
I guess there are some limitation on the number of training images therefore my best guess is reducing the number of images during training might solve the problem.

Hi, PatchCore is a memory-intensive algorithm because it stores features extracted from the training set in an internal memory bank. Using a smaller batch size does not solve the problem unfortunately, because the features extracted from each batch still need to be kept in memory.
This is especially a problem for datasets consisting of a large number of images. We are aware of this problem, and it is on our planning to work on memory optimizations for this algorithm. In the mean time, you could try @yonafalinie's suggestions, and use a smaller image size or train with a smaller subset of your training data. Both these modifications would result in a smaller size of the memory bank. Another way to reduce the size of the memory bank is to use a smaller model as backbone, e.g. resnet18.

This is a duplicate of #203. Closing this to could continue our discussion there. Thanks!


Tab reconfiguration

[ ] Remove the 'Overview' tab
[ ] Move the 'Template name/version' info from the Overview tab to the Write Plan tab
[ ] Move the Sharing form into the Conributors tab and rename it to 'Collaborators'
[ ] Rename the Download tab to Finalize/Publish

Note to @mariapraetzellis that I need to update user documentation & make a post informing folks about this change.
The new tabs are in staging now so can use this for screenshots.

Note to @mariapraetzellis that I need to update user documentation & make a post informing folks about this change.
The new tabs are in staging now so can use this for screenshots.


Other stage script formatting options

It would be great to have these stage script formatting options:
Scene: The scene location.
Time: When the scene takes place
Setting: A description of the scene
At Rise: What is happening as the scene begins
Below is an example of the formatting of each of these:

Just being curious, how does this visually differ from issue #15 ? (like a table without drawn lines)

A little. The characters would be formatted more like this:

So the main difference is (just) the underlining?

And the colons, which I pointed out in that other thread as a potential problem with using those as delimiters.

you forgot stage directions need to be added the syntax
it could be
+stage directions+
https://www.youtube.com/watch?v=QnTOxfu2RXw&t=82s

@severdia Can't you use synopses syntax or do you need it to be more metadata-style? In that case, maybe you could utilize a frontmatter
@severdia Couldn't you use a table for dramatis personae?
@Reaper10 Would be cool if markdown added text-align:right syntax so Fountain could just use this. For the time being, you could misuse transitions for the time being

@severdia Can't you use synopses syntax or do you need it to be more metadata-style? In that case, maybe you could utilize a frontmatter

This is not front matter or synopses. It's typically act or scene metadata.

@severdia Couldn't you use a table for dramatis personae?

Yes, that's what I was proposing, but there was no response, so I implemented what was discussed in the other issue for my own purposes.

@severdia But front matter is for storing metadata. That's why I suggested it.
Is this implementation public?

@shaedrich But it isn't front matter. The implementation is in this app: https://apps.apple.com/us/app/scriptigo-pro/id1444743519

@severdia I'm not talking about dramatis personae, I was talking about this:

Scene: The scene location.
Time: When the scene takes place
Setting: A description of the scene
At Rise: What is happening as the scene begins

Yeah, it's in the app but it's non-standard. Nobody prevents you from using this app but it's not implemented into Fountain (yet)

@shaedrich Yes, those items are not front matter. They could be at the beginning of every scene in the script. Front matter is literally the front of the script (typically first page only).

@severdia Does it have to be?

Yes, they're essentially key-value pairs. Yes, they're needed at the beginning of each scene. I didn't create the format. It's a convention.


Check for Field Permission When Adding Undeliverable Address to Contact Merge Page

Add field-level security checking before adding the undeliverable address field to the contact merge page.
Critical Changes
Changes
Issues Closed
Community Ideas Delivered
Features Intended for Future Release
Features for Elevate Customers
New Metadata
Deleted Metadata

Do we need a doc update to Contact Merge config that says you need FLS on the Undeliverable field? If so, just the Contact one, or all three?


JAVA-17525 upgrade kotlin, java, mockito versions

[retest this please]
Note: this comment is for the CI build. No action is required from the author.


Download is broken

Describe the bug
Team member uploads the file, copies the link but when we visit the link, download does not happen! It simply redirects us to homepage(login page if not logged in)
To Reproduce
Upload the file
Click on 3 dots, click copy link
Try visiting that copied link from private tab
Expected behavior
It should download the file
Environment (please complete the following information):

FileGator Version 7.4.4
Server: Apache 2.4
PHP Version 7.4
Browser All

Additional context
Sometimes it works, sometimes it doesn't!

Duplicate #117


RequestUrl missing slash

There's a slash missing after the base url in the request url on swagger ui.
The path in the outputted JSON is wrong. Also all the slashes are being escaped in the JSON output. Is that normal?
I'm ending up with this.
http://localhost:3000api/v2/account/billing

Here's my config
class Swagger::Docs::Config
    def self.transform_path(path, api_version)
      # Make a distinction between the APIs and API documentation paths.
      "/apidocs/#{path}"
    end
  end

  Swagger::Docs::Config.register_apis({
    '1.0' => {
      controller_base_path: '',
      api_file_path: 'public/apidocs',
      base_path: 'http://localhost:3000',
      #base_api_controller: "ApiController",
      clean_directory: true,
      camelize_model_properties: false
    }
  })

Faced the same issue. Created a pull request fixing the same.

For those of you who don't want to use a forked repo and wait for the path @pranavpr did to be integrated you can put this monkey patch in config/initializers/swagger_docs.rb (or whatever your initializer is called to fix it as an interim solution.
class Swagger::Docs::Generator
  def self.trim_slashes(str)
    "/" + trim_leading_slash(trim_trailing_slash(str))
  end
end

Thanks perldork!! totally worked, so helpful!!

Thanks @perldork, it works perfectly!

+1. I was pulling my hairs out with this bug too!

+1,I have the error too,and I used perldork's code,but api-docs.json's path don't change
api-docs.json
{
apiVersion: "1.0",
swaggerVersion: "1.2",
basePath: "http://localhost:3004/",
apis: [
{
path: "users.{format}",
description: "Users"
}
],
info: {
title: "Swagger Sample App",
description: "This is a sample description.",
termsOfServiceUrl: "http://helloreverb.com/terms/",
contact<EMAIL_ADDRESS>license: "Apache 2.0",
licenseUrl: "http://www.apache.org/licenses/LICENSE-2.0.html"
}
}

users.json
{
apiVersion: "1.0",
swaggerVersion: "1.2",
basePath: "http://localhost:3004/",
resourcePath: "users",
apis: [
{
path: "/users",
operations: [
{
summary: "Fetches all users",
responseMessages: [
{
code: 401,
responseModel: null,
message: "Unauthorized"
},
{
code: 406,
responseModel: null,
message: "Not Acceptable"
}
],
method: "get",
nickname: "Users#index"
}
]
}
]
}

I'm seeing the same thing. @perldork's suggestion corrects the path in the resource file users.json but still needs to be fixed for the api-docs.json as @xuyao91 suggests.

@xuyao91 On line 71 of the generator.rb file i replaced:

@xuyao91 On line 71 of the generator.rb file for swagger docs I added a forward slash to the  path
From This:
resource_api = {
                path: "#{Config.transform_path(trim_leading_slash(debased_path), api_version)}.{format}",
                description: ret[:klass].swagger_config[:description]
              }

To This:
resource_api = {
                path: "/#{Config.transform_path(trim_leading_slash(debased_path), api_version)}.{format}",
                description: ret[:klass].swagger_config[:description]
              }

adding this to the swagger config file also did the job:
def self.transform_path(path, api_version)
    # Make a distinction between the APIs and API documentation paths.
    "/apidocs/#{path}"
  end

@perldork Thanks for the fix!
@richhollis Does it really cost you so much to keep a gem updated with the contributions from its users...?

Fixes in my fork.
gem 'swagger-docs', git: 'https://github.com/amberteam/swagger-docs'

+1 grrr

Thanks to all on this thread.
v0.2.0 attempts to address this issue by removing the trailing slash on the base path and by adding it to api paths.


Get request in bad format

I have this problem
When I make the request to my backend, flutter receives the json with a bad format, as you can see in the image
But there are times when if you receive the request well and process it properly, the error is totally random. This happens mostly when the request result is large
Now, if I make the request by another means, such as postman or even the same browser, the request always comes in handy.

@EnmanuelAlx
Not sure if this issue is related to Flutter framework, as you said flutter receives the json with a bad format which indicates the data in bad format could be coming from the backend you are calling. Flutter processes the json from the server / backend and then decodes it to render in UI.
Please see https://flutter.dev/community for resources, you may also get some help if you post it on Stack Overflow and if you need help with your code, please see https://www.reddit.com/r/flutterhelp/
Closing, as this isn't an issue with Flutter itself. If you disagree, please write in the comments and I will reopen it.
Thank you


Service Account Updates

Updating documentation to reflect proper apply syntax when updating via File

This change is

@jrnt30 Is this correcting an inaccuracy, or a code change in the 1.6 release?

An inaccuracy in the command

I actually wouldn't expect to use apply for this... replace is correct

@jrnt30 FYI, docs/user-guide/service-accounts.md has moved to /docs/tasks/configure-pod-container/configure-service-account.md which is why there is a merge conflict. Please apply your changes to the new location. Thx

@jrnt30 Is this PR still active? How do you want to address the feedback from @liggitt ?


Line chart: the color of the line and the legend differs when multiple splits are selected

When multiple splits are selected, the color of the line and the legend are different.

Community issue

This issue has been mirrored in Jira: https://reddata.atlassian.net/browse/GROK-16383

1.20.1


RFP - WD SmartWare

Checklist

[x] The package I am requesting does not already exist on https://chocolatey.org/packages;
[x] There is no open issue for this package;
[x] The issue title starts 'RFP - ';
[x] The download URL is public and not locked behind a paywall / login;

Package Details
Software project URL : https://support.wdc.com/downloads.aspx?p=259
Direct download URL for the software / installer : https://downloads.wdc.com/smartware/WD_SmartWare_Installer_<IP_ADDRESS>.zip
Software summary / short description: Backup software for WD external hard-drives.

I am willing to pick this one up.

Submitted: https://chocolatey.org/packages/wd-smartware


Added absolute result to result column

Added absolute result to result column for the positions table on the dashboard

OK, so this is awesome. It was a starting point for me to figure out how to hook into the websockets data and parse that. using this method by just passively listening for data changes instead of a bunch of setTimeouts that make the screen flash and take up cpu cycles. I'm really stoked to be able to use the websockets here! Check out this branch and let me know what you think! https://github.com/markrickert/cryptohopper-dashboard-watchlist/tree/add-absolute-numbers

I've split this project into multiple userscript files now so each feature is sandboxed and added this code as a new userscript with your authorship attributed 👍  Thanks! Closing this PR.


GSD Request

--- GSD JSON ---
{
  "vendor_name": "Linux",
  "product_name": "Kernel",
  "product_version": "versions from v5.15 to before v5.15.25",
  "vulnerability_type": "unspecified",
  "affected_component": "unspecified",
  "attack_vector": "unspecified",
  "impact": "unspecified",
  "credit": "",
  "references": [
    "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?id=fa5d823b16a9442d609617abeec31da8b6afa224",
    "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?id=3e41445287afa3cf6d572778e5aab31d25e60a8d"
  ],
  "extended_references": [
    {
      "type": "commit",
      "value": "fa5d823b16a9442d609617abeec31da8b6afa224",
      "note": "introduced"
    },
    {
      "type": "commit",
      "value": "3e41445287afa3cf6d572778e5aab31d25e60a8d",
      "note": "fixed"
    }
  ],
  "reporter": "joshbressers",
  "reporter_id": 1692786,
  "notes": "",
  "description": "dmaengine: ptdma: Fix the error handling path in pt_core_init()\n\nThis is an automated ID intended to aid in discovery of potential security vulnerabilities. The actual impact and attack plausibility have not yet been proven.\nThis ID is fixed in Linux Kernel version v5.15.25 by commit 3e41445287afa3cf6d572778e5aab31d25e60a8d, it was introduced in version v5.15 by commit fa5d823b16a9442d609617abeec31da8b6afa224. For more details please see the references link."
}
--- GSD JSON ---

This issue has been assigned GSD-2022-1000474


Prefer Linux-specific fonts over Arial

Some Linux distributions (like Debian) have fontconfig aliases for Arial
that picks specific fonts. But such generic aliases might be less
desirable than the known-good Linux specific fonts.
This fixes a problem on my setup where Liberation Sans is aliased as
Arial, even when Noto Sans is available. Liberation Sans doesn't support
a weight of 500, so we end up rendering headers at the normal weight of
400, which makes them stand out less. Reordering the Arial fallback
makes us instead pick Noto Sans over Lieration Sans, which does support
a weight of 500, and makes headers stand out again.
While we're at it, fixup the reboot documentation to match, and change
the comment about Helvetica Neue; that's not a "Basic web-fallback" font,
it's the UI font on older iOS and macOS versions.

Thanks for opening this!
If we go this way, wouldn't it be better to drop Liberation Sans entirely, since it's found behind Arial in most distros (at least Ubuntu and Fedora? Setting Arial after Liberation Sans feels useless. On Ubuntu 20.04, I don't have Noto Sans installed but have Arial (using the microsoft-ttf-installer) so it's even weird because it forces Liberation where I could use Arial.
Same concern regarding Roboto, since it's an alias for Arial too. Not quite sure about side-effects on Android though, since if Noto Sans is available on Android it'd pick that instead of falling back to Roboto as an Arial alias.

I'm not really familiar enough with the specifics of Arial-proper and the various fallbacks that various distros provide depending on what set of installed packages to feel confident to suggest much change beyond what I'm suggesting here, I think. That doesn't mean that I would oppose going further, but I don't think that would be a change I would want to put my name on, simply because I don't feel like I've done enough research on the matter.

Fair enough 👌
IMHO this is good. Just remembered that on Ubuntu at least, dropping Liberation would make Chromium and Firefox choose a different fallback to Arial, which is what we tried to prevent.

@ffoodd: Anything I can do to help moving this forward?

@ffoodd: As a first-time contributor, I need someone to approve running the workflows. Would you mind doing that? :)


Calling functions on objects seem to lose this?

Ok, so I ran across this while porting facades to Scala.js, where I have a native trait with function members instead of methods. This is sometimes a reasonable thing to do, especially for encoding optional methods. The problem seems to be that when Scala.js sees that we're calling a function, it doesn't call it in a way which preserves this.
Am i misunderstanding something, or this a bug?
I narrowed it down to the following test case (tested against HEAD of 0.6.x and master). Hopefully it demonstrates the correct thing - the original problem i faced was when calling javascript code.
@js.native
trait ValueObject extends js.Object {
  var value: String
  val getValue: js.Function0[String]
}

class DontDropThisTest {
  val returnString: js.ThisFunction0[ValueObject, String] = instance =>
    instance.value

  @Test def worksString(): Unit = {
    val instance = js.Dynamic.literal("value" -> "foo", "getValue" -> returnString)

    assertEquals("foo", instance.getValue())
  }

  @Test def failsString(): Unit = {
    val instance = js.Dynamic.literal("value" -> "foo", "getValue" -> returnString).asInstanceOf[ValueObject]

    assertEquals("foo", instance.getValue())
  }
}

This results in the following:
[info] Test org.scalajs.testsuite.jsinterop.DontDropThisTest.failsString started
[error] Test org.scalajs.testsuite.jsinterop.DontDropThisTest.failsString failed: scala.scalajs.js.JavaScriptException: TypeError: Cannot read property 'value' of undefined, took 0.001000192 sec
[error]     at org.scalajs.testsuite.jsinterop.DontDropThisTest.org$scalajs$testsuite$jsinterop$DontDropThisTest$$$anonfun$returnString$1(/home/olvind/pr/scala-js/test-suite/js/target/scala-2.12/file:/home/olvind/pr/scala-js/test-suite/js/src/test/scala/org/scalajs/testsuite/jsinterop/DontDropThis.scala:24)
[error]     at <jscode>.{anonymous}()(/home/olvind/pr/scala-js/test-suite/js/target/scala-2.12/file:/home/olvind/pr/scala-js/test-suite/js/src/test/scala/org/scalajs/testsuite/jsinterop/DontDropThis.scala:23)
[error]     at org.scalajs.testsuite.jsinterop.DontDropThisTest.failsString(/home/olvind/pr/scala-js/test-suite/js/target/scala-2.12/file:/home/olvind/pr/scala-js/test-suite/js/src/test/scala/org/scalajs/testsuite/jsinterop/DontDropThis.scala:35)
[error]     at org.scalajs.testsuite.jsinterop.DontDropThisTest$scalajs$junit$bootstrapper$.invoke(/home/olvind/pr/scala-js/test-suite/js/target/scala-2.12/scalajs-test-suite-test-fastopt.js:233921)
[error]     ... 6 more
[info] Test org.scalajs.testsuite.jsinterop.DontDropThisTest.worksString started

The generated javascript is the following:
function $c_Lorg_scalajs_testsuite_jsinterop_DontDropThisTest() {
  $c_O.call(this);
  this.returnString$1 = null
}
$c_Lorg_scalajs_testsuite_jsinterop_DontDropThisTest.prototype = new $h_O();
$c_Lorg_scalajs_testsuite_jsinterop_DontDropThisTest.prototype.constructor = $c_Lorg_scalajs_testsuite_jsinterop_DontDropThisTest;
/** @constructor */
function $h_Lorg_scalajs_testsuite_jsinterop_DontDropThisTest() {
  /*<skip>*/
}
$h_Lorg_scalajs_testsuite_jsinterop_DontDropThisTest.prototype = $c_Lorg_scalajs_testsuite_jsinterop_DontDropThisTest.prototype;
$c_Lorg_scalajs_testsuite_jsinterop_DontDropThisTest.prototype.init___ = (function() {
  this.returnString$1 = (function(arg$outer) {
    return (function() {
      return arg$outer.org$scalajs$testsuite$jsinterop$DontDropThisTest$$$anonfun$returnString$1__Lorg_scalajs_testsuite_jsinterop_ValueObject__T(this)
    })
  })(this);
  return this
});
$c_Lorg_scalajs_testsuite_jsinterop_DontDropThisTest.prototype.worksString__V = (function() {
  var instance = {
    "value": "foo",
    "getValue": this.returnString$1
  };
  var this$2 = $m_Lorg_junit_Assert$();
  var actual = instance.getValue();
  this$2.assertEquals__T__O__O__V(null, "foo", actual)
});
$c_Lorg_scalajs_testsuite_jsinterop_DontDropThisTest.prototype.failsString__V = (function() {
  var instance = {
    "value": "foo",
    "getValue": this.returnString$1
  };
  var this$2 = $m_Lorg_junit_Assert$();
  var actual = (0, instance.getValue)();
  this$2.assertEquals__T__O__O__V(null, "foo", actual)
});

I don't really know what the (0, ...)() syntax is meant to accomplish, but it seems to get in the way here.

Hi,
This is as designed. When calling the apply method of a js.FunctionN on a receiver f, e.g., f(args), Scala.js guarantees that it will call f without passing any this. Even if f is of the form x.m. The syntax (0, ...)() is precisely meant to accomplish these particular semantics. These semantics are more regular than JS, whose specification goes to insane lengths to maintain the this-passing thing. They ensure that
x.f(args)

is always equivalent to
val g = x.f
g(args)

which is an important property in Scala.
If you want to preserve this the JavaScript way, you need to declare getValue as a def. Alternatively, declare it as js.ThisFunctionN an explicitly pass a value for this.

Ok, thanks for the answer. I found this pretty surprising TBH, but i get your point about consistency on the scala side of things.


Make sure that Energy Compensation is 1 by default everywhere

Changing the default value must be done without breaking compatibility.
In a second step, we will decide whether or not EC should be exposed to users in the plugins.

We need to check what happens in the MetalBRDF if the user inputs non-physical values.
I am not sure if the result is correct in this case.

The following shaders are affected: blackbody, metal, subsurface.
Blackbody does not expose this to the user, and EC is hardcoded in the closure call to 1.0.
The specular term in the subsurface shader does the same thing - parameter is not exposed to the user, and EC is hardcoded to 1.0.
The only case where EC is exposed is in the metal shader - it was mostly for @est77 to have a easy way to compare with/without EC tables in appleseed-maya.
To conclude - only the metal shader exposes this to the user, and this is to be hidden.
I can add widget=null at the moment - this will not expose it, but it will not break existing connections from existing scenes. What do you think?

Done with https://github.com/appleseedhq/appleseed/pull/2128


Refactored ReadableFloatVector

Refactored ReadableFloatVector by making method getEuclideanDistance static and providing one general implementation.

Please do not merge yet, I would like to make both toArray and toList static as well.

Should be fine now. Let me know if something is amiss.


Call sizeToColumnsToFit() only when table is visible

This issue stems from the use of multiple instances of ag-grid across different pages - the ag-grid API still calls sizeColumnsToFit() on the non-rendered grids. The related issue is logged here and here, and has existed since 2016 with no progress on a fix.


Drop support for Web image ?

I am thinking of dropping support and remove the web image from this repository, but I really think this is a decision to be discussed, so please give me feedback on this (whether you agree or not).
Actually, I think that the Web image is not really useful since it is only a Nginx server with minimal configuration to be used as a reverse proxy. I'm pretty sure that a huge majority of users already have their own reverse-proxy inside their infrastructures, so they are not using Web image. And people who don't should really, IMHO, use an existing reverse-proxy (Traefik, Nginx, etc.) and customize their configuration instead of using the default one we provide.
So what are you thinking ? Should we stop providing a Web image (and instead explain in documentation how to use App with a reverse-proxy) ? Or should we keep this image and improve it (maybe by using another reverse-proxy, like Traefik) ?

I think having a default, small, "security-first" reverse proxy is a good thing… but more as an example and "how to get this up and running as secure and fast as possible" not as a solution for everybody

@pichouk What are the implications of dropping support for the web image? What harm is keeping the web image support?

@jasonblais Dropping support for Web image will force users that use this image (how much ? can't really know) to configure their own reverse-proxy/web server OR to expose directly the Mattermost application to the internet.
IMHO this is not something difficult if users have some basic system administration skills (which I hope they have since they host a Mattermost server), but we will need to warn them (it will not be transparent if they just git pull && docker-compose up).
The complicated task with maintaining the Web image is "choices". A reverse-proxy/web server is the "main door" to enter on someone's infrastructure so this is a sensitive and highly customized component. There is probably hundreds of possible reverse-proxy/web server and thousands of different configurations. Somes want specific features, others want light and generic image. Somes want security, others want compatibility.
There are as much possible configurations as there are users. Because of this, it is really complicated to provide an image that will fit everyone's needs, and I guess that a lot of users don't use Web image for this reason (and use their own reverse-proxy).

Thanks for the context. What's typical for Docker images in this case? Do they usually support web image, but perhaps provide a recommended way to set it up?

I'm not sure that there is a typical way to handle this.I look at some other popular free softwares (eg. Etherpad, Rocket Chat, Mastodon) and they generally provide a docker image to deploy the application and few documentation to explain how to deploy behind a reverse-proxy
My opinion/proposal is the following.
I think we should continue to provide app AND db images, with a docker-compose.yml example file to use it. We (Mattermost, maintainers and community) should maintain those images and a deployment example. Plus we have to provide a quick, simple and generalist documentation on how to deploy behind a reverse proxy (port to use, websocket endpoint, etc.). Users will then be able to choose their reverse-proxy and configure themselves.
Eventually, we can also provide one or two example of deployment (on a contrib folder ?) if there is community members to maintain.

Great, thank you @pichouk. Would you like to post this proposal to the Docker channel as well, so people there see it too? It would be good to get an engineer (Christopher or Corey) review it and share feedback as well, if any.

Running Mattermost any of the common cloud providers would prob involve the provider native load balancers iso an nginx container?

Hello,
I have been running a docker instance of mattermost-preview for testing purposes and when I decided to install the production server I ran into multiple issues.
I wish there was a single server production docker as easy as docker run --name mattermost-preview -d --publish 8065:8065 mattermost/mattermost-preview and a vhost configuration.

I'm pro webserver.
This image works perfect out of the box and the nginx doesn't take much ressources away. I've never worked with Nginx but with Apache, HAProxy and misc firewalls with ReverseProxy support. It takes time to maintain to configure and adds another source of trouble.
But it would be nice to start the container without the proxy too. Maybe giving the choice to use it with or without the proxy.

I think that a traefik container would fit really well in the current docker-compose setup. Especially because it gives uses a way to use letsencrypt (which is currently not possible/easily done with the current setup?).

@cht47

This image works perfect out of the box

Not really. Plus the README lacks clarity if one isn't familiar with docker compose.
The preview docker image is much easier to run.

Please also consider deprecating the db image based on postgres:9.4. Custom configurations can be mounted directly into the upstream postgres images.
Furthermore, newer PostgreSQL versions are available and support for 9.4 ends in 2020.

Thanks @pichouk
I do not know what is the optimal approximation on these two options. But I am going to share my experience with Mattermos-docker. In the last two years I am using multiple instances with the web image. This image with the docker-compose has been very useful to me.
For me keep this image and improve it sounds interesting. I want to help with it. But if we chose other option I willing to learn and help to the best of my knowledge :)


Linux Mint support

Linux Mint by default uses Ubuntu repos and fully compatible with it.

Linux Mint and any distribution which supports Docker will be supported in EasyEngine v4. We're nearing the v4 stable release and currently are not entertaining any PR for v3. If your PR still makes change for v4, please create a new PR targeting v4.


Portable Mode create empty logs folder in %APPDATA%

VSCode Version: 1.26.0
OS Version: Windows 10 Enterprise 1803

Steps to Reproduce:

Download and extract VS Code 1.26.
Create data folder in VS Code's folder to enable Portable Mode.
Launch VS Code (Code.exe).
Logs folder created in %APPDATA%\Visual Studio Code\logs.

Does this issue occur when all extensions are disabled?: Yes

Update: Also occur in version 1.26.1 and windows 8.1 x64.

Easily reproducible.

Can't repro this with 1.25.
I'm 100% sure this happens at the Electron layer:

I've modified Code's main.js to simply and only call console.log(fs.existsSync('path/to/that/folder')) and it always returns true. That folder is created even before any JS runs.
I've modified Code's main.js to simply and only call process.exit(0) and still that folder gets created.

Seems to be an issue with Electron 2.

I cannot reproduce with electron-fiddle, so we should find out what causes this from our code.

I can repro this with vanilla Electron 2.0.5 on Windows:

Download and extract Electron 2.0.5 for Windows
Create the following files within:

resources\app\package.json with contents {"main":"main.js"}
resources\app\main.js with empty contents

Make sure %APPDATA%\Electron does not exist
Double click electron.exe

A wild %APPDATA%\Electron appears! :open_mouth:

@joaomoreno awesome, can you please report this to Electron and link the issue here?

https://github.com/electron/electron/issues/14276

@bpasero Did you test Electron 3?

@joaomoreno https://github.com/electron/electron/issues/14470#issuecomment-464517119


Still experimental?

Hey @mcollina,
First off, thanks for sharing this. Quick question: I noticed in the readme that the module is marked “experimental” but has been up for about two years. Would you still consider it experimental / are you using it yourself these days?
I had a quick look through the code while comparing it to write-file-atomic and, from what I can see, they approach the atomicity issue in the same way (with the latter doing a few more things like queuing requests to overwrite the same while, which I don’t need as I’m already doing that myself). Performance-wise, I’m also seeing similar results.
Just trying to decide between the two and my gut feeling is to go with this one as it’s more focused (less code = better in my book). Would value your thoughts. Please feel free to ignore if you’re busy :)

It's experimental because it's not as battle tested as the other one. If you have performance issues, use this one ;).


Incorrect usage of Historical price messages with get_historical_data function

Summary (include Python version)
Python 3.7.3
iexfinance 0.4.3
I used the function get_historical_data as follows:
get_historical_data("FB", start=start, end=end,
output_format='pandas', close_only=False, token = token)
with start=2020-05-11 and end=2020-05-15
An incorrect, incredibile amount of Historical Price messages were used
Date/time of issue
2020-05-18 17:00
Expected behavior
The function got the correct data:

but when I checked the message use in the iexcloud console I found that 2.530 Historical Price messages were used by the function instead of the 50 expected messages.
I tried to use directly the iex cloud API
https://cloud.iexapis.com/stable/stock/FB/chart/5d?token=
I got the same data, but the correct numer of Historical Price messages were used
Actual behavior
The function get_historical_data consumes an incorrect number of Historical Prices messages

happened to me too, drained many of my messages budget :(

I have the same behavior, the HistoricalReader downloads the entire 5 year dataset, then just slices it for the dates you made the get_historical_data() call with.
That is terrible! It uses thousands more message credits than it should.
iexfinance/stocks/historical.py self.chart_range() -
sets the query's timeframe to be 5y, 2y or 1y rounded up based on the starting year you query with
iexfinance/stocks/historical.py:77 -
where it slices the dataframe to the queried dates.
in your docs (https://addisonlynch.github.io/iexfinance/stable/stocks.html) it reads:
Certain endpoints such as Historical Data, which are unrelated to specific symbols, are supported by top-level functions (i.e. iexfinance.stocks.get_historical_data). This function is optimized to achieve the lowest possible message count for retrieval in a single request.
either I am missing something or it does the exact opposite of optimizing!

if anyone is following along, I found that if you do not specify an end date parameter in your call to get_historical_data(), it will only query IEX with the date you specified, not rounded-up-to-1y/3y/5y.

@dolanwill  You are the life saver!  After removing the end time, the daily historical price only costs 2 messages (per day). Awesome!


[Feature]

Summary
Disable sign up
Motivation
We have a requirement for security purposes to disable signup
Additional Context
Any other context or screenshots or API request payload/responses that you
pertain to the feature.

@mosinuga Disabling sign ups for an Appsmith instance is possible by setting an environment variablein your docker.env file. This is described in more detail, with a few other customization options, in our documentation here. Is this what you were looking for?

Yes, thank you!