Fix for PR template

Pull Request
Title
Fix for type of change in PR template.

Description
Show as non-editable list rather than editable checkboxes.

Type of Change

🛠 Bug fix

Testing
Not needed.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 72.34%. Comparing base (911ddfd) to head (a9f7abe).

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #66   +/-   ##
=======================================
  Coverage   72.34%   72.34%
=======================================
  Files          21       21
  Lines        1034     1034
  Branches      127      127
=======================================
  Hits          748      748
  Misses        236      236
  Partials       50       50

Flag
Coverage Δ

unittests
72.34% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Fix request body constructors in PHP discovery sample gen

Current coverage is 80.37% (diff: 100%)

Merging #665 into master will not change coverage

@@             master       #665   diff @@
==========================================
  Files           275        275
  Lines         10428      10428
  Methods           0          0
  Messages          0          0
  Branches       1385       1385
==========================================
  Hits           8382       8382
  Misses         1692       1692
  Partials        354        354

Powered by Codecov. Last update 01cbf1a...bd66bb4

This wasn't working before? When did this breakage happen? It seems like something basic.
The change looks fine to me, but let @shinfan and @saicheems weigh in.

It's been there since request bodies were added to PHP sample gen:
https://github.com/googleapis/toolkit/commit/ab244b982b5e9af14114d90f9b51859c7bc4dc5b%23diff-92164f3905edf4c2776a8110e7b9d31d&sa=D&ust=1477070683861000&usg=AFQjCNHd1eACWJKKK2RB2RbQjAaZzWMRXQ
Seems to me like another example of the incompleteness of our current compile-check approach.

LGTM
Thanks for fixing this. I think one of the limitations of our current compile-check (at lease for PHP) is that it only checks for our expected issues. And in PHP this did not cause an error since you can always pass more parameters than the function expects (those extra parameters will be ignored).

lgtm


Implement the first version of mobile tabs May be a dummy component that looks like the real one.

The puzzle 42-9a011cc1 from #42 has to be resolved:
https://github.com/codeforthailand/election-live/blob/843128114e9e7345e8a2d3156089c89d841bb352/src/components/ZoneMasterView.js#L126-L127
The puzzle was created by Thai Pangsakulyanont on 20-Mar-19.
If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.

This mobile tab component is displayed at the bottom of the screen. To let user pick between content view and map wheel.


Make the crate useable in no_std environments

[x] Remove spurious dependencies on std:

using core:: instead;
removing spurious uses of std::Vec and nalgebra::DMatrix.

[x] Update Cargo dependencies accordingly:

assert_approx_eq is a dev-dependency (only used in tests);
nalgebra's std feature isn't used anymore.

[x] Add a std feature, gate remaining uses of Vec (only in discrete Bayes), make the crate no_std otherwise.
[ ] Make the API for discrete Bayes useable in no_std environments (i.e. without Vec).

This can be checked with:

cargo check --tests && cargo check --tests --no-default-features;
cargo nono check.

I'm currently implementing embedded code in Rust that uses such filters, and I would rather contribute no_std patches to filters.rs (and perhaps improvements in the future as I use it) than NIH my own crate  ;3

This project had fallen a bit to the wayside, but I'm happy to review and merge your changes.
Going no-std seems very useful and was something that I definitely had in mind as a potential feature for this crate.
One suggestion I have upfront is to add a check for no-std compliance in the GitHub actions configuration (which I just added) to ensure it won't be broken again.

I have also just updated the repo to the (for Rust) more common Apache/MIT dual license. So let me know whether you are still fine contributing your PR under the additional Apache license.

I have also just updated the repo to the (for Rust) more common Apache/MIT dual license. So let me know whether you are still fine contributing your PR under the additional Apache license.

Entirely fine by me  :)

This project had fallen a bit to the wayside, but I'm happy to review and merge your changes.
Going no-std seems very useful and was something that I definitely had in mind as a potential feature for this crate.
\o/

I totally understand letting things fall by the wayside for a while, it's absolutely no problem  :)

One suggestion I have upfront is to add a check for no-std compliance in the GitHub actions configuration (which I just added) to ensure it won't be broken again.

Done, and thanks for adding CI  :)

It might also be possible to use Vec from the alloc instead of std. That would still require an allocator to be present though, so it might need a different feature gate. Would that be useful for your use case?

Oh, good point, the gate should be on alloc and not std; I will go change that.
alloc is still inconvenient for my usecase, but I also don't need discrete Bayes (just using Kalman filters and some IIRs right know), hence why I didn't think very hard on how to make it available on no_std.

@MichaelMauderer Do you consider to do a release with this PR merged? I think it's quite a big step to have no_std support.

Done.


Query returning null value after migrating to typeDefs/resolvers pattern

I used to create queries/mutations with schema/root independently but I wanted to follow a more convenient way to structure my project (back-end), so I migrated the old working functionalities to use the graphql-tools package, the old working code looks like this:
async function getUser(id: string) {
  return await Users.findById(id);
}

then I add the Query user to the schema (with buildSchema) and a method to the root like the official GraphQL.js docs which looks like this:
let root = {
  user: (id: string) => {
    return getUser(id);
  },
};

But now when I use the same method in the resolvers I get null in return, but I tested the Query again after I changed the method to return a dummy object of user without async/await, and it works, so I think that there is a problem with asynchronous methods inside the resolvers object.
is it a bug or there is a way to get this to work?

it turns out that I don't get the query parameter (user's id is undefined), so I searched for some examples in the docs and I saw this:
const resolvers = {
  Query: {
    posts: () => posts,
    author: (_, { id }) => find(authors, { id: id }),
  },
...

Adding the underscore _ like in the author query in the example parameter solved the issue, and I get an id value, but I don't understand what's the use of the underscore parameter, it is undefined by the way.

@ibraback the underscore is just a placeholder. Notice how every resolver takes four arguments. The arguments to the field are the second one, so if you want to access them, your function definition needs to take at least two arguments. We're not using the first one here (known as rootValue), but we still need to provide a dummy value, and we just happened to choose _.
Here's the full signature of resolvers from graphql.org:
type GraphQLFieldResolveFn = (
  source?: any,
  args?: {[argName: string]: any},
  context?: any,
  info?: GraphQLResolveInfo
) => any


implement native toggleAttribute signature

Fixes #5364.
As long as we return bool, we implement the same interface that was natively introduced recently. While keeping our third parameter..

No worries, tried it locally on a project too and it resolves the problem 👍


TypeError: undefined is not an object (evaluating '_reactNavigation.ThemeColors.light')

What's going on?
I scaffolded a fresh project with this config and am getting an error when I run the project.

Steps to reproduce
ignite new FunTimesAnd
npm i
yarn install
Then I went into the project and tried to run npx react-native run-ios, but I get the error in the title of this issue. Here's a screenshot also:

ignite doctor results:
FunTimesAnd (master) ⚾ ignite doctor
System
platform           darwin
arch               x64
cpu                12 cores      Intel(R) Core(TM) i7-8700B CPU @ 3.20GHz
directory          FunTimesAnd   /Users/jimb0/Git-Projects/Fun-With-React-Native-2020/fun-4-ignite-andross/FunTimesAnd
JavaScript
node               11.15.0      /Users/jimb0/.nvm/versions/node/v11.15.0/bin/node
npm                6.7.0        /Users/jimb0/.nvm/versions/node/v11.15.0/bin/npm
yarn               1.17.3       /Users/jimb0/.nvm/versions/node/v11.15.0/bin/yarn
Ignite
ignite-cli           3.5.1                                                                                /usr/local/bin/ignite
ignite src           build                                                                                /Users/jimb0/.config/yarn/global/node_modules/ignite-cli/build
createdWith          3.5.1
boilerplate          ignite-andross
examples             classic
navigation           react-navigation
askToOverwrite       true
generators           {"component":"ignite-andross","container":"ignite-andross","list":"ignite-andross","redux":"ignite-andross","saga":"ignite-andross","screen":"ignite-andross","listview":"ignite-andross"}
boilerplateVersion   4.2.0
Android
java               1.8.0_232    /usr/bin/java
android home       -            /usr/local/share/android-sdk
iOS
xcode              11.3.1
cocoapods          1.8.4        /usr/local/bin/pod
Thanks! 🙏 ❤ 🔥

I had the same issue and updating react-navigation-stack to version 2.0.16 helped solve it for me. However, I ran into a series of other errors so here are the total updates I had to make to bootstrap the base project successfully (with DevScreens):
...
"react-navigation": "3.13.0",
"react-navigation-redux-helpers": "3.0.7",
"react-navigation-stack": "2.0.16",
"@react-native-community/masked-view": "0.1.6",
"react-native-safe-area-context": "0.6.4",
"react-native-screens": "^2.0.0-alpha.32",
...

You're welcome, @JimLynchCodes! It's actually not Ignite causing this problem, it's the Andros boilerplate. We are currently in "community support" phase of Andross, which means we're happy to review and merge pull requests and release new versions, but we don't use Andross anymore ourselves, so we rely on the community to provide fixes for issues.
I recommend you try out Ignite Bowser!

Why did you guys close a crash issue asking us to switch to bowser boilerplate? This is not a solution!
How the community would to keep track of the problem and fix it?
You guys should get rid of Andross so.

@yudori that solution works for me too is this something that should PR'd


chore: add mount path to verbose logging for approle

Description
Add mount path to verbose logging for approle
Checklist
Please make sure that your PR fulfills the following requirements:

[x] Reviewed the guidelines for contributing to this repository
[x] The commit message follows the Conventional Commits Guidelines.
[ ] Tests for the changes have been updated
[ ] Are you adding dependencies? If so, please run go mod tidy -compat=1.17 to ensure only the minimum is pulled in.
[ ] Docs have been added / updated
[ ] Optional. My organization is added to USERS.md.

Type of Change

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] New tests
[ ] Build/CI related changes
[ ] Documentation content changes
[x] Other (please describe) - improve logging

Other information

Codecov Report

Merging #489 (c3789c8) into main (ddbd42b) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #489   +/-   ##
=======================================
  Coverage   75.31%   75.31%
=======================================
  Files          25       25
  Lines        1689     1689
=======================================
  Hits         1272     1272
  Misses        323      323
  Partials       94       94

Impacted Files
Coverage Δ

pkg/auth/vault/approle.go
68.96% <100.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Budget Allocator incorporating JSON file

Project Robyn
Describe issue
Describe your issue and provide warnings and error messages.
Provide reproducible example
Issues are often related to custom input data that is difficult to debug without. If necessary, please modify your data to mask real values and share a dataset that is able to reproduce the issue. Please also share your model configuration and exported JSON files if available.
Environment & Robyn version
Make sure you're using the latest Robyn version before you post an issue.

Check and share Robyn version: packageVersion("Robyn")
R version (Please, check and share: sessionInfo() or R.version$version.string)

Hi all - I used the below code to incorporate a previously created JSON file to recreate budget allocator pagers. However, I keep having the below error. could you let me know what when wrong?
Timing stopped at: 0.04 0.01 0.05
Error in { :
task 1 failed - "Can't recycle channel_1_s (size 0) to match channel_2_s (size 99)."

please clean up your message above bit more, as well as provide your code

Hi Gufeng -
Thank you very much for your strong support.
Here is the code: I need to mask some data as the information is confidential. In addition, I also noticed that it only happens when there are very many iterations (I tested 8000 iterations in 10 trials)

Have the same problem! Although I'm using robyn_recreate() to read the json from the model, but I've tried, but I have tried as you have done and I get the same error message.
I think that the problem is in the hyperparameters values when it's 0 but I'm confuse.

I can't reproduce this error on simulated dataset. If you could share your json, dataframe and holiday files, I can try to debug


Add better production build support

Currently, our production build works. But it's not optimized properly for static pages. So, try to get some input from React Create App and adapt.

It would be great if we can get a way to change the title page to our component/app name and maybe add an og:image to share ^^
A friend of mine created a decorator to add the github corner inside the storybook and it helped a lot to opensource projects.
React Storybook Github Corner

It's coming soon.

Let me know if you need some help. I really like this project, if you have some issues that you need help, call me.

We are pretty happy to get more help. Have a look at the issue list in here.
If you are familiar with webpack, get some of the production optimizations added here to storybook.


Trying to run the app, and app run to failed

Description

What went wrong:
Could not determine the dependencies of task ':app:compileDebugJavaWithJavac'.

Could not determine the dependencies of null.
SDK location not found. Define a valid SDK location with an ANDROID_HOME environment variable or by setting the sdk.dir path in your project's local properties file at

React Native Version
0.72.3
Output of npx react-native info
C:\Users\Admin>npx react-native info
error: unknown command 'info'
(Did you mean init?)
Steps to reproduce
After creating the app, later, try to run the android app from cmd
Snack, screenshot, or link to a repository

@saggy, looks like your environment is not setup properly. Pls follow instructions on this page https://reactnative.dev/docs/environment-setup?os=windows&platform=android

SDK location not found. Define a valid SDK location with an ANDROID_HOME environment variable or by setting the sdk.dir path in your project's local properties file at

Closing as @tarunrajput provided the right answer. Also please use react-native doctor to verify your environment is all green


EFUIntPixel init?(color: CGColor)  always return nil

Hi,
In EFUIntPixelr.swift Line 66, it will always return nil when init by CGColor. Thus, function  CGImage.binarization() will not be called. It's weird to see this useless  function and initializer.

@vin-zhou @LegendChan please check to see if the master branch have fixed the problem.

We assume the bug is fixed. If it's still not working for you, leave a comment or discuss in the QQ group.


replace ast.Literal with ast.Primitive and clean up durations

This commit is a first step toward implementation comprehensive
Z values, including complex literals, in the parser.  It replaces
the ast.Literal type with the zson parser's ast.Primitive.
In a future commit, we will generalize many of the code paths
to handle Z value expressions beyond ast.Primitive.
We also cleaned up ast.Duration so it too is now an ast.Primitive
conforming to RFC-3339 durations.  That said, Go's time.Duration type
does not propertly implement RFC-3339 durations behond an hour
(see issue #2356) so for now, the tests with every clauses have been
changed to use 24h instead of 1d.
Closes #2214
Closes #2184

This commit will likely break the app depending on how it generates "every" values for the histogram.


Move Database Introspection to Classes

👋 @bitner
This PR does:

Move Database Introspection to Classes (timvt.dbmodel.Table)
adapt for the new Table class

This reuse code from tifeatures (not yet public) project.

test fails right now with FAILED tests/routes/test_tiles.py::test_function_tile - asyncpg.exceptions.DataError: invalid input for query argument $6: {} (expected str, got bytes) which I think is related to https://github.com/developmentseed/timvt/blob/828768bc133d1c3bb1c5e63b2929d6006abaade5/timvt/db.py#L19-L26 and https://github.com/developmentseed/timvt/blob/828768bc133d1c3bb1c5e63b2929d6006abaade5/timvt/layer.py#L275-L283

This PR
Run siege --file .github/workflows/data/urls_epsg4326.txt -b -c 20 -r 100 > /dev/null
** SIEGE 4.0.4
** Preparing 20 concurrent users for battle.
The server is now under siege...
Transactions:		        2000 hits
Availability:		      100.00 %
Elapsed time:		        4.37 secs
Data transferred:	        0.19 MB
Response time:		        0.04 secs
Transaction rate:	      457.67 trans/sec
Throughput:		        0.04 MB/sec
Concurrency:		       19.31
Successful transactions:           0
Failed transactions:	           0
Longest transaction:	        0.13
Shortest transaction:	        0.00

Master
Run siege --file .github/workflows/data/urls_epsg4326.txt -b -c 20 -r 100 > /dev/null
** SIEGE 4.0.4
** Preparing 20 concurrent users for battle.
The server is now under siege...
Transactions:		        2000 hits
Availability:		      100.00 %
Elapsed time:		        2.78 secs
Data transferred:	        0.19 MB
Response time:		        0.03 secs
Transaction rate:	      719.42 trans/sec
Throughput:		        0.07 MB/sec
Concurrency:		       19.38
Successful transactions:           0
Failed transactions:	           0
Longest transaction:	        0.07
Shortest transaction:	        0.00

😬

FYI: There is a small impact on performance with this PR, we should wait before merging!
This PR
$ siege --file .github/workflows/data/urls_epsg4326.txt -b -c 20 -r 100 > /dev/null
** SIEGE 4.1.3
** Preparing 20 concurrent users for battle.
The server is now under siege...

Transactions:                   2000 hits
Availability:                 100.00 %
Elapsed time:                   3.03 secs
Data transferred:               5.47 MB
Response time:                  0.03 secs
Transaction rate:             660.07 trans/sec
Throughput:                     1.81 MB/sec
Concurrency:                   18.11
Successful transactions:        2000
Failed transactions:               0
Longest transaction:            0.08
Shortest transaction:           0.02

Master
$ siege --file .github/workflows/data/urls_epsg4326.txt -b -c 20 -r 100 > /dev/null
** SIEGE 4.1.3
** Preparing 20 concurrent users for battle.
The server is now under siege...

Transactions:                   2000 hits
Availability:                 100.00 %
Elapsed time:                   2.73 secs
Data transferred:               5.47 MB
Response time:                  0.02 secs
Transaction rate:             732.60 trans/sec
Throughput:                     2.00 MB/sec
Concurrency:                   16.76
Successful transactions:        2000
Failed transactions:               0
Longest transaction:            0.09
Shortest transaction:           0.00

Update on performance, I've ran more benchmark locally and the difference is really small and still faster than pg_tileserv so I think we are 👍


🐛 [cloud_firestore] Operation never completes when setting host to local for emulator - iOS

Bug report
Describe the bug
When working with firestore emulator and setting the host to localhost, the operations performed never complete.
Steps to reproduce
Steps to reproduce the behavior:

Using any Flutter application, set the setting of Firestore as follows:

String host = Platform.isAndroid ? '<IP_ADDRESS>:8080' : 'localhost:8080';

FirebaseFirestore.instance.settings = Settings(
  host: host,
  sslEnabled: false,
  persistenceEnabled: false,
);

Start firebase firestore emulator firebase emulators:start --only firestore
Run any write operation such as await FirebaseFirestore.instance.collection('test').doc().set({'test':'non-working'})
See error or incorrect behavior. The operation never completes, neither fails nor returns. It just stays there.

Expected behavior
The data should be written to the emulator.

Additional context
Mind you that this is working if we remove the Settings configuration and leave it to use the real database.

Flutter doctor
Run flutter doctor and paste the output below:
Click To Expand
[✓] Flutter (Channel stable, 1.22.5, on macOS 11.0.1 20B50 darwin-x64, locale en-US)
    • Flutter version 1.22.5 at /Users/josetapizquent/Projects/Tools/flutter
    • Framework revision<PHONE_NUMBER> (6 days ago), 2020-12-10 11:54:40 -0800
    • Engine revision ae90085a84
    • Dart version 2.10.4

[✓] Android toolchain - develop for Android devices (Android SDK version 29.0.3)
    • Android SDK at /Users/josetapizquent/Library/Android/sdk
    • Platform android-30, build-tools 29.0.3
    • Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_212-release-1586-b4-5784211)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 12.2)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 12.2, Build version 12B45b
    • CocoaPods version 1.9.1

[✓] Android Studio (version 3.6)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin version 45.1.1
    • Dart plugin version 192.8052
    • Java version OpenJDK Runtime Environment (build 1.8.0_212-release-1586-b4-5784211)

[✓] VS Code (version 1.52.0)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.17.0

[✓] Connected device (1 available)
    • TapPhone (mobile) • 00008020-000E58220E99002E • ios • iOS 14.2

• No issues found!

Flutter dependencies
Run flutter pub deps -- --style=compact and paste the output below:
Click To Expand
Dart SDK 2.10.4
Flutter SDK 1.22.5
icay 1.0.0+2

dependencies:
- app_settings 3.0.1 [flutter]
- apple_sign_in 0.1.0 [flutter]
- auto_size_text 2.1.0 [flutter]
- barcode_scan 2.0.2 [flutter]
- bloc 6.1.1 [meta]
- cached_network_image 2.4.1 [flutter flutter_cache_manager octo_image]
- cloud_firestore 0.14.4 [flutter meta quiver firebase_core firebase_core_platform_interface cloud_firestore_platform_interface cloud_firestore_web]
- cupertino_icons 0.1.3
- device_info 0.4.2+10 [flutter device_info_platform_interface]
- enum_to_string 1.0.14
- equatable 1.2.5 [collection meta]
- firebase_admob 0.10.3 [meta flutter firebase_core]
- firebase_analytics 6.3.0 [meta flutter firebase_core firebase_analytics_web firebase_analytics_platform_interface]
- firebase_auth 0.18.4+1 [meta firebase_core firebase_core_platform_interface firebase_auth_platform_interface firebase_auth_web flutter]
- firebase_core 0.5.3 [firebase_core_platform_interface flutter quiver meta firebase_core_web]
- firebase_dynamic_links 0.5.0+12 [flutter]
- firebase_messaging 7.0.3 [meta flutter firebase_core]
- firebase_storage 5.2.0 [flutter firebase_core firebase_core_platform_interface firebase_storage_web firebase_storage_platform_interface quiver]
- flare_flutter 2.0.6 [flutter flare_dart meta]
- flash 1.3.1 [flutter]
- flutter 0.0.0 [characters collection meta typed_data vector_math sky_engine]
- flutter_bloc 6.1.1 [flutter bloc provider]
- flutter_cupertino_localizations 1.0.1 [flutter flutter_localizations]
- flutter_local_notifications 1.5.0+1 [flutter platform flutter_local_notifications_platform_interface]
- flutter_localizations 0.0.0 [flutter intl characters collection meta path typed_data vector_math]
- flutter_material_color_picker 1.0.5 [flutter]
- flutter_picker 1.1.3 [flutter]
- flutter_secure_storage 3.3.5 [meta flutter]
- global_configuration 1.6.0 [flutter http]
- google_sign_in 4.5.6 [google_sign_in_platform_interface flutter meta google_sign_in_web]
- http 0.12.2 [http_parser path pedantic]
- hydrated_bloc 6.1.0 [flutter meta bloc hive synchronized path_provider]
- icay_shared 0.0.1 [flutter equatable uuid quiver]
- image_cropper 1.3.1 [flutter]
- image_picker 0.6.7+15 [flutter flutter_plugin_android_lifecycle image_picker_platform_interface]
- intl 0.16.1 [path]
- keyboard_actions 3.3.1+1 [flutter]
- logger 0.8.3 [io]
- mailer 3.2.1 [async logging intl mime path pedantic]
- notification_permissions 0.4.8 [flutter]
- qr_flutter 3.2.0 [flutter qr]
- quiver 2.1.5 [matcher meta]
- rxdart 0.23.1
- sailor 0.7.1 [flutter]
- share 0.6.5+4 [meta mime flutter]
- shimmer 1.1.2 [flutter]
- sticky_headers 0.1.8+1 [flutter meta]
- strings 0.1.4 [characters unicode]
- url_launcher 5.7.10 [flutter url_launcher_platform_interface url_launcher_web url_launcher_linux url_launcher_macos url_launcher_windows]
- uuid 2.2.2 [crypto convert]
- youtube_player_flutter 7.0.0+7 [flutter flutter_inappwebview]

dev dependencies:
- bloc_test 7.1.0 [bloc test meta mockito]
- cloud_firestore_mocks 0.5.2+1 [flutter cloud_firestore cloud_firestore_platform_interface collection plugin_platform_interface mockito quiver]
- flutter_launcher_icons 0.7.5 [image args yaml]
- flutter_test 0.0.0 [flutter test_api path fake_async clock stack_trace vector_math async boolean_selector characters charcode collection matcher meta source_span stream_channel string_scanner term_glyph typed_data]
- intl_translation 0.17.10+1 [analyzer args dart_style intl path petitparser]
- mockito 4.1.3 [analyzer build code_builder collection dart_style matcher meta source_gen test_api]

transitive dependencies:
- _fe_analyzer_shared 7.0.0 [meta]
- analyzer 0.39.17 [_fe_analyzer_shared args charcode cli_util collection convert crypto glob html meta package_config path pub_semver source_span watcher yaml]
- archive 2.0.13 [crypto args path]
- args 1.6.0
- async 2.5.0-nullsafety.1 [collection]
- boolean_selector 2.1.0-nullsafety.1 [source_span string_scanner]
- build 1.6.0 [analyzer async convert crypto logging meta path glob]
- built_collection 4.3.2 [collection quiver]
- built_value 7.1.0 [built_collection collection fixnum quiver]
- characters 1.1.0-nullsafety.3
- charcode 1.2.0-nullsafety.1
- cli_util 0.2.0 [path]
- clock 1.1.0-nullsafety.1
- cloud_firestore_platform_interface 2.2.1 [flutter meta collection firebase_core plugin_platform_interface]
- cloud_firestore_web 0.2.1+2 [flutter flutter_web_plugins http_parser meta firebase_core firebase_core_web cloud_firestore_platform_interface js]
- code_builder 3.5.0 [built_collection built_value collection matcher meta]
- collection 1.15.0-nullsafety.3
- convert 2.1.1 [charcode typed_data]
- coverage 0.14.2 [args logging package_config path source_maps stack_trace vm_service]
- crypto 2.1.5 [collection convert typed_data]
- csslib 0.16.2 [source_span]
- dart_style 1.3.6 [analyzer args path source_span]
- device_info_platform_interface 1.0.1 [flutter meta plugin_platform_interface]
- fake_async 1.2.0-nullsafety.1 [clock collection]
- ffi 0.1.3
- file 5.2.1 [intl meta path]
- firebase 7.3.3 [http http_parser js]
- firebase_analytics_platform_interface 1.0.3 [flutter meta]
- firebase_analytics_web 0.1.1 [flutter flutter_web_plugins firebase firebase_analytics_platform_interface meta]
- firebase_auth_platform_interface 2.1.4 [flutter meta firebase_core plugin_platform_interface]
- firebase_auth_web 0.3.2+3 [flutter flutter_web_plugins meta http_parser intl firebase_core firebase_core_web firebase_auth_platform_interface js]
- firebase_core_platform_interface 2.1.0 [flutter meta plugin_platform_interface quiver]
- firebase_core_web 0.2.1+1 [firebase_core_platform_interface flutter flutter_web_plugins meta js]
- firebase_storage_platform_interface 1.0.2 [flutter meta collection firebase_core plugin_platform_interface]
- firebase_storage_web 0.1.1+1 [async crypto firebase_core firebase_core_web firebase_storage_platform_interface flutter flutter_web_plugins http js meta]
- fixnum 0.10.11
- flare_dart 2.3.4
- flutter_blurhash 0.5.0 [flutter meta]
- flutter_cache_manager 2.0.0 [flutter path_provider uuid http path sqflite pedantic clock file rxdart]
- flutter_inappwebview 4.0.0+4 [flutter uuid mime]
- flutter_local_notifications_platform_interface 1.0.1 [flutter plugin_platform_interface]
- flutter_plugin_android_lifecycle 1.0.11 [flutter]
- flutter_web_plugins 0.0.0 [flutter characters collection meta typed_data vector_math]
- glob 1.2.0 [async collection node_io path pedantic string_scanner]
- google_sign_in_platform_interface 1.1.2 [flutter meta quiver]
- google_sign_in_web 0.9.2 [google_sign_in_platform_interface flutter flutter_web_plugins meta js]
- hive 1.4.4+1 [meta crypto]
- html 0.14.0+4 [csslib source_span]
- http_multi_server 2.2.0 [async]
- http_parser 3.1.4 [charcode collection source_span string_scanner typed_data]
- image 2.1.19 [archive xml meta]
- image_picker_platform_interface 1.1.1 [flutter meta http plugin_platform_interface]
- io 0.3.4 [charcode meta path string_scanner]
- js 0.6.3-nullsafety.2
- lists 0.1.6
- logging 0.11.4
- matcher 0.12.10-nullsafety.1 [stack_trace]
- meta 1.3.0-nullsafety.3
- mime 0.9.7
- nested 0.0.4 [flutter]
- node_interop 1.2.1 [js]
- node_io 1.2.0 [file node_interop path]
- node_preamble 1.4.12
- octo_image 0.3.0 [flutter flutter_blurhash]
- package_config 1.9.3 [path charcode]
- path 1.8.0-nullsafety.1
- path_provider 1.6.24 [flutter path_provider_platform_interface path_provider_macos path_provider_linux path_provider_windows]
- path_provider_linux 0.0.1+2 [path xdg_directories path_provider_platform_interface flutter]
- path_provider_macos 0.0.4+6 [flutter]
- path_provider_platform_interface 1.0.4 [flutter meta platform plugin_platform_interface]
- path_provider_windows 0.0.4+3 [path_provider_platform_interface meta path flutter ffi win32]
- pedantic 1.10.0-nullsafety.2
- petitparser 3.1.0 [meta]
- platform 2.2.1
- plugin_platform_interface 1.0.3 [meta]
- pool 1.5.0-nullsafety.2 [async stack_trace]
- process 3.0.13 [file intl meta path platform]
- provider 4.3.2+3 [collection flutter nested]
- pub_semver 1.4.4 [collection]
- qr 1.3.0 [meta]
- shelf 0.7.9 [async collection http_parser path stack_trace stream_channel]
- shelf_packages_handler 2.0.0 [path shelf shelf_static]
- shelf_static 0.2.8 [convert http_parser mime path shelf]
- shelf_web_socket 0.2.3 [shelf web_socket_channel stream_channel]
- sky_engine 0.0.99
- source_gen 0.9.10+1 [analyzer async build dart_style glob meta path pedantic source_span]
- source_map_stack_trace 2.1.0-nullsafety.3 [path stack_trace source_maps]
- source_maps 0.10.10-nullsafety.2 [source_span]
- source_span 1.8.0-nullsafety.2 [charcode collection path term_glyph]
- sqflite 1.3.2+1 [flutter sqflite_common path]
- sqflite_common 1.0.2+1 [synchronized path meta]
- stack_trace 1.10.0-nullsafety.1 [path]
- stream_channel 2.1.0-nullsafety.1 [async]
- string_scanner 1.1.0-nullsafety.1 [charcode source_span]
- synchronized 2.2.0+2
- term_glyph 1.2.0-nullsafety.1
- test 1.16.0-nullsafety.5 [analyzer async boolean_selector coverage http http_multi_server io js node_preamble package_config path pedantic pool shelf shelf_packages_handler shelf_static shelf_web_socket source_span stack_trace stream_channel typed_data web_socket_channel webkit_inspection_protocol yaml test_api test_core]
- test_api 0.2.19-nullsafety.2 [async boolean_selector collection meta path source_span stack_trace stream_channel string_scanner term_glyph matcher]
- test_core 0.3.12-nullsafety.5 [analyzer async args boolean_selector collection coverage glob io meta package_config path pedantic pool source_map_stack_trace source_maps source_span stack_trace stream_channel vm_service yaml matcher test_api]
- typed_data 1.3.0-nullsafety.3 [collection]
- unicode 0.2.4 [lists]
- url_launcher_linux 0.0.1+4 [flutter]
- url_launcher_macos 0.0.1+9 [flutter]
- url_launcher_platform_interface 1.0.9 [flutter meta plugin_platform_interface]
- url_launcher_web 0.1.5+1 [url_launcher_platform_interface flutter flutter_web_plugins meta]
- url_launcher_windows 0.0.1+3 [flutter]
- vector_math 2.1.0-nullsafety.3
- vm_service 5.5.0 [meta]
- watcher 0.9.7+15 [async path pedantic]
- web_socket_channel 1.1.0 [async crypto stream_channel]
- webkit_inspection_protocol 0.7.4 [logging]
- win32 1.7.4 [ffi]
- xdg_directories 0.1.2 [meta path process]
- xml 4.5.1 [collection convert meta petitparser]
- yaml 2.2.1 [charcode collection string_scanner source_span]

I can't reproduce this on the latest master 1.26.0-2.0.pre.64 with cloud_firestore: ^0.14.4.

flutter doctor -v
[√] Flutter (Channel master, 1.26.0-2.0.pre.64, on Microsoft Windows [Version 10.0.19041.685], locale et-EE)
    • Flutter version 1.26.0-2.0.pre.64 at C:\Development\flutter_master
    • Framework revision 9ff4326e1f (4 hours ago), 2020-12-17 06:19:05 +0000
    • Engine revision 6edb402ee4
    • Dart version 2.12.0 (build 2.12.0-157.0.dev)

[√] Android toolchain - develop for Android devices (Android SDK version 30.0.2)
    • Android SDK at C:\Users\marku\AppData\Local\Android\sdk
    • Platform android-30, build-tools 30.0.2
    • Java binary at: C:\Users\marku\AppData\Local\JetBrains\Toolbox\apps\AndroidStudio\ch-0\201.6953283\jre\bin\java
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b01)
    • All Android licenses accepted.

[√] Chrome - develop for the web
    • Chrome at C:\Program Files\Google\Chrome\Application\chrome.exe

[√] Visual Studio - develop for Windows (Visual Studio Community 2019 16.7.7)
    • Visual Studio at C:\Program Files (x86)\Microsoft Visual Studio\2019\Community
    • Visual Studio Community 2019 version 16.7.30621.155
    • Windows 10 SDK version 10.0.18362.0

[√] Android Studio (version 4.1.0)
    • Android Studio at C:\Users\marku\AppData\Local\JetBrains\Toolbox\apps\AndroidStudio\ch-0\201.6953283
    • Flutter plugin can be installed from:
       https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
       https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b01)

[√] IntelliJ IDEA Ultimate Edition (version 2020.3)
    • IntelliJ at C:\Users\marku\AppData\Local\JetBrains\Toolbox\apps\IDEA-U\ch-0\203.5981.155
    • Flutter plugin can be installed from:
       https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
       https://plugins.jetbrains.com/plugin/6351-dart

[√] Connected device (4 available)
    • sdk gphone x86 arm (mobile) • emulator-5554 • android-x86    • Android 11 (API 30) (emulator)
    • Windows (desktop)           • windows       • windows-x64    • Microsoft Windows [Version 10.0.19041.685]
    • Chrome (web)                • chrome        • web-javascript • Google Chrome 87.0.4280.88
    • Edge (web)                  • edge          • web-javascript • Microsoft Edge 87.0.664.60

• No issues found!

Code sample
import 'dart:io';

import 'package:cloud_firestore/cloud_firestore.dart';
import 'package:firebase_core/firebase_core.dart';
import 'package:flutter/material.dart';

void main() async {
  WidgetsFlutterBinding.ensureInitialized();
  FirebaseApp app = await Firebase.initializeApp();
  assert(app != null);
  String host = Platform.isAndroid ? '<IP_ADDRESS>:8080' : 'localhost:8080';

  FirebaseFirestore.instance.settings = Settings(
    host: host,
    sslEnabled: false,
    persistenceEnabled: false,
  );
  runApp(MyApp());
}

class MyApp extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      debugShowCheckedModeBanner: false,
      title: 'Material App',
      theme: ThemeData.dark(),
      home: Scaffold(
        appBar: AppBar(
          title: const Text('Sample'),
        ),
        body: Column(
          mainAxisAlignment: MainAxisAlignment.spaceEvenly,
          crossAxisAlignment: CrossAxisAlignment.stretch,
          children: [
            RaisedButton(
              child: const Text("Set"),
              onPressed: () async {
                print('start');
                await FirebaseFirestore.instance.collection('test').doc('testDoc').set({'test': 'non-working'}).catchError((e,s) => print('$e\n$s'));
                print('end');
              },
            ),
            RaisedButton(
              child: const Text("Get"),
              onPressed: () async {
                print('start');
                var doc = await FirebaseFirestore.instance.collection('test').doc('testDoc').get();
                print(doc.data());
              },
            ),
          ],
        ),
      ),
    );
  }
}

Can you reproduce this with this code sample? What version of the firebase CLI are you using?
Thank you

Unfortunately this does not work. I replaced my whole main.dart with your code sample, and as I previously mentioned, it prints start and then stays there. Nothing gets written to the database and end does not print.
I am currently on the latest stable channel as I cannot afford to be in master channel with this project.
I just updated to the latest firebase tools by using npm install -g firebase-tools
And the output is:
npm WARN deprecated<EMAIL_ADDRESS>request has been deprecated, see https://github.com/request/request/issues/3142
npm WARN deprecated<EMAIL_ADDRESS>this library is no longer supported
/usr/local/bin/firebase -> /usr/local/lib/node_modules/firebase-tools/lib/bin/firebase.js
+<EMAIL_ADDRESS>updated 1 package in 22.887s

So I believe the CLI version is 9.0.1
I retired your code sample after updating and it still does not work.

I'm not seeing this on iOS simulator either. Was not able to connect to the emulator on physical due to some connection issue but it seemed to be working just fine on simulator.

flutter doctor -v
[✓] Flutter (Channel master, 1.26.0-2.0.pre.84, on macOS 11.0.1 20B29 darwin-x64, locale en-GB)
    • Flutter version 1.26.0-2.0.pre.84 at /Users/markus/development/flutter_master
    • Framework revision cda1fae6b6 (4 hours ago), 2020-12-18 04:04:02 -0500
    • Engine revision 1be6f414e7
    • Dart version 2.12.0 (build 2.12.0-166.0.dev)

[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.1)
    • Android SDK at /Users/markus/Library/Android/sdk
    • Platform android-30, build-tools 30.0.1
    • Java binary at: /Users/markus/Library/Application Support/JetBrains/Toolbox/apps/AndroidStudio/ch-0/201.6953283/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6915495)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 12.2)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 12.2, Build version 12B45b
    • CocoaPods version 1.10.0

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 4.1)
    • Android Studio at /Users/markus/Library/Application Support/JetBrains/Toolbox/apps/AndroidStudio/ch-0/201.6953283/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      � https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      � https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6915495)

[✓] Connected device (4 available)
    • Nevercode’s iPhone (mobile) • b668e524315069f3db3661ac11ff1f66afafebdb • ios            • iOS 14.2
    • iPhone 12 Pro Max (mobile)  • CBF5C2A0-A408-4AED-A3DB-B385136B29FA     • ios            • com.apple.CoreSimulator.SimRuntime.iOS-14-2 (simulator)
    • macOS (desktop)             • macos                                    • darwin-x64     • macOS 11.0.1 20B29 darwin-x64
    • Chrome (web)                • chrome                                   • web-javascript • Google Chrome 87.0.4280.67

• No issues found!

Is nothing logged to flutter run -v or Xcode console if you wait during the operation?

Upon trying again, it does seem to be working now. Maybe an temporary error with Xcode or Firebase that was preventing it from connecting to the local?
Anyways, it works now. Thank you!


Test alias types byte and rune

Added test cases for byte and rune to close issue #9.

Although package generics maintains the highest level of standards around tests passing, the Travis integration is still a WIP, therefore I do not consider it a blocking issue at this time.
That said, I must still verify these changes by hand before accepting the PR.

I have to say that I really appreciate you taking time to verifying these changes by hand while CI is still in WIP considering amount of code these changes may have on impact in g.go.

It's hard work, but that's what passion is all about. I'll make the hard
personal sacrifices to ensure the success of something I truly believe is
the future of golang.
On Sep 26, 2016 6:23 AM, "Henri Koski"<EMAIL_ADDRESS>wrote:

I have to say that I really appreciate you taking time to verifying these
changes by hand while CI is still in WIP considering amount of code these
changes may have on impact in g.go.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/StabbyCutyou/generics/pull/10#issuecomment-249533663,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABdTKuzXHXzusDtgfJvVZSXTOoxSFqmUks5qt50lgaJpZM4KGWKR
.


martin-cr suggestions - removed optional return types

No longer returning Optionals.

Your changes addressed only the specific issues that I had marked. Please go through all of the changes in the PR and check whether my comments about @throws, throws clauses in the method signature, and rethrowing caught exceptions are applicable. In (almost?) every case, they are, and changes are required.

I overlooked that comment today. Thank you for bringing this to my attention.

I overlooked that comment today. Thank you for bringing this to my attention.

No worries, it's easy to miss comments sometimes :) Thanks for addressing it!


[test-integration] Remove most of the runCommandWithOutput

There is 5 calls left of runCommandWithOutput, that use StdinPipe that is not yet supported by icmd.
/cc @thaJeztah @dnephin @icecrime @AkihiroSuda @runcom @cpuguy83
🐸
Signed-off-by: Vincent Demeester<EMAIL_ADDRESS>

rebased 👼


Feature - Rename DynamicText library

before the first release using the conventional naming.

So now, you want to have all "dynamic" libraries in one project? Three comments back was there nothing common for them.

Well but those libraries have nothing in common, right?

So now, you want to have all "dynamic" libraries in one project? Three comments back was there nothing common for them.

Well but those libraries have nothing in common, right?

common... they can be in the same GROUP but they are not depending on each other, that's a different. And having them in one ida project is completely different. There you can have everything as long as it's grouped properly.
now you can have com.twocoders.dynamic:text, com.twocoders.dynamic:color as you said like the best but they are separate libraries they are only in the same dynamic group of libraries...

So now, you want to have all "dynamic" libraries in one project? Three comments back was there nothing common for them.

Well but those libraries have nothing in common, right?

common... they can be in the same GROUP but they are not depending on each other, that's a different. And having them in one ida project is completely different. There you can have everything as long as it's grouped properly.
now you can have com.twocoders.dynamic:text, com.twocoders.dynamic:color as you said you like the best but they are separate libraries they are only in the same dynamic group of libraries...
:dynamic-text and :dynamic-color indicate they share code together or are at least linked together

Ok, but this will affect the the publishing process. so then we need to revert my changes mentioned in the #3 .

So now, you want to have all "dynamic" libraries in one project? Three comments back was there nothing common for them.

Well but those libraries have nothing in common, right?

common... they can be in the same GROUP but they are not depending on each other, that's a different. And having them in one ida project is completely different. There you can have everything as long as it's grouped properly.
now you can have com.twocoders.dynamic:text, com.twocoders.dynamic:color as you said you like the best but they are separate libraries they are only in the same dynamic group of libraries...
:dynamic-text and :dynamic-color indicate they share code together or are at least linked together

Ok, but this will affect the the publishing process. so then we need to revert my changes mentioned in the #3 .

What changes do you mean, this should be ready to publish as com.twocoders.dynamic:text. what do you mean will be affected?

So now, you want to have all "dynamic" libraries in one project? Three comments back was there nothing common for them.

Well but those libraries have nothing in common, right?

common... they can be in the same GROUP but they are not depending on each other, that's a different. And having them in one ida project is completely different. There you can have everything as long as it's grouped properly.
now you can have com.twocoders.dynamic:text, com.twocoders.dynamic:color as you said you like the best but they are separate libraries they are only in the same dynamic group of libraries...
:dynamic-text and :dynamic-color indicate they share code together or are at least linked together

Ok, but this will affect the the publishing process. so then we need to revert my changes mentioned in the #3 .

What changes do you mean, this should be ready to publish as com.twocoders.dynamic:text. what do you mean will be affected? I'm not sure.

This: https://github.com/Two-Coders/dynamic-text/pull/3/files#r541675101

So now, you want to have all "dynamic" libraries in one project? Three comments back was there nothing common for them.

Well but those libraries have nothing in common, right?

common... they can be in the same GROUP but they are not depending on each other, that's a different. And having them in one ida project is completely different. There you can have everything as long as it's grouped properly.
now you can have com.twocoders.dynamic:text, com.twocoders.dynamic:color as you said you like the best but they are separate libraries they are only in the same dynamic group of libraries...
:dynamic-text and :dynamic-color indicate they share code together or are at least linked together

Ok, but this will affect the the publishing process. so then we need to revert my changes mentioned in the #3 .

What changes do you mean, this should be ready to publish as com.twocoders.dynamic:text. what do you mean will be affected? I'm not sure.

This: https://github.com/Two-Coders/dynamic-text/pull/3/files#r541675101

if you mean removal of
    dryRun = false
    override = false

and version update this shouldn't affect that in any way. No need to remove that IMHO


Switch to MIT license

Switch from LGPL v3+ to MIT.
Ping @gagern – I guess that’s okay with you? I think I’ll have to wait for your green light on this since there’s code by you involved here.

@addaleax: Sure, go ahead. Thanks for asking!

Thanks!


Please add this for 1.19.2!

This is EXACTLY what I'm looking to add to my server, is 1.19.2 an option?

Also, on Forge

Hi!
I experimented with maintaining support for multiple versions for some of my mods. I found that it is not worth the extra time and effort for me. I have a limited amount of time I can spend on modding and I'd rather spend that time on supporting the current version of the game and on creating new mods.
Adding support for Forge is a similar problem. Additionally I would have to rewrite large parts of the mod. I make heavy use of mixins, which are (to my knowledge) not supported by Forge.
I hope my reasons are understandable.


Refactor to introduce a sans-I/O layer?

https://sans-io.readthedocs.io/how-to-sans-io.html
Bonus: write curio- or trio-compatible versions of the main APIs?

Backpressure may be a bit tricky to handle.
Sans-I/O requires an implementation that is "defined entirely in terms of synchronous functions returning synchronous results, and that does not block or wait for any form of I/O."
Probably the best way to tell the I/O layer to stop the flow of input bytes without infringing these requirements is to send stop / resume events in the output stream.
Conversely, there should be a way to let the I/O layer tell the protocol to stop the flow of output bytes.

Websockets needs a way to reassemble incoming data chunks and read lines (for parsing the handshake) or N bytes (for parsing frames). asyncio.StreamReader and ohneio implement this part.

hyper-h2 simply attempts to parse HTTP2 frames, giving up if there isn't enough data and retrying when more data is pushed. This results in repeated work: the header is re-parsed every time.

Another concern is that WebSockets specifies some TCP-specific behavior, mostly related to half-closing and closing connections. This behavior cannot be encoded into the abstraction of a sans-I/O protocol.

The websockets.framing module is already almost sans-I/O compliant: dropping the @asyncio.coroutine decorator (which mostly serves as documentation) and injecting reader = ohneio.read and writer = ohneio.write should do the job.
The websockets.http module doesn't support injecting reader but that would be easy to change.
Then, with some surgery, about half of websockets.protocol could be extracted in the same way.
We'd end up with the protocol logic split across a sans-I/O part and a with-I/O part, which may or may not be easier to maintain. I don't remember bugs in the would-be sans-I/O part, all the complexity is in the with-I/O part...

There is a wsproto library that is already sans-I/O that could be helpful here.

Yes, I'm aware of wsproto.
It can be an inspiration for designing the API. Similar APIs will make it easier for third party integrators to support either websockets or wsproto (like uvicorn does).
I considered depending on the third-party implementation in wsproto and decided it wouldn't be a good trade-off.
websockets predates wsproto by more than three years. I'd rather continue building on the code base that I know very well and that received lots of production use than discover a new set of behaviors.
My problem isn't about writing a Sans-I/O implementation. I almost have one, as explained in the previous comment. It's more about plugging that implementation in the high-level APIs and determining whether this is an improvement — including in terms of performance.
Currently websockets doesn't have any dependencies. That's a good thing.  For example, websockets is more than 30 times faster than wsaccel, which wsproto uses, for masking 10kB of data:
>>> import timeit
>>> timeit.timeit(
...     """apply_mask(data, mask)""",
...     """from websockets.speedups import apply_mask; data = b'abcdefghij' * 1024; mask = b'xyzt'; """,
... )
0.46926557800000523
>>> timeit.timeit(
...     """masker.process(data)""",
...     """from wsaccel.xormask import createXorMasker; data = b'abcdefghij' * 1024; masker = createXorMasker(b'xyzt'); """,
... )
15.354961824000014
>>> 15.354961824000014 / 0.46926557800000523
32.721261784089016

Do I understand correctly that this is primarily about being able to use a protocol without tightly binding it to some specific source or sink (e.g. file descriptors) and secondarily about the issue with *red/blue functions? (Haven't watched the talk yet but it's now on my to do list.)

Yes, these are the main design principles. https://sans-io.readthedocs.io/ is a reasonably short read.

The low-level API I'd like to expose should look like this: https://aioquic.readthedocs.io/en/latest/http3.html /Cc @jlaine

If you want a more mature example I recommend looking at h11 and h2.
Ping @sethmlarson ;)

I'll take a look, thanks!

I wrote about the implementation strategy here: https://fractalideas.com/blog/sans-io-when-rubber-meets-road/


ci: Add needs to custom composite actions

Change-type: minor

Can needs be passed to action ?
Why can't uses the fork repository as a reusable workflow ?
Like this uses<EMAIL_ADDRESS>will got an workflow not found error.

Can needs be passed to custom composite action ?

@klutchell do you recall why we didn't set restrict_custom_actions: true here already? For the other part, I don't see any issues passing the needs object to custom actions...

Why can't uses the fork repository as a reusable workflow ? Like this uses<EMAIL_ADDRESS>will got an workflow not found error.

@issenn that should work - did you check your repo/org settings to see if reusable workflows are enabled/unrestricted?

Why can't uses the fork repository as a reusable workflow ? Like this uses<EMAIL_ADDRESS>will got an workflow not found error.

@issenn that should work - did you check your repo/org settings to see if reusable workflows are enabled/unrestricted?

I can't find related options in repo settings, only see Allow all actions and reusable workflows enabled in Settings-Action-General-Actions permissions. I didn't change any settings, I'll try again later with fork repository.

except adding a new input at this point would break any existing custom actions that aren't expecting it. Might be better to find a way to do it with env vars like we did for custom matrix, etc.

I think, adding a new input element in the action does not affect other actions, because this element is unused. needs has some pre-initialized event_types and project_types, and env.matrix_value can only pass matrix strategy parameters.

Hey @issenn , do you still need this change? Would you mind updating your PR to use the change I suggested above to avoid breaking existing workflows?
echo "needs_json=${{ toJSON(needs) }}" >> $GITHUB_ENV


In Whatsapp Windows Store version, Drag And Drop files into a conversation doesn't work

Description
Files dragged from the Files program into a WhatsApp conversation do trigger the windows mouse loading icon and then it goes away without adding the file to the conversation like File Explorer Does.
Steps To Reproduce
In the WhatsApp Windows Store App, open a conversation and drag a file from the Files window into a conversation, the file should be added to the conversation like in File Explorer, but that does not happen.
Requirements
When a File is dragged from the Files program into a WhatsApp conversation that file should be added to the conversation just like File Explorer Does.
Files Version
<IP_ADDRESS>
Windows Version
Windows 11 22H2 10.0.22621.1344
Log file
debug.log

Merging with #10171


Re-enable CVE test "Verify IsFixable is correct when scoped (#digest, #fixable)" in postgres mode

Description
A detailed explanation of the changes in your PR.
Feel free to remove this section if it is overkill for your PR, and the title of your PR is sufficiently descriptive.
Checklist

[ ] Investigated and inspected CI test results
[ ] Unit test and regression tests added
[ ] Evaluated and added CHANGELOG entry if required
[ ] Determined and documented upgrade steps
[ ] Documented user facing changes (create PR based on openshift/openshift-docs and merge into rhacs-docs)

If any of these don't apply, please comment below.
Testing Performed
TODO(replace-me)
Use this space to explain how you tested your PR, or, if you didn't test it, why
you did not do so. Valid reasons include, for example, "CI is sufficient",
"No testable changes". Feel free to attach JSON snippets, curl commands,
screenshots.
In addition to reviewing your code, reviewers must also review your testing
instructions and make sure they are sufficient.

Could you add description for this change?

/retest


Prevent server error cause c3 uses window

Fixes #13

@maZahaca: LGTM.

@bcbcarl when we can expect release of this issue?


Don't check for malloc failure twice.

a03f81f4ead24c234dc26e388d86a352685f3948 added a malloc failure check to EVP_PKEY_keygen, but there already was one.
Wasn't sure whether you all preferred the one with or without the EVPerr. The original code was without. EVP_PKEY_new already pushes ERR_R_MALLOC_FAILURE on error.

+1

+1 let me know if you want me to merge.


Communicator Deployment fails

I'm facing a new problem with Communicator when deploying using the master branch (haven't tried using other branches). Pls see the error message below. Has anyone encountered this?
{
"code": "DeploymentFailed",
"message": "At least one resource deployment operation failed. Please list deployment operations for details. Please see https://aka.ms/DeployOperations for usage details.",
"details": [
{
"code": "Conflict",
"message": "{\r\n  "status": "Failed",\r\n  "error": {\r\n    "code": "ResourceDeploymentFailure",\r\n    "message": "The resource operation completed with terminal provisioning state 'Failed'."\r\n  }\r\n}"
}
]
}
{ "id": "/subscriptions/9649282e-6ae7-4488-b646-195a841fca77/resourceGroups/azrg-eut-eoc-managed-prod/providers/Microsoft.Resources/deployments/Microsoft.Template/operations/D7189BA20740A200", "operationId": "D7189BA20740A200", "properties": { "provisioningOperation": "Create", "provisioningState": "Failed", "timestamp": "2019-11-29T13:58:39.3276151Z", "duration": "PT1H5M13.4637209S", "trackingId": "feb6efb5-54db-4603-9017-f8acf3683abb", "statusCode": "Conflict", "statusMessage": { "status": "Failed", "error": { "code": "ResourceDeploymentFailure", "message": "The resource operation completed with terminal provisioning state 'Failed'." } }, "targetResource": { "id": "/subscriptions/9649282e-6ae7-4488-b646-195a841fca77/resourceGroups/azrg-eut-eoc-managed-prod/providers/Microsoft.Web/sites/eytechprod/sourcecontrols/web", "resourceType": "Microsoft.Web/sites/sourcecontrols", "resourceName": "eytechprod/web" } }}

Check the troubleshooting section on the guide. it's the first error..https://github.com/OfficeDev/microsoft-teams-company-communicator-app/wiki/Troubleshooting#1-code-deployment-failure

@csnarain Did

Check the troubleshooting section on the guide. it's the first error..https://github.com/OfficeDev/microsoft-teams-company-communicator-app/wiki/Troubleshooting#1-code-deployment-failure

The resolution provided here should fix the issue.
@csnarain was the issue resolved.

Closing due to inactivity. Please re-open if you're still facing the issue.


"git add submodule" is wrong in your instructions.

The correct syntax is "git submodule add",... not "git add submodule"

thx


ng command not found on archlinux

Hello,
I am trying to start a MEAN project with Angular Cli, the problem is that bash does not find ng command.
N.B.
I installed @angular/cli locally, not globally. Here is my npm list --depth=0 output:
[ubarch@ubarch_725_g2 ~]$ npm list --depth=0
<EMAIL_ADDRESS>/home/ubarch
├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>└──<EMAIL_ADDRESS>
I found ng into the path ~/node_modules/@angular/cli/bin and I can execute it if I call using ./ng, the output is in the following screeshot.

What have I do to make ng usable without invoking it with ./ ?

Angular CLI can either be install globally (npm i -g @angular/cli) or locally on a project (same command but without -g).
In your case you're installing it locally but not on a project.  That won't work because your user directory is not really a CLI project.
I recommend that you either do a global install or create a real project to install Angular CLI in. Then you can add a npm script to your package.json that calls it (e.g. "ng": "ng",) and call commands with npm run ng -- args --flags).
 But the half local half global approach you're trying is not supported.

Thank you very much for the advice, I didn't know.


[improvement] Ability to export and import (additively) the requirements only

As title. Since ~you are too lazy~ it is difficult to parse the major requirement from the provided PDF files directly, it may be viable to have people share templates instead.

Feature included.


Remove extra sleep in ReconnectTest after polling hack is resolved

This issue tracks a work item to revert https://github.com/grpc/grpc/pull/14339 when the polling thread hack to track channel connectivity is removed and proper retry mechanisms are in place

@mehrdada or @kpayson64: is this now actionable? It smells now actionable?

I think we can close this issue now.
With the new "background poller" approach, the channels are only ever polled periodically, so we need the sleep in the test indefinitely.


[wasm] Add ICS20 withdrawals support for transaction plan building

Transaction planner interface now supports
repeated penumbra.core.component.ibc.v1alpha1.IbcAction ibc_actions = 60;
repeated penumbra.core.component.ibc.v1alpha1.Ics20Withdrawal ics20_withdrawals = 61;

We need to add support for these actions (ibc_actions, ics20_withdrawals) to wasm_planner
There may be some complications when importing crates related to IBC, previously we avoided them because they were not compatible with wasm32-unknown-unknown target

I don't have permission, so I can't assign this and some other wasm issues to me


defaulting max_early_data to SSL3_RT_MAX_PLAIN_LENGTH causes wasted traffic

Currently, we set a default max_early_data to SSL3_RT_MAX_PLAIN_LENGTH in SSL_CTX_new(), on the grounds that this is a sane default value for applications to use and there's supposedly no need to make them explicitly set a value when there are other things they have to do in order to get the application to actually use early data.  IIRC these "other things" are just calls to SSL_read_early_data(), which sets s->early_data_state to SSL_EARLY_DATA_ACCEPTING whicih in turn is required for final_early_data() to set s->ext.early_data to SSL_EARLY_DATA_ACCEPTED, which is in turn then used to determine whether we send the early_data extension in tls_construct_stoc_early_data() to tell the client that early data was accepted.
However, this setup means that when we construct a session ticket, tls_construct_stoc_early_data() will see a non-zero s->max_early_data and put into the ticket's extensions "sure, send us early data".  Clients will see this and attempt to send early data, which is doomed to fail unless the application has opted in.  This wastes bandwidth attempting to send data that will be rejected, and will also burn up session tickets for clients that adhere to the spec's recommendation to only use a ticket once.
The s->early_data_state field is not usable when determining whether to indicate that a given
ticket under construction should indicate to the client that early data is acceptable, as that field is a property of the current connection, and is not relevant to the application's configuration.  I think that we should change the default max_early_data to zero and require the application to set a non-zero value when it adds calls to SSL_read_early_data(), to make the default behavior for non-early-data-consuming applications more reasonable.

This is a good argument and seems fairly reasonable to me. When I set the default it wasn't clear to me what the default should be so I think I just picked something! We should make sure we update the docs if we do this. Care to make a PR?

I can try to put something together, sure.  I'm at the IETF meeting this week, so it may take longer than usual.


Trash bin restore move does not send back Etag and other headers

normal MOVE:
curl -k 'https://localhost:9200/remote.php/dav/files/einstein/file.txt' -ueinstein:relativity -X MOVE -H'Destination: https://localhost:9200/remote.php/dav/files/einstein/textfile1.txt' -v

.....

> MOVE /remote.php/dav/files/einstein/file.txt HTTP/1.1
> Host: localhost:9200
> Authorization: Basic ZWluc3RlaW46cmVsYXRpdml0eQ==
> User-Agent: curl/7.68.0
> Accept: */*
> Destination: https://localhost:9200/remote.php/dav/files/einstein/textfile1.txt
>
* TLSv1.3 (IN), TLS handshake, Newsession Ticket (4):
* Mark bundle as not supporting multiuse
< HTTP/1.1 201 Created
< Access-Control-Allow-Origin: *
< Content-Length: 0
< Content-Security-Policy: default-src 'none';
< Content-Type: text/plain; charset=utf-8
< Date: Thu, 17 Dec 2020 08:27:36 GMT
< Etag: "2befda739e8362fa65008837d4d738fc"
< Oc-Etag: "2befda739e8362fa65008837d4d738fc"
< Oc-Fileid: MTI4NGQyMzgtYWE5Mi00MmNlLWJkYzQtMGIwMDAwMDA5MTU3OjY2MWYwZDQzLWQxYjMtNGE2OC1hN2M2LTJiZTY4M2UxZTVlMQ==
< Vary: Origin
< X-Content-Type-Options: nosniff
< X-Download-Options: noopen
< X-Frame-Options: SAMEORIGIN
< X-Permitted-Cross-Domain-Policies: none
< X-Robots-Tag: none
< X-Xss-Protection: 1; mode=bloc

trash-bin restore MOVE
curl -k 'https://localhost:9200/remote.php/dav/trash-bin/einstein/4c510ada-c86b-4815-8820-42cdf82c3d51:661f0d43-d1b3-4a68-a7c6-2be683e1e5e1' -X MOVE -H'Destination: https://localhost:9200/remote.php/dav/files/einstein/textfile0.txt' -ueinstein:relativity -v

.....

> MOVE /remote.php/dav/trash-bin/einstein/4c510ada-c86b-4815-8820-42cdf82c3d51:661f0d43-d1b3-4a68-a7c6-2be683e1e5e1 HTTP/1.1
> Host: localhost:9200
> Authorization: Basic ZWluc3RlaW46cmVsYXRpdml0eQ==
> User-Agent: curl/7.68.0
> Accept: */*
> Destination: https://localhost:9200/remote.php/dav/files/einstein/textfile0.txt
>
* TLSv1.3 (IN), TLS handshake, Newsession Ticket (4):
* Mark bundle as not supporting multiuse
< HTTP/1.1 204 No Content
< Access-Control-Allow-Origin: *
< Content-Security-Policy: default-src 'none';
< Date: Thu, 17 Dec 2020 08:23:31 GMT
< Vary: Origin
< X-Content-Type-Options: nosniff
< X-Download-Options: noopen
< X-Frame-Options: SAMEORIGIN
< X-Permitted-Cross-Domain-Policies: none
< X-Robots-Tag: none
< X-Xss-Protection: 1; mode=block
<

re-tested with local server oCIS version 1.11.0
@individual-it It works. I suggest to close
trash-bin restore MOVE:
curl 'https://localhost:9200/remote.php/dav/trash-bin/marie/4081f8ee-a058-495d-bbf7-7db42d363dda' \

There is no mention in expected-failures - closing.


Update ngclient to skip visited nodes on delegation tree traversal

This change edits the ngclient Updater to traverse the delegation
tree on nodes, instead of edges in order to skip already visited
nodes.
For more detailed clarification, please review
theupdateframework/specification#177
Fixes #1528
Signed-off-by: Ivana Atanasova<EMAIL_ADDRESS>
[x] The code follows the Code Style Guidelines
[n/a] Tests have been added for the bug fix or new feature
[n/a] Docs have been added for the bug fix or new feature

Testing the delegation tree traversal requires changes in the implementation that are not related to this change and as a major update of the tests is already in the process of writing, I'm pushing this change relying only on current tests and logic assumptions.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

6 of 6 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.002%) to 97.465%

Totals

Change from base Build<PHONE_NUMBER>:
0.002%

Covered Lines:
3950

Relevant Lines:
4034

💛  - Coveralls


Metis <-> Base routes not getting filled by Routers in either direciotn

these should be fast path
Other routes to Base are coreclty going fast path
https://connextscan.io/tx/0xad1524bc351b9b6860eec2629a7dc5d0a116f13208f49f3bcb89c19c74856344
https://connextscan.io/tx/0x51f40ccc0e41db38edc817352ef9396a07bc6e80f87f9954bd8a518df79edc2f

This is solved after the router updates


Tailwind 2 Upgrade

Can you advice what needs to be done to upgrade to the latest @2 version of tailwind?

Haven't looked, it just came out. The upgrade guide would be a good place to start.
A PR would be appreciated if you can get started on it ❤

Have looked into it, but seems that tailwind is gonna need Laravel Mix v6.0 which is still in beta at mo

I keep getting this error whenever i run the npm run dev  command to use the tailwind preset with auth in laravel 8. Any suggestions??

I keep getting this error whenever i run the npm run dev  command to use the tailwind preset with auth in laravel 8. Any suggestions??


Downloading large videos freezes at end

Version
1.19.12
Details
The specific video is here. The video, downloading at max quality, is fine for the most part. Then, at 95.3%, it gets stuck indefinitely. Other large videos get stuck at the same exact percentage. In task manager, it shows the process taking up memory (obviously), but no CPU usage or any other network tasks. I left it like that for a few hours, and it stayed stuck. Any ideas what this may be caused by?
Steps to reproduce
see above

Is it consistently reproducible for you on that video? Which format did you choose to download?

It is reproducible, very consistently. I chose highest quality.

It does appear to finish eventually, just takes a while and does not report progress for whatever reason. I'll look into it.

How long does it take you for the video to finish? It's been an hour for me and I'm not seeing any change.

I think around 40 minutes. You should be able to see progress if you look at the output file and keep refreshing to see it grow in size.

That's weird. It's been 6 hours and nothing's happening.

That's weird. It's been 6 hours and nothing's happening.

Do you not see the output file changing in size at all? There should be a couple of .tmp files next to it too.

I see the temp files, but the output doesn't change all.

Fixed in d925d87.

Should work now


add logging for yum repos and compose ids

Fixes OSBS-8381
Add explicit logging of injected yum repos and inherited yum repos and compose ids.
Maintainers will complete the following section:

[x] Commit messages are descriptive enough
[x] "Signed-off-by:" line is present in each commit
[x] Code coverage from testing does not decrease and new code is covered
[x] JSON/YAML configuration changes are updated in the relevant schema
[x] Changes to metadata also update the documentation for the metadata
[x] Pull request includes link to an osbs-docs PR for user documentation updates
[x] New feature can be disabled from a configuration file

Waiving docs and toggle requirements: changes to logging output only.


cookie can't be set in chrome

fetch('http://mytest.com/login', {
        method: 'POST',
        headers: {
          'Content-Type': 'application/json',
          credentials: 'include',
        },
        body: JSON.stringify({
          username: 'username',
          password: 'password',
        }),
      })

chrome/55.0.2883.95 implements fetch. Perhaps, it didn't implement the specification as shown here -- Fetch Standard. Set-Cookie response headers are always ignored, no matter whether credentials option is set or not.
However, safari 10.0.2 has not implement fetch, so ajax makes Set-Cookie  functional.
So, for compatibility, is it possible to do something before return?

If you want to override Chrome's implementation with our polyfill—NOT RECOMMENDED—then you can do:
<script>window.fetch = undefined</script>
<script src="./fetch.js"></script>

However, if you have problems when using native fetch in the browser, but using XMLHttpRequest (like this polyfill uses) works just fine with CORS and cookies, then perhaps you should use XMLHttpRequest directly in your app and not fetch.

Thank you for your fast response, this maybe an option.


Altitude error while doing swarming using mavsdk-python ?

when I tried flying two drones at the same altitude using the same function (i.e takeoff) both the drones react in different way (error in altitude ) .Why does this error exist in the simulation ? apart from these when i tried to fly both the drones using the manual control when when both the drones received the same input both reacted differently.there is no significant difference in roll.yaw or pitch but the error in height is  persistent even with manual control or offboard  mode.
here is the code for takeoff :
#!/usr/bin/env python3

import asyncio#!/usr/bin/env python3

import asyncio
from mavsdk import System

async def run():
    drone = System(mavsdk_server_address="localhost", port=50040)
    await drone.connect(system_address="udp://:14541")
    drone2 = System(mavsdk_server_address="localhost", port=50041)
    await drone2.connect(system_address="udp://:14542")
    async def print_position(drone):
        async for position in drone.telemetry.position():
            return [position.latitude_deg,position.longitude_deg,position.relative_altitude_m]
    print("Waiting for drone to connect...")
    async for state in drone.core.connection_state():
        if state.is_connected:
            print(f"-- Connected to drone!")
            break

    print("Waiting for drone to have a global position estimate...")
    async for health in drone.telemetry.health():
        if health.is_global_position_ok and health.is_home_position_ok:
            print("-- Global position state is good enough for flying.")
            break

    print("Fetching amsl altitude at home location....")
    async for terrain_info in drone.telemetry.home():
        absolute_altitude = terrain_info.absolute_altitude_m
        break
        print("Waiting for drone to connect...")
    async for state in drone2.core.connection_state():
        if state.is_connected:
            print(f"-- Connected to drone!")
            break

    print("Waiting for drone to have a global position estimate...")
    async for health in drone2.telemetry.health():
        if health.is_global_position_ok and health.is_home_position_ok:
            print("-- Global position state is good enough for flying.")
            break

    print("Fetching amsl altitude at home location....")
    async for terrain_info in drone2.telemetry.home():
        absolute_altitude = terrain_info.absolute_altitude_m
        break
    await asyncio.sleep(10)
    print("-- Arming")
    await drone.action.arm()
    await drone2.action.arm()
    print("-- Taking off")
    await drone.action.set_takeoff_altitude(10)
    await drone2.action.set_takeoff_altitude(10)
    await drone.action.takeoff()
    await drone2.action.takeoff()
    await asyncio.sleep(10)
    height_b =  await print_position(drone)
    height_C =  await print_position(drone2)
    i=0
    while i < 10:
            height_b =  await print_position(drone)
            height_C =  await print_position(drone2)
            print("height of A")
            print("expected :" + "10")
            print(height_b[2])
            print("height of B")
            print("expected :" + "10")
            print(height_C[2])
            await asyncio.sleep(1)
            i+=1
    await drone.action.land()
    await drone2.action.land()
    await asyncio.sleep(5)
    await drone.action.kill()
    await drone2.action.kill()

from mavsdk import System

async def run():
    drone = System(mavsdk_server_address="localhost", port=50040)
    await drone.connect(system_address="udp://:14541")
    drone2 = System(mavsdk_server_address="localhost", port=50041)
    await drone2.connect(system_address="udp://:14542")
    async def print_position(drone):
        async for position in drone.telemetry.position():
            return [position.latitude_deg,position.longitude_deg,position.relative_altitude_m]
    print("Waiting for drone to connect...")
    async for state in drone.core.connection_state():
        if state.is_connected:
            print(f"-- Connected to drone!")
            break

    print("Waiting for drone to have a global position estimate...")
    async for health in drone.telemetry.health():
        if health.is_global_position_ok and health.is_home_position_ok:
            print("-- Global position state is good enough for flying.")
            break

    print("Fetching amsl altitude at home location....")
    async for terrain_info in drone.telemetry.home():
        absolute_altitude = terrain_info.absolute_altitude_m
        break
        print("Waiting for drone to connect...")
    async for state in drone2.core.connection_state():
        if state.is_connected:
            print(f"-- Connected to drone!")
            break

    print("Waiting for drone to have a global position estimate...")
    async for health in drone2.telemetry.health():
        if health.is_global_position_ok and health.is_home_position_ok:
            print("-- Global position state is good enough for flying.")
            break

    print("Fetching amsl altitude at home location....")
    async for terrain_info in drone2.telemetry.home():
        absolute_altitude = terrain_info.absolute_altitude_m
        break
    await asyncio.sleep(10)
    print("-- Arming")
    await drone.action.arm()
    await drone2.action.arm()
    print("-- Taking off")
    await drone.action.set_takeoff_altitude(10)
    await drone2.action.set_takeoff_altitude(10)
    await drone.action.takeoff()
    await drone2.action.takeoff()
    await asyncio.sleep(10)
    height_b =  await print_position(drone)
    height_C =  await print_position(drone2)
    i=0
    while i < 10:
            height_b =  await print_position(drone)
            height_C =  await print_position(drone2)
            print("height of A")
            print("expected :" + "10")
            print(height_b[2])
            print("height of B")
            print("expected :" + "10")
            print(height_C[2])
            await asyncio.sleep(1)
            i+=1
    await drone.action.land()
    await drone2.action.land()
    await asyncio.sleep(5)
    await drone.action.kill()
    await drone2.action.kill()

if __name__ == "__main__":
    # Run the asyncio loop
    asyncio.run(run())

**```the error :
Waiting for drone to connect...
-- Connected to drone!
Waiting for drone to have a global position estimate...
-- Global position state is good enough for flying.
Fetching amsl altitude at home location....
-- Connected to drone!
Waiting for drone to have a global position estimate...
-- Global position state is good enough for flying.
Fetching amsl altitude at home location....
 My guess is that GPS altitude can drift for the drones, and so the number shown later is off, as the estimate is corrected.
Or to put it differently, the drone takes off in local coordinates 10 meters above the home altitude but the global estimate drifts or changes slightly. The take off command is a local/relative command, but the altitude you're printing is "global". If you want to get to a "global" same altitude, you could use goto_location which will give you an absolute altitude to aim for.

i actually did try mavsdk with real drones and in simulation where both the drones were same . I tried off board and manual control and yet there was some reason a difference in altitude for mavsdk .I don't understand the reason for this but the drones in simulation and real life show the altitude error without any reason.


Fade old tasks

no actual changes, but a QA task to check this app on the free version of asana


large logs need to be fetched and parsed in chunks

When we receive large log files (eg 50mb and above) this breaks the json.parse() function

Rather than attempt to fetch the whole log, we should retrieve it and write it out in chunks.

[ ] create a test that makes a large log, which replicates the issue
[ ] fix the issue

Example SAS code for a large log:
data _null_;
  y=repeat('W',500);
  do x=1 to 1e6;
    putlog y=;
  end;
run;

The adapter should keep fetching log in chunks (up to 10000 lines each) until the whole log has been retrieved.
start parameter should be provided to the GET request to indicate the chunk start line.


build.emptyOutDir = true has no effect

Summary
Hi!
I understand that you internally check if the user set build.emptyOutDir and then manually remove that folder before anything else because you definitely have to set it internally to false. So far, so good, but it seems that resolvedConfig.build.emptyOutDir was already overwritten at the time you test for it.
So, if I don't miss anything, the line referenced here
https://github.com/aklinker1/vite-plugin-web-extension/blob/191fa4f69617e763da0ba334c914b45ff28801b7/packages/vite-plugin-web-extension/src/plugins/manifest-loader-plugin.ts#L222
should be
if (userConfig.build.emptyOutDir) {

instead.
This is the only way I can get the plugin to empty out the dist folder before building the extension.
Reproduction
The default setup plus the build.emptyOutDir option set to true will be enough to demonstrate that the dist folder is not emptied.
// vite.config.ts
import { defineConfig } from 'vite';
import webExtension from 'vite-plugin-web-extension';

export default defineConfig({
	build: {
		emptyOutDir: true
	},
	plugins: [webExtension()]
});

Feel free to let me know if you need anything else.
Environment

  System:
    OS: macOS 14.3.1
    CPU: (12) arm64 Apple M2 Max
    Memory: 335.38 MB / 64.00 GB
    Shell: 5.9 - /bin/zsh
  Binaries:
    Node: 18.14.2 - ~/Library/Caches/fnm_multishells/46290_1710372422808/bin/node
    npm: 9.5.0 - ~/Library/Caches/fnm_multishells/46290_1710372422808/bin/npm
    pnpm: 8.14.1 - /opt/homebrew/bin/pnpm
  Browsers:
    Brave Browser: <IP_ADDRESS>
    Chrome: 122.0.6261.129
    Chrome Canary: 124.0.6356.2
    Edge: 122.0.2365.80
    Safari: 17.3.1
  npmPackages:
    vite: ^5.0.0 => 5.1.5
    vite-plugin-web-extension: ^4.0.0 => 4.1.1

Thanks!

https://github.com/aklinker1/vite-plugin-web-extension/releases/tag/v4.1.3


Update difflibparser submodule link

Fixes #16

Could you please take a look at this and merge @yebrahim ? Thanks!

Thanks for fixing this @TheSandDoctor.

You're welcome @yebrahim ! Thank you for merging :)


mono fails to build on aarch64-darwin

Steps To Reproduce
Steps to reproduce the behavior:

build mono on aarch64-darwin

Build log
https://gist.github.com/babbaj/d1e86b0dd4bbb16664cfdc4f094518f1
Additional context
This is blocking any package made with buildDotnetModule from building with dotnet 6.
relevant code: https://github.com/mono/mono/blob/5d2e3bc3b3c8184d35b2f7801e88d96470d367c4/mcs/build/profiles/build.make#L92
Notify maintainers

@thoughtpolice @obadz @vrthra
Metadata
Please run nix-shell -p nix-info --run "nix-info -m" and paste the result.
@soybook:~ ❯ nix-shell -p nix-info --run "nix-info -m"
 - system: `"aarch64-darwin"`
 - host os: `Darwin 21.4.0, macOS 12.3.1`
 - multi-user?: `yes`
 - sandbox: `yes`
 - version: `nix-env (Nix) 2.8.0`
 - channels(babbaj): `""`
 - channels(root): `"nixpkgs"`
 - nixpkgs: `/nix/store/0y06zg1h1ks4ld6wizg3acraasikgqkk-57y6djpqdmjglkdzgrbsdyjzqkn48ff1-source`

See issue #151720

Fixed by #181051


api union type validation

Signed-off-by: akihikokuroda<EMAIL_ADDRESS>This is for latter of https://github.com/operator-framework/rukpak/issues/216 in case the former way doesn't work well.  When the former works, the e2e tests may still be useful.

Thanks for this @akihikokuroda ... I think the schema validation is still worth looking into, but it is challenging and this seems like a fine intermediate solution IMO. Let's see where that ends up and then we can potentially merge this.

I agree a webhook implementation is better than no schema checks, so +1 on merging this.
However, I think we should try to make use of the documented CRD schema validations for union types because that will:
a) give us more confidence that we implemented the schema type correctly.
b) make our API and the responses sent by the API server in case in validation failure consistent for users who expect kube APIs to follow kube API standards.

I believe that the CRD validation will be done by adding the x-kubernetes-validations in the openAPIV3Schema.  This feature is still **alpha** and in CustomResourceValidationExpressions` feature gate.
                        ref:
                          description: Ref configures the git source to clone a specific branch, tag, or commit from the specified repo. Ref is required, and exactly one field within Ref is required. Setting more than one field or zero fields will result in an error.
                          x-kubernetes-validations:
                            - rule: "(has(self.branch)? 1:0 + has(self.commit)? 1:0 + has(self.tag)? 1:0) == 1"
                          properties:
                            branch:
                              description: Branch refers to the branch to checkout from the repository. The Branch should contain the bundle manifests in the specified directory.
                              type: string
                            commit:
                              description: Commit refers to the commit to checkout from the repository. The Commit should contain the bundle manifests in the specified directory.
                              type: string
                            tag:
                              description: Tag refers to the tag to checkout from the repository. The Tag should contain the bundle manifests in the specified directory.
                              type: string

We shouldn't depend on an alpha feature. For the git.ref field, is it possible to use oneOf?
For the source field, I'd expect to use what's specified here: https://github.com/kubernetes/enhancements/blob/master/keps/sig-api-machinery/1027-api-unions/README.md

It seems possible.  I'll work on it.

I couldn't make the oneOf work.

This PR has:

adding CRD validation in the generated bundles.yaml using Kustomize when it is deployed.
validating webhook for source type and property mismatch
removing the bundle name check from the validating webhook
e2e test for CRD validation


python3.6 dropped but still requires python >= 3.6

Describe the bug
Hello,
support for python 3.6 is dropped since 4.6.0 but requirement still allows for python3.6 to be used with latest versions of pyfakefs.
This allows pip to list and install latest pyfakefs on python3.6.
I did not run any test to verify that latest was effectively still working with python 3.6.

https://pypi.org/project/pyfakefs/
still shows python>=3.6
in addition our dependabot running on python3.6 returned latest version (4.6.3) as an update for our current requirements (4.5.6)
extract from the dependabot run:
getting python 3.6.15
  proxy | 2022/08/22 10:13:04 [072] GET https://www.python.org:443/ftp/python/3.6.15/Python-3.6.15.tar.xz

submitting a PR for pyfakefs 4.6.3
updater | INFO <job_443473186> Updating pyfakefs from 4.5.6 to 4.6.3
  proxy | 2022/08/22 10:18:39 [204] GET https://pypi.org:443/simple/pip/
  proxy | 2022/08/22 10:18:39 [204] 200 https://pypi.org:443/simple/pip/
  proxy | 2022/08/22 10:18:40 [206] GET https://pypi.org:443/simple/pip/
  proxy | 2022/08/22 10:18:40 [206] 200 https://pypi.org:443/simple/pip/
  proxy | 2022/08/22 10:18:43 [208] GET https://pypi.org:443/simple/pip/
  proxy | 2022/08/22 10:18:43 [208] 200 https://pypi.org:443/simple/pip/
  proxy | 2022/08/22 10:18:45 [210] GET https://pypi.org:443/simple/setuptools/
  proxy | 2022/08/22 10:18:45 [210] 304 https://pypi.org:443/simple/setuptools/
  proxy | 2022/08/22 10:18:46 [212] GET https://pypi.org:443/pypi/pyfakefs/json
  proxy | 2022/08/22 10:18:46 [212] 200 https://pypi.org:443/pypi/pyfakefs/json
  proxy | 2022/08/22 10:18:48 [214] GET https://pypi.org:443/simple/setuptools/
  proxy | 2022/08/22 10:18:48 [214] 304 https://pypi.org:443/simple/setuptools/
  proxy | 2022/08/22 10:18:49 [216] GET https://api.github.com:443/repos/EnterpriseDB/tpaexec/commits?per_page=100
  proxy | 2022/08/22 10:18:49 [216] * authenticating github api request
  proxy | 2022/08/22 10:18:49 [216] 200 https://api.github.com:443/repos/EnterpriseDB/tpaexec/commits?per_page=100
  proxy | 2022/08/22 10:18:50 [218] GET https://pypi.org:443/pypi/pyfakefs/json
  proxy | 2022/08/22 10:18:50 [218] 200 https://pypi.org:443/pypi/pyfakefs/json
  proxy | 2022/08/22 10:18:50 [220] GET https://api.github.com:443/repos/jmcgeheeiv/pyfakefs/releases?per_page=100
  proxy | 2022/08/22 10:18:50 [220] * authenticating github api request
  proxy | 2022/08/22 10:18:50 [220] 200 https://api.github.com:443/repos/jmcgeheeiv/pyfakefs/releases?per_page=100
  proxy | 2022/08/22 10:18:50 [222] GET https://api.github.com:443/repos/jmcgeheeiv/pyfakefs/contents/
  proxy | 2022/08/22 10:18:50 [222] * authenticating github api request
  proxy | 2022/08/22 10:18:50 [222] 200 https://api.github.com:443/repos/jmcgeheeiv/pyfakefs/contents/
  proxy | 2022/08/22 10:18:51 [224] GET https://api.github.com:443/repos/jmcgeheeiv/pyfakefs/contents/docs
  proxy | 2022/08/22 10:18:51 [224] * authenticating github api request
  proxy | 2022/08/22 10:18:51 [224] 200 https://api.github.com:443/repos/jmcgeheeiv/pyfakefs/contents/docs
  proxy | 2022/08/22 10:18:51 [226] GET https://api.github.com:443/repos/jmcgeheeiv/pyfakefs/contents/CHANGES.md?ref=master
  proxy | 2022/08/22 10:18:51 [226] * authenticating github api request
  proxy | 2022/08/22 10:18:51 [226] 200 https://api.github.com:443/repos/jmcgeheeiv/pyfakefs/contents/CHANGES.md?ref=master
  proxy | 2022/08/22 10:18:51 [228] GET https://github.com:443/jmcgeheeiv/pyfakefs.git/info/refs?service=git-upload-pack
  proxy | 2022/08/22 10:18:51 [228] * authenticating git server request (host: github.com)
  proxy | 2022/08/22 10:18:51 [228] 200 https://github.com:443/jmcgeheeiv/pyfakefs.git/info/refs?service=git-upload-pack
  proxy | 2022/08/22 10:18:51 [230] GET https://api.github.com:443/repos/jmcgeheeiv/pyfakefs/commits?sha=v4.5.6
  proxy | 2022/08/22 10:18:51 [230] * authenticating github api request
  proxy | 2022/08/22 10:18:51 [230] 200 https://api.github.com:443/repos/jmcgeheeiv/pyfakefs/commits?sha=v4.5.6
  proxy | 2022/08/22 10:18:51 [232] GET https://api.github.com:443/repos/jmcgeheeiv/pyfakefs/commits?sha=v4.6.3
  proxy | 2022/08/22 10:18:51 [232] * authenticating github api request
  proxy | 2022/08/22 10:18:52 [232] 200 https://api.github.com:443/repos/jmcgeheeiv/pyfakefs/commits?sha=v4.6.3
  proxy | 2022/08/22 10:18:52 [234] GET https://api.github.com:443/repos/jmcgeheeiv/pyfakefs/commits?sha=v4.5.6
  proxy | 2022/08/22 10:18:52 [234] * authenticating github api request
  proxy | 2022/08/22 10:18:52 [234] 200 https://api.github.com:443/repos/jmcgeheeiv/pyfakefs/commits?sha=v4.5.6
  proxy | 2022/08/22 10:18:52 [236] GET https://api.github.com:443/repos/jmcgeheeiv/pyfakefs/commits?sha=v4.6.3
  proxy | 2022/08/22 10:18:52 [236] * authenticating github api request
  proxy | 2022/08/22 10:18:52 [236] 200 https://api.github.com:443/repos/jmcgeheeiv/pyfakefs/commits?sha=v4.6.3
  proxy | 2022/08/22 10:18:52 [238] GET https://api.github.com:443/repos/jmcgeheeiv/pyfakefs/commits?sha=v4.5.6
  proxy | 2022/08/22 10:18:52 [238] * authenticating github api request
  proxy | 2022/08/22 10:18:52 [238] 200 https://api.github.com:443/repos/jmcgeheeiv/pyfakefs/commits?sha=v4.5.6
  proxy | 2022/08/22 10:18:52 [240] GET https://api.github.com:443/repos/jmcgeheeiv/pyfakefs/commits?sha=v4.6.3
  proxy | 2022/08/22 10:18:52 [240] * authenticating github api request
  proxy | 2022/08/22 10:18:53 [240] 200 https://api.github.com:443/repos/jmcgeheeiv/pyfakefs/commits?sha=v4.6.3
updater | INFO <job_443473186> Submitting pyfakefs pull request for creation

Thanks, interesting - I don't know how this is determined (I thought it would be sufficient to remove Python 3.6 from setup.py). I won't have the time to check this today, will probably have a closer look tomorrow.

Thanks !

There is indeed still a python_requires='>=3.6' in setup.py - for some reason I completely overlooked that...
Will fix that in a moment.
The only change we made that is not Python 3.6 compatible was removing the support for stat_float_times, which was deprecated since Pyton 3.3 and hardly ever used - I think we can live with that without yanking the versions from PyPi. The main reason we removed it is that the support for Python 3.6 in the CI and other tools is removed, so we cannot reliably test in anymore.
Thanks for the catch!


PPP advanced options cleared when interface settings are saved

Important notices
Before you add a new report, we ask you kindly to acknowledge the following:

[x] I have read the contributing guide lines at https://github.com/opnsense/core/blob/master/CONTRIBUTING.md
[x] I am convinced that my issue is new after having checked both open and closed issues at https://github.com/opnsense/core/issues?q=is%3Aissue

Describe the bug
Hi,
when a PPP interface is assigned it shows up as Interfaces->foo. When you open it, settings may be changed and saved.
If you do that, settings on the underlying interface in Interfaces->Point-to-Point->Devices->pppX->Edit->Show advanced options are cleared! They vanish from both the web interface and config.xml.
Thanks!
To Reproduce
Steps to reproduce the behavior:

Assign pppX to interface foo
Go to Interfaces->Point-to-Point->Devices->pppX->Edit->Show advanced options
Set some stuff, e.g. SIM PIN or Init String, Save
Go to Interfaces->foo, press Save, then Apply
Go back to Interfaces->Point-to-Point->Devices->pppX->Edit->Show advanced options
Observe SIM PIN and Init String having been cleared
Open config.xml, observe <simpin> and <initstr> also missing

Expected behavior
Not discarding settings
Describe alternatives you considered

Screenshots

Relevant log files

Additional context

Environment
OPNsense 22.7.7 (amd64, OpenSSL).
APU 2D4

should be fixed with https://github.com/opnsense/core/commit/0ae0c2fc9307d89c449a61605a1af50e35c54fdd

Speedy bugfixing on a weekend? You guys are something else :) Thanks!


feat: add support for region comments

[ ] Because this PR includes a bug fix, relevant tests have been included.
[x] Because this PR includes a new feature, the change was previously discussed on an Issue or with someone from the team.
[ ] I didn't do anything of this.

Overview
This PR introduces support for region comments within Solidity .sol files previously mentioned in https://github.com/NomicFoundation/hardhat-vscode/issues/452, addressing the issue where developers were seeking the ability to organize code into collapsible sections for improved readability and navigation.
Changes

Modified the Solidity language configuration file to recognize the //#region and //#endregion patterns.

Implementation Details
Region comments are implemented by modifying the Solidity language grammar to include start and end region markers. The pattern follows the typical convention of //#region and //#endregion which is familiar to developers from other programming languages.
//#region ExampleRegion

// Your Solidity code here

//#endregion ExampleRegion

The language configuration now includes logic to parse these markers and translate them into foldable regions within VS Code.
Screenshots
Included are screenshots demonstrating the collapsible regions in action within a Solidity file.

How to test this feature

Check out this PR and follow the instructions in CONTRIBUTING.md#running-locally to run it locally.
Open a .sol file in VS Code.
Insert //#region and //#endregion comments around the code you wish to collapse.
Verify that you can collapse and expand the region as expected.

@Xanewok can we get some support on this feat? It would be great to have for navigating large contracts and can prevent a screen-split if you're working on, for example, public functions and their errors or events.

I'd be open to it; I thought this is a Microsoft/C#-ism but it seems to be ubiquitously supported in languages like Go (https://github.com/microsoft/vscode/pull/69899), Python (https://github.com/microsoft/vscode-python/issues/33) and C++, C#, TS etc.
Ideally:

it should probably be supported out of box in the VSCode at this point with a way to opt-out for specific languages
or one should use a dedicated extension for this https://marketplace.visualstudio.com/items?itemName=maptz.regionfolder

However, since this is such a small addition, I think it's more beneficial to have it rather than the other way around, especially if users will be migrating from the existing Juan Blanco's extension that supports it.
@kanej what do you think?


Monitor Typings Acqusition Events in TS Completion Item Provider

Monitors the status of typings acqusition from TS. If we are acquiring typings, in the TypeScript completion item provider, return an error result that informs the user that the results are incomplete.
Typings acqusition is currently capped at 30 seconds per typings install event so that we don't block intellisense forever if something goes wrong.

lgtm

@jrieken How do you want to coordinate checking in this work? My understand is that we will need to do work on the VSCode completion item provide to surface these rejections messages in the UI. Will rejecting promises on the TS side before the VSCode work is complete cause any issues?

Will rejecting promises on the TS side before the VSCode work is complete cause any issues?

Nope. Apart from a console message things will work as they used to. Later, I will add proper handling of well-known errors


repeat http download with range support; context propagate

This PR modifies:

context propagation into ExecCmd to handle cancel event
add retry into get ExecCmd (with Range headers if supported to continue download)

Signed-off-by: Petr Fedchenkov<EMAIL_ADDRESS>

LGTM structurally to me but I'd like to get @eriknordmark opinion as well. However, even before that -- can you please split this into two commits: one introducing the changes and the other one vendoring the changes into pillar.

Done

Oh, and any chance you can somehow add a test for this?

For now I testing it manually with tc, but will think about adding it to Eden

Thanks @giggsoff -- as for tests, can't you add them here https://github.com/lf-edge/eve/tree/master/libs/zedUpload#testing ?

Thanks @giggsoff -- as for tests, can't you add them here https://github.com/lf-edge/eve/tree/master/libs/zedUpload#testing ?

Done. I implement some kind of unstable TCP proxy which discards bytes for some period of time.

I put novel inactivityTimeout timer, which fires cancel of request context in case of no activity in download and issue retry.