Manifest 2

Does the latest version support Manifest 2?
Thanks

Yes, ublock origin still works for me after updating.

It definitively does and will continue to do so, it even states so in the projects README.

Thanks...
What is the syms download?

Those are for debugging purposes, not of any interest to 99.9% of users.


Very small bug was stopping me from requiring CoffeeScriptParser.

Looks like something unspecified which used to work with CS 1.0, then
turned into something unspecified which doesn't work with CS 1.2. CS is
shock-full of these, that's one of the reasons why I really want a properly
specified grammar. I'll pull your merge ASAP.
On Thu, Dec 22, 2011 at 12:46 PM, Anand Patil <
<EMAIL_ADDRESS>
wrote:

You can merge this Pull Request by running:
git pull https://github.com/apatil/parsec-coffee-script master
Or you can view, comment on it, or merge it online at:
https://github.com/fab13n/parsec-coffee-script/pull/1
-- Commit Summary --

Tiny bug

-- File Changes --
M src/CoffeeScriptParser.coffee (4)
-- Patch Links --
https://github.com/fab13n/parsec-coffee-script/pull/1.patch
https://github.com/fab13n/parsec-coffee-script/pull/1.diff

Reply to this email directly or view it on GitHub:
https://github.com/fab13n/parsec-coffee-script/pull/1

--
Fabien Fleutot
+---
| 33 chemin de Mange-Pommes
| 31520 Ramonville Saint-Agne -- France
| mobile: +33 6 28 06 09 97
| office: +33 5 61 00 06 49
| home: +33 5 61 75 05 67


add initial capz based cluster creation steps

What does this PR do?
add some documentation on how to create a workload cluster on CAPZ
What does it look like?
(If this is more than a textual change, a screenshot can help in some cases to speed up the review process.)
Any background context you can provide?
(Please link public issues or summarize if not public.)
towards https://github.com/giantswarm/roadmap/issues/2013
What is needed from the reviewers?
Have you maintained the front matter?
(Please bump the last_review_date in case this qualifies as a review for an entire page. Provide user_questions which should be answered in the page. Provide a meaningful description.)

@bavarianbidi opsctl is mentioned here. But customers do not have access to opsctl. Can you replace this with kubectl gs login?

@teemow done with https://github.com/giantswarm/docs/pull/1805


torch version and xformers install

Thanks for sharing this work! I would like to ask if the torch version needs to be 1.12.0+ when training, since xformer relies on 1.12.0+. However, torch version in README is 1.10.2.

No, as said in our doc, we used torch 1.10.2.
BTW, if you have problems with xformers, please ignore the package. It is totally optional as said in the readme.


Fix install instructions

The script is not POSIX compliant as it uses things like echo -e

Wow, this was fast. Thanks for the pull request, merged.

You might also need to handle updating the global theme as it breaks when it's already installed, as it should use kpackagetool5 -u instead of kpackagetool5 -i

Yeah, we're not too sure about updating yet, I'll try and figure it out though.


Bump pion/dtls

pion/dtls verifies certificates by default now. Disable verification
since WebRTC uses self-signed
Relates to pion/dtls#81

Codecov Report

Merging #757 into master will increase coverage by 0.1%.
The diff coverage is 100%.

@@           Coverage Diff            @@
##           master    #757     +/-   ##
========================================
+ Coverage   76.59%   76.7%   +0.1%
========================================
  Files          58      58
  Lines        4038    4039      +1
========================================
+ Hits         3093    3098      +5
+ Misses        690     685      -5
- Partials      255     256      +1

Impacted Files
Coverage Δ

dtlstransport.go
68.02% <100%> (+1.35%)
:arrow_up:

internal/mux/endpoint.go
62.96% <0%> (+7.4%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2f4049b...0d4bfea. Read the comment docs.

@daenney you are fast :)
thank you so much for the quick reviews!


Support AWS preparing/cleanup for Submariner

Initial support for AWS cloud preparation and cleanup.
For easier review the prepare and cleanup are in different commits and can be reviewed in an iterative manner
Signed-off-by: Mike Kolesnik<EMAIL_ADDRESS>

/cc @skeeey @zhiweiyin318 @qiujian16

It seems that there's generally a consensus on the API, and follow up PRs address some other issues and concerns.
I suggest that, if we're all fine with the API, we can start merging the PRs and address any further issues that might pop up in follow ups?
/cc @skeeey @zhiweiyin318 @qiujian16

I suggest that, if we're all fine with the API, we can start merging the PRs and address any further issues that might pop up in follow ups?

that would be good then we can start adding linting and other GHAs.

Based on the comments and code I +1'ed it, @qiujian16 @skeeey does github let you vote?

+1 from me, thanks!


Structure files

Describe the bug
The project files are not properly arranged.
To Reproduce
Steps to reproduce the behavior:

Go to vbay repo
See error

Expected behavior
Separate all the html and css files into different folders.

Hey, Can I would like to work on this issue can you assign this issue to me?

@Bhavya1403  can i also work on this

CAN YOU ASSIGN THIS TO ME


form is throwing an error in react native

Describe the bug
When following the documentation I received the error: Invariant Violation: View config getter callback for component form must be a function (received undefined). Make sure to start component names with a capital letter.
When I downgrade the library to 0.13.5 and use <form.Provider> The error resolves.
Am I doing something wrong?
Your minimal, reproducible example
https://snack.expo.dev/WRkKekvP4XXMTuUBo1FUy
Steps to reproduce
Start the app and the error will show
Expected behavior
As a user I expected the page to load but it currently does not.
How often does this bug happen?
Every time
Screenshots or Videos
No response
Platform

RN Expo

TanStack Form adapter
None
TanStack Form version
5.22.2
TypeScript version
No response
Additional context
No response

Oh I see what's wrong. Remove <form>. That's only for HTML, which is not present in React Native

Then this error shows up.  Error: You are trying to use the form API outside of a form!

Worked. Thank you.


Sylt docs

This is the start of the new Sylt documentation.

Some feedback that got lost:

The code color scheme should have the sylt-red somewhere, maybe keywords?
Maybe don't make primary, secondary and terniary color the SAME color value?


Add github action

Which component is your feature related to?
Other (Please describe below)
Feature Request
Would it be possible to add a github action that allows CI to download foundry version used project. The version could be found via the scarb.toml dependencies or a seperate file.

https://github.com/foundry-rs/setup-snfoundry
It is almost ready to be published


Add Undo/Redo support in the viewer

What

Closes https://github.com/rerun-io/rerun/issues/3135
Proceeded by https://github.com/rerun-io/rerun/pull/7602
Proceeded by https://github.com/rerun-io/rerun/pull/7603

This PR implements Undo and Redo for any edit to the active blueprint.
https://github.com/user-attachments/assets/05018729-f01e-42f4-a84f-b48dbf31b060
Implementation
This implements undo/redo by editing the "time cursor" for the blueprint timeline. Undo moves it backwards, redo forwards. When doing an action, all redo history is erased from the store with a new ChunkStore::drop_time_range function.
TODO
Closing a space-view and hitting undo fails to restore the space-view, and instead results in:

[WARN  re_blueprint_tree::blueprint_tree] Bug: asked to show a UI for a space view that doesn't exist
[DEBUG egui_tiles::tiles] Failed to find tile #8930786982270384173 during simplify

The reason are these lines of code:
https://github.com/rerun-io/rerun/blob/c599b565e7a35be30e302ee256c1521a0e1a796f/crates/viewer/re_viewport_blueprint/src/container.rs#L338-L343
https://github.com/rerun-io/rerun/blob/c599b565e7a35be30e302ee256c1521a0e1a796f/crates/viewer/re_viewport_blueprint/src/space_view.rs#L311-L316
When clearing a container or blueprint, the entity is dropped from the store.
Just removing these lines fixes undo, but creates a problem of accumulating garbage, potentially wasting RAM as the blueprint grows (especially for users with thousands of entities).
Me and @jleibs came up with a very nice solution to this though:

[x] Remove the DropEntity calls above. Just keep the entities, but don't reference them
[x] Remove the GC flag that protects at least 1 copy of each entity
[x] Add a GC flag that protects everything newer than a certain timepoint (make sure we have e.g. 100 undo points)

https://github.com/rerun-io/rerun/pull/7603

[ ] Optional optimization: Add a EntityDb::clear_index to remove references to components/entities that have no data (have all been GCed)
[ ] Optional optimization: Update this code to not walk the entity tree, but recursively collect entities from the root down

Checklist

[x] I have read and agree to Contributor Guide and the Code of Conduct
[x] I've included a screenshot or gif (if applicable)
[ ] I have tested the web demo (if applicable):

Using examples from latest main build: rerun.io/viewer
Using full set of examples from nightly build: rerun.io/viewer

[x] The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
[x] If applicable, add a new check to the release checklist!
[x] If have noted any breaking changes to the log API in CHANGELOG.md and the migration guide

PR Build Summary
Recent benchmark results
Wasm size tracking

To run all checks from main, comment on the PR with @rerun-bot full-check.

This is blocked by:

https://github.com/rerun-io/rerun/issues/8056


At

Android Open Source Projects https://p.codekk.com/
Share From App: Dev Tools(Android Developer Tools)

Looks like this was created by accident, closing. If needed, feel free to reopen with more details, thank you!


Consumer is getting disconnected even when heartbeat is getting sent regularly

Describe the bug
Consumer instance gets disconnected even when the heartbeat is sent every 5 sec and also when a message gets processed. But somehow consumer gets disconnected (sessionTimeout is 40 secs). Found no anomaly in broker metrics and logs. Sometimes also getting the logs broker closed the connection. Not able to debug the issue, need help in debugging.
Expected behavior
If the heartbeat is getting sent and there is no issue from the broker side, the consumer should not fail at failIfNotConnected.
Observed behavior
Consumer instance gets disconnected even when the heartbeat is sent every 5 sec and also when a message gets processed. But somehow consumer gets disconnected (sessionTimeout is 40 secs). Found no anomaly in broker metrics and logs. Sometimes also getting the logs broker closes the connection. Not able to debug the issue, need help in debugging.
Environment:

OS: ubuntu (docker)
KafkaJS version: v1.16.0
Kafka version 3.1.0
NodeJS version v14.18.0

Additional context
Messages are not consumed right away, with each message, handler we get the messages, store them in the queue then process them at a slower rate.

How do you ensure the heartbeat is sent every 5 seconds?


Properly assign issues from issue templates

Update our issue templates so the course-specific issues stop getting assigned to @cansavvy :)
Propogate https://github.com/jhudsl/DaSL_Course_Template_Bookdown/pull/320 into this repo

Closed by #119


Permission denied

Cant get this to work at all:
Im trying to return running containers inside of a container ruing php, apache and this library.
<?
use Docker\Docker;
$docker = new Docker();
$containers = $docker->getContainerManager()->findAll();
?>

[error] [client <IP_ADDRESS>] PHP Fatal error:  Uncaught exception 'Http\\Client\\Exception\\NetworkException' with message 'Permission denied' in /var/www/vendor/php-http/socket-client/src/Client.php:112\nStack trace:\n#0 /var/www/vendor/php-http/socket-client/src/Client.php(80): Http\\Client\\Socket\\Client->createSocket(Object(GuzzleHttp\\Psr7\\Request), 'unix:///var/run...', false)\n#1 /var/www/vendor/php-http/client-common/src/HttpClientDecorator.php(27): Http\\Client\\Socket\\Client->sendRequest(Object(GuzzleHttp\\Psr7\\Request))\n#2 /var/www/vendor/php-http/client-common/src/PluginClient.php(81): Http\\Client\\Common\\EmulatedHttpAsyncClient->sendRequest(Object(GuzzleHttp\\Psr7\\Request))\n#3 /var/www/vendor/php-http/plugins/src/DecoderPlugin.php(67): Http\\Client\\Common\\PluginClient->Http\\Client\\Common\\{closure}(Object(GuzzleHttp\\Psr7\\Request))\n#4 /var/www/vendor/php-http/client-common/src/PluginClient.php(156): Http\\Client\\Plugin\\DecoderPlugin->handleRequest(Object(GuzzleHttp\\Psr7\\Request), Object(Closure), Object(Closure))\n#5 /var/www/vendor/php-http/plugins/src/Content in /var/www/vendor/php-http/socket-client/src/Client.php on line 112

This tells me that is some thing to do with uids or gids.
I have added docker group to the container gid 2000 and www-data has a gid of 33.
On my linux vm the docker groups guid is 2000 and www-data has an gid of 33.
Running ubuntu 16 tls as vm with docker installed and container created with:
sudo docker run -d --restart=always -p 8040:80 --name site -v /var/www/site/:/var/www/ -v /root/_dockerlogs/site/:/var/log/apache2 -v /var/run.docker.sock:/var/run/docker.sock cfd44bc6f9fb

I have now tied to add my user to docker group in VM. I thought docker group should have access to the docker socket but has not and probably my problem.
How do I then solve this problem and use this library?

-v /var/run.docker.sock:/var/run/docker.so"c"k ?

This was just a typo in the issue

-v /var/run.docker.sock:/var/run/docker.so"c"k ?

Your user inside the vm (then the www-data) should be attached to the docker group gid of the host (which is 2000), so you should normally execute this command inside your VM :
usermod -aG docker www-data

This i have already done from inside and outside the docker container.
usermod -aG docker www-data
cat /etc/group
...
docker:x:2000:www-data
...

Can you show the info about cat /etc/group | grep docker inside and outside of container

Its the same sorry i think i found and fixed the issue:
-v /var/run.docker.sock:/var/run/docker.sock

/var/run.docker.sock should be /var/run/docker/sock a mistake from my side.
Thanks for the response!

Glad you find a solution


Cant Extract comment

Used --comments to extract. it is showing invalid syntax

It worked for myself. Can you attach a screenshot?


Not being able to choose Data in item-template

Somehow the highlighted code is not working as it should. I'm using ternary operator for choosing the Data for item-template i.e., if ensemble.storage.followSymbols array is empty, then use api result getSymbols.body.symbol else use ensemble.storage.followSymbols

I have tried console logging in onLoad of this screen

ensemble.storage.followSymbols               returns []
ensemble.storage.followSymbols.length    returns 0

This is how I'm initializing followSymbols array:
Global: |
  //@code
  if (ensemble.storage.followSymbols == null) {
    ensemble.storage.followSymbols = []
  }

link for the screen: (stockline app)
https://studio.ensembleui.com/app/PqiJYbUHUb0gGeiKqBC2/screen/cGiKcKKqqW3rKt8vAcbE

I'll check it out first

link for the screen: (stockline app)
https://studio.ensembleui.com/app/PqiJYbUHUb0gGeiKqBC2/screen/cGiKcKKqqW3rKt8vAcbE

this was fixed, please check again and reopen if needed


Probe

These are changes to make the blog your own. Please make these changes on a fork, not on a pull request. Thanks!

Thank you, this is my first attempt at git. I'm a little messed up, ups.


Error while training pose refiner.

I executed the train.py file. Training of correspondence block ran smoothly, but during training of pose refiner I am getting this error-
------ Started Initial pose estimation ------
0/2370 finished!
1000/2370 finished!
2000/2370 finished!
Number of instances where PnP couldn't be used:  352
------ Finished Initial pose estimation -----
----- Started creating inputs for DL based pose refinement ------
0/2370 finished!
/content/DPOD/create_renderings.py:31: RuntimeWarning: overflow encountered in true_divide
  coord_2D = homogenous_2D[:2, :] / homogenous_2D[2, :]
1000/2370 finished!
2000/2370 finished!
Number of outliers:  29
----- Finished creating inputs for DL based pose refinement
----- Started training DL based pose refiner ------
Downloading: "https://download.pytorch.org/models/resnet18-5c106cde.pth" to /root/.cache/torch/checkpoints/resnet18-5c106cde.pth
100% 44.7M/44.7M [00:00<00:00, 309MB/s]
----- Epoch Number:  1 --------
Traceback (most recent call last):
  File "train.py", line 82, in <module>
    train_pose_refinement(root_dir, classes, epochs=10)
  File "/content/DPOD/pose_refinement.py", line 147, in train_pose_refinement
    xy, z, rot = pose_refiner(image, rendered, pred_pose, batch_size)
  File "/usr/local/lib/python3.6/dist-packages/torch/nn/modules/module.py", line 550, in __call__
    result = self.forward(*input, **kwargs)
  File "/content/DPOD/pose_refiner_architecture.py", line 63, in forward
    z = self.fc_zhead(f)
  File "/usr/local/lib/python3.6/dist-packages/torch/nn/modules/module.py", line 550, in __call__
    result = self.forward(*input, **kwargs)
  File "/usr/local/lib/python3.6/dist-packages/torch/nn/modules/container.py", line 100, in forward
    input = module(input)
  File "/usr/local/lib/python3.6/dist-packages/torch/nn/modules/module.py", line 550, in __call__
    result = self.forward(*input, **kwargs)
  File "/usr/local/lib/python3.6/dist-packages/torch/nn/modules/linear.py", line 87, in forward
    return F.linear(input, self.weight, self.bias)
  File "/usr/local/lib/python3.6/dist-packages/torch/nn/functional.py", line 1610, in linear
    ret = torch.addmm(bias, input, weight.t())
RuntimeError: size mismatch, m1: [4 x 256], m2: [512 x 256] at /pytorch/aten/src/THC/generic/THCTensorMathBlas.cu:283

I didn't made any changes in the code. Can you please help me with this error.

I never got this error before. Do you mind training the pose refiner block again?
You can comment out the all lines before 76 to check if its trains properly

I trained it again but I am facing the same issue. Btw I am using google collab. Does it have to do something with the error?

I can't speak for colab but I used Deepnote. You can get a free gpu by requesting one


Figure out what to do about wasm features

binaryen can be configured to work with post-mvp wasm features. At some point we probably need to support them in the API.

We need to do this.
In the high level API:

Add a Feature enum that contains all the features from C++, similar to Pass.
Add a Features enum:

enum Features {
    Default,
    MvpOnly,
    All,
    Custom {
        enabled: HashSet<Feature>,
        disabled: HashSet<Fetature>,
    }
}

Add OptimizationOptions field features of type Features.
Add enable_feature(Feature) and disable_feature(Feature) builder methods

these will set the features field to Custom

Add mvp_features_only and all_features builder methods.
In the run method translate these to the base API and set the enabled/disabled features on the module

Base API and shims:

Add a wrapper shim for FeatureSet containing an inner FeatureSet
Add a newFeatureSet constructor that returns a unique_ptr to FeatureSet::MVP
Add bindings for setMVP and setAll.
Add bindings for set
Add Feature c-like enum that exactly matches binaryen's FeatureSet::Feature enum
Add shim method Module::applyFeatures that takes the enabled and disabled feature sets and does the same thing as OptimizationOptions.applyFeatures.

Tests:

Test that base Feature enum has same values as C++ enums

done


drills enchanted with silk touch do not drop blocks properly

Minecraft v1.20.1
Fabric v0.16.9 (loader 1.0.1)
Installed Mods:

Fabric API v0.92.2
Create Fabric v0.5.1-j-build.1631
Create Enchantable Machinery v2.8.7
EMI v1.1.18
Fabric Language Kotlin v1.12.3
Mod Menu v7.2.2

Drills enchanted with Silk Touch do not drop the original blocks when broken, instead behaving as unenchanted drills. This behavior is correct in v2.8.6, but not in v2.8.7. Only the mods listed above were installed in a creative test world, so "chunk protection" mods cannot be causing this issue.

Thank you for your report!
I will fix it in the next version.


Added dotnetcore sdk agent

I am creating this pull request because the coreruntime image we created from the dockerfile did not work for us when used as the image for one of our container templates.  When using the coreruntime image we received the following errors:

no file or directory for dotnet
scm was not able to complete due to git and ssh not being present in the image

For reference, we are trying create container templates to be used with the kubernetes-plugin
If I am using the coreruntime image or the container/pod template incorrectly please let me know. I followed the plugin documentation to configure the template and the pipeline.

We already have a dotnet core 3.1 image. I think it would be better to fixup the existing image rather than create a new one.

Change has been pushed.
We would like to continue using trusted images from the Jenkins Docker repositories.  Do you know if/when you guys will be able to create this image and push it to docker hub?  Thanks in advance.

We are working on getting more people access to dockerhub to create repos and such to reduce the bus factor. Until then, it will mainly be up to the schedule of those who do have access.

Image is published now: https://hub.docker.com/r/jenkins/jnlp-agent-coresdk


multi handle range select?

can this support multiple handles to select a specific range?

you mean two handles for a range selection?

@wangzuo two, or perhaps more. like https://mpowaga.github.io/react-slider/

maybe react-slider is a better choice for you?

lol. right on

:ok_hand:


[FEATURE REQUEST] Default Scanning Settings (Mode, Enhance, Whitepaper, Color, Brightness, Contrast)

Is your feature request related to a problem? Please describe.
Each time I start a scan, must change the settings to my favorites:

Tick Image "Enhance" and "Color" (or Whitepaper if desired).
Decrease "Brightness", increase "Contrast".
Change the mode to BW (okay, I prefer the normal mode, but I added this for a clear problem description)

Describe the solution you'd like
It would be nice if the app would simply "remember" my previos settings across multiple scanns.
Alternativeley, the default settings could be configured in the app settings.
Describe alternatives you've considered
Configure the settings after starting each scan.

@CheariX thanks for the request. You can edit default scanning settings either from the Camera/settings or from Settings/operations.
Those settings are used for Camera scan documents, but also for imported from PDF/images

Awesome. Thank you for this super quick integration!
Unfortunately, I get some error when I try to open these settings (either via settings/operations or via camera/settings):

Would it also make sense to include a setting for “automatically enable OCR"?

@CheariX really sorry about that. Will fix today!

@CheariX really sorry about that. Will fix today!

No worries. Thank you for fixing it.

About OCR will think about it. What bugs me is that then image processing would get really long

True, that was also what raised my concerns. Maybe if it is a setting with an appropriate message/warning, it could be okay.
It also depends on the device's power. It could be okay for some users but not for others.
Maybe it would be better if the processing took place in the background and just showed a little indicator in some corner instead of the current popup. However, this would be more than a simple change, I guess...

@CheariX should be fixed in latest i just released. I looked into the OCR part.

@CheariX should be fixed in latest i just released.

Unfortunately, I still get the same error as shown above.
I just tried to reset/reinstall the app but still, I get the same error.
I'm on version 1.11.2.

I looked into the OCR part.

Thank you. Appreciated.

@CheariX crazy i can't reproduce that...
Will look deeper

I just came across this issue too! #302

@farfromrefug I tried the new version via F-Droid, but the problem still exists.

@Comprehensive-Jason crazy i dont know where it comes from. I tied a fix as I can't reproduce it. Seems that wasnt it...
Will try again

Is it related to the settings you pick in the app? If so, could you add a feature to reset all settings to default, to see if that fixes the 'undefined' issue with the JSON?

It seems to be fixed now! @CheariX, can you check and verify?

Yes. The latest version fixed the issue.
Thank you again for taking care of it an integrating the feature so quickly.

Awesome. I will close #302 then.


Fix PvModel output calculation

The electric output calculation from PvModel seems to be partly wrong when assuming the elevationAngle as the angle between the horizontal plane / ground and the panel.
Assesment so far:

Output of east-directed PVs are higher than expected values
Output of west-directed PVs are lower than expected values
elevationAngle takes all values, documentation gives just the interval from 0 to 90°
Output of west-directed PVs with elevationAngle between 360° to 270° seems to be approx what would be expected for 0 - 90°

To do's:

[x] Do further investigations
[ ] Find solution
[ ] Extend test methods

Result of further investigations:

Weather data that is not in ZonedDateTime will be handled as LocalDateTime even if it is originaly in UTC.
Given that the first daylight beams that reach a east-oriented PV panel based on the simulation time (e.g. 09:00 UTC) will be matched with weather data at 10:00 (LocalDateTime) since this is 09:00 UTC in case of daylight saving time (e.g. January) or matched with weather data at 11:00 (LocalDateTime) in e.g. June.
In that case the production of east-oriented PV panels will be overestimated since the beam intensity is wrong.
For west-oriented PV panels on the other hand, the last beams that could reach the panel from geometrical perspective are weak or even zero since the false weather data (one or two hours later) contains a lower or zero beam.

Solution:

Make ZonedDateTime mandatory in PSDM.


Fix catch of existing DB error from postgres

To avoid postgres:
vagrant@vagrant-ubuntu-trusty-64:/cloudcxo$ rake db:create RAILS_ENV=development
rake aborted!
ActiveRecord::StatementInvalid: PG::DuplicateDatabase: ERROR:  database "development" already exists
: CREATE DATABASE "development" ENCODING = 'utf8'
/home/vagrant/.bundler/ruby/2.3.0/gems/activerecord-5.0.2/lib/active_record/connection_adapters/postgresql/database_statements.rb:98:in `async_exec'
/home/vagrant/.bundler/ruby/2.3.0/gems/activerecord-5.0.2/lib/active_record/connection_adapters/postgresql/database_statements.rb:98:in `block in execute'
/home/vagrant/.bundler/ruby/2.3.0/gems/activerecord-5.0.2/lib/active_record/connection_adapters/abstract_adapter.rb:589:in `block in log'
/home/vagrant/.bundler/ruby/2.3.0/gems/activesupport-5.0.2/lib/active_support/notifications/instrumenter.rb:21:in `instrument'
/home/vagrant/.bundler/ruby/2.3.0/gems/activerecord-5.0.2/lib/active_record/connection_adapters/abstract_adapter.rb:583:in `log'
/home/vagrant/.bundler/ruby/2.3.0/gems/activerecord-5.0.2/lib/active_record/connection_adapters/postgresql/database_statements.rb:97:in `execute'
/home/vagrant/.bundler/ruby/2.3.0/gems/activerecord-5.0.2/lib/active_record/connection_adapters/postgresql/schema_statements.rb:62:in `create_database'
/home/vagrant/.bundler/ruby/2.3.0/gems/active_record_shards-3.9.0/lib/active_record_shards/tasks.rb:40:in `block (3 levels) in <top (required)>'
/home/vagrant/.bundler/ruby/2.3.0/gems/active_record_shards-3.9.0/lib/active_record_shards/tasks.rb:31:in `each'
/home/vagrant/.bundler/ruby/2.3.0/gems/active_record_shards-3.9.0/lib/active_record_shards/tasks.rb:31:in `block (2 levels) in <top (required)>'
/home/vagrant/.bundler/ruby/2.3.0/gems/rake-12.0.0/exe/rake:27:in `<top (required)>'

This should be backwards-compat. The postgres adaptor must give a different error message to MySQL when creating an already-existing database, which causes the db:create task to crash out without creating the shard databases.


Generate data for use by benchmarks

Need to be able to have a large amount of data loaded into dynamo to help with benchmark testing
Use a fake reach ID and load a lot of data for that reach. Then benchmark tests can query against this fake reach id.

7 times per 21 days across 3 years


Gap between the accuracy of paper reported and that of released model

Hi,
I test the released model TPS-ResNet-BiLSTM-Attn.pth (downloaded from https://drive.google.com/drive/folders/192UfE9agQUMNq6AgU3_E05_FcPZK4hyt), and found that

there exist gaps between the accuracy of paper reported and that of the released model. Details are
as follows:
.
The test script is as follows:
python -u test.py
--eval_data  data_lmdb_release/evaluation
--benchmark_all_eval
--saved_model  released/TPS-ResNet-BiLSTM-Attn.pth
--Transformation TPS
--FeatureExtraction ResNet
--SequenceModeling BiLSTM
--Prediction Attn
Can you explain it?  Thanks.

Hello,
The possible reasons are

as we said in the caption,

In the paper, we used PyTorch 0.4.1 at that time.
In this repository (= pretrained model version), we used PyTorch 1.1.0

Best.


License information missing

The repository is missing license information. LGPL? GPL? MIT?
Requesting contributors to update the license information.
Thanks--

Push. I would like to fork it to change it slightly for our needs. Please add a license :)
Thanks

Fixed!


Add cert-manager logo to readme

This matches the repo with others in the org
(see https://github.com/cert-manager/csi-driver/pull/80 for the reasons I've used the specific attributes)

@wallrj I think this needs an approval by either @JoshVanL or @munnerz - thanks for the review though!

/lgtm
/approve


Add Sbert, local, EmbeddingClient impl

EmbeddingClient implementation that computes, locally, sentence embeddings with SBERT transformers.
It can use any pre-trained sbert model, serialized into Open Neural Network Exchange (ONNX) format.
The Deep Java Library and the Microsoft ONNX Java Runtime libraries are used to run the ONNX models and compute the embeddings.

Replaced by: https://github.com/spring-projects-experimental/spring-ai/pull/70


Add absolute references to names

We track names for path access. We should also track allow some method to generate variables on the top level control of a group that tells parent controls to collect it. Here's the idiom i have in mind:
with Window('root') as w:
    with FillForm('ignoreme'):
          with HeaderForm("ignoremetoo")
                Button ("@important")

 w.important.command += do_something

but we'd keep existing behavior so w.important would be the same as
w.ignoreme.ignoremetoo.important

The alternative paradigm would be to add a 'find' command to all layouts which looked for a name in their children. Right now this works:
from mGui.gui import *

with Window(None) as test:
    with ColumnLayout(None):
        Button("fred")

test.show()
for item in test: print item
fred = [i for i in test if i.Key == 'fred'][0]

fred.label = 'found'

Too much work. it's easier to simply use vanilla python to hack property assignments like this.


[DNM] Bluetooth: Convert to new logger subsystem

Ongoing work to convert the Bluetooth subsystem to the new logger APIs.
Known issues:

Transient strings are not handled properly and may cause corrupted messages
bt_hex() needs to go away (relates to first item), in most cases replaced with LOG_HEXDUMP()
There's an initial draft of the monitor backend, but I haven't been able to make it work yet

@nordic-krch I just finished a first draft of subsys/bluetooth/host/monitor.c as a log backend. I haven't been able to make it work yet - could you perhaps take a quick look and see if there's something obviously wrong there? I did the following change to samples/bluetooth/peripheral/prj.conf to try to test it:
-CONFIG_BT_DEBUG_LOG=y
+CONFIG_BT_DEBUG_MONITOR=y
+CONFIG_UART_CONSOLE=n
+CONFIG_LOG_BACKEND_UART=n

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@e1e12ba). Click here to learn what that means.
The diff coverage is 20%.

@@            Coverage Diff            @@
##             master   #10264   +/-   ##
=========================================
  Coverage          ?    53.1%
=========================================
  Files             ?      215
  Lines             ?    26205
  Branches          ?     5646
=========================================
  Hits              ?    13915
  Misses            ?    10018
  Partials          ?     2272

Impacted Files
Coverage Δ

subsys/bluetooth/host/hci_core.c
2.47% <ø> (ø)

subsys/bluetooth/host/crypto.c
0% <ø> (ø)

subsys/bluetooth/common/log.c
0% <0%> (ø)

subsys/bluetooth/common/log.h
100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e1e12ba...5a90591. Read the comment docs.

There appears to be a lot more changes here outside of the logging. Is the intent to separate the other changes and have a logging only change made available at some point?

I've removed the DNM tag since this now builds successfully and the monitor back end works. Strings are also handled using log_strdup() however some bt_hex calls should probably still be converted to LOG_HEXDUMP(). I'd also like to rename all BT_* calls to corresponding LOG_* ones, however that may require waiting for a resolution for #10644 since e.g. BT_DBG and BT_ERR include the function name in the output.

looks like you missed a few samples/tests?
samples/bluetooth/hci_spi/prj.conf
samples/bluetooth/hci_spi/src/main.c
samples/bluetooth/hci_uart/src/main.c
samples/bluetooth/ipsp/prj.conf
samples/bluetooth/ipsp/prj_dbg.conf
samples/bluetooth/ipsp/prj_zep1656.conf
samples/bluetooth/ipsp/src/main.c
samples/boards/nrf52/mesh/onoff-app/prj.conf
tests/bluetooth/tester/src/bttester.c
tests/bluetooth/tester/src/bttester.h
tests/bluetooth/tester/src/gap.c
tests/bluetooth/tester/src/gatt.c
tests/bluetooth/tester/src/l2cap.c
tests/bluetooth/tester/src/mesh.c

looks like you missed a few samples/tests?

Yep, I was mainly focusing on the stack rather than sample apps and missed these. I'll work on getting them converted.

@nashif I've updated the apps now


feat: allow skipping of registry login command in verifyConditions

I need to push to artifactory which does not support the helm registry login command, but does work with helm push. With this new parameter I can disable the check.
Signed-off-by: Sjouke de Vries<EMAIL_ADDRESS>

why is verifyRegistryLogin called at all if skipRegistryLogin is true?

My bad, I am doing this besides my regular work. I have fixed the issue accordingly

I also don't use this anymore so I don't have a good setup to quickly test changes... and since there are 0 tests and no linting / other static type checks changing anything is really error prone. Need to be careful not to break things.


⚠ Bofrost.at has degraded performance

In c2de949, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 1242 ms

Resolved: Bofrost.at performance has improved in 32d5243.


Reflection and NMS updates, some fixes

I updated the Reflection code to work with the new mc versions. (Like 1.17,1.18)
The new versions already include the kyori adventure API so I had to relocate. (LOCALE error on startup)
And the commons-io library is not included in the old server versions.

lgtm, I will made some commit to fix minor issues, thanks for a lot for the contribution!


pkg/p2p(cdc), tests: disable flushing for MessageClient's UT

What problem does this PR solve?

Issue Number: close #4092
What is changed and how it works?

Disable flushing at intervals for MessageClient, as the clientBatchSender used in the unit test cases is a mock and it does not require a call to Flush to test the correctness of the code under testing.

Check List
Tests

Unit Test

Release note
None

/run-leak-tests

/run-leak-tests

Codecov Report

Merging #4091 (e8ef74d) into master (3873d39) will decrease coverage by 1.9252%.
The diff coverage is 66.7491%.

Flag
Coverage Δ

cdc
58.6288% <66.7491%> (+0.3922%)
:arrow_up:

dm
52.1994% <ø> (-3.8352%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.
@@               Coverage Diff                @@
##             master      #4091        +/-   ##
================================================
- Coverage   57.0741%   55.1489%   -1.9253%
================================================
  Files           478        486         +8
  Lines         56551      60061      +3510
================================================
+ Hits          32276      33123       +847
- Misses        20978      23572      +2594
- Partials       3297       3366        +69

/run-leak-tests

/merge

/run-dm-integration-test

/run-kafka-integration-test

/run-verify

/run-kafka-integration-test


Apply terraform 0.12upgrade

To make this module compatible with the new release of Terraform 0.12, I've applied terraform 0.12upgrade to this module and all those in the modules directory.

Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement
Learn more about why HashiCorp requires a CLA and what the CLA includes
Have you signed the CLA already but the status is still pending? Recheck it.

This still doesn't apply on my sample plan:
provider "aws" {
  access_key = "AKIAXNBZ6TADW4CSUSHU"
  secret_key = "APJwyAFR0pDoSJkuIVbCMsLAuS2mcDK7NfGcTew6"
  region     = "us-east-1"
}

module "consul" {
  source = "github.com/mustafashabib/terraform-aws-consul"

  num_servers = "3"
}

When I run
terraform apply
Showing the errors:
Error: Invalid value for module argument

  on .terraform/modules/consul/main.tf line 83, in module "consul_servers":
  83:   tags = [
  84:     {
  85:       key                 = "Environment"
  86:       value               = "development"
  87:       propagate_at_launch = true
  88:     },
  89:   ]

The given value is not suitable for child module variable "tags" defined at
.terraform/modules/consul/modules/consul-cluster/variables.tf:208,1-16:
element 0: string required.

Error: Incorrect attribute value type

  on .terraform/modules/consul/modules/consul-cluster/main.tf line 34, in resource "aws_autoscaling_group" "autoscaling_group":
  34:   tags = [

Inappropriate value for attribute "tags": element 2: map of string required.

Error: Invalid value for module argument

  on .terraform/modules/consul/modules/consul-cluster/main.tf line 164, in module "security_group_rules":
 164:   allowed_inbound_cidr_blocks          = [var.allowed_inbound_cidr_blocks]

The given value is not suitable for child module variable
"allowed_inbound_cidr_blocks" defined at
.terraform/modules/consul/modules/consul-security-group-rules/variables.tf:10,1-39:
element 0: string required.

Error: Invalid value for module argument

  on .terraform/modules/consul/modules/consul-cluster/main.tf line 164, in module "security_group_rules":
 164:   allowed_inbound_cidr_blocks          = [var.allowed_inbound_cidr_blocks]

The given value is not suitable for child module variable
"allowed_inbound_cidr_blocks" defined at
.terraform/modules/consul/modules/consul-security-group-rules/variables.tf:10,1-39:
element 0: string required.

Error: Invalid value for module argument

  on .terraform/modules/consul/modules/consul-security-group-rules/main.tf line 240, in module "client_security_group_rules":
 240:   allowed_inbound_security_group_ids   = [var.allowed_inbound_security_group_ids]

The given value is not suitable for child module variable
"allowed_inbound_security_group_ids" defined at
.terraform/modules/consul/modules/consul-client-security-group-rules/variables.tf:20,1-46:
element 0: string required.

Error: Invalid value for module argument

  on .terraform/modules/consul/modules/consul-security-group-rules/main.tf line 240, in module "client_security_group_rules":
 240:   allowed_inbound_security_group_ids   = [var.allowed_inbound_security_group_ids]

The given value is not suitable for child module variable
"allowed_inbound_security_group_ids" defined at
.terraform/modules/consul/modules/consul-client-security-group-rules/variables.tf:20,1-46:
element 0: string required.

This still doesn't apply on my sample plan:
provider "aws" {
  access_key = "KEY"
  secret_key = "SECRET"
  region     = "us-east-1"
}

module "consul" {
  source = "github.com/mustafashabib/terraform-aws-consul"

  num_servers = "3"
}

When I run
terraform apply
Showing the errors:
Error: Invalid value for module argument

  on .terraform/modules/consul/main.tf line 83, in module "consul_servers":
  83:   tags = [
  84:     {
  85:       key                 = "Environment"
  86:       value               = "development"
  87:       propagate_at_launch = true
  88:     },
  89:   ]

The given value is not suitable for child module variable "tags" defined at
.terraform/modules/consul/modules/consul-cluster/variables.tf:208,1-16:
element 0: string required.

Error: Incorrect attribute value type

  on .terraform/modules/consul/modules/consul-cluster/main.tf line 34, in resource "aws_autoscaling_group" "autoscaling_group":
  34:   tags = [

Inappropriate value for attribute "tags": element 2: map of string required.

Error: Invalid value for module argument

  on .terraform/modules/consul/modules/consul-cluster/main.tf line 164, in module "security_group_rules":
 164:   allowed_inbound_cidr_blocks          = [var.allowed_inbound_cidr_blocks]

The given value is not suitable for child module variable
"allowed_inbound_cidr_blocks" defined at
.terraform/modules/consul/modules/consul-security-group-rules/variables.tf:10,1-39:
element 0: string required.

Error: Invalid value for module argument

  on .terraform/modules/consul/modules/consul-cluster/main.tf line 164, in module "security_group_rules":
 164:   allowed_inbound_cidr_blocks          = [var.allowed_inbound_cidr_blocks]

The given value is not suitable for child module variable
"allowed_inbound_cidr_blocks" defined at
.terraform/modules/consul/modules/consul-security-group-rules/variables.tf:10,1-39:
element 0: string required.

Error: Invalid value for module argument

  on .terraform/modules/consul/modules/consul-security-group-rules/main.tf line 240, in module "client_security_group_rules":
 240:   allowed_inbound_security_group_ids   = [var.allowed_inbound_security_group_ids]

The given value is not suitable for child module variable
"allowed_inbound_security_group_ids" defined at
.terraform/modules/consul/modules/consul-client-security-group-rules/variables.tf:20,1-46:
element 0: string required.

Error: Invalid value for module argument

  on .terraform/modules/consul/modules/consul-security-group-rules/main.tf line 240, in module "client_security_group_rules":
 240:   allowed_inbound_security_group_ids   = [var.allowed_inbound_security_group_ids]

The given value is not suitable for child module variable
"allowed_inbound_security_group_ids" defined at
.terraform/modules/consul/modules/consul-client-security-group-rules/variables.tf:20,1-46:
element 0: string required.

Seems to apply correctly on a default example:
provider "aws" {
  access_key = "KEY"
  secret_key = "SECRET"
  region     = "us-east-1"
}

module "consul" {
  source = "github.com/mustafashabib/terraform-aws-consul"

  num_servers = "3"
}

When I run  terraform plan  (after terraform init)
Output is
terraform plan
Refreshing Terraform state in-memory prior to plan...
The refreshed state will be used to calculate this plan, but will not be
persisted to local or remote state storage.

module.consul.data.template_file.user_data_server: Refreshing state...
module.consul.data.template_file.user_data_client: Refreshing state...
module.consul.data.aws_ami.consul: Refreshing state...
module.consul.module.consul_servers.module.iam_policies.data.aws_iam_policy_document.auto_discover_cluster: Refreshing state...
module.consul.data.aws_region.current: Refreshing state...
module.consul.data.aws_vpc.default: Refreshing state...
module.consul.module.consul_servers.data.aws_iam_policy_document.instance_role: Refreshing state...
module.consul.module.consul_clients.module.iam_policies.data.aws_iam_policy_document.auto_discover_cluster: Refreshing state...
module.consul.module.consul_clients.data.aws_iam_policy_document.instance_role: Refreshing state...
module.consul.data.aws_subnet_ids.default: Refreshing state...

------------------------------------------------------------------------

An execution plan has been generated and is shown below.
Resource actions are indicated with the following symbols:
  + create

Terraform will perform the following actions:

  # module.consul.module.consul_clients.aws_autoscaling_group.autoscaling_group will be created
  + resource "aws_autoscaling_group" "autoscaling_group" {
      + arn                       = (known after apply)
      + availability_zones        = []
      + default_cooldown          = (known after apply)
      + desired_capacity          = 6
      + enabled_metrics           = []
      + force_delete              = false
      + health_check_grace_period = 300
      + health_check_type         = "EC2"
      + id                        = (known after apply)
      + launch_configuration      = (known after apply)
      + load_balancers            = (known after apply)
      + max_size                  = 6
      + metrics_granularity       = "1Minute"
      + min_size                  = 6
      + name                      = (known after apply)
      + name_prefix               = "consul-example-client"
      + protect_from_scale_in     = false
      + service_linked_role_arn   = (known after apply)
      + tags                      = [
          + {
              + "key"                 = "Name"
              + "propagate_at_launch" = "true"
              + "value"               = "consul-example-client"
            },
          + {
              + "key"                 = "consul-clients"
              + "propagate_at_launch" = "true"
              + "value"               = "consul-example"
            },
        ]
      + target_group_arns         = (known after apply)
      + termination_policies      = [
          + "Default",
        ]
      + vpc_zone_identifier       = [
          + "subnet-03148f39",
          + "subnet-65a12769",
          + "subnet-65ae1212",
          + "subnet-7d778e56",
          + "subnet-ccf89da9",
          + "subnet-de558a87",
        ]
      + wait_for_capacity_timeout = "10m"
    }

  # module.consul.module.consul_clients.aws_iam_instance_profile.instance_profile[0] will be created
  + resource "aws_iam_instance_profile" "instance_profile" {
      + arn         = (known after apply)
      + create_date = (known after apply)
      + id          = (known after apply)
      + name        = (known after apply)
      + name_prefix = "consul-example-client"
      + path        = "/"
      + role        = (known after apply)
      + roles       = (known after apply)
      + unique_id   = (known after apply)
    }

  # module.consul.module.consul_clients.aws_iam_role.instance_role[0] will be created
  + resource "aws_iam_role" "instance_role" {
      + arn                   = (known after apply)
      + assume_role_policy    = jsonencode(
            {
              + Statement = [
                  + {
                      + Action    = "sts:AssumeRole"
                      + Effect    = "Allow"
                      + Principal = {
                          + Service = "ec2.amazonaws.com"
                        }
                      + Sid       = ""
                    },
                ]
              + Version   = "2012-10-17"
            }
        )
      + create_date           = (known after apply)
      + force_detach_policies = false
      + id                    = (known after apply)
      + max_session_duration  = 3600
      + name                  = (known after apply)
      + name_prefix           = "consul-example-client"
      + path                  = "/"
      + unique_id             = (known after apply)
    }

  # module.consul.module.consul_clients.aws_launch_configuration.launch_configuration will be created
  + resource "aws_launch_configuration" "launch_configuration" {
      + associate_public_ip_address = false
      + ebs_optimized               = false
      + enable_monitoring           = true
      + iam_instance_profile        = (known after apply)
      + id                          = (known after apply)
      + image_id                    = "ami-0a9b5046374af8659"
      + instance_type               = "t2.micro"
      + key_name                    = (known after apply)
      + name                        = (known after apply)
      + name_prefix                 = "consul-example-client-"
      + security_groups             = (known after apply)
      + user_data                   = "97e031d0aa6d1e6b2cd1838301fbecde7751eefb"

      + ebs_block_device {
          + delete_on_termination = (known after apply)
          + device_name           = (known after apply)
          + encrypted             = (known after apply)
          + iops                  = (known after apply)
          + no_device             = (known after apply)
          + snapshot_id           = (known after apply)
          + volume_size           = (known after apply)
          + volume_type           = (known after apply)
        }

      + root_block_device {
          + delete_on_termination = true
          + iops                  = (known after apply)
          + volume_size           = 50
          + volume_type           = "standard"
        }
    }

  # module.consul.module.consul_clients.aws_security_group.lc_security_group will be created
  + resource "aws_security_group" "lc_security_group" {
      + arn                    = (known after apply)
      + description            = "Security group for the consul-example-client launch configuration"
      + egress                 = (known after apply)
      + id                     = (known after apply)
      + ingress                = (known after apply)
      + name                   = (known after apply)
      + name_prefix            = "consul-example-client"
      + owner_id               = (known after apply)
      + revoke_rules_on_delete = false
      + tags                   = {
          + "Name" = "consul-example-client"
        }
      + vpc_id                 = "vpc-6b2bb80e"
    }

  # module.consul.module.consul_clients.aws_security_group_rule.allow_all_outbound will be created
  + resource "aws_security_group_rule" "allow_all_outbound" {
      + cidr_blocks              = [
          + "<IP_ADDRESS>/0",
        ]
      + from_port                = 0
      + id                       = (known after apply)
      + protocol                 = "-1"
      + security_group_id        = (known after apply)
      + self                     = false
      + source_security_group_id = (known after apply)
      + to_port                  = 0
      + type                     = "egress"
    }

  # module.consul.module.consul_clients.aws_security_group_rule.allow_ssh_inbound[0] will be created
  + resource "aws_security_group_rule" "allow_ssh_inbound" {
      + cidr_blocks              = [
          + "<IP_ADDRESS>/0",
        ]
      + from_port                = 22
      + id                       = (known after apply)
      + protocol                 = "tcp"
      + security_group_id        = (known after apply)
      + self                     = false
      + source_security_group_id = (known after apply)
      + to_port                  = 22
      + type                     = "ingress"
    }

  # module.consul.module.consul_servers.aws_autoscaling_group.autoscaling_group will be created
  + resource "aws_autoscaling_group" "autoscaling_group" {
      + arn                       = (known after apply)
      + availability_zones        = []
      + default_cooldown          = (known after apply)
      + desired_capacity          = 3
      + enabled_metrics           = []
      + force_delete              = false
      + health_check_grace_period = 300
      + health_check_type         = "EC2"
      + id                        = (known after apply)
      + launch_configuration      = (known after apply)
      + load_balancers            = (known after apply)
      + max_size                  = 3
      + metrics_granularity       = "1Minute"
      + min_size                  = 3
      + name                      = (known after apply)
      + name_prefix               = "consul-example-server"
      + protect_from_scale_in     = false
      + service_linked_role_arn   = (known after apply)
      + tags                      = [
          + {
              + "key"                 = "Name"
              + "propagate_at_launch" = "true"
              + "value"               = "consul-example-server"
            },
          + {
              + "key"                 = "consul-servers"
              + "propagate_at_launch" = "true"
              + "value"               = "consul-example"
            },
          + {
              + "key"                 = "Environment"
              + "propagate_at_launch" = "true"
              + "value"               = "development"
            },
        ]
      + target_group_arns         = (known after apply)
      + termination_policies      = [
          + "Default",
        ]
      + vpc_zone_identifier       = [
          + "subnet-03148f39",
          + "subnet-65a12769",
          + "subnet-65ae1212",
          + "subnet-7d778e56",
          + "subnet-ccf89da9",
          + "subnet-de558a87",
        ]
      + wait_for_capacity_timeout = "10m"
    }

  # module.consul.module.consul_servers.aws_iam_instance_profile.instance_profile[0] will be created
  + resource "aws_iam_instance_profile" "instance_profile" {
      + arn         = (known after apply)
      + create_date = (known after apply)
      + id          = (known after apply)
      + name        = (known after apply)
      + name_prefix = "consul-example-server"
      + path        = "/"
      + role        = (known after apply)
      + roles       = (known after apply)
      + unique_id   = (known after apply)
    }

  # module.consul.module.consul_servers.aws_iam_role.instance_role[0] will be created
  + resource "aws_iam_role" "instance_role" {
      + arn                   = (known after apply)
      + assume_role_policy    = jsonencode(
            {
              + Statement = [
                  + {
                      + Action    = "sts:AssumeRole"
                      + Effect    = "Allow"
                      + Principal = {
                          + Service = "ec2.amazonaws.com"
                        }
                      + Sid       = ""
                    },
                ]
              + Version   = "2012-10-17"
            }
        )
      + create_date           = (known after apply)
      + force_detach_policies = false
      + id                    = (known after apply)
      + max_session_duration  = 3600
      + name                  = (known after apply)
      + name_prefix           = "consul-example-server"
      + path                  = "/"
      + unique_id             = (known after apply)
    }

  # module.consul.module.consul_servers.aws_launch_configuration.launch_configuration will be created
  + resource "aws_launch_configuration" "launch_configuration" {
      + associate_public_ip_address = false
      + ebs_optimized               = false
      + enable_monitoring           = true
      + iam_instance_profile        = (known after apply)
      + id                          = (known after apply)
      + image_id                    = "ami-0a9b5046374af8659"
      + instance_type               = "t2.micro"
      + key_name                    = (known after apply)
      + name                        = (known after apply)
      + name_prefix                 = "consul-example-server-"
      + security_groups             = (known after apply)
      + user_data                   = "bea44523b6e01d16013cc9699c268cc65005f72f"

      + ebs_block_device {
          + delete_on_termination = (known after apply)
          + device_name           = (known after apply)
          + encrypted             = (known after apply)
          + iops                  = (known after apply)
          + no_device             = (known after apply)
          + snapshot_id           = (known after apply)
          + volume_size           = (known after apply)
          + volume_type           = (known after apply)
        }

      + root_block_device {
          + delete_on_termination = true
          + iops                  = (known after apply)
          + volume_size           = 50
          + volume_type           = "standard"
        }
    }

  # module.consul.module.consul_servers.aws_security_group.lc_security_group will be created
  + resource "aws_security_group" "lc_security_group" {
      + arn                    = (known after apply)
      + description            = "Security group for the consul-example-server launch configuration"
      + egress                 = (known after apply)
      + id                     = (known after apply)
      + ingress                = (known after apply)
      + name                   = (known after apply)
      + name_prefix            = "consul-example-server"
      + owner_id               = (known after apply)
      + revoke_rules_on_delete = false
      + tags                   = {
          + "Name" = "consul-example-server"
        }
      + vpc_id                 = "vpc-6b2bb80e"
    }

  # module.consul.module.consul_servers.aws_security_group_rule.allow_all_outbound will be created
  + resource "aws_security_group_rule" "allow_all_outbound" {
      + cidr_blocks              = [
          + "<IP_ADDRESS>/0",
        ]
      + from_port                = 0
      + id                       = (known after apply)
      + protocol                 = "-1"
      + security_group_id        = (known after apply)
      + self                     = false
      + source_security_group_id = (known after apply)
      + to_port                  = 0
      + type                     = "egress"
    }

  # module.consul.module.consul_servers.aws_security_group_rule.allow_ssh_inbound[0] will be created
  + resource "aws_security_group_rule" "allow_ssh_inbound" {
      + cidr_blocks              = [
          + "<IP_ADDRESS>/0",
        ]
      + from_port                = 22
      + id                       = (known after apply)
      + protocol                 = "tcp"
      + security_group_id        = (known after apply)
      + self                     = false
      + source_security_group_id = (known after apply)
      + to_port                  = 22
      + type                     = "ingress"
    }

  # module.consul.module.consul_clients.module.iam_policies.aws_iam_role_policy.auto_discover_cluster[0] will be created
  + resource "aws_iam_role_policy" "auto_discover_cluster" {
      + id     = (known after apply)
      + name   = "auto-discover-cluster"
      + policy = jsonencode(
            {
              + Statement = [
                  + {
                      + Action   = [
                          + "ec2:DescribeTags",
                          + "ec2:DescribeInstances",
                          + "autoscaling:DescribeAutoScalingGroups",
                        ]
                      + Effect   = "Allow"
                      + Resource = "*"
                      + Sid      = ""
                    },
                ]
              + Version   = "2012-10-17"
            }
        )
      + role   = (known after apply)
    }

  # module.consul.module.consul_clients.module.security_group_rules.aws_security_group_rule.allow_cli_rpc_inbound[0] will be created
  + resource "aws_security_group_rule" "allow_cli_rpc_inbound" {
      + cidr_blocks              = [
          + "<IP_ADDRESS>/0",
        ]
      + from_port                = 8400
      + id                       = (known after apply)
      + protocol                 = "tcp"
      + security_group_id        = (known after apply)
      + self                     = false
      + source_security_group_id = (known after apply)
      + to_port                  = 8400
      + type                     = "ingress"
    }

  # module.consul.module.consul_clients.module.security_group_rules.aws_security_group_rule.allow_cli_rpc_inbound_from_self will be created
  + resource "aws_security_group_rule" "allow_cli_rpc_inbound_from_self" {
      + from_port                = 8400
      + id                       = (known after apply)
      + protocol                 = "tcp"
      + security_group_id        = (known after apply)
      + self                     = true
      + source_security_group_id = (known after apply)
      + to_port                  = 8400
      + type                     = "ingress"
    }

  # module.consul.module.consul_clients.module.security_group_rules.aws_security_group_rule.allow_dns_tcp_inbound[0] will be created
  + resource "aws_security_group_rule" "allow_dns_tcp_inbound" {
      + cidr_blocks              = [
          + "<IP_ADDRESS>/0",
        ]
      + from_port                = 8600
      + id                       = (known after apply)
      + protocol                 = "tcp"
      + security_group_id        = (known after apply)
      + self                     = false
      + source_security_group_id = (known after apply)
      + to_port                  = 8600
      + type                     = "ingress"
    }

  # module.consul.module.consul_clients.module.security_group_rules.aws_security_group_rule.allow_dns_tcp_inbound_from_self will be created
  + resource "aws_security_group_rule" "allow_dns_tcp_inbound_from_self" {
      + from_port                = 8600
      + id                       = (known after apply)
      + protocol                 = "tcp"
      + security_group_id        = (known after apply)
      + self                     = true
      + source_security_group_id = (known after apply)
      + to_port                  = 8600
      + type                     = "ingress"
    }

  # module.consul.module.consul_clients.module.security_group_rules.aws_security_group_rule.allow_dns_udp_inbound[0] will be created
  + resource "aws_security_group_rule" "allow_dns_udp_inbound" {
      + cidr_blocks              = [
          + "<IP_ADDRESS>/0",
        ]
      + from_port                = 8600
      + id                       = (known after apply)
      + protocol                 = "udp"
      + security_group_id        = (known after apply)
      + self                     = false
      + source_security_group_id = (known after apply)
      + to_port                  = 8600
      + type                     = "ingress"
    }

  # module.consul.module.consul_clients.module.security_group_rules.aws_security_group_rule.allow_dns_udp_inbound_from_self will be created
  + resource "aws_security_group_rule" "allow_dns_udp_inbound_from_self" {
      + from_port                = 8600
      + id                       = (known after apply)
      + protocol                 = "udp"
      + security_group_id        = (known after apply)
      + self                     = true
      + source_security_group_id = (known after apply)
      + to_port                  = 8600
      + type                     = "ingress"
    }

  # module.consul.module.consul_clients.module.security_group_rules.aws_security_group_rule.allow_http_api_inbound[0] will be created
  + resource "aws_security_group_rule" "allow_http_api_inbound" {
      + cidr_blocks              = [
          + "<IP_ADDRESS>/0",
        ]
      + from_port                = 8500
      + id                       = (known after apply)
      + protocol                 = "tcp"
      + security_group_id        = (known after apply)
      + self                     = false
      + source_security_group_id = (known after apply)
      + to_port                  = 8500
      + type                     = "ingress"
    }

  # module.consul.module.consul_clients.module.security_group_rules.aws_security_group_rule.allow_http_api_inbound_from_self will be created
  + resource "aws_security_group_rule" "allow_http_api_inbound_from_self" {
      + from_port                = 8500
      + id                       = (known after apply)
      + protocol                 = "tcp"
      + security_group_id        = (known after apply)
      + self                     = true
      + source_security_group_id = (known after apply)
      + to_port                  = 8500
      + type                     = "ingress"
    }

  # module.consul.module.consul_clients.module.security_group_rules.aws_security_group_rule.allow_serf_wan_tcp_inbound[0] will be created
  + resource "aws_security_group_rule" "allow_serf_wan_tcp_inbound" {
      + cidr_blocks              = [
          + "<IP_ADDRESS>/0",
        ]
      + from_port                = 8302
      + id                       = (known after apply)
      + protocol                 = "tcp"
      + security_group_id        = (known after apply)
      + self                     = false
      + source_security_group_id = (known after apply)
      + to_port                  = 8302
      + type                     = "ingress"
    }

  # module.consul.module.consul_clients.module.security_group_rules.aws_security_group_rule.allow_serf_wan_tcp_inbound_from_self will be created
  + resource "aws_security_group_rule" "allow_serf_wan_tcp_inbound_from_self" {
      + from_port                = 8302
      + id                       = (known after apply)
      + protocol                 = "tcp"
      + security_group_id        = (known after apply)
      + self                     = true
      + source_security_group_id = (known after apply)
      + to_port                  = 8302
      + type                     = "ingress"
    }

  # module.consul.module.consul_clients.module.security_group_rules.aws_security_group_rule.allow_serf_wan_udp_inbound[0] will be created
  + resource "aws_security_group_rule" "allow_serf_wan_udp_inbound" {
      + cidr_blocks              = [
          + "<IP_ADDRESS>/0",
        ]
      + from_port                = 8302
      + id                       = (known after apply)
      + protocol                 = "udp"
      + security_group_id        = (known after apply)
      + self                     = false
      + source_security_group_id = (known after apply)
      + to_port                  = 8302
      + type                     = "ingress"
    }

  # module.consul.module.consul_clients.module.security_group_rules.aws_security_group_rule.allow_serf_wan_udp_inbound_from_self will be created
  + resource "aws_security_group_rule" "allow_serf_wan_udp_inbound_from_self" {
      + from_port                = 8302
      + id                       = (known after apply)
      + protocol                 = "udp"
      + security_group_id        = (known after apply)
      + self                     = true
      + source_security_group_id = (known after apply)
      + to_port                  = 8302
      + type                     = "ingress"
    }

  # module.consul.module.consul_clients.module.security_group_rules.aws_security_group_rule.allow_server_rpc_inbound[0] will be created
  + resource "aws_security_group_rule" "allow_server_rpc_inbound" {
      + cidr_blocks              = [
          + "<IP_ADDRESS>/0",
        ]
      + from_port                = 8300
      + id                       = (known after apply)
      + protocol                 = "tcp"
      + security_group_id        = (known after apply)
      + self                     = false
      + source_security_group_id = (known after apply)
      + to_port                  = 8300
      + type                     = "ingress"
    }

  # module.consul.module.consul_clients.module.security_group_rules.aws_security_group_rule.allow_server_rpc_inbound_from_self will be created
  + resource "aws_security_group_rule" "allow_server_rpc_inbound_from_self" {
      + from_port                = 8300
      + id                       = (known after apply)
      + protocol                 = "tcp"
      + security_group_id        = (known after apply)
      + self                     = true
      + source_security_group_id = (known after apply)
      + to_port                  = 8300
      + type                     = "ingress"
    }

  # module.consul.module.consul_servers.module.iam_policies.aws_iam_role_policy.auto_discover_cluster[0] will be created
  + resource "aws_iam_role_policy" "auto_discover_cluster" {
      + id     = (known after apply)
      + name   = "auto-discover-cluster"
      + policy = jsonencode(
            {
              + Statement = [
                  + {
                      + Action   = [
                          + "ec2:DescribeTags",
                          + "ec2:DescribeInstances",
                          + "autoscaling:DescribeAutoScalingGroups",
                        ]
                      + Effect   = "Allow"
                      + Resource = "*"
                      + Sid      = ""
                    },
                ]
              + Version   = "2012-10-17"
            }
        )
      + role   = (known after apply)
    }

  # module.consul.module.consul_servers.module.security_group_rules.aws_security_group_rule.allow_cli_rpc_inbound[0] will be created
  + resource "aws_security_group_rule" "allow_cli_rpc_inbound" {
      + cidr_blocks              = [
          + "<IP_ADDRESS>/0",
        ]
      + from_port                = 8400
      + id                       = (known after apply)
      + protocol                 = "tcp"
      + security_group_id        = (known after apply)
      + self                     = false
      + source_security_group_id = (known after apply)
      + to_port                  = 8400
      + type                     = "ingress"
    }

  # module.consul.module.consul_servers.module.security_group_rules.aws_security_group_rule.allow_cli_rpc_inbound_from_self will be created
  + resource "aws_security_group_rule" "allow_cli_rpc_inbound_from_self" {
      + from_port                = 8400
      + id                       = (known after apply)
      + protocol                 = "tcp"
      + security_group_id        = (known after apply)
      + self                     = true
      + source_security_group_id = (known after apply)
      + to_port                  = 8400
      + type                     = "ingress"
    }

  # module.consul.module.consul_servers.module.security_group_rules.aws_security_group_rule.allow_dns_tcp_inbound[0] will be created
  + resource "aws_security_group_rule" "allow_dns_tcp_inbound" {
      + cidr_blocks              = [
          + "<IP_ADDRESS>/0",
        ]
      + from_port                = 8600
      + id                       = (known after apply)
      + protocol                 = "tcp"
      + security_group_id        = (known after apply)
      + self                     = false
      + source_security_group_id = (known after apply)
      + to_port                  = 8600
      + type                     = "ingress"
    }

  # module.consul.module.consul_servers.module.security_group_rules.aws_security_group_rule.allow_dns_tcp_inbound_from_self will be created
  + resource "aws_security_group_rule" "allow_dns_tcp_inbound_from_self" {
      + from_port                = 8600
      + id                       = (known after apply)
      + protocol                 = "tcp"
      + security_group_id        = (known after apply)
      + self                     = true
      + source_security_group_id = (known after apply)
      + to_port                  = 8600
      + type                     = "ingress"
    }

  # module.consul.module.consul_servers.module.security_group_rules.aws_security_group_rule.allow_dns_udp_inbound[0] will be created
  + resource "aws_security_group_rule" "allow_dns_udp_inbound" {
      + cidr_blocks              = [
          + "<IP_ADDRESS>/0",
        ]
      + from_port                = 8600
      + id                       = (known after apply)
      + protocol                 = "udp"
      + security_group_id        = (known after apply)
      + self                     = false
      + source_security_group_id = (known after apply)
      + to_port                  = 8600
      + type                     = "ingress"
    }

  # module.consul.module.consul_servers.module.security_group_rules.aws_security_group_rule.allow_dns_udp_inbound_from_self will be created
  + resource "aws_security_group_rule" "allow_dns_udp_inbound_from_self" {
      + from_port                = 8600
      + id                       = (known after apply)
      + protocol                 = "udp"
      + security_group_id        = (known after apply)
      + self                     = true
      + source_security_group_id = (known after apply)
      + to_port                  = 8600
      + type                     = "ingress"
    }

  # module.consul.module.consul_servers.module.security_group_rules.aws_security_group_rule.allow_http_api_inbound[0] will be created
  + resource "aws_security_group_rule" "allow_http_api_inbound" {
      + cidr_blocks              = [
          + "<IP_ADDRESS>/0",
        ]
      + from_port                = 8500
      + id                       = (known after apply)
      + protocol                 = "tcp"
      + security_group_id        = (known after apply)
      + self                     = false
      + source_security_group_id = (known after apply)
      + to_port                  = 8500
      + type                     = "ingress"
    }

  # module.consul.module.consul_servers.module.security_group_rules.aws_security_group_rule.allow_http_api_inbound_from_self will be created
  + resource "aws_security_group_rule" "allow_http_api_inbound_from_self" {
      + from_port                = 8500
      + id                       = (known after apply)
      + protocol                 = "tcp"
      + security_group_id        = (known after apply)
      + self                     = true
      + source_security_group_id = (known after apply)
      + to_port                  = 8500
      + type                     = "ingress"
    }

  # module.consul.module.consul_servers.module.security_group_rules.aws_security_group_rule.allow_serf_wan_tcp_inbound[0] will be created
  + resource "aws_security_group_rule" "allow_serf_wan_tcp_inbound" {
      + cidr_blocks              = [
          + "<IP_ADDRESS>/0",
        ]
      + from_port                = 8302
      + id                       = (known after apply)
      + protocol                 = "tcp"
      + security_group_id        = (known after apply)
      + self                     = false
      + source_security_group_id = (known after apply)
      + to_port                  = 8302
      + type                     = "ingress"
    }

  # module.consul.module.consul_servers.module.security_group_rules.aws_security_group_rule.allow_serf_wan_tcp_inbound_from_self will be created
  + resource "aws_security_group_rule" "allow_serf_wan_tcp_inbound_from_self" {
      + from_port                = 8302
      + id                       = (known after apply)
      + protocol                 = "tcp"
      + security_group_id        = (known after apply)
      + self                     = true
      + source_security_group_id = (known after apply)
      + to_port                  = 8302
      + type                     = "ingress"
    }

  # module.consul.module.consul_servers.module.security_group_rules.aws_security_group_rule.allow_serf_wan_udp_inbound[0] will be created
  + resource "aws_security_group_rule" "allow_serf_wan_udp_inbound" {
      + cidr_blocks              = [
          + "<IP_ADDRESS>/0",
        ]
      + from_port                = 8302
      + id                       = (known after apply)
      + protocol                 = "udp"
      + security_group_id        = (known after apply)
      + self                     = false
      + source_security_group_id = (known after apply)
      + to_port                  = 8302
      + type                     = "ingress"
    }

  # module.consul.module.consul_servers.module.security_group_rules.aws_security_group_rule.allow_serf_wan_udp_inbound_from_self will be created
  + resource "aws_security_group_rule" "allow_serf_wan_udp_inbound_from_self" {
      + from_port                = 8302
      + id                       = (known after apply)
      + protocol                 = "udp"
      + security_group_id        = (known after apply)
      + self                     = true
      + source_security_group_id = (known after apply)
      + to_port                  = 8302
      + type                     = "ingress"
    }

  # module.consul.module.consul_servers.module.security_group_rules.aws_security_group_rule.allow_server_rpc_inbound[0] will be created
  + resource "aws_security_group_rule" "allow_server_rpc_inbound" {
      + cidr_blocks              = [
          + "<IP_ADDRESS>/0",
        ]
      + from_port                = 8300
      + id                       = (known after apply)
      + protocol                 = "tcp"
      + security_group_id        = (known after apply)
      + self                     = false
      + source_security_group_id = (known after apply)
      + to_port                  = 8300
      + type                     = "ingress"
    }

  # module.consul.module.consul_servers.module.security_group_rules.aws_security_group_rule.allow_server_rpc_inbound_from_self will be created
  + resource "aws_security_group_rule" "allow_server_rpc_inbound_from_self" {
      + from_port                = 8300
      + id                       = (known after apply)
      + protocol                 = "tcp"
      + security_group_id        = (known after apply)
      + self                     = true
      + source_security_group_id = (known after apply)
      + to_port                  = 8300
      + type                     = "ingress"
    }

  # module.consul.module.consul_clients.module.security_group_rules.module.client_security_group_rules.aws_security_group_rule.allow_serf_lan_tcp_inbound[0] will be created
  + resource "aws_security_group_rule" "allow_serf_lan_tcp_inbound" {
      + cidr_blocks              = [
          + "<IP_ADDRESS>/0",
        ]
      + from_port                = 8301
      + id                       = (known after apply)
      + protocol                 = "tcp"
      + security_group_id        = (known after apply)
      + self                     = false
      + source_security_group_id = (known after apply)
      + to_port                  = 8301
      + type                     = "ingress"
    }

  # module.consul.module.consul_clients.module.security_group_rules.module.client_security_group_rules.aws_security_group_rule.allow_serf_lan_tcp_inbound_from_self will be created
  + resource "aws_security_group_rule" "allow_serf_lan_tcp_inbound_from_self" {
      + from_port                = 8301
      + id                       = (known after apply)
      + protocol                 = "tcp"
      + security_group_id        = (known after apply)
      + self                     = true
      + source_security_group_id = (known after apply)
      + to_port                  = 8301
      + type                     = "ingress"
    }

  # module.consul.module.consul_clients.module.security_group_rules.module.client_security_group_rules.aws_security_group_rule.allow_serf_lan_udp_inbound[0] will be created
  + resource "aws_security_group_rule" "allow_serf_lan_udp_inbound" {
      + cidr_blocks              = [
          + "<IP_ADDRESS>/0",
        ]
      + from_port                = 8301
      + id                       = (known after apply)
      + protocol                 = "udp"
      + security_group_id        = (known after apply)
      + self                     = false
      + source_security_group_id = (known after apply)
      + to_port                  = 8301
      + type                     = "ingress"
    }

  # module.consul.module.consul_clients.module.security_group_rules.module.client_security_group_rules.aws_security_group_rule.allow_serf_lan_udp_inbound_from_self will be created
  + resource "aws_security_group_rule" "allow_serf_lan_udp_inbound_from_self" {
      + from_port                = 8301
      + id                       = (known after apply)
      + protocol                 = "udp"
      + security_group_id        = (known after apply)
      + self                     = true
      + source_security_group_id = (known after apply)
      + to_port                  = 8301
      + type                     = "ingress"
    }

  # module.consul.module.consul_servers.module.security_group_rules.module.client_security_group_rules.aws_security_group_rule.allow_serf_lan_tcp_inbound[0] will be created
  + resource "aws_security_group_rule" "allow_serf_lan_tcp_inbound" {
      + cidr_blocks              = [
          + "<IP_ADDRESS>/0",
        ]
      + from_port                = 8301
      + id                       = (known after apply)
      + protocol                 = "tcp"
      + security_group_id        = (known after apply)
      + self                     = false
      + source_security_group_id = (known after apply)
      + to_port                  = 8301
      + type                     = "ingress"
    }

  # module.consul.module.consul_servers.module.security_group_rules.module.client_security_group_rules.aws_security_group_rule.allow_serf_lan_tcp_inbound_from_self will be created
  + resource "aws_security_group_rule" "allow_serf_lan_tcp_inbound_from_self" {
      + from_port                = 8301
      + id                       = (known after apply)
      + protocol                 = "tcp"
      + security_group_id        = (known after apply)
      + self                     = true
      + source_security_group_id = (known after apply)
      + to_port                  = 8301
      + type                     = "ingress"
    }

  # module.consul.module.consul_servers.module.security_group_rules.module.client_security_group_rules.aws_security_group_rule.allow_serf_lan_udp_inbound[0] will be created
  + resource "aws_security_group_rule" "allow_serf_lan_udp_inbound" {
      + cidr_blocks              = [
          + "<IP_ADDRESS>/0",
        ]
      + from_port                = 8301
      + id                       = (known after apply)
      + protocol                 = "udp"
      + security_group_id        = (known after apply)
      + self                     = false
      + source_security_group_id = (known after apply)
      + to_port                  = 8301
      + type                     = "ingress"
    }

  # module.consul.module.consul_servers.module.security_group_rules.module.client_security_group_rules.aws_security_group_rule.allow_serf_lan_udp_inbound_from_self will be created
  + resource "aws_security_group_rule" "allow_serf_lan_udp_inbound_from_self" {
      + from_port                = 8301
      + id                       = (known after apply)
      + protocol                 = "udp"
      + security_group_id        = (known after apply)
      + self                     = true
      + source_security_group_id = (known after apply)
      + to_port                  = 8301
      + type                     = "ingress"
    }

Plan: 52 to add, 0 to change, 0 to destroy.

------------------------------------------------------------------------

Thanks for the PR! So this will only work with terraform 12 but not with older versions? Is there a major conflict that stops it from running in both?

Thanks for the PR! So this will only work with terraform 12 but not with older version, correct? Let me run the tests :)

Yes @Etiene that's correct. Based on my understanding in the upgrade guide, these changes are not backwards compatible.

Have you tried running the tests after this update? I kicked off our automated tests but currently it is failing with:
 Error: Error parsing /tmp/TestConsulClusterWithAmazonLinuxAmi896389390/terraform-aws-consul/main.tf: At 60:19: Unknown token: 60:19 IDENT var.num_servers
Perhaps a previous version of terraform is still being used somewhere in the process

But also terratest supports terraform 0.12 only as of v0.16.0, so the terratest version and the tests need to be updated as well

Any progress regarding terraform 0.12 compatibility?

I'll do my best to take a look today or tomorrow about updating tests, missed that earlier.

On May 31, 2019, at 1:45 PM, Etiene Dalcol<EMAIL_ADDRESS>wrote:
But also terratest supports terraform 0.12 only as of v0.16.0, so the terratest version and the tests need to be updated as well
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

Glad to come across this. I have a tf config that depends on this (and the vault one), and cannot run in tf 0.12 because of the 0.11-ism.
Out of curiosity, how do you plan on maintaining support for 0.11 and 0.12, since the syntax is incompatible? Will you do multiple branches? Or just keep 0.12 only going forward except for hotfixes?

Out of curiosity, how do you plan on maintaining support for 0.11 and 0.12, since the syntax is incompatible? Will you do multiple branches? Or just keep 0.12 only going forward except for hotfixes?

We will be updating each module, merging the updates into master, and doing a new (backwards incompatible) release. After that, we will only support 0.12 going forward, other than security-related hotfixes.

Makes sense. Thanks.
I really do wish that, e.g. 0.12.x (or maybe 0.12.0-0.12.4, or some subset) supported both fo an easier transition path. The knowledge must be in there anyways, since 0.12.x includes that 0.12upgrade command. Big Bang transitions are hard to do.

Hi @mustafashabib , I am the project lead for the tf12 updates at Gruntwork, and I'm almost ready to start on the consul, vault, and nomad modules. I am expecting to get started with these modules next week.
I wanted to check in to see if you were still interested in completing this, or would you be ok with me taking on the torch? I will build off of your commits so the initial work here will still be properly attributed to you.
Taking a scan here, here are the things that need to be addressed:

We need to update not just the root example, but all the examples in the examples folder
Need to update the tests to run off of tf12. This includes upgrading terratest to 0.16.X.
All the input vars should have type set, not just list and map.
Following the new tf12 convention, we should default to using null instead of "" to mean "unset".

Just let me know!

Thank you - I haven’t had time to update the tests and the examples. Feel free to take over this PR, I appreciate your work!

On Jun 20, 2019, at 6:25 PM, Yoriyasu Yano<EMAIL_ADDRESS>wrote:
Hi @mustafashabib https://github.com/mustafashabib , I am the project lead for the tf12 updates at Gruntwork, and I'm almost ready to start on the consul, vault, and nomad modules. I am expecting to get started with these modules next week.
I wanted to check in to see if you were still interested in completing this, or would you be ok with me taking on the torch? I will build off of your commits so the initial work here will still be properly attributed to you.
Taking a scan here, here are the things that need to be addressed:
We need to update not just the root example, but all the examples in the examples folder
Need to update the tests to run off of tf12. This includes upgrading terratest to 0.16.X.
All the input vars should have type set, not just list and map.
Following the new tf12 convention, we should default to using null instead of "" to mean "unset".
Just let me know!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub https://github.com/hashicorp/terraform-aws-consul/pull/138?email_source=notifications&email_token=AAGMHAU32M2P4ASGLLO4CBDP3P7VJA5CNFSM4HPLIYN2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODYG46EY#issuecomment-504221459, or mute the thread https://github.com/notifications/unsubscribe-auth/AAGMHAWTJCIS3756ZWHPVBDP3P7VJANCNFSM4HPLIYNQ.

Closing in favor of #144


$(tb:emotes) doesn't work anymore

Removed and replaced by tb:emote_instances and tb:emote_counts, documented in https://github.com/pajbot/pajbot1-doc/commit/1dfd6909f914a9fe2941505b2bd0300b00c95f0f