Multus: error in invoke Delegate add - "flannel": open /run/flannel/subnet.env

I am trying to configure 2 network card in a pod for testing purpose. I am using multus plugin and executed following steps:

Downloaded the Multus plugin and build it. Copied the file under /opt/cni/bin. I executed this step on both master as well as on worker node.
Following is the kubeadm version:
kubeadm version: &version.Info Major:"1", Minor:"9", GitVersion:"v1.9.1+2.1.5.el7"
I followed Install Doc. I used multus.yaml.
When I create ngnix container, I get following error on worker node:

Apr  8 07:20:41 k8dind2 kubelet: E0408 07:20:41.043438   31024 remote_runtime.go:92] RunPodSandbox from runtime service failed: rpc error: code = Unknown desc = NetworkPlugin cni failed to set up pod "nginx-whjjm_default" network: Multus: error in invoke Delegate add - "flannel": open /run/flannel/subnet.env: no such file or directory
Apr  8 07:20:41 k8dind2 kubelet: E0408 07:20:41.043487   31024 kuberuntime_sandbox.go:54] CreatePodSandbox for pod "nginx-whjjm_default(28594443-3afd-11e8-824c-0000170195b8)" failed: rpc error: code = Unknown desc = NetworkPlugin cni failed to set up pod "nginx-whjjm_default" network: Multus: error in invoke Delegate add - "flannel": open /run/flannel/subnet.env: no such file or directory
Apr  8 07:20:41 k8dind2 kubelet: E0408 07:20:41.043506   31024 kuberuntime_manager.go:647] createPodSandbox for pod "nginx-whjjm_default(28594443-3afd-11e8-824c-0000170195b8)" failed: rpc error: code = Unknown desc = NetworkPlugin cni failed to set up pod "nginx-whjjm_default" network: Multus: error in invoke Delegate add - "flannel": open /run/flannel/subnet.env: no such file or directory
Apr  8 07:20:41 k8dind2 kubelet: E0408 07:20:41.043546   31024 pod_workers.go:186] Error syncing pod 28594443-3afd-11e8-824c-0000170195b8 ("nginx-whjjm_default(28594443-3afd-11e8-824c-0000170195b8)"), skipping: failed to "CreatePodSandbox" for "nginx-whjjm_default(28594443-3afd-11e8-824c-0000170195b8)" with CreatePodSandboxError: "CreatePodSandbox for pod "nginx-whjjm_default(28594443-3afd-11e8-824c-0000170195b8)" failed: rpc error: code = Unknown desc = NetworkPlugin cni failed to set up pod "nginx-whjjm_default" network: Multus: error in invoke Delegate add - "flannel": open /run/flannel/subnet.env: no such file or directory"
I have no idea how to fix it. Also, I have following physical network cards on my master and worker node:
ens3 : 10.0.20.xx
ens4 : 192.168.16.xx
Do I need to change IP series in multus.yaml?

I also observed following things:

I can see only 1 multus container on master:
bash-4.2# kubectl get pods --all-namespaces | grep multus
kube-system   kube-multus-ds-9jzrp                    1/2       CrashLoopBackOff    6          10m

If I describe pod, I see following error:
Events:
Type     Reason                 Age               From              Message

Normal   SuccessfulMountVolume  8m                kubelet, k8dind2  MountVolume.SetUp succeeded for volume "cni"
Normal   SuccessfulMountVolume  8m                kubelet, k8dind2  MountVolume.SetUp succeeded for volume "run"
Normal   SuccessfulMountVolume  8m                kubelet, k8dind2  MountVolume.SetUp succeeded for volume "flannel-cfg"
Normal   SuccessfulMountVolume  8m                kubelet, k8dind2  MountVolume.SetUp succeeded for volume "multus-token-ldk62"
Normal   Pulled                 8m                kubelet, k8dind2  Container image "quay.io/coreos/flannel:v0.7.0-amd64" already present on machine
Normal   Created                8m                kubelet, k8dind2  Created container
Normal   Started                8m                kubelet, k8dind2  Started container
Normal   Pulled                 6m (x4 over 8m)   kubelet, k8dind2  Container image "quay.io/coreos/flannel:v0.7.0-amd64" already present on machine
Normal   Created                6m (x4 over 8m)   kubelet, k8dind2  Created container
Normal   Started                6m (x4 over 8m)   kubelet, k8dind2  Started container
Warning  BackOff                3m (x12 over 7m)  kubelet, k8dind2  Back-off restarting failed container

@psaini79 Flannel daemon is not running in your node.. Please check the flannel daemonset deployment in @dougbtv multus.yaml file

@psaini79 @dougbtv I think somewhere command: [ "/bin/sh", "-c", "set -e -x; cp -f /etc/kube-flannel/cni-conf.json /etc/cni/net.d/10-multus.conf; while true; do sleep 3600; done" ] is failing in the flannel container.

Thanks for highlighting me -- Kural's right on the money, it sure looks like you don't have a Flannel daemonset running there.
I have a reference Flannel daemonset that uses Multus+Flannel that I use often, it's a jinja2 template that I use as a set of ansible playbooks -- so you'll need to kind of manually parse it. Notably, anything that's {{ in_double_curly_braces }} is a variable and you'll need to fill it out by hand if you're not processing the template.
However, this is the one: https://github.com/redhat-nfvpe/kube-ansible/blob/master/roles/kube-template-cni/templates/multus.yaml.j2

Hello Everyone,
Thanks for providing input. I will check my env and will get back to you.
However, I would like to let you know that I am able to configure 2 network cards using following config file. I took this file from YYGCui user.:
{
"name": "multus-demo-network",
"type": "multus",
"delegates": [
{
"type": "flannel",
"name": "flannel.2",
"subnetFile": "/run/flannel/networks/2.env",
"dataDir": "/var/lib/cni/flannel/2",
"delegate": {
"bridge": "kbr1"
}
},
{
"type": "flannel",
"name": "flannel.1",
"subnetFile": "/run/flannel/subnet.env",
"dataDir": "/var/lib/cni/flannel",
"masterplugin": true,
"delegate": {
"bridge": "kbr0",
"isDefaultGateway": true
}
}
]
}

I believe that looks like it's going to use flannel, which will require a daemonset being up, or, at least I assume, when you get back in touch can you post the process you used in whole, e.g. did you require both spinning up the yaml from my own reference with flannel+multus, and then configuring that? Or is that packed inside the yaml? Thanks

Hi,
I appreciate your help and using your new conf file, I am able to configure 2 network cards in the container using multus plug in.
Though I have few question and I am going test the same:

What will happen to my pod if there is any error in macvlan eth card? i.e. eth0 or flannel based IP? or both of them have issues?
Can I have 2 flannel based card running on 2 different physical network card? I am able to configure 2 network card inside the container using flannel driver but I don't know how to configure flannel driver on 2 different physical network card?
I observed that I can reach i.e. 'ping' Flannel based ip from one pod to another pod but I am unable to  reach IPs allocated to macvlan based card. However, I am checking routing table and will debug it further.

Hi,
Though I am able to see 2 network cards in container, I am unable to ping MACVLAN based Ip from other PODs or hosts.
If I check following on the worker node, I do not see any bridge allocated to MACVLAN:
bash-4.2# brctl show
bridge name     bridge id               STP enabled     interfaces
cni0            8000.0a580af40101       no              vethfc275506
docker0         8000.0242e2df3b04       no
I gave reference of ens4 but it seems that flannel and Macvlan are on same bridge i.e. cni. I used following file:
{
"name": "multus-demo",
"type": "multus",
"delegates": [
{
"type": "macvlan",
"master": "ens4",
"mode": "bridge",
"ipam": {
"type": "host-local",
"subnet": "<IP_ADDRESS>/24",
"rangeStart": "<IP_ADDRESS>",
"rangeEnd": "<IP_ADDRESS>",
"routes": [
{ "dst": "<IP_ADDRESS>/0" }
],
"gateway": "<IP_ADDRESS>"
}
},
{
"type": "flannel",
"masterplugin": true,
"delegate": {
"isDefaultGateway": true
}
}
]
}

@psaini79 -- do you have any further information on this one? If not, could you please close that out?

I looked at it sometime back and found the issue was in my env. I found that macvlan bridge did not work on few VMs as some policies was enforced at ARP level which didn't allow me to pass packets outside the VM.
Since the issue in my env , I am closing it and will reopen if I test the some new machine. I will add my feedback.
Thanks @dougbtv  for your help.


Add grace period to allow resolution of transient CreateContainerError

Signed-off-by: Jeev B<EMAIL_ADDRESS>TL;DR
Adds grace period to allow resolution of transient CreateContainerError
Type

[x] Bug Fix
[ ] Feature
[ ] Plugin

Are all requirements met?

[x] Code completed
[ ] Smoke tested
[x] Unit tests added
[ ] Code documentation added
[ ] Any pending items have an associated Issue

Complete description
Adds the CreateContainerErrorGracePeriod config option to the k8s plugin that specifies the amount of time to allow for CreateContainerError to be resolved by kubelet + container runtime, before marking the corresponding task as permanently failed. This grace period is used within DemystifyPending.
Tracking Issue
Remove the 'fixes' keyword if there will be multiple PRs to fix the linked issue
fixes https://github.com/flyteorg/flyte/issues/1234
Follow-up issue
NA
OR
https://github.com/flyteorg/flyte/issues/

Also note that this change may cause a failure in the case where a pod goes from Running -> Pending, for some reason. Per the pod lifecycle, however, this should theoretically not happen.


How to train and test MemSeg in other datasets

Hello, sorry to bother you. How can i set up training and testing on other datasets. such as KolektorSDDs.  Do I first have to adjust the structure of the dataset and then make some changes in the code? 🙏   @TooTouch

For example, the new data set is 228 x 630 pixels. Should it be adjusted to 256x256?

I mainly changed the anomaly_mask.json and the datadir and batch_size in the configs.yaml file, and modified the new dataset to follow the MVTec dataset arch. Now the code can run and train, but SEED: 42 has not changed. Does this mean that the parameters are still the same as before

Hi, @jamdodot

For example, the new data set is 228 x 630 pixels. Should it be adjusted to 256x256?

Converting to 256 x 256 is the easiest way to go. However, if the proportions of your existing image are important to you, you may want to leave it unconverted.

I mainly changed the anomaly_mask.json and the datadir and batch_size in the configs.yaml file, and modified the new dataset to follow the MVTec dataset arch. Now the code can run and train, but SEED: 42 has not changed. Does this mean that the parameters are still the same as before

Yes, the seed is for reproducibility to produce the same result.

Thank you for your answer. I still have some questions I would like to ask you.

seed parameters can be unchanged ?
Metrics will be calculated every 100 iterations. I added two lines of printing information in evaluate function.

  image_masks = np.array(image_masks)
    anomaly_map = np.array(anomaly_map)
    print(image_targets)
    print(anomaly_score)
    auroc_image = roc_auc_score(image_targets, anomaly_score)

What makes me confused is that the value of the image_targets array does not change every time

3. My training graph looks really weird and I don't know what's wrong. can you give me  some advice 😭 🙏
wandb-Link
output.log

A1. The seed parameter can be changed with any number.
A2. The value of the image_targets array does not change every time, because the shuffle is False for testloader.
A3. Can you explain what looks weird?
I modified the focal loss few minutes ago.
You can try again with a modified focal loss. (#22, c3c6e99ad3c7fc9fc394e0d19c8b20f688027061)

I think that the fluctuation can be reduced with lower learning rate.
Since the evaluation scores have pretty much converged since the beginning, I think that with a small learning rate, a small parameter update should be enough to improve performance.

I would like to ask about the N normal samples in the memory bank. What is the value of N? How to determine its value?  🤔   @TooTouch

@jamdodot
There is no criterion for the N normal samples of the memory bank.
The value of N in this repo is the value mentioned in MemSeg paper.
N should be specified as a sample size large enough to capture all the features of normal data.
This will vary depending on the characteristics of your data, but you can use your domain knowledge to determine this.

Why does the test path need to contain good samples in the MVTech AD data set structure?  If there is no good sample file, the following error will occur：

only one class present in y_true. roc auc score is not defined in that case

Is it to calculate AUROC? @TooTouch

@jamdodot
I'm sorry too late for reply.
The good samples need to calculate AUROC. Because AUROC is the area under ROC curve that is constructed by true positive rate and false positive rate.
To calculate the true positive rate and false positive rate need good class in binary class setting.
https://towardsdatascience.com/understanding-auc-roc-curve-68b2303cc9c5


Exercise detail view back arrow redirect to course

Checklist

[ ] I tested all changes and all related features with different users (student, tutor, instructor, admin) on the test server https://artemistest.ase.in.tum.de.
[x] Client: I followed the coding and design guidelines.

Motivation and Context

Resolves #2251
Description
Pressing the back arrow does not go back to the previous history anymore. Instead, the URL to the course is built and navigated to via the Router service.
Steps for Testing

Log in to Artemis
Navigate to courses
Select a course
Select an exercise
Bookmark the page
Close the window and open the bookmarked exercise page
Press the back arrow

We want to get rid of back buttons in the future and should not change their behavior any more


ONNX import issue: index out of bounds in pad_config() due to node.input only having len of 2

ERROR burn_import::logger: PANIC => panicked at /home/simon/.cargo/git/checkouts/burn-178c6829f420dae1/f7639bd/crates/burn-import/src/onnx/op_configuration.rs:802:27:
index out of bounds: the len is 2 but the index is 2

Link to model: https://drive.google.com/file/d/1E6fNKzGE3_JhEokgqqHDqJxwqw3UUku9/view?usp=drive_link

Yes, it seems all ops in the ONNX file should be supported.

CC @mepatrick73 it's a good one to take to fix a bug.

I'll get on it!

This problem is now fixed, there are more issues with the model. Specifically the avgpool operation uses ceilling mode which we currently do not support. If you could make a new issue, that would be wonderful.
Anyhow, I'll close this issue as it is now fixed.

Thanks @mepatrick73!


Feature Request: Subtitles

I used this to make an anime channel. With anime, you kind of need subtitles, as the audio is in japanese. Can you add some way to add subtitles to these streams? You could do it with an ffmpeg flag i think. Thanks in advance

Thanks for the feedback. This is definitely on the roadmap.
Closing as a duplicate of #45


ISPN-12068 Add Chunked File handler to the HTTP/2 pipeline

https://issues.redhat.com/browse/ISPN-12068
Not sure if we need the CORS handler too. @gustavonalle can you check please ?

I will improve the coverage of HTTP/2 tests and we will find out what it needs

Merged, thanks @tristantarrant !

I tested some more resources under HTTP/2, and we also need CORS and compression in the pipeline, I will send a PR for them
/cc @pruivo


simplify the use of flink connector

Proposed changes
Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue.

Simplify the use of flink connector like other stream sink by GenericDorisSinkFunction.
Add the use cases of flink connector.

Use case
env.fromElements("{\"longitude\": \"116.405419\", \"city\": \"北京\", \"latitude\": \"39.916927\"}")
     .addSink(
          DorisSink.sink(
             DorisOptions.builder()
                   .setFenodes("FE_IP:8030")
                   .setTableIdentifier("db.table")
                   .setUsername("root")
                   .setPassword("").build()
                ));

Types of changes
What types of changes does your code introduce to Doris?
Put an x in the boxes that apply

[ ] Bugfix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation Update (if none of the other choices apply)
[ ] Code refactor (Modify the code structure, format the code, etc...)
[x] Optimization. Including functional usability improvements and performance improvements.
[ ] Dependency. Such as changes related to third-party components.
[ ] Other.

Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

[ ] I have created an issue on (Fix #ISSUE) and described the bug/feature there in detail
[x] Compiling and unit tests pass locally with my changes
[x] I have added tests that prove my fix is effective or that my feature works
[x] If these changes need document changes, I have updated the document
[ ] Any dependent changes have been merged

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

It is recommended to add descriptions and examples in   docs/zh-CN/extending-doris/flink-doris-connector.md  for this feature.


Empty product

Fixes #28

Output matrices are now always allocated in an undefined state (putting the self-created and the given output on equal footing and removing the mostly redundant zero-initialization in the case of self-creation)
Output matrices are explicitly zeroed in the case of the empty shortcuts
Output matrices are implicitly zeroed via their coefficients in the MKL calls
Type checks are also carried out when the empty shortcut is taken
The lower triangle in the to-dense Gram matrix calculation is now always undefined (before, it was zeroed out if the output was self-created), so tests are adjusted appropriately

Output matrices are explicitly zeroed in the case of the empty shortcuts
Type checks are also carried out when the empty shortcut is taken

These things are fine

Output matrices are now always allocated in an undefined state (putting the self-created and the given output on equal footing and removing the mostly redundant zero-initialization in the case of self-creation)
Output matrices are implicitly zeroed via their coefficients in the MKL calls
The lower triangle in the to-dense Gram matrix calculation is now always undefined (before, it was zeroed out if the output was self-created), so tests are adjusted appropriately

I am concerned about making this breaking change to save a zero-initialization. In the case where you want to output into an empty matrix, you can always pass one into out and save the initialization. In most other cases, partially initialized arrays do not play well with numpy broadcasts. Is there a specific, tangible problem with initializing the output explicitly that allocating an empty array and initializing it to 0 with a multiplication solves?

The question is whether this actually is a breaking change - I would say no. The creation of an uninitialized instead of a zero matrix is the change introduced in the _out_matrix function. And all the other functions that use this one were adapted to handle this change.
Is there any "semantic" reason/problem why I introduced the change - no. The only reason for this is that zero-initializing something is an extra step that is not necessary, so leaving it uninitialized saves some operations (that, granted, are fast compared to the actual multiplications).
If you call BLAS functions with zero coefficient on the output array, then the output array is overwritten (which is different from multiplying by zero given that there's NaN and Inf). Therefore, zero-initializing an output array and then calling a BLAS function with any output scaling is equivalent to not initializing it and calling the function with zero output scaling, so in almost all functions, the user will not notice anything about the internal change.
The only case in which some actually different "results" can be observed are the to-dense Gram matrix functions which by Intel's documentation leave the lower triangle untouched. Given that the user somehow has to cope with this either by copying the upper triangle or by subsequently calling functions that work on the triangle only, this also shouldn't be a problem. But yes, in this particular case it is exposed to the user, so I could insert a zero-fill just there?

By the way, I'm also very curious about all those test failures, as I didn't touch the Pardiso part at all. And the one failed test in COO multiplication on my machine I attributed to a newer version of NumPy/SciPy that I had installed where probably some properties were renamed, but now it also happens here. I'll have to check this one.

Don't worry about the pardiso tests, it's just the initialization function and it passes locally.
The gram matrix function will sometimes return an array which is partially uninitialized, and it will do so unpredictably depending on the arguments that are provided (it does not pass the current release unit tests). Fixing it with numpy indexing at the end has memory and time costs that certainly exceed initializing the array when it's declared.
IF you don't mind, I'm going to roll back those changes, and keep the changes that fix #28. I will also write unit tests to cover passing in an empty matrix as out and out_scalar=0 to make sure that you can get this behavior if it's useful - I can imagine that it'd be a non-trivial improvement if you are doing lots of little matrix operations.

Sure, you can roll back the non-initialization; it is not so bad for performance.
I completely agree that the zeroing as done in the tests does not make any sense for production systems. In the tests, I just chose a very quick and dirty way - it would be much better to just compare the upper triangles.
I wouldn't say that it is unpredictable. In fact, I'd rather say that the array is always, regardless of the arguments, partly "uninitialized" for this simple reason: Assume you have valid data in your out array and then you perform the gram function. After this, the upper triangle will correctly contain the output. But the lower triangle will be untouched with some old, no longer valid, data. If you want to use this output, you either have to restrict yourself to functions that only use one triangle (of which there are a couple in BLAS/particular LAPACK), or you have to copy the upper to the lower triangle. Until you do this, the lower triangle is essentially invalid.
But this is only a matter of documenting what you want to happen in the individual cases, so if you want it to always return a zero lower triangle (in the out=None case, and keep the original value in the other case, assuming we can interpret Intel's "Only the upper-triangular part of the matrix is computed." as "We will never change the lower triangle, also not abuse it as a temporary"), please do so. However, I would then suggest to simply catch the out=None case in the Gram function and do the zero initialization there instead of doing it generically in _out_matrix, where it is really not necessary.

Aight, I ended up keeping it and just initializing the gram matrix to zero

Intel's "Only the upper-triangular part of the matrix is computed."

As a warning, this is not true for the sparse syrk, depending on which (unrelated) flags are provided


18

This PR solves #18 . Tests for Common.c were added.

@rultor merge this PR please

@rultor merge this PR please

@maxgoryunov OK, I'll try to merge now. You can check the progress of the merge here

@rultor merge this PR please

@maxgoryunov Done! FYI, the full log is here (took me 2min)


README.md for AWS EKS cluster added

Description
README.md for AWS EKS cluster added
Type of change

[x] Documentation update

Screenshots

[x] No screenshot

I believe it would be easier to create a new PR with changed README only @localdotcom


[Branch View] save space, change pull button to a icon-only button

Oh, and if you want to save even more space, change the pull button to a icon-only button.
Originally posted by @silverwind in https://github.com/go-gitea/gitea/pull/7520#issuecomment-514728279

@6543 Is this resolved?

Not jet

But I'm not working on this at the moment ...

Should add this to the #7454 list


os/linux/elf.rb: Use readelf for Linuxbrew

Use readelf if available, otherwise patchelf,
and otherwise print an error.

Codecov Report

Merging #365 into master will decrease coverage by 0.06%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #365      +/-   ##
==========================================
- Coverage   61.35%   61.29%   -0.07%
==========================================
  Files         375      375
  Lines       20367    20389      +22
==========================================
  Hits        12497    12497
- Misses       7870     7892      +22

Impacted Files
Coverage Δ

os/linux/elf.rb
0% <0%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5362d92...bd9b901. Read the comment docs.


feat(rotable): add metatable support to rotable

Since rodata's meta table is already used to fake the normal table operation, we use userdata uservalue[2] to store an optional table as meta table. It's further searched when no match found in rodata's __index method.
Fix bug in rotable_newidx.

Requires lua5.4


[Business Approvals Kit - BUG] Schema Validation Issue

Describe the issue
When testing the custom connector, a an error is shown on the GetApprovalDataFields:
Property "" type mismatch, Expected: "object", Actual: "string".
This is shown for all operations and are returning a 401 error
Expected Behavior
Per the Learn steps (https://learn.microsoft.com/en-us/power-automate/guidance/business-approvals-templates/setup) the operations should run successfully with a status of 200
What solution version are you using?
1.70
What app or flow are you having the issue with?
Custom connectors
Steps To Reproduce
Under the Security tab, modify the following:
Select Authentication type as OAuth 2.0.
Enter the Client ID, Secret noted in previous section.
Specify the environment URL under Resource URL section.
Copy the Redirect URL
Open the created Entra App Registration
Select Authentication
In the Web Redirect URIs add the Redirect URL
Select Save to update the App Registration
Switch back to the custom connector.
Select Update connector.
Under the Test tab, create a New connection.
Specify the account details for the connection and allow access if prompted.
Edit the Custom connector again and test the GetPublishedWorkflow operation.
The operation should run successfully with status as 200.
Anything else?
No response
AB#1820

@WorkWithMeHere - Can you please confirm if
a) You have modified the host URL in the General tab and Resource URL in Security Tab of the custom connector based on your target environment details as mentioned in the release note - Setup Guide section and updated the connector.
b) You are able to create the connection for the custom connector inside PowerAutomate.

Thanks - changing the host URL in the general channel fixed the issue and we are now able to use the approvals kit.
Thank you 👍

For anyone else who happens across this page - update the general tab with the environment URL (which can be found in the power platform admin settings). Should be in the format of the image below


ra_ide_db fails to compile on PocketBeagle computer

"cargo xtask install --server" eventually dies at ra_ide_db because it eventually chews up 512MB of RAM on a PocketBeagle computer and gets out of memory killed.
I had a similar problem with rustup where they had a peak usage that would overflow.  However, they fixed it.  See:
https://github.com/rust-lang/rustup/issues/2340
Quoting:

This is likely fixed with master which probes for available memory using
the effective-memory crate.

The memory spike is due to having to hold buffers for incomplete writes.

I will check if swap allows the process to complete.  However, as these systems all have flash-based filesystems, swap is not a good solution.
Thanks.

Have you tried passing -j1 to cargo to prevent multiple parallel rustc processes? (edit https://github.com/rust-analyzer/rust-analyzer/blob/3615347fcebebaa58a5cbf675ae062aae149d9c3/xtask/src/install.rs#L134)

Can confirm adding swap allows compile to complete.  I will try with -j1 to see what happens.

How do I pass "-j1" to the appropriate commands.  Nothing I do seems to work.  For example:
# export RUSTFLAGS="-j1"
root@beaglebone:~/rust-analyzer-2# time cargo xtask install
error: failed to run `rustc` to learn about target-specific information

Caused by:
  process didn't exit successfully: `rustc - --crate-name ___ --print=file-names -j1 --crate-type bin --crate-type rlib --crate-type dylib --crate-type cdylib --crate-type staticlib --crate-type proc-macro --print=sysroot --print=cfg` (exit code: 1)
--- stderr
error: Unrecognized option: 'j'

-j1 is not a rustc argument. It is a cargo argument. You can edit the cargo invocation at https://github.com/rust-analyzer/rust-analyzer/blob/3615347fcebebaa58a5cbf675ae062aae149d9c3/xtask/src/install.rs#L134

Can confirm that -j1 doesn't change things.  This is not surprising as the chip only has a single A8 core.
 # time cargo xtask install
   Compiling xtask v0.1.0 (/root/rust-analyzer-2/xtask)
    Finished dev [unoptimized] target(s) in 22.88s
     Running `target/debug/xtask install`
> cargo --version
cargo 1.44.1 (88ba85757 2020-06-11)
> cargo install -j1 --path crates/rust-analyzer --locked --force
  Installing rust-analyzer v0.1.0 (/root/rust-analyzer-2/crates/rust-analyzer)
    Updating crates.io index
   Compiling ra_ide_db v0.1.0 (/root/rust-analyzer-2/crates/ra_ide_db)
error: failed to compile `rust-analyzer v0.1.0 (/root/rust-analyzer-2/crates/rust-analyzer)`, intermediate artifacts can be found at `/root/rust-analyzer-2/target`

Caused by:
  could not compile `ra_ide_db`.

Caused by:
  process didn't exit successfully: `rustc --crate-name ra_ide_db --edition=2018 crates/ra_ide_db/src/lib.rs --error-format=json --json=diagnostic-rendered-ansi,artifacts --crate-type lib --emit=dep-info,metadata,link -C opt-level=3 -C debuginfo=0 -C metadata=cd6412056c55cbf2 -C extra-filename=-cd6412056c55cbf2 --out-dir /root/rust-analyzer-2/target/release/deps -C incremental=/root/rust-analyzer-2/target/release/incremental -L dependency=/root/rust-analyzer-2/target/release/deps --extern either=/root/rust-analyzer-2/target/release/deps/libeither-dfed31a392aedfea.rmeta --extern fst=/root/rust-analyzer-2/target/release/deps/libfst-59e43af35a29fa04.rmeta --extern log=/root/rust-analyzer-2/target/release/deps/liblog-0e590f17c3c4559d.rmeta --extern once_cell=/root/rust-analyzer-2/target/release/deps/libonce_cell-b7fa5b4adfd48191.rmeta --extern ra_db=/root/rust-analyzer-2/target/release/deps/libra_db-b0d1d62e20cb8249.rmeta --extern hir=/root/rust-analyzer-2/target/release/deps/libra_hir-2575e1cf737ef491.rmeta --extern ra_prof=/root/rust-analyzer-2/target/release/deps/libra_prof-e252edca3f2f32ff.rmeta --extern ra_syntax=/root/rust-analyzer-2/target/release/deps/libra_syntax-a268f1ca8234ab95.rmeta --extern ra_text_edit=/root/rust-analyzer-2/target/release/deps/libra_text_edit-65504f750098197d.rmeta --extern rayon=/root/rust-analyzer-2/target/release/deps/librayon-579d180634971d45.rmeta --extern rustc_hash=/root/rust-analyzer-2/target/release/deps/librustc_hash-5220f8d22a79c07f.rmeta --extern superslice=/root/rust-analyzer-2/target/release/deps/libsuperslice-1b903db085c3acc4.rmeta --extern test_utils=/root/rust-analyzer-2/target/release/deps/libtest_utils-222f80ca0c5efbed.rmeta` (signal: 9, SIGKILL: kill)
Error: install server

Caused by:
    0: process `cargo install -j1 --path crates/rust-analyzer --locked --force ` failed
    1: exit code: 101

real    39m2.673s
user    22m35.302s
sys     1m54.413s

Does turning down codegen-units to 1 help here? Also, would it be possible to cross-compile it instead?

I'm willing to try if you tell me how to turn the codegen-units down.
Yes, it's always possible to cross compile.  That has its own set of issues and generally winds up producing subtle bugs that are hard to track down.  However, that's a band-aid along the lines of "I can enable swap".
I also would like to know "Why is this particular crate out of all of the 190+ the only one causing a memory hiccup?"
In addition, I don't want to let this drop because this is part-and-parcel of "Rust is painful to compile".

I'm willing to try if you tell me how to turn the codegen-units down.

Add the following to the bottom of Cargo.toml:
[profile.release]
codegen-units = 1

or set RUSTFLAGS="-Ccodegen-units=1.

We improved our compile times/separate compilation quite a bit recently, might make sense to retry this now.

We've done a bunch of cross-compilation work in CI lately and the story is pretty reasonable (rustup target add, cargo build --target and maybe install a target-specific gcc and set CARGO_TARGET_FOO_LINKER). I disagree that it leads to more bugs -- we already cross-compile some of our release binaries.
We could still build 32-bit binaries on CI, but there's a bunch of ARM targets and I'm not sure which ones people care about. And there's still the option of installing a (pretty outdated) version from rustup.
The rustup change you mentioned is unrelated: it was probably uncompressing to memory or allocating too much. We don't, however, pass a compiler option saying "try to OOM on this crate".

We've done a bunch of cross-compilation work in CI lately and the story is pretty reasonable (rustup target add, cargo build --target and maybe install a target-specific gcc and set CARGO_TARGET_FOO_LINKER). I disagree that it leads to more bugs -- we already cross-compile some of our release binaries.
We could still build 32-bit binaries on CI, but there's a bunch of ARM targets and I'm not sure which ones people care about. And there's still the option of installing a (pretty outdated) version from rustup.
The rustup change you mentioned is unrelated: it was probably uncompressing to memory or allocating too much. We don't, however, pass a compiler option saying "try to OOM on this crate".

I'm going to close this as I'm not driving the PocketBeagle project anymore.  If this pops back up, I'll refile a new bug.
Thanks.


When will 1.0 be released?

We're targeting late 2022 for a public Material 3 web release. Check out https://github.com/material-components/material-web/issues/3050#issuecomment-1011447013 for more info!
Closing as a duplicate of #3050


Tabs name is showing incorrect

Hi
This is a a very minor issue. In my system when I open journal page the the Tab shows it as gj . I tried reinstalling the plugin but not luck. I attach the screen shot for the reference. On my other system it works just fine. That is it shows Journals as the tab name.

I'm having the exact same issue although the look and feel is different for me:

Also sometimes, while the tab title remains the same, the page shows up as a regular page for "gj":

It happens to me too, when two tabs are open, closing the one takes me to gj page

Same. After clear cache on 0.10.1, Journal became “gj”.
Btw, good work upstairs!

The upstream seems unresponsive. Meanwhile, you can use this workaround:

View → Toggle Developer Tools.
In the console, copy&paste localStorage.setItem("journalsString", "Journals") and press Enter. Journals here can be replaced by your preferred tab name.


[Accordion] List items () are not contained within  or  parent elements.

What should happen?
Using the example markup (https://foundation.zurb.com/sites/docs/accordion.html) the ul has a role attribute added as does the a attribute and the data-tab-content container. Running an audit on the markup should be ok. (Running an audit using chrome developer tools)
...
What happens instead?
Audit returns the following:

List items (<li>) are not contained within <ul> or <ol> parent elements.

...
Possible Solution

What you need to do is set role="presentation" on all the structures that are not one of the tablist specific roles.

https://stackoverflow.com/a/27475768

...
Test Case and/or Steps to Reproduce (for bugs)

Test Case: https://foundation.zurb.com/sites/docs/accordion.html

How to reproduce:

Open Developer Tools in Chrome
Navigate to the Audits tab
Run Audit for mobile

Context

To improve the experience of reading tabular or list data using assistive technology, like a screen reader.
...
Your Environment

Foundation version(s) used: 6.5.1
Browser(s) name and version(s): Google Chrome Version 75.0.3770.80 (Official Build) (64-bit)
Device, Operating System and version: Macbook Pro, MacOS Mojave 10.14.3
Link to your project: N/A

Checklist

[x] I have read and follow the CONTRIBUTING.md document.
[x] There are no other issues similar to this one.
[x] The issue title and template are correctly filled.

Hi @philiprabbett,
in general they are in a ul, see

Also see https://github.com/zurb/foundation-sites/issues?q=is%3Aissue+is%3Aopen+sort%3Aupdated-desc+label%3Aaccessibility and https://github.com/zurb/foundation-sites/issues/11659
Which has a related PR at https://github.com/zurb/foundation-sites/pull/11681
I am not an a11y expert so I linked @Owlbertz who is an expert in this and who should decide this with the others too.
I am going to close this as duplicate. Please try to check if there is already a related issue or PR when you create an issue.


xterm.js simply exports Terminal so it should be called Terminal.js

I propose we change xterm.js to Terminal.js since all it does is export the Terminal object. Then on the browserify call output it as ./dist/xterm.js.

Once Terminal is fully TS it would make sense to be in a Terminal.ts file like the others, what if we had an xterm.ts as well which simply imported and exported Terminal?

Let me get back to this. I propose closing this along with #374 and always keep a file named xterm.js in the repo, even if it serves only as an entry point for the library.
IMO it's intuitive to have a file named like that, based on the library's name.
Plus, I do not think that there will be much gain by such a rename.

We'll eventually pull out a Terminal object, let's reference it from xterm.ts when we do that.


PS-3454 update to python v10

https://keboola.atlassian.net/browse/PS-3454

The build is working, but I'm going to rebase it so it will need to run again

@joker806 tak vypada ok,  muzu to releasnout?


update node driver name to Equinix Metal from Packet

Node driver name to be updated from Packet to Equinix Metal
present under: Cluster management --> Drivers --> Node Drivers

Reference issue: https://github.com/rancher/rancher/issues/33758

@gaktive I think I should have time to take a look at this one

@rak-phillip go for it!

Not sure why Zube isn't tracking the PR containing the fix... but here it is... https://github.com/rancher/ui/pull/4757

Verified on v2.6-head 1a57856
Packet name is updated to reflect Equinix Metal
Logo is updated as well - displayed when creating equinix Metal cluster


Add license information

Could you add license information to a README or even include COPYING/LICENSE files to clarify usage of this code?

Sorry about that. Added MIT license


feat: underscores in numeric literals

Work to implement and close #14

modified pest grammar to allow for underscores following at least one number in a numeric literal, including floating point and those ending with the size suffixes
added tests as well

Also tested with the following rule
rule test {
  condition:
    2_000 == 2000 and 100KB == 1_00KB and 0o12 == 1_0 and 0x2_1 == 0x21 and 0x31_1 == 7_8_5
}

this is no longer relevant with the parser rewrite i believe, closing


Header view more button

View more button connected to headerRandomizer.js. Links will lead to post in header image.


raw api usage doesn't refresh SNAPSHOTs

A lot of ensime users have been reporting that their servers are not getting updated even after running sbt ensimeConfig. This is the other half of https://github.com/ensime/ensime-sbt/issues/321 and I'm very sorry that I don't have a reproduction for you to look at. I'm sure this used to work in earlier milestone releases.
Next time I am upgrading the server, I'll try to capture as much info as I can (e.g. timestamps before / after).

Answered directly on https://github.com/ensime/ensime-sbt/issues/321.


I want to contribute to conrod

I'd like to work on the tutorial...

Hi @bobgates, that would be a great help! Please see the related issue at PistonDevelopers/conrod#505. Keep in mind that issue might be a little out of date, however that would be the best place to discuss it.

@bobgates Welcome to the team! I've sent you an invitation.
Closing this.


Add support for msys2 on windows

Thanks for the great plugin @kennyp ❤ ! This PR adds windows support when using the msys2  bash and linux tooling.

@dominicletz mind updating .github/workflows/main.yml to include windows as well?

Hm, would love to, but it looks like the asdf-vm/actions/plugin-test@v1 is not windows compatible at all. So someone will have to fix that, or replace the CI steps here with simple bash to test the plugin.


cmd/og: missing package documentation

Command github.com/ohler55/ojg/cmd/oj lacks package documentation.

I'll get that in tonight. The command itself does include documentation with the -h option.

Fixed by #17 (merged).


zoo kcl snapshot on car wheel looks strange

Description
I noticed the snapshot for the Car Wheel was strange on our website. When using zoo kcl snapshot on the car-wheel.kcl file locally, it reliably fails with this message:
Terminal Output
kcl-samples git:(main) zoo kcl snapshot car-wheel/car-wheel.kcl test.png
could not read from WS: Protocol(ResetWithoutClosingHandshake)

    | const spokeThickness = 0.85
    |
    | // Create the wheel center
 20 | const lugBase = startSketchOn('XZ')
    |                 ^ engine: Modeling command failed: websocket closed early
    |   |> circle([0, 0], (lugSpacing + 1.5) / 2, %)
    |   |> extrude(wheelWidth / 20, %)

Screenshots

check your auth, zoo auth status? zoo auth login again

ahh, okay that was the local error, but the now the snapshot I get turns out exactly as shown above, even though it looks fine in the modeling app on 0.25.1

I think this is a @gserena01 question


feat: add workflow for ublue-stable images

Since "latest" bluefin/aurora are broken with fsync 6.11.2 not containing apple_bce module (still investigating), this pull request implements a ublue-stable workflow that builds images weekly (roughly in sync with the ublue github action) from their "stable" tagged images.

cancelling the tests and merging this as it's adding a new workflow (so the tests aren't relevant.


Can't add a proxy device - error says bind: address already in use but container has none assigned ?

Distribution: Ubuntu
Distribution version: 20.04.1
The output of "lxc info" or if that fails:

Kernel version: 5.4.0-42-generic
LXC version: 4.4
LXD version: 4.4
Storage backend in use: dir

# Issue description
I have one LXD container, host and container are ubuntu 20.04
Added several proxy devices to cn_name
lxd config device add cn_name  myproxyXXX proxy ... etc
All was okay at that point.
Later removed all of the proxy devices I had added using
lxc config device remove to remove all proxy devices
I confirmed there are No Proxy devices now install against my cn_name
$ lxc config device show cn_name
{}
But now attempting to add a proxy device again to cn_name I get an error:
lxc config device add cn_name myport443 proxy listen=tcp:<IP_ADDRESS>:443 connect=tcp:<IP_ADDRESS>:443
Error: Failed to start device "myport443": Error occurred when starting proxy device: Error: Failed to listen on <IP_ADDRESS>:443: listen tcp <IP_ADDRESS>:443: bind: address already in use
Again, checked that there were NO Proxy Devices configured for cn_name:
$ lxc config device show cn_name
{}
Reloaded snap.lxd and still same problem?
$ lxc info cn_name --show-log
Name: cn_name
Location: none
Remote: unix://
Architecture: x86_64
Created: 2020/08/08 15:51 UTC
Status: Running
Type: container
Profiles: default
Pid: 61788
Ips:
eth0:	inet	<IP_ADDRESS>	vethaf4121b7
eth0:	inet6	fd42:5daf:90cc:97a6:216:3eff:fe0e:ef83	vethaf4121b7
eth0:	inet6	fe80::216:3eff:fe0e:ef83	vethaf4121b7
lo:	inet	<IP_ADDRESS>
lo:	inet6	::1
Resources:
Processes: 509
Disk usage:
root: 315.08MB
CPU usage:
CPU usage (in seconds): 69
Memory usage:
Memory (current): 917.86MB
Memory (peak): 918.13MB
Network usage:
eth0:
Bytes received: 161.94MB
Bytes sent: 662.38kB
Packets received: 11707
Packets sent: 9642
lo:
Bytes received: 5.18MB
Bytes sent: 5.18MB
Packets received: 5467
Packets sent: 5467
Log:
lxc cn_name<PHONE_NUMBER>5748.804 WARN     cgfsng - cgroups/cgfsng.c:mkdir_eexist_on_last:1153 - File exists - Failed to create directory "/sys/fs/cgroup/cpuset//lxc.monitor.jitsi"
lxc cn_name<PHONE_NUMBER>5748.805 WARN     cgfsng - cgroups/cgfsng.c:mkdir_eexist_on_last:1153 - File exists - Failed to create directory "/sys/fs/cgroup/cpuset//lxc.payload.jitsi"
lxc cn_name<PHONE_NUMBER>5748.811 WARN     cgfsng - cgroups/cgfsng.c:fchowmodat:1573 - No such file or directory - Failed to fchownat(17, memory.oom.group,<PHONE_NUMBER>, 0, AT_EMPTY_PATH | AT_SYMLINK_NOFOLLOW )
$ lxc config show cn_name --expanded
architecture: x86_64
config:
image.architecture: amd64
image.description: ubuntu 20.04 LTS amd64 (release) (20200729)
image.label: release
image.os: ubuntu
image.release: focal
image.serial: "20200729"
image.type: squashfs
image.version: "20.04"
volatile.base_image: b1900a3455dd9ce8d2a7e77f755d72974803f2d7dd0f06a27724a1aa847a9a24
volatile.eth0.host_name: vethaf4121b7
volatile.eth0.hwaddr: 00:16:3e:0e:ef:83
volatile.idmap.base: "0"
volatile.idmap.current: '[{"Isuid":true,"Isgid":false,"Hostid":1000000,"Nsid":0,"Maprange":1000000000},{"Isuid":false,"Isgid":true,"Hostid":1000000,"Nsid":0,"Maprange":1000000000}]'
volatile.idmap.next: '[{"Isuid":true,"Isgid":false,"Hostid":1000000,"Nsid":0,"Maprange":1000000000},{"Isuid":false,"Isgid":true,"Hostid":1000000,"Nsid":0,"Maprange":1000000000}]'
volatile.last_state.idmap: '[{"Isuid":true,"Isgid":false,"Hostid":1000000,"Nsid":0,"Maprange":1000000000},{"Isuid":false,"Isgid":true,"Hostid":1000000,"Nsid":0,"Maprange":1000000000}]'
volatile.last_state.power: RUNNING
devices:
eth0:
name: eth0
network: lxdbr0
type: nic
root:
path: /
pool: default
type: disk
ephemeral: false
profiles:

default
stateful: false
description: ""

This suggests that port 443 on your host is already in use.
Remember that bind defaults to host, so what you're requesting LXD to do here is listen on port 443 of the host and forward any connections to that onto port 443 of <IP_ADDRESS> in the container.

@stgraber
I'll double chk again but as I indicated above I had thse same Device Proxys installed once ok
Removed them
Later tried to reinstall again and got the error
Netstat on the host didn't show any process using the Port and I had no other Containers active at the time.
But I'll double chk everything
Thanks Stephane


Proof of concept: remote collections

Proof of concept as suggested here: https://github.com/tightenco/jigsaw/issues/113
With my ideas from here: https://github.com/tightenco/jigsaw/issues/117
config.php
<?php

return [
    'baseUrl' => '',
    'production' => false,
    'collections' => [
        'posts' => [
            'remote' => function() {
                $posts[] = json_decode(file_get_contents('https://pokeapi.co/api/v2/pokemon/1/'));
                $posts[] = json_decode(file_get_contents('https://pokeapi.co/api/v2/pokemon/4/'));
                $posts[] = json_decode(file_get_contents('https://pokeapi.co/api/v2/pokemon/7/'));

                return array_map(function($v) {
                    return [
                        'extends' => '_layouts.master',
                        'section' => 'body',
                        'filename' => $v->name,
                        'title' => ucfirst($v->name),
                        'category' => $v->types[0]->type->name,
                        'date' => date('Y-m-d'),
                        'content' => "# {$v->name}\n<img src='{$v->sprites->front_default}'>", # refer to layout instead
                    ];
                }, $posts);
            },
            'path' => 'blog/{date|Y}/{filename}',
        ],
    ],
];

It's just a proof of concept, but I could need a little help implementing this properly, because I'm not too familiar with the ORM concept as a whole as of now.

Would love to see this looked into more by the Jigsaw team.
Something similar to this would make it easy to integrate a headless CMS like Contentful & DatoCMS which I feel would take Jigsaw to the next level.

Yes, agreed. I'll dig into this later this week.


[dv,jtag] Change JTAG clock frequency to 24MHz for GLS - fix the code…

… to match to the comments (24MHz for GLS, 50MHz for RTL).
Reverting the frequencies in https://github.com/lowRISC/opentitan/pull/24580 so it will be correct.

Opened a new PR https://github.com/lowRISC/opentitan/pull/24701 with the same changes since I somehow messed up this one.


Add option to over-ride license metadata

This PR fixes #19, providing a build argument that allows for manually specifying the license type in the metadata of the recipe.

Makes sense! Merged, and tagged a new release.


Small Stickers n' Stuff

Description

Added the ability to put small stickers in all windows!
Updated Kotlin & PHP Syntax Highlighting some.
You can now control the max-width & max-height of stickers.
Stickers now change when you hit Apply in the Doki Theme Settings menu.

Motivation and Context

Closes #471
Closes #361
Screenshots (if appropriate):
https://user-images.githubusercontent.com/15972415/147772756-c64a7422-8e63-4f1b-bcd5-6fe7e27c5b45.mp4
Types of changes

[X] Bug fix (non-breaking change which fixes an issue)
[X] New feature (non-breaking change which adds functionality)

Checklist:

[X] My code follows the code style of this project (./gradlew check passes clean).

Tip: If you have lint issues just run ./gradlew :ktlintMainSourceSetFormat.

[X] I updated the version.
[X] I updated the changelog with the new functionality.

I made small mistakes. They're
settings.general.content.dimension.cap.title=Округление по размеру Основного Стикера
settings.general.content.dimension.cap.enable=Использовать Округление по размеру Основного Стикера

Now, they're correct.


Jaren servos

Before issuing a pull request, please see the contributing page.
yo mama
Finished coding da servos

sorry, we have new servo code now


bump Cheshire dependency version to 5.8.0

This PR bumps Cheshire version to the latest stable 5.8.0.

Thank you!


windows join cluster

how make windows emqtt node join the cluster? in linux,emqttd_ctl,in windows what I do?

for the ./bin/emqttd_ctl CTL command can'n work on window (We will try to fix this issue later)


quartodoc interlinks should validate the version of the interlinks filter being used

Currently, the quartodoc interlinks command doesn't check anything about the interlinks quarto filter installed. However, features like quartodoc interlinks --fast cannot run on old extension versions.
We should do two things:

validate the filter version (e.g. that it will work correctly)
orchestrate the installation of the filter

It's okay for now if we orchestrate by telling the user what to do. But let's investigate what managing / installing quarto extensions via the quartodoc CLI commands etc.. might look like.
More on validating
There are some weird aspects of how extensions get put in _extensions that'll need to be researched. For example, from the quartodoc/docs folder, these do different things:

quarto add ..: creates _extensions/interlinks
quarto add machow/quartodoc: creates _extensions/machow/interlinks

@cscheid, any idea how a program might check for a filter in the _extensions folder?
If the interlinks filter has this _extension.yml:
title: Interlinks
author: Michael Chow
version: 1.1.0
quarto-required: ">=1.2.0"
contributes:
  filters:
    - interlinks.lua

And it's path is...
_extensions/machow/interlinks/_extension.yml

What is used to determine the name? The final folder name (the "interlinks" in "machow/interlinks")?

A better solution is to ship the first class lua filters (e.g. the interlinks filter) with quartodoc and have quartodoc build install (copies) the filters to the _extension directory.
This fully resolves the conflict(s) and would allow us to use lua filters in quartodoc without the reservation that they need to be installed and managed by the user.
Then only 3rd-party filters would be managed on the CLI by the user. quartodoc would also check them for compatibility.

Shipping with quartodoc seems like a great way to orchestrate installing the filters! One weird hitch is that I'm not sure how we could include it in the quartodoc package? Basically, quarto requires the extension to live in a top-level _extensions folder. So we'd have to symlink it, or copy it in before building the package or something? Any ideas?

Basically, quarto requires the extension to live in a top-level _extensions folder. So we'd have to symlink it, or copy it in before building the package or something? Any ideas?

Yes we would copy them to project/docs/_extensions. symlinking can have weird edge-cases!
We can claim the quartodoc namespace for all of quartodoc's filters. e.g.
project/docs/_extensions/quartodoc/interlinks/...
project/docs/_extensions/quartodoc/another-filter/...
project/docs/_extensions/quartodoc/and-another-filter/...
...

So quartodoc build would do the equivalent of
rm -rf project/docs/_extensions/quartodoc
cp -R /path/to/quartodoc/_extensions/quartodoc project/docs/_extensions/quartodoc


Expose representation order on defendant

What
Link to story
Expose representation order on defendant post linking
Checklist
Before you ask people to review this PR:

[ ] Tests and linters should be passing
[ ] Github should not be reporting conflicts; you should have recently run git rebase master.
[ ] Avoid mixing whitespace changes with code changes in the same commit. These make diffs harder to read and conflicts more likely.
[ ] You should have looked at the diff against master and ensured that nothing unexpected is included in your changes.
[ ] You should have checked that the commit messages say why the change was made.

superseded by https://github.com/ministryofjustice/laa-court-data-adaptor/pull/153


Logo

Logo ideas via DALLE-2 (prompts: https://gist.github.com/lmmx/1fd4b848cee99f8aac17b0c614ebc0bf)
1 (my favourite: “cute factory building with trees growing out of its chimneys, logo, digital art, drawing, in a dark circle as the background“)

2 (I like the pipes in a cool loop-like network resembling a diagram, cued by “poset diagram”)

(Midjourney was not good at this)


Use API versioning for HTTP-based services

From @captainsafia
See https://github.com/dotnet/aspnet-api-versioning

Hey @captainsafia! Great to hear from you. Congrats on the release. Hope all is well.
I'd love to help out with this. If there are any specific requirement, features, or behaviors that need to be showcased, please call them out. I ran into a few snags building the net8.0 TFM, but I think I've got them resolved and I expect to have a .NET 8 release by EOW. Do you have a specific deadline?
This would be great way to highlight one of the most under-utilized features, which is the API version-aware HttpClient. 😉
https://github.com/dotnet/aspnet-api-versioning/wiki/Versioned-Clients
The Asp.Versioning.Http.Client package and features have been around for about two years, but they don't get used a whole lot - yet. It wires things up with DI extensions and IHttpClientFactory, resulting in the rest of the code not knowing or understanding which API version it's talking to. The IApiVersionWriter is the reciprocal of IApiVersionReader and will automatically add the API version to the query string, header, media type, or even the request URL. 😄
For example:
var response = await client.GetAsync("api/order/42"); // GET api/order/42?api-version=1.0

There some additional interesting features if the server reports more information, such as:

Is an API version newer than the one you are talking to available?
Is the API version you are talking to deprecated?
If you're talking to a deprecated API version, when will to be permanently sunset?

This all abstracted behind IApiNotification with the default implementation plumbing through ILogger, but this would be a good opportunity to exercise those capabilities and see if any additional improvements are warranted.
Thanks for reaching out. Let me know.

but I think I've got them resolved and I expect to have a .NET 8 release by EOW. Do you have a specific deadline?

No specific deadline! Integrating this after the .NET 8 release of the package is out should be sufficient.

This would be great way to highlight one of the most under-utilized features, which is the API version-aware HttpClient.

I think it would be interesting to try showcasing the versioned HTTP client here, if we can get it wired up with the authentication and service discovery configuration on our current setup.

There some additional interesting features if the server reports more information, such as:

Interesting features. At the moment, we only have a single version of the API so there's not much to maintain with regard to different versions.
I think we can start with a basic versioning implementation on the APIs + versioned HTTP client for this.


"TÂRGU BUJOR" is listed in the drop-down menu

Description:
"TÂRGU BUJOR" is listed in the drop-down menu alongside its corresponding county and commune, according to the law
Precondition:
The website is up an running.

Step 1
Type "TÂRGU BUJOR" in the search bar.

Expected results
The location is listed in the drop-down menu as "Oraș TÂRGU BUJOR, GALAȚI".

Step 2
Press "x" button.

Expected results
The location was deleted from the search bar.


[WebToolsE2E][Aspire] 9.0 P2 build is branded as preview.1 instead of preview.2

INSTALL STEPS
Clean machine: Win11 x64 23h2 ENU

Install SDK 9.0 Preview 2

Apply feed for SDK 9.0 P2

Install Aspire SDK 9.0 P2 workload

Download installLatest90p2FromReleaseBranch.ps1 to your Downloads folder
Open/Run Powershell as an administrator, change the execution policy to run the script
Set-ExecutionPolicy -ExecutionPolicy Unrestricted -Scope LocalMachine
Run the installLatest90p2FromReleaseBranch.ps1 script
powershell.exe "C:\Users\<user-name>\Downloads\installLatest90p2FromReleaseBranch.ps1"

ACTUAL
The Aspire version is 9.0.0-preview.1.24160.5
EXPECTED
The Aspire version should be branded as 9.0.0-preview.2

The milestone should be '8.0 preview 4' and this issue needs to be fixed before this week's Tuesday release. @joperezr

Yes, I'll fix this today.

Fixed via #2784.


feature: clickable path aliases

Goal
The goal of this PR is to provide a better developer experience by enabling VS Code and other editors to read the aliases we have setup so we can do things like:

command+click a path to go to it's file
right click and be able to go to definition
and more

Nice 😎 looks good to me!
Changing the base branch to dev so that we can bump the version and prep a release when we're ready.

Thank you!
On Tue, May 23, 2023 at 1:23 PM Andrew Rubin @.***>
wrote:

@.**** approved this pull request.
—
Reply to this email directly, view it on GitHub
https://github.com/wethegit/corgi/pull/33#pullrequestreview-1440508252,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAO5UYDOHPLYPD3EXML3P2LXHUME5ANCNFSM6AAAAAAYMMSL3I
.
You are receiving this because you were assigned.Message ID:
@.***>


fix: updated js-gardener

Pull Request Test Coverage Report for Build 111

1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build 107:
0.0%

Covered Lines:
40

Relevant Lines:
40

💛  - Coveralls

Pull Request Test Coverage Report for Build 111

1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build 107:
0.0%

Covered Lines:
40

Relevant Lines:
40

💛  - Coveralls


Getting Global CSS cannot be imported from within node_modules  error

Hi. I'm using a fresh NextJS 13.2.1 with Tailwind and integrated the Sanity Studio V3 in /pages directory. They're working fine. I installed this plugin but it's getting Global CSS cannot be imported from within node_modules error.

sanity.config.ts:
import { deskTool } from 'sanity/desk';
import { visionTool } from '@sanity/vision';
import { codeInput } from '@sanity/code-input';
import { latexInput } from 'sanity-plugin-latex-input';

import { schemaTypes } from '@/schemas/index';

export const projectId = process.env.NEXT_PUBLIC_SANITY_PROJECT_ID!;
export const dataset = process.env.NEXT_PUBLIC_SANITY_DATASET!;

export default defineConfig({
  basePath: '/studio',
  projectId,
  dataset,

  plugins: [deskTool(), visionTool(), codeInput(), latexInput()],

  schema: {
    types: schemaTypes,
  },
});

Hello, any updates?

I'm using NextJS as well and I'm facing the same issue here.
is there any workaround to make it work?
This is the suggested solution provided by NextJS:

Hey! You can use my fork: https://github.com/filipesmedeiros/latex-input
The only thing it does is fix this issue. It removes the CSS import from the component itself. Then you have to import it yourself at the app level (e.g. _app.tsx or layout.tsx)

Hey @filipesmedeiros, could you elaborate on how you removed the CSS import from the component itself? In particular, what do you mean by component?


Handle 500/400 iFrame errors in a better way

Is your feature request related to a problem? Please describe.
When using chart as iFrame it is not posible for the client app to verify the iFrame content (CORS etc)
When an iFrame chart for superset fails into 500/400 etc for some reason it looks real bad for the user.
Describe the solution you'd like
A default text and/or an img configured by developer to show/return when request from superset api fails.
Additional context
Screenshot as is today: (500 error)

bump


Replace nil check with len()

As the slice is no longer a pointer, checking len() works in both cases:

len(nil-slice) == 0
len(empty-slice) == 0

See: https://go.dev/play/p/ah-hRMCmEWk

Codecov Report
Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 38.80%. Comparing base (3eab133) to head (dc7dc81).
Report is 2 commits behind head on main.

Files with missing lines
Patch %
Lines

pkg/aws/aws.go
0.00%
1 Missing :warning:

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #310   +/-   ##
=======================================
  Coverage   38.80%   38.80%
=======================================
  Files          22       22
  Lines        1742     1742
=======================================
  Hits          676      676
  Misses       1020     1020
  Partials       46       46

Files with missing lines
Coverage Δ

pkg/aws/aws.go
5.05% <0.00%> (ø)


Any plans or suggestions to migrating to OWLv2?

OWLv2 seems to be much better than v1.
Is it possible to migrate to version 2 by just making minor changes to the owl_predictor.py file?

Did you have the solution for this yet?


Uninitialized memory should not be depended on

With the new VecMaps refactor, we ran into a bug where previously a vector of booleans had just been used without initialization, and now this errors because accessing something uninitialized now returns nothing instead of something random.
After copy_parts!, the orientation array is uninitialized: https://github.com/AlgebraicJulia/CombinatorialSpaces.jl/blob/8480caa25baf7fae18478ab45410417cbbb6af1e/src/DiscreteExteriorCalculus.jl#L340, and then this is accessed here: https://github.com/AlgebraicJulia/CombinatorialSpaces.jl/blob/8480caa25baf7fae18478ab45410417cbbb6af1e/src/DiscreteExteriorCalculus.jl#L178.
The error in action: https://github.com/AlgebraicJulia/Catlab.jl/actions/runs/3624910884/jobs/6112385806

This was closed a while back by PR #56


[Feature Request]: Reminders & Notifications

Is there an existing issue for this?

[X] I have searched the existing issues

Feature Description
Automated reminders for eligible donors and notifications about urgent donation needs, ensuring timely contributions.
Use Case
Notifies donors when they are eligible to donate again and alerts them about emergencies requiring immediate donations.
Benefits
Improves donor participation, ensures faster responses to urgent needs, and enhances the efficiency of donation drives.
Add ScreenShots
No response
Priority
High
Record

[X] I have read the Contributing Guidelines
[X] I'm a GSSOC Ext'24 contributor
[X] I'm a Hacktoberfest 2024 contributor
[X] I have starred the repository

I want to give this a try.

@may-tas What's your status?
Last few days are left

I was working on it, but was having some trouble while setting up the backend.
I'll update you on the issue by tomorrow EOD.

Status?

Sorry for the delay I'm still trying to do this.

@may-tas
As deadline will approching soon....
If you want level up your score on leaderboard or want to make contribution
btw Happy New Year && Happy Diwali

Sorry, wasn't able to complete this as endsems exams started in my college.
Happy Diwali !


Feature: Git Integration

Resolved / Related Issues

[x] Were these changes approved in an issue or discussion with the project maintainers? In order to prevent extra work, feature requests and changes to the codebase must be approved before the pull request will be reviewed. This prevents extra work for the contributors and maintainers.
Related #11014

Validation
How did you test these changes?

[x] Did you build the app and test your changes?
[ ] Did you check for accessibility? You can use Accessibility Insights for this.
[ ] Did you remove any strings from the en-us resource file?

[ ] Did you search the solution to see if the string is still being used?

[x] Did you implement any design changes to an existing feature?

[x] Was this change approved?

[ ] Are there any other steps that were used to validate these changes?

Screenshots (optional)

I think we need to finalize the requirements before reviewing this.

Requirements:

Following things should be showed even when you're exploring git subfolders.

Show the current branch name on status bar
Show Push button on status bar
Show Pull button on status bar
Show Sync button on status bar
Show Add Branch button on status bar
Show Checkout Branch button on status bar

Requirements:

Following things should be showed even when you're exploring git subfolders.

Show the current branch name on status bar
Show Push button on status bar
Show Pull button on status bar
Show Sync button on status bar
Show Add Branch button on status bar
Show Checkout Branch button on status bar

They are already shown in subfolders, I just need to make them work
(use user's credentials and add a menu for checkout).
I think that instead of a Checkout button, we might show that menu when the user clicks on the branch name (As in VS)

Let's move the discussion to the issue

At the moment, if you change the active branch using an external app (such as GitHub Desktop) you have to manually update the page. I'll try to find a way to fix that

Now the branch name is auto updated

@gave92 can you review the changes to ItemViewModel?

How to activate this ? using <IP_ADDRESS> and also checked to on my local repo
commit 6d7c29d4037362602f2146cb0b9fab504999d18b (HEAD -> main, origin/main, origin/HEAD)
Author: dependabot[bot]<EMAIL_ADDRESS>Date:   Fri Jun 2 01:59:28 2023 -0400

and it did not show up? Cannot see branch name at the bottom right as in first ss on this pr?
https://user-images.githubusercontent.com/102259289/232000382-0787e9f3-c269-424e-887b-67b47eb1cab0.png

@lapaz17 thank you for your interest, the git integration is currently available in the preview version https://files.community/download. We're adding some more features to the integration, but it'll be good to hear your first impressions once you start using it.


Modify as_json serializer to validate attributes exposed via openapi.json

Validate all attributes as exposed in openapi.json
Tests are all updated to no longer expect attributes not exposed
Added dates to openapi.json as were expected in a number of specs.
JIRA: https://projects.engineering.redhat.com/browse/SSP-95

@syncrou We'll want to apply the same changes to https://github.com/ManageIQ/approval-api after we get this merged.

@gmcculloug JIRA: https://projects.engineering.redhat.com/browse/SSP-476

@mkanoor this should be all set


Azure OpenAI Assistants API support

This PR adds support for the Azure OpenAI Assistants API. Fixes #239
    <deep-chat
      id="chat-element"
      directConnection='{
        "azureOpenAI": {
          "key": "YOUR_AZURE_KEY",
          "validateKeyProperty": true,
          "azureConfig": {
            "endpoint": "https://YOUR_RESOURCE_NAME.openai.azure.com",
            "version": "2024-05-01-preview"
          },
          "assistant": {
            "new_assistant": {
              "model": "gpt-4o",
              "name": "Test Azure Assistant",
              "description": "An assistant to test Azure integration into deep-chat",
              "instructions": "You are an assistant. Your instructions are to help test the integration of Azure with deep-chat",
              "tools": [
                { "type": "code_interpreter" },
                { "type": "file_search" }
              ]
            },
            "files_tool_type": "code_interpreter"
          }
        }
      }'
    ></deep-chat>

Hey @bruffridge.
I can see you were busy. Thankyou for raising this PR. I am unfortunately just about to leave for a trip due to a long weekend here in Japan, so my availability might be a little limited. But I'll take a look at this PR.
Having briefly looked at the code, a lot of it appears to be very similar to the existing OpenAIChat/OpenAIAssistant code (which is great), and I am wondering if instead of repeating the code - we could try to reuse the existing code by extending it and have Azure be inside concrete classes. This way we can keep the addition of new code to a minimum and the overall bundle size smaller.
I know this may sound a little complicated and I can probably do it myself, if you could instead perhaps tell me the areas where you really had to make explicit changes for Azure (instead of copying) and I'll minimize the code myself.
Thanks for the PR again and apologies for the delays in everything as I have just moved countries and am playing catchup with all of my GitHub projects.

Hey @bruffridge.
I have attempted to edit the code in your repository but was unable to due to me not having writer permissions.
Your code is really nice, but the main problem is what I had mentioned in the previous comment - a lot of it is repeated and can be minimized by extending classes.
Due to me not having much free time recently I did not hesitate and start making the required changes right away (based on the code in your PR). The necessary changes for the basic OpenAI Chat via Azure are in the following commit.
I have made a small change to how the interface is exposed. Instead of creating an entirely new service, I placed the OpenAI Chat inside the Azure domain. The new Azure TS interface can be found here.
This is what it looks like:
type URLDetails = {
  endpoint: string;
  version: string;
  deploymentId: string;
};

export interface AzureOpenAI {
  urlDetails: URLDetails;
  chat?: true | OpenAIChat;
  assistant?: true | OpenAIAssistant;
}

export interface Azure {
  openAI?: AzureOpenAI;
  ...

I am going to do the Assistants API on another day and publish it for you to try it.
Apologies for not using this PR which takes away the credit of your work, but the new code would have been possible without what you have done. So thankyou very much for that.
Because this PR is not going to be used I will be closing it.
Thankyou!

Hi @bruffridge.
I have not published this change yet, my apologies. The reason for this is because my local codebase has a lot of experimental code which I don't want to publish and I am currently working on refactoring the assistants logic. I should have this all done pretty soon and will update you in this PR on the latest.
Thankyou!

Hi @bruffridge.
I have released a new deep-chat-dev and deep-chat-react-dev package version 9.0.197. This includes all of the refactored methods to access OpenAI API via Azure.
The new azure interface looks as follows:
type URLDetails = {
  endpoint: string;
  version: string;
  deploymentId: string;
};

export interface AzureOpenAI {
  urlDetails: URLDetails;
  chat?: true | OpenAIChat;
  assistant?: true | OpenAIAssistant;
}

export interface Azure {
  openAI?: AzureOpenAI;
  textToSpeech?: AzureRegion & AzureTextToSpeechConfig;
  ...
}

The chat and assistant properties are exactly the same as the OpenAI chat and assistant properties.
The way you would use this interface would be as follows:
directConnection = {
  azure: {
    openAI: {
      chat: true,
      urlDetails: {
        deploymentId: 'azure-deployment-id',
        endpoint: 'azure-endpoint',
        version: 'azure-resource-version',
      }
    }
  }
}

Let me know if you have any issues!

I updated to deep-chat-dev 9.0.198 but it didn't work. When I enter the API key into the text input it tries to validate the key by sending a request to https://api.openai.com/v1/models instead of the Azure endpoint. I tried putting the key and validateKeyProperty up a level in the azure object but that didn't work either.
directConnection={{
    azure: {
      openAI: {
        key: key,
        validateKeyProperty: key ? false : true,
        assistant: key ? {
          assistant_id: asstId,
          new_assistant: asstConfig,
          thread_id: threadId,
          load_thread_history: false,
          files_tool_type: fileTools,
          function_handler: handleFuncCalling
        } : null,
        urlDetails: {
          deploymentId: 'gpt-4o',
          endpoint: 'https://RESOURCE_NAME.openai.azure.com',
          version: '2024-08-01-preview'
        }
      }
    }
  }}

I'm shooting in the dark because I haven't done any debugging, but did you remember that the authorization mechanism differs between azure and openai?
2. API_KEY header change
Another difference is instead of setting the api-key as  Authorization: Bearer OPENAI_API_KEY header, in Azure it is set as a custom api-key header
curl https://YOUR_RESOURCE_NAME.openai.azure.com/openai/threads \
  -H "Content-Type: application/json" \
  -H "api-key: $AZURE_OPENAI_API_KEY" \
  -d ''

Hey!
Apologies for the late reply! I merged your newest PR. Do the new code changes take care of the issues above? If not, please let me know! Thankyou!!


Post GSoC: cleanup, refactoring, docs

First of all: I need to apologize for my insufficient participation in your work during summer.
Being one of initial proposal authors and SciRuby's dedicated code qulaity mentor, I've should provide you with much more help and suggestions. And I'd definitely do that, if not for the fact that I've fighted with severe clinical depression this summer.
But now I feel like being back to life (as you probably 've noticed by much more of dumb suggestions and discussions!) and are excited by the project. Yet I have a lot of suggestions on small things, and on how to make project more accessible to newcomers (e.g. docs and tutorials).
As 3 days before GSoC end is a bit :trollface: late for those changes, I'd like to work together on the project cleanup and enchancement after GSoC would be finished and the dust will settle. (Of course, this means that we are gratefully accepting your summer work!)
If you are willing to work on a project after GSoC (which I am really hoping you are, but of course can't force or even ask you, if your plans differ), let's make this issue a "communication hub" for those further encancements?

@zverok , It was a great summer and I really enjoy working with SciRuby. I will surely contribute to daru and daru-view after the GSoC also.
Your experience and suggestions are always helpful. I hope after cleanup  & enhancement daru-view,  will be very good gem for the Ruby Developers.

It definitely will (and in fact already is)!
OK, good, then expect some list of suggestions and ideas right in this issue in upcoming month.

Suggestions are always welcome :)


Update object using spread functionality was broken

functionality was broken in commit 171b655e8abfa368f4a6c7c2b1352ea04375ae7f
Now code like this:
/**
 * @type {{a: number, b: number}}
 */
let x = {a: 1, b: 2}

x = {...x, b: 3}

produce warnings:
index.js:6: WARNING - assignment
found   : Object
required: {a: number, b: number}
missing : [a,b]
mismatch: []
	x = {...x, b: 3}
	^^^^^^^^^^^^^^^^

This was an intentional change.
Although in this case the compiler can safely determine what properties are on the new value of x, in general this is not true. We realized that the type checking we had initially implemented for Object rest
could be wrong in potentially dangerous ways due to the way rest and spread are defined to behave.

only 'own' properties are copied
getters / setters are not invoked

Also, all of the useful code patterns we could think of could lead to code where the compiler would not have sufficient type information ensure correctness.
We decided it was safer to always infer the result of object rest/spread to be just Object, so users will at least be made aware that the compiler cannot type check it correctly.
Workaround is to add a cast.

FYI: In TypeScript, the code passes type checking:
https://www.typescriptlang.org/play/index.html#src=let x %3D {a%3A 1%2C b%3A 2}
x %3D {...x%2C b%3A 3}

I think the inference is not perfect but very useful in the real world.


Improved clientId as scope error handling

Yes, and to provide better feedback to developer. Previously, we just silently removed it, so the request would always fail with declines scopes error.


Revert Fix evc_setup_package name

Describe your changes
Revert the last commit.
Issue ticket number and link
Checklist before requesting a review

[x] I have performed a self-review of my code
[ ] I have made corresponding changes to the documentation
[x] I read the contribution documentation and made sure that my changes meet its requirements

No longer relavant due to this PR #10!


Issue 376

Coverage decreased (-2.2%) to 82.578% when pulling 7daee9ded0d6343d1eed0aae0d8fa942883d7233 on issue-376 into 3a000d69d9c93596ee2fe0f80d2acee063fb7879 on master.

@homu r+

:pushpin: Commit 7daee9d has been approved by kbknapp

:zap: Test exempted - status


ReactJs Web client + Ruby-on-Rails API server - Authentication with facebook & google_oauth2 using Devise + OmniAuth

Configuration

Provider Gem: omniauth 1.9.0
Other Gems: devise 4.6.2 + omniauth-facebook 5.0.0 + omniauth-google-oauth2 0.7.0
Ruby Version: 2.6.2
Framework: rails 6.0.0.rc2
Platform: ``

Expected Behavior
Authentication to facebook or google_oauth2 should succeed (returning request.env['omniauth.auth']).
I followed the Devise guide to integrate with Omniauth (here), taking into account Omniauth's recommendations when integrating into a Rails API (here).
Actual Behavior
Client-side, I am able to connect to facebook or google_oauth2 with OmniAuth. But server-side,  but I get an Authentication failure!
In the rails console, I have different error messages for Facebook and for Google as I request different authentication strategies, using One-time Code Flow (Hybrid Authentication) with Google.

For Facebook:

ERROR -- omniauth: (facebook) Authentication failure! no_authorization_code: OmniAuth::Strategies::Facebook::NoAuthorizationCodeError, must pass either a `code` (via URL or by an `fbsr_XXX` signed request cookie)

For Google:

ERROR -- omniauth: (google_oauth2) Authentication failure! csrf_detected: OmniAuth::Strategies::OAuth2::CallbackError, csrf_detected | CSRF detected

I found kind of a workaround by adding provider_ignores_state: true in the Devise initializer but it doesn't seem to be secure...
config/initializers/devise.rb
  config.omniauth :google_oauth2, google_app_id, google_app_secret, scope: 'email,public_profile', provider_ignores_state: true

Steps to Reproduce
config/initializers/devise.rb
  # ==> OmniAuth
  # Add a new OmniAuth provider. Check the wiki for more information on setting
  # up on your models and hooks.
  facebook_app_id = Rails.application.credentials.apis[:facebook][:oauth2][:app_id]
  facebook_app_secret = Rails.application.credentials.apis[:facebook][:oauth2][:app_secret]
  google_app_id = Rails.application.credentials.apis[:google][:oauth2][:app_id]
  google_app_secret = Rails.application.credentials.apis[:google][:oauth2][:app_secret]

  config.omniauth :facebook, facebook_app_id, facebook_app_secret, scope: 'email,public_profile'
  config.omniauth :google_oauth2, google_app_id, google_app_secret, scope: 'email,public_profile'

app/config/application.rb
    # To integrate OmniAuth into a Rails API.
    config.session_store :cookie_store, key: '_interslice_session'
    config.middleware.use ActionDispatch::Cookies
    config.middleware.use ActionDispatch::Session::CookieStore, config.session_options

app/models/user.rb
  devise :database_authenticatable, :registerable,
         :recoverable, :rememberable, :validatable,
         :omniauthable, omniauth_providers: %i[facebook google_oauth2]

config/routes.rb
  devise_for :users,
             only: :omniauth_callbacks,
             controllers: { omniauth_callbacks: 'v1/omniauth_callbacks' }

app/controllers/v1/omniauth_callbacks_controller.rb
module V1
  class OmniauthCallbacksController < Devise::OmniauthCallbacksController
    def facebook
      generic_callback
    end

    def google_oauth2
      generic_callback
    end

    private

    def generic_callback
      auth = request.env['omniauth.auth']

      user = User.from_omniauth(auth)

      if user.persisted?
        return serialize_response(
          resource: user,
          options: response_options(user_id: user.id),
          status: :created
        )
      end

      # Raise custom 'Unauthenticated' error message.
      raise Errors::Unauthenticated.new(message: 'Invalid social credentials')
    end
  end
end

Hi! how did you manage to use React to connect with OmniAuth?

As it did not work I switch to using Auth0 (and they have a nice tuto for Rails API / React client...

As it did not work I switch to using Auth0 (and they have a nice tuto for Rails API / React client...

Im trying to do:
React Client  login button -> Rails API with omniauth so it will create users after successful auth. such a pain in the a$$ trying to get it work 😭

@errawn Any progress on your end? I am looking into this too.

Hello @YassineDM, did you manage to get this bug fixed?

Any luck here guys?

Try this, It helped me. https://github.com/omniauth/omniauth/wiki/Resolving-CVE-2015-9284

Try this, It helped me. https://github.com/omniauth/omniauth/wiki/Resolving-CVE-2015-9284


Make some new Kestrel types internal

There were some new public types added to Kestrel between 2.0 and 2.1 that don’t need to be exposed. We should make them internal to alleviate back compat concerns going forward.

@muratg This is already approved by the ship room, right? If so, I can merge #2543 once @davidfowl approves the PR.


Shader defs can now have a value

Objective

shaders defs can now have a bool or int value
#if SHADER_DEF == 3

ok if SHADER_DEF is defined, has the correct type and is equal

#if SHADER_DEF != 3

ok if SHADER_DEF is not defined, or defined, correct type and not equal

#SHADER_DEF

will be replaced by the value in the shader code

Migration Guide

replace shader_defs.push(String::from("NAME")); by shader_defs.push(String::from("NAME").into());
if you used shader def NO_STORAGE_BUFFERS_SUPPORT, check how AVAILABLE_STORAGE_BUFFER_BINDINGS is now used in Bevy default shaders

How will this feature be documented ? As the syntax is proper to bevy, even though resembling what's existing in other solutions, I think documentation and discoverability will be very important :)

Examples and Bevy book.
If this get merged, I'll continue on adding features to shader defs, the two I have planned is being able to define a shader def from inside a shader, and being able to have a function as a shader def. They will both be somewhat more complicated, so I'll do it small PR by small PR. But they will also have a lot more added value and it will be quite easier to show how this can be used.

Very nice work! I love the changes / they resolved all of my comments.

bors r+

bors retry


Version 1.14.0 ?

According to https://search.maven.org/artifact/io.sundr/builder-annotations/1.14.0/jar there's a version 1.14.0, but it doesn't really exist because https://repo1.maven.org/maven2/io/sundr/builder-annotations/1.14.0/ gives 404.
What happened to 1.14.0 and is 0.15.1 the most recent version?

The 1.14.0 was accidentally released instead of 0.14.0.
The artifacts have been removed from maven central, and I think that they shouldn't appear in search.maven.org.

I would trust the badge listed on the main github page when it comes to the latest release.

Crap, that's not accurate either.

Nothing to do here, badge currently shows the correct version and artifacts have been removed from central


Use Time series split for while doing lgm.cv

I tried this with this issue - https://github.com/microsoft/LightGBM/issues/2984, still I can't run my model successfully here as it is throwing a value error. Anyone can share some insights on how to make it work.?

Hey @rachitagrwl !
You are passing wrong argument (nfold). You should pass folds one.

Hi @StrikerRUS Thanks for coming back but error is still intact.

Sorry, probably it was unclear as you have folds variable in you code. But I meant you should pass either tss or folds via folds parameter of cv() function.
lgb.cv(params, train_data, folds=tss, verbose_eval=200, metrics=['mae'])


support check licences as pre-commit hook

I tried to get this going:
https://github.com/jmtatsch/pip-licenses/blob/master/.pre-commit-hooks.yaml
and called from pre-commit like this:
-   repo: https://github.com/jmtatsch/pip-licenses
    rev: 0b6176619a8314c88e7817e3b51c59b1ffd4943a
    hooks:
    -   id: update-pip-licenses
        additional_dependencies: [prettytable]

However, the dependency prettytable doesn't seem to get installed correctly.
An unexpected error has occurred: CalledProcessError: command: ('/home/tatsch/.cache/pre-commit/repoijlcclt_/py_env-python3.10/bin/python', '-mpip', 'install', '.', 'prettytable')
return code: 1
stdout:
    Processing /home/tatsch/.cache/pre-commit/repoijlcclt_
      Preparing metadata (setup.py): started
      Preparing metadata (setup.py): finished with status 'error'
stderr:
      error: subprocess-exited-with-error

      × python setup.py egg_info did not run successfully.
      │ exit code: 1
      ╰─> [8 lines of output]
          Traceback (most recent call last):
            File "<string>", line 2, in <module>
            File "<pip-setuptools-caller>", line 34, in <module>
            File "/home/tatsch/.cache/pre-commit/repoijlcclt_/setup.py", line 34, in <module>
              from piplicenses import __author__ as AUTHOR
            File "/home/tatsch/.cache/pre-commit/repoijlcclt_/piplicenses.py", line 43, in <module>
              from prettytable import ALL as RULE_ALL
          ModuleNotFoundError: No module named 'prettytable'
          [end of output]

      note: This error originates from a subprocess, and is likely not a problem with pip.
    error: metadata-generation-failed

    × Encountered error while generating package metadata.
    ╰─> See above for output.

    note: This is an issue with the package mentioned above, not pip.
    hint: See above for details.
Check the log at /home/tatsch/.cache/pre-commit/pre-commit.log

Does anyone have an idea why this doesn't work?

Ok, got a step further.
It runs pip-licenses but produces an empty output file.
Maybe because everything is running in a separated pre-commit environment?


[Design Component] Update the default state for components

With the recent color changes, we need to do the following:

[ ] Identify the components that should use "basic" as the default color
[ ] Change the default state (if a user adds a new component it should use the basic color)
[ ] Find a good solution to update all existing components (automatically)
[ ] Communicate the change via a slack channel

[ ] Chip
[ ] Radio Button
[ ] Checkbox
[ ] Toggle
[ ] Tabs
[ ] Tag

Tag : If you change the default colour, many mock-ups will be affected. What can you do? (cc @JeremiasUX @lauragautheron )

Tag: We can change the colour but everyone should be warned not to update unless it's polaris components.
Same for the tabs

I don't understand sorry : if the component changes in production, is it a problem if it changes everywhere ?

@lauragautheron If we change the component, all the tag with main (primary) colour will become 'accent' (purple) like the tag 'à la une', 'nouveau', 'profil recommendé' ,etc....
We'll be saddling designers with an additional debt, as they'll have to redo everything manually.

Tag will be solved in this issue: [Tag] Resolve the color issues#1310


Added Fix Invalid Cell and Clear All action to GridMap

Added option to fix invalid cells in GridMap just like TileMap.
Also added an option to Clear all cells of GridMap, this fixes/resolve #37124
Both actions are working properly, even with undo-redo.

What if you want to swap the MeshLibrary to another, compatible one (i.e. different meshes but with the same logical use at the same IDs)? I do this a lot with TileMaps (see e.g. https://github.com/KOBUGE-Games/jetpaca where different TileSets use the exact same layout).

Then that would be a problem. Maybe we can clear the internal data only when mesh library is empty?

What if you want to swap the MeshLibrary to another, compatible one (i.e. different meshes but with the same logical use at the same IDs)? I do this a lot with TileMaps (see e.g. https://github.com/KOBUGE-Games/jetpaca where different TileSets use the exact same layout).

Would it be possible to have two options? As there can be two scenarios:
A) Updating to a compatible library, like you said
B) Changing library to a different one with incompatibles IDs - in this case not removing old references would make a mess of a map (an example would be having library with new tiles or missing ones)

@Alastor01 that would cause problem when user will undo the mesh library change. The cell data will remain empty even after undoing it.
One of the solution is to adapt it like TileMap :
TileMap has function to fix invalid tiles.

I have implemented the same functionality and also added an option to clear all cells.

Things are working properly even undo-redo.
@akien-mga what are your opinions? Should I open a new PR for that or force push to this one?

@simpuid That's interesting, haven't used 2D part of the engine for ages.
This looks great, thank you!

Sorry for the delay reviewing this. The feature seems to make sense, it should maybe be synced with how this is handled in the TileMap editor in 4.0 to be consistent (which is also able to display invalid cells in the viewport).


Switch from IAM to ACM certificates

This does for our CloudFront distributions what aptible/pancake#124 did for our ELB certificate configurations, moving from IAM to ACM so that we can deprecate all IAM certificates (except for our one production EV certificate). The first two commits are just cleanup; see 99b0fd7 for relevant changes.

I used this to set up the Dashboard for the brower testing Dashboard. Worked great.

(Replaced by aptible/dashboard-private#187.)


Docker compose uses service names as image names which causes namespace conflicts between projects

Not really an issue anymore


Remove Vehicle Type from AgentInterface

Is your feature request related to a problem? Please describe.
It is not the case that the vehicle that the agent will take over is always the same as is provided in the agent interface. The pre-defined type in the agent interface then conflicts with the type of the assumed vehicle on capture.
Describe the solution you'd like
The vehicle type should be removed from the agent interface and the default (should there be no pre-existing vehicle to assume) should come through scenario studio. A scenario with no existing mission should just result in the default being "sedan" or "passenger".
Additional context
Agent attempts to hijack always result in replacement of the target vehicle with a "sedan".

This issue has morphed to some extent here.
Some discussion is needed here to get the right approach to this issue:

Vehicle acquiring issues:

AgentInterface requirements that the agent would need to be able to perform.
EntryTactic requirements in the scenario for the kind of vehicle that an agent will acquire.
How to negotiate conflicts between the two.

Specificity of the agent type:

How specific should the agent type be.

Incorporation of custom vehicle models

How to supply .urdf to override vehicles
How to supply .urdf for a completely custom vehicle

Default selection of a vehicle type

How to handle cases where the vehicle type should have no default (e.g. for taking on vehicle from imitation learning.)
How to supply a default vehicle type.


Multistream decoding support

Support decoding multistream bzip2 files. Originally posted by @ygyzys at https://github.com/alexcrichton/bzip2-rs/issues/75

@paolobarbolini Hello, thanks for reply. I want to add it to bzip2-rs, but it seems to be a breaking change. In my view, we should remove ReadState::Eof entirely, since Decoder can never know that the end of file happened (it can only know that the end of block happened). Instead, DecoderReader should check for the end of file in the original stream (which it doesn't do now, and actually it seems to me that it can get stuck in infinite loop of feeding zero bytes to Decoder on some corrupted files which contain the header but end abruptly).
In any case, I'm more interested in pure Rust crate, so I suggest to create an issue there and continue our discussion of this there if possible.
And btw, I found a place where it is handled in the reference implementation: https://gitlab.com/federicomenaquintero/bzip2/-/blob/master/bzip2.c#L455 If you change this line to unconditional break;, bzip2 starts to give identical result to these crates.

- _https://github.com/alexcrichton/bzip2-rs/issues/75#issuecomment-826299753_
Thanks for the detailed answer. I'll think about how to implement this in the following days. I also have a refactor that improves how Decoder interacts with Block. After landing that this feature should become easier to implement.

OK, I'll probably do a quick patch of DecoderReader anyway for my little project, and then we'll see how to merge it with that refactoring.
After thinking a little more I'm also not sure whether we should remove Eof from Decoder interface entirely or leave it messaging about the end of block to the user. The problem is, I'm not sure what is a supposed use case for Decoder at all - is it needed in the public interface? Of course, the user may want to tamper with the buffer size of 1024, but this particular problem can be resolved by adding a setting to DecoderReader, akin to setvbuf in stdio.h library.


Add facebook-custom-audiences integration

Unsure if this integration was left out on purpose

thanks! released 2.11.0

no problem :)


client generator for openapi v3

starting points
info

https://github.com/despiegk/ai_playground/tree/main/openai/prompts/openapi
https://github.com/freeflowuniverse/crystallib/tree/development_db/crystallib/core/openapi

tips

don't generate all details, expand the httpclient and our own crystal json to give you the primitives you need, keep the generation as concise as possible

test it on https://github.com/dagu-dev/dagu

test on gitea

test on https://www.cloudhypervisor.org/

was working with @ashraffouda on this. mainly all openapi spec structs are done. the problem now is that we are using sumtypes in the structs, and currently it is not supported to decode json into sumtypes (https://github.com/vlang/v/issues/15081).
still need to figure a workaround, maybe somehow drop the sumtypes, or use the x.json2 module.

"we are using sumtypes in the structs" or they are using it?

if too hard we can skip the task for now but we need communication