CMS: image upload for all media

CMS LEVEL BUG. CAN'T BE ADDRESSED RIGHT AWAY. LOOK TO PHASE 2.
Issue: If an image is replaced in the CMS with a new asset, the Traditional Chinese alternative text and description are wiped out.
Expected behaviour: Alt text should remain, as it does with English text.

See processwire/processwire-issues#489.

I've bumped ProcessWire to the latest version which includes a fix for this issue.


params variable is defined incorrectly on line 284

The params variable is defined incorrectly here:
https://github.com/pycontribs/python-crowd/blob/master/crowd.py#L284
currently:
params["validation-factors"]["validationFactors"].append({"name": "X-Forwarded-For", "value": proxy, })
//
It should be:
params["validationFactors"].append({"name": "X-Forwarded-For", "value": proxy, })

Thanks for the report, and @maiko for the patch.


Bug: react-scripts 4 no eslint warnings anymore

React version: 16.13.1
Steps To Reproduce
Upgrade to react-scripts 4
The current behaviour
No eslint warnings are being displayed inside the terminal as they used to. (errors work fine)
React-scripts thinks everything is fine

But running eslint manually shows that some warnings are still present

Not sure if this is connected to the bug, but 2 of the warnings should actually be ignored because of an // eslint-disable-line comment, but for some reason they still get reported.
I've no clue what's going on. I checked the changelogs and saw nothing of cra disabling the warnings on purpose. I made sure the correct eslintrc file is used. Is there something I'm missing? 🤷🏻♂
Edit: Just quickly tested with a fresh cra install if the same behaviour is happening. And yes, npx create-react-app my-app --template typescript resulted in the same behaviour. I added a variable and never used it, which will show a "variable never used" warning, and car reported nothing in the terminal. Is this behaviour intended? If so, is there a way to enable warnings again? 😁
The expected behaviour
Eslint warnings should still appear in the terminal.

Just found this ticket. My ticket is a duplicate, closing it


v5(array functions)

Type

[ ] Bug Fix
[x] Functions: <Function Name>
[ ] Callbacks: <Callback Name>
[ ] Handlers: <Handler Type>
[ ] Others: ______

Dependencies (Third Party Modules) needed: <Name | Github Link> (Maximum: 20MB~ size)
Want a credit? Discord tag or other social media link: <DiscordTag | OtherSocialMediaLink>
Referenced Issue: #NaN (Answer for an issue, if any)
Description
Pull Request Description Here

Also resolve the interpreter conflict.


webhook_job auto scaling matches wrong labels

Describe the bug
When RunnerDeployments are matched against labels, the label comparison happens against the deployment label maps, not the runner labels.
Code from here
// Ensure that the RunnerDeployment-managed runners have all the labels requested by the workflow_job.
for _, l := range labels {

	var matched bool
	for _, l2 := range rd.Spec.Template.Labels {
		if l == l2 {
			matched = true
			break
		}
	}

	if !matched {
		continue HRA
	}
}

The comparison  is being made between the github labels and the RunnerDeployment.Spec.Template.Labels, which are not the runner labels. The runner labels are RunnerDeployment.Spec.Template.Spec.Labels.
As a workaround I've had to do the following in my runner deployment
apiVersion: actions.summerwind.dev/v1alpha1
kind: RunnerDeployment
metadata:
  name: ${local.runner_deployment_name}
  namespace: ${kubernetes_namespace.deployment_namespace.metadata[0].name}
spec:
  replicas: 0
  template:
    metadata:
      labels:
        label1: sandbox
    spec:
      organization: XXX
      labels:
        - sandbox
      env: []

The simple fix is to replace rd.Spec.Template.Labels with rd.Spec.Template.Spec.Labels, which I have built and tested that it works.
I'll push up a PR.

@artificial-aidan Thanks for reporting and contributing the fix! #852 has been released as v0.20.2. Would you mind giving it a shot?

Error response from daemon: manifest for summerwind/actions-runner-controller:v0.20.2 not found: manifest unknown: manifest unknown

https://github.com/actions-runner-controller/actions-runner-controller/runs/3751275960

Just hold on until the image is published. I can't make the image available before tagging a release.

👍
no problem. Thought when you asked me to test it had been built.

Ah gotcha! I should have been clearer about the timing 😄

Seems to be working


Adding "condition" logic at the screen level

If client attempts to view a screen that does not meet the condition, they will be redirected to the next viewable screen.
See notion page for details

Oh and another test case to try is to mix a pre condition and a post condition and make sure it works as expected.


setBrighness function of ColorController is internal

Please complete the following information:

Library Version: 1.0.5
Affected Device: Every device; Samsung Galaxy S21 5G (in my case)

Describe the Bug:
The function set set the brightness of the slider is set to internal.
Expected Behavior:
This function should be public (so you can set the brightness by your own).
At least there should be a possibility to reset the brightness, like the selectCenter funtion of the color wheel.

The setBrighness method is public now in the new release 1.0.7. Thanks for your reporting!


docs(faq): fix faq toc general anchor links

Fixes the TOC links under general with the correct anchor tags
Issue: https://github.com/reduxjs/redux/issues/3090

Thanks!


Restore HTTP access to liquibase schemas

Hi folks,
the error re-appeared again. Today, the call curl -v http://www.liquibase.org/xml/ns/dbchangelog/dbchangelog-3.9.xsd delivers 301 moved permanently (Location: https://www.liquibase.org/xml/ns/dbchangelog/dbchangelog-3.9.xsd).
SAX Parsers in Keycloak for example are not able to get them. Could you please re-enable the unsafe http access?
Thanks,
Simon
Originally posted by @zambrovski in https://github.com/liquibase/liquibase/issues/1153#issuecomment-1026597782

Hi,
we have the same problem since yesterday
The error is
init method failed; nested exception is liquibase.exception.ChangeLogParseException: liquibase.exception.SetupException: Error parsing line 2 column 35 of classpath:config/liquibase/changelog/20190711143117_added_entity_Paycheck.xml: s4s-elt-character: Non-whitespace characters are not allowed in schema elements other than 'xs:appinfo' and 'xs:documentation'. Saw '301 Moved Permanently'.
When call http://www.liquibase.org/xml/ns/dbchangelog/dbchangelog-3.5.xsd
Thanks
Leo

Please bring it back. I already commented in the other issue, but I can't easily update the URL without redeploying a lot of stuff, I'd like to avoid it. Or tell me that it won't be fixed, so I can prepare for it. :) Thanks!

Hi @zambrovski, @leitus and @AleksanderGrzybowski .
Thanks for the update.
We are looking into the 301s currently.
What versions of Liquibase are each of you using?
Later versions of Liquibase look locally for the xsds.

Yes, that may be a pretty old version, it is version 3.8.9 #73 built at Mon Apr 06 09:32:58 UTC 2020.

try this : https://github.com/liquibase/liquibase/issues/2448#issuecomment-1026873548

Hi @zambrovski, @leitus and @AleksanderGrzybowski @lbanas This should be fixed now.

Thanks for your amazing support! Kudos! :)

Thank you!
El mar, 1 feb 2022 a las 14:06, Mike Olivas @.***>)
escribió:

Closed #2449 https://github.com/liquibase/liquibase/issues/2449.
—
Reply to this email directly, view it on GitHub
https://github.com/liquibase/liquibase/issues/2449#event-5989851871, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AD7FUY6FXJZUYQQ77JNSXILUZAHHRANCNFSM5NIPWBVQ
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you were mentioned.Message ID:
@.***>


fix(@libp2p/webtransport): maximum call stack size exceeded on abort

Fixes bug in webtransport where the .abort method on the stream class was calling stream.abort and leading to a call stack overflow.

Also splits the code into multiple files to make it a bit easier to see what is doing what.

@achingbrain I am not familiar with this commit convention, where is it derived from?

Do you mean the (@libp2p/webtransport) bit?  It's a scope.  Just an experiment - I figure it might make our release notes a bit more readable as it'll indicate which module is affected by which PR.

It's hard to fit the scope into the git commit and still be under 50 characters, but with modern technology, I prefer scoped commits rather than short git commit messages.


Other Image sizes for the Model

Hi there,
first of all, thanks for your awesome work. It is very nice to be able to use more than like 500 images to run the model. :)
Now the question.. What and how do i have to change, if i want to run the model with another image size than 418x418 (from semmacape for example). I think i have to adjust the num_embeddings but i am not sure how to determine the correct size.
If I run the code with 256x256 i get the following error:
File "./padim/padim.py", line 45, in train_one_batch
    (-1, self.num_embeddings, self.num_patches))  # b * c * (w * h)
RuntimeError: shape '[-1, 100, 10816]' is invalid for input of size 13107200

I ran python examples/main.py  for this
Would be really cool, if you could help me!
Best regards

this is the line failing btw:
embeddings = embeddings.reshape((-1, self.num_embeddings, self.num_patches))  # b * c * (w * h)

Hi! This is something that I wanted to do for a long time, but since all my images are 416x416 I never took the time to do it.
You can use try something like in https://github.com/Pangoraw/PaDiM/commit/8c434e2872088a711fbba94f34bd422223099883 with the flag --size 256x256.
I will merge in main when I am sure that model serialization is not broken ;)

Thank you very much for the quick answer/solution! Will test it today. Closing this issue for now :)


feat: Expose from_public_key functionality

Feature or Problem
Public counterpart to #42, this is necessary for use cases such as being able to replicate the functionality in #43 outside of this crate.
Related Issues

Release Information

Consumer Impact

Testing

Unit Test(s)

Acceptance or Integration

Manual Verification

would love to get this in as part of #45 🙂


more than 10,000 address support

Hi, I've built a modubs tcp server, and I found  rmodubs do not support address over 10,000 . I think it is necessary to access more than 10,000 of a register type.
0x = Coil =<PHONE_NUMBER>35
1x = Discrete Input =<PHONE_NUMBER>35
3x = Input Register =<PHONE_NUMBER>35
4x = Holding Register =<PHONE_NUMBER>35
So, how about add a feature to set CONTEXT_SIZE to 65535?
Thanks.Awesome project!

Good day,
there are currently two possible context sizes out-of-the-box: 1000 and 10k elements, as we can not specify (yet) particular sizes for static arrays via features.
the best currently recommended way is to fork the crate and set server::context::CONTEXT_SIZE to the desired value. however:

The context size must be divisible by 8
In your example coils should start from 0 and end at 65535 = 65536 total
You must test custom-sized context manually. As the standard tests allocate context in stack, it should be 65536*2+(65536/8)*2 bytes or more.

Hi,
I just started trying this crate, and then I saw this issue. About CONTEXT, Is the following way OK?
like:
pub struct ModbusContext<'a> {     pub coils: &'a mut [bool]     pub discretes: &'a [bool]     pub inputs: &'a [u16]     pub holdings:&'a mut [u16] }

I think const generics may be a solution here.  I tried implementing this here: https://github.com/alttch/rmodbus/commit/69789d8e1cc2ae8b04cf726294ad35624c43680f
It allows downstream code to set the context size without ever touching any cargo features or worse. However, I didn't manage to make it entirely backwards-compatible, unfortunately.  So this change as it stands would be a breaking change...  Not sure if that's worth it here.

@Rahix I definitely think this issue is worth a breaking change. I opened a second issue #10 to address omitting register types entirely, which would be useful in embedded environments running RTU where you can't afford to allocate 1000 registers that aren't used by the device's register map.

v0.7 supports custom context sizes


MNT: rerender

Hi! This is the friendly automated conda-forge-webservice.
I've rerendered the recipe as instructed in #150.
Here's a checklist to do before merging.

[ ] Bump the build number if needed.

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.


Upgrade vue-lazy-hydration to latest (2.0.0-beta.4)

Hi there,
Can we upgrade the vue-lazy-hydration package to v2? I see that the version 1 is also a beta version, and on NPM there is a version 2.0.0-beta.4 released, a couple of months ago.
Breaking changes
https://github.com/maoberlehner/vue-lazy-hydration#upgrade-v1x-to-v2x
Seems like some minor changes.

Hi @memic84
Thanks for the input. I know, that the package is lagging behind. When I first released NuxtDynamic on 2020-11-18 there have been issues with the version 2.0.0 of vue-lazy-hydration (related to rendering and event listeners). But as I can see there have been made several fixes the following days (2020-11-19 - 2020-11-21).
So I guess the chances are good the issues are gone with the latest version - Therefore no need to stay with 1.0.0.
As you already discovered, there are just minor changes to implement 2.0.0, not much to change. If you'd like to you can make a pull request and I'll verify that everything works as expected. If you don't have the resources to do so, I'll gonna do it myself in the coming days.

Hi @aerophobic
I can make the pull request, but there's some confusion on my side now with the vue lazy hydration package. On NPM it shows the version 2, and the releases on github from vue lazy hydration don't show any version 2.
Not sure what has been fixed, and what now cause i haven't seen any change notes.

I'll test the new version and bump it if all tests succeed

Thanks! Sorry, have been very busy two weeks..

no worries, same here. I upgraded vue-lazy-hydration to the latest version and published a new version of the package (1.2.0). I'll close this issue for now - feel free to reopen if you'll experience unexpected behaviour.


Add User-Agent token to allowed headers

Related: https://github.com/ethereum/web3.js/issues/1803
Also related: https://github.com/trufflesuite/ganache/issues/359
Although the latter is a broader issue, I fixed my immediate problem of not being able to connect from Firefox. I will look into the rest in a separate branch as requested by @davidmurdoch

Thanks for this one, @dinostabOMG! I've opened #142 to prevent issues like this one from cropping up in the future.

The correct issue for tracking the CORS fix is actually in #143


Update AuthorizationInterceptor.csproj

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Warning: This coverage report may be inaccurate.
This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

For more information on this, see Tracking coverage changes with pull request builds.
To avoid this issue with future PRs, see these Recommended CI Configurations.
For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 92.368%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
266

Relevant Lines:
278

💛  - Coveralls


What is "|="? (typo?)

In "down the rabbit hole" there are few piece of code with a typo "|=" instead of simple assignment "=", i suppose one will get compile error if such code is attempted to be compiled... or maybe this is new magic i cannot understand?


One form of jsonCall not working in Comet context

Mailing List thread
No example project available.
When using this form of jsonCall:
def jsonCall(jsCalcValue: JsExp, jsonContext: JsonContext, func: (JValue) ⇒ JValue): GUIDJsExp
When "func" is called in a comet context, the client receives an empty response.
Antonio said:
Got it. This is the interaction of https://github.com/lift/framework/blob/master/web/webkit/src/main/scala/net/liftweb/http/CometActor.scala#L934
with https://github.com/lift/framework/blob/master/web/webkit/src/main/scala/net/liftweb/http/LiftServlet.scala#L637,
which means that a JsonResponse isn't ever generated correctly from a CometActor.
That's going to be a doozy to fix… We may end up wanting to push notices via the comet
response while pushing JSON via the AJAX response. But always doing that could result
in strange ordering issues, and sometimes doing that could lead to lack of clarity about when
that will happen vs not.
Will ponder it a bit; can you open an issue?

The basic question here is what we do when we have a JValue bundled with a JsCmd in the return value of liftSession.runParams. This seems like it's mostly a concern in comet actors, but we'll need to confirm that. One observation is that in this particular context, we are likely always returning only S.noticesToJsCmd, because of the mixed nature of the response data that comes back from runParams. So changing this behavior may take us from not really returning anything to returning something, which is much less potentially-breaking than other changes we could make.
For the comet case specifically, we see the comet actor line also appends LiftRules.noticesToJsCmd. However, since the notice stuff in S uses TransientRequestVars, I think any notice set in the comet would be invisible once we get back out of the comet and into LiftServlet's handling. IF that is true, that means LiftRules.noticesToJsCmd will always be empty in LiftServlet, which means a mixed JSON + notices return from the comet would always result in an empty response.
Some assumptions to be verified there, but we may be able to make a fix to this that is “additively backwards compatible”, which is to say it doesn't lose any data that wasn't already being lost before this. It could still result in changed behavior if somehow folks were relying on that data being lost, of course.


added support for V7 Schematics with no id field

Any updates on this PR? I'd really love to have this for kicad7!

Sorry, totally lost track on this one.
@sirtux Could you test this PR and let me know if it works for you in V7?
If that's the case I'll merge it and release a new version

Yeah, will test it, but can take some days - I'll put in on my todo for latest next weekend.
Thanks for your work!

Looks fine for me!

Thanks @computergeek1507 and @sirtux  for your help with this 👍🏽

I have used this PR with v7 to get assembled boards.  It went smooth and they worked.  Thanks!


Add Polkadotters to delegate registry

this PR will add Polkadotters as one of the delegates for OpenGov.

Hello @pmensik!
Thank you for PR, we'll check it out soon. Could you provide proof of ownership of that accounts? You can do it based on that tutorial, step 14

Hey @stepanLav,
here is the proof for Kusama
https://kusama.subscan.io/extrinsic/18365781-2
and for Polkadot
https://polkadot.subscan.io/extrinsic/15976551-2
Thank you!

Ty, everything looks good, this is how it will looks like in the app:

Spoiler!

Hey @stepanLav, looks awesome, thank you!


feat: also try to auth for config if server returns status 403

This makes it so that the registry-auth unstable feature also attempts to make authorized requests to a registry's config.json (in sparse mode) if the server's response code is 403, not just 401.
These status codes have very similar meanings and some 3rd-party registry providers (e.g. Artifactory) prefer to return 403 for unauthorized requests.
Also updates the docs on this feature to reflect this.
What does this PR try to resolve?
Artifactory likes to return 403 for unauthorized requests.
The meanings of HTTP 401 Unauthorized and HTTP 403 Forbidden are very similar and largely overlapping.
In order to make Cargo's registry-auth feature play better with 3rd-party registries, I would recommend also supporting attempting authentication for 403s even if that is not the perfectly semantic meaning.
How should we test and review this PR?
Ideally, talk to a 3rd-party registry such as artifactory with this change included and all the config set on the 3rd party registry.
Additional information
Related tracking issue for the whole registry-auth feature: https://github.com/rust-lang/cargo/issues/10474

r? @arlosi
You're a better reviewer than me for this PR.

The intent of only sending the token for HTTP 401 is to minimize the possibility of sending a token to a server that's not expecting it. Additionally allowing HTTP 403 relaxes that slightly.
Is there a reason why Artifactory can't send HTTP 401 when Cargo is attempting to fetch config.json? Other 3rd party registries have implemented this.

Is there a reason why Artifactory can't send HTTP 401 when Cargo is attempting to fetch config.json? Other 3rd party registries have implemented this.

I don’t work for JFrog / Artifactory so I cannot answer that. However it seems like 403 is generally what Artifactory returns for any unauthenticated request.

I'd rather not merge this unless we know we need to, since it makes Cargo slightly more likely to send a token to a URL where it shouldn't. Given that a registry already has to implement the rest of the Cargo protocol, it doesn't seem too difficult to send HTTP 401 for authentication failure.
I suspect that the biggest blocker for registries adding Cargo support likely that registry-auth is still unstable, rather than not allowing for authenticating on HTTP 403.
I'm happy to revisit this if we get a compelling request from a registry operator though. Thanks.


BlockMetadata into_inner() function cannot fail; drop the Result

This simplifies the code a bit and also removes an unnecessary error check in the VM Adapter.
Motivation
Removing unnecessary code
Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
Ran existing tests

This PR may have modified JSON-RPC server code.
Breaking changes policy:

Chaning JSON-RPC method signatures or removing/modifying fields
in the response in /V1 will not be accepted.
Adding fields is ok.
Adding a new JSON-RPC method is ok.

Please ensure you have also done the following to update the docs:

Update json-rpc/API-CHANGELOG.md.
Add/update type/method documentation under json-rpc/docs.

It looks like the code was different prior to #3097 from @zekun000. It used deserialize the previous votes and that could fail.

LGTM

/land


Add include YAML tag.

Allows including other files in the main configuration.yaml file.  With this functionality, passwords or other sensitive information can be stored in a separate file from the main configuration.

Coverage decreased (-0.0%) to 75.51% when pulling 6ef60aa979d7682c9431ef531d807f50d7af5fd8 on andythigpen:yaml-include into a4e0a7f2353c6c55f803969c055d3789e9ea62b9 on balloob:dev.

This is cool !


Change default generation flavor and flags for generic codegen

Emitter should generate "unbranded" code by default
Add a new flag flavor that generates azure code for the value azure. This is not case-sensitive. Any other value does nothing, and therefore generates unbranded code.
Don't remove yet currently supported flag branded to help the transition to the new system. If both flags are set, read flavor first and ignore branded boolean flag.
If package-dir starts with azure, auto-set flavor to azure if flavor was not set already. If package-dir is anything else, no specific behavior.

We can do this, but as 2024/03/04 it would not be meaningful, as Java don't have a generic core published anywhere.
@srnagar

As discussed, since the generic-core is not published to Maven Central yet, switching the default will result in unresolved dependencies for generic core. Also, the generic core APIs are still work in progress and we should not change the emitter to be generic by default until the APIs are stabilized.

a bit of thought on internal impl
we probably still want to keep the boolean in internal, e.g. isBranded or isAzure or isGeneric. personally I don't want to see 10+ lines of if ("azure".equalIgnoreCase(settings.getFlavor()) { scattered around the whole repo.

I'm going to close this task, and we will create other tasks related with unbranding later, e.g. adopting generic-core, embedding flavor to generated code, make non-azure code as default (after generic-core go public). @lmazuel @srnagar @lirenhe Please let me know if you have any concern on closing this task.
/cc @weidongxu-microsoft


Create context template

It would be awesome if we had the option to create context modules that export providers and hooks. I think most of the time, these files are boilerplates.
Input: ContextName
Produces:

a folder called <ContextName>Context
index file
<ContextName>Context.tsx

export * from './__ContextName__Context';

// <ContextName>Context.tsx
import React, { createContext, useContext } from 'react';

export interface __ContextName__Value {
}

const context = createContext<__ContextName__Value | null>(null);

export function __ContextName__Provider({ children }: __ContextName__Value & { children: React.ReactNode }) {
    return (
        <context.Provider value={{ }}>
            {children}
        </context.Provider>
    );
}

export function use__ContextName__(): __ContextName__Value {
    const value = useContext(context);

   if (!value) {
        throw new Error('use__ContextName__ must be used within a __ContextName__Provider');
    }

    return value;
}

Nice @eddeee888 !
So are you imagining that there will be two commands:

Create React Component
Create React Context

--
Or one command:

Create React Component

That opens a menu:

Component
Context

I'm thinking one command that opens a menu.
That way we could add more templates in there. e.g. Class component ( contrived example since people may not be using this )


added GitLab build badge

Q
A

Is bugfix?
no

New feature?
yes

Breaks BC?
no

Related: https://github.com/yiisoft/yii2/pull/13360#issuecomment-284528243
This PR is merely for discussion or an example, discard it, if you don't want the badge, or comment if you'd like to see another badge.

I've added build status badges to https://github.com/yiisoft/yii2/wiki. I think it's enough to have one build badge in readme.


Update NRed boot-args and status

This sentence contains too many brackets. Can you please formulate a sentenence that's more readable?

@5T33Z0 Done


Initial demo not working

Hello ,
I am trying to install the app inside a brand new project, and make a demo for my team to see.
however, after starting a new project and copying the files from the demo/demodesk folder , i am getting an error.
The main issue is everytime i execute run server, i get a error -
Please help.
ModuleNotFoundError: No module named 'demodesk'
I am trying to demo the project by installing it in a virtualenv, and then running pip install django-helpdesk in it.

You probably the need the files to stay in a "demodesk" folder within your main project folder so python can find it. Check out the Makefile and see how to start a basic demo.

Thank you for the response. I tried to run the makedemo. I followed the instructions in the install docs to add to an existing project, but i am not sure what the step 's MEDIA_ROOT folder is supposed to be. I am also not sure where and how to run step 6.
Do we need a apache or nginx server for demo app.

Oh the install docs are meant for production deployment, you would need to set up apache or something similar with the wsgi support. Check out the apache docs for how to do that.
If you just want to run it and test it locally, you can use django's built-in python development webserver. Not a good idea to use in real cases but just for showing off it works fine. That's what the Makefile script does.

Hello Garret,
Thank you for the response.
The application runs fine until i enter a ticket and click submit (even as
a admin) . Then it fails. Not sure which parts i am missing.
On Sun, Apr 14, 2019 at 11:55 PM Garret Wassermann<EMAIL_ADDRESS>wrote:

Oh the install docs are meant for production deployment, you would need to
set up apache or something similar with the wsgi support. Check out the
apache docs for how to do that.
If you just want to run it and test it locally, you can use django's
built-in python development webserver. Not a good idea to use in real cases
but just for showing off it works fine. That's what the Makefile script
does.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/django-helpdesk/django-helpdesk/issues/753#issuecomment-483130060,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ATwHrvVYCcsFjUqqYFlJysqdWetWMElEks5vhCJggaJpZM4cuyqC
.

What error message do you get when it fails?

When i click on the new ticket and enter a test ticket, i get a runtime
error
RuntimeError at /helpdesk/tickets/submit/
Model class django.contrib.sites.models.Site doesn't declare an
explicit app_label and isn't in an application in INSTALLED_APPS.
Request Method: POST
Request URL: http://<IP_ADDRESS>:8000/helpdesk/tickets/submit/
Django Version: 2.2
Exception Type: RuntimeError
Exception Value:
Model class django.contrib.sites.models.Site doesn't declare an
explicit app_label and isn't in an application in INSTALLED_APPS.


Feature Request: Deal with Android obb/apk files smartly

The Android versions of some large Unity games uses obb files, which is a zip file with the structure below:

assets

bin

Data

[Lots of files with filename as arbitrary hex number with length 32]
sharedassetsX.assets.splitY where X and Y are numbers usually starting from 0

* For Android Unity games that does not use obb, the apk file also has the same data structure.
Those hex-named files are all Unity assets files. For now I can only  "disunity extract *" which is not very convenient, and also results in a huge number of folders. It would be good if disunity can automatically unzip the obb file, extract all assets files, and put the extracted files in the same folder, as if it's dealing with a single assets file. Sharedassets files can be dealt with as usual.

I've never seen .obb files so far, but it should be possible to add support for Zip archives in general. At least for the read-only commands.

obb files are usually just zip files. And the obb file of Unity games are all zip files. So you can just do this (pseudocode)
if (extension=="obb" or extension=="apk)
unzip(file)
extractassets("assets/bin/Data/xxxx")

It's possible to scan Zip files directly without extracting them, which would save storage space and time. It would enforce a ready-only mode, however.

hey it's been 2 weeks, I was wondering if you had come up with anything?

+1 for this!


Crl/buttons in header

Introduces the HeadCellContent. It should be reusable for both tables. Right now only used in the pagination table.
Things that break with this PR

head font size

I think we might need some design input on this

keyboard navigation

I'm leaving some things commented that I might need to rewrite, so I don't have to redo it from scratch. When this header work is completed, I think it is a good time to do some "e2e" RTL tests for sorting

Also dont forget to merge with correct commit message


Notify the user at the beginning if some bids entered the reveal phase

now we have the sidebar in mist to do that. Any other suggestion?


Site-wide validation overrides

We use this to implement a "UTF-8-only" policy, but the same could be used for standardizing other options across a site with a configuration option.

failure is unrelated to this change.
The problem is our tests are creating a resource with ckan's factory, which creates a dataset, then passes the resource to a new dataset factory, but that resource already belongs to a dataset.

It may be unrelated, but it still means this change isn't properly tested.
How easily can the tests be fixed?

test resources should be created like this https://github.com/frictionlessdata/ckanext-validation/blob/1073c80dace453a404df3d5f1ac1ae86a88b5029/ckanext/validation/tests/test_logic.py#L235-L237 instead of like https://github.com/frictionlessdata/ckanext-validation/blob/1073c80dace453a404df3d5f1ac1ae86a88b5029/ckanext/validation/tests/test_logic.py#L349-L351


[CP] [beta] Fix analysis server exceptions communicating with analyzer_plugin when server has macro support enabled

Commit(s) to merge
916272331b64c5a104ddc8afdafae4be1231b8c4
Target
beta
Prepared changelist for beta/stable
https://dart-review.googlesource.com/c/sdk/+/374361
Issue Description
As part of changes to support macros, the protocol classes used for communication between the client IDE and server were updated to use URIs in place of file paths (so that we can represent resources that are macro-generated, such as dart-macro-file:///x.dart that is macro-generated content for file:///x.dart).
Some of the protocol classes are also used to communicate with analyzer plugins, which at this point are not handling macro sources and still expect to use file paths. This results in exceptions when using plugins because the server is trying to send (and expecting to receive) URIs instead of paths.
What is the fix
The fix is to stop using a global encoder for the path/URI translation from all protocol classes and instead pass the encoder to all toJson/fromJson methods (where it can be done based on whether the communication is with the client or a plugin).
Why cherry-pick
Analyzer plugins will stop working when the server is in macro (URI) mode without this fix. To simplify trying out the JSON macro, the VS Code extension has always enabled macro (URI) mode for Dart 3.5 pre-releases.
Risk
I'd say it's probably low-medium risk. The change does unfortunately touch a lot of code (because encoders have to be passed everywhere), however most of the change was code-generated, or updated by generating code and then fixing compile errors to ensure the encoder is passes everywhere it's necessary.
Issue link(s)
https://github.com/Dart-Code/Dart-Code/issues/5156
Extra Info
fyi @bwilkerson @jwren

A possible alternative to cherry-picking this would be to ship a new VS Code extension that puts enabling macro support back behind a flag for =3.5 and possibly automatically enabling it for >=3.6 (undoing this change).
However, that would require enabling this flag for anyone testing out macros (including JSON) again (cc @mit-mit).

Thanks, @DanTup !  @srawlins @bwilkerson @jwren - do agree on low risk / cherry picking?

+1 from me. It's a big change but it's important, so the earlier the cherry-pick the better.

The change was merged into beta in https://github.com/dart-lang/sdk/commit/0662a87c772dfbb95e51a6b7ba2f1c4b17d8d7ea

I'm not 100% sure of the process here, but should this be closed, @itsjustkevin ?


JS is recompiled when editing a scss file

Laravel Mix Version: 4.0.15
Node Version (node -v): v10.15.1
NPM Version (npm -v): 6.9.0
OS: macOS 10.14.3

Description:
In my project I use Laravel Mix to compile JS and scss. I also use BrowserSync to refresh the Browser on change. Problem is, when editing my scss files, BrowserSync makes a hard reload instead of inject the compiled css into the browser.
If I comment out all the JS compiling steps from webpack.mix.js so only the scss/css is compiled. BrowserSync works as expected and injects the css without a full reload. So BrowserSync works as expected. The problem must be somewhere else.
When I investigated this further, it found out that when I edit a scss file, the js is also getting recompiled, even though I haven't edited the js source files.
But, if I edit one of the js files, only the js is getting recompiled. The scss is not recompiled, just as expected.
So the problem boils down to this:
If I edit a scss file, the scss is compiled into css. But the js is also getting compiled, causing BrowserSync to do a full reload, instead of just injecting the new css.
The js files should not be compiled when I edit a scss file.
I have not found a solution to prevent the scss files to getting recompiled when editing a js file. Anyone has a solution to this?
Steps To Reproduce:
Here is my webpack.mix.js:
let mix = require('laravel-mix');

mix.disableSuccessNotifications();
mix.setPublicPath('assets/build');
mix.version();

mix.options({
	processCssUrls: false // Don't copy images to build folder
});

mix.browserSync({
	proxy: 'example.test',
	files: [
		'assets/build/css/main.min.css',
		'assets/build/js/main.min.js',
		'**/*.php'
	]
});

mix.combine([
	'assets/vendor/example1.js',
	'assets/vendor/example2.js',
	'assets/vendor/example3.js',
	'assets/js/main.js'
], 'assets/build/js/main.min.js');

mix.sass('assets/scss/main.scss', 'assets/build/css/main.min.css');
mix.sass('assets/scss/editor.scss', 'assets/build/css/editor.min.css');
mix.sass('assets/scss/login.scss', 'assets/build/css/login.min.css');

After updating macOS from 10.14.3 to 10.14.5 this issue seems to be gone. Compiled CSS is now injected on the page without a full page reload in my projects. I have no idea if the update to macOS solved the issue, or if it was something else. But hey, a fresh restart solves most computer related problems.


PHP Error when PHP8 named arguments get forwarded using __call() and Illuminate\Support\Traits\ForwardsCalls

Laravel Version: 8.42.1
PHP Version: 8.0.6
Database Driver & Version: sqlite3

Description:
Using PHP8's named arguments syntax creates errors when the method gets forwarded.
Steps To Reproduce:

Default laravel installation
Uncomment the line on DatabaseSeeder.php
Migrate and seed the database (this should give us an users table with some users created.)
php artisan tinker

use App\Models\User;

// this should give the same result.
User::get()->pluck('id');
User::all()->pluck('id');
User::pluck('id');

// this throws an error
User::pluck(value: 'id');
// this, does not.
User::get()->pluck(value: 'id');

Similarly, using a named argument in a migration's default()'s method.
$table->string(column: 'password')->default(value: 'do not actually do this');

this is because named arguments get passed as associative arrays in the __call($method, $parameters)  method.
For example,

->default('a string') get turned into $method = 'default', $parameters = [0 => 'a string']
->default(value: 'a string') get turned into $method = 'default', $parameters = ['value' => 'a string']

This indeed isn't supported.


Convert sequence diagram in admission controllers for container drift article to Mermaid

This is a Feature Request

What would you like to be added
Update https://kubernetes.io/blog/2021/12/21/admission-controllers-for-container-drift/ to use the same diagram, but drawn using Mermaid. See https://kubernetes.io/docs/contribute/style/diagram-guide/ for a guide to using Mermaid for diagrams.
Why is this needed
We'd like to use a consistent approach for diagrams. The existing diagram doesn't scale so well with different viewports.
Note
We should not change any of the meaning of the diagram. If there is any factual error in the diagram, open a separate issue about correcting that (we'll want to check in with the article authors too).
Comments
/area blog
/kind cleanup
This would be a fixup for PR https://github.com/kubernetes/website/pull/29761

I can work on it

/help
Help wanted - and someone has already stepped forward.
/triage accepted


Add support to view local and argument variables in termdebug

This is a pull request tied to a feature request https://github.com/vim/vim/issues/12402.
This would add the Var command to spawn a window similar to Asm in which local variables and function arguments can viewed.

Thanks for looking into this.  The help for the :Var command is still missing.  It would be good to explain what the window will show.  Does it update when returning from a function or when calling a function?
No need to update the tags file, this is done automatically.

I have added the help text.
Would you like me to discard any changes to the runtime/doc/tags file?

This is still marked as draft.  Do you plan to add more or does it need some more testing?

I have reverted the tags file.
I will unmark this as a draft. I'm looking at adding some of the other functionality that could be helpful, like a memory explorer or a register window. But I will create separate commits for those.

I have reverted the tags file.
I will unmark this as a draft. I'm looking at adding some of the other
functionality that could be helpful, like a memory explorer or a
register window. But I will create separate commits for those.

I'll leave this open for a little while, waiting for users to try it out
and give feedback.
--
George:  "I just got a new set of golf clubs for my wife!"
John:  "Great trade!"
/// Bram Moolenaar -- @.*** -- http://www.Moolenaar.net   \
///                                                                      \
\\        sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ ///
\\            help me help AIDS victims -- http://ICCF-Holland.org    ///

has someone used this? Is this working as expected?

no, I don't think so.
some value of local var didn't print exactly.
and should slient or ignore the echo when reading/opening that var buf.
--
shane.xb.qian

no, I don't think so. some value of local var didn't print exactly. and should slient or ignore the echo when reading/opening that var buf.
…
-- shane.xb.qian

Do you remember the code and situation?

and -stack-list-variables seems this would not print exactly some value of local var vs/but identifying it was a complex struct something, though by p xxx can print it.

and -stack-list-variables seems this would not print exactly some value of local var vs/but identifying it was a complex struct something, though by p xxx can print it.

There was indeed a problem with this around strings, but for structs this is an issue with gdb.p and -stack-list-variables --all-values give you more magic than -stack-list-variables --simple-values. But they leave out the type.
My opinion was that the types and then doing the rest with p was more relevant. Especially because most structs are passed around as pointers, which both versions of -stack-list-variables show.

I think no reason to use exe here, and yes, I think should modify (silent) this for Asm too.
and actually if this Var and Asm (etc?) both set to init auto open, I felt what was that file would be, just a feeling, you may can test it.
--
shane.xb.qian

I think no reason to use exe here, and yes, I think should modify (silent) this for Asm too. and actually if this Var and Asm (etc?) both set to init auto open, I felt what was that file would be, just a feeling, you may can test it.
…
-- shane.xb.qian

I'm not sure I'm following what you're suggesting the alternative would be.

I'm not sure I'm following what you're suggesting the alternative would be.

I meant if Var and Asm (etc) both set to init auto open (there is a config to toggle them to open auto or manually) that maybe a race of file cmd for them.
anyway, I suggest those all exe file xxx modify to silent file xxx, but anyway please try if there any others side-effects.
--
shane.xb.qian

I'm not sure I'm following what you're suggesting the alternative would be.
I meant if Var and Asm (etc) both set to init auto open (there is a config to toggle them to open auto or manually) that maybe a race of file cmd for them. anyway, I suggest those all exe file xxx modify to silent file xxx, but anyway please try if there any others side-effects.
…
-- shane.xb.qian

The auto open just ensures that the Goto(Asm|Variables)winOrCreateIt function is called from StartDebug_internal. Calling :Var or :Asm at that point is exactly the same as just calling it twice. It will transport you to that buffer.

that bufnr>0 confirm that, vs file is to modify current.
anyway, I guess a race, (and I am not nearing my PC for now,) but/though that maybe not impact the result. however, a silent should be more nice operation.
--
shane.xb.qian

should be silent file Termdebug-variables-listing and silent file Termdebug-asm-listing without (no req) exe here.
seems useless only type but no value exactly was printed.

Error detected while processing function <SNR>80_CommOutput[25]..<SNR>80_HandleError: line    8: err was judged by msg =~ '^\^error,msg=' looks was not accurate, seems some log would be printed prefix with error but it was just a log, specially if print via echoerr substitute(msgVal, '\\"', '"', 'g'), it looks like vim had some err.
once quit from gdb window (by q), it would auto close program window (default auto open) with gdb window, howerver this Var window would not be closed with it, is it good to keep the same?

Done
Again that's a thing with gdb. It works for simple values only.
Theoretically a double pass could be done. --simple-values to get the
types and --all-values for the "complex" values. But I thought that wasn't
a great idea
Fixed
I was on the fence about that. The main reason I chose not to do that
initially was that the assembly window did not implement it either. But now
that we're changing that too, I have implemented that both windows get
closed on Termdebug exit.

2. Theoretically a double pass could be done. --simple-values to get the
types and --all-values for the "complex" values. But I thought that wasn't
a great idea

but Var window supposed to check local var's value, that's its value, if only type, seems useless, specially perhaps there was not much simple-values cases, but most were complex var.

actually i verified with golang, it's mostly all were complex var.
to type, since there is a source code window, normally i knew it's type, so value perhaps was much more valuable.

3. Fixed

this item seems not fixed yet.

or let it be, to c/c++, perhaps you're right, or if you knew how to make it be workable for golang as well.
this item, an easy workaround i think is changing echoerr to 'echohl error | something... | echohl none'.

so, is this ready to be included? Has anybody tried it out?

I have tried this out for a C program and it seems to work for me.

or let it be, to c/c++, perhaps you're right, or if you knew how to make it be workable for golang as well.

better be making golang working as well (maybe --all-values better, or not sure if it worked for golang),
or let it be, your call.

this item, an easy workaround i think is changing echoerr to 'echohl error | something... | echohl none'.

i opened PR #12856 for this item.

some broken indent
PR  #12857 for this item.

I've been meaning to look at some none c/c++ languages, but haven't gotten around to it yet.
I'm going to take a look tomorrow, but I don't think I'd change it from simple-values
I'll also look at the hybrid approach, but it gives me bad vibes.

I've been meaning to look at some none c/c++ languages, but haven't gotten around to it yet.
I'm going to take a look tomorrow, but I don't think I'd change it from simple-values
I'll also look at the hybrid approach, but it gives me bad vibes.

thanks, this is the key point, wish you make this work through,
or if really not possible or difficult, then let it be for now, thanks~

Included as of 9f29621415146abc046471440515e9e34f3e57a1
I suppose we can make further adjustments as needed.


Dial Connection not being considered by context timeout

We've ran into an issue where we set timeouts, but during high traffic/requests dax seems to not properly timeout.
We setup our dax client as below...
sess := session.Must(session.NewSession())
cfg := dax.DefaultConfig()
cfg.Credentials = sess.Config.Credentials
cfg.Region = region
cfg.HostPorts = []string{endpoint}
cfg.RequestTimeout = 300 * time.Millisecond
cfg.ReadRetries = 1                    // default is 2
cfg.MaxPendingConnectionsPerHost = 100 // default is 10
cfg.DialContext = (&net.Dialer{
  Timeout:   300 * time.Millisecond,
  KeepAlive: 30 * time.Second,
}).DialContext
client := dax.New(cfg)

During peak traffic hours we are seeing dax response take over 3 seconds.
I'm suspecting dial connection to be using context.TODO instead of request context.
https://github.com/aws/aws-dax-go/blob/master/dax/internal/client/tubepool.go#L318
Thank you in advance!

@mocyuto were you able to find the root cause or a fix for this?
BTW the right code line now is https://github.com/aws/aws-dax-go/blob/master/dax/internal/client/tubepool.go#L341


feat(handlers): add editChannelOverwrite() function

Please describe the changes this PR makes and why it should be merged:
Status

[x] Code changes have been tested against the Discord API, or there are no code changes

Semantic versioning classification:

[x] This PR changes the library's interface (methods or parameters added)

[ ] This PR includes breaking changes (methods removed or renamed, parameters moved or removed)

[ ] This PR only includes non-code changes, like changes to documentation, README, etc.

Should I add a new interface for that?

Should I add a new interface for that?

Forgot one function: deleteChannelOverwrite

Forgot one function: deleteChannelOverwrite


Update tomcat url to download a fixed version

Fixes #2023
What is being addressed
Download Tomcat from a location that will hold our pinned version for a long time (the previous location saved only last 2 versions).
How is this addressed

As stated

/test-force-approve
enough to see the docker build workflow pass, no need to deploy.

/test-force-approve


Fix RTL text direction in PDF export

Short description
Somehow RTL languages are printed LTR in the PDF export
Title has correct direction, but content is incorrect:

Proposed changes
Text direction is broken when text passes through pdf_strip_fontstyles filter.
Adding "unescape" in return statement solves the issue.
Side effects
I also updated pdfs in tests for other languages, because tests were failing.
But visually there was no difference except for Arabisch.

Resolved issues
Partially fixes: #1954
(text direction is also wrong in ToC, but I will look into that separately)

Pull Request Review Guidelines

@JoeyStk
Cool finding, thanks. I was looking at Arabisch for so long that my eyes blurred.
I have just reviewed Arabic and Farsi one more time, and here is my summary:
As I see, issues below are actually the same for both Arabic and Farsi.

When Arabic/Farsi sentence contains a Latin word, weird metamorphoses take place:
I've marked identical pieces of text with the same color. So, we can see that these pieces of text change their position relative to the English word.
What is besonders strange to me - they change not their direction (they still RTL), but position in the sentence.

When there is a line break, the newline goes up, not down.

Bullet points are on the left, but should be on the right.

Have you tried setting an dir="rtl" attribute for a list item, for example? Would that improve the layout?

As we discussed on the team call:

the first issue related to mixed content - we will leave it as is
for second (line breaks) and third (bullet points) and ToC - I will raise issues for xhtml2pdf library


Add Forecast Quantiles Plots and Docs

Following #140, the standard plots can be updated with an additional one giving forecast quantiles for each horizon.
Some Jupyter notebooks should also be added in the doc directory.

Forecast quantiles Plot for the 12 horizons on the ozone dataset.

Notebook for Ozone dataset
https://github.com/antoinecarme/pyaf/blob/master/docs/PyAF_ozone_forecast_quantiles.ipynb

Air Passengers forecast quantiles
https://github.com/antoinecarme/pyaf/blob/master/docs/PyAF_airpassengers_forecast_quantiles.ipynb

Closing


Can i assign css to the pin?

Can i assign css to the pin?

No, because nothing on the canvas is an HTML element; its all just lines and shapes drawn on a canvas like drawing something in MS paint or on a bit of paper with a pen.
 If you would like an HTML and CSS winning wheel I suggest searching for alternatives.
I just did a quick google search for "html and css wheel of fortune" and the top result was this http://bl.ocks.org/jrue/a2aaf36b3c096925ccbf I see it uses HTML elements you should be able to style with CSS.


Any way to skip the initial Select+Start calibration?

Hi,
I'm using RiftCat with my smartphone and a lightened up ping-pong ball on top of my HMD headband for tracking and my problem is that before doing the calibration, the PS Move controller postion and orientation is almost perfect: it's not perfectly offsetted to my HMD but both 3D spaces (PS Move and HMD spaces) match, and I can move and rotate over myself without seeing the controller flying around.
But when I do the Select+Start calibration, it just destroys everything: PS Move orientation gets completely f*cked up no matter how perfectly aligned and stable you hold it and the position, well, it's just completely missaligned with the HMD as soon as you start moving or rotating.
I can easily hide the "need_alignment_gesture.png" message but I cannot use the controller outside the Steam overlay menu unless I do the calibration.
Any help with this?
Thank you very much.

Sorry about that. The alignment setup can use some work. There is currently no way to disable the alignment gesture completely, though that would be easy to add (I can add that in the next release). However you can disable the orientation portion of the alignment by adding the following to the "psmove_settings portion of your steamvr.vrsettings file:
"psmove_settings":{
    "use_orientation_in_alignment":false
}

Yes, I read about that setting on another issue but sadly the worst offender is the position offset. Either way I think I'll be stopping with all this Android based VR as my phone (Moto G 4º generation) seems to have some extremely shitty accelerometers and no compass whatsoever, so drifting is insane and I have to recalibrate the orientation every 30 seconds or so, making everything unplayable. I might get something like a Oculus DK2 sometime in the future to at least have proper orientation tracking.
Thank you very much to you and to cboulay for this software though, you're doing a great work with it.


Cannot sign in

Version
1.95.1
Describe the bug
Attempting to sign-in to the extension with Google or GitHub, i get a new Authorization tab in the browser, but upon clicking on "Authorize" another/ new empty tab opens while Cody in VScode remains stuck in Signing-in.
Expected behavior
sign-in successful and extension usable
Additional context
Cody v1.40.x-1.41.x, VSCode 1.94.2 and 1.95.1, Debian 12 and Firefox 132...had it in the past as well...not under proxy, VPN or anything
Runtime Status
Activation
Activated by onLanguage event: 1ms
Uncaught Errors (2)
Cannot write headers after they are sent to the client
Cannot write headers after they are sent to the client

Oh, I bet this is because app link redirects are disabled or something like that.


Make network configuration of factory vm configurable

In some scenarios you might want to have the ability to configure the network configuration as internet egress is only available for certain networks. An option should be added which enables a static configuration of the deployed factory vm.

Yup, definitely want to enable this.

I am working on something for this.  Just need to test it first.

Thanks Grant!


Automatic Batching for Dynamic Graphs

@piiswrong: This seems very relevant to MXNet's efforts to support dynamic graphs  #5705:

https://arxiv.org/pdf/1705.07860.pdf
https://github.com/clab/dynet/blob/master/examples/python/tutorials/Autobatching.ipynb

@jekbradbury: any idea whether PyTorch is thinking about adding support for something like this?

Yeah we have been thinking about doing the same thing. Haven't got to it yet. Never thought you can write a paper about it...

DyNet's autobatching approach is predicated on their lazy execution semantics (build a graph imperatively but don't execute it until later -- the autobatching can happen in between) and this limits the applicability of autobatching to truly dynamic situations (where the graph structure depends on runtime values of tensors e.g. because of discrete samples from a stochastic policy network).
PyTorch and Chainer are currently using eager execution semantics (other than the minimal laziness that comes from CUDA async execution), which means they'd either need to implement lazy eval or apply a very different autobatching approach. The problems with choosing lazy eval are a) the runtime conditionals mentioned above and b) the fact that as GPUs get faster and faster graph-building starts to be more costly than execution.
Ultimately what we need is either a magical static analyzer that can convert imperative-looking Python into an MXNet-like symbolic graph or a combination of autobatching with lazy eval together with annotations that say "this function can be statically compiled." MXNet is pretty well-positioned to do that since it's always had a mixed imperative-symbolic approach.

This issue is closed due to lack of activity in the last 90 days. Feel free to reopen if this is still an active issue. Thanks!


feat: add update-core command to upgrade deployer chains to 2.5.19

Introduces the update-core command, used to update deployer-generated bridgechains from Core 2.3 to 2.5.19.
What kind of change does this PR introduce?

[x] Feature

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Does this PR release a new version?

[ ] Yes
[x] No

Your pull request doesn't follow our contribution guidelines. Please review and correct it.

@vmunich submit another PR to bump it to 2.5.24


(mini.starter) unnecessary slowdown while checking is_something_shown

Contributing guidelines

[X] I have read CONTRIBUTING.md
[X] I have read CODE_OF_CONDUCT.md
[X] I have updated 'mini.nvim' to latest version

Module(s)
mini.starter
Description
Opening large files directly with nvim + mini.starter causes unnecessary slowdown
Neovim version
v0.10.0-dev-2218+ga757195a6-dirty
Steps to reproduce

yes mini | head -n 500000 > example-file
nvim example-file

This takes starter around 30ms to check if there is something shown
Expected behavior
run checks in reverse order to speed up process (args, buffers, lines)
Actual behavior
processing time of M.is_something_shown is slow
with large json files (~18M, ~750000 lines) it takes around 150ms (according to lazy.nvim profiler)

Thanks for the issue!
Yes, I could reproduce this. Should now be fixed on latest main (ended up also slightly improving check for actually shown lines, hence didn't merge #681 right away).


Main cdkv2 merge 02272023

Description of changes
Main -> cdkv2 merge

CDK / CloudFormation Parameters Changed

Issue #, if available

Description of how you validated changes
Checklist

[x] PR description included
[x] yarn test passes
[ ] Tests are changed or added
[ ] Relevant documentation is changed or added (and PR referenced)
[ ] New AWS SDK calls or CloudFormation actions have been added to relevant test and service IAM policies
[ ] Any CDK or CloudFormation parameter changes are called out explicitly

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Codecov Report

Merging #1308 (11188d7) into cdkv2 (db09f15) will not change coverage.
The diff coverage is n/a.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@           Coverage Diff           @@
##            cdkv2    #1308   +/-   ##
=======================================
  Coverage   63.64%   63.64%
=======================================
  Files         304      304
  Lines       19050    19050
  Branches     4569     4569
=======================================
  Hits        12125    12125
  Misses       6291     6291
  Partials      634      634

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


[Feature Request] Some way to specify random numbers for randomly weighting terms/loras/hypernetworks/etc

It would be nice to be able to generate random numbers for use in term weighting.  Something like:
{#0.1-1.4|0.05#}
...which would generate a random number between 0.1 and 1.4 with a precision of 0.05 (for instance 0.6 or 1.15).  Syntax is just a suggestion; I don't really care how it's implemented.
The current work-around is to have a list of individual numbers in a file, but this would be a lot more convenient.

Have you had a look at Jinja templates? https://github.com/adieyal/sd-dynamic-prompts/blob/main/jinja2.md


sync

@cla/google the CLA failures are from commits contributed to the project before the CLA policy was in place. we're syncing across branches (from master into an active dev branch). the CLA policy will continue to be enforced for new contributions to the project.

tests failing because the testfiles  submodule is pointing back at master, not the dynamic branch. fixing this now.


fix: clean cached column information on delete

Fixes https://github.com/electric-sql/electric/issues/1550.
This PR extends the shape log collector to also clean the cached column information from ETS when a relation changes. This ensures that when a table is migrated, we don't re-use the old table information from ETS but instead load it from Postgres and re-populate the cache with the new column info.
There's one corner case that this PR does not address:

Create table, insert data
Sync a shape containing that table
Drop the table
Delete the shape
Recreate the table but with a different schema
Insert some data into the new table
Sync a shape containing the newly recreated table

In the above scenario, when syncing the newly recreated table, we get the new data but in the old schema (so we only get the columns that also existed in the old schema). This is because Postgres logical replication stream does not inform us when a table is dropped.
As a result, we can't detect that a table was dropped and thus don't know that we need to clean the cached column information. It's only when we get a Relation message that we know this. But Postgres only sends a Relation message the first time the data in the table changes and we're subscribed to that table in the replication stream (and that's only after syncing the shape).
So, the data that was inserted before we synced the table in the last step, does not lead to a Relation message. Only if we insert data into the table after that sync step, will Postgres send a Relation message that will make us clean the cached column information. But note that at that point the row that was inserted in the previous step is already stored in storage in the format of the old schema.

@magnetised i'm feeling your pain :D spent the day rebasing this one on top of storage changes

@magnetised Thanks for your review. As discussed in DM, i won't move the unit tests as you have an upcoming PR that moves the code that handles relation changes out of the genstage. So the unit tests can be moved together with that change.


Adding 'Edit in CartoDB' link to new public map

Basically checking if logged user and map owner are the same.

Frontend tests were OK :+1: (details)

Frontend tests were OK :+1: (details)

Please @javierarce, could you take care of and release this thing tomorrow? thanks :).

Sure :)


Dialac dev

This is the refactoring class for Array.Sort method.
This work is tracked by Issue - https://github.com/ellismg/corefx/issues/13
One change that happened since the issue was filled is that Instead of having Sorting Class generic, I made the method Sorting.Sort Generic because of backwards compatibility for the existent overloaded methods that receives Key and Value pair.

Would you mind doing a pass over this and removing the commented out code if it's not needed?


[Agent][Enhancement]Unify system in agent and chat model

统一agent与chat models中传入的系统消息的变量名为system，与底层api保持一致，同时无需用户自定义SystemMessage
修改functions typing遗漏
当chat models与agent 都定义了system时，以agent为主，增加warning

Codecov Report
Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (f33750f) 70.70% compared to head (7dd90db) 69.50%.
Report is 8 commits behind head on develop.

Files
Patch %
Lines

erniebot-agent/src/erniebot_agent/agents/agent.py
75.00%
1 Missing :warning:

...-agent/src/erniebot_agent/agents/function_agent.py
80.00%
1 Missing :warning:

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #271      +/-   ##
===========================================
- Coverage    70.70%   69.50%   -1.21%
===========================================
  Files           62       63       +1
  Lines         3106     3223     +117
===========================================
+ Hits          2196     2240      +44
- Misses         910      983      +73

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

close due to #272


Log queries

Solves https://github.com/CartoDB/CartoDB-SQL-API/issues/573
Tasks:

Remove the old query system
Added the parameter logQueries to enable or disable queries log
Handle queries in middleware and save them in res.locals.sql
Using the previous middleware in query, job, and copy controllers endpoints
Generic log middleware (using headers system X-SQLAPI-Log). Now it is only used for queries log, but it could be the solution to change string log to JSON log
Using log middleware only in query and job controllers endpoints. Copy endpoints use their log
extracting stringifyForLogs function and refactor to avoid modifying the original

Good work mate :)


EEGLOGER

Operating system: ✍ TODO
Last upstream commit (run git log --author="Robert Lord" | head -n 1): ✍ TODO
language version:(nodejs version, ruby version ....) ✍ TODO
Cortex version:  ✍ TODO

✍ TODO write your issue here
Hi all,
pls help me this problem,
I run this program on March, it's ok;
but now, when I run the program EEGLOGER which I download on this website,
I receive this message:
Message Error recieved from CortexAccess.CortexClient
Recieved: -32041 : EULA has not been accepted by the user follow this url https://www.emotivcloud.com/dbapi/privacy/doc/eula/
pls help me correct it
thank so much
my email<EMAIL_ADDRESS>

@QUANGCHUYEN  Because GDPR from european union. So, user need to accept our eula to continue use our system.
You call this api to accept eula

Thanks for your reply, but I don't master about JSON-RPC,
would you please translate its code into C# or not?
Regards,
Vào Th 5, 9 thg 8, 2018 vào lúc 16:50 Cuong Trinh Manh <
<EMAIL_ADDRESS>đã viết:

@QUANGCHUYEN https://github.com/QUANGCHUYEN Because GDPR from european
union. So, user need to accept our eula to continue use our system.
You call this api to accept eula
https://emotiv.github.io/cortex-docs/#acceptlicense
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/Emotiv/cortex-example/issues/36#issuecomment-411702795,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AkJO6QG4NT-ZlsNIsVvzUF78u0pFjTIRks5uPAXqgaJpZM4V1WP-
.

--
Lâm Quang Chuyên
Trường Cao đẳng Công thương TP. Hồ Chí Minh
20, Tăng Nhơn Phú, Phước Long B, Quận 9
Khoa Điện - Điện tử
Mobile: 0908.019.720

Hi All,
I downloaded cortex-example and run on C Sharp, it's ok,
But data was display on console panel so I can get it to analysis and process,
I want to get data draw the chart on Window form,
Please help me do this,
Thank so much
Regards,

@QUANGCHUYEN , our example only is basic code to show how is work with Cortex. For the implementation in project, you should do it by yourself

Thank for your soon reply,
Regards,
Vào Th 2, 27 thg 8, 2018 vào lúc 09:38 Cuong Trinh Manh <
<EMAIL_ADDRESS>đã viết:

@QUANGCHUYEN https://github.com/QUANGCHUYEN , our example only is basic
code to show how is work with Cortex. For the implementation in project,
you should do it by yourself
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/Emotiv/cortex-example/issues/36#issuecomment-416098257,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AkJO6Q82hCGomMn6PwVtxmdUHwewEq1sks5uU1uZgaJpZM4V1WP-
.

--
Lâm Quang Chuyên
Trường Cao đẳng Công thương TP. Hồ Chí Minh
20, Tăng Nhơn Phú, Phước Long B, Quận 9
Khoa Điện - Điện tử
Mobile: 0908.019.720


fix: fix storybook by wrapping all Vis in VisProvider

Closes https://github.com/datavisyn/visyn_core/issues/109
Developer Checklist (Definition of Done)
Issue

[ ] All acceptance criteria from the issue are met
[ ] Tested in latest Chrome/Firefox

UI/UX/Vis

[ ] Requires UI/UX/Vis review

[ ] Reviewer(s) are notified (tag assignees)
[ ] Review has occurred (link to notes)
[ ] Feedback is included in this PR
[ ] Reviewer(s) approve of concept and design

Code

[ ] Branch is up-to-date with the branch to be merged with, i.e., develop
[ ] Code is cleaned up and formatted
[ ] Unit tests are written (frontend/backend if applicable)
[ ] Integration tests are written (if applicable)

PR

[ ] Descriptive title for this pull request is provided (will be used for release notes later)
[ ] Reviewer and assignees are defined
[ ] Add type label (e.g., bug, feature) to this pull request
[ ] Add release label (e.g., release: minor) to this PR following semver
[ ] The PR is connected to the corresponding issue (via Closes #...)
[ ] Summary of changes is written

Summary of changes

Fixes storybook by wrapping all Vis in VisProvider (this is now necessary and usually done automatically via VisynApp).
Also, changed the displayName for the SelectItem as the @ broke the storybook build (for some reason...)

Screenshots
Additional notes for the reviewer(s)

Thanks for creating this pull request 🤗

Closed in favor of https://github.com/datavisyn/visyn_core/pull/101


[Adblock BUG] Describe bug.

it dosent wanna work at all.
Steps to replicate
Necessary screenshots
Spicetify.
Config file: the add blocker dosentwanan seem tow ork. i tried several ways from unstalling spicetify to unstall ad blocker and re downloding it and its enabled too so idk what is interferring with the ad blocker. it used to work but not anymoe

Yup, straight up broken, doesn't block ads at all.


Ignore Difficult_Case set to True

Hello @YuwenXiong
I have a doubt regarding ignoring difficult_case while training/testing on Pascal0712.
As per my understanding, for both training and testing phase, difficult annotation from pascal data is ignored which is set in pascal_voc.py
# PASCAL specific config options
self.config = {'cleanup'     : True,
'use_salt'    : True,
'use_diff'    : False,
'matlab_eval' : False,
'rpn_file'    : None,
'min_size'    : 2}
As per my understanding, one should not ignore difficult_case atleast for evolution because if network is able to detect difficult example from test set, it will be treated as false alarm since there is no ground truth available to evaluate.
Please correct me if my understanding is wrong.
Thank you

I'm not sure whether I understand your question, and the 'use_diff' is used only during training https://github.com/YuwenXiong/py-R-FCN/blob/master/lib/datasets/pascal_voc.py#L260.


how

make a vid on how its done bec i cant run it for some reson

Hello @mohannad1220, I don't have worked on this project for a long time. Sorry for that.
Do you need any help? Can you explain me more precisely the problem?
Sorry I don't have time to make a video to explain how this bot works.
You can contact me on Discord if needed (Utarwyn#1334).


fix: get fees by id then update status to paid or late

merged differently on https://github.com/hei-school/hei-admin-api/blob/a1457e89662ea0350c07d85f4ff1b904551aa111/src/main/java/school/hei/haapi/service/FeeService.java#L101


respawnWorld property not working

I'm trying to make people respawn in the world they die in, but it respawns them in a totally different world. I keep trying to use /mvmset respawnWorld filchallenge, but i keep respawning in my Arena world.

If you still face issue, please create a new issue and use the new issue template


relax component path linter to apply only to those with translations

This relaxes our linter to not apply the component path rule to components that don't have translations.
The reason components with translations must be in a bundles/ directory is to imply the namespace for the translation strings.
PTAL @yangsu @bryan-coursera

LGTM


Provide the /containers//resize endpoint

This can be merged with the function that implements the /exec//resize
endpoint, since they are almost identical. Note that the Docker CLI does this
too.
Signed-off-by: Miquel Sabaté<EMAIL_ADDRESS>

Note that I've also removed the client.URL.String() on the URL, since I was getting a 301 from the server.


Extend davidson for complex operator

This should fix #127

This fails if the starting vector phi0 (in the test case, this is v) is real. I'll submit a pull request.


Task and chain not working on the project it says it is working on inside the working directory

Description
After that issue with it not going into the directory to create a directory that it needs to work on whatever project it says its working on /project/component/file.whatever  and it is really not doing anything or writing as its going through.
Steps to Reproduce the Bug
1.Run a task chain that requires navigating though directories etc..
Expected Behavior
To be able to work on the project and have a general sense of what its doing instead of saying oh I'm working on x thing but not doing x that inside of x directory when clearly its not and its just doing nothing.
Operating System

[X] Linux
[ ] Microsoft Windows
[ ] Apple MacOS
[ ] Android
[ ] iOS
[ ] Other

Python Version

[ ] Python <= 3.9
[X] Python 3.10
[ ] Python 3.11

Environment Type - Connection

[X] Local - You run AGiXT in your home network
[ ] Remote - You access AGiXT through the internet

Runtime environment

[ ] Using docker compose
[X] Using local
[ ] Custom setup (please describe above!)

Acknowledgements

[X] I have searched the existing issues to make sure this bug has not been reported yet.
[X] I am using the latest version of AGiXT.
[X] I have provided enough information for the maintainers to reproduce and diagnose the issue.

Not all tasks will work with files, many may not.  If you're specifically needing the AI to look in a directory for things like code or files, you will need to tell it where that file is in your prompt, otherwise it will assume.


Booking Event Flow Change

Change flow of booking so that user type can automatically be assigned if there is only one ticket you can possibly book.  e.g. Mentor or Parent (only match with the Mentor or Parent ticket type)
If there are multiple ticket types that a user can book in for either one or multiple tickets. e.g. Scratch, Hardware, Laptop.
Allows user to clearly see what they are booking in for.
Setup would be;
Rosa (Mentor) - [Dropdown to ticket options] or [Book - if only one option]

The idea is to reverse the display logic : instead of making it session oriented as it is atm, it should be user oriented.
This way, you easily see what you're booking for, both for yourself or your children

Most important, if you have 2 tracks and a capacity of 30 you can potentially end up with 60 ninja's.
Another possibility, and probably easy quick fix, is to be able to set a max capacity for your dojo.
This way you can have 30 tickets for each track, but close the ticketing as soon as a total of 30 have been booked.
You would also need to be able to make ticket types as not counting so ninja's are able to book extra things like laptops etc.

Should this maxCapacity defaulted to a caculation based upon the number of mentor? 1 for 5 ?

Probably better for Champions to set capacity as they will have to take
into account Mentors and venue capacity!
On 15 April 2016 at 14:54, Wardormeur<EMAIL_ADDRESS>wrote:

Should this maxCapacity defaulted to a caculation based upon the number of
mentor? 1 for 5 ?
—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
https://github.com/CoderDojo/community-platform/issues/953#issuecomment-210471966

--
Rosa Langhammer
Reporting Lead
@RosaLanghammer | @CoderDojo
--
Volunteer at your local Dojo and inspire the next generation of digital
creators!

Pledge to start a Dojo https://coderdojo.com/pledge-a-dojo/
How to volunteer at your local CoderDojo
https://coderdojo.com/get-involved/volunteer/
Read the CoderDojo Foundation Strategy
https://coderdojo.com/news/2015/08/07/the-coderdojo-foundation-strategy-20152016/

--
Hello World Foundation operating as the CoderDojo Foundation is a company
limited by guarantee not having a share capital with charitable status, CHY
20812. Registered in Dublin, Ireland, No 524255. Registered Office:
Dogpatch Labs, Unit 1, CHQ Building, Custom House Quay, Dublin 1, Ireland.

Exactly what I meant @rosalanghammer :)

@ChristianVermeulen have opened a new issue for this - may make the booking flow a bit more complex so would be great to get some comments on it. See #954

Parent are now automatically booked and tickets are filtered on the kind of users you are :

children -> ninja;
adult mentoring -> mentor;
adult accompagning -> "parent" (hidden)


chore: script for by linebreaks

Not quite sure if the -i inplace part will work on all systems...

It might be good, as suggested by @digama0 to run this when generating the files for mathlib3port

Can mathport do this for us?

I think that would be very good!
In fact it might even do this for lines of length 98, 99 and 100, resulting in some linter warning, that the person porting can take care of manually in those cases, because with this script those cases are not taken care of.

mathport used to get the by location correct (at least more of the time), it seems things changed in the run that resulted in https://github.com/leanprover-community/mathlib3port/commit/27def984dfd287bf25cbc09ac35d7bdcc475fe29.
But the old version has a lot of weird layout in declarations, as well.
It's also not clear to me what actually changed to cause the new layout...

Could you add a 1-2 line comment explaining what the script does (e.g. # Modify all lean files in mathlib to put "by" at the end of the previous line, where possible)?

mathport used to get the by location correct (at least more of the time), it seems things changed in the run that resulted in leanprover-community/mathlib3port@27def98. But the old version has a lot of weird layout in declarations, as well. It's also not clear to me what actually changed to cause the new layout...

That run was mathport #544, and if you look at the CI page from around then you will notice that that run was preceded by mathport being broken for several days, during which there was a lean bump from lean4:nightly-2022-12-16 to lean4:nightly-2022-12-22. During that period the most likely commits that could have caused this are

fix: Format.align always prints whitespace by gebner
fix: parenthesize by optParam values by Kha
refactor: remove redundant state by Kha

Could you add a 1-2 line comment explaining what the script does (e.g. # Modify all lean files in mathlib to put "by" at the end of the previous line, where possible)?

Done


Update start_linux.sh

added auto install dependencies of index.py on linux

Don't want people to forcefully install every time

shall I use inputs for installing dependencies?

Don't want people to forcefully install every time

I agree, it also creates a big wall of text (which can be hidden by running pip in silent mode)
You also don't want to ask the user if they want to install dependencies every time they run start_linux.sh, that'd just be irritating! The README goes over how to install the dependencies. No need to have it done in the start script.

ok


[BUGFIX] Remove duplicated project command in CMakeLists.txt

Description
Remove duplicate project command in the CMakelists.txt file.
Checklist
Essentials

[x] PR's title starts with a category (e.g. [BUGFIX], [MODEL], [TUTORIAL], [FEATURE], [DOC], etc)
[x] Changes are complete (i.e. I finished coding on this PR)
[x] All changes have test coverage
[x] Code is well-documented

Changes

[x] CMakelists.txt

@leezu
Fix this issue https://github.com/apache/incubator-mxnet/issues/20464


RequestReferer should be in the Rails namespace, not Style

It seems to me that the Style/RequestReferer cop that was (suggested in #3171, implemented in #3105) should be a Rails cop. Actually, #referer/#referrer are implemented in Rack, not Rails, but I guess it’s a Rails cop nonetheless.

Definitely. This was an oversight on my part.

I’ll whip up a PR.


Validate plugin PRIORITY and VERSION fields upon loading

Adds stricter checks on plugins when loading. Priority must be a valid integer (not inf nor NaN), and the version must be parseble as x.y.z.
This means the pre-functions plugin now has a PRIORITY = 1000000, which previously was +inf.
review: best reviewed without whitespace changes

@Tieske Does this mean all external plugins needs to have Version and Priority defined?

@Tieske Does this mean all external plugins needs to have Version and Priority defined?

Yes, so it's a breaking change. But it's for the better imho since it allows for better control of plugins, they should have it anyway. Only thus far they got away without it.


[WIP] Adding SAX+MINDIST to KNN

This PR contains the following changes:

'sax' is now a valid metric for KNN:

knn = KNeighborsTimeSeriesClassifier(n_neighbors=1, metric='sax')

Added BaseEstimator to classes in preprocessing module so that they can be used within a Pipeline (errors were raised when using TimeSeriesScalerMeanVariance)

Fixed a bug in kneighbors method which would always return [0] as nearest neighbor for every sample.

knn = KNeighborsTimeSeriesClassifier(n_neighbors=1, metric='dtw')
knn.fit(X_train, y_train)
_, ind = knn.kneighbors(X_test)
# ind would be filled with 0's

Slightly changed to code of kneighbors so that its result is consistent with sklearn. There was a small difference in breaking ties (tslearn would pick largest index while sklearn would pick the smallest index). Now the following code is equivalent:

knn = KNeighborsTimeSeriesClassifier(n_neighbors=1, metric='dtw')
knn.fit(X_train, y_train)
_, ind = knn.kneighbors(X_test)

knn = KNeighborsTimeSeriesClassifier(n_neighbors=1, metric='precomputed')
all_X = numpy.vstack((X_train, X_test))
distances = pairwise_distances(all_X, metric=dtw)
X_train = distances[:len(X_train), :len(X_train)]
X_test = distances[len(X_train):, :len(X_train)]
knn.fit(X_train, y_train)
_, ind = knn.kneighbors(X_test)

# both ind vectors are now equal (while that was not the case before this PR)

Some remarks:

I am unexperienced with numba; adding an njit decorator to cdist_sax did not work immediately, I could perhaps use some help with that.

Hello @GillesVandewiele! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

In the file tslearn/docs/examples/plot_sax_mindist_knn.py:

Line 6:64: W291 trailing whitespace
Line 42:5: E265 block comment should start with '# '
Line 43:5: E265 block comment should start with '# '
Line 45:5: E265 block comment should start with '# '
Line 46:5: E265 block comment should start with '# '
Line 48:5: E265 block comment should start with '# '
Line 53:5: E265 block comment should start with '# '
Line 54:5: E265 block comment should start with '# '
Line 63:1: E302 expected 2 blank lines, found 1
Line 89:1: E305 expected 2 blank lines after class or function definition, found 1
Line 111:31: W292 no newline at end of file

In the file tslearn/docs/examples/plot_sdtw.py:

Line 65:80: E501 line too long (80 > 79 characters)

In the file tslearn/metrics.py:

Line 29:77: W291 trailing whitespace
Line 61:68: W291 trailing whitespace
Line 62:69: W291 trailing whitespace
Line 432:80: E501 line too long (80 > 79 characters)
Line 442:49: W605 invalid escape sequence '_'
Line 442:55: W605 invalid escape sequence '_'

In the file tslearn/neighbors.py:

Line 59:43: W291 trailing whitespace
Line 99:76: E261 at least two spaces before inline comment
Line 99:76: E262 inline comment should start with '# '
Line 99:80: E501 line too long (115 > 79 characters)
Line 334:69: W291 trailing whitespace
Line 337:64: W291 trailing whitespace

I merged with the latest dev branch before working futher, hence why @AKuederle his commits are in here as well. #GitNoob

Could also maybe important to note that the technique doesn't really work that well, the results are quite consistent with the paper though, but I thought SAX would work insanely fast, which turns out not to be the case currently:
|      dataset       | sax error  |  sax time  | eucl error | eucl time  |
--------------------------------------------------------------------------
|    SyntheticControl|     0.02667|        0.12|        0.12|     0.06491|
|            GunPoint|     0.20667|     0.08667|     0.08667|     0.00989|
|             OSULeaf|     0.47521|     0.47934|     0.47934|     0.03286|
|               Trace|        0.52|        0.24|        0.24|     0.01209|
|            FaceFour|     0.14773|     0.21591|     0.21591|     0.01297|
|          Lightning2|     0.21311|      0.2459|      0.2459|     0.00842|
|          Lightning7|     0.46575|     0.42466|     0.42466|     0.00799|
|              ECG200|        0.12|        0.12|        0.12|     0.00945|
|                Fish|     0.50286|     0.21714|     0.21714|     0.02922|
|               Plane|     0.04762|      0.0381|      0.0381|     0.01164|
|                 Car|        0.35|     0.26667|     0.26667|     0.00749|
|                Beef|     0.53333|     0.33333|     0.33333|     0.00439|
|              Coffee|     0.46429|         0.0|         0.0|     0.00389|
|            OliveOil|     0.83333|     0.13333|     0.13333|      0.0043|
--------------------------------------------------------------------------

Great @GillesVandewiele
I will try to review this PR asap, probably early next week. I am still unsure if we should target to get a fast SAX+MINDIST in this PR or delay that to a later PR.

Hi @rtavenar there's no rush in reviewing I'd say. I still need to fix Travis etc, so maybe after that passes reviewing is more appropriate.

That looks great @GillesVandewiele !
Maybe a minimal test would be to check that the distances returned by kNN's kneighbors are indeed lower bounding L2 (I think they should be, if I remember the original paper correctly, but maybe it would be worth checking :)
Hope this helps

Codecov Report

Merging #152 into dev will decrease coverage by 0.22%.
The diff coverage is 84.21%.

@@            Coverage Diff             @@
##              dev     #152      +/-   ##
==========================================
- Coverage   93.99%   93.76%   -0.23%
==========================================
  Files          22       22
  Lines        2829     2982     +153
==========================================
+ Hits         2659     2796     +137
- Misses        170      186      +16

Impacted Files
Coverage Δ

tslearn/tests/test_neighbors.py
100% <100%> (ø)
:arrow_up:

tslearn/metrics.py
96.18% <72.22%> (-1.35%)
:arrow_down:

tslearn/neighbors.py
84.9% <78.26%> (-0.32%)
:arrow_down:

tslearn/preprocessing.py
93.24% <93.33%> (+1.3%)
:arrow_up:

tslearn/barycenters.py
94.11% <0%> (-2.92%)
:arrow_down:

tslearn/tests/test_barycenters.py
100% <0%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b8d50c5...550f846. Read the comment docs.

Hi Romain, I added the test. I'm not sure how this codecov report is actually generated, it's weird that it is reporting about barycenters.py in this PR...
There's also one other point that's maybe worth discussing. Currently, I always perform a SAX transformation on the provided input data, but this then actually assumes that the user has not already done that. Moreover, the current SAX transformation will fail pretty badly if the data is not standard-normalized. So maybe it could be better to actually change the metric to mindist and require the user to standard-normalize + sax-transform the data?

@GillesVandewiele
This is a very good question. I do not think we can use Pipelines here, because we need parameters of the previous step for the distance computation, so I guess the way you did it is reasonable, or at least I do not see a more straight-forward approach.
Maybe having a Pipeline (standardize + SAX kNN) in your gallery example (together with some comment saying that this is good practice for SAX to standardize your data beforehand) would be a good idea. And a note in the kNN doc (under the metric param) also.
Let me know when I should start my review, I could probably do it next week if you feel your code is in sufficiently advanced state.
Have a nice week-end,
Romain

Two other options would be the following:

always standard-normalize the input that we get. As far as I know, standard-normalizing is quite idempotent (so normalizing data that is already normalized will not really have great effects). Moreover, we do the normalization per timeseries individually which makes it a lot easier to do this as well.

Perform some hypothesis testing on (a sample of) the input data and raise a warning or perform normalization when results of hypothesis test are that the data isn't normally distributed.

What do you want me to do about the codecov btw?

Hi,
I would be in favor of option 1.
However,

this should be documented
normalization should be performed dataset-wise, not per time series, in this case, I think

Concerning codecov, I can have a look when I'll do a review.

Forgot to mention it yesterday, but I think the code is now ready to be reviewed, whenever you have time @rtavenar. I refactored quite a lot of code in neighbors.py so we definitely need to be careful there.

I did not find time to review it this week, sorry. I hope I can do it next week.

Hi @GillesVandewiele
Sorry for the delay. I have made my review, not much to say (except individual comments), this seems to be in pretty advanced state, thanks for this!

Thanks for this Romain!
Small heads up: I'll be abroad for three weeks, including two weeks without laptop starting from today though. I'll do my best to integrate as much comments as possible!

No problem, of course!

Oh, and before I forget.. Do you happen to know why the codecov is complaining (about code unrelated to this PR)?

No, but I do not really care (I could take care of that just before merging to master, if necessary)

Did the tensorflow version for tslearn recently got upgraded to >= 2? Seems like Travis is failing due to the fact that set_random_seed is no longer a valid import...

Did the tensorflow version for tslearn recently got upgraded to >= 2? Seems like Travis is failing due to the fact that set_random_seed is no longer a valid import...

I changed requirements.txt on master so that tensorflow version is < 2, but did not change it on dev: could you do it in your PR?

I just refactored code for cdist calls, FYI, I will have to resolve conflicts before merge.

Hi @GillesVandewiele ,
When you have time to take my last comments into account, we could proceed to merge.
No hurry (I am myself very busy these days so I can understand if you are too :)

Hey @rtavenar,
Just arrived back in Belgium after three weeks of travelling around in New-Zealand in which I tried to refrain from working as much as possible :laughing:. You can expect an update on this PR in the nearby future!

I think I've handled most comments now (left responses on some), I also refactored the PAA a bit so that it can now handle variable-length time series, which was required so that SAX can handle it as well. This was discovered by extending the variable_length test. The code for that could perhaps be more efficient/vectorized though:
    def _transform(self, X, y=None):
        n_ts, sz, d = X.shape
        X_transformed = numpy.empty((n_ts, self.n_segments, d))
        for i_ts in range(n_ts):
            for i_dim in range(d):
                sz = numpy.sum(~numpy.isnan(X[i_ts, :, i_dim]))
                sz_segment = sz // self.n_segments
                for i_seg in range(self.n_segments):
                    start = i_seg * sz_segment
                    end = start + sz_segment
                    segment = X[i_ts, start:end, i_dim]
                    X_transformed[i_ts, i_seg, i_dim] = numpy.nanmean(segment)

Seems like Travis succeeds except that it takes quite some time for python2 (had to increase travis_wait), that all pep8 issues are solved as well, and that the coverage has increased :)

Thanks! I should be available for a review by the end of the week.

I think I've handled most comments now (left responses on some), I also refactored the PAA a bit so that it can now handle variable-length time series, which was required so that SAX can handle it as well. This was discovered by extending the variable_length test. The code for that could perhaps be more efficient/vectorized though:
    def _transform(self, X, y=None):
        n_ts, sz, d = X.shape
        X_transformed = numpy.empty((n_ts, self.n_segments, d))
        for i_ts in range(n_ts):
            for i_dim in range(d):
                sz = numpy.sum(~numpy.isnan(X[i_ts, :, i_dim]))
                sz_segment = sz // self.n_segments
                for i_seg in range(self.n_segments):
                    start = i_seg * sz_segment
                    end = start + sz_segment
                    segment = X[i_ts, start:end, i_dim]
                    X_transformed[i_ts, i_seg, i_dim] = numpy.nanmean(segment)

Seems like Travis succeeds except that it takes quite some time for python2 (had to increase travis_wait), that all pep8 issues are solved as well, and that the coverage has increased :)

Hum, I agree that we can no longer vectorize on the first dimension (since different time series can have different lengths), but the assumption is that, for a time series, all modalities have the same length, so we could probably vectorize on that and get a mix between original version and your version, something like:
    def _transform(self, X, y=None):
        n_ts, sz, d = X.shape
        X_transformed = numpy.empty((n_ts, self.n_segments, d))
        for i_ts in range(n_ts):
            sz_segment = ts_size(X[i_ts]) // self.n_segments
            for i_seg in range(self.n_segments):
                start = i_seg * sz_segment
                end = start + sz_segment
                X_transformed[i_ts, i_seg, :] = X[i_ts, start:end, :].mean(axis=1)

Hi @GillesVandewiele
Do you think you could find time to finalize this PR soon?
Romain

Hi @rtavenar
I am so sorry that this have been dragging on for so long... I will try to finalize it this weekend! It should not be too much of work anymore.
Kind regards,
Gilles

Hi @rtavenar
I am so sorry that this have been dragging on for so long... I will try to finalize it this weekend! It should not be too much of work anymore.
Kind regards,
Gilles

No pb! That's perfect if you can finalize it soon.

I handled most of the feedback and left some comments where needed.

One test if failing for KNN with SAX. My guess would be that
X = to_time_series_dataset([[1, 2, 3, 4],
                            [1, 2, 3],
                            [2, 5, 6, 7, 8, 9],
                            [3, 5, 6, 7, 8]])

is transformed into SAX with two segements
clf = KNeighborsTimeSeriesClassifier(metric="sax", n_neighbors=1,
                                     metric_params={'n_segments': 2})

and all the new time series are equal to [0, 1], and when you perform classification with 1NN you may get the class of the first sample (np.argmin returns the first index).
Could you try to print the SAX transformation for this dataset? You could also try to make the time series for class 1 decreasing instead of increasing, it should fix this.

One test if failing for KNN with SAX. My guess would be that
X = to_time_series_dataset([[1, 2, 3, 4],
                            [1, 2, 3],
                            [2, 5, 6, 7, 8, 9],
                            [3, 5, 6, 7, 8]])

is transformed into SAX with two segements
clf = KNeighborsTimeSeriesClassifier(metric="sax", n_neighbors=1,
                                     metric_params={'n_segments': 2})

and all the new time series are equal to [0, 1], and when you perform classification with 1NN you may get the class of the first sample (np.argmin returns the first index).
Could you try to print the SAX transformation for this dataset? You could also try to make the time series for class 1 decreasing instead of increasing, it should fix this.

Thanks Johann! Let me see if I can fix it :)

LGTM, thanks Gilles! @rtavenar

No thank you for again some great feedback! Always a great learning experience to do a PR here! Now next up should be some improvements for the ShapeletModel. I hope I can do it faster than this one ;)

This looks good to me too. I had a simple comment regarding the documentation and my last comment is that you can document your changes in the changelog before merge.
Great job, once again, thanks @GillesVandewiele !

Hi Romain,
Thanks! Where/how do you want me to add it to the changelog? Do I add the following just on top?
## [v0.3.0]

### Changed
* TimeSeriesScalerMeanVariance and TimeSeriesScalerMinMax are now completely sklearn-compliant
* Bugfix in kneighbors() methods.

### Added
* Nearest Neighbors on SAX representation (with custom distance)
* Calculate pairwise similarity matrix between SAX representations
* PiecewiseAggregateApproximation can now handle variable lengths

Yes you can create a ## [Towards v0.4.0] section and describe your changes there.

Alright done! :)