create scale-codec-comparator

Project Abstract

Please provide a brief description of your project here summarising key points (1-2 paragraphs).
If your application is a follow-up to a previous grant, please mention which one in the first line of the abstract and include a link to previous pull requests if applicable.

For which grant level are you applying?

[ ] Level 1:  Up to $10,000, 2 approvals
[x] Level 2:  Up to $50,000, 3 approvals
[ ] Level 3:  Unlimited, 5 approvals (for > $100k Web3 Foundation Council approval)

Application Checklist

[x] The application template has been copied, renamed ( project_name.md) and updated.
[x] I have read and understood the FAQs, application guidelines and announcement guidelines.
[x] A BTC or Ethereum (DAI/USDT) address for the payment of the milestones is provided inside the application.
[x] I have read and acknowledge the terms and conditions.
[x] The software delivered for this grant will be released under an open-source license specified in the application.
[x] The initial PR contains only one commit (squash and force-push if needed).
[x] The grant will only be announced once the first milestone has been accepted.
[x] I prefer the discussion of this application to be in a private Element/Matrix channel. My username is: @gmajor:matrix.org

How Did You Hear About our grants program?

[x] Social Media
[ ] Hackathon
[ ] Personal Recommendation
[ ] Substrate Builders Program
[ ] Investor/VC
[ ] Online Search
[ ] Other: _______

Sorry, @gmajor-encrypt. I merged your PR prematurely. Could you submit it again? Sorry for the hassle.

@semuelle OK, I resubmit my PR again, https://github.com/w3f/Grants-Program/pull/953


Appinstaller and scale-specific asset packages - question

I originally posted the question below in the WindowsAppSDK repo (https://github.com/microsoft/WindowsAppSDK/discussions/1690), but was told this might be a better place (apologies if you don't accept questions).
This is a simple question about what happens if I install an msixbundle from an appinstaller file on the web rather than the Microsoft Store. The msixbundle has several asset packages for different scales (from 100 to 400) that were automatically created as separate packages in the bundle by Visual Studio. My question is what happens when the display scale changes after the initial install, so that a different scale-specific package becomes more appropriate. Will Windows automatically download and install the new scale-specific package? If so is that immediately or in a few hours time etc and does it require the appinstaller to specify automatic updates? Does it work the same for both regular and flat bundles? I could probably do a test but it would be quite time consuming and I don't know exactly how to confirm it has installed the new scale-specific package, so I was hoping someone in the know could answer here.

Hi Ben,
As of 20H1, changes to the scale settings will trigger appinstaller-based automatic updates the next time an update would normally take place (see https://docs.microsoft.com/en-us/uwp/schemas/appinstallerschema/element-update-settings). This works for regular bundles and flat bundles.
Best regards,
Jonathan

Thanks for the reply. Just to clarify, what happens if the appinstaller file does not specify automatic updates? Will the scale packages be downloaded on next manual update?

If the appinstaller file doesn't specify automatic updates or the user performs a manual update directly through the appxbundle, then the scale packages will be downloaded as part of the manual update.

Ok, thanks a lot for the info.


feat(typography): allow override of line heights

:tada: This PR is included in version 4.6.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


⚠ Processors has degraded performance

In 59aa283, Processors ($STATUS_URL) experienced degraded performance:

HTTP code: 200
Response time: 83 ms

Resolved: Processors performance has improved in 9895835.


Not using exceptions for flow control if suppress exceptions is enabled

@kallestenflo Requesting your approval for this

This has introduced breaking changes in 2.7.0 vs 2.6.0. For instance now set throws and exception when the path is not present in the target JSON.
I can't find any explanation of why this change was introduced or whether the project follows semantic versioning, so I'd really appreciate some clarification on those topics 🙇

@r0goyal @abelsromero  Maybe we should add an option to create an absent path, to handle each of use cases. But at least I'd wanted to get any ideas which problem this PR is solving to get more context on this.

I found another change in behavior from this change.  The following snippet used to return null under 2.6.0 and it now fails under 2.7.0. Since SUPPRESS_EXCEPTIONS is configured, I would have expected no exceptions to be propagated.
        final String json = "{\"value\" :  null" + "}";
        final Configuration configuration = Configuration.builder()
                .jsonProvider(new JsonOrgJsonProvider())
                .mappingProvider(new JsonOrgMappingProvider())
                .options(Option.SUPPRESS_EXCEPTIONS).build();
        String value = JsonPath.using(configuration).parse(json).read("$.value");
        System.out.println(value);

2.6.0 value = null
2.7.0
Exception in thread "main" com.jayway.jsonpath.JsonPathException: org.json.JSONException: JSONArray[0] not found.
	at com.jayway.jsonpath.spi.json.JsonOrgJsonProvider.getArrayIndex(JsonOrgJsonProvider.java:75)
	at com.jayway.jsonpath.internal.path.EvaluationContextImpl.getValue(EvaluationContextImpl.java:145)
	at com.jayway.jsonpath.JsonPath.read(JsonPath.java:199)
	at com.jayway.jsonpath.internal.JsonContext.read(JsonContext.java:88)
	at com.jayway.jsonpath.internal.JsonContext.read(JsonContext.java:77)
	at Scratch.main(scratch_1.java:15)
Caused by: org.json.JSONException: JSONArray[0] not found.
	at org.json.JSONArray.get(JSONArray.java:209)
	at com.jayway.jsonpath.spi.json.JsonOrgJsonProvider.getArrayIndex(JsonOrgJsonProvider.java:73)
	... 5 more

My main concern with this is the "surprise factor" at the end of the day, we dealt with it, but after some head bashing.
Being blunt here, apologies in advance, "are breaking changes possible in any version release?"

@kallestenflo I just hit this issue as well when trying to upgrade from v2.6.0 to v2.7.0+ (v2.9.0, to be specific). Based on how JsonPath.handleMissingPathInContext() was implemented, it can cause a different type to be returned by JsonPath.put(), which then causes a ClassCastException in JsonContext.put(). Based on that, I don't see how I can restore the behavior I had in v2.6.0 no matter which Options I enable.


Address backlog of dependency updates

Due to a bug in npm/cli that was resolved in version 6.4.1, CI builds have been consistently erroring and several dependencies are now out of date. This PR composes all version bumps made by Renovate since this bug was introduced and will bring dependencies back to their current version.

:tada: This PR is included in version 1.5.3 :tada:
The release is available on:

GitHub release
npm package (@latest dist-tag)

Your semantic-release bot :package::rocket:


Method for checking if block is shown

This adds a new method isBlocking which tells whether a block is shown or not.

Merged -- Thanks!


Deep Speech model issue

Hi Team,
I am exploring deep speech model in the open model zoo, i have downloaded the model and converted the model to IR using model optimizer.
i am trying to use the demo file, but encountering the below error,
python3.7 deepspeech_openvino_0.5.py  -m /home/avijapur/openvino_models/model/deepspeechmodel/output_graph.xml -i male.wav  -a a.txt
[ INFO ] Creating Inference Engine
[ INFO ] Loading network files:
        /home/avijapur/openvino_models/model/deepspeechmodel/output_graph.xml
        /home/avijapur/openvino_models/model/deepspeechmodel/output_graph.bin
[ INFO ] Preparing input blobs
[ INFO ] Preparing output blobs
[ INFO ] Loading model to the plugin
Traceback (most recent call last):
  File "deepspeech_openvino_0.5.py", line 185, in <module>
    sys.exit(main() or 0)
  File "deepspeech_openvino_0.5.py", line 178, in main
    logits = np.concatenate((logits, res['Softmax']))
KeyError: 'Softmax'

Please check this issue.
Thanks
Akshay

@akshayvijapur could you please point me where you find DeepSpeech model in Open Model Zoo repository? I do not recall we accept and merge contribution for this model in OMZ, am I missed something?

Hi,
I got this from
https://github.com/opencv/open_model_zoo/pull/419
https://github.com/FengYen-Chang/open_model_zoo
Thanks
Akshay

@FengYen-Chang  Please take a look here.

Hi @akshayvijapur,
Please check PR #430, #419 is an old one. To convert the IR model, please refer the this yaml file, and using below command to acquire IR model on OpenVINO 2019R3.
python3 mo.py \
--input_model=$dl_dir/deepspeech-0.5.0-models/output_graph.pb \
--input=input_node,previous_state_h/read,previous_state_c/read \
--input_shape=[1,16,19,26],[1,2048],[1,2048] \
--output=Softmax,lstm_fused_cell/GatherNd,lstm_fused_cell/GatherNd_1 \
--freeze_placeholder_with_value=input_lengths->[16] \
--disable_nhwc_to_nchw

If you are using OpenVINO 2020.1, please using below command to acquire IR model.
python3 mo.py \
--input_model=$dl_dir/deepspeech-0.5.0-models/output_graph.pb \
--input=input_node,previous_state_h/read,previous_state_c/read \
--input_shape=[1,16,19,26],[1,2048],[1,2048] \
--output=Softmax,lstm_fused_cell/GatherNd,lstm_fused_cell/GatherNd_1 \
--freeze_placeholder_with_value="input_lengths->[16]" \
--disable_nhwc_to_nchw

After this, I think you could run the sample.
Thanks,
John

Hi John,
Thanks for the help, I am able to run the sample now. But it is not able to recognize some words from wav file. Do you recommend training the model to fix the issue.?
Thanks
akshay

Hi akshay,
It's good to know the sample is working 👍. Regarding model accuracy, there are many factors need to check to improve. Maybe deep speech forum can give you or find some suggestions.
Thanks,
John


bad ttl value returned

Returns a UNIX timestamp, rather than seconds, as the redis.io docs say it should:
http://redis.io/commands/ttl
var redis = require('redis'),
    client = redis.createClient();
client.on("error", function (err) { console.log("Error " + err.stack) });

client.set('hello', 'mjr');
client.expireat('hello', (new Date()).getTime() + 20e3, function(err, set) {
    client.ttl('hello', redis.print);
    // => UNIX timestamp, rather than seconds,
    // as noted on http://redis.io/commands/ttl
    // e.g.
    //      Reply:<PHONE_NUMBER>363817
    client.quit()
});

Note that I wrote this issue up while tired; so this may not actually be an issue and I may have just been super tired.
Cheers,
D


Simplify word increment code

As suggested by Daniel Baboiu @ Linkedin:

For example, lines 46-49 (if/else increasing count for word) can be written as
self.counters[word] = self.counters.get(word,0)+1

Just changed in the code.


Remove Hacktoberfest labels

Description
Now that Hacktoberfest is all done and dusted with, we can go ahead and remove the Hacktoberfest labels. We'll also have to run the necessary scripts with admin rights in order to remove labels attached with the existing Hacktoberfest issues.
I can go ahead and remove the Hacktoberfest associated labels from the labels.json file as suggested by @dhruvkb.
Expectation

Hacktoberfest associated labels should be removed.
Hacktoberfest labels that are attached with existing issues must also be removed.
We could potentially replace them with "help wanted" labels as well, but I'm really not sure about this.

Resolution

[x] I would be interested in resolving this issue.

@nimishbongale I think you should this issue as well as PR #98, based on this comment (and it's upvotes).

@nimishbongale I think you should this issue as well as PR #98, based on this comment (and it's upvotes).

Closing this issue!


Fix order of magnitudes

I noticed the order of magnitude of the initial position vector in validate_elements::validate_rv2coe was given in u.km but assumed to be in u.m during the whole workflow. Just a quick fix :sweat_smile:

Values from the validate_elements::validate_coe2rv were updated to match Example 4.3 from Curtis' book.

Values from the validate_elements::validate_coe2rv were updated to match Example 4.3 from Curtis' book.

In fact, this proofs that no matter the initial values, Orekit and poliastro will raise the same numerical output. So that is the idea behind validation :wink:
Merging this!

In fact, this proofs that no matter the initial values, Orekit and poliastro will raise the same numerical output. So that is the idea behind validation :wink:
Merging this!


set border color to captured screen (electron app.)

Hello,
Screen sharing is working fine in my electron app. i can see captured screen to another browser using "DesktopCapturerSource" but i want to set border color to the selected screen or window so i can see which screen currently i am sharing to others. we can see in skype or microsoft team or other application like red border to the selected screen while screen sharing something like that i want to make.
thanks.

Hello,
Screen sharing is working fine in my electron app. i can see captured screen to another browser using "DesktopCapturerSource" but i want to set border color to the selected screen or window so i can see which screen currently i am sharing to others. we can see in skype or microsoft team or other application like red border to the selected screen while screen sharing something like that i want to make.
thanks.


Binder badge images do not render in the gallery on Chrome

On https://cookbooks.projectpythia.org/ the Binder badges are not rendering correctly:

The Chrome developer console error:

Mixed Content: The page at 'https://cookbooks.projectpythia.org/' was loaded over HTTPS, but requested an insecure element 'http://binder.mypythia.org/badge_logo.svg'. This request was automatically upgraded to HTTPS, For more information see https://blog.chromium.org/2019/10/no-more-mixed-messages-about-https.html

Thanks for this report @tylere! This is a known issue with how Chrome treats http links. We are hoping to launch a new and improved Pythia binder shortly that will be served over https so this issue should go away.

Closing this as the same issue is described in #104


[flink] Introduce watermark alignment options

Purpose

Introduce watermark alignment options
Fix watermark generation

Tests
WatermarkITCase
API and Format
Introduce options.
Documentation
Documented.

Consistent with https://cwiki.apache.org/confluence/display/FLINK/FLIP-296%3A+Extend+watermark-related+features+for+SQL


RuntimeError: cannot perform reduction function max on tensor with no elements (Custom Dataset)

Hi,
I would like to ask about the error. I trained a custom dataset in kitti format. The training goes well, however when the eval result start processing, the error occured.
Note: I changed the class name in eval.py

Error:
x_max = torch.max(x, dim=1, keepdim=True)[0]
RuntimeError: cannot perform reduction function max on tensor with no elements because the operation does not have an identity.
Anyone knows what the error is about? and how to solve it?

Hi, I found the same error. Did you solve it?

Hi, I found the same error. Did you solve it?

have you solved it?


Create glossary.md

Mostly copied from https://docs.nano.org/glossary/

ah nice! There are definitely a few additions here that I think would be helpful.
What would be the advantage of maintaining a separate glossary from the one found on the docs? Why not link out to that one and make the additions there?
Generally speaking, I see a benefit for the community to focus their effort on maintaining one set of documentation. (Rule #3)

closing in favor of #14


[ROCm] fix gpu_conv_algorithm_picker on ROCm build

This new added PR https://github.com/tensorflow/tensorflow/commit/9b616058967513340d882623c489b25398849373 has broken ROCm build and it is for CUDA only, as ROCm implementation has not used redzone.
This PR fixes it.
@cheshire Thanks in advance!

close it as https://github.com/tensorflow/tensorflow/commit/e9bd1094b7d3c047ff6abbe503e124f253ea29ce has fixed it
Thanks! @cheshire


"unknown tool name found in scoped lint: rustdoc::all" on older Rust versions

Hi, while working on a feature for our open-source control system for quantum physics experiments - ARTIQ - I found this crate to be potentially very useful.
However, trying to integrate it, I did encounter a small issue:
error[E0710]: an unknown tool name found in scoped lint: `rustdoc::all`
  --> /home/spaqin/.cargo/registry/src/github.com-1ecc6299db9ec823/tar-no-std-0.1.8/src/lib.rs:77:9
   |
77 | #![deny(rustdoc::all)]
   |         ^^^^^^^

error: aborting due to previous error

For more information about this error, try `rustc --explain E0710`.
error: could not compile `tar-no-std`

First things first: the problem is that we're using a nightly Rust version from 2021-01-29, rather than stable 1.52+ that includes rustdoc. With complex projects updating the toolchain should be done with utmost care, as things may (and do) break unexpectedly. Fixing that takes a lot of time, so we're not willing to update unless really necessary.
On the other hand, just removing that one line, allows it to work without an issue: https://github.com/spaqin/tar-no-std/commit/2ab6dc58e5249c59c4eb03eaf3a119bcdd678d32
I realize that removing it from the main repository could potentially break your documentation tests, so my suggestion for a compromise would be to do it only for 0.1.x line for legacy support (making it actually compatible with 2018 edition as specified in your Cargo.toml for the older version), and keep your current main as-is.

Hi @Spaqin ,
thanks for the interest in my library. Sounds like a cool project you're working on!
TL;DR: Please fork this and reference it as git dependency. This might be the quickest solution for you.

With complex projects updating the toolchain should be done with utmost care, as things may (and do) break unexpectedly.

While I generally agree with you, especially for complex, C/C++ toolchains, I don't think that this statement holds for Rust toolchains. Especially because of Rust's stability without stagnation statement, the Rust editions etc.
IMHO, I recommend you to spend time on improving the infrastructure of your repository so that toolchain updates are an easy and quickly done with sufficient CI coverage.
Also the general Rust ecosystem tries to stay up-to-date with new Rust releases.
If its not my library, you will face the same problem with the next one.
Last but not least, having fresh software and fresh toolchains is one of my personal important properties in software development. So it feels a bit unnatural for me to do such a change to support such an old toolchain.
Sorry if I disappoint you. Please fork this repository and reference it as git dependency. This might be the quickest solution for you.


Alpha Tuning Llama Pack: KodaRetriever

Description
Llama Pack that implements alpha-tuning automatically using few-shot learning (while also allowing users to fine tune and or provide their own models). This was largely inspired from the llama-index blog post sourced below:
https://blog.llamaindex.ai/llamaindex-enhancing-retrieval-performance-with-alpha-tuning-in-hybrid-search-in-rag-135d0c9b8a00
Fixes # (issue)
Type of Change
Please delete options that are not relevant.

[X] New feature (non-breaking change which adds functionality)

How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

[X] Added new unit/integration tests
[X] Added new notebook (that tests end-to-end)
[X] I stared at the code and made sure it makes sense

Suggested Checklist:

[X] I have performed a self-review of my own code
[X] I have commented my code, particularly in hard-to-understand areas
[X] I have made corresponding changes to the documentation
[ ] I have added Google Colab support for the newly added notebooks.
[X] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[X] I ran make format; make lint to appease the lint gods

Currently fixing these build issues... apologies as this didn't show up in my local tests. Please hold!


Project Structure

@tranvnb Please check if the project structure is satisfactory. Are there any changes you would like?

create pull request for issue #3

create pull request for issue #3


Clean up the gemfile

Add version dependencies to satisfy Hakiri
Drop unnecessary / unused dependencies

ugh this broke what I've been trying to accomplish in #25 :/

I'm not sure I understand ... what did it break? I see that #25 is conflicted, but I don't see anything that should actually cause a problem.

@Fryguy the Travis PR was already unmergeable before I opened this yesterday.


Remove campaign name

@hoop71 Your commits look good to me. Thanks for that. I just realized that I just commented out the name attribute in the Campaign model to test it and make sure it didn't break anything but didn't actually delete that line afterwards. I just fixed that and made another commit.


Fill in the about page

Just ordinary markdown as in https://github.com/JuliaAI/MLJ/blob/main/src/data/AboutPage.md
CC @ablaom

Thanks for flagging. Getting busy with other matters. plan to get back to this mid-July

At your leisure of course.


Fix hotline link in May 12, 2021 blog (resolves #1796)

This PR resolves a bad link to the app hotline in May 12, 2021 blog (DE) from issue https://github.com/corona-warn-app/cwa-website/issues/1796.
It changes the hyperlink for the international app hotline number "+49 30 498 75401" in https://github.com/corona-warn-app/cwa-website/blob/master/blog/2021-05-12-cwa-2-2/index_de.md from non-working https://www.coronawarn.app/de/blog/2021-05-12-corona-warn-app-version-2-2/+493049875401 to tel:+493049875401 which will invoke a dialing response in an appropriate environment.
Steps to verify

Open http://localhost:8000/de/blog/2021-05-12-corona-warn-app-version-2-2/ in a webbrowser
Scroll down to the paragraph starting "Falls ihnen ein Fehler auffällt ..."
Click on the hyperlink +49 30 498 75401
Depending on the browser environment, you may see a pop-up like "Make a call from ..."

To verify in production open https://www.coronawarn.app/de/blog/2021-05-12-corona-warn-app-version-2-2/ with same steps as above.

@MikeMcC399 Thanks for the fix!


Template evaluation in AST

Template invocations in the AST are correctly transcluded.

Codecov Report

Merging #36 (c3cfbaf) into main (689db9b) will decrease coverage by 10.29%.
The diff coverage is 50.42%.

@@              Coverage Diff              @@
##               main      #36       +/-   ##
=============================================
- Coverage     91.79%   81.50%   -10.30%
+ Complexity      294      288        -6
=============================================
  Files            42       43        +1
  Lines           585      638       +53
  Branches         29       31        +2
=============================================
- Hits            537      520       -17
- Misses           36      106       +70
  Partials         12       12

Flag
Coverage Δ

unittest
81.50% <50.42%> (-10.30%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

...hang/wikitext_parser/ast/base/WikiTextElement.java
50.00% <ø> (ø)

...xt_parser/ast/link/WikiLinkNamespaceComponent.java
83.33% <ø> (+6.41%)
:arrow_up:

...zhang/wikitext_parser/ast/link/WikiLinkTarget.java
100.00% <ø> (+10.00%)
:arrow_up:

...skjaerozhang/wikitext_parser/ast/root/Article.java
100.00% <ø> (ø)

...ng/wikitext_parser/template/TemplateEvaluator.java
0.00% <0.00%> (ø)

...zhang/wikitext_parser/template/TemplateHolder.java
0.00% <0.00%> (ø)

...xt_parser/ast/template/TemplateWithParameters.java
35.00% <13.33%> (-65.00%)
:arrow_down:

...itext_parser/ast/base/TreeConstructionContext.java
33.33% <50.00%> (+33.33%)
:arrow_up:

..._parser/ast/template/TemplateWithNoParameters.java
77.77% <50.00%> (-22.23%)
:arrow_down:

...caskjaerozhang/wikitext_parser/WikiTextParser.java
83.33% <100.00%> (ø)

... and 26 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Unable to turn on addon

Unable to load addon script from path: 'res://addons/Qodot-2.1.0/addons/qodot/src/qodot_plugin.gd'. This might be due to a code error in that script.
Disabling the addon at 'res://addons/Qodot-2.1.0/addons/qodot/plugin.cfg' to prevent further errors.

Did you press "Build" in the top-right of the screen first, and do you have .NET SDK 7.0 installed? https://dotnet.microsoft.com/en-us/download

Ah hold on, you might need to move it out of the zip folder when you unpack it into your project. It should be res://addons/qodot/ not res://addons/Qodot-2.1.0/addons as there are some hardcoded resource paths in the code.
Also, it helps to download the latest master rather than the latest release. As of writing master is getting a release soon to get everyone up to speed.

If you have any additional troubles, don't hesitate to make a new issue or ask on the Discord.


Take a dependency on System.CommandLine for command line handling.

This resolves https://github.com/Microsoft/ClangSharp/issues/41 by taking a dependency on System.CommandLine in ClangSharpPInvokeBindingGenerator.
It should, overall, make the handling of command line parsing simpler and immediately provides a plethora of additional functionality.

Help text looks like:
ClangSharpPInvokeGenerator:
  ClangSharp P/Invoke Binding Generator

Usage:
  ClangSharpPInvokeGenerator [options]

Options:
  --a, --additional <arg>               An argument to pass to Clang when parsing the input files.
  --c, --config <config>                A configuration option that controls how the bindings are generated.
  --d, --define <macro>                 A macro for Clang to define when parsing the input files.
  --e, --excludeFunction <name>         A function to exclude from binding generation.
  --f, --file <file>                    A file to parse and generate bindings for.
  --i, --include <directory>            A directory for clang to use when resolving #include directives.
  --l, --libraryPath <dllName>          The string to use in the DllImport attribute used when generating bindings.
  --m, --methodClassName <className>    The name of the static class that will contain the generated method bindings.
  --n, --namespace <namespace>          The namespace in which to place the generated bindings.
  --o, --output <file>                  The output file to write the generated bindings to.
  --p, --prefixStrip <prefix>           The prefix to strip from the generated method bindings.
  --version                             Display version information


Not able to get the desired output while running the app.js on browser.

Not able to get the desired output while running the app.js on browser.
Please suggest, what is going wrong here.

You need to run app.js from the command line. And if you are running it within a VM, make sure the port (4000) is exposed to the host machine so you can query from the browser. You should use curl scripts from the command line instead of a browser as you will need to supply other options with the request.
See the latest branch: https://github.com/HyperledgerHandsOn/trade-finance-logistics/tree/release-1.4
Scripts can be found here: https://github.com/HyperledgerHandsOn/trade-finance-logistics/tree/release-1.4/application/client_scripts

Also, this is a fairly old project at this point and we are nor maintaining it any more. We have instead been working on a new and improved project that works for the latest version of Fabric (version 2). This should be released within a month or so; watch out for notifications on these pages.

Thank you so much for your reply. Thank you.
On Sun, Jul 5, 2020 at 4:51 PM VRamakrishna<EMAIL_ADDRESS>wrote:

Closed #77
https://github.com/HyperledgerHandsOn/trade-finance-logistics/issues/77.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/HyperledgerHandsOn/trade-finance-logistics/issues/77#event-3513242863,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AOV3C5BRBPAORCYDHE5QDHTR2BO5BANCNFSM4OQNYNBA
.


IMPOPRTANT!!! In the zip of release 1.12 is a config.production.json file

That's an critical error. Will mess up all self hosted instances of ghost!

Confirmed, it also contains sensitive information ☹
Need to re-release

We have releases 1.12.1. Thanks for reporting @larsauswsw 👋

Your welcome.


DTLS 1.3 support

BouncyCastle should support DTLS 1.3.
It's not imminently needed, but since (D)TLS 1.2 doesn't seem likely to get any post-quantum KEMs, DTLS 1.3 will be needed to protect DTLS traffic (and things derived from it, like WebRTC traffic) from harvest-now-decrypt-later attacks.

If I try to use DTLS 1.3 I get the follow exception:
org.bouncycastle.tls.TlsFatalAlert: internal_error(80)
	at org.bouncycastle.tls.DTLSClientProtocol.generateClientHello(DTLSClientProtocol.java:406)
	at org.bouncycastle.tls.DTLSClientProtocol.clientHandshake(DTLSClientProtocol.java:91)
	at org.bouncycastle.tls.DTLSClientProtocol.connect(DTLSClientProtocol.java:52)

Any progress on it?

Hello,
Do you have any update on supporting DTLS1.3?
Thanks.

Hello,
is there any update or timeline to be shared regarding this topic?
BR

I think until the value of SERVER_LATEST_SUPPORTED_DTLS is changed, there is no progress: https://github.com/bcgit/bc-java/blob/main/tls/src/main/java/org/bouncycastle/tls/ProtocolVersion.java#L25


[DaVinci] Added an interface for the customized transformation support of Object Cache

Summary, imperative, start upper case, don't end with a period
The initial interface for the customized object cache in DaVinci client.
How was this PR tested?
N/A
Does this PR introduce any user-facing changes?

[ ] No. You can skip the rest of this section.
[x] Yes. Make sure to explain your proposed changes and call out the behavior change.

When customer wants to use customized object cache, they will need to specify a transformation function per store.
With this interface, the user will need to use a separate store client to retrieve the cached value besides the original DaVinciClient since the returned object will be with different type from the original value.
The assumption is that when customized object cache is enabled, DaVinci won't need to cache the raw value any more.
We will need to make the storage engine configurable in the future since when object cache is enabled, they don't need to use plaintable format for most of the scenarios.

Maybe it is okay to drop this draft PR now, as for now even if we have discussed it, we know it is not going to be the option for Frame onboarding due to expensive transformation logic and no other use case so far in the near term.

I'm going to be the janitor to clean up inactive PR. Per @sixpluszero suggested, seems we don't need this for the time being.
Please re-open it when we are pick up this feature.


Cycle in chicken parents causes stack overflow

Issue Description:
(This might be a case of "well, don't do that, then", but I didn't see anything in the description or other issues about it, so I thought I'd report it just in case.  I'm going to just work around this in my own pack by adding some crafting recipes.)
The isEnabled() method in ChickenRegistryItem recursively calls isEnabled() on the current chicken's parents.  If any chicken type is its own ancestor, this leads to infinite recursion:
net.minecraftforge.fml.common.LoaderExceptionModCrash: Caught exception from Chickens (chickens)
Caused by: java.lang.StackOverflowError
	at com.setycz.chickens.registry.ChickensRegistryItem.isEnabled(ChickensRegistryItem.java:174)
	at com.setycz.chickens.registry.ChickensRegistryItem.isEnabled(ChickensRegistryItem.java:175)
	at com.setycz.chickens.registry.ChickensRegistryItem.isEnabled(ChickensRegistryItem.java:175)
	at com.setycz.chickens.registry.ChickensRegistryItem.isEnabled(ChickensRegistryItem.java:175)
[...]

Steps to reproduce (important):

Edit config/chickens/chickens.json as follows:
"chickens:snowballchicken": {
 /* ... */
  "parent_1": "chickens:whitechicken",
  "parent_2": "chickens:waterchicken"
},
"chickens:waterchicken": {
  /* ... */
  "parent_1": "chickens:bluechicken",
  "parent_2": "chickens:snowballchicken"
},

Launch Minecraft

What happens:
The game crashes during startup.
What you expected to happen:
The player could find either snowball or water chickens in the world, then breed the other.
Affected Versions:

Chickens: 6.1.0
Minecraft: 1.12.2
Forge: <IP_ADDRESS>53

humm. yeah I think your the first person to ever do that. I will look into some type of a fix for it.

hello i have this same problem xD but i modifity all ;) + use logic breed.
any can help to work it ?
chickens.zip

@halk6000
For me this happened when I tried to make the Soulstone and Quartz chickens breedable. Putting those two back to blank made it load.


Block Creeper Explosions with Shields.

This code should make the bot automatically block creeper explosions when a creeper is starting to explode.
It checks the metadata property to see if it's exploding or not.
https://wiki.vg/Entity_metadata#Creeper

This code should

Does it work ?

This code should

Does it work ?

It does


Increase the width of investigation view details page padding

Bug Description
An unnecessary scrollbar appears on a standard laptop screen on the investigation details page.
Steps to Reproduce:

[ ] Navigate to the "Patient" tab and select any card with an active consultation.
[ ] Click on the "Investigation" tab and select the "Log Update Result" button.
[ ] After creating a log, click on the "View" button on the card of the newly created log.
[ ] Observe the error: a scrollbar appears unnecessarily.

Expected Behavior
Adjust the width of the investigation details page for standard laptop screen sizes, ensuring that no horizontal scrolling is required.
Screenshots

@nihal467 isn't this expected for print preview?

We shouldn't be having scrollbars in the print preview.
But increasing the width would no longer maintain the A4 size print's width.

hi can you please assign me this issue

unassigning this issue because  i wont be able to work on it right now

@rithviknishad Can you assign this to me?


hxu is not recognized as valid triage engineer

On the DOM: LWS calendar next would be<EMAIL_ADDRESS>but the bot does not want this:
The following calendar needs to be updated in order to have a triage owner:
DOM:LWS: cannot find the following person:
    hxu

For jjalkanen (other new entry) this worked, so not sure what I am missing.

I think this means hxu couldn't be found in people.mozilla.org (https://github.com/mozilla/relman-auto-nag/blob/ab5d64ae4f96607d98ec355c3cd7a83f69c8f371/auto_nag/people.py#L406)
@calixteman any idea why?

Maybe because a search for hxu gives 4 results there? Can/should I just use "Haiyang Xu" as name in the calendar?

Trying this ^ now.

The "guess" is based on what we have in phonebook.
We try to be smart:
https://github.com/mozilla/relman-auto-nag/blob/ab5d64ae4f96607d98ec355c3cd7a83f69c8f371/auto_nag/people.py#L116
and I'd say that it likely fails to find something because hxu is very short.
So ideally, having the the same name as in phonebook should work fine.


Why is S3 file system being used?

/arrow/cpp/src/arrow/filesystem/s3fs.cc:2598:  arrow::fs::FinalizeS3 was not called even though S3 was initialized.  This could lead to a segmentation fault at exit
Segmentation fault (core dumped)
Is it possible to switch it off or suppress its use?
Or alternatively to fix this issue?

have you solve it ?  I have the same problem.

Just comment out:
https://github.com/TimDettmers/bitsandbytes/blob/1b8772a8f33fdb47df0c849302cbb7e703571b8c/bitsandbytes/functional.py#L187

I also got the same error.

The error also goes away for me if I use  adamw_8bit instead of paged_adamw_8bit  as the optimizer

A simple solution to fix this error:
pip install --upgrade --force-reinstall pyarrow==11.0.0

The error also goes away for me if I use adamw_8bit instead of paged_adamw_8bit as the optimizer

It has solved the issue (Error operation not supported at line 380 in file /mmfs1/gscratch/zlab/timdettmers/git/bitsandbytes/csrc/pythonInterface.c) I had when adding target_modules=["query_key_value",
"dense",
"dense_h_to_4h",
"dense_4h_to_h",
],

Downgrading to pyarrow 11 worked for me and allows me to use paged_adamw_32bit. The issue happens whenever I resume training. I don't see a downside to the downgrade however it may make sense to add something like pyarrow<12 to requirements.


fix(release): updating release

Goal
Need to remove npm run get from our release workflow now.

#268 is a better fix.


[Mobile]Push notifications with action buttons in flutter

Topic Suggestion
Push notifications with action buttons in flutter
Writing sample(s):

https://www.section.io/engineering-education/google-drive-api-nodejs/
https://www.section.io/engineering-education/deploy-flutter-to-google-computer-engine/

Proposal Submission
Proposed title of article
Push notifications with action buttons in flutter
Use keyword research to improve your article's SEO.
Proposed article introduction
A push notification is a message that pops on the screen when a mobile or a web application is performing another activity. In modern android applications, action buttons are integrated into push notifications are used to give the user a quick action to perform on the notification instead of opening the application.
Action buttons in push notifications have been used by most major known applications for instance:

Google messages where a user can access pre-set responses to messages.
Any.do task manager allows a user to add a task from the push notification
Google calendar allows one to accept or decline a meeting invite.

Having looked at these examples, this article will walk the reader through implementing action buttons in a push notification using flutter. In the end, the user will have built a complete mobile application using flutter with an ability to send push notifications and working action buttons.
Key takeaways

What are action buttons in push notifications and how do they work.
Creating custom action buttons using flutter
Building a flutter application that accesses action buttons in a push notification.
Working with flutter packages

Article quality
This article is one of a kind because besides a working implementation using flutter, most articles online do do not include action buttons in their implementation and even if they do, they have done it other tech stack and not flutter, so with this article, the reader will have a different dynamic on doing push  notification.
References
Please list links to any published content/research that you intend to use to support/guide this article.
Templates to use as guides

How To Guide Template
Software Review Template
Tutorial Template

Closing due to inactivity


Update Sharethrough endpoint

Story: #166961230
Dependency: sharethrough/sfp-ad-server#18

Please add reference to the related story in the description.
Please add tasks to the story so that faux and dumb-waiter respond to both the header-bid endpoint and the new one. Inspector AdGet has a dependency, with force prebid, for there to be the corresponding endpoint on dumb-waiter.

Tasks added to Pivotal story.

Changes are good but there is a change that needs to go on SFP ad server first

@maphe just wanted to confirm that this PR can be unblocked now. The relevant PR for SFP Ad Server was merged yesterday: https://github.com/sharethrough/sfp-ad-server/pull/18.

Changes are good but there is a change that needs to go on SFP ad server first

@maphe just wanted to confirm that this PR can be unblocked now. The relevant PR for SFP Ad Server was merged yesterday: sharethrough/sfp-ad-server#18.

Just noting for the record that the blocker by SFP Ad Server update has been cleared. Confirmed with @maphe.


fix(decodeOpReturn): Trying different error configuration

:tada: This PR is included in version 4.15.15 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Earlier release

Hi,
README describes

This is a self-updating and self-publishing repository that looks for updates once a week.

However, I see that releases are once a month since https://github.com/tfranzel/drf-spectacular-sidecar/commit/376c697ddb1a839c75dd4ebf8d23a98d7d70b001.
Is it possible to revert it (for every week) or is it possible to generate a new release on request?
Context:
I noticed that the latest version (2024.3.1) of drf-spectacular-sidecar contains swagger-ui-dist in version 5.11.8. We already know that this version introduced the bug that is breaking our deployment. The bug was already fixed and will be released next week (https://github.com/swagger-api/swagger-ui/issues/9645#issuecomment-1973141060).
It means that we would have to wait a whole month for the new version of drf-spectacular-sidecar.

Hi,
yes I forgot to update the README. I chose once a month because weekly did rack up too much github storage for me.
I do not intend to change the cycle currently. All things considered, having to use a 4 weeks old SwaggerUI shouldn't be that much of a problem imho. drf-yasg currently ships with SwaggerUI 4.1.3 (2021-12-10) 😄
However, since this is hitting a lot of people we can do a one-off release.

Hi @tfranzel,
I hope that all user of drf-yasg are already migrating their setup 😄 2021-12-10 sounds bit old.
The fixed version of swagger-ui-dist in version 5.11.9 was already released (https://github.com/swagger-api/swagger-ui/issues/9645#issuecomment-1976043844) and works well (in our environment).
Can you please release a new version of drf-spectacular-sidecar with mentioned version, please?

I hope that all user of drf-yasg are already migrating their setup 😄 2021-12-10 sounds bit old.

doubtful 😄
new version is released. 🚀


Fix bug in rational cooperative equality

unifiedPrimitiveEquals is only supposed to be called for types that "are
happy to be converted to a Long", so we need to sort out non-long rationals
before.
Fixes #406

These test failures seem unrelated to the bug fix. I'll investigate and merge this if possible.

I think this fix is not right actually. See #408 for my proposed solution.

(The reason is that unifiedPrimitiveEquals also supports types like Double.)

You are right. I forgot about doubles.


Spiral\Scheduler\Job\Job::filtersPass(): Argument #1 ($container) must be of type Spiral\Core\Container

When trying to run schedule:run command, TypeError occurs:
TypeError: Spiral\Scheduler\Job\Job::filtersPass(): Argument #1 ($container) must be of type Spiral\Core\Container, Psr\Container\ContainerInterface SCOPED PROXY given, called in /app/vendor/spiral-packages/scheduler/src/Commands/ScheduleRunCommand.php on line 28 in /app/vendor/spiral-packages/scheduler/src/Job/Job.php at line 292

Would it be logical to change Spiral\Scheduler\Job file and use Psr\Container\ContainerInterface instead of Spiral\Core\Container?

I think Yes

I have the same problem
When will the pull request be merged? My scheduler just doesn't work because of this. Or are there any workarounds to fix this right now?


ArcHeap checking (issue #161 follow-up)

Since the ArcHeap team released their tool, I ran it over mimalloc for a
day and it reported some issues.  The three things I note are:

The only two categories of problem it finds are overlapping-chunk (OC)
and restricted-write (RW).  So far none of the RW crashes it has found
have reproduced outside of what AFL reported, so perhaps those are
invalid tests, or only reproduce with the right initial randomness state.
The ArcHeap paper doesn't appear to make a hard claim of no
false-positives - just that they didn't see any.  @jakkdu FYI in case this is
of interest.

One of the OC files it created seemingly enters an infinite loop and
allocates ~7TB of virtual memory.  I couldn't attach the debugger to
it and it only happens every few runs.

Another OC file hits its assert() every run.  I presume that means
it's a reliable overlap?

This is with MI_SECURE=4 and mimalloc v1.6.4.
The POC .c files are available.

Hi. Thank you for running ArcHeap.
Could you share your poc files?
I would like to check them.
Best,
Insu Yun

Awesome. I would like to harden mimalloc as well as possible (within reasonable efficiency).
Already due to the ArcHeap tool mimalloc checks reliably for double frees, and also detects heap block overflows and free-list corruption.
However, at some point double-free checking is in tension with reasonable efficiency -- so I think that in the extreme one needs to test with, say, address sanitizer, but run in production with mimalloc-secure.
The difficult situation as: 1) an object is allocated at address A and freed; 2) lots of other objects are freed until an entire raw OS block is free; 3) the OS block is reused for new pages or large objects; 4) and only now the object is freed again.
Since at 4) the raw OS memory was reused in a completely new way, the meta-data may not correspond at all anymore to the initial situation and thus this can lead to all kinds of errors. (mimalloc in secure mode should still not corrupt entries though but it may free an object if it happens to be at address A for example).
Now, this is a fundamentally tricky situation: the allocator either (A) reuses raw OS memory when it can or (B) it keeps allocating fresh (virtual) OS memory and never reuses previous memory if the metadata would change. (B) is much more expensive though, and of course, the whole point of an allocator is to "reuse" OS memory efficiently so I see it as unresolvable in general.
(I believe this is also the argument made by Emery Berger here (issue 12)
Anyways, if there are an POC files I would love to try and see if it exposes a realistic bug or not.
Also, see also the main-override-static.c test file which has two tests double_free1 and double_free2 that come from ArcHeap.

Yea, I've got no interest in being pedantic on this.  I figured that since what I found was a bit different from what was described in the original ticket that it was worth mentioning.  And if nothing else, the odd side effect of the memory growth would be worth understanding in case it happens due to a bug in an actual application.
I emailed the OC POC files, but need to see if I can recreate the RW ones since they were lost in a power outage.

Thanks Jason. Yep, it is weird to see memory growth so not sure if that is actually metadata corruption (which I would consider a bug for sure!). Thanks for following up.

@jasongibson, could you share the PoC with me, too?
@daanx I couldn't fully understand the situation that you explained earlier. But, in DieHarder's case, the problem was not just reusing, but incorrect reuse. In ArcHeap, we don't consider a trivial reuse as buggy, which returns same address.
For example,
void* a = malloc(0x100);
free(a);
void* b = malloc(0x100);
assert(a == b); // reused
free(a); // double free?
void* c = malloc(0x100);
// overlapping since c== a, but we don't consider it as buggy

In this case, a is a dangling pointer in application's view but not for the allocator, since an allocator does not know the applications status.  In DieHard issue (https://github.com/emeryberger/DieHard/issues/12#issuecomment-580298180), we believe that it is a bug because it returns some memory, which does not alias to any others in double free, i.e., different from reusing.


[android] Add a test for Android conditional compilation (AArch64)

There are similar tests for other architectures/OS pairs, but
android-aarch64 was missing. This should ensure that the conditional
compilation for Android works correctly in this case.

@swift-ci please smoke test

@swift-ci please smoke test linux platform

Removed the flags, since they were removed in #24571 from the other targets.
@swift-ci  please smoke test and merge

@swift-ci please smoke test

Wow - honestly, I think it was just me testing the build configs feature.


/usr/bin/docker failed with exit code 1 - permissions of build service user set

/usr/bin/docker run --rm -i -e DEPENDABOT_PACKAGE_MANAGER=docker -e DEPENDABOT_FAIL_ON_EXCEPTION=true -e DEPENDABOT_EXCLUDE_REQUIREMENTS_TO_UNLOCK= -e AZURE_PROTOCOL=https -e AZURE_HOSTNAME=dev.azure.com -e AZURE_ORGANIZATION=PJ-ORG-e AZURE_PROJECT=project1 -e AZURE_REPOSITORY=app-ddk -e AZURE_ACCESS_TOKEN=*** -e AZURE_SET_AUTO_COMPLETE=false -e AZURE_MERGE_STRATEGY=2 -e DEPENDABOT_DIRECTORY=/docker -e DEPENDABOT_VERSIONING_STRATEGY=auto -e DEPENDABOT_OPEN_PULL_REQUESTS_LIMIT=10 -e AZURE_AUTO_APPROVE_PR=false tingle/dependabot-azure-devops:0.7
warning: parser/current is loading parser/ruby27, which recognizes2.7.6-compliant syntax, but you are running 2.7.5.
Please see https://github.com/whitequark/parser#compatibility-with-ruby-mri.
/home/dependabot/dependabot-script/vendor/ruby/2.7.0/gems/dependabot-docker-0.196.0/lib/dependabot/docker/file_fetcher.rb:26:in `fetch_files': Dependabot::DependencyFileNotFound (Dependabot::DependencyFileNotFound)
	from /home/dependabot/dependabot-script/vendor/ruby/2.7.0/gems/dependabot-common-0.196.0/lib/dependabot/file_fetchers/base.rb:65:in `files'
	from ./update-script.rb:259:in `<main>'
Using hostname = 'dev.azure.com', protocol = 'https', port = '443'.
Using '[https://dev.azure.com:443/'](https://dev.azure.com/') as API endpoint
Fetching docker dependency files for PJ-ORG/project1/_git/app-ddk-
Targeting 'default' branch under '/docker' directory
Using 'auto' requirements update strategy
##[debug]Exit code 1 received from tool '/usr/bin/docker'
##[debug]STDIO streams have closed for tool '/usr/bin/docker'
##[debug]task result: Failed
##[error]The process '/usr/bin/docker' failed with exit code 1

Project's build service user permissions are set like this:

By searching for similar issues I found that the permissions have to be set for the build service user, but this looks to be in order.

@piejanssens  how did you resolve this issue


The tracker not working

We can play without it but I really like what you made here, it's too bad it doesn't work now.

it can use now

Thank you!!!

You are the best developer. Thank you for your kindness and sincerity.


Dinghy broken after update to MacOS Big sure

Was parallels desktop related :
https://forum.parallels.com/threads/big-sur-and-parallels-network-initialization-failed.351463


sgpt -se failed with "sh: 1: Command:: not found"

For example:

I guess the root cause is chat gpt outputs extra Command:  prefix.

ChatGPT is not always obedient!
https://github.com/TheR1D/shell_gpt/blob/caa4fbfb8e8d9bc50ef337510f33eb6eb94238eb/sgpt/make_prompt.py#L25-L35
You may retry with --no-cache

ChatGPT is not always obedient! It was asked not to do this:
https://github.com/TheR1D/shell_gpt/blob/caa4fbfb8e8d9bc50ef337510f33eb6eb94238eb/sgpt/make_prompt.py#L25-L35
You may retry with --no-cache

Thank you


Title and subtitle overflow fix

I've noticed an issue with horizontal overflow when using isDefaultVerticalPadding = false:

This PR fixes overflow issue by wrapping title and subtitle column in Expanded:

Hi @benja8151 , thanks for contributing, let me consider it and feedback you soon!

Thanks for contributing, i has updated package in ver 1.2.6.


Existence of config folder, breaks package installation

I was trying to install the Ionide suite of packages and ran into a problem as documented in this bug I filed against ionide. At the end of that issue a reference to another bug pointed to the problem happening when Atom has the config folder, created when opening settings, showing in the left pane.

Can you describe what the actual problem is with repro steps? I did my best to take a quick look through the two bugs you linked, but I'm not understanding what is going wrong.

If you go to edit settings, this creates a config project folder. As detailed in the second bug I linked, if this folder exists when you install some packages, you will get errors on certain file access, where some file or other can't be found. In my case, detailed in the first bug I linked, I was trying to install ionide, which has the first step of installing ionide-installer and then the associated packages. You will find in that bug that many people end up with errors. The solution is to install the package with the config folder removed. I did it by removing the folder, going to the command line to install with apm install ionide-installer, starting up Atom and letting it finish the installation without error.
With the folder present I could never install ionide without an error.

If you go to edit settings, this creates a config project folder.

Where does it create this project folder? I don't get this behavior, so I can't replicate the error.

It's created in the left panel by opening up the settings where manually created project folders would be created. Well, it was in previous versions of Atom - can't confirm that this still happens because Atom has been updated since then.

Oh, if you already have a project folder in the left panel, the config folder will not be created. The panel has to be empty.

If I'm understanding this correctly, I think I can replicate this - I posted some repro steps in the Electron PR but forgot to create a dedicated issue for it.

Opening Settings or any other file that uses a URI will cause a fake folder to appear in the Tree View (eg config, init-script) and Settings - atom://config or similar to show up in the titlebar. Reproduce by using a new window.

Yeah, that's the cause of the problem.

This has been fixed in https://github.com/atom/atom/pull/12694 and will be available in Atom 1.12.


feat(toggle): added toggle component with tests

Storybook Hub is building storybooks for every commit in this PR.
Latest Storybook: https://03cdd6fe-9293-489d-9e16-a296b93c8d2b.sbook.io/
( Visit here for more info )

This comment is automatically added by Storybook Hub

Current coverage is 100% (diff: 100%)

No coverage report found for master at cbaf3f7.

Powered by Codecov. Last update cbaf3f7...6250588


chore: add CMakePresets.json file

What type of PR is this?
/kind feature
Any specific area of the project related to this PR?
/area build
Does this PR require a change in the driver versions?
No
What this PR does / why we need it:
These days I'm building scap drivers tests over several machines and every time I need to type an infinite cmake to configure them (getting it wrong every time). If you are like me this CMakePresets.json file should help you. Configure drivers test should be as simple as:
cmake --presets scap-drivers

Then to build different targets you should enter the directory created for you by the preset and run the make command`
cd build-scap-drivers
make drivers_test
make scap-open
make libscap_test
...

Here I provide just 2 presets that I often use while developing, i hope this could be useful to other folks who build libs every day
Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
NONE

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: Andreagit97
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [Andreagit97]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

I upstreamed these 2 presets because I think they could be widely used, if not, I will keep them locally inside my CMakeUserPresets.json with no issues!

Now I don't have enough bandwidth but at a certain point we could also use these presets in our CI to avoid duplicates of CMake commands
Moreover, there are also build presets that a certain point we could add

I believe this is useful. Could other presets be useful? Or merge those first?

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: Andreagit97, incertum
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [Andreagit97,incertum]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

LGTM label has been added.  Git tree hash: f3cde5cb90b88663b71cb2286a7f04603aff25c0

I believe this is useful. Could other presets be useful? Or merge those first?

I've no other presets to add ATM :/ I think we can add them incrementally if we find something that could be useful

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: Andreagit97, FedeDP, incertum
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [Andreagit97,FedeDP,incertum]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


[GUI] Apply wording changes to installer templates

This is to resolve #1418.

I still need to:

[ ] Update SVGs

Here the sentence is not exactly the one requested:

Change the first sentence to: "For this setup you will need 2 keys: a Primary Key (for yourself) and an Inheritance Key (for your heir). For security reasons, we suggest you use a separate Hardware Wallet for each key."

setup vs Inheritance wallet, but maybe this is wanted/better?

Here the sentence is not exactly the one requested:

Change the first sentence to: "For this setup you will need 2 keys: a Primary Key (for yourself) and an Inheritance Key (for your heir). For security reasons, we suggest you use a separate Hardware Wallet for each key."

setup vs Inheritance wallet, but maybe this is wanted/better?

I would use "setup" for consistency with the other introduction pages.

nit: titles vs texts are not aligned, and it looks to me the title are too close from the radiuses

nit2: i'd keep Add another key & Add another recovery option as i dont think we use + elsewhere

will be always able vs will always be able

Oh yes, well spotted :) I changed this to the latter as I think it's more common this way and that's how I kept trying to read it.

nit: titles vs texts are not aligned, and it looks to me the title are too close from the radiuses

I haven't made any changes for this. Shall we move it to a new issue?

I still need to:
* [x]  Update SVGs

SVGs have been updated.

I would use "setup" for consistency with the other introduction pages.

Done.

Looking at it, I would probably drop the "another", especially when adding a key. It was useful to see how it looks, but I don't think it adds much value compared to the disadvantage of having a word more.

I dropped the commit that changed the wording of the "Add key" and "Add recovery option" buttons.

nit: titles vs texts are not aligned, and it looks to me the title are too close from the radiuses

I haven't made any changes for this. Shall we move it to a new issue?

Yes we can manage it as a different UI improvement.

updated screenshot @ f4b4afbb6cfba6f847b4c6e0d864fd2ffbca9a40:

tACK f4b4afbb6cfba6f847b4c6e0d864fd2ffbca9a40

Rebased on master.


mps-model-adapters: fixed incompatibility with MPS 2021.2

It's actually just an issue of the Kotlin compiler and the bytecode would have been compatible.
It's still good to have the workflow that detects possible incompatibilities.

:tada: This PR is included in version 2.15.3 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Fix error if kubectl path contains spaces

If the path to kubectl contained spaces, we were throwing an error because we did not quote the path before composing the command string and passing it to the shell.
Fixes #637.

I am getting exactly the same error with the path which contains an opening and closing bracket..
@itowlson

Dear concern,
I will be grateful if you can take initiative for fixing my issues.
Kind Regards

We appreciate your efforts


updated install link and instructions for R-Pi

Removed old demo which is no longer needed

Restarted AppVeyor build.

Closing & reopening to bump status checks on CLA (this is a test, thanks for your patience)

FYI @SteveL-MSFT the CLA part is validated now


Windows: Rename layers before deletion

fixes https://github.com/docker/docker/issues/27570
- What I did
Layers are less likely to enter a partially removed state.
- How I did it
By renaming the layers to *-removing before removal starts, the rename will fail if the layer is in use, preventing the partial deletion by DestroyLayer.
- How to verify it
Manual testing that when a container is leaked, the layer is not partially removed, but instead the rename fails.
Signed-off-by: Darren Stahl<EMAIL_ADDRESS>

That seems sane assuming you can't rename an in-use file. Is there any documentation that says so? I am curious more than anything.
Code looks good.

@MHBauer It depends on the flags passed to OpenFile/CreateFile. On Windows, you must request the ability for shared deletion with the FILE_SHARED_DELETE flag at creation, otherwise it cannot be renamed or deleted by other processes. Containers intentionally do not use the FILE_SHARED_DELETE flag, as a result, a rename will fail if the container is in use. There's still the chance for something to grab a file between the rename and the delete, but the layerstore should no longer see the leaked files since they have the -removing in the layer name.
See https://msdn.microsoft.com/en-us/library/windows/desktop/aa363858(v=vs.85).aspx
Thinking about it more, the DestroyLayer errors should be ignored since the folder is already renamed, and we can't do anything about it at that point. It should also be removed from the layer store if the DestroyLayer fails. I've updated the PR slightly.

/cc @jstarks

LGTM

/cc @johnstep

LGTM. Merging.


Enhancement no more global conf

CONF is moved to module specific namespace
get_conf() introduced for the rare occasions it's necessary to access the module's configuration from outside of it
added unit tests for all get_conf()
cleaned up util.log so that it passes PEP8 (dumb but required!)

Closes #31

Looks good :+1:


Canonical way to clear file caches

Maybe I missed it in the docs, but is there a way to clear all cached files?
I have a use-case where download videos from the cloud, split them to frames, and upload them back.
There are many videos, and I don't need them once I've split them to frames. Currently I run out of HD memory because there's no way to tell cloudpathlib I don't need those files cached anymore.
I've resorted to shutil.rmtree(tempfile.gettempdir(), ignore_errors=True), but this interferes with other running scripts that use tempfile and also breaks many tests that rely on tempfiles.
Is there a better way?

Yeah, this should exist and I think should be part of #10
As noted there, the cache temp dir can be cleaned up by deleting the client so it gets garbage collected, which cleans up its cache dir if it is a temporary directory:
https://github.com/drivendataorg/cloudpathlib/blob/ce411fe22b138a183b1b17b815c3141a42e481b1/cloudpathlib/client.py#L44-L47
You could also do something like manually in the meantime S3Client.get_default_client()._cache_tmp_dir.cleanup(); or, if you set the cache dir yourself, shutil.rmtree(S3Client.get_default_client(). _local_cache_dir).

Going to close this for now in favor of #10

@Gilthans Updates here were just released! See documentation here: https://cloudpathlib.drivendata.org/stable/caching/#clearing-the-file-cache


Update psf script. Using job_psf.jl as the job submission script.

Upload script for PSF analysis in example.
Using job_psf.jl to call the script.
beadtest.jl work using gaussian fitting function.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

:exclamation: No coverage uploaded for pull request base (master@1249337). Click here to learn what that means.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff            @@
##             master      #37   +/-   ##
=========================================
  Coverage          ?   21.73%
=========================================
  Files             ?       15
  Lines             ?      391
  Branches          ?        0
=========================================
  Hits              ?       85
  Misses            ?      306
  Partials          ?        0

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Ignore the file type requirements when determining whether a directory is traversed when noTraverseFailed is true

Work for this issue will begin begin on branch work-liquid-labs/find-plus/26.


[Feature]: app dev should update URLs and respect paths

What area(s) will this request affect?
App, Running your code locally
What type of change do you want to see?
New feature
Overview
When shopify app dev runs, it creates a tunnel via Cloudfare and updates the app URLs in Partners Dashboard.
The URLs have the following format:
application_url = "https://trash-shopping-health-inspection.trycloudflare.com"

[auth]
redirect_urls = [
  "https://trash-shopping-health-inspection.trycloudflare.com/auth/callback",
  "https://trash-shopping-health-inspection.trycloudflare.com/auth/shopify/callback",
  "https://trash-shopping-health-inspection.trycloudflare.com/api/auth/callback"
]

where the subdomain trash-shopping-health-inspection is a random string that changes on every app dev.
I would like to suggest to make it possible to configure the paths of each URL. For example, instead of /auth/callback  it should be possible to use /app/auth/callback or any other paths. Right now it's always / for the application_url and /auth/callback, /auth/shopify/callback and /api/auth/callback for redirect_urls.
It would be nice if there were two CLI options like --app-url-path=/apps or --redirect-url-path=/app/auth/callback to override the default values.
Another option would be, if the CLI updates only the hostname trash-shopping-health-inspection.trycloudflare.com of each URL and doesn't update the paths.
Motivation
I have to work with multiple apps (custom and public apps) on the same backend. In order to re-use the same infrastructure, I have to distinguish the different apps by their ID. I do that by simply adding /apps/<app-id> as prefix to all app URLs.

https://trash-shopping-health-inspection.trycloudflare.com/apps/123/
https://trash-shopping-health-inspection.trycloudflare.com/apps/456/

These two URLs would go through the same Remix backend and the right config is loaded depending on the <app-id>.
The static URL paths from the CLI make it very hard to make app dev work.

Hi! Thanks for the suggestion, I think it makes sense. @nickwesselman what do you think?

@nickwesselman sorry to ping you. Do you think this feature would be possible?

Hi @zirkelc -- Sorry for the delayed reply. I dug into the logic here a bit and confirmed that this is actually already possible in the shopify.web.toml with the auth_callback_path option. For example, if I add the last line here to my shopify.web.toml:
name = "remix"
roles = ["frontend", "backend"]
webhooks_path = "/webhooks"
auth_callback_path = ["/hello/world","/foo/bar"]

Then when I run shopify app dev the URLs are updated to:
[auth]
redirect_urls = [
  "https://social-consortium-monroe-cleaner.trycloudflare.com/hello/world",
  "https://social-consortium-monroe-cleaner.trycloudflare.com/foo/bar"
]

Does this solve your need?

Yes, but I would like the same behavior for application_url.  See this comment https://github.com/Shopify/cli/issues/4219#issuecomment-2232766745
name = "remix"
roles = ["frontend", "backend"]
webhooks_path = "/webhooks"
auth_callback_path = ["/hello/world","/foo/bar"]

# New
app_path = "/foo"

Then shopify app dev should update the application URL:
application_url = "https://trash-shopping-health-inspection.trycloudflare.com/foo"

Hi @zirkelc -- We are open to the feature but before accepting a PR for this, the team raised a couple additional questions we'd need to answer --

Apps can have multiple web.toml, how would we resolve which to use? This isn't an issue for auth_callback_path since they can just be concatenated.
Does this affect the UI extension preview server at all? This probably requires testing -- does appending to the app path affect the expected URL for the HMR websocket connection?

Thinking about this more, probably not -- you could use a path in your App URL without this configuration. But it would be good to confirm.

not stale


Updated some glossary terms

Removed unnecessary quotes in the app shell definition
Made descriptions consistently repeat the term being defined in the first sentence of the definition
Fixed grammar in the service worker definition
Removed init caps from some terms (e.g., changed "Add to Home Screen" to "add to home screen")

@jpmedley - can you confirm the capitalization on these?


Removing JCR leakage

Wrapping RepositoryException in RepositoryRuntimeException
Using FedoraResource.replaceProperties instead of direct node updates
Addresses https://jira.duraspace.org/browse/FCREPO-1489

I assume this PR is dependent on: https://github.com/fcrepo4/fcrepo4/pull/781

Yes, this PR depends on fcrep4/fcrepo4#781

I put this in the JIRA ticket, but thought it would be good to have here to: This PR depends on https://github.com/fcrepo4/fcrepo4/pull/781 (adding FedoraResource.setURIProperty method) and https://github.com/fcrepo4/fcrepo4/pull/782 (updating DefaultIdentifierTranslator)

Resolved with: https://github.com/fcrepo4-labs/fcrepo-audit/commit/ace483a79fdc7c119ff90dfec6e8eab1814db07b


Porting of Alchemist

This is really a started port. It is fully functional, but will need changes when ClientFactory becomes BotoPool.
We also need to possibly move the aws_quickstart_s3_key_prefix_builder function out to a common utils, as well as a perfected version of aws_api_init (also after BotoPool).

Can we please get a final review before we merge?

my only outstanding concern is that the cli script alchemist.py is not setup to be properly deployed to the user's executable path by setup.py/pip. To do this I'd recommend:

move  it to the scripts/ folder
drop the .py exension
add it to setup.py in the scripts section

@jaymccon See my comments. I will take care of it. setup.py in the repo is not used to build the pip module. I will make sure that the pipeline version and the repo version are synced in develop.

@jaymccon @avattathil @sshvans  we need to convene to discuss best way going forward. I see both points of views with pros/cons.


Logo

Every cool project needs a cool logo. I took a look at the character Harvey's outfit and came up with some ideas for an abstract representation. This is the same process @orta went through to design Moya's original logo. Here's what I've got, very open to suggestions.

or

or

The blue is the same blue hue as Moya's logo, but I'm totally open to any colour scheme.

@ashfurrow I like these in blue (2 & 3)! How would it look smaller in width? Also, do you think we could add a name somewhere in the logo or is it too much? 🤔

I generally don't like names in logos, like a name as a logo like Danger's:

But a name within a logo might work too. I'll try and brainstorm.

You could probably play with a "H" - then try re-use the soya color scheme to hint at a connection

lols, try make a H from the Moya shapes :P

You could make an H from inverting the middle of one Moya logo on top of another.

I vectorized and played around with @SD10 's idea above, what do we think of this?

Happy to accept feedback. The Sketch file is here:
Harvey.sketch.zip

My only problem with my own suggestion is I didn't use all 3 of Moya's colors 🤔

Maybe add a blue line each on the left and right of the main column? I'll play with it and update 👍

Placing the H in the negative space is an interesting idea. This is colorful too, never noticed Moya had such a nice color pallet.
Logo's should connect with the meaning of what they stand for in some way. Harvey is a network stubbing library?
An idea building on this last one: Take an "H" in a sans-serif font, a font suitable to write the name Harvey in. Arrange the Colors/Shapes around that, or arrange the colors shapes then place the the "H" over it to mask. Then put the word "Harvey" to the right with the same capital H. (How logo & name look together is a consideration anyway). The logo would still work independently, the H just needs a little more definition anyway. The idea is, Harvey fills in the gap.

Using @ashfurrow as a launching off point I went through some iterations and came up with this:

Sketch file is
Harvey_logo_2.sketch.zip
, Sorry for the atrocious techniques used I'm sure, I cobbled this out (also why imprecise alignment--no need to do perfect until final decisions made). The logo iterations are grouped. Also, this sketch file has "Document Colors" from the Moya logo, really convenient, though that only took a few minutes.
The evolution:

On the final evolution, shape exact positioning needs adjustment, which should be after selection of font (Any comments on that?). Looks composed of horizontal and vertical lines, but by connecting points will be able to see shapes of diamonds. For example, the top and bottom blue corner.
The two matching shapes on the side enclose the inner area, suggesting containment. Being very symmetrical helps this. But they are hands off.
The middle part then forms the bulk of it, formed by two symmetrical shapes that resemble breakpoints (not directly related to Harvey but being an IDE/debugging shape gets there). They also point up and down, evoking the up/down of server requests. Things going up and down in a controlled, symmetrical way.
Colors could be adjusted, the green or purple. Still, at only 8 shapes the logo is simple. Feedback welcome.

I like this ^

@mikesanderson This is awesome!


Move _count logic to parser section and fix handling when TIMES does not have a lower bound

Migrate to new project


Difference between Morphable model and PCA Model.

Hi patrikhuber,
I know this is a very basic question but I want know whats the difference between Morphable model  and PCA model in simple words I am confused about these two terms can you please give me a little bit overview about these two terms and differentiate them and what they contains? also tell me about basel face model are they related with each others?
Thanks

Morphable Model is the term usually used for a "model" containing two models, namely a PCA model of shape and a PCA model of vertex colour (albedo). You can find more details in the 1999 Blanz & Vetter paper. Our VISAPP paper also has a nice class diagram that explains the relationship in the code.
The Basel Face Model is a Morphable Model from the Graphics and Vision group in Basel (link). There's also our Surrey Face Model.

Thanks very much.

@patrikhuber Hi, say we use ICP for shape model. But when computing albedo model, how do you make sure the color vertex are in correspondence when original scans and template have different amount of verts?

@tiancaipipi110 Just use the registered template's vertex positions to look up the colour values in the texture of the original scan. I recommend that you read the literature on registration. This is not really on topic here. You would be better suited on a help website like StackExchange.

@patrikhuber right! Thanks!


React.createContext on server

Type of issue
Feature request and bug
Description
Due to this PR, we need to keep track of when using ReactContext universally.

I think we already support using context for SSR, and the react-apollo PR is just fixing some of their usage of it? Anything specific we need to do here?

@KevinGrandon Currently , the context itself doesn't work on SSR, it needs to be fixed on react-apollo, we can't do anything, sorry.

Our CacheContext will work fine as long as it's on client.

Thanks, I'm still not clear on what we need to do in our codebase. Do we just need to upgrade react-apollo versions when it comes out?

I believe we just need to upgrade react-apollo once the fix is ready, so closing this for now. Feel free to re-open or file a new issue if there's anything specific we can do in the meantime. Thanks for bringing this to our attention.

@KevinGrandon This issue has been resolved, cheer
https://github.com/apollographql/react-apollo/issues/2291


Need more exemple

Hello,
Sorry, but have you an example to work with Rocket framework ?
It's built over hyper with http2 but all my test don't work...
Thx

Hi!
Unfortunately, rocket is unsupportable by the ngrok crate, at least in a direct capacity. The issue is that Rocket only offers the ability to configure the port that it listens on via its Config struct, with no way to provide a generic "listener-like" object, as with the hyper server, and, by extension, tower and axum.
To work around this, you can use either the forward_http or forward_tcp methods from the TunnelExt trait to automatically forward all incoming connections on a tunnel to another address, similar to how the standalone agent operates.


[SIL] NFC: remove TailAllocatedOperandList template

Introduces InstructionBaseWithTrailingOperands to wrap llvm::TrailingObjects and remove TailAllocatedOperandList, which is less safe, less feature rich, and less space efficient when compared to the LLVM type. This new template also helps automate boilerplate methods like getAllOperands().

@swift-ci please test and merge


Build failed with error saying annotation processors must be explicity declared now

Hi there,
I recently added these two dependencies to write some custom detekt rules.
implementation 'io.gitlab.arturbosch.detekt:detekt-api:1.7.4'
testImplementation 'io.gitlab.arturbosch.detekt:detekt-test:1.7.4'

But build failed with an exception saying:
Annotation processors must be explicitly declared now. The following dependencies on the compile classpath are found to contain annotation processor. Please add them to the annotationProcessor configuration.
(org.jetbrains.kotlin:kotlin-compiler-embeddable:1.3.71)
Adding this kotlin-compiler-embeddable dependency with kapt didn't help.
What should i need to do for building project with these dependencies ?
Thanks

Hi,
do you know who prints this warning?
Which plugins do you use?
It seems that you apply some plugin to your custom-detekt-rules module which shouldn't be necessary for detekt.

Thanks for response.
I've seperated module for custom-detekt-rules and basicly have one custom-rule class and one class for testing this rule class. So i added the dependencies below.
In this new custom-detekt-rules module that i create i have only basic plugins like
com.android.library,
kotlin-android,
kotlin-android-extensions. I haven't add any extra plugins.
I think detekt uses kotlin-compiler-embeddable and detekt has some kind of annotation processor that i also need to add with kapt. I can go with includeCompileClasspath = true but since it's deprecated and doesn't solve the real problem, i try to find what is the main problem

Ok problem solved with addition of
annotationProcessor "org.jetbrains.kotlin:kotlin-compiler-embeddable:1.3.71"
I didn't get why kapt didn't work but it seems this line solves the issue


Application ID does not appear in Android files (AndroidManifest and MainActivity)

Description
When we create a project, the argument --argument-id is not used in several Android config files.
Steps To Reproduce

Create a Flutter project with the command : very_good create flutter_app foo --application-id com.foo.app

Open the files :

foo/android/app/src/main/AndroidManifest.xml
foo/android/app/src/debug/AndroidManifest.xml
foo/android/app/src/profile/AndroidManifest.xml
foo/android/app/src/main/kotlin/com/foo/

Check the package names in those files

Start again with the command : very_good create flutter_app foo --org com.foo --application-id com.foo.app

Expected Behavior
The package name must be : com.foo.app
But it is instead : com.example.verygoodcore.foo or com.foo.foo
Screenshots

The application ID should not be in the AndroidManifest or the MainActivity class. It resides in the build.gradle file, as @alestiago mentioned above. It is only used to identify your application in the Play Store.
The package name in the AndroidManifest is what dictates the directory structure of your code. It is what you should see in package definition in e.g. the MainActivity class.
It is perfectly fine for the two to be different. The package name can be changed at any time, but the application ID can not be changed once your app has been published.
You could argue that it might be expected, or nicer, to have them both be the same after initializing the project. Personally, I think that having different default values helps people understand that they are not one and the same. I would recommend keeping things as is for now, but continue to monitor any feedback related to their default values.

I see. It is good to know that it has no impact on the way it is identified by the Play Store.
I still prefer to have a package name identical to the application ID, because I believe it is what is done by default when you create an native Android project. I think it would be great to keep things as closely as the way it is for most projects.
By the way, when we create a project with flutter create the application ID and the package are identical.
Is there a good reason to change this behavior ?

⚠ ⚠ ⚠
Hello, I tried for the first time to run the app on my Android device, and now it seems that the problem is critical.
⚠ ⚠ ⚠
Whenever I create an app using application-id :
very_good create flutter_app foo --application-id com.foo.app

When I run this app on my Android, the code will not compile !!!!!
I have the following error :
/Users/mb/dev/temp/FLUTTER/TEST/youniqueid/android/app/src/debug/AndroidManifest.xml Error:
	Overlay manifest:package attribute declared at AndroidManifest.xml:2:5-50 value=(com.example.verygoodcore.youniqueid)
	does not match the module's namespace (com.youniqueid.app).
	Suggestion: remove the overlay declaration at AndroidManifest.xml.
	If you want to customize the applicationId for a buildType or productFlavor, consider setting applicationIdSuffix or using the Variant API.
	For more information, see https://developer.android.com/studio/build/build-variants

FAILURE: Build failed with an exception.

PS : I updated flutter and very_good to the last version.
very_good version : 0.22.0
Flutter version : 3.22.2

Thanks @icodeyou for providing further information!I was able to reproduce.

Created the project using:

very_good create flutter_app foo --application-id com.foo.app

Running the application on an Android device:

/Users/alestiago/Desktop/temp/foo/android/app/src/debug/AndroidManifest.xml Error:
        Overlay manifest:package attribute declared at AndroidManifest.xml:2:5-26 value=(com.foo.foo)
        does not match the module's namespace (com.foo.app).
        Suggestion: remove the overlay declaration at AndroidManifest.xml.
        If you want to customize the applicationId for a buildType or productFlavor, consider setting applicationIdSuffix or using the Variant API.
        For more information, see https://developer.android.com/studio/build/build-variants

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':app:processDevelopmentDebugMainManifest'.
> Manifest merger failed : Overlay manifest:package attribute declared at AndroidManifest.xml:2:5-26 value=(com.foo.foo)
        does not match the module's namespace (com.foo.app).
        Suggestion: remove the overlay declaration at AndroidManifest.xml.
        If you want to customize the applicationId for a buildType or productFlavor, consider setting applicationIdSuffix or using the Variant API.
        For more information, see https://developer.android.com/studio/build/build-variants

* Try:
> Run with --stacktrace option to get the stack trace.
> Run with --info or --debug option to get more log output.
> Run with --scan to get full insights.

* Get more help at https://help.gradle.org

BUILD FAILED in 9s
Running Gradle task 'assembleDebug'...                             10.4s
Error: Gradle task assembleDebug failed with exit code 1

Should be solved with https://github.com/VeryGoodOpenSource/very_good_templates/pull/148, we're pending to do a release so the fix is available.

Very Good Cli 0.22.2 has been released, it should have a fix for this issue.
If the issue persists don't hesitate on letting us now by re-opening the issue! 🙌 💙


transport sockets: expose proxy protocol socket

Exposes proxy proto socket
Commit Message: Expose proxy protocol socket publicly.
Additional Description: Finishes off work for upstream proxy protocol header generation (possible performance pass still to come). Previous work so far includes https://github.com/envoyproxy/envoy/pull/10548 (util funcs to generate header), https://github.com/envoyproxy/envoy/pull/10845 (config api message), and https://github.com/envoyproxy/envoy/pull/11584 (non-exposed transport socket). This PR hooks up tcp proxy, adds config factories to the socket, adds integration tests, and adds docs.
Risk Level: Medium
Testing: Unit + Integration
Docs Changes: IP transparency - Added to proxy protocol section to mention this socket for upstream generation, API docs
generated from proto
Release Notes: https://github.com/envoyproxy/envoy/pull/12762/files#diff-0ec5c857b4b6fbbb72b2ffc5275b15efR64
Fixes https://github.com/envoyproxy/envoy/issues/1031

@antoniovicente would you be up for taking first pass?

/assign @antoniovicente

Thank you for adding this. Testing it locally works great 👍

Thanks for trying it out! I actually was seeing some issues with health checks when I was going through functions tests again the other day. For some reason https://github.com/envoyproxy/envoy/blob/1df7242057f3aba3b52d8fcbf8f5169b6a8e8f22/source/extensions/transport_sockets/proxy_protocol/proxy_protocol.cc#L56 was null. I'm trying to figure out what's going on there. This is also probably an indicator that we need an integration test to cover this.

Thanks for the further feedback! My plan right now is to address this weekend. I should have some free time then.

Sorry, I didn't end up getting to everything today. There's still a bit of test re-org to be done as well as adding a test using a TLS socket.

@alyssawilk I think things are ready for another look :slightly_smiling_face:

LGTM modulo clang tidy fix :-)

@lizan can you take a look both as secondary reviewer and API shepherd?

@lizan ping?  Alternately @mattklein123 could do second and Api pass?

I can take a look.

@wez470 This PR generates the following error on build:
ERROR: ~/Library/envoyproxy/envoy/source/exe/BUILD:28:17: in cc_library rule //source/exe:envoy_common_lib: target '//source/extensions/transport_sockets/proxy_protocol:upstream_proxy_protocol' is not visible from target '//source/exe:envoy_common_lib'. Check the visibility declaration of the former target if you think the dependency is legitimate
ERROR: Analysis of target '//source/exe:envoy-static.stripped' failed; build aborted: Analysis of target '//source/exe:envoy_common_lib' failed

Thanks all! 🎉

Doing some more testing on this, there is a common case where it's not behaving as expected from what I can tell.
The first few requests always work correctly for me, or if I never change downstream/upstream IPs everything works correctly also.
But when changing the downstream remote IP, the remote IP inserted in the proxyproto header is randomly reused from previous connections.
Logs (%DOWNSTREAM_REMOTE_ADDRESS%) always shows the correct address though.
Rough steps to reproduce:
Have envoy listen on <IP_ADDRESS>:9000 and tcp proxy to a cluster that listens for connections, reads the proxy protocol header, and then promptly closes the connection.
ip route add local <IP_ADDRESS>/8 dev lo
# run this about 20 times:
curl --interface <IP_ADDRESS> <IP_ADDRESS>:9000
# then run this about 20 times
curl --interface <IP_ADDRESS> <IP_ADDRESS>:9000
# then run this about 20 times
curl --interface <IP_ADDRESS> <IP_ADDRESS>:9000

The expectation here and what the logs show is 20 connections each from the 3 separate addresses above.
Any ideas?
I tried setting ConnectionPoolPerDownstreamConnection: true, with no luck unfortunately.

I wonder if this comment, suggesting existence of connection reuse scenarios, is relevant:
https://github.com/envoyproxy/envoy/pull/4684#discussion_r224930480

Sadly it's not that simple but I've confirmed there's definitely a bug here.  I'll pick up fixing.


Precision Deadtime scalars

See elog 3028. Precision scalars are now included in the data stream. Run 4187 is first run file to disk to test sorting of this new feature. I'm not sure exactly what the best way to deal with these in the sorting code is at the moment, in respect to displaying as histograms etc. These will be used in the analysis of precision half-life measurements.

If they are in the Scaler bank, they are already include.  The scalers from
these banks get put in a separate tree in the fragment file.   These allows
them to be plotted in time against fragments stored in the fragment free.
On Jul 20, 2015 12:00 PM, "Adam Garnsworthy"<EMAIL_ADDRESS>wrote:

See elog 3028. Precision scalars are now included in the data stream. Run
4187 is first run file to disk to test sorting of this new feature. I'm not
sure exactly what the best way to deal with these in the sorting code is at
the moment, in respect to displaying as histograms etc. These will be used
in the analysis of precision half-life measurements.
—
Reply to this email directly or view it on GitHub
https://github.com/GRIFFINCollaboration/GRSISort/issues/398.

Should there be a separate ScalerTree? Or are they included in the EpicsTree?

They are in the epics tree.  Old naming convention, tigree calls in its
scale bank epix but it sets it from sclr if reading Griffin data.
On Jul 20, 2015 12:31 PM, "SmithJK"<EMAIL_ADDRESS>wrote:

Should there be a separate ScalerTree? Or are they included in the
EpicsTree?
[image: frag4187_contents]
https://cloud.githubusercontent.com/assets/10604745/8781105/138e086a-2ec2-11e5-9078-1c2cce26c1ec.png
—
Reply to this email directly or view it on GitHub
https://github.com/GRIFFINCollaboration/GRSISort/issues/398#issuecomment-122941384
.

We need to make some modification then. The EpicsTree appears to be reading out the 40 Epics scalers and not also including the 128 precision scalers. The size of "Data" is always 40.

Not sure I follow... Attached is a screen shot from run 4187.
The "EpicsTree is being filled with the vaules from "MSRD" which is always size 40 and tid type 9 (float).  I see no other events in this tree.
If there are other scalers, they are not in this file.

I did something stupid.... I see them as SCLR events. One sec

So, we want these to be 8 byte scalers,  do we know the write ordering ( high-low, low-high?) as they are written out in four byte chunks?  Also, where in the odb do we find the ordering of this list?  And does it make sense that only the first 64 channels have numbers in them?

Adam had on two GRIF-16s, for 32 channels. There should be four scalers for each channel, coming to 128 entries, which is how many non-zero words I see in the entries.

ok, I too see the 128 words, so each g16 has two 8 bytes scalers.
But I am still missing something here.  There are 320 total 4 byte datum in
the bank, which is 160 8 byte "scalers".   Assuming 4 "scalers" per channel
than gives 40 channels or 2.5 g16's.   This seems like a very strange
number.
Also, any thoughts on byte ordering or where the matching list in the odb
is stored?
On Mon, Jul 20, 2015 at 2:04 PM, SmithJK<EMAIL_ADDRESS>wrote:

Adam had on two GRIF-16s, for 32 channels. There should be four scalers
for each channel, coming to 128 entries, which is how many non-zero words I
see in the entries.
—
Reply to this email directly or view it on GitHub
https://github.com/GRIFFINCollaboration/GRSISort/issues/398#issuecomment-122969757
.

Also what are the odds that 0xc0000000 bits are never set (either high or
low)?  are we possible looking at two 28 or 30 bit numbers instead?
On Mon, Jul 20, 2015 at 2:12 PM, Peter<EMAIL_ADDRESS>wrote:

ok, I too see the 128 words, so each g16 has two 8 bytes scalers.
But I am still missing something here.  There are 320 total 4 byte datum
in the bank, which is 160 8 byte "scalers".   Assuming 4 "scalers" per
channel than gives 40 channels or 2.5 g16's.   This seems like a very
strange number.
Also, any thoughts on byte ordering or where the matching list in the odb
is stored?
On Mon, Jul 20, 2015 at 2:04 PM, SmithJK<EMAIL_ADDRESS>wrote:

Adam had on two GRIF-16s, for 32 channels. There should be four scalers
for each channel, coming to 128 entries, which is how many non-zero words I
see in the entries.
—
Reply to this email directly or view it on GitHub
https://github.com/GRIFFINCollaboration/GRSISort/issues/398#issuecomment-122969757
.

I meant the 0xfc000000 not what I wrote above...
On Mon, Jul 20, 2015 at 2:18 PM, Peter<EMAIL_ADDRESS>wrote:

Also what are the odds that 0xc0000000 bits are never set (either high or
low)?  are we possible looking at two 28 or 30 bit numbers instead?
On Mon, Jul 20, 2015 at 2:12 PM, Peter<EMAIL_ADDRESS>wrote:

ok, I too see the 128 words, so each g16 has two 8 bytes scalers.
But I am still missing something here.  There are 320 total 4 byte datum
in the bank, which is 160 8 byte "scalers".   Assuming 4 "scalers" per
channel than gives 40 channels or 2.5 g16's.   This seems like a very
strange number.
Also, any thoughts on byte ordering or where the matching list in the odb
is stored?
On Mon, Jul 20, 2015 at 2:04 PM, SmithJK<EMAIL_ADDRESS>wrote:

Adam had on two GRIF-16s, for 32 channels. There should be four scalers
for each channel, coming to 128 entries, which is how many non-zero words I
see in the entries.
—
Reply to this email directly or view it on GitHub
https://github.com/GRIFFINCollaboration/GRSISort/issues/398#issuecomment-122969757
.

Details on the non-ideal ordering and more information about the scaler output here: https://elog.triumf.ca/Tigress/GRIFFIN/3028. I think that for now, unpacking the scaler buffer to a "Data" array, similar to the EpicsTree, will work.
Hopefully @AdamGarnsworthy can give more insight into the 0xfc000000 bits. Is it possible that the run was just not long enough to set those bits?

I saw that earlier when Adam mentioned it.  It doesn't answer the questions
above.  I have half of the unpacking done, working on the written an
associating.  Midas doesn't know how to write a long int as far as i know
(and it tells us from type 6 that this are int32_t's), so how the data is
packed has to be done in what ever code is making this bank.  They need to
be reconstructed correctly to be meaniful, for right now I will assume it
is 32 bits high followed by 32 bits low for each channel...
On Mon, Jul 20, 2015 at 2:50 PM, SmithJK<EMAIL_ADDRESS>wrote:

Details on the non-ideal ordering and more information about the scaler
output here: https://elog.triumf.ca/Tigress/GRIFFIN/3028. I think that
for now, unpacking the scaler buffer to a "Data" array, similar to the
EpicsTree, will work.
Hopefully @AdamGarnsworthy https://github.com/AdamGarnsworthy can give
more insight into the 0xfc000000 bits. Is it possible that the run was just
not long enough to set those bits?
—
Reply to this email directly or view it on GitHub
https://github.com/GRIFFINCollaboration/GRSISort/issues/398#issuecomment-122986167
.

They are four 4-byte scalars for each of the 16 channels of a GRIF-16. The frontend is polling all 5 GRF-16s and adding the data for all scalars to the data stream.
So you see 4 x 16 x 5 = 320 4-byte words.
The ordering is:
chan1: 0us, chan1: 1us, chan1: 10us, chan1:100us,
chan2: 0us, chan2: 1us, chan2: 10us, chan2:100us,
etc, then the same for the next GRIF-16.

0xc000000 being set is certainly a possibility. If these data words showed up in the same bank as our normal data then this would confuse the parser. However these are words in the SCLR bank and should be treated separately and independently from the other data.

The issue with the bits is I never saw the bits 0xfc000000 set in the any of the values.  It may just be a function of a short file or it maybe that they are masked out in the producer.  The SCLR midas bank can not be mixed up with the data bank unless we change there name to GRIF0 | GRIF1 and change there bank type to EventData (0x00000001).  This is near impossible.
The SCLR events in the midas file are now read in as unsigned ints with four values at a time being assigned to an "entry number".  The list of entries are than filled in a tree, currently there are 80 entries in each row of the tree, this will scale automatically if the bank changes size.
Whats left to do:   There is a function (TSCLRFrag::SetAddress(int *array,int size); once we know which channel belongs to which entry in the midasbank, we need to fill in this function.  The call to the function currently lives in TGRSILoop, so it can directly access the variables in the ODB in case these turn out to be simple array.  Once this is done, we can use TChannel to some useful info for each entry (name, channel number, type, etc...).  We may also want to add some smart getter functions to the TSCLRFrag class that returns the values with a more sensible name.  As can be sen in the attached screen shot, the variable names right now are just Data1, Data2, Data3, Data4.
I should also say, this SCLRTree only gets creates in griffin runs where the scalar bank is present and has a valid size. This should make it completely backwards compatible.
Also in the screen shot, the first "scaler event" has a MidasSerialNumber of 134, after this the restart as zero.  This particular serial only gets updated when the a MidasEvent with type 2 gets written to a file, it comes from the Midas platform.  The first one being 134 means it came from another run.

We're now processing scalers a different way - they come through as actual events and @VinzenzBildstein has completed the initial functionality of the TScaler class. Modifications to that class should be another issue.