Incorporate cf-metadata mailman archive from UCAR into CF GitHub website

Dear all
The CF UCAR email archive has vanished, in which our discussions occurred before we started to use GitHub. There's a broken link to it on the discussion page. We had previously discussed that it would make sense to host the archive in GitHub. Luckily @davidhassell had downloaded it a while ago (as a plain-text file in Unix mailbox format). I have converted this to HTML looking like this and prepared a pull request to include in the CF GitHub website instead of the broken link.
Does this look OK? Please note that this isn't finished yet because faq.md contains references to particular emails and I'll have to work out which ones they are. I have modified discussion.md and governance.md, I believe. However, this pull request contains so many files that I can't look at it. Also, the first automatic check failed. I would appreciate GitHub advice.
Best wishes
Jonathan

Dear Jonathan - I think that the new page looks fine. These new files are large (collectively at least 75 MB), but they're an essential artifact that will never change, so I think that GitHub can cope!

The discussion pages look fine (although I've noted after downloading the page as a whole that index.html contains a link to discussion.html at root, which is fine on the website because the shoe fits, but it's not fine when you're looking at a local copy, which in my case takes me to C:\discussion.html and thus to nirvana).
I ended up booting my Linux in order to take a look at this. Indeed, discussion.md and governance.md have been changed. Found it out like this:
$ git diff --name-status main | grep -v Data/cf-metadata-mailman
M       discussion.md
M       governance.md

And the differences in those are:
$ git diff main *md
diff --git a/discussion.md b/discussion.md
index 92803cda..e5541f16 100755
--- a/discussion.md
+++ b/discussion.md
@@ -54,8 +54,7 @@ on the [CF Metadata Trac](Data/trac.html) site.
 [website]: https://cfconventions.org
 [trac]: Data/trac.html
 [about]: about-trac.html
-[mail]: http://mailman.cgd.ucar.edu/mailman/listinfo/cf-metadata
-[archives]: http://mailman.cgd.ucar.edu/pipermail/cf-metadata/
+[archives]: Data/cf-metadata-mailman
 [current]: http://cfeditor.ceda.ac.uk/proposals/1?status=active&namefilter=&proposerfilter=&descfilter=&filter+and+display=filter
 [proposals]: http://cfeditor.ceda.ac.uk/proposals/1?status=inactive&namefilter=&proposerfilter=&descfilter=&filter+and+display=filter
 [github_issues]: https://guides.github.com/features/issues
diff --git a/governance.md b/governance.md
index 19f7048b..df5ffb1a 100755
--- a/governance.md
+++ b/governance.md
@@ -83,7 +83,7 @@ The climate research community is indebted to the above for their magnanimous co

 [rules]: rules.md
 [errors]: errors.md
-[mail]: http://mailman.cgd.ucar.edu/pipermail/cf-metadata
+[mail]: Data/cf-metadata-mailman
 [html]: Data/cf-documents/cf-governance/cf2_whitepaper_final.html
 [pdf]:  Data/cf-documents/cf-governance/cf2_whitepaper_final.pdf
 [ticket146]: http://cfconventions.org/Data/Trac-tickets/146.html

meaning that in those files, the references to [mail] have been removed in the case of discussion.md and updated in the case of governance.md, and that the reference to [archives] had been updated. I think this is good as I've checked discussion.md and see no hanging references.
The only thing that remains would be the updates to faq.md. I believe you're probably the best person to do that - would you mind updating that as part of this PR, or would you prefer to do it in a separate issue?

Hi all - The UCAR/CGD hosted archive is back up. I touched base with CGD folks some months back and they said they were happy to continue hosting it. I just reached out again about this outage but haven't heard back yet.

That's useful, thanks. Shall we have both then?

In my view, if we know that UCAR's going to host for the foreseeable future I'd prefer to hyperlink to them - it keeps our repo nice and small. If that's not the case then of course we should have our own copy.

I feel that it would be more robust if we had our own copy. It's helpful that UCAR CGD have hosted it for so long, and will to continue to do it, but there have been outages before, and CF isn't part of their mission. Is the size of it a problem? The HTML version of the email archive is 180 Mbyte. My copy of cf-convention.github.io repo is 1.1 Gbyte, the majority of which is the standard name table Data. If that's a correct reflection of the size of the repo, this isn't a huge increase, and these files will never change, so there won't be any further increase because of it. Or perhaps it could be put in a different repo of the same GitHub organisation and still be linked to the website?

Dear Daniel @erget et al.
http://mailman.cgd.ucar.edu/pipermail/cf-metadata has gone again this morning. I do think we would be better off if we had our own copy of this. Of course, it's helpful if UCAR keep theirs online too, since there may be other links to that site in various places. There are at present some in faq.md, which I can work through and replace if we decide to put our own copy online.
Above, I asked

perhaps it could be put in a different repo of the same GitHub organisation and still be linked to the website?

I don't think that be done, can it. The other repos are not accessible to the web; only the repo with the special name ending github.io. If it's a problem to have the 180 Mbyte of static emails in this repo, we could create a separate GitHub organisation for it, with its own github.io repo. What other possibilities are there?
Best wishes
Jonathan

perhaps it could be put in a different repo of the same GitHub organisation and still be linked to the websit

I think we can do this: http://cfconventions.org/webtest1 is the web presence of https://github.com/cf-convention/webtest1.
So if we create a new repo called, say, discuss-archivefor the archived discussions, we could link to it via http://cfconventions.org/discuss-archive

I think putting it in a separate repository wouldn't be a bad idea - if we had tons of time we could always reformat the HTML pages into Markdown but I think that'd be more trouble than it's worth unless the stuff outside the body and header are static enough that we could cover them by making them part of a template. So +1 on @davidhassell 's proposed implementation of @JonathanGregory 's idea.

Marvellous, thanks. I misunderstood about GitHub websites. Any repo can be seen at github.com/organisation/repo but the github.io one has the special URL organisation.github.io. I propose we should put the archive in a repo called mailman, because that's what it is.

Hello @JonathanGregory  - I'm not so sure about calling the repo mailman, as that's what we might call it given that it's in a particular format, not what it actually means (cf. standard names :)), hence I prefer something that indicates that it's an "archive of discussions".

OK - how about mailing_list_archive, which is what it's called on http://cfconventions.org/discussion.html?

@JonathanGregory  - mailing_list_archive sounds good to me.

Fine by me. I do have 1 other idea - we could commit the archive using LFS, so it doesn't "clog" the git history - then the website would build without depending on another repo, simplifying the build process. Would that be better?

I don't fully understand the implication of using LFS, but I'm equally happy with that suggestion as I am committing them as usual.

I fixed this by making a new PR.
# Secure Jonathan's changes outside repo
$ git checkout mailman-archive
$ mv Data/cf-metadata-mailman ~
$ cp discussion.md governance.md ~
# Make new branch based on main to commit to
$ git checkout -b lfs-mailman-archive main
# Copy in data secured from Jonathan's branch
$ mv ~/cf-metadata-mailman Data/
$ cp ~/discussion.md ~/governance.md .
# Start committing that stuff
$ git add discussion.md governance.md
$ git lfs track "Data/cf-metadata-mailman/**"
Tracking "Data/cf-metadata-mailman/**"
$ git add .gitattributes
$ git add Data/cf-metadata-mailman/*
$ git commit -m "Add CF UCAR email archive"
...
$ git push erget

Result's in https://github.com/cf-convention/cf-convention.github.io/pull/225.

Thanks very much for this magic, @erget! I have closed https://github.com/cf-convention/cf-convention.github.io/pull/221.
The usual rule is that we should wait three weeks for further comments before this is merged. In this case, it's a bit inconvenient because faq.md needs to be updated as well, and it's difficult to work on because the pull request is too large to be viewed. I think we could merge it sooner by agreement, as if it were an update to the website. It would be helpful if anyone who has comments could make them known as soon as possible.
The proposal is to

Install in this GitHub repo a copy of the cf-metadata mailing list archive. We no longer use the mailing list but the archive of postings is valuable information. It is still hosted at UCAR but currently offline. Daniel @erget has made a PR which adds the archive (180 Mbyte) to the repo with GitHub large file support, so that it's not tracked. It's a static blob.

Change the website to point to the GitHub copy of the archive as the primary source for reference, rather than the UCAR original.

Does anyone have concerns about this? Thanks. Jonathan

Hi @JonathanGregory and all - Just two things.
I would like to understand the issue(s) impacting the NCAR/CGD archive (and give them a heads-up) before deciding to replicate cf-metadata archive on the CF Website. It is unclear to me the extent of the problem as I have only found the NCAR/CGD cf-metadata archive site inaccessible once in the last few days. Are others seeing this more regularly?
I'm a bit unclear on how the LFS storage works with GitHub Pages sites. Does storing the email archive in LFS mean these files will not impact the size of the published CF website? The size limit for published GitHub Pages sites is 1 GB and the current build artifact is 865 MB. So, we are somewhat close to that limit. In the past, we've discussed other ways to reduce the size of the site. It might be worth revisiting that discussion at some point.

Dear @ethanrd
I don't think the UCAR archive goes offline "regularly" but it has happened more than once before. (It's still offline now.) But even if it were perfectly reliable, wouldn't it be better for CF to host its own documents?
I don't know the rules about LFS. If it's problematic, other suggested alternatives are (1) put it in a different repo of our GitHub organisation. Then it would be under github.com instead of github.io - would it count as the same site? (2) put it in a different GitHub organisation also managed by us.
Best wishes
Jonathan

Dear all
I have been looking around for an answer to the question which @ethanrd asked

Does storing the email archive in LFS mean these files will not impact the size of the published CF website? The size limit for published GitHub Pages sites is 1 GB

I can't find a direct answer to this question, but https://docs.github.com/en/repositories/working-with-files/managing-large-files/about-git-large-file-storage says (at the bottom)

Git LFS cannot be used with GitHub Pages sites

I assume this means that, although we can put the files in the repo with LFS to avoid it being counted in the repo size, we can't access them on the web. If so, LFS isn't a solution.
The other solution we discussed is to put them into another repo of the organisation, as a GitHub pages project site, such as David has demonstrated. The size limits apply to repos, not to the organisation, so I suppose that would work, wouldn't it?
Cheers
Jonathan

Hi @ethanrd @JonathanGregory , I'm not sure about the use of the Unidata archive vs. one we own ourselves - wouldn't want to tread on the toes of those who've invested time and money in maintaining the mailman server. I wasn't aware that we can expect it to continue working.
On a technical level, having a second repository is a bit cumbersome but if we expect it to be static forever I suppose it's ok, then it won't impact the build process. It's a cross-domain link but we have the fabulous link checker now so we#ll probably catch it if something goes sour. I wasn't aware about LFS not being compatible with GitHub Pages, that's a pity.

Dear @erget @ethanrd
I don't see why UCAR would be offended if we have our own copy of our own material, and link to both copies from our website. That seems sensible to me just for greater resilience - wouldn't you agree? It's not surprising if things go wrong from time to time. I note that their copy is still offline. I'm grateful to them for hosting for so long. Even before we stopped actively using the mailing list, there were difficulties from time to time and Brian Eaton kindly intervened to get it working again a few times.
Best wishes
Jonathan

The CGD-hosted CF email archive has been accessible for me every time I've tried except for one instance when this issue started on 27 July. Are others still unable to access it?

Hi - I can not access it just now (2022-08-02 14:45Z).
I was using the link http://mailman.cgd.ucar.edu/pipermail/cf-metadata/ (found from https://cfconventions.org/discussion.html) and got "404 Not Found The requested URL /pipermail/cf-metadata/ was not found on this server."
Is that the correct URL?

Oh, hang on! at 2022-08-02 14:47Z it now works ...

I wonder if it has something to do with using HTTP rather than HTTPS. I believe all UCAR sites are required to only support HTTPS. Though usually HTTP requests get forwarded to the matching HTTPS request.

I think you're right that it must be something to do with http vs https, @ethanrd, thanks. It didn't work for me with http just now. Then I tried https, and now it works with both. Good. So it is working, and we can of course change https://cfconventions.org/discussion.html to use https.
But still, I think we should keep our own copy too, for resilience and because it seems logical to me that CF GitHub should host CF archives. Jonathan

OK. I talked with the NCAR/CGD folks involved in the current archives. They agree that a second copy would be good.
Two questions:

The file names and directory structure in the PR don't match the file names and structure in the current archive. Should they? Pro: Matching names/structure would make existing references to archive messages easy to update. Con: We'd have to grab another copy. I could ask folks at CGD who may be able to grab a copy from file rather than us scraping the site.
Do we need to use LFS? The individual files are not large. There are just lots of them, 9 or 10 thousand. (Did we decide not to keep them in a different repo?)

Dear @ethanrd
Thanks for asking NCAR/CGD.

Yes, I agree with the Pro. With the different organisation I will need to update links in the FAQ. Another Con is that the old organisation is perhaps less convenient for searching, because each year is in its own file.
LFS can't be presented to the web, so we can't use that, although it was a good idea. The concern was the size of the email archive altogether, which is 180 Mbyte, bringing us nearer to the GitHub pages limit. Hence a new repo in our organisation might be best. That would be fine to link from the website.

Best wishes
Jonathan

Hi @JonathanGregory, all - The CF email archive is down again and I haven't heard when/if it will be coming back up. It also has Google search indexing blocked which I think we need (I know that's how I have generally searched the archive).
So I think we should proceed with the structure you have (I think I was the last one hesitating on duplicating the archive).
From a quick review, looks like mailing_list_archive was the last suggestion for the name of a new repo.
Are there any other issues or decisions to make before proceeding with that plan?

I don't believe so, the only suggestion I'd make is to name the repo with slug spacing, i.e. mailing-list-archive rather than with underscores because I find it easier to type. I care about the differentiation a lot less than whether there's milk in my coffee though, so I'm happy to be ignored here if someone like underscores more.

Dear all
As well as resilience and hosting our own archve which can be googled, there's a further advantage of offering different views, in that the file I made with David's help is all years together, whereas the NCAR/CGD one is organised by years.
We already have hyphens in other repo names, but no underscores, so hyphens are the right choice. @davidhassell, if you agree with this, please would you be so kind as to create a mailing-list-archive repo and give me any permission I might need to submit a pull request to it?
For future reference, @erget, do you like milk in your coffee or not? I like milk in my tea, but not sugar, thanks.
Cheers
Jonathan

Repo created: https://github.com/cf-convention/mailing-list-archive. It is public, so PRs can be submitted by anyone.

Hi @JonathanGregory , I take mine unembellished in any way, but if I drink tea I tend to follow your example :)
So I think the next things to do are

Now that we have the files in the repo, get it setup with a website,
Hookup the cfconventions.org website to refer to the new repo's website, and
Document this all somewhere so we don't forget about it because it's not super super obvious

Does that sound about right? Perhaps a topic for the upcoming hackathons?

I've just enabled the website for mailing-list-archive http://cfconventions.org/mailing-list-archive. It is currently just displaying the repo's minimal README.

Thanks, @davidhassell. I have created PR #1 in the new repo to add a copy of the hypermail version of the mail archive as a directory Data in the repo. This is the same contents as the copy I put up on my own website.  As before, you can't see it properly in the PR because there are too many files. Please could someone check and merge it? Once that is done, I will make a pull request in this repo (a modified version of my earlier PR) to add a link from the discussion page, and also correct the link to the NCAR archive to use https (fixing the error Ethan @ethanrd noticed).

Dear Jonathan - thanks. The view on your website looks good (screenshot below). I wonder if we could add a slightly more informative title, above the "cf-metadata-mailman by ..." line? I'd suggest "Archive of all CF discussions from 2006 to 2019, including questions, standard names and enhancements.", simply since that's what I wrote in the README, but it wouldn't have to be that!

Thanks, @davidhassell. I have created PR #1 in the new repo to add a copy of the hypermail version of the mail archive as a directory Data in the repo. This is the same contents as the copy I put up on my own website. As before, you can't see it properly in the PR because there are too many files. Please could someone check and merge it? Once that is done, I will make a pull request in this repo (a modified version of my earlier PR) to add a link from the discussion page, and also correct the link to the NCAR archive to use https (fixing the error Ethan @ethanrd noticed).

Good approach @JonathanGregory . I've checked https://github.com/cf-convention/mailing-list-archive/pull/1 and would approve it but I don't have write access to the repo! @davidhassell can you help? I think it's because I'm a member of the CF organisation but not an owner, so I don't get write access by default. We might change that or live with it - either way I've commented the PR so it's clear that it's been reviewed (at least to confirm that its contents have filenames that are expected, I didn't dig deeper than that on this).

Hi Daniel and Jonathan, I've given you both write permission to the repo, so you can approve and merge  - but I'll put my title suggestion in a suggest-changes review for traceability.

@davidhassell @JonathanGregory I've updated the title in line in the PR with David's proposal - if you're happy, I'm happy with it being merged.

Dear @davidhassell and Daniel @erget, Thanks for your interventions. I agree about the title. I had not considered that! It's the name of the mailbox fle at the time I processed it. I'll see what I can do with manual editing. J

Good point, @ethanrd  - I have added teams permissions as you suggest, and also info-mgt (following the leas of other repos).

Dear @davidhassell @erget
Following your conversation in PR #1, I edited my local copies of the html to replace the text cf-mailman-archive. In most places I put mailing-list-archive as a short form, and in the titles of the indexes I put Archive of CF discussions from 2006 to 2019 on the cf-metadata mailing list. You can see what it looks like again on my website. I have made a new PR for this version. Is that all OK?
Jonathan

Looks good to me:

Good, thanks for checking, @davidhassell. I have closed the old PR. Please could someone merge the new one?

Done. So glancing back up, we've got the material in https://github.com/cf-convention/mailing-list-archive, but I'm still not clear on how to do the rest of the setup:

Now that we have the files in the repo, get it setup with a website,
Hookup the cfconventions.org website to refer to the new repo's website, and
Document this all somewhere so we don't forget about it because it's not super super obvious

(1) is done.
(2) looks like it's good to go if the hyperlink points to the right place, but currently it's just the README, whereas I believe it should point to the archive index, and we could drop the reference to the README (or link to the archive index from the README).
And then (3) is still outstanding.
I'm happy to take these on in Santander, or to provide support from the sidelines if there's a volunteer now - I'm sadly a bit strapped for time in the interim. Any takers? If not I'll volunteer in 2w.

Thanks for merging, Daniel @erget. The mailing list archive can now be seen on the web at https://cfconventions.org/mailing-list-archive/Data/. I will make another PR to link it to the CF website.

Please could someone check and merge PR #244 to update the link from the Discussion page to point to the GitHub copy of the mailing list archive. The NCAR archive is linked as well, now with https, but it's not working at present. Thanks. Jonathan

Looks good @JonathanGregory , many thanks. Merged.
@davidhassell how did you get the archive repo to be found under the cfconventions.org domain? Are there any updates to the docs that we should complete before closing this issue?

David and I can record how we made the mailing list archive. I think the right place to record this would be in README.md of the new repo - do you agree?

That's a nice idea, and I agree about the location. I'm not sure that I have much to provide, apart from that the source data came from a simple text concatenation of each year's archive file downloaded from the NCAR site. Do remind me if I did more ...

@davidhassell the only thing that's missing from my side is what magic makes https://cfconventions.org/mailing-list-archive/Data/ point to the data found in https://github.com/cf-convention/mailing-list-archive/tree/main/Data. I don't see an entry for mailing-list-archive/Data/ in https://github.com/cf-convention/cf-convention.github.io - I'm sure there's a clever way of establishing the link, but how that works is a mystery to me.

@erget, I don't think this is anything special. The mailing list archive is a GitHub Pages project website. The URL of a project website is organisation.github.io/repo, which in this case is cf-convention.github.io/mailing-list-archive. Because cfconventions.org points to cf-convention.github.io, cfconventions.org/mailing-list-archive/Data points to cf-convention.github.io/mailing-list-archive/Data. Ta-da! I made this link yesterday without any magic.

Wow, this is what revelation feels like... Great, then let's close this and thank you for helping me grasp that!


Making mandatory to add 'character set latin1' when making the APIM mysql 8 database

Description:
Currently in the Change to MySQL page, it shows in an info box that for Windows users it is required to add character set latin1 when creating the databases. However, for MySQL 8 it is necessary to add the part to create the apim_db database.
Solution:
In the Change to MySQL page, change the info box to warning box and inform that for MySQL 8 it is mandatory to add 'character set latin1'
For Tested DBMSs page also this change need to be added which is already done to IS documentation
create database apim_db character set latin1;

Description: Currently in the Change to MySQL page, it shows in an info box that for Windows users it is required to add character set latin1 when creating the databases. However, for MySQL 8 it is necessary to add the part to create the apim_db database.
Solution: In the Change to MySQL page, change the info box to warning box and inform that for MySQL 8 it is mandatory to add 'character set latin1'
For Tested DBMSs page also this change need to be added which is already done to IS documentation create database apim_db character set latin1;


This is not the correct coordinator/ co-ordinator unaware of this member

ERROR [org.springframework.kafka.KafkaListenerEndpointContainer#1-0-C-1] ConsumerCoordinator: [Consumer clientId=consumer-6, groupId=mysearchapp] Offset commit failed on partition recruiter_entity-0 at offset 6535: This is not the correct coordinator.
We are getting this issue intermittently. Any suggession would be great help for me.
we are using kafka => <spring-kafka.version>2.2.7.RELEASE</spring-kafka.version>****

This has nothing to do with Spring - it appears you have had a rebalance for some reason.
For errors regarding the kafka-clients library, you should reach out to the broader Kafka community, e.g. on Stack Overflow tagged with apache-kafka.

This has nothing to do with Spring - it appears you have had a rebalance for some reason, perhaps your listener is taking too long to process the records; try reducing max.poll.records.
For errors regarding the kafka-clients library, you should reach out to the broader Kafka community, e.g. on Stack Overflow tagged with apache-kafka.

Thanks for the speedy response.


[Incompatibility] Update to V10

The module doesn't appear to be working with Foundry V10, getting an error when a player accepts the trade.

Fixed in 0.4.3


Incorrect Az command in the Page

Describe the bug
At this page:
https://learn.microsoft.com/en-us/cli/azure/eventhubs/eventhub/authorization-rule?view=azure-cli-latest#az-eventhubs-eventhub-authorization-rule-create
The command in the Examples is missing "eventhubs"
So instead of
az eventhub authorization-rule create --resource-group myresourcegroup --namespace-name mynamespace --eventhub-name myeventhub --name myauthorule --rights Listen

It should be
az eventhubs eventhub authorization-rule create --resource-group myresourcegroup --namespace-name mynamespace --eventhub-name myeventhub --name myauthorule --rights Listen

Related command
az eventhubs eventhub
Errors
N/A
Issue script & Debug output
N/A
Expected behavior
N/A
Environment Summary
N/A
Additional context
N/A

@doctorlai-msrc The PR for the fix has been created and it will be merged soon. Thanks again for pointing this out, I am closing the issue based on this update, please let us know if there is something else that we can help you with.


Simplify internal generator and refactor a wle controller

[ ] Configuration Infrastructure
[ ] Docs
[ ] Installation
[X] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure
Pull Request Attributes
Please check any characteristics that apply to this pull request.
[ ] Does not have any changes that may affect Istio users.

@hzxuzhonghu: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
f796a05673ed2a31c3f5ba3629ac1ed66b427731
link
/test release-notes_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hzxuzhonghu: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
f796a05673ed2a31c3f5ba3629ac1ed66b427731
link
/test release-notes_istio

unit-tests_istio
f796a05673ed2a31c3f5ba3629ac1ed66b427731
link
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hzxuzhonghu: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
f796a05673ed2a31c3f5ba3629ac1ed66b427731
link
/test release-notes_istio

unit-tests_istio
f796a05673ed2a31c3f5ba3629ac1ed66b427731
link
/test unit-tests_istio

lint_istio
f796a05673ed2a31c3f5ba3629ac1ed66b427731
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hzxuzhonghu: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
f796a05673ed2a31c3f5ba3629ac1ed66b427731
link
/test release-notes_istio

unit-tests_istio
f796a05673ed2a31c3f5ba3629ac1ed66b427731
link
/test unit-tests_istio

lint_istio
f796a05673ed2a31c3f5ba3629ac1ed66b427731
link
/test lint_istio

gencheck_istio
f796a05673ed2a31c3f5ba3629ac1ed66b427731
link
/test gencheck_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hzxuzhonghu: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

gencheck_istio
f796a05673ed2a31c3f5ba3629ac1ed66b427731
link
/test gencheck_istio

lint_istio
cc4bd6968fe97d94c0f3dd4b4e824bc8397441de
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hzxuzhonghu: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

lint_istio
cc4bd6968fe97d94c0f3dd4b4e824bc8397441de
link
/test lint_istio

gencheck_istio
cc4bd6968fe97d94c0f3dd4b4e824bc8397441de
link
/test gencheck_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hzxuzhonghu: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

lint_istio
cc4bd6968fe97d94c0f3dd4b4e824bc8397441de
link
/test lint_istio

gencheck_istio
cc4bd6968fe97d94c0f3dd4b4e824bc8397441de
link
/test gencheck_istio

integ-pilot-multicluster-tests_istio
cc4bd6968fe97d94c0f3dd4b4e824bc8397441de
link
/test integ-pilot-multicluster-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@stevenctl  @howardjohn Let's based on this to fix the race of reg/unreg

ping @stevenctl @howardjohn

@hzxuzhonghu: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-pilot-multicluster-tests_istio
0d684f630e37c08b8aba27eb606168379bfff2fb
link
/test integ-pilot-multicluster-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hzxuzhonghu: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-pilot-multicluster-tests_istio
0d684f630e37c08b8aba27eb606168379bfff2fb
link
/test integ-pilot-multicluster-tests_istio

integ-telemetry-k8s-tests_istio
0d684f630e37c08b8aba27eb606168379bfff2fb
link
/test integ-telemetry-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test integ-pilot-multicluster-tests_istio

/test integ-telemetry-k8s-tests_istio

@hzxuzhonghu: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-telemetry-k8s-tests_istio
0d684f630e37c08b8aba27eb606168379bfff2fb
link
/test integ-telemetry-k8s-tests_istio

integ-pilot-multicluster-tests_istio
0d684f630e37c08b8aba27eb606168379bfff2fb
link
/test integ-pilot-multicluster-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test integ-pilot-multicluster-tests_istio

This pr conflicts so frequently, can we make it in quickly?

@ramaraochavali please take a look, i am tired of rebasing.

Thanks @stevenctl and @ramaraochavali


Update gRPC vendor

It's now v1.6.0, which is pretty old and 9 minor releases behind.

I'll update this and some other outdated vendors


[WIP] Configure Danger

First attempt at configuring Danger for this repository
Note: Once this works, we might want to migrate the installation of the xcpretty gem into the Gemfile as well — now that we have one to include Danger — and alter the .travis.yml accordingly.

          1 Error

:no_entry_sign:
Please include a CHANGELOG entry.
You can find it at CHANGELOG.md.

          1 Warning

:warning:
PR is classed as Work in Progress

          1 Message

:book:
We use the following format for CHANGELOG entries:
```

Describe your change here.  Don’t forget to use 2 spaces at the end of the last line describing your change.
#nn
<

  Generated by :no_entry_sign: danger

Need to add DANGER_GITHUB_API_TOKEN to the circleci configuration.

Done!
btw looking at the rake compile:output log files used:

Their named is only used based on the context being used but not the subcommand. This results in e.g. output_compile_default_context_empty_raw.log to be used as a log file for storyboards + strings + colors etc, each overriding the previous one
it could be worth making it possible to group/organize them in a folder, like output_compile/strings/default_context_empty_raw.log

Basically, in Utils.run, maybe the subtask parameter should add a _ in the file path but a / instead? (even if we might have to mkdir  -p the directory first in those cases to ensure it exists)

Will look into it. Also saw something reaaaally interesting on Slack today:
https://github.com/orta/danger-junit
Integrates failed tests into danger.


feat(firewall): add jupyter hub and livy to firewall

Which issue(s) this PR fixes

Fixes #195
Additional comments

Agreements

[x] I hereby declare this contribution to be licensed under the Apache License Version 2.0, January 2004.
[x] I hereby agree to grant TOSIT a copyright license to use my contributions.

forced-pushed to add missing public zone to livy spark3


Can not export resume as pdf

I'm using the resume-cli to generate a pdf version of my resume, but the generated file is corrupt when I try to open it.
As far as I can tell the pdf conversion logic is located on the registry server, with an endpoint for the cli to connect to, so the error is likely on the registry server.
Navigating to http://registry.jsonresume.org/thomasdavis.pdf is responding with "ERROR: No API conversion tokens available", and not with the actual pdf. Could it have something to do with pdfcrowd? Perhaps a missing or invalid API key/token, the error message seem to suggestion something in that manner.

I am having the same problem. Kind of a deal breaker for me.

This is caused by the following code: https://github.com/jsonresume/registry-server/blob/master/server.js#L77. Currently, the pdf encoding is handled by pdfcrowd, an freemium online PDF converter. Here are some alternatives:

html-pdf prints to pdf using phantomjs.
jsPDF recently added support for adding html elements to a PDF.
Firefox and Webdriver isn't the most performant solution.

There are a lot of html to pdf converters out there, I personally tried 18 of them and the most accurate was wkhtmltopdf. It still has a lot of issues, but it looks like the most popular tool out there.
I'd recommend disabling the pdf feature from the cli and providing help text instead of the misleading "ERROR: No API conversion tokens available" message. Also not that browser's print to pdf functionalities could be used as mostly anyone can do this without the need of any other cli tool, it's not cool, but it works ;)


Feature/cu 1da4wxv Boss Bullet Hell

This PR contains most of the features of the Bullet Hell with 3 patterns of example and debugging tools on AttackDronesController. This is an early PR so you can start reviewing files before the final PR.
What's left to implement is:

Get DronesFormation from Patterns file and apply them on wave change.
Recoil On Drones Shoot.
Call from Duke Script
Clean Code and possible optimization

This hasn't yet been merged with the newest version of BossBasicStructure.


Changelog Management

Fontsource goes through many types of different updates, however, developers may sometimes remain confused whether an update is associated with an update from the font source itself, or if it is a change in how the repository is creating libraries either through a feature addition or bug fix.
I'm quite frankly lost on choosing the best method to maintain changelogs for every library Fontsource publishes.
There are quite a few monorepo integrations for semantic-release:

atlassian/lerna-semantic-release
dhoulb/multi-semantic-release
pmowrer/semantic-release-monorepo

There are a bunch more, but I believe all these solutions feel over-engineered and unreliable to implement into our build chain.
My current thought process is to create our own solution that hooks into our code directly to determine whether it is a direct source update or a change from Fontsource itself (retrieving those specific update details via a manually, possibly automated, maintained changelog in the main repo) and generate the individual changelog for each library alongside all the other files that are built with each build.
If anyone has any better ideas, I'd love to hear them. Else I might tackle this issue in a few weeks and see what we end up with.

Closing after #41. This can be addressed in the future in more depth if it continues to pose as a problem.


ci: Replace diff --exit-code with status --porcelain to catch untracked files

I commited this line to the repo quite some time, but discovered over time that it has one fatal flaw: git diff only considers tracked files.  In the event that the command-at-test generates new files that weren't checked in by accident (and aren't explicitly in .gitignore), git status --porcelain will return a non-empty string and allow the test to fail appropriately.
Note that it is typically unlikely for this to happen, as e.g. a single missing Rust file generally results in a compilation failure, assuming a mod has likely been added in a file that was tracked already.  But better to be safe than sorry nevertheless.

This has worked well for some time. I'm reluctant to change it unless there's a more compelling reason to do so. It sounds like this is an unlikely issue but if you'd like to add a commit that should how this breaks and also validates that it still detects changes as before then we can consider it.

Glad to hear that it hasn't happened to this repo yet. I'm just cleaning up after my own submissions from earlier, feel free to take it or leave it. I don't think spending time to implement the sketched scenario is worth it, tbh.


Fancy Zones - Snapping a Window to Two or More Zones - Doesn't Work

Provide a description of requested docs changes
I recently downloaded power toys, saw fancy zones, and hit win+ backtick (`) to open it.
I checked the documentation: https://docs.microsoft.com/en-us/windows/powertoys/fancyzones#snapping-a-window-to-two-or-more-zones
And checked the following under "Window Behavior":

And yet hitting win+ctrl+alt+arrows moves the windows, same as win+arrows without ctrl+alt.

This also does not work with two monitors (I'm using the "Priority Grid") as the window is cut off between both monitors.
Also, the scroll wheel does not work inside PowerToys for some reason. This is the only app I've ever used where the scroll wheel does not work.

Can't record my screen with game bar, so I had to download https://www.freescreenrecording.com/, then can't upload videos to github so had to convert: https://ezgif.com/video-to-gif and reduce quality. Hopefully you guys can see this. Half the time I'm pushing win+arrows, the other half I'm pushing win+ctrl+alt+arrows, it does the same thing, and the window gets cut in half only sometimes (it's inconsistent).

Love powertoys and think this thing is awesome, many of the features don't seem to work and the interface is clunky. I've probably wasted several minutes alone trying to scroll down or up the settings pages, trying to select or drag the scrollbar, and figure out why I can't scroll.

Those docs are the first result for "fancy zones one window multiple zones" and despite hundreds of articles and videos, there is no other source saying any way to do this. Maybe it just doesn't work on my machine?
I've also noticed that in addition to the scroll wheel not working, the scroll bar is super buggy, home, end, page up, and page down are all broken as well. Again, this is the only program on my computer that doesn't work with the scroll wheel.

The docs also say win+ctrl+alt allows the user to quickly switch layouts. This does nothing for me, both with and without the layout editor open.

Also I found one more bug with Fancy Zones in Power Toys:
I have a dual monitor setup, with three zones (1,2,3) on each monitor. The windows snap to monitor 1 zone 1, monitor 1 zone 2, monitor 1 zone 3+monitor 2 zone 1, monitor 2 zone 1, monitor 2 zone 2, monitor 2 zone 3. In other words, the leftmost monitor has the rightmost window split in half between monitors, but the rightmost monitor does not. They both have the exact same layout selected and I have never used a different layout.

Wow, that's a lot of information. Let's try and break ik into steps.

I can only assume you have the latest version installed.
the gif shows Spotify, I assume this applies too other apps too?
there are quite a few settings for FancyZones, it might take a bit of time to get comfy with it and finding the correct settings for you. Also, PowerToys is not finished yet, so some bugs may still exist, although less and less over time.

The docs also say win+ctrl+alt allows the user to quickly switch layouts

This works if you have different layouts set up. Each one can be accessed via a hotkey, visible in the settings for that specific layout. Based on what I can see so far, you only have one (at least for each monitor).
for the developers, you can create a debug file with more info. Click on the tray icon, then "create zip". Then you can drag it from your desktop into a comment here.
it would help to keep different subjects in different issues, so if the Settings window issue persists, that may have an issue of its own. But, I also saw your comment on the new style, so I would just wait for that in the new update.

Thank you for your quick reply.
I'm sorry for all the spam, just wanted to provide as many details as possible and document what I was seeing to help diagnose and improve.
I have the latest version as far as I know (just got it recently), Windows was last updated a few weeks ago.
Just tried on Notepad and same problem, win+arrow keys and win+ctrl+alt+arrow keys do the same things, also wacky and inconsistent with 2 monitors
Yeah I want to customize FancyZones in the future, but honestly the default focus view is good enough for now. I used to just use win+arrow keys and fiddle with stuff myself, I only downloaded PowerToys because I saw you could use FancyZones to make everything easier.
I have no layouts other than the defaults, but there are multiply layouts by default:

I have priority grid selected for both monitors.
I don't see "create zip" anywhere or any tray icons in power tools or the layout editor for FancyZones. Could you please help me find it?
I'm not sure I understand your description enough to agree or confirm, but what is happening is that the win+arrow keys shortcut works correctly to move across different zones, but the shortcut (win+ctrl+alt+arrow keys) does the same thing, rather than adding new zones and letting one app span multiple zones per the docs.
I've been having trouble with my mouse recently. Unfortunately, I only have one mouse, I've tried resetting it and updating drivers but it's still finicky. It's gotten worse over time.
I guess there are really three bugs here:

The scrolling bugs

The one program multiple zones (lack thereof) bug

The zones being buggy with two monitors

PowerToys looks really awesome, I'm excited to eventually use this for my layouts : )

No problem, it's not spam. Being specific is good to get to the source of something. Speaking of details, to create the debug file, find the PowerToys icon in the system tray. Right click, and the one I mean should be in the middle. (I'm on my phone right now:)
Another simple step: could you make a screenshot of all the settings for FancyZones?

Hi, @justingolden21 let's take a look at the problems step by step.  At first, you're right regarding the documentation, it should be updated. Win + Arrow and Win + Ctrl + Alt + Arrow do exact the same thing.
Regarding other problems, a bug report could help us investigate them. You can find it in the menu with right-click on the PowerToys tray button.

The docs also say win+ctrl+alt allows the user to quickly switch layouts. This does nothing for me, both with and without the layout editor open.

To use this feature you should first assign keys to custom layouts in the Editor. It doesn't work with templates.

Did some testing myself now.

The scrolling bugs

As I said, I would put this to rest until the updated GUI is released. Also: off-topic for this issue.

The one program multiple zones (lack thereof) bug

I think, for multiple zones, you have to use the mouse while dragging and use Ctrl to select multiple (consecutive) zones.

The zones being buggy with two monitors

I think that there actually is not a bug at all. Because the Spotify window has a minimum width of 800px, it will not fit inside the narrow zones on the sides. Top/left will be aligned accordingly. When moving the window left and right, it does go to zone 1, 2, 3 on every monitor - notice they wrap-around between monitors. Also notice that the edge between zones 1 and 2 is right above the blue icon on the task bar, so it does get used.

Thank you both for the answers, clarifications, and information. @Jay-o-Way @SeraphimaZ
I right clciked the system tray icon and clicked "report bug" (thank you for the screenshot by the way, that was very helpful), and it seemed to do nothing. I waited a while and tried a few more times. Then after a few seconds, the application force closed and a zip file appeared on my desktop. Attaching that now. Seems like a bad UX for bug reporting if I may provide some feedback there as well.
PowerToysReport_2021-08-23-15-59-39.zip
You mention that Win + Arrow and Win + Ctrl + Alt + Arrow do the same thing, so then how would I go about changing a window to fill multiple zones? That's what I was trying to do in the first place before all this other stuff lol.
Got it, to assign shortcuts to specific layouts I need to edit the layout shortcut in the layout.
As for dragging multiple zones, do you mean to use ctrl with shift, or after I used shift, or by itself? It doesn't seem to work for me either way. Also, dragging windows in general now is super buggy. Just to move the Notepad application anywhere on my screen takes immense effort and more than five minutes. No idea if this is PowerToys or my mouse, but it was never this bad before.
I need to clarify my bug with the two monitors. In fairness, it's hard to expain. Let me try an ugly MS paint mockup:

So basically, the left monitor has zone 3 extending to the right, but the right monitor has zone 1 "correctly" only in the right monitor, same as all other zones 1 and 3.

I've got even more bugs!
For some, and only some apps, it's like the screenshot above, but for some the left monitor zone 1 is twice as big and extends well into zone 2.
Right now I have vs code and discord open. VS code goes either to zone 1, 2, or 3 correclty on monitor 1, but VS code goes into zone 1 + half of 2, or 2 + half of 3, or 3 + all of 1 in the right monitor...

Also, creating a custom layout is very difficult. Clicking to delete takes like ten minutes for me to delete a single zone (I just start over every single time) and there is no undo or redo. There should also be a way to manually enter the dimensions. The UI is very good in theory anyway, I love the design.

I found one more minor bug (sorry for the spam, feel like it's helpful to report this stuff real quick)
When opening power toys from the windows menu, it opens fine, but when I create a  desktop shortcut from the windows menu and open it, it opens but it's minimized. I'm assuming this isn't intentional behavior.

I've noticed sometimes that power toys isn't active, and almost every time I turn on or restart the PC I'll have to open and close power toys for it to work. Just my feedback / UX
Thanks for all the work on this. Awesome stuff.

Hi, what's the latest status for this issue? Been a number of releases in the mean time...

Cannot make the command Win+Ctrl+Alt+[arrows] to work when I connect to a computer via RDP (Windows Remote Desktop). When I'm working on the same computer directly, this works like a charm. I've tried out all three options in RDP before connecting; Tab = Local Resources, Keyboard and setting for Apply Windows key combinations: as follows:

On this computer None of the key combinations work (using FancyZones in PowerToys)
On the remote computer FancyZones work and its key combinations. Win+Ctrl+Alt+[arrows] does not work.
Only when using the full screen FancyZones work and its key combinations. Win+Ctrl+Alt+[arrows] does not work.


Use text/template instead of html/template in url building

Now the "html/template" is used for templating URLs in get subcommand. That leads to unnecessary escaping of the URL parts.
For demonstrating the expected and current behaviours I use the following patch applied which is not a part of this PR
This patch adds k0s project as a tool to download by arkade.
diff --git a/pkg/get/tools.go b/pkg/get/tools.go
index 5feedb9..e394d63 100644
--- a/pkg/get/tools.go
+++ b/pkg/get/tools.go
@@ -1283,5 +1283,24 @@ https://github.com/{{.Owner}}/{{.Repo}}/releases/download/{{.Version}}/{{.Name}}
 			`,
 		},
 	)
+
+	tools = append(tools,
+		Tool{
+			Owner:       "k0sproject",
+			Repo:        "k0s",
+			Name:        "k0s",
+			Description: "Zero Friction Kubernetes",
+			BinaryTemplate: `
+			{{$arch := ""}}
+			{{- if eq .Arch "x86_64" -}}
+			{{$arch = "amd64"}}
+			{{- else if eq .Arch "aarch64" -}}
+			{{$arch = "arm64"}}
+			{{- end -}}
+			{{.Name}}-{{.Version}}-{{$arch}}
+			`,
+		},
+	)
+
 	return tools
 }

Expected Behaviour
The version scheme of the k0s project is built like:

+<kubernetes_version>
I expect the final url be like this

➜  arkade git:(master) ✗ go run main.go get k0s
Downloading k0s
https://github.com/k0sproject/k0s/releases/download/v1.21.2+k0s.1/k0s-v1.21.2+k0s.1-amd64

Current Behaviour

However because of the html/template the url is built like this
➜  arkade git:(9575ed0) ✗ go run main.go get k0s
Downloading k0s
https://github.com/k0sproject/k0s/releases/download/v1.21.2+k0s.1/k0s-v1.21.2+k0s.1-amd64

Possible Solution

Change templating engine from html/template to text/template
Steps to Reproduce (for bugs)

add a new tool with special sign ("+" for example) as a part of the templated string
try to download that tool

Context

I was trying to add support of the https://k0sproject.io tool
The support of the k0s tool is not a part of that PR.

Check at: https://github.com/sponsors/alexellis

[ ] Yes
[X] No

Should be fixed in #447

Hi there,
That's a perfect example, and exactly what we're looking for in contributions. Issue first, discussion, then PR if requested.
Can you as part of your PR add the K0s project, and the requisite unit test? Just rename your PR to "adding K0s project" and follow the example given elsewhere for unit-testing.
In that way, your patch is warranted, but if we have no examples that fail, then it is useful, but of theoretical benefit.
Alex

@alexellis sure, I will modify the PR accordingly. Do you have any way to prevent some tool from being listed under specific problem? The k0s binary doesn't work on darwin

@alexellis I added two new binaries as a part of the PR (k0s and k0sctl) + rebased with the actual main branch

Thank you

Since PR #447 was merged for almost a year ago and it is working great.
I'll close this if you don't mind.

/close


Temporary fix for broken Result release.

Xcode 7.1 made Result a little broken. Rob has fixed that, but
not yet put out a release, so I'm pointing at a specific commit
(just so we can have something that works) for now.

Is there a better branch or something that we can/should point at instead of a specific SHA? master maybe?

Not sure. I just did the simplest thing I could, as a temporary fix. Maybe master would be better.

They also just released a new beta, if we want to point to that.

I'm currently facing this issue with Carthage when trying to use Swish with ReactiveCocoa v4.0.0-alpha.3
Could not pick a version for github "antitypical/Result", due to mutually incompatible requirements:
	"0.6.0-beta.5"
	"0.6.0-beta.3"

Would love to see a version of Swish that points to Result 0.6.0-beta.5 for that reason.

Anything I can do to help move this along?


add python api to get headers only from files

As in the bug report except get_parent_sha1 is returning a option instead of a 20 bytes 0 filled vector. Not sure if you want that, or would prefer a exception instead, but i thought python 'None' was better suited to represent 'no parent' than the zero filled 20 bytes; and it still fails if you test with if header.get_parent_sha1 == other.get_sha1.
Now i just want a way to extract the sha1 of only each track instead of the total...

Looks mostly good, just some small changes needed.

Now i just want a way to extract the sha1 of only each track instead of the total...

Get the metadata to find the track separations, buffer the track via hunk and calculate the SHA1 manually. You can do this in the Python side or in Rust side faster, https://github.com/SnowflakePowered/chd-rs/blob/master/rchdman/src/main.rs#L514 does the SHA1 of the whole thing but if you parse the track metadata you should be able to do it for each track.

Mmm maybe the return being a list is not the best api
I'm thinking of a environment where there are mixed versions of the header. This code only handles v5 headers, and i'm fine with it, for myself, but imagine someone that places both v5 and v4 and tries to read both in a single call.
Exception. While if the for was external, the exception could be caught. Yeah, i think i'm exposing the single header version of the function instead.

You can add a version() method to Header that just matches on the header type and returns the version

You can add a version() method to Header that just matches on the header type and returns the version so you can do
headers = [chd_read_header(f) for f in files]
headers_v5 = [h if h.version() is 5 for h in headers]

return type? usize or u32?
Also I had to turn the function len from u32 to usize for the #[pyo3(name = "__len__")] property to work.

I believe you have to cast it to usize for PyO3

It's also different from the method already there in that that method returns a PyResult. Should this one do that too, or is it pointless?

ah nvm, if it compiles as u32 then PyO3 should handle it fine. If you don't need Result then you don't need to return PyResult either.

lgtm, just run cargo fmt and fix the formatting

Done.

released as 0.1.3 on pypi, thanks again!

If you're still interested, I managed to fix the lifetime problem with an Option trick to enforce parent lifetimes at runtime in https://github.com/chyyran/chd-rs-py/commit/1c26d412307e9db382f76863a0be9f6bb6fca42f and added a header method to Chd built off this PR as 0.1.4 on pypi

Nice hack. A bit mindbending if you're not used to rust, but i can see how it would be useful in other contexts.


Passenger showcase

I have added language about aspect ratio to both the guide and submission form.  I also added info about the maximum file size (included both the width of 800 px and file size of 500 kb. )

I just had one small suggestion to your edits.

Thanks! Added! @klinegareth can you take a look and merge if it all seems good to you!


'structuralSharing' has incorrect type when combined with 'select'

Describe the bug
When using both select and structuralSharing, structuralSharing is incorrectly typed to the query result instead of the result of the select parameter.
Your minimal, reproducible example
https://www.typescriptlang.org/play?ts=4.9.5#code/JYWwDg9gTgLgBAbzgVwM4FMCKz1QJ4A0c2ueA0uoXAKoYn4DyYMwEAdqnAL5wBmUEEHADkAARgBDDpIDGAawD0UdBJkwAtAEcc+YQG4AsAChjvZGzWs2cAGIQIACgCUiY3Hco6OvA4RuPAdqkFHgAXHAA2gBEcpRRALoE-gHuQfg2bOESqHgWcM5wALwAfHASAO4SwPBRABLoADYNEHAA6tANACZRSUYpHhgN6GrhqDBQRaVjUAB0Q2wA5jAAFr397tPIashQEg0AyssSUMCL4Q4SRABGLiWufesBCgpwbBAsMuhwKxLwK1+oYALNi-HZfCC8b7LYCcGHfPBgdCdb4taanBbXZDwarCTiqGDIPYNPBwMDZDDI-6vZAgK64PgCISDYYwZKPODKAlQaxRKKGB79LhsrhOflcIA
Steps to reproduce
Create a query with both a select and structualSharing.  The select should return a different type from the queryFn.
Expected behavior
The structuralSharing function is typed to accept the queryFn return, but is actually passed the select return.
How often does this bug happen?
Every time
Screenshots or Videos
No response
Platform

Typescript 4.9.5
VS Code

Tanstack Query adapter
react-query
TanStack Query version
4.29.3
TypeScript version
4.9.5
Additional context
No response

yeah, structuralSharing is applied to both the result of the queryFn as well as the result of select.
I think it would be best to widen the types of structuralSharing to a: unknown, b: unknown. Imo, if a custom structuralSharing is implemented, it's something that you'd usually do on a global level for all queries / some queries that have a specific key anyways.
would that work for you? would you want to contribute it ?

I added console logs to the structuralSharing callback and it appears to only call this function with the post select data.

show a codesandbox reproduction please. I'm pretty sure we first have to call structuralSharing for the data that is returned from the queryFn, so that we get a stable input to select. Then, the result of select is also structurally shared as an optimization.

Why was unknown used instead of TQueryFnData | TData?

because structualSharing runs on query level, and TData is only known on observer level.


Add withRouter HoC

Closes #3350.
This is a little funky because we have to set a static on the composed component. I was originally just going to set Component.contextTypes and call it a day, but that creates a side effect. Is there any downside or error in the proposed solution? hoist-non-react-statics is nice to keep from running into unintended surprises (especially if the component is wrapped multiple times).

Huh ... I was thinking
function withRouter(Component) {
  return React.createClass({
    contextTypes: { router: routerShape },
    render() {
      return <Component {...this.props} router={this.context.router}/>
    }
  })
}

That doesn't copy over the static methods, but ... I dunno ... does redux copy over the statics?

Yes: https://github.com/reactjs/react-redux/blob/master/src/components/connect.js#L365
Also, that won't provide it on this.context.router, only this.props.router. Most of the docs assume this.context.router and may or may not include the contextTypes. I think in order to reduce confusion when people copypasta, we should keep it on this.context.router.

Yeah, I want this.props.router and change all the docs.

How about decoration over composition?
function withRouter(Component) {
  if (! Component.contextTypes) {Component.contextTypes = {};}
  Component.contextTypes.router = Router.PropTypes.router;
}

@Download I didn't want to create a side effect.

You want composition because the idea is to make consumers not care about context.
I'd definitely set displayName here so users can tell what's happening.

@ryanflorence But why?
context is documented now. Why do you think it would be going away?
@timdorr What is the problem with a side effect? We are talking React components right? Mostly we just create them at app start and that's it. What issues do you see?

@Download let's discuss justification on #3350, mind cut/pasting over to there your question?

You want composition because the idea is to make consumers not care about context.

I get that.
But context is just as high-level a feature in React as props is now. The function signature for stateless functions (their recommended way for writing React components now) is even:
function MyComponent(props, context /* notice how big context is in terms of API surface */) {
}

Yeah, I want this.props.router and change all the docs.

Ugh, I hear ya, that's just a lot more busywork.

My reasoning is that, given React's user base, context is more dependable as an API than withRouter. Not to bash this project, but that's how I see it. Using context directly keeps my component a standard component whereas using props means that now I am almost forced to wrap it.

Hey, people, let's not justify the feature here, just the implementation #3350 for justification, please move it over there.

@timdorr https://github.com/reactjs/react-router/issues/3350#issuecomment-211599047

Switched it up to this.props.router and stole some stuff from connect()

LGTM other than the test nit, BTW.
I assume we'll want to update docs on another PR, right? Otherwise it's going to get hairy.

I was going to do the doc changes here too. All of that should go together.

+1 to docs change on this commit, will be nice to see it together, sorry I know it's a pain, if you want me to do it, I can do it on my flight to Boston next week :)

Added docs and updated the examples. Also forgot the export. Should be good to go.

You don't need the explicit displayName in the examples – Babel will add it for you automatically, even with the wrapper. See e.g. http://babeljs.io/repl/#?evaluate=true&presets=es2015%2Creact&code=const Foo %3D withRouter(React.createClass({}))%3B.

I was getting unnamed components. Does that apply to Babel 5? (which we're still on!)

I guess it must be a new Babel 6 feature. Bleh.

I'm inclined to say we omit for the sake of terseness anyway.

Maybe we should update to Babel 6... 👹

Any reason we don't?

I remember there being some issues with the examples in Babel 6. I think we figured all of that out, so I'm not sure why not. I can try out a PR later on to see how much work is involved and to centralize discussion.

I just started on Babel 6. We need a custom transform to preserve module exports, and it's a bit of work to avoid breaking the ES build.

Redux does that via an env: https://github.com/reactjs/redux/blob/master/.babelrc

Yup, I know. Just need to tweak a bit to preserve some of our functionality.

I see the automatic displayName logic working against master now. Want to check if it works for the cases in this PR?

Yep, I'll get rid of them now.

thank you for this. We're just in the middle of bringing 0.13 to latest version. when is 2.4.0 expected to be released?


black-pr.yml and black.yml will be difficult to maintain

The prior configuration for the formatting check, while less efficient, had a subtle yet significant benefit that it can be understood just as quickly as it can be read. The new ones, by contrast, are much more difficult to understand, debug, and modify [1][2]. And while additional features will inevitably lead to greater complexity, the tradeoff in this case seems to be more of a disadvantage in the long run.
Refactoring the current configuration to abstract away some of the string parsing and split up the code would greatly improve its maintainability, and in general it'd be best to keep code clarity in mind when reviewing PRs.
Tagging @leotrs @naveen521kk @huguesdevimeux for their work on the change.

The more I look at these files the more they don't make sense to me.
For black-pr.yml:

Why doesn't it checkout the repository with the checkout action provided by GitHub?
Why is it beneficial to only format the files that were edited?
Why run both black --diff and black on each file?
Why manually log the edited files when black logs edited files by default?

For black.yml:

Why remove newlines separating steps in the most densely packed part of the code?
Why set fetch-depth to 0 during the checkout?
Why manually check for modified files when black --check already does this?
Why manually log the version of black when it's logged when it's installed?
Have you considered using an action to create the pull request, like this one?

It's very important that we maintain code hygiene in order to develop efficiently, and right now these changes are making that goal more difficult to achieve.

Reference#362 , #416 , #409

Why doesn't it checkout the repository with the checkout action provided by GitHub?

Yeah, it can be done using the one Github provides yes.

Why is it beneficial to only format the files that were edited?

It is enough to check what has been edited rather than checking for whole library formatting. This would prevent it from failing when it shouldn't.

Why run both black --diff and black on each file?

black --diff is to show what has to be changed by black and black actually formats the file to further check whether there are any files that are changed.

Why manually log the edited files when black logs edited files by default?

That is just for showcase. People would find it difficult on seeing the diff but could be a lot better to just what files have changed directly moving to a section. Possibly we can make it add as a review comment.

Why remove newlines separating steps in the most densely packed part of the code?

That can be easily added though.

Why set fetch-depth to 0 during the checkout?

I think that can be removed may be a redundant line.

Why manually check for modified files when black --check already does this?

I don't understand this. If I am right that is for the comment in the PR. See this comment for example. https://github.com/ManimCommunity/manim/pull/508#issue-497233229

Why manually log the version of black when it's logged when it's installed?

That was to prevent creating conflicting branches. That was written in the aim to run daily but now it is not doing so.

Have you considered using an action to create the pull request, like this one?

First I didn't know there was an action like that and I couldn't find one. If that is helpful, that can be used. But the present implementation is just calling the API and that's it.

It is enough to check what has been edited rather than checking for whole library formatting. This would prevent it from failing when it shouldn't.

This wouldn't happen if all of the code is formatted, were there places where we merged unformatted code?

black --diff is to show what has to be changed by black and black actually formats the file to further check whether there are any files that are changed.

Why do you want to see the changes?

That is just for showcase.

The extra step here just isn't necessary. It clutters the configuration without providing any benefit.

I don't understand this. If I am right that is for the comment in the PR. See this comment for example.

I think that's fine.

That was to prevent creating conflicting branches. That was written in the aim to run daily but now it is not doing so.

Two things: using the date alone would still accomplish that, and "Print Black Version if Failed" is a misnomer since the step is actually committing changes.

First I didn't know there was an action like that and I couldn't find one.

The benefit in this case is that it would make the step much clearer with no real drawback.

Is anyone opposed to me rewriting these?

No objection. @naveen521kk ?

Is anyone opposed to me rewriting these?

No problem.
Also, Alternative to the action is using GitHub CLI.

@eulertour are you working on this?

No, I got sidetracked with other things

black.yml and black-pr.yml have been replaced. The issue can be closed.


Fix cron timeout

Closes #8.
If cronTimeout is 0 or negative, the runner has already been invoked. Instead of setting cronTimeout to 1 (one millisecond) we should get the next time from the iterator.

I did not write a test case for this one as I couldn't reproduce the issue with every second cron expression. If I would write a test with the every minute expression it would slow down the tests significantly 😞

Coverage remained the same at 100.0% when pulling 06306762f8c2d004482cb749f04fa86bf0476bba on tjokimie:fix-cron-timeout into 022a7862367c2c30117959a59a4bec5c03c27ba1 on airbnb:master.

Coverage remained the same at 100.0% when pulling 06306762f8c2d004482cb749f04fa86bf0476bba on tjokimie:fix-cron-timeout into 022a7862367c2c30117959a59a4bec5c03c27ba1 on airbnb:master.

This is great, thanks for fixing this bug. I'm curious when the time returned from the iterator would be negative. 0 seems possible although unlikely.

The time returned from the iterator is not be negative, but cronTimeout (the result of iterator.next().getTime() - Date.now()) can be negative as iterator.next().getTime() can return current time and after that Date.now() will be subtracted from it.

Ah fair, I confirmed that this can happen in my console too:
for (var i = 0; i < 10000; i++) console.log(Date.now() - Date.now())

This sometimes prints negative numbers.

Coverage remained the same at 100.0% when pulling 839679c96a8cf1fae6fabae155f18c29264652e5 on tjokimie:fix-cron-timeout into decbf21ade6c4a3b616bc0f561ec611afb8cd723 on airbnb:master.

Coverage remained the same at 100.0% when pulling 839679c96a8cf1fae6fabae155f18c29264652e5 on tjokimie:fix-cron-timeout into decbf21ade6c4a3b616bc0f561ec611afb8cd723 on airbnb:master.

Coverage remained the same at 100.0% when pulling 839679c96a8cf1fae6fabae155f18c29264652e5 on tjokimie:fix-cron-timeout into decbf21ade6c4a3b616bc0f561ec611afb8cd723 on airbnb:master.

Published as<EMAIL_ADDRESS>


Question regarding the Rust Examples' Readme

Hello!
I was wondering why you build & generate the skel manually (using cargo libbpf <...>) rather than using cargo build like you did at the end.
These commands generate another .skel.rs and .mod files plus keeping the .bpf.o file which cargo build discards automatically.
$ cd examples/rust
$ cargo libbpf build
$ cargo libbpf gen
$ cargo build --release
$ sudo ./target/release/xdp 1
<...>

Thanks!

#29 introduced build script, the following commands are not required now:
$ cargo libbpf build
$ cargo libbpf gen

Thanks for clarifying,
I've opened a PR for removing these commands.

The PR has been merged, closing the issue :)


LandingPage: Integrate selected tab with url.

In the context of HMS-parity with edge management, fixes the current behavior when selecting tabs and navigating back from edge image details view:

when selecting a tabs the corresponding url is shown (the url can be copied , and when pasted we return to the selected tab)
when returning back from edge management details view, the user  return back to the last tab (e.g ostree tab)

FIXES: https://issues.redhat.com/browse/THEEDGE-3445

IQE tests seem to be failing on a timeout, so I'm going to merge this.

Yeah, another day, another issue, now it fails to deploy the iqe-cji-pod where the tests are ran for some reason, didn't see this before.


messenger needs 'updating' instantly locks accounts on attempted log in

as I reported on discord my accounts are auto locked with the error message
Your account is temporarily unavailable. Regain access by updating the app or logging in from a mobile or web browser.

seems like the same problem: https://github.com/miscord/miscord/issues/434


Record page doesn't load in IE11

Spun up a VM testing IE11 on Windows 7 - which is so far the most used flavor of IE visiting our sites and the version of chaise on dev.isrd.isi.edu has a serious bug that doesn't load the record page at all - it just displays the spinner. The error in the console reads:
TypeError: Object doesn't support property or method 'endsWith'
at Anonymous function (https://data.gpcrconsortium.org/chaise/record/assets/javascripts/app.js?v=fd00039d6464ae44ead0dccb82436268:135:17)
at Anonymous function (https://data.gpcrconsortium.org/chaise/scripts/vendor/angular.js:11255:13)
at processQueue (https://data.gpcrconsortium.org/chaise/scripts/vendor/angular.js:15961:11)
at Anonymous function (https://data.gpcrconsortium.org/chaise/scripts/vendor/angular.js:15977:27)
at Scope.prototype.$eval (https://data.gpcrconsortium.org/chaise/scripts/vendor/angular.js:17229:9)
at Scope.prototype.$digest (https://data.gpcrconsortium.org/chaise/scripts/vendor/angular.js:17045:15)
at Scope.prototype.$apply (https://data.gpcrconsortium.org/chaise/scripts/vendor/angular.js:17337:13)
at done (https://data.gpcrconsortium.org/chaise/scripts/vendor/angular.js:11572:36)
at completeRequest (https://data.gpcrconsortium.org/chaise/scripts/vendor/angular.js:11778:7)
at requestLoaded (htt

@crisaless please review.

fixed and looking good!


TensorFlow SavedModel export fails with AttributeError

I'm following the tutorial exactly as it is here: https://www.tensorflow.org/tutorials/keras/text_classification_with_hub
Finally, if I want to export the trained model from this tutorial using model.save() I get this error message:
---------------------------------------------------------------------------
AttributeError                            Traceback (most recent call last)
<ipython-input-19-768eb5acd4e8> in <module>()
      3
      4 export_path = "/tmp/saved_models/{}".format(int(t))
----> 5 model.save(export_path, save_format='tf')

4 frames
/usr/local/lib/python3.6/dist-packages/tensorflow_core/python/keras/engine/network.py in save(self, filepath, overwrite, include_optimizer, save_format, signatures, options)
    984     """
    985     saving.save_model(self, filepath, overwrite, include_optimizer, save_format,
--> 986                       signatures, options)
    987
    988   def save_weights(self, filepath, overwrite=True, save_format=None):

/usr/local/lib/python3.6/dist-packages/tensorflow_core/python/keras/saving/save.py in save_model(model, filepath, overwrite, include_optimizer, save_format, signatures, options)
    113   else:
    114     saved_model_save.save(model, filepath, overwrite, include_optimizer,
--> 115                           signatures, options)
    116
    117

/usr/local/lib/python3.6/dist-packages/tensorflow_core/python/keras/saving/saved_model/save.py in save(model, filepath, overwrite, include_optimizer, signatures, options)
     72   # default learning phase placeholder.
     73   with K.learning_phase_scope(0):
---> 74     save_lib.save(model, filepath, signatures, options)
     75
     76   if not include_optimizer:

/usr/local/lib/python3.6/dist-packages/tensorflow_core/python/saved_model/save.py in save(obj, export_dir, signatures, options)
    905   # Note we run this twice since, while constructing the view the first time
    906   # there can be side effects of creating variables.
--> 907   _ = _SaveableView(checkpoint_graph_view)
    908   saveable_view = _SaveableView(checkpoint_graph_view)
    909

/usr/local/lib/python3.6/dist-packages/tensorflow_core/python/saved_model/save.py in __init__(self, checkpoint_view)
    189           concrete_functions = [function]
    190         for concrete_function in concrete_functions:
--> 191           if concrete_function.name not in seen_function_names:
    192             seen_function_names.add(concrete_function.name)
    193             self.concrete_functions.append(concrete_function)

AttributeError: 'NoneType' object has no attribute 'name'

What's going on? Shouldn't it be possible to simply export this model to the SavedModel format? I'm trying with and without the save_format='tf' parameter.

Can you please provide a simple reproducible case for us to look into the issue as the information provided is too vague to find the root cause. Thanks!

Here you go:
!pip install tensorflow==2.0
!pip install -q tensorflow-hub
!pip install -q tensorflow-datasets

import numpy as np
import tensorflow as tf
import tensorflow_hub as hub
import tensorflow_datasets as tfds

print("Version: ", tf.__version__)
print("Eager mode: ", tf.executing_eagerly())
print("Hub version: ", hub.__version__)
print("GPU is", "available" if tf.config.experimental.list_physical_devices("GPU") else "NOT AVAILABLE")

# Split the training set into 60% and 40%, so we'll end up with 15,000 examples
# for training, 10,000 examples for validation and 25,000 examples for testing.
train_validation_split = tfds.Split.TRAIN.subsplit([6, 4])

(train_data, validation_data), test_data = tfds.load(
    name="imdb_reviews",
    split=(train_validation_split, tfds.Split.TEST),
    as_supervised=True)

embedding = "https://tfhub.dev/google/tf2-preview/gnews-swivel-20dim/1"
hub_layer = hub.KerasLayer(embedding, input_shape=[],
                           dtype=tf.string, trainable=True)

model = tf.keras.Sequential()
model.add(hub_layer)
model.add(tf.keras.layers.Dense(16, activation='relu'))
model.add(tf.keras.layers.Dense(1, activation='sigmoid'))

model.compile(optimizer='adam',
              loss='binary_crossentropy',
              metrics=['accuracy'])

history = model.fit(train_data.shuffle(10000).batch(512),
                    epochs=2,
                    validation_data=validation_data.batch(512),
                    verbose=1)

model.save('tmp')

Was able to reproduce the issue. Please find the gist here.

I am having the same issue


Fix markdown disappearing after editing and hitting the escape key.

For #8045
Hitting the escape key was never actually causing a focus loss because of refactoring done around updating the render stage.

Codecov Report

Merging #8047 into master will decrease coverage by 0.38%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #8047      +/-   ##
==========================================
- Coverage   59.26%   58.88%   -0.39%
==========================================
  Files         499      499
  Lines       22413    22412       -1
  Branches     3597     3592       -5
==========================================
- Hits        13284    13198      -86
- Misses       8300     8377      +77
- Partials      829      837       +8

Impacted Files
Coverage Δ

src/datascience-ui/interactive-common/mainState.ts
44.89% <ø> (-1.11%)
:arrow_down:

src/client/testing/serviceRegistry.ts
48.64% <0%> (-46.85%)
:arrow_down:

src/client/testing/codeLenses/main.ts
44.44% <0%> (-33.34%)
:arrow_down:

...t/datascience/jupyter/jupyterDataRateLimitError.ts
66.66% <0%> (-33.34%)
:arrow_down:

src/client/formatters/serviceRegistry.ts
75% <0%> (-25%)
:arrow_down:

src/client/common/utils/platform.ts
64.7% <0%> (-23.53%)
:arrow_down:

src/client/common/utils/icons.ts
83.33% <0%> (-16.67%)
:arrow_down:

src/client/api.ts
78.57% <0%> (-14.29%)
:arrow_down:

src/client/datascience/cellFactory.ts
75.86% <0%> (-13.8%)
:arrow_down:

src/client/providers/providerUtilities.ts
83.33% <0%> (-5.56%)
:arrow_down:

... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c5414c5...f13e176. Read the comment docs.

Basically I'd like to understand the failure when Uri is still used.
This should only impact the tests.
Meaning we have some test somewhere, where we're expecting file path without the leading /.
E.g. xy.py is not a valid file path on Linux, it is /xy.py and that's what Uri.file(....).fsPath gives us. Else xy.py is just a file name, not a path.

Well this code must not be happening on linux because the functional and unit tests passed on linux

I can just remove this change as it's not related to the fix. I'll enter a separate issue to fix opening the index.html.


Water Blocked

[x] This issue isn't duplicated - you can check if it is by using the search bar located at the top left hand corner and select "Issues" on the left.
[x] This issue includes appropriate markdown for sections - e.g. code blocks for crash dumps.
[x] This issue is understandable - feel free to use your native language to write issues if you are not comfortable with English.

Issue description
Liquids don't work in plots

Reproducing the issue

Place Water or Lava in a plot world

Client information
PocketMine-MP Version: N/A
Plugin Version: Unknown
PHP version: 7.0.13 (default)

Optional information
None

In the config is a setting to enable block updates. That should fix your problem.

How can I be solving this? Can you give me details of how I can be activating lava and water at all

As was previously stated, there is a setting in the config file to enable block updates. That will fix your problem.

Again, the reason why water flow has been disabled is because if it could flow, it could flow into the paths and other people's plots. If you don't care, I guess removing that block of code would let it flow.

Isn't it possible to just not tick the water? It would lagg the server anyways.

I don't think it's possible to prevent a block from being ticked

Fair enough.

    public function onBlockUpdate(BlockUpdateEvent $event) {
        /*
         * Disables water and lava flow as a temporary solution.
         */

        $levelName = $event->getBlock()->getLevel()->getName();
        if ($this->plugin->isLevelLoaded($levelName)) {
            $event->setCancelled(true);
        }
        if ($event->getBlock() instanceof Water or $event->getBlock() instanceof Lava && is_null($this->plugin->getPlotByPosition($event->getBlock()))) {
            $event->setCancelled(true);
        }
    }

I once added this onplot check, it disables it on the roads

@thebigsmileXD the issue is water spreading. Even if the water isn't in the road, it can still spread to it.

I used that code snipped since about 2 years now, and never saw water spreading over borders, simply on plots.

I suppose that makes sense because it's in the BlockUpdateEvent function instead of a BlockPlaceEvent function


Apply to custom images

Hi @DingfanChen:
Hope you are doing well. I wonder if this can be applied to the custom images? Is changing the dataloader enough in such case.

In general, the network architecture needs to be adjusted (at least to the dimensionality of your data). And the hyperparameters may need to be re-tuned.


Task for this homework

Hi all,
What exactly are you going to do in this task? Even though we chose different configuration, we are supposed to perform the same task with different configuration. There is no task distribution for this homework, isn't it?

@pratibha77118 Yes, we just have to make sure we choose the different pair of configuration and perform the same task, and at the last we have to discuss our approach.


Dashing Build Failure: uxrOnTopicFunc structure mismatch

I cannot get the build to succeed. I have tried dockers ros:dashing + micro ros install and base:dashing.
It looks like a structure mis-match issue. The uxrOnTopicFunc structure has an extra unit16_t "length" field. It looks like ePromisa code.
Below is the log for the base:dashing build failure.
ubu@ubu-VirtualBox:~$ sudo docker run -it microros/base:dashing
[sudo] password for ubu:
root@1e804c6cccb2:/uros_ws# source /opt/ros/$ROS_DISTRO/setup.bash
root@1e804c6cccb2:/uros_ws# source install/local_setup.bash
root@1e804c6cccb2:/uros_ws# ros2 run micro_ros_setup create_agent_ws.sh
#All required rosdeps installed successfully
root@1e804c6cccb2:/uros_ws# colcon build --metas src
Starting >>> drive_base_msgs
Finished <<< drive_base_msgs [29.1s]
Starting >>> microxrcedds_agent
[Processing: microxrcedds_agent]
[Processing: microxrcedds_agent]
[Processing: microxrcedds_agent]
[Processing: microxrcedds_agent]
[Processing: microxrcedds_agent]
[Processing: microxrcedds_agent]
[Processing: microxrcedds_agent]
[Processing: microxrcedds_agent]
[Processing: microxrcedds_agent]
[Processing: microxrcedds_agent]
[Processing: microxrcedds_agent]
[Processing: microxrcedds_agent]
[Processing: microxrcedds_agent]
[Processing: microxrcedds_agent]
[Processing: microxrcedds_agent]
[Processing: microxrcedds_agent]
--- stderr: microxrcedds_agent
Cloning into 'fastrtps'...
Note: checking out 'b257a33'.
You are in 'detached HEAD' state. You can look around, make experimental
changes and commit them, and you can discard any commits you make in this
state without impacting any branches by performing another checkout.
If you want to create a new branch to retain commits you create, you may
do so (now or later) by using -b with the checkout command again. Example:
git checkout -b
HEAD is now at b257a3350 XML Services [1.8.x] [7117] (#930)
Submodule 'thirdparty/android-ifaddrs' (https://github.com/michalsrb/android-ifaddrs.git) registered for path 'thirdparty/android-ifaddrs'
Submodule 'thirdparty/asio' (https://github.com/chriskohlhoff/asio.git) registered for path 'thirdparty/asio'
Submodule 'thirdparty/fastcdr' (https://github.com/eProsima/Fast-CDR.git) registered for path 'thirdparty/fastcdr'
Submodule 'thirdparty/idl' (https://github.com/eProsima/IDL-Parser.git) registered for path 'thirdparty/idl'
Submodule 'thirdparty/tinyxml2' (https://github.com/leethomason/tinyxml2.git) registered for path 'thirdparty/tinyxml2'
Cloning into '/uros_ws/build/microxrcedds_agent/fastrtps/src/fastrtps/thirdparty/android-ifaddrs'...
Cloning into '/uros_ws/build/microxrcedds_agent/fastrtps/src/fastrtps/thirdparty/asio'...
Cloning into '/uros_ws/build/microxrcedds_agent/fastrtps/src/fastrtps/thirdparty/fastcdr'...
Cloning into '/uros_ws/build/microxrcedds_agent/fastrtps/src/fastrtps/thirdparty/idl'...
Cloning into '/uros_ws/build/microxrcedds_agent/fastrtps/src/fastrtps/thirdparty/tinyxml2'...
Cloning into 'microxrcedds_client'...
Switched to a new branch 'develop'
Cloning into 'microcdr'...
Switched to a new branch 'develop'
Cloning into 'cli11'...
Note: checking out 'v1.7.1'.
You are in 'detached HEAD' state. You can look around, make experimental
changes and commit them, and you can discard any commits you make in this
state without impacting any branches by performing another checkout.
If you want to create a new branch to retain commits you create, you may
do so (now or later) by using -b with the checkout command again. Example:
git checkout -b
HEAD is now at 49ac989 Fixes to the readme
Submodule 'extern/googletest' (https://github.com/google/googletest.git) registered for path 'extern/googletest'
Submodule 'extern/json' (https://github.com/nlohmann/json.git) registered for path 'extern/json'
Submodule 'extern/sanitizers' (https://github.com/arsenm/sanitizers-cmake) registered for path 'extern/sanitizers'
Cloning into '/uros_ws/build/microxrcedds_agent/CLI11/src/cli11/extern/googletest'...
Cloning into '/uros_ws/build/microxrcedds_agent/CLI11/src/cli11/extern/json'...
Cloning into '/uros_ws/build/microxrcedds_agent/CLI11/src/cli11/extern/sanitizers'...
Cloning into 'sanitizers'...
Already on 'master'
Cloning into 'spdlog'...
Note: checking out 'v1.4.2'.
You are in 'detached HEAD' state. You can look around, make experimental
changes and commit them, and you can discard any commits you make in this
state without impacting any branches by performing another checkout.
If you want to create a new branch to retain commits you create, you may
do so (now or later) by using -b with the checkout command again. Example:
git checkout -b
HEAD is now at 1549ff12 Replace STRING(PREPEND ..) in CMakeLists.txt to support older CMake versions
/uros_ws/src/eProsima/Micro-XRCE-DDS-Agent/src/cpp/p2p/InternalClient.cpp: In member function ‘void eprosima::uxr::InternalClient::set_callback()’:
/uros_ws/src/eProsima/Micro-XRCE-DDS-Agent/src/cpp/p2p/InternalClient.cpp:151:53: error: invalid conversion from ‘void ()(uxrSession, uxrObjectId, uint16_t, uxrStreamId, ucdrBuffer*, void*) {aka void ()(uxrSession, uxrObjectId, short unsigned int, uxrStreamId, ucdrBuffer*, void*)}’ to ‘uxrOnTopicFunc {aka void ()(uxrSession, uxrObjectId, short unsigned int, uxrStreamId, ucdrBuffer*, short unsigned int, void*)}’ [-fpermissive]
uxr_set_topic_callback(&session_, on_topic, this);
^
In file included from /uros_ws/build/microxrcedds_agent/temp_install/microxrcedds_client-1.2.1/include/uxr/client/client.h:24:0,
from /uros_ws/src/eProsima/Micro-XRCE-DDS-Agent/include/uxr/agent/p2p/InternalClient.hpp:18,
from /uros_ws/src/eProsima/Micro-XRCE-DDS-Agent/src/cpp/p2p/InternalClient.cpp:15:
/uros_ws/build/microxrcedds_agent/temp_install/microxrcedds_client-1.2.1/include/uxr/client/core/session/session.h:144:16: note:   initializing argument 2 of ‘void uxr_set_topic_callback(uxrSession*, uxrOnTopicFunc, void*)’
UXRDLLAPI void uxr_set_topic_callback(
^~~~~~~~~~~~~~~~~~~~~~
make[5]: *** [CMakeFiles/microxrcedds_agent.dir/src/cpp/p2p/InternalClient.cpp.o] Error 1
make[4]: *** [CMakeFiles/microxrcedds_agent.dir/all] Error 2
make[3]: *** [all] Error 2
make[2]: *** [uagent-prefix/src/uagent-stamp/uagent-build] Error 2
make[1]: *** [CMakeFiles/uagent.dir/all] Error 2
make: *** [all] Error 2
Failed   <<< microxrcedds_agent	[ Exited with code 2 ]
Summary: 1 package finished [8min 35s]
1 package failed: microxrcedds_agent
1 package had stderr output: microxrcedds_agent
1 package not processed
root@1e804c6cccb2:/uros_ws#

Please check if https://github.com/micro-ROS/micro-ROS-Agent/pull/27 solves it. If it is solved, close the issue, thanks!

I have verified with #27 the build is fixed. Thank you!


chore: Update rb-sys

This commit updates rb-sys to the latest version. I'm hoping that this will fix the failures that are currently in main

@ianks I'm mostly flying blind here, but do you think that this change will help resolve the failures in main: https://github.com/bytecodealliance/wasmtime-rb/actions/runs/8816496220/job/24246997925?

Ah, I'll confirm by running the action with this branch.

yes 0.9.97 should fix that issue, as well add support for aarch64-linux-musl

Thanks, yeah that fixed it, there's also an issue with x64-mingw32 I believe we need to exclude it give that 3.0 is no longer considered stable? See https://github.com/bytecodealliance/wasmtime-rb/pull/317/commits/68fb3d5b1de607d85123e6f2f35f67c9b36fb42c

Yeah, excluding x64-mingw32 fixed the issue https://github.com/bytecodealliance/wasmtime-rb/actions/runs/8834566920


Add kuttl test assert to check Horizon route

This change adds a Kuttl test assertion to ensure the Horizon route is responding to curl requests with the appropriate HTTP status codes.

/test horizon-operator-build-deploy-kuttl
We probably have to rerun it after we merged the change required to run kuttl in a dedicated namespace.


Experiment with contextual embeddings based on Transformer architectures.

Perform initial experiments with the contextual log line embeddings.
Our current embedding is based on aggregating (averaging) of per-token fastText embeddings. Contextual embeddings are expected to improve the performance of the downstream task similarly to NLP.

start with pre-trained BERT-like Transformer models (https://huggingface.co/, https://www.sbert.net/, https://simpletransformers.ai/), then:

continue with unsupervised pretraining with objectives like masked language modeling (MLM) or next sentence prediction (NSP)
finetune on labeled log data

analyze the embeddings (clustering, t-SNE visualizations...)
add to LAD benchmark suite and compare with other methods

raw logs -> distilbert -> f-1 score ~ 0%
drain logs -> distilbert -> f-1 score ~ 96%

MLM - eval_loss: 0.7880746566936903       Masked Language Modeling
CLM - eval_loss: 3.7285281655768676e-07 Next word prediction(Causal Language Modeling)


ASA-3989: Adding github discovery in AppScan Go

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

@bao-lu rather than storing the target url as a File object, we should store it as a String. We should also add the parameters to the declaration of the m_properties variable (i.e. Map<String, String>).


Add /holidays command using Abstract Holidays API

Command Name
/holidays
Public API Resource
https://www.abstractapi.com/holidays-api
Description
/holidays command replies with a list of holidays.
It has country, year, and day options
and will show a list of holidays specific to the options provided
e,g - /holiday country|IN year|2022
results - holidays list from India in 2022 in an embedded form
Implementation Details

Add a new javascript file in the commands folder
Implement a API request with the help of axios to your public API
Format the data in a readable way and send it to the user
Use the discord.js docs to get started

Code of Conduct

[X] I agree to follow this project's Code of Conduct

I would like to work on this command. Please assign this to me @thieleju
Thanks

Hey @BiswajitSahoo-tech, thank you for opening this issue :)
I updated the Contribution Guidelines to only allow one pr/issue per person.
Since you already contributed in #18, I'm not going to assign this issue to you.
Keep contributing ❤

I would love to work on this issue, please assign it to me

@MaruthiKo Sure, please go ahead! :)

Hey, is there a slack/discord channel link for the project, I am having few doubts regarding the issue

No, there's no slack/discord :/
But you can ask me here about your doubts :)

Oh alright, I'm very new to using Api and contributing to OpenSource, can u please guide me on how to complete this issue

This is my current progress on the issue

I just noticed that the api mentioned in the issue requires an api key.
This is rather inconvenient because everyone has to generate their own api key for it to work...
But since I did not find another public Holidays API without requiring an api key, I'd say I close this issue and you can work on another issue with another (more easy to handle) api.
If you want you can choose out of this list or I can pick something for you.
Let me know what you prefer :)

Hoo, that's what I was thinking, if there is an open issue, I'm ready to work on any please feel free to assign me any one of your choice and which u feel can be more useful
Thank you

@MaruthiKo I created a new issue for you, can you comment something so I can assign you to the issue? :)


BUG: Fix child keys warning

Warning: Each child in a list should have a unique "key" prop.
Check the render method of BaseFormView. See https://reactjs.org/link/warning-keys for more information.
in Fragment (created by BaseFormView)
in BaseFormView (created by EntityPage)
...
It is reproducible in browser runtime and tests, for example: link

Thanks @Harshit1q1 for helping us with this one, I merged your PR and it will be available with the next release (it should go this Friday).


Food blog has been created 💫💫

If you like the blog please star the main blog repository in my profile.


Vertical Format?

Hey,
thanks for your great work !
I try to integrate the mediapipe in my project, but since my use case needs vertical format input/output I am trying to change the width and height parameters, but so far unsuccessfully. If I switch the width and height everywhere it seems to break apart - the detections stop working, the image is put to the top left and is not filling the container anymore.
How could I achieve this?
EDIT:
I just used a FLIP top on my input before the syphonspoutout and a FLIP top after the MediaPipe for now.

Hey @burritotrex I think you're on the right track - the AI model itself is trained on landscape webcam type images, so you'll get the best tracking accuracy if you feed it that size and shape images.
You could experiment with boxing the content (black bars on each side of the vertical image to fill out a horizontal frame) to see if that gets you any better or different results. Or the flip and flop may also work. I'd try both to see which works best.


[stable/cockroachdb] Built-in cert-manager support

What this PR does / why we need it:

Add cert-manager certificate resources to the helm chart, to avoid users having to manually match subject alternative names in certificate resources
Update documentation on setting up secure clusters

Special notes for your reviewer:

The implementation of this is made with maximum backwards compatibility in mind. I've tested that the new templates render to the same result as the old ones, when using the same values. The right thing to do here, seems to be to rework the template a bit, but it'll break backwards compatibility, and require a major version bump.
The implementation only covers the certificates, but it could be easily expanded to include the certificate authority and the issuer, with inspiration from #22838

Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

[x] DCO signed
[x] Chart Version bumped
[x] Variables are documented in the README.md
[x] Title of the PR starts with chart name (e.g. [stable/mychartname])

/assign @joshimhoff

@PaulFarver This is weird. Did we really have the same contribution idea on June 16th? :open_mouth: :slightly_smiling_face:
Seems that my PR https://github.com/helm/charts/pull/22838 becomes obsolete with yours.

I'll recreate this in the new repo

Great job, @PaulFarver! This is a much wanted feature :)