[BUG] Source maps not found in dev server for third party packages

Bug Report Quick Checklist

[x] I am on the latest version of Snowpack & all plugins. (3.5.1)
[x] I use package manager npm (Fill in: npm, yarn, pnpm, etc).
[x] I run Snowpack on OS Mac (Fill in: Windows, Mac, Linux, etc).
[x] I run Snowpack on Node.js v12+

Describe the bug
Enabling buildOptions.sourcemap: true causes the dev server to throw "file not found" errors for third party packages .map files. First-party modules don't have the problem
To Reproduce
We can't fix bugs that we can't see for ourselves. Issues often need to be closed if this section is skipped.

npx create-snowpack-app snowpack_sourcemap_test --template @snowpack/app-template-lit-element-typescript
cd snowpack_sourcemap_test
Edit snowpack.config.mjs, add buildOptions.sourcemap: true
Run npm run start
Look at console, see errors for http://localhost:8080/_snowpack/pkg/lit-html.js.map et al.

Expected behavior
No source map errors during development.
Anything else?
The source maps are properly being generated when doing npm run build, just not during dev.

I can confirm this is still an issue as of 3.6.2.
I'm getting [404] Not Found (/_snowpack/pkg/custom-elements.js.map) when running the development server.
This is my snowpack config:
/** @type {import("snowpack").SnowpackUserConfig } */
export default {
  mount: {
    public: { url: '/', static: true },
    src: { url: '/dist' },
  },
  plugins: [
    [
      '@snowpack/plugin-babel',
      {
        transformOptions: {
          sourceMaps: "inline"
        },
      }
    ],
    [
      '@snowpack/plugin-webpack',
      {
        sourceMap: true,
        outputPattern: { html: './build/' },
      },
    ],
  ],
  routes: [
    /* Enable an SPA Fallback in development: */
    // {"match": "routes", "src": ".*", "dest": "/index.html"},
  ],
  optimize: {
    /* Example: Bundle your final build: */
    "bundle": true,
  },
  packageOptions: {
    /* ... */
  },
  devOptions: {
    /* ... */
    "open": "chrome",
  },
  buildOptions: {
    /* ... */
    sourcemap: true,
  },
};

and this is my index.js:
import '@ungap/custom-elements';
import './js/components/components.js';

I have same issue.
I am using chakra-ui.
It's prebuilt javascript which I hosted already has relative path to source map.
This is screenshot for button.js.

But snowpack dev server doesn't host button.js.map which exists at same directory with button.js.

I was running into this problem with web-test-runner coverage mode looking up these broken sourcemaps and causing logspam.
The way the dev server works is by building the files in memory when they get requested so this problem means the internal mapping isn't working for some reason.
The problem with external deps was introduced with a refactor that happened earlier this year:
https://github.com/snowpackjs/snowpack/blob/91cd7dd1c9239542842814f99ad4e40cf94d18ba/snowpack/src/commands/dev.ts#L510-L515
You can see here that for some reason instead of properly serving a sourcemap the code removes the .map suffix and attempts to serve the file itself. (Which is not valid sourcemap json...)
I didn't debug deeply why those files sometimes also 404 (since 404s are ignored during coverage) but it's probably a proximate cause.
A workaround/fix is to realize that sourcemap: true is not a valid option and instead you should use sourcemap: inline which as far as I can tell works correctly. I noticed in intellisense that false and 'inline' are the only two accepted value for that option even though the online docs just say it's a boolean flag...
One warning: even though the sourcemap option changes these external packages, the cache is not invalidated and thus you won't see any change if you don't also run snowpack build --reload which clears the cache. I plan to open another issue for that later.

It seems like when the lateset sourcemap changes were made it was expected that snowpack would treat true as inline which is what happens during build but for local install of packages this wasn't changed:
https://github.com/snowpackjs/snowpack/blob/96ecac36439034d61d56ba2c18f004567a6cea8b/snowpack/src/sources/local.ts#L575
If I change that line to end with && 'inline' then things work okay (though it causes some of my tests to fail...). I can also change it to false which causes no harm as far as I can tell. (though there was at least one person trying to get sourcemaps to work there: https://github.com/snowpackjs/snowpack/discussions/3280)
For consistency, it seems that we should use && 'inline' everywhere or throw an error if people pass true as an option.
I think long term though there's no reason why URL based sourcemaps shouldn't work if we fix the issues in dev.ts I mentioned above.


Mark promo domains as such in WHMCS

WHMCS version 7+ supports marking domains as sale, new or hot. The addon module should automatically set this category when a domain is on sale.

Users should be able to choose which category to set
Users should be able to choose whether the category should be overwritten if a domain already has another category set

Closed by https://github.com/ducohosting/whmcs-enom-updater/commit/ad5407f7b4acb17ca2ced68fa41bd5a5bf410f0d


CB-10017: Restored broken image in amazon fireos docs

This restores a broken image link that was deleted as part of f90b9d66056349aa33480675f013ae9269823d8d. Clearly, this is a big problem with how we handle images. Images need to be pinned with versions, otherwise if an image is deleted in master then the link will be broken in all of the past docs (hopefully we can come up with a smart way of handling this that does not require us to have 50 copies of every image). We should probably do a sweep to see if there are any other missing images in the past docs. Also, the linked commit makes it seem like this image isn't currently correct for Amazon fireos.

Maybe we could include a test script to find broken images as part of the deployment/release process?

@dblotsky please review

LGTM. I'll create a JIRA for the test script so that we can address it in the future.


CI: use travis_retry to deal with network timeouts

Once in a while, one or more jobs fail on TravisCI because downloading this or that package times out.
This PR follows the suggestion in http://docs.travis-ci.com/user/build-timeouts/ and http://docs.travis-ci.com/user/build-timeouts/ and tries to work around these intermittent network issues via travis_retry.
Note that I'm only retrying pip installs only because I do not remember any problems with either OS-level installs or gmpy2 dependencies, if my memory serves.

LGTM.

That sounds right. Should take care of some of the timeouts. This plus the other PR on splitting test('full') hopefully takes care of all of them.

Merged. Let's see if the timeout go away now.


Fail to send SMS (SmsManager problem)

Android-9, Samsung Galaxy S9+
Error thrown while sending SMSes (foreground).
The reason: file SmsController.kt, the call
val smsManager = getSystemService(context, SmsManager::class.java)
returns null.
I've replaced it (locally) by
SmsManager.getDefault()
and that works on my devices.

Same here smsManager works perfectly on android 12 13  but not working on android 11
And also i found that the plugin is no longer maintained
Check their docs

The answer is from https://github.com/shounakmulay/Telephony/issues/149
above link solved my problem

try this solution
https://github.com/shounakmulay/Telephony/issues/149#issuecomment-1212695720
hope this help :)


[7.x] Adding "between" clauses for BelongsToMany pivot columns

Pretty short and simple. This adds the ability to add 'where between' query clauses to pivot columns.
More or less syntactic sugar, but it allows to more consistency between the normal "where" clauses and the "wherePivot" methods.

Got all of those changes implemented. Let me know how it looks!


linux-raspberrypi=4.19.80 bcm2835-bootfiles=20191021

Upgrade the kernel to latest with corresponding firmware.

This VC4 firmware is compatible with network boot described here:
https://github.com/raspberrypi/rpi-eeprom/blob/master/firmware/raspberry_pi4_network_boot_beta.md

Signed-off-by: Martin Jansa<EMAIL_ADDRESS>

Merged. Thanks @shr-project


URL's ending in name.id not handled correctly

Description
People with ID's name.id versus name.id.blockstack result in invalid URL's that give a 502 error
example: https://app.sigle.io/friedger.id
Is it that the ".id" needs to be URL encoded?
Screenshots
https://imgur.com/uMjoJZw.png
Device
any

now not sure if it's related to domains ending in .id because right now this URL also is not showing up >> https://app.sigle.io/friedger.id/UF470tRdy3BtSs46l7axq
https://imgur.com/Ti5kPGq.png

I have updated my postes because they contained cover image data from older
versions. Should be working now.
BBaker<EMAIL_ADDRESS>schrieb am Sa., 8. Feb. 2020, 11:30:

now not sure if it's related to domains ending in .id because right now
this URL also is not showing up >>
https://app.sigle.io/friedger.id/UF470tRdy3BtSs46l7axq
https://imgur.com/Ti5kPGq.png
I was logged in at the time. When logged out this URL worked fine.
Yesterday @friedger https://github.com/friedger told me the same thing
happened to him - wouldn't work until he logged out and back in.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/pradel/sigle/issues/85?email_source=notifications&email_token=AALBYWLF3YQIYGGOZRED3JLRB2CTPA5CNFSM4KRWDZ5KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOELFOWBA#issuecomment-583723780,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AALBYWNBNEXUQPKPPOVBJYTRB2CTPANCNFSM4KRWDZ5A
.

Seems to be working now for my blog page as well. What was the fix? Sigle changed something?

Closing since it's resolved now :)


can you implement uploading more than one file at once?

I tried implementing it myself but i am bad at coding

Look at this branch for multu upload.

Okay, thanks!


Most nodejs stacks in the community registry are not working

/kind bug

Which area this bug is related to?

/area ci
/area registry
Bug Summary
Describe the bug:
The devfile/registry CI has started showing errors for the following nodejs stacks:
 FAILURE: FAILED TESTS:  nodejs-angular nodejs-nextjs nodejs-nuxtjs nodejs-react nodejs-vue

nodejs-react nodejs-angular nodejs-vue all build and and deploy fine, but they cannot be accessed in a browser
 Checking if http://http-app-nodejs-angular.apps.ci-op-sb5v5i40-3f3af.origin-ci-int-aws.dev.rhcloud.com is returning HTTP 200
+ echo 'HTTP/1.1 403 Forbidden
Server: nginx/1.21.3
Date: Mon, 01 Nov 2021 18:18:00 GMT
Content-Type: text/html
Content-Length: 153
Set-Cookie: dc3ea513abad515485ed16a0902734e2=50f96e239a6e88a62c55890aff59cbcd; path=/; HttpOnly

<title>403 Forbidden</title>

403 Forbidden

nginx/1.21.3

nodejs-nextjs and nodejs-nuxtjs fail during odo push
 Error: error:0308010C:digital envelope routines::unsupported
    at new Hash (node:internal/crypto/hash:67:19)
    at Object.createHash (node:crypto:130:10)
    at module.exports (/project/node_modules/webpack/lib/util/createHash.js:135:53)
    at NormalModule._initBuildHash (/project/node_modules/webpack/lib/NormalModule.js:417:16)
    at handleParseError (/project/node_modules/webpack/lib/NormalModule.js:471:10)
    at /project/node_modules/webpack/lib/NormalModule.js:503:5
    at /project/node_modules/webpack/lib/NormalModule.js:358:12
    at /project/node_modules/loader-runner/lib/LoaderRunner.js:373:3
    at iterateNormalLoaders (/project/node_modules/loader-runner/lib/LoaderRunner.js:214:10)
    at Array.<anonymous> (/project/node_modules/loader-runner/lib/LoaderRunner.js:205:4)
    at Storage.finished (/project/node_modules/enhanced-resolve/lib/CachedInputFileSystem.js:55:16)
    at /project/node_modules/enhanced-resolve/lib/CachedInputFileSystem.js:91:9
    at /project/node_modules/graceful-fs/graceful-fs.js:123:16
    at FSReqCallback.readFileAfterClose [as oncomplete] (node:internal/fs/read_file_context:68:3) {
  opensslErrorStack: [ 'error:03000086:digital envelope routines::initialization error' ],
  library: 'digital envelope routines',
  reason: 'unsupported',
  code: 'ERR_OSSL_EVP_UNSUPPORTED'
}

To Reproduce:
See https://github.com/devfile/registry/runs/4070795791?check_suite_focus=true
Or https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/devfile_registry/79/pull-ci-devfile-registry-main-v4.7-registry-test/1455085083315671040
Or do:

odo create nodejs-nextjs --starter nodejs-nextjs-starter
odo url create
odo push

Expected behavior
The tests do not fail.

I think there's two separate issues at hand here:

Some issue with the nginxinc/nginx-unprivileged:alpine container used in nodejs-angular, nodejs-react, and nodejs-vue.

What's weird is that the image hasn't been updated in 24 days, so I don't think it's an issue with the image itself

Some other issue affecting nextjs & nuxtjs stacks


Rename local variable catalogID to catalogId

We use camel case throughout the application and I keep seeing this gem show up in different places in chaise. This affects viewer, recordedit, recordset, and the common folder.

Is this the time for you to do this for record2?

This relies on changing the parser in the common module which each app uses. To fix this, we would need it to be done for all apps at once instead of on a per app basis.

I am closing this issue with wishlist. We can reopen this later if needed.


Adding Hangman Game

How would you like to enhance the existing project.
Description: Enhance the existing project by adding a Hangman game feature. Hangman is a popular word-guessing game where players attempt to guess a hidden word by suggesting letters within a certain number of attempts. This addition will provide an engaging and interactive game experience for users.
By adding the Hangman game feature, the project will become more interactive and entertaining for users, offering them an additional game to enjoy alongside the existing features.
Describe breifly how would you implement the same.
Create a Hangman game using HTML, CSS, and JavaScript, you can follow these steps:

Game Setup: Define an array of words from which the game will randomly select a word to be guessed. Each word should be associated with a hint or category.

User Interface: Design the Hangman game interface using HTML and CSS. Create placeholders for the letters of the word to be guessed, a visual representation of the hangman's gallows, and buttons for the player to select letters.

Game Logic: Implement the game logic using JavaScript. Define functions to select a random word, display the placeholders for the letters, handle letter button clicks, and update the game state.

Letter Selection: Allow the player to select letters by clicking on the corresponding buttons. Validate the selected letter, checking if it is present in the word to be guessed and not previously selected.

Game State: Track the state of the game, including the number of incorrect guesses, the letters already guessed, and the progress of the word being revealed.

Hangman Drawing: Implement the visual representation of the hangman's gallows using CSS. Add CSS classes dynamically based on the number of incorrect guesses to draw the different parts of the hangman as the game progresses.

Win/Loss Conditions: Determine the win and loss conditions. Check if the player has correctly guessed the word by filling in all the letters before reaching the maximum number of incorrect guesses. Display appropriate messages to the player indicating whether they have won or lost the game.

Game Restart: Offer an option to restart the game after a win or loss. Reset the game state and allow the player to play again with a new word.

Throughout the implementation, add suitable animations, transitions, and styling to enhance the user experience. Handle edge cases, such as validating user input, preventing duplicate letter selections, and managing the game state correctly.
By following these steps, you can create an interactive and enjoyable Hangman game using HTML, CSS, and JavaScript.
Are you contributing for a program?
GSSoC23
Code of Conduct

[X] I follow CONTRIBUTING GUIDELINE of this project.

I would like to help tis issue so do assign me this issue under GSSoC'23.


Something Else?

I'm curious, wouldn't the pipe operator solve this?
function doSomething(a) {
  let b = dbg!(a + costlyOperation()) * 2;
  // ...
}
// with pipe
const debug = (value) => {console.log(value); return value;}
function doSomething(a) {
  let b = ((a + costlyOperation()) |> debug) * 2;
  // ...
}

I know this is an early proposal. I just want to understand what it intends to accomplish.
Is it just introducing a debug function that can be easily written on one line?
Or more complex debugging features that are not currently available?

part of the motivation here is an api that is available anywhere that you're writing js.

Does a one-liner function require going through the tc39 process, and adding more baggage to the language?
Anyways, thanks for the answer.

Of coz we can use pipeline op, but unfortunately, pipeline op require u to write many parens.
The old bind operator proposal need less parens:
function doSomething(a) {
  let b = (a + costlyOperation())::debug() * 2;
  // ...
}

The main difference of dbg!(v) and v::dbg() is the order, I can see each have their pros and cons. Anyway, I like the idea of having a debug api!


Proposing example using QPid instead of RabbitMQ

Hi,
RabbitMQ is nice but is an external process, which needs to be launched separately which for some kind of testing can be a waste of time.  Using the base example you provided, I've reworked it a bit to propose a way to use Apache QPId instead. Just run Application and ApplicationTest with "qpid" profile and both should workk, without having to start RabbitMQ externally.
If you feel this example doesn't "belong here", let me know where to send my PR instead.

Nice idea. We might wait until Spring Boot supports QPid better and then just use that. These guides are really supposed to have the minimum amount of code to get something working, so supporting Rabbit and QPid together in the same project is probably a non-goal.
Some advice for cleaning up the pull request (and for future patches):

Please don't use Lombok.
You forgot to edit the Gradle build (which is why the CI failed).
Squash your commits down to a single change.

Thanks for the code, anyway! We can definitely try and incorporate it somewhere, now we know it works.

sorry, I still am a 100% Maven developer ;-) and Lombok has also become an habit for me...
The way I see it (in my current project for instance), I would want to support RabbitMQ in prod, but run my low level integration tests on QPid (the same way people use H2 instead of "real" DB) for faster feedback.
I get what these guides are for, and that's why I was saying that maybe it doesn't belong here.
I'll clean-up my PR and push again, so at least it's green .

OK, now build is green, my PR contains a single commit, and there's no Lombok dependency anymore.


ShirukaWorldBorder.java:143:...

The puzzle 1-02f99adc from #1 has to be resolved:
https://github.com/shiruka/shiruka/blob/2d4fd18edd89ca67db88ccfe8c4a55ac9bb4690f/src/main/java/io/github/shiruka/shiruka/world/options/ShirukaWorldBorder.java#L143-L143
The puzzle was created by @portlek on 27-Dec-20.
Estimate: 60 minutes,  role: DEV.
If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.

The puzzle 1-02f99adc has disappeared from the source code, that's why I closed this issue.

The puzzle 1-02f99adc has disappeared from the source code, that's why I closed this issue.


 Don't review yet.

I'd be quite shocked if this made a difference given that evalBuiltinApp is marked as INLINE :thinking:

Which does make sense.  Weird! How come it's faster than the baseline, but slower than #4581? Maybe constructing a BuiltinRuntime and then forcing it immediately is generally better than not constructing it when it's not needed, but delaying the forcing otherwise? Gonna experiment more.
 Not sure if noise or not, but in any case worse than the competitor (#4581) giving us -6.3%. Given that the competitor is also more explicit and safer, I'm going to go with it.

Ah, yeah, it's ab absolute mystery for me why #4581 is faster given that this one seems to have fewer indirections and I'm not able to spot anything else.


[flake8-type-checking] Fix helper function which surrounds annotations in quotes

[WIP - I want to exercise with some tests to see if there are other expressions not handled in this visitor while I'm at it.]
This PR adds corrected handling of  list expressions to the Visitor implementation of QuotedAnnotator in flake8_type_checking::helpers.
Closes #14368

Notice that the snapshot I updated was for a test that already existed (I didn't change the fixture). It seems to me like the previous behavior was incorrect and the new behavior is correct - but maybe I'm missing something?


Extendable cleanup.

Proposed Semver Increment Bump: [MAJOR/MINOR/PATCH]
N/a
Changes Proposed in this Pull Request (List new items in CHANGELOG.MD)

Minimized processing (running the same function multiple times).

(If Applicable) What Issue does it fix?
Fixes... performance.

Already in #255


_ready() is called twice when instancing a tool in the editor

Tested on Godot 2.1 rc1 windows 10 64 bits
I make an editor plugin in which I instantiate a scene that contains a control for a container in the editor.
However, initialization fails compeletely because _ready() is called twice, and I cannot rely on _enter_tree().
Repro:
PluginReadyTwice.zip
This project contains a dummy plugin that instances a custom control. In _ready(), this control prints a message.
Open the project, see the message print twice in the console.
Note: _ready() is called once normally for games.
Note 2: I also don't understand why the doc recommends using _enter_tree() for initialization, because it makes onready() and get_node() useless.
Note 3: unrelated, but I get countless errors in the console when developping my tool since rc1 is out. They don't seem harmful, but I didn't managed to get them 100% reproductible in a simple project yet :s

I have a similar issue which is likely a duplicate: _init and _ready are also called twice for AutoLoads (regardless of their Singleton status).

I just hit the ready_ twice issue myself.  Here's a minimal ready_x2.tar.gz project to the effect.  It clearly shows the single call (when brought in from main) versus the double call (when brought in from an autoload).  It also shows the main script and autoload themselves only get _ready once but the object instantiated is getting a differing number of _ready calls.  In my case I'm attaching from an external script but I still think it's a duplicate of the above issue.
PS: As a workaround I define a member var as a flag to enforce a one-off initialization:
var init=false
func _ready():
    if !init:
        init=true
        # only runs once

This thing is quite annoying. I dug a little but have no idea of what is causing it. I noticed that _ready() is called twice on plugins but only when the editor starts, not when disabling/re-enabling it. So I guess there's something on in the initialization that propagates the NOTIFICATION_READY one extra time.

Its probably related to your window being moved arond the docks? I don't
think it's a bug in itself
On Sep 23, 2016 13:53, "George Marques"<EMAIL_ADDRESS>wrote:

This thing is quite annoying. I dug a little but have no idea of what is
causing it. I noticed that _ready() is called twice on plugins but only
when the editor starts, not when disabling/re-enabling it. So I guess
there's something on in the initialization that propagates the
NOTIFICATION_READY one extra time.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/godotengine/godot/issues/6005#issuecomment-249244811,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AF-Z26BJzusgiYe0uGjNy1_e7zFV3bb2ks5qtAQFgaJpZM4JaKTE
.

Maybe for Godot 3.0 we could make _ready only run once, and add something
else for when reentering
On Sep 23, 2016 14:14, "Juan Linietsky"<EMAIL_ADDRESS>wrote:

Its probably related to your window being moved arond the docks? I don't
think it's a bug in itself
On Sep 23, 2016 13:53, "George Marques"<EMAIL_ADDRESS>wrote:

This thing is quite annoying. I dug a little but have no idea of what is
causing it. I noticed that _ready() is called twice on plugins but only
when the editor starts, not when disabling/re-enabling it. So I guess
there's something on in the initialization that propagates the
NOTIFICATION_READY one extra time.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/godotengine/godot/issues/6005#issuecomment-249244811,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AF-Z26BJzusgiYe0uGjNy1_e7zFV3bb2ks5qtAQFgaJpZM4JaKTE
.

Or just leave enter tree for that..
On Sep 23, 2016 14:15, "Juan Linietsky"<EMAIL_ADDRESS>wrote:

Maybe for Godot 3.0 we could make _ready only run once, and add something
else for when reentering
On Sep 23, 2016 14:14, "Juan Linietsky"<EMAIL_ADDRESS>wrote:

Its probably related to your window being moved arond the docks? I don't
think it's a bug in itself
On Sep 23, 2016 13:53, "George Marques"<EMAIL_ADDRESS>wrote:

This thing is quite annoying. I dug a little but have no idea of what is
causing it. I noticed that _ready() is called twice on plugins but only
when the editor starts, not when disabling/re-enabling it. So I guess
there's something on in the initialization that propagates the
NOTIFICATION_READY one extra time.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/godotengine/godot/issues/6005#issuecomment-249244811,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AF-Z26BJzusgiYe0uGjNy1_e7zFV3bb2ks5qtAQFgaJpZM4JaKTE
.

Its probably related to your window being moved arond the docks? I don't
think it's a bug in itself

No, it runs _ready() twice just by opening the editor. It's not even a dock plugin, it happens on import and main screen plugins too.
In a game you have control. If you never reparent anything, you can be sure _ready() is only called once. In the editor you have to be a bit more careful, but you should have control of the scenes you instance and add to the tree manually.
However, the problem here is that _ready() is a actually called twice, it's not being reparented. In my plugin I create a new instance every time and add it to the tree once, so I shouldn't have two calls for _ready(). Based on the prints, is the same instance. Again: this only happens when starting the editor, not when re-enabling the plugin.
The problem with singletons is similar (likely the same cause). The effect is worse though: you have to always make initialization guards for a singleton, which by definition should be added to tree only once.

I think I found problem.
I happens even not editor plugin.
main.tscn
extends Control
func _enter_tree():
	var sp = load("res://Sprite.tscn").instance()
	add_child(sp)

Sprite.tscn
extends Sprite
func _ready():
	print("sprite ready")

I can see sprite ready twice on output when run.
to work around this, use call_deferred("add_child",sp) instead.
EditorPlugin example also add a scene in _enter_tree
So, I made call_deffered instead of just call adding it.
func _enter_tree():
    dock = preload("res://addons/my_custom_dock/my_dock.tscn").instance()
    call_deffered("add_control_to_dock", DOCK_SLOT_LEFT_UL, dock)

AND PROBLEM IS GONE!

I think, the REAL problem is _ready is called twice when added in _enter_tree.

@volzhs Nice bug summary, though I hope it isn't a too paranormal issue... :+1:
So, I made a quick check for when _ready is emitted -- seems like it is only here:
scene/main/node.cpp:175
void Node::_propagate_ready() {

	data.blocked++;
	for (int i=0;i<data.children.size();i++) {

		data.children[i]->_propagate_ready();
	}
	data.blocked--;
	notification(NOTIFICATION_READY); // <---- here

}

Then... debugging everything on a sheet of "paper" produces this:

Node
"event"

/root/editor
... → add_child(plugin)

/root/editor/plugin
_set_tree → _propagate_enter_tree

/root/editor/plugin
script (_enter_tree) → add_child(my_node)

/root/editor/plugin/my_node
_set_tree → _propagate_enter_tree & _propagate_ready

/root/editor/plugin/my_node
_propagate_ready → script(_ready) :exclamation:

/root/editor/plugin
_propagate_enter_tree (Continuation) → children*_propagate_enter_tree

/root/editor/plugin
_set_tree (Continuation)→ _propagate_ready → children*_propagate_ready

/root/editor/plugin/my_node
parent → _propagate_ready → script(_ready) :exclamation:

Or, in short, when the child node is added, it is immediately _ready-ed, then all the children of the node that added it are readied...
To fix this, one of the two "paths" which call _ready should be stopped somehow. I guess the simplest way to do this (and remain mostly backwards-compatible) would be to not call children._ready on children added in parent._enter_tree, but wait for parent._ready to propagate it.
To do this, we might add data.ready = false, which we set to true when we start propagating _ready and reset it when we exit the tree (until 3.0). Then, we would check/pass the parent's flag in _set_tree, and not call _propagate_ready in this case.
Hopefully, I was clear enough... :smiley:

Issue persist v3.4.1.rc1.official [7b0801c7f]

Issue persist v3.4.1.rc1.official [7b0801c]

This may be related to https://github.com/godotengine/godot/issues/47731 or https://github.com/godotengine/godot/issues/31002, which means it would be fixed in master already.


[Improvement]: Add "Show only my policies" switch and show list of all policies if not set

What happened?

Currently if a new user opens policies view he sees lonely "No policies for this wallet found - click here ... to apply for a new policy". Better to show all policies and give option to sort out those he owns.
What operating system are you seeing the problem on?
Mac OS, Other (please mention in the description)
What browsers are you seeing the problem on?
Safari
What wallet extension are you using?
Metamask
Rules

[X] I agree to follow this project's rules

No, we will only show policies belonging to the current connected wallet. Other (not his own) policies are of no interest to one single user checking the list of this policies.


Portals only work from Nether/End not from Overworld

Information

Server Version: Paper 1.16.5

Full output of /mv version -p: Lastest Dev build

Server log: https://gist.github.com/LordGrafnus/8d7a44591a146c49c570e131fd56f76a

Help request
Problem
I can use a Netherportal in the Nether to get back to the overworld. But I cannot use a Netherportal in the overworld to get into the Nether. The End portals do not work as well.
What I have tried
Linking the world with one another.
Only linking in one direction.

Please follow the issue template. Server logs, and output of /mv version-p is missing.

There you go updated the request

You need to link the portals both ways, so Utopia -> Destopia in your case. As for end portals, I don't see any linking done so link them if you want them to work. You may need to set respawn world if you don't respawn  at overworld from end/nether, see https://github.com/Multiverse/Multiverse-Core/issues/2160

Yeah I know. I removed the link for test purpose. It still does not work if they are linked. As I already stated above

I linked the world again, tried it, still not working. I edited the request again. New Startup log now with the try to use a portal.

Tested it on latest version of papermc and MV installed, cannot reproduce, netherportals worlds just fine with linked both way. So I can only see an issue with your setup.

Ensure that allow-nether is true is server.properties
The default nether is loaded.
Link them correctly (2 ways not just one) as I said.
Test with only mv installed, plugin conflict could have cause it.
You are using some 5.0.0 UNKNOWN build, no one released such a built, not even for beta testing yet so...


DataLifecycle: CreateBucket Lifecycle always keeping the latest and removing other rules

Is this a BUG REPORT or FEATURE REQUEST?:

Uncomment only one, leave it on its own line:
/kind bug

What happened:

Create Bucket Life Cycle Config rule
Create 2nd rule
Only second one exists.. (Latest)
What you expected to happen:
Should maintain all rules created
How to reproduce it (as minimally and precisely as possible):

Anything else we need to know?:
Environment:

Gelato(release/branch) version:
OS (e.g. from /etc/os-release):
Kernel (e.g. uname -a):
Install tools:
Others:

@satya-gorli Which version you used to do this test? I used the latest code of development branch to test, it works fine, please update the code and test. Thank you.

@satya-gorli I have checked in the updated code for PUT bucket lifecycle as a part of "https://github.com/opensds/multi-cloud/pull/132" (Restore and HEAD API for object). And I have tested it also, need to do some dashboard changes, which @jimccfun  will take care.

@satya-gorli this issue is not connected to restore , and use the latest code of development branch to test, it works fine.

I am raising a new PR for the fix and detach it from restore PR. Then we can track that PR separately

This issue is fixed as a part of PR #146


Document coding conventions/guidelines

Describe coding conventions used in this codebase.
This will include reference to:

the airbnb ESLint rules (and local override rules)
directory and file naming conventions
algo más?

This will probably be covered by #1.


wd_demo.au3 _RunDemo_Update() should back to main loop on error

Pull request
Proposed changes
_RunDemo_Update() should back to main loop on error
Currently I notice some issue with updating chromedriver.exe and testing with wd_demo.au3 the scirpts goes over the issue (even with forced update) instead ends on non updated driver
Checklist

[x] I have read and noticed the CODE OF CONDUCT document
[x] I have read and noticed the CONTRIBUTING document
[ ] I have added necessary documentation or screenshots (if appropriate)

Types of changes
Please check x the type of change your PR introduces:

[x] Bugfix (change which fixes an issue)
[ ] Feature (change which adds functionality)
[ ] Code style update (formatting, renaming)
[ ] Refactoring (functional, structural)
[ ] Documentation content changes
[ ] Other (please describe)

What is the current behavior?
on dirver update errors the program still is trying to go ahead
What is the new behavior?
on dirver update errors the program back to main loop
Influences and relationship to other functionality
none
Additional context
none
System under test
Wersja 121.0.6167.185 (Oficjalna wersja) (64-bitowa)

btw.
Currently I notice some issue with updating chromedriver.exe
this was related to the fact that an update was released for Chrome but not for the corresponding web driver.
After a few hours, the corresponding webdriver was also released.


Updated request package version.

Good day,
I have a project using node-sass and Github reported a security issue in the hoek library that is related to the request library.  So I created this quick pull request to hopefully allow node-sass to use the latest release of request.
All the tests passed with my testing, but if there's anything else I need to do please let me know.
Thanks,
Adam

Please search closed issues before a new one


Fix download archiver of a commit

When reviewing #20925, found the bug that when you download archiver in a special commit UI, it will still download from default branch.

please backport :)


Django 4.2 compatible release

A PR has already been opened by a new contributor (yay!).
@rbm, would it be possible to put together a new release?

@james-certn -- Thanks for filing the issue! And thanks @hernantz for the PR.
I'm not at Hearsay (the company behind django-livefield) these days and I don't think I can merge PRs or release to PyPI for this package any more. Let me reach out to some folks on the team there.

@james-certn @ibiternas will follow up about this (or have someone from the python infra team at Hearsay follow up) -- please allow a bit of time since I'm pretty sure it's a busy time over there, and 4.2 isn't officially out yet.

@james-certn @rbm appreciate your help moving this forward!
@rbm this also adds support for 4.1 which has been released already

Hey friends (@hernantz @ibiternas, @rbm) - just noting that Django 4.2 is released an now generally available to the public. Do we think we can nail down a timeline for getting a compatible release of django-livefields out? Thanks!
See the PR for it. 🙏

@james-certn @hernantz
Thank you for the contributions. Apologies for losing track of these issues.
We have released 4.0.0 which offers Django 4.2 and Python 3.11 support. In the future release, we will extend this to Django 5 and Python 3.12 to keep this repo up to date.


Fix image URLs

Summary
When browsing the docs website, images under the topic Snapshot Testing were returning a 404. The paths to these images were incorrect. Instead of loading from /website/static/img they should be loaded from /img
Test plan
N/A

Works on the netlify preview, thanks!
You can move the changelog entry to the Chore section, fixes and features usually only contain changes to Jest itself.
I'll update the contributing guide with some info on adding changelog entries.


Add missing @Flag initializer in example

The documentation as presented doesn't compile. An initializer is required for a boolean flag.
rdar://132579907

Checklist

[x] I've added at least one test that validates that my change is working, if appropriate
[x] I've followed the code style of the rest of the project
[x] I've read the Contribution Guidelines
[x] I've updated the documentation if necessary

I can't remember if omitting the initial value is intended to work, @natecook1000 do you recall?

@rauhul it definitely does not work. Leaving out the initial value makes it assume it's an Int, and I get this error:
error: property type 'Bool' does not match 'wrappedValue' type 'Int'
    var verbose: Bool
        ^~~~~~~

Right! I think you can only omit the default false value when you specify an inversion (like a --foo/--no-foo pair), which makes specifying one of those values required.

@swift-ci Please test


replace django-tinymce by mezzanine code

Currently require django-tinymce
however, also provided by mezzanine somehow. Perhaps integrate?

Done.


Log during tests

What was wrong?
Logs were not being initialized/generated during test runs. It's so much nicer to debug a failing test when the logs are shown on failure.
Also, bonus: disable state network by default. This was discussed on a call. Soon, history will be properly supported and state won't, so don't launch state by default.
How was it fixed?
Add the test-log crate to use an easy attribute that initializes logging during tests.
Sometimes, when there are sibling rstest attributes, or a tokio::test, we need to manually wrap the macro.
To-Do

[ ] Add entry to the release notes (may forgo for trivial changes)
[ ] Clean up commit history

I don't really know who to send this to, so I just went with the github recommendation 🤷🏻♂

One thing that I did notice in the CI test runs is that there was some printout under test utp::packets::tests::test_reversible ... ok that I do not see when I run the test suite locally. I'm not sure why this is, but we should make sure that we don't see log output on successful tests.

Yup, I'm guessing you were not running tests locally with -- --nocapture. What you're seeing is actually not logging, it's some other stdout output. But it did highlight another bug which is that RUST_LOG has to be set for the logs to show up during testing. I'll add that, and turn off --nocapture in CI, so the output isn't overwhelming.

I assume that we validated that this does indeed work for failed tests whose output is not otherwise captured.

Yes, I did run tests locally to see the log output on failed tests. But I'll also run a test in CI to confirm there, with the above change.

Well, I figured everything out except for tests/self_peertest.rs. If I turn off --nocapture and use test_log, then it doesn't show anything at all on failure. Seems better to just show too much for now, until we figure out what's going on there. But it seems like a distraction to keep digging right now. I'll write up what I know in an issue.

Happy to take another look whenever it's ready.

Ok, ready for your eyes again, thanks!


Sync Dockerfile and ci-operator config

The ci-operator config allows for a from-repository build-root image definition.  A follow up PR in openshift/release will enable these changes and then we'll only have to update a single location if/when switching Golang versions in the future.

/assign @smarterclayton

The openshift/release followup PR: https://github.com/openshift/release/pull/20287

/lgtm


Compilation warning for AFNetworking 3.0

I add AFNetworking 3.0 into my XCode project which supports iOS 7.1+. I configured it support iOS 7.0 in the podfile.
I have tried to compile it in XCode 7.3 and 7.2.1. I always get such warnings. Even I have tried to make pod install and pod update.
Shall I omit the warnings? Does it matter for release? Thanks!
These are a part of the warnings.
ld: warning: object file (/Users/yan/Library/Developer/Xcode/DerivedData/MyApp-dsvmrgrlnpncfwhgxmgvccrxbjpu/Build/Products/Debug-iphonesimulator/libAFNetworking.a(AFAutoPurgingImageCache.o)) was built for newer iOS version (8.0) than being linked (7.1)
ld: warning: object file (/Users/yan/Library/Developer/Xcode/DerivedData/MyApp-dsvmrgrlnpncfwhgxmgvccrxbjpu/Build/Products/Debug-iphonesimulator/libAFNetworking.a(AFImageDownloader.o)) was built for newer iOS version (8.0) than being linked (7.1)
ld: warning: object file (/Users/yan/Library/Developer/Xcode/DerivedData/MyApp-dsvmrgrlnpncfwhgxmgvccrxbjpu/Build/Products/Debug-iphonesimulator/libAFNetworking.a(AFNetworkActivityIndicatorManager.o)) was built for newer iOS version (8.0) than being linked (7.1)
ld: warning: object file (/Users/yan/Library/Developer/Xcode/DerivedData/MyApp-dsvmrgrlnpncfwhgxmgvccrxbjpu/Build/Products/Debug-iphonesimulator/libAFNetworking.a(AFURLResponseSerialization.o)) was built for newer iOS version (8.0) than being linked (7.1)

This is probably best suited for stackoverflow. We use Github to track bugs and feature requests.
:beers:

From our Contribution Guidelines
Asking Questions
We don’t use GitHub as a support forum. For any usage questions that are not specific to the project itself, please ask on Stack Overflow instead. By doing so, you’ll be more likely to quickly solve your problem, and you’ll allow anyone else with the same question to find the answer. This also allows maintainers to focus on improving the project for others.


UI enhancement to add and update workflow Metadata

Summary
UI can have UX based form to add and edit metadata fields (namespace, labels and annotation) in workflow submission page. This will help user to edit existing label/annotation and update the namespace. This support mainly helps the user to not mesh up the YAML format
What change you think needs making.

I think fixed in v3.


When I update the folder name from bagisto to new name, the logo image doesn't appear, why?

please help..
thank you

Can you please provide us more info & use the template instead when you post a issue here?

Can you please provide us more info & use the template instead when you post a issue here?

already repaired, thank you


read flow statistics is not collected for raw kv

read flow is only collected in MvccReader and currently RawKv is out of this mechanism

Collected in read pool based implementation. Closing.


Add cities visited labels in friend's profile

Steps to go to friend's profile

Go to My Friends from the navigation drawer
Click on any friend

Expected behaviour
Below the friend's profile photo, show the labels of the cities visited by the user.
labels should look something like GitHub label only (with city name). Assign any random color to the label.

Endpoint to use
get-trip-cities/<int:user_id>
https://github.com/project-travel-mate/server/issues/104

Can I work on this??

Okay cool. I'll work on this issue then 👍

@Swati4star How do I add friends?? I am trying to add friend to a trip and it shows "Please Select a valid friend to add" snackbar

start type an email id<EMAIL_ADDRESS>name suggestions will start showing up in the autocomplete drop down.
Select the name from there.
Then, select add friend

@Swati4star This is the url I am hitting to get the trips data for a user: https://project-travel-mate.herokuapp.com/api/get-trip-cities/552 It is returning an html response. Is there something that I am missing??

HI @nikhilbansal97 ! Really sorry, I didnt know that url endpoint wad changed.
Try out this one https://project-travel-mate.herokuapp.com/api/get-visited-city/1

@Swati4star Thanks that worked. I had another doubt. I have completed the implementation and was about to raise a PR but was running tests:

./gradlew checkstyle
./gradlew assembleDebug assembleRelease
For both the tests, it shows an NullPointerException but not in any of the project files.

We have included checkstyle in the Android build process only. So, the above is not required.
You can create a PR :)
...and travis will check for failure
@nikhilbansal97


Autoscroll

When flicking through images with the swipe, if you click the back button the page's scroll is all the way back at the top where you first clicked an image.
The page should scroll so that it's always level with the image you're viewing.

Settings — Interface — Scroll thread when scrolling gallery

Ah, I didn't see that. It should really be enabled by default.


Kafka-manager requires manual config to find cluster

Running kafka-manager on an existing kafka cluster using the following command:
kafka-manager/bin/kafka-manager -Dconfig.file=../../configs/application.conf
This allows me to access the kafka-manager via web browser but no clusters are preconfigured even though I gave the manager the ZK host:port in the cfg file.  I have to manually "Add Cluster" from the web interface, only providing a custom name and "localhost:2181" under ZK host.
I need this automated.  I'm surprised this isn't done already, I already provide it the zkhost:port in the config file (below).  Perhaps it needs a name in order to create the cluster and that's not provided in the config file?
The application.conf is as follows:
play.crypto.secret=${?APPLICATION_SECRET}
play.i18n.langs=["en"]
play.http.requestHandler = "play.http.DefaultHttpRequestHandler"
play.application.loader=loader.KafkaManagerLoader
kafka-manager.zkhosts="localhost:2181"
kafka-manager.zkhosts=${?ZK_HOSTS}
pinned-dispatcher.type="PinnedDispatcher"
pinned-dispatcher.executor="thread-pool-executor"
application.features=["KMClusterManagerFeature","KMTopicManagerFeature","KMPreferredReplicaElectionFeature","KMReassignPartitionsFeature"]
akka {
  loggers = ["akka.event.slf4j.Slf4jLogger"]
  loglevel = "INFO"
}
basicAuthentication.enabled=false
basicAuthentication.username="admin"
basicAuthentication.password="password"
basicAuthentication.realm="Kafka-Manager"```

Hi @etotheipi,
zookeeper configuration is for kafka manager storage only. If you need to add cluster automatically you need to make a HTTP request. Few monthes ago, I wrote a CSD for cloudera manager and, to add  cluster to KM, I used curl :
curl  ${KM_URL} --data "name=${KM_CLUSTER_NAME}&zkHosts=${ZK_QUORUM}&kafkaVersion=${KAFKA_VERSION}" -X POST
I think it's still valid.

Thanks @sheepkiller, that's exactly what I needed.
Note that I needed to use ${KM_URL}/clusters to submit the POST action, but otherwise it was exactly as you said:
curl localhost:9000/clusters --data "name=primarycluster&zkHosts=localhost:2181&kafkaVersion=<IP_ADDRESS>" -X POST

Are the optional tuning parameters implemented in this rest API?
I try to add &clusterManagerThreadPoolSize=4  and &tuning_clusterManagerThreadPoolSize=4,
but they have no effect on the cluster created.

This has stopped working for me with the latest kafka-manager.   The above curl command simply returns HTML of a partially-filled-in form (with the values I specified), but it doesn't actually submit it.  I can confirm that the html suggests that /clusters is the correct action and the field names are still valid.  Not sure why it doesn't just finish the submission, though.

Sorry, I meant to reopen this issue with my last message.

Same here, need an automated way to setup the already existing clusters, here's the output of what I'm getting: POST.out
command I'm executing: curl localhost:9000/clusters --data 'name=Prod2&zkHosts=<IP_ADDRESS>:2181,<IP_ADDRESS>:2181,<IP_ADDRESS>:2181&kafkaVersion=<IP_ADDRESS>' -X POST
Thank you in advance.

curl localhost:9000/clusters --data 'name=Prod2&zkHosts=<IP_ADDRESS>:2181,<IP_ADDRESS>:2181,<IP_ADDRESS>:2181&kafkaVersion=<IP_ADDRESS>' -X POST

Doesn't work for me. I run kafka manager as container on 8080 port. I got respond as html page, where all parameters are selected (name,zkHosts, kafkaVersion), but it is create nothing(

If you do it manually through the web UI you can find out that kafkaVersion needs to be set to: <IP_ADDRESS> (this also seems to work against newer versions of Kafka).
Besides this, some of the default values are wrong, and need to be changed from 1 to 2 (e.g. clusterManagerThreadPoolSize).  After these changes the cluster is added successfully. In the mean time when running fiddler you can capture the correct command parameters.
The following worked out for me:
curl localhost:8082/clusters --data 'name=MyKafkaCluster&zkHosts=zookeeper%3A2181&kafkaVersion=<IP_ADDRESS>&jmxUser=&jmxPass=&tuning.brokerViewUpdatePeriodSeconds=30&tuning.clusterManagerThreadPoolSize=2&tuning.clusterManagerThreadPoolQueueSize=100&tuning.kafkaCommandThreadPoolSize=2&tuning.kafkaCommandThreadPoolQueueSize=100&tuning.logkafkaCommandThreadPoolSize=2&tuning.logkafkaCommandThreadPoolQueueSize=100&tuning.logkafkaUpdatePeriodSeconds=30&tuning.partitionOffsetCacheTimeoutSecs=5&tuning.brokerViewThreadPoolSize=2&tuning.brokerViewThreadPoolQueueSize=1000&tuning.offsetCacheThreadPoolSize=2&tuning.offsetCacheThreadPoolQueueSize=1000&tuning.kafkaAdminClientThreadPoolSize=2&tuning.kafkaAdminClientThreadPoolQueueSize=1000' -X POST

It doesn't help. I got this respond.txt

In conclusion, the trick of cURLing works fine (even though it may seem not to work, since the response is the HTML page of cluster creation).
However, it would be better if it was actually documented in Kafka Manager.
Should this issue track the documentation update?

Just to add to this conversation...
I cam here looking for this exact functionality, and while the examples here did not work, I wanted to post my process here for others to try.

I am running firefox developer edition, but this should work with other browsers as well. Also, I am running kafka-manager inside a docker container, localhost:9000.

Browse to localhost:9000/addCluster
Open the developer tools
select the network tab (may need to select "persist logs")
Complete the form with your desired values, submit
In developer tools, select the network tab
Find the POST call
Right click on the entry and select Copy > Copy cURL (or Copy POST DATA)
Create a new script (I created a .sh script), and paste (or create) the curl command

If this doesn't work the first time, you can redirect the output to an html file. Open the html file in a browser and you can see which form entries failed.
In my scenario:
./create-cluster.sh > results.html
Then I would open results.html in a browser to see which form field was invalid, looking for entries with "This field is required" next to them.

I have the same question, according to the answers above, there is only one way is to execute some commands on a running container.
I solved this problem with a bash-script that is executed after Kafka manager is ready.
You can find full source code here https://gist.github.com/CROSP/0d98ec1d5da389c679025a75260c7599#file-kafka-config-sh
And in my docker-compose.yml file it is defined as follows.
  bootrstrap-config:
    image: ellerbrock/alpine-bash-curl-ssl
    restart: "no"
    environment:
      - KAFKA_MANAGER_HOST=kafka-manager:9000
      - KAFKA_CLUSTERS=zookeeper:2181#BusLux,zookeeper-2:2181#BusLux2
    depends_on:
      - kafka-manager
      - kafka
      - zookeeper
    command: /bin/bash /config.sh
    volumes:
      - "./kafka-config.sh:/config.sh"

You can specify multiple clusters in the following format
<zookeper_host_name>:<zookeper_port>#<cluster_name>,<zookeper_host_name>....
If you need specific options for your cluster you can modify the script or define them in properties file for example and parse while running the script.
Basically this container runs on startup, checks whether a specific cluster is already set up.
This a dirty solution, however in my case it satisfies requirements.

Dear yahoo developers ,
1st rule of KISS: "always use a text file for ALL config"
2nd rule of KISS: "NEVER use a database for config"


Add rackup host option to listen on <IP_ADDRESS> to pass integration test

I have found an issue that fails integration test.
I have fixed it, please check it.
Then I have passed the integration test.
vagrant@precise64:~$ ss -ltn | grep :80
LISTEN     0      128               <IP_ADDRESS>:80                       *:*
vagrant@precise64:~$

:arrow_down:
vagrant@precise64:~$ ss -ltn | grep :80
LISTEN     0      128                       *:80                       *:*
vagrant@precise64:~$

Raason: rackup has been changed to be run on <IP_ADDRESS> by default.
See: rack: Default host to localhost when in development mode.
https://github.com/rack/rack/commit/28b014484a8ac0bbb388e7eaeeef159598ec64fc

[Jenkins] Can one of the admins verify this patch? (say "test this please")


Update Invisor Lite to 3.5.1

Thank you for the contribution. It was merged directly as 6ba2f80e99bb943c05e06f95b9a545aaab242812 to keep commit history cleaner. Your contribution is still credited to you.


no unifi_access_doorbell_start event, UA-G2-Pro, UA-Hub and UDM-Pro

new Issue entry for issue originally described here: https://github.com/imhotep/hass-unifi-access/issues/52#issuecomment-2273313096
When doorbell UA-G2-Pro is rang, no unifi_access_doorbell_start event is seen on the Event Bus, nor is any other event related to the doorbell.
Access and Lock events for the same hardware (UA-G2-Pro, UA-Hub and UDM-Pro) do register properly.
Event Bus was monitored in Home Assistant (running as docker container) via the asterisk (*) mask = monitor all events.
There is no registration of any doorbell_start event while numerous other events from various other devices were registered.
Over 5 minutes of trying, 68 events, of which no doorbell events (rung 4 times).
Happy to provide any logs; please specify!
Kind regards!

@fieldsalad2 can you try the latest release and let me know? If it still doesn't work, can you set the integration in debug mode. Hit the doorbell on/off a few times and share some logs here please?
Reminder this is how you enable debug mode. Add the following to your configuration.yaml
logger:
  default: info
  logs:
    homeassistant.components.unifi_access: debug

@fieldsalad2 closing this. Feel free to re-open if you're still facing issues.

Seems to be fixed in the new release(s); the events are properly registered again.
I tested this by leaving out the hardwired (UA-Hub auxiliary doorbell ring output to KNX) trigger out,
only leaving the unifi_access integration doorbell_pressed event as a trigger to the doorbell ring on Sonos automation,
and it still fires the automation correctly.
I will subsequently refrain from uploading the log as the problem seems to be fixed.
Thank you!


feat: Support waves for parallel builds with github options

Fixes #489
Removed the if-specific code from #377 and rebased on top of the latest main.
With this PR it's possible to have Waves without losing GitHub-specific settings properties.

Ok, @kaizencc, I updated the docs to include the new objects and how to use them.

Ok, @kaizencc, I believe I have made all the requested changes and answered all questions. I'll keep an eye out or any more you might have. Thank you!

Ok, @kaizencc - I think I got all the changes you asked for.

@kaizencc any update on this?

Ok, I once more believe I have all the changes you requested in, or have a good reason not to (and commented to that elsewhere).


Attending the workshop with a Linux machine

Hello,
I only have Linux installed on my laptop. I have been thinking about switching to a dual boot setup for quite a while, so if necessary, I could try to get that set up by Friday.
That being said, the first line after the title of the description of the workshop (https://remi-gau.github.io/matlab_clean_code_workshop/) mentioned GNU Octave, but it isn't mentioned as one of the options under "Requirements". Hence, I'm a bit confused: Is having Octave on my machine sufficient or should I come with an installation of MATLAB?

You should be fine using just Linux + Octave for most things.
It will actually even be easier for certain things: testing things with continuous integration on gitlab and matlab is more complicated than with Octave.

If it helps see #4


Add contributor

@all-contributors please add @LBF38 for code and documentation

@all-contributors please add @LBF38 for code and documentation


PXE boot related service doesn't work on Docker for Windows

Description
When I try running a simple TFTP service on port 69/udp on Docker for Windows, I cannot fetch a file from it.  I really want to be able to connect a laptop to a network, run a Docker container on it, and start PXE booting other computers from the laptop.
Steps to reproduce the issue:
Example 1

Install Docker for Windows Version 1.13.0-rc7-beta37 (9733) on a Windows 10 Pro computer.  The Docker for Windows installer will set up MobyLinuxVM in Hyper-V.
Disable the Windows Firewall.
Create a new example Dockerfile with these contents:

FROM alpine

RUN apk add --no-cache tftp-hpa; \
    wget -P /var/tftpboot http://boot.ipxe.org/undionly.kpxe

EXPOSE 69/udp

ENTRYPOINT ["in.tftpd", "--foreground", "--secure", "/var/tftpboot"]

Build the image by running the following command in Windows Powershell:

docker build -t tftp .

Run the TFTP server with the following command (try with --net=host too):

docker run -it --rm -p 69:69/udp tftp

Example 2 (pixiecore)

Install Docker for Windows Version 1.13.0-rc7-beta37 (9733) on a Windows 10 Pro computer.  The Docker for Windows installer will set up MobyLinuxVM in Hyper-V.
Disable the Windows Firewall.
Run the following command in Windows Powershell:

docker run --net=host -v ${PWD}:/image danderson/pixiecore boot https://alpha.release.core-os.net/amd64-usr/current/coreos_production_pxe.vmlinuz https://alpha.release.core-os.net/amd64-usr/current/coreos_production_pxe_image.cpio.gz --cmdline='coreos.autologin'

Describe the results you received:
Example 1
From either Windows or another Linux computer, test the TFTP server.
C:\Users\Bill>tftp -i <IP_ADDRESS> GET undionly.kpxe

OR

bill@nuc1:~$ tftp <IP_ADDRESS>
tftp> get undionly.kpxe
Transfer timed out.

Example 2 (pixiecore)
Turn on another computer in the same network that first tries to boot from network.
Describe the results you expected:
When I run this software on Docker on a computer running Ubuntu, TFTP serves undionly.kpxe just fine and network booting from pixiecore also works as expected.
Additional information you deem important (e.g. issue happens only occasionally):

Windows Docker containers (<IP_ADDRESS>/24) can send UDP packets to an Ubuntu box.
An Ubuntu box can send UDP packets to a Windows Docker container at <IP_ADDRESS>.
Windows host PowerShell can TFTP a file from an Ubuntu box.
Windows Docker containers (<IP_ADDRESS>/24) cannot TFTP from an Ubuntu box.
Windows host Powershell cannot TFTP a file from a Windows Docker container at <IP_ADDRESS>.
Windows Docker containers cannot TFTP a file from another Windows Docker container at <IP_ADDRESS>.
Windows Docker containers (<IP_ADDRESS>/24) can TFTP a file from another Windows Docker container through an address from <IP_ADDRESS>/24

Output of docker version:
Client:
 Version:      1.13.0-rc7
 API version:  1.25
 Go version:   go1.7.3
 Git commit:   48a9e53
 Built:        Fri Jan 13 21:41:57 2017
 OS/Arch:      windows/amd64

Server:
 Version:      1.13.0-rc7
 API version:  1.25 (minimum version 1.12)
 Go version:   go1.7.3
 Git commit:   48a9e53
 Built:        Fri Jan 13 21:41:57 2017
 OS/Arch:      linux/amd64
 Experimental: true

Output of docker info:
Containers: 1
 Running: 1
 Paused: 0
 Stopped: 0
Images: 16
Server Version: 1.13.0-rc7
Storage Driver: aufs
 Root Dir: /var/lib/docker/aufs
 Backing Filesystem: extfs
 Dirs: 43
 Dirperm1 Supported: true
Logging Driver: json-file
Cgroup Driver: cgroupfs
Plugins:
 Volume: local
 Network: bridge host ipvlan macvlan null overlay
Swarm: active
 NodeID: 3cri74k2gzb3s8m0z0s1rg3qt
 Is Manager: true
 ClusterID: 908edch466kp3sw5u3snssll8
 Managers: 1
 Nodes: 1
 Orchestration:
  Task History Retention Limit: 5
 Raft:
  Snapshot Interval: 10000
  Number of Old Snapshots to Retain: 0
  Heartbeat Tick: 1
  Election Tick: 3
 Dispatcher:
  Heartbeat Period: 5 seconds
 CA Configuration:
  Expiry Duration: 3 months
 Node Address: <IP_ADDRESS>
 Manager Addresses:
  <IP_ADDRESS>:2377
Runtimes: runc
Default Runtime: runc
Init Binary: docker-init
containerd version: 03e5862ec0d8d3b3f750e19fca3ee367e13c090e
runc version: 2f7393a47307a16f8cee44a37b262e8b81021e3e
init version: 949e6fa
Security Options:
 seccomp
  Profile: default
Kernel Version: 4.9.3-moby
Operating System: Alpine Linux v3.5
OSType: linux
Architecture: x86_64
CPUs: 2
Total Memory: 1.934 GiB
Name: moby
ID: 4TJT:YSEG:BAWD:D5VK:J7SE:R3AV:QTJY:JB74:DKHQ:LENC:LCTA:2JWE
Docker Root Dir: /var/lib/docker
Debug Mode (client): false
Debug Mode (server): true
 File Descriptors: 36
 Goroutines: 127
 System Time: 2017-01-17T04:39:02.0906497Z
 EventsListeners: 0
Registry: https://index.docker.io/v1/
Experimental: true
Insecure Registries:
 <IP_ADDRESS>/8
Live Restore Enabled: false

Additional environment details (AWS, VirtualBox, physical, etc.):
Microsoft Surface Book with Windows 10 Pro; VirtualBox NOT installed.

Can you open this in https://github.com/docker/for-win/issues as it seems to be specific to Docker for Windows.
I am going to close this here as you say it is working elsewhere.

Created issue #395.


Error when npm run build

Error when npm run build
(node:6321) UnhandledPromiseRejectionWarning: Error: ENOTEMPTY: directory not empty, rmdir 'node_modules'

@poiedk
Try deleting the dist folder manually, and then running the command again.

@poiedk
What version of Node.js are you using?

@poiedk
I have modified the code.
Please try to use the latest.

@poiedk
I have modified the code.
Please try to use the latest.

Thanks, I'll try.


dovecot2: added ssl_dh using security.dhparams

Request

please merge into master
please merge into 18.03

Motivation for this change
The 18.03 channel includes dovecot 2.3, which requires ssl_dh to be set.
-> fixes https://github.com/nixcloud/nixcloud-webservices/issues/21
without this fix, dovecot2's IMAP functionality using ACME won't work
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[x] Fits CONTRIBUTING.md.

This and #39288 are duplicates

If the folder /var/lib/dhparams/ does not exist, I think this fails. The patch should probably include a:
mkdir -p /var/lib/dhparams

@leenaars , the path will be created and managed by the dhparams service. It should however use config.security.dhparams.path instead of the hardcoded one as pointed out by @Ekleog

Tested that Dovecot service builds and configuration looks sensible, didn't test that it fully works -- I expect this has already been tested. Thanks!

About 18.03 merge -- I'm personally okay with merging #39526 too as it is backwards compatible. If no contra voices arise in the coming days I can go ahead.

On the other hand this change is not fully backwards compatible because before people have probably specified ssh_dh in their extra configuration -- suddenly they have different values coming from them and from this change. Not sure this is a good idea after all.

@abbradar your observation is correct and i think that dovecot will then have a runtime breakage
however, in nixcloud.email we cover both types of setup and when you decide to backport it we just adapt and whoever runs a mailserver on top of nixpkgs WILL be able to handle this breakage and possibly even welcome it. your choice.


Added React Native Bridge for Native (Bottom Sheet, Popover) Libraries

Hi,
I have created below React Native bridge plugins:

react-native-bottom-action-sheet
react-native-popover-menu

I have added the above libraries in react-native-libraries.json file, can you please merge this PR. Please let me know in case any discuss is required for the same
Thanks
Pranav

Hey @prscX thanks for adding these libraries! Cheers.


Requirement for manual install of babel-preset-es2015

Babel is configured to run with es2015 preset but no dependency is declared in sweet.js package.
That results in:
mb % ./node_modules/.bin/sjs ./test.js                                                                                ~/Workspace/sweet-playground
/Users/andreypopp/Workspace/sweet-playground/node_modules/babel-core/lib/transformation/file/options/option-manager.js:372
          throw new Error("Couldn't find preset " + JSON.stringify(val) + " relative to directory " + JSON.stringify(dirname));
          ^

Error: Couldn't find preset "es2015" relative to directory "/Users/andreypopp/Workspace/sweet-playground"
    at /Users/andreypopp/Workspace/sweet-playground/node_modules/babel-core/lib/transformation/file/options/option-manager.js:372:17
    at Array.map (native)
    at OptionManager.resolvePresets (/Users/andreypopp/Workspace/sweet-playground/node_modules/babel-core/lib/transformation/file/options/option-manager.js:364:20)
    at OptionManager.mergePresets (/Users/andreypopp/Workspace/sweet-playground/node_modules/babel-core/lib/transformation/file/options/option-manager.js:348:10)
    at OptionManager.mergeOptions (/Users/andreypopp/Workspace/sweet-playground/node_modules/babel-core/lib/transformation/file/options/option-manager.js:307:14)
    at OptionManager.init (/Users/andreypopp/Workspace/sweet-playground/node_modules/babel-core/lib/transformation/file/options/option-manager.js:465:10)
    at File.initOptions (/Users/andreypopp/Workspace/sweet-playground/node_modules/babel-core/lib/transformation/file/index.js:194:75)
    at new File (/Users/andreypopp/Workspace/sweet-playground/node_modules/babel-core/lib/transformation/file/index.js:123:22)
    at Pipeline.transform (/Users/andreypopp/Workspace/sweet-playground/node_modules/babel-core/lib/transformation/pipeline.js:45:16)
    at Object.compile (/Users/andreypopp/Workspace/sweet-playground/node_modules/sweet.js/dist/sweet.js:79:70)

I think the the right fix would be to remove es2015 preset configuration and let users configure Babel themselves (via .babelrc or "babel" key in package.json).

Good call. Let me know if #511 looks reasonable.

#511 looks good to me


Windows taskbar recent & tasks support

The task bar supports a number of cool features in Windows we aren't currently using today.
This PR adds;

Recently files (opened from Explorer, must be associated, can be pinned)
Recent projects (same as File > Reopen Project including configurable number of items)
New Window task (same as File> New Window)

A screenshot is worth n number of words.

Does this apply to https://github.com/atom/atom/issues/12655?

This was the underlying PR that enabled that functionality.... Will continue discussion on other issue.


Not an issue but a compliment

This packaging is freakin outstanding.  Saved me hours of headaches
just wanted to say THANK YOU

🤘


Add a flag to specifically disallow the "lazy initialization of an empty object" pattern in checkJs mode

Bug Report
🔎 Search Terms
ts2739 jsdoc
🕗 Version & Regression Information

This is the behavior in every version I tried, and I reviewed the FAQ for entries about ts2739

⏯ Playground Link
Playground links with relevant code:

JavaScript + JSDoc
TypeScript equivalent of the same code

💻 Code
JavaScript
/**
 * @typedef Foo
 * @property {number} foo
 * @property {string} bar
 */

/** @type {Foo} */
const x = {}; // No error here, even though x is missing some properties
x.foo = 3;

TypeScript
type Foo = {
    foo: number;
    bar: string;
}

const x : Foo = {}; // x gets a TS2739 error, as expected
x.foo = 3;

🙁 Actual behavior
The JavaScript + JSDoc version doesn't get a TS2739 error.
🙂 Expected behavior
TS2739 is emitted, similar to what happens in the TypeScript equivalent of this code.
I reckon this might have been added to solve a situation that might occur in JavaScript that will never happen when using TypeScript only (although I'm not sure what that situation might be). If that's the case, consider this a feature request to add a configuration option that removes this behaviour 🙂.

This is the documented behavior for JS, see the handbook.

I get that lazy initialization is allowed in JS, but it actually seems like a bug that an error is never flagged even if x is used before all the properties are initialized.


Exclude files starting with certain characters

https://wordpress.org/support/topic/exclude-files-starting-with-certain-characters/

Hello,
We walked into an issue using HTML to Canvas, where the Google Cloud bucket doesn’t allow us to take a screenshot of a certain image. It does work when we don’t use GC for these files, but host them on our normal server. Using CORS on the bucket isn’t an option, due to security reasons and running a multisite environment.
We use completely stateless.
Is it possible to exclude files being uploaded that for example start with specific characters? So for example: If a file starts with SPECIFCHAR the file doesn’t get uploaded to GC, the URL doens’t get replaced & the file isn’t removed from our regular server? So for example; SPECIFCHARfilename.png doesnt get uploaded to the cloud, filename.png does get uploaded?
Thanks in advance!

I have added wp_stateless_skip_add_media as filter.
With this filter user can skip the sync if they want.
/**
* To skip the sync process.
*
* Returning a non-null/true value
* will effectively short-circuit the function.
*
* $force and $args params are optional.
* This two will be passed on by compatibility.
*
* @since 2.2.4
*
* @param bool              $value          This should return true if want to skip the sync.
* @param int               $metadata       Metadata for the attachment.
* @param string            $attachment_id  Attachment ID.
* @param bool              $force          Whether to force the sync even the file already exist in GCS.
* @param bool              $args           Whether to only sync the full size image.
*/

$check = apply_filters('wp_stateless_skip_add_media', null, $metadata, $attachment_id, $force, $args);

Looks good. Is it done? Could be closed?

@antonkorotkov yes.


feat: Allow multiple responses for a unique request ID

Summary
This change allows multiple responses to be recorded for the same request.
For example, if an app makes a GET request to the endpoint /todo/1 it will record the response within a response collection for the calculated request ID.
Any subsequent responses for the same GET requests will be pushed into the response collection for that calculated request ID.
This allows the plugin to support the case described in the issue. Where a later request for an entity results in a different response.
Related Issue(s)
Issue #128
Checklist

[x] Follows Contributing guidelines.
[x] Pull Request title uses Conventional Commit syntax.
[x] All tests pass.
[x] Linted code.
[x] Authored new tests, if necessary.
[x] Updated documentation, if necessary.

@tvsbrent Pinging you on this to see if you have any feedback.

Your suggestion seems to work. I implemented it and added a few tests.


chore(deps): upgrade dev dependencies

Upgrades project dependencies. See details in workflow run.

Automatically created by projen via the "upgrade-dev-dependencies-1.x" workflow

⚪ Backport skipped
The pull request was not backported as there were no branches to backport to. If this is a mistake, please apply the desired version labels or run the backport tool manually.
Manual backport
To create the backport manually run:
backport --pr 1758

Questions ?
Please refer to the Backport tool documentation


UI: Notification experience improvements

@jordwalke had some great ideas around improving our notifications story in the Discord.
A persistent number of 'new messages' that are 'unread' in the statusbar.

Message animates in when a new notification comes in:

Messages are shown in the bottom:

And can expand the pane:

The UX for notifications is very spammy and not very friendly right now. I really like the proposal here - maybe something we can explore @glennsl ?
A few things we'd have to consider:

How long do messages 'stay' in the status bar?
Do they cover up the items in the status bar? Or fit in between them?

I think the 'search pane' + the diagnostics pane in #1034 would be a natural place we could surface these.

Only problem with the search pane position as the sole locations that I can see, is that many of these messages are intended to be very lightweight, and should be visible even in a minimalist windowing configuration. I think the search pane would be a great place to see the entire history of logs though. You definitely want a place to go explore old logs and that pane seems like the right place.

Only problem with the search pane position as the sole locations that I can see, is that many of these messages are intended to be very lightweight, and should be visible even in a minimalist windowing configuration.

Definitely! I like the idea of using the status bar for the showing of the notifications - the experience seems much better than what we have now.
I think my comment above made it sound like I only wanted them in the 'search pane', so I edited it a bit to clarify-


Build failed on chip M2 Pro (Apple Silicon)

Build failed with error:
error: failed to run custom build command for `rusty_ffmpeg v0.9.5`

Caused by:
  process didn't exit successfully: `/Users/zed/Documents/self/rspleeter/target/debug/build/rusty_ffmpeg-2205ec434d1e9750/build-script-build` (exit status: 101)
  --- stderr
  thread 'main' panicked at 'No linking method set!', /Users/zed/.cargo/registry/src/index.crates.io-6f17d22bba15001f/rusty_ffmpeg-0.9.5/build.rs:339:13
  note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

Please link the full error report with your building command. Have you ever used cargo xtask build to build the project?

@ldm0, thanks for your reply. I have followed the instructions that you provided in the README file, but I'm stuck at building tensorflow-sys for rspleeter. I mean, rspleeter depends on tensorflow, and tensorflow is dependent on tensorflow-sys, but I've tried building it many times and encountered different errors. The one mentioned above is just one of those cases.
I have found out the issue from here and I retry to build with the gist from the issue and it works, it generated tensorflow dylib. But I don't know how to use these dylibs in rspleeter.
After finding many method to get it works, I have realized that I can install tensorflow via homebrew without compile it manually.
It works.

That's great! Thanks for your sharing. Building rust projects with FFI is relatively thorny compared to pure rust projects. Feel free to open another issue if you encounter any other problem.


Fix client header reading bug

@nsg This solves the client header problem as far as I have been able to test

@petterarvidsson :+1:


Verb idea: tab.getFilePath

I would find this very useful.
I thought about something like tab.getFileInfo, which would return the same type of structure as file.getFileInfo. However, I think that might be confusing. And, once you have the path from the tab, you can get the other info with the verb that's already there.
I also considered a couple other options like tab.getOutlineUrl (returns the URL of the open tab, if it's not a Drummer file), and tab.getInfo (returns some structure that combines both getFileInfo and URL-type stuff). I don't have a use right now for the first, and the second is basically a whole new API, so I discarded those as well.
tab.getFilePath
Syntax
tab.getFilePath()
Params
None
What it does
If the outline in the current tab in the outliner is a Drummer file, returns the path to the file
Returns
The path to the file, or null if the outline in the current tab is not a Drummer file
Examples
tab.getFilePath ()

"hello3.opml"

Notes
This verb returns null if the tab is not a Drummer file rather than undefined because the value is known to be null

I think returning undefined is probably better than null, so please disregard that part of the idea.

This is a good idea. For some reason I thought we already had this functionality but I just scanned the list of verbs and couldn't find it. Obviously a verb that gets you info about the current file would be a good thing to have.

Here you go --
http://docserver.scripting.com/?verb=tab.getActiveTabStatus
Dave

Hot dog, that is perfect for my needs. Works great. Thank you!


refactor: upgrade terraform setup action

Current dependencies on/for this PR:

main

PR #185   👈

This stack of pull requests is managed by Graphite.


Update 2015-01-04-cocoapods-and-frameworks.markdown

Fixed a typo Howver / However

Thanks Estaban!

:bow:


Cannot read property 'apply' of null

After upgrading from 1.10.0 to 1.11.0 the following code causes an error:
  // set data-selected on options that are programmatically selected
  // prior to initialization of bootstrap-select
  var _val = $.fn.val;
  $.fn.val = function(value){
    if (this.is('select') && value) {
      this.find('option[value="' + value + '"]').data('selected', true);
    }

    return _val.apply(this, arguments);
  };

the exception is thrown on the return line. It looks like _val is null.
What changed from 1.10.0 to 1.11.0 that could cause this error?

That piece of code went in here: https://github.com/silviomoreto/bootstrap-select/commit/5da66949c2e7607a078a3aa3dd5c024c60ed4b50

Can you provide an example? I can't recreate this.

We had that problem in this open source: https://github.com/jekkos/opensourcepos/commit/9a6bd6e000cf731767344a19d25154f5dfc0ff18 and I reverted the version to 1.10 to avoid that issue.
As soon as I updated your plugin to 1.11 I got issue reports: https://github.com/jekkos/opensourcepos/issues/813 and https://github.com/jekkos/opensourcepos/issues/812
Unfortunately I don't have the time to create a specific example, but that source is quite mature and ready to be delivered and worked well for many months of development with version 1.10.

@caseyjhol I was having the same problem and we rolled back to v1.10.0 and everything worked fine.  Here is a link to a codeply that causes the problem.
http://codeply.com/go/y8gEFpNvbz
To see the problem please do the following:

Click on Magnifying class
Type in J in the text box that just displayed (In the console, you will see the error)

If you roll back to an older version of bootstrap-select you will the autocomplete run correctly.
I hope this helps, if not let me know and I'll try and update with some more.
Ken

Great - thanks, Ken. Will look into this.

Yes, we get the same issue with an autocomplete box.


fix: commit icon of github on airgapped, the app crashes. #33812

Screenshot after Solving the app crash.

Bug Fixes:
Page crashes happened because of null pointer exception from front-end code, fixed that one.
Fixes : #33812 .

Summary by CodeRabbit

Bug Fixes

Improved error handling in the ReconnectSSHError component to prevent crashes due to undefined nested properties using optional chaining.

@rohan-arthur , please assign reviewer to this small and easy to review pr

@rohan-arthur , gentle reminder for reviewing @Nikhil-Nandagopal ,
it is a small fix. Let us know your feedback

Have passed this on to the concerned team, they'll be in touch

@VigneswarV apologies for the late response. I will take a look at this PR

CI tests running at https://github.com/appsmithorg/appsmith/pull/35454


stream data lags after some time

If streaming is left for some time, the data starts to lag.
This is because of the way subscriber is implemented. The Blocking Collection take is FIFO and the interface provided to get packet retrieves only one packet at a time, the rate of which is controlled by the interface user. For example an app using getpackets may choose to call it at an interval of 5 secs, whereas the packet gets added to the collection each time onmessage is called.
So after some time the collection size grows , with the most recent data at the end but getpacket retrieves only the first.
The solution is to drain the collection and return only the last. If the user polls more frequently then the onmessage called, it will return null / error( as a list ) and not block on collection to be filled.

@apurvaChaudhari

hi,
Thank you for contributing.
the lag is important and can be delt by starting a thread that cleans the que
let me explain
now imagine u subcribe to 10 scripts
at every tic you get data for two to three scripts but you dont know which is which and the tics dont follow any particular sequence or order
so in this case tis better to build a abstraction layer that runs a thread that reads from the que and saves each individual tick as per the script and when the script is requested it will give the latest one saved.
I have done this and it solves the lag prob ,but if i introduce the file here it will prevent anyone from doing their custom implementation for the same.
kindly give ur suggestion @me-neo

@apurvaChaudhari
Hi Apurva,
What I had suggested is a very simplistic solution and agree this wont be ideal if many scripts are subscribed.
But then the correct way to go should be to provide a plug and play solution , where someone wanting to get quotes for scripts should just use kitecore apis.
The current code exposes getpackets api to get data, not the Blocking Collection subscribe / publish.
Writing such a thread would mean to add custom code in KiteCore,
Since you are already abstracting over the kite APIs, I think the best thing to do would be to return a dictionary of subscribed scripts, ltp. This dictionary would always contain the ltp for each script, and when you parse the incoming data, update the corresponding dictionary value. This way the drain is controlled by the subscriber thread itself and the kitecore client always gets the updated data.
let me know what you think.
I have some other suggestions / fixes, will open new threads for them.


haskellPackages.hnix: Patch to fix broken location annotations

Also reenable tests for update-nix-fetchgit

Motivation for this change
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Added a release notes entry if the change is major or breaking
[x] Fits CONTRIBUTING.md.

@ofborg build haskellPackages.update-nix-fetchgit update-nix-fetchgit haskellPackages.hnix

Thanks for fixing this up!
If for some reason this doesn't get into the release-21.05 branch, please feel free to backport this PR.

Thanks!


Luci web shows menus when user is not logged in

Hello,
Luci web shows menus when user is not logged in.
Menus should be visible only if user is logged in.
How to fix this ?

Duplicate of #3653, #3766, #3785, #3837 and original discussion in #3563

Hi,
This patch is really really bad. You are saying "come wolf eat me" to hackers :)
I know that you can see the menus on other places but i think it is better if the door is not locked but closed instead not closed and widely open ... if you understand what i mean.....


v2021.5.26

coverage - increase regression testing and coverage to 98.41% (almost 100% baby!)
ci - fix ci silently failing in node-v12 and node-v14.
cli - add env var JSLINT_CLI to force-trigger cli in jslint.js (used for code-coverage of cli).
jslint - add "globalThis" to default globals.
jslint - add new rules unordered_param_a, unordered_property_a, that warn if parameters and properties are listed in nonascii-order.
jslint - fix bug where (global) functionage missing properties finally and try.
jslint - fix bug failing to parse unicode "\u{12345}".
jslint - fix bug falsely warning against conditional-chaining-operator "?.".
jslint - remove deadcode for preaction-binary-".".
jslint - remove deadcode warning bad_option_a.
website - add fork-me ribbon.
website - load index.html with example code.
website - merge file report.js into browser.js.

demo of release-candidate available @ https://www.jslint.com/branch.beta/index.html

Not sure if this is the right place, but I feel like the unordered_param_a/unordered_property_a is quite the change and to just have it on by default, without an option to disable it. I've been using JSLint for years and have always gone with what ever changes were introduced, because in the end they made my code better. But this feels a bit weird?

hi @chrswk,  jslint will be shipping with ignore-macros shortly.  i eventually want to get rid of most of the directives, and use /*jslint ignore:...*/  macros whenever a need to ignore warnings arise, e.g.:
/* jslint ignore:start */
/*! jQuery v3.6.0 | (c) OpenJS Foundation and other contributors | jquery.org/license */
!function(e,t){"use strict";"object"==typeof module&&...
/* jslint ignore:end */

let err = {
    statusCode: 404,
    // suppress warning unordered_property_a
    message: "Not Found", // jslint ignore:line
    type: "httpError",
    url: "https://www.undefined.com/undefined"
};

would that satisfy your needs?  and appreciate knowing the cli helps : )

Thank for the input.
To be honest, I'm not really a fan of the macros instead of the config flags, but I see why it would be easier in some cases. If that is the "solution", I think I will go through the trouble of reordering all my properties and parameters, even if that's a lot of work.
But out of curiosity: What is the reason or expected benefit of having ordered properties/parameters?

when inspecting/editing large dictionaries/json-objects with > 50 items, scrolling around the editor to find a key becomes troublesome if they're not sorted in some canonical order.
you've made me consider maybe adding a new directive classical or something similar which allows jslint to only enforce warnings pre v2021.5.26.
in meantime, since jslint is tool-less, you are free to disable (or add) warnings by simply editing jslint.js:
https://raw.githubusercontent.com/jslint-org/jslint/v2021.5.26/jslint.js
diff --git a/.a00.js b/.a00.js
index 2b62242..bee1d2a 100644
--- a/.a00.js
+++ b/.a00.js
@@ -2769,9 +2769,9 @@ function parameter_list() {
                     survey(subparam);
                     a = b;
                     b = String(subparam.value || subparam.id);
-                    if (a > b) {
-                        warn("unordered_param_a", subparam);
-                    }
+                    //!! if (a > b) {
+                        //!! warn("unordered_param_a", subparam);
+                    //!! }
                     advance();
                     signature.push(subparam.id);
                     if (next_token.id === ":") {
@@ -3123,9 +3123,9 @@ prefix("{", function () {
             advance();
             a = b;
             b = String(name.value || name.id);
-            if (a > b) {
-                warn("unordered_property_a", name);
-            }
+            //!! if (a > b) {
+                //!! warn("unordered_property_a", name);
+            //!! }
             if (
                 (name.id === "get" || name.id === "set")
                 && next_token.identifier
@@ -3284,9 +3284,9 @@ function do_var() {
                 survey(name);
                 a = b;
                 b = String(name.value || name.id);
-                if (a > b) {
-                    warn("unordered_param_a", name);
-                }
+                //!! if (a > b) {
+                    //!! warn("unordered_param_a", name);
+                //!! }
                 advance();
                 if (next_token.id === ":") {
                     advance(":");

new version v2021.5.27 has been pushed to branch master and https://www.jslint.com/jslint.js with new directive /*jslint unordered*/.
also in future, please use https://github.com/jslint-org/jslint/issues to raise issues/feature-requests/ideas ; )

Oh no. As a developer who fights every day to not have to add new config parameters for X and Y to my software, I now have a config parameter on my conscience! 😅
I really appreciate your efforts. Your explanation makes sense and I think it should also reduce the mental effort of reasoning about a "logical" order. If you will excuse me, I have some properties and params reordering to do...


Delete resources older than X days

Hello and thanks for this useful tool!
My goal is to drop resources that are older than X days, following this part of the docs.
I tested with VirtualMachine and it does not work. I'm not familiar with this repo but I think that's because TimeCreated is not mapped here: https://github.com/ekristen/azure-nuke/blob/d952ce21e255b073fdf89b755c67b63764610642/resources/virtual-machine.go#L79-L88
I had a quick look at the azure SDK and I'm not even sure they expose this field, I only saw it for the Disk resource.
Would it be possible to add this feature? I'd be happy to help if needed!

Correct. It would need to be added to here https://github.com/ekristen/azure-nuke/blob/d952ce21e255b073fdf89b755c67b63764610642/resources/virtual-machine.go#L29-L35 then mapped in your link. I'll take a look. Azure is pretty junky to work with, especially with their sdks. :facepalm:

@FlorentClarret glad you like the tool. Looks like the current SDK doesn't expose it but there's a newer SDK I need to move to, perhaps it supports that field. I'll take a look and see what I can do. For now I'll leave it open.

@FlorentClarret I figured out how to get CreationDate on VirtualMachine, I'll get it in an upcoming release.


Make Worldwide taxons expand/collapse per country

https://trello.com/c/O7if1mGu/147-improve-the-worldwide-tagging-interface-3
Currently, only world expands which displays a huge list of all
the countries and their sub taxons. This is not good for the user as its
an overload of information.
This change provides a link to expand/collapse per country, this new list
also displays everything alphabetically starting with all the taxons
that have no children.
Before

After

It looks like you've made some changes related to comments I've made. Just a note, but it is useful to comment and say this has happened, just to make it clear what is going on.

Is this change going to require the cache for the taxon data to be repopulated from the Publishing API?

Yes, the cache would have to be refreshed!


Update mysql.sh + mysql-install.sh

Description
Added Release Repository selection
Type of change
Please check the relevant option(s):

[ ] Bug fix (non-breaking change that resolves an issue)
[X] New feature (non-breaking change that adds functionality)
[ ] Breaking change (a fix or feature that would cause existing functionality to change unexpectedly)
[ ] New script (a fully functional and thoroughly tested script or set of scripts.)
[ ] Documentation update required (this change requires an update to the documentation)

Prerequisites
The following efforts must be made for the PR to be considered. Please check when completed:

[X] Self-review performed (I have reviewed my code, ensuring it follows established patterns and conventions)
[X] Testing performed (I have tested my changes, ensuring everything works as expected)

Related Pull Requests / Discussions

Related PR #106

A yes/no prompt like this in install script could be acceptable
RELEASE_REPO="mysql-8.0"
RELEASE_AUTH="mysql_native_password"
read -r -p "Would you like to install MySQL Innovation release instead of MySQL 8.0? <y/N> " prompt
if [[ "${prompt,,}" =~ ^(y|yes)$ ]]; then
      RELEASE_REPO="mysql-innovation"
      RELEASE_AUTH="caching_sha2_password"
fi

Thanks, I appreciate the feedback.. I needed 8.4 LTS in a container and after getting it working for myself thought I would contribute.  Innovation is "production ready" but too bleeding edge.  8.0 is the older LTS and its EOL is April 2026.  8.4 is the current LTS release.  I will rework it to offer a choice between the two LTS versions and submit a final PR.


[Channel] FPDA - Federação Portuguesa de Autismo

Information about the proposed communication channel:
Channel Name or label: FPDA - Federação Portuguesa de Autismo
Contact address<EMAIL_ADDRESS>Rua José Luís Garcia Rodrigues, Bairro do Alto da Ajuda, 1300 - 565 Lisboa, Portugal
Type: Federation of associations for people on the ASD
Disability focus: Autism
Country and language: Portugal / Portuguese
Link: https://www.fpda.pt/
Proposed by: Pedro Encarnação
Status: Proposal

Types include: Care givers, end- users, teachers, relatives, parents, friends researchers, colleagues, HR,  developers, experts

The organization was added to the Wiki - thank you for your contribution Pedro :pray:


change(esp-tls): add option to enable/disable the full set of OCSP checks for wolfSSL (IDFGH-13619)

I've added an option to enable/disable WOLFSSL_OCSP_CHECKALL when enabling OCSP in esp_tls_wolfssl.c .

@frankencode Thanks for the change.
Just one thing as mentioned above but otherwise the PR looks good to me.

OK, I've fixed that Kconfig to proper "ESP_TLS_" prefix.

Done.

sha=ba27281c3ed7c3ee174db5bd75f4dc7cd698c241


Can I continue training based on the weights you provided?

Of course, my friend! We also encourage further development and contributions to this project.


fixed build error on osx app

if statement bracket position is wrong. then I fixed bracket position.

Thanks!