Update Android changelog

The android changelog was not updated since the last release in Dec 2021.
This pull request adds changelog entries for the time since the last release including commits which either touched the core or the platform/android folder.
The list was generated with git log --oneline -- src include platform/android
Related to the goal of making an android release at #585

@boltrn as we are waiting for the timeout issues to get resolved, do you think this changelog makes roughly sense?

Ready for review @boldtrn


[go_router] Replacing a ModalBottomSheetRoute with Another ModalBottomSheetRoute Fails

What package does this bug report belong to?
go_router
What target platforms are you seeing this bug on?
Android, iOS
Have you already upgraded your packages?
Yes
Dependency versions
pubspec.lock
# Generated by pub
# See https://dart.dev/tools/pub/glossary#lockfile
packages:
  adaptive_breakpoints:
    dependency: transitive
    description:
      name: adaptive_breakpoints
      sha256: "3aa6ef09074fe7824dfdc9a6d9f955c8a3bae0fb71c495cbd72f471a87699b4f"
      url: "https://pub.dev"
    source: hosted
    version: "0.1.6"
  adaptive_navigation:
    dependency: "direct main"
    description:
      name: adaptive_navigation
      sha256: "271d3e54147ce37b389c3d7d19777b4340e4ccd440d0349457c8b8db197b1c41"
      url: "https://pub.dev"
    source: hosted
    version: "0.0.9"
  async:
    dependency: transitive
    description:
      name: async
      sha256: "947bfcf187f74dbc5e146c9eb9c0f10c9f8b30743e341481c1e2ed3ecc18c20c"
      url: "https://pub.dev"
    source: hosted
    version: "2.11.0"
  boolean_selector:
    dependency: transitive
    description:
      name: boolean_selector
      sha256: "6cfb5af12253eaf2b368f07bacc5a80d1301a071c73360d746b7f2e32d762c66"
      url: "https://pub.dev"
    source: hosted
    version: "2.1.1"
  characters:
    dependency: transitive
    description:
      name: characters
      sha256: "04a925763edad70e8443c99234dc3328f442e811f1d8fd1a72f1c8ad0f69a605"
      url: "https://pub.dev"
    source: hosted
    version: "1.3.0"
  clock:
    dependency: transitive
    description:
      name: clock
      sha256: cb6d7f03e1de671e34607e909a7213e31d7752be4fb66a86d29fe1eb14bfb5cf
      url: "https://pub.dev"
    source: hosted
    version: "1.1.1"
  collection:
    dependency: "direct main"
    description:
      name: collection
      sha256: ee67cb0715911d28db6bf4af1026078bd6f0128b07a5f66fb2ed94ec6783c09a
      url: "https://pub.dev"
    source: hosted
    version: "1.18.0"
  cupertino_icons:
    dependency: "direct main"
    description:
      name: cupertino_icons
      sha256: d57953e10f9f8327ce64a508a355f0b1ec902193f66288e8cb5070e7c47eeb2d
      url: "https://pub.dev"
    source: hosted
    version: "1.0.6"
  fake_async:
    dependency: transitive
    description:
      name: fake_async
      sha256: "511392330127add0b769b75a987850d136345d9227c6b94c96a04cf4a391bf78"
      url: "https://pub.dev"
    source: hosted
    version: "1.3.1"
  ffi:
    dependency: transitive
    description:
      name: ffi
      sha256: "7bf0adc28a23d395f19f3f1eb21dd7cfd1dd9f8e1c50051c069122e6853bc878"
      url: "https://pub.dev"
    source: hosted
    version: "2.1.0"
  file:
    dependency: transitive
    description:
      name: file
      sha256: "1b92bec4fc2a72f59a8e15af5f52cd441e4a7860b49499d69dfa817af20e925d"
      url: "https://pub.dev"
    source: hosted
    version: "6.1.4"
  flutter:
    dependency: "direct main"
    description: flutter
    source: sdk
    version: "0.0.0"
  flutter_test:
    dependency: "direct dev"
    description: flutter
    source: sdk
    version: "0.0.0"
  flutter_web_plugins:
    dependency: transitive
    description: flutter
    source: sdk
    version: "0.0.0"
  go_router:
    dependency: "direct main"
    description:
      path: ".."
      relative: true
    source: path
    version: "13.2.3"
  leak_tracker:
    dependency: transitive
    description:
      name: leak_tracker
      sha256: "78eb209deea09858f5269f5a5b02be4049535f568c07b275096836f01ea323fa"
      url: "https://pub.dev"
    source: hosted
    version: "10.0.0"
  leak_tracker_flutter_testing:
    dependency: transitive
    description:
      name: leak_tracker_flutter_testing
      sha256: b46c5e37c19120a8a01918cfaf293547f47269f7cb4b0058f21531c2465d6ef0
      url: "https://pub.dev"
    source: hosted
    version: "2.0.1"
  leak_tracker_testing:
    dependency: transitive
    description:
      name: leak_tracker_testing
      sha256: a597f72a664dbd293f3bfc51f9ba69816f84dcd403cdac7066cb3f6003f3ab47
      url: "https://pub.dev"
    source: hosted
    version: "2.0.1"
  logging:
    dependency: "direct main"
    description:
      name: logging
      sha256: "623a88c9594aa774443aa3eb2d41807a48486b5613e67599fb4c41c0ad47c340"
      url: "https://pub.dev"
    source: hosted
    version: "1.2.0"
  matcher:
    dependency: transitive
    description:
      name: matcher
      sha256: d2323aa2060500f906aa31a895b4030b6da3ebdcc5619d14ce1aada65cd161cb
      url: "https://pub.dev"
    source: hosted
    version: "0.12.16+1"
  material_color_utilities:
    dependency: transitive
    description:
      name: material_color_utilities
      sha256: "0e0a020085b65b6083975e499759762399b4475f766c21668c4ecca34ea74e5a"
      url: "https://pub.dev"
    source: hosted
    version: "0.8.0"
  meta:
    dependency: transitive
    description:
      name: meta
      sha256: d584fa6707a52763a52446f02cc621b077888fb63b93bbcb1143a7be5a0c0c04
      url: "https://pub.dev"
    source: hosted
    version: "1.11.0"
  nested:
    dependency: transitive
    description:
      name: nested
      sha256: "03bac4c528c64c95c722ec99280375a6f2fc708eec17c7b3f07253b626cd2a20"
      url: "https://pub.dev"
    source: hosted
    version: "1.0.0"
  path:
    dependency: transitive
    description:
      name: path
      sha256: "087ce49c3f0dc39180befefc60fdb4acd8f8620e5682fe2476afd0b3688bb4af"
      url: "https://pub.dev"
    source: hosted
    version: "1.9.0"
  path_provider_linux:
    dependency: transitive
    description:
      name: path_provider_linux
      sha256: f7a1fe3a634fe7734c8d3f2766ad746ae2a2884abe22e241a8b301bf5cac3279
      url: "https://pub.dev"
    source: hosted
    version: "2.2.1"
  path_provider_platform_interface:
    dependency: transitive
    description:
      name: path_provider_platform_interface
      sha256: "94b1e0dd80970c1ce43d5d4e050a9918fce4f4a775e6142424c30a29a363265c"
      url: "https://pub.dev"
    source: hosted
    version: "2.1.1"
  path_provider_windows:
    dependency: transitive
    description:
      name: path_provider_windows
      sha256: "8bc9f22eee8690981c22aa7fc602f5c85b497a6fb2ceb35ee5a5e5ed85ad8170"
      url: "https://pub.dev"
    source: hosted
    version: "2.2.1"
  platform:
    dependency: transitive
    description:
      name: platform
      sha256: ae68c7bfcd7383af3629daafb32fb4e8681c7154428da4febcff06200585f102
      url: "https://pub.dev"
    source: hosted
    version: "3.1.2"
  plugin_platform_interface:
    dependency: transitive
    description:
      name: plugin_platform_interface
      sha256: da3fdfeccc4d4ff2da8f8c556704c08f912542c5fb3cf2233ed75372384a034d
      url: "https://pub.dev"
    source: hosted
    version: "2.1.6"
  provider:
    dependency: "direct main"
    description:
      name: provider
      sha256: cdbe7530b12ecd9eb455bdaa2fcb8d4dad22e80b8afb4798b41479d5ce26847f
      url: "https://pub.dev"
    source: hosted
    version: "6.0.5"
  shared_preferences:
    dependency: "direct main"
    description:
      name: shared_preferences
      sha256: b7f41bad7e521d205998772545de63ff4e6c97714775902c199353f8bf1511ac
      url: "https://pub.dev"
    source: hosted
    version: "2.2.1"
  shared_preferences_android:
    dependency: transitive
    description:
      name: shared_preferences_android
      sha256: "8568a389334b6e83415b6aae55378e158fbc2314e074983362d20c562780fb06"
      url: "https://pub.dev"
    source: hosted
    version: "2.2.1"
  shared_preferences_foundation:
    dependency: transitive
    description:
      name: shared_preferences_foundation
      sha256: "7bf53a9f2d007329ee6f3df7268fd498f8373602f943c975598bbb34649b62a7"
      url: "https://pub.dev"
    source: hosted
    version: "2.3.4"
  shared_preferences_linux:
    dependency: transitive
    description:
      name: shared_preferences_linux
      sha256: c2eb5bf57a2fe9ad6988121609e47d3e07bb3bdca5b6f8444e4cf302428a128a
      url: "https://pub.dev"
    source: hosted
    version: "2.3.1"
  shared_preferences_platform_interface:
    dependency: transitive
    description:
      name: shared_preferences_platform_interface
      sha256: d4ec5fc9ebb2f2e056c617112aa75dcf92fc2e4faaf2ae999caa297473f75d8a
      url: "https://pub.dev"
    source: hosted
    version: "2.3.1"
  shared_preferences_web:
    dependency: transitive
    description:
      name: shared_preferences_web
      sha256: d762709c2bbe80626ecc819143013cc820fa49ca5e363620ee20a8b15a3e3daf
      url: "https://pub.dev"
    source: hosted
    version: "2.2.1"
  shared_preferences_windows:
    dependency: transitive
    description:
      name: shared_preferences_windows
      sha256: f763a101313bd3be87edffe0560037500967de9c394a714cd598d945517f694f
      url: "https://pub.dev"
    source: hosted
    version: "2.3.1"
  sky_engine:
    dependency: transitive
    description: flutter
    source: sdk
    version: "0.0.99"
  source_span:
    dependency: transitive
    description:
      name: source_span
      sha256: "53e943d4206a5e30df338fd4c6e7a077e02254531b138a15aec3bd143c1a8b3c"
      url: "https://pub.dev"
    source: hosted
    version: "1.10.0"
  stack_trace:
    dependency: transitive
    description:
      name: stack_trace
      sha256: "73713990125a6d93122541237550ee3352a2d84baad52d375a4cad2eb9b7ce0b"
      url: "https://pub.dev"
    source: hosted
    version: "1.11.1"
  stream_channel:
    dependency: transitive
    description:
      name: stream_channel
      sha256: ba2aa5d8cc609d96bbb2899c28934f9e1af5cddbd60a827822ea467161eb54e7
      url: "https://pub.dev"
    source: hosted
    version: "2.1.2"
  string_scanner:
    dependency: transitive
    description:
      name: string_scanner
      sha256: "556692adab6cfa87322a115640c11f13cb77b3f076ddcc5d6ae3c20242bedcde"
      url: "https://pub.dev"
    source: hosted
    version: "1.2.0"
  term_glyph:
    dependency: transitive
    description:
      name: term_glyph
      sha256: a29248a84fbb7c79282b40b8c72a1209db169a2e0542bce341da992fe1bc7e84
      url: "https://pub.dev"
    source: hosted
    version: "1.2.1"
  test_api:
    dependency: transitive
    description:
      name: test_api
      sha256: "5c2f730018264d276c20e4f1503fd1308dfbbae39ec8ee63c5236311ac06954b"
      url: "https://pub.dev"
    source: hosted
    version: "0.6.1"
  url_launcher:
    dependency: "direct main"
    description:
      name: url_launcher
      sha256: "47e208a6711459d813ba18af120d9663c20bdf6985d6ad39fe165d2538378d27"
      url: "https://pub.dev"
    source: hosted
    version: "6.1.14"
  url_launcher_android:
    dependency: transitive
    description:
      name: url_launcher_android
      sha256: b04af59516ab45762b2ca6da40fa830d72d0f6045cd97744450b73493fa76330
      url: "https://pub.dev"
    source: hosted
    version: "6.1.0"
  url_launcher_ios:
    dependency: transitive
    description:
      name: url_launcher_ios
      sha256: "7c65021d5dee51813d652357bc65b8dd4a6177082a9966bc8ba6ee477baa795f"
      url: "https://pub.dev"
    source: hosted
    version: "6.1.5"
  url_launcher_linux:
    dependency: transitive
    description:
      name: url_launcher_linux
      sha256: b651aad005e0cb06a01dbd84b428a301916dc75f0e7ea6165f80057fee2d8e8e
      url: "https://pub.dev"
    source: hosted
    version: "3.0.6"
  url_launcher_macos:
    dependency: transitive
    description:
      name: url_launcher_macos
      sha256: b55486791f666e62e0e8ff825e58a023fd6b1f71c49926483f1128d3bbd8fe88
      url: "https://pub.dev"
    source: hosted
    version: "3.0.7"
  url_launcher_platform_interface:
    dependency: transitive
    description:
      name: url_launcher_platform_interface
      sha256: "95465b39f83bfe95fcb9d174829d6476216f2d548b79c38ab2506e0458787618"
      url: "https://pub.dev"
    source: hosted
    version: "2.1.5"
  url_launcher_web:
    dependency: transitive
    description:
      name: url_launcher_web
      sha256: "2942294a500b4fa0b918685aff406773ba0a4cd34b7f42198742a94083020ce5"
      url: "https://pub.dev"
    source: hosted
    version: "2.0.20"
  url_launcher_windows:
    dependency: transitive
    description:
      name: url_launcher_windows
      sha256: "95fef3129dc7cfaba2bc3d5ba2e16063bb561fc6d78e63eee16162bc70029069"
      url: "https://pub.dev"
    source: hosted
    version: "3.0.8"
  vector_math:
    dependency: transitive
    description:
      name: vector_math
      sha256: "80b3257d1492ce4d091729e3a67a60407d227c27241d6927be0130c98e741803"
      url: "https://pub.dev"
    source: hosted
    version: "2.1.4"
  vm_service:
    dependency: transitive
    description:
      name: vm_service
      sha256: b3d56ff4341b8f182b96aceb2fa20e3dcb336b9f867bc0eafc0de10f1048e957
      url: "https://pub.dev"
    source: hosted
    version: "13.0.0"
  win32:
    dependency: transitive
    description:
      name: win32
      sha256: "9e82a402b7f3d518fb9c02d0e9ae45952df31b9bf34d77baf19da2de03fc2aaa"
      url: "https://pub.dev"
    source: hosted
    version: "5.0.7"
  xdg_directories:
    dependency: transitive
    description:
      name: xdg_directories
      sha256: "589ada45ba9e39405c198fe34eb0f607cddb2108527e658136120892beac46d2"
      url: "https://pub.dev"
    source: hosted
    version: "1.0.3"
sdks:
  dart: ">=3.2.0 <4.0.0"
  flutter: ">=3.16.0"

Steps to reproduce
Initial Setup: Configure GoRouter with routes that use ModalBottomSheetRoute for displaying modal bottom sheets.
First Navigation: Navigate to the first modal bottom sheet using context.go('/first-modal').
Attempted Replacement: From the first modal bottom sheet, attempt to navigate to a second modal bottom sheet using context.go('/second-modal').
Expected results
Navigation Success: The first modal bottom sheet should close, and the second modal bottom sheet should open, effectively replacing the first one.
Actual results
Navigation Failure: The second modal bottom sheet does not open. The system does not navigate away from the first modal bottom sheet, nor does it display any error messages.
Code sample
Code sample
import 'package:flutter/material.dart';
import 'package:go_router/go_router.dart';

void main() => runApp(const MyApp());

/// The route configuration.
final GoRouter _router = GoRouter(
  routes: <RouteBase>[
    GoRoute(
      path: '/',
      builder: (BuildContext context, GoRouterState state) =>
          const HomeScreen(),
      routes: <RouteBase>[
        GoRoute(
          path: 'first-modal',
          pageBuilder: (BuildContext context, GoRouterState state) =>
              const ModalPage<void>(child: FirstModalScreen()),
        ),
        GoRoute(
          path: 'second-modal',
          pageBuilder: (BuildContext context, GoRouterState state) =>
              const ModalPage<void>(child: SecondModalScreen()),
        ),
      ],
    ),
  ],
);

/// The main app.
class MyApp extends StatelessWidget {
  const MyApp({super.key});

  @override
  Widget build(BuildContext context) {
    return MaterialApp.router(
      routerConfig: _router,
    );
  }
}

/// The home screen with a button to navigate to the first modal.
class HomeScreen extends StatelessWidget {
  const HomeScreen({super.key});

  @override
  Widget build(BuildContext context) {
    return Scaffold(
      appBar: AppBar(title: const Text('Home Screen')),
      body: Center(
        child: ElevatedButton(
          onPressed: () => context.go('/first-modal'),
          child: const Text('Go to the First Modal'),
        ),
      ),
    );
  }
}

/// The first modal screen with a button to navigate to the second modal.
class FirstModalScreen extends StatelessWidget {
  const FirstModalScreen({super.key});

  @override
  Widget build(BuildContext context) {
    return Scaffold(
      appBar: AppBar(title: const Text('First Modal Screen')),
      body: Center(
        child: ElevatedButton(
          onPressed: () => context.go('/second-modal'),
          child: const Text('Go to Second Modal'),
        ),
      ),
    );
  }
}

/// The second modal screen with a button to navigate back home.
class SecondModalScreen extends StatelessWidget {
  const SecondModalScreen({super.key});

  @override
  Widget build(BuildContext context) {
    return Scaffold(
      appBar: AppBar(title: const Text('Second Modal Screen')),
      body: Center(
        child: ElevatedButton(
          onPressed: () => context.go('/'),
          child: const Text('Back to Home Screen'),
        ),
      ),
    );
  }
}

/// A generic modal page class to demonstrate the issue with ModalBottomSheetRoute.
class ModalPage<T> extends Page<T> {
  const ModalPage({required this.child});

  final Widget child;

  @override
  Route<T> createRoute(BuildContext context) => ModalBottomSheetRoute<T>(
        settings: this,
        builder: (context) => Dialog(
          child: child,
        ),
        isScrollControlled: false,
      );
}

Screenshots or Videos

Screenshots / Video demonstration
https://github.com/flutter/flutter/assets/97469482/65327637-083b-4df8-8edb-fb6b0ce6a914

Logs
Logs
[Paste your logs here]

Flutter Doctor output
Doctor output
Doctor summary (to see all details, run flutter doctor -v):
[✓] Flutter (Channel stable, 3.19.5, on macOS 14.4.1 23E224 darwin-arm64, locale
    fr-FR)
[✓] Android toolchain - develop for Android devices (Android SDK version 34.0.0)
[✓] Xcode - develop for iOS and macOS (Xcode 15.0)
[✓] Chrome - develop for the web
[✓] Android Studio (version 2023.2)
[✓] VS Code (version 1.88.0)
[✓] Connected device (5 available)
[✓] Network resources

• No issues found!

Thanks for the report @AristideVB
By updating the code implementation for Go to Second Modal button as below, you get the expected behavior:
onPressed: () => Navigator.of(context).pop(),
          child: const Text('Go to Second Modal'),

Thanks for the update. Can you take a look at below issues and see if they help in your case or not ?
https://github.com/flutter/flutter/issues/100933
https://github.com/flutter/flutter/issues/112765

Thanks for you quick response,
No I've read through https://github.com/flutter/flutter/issues/100933
https://github.com/flutter/flutter/issues/112765 before submitting this issue & they are different

Thanks for the update. I was able to replicate the reported behavior.

 stable, master flutter doctor -v
[!] Flutter (Channel stable, 3.19.5, on macOS 12.2.1 21D62 darwin-x64, locale
    en-GB)
    • Flutter version 3.19.5 on channel stable at
      /Users/dhs/documents/fluttersdk/flutter
    ! Warning: `flutter` on your path resolves to
      /Users/dhs/Documents/Fluttersdk/flutter/bin/flutter, which is not inside
      your current Flutter SDK checkout at
      /Users/dhs/documents/fluttersdk/flutter. Consider adding
      /Users/dhs/documents/fluttersdk/flutter/bin to the front of your path.
    ! Warning: `dart` on your path resolves to
      /Users/dhs/Documents/Fluttersdk/flutter/bin/dart, which is not inside your
      current Flutter SDK checkout at /Users/dhs/documents/fluttersdk/flutter.
      Consider adding /Users/dhs/documents/fluttersdk/flutter/bin to the front
      of your path.
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 300451adae (4 days ago), 2024-03-27 21:54:07 -0500
    • Engine revision e76c956498
    • Dart version 3.3.3
    • DevTools version 2.31.1
    • If those were intentional, you can disregard the above warnings; however
      it is recommended to use "git" directly to perform update checks and
      upgrades.

[!] Xcode - develop for iOS and macOS (Xcode 12.3)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    ! Flutter recommends a minimum Xcode version of 13.
      Download the latest version or update via the Mac App Store.
    • CocoaPods version 1.11.2

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] VS Code (version 1.62.0)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.21.0

[✓] Connected device (5 available)
    • SM G975F (mobile)       • RZ8M802WY0X • android-arm64   • Android 11 (API 30)
    • Darshan's iphone (mobile)  • 21150b119064aecc249dfcfe05e259197461ce23 •
      ios            • iOS 14.4.1 18D61
    • iPhone 12 Pro Max (mobile) • A5473606-0213-4FD8-BA16-553433949729     •
      ios            • com.apple.CoreSimulator.SimRuntime.iOS-14-3 (simulator)
    • macOS (desktop)            • macos                                    •
      darwin-x64     • Mac OS X 10.15.4 19E2269 darwin-x64
    • Chrome (web)               • chrome                                   •
      web-javascript • Google Chrome 98.0.4758.80

[✓] HTTP Host Availability
    • All required HTTP hosts are available

! Doctor found issues in 1 category.

[!] Flutter (Channel master, 3.22.0-7.0.pre.14, on macOS 12.2.1 21D62
    darwin-x64, locale en-GB)
    • Flutter version 3.22.0-7.0.pre.14 on channel master at
      /Users/dhs/documents/fluttersdk/flutter
    ! Warning: `flutter` on your path resolves to
      /Users/dhs/Documents/Fluttersdk/flutter/bin/flutter, which is not inside
      your current Flutter SDK checkout at
      /Users/dhs/documents/fluttersdk/flutter. Consider adding
      /Users/dhs/documents/fluttersdk/flutter/bin to the front of your path.
    ! Warning: `dart` on your path resolves to
      /Users/dhs/Documents/Fluttersdk/flutter/bin/dart, which is not inside your
      current Flutter SDK checkout at /Users/dhs/documents/fluttersdk/flutter.
      Consider adding /Users/dhs/documents/fluttersdk/flutter/bin to the front
      of your path.
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 74b65d4e4c (4 hours ago), 2024-04-09 21:26:14 -0400
    • Engine revision eaf73cd39c
    • Dart version 3.5.0 (build 3.5.0-36.0.dev)
    • DevTools version 2.34.1
    • If those were intentional, you can disregard the above warnings; however
      it is recommended to use "git" directly to perform update checks and
      upgrades.

[!] Android toolchain - develop for Android devices (Android SDK version 30.0.3)
    • Android SDK at /Users/dhs/Library/Android/sdk
    ✗ cmdline-tools component is missing
      Run `path/to/sdkmanager --install "cmdline-tools;latest"`
      See https://developer.android.com/studio/command-line for more details.
    ✗ Android license status unknown.
      Run `flutter doctor --android-licenses` to accept the SDK licenses.
      See https://flutter.dev/docs/get-started/install/macos#android-setup for
      more details.

[✓] Xcode - develop for iOS and macOS (Xcode 13.2.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Build 13C100
    • CocoaPods version 1.11.2

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] IntelliJ IDEA Ultimate Edition (version 2021.3.2)
    • IntelliJ at /Applications/IntelliJ IDEA.app
    • Flutter plugin version 65.1.4
    • Dart plugin version 213.7228

[✓] VS Code (version 1.62.0)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.29.0

[✓] Connected device (3 available)
    • Darshan's iphone (mobile) • 21150b119064aecc249dfcfe05e259197461ce23 • ios
      • iOS 15.3.1 19D52
    • macOS (desktop)           • macos                                    •
      darwin-x64     • macOS 12.2.1 21D62 darwin-x64
    • Chrome (web)              • chrome                                   •
      web-javascript • Google Chrome 109.0.5414.119

[✓] Network resources
    • All expected network resources are available.

! Doctor found issues in 1 category.

[!] Xcode - develop for iOS and macOS (Xcode 12.3)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    ! Flutter recommends a minimum Xcode version of 13.
      Download the latest version or update via the Mac App Store.
    • CocoaPods version 1.11.2

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] VS Code (version 1.62.0)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.21.0

[✓] Connected device (5 available)
    • SM G975F (mobile)       • RZ8M802WY0X • android-arm64   • Android 11 (API 30)
    • Darshan's iphone (mobile)  • 21150b119064aecc249dfcfe05e259197461ce23 •
      ios            • iOS 14.4.1 18D61
    • iPhone 12 Pro Max (mobile) • A5473606-0213-4FD8-BA16-553433949729     •
      ios            • com.apple.CoreSimulator.SimRuntime.iOS-14-3 (simulator)
    • macOS (desktop)            • macos                                    •
      darwin-x64     • Mac OS X 10.15.4 19E2269 darwin-x64
    • Chrome (web)               • chrome                                   •
      web-javascript • Google Chrome 98.0.4758.80

[✓] HTTP Host Availability
    • All required HTTP hosts are available

! Doctor found issues in 1 category.

you should give it a key
final GoRouter _router = GoRouter(
  routes: <RouteBase>[
    GoRoute(
      path: '/',
      builder: (BuildContext context, GoRouterState state) =>
          const HomeScreen(),
      routes: <RouteBase>[
        // Routes are at the same level as I don't want them stacked
        GoRoute(
          path: 'first-modal',
          pageBuilder: (BuildContext context, GoRouterState state) =>
              const ModalPage<void>(key: state.pageKey, child: FirstModalScreen()),
        ),
        GoRoute(
          path: 'second-modal',
          pageBuilder: (BuildContext context, GoRouterState state) =>
              const ModalPage<void>(key: state.pageKey, child: SecondModalScreen()),
        ),
      ],
    ),
  ],
);

class ModalPage<T> extends Page<T> {
   ModalPage({super.key, ...})
}

Thank you 🙏 @chunhtai giving the Page a key solved the issue 🙂⚡


Add the position_imbeddings param to LlamaAttention.forward

The function LlamaAttention.forward() has a new param.
https://github.com/huggingface/transformers/blob/2e113422b3504fe6de821bb9911b24273b11aa9c/src/transformers/models/llama/modeling_llama.py#L317
The param position_embeddings is calculated here.
https://github.com/huggingface/transformers/blob/2e113422b3504fe6de821bb9911b24273b11aa9c/src/transformers/models/llama/modeling_llama.py#L917-L918

If the parameter is not added here, an error will occur when running the llama model:
TypeError: LlamaAttention.forward() got an unexpected keyword argument 'position_embeddings'

What version of the transformers library raises this issue?

What version of the transformers library raises this issue?

After v4.43.0
https://github.com/huggingface/transformers/blob/v4.43.0/src/transformers/models/llama/modeling_llama.py#L317

PR is good. Can you please reformat your file using pre-commit (guide here: https://intel.github.io/intel-npu-acceleration-library/developer.html#developer-guide) in order to fix CI and also please add the transformers >= v4.43.0 to requirements.txt in order to not break new installs?

Thanks you very much, merging this now


this allows to find the right username when a token is used

@jthiltges I couldn't find you in the list of reviewers, would you mind to give it a look to this PR?

LGTM! It covers the other use of sec->name that didn't get changed in ee92fd8d498c71926067557536c43b09123a6895.


Possible Burn of Funds while updating Data Request

Finding discovered during Red4Sec security audit.
Description
Red4Sec team has detected a high impact vulnerability that in case of occurring could cause the burn of funds due to a bad implementation in upgradeDataRequest() function located in WitnetRequestBoard.sol contract.

Impact
Burn of funds due to a bad implementation in upgradeDataRequest() function.

Steps to reproduce
This fault has been located between lines 166-168 of the contract and its produced because the function does not include a require() that verifies the current status of the request.
The current state of the request should be verified by means of a require, since it could happen that the claim arrives before the user tries to extend the fee, which would burn that fee. In the same way, it could happen with publish, that is why it is necessary to carry out the appropriate checks to revert or not the transaction.

Code Reference
https://github.com/witnet/witnet-ethereum-bridge/blob/cf4ffe9434be79ec29079a3fcaf885adfb213cb8/contracts/WitnetRequestsBoard.sol#L166-L168

Mitigation
Check the status of the contract request to revert or not the fee expansion, and thus avoid unnecessary loss of ether.

Closed by #86


feat(tableheadercell): add collapsing

Collapsing is missing from headercells.

Thanks, we'll also need to update the index.d.ts file in this directory as well as add a test call in TableHeader-test.js.

Nice, just need a common test now.

@levithomason Wait a second there. TableHeaderCell is only simple wrapper around TableCell, so collapsing prop will be pass as unhandled.
So, I think it's job for #1169. It's already done in the typings.

This is true, however, there is also a className and CSS rule for it:
/*--------------
    Collapsing
---------------*/

.ui.table th.collapsing,
.ui.table td.collapsing {
  width: 1px;
  white-space: nowrap;
}

@levithomason It's not the single property that th has in CSS. I still think that it's not best idea to handle collapsing prop in TableHeaderCell while we handle it too in child TableCell.

I see what you're saying, the header cell composes the regular cell.
This plays into #1169.  There is no documentation visibility with the inheritance here.  We could handle this by only adding the propTypes for it, or, pending the babel plugin update for unhandled props, we could spead the cell prop types and update the docs to show "composes" propTypes as well.

Note that this prop is supported as it is passed to the underlying TableCell.  Typings extend the TableCell props as well, so there is support there.   Lastly, we're very close to finishing updates to the doc site to show inherited or "composed" propTypes as well, track #1169.
Closing this issue in favor of those efforts.


Trigger dotnet 1st-run experience in SDK

Fixes #683

I'll let you decide what the correct behavior should be. I do know there is a DOTNET_NOLOGO environment variable that will suppress the "first run" header that is currently displayed when you run dotnet for the first time.

Yes, it seems DOTNET_SKIP_FIRST_TIME_EXPERIENCE has been replaced with DOTNET_NOLOGO.  Using DOTNET_NOLOGO seems like the proper way to handle this because it's explicit on what the intent is.

 I do know there is a DOTNET_NOLOGO environment variable that will suppress the "first run" header that is currently displayed when you run dotnet for the first time.

Yes, it seems DOTNET_SKIP_FIRST_TIME_EXPERIENCE has been replaced with DOTNET_NOLOGO.  Using DOTNET_NOLOGO seems like the proper way to handle this because it's explicit on what the intent is.

After further discussion, it was determined that the appropriate way to do this is to call dotnet help because the act of calling that first command does execute some initialization logic that we want to preserve within the image.  If we were to only set DOTNET_NOLOGO, it wouldn't cause this initialization logic to be executed when building the Docker image.

After further discussion, it was determined that the appropriate way to do this is to call dotnet help because the act of calling that first command does execute some initialization logic that we want to preserve within the image.  If we were to only set DOTNET_NOLOGO, it wouldn't cause this initialization logic to be executed when building the Docker image.


'NKVSource' initializer is inaccessible due to 'internal' protection level

I can't create NKVSource

Fixed in 2.0.1


Remove some duplicate code

Would it be a fair change to do the following?
    if (char === '(') {
      tokens.push({
        type: 'paren',
        value: '('
      });
      current++;
      continue;
    }

    if (char === ')') {
      tokens.push({
        type: 'paren',
        value: ')'
      });
      current++;
      continue;
    }

to
    if (char === '(' || char === ')') {
      tokens.push({
        type: 'paren',
        value: char
      });
      current++;
      continue;
    }

Hence removing ~8 lines.
// Neo

mate, it is a tutorial after all, it should be as clear as possible..

Maybe... I kinda like the repetition from a learning perspective... I don't know how valuable that is though


Project point coordinate to pixel coordinate using MATLAB

Required Info

Camera Model
{D415}

Firmware Version
<IP_ADDRESS>

Operating System & Version
Win 10

Kernel Version (Linux Only)
(e.g. 4.14.13)

Platform
PC

SDK Version
2.33.1

Language
Matlab}

Segment
Robot

Issue Description
Hi !
I'm trying to project Target's 3D point to Pixel coordinate.
I believe there is method for projection , but I cant find any related.
May u let me know any documents or something like that?
I know how to project with intrinsic parameters of camera and I found some of about Intrinsic Params though. Thing is, I'm not familiar with c++ codes...... and Its pretty hard to understand wrappers for me.
Is there any example codes?
+Can i get depth data which is perpendicular to target? (not a distance)
My questions are.

Is there any method for projection using MATLAB?
Is there any sample code to get Intrinsics parameters using MATLAB?
Can i get depth data which is perpendicular to target?(not a distance)

Thanks in advance !

MATLAB has a built-in worldToImage function for projecting 3D world points to a 2D image.

https://uk.mathworks.com/help/vision/ref/worldtoimage.html

I hope the link below will be useful in getting intrinsics information using the MATLAB wrapper.

https://github.com/IntelRealSense/librealsense/issues/3735

If by 'perpendicular to target' depth you mean measuring the distance between two points, built-in functions in MATLAB may again be able to help with this.

https://uk.mathworks.com/matlabcentral/answers/16848-how-to-find-distance-between-two-points

I got u. Thanks a lot !


Specify a platform in the Molecule test configuration

💡 Summary
We should consider specifying a platform in our Molecule configurations.
Motivation and context
This would both allow us to test multiple platforms in a given configuration (amd64 and aarch64/arm64 for example) as well as ensure that the desired platform is tested regardless of the underlying hardware. The former would allow us to ensure our roles are compatible with AWS Graviton2-based instances for our own purposes. The latter would help ensure that with the rollout of Apple silicon (ARM) that the amd64 platform is still tested explicitly.
Implementation notes
Support for this was added in https://github.com/ansible-community/molecule-docker/pull/122 which was included in molecule[docker] v2.0.0.
Acceptance criteria

[ ] Molecule testing is enabled for non-amd64 platforms.
[ ] Molecule testing works even when run on non-amd64 hardware.

@mcdonnnj - do you think that the arm64v8 platform should be handled as a separate scenario, or should we double the number of platforms served by the default scenario?

@jsf9k I think increasing the number of platforms served by the default scenario makes the most sense for this specific change. However, I'm not opposed to treating different underlying architectures as different scenarios if you think that would be a better implementation.

@jsf9k I think increasing the number of platforms served by the default scenario makes the most sense for this specific change. However, I'm not opposed to treating different underlying architectures as different scenarios if you think that would be a better implementation.

I will try to include them in the default scenario, but there may not be sufficient disk space on the GH Actions runners for that.


Rodlike

a) Fix bug in calculation of rodlike micelles chemical potential difference. Properly weigh deformation free energy of contributions from spherical endcaps / cylindrical part by aggregation number
b) Implement derivatives of chemical potential difference with respect to radius of spherical encaps / radius of cylindrical part. Test via finite differences against prior implementation
c) Implement high level functionality to optimise via a root search of the jacobian programmed in b) and the minimisation of the chemical potential difference. There is a problem when using the second as the result is dependent on starting values ( there might be a slight jump in the objective function). Resolution: 1) use root search algorithm 2) use hot_start, i.e. the radii from the last iteration is used as starting value. As the starting values problem is pronounced at high aggregation numbers this can be used to progress along aggregation number (as is usually done with the sums we will want to evaluate later).

Implement Jacobian with boundaries, add optimisation options, fix bug in deformation free energy.
Deformation free energy for rodlike micelles is now weighted acc. to occupation of sphere/rod. Derivatives of chemical potential differences implemented with respect to radius of spherical endcap / radius of rod. Boundaries were implemented to guide the optimisation when going into (very) unphysical regions. High level choice between minimisation of chemical potential difference and root finding of jacobian given, but second as default along with hot start (using previous radii) as this gives easiest/best results.


@helia/interface and @helia/interop don't generate /dist folder on install

/dist should be generated with compiled js files for depending packages to be able to consume the library. It looks like they are not properly being generated on npm install

This actually seems to only happen within the helia monorepo. The /dist directory is created correctly when installing as a dependency of another package 🤔

I believe the dist folder should only be created during the build step.

We can close this, I think I was having issues with my local machine


Client can not connect if there are inherited retained messages

If there are retained messages and the client is not connecting with CleanSession, it will result retained messages sent before the Connack.
In the inheritClientSession, it will call publishRetainedToClient before it has a chance to sendConnack.
https://github.com/mochi-co/mqtt/blob/300152413c0e3a35741329068cfe12c5c502274f/server.go#L346
In the inheritClientSession, it can make a copy of the existing subscriptions, but process them after it completes sendConnack.
If you like, I can create a PR.

Great discovery - I think you are correct. Yes, send over a PR and let's get it fixed!
Thank you very much @thedevop

Fixed in v2.1.6


 Working on a few performance improvements for vdb but will be nice to hit trivy or grype kinda performance this year.

4.0.0 released, which uses the new improved vdb 5.0.1. Let's see how this version performs in the wild now.


date fields

Hi.
I am having issues when working with MySQL databases because of the function GetTimeZoneOffset.
It can be a good idea to configure how you want the date time result, and give the chance to offer data time in other format.
After modifying this lines, everything works fine!
I added this private function:
private Function BuildDate(fecha)
tmp = ""
if IsDate(fecha) then
dia = day(fecha)
mes = month(fecha)
ano = year(fecha)
hora = hour(fecha)
minuto = minute(fecha)
segundo = second(fecha)
if len(hora) = 1 then hora = "0" & hora
if len(minuto) = 1 then minuto = "0" & minuto
if len(segundo) = 1 then segundo = "0" & segundo
if len(dia) = 1 then dia = "0" & dia
if len(mes) = 1 then mes = "0" & mes
tmp = ano & "-" & mes & "-" & dia & " " & hora & ":" & minuto & ":" & segundo
end if
BuildDate = tmp
end function
Now I have the time "yyyy-mm-dd HH:MM:SS"
You could add some properties in order to return functions using timezone or nor!

It's a nice idea to have an option to choose the date format, but I think it will not add much to this project.
Since this project aims at create standard JSON, the standard for JSON dates is "yyyy-mm-ddTHH:MM:SSZ", where T is a literal and Z is the time zone.
You can see this standard definition on https://en.wikipedia.org/wiki/ISO_8601
What are you trying to do when this date format causes you problems?

You're right about the format, but I do have problems with the dates when I use MySQL as database, and I don't know why.

I will take some time to investigate this.
Do you get errors while trying to use the LoadRecordset(rs) and LoadSingleRecord(rs) methods?
What problems do you have?

LoadRecordset(rs)
It give me an error on line 705 error '80041010'

I've done a test and the problem seems related to how this class obtains the time zone information from Windows. Since this works on my machine, I could not simulate the error yet.
What version of Windows are you running?
Does this work when you add a date value to any property except when coming from MySQL?

I am running Windows XP

I'm testing some other methos to obtain the timezone. As soon I get something that can replace the actual implementation I will ask you to test it on your machine. OK?

Sure, no problem!

I have the same problem. In my environment it's a security issue. On my local machine there is no problem, but remote i get an error (function GetTimeZoneOffset, get winmgts object). It seems to be a security problem (Unauthorized).
Unfortunately, I can't change the security settings on the production server. Have you figured out an other way, yet?

Hi.
Thank you for the info.
This is a known issue and I will solve it soon. I have to try an alternate method to get the timezone info.
I will have some time to fix this by the next few days.


AJ-1359: Wire up shell verb for run_postgres.sh

Quickly access local postgres prompt.
Usage:
./local-dev/run_postgres.sh shell

Maybe add a line about it to the README so people know it's an option?

Added a section to the README


MaxPool1D

Feature description
Add MaxPool1D  layers.

I'd love to contribute to this project, is this issue already in progress or can I give it a try?

@CaioPiccirillo I have assigned it to you.

Completed per https://github.com/burn-rs/burn/pull/602


Can't worked sometimes.

Just like this:

I have the same issue, almost daily, which make it almost unusable. The only way to clear the error is to disable/enable the extension.

If you can consistently reproduce, can you provide more info and possibly a concrete steps to reproduce the issue?

Unfortunately the issue is frequent, but I don't yet know how to trigger it. Will post back any findings.

Disconnect from the wifi, wait for the icon to become red, connect to the internet again. The icon will stay in this state until you click it.

Yes I have that issue too. But regularly, even clicking on the icon doesn't refresh its state. So it looks like there are 2 bugs, one which is probably easy to fix (refresh display immediately when connectivity is regained), and maybe another more subtle one.

I would really appreciate you guys taking a look at https://github.com/sindresorhus/notifier-for-github-chrome/pull/120 and reporting if it helps or not.
Make sure to run
npm run build

to compile the extension

Should  be fixed in 3.0.3, feel free to reopen if this still happens

@YurySolovyov 3.0.3 works well，Great job, Thanks. :smile:


Max_redirect = 0; Location header missing

Hi,
Requests ver: 2.11.1
I'm using a session object (s) to make a POST to a specific URL:
r=s.send(prepared)
I expect this to return 302, which is happening.
I set s.max_redirects=0 because I don't want Requests to automatically visit the new URL.
So, I promptly receive a TooManyRedirects exception, which is good.
However, in the exception handler, I'm unable to get hold of the header 'Location'.
The response object itself is empty.
I debugged it and saw that the Location header was captured correctly. But, when the exception is thrown, it's all gone.
Thanks!

Hey @arao-nnl, in order to get the behaviour you're looking for, you'll need to use a slightly different mechanism. max_redirects is intended to raise an exception halting the request in the event of a redirection loop, or excessive redirects.
For your issue of trying to simply halt before a redirect is performed, I suggest using the allow_redirects parameter. This will retrieve the 302 and then leave the object untouched until you decide how to proceed (such as only reading the Location header).
s = requests.Session()
r = requests.Request('GET', 'http://httpbin.org/redirect-to?url=get')
resp = s.send(r.prepare(), allow_redirects=False)
loc = resp.headers['Location']


Ability to run ocp-customization role as standalone playbook

Currently ocp-customization runs as part of install playbook. There should be a way to run ocp-customization as standalone playbook for customizing an installed OCP cluster

we could implement ansible tag. This will allow to run only this part if needed

@bpradipt
A quick fix for this one (as I had to use it a lot yesterday). Tell me if this is what you expect.
to run it:
ansible-playbook -i inventory -e @install_vars.yaml playbook/customization.yaml

yes @schabrolles this is what I use as well


Integration attempts to retrieve task data with wrong email address

The integration seems to work fine in the current version of Unity DevOps Version Control (previously PlasticSCM), but there is some behaviour that seems unintended.
My setup:
Logged into Unity Version Control with my Unity ID, with email address A.
Codecks account uses email address B. I entered this into the Preferences > Issue Trackers window inside UVCS/Plastic according to the image shown at point 4 of Getting Started in the integration readme.
The integration seems to attempt to fetch the task data from Codecks using email address A, instead of email address B. It then returns an error, stating "Failed to find user by mail: [email address A]". I believe that the integration should not be using email address A here, but instead should use email address B as entered in the Preferences > Issue Trackers window.
My colleague uses only 1 email address for all of this, and for him the integration works as expected.
Thanks in advance!

Thanks for bringing this up! Sorry for not being quicker, I kind of didn't have notifications enabled. ^^
Anyway, I'll set the project up to work on macOS first, so I can work on it again.

I can confirm the issue on macOS, Unity DevOps <IP_ADDRESS>80.
Logged in with my Unity ID.
Setup a Codecks account with a different mail.
When I try to create branch it says "Failed to find user by mail: xxx" where the mail is my Unity ID and not the intended Codecks mail which was set up in the settings.

No problem! I circumvented the issue on my side by changing the email address associated with my Unity ID to the same company email address I already used for Plastic.
That opened up a whole other can of worms on Unity's side (losing access to my admin account and all my invoices) but fortunately Unity support helped me resolve that.

Glad to here, I'll keep this one open and try to find a solution nevertheless. Feel free to unsub if you feel spam. :)
One possible workaround (for other users that might be reading) at the moment: In the CreateBranch window, there's an option called Display pending tasks from all users. That will at least show the entire task list, which then can be filtered by issue title or assignee (email).

Now the issue:
In the API, Plastic passes us the "assigneeEmail" which the extension is supposed to use for filtering the list of tasks. However, the passed assignee is the one from Plastic/Unity. It seems there's no direct way to change this behaviour easily.
I might find a solution by retrieving the config value from the extension, or I'll send a bug report/feature request to Unity. But yeah, basically Unity assumes that the mail used in their app is the same as in the issue trackers (as is probably the case most of the time for company accounts).


Cloning a revision from a template revision with latest K8s versions gets saved without the satisfies condition

Rancher Server Version - v2.3.1-rc2
Steps :

Create a Template Revision R1 with K8s version set to Latest 1.15 (or Latest 1.16 or Latest 1.14 or Latest 1.13)
Do not set override. This revision gets saved with questions and the satisfies condition is set in the template as below

"questions": [
{
"default": "1.15.x",
"max": 0,
"maxLength": 0,
"min": 0,
"minLength": 0,
"required": false,
"satisfies": ">=1.15.0 <1.16",
"type": "string",
"variable": "rancherKubernetesEngineConfig.kubernetesVersion"
}
],

Create another revision R2 by cloning this template revision R1(OR creating a new revision from Default). This revision gets saved as  a revision with question but the satisfies condition does not exist any more.

"questions": [
{
"default": "1.15.x",
"max": 0,
"maxLength": 0,
"min": 0,
"minLength": 0,
"required": false,
"type": "string",
"variable": "rancherKubernetesEngineConfig.kubernetesVersion"
}
],

Available in UI tag 2.3.17

Tested with rancher v2.3.1-rc2 with the UI tag 2.3.17
Case 1:

Create a Template Revision R1 with K8s version set to Latest 1.16 without setting override.  This revision gets saved with questions and the 'satisfies' condition is set in the template.
Create another revision R2 by cloning this template revision R1(OR creating a new revision from Default). This revision gets saved as a revision with question and the 'satisfies' condition is set correctly as below:

questions": [
{
"default": "1.16.x",
"max": 0,
"maxLength": 0,
"min": 0,
"minLength": 0,
"required": false,
"satisfies": ">=1.16.0 <1.17",
"type": "string",
"variable": "rancherKubernetesEngineConfig.kubernetesVersion"
}
]

Case 2:

Create a Template Revision R1 with K8s version set to Latest 1.15 without setting override.  This revision gets saved with questions and the 'satisfies' condition is set in the template.
Create another revision R2 by cloning this template revision R1(OR creating a new revision from Default). This revision gets saved as a revision with question and the 'satisfies' condition is set correctly as below:. questions": [
{
"default": "1.15.x",
"max": 0,
"maxLength": 0,
"min": 0,
"minLength": 0,
"required": false,
"satisfies": ">=1.15.0 <1.16",
"type": "string",
"variable": "rancherKubernetesEngineConfig.kubernetesVersion"
}
]


Deleting diff comment lefts buttons toolbar

Description
At the Pull request page,
at the Files Changed tab,
deleting a comment isn't  visually complete.
The buttons toolbar is left (see the screenshot).
Screenshots

Gitea Version
1.23.0+dev-567-g9df5ddaf44
Can you reproduce the bug on the Gitea demo site?
Yes
Operating System
No response
Browser Version
129.0.6668.100 (Official build), (64 bit)

It would be better to mention that to reproduce issue, the deletion of comment should be happen in conversation tab.

Thanks!

Should this affect 1.22?

@lunny maybe yes the error prone line was wrote 3 years ago


Add new memory cells.

DO NOT MERGE until the following issues are fixed:

[x] cxxrtl doesn't yet support the new features
[x] needs tests for init/reset value handling in various passes, and really needs tests for wide port handling
[x] needs CHANGELOG entries
[x] the manual needs updating

Also, we still don't have a new transparency mask model.  To avoid creating _v3 versions of the cells, it would be good to deal with this as well before this PR is merged.
There is also (probably) going to be a $meminit_v2, but that's independent from this PR.

New version, now includes transparency mask, and thus depends on #2904

CHANGELOG and manual now done; tests will land together with new transparency recognition in a future PR

Shortening this PR to just the new cells + proc_memwr changes; the other two commits will be reordered and land in different PRs so they can be tested properly.

(the tests became part of #2930, #2928, and #2925 in the end)


[luigi.contrib.pyspark_runner] SparkSession support in PySparkTask

Description
luigi.contrib.spark.PySparkTask now supports spark_session as a first argument in main().
To use it just enable pyspark_runner.use_spark_session = True in luigi.cfg
This change allows users to work with spark_sesion it in their jobs on Apache Spark 2+ version.
Motivation and Context
Apache Spark 2.0.0 have introduced a new entrypoint object which is SparkSession instead of SparkContext in previous releases.
luigi.contrib.spark.PySparkTask in its main function supports only sc argument which doesn't allow you to use spark session object.
Have you tested this? If so, how?

I've added unit tests into my PR
I've checked locally that this works as expected (for both old-style and new-style syntax)

@dlstadther
@honnix
@ntim
please, take a look at that

You probably want other Spark users to comment on the usefulness of this PR. :)

You probably want other Spark users to comment on the usefulness of this PR. :)

yes, but none of them (PysparkTask contributors) seem to be online last year except @ntim and you @Tarrasch

@b2arn
PTAL

@Tarrasch done

@honnix
@dlstadther
PTAL

@GoodDok
@mrk-its
PTAL as well


Allow for syntax highlight customizability.

Check for existing issues

[X] Completed

Describe the feature
Allow for custom syntax highlighting definitions; this is essentially and option to allow user to create their own syntax highlighting themes. This is somewhat related and extends on #1003 , but I feel this ticket is more general and to the point.
If applicable, add mockups / screenshots to help present your vision of the feature
One of good example is ability to change:

CODE SELECTION
or SELECT ALL FIND INSTANCES

For example: yellow font background with black letters, etc. This allows/helps enhance visibility of those find instances to stand out. I can see a similar highlight is already available in ZED, but currently we lack customizability.
Sample screenshot:

Internally we already have this:

Externally, we will eventually publish a package that allows people to create their own themes. You can read a bit more about our plans here: https://docs.zed.dev/configuration/themes
We have some work to do before the theme system is stable enough to provide others access to writing their own themes.


Update s3, sdk-core, sqs to 2.16.50

Updates

software.amazon.awssdk:s3
software.amazon.awssdk:sdk-core
software.amazon.awssdk:sqs

from 2.16.26 to 2.16.50.
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "software.amazon.awssdk" } ]

labels: library-update, semver-patch

Superseded by #163.


RealSense-Matlab: multiple device

Dear users
I'm new in realsense-matlab interface. I tryed the simple example to acquire point clouds, and they worked fine so far. Now I want to use more than one sensor, and I want to chose which one to use for each acquisition (timing is not an issue so far). How can I select which device to stream for in matlab? (I'm using D415).
Thank you for your help!
This is the code I'm using to start treaming from arbitrary device:
pipe = realsense.pipeline();
pointcloud = realsense.pointcloud();

%%
% Start streaming on an arbitrary camera with default settings
profile = pipe.start();
figure('visible','on');  hold on;
figure('units','normalized','outerposition',[0 0 1 1])

    CLOUDS={};
    nc=40;
% Main loop
for i = 1:nc

    % Obtain frames from a streaming device
    fs = pipe.wait_for_frames();

    % Select depth frame
    depth = fs.get_depth_frame();
    %color = fs.get_color_frame();

    % Produce pointcloud
    if (depth.logical())% && color.logical())

        %pointcloud.map_to(color);
        points = pointcloud.calculate(depth);

        % Adjust frame CS to matlab CS
        vertices = points.get_vertices();
        X = vertices(:,1,1);
        Y = vertices(:,2,1);
        Z = vertices(:,3,1);

        plot3(X,Z,-Y,'.');
        grid on
        hold off;
        view([45 30]);

%             xlim([-0.5 0.5])
%             ylim([0.3 1])
%             zlim([-0.5 0.5])
        xlabel('X');
        ylabel('Z');
        zlabel('Y');

        pause(0.5);

    CLOUDS{i}=[X Z -Y]*1000;
    end
    % pcshow(vertices); Toolbox required
end

 % Stop streaming
pipe.stop();

take a look at the config object. You can pass it to pipeline.start to request a specific device / specific streams and settings.
e.g.
cfg = realsense.config();
cfg.enable_device('<serial number>');
cfg.enable_stream(realsense.stream.depth, 1280, 720, realsense.format.z16);
pipe.start(cfg);

Thank you for your answer, it solved the problem!
Now I'm facing another issue, with SR300 in a multi-sensor setup: I want to switch them on and of sequently, to avoid interference between the sensors' field of view. So far i managed to do so by changing the laser power from 0 to max. Anyway, this procedure results slow, since a pause is needed to allow the sensors to set after the laser power is changed: Is there a faster way to control this simulatneous acquisition of the same scene without sensors cross-talk?
Thank you very much!

Hi,
Will you be needing further help with this? If we don’t hear from you in 7 days, this issue will be closed.
Thanks


Renaming suggestion for "shorting_target"

Following your comment in this code snippet, I would like to suggest an alternative to the name of the "shorting_target" attribute.
I suggest "min_free_space_path_shorting" as it explains both the effect of this attribute and the consequence for the path name.
I know it's kinda long, but to me this seems like a good compromise.
What do you think about this name?

I started a pull request which didn't pass the necessary tests. I'm not really experiencing with writing those test configs, so help would be greatly appreciated.


Preview deployments: Github secrets not available in PR forks

Storybook preview was not built during a fork PR. I suspect this is because github secrets are not available from the merge context.
Think we need to change the GH event to pull-request-target.

https://securitylab.github.com/research/github-actions-preventing-pwn-requests/


Update ActiveRecord Syntax (Deprecated Finders)

From @benjaminwood on April 10, 2018 19:19
All dynamic methods except for find_by_... and find_by_...! are deprecated.

48 occurrences of find_all_by_
150 occurrences of find_or_create_by_.
87 occurrences of find(:all....)
154 uses of :conditions => in various contexts (lots of scopes with conditions)
43 occurrences of :order =>

Under Rails 4, the activerecord-deprecated_finders gem can be used to but our recommendation is to resolve these issue in advance of the 4.x upgrade.
Copied from original issue: hintmedia/rigse#14

The plan of attack here is to:

Discover which occurrences are hit by the test suite
Update syntax for those that have test coverage
Create a report/list of occurrences that are not hit by the test suite for @scytacki to review before taking next steps.

My thought is that we can discover which occurrences are hit by the test suite by replacing them with an exception. Upon running the tests, any occurrences that do not raise the exception are not hit by the test suite. Kind of like mutation testing. :smile:
Might be easier to use simple-cov? Not sure.

With the work on scopes in #473 I have cleaned up a number of the above implicitly, given that the generated specs I made weeks ago cover scopes I know they should have test coverage. So once PR #606 is merged I can begin to tackle the remainder of the above.
First I would change those occurrences in spec modules (*spec.rb) - since those are 100% executed. Then I can embark on the process of only changing those covered by a spec. using a technique similar to what @benjaminwood described above.

As of the today:

40 occurrences of find_all_by_
110 occurrences of find_or_create_by_.
70 occurrences of find(:all....)
107 uses of :conditions => in various contexts (lots of scopes with conditions)
7 occurrences of :order => fixable

Gotcha, thanks!

Down to 10 find_or_create_by_ occurrences - 2 in comments, 1 in migrations, leaving only 7 of those to review. However I have one cucumber spec that is failing. So I need to trace that.

As of today:

7 occurrences of find_all_by_ (4 in site_notices_controller, 2 in inports_controller, 1 in fixups.rake)
6 occurrences of find_or_create_by_ in various controllers and process_external_activities_job.rb
1 occurrence of find(:all) in rig_se model folder (ignore?)
4 references to :conditions all in has_many or has_one (change when we get to Rails 4.0)
25 occurrences of :order => all in has_many (change when we get to Rails 4.0)

I could tackle trying to add more coverage in the controllers, etc. to address the remaining find_issues. THoughts?

@scytacki your thoughts on next steps?

I believe this is as addressed as it will be until converting to Rails 4.0. @benjaminwood feel free to close if you concur.

Agreed! Nice work.


Versioning system

Hi @ankane and thank you for this action 👍
Having recently had to deal with cross-platform MongoDB in GitHub Actions and following GitHub’s decision to default to having the service stopped in Windows (which you supposedly fixed after #1), the approach you take in this action seems the most relevant to me: using the preinstalled MongoDB servers instead of installing them or using Docker sounds much more efficient.
However, I am a bit confused by the versioning system used on this action. After you fixed #1, I see no version bump. Versioning is an important way to ensure consistency, and without it, I don't see us using this action as it is. Do you currently version this action? Do you have plans to do so? 🙂

Hey @MattiSG, thanks for the suggestion. I may adopt more traditional versioning in the future (which shouldn't affect the recommended usage of ankane/setup-mongodb@v1), but for now, the v1 branch contains the latest changes, which will be bumped to v2 for breaking changes.

Than you @ankane for your fast reply! I understand this means you do not intend to publish this action on the GitHub Marketplace, since versioning is a prerequisite. This would bring more visibility and contributors to this really useful action. Had I found it earlier, it could have saved me significant effort 😅
While we would prefer to contribute to this repo, considering this choice of yours and our need @OpenTermsArchive to abstract away from MongoDB setup cross-platform while maintaining reproducible history, we are considering forking this action and maintaining it with proper versioning and publishing. I wanted to check in with you before going further with that decision 🙂


Enforce some kind of timeout for selected tasks

There is no "timeout" for ansible tasks. We therefore must work around
that lacking feature using async and related poll.
With those small changes, the node list gathering will:

run for 10 seconds
show a "ASYNC POLL on..." message every 2 second
in case of failure, retry for the set amount

In the end, it can take up to (10 * COUNT * 2) time before failing
for good (2 being the "delay" between retries).
We may need to adjust the "async" value.
As a pull request owner and reviewers, I checked that:

[X] Appropriate testing is done and actually running

/lgtm


Added back to top button

Added back to top button on the website

@arghadipmanna101 Please add gssoc24 and level2 labels

OK man 😊. Thank you for your contribution .

@arghadipmanna101 Please add gssoc24 and level2 labels

OK man 😊. Thank you for your contribution .

Thank you 🙏

@arghadipmanna101 Please add me in assignees as it is important for the leaderboard


Add an IMU class with easy reading and writing

Doesn't yet include DMA as it won't make a massive difference and there's more important things atm.
Includes tests in test_hw.hpp, and instructions at the top of imu.h.
Still needs to be tested once more since I've refactored it (which shouldn't make a difference, but just in case), but I can't do that atm.

Initial review. Deleting the .mxproject (or any of the .cproject files, etc) caused a lot of problems when trying to get cube to compile the binaries. What was the reason for deleting these files? I'd rather have them in the repo so when I git clone anytime for any reason I can just start developing and building stuff right away

Can you connfirm that the .mxproject was needed? My testing for #5 didn't show that, but the .project and .cproject were needed. I changed that in the other PR but must have forgotten here


Replace momentjs with dayjs for Servers.Web

Summary
This is the first of several PRs for #3875.  This one replaces momentjs with dayjs for Servers.Web in Dnn.AdminExperience.

Can we update the license documentation to include this new third party to keep compliant.

My suggestion is a bit beyond the scope of this PR but what do you guys think if we use https://classic.yarnpkg.com/en/docs/cli/licenses/ to generate all the mentions for the stuff we grab using npm. If we are in agreement, I can work on a PR that would do this on build... It would no cover stuff we use without npm but that would be a lot less maintenance for what does.

Possibly the generate disclaimer option could work. But for the interim id like to get it added here the normal way.

@mitchelsellers yes, the license stuff is on my list.  This is the first of many PRs to switch from moment.js to dayjs.  Do you want the license mention to be added to this specific PR?  Also, I have seen license information in multiple places, so at this point I am not clear where it should be based on the usage context.
@valadas I really like your idea and it would really help to have this automated like this.  To me, the sooner we do that, the better off we'll be covered for attribution.

Just needs to be in the master list of licenses for the project.
No specific place for this PR

Just needs to be in the master list of licenses for the project.

@mitchelsellers I just pushed a commit to put it where I think it needs to be.  Let me know if that is not the correct place.


how to choose the parameter num_epochs

first, thanks for your excellent project. It's very friendly for beginner.
I have noticed that on dog-vs-cats dataset the hyper parameter of num_epochs is 100 which is bigger than that on CIFAR dataset. CIFAR dataset has more data and more classes. So why we need to train out net more on this dataset?How can I choose a proper hyper parameter of num_epochs. Looking forward for your response.

Hi there.
That's an interesting question. So for this project, I didn't do extensive hyperparameter tuning. If I have some time this summer, I wanted to modify the codes a bit including visualizations of the loss etc. like I did for the class I was teaching this semester: https://github.com/rasbt/stat453-deep-learning-ss21/blob/main/L14/1.1-vgg16.ipynb

Yes, this is correct, depending on the architecture, there may be more parameters involved (e.g., if you have fully connected layers). There are a few architectures that have global average pooling layers only (no fully connected layers) where the number of parameters may be the same; however, the convolutional operations will take more time because you have to move the kernel over the image in more steps.
Also, yeah, it can increase the training time. You are right, if the loss doesn't change that much anymore, training can probably be stopped.


Destruction of postgres module causes error.

When using the following config, I get an error when using terraform destroy: Error, failure waiting for deletion of db-user in my-db
module "postgres" {
  source  = "GoogleCloudPlatform/sql-db/google//modules/postgresql"
  version = "3.1.0"

  project_id = var.project
  region  = var.region
  name    = local.instance_name
  db_name = var.db_name

  database_version = var.postgres_version
  tier = var.machine_type

  user_password = random_password.password.result
  user_name     = var.user_name

  ip_configuration = {
    require_ssl = true
    ipv4_enabled = true
    authorized_networks = []
    private_network = null
  }
  backup_configuration = {
    enabled = true
    binary_log_enabled = false
    start_time         = "04:00"
  }

  maintenance_window_day = 7
  maintenance_window_hour = 7
  maintenance_window_update_track = "stable"

  database_flags = [
    {
      name  = "autovacuum_naptime"
      value = "2"
    },
  ]

  zone = var.zone
}

Config
Terraform v0.12.21

This is likely a provider issue, please file it there.

Ok, filed to provider.


release v1.15.1

Description of the change
Release v1.15.1
Type of change

[ ] Bug fix (non-breaking change that fixes an issue)
[ ] New feature (non-breaking change that adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Maintenance
[x] New release

Checklists
Development

[ ] Lint rules pass locally
[ ] The code changed/added as part of this pull request has been covered with tests
[ ] All tests related to the changed code pass in development

Code review

[ ] This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
[ ] "Ready for review" label attached to the PR and reviewers assigned
[ ] Issue from task tracker has a link to this pull request
[ ] Changes have been reviewed by at least one other engineer

Pull Request Test Coverage Report for Build<PHONE_NUMBER>8
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 92.097%

Totals

Change from base Build<PHONE_NUMBER>5:
0.0%

Covered Lines:
1480

Relevant Lines:
1607

💛  - Coveralls


Doc landing page

Update the landing page for the documentation to be more in line with other documentation sites.

Documentation preview available at: https://linuxcontainers.org/lxd/docs/pr.10728/


proposal: runtime/debug: delete Stack

Now that runtime.Stack exists, its value added is pretty small. Maybe for Go 2.

In Go 1.6 we changed debug.Stack to be a convenience wrapper around runtime.Stack, for #12363. Whereas runtime.Stack requires passing an allocated buffer at the call site, debug.Stack takes care of allocation and also of making sure the buffer is bug enough to hold the complete stack.
Leaving this open but note that now debug.Stack is actually nicer than runtime.Stack. If we're going to remove one, it might make sense to unexport runtime.Stack instead.

That sounds like the right answer now.

debug.Stack only returns the current goroutine, though.
If runtime.Stack is removed, how would one implement, say, a /debug/goroutinez debug endpoint?


4253190    [Microsoft.Update.Admin] Resources missing from OpenApi Spec

Latest improvements:
MSFT employees can try out our new experience at OpenAPI Hub  - one location for using our validation tools and finding your workflow.

Contribution checklist:

[ ] I have reviewed the documentation for the workflow.
[ ] Validation tools were run on swagger spec(s) and have all been fixed in this PR.
[ ] The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

[ ] Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
adding/removing APIs.
adding/removing properties.
adding/removing API-version.
adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

[ ] If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Please follow the link to find more details on API review process.

Can one of the admins verify this patch?

Automation for azure-sdk-for-go

Automation for azure-sdk-for-js

Automation for azure-sdk-for-python
Nothing to generate for azure-sdk-for-python

Automation for azure-sdk-for-ruby

Automation for azure-sdk-for-java

If you haven't taken a look at our new onboarding experience at OpenAPIHub, it's a convenient way to create your PR when you're copying from an existing API version or when you're editing your existing specs. If you have any feedback or questions, feel free to use the feedback button on top of the site for help. Thanks!

LGTM. Let's wait for ARM feedback.

@yudomsft Do you want me to merge? Is the service deployed?

@kpajdzik Please merge. This API is for Azure Stack only so there is no concept of "deployed".


Sitecore 10.0.1 - Custom Images- Not able to bring up the containers

HI Team, I am trying to use the Custom-Images with Solution Service As-Is, but not able to bring up the containers. I did not do any customization and using the exact same solution.
When tryig to bring up the containers, I see below error message in the CM and xConnect Containers.
Service 'w3svc' has been stopped
APPCMD failed with error code 259
Failed to update IIS configuration
[LOGMONITOR] INFO: Entrypoint processs exit code: -2147467259.
Could you please help me on getting this resolved as we are planning to start the Dockers development.

This sounds like a known issue w/ LTSC2019 and 10.0.1, but please use community or official support channels for troubleshooting, and GitHub for bug reports or feature requests for the examples.


Audit issue

Your library dependency: "glob-parent" has an audit vulnerability of "Regular expression denial of service" that has been patched in >=5.1.2

no, it doesn't. Proof: https://github.com/paulmillr/chokidar/blob/master/package.json#L18


switch to ns

uses openshift namespace an enmasse provisioning services "namespace" param

verified on my cluster. Could we merge and create a new release


require(module) does not always return module

Hi, I've noticed this bug a couple times but I finally managed to figure out how to reliably recreate it. The way aniseed uses package.loaded['module'] to set the value of require('module') seems to be unreliable. In cases where the compiled lua file has an actual return statement at the end the returned value overrides the value set in package.loaded.
Here's a small example
; ---------------
; fnl/modtest.fnl
; ---------------
(module modtest
  {require {a aniseed.core}})

(def x 1337)

(defn- do-something [z] z)

(do-something {:x 420})

-- ---------------
-- lua/modtest.lua
-- ---------------
local _2afile_2a = "fnl/modtest.fnl"
local _2amodule_name_2a = "modtest"
local _2amodule_2a
do
  package.loaded[_2amodule_name_2a] = {}
  _2amodule_2a = package.loaded[_2amodule_name_2a]
end
local _2amodule_locals_2a
do
  _2amodule_2a["aniseed/locals"] = {}
  _2amodule_locals_2a = (_2amodule_2a)["aniseed/locals"]
end
local a = require("aniseed.core")
do end (_2amodule_locals_2a)["a"] = a
local x = 1337
_2amodule_2a["x"] = x
local function do_something(z)
  return z
end
_2amodule_locals_2a["do-something"] = do_something
return do_something({x = 420})

require('modtest').x --> 420 !! (expected value is 1337)
require('modtest') --> { x = 420 }

This can be fixed by using an aniseed def(n)(-) at the end of the module or just putting *module* after everything.
(module modtest
  {require {a aniseed.core}})

(defn- do-something [z] z)

(do-something {:x 420})

(def x 1337)

require('modtest').x --> 1337 :)

This is most likely to cause issues when the last call in the module is a side-effecting function that happens to have a return value

I like the idea of putting a *module* at the end of the file 🤔  I'll have a look at that! Sorry for the issue! I've run into it once I think then I just put a nil at the end of the file which will also fix it. This bug is basically if your module ends with a table, if you put nil or anything else it should be fine.

Wrapping the entire file in this macro (after the (require-macros ...) that the compiler inserts) could be a solution. It should allow users to compile files that aren't aniseed modules while just appending *module* to everything would break that. I had a little trouble modifying the compiler but I'll see if I can get something working and open a PR. The macro implementation might also need a few safety checks, let me know what you think.
(macro wrap-module [...]
  (let [body# [...]
        last-expr# (table.remove body#)]
    (table.insert body#
      `(let [original-return# (do ,last-expr#)]
         (or ,(sym "*module*") original-return#)))
    body#))


Set language level to 17, 19 for integration tests

Type of change
Select the type of your PR

Enhancement / new feature

Description
Sets the language level to 17 for main and test in all modules except integrationtests. integrationtests relies on an 18+ feature to configure in a custom InetAddressResolver so test clients can resolve foo.multitenant.kafka:9192 and bar.multitenant.kafka:9192 to a localhost ip.
Additional Context
The split language levels across test and main sources has been a pain for development, several of us use IDEA and it doesn't work smoothly having different language levels for main and test. It hungs together in an experimental maven import mode but recently we found an issue where test resources were not on the classpath when running some new unit tests. Moving to a more conventional setup with the same language level for test/main per maven module should make it smoother.
We want to target a LTS java version as a minimum runtime version.

I ran some basic perf tests as laid out in the benchmarking.md locally to make sure they were run on same hardware. I also ran with a slight variation using a fixed message from file instead of random data.
The direct to broker cases are where I pointed the load tester at kafka instead of kroxylicious so we have a point of comparison. Apart from that the only variable changed for each test case was the java version used to run kroxylicious.
Note: all results are from a single laptop without any attempt to isolate the resources used by the client/broker/proxy, this was a crude test to see if there was any regression.
Randomised 1024 bytes messages from the kafka producer test client
 bin/kafka-producer-perf-test.sh \
    --topic perf-test \
    --throughput -1 \
    --num-records 10000000 \
    --record-size 1024 \
    --producer-props acks=all bootstrap.servers=localhost:9192

case
records/sec
avg latency
max latency
50th
95th
99th
99.9th

direct to kafka
85822
1.74ms
232.00 ms
0 ms
1ms
50ms
191ms

java 11 runtime at proxy
86772
2.20 ms
469.00 ms
0ms
1ms
64ms
223ms

java 17 runtime at proxy
88794
1.49 ms
221.00 ms
0ms
1ms
41ms
180ms

java 19 runtime at proxy
87765
2.54 ms
252.00 ms
0 ms
1 ms
99 ms
217 ms

Fixed 1024 byte messages from the kafka producer test client
with open("out", "w") as f:
  f.write("a" * 1024)

bin/kafka-producer-perf-test.sh \
    --topic perf-test \
    --throughput -1 \
    --num-records 10000000 \
    --producer-props acks=all bootstrap.servers=localhost:9192 \
    --payload-delimiter , \
    --payload-file out

case
records/sec
avg latency
max latency
50th
95th
99th
99.9th

direct to kafka
219178
138.88 ms
396.00 ms
130 ms
171 ms
376 ms
392 ms

java 11 runtime at proxy
202486
150.34 ms
464.00 ms
142 ms
174 ms
396 ms
453 ms

java 17 runtime at proxy
233623
130.28 ms
462.00 ms
122 ms
153 ms
336 ms
460 ms

java 19 runtime at proxy
212670
142.78 ms
403.00 ms
135 ms
180 ms
367 ms
396 ms

10000000 records sent,<PHONE_NUMBER>85 records/sec (228.15 MB/sec), 130.28 ms avg latency, 462.00 ms max latency, 122 ms 50th, 153 ms 95th, 336 ms 99th, 460 ms 99.9th.
machine specs:
Intel(R) Core(TM) i7-10750H CPU @ 2.60GHz
Dell XPS

java 19 details:
java --version
openjdk 19.0.2 2023-01-17
OpenJDK Runtime Environment Zulu19.32+13-CA (build 19.0.2+7)
OpenJDK 64-Bit Server VM Zulu19.32+13-CA (build 19.0.2+7, mixed mode, sharing)

java 17 details:
openjdk version "17.0.5" 2022-10-18
OpenJDK Runtime Environment Temurin-17.0.5+8 (build 17.0.5+8)
OpenJDK 64-Bit Server VM Temurin-17.0.5+8 (build 17.0.5+8, mixed mode, sharing)

java 11 details:
openjdk 11.0.18 2023-01-17 LTS
OpenJDK Runtime Environment Corretto-<IP_ADDRESS>.1 (build 11.0.18+10-LTS)
OpenJDK 64-Bit Server VM Corretto-<IP_ADDRESS>.1 (build 11.0.18+10-LTS, mixed mode)


Log which scope the IdP was sending that fails our data.

This is essential information to understand violations.

:+1:


Update lint rule: no-extraneous-deps

Include all missing packages.
Do not allow devDeps except in tests files.

/retest

LGTM,
re ran Build Test / resolve-dependencies (18) (pull_request) as it failed initially...

/approve

/lgtm

/retest


New 2DS

This would also have to accommodate for the Old 3DS Get Started page, as it never said "or 2DS".


remote plane use remote plane's service local ip and main cluster gw ip properly

Describe the feature request
I've got a POC running for https://github.com/istio/istio/issues/22934, and it works fairly well for shared control plane scenario.  One issue I noticed is that when multicluster shared control plane configures endpoint for remote cluster, it uses remote cluster’s gateway ip.  Examples: for sleep to reach httpbin both deployed in remote plane, traffic will go from sleep->ingress gw (remote plane's)->httpbin.
This is fine in shared control plane model but doesn’t work too well for central istiod manage remote plane where users are not allowed to deploy any services to central istiod, e.g. a dedicated cluster is only used to run istio control plane without any user's data plane running.  When central istiod runs in this mode where no user's data plane running in the cluster where central istiod runs, we need to provide a configuration to allow admin to configure that the remote plane's service endpoints should use the service's local pod IPs.  With this, for sleep to reach httpbin both deployed in remote plane, traffic will go from sleep->httpbin directly.
Describe alternatives you've considered
Traffic goes through an extra hop via the ingress gw.
Additional context

chatted with @GregHanson a bit more on this.  Ideally if we could, would be nice to fix this for the shared control plane model, not just central istiod or central istiod without any workloads on the istiod cluster.  (if not, certainly we want this to be fixed for at least the central istiod without any workloads on the istiod cluster scenario.)
@GregHanson will help us investigate more on this.
@costinm @howardjohn would appreciate your thoughts.

Another related issue that @nmittler ran into, think it is related to this. from the remote cluster, it sees the main cluster's endpoint IP, but not its gateway IP.  The key thing is the endpoint registry also has main cluster's perspective, regardless of whether the pods resides in main or remote cluster.

change to a bug as this really was not a new feature but a bug with shared control plane in general that it doesn't have proper endpoints on the remote cluster.

@GregHanson @nmittler said this worked for him in 1.5.1, e.g. correct endpoint is displayed for pods in remote cluster.

As @linsun mentioned, things seem to work for me on 1.5.1 but not in the latest 1.6 branch.
My setup has 2 clusters (cluster1 and cluster3) which are on separate networks, with a control plane deployed to cluster1.
Master cluster setup:
https://gist.github.com/nmittler/ced1775e4ecd1c1dfd1eec59a5c630f7
Remote cluster setup:
https://gist.github.com/nmittler/0c9816d5f9d1283c81dcc3bb2333879f
I have the test services deployed to both clusters.
I can test reaching the helloworld service from cluster 1:
kubectl exec --context=${CTX_1} -it -n sample -c sleep \
  $(kubectl get pod --context=${CTX_1} -n sample -l \
  app=sleep -o jsonpath='{.items[0].metadata.name}') -- curl \
  helloworld.sample:5000/hello

This seems to properly toggle between hitting the helloservice v1 (cluster1) and v2 (cluster3).
Then I try from cluster 3:
kubectl exec --context=${CTX_3} -it -n sample -c sleep \
  $(kubectl get pod --context=${CTX_3} -n sample -l \
  app=sleep -o jsonpath='{.items[0].metadata.name}') -- curl \
  helloworld.sample:5000/hello

From cluster 3, I always see v2 which is the version of helloworld deployed to cluster 3.
I then checked the clusters (endpoints) seen by the envoy in cluster3:
kubectl --context=${CTX_3} exec -it \
  $(kubectl --context=${CTX_3} get pod -n sample -l app=sleep -o jsonpath='{.items[0].metadata.name}') \
  -n sample -c sleep -- curl <IP_ADDRESS>:15000/clusters | grep helloworld

This seems to have both endpoints, but it seems to be using pod IPs for the endpoint in cluster1, rather than the ingress. So v1 is never reachable.
In v1.5.1, this list has the ingress for the cluster1 endpoint.

cc @sdake

@stevenctl has a fix for #23591 but I don't think it would fix the prob I have because I don't run istiod on remote cluster.  Regardless, I think we should apply cluster local for istiod service for main cluster to pick up the change as it can avoid issues with shared control plane with Istiod runs in both clusters.  cc @GregHanson

Pending validation but this is fixed with configuring fromRegistry to the cluster name in main cluster per @GregHanson

@linsun @GregHanson have you confirmed that this is fixed now?

Yes, just pulled down the 1.6.1 pre-release build, I can confirm this is fixed now


To Do List: add & remove

To Do List: add & remove
In this project, you will implement the CRUD (create, read, update, delete) methods. All the elements of the user interface will be fully functional and your application will be completed.
Implemented Feature

[ ] Remove all hardcoded items from the tasks array.
[ ] Create a new JavaScript file for the new functionality.
[ ] Implement a function for adding a new task (add a new element to the array).
[ ] Implement a function for deleting a task (remove an element from the array).
[ ] Implement a function for editing task descriptions.
[ ] Deleting a task should update all remaining items' indexes
[ ] All changes to the To Do List should be saved in local storage.
[ ] By default new tasks should have the property completed set to false

Hi @codepantha Thank you so much for feedback!!
I will take that into considaration and change it.


Add layout_sidebar() to express to make inline sidebar layouts possible

The current design of shiny.express.layout.sidebar() doesn't allow for inline sidebar layouts. This would make it a possibility with:
from shiny import ui
from shiny.express import layout

with layout.layout_sidebar():
    ui.sidebar(
        ui.div("Thing 1"),
        ui.div("Thing 2")
    )
    ui.div("Thing 3")

TODO
Consider the direction proposed by @schloerke https://github.com/posit-dev/py-shiny/pull/847#issuecomment-1843104848 (which would remove the need to have a layout_sidebar(), and would seemingly also allow for inline layouts). I'm not sure we currently have a technical foundation to easily accommodate for this though

Closing since layout_sidebar() was added somewhat recently


Class instance should not be allowed to cast to an arbitrary object type.

Test with 0.34, hope this behavior will be forbidden, it is too counterintuitive.
( flowtry here):
declare class Cl { s: string, f: Function }
declare var cl:Cl;
const ob: { [key: string]: number } = cl; // should not allow this implicitly cast.
const s: number = ob.s; // ob.s is a string indeed.

This is now banned


docs additions

add the unix socket, the default of the docker client
partially resolves #804

the docs didn't start up the daemon on the unix socket, which results in a confusing error like
FATA[0000] Post http:///var/run/docker.sock/v1.18/containers/create: dial unix /var/run/docker.sock: no such file or directory. Are you trying to connect to a TLS-enabled daemon without TLS?

Please sign your commits following these rules:
https://github.com/docker/docker/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:
$ git clone -b "docs-started" git@github.com:MHBauer/swarm.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -f

Ammending updates the existing PR. You DO NOT need to open a new one.

@moxiegirl @aluzzardi make sure this makes sense.

SGTM :+1:

Awesome. Thanks!
LGTM
/cc @moxiegirl

Nice catch @MHBauer LGTM


No view created

How can the extension get the media without creating a view urgent please
thanks

@alikabeel What do you mean by "without creating a view"? Do you mean a popup? Chrome extensions don't have to have a popup. This extension makes use of a background script and content_scripts to inject the media into the page. Checkout js/injectStoryTray.js to see how it's done.

i mean that the story does not appear as viewed i have downloaded a story but still it appears as new how is this done?

@alikabeel Oh, I was confused for a second. The Instagram app makes a request to https://i.instagram.com/api/v1/media/seen/ after you view a Story. This extension simply doesn't call that endpoint.