build: Upgrade eslint-config-wikimedia from ^0.22.1 to ^0.24.0

Codecov Report

Merging #91 (cac0f85) into master (551f9bb) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff            @@
##            master       #91   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files            9         9
  Lines          128       128
=========================================
  Hits           128       128


NTRs for plant immaterial entities

From @bionicjules in https://github.com/obophenotype/uberon/issues/1333
terms requested for:
'plane of abscission'
'plane of dehiscence'
'line of dehiscence'

Is this what you want? (I suspect it’s a bit skeletal compared with Uberon)

On 25 Jun 2017, at 19:28, Chris Mungall<EMAIL_ADDRESS>wrote:
From @bionicjules https://github.com/bionicjules in obophenotype/uberon#1333 https://github.com/obophenotype/uberon/issues/1333
terms requested for:
'plane of abscission'
'plane of dehiscence'
'line of dehiscence'
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub https://github.com/Planteome/plant-ontology/issues/677, or mute the thread https://github.com/notifications/unsubscribe-auth/AHWxAdyySKNDY7vSrCH4a68ed_tKPqdIks5sHqbBgaJpZM4OErkK.

<owl:Class rdf:about="http://purl.obolibrary.org/obo/BMO_0004601">
<rdfs:subClassOf rdf:resource="http://purl.obolibrary.org/obo/UBERON_0035087"/>
BioTRI2:IAO_0000115Dehiscence is the splitting at maturity along a built-in line (sic) of weakness in a plant structure in order to release its contents, and is common among fruits, anthers and sporangia. Sometimes this involves the complete detachment of a part. Structures that open in this way are said to be dehiscent. Structures that do not open in this way are called indehiscent, and rely on other mechanisms such as decay or predation to release the contents.
A similar process to dehiscence occurs in some flower buds (e.g., Platycodon, Fuchsia), but this is rarely referred to as dehiscence unless circumscissile dehiscence is involved; anthesis is the usual term for the opening of flowers. Dehiscence may or may not involve the loss of a structure through the process of abscission. The lost structures are said to be caducous. (WP)</BioTRI2:IAO_0000115>
<dc:date rdf:datatype="http://www.w3.org/2001/XMLSchema#long">1492533994950</dc:date>
rdfs:commentThe opening of a seed pod or other outer covering, often (in plants) as an elastic mechanism, but also when an insect emerges from its previous instar's cuticle.</rdfs:comment>
<rdfs:label xml:lang="en">plane of dehiscence</rdfs:label>
</owl:Class>
<!-- http://purl.obolibrary.org/obo/BMO_0004602 -->

<owl:Class rdf:about="http://purl.obolibrary.org/obo/BMO_0004602">
    <rdfs:subClassOf rdf:resource="http://purl.obolibrary.org/obo/UBERON_0035087"/>
    <dc:date rdf:datatype="http://www.w3.org/2001/XMLSchema#long">1492531886638</dc:date>
    <rdfs:comment>A botanical term defining the plane over which a leaf or other part of a plant develops a weak layer which allows the leaf or other part to break off and be discarded.</rdfs:comment>
    <rdfs:label xml:lang="en">plane of abscission</rdfs:label>
</owl:Class>

<owl:Class rdf:about="http://purl.obolibrary.org/obo/BMO_0004604">
    <rdfs:subClassOf rdf:resource="http://purl.obolibrary.org/obo/BMO_0004600"/>
    <BioTRI2:IAO_0000115>dehiscence is characterised by brittle fracture, but not necessarily due to drying out (cf. squirting cucumber)</BioTRI2:IAO_0000115>
    <dc:date rdf:datatype="http://www.w3.org/2001/XMLSchema#long">1492534033926</dc:date>
    <rdfs:label xml:lang="en">line of dehiscence</rdfs:label>
</owl:Class>

Currently in the PO we have abscission zone http://browser.planteome.org/amigo/term/PO:0000146
and child terms


SIGSEGV when using --http-port option for dev server and port is already in use

What are you really trying to do?

Describe the bug
With CLI version 0.12.0, I started a local development server with the --http-port option. Since I had already started one in another terminal window, I expected this to fail with a "port already in use" message. While it did do this, that message was followed by panic: runtime error: invalid memory address or nil pointer dereference, [signal SIGSEGV: segmentation violation code=0x2 addr=0x20 pc=0x1023b3680], and a stack trace that obscured the "port already in use" message until I scrolled through 100 lines of output.

Minimal Reproduction

Install Temporal CLI version 0.12.0 and ensure that it's foremost in your executable path by running temporal --version
In one terminal, run temporal server start-dev --http-port 8234
In another terminal, run temporal server start-dev --http-port 8234
Observe that the second command fails immediately, as described above.

Environment/Versions

OS and processor: M2 Mac running macOS Ventura 13.6.6 (22G630)
Temporal Version: CLI = temporal version 0.12.0 (server 1.23.0) (ui 2.26.2)
Are you using Docker or Kubernetes or building Temporal from source? No

Additional context
N/A

I forgot to mention that I encountered this when I attempted to start the dev server using temporal server start-dev --http-port 8234 after having forgotten that I had started it a few hours earlier in another terminal.

So we would expect this to fail if the port is already in use, but the issue is how many lines to scroll to see that? I suspect this is a server issue and that if you started two servers on the same machine with the same ports configured the same thing would happen regardless of how you started those servers (CLI, via binary + config, etc).
Can you describe what the desired result is?

Yes, I'd certainly expect the command to fail if the port is in use. What I did not expect is that, if using the --http-port option, the failure results in segmentation violation and panic (and therefore, significantly more output).
Having similar output for port conflicts whether or not that option is specified would provide a better user experience.

What I did not expect is that, if using the --http-port option, the failure results in segmentation violation and panic (and therefore, significantly more output).

I think this will happen with our server regardless of whether you use CLI. I think this may be a general server issue concerning port-in-use reaction instead of only something for CLI users. We can leave this open here, but after confirmation this is a server issue, it may be transferred to that repo.


GeoJSON authentication keeps failing

Every time I try to hit the "login" button at the top right of geojson.io when I am logged into my github account, nothing happens. The page refreshes and I am still not logged into geojson. When I click a couple of more times, I get this error: "Authentication with GitHub failed"
How do I fix this so I can use geojson?

Closing as a dup of #620

Note: development of geojson.io is currently paused. You may be interested in the new fork at https://geojson.net. Until development restarts, please refrain from adding issues to the tracker.


Fix: Strengthen Login Functionality and Error Handling

Description
This pull request enhances the login functionality and overall security of the user authentication process in the application. The following changes have been implemented:
Input Validation: Introduced a new module for input validation and sanitization to prevent common security vulnerabilities, such as SQL injection and cross-site scripting (XSS).
Improved Login Logic: Added checks and validations during the login process to enhance user experience and security.
Error Handling: Enhanced error handling in the login and signup processes to provide clear feedback for invalid credentials, improving user experience.
Cookie Management: Integrated the use of timedelta for cookie expiration in the "Remember me" feature, ensuring cookies are managed properly based on user preferences.
Code Refactoring: Cleaned up and reorganized the code for better readability and maintainability, including updated comments to clarify functionality.
These changes aim to provide a more secure and user-friendly experience for the application's users.

I am not merging these PRs without proper communication


Complete Parse Server

Hello, are all Parse Server features (Livequery, Local datastore, Query cache, cloud functions, etc..) implemented?

Hey
Not yet. It's a work in progress.
There's a lot to do in terms of queries. The project currently connects to
a Parse Server, can get and save objects and login. It's an updated version
of an old attempt I found. I'm currently working on this along side a
Flutter project I have but there's a few issues I'm hitting.
On Mon, 24 Sep 2018, 18:51 Alexander Melo<EMAIL_ADDRESS>wrote:

Hello, are all Parse Server features (Livequery, cloud functions, etc..)
implemented?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/phillwiggins/FlutterParseSDK/issues/2, or mute the
thread
https://github.com/notifications/unsubscribe-auth/AHgn3tTSkKWo1tVxEDUGBzTnsCuwGq65ks5ueRurgaJpZM4W3JqK
.

Thank you.


Feat - Add base Vuejs support - this template offers only necessary c…

…onfigurations and no more yet.

@xeuxdev kindly fix conflict

Alright 👍

Alright 👍

merge conflicts have been fixed


Nullpointer when adding a new file in a PR

After adding a new HTML file (using 6.0.1), I got a nullpointer in this line (base is null so base.sizeMap throws):
https://github.com/jsenv/jsenv-file-size-impact/blob/31f8da63c44fb118de48bd59507394aedf876406/src/internal/comment/formatComment.js#L367

Good catch you nailed it.
I should update the doc from This parameter is null to It will crash your program.

Or maybe update the code to actually send null 🤔 .
I am joking of course, I guess I will just need to
- sizeMapOnBase: base.sizeMap
+ sizeMapOnBase: base ? base.sizeMap : null

And maybe also
- sizeMapAfterMerge: afterMerge.sizeMap,
+ sizeMapAfterMerge: afterMerge ? afterMerge.sizeMap : null,

6.0.2 released with the fix.
You can update version to 6.0.2 in package.json :)


Invalid CSS Media Query Syntax

Firefox flags the media query syntax as invalid with print being in parentheses on line 3616:
@media (print), (prefers-reduced-motion: reduce) {
should be
@media print, (prefers-reduced-motion: reduce) {
This does appear to be accurate per the official CSS3 and 4 specs.

alright we will take a look on this...

@minig0d fix in 0f35cf3 at #1029
Reference:
prefers-reduced-motion
https://developer.mozilla.org/en-US/docs/Web/CSS/@media/prefers-reduced-motion
print
https://developer.mozilla.org/en-US/docs/Web/CSS/@media

@eltonmesquita kindly review and close if necessary.


change 'New Object' with 'Replace Object' for english translation

closes #838

Coverage remained the same at 44.194% when pulling 0e1a7224fccd2046eaa95971a29f366ea4dcb06b on 838-translations into 8bc3982c3f8dcca9cb603124c8bb9395c1265110 on release2.1.


Rellax inside a container

Hi,
Is there a possibility to make Rellax work when it's use inside a div container ( with his own overflow  ) ?
Thanks a lot for this good library !

Added this with #104 PR


what is the data flow of this app?

Say user A and user B are in a chat room(topic), A send a message 'Hello'. Does this message go through network directly to B or it goes first to some server(owned by databag or anyone, but not me), then to B?

Thanks for the question; the data does not flow through any Databag server.
Scenario: User A creates a topic and adds User B as a member, then User A sends a message.

User A's node will host the topic
When User A posts a message, it is sent only to User A's node
User B's node is then notified of a new message by User A's node (could be the same node)
User B's app receives the notification through a websocket connection to User B's node
User B's app pulls the message from User A's node

A's node and B's node each has their corresponding domain, right?

Yes correct. The project supports federation, so accounts on different nodes (and different domains) can communicate.

Thanks. You can close this thread.


Bug in inject plugin

https://github.com/rolldown/rolldown/blob/main/crates/rolldown/tests/rolldown/function/inject/main.js#L7-L8

https://github.com/rolldown/rolldown/pull/1934


ISSUE-6 Fix line endings in org.spdx.spdxspreadsheet package

Pull request to continue towards resolving #6 - as there are hundreds of files in the repository, of which all appear affected, I thought a good way to break it into manageable chunks would be to pick a package.
This resolves the line endings issue in the org.spdx.spdxspreadsheet package. There are no other changes in this pull request.
All of the files appear modified on every line due to the nature of the issue.
My contributions are licensed under the Apache 2.0 license as required for contributions to this project.

Merged into git.spdx.org - should be mirrored to github soon


Support TLS in prober

Fixes #3128

Proposed Changes

Add a new constructor for the async prober so that it can support TLS, allowing us to probe even when the address uses https

Release Note

Added TLS support to the prober.

(I left a early comment since it's WIP)

Another interesting aspect for TLS support on the prober is, we would need to offer/implement a mechanism to rotate CA certs on the underlying HTTP(s) client.

How do you see this working?

/retest-required

@pierDipi its worth noting that I had to make a TLS cert that had an IP SAN - is there anything we need to do to ensure that the certs being issued in the cluster all have an IP SAN?

@pierDipi its worth noting that I had to make a TLS cert that had an IP SAN - is there anything we need to do to ensure that the certs being issued in the cluster all have an IP SAN?

Awesone, I'd update the one in Eventing with the additional IP SAN, so that we can reuse them here

/lgtm
/approve
Using the updated Eveting library can be done in a follow up


Count and Sum return 0 for empty intervals

I still need to write a test for this specific use case but this is the general idea.

[x] Rebased/mergable
[ ] Tests pass
[ ] CHANGELOG.md updated

@jsternberg What do you think?

Assuming that tests pass, this seems fine to me. 👍
I think the tests should be fine since the iterator doesn't attempt to use a reducer for an interval unless that interval has at least one point, which is why this would have never had an error previously.


snapshot.rehydrate does not restore arrays properly

They're VNodes instead of arrays, so components expecting arrays in props will crash.

@emmby thanks for reporting this. The state rehydration converts the entire state map to an Immutable.js data structures, in case of arrays to List. The VNodes you are seeing are List nodes in a Immutable Map.
This is intentional, as in the Pepperoni architecture the entire state of your application should be an immutable data structure to begin with - i.e. you should never have plain javascript objects or arrays in your application state. For the rationale behind immutable app architectures, I recommend watching Lee Byron's talk about them.
I admit the documentation does not make this clear. I will improve the documentation, tracked by https://github.com/futurice/pepperoni-app-kit/issues/49.


ROS2 dashing image_transport

I'm trying to compile, using ROS2 dashing, image_transport plugin that can be found HERE.
colcon build is saying me that the makefile requires catkin, that I know is a ROS1 package and is not supported by ROS2.
How can I proceed to use image transport on my ROS2 nodes?

I am not sure if you have seen the ROS support guidelines but we kindly ask to raise questions like this on answers.ros.org instead.
The rational for asking all kind of questions in a single place is:

There are many more people reading questions there so your chances on getting an answer and in a timely manner are much higher.
In the future other users will search there for similar problems and can find your question and the potential answers.
The issue tracker in this repo is used to track bugs, feature requests, etc. But your question is not such an action item.

Therefore I will close this ticket here for now. If you have asked your question on answers.ros.org please feel free to add a link to the question to this ticket so that future readers can find the related question.


[#36] Add in NFR

Adding in the NFRs for the SRS Document.

Some of these links dont work (the ones that aren't blue)

Make sure you add two spaces to the end of each line so that this wrapping doesn't happen.

For example:
first line  <-- two spaces
next line

Too many conflicts, make a new branch 😅


Extreme weather updates

Includes updates to the Extreme Weather tool

use partial components for Help, Resources, About
create a new ChangeStation partial (can be used by other station based tools)
fix some bugs in StaticMap and VectorLayer components

 Browser navigation broken on Extreme Weather tool


"People's Republic of China" should just be "China"

Fixed with https://github.com/datadesk/web-map-maker/commit/a170c3b22c431ffcebfe4ff990ac60a8a428f4d1 should have stuck on 2.1 branch


Add 8x4 Arm64 kernel to improve performance

In my spare time I'm been messing around with the optimised Arm64 kernels.
This PR adds an 8x4 kernel (for 64-bit bitpacked input) which improves single-threaded benchmark performance by around 6%.
What do these changes do?
The current optimal Arm kernel (for 64-bit bitpacking) has a 4x4 layout and uses 32-bit accumulators. This PR additionally introduces an 8x4 version of this kernel that uses 16-bit accumulators.
After the accumulation loop, the first operation is an unsigned shift left long instruction which performs the necessary back-transformation left-shift by 1, and writes the result into 32-bit vector registers. This means that all subsequent 'post-processing' (clamping, post-multiply and post-addition) is done in Int32/Float32, as in the existing kernel.
Performance improvements
Performance is improved (compared to the 4x4 kernel) in two ways:

Increased weight sharing: The 8x4 layout means that the RHS data gets used two times more for each load, or equivalently the number of RHS memory loads is halved.

Faster BMLA pseudo-instructions: With 8 rows and 16-bit accumulators, each column of accumulators fits into a single NEON register. With 16-bit accumulators rather than 32-bit accumulators, there's no need for an extra uadalp instruction to pack 16-bit results into 32-bits (specifically, there's no need for the equivalent of this instruction in the current kernel). As a result, the proposed BMLA macro uses 24 instructions to process eight rows of data, as opposed to 13 instruction to process four rows of data in the current 4x4 kernel.

Overflow risk with 16-bit accumulators
There is a potential risk of overflowing the 16-bit accumulators if filter_height * filter_width * channels_in >= 2^16. As a result, this PR does not replace the existing 4x4 kernel, and safely falls back to the old kernel if this overflow threshold is breached.
In reality, we will always use the new 8x4 kernel for models of any reasonable size: a 3x3 kernel would have to have > 7000 input channels to present an overflow risk.
How Has This Been Tested?
All existing kernel tests pass, including the 'big' versions of the tests (that I've run locally, as they don't run by default on CI).
Benchmark Results
I have benchmarked current master (the 'Baseline') and this PR on my Android phone (a OnePlus 6) and on a Raspberry Pi Model 4B. I used the LCE benchmark utility with num_runs=250 and report the average and the standard-deviation.
Single-threaded

Device
Model
Baseline
PR
Speed-up

OnePlus 6
QuickNet
19.83 +- 0.28
18.72 +- 0.21
5.6%

OnePlus 6
QuickNetLarge
28.41 +- 0.22
26.99 +- 0.22
5.0%

OnePlus 6
QuickNetXL
50.65 +- 0.52
47.86 +- 0.33
5.5%

RPi 4
QuickNet
37.82 +- 0.09
34.94 +- 0.17
7.6%

RPi 4
QuickNetLarge
55.98 +- 0.12
52.66 +- 0.15
5.9%

RPi 4
QuickNetXL
99.09 +- 0.46
92.00 +- 0.26
7.2%

Multi-threaded (4 threads)

Device
Model
Baseline
PR
Speed-up

OnePlus 6
QuickNet
10.36 +- 0.40
10.08 +- 0.31
2.7%

OnePlus 6
QuickNetLarge
14.65 +- 0.55
14.14 +- 0.42
3.5%

OnePlus 6
QuickNetXL
26.32 +- 0.53
25.34 +- 0.55
3.7%

RPi 4
QuickNet
17.73 +- 0.34
17.17 +- 0.45
3.2%

RPi 4
QuickNetLarge
26.56 +- 0.56
25.74 +- 0.43
3.1%

RPi 4
QuickNetXL
43.63 +- 1.09
41.71 +- 1.06
4.4%

There is an average single-threaded speed-up of 6.1% and multi-threaded speed-up of 3.4%.

Prospects for an 8x8 kernel
If we don't use RUY_OPT_MAX_STREAMING, then there are enough registers to be able to implement an 8x8 kernel. I have experimented with disabling the RUY_OPT_MAX_STREAMING part of this kernel and haven't noticed any significant benchmarked performance difference, so I don't think that would be a problem.
However, I also don't think that going to 8x8 would bring significant futher performance gains in and of itself, because as far as I can tell most of the performance gain in this PR comes from the slightly more optimal LCE_BMLA rather than the increased weight sharing. That's just a guess though.
On this branch I have an implementation of an 8x8 kernel that is very close to working (out of the many thousands of kernel tests, it fails 12 of them - specifically it fails for large inputs combined with valid padding combined with large stride combined with large dilation). I haven't been able to successfully debug the issue, and I think @Tombana also had weird specific test failures when he tried to get an 8-column kernel working, so there might be some weird underlying issue. In any case, I'm not going to pursue 8x8 any further any time soon.

Prospects for an 8x8 kernel
If we don't use RUY_OPT_MAX_STREAMING, then there are enough registers to be able to implement an 8x8 kernel. I have experimented with disabling the RUY_OPT_MAX_STREAMING part of this kernel and haven't noticed any significant benchmarked performance difference, so I don't think that would be a problem.

I observed the same performance behaviour, utilizing the entire register space did not yield noticeable performance differences (it decreases the iteration over depth and as a result number of kernel calls but this is not significant)
Regarding the 8x8 kernels, I also think it will not also yield signifant improvement (for the same reason as stated above for increasing usage of register space) However, if you are still interested to get it working, I have a 8x8 kernel working here (with a completely different memory layout and instructions). You might have a bug in corner case where the destination matrix does not fit entirely into 8x8 sub-matrices. You can check against my branch to debug that.

We previously had a separate 4x4 kernel for uint32 inputs (that didn't, for example, implement RUY_OPT_MAX_STREAMING). As far as I can tell, there's no reason not to write the optimised kernels to just accept uint64, i.e. get rid of the separate uint32 kernel, because we can still use the uint64 kernels with uint32 inputs (by pretending that the inputs are uint64: halving the LHS/RHS stride and the depth in the kernel params).
That is what I have implemented in ab533ea. All the big tests, in particular the OPT_32 tests, still pass.
The benefit of doing this is that we remove a bunch of code and reduce binary size. Before this PR there were two Arm64 kernels: one 4x4 uint32 kernel and one 4x4 uint64 kernel. After this PR there will still be two Arm64 kernels: one 8x4 uint64 kernel and one 4x4 uint64 kernel. But both will be compatible with uint32 input as well. It also means that using 32-bit bitpacked input still allows us to take advantage of the fastest and most optimised kernels, which is important e.g. for reading bitpacked input directly (which is uint32).
The downside is that ab533ea has made the diff less readable so I'm very happy to revert it and open another PR to discuss those changes.

That is what I have implemented in ab533ea. All the big tests, in particular the OPT_32 tests, still pass.

That sounds great! I think i've measured performance differences in the past between the '32-bit' and '64-bit' kernel, even though they should be the same (just some parameters doubled/halved). Could it be that the '64-bit' kernel causes better memory alignment by requesting blocks that are double the size (but half as many) and therefore a speedup? I guess that's the only reason I can think of for having this distinction at all.

That sounds great! I think i've measured performance differences in the past between the '32-bit' and '64-bit' kernel, even though they should be the same (just some parameters doubled/halved). Could it be that the '64-bit' kernel causes better memory alignment by requesting blocks that are double the size (but half as many) and therefore a speedup? I guess that's the only reason I can think of for having this distinction at all.

Ah it's quite possible that alignment might make a difference; the only other concrete difference I can think of is that the uint32 kernels previously didn't have RUY_OPT_MAX_STREAMING, though as discussed above I don't think that makes a difference really. Also I guess the actual bitpacking step would be quicker for uint64?

Ah it's quite possible that alignment might make a difference; the only other concrete difference I can think of is that the uint32 kernels previously didn't have RUY_OPT_MAX_STREAMING, though as discussed above I don't think that makes a difference really. Also I guess the actual bitpacking step would be quicker for uint64?

Ah yes the bitpacking is only optimized for uint64. I also didn't realize we didn't have the RUY_OPT_MAX_STREAMING in the uint32 kernel. It might be good to benchmark this stuff, with the bitpacking temporarily commented out.
I'm wondering if it makes sense to keep the 32-bit code path at all. There might be some situations where the 32-bit bitpacking path is faster, when the number of input channels is less than 32, so there's less bitpacking-padding overhead. However I think the assembly kernels always pad it to 128-bits (in the "ruy prepacking step"), so maybe its never faster?

I'm wondering if it makes sense to keep the 32-bit code path at all. There might be some situations where the 32-bit bitpacking path is faster, when the number of input channels is less than 32, so there's less bitpacking-padding overhead. However I think the assembly kernels always pad it to 128-bits (in the "ruy prepacking step"), so maybe its never faster?

Yes I've been thinking about this too. I think the assembly kernels pad to 128-bits only after im2col, so if we have a 3x3 kernel operating on 24 or 32 input channels, for example, and do bitpacking before im2col then there would be a performance gain to be had.
Also, I was under the impression that if/when we implement writing bitpacked activations for the assembly kernels we would do it with 32-bit bitpacked activations as in the reference kernel? Not 100% sure about that though.

Yes I've been thinking about this too. I think the assembly kernels pad to 128-bits only after im2col, so if we have a 3x3 kernel operating on 24 or 32 input channels, for example, and do bitpacking before im2col then there would be a performance gain to be had.

Good point, there's im2col inbetween indeed.

Also, I was under the impression that if/when we implement writing bitpacked activations for the assembly kernels we would do it with 32-bit bitpacked activations as in the reference kernel? Not 100% sure about that though.

I'm not sure either. Can we use a destination matrix with #rows padded to multiples of 64 even when the LHS-#rows does not agree with that? It might get a bit hacky at some point, but i guess it already is when writing bitpacked activations.

I'm not sure either. Can we use a destination matrix with #rows padded to multiples of 64 even when the LHS-#rows does not agree with that? It might get a bit hacky at some point, but i guess it already is when writing bitpacked activations.

I think we can, because we had to do it to get the CPP kernel working in the first place. As far as I can tell, when writing to the destination we are writing directly to the output tensor that we allocate in Prepare().

We previously had a separate 4x4 kernel for uint32 inputs (that didn't, for example, implement RUY_OPT_MAX_STREAMING). As far as I can tell, there's no reason not to write the optimised kernels to just accept uint64, i.e. get rid of the separate uint32 kernel, because we can still use the uint64 kernels with uint32 inputs (by pretending that the inputs are uint64: halving the LHS/RHS stride and the depth in the kernel params).

I think changing the 64-bit kernel to be used for both 32-bit packing and 64-bit packing needs to be in a separate PR, so we bisect it if it causes any bugs later. Regarding, the 32-bit kernels we have them in repo, in case we start to optimize for armv7-a and I think we should keep them.

We previously had a separate 4x4 kernel for uint32 inputs (that didn't, for example, implement RUY_OPT_MAX_STREAMING). As far as I can tell, there's no reason not to write the optimised kernels to just accept uint64, i.e. get rid of the separate uint32 kernel, because we can still use the uint64 kernels with uint32 inputs (by pretending that the inputs are uint64: halving the LHS/RHS stride and the depth in the kernel params).

I think changing the 64-bit kernel to be used for both 32-bit packing and 64-bit packing needs to be in a separate PR, so we can git bisect it if it causes any bugs later. Regarding, the 32-bit kernels we have them in repo, in case we start to optimize for armv7-a and I think we should keep them.

Makes sense, I'll revert the last commit and open a new PR :+1:


EventSource support inside Endpoints

One of the missing features holding me back from SvelteKit as opposed to Next.js is the ability to have an endpoint that acts as a text/event-stream also known as an EventSource. However, SvelteKit has a very appealing endpoint design, and it would be great to have it support Event Streams.
It would be great to have this support baked in to SvelteKit, and one design that I believe is appealing is to return a body in the endpoint that is an async generator function. SvelteKit can instantiate that as an async generator and consume the iterator until it has exited, or the client has disconnect, which ever comes first.
I believe the adapter design for SvelteKit does cause a problem in that this feature is only available where long running request processing can be enabled. There are a few caveats with load balancers and serverless that will cause problems keeping the EventSource open. Yet, this proposal doesn't require SvelteKit to be involved in processing the event stream, and all the client-side retry logic will work flawlessly.
Please see a proposed experimental branch here:
https://github.com/sveltejs/kit/compare/master...kjmph:feature/event-source?expand=1
Here is a potential es.json.ts file that demonstrates the design:
import type { RequestHandler } from '@sveltejs/kit';
import type { Locals } from '$lib/types';

const wait = ms => new Promise(resolve => setTimeout(resolve, ms));

// GET /es.json
export const get: RequestHandler<Locals> = async (request) => {
    // Handle setup here..
    async function* es() {
        try {
            while (true) {
                yield `event: time\ndata: ${(new Date()).toISOString()}\n\n`;
                await wait(1000);
            }
        } finally {
            // Handle cleanup here..
        }
    }
    return {
        headers: {
            'Cache-Control': 'no-cache',
            'Connection': 'keep-alive'
        },
        body: es
    };
};

This can be called like so via es.svelte:

<svelte:head>
  <title>EventSource</title>
</svelte:head>

EventSource Example

{timestamp}

This can be dropped in place in the src/routes/ directory via npm init svelte@next my-app

Heavily related to https://github.com/sveltejs/kit/issues/1563. Do you think we should close this and talk about it there since it's another side of the same coin (from my inexperienced perspective)?

Closing in favor of #1563 and due to inactivity.


PyTorch issue in requirements.txt

When performing a
pip install -r requirements.txt
on Ubuntu 22.04 with python 3.10, we receive this error
 × Running setup.py install for pytorch did not run successfully.
  │ exit code: 1
  ╰─> [6 lines of output]
      Traceback (most recent call last):
        File "<string>", line 2, in <module>
        File "<pip-setuptools-caller>", line 34, in <module>
        File "/tmp/pip-install-5380e9mr/pytorch_738d7a5252c5452a8062cfd877cfb51c/setup.py", line 11, in <module>
          raise Exception(message)
      Exception: You tried to install "pytorch". The package named for PyTorch is "torch"
      [end of output]

It seems pytorch has been renamed to torch so I modified the file requirements.txt to the following and I was able to get it working
pytorch-lightning==1.8.6
torch>=1.9.0
tqdm
bcolz-zipline
prettytable
menpo
mxnet
opencv-python


sensor oil_level

Hello,
From the new version, the oil_level sensor no longer goes up.
This sensor gives me the oil_level as a pourcentage.
Do you have an idea ?

Maybe related to: https://github.com/audiconnect/audi_connect_ha/issues/297
Which vehicle you onw? Any logs what you get from API?

My car is A3 Sportback S-Line 2021.
audi-log.log

My car is A3 Sportback S-Line 2021. audi-log.log

I'm not seeing this value being provided by the API anymore:
textId:OIL_LEVEL_DIPSTICKS_PERCENTAGE loc:['oilLevel', 'oilLevelStatus', 'value', 'value']: val:None ts:None
@neil-bh can you provide a log? integrations > audiconnect > enable debug logging. Run the refresh_cloud_data service. Then disable debug logging and provide the file?
I'm guessing this isn't provided by the API anymore. My car is also reporting None value.

No problem, see attached -->
home-assistant_audiconnect_2024-04-08T19-50-31.509Z.log
I seem to be getting this returned:
textId:OIL_LEVEL_DIPSTICKS_PERCENTAGE loc:['oilLevel', 'oilLevelStatus', 'value', 'carCapturedTimestamp']: val:True ts:2024-04-06 09:40:10+00:00
That's odd, why would it be returning a timestamp?
I can also see some data the ends with something like:
.........., 'inspectionDue_days': 82, 'inspectionDue_km': 20278, 'mileage_km': 16779, 'oilServiceDue_days': 82, 'oilServiceDue_km': 12875}}}}
...this doesn't seem to contain any oil level values either (apart from service due), but i'm lost in these logs, so I won't pretend I know what I'm talking about.
What are your thoughts?

The returned value is actually "True" if you see val:True.
ts: is for timestamp.
It seems with API changes they've either moved away from using this, or its actually just a bool value for if the oil level is good (True) or bad (False). If its changed to that, we'll have to modify the sensor to binary_sensor and return the correct device_class to make this worthwhile. Its definitely not providing percentage anymore from what i've seen.
I'm just not sure why you would be returning True while mine is returning None. Could be a difference between diesel providing the value vs gas/electric not providing the value.

Sounds like you could be right.  The Audi app on my phone is reporting OK.  I'm not sure if in the past this was an integer value - can't say I paid much attention.

Also, in the service schedule section of the phone app, it provides a date for the oil change.  I'm not sure how that's calculated if it doesn't know the level of oil.  Maybe it's an estimation based on the last time the car had an oil change?  If thats so, that'd be a semi-useful value to report on perhaps.

This is great info. Thanks for providing this. I can put together a PR for a binary sensor for the "oil level" since that seems to be its purpose now.
As for the service schedule, these sensors should be available already. Do you have these sensors available for your car?

Glad I could provide some help to the future changes.

As for the service schedule, yes, I double checked and I can see these entities already.

Sorry for your loss 😞
Okay so for this its just the oil level. Service schedule and oil change are working for you.

2024-04-09 07:34:12.354 DEBUG (MainThread) [custom_components.audiconnect.audi_models] audi_models.py - _tryAppendFieldWithTs: textId:OIL_LEVEL_DIPSTICKS_PERCENTAGE loc:['oilLevel', 'oilLevelStatus', 'value', 'carCapturedTimestamp']: val:True ts:2024-04-08 15:27:43+00:00
The Web API still delivers it as an percentage: https://userinfo.my.audi.com/bvh/v1
data.vehicleStatusReport.oilLevel {
  "value": 87,
  "unit": "%"
}

Maybe we need to think if the should integrate this API as well.
Full data:
{     "data": {         "vehicleStatusReport": {             "vin": "WAUZZZF23[XXX]",             "vehicleType": "HYBRID",             "lastUpdated": "2024-04-09T03:55:14Z",             "engines": [                 {                     "type": "GASOLINE",                     "range": {                         "value": 670,                         "unit": "km"                     },                     "filling": {                         "value": 93,                         "unit": "%"                     },                     "adBlueRange": null,                     "electric": null                 },                 {                     "type": "ELECTRIC",                     "range": {                         "value": 15,                         "unit": "km"                     },                     "filling": {                         "value": 22,                         "unit": "%"                     },                     "adBlueRange": null,                     "electric": {                         "chargingState": "INACTIVE",                         "chargingTime": null                     }                 }             ],             "totalRange": {                 "value": 685,                 "unit": "km"             },             "mileage": {                 "value": 20483,                 "unit": "km"             },             "oilLevel": {                 "value": 87,                 "unit": "%"             },             "oilLevelSupported": true,             "service": {                 "oilChange": {                     "time": {                         "value": -193,                         "unit": "d"                     },                     "distance": {                         "value": -9600,                         "unit": "km"                     }                 },                 "inspection": {                     "time": {                         "value": -193,                         "unit": "d"                     },                     "distance": {                         "value": -9600,                         "unit": "km"                     }                 }             },             "messages": [                 {                     "key": "vehicle.locked",                     "value": true                 },                 {                     "key": "doors.closed",                     "value": true                 },                 {                     "key": "windows.closed",                     "value": true                 },                 {                     "key": "parking.lights.off",                     "value": true                 },                 {                     "key": "bonnet.closed",                     "value": true                 },                 {                     "key": "trunk.closed",                     "value": true                 }             ],             "stoWarnings": []         }     } }

Oh nice catch @Kolbi .
Yeah maybe thats something we could do to get the Oil Level back as a separate sensor to the binary? Is that what you're thinking?

I have a same result before reload cloud data Audi.
textId:OIL_LEVEL_DIPSTICKS_PERCENTAGE loc:['oilLevel', 'oilLevelStatus', 'value', 'value']: val:None ts:None

Just link it here: https://github.com/audiconnect/audi_connect_ha/discussions/276


Resolves #305, use an English locale when excuting java command line

Otherwise we cannot rely on the exception message because the error returned by the java command line will be localized.

Good, will merge after CI


Incorrect raising of ValueError("must set wavelet if scales isn't array") line 220 cwt_utils,py

Hi,
I've encountered what i believe to be a bug in a call to ssqueezepy.ssqueeze to synchro-squeeze a continous wavelet transform. I'll try to explain the issue as best i can, because i can't send the exact implementation. This is also my first issue, to bear with me if i get anything wrong in the format or conventions :)
I'm running ssqueezepy v0.6.3
The call is of the form:
Tx, fvec = sq.ssqueeze(
			Mx, w=phase, ssq_freqs="log", wavelet=wavelet, scales="log", fs=sampleRate, maprange="maximal",
			transform="cwt"
		)

where,
wavelet = sq.Wavelet("morlet") is set before calling the method. and is of type(wavelet) = ssqueezepy.wavelets.Wavelet
and Mx, phase are the normal matrices of the transform and phase produced by ssqueezepy.cwt()
In 'squeezing.py/squeeze' after the call to _process_args is completed, the following if statement on line 168 calls the method process_scales if transform == 'cwt'. See below
    if transform == 'cwt':
        scales, cwt_scaletype, _, nv = process_scales(scales, N, get_params=True)

However the call to process_scales does NOT pass the wavelet as an input argument (which it expects and sets to None if not passed). This results in the exception ValueError("must set `wavelet` if `scales` isn't array") being raised on line 220 in cwt_utils.pt/_process_args as called from process_scales.
The argument wavelet passed to ssqueeze()  was in fact set correctly.
Hopefully that makes sense...
Thanks,
J.

Thanks for the report. The debug details help, but please include a minimal reproducible example.


Add ublacklist-ai to the list of filters

Adding my own repository to block pesky ai-art from google images into the mix.

This is a different repository from #388, which I opened a few days ago, but ublacklist-noai seems to have broader coverage. How about integrating your filter list into this repository?

P.S.
Just a little question, why is your profile picture an AI image? That doesn't make sense.

This is a different repository from #388, which I opened a few days ago, but ublacklist-noai seems to have broader coverage. How about integrating your filter list into this repository?

While that is true, you just block some sites people may wanna use aswell.
And i didnt see your PR haha

P.S. Just a little question, why is your profile picture an AI image? That doesn't make sense.

As for this, when i wanna search Art, i want Art from artists. An Profile picture is just a profile picture


It is  possible to reopen merged PRs via API

Gitea Version
(almost) latest main
Git Version
No response
Operating System
No response
How are you running Gitea?
Built from source, from cli
Database
No response
Can you reproduce the bug on the Gitea demo site?
Yes
Log Gist
No response
Description
It is possible to reopen merged prs via the api endpoint. This should be impossible
Screenshots
No response

Could you please clarify which endpoint you mean?
Because I just had a quick glance at https://try.gitea.io/api/swagger, and I have no idea which endpoint might be responsible for this.

yes it is - if it's not working we need more infos&logs:

what specific endpoints do you rever to?
what gitea do print out in debug mode
what response the api return (body & header & status)

I get the urge for detailed bug reports, but in this case it's just needless bureaucracy.. I was easily able to spot the problem here right away 🤔

it's this request https://try.gitea.io/api/swagger#/repository/repoEditPullRequest

Yes, it is, and it is probably the same (not tested) here: https://try.gitea.io/api/swagger#/issue/issueEditIssue

@6543 it's the same if I reopen a closed issue or PR - status code is 201, and the answer is the pull request.


Groups members $ref DELETE operation missing from open API description

The following operation is missing from the OpenAPI descriptions, I believe this is because the CSDL metadata is missing an annotation.
DELETE /groups/{group-id}/members/{member-id}/$ref

https://docs.microsoft.com/en-us/graph/api/group-delete-members?view=graph-rest-1.0&tabs=http

for reference the initial ask is here https://github.com/microsoftgraph/msgraph-sdk-go/discussions/116

Additionally the POST operation is also missing as outlined by the following issue

After a bit of scrapping on the public docs here is a list of endpoints we should enable.
Some of them are in beta only, some of them might be duplicates.
/identityGovernance/entitlementManagement/accessPackages/{id}/incompatibleAccessPackages/$ref
/identityGovernance/entitlementManagement/accessPackages/{id}/incompatibleGroups/$ref
/administrativeUnits/{id}/members/$ref
/applications/{id}/owners/$ref
/applications/{id}/tokenIssuancePolicies/$ref
/applications/{id}/tokenLifetimePolicies/$ref
/applications/{id}/appManagementPolicies/$ref
/identity/b2cUserFlows/{id}/identityProviders/$ref
/identity/b2cUserFlows/{b2cUserFlowId}/apiConnectorConfiguration/{step}/$ref
/identity/b2cUserFlows/B2C_1_testuserflow/apiConnectorConfiguration/postFederationSignup/$ref
/identity/b2cUserFlows/B2C_1_testuserflow/apiConnectorConfiguration/postAttributeCollection/$ref
PATCH /identity/b2cUserFlows/{userflow-id}/userflowIdentityProviders/$ref
/identity/b2xUserFlows/{id}/identityProviders/$ref
/identity/b2xUserFlows/{b2xUserFlowId}/apiConnectorConfiguration/{step}/$ref
/identityGovernance/entitlementManagement/connectedOrganizations/{id}/externalSponsors/$ref
/identityGovernance/entitlementManagement/connectedOrganizations/{id}/internalSponsors/$ref
/onPremisesPublishingProfiles/applicationProxy/connectors/{id}/memberOf/$ref
/applications/{id}/connectorGroup/$ref
/onPremisesPublishingProfiles/applicationProxy/connectorGroups/{id}/members/$ref
/devices/{id}/registeredOwners/$ref
/devices/{id}/registeredUsers/$ref
/directoryRoles/{role-id}/members/$ref
/compliance/ediscovery/cases/{caseId}/sourceCollections/{sourceCollectionId}/custodianSources/$ref
/compliance/ediscovery/cases/47746044-fd0b-4a30-acfc-5272b691ba5b/sourceCollections/1a9b4145d8f84e39bc45a7f68c5c5119/custodianSources/$ref
/compliance/ediscovery/cases/{caseId}/sourceCollections/{sourceCollectionId}/noncustodialSources/$ref
/education/classes/{id}/assignments/{id}/categories/$ref
/education/classes/11021/assignments/19002/categories/$ref
/education/classes/{id}/assignments/{id}/rubric/$ref
/education/classes/{id}/assignments/{id}/categories/{id}/$ref
/education/classes/{id}/members/$ref
/education/classes/{id}/teachers/$ref
/education/schools/{id}/classes/$ref
/education/schools/{id}/users/$ref
/policies/featureRolloutPolicies/{id}/appliesTo/$ref
/groups/{id}/acceptedSenders/$ref
/groups/{group-id}/members/$ref
/groups/{id}/owners/$ref
/groups/{id}/rejectedSenders/$ref
/policies/mobileAppManagementPolicies/{id}/includedGroups/$ref
/policies/mobileDeviceManagementPolicies/{id}/includedGroups/$ref
/onPremisesPublishingProfiles/{publishingType}/agents/{id1}/agentGroups/$ref
/print/shares/{id}/allowedGroups/$ref
/print/shares/{id}/allowedUsers/$ref
/onPremisesPublishingProfiles/{publishingType}/publishedResources/{id1}/agentGroups/{id2}/$ref
/servicePrincipals/{id}/claimsMappingPolicies/$ref
/servicePrincipals/{id}/homeRealmDiscoveryPolicies/$ref
/servicePrincipals/{id}/owners/$ref
/users/{id}/manager/$ref
/onPremisesPublishingProfiles/applicationProxy/connectors/f2cab422-a1c8-4d70-a47e-2cb297a2e051/memberOf/$ref


Use up to date che sample for happy path test

What does this PR do?
Use up to date che sample for happy path test
What issues does this PR fix or reference?
Is it tested? How?

PR Checklist

[ ] E2E tests pass (when PR is ready, comment /test v7-devworkspaces-operator-e2e, v7-devworkspace-happy-path to trigger)

[ ] v7-devworkspaces-operator-e2e: DevWorkspace e2e test
[ ] v7-devworkspace-happy-path: DevWorkspace e2e test

/test v7-devworkspaces-operator-e2e, v7-devworkspace-happy-path

Happy path went further but failed later on Theia side. Merging and will figure out the state with theia.


Flickering when resizing of the VSCode window

Issue Type: Bug

Grab any of the corners
Resize the window (especially top-bottom, bottom-top)

VS Code version: Code 1.37.0 (036a6b1d3ac84e5ca96a17a44e63a87971f8fcc8, 2019-08-08T01:24:14.598Z)
OS version: Linux x64 5.0.0-23-generic
Ubuntu 19.04
Extensions (15)

Extension
Author (truncated)
Version

Bookmarks
ale
10.4.4

bracket-pair-colorizer
Coe
1.0.61

vscode-eslint
dba
1.9.0

githistory
don
0.4.6

gitlens
eam
9.9.3

tslint
eg2
1.0.44

vscode-docker
ms-
0.7.0

remote-ssh
ms-
0.45.4

remote-ssh-edit
ms-
0.45.4

remote-ssh-explorer
ms-
0.45.4

typescript-javascript-grammar
ms-
0.0.52

vscode-statusbar-json-path
ric
1.4.0

vscode-javascript-booster
sbu
0.11.0

vscodeintellicode
Vis
1.1.9

vscode-js-console-utils
wht
0.7.0

@terradek can you record this somehow?

@bpasero
PFA
flickering.zip

Does it get any better with setting "window.titleBarStyle": "custom" ?

@bpasero  It gets worse with this setting
flickering_title_bar_native-cuscton-2019-08-10_21.28.20.zip

We are building exploration builds that use a much newer version of our UI framework (Electron version 6.0.x). I wonder if this issue reproduces with one of these builds, could you try? Download:

macOS: Download
Linux (DEB): Download
Linux (RPM): Download
Windows: Download

@bpasero  IMO a bit better
flickering_title_bar_code_exploration-2019-08-12_11.43.07.zip

Fixed with https://github.com/microsoft/vscode/pull/81644


compability issue

Hello,
So I got my php file figured out but when I went to install my composer.phar file, it is telling me that my requirements could not be resolved to an installable set of packages.
I had this problem before and at the bottom it says that Installation request for elastic search/elasticsearch ~1.0 -> stisfiable by elasticsearch/elasticsearch[v1.0, v1.0.1, v1.0.2, v1.1.0, v1.2.0, v1.2.1, v1.2.2, v1.3.0, v1.3.1, v1.3.2].
I originally had version 1.4 installed so I thought that was my issue. I cleared the machine and started over downloading v1.3.2, would you know why it is giving me the same error?

Hmm, could you attach your composer.json file?  I'm guessing there is another dependency that is conflicting?

It won't let me upload that file type here is what is in the composer.json file
aharmon@LocalSearchEngine:~$ cat composer.json
{
"require":  {
"elasticsearch/elasticsearch":   "~1.0"
}
}

I have the composer.json, composer.phar, elasticserach-1.3.2.deb, elkdata (directory with all the files I want to index), php-files (directory with my index.php and my init.php) all on the root. Is that the problem that they are all on the root?

I changed my composer.json file to say:
{
"require": {
"elasticsearch/elasticsearch": "1.3.*"
}
}
Now the out put is saying the same thing with just less occurrences. It just says satisfiable by elastic search/elasticsearch[v1.3.0, v1.3.1, v1.3.2]
Does this mean I have to have all three files installed or is there another issue. I'm looking throughout the composer documentation so hopefully I find something there.

Honestly I have no idea what's wrong.  This is what the process should look like on a fresh install:
$ mkdir esphp
$ cd esphp

$ echo '{
>   "require": {
>     "elasticsearch/elasticsearch": "~1.0"
>   }
> }' >> composer.json

$ ls
composer.json

$ curl -s http://getcomposer.org/installer | php
All settings correct for using Composer
Downloading...

Composer successfully installed to: /Users/tongz/Documents/temp/esphp/composer.phar
Use it: php composer.phar

$ php composer.phar install --no-dev
Loading composer repositories with package information
Installing dependencies
  - Installing psr/log (1.0.0)
    Loading from cache

  - Installing symfony/event-dispatcher (v2.6.3)
    Loading from cache

  - Installing guzzle/common (v3.9.2)
    Loading from cache

  - Installing guzzle/stream (v3.9.2)
    Loading from cache

  - Installing guzzle/parser (v3.9.2)
    Loading from cache

  - Installing guzzle/http (v3.9.2)
    Loading from cache

  - Installing pimple/pimple (v2.1.1)
    Loading from cache

  - Installing monolog/monolog (1.12.0)
    Loading from cache

  - Installing elasticsearch/elasticsearch (v1.3.2)
    Loading from cache

Writing lock file
Generating autoload files

$ ls
composer.json	composer.lock	composer.phar	vendor

Is that the problem that they are all on the root?

No, this really shouldn't affect anything.  Composer will only look at the composer.json file to determine dependencies, then download and install them into /vendor/.

Does this mean I have to have all three files installed or is there another issue.

Something else is going wrong.  Composer should download the most recent version that satisfies your dependency requirement.  So ~1.0 basically means >=1.0, <2.0, so you should get v1.3.2 like my above example.  When you changed it to 1.3.* you should also get v1.3.2
Do you have a globally installed Composer which is messing things up maybe?

Closing due to inactivity, please feel free to re-open if you have any more questions.


switch to ninja

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.


There should be a new "workspace"

It is accidentally created issue which was supposed to be #137804 or is it separate request that you forget to fill?
Please close if it's former and add content if it's later.


Virtual Machine disappear after stopped sometimes.

Describe the bug
In latest version 1.8.1, when create a linux machine, and stop it, linux machine will gone.
The machine created on old version is OK.
To Reproduce

Go to Machines.
Click "New Machine" to create any linux machine.
After new machine running, click stop.
Get error "Can't create machine: create 'alpine': setup: do initial setup: cancel by machine shutdown."
The machine you created is disappear from list.

Expected behavior
The machine that just created should be retained.
Diagnostic report (REQUIRED)
OrbStack info:
Version: 1.8.1
Commit: 442ca0f634f1e62aa1f00c2c54353e69830cc4d5 (v1.8.1)
System info:
macOS: 13.6.6 (22G630)
CPU: amd64, 16 cores
CPU model: Intel(R) Core(TM) i7-10870H CPU @ 2.20GHz
Model: Macmini8,1
Memory: 32 GiB
Full report: https://orbstack.dev/_admin/diag/orbstack-diagreport_2024-11-15T09-51-39.443611Z.zip

Screenshots and additional context (optional)
https://github.com/user-attachments/assets/972348b0-b3c5-44f4-a5f2-cfebe7ba75af

Same one: https://github.com/orbstack/orbstack/issues/1399

I found that I only have this problem if I stop it a short time after created, not if I wait a few more minutes.


pd: fix a deadlock

This PR fix deadlock pitfall.
Demo:
use std::sync::RwLock;

fn main() {
    let mu = RwLock::new(Some(1));
    {
        let clone = foo(&mu.read().unwrap());
        let mut data = mu.write().unwrap();
        *data = Some(2);
        println!("none match: {:?}", clone);
    }

    {
        match foo(&mu.read().unwrap()) {
            Some(_) | None => {
                let mut data = mu.write().unwrap();
                *data = Some(2);
                println!("in match");
            }
        }
    }

    println!("done");
}

fn foo(a: &Option<usize>) -> Option<usize> {
    a.clone()
}

Playground

can we add a test for it?
For the next write, we use try_write to check the lock is still locked.

LGTM
This issue looks like a compiler impl bug to me.

I think compiler will translate it to
let read_lock = lock.read().unwrap();
match func(read_lock) {
    ...
}
...
drop(read_lock)

.

LGTM

PTAL @BusyJay

LGTM

Though I don't think the test case is related to the detail bug.

FYI, may be solved in RFC#2094(non-lexical lifetimes)


MatchTemplate with mask abnormal behavior

Is this right result from MatchTemplateSample (i highlighted minLoc and maxLoc)? Why gem isn't selected? Other modes work fine (almost :smile:).

Result without mask

I have not debugged your sample but you may find help by reviewing #182.


Added support to check for architecture differences betweeen jvm and python

Patch for #241
I still don't have access to make the patterns for Mac or Linux, but the problem bit me on Windows so I figured it was time to put the check in place.
This patch adds a new call to the jvm finder that checks if the jvm is valid prior to returning it.  The check procedure can throw a JVMNotSupportedException if the jvm and the python architecture don't match so that the finder will continue to look for a valid jvm.  It will now properly throw a failure if the found jvm is not supported but it doesn't report the exception string that would be useful for debugging.
We can add checks for other architectures and have them implement the check method.
This patch is a work in progress as I have not checked out the other issues that were causing appveyor failures.

Thanks for that. The Appveyor failure is due to a redefintion of jlong (jpype.h and shipped jni.h have different typedefs). I wonder why we need to define jlong in jpype.h in the first place.


Finalizing work on entering time

User story checklist:
The following is used during story development as a reminder to the development team
what is needed for high-quality software.
functional development and considerations
documented thoughtfully
[ ] classes
[ ] methods
[ ] tests
[ ] unusual aspects documented within code
[ ] README's
[ ] Developer documentation
[ ] User documentation
[ ] Log entries added
correctness
[ ] unit tests written
[ ] Were the tests thorough, or only superficial?
[ ] invariants applied (e.g. assert val > 10)
[ ] integration tests written
non-functionals:
[ ] perf
[ ] security
[ ] accessibility
[ ] logging
[ ] graceful degradation
[ ] mobile-first
[ ] static analysis considered
[ ] risks considered
[ ] should it be refactored?

@coveros-matt-taylor I would like to do a pair-walkthrough review on this code whenever you get a chance.


Single timeout, single default

Each layer sets a new default. Either we always ask the user to provide a timeout, or we specify a default at the one single point.

For bulk adder and IO test cases. Example: timeout and prefix. There should be one single default. This bit me again for PA3.


Temporary Credentials Not Working: External ID without Cause

I'm using the "Temporary Credentials" option, however the "External ID" unpredictably changes.
I have been able to successfully setup multiple CodeDeploys and have them work consistently for a few days.  However the "External ID" unexplainably changes and obviously subsequent CodeDeploy's fail until I re-associate the new “External ID” to the “AWS Account ID” and “IAM Role ARN”.
The “AWS Account ID” and the “IAM Role ARN” do not and have not been changed.
My environment is :

Jenkins ver 1.656
JAVA  ver 1.8.0_74-b02
AWS CodeDeploy Plugin ver 1.11
Windows 2012 Server R2

What is the causing the External ID to change?  How can I prevent it?

Hi,
Who came up with the External ID? Normally, it is the owner of the account who sets up the External ID in the IAM role. (See here for more details: http://docs.aws.amazon.com/IAM/latest/UserGuide/id_roles_create_for-user_externalid.html). If you could paste your IAM role here, that'd be helpful.

This is the only place where this plugin sets External ID. If the external ID is null, then it will set it to a random UUID.

Hi,
Thank you for letting us know what is happening. I have added an item to look into this in our backlog to be Triaged.

We also experience that. Can maintainers indicate where do the ‘global persisted configuration’ values such as the external-id are stored?
I couldn’t find it.


Close the evolution repo issues to maintainers

Community should not use the github issues to submit proposals

I guess we can close this once the other 2 issues are closed.

Right, maybe there is a way to allow use of github issues for maintainers? But if that doesn't work, I'd suggest to simply shutdown github issues for the evolution repo to avoid further confusion.

Pretty sure you can't restrict the issues (only the wiki)
Cheers,
Martijn
On 11 November 2016 at 13:29, Heiko Braun<EMAIL_ADDRESS>wrote:

Right, maybe there is a way to allow use of github issues for maintainers?
But if that doesn't work, I'd suggest to simply shutdown github issues for
the evolution repo to avoid further confusion.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/microprofile/evolution/issues/8#issuecomment-259957249,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AALCaHvsrzcMDa3OyXqtZe2KO7sTd7Eaks5q9G2cgaJpZM4Kvvna
.

What are you trying to do here? if we're trying to close off who can submit proposals... that doesn't sound right.

Correct me if i'm wrong @heiko-braun, but I think its the case that proposals would be PRs, and comments on proposals would be on PRs.
Issues may only be needed for maintaining the repository, maybe.
I think the best option may be to disable issues

If that's what he's aiming for, agreed, we can disable issues and wiki on the repo.

Right,  the idea is to prevent people from creating issues as a proposal, rather then PR.

I missed the discussion. Why is it bad for people to submit ideas as issues?
Do we want to use jira instead?
On Saturday, November 12, 2016, Heiko Braun<EMAIL_ADDRESS>wrote:

Right, the idea is to prevent people from creating issues as a proposal,
rather then PR.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/microprofile/evolution/issues/8#issuecomment-260109399,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAFyznKrjcXBxlZ7pUK8ACsqt820t68lks5q9XiAgaJpZM4Kvvna
.

--
Sent from my iPhone

I'll note projects often require an issue number to be present in PRs.
I think the most important thing for us is to take the feedback however we
can get it. We can restrict if it gets too much, but I don't think we have
that problem yet.
On Saturday, November 12, 2016, David Blevins<EMAIL_ADDRESS>wrote:

I missed the discussion. Why is it bad for people to submit ideas as
issues?
Do we want to use jira instead?
On Saturday, November 12, 2016, Heiko Braun<EMAIL_ADDRESS><javascript:_e(%7B%7D,'cvml','notifications@github.com');>> wrote:

Right, the idea is to prevent people from creating issues as a proposal,
rather then PR.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/microprofile/evolution/issues/8#issuecomment-260109399,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAFyznKrjcXBxlZ7pUK8ACsqt820t68lks5q9XiAgaJpZM4Kvvna
.

--
Sent from my iPhone

--
Sent from my iPhone

I agree with David.  I'll be honest, the current proposal format is confusing.  It doesn't seem to tackle what I would expect in a proposal.
With github, we can put in issue templates, and they'll cover what we need them to.

No, we want the proposal document to stick around. So we can refer to them later on. Issues don't serve this purpose.  As for the templates: You have to be more specific about what's confusing about the proposal template here https://github.com/microprofile/evolution/blob/master/0000-template.md IMO it's pretty straight forward and provides a good baseline to remind people what information is needed to submit a proposal.

But how do you refer to them? Having a title subject [config] might e.g. be ambiguous nowadays ;)
LieGrue,
strub

Am 15.11.2016 um 08:28 schrieb Heiko Braun<EMAIL_ADDRESS>No, we want the proposal document to stick around. So we can refer to them later on. Issues don't serve this purpose. As for the templates: You have to be more specific about what's confusing about the proposal template here https://github.com/microprofile/evolution/blob/master/0000-template.md IMO it's pretty straight forward and provides a good baseline to remind people what information is needed to submit a proposal.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

You can refer to them by ID, i.e. MP-0001 links to https://github.com/microprofile/evolution/blob/master/proposals/0001-config.md

I'm going to close this for now as I think we've reached a point where we're ok with leaving issues open for now.
We can revisit when/if it becomes a problem


Create a sample IWA directory containing a minimum viable IWA app

Codecov Report

:exclamation: No coverage uploaded for pull request base (main@5f203e3). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #33   +/-   ##
=======================================
  Coverage        ?   72.00%
=======================================
  Files           ?        6
  Lines           ?      125
  Branches        ?       17
=======================================
  Hits            ?       90
  Misses          ?       35
  Partials        ?        0

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


[Bug] Unnecessary update serialize/merge serialize in aggregated nodes

Enhancement
mysql> set new_planner_agg_stage=0;
Query OK, 0 rows affected (0.00 sec)

mysql> explain select count(distinct LO_SHIPMODE,LO_ORDERKEY) from lineorder_flat;
+---------------------------------------------------------------------------------+
| Explain String                                                                  |
+---------------------------------------------------------------------------------+
| PLAN FRAGMENT 0                                                                 |
|  OUTPUT EXPRS:39: count(distinct 17: LO_SHIPMODE, 1: LO_ORDERKEY)               |
|   PARTITION: UNPARTITIONED                                                      |
|                                                                                |
|   RESULT SINK                                                                   |
|                                                                                |
|   6:AGGREGATE (merge finalize)                                                  |
|   |  output: count(39: count(distinct 17: LO_SHIPMODE, 1: LO_ORDERKEY))         |
|   |  group by:                                                                  |
|   |  use vectorized: true                                                       |
|   |                                                                             |
|   5:EXCHANGE                                                                    |
|      use vectorized: true                                                       |
|                                                                                |
| PLAN FRAGMENT 1                                                                 |
|  OUTPUT EXPRS:                                                                  |
|   PARTITION: RANDOM                                                             |
|                                                                                |
|   STREAM DATA SINK                                                              |
|     EXCHANGE ID: 05                                                             |
|     UNPARTITIONED                                                               |
|                                                                                |
|   4:AGGREGATE (update serialize)                                                |
|   |  output: count(if(17 IS NULL, NULL, 1: LO_ORDERKEY))                        |
|   |  group by:                                                                  |
|   |  use vectorized: true                                                       |
|   |                                                                             |
|   3:Decode                                                                      |
|   |  <dict id 40> : <string id 17>                                              |
|   |  use vectorized: true                                                       |
|   |                                                                             |
|   2:AGGREGATE (merge serialize)                                                 |
|   |  group by: 1: LO_ORDERKEY, 40: LO_SHIPMODE                                  |
|   |  use vectorized: true                                                       |
|   |                                                                             |
|   1:AGGREGATE (update serialize)                                                |
|   |  STREAMING                                                                  |
|   |  group by: 1: LO_ORDERKEY, 40: LO_SHIPMODE                                  |
|   |  use vectorized: true                                                       |
|   |                                                                             |
|   0:OlapScanNode                                                                |
|      TABLE: lineorder_flat                                                      |
|      PREAGGREGATION: ON                                                         |
|      partitions=1/1                                                             |
|      rollup: lineorder_flat                                                     |
|      tabletRatio=192/192                                                        |
|      tabletList=44248,44250,44252,44254,44256,44258,44260,44262,44264,44266 ... |
|      cardinality=600037902                                                      |
|      avgRowSize=8.286715                                                        |
|      numNodes=0                                                                 |
|      use vectorized: true                                                       |
+---------------------------------------------------------------------------------+
51 rows in set (0.01 sec)

AGGREGATE (merge serialize) and (update serialize)  could convert to update/finalize

ref #441


Enabling Cypress to login to the self-service UI without utilizing Github Oauth

Value Statement
As VANotify platform using cypress to test the self service UI
I need Cypress to able to log in to the API with an email address and a password
So that Cypress can test login without authenticating via Github Oauth process
IN DEV AND STAGING!
Acceptance Criteria
GIVEN a cypress test has been started
WHEN cypress is verifying authenticated behavior
THEN cypress logs in to the API using an email and password
AND tests are then ran using the authenticated cypress user
GIVEN a user makes an API request to /login
WHEN in a lower environment i.e. dev or staging
AND that request contains a valid email address and password for an existing user
THEN the api response includes a JWT representing that existing user
GIVEN a user makes an API request to /login
WHEN in a lower environment i.e. dev or staging
AND that request contains an invalid email address and password
THEN the api response is a 401 error
Checklist

[x] Feature toggles, only in dev and staging
[x] Add new flask endpoint with no authentication
[x] Endpoint should take email address and plaintext password
[x] Lookup user by email address
[x] Hash password and compare to stored hash!
[x] Return JWT representing the user if all is well
[x] Call that endpoint in the cypress tests!

Assumptions

User Name and Password are stored in VAEC SSM
Acknowledge this approach is a slight gap in terms of testing the reality of user behavior re: logging in with Github Oauth, but the work required to test this at this moment outweighs the gap

Additional Info/Resources

Please consult ADR for full detail on how to implement this story: https://github.com/department-of-veterans-affairs/vanotify-team/blob/master/documents/adr/0012-authenticating-in-cypress.md

Reverse proxy configuration has to be updated here:
https://github.com/department-of-veterans-affairs/devops/tree/master/ansible/deployment/config/revproxy-vagov/templates/nginx_api_server.conf.j2#L255

Out of Scope

refactoring auth endpoints and proxy changes have been moved to #489

Open Questions

Verified all 3 scenarios,  all meet the acceptance criteria.  For the failed user story scenario, the Failed status received was 401 Unauthorized user and not 403 Forbidden.  The acceptance criteria needs to be updated to reflect 401 and not 403.  Moving the ticket to Signoff


How can I use an older version of ruby?

The documentation specifies >= 2.4 in a comment, as a hint towards the supported versions of Ruby.
I have a case where I want to use Ruby 2.3.3 (x64), how can I install this version on a Microsoft hosted agent?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 02568f8b-6928-c8f1-178a-79e4cb0d93e2
Version Independent ID: 1107622c-4165-dcff-741a-279757b35323
Content: Use Ruby Version task - Azure Pipelines
Content Source: docs/pipelines/tasks/tool/use-ruby-version.md
Product: devops
Technology: devops-cicd
GitHub Login: @DavidStaheli
Microsoft Alias: dastahel

Thanks for your question. It looks like you're working through an issue with your scenario or implementation, rather than an issue with the documentation. Here are a couple of options where you might consider asking your question:

Azure DevOps on Stack Overflow
Azure DevOps Support Bot


Create less objects and sets when creating findings id map

Codecov Report

Merging #2385 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@             Coverage Diff              @@
##             master    #2385      +/-   ##
============================================
+ Coverage     82.82%   82.83%   +<.01%
  Complexity     2138     2138
============================================
  Files           352      352
  Lines          6080     6081       +1
  Branches       1109     1109
============================================
+ Hits           5036     5037       +1
  Misses          475      475
  Partials        569      569

Impacted Files
Coverage Δ
Complexity Δ

.../io/gitlab/arturbosch/detekt/cli/IssueExtension.kt
87.5% <100%> (+0.4%)
0 <0> (ø)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 07a83d3...9208e6b. Read the comment docs.


Lower log level in messages that contain sensitive information

Is your feature request related to a problem? Please describe.
Currently, there are several places within the dataprepper codebase where error logs contain sensitive information. It would be nice to downgrade some of these to WARN or INFO so that error logs can be used by third parties for debugging if neccessary.
Describe the solution you'd like
Go through the codebase and lower the log level of any error messages that contain sensitive information inside the message.

Thanks @roshan-dongre for raising this important issue. There are two approaches I'm most interested in:

When logging errors, include a DEBUG line as well that logs out the events. This way, the level can be set to WARN or INFO for any given logger and the events are not included.
Include a special class that logs out Events. In this way, the Data Prepper admin has the option to turn on error logging for Events for all of Data Prepper.

I like option 2 that I mentioned above. I think this could be very useful since it would be possible to shut off all event logging by turning that logger OFF. And we could potentially expand it to include some sort of sample logging using the DEBUG level as well, if that were desired. This also follows patterns from other projects such as request logging in Apache HTTP which is controlled through a specific logger for that purpose.
Thoughts?

I created #1990 as a possible solution to this.


Remove unused LimitOffsetNode in AST builder

It looks that LimitOffsetNode file is restored by mistake when I do merge.
Re-remove the limit_offset.rs file

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
19 unchanged lines in 1 file lost coverage.
Overall coverage increased (+0.04%) to 98.622%

Files with Coverage Reduction
New Missed Lines
%

test-suite/src/tester/mod.rs
19
87.5%

Totals

Change from base Build<PHONE_NUMBER>:
0.04%

Covered Lines:
37298

Relevant Lines:
37819

💛  - Coveralls


Run artisan commands inside/for a module

Summary
It would be great if we can run artisan commands inside an application module. I tried to find if this feature already exists, but couldn't find anywhere. If it does, please guide me so I can close this request.
What & Why
A lot of packages now a days have their own generate commands for example Laravel Verbs:
php artisan verbs:event CustomerBeganTrial

This makes it difficult to maintain the application as for each creation we need to move the files and update the namespaces. It would be great if we can just specify --module= flag and it runs for that specific module. I see that it is a feature in internachi/modular and also somewhat similar feature in stancl/tenancy

Are you aware you can call module specific commands? ie php artisan module:make-controller MyAwesomeController Blog
would create a controller in a module called Blog.
I've seen the commands in modular it indeed that's cool. Not sure if that's something that can be supported with out structure. One to look into.


When doing search in TreeTable HIERARCHY_LEVEL eq 0 is added automatically

I am facing a issue with a TreeTable. Suppose I have a following rows binding:
rows="{ path : '/MY_TABLE', parameters : { countMode: 'Inline', treeAnnotationProperties : { hierarchyLevelFor : 'HIERARCHY_LEVEL', hierarchyNodeFor : 'HIERARCHY_RANK', hierarchyParentNodeFor : 'HIERARCHY_PARENT_RANK', hierarchyDrillStateFor : 'DRILL_STATE' } } }"
If I am doing a search in this grid table on a back-end, it seems that HIERARCHY_LEVEL eq 0 is added automatically. Is there a way to modify this sap.ui.model.odata.v2.ODataTreeBinding functionality?

Hello @zygimantus,
Thank you for sharing this finding. I've created an internal incident<PHONE_NUMBER>. The status of the issue will be updated here in GitHub.
Regards,
Nikolay Hristov
GitHub Dispatcher

Thank you @NHristov-sap.

Hello zygimantus,
can you provide more details on this issue? How exactly are you searching on the backend? Do you add a filter on the binding? Can you provide a sample where we can debug this issue?
Regards Sebastian

Hello, @HerzogIgzorn , yes, I am using a custom filter function via filter property on TreeTable which in the end filters like this: oTable.getBinding("rows").filter(oFilter, "Application"); Not sure if I would manage to provide a sample because it would require to host somehow odata service.

Hi @zygimantus, I would expect that almost all request from this TreeTable filter on the hierarchy level. This is by design.
What issue are you facing with this behavior? How would you like to change it?
Relevant documentation: https://ui5.sap.com/#/api/sap.ui.model.odata.v2.ODataTreeBinding%23overview

Closing due to inactivity. Please feel free to comment if there's new input.

I am also facing the hierarchy level issue as 0 by default filter is going to backend when i am doing a filter

Hi @zygimantus, I would expect that almost all request from this TreeTable filter on the hierarchy level. This is by design.
What issue are you facing with this behavior? How would you like to change it?
Relevant documentation: https://ui5.sap.com/#/api/sap.ui.model.odata.v2.ODataTreeBinding%23overview

@RandomByte This works nice for initial display of the table. The problem is when I want to filter with certain keywords (for example, 'name startsWith B') without considering hierarchy level , hierarchyLevel eq 0 (or rootLevel) is automatically added to the request sent to backend odata service. Is there a way to remove this deafault hierarchyLevel filter?

@ThomasChadzelek
Hi, thank you for your quick reply.
In my case, I bind TreeTable with OData V2 (operationMode SERVER) and rootLevel set to 1. After initial display (here only data of hierarchyLevel eq 1 is displayed), the requirement is to be able to filter this table with search keywords. I use this syntax to filter but there are no results.
oTreeTbl.getBinding("rows").filter(oMyFilter, FilterType.Application)
When I checked the network tab, the request was in this format (url-decoded)
$filter=hierarchyLevel eq 1 and (substringof('searchKeyword', description))
hierarchyLevel was added automatically, thus resulting in wrong filter.
Is it possible to remove this default filter?

Tracking internally as<PHONE_NUMBER>

Is this issue being fixed? May I ask the expected date of release?

Hi @HannaNguyen-new,

Is this issue being fixed? May I ask the expected date of release?

No, we are not even sure whether it is an issue on the client or server side. We need to investigate an example. To that end we had contacted a colleague by the same name as you. So far without a result.
What we can do here is to double-check expectations. We are displaying a hierarchy. When filtering or searching, the expectation is that all nodes matching the filter/search and all parents of these matching nodes are forming the hierarchy. It would then be possible to request level 0 and get all the matching nodes in level 0 plus all parents of matching nodes in level 0.
Is that also your expectation? Is that also how your service behaves?
Best regards
Mathias.

Hi, @uhlmannm
In our case, this is an issue on client side because the request is sent with hierarchyLevel eq 0 (rootLevel is 1 in our case though).
the expectation is that all nodes matching the filter/search and all parents of these matching nodes are forming the hierarchy
-> Our application uses sap.ui.table.TreeTable and I suppose this is what sap.ui.table.TreeTable expects to get. Our application returns results satisfying this condition  so as to form hierarchical structure( We use CAP java handlers to deal with this). Matching nodes are not necessarily in level 0 (or root level). Therefore, except for initial display, I think this default query is not necessary.
$filter=hierarchyLevel eq 1 and

Hi Hanna,
as written before, we need to analyze what is happening with an example. Please provide an example!
Also, if you are working for SAP, I strongly encourage you to contact me internally, as this makes organizing the analysis much easier.
Best regards
Mathias.

@uhlmannm
I'm not working for SAP, our team is developing an app using SAP technologies. It might take some time but I'll try providing a sample.

Hello,
I was able to have a deeper look at this issue. If you are using tree tables as mentioned above, the underlying tree binding requests the data. First all elements of the root level are requested. So the binding creates a request with the filter HIERARCHY_LEVEL eq 0 (as in the example above; other levels are also possible, for example 1 as decribed by HannaNguyen-new).
If the application now filters for any other property, the tree structure must not be corrupted, that means all parent nodes for the matches have to be contained in the result.
In the example above, $filter=hierarchyLevel eq 1 and (substringof('searchKeyword', description)), the backend service has to apply the non-tree-structural filters substringof('searchKeyword', description) first. The result has to contain all parent nodes up to the root for all matches. After that the filters for tree-structural properties have to be applied (for example hierarchyLevel eq 1), which filters the root elements of all matching results. That's the expected response for this request.
This is the way how TreeBindings work.
Best Regards,
Sven


Windows Servicify needs its first implementation (70 points)

https://github.com/CleverCodeCravers/WindowsServicify/blob/main/README.md

This is not done yet

Awesome!!


Add  tutorial about CoV-2 genome assembly from public data

This inital version still has some open TO DOs and needs more
explanations of some steps.

Merci!


Implementing the Dijkstra's algorithm

Feature ✅
Description

Implementation of the Dijkstra's algorithm.
Checklist:

[✅ ] I have read the project guidelines.
[✅] I have checked all the existing projects, before submitting a new project issue.
[✅] This issue will be meaningful for the project.
[✅] I will contribute more in future

Can You assign me this issue.

Can you assign me this, I will do it in C

@cs-mshah You are up for c++, @sarthak-21 it has been assigned to @cs-mshah
C and C++ are not distinguished here.

can you assign this to me? i will code in C++

Hi, can you assign this to me? I would like to do this in Python. Thanks.

@pratik-choudhari the PR for C++ has been done with documentation. Kindly check and accept the PR.

Is this issue still open, I would like to code Dijkstra's Algorithm in Java Thanks.

Hello, @cs-mshah
I'm excited to participate in Hacktoberfest and contribute to this repository. Please consider me for any relevant tasks or issues. I look forward to collaborating with the community.
Thank you!
SanidhayaAgarwal

Hi @SanidhayaAgarwal,
You can have a look at open issues and ask Pratik.


DS-2852 - Discovery label fix for authority display value

DSpace 6 port of https://github.com/DSpace/DSpace/pull/1701

Closing and reopening to restart tests

@tomdesair , thanks for this PR


Allow listing multiple databases in the MSSQL Recipe

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
We have MSSQL instances which have dozens of databases and it is cumbersome to have several different ingestion yaml files for one MSSQL instance.
Describe the solution you'd like
A clear and concise description of what you want to happen.
It would be nice to have the ability to list several databases in one ingestion yaml file instead of being limited to one database per config.
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.

Hi @man715!
We are now managing feature requests through our new portal to improve visibility & prioritize work into our public roadmap. Your request should be addressed here, which is currently underway. If we missed something, please create a new issue so we can gauge current interest from the Community & prioritize work accordingly.
We'll close out this issue in the meantime. Feel free to reach out to me on DataHub Slack with any questions!


[BUG] Client is crashing when trying to break gravestone

Describe the bug
Client is crashing when breaking a gravestone
Forgotten Graves Version
2.3.1
To Reproduce
A list of steps to reproduce your issue, i.e.:

Install https://www.curseforge.com/minecraft/modpacks/deathdusk
Die
Try to break gravestone

Additional context
https://bytebin.lucko.me/jfuhSeuW2a

https://github.com/TheButterbrotMan/Deathdusk/issues/10

Server is crashing also:
https://bytebin.lucko.me/JM50KTN3ne

So this is most likely the same issue as #34. I'd recommend updating to Forgotten Graves 2.4.1 (released yesterday) which should resolve this.


Upgrade to latest wasmtime and component model

I've been experimenting with upgrading to the latest wasmtime (i.e. the main branch for now, but I would use the most recent release in a PR).  As a consequence of the upgrade, instantiate_smw fails to build due to its use of the module linking API, which has been removed as of wasmtime 0.36.
I'd like to update instantiate_smw to use the component model, although I realize it's not yet fully implemented as of this writing.  I don't know whether wasmtime's implementation is complete enough yet for wit-bindgen's needs; one goal of this experiment is to answer that question.  Either way, I'm eager to start using the component model in other projects, so it will be helpful to understand the specific limitations of the current (partial) implementation -- particularly with regard to linking modules together.  I'd also be interested in helping move that implementation forward if there are opportunities to do so.
My current (possibly naive) strategy is to change instantiate_smw to create a component::Component which instantiates both the spidermonkey and input module, passing the former as an argument to the latter.  Then I would instantiate that component using a component::Linker, call wizer.initialize on the spidermonkey module instance, and return as before.  This raises a few questions:

Given that the wit_bindgen_wasmtime::export! and wit_bindgen_wasmtime::import! macros (not to mention wasmtime_wasi::add_to_linker, etc.) expect a module Linker, not a component Linker, it's not clear to me how to use them in a component context.  Is there (or will there be) some way to add a module Linker into a component Linker for the purpose of dynamic instantiation?  Or am I thinking about it the wrong way?
More generally, what's the vision for code which previously used module linking and will eventually need to transition to the component model?  Will there be a simple recipe to follow, or will big (e.g. architectural) changes be necessary?

Reading over what I wrote above, I realize this might be more appropriate as an issue in the wasmtime repo.  If so, I'll be happy to move it over there.

I think moving it to the wasmtime repo would make sense. You could make your first bullet point its own question here if you do move this one since it is more specifically about how wit-bindgen should work.
e.g. "wit_bindgen_wasmtime is not compatible with component Linker"

BTW, the last paragraph in this comment indicates that we should just disable the spidermonkey tests.  So perhaps the answer to this issue is: go ahead and upgrade wit-bindgen to the latest wasmtime and disable the affected tests until the component model is ready.  If that's correct, I can make a PR for that.

We discussed this during today's wasmtime project meeting.  The conclusion was that disabling the spidermonkey tests for now is a reasonable choice until ecosystem support (not just wasmtime support) is mature enough to allow them to be re-enabled with minimal effort.

BTW, Alex answered answered my question about add_to_linker here: https://github.com/bytecodealliance/wasmtime/issues/4303#issuecomment-1165629805


Update directives page with new directives, organization

Reorganized the index into a table much like for decorators
Changed the categorization a bit
4 new sections: choose, join, map, when, range

I'm going to split this into multiple commits...

Ok, it's now split. The second commit is much easier to review.


add & modify: add func getBytes32 and modify miner.list

Codecov Report

Merging #235 into dev-1.5 will decrease coverage by 0.01%.
The diff coverage is 0%.

@@             Coverage Diff             @@
##           dev-1.5     #235      +/-   ##
===========================================
- Coverage    14.05%   14.03%   -0.02%
===========================================
  Files          284      284
  Lines        19268    19289      +21
===========================================
  Hits          2708     2708
- Misses       16560    16581      +21

Impacted Files
Coverage Δ

libchannelserver/ChannelServer.h
0% <ø> (ø)
:arrow_up:

libconsole/ConsoleServer.h
0% <ø> (ø)
:arrow_up:

libconsole/ConsoleServer.cpp
0% <0%> (ø)
:arrow_up:

libstorage/EntryPrecompiled.cpp
92.3% <0%> (-7.7%)
:arrow_down:

libethcore/ABI.h
72.36% <0%> (-6.21%)
:arrow_down:

libp2p/Host.h
0% <0%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e6b2c8f...4ef7f70. Read the comment docs.


M/import messengers

Description
A clear and concise description of the features you're adding in this pull request.
Additional context
Add any other context about the problem you're solving.
Metadata

Fixes #[Link to Issue]

A thorough review of each instance of msg.sender is required to ensure that the aliasing is done appropriately

All usage of OVM_ETH needs further inspection, as it will be migrated to be protocol level ETH with the upgrade to bedrock

Closing this since it's no longer relevant.


add transform to GET

Docs clearly say PUT/POST/PATCH gets addRequestTransform but I could sure use it for a GET.  Any reason it's not supported?
If philosophically, then let's discuss.
If just not done yet, then I'd love to add it!

The only mutable part of addRequestTransform is the data.   Data isn't passed unless its PUT/POST/PATCH.
I have a feeling you're after modifying the headers.  Or maybe appending QSVs?
I'm sure we can make it work, lemme know your use case!  🎉

appending a QSV, you are correct.   But I could very likely be modifying headers for any client that demands a login token.

Ok @GantMan 0.5.0 has just been released with mutable everything for addRequestTransform (see #28 for the specifics).
For example:
api.addRequestTransform(request => {
  request.headers = { 'X-Kanye': 'Imma let u finish but...' }
  request.params['page'] = 42
  delete request.params.secure
  request.url = request.url.replace(/\/v1\//, '/v2/')
})

I feel like I just handed you a loaded gun.
Good luck!

I should be ok with a loaded gun


Feature/deploy affected storybooks

Each storybook can now be visited like this:
https://sebgroup.github.io/green/pr-216/chlorophyll
https://sebgroup.github.io/green/pr-216/angular
https://sebgroup.github.io/green/pr-216/react
And so on...

:tada: This PR is included in version<EMAIL_ADDRESS>:tada:
The release is available on:

npm package (@beta dist-tag) :package::rocket:
GitHub release :package::rocket:

:tada: This PR is included in version<EMAIL_ADDRESS>:tada:
The release is available on:

npm package (@beta dist-tag) :package::rocket:
GitHub release :package::rocket:

:tada: This PR is included in version<EMAIL_ADDRESS>:tada:
The release is available on:

npm package (@beta dist-tag) :package::rocket:
GitHub release :package::rocket:

:tada: This PR is included in version<EMAIL_ADDRESS>:tada:
The release is available on:

npm package (@beta dist-tag) :package::rocket:
GitHub release :package::rocket:


Stuck at "Run maestro help command to get help specific to a subcommand." on MacOS M2

Describe the bug
After installing Maestro by following the guide: https://maestro.mobile.dev/getting-started/installing-maestro I keep getting the message "Run maestro help command to get help specific to a subcommand." on every command.
To Reproduce
Follow the installation guide and run the maestro --version command
Expected behavior
It should be able to run/start maestro instead of returning the above message
Screenshots

Environment information (please complete the following information):

Maestro version: ? (should be the latest available version)
Platform: -
Framework: React Native
Device model and OS version: -
Simulator, emulator or physical device
Host Mac M2 Pro

Hi @corne-de-bruin , try maestro -v

That's giving the same result

Apparently there was an NPM package installed (maestro) that caused this behaviour


Fix Typos

Fix typos after adding opening and closing braces - { and } are braces, not brackets 😜.

There are a whole lot of changes here that will undo recent commits. Were your changes made using the latest master?

Good catch. I forked the master and created a local clone, but I edited the file from the downloaded version from the forum link, copied it over the file in my clone and pushed it back to my fork.
I guess you can just drop the PR your end, and I'll submit another being more careful this time?

These changes are nice to have (anything to make script more clear), if you could resubmit with up-to-date changes I'll merge

I guess while you're at it, might as well remove some commented out code that was left "just in case". I do like the date comments tho, cause I forget what was edited and why without having to perk into the project history. I personally think those comments provide benefit which browsing and editing the code. Is it helpful to any of you, or do you consider it clutter?

I'm fine with date comments, and yes most of the "just in case" code really isn't necessary like here
git stores all the changes ever made so if we did need to go make it is stored there
GitHub allows maintainers to edit PR's so I should be able to clean up this just in case code and have fade2gray's fixes all in one commit

I'm fine with date comments, and yes most of the "just in case" code really isn't necessary like here

Ok... I will try to do a better job cleaning up my messes. Sorry about that.

Ok... I will try to do a better job cleaning up my messes. Sorry about that.

No worries, it was all commented out so it doesn't affect end user experience

if @fade2gray doesn't clean up my mess with this commit, I will do it as part of my next submission.


Try-Except in AER2GEO

There is a problem with multi-dimensional arrays containing nans. This correction returns 'True' when the problem occurs and aborts the iteration. The value is Nan anyway.

This is based on an out of date version. The conversion is now closed form (more accurate, faster)