how to allow only table to expand one row at a time

TanStack Table version
e.g. @tanstack/react-table": "^8.11.0
Framework/Library version
e.g. React 18.2.0
Describe the bug and the steps to reproduce it
how i can that just one expand will be open
Your Minimal, Reproducible Example - (Sandbox Highly Recommended)
.
Screenshots or Videos (Optional)
.
Do you intend to try to help solve this bug with your own PR?
None
Terms & Code of Conduct

[X] I agree to follow this project's Code of Conduct
[X] I understand that if my bug cannot be reliable reproduced in a debuggable environment, it will probably not be fixed and this issue may even be closed.

this allows limiting main rows to only 1 open but allows normal expand logic in sub rows
        onClick: () => {
                      const state = table.getState();
                      const expanded = structuredClone(state.expanded) as Record<
                        string,
                        boolean
                      >;
                      if (row.id.includes('.')) {
                        expanded[row.id] = !row.getIsExpanded();
                        table.setExpanded(expanded);
                        return;
                      }

                      table.setExpanded(row.getIsExpanded()?{}:{ [row.id]: true });
                      // return row.getToggleExpandedHandler();
                    },

This is what I do:
onClick: () => table.setExpanded({ [row.id]: !row.getIsExpanded() }), //only 1 detail panel open at a time

^Above advice is about the same and good too.
Let's leave issues for bugs and convert this into a discussion


Add ability to ignore certain props from jsx-sort-props

Useful when using React built-ins (ie. key, ref), or when you want a group of props to be together but the rest to be alphabetically sorted. For instance, I prefer having key and ref props to declared at the top before any other props, but all other props should be alphabetized.
Looking at the implementation, this looks like it should be fairly easy and I can make a PR soon, but I was wondering if there was any other feedback (maybe I missed something that already allows you to do this?).

key and ref are controllable with the reservedFirst option, added in #1134.


elastic search indexing not working on local installation

Details
On a local RTD version as 09f8282be35c20dcca42c85d3f845bba8b784cfe each project build returns the exception below and thus search does not work.
Elastic search is from docker image "elasticsearch:1.5.2" which should match the elasticsearch-py 1.5.0 from requirements. Same result with elasticsearch:1.7.6 docker image.
Expected Result
Elastic search indexes updated after project build.
Actual Result
The exception ElasticsearchIllegalArgumentException[Can't specify parent if no parent field has been configured] is raised
[28/Feb/2018 04:39:37] readthedocs.projects.tasks:779[21905]: INFO (Search Index) Sending Data: pip [user_guide news logic cookbook configuration development usage index quickstart installing reference/pip_show reference/pip reference/pip_hash reference/pip_freeze reference/pip_search reference/pip_uninstall reference/pip_download reference/index reference/pip_list reference/pip_install reference/pip_wheel]
[28/Feb/2018 04:39:37] readthedocs.restapi.utils:104[21905]: INFO Updating search index: project=pip pages=[user_guide news logic cookbook configuration development usage index quickstart installing reference/pip_show reference/pip reference/pip_hash reference/pip_freeze reference/pip_search reference/pip_uninstall reference/pip_download reference/index reference/pip_list reference/pip_install reference/pip_wheel]
[28/Feb/2018 04:39:37] celery.app.trace:248[21905]: ERROR Task readthedocs.projects.tasks.sync_callback[cfaf9e6d-6c5a-448b-8d02-9d4b205dba95] raised unexpected: RequestError(400, u"ElasticsearchIllegalArgumentException[Can't specify parent if no parent field has been configured]", {u'status': 400, u'error': u"ElasticsearchIllegalArgumentException[Can't specify parent if no parent field has been configured]"})
Traceback (most recent call last):
  File "/home/rm/src/readthedocs/rtd/local/lib/python2.7/site-packages/celery/app/trace.py", line 374, in trace_task
    R = retval = fun(*args, **kwargs)
  File "/home/rm/src/readthedocs/rtd/checkouts/readthedocs.org/readthedocs/projects/tasks.py", line 1092, in sync_callback
    update_search(version_pk, commit=commit)
  File "/home/rm/src/readthedocs/rtd/local/lib/python2.7/site-packages/celery/local.py", line 191, in __call__
    return self._get_current_object()(*a, **kw)
  File "/home/rm/src/readthedocs/rtd/local/lib/python2.7/site-packages/celery/app/task.py", line 380, in __call__
    return self.run(*args, **kwargs)
  File "/home/rm/src/readthedocs/rtd/checkouts/readthedocs.org/readthedocs/projects/tasks.py", line 789, in update_search
    delete=delete_non_commit_files,
  File "/home/rm/src/readthedocs/rtd/checkouts/readthedocs.org/readthedocs/restapi/utils.py", line 169, in index_search_request
    page_obj.bulk_index(index_list, parent=project.slug, routing=route)
  File "/home/rm/src/readthedocs/rtd/checkouts/readthedocs.org/readthedocs/search/indexes.py", line 142, in bulk_index
    bulk_index(self.es, docs, chunk_size=chunk_size)
  File "/home/rm/src/readthedocs/rtd/local/lib/python2.7/site-packages/elasticsearch/helpers/__init__.py", line 182, in bulk
    for ok, item in streaming_bulk(client, actions, **kwargs):
  File "/home/rm/src/readthedocs/rtd/local/lib/python2.7/site-packages/elasticsearch/helpers/__init__.py", line 124, in streaming_bulk
    raise e
RequestError: TransportError(400, u"ElasticsearchIllegalArgumentException[Can't specify parent if no parent field has been configured]")

So this makes the indexing works fine but definetely not a fix
diff --git a/readthedocs/search/indexes.py b/readthedocs/search/indexes.py
index 1b2ede6a..f71cf934 100644
--- a/readthedocs/search/indexes.py
+++ b/readthedocs/search/indexes.py
@@ -132,7 +132,7 @@ class Index(object):
                 '_id': source['id'],
                 '_source': source,
             }
-            if parent:
+            if parent and False:
                 doc['_parent'] = parent
             if routing:
                 doc['_routing'] = routing

@xrmx do you get this error with ES 1.3.9 too?

@gaborbernat Ii'm using elasticsearch from docker and there's no docker image for 1.3.9. Anyway I'm dog fooding the elasticsearch5 branch so if I think we can close this as dup of #3803.

I see. I'm using 1.3.9 and still getting this error. ES5 will be nice, might take a few days to merge though :thinking:

The guide was merged, you can see it in https://docs.readthedocs.io/en/latest/custom_installs/elasticsearch.html


Proposal: Separate submodules for different UUID versions

I expect it's rare for someone using this library to want both v1() and v4() support.  99% of the time they'll only care about one flavor.  Thus, I think it would make sense to separate the code for the different versions into separate submodules.  So, for example ...
var uuid = require('uuid/v1'); // returns v1() for timestamp-based UUIDs
var uuid = require('uuid/v4'); // returns v4() for random UUIDs

One immediate benefit is that if you don't use v1(), you don't need to deploy the v1() code, which is ~75% of the code in this module.
Another benefit is that it becomes straight-forward to add support for v3() and v5() UUIDs, which has occasionally been requested, but that I resisted in the original node-uuid library because it required shipping JS code to do MD5 / SHA hashes.  But now that uuid puts the burden for packaging on the user, it'd be straight-forward to implement those versions as well (and provide the requisite md5.js/md5-browser.js or sha.js/sha-browser.js modules as needed for node/browser support).
Thoughts?  Is this a reasonable direction to take this library?

👍 from me. No maintenance burden on our end to split the code out into the separate files.
Eventually this won't even be needed with the various "tree shaking" and optimization features going into rollup and webpack bundlers. They will be able to remove functions from the bundle which are not used.

I just ran a yarn install with uuid 3.0 and am using the code from the readme:
import {v4} from 'uuid/v4';
...
// later using v4() to generate the uuid

Seeing this in terminal:
ERROR in ./core/js/ui/TextInput.jsx
Module not found: Error: Cannot resolve module 'uuid/v4' in /Users/przybylski/retrofit/dev/code/front-end/core/js/ui
@ ./core/js/ui/TextInput.jsx 19:9-27
Any idea why this would be happening?

Hmm, looks like yarn is still pulling the version that has uuid.js in the code hence why this isn't working. Any way you can publish a new version to npm to fix this?

@defunctzombie - based on your comments on #159, I'll let you publish this.

Released in v3.0.1

@defunctzombie  Does it mean that the uuid library is tree-shakeable? Do you need to declare anything within the sideEffects section?


Add Foreign Keys to naming conventions

I've noticed we have this problem in a few of our ELA-related entities, and it makes changing them difficult. @pbrisbin and I already chatted a bit about this over Slack. Let me know if y'all have thoughts.

@jdreaver yeah, this is a little confusing because it's really both a Haskell and DB issue. We have some tables where the DB column is prefixed like this, and we've also prefixed the Haskell entity field name, e.g.:
CREATE TABLE public.ela_adaptive_skill_practice_paragraphs (
    id integer NOT NULL,
    ela_adaptive_skill_practice_content_id uuid NOT NULL,
    type text NOT NULL,
    content text NOT NULL,
    caption text,
    "position" integer NOT NULL,
    CONSTRAINT valid_ela_adaptive_skill_practice_paragraph_position CHECK (("position" >= 0))
);

and
share [mkPersist sqlSettings, mkMigrate "migration"] [persistLowerCase|
ElaAdaptiveSkillPracticeParagraph sql=ela_adaptive_skill_practice_paragraphs
  elaAdaptiveSkillPracticeContentId ElaAdaptiveSkillPracticeContentId
  type ElaParagraphType
  content Text
  caption Text Maybe
  position Natural
  UniqueElaAdaptiveSkillPracticeParagraphElaAdaptiveSkillPracticeContentIdPosition  elaAdaptiveSkillPracticeContentId position
  deriving Show Eq Generic
|]

This is bad because AdaptiveSkillPractice isn't right. It should be SkillsPractice. However, because of this over-prefixing, I can't quick-fix it because the extra prefixing is now part of the JSON API.
Maybe this is a better motivating example?

Also, there's definitely a switch in the quasiquoter syntax to use a different field name than what the DB column actually looks like.

Ah that example makes more sense. From how this rule is written it looks like a primarily Haskell concern though instead of a schema naming concern. I would phrase any rules here like this:

In our schema, don't over-prefix names (i.e. ela_adaptive_skill_practice_content_id should be content_id or whatever it should be)
In our Haskell entities, use the exact same column names as our schema, just in camelCase instead of snake_case

This gives us the naming we want and keeps out Haskell names consistent with our schema, so there are no surprises between them. To be clear, I'm totally in agreement that this over-prefixing is bad. I'm just trying to simplify the rules we use in the guide, and I also think saying "just use the SQL column names in camelCase" is generally what we want anyway.
Having our DB column names be part of the JSON schema is unfortunate :cry:


Spring Boot Cache: ehcache support

Work in progress.

More work than expected, so increasing the bounty

cache/common shared kernel
cache/simple
cache/ehcache

Thanks a lof for all your work here @pblanchardie !

You're welcome, thanks for your help!

@pascalgrimaud https://opencollective.com/generator-jhipster/expenses/60551

@pblanchardie : approved, thanks so much for helping this project! <3


QC Support of new batching variables

Add QC support for the following variables:

“extraction_date”: (data type: date YYYY-MM-DD) required, non-unique: metabolite extraction date.
“acquisition_date”: (data type: date), required: date for the process of collecting and recording mass spectral data from samples. Two possible formats:

Preferred: MM/DD/YYYY HH:MM:SS AM/PM
Alternative: YYYY-MM-DD (with no time provided)

“lc_column_id”: LC column unique identifier (data type: character): Part_Number-Serial_number (e.g WATER-2345395, AGILENT-68797904)

Release v0.8.7


handle spaces in new template IDs

when creating a template, if you put a space in the template ID, Sinopia saves the template successfully,

and lists it in the Resource Templates tab, but when you try to open it you get an error
once we have literal validation we could validate this field and make sure user doesn't enter spaces but for now proposed solution is for Sinopia to replace spaces with underscore upon saving
(see #2894 for background)

Superceded by #2997.


one-to-one relationship accepts (->first()) and returns the first record in the table however it's related to the model used by or not

Laravel Version: 6.0
PHP Version:7.2
Database Driver & Version:MYSQL

Description:
As i know has if i used one-to-one relationship it will return one record using the foreign key but the relation accept (->first()) and returns the first record in the table
My Models
User Model
protected $guarded = ['id'];
public function activation()
{
return $this->hasOne(Activation::class, 'user_id', 'id');
}
Activation Model
protected $fillable=['token']
###Steps To Reproduce:
in controller

retrun auth()->user->activation()    //returns the activation of the user as normal
2.return auth()->user->activation->first()    ///// returns the first record of the activation table however it's for this user or not
return auth()->user->activation()->first()   //returns the activation of the user as normal

$user->activation returns a single instance of the Activation model. Calling ->first() on a model instance will forward the call to the underlying query builder, which is the same as calling Model::first().
For your particular use case, you should not call auth()->user->activation->first(). Instead, call either auth()->user->activation()->first() or auth()->user->activation to get the user's activation.

Hi there,
Thanks for reporting but it looks like this is a question which can be asked on a support channel. Please only use this issue tracker for reporting bugs with the library itself. If you have a question on how to use functionality provided by this repo you can try one of the following channels:

Laracasts Forums
Laravel.io Forums
StackOverflow
Discord
Larachat
IRC

However, this issue will not be locked and everyone is still free to discuss solutions to your problem!
Thanks.

I knew How To Work Around this Issue as i said above and how @36864 suggested,
but is this a normal  behaviour ?
to return first record of the table activations which not related to the user when using
auth()->user->activation->first()

Yes, there are many cases like this with Eloquent. If it's a one-to-one, you already have a model so you shouldn't call "first".


Lint rule for AmplifyUserError and AmplifyFault

Description
We should lint for the use of the Error base class and point developers to use AmplifyUserError or AmplifyFault instead.
Using Error in tests or scripts should continue to be allowed

In addition . Usage of AmplifyUserError and AmplifyFault in CDK packages should be forbidden. (which could be separate rule).
Perhaps we need two rules:

no-amplify-errors (to cover the above comment)
prefer-amplify-errors (to cover original ask above)


Router: use state.location.href

Passes full href to sheet-router instead of just pathname.
(started over on #279 to avoid spending time on git today 💀)

haha, yay :sparkles:

merging! - sorry for the wait, I have like no reason to hah


how add button to initial notification ?

how add button named "Disconnect" in AndroidNotificationOptions ?
my simple code is here .
const AndroidNotificationOptions(
      channelId: 'parameter_channel',
      channelName: 'Parameters',
      channelDescription: 'This notification appears when the reading begaz params running.',
      channelImportance: NotificationChannelImportance.LOW,
      priority: NotificationPriority.LOW,
      visibility: NotificationVisibility.VISIBILITY_PRIVATE,
      playSound: false,
      enableVibration: false,
      iconData: NotificationIconData(
        resType: ResourceType.mipmap,
        resPrefix: ResourcePrefix.ic,
        name: 'launcher',
      ),
    ),

The feature to add a button to a notification is not implemented yet. I'll set it as a feature to be added in the future.

I checked the Android official documentation, but there are many difficulties in adding button functions to this plugin. This is because Dart code cannot be guaranteed to work normally even in the background, and accessibility with TaskHandler must also be considered.
Let's try implementing it by creating a new branch.

Thanks for everything.

@alishe79
Add the following line to your pubspec.yaml file.
dependency_overrides:
  flutter_foreground_task:
    git:
      url: https://github.com/Dev-hwang/flutter_foreground_task.git
      ref: add_notification_button

Run the command.
flutter clean
flutter pub get

Use the buttons option in the FlutterForegroundTask.init function as shown below.
Future<void> _initForegroundTask() async {
    await FlutterForegroundTask.init(
      androidNotificationOptions: AndroidNotificationOptions(
        channelId: 'notification_channel_id',
        channelName: 'Foreground Notification',
        channelDescription: 'This notification appears when the foreground service is running.',
        channelImportance: NotificationChannelImportance.LOW,
        priority: NotificationPriority.LOW,
        iconData: const NotificationIconData(
          resType: ResourceType.mipmap,
          resPrefix: ResourcePrefix.ic,
          name: 'launcher',
        ),
        buttons: [
          const NotificationButton(id: 'sendButton', text: 'Send'),
          const NotificationButton(id: 'testButton', text: 'Test'),
        ],
      ),
      iosNotificationOptions: const IOSNotificationOptions(
        showNotification: true,
        playSound: false,
      ),
      foregroundTaskOptions: const ForegroundTaskOptions(
        interval: 5000,
        autoRunOnBoot: true,
        allowWifiLock: true,
      ),
      printDevLog: true,
    );
  }

And override the onButtonPressed function in the TaskHandler implementation class.
class FirstTaskHandler extends TaskHandler {
  @override
  Future<void> onStart(DateTime timestamp, SendPort? sendPort) async {

  }

  @override
  Future<void> onEvent(DateTime timestamp, SendPort? sendPort) async {

  }

  @override
  Future<void> onDestroy(DateTime timestamp) async {

  }

  @override
  void onButtonPressed(String id) {
    // Called when the notification button on the Android platform is pressed.
    print('onButtonPressed >> $id');
  }
}

I will do more testing and upgrade the plugin. First, try using the plugin by overriding the dependency.

The plugin has been updated. You can upgrade to version 3.5.0.
dependencies:
  flutter_foreground_task: ^3.5.0

In Android 11 and lower versions, the notification action button may not be displayed properly. This is because the notification importance is set LOW, so the notification is not in an expanded state. Therefore, the user must extend the notification or set the notification importance to HIGH as shown below.

Future<void> _initForegroundTask() async {
    await FlutterForegroundTask.init(
      androidNotificationOptions: AndroidNotificationOptions(
        channelId: 'notification_channel_id',
        channelName: 'Foreground Notification',
        channelDescription: 'This notification appears when the foreground service is running.',
        channelImportance: NotificationChannelImportance.HIGH,  // here
        priority: NotificationPriority.HIGH,  // here
        buttons: [
          const NotificationButton(id: 'sendButton', text: 'Send'),
          const NotificationButton(id: 'testButton', text: 'Test'),
        ],
      ),
      iosNotificationOptions: const IOSNotificationOptions(),
      foregroundTaskOptions: const ForegroundTaskOptions(),
      printDevLog: true,
    );
  }

This greate :) ! Thanks for work.

Hi! Is it posible to update button text while service is running?


Can't install via composer:  Installation request for symfony/symfony (installed at v3.4.3, required as 3.4.*) -> satisfiable by symfony/symfony[v3.4.3].

Steps to reproduce:
$ composer create-project symfony/framework-standard-edition test
$ composer require "dbdiff/dbdiff:@dev"
Log:
./composer.json has been updated
Loading composer repositories with package information
Updating dependencies (including require-dev)
Your requirements could not be resolved to an installable set of packages.

  Problem 1
    - Conclusion: don't install dbdiff/dbdiff dev-master
    - Conclusion: remove symfony/symfony v3.4.3
    - Installation request for dbdiff/dbdiff @dev -> satisfiable by dbdiff/dbdiff[dev-better-ci-coverage, dev-master].
    - Conclusion: don't install symfony/symfony v3.4.3
    - dbdiff/dbdiff dev-better-ci-coverage requires symfony/yaml 2.8.*@dev -> satisfiable by symfony/yaml[v2.8.0, v2.8.1, v2.8.10, v2.8.11, v2.8.12, v2.8.13, v2.8.14, v2.8.15, v2.8.16, v2.8.17, v2.8.18, v2.8.19, v2.8.2, v2.8.20, v2.8.21, v2.8.22, v2.8.23, v2.8.24, v2.8.25, v2.8.26, v2.8.27, v2.8.28, v2.8.29, v2.8.3, v2.8.30, v2.8.31, v2.8.32, v2.8.33, v2.8.4, v2.8.5, v2.8.6, v2.8.7, v2.8.8, v2.8.9].
    - don't install symfony/yaml v2.8.0|don't install symfony/symfony v3.4.3
    - don't install symfony/yaml v2.8.1|don't install symfony/symfony v3.4.3
    - don't install symfony/yaml v2.8.10|don't install symfony/symfony v3.4.3
    - don't install symfony/yaml v2.8.11|don't install symfony/symfony v3.4.3
    - don't install symfony/yaml v2.8.12|don't install symfony/symfony v3.4.3
    - don't install symfony/yaml v2.8.13|don't install symfony/symfony v3.4.3
    - don't install symfony/yaml v2.8.14|don't install symfony/symfony v3.4.3
    - don't install symfony/yaml v2.8.15|don't install symfony/symfony v3.4.3
    - don't install symfony/yaml v2.8.16|don't install symfony/symfony v3.4.3
    - don't install symfony/yaml v2.8.17|don't install symfony/symfony v3.4.3
    - don't install symfony/yaml v2.8.18|don't install symfony/symfony v3.4.3
    - don't install symfony/yaml v2.8.19|don't install symfony/symfony v3.4.3
    - don't install symfony/yaml v2.8.2|don't install symfony/symfony v3.4.3
    - don't install symfony/yaml v2.8.20|don't install symfony/symfony v3.4.3
    - don't install symfony/yaml v2.8.21|don't install symfony/symfony v3.4.3
    - don't install symfony/yaml v2.8.22|don't install symfony/symfony v3.4.3
    - don't install symfony/yaml v2.8.23|don't install symfony/symfony v3.4.3
    - don't install symfony/yaml v2.8.24|don't install symfony/symfony v3.4.3
    - don't install symfony/yaml v2.8.25|don't install symfony/symfony v3.4.3
    - don't install symfony/yaml v2.8.26|don't install symfony/symfony v3.4.3
    - don't install symfony/yaml v2.8.27|don't install symfony/symfony v3.4.3
    - don't install symfony/yaml v2.8.28|don't install symfony/symfony v3.4.3
    - don't install symfony/yaml v2.8.29|don't install symfony/symfony v3.4.3
    - don't install symfony/yaml v2.8.3|don't install symfony/symfony v3.4.3
    - don't install symfony/yaml v2.8.30|don't install symfony/symfony v3.4.3
    - don't install symfony/yaml v2.8.31|don't install symfony/symfony v3.4.3
    - don't install symfony/yaml v2.8.32|don't install symfony/symfony v3.4.3
    - don't install symfony/yaml v2.8.33|don't install symfony/symfony v3.4.3
    - don't install symfony/yaml v2.8.4|don't install symfony/symfony v3.4.3
    - don't install symfony/yaml v2.8.5|don't install symfony/symfony v3.4.3
    - don't install symfony/yaml v2.8.6|don't install symfony/symfony v3.4.3
    - don't install symfony/yaml v2.8.7|don't install symfony/symfony v3.4.3
    - don't install symfony/yaml v2.8.8|don't install symfony/symfony v3.4.3
    - don't install symfony/yaml v2.8.9|don't install symfony/symfony v3.4.3
    - Installation request for symfony/symfony (locked at v3.4.3, required as 3.4.*) -> satisfiable by symfony/symfony[v3.4.3].

Installation failed, reverting ./composer.json to its original content.

Hi! You try to install dbdiff to a project which uses symfony packages, and dbdiff, in its turn, depends on some symfony packages of different version. They conflict. As a most reasonable solution you can install dbdiff separately, make it probably global. Or install it to a subfolder of your project and run from there.

Would still make sense to composer update this project at some point, because it is using 3 years old versions of its dependencies while it is even likely that the interfaces did not change that much and would only cause marginal refactoring.

Hi,
I have so diligently the same problem.
I already have symfony / yaml in my project but in the 3.4 version.I am not able to install dbdiff  the composer because it says the dependency is 2.8.
The problem lies more to it that the code from here is 2 up 3 years old. I found the solution really great and was not able to find a better one like this, for my use case.
Maybe someone has an alternative that offers about the same?
Or does someone have a fork of it that is a bit more uptodate in dependency and/or code?

Until then you can install dbdiff as a standalone project and still use it in another one through CLI.

Yes I know, but I want to extend the DBDiff classes and use it native in my project.

Check #109


Add hover effect on "Add" button

Is your feature request related to a problem? Please describe.
The "add" button doesn't have any hover effect nor any animation. Would like to add that.
I can work on this.

Describe the solution you'd like
I will be adding pointer cursor and give some basic hover effect to make the button dynamic
Describe alternatives you've considered
No response
Additional context
No response

I would like to work on this issue can u please assign me. @dhrumishah

Assign me!

Hi @dhrumishah , I recently reviewed your website and codebase, and I noticed an opportunity to enhance the appearance of the "add" button doesn't have any hover effect nor any animation. I suggest making improvements by incorporating better hover effect with responsive design. I am confident that I can contribute significantly to enhancing the web page's appearance. Please assign this issue to me under GSSOC'23. Thank you!

can you please assign me this issue.

I am interested to work on this issue please assign me this task under GSsoc

@J0SAL  I added the hover effect on the add button. Assign me this task for better enhancement

I have been added the hover effect in "Add " button .Can you assign me this task for more enhancement and changes.

Hey @dhrumishah, the behavior is intentional.
Till the form is incomplete, Add button will stay disabled, and hence there won't be any hover-effect.
However, once you fill out the form, you'll see that button will get enabled and will hence have hover-effect.


ZEE5 Broken site for few videos [No video formats found!]

Checklist

[X] I'm reporting a broken site
[X] I've verified that I'm running yt-dlp version 2022.02.04. (update instructions)
[X] I've checked that all provided URLs are alive and playable in a browser
[X] I've checked that all URLs and arguments with special characters are properly quoted or escaped
[X] I've searched the bugtracker for similar issues including closed ones. DO NOT post duplicates
[X] I've read the guidelines for opening an issue
[ ] I've read about sharing account credentials and I'm willing to share it if required

Region
No response
Description
Video URL : https://www.zee5.com/tv-shows/details/sa-re-ga-ma-pa-2021/0-6-3497/sa-re-ga-ma-pa-2021-auditions-round-1/0-1-6z526594
Few videos are giving broken site issue.
Verbose log
[debug] Command-line config: ['https://www.zee5.com/tv-shows/details/sa-re-ga-ma-pa-2021/0-6-3497/sa-re-ga-ma-pa-2021-auditions-round-1/0-1-6z526594', '--verbose']
[debug] Encodings: locale UTF-8, fs utf-8, out utf-8, err utf-8, pref UTF-8
[debug] yt-dlp version 2022.02.04 [c1653e9ef] (zip)
[debug] Lazy loading extractors is disabled
[debug] Python version 3.9.10 (CPython 64bit) - macOS-12.1-arm64-arm-64bit
[debug] exe versions: ffmpeg 5.0 (setts), ffprobe N-105035-g617452ce2c-tessus
[debug] Optional libraries: Cryptodome, sqlite
[debug] Proxy map: {}
[debug] Using fake IP <IP_ADDRESS> (IN) as X-Forwarded-For
[debug] [Zee5] Extracting URL: https://www.zee5.com/tv-shows/details/sa-re-ga-ma-pa-2021/0-6-3497/sa-re-ga-ma-pa-2021-auditions-round-1/0-1-6z526594
[Zee5] 0-1-6z526594: Downloading access token
[Zee5] 0-1-6z526594: Downloading JSON metadata
[Zee5] 0-1-6z526594: Downloading m3u8 information
WARNING: [Zee5] Failed to download m3u8 information: HTTP Error 404: Not Found
ERROR: [Zee5] 0-1-6z526594: No video formats found!; please report this issue on  https://github.com/yt-dlp/yt-dlp , filling out the "Broken site" issue template properly. Confirm you are on the latest version using -U
Traceback (most recent call last):
  File "/usr/local/bin/yt-dlp/yt_dlp/YoutubeDL.py", line 1381, in wrapper
    return func(self, *args, **kwargs)
  File "/usr/local/bin/yt-dlp/yt_dlp/YoutubeDL.py", line 1465, in __extract_info
    return self.process_ie_result(ie_result, download, extra_info)
  File "/usr/local/bin/yt-dlp/yt_dlp/YoutubeDL.py", line 1521, in process_ie_result
    ie_result = self.process_video_result(ie_result, download=download)
  File "/usr/local/bin/yt-dlp/yt_dlp/YoutubeDL.py", line 2441, in process_video_result
    self.raise_no_formats(info_dict)
  File "/usr/local/bin/yt-dlp/yt_dlp/YoutubeDL.py", line 961, in raise_no_formats
    raise ExtractorError(msg, video_id=info['id'], ie=info['extractor'],
yt_dlp.utils.ExtractorError: [Zee5] 0-1-6z526594: No video formats found!; please report this issue on  https://github.com/yt-dlp/yt-dlp , filling out the "Broken site" issue template properly. Confirm you are on the latest version using -U

Umm technically DRM is not the issue here @pukkandan
The issue is non-DRM url not working for unknown reasons.

yt-dlp --concurrent-fragments 10 "https://www.zee5.com/news/details/russia-ukraine-war-russia-bombs-drama-theater-in-mariupol-over-1000-feared-trapped/0-0-newsauto_3o2svtunol20"
[generic] 0-0-newsauto_3o2svtunol20: Requesting header
WARNING: [generic] Falling back on generic information extractor.
[generic] 0-0-newsauto_3o2svtunol20: Downloading webpage
[generic] 0-0-newsauto_3o2svtunol20: Extracting information
ERROR:

Umm technically DRM is not the issue here @pukkandan The issue is non-DRM url not working for unknown reasons.

There are no non-DRM urls in zee5
which url are you referring about "non-DRM url not working for unknown reasons"

Umm technically DRM is not the issue here @pukkandan The issue is non-DRM url not working for unknown reasons.

There are no non-DRM urls in zee5 which url are you referring about "non-DRM url not working for unknown reasons"

Every free content video in zee5 has a non-drm hls url, and we take advantage of it.

Any update on this issue? This link is playable in a browser but shows the same error

Any update on this issue? This link is playable in a browser but shows the same error

But it is not playable for me without DRM. See https://github.com/yt-dlp/yt-dlp/issues/4062#issuecomment-1153474056 for how to check


Line Chart support for various detection issues

[x] Contrast Ratio Detection
[x] Missing Label Detection
[x] Color Detection
[x] Overcomplexity Detection

Finished with merge of @yadiw 's work on color detection and overcomplexity.
https://github.com/charlesdrotar/accessiplot/pull/34


Fix test tool text is cropped

Explanation of Change

Fix test tool text is cropped
Fixed Issues

$ https://github.com/Expensify/App/issues/53092
PROPOSAL: https://github.com/Expensify/App/issues/53092#issuecomment-2499174243
Tests

Prerequisite: in Android settings font size is set to the 3rd smallest one and display size to the 2nd

Open troubleshoot page from settings
Verify that the text is not cropped and the page is scrollable

[x] Verify that no errors appear in the JS console

Offline tests

Same
QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."
Prerequisite: in Android settings font size is set to the 3rd smallest one and display size to the 2nd

Open troubleshoot page from settings
Verify that the text is not cropped and the page is scrollable

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome
https://github.com/user-attachments/assets/219f9a9e-0dd4-48f0-9014-8887ed9761b4

iOS: Native
https://github.com/user-attachments/assets/eaad00f0-58f8-4d8d-adbe-1aeec5de3d29

iOS: mWeb Safari
https://github.com/user-attachments/assets/1c72bc19-6e34-4036-bd24-7633b83c36eb

MacOS: Chrome / Safari
https://github.com/user-attachments/assets/a3b641dc-b96a-4ddf-8bb1-85b6ea5f1760

MacOS: Desktop
https://github.com/user-attachments/assets/f5e0a999-ef8f-41b3-b732-1c4032a5dc4c

Looks good to me 👍

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.


Added a way to limit the query or scan

NOTE: This is just to get a discussion going around limits.  The code isn't finished, or polished and can definitely (and should be) changed, but it serves as a starting point to discuss using the Limit kwarg in boto3's dynamodb client.
https://boto3.readthedocs.io/en/latest/reference/services/dynamodb.html#DynamoDB.Client.scan

I think this may be similar to #91 which asks about the Limit parameter in DynamoDB.  Copying my comment from there:

I believe most people expect limit to say "when I iterate over my Engine.query or Engine.scan there must mot be more than limit items". Meanwhile the DynamoDB API defines Limit to mean "for a single call only evaluate up to Limit items before applying any filters". Because Bloop doesn't expose the individual query calls with continuation token and instead gives you a single Iterable that automatically handles pagination, the concept of a limit doesn't really apply. Because each next() for a query or scan will follow any number of continuation tokens, limiting the items evaluated per continuation token doesn't provide any additional throughput control to the client.

For example, imagine you have 100 items in a User table and want to get one user with<EMAIL_ADDRESS>in their email address.  Since you only need to get one user you decide to set Limit=1, giving you the following hypothetical scan:
scan = engine.scan(User, filter=User.email.contains("@domain.com"), limit=1)

However the first 3 users have the email<EMAIL_ADDRESS>your scan will return nothing because the "Limit" parameter told DynamoDB to stop searching after it considers 1 item.  In this case that item was filtered by the FilterCondition, so DynamoDB won't continue scanning.

Because bloop follows continuation tokens for you and lazily loads, all query/scan iterators are lazy and you can implement your own result limiting client side:
def stop_after(iterator, n):
    assert n > 0
    i = 0
    for item in iterator:
        yield item
        i += 1
        if i == n:
            break

any_iterator = iter(range(10000))
for value in stop_after(any_iterator, 3):
    print(value)


feat: shift from cargo test to cargo nextest

Shifting from cargo test to cargo nextest as per Issue- #999

Hello!
Thanks for your external contribution!
I approved the workflows, and it seems the github workflow files need a bit more work:
error: no such command: `nextest`
	Did you mean `test`?
	View all installed commands with `cargo --list`
	Find a package to install `nextest` with `cargo search cargo-nextest`

Hello!
Thanks for your contribution!
I approved the workflows, and it seems the github workflow files need a bit more work:
error: no such command: `nextest`
	Did you mean `test`?
	View all installed commands with `cargo --list`
	Find a package to install `nextest` with `cargo search cargo-nextest`

I had added the installation for cargo nextest in the docker file, but forgot to put the same in workflow, I have corrected the mistake in the latest commit

I would use https://github.com/taiki-e/install-action to install the tooling. The nextest examples themselves use it https://github.com/nextest-rs/reuse-build-partition-example/blob/main/.github%2Fworkflows%2Fci.yml

I would use https://github.com/taiki-e/install-action to install the tooling. The nextest examples themselves use it https://github.com/nextest-rs/reuse-build-partition-example/blob/main/.github%2Fworkflows%2Fci.yml

Hey @mkysel , I have replaced that particular piece of code in the latest commit

Thanks @Arya-A-Nair. Looks good to me. I will wait for @insipx to approve since he is the original reporter.

Looks great, thanks again for the contribution!
feel free to merge whenever

Hey, as I don't have write access I cant merge from my end

Done!


Feature: Don't append Command/Service/Form when specified in name

When using a generator:
rails g slayer:command FooCommand
Generates:
/commands/foo_command_command.rb
class FooCommandCommand...
Should not append  command  to the generated file and class if already specified.

this will be fixed in slayer_rails


Update existing service instance: not able to delete while update in progress

What is the problem?

Provision a new service instance and delete it while creation in progress
Update an existing service instance and delete it while update in progress

for scenario 1 I was able to delete the service while it was still creating
for scenario 2 I get error if I try any operation while update in progress
Server error, status code: 409, error code: 60016, message: An operation for service instance my-service is in progress.
Does service broker allow two operations simultaneously? Is this the expected behavior? If so, then why does it give error in case of update
Expected behavior
Allow delete in both scenarios or give error in both scenarios

It's up to the broker if and when concurrent operations are allowed. The spec says this:

Service Brokers MAY choose the degree to which they support concurrent requests, ranging from not supporting them at all to only supporting them in selective situations. If a Service Broker receives a request that it is not able to process due a concurrency issue then the Service Broker MUST reject the request with a HTTP 422 Unprocessable Entity and a response body containing error code "ConcurrencyError" (see Service Broker Errors).

The first scenario is also explicitly covered by the spec:

If a Service Broker accepts the request to delete a Service Instance during the process of it being provisioned, then it MUST have the net effect of halting the current creation process and beginning the deletion of any resources associated with the Service Instance.

In the second scenario, the broker returns the wrong status code, though.
Does this answer your question? If so, please close this issue.

Closing this as the question was answer and there wasn't activity ever since.


controll curl image per variable

Subject

Curl Image in charts/linkerd-smi/templates/namespace-metadata.yaml

Problem

We want to using this in a private cloud and using our own Dockerrepository

Solution

Controll Curl image per Value.yaml

Fixes #11234

Signed-off-by: Kevin Bock<EMAIL_ADDRESS>
Greatings Kevin

Closing this one, as we're no longer using the curl image and instead cr.l5d.io/linkerd/extension-init.


docs: add release tags to providers

And complain if API doesn't have release tag

Current dependencies on/for this PR:

main

PR #302   👈

This stack of pull requests is managed by Graphite.


[python/c++] Use C++ bindings for SparseNDArray write path

Issue and/or context:
https://github.com/single-cell-data/TileDB-SOMA/issues/2428
Changes:

Use C++ bindings for SparseNDArray write path
Also modify SOMA typechecks to be case insensitive

Note for reviewers:
Python CI here: https://github.com/single-cell-data/TileDB-SOMA/actions/runs/8706690043/job/23879862239

R CI is a KP, as TileDB-R 0.26.0 exists but we've not updated TileDB-SOMA yet. We are actively addressing this and will have a fix soon. Meanwhile the red R CI should not be used as a reason to not merge this PR.

I'm not so sure that my failure is related to the TileDB-R 0.2.26 because the only test it is failing is the SparseNDArray Python write  and R readback (and not vice versa) which is exactly what this PR changes. However, I'll go ahead and switch to working on other tasking.

@nguyenv I may be mistaken -- CI fail for this PR
https://github.com/single-cell-data/TileDB-SOMA/actions/runs/8706640564/job/23879684263?pr=2446
is not related to core versions.

@nguyenv I just rebased on top of #2448 (the R CI thing) & indeed an issue does still remain ...


[ANT-804] Saving modifications impossible on table mode

Description
When we make some modification on the table mode of this study ID 0b25cf01-d6a8-4917-a88a-2dc030342e50 (on production), it's not saving it. This issue isn't present on other studies.

Given the fact that this bug only occurred in a production study, the issue will be validated after the MEP


Feature Request: Real-Time Collaboration Functionality Similar to VS Code Live Share

Quality peer programming is currently difficult if not impossible with Vim.
A modern editor must have such a solution, with good integration. Allowing everyone to work on the same code with their own configuration is what Vim needs. Ideally, this would be something compatible with other IDEs (to be developed in collaboration with VSCodium, which doesn't have Live Share?) with a clear standard.
Under these conditions, using Tmux is not a really satisfactory solution. As far as I can tell from the Internet, Floobits once existed, but has long since been discontinued:
https://github.com/Floobits/floobits-vim
The same goes for duckly/ducky, whose integration was probably not ideal.
Extensions are too easily abandoned, and should be integrated into Vim.

I have thought this would be useful previously as well.
To play devils advocate, this feature may be out of scope for vim. If it is out of scope terminal applications like Terminus offer terminal sharing which could offer a collaboration method.
If this were a feature in scope with vim, the feature would need to include encryption, user authentication, host authentication, collaboration endpoints, host access control, remote editing capabilities, remote file browsing capabilities.

Fun fact: the whole Neovim debacle started with the exact same request and appeal to "modernity". You should check out if they actually delivered on that front.

I personally think this is too much a nice use case (I would have only used it about a couple of times within the last 20 years) and there are enough work-arounds (using tmux/screen), that I don't think this belongs into Vim. And as mentioned, this would complicate the whole code base already quite a bit (including we are adding a whole new level of security considerations here, including being able to target Vim from a remote host).
Honestly, I don't want Vim to become like this.


Made test_vcache_flush test lowest and highest word

Addresses part of #451

Not long. Timing it gives this:
make test_vcache_flush.log  3.96s user 0.16s system 100% cpu 4.099 total

Can you raise the random address limit, and make it reproducible using a seed?

Limit is now 128, seed is DEADBEEF. It takes ~64 seconds to run now in cosim.

can we also have tests to byte/half size access?

Thanks @tommydcjung, this is a good suggestion

If we could include tests to byte/half access in tile DMEM, that would also be helpful.

Also a good idea, but that would be the subject of another PR (one feature per PR policy)

@tommydcjung Can you file an issue for that? We'll do it

Ok so I should do byte/half word testing from vcache in this PR and then from DMEM in another PR?

yep! Separate PR and separate test

@mrutt92 When you have a moment, can you add some feedback as our resident C++ guru?


Fix the uploaded supplier pack file name

supplier-frontend expects the supplier pack file name to be
<slug>-supplier-pack.zip, which doesn't match the file name
generated by the admin app on upload.
https://github.com/alphagov/digitalmarketplace-supplier-frontend/blob/master/app/main/views/frameworks.py#L86

:+1:


Serialize MapName (and other MapInfo?) and move mapname to EntityData

aka, MapName shows City_00_01 instead of Atlas Park
Feel free to provide feedback or input on direction for this Enhancement.
Summary
Unless the Client has map display names hardcoded, there must be a way for us to pull that map name out for use throughout the server (e.g. FriendsList, TeamsList, Char Select, etc)
There may also be other info that we'll want to store in some kind of new MapStruct for use as MapInstance begins to recognize multiple zones.
Additionally, currently m_mapname is stored in CharacterData under Character. In reality, we should move this to EntityData inside Entity, as every Entity should know what map it's in (besides every Character is an Entity). It's possible that we'll want to rename this to m_current_map or something instead.
There are some comments in map_serializers.cpp that may provide insight into what's stored in maps.bin
//static Serialization_Template Map_Tokens[6] = {
//{ "Name", TOKEN_STRING, 0x10},
//{ "Icon",  TOKEN_STRING, 0x14},
//{ "Location",  TOKEN_VEC2, 0},
//{ "TextLocation",  TOKEN_VEC2, 8},
//{ "End",  TOKEN_END},
//{ },
//};

//static const Serialization_Template Map_Token[2] = {
//{ "Zone", TOKEN_SUB_TABLE, 0, 0x18, Map_Tokens},
//{},
//};

Tasks to complete this issue:

[ ] Research what is stored client side related to map data/info (maps.bin, maybe others)
[ ] Serialize relevant map data in map_serializers.cpp using Cereal
[ ] Rename m_mapname to m_current_map
[ ] Move m_current_map to EntityData struct

We could extract map names using map.bin, although the file itself contents are not exactly what we want/need since the atlas park entry looks like
{
"Name" : "maps/City_Zones/City_01_01/City_01_01.txt",
"Icon" : "City_01_01_Atlas_Park.tga"
}

We 'can' extract the map name from the splash screen name, and build an dictionary for internal_map_name to user_visible_map_name.
Although we could consider creating our own simple format and loading it instead ?

Maybe easier just to create our own array then? Possible first use-case for Lua script? Allow users to rename their zones if they want.
-- Add this zone to the zones table
outbreak = {
  zone_id = 1,
  name = "City_00_01",
  displayname = "Outbreak",
  customspawn = {x = -61, y = -0, z = 161}, -- y is the elevation
}
zones.insert(outbreak, "outbreak")

If not LUA, maybe yaml or json for simple strings and settings?

Actually, just rereading your comment... if the naming schema is consistent, a good interim solution would be to pull this from the name:
"Icon" : "City_01_01_Atlas_Park.tga" and strip out Atlas_Park and remove the underscore, like what we do with NPC names.

I think I'll hop on this one, if you don't mind :) I think we can check based on city_00_01 and so on and get our map detail from there.
Some things I'd like to ask regarding this issue...

Where do we give the map name in client's character select screen (eg MapInstance/city_00_01) to display from the server?
Is struct Map_Data going to be stored in characters' db entries or just the map name?

To answer your question @eos428, no Map_Data should not be stored in the database. Just current map, either by name or by referenced ID

Ah, good to hear then. Then I'd assume we'd store the map datas in some files server-side?
Also, PR is ready for testing and looks fine on my end, have a look when you are free :)


Add v1.10.1

Fix deprecation warning for fluent.** logs

@repeatedly Please take a look

Thanks!

@repeatedly Sure! I assume you're publishing the new images as I couldn't find a job that takes care that, right?

Please wait. docker hub destroyed our build rules again. I'm now re-creating our setup on docker hub build page.


[feature] 2FA + ability to enforce 2FA in Subdomain

Addresses: #1081
Demo:
https://user-images.githubusercontent.com/55496123/195891042-e9508cb0-0d07-4b1c-9e1c-f0fcfc2659a4.mov
Co-authored-by: Er. Ajay Shrestha<EMAIL_ADDRESS>Co-authored-by: Ajay Shrestha<EMAIL_ADDRESS>Co-authored-by: Prashant Khadka<EMAIL_ADDRESS>

@ajaystha42 Im seeing a couple of bugs here. I have applied the migrations on violet-test.net so we are now committed to shipping this feature soon. Please see https://violet-test.net for the following issues:

user can get locked out of entering the OTP since the OTP form is missing

1 in 4 OTP's are rejected.

@ajaystha42 Im seeing a couple of bugs here. I have applied the migrations on violet-test.net so we are now committed to shipping this feature soon. Please see https://violet-test.net for the following issues:

user can get locked out of entering the OTP since the OTP form is missing

1 in 4 OTP's are rejected.

@donrestarone  I will look on it. Also, I dont see the changes of 2fa in https://violet-test.net/ .

@ajaystha42 Im seeing a couple of bugs here. I have applied the migrations on violet-test.net so we are now committed to shipping this feature soon. Please see https://violet-test.net for the following issues:

user can get locked out of entering the OTP since the OTP form is missing

1 in 4 OTP's are rejected.

I fixed the Issue No. 1.
For Issue No, 2, it is caused due to time limit of the otp. Do you want to increase the time limit?

@ajaystha42 where is the OTP timeout set? Each code should be valid for 10 minutes

@ajaystha42 where is the OTP timeout set? Each code should be valid for 10 minutes

By default it is set around 30 seconds. I will update it to 10 minutes

@ajaystha42 where is the OTP timeout set? Each code should be valid for 10 minutes

@donrestarone  if we set the otp time out to 10 minutes? the same code can be used for multiple times and we wont be requiring to send email for every otp request, is that what we need?

@ajaystha42 no. 30 seconds is not enough time for someone to enter the OTP code. It should be something reasonable like 2-3 minutes.

@ajaystha42 still locked out from changing my password. Have you tested this flow on the review app?

@ajaystha42 still locked out from changing my password. Have you tested this flow on the review app?

@donrestarone  Yes if the otp is invalid theres no way we can send a new otp from this screen. Do you want to redirect to edit page or put a button to resend otp if the otp is invalid?

@ajaystha42 yes, add a button to resend OTP.

Acceptance Criteria:
When the user logs in for the first time user must encounter the 2FA.
When the IP (Network of the Device) changes user must be presented with the 2FA for the login
When user goes through the password change process the user must be presented with the 2FA.
When user enters invalid Token for while authenticating with 2FA proper validation message must be displayed
When user is invited for access to a particular domain user must encounter with 2FA.
Received token must be only valid for a particular period of the time.


Script element not registering

Challenge http://www.freecodecamp.com/challenges/waypoint-learn-how-script-tags-and-document-ready-work has an issue. Please describe how to reproduce it, and include links to screenshots if possible.
After creating script element as told in problem. Checker says element not created.

@jeffvk thanks for posting this issue!
Please, provide your code and screenshot, thanks.

Please review the Guidelines for Contributing, thank you!.

This is the code that finally worked(thanks forum). You will notice I needed a line space after the end of the function before the closing script to get it to read correct. Without the line space, it does not read as correct and you cannot continue.

@jeffvk You need to wrap your code in ``` for others to be able to see it. I don't understand what you mean by "a line space after the end", I've tried it many different ways and it always passes.

Seems the problem is solved so I'm closing this issue.


Improve pronunciation

added what I think is a better pronunciation guide

That really sounds better. Could you please replace that with:
It is pronounced "sequel-eck-tron" - https://translate.google.com/?source=osdd#en/en/sequel-eck-tron

Made the change you suggested. Sorry, but I'm new to this, do I need to make a new pull request, or is the commit I made ok?

That commit is ok. Thanks!!


3.1.0 changelogs

@mergifyio backport release/3.0.x

@skirby1996 you shouldn't need to backport this to 3.0.x.  That branch is going to stay how it is.


Download all historic station data (as converting to a paid-for model)

Tasks

[X] adding test script
[x] test for one location "laos" where country_id=98
[x] Create s3 buckets for storage
[x] complete for all country locations
[x] automate creation of s3 buckets with useful naming schema

@jit-1 are we merging this script? I believe you adjusted it when we needed to download historic data from openaq, but I am unaware of the location of the updated script.


More sidecar injector template cleanup

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: greghanson
If they are not already assigned, you can assign the PR to them by writing /assign @greghanson in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

install/OWNERS
pilot/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ostromart PTAL

@nmittler: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
17aa283fb30e40a18c75f7b220bda04f54821999
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/lgtm
/approve

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: ostromart
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: nmittler
If they are not already assigned, you can assign the PR to them by writing /assign @nmittler in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

install/OWNERS [ostromart]
pilot/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

New changes are detected. LGTM label has been removed.

@nmittler: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-mixer-no_auth.sh
47acf33e5774a272088246a04de77ad897420e45
link
/test e2e-mixer-no_auth

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@nmittler: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-mixer-no_auth.sh
47acf33e5774a272088246a04de77ad897420e45
link
/test e2e-mixer-no_auth

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/lgtm

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: ostromart
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: nmittler
If they are not already assigned, you can assign the PR to them by writing /assign @nmittler in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

install/OWNERS [ostromart]
pilot/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


rails_admin pagination not working

links appear vertically and are ineffectual.

This was caused by storytime gem which has been removed.  Closing this issue now.


[BUG] Problems with Login Pop Up

Core Library
MSAL.js (@azure/msal-browser)
Core Library Version
2.31.0
Wrapper Library
MSAL Angular (@azure/msal-angular)
Wrapper Library Version
2.4.6
Public or Confidential Client?
Public
Description
There is a problem when using the pop-up login because when we maximize the login screen, the MFA flow is lost in the initial pain from where the trigger was sent to lift that pop-up
Error Message
No response
MSAL Logs
No response
Network Trace (Preferrably Fiddler)

[ ] Sent
[X] Pending

MSAL Configuration
auth: {
      authority: environment.adB2C.authority,
      clientId: environment.adB2C.clientID,
      redirectUri: environment.adB2C.redirectUri,
      postLogoutRedirectUri: environment.adB2C.logoutRedirectUri,
      navigateToLoginRequestUrl: true,
      knownAuthorities: environment.adB2C.knownAuthorities,
    },
    cache: {
      cacheLocation: 'localStorage',
      storeAuthStateInCookie: false,
    },

Relevant Code Snippets
raiseMFAPopup(): Observable<any> {
    return this.authService
      .authorizationPopUpRequest({
        scopes: environment.adB2C.scopes,
        authority: environment.adB2C.authorityApprovalFlow,
        redirectStartPage: window.location.href,
      } as PopupRequest)
      .pipe(
        catchError((error) => {
          return throwError(error);
        }),
        tap((_) =>
          // Got success information
)

Reproduction Steps
1.- trigger MFA
2.- Maximaize login pop-up screen
3.- Fill login data
4.- Got Error
Expected Behavior
Allow the screen to be maximized to return to the corresponding page in the main window
Identity Provider
Azure B2C Custom Policy
Browsers Affected (Select all that apply)
Chrome
Regression
No response
Source
Internal (Microsoft)

What error are you getting?

The issue is still not resolved


Fix adding Jekyll format to the top

Problem with /permalink/. This adds a few bash lines that updates
index.md without the permalink.

Unfortunately I'm going to have to merge this in, in order to troubleshoot what's up with GitHub. If this doesn't work i'll revert it manually.


Make symlink a relative path

Is your feature request related to a problem? Please describe.
When copying files, the symlinks are automatically copied.
https://github.com/Senzing/docker-db2-driver-installer/blob/d9d797895c7e5f7bfd0fd89ab4cdcae5c00b2495/db2-driver-installer.py#L431
However, it produces results like:
$ pwd
/opt/my-senzing/opt-ibm/db2/clidriver/lib

$ ls -la
total 70096
drwxr-xr-x 3 root root     4096 Aug 12 14:14 .
drwxr-xr-x 9 root root     4096 Aug 12 14:14 ..
drwxr-xr-x 3 root root     4096 Aug 12 14:14 icc
lrwxrwxrwx 1 root root       48 Nov 21 10:27 libdb2o.so -> /opt/IBM-template/db2/clidriver/lib/libdb2o.so.1
-r-xr-xr-x 1 root root 35885715 Jun  8  2016 libdb2o.so.1
lrwxrwxrwx 1 root root       47 Nov 21 10:27 libdb2.so -> /opt/IBM-template/db2/clidriver/lib/libdb2.so.1
-r-xr-xr-x 1 root root 35873393 Jun  8  2016 libdb2.so.1

where the symlinks are "absolute path" rather than relative path.
The fix would have the result be:
$ pwd
/opt/my-senzing/opt-ibm/db2/clidriver/lib
senzing@office:/opt/my-senzing/opt-ibm/db2/clidriver/lib$ ls -la
total 70096
drwxr-xr-x 3 root root     4096 Aug 12 14:14 .
drwxr-xr-x 9 root root     4096 Aug 12 14:14 ..
drwxr-xr-x 3 root root     4096 Aug 12 14:14 icc
lrwxrwxrwx 1 root root       48 Nov 21 10:27 libdb2o.so -> libdb2o.so.1
-r-xr-xr-x 1 root root 35885715 Jun  8  2016 libdb2o.so.1
lrwxrwxrwx 1 root root       47 Nov 21 10:27 libdb2.so -> libdb2.so.1
-r-xr-xr-x 1 root root 35873393 Jun  8  2016 libdb2.so.1

Pull requests:

https://github.com/Senzing/docker-db2-driver-installer/pull/19


fix: generate gift wallet is disabled if there is not enough funds

Ideally we would send these amounts with the request to the bee-desktop but lets not do that now.

🐝 PR preview in Swarm
Preview URL: https://bah5acgzadrg533lokiakgzpn3xftunay5vn2ojcyx3bbo3uhq6aa4xqltnwq.bzz.link
Swarm Hash: 1c4ddded6e5200a365edddcb3a3418ed5ba72458bec2176e8787800e5e0b9b6d
Commit Hash: 91a906a0a613175258d0dc110aefc8ae96276d22
Commit Message: fix: generate gift wallet is disabled if there is not enough funds


Should godownloader just be a flag for goreleaser

i.e.  goreleaser --make-downloader or something
There are some good reasons for this.  It makes the whole vendoring issue for godownloader goes away,  less confusing for users, more eyeballs (and hopefully end users),  and makes goreleaser that much more complete.
The downside is if we want to add a lot of flags to godownloader to do... I don't know what, it becomes harder (well we could do something like gorelease --make-downloader "option1,option2"  or something
I've got a few more days of hacking on godownloader before it makes sense, but something to consider.
thoughts,
n

Good thoughts!
Would agree that it would be nice to have it as a part of the same tool. Would definitely lower the friction to use it and conceptually it sort of belongs there.
Instead of just making it a flag it would probably be more appropriate to make it a command, goreleaser make-downloader -flags... .
I wish I could come up with something shorter than "make-downloader" though..

I like the idea, it might even be a pipe, like the brew pipe or something..
In that case, this tool here could still exist, but it would only be useful to generate the sh for tools that didn't...
We should probably mature this idea 👍

@jorinvo :

Instead of just making it a flag it would probably be more appropriate to make it a command,
goreleaser make-downloader -flags....

ah yes, you are correct.

I wish I could come up with something shorter than "make-downloader" though..

likewise !

Ok New idea!
if the output godownloader script was added to the build directory and released just like checksums.txt then everyone wins.
Everyone who does a release for goreleaser, gets a fresh download script using latest bits.  They could check that file in the main repo if they want the latest script and a stable URL but not required.  no flag needed.
Godownloader-the-command might still live as a debug generator or something.
let's keep thinking...

Sounds like @caarlos0's idea above. I also like it. But definitely need a config to disable/enable it.

What if this is controlled via goreleaser.yml config file?
Example:
release:
  github:
    owner: <user>
    name: <repo>
brew:
...
build:
...
archive:
...
fpm:
...
snapshot:
...
downloader:
...

@petermbenjamin I really like your idea. Seems the way to go for me.
We may put the commons on the goreleaser repo, make it a pipe there, and import it as a dep here to have a cli for godownloader only.
@client9 what do you think?

love it

With regards to:

No OS-specific installs such as homebrew, deb, rpm. Everything is installed locally via a tar.gz or zip. Typically OS installs are done differently anyways (e.g. brew, apt-get, yum, etc).

Would this limitation go away if we bundle the downloader/installer into the goreleaser.yml?
Especially, since goreleaser.yml knows about releasing to brew, deb platforms, and the like.
What if the downloader (or shall we call it installer since typically projects have an INSTALL header in README that links to some installer.sh?) can be configured for each platform independently?
Example:
release:
  github:
    owner: <user>
    name: <repo>
brew:
  github:
    owner: goreleaser
    name: homebrew-tap
  folder: Formula
  homepage: *homepage
  description: *description
  dependencies:
    - git
  installer: brew install <user>/<repo>  # <---- proposed
build:
...
archive:
...
fpm:
  homepage: *homepage
  description: *description
  maintainer: Carlos Alexandro Becker<EMAIL_ADDRESS>  license: MIT
  vendor: GoReleaser
  formats:
    - deb
  dependencies:
    - git
  installer:                       # --|
    deb: apt install <package>     # --| proposed
    rpm: yum install <package>     # --|
snapshot:
...

Hi @petermbenjamin   I'm bit confused by your request.  Can you explain your use case a bit more.
You want a script to to run "brew install your/project" ?  How come?
RPM/DEB both creation and install is quite complicated and don't think it's in the scope of this project. But what do I know!    (if you are interested checkout https://github.com/jordansissel/fpm  for a cross-platform solution for RPM/DEB... sorta... RedHat can produce Debs, but Debian cannot produce RPMs)
thanks for feedback!
n

removed milestone for 1.0.0 since I don't think it's required to glue it into goreleaser since we'll do something different in #39


Can't do AND in tag filter

For the last couple of Eastercon's, as well as topic tags like art, science, writing, fantasy, etc., have had tags like online, in person, no catch-up available and sign up required.
A natural query to want to use the filters to answer is "show me all the fantasy items that are available online". However, the current tag filter only does an OR. If I check fantasy and online, it shows me anything that is fantasy OR online, rather than fantasy AND online.

I don't want to see the filter form get any more complicated. Support for arbitrary ORs and ANDs in the query would make it very difficult to use.
My proposal is to add the concept of "tag groups". Each tag would belong to a tag group:
Topic:

art
science
writing
fantasy
Location:
online
in person
Catch-up:
no catch-up available
Sign up:
sign up required

The tags within a group are ORed together, and then each tag group is ANDed together. For example:

writing, fantasy, online -> (writing OR fantasy) AND (online)
writing, fantasy, online, in person, no catch-up available -> (writing OR fantasy) AND (online OR in person) AND (no catch-up available)

I'm undecided how, if at all, tag groups should be displayed in the UI. I think maybe just ordering by tag group, and then alphabetically within tag groups. So the dropdown would list:

no catch-up available
online
in person
art
science
writing
fantasy
Tag groups could be alphabetical by name, or the order of the tag groups could be defined in the program json. Some flourishes that could be added to the UI include a horizontal line separating tag groups, and having headings for the tag groups. But I think those are probably unnecessary and messy. I think (hope) the concept of tag groups is natural enough that people don't need it explained why writing, fantasy, online shows online writing or fantasy items.

Tag groups would need to be defined somehow in the program json. The tags array could be changed from an array of strings to an array of string or object. If it is a string, it gets added to an implicit "unknown" tag group. If it is an object, it has tag and group attributes.
{
  "id": "item1",
  ...
  "tags": [
    "a raw tag",
    "this still works",
    "these are added to the unknown tag group"
  ]
}, {
  "id": "item2",
  ...
  "tags": [
    { "tag": "science", "group": "topic" },
    { "tag": "online", "group": "location" }
  ]
}, {
  "id": "item3",
  ...
  "tags": [
    "I guess you could mix raw tags",
    { "tag": "and explicitly grouped tags", "group": "the group" },
    "but no one would in practice"
  ]
}

Finding somewhere to add an explicit ordering of the tag groups is difficult with the current structure. (This is why I tend to steer away from arrays as the root objects for json. It makes it difficult to add other types of things in the future) So maybe groups are just ordered alphabetically in the UI.
A consideration is how to handle the same tag belonging to multiple groups. If I have:
{
  "id": "item4",
  ...
  "tags": [
    { "tag": "cool tag", "group": "group 1" },
    { "tag": "cool tag", "group": "group 2" },
  ]
}

a) Do we show cool tag twice in the tag filter dropdown? Do we make any effort to visually distinguish the two?
b) Do we show cool tag twice in the tag list on the item? Do we make any effort to distinguish the two?
c) Or do we error, saying the tags are invalid?
My current inclination is to say we just show them twice in both places, without making any extra effort to visually distinguish them, and if someone is foolish enough to have duplicate tag names, that's kinda their fault.
An alternative presentation is that, instead of smooshing it all into the tags filter, each tag group gets it's own dropdown list in the filter form. My concern here is that already for a hybrid event list Eastercon we have 4 tag groups, so we'd end up with 7 input boxes in the filter form.

It's already possible to group tags (into separate dropdowns/categories) via the JSON data, and the search over different dropdowns is treated as an AND.   See the docs directory for details of the formatting.   This option also existed in KonOpas  and is possible using either data format.

Doh, I can't believe I missed that in the docs! Thanks.


[3pt]My Reservations Page

When the user clicks the "My reservations" link in the
navigation panel they can see a list of their reservations (with
information about item name, date and city).

Implemented in this PR https://github.com/piero-vic/house-booking-front-end/pull/4


Bump kafka-python to 1.4.4

This bumps to 1.4.4 which added the new KafkaAdminClient which we need
in order to make monitor_unlisted_consumer_groups work for consumer
offsets stored in Kafka.
It also comes in handy since it will let us remove a bunch of code from
the existing KafkaCheck and just rely on upstream.

Codecov Report

Merging #2728 into master will decrease coverage by 6.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2728      +/-   ##
==========================================
- Coverage   84.64%   78.61%   -6.04%
==========================================
  Files         663        8     -655
  Lines       37574      519   -37055
  Branches     4518      110    -4408
==========================================
- Hits        31804      408   -31396
+ Misses       4433       79    -4354
+ Partials     1337       32    -1305


Added name in README.md

I have added my name in README.md file.
@HimangshuSharma01 can you please review this?
Thank you!

@HimangshuSharma01 you should focus on merging existing PR

Okay sir I will do it


Improve support for tags

Hi,
The log view shows tags only if they happen to point at a revision in view.
The revision view does not show that it is pointed to by a tag.
I didn’t see any obvious way of displaying all the tags in the repository either, maybe I missed it.
It’d be convenient to put more focus on tags:

display tags in the reference view (they are stored in .git/refs/tags after all)
have a dedicated tag view that shows all the information related to it (signing, annotation…)
allow jumping to a tag view from the log/revision view
showing that the current revision in the revision view is pointed to by a tag

@altsem I think it's worth adding tags to show_refs right?
Also maybe segregate branches on local and remotes like in magit?:

The issue for me is that in my company we name branches like "feature/JIRA-XXX-quite-long-description-of-the-feature" and pretty often two branches (local and remote) don't fit onto one line

So having them in two different sections would make it more neat


New Network Request: Rootstock Mainnet.

Network information

Name: Rootstock Mainnet
ChainId: 30
RPC http/s address: https://public-node.rsk.co
Link to https://chainlist.org/chain/30
(Optional) Blockexplorer: https://explorer.rsk.co/
[x] I have run RPC='https://public-node.rsk.co' yarn estimate

{ chainId: 30 }
{ estimate: '72291' }
{ gasPriceGwei: '0.065164', gasPrice: '65164000' }
{ requiredFunds: '0.000004710770724' }

[x] I have sent requiredFunds to 0xE1CB04A0fA36DdD16a06ea828007E35e1a3cBC37

There are not enough funds for deployment

Thank you, I funded the wallet with the correct amount.

Contract is created: https://explorer.rsk.co/address/0x914d7fec6aac8cd542e72bca78b30650d45643d7


Enhance Dashboard to Include User Settings and Sharing Options

Expand the current dashboard to include settings for changing the username and full name.
Add options to edit additional details, such as social links.
Implement a 'Share Your URL' button to facilitate sharing with other users.

These enhancements will provide users with greater control over their profile and make it easier to share their information.

I am building that part

I am building that part

Then you can assign yourself this issue


[Question] 网络慢

Search before asking

[X] I had searched in the issues and found no similar issues.

Question

网络好慢，半天也出不来

感谢反馈，正在修复


error when running on windows

Cloned repo + pnpm i + nr dev, seems a problem on nuxt3:
uxtdistplugin.mjs" from "virtual:F:\work\projects\quini\GitHub\antfu\vitesse-nuxt3\.nuxt\plugins\server.mjs". Does the file exist?

System info:
System:
    OS: Windows 10 10.0.19042
    CPU: (16) x64 Intel(R) Core(TM) i9-9900K CPU @ 3.60GHz
    Memory: 49.33 GB / 63.95 GB
  Binaries:
    Node: 16.12.0 - C:\Program Files\nodejs\node.EXE
    npm: 8.1.0 - C:\Program Files\nodejs\npm.CMD
  Browsers:
    Chrome: 95.0.4638.69
    Edge: Spartan (44.19041.1266.0), Chromium (95.0.1020.40)
    Internet Explorer: 11.0.19041.1202

and the error:
F:\work\projects\quini\GitHub\antfu\vitesse-nuxt3>nr dev

> @ dev F:\work\projects\quini\GitHub\antfu\vitesse-nuxt3
> nuxi dev
Nuxt CLI v3.0.0-27268729.5b8e10f                                                                                17:27:35
                                                                                17:27:35
  > Local:    http://localhost:3000/
  > Network:  http://<IP_ADDRESS>:3000/
  > Network:  http://<IP_ADDRESS>:3000/

 WARN  Current version of Node.js (15.11.0) is unsupported and might cause issues.                                                                                17:27:39
       Please upgrade to a compatible version (^14.16.0 || ^16.11.0 || ^17.0.0).

i Vite warmed up in 839ms                                                                                17:27:46

 WARN  [SSR] Error transforming virtual:F:/work/projects/quini/GitHub/antfu/vitesse-nuxt3/.nuxt/plugins/server.mjs: Error: Failed to resolve import "F:workprojectsquiniGitHubantfu♂itesse-nuxt3          17:27:46
ode_modules.pnpm@pinia+nuxt<EMAIL_ADDRESS>ode_modules@pinia
uxtdistplugin.mjs" from "virtual:F:\work\projects\quini\GitHub\antfu\vitesse-nuxt3\.nuxt\plugins\server.mjs". Does the file exist?

√ Vite server built in 1422ms                                                                                17:27:46
√ Nitro built in 184 ms                                                                                17:27:47
Cannot read property 'map' of undefined
  at Module.normalizePlugins (file:///F:/work/projects/quini/GitHub/antfu/vitesse-nuxt3/.nuxt/dist/server/server.mjs:179:28)
  at $id_a8355258 (file:///F:/work/projects/quini/GitHub/antfu/vitesse-nuxt3/.nuxt/dist/server/server.mjs:28:39)
  at async __instantiateModule__ (file:///F:/work/projects/quini/GitHub/antfu/vitesse-nuxt3/.nuxt/dist/server/server.mjs:1078:3)
Cannot read property 'map' of undefined
  at Module.normalizePlugins (file:///F:/work/projects/quini/GitHub/antfu/vitesse-nuxt3/.nuxt/dist/server/server.mjs:179:28)
  at $id_a8355258 (file:///F:/work/projects/quini/GitHub/antfu/vitesse-nuxt3/.nuxt/dist/server/server.mjs:28:39)
  at async __instantiateModule__ (file:///F:/work/projects/quini/GitHub/antfu/vitesse-nuxt3/.nuxt/dist/server/server.mjs:1078:3)
Cannot read property 'map' of undefined
  at Module.normalizePlugins (file:///F:/work/projects/quini/GitHub/antfu/vitesse-nuxt3/.nuxt/dist/server/server.mjs:179:28)
  at $id_a8355258 (file:///F:/work/projects/quini/GitHub/antfu/vitesse-nuxt3/.nuxt/dist/server/server.mjs:28:39)
  at async __instantiateModule__ (file:///F:/work/projects/quini/GitHub/antfu/vitesse-nuxt3/.nuxt/dist/server/server.mjs:1078:3)

 WARN  [unocss] entry module not found, have you add import 'uno.css' in your main entry?                                                                                17:27:49

F:\work\projects\quini\GitHub\antfu\vitesse-nuxt3>node --version
v16.12.0

why this message?
WARN  Current version of Node.js (15.11.0) is unsupported and might cause issues.                                                                                17:27:39
       Please upgrade to a compatible version (^14.16.0 || ^16.11.0 || ^17.0.0).

I have a few node versions via nvm:
F:\work\projects\quini\GitHub\antfu>nvm list

  * 16.12.0 (Currently using 64-bit executable)
    16.7.0
    15.11.0
    15.5.1
    14.17.6
    12.18.3
    10.16.0
    8.17.0
    8.11.3
    6.12.0
    4.2.4

Same error here

The example on stackblitz is also not running:
Cannot start nuxt:  Failed to fetch dynamically imported module: https://xorijpmno--github.jw.staticblitz.com/dist/module.mjs

The example on stackblitz is also not running: Cannot start nuxt: Failed to fetch dynamically imported module: https://xorijpmno--github.jw.staticblitz.com/dist/module.mjs

Yesterdy I also notice that, I forgot also add the error here

@antfu I get it working modifying the virtual module on nuxt.
I added on nuxt3 playground unocss and @unocss/nuxt, see below screenshot. The problem is nuxt vite plugin should load the resolved module with the prefixx file:///:

uhmm, seems the problem is in another package (pinia), I get it working on nuxt playground without the file:/// protocol patch.

Hi @userquin , the error was fixed https://github.com/nuxt/framework/pull/1779 , please try reinstall
<EMAIL_ADDRESS>
"D:GitGitHub
                                                                                itesse-nuxt3
ode_modules@pinia
uxtdistplugin.mjs"

"\n" was escaped as a newline character，@nuxt/kit does not normalize the path

@qianphong fixed, now it is working


Incorrect calculation in Ledoit-Wolf shrinkage intensity

https://github.com/robertmartin8/PyPortfolioOpt/blob/d220fddb418420f622d1af1999724110d6371eca/pypfopt/risk_models.py#L542
You write:
term1 = np.dot((X ** 3).T, X) / t
help_ = np.dot(X.T, X) / t

But it should be Xm instead of X (i.e. the demeaned variable).

Good spot, will push a fix shortly!
On Tue, 14 Jul 2020, 01:46 szev77<EMAIL_ADDRESS>wrote:

https://github.com/robertmartin8/PyPortfolioOpt/blob/d220fddb418420f622d1af1999724110d6371eca/pypfopt/risk_models.py#L542
You write:
term1 = np.dot((X ** 3).T, X) / t
help_ = np.dot(X.T, X) / t
But it should be Xm instead of X (i.e. the demeaned variable).
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/robertmartin8/PyPortfolioOpt/issues/150, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/ACZ7ECOVOIQITAZPEHEFTG3R3NCAXANCNFSM4OYWYQ3A
.


setup github pipelines and rules

@m0cah any progress here?

@m0cah any progress here? it has been several weeks now.

Sorry Josh school is picking up a lot right now right before thanksgiving break, I'll see what still needs to be done.

@m0cah please work on this ticket and push up your latest version of sellstuffapi, then I will try to see why it isn't working for you locally, thanks

@m0cah I see the pipelines, but I see snyk twice, would you please remove the M0cah one and leave the WebJamApps, thanks


HCM fixes for ComboBox and Statuslight

Closes #4082, closes #4096, closes #4114, closes https://github.com/orgs/adobe/projects/19/views/4?pane=issue&itemId=28260452
Also has some other additional fixes from things I noticed from testing (express button backgrounds, disabled background color etc)
✅ Pull Request Checklist:

[ ] Included link to corresponding React Spectrum GitHub Issue.
[ ] Added/updated unit tests and storybook for this change (for new code or code which already has tests).
[ ] Filled out test instructions.
[ ] Updated documentation (if it already exists for this component).
[ ] Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:
Compare the combobox WHCM for express and non-express with the XD file found here: https://spectrum.adobe.com/page/combo-box/#Windows-high-contrast-mode
🧢 Your Project:
RSP

@reidbarber ah good catch, https://github.com/adobe/react-spectrum/pull/4050 should cover it. I'll put that PR into our testing session monday