Issue with sync becoming stale (or not properly reinitializing) after force closing app on Android when connecting to a SSL Authenticated Endpoint.

"expo": "^27.0.1",
"pouchdb-react-native": "6.4.1",
"react": "16.3.1",
"react-native": "https://github.com/expo/react-native/archive/sdk-27.0.2.tar.gz",
It seems to be only with SSL enabled CouchDB servers, and only happening when trying to reconnect to them (further, in app releases only, not the JS builds via expo).
Note: I have set up CouchDB according to: http://docs.couchdb.org/en/master/config/http.html#secure-socket-level-options
(although my cert file is a bundle.. which could be an issue)
Recreation Steps:
Code:
initDBs = (firstTime, skipUpdateBatch = false) => new Promise((resolve, reject) => {
  this.localDB = new PouchDB(<DB_NAME>);
  this.remoteDB = new PouchDB(<REMOTE_URL>, {
    skipSetup: true,
    auth: {
      username: <USERNAME>,
      password: <PASSWORD>
    },
    ajax: {
      cache: true,
      timeout: 30000,
      rejectUnauthorized: false,
      requestCert: true,
      agent: false
    }
  this.syncChanges()
  .then(() => {
    this.reactToChanges()
    .then(() => {
      resolve(true);
    }).catch((err) => {
      reject(`Error (1001): ${JSON.stringify(err)}`);
    });
  }).catch((err) => {
    reject(`Error (1002): ${JSON.stringify(err)}`);
  });
});

syncChanges = () => new Promise((resolve, reject) => {
  this.sync = this.localDB.sync(this.remoteDB, {
    live: true,
    retry: true,
  }).on('paused', (err) => {
    if (!err) {
      resolve(true);
    }
  }).on('active', () => {
  }).on('denied', (err) => {
    reject(`Error (2001): ${JSON.stringify(err)}`);
  }).on('complete', (info) => {
  }).on('error', (err) => {
    reject(`Error (2002): ${JSON.stringify(err)}`);
  });
});
reactToChanges = () => new Promise((resolve, reject) => {
  this.changes = this.localDB.changes({
    since: 'now',
    live: true,
    retry: true,
    include_docs: true,
    return_docs: false,
  })
  .on('change', this.handleChange.bind(this))
  .on('denied', (err) => {
    reject(`Error (3001): ${JSON.stringify(err)}`);
  })
  .on('error', (err) => {
    reject(`Error (3002): ${JSON.stringify(err)}`);
  });
  resolve(true);
});

(working example WITHOUT SSL)

connect to endpoint on IOS and Android Devices:
http://<REMOTE_URL>:5984/<DB_NAME>
perform items that will sync between devices.
confirm the sync and reaction to changes occurs properly.
force close app on iOS.
Perform item that will sync (on either device), confirm it DOES.
force close app on Android.
Perform item that will sync (on either device), confirm it DOES.

(working example WITH SSL)

connect to endpoint on IOS and Android Devices:
https://<REMOTE_URL>:6984/<DB_NAME>
perform items that will sync between devices.
confirm the sync and reaction to changes occurs properly.
force close app on iOS.
Perform item that will sync (on either device), confirm it DOES.
force close app on Android.
Perform item that will sync (on either device), confirm it DOES NOT.

Note: The code does not change other than the endpoint url.
I cannot figure out what is going wrong.

Found my issue.
http://docs.couchdb.org/en/latest/best-practices/nginx.html seemed to be the biggest help. nginx was doing weird stuff with my cert.
Further, https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=48203146 helped me to diagnose and arrive at a solution.
Helpful hint to CouchDB Users: (look at your logs)


Update predicates to filter events outside of migration namespace (#1…

(Cherry-picked from 4972678e19b682d7e87f292a33fc1940e1934d16)

Wrong branch


Add migration guides

Reason/Context
Currently, we have no docs that describe the migration guide between versions, we should add them.
This can be done by checking the commit history and looking for commits with !: i.e. feat!:, that describes a breaking change.

Here is the TLDR:
Message
- - messageId(): `string` | `undefined`
- - schemaFormat(): `string`
+ - schemaFormat(): `string` | `undefined`

MessageTrait
- - messageId(): `string` | `undefined`
- - schemaFormat(): `string`
+ - schemaFormat(): `string` | `undefined`

for messageId use id instead.

what is the meaning of TLDR?

It's just the short answer to the changes that were between the two versions of v2 and v3 of the parser.
messageId got removed, and should use id instead, schemaFormat changed return types.

can I be assigned to this

@jonaslagoni

We got no assignments, just say you are working on it and that's it 👍

I am working on this

can this be changed to hasMessageId() to hasId()

Hi @jonaslagoni, I'm Jiehui, a newcomer to AsyncAPI community. I came across this good first issue and based on the TLDR I made a draft version of the migration guide specially for Parser in this PR. Looking forward to any feedback on the wording or if there are anything incorrect please let me know.
Also, I am not sure if creating the migration document inside this repository is the ideal practice. Shall we integrate it into the main migration guide?
cc @Ibukun-tech also open to discussion so that we can work on together to make the document better!

@RegretfulWinter  lets work on this together


build(deps): downgrade pager view

This PR resolves []
Description
Downgrade pager view due to beta crashing on launch:
Android sentry
iOS sentry

PR Checklist

[x] I have tested my changes on iOS and Android.
[x] I hid my changes behind a [feature flag], or they don't need one.
[x] I have included screenshots or videos, or I have not changed the UI.
[x] I have added tests, or my changes don't require any.
[x] I added an [app state migration], or my changes do not require one.
[x] I have documented any follow-up work that this PR will require, or it does not require any.
[x] I have added a changelog entry below, or my changes do not require one.

To the reviewers 👀

[ ] I would like at least one of the reviewers to run this PR on the simulator or device.

Changelog updates
#nochangelog

Warnings

:warning:

✅ No changelog changes

  Generated by :no_entry_sign: dangerJS against 48e164940e454849307a5e9d8d940d06e75ef267


Clifford utils optimizations

Summary
This PR addressed the suggestions made in #148 .
Details and comments

Is there a test for the clifford utils?
perhaps you can check that you generate 24 distinct 1q cliffords, and 11520 distinct 2q cliffords
see: https://github.com/Qiskit/qiskit-terra/blob/5fb0b271d157b001d417f9d1339100c69805b46a/test/python/quantum_info/operators/symplectic/test_clifford.py#L397

You can remove the classes VGate and WGate:
https://github.com/Qiskit/qiskit-experiments/blob/ab656eaf50805c8dd6274152ef60d7efd39cebc1/qiskit_experiments/library/randomized_benchmarking/clifford_utils.py#L25
https://github.com/Qiskit/qiskit-experiments/blob/ab656eaf50805c8dd6274152ef60d7efd39cebc1/qiskit_experiments/library/randomized_benchmarking/clifford_utils.py#L40


Exported model from Blender 2.83 LTS breaks ForwardRenderer

Hi, I used this model all the time for testing (mostly exported by using Blender 2.79), but for some reason it breaks multiple things when exported from Blender 2.83 LTS:

Supposed to look like:

playcanvas-stable.js:8109 Uncaught TypeError: Cannot read property '_aabbVer' of undefined
    at MeshInstance.get (playcanvas-stable.js:8109)
    at scriptType.OrbitCamera._buildAabb (orbit-camera.js:600)
    at scriptType.OrbitCamera._buildAabb (orbit-camera.js:608)
    at scriptType.OrbitCamera.focus (orbit-camera.js:400)
    at scriptType.<anonymous> (orbit-camera.js:540)
    at scriptType.fire (playcanvas-stable.js:326)
    at scriptType.set (playcanvas-stable.js:41555)
    at Viewer.initializeScene (viewer.js:209)
    at playcanvas-gltf.js:1457
    at parse (playcanvas-gltf.js:1300)
get @ playcanvas-stable.js:8109
OrbitCamera._buildAabb @ orbit-camera.js:600
OrbitCamera._buildAabb @ orbit-camera.js:608
OrbitCamera.focus @ orbit-camera.js:400
(anonymous) @ orbit-camera.js:540
fire @ playcanvas-stable.js:326
set @ playcanvas-stable.js:41555
initializeScene @ viewer.js:209
(anonymous) @ playcanvas-gltf.js:1457
parse @ playcanvas-gltf.js:1300
(anonymous) @ playcanvas-gltf.js:1445
(anonymous) @ playcanvas-gltf.js:1267
loadBuffers @ playcanvas-gltf.js:1248
loadGltf @ playcanvas-gltf.js:1443
loadGltf @ viewer.js:220
fr.onload @ viewer.js:434
load (async)
loadFile @ viewer.js:424
(anonymous) @ viewer.js:489
(anonymous) @ viewer.js:456
6804playcanvas-stable.js:12010 Uncaught TypeError: Cannot read property 'worldTransform' of undefined
    at ForwardRenderer.drawInstance (playcanvas-stable.js:12010)
    at ForwardRenderer.renderForward (playcanvas-stable.js:12477)
    at ForwardRenderer.renderComposition (playcanvas-stable.js:13189)
    at Application.render (playcanvas-stable.js:47367)
    at playcanvas-stable.js:47948

The glTF model for testing:
maila.zip

Hi @kungfooman,
The crash is something we can fix, but as we're about to release new viewer which does not exhibit the crash issue, we might not get to fix the old one.
Try new viewer from here: https://github.com/playcanvas/engine/tree/master/tools/viewer
(you need to have local engine build, or download engine to build folder)
But missing parts of the mesh could perhaps be something to do with the gltf file itself? I tried loading it into 2 other viewers, and they both show missing parts.
threejs https://gltf-viewer.donmccurdy.com/
babylon https://sandbox.babylonjs.com/

Hi @mvaligursky, thank you for the quick answer! The gltf file itself is indeed missing the body (Blender only exported the selected objects).
So I exported everything now:

Thanks for referencing the new viewer, I just have a hard time to understand how it loads an entire model (with textures). I tried to drag&drop the model folder (like this viewer works), but it seems to only support single files (maybe thats something you work on already)

@slimbuck Were you planning on supporting loading of unpacked glTF in the new viewer?

Hi @kungfooman @willeastcott, the latest version of the viewer will support dragging multiple files into the viewer. The viewer released with engine 1.31.0 has limited support for multiple files.

@kungfooman I'd suggest migrating to the engine-native glTF support soon as you can.
The engine glTF code is actively maintained and developed, it largely has feature parity with playcanvas-gltf and in some cases has much better support (for example morph targets).
We'll also continue developing the viewer, so if you have any feature requests please shout :)

Once the new viewer supports folder drag&drop I would like to test/compare the performance, so my feature request would be a "Spawn 8x8" button 😅

So I was pretty relaxed about adding that 8x8 feature to the viewer in this repo. But it's a bit of a non-standard feature for a model viewer IMHO. So I probably wouldn't want to add it to the new viewer in the engine repo. But if you want to fork the viewer and add it to your fork, go right ahead. 😄  (BTW, just FYI, we're probably going to move the viewer in the engine repo out into its own repo in the coming days).

IMHO not having a 8x8 cloning button just shows the inability of these other viewers. When I worked a bit with ThreeJS/glTF it wasn't even possible to clone an animated glTF model and it still has open issues (and the cloning problem dates back to 2016).
https://www.google.com/search?q=gltf+clone+threejs+fail
Being able to quickly and easily clone a model 64 times also allowed me to discover/verify memory/GC issues in the past (like https://github.com/playcanvas/playcanvas-gltf/issues/70)
Looking forward to the new viewer repo 🎉

I'm not saying it's an effective way to add 64 objects, but you can drag & drop while holding Shift (or Ctrl?) and it adds the object without removing what's already there.

An aspect of this bug is present in both glTF loaders (playcanvas-gltf and glb-parser), they just shine through differently.
So we are all on the same page and analyze the same thing here, this is the full test model:
maila.zip
It defines a scene like this:
    "scenes" : [
        {
            "name" : "Scene",
            "nodes" : [
                0,
                1,
                97,
                100
            ]
        }
    ]

However, as we can see here, glb-loader will have six rootNodes (two more than defined in the scene). Because glb-loader doesn't looks into the scenes key and just searches every node with parent === null:

This is how the hierarchy looks in Blender:

Point001/Maila_EyeR and Point002/Maila_EyeL are treated as rootNodes, but they are a child of Bip001. This confusion renders the eyes at the wrong position:

Good observation, I've noticed that on Friday when looking at some other improvements / optimizations to glb characters. I'll be fixing this shortly. Thanks!

I have a fix for your issue @kungfooman, it should get released soon.
The problem in your case is that you seem to have two nodes referencing left and two nodes referencing right eye mesh, but only one of these nodes each side is part of the scene, the other is not. We didn't handle a case where mesh is not part of the scene, and ended up with undefined node crashing rendering. Now I correctly (I believe) skip creating the meshInstance completely.
But honestly, this seems to point to issue with either model, or exporter. I would not expect valid gltf file to have node referencing mesh that is not used in the scene, as what's the point of it?

Thank you so much for fixing Glb-parser @mvaligursky
That's a huge argument to switch now, as it even seems to perform faster than playcanvas-gltf (quite hard to compare without materials yet):
clones = [];

/**
 * @summary
 * clones viewer.entities[0] 64 times
 * 8 rows, 8 cols
 * useful for performance tracing
 */

function spawn8x8() {
    var entity = viewer.entities[0];
    if (!entity) {
        console.log("drag&drop an entity first");
        return;
    }
    var padding_x = 0;
    var padding_z = 0;
    for (var i=0; i<entity.model.meshInstances.length; i++) {
        var aabb = entity.model.meshInstances[i].aabb;
        padding_x = Math.max(padding_x, aabb.halfExtents.x * 2);
        padding_z = Math.max(padding_z, aabb.halfExtents.z * 2);
    }
    for (var i=1; i<=8; i++) {
        for (var j=1; j<=8; j++) {
            var clone = entity.clone();
            clone.setLocalPosition(
                i * padding_x,
                0,
                j * padding_z * -1
            );
            clones.push(clone);
        }
    }
    // add all clones to scene
    for (var i=0; i<clones.length; i++) {
        var clone = clones[i];
        viewer.app.root.addChild(clone);
    }
}

spawn8x8();

And Glb-parser feels like a "first-class citizen", e.g. no custom-clone-function, simply entity.clone().
I would just like to point out that this issue is not solved for playcanvas-gltf (but probably nobody cares anyway now):

But honestly, this seems to point to issue with either model, or exporter. I would not expect valid gltf file to have node referencing mesh that is not used in the scene, as what's the point of it?

Yea, too bad that exporter is written in Python. I had a look once but I find it confusingly hard to debug. I would love a blend format file parser dumping a glTF, written in pure JavaScript (maybe some point in the future).


Add abilty to hide db.statement in opentelemetry_redix

It's not always necessary/desired to include this attribute, especially as in some cases it can be very long.

This is defined on documentation as a recommended attribute. Do you have examples of other libraries (java, node, ruby etc) that could optionally remove it?
Also, is this causing issues? For example, Ecto statements tends to be even bigger than (most) Redis, still there is no configuration to opt-out this attribute.
Sorry to push back a bit like that, just want to understand more the use case and keep as consistent as possible with prior art from OTEL community.
Thanks in advance @tomtaylor!

The docs actually say it should only be collected if the statement is sanitized.
I forget where we are at with Ecto but it should not be collected by default because we do not sanitize.

Ah right, its in, https://github.com/open-telemetry/opentelemetry-erlang-contrib/pull/166

I’m away at the moment without my laptop, but a cursory look showed me that the Ecto instrumentation supports a custom sanitiser as mentioned in #166. The Ruby Redis library supports something similar.
Our example is that we do a KEYS request for a lot of very long patterns at a regular interval, and this is logged verbatim.
Happy to turn this PR into a custom sanitiser if that’s what’s commonly implemented across multiple languages and there’s prior art in Elixir. Does that seem like a better approach?

@tomtaylor yup, that'd be great

@tomtaylor @tsloughter just a heads up, I'm on finishing points with a mongo instrumentation and following that same pattern, with a :disabled, :plain, :obfuscated (basic sanitization) and custom fun options.
Sounds like a good plan to me!

@tomtaylor any update on the switch to a function from a boolean?

I haven't had time to dig into this yet. Happy for someone else to chip it in, or I'll try and get to it when I've got a bit of time.

@tsloughter I've just sorted this and moved from a boolean config option to :enabled, :disabled or a single arity function, to mimics how the Ecto instrumentation behaves.


Sticky headers strange behaviour

Sticky headers strange behaviour when display already created fragment (replace from cache)

If fragment starts at first time all is working fine
I init adapter with empty list and then update dataset with items loaded from network also I save this list globally in the fragment

adapter = FlexibleAdapter(listOf(), this)
        adapter.setStickyHeaders(true)
                .setDisplayHeadersAtStartUp(true)
                .stickyHeaderElevation = 2
// after items loaded
adapter.updateDataSet(getConvertedList(items))

when I display this fragment again (replace some other fragment in activity) it already contains list of items and I pass it in constructor
 adapter = FlexibleAdapter(getConvertedList(items), this)
and get this

I have two types of header (upcoming and past)
private fun getConvertedList(items: List<Appointment>): List<AppointmentModelView> =
            items.map { AppointmentModelView(it, AppointmentHeaderItem(it.status)) }

AppointmentHeaderItem
    private val headerId: Int
        get() = when (status) {
            Appointment.Status.APPROVED -> HEADER_UPCOMING
            else -> HEADER_OTHER
        }

    init {
        isSelectable = false
        isEnabled = false
    }

    override fun equals(other: Any?): Boolean {
        if (other is AppointmentHeaderItem) {
            return this.headerId == other.headerId
        }
        return false
    }

    override fun hashCode(): Int = headerId.hashCode()

    companion object {
        private const val HEADER_UPCOMING = 1
        private const val HEADER_OTHER = 2
    }

Another case. I created adapter globally in fragment.
private val adapter: FlexibleAdapter<AppointmentModelView>= FlexibleAdapter(listOf(), this)
When fragment added onCreate and other lifecycle methods called but adapter with items already exists in global variables and it contains items.
The problem is in sticky headers they stoped working. All headers except first one become not sticky and first one is visible if scroll position at 0 but if I start scrolling it disappear and left only empty space.

Am I doing something wrong?

@PingForward, yes, don't keep the adapter or any others UI objects in permanent memory.
Regarding your first problem (related to my previous sentence), please check your equals method in the items. Only the business objects (the original list).
But I think that, all your problems seem not related to the Adapter itself, but the way you manage the objects in lifecycle.

@PingForward, If you don't have any update, I will close this issue.


Extract hardcode texts to the string resource in the Bottom Sheet Dialog of Speaker Detail Screen

Issue

none

Overview (Required)

Extract hardcode texts to the string resource in the Bottom Sheet Dialog of Speaker Detail Screen

Links

Similar PR: https://github.com/DroidKaigi/conference-app-2018/pull/572

Screenshot
none

LGTM:+1:


Want to add shell sort in you repo

I want to contribute in your repo . I have already created a PR . kindly merge it. kindly tag it as hactoberfest 2024.
Regards

I have merged the PR, thanks for your contribution!

Closing this issue as it is resolved easily!


Consider adding keyboard shortcut in VS Code extension to run shiny app

Thanks for the VS Code extension. It would be nice if there was a default keyboard shortcut to shiny.python.runApp. The shortcut could be the same as the render or preview Quarto extension shortcut ( Ctrl+Shift+K or Ctrl+Shift+L). Edit: I realized after posting that this issue should belong in the vscode extension repo which doesn't appear to be public at this time. Please close this issue if it is already being addressed.

This is a great idea, here's how you can do this yourself. Use the command palette to open "Preferences: Open keyboard shortcuts (JSON)". Then add the following JSON snippet to map the "shiny.python.runApp" command to Cmd/Ctrl + Shift + K:
  {
    "key": "cmd+shift+k",
    "command": "shiny.python.runApp",
    "when": "shiny.python.active"
  },

If we like Cmd + Shift + K, we could add it to the extension. There's some precedent in RStudio for Cmd + Shift + S, but in VS Code this action feels well-aligned with "Quarto preview" and the shortcut it'd be overriding is likely less popular ("Save file as" (S) vs "Delete line" (K)).


fix apostrophe in dashboard

cool, but why do you need another commit to merge? you can make a PR not from master, but from your other branch (that's how I usually do it)

other than that I'll merge after the Travis would pass

you can close the issue as resolved, meanwhile I'll deploy


Update Child Record - not applying "Yes" (1)

Using Dynamics 365 <IP_ADDRESS>, Dynamics 365 Workflow Tools Solution <IP_ADDRESS>
I set up a field on Opportunity: "Tax Applicable" (Boolean), and the same field on Opportunity Products. I used the "Update Child Records" workflow to update this value on the opportunity products, whenever the value changed on the opportunity. The "update only active child records" setting was set to no (update all records).
Strangely, the workflow works perfectly when updating the value to no (0), but does not work at all when setting the value to yes (1). I had this working and tested with version <IP_ADDRESS> of the tools, before the "update only active child records" flag was introduced. I wonder if this feature has had an adverse effect on functionality? I was able to resolve the issue by removing the solution, downgrading to <IP_ADDRESS>, and then reinstating my workflow.
Many thanks for any help provided, this tool has been really invaluable to me 👍

Hi tpickles1984,
on this I found a bug, just fixed today. I'm going to create an update on current release to fix it.
Thanks!

solved on version <IP_ADDRESS>
thanks for your feedback.

Thank you for looking in to it so quickly! Excellent work :-)


Not working with debian's vim 8.1 or Vundle?

Hi again :wave:
Since this is the most useful plugin I'm using currently, wanted to install it to a debian server, using Vundle, which failed with:
Error detected while processing /home/seqizz/.vim/bundle/vim-oscyank/plugin/oscyank.vim:
line   62:
E475: Invalid argument: type = '') abort
line   67:
E133: :return not inside a function
line   71:
E121: Undefined variable: a:type
line   73:
E133: :return not inside a function
line   81:
E133: :return not inside a function
line   84:
E684: list index out of range: -1
line   85:
E684: list index out of range: 0
Error detected while processing function YankOSC52:
line   24:
E121: Undefined variable: s:osc52_table
E116: Invalid arguments for function get(s:osc52_table, osc52_key, s:osc52_table['default'])(a:str)
line   25:
E121: Undefined variable: osc52
E116: Invalid arguments for function <SNR>54_raw_echo
[oscyank] 0 characters copied
Error detected while processing /home/seqizz/.vim/bundle/vim-oscyank/plugin/oscyank.vim:
line   88:
E193: :endfunction not inside a function

vim --version output is:
VIM - Vi IMproved 8.1 (2018 May 18, compiled Jun 15 2019 16:41:15)
Included patches: 1-875, 878, 884, 948, 1046, 1365-1368, 1382, 1401
Modified by<EMAIL_ADDRESS>Compiled by<EMAIL_ADDRESS>Huge version without GUI.  Features included (+) or not (-):
+acl               +extra_search      +mouse_netterm     +tag_old_static
+arabic            +farsi             +mouse_sgr         -tag_any_white
+autocmd           +file_in_path      -mouse_sysmouse    -tcl
+autochdir         +find_in_path      +mouse_urxvt       +termguicolors
-autoservername    +float             +mouse_xterm       +terminal
-balloon_eval      +folding           +multi_byte        +terminfo
+balloon_eval_term -footer            +multi_lang        +termresponse
-browse            +fork()            -mzscheme          +textobjects
++builtin_terms    +gettext           +netbeans_intg     +textprop
+byte_offset       -hangul_input      +num64             +timers
+channel           +iconv             +packages          +title
+cindent           +insert_expand     +path_extra        -toolbar
-clientserver      +job               -perl              +user_commands
-clipboard         +jumplist          +persistent_undo   +vartabs
+cmdline_compl     +keymap            +postscript        +vertsplit
+cmdline_hist      +lambda            +printer           +virtualedit
+cmdline_info      +langmap           +profile           +visual
+comments          +libcall           -python            +visualextra
+conceal           +linebreak         -python3           +viminfo
+cryptv            +lispindent        +quickfix          +vreplace
+cscope            +listcmds          +reltime           +wildignore
+cursorbind        +localmap          +rightleft         +wildmenu
+cursorshape       -lua               -ruby              +windows
+dialog_con        +menu              +scrollbind        +writebackup
+diff              +mksession         +signs             -X11
+digraphs          +modify_fname      +smartindent       -xfontset
-dnd               +mouse             +startuptime       -xim
-ebcdic            -mouseshape        +statusline        -xpm
+emacs_tags        +mouse_dec         -sun_workshop      -xsmp
+eval              +mouse_gpm         +syntax            -xterm_clipboard
+ex_extra          -mouse_jsbterm     +tag_binary        -xterm_save
   system vimrc file: "$VIM/vimrc"
     user vimrc file: "$HOME/.vimrc"
 2nd user vimrc file: "~/.vim/vimrc"
      user exrc file: "$HOME/.exrc"
       defaults file: "$VIMRUNTIME/defaults.vim"
  fall-back for $VIM: "/usr/share/vim"
Compilation: gcc -c -I. -Iproto -DHAVE_CONFIG_H   -Wdate-time  -g -O2 -fdebug-prefix-map=/build/vim-4Pursk/vim-8.1.0875=. -fstack-protector-strong -Wformat -Werror=format-security -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=1
Linking: gcc   -Wl,-z,relro -Wl,-z,now -Wl,--as-needed -o vim        -lm -ltinfo -lnsl  -lselinux -lacl -lattr -lgpm -ldl

Thanks for any hints.

It seems to be the recent OSCYankOperator  commit (fe67f649111dc15336c9905b9aee28e242add358). I use vim-plugged and I pinned my config to use the last working commit (e2a6ec4fb91b38591445bdaa9972f54653dbcd49), which you can try if Vundle supports it.

Sorry if it broke anything :/
I'm currently away from home and don't have access to a computer for the next 5 days unfortunately.
I'll try to fix this issue as soon as I get back home. Or if someone is willing to make a PR about it, it'd be welcome :)

same here on Debian 11, neovim 0.4.4 and vim-plug

I've reverted the commits that introduced the errors. The issue should be fixed now but the yank operator has been removed. I'll see if I can add it again without introducing any errors in the following days.

Hi all -- mea culpa. You're seeing that error because optional/default arguments were not supported until Vim 8.1.1310 (something I didn't realise when I was writing the patch). If you're using Vim >= 8.1.1310 (oe Neovim version) then this should work fine, otherwise I'd expect errors.
I think the patch will need to be updated to use Vim's ... arguments for backward compatibility.
function! Foo(bar, ...)
    let baz = get(a:, 1, 0)
endfunction

^ something like that.
@ojroques and others, apologies for the breakage!

Hey again folks -- proposed fix in #17, would anybody mind testing?

I've merged the fix. Feel free to re-open this issue if the problem persists.


Change store RowIter type from Iterator to Stream

resolve #1410

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

43 of 52 (82.69%)  changed or added relevant lines in 11 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.01%) to 99.173%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

storages/sled-storage/src/index_mut.rs
2
4
50.0%

core/src/executor/fetch.rs
14
17
82.35%

core/src/executor/validate.rs
13
17
76.47%

Totals

Change from base Build<PHONE_NUMBER>:
-0.01%

Covered Lines:
50237

Relevant Lines:
50656

💛  - Coveralls


[Feature request] swipe down gesture and cheat code

Hi! I love your launcher and have been using it for a while. I would like to make to feature suggestions. The first one would be a swipe down to open notitfications. The second would be a kind of cheat code (maybe just * or #) to see all apps on the home screen.

As of 1.4.2, swiping straight down will open the notifications shade.
I'm considering adding a way to display all apps on the home screen

As of 1.4.3, there will be an option to make searching "..." display all apps


AC: align common semantic segmentation behaviour

@vladimir-dudnik @eaidova
Are you sure this works? With this change, it is impossible for me to use accuracy checker. (worked before this change)
Since the identifier and mask_id do not encode the relative paths anymore (e.g. images/ and labels/) the accuracy_check evaluator module can't find them. Even if I force the image source location (with -s <source_folder>), then it will find the image, but not the mask.

@ngaloppo  you need to specify segmentation_masks_source parameter in config, which will be works as prefix for mask_id. data_source  used for images only now. these changes is not our decision, they were required for enabling sementic segmentaion task in DL Workbench

@eaidova Thank you for your quick response. That makes sense now. I didn't see the change to dataset_definitions.yml in the same PR so I assumed nothing else had changed. I'm assuming this is captured in the documentation?

@eaidova I am curious, how come you didn't have to specify segmentation_masks_source for all datasets that use common_semantic_segmentation in the dataset_definitions.yml? I only see it defined on VOC, even though there are many other ones that have a separate mask folder (e.g. adas).

@ngaloppo , it is my mistake, we have precollected annotation from previous releases in validation pipeline, I update definition when we will be ready to update validation infra. (anyway nobody has access to our data for these datasets). Regarding docs, yes we have note about masks_source, but I think we should highlight it, thanks


Axes titles are misaligned when orientation set

When the axis orientation property is set to 'right' or 'top', the title of the axis is not aligned correctly.

Resolved in #145


Rotational dismantlation

Stairways:
The upper portion  of the image consists of stairs (E/W) attached to a vertical (N/S) landing attached to (W/E) stairs. I wanted to duplicate the stairs but rotate them 180° so attached a temporary area to the four nodes and added a 5th node area only on the left hand side. Both ends of the upper stairs moved correctlybut only the 'clockwise' ends of the landing and lower stairs moved. The other ends broke free from the things they were joined to and remained stationary. The lower portion of the image shows an anticlockwise rotation of the area of approx 25°.
Can this be fixed please - so a shape moved or rotated has everything attached move as well ?
Another 'nice' feature perhaps would be the ability to 'flip' a shape - either E-W or N-S to generate a mirror image of the objects.
Cheers.

I tried this out today but I can't reproduce the issue.  When I try this, the attached ways always stay attached (see below)..
Can you create a test shape someplace that demonstrates the issue?

Can you create a test shape someplace

On http://master.apis.dev.openstreetmap.org/, not the live DB

Ahh - I know what it is - it's after the three items have been copied and pasted as the pasted items' nodes no longer remain connected. This issue is reported elsewhere.
(the live DB is fine for sandbox activities)

Nice, glad it makes sense now..


what do the colors represent in the bubble chart?

import pandas as pd
df = pd.read_csv('http://www.stat.ubc.ca/~jenny/notOcto/STAT545A/examples/gapminder/data/gapminderDataFiveYear.txt', sep='\t')
df2007 = df[df.year==2007]

df2007.iplot(kind='bubble', x='gdpPercap', y='lifeExp', size='pop', text='country', filename='cufflinks/simple-bubble-chart')

I think I expected all of these points to have the same color

Hi, is it possible to get multicolor bubble plot by passing some variable (Tried 'color' but it is giving only first color in list passed). Sometimes it looks good with multiple colors rather than single tone.


Support comparing channel by name or id

Thanks for the lovely library. I'm building a permission system for finer-grained access control to the bot, so inevitably, I stumbled upon the need to check whether some messages belong to certain channel. This PR is a direct port of the functionality in the official slackclient's channel object: https://github.com/slackhq/python-slackclient/blob/master/slackclient/_channel.py#L11-L15

@limdauto How are you using this in your run.py or equivalent? Looking to do the same, not sure where to start :)

@wgins in your message handler, you can do message.channel == "foo"


ADD: FeeRates from thorchain

Thirdparty services are delayed
Instead of using third-parties, default to use thorchain gas oracle instead, which is always up to date
https://thornode.thorchain.info/thorchain/inbound_addresses
Gas rates you can get for each chain, if nothing there, then use the other service providers.
fastest: 1.5x
fast: 1x
average: 0.67x
For PoW chains, the gas rate is a feeRate.
For BNB, it is fixed (and not really relevant) but it is the total fee to pay

reviewed this yesterday.  I propose the following approach:

create a base class in xchain-client XChainBase and create  getFeesFromThorchain() there

this would also allow us to centralize the setPhrase() and purgeclient() logic in this class helping ensure more consistent behavior across chain implementations

refactor all existing client implementation to call super.getFeesFromThorchain() and if no response after x sec timeout(default 3? secs) then it falls back to fetchign for the explorer or alternate source.

going to proceed as described in the comment above.

@veado @thorchain-admin @stuartwk  i just pushed the initial implementation for this, it adds a base class BaseXChainClient to centralize the fetching of the gas prices (and it also centralizes some  other common attributes)
i refactored the xchain-bitcoin client to extend this base class, it was a pretty clean change and removed a bunch of redundant  code


Update SqlToolsService to .68 (SqlClient 2.1.1)

Primary update here is to get the new SqlClient version (2.1.1) that contains the Mac Kerberos fix as well as some things for Always Encrypted.
Will be doing thorough testing with private builds before merging this in.

Pull Request Test Coverage Report for Build 478915020

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 43.213%

Totals

Change from base Build 478899944:
0.0%

Covered Lines:
24388

Relevant Lines:
51754

💛  - Coveralls

Pull Request Test Coverage Report for Build 478915020

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 43.213%

Totals

Change from base Build 478899944:
0.0%

Covered Lines:
24388

Relevant Lines:
51754

💛  - Coveralls

Haven't encountered any issues so getting this in now so insiders/dev builds can start testing it. Will be following up with making signoff testing for the January release to ensure that all important scenarios are tested.

Haven't encountered any issues so getting this in now so insiders/dev builds can start testing it. Will be following up with making signoff testing for the January release to ensure that all important scenarios are tested.


API revisions

[x] Change send to take an array of arguments
[x] Add endpoint to mine regtest coins
[x] Balance should take unit as argument
~- [ ] Automatically store named wallets in DB~
~- [ ] Test sendMax utxo param~
[x] Change fromWif and WatchOnly to static methods
[x] Redirect to swagger docs from / of server
[x] Change balance to getBalance,
[x] Fix or override examples displayed in default swagger ui
[x] Add defaults for wallet, test POST /v1/wallet
[x] Rename internal functions createWaletObject to createWallet and current createWallet to createWalletAsResponse
[x] Resolve all swagger validation warnings
[x] Test create wallet without parameters
[x] Make to required on send
[x] Adjust fee

Outstanding issue moved to named wallets #37


"obi ls" should probably be called "obi template list"

for consistency's sake.

(this also frees up obi ls to do something interesting in the future)

More thoughts on this:
I would like a convenient shell one-liner to update all of my templates. More generally, I would like to be able to write convenient shell-oneliners to do (some action) on all of my templates.
Today, obi ls 2>/dev/null outputs this to stdout:
Installed templates:
cpp
greenhouse
gspeak
seabed

If not for that first line, I could do something like (assuming no spaces in my template names… though there are workarounds for that)
for temp in $(obi ls); do obi template upgrade $temp; done

But because of that "Installed templates" header line, I have to add a tail to the subshell pipeline. Oh, the humanity!
for temp in $(obi ls | tail -n +2); do obi template upgrade $temp; done

But I think it's reasonable to include that line of output. It's probable someone might run obi ls after seeing it in the help screen without knowing what it does. The extra line of output is helpful in describing what comes next.
If the command were called obi template list, I think it would be totally fair to remove the "Installed templates" line from the output.  And then my one-liner would be cleaner. :-)

I'm going to submit an unsolicited MR about this, even though I'm the only person who seems to care. More evidence obi ls is the wrong name: to list templates, you use obi ls, but to remove a template you don't use obi template rm, you use obi template remove.

Blind user experience note: I was surprised there was no obi template ls recently, and didn't see the obi ls command.
I prefer short names, so
obi t ls
should work.  And I don't mind if the heading line is dropped or requires a -f --fancy option.

Commands should be consistent.  All commands directly touching on templates should use the obi template format.
If we want to go to a different format, we could entertain that in a separate ticket.
If we want to support shortened forms, I think that would also be a new ticket.

Having said that, why not stick with the standard unix commands?

obi template ls
obi template rm

yes, please.  ls and rm are nice, short, and familiar.

I created a new issue for nice short names. https://github.com/Oblong/obi/issues/72


MM-12348 Persist interactive menu choices past channel switch and share with thread view

Summary
When choosing an option in the interactive menus, have the choice persist after channel switch and have threaded view and main channel view share choices. The web app does something similar.
Ticket Link
https://mattermost.atlassian.net/browse/MM-12348
Device Information
Android Galaxy S9

I did test going to the background on Android and it worked fine, let me check on iOS

@jwilander also test closing the app completely and open it back

Closing the app doesn't persist the choices for sure, but neither does the web app so that's fine

Works on iOS coming back from the background.
@enahum do you know a simple method of not including a specific view reducer in the blacklist for redux-persist?

@jwilander https://github.com/mattermost/mattermost-mobile/blob/master/app/store/index.js#L52

Right I know that exists but how do I tell it to not include views.post.submittedMenuActions?

ohhh I don't think is possibly to go that far in a simple way, and if there is a way I'm not aware of it

Ok cool, figured. This is fine then, doesn't really need to persist past app close

cherry-picked 1.13


HN example: Increase firebase cache times for important assets

See https://www.webpagetest.org/performance_optimization.php?test=180228_Y9_308b0df83539fbb26d30a51ea3067c7b&run=3#cache_static_content
Add 24-hour expire for pwa.dart.js, images/logo.svg
...and main.dart.js ?

As far as I know I did?
https://github.com/dart-lang/angular/blob/7024dbe70531f5b8b3450992dfcd957d2e798e3b/examples/hacker_news_pwa/firebase.json#L15-L26
@kevmoo

Is there someway to indicate a request isn't a static asset? The 80/100 score for using CDN on static assets blames a REST API we hit, which isn't a static asset.

I think we did this. Feel free to re-open if I'm mistaken @kevmoo.

You did it for the root file, but not the other stuff...
I'll dig in...


Add drowning mechanic

I propose that mobs are able to drown properly. Currently, there is no proper implementation of drowning.
Which is quite surprising.
Note water_damage is not a replacement for drowning, as it damages mobs for merely touching it, and the damage happens immediately. So water_damage is pretty agressive. Mobs just touching water tend to die pretty fast, this is especially a problem for floating mobs.

Generally, the drowning mechanic for mobs should roughly work more or less like for players.
Mobs have a number of breath points (BP) which runs out while they are in water (or other certain nodes). “Inside” means “fully submerged”, not just touching.
When the BP are 0, drowning damage is taken regularily.
When the mob is no longer in a “drowning node”, the breath points quickly rise again, up to the maximum capacity.
Details:

The maximum BP are stored in max_breath. The default is nil, which disables drowning for this mob
The BP are never lower than 0 and never higher than max_breath
All mobs spawn with their full BP
A mob is said to be “drowning” if it is submerged in a node with the drowning field set
While drowning, the mob loses 1 BP every 2 seconds (this time has been chosen because it's the same for players)
While not drowning, the mob gains 1 BP every 0.5 seconds
If the mob has 0 BP and is drowning, it loses the health set in the drowning attribute every 2 seconds
Optional attributes:

drowning_nodes overrides the nodes in which the mob might drown. This is a key-value storage. The keys are node names. Additionally, by adding ["default"] = true to the list, nodes with drowning will be re-enabled, dealing the damage set in the drowning attribute of the node

Example: { ["air"] = 1 }: Mob drowns in air, dealing 1 damage, but ONLY in air. Useful for fish.
Example: { ["example:magic_mud"] = 2, ["default"] = true }: Mob drowns normally, but additionally it also drowns in magic mud
Would be nice if this attribute also supports groups, but this can wait

If this feature is added: In case a node fits into multiple groups, take the first group in the list to read the damage

Make it possible to read and write the mob's current breath (or return nil if drowning is disabled)

Finally, water_damage should not be touched. water_damage is still useful in its own right, e.g. for fire elementals and the like.

This would be a nice feature but would require extra mob settings for head level get_node's to check for water which would slow things down, but as a specific setting could be a thing...  Also I need to redo water floating for mobs so they dont end up walking on the surface but bob around and sometimes drop under.


Upgrade to purescript 0.14.2

@athanclark Would you be able to release a new version with this, so this can be included into the current purescript package set?


Add action to checkout and detect changed files

Codecov Report

Merging #2 (287993e) into main (0f69f24) will decrease coverage by 0.47%.
The diff coverage is n/a.

:exclamation: Current head 287993e differs from pull request most recent head 1b84e86. Consider uploading reports for the commit 1b84e86 to get more accurate results

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@            Coverage Diff             @@
##             main       #2      +/-   ##
==========================================
- Coverage   92.32%   91.85%   -0.47%
==========================================
  Files          59       58       -1
  Lines        2892     2764     -128
==========================================
- Hits         2670     2539     -131
- Misses        222      225       +3

see 42 files with indirect coverage changes


🐛 Make set_managed_storage() safer

https://laminlabs.slack.com/archives/C07DB677JF6/p1723623568991179?thread_ts=1723618378.437019&cid=C07DB677JF6

This is good, but please take the time to write a test for it and add the comments. It's very fundamental.
We'll also still need to update RLS, right? It's not a security concern, only an integrity concern, hence less urgent.

Not sure what kind of test can be added here, i am not really sure it is a good idea to add something failing, touching hub every time, than deleting the record to the CI.

It's totally OK to add some failing and touch the hub all the time. It can deal with millions of requests.

Maybe even in hub-local?

I will try to add some testing here.

I am not worried about the number of requests, rather about adding some garbage to the hub, and it will happen every time something incorrect happens to this flow (in future code edits etc).


prevent release workflows to run in parallel, and bump version

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 91.591%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
6045

Relevant Lines:
6600

💛  - Coveralls


webpack+proxy sometimes throws internal error instead of true error message

i.e. kubectl commands without k8s auth
Now:

Expected:

Related to #293


System Out: add and save attractor plot

It's good to have attractor visualization when modelling the system, it's used often

Done in https://github.com/chaossoftware/modelled-systems/commit/5b88bf480e8e2f8cb2bbb445f2113af87d7f75fe


[Bug]: Auto Split not working

Installation Method
Docker
The Problem
I want to use the automatic PDF splitting feature, but after uploading, the downloaded file is the same as the original PDF and is not split. I found issue #743, and I believe my situation is the same. The QR code link is https://github.com/Stirling-Tools/Stirling-PDF. What should I do?
Version of Stirling-PDF
0.33.1
Last Working Version of Stirling-PDF
No response
Page Where the Problem Occurred
/auto-split-pdf
Docker Configuration
No response
Relevant Log Output
No response
Additional Information
No response
Browsers Affected
No response
No Duplicate of the Issue

[X] I have verified that there are no existing issues raised related to my problem.

Sorry, there was a mistake in my previous statement. The QR code link is https://github.com/Frooodle/Stirling-PDF.
Auto Splitter Divider (with instructions).pdf


Could not read tables from @DriftDatabase annotation

So far I had three tables in my drift database, all working fine. Now I added another one and when I run flutter pub run build_runner build, I get the following error message:
[INFO] drift_dev:drift_dev on lib/database/my_db.dart:line 15, column 7 of package:myapp/database/my_db.dart: Could not read tables from @DriftDatabase annotation!
Please make sure that all table classes exist.

Here is what my @DriftDatabase annotation looks like:
@DriftDatabase(
  tables: [Artists, Tags, AssignedTags, Foobars],
  include: {'queries.drift'}
)
class MyDB extends _$MyDB {

The SQL code:
CREATE TABLE foobars (
    prop_key VARCHAR(255) NOT NULL PRIMARY KEY,
    prop_value VARCHAR(512)
);

Originally, the new table was called UserProperties, with the resulting object being called UserProperty, but I renamed it to the simpler Foobars to rule out a potential cause of the issue.
In the created my_db.g.dart file, there definitely is a Foobars class that extends Table, so this error does not make sense to me... However, when I made a query to the table, I got an error that it does in fact not exist.
I am using the sqlite3_flutter_libs package as a sqlite connector. Maybe it would be helpful to activate logging, but I could not figure out how.
Any help would be appreciated.

I'm getting the same error message today when running build runner.
[WARNING] drift_dev:drift_dev on lib/db.dart: There were some errors while running moor_generator on package:database_package/db.dart:         [INFO] drift_dev:drift_dev on lib/db.dart:line 57, column 7 of package:database_package/db.dart: Could not read tables from @DriftDatabase annotation! Please make sure that all table classes exist.
I was previously using Drift v1.4, but updated to v1.7 and still got the same error.

So far I had three tables in my drift database, all working fine. Now I added another one and when I runflutter pub run build_runner build, I get the following error message:

Was Foobars defined in a .drift file? In that case, adding the file to the includes is enough, you don't have to add the table explicitly. In fact, there's not much that drift could do about this in that case:

At the time drift_dev runs, the Foobars class is not generated yet (builders consistently see the state before they ran to ensure consistent rebuilds)
This means that the @DriftDatabase references an unknown Foobars class and is thus an invalid constant.
Which means that drift_dev can't even read parts of it due to the way the analyzer API for reading constants is implemented.

Hopefully, the easy solution is to just remove all tables defined in .drift files from the tables:  parameter in the annotation.

I was previously using Drift v1.4, but updated to v1.7 and still got the same error.

Thanks for the report! Do you get any warnings from the analyzer in the @DriftDatabase annotation if you delete the generated file? Or in other words, do you reference generated classes in there? If not, are there more details you could share to help me reproduce this?

Looks like my issue was actually a mismatched casing on one of my files and the import for it with my database class. Visual Studio Code was able to detect the file without issue so it was not immediately obvious. I am not sure how I was able to build previously with that filename/import or when exactly it stopped working for me but I am able to build correctly now.
Thank you for your quick response and looking into the issue for me.

Unfortunately not, removing all tables from the annotation did not help...

Just to be sure, you still got that error after removing all entries from the tables list? So you don't have any Dart-defined tables at all? From a quick look at where  that error comes from in drift, it seems like it might still generate most code if it can't read Dart tables. Or is the annotation completely broken for you?

Upgrading my dependencies, amongst others upgrading drift from 1.6.0 to 1.7.0

This shouldn't make much of a difference, but what analyzer version are you on? Drift emits that error really early in the build step without applying much internal logic. It essentially asks  the analyzer for the tables field on that annotation and emits the error if we get back null.

Same error when trying to migrate from moor_flutter to drift.
I think it has something to do with creating tables.
Print:

I solved my problem.
I'm using the default files with the first capital letter and my import was lowercase! x.x

Thanks for providing more details! I've tried to reproduce this in 6049d1aaa019623617b05164f27ae689bbed68d5 but I couldn't reproduce the warning. I wonder if this could be about a broken analyzer cache, but in that case I'm not sure how to resolve it.

Alright :D Yeah I think this may be an analyzer bug, but those can be quite hard to reproduce because the analyzer has a bunch of hidden caches.
Since it looks like the issue was resolved for everyone who commented here (and since it's probably not a drift bug), I'll close this. If anyone is still running into this, please let me know so that we can look into again.


Fix img2img DDIM index out of bound

Added a community solution to fix index out of bound when doing img2img generation with ddim sampler. Also, restored steps_out to be ddim_timesteps + 1 since the removal was meant to fix the 1000 steps issue

Thanks for this. Is there a test case that you use to test the bug before and after the fix? It is certain values of step, is that right?

Thanks for this. Is there a test case that you use to test the bug before and after the fix? It is certain values of step, is that right?

After merging version 2.0 to my local machine, I encountered the following error frequently during img2img generation:
../aten/src/ATen/native/cuda/ScatterGatherKernel.cu:145: operator(): block: [0,0,0], thread: [0,0,0] Assertion `idx_dim >= 0 && idx_dim < index_size && "index out of bounds"` failed.

Traceback (most recent call last):
  File "/stable-diffusion/./ldm/generate.py", line 388, in prompt2image
    results = generator.generate(
  File "/stable-diffusion/./ldm/invoke/generator/base.py", line 78, in generate
    image = make_image(x_T)
  File "/stable-diffusion/./ldm/invoke/generator/img2img.py", line 45, in make_image
    samples = sampler.decode(
  File "/usr/local/lib/python3.9/site-packages/torch/autograd/grad_mode.py", line 27, in decorate_context
    return func(*args, **kwargs)
  File "/stable-diffusion/./ldm/models/diffusion/sampler.py", line 347, in decode
    outs = self.p_sample(
  File "/usr/local/lib/python3.9/site-packages/torch/autograd/grad_mode.py", line 27, in decorate_context
    return func(*args, **kwargs)
  File "/stable-diffusion/./ldm/models/diffusion/ddim.py", line 79, in p_sample
    sigma_t = torch.full((b, 1, 1, 1), sigmas[index], device=device)
RuntimeError: CUDA error: device-side assert triggered
CUDA kernel errors might be asynchronously reported at some other API call,so the stacktrace below might be incorrect.
For debugging consider passing CUDA_LAUNCH_BLOCKING=1.

Image generation no longer work after that and restart is required. The common configuration that I used at that time is as follows:

sampler_name: DDIM
steps: 12
cfg_scale: 0.65 (I used other values as well between 0.01 to 0.95)

After applying the fix, I no longer receive the error above. Please note that the value of ddim_timesteps is not the same.
# Step 12 (before)
[  0  83 166 249 332 415 498 581 664 747 830 913 996]
# Step 12 (after)
[  0  83 166 249 332 415 498 581 664 747 830 913]

# Step 18 (before)
[  0  83 166 249 332 415 498 581 664 747 830 913 996]
# Step 18 (after)
[  0  83 166 249 332 415 498 581 664 747 830 913]

# Step 24 (before)
[  0  41  82 123 164 205 246 287 328 369 410 451 492 533 574 615 656 697
738 779 820 861 902 943 984]
# Step 24 (after)
[  0  41  82 123 164 205 246 287 328 369 410 451 492 533 574 615 656 697
738 779 820 861 902 943]

# Step 27 (before)
[  0  37  74 111 148 185 222 259 296 333 370 407 444 481 518 555 592 629
666 703 740 777 814 851 888 925 962 999]
 # Step 27 (after)
[  0  37  74 111 148 185 222 259 296 333 370 407 444 481 518 555 592 629
666 703 740 777 814 851 888 925 962

It seems that the error only happens when num_ddim_timesteps % 3 == 0 (step is multiple of 3). For example, using the step 27 will result in out of bound when using the original steps_out = ddim_timesteps + 1 code. This fix will resolve both issue as it excludes the extra time step in the bad cases.


Consider renaming the hidePasswordButton property

There is a property called hidePasswordButton currently:
https://github.com/vaadin/vaadin-login/blob/master/src/vaadin-login.html#L155
This name is not really aligned with the other examples:

vaadin-password-field: revealButtonHidden https://github.com/vaadin/vaadin-text-field/blob/3a7d4de5c2fa3fe4c8584064691d6e6be856342b/src/vaadin-password-field.html#L91 ("hidden" is used, not "hide")

vaadin-confirm-dialog: cancel https://github.com/vaadin/vaadin-confirm-dialog/blob/9b9d11d0b095dc5b2653a74bbe71ccf643b3e27a/src/vaadin-confirm-dialog.html#L183
("button" is not included in the property name at all)

vaadin-text-field: cleatButtonVisiblehttps://github.com/vaadin/vaadin-text-field/blob/3a7d4de5c2fa3fe4c8584064691d6e6be856342b/src/vaadin-text-field-mixin.html#L148
(also currently in alpha)

Is there any decision about the naming?
Please, keep in mind that it's 2 different use cases when an element is visible and hidden by default.


[INFRA] Add CPM_SOURCE_CACHE

Artifacts available for download:

Artifact Name
Download Link

clang.versions
https://github.com/seqan/actions/actions/runs/11895076431/artifacts/2202079435

gcc.versions
https://github.com/seqan/actions/actions/runs/11895076431/artifacts/2202074273

intel.versions
https://github.com/seqan/actions/actions/runs/11895076431/artifacts/2202074445


xmpp-bridge: init at 0.6.0

Description of changes

A tool that forwards the stdout of a command to an XMPP account.
https://github.com/majewsky/xmpp-bridge
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

@AndersonTorres thanks for the cleanup, build still works fine.

@Gigahawk I think the only thing left is to amend the last commit into the previous one


1823825 | Message fixes | Address validation issues | 48

This PR is for user story 1823825.
Fixed an issue with missing alt text descriptions.
If these changes are not appropriate, please let me know. I'm only trying to clean up validation issues in this repo. So I can easily close this PR or modify it in whatever way is best for the content.

Docs Build status updates of commit 76e672b:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

technical-reference/biztalk-mapper-grid.md
:white_check_mark:Succeeded
View

technical-reference/btbatchoperationstatus-fields-com.md
:white_check_mark:Succeeded
View

technical-reference/btbatchoperationstatus-members-com.md
:white_check_mark:Succeeded
View

technical-reference/character-to-ascii-functoid.md
:white_check_mark:Succeeded
View

technical-reference/common-logarithm-functoid.md
:white_check_mark:Succeeded
View

technical-reference/conversion-functoids-reference.md
:white_check_mark:Succeeded
View

technical-reference/cosine-functoid.md
:white_check_mark:Succeeded
View

technical-reference/cumulative-average-functoid.md
:white_check_mark:Succeeded
View

technical-reference/cumulative-concatenate-functoid.md
:white_check_mark:Succeeded
View

technical-reference/cumulative-functoids-reference.md
:white_check_mark:Succeeded
View

technical-reference/cumulative-maximum-functoid.md
:white_check_mark:Succeeded
View

technical-reference/cumulative-minimum-functoid.md
:white_check_mark:Succeeded
View

technical-reference/cumulative-sum-functoid.md
:white_check_mark:Succeeded
View

technical-reference/database-functoids-reference.md
:white_check_mark:Succeeded
View

technical-reference/database-lookup-functoid.md
:white_check_mark:Succeeded
View

technical-reference/date-and-time-functoid.md
:white_check_mark:Succeeded
View

technical-reference/date-and-time-functoids-reference.md
:white_check_mark:Succeeded
View

technical-reference/date-functoid.md
:white_check_mark:Succeeded
View

technical-reference/division-functoid.md
:white_check_mark:Succeeded
View

technical-reference/equal-functoid.md
:white_check_mark:Succeeded
View

technical-reference/error-return-functoid.md
:white_check_mark:Succeeded
View

technical-reference/format-message-functoid.md
:white_check_mark:Succeeded
View

technical-reference/get-application-id-functoid.md
:white_check_mark:Succeeded
View

technical-reference/get-application-value-functoid.md
:white_check_mark:Succeeded
View

technical-reference/get-common-id-functoid.md
:white_check_mark:Succeeded
View

technical-reference/get-common-value-functoid.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

@MandiOhlinger This PR is ready for merge.


Nothing works on VisualFSharp.Unittests project

Severity	Code	Description	Project	File	Line	Suppression State
Error	FS3160	Problem reading assembly 'D:\WLCR\github\visualfsharp\Debug\net40\bin\FSharp.Build.dll': Build was not evaluated, expected the results to be ready after 'Eval' (GetCheckResultsAndImplementationsForProject, data = ("FinalizeTypeCheck", [|Id 2792; Id 2793; Id 2794; Id 2795; Id 2796|], Id 2798,
false, None)).	VisualFSharp.Unittests	D:\WLCR\github\visualfsharp\vsintegration\tests\unittests\UnusedOpensTests.fs	1	Active
Error	FS3160	Problem reading assembly 'D:\WLCR\github\visualfsharp\Debug\net40\bin\FSharp.Compiler.Private.dll': Build was not evaluated, expected the results to be ready after 'Eval' (GetCheckResultsAndImplementationsForProject, data = ("FinalizeTypeCheck", [|Id 2799; Id 2800; Id 2801; Id 2802; Id 2803|], Id 2805,
false, None)).	VisualFSharp.Unittests	D:\WLCR\github\visualfsharp\vsintegration\tests\unittests\UnusedOpensTests.fs	1	Active
Error	FS3160	Problem reading assembly 'D:\WLCR\github\visualfsharp\Debug\net40\bin\FSharp.Editor.dll': Build was not evaluated, expected the results to be ready after 'Eval' (GetCheckResultsAndImplementationsForProject, data = ("FinalizeTypeCheck", [|Id 2806; Id 2807; Id 2808; Id 2809; Id 2810|], Id 2812,
false, None)).	VisualFSharp.Unittests	D:\WLCR\github\visualfsharp\vsintegration\tests\unittests\UnusedOpensTests.fs	1	Active
Error	FS3160	Problem reading assembly 'D:\WLCR\github\visualfsharp\Debug\net40\bin\FSharp.LanguageService.dll': Build was not evaluated, expected the results to be ready after 'Eval' (GetCheckResultsAndImplementationsForProject, data = ("FinalizeTypeCheck", [|Id 2813; Id 2814; Id 2815; Id 2816; Id 2817|], Id 2819,
false, None)).	VisualFSharp.Unittests	D:\WLCR\github\visualfsharp\vsintegration\tests\unittests\UnusedOpensTests.fs	1	Active
Error	FS3160	Problem reading assembly 'D:\WLCR\github\visualfsharp\Debug\net40\bin\FSharp.ProjectSystem.FSharp.dll': Build was not evaluated, expected the results to be ready after 'Eval' (GetCheckResultsAndImplementationsForProject, data = ("FinalizeTypeCheck", [|Id 2820; Id 2821; Id 2822; Id 2823; Id 2824|], Id 2826,
false, None)).	VisualFSharp.Unittests	D:\WLCR\github\visualfsharp\vsintegration\tests\unittests\UnusedOpensTests.fs	1	Active
Error	FS3160	Problem reading assembly 'D:\WLCR\github\visualfsharp\Debug\net40\bin\VisualFSharp.Salsa.dll': Build was not evaluated, expected the results to be ready after 'Eval' (GetCheckResultsAndImplementationsForProject, data = ("FinalizeTypeCheck", [|Id 2827; Id 2828; Id 2829; Id 2830; Id 2831|], Id 2833,
false, None)).	VisualFSharp.Unittests	D:\WLCR\github\visualfsharp\vsintegration\tests\unittests\UnusedOpensTests.fs	1	Active

I've noticed this in other projects as well, but I can't reproduce it (nor in the unit tests projects right now).  After a git clean -xdf and rebuild of everything it all worked, and hasn't stopped working since Friday for me.
cc @dsyme and @KevinRansom

@cartermp Sorry, I've been working on the type provider SDK and not on Visual F# IDE Tools lately...

I haven't seen this error in quite some time. Closing now, but re-open if you see it again.


Fix usage of pipefail in shell tasks

[1][2] added it wrongly causing the shell task not working as expected, this patch fixes it.
[1] https://github.com/openstack-k8s-operators/edpm-ansible/pull/433
[2] https://github.com/openstack-k8s-operators/edpm-ansible/pull/434

/lgtm


guile_3_0: 3.0.7 -> 3.0.8

While at it added trivial updater script.
Changes: https://git.savannah.gnu.org/cgit/guile.git/tree/NEWS?h=v3.0.8#n8

Motivation for this change
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 160051 run on aarch64-darwin 1

1 package failed to build:

guile_3_0

Build failure on aarch64-darwin: http://ix.io/3PEf
...
checking size of size_t... configure: error: in `/private/tmp/nix-build-guile-3.0.8.drv-0/guile-3.0.8':
configure: error: cannot compute sizeof (size_t)
See `config.log' for more details

Build failure on aarch64-darwin: http://ix.io/3PEf
...
checking size of size_t... configure: error: in `/private/tmp/nix-build-guile-3.0.8.drv-0/guile-3.0.8':
configure: error: cannot compute sizeof (size_t)
See `config.log' for more details

Can you extract config.log? I tried to build guile_3_0 on clang-linux and it seemed to configure successfully here.

@ofborg build guile_3_0

Hey, I accidentally created a duplicate. Closed my PR now, but here's a comment with more details from console.log: https://github.com/NixOS/nixpkgs/pull/160926#issuecomment-1046097457
I'll retry this PR on x86_64-darwin and report back the results.

Result of nixpkgs-review pr 160051 run on x86_64-darwin 1

1 package failed to build:

guile_3_0

Aha, that's useful. We probably need to flip off lto support for this mix of toolchain and inker.

Alright, that seems to have worked, @trofi! Here is the patch I applied, the error during configure goes away (haven't waited for the full build yet): https://gist.github.com/gordiasdot/d78b4af4e70566376c4a1b0af8969540
I must say, I'm not sure how or why this issue is caused by linker optimization -- for my own curiosity I'd be interesting in understanding this behavior. Thanks!

To understand the issue mechanically you can check at the lines in ./configure that are supposed to detect type sizes: configure:54594: checking size of size_t:
ac_fn_c_compute_int () { # binary search of "sizeof (size_t)" against the value ...
...
if ac_fn_c_compute_int "$LINENO" "(long int) (sizeof (size_t))" "ac_cv_sizeof_size_t"        "$ac_includes_default"; ...
else ac_cv_sizeof_size_t=0; fi

Here configure script tries to compile various .c files trying to guess size of type. Unfortunately -flto flag seems to be broken on darwin for that toolchain. That's worth investigating in more detail. config.log should contain exact .c file contents to run in standalone environment.

Pushed your change to disable lto as is into guile_3_0 commit.

Proposet possible [PATCH] Test -flto on both compiler and linker fix upstream (Message-Id: <20220220093959.3130873-1-slyich@gmail.com>). Does not show up yet in https://lists.gnu.org/archive/html/guile-devel/2022-02/index.html for some reason.

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-ready-for-review/3032/767

Result of nixpkgs-review pr 160051 run on aarch64-darwin 1

1 package built:

guile_3_0

LGTM
GNU Guile 3.0.8
Copyright (C) 1995-2021 Free Software Foundation, Inc.

Guile comes with ABSOLUTELY NO WARRANTY; for details type `,show w'.
This program is free software, and you are welcome to redistribute it
under certain conditions; type `,show c' for details.

Enter `,help' for help.
scheme@(guile-user)> (define (factorial n) (if (= 0 n) 1 (* n (factorial (1- n)))))
scheme@(guile-user)> (factorial 6)
$1 = 720
scheme@(guile-user)>


error building under cygwin

Getting the following error building yara 3.7.1 under current full install of cygwin:
$ make
Making all in libyara
make[1]: Entering directory '/cygdrive/d/Downloads/yara-3.7.1/libyara'
make  all-am
make[2]: Entering directory '/cygdrive/d/Downloads/yara-3.7.1/libyara'
CC       modules/pe_utils.lo
In file included from /usr/include/w32api/windows.h:95:0,
from ./include/yara/limits.h:34,
from ./include/yara/types.h:36,
from ./include/yara/pe.h:34,
from ./include/yara/pe_utils.h:4,
from modules/pe_utils.c:39:
/usr/include/openssl/ossl_typ.h:159:29: error: expected ‘)’ before numeric constant
typedef struct X509_name_st X509_NAME;
^
/usr/include/openssl/ossl_typ.h:207:33: error: expected ‘)’ before numeric constant
typedef struct ocsp_response_st OCSP_RESPONSE;
^
make[2]: *** [Makefile:681: modules/pe_utils.lo] Error 1
make[2]: Leaving directory '/cygdrive/d/Downloads/yara-3.7.1/libyara'
make[1]: *** [Makefile:487: all] Error 2
make[1]: Leaving directory '/cygdrive/d/Downloads/yara-3.7.1/libyara'
make: *** [Makefile:899: all-recursive] Error 1

Issue likely related to: https://github.com/openssl/openssl/issues/1157

Here is a patch:
`diff --git a/libyara/libyara.c b/libyara/libyara.c
index e74bd00..60e3c7b 100644
--- a/libyara/libyara.c
+++ b/libyara/libyara.c
@@ -38,6 +38,14 @@ SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
#include <yara/threading.h>
#ifdef HAVE_LIBCRYPTO
+#if defined(_WIN32) || defined(CYGWIN)
+// Name clashes between windows.h and openssl
+#undef X509_NAME
+#undef X509_CERT_PAIR
+#undef X509_EXTENSIONS
+#undef OCSP_REQUEST
+#undef OCSP_RESPONSE
+#endif
#include <openssl/crypto.h>
#endif`


[WIP] POC - Decouple dependency phase

POC - Decouple dependency phase so other build tools would be able to use it and code will not be duplicated and maintained several times.
e.g. bazelbuild/rules_scala strict_deps feature.
changes:

CallbackGlobal can not be part of the dependency analysis phase as it is zinc-specific, so the DependencyAnalyzer logic should only know of Global.

AnalysisCallback interface  should be split in two, so that there will be an interface that only declare dependency related methods

pending issues:

LocalToNonLocalClass cache should somehow still be shared with other phases (this branch just creates a standalone instance of the cache for the DependencyAnalyzer due to technical issue relating Symbol type conflicts).

@gkossakowski @stuhood @ittaiz @johnynek
WDYT?

Hi @natansil,
Thank you for your contribution! We really value the time you've taken to put this together.
Before we proceed with reviewing this pull request, please sign the Lightbend Contributors License Agreement:
http://www.lightbend.com/contribute/cla

To validate this pull request against other sbt modules, please visit this link.

also, please note that I've managed to successfully use the dependency analysis logic in rules_scala by copying the code:
https://github.com/bazelbuild/rules_scala/pull/439
(all tests pass)

I think decoupling callbacks for the Dependency phase makes sense. What's your long-term idea to use that code from zinc? Depend on a zinc jar and use the Depenendcy phase yourself (skipping the rest of zinc) or are you thinking about some more high-level api?

What is the exact use case for this decoupling? I'm interested to hear more about how you plan on improving support for strict dependencies.

@gkossakowski, for bazelbuild/rules_scala, pipelining plugin phases (be it from external sources or internal ones) seems like an interesting idea (I can think of at least two plugin phases - strict deps (already exists) and unused deps)
If zinc's Dependency Phase can become standalone (i.e. not use CallbackGlobal and solve the LocalToNonLocalClass cache), then rules_scala can depend on it directly.
Regarding higher-level apis, I'm not sure what you mean. In this PR, iv'e tried to split the actual dependency analysis logic from the Plugin boiler-plate, but the way Global object is structured (huge class that has many many mixins that introduce many inner classes) is very rigid and makes it hard to access the CompilationUnit and syntax tree without passing the entire global object. So I'm not sure how much abstraction can happen without using Global

@jvican regarding support for strict deps in bazelbuild/rules_scala,
Currently there is a solution based on scalacenter/classpath-shrinker where the dependency analysis part collects all jars loaded by the compiler.
The disadvantages here are:

over-approximation of actually used jars (due to compiler's aggressive loading)
no mapping between the source code dependency (file + line number) and the commensurate jar dependency.

The rules_scala plugin also receives information on the jars from Bazel - for this unit (target), which jars are declared directly, and which ones are declared indirectly (transitively)
Then it simply alerts on all loaded jars that are in the indirect category.
We would like to change the dependency analysis to work on the AST itself, which should mitigate the two disadvantages I described above
@ittaiz, anything you would like to add?

over-approximation of actually used jars (due to compiler's aggressive loading)

Is this just a guess or do you have data to back up that the loading is too agressive? I know for sure that the compiler is aggresive on loading symbols from the Java namespace (because of macros), but I think this is not the case for libraries code.
In any case, if you want to avoid that, you need to improve the class loaders in the compiler. If you try to remove from the classpath things that would be loaded by the compiler, wouldn't compilation fail? I guess I'll need more details on this topic to be able to make an educated guess of what's going on.

On over-approximation:
I've also heard of macros causing this, and also on transitive dependencies introduced by traits for example. but haven't seen any concrete example by myself. maybe @gkossakowski can shed more light here on the motivation.

I don't think compilation will fail, because the fixes that will be introduced by strict deps adherence will not remove any dependency from the transitive closure. just add jars to be direct deps.
on the other hand this could happen for unused deps feature.

Regarding lack of mapping between jar and source code disadvantage, what I mean is that the current solution that exists in rules_scala that aggregates all loaded jars does not have any fine grained source code data for the error shown to the user. e.g. (from bazel's java strict deps):

A.java:6: error: [strict] Using type C from an indirect dependency (TOOL_INFO: "//:C"). See command below **
  C getC() {
  ^
** Please add the following dependencies:
  //:C  to //:A

I don't think compilation will fail, because the fixes that will be introduced by strict deps adherence will not remove any dependency from the transitive closure. just add jars to be direct deps. on the other hand this could happen for unused deps feature.

I think the fix in https://github.com/scalacenter/classpath-shrinker tells you everything that was loaded intentionally by the compiler for a given compilation unit; if you try to be smarter and remove some of the symbols that were loaded, without changing the compiler, I would expect the symbol loaders in the compiler to fail compilation. (I'm not an expert in this area, so take my word with a pinch of salt, I'm just trying to provide useful information in this discussion. I suggest you have concrete examples to work on and you prove that there is too much unnecessary loading going on and that you can avoid it by removing the jars from the classpath.)

rules_scala that aggregates all loaded jars does not have any fine grained source code data for the error shown to the user

Aha, I see. Have you looked into other ways of getting that information that does not require adding this decoupling? I think doing this is a good idea, not only for your use case in general but for other tools like scala-sculpt, but I suspect you may be better off getting that information alone in another way.

This has been sitting in the queue for quite a while. Let's reopen if activity in the code or the comments restarts :smile:


Fix documents' links to .md

Fix #1044 - Replace the links in the doc/src/*.md with links to .md file.

Thanks for the PR, but I think this will break the compiled documentation output. From a comment of mine in issue #1044:

This links to .html files are expected. Otherwise, the compiled/published documentation wouldn't work correctly, as Pandoc doesn't know to convert, say, a link to compiler.md to compiler.html during the documentation build.
If you know a way to have Pandoc do this conversion, we'd be happy to integrate that so that the links work both from the documentation source code (the .md files) and the published output (the .html files).

Thanks @chwarr, closing the PR.


Update test: application -> use() should throw if not a function

Missing for 100% coverage.

linting failed

Yep, sorry :/

+1, just needs a rebase

Do not merge :)
as require('should') is not required using the following syntax:
(() => app.use('not a function')).should.throw('middleware must be a function!');

I'll update it soon sorry.

ok it's cleaner now

perfect! just needs a rebase and it's good to merge

:tada: for 100%!

:beer: !
We have now to keep it with async tests :wink:


aimbot broken if backtrack is off

Fedoraware Version Date:
Config used:

Description:

Steps to reproduce:

[ ] I am able to consistently reproduce this error

Steps to reproduce the behavior:

Enable X
Do Y
Notice Z

Additional context

[ ] I have included the steps to reproduce to the best I am able to share.

shit i forgot to write anything

is this with the main branch?

nah just this one


[ENHANCEMENT] Dev Builds on Github or Jenkins

So I was wondering if we could get dev builds because, we might want to test them out. This could possibly help this mod. And I love this mod btw

As of right now all the dev builds have been going on curse (which is why there's a new release every day or two), but yeah, I am in the process of getting a build server to host dev builds on, setup has just been taking a bit of time.

Nice to know :) , but when is the next major release (that adds blocks or items)

@dmodoomsirius will be working on this issue

that i will. I need to get everything set up on my end then it will be easy to do.

http://<IP_ADDRESS>:8080/


Added print to print the branchowner name

Purpose of Pull Request:
Checks:

[x] Tested on simulation
[x ] Tested on hardware
[ ] Added docstrings to the code
[ ] Made necessary changes to dependencies
[ ] Added changes to installation documentation

New Features:

remco you suck, fix it!


Sound components not cleaned on hotreload

Reported by a community member:
"I attached a entity to the player with a background music on it. It seem that on each hotreload the audio persists.
It checked before create a new entity if it exists with engine.getEntitiesWithComponent("audioComponent"); so the entity is well remove from the engine.
It's annoying bug for dev but it should not occur in prod."
He produced an example snippet to reproduce this:
audioModule.ts.zip
Instructions:
you can start it in the game.ts with     AudioModuleEntity.Init(yourAudioClip);
then you just need to same any file to make a hotreload
Another way is to create a video with triggerbox in front.
Then put your avatar in front and spam hotreload the sound will be duplicate too.
This issue is possibly linked to  #296

Cannot reproduce on SDK7
This issue was created referencing an SDK6 example, I tried reproducing this on SDK7 and it's not a problem


STAR Selection: Result predictable order of columns

When all fields of Firestore documents selected using STAR selection (select * from users), the order of columns resulted is not always same.
This is because when STAR selected, FireQL don't explicitly request column selections to get all fields of Firestore collection and uses data returned by Firestore.DocumentSnapshot which is a map field and value pair where order of key is not always same.
One way to return the same columns always would be by sorting columns (map keys) returned by DocumentSnapshot.Data

does it mean we need to sort the columns (selectedColumns) before exiting this if-else statement select.go#L109?
if starIdx != -1 {
    ...
        }
        starIdx++
    }
    // TODO: Sort selectedColumns before exiting this if-else statement
}

Hi @rafiramadhana thanks a lot for your interest in this project.
Sorting selectedColumns would possibly change the position of other selected columns along with *. For example select user_id, *, account_id from users should list user_id first and account_id last in resulted columns and remaining all columns in order in place of *.
You could possible collect all fields from data and sort then add it to selectedColumns rather than adding it on-the-fly.

@pgollangi i see, to spawn a mocked firestore in local, is it enough by doing these steps?

Run gcloud beta emulators
Populate the collection using data/users.json

btw is there any UI/CLI app to interact with the mocked firestore? like seeing data, adding collection, etc

@rafiramadhana yes thats right. I generally follow programatical way of manage firestore data, I found it easy. however there are many open-source and commercial tools to connect firestore.


Fix CSS colors for the inputs on popup modals

Basically, this screenshot should explain everything, I guess.

Context: I tried to boost this post and saw that input in popup is colored incorrectly.

so you can use background color and add !important so it override any previews styles
input{
background-color : #D3D3D3 !important;
}

Ah, this is caused by a change in Mastodon v4.2.0.
Will fix this, thanks!


"Display WSL distro information as JSON form into stdout has stopped working"

I just installed the latest version of WSLManager and this is the pop up I get when I try to run it. Windows 10 with latest updates.

It doesn't work anymore because of the COM interface has been changed. I've got a patch to fix that: https://github.com/Biswa96/WslReverse/issues/1

@mgurevin Thanks to the suggestion. Yes, you are correct.
Currently, I'm not maintaining this repository due to the incompatibility issues between each Windows 10 release, as you may already know.
I will update the readme to prevent any further misunderstanding. Sorry for the late response. 🙏


Fix replication error that occurs when following kubernetes tutorial

When currently running the Kubernetes tutorial, you get:
Error received from Stream rpc error: code = 2 desc = newKeyspaceIDResolverFactory failed: ShardingColumnName needs to be set for a v2 sharding key for keyspace test_keyspace.  This fix make the example use v3 resharding, by default, so that it works with the tutorial instruction vschema.

I tried signing the CLA, it looks like it's not coming through, any tips?

LGTM


BR: Make topology reload transactional

When reloading the topology, either all changes shall be successful or no changes must be done at all.
Currently, the BR closes sockets before creating new ones, possibly leading to an unwanted state of the BR when the socket creation fails later on.
PR #2252 adopts this specific issue, but we should design proper transactional behavior of topology reloading.

This approach does not support reusing the same ip+port on a different interface on a single step, given that the old sockets are kept open until the new configuration succeeds .
To avoid such restriction, socket should be open using SO_REUSEADDR, thus being able to have multiple sockets open for the same ip+port.

According to https://stackoverflow.com/a/14388707 SO_REUSEPORT is what we want.

Setting SO_REUSEPORT must be done before binding the socket.
Support to do so has only been recently added to go (https://github.com/golang/go/commit/3c4d3bdd3b454ef45ce00559d705fe5dc6f57cad)


make xee compatible with rioxarray

when dealing with rasters represented as xarray datasets, rioxarray have proven to be extremely useful to perform all sort of enoying tasks like reproject, window reading, parralalesiation, plottting etc...
It shine with a vibrant community and I don't see any reason to reinvent the wheel here.
As rioxarray is a xarray extention, it's automatically loaded upon import. The only limitation to use it is to make sure that datasets generated by xee have all the metadata required by GDAL and rio to perform their magic.
Do you think it would make sense ? Happy to propose a PR in this direction.

I’m not so familiar with rioxarray. What metadata is required to be compatible with GDAL? Could you show me a (mock) code example where the two libraries would interact? I don’t understand what problem for the user that this solves where there isn’t a solution today. I’m not saying there isn’t a problem, I simply don’t know. Like, isn’t it a good thing that we don’t have to interface with GDAL client-side?

TBH once I started using rasterio in a Python environment, GDAL stopped being an issue as the compilation is maintained and managed by rasterio wheel itself (the consequence is of course a very big wheel but you know the omelet, the eggs....).
I have multiple use cases that requires lots of extra work when they are literally one-liner within rioxarray.
The biggest challenges being reprojection, plotting and histogram matching.
I'll try to make you a small reproducible example during the the geo4good hackathon.

I’m warming up to this feature having seen more of how folks use Xee. I wrote a note on user expectations here:
https://github.com/google/Xee/issues/45#issuecomment-2372747409
Maybe it’s my first time experiencing “the death of the author.” :)

And I look forward to your prototype!


Is the new PHP file working?

I'm trying to deploy with the latest version and I'm getting this error
Serverless: Invoke invoke
{
    "errorMessage": "Process error code 1: ",
    "errorType": "Error",
    "stackTrace": [
        "ChildProcess.<anonymous> (/var/task/handler.js:47:23)",
        "emitTwo (events.js:106:13)",
        "ChildProcess.emit (events.js:191:7)",
        "maybeClose (internal/child_process.js:886:16)",
        "Process.ChildProcess._handle.onexit (internal/child_process.js:226:5)"
    ]
}

  Error --------------------------------------------------

  Invoked function failed

     For debugging logs, run again after setting the "SLS_DEBUG=*" environment variable.

  Stack Trace --------------------------------------------

This is a fresh install (no modifications).
Anybody else facing this problem with the latest version? Is this because of the new PHP file (earlier it was working fine).

Hi @san-kumar
I've just rerun through the steps in the README and its working fine, although there is one more step you need to do to get it working, which #3 was opened to attempt to address (albeit not very clearly!)
For one reason or another, serverless install doesn't seem to play nice with git lfs and as such the PHP binary doesn't actually download properly.  To work around this, after doing serverless install you need to rebuild the PHP binary:
sh buildphp.sh

This does need docker installed, though.
Another option is to clone the repository directly from GitHub instead of using serverless.  As long as you have git lfs installed it will download the PHP binary properly.
The final option is to use a combination of the two - use serverless install as directed and then simply download the PHP binary from GitHub.
I'll get on with addressing #3 to avoid others suffering with similar problems in the future!
If the above doesn't work, please provide a little more information on the steps you've run and I'll try to help debug.

Hi Andy,
Thanks for the reply. I'm using Windows 10 so maybe that is causing the problem. I did everythinga as per the readme and then downloaded the php binary directly from github. It still won't work. Anyway, here are the steps I did:
C:\tmp\2\>serverless install --url https://github.com/araines/serverless-php

C:\tmp\2\serverless-php>wget -O php https://media.githubusercontent.com/media/araines/serverless-php/master/php

C:\tmp\2\serverless-php>sls deploy

C:\tmp\2\serverless-php>serverless invoke -f hello
{
    "errorMessage": "RequestId: 55e45e30-eafb-11e7-b724-b19b0d130fcb Process exited before completing request"
}

  Error --------------------------------------------------

  Invoked function failed

     For debugging logs, run again after setting the "SLS_DEBUG=*" environment variable.

  Get Support --------------------------------------------
     Docs:          docs.serverless.com
     Bugs:          github.com/serverless/serverless/issues
     Forums:        forum.serverless.com
     Chat:          gitter.im/serverless/serverless

  Your Environment Information -----------------------------
     OS:                     win32
     Node Version:           8.9.1
     Serverless Version:     1.25.0

Attached is the Cloudwatch log (if it is of any help)
cloudwatch-log.txt

Oh thats really interesting - I'm a little surprised you're having problems on the Lambda environment itself - thats the bit which I'd expect to be unaffected by your local operating system!
However, I'm wondering if its do to with executable flags on the PHP binary.  Looking at the Cloudwatch logs, it looks like spawn EACCES is the error being thrown - which I believe is thrown when its not able to execute a binary.
I'm afraid I'm not anything close to a Windows expert - for macOS/linux I'd do something like this to the PHP binary before doing sls deploy again:
chmod a+x php

I wonder if there is some form of equivalent for Windows?


s6 natpmp service broken

linuxserver-mod moved to s6 v3, so older (deprecated) s6 v2 mods are ignored (read: get deleted).
So etc/services.d/natpmp needs to be migrated to something like etc/s6-overlay/s6-rc.d/svc-natpmp/run

You are right, this mod is currently obsolete. I have currently no plan for upgrading it to be a S6v3 compatible mod. I am unsure if I will get the time to do it promptly or not.
Nonetheless PR are accepted and it might be more easy for me to find time to test it than to update it from scratch.


Clang-tidy Action Version

PX4 is using clang-tidy 6.0 for static analysis for their GitHub actions. It is 11 versions behind the latest version of clang-tidy 13.0. However, the release time difference between 6.0 and 13.0 is only two years. Still, we should figure out why they are using 6.0 instead of keeping upstream with the latest versions.

[x] Ask Daniel why they are using clang-tidy 6.0 instead of keeping up with the upstream version release.

No response from Daniel on Slack, will follow up with email to try different communication medium.

Daniel Reply on Slack:

the checks are locked down so that they cause the build to fail
so that we can ratchet it up over time
between versions there are new things introduced and new things found, etc
periodically it should be bumped, then corresponding px4 updated (violations fixed or explicitly ignored)

I think this has just been put on the back burner for more pressing px4 issues. Just documenting the response if we are asked down the line.


Localizations added

This PR consolidates the following:

added a string file instance using which we can add and apply Localizations
please go through and suggest changes if needed

@tneotia can you please take a look at this

Please remove idea directory, thanks :)
I also don't think all the strings got translated in this, for example choose a color is not.

@tneotia all string must be translated yes, its is very needed.
@PJ7536 good pr

@tneotia can you please take a look at this added the remaining strings and deleted .idea directory


Fix build warnings related to use of experimental features

This pull request shows one possible way to address the warnings produced by the use of [Obsolete] as a marker for experimental features. This change was originally part of #227, but was removed from that PR before it was merged.
(Submitting a pull request so it can be referenced from another discussion.)

Codecov Report

Merging #293 into master will increase coverage by <.01%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master     #293      +/-   ##
==========================================
+ Coverage   24.35%   24.36%   +<.01%
==========================================
  Files         199      199
  Lines      112479   112495      +16
  Branches    11228    11238      +10
==========================================
+ Hits        27397    27410      +13
+ Misses      85055    85052       -3
- Partials       27       33       +6

Flag
Coverage Δ

#2015
24.36% <0%> (ø)
:arrow_up:

#2017
24.35% <0%> (-0.01%)
:arrow_down:

#Debug
15.82% <0%> (ø)
:arrow_up:

#Release
14.89% <0%> (-0.01%)
:arrow_down:

Impacted Files
Coverage Δ

src/PerfView/memory/PdbScopeMemoryGraph.cs
18.22% <ø> (ø)
:arrow_up:

src/PerfView/Extensibility.cs
12.88% <ø> (ø)
:arrow_up:

src/PerfView/PerfViewData.cs
17.43% <ø> (ø)
:arrow_up:

src/PerfView/HeapView/GcInfoView.cs
9.15% <ø> (ø)
:arrow_up:

src/PerfView/JitStats.cs
11.11% <0%> (-0.07%)
:arrow_down:

src/PerfView/GcStats.cs
11.05% <0%> (-0.12%)
:arrow_down:

src/PerfView/HeapView/HeapDiagram.cs
11.36% <0%> (-0.03%)
:arrow_down:

.../PerfView/GuiUtilities/StatusBar/StatusBar.xaml.cs
68.15% <0%> (+2.38%)
:arrow_up:

src/PerfView/Utilities/ExceptionMessage.cs
40% <0%> (+33.33%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0febfab...ace1271. Read the comment docs.


JS SDK - Dynamic Typeahead in Input.ChoiceSet

The PR covers code changes to add Dynamic Type Ahead support to Input.ChoiceSet in adaptive cards in JS SDK.
Feature Details/Design:
https://microsoftapc-my.sharepoint.com/:w:/g/personal/suprabhat_microsoft_com/EZ9Hhv0Gls5OlxxH02r47LIBH3Xp-mRlnwlYXvr30NmN9g?e=s5awDy
UX for the feature:

Default State of the Input.ChoiceSet

On-hover/Click mouse experience.

https://user-images.githubusercontent.com/39309315/218469337-39d460e7-4145-471c-ab0c-cb3c2043b472.mp4

Dropdown navigation/Enter via arrow keys.

https://user-images.githubusercontent.com/39309315/218469445-00f80cac-7433-4332-9502-6c6555654274.mp4

Loading Experience when there are no static choices or choices do not match the filter.

Loading Experience when there are static choices and they do match the filter.

Error experience when the Data.Query request returns an error response.

Error experience when there are no results matching the filter.

@dclaux  Can you please take a look?

Hi @SuryanshPrabhat,
Can you add samples to this folder: https://github.com/microsoft/AdaptiveCards/tree/main/samples/v1.6/Elements, and also include some gifs/videos of this working in your PR?

Sure @anna-dingler
Thanks for pointing it out. I've done the same.


Create .nginx.conf

The config looks fine, but I'm not merging anything into master anymore – could you submit it against the v3.0.0 branch please? Thanks so much for adding this!

Here it is #236.