TB Arch

I checked on the TB arch doc and I have few points to make:

There is no DUT in this project
The write and read agents are inappropriate here. The master can be either in transmit mode(write) or in receive mode(read). Ideally, it should be the master agent and slave agent  connected back-to-back

The new TB arch is amazing! I could see the ambitious work of adding virtual sequencer and virtual sequences, which is good initiative. Keep up the good work 👍
I have few points to make:

Name the master and slave agents as, master I2C agent and slave I2c agent as this TB arch is for I2C project.
The static interface is missing from the diagram. The static interface is instantiated in the top_module and then the virtual interface(pointer) is used inside the ENV.

Please incorporate these changes.

Hi Muneeb,
Thank you for reviewing the testbench architecture, I appreciate the time
and efforts you are putting to review the pulpino soc project. I'll try to
update the TB architecture and include the features you suggested.
Thanks and Regards,
Sweta Basavaraj.
On Thu, May 30, 2019 at 12:36 AM Muneeb Ulla Shariff <
<EMAIL_ADDRESS>wrote:

The new TB arch is amazing! I could see the ambitious work of adding
virtual sequencer and virtual sequences, which is good initiative. Keep up
the good work 👍
I have few points to make:

Name the master and slave agents as, master I2C agent and slave I2c
agent as this TB arch is for I2C project.
The static interface is missing from the diagram. The static
interface is instantiated in the top_module and then the virtual
interface(pointer) is used inside the ENV.

Please incorporate these changes.
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
https://github.com/muneebullashariff/i2c_vip/issues/1?email_source=notifications&email_token=AGAORYSBJH275E2JEFJAUMDPX57XHA5CNFSM4HOHSG42YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODWRTTKI#issuecomment-497236393,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AGAORYT75FIECPW2AVEOM4LPX57XHANCNFSM4HOHSG4Q
.


WIP: Testing dev builds on travis

It's not super useful to have dev builds on the public anaconda.org.  Closing this until we realize that we do actually need dev builds available on anaconda.org/lightsource2


feat: Navbar fixed when user scrolls

🛠 Fixes Issue
Closes #321

➕ Changes Introduced

Made navbar sticky.
When scrolled decreased navbar height.
Added background color and border to navbar when scrolled.

📄 Note To Reviewers

📷 Screenshots

Hey @ykdojo can you please review this feature I implemented.


Add README.md to the service directory

A new package, service, has been added to the top level of the ciao repo.  This package needs a README.md to be consistent with our other top level packages.

We had an offline discussion on this and we agreed that this was no longer necessary.


Added React.js for beginners to learn

I will also continue to add more and more files to the folder.

Great Work


fixing integration tests

Codecov Report

Merging #46 (8486a24) into main (293d556) will not change coverage.
The diff coverage is 0.00%.

@@          Coverage Diff          @@
##            main     #46   +/-   ##
=====================================
  Coverage   4.24%   4.24%
=====================================
  Files         13      13
  Lines       1249    1249
=====================================
  Hits          53      53
  Misses      1196    1196

Impacted Files
Coverage Δ

storage.go
0.00% <0.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Add visibility to the button "Show completed tasks"

Hi,
To improve the visibility of the button "Show completed tasks", you can use this icon :
http://fortawesome.github.io/Font-Awesome/icon/eye/
Otherwise, you can add a message like : "You have nothing to do, maybe you want to show your completed tasks ?" when no task in shown and remove the header of the table.

done !


ClassPathScanner scans entire executable jar

In an application packaged as an executable jar, create a SessionFactory with new SessionFactory(config, "some.package").
Expected behavior: ClassPathScanner scans some.package (2 classes)
Current behavior: ClassPathScanner scans the entire jar (~44,000 classes)
Consequences: significantly increased application startup time

OGM Version used: 2.1.2
Java Version used: Java(TM) SE Runtime Environment (build 1.8.0_121-b13)
Neo4J Version used: 3.1.3
Bolt Driver Version used (if applicable): embedded
Operating System and Version: Ubuntu 16.04

The delay is caused by excessive logging, not the scanning itself.


People can upload data easily (and we don't store it)

Summary
Provide publishers with an easy solution to drag & drop some files during publish flow and in background they are added to decentralized storage. But where we don't store it or pay for storage.
Motivation
Status quo: publishers must a provide url for their data, which takes technical savvy. Removing this friction will help adoption.
In Ocean Commons, we had where people could "upload to IPFS" for a smoother flow. They would drag and drop the file, and it would get uploaded. However since IPFS does not do storage, we were actually doing the storage on Pacific nodes. This is not a good idea because then we inadvertently start hosting a ton of files for free.
Target outcome

have a GUI / UX similar to what we had in Ocean Commons
but store somewhere that we don't have to pay for.

Where to store

Recommended: Arweave - pay once, store forever
(Backup: Filecoin - pay once, store for a long time)
IPFS could still be used as the intermediary ("IPFS pinning"). Data would be encrypted.

Our team is working on this! As mentioned in our recent issue/PR, overhead is still a challenge. There may be some ways to decrease overhead but will require a bit of engineering + experimentation https://github.com/oceanprotocol/market/issues/1483
https://port.oceanprotocol.com/t/project-coral-core-tech-improvement-desci-oceandao-berlin-hackathon-round-17/1824

our recent issue/PR

To be clear, that's an issue. And it's fine as an issue right now. A PR will be needed at some point though.

As a reminder cause it's mentioned in this issue's description as a goal. This is how the file form field looked in Commons:

"From URL" revealed the URL text input, "Add to IPFS" opened up a drag & drop field, dropping a file was sending this to our own IPFS node's API and we pinned it there. App then receives back the new IPFS URL and uses that as the final file URL.

We have other issues that handle this in a more direct way


[turborepo] DevDependencies not installed using yarn on vercel

What version of Turborepo are you using?
latest
What package manager are you using / does the bug impact?
Yarn v2/v3 (node_modules linker only)
What operating system are you using?
Mac
Describe the Bug
I have an issue since more than a week about deploying my nextjs app on vercel using yarn.
I am using a standard turborepo setup forked from this repository:
https://github.com/aaron5670/webshop-starter/tree/main

I add my nextjs repo under apps/store and install my deps via yarn install
I then build my app using turbo run build locally. So far so good.
When I deploy my app to vercel weird stuff is going on though:

a) I have left the install on vercel to the default using yarn install. It works fine.
b) The build command is cd ../.. && turbo run build --filter={apps/store}.... This is where things start to get funky:
I consistently get build errors around certain packages and basic dependencies not found:
info  - Linting and checking validity of types...
It looks like you're trying to use TypeScript but do not have the required package(s) installed.
Please install typescript by running:
    yarn add --dev typescript
If you are not trying to use TypeScript, please remove the tsconfig.json file from your package root (and any TypeScript files in your pages directory).

Obviously typescript should be installed.
This is my package.json at the root:
{
  "name": "webshop-starter",
  "version": "0.0.0",
  "private": true,
  "workspaces": [
    "apps/*",
    "packages/*"
  ],
  "scripts": {
    "build": "turbo run build",
    "dev": "turbo run dev",
    "lint": "turbo run lint",
    "format": "prettier --write \"**/*.{ts,tsx,md}\""
  },
  "devDependencies": {
    "eslint-config-custom": "*",
    "prettier": "latest",
    "turbo": "latest",
  },
  "engines": {
    "node": ">=14.0.0"
  },
  "dependencies": {},
  "packageManager"<EMAIL_ADDRESS>}

and then my package.json on the apps/store level:
{
  "name": "medusa-next",
  "version": "1.0.3",
  "private": true,
  "description": "Next.js starter to be used with Medusa server",
  "keywords": [
    "medusa-storefront"
  ],
  "scripts": {
    "dev": "next dev -p 8000",
    "build": "next build",
    "start": "next start -p 8000",
    "lint": "next lint",
    "cypress": "cypress open",
    "analyze": "ANALYZE=true next build",
    "test": "jest --watch",
    "postbuild": "next-sitemap"
  },
  "resolutions": {
    "webpack": "^5"
  },
  "dependencies": {
    "@calcom/embed-react": "^1.0.10",
    "@headlessui/react": "^1.7.5",
    "@heroicons/react": "^2.0.13",
    "@hookform/error-message": "^2.0.0",
    "@medusajs/medusa": "1.7.8",
    "@medusajs/medusa-js": "^1.3.3",
    "@meilisearch/instant-meilisearch": "^0.7.1",
    "@next/font": "^13.1.5",
    "@paypal/paypal-js": "^5.0.6",
    "@paypal/react-paypal-js": "^7.8.1",
    "@react-pdf/font": "^2.3.1",
    "@react-pdf/renderer": "^3.0.3",
    "@stripe/react-stripe-js": "^1.7.2",
    "@stripe/stripe-js": "^1.29.0",
    "@supabase/supabase-js": "^2.2.1",
    "@twind/preset-tailwind-forms": "^1.0.3",
    "@vercel/og": "^0.0.27",
    "algoliasearch": "^4.14.2",
    "clsx": "^1.1.1",
    "editorjs-blocks-react-renderer": "^1.3.0",
    "flowbite": "^1.6.2",
    "flowbite-react": "^0.3.7",
    "fontkit": "^2.0.2",
    "heroicons-react": "^1.4.1",
    "i18n-iso-countries": "^7.5.0",
    "js-cookie": "^3.0.1",
    "lodash": "^4.17.21",
    "medusa-react": "^3.0.1",
    "meilisearch": "^0.30.0",
    "next": "^13.0.6",
    "next-seo": "^5.15.0",
    "next-sitemap": "^4.0.5",
    "react": "^18.2.0",
    "react-copy-to-clipboard": "^5.1.0",
    "react-country-flag": "^3.0.2",
    "react-dom": "^18.2.0",
    "react-hook-form": "^7.30.0",
    "react-instantsearch-hooks-web": "^6.29.0",
    "react-intersection-observer": "^9.3.4",
    "react-pdf-tailwind": "^1.0.1",
    "react-query": "^3.34.16",
    "sharp": "^0.30.7",
    "swr": "^2.0.0",
    "tailwind-scrollbar-hide": "^1.1.7",
    "uuid": "^9.0.0",
    "webfontloader": "^1.6.28"
  },
  "devDependencies": {
    "@babel/core": "^7.17.5",
    "@tailwindcss/aspect-ratio": "^0.4.2",
    "@tailwindcss/forms": "^0.5.3",
    "@tailwindcss/line-clamp": "^0.4.2",
    "@tailwindcss/typography": "^0.5.8",
    "@testing-library/jest-dom": "^5.16.5",
    "@testing-library/react": "^14.0.0",
    "@types/fontkit": "^2.0.1",
    "@types/js-cookie": "^3.0.3",
    "@types/node": "17.0.21",
    "@types/react-copy-to-clipboard": "^5.0.4",
    "@types/react-instantsearch-dom": "^6.12.3",
    "@types/uuid": "^9.0.1",
    "autoprefixer": "^10.4.13",
    "babel-loader": "^8.2.3",
    "cypress": "^9.5.2",
    "eslint": "8.10.0",
    "eslint-config-next": "^13.0.6",
    "jest": "^29.4.3",
    "jest-environment-jsdom": "^29.4.3",
    "lato-font": "^3.0.0",
    "msw": "^1.1.0",
    "postcss": "^8.4.19",
    "sitemap": "^7.1.1",
    "tailwind-scrollbar": "^3.0.0",
    "tailwindcss": "^3.2.4",
    "typescript": "4.6.2"
  }
}

My tsconfig on the apps/store:
{
  "compilerOptions": {
    "target": "es5",
    "lib": ["dom", "dom.iterable", "esnext"],
    "allowJs": true,
    "skipLibCheck": true,
    "strict": true,
    "forceConsistentCasingInFileNames": true,
    "noEmit": true,
    "esModuleInterop": true,
    "module": "esnext",
    "moduleResolution": "node",
    "resolveJsonModule": true,
    "isolatedModules": true,
    "jsx": "preserve",
    "incremental": true,
    "types": ["cypress", "jest",  "@testing-library/jest-dom"],
    "baseUrl": "./src",
    "paths": {
      "@lib/*": ["lib/*"],
      "@modules/*": ["modules/*"],
      "@pages/*": ["pages/*"],
    }
  },
  "include": [
    "next-env.d.ts",
    "**/*.ts",
    "**/*.tsx",
    "cypress/support/index.js",
    "cypress/support/commands.js",
    "cypress/integration/product.spec.js",
    "cypress/plugins/index.js",
  ],
  "exclude": [
    "node_modules",
    ".next",
    ".nyc_output",
    "cypress-coverage",
    "coverage",
    "jest-coverage"
  ]
}

We would really appreciate any kind of help, this has been an issue for more than a week now and I really do not understand what is causing the issue here.
It seems that my dependencies are not properly installed or that my vercel build command is off not recognizsing the correct node_modules folder.
Expected Behavior
I would expect the build command to succeed on vercel
To Reproduce
Clone this repository and deploy to vercel: https://github.com/aaron5670/webshop-starter/tree/main
Reproduction Repo
https://github.com/aaron5670/webshop-starter/tree/main

The issue seems to be related to devDependencies. Whenever I add the missing package (e.g. typescript) to the regular dependencies it works for that package. It then throws the next error:
medusa-next:build: Type error: Could not find a declaration file for module 'js-cookie'. '/vercel/path0/node_modules/js-cookie/index.js' implicitly has an 'any' type.

If I then go ahead and add @types/js-cookie to the actual dependencies, not the dev dependencies it gets installed and works, e.g. it complains about the next type declaration file it is missing. However, they are all there in devDependencies.
I am sure I am just missing a tiny detail in my setup but I would really appreciate some help to fix this and the deployments running. Thanks

Isn't the whole point of devDependencies that they get installed in a development environment, and not in production, such as on vercel?

This is expected behavior of yarn when operating in a production context (docs). Do you have NODE_ENV set to production by chance? That's one thing that will alter this behavior of yarn.
If you do need dev deps installed at build time on vercel you can override this by passing an arg to yarn on install (--prod=false).


Use nightly toolchain in docker

Testauskoira is developed on the nigthly toolchain, so this is a timebomb that needs fixing.

I fully agree with this. Have you tested whether it builds?

no

Feature gates will be used in the future with high probability.


Is there Python 3 support?

An attempt to pip install this solution
(File "/usr/local/bin/pip", line 9, in <module>
  load_entry_point('pip==1.5.6', 'console_scripts', 'pip')()
File "/usr/local/lib/python2.7/dist-packages/setuptools-7.0-py2.7.egg/pkg_resources.py", line 339, in load_entry_point
  return get_distribution(dist).load_entry_point(group, name)
File "/usr/local/lib/python2.7/dist-packages/setuptools-7.0-py2.7.egg/pkg_resources.py", line 2470, in load_entry_point
  return ep.load()
File "/usr/local/lib/python2.7/dist-packages/setuptools-7.0-py2.7.egg/pkg_resources.py", line 2184, in load
  ['__name__'])
File "/usr/local/lib/python2.7/dist-packages/pip-1.5.6-py2.7.egg/pip/__init__.py", line 11, in <module>
  from pip.vcs import git, mercurial, subversion, bazaar  # noqa
File "/usr/local/lib/python2.7/dist-packages/pip-1.5.6-py2.7.egg/pip/vcs/mercurial.py", line 9, in <module>
  from pip.download import path_to_url
File "/usr/local/lib/python2.7/dist-packages/pip-1.5.6-py2.7.egg/pip/download.py", line 22, in <module>
  from pip._vendor import requests, six
File "/usr/local/lib/python2.7/dist-packages/pip-1.5.6-py2.7.egg/pip/_vendor/requests/__init__.py", line 53, in <module>
  from .packages.urllib3.contrib import pyopenssl
File "/usr/local/lib/python2.7/dist-packages/pip-1.5.6-py2.7.egg/pip/_vendor/requests/packages/urllib3/contrib/pyopenssl.py", line 70, in <module>
  ssl.PROTOCOL_SSLv3: OpenSSL.SSL.SSLv3_METHOD,
AttributeError: 'module' object has no attribute 'PROTOCOL_SSLv3'
(env3)sashko@tato-LIFEBOOK-SH531-GFX:~/a/python/placenta-preeclampsia$ sudo pip install git+https://github.com/CrossWaterBridge/django-grappelli-autocomplete-fk-edit-link.git@master#egg=django-grappelli-autocomplete-fk-edit-link
[sudo] password for sashko:
Traceback (most recent call last):
File "/usr/local/bin/pip", line 9, in <module>
  load_entry_point('pip==1.5.6', 'console_scripts', 'pip')()
File "/usr/local/lib/python2.7/dist-packages/setuptools-7.0-py2.7.egg/pkg_resources.py", line 339, in load_entry_point
  return get_distribution(dist).load_entry_point(group, name)
File "/usr/local/lib/python2.7/dist-packages/setuptools-7.0-py2.7.egg/pkg_resources.py", line 2470, in load_entry_point
  return ep.load()
File "/usr/local/lib/python2.7/dist-packages/setuptools-7.0-py2.7.egg/pkg_resources.py", line 2184, in load
  ['__name__'])
File "/usr/local/lib/python2.7/dist-packages/pip-1.5.6-py2.7.egg/pip/__init__.py", line 11, in <module>
  from pip.vcs import git, mercurial, subversion, bazaar  # noqa
File "/usr/local/lib/python2.7/dist-packages/pip-1.5.6-py2.7.egg/pip/vcs/mercurial.py", line 9, in <module>
  from pip.download import path_to_url
File "/usr/local/lib/python2.7/dist-packages/pip-1.5.6-py2.7.egg/pip/download.py", line 22, in <module>
  from pip._vendor import requests, six
File "/usr/local/lib/python2.7/dist-packages/pip-1.5.6-py2.7.egg/pip/_vendor/requests/__init__.py", line 53, in <module>
  from .packages.urllib3.contrib import pyopenssl
File "/usr/local/lib/python2.7/dist-packages/pip-1.5.6-py2.7.egg/pip/_vendor/requests/packages/urllib3/contrib/pyopenssl.py", line 70, in <module>
  ssl.PROTOCOL_SSLv3: OpenSSL.SSL.SSLv3_METHOD,
AttributeError: 'module' object has no attribute 'PROTOCOL_SSLv3'
(env3)sashko@tato-LIFEBOOK-SH531-GFX:~/a/python/placenta-preeclampsia$ sudo pip install https://github.com/CrossWaterBridge/django-grappelli-autocomplete-fk-edit-link.git@master#egg=django-grappelli-autocomplete-fk-edit-link
Traceback (most recent call last):
File "/usr/local/bin/pip", line 9, in <module>
  load_entry_point('pip==1.5.6', 'console_scripts', 'pip')()
File "/usr/local/lib/python2.7/dist-packages/setuptools-7.0-py2.7.egg/pkg_resources.py", line 339, in load_entry_point
  return get_distribution(dist).load_entry_point(group, name)
File "/usr/local/lib/python2.7/dist-packages/setuptools-7.0-py2.7.egg/pkg_resources.py", line 2470, in load_entry_point
  return ep.load()
File "/usr/local/lib/python2.7/dist-packages/setuptools-7.0-py2.7.egg/pkg_resources.py", line 2184, in load
  ['__name__'])
File "/usr/local/lib/python2.7/dist-packages/pip-1.5.6-py2.7.egg/pip/__init__.py", line 11, in <module>
  from pip.vcs import git, mercurial, subversion, bazaar  # noqa
File "/usr/local/lib/python2.7/dist-packages/pip-1.5.6-py2.7.egg/pip/vcs/mercurial.py", line 9, in <module>
  from pip.download import path_to_url
File "/usr/local/lib/python2.7/dist-packages/pip-1.5.6-py2.7.egg/pip/download.py", line 22, in <module>
  from pip._vendor import requests, six
File "/usr/local/lib/python2.7/dist-packages/pip-1.5.6-py2.7.egg/pip/_vendor/requests/__init__.py", line 53, in <module>
  from .packages.urllib3.contrib import pyopenssl
File "/usr/local/lib/python2.7/dist-packages/pip-1.5.6-py2.7.egg/pip/_vendor/requests/packages/urllib3/contrib/pyopenssl.py", line 70, in <module>
  ssl.PROTOCOL_SSLv3: OpenSSL.SSL.SSLv3_METHOD,
AttributeError: 'module' object has no attribute 'PROTOCOL_SSLv3')

It appears to lack Python 3 support but may be something else.

Based on those stack traces it looks like you're using Python 2.7


Add Smooth Scrolling to Flet Windows App

Problem To Be Solved
Currently, when using the drag scroll bar in Flet, the scrolling behavior is smooth and provides a good user experience. However, when scrolling by other means, the experience is not smooth, leading to a less than optimal user experience.
In-Scope
Implement smooth scrolling for Flet when using methods other than the drag scroll bar. It is important to note that this issue is specific to the Windows app, and the web app is not affected by this behavior.

+1

Please share a visual output of the scrolling issue.

https://github.com/flet-dev/flet/assets/66740223/82141e0c-06b2-4a58-b2d1-ca16e1aabdb7
The mouse wheel scrolling is smooth and can scroll continuously but with the trackpad, scrolling is limited to just a few lines in any one direction per touch, then I have to lift my fingers off of the trackpad and touch it again to scrolling another few lines. This problem doesn't exist on the web app for me as well.

+1

+1
Scrolling one line at a time with touchpad on desktop windows app.
Scroll is ok with mouse wheel (in all cases) or when using webapp

Please give the latest Flet version a try.

Trackpad scrolling works really well. Nice job.


Incorrect name of the target product returned from productNameWithExtension()

Context 🕵♀
As an author of XcodeSelectiveTesting I've been trying to integrate it for fun with Wire-iOS project.
This project has several libraries, amongst those you can find WireCanvas project. This project has a target called WireCanvas that emits a framework.
What 🌱
When parsing WireCanvas project, XcodeProj is returning Canvas.framework from productNameWithExtension(). Correct name of the product is WireCanvas.framework
Proposal 🎉
I tried to fix the issue but was not sure what was causing this behavior. There must be some misconfiguration in the WireCanvas project, but from Xcode side I only see WireCanvas.framework in other project linked frameworks phase and as a product name

@kwridan thanks so much for the reply. This sounds reasonable, adding support for xcconfig resolution might be too big of a feature for a GitHub issue :)
Would it make sense to enhance the documentation for productNameWithExtension() (any other?) method so people using it would have reasonable expectations? I can propose a small change for this if you think this is appropriate.

Sure that sounds like a reasonable change, this contribution would be welcome! thanks @mikeger

@kwridan I created the PR, thanks for your support.


Alarm panel not working (Page 7)

Hello,
i can't activate an alarm in the alarm viewer. If I enter the code and then press arm away or arm home, nothing happens. What am I doing wrong?
My blueprint looks like this:
alias: HASPone p[7].b[all] displays an alarm control panel
description: ''
use_blueprint:
path: HASwitchPlate/hasp_Display_Alarm_Control_page7_new.yaml
input:
b15armservice: alarm_arm_away
haspdevice: be9fd115990418ac490f4dbd6727839e
alarmpanel: alarm_control_panel.alarm
b13armservice: alarm_arm_home
Thanks
Stephan

I am having the same issue. My blueprint yaml

alias: HASPone Plate 2_Alarm_all  displays an alarm control panel
description: ""
use_blueprint:
  path: HASwitchPlate/hasp_Display_Alarm_Control_page7.yaml
  input:
    haspdevice: 9adc68c9e7a5b6aa48de3c3ddc0be4f0
    alarmpanel: alarm_control_panel.ha_alarm
    b13armservice: alarm_arm_away
    b15armservice: alarm_arm_home

I can't replicate this issue.   I am running it with Alarmo (fro HACS) and it works flawlessly for me.
Arm Home and Arm Away both work as does disarm function.......


[Mobile] Top to top button should be a nice to have when going all way to the bottom

from October 2021 pre-launch bug bash
Created by: Laura Marcos
Description
When navigating through napari and going back down, it would save lots of time to user to have a "top to top" button to go back to the top instead of doing all that scrolling
Info
Bug source: unknown
Browser: All in mobile
PR: none
Attachments

With #134 this works. As soon as you start to scroll back up a touch the Back to top appears.


Update top-extensions-install-software.md

The offered NodeJS Tools is not for VS2017 anymore. It's built-in.

Docs Build status updates of commit c04feba:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

portal-sdk/generated/top-extensions-install-software.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

make changes to the /templates/ dir rather then /generated/ dir please


Bug: Form text overlaps when font size is very large

As you can see in the screenshot below, when the font size is set to very large (through settings > accessibility > display & text size > Larger text > turn everything to max) the text overlaps and it is not clear how to interact with the form.

Hi @LouiseBC ,
Thank you for your feedback. I just did a test myself and it works like a charm on my end:

Could you please share the form name and account name by sending an email to<EMAIL_ADDRESS>I can then test further on this for you.
Looking forward to your reply.

Hi @LouiseBC ,
Thanks for sending through your form ID. I did my tests on a campaign where it works. However,  I can confirm this is an issue with the feedback form:
.
This issue originates from the error message fields which can be set up in your Usabilla console:

A ticket has been created for this. If there is anything else we can assist with, please let me know.

Great, thank you!
On Thu, Dec 12, 2019 at 5:09 PM Toralf Kvelland<EMAIL_ADDRESS>wrote:

Hi @LouiseBC https://github.com/LouiseBC ,
Thanks for sending through your form ID. I did my tests on a campaign
where it works. However, I can confirm this is an issue with the feedback
form:
[image: 2019-12-12 at 17 08]
https://user-images.githubusercontent.com/40064170/70728604-0341b780-1d02-11ea-8437-189235143270.png
.
This issue originates from the error message fields which can be set up in
your Usabilla console:
[image: 2019-12-12 at 17 09]
https://user-images.githubusercontent.com/40064170/70728704-31bf9280-1d02-11ea-8fd5-be62d72af9be.png
A ticket has been created for this. If there is anything else we can
assist with, please let me know.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/usabilla/usabilla-u4a-react-native/issues/90?email_source=notifications&email_token=AFCHNHOQ6RTVKDVZZDQH5PLQYJO5HA5CNFSM4JZ3IWZ2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEGXFI6Q#issuecomment-565073018,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AFCHNHKGL3PHOWGCA5JNY5DQYJO5HANCNFSM4JZ3IWZQ
.

--
[ Q42 | 070 44523 52 | https://www.q42.nl http://q42.nl/ | KvK 30164662 ]

Hi @LouiseBC,
Thank you for your patience on this. I'm happy to be able to share that we have fixed this issue in the latest release of our React Native Hybrid SDK. Please upgrade to the latest version of the SDK to implement the fixes on your end as well.
In the new version of our React Native SDK, we also have introduced auto-linking. Based on how our current React Native SDK is installed, this might mean that you will have to install the new SDK differently. In any case, we have included the steps for this in the documentation.
Should you run into any issues, then please feel free to get back in touch.


[Feature] Support for additional variables in configure.sh

Support these variable using configure.sh
ASOUND_FILE_PREFIX
FORCE_PLAYBACK_DEVICE
CREATED_ASOUND_CARD_NAME
Asked in #101

Hello @hv6478, would you give a try to this branch?

Quickly tested it already, it's already merged, but please have a look if you can


code about PrototypicalNet+P&D

I really appreciate your code style!
Would you like to publish the code about PrototypicalNet and PrototypicalNet+P&D ?
Thanks!

Hi - unfortunately, I do not have time to clean up code for prototypicalNet or PrototypicalNet+P&D. Maybe you could ask the authors from the original paper?


Forbidden Lands v1.851

Swap imgur images for polyhedral dice to github.
Further adjustments to try and get the Swedish logo to display properly. It appears this is still a roll20 bug.

Submission Checklist
Required

[ ] The pull request title clearly contains the name of the sheet I am editing.
[ ] The pull request title clearly states the type of change I am submitting (New Sheet/New Feature/Bugfix/etc.).
[ ] The pull request makes changes to files in only one sub-folder.
[ ] The pull request does not contain changes to any json files in the translations folder (translation.json is permitted)

New Sheet Details

The name of this game is: <   >  (i.e. Dungeons & Dragons 5th Edition, The Dresden Files RPG)

The publisher of this game is: <   > (i.e. Wizards of the Coast, Evil Hat)

The name of this game system/family is: <   > (i.e. Dungeons & Dragons, FATE)

[ ] I have followed the Character Sheets Standards when building this sheet.

[ ] This sheet has been made on behalf of, or by, the game's publisher.
[ ] This game is not a traditionally published game, but a copy of the game rules can be purchased/downloaded/found at: <   >
[ ] This sheet is for an unofficial fan game, modification to an existing game, or a homebrew system.

Changes / Description

Character Sheet Info Roll20 Internal Use only.


Hosts search

When running more than 50 hosts, searching is cumbersome. It would be nice to be able to search the host selector. In my case for example, we are shipping logs from Kubernetes with >1000 containers on it, so a search would really help here :)

Added support for search in hosts popup when hosts list is greater than 10. Download latest release @ https://github.com/sivasamyk/logtrail/releases/download/v0.1.23/logtrail-5.6.3-0.1.23.zip


godot 2.1.7 is released for API 29. please consider creating admob Template for this Version

OS target (Android/iOS):
Android API 29 , new secuirty requirement which is Mandatory
Godot version:
2.1.7
Issue description:
Please consider building Template for Admob for Godot 2.1.7 version as it supports API 29

Hello, the version for 2.1 is deprecated, we ask you to use version 3.0 at least
if that is not possible, try to compile through this branch: https://github.com/kloder-games/godot-admob/tree/2.1.X if there is an error please show here that we will try to help you
currently I can't compile on my own for 2.1, sorry


[FEATURE REQUEST]: Communicate Product Ingest Status in UI

Picking up from previous issue: https://github.com/USACE/cumulus/issues/258
Indicate in the UI that a product is beyond it's threshold since last product was processed.

Proposal:

@jeffsuperglide Can you review develop UI and let me know what you think?

Changes in develop merged into stable
PR https://github.com/USACE/cumulus-ui/pull/158


4.17.2

v4.17.2  (November 14, 2024)
Changed

Changed message signing contract from POST to PUT request.

The change log message should be from PUT to POST request 😇 (they are inverted)
Thanks!


Remove Openchain inside  Blockchain/Contribute/    [OTHER]

Which field of community (DevOps/Opensource/Web/Web3/Android/Devrel) you want to add, drop the links?
the website of Openchain is not working , no one maintain any repo
For adding Job Posting, add links here.
No response
For adding OpenSource Projects, add links here.
No response

This is likey something to do with your internet. The OpenChain link works perfectly


docs: update documented version to v0.4

several updates to the docs for the latest release. /cc @ideahitme

:+1:


Tab completion eats up new file name

If I have a template names mytemplate.md and then try to load it using:
:Template myfile<TAB>

what happens is that myfile gets replaced with mytemplate. Notice the missing space after myfile and before <TAB>. I don't know if this is a bug with neovim or this plugin.

you need space after my file.

hmm does myfile exits ? if exist and is current buffer why you input it. Template test.md <TAB> this test.md is not exist then template will create it and open it


Drop series containing a specific value

I have got a series with values equal to 0. Since we decided not to push any value that is 0 in our InfluxDB, I want to clean up this serie and remove the existing values equal to 0. Here is what I did:
> select count(value) from p2p
name: p2p
---------
time      count
1970-01-01T00:00:00Z  286216

> select count(value) from p2p where value=0
name: p2p
---------
time      count
1970-01-01T00:00:00Z  113630

> drop series from p2p where value=0
> select count(value) from p2p where value=0
> select count(value) from p2p
name: p2p
---------
time      count
1970-01-01T00:00:00Z  3

I am surprised that is removed everything (the 3 entries is because the DB get populated at the same time by live clients).
Is the DROP series for a specific value supported?

(i have just updated the main description above)

I believe the WHERE clause for DROP SERIES only operates on tags. For it to work on fields (like value) it would have to scan every point in the series, as field values are unindexed.

Ok thanks for the info.

@simcap I am closing this in favor of another issue open on DROP SERIES (https://github.com/influxdb/influxdb/issues/4276). It appears the WHERE clause is not being properly evaluated

Actually, looking more closely these are two different issues. I'm re-opening this one to focus on the field matching not working. (I don't think it's supposed to work, but it should error or do nothing, not match all points instead.)

It appears that a WHERE clause containing a field key will match every point in the series, regardless:
> SELECT * FROM h2o_feet limit 4
name: h2o_feet
--------------
time				location	status!				water_level
1970-01-01T00:00:01.439856Z	santa_monica	below three feet		2.064
1970-01-01T00:00:01.439856Z	coyote_creek	between six and nine feet	8.12
1970-01-01T00:00:01.43985636Z	coyote_creek	between six and nine feet	8.005
1970-01-01T00:00:01.43985636Z	santa_monica	below three feet		2.116

> drop series from h2o_feet where water_level = 'foo'
> SELECT * FROM h2o_feet limit 4
> SELECT * FROM h2o_feet
>

Note that the WHERE water_level = 'foo' cannot ever be true, since water_level has floats and foo is a string. However, the DROP SERIES result suggests that the WHERE clause evaluated to true for every point in the measurement.

See also https://github.com/influxdb/influxdb/issues/4276

Might be related somehow to this generic WHERE field = bug: https://github.com/influxdb/influxdb/issues/4306


Allow post-processing of form data

IIUC, it seems that data is synced directly from form fields to the options storage via dom-form-serializer.  In some cases it is necessary to post-process form data into a new format before serializing for storage, for example when an individual item exceeds the 8k size limit, it is necessary to break it into chunks first before storing.
Is there a recommended way to do this?  If not, would it be possible to add some kind of mechanism to support it?  Thanks!

it is necessary to break it into chunks first before storing

What you're asking makes sense, but I think you can already do it autonomously. OptionsSync is a class so you just need to extend it and override the getters and setters since those are what take care of it. Example:
class MyOptionsSync extends OptionsSync {
	async getAll() {
		return myLoadingMechanism()
	}
	async setAll(values) {
		return mySettingMechamism(values)
	}
}

Thanks, I'll play with this approach.


[narwhal] hardening synchronizer gc testing

Description
Adding test for the gc logic of the synchronizer State. I've specifically tested the State as it is more straightforward to test this directly there instead of the Synchronizer it. self as it would be harder to understand/make it obvious the gc limit.
Test Plan
How did you test the new or updated feature?

If your changes are not user-facing and not a breaking change, you can skip the following section. Otherwise, please indicate what changed, and then add to the Release Notes section as highlighted during the release process.
Type of Change (Check all that apply)

[ ] protocol change
[ ] user-visible impact
[ ] breaking change for a client SDKs
[ ] breaking change for FNs (FN binary must upgrade)
[ ] breaking change for validators or node operators (must upgrade binaries)
[ ] breaking change for on-chain data layout
[ ] necessitate either a data wipe or data migration

Release notes

We can add an assert too on the returned value of run_gc_once.

Good point, I'll amend that!


Mic-5187/call-overload

Mic-5187/call-overload
Fixes one instance of call-overload

Category: Feature
JIRA issue: MIC-5187

-fixes one instance of call overload
Testing

[ ] all tests pass (pytest --runslow)

A few notes on this PR:
-I fixed one instance of the mypy errors for call-overload
-I did NOT remove call-overload from the errors to ignore because in the 2 main places where the error seems to originate, if I ignore the error there the error moves further up the call chain.
-The errors always appear in places where we get a value from multiple layers deep in a LayeredConfigTree and these values could be different objects. I tried importing the different types from LayeredConfigTree like NodeValue, NestedDict, etc to resolve this and that caused more issues than it fixed.
-Looking at potential solutions online it looks like we need to overwrite the magic method for getitem which I would assume would be in LayeredConfigTree but that is an educated guess.


flare of the heavens should only proc on harmful spells

this doesn't actually do anything since Harmful flag is only used with the CallbackOnSpellHitDealt callback. ProcMaskSpellDamage will already be checked and that should be sufficient!


Allow anchors

I don't know why it stopped working, but this fixes it.

What is this for?
If there is no ticket, please elaborate in the title and PR description


🐛 UI | SSW People | Wrong profile picture after scanning QR code

Device Info

iPhone SE (3rd Gen)
iOS 16.6.1
SSW Rewards 2.2.1(7) from TestFlight

Steps to reproduce:

Go to "SSW People" menu
Search on someone
Go to "Scanner" menu
Scan a QR code
Go back to "SSW People"

Expected result:
The same person with correct profile picture
Actual result:
Profile picture somehow switched to a random person.
https://github.com/SSWConsulting/SSW.Rewards.Mobile/assets/35659961/ccd9f6f7-83de-49a4-8a91-6c1e87a7853f

Closing the issue as it's not relevant anymore - the SSW People page has been replaced with the Network page.


JUnit reporting marks excluded as failed.

Problem
The exceptions seem not to be formatted in the right way while reporting in junit format. If the reporting is set pretty-printer, the exclusion seems to be taken in account and the risk score is 0. Also, its seems that the exclusion is taken in account but not printed in the right way. The failed resources are marked as 0 but it is still marked as a failure in Azure DevOps. Also it seems that the exclusion property is set to 0 while the test is being excluded.
Example
kubescape scan framework nsa \
--keep-local \
--format junit \
--exceptions exceptions.json \
--fail-threshold 0 \
--output example.xml \
deploy.yaml

# deploy.yaml
apiVersion: apps/v1
kind: Deployment
metadata:
  name: example
spec:
  selector:
    matchLabels:
      app: example
  template:
    metadata:
      labels:
        app: example
    spec:
      containers:
        - name: example
          image: nginx
          resources:
            limits:
              memory: "128Mi"
              cpu: "500m"
          ports:
            - containerPort: 80

[
  {
    "name": "Allow Non-root containers",
    "policyType": "postureExceptionPolicy",
    "resources": [
      {
        "designatorType": "Attributes",
        "attributes": {
          "namespace": ".*"
        }
      }
    ],
    "posturePolicies": [
      {
        "controlName": "Non-root containers"
      }
    ]
  }
]

<!-- example.xml (snipped) -->
<testsuites>
    <testsuite tests="26" time="" name="NSA" resources="1" excluded="0" filed="1">
        <properties></properties>
        <testcase classname="Kubescape" name="Non-root containers" time="0001-01-01 00:00:00 +0000 UTC" resources="1" excluded="0" filed="0">
            <failure message="0 resources failed" type="">
</failure>
        </testcase>
    </testsuite>
</testsuites>

Solution

Thank you @wim-de-groot .
We will look into this.


Suggestion: Create a validator that runs after parsing, to check for inconsitencies like multiple unique names etc.

Should check for inconsistencies that we cannot feasibly resolve during parsing. E.g. multiple unique names etc. Basically, a validation that our final metamodel does not contain errors.
Based on suggestions from chapter 4 in "Implementin Domain Specific Languages..."

Hmm, maybe not so relevant after all. I read on and, the cool takeaway from xtexts own validators is that they can propagate their results to the DSL editor, so the errors can be shown to the user. For example, it can do squiggly lines under two identical variable names and indicate that this is not allowed. I think that implementing custom validators with the same capabilities is out of scope.
Maybe we should research how hard it is to generate a web editor with xtext (i read this is possible somewhere) and connect it to a C# backend. If we can do that, I believe we can enjoy all the niceties from xtext only altering our approach slightly.


Roll Engine from 6de212bdaeb8 to 91b1460d3fd2 (10 revisions)

https://github.com/flutter/engine/compare/6de212bdaeb8...91b1460d3fd2
2021-06-10<EMAIL_ADDRESS>Roll Dart SDK from 51af508b1661 to b541bcb9fd3d (1 revision) (flutter/engine#26697)
2021-06-10<EMAIL_ADDRESS>[web] test runner fixes: build, sourcemaps, Dart 1-isms (flutter/engine#26696)
2021-06-10<EMAIL_ADDRESS>Roll Skia from ecc8e3bc043e to 1f5ee0d00c7f (1 revision) (flutter/engine#26695)
2021-06-10<EMAIL_ADDRESS>[web] Allow some more nulls in platform_dispatcher. (flutter/engine#26626)
2021-06-10<EMAIL_ADDRESS>Roll Skia from 9d1cc0510039 to ecc8e3bc043e (2 revisions) (flutter/engine#26692)
2021-06-10<EMAIL_ADDRESS>Remove compilation trace saving. (flutter/engine#26642)
2021-06-10<EMAIL_ADDRESS>[Android TextInput] clean up nested batch edits in closeConnection() (flutter/engine#26628)
2021-06-10<EMAIL_ADDRESS>Revert "Add support for native callbacks to the macOS embedder test harness (#26623)" (flutter/engine#26693)
2021-06-10<EMAIL_ADDRESS>Updates the objectc docs script to use env variables. (flutter/engine#26666)
2021-06-10<EMAIL_ADDRESS>Roll Skia from d2e096069691 to 9d1cc0510039 (4 revisions) (flutter/engine#26691)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC<EMAIL_ADDRESS>on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Closing to trigger a new roll attempt.

Commit queue failed; closing this roll.


Make all vars accessiable in index.html

This PR try to fixed #1438.
Expose all vars from getClientEnvironment and put it into InterpolateHtmlPlugin.

@Timer Something you'd consider for 0.9.0?

I'll add it to the list. I want to understand the need for the JSON.stringify before signing off on anything.

In Webpack defineplugin replaces strings verbatim. For examples if you don't stringify 'development' (thus adding quotes inside the string) it will actually replace NODE_ENV with development which would be an undefined variable.

@gaearon ah! Thanks for the explanation. Saved me some research. 😄

Maybe raw and stringified?

Maybe raw and stringified?

Fixed in 096f3c671838057b8e6aa292d5a9e11b454987b9

Thanks!

Hi guys. Can you tell me what I'm doing wrong? I'm trying to access these env variables in index.html.
...
    <title>React App</title>
    <script type="text/javascript">
        console.log(process); // process is not undefined
    </script>
    </head>
...

Hi @andrewhl ,
Try this (interpolate variable):
...
    <title>React App</title>
    <script type="text/javascript">
        console.log(%NODE_ENV%);
    </script>
    </head>
...

@jihchi Needed to place %NODE_ENV% in quotes, but other than that it works perfectly. Thank you!

Looks like there is currently a bug with this feature : https://github.com/facebook/create-react-app/issues/5473


Make -[IGListBindingSectionController object] Public

Issue fixed: #572
I didn't add an entry into CHANGELOG since the entire component is new. I've been doing some proof-of-concepts for IGListBindingSectionController + AsyncDisplayKit in Pinterest and it's working like a charm!

Why didn't this kick off any Travis builds of the Examples? Swift should have thrown errors on all the sample code because now they are generic and require type definition.
IGListKit/Examples/Examples-iOS/IGListKitExamples/SectionControllers/MonthSectionController.swift:18:37: Reference to generic type 'IGListBindingSectionController' requires arguments in <...>

@amonshiz we probably merged before travis ran.
travis is slow af


tar using --no-same-owner

Issue #, if available:
#10
Description of changes:
Run tar using --no-same-owner. This works around permissions issues when trying to install aws-lambda-ric on CI pipelines. It also maintains parity with https://github.com/aws/aws-lambda-python-runtime-interface-client/pull/39
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Is there any timeline for merging this.It has already been merged in python ric module.


CLI throws an error if there is no detections dir

Problem
If the Matano CLI doesn't find a detections/ dir, it throws an error:
$ matano diff --user-directory ./config/envs/my-env
 ›   Error: ENOENT: no such file or directory, scandir '/my-homedir/my-repo-path/config/envs/my-env/detections'
exit status 1

Solution
If there is no detections/ dir, the CLI should no-op instead of throwing an error.

An empty dir leads to a CFN stack failure when attempting to create a bucket notification for the detections bucket.

Logical ID
Status
Status reason

DetectionsQueueDPCommonStackMatanoRealtimeBucketNotifications10DA379E819ABF04
CREATE_FAILED
Invalid parameter: Attributes Reason: FilterPolicy: Empty arrays are not allowed at [Source: (String)"{"resolved_table_name":[]}"; line: 1, column: 26] (Service: AmazonSNS; Status Code: 400; Error Code: InvalidParameter; Request ID: dd7fdee9-33a0-517c-8515-828d8fad07df; Proxy: null)


update zg-ipchat 1.0.0 locale en-US yaml

[ ] Have you signed the Contributor License Agreement?
[ ] Have you checked that there aren't other open pull requests for the same manifest update/change?
[ ] Have you validated your manifest locally with winget validate --manifest <path>?
[ ] Have you tested your manifest locally with winget install --manifest <path>?
[ ] Does your manifest conform to the 1.1 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.

Microsoft Reviewers: Open in CodeFlow

I want to delete  IpchatGuiPc first

I want to delete IpchatGuiPc first

I want to delete IpchatGuiPc first


domain renewal

I got a renewal notice for njump.me.  All the links looks legit (not like phishing). I don't recall buying the domain, but I don't mind if my name/email was somehow used. Just curious.  Says it expires 2 February (today in NZ).

Yes that is my email address.  Maybe it was phishing.  It was cow bird dot net (I'm afraid to go there).


[aes/sw] Load all-zero vector into PRNG buffer stage for masking off

The input masks are now taken from the PRNG buffer stage. This means after loading the magic seed into the PRNG and having the PRNG output the all-zero vector, the buffer stage needs to be updated as well. This can be achieved by triggering via a clearing operation of the data output registers.
This resolves lowRISC/OpenTitan#22917.

Thanks for your reviews. There are some CI FPGA failures but this is all spurious. The code in this PR is NOT run on the FPGA in any form in CI. I am thus merging this.


SMILES Parsing Helper Function

Develop this function -
//pre: molecule is a valid SMILES notation i.e. CC(CCC(C)=O)C which is 5-methyl-2-oxohexane
//post: a vector is returned that contains each chain and the point it branches off of
//i.e. [CCC, -1], [CCC(C)=O, 1]
std::vector filterBranching(std::string molecule);
SEE DEVELOPMENTDRIVER FOR MORE INFO.

Development Driver cpp framework now has incorporated the branch locations helper function in context. Added the system pause to the main of development driver. Feel free to comment out the test I have for the filterBranching function to run smaller tests.  Main now contains the format of expected output should the filterBranching be working properly. The filter branching function in development driver is equivalent to the main function in your branch locations cpp. A skeleton of code has been provided for the next step along with a short paragraph description of the task and how to complete it. Some examples of how substring works has also been provided.


[Bug] [UI] The project name cannot be searched when a dependency node is added

Search before asking

[X] I had searched in the issues and found no similar issues.

What happened

What you expected to happen
I hope it will be recover quikly
How to reproduce
null
Anything else
No response
Version
3.1.x
Are you willing to submit PR?

[ ] Yes I am willing to submit a PR!

Code of Conduct

[X] I agree to follow this project's Code of Conduct

I'll check out this issue.


usd-rs 0.0.3 failed to build

Crate name:
usd-rs
Build failure link:
https://docs.rs/crate/usd/0.0.3/builds/315265
Additional details:
usd-rs depends on usd-cpp, that's a crate I wrote to build a c++ library that usd-rs wraps. The crate uses a utility that is bundled with the c++ library that will download it's dependencies (namely boost and tbb). Please can you grant network access for this reason?
I'm not sure if there's a way to generate the docs for my crate without building the upstream dependencies, but that would be the ideal.
Thanks again,
Luke

Docs.rs does not allow network access for any reason. If you need boost and tbb you can install them in the build image: https://forge.rust-lang.org/docs-rs/add-dependencies.html

I'm not sure if there's a way to generate the docs for my crate without building the upstream dependencies, but that would be the ideal.

I assume you have a build.rs that's compiling the c++ dependency? You can check if the DOCS_RS env variable is set and skip the compile if so: https://docs.rs/about/builds

ah, great, thank you!
Sent with ProtonMail Secure Email.
‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐
On Friday, November 13th, 2020 at 22:44, Joshua Nelson<EMAIL_ADDRESS>wrote:

I'm not sure if there's a way to generate the docs for my crate without building the upstream dependencies, but that would be the ideal.

I assume you have a build.rs that's compiling the c++ dependency? You can check if the DOCS_RS env variable is set and skip the compile if so: https://docs.rs/about/builds
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.


more hyper-rust optimizations

Use a pure-rust http client (AFAIK chttp uses libcurl, and reqwest's author is hyper's author)
instead of panicking (and killing a thread), return an error when dividing/modulus by zero
Save more allocations in program construction by using static arrays instead of vectors
spawn_blocking should be used when spawning a blocking task (such as eval)

Thanks!

Save more allocations in program construction by using static arrays instead of vectors

Can you confirm this makes it faster (or at least, no slower) for you?

spawn_blocking should be used when spawning a blocking task (such as eval)

I don't understand this change. Could you explain it for the next person to work on this (as a comment if appropriate, else here is fine)?
Thanks!

Save more allocations in program construction by using static arrays instead of vectors

Can you confirm this makes it faster (or at least, no slower) for you?

Yes, I used criterion to benchmark the eval function.
Current main branch:
fizzbuzz                time:   [663.04 us 679.78 us 697.84 us]
Found 7 outliers among 100 measurements (7.00%)
  4 (4.00%) high mild
  3 (3.00%) high severe

fizzbuzz                time:   [637.85 us 653.05 us 668.90 us]
                        change: [-9.0754% -4.4719% +0.5992%] (p = 0.08 > 0.05)
                        No change in performance detected.
Found 9 outliers among 100 measurements (9.00%)
  5 (5.00%) high mild
  4 (4.00%) high severe

This PR:
fizzbuzz                time:   [473.37 us 487.92 us 503.96 us]
                        change: [-28.994% -25.821% -22.838%] (p = 0.00 < 0.05)
                        Performance has improved.
Found 1 outliers among 100 measurements (1.00%)
  1 (1.00%) high mild

If you'd like I can include the benchmark's code in a separate PR.

spawn_blocking should be used when spawning a blocking task (such as eval)

I don't understand this change. Could you explain it for the next person to work on this (as a comment if appropriate, else here is fine)?

Tasks spawned on the tokio executor must not block. rust-hyper will block when making HTTP requests, which may block the executor and cause a delay.
From spawn_blocking's documentation:

Runs the provided closure on a thread where blocking is acceptable.


Syntax highlight in diff and edit preview broken

The highlighting code currently assumes a pre > code structure to work but this is not given for diff and edit previews. Given that pre > code is problematic in regards to introducing extra whitespace for text selection, I think we should introduce a new exclusive HTML class for syntax highlighting and use that everywhere.

How that will work in markdown code sections

Good point, if the markdown renderer can only output pre > code, we have to cover it via .markdown pre > code. On the other hand, I think some more expermentation is neccessary if pre > code can be made to work in regard to copy/paste.


Use tsx over jsx in documentation

Summary
import type { Data, PageHelpers } from 'lume/core.ts';

export default (
    { title, children }: Data,
    filters: PageHelpers
) => (
  <html>
    <head>
      <title>{title}</title>
    </head>
    <body>
      {children}
    </body>
  </html>
);

replace examples in jsx, jsx preact with tsx.
Motivation
majority of template engines lume supports does not have type system (nunjucks, liquid, etc...). however, users of tsx and tsx preact could benefit by using typescript definitions. for example, it would be helpful to show that layouts uses Data type.

The use of JSX for the examples is for simplicity. TSX is a bit verbose and JSX is more clear. But yeah, probably some examples could have both formats.

Possibly do something similar to [SvelteKit] and allow switching between the two? (e.g. tabs or a toggle - but a toggle might be a bit too much :sweat_smile:)


Added the Gssoc banner

IMPORTANT: When creating your Pull Request, please use the following format for the title: Category - Resource Name & Section
PR Title samples:

Web development - CSS Portal & Tools
Web development - Leetcode & Challenges

Closes #654
Description:
I have added the GSSoC'24 banner in the README.md file
Resource URL:

Insert the URL of the resource you're proposing

Checklist:
Before submitting your pull request, ensure that you have completed the following tasks:

[x] I have carefully reviewed and adhered to the contributing guidelines before creating this pull request.
[x] I followed the prescribed PR title template. (Check this if you're adding a resource)

fill the bracket with x. Something like this [x]

@jfmartinz please review and merge it


HADOOP-18711. upgrade nimbus jwt jar due to issues in its embedded shaded json-smart code.

Description of PR
backport of #5573
How was this patch tested?
For code changes:

[x] Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
[ ] Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
[ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
[x] If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
5m 10s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+0 :ok:
xmllint
0m  0s

xmllint was not available.

+0 :ok:
shelldocs
0m  0s

Shelldocs was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s

The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ branch-3.3 Compile Tests _

+0 :ok:
mvndep
14m 26s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
22m 14s

branch-3.3 passed

+1 :green_heart:
compile
11m 57s

branch-3.3 passed

+1 :green_heart:
mvnsite
19m 24s

branch-3.3 passed

+1 :green_heart:
javadoc
5m  6s

branch-3.3 passed

+1 :green_heart:
shadedclient
27m 23s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 28s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
21m 42s

the patch passed

+1 :green_heart:
compile
11m 32s

the patch passed

+1 :green_heart:
javac
11m 32s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
mvnsite
15m  4s

the patch passed

+1 :green_heart:
shellcheck
0m  0s

No new issues.

+1 :green_heart:
javadoc
4m 54s

the patch passed

+1 :green_heart:
shadedclient
27m 57s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
614m 47s
/patch-unit-root.txt
root in the patch passed.

+1 :green_heart:
asflicense
1m 19s

The patch does not generate ASF License warnings.

797m 43s

Reason
Tests

Failed junit tests
hadoop.yarn.server.resourcemanager.scheduler.capacity.TestCapacitySchedulerAutoQueueCreation

hadoop.hdfs.tools.TestDFSAdmin

hadoop.hdfs.server.namenode.TestAddOverReplicatedStripedBlocks

hadoop.hdfs.server.balancer.TestBalancerWithHANameNodes

hadoop.hdfs.server.datanode.TestDataNodeRollingUpgrade

hadoop.util.curator.TestZKCuratorManager

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6201/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/6201

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient codespell detsecrets xmllint shellcheck shelldocs

uname
Linux 054cbe1e3b8b 4.15.0-212-generic #223-Ubuntu SMP Tue May 23 13:09:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
branch-3.3 / 3ca7f162bb137dab32dfc5bdc60225ff73f44dca

Default Java
Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~18.04-b09

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6201/1/testReport/

Max. process+thread count
3924 (vs. ulimit of 5500)

modules
C: hadoop-project . U: .

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6201/1/console

versions
git=2.17.1 maven=3.6.0 shellcheck=0.4.6

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 25s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+0 :ok:
xmllint
0m  0s

xmllint was not available.

+0 :ok:
shelldocs
0m  0s

Shelldocs was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s

The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ branch-3.3 Compile Tests _

+0 :ok:
mvndep
15m 17s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
24m  8s

branch-3.3 passed

+1 :green_heart:
compile
12m 29s

branch-3.3 passed

+1 :green_heart:
mvnsite
20m 19s

branch-3.3 passed

+1 :green_heart:
javadoc
4m 48s

branch-3.3 passed

+1 :green_heart:
shadedclient
29m 52s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 26s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
24m 34s

the patch passed

+1 :green_heart:
compile
10m 56s

the patch passed

+1 :green_heart:
javac
10m 56s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
mvnsite
15m 26s

the patch passed

+1 :green_heart:
shellcheck
0m  0s

No new issues.

+1 :green_heart:
javadoc
5m 17s

the patch passed

+1 :green_heart:
shadedclient
30m 40s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
360m 48s
/patch-unit-root.txt
root in the patch failed.

+1 :green_heart:
asflicense
0m 59s

The patch does not generate ASF License warnings.

550m 18s

Reason
Tests

Failed junit tests
hadoop.yarn.server.resourcemanager.reservation.TestCapacityOverTimePolicy

hadoop.hdfs.server.datanode.TestDirectoryScanner

hadoop.hdfs.TestReconstructStripedFile

hadoop.hdfs.TestDecommissionWithStripedBackoffMonitor

hadoop.hdfs.server.balancer.TestBalancerWithHANameNodes

hadoop.hdfs.server.datanode.fsdataset.impl.TestLazyPersistReplicaRecovery

hadoop.hdfs.server.datanode.TestDataNodeRollingUpgrade

hadoop.hdfs.TestDFSStripedInputStream

hadoop.hdfs.server.mover.TestMover

hadoop.security.TestRaceWhenRelogin

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch-windows-10/job/PR-6201/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/6201

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient codespell detsecrets xmllint shellcheck shelldocs

uname
Linux a1f93df98c42 4.15.0-212-generic #223-Ubuntu SMP Tue May 23 13:09:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
branch-3.3 / 3ca7f162bb137dab32dfc5bdc60225ff73f44dca

Default Java
Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~18.04-b09

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch-windows-10/job/PR-6201/1/testReport/

Max. process+thread count
3317 (vs. ulimit of 5500)

modules
C: hadoop-project . U: .

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch-windows-10/job/PR-6201/1/console

versions
git=2.17.1 maven=3.6.0 shellcheck=0.4.6

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 24s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+0 :ok:
xmllint
0m  0s

xmllint was not available.

+0 :ok:
shelldocs
0m  0s

Shelldocs was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s

The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ branch-3.3 Compile Tests _

+0 :ok:
mvndep
15m  3s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
22m 45s

branch-3.3 passed

+1 :green_heart:
compile
11m 58s

branch-3.3 passed

+1 :green_heart:
mvnsite
19m 32s

branch-3.3 passed

+1 :green_heart:
javadoc
5m 18s

branch-3.3 passed

+1 :green_heart:
shadedclient
27m 33s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 30s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
21m 43s

the patch passed

+1 :green_heart:
compile
11m 36s

the patch passed

+1 :green_heart:
javac
11m 36s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
mvnsite
15m  0s

the patch passed

+1 :green_heart:
shellcheck
0m  0s

No new issues.

+1 :green_heart:
javadoc
4m 49s

the patch passed

+1 :green_heart:
shadedclient
27m 40s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
357m 23s
/patch-unit-root.txt
root in the patch failed.

+1 :green_heart:
asflicense
1m  2s

The patch does not generate ASF License warnings.

536m 15s

Reason
Tests

Failed junit tests
hadoop.hdfs.server.balancer.TestBalancer

hadoop.hdfs.server.balancer.TestBalancerWithHANameNodes

hadoop.hdfs.server.datanode.TestDataNodeRollingUpgrade

hadoop.hdfs.server.namenode.ha.TestDFSUpgradeWithHA

hadoop.hdfs.server.mover.TestMover

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6201/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/6201

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient codespell detsecrets xmllint shellcheck shelldocs

uname
Linux df9ec5ed00ea 4.15.0-212-generic #223-Ubuntu SMP Tue May 23 13:09:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
branch-3.3 / c5117ddb52a83b6b9eda2e0824d73631cec24f89

Default Java
Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~18.04-b09

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6201/2/testReport/

Max. process+thread count
3282 (vs. ulimit of 5500)

modules
C: hadoop-project . U: .

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6201/2/console

versions
git=2.17.1 maven=3.6.0 shellcheck=0.4.6

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 25s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+0 :ok:
xmllint
0m  0s

xmllint was not available.

+0 :ok:
shelldocs
0m  0s

Shelldocs was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s

The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ branch-3.3 Compile Tests _

+0 :ok:
mvndep
15m  4s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
22m 46s

branch-3.3 passed

+1 :green_heart:
compile
12m  1s

branch-3.3 passed

+1 :green_heart:
mvnsite
19m  0s

branch-3.3 passed

+1 :green_heart:
javadoc
5m  0s

branch-3.3 passed

+1 :green_heart:
shadedclient
27m 23s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 29s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
21m 50s

the patch passed

+1 :green_heart:
compile
11m 22s

the patch passed

+1 :green_heart:
javac
11m 22s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
mvnsite
14m 59s

the patch passed

+1 :green_heart:
shellcheck
0m  0s

No new issues.

+1 :green_heart:
javadoc
4m 59s

the patch passed

+1 :green_heart:
shadedclient
27m 59s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
357m 58s
/patch-unit-root.txt
root in the patch failed.

+1 :green_heart:
asflicense
1m  2s

The patch does not generate ASF License warnings.

536m 16s

Reason
Tests

Failed junit tests
hadoop.yarn.server.nodemanager.containermanager.logaggregation.TestLogAggregationService

hadoop.hdfs.server.datanode.TestDirectoryScanner

hadoop.hdfs.server.datanode.TestNNHandlesCombinedBlockReport

hadoop.hdfs.server.mover.TestMover

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6201/3/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/6201

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient codespell detsecrets xmllint shellcheck shelldocs

uname
Linux 78ab2b7e5b12 4.15.0-212-generic #223-Ubuntu SMP Tue May 23 13:09:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
branch-3.3 / c5117ddb52a83b6b9eda2e0824d73631cec24f89

Default Java
Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~18.04-b09

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6201/3/testReport/

Max. process+thread count
3605 (vs. ulimit of 5500)

modules
C: hadoop-project . U: .

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6201/3/console

versions
git=2.17.1 maven=3.6.0 shellcheck=0.4.6

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.


JsMinifyTask reports outdated warnings

JsMinifyTask still reports outdated warnings
Warning: Custom property reference encountered. Please note that custom properties do not work with all major browsers, and their use is discouraged. at xyz.css line 40:742
As of 2017, all major browsers support custom properties.

@616slayer616 can we disable this in the backend

I don't think it makes sense to filter the messages from the backend.
But if this is really obsolete then the newer versions should not contain this warning anymore.
We already have a PR to upgrade the closure compiler but it is quite old.
So I updated the dependencies again and am working on getting the build to run so I would suggest to release this:
https://github.com/gradle-webtools/gradle-minify-plugin/pull/48

@4braincells thx for reporting :)

Thanks for reacting so fast :-)
I was ready for a RELEASE after a long time, I stumbled upon it by chance ...
Just saw the 2.0.0 already on org.gradlewebtools.minify
Is there a special reason why it depends on JVM 19?
As I am using Java LTS versions (and still on 17) , I wont be able to switch until 21.

I needed to upgrade the jdk because of the new Gradle version.
But I will check if 17 or even earlier also works

Ok I released again with JDK 17.
Lower was not possible because of sonarqube

I am scratching my head ;-D
So, one thing is: I was talking about "Custom property reference", so I should also have written CssMinifyTask instead of JsMinifyTask. My fault.
As I found a couple of deprecated stuff in my build.gradle, I upgraded gradle from 7.4.1 to 8.6 (step-wise :D),
then got the 2.0.0, but the result is again (or still)
> Task :cssMinifyBase
Warning: Custom property reference encountered. Please note that custom properties do not work with all major browsers, and their use is discouraged. at admin.css line 40:742
Warning: Custom property reference encountered. Please note that custom properties do not work with all major browsers, and their use is discouraged. at admin.css line 99:1678
Warning: Custom property reference encountered. Please note that custom properties do not work with all major browsers, and their use is discouraged. at admin.css line 122:2017
Warning: Custom property reference encountered. Please note that custom properties do not work with all major browsers, and their use is discouraged. at base.css line 22:320

Am I doing s.t.h wrong?

BTW, the gradle config is now:

import org.gradlewebtools.minify.CssMinifyTask
import org.gradlewebtools.minify.JsMinifyTask
minification {
    tasks.register('jsMinifyBase', JsMinifyTask) {
        srcDir = project.file("$projectDir/src/main/resources/static/js")
        dstDir = project.file("${layout.buildDirectory.get().asFile}/resources/main/static/js")
        print "Minifying JS to " + dstDir + "\n"
        options.ignoreMinFiles = true
    }
    tasks.register('cssMinifyBase', CssMinifyTask) {
        srcDir = project.file("$projectDir/src/main/resources/static/css")
        dstDir = project.file("${layout.buildDirectory.get().asFile}/resources/main/static/css")
        print "Minifying CSS to " + dstDir + "\n"
        options.ignoreMinFiles = true
    }
}

processResources {
    if (buildLevel == "RELEASE") {
        exclude "/static/css/*.css"
        exclude "/static/js/*.js"
        filesMatching(['/templates/*.html', '/templates/**/*.html']) {
            filter { line ->
                {
                    line = line.replaceAll('/css/base.css', '/css/base.min.css')
                            .replaceAll('/css/admin.css', '/css/admin.min.css')
                            .replaceAll('/js/apply.js', '/js/apply.min.js')
                            .replaceAll('/js/cancel.js', '/js/cancel.min.js')
                            .replaceAll('/js/admin.js', '/js/admin.min.js')
                }
            }
        }
        dependsOn(jsMinifyBase)
        dependsOn(cssMinifyBase)
    }
}

I thought the issue is with the JsMinifyTask as mentioned in the title.
But it is Really with the CSS task.
That uses another library.
Unfortunately, it is not maintained anymore by Google.
It would be nice to find a replacement.
In the meantime, I maintain a fork of this repo.
This could be the solution to the issue:
https://github.com/616slayer616/closure-stylesheets/pull/19
I will have to get the build working first though.

https://github.com/gradle-webtools/gradle-minify-plugin/pull/51


Cannot import Napari

Hi,
it seems that there is an issue with my Napari installation.
To Reproduce
I installed Napari using pip: sudo pip install napari[all].
Then I started python and tried import napari, but I got the following error:
Expected behavior
>>>import napari
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/opt/local/Library/Frameworks/Python.framework/Versions/3.8/lib/python3.8/site-packages/napari/__init__.py", line 16, in <module>
    from ._event_loop import gui_qt, run
  File "/opt/local/Library/Frameworks/Python.framework/Versions/3.8/lib/python3.8/site-packages/napari/_event_loop.py", line 2, in <module>
    from ._qt.qt_event_loop import gui_qt, run
  File "/opt/local/Library/Frameworks/Python.framework/Versions/3.8/lib/python3.8/site-packages/napari/_qt/__init__.py", line 45, in <module>
    path, loader = import_resources()
  File "/opt/local/Library/Frameworks/Python.framework/Versions/3.8/lib/python3.8/site-packages/napari/_qt/qt_resources/__init__.py", line 122, in import_resources
    respath = build_pyqt_resources(fspath(target_file), overwrite=overwrite)
  File "/opt/local/Library/Frameworks/Python.framework/Versions/3.8/lib/python3.8/site-packages/napari/_qt/qt_resources/build_icons.py", line 226, in build_pyqt_resources
    for name in _find_rcc_or_raise():
  File "/opt/local/Library/Frameworks/Python.framework/Versions/3.8/lib/python3.8/site-packages/napari/_qt/qt_resources/build_icons.py", line 177, in _find_rcc_or_raise
    raise FileNotFoundError(
FileNotFoundError: Unable to find an executable to build Qt resources (icons).
Tried: 'pyrcc5.bat', 'pyrcc5', 'pyside2-rcc'.
Please open issue at https://github.com/napari/napari/issues/.

Environment
MacOSX 10.15.7
Python 3.8.7 installed using MacPort, (default, Dec 24 2020, 16:36:45) [Clang 11.0.3 (clang-1<IP_ADDRESS>)] on darwin
Pip 20.3.3 installed using MacPort
Napari installed PyQt5 5.15.2 and PyQt5-sip 12.8.1
pip freeze
alabaster==0.7.12
anyio==2.0.2
appdirs==1.4.4
appnope==0.1.2
argon2-cffi==20.1.0
astroid==2.4.2
async-generator==1.10
attrs==20.3.0
Babel==2.9.0
backcall==0.2.0
Beaker==1.11.0
bleach==3.2.2
bokeh==2.2.3
cachey==0.2.1
cellpose==0.6
certifi==2020.12.5
cffi==1.14.4
chardet==4.0.0
colorcet==2.0.6
cycler==0.10.0
dask==2021.1.0
decorator==4.4.2
defusedxml==0.6.0
docutils==0.16
entrypoints==0.3
freetype-py==2.2.0
h5py==3.1.0
HeapDict==1.0.1
holoviews==1.14.1
horology==1.1.0
idna==2.10
imageio==2.9.0
imagesize==1.2.0
ipykernel==5.4.3
ipython==7.19.0
ipython-genutils==0.2.0
isort==5.6.4
jedi==0.18.0
Jinja2==2.11.2
joblib==1.0.0
json5==0.9.5
jsonschema==3.2.0
jupyter-client==6.1.11
jupyter-core==4.7.0
jupyter-server==1.2.2
jupyterlab==3.0.5
jupyterlab-pygments==0.1.2
jupyterlab-server==2.1.2
kiwisolver==1.3.1
lazy-object-proxy==1.4.3
llvmlite==0.35.0
magicgui==0.2.5
Mako==1.1.4
Markdown==3.3.3
MarkupSafe==1.1.1
matplotlib==3.3.3
mccabe==0.6.1
mistune==0.8.4
napari==0.4.3
napari-plugin-engine==0.1.9
napari-svg==0.1.4
natsort==7.1.0
nbclassic==0.2.6
nbclient==0.5.1
nbconvert==6.0.7
nbformat==5.1.2
nest-asyncio==1.4.3
networkx==2.5
notebook==6.2.0
numba==0.52.0
numpy==1.19.5
numpydoc==1.1.0
opencv-python-headless==<IP_ADDRESS>
packaging==20.8
pandas==1.2.1
pandocfilters==1.4.3
panel==0.10.3
param==1.10.1
parso==0.8.1
pexpect==4.8.0
pickleshare==0.7.5
Pillow==8.1.0
prometheus-client==0.9.0
prompt-toolkit==3.0.11
psutil==5.8.0
ptyprocess==0.7.0
pycparser==2.20
pyct==0.4.8
Pygments==2.7.4
pylint==2.6.0
PyOpenGL==3.1.5
pyparsing==2.4.7
PyQt5==5.15.2
PyQt5-sip==12.8.1
pyrsistent==0.17.3
python-dateutil==2.8.1
pytz==2020.5
pyviz-comms==2.0.1
PyWavelets==1.1.1
PyYAML==5.4.1
pyzmq==21.0.1
qtconsole==5.0.1
QtPy==1.9.0
requests==2.25.1
scikit-image==0.18.1
scikit-learn==0.24.1
scipy==1.6.0
Send2Trash==1.5.0
six==1.15.0
sniffio==1.2.0
snowballstemmer==2.0.0
Sphinx==3.4.3
sphinxcontrib-applehelp==1.0.2
sphinxcontrib-devhelp==1.0.2
sphinxcontrib-htmlhelp==1.0.3
sphinxcontrib-jsmath==1.0.1
sphinxcontrib-qthelp==1.0.3
sphinxcontrib-serializinghtml==1.1.4
tabulate==0.8.7
terminado==0.9.2
testpath==0.4.4
threadpoolctl==2.1.0
tifffile==2021.1.14
toml==0.10.2
toolz==0.11.1
torch==1.7.1
torchaudio==0.7.2
torchvision==0.8.2
tornado==6.1
tqdm==4.56.0
traitlets==5.0.5
typing-extensions==<IP_ADDRESS>
urllib3==1.26.2
vispy==0.6.6
wcwidth==0.2.5
webencodings==0.5.1
wrapt==1.12.1
What am I missing?

Hi @FiReTiTi, sorry you're having this issue.
most often this occurs because of some environment issue.  It looks like you're installing into a global python environment, and some previously installed stuff might be conflicting.  In the vast majority of cases, this may be fixed by creating a new "virtual environment" in which to install and run your programs.  This is one of the reasons we give this little bit of advice in our readme:

Note: while not strictly required, it is highly recommended to
install napari into a clean virtual environment using an environment
manager like conda.
For example, with conda:
conda create -y -n napari-env python=3.8
conda activate napari-env
pip install napari[all]

If you want to post the output of pip freeze here, we can try to help debug your environment, but you might be better off in the long run going with a virtual environment manager like conda.

Hi @FiReTiTi, sorry you're having this issue.
most often this occurs because of some environment issue.  It looks like you're installing into a global python environment, and some previously installed stuff might be conflicting.  In the vast majority of cases, this may be fixed by creating a new "virtual environment" in which to install and run your programs.  This is one of the reasons we give this little bit of advice in our readme:

Note: while not strictly required, it is highly recommended to
install napari into a clean virtual environment using an environment
manager like conda.
For example, with conda:
conda create -y -n napari-env python=3.8
conda activate napari-env
pip install napari[all]

If you want to post the output of pip freeze here, we can try to help debug your environment, but you might be better off in the long run going with a virtual environment manager like conda.

Thank you for your answer. I don't have multiple programs and libraries to use, this is why I didn't create a specific environment.
I've updated my original post with the pip freeze results.

Thank you for your answer. I don't have multiple programs and libraries to use, this is why I didn't create a specific environment.
I've updated my original post with the pip freeze results.

thanks for the update.  If you just run which pyrcc5 on the command line, does it give you anything?

thanks for the update.  If you just run which pyrcc5 on the command line, does it give you anything?

Nothing found :-(
I tried to do pip search pyrcc5, but got an error:
pip search pyrcc5                                                                                13:20:53
ERROR: Exception:
Traceback (most recent call last):
File "/opt/local/Library/Frameworks/Python.framework/Versions/3.8/lib/python3.8/site-packages/pip/_internal/cli/base_command.py", line 224, in _main
status = self.run(options, args)
File "/opt/local/Library/Frameworks/Python.framework/Versions/3.8/lib/python3.8/site-packages/pip/_internal/commands/search.py", line 62, in run
pypi_hits = self.search(query, options)
File "/opt/local/Library/Frameworks/Python.framework/Versions/3.8/lib/python3.8/site-packages/pip/_internal/commands/search.py", line 82, in search
hits = pypi.search({'name': query, 'summary': query}, 'or')
File "/opt/local/Library/Frameworks/Python.framework/Versions/3.8/lib/python3.8/xmlrpc/client.py", line 1109, in call
return self.__send(self.__name, args)
File "/opt/local/Library/Frameworks/Python.framework/Versions/3.8/lib/python3.8/xmlrpc/client.py", line 1450, in __request
response = self.__transport.request(
File "/opt/local/Library/Frameworks/Python.framework/Versions/3.8/lib/python3.8/site-packages/pip/_internal/network/xmlrpc.py", line 46, in request
return self.parse_response(response.raw)
File "/opt/local/Library/Frameworks/Python.framework/Versions/3.8/lib/python3.8/xmlrpc/client.py", line 1341, in parse_response
return u.close()
File "/opt/local/Library/Frameworks/Python.framework/Versions/3.8/lib/python3.8/xmlrpc/client.py", line 655, in close
raise Fault(**self._stack[0])
xmlrpc.client.Fault: <Fault -32500: "RuntimeError: PyPI's XMLRPC API has been temporarily disabled due to unmanageable load and will be deprecated in the near future. See https://status.python.org/ for more information.">

Nothing found :-(
I tried to do pip search pyrcc5, but got an error:
pip search pyrcc5                                                                                13:20:53
ERROR: Exception:
Traceback (most recent call last):
File "/opt/local/Library/Frameworks/Python.framework/Versions/3.8/lib/python3.8/site-packages/pip/_internal/cli/base_command.py", line 224, in _main
status = self.run(options, args)
File "/opt/local/Library/Frameworks/Python.framework/Versions/3.8/lib/python3.8/site-packages/pip/_internal/commands/search.py", line 62, in run
pypi_hits = self.search(query, options)
File "/opt/local/Library/Frameworks/Python.framework/Versions/3.8/lib/python3.8/site-packages/pip/_internal/commands/search.py", line 82, in search
hits = pypi.search({'name': query, 'summary': query}, 'or')
File "/opt/local/Library/Frameworks/Python.framework/Versions/3.8/lib/python3.8/xmlrpc/client.py", line 1109, in call
return self.__send(self.__name, args)
File "/opt/local/Library/Frameworks/Python.framework/Versions/3.8/lib/python3.8/xmlrpc/client.py", line 1450, in __request
response = self.__transport.request(
File "/opt/local/Library/Frameworks/Python.framework/Versions/3.8/lib/python3.8/site-packages/pip/_internal/network/xmlrpc.py", line 46, in request
return self.parse_response(response.raw)
File "/opt/local/Library/Frameworks/Python.framework/Versions/3.8/lib/python3.8/xmlrpc/client.py", line 1341, in parse_response
return u.close()
File "/opt/local/Library/Frameworks/Python.framework/Versions/3.8/lib/python3.8/xmlrpc/client.py", line 655, in close
raise Fault(**self._stack[0])
xmlrpc.client.Fault: <Fault -32500: "RuntimeError: PyPI's XMLRPC API has been temporarily disabled due to unmanageable load and will be deprecated in the near future. See https://status.python.org/ for more information.">

pyrrc should have been installed when you got PyQt5... so that's what we need to figure out here.  you can try to do pip uninstall -y PyQt5 and then pip install PyQt5, but the other possibility is that the pyrrc script did get installed, but to some location that's not on your PATH for some reason.  Based on your stack traces, I would have expected pyrrc5 to have been put in /opt/local/Library/Frameworks/Python.framework/Versions/3.8/bin.  Can you look in there?  or maybe run the following and see if it got put anywhere?
find /opt/local/Library/Frameworks/Python.framework/Versions/3.8/ -name pyrcc5

and if that still gives nothing try:
find /opt/local/Library/Frameworks/Python.framework/Versions/3.8/ -name 'pyrcc*'

pyrrc should have been installed when you got PyQt5... so that's what we need to figure out here.  you can try to do pip uninstall -y PyQt5 and then pip install PyQt5, but the other possibility is that the pyrrc script did get installed, but to some location that's not on your PATH for some reason.  Based on your stack traces, I would have expected pyrrc5 to have been put in /opt/local/Library/Frameworks/Python.framework/Versions/3.8/bin.  Can you look in there?  or maybe run the following and see if it got put anywhere?
find /opt/local/Library/Frameworks/Python.framework/Versions/3.8/ -name pyrcc5

and if that still gives nothing try:
find /opt/local/Library/Frameworks/Python.framework/Versions/3.8/ -name 'pyrcc*'

Good catch.
pyrcc5was installed in /opt/local/Library/Frameworks/Python.framework/Versions/3.8/bin, and this directory was added to PYTHONPATH, but not to the PATH, so I added PYTHONPATH to PATH.
I tried to import Napari and it's now working.
Thanks a lot for your help.

Good catch.
pyrcc5was installed in /opt/local/Library/Frameworks/Python.framework/Versions/3.8/bin, and this directory was added to PYTHONPATH, but not to the PATH, so I added PYTHONPATH to PATH.
I tried to import Napari and it's now working.
Thanks a lot for your help.

great news!  thanks for helping us track that down, will be useful to have here for others.

great news!  thanks for helping us track that down, will be useful to have here for others.


Possible build error

Test server :

Ubuntu 14.04.2 LTS fresh install
go version go1.3 linux/amd64
lxd commit 4b84c8bd047ae1b71352b76677fd60d3b21b981a
installed packages :

acl xzip tar rsync pxz xz-utils
python-lzma cgroup-bin libpam-systemd

lxc lxc-dev mercurial git pkg-config
protobuf-compiler golang-goprotobuf-dev

protoc & protoc-gen-go in path (from ubuntu official repos)

> protoc --version
libprotoc 2.5.0

> export GOBIN=/opt/go/bin
> export GOPATH=/opt/go
> export PATH=$PATH:/usr/local/go/bin
> cd /opt/go/src/github.com/lxc/lxd

> /usr/local/go/bin/go get -v -u -d ./...
github.com/lxc/lxd (download)
github.com/gorilla/websocket (download)
github.com/gosexy/gettext (download)
github.com/mattn/go-sqlite3 (download)
gopkg.in/lxc/go-lxc.v2 (download)
golang.org/x/crypto (download)
gopkg.in/yaml.v2 (download)
github.com/olekukonko/tablewriter (download)
code.google.com/p/go-uuid (download)
github.com/dustinkirkland/golang-petname (download)
github.com/golang/protobuf (download)
github.com/gorilla/mux (download)
github.com/gorilla/context (download)
Fetching https://gopkg.in/tomb.v2?go-get=1
Parsing meta tags from https://gopkg.in/tomb.v2?go-get=1 (status code 200)
get "gopkg.in/tomb.v2": found meta tag main.metaImport{Prefix:"gopkg.in/tomb.v2", VCS:"git", RepoRoot:"https://gopkg.in/tomb.v2"} at https://gopkg.in/tomb.v2?go-get=1
gopkg.in/tomb.v2 (download)

The error happens when i'm trying to run make :
> make
protoc --go_out=. ./lxd/migration/migrate.proto
go install -v ./...
lxd/migration/migrate.pb.go:7:8: cannot find package "code.google.com/p/goprotobuf/proto" in any of:
	/usr/local/go/src/pkg/code.google.com/p/goprotobuf/proto (from $GOROOT)
	/opt/go/src/code.google.com/p/goprotobuf/proto (from $GOPATH)
make: *** [default] Error 1

Is there another way to build protoc ? (I tried to rebuild protoc from sources but it did the same) ... And protoc doesn't seem to be in go get dependencies list (normal ?)
Is it normal at this point ? Or did I made a mistake somewhere ?

Ah, no, you didn't make a mistake. We've had other reports about this, and I finally realized what was going on. That PR should fix it, sorry about that.

:godmode: great job !
Thanks a lot.


Mast branch sinks ships on bad-softing

While experimenting with marks, some sort of error on my end sank my fakezod on master. urbit repeatedly spits out:
serf_send_replace 220 crud
pier: replace: 220
pier: (220): compute: replace
[%bad-softing 'crud']
serf_send_replace 220 crud
pier: replace: 220
pier: (220): compute: replace
[%bad-softing 'crud']
serf_send_replace 220 crud
pier: replace: 220
pier: (220): compute: replace
[%bad-softing 'crud']

And over and over again until I ctrl+c, which sinks the ship as if I kill the urbit/urbit-worker process, it just retries the computation.

I've similarly crashed several master (cc-release) fake-zods after failed hoon.hoon resets.

Hmm, not sure exactly what this is about, but I believe the trace is coming from here:
https://github.com/urbit/arvo/blob/master/sys/vane/clay.hoon?utf8=✓#L3272
%clay is trying to call ++soft to clam a card it received, but the card didn't nest into the kind of card %clay knows how to deal with. The tag on the card was %crud, which sure enough isn't one of the types of ++task clay recognizes, defined in zuse.hoon here:
https://github.com/urbit/arvo/blob/master/sys/zuse.hoon?utf8=✓#L339
It looks like the older versions of clay didn't understand %crud cards either, which I found a little surprising. %eyre and %dill deal with %crud cards, though, and in particular ++task:able:eyre defines a %crud card with an XX rethink comment, so ... maybe we should rethink that.

%crud looks like it's the card type indicating an error, so maybe some other vane errored out in response to a %clay request and sent back a %crud, which %clay didn't know how to handle. Another part of this I don't understand is that the only places I see %crud in the vane interfaces in the master branch are in their ++task sections, not in their ++gift sections, so it seems wrong for another vane to send a %crud, as opposed to knowing how to receive them. Maybe there's some generic error handler in a vane that sends a %crud back to whatever vane sent the request, and in this case it was %clay, despite %clay not knowing how to deal with a %crud.
One thing to try might be to add a debug printf for %crud messages in %clay that prints the stack trace contained in the card, then trigger this crash. @eglaysher do you remember what command you ran to get the crash?

Yes, there are plenty of bugs in bad-event handling in master.
Fortunately, if you grab cgyarvin/remaster for arvo, and cgyarvin/retrofit
for vere, you can run the old interpreter with the latest arvo.  Pills are
on https://bootstrap.urbit.org/${commit}-maint.pill.
On Mon, Oct 2, 2017 at 6:26 AM, Ted Blackman<EMAIL_ADDRESS>wrote:

%crud looks like it's the card type indicating an error, so maybe some
other vane errored out in response to a %clay request and sent back a
%crud, which %clay didn't know how to handle. Another part of this I
don't understand is that the only places I see %crud in the vane
interfaces in the master branch are in their ++task sections, not in
their ++gift sections, so it seems wrong for another vane to send a %crud,
as opposed to knowing how to receive them. Maybe there's some generic error
handler in a vane that sends a %crud back to whatever vane sent the
request, and in this case it was %clay, despite %clay not knowing how to
deal with a %crud.
One thing to try might be to add a debug printf for %crud messages in
%clay that prints the stack trace contained in the card, then trigger
this crash. @eglaysher https://github.com/eglaysher do you remember
what command you ran to get the crash?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/urbit/arvo/issues/432#issuecomment-333533675, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AALyAR_XFbrUgDR-iNrbpBuJwPEM3nqxks5soOSbgaJpZM4PqMtJ
.

Any vane that receives cards from unix (ie, with an entry in +dint:is) must be able to handle a %crud task. As of #900 and #907, they all can.


[Fix] Change the path to pre-trained EDVR-M

Motivation
As discussed in #391, there are additional .modules's  in edvrm_x4_8x4_600k_reds_20200622-ba4a43e4.pth. Therefore, the weights cannot be correctly loaded.
Modification
We manually removed the unnecessary .modules. The path to the modified model is changed.

Any idea on the cause?

Any idea on the cause?

No clue at the moment. It seems not the problem of publish_model. I guess model = model.module is not execute for some unknown reasons.

Would you mind digging into this problem?

Would you mind digging into this problem?

Sure I will try

I tried training the model and there is no error in this current version.
I checked the commit history and found that two EDVR-M models are uploaded in the same commit. It is kind of strange that only one has this problem. May need more time but not sure whether I can figure it out.


MARATHON_SINGLE_INSTANCE_APP should be a property, not a label

See https://mesosphere.github.io/marathon/docs/recipes.html
Why is this a label?

Hi Michael,
this is a good question! We are aware of this and will hopefully refactor this within v3. I`ll close this issue as duplicate of https://github.com/mesosphere/marathon/issues/4225 (your ticket was opened earlier, but @ssk2 has more details).
Kind regards
Johannes


0.5.x: merge PRs

This merges the following PRs:

https://github.com/OISF/libhtp/pull/123
https://github.com/OISF/libhtp/pull/125

ping

Hello, the PR will be merged soon.
We need to run some QA on it.

Could you update this to include #129 ?

Add #122 while at it :)


[FLINK-13903][hive] Support Hive version 2.3.6

What is the purpose of the change
Support Hive 2.3.6, which was released a few days ago.
Brief change log

Added  a new shim for this version

Verifying this change
This change is already covered by existing tests, and manually ran the tests for the version.
Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): (no)
The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
The serializers: (no)
The runtime per-record code paths (performance sensitive): (no)
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
The S3 file system connector: (no)

Documentation

Does this pull request introduce a new feature? (no)
If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

Close this PR as the wrong branch was chosen.


Enable Docker for Llama.cpp Benchmarking

Add docker scripts to benchmark llama.cpp performance for llm models on cuda.

Ready for review! CC: @junrushao

Thanks @zxybazh! Will review tomorrow by trying to actually run it on my 3090ti :)


Unite the way how celebration dates are defined

I think we should unite (and thus define) the way the dates of celebrations are defined. We might use different date definition ways, but I think we should define when which one is better to be used (i.e. because of performance/optimalisation/readability/etc).

For simple (i.e. fixed) dates, we use date: dayjs.utc(```${year}-10-25```), which is good enough IMHO and it is already used consistently.

When the celebration date is not fixed and thus the calculation needs to take into account multiple criteria, currently we use the following three code snippets to define the date. I have no idea which one is better. Note that I have simply copy-pasted these snippets from the codebase.

date: ((y: number): dayjs.Dayjs => {
  const date = dayjs.utc(`${y}-11-1`);
  if (date.day() === 6) {
    return dayjs.utc(`${y}-11-2`);
  } else {
    return date;
  }
})(year),

date: await (async (y: number): Promise<Dayjs> => {
  const firstDayOfOT = dayjs((await Seasons.earlyOrdinaryTime(y,
    config.epiphanyOnSunday))[0].date);
  return firstDayOfOT.add(2, 'week').startOf('week');
})(year)

date: ((): dayjs.Dayjs => {
  const firstDay = dayjs.utc(`${year}-1-1`);
  const feastDay = 22 - (firstDay.day() == 0 ? 7 : firstDay.day());
  return dayjs.utc(`${year}-1-${feastDay}`);
})(),

Actually the 3 are valid, and are different because of the code inside the date function (the use of the y or year argument, in some cases, the use of async functions). When an argument isn't used, it's better not to define it (for nothing) in the function declaration. Same for await/async, when async isn't required. So I won't change anything here.

Actually, I have just found a variation of one of those three date definitions:
date: ((y: number): Dayjs => Dates.pentecostSunday(y).add(1, 'day'))(year),

date: ((y: number): dayjs.Dayjs => Dates.pentecostSunday(y).add(1, 'day'))(year),

I think that the first one of these is better (less chars used) that the other one, however, both of them are used in the source code.


add nav-bar hover color

Issue #3

Pink color hover added
Underline to show current path
Improve selector activeNavbar by DataContextProvider
Abstraction of NavBar items by path on helper file.

https://user-images.githubusercontent.com/11053039/196020637-5ce14c81-982e-4183-8204-7e88ba109008.mov

Thank you for contributing @JABvzla


Add GitHub Enterprise URL support

Thanks for saving me from having to browse GH to find files. We use GHE at work and so we have our own hostname, but everything else works the same. This PR adds support for GitHub running anywhere. Appreciate the work!
Summary

Add support for GHE URLs by parsing remote for host
Use lua pattern matching for parsing remote

Thank you so much @BSathvik for this PR, your changes added support not just for GHE, the plugin now supports gitlab and Bitbucket as well.