Please add tags to this repository at the point of release

Trying to package git-xet and others for distros is a pain because there is no clear release point. I realize binaries are posted on the other repository along with release tags, but they are not reproducible nor do they always match system libraries and compile options. I am able to build Arch Linux packages just fine, but it is unclear what version they are. Typically I take the last commit in here before the version is bumped to the next release, but it isn't always clear if that is what is built and packaged as a release.
Please tag the source repository here with the tag at the point of building a release and posting binaries elsewhere.

Once again having to guess, I released 586264053b96f63a36550aabb4aaf9999e4f053c96dc5e52a1d9c2cffddfbd11 as 0.11.5 to Arch Linux. Please tag this repo when you cut releases. You can still use the GitHub Releases feature on the other repository to post binaries if you want, but a Git tag in the source is needed!

Still a problem. I'm guessing 1f2d3cece736664d155cf991fa952ebfc54d5eb2 for v0.12.0, but this repository still needs tags.

Guessing a2681c8b8dd6396a7128b7b3e4f176e5bf94860a for v0.12.1.

$RANDOM suggests I use 4ba4d135d03ea5d1c58b06993617c87032b1d9fe for v0.13.5.

Added tags since v0.11.0. Thank you!

Fantastic, thank you!

The v0.12.6 release marked over on the issue stub repository did not get tagged here. I guess some port of the release workflow needs updating: whether that is automation or release documentation or whatever.

Tagging is not built into our automatic release workflow yet so there will be some delay for manual tagging.

Some delay is okay as long as it doesn't get overlooked. Is there a release checklist / workflow document of some kind that gets followed where it could be added, preferably even before the other stub repository gets a tag? That would make the most sense since having binary builds before the tag shows up is kind of strange.

Hello @alerque -- we're currently looking into revamping this workflow.  Stay tuned for a better end-to-end process here.

This is in our runbook, and I believe the last few versions should be consistently tagged now. Closing this issue. Thanks!


Make the default state of a VM configurable when removed by hypervisor in hybrid deployments

Description
Currently the default state of a VM is UNKNOWN when the VM is removed by the hypervisor in hybrid deployments. This causes OpenNebula to continue considering the VM as RUNNING.
Use case
The user wants OpenNebula to consider a VM as POWEROFF when removed by the hypervisor. This configuration will survive upgrades.
Interface Changes
Configuration.

Progress Status

[ ] Branch created
[ ] Code committed to development branch
[ ] Testing - QA
[ ] Documentation
[ ] Release notes - resolved issues, compatibility, known issues
[ ] Code committed to upstream release/hotfix branches
[ ] Documentation committed to upstream release/hotfix branches

This can be already tuned for each driver:

Azure: https://github.com/OpenNebula/one/blob/master/src/im_mad/remotes/az-probes.d/vm/status/probe_vm_status.rb#L47
EC2: https://github.com/OpenNebula/one/blob/master/src/im_mad/remotes/ec2-probes.d/vm/status/probe_vm_status.rb#L47

It needs to reflect the actual desired behavior of each driver.


[BUG] Fails to parse multiple binary + unary operators

Describe the bug
When there is a binary operator (such as ==) directly followed by a unary operator (such as !), the code panics saying that it cannot find the ==! operator.
Raven Code To Reproduce
import stdio;

fn main() {
    let t = true;
    let f = false;
    if t == !f {
        printf("Passed!");
    } else {
        printf("Failed!");
    }
}

Error Output or Unexpected Behavior
thread 'main' panicked at language\data\src\lib.rs:178:13:
Missing file: Failed to find operation {}==!{} with [LoadVariable("t"), LoadVariable("f")]

Additional context

A quick look-through at the parser and the issue might be around lines 24-26. When parsing operators, they are parsed if it is already an operator, or equals, or period, without respect to anything else. that means == ! is being parsed as TokenTypes::Equals, TokenTypes::Equals, TokenTypes::Operator, all of which mistakenly get added to the operation in total to become the operation ==!. There might be a couple more places in the code where something like this can happen mainly line 97.
More logic might need to be incorporated there to determine whether the next token actually should be added to the operation or not.


Use nbval on the CI

This would have helped catch this issue: https://github.com/bqplot/bqplot/pull/1296

Note that I run nbval on examples/Marks, because some of the more complicated examples are fetching data online, which could lead to unwanted network errors on the CI.


No package yajl-ruby available in CentOS.

The package yajl-ruby isn't available in CentOS. it can be installed in the end with:
gem install yajl-ruby

What's the problem you're trying to fix? Nothing seems to break without manually installing this gem

The package yajl-ruby isn't available in CentOS.
When you do :
yum install yajl-ruby

the package is not found, so you need to install it with gem.
I only use the official CentOS repository. Do you use additional repositories like rpmfusion etc?

I don't think yajl-ruby needs to be installed anyway. It wasn't probably needed ...

If is not needed it, probably the best move is to remove it from the dependencies, in order to keep the documentation updated. Can you confirm that?

@d do you have any new information about this topic?


Fix #60 - rewrite for createClient()

First off, great work to the creators and or maintainers. I've relied on this project for a few years on numerous projects, it's been awesome, I'm glad that I can contribute here.
The issue started when key_file was allowed to be an array, the code was changed and we ran into the original array_merge issue #57 & #59 that I had created. The error was that array_merge would throw an exception that its given parameters could not be null. The fix was to write an is_array check, and if it failed then it would set $keyFile to an empty array.
While this fixed the array_merge issue, it did not fix the underlying problem, which was that the code, currently, will always return a new StorageClient with a key_file. Even if it is null, as long as the key 'key_file' exists the constructor array, the Google\Cloud\Storage\StorageClient will try to look for it, and it will fail throwing null errors on missing or incorrect data. This prevents and breaks all built-in service accounts from working without explicitly setting a .json file.
Now the key_file parameter (while it may work if a file path is passed into it, not sure) is actually for passing in the config in an array directly (like it says in the laravel-google-cloud-storage readme), and key_file_path is for the file path of the json file that Google\Cloud\Storage\StorageClient->Google\Cloud\Core\ClientTrait::getKeyFile() will read and run a json_decode(file_get_contents(key_file_path) on to get an array of parameters.
I rewrote createClient() to do the following (in pseudo code below)
`
get from config key_file_path
if is_string(key_file_path) and key_file_path is not empty()
Give us our storage client and tell Google to use our key_file_path file
if that fails
get from config key_file
if is_array(key_file) and key_file_path is not empty()
Give us our storage client and tell Google to use our key_file array as its config
if that fails
Give us our storage client and tell google we don't have any configuration to give it
`
Now that since Google didn't receive any configuration (given key_file_path and key_file are null), it searches on its own (GOOGLE_APPLICATION_CREDENTIALS, well known OS specific files, and built-in service accounts). With this patch, everything works as expected from the README.
That should bring this issue to a close. Sorry if my php-cs-fixer formatted the code base. It was automatic. I updated the readme to reflect the changes in the config, to match the new code, as well as updating the changelog.

Turns out, you can pass null into key_file for the StorageClient and \Google\Cloud\Storage will still look for credentials on the server and not throw an error.
The issue before is that there was an array_merge(project_id, []) so that key_file contained a value which caused it to fail. Since it always defaulted null (in the config) in the case of Google App Engine or Google Compute Engine instances, the fix for the array_merge null issue was to make it an empty array and still merge it with the project_id, causing it to still fail


Add support for "{target}" to the --extern-html-root-url cargo passes to rustdoc (through doc.extern-map.registries)

Describe the problem you are trying to solve
docs.rs would like to link to builds for specific targets, since not all targets have the same documentation: https://github.com/rust-lang/docs.rs/issues/1397#issuecomment-860065315. However, this requires more flexibility in the URL than cargo currently allows. It would be great if -Zrustdoc-map added support for this so we don't have to go back to adding --extern-html-root-url by hand (which was quite buggy).
Describe the solution you'd like
Add support for {target} to doc.extern-map.registries. It should have the following behavior:

When using cargo doc --target x, replace {target} with x in the remapping.
When using cargo doc alone, without --target, remove {target} altogether.

I don't have strong opinions on 2 (docs.rs will work even if it's replaced with the host target) but it seems like a reasonable behavior.
Notes

I am interested in implementing this myself.

Err actually I just realized docs.rs can do this without changes to cargo, so it's probably not necessary, we can just pass --config=doc.extern-map.registries.crates-io="https://docs.rs/{pkg_name}/{version}/hardcoded_target".

Err @Nemo157 mentions this could still be useful for people other than docs.rs (e.g. building a crate on a target other than the package.metadata.docs.rs.default-target should probably link to that specific target). So it would be nice for this to be part of the default map for docs.rs.

@rustbot claim


Add release notes for SDK 2024.02

Unfortunately, @rpaladin no longer has time to work on the monthly release notes (thanks for your work again!), which is why I'm doing them this month :)
I'm currently working on a script that automatically fetches update information from GitHub so that the only manual tasks left for creating release notes are creating the header image, screenshots and writing a small summary (if wanted). I hope to have it ready until March.

Many thanks!


Fixed panel for better player status info

Would be great to have a fixed top panel above the map with "boxes" per player. Ideally players would identify themselves by their player skin.

Done.


Many errors while running unit tests on A100 and V100

Hi there,
I see a lot of failed unit tests on A100 and V100.
Summary reports are the follows:
A100 ():
= 31 failed, 109 passed, 36 skipped, 142 warnings, 1 error in 274.41s (0:04:34) =

V100:
===== 18 failed, 121 passed, 38 skipped, 152 warnings in 428.86s (0:07:08) =====

The full test logs are attached
artifact-levanter-unit-test-V100.zip
artifact-levanter-unit-test-A100.zip

Thanks! This should fixed when #468 lands I think. It's just tolerances that are too tight for GPU...

We merged #468 so this should hopefully be much better!

These are mostly fixed. a few small tests are still failing

UPD(05/09/2024): the latest runs on A100 and V100 (link):
V100

pytest tests -m entry -- passed (runs only 5 tests)
pytest tests -m "not entry and not slow and not ray" -- fails (4 tests fails):

=========================== short test summary info ============================
FAILED opt/levanter/tests/test_attention.py::test_llama_attention_uses_te[1]
FAILED opt/levanter/tests/test_attention.py::test_llama_attention_uses_te[2]
FAILED opt/levanter/tests/test_attention.py::test_llama_attention_uses_te[4]
FAILED opt/levanter/tests/test_attention.py::test_gpt2_attention_uses_te - Va...
= 4 failed, 148 passed, 46 skipped, 22 deselected, 304 warnings in 293.16s (0:04:53) =

A100

pytest tests -m entry -- passed (runs only 5 tests)
pytest tests -m "not entry and not slow and not ray" -- fails (1 test fails):

FAILED opt/levanter/tests/test_hf_checkpoints.py::test_save_sharded_checkpoints
= 1 failed, 152 passed, 45 skipped, 22 deselected, 308 warnings in 246.20s (0:04:06) =

Q: Having info above, what unit-tests do you suggest to run in Jax-Toolbox?

the v100 tests are concerning. we do expect te flash attention to work on v100s?
=========================== short test summary info ============================
FAILED opt/levanter/tests/test_attention.py::test_llama_attention_uses_te[1]
FAILED opt/levanter/tests/test_attention.py::test_llama_attention_uses_te[2]
FAILED opt/levanter/tests/test_attention.py::test_llama_attention_uses_te[4]
FAILED opt/levanter/tests/test_attention.py::test_gpt2_attention_uses_te - Va...
= 4 failed, 148 passed, 46 skipped, 22 deselected, 304 warnings in 293.16s (0:04:53) =
I don't know why the save_sharded_checkpoints is failing. Could be a device thing I missed since we run most tests cpu only typically

we do expect te flash attention to work on v100s?

Yes, I think so

Both FlashAttention and TE's cuDNN-based attention don't support V100


Consider adding Equatable to generated models

Would it be a good idea to add Equatable to the generated models / types?
I ran into an issue where I reused meta.v1.Condition in one of my custom CRDs in the status property and wanted to compare if the status had changed. For that I had to implement the Equatable conformance manually.

I've already implemented this 😄. All the kubernetes resources will be Hashable.
I haven't pushed it yet, because I'm still testing and deciding if there is a better solution, than the one I made.


Publish mermaid-editor on https://open-vsx.org/

Describe the bug
I'm using https://vscodium.com/ which in turn uses https://open-vsx.org/
Right now mermaid-editor isn't easily installable with that setup. Any chances of seeing this plugin in open-vsx ? Thanks in advance !
Desktop (please complete the following information):

OS: Ubuntu
VSCode version: VSCodium

Hi @arthurzenika , thank you for the information. I never knew that before. I finally published the extension to ovsx too. Please check it on mermaid-editor on open-vsx.org!

That's awesome ! Thanks @tomoyukim !


Upgrade Demo build tools

The demo currently uses Webpack 3 and has audit problems. It's build tooling should be upgraded.

Migrated to CRA - https://github.com/JSainsburyPLC/react-timelines/pull/109


[Android] Generate model to hold optional parameter to REST call

The model name
setters
no Ctr (default is fine) or required arguments.

Upon discussion within autorest.java group, we agreed this is no longer required


Make Breps faster

I have benchmarked the speed of all the lading steps (breaking down the buildGeometry function):

There are many places where the code can be improved, but one of the places I am most aware of is the generation of Breps. As you may know, breps are geometries defined by planes in space. The problem is that Three.js is only capable of constructing triangles in space, and the planes of Breps can have more than three points. So the current implementation runs a rather expensive algorithm using quaternions. This algorithm is something I borrowed from here.
Nonetheless, there is a much more efficient way to create geometry without the need to use this algorithm: triangulating all the faces and generating the geometry directly. For this, we need to triangulate the points, which is a challenging task that, fortunately, has already been addressed by others.
I will play around these days with this idea.
BTW: I am not sure if we should generate the edges or bring this outside to the example. It slows things down an this is something the user can implement if they want.

I have a first implementation of the algorithm, and I am very happy with the result.

This looks very similar to the geometry generated with the previous algorithm, but faster. To be precise, 5 times faster.

This speed improvement depend on the object, but if I load a scene full of breps, we can see that the gain is substantial:

Obviously, the more breps, the more the gain. But this is not the most important part of this implementation. This algorithm is able to take an arbitrary array of faces (defined by points) and construct the geometry really fast. My idea is that this will substitute the rest of geometry generators, so in the end all IFC entities will be defined as an array of vertices and constructed using this. This will make the code for geometry generation much shorter, cleaner and faster.
I still need to implement the interior holes for the faces.

Before:

Now:

looking good.

I have pushed the changes with the first implementation of the algorithm. I will try to use this to generate all other geometries to make everything faster and cleaner.


Switch to updated GitHub Actions logic for storing output

Resolves warning about set-output being deprecated using new logic defined in https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

Deployed on staging, this worked as expected


wg_engine: memory leak?

Need to clarify the memory leaks report.
Test 'Shape' webgpu with this build:
meson setup build -Dexamples=true -Dloaders=all -Db_sanitize="address,undefined" -Dengines="wg_beta"

Direct leak of 88 byte(s) in 1 object(s) allocated from:
    #0 0x7f687ee39887 in __interceptor_malloc ../../../../src/libsanitizer/asan/asan_malloc_linux.cpp:145
    #1 0x7f687c15b5ac in wgpuSurfaceGetCurrentTexture (/usr/local/lib/libwgpu_native.so+0x1025ac)
    #2 0x7f687d4e137a in tvg::Canvas::Impl::sync() ../src/renderer/tvgCanvas.h:129
    #3 0x7f687d4e137a in tvg::Canvas::sync() ../src/renderer/tvgCanvas.cpp:86
    #4 0x5633152527bf in tvgexam::Window::ready() ../examples/Example.h:187
    #5 0x563315243506 in tvgexam::main(tvgexam::Example*, int, char**, unsigned int, unsigned int, unsigned int, bool) ../examples/Example.h:533
    #6 0x563315246a67 in main ../examples/Shape.cpp:56
    #7 0x7f687b5d6d8f in __libc_start_call_main ../sysdeps/nptl/libc_start_call_main.h:58

Direct leak of 32 byte(s) in 1 object(s) allocated from:
    #0 0x7f687ee39887 in __interceptor_malloc ../../../../src/libsanitizer/asan/asan_malloc_linux.cpp:145
    #1 0x7f687c14cf2b in wgpuDeviceCreateBindGroupLayout (/usr/local/lib/libwgpu_native.so+0xf3f2b)

Direct leak of 32 byte(s) in 1 object(s) allocated from:
    #0 0x7f687ee39887 in __interceptor_malloc ../../../../src/libsanitizer/asan/asan_malloc_linux.cpp:145
    #1 0x7f687c156096 in wgpuDeviceGetQueue (/usr/local/lib/libwgpu_native.so+0xfd096)
    #2 0x7f687d8a669a in WgRenderer::target(WGPUInstanceImpl*, WGPUSurfaceImpl*, unsigned int, unsigned int, WGPUDeviceImpl*) ../src/renderer/wg_engine/tvgWgRenderer.cpp:299
    #3 0x7f687d588b19 in tvg::WgCanvas::target(void*, void*, unsigned int, unsigned int, void*) ../src/renderer/tvgWgCanvas.cpp:73
    #4 0x563315259063 in tvgexam::WgWindow::resize() ../examples/Example.h:446
    #5 0x563315259063 in tvgexam::WgWindow::WgWindow(tvgexam::Example*, unsigned int, unsigned int, unsigned int) ../examples/Example.h:433
    #6 0x563315243209 in tvgexam::main(tvgexam::Example*, int, char**, unsigned int, unsigned int, unsigned int, bool) ../examples/Example.h:528
    #7 0x563315246a67 in main ../examples/Shape.cpp:56
    #8 0x7f687b5d6d8f in __libc_start_call_main ../sysdeps/nptl/libc_start_call_main.h:58

Direct leak of 1 byte(s) in 1 object(s) allocated from:
    #0 0x7f687ee3b1e7 in operator new(unsigned long) ../../../../src/libsanitizer/asan/asan_new_delete.cpp:99
    #1 0x7f687d588777 in tvg::WgCanvas::WgCanvas() ../src/renderer/tvgWgCanvas.cpp:43
    #2 0x7f687d5897b3 in tvg::WgCanvas::gen() ../src/renderer/tvgWgCanvas.cpp:89
    #3 0x563315258624 in tvgexam::WgWindow::WgWindow(tvgexam::Example*, unsigned int, unsigned int, unsigned int) ../examples/Example.h:425
    #4 0x563315243209 in tvgexam::main(tvgexam::Example*, int, char**, unsigned int, unsigned int, unsigned int, bool) ../examples/Example.h:528
    #5 0x563315246a67 in main ../examples/Shape.cpp:56
    #6 0x7f687b5d6d8f in __libc_start_call_main ../sysdeps/nptl/libc_start_call_main.h:58

Seems to all there is not a problem of ThorVG WebGPU renderer.
Just double check in the standalone simple application with SDL2+WebGPU configuration.
We have same mem leaks messages that related to surface, bindg roups and instance:
Direct leak of 227480 byte(s) in 2585 object(s) allocated from:
    #0 0x7f814d857b37 in malloc ../../../../src/libsanitizer/asan/asan_malloc_linux.cpp:69
    #1 0x7f814d2295ac in wgpuSurfaceGetCurrentTexture (/usr/local/lib/libwgpu_native.so+0x1025ac) (BuildId: 58b0b1d195679188b7050149b69ce5c85fef86b1)
    #2 0x55fb76708631 in __invoke_impl<void, main(int, char**)::<lambda()>&> /usr/include/c++/13/bits/invoke.h:61
    #3 0x55fb767084d1 in __invoke_r<void, main(int, char**)::<lambda()>&> /usr/include/c++/13/bits/invoke.h:150
    #4 0x55fb76708260 in _M_invoke /usr/include/c++/13/bits/std_function.h:290
    #5 0x55fb767089a9 in std::function<void ()>::operator()() const /usr/include/c++/13/bits/std_function.h:591
    #6 0x55fb76706eec in mainLoop(std::function<void ()>) ../src/main.cpp:106
    #7 0x55fb76707e6d in main ../src/main.cpp:166
    #8 0x7f814cab71c9 in __libc_start_call_main ../sysdeps/nptl/libc_start_call_main.h:58
    #9 0x7f814cab728a in __libc_start_main_impl ../csu/libc-start.c:360
    #10 0x55fb76705ae4 in _start (/home/sliebodkin/projects/local/webgpu-sdl2-app/builddir/webgpu-cpp-app+0x4ae4) (BuildId: d231b43a71572b3e90b4dec65b71c35da5d66b0d)

Indirect leak of 24 byte(s) in 1 object(s) allocated from:
    #0 0x7f814d857b37 in malloc ../../../../src/libsanitizer/asan/asan_malloc_linux.cpp:69
    #1 0x7f814d224cfa in wgpuInstanceCreateSurface (/usr/local/lib/libwgpu_native.so+0xfdcfa) (BuildId: 58b0b1d195679188b7050149b69ce5c85fef86b1)
    #2 0x55fb767079e6 in main ../src/main.cpp:126
    #3 0x7f814cab71c9 in __libc_start_call_main ../sysdeps/nptl/libc_start_call_main.h:58
    #4 0x7f814cab728a in __libc_start_main_impl ../csu/libc-start.c:360
    #5 0x55fb76705ae4 in _start (/home/sliebodkin/projects/local/webgpu-sdl2-app/builddir/webgpu-cpp-app+0x4ae4) (BuildId: d231b43a71572b3e90b4dec65b71c35da5d66b0d)


Question

How to visualize the extracted features?

You can normalize the features to 0-1 and store the image

Thanks！！！


Added the domains module

Context
This configuration deploys the Azure Front - which is a Content Delivery Network (CDN) that provides fast, reliable and secure access between user and Applications static and dynamic web contents.
Changes proposed in this pull request
Added a 'domains' folder in the terraform directory that contains the configuration for the change above.
Guidance to review
Include any useful information needed to review this change.
Include any dependencies that are required for this change.
Checklist

[ ] Attach to Trello card
[ ] Rebased main
[ ] Cleaned commit history
[ ] Tested by running locally

Hi @johnake — could you fill out the PR description a bit? Nothing too heavy needed, just a basic description of what this is and why we're adding it.

 Deploy AKS infra resources


Is it possible to flash on PICO-i.MX7D board from Android Things?

Hi,
I have an Android Things kit lying around which is PICO-i.MX7D board. Since Google killed the project, I was hunting for an idea to make some use of it, and looking at this opportunity makes perfect sense :D
What would I need to change to run on that board? I'm hopeful I could get some Linux version on that board. Or is the image with some additional config enough?

You can check if the upstream buildroot supports this board. If it has support for it, you might be able to setup and build for it.

I don't have the board to test. Do let us know if you ever get it working.


list_by_resource_group of azure-mgmt-resource does not work correctly

Package Name: azure-mgmt-resource
Package Version: 20.0.0
Operating System: Linux
Python Version: 3.6.9

Describe the bug
Resource Management Client's list_by_resource_group() API does not list all resources correctly. This has been observed with Microsoft.Compute/disks resource types. There are 2 OsDisk resources created for each VM instance in the resource group, however the list operation only returns the OS Disk associated with the first VM.
To Reproduce
def list_resources_in_group(resource_group):     try:         resource_list = []         resources = resource_mgmt_client.resources.list_by_resource_group(resource_group)         for res in resources:             print(res)             print("\n")     except ResourceNotFoundError as err:         print("Resource Not Found")     except Exception as err:         print(err)
Expected behavior
All resources in resource group should be listed.
Screenshots
Attached is a screenshot showing the OS Disk resources shown in the portal that is associated with the 2 VM instances. Also attached is the output of the code which only lists one of the OS Disk resources.
Additional context
Add any other context about the problem here.

out.txt

@msyyc could you please take a look?

Hi, Python SDK is generated automatically with swagger. Since SDK team can't reproduce your error, we should think about whether it is problem of service. You could use rest api to call service directly and see the return result.
If result is expected, it proves that SDK has problems;
If result is not right, it proves that service has problem. Then you could make issue in https://github.com/Azure/azure-rest-api-specs to ask help from service team.

I notice different behaviour with different APIs - REST, Az CLI and Python SDK. None of them results in the expected output. I will also raise this issue with the service team as suggested. Thanks.

Hi @ksridhar57, I noticed your out Txt file has detailed output. Is it obtained through the python SDK?
If so, you can see that the name value in each dictionary returned roughly corresponds to the name in your screenshot above.
Did you do the operation at the same time without changing the resources?
Thank you for providing more information to help us solve this issue faster.


Documentation issues

Disclaimer: These aren't necessarily all issues but there are issues I found that if changed would make the process easier to follow.
Create a virtual machine.
4.In the Basics tab, use the VM settings as specified in the table below the image:
maybe add a section for specifying size b/c mine chooses an excessively large VM by default.
should add a red outline to clarify where to go for:
select Create new to configure a new virtual network

9.Choose the Management tab, then in Diagnostic storage account, choose Create new to create a new Storage account.
is redundant. this is done by default and could be encompassed in:
10.Leave the default values for the Identity, Auto-shutdown, and Backup sections.
if it's there for visibility.
Create an Azure Functions app
This section lacks the graphics that previous steps offer (just noting b/c of consistency).
Specifically, Step 1. mention of the Platform Features tab
This section doesn't reflect the new layout of the Azure Function journey page.
Configure Access Restrictions
Nothing in these steps mentions adding the Priority or Name (documentation consistency)
I was able to create without giving this Rule a Name. is that supposed to work?
Step 4. should specify the Tutorial Subnet instead of being vague. there were 2 created.
Should maybe add something about his message I got when following along
Selected subnet 'secure-function-vnet/Tutorial' does not have service endpoint enabled for Microsoft.Web. Enabling access may take up to 15 minutes to complete.
Not sure how this Important section is relevant unless there is some relation to doing something with the rules under the <FUNCTION_APP_NAME>.scm.azurewebsites.net tab.
Important
Each function app has an Advanced Tool (Kudu) site that is used to manage function app deployments. This site is accessed from a URL like: <FUNCTION_APP_NAME>.scm.azurewebsites.net. Because access restrictions haven't been enabled on this deployment site, you can still deploy your project code from a local developer workstation or build service without having to provision an agent within the virtual network.

There is a sentence starting with Because. (not an English stickler but I noticed)
Access The Functions App
Step 1. The image doesn't match the new layout of the Azure function Journey page.
Step 4. mention you need to be on the VM journey page. The uses of bold text here I find are distracting, pulls my eyes and I start jumping to conclusions (i thought I needed to go to the Bastion resource haha). This could be clearer with an additional image to show where the focus has moved to.
Step 5. from my understanding this says I should be getting a 403 but I got the "Your Functions 3.0 app is up and running"
Create a function
Step 1. all of these options are overkill and takes time away from what users can here to learn. The easiest function to create is the default HttpTrigger in the browser.
Also, all of these links go to the same page.
Invoke the function directly
this Note is very specific. I did this with the js Http trigger and the message after testing gave me a better message
You must have direct network access in order to run your function. Your app may be restricted with Private Endpoints, Access Restrictions or Service Endpoints.Learn more

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: bcef3f76-93ec-884a-b808-96a2c4f924c0
Version Independent ID: ddcb71ec-361e-c724-bc50-85c57882d065
Content: Enable private site access to Azure Functions
Content Source: articles/azure-functions/functions-create-private-site-access.md
Service: azure-functions
GitHub Login: @mcollier
Microsoft Alias: mcollier

@Mexicoder Thank you for your feedback! We have assigned this issue to the author to review further and take the right course of action.
cc: @ggailey777  @craigshoemaker

Thank you for the detailed feedback, @Mexicoder.  The document has been updated and includes many of your suggestions. I'm going to #please-close this issue for now. If you feel anything else requires more attention, please feel free to re-open this issue.
Thanks again!!


Fixing TSHttpTxnServerAddrSet

PR #9054 broke hostdb behavior for TSHttpTxnServerAddrSet(). This fixes the behavior and adds a regression test for the API.

@fatih-acar : I'm ready to merge this, but I don't have access to machines that use parent selection. This shouldn't break parent selection, but I'd feel more comfortable merging this if you or someone with your organization can confirm that for me before I merge.

Hello @bneradt thanks for following up
You can move on with this. As you pointed out, it was not the right patch for our initial issue. I have created a new PR which should be the right one: https://github.com/apache/trafficserver/pull/10234 (note: I'm not sure with the approach but I've described the actual issue in the commit message so feel free to propose another solution).

Hello @bneradt thanks for following up You can move on with this. As you pointed out, it was not the right patch for our initial issue. I have created a new PR which should be the right one: #10234 (note: I'm not sure with the approach but I've described the actual issue in the commit message so feel free to propose another solution).

Thank you @fatih-acar for the quick reply.


Type not inferred correctly in false branch of conditional when using type with union (javascript with types)

Bug Report

🔎 Search Terms

literal types, boolean, conditional operator, union
🕗 Version & Regression Information

This is the behavior in every version I tried, and I reviewed the FAQ for entries about Type System Behavior

⏯ Playground Link

Playground link with relevant code
💻 Code

/**
 * @typedef {{isSingleValue: true, result: number} | {isSingleValue: false, result: number[]}} T
 */

/**
 * @returns {T}
 */
function makeT() {
    return {isSingleValue: true, result: 3};
}

var t = makeT();

var v = t.isSingleValue ? t.result : t.result[0];

(javascript with type checking)
🙁 Actual behavior

Got an error:
Element implicitly has an 'any' type because expression of type '0' can't be used to index type 'number | number[]'.
  Property '0' does not exist on type 'number | number[]'.

This is wrong because isSingleValue being false means that t.result must be number[] instead of number | number[].
This bug doesn't occur with just typescript:
Playground link with typescript example (that works as expected)
🙂 Expected behavior

No error, the type checker can infer that t.result is a number[] because isSingleValue is false. This is what happens with just typescript instead of javascript with types (see link playground link above for typescript example working as expected).

Just for future reference: This is a discriminated union.  Conditional types are something different.

You have strictNullChecks disabled. Once enabled the code works as expected. Without it, true is not the only valid value for the true case, but undefined and null are valid as well. If you don't want to enable it, you need to explicit check for true by writing t.isSingleValue === true.


Geometry and Geography typenames are not supported

Driver version or jar name
mssql-jdbc-66.2.2.jre8
SQL Server version
tested with SQL Server 2014
Client operating system
Windows 10 x64
Java/JVM version
java version "1.8.0_144"
Table schema
CREATE TABLE [dbo].[my_table]([GEOM] [geography] NULL)
Problem description
SQLServerPreparedStatement.getParameterMetaData() will fail if SQLServerPreparedStatement was prepared using a query that contains geometry or geography column types.
Seems that the source of the issue is, our resultSet from "exec sp_describe_uneclared_parameters ?") returns a typename of "geometry" or "geography".
DataTypes.SSType does not have these value, and therefore an exception is thrown.
Expected behavior and actual behavior
expected -- the method returns a SQLServerParameterMetadata successfully (for reference, the JDBCType for geography was VARBINARY in sqljdbc41.jar)
actual -- the following exception was thrown:

Caused by: com.microsoft.sqlserver.jdbc.SQLServerException: A metadata error for the parameter {0} occurred.
at com.microsoft.sqlserver.jdbc.SQLServerParameterMetaData.parseQueryMeta(SQLServerParameterMetaData.java:289)
at com.microsoft.sqlserver.jdbc.SQLServerParameterMetaData.(SQLServerParameterMetaData.java:573)
at com.microsoft.sqlserver.jdbc.SQLServerPreparedStatement.getParameterMetaData(SQLServerPreparedStatement.java:2799)
at COM.safe.fme.JdbcBackendHelper.bindValues(JdbcBackendHelper.java:1204)
... 3 more
Caused by: com.microsoft.sqlserver.jdbc.SQLServerException: Invalid SQL Server data type geography.
at com.microsoft.sqlserver.jdbc.SQLServerException.makeFromDriverError(SQLServerException.java:227)
at com.microsoft.sqlserver.jdbc.SSType.of(DataTypes.java:185)
at com.microsoft.sqlserver.jdbc.SQLServerParameterMetaData.parseQueryMeta(SQLServerParameterMetaData.java:242)
... 6 more

Repro code
for example, using the above table schema, create a prepared statement with a query of INSERT INTO [my_table] ([GEOM]) VALUES (?)
sqlServerConnection = getSQLServerConnection(); // set up SQLServerConnection
PreparedStatement statement = sqlServerConnection.prepareStatement("INSERT INTO [my_table] ([GEOM]) VALUES (?)");
statement.setQueryTimeout(5000);
ParameterMetaData metaData = statement.getParameterMetaData(); // ---> this throws an exception

Hi @jpoernomoatsafe, thanks for creating this issue. We are currently working on adding support for Geometry/Geography datatypes, and will let you know once they are under review / merged into preview.

Hi @jpoernomoatsafe, I've merged in the initial implementation for supporting Geometry/Geography datatypes into Spatial_Datatypes branch. This branch will not be merged into preview for now - but please feel free to use/test it.

Geometry/Geography types are supported starting from preview release v6.5.0. Closing this issue.


[Discussion] React Native Controllers Evolution

During the last few months we’ve been hard at work on a native navigation solution for Android. Working on both platforms in parallel introduced new challenges and helped us better understand how this entire project should be split up.
We’re currently thinking about merging react-native-controllers into react-native-navigation. This will make the codebase much simpler and unify the API between iOS and Android, while maintaining the native differences in UX between the two platforms.
This will naturally be a major version that will break some API’s that no longer make sense. In addition, there are many major features (like Screen lifecycle - onAppear, onDisappear events) that we held off until we figure out how Android fits into things. Introducing these features will require significant architecture changes, and doing these with Android around the corner did not make sense. All of these missing major features will now enter active development as the new architecture is finalized, along with all issues and pull requests.
We’d love to hear your feedback about evolving this library to the next level correctly. If you have ideas, questions or concerns please add them to the discussion in this issue.

@drorbiran First of all, thanks for great component! I don't understand why it is discontinued and will became as part of something other component. I like JSX-based declarative syntax and don't like syntax of react-native-navigation.
Anyway I understand that you want to make native navigation cross-platform and hide implementation details this way. But why to invent bicycle and new syntax? As author of react-native-router-flux (RNRF) I propose you to unite our efforts. RNRF provides abstract well-defined declarative JSX-based syntax to define all your scenes with hierarchical manner (yes, mobile navigation is hierarchical with possible very deep structure, so i don't understand why react-native-navigation doesn't allow to insert drawer controller into navigation controller for example). Also RNRF has great big community and i believe many of developers will really want to use Native Navigation instead of JS one.
RNRF's v1 version is based on native Navigator, v2 is based on exNavigator component and v3 is based on new NavigationExperimental API (that based on JS navigation). I don't think that v4 version could be good idea for RNRF, so created another project for Native Navigation (RNRN): https://github.com/aksonov/react-native-router-native based on forked version of react-native-controllers (to allow nested controllers and much much more).
So we could join our efforts and make RNRF available for both iOS and Android.

Sounds like a good plan. I definitely support merging the two libraries.

I don't mind the syntax either. The performance is the only thing we care versus RN's navigator because your app's user don't care about your code style, they care about the user experience.

Facto, I turned here from react-native-navigation, you guys are great even better after merging projects, I guess.

We really appreciate your input and your contributions! All your inputs and concerns will be  addressed and this is the exact reason we created this issue. We feel your pains.
Both of the projects (react-native-navigation and react-native-controllers) grew organically and, along with the react-native platform as a whole, was kinda "proof of concept"-ish. This includes not having tests (!), not having unified API, and in general messy at times, without well defined platform agnostic concepts. Additionally, we want to avoid maintaining multiple projects which under the hood just address the same skeletal structure of a single application.
One of the major architectural issues I want to address by making the merge is the syntax we use. In my opinion all commands flowing to the native core should be imperative.
The reasoning behind this is pretty simple: under the hood, all native code by definition is imperative. The declarative JSX syntax is and should be a wrapper around the imperative core, and should manage the deltas himself and send the appropriate commands to the core.
This is exactly the opposite of what happens here today. We have this awesome react-native-controllers library, which receives declarative JSX syntax, which is really a low-level API around iOS structured components, and sends it to be handled by the native ObjC code. On top of it we have react-native-navigation, which should hide platform specific code, receives commands imperatively and does weird voodoo to send those commands to controllers.
This is, in my opinion, completely upside down.
On top of all that, the current JSX syntax implementation (by hijacking the react import) is smelly and hard to maintain.
I think that wrapping the imperative api with something that can parse JSX, keep a "shadow skeleton", find the deltas, and convert it into react-native-navigation commands is indeed doable and encouraged (and not that hard), and we are planning to do just that in the future (using the help of this great community).
Unfortunately, this comes second to the fact that we must accomplish a few things as a top priority:

merge these 2 projects to a single code base (both in git and in npm)
clean the project up by separating the code into well defined concerns (making the code as SOLID as possible)
consolidate duplications and multiple intersecting pathways, while trying to stay as un-opinionated as possible
define general platform-agnostic concepts, which will make the code easier to reason about
adding tests - this is important because other than "feel good" trust of the code, helping with bug hunts and making sure the code is SOLID, this will help greatly in accepting pull requests from the community, as we will automatically run all tests on a dedicated build-server on each PR
Upgrading to the latest stable RN version - this will solve a lot of bugs and clean up some of the hacks
address some major bugs and PRs from the community and become more "community-friendly" in general

As for flexibility - I completely agree, up to a certain point. We must remember that we are after all living inside a native app and some things just do not work, and trying to force some things will cause you to "fight" with the system, and once you start fighting the system you'll never get out of it. The whole point of this project is to make our apps feel "native" to our users. Otherwise we would just hack away everything is JS.
So flexibility really should be a case-by-case examination and should be addressed by specific issues. Most of the time when things aren't supported by the platform, I guess will become some kind of a compromise. But we will always strive to be as un-opinionated as possible.
Most opinionated stuff we do right now are "quick-wins" (read - hacks) required for our production and will be generalised as part of the merge.

One possible future I see for this project is to keep it in it's current state, accept some of the community as collaborators, and let you manage it freely. This then should be completely separate from our implementation that will be seated in react-native-navigation.
I think this is a good win-win scenario and will allow you to choose between the 2 projects, if you really MUST have the JSX syntax right now. Keep in mind we will still concentrate our efforts on the one true 100% native navigation solution ;)

all of this looks good. However, where is the Android project, not everybody uses IPhones, there are couple or more users who do use Android phones and tablets... and we have the same problems to solve....


Question

"as well as the internet in the user’s organization."
I wonder if it refers to the intranet?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 1df67176-e302-f972-dbf7-d7e0747e5bd2
Version Independent ID: e213129d-0fb1-31ee-a654-091d032c2746
Content: Set up Microsoft Search
Content Source: MicrosoftSearch/setup-microsoft-search.md
Service: mssearch
GitHub Login: @adefowler
Microsoft Alias: anfowler

Internet is intended here as Microsoft Search in Bing allows for internet search in combination with intranet, but I do see how the rest of the sentence makes this confusing. We will make that clearer.


[VS Code]

Error:
[Description of error message]
Steps to Reproduce:
1.
2.

Version Data

extensionName
VSLS

extensionVersion
1.0.826

protocolVersion
2.2

applicationName
VSCode

applicationVersion
1.38.1

platformName
Windows

platformVersion
10.0.17134

Thanks for reporting this issue! Can you please tell what issue you ran into? What went wrong, and what are the steps to reproduce.
I'm going to close it as a duplicate of #2808
Please reply to #2808


Monk defensive traits aren't tracked.

Guard does not seem to be tracked at all currently. Seems to be treated as a normal hit.
Counter rate is not tracked directly, but is tracked indirectly through being treated as an Evade. Counter damage also does not seem to be tracked.

I added defensive tracking of guard/counter in v0.985

Fixed with v0.986, please report if the percentages aren't accurate


warnungen im log admin 5

adapter version 0.3.6
`enocean.0 | 2021-05-13 06:50:51.309 | warn | Read-only state "enocean.0.gateway.lastID" has been written without ack-flag with value "01a5bd01"
enocean.0 | 2021-05-13 06:49:11.232 | warn | Read-only state "enocean.0.gateway.lastID" has been written without ack-flag with value "01a5bd01"
enocean.0 | 2021-05-13 06:45:51.093 | warn | Read-only state "enocean.0.gateway.lastID" has been written without ack-flag with value "01a5bd01"
enocean.0 | 2021-05-13 06:44:11.011 | warn | Read-only state "enocean.0.gateway.lastID" has been written without ack-flag with value "01a5bd01"
enocean.0 | 2021-05-13 06:43:58.060 | warn | Read-only state "enocean.0.gateway.lastID" has been written without ack-flag with value "05057e7d"`

Ist bei mir auch:
JS 3.3.5
Admin 5.0.15

enocean.0
2021-05-14 12:28:32.327
warn
(1259) Read-only state "enocean.0.gateway.lastID" has been written without ack-flag with value "0590176e"

enocean.0
2021-05-14 12:28:32.147
warn
(1259) Read-only state "enocean.0.gateway.lastID" has been written without ack-flag with value "05839880"

enocean.0
2021-05-14 12:28:32.008
warn
(1259) Read-only state "enocean.0.gateway.lastID" has been written without ack-flag with value "0583987c"

enocean.0
2021-05-14 12:28:30.475
warn
(1259) Read-only state "enocean.0.gateway.lastID" has been written without ack-flag with value "ffef578b"

enocean.0
2021-05-14 12:28:30.391
info
(1259) State value to set for "enocean.0.0590176e.CMD" has to be type "number" but received type "undefined"

enocean.0
2021-05-14 12:28:30.386
info
(1259) State value to set for "enocean.0.0590176e.DS" has to be type "number" but received type "undefined"

enocean.0
2021-05-14 12:28:30.327
warn
(1259) Read-only state "enocean.0.gateway.lastID" has been written without ack-flag with value "ffef5789"

enocean.0
2021-05-14 12:28:30.242
info
(1259) State value to set for "enocean.0.05839880.CMD" has to be type "number" but received type "undefined"

enocean.0
2021-05-14 12:28:30.236
info
(1259) State value to set for "enocean.0.05839880.DS" has to be type "number" but received type "undefined"

enocean.0
2021-05-14 12:28:30.174
warn
(1259) Read-only state "enocean.0.gateway.lastID" has been written without ack-flag with value "ffef5788"

enocean.0
2021-05-14 12:28:30.089
info
(1259) State value to set for "enocean.0.0583987c.CMD" has to be type "number" but received type "undefined"

enocean.0
2021-05-14 12:28:30.084
info
(1259) State value to set for "enocean.0.0583987c.DS" has to be type "number" but received type "undefined"

Ist in der 0.3.7 behoben.


Side

Python Strong with indices

Looks Good! I can see the indice being performed on the string.


Repeated scans result in different reports

Describe the bug
I have a project which consists of 12 war files, and a shared war. I scan these using the jenkins plugin using --scan **/*.war.
The report that is outputted changes from time to time, even when the wars are binary identical to the previous runs.
Dependency check seems to be trying to group things together, or mark some wars as shade by other wars.
What I see is that sometimes war A is reported a dependency with war B as related dependencies. But sometimes it's different or the other way around.
The differences are so big that it's hard see what exactly is going on, but my suspicion is this is caused by having no predictable ordering. (a point mentioned in #2608 - now closed).
Version of dependency-check used
The problem occurs using version 6.1.3 of the jenkins cli
Log file
I can provide private links to logs offline
To Reproduce
Have a project with multiple wars, generated independently of eachother
Have a job copying all the wars into a folder
Scan the wars using the (jenkins) cli with --scan '**/*.war`
Expected behavior
When the wars are binary identical, the reports generated by dependency check should be identical as well.

Did some more testing. Without knowing the intention behind the "shading" it's hard to understand what is happening. It looks like when I have a project that has:
A.war, which contains shared.war
B.war, which contains shared.war
C.war, which contains shared.war
shared.war
If I scan these 4 wars (or ~~/*.war), it looks like shared.war gets either "grouped" (or "shaded"?) under A.war xor B.war xor C.war. Could depend on filesystem ordering or maybe last update timestamp, haven't found a pattern yet.
But depending on what gets chosen you either get all the vulnerabilities from shared.war under only A.war or only B.war or only C.war. And seperate from that you get them also under shared.war.
Not sure if this is intended, but I would expect all the vulnerabilities to be reported 4 times, once under A, once under B, once under C, once under shared. Does that make sense?
The current behaviour only has 2 vulnerabilities in the report which hides the 2 others. And it's unpredictable which 2 get hidden. So if you have a tool like Defect Dojo trying to ingest the findings and keep track of new/mitigated findings things go wrong as it will start flipping findings from open to closed based on the unpredictability.

Just did another run, with different result again using this setup:
A.war, which contains shared.war
B.war, which contains shared.war
C.war, which contains shared.war
run 1 contains "B.war" 34 times
run 2 contains "B.war" 76 times
This with explicit ordering, so --scan A.war --scan B.war --scan C.war

As long as you scan only single wars or unrelated wars, everything seems fine. But the usecase we're seeing more and more are applications based on a microservice architecture, with shared code like the shared.war in the above example.

99% positive its because of this line: https://github.com/jeremylong/DependencyCheck/blob/3d097c4838d21d861753a0ea77cde92af19fac40/core/src/main/java/org/owasp/dependencycheck/analyzer/AbstractDependencyComparingAnalyzer.java#L92
As we are sorting on just the file name - there is no guaranteed order of files with the same name so the may be grouped differently and this results in a different order for the dependency bundling....

Turns out it was that 1% @jeremylong ;-) That fix didn't solve the problem. I did some digging today and created a PR that makes the data in the report / internal data structures ordered and that seems to make the reports predictable / idempotent. Please let me know if this approach is an acceptable one (more details in PR description). Personally I think reports across runs on the same set of scanned artifacts should be identical, apart from some timestamps maybe.


Output Discrepancies in TensorFlow Model with Extra Concat Output Node Under XLA Compilation

Issue type
Bug
Have you reproduced the bug with TensorFlow Nightly?
Yes
Source
source
TensorFlow version
2.15.0
Custom code
Yes
OS platform and distribution
Ubuntu 22.04.3 LTS
Mobile device
No response
Python version
3.10
Bazel version
No response
GCC/compiler version
No response
CUDA/cuDNN version
No response
GPU model and memory
No response
Current behavior?
In TensorFlow 2.15.0, I have encountered an issue where adding an extra concat output node to a model results in discrepancies in the output when compiled with XLA. This inconsistency is not observed without XLA compilation.
Additional Context
In our efforts to understand and locate the root cause of this issue, we have conducted several tests and experiments. Through this process, we've identified specific conditions under which the discrepancy does not occur:

Removing an Operator: If any one of the operators (expand_dims, multiply, abs) is removed from either model, the discrepancy under XLA compilation is no longer triggered.

Removing concated from Model2's Return: Omitting the concated tensor from the output of Model2 results in no discrepancy between the two models under XLA compilation.

Changing Input Tensor Data Type: Altering the data type of the input tensor to a type other than int8 also prevents the occurrence of this discrepancy.

Standalone code to reproduce the issue
import tensorflow as tf
import numpy as np
class Model1(tf.keras.Model):
    @tf.function(jit_compile=True)
    def __call__(self, inp):
        expanded = tf.expand_dims(inp, axis=0)
        multiplied = tf.multiply(inp, expanded)
        absed = tf.abs(multiplied)
        return absed,
class Model2(tf.keras.Model):
    @tf.function(jit_compile=True)
    def __call__(self, inp):
        expanded = tf.expand_dims(inp, axis=0)
        multiplied = tf.multiply(expanded, inp)
        concated = tf.concat([multiplied, multiplied], axis=0)
        absed = tf.abs(multiplied)
        return absed, concated

inputs = [
tf.cast(tf.random.uniform(shape=[5, 5], minval=-128, maxval=128, dtype=tf.int32), tf.int8),
]
model1 = Model1()
model2 = Model2()
device = "cpu"
with tf.device(device):
    tf.config.run_functions_eagerly(True)
    out1 = model1(*inputs)
    out2 = model2(*inputs)
    print(f'=========eager_output(version:{tf.__version__})================')
    try :
        for i in range(min(len(out1),len(out2))):
            np.testing.assert_allclose(out1[i].numpy(), out2[i].numpy(), rtol=0.001, atol=0.001, err_msg=f'at checking {i}th')
        print("XLA_eager does not trigger assertion")
    except AssertionError as e:
        print("XLA_eager triggers assertion")
        print(e)
    tf.config.run_functions_eagerly(False)
    out1 = model1(*inputs)
    out2 = model2(*inputs)
    print(f'=========compiled_output(version:{tf.__version__})================')
    try :
        for i in range(min(len(out1),len(out2))):
            np.testing.assert_allclose(out1[i].numpy(), out2[i].numpy(), rtol=0.001, atol=0.001, err_msg=f'at checking {i}th')
        print("XLA_complie does not trigger assertion")
    except AssertionError as e:
        print("XLA_complie triggers assertion")
        print(e)

Relevant log output
=========eager_output(version:2.15.0)================
XLA_eager does not trigger assertion
=========compiled_output(version:2.15.0)================
XLA_complie triggers assertion

Not equal to tolerance rtol=0.001, atol=0.001
at checking 0th
Mismatched elements: 13 / 25 (52%)
Max absolute difference: 126
Max relative difference: 2.
 x: array([[[ -63,   16,  -23,  -15,   68],
        [ -92, -103,  -60,  100,    1],
        [   9,   16,   36,   33,   64],...
 y: array([[[ 63,  16,  23,  15,  68],
        [ 92, 103,  60, 100,   1],
        [  9,  16,  36,  33,  64],...

Hello @sachinprasadhs,
We were considering the importance of examining the intermediate values in the layer and thought it might be a crucial aspect to look into.

Hi,
Returning the different outputs for both the results and then comparing will not yield same result.
The behavior is expected and it does not not look like a bug.


Added icons and remove context menu on the components bar. Fixes #10

Removed the three dots and the contextmenu on the component's name and replace them by icons (Style and image to-be-defined)
Added confirmation while trying to remove or reset a component.

Where is the icon to copy the component to clipboard going to be?

@dmarcos next to the current icons, in the same row

Are we adding the icon on a different PR?

Not yet, the icons will be something like the one used on the Copy to clipboard for entity (https://github.com/aframevr/aframe-editor/pull/188) and it will be added in another PR, not to mix different issues in the same PR (delete dots -> icons, and copy to clipboard)

Can we try labels instead of icons as @cvan suggested. It might not be too bad.

My idea is, as they all looks the same style, review the functionality and the placement and if we're good to go merge them and create another issue with "Style the component's icons"

do you mean label when mouseOver or label all the time?

Label all the time: copy, reset, delete instead of the icon.

We can add a subtle background to indicate it's a button

You mean something like this right?
https://cloud.githubusercontent.com/assets/203725/16678220/d71f5b90-4491-11e6-9d7e-bebc600eb449.png
(From https://github.com/aframevr/aframe-editor/issues/10)

I'm afraid that showing the labels all the time won't fit in some situations, like when we've multiple components:

When having multiple components we can show the id in the panel like the html element (<a-entity>) in the common section

But could be nice to see them when everything is collapsed

What about always showing the attribute name as it is. Only SOUND__2 instead of SOUND (SOUND__2)

We had already an issue on the previous repo but I deleted when I changed the repos, I've created a new one to discuss it again -> https://github.com/aframevr/aframe-editor/issues/190

Use text-overflow: ellipsis + max-width up until the start of the icons so they don't clash. Then use title so they can see the full name on hover.

@ngokevin ok thank you! And what do you think about the icons + tooltip/label? https://github.com/aframevr/aframe-editor/issues/10

The current state is great. Only problems:

Tooltip takes too long to display on Chrome after hover. We can't really change that except by using a custom solution.
Eraser icon might not be immediately clear what it does. The alert modal does help. Personally, I don't think we need Reset to Default and would remove it (Trashing + Re-add would do it too). But if we keep it, we'll have telemetry to see how often it is used.

Addressing those two might not be in context of this PR.

What about using labels instead of icons? text labels with a background + underline to convey clickability

That sounds good, it would solve both issues.

Something like this?

I also start to believe that the clear button probably won't be used so much, so we could remove it and just add it in the future if someone asks for it. Or just leave it on the edit menu, just in case :)

That looks good. Maybe lowercase copy html too.

I've removed the reset to default button and the copy html because it was just to show the mockup and I'll open another PR with that functionality.

remove component is more consistent to the API than delete. Former means to detach from the entity, latter almost sounds like to permanently delete.
r+wc love it

@ngokevin both changes done! thank you


Null check operator used on a null value

E/MediaMetadataRetrieverJNI(28521): getFrameAtTime: videoFrame is a NULL pointer
I/flutter (28521): ERROR: Couldn't generate thumbnails: MissingPluginException(No implementation found for method data on channel plugins.justsoft.xyz/video_thumbnail)
Another exception was thrown: Null check operator used on a null value
E/MediaMetadataRetrieverJNI(28521): getFrameAtTime: videoFrame is a NULL pointer
I/flutter (28521): ERROR: Couldn't generate thumbnails: MissingPluginException(No implementation found for method data on channel plugins.justsoft.xyz/video_thumbnail)
Another exception was thrown: Null check operator used on a null value

It was a bug from the thumbnail generation. I have added a few fixes for that in a separate repository. Check this one out,
video_trimmer:
  git:
    url: https://github.com/Kasun-thilina/video_trimmer
    ref: v3.0.5

Any updates?

Should be fixed in the latest version 4.0.0!


update imagetest readme

hint: use 'view file' in files tab to see the github rendering of the markdown

eric is oo
/cc zmarano


Windows fat binary multiprocessing issue

There is an issue running silx test with Windows fat binary, I expect it is due to multiprocessing being used in silx.io.h5py_utils which makes a fork-bomb.
Using multiprocessing.freeze_support() should fix it.

closed on 0.15 branch


GH Issue and PR template

Description:

Currently any new user who comes up to this repository and reports a new issue ticket, we don't have a template. For a better contributor experience, also there is no template for PR while raising one.

Potential Solution:

We can create a markdown file for the same.

Screenshots:
Helpful links:
https://docs.github.com/en/communities/using-templates-to-encourage-useful-issues-and-pull-requests/configuring-issue-templates-for-your-repository
https://docs.github.com/en/communities/using-templates-to-encourage-useful-issues-and-pull-requests/manually-creating-a-single-issue-template-for-your-repository

The amount of activity here doesn't require any additional procedures.


Remove Runnable Demo links

Runnable got acquired and shut down the service.

Need to remove the "Demo on Runnable" images in docs and README

@jdorfman
Removed from readme here: https://github.com/odb/shml/commit/568b0495b49dd7ee8e07a75ae218ca7e5347f6a6
Created https://github.com/odb/shml/pull/38 to remove from site.

Removed the others. Missed one, @Mandihamza is on it. Keep open until then.


How to use custom fonts?

First of all, thanks for that great module!
Would someone elaborate on how to use custom fonts?
I've seen the business-card example with @font-face definiton, but it's unclear to me what the file-path of the font must be relative to.:
<html>
   <head>
      <style>
         @font-face {
           font-family: 'MyOpenSans';
           font-style: normal;
           font-weight: 400;
           src: url(file://app/templates/fonts/OpenSans-Regular.ttf); <-- ?
         }
   </style>
     ...

Would appreciate some info!

You can try uploading font files to your server and try accessing from there. I am able to do this by using the following code:
@font-face {       font-family: 'Aller_Rg';       src: url('https://MYS3BUCKET/assets/Aller_Rg.ttf') format('truetype')     } p{       font-family: 'Aller_Rg';       font-size: 10px;     }
You dont need to set base after this

I'm trying to get this running in a lambda that's locked down. How would you do this by putting the font on the file system?

I base64 the src if that helps.
@font-face {
  font-family: "CustomFont";
  font-style: normal;
  font-weight: 700;
  src: url(data:font/truetype;base64,....)
}

I base64 the src if that helps.
@font-face {
  font-family: "CustomFont";
  font-style: normal;
  font-weight: 700;
  src: url(data:font/truetype;base64,....)
}

Yes! Thank you 👏🏼

I base64 the src if that helps.
@font-face {
  font-family: "CustomFont";
  font-style: normal;
  font-weight: 700;
  src: url(data:font/truetype;base64,....)
}

Solved the problem that I was having for weeks. Thank you!

I base64 the src if that helps.
@font-face {
  font-family: "CustomFont";
  font-style: normal;
  font-weight: 700;
  src: url(data:font/truetype;base64,....)
}

I'm using the same but still have the "DejaVuSans" font inside my PDF. How can if fix this?


Better API alternative for "db.open"?

I'm evaluating Dexie.js for my client side DB needs and it seems very nice, but as a lazy reader I missed that I needed to open the database before anything happens. If I don't open it, no error is given anywhere but promises just don't trigger, which I wondered for a while.
I see that the rationale for the open to work the way it does is the queuing, which indeed is a nice feature to have (although I've still not fully grasped what's their role in comparison to transactions). However, having such a strong "internal state" that is easy to overlook is often a bit smelly. I think eg. the stores-method could return a new object to avoid the "stateness".

Closing this issue now since it has been opened for a while with no more comments.


@Query can't encode the symbol normally $ ] [

Thanks for your question. This issue tracker is only for bug reports with test cases and feature requests. Please ask usage questions on Stack Overflow.
https://stackoverflow.com/questions/tagged/okhttp


Describe usage in README.

Fixes #12.

Coverage remained the same at 91.622% when pulling 186016988cdf8949260bdc686ae3e1c842503d01 on dangle:docs into 0984ce9b0085b6e5fe9e76d2c5b4b4c21b7a6f14 on containenv:development.

Coverage decreased (-1.08%) to 90.541% when pulling 6b5b52621a1661595fb755686704bbe8d1263202 on dangle:docs into 0984ce9b0085b6e5fe9e76d2c5b4b4c21b7a6f14 on containenv:development.

Coverage remained the same at 91.622% when pulling 01045241d147b7a2b41e73f3d53637cd97ac19e9 on dangle:docs into 0984ce9b0085b6e5fe9e76d2c5b4b4c21b7a6f14 on containenv:development.

Coverage remained the same at 91.622% when pulling 01045241d147b7a2b41e73f3d53637cd97ac19e9 on dangle:docs into 0984ce9b0085b6e5fe9e76d2c5b4b4c21b7a6f14 on containenv:development.


is torch1.6 branch still under development?

Hi! torch1.6 branch seems not working now using the training script privided. As PyTorch has provided searchsorted API in v1.6, will it be merged into master later on?

no normals_ndc_fine key in input list under current branch now.

To support the old colab files, the master branch will not be updated.
I did some update (update library versions, remove torchsearchsorted) into the dev branch just now. In the future that branch will contain the latest code (might not be updated so often though...)

To support the old colab files, the master branch will not be updated.
I did some update (update library versions, remove torchsearchsorted) into the dev branch just now. In the future that branch will contain the latest code (might not be updated so often though...)

By the way, normal branch is just my personal experiments to try to output the normal map (the result doesn't seem good...), it will not be included anywhere.

By the way, normal branch is just my personal experiments to try to output the normal map (the result doesn't seem good...), it will not be included anywhere.


IsGroupingEnabled can cause possible Null argument exception when setting source to null

Hello,
In line 627 of FlowListView.cs, there is a cast on the IEnumerable FlowItemsSource when IsGroupingEnabled is true. This can cause a null argument exception if the FlowItemsSource is set to null (previously not null). This happens when my view is destroyed (VM is set to null)... or when I just want to set it to null or something that is not INotifyCollectionChanged.
I am using Prism and when I set the IsGroupingEnabled = false when the view is destroyed the error goes away... IMO, the cast should probably be: var groupedSource = FlowItemsSource?.Cast<INotifyCollectionChanged>();?
Can you verify if this is indeed a bug or I am missing something?
Thanks!

Yes, it's a bug. Nice catch. Fixed :)


Update developer guide for sortCommand

Updated developer and user guide for sort command.

Codecov Report

Merging #81 (f928bde) into master (bb24531) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master      #81   +/-   ##
=========================================
  Coverage     63.82%   63.82%
  Complexity      515      515
=========================================
  Files            92       92
  Lines          1700     1700
  Branches        171      171
=========================================
  Hits           1085     1085
  Misses          550      550
  Partials         65       65

:mega: Codecov can now indicate which changes are the most critical in Pull Requests. Learn more


Compatibility with hotwired/turbo-rails

I started migrating a project from Turbolinks to the Turbo project and hit some issues. I have a workaround which might be useful to include in the documentation, or at least have here for others who encounter the same problem. Let me know if it would be helpful to PR somewhere.
Turbo feels like a drop-in replacement but it doesn't profess to being backwards compatible as DHH outlines: https://github.com/hotwired/turbo-rails/issues/67
Although Turbo follows the same patterns as Turbolinks, and has the same events, i.e. before-cache, visit, load etc. they are now namespaced under turbo instead of turbolinks, so turbolinks:load is now turbo:load.
The IntercomJS client that gets loaded from Intercom has a bunch of Turbolinks event listeners, as you can see if you view the file and ctrl-f for Turbolinks. Due to the new names these event listeners are ignored and Intercom throws the following error when navigating via Turbo.

I've messaged Intercom support and asked them to consider including the new event names alongside the current ones. In the meantime I've found the following workaround:
document.addEventListener('turbo:before-cache', () => {
  document.dispatchEvent(new Event('turbolinks:before-cache'))
});
document.addEventListener('turbo:load', () => {
  document.dispatchEvent(new Event('turbolinks:load'))
});
document.addEventListener('turbo:visit', () => {
  document.dispatchEvent(new Event('turbolinks:visit'))
});

Version info

intercom-rails version: 0.4.2
Rails version: <IP_ADDRESS>

Expected behavior
Intercom works when using Turbolinks to navigate
Actual behavior
Intercom JS throws an error
Steps to reproduce

Install Turbo
Load page
Click link to another page

Logs
VM6567 frame-modern.412e5163.js:1 Uncaught TypeError: Cannot read property 'document' of null
    at o (VM6567 frame-modern.412e5163.js:1)
    at Object.read (VM6567 frame-modern.412e5163.js:1)
    at VM6567 frame-modern.412e5163.js:1
    at session_Session.createOrUpdateUser (VM6567 frame-modern.412e5163.js:1)
    at app_App.createOrUpdateUser (VM6567 frame-modern.412e5163.js:1)
    at Object.update (VM6567 frame-modern.412e5163.js:1)
    at VM6567 frame-modern.412e5163.js:1
    at <anonymous>:3:473
    at <anonymous>:3:910
    at replaceElementWithElement (turbo.es2017-esm.js:3925)

This seems to have been fixed. The Intercom script now includes Turbo events:

And we've stopped seeing this error at some point in the last few days.

This seems to have been fixed. The Intercom script now includes Turbo events:

And we've stopped seeing this error at some point in the last few days.

Oh that's great! Thanks letting me know. Intercom support were helpful and receptive but I didn't expect to see it incorporated this quickly.

Oh that's great! Thanks letting me know. Intercom support were helpful and receptive but I didn't expect to see it incorporated this quickly.

I'm doing the same thing, migrating to Hotwire from Turbolinks. For forms that fail validation, we used to just render with a 200 OK. But now, we need to render with a 422 Unprocessable Entity. https://github.com/hotwired/turbo-rails/issues/34#issuecomment-754628629
When I get the 422, I get this error:
VM1314 frame-modern.4decb80c.js:1 Uncaught TypeError: Cannot read property 'document' of null
    at s (VM1314 frame-modern.4decb80c.js:1)
    at Object.read (VM1314 frame-modern.4decb80c.js:1)
    at VM1314 frame-modern.4decb80c.js:1
    at session_Session.createOrUpdateUser (VM1314 frame-modern.4decb80c.js:1)
    at app_App.createOrUpdateUser (VM1314 frame-modern.4decb80c.js:1)
    at Object.update (VM1314 frame-modern.4decb80c.js:1)
    at VM1314 frame-modern.4decb80c.js:1
    at <anonymous>:3:213
    at <anonymous>:3:650
    at replaceElementWithElement (turbo.es2017-esm.js:1476)

It looks like it's coming from Turbo, but the Intercom widget disappears as well. Is anyone else seeing this?

@Petercopter, that error is coming from the Intercom widget. For 422 responses, I see an error coming from frame.134abfc8.js. I'll probably open a ticket for them.

The Intercom widget listens to turbo:load, turbo:visit, and turbo:before-cache events.
Turbo doesn't fire any of these events during unsuccessful form submission, so the widget can't prepare itself for the DOM change.
I've already opened a ticket for Intercom so they can improve it, but in the meantime I've came up with the following workaround:
document.addEventListener("turbo:submit-end", (event) => {
  window.turboFormSubmissionFailed = !event.detail.success

  if(window.turboFormSubmissionFailed) {
    document.dispatchEvent(new Event('turbo:visit'))
    document.dispatchEvent(new Event('turbo:before-cache'))
  }
})
document.addEventListener("turbo:render", () => {
  if(window.turboFormSubmissionFailed) {
    document.dispatchEvent(new Event('turbo:load'))
    window.turboFormSubmissionFailed = false
  }
})

This code emulates the page visit flow after unsuccessful form submission, and it fixes issues with the widget.

APP ID: 15540
User/Lead (who reported issue): 5622a0411cf1a9784902c642
Can Impersonate?: No
Conversation with Customer: https://intercomrades.intercom.com/a/apps/tx2p130c/inbox/inbox/4697146/conversations/40612403733

@mrhead thanks for all the details! Do you know if this was ever resolved?

@summera It looks like this was never fixed. When I remove our workaround, the Intercom widget fails on unsuccessful form submission.

@mrhead thanks for checking! Apparently this is a deeper issue that others have brought up in the Turbo repo:

https://github.com/hotwired/turbo/issues/85#issuecomment-756259687
https://github.com/hotwired/turbo/issues/520#issuecomment-1020209174

I wonder if there's a way to gracefully shut down and restart the Intercom widget without simulating the Turbo events. Any idea what the Intercom JS script is doing when it receives the turbo:load event? Maybe the same code could be executed in your workaround instead of firing off Turbo events?

Still an issue after two years.  Any update from maintainers?

I can confirm that this is still an issue.


Separate contract class constructors in 2, one with and one without class_hash calculation

That's great. We're in fact using ContractClass::from_str(), not the constructors directly, so having a function that receives a string and a class hash would be best for us.


Order Summary: Applied promotions - whole cart

Fix issues with presentation of order summary promotions
Issues

Multiple entry handling
Resolution of duplicates
Styling update

Analogical to #1637

fixed with #5464


Property Naming

The property names for attributes causes code analysis violations in Visual Studio and in Azure Pipelines, where code analysis warnings are treated as errors and the build therefore fails.
Would it be possible to use the display name minus the whitespace for naming properties, rather than using the logical name or schema name of the field, ensuring that property names meet the Microsoft naming conventions?
You would probably need to add a JsonPropertyAttribute to each property, setting the PropertyName to the logical name or schema name of the field.
Here is an example of what that could look like:
[JsonProperty(PropertyName = "msdyn_taxexempt")]
public bool? TaxExempt { get; set; }

Hi, i think that i can do this

Can you follow https://docs.microsoft.com/en-us/dotnet/standard/design-guidelines/naming-guidelines when naming your classes/fields/methods/properties/etc. please?
Code Analysis Warnings are generated when the Microsoft Naming Guidelines are violated.
One thing I've noticed in your naming is the use of underscores for public types (private is fine - but you should follow Roslyn and/or Resharper recoomneded naming).


Rel 1.50.1

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.1 out of 43 committers have signed the CLA.:white_check_mark: pavelkornev:x: valtson:x: Nanovsky:x: gerym:x: JumpNRun:x: Silkinator:x: Kevin Edinger:x: Sebastian Allmann:x: tommyvinhlam:x: ilhan007:x: awolfish:x: d060270:x: Vitor Seifert:x: Vitor Eduardo Seifert Bazzo:x: adrian-bobev:x: UweReeder:x: Tuan Dat Ngo:x: StSche:x: ShtiliyanUzunov:x: Stefan Minchev:x: EugenResch:x: Jay Barbhaiya:x: DMihaylova:x: myordanov:x: Aditya Bhatia:x: stopcoder:x: PetrStribrny:x: Mingxin Fu:x: petermuessig:x: sapui5:x: Ivelina Hristova:x: hristop:x: GerganaKremenska:x: Radostina Tsiklovska:x: Christian Voshage:x: NikolayCholakov:x: Bozhko Todorov:x: Dominik Bogar:x: SvetoslavSpasov:x: goligo:x: Marcos Gavilan de Paz:x: Diana Shtilianova:x: ulasenkaKevin Edinger, Sebastian Allmann, Vitor Seifert, Vitor Eduardo Seifert Bazzo, Tuan Dat Ngo, Stefan Minchev, Jay Barbhaiya, Aditya Bhatia, Mingxin Fu, sapui5, Ivelina Hristova, Radostina Tsiklovska, Christian Voshage, Bozhko Todorov, Dominik Bogar, Marcos Gavilan de Paz, Diana Shtilianova seem not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

i believe this pull request is some kind of error? closing it to clean up the queue


The svg is going in a cyclic mode with editable

The svg is going in a cyclic mode when the no coordinates mapping is opened in editable mode.

Seems like for some reason forceSimulation is not stopping. Gonna try to have a look at it tomorrow.

I had a look but couldn't find what the problem was. I might look into it later on.
In the meantime if you manage to fix it feel free to submit a PR.

Having the same issue.

I should have fixed it, you can try updating react-mindmap to v2.1.5.
I'm gonna close this issue for now, feel free to reopen it if you still have problems.


[OSCI] Add new OSCI author arnoldtingsu

Description
[Describe what this change achieves]
Issues Resolved
[List any issues this PR will resolve]
Check List

[ x ] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the BSD-3-Clause License.

thank you


[Settings] Solving Hook-related problems with modifier keys appearing at ShortcutControl

Summary of the Pull Request
Solve the problem that the system receives incomplete KeyDown&KeyUp messages when pressing and holding the modifier keys to enter or close the ShortcutDialog of ShortcutControl.
Currently at the ShortcutControl, when you hold down the modifier key and then open or close the ShortcutDialog, KeyDown/KeyUp will be intercepted by the hook, causing the system not to receive the full KeyDown&KeyUp message.

PR Checklist

[x] Closes: #27514
[ ] Tests: Added/updated and all pass

Detailed Description of the Pull Request / Additional comments

Validation Steps Performed

@microsoft-github-policy-service agree

@microsoft-github-policy-service agree

@sh0ckj0ckey please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
@microsoft-github-policy-service agree [company="{your company}"]

Options:

(default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.

@microsoft-github-policy-service agree

(when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.

@microsoft-github-policy-service agree company="Microsoft"

Contributor License Agreement

@microsoft-github-policy-service agree

@sh0ckj0ckey thanks for the update! Do you need any help resolving the merge conflict?

@yuyoyuppe Hello, I may need some help with this, I just did some operations, and in the end, according to the Files changed tab of this page, I did change only one file and resolved the conflicts, right? Sorry I'm not familiar with this😭.

@yuyoyuppe Thank you😀, I tried this, and I've also had this problem, which seems to have existed in previous versions because the variable internalSettings was not reset when the Shortcut Dialog was closed, I will try to fix this.

OK, I will fix that in another PR, and this PR is done, right? Thank you😊

That's correct 🙂

Thanks for the contribution, I've tested it and haven't found any regressions with the latest changes.
@sh0ckj0ckey please go ahead and open a second PR, if you'd like.


html event abstraction, phase 3 - query

to #3602
query method in event class. + UTs
WIP for now. TODO:

[x] see how to integrate query in current usages of mv_getdata
[X] lots of some_command?repo_key -> refactor into some_command?key=repo_key to reuse uniformely via query
[ ] additional attention to cl_http_utility=>unescape_url( escaped = lv_value ) - used in get_field but not used in parse_fields currently - may be a problem

UPD: see comment below

missing escape for urls and html attributes in general is a problem indeed. instead of using string templates or concat, urls should be composed via string map where we could easily add the escaping. there's always another refactor ;-)

OK, this is ready to review and test. Could be a bit messy. Appeared to be a lot of small changes.
Main goal was: to remove usage of ii_event->mv_getdata and use ii_event->query( ) instead

ii_event->query( ) returns string map with uppercased (by default) params from url (k1=v1&k2=v2...). Can be not uppercased too (not sure that it is needed but I implemented it too).
Params can be retrieved by ii_event->query( )->get( 'XXX' ) or ii_event->query( )->to_abap( changing ... )
there was one place where I didn't refactor ii_event->mv_getdata - background pages. There is some complex logic of dynamic calling of class, received from param (!!! see ZCL_ABAPGIT_GUI_PAGE_BKG->DECODE) ... and I don't use this feature so I decided not to touch it or I'd break something :) BTW, dynamic call of a class, named by a received param look rather insecure ... :)
rest of direct mv_getdata were eliminated, together with part of action utils
also made all links that address a repo to uniformely address it via ?key=1234 instead of just ?1234

This should be tested a bit ... I'm not sure that I found all occurances of repo key urls. Though repo overview, stage, commit, diff, palettes, dbutils work.
One more concern is url unescape. I removed some of cl_http_utility=>unescape on the way. But action utils use own and simplified ZCL_ABAPGIT_HTML_ACTION_UTILS=>UNESCAPE with a comment (and UT) that suggest not to use cl_http_utility. So ... might be some issues with that potentially. Solution is: either to improve own tool, or use cl_http_utility where it is needed specifically (I'm sure there are not so many cases where it will be really needed)

... and docs respectively

thanks 👍 merging


change some translations in Russian

[x] I have read freeCodeCamp's contribution guidelines.
[x] My pull request has a descriptive title (not a vague title like Update index.md)
[x] My pull request targets the master branch of freeCodeCamp.
[x] All the files I changed are in the same world language, for example: only English changes, or only Chinese changes, etc.

Change some translations in Russian

Thanks for your PR, we are in the midst of a migration of the translation infrastructure and soon, will not be adding i18n to docs etc., via GitHub.
I know this is not case currently and you probably reached the file using a link on the page, but that is changing. This is a valid change and I will add instructions soon on the new way here in comments.
Thanks for you patience and taking the time to contribute @sixelalexis

Closing this with updates being made in https://github.com/freeCodeCamp/freeCodeCamp/pull/39794, please head over to https://translate.freecodecamp.org/contributing-docs if you are still interested in updating the relevant guide.
Thanks and happy contributing.


Custom cellSize puts display off centre

When the cellSize parameter is used to specify a size other than 256, the resulting display is off center. For example  L.map('map').setView([0, 0], 0) shows /0/0/0.png like this with cellSize: 256:

but like this with  cellSize: 100:

What do you mean by cellSize? This word isn't even present anywhere in Leaflet code. You probably opened the issue in a wrong repo.

Sorry, I meant tileSize.

Oh, I see. This looks like intended behavior, since when you change the tile size, the tile numbers also change and the center doesn't necessarily have to line up with a center of a tile.

I don't understand how this can be. This leaves setView inaccurate doesn't it?

No. If you take your time with projection math, you'll figure out that this is correct behavior. For a given zoom, you have 256 * 2^zoom pixels with the standard projection. If you have a tile size that's not a multiple of 256, it will be shifted relative to the center. If you need a different behavior, you need to write a custom projection.

Isn't setView([0, 0], 0) always supposed to centre the view at the centre of the map?


French translation :  fr.yml

Hey guys,
here the french translation. :)

Codecov Report

Merging #132 into master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #132   +/-   ##
=========================================
  Coverage     24.04%   24.04%
  Complexity      381      381
=========================================
  Files            60       60
  Lines          1127     1127
=========================================
  Hits            271      271
  Misses          856      856

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4b8720a...7564674. Read the comment docs.

Hey !
@clarkwinkelmann nouvelle version te semble bien? :)

@clarkwinkelmann C'est édité ! :)

@Hiobi thanks for your contribution, it's now merged. It'll be available in the next Bazaar release


Limit beacon range

After setting up a dozen beacons in the library where I work today, I started thinking about the range. I'm not sure I agree with myself, but throwing this in for discussion. The range of the beacons were really good in terms of distance, and I can think of a few occasions where I don't want it to be that great... like limit it to a smaller area.
I'm no Bluetooth expert, but for future beacon hardware it could be useful to be able to set the advertisement strength somehow.

What beacons are you using? If you are using V2 beacons you should be able
to set the broadcasting power.
On Thu, Feb 26, 2015, 7:51 AM Mikael Jergefelt<EMAIL_ADDRESS>wrote:

After setting up a dozen beacons in the library where I work today, I
started thinking about the range. I'm not sure I agree with myself, but
throwing this in for discussion. The range of the beacons were really good
in terms of distance, and I can think of a few occasions where I don't want
it to be that great... like limit it to a smaller area.
I'm no Bluetooth expert, but for future beacon hardware it could be useful
to be able to set the advertisement strength somehow.
—
Reply to this email directly or view it on GitHub
https://github.com/google/physical-web/issues/294.

Oh, great, these are V1.

The v2 beacon spec has been out a few months but the v2 hardware is JUST
coming out. Sorry we couldn't send you the latest.
Scott
On Feb 26, 2015 8:17 AM, "Mikael Jergefelt"<EMAIL_ADDRESS>wrote:

Oh, great, these are V1.
—
Reply to this email directly or view it on GitHub
https://github.com/google/physical-web/issues/294#issuecomment-76207424.

No worries @scottjenson! Much appreciated, thank you!


Adds margin-top, and margin-bottom auto classes for additional flexbox alignment functionality

https://github.com/basscss/basscss/issues/238

Sorry for the delay and thanks for this!


Filled in depversion.json

Using this PR to test for package updates on AspNet now.

:+1:

:+1: :shipit:

@hal-ler close?


Legacy vm creation

This PR will capture the old vm creation module.

Thanks @abdulrabbani00 Let me test it first. Looks like a pragmatic way to unblock marketplace images with additional data disks

Thanks @abdulrabbani00 Let me test it first. Looks like a pragmatic way to unblock marketplace images with additional data disks

Hello @LaurentLesle,
I have tested both the windows and Linux machine creation with custom images and data disks attached. I had difficulties testing the data disk attachment with marketplace images since most of them do not accept additional data disks on bootup.
Please let me know the outcome of your test.


Discussion - h2 as the default database

I have been playing with Zipkin using the default SQLite implementation and have run into random failures writing traces in the collector.  The application I was attempting to trace had spans that were very short, and I would get errors like the following
[error] ERR [20140416-14:43:14.253] processor: storeSpan
[error] ERR [20140416-14:43:14.253] processor: java.sql.SQLException: SQL logic error or missing database
[error] ERR [20140416-14:43:14.253] processor:     at org.sqlite.DB.throwex(DB.java:370)
[error] ERR [20140416-14:43:14.253] processor:     at org.sqlite.DB.exec(DB.java:76)
[error] ERR [20140416-14:43:14.253] processor:     at org.sqlite.Conn.rollback(Conn.java:351)
[error] ERR [20140416-14:43:14.253] processor:     at com.twitter.zipkin.storage.anormdb.DB.withTransaction(DB.scala:70)
[error] ERR [20140416-14:43:14.253] processor:     at com.twitter.zipkin.storage.anormdb.AnormStorage$$anonfun$storeSpan$1.apply$mcV$sp(AnormStorage.scala:63)
[error] ERR [20140416-14:43:14.253] processor:     at com.twitter.zipkin.storage.anormdb.AnormStorage$$anonfun$storeSpan$1.apply(AnormStorage.scala:58)
[error] ERR [20140416-14:43:14.253] processor:     at com.twitter.zipkin.storage.anormdb.AnormStorage$$anonfun$storeSpan$1.apply(AnormStorage.scala:58)
[error] ERR [20140416-14:43:14.253] processor:     at com.twitter.util.Try$.apply(Try.scala:13)
[error] ERR [20140416-14:43:14.253] processor:     at com.twitter.util.ExecutorServiceFuturePool$$anon$2.run(FuturePool.scala:111)
[error] ERR [20140416-14:43:14.253] processor:     at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:439)
[error] ERR [20140416-14:43:14.253] processor:     at java.util.concurrent.FutureTask$Sync.innerRun(FutureTask.java:303)
[error] ERR [20140416-14:43:14.253] processor:     at java.util.concurrent.FutureTask.run(FutureTask.java:138)
[error] ERR [20140416-14:43:14.253] processor:     at java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:895)
[error] ERR [20140416-14:43:14.253] processor:     at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:918)
[error] ERR [20140416-14:43:14.253] processor:     at java.lang.Thread.run(Thread.java:695)
[error] ERR [20140416-14:43:14.253] processor: storeSpan
[error] ERR [20140416-14:43:14.253] processor: java.sql.SQLException: database in auto-commit mode
[error] ERR [20140416-14:43:14.253] processor:     at org.sqlite.Conn.rollback(Conn.java:350)
[error] ERR [20140416-14:43:14.253] processor:     at com.twitter.zipkin.storage.anormdb.DB.withTransaction(DB.scala:70)
[error] ERR [20140416-14:43:14.253] processor:     at com.twitter.zipkin.storage.anormdb.AnormStorage$$anonfun$storeSpan$1.apply$mcV$sp(AnormStorage.scala:63)
[error] ERR [20140416-14:43:14.253] processor:     at com.twitter.zipkin.storage.anormdb.AnormStorage$$anonfun$storeSpan$1.apply(AnormStorage.scala:58)
[error] ERR [20140416-14:43:14.253] processor:     at com.twitter.zipkin.storage.anormdb.AnormStorage$$anonfun$storeSpan$1.apply(AnormStorage.scala:58)
[error] ERR [20140416-14:43:14.253] processor:     at com.twitter.util.Try$.apply(Try.scala:13)
[error] ERR [20140416-14:43:14.253] processor:     at com.twitter.util.ExecutorServiceFuturePool$$anon$2.run(FuturePool.scala:111)
[error] ERR [20140416-14:43:14.253] processor:     at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:439)
[error] ERR [20140416-14:43:14.253] processor:     at java.util.concurrent.FutureTask$Sync.innerRun(FutureTask.java:303)
[error] ERR [20140416-14:43:14.253] processor:     at java.util.concurrent.FutureTask.run(FutureTask.java:138)
[error] ERR [20140416-14:43:14.253] processor:     at java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:895)
[error] ERR [20140416-14:43:14.253] processor:     at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:918)
[error] ERR [20140416-14:43:14.253] processor:     at java.lang.Thread.run(Thread.java:695)

Thinking maybe the file based SQLite implementation couldn't handle the rapid spans I was sending it, I switched to file based H2.  Had to tweak the SQL statements, as some of the GROUP BY portions were non standard and didn't work.  No more errors and it appears all the spans are stored.
I also added a small h2-client script to launch a web gui into the same H2 database, which I found useful for seeing what was stored.    Would this change be useful to contribute?  If so, I would need to update the tests.  Thinking I might pull out the database configuration as well, so you could switch databases without recompiling.  That would make it easier to unit test all database backends, instead of just the default.
Thanks

Closing this issue a we are removing H2 from the default list. Since we don't run tests or allow docker configuration, H2 may already be broken without us knowing: #853
In the near future, we will release an alternative to anorm, jOOQ, in the java project. If there's enough interest to contribute docs and tests for other databases, we can always pick this back up.


compose: use istio/proxyv2 1.9.6

We will be shipping a proxy based on Istio 1.9, so let's update the base image and check what needs to change.

bors r+


Clarity Spinner Appears with Scrollbar in Modal

I currently have a website using clarity and angular 8,
when adding the clarity spinner to a clarity modal it gives a scroll bar on the side of the modal, which appears and disappears from time to time while loading.
(this sometimes happens when hovering with your mouse over the modal and other times it appears by itself)
I'm not entirely sure if this has something to do with the screen size or browser because it doesn't have any effect when changing the size of the modal.
see link to stackblitz : https://clarity-light-theme-v2-oftfd8.stackblitz.io
image:

This is related to the rotating object for the spinner. You will need to give the spinner container some extra margin to allow it to rotate without changing the height (which is triggering the scrollbar).


Error running maltego transforms

The steps give in maltego usage in the documentation is followed but the command:
canari create-profile nettacker_transforms -w {ABSOLUTE PATH OF DIRECTORY}/OWASP-Nettacker/lib/transactions/maltego/nettacker_transforms/src
Giving this error:
Loading Canari configuration file '/home/am4n/.canari/canari.conf'
Usage: canari create-profile [OPTIONS] [PACKAGE]
Try 'canari create-profile --help' for help.

This is my .canari/canari.conf file:
[canari.local]
# Additional config files that should be read to merge with the current config
configs =

path = ${PATH},/usr/local/bin,/opt/local/bin

[canari.remote]
# This section deals exclusively with remote transform execution and has no effect on local transform execution. Modify
# these options if you are running your transforms under plume.

# Additional config files that should be read to merge with the current config in remote exec mode.
configs =

# Specify any transforms that your WSGI container will host. This is for Plume ONLY.
packages =

path = ${PATH},/usr/local/bin,/opt/local/bin

Something is going wrong with my canari.conf file I think. This issue will come whenever someone freshly clone the repo and follow the maltego transforms

OS: Linux
OS Version: Ubuntu 18.04
Python Version: 3.6.9

ditched in new version


HALON-613: fix disk status output.

Created by: qnikst
Disk were missing in status replies if no slot information was
available.

Closing as an obsolete