tests: mem_block: add a delay between test functions

Currently, cavstool.py can not catch up with the log output flooding
into the winstream buffer. We have to add a delay between test functions
to catch the full log without missing anything.
Fixes: #46925
Signed-off-by: Guo Lixin<EMAIL_ADDRESS>

The CI failures seem irrelevant.

Thanks, @LixinGuoX , it fixed the issues on CAVS boards. But I was thinking if we could apply this only for CAVS boards, and keep completed log for other boards?

@nashif
Some of my thoughts:

The test point of this test case is not about the logging. We can tell that from the asserts in the code. So reducing logs won't cripple the test.

It's inherent in the design of winstream ring buffer to lose logs if the logging is too frequent. See https://github.com/zephyrproject-rtos/zephyr/issues/47833.

So maybe it's OK to reduce the noise of excessive logs for this test.

Using a before function to add an extra delay(1 seconds) between test functions can help cavstool.py to catch the full log without missing anything.

Some of my thoughts:

The test point of this test case is not about the logging. We can tell that from the asserts in the code. So reducing logs won't cripple the test.

It is not, but we also do not want to start special casing platforms enabling something on one and disabling on the others. Logs are there for a reason, to see crashes in details and such. If a test is to be changed for this type of reasoning, it needs to be done globally and not for one platform.

It's inherent in the design of cavstool.py and winstream to lose logs if the fw logging is too frequent. See Intel CAVS: cavstool.py fails to extract complete log from winstream buffer when logging is frequent #47833.

Right, we need to figure out an alternative way for capturing tests then.

So maybe it's OK to reduce the noise of excessive logs just for this test.

My issue is that it does not end here, we have already modified a few tests this, what is the point of enabling logging if we have to disable it after that?
There are 2 ways out of this:

Alternative logging on this platform, maybe long term.
Better way for caputering results, you are already working on that.

We just turned to use an extra delay as the before function. Rather than use platform_exclude.
This can give cavstool.py a chance to catch up. And also it can work on all platforms.
We can continue work on the 2 ways out for long term.
Do you think it's sufficient to fix this test? @nashif

closing this as we have a solution already.


Split (unit) tests from garden-build

What would you like to be added:
Currently the whole logic for (unit) tests is built into garden-build which makes it very complex and difficult to handle tests that should be called from a final artifact. Therefore, we should split this and create a new garden-test script that contains all the needed tasks. Next to this, this should be called after the artifact/image got created and perform the tests.
Why is this needed:
We will need further tests that may need a final artifact, as well as a executing tests on a running OS.

PR https://github.com/gardenlinux/gardenlinux/pull/684 is ready for review.
The mentioned PR solves this issue.


[bug 1153120] show linkedin username or old url

Coverage decreased (-0.04%) to 92.911% when pulling 481152f3bcebc6f33c6b199923ce4933248e9de3 on Mte90:Mte90/1153120-rebase into 907f996b7aa7d0157a34a1866acdd22a952ea5f0 on mozilla:master.

Coverage decreased (-0.04%) to 92.91% when pulling 69b2049d376c412a52ef697eec2b4ec42afa84cd on Mte90:Mte90/1153120-rebase into 907f996b7aa7d0157a34a1866acdd22a952ea5f0 on mozilla:master.

Coverage decreased (-0.04%) to 92.91% when pulling 69b2049d376c412a52ef697eec2b4ec42afa84cd on Mte90:Mte90/1153120-rebase into 907f996b7aa7d0157a34a1866acdd22a952ea5f0 on mozilla:master.

Coverage decreased (-0.04%) to 92.91% when pulling 69b2049d376c412a52ef697eec2b4ec42afa84cd on Mte90:Mte90/1153120-rebase into 907f996b7aa7d0157a34a1866acdd22a952ea5f0 on mozilla:master.

Unit test added, I am waiting a confirm for that before merge again the commits :-)

Coverage decreased (-0.003%) to 92.95% when pulling 021e8420ba49c394d4a57dcbe5bb28983408e425 on Mte90:Mte90/1153120-rebase into 907f996b7aa7d0157a34a1866acdd22a952ea5f0 on mozilla:master.

Thanks @Mte90, it looks good. Please go ahead and squash the commits.

Done!

Coverage decreased (-0.0008%) to 92.95% when pulling 0bcf7dc2aa1c0e8eecfa578e7c42d34df91dea97 on Mte90:Mte90/1153120-rebase into 9bd3419c7a8ee579b1eedb01a60e4c96e30de08d on mozilla:master.

Merging since this is approved.


Mod crash - (0.1.5)

The mod Spawner alert (0.1.5) caused a non-recoverable error.
Please report this to mod author.
Error while running spawner-alert::on_nth_tick(60)
_ spawner-alert _/control.lua:74: attempt to index field '?' ( a nil value)
stack traceback:
_ spawner-alert /control.lua:74: in function
< spawner-alert _/control.lua:54>

Hi,
Can you please give more insights about the error ?
When does the crash happen ? Can you provide a save so i can reproduce it locally ?
Thanks!

Sure - auto save attached. As soon as pollution ticks over to the biter base near spawn to the West, it crashes.
_autosave3.zip

Huum, that's weird, it didn't crash for me when i ran your save.

Are you playing in a MP server ?

I loaded save, immediately removed the burner miners and reduced pollution. This allowed another 30-40 min of play. But as soon as I generate pollution to hit that biter spawner, it crashes: (Just now; new autosave
_autosave1.zip
attached)

Can you try to disable then enable the alerts with SHIFT + I ?

Seems to be working after disable and re-enable of alerts - I'll keep puttering around and see if I can get more info on what exactly it's issue is.
I went thru an entire 70+ hour campaign on a railworld map to launching a rocket and had no issues whatsoever with it, started this deathworld, and as soon as pollution was eaten by biter spawner, it would fatal crash.

Normally it shouldn't happen anymore. Disabling/enabling the alerts resets the internal state.
I think i know why you had the crash the first time, its the combination of several (rare) factors.
Anyway, keep me posted if the mod crashes again. I'll keep this issue open.

Once I reset it, had no further issues, got it to where I could see the alerts. Will have to try on another world this one was unsustainable (I screwed up! :D)  Great mod though, has saved me several times.

New world; same thing- as soon as pollution ticked the biter-spawner, crashed. Reloaded auto-save, immediately hit Shift + i, and toggled off and on, and no problems since.
Maybe have a help window come up to show people "this is how you use it" and have them auto-toggle on/off, or set it to do that on first load?

Alright, thanks for the additional information.
The mod shouldn't crash in the first place, so adding a help window isn't an actual fix.
The bug will be fixed in the next release!

Should be fixed in 201a922e92fe28afdf2ead9342c262f089ad5aad (v0.1.6).


Implement create user role

-- DRAFT --

Codecov Report

Merging #1316 (11fc830) into main (1d7c14e) will increase coverage by 17.23%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             main    #1316       +/-   ##
===========================================
+ Coverage   55.43%   72.66%   +17.23%
===========================================
  Files          26       38       +12
  Lines         359      633      +274
  Branches       25        0       -25
===========================================
+ Hits          199      460      +261
- Misses        154      161        +7
- Partials        6       12        +6

Impacted Files
Coverage Δ

...Controllers/MarketParticipantUserRoleController.cs
0.00% <ø> (ø)

...taHub.WebApi/Controllers/Wholesale/Dto/BatchDto.cs
0.00% <0.00%> (-100.00%)
:arrow_down:

...gistration/HealthEndpointRegistrationExtensions.cs
45.45% <0.00%> (-36.37%)
:arrow_down:

...WebApi/RequireNonNullablePropertiesSchemaFilter.cs
80.00% <0.00%> (-8.00%)
:arrow_down:

apps/dh/api-dh/source/DataHub.WebApi/Startup.cs
96.38% <0.00%> (ø)

...sts/Integration/Controllers/ControllerTestsBase.cs
100.00% <0.00%> (ø)

...taHub.WebApi.Tests/Integration/HealthCheckTests.cs
100.00% <0.00%> (ø)

.../DataHub.WebApi.Tests/Integration/EndpointTests.cs
100.00% <0.00%> (ø)

...ration/Controllers/MeteringPointControllerTests.cs
100.00% <0.00%> (ø)

...ce/DataHub.WebApi.Tests/Fixtures/WebApiTestBase.cs
100.00% <0.00%> (ø)

... and 7 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Laggy group messages / memory pruning [bug][performance]

@dzcode: "..I have had to leave the Nostr and Amethyst Users Public Channels, because the constant stream of posts on both channels was making the app lagging too much.
Am option to disable automatic updates to (some) Public Channels (as well as notifications of new messages) could be very useful."
@vitorpamplona: "I was not expecting this amount of messages for sure. Gotta figure out a way to prune the memory."
https://damus.io/note14unlmhrm58kaf2alq2qpw4nc9e5yjvwaatvqc267nplveqxm85qqmngttx

same here, and many crashes. Leave those public channels will feel much better.

Are we still having this issue? We did improve the rendering of chats in many versions. Can we close this?


[capstone] Update to 4.0.2

https://www.capstone-engine.org/Version-4.0.2

Cools! Thanks @ceeac :)


RegExp helper please

A user wants to strip out blank lines, but that requires a RegExp to be used.
A simple handler such as:
function hb_regexp(text) {
    return new RegExp(text, "g");
}

Handlebars.registerHelper('hb-regexp', hb_regexp);

This will allow a user to use an expression to remove break lines from the HTML of item/actor descriptions, such as:
{{{more-handlebars-helpers-sanitize (more-handlebars-helpers-replaceAll system.description.value (more-handlebars-helpers-regexp '\n<hr />') '') }}}

(The "\n" isn't recognised by the basic replaceAll function)

You got it! This is a really cool orthogonal helper to put in.
Would you like the flag to be optional with a default to "g"? Asking on behalf of the "i" flag.

Concerning optional, I guess the RegExp could take a second optional parameter, which would be the flags passed as the second argument for the RegExp constructor.  Much better for those who like more than just "g" :-)

Version 1.2.0 has released. Give it a go, and if things are working, go ahead and close the issue.

It is working just fine. Thanks for the rapid turn-around!

Thank you both! We have rendering stat-blocks!

It just needs the Cause/Effect text better formatted now 😉

Baby-steps lol.


Update dependencies

We need to update all dependencies, especially critical ones like the Monaco editor. They need to be up to date so we will be able to maintain the codebase in the future and include any bugfixes that were done.

Status update:

#324 upgrades all dependencies except those related to Apollo and monaco-languageclient + vscode-jsonrpc
Upgrading monaco-languageclient and switching to vscode-ws-jsonrpc is a larger task we can break out
Upgrading to Apollo 3 is also a larger task that will require some refactoring and using hooks instead of the projectMutator
The upgrades caused a regression:

Open a new project
Deploy a HelloWorld contract
Click on the Transaction template
The HelloWorld contract is not found on 0x01 until a page reload

Playground monaco editor is currently on v0.33 whereas most current is v0.34. no updates needed for the time being
Apollo 3 upgrade will still require projectMutator class to be refactored https://github.com/onflow/flow-playground/issues/283


chore(main): release 0.1.3

:robot: I have created a release beep boop
0.1.3 (2024-09-22)
Bug Fixes

include switch in device and implement turn on / off methods (689e91f)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/kasperiio/smartevse-2-custom-component/releases/tag/v0.1.3 :sunflower:


fix p-tuning inaccuracy, because output logit contains virtual token …

…length

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Thanks for the contribution! Can you elaborate on what the issue is and how this fixes it?

The issue happens when we evaluate the PEFT model of prompt tuning. for instance, p-tun adds virtual token embedding in front of input token embedding, so the logit len = inplen + virtual token len.  To get the logit of cont token. it should get the [logit_len - contlen: contlen ] instead of [inplen-contlen:contlen], or else the acc will be incorrect. For other PEFT like lora,where logit_len = inputlen, the change will not impact the original logic as well.

model_ptun.zip

@haileyschoelkopf , Hailey, any progress on your validation? Thx.

with p-tuning wouldn't prompt-embs be added to very single rolling_token_windows? wouldn't this affect the PPL evaluation as well?

yes. see https://github.com/huggingface/peft/blob/main/src/peft/peft_model.py#L897-L902, but the loss will not be affected, since label is not extend by filling with -100

not reasonable :), have you tried my pr?

I'm sorry that this took so long to follow up on!
Applied a change to this PR branch that should be equivalent to your fix at batch size = 1, and accounts for the fact that inputs will be right-padded for calculating loglikelihoods.

I'm sorry that this took so long to follow up on!
Applied a change to this PR branch that should be equivalent to your fix at batch size = 1, and accounts for the fact that inputs will be right-padded for calculating loglikelihoods. If this looks good to you, we can merge!

the change looks good to me. you could merge it


New Device Classes in HA 2023.04

https://www.home-assistant.io/blog/2023/04/05/release-20234/#other-noteworthy-changes
[@emontnemery](https://github.com/emontnemery) added energy storage and volume storage device classes;
these will allow differentiating between, for example, consumed energy versus stored energy in a battery.

battery: Percentage of battery that is left in %
energy: Energy in Wh, kWh, MWh, MJ, or GJ
energy_storage: Stored energy in Wh, kWh, MWh, MJ, or GJ
I'm thinking some of the devices should possibly use the new class

sensor.solaredge_b1_available_energy:
      device_class: energy_storage
sensor.solaredge_b1_maximum_energy:
      device_class: energy_storage

I haven't had a chance to look at release notes yet, but I will.

This has been added starting with v2.2.14-pre.4


Remove more uses of tan() in reduction tests.

This is to avoid subtly brittle tests. Tan() is an ill-conditioned function to evaluate near it's singularities.

Thanks, Rasmus!


Update baseUrl to the new tbcscans domain

Checklist:

[ ] Updated extVersionCode value in build.gradle for individual extensions
[ ] Updated overrideVersionCode or baseVersionCode as needed for all multisrc extensions
[ ] Referenced all related issues in the PR body (e.g. "Closes #xyz")
[ ] Added the isNsfw = true flag in build.gradle when appropriate
[ ] Have not changed source names
[ ] Have explicitly kept the id if a source's name or language were changed
[ ] Have tested the modifications by compiling and running the extension through Android Studio
[ ] Have removed web_hi_res_512.png when adding a new extension

where are you getting this new domain from?
you also need to bump the extVersionCode in build.gradle, as well as test these changes

aaah really sorry didn't knew more was required. an for the domain i use this extension a lot to read one piece because i like the translations job they do so right now if you try to use the extension it will give you 502 and if you have the extension install an try to update a manga from there will give you an error. so i verified in my laptop and the old domain is down i look for the new one an is the one i change
so let me get this right. i have to clone the repo bump the version and run the tests? or do i need to do something else


Removed swatch in favor of watchified bundles in dev middleware.

Removed swatch and added mendel-requirify to the dev middleware bundlers to generate server side files on demand without significant overhead.
Loader detects if serveroutdir exists, it can be queried through isSsrReady method, also available in the middleware through req.mendel.isSsrReady.
Improved mendel-requirify so that it doesn't add __mendel_require_() to node_modules dependencies.
Improved dev middleware watchified bundles speed by re-bundling on update, which handles client and server side.
Fixed tests

Code-wise this looks good. I will test a bit once I get a chance.
Architecture-wise I am not very found of the approach, since this means we have to start in development mode without any application code and wait for the browser to request the javascript file in order to have some code to server side render.
It also have a pitfall, if an application uses package.json with "browser" and "main" entries, you will get the browser version compiled as a server-file.
I think this is better than what we have and will enable us to move forward. But we are still without a final solution for server-side-development.
Let's test this on the internal projects and talk more in person.
👍

Fixed comments and example app.


Add E2E tests

We should add some simple E2E tests (using the E2E test framework from Oasis Core) that make sure that a trivial runtime based on the runtime-sdk works correctly with the specified version of Oasis Core and the various client-sdk implementations.

ts side is in with #51


Db evidence selection

Pull request to merge the changes made for adding the statements with database evidences in the curation pages.

Other things to fix:

[ ] The go curation page seems to not sort statements /curate/go/GO:0003677
[ ] /curate/entity/pubmed:11261874?include_db_evidence=false&filter_curated=true errors for filter_curated=true


Please make custom theme tutorial more descriptive

I'm submitting a ...  (check one with "x")
[ ] bug report => search github for a similar issue or PR before submitting
[ ] feature request
[x] support request/question

Current behavior

I am trying to implement a custom theme, but official guide (https://github.com/Gbuomprisco/ng2-tag-input/blob/master/docs/custom-themes.md) is not descriptive enough. It doesn't say where to put theme's (.scss) file or how to make our own component aware of said file and how to use it inside component's html file. Do I have to put it inside my node_modules\ng2-tag-input\dist\modules\core\styles\themes folder? Or is there other way? Do I need to modify any files in my angular-cli project to make it work? Do I need to install any additional libraries like scss support? How do I attach it to my component so that I can use it? etc.
Expected behavior

I followed all the steps in official custom theme guide, but I don't know how to use created .scss file in my angular-cli project. I'd like to be able to do that.
Minimal reproduction of the problem with instructions (if applicable)

Generate new angular-cli project
Generate new component called MyComponent
Add newest ng2-tag-input library into project
Follow official guide for custom theme, create .scss theme file inside MyComponent's folder
???

What is the motivation / use case for changing the behavior? (if applicable)

I am writing here because I want to style my ng2-tag-input and I think others might want to do it too and may not be fluent with technologies like scss
What do you use to build your app? (SystemJS, Webpack, angular-cli, etc.). Please specify the version

I am using default angular-cli v1.0.0
Angular version:

^4.1.1
ng2-tag-input version:

^1.2.5
Browser: [all | Chrome XX | Firefox XX | IE XX | Safari XX | Mobile Chrome XX | Android X.X Web Browser | iOS XX Safari | iOS XX UIWebView | iOS XX WKWebView ]

Firefox 53.0.2 (32 bits)

Hi @Celebes,
Check out the demo here and especially this file https://github.com/Gbuomprisco/ng2-tag-input/blob/master/demo/home/home.scss.
You do not need to put your file in node_modules, but anywhere in your project, as long as you import it in the parent component containing ng2-tag-input.

Here's how I did it:

I created a new Angular component where I used tag-input with attribute theme="custom-theme", for example:

  <tag-input [(ngModel)]="invitationEmails"
             theme="custom-theme">
  </tag-input>

I created new file custom-theme.scss in the same folder as my new component (ofcourse make sure your path to _core.scss in import is correct):

@import "../../../node_modules/ngx-chips/core/styles/core/_core.scss";

$custom-primary: #707070;
$custom-primary-dark: #343434;

$custom-theme: (
  container-border-bottom: none !important,
  container-border-bottom-focused: none !important
);

$custom-tag-theme: (
  background: $custom-primary,
  background-focused: $custom-primary-dark,
  background-active: $custom-primary-dark,
  background-hover: $custom-primary-dark,
  color: #fff,
  color-hover: #0FF,
  border-radius: 0px,
  font-family: 'nimbus-regular'
);

$custom-icon-theme: (
  fill: #fff,
  fill-focus: #eee,
  transition: all 0.35s
);

/deep/ .ng2-tag-input.custom-theme {
  @include tag-input-theme($custom-theme);
}

/deep/ .ng2-tag-input.custom-theme tag {
  @include tag-theme($custom-tag-theme);
}

/deep/ .ng2-tag-input.custom-theme tag delete-icon {
  @include icon-theme($custom-icon-theme);
}

/deep/ .ng2-tag-input.custom-theme .progress-bar {
  display: none !important;
}

In my component's typescript file I added my new theme in styleUrls attribute of @Component annotation:

@Component({
  selector: 'app-custom',
  templateUrl: './custom.component.html',
  styleUrls: ['./custom.component.css', './custom-theme.scss']
})

And that's it, should work now.

Thanks! It turned out that :ng-deep wasn't working

@Gbuomprisco how I change the input background color? My app's background it's not white.

I know this is closed but I am still having issues with this because my variables are bootstrap variables for the colours that matches my bootstrap theme, I can not use them as they give error. How can I make the component also recognise bootstrap variables that are imported with the cli? Or do I just have to create variables in the file once again?

Ok I managed to get it working. I had to refer to the scss file from the component and put it in the same folder by taking it out from the usual bootstrap scss build chain. But import all my functions and variables again for this scss only so I can use my variables and functions.

For all the guys who have issues with changing style, you can override the ngx-chips style. In my case i needed to change the width of the text-input and placeholder, so instead of creating a custom theme, you can use, in your css or scss file, the ::ng-deep special selector for an specific class. It took me 1 week or so to achieve this and to understand it completely. Im using angular 8, and ngx-chips 2.1.0
This is how i changed width and font for  in the css file  of my component:
.card-body {
display: inline-flex;
}
.search-img {
cursor: pointer;
position: absolute;
padding: 10px;
}
THIS IS THE PART PREVIOUS MENTIONED
::ng-deep .ng2-tag-input__text-input   {
width: 600px;
font-family: "Arial";
/display: none !important;/
}
I hope this is help you all, cause i had to figure it out by my own, if you have any questions, please let me know.


Import export Error

How to reproduce

Start 3bot server

create some nodes

do an export

j.data.bcdb.export()

close threebot server

do an import
example:

 j.data.bcdb.import_(path="/sandbox/var/bcdb_exports/10_Mar_2020_14_16_33")

after @zaibon  suggested adding
https://github.com/threefoldtech/jumpscaleX_core/blob/9bada8d884a4e07f2118e91f89d4a9ced0c7f713/JumpscaleCore/data/bcdb/BCDB.py#L566
you will get the following error

This breaks the storclient interface, the fix done in this commit needs to be refactored to keep all the storclients consistent with the interface:
https://github.com/threefoldtech/jumpscaleX_core/commit/e8ca3d939aa98472300afdcd482e48d8fe38f442

Where is the storclient interface defined ?

Fixed:
commits:
cad68ae7c52ee4f54965453238bebef36c80f76c
https://github.com/threefoldtech/jumpscaleX_threebot/commit/60793aceabe356725408f38048fe8ead7abfb9d6

storeclient related to zdb.
validate that the schema is saved with it's the latest state before exporting.
bug in the name of function threebot_zdb_sonic_start to be  start_servers_threebot_zdb_sonic.

Verified on unstable branch.
** Scenarios 1 **  export and import database
** Scenarios 2 **  change in bcdb and export then import
Verification steps:
Scenarios 1

Start 3bot server j.servers.threebot.start(background=True)

Export bcdb j.data.bcdb.export()

close threebot server

Import bcdb j.data.bcdb.import_(path="/sandbox/var/bcdb_exports/15_Mar_2020_09_28_07/")

Scenarios 2

Start 3bot server j.servers.threebot.start(background=True)

Add package
gedis = j.clients.gedis.get("pm", port=8901, package_name="zerobot.packagemanager")
gedis.actors.package_manager.package_add(path="/sandbox/code/github/threefoldtech/jumpscaleX_threebot/ThreeBotPackages/tfgrid/registrygeneric")

do an export
j.data.bcdb.export()

close threebot server

Import bcdb j.data.bcdb.import_(path="/sandbox/var/bcdb_exports/15_Mar_2020_09_38_07/")

check the existence of data
j.data.bcdb.instances.registry.get_all()


feat: add certificate rotation support

Description
Title

Testing required outside of automated testing?

[x] Not Applicable

Screenshots (if appropriate):

[ ] Not Applicable

Rollback / Rollforward Procedure

[x] Roll Forward
[ ] Roll Back

Reviewer Checklist

[ ] Description of Change
[ ] Description of outside testing if applicable.
[ ] Description of Roll Forward / Backward Procedure
[ ] Documentation updated for Change

:tada: This PR is included in version 1.1.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Streams tech systest cherrypicks

@guozhangwang @enothereska @ewencp @ijuma @ymatsuda
Cherrypicked commits which make it possible to run downstream muckrake system tests
Notes:

the muckrake streams preview job is currently pinned to this branch, and system tests passed there:
https://jenkins.confluent.io/job/cp-streams-preview-system-tests/3/console

Kafka system tests on this branch pass with the exception of streams tests, which are also broken in 0.9.0-cp-2.0.1-with-streams-tech-preview. Perhaps @ymatsuda can help sort this out in another PR?

The modified vagrant-related files simplify testing by allowing parallel cluster bringup

LGTM overall.
About the duscktape failures, could you point me to some examples if they are in Jenkins?

@guozhangwang
In progress:
https://jenkins.confluent.io/job/kafka_system_tests_branch_builder/370/console
(you should be able to browse the workspace for the job as well)
Once finished, results will be uploaded here:
http://testing.confluent.io/confluent-kafka-branch-builder-system-test-results/

LGTM too


end_point is not incrementing within the functions

Hey there,
First of all, great stuff, I've been trying to do this for a while now but hadn't thought to use the average outcome. Brilliant!
Issue: because you are importing the globals.py which imports the settings.py within the function calls (current_pattern, pattern_storage, pattern_recognition), you are using the initial endoints within the functions (you can see it prints the same real_outcome every time...).
In the main.py the end_point gets incremented correctly but unfortunately that value is not used by the functions. You can check by printing the end_point from the functions and see for yourself.
Me because I'm no python master, I've just chosen the easy way around and initialized the end_point in the main.py and then pass it to the functions as a parameter rather then importing it from settings.py (and of course, removed end_point assignment from settings.py).
Cheers,
Dan
PS: running it now, seems to have the same overall accuracy with the change, will update when done running

Finished running: it still has very good results (85% vs 92% on a dataset of mine). Was a bit worried that the change will ruin everything :)


[GHSA-78xj-cgh5-2h22] NPM IP package vulnerable to Server-Side Request Forgery (SSRF) attacks

Updates

Affected products

Comments
Version 2.0.0 is vulnerable as well

Duplicate of: https://github.com/github/advisory-database/pull/3504


feat: generalize select_n dispatch

Now the dispatch uses a non-Q selector for a set of Q cases.
Addresses problem identified in private communication.

The example in the docs will get run as a doctest, right? So don't need to add a separate unit test?

Yes!

@adrn do you need a bugfix release?

Not urgently


add this.req check at querystring() method

If connection drop by client-side and use post-query logging (for example winston wrapper), then cause a error "Cannot read property 'url' of undefined" at parse() method
This pull request fix a problem

can you add a test and an explanation in the test case?

8804b7ba6f7d85626970d1ea636ac002488d9095


4664: Moved WelcomeActivity to ViewBinding

Fixes #4664
What changes did you make and why?

Issue: As per the information provided and work request on the ticket above, WelcomeActivity.java is currently using Butterknife to to inject views into Android components.
Solution: Hence migration was done by replacing butterknife with viewbinding, which is always null safe, type-safe and supports both Java and Kotlin.

Hi @psh ,
I need little help regarding error showing on WelcomeActivityUnitTest.kt file.
Run test step failed due to error on this file, and says below:

I made the changes as it says in these lines, but I kept getting error.
I tried to run other test classes , like AccountUtilUnitTest.kt and it have failes due to same problem -
Could not initialize plugin: interface org.mockito.plugins.MockMaker (alternate: null)
Refer to the error image below please.

Requesting help to fix/merge this PR

@dbrant Requesting to review this PR

Hi @psh Can you review this PR?


Feature request - use floats for base-call quality averages for jsa.np.filter params

Hi again,
Integers are used for Phred base-call quality values for individual bases because they can easily be ASCII-encoded. However, when average values are taken over a read for base-call qualities, the use of floats has advantages, given the coarseness of the Phred scale. Currently, the '--qualMin' and '--qualMax' params of jsa.np.filter (which by definition concern average base-call quals) accept integer values, but the use of floats for these params and the related filtering calculations would allow e.g. for the creation of finer-grained error-profiles for a read dataset.
Thanks for your consideration of this request!

Just fixed it and made a push. If you pull the newest version of japsa and run a test with it, that'd be great!
About to make a release soon on July and will update the documentation.
Thank you very much for the feedback!

Thanks!
I’ve pulled the latest changes and am running my updated analyses overnight.
I’ll get back to you tomorrow with the results and some background information that you may find interesting.
Best wishes,
Robert
P.S. Completely understand and agree with your explanation about the np.reader issue.
From: hsnguyen<EMAIL_ADDRESS>Sent: Saturday, June 17, 2017 7:12 PM
To: mdcao/japsa<EMAIL_ADDRESS>Cc: Boissy, Robert J<EMAIL_ADDRESS>Author<EMAIL_ADDRESS>Subject: Re: [mdcao/japsa] Feature request - use floats for base-call quality averages for jsa.np.filter params (#14)
Just fixed it and made a push. If you pull the newest version of japsa and run a test with it, that'd be great!
About to make a release soon on July and will update the documentation.
Thank you very much for the feedback!
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/mdcao/japsa/issues/14#issuecomment-309248088, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AHyHo9-fHUsGiQej5v10xyTLx0uxeN7rks5sFGtfgaJpZM4N9Uc7.
The information in this e-mail may be privileged and confidential, intended only for the use of the addressee(s) above. Any unauthorized use or disclosure of this information is prohibited. If you have received this e-mail by mistake, please delete it and immediately contact the sender.

Your changes worked really well, thanks again!


⚠ Second-Chance-Element (Production) has degraded performance

In 60c72e6, Second-Chance-Element (Production) ($SECOND_CHANCE_ELEMENT) experienced degraded performance:

HTTP code: 502
Response time: 8763 ms

Resolved: Second-Chance-Element (Production) performance has improved in 1baf67b.


Rework how unread messages are managed

Handle UPDATE_MESSAGE_FLAGS events from server
Add functions for 'unread message count'
Extract all message flags data to a separate reducer (performance reasons)
Immutably transform the flags, replace old mutating code
Add tests
Handles all types of flags, not just 'read'

This way of handling the data is essential for us to be able to display unread counts, and to use the other flags correctly.

Automated message from Dropbox CLA bot
@borisyankov, it looks like you've already signed the Dropbox CLA. Thanks!

After last comment, if you agree I think it is ready to merge.

Rebased against latest master.

I think flags separate from messages I definitely a step in the right direction.
Maybe we should separate some more of this later (or not).
Think of the messages API response of a strongly denormalized data, and we should not expect our internal structure to be optimally equal to it.
On the other hand we do not run a relational DB engine, so fully normalized data will be a mess (and also not optimal for Redux).


Updates pricing and limits in Workers Static Assets

Includes updates to pricing information for storing assets on Workers, as well as file size limits

We should probably make an Assets section in the limits page and add there - https://developers.cloudflare.com/workers/platform/limits/


Properties location?

Since updating from version 2.5, I am unable to use "pyscf.prop"
Checking the code, I cannot find it or the rest of the properties that the module had.
It migrated somewhere else that I cannot find.?
I would appreciate any help with this 😊

It is now a PySCF extension: https://github.com/pyscf/properties
On Thu, Jun 6, 2024 at 11:08 AM n00b-0K @.***> wrote:

Since updating from version 2.5, I am unable to use "pyscf.prop"
Checking the code, I cannot find it or the rest of the properties that the
module had.
It migrated somewhere else that I cannot find.?
I would appreciate any help with this 😊
—
Reply to this email directly, view it on GitHub
https://github.com/pyscf/pyscf/issues/2251, or unsubscribe
https://github.com/notifications/unsubscribe-auth/ADGAJC74FME3IIBYWMSODH3ZGB3O3AVCNFSM6AAAAABI455LMWVHI2DSMVQWIX3LMV43ASLTON2WKOZSGMZTQNBZGQ2DAMI
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

thanks


Formainpr

Consolidated multiple branches into one:
cora
CORA_test
cora-test
lohindast
Code and script cleanups and fixes.
Deployment, CORA Adcirc, and Liveocean tested.

@ZacharyWills @mykelalvis can you take a look at this PR and provide thoughts/approval?


Automatically determine the number of sensors

If n_sensors isn't passed to the brain during initialization, automatically determine it.

After thinking about this some more, I'm not sure it would add anything. Closing it unfixed for now.


How use to create chat?

i want create a chat function using your code, How i can do?
please details steps.. thanks

Have a look at the /survey command :+1:

Sir How to send or forward Message Result from /survey comand to admin bot? @noplanman


chore: bdd-nh-import-1585927453 to 0.0.1

chore: Promote bdd-nh-import-1585927453 to version 0.0.1

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approvers:
If they are not already assigned, you can assign the PR to them by writing /assign  in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


Can i use this using Windows 11 with WSL?

hello, just wanna know if this template can run via WSL on Windows 11.
cause everytime i try to run the build command, its always produce error like:
[stage-2 22/24] RUN composer install     --classmap-authoritative     --no-interaction     --no-ansi     --no-dev     && composer clear-cache:
0.208 exec /bin/bash: no such file or directory
ERROR: failed to solve: process "/bin/bash -eou pipefail -c composer install     --classmap-authoritative     --no-interaction     --no-ansi     --no-dev     && composer clear-cache" did not complete successfully: exit code: 1
Thankyou.

try doing a composer update in your project before building the docker container

try doing a composer update in your project before building the docker container

i've do that before. but lemme try again

hey, im really new on docker:(
can someone give me the very basic tutorial to run this template? since idk, the build is success, but its return error like this when im tryna to run it in http mode
2024-12-18 15:41:08 env: can't execute 'sh
': No such file or directory
2024-12-18 15:41:51 env: can't execute 'sh
': No such file or directory


(chores) camel-tooling: use unmodifiable lists when possible

The failure is unrelated, it should be safe to merge.


getChildElement(index) return element itself

Hi,
First of all, thanks a lot for this great project!
I encountered an issue when trying to get the child element with getChildElement().
const select = Selector(id => document.querySelector(`${id}`));

test('base', async t => {
  await t;
  const base = await select('#base'); // get #base
  const child10 = await base.getChildElement(10); // get #base while expect to get the 11th child element

  // tests
  // ...
});

Instead of getting the child element I always get the parent element itself.
Can someone help?

Got solution from discuss.


Request/Response Buffering API support

Feature
I would like a direct API in envoy gateway to enable request and response buffering. As of today this can be achieved by using either Buffer filter to enable request buffering or using File System Buffer filter to enable request and response buffering with help of EnvoyPatchPolicy.
I don't wish to use EnvoyPatchPolicy in production hence would prefer an api in envoy gateway.
Use Case
One of our main reasons for setting up envoy gateway is to have a layer between our upstream servers and aws ALB which can buffer both requests and responses to prevent slow DDoS attacks. The reasons are explained further in detail in point 1 and 2 of What is it Good For section of File System Buffer documentation as well :

To shield a server from intentional or unintentional denial of service via slow requests. Normal requests open a connection and stream the request. If the client streams the request very slowly, the server may have its limited resources held by that connection for the duration of the slow stream. With one of the “always buffer” configurations for requests, the connection to the server is postponed until the entire request has been received by Envoy, guaranteeing that from the server’s perspective the request will be as fast as Envoy can deliver it, rather than at the speed of the client.
Similarly, to shield a server from clients receiving a response slowly. For this case, an “always buffer” configuration is not a requirement. The standard Envoy behaviour already implements a configurable memory buffer for this purpose, that will allow the server to flush until that buffer hits the “high watermark” that provokes a request for the server to slow down.

Some of our upstream servers run on a request per thread model, so above types of attacks become very critical for us as it can quickly lead to server downtimes.

isnt this already supported https://gateway.envoyproxy.io/docs/tasks/traffic/client-traffic-policy/#configure-downstream-per-connection-buffer-limit ?
cc @yaelSchechter

@arkodg i think bufferLimit field in ClientConnection defines the buffer size of the connection with downstream(by default which is 32KB). Buffer /File System Buffer filters on the other hand are for requests coming on those connections, and used to define if the request should be buffered in memory/disk or not and the size they specify are of the requests and not connection buffer. Please correct me if I am wrong here.


MWPW-143192: Merch card with 2 CTAs and secure transaction label

This PR enables the option of adding 2 CTAs along with the "Secure transaction label" to all Merch card variants and display them properly.
Resolves: MWPW-143192
Tacocat related PR: https://git.corp.adobe.com/wcms/tacocat.js/pull/550
Test URLs:

Before: https://main--milo--adobecom.hlx.page/drafts/axel/bug-fixes/mwpw-143192
After: https://MWPW-143192--milo--axelcureno.hlx.page/drafts/axel/bug-fixes/mwpw-143192

@Axelcureno

In the after link, the merch card CTA alignment is disturbed in mobile

2. In desktop mode the Quantity selector is misaligned:

Mini Compare chart card alignments will be fixed here https://github.com/adobecom/milo/pull/2093 @Roycethan

Closing since it's already integrated in milo


Make public to be able to use IPAddress class in other packages

@hakonhall Please review

I thought of that myself... I'm gonna need to differentiate between other execs too quite soon.


Add new config entries from 2.x documentation

Resolves #2

@BDelacour thanks for your great work


undefined is not an object (evaluating 'tree.get') when using app.router()

Source:
import server from 'bunrest'

const app = server()
const router = app.router()

router.get('/', (req, res) => {
  res.status(200).json({ message: 'Router succeed' })
})

app.listen(3000, () => {
  console.log('App is listening on port 3000')
})

Error:
undefined is not an object (evaluating 'tree.get')
λ() node_modules/bunrest/src/server/server.ts:132:21
      async fetch(req1: Request) {
        const req: BunRequest = await that.bunRequest(req1);
        const res = that.responseProxy();
        const tree: TrieTree<string, Handler> =
          that.requestMap[req.method.toLowerCase()];
        const leaf = tree.get(req.path);
        /*          ^ happened here    */

Stack trace:

  λ() node_modules/bunrest/src/server/server.ts:132:21

Info:

bun v0.2.2
macOS 13.2.0 (Apple Silicon)
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/15.5 Safari/605.1.15
Pathname: /

This works (no router):
import server from 'bunrest'

const app = server()

app.get('/', (req, res) => {
  res.status(200).json({ message: 'Router succeed' })
})

app.listen(3000, () => {
  console.log('App is listening on port 3000')
})

@selfagency Thank your for your feedback, I was able to reproduce the problem.

@selfagency Thank your for your feedback, I was able to reproduce the problem.

quick fix:
You need to attach router to app, add this line after route.
app.use('/', router);


Add smoke test to stress test

Final split of #21926, will close that one out now.  No changes as compared to that PR but we can continue the discussion here.
This change also moves process exit out to main() (rather than exiting directly from stressTest).  To minimize change to the test I swallow all errors (to approximate process exit with status 0 in the finally block), but really I think it would make more sense to allow the error to throw and exit with -1.  Happy to leave it as-is or change, or could consider a change in a followup PR.
Re: using runWithRetry or reusing the stress container instead of creating a new container with tryNTimes():

I think runWithRetry really only works for errors of type IDriverErrorBase - I'm probably OK limiting retries to just driver (network) errors, but this would retry in fewer scenarios than as currently written.
I favor not reusing the container for two main reasons:

I like having the separation between the two - changes to either smoke or stress can be made without worrying about impacting the other
The loader options for the stress test's document creation are more complex and randomly selected which could produce inconsistent results across random seeds.

AB#9092

PR for exit flows here: #22037


[Error] error parsing regexp: invalid escape sequence: \3

I am using YAML templates and most projects work, there are some exceptions such as the below: i think its usually \1 and \3
Found tool in cache: jfrog 1.26.2 x64
Running jfrog-cli from G:\AzureDevOpsAgent-0_work_tool\jfrog\1.26.2\x64\jfrog.exe.
JFrog CLI version: 1.26.2
Using file spec:
{ "files": [ { "pattern": "G:\AzureDevOpsAgent-0\_work\39\a/Lodgement.Api-develop-20191021.4.zip", "target": "ADV-build/Podium/SalesTools/Lodgement.Api-develop/20191021.4/" } ] }
[Error] error parsing regexp: invalid escape sequence: \3
{
"status": "failure",
[Error] error parsing regexp: invalid escape sequence: \3
[Error] Upload finished with errors, Please review the logs.
"totals": {
"success": 0,
"failure": 0
}
}

@DeadlyDragon,
I have tried reproducing the issue you describe, but it worked for me.
The YAML I tested:
- task: myAzureDevops.jfrog-artifactory-vsts-extension.artifactory-generic-upload.ArtifactoryGenericUpload@1
  displayName: 'Artifactory Generic Upload'
  inputs:
    artifactoryService: 'Artifactory1'
    fileSpec: |
     {
       "files": [
         {
           "pattern": "D:\files1\39/a\a1.in",
           "target": "test-build/Test/uploadTask/"
         }
       ]
     }
    collectBuildInfo: true```
The agent I use is 'windows-latest', Extension version is 1.6.2.

In order to identify the problem, please share with us more details about your execution, such as the build YAML, build agent (windows, linux...), plugin version and execution logs.

Sorry for not getting back sooner. Extension version is 1.6.2, we are using a self hosted agent
We are using AzureDevops Variables to create the pattern so it inserts a double backslash:
- task: ArtifactoryGenericUpload@1   inputs:     artifactoryService: 'Artifactory'     fileSpec: |       {         "files": [           {             "pattern": "$(Build.ArtifactStagingDirectory)/$(Build.DefinitionName)-$(Build.SourceBranchName)-$(Build.BuildNumber).zip",             "target": "ADV-build/$(AssetID)/$(ArtifactoryRootFolder)/$(Build.DefinitionName)-$(Build.SourceBranchName)/$(Build.BuildNumber)/"           }         ]       }     collectBuildInfo: true     buildName: '$(Build.DefinitionName)-$(Build.SourceBranchName)'     buildNumber: '$(Build.BuildNumber)'     includeEnvVars: true
Here is the error again from the logs:
Found tool in cache: jfrog 1.26.2 x64 Running jfrog-cli from G:\AzureDevOpsAgent-0\_work\_tool\jfrog\1.26.2\x64\jfrog.exe. JFrog CLI version: 1.26.2 Using file spec: { "files": [ { "pattern": "G:\\AzureDevOpsAgent-0\\_work\\39\\a/Lodgement.Api-develop-20191021.4.zip", "target": "ADV-build/Podium/SalesTools/Lodgement.Api-develop/20191021.4/" } ] } [Error] error parsing regexp: invalid escape sequence: \3{   "status": "failure", [Error] error parsing regexp: invalid escape sequence:\3 [Error] Upload finished with errors, Please review the logs.   "totals": {     "success": 0,     "failure": 0   } }


HandlerFactories should be functions

What's wrong with the current encoding?

Why should the handler factory methods be lazy vals? Both should work, as the implicit class is instantiated every time I call one of the properties (Handler.inputEvents, Handler.mouseEvents, ...). So the vals would not persist, but there is also no advantage over using def, which is cheaper.

Aaah yes that makes perfect sense! +1


Prototype of infering enums from the database schema

It only works with postgres

This is a resubmitted update version of #940.
Some small things should be fixed(see the todo list) before the pull request is merged. Feel free to comment on the other parts in the meanwhile.
Todo:

[ ] Pretty Printing
[ ] Documentation

Thanks! That looks like a lot of features!
It's also a huge amount of code, though… I'll try my best to find some time to play around with it. One single commit adding 472 lines is not quick to read through 😅 I personally love to read big additions like these in multiple commits that build on each other and whose commit messages tell me the indent of each change.
IIRC, @sgrif mentioned in an earlier discussion about enum inference that he'd like to try to have this in (an) external crate(s). Maybe he can chime to supply his original arguments before I quote him wrong :). @weiznich, do you think this is do-able as an add-on?

Yeah so as @killercup mentioned, I don't think this is a feature that's appropriate for Diesel itself. I'm happy to help you get it set up as a third party crate though. I thought I had mentioned this before, but I can't find it on the issue tracker so it must have been in gitter or I just never mentioned it. Sorry if I haven't made this clear before now.
In general, I think this code should be broken up differently. I think a simpler starting point would be #[derive(PgEnum)], which you place on enums defined in your code. infer_enums! could be built on top of that pretty easily (though I'm not really sure that this needs a macro to infer it. The number of enum types in an application are going to be pretty small compared to the number of tables).

Yeah so as @killercup mentioned, I don't think this is a feature that's appropriate for Diesel itself. I'm happy to help you get it set up as a third party crate though. I thought I had mentioned this before, but I can't find it on the issue tracker so it must have been in gitter or I just never mentioned it. Sorry if I haven't made this clear before now.

I remember only some discussion about mapping enums to primitive types like integers, but it is ok. Would it be possible to host this crate as part of the diesel-rs organization?

In general, I think this code should be broken up differently. I think a simpler starting point would be #[derive(PgEnum)], which you place on enums defined in your code. infer_enums! could be built on top of that pretty easily (though I'm not really sure that this needs a macro to infer it. The number of enum types in an application are going to be pretty small compared to the number of tables).

Good point:+1: This will hide the implementation details fro the actual users. It should be quite easily possible to rewrite the current code to that approach.


[az ad sp create-for-rbac] Command doesn't work in git bash on windows, works fine on cmd

az feedback auto-generates most of the information requested below, as of CLI version 2.0.62

Related command
az ad sp create-for-rbac --name="sp-test" --role="Contributor" --scopes="/subscriptions/<subscription_id>" --sdk-auth --only-show-errors

Describe the bug
Running the command above on Git Bash terminal fails with the error shown below. The exact same command works when run in regular cmd terminal.

To Reproduce

On a windows machine with Git For Windows installed, open a Git Bash terminal
Run the command: az ad sp create-for-rbac --name="sp-test" --role="Contributor" --scopes="/subscriptions/<subscription_id>" --sdk-auth --only-show-errors

Expected behavior
The command works the same, whatever the terminal.
Environment summary

Freshly installed Azure CLI on a Windows 10 machine.
 az --version
azure-cli                         2.42.0

core                              2.42.0
telemetry                          1.0.8

Dependencies:
msal                              1.20.0
azure-mgmt-resource             21.1.0b1

Python location 'C:\Program Files (x86)\Microsoft SDKs\Azure\CLI2\python.exe'
Extensions directory 'C:\Users\sinedied\.azure\cliextensions'

Python (Windows) 3.10.8 (tags/v3.10.8:aaaf517, Oct 11 2022, 16:37:59) [MSC v.1933 32 bit (Intel)]

Legal docs and information: aka.ms/AzureCliLegal

Your CLI is up-to-date.

Additional context
On a 3h workshop where we're using Azure CLI to provision the whole infrastructure, this is the only command not working on a git Bash terminal. Here's the workshop for context: https://azure.github.io/aca-java-runtimes-workshop/#creating-an-azure-service-principal

@jiasli for awareness

I guess it's caused by bash path conversion
Can you MSYS_NO_PATHCONV=1 at the beginning of command and try again?

It worked with MSYS_NO_PATHCONV=1.
Wouldn't it be possible to set this flag directly in the CLI command where no file paths are to be expected to avoid these kind of errors?
Or is there another way to setting a subscription scope that doesn't rely on a starting slash?

You can also export it as environment variable. But this may break other command, I suggest you unset it if you do not use it anymore.
Or use //subscriptions instead of /subscriptions in scope.
is there another way to setting a subscription scope that doesn't rely on a starting slash

I'm afraid not.

Or use //subscriptions instead of /subscriptions in scope.

Thanks for the workaround suggestion. Does this work on all platforms?

No, it only works in Git Bash.


Fix model build issue with AdditionalItems (serialization, validation)

Fix AdditionalItems validation when spec is flattened
Contributes to #866

Models with AdditionalItems now build with swagger generate model --skip-validation ...
Strengthened CI test suite on codegen with server, model and client generations and builds.

Oops! I've seen a glitch in my CI script. I am fixing this right away

.. and appveyor is stuck once again


Blueprint (discuss on issue) mef_eline VLAN range EVPL

Blueprint mef_eline VLAN range EVPL
This is for extending mef_eline to support VLAN range when creating an EVPL.
The API should be extended, of_core, flow_manager should support OF mask match on vlan.
This blueprint should identify the use case, how translations will work, NApps dependencies involved, what needs to be changed, and what's already supported.
I'll assign this one to @ajoaoff since he's started an initial assessment.

Similar to https://github.com/kytos-ng/mef_eline/issues/18. Since we won't have a blueprint, but will only discuss on issue, the discussion can take place on this issue or on he linked one, and then we can close one as duplicated.

of_core seems to support masks on all match fields https://github.com/kytos-ng/of_core/blob/master/v0x04/match_fields.py#L30-L62

I have tested flow_manager with VLAN masks and the only error I found was the pydantic model that has dl_vlan: Optional[int]
When I changed the field to str, flow_manager was able to install the flow.
I removed it manually to test the consistency and it also worked, the flow was reinstalled.

I have tested flow_manager with VLAN masks and the only error I found was the pydantic model that has dl_vlan: Optional[int] When I changed the field to str, flow_manager was able to install the flow. I removed it manually to test the consistency and it also worked, the flow was reinstalled.

@ajoaoff nice, and thanks for anticipating that PR. If you could also break down the dependencies or how the feature will behave (consolidating some of the information that you also shared and researched some time ago on Slack and clarified requirements with Jeronimo), much appreciated. cc'ing also @Alopalao @italovalcy @gretelliz since they're working on related mef VLAN untagged/any and or sdntrace_cp.

Regarding sdntrace_cp, it is used by mef_eline to evaluate if the path is available. This is done by using a sample "packet" matching the UNI and performing a match in each switch. As it is a packet, we can't have a VLAN range in it, just a single VLAN. What do we want here? A single vlan within the range is enough for us to assume the circuit is up? Or we want to test every possible vlan?

Regarding sdntrace_cp, it is used by mef_eline to evaluate if the path is available. This is done by using a sample "packet" matching the UNI and performing a match in each switch. As it is a packet, we can't have a VLAN range in it, just a single VLAN. What do we want here? A single vlan within the range is enough for us to assume the circuit is up? Or we want to test every possible vlan?

I have an impression that a single VLAN should suffice, otherwise we'd be ignoring at the application level that a concept of a matched range is supported by the switches. In terms request payload, probably sdntrace_cp and sdntrace should still be supporting only a single dl_vlan: str, but then sdntrace_cp being able to match accordingly. cc'ing @gretelliz
@italovalcy @jab1982 would you be OK with a single vlan in the payload of traces? based on how you guys will use in production do you see any issues with this approach?

Also, as a range of VLANs, are we only considering a contiguous [low, high] range or more flexibility is needed?

Regarding sdntrace_cp, it is used by mef_eline to evaluate if the path is available. This is done by using a sample "packet" matching the UNI and performing a match in each switch. As it is a packet, we can't have a VLAN range in it, just a single VLAN. What do we want here? A single vlan within the range is enough for us to assume the circuit is up? Or we want to test every possible vlan?

Hey @ajoaoff, good question. Thank you for bringing that up. Just one VLAN is enough, in my opinion. However, I suggest using a "random VLAN inside the expected range". That way we simplify the tests but we also probabilistically cover other possibilities though out the time. Wdyt?

Also, as a range of VLANs, are we only considering a contiguous [low, high] range or more flexibility is needed?

I would suggest more flexibility here, maybe something similar to what was defined for SDX data model (L2VPN):
"vlan_range": [(1,100), {300,305), (1000,1500)]

Some points of attention I see:

UI should be updated to support the VLAN range
VLAN range should keep compatibility with the failover path whenever applicable
We have to add some end-to-end tests for this feature
We should check the flow_stats Zabbix integration wrapper for compatibility when accounting for the traffic of an EVC - to make sure all flows will be considered

Regarding sdntrace_cp, it is used by mef_eline to evaluate if the path is available. This is done by using a sample "packet" matching the UNI and performing a match in each switch. As it is a packet, we can't have a VLAN range in it, just a single VLAN. What do we want here? A single vlan within the range is enough for us to assume the circuit is up? Or we want to test every possible vlan?

Hey @ajoaoff, good question. Thank you for bringing that up. Just one VLAN is enough, in my opinion. However, I suggest using a "random VLAN inside the expected range". That way we simplify the tests but we also probabilistically cover other possibilities though out the time. Wdyt?

UPDATE: Thinking about this I realized that maybe one trace per VLAN/MASK would be enough, instead of my original reply that considers one trace for the whole EVC. Explanation: since the idea of the trace will be to guarantee consistency between mef_eline and flow_manager, we have to make sure all necessary flows for an EVC are there. Thus, suppose you request the following range:
1779-1799

Depending on the strategy to calculate the necessary flows, you may end up requiring more than two flows to implement that. Indeed, the following calculation is one of the possibilities (using Noviflow's syntax):
# plans 1779 to 1799 (using vlan range: 1779/12 + 1780/10 + 1784/9 + 1792/9, where /x means x bits set from the 12 available)
set config flow tableid 0 command add priority 200 matchfields in_port vlan_vid valuesmasks 3 1779 instruction apply_actions action output port 20 ofpff persistent
set config flow tableid 0 command add priority 200 matchfields in_port vlan_vid valuesmasks 20 1779 instruction apply_actions action output port 3 ofpff persistent
set config flow tableid 0 command add priority 200 matchfields in_port vlan_vid valuesmasks 3 1780-4092 instruction apply_actions action output port 20 ofpff persistent
set config flow tableid 0 command add priority 200 matchfields in_port vlan_vid valuesmasks 20 1780-4092 instruction apply_actions action output port 3 ofpff persistent
set config flow tableid 0 command add priority 200 matchfields in_port vlan_vid valuesmasks 3 1784-4088 instruction apply_actions action output port 20 ofpff persistent
set config flow tableid 0 command add priority 200 matchfields in_port vlan_vid valuesmasks 20 1784-4088 instruction apply_actions action output port 3 ofpff persistent
set config flow tableid 0 command add priority 200 matchfields in_port vlan_vid valuesmasks 3 1792-4088 instruction apply_actions action output port 20 ofpff persistent
set config flow tableid 0 command add priority 200 matchfields in_port vlan_vid valuesmasks 20 1792-4088 instruction apply_actions action output port 3 ofpff persistent

Thus, having one trace for each pair of flows (ingress-egress) makes more sense in my opinion.

Also, as a range of VLANs, are we only considering a contiguous [low, high] range or more flexibility is needed?

I would suggest more flexibility here, maybe something similar to what was defined for SDX data model (L2VPN):
"vlan_range": [(1,100), (300,305), (1000,1500)]

If that turns out to be much more complicated, we can leverage the new VLAN string type to do something like:
 {"tag": {"value": "1-100,200-300,400", "tag_type": 1}

Great suggestion, @italovalcy. In the API spec, I think the second suggested option {"tag": {"value": "1-100,200-300,400", "tag_type": 1} is probably easier to maintain, and since this can be also validated as a regex, which has also been shown to work correctly with OpenAPI validations that would be very aligned with what we currently have. Also since parsing this validated str as a unique list isn't that difficult then I believe it would fit well.
Internally, though, @ajoaoff, I'll recommend to try to potentially subclass UNI as UNIRange or something similar. But then the subclass introducing a self.values: List[TAG] and acting as container and overwrite the methods accordingly. That way everywhere whare a UNI object is being used, if a UNIRange is being used, then the caller can differentiate and use it for validation and getting the values.  Each Interface object when using, releasing or checking if a tag a TAG object has been protected with a lock, so we'll also need to ensure that when checking if an entire vlan range is available that the same Interface._tag_lock is also used to avoid race conditions when checking if a range is available.

Thus, having one trace for each pair of flows (ingress-egress) in each direction makes more sense, in my opinion.

Agreed, this sounds better and easier to maintain too. With sdntrace_cp, currently with bulk traces it's always sending a pair of traces (uni_a -> uni_z and uni_z -> uni_a), so it's a matter of sending additional traces and gather the results accordingly. It'll need to reuse part of the logic of how mef_eline will calculate/derive this. Also, when checking for the success of a trace, when a uni has a range, then any trace result should not  not overwrite a false result that for the circuit, adapting that part is relatively simple. Good thing that with bulk trace it's only a single round trip. Btw, thanks for providing the example on NoviFlow.

@italovalcy @ajoaoff, should UNI vlan range always be the same size on both ends? for an EVPL we currently support asymmetric VLANs UNI since it always knows the expected C-VLAN on the other UNI. I think we need to confirm both if the length needs to be the same and also if they can be asymmetrical (different values) or if symmetrical is sufficient.

@italovalcy @ajoaoff, should UNI vlan range always be the same size on both ends? for an EVPL we currently support asymmetric VLANs UNI since it always knows the expected C-VLAN on the other UNI. I think we need to confirm both if the length needs to be the same and also if they can be asymmetrical (different values) or if symmetrical is sufficient.

Hi @viniarck, good question, and great observation! IMHO, we should not support different ranges on the UNIs. If we use a VLAN range, both UNIs should have the same range. Even though we may have use cases for having different ranges, that would be very difficult to implement using OpenFlow rules. Thus, to make it simple and fully compatible with the current data plane implementation, my suggestion is that both UNIs have the same range. Then, when matching ingress traffic in a UNI, we just push the service tag VLAN and output to the next hop port (for intra-switch, we don't even need to push service tag VLAN) - instead of also applying the set_field VLAN as we currently have.

IMHO, we should not support different ranges on the UNIs.

Sounds good, @italovalcy. Thanks for your input and confirming the use case.
@ajoaoff looks like you have all the requirements in place, feel free to start breaking down the tasks on GitHub in the epic_mef_eline_vlan_range epic. If you need anything else to confirm/refine the scope let us know, thanks.

Also, as a range of VLANs, are we only considering a contiguous [low, high] range or more flexibility is needed?

I would suggest more flexibility here, maybe something similar to what was defined for SDX data model (L2VPN):
"vlan_range": [(1,100), (300,305), (1000,1500)]

If that turns out to be much more complicated, we can leverage the new VLAN string type to do something like:
 {"tag": {"value": "1-100,200-300,400", "tag_type": 1}

Great suggestion, @italovalcy. In the API spec, I think the second suggested option {"tag": {"value": "1-100,200-300,400", "tag_type": 1} is probably easier to maintain, and since this can be also validated as a regex, which has also been shown to work correctly with OpenAPI validations that would be very aligned with what we currently have. Also since parsing this validated str as a unique list isn't that difficult then I believe it would fit well.
Internally, though, @ajoaoff, I'll recommend to try to potentially subclass UNI as UNIRange or something similar. But then the subclass introducing a self.values: List[TAG] and acting as container and overwrite the methods accordingly. That way everywhere whare a UNI object is being used, if a UNIRange is being used, then the caller can differentiate and use it for validation and getting the values. Each Interface object when using, releasing or checking if a tag a TAG object has been protected with a lock, so we'll also need to ensure that when checking if an entire vlan range is available that the same Interface._tag_lock is also used to avoid race conditions when checking if a range is available.

Additional comments:

Currently UNIs aren't consuming or releasing vlans from available_tags, it might also be worth trying to address https://github.com/kytos-ng/mef_eline/issues/324, to make it easier to check if a range is still available or not. We'll still need to shares_uni(other) to detect overlapping port-based circuits though, but at least the implementation won't be much more complicated.
Regarding the potential UNIRange, since we don't have a reentrant lock with interface._tag_lock we'll likely need to add additional methods on Interface to use the same lock but taking an iterable as argument like def are_tags_available(self, tags: list[TAG]) -> bool, def use_tags(self, tags: list[TAG]) -> bool, and def make_tags_available(self, tags: list[TAG]) -> bool

Closing this issue, this discussion contains more details about updated features. The epic is in progress and soon to be finnished.


Added configurationpossibilities

I have added a new feature that allows users to configure two settings via the config file. Firstly, you can now specify whether a slash should be included between the absoluteBaseURL and the 'qr/' route in the getQRLink function using the add_slash_on_qr_link configuration option. Additionally, you can control whether the public folder should be utilized for the generated QR code by using the use_public_assets configuration setting.

Hi Moritz,
nice work. I will test this tomorrow!
Regards,
Remy


Add more placeholders to display name

With recent release of wSkeever's mod it is now apparent that any further useful dynamic additions to the name is not possible.
To mitigate this NND should be able to:

Substitute placeholders in any context.
Add support for several placeholders:
2.1 [race] - race
2.2 [sex] - sex
2.3 [relation] - relationship disposition
2.4 [class] - class or combat style (e.g. warrior, mage)
2.5 [break] - new line

Take into account unique names that were previously bypassing any modifications.
Maybe support for obscurity names too?

Nah, this one is not that crucial, so will postponse until requested.
Keep in mind that some info that might change in runtime will significantly complicate name fetching as it will require continuous updates.


bug: Denied request: HTTP header: host value:  verification failed

Bug Report
Madara version: 0.8.0-7b405924b58
Current behavior:
Requests don't go through.
Expected behavior:
Allows requests to be made.
Steps to reproduce:

Run either cargo run --release -- --dev or cargo run --release -- --dev --rpc-external.
Make a request from localhost or host.docker.internal.
Get the error: Denied request: HTTP header: hostvalue:host.docker.internal:9944 verification failed

@neelkamath can I work on this ? This would be my first time contributing to this ecosystem…

I am applying for this issue via https://app.onlydust.com/p/madara
Hello, I've read the contributors guidelines and I'm excited to help with this task. I understand the bug:

Madara version 0.8.0-7b405924b58 is not allowing requests to go through.
Error message: "Denied request: HTTP header: host value:host.docker.internal:9944 verification failed".

To approach this problem, I would:

Investigate the Madara configuration files for any incorrect settings.
Verify the RPC settings and ensure they are correct.
Analyze the error message for any clues.
Check the Madara documentation for any known issues or solutions.
Test the requests using tools like Postman or cURL to isolate the issue.

My background in software development, debugging, and RPC protocols can be leveraged to efficiently identify and resolve this issue. I'm confident in my ability to debug and fix this problem.
Please assign me this task, and I'll deliver the updated code to resolve the request issue in Madara.

repository archived in favor of https://github.com/madara-alliance/madara


Disable plugins output in --stream mode

Use Case
I'm always frustrated when I see all my >2000 hosts returned by an inventory plugin in the bolt command run ... --stream --no-verbose output. My inventory.yaml calls a task plugin to get list of my hosts from another source in the company. All those hosts are dumped to the stdout when I run bolt in --stream mode.
Describe the Solution You Would Like
I'd like to not see the inventory plugin task output in the bolt --stream mode.
Describe Alternatives You've Considered
I can consider writing a Ruby non-task inventory plugin like prompt or env_var e.g. Such plugins output is not dumped to stdout as far as I can see (I tried to pass some hosts in JSON form via the env_var plugin). Though I found no way how to write such plugins in the documentation. So I'm not sure if it's possible at all.

Please reopen the issue.


XML Parsing Error

Which service(blob, file, queue, table) does this issue concern?
Blob
Which version of the Azurite was used?
latest docker container as of 30-Apr-2021
Where do you get Azurite? (npm, DockerHub, NuGet, Visual Studio Code Extension)
DockerHub
What's the Node.js version?
Not sure, it's in the container
What problem was encountered?
.NET SDK BlobContainerClient.Exists() throws an exception System.Xml.XmlException: 'Reference to undeclared entity 'nbsp'. Line 5, position 18.'
Steps to reproduce the issue?
call BlobContainerClient.Exists() with any container name, non-existing or existing.
Strangely, this worked with the same container and code a couple of days ago. No change related to this as far as I can recall.
If possible, please provide the debug log using the -d parameter, replacing <pathtodebuglog> with an appropriate path for your OS, or review the instructions for docker containers:
StackTrace:

  | Name | Value | Type
-- | -- | -- | --
  | StackTrace | "   at System.Xml.XmlTextReaderImpl.Throw(Exception e)\r\n   at System.Xml.XmlTextReaderImpl.HandleGeneralEntityReference(String name, Boolean isInAttributeValue, Boolean pushFakeEntityIfNullResolver, Int32 entityStartLinePos)\r\n   at System.Xml.XmlTextReaderImpl.HandleEntityReference(Boolean isInAttributeValue, EntityExpandType expandType, Int32& charRefEndPos)\r\n   at System.Xml.XmlTextReaderImpl.ParseText(Int32& startPos, Int32& endPos, Int32& outOrChars)\r\n   at System.Xml.XmlTextReaderImpl.ParseText()\r\n   at System.Xml.XmlTextReaderImpl.ParseElementContent()\r\n   at System.Xml.XmlTextReaderImpl.Read()\r\n   at System.Xml.Linq.XContainer.ReadContentFrom(XmlReader r)\r\n   at System.Xml.Linq.XContainer.ReadContentFrom(XmlReader r, LoadOptions o)\r\n   at System.Xml.Linq.XDocument.Load(XmlReader reader, LoadOptions options)\r\n   at System.Xml.Linq.XDocument.Load(Stream stream, LoadOptions options)\r\n   at Azure.Storage.Blobs.BlobRestClient.Container.GetPropertiesAsync_CreateResponse(ClientDiagnostics clientDiagnostics, Response response)\r\n   at Azure.Storage.Blobs.BlobRestClient.Container.<GetPropertiesAsync>d__3.MoveNext()\r\n   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()\r\n   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)\r\n   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)\r\n   at System.Threading.Tasks.ValueTask`1.get_Result()\r\n   at System.Runtime.CompilerServices.ConfiguredValueTaskAwaitable`1.ConfiguredValueTaskAwaiter.GetResult()\r\n   at Azure.Storage.Blobs.BlobContainerClient.<ExistsInternal>d__70.MoveNext()\r\n   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()\r\n   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)\r\n   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)\r\n   at System.Runtime.CompilerServices.TaskAwaiter`1.GetResult()\r\n   at Azure.Core.Pipeline.TaskExtensions.EnsureCompleted[T](Task`1 task)\r\n   at Azure.Storage.Blobs.BlobContainerClient.Exists(CancellationToken cancellationToken)\r\n   at FileProvider.AzureBlob.FileProviderAzureBlob.ConnectIfNecessary(String path, Boolean createContainerIfNotExist, CancellationToken cancellationToken) in...

Please be sure to remove any PII or sensitive information before sharing!
The debug log will log raw request headers and bodies, so that we can replay these against Azurite using REST and create tests to validate resolution.
Have you found a mitigation/solution?
Nope

One more note: This issue is specific to the .NET Nuget Package Azure.Storage.Blobs v12.8.3.
Azurite works fine using the Storage Emulator 1.19.1
I have not tried it in other languages.

BTW, the reason for opening the issue here is because with the 'real' Azure Storage Account Blobs this issue is not present

Hi,
thanks for raising the issue.
Could you perhaps provide a debug log of the issue occurring?

Apologies for never getting the logs to you.
I retested this with the 3.13.1 image and the issue has been resolved.
Many thanks !


Feature/remove any references to ges disc servers from the meditor codebase

This PR contains removal of references to GES DISC servers and people from codebase to support open sourcing meditor. Changes are as follows,

removed references to GES DISC, GESDISC, etc.
removed references to "lb.gesdisc.eosdis.nasa.gov/meditor"
added "fake" people emails in test files to remove references to GES DISC people.
Added relative URLs in replace of default LB in .env files

Hey, I really like the idea behind this PR—especially when it comes to our fixtures! There are a few places where I still have questions:

Sometimes we remove "GES DISC" but leave a @nasa.gov email next to it. Should we remove both?
Sometimes, like for OpenGraph (used in our <meta property="og:url" >), a relative URL won't work. Maybe we can use an environment variable instead?
I'm not sure where the NB Viewer parses URLs (Node or Browser), but I know that some Node URL parsers don't handle relative URLs. We could either be careful to test these cases, or maybe we could use an environment variable there, too.

Hey, I like the idea of using environment variables. I have kept @nasa.gov because we will still use meditor for any NASA website even after open sourcing it but it is using fake users. Do you want to discuss about using environment variables sometime today?

Hey, I like the idea of using environment variables. I have kept @nasa.gov because we will still use meditor for any NASA website even after open sourcing it but it is using fake users. Do you want to discuss about using environment variables sometime today?

Cool, let's discuss! See you on Gather. 👍🏼
Just to clarify about the email addresses, I'm great with<EMAIL_ADDRESS>but was wondering if we should also change real email addresses like gsfc-nasa-disc.


[docs] add alt text to docs images

This pull request closes #4028

[x] docs/Features.rst
[x] docs/GPU-Performance.rst
[ ] docs/GPU-Windows.rst
[x] docs/Parallel-Learning-Guide.rst
[x] docs/Parameters-Tuning.rst
[ ] docs/gcc-Tips.rst
[x] docs/index.rst

I am not sure why these checks are failing, have I made a mistake somewhere? To the best of my knowledge I did not touch files that weren't mentioned in the issue and edited the ones with proper syntaxing.

Thanks so much for doing this!
Could you please revert the changes to index.rst (since we already have https://github.com/microsoft/LightGBM/pull/4029 addressing that file) and Parameters-Tuning.rst (since someone else asked to work on it in https://github.com/microsoft/LightGBM/issues/4028#issuecomment-787941552)? And please remove the language "closes" from the description.
Sorry for the inconvenience, but in https://github.com/microsoft/LightGBM/issues/4028 we did say

Please limit pull requests to only 1 file

Since you've already done the work here, it's ok to leave Features, GPU-Performance, and Parallel-Learning-Guide.

I am not sure why these checks are failing, have I made a mistake somewhere? To the best of my knowledge I did not touch files that weren't mentioned in the issue and edited the ones with proper syntaxing.

Don't worry! These check failures are not related to your changes. We have some ongoing issues with our automated testing that came up in the last day or so. I'm working on fixing them in #4032 .

Sorry for the trouble. Will definitely do what is required.


[Keras Applications] WideResNet(s)

WideResNet(s) [1] are residual network structures that are aimed at improving classification performance by decreasing the depth and increasing the width of residual networks. Many SOTA paper(s) make use of WRN implementations in some form or the other (eg. [2], [3], [4]). It'd be useful to have WRN implemented in tf.keras.applications itself.
In case, WideResNet-28-10 and similar architectures can be added to tf.keras.applications we can look into the following:

Pre-trained weights for resized ImageNet  [5] (32 x 32) on WRN-28-10
Pre-trained weights for resized ImageNet [5] (64 x 64) on WRN-36-5 (https://patrykchrabaszcz.github.io/Imagenet32/#validation-performance)
Pre-trained weights for CIFAR-10 / SVHN? (although, keras_applications is tightly coupled with ImageNet related implementations)
Bottleneck ResNet-50-2 architecture with larger image sizes (eg. 224x224 / 299x299)

[1] Wide Residual Networks
[2] SGDR: Stochastic Gradient Descent with Warm Restarts
[3] AutoAugment: Learning Augmentation Strategies From Data
[4] RandAugment: Practical automated data augmentation with a reduced search space
[5] A Downsampled Variant of ImageNet as an Alternative to the CIFAR datasets
/cc: @tanzhenyu, @fchollet

Hey @fchollet, any updates?

Hey @fchollet, any thoughts on this?

Gentle ping.
/cc: @fchollet, any thoughts on this?

We currently don't have the bandwidth to support this model. Closing it.


Adding prefetch feature to slice plugin

Prefetching the successive slice block requests can prevent cache miss latency which will improve overall performance.

next 'n' blocks will be prefetched in the background and cached
more features can be added but this is the initial addition

testing with h2load show improvement

[approve ci autest]

[approve ci fedora]

[approve ci fedora]

[approve ci fedora]

Cherry-picked to v9.2.x


Just get rid of sftp in testing

I'm not sure why my test call to
ska-fido: /proj/sot/ska/share/cmd_states/update_cmd_states.py --dbi 'sybase' --server 'sybase' --database aca_tstdb --user aca_test --h5file ~/git/cmd_states/cmd_states.h5 --datestart '2014:180:00:00:00.000'

Stuck me in apparently infinitely repeating
Exception RuntimeError: 'maximum recursion depth exceeded while calling a Python object' in <bound method SFTP.__del__ of <Ska.ftp.SFTP object at 0x1f3fe90>> ignored
Exception RuntimeError: 'maximum recursion depth exceeded while calling a Python object' in <bound method SFTP.__del__ of <Ska.ftp.SFTP object at 0x1f3fe90>> ignored
Exception RuntimeError: 'maximum recursion depth exceeded while calling a Python object' in <bound method SFTP.__del__ of <Ska.ftp.SFTP object at 0x1f3fe90>> ignored
Exception RuntimeError: 'maximum recursion depth exceeded while calling a Python object' in <bound method SFTP.__del__ of <Ska.ftp.SFTP object at 0x1f3fe90>> ignored

I'll try just skipping the construction of a new/testing h5 file.

So, we had that previous issue, and now I'm having the issue that my host was blocked from occweb due to 3 consecutive login failures on lucky ... which was likely when I was trying to run the timelines testing.


Replace num_traits.h, limits.h

As per p1841r1

remove support for numeric_limits and replace with individually-specialisable traits from P1841R1,
move definitions from num_traits.h into numbers.
more set_tag, set_rep etc. to _impl/wrapper/
decide what to do with cnl/numeric.h

drop cnl::numbers; it's tautological: two ns.

https://github.com/cplusplus/papers/issues/107#issuecomment-511696077


Use number when unmarshal json

Allow the support of json number.
Example:
{
"Name":"Marc",
"id":12423434
}

Testing & a bit improvement has been implemented in different branch.
This feature will be included in the next version release.
I will put your name in contributor section as well as in release note.
Thanks!

oupps sorry for the time of response and thanks for update test for me ;)

it would be amazing if you could merge develop with master or at least this fix into master.
gracias!

I am planning to do it within today!  Thanks for pinging :)

It's merged to Master.


Add shift leftclick copy players name as a mod.

Saw someone open an issue (#22) looking for similar functionality of shift-click copy name to chat.

Thanks for your contribution. I decided to include that into the chat-links module via this commit: https://github.com/shagu/ShaguTweaks/commit/5014a47bac39e25c3caee512b940298436049f9b


Remove cardano-configuration submodule added for the example

It was easier than expected, I've tested the restore script an it works.
Closes #59

Do you think we could setup some ci effects to run the restore script in ci? Do you think it could be valuable/worth it? (Thinking for M5)


Bug report: Imidiate Crash after enabling Dataview

What happened?
Installed Obsidian fresh and enabled in my vault with about 2500 notes and quite some Dataviews (on PC windows no problem)
I have a Samsung S21 Ultra with 16 GB RAM.
DQL
dont know, because of immediate breakdown of the app.
JS
dont know, because of immediate breakdown of the app.

Dataview Version
0.5.66
Obsidian Version
1.5.12
Device
Samsung S21 Ultra
OS
Android 14, One UI 6.0

I have the same issue on 2 samsung phones. S10e and s24 with fresh obsidian install, no other community plugins installed. 1900 notes in vault.

Still happening on obsidian 1.6.3
And 0.5.67


Hi, I need a Canvas signature using Angular2, Help me to find that one

https://github.com/wulfsolter/angular2-signaturepad

@wulfsolter cant get curve interpolation working using your library. Can you give me a hand / or a hint?


Incorrect data being published in the LaserScan data.

Hello,
I am using a PicoScan 150  lidar for a autonomous mobile navigation project in ROS2.
ROS2 Version: Humble
OS: Ubuntu 22.04
I am using below command to launch the ros2 files related to PicoScan lidar.
ros2 launch sick_scan_xd sick_picoscan.launch.py hostname:=<IP_ADDRESS> udp_receiver_ip:=<IP_ADDRESS>
Connection is successful and I am able to see the point cloud data in rviz on "/cloud_all_fields_fullframe" topic with the fixed frame as "world" frame as shown in image below.

But when I try to visualize the laser scan data on "/scan_fullframe" or "/scan_segment" topics and by changing the fixed frame to "world_1"  , there are very few points visible in rviz as shown in below image.

Can some please help me to understand why I am facing problem with laser scan data while I am able to see correct data in point cloud ?

Thank you for your feedback. The error is most likely caused by echo filtering. By default (i.e. parameter "host_FREchoFilter"="2" in the launchfile) only the last of 3 possible echos is expected from the lidar. If more echos are received, they will be filtered intensionally and only the last echo will be published in the laserscan topic with frame id "world_1". If there are scan points in other echos, they will not be published in the laserscan frame "world_1". Unlike laserscan messages, point cloud messages contain all echos. Therefore, rviz shows the complete scan in the point cloud topics, but not in the laserscan messages.
Please run the following steps:

Enable all echoes by changing the parameter host_FREchoFilter to 1 (all echoes) in the launchfile:
<arg name="host_FREchoFilter" default="1" /> <!-- Optionally set FREchoFilter with 0 for FIRST_ECHO (default, EchoCount=1), 1 for ALL_ECHOS (EchoCount=3), or 2 for LAST_ECHO (EchoCount=1) -->

With host_FREchoFilter=1, a laserscan message will be published for each echo with frame id "world_1_<echo_idx>". Set fixed frame in rviz to "world_1_0", "world_1_1" or "world_1_2" to visualize each echo:

Alternatively, you can switch to the first echo by changing the `host_FREchoFilter' parameter in the launchfile to 0 (first echo):
<arg name="host_FREchoFilter" default="0" /> <!-- Optionally set FREchoFilter with 0 for FIRST_ECHO (default, EchoCount=1), 1 for ALL_ECHOS (EchoCount=3), or 2 for LAST_ECHO (EchoCount=1) -->

Set the fixed frame in rviz to "world_1" to visualize the first echo:

Check for an updated firmware version with SOPAS ET or SOPAS Air and install the latest version.

Thank you for your quick response. Now  I am able to see correct LaserScan data on world_1 frame after setting host_FREchoFilter to 1.


ability to append operationName in http post url for debugging purpose

Problem
Right now if you analyze your network requests through a tool like 'Charles' then all you see is your base url used for post request. It is cumbersome to open request/response detail to know what is the content of that post. This is needed during development when you have 100s of api calls happening and you want to analyze what that call is about.
Solution
Ability to append operationName in post url (like get urls) either at library level or through interceptors. I like the ability to modify url through interceptors because then developers can append anything they like in the serverUrl e.g. http://baseurl.com/graphql?query=authenticate&newUser=false. If this is possible in existing library then please point me the right direction. Thanks,
Relevant code in httpGetUrl com.apollographql.apollo.internal.interceptor.ApolloServerInterceptor#httpGetUrl
urlBuilder.addQueryParameter("operationName", operation.name().name());

Could you use the X-APOLLO-OPERATION-NAME header? As far as I remember, this is added in ApolloServerInterceptor before it reaches the okhttp client. So you could add a OkHttp interceptor to get it from the headers and append it as query parameter?

Wow, didn't know about this header. I was in the middle of writing okhttp interceptor which reads the whole body and parses operation name. Seems like X-APOLLO-OPERATION-NAME will do just fine.

Sharing my interceptor if someone needs it.
import okhttp3.Interceptor
import okhttp3.Response

class OperationNameInterceptor : Interceptor {

    override fun intercept(chain: Interceptor.Chain): Response {
        var request = chain.request()
        try {
            val operationName = request.header("X-APOLLO-OPERATION-NAME")
            if (operationName != null) {
                request = request.newBuilder().url(request.url.newBuilder().addEncodedQueryParameter("operation", operationName).build()).build()
            }
        } catch (t: Exception) {
            //ignore
        }

        return chain.proceed(request)
    }
}


Changelog

This should make the change log “visible” on Hackage (see http://stackoverflow.com/questions/21076759/how-to-add-a-changelog-to-a-cabal-package/21076816).

Thanks!


lib: changes versioned structs regarding api_version

Use uint16_t for api_version (most structs were using it
already).
In some cases, it leads to a hole, so a "reserved" field was
placed.
In some cases struct was changed a bit to reduce holes.
Signed-off-by: Bruno Dilly<EMAIL_ADDRESS>

v2 pushed


Fix #452 for both CSharp and VB with proper casting.

Added an extra cast to both the C# and VB analyzers.  Also had to get the statements of this dispose for VB a bit differently.  It was always returning Nothing with the previous code because it was getting a declaration node, which does not include the statements, instead of a method block node that does contain the statements.

Hey, that was fast! Cool!


Implement style merging for highlight styles

Previously the highlight style (even if not present) overrode the row styles for a table and list:

With this change, if there is no highlight style defined, the selected item follows the style of the row:

When a highlight style is defined, it is merged with the data style:

This is now implemented on top of StyleDiff. The highlight_style and header_style are accepted through that. The basic style is still a normal Style as this should be the lowest priority style so there's nothing to patch that on top of.
I also wish I could have added DiffStyled variants to Text and Row, but that would have been a compatibility break. Maybe it should be considered for the next semver-major release?
There's also some overall improvements here in how styles get applied between highlight symbols, etc.

Thanks for your contribution. The highlighting behavior has been certainly overlooked until now. Given the ongoing discussion in #239, I had already started some experimentation on the styling issues of List and reached the same conclusion as you that we might want to have a style incrementally applied instead of overridden. I've cleanup this work, taking your ideas into account in #318. I think that as you suggested using a StyleDiff in a backward-compatible way (there is a From<Style> impl) for highlight_style would be a much better idea as it would not require an implicit merge logic as you introduced in this first version. Let me know what you think. If you are ok the plan would then be to merge #318 and let you rework your PR upon it.

That sounds great! I was somewhat reluctant to push completely new type out of the blue, but given #318 exists, I feel the use of StyleDiff makes more sense for the API for this PR.
I'll rework this implementation once that PR land.

I've merged #318 so the road is clear ;).

This needs some backwards compatibility tests. I patched my project on top of this, expecting the behavior to revert to the original (until I fixed my project to use the new _diff methods), but didn't see any change.
I'll add some tests that verify the old behavior doesn't change and see if there's something that changes it with the implementation.

There are two changes that affect backwards compatibility:

The way Row::Data is styled has changed, which is to say it is now styled.
The parts that are affected by Row::StyledData differ slightly to make Table consistent with List.

In the past Row::Data was always unstyled (or styled with Style::default()), now Table::style is applied to that data instead. I'd consier the previous behavior a bug, essentially Table::style().fg was not used for anything and Table::style().bg was used only for empty spaces.
Row::StyledData style applied to also the blank spaces where highlight_symbol would be. This wasn't visible for foreground color, but if the Row::StyledData applieda  background color, this extended also to the highlight symbol column. This differs from List, which always had the highlight symbol color either as List::style() for blank symbols or List::highlight_style() if the row was highlighted.
The diff to backwards compatibility changes is:
https://github.com/fdehau/tui-rs/pull/317/commits/1614bf269c564db443ef2c4488113046ed74e635#diff-538c05d01c0ce71eadc533e09c6f7194R540-R592
Furthermore for backwards compatibility reasons the default for style/highlight_style/etc. is now StyleDiff::from(Style::default()), which is to say those styles will always fully override the previous styles.
List example (with higlight_style removed)

The behavior here is maintained between versions. Adding hilight_style_diff(StyleDiff::default()) removes the backwards compatibility default style, resulting in:

Table example (with style(Style::default().bg(Color::DarkGray)))
Before the changes:

After the changes:

(Note the rows are all StyledRow so they still maintain the black background coming from Style::default())
Adding header_style_diff(StyleDiff::default()) removes the otherwise-overriding default style from headers and changing highlight_style to highlight_style_diff gives the following result:

I think your changes are very sensible but I would not worry too much about backward compatibility in this case as you pointed that the previous behavior was not consistent. If using StyleDiff::default() instead of StyleDiff::from(Style::default()) provides better a out of the box result then let's change it. It will be especially nicer to newcomers and makes the API more understandable.

I'll deal with this next week. Currently spending midsummer at a summer house so not in a great position to make the changes at the moment.
I do agree that not bothering with the full backwards compatibility would result in less surprising user experience.

Got back from the vacation to find my development server with one less working hard drive so that delayed this a bit.
Made the change to default to StyleDiff::default() (ie. empty StyleDiff) instead of the previous Style::default() (ie. style that resets everything).
This applies to list highlight style as well as table header and highlight style. So now the default behavior for a highlighted list/table row is to inherit the style from the row itself instead of using an empty Style that would reset the highlighted row/header.

Based on the review comment that indicated the non-StyleDiff method should be deprecated (Which I agree with); I've added #[deprecated] attributes on the old methods and cleaned up the examples to use the new _diff methods instead. The version for #[deprecated(since = "...")] is 0.10.0; That should be changed once the version in which this is going out is known.
Also saw that widgets::Tabs had a highlight_style as well so I changed that to use the StyleDiff for consistency as well.

This should have been addressed as part of #417


Update redis_best_practices.md

INCR command is required. It's possible that DECR is required, as well - I added it to my ACL together with INCR, but haven't tested without it. Feel free to update the Chinese docs, as well.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Borderless (Duality) missing from this list??

I noticed that Borderless (Duality) and Unbending Steel (Duality) from the Duality album are missing here, while Unbreakable (Duality) is in the list.
Was just wondering if there is anything preventing them from being added, or if they just haven't gotten around to it.

I don't know if these are the correct versions of those tracks, but I found these in the sheet:

319 - Borderless
325 - Unbending Steel

Neither is tagged with Duality, but that might just be an inconsistency on the part of the sheet maintainers.  If those are the correct versions, you should go to the source sheet and add a comment on those tracks so they can get updated.  If they're the wrong versions, it may be that the other versions are not present in game directly.

I don't know if these are the correct versions of those tracks, but I found these in the sheet:

319 - Borderless
325 - Unbending Steel

Neither is tagged with Duality, but that might just be an inconsistency on the part of the sheet maintainers.  If those are the correct versions, you should go to the source sheet and add a comment on those tracks so they can get updated.  If they're the wrong versions, it may be that the other versions are not present in game directly.


Better handling of Claimed Account restricted guilds

When connecting to a guild in IRC that has a claimed account restriction with an unclaimed account, this error is thrown
(node:22110) UnhandledPromiseRejectionWarning: Unhandled promise rejection (rejection id: 2): TypeError: Cannot set property 'discordDisplayName' of undefined
data: QUIT :Leaving

An interesting alternative is to have your name as your username+descriminator, and have all channels as voiced only/read only

I have no idea what a "claimed account restriction" is, can you explain a bit more?

Hrm... but joining those servers is done from discord itself. DiscordIRCd doesn't have support for joining servers you are not yet in. So I am not exactly sure how this can cause issues?
It is honestly also not something I am planning to integrate in the short term since most people will be joining through an invite link anyway.

Works fine though?
I can read messages, and even join voice chat

Oh... right it is read only...
Gotcha, I guess I should account for that.

This is no longer relevant as Discord seemingly no longer exposes this kind of functionality to discord.js