Compute delta_ip and delta_stp in side table

#46

There are a few issues:

side_table_last_entry is wrong, you need to supported nested blocks. You might need to put an index to the side table in Label or LabelKind.
I don't think instruction index is the correct abstraction, I think we want instruction address. So you don't need instr_idx at all and can use parser.save().as_ptr() as i32.

Then in terms of design, I think we should keep Context constant in Expr and make Expr::check_body return the side-table. We can then set it from Context::check_module where check_body is called.

Thanks! The issues with parser.save().as_ptr() as i32 are

parser.save().as_ptr() overflows.

The DELTA_IP_MASK is too small to hold it.

Thanks! The issues with parser.save().as_ptr() as i32 are

parser.save().as_ptr() overflows.
The DELTA_IP_MASK is too small to hold it.

Those are not issues because we only care about deltas between parser.save(). In the proposed design, I store directly the &'m [u8] delays converting to i32 until after we compute the delta.

I'm not sure it's worth iterating too much. It's simpler to just design correctly from the start, which means understanding the goal. Essentially, we want all occurrences of skip_to_{else,end}() in exec.rs to be resolved from the side-table (to which we can add Loop to handle everything uniformly). This means If, Else, Br{,If} should each have an entry in the side-table and BrTable as much as its arguments. This defines when an entry is added. Then we need to fill their content, which is done on Loop, Else, and End (with Loop done before the entry is added). This means that for Loop we can store the parser position in the LabelKind (like done in exec.rs). For Else and End, we need the side-table entries to register themselves in their labels. This means that Label should contain an entries: Vec<(&'m [u8], usize)> recording for each side-table entry the parser position and the side-table length when it was added. Then in end_label() we can simply go over all entries compute the difference between the current parser position and the saved one to compute the delta IP, as well as the difference between the current side-table length and the index for the delta STP. We can then update the side-table entry.

Thanks! I implemented this design except Loop for the moment. I'll run some tests in the meanwhile.

I've merge main into dev/fast-interp. You might want to pull and merge your add-delta-ip branch into dev/fast-interp. This adds better support for unsupported operations, such that we can still run parts of a test instead of having to ignore it completely.

Could you clarify the hw-host error? I guess it results from the mask size issue.

I posted https://github.com/zhouwfang/wasefire/pull/2 to add val_cnt and pop_cnt on top of this PR. Could you also take a look at that? Thanks.

Could you clarify the hw-host error? I guess it results from the side table bit mask size issue.

Yes, this is indeed the side table masks being too short. So we'll probably have to use a u64 for the bit fields. You can also apply the following patch:
--- a/crates/interpreter/src/bit_field.rs
+++ b/crates/interpreter/src/bit_field.rs
@@ -29,6 +29,8 @@ fn offset(mask: u32) -> i32 {
 pub fn into_field(mask: u32, value: u32) -> Result<u32, Error> {
     let field = (value << mask.trailing_zeros()) & mask;
     if from_field(mask, field) != value {
+        #[cfg(feature = "debug")]
+        eprintln!("Bit field value {value:08x} doesn't fit in mask {mask:08x}.");
         return Err(unsupported(if_debug!(Unsupported::SideTable)));
     }
     Ok(field)

This is similar to what we do in the memory_too_small function.


Add new Client constructor with server-address-getting function as input.

Previously, if a connection to a metricd server was unsuccessful, the client would try reconnecting to the same server forever.
However, in large production systems it is quite common to have a cluster manager tool, which might migrate metricd server at any time, without client knowing.
This proposed change adds a new Client constructor, which takes a function, which will provide metricd client with current server URL address if the current connection was unsuccessful.
This way, buffered metrics will not be discarded (provided buffer wasn't full at any given point), but rather will be resend to a n ew server once it's up.

Thanks. LGTM.


Removed dependency on pydantic. Use dataclasses instead.

Removed dependency on pydantic. Use dataclasses instead.

Codecov Report

Merging #94 (6e1926e) into main (2cce142) will increase coverage by 0.79%.
The diff coverage is 100.00%.

:exclamation: Current head 6e1926e differs from pull request most recent head b2b9dfe. Consider uploading reports for the commit b2b9dfe to get more accurate results

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

@@            Coverage Diff             @@
##             main      #94      +/-   ##
==========================================
+ Coverage   72.51%   73.31%   +0.79%
==========================================
  Files           8        8
  Lines         302      311       +9
==========================================
+ Hits          219      228       +9
  Misses         83       83

Files
Coverage Δ

src/managed_service_fixtures/base_manager.py
54.65% <100.00%> (+0.53%)
:arrow_up:

src/managed_service_fixtures/services/asgi_app.py
100.00% <100.00%> (ø)

src/managed_service_fixtures/services/cockroach.py
97.61% <100.00%> (+0.11%)
:arrow_up:

src/managed_service_fixtures/services/redis.py
100.00% <100.00%> (ø)

src/managed_service_fixtures/services/vault.py
100.00% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2cce142...b2b9dfe. Read the comment docs.


Fix bug in SkySSHRunner with local/remote port ordering.

Submitting this separately from refactoring PR so I can remember that this was causing problems and land it sooner.

#630  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @rohinb2 and the rest of your teammates on  Graphite


🚚 Move project to src layout

This PR moves MQT Bench to a src layout similar to the MQT Predictor project.
Not only is this a common best practice for avoiding all kinds of packaging and testing problems (since mqt.bench is no longer also a top-level directory mqt/bench, but now src/mqt/bench), it also creates a much cleaner code structure, where source code is in src and tests are in tests.
Over the course of this transition, I also fixed some of the hard coded paths and replaced them with the corresponding importlib.resource code.
The actual changes are rather small and can be considered cleanup of existing code. Some modules have been moved around slighlty. Some modules got a more convenient include. A pytest and coverage configuration has been added.
Last but not least, this PR removes the deprecated get_one_benchmark function.

The coverage changes here at first seemed weird. Then I noticed that the original coverage report is faulty itself. It shows many lines of important files as uncovered even though the respective lines are definitely covered by tests.
I'll investigate further.
The actual coverage decrease here comes from the fact that many lines of code have been removed that were previously covered but were no longer needed.

Ah, might have missed changing the path. Thanks for catching that. I'll check later.
Tests run smoothly in the CI, so I'd guess that this is a macOS problem. At some point we should probably also run (some of) the tests on macOS and Windows in the CI.

Ok, just checked again. Everything is running smoothly on my end. Have you tried it with a new virtual environment?

Ok, just checked again. Everything is running smoothly on my end. Have you tried it with a new virtual environment?

I thought I had. Tested it again with new virtual environments for both python 3.9 and 3.10, it works now. I don't know why it has not worked before.


Cereal serialization - Enable SGMatrix serialization in SGObject

It looks kinda ugly with all these data types listed explicitly...

@vigsterkr wanna check this one?

@OXPHOS mmmm it's just waaaaaaaaaaaaay toooo verbose... template to the rescue?

@vigsterkr The type information is completely removed and I didn't find a way to completely avoid listing... One way is using enum Type {  INT8, SGVECTOR_INT8, SGMATRIX_INT8 .. }, the other one is to use Macros, but neither will improve much.

@vigsterkr have any good idea? I don't think template could do much

@OXPHOS hi there! Let's get this merged ! :)
So I guess we can avoid all this duplicate code with defining some macros no?
However, I dont think we can get around explicitly listing all these cases (unfortunately) we had this problem before ...
It is not very nice, but I am fine to merge this stuff anyways -- can discuss in IRC.

Okay I am back to this.

Let's get this in! :)

Rebase and merge? :)

@vigsterkr your serialisation stuff does this right?

yep this is all fixed


docker.io SSL cert is expired

Well, I tried to report this "properly" but it is on Hacker News now anyway so I don't think there is any harm in putting the details here.

$ curl --verbose https://index.docker.io/v1/search?q=busybox
* Adding handle: conn: 0x7fefda804000
* Adding handle: send: 0
* Adding handle: recv: 0
* Curl_addHandleToPipeline: length: 1
* - Conn 0 (0x7fefda804000) send_pipe: 1, recv_pipe: 0
* About to connect() to index.docker.io port 443 (#0)
*   Trying <IP_ADDRESS>...
* Connected to index.docker.io (<IP_ADDRESS>) port 443 (#0)
* SSL certificate problem: Invalid certificate chain
* Closing connection 0
curl: (60) SSL certificate problem: Invalid certificate chain
More details here: http://curl.haxx.se/docs/sslcerts.html

curl performs SSL certificate verification by default, using a "bundle"
 of Certificate Authority (CA) public keys (CA certs). If the default
 bundle file isn't adequate, you can specify an alternate file
 using the --cacert option.
If this HTTPS server uses a certificate signed by a CA represented in
 the bundle, the certificate verification probably failed due to a
 problem with the certificate (it might be expired, or the name might
 not match the domain name in the URL).


"alert_words_ui.js: add removed alert to confirmation banner"

Added removed alert to confirmation banner
Fixes:

Screenshots and screen captures:
Self-review checklist

[ ] Self-reviewed the changes for clarity and maintainability
(variable names, code reuse, readability, etc.).

Communicate decisions, questions, and potential concerns.

[ ] Explains differences from previous plans (e.g., issue description).
[ ] Highlights technical choices and bugs encountered.
[ ] Calls out remaining decisions and concerns.
[ ] Automated tests verify logic where appropriate.

Individual commits are ready for review (see commit discipline).

[ ] Each commit is a coherent idea.
[ ] Commit message(s) explain reasoning and motivation for changes.

Completed manual review and testing of the following:

[ ] Visual appearance of the changes.
[ ] Responsiveness and internationalization.
[ ] Strings and tooltips.
[ ] End-to-end functionality of buttons, interactions and flows.
[ ] Corner cases, error conditions, and easily imagined bugs.

Closing as this does not seem to reference an issue or otherwise follow our contributing guidelines. Thanks @srgcano!


Release on Nexus

When the mod is more mature, release it on Nexus.

Then, when the mod is even more mature, release it on Steam.


Product Page: refactor grid layout and update styles

PR Checklist
Please check if your PR fulfills the following requirements:

[x] The commit message follows our guidelines: https://github.com/graycoreio/daffodil/blob/master/CONTRIBUTING.md#commit
[x] Tests for the changes have been added (for bug fixes / features)
[x] Docs have been added / updated (for bug fixes / features)

PR Type
What kind of change does this PR introduce?

Grid layout on product page is too complicated with grids nested within grids. Some containers do not require the use of css grid.
Issue Number: N/A
What is the new behavior?
Simplify grid layout and remove display: grid; on containers that can be styled simpler.
Does this PR introduce a breaking change?
[ ] Yes
[x] No

Other information

I really like that you added the product__details class. Makes it a lot cleaner. I think it would be nice if product-details was its own component though, because there's a lot going on in product right now. I'll leave it up to you though, whether you want to do it in this PR or I could do it in another.

I really like that you added the product__details class. Makes it a lot cleaner. I think it would be nice if product-details was its own component though, because there's a lot going on in product right now. I'll leave it up to you though, whether you want to do it in this PR or I could do it in another.

Let's leave this for another PR?


Return AuthenticationFailedError by pointer

To be consistent with other errors returned from our SDKs.

[ ] The purpose of this PR is explained in this or a referenced issue.
[ ] The PR does not update generated files.

These files are managed by the codegen framework at Azure/autorest.go.

[ ] Tests are included and/or updated for code changes.
[ ] Updates to CHANGELOG.md are included.
[ ] MIT license headers are included in each file.

/azp run

/azp run go - azidentity

/azp run go - azidentity


Evaluate Grafana Alloy

https://github.com/grafana/alloy
It's an OTel collector that would replace vector and victoriametrics agent.

Deployed for logs. VictoriaMetrics continues to collect metrics. Tried to deploy it for node exporter as well, but its push model is hard to use with the requirement to run it in the root network namespace to see all network devices (and not just its pod's devices).


[PE-D][Tester B] Could not save data to file

I am using Windows 11, and I create a new empty folder to store the jar file. When I first launch the application, and execute the command below add n/task D/2023-01-29 1000.
Suggestion: Perhaps one of your members can carry out smoke test of the product in a completely new empty folder on Windows 11 OS platform in future release.

Labels: severity.High type.FunctionalityBug
original: jiasheng59/ped#1

Hi @jiasheng59, thank you for testing our product and your comments are appreciated.
We were wondering if you could share the folder properties of the folder that you executed this commands in. It seems like a common issue that the application is unable to save data which prohibits a few of our commands from working as intended (and its error message).
We hope that to replicate this bug on our systems and would like to eliminate the possibility that the jar was executed in a write-protected folder. Thanks!

Hi @lywich , I check the properties of the folder and it's indeed read-only, but I'm not sure if it's the real cause as the folder containing my own group project for testing is also read-only but the error doesn't show up.
Could not save data to file: java.nio.file.AccessDeniedException: C:\WINDOWS\system32\data
Btw, this is the full error message.
I have also check for the folder properties of system32, it's also read-only. There's no data folder present in the folder system32.
Should you need any further clarification, please @ me in following replies. Thanks

Hi @jiasheng59. Thank you for the reply. Perhaps did you keep the "taskbook.log.0" from your session that you could share with us?

@lywich There's only a jar file within the folder, the log is not found. Moreover, I found that me as a user in fact has the read & write access to the folder storing the jar file, despite the folder's read-only attribute is true.

Hi @jiasheng59 . Thank you for your reply again. We will see what we can do with this issue.

Exception message caused by jar file being executed in a write protected environment (System32).


Remove spent transactions from the minting table model.

This addresses #17

Tested and confirmed working. I like it, good to see the minting table cleaned up a bit on a always on Qt wallet.


Some features do not respect timeoutlen

Currently, the plugin works as intended for half pressed keybindings and registers. But say when I press ` or ' for a mark, or @ for a macro, the popup window opens up immediately (instead of waiting for timeoutlen which is 1s for me). Also opens instantly for operator + number. This is really annoying when I just want to delete 3 words with d3w, the popup window opens and instantly closes, and its kinda jarring/triggering.
Would be really happy if everything respected timeoutlen, or atleast there was an option for it. I am considering disabling operators and marks but the features by themselves are amazing, so I don't want to fully remove them.
https://user-images.githubusercontent.com/54357427/129888597-09a13d84-dfa3-4d73-b580-40254808f49e.mov

@HerringtonDarkholme I fixed the issue for myself by taking a look at your pull request. You did it for registers, I also added the same feature for marks. Thank you. Although it would be great if this would be merged into upstream.

This is still an issue for me

Also if I press the " button for registers it appears immediately. I only want to paste from a register "yp and not see what's inside.

This might be intentional. See #144.

I went into config and disabled registers completely: https://github.com/folke/which-key.nvim#-configuration


Add text about acknowledging CUAHSI to publication agreement pop up

CUAHSI has acknowledgement policies so that the community remembers to cite CUAHSI in their publications. We need to add some text to the publication pop up that says:
new header after "Upon submitting..." and before "Please confirm...":
"Acknowledgements"
You are responsible for assuring acknowledgment of material based on or developed with NSF support in any publication, including web pages. To acknowledge CUAHSI in your work, use the following text:
“This material is based on [data, workshop, and/or grant] [provided/facilitated] by CUAHSI with support from the National Science Foundation (NSF) Cooperative Agreement No. EAR- 1338606."
Taken from: https://www.cuahsi.org/about/policies/
@Maurier @horsburgh @dtarb  Any objections to this? I am seeing if Hongzhen can take this on. I am having Jerad review the text for edits.

One thing we need to keep track of, the NSF grant number will change soon.

I am fine adding this wording.

For developers:

create a resource, add keywords, abstract, and content to the content section
make public
DO NOT PUBLISH Click publish (world icon) and see the pop up new
Add new header after "Upon submitting..." and before "Please confirm...":
"Acknowledgements"

You are responsible for assuring acknowledgment of material based on or developed with NSF support in any publication, including web pages. To acknowledge CUAHSI in your work, use the following text:
“This material is based on [data, workshop, and/or grant] [provided/facilitated] by CUAHSI with support from the National Science Foundation (NSF) Cooperative Agreement No. EAR- 1338606."
4. place


csv_reader declaration to include columns with spaces

While in agreement that spaces should never be used in a column name, at times, when dealing with externally sourced csvs, spaces are indeed present.
When attempting to create a virtual table that includes spaces, a 'vtable constructor failed: iavm_reader' error is returned.
e.g.
CREATE VIRTUAL TABLE temp.iavm_reader using csv_reader(plugin, [plugin name])
Is there a way to work around this?
PS
When creating a virtual table directly there are no issues with the header.
e.g.
CREATE VIRTUAL TABLE temp.iavm_csv using csv(filename=iavm.csv)

not yet, this is a limitation with the custom parser sqlite-xsv has that tries to parse column names + definitions on that case. It splits by word and doesn't take into account spaces/[] brackets/"" quotes, which the SQLite core library does.
But it should! Like you mentioned there are workaround if you use filename=, but that's not always possible. Will look into seeing how much effort it'll be to update that naive parser.

Alex,
To the best of my understanding, columns with (unfortunate) spaces can be handled in SQLite in 3 ways:
.1  'Item Type'
.2  "Item Type"
.3 [Item Type] (this is my preferred way)
When creating a VT like:
CREATE VIRTUAL TABLE IF NOT EXISTS temp.xsv_5m_Sales_Records_Test USING csv(filename='D:\Temp\5m-Sales-Records.csv.zst', header=false,Region TEXT, Country TEXT, [Item Type] TEXT

it fails.  When replacing "[]" with single quotes, the creation goes through but the results are:
Region Country Item
------ ------- ----
Europe Poland  Beverages
Europe Poland  Clothes

Using alternate delimiters like '`' (backtick) allows the table creation to complete but the column will assume the generic name of 'Column1'
Region Country Column1
------ ------- -------
Europe Poland  Beverages
Europe Poland  Clothes
Europe Poland  Cosmetics
Europe Poland  Snacks

Alex, if I understand correctly the code despite my turkey induced drowsiness, the column space issue should be resolved in the sqlite-loadable-rs (vtab_argparse.rs).  This is an attempt.  Let me know your thoughts.
pub fn arg_is_column_declaration(arg: &str) -> Result<Option<ColumnDeclaration>, String> {
    if arg.trim().is_empty() {
        return Ok(None);
    }

    // TODO this is a bit of a hack, but it works for now
    // NOTE Test if 'arg' contains characters that imply the column name has a space.
    let regex_check = Regex::new(r#"[\['"]"#).unwrap();
    // NOTE Assign an appropriate regex string based on the above check.
    let regex_string = if regex_check.is_match(arg) {
        r#"^[\['"](?<name>.*?)[\]'"]\s+(?<declared_type>.*?)\s+(?<constraints>.*)$"#
    } else {
        r#"^(?<name>.*?)\s+(?<declared_type>.*?)\s+(?<constraints>.*)$"#
    };
    // NOTE Compile the regex string into a regex object.
    let regex_result = Regex::new(regex_string);
    // NOTE Check if the regex compiled successfully and assign the results to variables.
    match regex_result {
        Ok(re) => match re.captures(arg) {
            Some(caps) => {
                /*
               // TEST
                println!(
                    "Found match: Name: {0} - Declared Type: {1} - Constraints: {2}",
                    &caps["name"].trim(),
                    &caps["declared_type"].trim(),
                    &caps["constraints"].trim()
                );
                */
                // TODO Verify scope.
                name = &caps["name"].trim();
                declared_type = &caps["declared_type"].trim();
                constraints = &caps["constraints"].trim();
            }
            None => {
                println!("No match found!");
            }
        },
        Err(err) => {
            println!("Could not compile regex: {}", err);
        }
    }

    Ok(Some(ColumnDeclaration::new(
        name,
        declared_type,
        constraints,
    )))
}

Happy TG!


HomeKit component

A while ago I ran into someone who originally posted the idea about HomeKit integration in the forums, he did not know about homeassistant development and hates git repos.
Nevertheless he is a very bright guy and was willing to dig into it all to get proper and usable HomeKit support as he knows about HomeKit In great detail.
The guy responsible for the HomeKit component sort of stole the idea and this pissed him of so much that he quit totally.
HomeKit, he told me is extremely flexible and very misunderstood, again like homebridge it is limited to the Apple defined default components and this limits the possibilities.
An example is the media-player support. It is easy to create a new HomeKit definition with an added string property named “Source”. The home app will not support this component but other software like legato eve will.
After that, is it possible to use Siri to switch on a receiver and set it to a certain input, switch on the television and set it up properly to with a scene. He modified the HomeKit component in such a way that HomeKit.yaml contains the configuration of custom HomeKit components and modified the HomeKit component to incorporate all this.
I asked him if he was willing to make this public as HomeKit support sucks as many things in ha are now limited and unsupported. He told me that he will not because his project was taken away by somebody.
 (His words). Only then he will consider posting his code and leave it to the bastard to maintain. He does not want his name attached to it all.
The above is a representation of a voice conversation and I tried to keep as close to the words he used. Not meaning that I agree with the words of his choice. I posted it as an issue as it is in my eyes and a serous one too. Taking somebody’s idea, piss him off in stead of helping him and take the credits Is not the way open source projects like ha should work.
As I have his components I know what is possible, I promised him not to share so I will not.
There is only one guy, who can change this and I think there is only one thing he can do. Word to him: grow up and take the shame!

Home Assistant release with the issue:

Last working Home Assistant release (if known):
Operating environment (Hass.io/Docker/Windows/etc.):

Component/platform:

Description of problem:
Problem-relevant configuration.yaml entries and (fill out even if it seems unimportant):

Traceback (if applicable):

Additional information:

No one stole any "idea of an integration". We integrate stuff, that's literally what we do and no one can claim any rights to that. If people don't open pull requests, don't bother following our best practices, other people will come that do.
We don't care about his code, or any code. We care about people having a good time working together. Your post includes demands, name calling and baseless claims. That does not belong in our community.


ci: changes to gihub flow like structure

:tada: This PR is included in version 1.1.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Use blocksurvey for feedback tool

What's happening with the current submissions? I think the way the component works suggests one could provide a sentiment before opening a form. Seems like this might require some thoughts.
If the current setup works, maybe we could keep it? I'd assume low participation and hence low priority for this. Wdyt?

They are being fed to my account I set up with the tool we are using. I only have two bits of feedback -- from you and @hstove  ;). It's a good tool but I like that we are using blocksurvey in our explorer feedback, and think we should do the same here.
While I agree that it would be best to be able to capture when someone hits any of the buttons, but unfortunately I don't currently know a good solution. I'd love for blocksurvey to be able to have an API endpoint we can hit, but I don't think they offer that.

I agree. I just checked out their FAQs to see if there'd be a way to pass a parameter to the survey (eg to indicate what button was pressed on the docs) but I couldn't find anything relevant. Still, agree that we should use the same tools across properties

I just checked this. This is Wilson from Blocksurvey. Few weeks ago, we have release a query parameters / hidden variables on URL. By this sentiment can be captured by constructing variables like ?sentiment=positive. This will added to the result as well without user entering it. Would this be helpful?

hey @wilsonbright. oh, that would totally do the trick! is that already live? How will the data show in the results?

hi @agraebe, the data will be the grid as a variable with values. Enclosing a sample screenshot. The 'source' and 'group' are passed in URL. Sample URL for trial. https://blocksurvey.io/survey/1DnQ8ArNjQU8Xrf97BbaNNLbFeJTksxHYC/a4e4ee71-ea74-4f5e-a188-b8ef40ab4406?source=twitter&group=binance
Not sure if this will be helpful when it comes to user experience. But, we can look into building small widgets to capture data for docs site specifically. I have made note of this.

@wilsonbright that's great!
@aulneau looks like this will be a good solution. let's see how/when to prioritize this

@wilsonbright This looks cool. I think an ideal feature would be: allow for sentiment to be captured, eg good/neutral/bad without the user submitting anything, eg, they would click on an item, and then we can do a POST request for the item they hit. Would that be possible?

@aulneau Can you share your mail id to<EMAIL_ADDRESS>Will share details on how this can be done through POST request.

Hi @aulneau and @agraebe, we have recently added docs on using BlockSurvey as a headless form builder. Here is a sample for reference: https://help.blocksurvey.io/article/99-how-to-use-blocksurvey-as-headless-forms


iox-#1287 Setup RPATH correctly

Pre-Review Checklist for the PR Author

[x] Code follows the coding style of CONTRIBUTING.md
[x] Tests follow the best practice for testing
[x] Changelog updated in the unreleased section including API breaking changes
[x] Branch follows the naming format (iox-123-this-is-a-branch)
[x] Commits messages are according to this guideline

[x] Commit messages have the issue ID (iox-#123 commit text)
[x] Commit messages are signed (git commit -s)
[x] Commit author matches Eclipse Contributor Agreement (and ECA is signed)

[x] Update the PR title

Follow the same conventions as for commit messages
Link to the relevant issue

[x] Relevant issues are linked
[x] Add sensible notes for the reviewer
[x] All checks have passed (except task-list-completed)
[x] All touched (C/C++) source code files are added to ./clang-tidy-diff-scans.txt
[x] Assign PR to reviewer

Notes for Reviewer
The RPATH issue on MacOS still persists, see: https://github.com/eclipse-cyclonedds/cyclonedds/issues/1270
The solution is actually simple, just uncomment the rpath setter function.
@mossmaurice I think we did not merge it previously since you intervened and stated that it is bad when we have somehow "posh" stated in the hoofs library. I agree with this but I think it is even worse when it is not working at all (on mac os). The issue is already documented and I suggest to merge this, make it work and later we solve the issue and go for a clean solution.
Checklist for the PR Reviewer

[ ] Commits are properly organized and messages are according to the guideline
[ ] Code according to our coding style and naming conventions
[ ] Unit tests have been written for new behavior
[ ] Public API changes are documented via doxygen
[ ] Copyright owner are updated in the changed files
[ ] All touched (C/C++) source code files have been added to ./clang-tidy-diff-scans.txt
[ ] PR title describes the changes

Post-review Checklist for the PR Author

[ ] All open points are addressed and tracked via issues

References

Part of #1287

@mossmaurice @dkroenke
Since the question was raised in the cyclone-dds issue: I can remember a discussion from above https://github.com/eclipse-cyclonedds/cyclonedds/issues/1270#issuecomment-1137502372 where it doesn't seems to help and we had a reason to deactivate it since it was not properly tested.
Yes we tested it properly on all platforms (except Windows which does not support this feature). For that we build iceoryx and moved the build folder and run all the binaries again. With current iceoryx master this is not possible and leads to a library load failure but with this PR the problem is solved.
The same thing goes for the install directory. Here we added an RPATH so that one can always have a directory structure like:
/usr/local/iceoryx-1.0/lib, /usr/local/iceoryx-1.0/bin ... Something which llvm for instance does and which allows to install multiple versions of iceoryx on the same machine.
To test this one can move the install folder and the binaries should still be able to run.


creating a seperate copy of redis.conf to allow sentinel to make changes

When sentinel detects a failover it reconfigures redis.conf to change the 'slaveof' setting.  Puppet was then changing it back to the initial setting.  This uses the same configuration as sentinel.pp had in place.

This travis build is failing in puppet 4 but with a file I did not modify.  It is failing on preinstall.pp.

That's a creative solution to the problem but I don't see any other way myself.
Thanks for the contribution! :+1:

Merged.


Gameplay options

Ordered by priority:

Levelcap - currently just a command line parameter!

it basically just sets MaxLevel (0x10300118), which itself is only referenced in CanLevelUp (0x10080220)

Max # of PCs

1002BBED cmp eax, 6 (max no. of PCs)
1002BC4D cmp eax, 2 (max no. of NPCs)
100B0185 cmp eax, 2 (max no. of NPCs)

Amount of Point Buy Points:

1018B529  mov eax, 8 (initial level - default 8)
10C453F4 no. of point buy points (set at 1018B52E)
sub_1018B570 manipulates the raise/lower stat controls

Display Exact HP for NPCs:

1012441B  disable jump

Max HP
For NPCs, from Levels
For NPCs, from HD
Max HP on Levelup <- these should be part of difficulty setting configs

Delayed blast delay - I think we'll leave this one out. I doubt anyone uses it and it needs a proper UI anyway within the radial menu.

RNG - I think we should just leave it as Mersenne. Maybe I'll make a toggle to log rolls so the users can see if it's really cheating them ;)

This are most if not all in the ini, but we still need to integrate it in the MM options when the time comes :)


[Lighthouse] - Update cookie banner to not use anchor links for accept/decline

Cookie banner is using anchor links for accept/decline buttons and is affecting the lighthouse score.
Screenshot 📸

👋


modinfo uvcvideo | grep "version:"

I am installing Intel® RealSense™ SDK 2.0.
ubuntu 16.04
4.15.0-66-generic
realsense-viewer is working correctly.
However, when I do $ modinfo uvcvideo | grep "version:", the output cannot see any realsense string as you can see the following.
version:        1.1.1
srcversion:     79A49299483C7A964CCC049

Could you please help me?

I meet the same problem with
ubuntu 16.04, 4.10.0-28-generic by following
https://github.com/IntelRealSense/librealsense/blob/development/doc/distribution_linux.md
After the step $  sudo apt-get install librealsense2-utils and connect the realsense sr300, i can open the realsense-viewer but can not get any picture.
Anyone have meet the same problem?

@netgittemp hello, the dkms package for kernel 4.15 is not applicable to versions 4.15.0-58+.(#4669, #4869). The fix is under test. In the meantime the manual installation guide is available, where you patch the kernel with script:
./scripts/patch-realsense-ubuntu-lts.sh

Note that the script patching does not amend the drivers names. There are ways to verify the patches being applied correctly but in most case following the script log and checking whether the operation finishes successfully is sufficient.

Hi @dorodnic, this issue happen also on UP Xtreme with Ubuntu 18.04.3 LTS and kernel 5.0.0-1-generic.
I tried to patch using patch-realsense-ubuntu-lts.sh but nothing changed.
Log of installation of librealsense-dkms:
Setting up librealsense2-udev-rules:amd64 (2.30.0-0~realsense0.1694) ...
Setting up librealsense2-dkms (1.3.6-0ubuntu0) ...
Loading new librealsense2-dkms-1.3.6 DKMS files...
Building for 5.0.0-1-generic
Building initial module for 5.0.0-1-generic
ERROR (dkms apport): kernel package linux-headers-5.0.0-1-generic is not supported
Error! Bad return status for module build on kernel: 5.0.0-1-generic (x86_64)
Consult /var/lib/dkms/librealsense2-dkms/1.3.6/build/make.log for more information.

Loading the modified modules into kernel... complete
Current status:
librealsense2-dkms, 1.3.6: added
mod: videodev
mod: uvcvideo 			 version: 1.1.1
mod: hid_sensor_gyro_3d
mod: hid_sensor_accel_3d

I know that I can compile librealsense from source as explained here but are you planning to release an update in the near future?
Thank you in advance!

@gb1, the librealsense2-dkms package and patch-realsense-ubuntu-lts.sh script are two alternative methods to apply kernel patches. As they affect the same kernel drivers you cannot apply both but have to pick one method - currently kernel 5.0 is supported with the later so you need to remove DKMS for that kernel and run the manual script.
Also to clarify - the Debian distributions of the SDK and the kernel patches are not coupled, so it is perfectly fine to to patch kernel with the manual script while using the Debian packages for the library.
Extending DKMS support for LTS kernels 5.0 and 5.3 is scheduled. Follow the Release Notes for updates.

@ev-mp I have previously installed kernel patches in two ways. But if I use ‘dkms status ’in the follow-up process, I will delete the extra ones. This should not be the reason why I can't identify the camera.
I saw someone saying that the problem was solved by upgrading the firmware. But I don't know how to check the firmware version of the SR300 and where to upgrade the firmware. Can you give me some help?

@likestudy , I presume you refer to #5230, correct ? I'll follow SR300 identification in that thread.
As for the original question - since you're using kernel 4.15.0-66 then please make sure that the dkms package was not installed for the current kernel ( dkms status).

@likestudy With the reply of ev-mp, did you get it through now? Looking forward to your update. Thanks!

@RealSenseCustomerSupport. Thanks to ev-mp's reply. According to the guidelines of ev-mp, my problem has been solved.


Refine event handling

The internal event handling relied on the poll(2) for monitoring X11 events via I/O multiplexing. However, for backends such as SDL, this manipulation causes problems since the internal file descriptors associated with underlying system events are hidden and not exposed. Thus, we should avoid polling the file descriptors. Instead, let the backend handle the event loop when possible. See commit e935b0d4e505729b2b931934ecb729b0015d88f8 .
For #3, we may provide poll(2) based mechanism to monitor events when requested.

Reference for implementing Coroutine in C:
https://github.com/shengwen-tw/coroutine_c


Fix @return, @param an @var types

This is mostly just changing @return null to @return void, with two other notable changes:

the last two args of Clazz::__construct are no longer nullable
fixed @return of Type::getTemplateParameterTypeMap as Psalm emitted an error here

Also just removed an impossible instanceof check thanks to @TysonAndre pointing out a mistake in a previous PR here


THRIFT-4526: Implement rubocop for ruby in the sca build

Client: ruby

This PR introduces RuboCop into the sca build to keep code quality. It also addresses the "warning" and higher severities.

[x] Did you create an Apache Jira ticket?  (not required for trivial changes)
[x] If a ticket exists: Does your pull request title follow the pattern "THRIFT-NNNN: describe my issue"?
[x] Did you squash your changes to a single commit?  (not required, but preferred)
[x] Did you do your best to avoid breaking changes?  If one was needed, did you label the Jira ticket with "Breaking-Change"?
[x] If your change does not involve any code, add  [skip ci] at the end of your pull request to free up build resources.

The CI failures on Travis are irrelevant to the PR, it's probably caused by new version of rack, which is recently released (2.0.8 -> 2.1.0). Will file it as another issue.


stack deploy does not use env-vars from shell

Description
Trying to use my docker-compose file to stack my swarm.
I am testing here and there features and environment variables are a must.
But, I can't seem to forward them from my shell to the swarm as explained by the documentation.
Note: I am on Docker for Mac Beta, but never had an issue on anything.
I don't have the time this week to switch to stable to make sure it does not depend on the beta, but if necessary I can double check the very next one.
Steps to reproduce the issue:

init the swarm, with one node and one manager
I set my variable in my bash:

bash-4.4$ echo $MYNAME
something

Create and deploy the stack with a simple compose:

bash-4.4$ cat docker-compose.yml
version: '3'

services:
  client:
    image: postgres:9.6
    command: sleep<PHONE_NUMBER>
    environment:
      - MYNAME
    networks:
      - mynet

  server:
    image: postgres:9.6
    networks:
      mynet:
        aliases:
          - db

networks:
  mynet:

bash-4.4$ docker deploy -c docker-compose.yml test

Describe the results you received:
docker service inspect test_client | jq .[0].Spec.TaskTemplate.ContainerSpec.Env
[
  "MYNAME="
]

Describe the results you expected:
docker service inspect test_client | jq .[0].Spec.TaskTemplate.ContainerSpec.Env
[
  "MYNAME=something"
]

Additional information you deem important (e.g. issue happens only occasionally):
It works as expected if I do docker-compose up client.
Output of docker version:
Client:
 Version:      17.03.0-ce-rc1
 API version:  1.26
 Go version:   go1.7.5
 Git commit:   ce07fb6
 Built:        Mon Feb 20 10:12:38 2017
 OS/Arch:      darwin/amd64

Server:
 Version:      17.03.0-ce-rc1
 API version:  1.26 (minimum version 1.12)
 Go version:   go1.7.5
 Git commit:   ce07fb6
 Built:        Mon Feb 20 10:12:38 2017
 OS/Arch:      linux/amd64
 Experimental: true

Output of docker info:
Containers: 7
 Running: 2
 Paused: 0
 Stopped: 5
Images: 85
Server Version: 17.03.0-ce-rc1
Storage Driver: overlay2
 Backing Filesystem: extfs
 Supports d_type: true
 Native Overlay Diff: true
Logging Driver: json-file
Cgroup Driver: cgroupfs
Plugins:
 Volume: local
 Network: bridge host ipvlan macvlan null overlay
Swarm: active
 NodeID: e775z7lt77l793fipjsaem4bv
 Is Manager: true
 ClusterID: v910js09mbrhxc8o1804deb09
 Managers: 1
 Nodes: 1
 Orchestration:
  Task History Retention Limit: 5
 Raft:
  Snapshot Interval: 10000
  Number of Old Snapshots to Retain: 0
  Heartbeat Tick: 1
  Election Tick: 3
 Dispatcher:
  Heartbeat Period: 5 seconds
 CA Configuration:
  Expiry Duration: 3 months
 Node Address: <IP_ADDRESS>
 Manager Addresses:
  <IP_ADDRESS>:2377
Runtimes: runc
Default Runtime: runc
Init Binary: docker-init
containerd version: aa8187dbd3b7ad67d8e5e3a15115d3eef43a7ed1
runc version: 9df8b306d01f59d3a8029be411de015b7304dd8f
init version: 949e6fa
Security Options:
 seccomp
  Profile: default
Kernel Version: 4.9.11-moby
Operating System: Alpine Linux v3.5
OSType: linux
Architecture: x86_64
CPUs: 2
Total Memory: 1.952 GiB
Name: moby
ID: BIWR:ZM3N:3P6O:JFA4:KTZJ:EHDG:7UBY:5TPV:CK6K:I5BI:2O6M:OMWL
Docker Root Dir: /var/lib/docker
Debug Mode (client): false
Debug Mode (server): true
 File Descriptors: 58
 Goroutines: 177
 System Time: 2017-02-24T08:31:08.755419506Z
 EventsListeners: 3
Username: pdonorio
Registry: https://index.docker.io/v1/
Experimental: true
Insecure Registries:
 <IP_ADDRESS>/8
Live Restore Enabled: false

Additional environment details (AWS, VirtualBox, physical, etc.):
On Mac OS Sierra 10.12.3 (16D32),
Docker for Mac Version 17.03.0-ce-rc1-mac2 (15497)
Channel: beta 7c93573425

ping @dnephin @vdemeester

#30781 was opened a while ago to fix this

oh boy  didn't see it, I need some sleep I guess 😴

Sorry to bother: if I got it right there is already a PR for this which would work.
May I help to get this further?

@pdonorio yes, and the PR has been merged 👼 This should be available for 17.04 😉

Thank you!


starting "vue ui" - TypeError [ERR_INVALID_ARG_TYPE]: The "path" argument must be of type string. Received undefined

Version
4.5.14
Environment info
  System:
    OS: macOS 11.6.1
    CPU: (8) arm64 Apple M1
  Binaries:
    Node: 16.13.0 - ~/.nvm/versions/node/v16.13.0/bin/node
    Yarn: 1.22.17 - /opt/homebrew/bin/yarn
    npm: 8.1.0 - ~/.nvm/versions/node/v16.13.0/bin/npm
  Browsers:
    Chrome: 95.0.4638.54
    Edge: 95.0.1020.30
    Firefox: Not Found
    Safari: 15.0
  npmPackages:
    @riophae/vue-treeselect: ^0.4.0 => 0.4.0
    @vue/babel-helper-vue-jsx-merge-props:  1.2.1
    @vue/babel-helper-vue-transform-on:  1.0.2
    @vue/babel-plugin-jsx:  1.1.1
    @vue/babel-plugin-transform-vue-jsx:  1.2.1
    @vue/babel-preset-app:  4.5.14
    @vue/babel-preset-jsx:  1.2.4
    @vue/babel-sugar-composition-api-inject-h:  1.2.1
    @vue/babel-sugar-composition-api-render-instance:  1.2.4
    @vue/babel-sugar-functional-vue:  1.2.2
    @vue/babel-sugar-inject-h:  1.2.2
    @vue/babel-sugar-v-model:  1.2.3
    @vue/babel-sugar-v-on:  1.2.3
    @vue/cli-overlay:  4.5.14
    @vue/cli-plugin-babel: ^4.5.14 => 4.5.14
    @vue/cli-plugin-eslint: ^4.5.14 => 4.5.14
    @vue/cli-plugin-router:  4.5.14
    @vue/cli-plugin-unit-jest: ^4.5.14 => 4.5.14
    @vue/cli-plugin-vuex:  4.5.14
    @vue/cli-service: ^4.5.14 => 4.5.14
    @vue/cli-shared-utils:  4.5.14
    @vue/component-compiler-utils:  3.2.0
    @vue/composition-api: ^1.2.4 => 1.2.4
    @vue/preload-webpack-plugin:  1.1.2
    @vue/test-utils: 1.0.0-beta.29 => 1.0.0-beta.29
    @vue/web-component-wrapper:  1.3.0
    babel-helper-vue-jsx-merge-props:  2.0.3
    eslint-plugin-vue: ^6.2.2 => 6.2.2
    jest-serializer-vue:  2.0.2
    typescript:  3.9.10
    vue: ^2.6.14 => 2.6.14
    vue-cli-plugin-webpack-bundle-analyzer: ^4.0.0 => 4.0.0
    vue-count-to: ^1.0.13 => 1.0.13
    vue-demi:  0.9.1
    vue-eslint-parser:  7.6.0 (2.0.3)
    vue-hot-reload-api:  2.3.4
    vue-jest:  3.0.7
    vue-loader:  15.9.7 (16.8.1)
    vue-monoplasty-slide-verify: ^1.1.3 => 1.1.3
    vue-router: ^3.5.3 => 3.5.3
    vue-style-loader:  4.1.3
    vue-template-compiler: ^2.6.14 => 2.6.14
    vue-template-es2015-compiler:  1.9.1
    vuex: ^3.6.2 => 3.6.2
    vuex-persistedstate: ^3.2.1 => 3.2.1
  npmGlobalPackages:
    @vue/cli: Not Found

What is actually happening?
TypeError [ERR_INVALID_ARG_TYPE]: The "path" argument must be of type string. Received undefined
at new NodeError (node:internal/errors:371:5)
at validateString (node:internal/validators:119:11)
at Object.join (node:path:1172:7)
at Object.readPackage (/Users/cheyongzhi/.config/yarn/global/node_modules/@vue/cli-ui/apollo-server/connectors/folders.js:131:24)
at readPackage (/Users/cheyongzhi/.config/yarn/global/node_modules/@vue/cli-ui/apollo-server/connectors/dependencies.js:78:20)
at getLink (/Users/cheyongzhi/.config/yarn/global/node_modules/@vue/cli-ui/apollo-server/connectors/dependencies.js:170:15)
at /Users/cheyongzhi/.config/yarn/global/node_modules/@vue/cli-ui/apollo-server/connectors/dependencies.js:58:16
at Array.map ()
at findDependencies (/Users/cheyongzhi/.config/yarn/global/node_modules/@vue/cli-ui/apollo-server/connectors/dependencies.js:53:5)
at Object.list (/Users/cheyongzhi/.config/yarn/global/node_modules/@vue/cli-ui/apollo-server/connectors/dependencies.js:36:5) {
code: 'ERR_INVALID_ARG_TYPE'
}
(node:80985) [DEP0148] DeprecationWarning: Use of deprecated folder mapping "./" in the "exports" field module resolution of the package at /Users/cheyongzhi/Desktop/work/VUE_IFW/node_modules/vuex/package.json.
Update this package.json to use a subpath pattern like "./*".
(Use node --trace-deprecation ... to show where the warning was created)

Having the same issue. Does anyone know a solution for this?

same issue

Hello,
yes I am also currently having the same issue but not sure yet what the impact is and where it comes from.

TypeError [ERR_INVALID_ARG_TYPE]: The "path" argument must be of type string. Received undefined
at new NodeError (node:internal/errors:371:5)
at validateString (node:internal/validators:119:11)
at Object.join (node:path:1172:7)
at Object.readPackage (/usr/local/lib/node_modules/@vue/cli/node_modules/@vue/cli-ui/apollo-server/connectors/folders.js:131:24)
at readPackage (/usr/local/lib/node_modules/@vue/cli/node_modules/@vue/cli-ui/apollo-server/connectors/dependencies.js:78:20)
at getLink (/usr/local/lib/node_modules/@vue/cli/node_modules/@vue/cli-ui/apollo-server/connectors/dependencies.js:170:15)
at /usr/local/lib/node_modules/@vue/cli/node_modules/@vue/cli-ui/apollo-server/connectors/dependencies.js:58:16
at Array.map ()
at findDependencies (/usr/local/lib/node_modules/@vue/cli/node_modules/@vue/cli-ui/apollo-server/connectors/dependencies.js:53:5)
at Object.list (/usr/local/lib/node_modules/@vue/cli/node_modules/@vue/cli-ui/apollo-server/connectors/dependencies.js:36:5) {
code: 'ERR_INVALID_ARG_TYPE'
}

I am starting to update my vue-vite-vuetify-ceisum-template (https://github.com/meschg/vue-stack-cesium) and see if it still exists.
Kind regards,

Having this issue lately, but with "from" instead of "path" on an old project that always worked before. Output looks like this:
 ERROR  Failed to compile with 1 error                                                                                12:08:48 AM

 error  in ./src/LiveCode.vue?vue&type=template&id=a887fc58&

Syntax Error: Thread Loader (Worker 5)
The "from" argument must be of type string. Received undefined

 @ ./src/LiveCode.vue?vue&type=template&id=a887fc58& 1:0-525 1:0-525
 @ ./src/LiveCode.vue
 @ ./src/index.js
<EMAIL_ADDRESS>

I solved my case by pinning all Vue build-related dependencies. Something has an in-range breaking change somewhere.

We had this issue as well and it was caused by race conditions with a "non-serializable" loader. In our case, it was sass-loader. It's always sass...


Make Minutes.md updates automatic

See #35 - we should make Minutes.md some form of template that will automatically populate itself with a list of Minutes available in the pages/minutes subdirectory.

See #37


Global site config

Hi! What is the best way to define and use global site config(that depends on env)?
For example I have following config:
production: {api_key: "123"}
development: {api_key: "001"}
Accordingly to the docs  - getSiteData is what I need, but:

I didn't find any examples/notes - how to pass and use env with it
Is it possible to access SiteData from non-component? Lets say I have api library, that needs api_key. Can this library directly access SiteData?

Thanks!

For keys like that an environment variable is perfect. You can set those a variety of ways:

In your bash execution: $ MY_VARIABLE=123 react-static start/build
In your static.config.js file: process.env.MY_VARIABLE = '123'
Using something like dotenv or cross-env

@tannerlinsley thank you for detailed answer about env.
Ok, I set MY_VARIABLE, read it in static.config.js. How I can make it global and readable from other files? (That are not react components.)

You can access it in other files now via process.env.MY_VARIABLE
On Fri, Mar 16, 2018 at 1:00 PM unlimit<EMAIL_ADDRESS>wrote:

@tannerlinsley https://github.com/tannerlinsley thank you for detailed
answer about env.
Ok, I set MY_VARIABLE, read it in static.config.js. How I can make it
global and readable from other files? (That are not react components.)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/nozzle/react-static/issues/477#issuecomment-373813458,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AFUmCRqjkeEcG6IgemgKdHI0Kg4eJ1GAks5tfAvYgaJpZM4Stc6S
.


ensure wallet sync setting adheres to local data on Desktop

With the recent settings v2 revamp, we defaulted to true.

[x] LBRY APIs wallet sync should default to local storage setting
[x] save sync setting to wallet
[x] if not syncing to APIs, it should still write to local wallet

This is still an issue, gave Sean some feedback via DM:

sync section also says "to enable this feature, click save password on app startup" and it's greyed out (I had checked it during sign in).  This is supposed to refer to the sync balances/data setting, not password.

sync apply call failed when going to settings page and would lock up app instead of prompting me for a password.

wallet was decrypted somehow still - would need to try to repro, but I think sync apply with a blank password was called while it was unlocked (running daemon in the background).

Top bullets done - still interested in repro for some of the bottom bullets:
First - We talked about this messaging - going to leave it as is, but perhaps change the unsigned in text.
Second - This probably won't happen after fixing the checkSync bug on the settings page.
Third - Need repro?


Problem when used on remote server : Recycling/closing worker

Hello
I'm trying to deploy webssh in docker-compose instance.
When I try it locally, everything is working (I'm on Windows/Docker desktop) but when I deploy the same docker-compose file on a remote serveur (Linux, there is a proxy configured on the host, ...) webssh displays correctly the login page but when I enter user/password and connect nothing happens. there is no error message
At the beginning, even on localhost I had this behaviour but I solved it by adding "--policy=autoadd" options (I'm only using user/password authentification). But adding the same option on my remote server didn't solve the problem
So I changed run.py options to add info :
CMD ["python", "run.py", "--policy=autoadd", "--logging=debug", "--log-file-prefix=main.log"]
I think that my docker-compose file is useless to investigate
the only thing that coulb be tricky is the fact that my host needs a proxy but in docker-compose environment, between 2 docker services, I don't see why there would be a problem...
I don't really see what could cause the problem. authentification is OK and then connexion is closed
Thank you in advance
RV
Here you can find the logs :

[D 210825 11:32:42 handler:223] netloc: myserver.domain
[D 210825 11:32:42 handler:226] host: myserver.domain
[D 210825 11:32:42 handler:409] ('mydockerservice', 22, 'user', 'password', None)
[I 210825 11:32:42 handler:446] Connecting to mydockerservice:22
[D 210825 11:32:42 transport:1819] starting thread (client mode): 0x7f8ebb50
[D 210825 11:32:42 transport:1819] Local version/idstring: SSH-2.0-paramiko_2.7.2
[D 210825 11:32:42 transport:1819] Remote version/idstring: SSH-2.0-OpenSSH_7.9p1 Debian-10+deb10u2
[I 210825 11:32:42 transport:1819] Connected (version 2.0, client OpenSSH_7.9p1)
[D 210825 11:32:42 transport:1819] kex algos:['curve25519-sha256'<EMAIL_ADDRESS>'ecdh-sha2-nistp256', 'ecdh-sha2-nistp384', 'ecdh-sha2-nistp521', 'diffie-hellman-group-exchange-sha256', 'diffie-hellman-group16-sha512', 'diffie-hellman-group18-sha512', 'diffie-hellman-group14-sha256', 'diffie-hellman-group14-sha1'] server key:['rsa-sha2-512', 'rsa-sha2-256', 'ssh-rsa', 'ecdsa-sha2-nistp256', 'ssh-ed25519'] client<EMAIL_ADDRESS>'aes128-ctr', 'aes192-ctr', 'aes256-ctr'<EMAIL_ADDRESS><EMAIL_ADDRESS>server<EMAIL_ADDRESS>'aes128-ctr', 'aes192-ctr', 'aes256-ctr'<EMAIL_ADDRESS><EMAIL_ADDRESS>client<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>'hmac-sha2-256', 'hmac-sha2-512', 'hmac-sha1'] server<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>'hmac-sha2-256', 'hmac-sha2-512', 'hmac-sha1'] client compress:['none'<EMAIL_ADDRESS>server compress:['none'<EMAIL_ADDRESS>client lang:[''] server lang:[''] kex follows?False
[D 210825 11:32:42 transport:1819] Kex agreed<EMAIL_ADDRESS>[D 210825 11:32:42 transport:1819] HostKey agreed: ssh-ed25519
[D 210825 11:32:42 transport:1819] Cipher agreed: aes128-ctr
[D 210825 11:32:42 transport:1819] MAC agreed: hmac-sha2-256
[D 210825 11:32:42 transport:1819] Compression agreed: none
[D 210825 11:32:42 transport:1819] kex engine KexCurve25519 specified hash_algo
[D 210825 11:32:42 transport:1819] Switch to new keys ...
[I 210825 11:32:42 handler:86] Trying password authentication
[D 210825 11:32:42 transport:1819] userauth is OK
[I 210825 11:32:42 transport:1819] Authentication (password) successful!
[D 210825 11:32:42 channel:1212] [chan 0] Max packet in: 32768 bytes
[D 210825 11:32:42 transport:1819] Received global request<EMAIL_ADDRESS>[D 210825 11:32:42 transport:1819] Rejecting<EMAIL_ADDRESS>global request from server.
[D 210825 11:32:42 channel:1212] [chan 0] Max packet out: 32768 bytes
[D 210825 11:32:42 transport:1819] Secsh channel 0 opened.
[D 210825 11:32:42 channel:1212] [chan 0] Sesch channel 0 request ok
[D 210825 11:32:42 channel:1212] [chan 0] Sesch channel 0 request ok
[D 210825 11:32:42 channel:1212] [chan 1] Max packet in: 32768 bytes
[D 210825 11:32:42 channel:1212] [chan 1] Max packet out: 32768 bytes
[D 210825 11:32:42 transport:1819] Secsh channel 1 opened.
[D 210825 11:32:42 channel:1212] [chan 1] Sesch channel 1 request ok
[D 210825 11:32:42 channel:1212] [chan 1] Sesch channel 1 request ok
[D 210825 11:32:42 channel:1212] [chan 1] EOF sent (1)
[D 210825 11:32:42 channel:1212] [chan 1] EOF received (1)
[D 210825 11:32:42 handler:435] '$SHELL -ilc "locale charmap"' => b'ANSI_X3.4-1968\r\n'
[I 210825 11:32:42 web:2250] 200 POST / (<IP_ADDRESS>) 204.91ms
[W 210825 11:32:42 web:2250] 400 GET /ws?id=140391744658640 (<IP_ADDRESS>) 0.36ms
[D 210825 11:32:42 websocket:240] Can "Upgrade" only to "WebSocket".
[W 210825 11:32:45 worker:28] Recycling worker<PHONE_NUMBER>58640
[I 210825 11:32:45 worker:115] Closing worker<PHONE_NUMBER>58640 with reason: worker recycled
[D 210825 11:32:45 channel:1212] [chan 0] EOF sent (0)
[I 210825 11:32:45 worker:122] Connection to siam:22 lost
[D 210825 11:32:45 worker:125] {}
[D 210825 11:32:45 transport:1819] EOF in transport thread

The tornado server did not receive the "Upgrade" header, so the websocket connection was failed.
It is probably a proxy problem.

Hello
Me again. What could be the proxy problem ? something to configure in webssh config ?
My serveur has a proxy configured in /etc/environment http_proxy and HTTP_PROXY for compliance
I had to configured Docker in addition via /etc/systemd/system/docker.service with Environment
Is there something equivalent for webssh ?


Memory Leak issue

Hi
First thanks for the great library. It's really useful.
But I am facing the memory leaks when using this library. I have debug into the code and came to know that this code is causing memory leak.
self.propertyAnimator = [[UIViewPropertyAnimator alloc] initWithDuration:1.0 curve:UIViewAnimationCurveLinear animations:^{                 self.blurBackgroundView.effect = nil;             }];
To resolve it I have changed it to weak self as instructed by Apple to avoid any memory issue.
__weak MZFormSheetPresentationController *weakSelf = self;             self.propertyAnimator = [[UIViewPropertyAnimator alloc] initWithDuration:1.0 curve:UIViewAnimationCurveLinear animations:^{                 weakSelf.blurBackgroundView.effect = nil;             }];
Please update the pod with resolution of this issue.
Thanks!!!

Thanks, thats true, this is a memory leak, can you make PR ?

Don't see Pull Request, you probably only have added commit to your repo

Is this issue resolved? My apps are freezing due to this issue.


Typo "brach"

Overview
TL;DR
<On the website, this line exists: "create a brach, you can be sure that you will be working with the most recent information".>

Hi

https://github.com/github/training-kit/issues/799#issue-740694163

This was fixed in #813  🎉


Some cases will be ignore

The safe resolve seems not accurate, because something like @babel/xxx will not be treated as external.
I find that your comment said there is another plugin which could do this(I haven't test it for now), but I think maybe this is not a good way, from my personal perspective we should put that into this repo because this is its own responsibility to do this.

Try https://github.com/Septh/rollup-plugin-node-externals

@elado I tried but seems that still doesn't work, unlike this repo just ignore the @babel/xxx, the plugin you mentioned ignore all except peerDependencies

rollup-plugin-node-externals worked for me


Use std::old_path.

This patch is needed to compile nix-rust.

This is a duplicate of #59.

Handled by #59. Thanks though :smile:


[Site] Footer re-work and Mobile responsiveness

Current State of the GetNighthawk.dev site
Currently, The footer has a few components (copyright text and social media logos) that are wrongly aligned in the desktop view as well as the mobile view.

Desired State of the GetNighthawk.dev site
Refer to the Figma link - https://www.figma.com/file/5ZwEkSJwUPitURD59YHMEN/Layer5-Designs?node-id=6189%3A0

Contributor Resources

See the Contributing to getnighthawk.dev Website
See the Project Site section of GetNighthawk project doc

can I take up this issue?


added shared component for prefix inputs

What does this PR do and why?
Fixes - https://github.com/jbx-protocol/juice-interface/issues/2157
I've added shared component PrefixInput (the name may be dumb but please suggest if you have a better one 😺 ) that is going to handle all inputs that need prefixes throughout the app.
The first example was in the creation flow, therefore I first adjusted in NFT rewards input that is responsible for external links ( you gonna see in the video ), and then I've added prefix input in details for project links.
one note: CSS is acting weird in project links, @wraeth-eth do you have any idea since this is your baby? 🙏
Small touchups:

created url.ts and moved functions over from SocialLinks.tsx so we can use them everywhere such as -  prettyUrl , linkUrl
adjusted prettyUrl function a bit, now we also remove slash at the end of URL, for example in past we displayed example.com/ and now we display example.com

Screenshots or screen recordings
Before
https://user-images.githubusercontent.com/18723426/199320841-979a325f-a84d-403d-a7ba-59415b4373af.mov
After
https://user-images.githubusercontent.com/18723426/199320869-92b736e2-6679-480b-8ac4-580e7a04bbe1.mov

Acceptance checklist

[ ] I have evaluated the Approval Guidelines for this PR.
[ ] I have tested this PR in all supported browsers.
[ ] I have tested this PR in dark mode and light mode (if applicable).

This is great @NakedFool. I think maybe we could change the name to PrefixedInput. I also think the default value 'https' is probably unnecessary, and we should just require giving it as the prefix prop in each instance of the component. Looks great to me otherwise.

This is great @NakedFool. I think maybe we could change the name to PrefixedInput. I also think the default value 'https' is probably unnecessary, and we should just require giving it as the prefix prop in each instance of the component. Looks great to me otherwise.

Fixed conflict and applied changes ser!

@johnnyd-eth @NakedFool shall we get this merged?

@johnnyd-eth @NakedFool shall we get this merged?

it looks good to me now, there was a minor conflict with importing stuff but now that's resolved.


extending the db object

First, thanks for the fantastic module! I was just about to write something like this myself when I found this package.
The only part that feels a bit off to me is how this package extends the db object with a db.transaction() method similarly to level-sublevel. I think a better model for providing functionality on top of leveldb is to pass in an ordinary levelup or leveldown instance to a function that returns a function or a new instance like how subleveldown works:
var sub = require('subleveldown')
var db = level('db')
var test = sub(db, 'test') // test is a new prefixed levelup

The subleveldown approach works best across a vast ecosystem of packages like we have on npm since there might be many versions of a library in a dependency tree, and modifying a reference will affect functionality globally. This subverts semver and makes applications more fragile against library changes.
I propose a level-transactions api more similar to the subleveldown approach:
var db = level('./db')
var transaction = require('level-transactions');

var tx = transaction(db);

If you'd like I can send a pull request for this feature too. Thanks for the great module!

The original way of extending db object was kinda resemble the sublevel way of a level- plugin. I do agree the subleveldown's modular approach is better. Thanks for your feedback!


Page list as simple example to get my head around SFW

Sorry I couldn't make it this week to the workshop. Sounds like a fun project so I figured that I would tinker. I'm sure that other are like this too but I needed to get my hands dirty to figure out the inner workings, thus I set my self a simple example of building out a route that just lists the known pages. So far so good though I did run in to some issues and confusion. Disclaimer: I think in perl so this whole ruby universe still feels foreign, I'm sure that much of my confusion is just not knowing the expected baselines, sorry in advance.
Ok off to the races: Where did I get confused?

Where's 'page' built? I kept running in to errors about page['title'] not found before I just gave it a string in pages.haml. The closest example that I could find was put /pages/.../action, I attempted to build a hash in the route but that wasn't it. In reading over [[Concepts]] it sounds like the expectation is that page is some magic that reads the JSON, but what about system gen pages like this one? Is there a clean way to feed the right data to some method to just make it happy, rather then completely side-step things like I did?
I'm completely lost on why going to /pages ends up at /view, I'm guessing that it has something to do with that page thing that I never found as all the other pages seem to do that. I'm sure that there's a very good reason but I couldn't find it in the docs nor in code. Is this a case of: it was explained in person and never made it to the docs? I'll gladly help starting those docs with some coaching.
Long term is the expectation that config items will be something... well configurable? Currently it looks like paths to data are hard coded? I followed suit though it seems that doing something like conf.pages.map{} would be prefered over what I've done? I know that this is likely cart before horse as the project is still rather young, so I guess this is more of a feature request rather then a point of confusion.

So those are the big ones, I'm sure that as I play I'll have more questions, is there a preferred channel for them as they come up? Thanks again ward and team for helping make a happy place for content.
Let me know how I can help.
--
benh~

Ben -- Welcome to the project. Thanks for jumping in. There is no better way to learn code than by using it.  I felt like I was sitting next to you.
Had I been actually sitting next to you I would of mentioned that Ruby/Sinatra are playing increasingly less significant roles in this project. I like the use case you've chosen. But I'm not comfortable with your strongly server-side implementation approach. Let me summarize it and then suggest an alternative:

Sinatra detects a unique route (url syntax)
Ruby code collects data for a response
Haml formats this into a new web page

The direction we're heading puts the center of control on the client side with one script, client.js, interpreting JSON objects which are the wiki pages (soon to be call articles) which can co-exist with other articles within a single web page. The way to extend this repertoire of functionality is by adding new types of elements to the JSON object.
Here is how it might work. Say your wiki started with welcome-visitors that included a paragraph-like section listing all available pages on your site. This then gets rendered as follows:

Sinatra generates the boiler-plate for the one-page application
A div in that page cites your welcome-visitors which is loaded via ajax and rendered client-side
While rendering, your "all pages" paragraph is rendered by consulting the plugin directory
Your plugin queries the server for a json object listing every page which it then renders as a list

The advantage of all this is that instead of creating a new web page you are creating a new type of paragraph (more correctly a new type of story item). This item can participate in drag-and-drop refactoring when you decide that the list should appear on another page.
There is a model for this in the "changes" plugin that lists pages stored in the browser's localStorage. There is a short-hand list of plugins in the client.coffee code. Look for "changes" there.
Fair warning: I'm not above editing JSON to call for a new plugin before there is any interface to create instances of that item type. This lets me feel what it is like to have something before I figure out how to make them.

Thanks Ward for the very detailed reply. I think that it's very
interesting move toward a js only core. This would make it insanely
portable. Is this the intent or is it just a happy accident? Though if
that's the direction, then I wonder why having Sinatra on the backend
at all? It seems like overkill if the intent is to just ship a single
page app, wouldn't that be doable by just a simple flat html file?
Then if I understand thing correctly, with that move then the app
would then use local storage rather then the JSON file scheme that is
currently set up with Sinatra. Then the wiki cross talk would be done
via JSON packed snapshots from local store. All possible via JS, it
just needs to get to the browser.
Does it sound like I have a good understanding on where you want to
see SFW heading? Either way this is a great excuse for me to play with
coffeescript.

We have been discussing the distribution of responsibilities between client and server in issue #47. There the question is how much the server participates in retrieving remote pages. So far Sinatra has been helpful in that pretty much anything I would expect of a server is easy to realize with Sinatra and standard gems.


Cannot DROP BLOB TABLE

CrateDB version
4.2.6
CrateDB setup information
No response
Steps to Reproduce
DROP TABLE "blob"."mytable"`
-- or
DROP BLOB TABLE "blob"."mytable"

I receive the following error:
SQLActionException[ClusterBlockException: blocked by: [FORBIDDEN/12/index read-only / allow delete (api)];]

Tried to change the table settings but that also fails.
ALTER TABLE "blob"."document" SET ("blocks.read_only_allow_delete" = FALSE)

SQLActionException[OperationOnInaccessibleRelationException: The relation "blob.mytable" doesn't support or allow ALTER operations.]

ALTER BLOB TABLE "blob"."document" SET ("blocks.read_only_allow_delete" = FALSE)

SQLActionException[SQLParseException: Invalid property "blocks.read_only_allow_delete" passed to [ALTER | CREATE] TABLE statement]

NOTE: Some nodes in the cluster reached the storage full threshold in the past, which made all the tables readonly.
Expected Result
Table being dropped
Actual Result
SQLActionException[ClusterBlockException: blocked by: [FORBIDDEN/12/index read-only / allow delete (api)];]

Quick note: Behaviour is reproducible with most recent release version CrateDB 4.8.0


Need a mechanism to enforce adding helpful resolutions to customer facing errors

AmplifyErrorOptions treats the resolution field as optional. Requiring a resolution to customer facing errors at the time of adding error handling allows us to prevent playing catch up in the future. Additionally, it requires contributors to think through the customer experience when an error is thrown and how/if the customer can do anything about it (hint: if they can't, this is our Fault)

Whoever picks this up, make the resolution field required and see what the changes look like to make TS happy. If it starts to look gross, we can reevaluate how / if we want to tackle this.


Add new cursor types ‗

Description of the new feature/enhancement

Currently in cmd.exe and windows terminal we have a couple of options to customize cursor shape. It might be interesting to add additional options there, and I would propose to start with double underline.

Image adjusted from MS devblogs.
This would give to WT a new unique feature, which I am not aware other terminals do have. 🥇
Proposed technical implementation details (optional)
I presume, for start, it would be needed to add new shape functionality to paint.cpp, something like:
case CursorType::DoubleUnderscore:
        line1 = line2 = rcBoundaries;
        RETURN_IF_FAILED(LongAdd(line1.bottom, -1, &line1.top));
        RETURN_IF_FAILED(LongAdd(line1.bottom, -3, &line1.top));
        cursorInvertRects.push_back(line1);
        cursorInvertRects.push_back(line2);
        break;

Of course, additional code and documentation changes would be needed, but I think that should not be hard to do. 😸

I'm okay with this. I believe the EmptyBox cursor is already one of the cursors that's not possible to set with VT, so we might as well have others.

Are new cursors, something that could be added as extensions in the future?  There could be some cool animated effects that would add a touch of flare to the experience.

Rainbow or Pride cursors;
Animated gradients or glitter and sparkle effects;
Simple throbbing effect as the cursor "breathes" with a simple fade in and out;
etc

@mdtauk That's definitely something we'd want to consider for renderer extensions (over in #4000). If our goal is to make the retro terminal effect an extension one day, then cursor effects should be much easier than that 😆

Hello
I would like to work on this, if it's okay.
I already fiddled a bit. Am I right that there is a GDI- and a DirectX-Renderer?
If my assumption is right, I got two questions:

How am I able to test the GDI renderer with Microsoft's Dev VM?
For the DirectX renderer: Would you prefer a stack/vector of rectangles or a new CursorPaintType (i.e. DoubleLine) in CustomTextRenderer::_drawCursor?

Thanks.

As you see, I created a PR. I came up with a more generic approach than a CursorPaintType "DoubleLine". I created one named HorizontalOnly, IMHO turning the second question obsolete. This would allow the addition of more "horizontal only" cursors, i.e. just an overline and underline...
Let me know if I should perform more steps (i.e. add automated tests).


optimize png images using zopflipng

Using Google's zopflipng to recompress png images losslessly.
Size before optimize:
16500   ./assets
3708    ./dist
444     ./demo

Size after optimize:
15784   ./assets
3180    ./dist
436     ./demo

thanks


[skia] build failure

Host Environment

OS: Windows 10
Compiler: Visual Studio 2019

To Reproduce
Steps to reproduce the behavior:
./vcpkg install skia
Failure logs
PS D:\vcpkg> .\vcpkg.exe install skia
Computing installation plan...
The following packages will be built and installed:
    skia[core]:x64-windows
Starting package 1/1: skia:x64-windows
Building package skia[core]:x64-windows...
-- Using cached D:/vcpkg/downloads/skia-05676f7bc238f667de848dfd37b4aa3c01b69efb.tar.gz
-- Using source at D:/vcpkg/buildtrees/skia/src/3c01b69efb-0a98da8354
-- Syncing git dependencies...
-- Generating build (debug)...
-- Generating build (release)...
-- Building Skia (debug)...
CMake Error at scripts/cmake/vcpkg_execute_build_process.cmake:136 (message):
    Command failed: "C:/Program Files (x86)/Microsoft Visual Studio/2019/Community/Common7/IDE/CommonExtensions/Microsoft/CMake/Ninja/ninja.exe" -C D:/vcpkg/buildtrees/skia/x64-windows-dbg skia
    Working Directory: D:/vcpkg/buildtrees/skia/src/3c01b69efb-0a98da8354
    See logs for more information:
      D:\vcpkg\buildtrees\skia\build-x64-windows-dbg-out.log
      D:\vcpkg\buildtrees\skia\build-x64-windows-dbg-err.log

Call Stack (most recent call first):
  ports/skia/portfile.cmake:107 (vcpkg_execute_build_process)
  scripts/ports.cmake:90 (include)

Error: Building package skia:x64-windows failed with: BUILD_FAILED
Please ensure you're using the latest portfiles with `.\vcpkg update`, then
submit an issue at https://github.com/Microsoft/vcpkg/issues including:
  Package: skia:x64-windows
  Vcpkg version: 2020.02.04-nohash

Additionally, attach any relevant sections from the log files above.

Additional context
build-x64-windows-dbg-err.log
ninja: error: '../src/3c01b69efb-0a98da8354/third_party/externals/icu/common/icudtl.dat', needed by 'icudtl.dat', missing and no known rule to make it

I really don't have this file here

Hi @sotex, thanks for reporting this issue.
Could you provide full log D:\vcpkg\buildtrees\skia\build-x64-windows-dbg-out.log and D:\vcpkg\buildtrees\skia\build-x64-windows-dbg-err.log?
Thanks.

@JackBoosY Sorry, I only reply to you today.
build-x64-windows-dbg-out.log
ninja: Entering directory `D:/vcpkg/buildtrees/skia/x64-windows-dbg'

build-x64-windows-dbg-err.log
ninja: error: '../src/3c01b69efb-0a98da8354/third_party/externals/icu/common/icudtl.dat', needed by 'icudtl.dat', missing and no known rule to make it

@sotex, do you have access to https://chromium.googlesource.com? To my surprise, there appear to be issues with that url from China.
This has also been reported in the following issues:

https://bugs.chromium.org/p/chromium/issues/detail?id=411187
https://github.com/google/shaka-packager/issues/597
https://github.com/microsoft/onnxruntime/issues/1775

The error's indicating that the icu dependency is failing, which can be disabled by adding
skia_use_icu = false

to D:\vcpkg\buildtrees\skia\x64-windows-dbg\args.gn and D:\vcpkg\buildtrees\skia\x64-windows-rel\args.gn. However, I would expect there to be other failing dependencies as well.
@JackBoosY, I'll look into replacing these dependencies in the Skia port with ones from vcpkg (as was done for the Crashpad port), which should hopefully fix this issue.

@vejmartin You are right, we cannot access googlesource.com . I will try again as you said, thank you very much.

I'm having the same problem and can't access skia.googlesource.com. I wonder if there is any other way to solve it?

@fawdlstty  May be you need a proxy.

Yes, I have try to use, but the results are very poor, I still can't install Skia 😢


Support for Knex 3.x

Hello!
The current version supports Knex 2.x versions only. Are there any plans to support 3.x as well?
Best,
Jussi

Did you tried it with knex v3? It should work...
If no, can you share the error...

Did you tried it? Is it failed? What do you get?

The following line in package.json is causing problems with npm i.
"peerDependencies": {
"knex": "^2.0.0"
},
I didn't try any magic to bypass that and see if it would work for real.

Can you check if it solved for you in v2.0.1?

I've just tried this and it seems to work fine with knex 3 with a fairly basic test. Just had to tell npm to ignore the restriction on the peer dependency using npm i -D knex-mock-client --force so would be ideal to just update the peer dependency to allow 2 or 3...
"peerDependencies": {
"knex": "^2.0.0 || ^3.0.0"
},

Or if you want to be less restrictive it could just be >=2.0

@brainsiq thank you for your input, this is exactly what i've did in v2.0.1 :]
Closing this issue.

Thank you for your fast feedback. Version 2.0.1 seems to work nicely with Knex 3.x series. 🙇


Formatting for node-version matrix not working

I just setup GH Actions using the Nodejs recommended workflow and when using the node-version matrix it doesn't format the name of the version it's using properly:

For what it's worth, here is my nodejs.yml file:
name: Main

on: [push]

jobs:
  run:
    name: Run

    runs-on: ubuntu-latest

    strategy:
      matrix:
        node-version: [10.x, 12.x]

    steps:
    - uses: actions/checkout@v1
    - name: Use Node.js ${{ matrix.node-version }}
      uses: actions/setup-node@v1
      with:
        node-version: ${{ matrix.node-version }}

    - name: install and build
      run: |
        npm ci
        npm run build
      env:
        CI: true

    - name: lint
      run: |
        npm run lint
        npm run style

    - name: test
      run: npm test
      env:
        CI: true

@chrispat why was this closed?
Here the same issue can be seen: https://github.com/jaydenseric/babel-plugin-syntax-highlight/runs/216262526

This issue is fixed in the orchestrator and will rollout in a coming update.


[VZ] Update CONTRIBUTING.md to give workflow for contributing

Moved from https://github.com/cfpb/cf-buttons/issues/39 and applies generally to all cf-components.
While updating this project @anselmbradford  realized the CONTRIBUTING.md and docs he looked at on http://cfpb.github.io/capital-framework/contributing/ are too generic to guide a contributor in what needs to be done when fixing an issue and contributing to the project. Specifically what installation and grunt commands need to be run, what needs to happen with the changelog, etc.

[ ] cf-core
[ ] cf-grid
[ ] cf-icons
[ ] cf-buttons
[ ] cf-forms
[ ] cf-pagination
[ ] cf-expandables
[ ] cf-layout
[ ] cf-typography
[ ] capital-framework
[ ] cf-grunt-config
[ ] cf-component-demo
[ ] generator-cf

There is a single contributing file in the main repo and it's pretty robust. @anselmbradford having run it again recently, is there anything you think we need to add/change that can be addressed in this issue?

@anselmbradford bumpity bump. I'm pretty sure we can close this one.

Sounds good 👍 I'll be running through them again sometime after the 11th and will re-open if necessary.


Implement Automatic Page Generation and Site Map for Non-Profit Data

Enhance the structure and SEO of TryOpenGiving by implementing automatic page generation and a site map based on the non-profit data currently available. This will help in creating dedicated pages for each non-profit, which can be easily indexed by search engines.
Acceptance Criteria:

Automatically generate a page for each non-profit listed in our platform based on their data (e.g., name, description, donation options, etc.).
Create a dynamic site map that updates as new non-profits are added or removed.
Ensure that each generated page has a clean URL structure (e.g., /non-profits/{non-profit-name}).
Implement logic that checks for updates in non-profit data and regenerates the pages accordingly.
Optimize the generated pages for SEO, including meta tags, Open Graph, and structured data.
Ensure the solution is scalable for a large number of non-profits.

I want to work on this issue. What programming language is will I write the code with?

Hi @DevvEmeka,
The project is built with JavaScript and uses Next.js, so kindly use that. Let me know if you have any more questions.


Prevent user from submitting tag by ENTER key & add button to submit tag

This PR add Button to submit a tag in modal window
fixes #345

The issue description says "fixes #345", but I think this fixes #344, right? (that being said, I am happy if you can fix both in the same PR, as the same language strings and icon would be used)

fixed https://github.com/readium/readium-desktop/issues/345#issuecomment-520473122

The issue is not fixed (but I am happy to close this obsolete and unmaintained PR :) )
PR https://github.com/readium/readium-desktop/pull/550 fixed issue https://github.com/readium/readium-desktop/issues/345
...but issue https://github.com/readium/readium-desktop/issues/344 remains open.


Add a files method

Like file but takes multiple files. Make it accept IntoIterator<Item = AsRef<&str>>.

@brson maybe IntoIterator<Item = AsRef<Path>>? file takes AsRef<Path>.

@opilar yeah that sounds right to me!

Can anyone help me with that?
258 | /     pub fn files<P: IntoIterator<Item = AsRef<Path>>>(&mut self, p: P) -> &mut Config {
259 | |         for file in p.into_iter() {
260 | |             self.file(file);
261 | |         }
262 | |         self
263 | |     }
    | |_____^ `std::convert::AsRef<std::path::Path> + 'static` does not have a constant size known at compile-time
    |
    = help: the trait `std::marker::Sized` is not implemented for `std::convert::AsRef<std::path::Path> + 'static`
    = note: required by `std::iter::IntoIterator`

Oh that's actually shorthand, I think what you'll actually want is:
fn files<P>(...)
    where P: IntoIterator, P::Item: AsRef<Path>


Sharing global client side dependencies

In a nutshell:

We want to externalize a large dependency (React & ReactDOM in our case but could be any) from OC components for code sharing reasons
The host microsite is responsible for shipping these in the html response
Components then depend on these from the global scope (ideally using something like webpack's externals)

This works fine in principal, but it has the side effect of breaking the components ~preview url. I've created the following repo to help demonstrate the issue -> https://github.com/matthewdavidson/client-side-render-with-external-deps
We could use the oc require mechanism, but the guide even mentions:

"This is particularly useful in case we want to use a javascript dependency and we want to load it only if the container does not exposes it on the global scope."

The question is, how do you facilitate this and get the ~preview functionality working?

Ok, the issue is:

server-side rendered A+B script tags guarantees A is done first and B next. If B depends on A, you're ok
client-side rendered A+B script tags have no guarantee A is gonna be downloaded and executed first, and B next (and ~preview does client-side rendering). That's why sometimes it could work, sometimes it couldn't (it probably depends on network or caches etc). And that's why we built oc.require. With oc.require you know you can require A, then B, and it should be guaranteed to be in the correct order and work.

So, I tried to move your requires to oc.require and it works for me: https://github.com/matthewdavidson/client-side-render-with-external-deps/pull/1
Consider that if you inspect the HTML you should see react and react dom in the  of your page. But if you already have them in a page, the require shouldn't happen and it should just execute the callbacks straightaway.

Ok so do you folks always make sure and use oc.require whenever you use an external dependency? It make complete sense - load order is non deterministic therefore it makes sense to use an async flow. I guess it was just the note in the wiki that threw me off.
Feel free to close this :). I suspect we'll want to talk about some improvements that could perhaps be made to the oc-client component and the functionality it exposes, namely:

first class react support (in progress with #392)
Improving the oc.require api to use promises or something a little more akin to import() (see https://webpack.js.org/guides/code-splitting-import/#dynamic-import)
Having the option to drop jquery as we are deprecating it

Ok @matthewdavidson

Can you improve the wiki? Feel free to edit as you like.
We will definitely talk more about explicitly declaring client-side deps. This is needed for isomorphic react apps and I know @nickbalestra has a lot of ideas about it. Leave it to me, we'll probably create a whole repo to discuss the react thing very soon.
I think browser client needs some love. There is an open discussion about improving the dynamic imports: #281 - if we can improve it on the client or in the bundled js, either is a win!
Dropping jquery is complicated when supporting old browsers but I definitely would like to. Perhaps we can start a separate thread to figure out if we want/can drop ie9 support which I think needs a lot of jquery? Feel free to open an issue for that.
Closing this as you recommended. Let's discuss the various points in the separate issues.


chore: Add an ExperimentOptions class to control experiments

FYI @TrevorBergeron, the semantic operators would be launched as experimental APIs, when the configurations are enabled.


[Feature] Use em instead of rem in styles

My app has a setting where users can change the text size of the editor by changing the container's CSS font size.
However, almost all of milkdown's styles use rem as the base unit. It's causing problems like  table cells and task lists bullets being way too large and out-of-place for the user's font size.
So far I've been trying as best as I can to override the styles whenever I see it affecting the interface. It's hard as well, because I still can't cover all the rem styles (therefore causing a lot of UI inconsistencies) and because milkdown uses styled-components (and CSS classes are random).
This is probably affecting other users that have their milkdown editor somewhere separate from their root. I think using em instead of rem would make milkdown scale much better and improve usability for those use cases. Thanks.

https://css-tricks.com/rems-ems/
Inshort: I won't replace rem with em for the reason in the article. For your case, create your own theme seems more reasonable. I'm working on milkdown v6 to make it easier.

So here’s my idea: you still keep px size adjustments at the document level so you can make easy/efficient sweeping size changes. But then each module on the page has a font-size set in rem. Actual text elements (h1, h2, p, li, whatever), if you size them at all, are sized in em, and thus become relative to the module.
This way you can adjust font-size at a module level, which is pretty easy. The chances the type within a single module have good proportions and can scale together nicely is high.

I don't really understand what part of the article was the rationale for using rem (feel free to point it out for me). But what I got from it is:

The root element (document.body) should have a pixel size
An individual module's root (like a sidebar or an editor) should use rem
Everything inside that module should use em, so it scales relative to the module

And not "everything should be rem".
If you still want to keep rem anyway, how would you suggest I handle things like this (milkdown's line height being 3rem while the font size is half the root size)?

Let me reconsider this.


fix cel API generation

It currently fails.
https://github.com/googleapis/artman/blob/fcc5de85002c7a9d6c9bc9e46b313daef0aa7c03/test/smoketest_artman.py#L50

go: downloading golang.org/x/text v0.3.0
go: extracting golang.org/x/text v0.3.0
go: finding golang.org/x/net v0.0.0-20190213061140-3a22650c66bd
go: finding golang.org/x/sys v0.0.0-20180830151530-49385e6e1522
go: finding golang.org/x/text v0.3.0
artman generating google/api/expr/artman_cel.yaml
Traceback (most recent call last):
  File "/usr/bin/artman", line 6, in <module>
    from pkg_resources import load_entry_point
  File "/usr/lib/python2.7/site-packages/pkg_resources/__init__.py", line 3191, in <module>
    @_call_aside
  File "/usr/lib/python2.7/site-packages/pkg_resources/__init__.py", line 3175, in _call_aside
    f(*args, **kwargs)
  File "/usr/lib/python2.7/site-packages/pkg_resources/__init__.py", line 3204, in _initialize_master_working_set
    working_set = WorkingSet._build_master()
  File "/usr/lib/python2.7/site-packages/pkg_resources/__init__.py", line 585, in _build_master
    return cls._build_from_requirements(__requires__)
  File "/usr/lib/python2.7/site-packages/pkg_resources/__init__.py", line 598, in _build_from_requirements
    dists = ws.resolve(reqs, Environment())
  File "/usr/lib/python2.7/site-packages/pkg_resources/__init__.py", line 791, in resolve
    raise VersionConflict(dist, req).with_context(dependent_req)
pkg_resources.ContextualVersionConflict: (ply 3.11 (/usr/lib/python2.7/site-packages), Requirement.parse('ply==3.8'), set(['google-gax']))
error generating gapics (may need to check logs for more errors): exit status 1
exit status 1

@alexander-fenster Is it still a problem?

This was fixed. Sorry!

Great. Thanks for the update!


[Medium] "Auto-Update Page" checkbox is automatically unchecked when user switches between different sections

To Reproduce

Run AlphaPept and in the "Status" section check "Auto-Update Page" check box.
Switch to any other section, i.e. "New experiment".
Switch back to the "Status" section and check that the "Auto-Update Page" check box is again unchecked.

Expected behavior
It would be nice to save the checking/unchecking of this check box during switching between the sections.
Version (please complete the following information):

OS: Windows
Version: 10.0.19041
Installation Type: One-Click Installer

Revised to now auto-update.


feat: Improved documentation

fixes #355

@sftim @reylejano @salaxander Hey raised their PR which fixes the issue #355

/lgtm
/approve


Fixing Java.Lang.NullPointerException: bitmap

I am not sure if this also occurs on iOS and I am not able to find out so it is fixing just on android.
If I find out that it occurs also on iOS I will push another pullrequest

It probably occurs only on Android. @amay077 could you review this PR please?

Sorry I'm late.
Merged it, thanks!

ref #246

ref #235


NIFI-7728: FetchS3Object sends a flowfile to failure relationship if the given bucket or object key is empty

Thank you for submitting a contribution to Apache NiFi.
Please provide a short description of the PR here:
Description of PR
This change will fix https://issues.apache.org/jira/browse/NIFI-7728
The original contributor has left working this development, I'm fixing it in this PR instead.
Previous PR: https://github.com/apache/nifi/pull/4515
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:

[X] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?

[X] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

[X] Has your PR been rebased against the latest commit within the target branch (typically main)?

[ ] Is your initial contribution a single, squashed commit? Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not squash or use --force when pushing to allow for clean monitoring of changes.

For code changes:

[X] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
[X] Have you written or updated unit tests to verify your changes?
[ ] Have you verified that the full build is successful on JDK 8?
[X] Have you verified that the full build is successful on JDK 11?
[ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
[ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
[ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
[ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?

For documentation related changes:

[ ] Have you ensured that format looks appropriate for the output in which it is rendered?

Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI for build issues and submit an update to your PR as soon as possible.

Thank you for looking at this change.
Assume that the "Bucket" property of FetchS3Object is set to "${bucket}" and "Object Key" property is set to "${key}". If we set bucket = "valid-bucket-name" and key = "" (empty string) in Variables in the process group, after this change the flowfile will be routed to failure instead of stucking as the current implementation. If a user set the failure relationship to self-loop, changing key = "valid-key-name" correctly while being penalized would fix this error, and the flowfiles would be then routed to success with fetching an S3 object successfully. I think this is the same semantic as the other kinds of errors, penalizing in this case also meaningful.

In case of the variable in the incoming flowfile attributes, yes, penalizing has no meanings. So like failure.reason idea makes sense to me.

Yeah but would someone use variables/parameters for bucket and key in this processor? Wouldn't it always be based on flow files attributes?

Yes I definitely agree with using flow files attributes is typical cases. I'll try to think over and fix the code based on the ideas.


fluentd is not functioning

this now fixed I think

Unfortunately still having this issue with new installation. [fluentd-gcp-v2.0] Pods 0/0. "DaemonSet has no nodes selected"


Use LinkedHashMap for deterministic order in Issue1177_2.java

The test in com.alibaba.json.bvt.issue_1100.Issue1177_2#test_for_issue can fail due to a different order. The assertion compares a hard-coded string against the string representation of a JSON object implemented by HashMap. The failure is presented as follows:
junit.framework.ComparisonFailure:
expected:<{"a":{"x":"y2"},"b":{"x":"y2"}}>
but was:   <{"b":{"x":"y2"},"a":{"x":"y2"}}>
The reason is that HashMap makes no guarantee about the iteration order. The specification about HashMap says that "this class makes no guarantees as to the order of the map; in particular, it does not guarantee that the order will remain constant over time". The documentation is here for your reference: https://docs.oracle.com/javase/8/docs/api/java/util/HashMap.html
The fix is to change HashMap into LinkedHashMap. In this way, we can get rid of the non-deterministic behaviour and make the test more stable.

Codecov Report

Merging #3042 into master will decrease coverage by 0.06%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #3042      +/-   ##
============================================
- Coverage     80.58%   80.52%   -0.07%
+ Complexity     7234     7232       -2
============================================
  Files           145      145
  Lines         27106    27131      +25
  Branches       6490     6501      +11
============================================
+ Hits          21844    21846       +2
- Misses         3383     3400      +17
- Partials       1879     1885       +6

Impacted Files
Coverage Δ
Complexity Δ

...m/alibaba/fastjson/serializer/ArraySerializer.java
86.2% <0%> (-10.35%)
7% <0%> (-1%)

...com/alibaba/fastjson/serializer/SerialContext.java
72.91% <0%> (-4.17%)
19% <0%> (ø)

.../fastjson/serializer/PrimitiveArraySerializer.java
95.89% <0%> (-4.11%)
24% <0%> (-1%)

.../alibaba/fastjson/serializer/ObjectArrayCodec.java
82.53% <0%> (-2.39%)
30% <0%> (-1%)

...main/java/com/alibaba/fastjson/util/TypeUtils.java
79.7% <0%> (-0.35%)
638% <0%> (-1%)

...main/java/com/alibaba/fastjson/util/FieldInfo.java
86.2% <0%> (-0.35%)
91% <0%> (ø)

...n/java/com/alibaba/fastjson/util/JavaBeanInfo.java
87.6% <0%> (-0.17%)
207% <0%> (-1%)

...json/parser/deserializer/JavaBeanDeserializer.java
79.24% <0%> (-0.14%)
301% <0%> (ø)

...libaba/fastjson/serializer/JavaBeanSerializer.java
82.85% <0%> (-0.11%)
194% <0%> (+4%)

.../main/java/com/alibaba/fastjson/JSONValidator.java
0% <0%> (ø)
0% <0%> (ø)
:arrow_down:

... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 97ee7b6...9fa2b15. Read the comment docs.