Bump actions

This bumps all our actions to the latest versions to get the set-output deprecation warning out of CI
action-create-release-pr doesn't need a bump because v1 is now 1.4.3
You can see that working without any warnings here
You can also see the entire publish flow working without any warnings here

Hmm. Elsewhere we seem to use the major version of our own actions. I'm curious to know why we used specific versions in these places only.

I'm curious to know why we used specific versions in these places only.

looks like it was my doing and I don't think there was a reason for it?
for MetaMask/action-publish-release we could also just pin that to @v2: https://github.com/MetaMask/action-publish-release/releases/tag/v2


[Bug]: Can't close sidebars on mobile view (iPhone SE)

What happened?
Can't close either sidebar on my iPhone SE
Steps to Reproduce
It can be reproduced from the browser DevTool mobile view
What browsers are you seeing the problem on?
No response
Relevant log output
No response
Screenshots
https://github.com/user-attachments/assets/b96dbe34-51e6-4321-888e-20fb9d916d21
Code of Conduct

[X] I agree to follow this project's Code of Conduct

thanks I know the issue, fixing now


Kill BlockingCollection which is firing timers a lot

The current version of BlockingCollection has a bug where it will sit and fire a timeout on a gate over and over, which is effectively a timer, which sucks.
This PR just upgrades our profile version to a still-compatible-with-basically-everything PCL version, but gets us the standard .NET BlockingCollection. This similarly also :fire:s the ConcurrentDictionary impl we were using

Closed in favor of #367


Changes to safe-links and the TABL

Recent changes to safe-links to move blocked URLs into the TABL have changed the way safe-links functions.  If a user is sent an email that contains a blocked URL, the email itself will be blocked with the email categorized as high-confidence phishing.  The intended recipient will not be able to release the email nor click on any links in the email.  The email section of this page should be re-written to reflect the current functionality of this product.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 8112b7a9-8f21-18b3-03da-f8c02b05f239
Version Independent ID: a441f1d1-5844-ecb9-ba44-95b94714e4e8
Content: Complete Safe Links overview for Microsoft Defender for Office 365 - Office 365
Content Source: microsoft-365/security/office-365-security/safe-links.md
Product: m365-security
Technology: mdo
GitHub Login: @chrisda
Microsoft Alias: chrisda

@idontknowwhattocallit, the current note in the topic says this:

You can now manage block URL entries in the Tenant Allow/Block List. The "Block the following URLs" list is in the process of being deprecated. We'll attempt to migrate existing entries from the "Block the following URLs" list to block URL entries in the Tenant Allow/Block List. Messages containing the blocked URL will be quarantined.

Is this incorrect?
I know that in the Tenant Allow/Block List content says blocked URLs are identified as phishing, not high confidence phishing.
Comments?

They are definitely marked as high-confidence phishing, and the description of how safelinks currently functions for email is now out of date.  Safe Links no longer blocks URLs in emails, it blocks the entire email instead.
"Safe Links immediately checks the URL before opening the website:
If the URL is included in the Block the following URLs list, a [blocked URL warning] opens."

I dont get the question here. Are we talking about email delivery or blocking at time of click?
the time of click blocking information is accurate and safe links is checking Tenant allow/block list as there is no block list in safelinks.
@chrisda  could you please update the email section of safelinks to reflect this?

Email delivery.  Emails are blocked if they contain a URL listed in the TABL.  Microsoft has assured me over the last four months that this is intentional behavior and not a bug.

@dhairyya, I'm having trouble parsing both what needs to be changed/added and where to do it. If you can, please make whatever changes you see fit directly in the topic and @ include me in the comments of the PR.
@idontknowwhattocallit, you, too, are free to directly modify the topic with whatever changes you want. Super-easy instructions are here. @ include me in the comments.

I may be having the same issue the original poster was describing, I'll share our specific scenario. We want to block every link to "sites.google.com/~" by default. But, we have vendors with a link in their email that links to a sites.google.com page.
Since the migration from SafeLinks -> TABL, these emails now get sent to quarantine with the following categorizations:
Quarantine reason: High Confidence Phish
Policy type: Anti-spam policy
Threats None
Blocked by organization policy: Tenant Allow/Block List URL blocked
We do not want these emails blocked, which is why we chose to block sites.google.com in SafeLinks rather than via a mail flow rule (in the before times). Now, we can't receive emails with sites.google.com unless we remove it from our TABL since there is no way to create an exception.
What I would love to see is the ability to add URLs with an "allow" action and have the TABL apply the most specific rule. In example:
Block: sites.google.com/~
Allow: sites.google.com/cheapvendorwebsite/~

@johnwhirsch This is the new behavior, and they've finally clarified their documentation months after changing it.  Support insists this is working as intended, however I did manage to convince them to change the behavior of blocked domains in the TABL to match the behavior of blocked URLs.


God cannot run activities as root user (sudo)?

I have a process that I need to run as root using sudo ( a node.js instance ) and the proces hangs in the "starting" state when trying to run first time. I think this is probably because I'm not being given the option to enter the password when sudo tries to run.
Is there a good way around this or is this an enhancement to pursue?

If you run god as root, you can specify the user/group that spawned processes should run as. Check the docs at http://god.rubyforge.org/ and search for "CHANGING UID/GID FOR PROCESSES"

this is awesome: God cannot run activities as root user (sudo)?   Thats why:

我 06/08/2017 (四)不在k公室，直到 06/14/2017 (三)才返回。
本人休假至14（周三），急事j66595528.
注意: 这是对您消息的自动响应  "Re: [mojombo/god] God cannot run activities
as root user (sudo)? (#22)" 发送日期 6/9/2017 4:23:06 AM.
此通知是此用户离开期间您将收到的唯一通知。


h5py unable to read data

Hello!
I am trying to read dataset (dEchorate_rirs_gzip7.hdf5) using the example notebook notebooks/[Control] check RIRs in dEchorate_rirs.hdf5.
Any idea why rir_dset['rir'] shows the "unable to get group info" error ?
I downloaded the most recent version (2.0) from zenodo.
Thanks!

Thank you very much for the intereset in our dataset. I am currently looking at it.
Indeed, I looks there is an error on the uploaded version and I would like to apologize for it.
On my old python environment, it is working fine, but I am experiencing the same error with a new enviroment. I will soon upload the corrected version.

Dear @kyungyunlee ,
I re-generated the whole dataset. Could you please try it from this link?
https://drive.google.com/drive/folders/1yGTh_BjnVNwDgBsn5mkuW3i4rJIgZwlS?usp=share_link
If there are no issues, I will re-upload everything.
I also updated the notebook in the master branch

Thank you very much for your feedback.
I will soon update the zenodo link.
Please, do not hesitate to contact me here if you find any other problem.


Feature/355 UI Refactor Part 1: Categories List in Settings

Description:
Screen 1 of Ticket 355
Per the new Figma designs, the Categories list in Settings is being refactored for a more user-friendly UI.
Before:

After:
Figma: https://www.figma.com/file/mNrwUygVhTmuWnKNHHkenR/Vocable---Current?node-id=461%3A1293

Clicking the category buttons should take the user to a "Category Edit" screen. This "Category Edit" screen is also out-dated and will be updated in a separate PR as Screen 2 of Ticket 355. Up and down arrows should be functional as it was before.

[ ] Acceptance Criteria satisfied
[ ] Regression Testing

Thanks for the UI updates! Most of the time, up and down buttons behaved as expected, but sometimes last two categories' up and down buttons functioned after 2 clicks, instead of 1 click.
https://user-images.githubusercontent.com/100222793/165847819-3a3834ea-841c-40d8-a1a9-89dfc240c295.mov

Thanks for the fix. Test is verified.
Note: I deleted all preset categories, added 2 custom categories. While adding custom phrases, app crashed. Then I reopened the app, all preset categories were back.


Make address optional for gateway_mgmtapp_probingcustom_apps in mist_site_setting

Address is required, but I would expect it to be optional when protocol is set to http

Hi @zbuchheit , can you test with v0.1.29?

with the following, I get an error
resource "mist_site_setting" "site_one" {
  site_id = "redacted"
  ap_updown_threshold     = 5
  device_updown_threshold = 5
  gateway_mgmt = {
    app_probing = {
      custom_apps = [ {
        hostname = ["example.com"]
        url = "example.com"
        protocol = "http"
      } ]
    }
  }
}

mist_site_setting.site_one: Creating...
╷
│ Error: Value Conversion Error
│
│   with mist_site_setting.site_one,
│   on main.tf line 10, in resource "mist_site_setting" "site_one":
│   10: resource "mist_site_setting" "site_one" {
│
│ An unexpected error was encountered while verifying an attribute value matched its
│ expected type to prevent unexpected behavior or panics. This is always an error in
│ the provider. Please report the following to the provider developer:
│
│ Expected framework type from provider logic: VlansType / underlying type:
│ tftypes.Object["custom_test_urls":tftypes.List[tftypes.String],
│ "disabled":tftypes.Bool, "vlan_ids":tftypes.List[tftypes.String]]
│ Received framework type from provider logic: CustomAppsType / underlying type:
│ tftypes.Object["address":tftypes.String, "app_type":tftypes.String,
│ "hostname":tftypes.List[tftypes.String], "name":tftypes.String,
│ "network":tftypes.String, "protocol":tftypes.String, "url":tftypes.String,
│ "vrf":tftypes.String]
│ Path: [0]
╵
╷
│ Error: Invalid Object Attribute Type
│
│   with mist_site_setting.site_one,
│   on main.tf line 10, in resource "mist_site_setting" "site_one":
│   10: resource "mist_site_setting" "site_one" {
│
│ While creating a Object value, an invalid attribute value was detected. A Object
│ must use a matching attribute type for the value. This is always an issue with the
│ provider and should be reported to the provider developers.
│
│ Object Attribute Name (custom_apps) Expected Type: types.ListType[CustomAppsType]
│ Object Attribute Name (custom_apps) Given Type: types.ListType[VlansType]

can you test with v0.1.31?

looks like that fixed it. Thanks!


Project: import epub to onenote

Project name
onenote-converter
Description
import epub to onenote as a new notebootk, each page as a page in notebook
Repo URL
https://github.com/lostsquirrel/onenote-converter
Team members
lostsquirrel

Hey @lostsquirrel. Thank you for your submission. In this hackathon we're building apps using .NET and the Microsoft Graph .NET SDK. It seems like your project is built using Python. Would you be willing to convert your project to .NET to participate in the hackathon and make chance for one of prizes?

sorry, I am not familiar with .NET developing, I'll close it


Direct connect to Airthings Wave Plus

Arithings Wave Plus (and other sensors) has ability to connect via bluetooth and pull all of the metrics from it without going into the cloud.
For example Airthings has repo that shows this ability.
I think this ability can be added to the package by reimplementaton of the package above into JS/TS.
Could you consider adding such functionality to the package? (I'm willing to help with it)

There are a few existing Homebridge plugins that target Airthings Wave devices over Bluetooth. Have you tried any of these?
https://www.npmjs.com/search?q=keywords%3Ahomebridge-plugin airthings

@michaelahern I didn't do broader search and that's my fault. Thank you for pointing to the package. So I think this issue is pointless.


ToParentBlockJoinQuery Explain Support Score Mode

Description
Today, explain() returns the max score regardless of the value of toParentBlockJoin as documented in #12204. This is a simple PoC to address the issue.
Please note: I still need to write three more tests. I'm toying around with a few approaches and trying to be mindful of opportunity costs and readability given the size of the project. I am curious if anyone has any thoughts around parameterized tests vs individual methods for each score mode other than None, which was already tested.

ok @mkhludnev I made the changes with your blessing and guidance. Thanks for laying groundwork, and for the talk at Buzzwords '15. It was helpful.

WDYT, @MarcusSorealheis ?


[Beta] Add note about translations degrading to english

cc/ @QuincyLarson

Our community has translated many of our challenges. If we don't have a translation for a challenge, it will be in English.

@QuincyLarson As per the discussion in #11469 please can you expand on the issue and what the required outcome would be

Instead of a long message i'd like to see a simple toast with a short message and a link as the call to action.
No translation found <link>info</link>
We've moved away from alerts and we don't want this message to be as intrusive as an alert as it will get tiring soon.

@QuincyLarson @BerkeleyTrue, is there a consensus? Personally I like the idea of a toast, the Alert IMO is very intrusive on the UI.
If we got the toast route, what about We have not yet translated this challenge into {user lang}. <link>More info</link>

Yes, we should stick to toasts where possible.
We don't need to mention the language.
We have not translated this challenge yet.

Just had a quick look over Toasts.jsx and it seems that the onClick event handler is tied into dispatch.
What is the best way of doing a target='_blank' link to the forum through actions? Would it have to be an epic?

We'll need to change the set up to accept links

Small change in the comment to make it more conversational?

We haven't translated this challenge yet.

@erictleung yes - I agree. That reads much better and is unambiguous. I agree with @BerkeleyTrue about wanting to keep these as short as possible, and I think your copy is a good happy medium.

PR refactored to use toasts :+1:


Photo's taken on iPhone 6S Plus are too large to be sent/attached.

Error:
Unable to upload file. File is too large.
Sending images photo library, taken on previous phones or different camera's is no problem.
Turning live photo's off, or using an app like Lively (selecting one frame to send/share) works fine.
iPhone 6S Plus / iOS 9.2.1

Thanks for bug report @jaapvdv. We are investigating. Ticket can be tracked in JIRA.


Modify organization-selector image

This PR replaces the organization-selector image by masking certain areas.

I think we need to port this fix to 4.0.0 branch in order to add this to 4.0.0 docs? @Mariangela

ported the change to 4.0.0 https://github.com/wso2/docs-apim/pull/3866


ics20: decrease token supply in withdrawal of native assets

This addresses the finding in #3920

I'm not sure this is safe. The token supply numbers are also used by the staking component right?
I think the problem is the existence of the shielded pool's value tracking mechanism at all. We should have a design meeting about what to do here.

Closing this in favor of having component-scoped supply tracking. Thanks for your work on this, the original ticket should have been clearer.


Compile python requirements

Automated changes by create-pull-request GitHub action

sqlfluff now removes (for fix) or errors (for lint) on unnecessary quoted columns

Okay - sqlfluff also is broken - these fixes are not valid sql anymore. Quotes are still needed when a column name begins with a number. I'll file a bug for sqlfluff, and pin the version to 3.1.x for now

Made a PR in sqlfluff
https://github.com/sqlfluff/sqlfluff/pull/6247
None of these changes seem urgent, and these sqlfluff fixes obviously have some erroneous ones included. Just going to close this rather than pin sqlfluff, and maybe we wait until it's fixed. If they don't seem to have momentum on a patch RC by end of the week, I might pin


Render webapp from env URL

@QilongTang do you think we should add the URL in the env file by default, currently i have removed it, so anyone running the webapp alone will have to add it before running the app.

@QilongTang do you think we should add the URL in the env file by default, currently i have removed it, so anyone running the webapp alone will have to add it before running the app.

I would add it

@QilongTang do you think we should add the URL in the env file by default, currently i have removed it, so anyone running the webapp alone will have to add it before running the app.

I would add it

We can also keep it as GitHub Secrets

@QilongTang do you think we should add the URL in the env file by default, currently i have removed it, so anyone running the webapp alone will have to add it before running the app.

I would add it

We can also keep it as GitHub Secrets

Do you mean access using RestAPI for Secrets? AFAIK, devs won't be able to access Github Secrets locally as easily as the current way. Also, this endpoint probably will not contain sensitive information moving forward so we should be good for now. We do leverage Github Secret for the npm package publish workflow


Install GIT but not identifying the version

1 Errors one GIT version error
Now this problem I attach the image

I also need to remove the ad code ..
Thanks

I compiled and it run now ,  Your code well, I am working on it to make it more reliable ..
Thanks

Great to know you like to contribute. If you think this issue is solved then you can close it.
Thanks


Cannot get latest version: module contains a go.mod file, so module path should be github.com/zerodhatech/gokiteconnect/v3

Background
The github.com/zerodhatech/gokiteconnect uses Go modules and the current release stream version is v3. It must comply with the specification of "Releasing Modules for v2 or higher" available in the Modules documentation and enforced since the most recent versions of Go. The module path should be “github.com/zerodhatech/gokiteconnect/v3”. Quoting the specification:

A package that has opted in to modules must include the major version in the import path to import any v2+ modules
To preserve import compatibility, the go command requires that modules with major version v2 or later use a module path with that major version as the final element. For example, version v2.0.0 of example.com/m must instead use module path example.com/m/v2.
https://github.com/golang/go/wiki/Modules#releasing-modules-v2-or-higher

Using go get (under go1.13 and go1.14) does not work for<EMAIL_ADDRESS>.
I consider this a pretty high severity issue since not doing so prevents any other Go project also using Go Modules to properly require zerodhatech/gokiteconnect on version v3.1.0 as a dependency, resulting in errors like:
invalid version: module contains a go.mod file, so major version must be compatible: should be v0 or v1, not v3

SO anyone using Go modules will not be able to easily use any newer version of zerodhatech/gokiteconnect
Steps to Reproduce
Under a project making use of Go modules, run go get targeting any version >= v3.0.0 of the zerodhatech/gokiteconnect:
$ go get<EMAIL_ADDRESS>go get<EMAIL_ADDRESS><EMAIL_ADDRESS>invalid version: module contains a go.mod file, so major version must be compatible: should be v0 or v1, not v3

Solution
1.  Kill the go.mod files.
This would push them back to not being managed by Go modules (instead of incorrectly using Go modules). Importing specific versions would work, but they'd receive the +incompatible prefix and would need to be manually upgraded.
Probably best option short-term -- better to not use Go modules than use it incorrectly.
Also, best option for older branches/versions that aren't maintained.
2.  Make breaking changes
Patch the go.mod file to declare the module as github.com/zerodhatech/gokiteconnect/v3 as per the specs. AND adjust all internal imports.
There are two alternative mechanisms to release a v2 or higher module. Note that with both techniques, the new module release becomes available to consumers when the module author pushes the new tags. Using the example of creating a v3.0.0 release, the two options are:

Major branch: Update the go.mod file to include a /v3 at the end of the module path in the module directive (e.g., module github.com/my/module/v3). Update import statements within the module to also use /v3 (e.g., import "github.com/my/module/v3/mypkg"). Tag the release with v3.0.0.

Go versions 1.9.7+, 1.10.3+, and 1.11 are able to properly consume and build a v2+ module created using this approach without requiring updates to consumer code that has not yet opted in to modules (as described in the "Semantic Import Versioning" section above).
A community tool github.com/marwan-at-work/mod helps automate this procedure. See the repository or the community tooling FAQ below for an overview.
To avoid confusion with this approach, consider putting the v3.. commits for the module on a separate v3 branch.
Note: creating a new branch is not required. If instead you have been previously releasing on master and would prefer to tag v3.0.0 on master, that is a viable option. (However, be aware that introducing an incompatible API change in master can cause issues for non-modules users who issue a go get -u given the go tool is not aware of semver prior to Go 1.11 or when module mode is not enabled in Go 1.11+).
Pre-existing dependency management solutions such as dep currently can have problems consuming a v2+ module created in this way. See for example dep#1962.

Major subdirectory: Create a new v3 subdirectory (e.g., my/module/v3) and place a new go.mod file in that subdirectory. The module path must end with /v3. Copy or move the code into the v3 subdirectory. Update import statements within the module to also use /v3 (e.g., import "github.com/my/module/v3/mypkg"). Tag the release with v3.0.0.

This provides greater backwards-compatibility. In particular, Go versions older than 1.9.7 and 1.10.3 are also able to properly consume and build a v2+ module created using this approach.
A more sophisticated approach here could exploit type aliases (introduced in Go 1.9) and forwarding shims between major versions residing in different subdirectories. This can provide additional compatibility and allow one major version to be implemented in terms of another major version but would entail more work for a module author. An in-progress tool to automate this is goforward. Please see here for more details and rationale, along with a functioning initial version of goforward.
Pre-existing dependency management solutions such as dep should be able to consume a v2+ module created in this way.

3.  Major version bump / repository change
Leave v3 as a dead version and bump to v4 with the path changes.
4.  Remain unchanged
Don’t want to fix it. Not intended to be used as a library and does not make any guarantees about the API.
5.  Let the user change
The standard rule of go modules conflicts with your development mode. So you can’t comply with the specification of "Releasing Modules for v2 or higher" available in the Modules documentation.
Regardless, since it's against one of the design choices of Go, it'll be a bit of a hack. Instead of go get github.com/zerodhatech/gokiteconnect@version-tag, the install procedure would be something like:
(1)Search for the tag you want (in browser)
(2)Get the commit hash for the tag you want
(3)Run go get github.com/zerodhatech/gokiteconnect@commit-hash
(4)Edit the go.mod file to put a comment about which version you actually used
This way seems good, but if the users try to use go get -u, they will get the old version and break again.
References

https://github.com/golang/go/wiki/Modules#semantic-import-versioning
https://golang.org/cmd/go/#hdr-Module_compatibility_and_semantic_versioning
https://github.com/golang/go/wiki/Modules#releasing-modules-v2-or-higher

@VarunBatraIT  @rhnvrm  Could you help me review this issue? Thx :p

@rhnvrm Thanks for your feedback.

Close this issue via commit eba0269

Close this issue via commit eba0269


Add "concepts" to kiwi.toml

Just sketching out some thoughts for tomorrow:

A concept is a list of components that, when used together, result in some behaviour (likely driven by a host system or the module)
These components can have default values
The macro will generate a function to create a Components containing all of the specified components with their defaults; all components that don't have defaults will be made into parameters
The macro will generate a function to check if a specific entity abides by a concept
For now, you will only be able to use components that you define.

The first extension will be to support core components; I'm not really sure how to do this, given that the macro won't have access to kiwi_api's kiwi.toml. Could copy it in or see if it's possible to pass it in somehow.
Once #23 is in, it should hopefully be a fairly natural extension to support that, too

You can extend other concepts, but the same caveat about being in the same toml applies
These are purely for convenience and do not exist in the ECS proper - they're like TypeScript interfaces

Here's a rough idea of how that might look:
[concepts.transformable]
name = "Transformable"
description = "Can be translated, rotated and scaled."
components = {
  "core::transform::translation" = [0, 0, 0],
  "core::transform::rotation" = [0, 0, 0, 1],
  "core::transform::scale" = [1, 1, 1],
}

[concepts.sphere]
name = "Sphere"
description = "A primitive sphere."
extends = ["transformable"]
components = {
  "core::primitives::sphere_radius": 0.5,
  "core::primitives::sphere_sectors": 36,
  "core::primitives::sphere_stacks": 18
}

[concepts.colored_sphere]
name = "Colored Sphere"
description = "A sphere with some color!"
extends = ["sphere"]
components = { "core::rendering::color" = {} }

generates the following:
/// Makes a Transformable (Can be translated, rotated and scaled.)
pub fn make_transformable() -> Components {
  Components::new()
    .with(translation(), vec3(0.0, 0.0, 0.0))
    .with(rotation(), quat(0.0, 0.0, 0.0, 1.0))
    .with(scale(), vec3(1.0, 1.0, 1.0))
}

/// Checks if the entity is a Transformable (Can be translated, rotated and scaled.)
pub fn is_transformable(id: EntityId) -> bool {
  entity::has_components(id, [translation(), rotation(), scale()]);
}

/// Makes a Sphere (A primitive sphere.)
pub fn make_sphere() -> Components {
  make_transformable()
    .with(sphere_radius(), 0.5)
    .with(sphere_sectors(), 36)
    .with(sphere_stacks(), 18)
}

/// Checks if the entity is a Sphere (A primitive sphere.)
pub fn is_sphere(id: EntityId) -> bool {
  is_transformable(id) && entity::has_components(id, [sphere_radius(), sphere_sectors(), sphere_stacks()]);
}

/// Makes a Colored Sphere (A sphere with some color!)
pub fn make_colored_sphere(color_value: Vec4) -> Components {
  make_sphere()
    .with(color(), color_value)
}

/// Checks if the entity is a Colored Sphere (A sphere with some color!)
pub fn is_colored_sphere(id: EntityId) -> bool {
  is_sphere(id) && entity::has_components(id, [color()]);
}


[conventions/angular] Make : after BREAKING CHANGE optional

Hey,
I've already run into this several times. I usually do breaking change commits like this
BREAKING CHANGE

Before

var Server = require('kazana-server')

    var kazana = new Server('path/to/kazana-app-or-plugin')
    kazana.start(function () {
      console.log('Server running at %s', kazana.info.uri)
    })

Now

    var startKazanaServer = require('kazana-server')

    startKazanaServer('path/to/kazana-app-or-plugin', /*options ,*/ function (error, server) {
      if (error) {
        throw error
      }
      console.log('Server running at %s', kazana.info.uri)
    })

I tend to forget the : because I do line breaks instead. Any chance we could make the : optional?
This is causing quite some headaches for me, because I use semantic-release everywhere, and end up with minor releases, but with breaking changes :(
I'm happy to send a PR for that, just point me to the right things on how to do it.
Thanks :bouquet:

+1 same here

According to angular's commit guide the : is not optional. If you think it's not reasonable you should probably open an issue there.

@stevemao thanks! Could you please point me to a place I shall create the issue? I don't know which repository that is

both https://github.com/angular/angular and https://github.com/angular/angular.js
ping me when they decide to take your advice.

You can, however, supply your customised parserOpts to achieve this :)


Sort field in Hit deserializer should handle null events

Signed-off-by: Rene Cordier<EMAIL_ADDRESS>Description
Adds a new StringOrNullDeserializer to allow to handle the null events with strings (like with Int or Double), which then allows us to use this for the sort field in Hit deserializer, thus getting the null event case being handled in the array deserializer.
Would like to add I built it locally and tested on my project and it seems to solve the issue for sorts on my end.
Let me know if this is good for you guys :)
Issues Resolved
Attempt to solve #158
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Are there other instances where we should be using this?

Are there other instances where we should be using this?

No idea to be honest, the only issue I had so far was with sorts. Easy to fix later though if it's necessary for other instances IMO

Any ETA of this fix in a public release @dblcok ?

Any ETA of this fix in a public release @dblcok ?

We release clients in sync with OpenSearch usually, I don't have any exact ETA though. @CEHENKLE maybe can comment on something more precise?


Why supervisor is not showing for some officers?

Bug: why supervisor is not showing for some officers like “Alijah OConnor (Id = 16886)??
Steps to reproduce:

Go to the  table and search for id = 16886
Note that this row has supervisor_officer_number = 14120
Find officer id = 14120

You will see there's no data for id = 14120, so this is not a bug. It  should be resolved with a data update.

I investigated a few cases like the one above and it turns out the db does not have a supervisor_officer_number, so it's not an UI issue. Hopefully this will be resolved with the new officer table


mvnd maven plugin

Is it possible to develop a mvnd maven plugin, which can be used after importing it in pom.xml

Could you be a bit more specific, I don't really understand the question.

similar maven-clean-plugin

ide can control process

If you want your IDE to use mvnd instead of mvn, then it cannot be reached by writing a plugin. You may still want to ask your IDE to implement such an option via their issue tracker.


add Contact us to header section

Contact us page takes user input like YOUR NAME and YOUR EMAIL and YOUR MESSAGE which can understand what user can saying

Solution Proposal:
I plan to add a "Contact Us" link to the header section (#39) to improve user navigation.
Plan:
Add a visible "Contact Us" link to the header, matching the site’s design.
Ensure it’s responsive on all devices (mobile, tablet, desktop).
Make sure the link smoothly scrolls or redirects to the contact section.
please assign this to me

@rutikakengal, @sambedan1 thank you for your suggestion. We appreciate your message. Once PR no. #43 is merged, we will continue to review this PR. The main issue is major and helpful to others the folder structure.

We can add it but use backend i.e database to store data

it should take responses and send them to the database as well.

i want to work on this issue please assign me


Document sync approach using YouTube API: seekTo

The cards will move by themselves, according to the linked PR status. You shouldn't need to move them manually.


Add tiled simple mult example

This PR adds a simple example that explores a tiled/double-buffered multiplication flow.
I'm planning on adding some extra scripts later for testing with more data and with different tile sizes.

Just an update, I still need time to fix this haha this bug is so difficult to fix because my HW sims (trying my best to replicate the scenario) shows it works okay.
But what I found is that on the 2nd or 3rd re-execution of the accelerator, it suddenly executes by itself continuously. It does not stop :( so I am unsure if there is a weird bug in it from the MAC engine itself oof.

Basically I see this!!!

Heeeyyy @JosseVanDelm!
I found the bug and it's an HWPE problem. Basically, (1) the done signal was not deasserted which should've been like you saw. The fix is to do a software clear: csr_write(0x3c5,0) it needs to be 0 because according to the hwpe_ctrl_slave this clears the done signal as well as all other register files of the HWPE. If we do a clear we see:

(2) There's a second problem though we need to make sure the clear is done in 3 cycles, hence after doing a clear we need to wait for 3 cycles for the clear to be complete. Therefore add 3 cycles of nop 😢 . Why? Referring to the same lines of code of the hwpe_ctrl_slave that specific implementation causes it to clear in 3 cycles! Here is a zoomed in view:

If we do a CSR write within this cycles, it won't push through because this forces the
Conclusion:

Make sure to add the clear csr_write(0x3c5,0)
Make sure to add at least 3 nop instructions after this write to ensure that writes can go through and not be cleared.

I will test another round just to make sure my eyes don't deceive me.
P.S. I think it's better I make my own MAC engine soon. The concept is easy anyway and I can add features like 2D strides so we can do that "per bank" mechanism. I highly recommend replacing this MAC soon. I think it wouldn't hurt for our needs.

@JosseVanDelm also! Add the test to the snitch_cluster/target/snitch_cluster/sw/Makefile subdirectory list and the snitch_cluster/target/snitch_cluster/sw/tests/snax-mac-run.yml  file 😄 so that it's part of the test suite!

@rgantonio thanks for your thorough review. I was waiting for someone to notice that this example was not tested in CI :nerd_face:

@JosseVanDelm will you still do something with what @asyms requested? So you can push this into the main already :)

@JosseVanDelm I am adding the quick datagen to this PR since it's a tiny thing anyway 😄

@JosseVanDelm This datagen is like the axpy one, but I tried to match it with our data set before. To invoke we do:
python datagen.py --length 20
Something like that 😄

I've noticed that not all sizes (e.g. length=289 and tile_size=17 don't) work, but a standard size of 512 with tile sizes of 32 should already work in this example
New sizes can be made with:
make -C sw/apps/snax-mac-tiled/ clean
make -C sw/apps/snax-mac-tiled/ all LENGTH=512 TILE_SIZE=32

Work next is on a collection script for plotting those results somewhere and on inserting performance counters in the right way.


panic: runtime error: slice bounds out of range

Hello,
I am trying to write an resized image and I am getting this panic:
panic: runtime error: slice bounds out of range [::-316]

goroutine 1 [running]:
github.com/HugoSmits86/nativewebp.flatten({0x541828, 0xc00012c140})
        github.com/HugoSmits86/nativewebp@v0.9.0/writer.go:231 +0x1b2
github.com/HugoSmits86/nativewebp.WriteBitStreamData(0xc00011edb0, {0x541828, 0xc00012c140}, 0x4, {0x1, 0x0, 0x1, 0x0})
        github.com/HugoSmits86/nativewebp@v0.9.0/writer.go:98 +0x3d
github.com/HugoSmits86/nativewebp.Encode({0x540fe8, 0xc000128028}, {0x5416a8, 0xc00014e100})
        github.com/HugoSmits86/nativewebp@v0.9.0/writer.go:51 +0x27e
main.main()
        smartcrop/main.go:47 +0x4b7

I'm away from my laptop right now, but I have a good hunch about what might be causing the issue and will look into it tomorrow. In the meantime, could you let me know which package or code you used to resize the image? That way, I can test it directly when I get back. Thanks!


Update README links from bitbucket to github

I was having a hard time navigating the docs with these broken links, so just thought I'd try to leave this better than I found it. 😄

Although this was merged more than a year ago, the latest version on npm (where probably more users read the documentation) still has the old, broken link.


Equivalent of bash set -e

I asked this question on twitter and it was suggested I post here.
Many people consider it good practice to start a bash script.
#! /bin/bash
set -eu

set -e tells the script to stop on first error
set -u tells the script to not allow undeclared variables
Although not everyone agrees
I think set -u and Set-StrictMode -Version 1.0 are equivalent.
I just wrote a set of Powershell scripts for managing an elasticsearch server. Then a few top-level scripts to tie them together.
It would have been really useful to be able to write something equivalent to...
set -e

$someValue = .\server-task-1.ps1
.\server-task-2.ps1 -using $someValue
.\task-that-requires-everything-else-suceeded.ps1

... but I couldn't find how to and ended up with something more like...

$someValue = .\server-task-1.ps1
if ($LastExitCode -ne 0) {
    exit $LastExitCode
}

.\server-task-2.ps1  -using $someValue
if ($LastExitCode -ne 0) {
    exit $LastExitCode
}

.\task-that-requires-everything-else-suceeded.ps1
if ($LastExitCode -ne 0) {
    exit $LastExitCode
}

Apologies if this is already possible and I've missed it...

$erroractionpreference = "stop" is similar to set -e, except it only works against cmdlets and not native commands

As someone fresh to Powershell that's a confusing distinction.
So would $erroractionpreference = "stop" work for my example above..?
i.e.
$erroractionpreference = "stop"

$someValue = .\server-task-1.ps1

# does not run the next two commands if server-task-1.ps1 exits with code != 0
.\server-task-2.ps1 -using $someValue
.\task-that-requires-everything-else-suceeded.ps1

but
$erroractionpreference = "stop"

$someValue = .\server-task-1.exe

# does run the next two commands _even though_ server-task-1.exe exits with code != 0
.\server-task-2.ps1 -using $someValue
.\task-that-requires-everything-else-suceeded.ps1

$erroractionpreference = "stop" only works if Write-Error is called (such as an exception is raised).  It doesn't do any checks against $lastexitcode.  We can certainly look into adding another preference variable to throw an exception if $lastexitcode != 0.

Would probably want to throw the exception only in a context where Powershell also sets $? to false as a result.
Throwing an exception in other situations where lastexitcode != 0 would not give a result equivalent to "set -e" in bash.
https://www.gnu.org/software/bash/manual/html_node/The-Set-Builtin.html

Hi, i've done some work on this, can I ask for an assignment?

@mopadden consider it assigned, GitHub doesn't allow assigning to people without write access

Assigning to @daxian-dbw who's assigned to the PR so no one else duplicates this work

Anyone who's interested in this should review the RFC: https://github.com/PowerShell/PowerShell-RFC/pull/88/files

+1, very inconvenient to check $LastExitCode, especially when using PS for build scripts with multiple steps...

Since this is the first google result, linking the most recent thread on this RFC that I can find for anyone interested in implementing it https://github.com/PowerShell/PowerShell-RFC/pull/277

The PR that implements the RFC was already merged as an experimental feature: #15897
So, closing this issue.

Is the equivalent of set -eu then:
Set-StrictMode -Version Latest
\$ErrorActionPreference = "Stop"
Enable-ExperimentalFeature PSNativeCommandErrorActionPreference
\$PSNativeCommandUseErrorActionPreference = \$true


Resolve name shadowing between imports and params

If the interface to be mocked requires an import that is shadowed by a
param with the same name, it's unlikely to be a problem for the upstream
interface (and thus go undetected), but it causes moq to generate
invalid code.
Example in the wild:
https://github.com/kubernetes/helm/blob/534193640179fe3c9ffc3012a7bc4e8b23fbe832/pkg/helm/interface.go#L28 (the conflict is between the chart param and the chart import)

What kind of code does moq generate here?

It only changes anything if it detects a conflict with an import name, and even then it only changes the generated local name of the argument, not the interface on the exposed mock (since those are exported, the names don't conflict)
package main

import "context"

type Thing interface {
        WithConflict(context context.Context)
        NoConflict(ctx context.Context)
}

$ ./moq.fbe042a -out before . Thing
$ ./moq.2e9ae34 -out after . Thing
$ diff -u before after

--- before      2018-07-24 12:42:55.253016061 -0700
+++ after       2018-07-24 12:43:06.617187737 -0700
@@ -22,7 +22,7 @@
 //             NoConflictFunc: func(ctx context.Context)  {
 //                    panic("TODO: mock out the NoConflict method")
 //             },
-//             WithConflictFunc: func(context context.Context)  {
+//             WithConflictFunc: func(contextMoqParam context.Context)  {
 //                    panic("TODO: mock out the WithConflict method")
 //             },
 //         }
@@ -36,7 +36,7 @@
        NoConflictFunc func(ctx context.Context)

        // WithConflictFunc mocks the WithConflict method.
-       WithConflictFunc func(context context.Context)
+       WithConflictFunc func(contextMoqParam context.Context)

        // calls tracks calls to the methods.
        calls struct {
@@ -85,19 +85,19 @@
 }

 // WithConflict calls WithConflictFunc.
-func (mock *ThingMock) WithConflict(context context.Context) {
+func (mock *ThingMock) WithConflict(contextMoqParam context.Context) {
        if mock.WithConflictFunc == nil {
                panic("ThingMock.WithConflictFunc: method is nil but Thing.WithConflict was just called")
        }
        callInfo := struct {
                Context context.Context
        }{
-               Context: context,
+               Context: contextMoqParam,
        }
        lockThingMockWithConflict.Lock()
        mock.calls.WithConflict = append(mock.calls.WithConflict, callInfo)
        lockThingMockWithConflict.Unlock()
-       mock.WithConflictFunc(context)
+       mock.WithConflictFunc(contextMoqParam)
 }

 // WithConflictCalls gets all the calls that were made to WithConflict.

The before copy in this example fails to compile because the context arg shadows the context import, so the context.Context in the callInfo struct decl blows up; this code makes sure that in that case, the context arg is deconflicted to there's no shadowing

Finally got back to this again, with a test this time.

@matryer resolved the conflict, can you give this another look?

Hey @novas0x2a thanks for your work on this. If the situations occurs without this PR, what does the user need to do to fix it? Is it as simple as just changing the variable name from context to ctx or is it more complex?

Yeah, a parameter rename would resolve it. The main issue is when the param is in another project the user doesn't control (that's what motivated the change :))

Ping @matryer (and maybe @sudo-suhas)?

Hey @novas0x2a, I have been a bit occupied with professional and personal things. I will get around to this, please give me some time 🙏

@sudo-suhas updated my branch to fix the conflicts!

We're about to hit the 2 year anniversary of this PR. Am I wasting my time resolving the conflicts on this?

Hey @novas0x2a - since it's so easy for the programmer to solve this problem, I don't think it's worth the complexity to have the moq tool do this. What do you think?
I don't want to undermine the effort that's gone into this, and I have not experienced this issue myself (so I don't quite have a grasp for how frustrating this could be) which is why I think we've been reluctant to make any progress on this PR.

since it's so easy for the programmer to solve this problem, I don't think it's worth the complexity to have the moq tool do this. What do you think?

I'm not sure what you mean "so easy"- in order to solve this problem, I had to either fork moq or helm. There's no workaround if I don't control the upstream.

Oh right, if you don’t control the code. Yeah good point.
On Thu, 17 Sep 2020 at 17:32, Mike Lundy<EMAIL_ADDRESS>wrote:

since it's so easy for the programmer to solve this problem, I don't think
it's worth the complexity to have the moq tool do this. What do you think?
I'm not sure what you mean "so easy"- in order to solve this problem, I
had to either fork moq or helm. There's no workaround if I don't control
the upstream.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/matryer/moq/pull/63#issuecomment-694352439, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AAAY2G5HUB7HVVMRKUD3MSDSGI2ZLANCNFSM4FJ6JFSQ
.


Refactor WormholeProvider

If we are getting rid of worker, we need to cleanup in gulpfile.js and Dockerfile as there are some tasks defined.

@JustusFT I have issue, that I cannot download file, when I use url on receiver side: http://localhost:8080/#6-backwater-southward.
If I enter code manually, download works.

One more error, not handled case when  Nameplate is unclaimed: 14.

After discussion with @JustusFT we agreed to close this PR, as it requires more dev and testing effort to finalise, however with dilation, we might still need to get back to worker. Closing PR, but keeping branch for future work.

Is there ticket describing what this PR was / is trying to achieve (so that when/if we do revisit it, some context can be obtained without reading all ~2000 LoC of the PR)?


refactor: pulled logic from ChainManager.blocks.range to DefaultQueryProvider

What I did
Pull the range longic from ChainManager.blocks.range and place that functionality in DefaultQueryProvider
fixes: #595
How I did it
Grabbed the functionality from ChainManager.blocks.range (which was in BlockContainer) and pulled it to DefaultQueryProvider
How to verify it
Currently, the only tests that I have ran are:
ape console

a = accounts.test_accounts[0]
a.transfer(a, 100)
a.transfer(a, 100)
a.transfer(a, 100)
chain.blocks.query("number", "timestamp")

   number   timestamp  size
0       0<PHONE_NUMBER>   517
1       1<PHONE_NUMBER>   627
2       2<PHONE_NUMBER>   627

I also ran pytest test_basic_query(), which passed
Checklist

[ ] All changes are completed
[ ] New test cases have been added
[ ] Documentation has been updated

I can return that range function to ChainManager
then add this:
    def get_blocks(self, start_or_stop: int, stop: Optional[int] = None) -> Iterator[BlockAPI]:
        return self.chain_manager.blocks.range(start_or_stop, stop)

I need help fixing chain.BlockContainer.range
I'm not sure why I can't call the query.get_blocks function at the moment, figured other eyes would quicken this up

I need help fixing chain.BlockContainer.range
Should I move that get_blocks function from DefaultQueryProvider to QueryManager? Or import DefaultQueryProvider?

No, so the functions you are replacing under BlockContainer should delegated to the QueryManager.query(query=BlockQuery(...)) method, and then take the result and serialize it back to the BlockAPI subclass that the current ecosystem is using

Just a heads up, I had to force a push in order for the checks to run. GitHub wasn't down


What's the id of debugProtocol.Breakpoint when the reason is removed?

When the breakpoint command can't be solved with my debuggers, I want to remove it from vscode UI(That is to say, remove the red dot on vscode editor automatically). So i try to use the BreakpointEvent with reason removed .  But it really confused me how to set the id of the id of Breakpoint. Does it increase by one according to the click event on vsocde UI or returned from my debugger please? Hope for your help. Thanks a lot.

Seen from https://github.com/microsoft/vscode-mock-debug/blob/85f04c5ae88a592098ce64008872500026d2a691/src/mockRuntime.ts#L216 , it seems like the id is just a increasing number? Is there any misunderstanding here please? Hope for your help. Thanks a lot.

When the DA creates a breakpoint based on the setBreakpoints request, it can optionally give the new breakpoint an ID (and return it from the setBreakpoints request). The client (e.g. VS Code) will store the ID without interpreting it. Later when the breakpoint should be removed, the DA must use the same ID.

In function  protected setBreakPointsRequest(response: DebugProtocol.SetBreakpointsResponse, args: DebugProtocol.SetBreakpointsArguments)
Should i send break-insert command to my debugger according to args (Which contains the breakpoints added in the client ,eg vscode ), get theresult (returned from debugger)  and add a id to the result, then send the response to vscode . After that the id will be stored and can use when removed?  Does the id will worked only after sendResponse?  In my case, the addBreakPoint may result error, If this happends, i want to remove the breakpoint on the vsocde UI.
function setBreakPointsRequest(response: DebugProtocol.SetBreakpointsResponse, args: DebugProtocol.SetBreakpointsArguments): void {

	const cb = (() => {
		this.debugReady = true;
		let path = args.source.path;

		const all = args.breakpoints.map(brk => {
			return this.myDebugger.addBreakPoint({ file: path, line: brk.line, condition: brk.condition, countCondition: brk.hitCondition });
		});
		Promise.all(all).then(brkpoints => {
			const finalBrks = [];
			brkpoints.forEach(brkp => {
				const bt = new DebugAdapter.Breakpoint(true, brkp[1].line);
				bt.id = this.count++; // give it a unique id
				finalBrks.push(bt);
			});
			response.body = {
				breakpoints: finalBrks
			};
			this.sendResponse(response); // Does the id will worked only after sendResponse?

		}, msg => {
			this.sendErrorResponse(response, 9, msg.toString());
		});

	}).bind(this);
	if (this.debugReady)
		cb();
	else
		this.myDebugger.once("debug-ready", cb);
}

When the DA creates a breakpoint based on the setBreakpoints request, it can optionally give the new breakpoint an ID (and return it from the setBreakpoints request). The client (e.g. VS Code) will store the ID without interpreting it. Later when the breakpoint should be removed, the DA must use the same ID.
Mock Debug shows how to use "ID" with the "breakpoint" request.

Does it mean the vscode UI will update according to the SetBreakpointsResponse  ? But in my experiment, the breakpoint on the vscode UI won't be removed even i delete some elements in SetBreakpointsResponse . Could you please explain which is the breakpoint send to vscode UI if possible? Thanks a lot.

My goal is send the breakpoint info to my debugger in setBreakPointsRequest and set the breakpoint in debugger. But if the debugger fails to deal with a breakpoint , remove the breakpoint (the red dot) on the vscode UI.
In my understanding, i should deal with the breakpoint and add a id to the breakpoint in the  DebugProtocol.SetBreakpointsArguments even if the breakpoint fails to set in my debugger. Then add it into DebugProtocol.SetBreakpointsResponse and send to vscode UI.
If the breakpoint fails to set, remove it using BreakpointEvent with reason removed.
Is there any problem with my understanding please? Thanks a lot.

Got it. Thanks a lot.


View and Select existing Applicant Profile

As an IAO analyst
I want view and select an existing applicant profile
so that I can link the profile to a new request

Assumptions & Scope
What are the assumptions for this story?
This story is only for the selection of an applicant profile when the applicant only has one profile (e.g. category) associated with the name of the individual.
View and selection will be a continuation of the search in story for applicant profiles in #4758
If an applicant has a new entered new contact information when making the new FOI request (e.g. a new email) and the analyst matches the applicant to an existing Applicant Profile that has different contact information (e.g. an old email), when the analysts Selects the existing Applicant Profile, then the Applicant Profile will be updated with the new contact information (e.g. email).
What is IN scope?
Navigate to applicant profiles from search results
View the applicant profiles
Select an existing applicant profile (when there is only one category for the applicant)
Multiple applicant category profiles #4763
What is NOT in scope?
Search Applicant Profile #4758
Multiple and new applicant category profiles #4763
Creating a new applicant profile
Updating an existing applicant profile
Request History for an applicant
Applicant Contact History
Acceptance Criteria
Scenario 1: Click search result in Search Applicants profile

GIVEN the IAO analyst is on the the Search Applicants modal
https://jacklyn808742.invisionapp.com/console/FOI---Intake-ckpq19frj032r013q6gpm8t1m/clp8r0umw0g3m016n9wh9gobi/play
AND results have been returned
WHEN the IAO analyst clicks on the line for any search result
THEN the existing Applicant Profile will open
AND there will be a toggle for Request History
AND there will be tags for additional profiles
AND the Applicant Details section will be open with these fields: Applicant First Name; Applicant Middle Name; Applicant Last Name; Organization; Category; AKA/Previous Name
AND the Address and Contact Information and Additional Applicant Details sections will be closed
AND there will be buttons to 'Select Profile, Save Changes, and 'Back to Search'
https://jacklyn808742.invisionapp.com/console/FOI---Intake-ckpq19frj032r013q6gpm8t1m/clp8r0umw0g3t016n0eue6392/play

Scenario 2: Back to Search from Applicant Profile

GIVEN the IAO analyst is on an Applicant Profile
https://jacklyn808742.invisionapp.com/console/FOI---Intake-ckpq19frj032r013q6gpm8t1m/clp8r0umw0g3t016n0eue6392/play
WHEN the analyst clicks the 'Back to Search'
THEN the analyst will be returned to the Search Applicants modal
https://jacklyn808742.invisionapp.com/console/FOI---Intake-ckpq19frj032r013q6gpm8t1m/clp8r0umw0g3m016n9wh9gobi/play

Scenario 3: All information does not match

GIVEN the IAO analyst clicks on applicant profile search result
WHEN NOT all of the data fields match in the request and the applicant profile
THEN the existing Applicant Profile will open
AND there be a message, 'Some of the fields in the applicant profile do not match your original request.'
https://jacklyn808742.invisionapp.com/console/FOI---Intake-ckpq19frj032r013q6gpm8t1m/clp8r0umw0g3t016n0eue6392/play

Scenario 4: All information does match

GIVEN the IAO analyst clicks on applicant profile search result
WHEN all of the data fields match in the request and the applicant profile
THEN the existing Applicant Profile will open
AND there be a message, 'All of the fields in the applicant profile match your original request.'

Scenario 5: Click Select Profile button

GIVEN the IAO analyst is on the Applicant Profile
https://jacklyn808742.invisionapp.com/console/FOI---Intake-ckpq19frj032r013q6gpm8t1m/clp8r0umw0g3t016n0eue6392/play
WHEN the analyst clicks the 'Select Profile' button
THEN a 'Add Applicant Profile to Request' modal will open
AND there will be a message, 'Would you like to save change for all open requests?'
AND there will be a button (blue by default) that says 'Save Change for Current Request'
AND there will be a button that says 'Save Changes for All Open Requests'
AND there will an 'X'

**Scenario 6: Click 'X' on the' Add Applicant Profile to Request' modal will open **

GIVEN the IAO analyst is on 'the 'Add Applicant Profile to Request' modal
WHEN the analyst clicks the 'X' button
THEN a the modal will close
AND the analyst will be returned to the Applicant Profile
https://jacklyn808742.invisionapp.com/console/FOI---Intake-ckpq19frj032r013q6gpm8t1m/clp8r0umw0g3t016n0eue6392/play

Scenario 7: Click 'Save Change for Current Request' when all information matches

GIVEN the IAO analyst is on 'the 'Add Applicant Profile to Request' modal
AND all of the information matches (e.g. same email, address, phone number)
WHEN the analyst clicks the 'Save Change for Current Request' button
THEN a the modal will close
AND the Applicant Profile will be linked to the new FOI request
AND the analyst will be returned to the Request View for the request?
AND the 'Search Applicant Profile' link will be updated to 'Applicant Profile'
https://jacklyn808742.invisionapp.com/console/FOI---Intake-ckpq19frj032r013q6gpm8t1m/clp8r0umw0g3p016ngmj29rhz/play

Scenario 8: Click 'Save Changes for All Open Requests' and all the information matches

GIVEN the IAO analyst is on 'the 'Add Applicant Profile to Request' modal
AND all of the information matches (e.g. same email, address, phone number)
WHEN the analyst clicks the 'Save Changes for All Open Requests' button
THEN a the modal will close
AND the Applicant Information will updated on all OPEN FOI requests linked to the Applicant Profile
AND the analyst will be returned to the Request View for the request
AND instead the 'Search Applicant Profile' link will be update to 'Applicant Profile'
https://jacklyn808742.invisionapp.com/console/FOI---Intake-ckpq19frj032r013q6gpm8t1m/clp8r0umw0g3p016ngmj29rhz/play

Dependencies? What is the impact of this dependency? (If so, link dependency in the ticket, make it visible in a team´s backlog)
Validation Rules? (If yes, list here)
Design
@xxx - please link the Design here
Definition of Ready

[ ] Is there a well articulated User Story?
[ ] Is there Acceptance Criteria that covers all scenarios (happy/sad paths)?
[ ] If there is a user interface, is there a design?
[ ] Does the user story need user research/validation?
[ ] Does this User Story needs stakeholder approval?
[ ] Design / Solution accepted by Product Owner
[ ] Is this user story small enough to be completed in a Sprint? Should it be split?
[ ] Are the dependencies known/ understood? (technical, business, regulatory/policy)
[ ] Has the story been estimated?

Definition of Done

[ ] Passes developer unit tests
[ ] Passes peer code review
[ ] If there's a user interface, passes UX assurance
[ ] Passes QA of Acceptance Criteria with verification in Dev and Test
[ ] Confirm Test cases built and succeeding
[ ] No regression test failures
[ ] Test coverage acceptable by Product Owner
[ ] Ticket ready to be merged to master or story branch
[ ] Developer to list Config changes/ Update documents and designs
[ ] Can be demoed in Sprint Review
[ ] Tagged as part of a Release
[ ] Feature flagged if required
[ ] Change Management activities done?

Scenarios 3 and 4 were in the designs but are they necessary?

@JHarrietha-AOT, please review.
Question for you - if an applicant submits a request and they have new contact information (e.g. a new phone number). When the IAO analyst finds and the selects an existing Applicant Profile and saves that profile to the request, then which contact information would be used? Would the new phone number be added to the existing Applicant Profile, or would the existing phone number overwrite the new number provided by the applicant with their FOI request?
cc @arielleandrews @m-prodan

As discussed will remove scenarios for updating applicant profile when the information on the original request does not match the information on the Applicant Profile (e.g. email).
The AC below will be included in an Update and Save Applicant Profile story:
Scenario 8: Click 'Save Change for Current Request' when all information DOES NOT match

GIVEN the IAO analyst is on 'the 'Add Applicant Profile to Request' modal
AND all of the information DOES NOT match (e.g. different email)
WHEN the analyst clicks the 'Save Change for Current Request' button
THEN a the modal will close
AND the Applicant Profile will be linked to the new FOI request
AND the Applicant Profile will be updated with the new contact information (e.g. different email)
AND the analyst will be returned to the Request View for the request
AND the 'Search Applicant Profile' link will be updated to 'Applicant Profile'
https://jacklyn808742.invisionapp.com/console/FOI---Intake-ckpq19frj032r013q6gpm8t1m/clp8r0umw0g3p016ngmj29rhz/play

Scenario 10: Click 'Save Changes for All Open Requests' and all the information DOES NOT match

GIVEN the IAO analyst is on 'the 'Add Applicant Profile to Request' modal
AND all of the information DOES NOT match (e.g. different email, address, phone number)
WHEN the analyst clicks the 'Save Changes for All Open Requests' button
THEN a the modal will close
AND the Applicant Information will updated on all OPEN FOI requests linked to the Applicant Profile
AND the Applicant Profile will be updated with the new information (e.g. different email, address, phone number)
AND all OPEN requests linked to the Applicant Profile will be will be updated with the new information (e.g. different email, address, phone number)
AND the analyst will be returned to the Request View for the request
AND instead the 'Search Applicant Profile' link will be update to 'Applicant Profile'
https://jacklyn808742.invisionapp.com/console/FOI---Intake-ckpq19frj032r013q6gpm8t1m/clp8r0umw0g3p016ngmj29rhz/play

View and Select existing Applicant Profile#4761 - 8/13
##################################################
front end - 3

Switch over of views from "Search Applicants" to "Applicant Profile"
develop react components for "Applicant Profile" - Viewonly

back end

API to fetch the Applicant details as per selection on the list - 5

@lmullane Story needs to be updated with the new module we discussed at Stand-Up yesterday. It is the module that will show up if the Analyst Clicks to Create New Profile. I added it in the flow here (under sprint 66: https://miro.com/app/board/uXjVMtjQyiU=/?share_link_id=207208780832). Let me know if you have any questions


[GOBBLIN-1707] Update IcebergDataset to incorporate all snapshots, not only the current one

Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
JIRA

[ ] My PR addresses the following Gobblin JIRA issues and references them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"

https://issues.apache.org/jira/browse/GOBBLIN-1707

Description

[ ] Here are some details about my PR, including screenshots (if applicable):

Update IcebergDataset to incorporate all snapshots, not only the current one

Update IcebergDataset to use IcebergTable.getIncrementalSnapshotInfosIterator rather than .getCurrentSnapshotInfo

Tests

[ ] My PR adds the following unit tests OR does not need testing for this extremely good reason:

Augment IcebergDatasetTest unit test to exercise mult-snapshot icebergs

Commits

[ ] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":

Subject is separated from body by a blank line
Subject is limited to 50 characters
Subject does not end with a period
Subject uses the imperative mood ("add", not "adding")
Body wraps at 72 characters
Body explains "what" and "why", not "how"

Codecov Report

Merging #3569 (43bc0f2) into master (3733d60) will increase coverage by 3.94%.
The diff coverage is 75.34%.

@@             Coverage Diff              @@
##             master    #3569      +/-   ##
============================================
+ Coverage     46.80%   50.75%   +3.94%
+ Complexity    10551     5797    -4754
============================================
  Files          2106     1061    -1045
  Lines         82234    40261   -41973
  Branches       9151     4507    -4644
============================================
- Hits          38493    20435   -18058
+ Misses        40190    18064   -22126
+ Partials       3551     1762    -1789

Impacted Files
Coverage Δ

...management/copy/iceberg/IcebergCatalogFactory.java
0.00% <0.00%> (ø)

...ta/management/copy/iceberg/IcebergHiveCatalog.java
0.00% <0.00%> (ø)

...n/data/management/copy/iceberg/IcebergDataset.java
83.56% <76.92%> (-0.73%)
:arrow_down:

...lin/data/management/copy/iceberg/IcebergTable.java
88.67% <83.78%> (-11.33%)
:arrow_down:

...a/management/copy/iceberg/IcebergSnapshotInfo.java
88.23% <100.00%> (+8.23%)
:arrow_up:

.../org/apache/gobblin/metrics/RootMetricContext.java
78.12% <0.00%> (-1.57%)
:arrow_down:

...apache/gobblin/runtime/metrics/RuntimeMetrics.java
0.00% <0.00%> (ø)

...data/management/copy/RecursiveCopyableDataset.java
86.36% <0.00%> (ø)

...bblin/elasticsearch/writer/MalformedDocPolicy.java

... and 1061 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


[Translatable] PostgreSQL FK cast

Hello,
I had some problems with a personal translations and PostgreSQL in my Symfony project.
When I am using the Gedmo\\Translatable\\Query\\TreeWalker\\TranslationWalker class, Doctrine throws an error, saying that I'am passing an integer parameter to the where clause (my FK are ints). The main part of the query, which cause the problem looks like this: ...t1_.object_id = a0_.id::VARCHAR....
I found that in TranslationWalker there is an if statement on line 307:
$castFK = ($this->platform instanceof PostgreSqlPlatform) ? '::VARCHAR' : '';
Can I ask please, what is the meaning of this statement? When I comment that, all queries are OK.
Thanks!

yes, actually there is a casting done. so for postgresql either use a custom translation entity where you can overide the mapping to int instead of string. or use personal translations. the initial version was made to support mainly mysql.

Yes, I've already wrote, that I'm using personal translations.
I don't think, that overriding some part of the entity would solve the problem, because if statement depends on a platform:
$this->platform instanceof PostgreSqlPlatform ? '::VARCHAR' : ''
I cannot understand the meaning of this statement, because in the most cases FK are integers, not Varchar. Could this feature be configurable or somehow extendable?
Thanks!

well, it certainly would be best to have only integers and prevent casting at all. since this is not backward compatible, I would advice you to have a fork now with appropriate modifications. extensions will not change the behavior in future releases. so for the specific project that would be a good solution..

should be fixed in master

Thank you!


Messages are duplicated

Subject of the issue
Sometimes messages are duplicated, meaning several copies of the same message are present inside the chat. It happens with text and image messages. This issue has appeared before. Last time the problem was about sending the same message multiple times. I think this is the same issue because duplicated messages have different receive times and get downloaded again after clean re-installation of the app.
Your environment
Server-side

[ ] web.tinode.co, api.tinode.co
[ ] sandbox.tinode.co
[x] Your own setup:

platform: Linux
version of Tinode server: Latest
database backend: MySql
standalone

Client-side

[ ] TinodeWeb/tinodejs: javascript client

Browser make and version.

[x] Tindroid: Android app

Android API level (e.g. 25).
hardware, Samsung Galaxy S7Edge

[ ] Tinodios: iOS app

iOS version
Simulator or hardware, if hardware describe it.

[ ] tn-cli

Python version

[ ] Chatbot

Python version

Version of the client, e.g. 0.15.1
[ ] Your own client. Describe it:

Transport (gRPC, websocket, long polling)
Programming language.
gRPC version, if applicable.

What is the version of the app?

Can you show the logcat and the server-side log?

I'm on the last commit of the devel branch.
Actually reproducing this bug is not easy and It happens occasionally so I can not send any useful logcat or server logs.

Please try to provide additional information. Otherwise it's unclear to me how to replicate the bug.

Is this resolved? Still relevant?


Remove restriction on whitespace in netCDF variable names

The netCDF conventions state:

Variable, dimension and attribute names should begin with a letter and be composed of letters, digits, and underscores.

However, the netCDF4 Python library does not enforce this convention. Is there any reason Iris should too?
I have a user with a netCDF file with a variable containing whitespace that can't be used in Iris due to this restriction. I imagine there are others who have encountered the issue as well.
So, what are the arguments against relaxing the restriction?

I don't think we should relax this. If the NetCDF conventions state that variable names may not include spaces, then Iris should not allow variable names that contain spaces. In this case (awkwardly) it's the NetCDF python library that is wrong, not Iris...

Is there room for compromise where we allow names with white space but replace with underscores, following the principal of being lenient on load but strict on save?

@ajdawson that might be a nice (and well-principled) solution to this :+1: We could (optionally!) raise a warning that such a replacement is happening, too.

Can I suggest we allow loading with no modification, but raise an error on save? I can see things getting a bit fiddly when you try to deal with the corner cases where replacing whitespace with underscores produces an existing variable name.
This relates to the discussion on this pull request about whether to allow non-compliant values in the data at all.

Can we currently assign a name with spaces once data are loaded? If so then I'm in favour of this not causing any error on load, since one could have generated the same dataset manually. If not then we might want to think about sanitizing on input.

Can we currently assign a name with spaces once data are loaded?

No, it gives the same error as when loading

I've closed this because I think trying to sanitise the inputs will be two fiddly and not worth the time


prebuilt binary does not run on Debian

Description of the problem or steps to reproduce
The prebuilt binary doesn't seem to work in Debian 8 and Debian 9, at least not over SSH. It complains about an error in the executable's format:
戭獡㩨⼠潨敭爯湹潮⽮楢⽮業牣㩯䬠湡楤楂摲瑡楥渠捩瑨愠獵ﱦ牨湥›敆汨牥椠潆浲瑡搠牥倠潲牧浡摭瑡楥
for some reason it gets converted to an Asian script when I paste it; output from other commands pastes just fine. typing it out, the message actually reads this (sorry, it's in German):
bash: ./micro: Kann die Binärdatei nicht ausführen: Fehler im Format der Programmdatei
Specifications
Commit hash: 5fc8f84
OS: Debian 8, Debian 9
Terminal: urxvt (SSH-session)

Have you tried building from source? I'm not seeing this issue or the other one you posted about (#943) when running on Ubuntu.

For clarification, did you see this issue when running debian? And did you see the other issue on ubuntu 16.04, as opposed to ubuntu 17.10?
I would try compiling it myself, but I don't know the dependencies.

Which architecture are you running on?  Did you use the correct binary?
I’m using Debian testing (x86_64) and I didn’t encounter any similar issue.

 The linux32 binary works.


Add activity log for saving properties

Storage Explorer Version: 1.12.0
Build: 20200109.2
Branch: rel/1.12.0
Platform/OS: Windows 10/ Linux Ubuntu 18.04/ MacOS High Sierra
Architecture: ia32/x64
Regression From: Not a regression
Steps to reproduce:

Expand one storage account -> Blob Containers.
Create one blob container -> Upload one blob.
Open its properties dialog -> Click 'Save'.
Check whether there shows activity log or not.

Expect Experience:
There shows activity log.
Actual Experience:
No activity log shows.
More Info:

This issue doesn't reproduce for ADLS Gen2 blob container & ADLS Gen2 blob.
This issue also reproduces for files under one file share.

Verified this issue on build 20200924.2.

This issue has been fixed for blobs.
This issue still reproduces for files & folders under one file share.

@v-xianya I have now merged code to fix this for files and file shares as well. Please note the following:

Both files and folders have a 'Directory' property now
The md5 property is now readonly, same as blobs
The ordering of properties should now roughly be the same as blobs
'Uri' was changed to 'URL' to be consistent with blobs

@v-xianya I have now merged code to fix this for files and file shares as well. Please note the following:

Both files and folders have a 'Directory' property now
The md5 property is now readonly, same as blobs
The ordering of properties should now roughly be the same as blobs
'Uri' was changed to 'URL' to be consistent with blobs

@MRayermannMSFT
We noticed there is a '/' append to the name of the folder in Folder Properties dialog on the latest build 20210113.4, is this intended?

@MRayermannMSFT
We noticed there is a '/' append to the name of the folder in Folder Properties dialog on the latest build 20210113.4, is this intended?

@v-xianya  yes

@v-xianya  yes


added Dutch locale

Hi,
This is a PR with:

a Dutch locale (I am willing to maintain it in the future)
bugfix for language selection in Chrome

selection options appear as white text on a white background

updated the default (outlined) background to bg-main-dark because I felt that this was the initial design

Hey @brambex, thank you so much for the PR! I'll review it tomorrow 👍

Everything looked good! It's merged 🎉
It just updated the flag/name so it's more consistent with ours.
.
Maintenance will might be a bit annoying. We very often add new keys and won't be able to translate them. So they will fallback in english in the meantime. I guess it's not too problematic.

By the way, we also released a "Game summary" page this week-end but it hasn't been translated yet (https://hanabi.cards/summary?gameId=udVsP7ebn)

@bstnfrmry Yes, I've seen it. Somebody picked it up already or can I work on it in a new branch?

@brambex We haven't started anything yet so you can create a new branch 👍


Wrong URL for fetching ontology from git.

The class GitHubOwlTechnique, located in src/misc/technique-getter.ts downloads the OWL ontology from github, as the source/PaNET.owl file (taken from the master branch) by default.
There are two problems with this.

The default value is wrong.  The file source/PaNET.owl is not the latest release.  The correct path for the latest release is releases/latest-release/PaNET.owl, also available under the master branch.
We are in the process of removing the compiled ontology from git (see the issue ExPaNDS-eu/ExPaNDS-experimental-techniques-ontology#70).  Therefore, both paths (source/PaNET.owl and releases/latest-release/PaNET.owl) will go away "at some point".

A safer way of obtaining the latest version of the PaNET ontology is to dereference the purl.org IRI for the ontology:
http://www.purl.org/pan-science/PaNET/PaNET.owl.  A client making an HTTP GET request against this URL is redirected to a configurable location.  The result is that fetching the content from the IRI will return the RDF/XML description of the latest PaNET version.
Note that the URL http://www.purl.org/pan-science/PaNET/PaNET.owl currently redirects to the same wrong file as the default in src/misc/technique-getter.ts (i.e., source/PaNET.owl).  This is being fixed, see ExPaNDS-eu/ExPaNDS-experimental-techniques-ontology#73. Once this issue is fixed, the Purl.org IRI will redirect to the releases/latest-release/PaNET.owl (see problem 1. above).
Longer term, in resolving ExPaNDS-eu/ExPaNDS-experimental-techniques-ontology#70, we will place the XML/RDF file describing the PaNET ontology somewhere else, most likely on github pages.  When doing this, we will update the Purl.org configuration so the ontology IRI (http://www.purl.org/pan-science/PaNET/PaNET.owl) will continue to provide the ontology description.

A quick update on this issue.
PaNET has adopted GitHub releases.
The PaNET GitHub repository has been updated by creating the v1.0.0 release, with the file PaNET.owl being one of the assets of that release.  The PaNET.owl asset within the v1.0.0 release is identically the same as the contents currently available as releases/latest-release/PaNET.owl on the master branch.
Subsequent releases of PaNET will be made available as new GitHub releases, and not by storing files under the releases/ directory within the repository.
The PaNET PURL now resolves to a GitHub release.
The PaNET PID: http://www.purl.org/pan-science/PaNET/PaNET.owl now resolves to the PaNET.owl asset of the GitHub release tagged "latest".  (Currently, this is the above v1.0.0 release.)  This closes issue https://github.com/ExPaNDS-eu/ExPaNDS-experimental-techniques-ontology/issues/73.
One of the next steps will involve removing releases/latest-release/PaNET.owl from the repository.


Renew OAuth tokens and store updated tokens

Should test with Google's oauth before merging (ie. meetbot)

Great this works for meetbot as well


Create a system to make flexibe stats

http://howtomakeanrpg.com/a/how-to-make-an-rpg-stats.html
https://www.reddit.com/r/gamedev/comments/4fucve/how_do_developers_create_and_refine_their_rpg/
https://gamedev.net/forums/topic/683035-designing-a-stateffect-system-for-an-rpg/5314973/
https://www.reddit.com/r/gamedesign/comments/3puffc/how_do_you_design_a_rpg_attribute_system_where/
https://www.redblobgames.com/articles/probability/damage-rolls.html

https://forum.unity.com/threads/tutorial-character-stats-aka-attributes-system.504095/

https://forum.unity.com/threads/tutorial-character-stats-aka-attributes-system.504095/

In the end didn't create flexible stats, but i think that for now this will be left here because i think i did a good enough job.

In the end didn't create flexible stats, but i think that for now this will be left here because i think i did a good enough job.


Robots teleported from the penalty area if they are in there for more than 5 seconds

@javier687 @felipenmartins  @Adman Let's see if we can put this together rather quickly

@Adman would you be up to taking this?


krita: 4.4.2 -> 4.4.3

Motivation for this change
Fixes nasty and common crash
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[ ] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 118597 at bfcf7de5 run on x86_64-linux 1

1 package skipped due to time constraints:

gmic-qt-krita

1 package built successfully:

krita

1 suggestion:

warning: unclear-gpl
gpl2 is a deprecated license, please check if project uses gpl2Plus or gpl2Only and change meta.license accordingly.
Near pkgs/applications/graphics/krita/default.nix:55:5:
   |
55 |     license = licenses.gpl2;
   |     ^


Use cosmiconfig for rc file lookup

This is used pretty widely and is battle tested, provides more flexibility than our current approach, and should still allow us to use esm to load import / export.
https://github.com/davidtheclark/cosmiconfig

Implemented in #302.


backport to istio 1.9: copy node instead of merging

https://github.com/istio/istio/issues/31904 is fixed on Envoy master, but this backports the fix to Istio 1.9
Test coverage is from existing unit tests and ADS integration test

Maybe could add an extension to config in an existing test. Doesn't seem too important; seems unlikely this change would ever be undone


test: refactor common tests to AVA

This is an automated PR, so double check that I got all the test cases. I'll follow up once I've verified that this translates everything correctly.

@freitagbr PTAL

LGTM

LGTM


Added Swagger documentation

Closes #5.

Reorganized routing system into a centralized router imported by app, rather than importing various routers in app directly.
Setup Swagger model definitions in separate file for each entity.
Added Joi validations for various endpoints, which also generates Swagger documentation.
Setup Swagger spec file at /docs/spec.json and Swagger UI at /docs
Updated CONTRIBUTING.md to match changes

Hi @TheBeege, when I run docker-compose up w/o -d option, I got:

Error: Cannot find module '@hapi/joi'

I deleted node_modules directory, and re-install dependencies using npm install, and also, npm ci. However, the error still happened. Would you be able to check on it if you have the same error?

Hi @TheBeege, when I run docker-compose up w/o -d option, I got:

Error: Cannot find module '@hapi/joi'

I deleted node_modules directory, and re-install dependencies using npm install, and also, npm ci. However, the error still happened. Would you be able to check on it if you have the same error?

@kzkaneoka I can't reproduce that behavior. I also removed node_modules and reinstalled. I ran docker-compose up outside of npm with success. I ran it on my shell directly, not in my IDE, though both should work.
If it's still happening, can you show me a stacktrace?

@kzkaneoka I can't reproduce that behavior. I also removed node_modules and reinstalled. I ran docker-compose up outside of npm with success. I ran it on my shell directly, not in my IDE, though both should work.
If it's still happening, can you show me a stacktrace?

Um, it's wired. This is the stacktrace, and as well as git log.

Um, it's wired. This is the stacktrace, and as well as git log.

Thanks for working. LGTM!

Thanks for working. LGTM!


Keyboard shortcut to exit note

This isn't really an issue, more of a suggestion.
Whenever I want to cancel a note, or save and exit, I like to press esc
Also you should make a feature suggestion forums site or area (if there already is can you please direct me there?)

Thanks for the suggestion. This is very similar to #59 but you additionally mention cancelling. How would you propose to choose between cancelling and saving & exiting? If it were a modal-based question, would that not negate the benefit of the keyboard shortcut?

As of 5.2.0 you can now exit edit mode with the escape key. 🚀


[UG1] Implement in-game configurator

This screenshot is the current status as of commit https://github.com/xan1242/NFSU-XtendedInput/commit/3ba9d4ee175db521a11ed41bbe20b2463cd90370
As of now, it only displays current settings and not much more.
What's left to do:

PlayStation strings
Keyboard strings & map to name conversion
And finally, actual remapping & saving to the INI (a spot for this is stubbed in HandleInGameConfigMenu())

This menu normally supports up to 6 devices with 3 different types: keyboards, joypads and wheels.
I'm only focusing on the first two, as is the intent of this plugin. As such, index 0 will be hardcoded to the keyboard input, and index 1 will be hardcoded to the joypad input.

Implemented in: https://github.com/xan1242/NFSU-XtendedInput/commit/ae46cd8a3b61dfa712eb5eb56b903c23e69856b0
Currently it works, with the caveat that it doesn't support 2 mappings and it's limited to what's shown on the screen.


Add rust-format-diff-buffer

This command displays the output of rustfmt-diff.

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nikomatsakis (or someone else) soon.
If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.
Please see the contribution instructions for more information.

Hmmm. Emacs-24. I can make this work with Emacs-24, but given that we are near the end of the Emacs-26 release cycle do you really want that support?

A good question. All of my machines are emacs 25 or above. @pnkfelix -- thoughts?

If you want emacs-24, I can add another PR which allows the tests to be run locally via docker. I still support Emacs-24 in one of my packages (cause it's a test framework), but it's very hard to build all of the Emacs-24 release cycle now.

@phillord I personally don't think it's necessary, but I guess I have no real sense of what is the norm in terms of backwards compatibility for emacs packages.

Explicit support for Emacs-24 is pretty rare now, although many packages will support it just because they do not depend on anything from 25 onwards. There are some people who are still on Emacs-24, perhaps because of organisational policy.
I am not sure it's a question of the norm, though. it a question of Rust developers. It wasn't that long ago that most Rust developers were on nightly (perhaps they still are). And Emacs-25 was released at about the same time as Rust 1.12, while Emacs-24.5 was released about the same time as Rust 1.0.
Anyway, how do we move this forward? It's not my decision as to which version you want to support, but it would be nice to close this PR (supporting 24 or not).

Anyway, how do we move this forward? It's not my decision as to which version you want to support, but it would be nice to close this PR (supporting 24 or not).

Indeed. I vote we drop emacs 24 support, but I'm going to defer to @mookid, since they recently volunteered to help keep up maintenance. =)

Hi @phillord,
is that possible to use create-process instead of make-process? If that makes compilation happy, we can defer the discussion about maintaining compatibility for emacs-24.

I rebased on master, and added a couple commits to

fix the build on emacs24
use diff-mode in the resulting buffer, making ir also read-only :
https://github.com/rust-lang/rust-mode/tree/rust-format-diff-buffer

The motivation for the second point is to have something similar to vc-diff (the window get focus, so that 'q' exist).
@phillord let me know what you think.
Please let me

Many thanks for the contribution.


chore: Add discord link to README

Add discord link to README
see diff in rich text mode to try out the button: https://github.com/osmosis-labs/osmosis/pull/1432/commits/87ba8c314ff44c51c31550fe85855c522749600f#diff-b335630551682c19a781afebcf4d07bf978fb1f8ac04c6bf87428ed5106870f5

Codecov Report

Merging #1432 (87ba8c3) into main (f56fbe5) will decrease coverage by 0.28%.
The diff coverage is 17.22%.

@@            Coverage Diff             @@
##             main    #1432      +/-   ##
==========================================
- Coverage   19.82%   19.53%   -0.29%
==========================================
  Files         202      226      +24
  Lines       27685    30953    +3268
==========================================
+ Hits         5489     6048     +559
- Misses      21175    23800    +2625
- Partials     1021     1105      +84

Impacted Files
Coverage Δ

x/epochs/client/cli/query.go
0.00% <ø> (ø)

x/gamm/client/cli/query.go
36.74% <0.00%> (-0.36%)
:arrow_down:

x/gamm/pool-models/stableswap/amm.go
40.27% <0.00%> (-15.50%)
:arrow_down:

x/gamm/pool-models/stableswap/msgs.go
0.00% <0.00%> (ø)

x/gamm/pool-models/stableswap/pool.go
0.00% <0.00%> (ø)

x/gamm/pool-models/stableswap/stableswap_pool.go
0.00% <0.00%> (ø)

.../gamm/pool-models/stableswap/stableswap_pool.pb.go
0.58% <0.00%> (-0.09%)
:arrow_down:

x/gamm/types/pool.go
0.00% <ø> (ø)

x/incentives/client/cli/query.go
0.00% <ø> (ø)

x/incentives/keeper/distribute.go
61.00% <0.00%> (ø)

... and 49 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 94caf2b...87ba8c3. Read the comment docs.


helm doesn't inherit values for subcharts with -f myvals.yaml

to reproduce:

create a chart with subcharts
package chart
install chart with custom subchart vals: helm install foo.tgz -f myvals.yaml

helm doesn't care about myvals.yaml

I just easily reproduced this:
⇒  helm install --dry-run --debug -f foo.yaml borked
Created tunnel using local port: '59664'
Server: ":59664"
Chart path: /Users/mattbutcher/Code/Go/src/k8s.io/helm/borked
NAME:   happy-ladybird
INFO:   Thu Jul 21 10:22:58 2016
CHART:  borked 0.1.0
MANIFEST:
---
# Source: borked/charts/foobar/templates/test.yaml
apiVersion: v1
kind: Foo
metadata:
  foo: quxx  ## value of .Values.foo

---
# Source: borked/templates/alpine-pod.yaml
apiVersion: v1
kind: Pod
metadata:
  name: "happy-ladybird-alpine"
  labels:
 >heritage: "Tiller"
  chart: "borked-0.1.0"
spec:
  restartPolicy: Never
  containers:
  - name: waiter
    image: "alpine:3.3"
    command: ["/bin/sleep","9000"]

⇒  cat foo.yaml
foobar:
  foo: bar


Pod crashes when logging in

Is this a request for help?: yes

Is this a BUG REPORT or FEATURE REQUEST? (choose one): BUG REPORT

Version of Helm and Kubernetes: Helm v2.12.3 and GKE
Which chart: parse-5.1.2 and parse-6.0.2 (tested on both)
What happened: When trying to log in (whether via the SDK or REST) the server crashes. False usernames and passwords are handled perfectly, returning normal error codes, it's just after a successful login that the pod crashes and leaves me with a 502 Bad Gateway.
What you expected to happen: Return a user object with session id etc.
Anything else we need to know:
When further investigating the kubectl logs I recognized the following error:
(the false login attempts still seemed to work, afterwards it crashed)
appId: e1
masterKey: ***REDACTED***
serverURL: http://<IP_ADDRESS>:1337/parse
masterKeyIps: []
appName: parse-server
logsFolder: ./logs
databaseURI: mongodb://bn_parse:HF3kE2DpVj@e1-backend-mongodb:27017/bitnami_parse
userSensitiveFields: ["email"]
enableAnonymousUsers: true
allowClientClassCreation: true
maxUploadSize: 20mb
customPages: {}
sessionLength: 31536000
expireInactiveSessions: true
revokeSessionOnPasswordReset: true
schemaCacheTTL: 5000
cacheTTL: 5000
cacheMaxSize: 10000
objectIdSize: 10
port: 1337
host: <IP_ADDRESS>
mountPath: /parse
scheduledPush: false
collectionPrefix:
preserveFileName: false
verifyUserEmails: false
preventLoginWithUnverifiedEmail: false
enableSingleSchemaCache: false
enableExpressErrorHandler: false
jsonLogs: false
verbose: false
level: undefined

[29] parse-server running on http://<IP_ADDRESS>:1337/parse
Warning: no saslprep library specified. Passwords will not be sanitized
Warning: no saslprep library specified. Passwords will not be sanitized
Warning: no saslprep library specified. Passwords will not be sanitized
Warning: no saslprep library specified. Passwords will not be sanitized
error: Error generating response. ParseError { code: 101, message: 'Invalid username/password.' } code=101, message=Invalid username/password.
error: Invalid username/password. code=101, message=Invalid username/password.
/opt/bitnami/parse/node_modules/parse-server/lib/ParseServer.js:218
          throw err;
          ^

Error: ENOENT: no such file or directory, open '/logs/parse-server.info.2019-02-17'

I then opened the bash within the pod (after it restarted) and investigated that lines of code within the ParseServer.js:
    api.use(bodyParser.json({ 'type': '*/*', limit: maxUploadSize }));
    api.use(middlewares.allowCrossDomain);
    api.use(middlewares.allowMethodOverride);
    api.use(middlewares.handleParseHeaders);

    const appRouter = ParseServer.promiseRouter({ appId });
    api.use(appRouter.expressRouter());

    api.use(middlewares.handleParseErrors);

    // run the following when not testing
    if (!process.env.TESTING) {
      //This causes tests to spew some useless warnings, so disable in test
      /* istanbul ignore next */
      process.on('uncaughtException', err => {
        if (err.code === "EADDRINUSE") {
          // user-friendly message for this common error
          process.stderr.write(`Unable to listen on port ${err.port}. The port is already in use.`);
          process.exit(0);
        } else {
          throw err;                       <-------- line 218

So some kind of uncaught exception is happening here but I just can't seem to find out what exactly has happened.
If anybody could help me that would be amazing. Thank you!

Did you deploy parse using any special values? Or you simply executed helm install stable/parse?