Content Creator: Understand content types and take action

As a Content Creator, I want to understand which content type I need and have the ability to take action quickly so that I can create and edit content with ease.
Feature: Content type list context
  As a Content Creator,
  I want to understand which content type I need
    And have the ability to take action quickly
  So that I can create and edit content with ease.

  Scenario: Understand content types
    Given I am looking to create/edit content in the CMS
     When I view the list of content types
     Then I will see a description for each content type
       And be able to understand the purpose of each content type

  Scenario: Add content
    Given I am looking to create new content
     When I view the list of content types
     Then I will have the ability to add content from this view

  Scenario: View content
    Given I am looking to see all the content for a content type
     When I view the list of content types
     Then I will have the ability to view a list of all the content from a specific content type

Content type list context:

[ ] Understand content types
[ ] Add content
[ ] View content

http://watson-cms.stage1.mybluemix.net/content

🎱
@joshkimmell @poofichu @mkiang3051 @scottnath - Had a little trouble writing the scenarios for this one, but here you go. Ready for review.

@ineedsubstance
When you say add or view content with 1 click, does that mean the ability to add something prior to clicking into a content type? (e.g., like having buttons to create or view on the screenshot from the CMS you provided above)
Also, are we deciding to show all content types for all users? Or are you putting it in here, in case we decide to go that way? (I think this may also be a bit related to user roles and access that I need to create stories for.)

@mkiang3051 - Yes! Users should be able to perform these actions from the content type list without having to click into it.
I think it would be useful to show all content types for all users. My thought is if we don't display them, then a user wouldn't know what content they don't have access to or to who/how to ask. I think this is still up for debate and needs to be validated.

@ineedsubstance will break this into 2 stories.

presentation of content types (this)
more actions to take

Split this up into 2 stories. This story is not a blocker for #444

@ineedsubstance
I have a question about view content scenario for the story. Are we talking about the ability to expand a content type on this initial Content Type landing screen and view some of the content in a section without having to click into it?
Or are you more referencing the view of a certain type of content a user would see upon clicking into a Content Type?

@ineedsubstance @joshkimmell @scottnath @poofichu
Started some quick card designs in mobile for displaying content types. There are 3 main versions so far, with small changes in the way the buttons/links are displayed.
If you could let me know your thoughts and perhaps which of these you like best, that would be very helpful!
These are totally not final, but I wanted some input earlier to help me shape my designs.
Thanks guys!

Mocks in mobile for very basic actions (seeing content types + their descriptions, adding new content types, and viewing the content under each content type).
V1 has a physical link / button on each content type card to add new content or to view all the content associated with that content type.
V2 has a global add button that lets you select the type of content you'd like to add from a menu (instead of having a specific add button on each content type card)

V1

V2

I think v1 is the better way to go so we are not separating the actions from the content type cards.

@ineedsubstance It would definitely make it easier on us not having to create a new menu for a global add. 🙃 I thought of having a global add at the top of the page so that users who come to this page can immediately click on the add new button and select a content type to add, instead of scrolling down to find the card of the content type they want, then clicking on a button on that card to add it. It's not that big a deal on desktop since more cards will display, but I was just thinking about on mobile.
I'll run with the no global add idea though and iterate more on card design.
@joshkimmell @poofichu @scottnath Any thoughts?

@mkiang3051 - I think that could be an additon in the future that we explore. I don't think it should be in place of having those actions on the actual cards.

@ineedsubstance Yea - that works.

Preference for list vs. grid on mobile? See mocks below. (This is with the assumption that the presentation on desktop would be a grid bc of the cards)
NOTE: Don't pay attention to the buttons/information present on these two mocks regarding actions on the cards b/c I know they differ (V1 has two actions, add and view content while V2 only has a button for add. I will post again about card formatting after this post.
V1 - List

V2 - Grid

I like the single column on mobile (more clear with more tappable area for actions) and then expand that out as the view get's bigger.

@ineedsubstance Works for me. When you say expand out, do you mean larger cards in grid format for desktop? And maybe just expanded list form in single column for larger mobile screens?

@ineedsubstance @joshkimmell @poofichu @scottnath
Here are some very simple card layout wires.
Versions 1 and 2 each have 2 iterations that have two links/buttons: one for viewing the content and then one for adding new content.
Version 3 has 1 physical link or button for adding new content - while I was thinking the larger card overall would be a clickable link/button to view the content. It has 4 iterations that just show ideas of how the 1 button can be placed.
Let me know your thoughts on whether we want 1 or 2 buttons, or if there is another way we can display this. My preference would be to have a larger area to click on to be taken to view the content, but I think ultimately either do the job.

@mkiang3051 - Good options. Given our current styling for the CMS, and that the title and description could fluctuate a lot, I would say v1.2 is the best option.
Although, for all v3 options, would the view action be the title since the button isn't present?

@ineedsubstance Suhweet. And yea version two is pretty straightforward and adaptable in case any of the titles and descriptions change.
I was thinking in all the v3 options the whole card (with the add new button as an exception) would be the clickable view action. So if a user clicks on anything on that card minus the designated add button or section, they would be taken to view the available content.
Would that be feasible? My concern is if that separation would actually work in a real life scenario and that people wouldn't be confused.
Clicking on the title would be another way it could work without the confusion - but I was trying to think of a way to provide users with a larger active area to view items one level deeper, since I know that my first instinct when I see anything that remotely looks like a card is to click on the card itself and not necessarily on specific text or a button to view items one level deeper. I've heard that sentiment around as well.
Let me know your thoughts on this. Thanks!

Yeah, technically that won't work to have the card as a button with a button on top. The button will actually live inside the card. My opinion is to go with v1.2.

@ineedsubstance Yea - wishful thinking haha. A button within a button within a button! Yea, v1.2 is probably easiest to design/implement. Let's go with that!
Did you want me to try to visually mock up v1.2 in desktop/larger format and/or with some visual styling?

@mkiang3051 - Let's take this to code! We can work together to code this out and take a look at the styling that already exists and adjust from there.

@ineedsubstance
Sounds good! I may or may not be in the office tomorrow - but I can put something on the calendar for next week?

That sounds good to me

@poofichu @joshkimmell - Looking for some opinions here. We have 2 main actions on content types, first is to add content and the second is to view content. @mkiang3051 and I both think simplifying the button text to add and view still works for clarity and simplification. What do you guys think? Also, @poofichu, do we need a secondary style button here maybe? Maybe just a button with an outline and no color background? Just wondering if that might help distinguish the buttons better.

The one reason I can see to leave the word "content" is for accessibility reasons.
Otherwise, outlined dark teal button is something I'll need to see to say yay or nay to.

@poofichu - Hmm... didn't think that using Add only would be an accessibility issue since it is on the content page in the context of a content type but you might be right. Is that something testable?
Also, quick mockups of a secondary style button. If you have any suggestions, let me know. I was just thinking we might need something like that for instances where we have 2 buttons next to each other that we want to add some visual hierarchy too.

To be honest, when I'm looking at the 2 different styles, I'm wondering if it really needs it?  This one is still my favorite option:

Cool. That is the one that Miranda and I preferred as well.

Yar har! (Triple agreement - oh yea!)


streaming json reader

see https://github.com/json-path/JsonPath/blob/master/json-path/src/test/java/com/jayway/jsonpath/JacksonJsonNodeJsonProviderTest.java

. Read mapping file via Jackson ObjectMapper (as POJO)
. Stream JSON data file, read one JSON object at a time (no POJO mapping possible); For each object:
** Create a node in Gio
** For each link in the mapping:
*** Create a link in Gio (refer=existing)
*** Create a node and link in Gio (refer=inline)


Add package-lock.json files to user tests

Try to use the same package versions that resulted in the baselines. Update the package versions in rolling builds and reuse them in triggered PR associated builds.

@typescript-bot user test this

@typescript-bot user test this
(sorry, typescript-bot only responds to team members)

This PR hasn't seen any activity for quite a while, so I'm going to close it to keep the number of open PRs manageable. Feel free to open a fresh PR or continue the discussion here.


Preferrably rename these Surahs:

rename Surahs referring to prophets (explicitly) to The Prophet _______
rename Surah 5 to Al-Maidah
rename Surah 14 to Abraham, "im" to "am"; more common
rename Surah 20 to The Letters "Ta" and "Ha"
rename Surah 22 to Al-Hajj, extra j more common
rename Surah 25 to The Criterion, "a" changes to an "o"
rename Surah 36 to The Letters "Ya" and "Sin"
rename Surah 52 to The Mountain, as mounts can refer to horses
rename Surah 58 to Al-Mujadilah, add h to mean converted t in Arabic
rename Surah 60 to The Woman to Be Examined
rename Surah 66 to The Prohibition, had extra i
rename Surah 86 to The Nightcomer, extra m
rename Surah 88 to The Overwhelming Event
rename Surah 101 to The Striking Calamity
rename Surah 102 to The Rivalry in Worldly Increase
rename Surah 104 to The Slanderer
rename Surah 106 to The Tribe of Quraysh
maybe rename Surah 21 to Al-Ambya, if you wish to write as pronounced
maybe rename Surah 28 to The Narrations, stories can mean fairy tales
maybe rename Surah 85 to The Big Stars

I disagree with some of these - let's stick to current quran.com naming for
now (that'll fix some of the suggestions from this ticket, ex Abraham
should be Ibrahim).

To be clear, I am talking about the Arabic name. For English, let's find a
translation and use their naming.

yeah i am with you i dont want to change them


Unable to login via near shell + /create is wiping out account information from local storage

Problem
When I run near login in the terminal it redirects me to the Browser, I provide all the information to grant full access to near shell. However, once I hit confirm it either throws an error in the browser or it redirects me back to the terminal but then throws an error.
The error in the browsers

The error in the console

This error happened every time I tried to login (using Chrome and then Firefox, each on Ubuntu and Windows).
Separately, I have encountered an error that basically wipes out all the information on the wallet in local storage -- this happens upon opening /create near wallet in the browser. However, this error was more like a "by-chance" thing rather than an every-time default behavior.
It would then show the following error (I think that was the error in that case)

In this case, we were trying to log in through near login in the terminal but then it would wipe out the keys that were previously used in the browser. This behaviour only happened on Windows but on two different machines.
Expected Behavior
Happy log-in path (like usual)
Steps to reproduce
Well, this is a bit complicated -- near login in the terminal and see what happens.

@AnaisUrlichs Did we ever get a reliable reproduction of this?

@kcole16 we sadly did not and it also stopped happening -- so I guess you can close this issue. It was right at the time when we had the timeout issues :)


Get Info about Country

https://twitter.com/marcelcutts/status/959437209102438400

Done for all that I could


Latest Python does not supported

Description of the feature request:
Latest Python does not supported the streamlit for deployment
What problem are you trying to solve with this feature?
No response
Any other information you'd like to share?
No response

@safwaahmad,
We see that the issue template has not been filled, could you please do so as it helps us analyze the issue [SDK version, steps followed before you ran into this error or stand alone code/colab gist to reproduce the issue faced and reopen this issue. Thanks!


Rails 3

I've modified the source code to work with rails 3, and tweaked Readme install instructions.  Should probably mark as a new gem version when merged to master.

Hi.  I tried to install this plugin for rails 3.2 but it was requiring activesupport as opposed to active_support.  Was this supposed to be pulled in?
thx!


Plan to create a library?

Hi @currocam ,
Amazing work done here!  It is a nice resource for the community.
However, do you think you'd like to create a lib? It would be great as it would be easily incorporated into other crates.
I can contribute and write most of the code if you want.
Thanks.

Hi @Ebedthan Thank you very much! It sounds great, let's do it.
Are you planning to use the library? If so, for what? This was a project I did for my MSc, so I have slides about it (some diagrams could be useful for docs)
In this project I implemented 3 different algorithms.

Canonical, as done by Quicktree. I think this would be the most useful thing to move to a library. It is pretty standard and, in fact, it does fairly well in performance. During my benchmark, it did always better than Quicktree (implemented in C). For big sizes, N=30.000 sequences tt was around one hour faster.

The RapidNJ algorithm with B-trees, in the same spirit as the RapidNJ program. This algorithm in faster than the canonical (the previous one), for n>11000, but it uses more memory. This rust version is far from being as optimized as the original RapidNJ one (and I think it will never be😂). The B-trees data strcutures are from the standard library, and I think making it faster would require custom implementation, additional tricks and using external memory. A version using Red black trees (change would be straightforward), should be slower but use less memory. I think this would be the second most useful to have in a crate.

A mix of the previous one, that sometimes was faster for intermediate sizes. I don't think this is worthy to put in a library.

That said, I agree it could be handy to have such library! I think that, I practice, you don't make trees for such big values of n. And, if you do, then you are running it separately in a cluster and saving the newick file.
What do you think? By the way, I've checked out your profile, very cool projects!

Yes, I plan to use it. And it would be really useful to have a library allow us to create NJ trees in rust (we don't have such things right now).

Cool! Do you have any about of how the public API of such library should look like?

Yes, I think of a set of pub fn like:
create_naive_nj(distance: Vec<Vec<f64>>) -> Tree
create_rapid_nj(distance: Vec<Vec<f64>>) -> Tree
could be really useful to start with, Then after some iterations, some useful functions could be added like
to_qmatrix(distance: Vec<Vec<f64>>) -> QMatrix
But I think that such a project should first concentrate on providing the function to create a NJ from a matrix and then some optimization could be done which generally take more iterations.

Hi!
I've found some time today to start working on this. The code is a bit spaghetti. But I got something that kind of works.

As far as I understand, the crate should provide:
1- Read from Phylip matrix (as it is the most common input file to the Distance Matrix data structure)
2- Create your own distance matrix (which is straightforward, just a vec of vecs and a vec of labels)
3. The two (maybe three) algorithms to solve the actual problem. The interface of the functions is a bit weird. For example, the rapid_nj expects the chunk_size (for parallel processing, if threads are given). I don't know how parallelization works for traits. So, (a) make a simpler API with no parallelization or (b) I think it would be nice to have a NeighborJoiningBuilder so there is a nice interface to tune the algorithm.  For example, doing stuff like
let dist_mat = DistanceMatrix::new ( ... )
pub enum Algorithm {Canonical, RapidNJ, Hybrid}
let canonical = NeighborJoiningBuilder::new(Canonical);
let tree = canonical.solve(dist_mat);
let rapid = NeighborJoiningBuilder::new(RapidNJ).set_chunk_size(10);
let tree = rapid.solve(dist_mat);

My implementation of undirected graph to newick might not be the best but it might be handy (in addition to all the functions Petgraph already has)
Also, maybe expose the functions I used for property testing and compute distances between trees.

So, as a summary: (1) input struct with read or construct methods, (2) algorithm struct (with builder pattern),  (3) function to newick, (4) function to compare trees.
I have created a PR. You are more than welcome to help if you want! Also, if you have any suggestion / improvement, please tell me :) I think making such API would be nice. Later, I would like to add the docs and use anyhow (better error handling)

Great work @currocam!
Yes, I agree that the QMatrix will stay as an internal data structure unless we have a good reason.
The work you did is already great for a start and we can start with it.
I will work on improving the error handling. I would like to go for something like thiserrror which is great for lib error management If you are okay with it.
Congrats on the work already done! I am eager to use it in my future work!

Great! If you are more familiar with this crate, then we should definitely go for it.

Great! If you are more familiar with this thiserror, then we should definitely go for it.

Hi!
I have created the library and published it. I am afraid I don't have more time to spend in this project right now, but, please, feel free to contribute with the error handling. That would be great. Or any other idea you have about best practices.
You can find the docs here (I made what I hope is a nice API) and the crate page here
I will leave this issue opened until I hear from you :)

Yes, thanks. I have seen the lib page.
I will do a PR in the coming days on the error handling.
(By the way, you can close this issue).
Best.


Accessing members of Tuple<> results in "undefined" values

        var edgeIndexes = new Tuple<int, string>(4, "67");
        Console.WriteLine(edgeIndexes.Item1);
        Console.WriteLine(edgeIndexes.Item2);

results in:
undefined
undefined
I'm looking for an alternative to help performance of functions that contain more than "one" out parameter.  The thought was to return a Tuple<> and pick off the members on the calling side.  The alternative of providing a small collection class for each combination is doable, but a bit tedious.

Can you
return new { a = 4, b = "67" };

in these scenarios? Would that be sufficient? It'll work since it doesn't rely on System.Tuple, the compiler generates a type.

Best I can tell, the return type has to be object, and then the calling side would have to use reflection to pick off the pieces by name.  This would make the C# code slower (which we still have to use in our mobile apps), and I don't think it's supported in your translator - nor would I ever expect it to be possible.  I've already had to remove any instance of FieldInfo and MethodInfo and re-write this sections as big switch statements.
Somebody else suggested that I try making a template class with 2 types, and another with 3 to simulate the Tuple.  Would you expect this work?

Just tested, it was dirt easy to try.  It works fine, but it comes at a cost of readability - same as the tuple<> class.  I'm probably going to stick with small collection classes so that everything is named and nobody gets confused on the calling side and gets the values backwards.
You could probably easily include this mechanism as a translation, and just cap it at 10 values.
    public class Values_2<T1, T2>
    {
        public readonly T1 Value1;
        public readonly T2 Value2;

        public Values_2(T1 v1, T2 v2)
        {
            Value1 = v1;
            Value2 = v2;
        }
    }

    public class Values_3<T1, T2, T3>
    {
        public readonly T1 Value1;
        public readonly T2 Value2;
        public readonly T3 Value3;

        public Values_3(T1 v1, T2 v2, T3 v3)
        {
            Value1 = v1;
            Value2 = v2;
            Value3 = v3;
        }
    }

    public static void Run()
    {
        var temp = new Values_2<int, string>(4, "A67");
        Console.WriteLine(temp.Value1);
        Console.WriteLine(temp.Value2);

        var temp2 = new Values_3<double, string, bool>(4.6, "Test", true);
        Console.WriteLine(temp2.Value1);
        Console.WriteLine(temp2.Value2);
        Console.WriteLine(temp2.Value3);

}

It sounds like Tuple is the way to go then.
FYI, FieldInfo and MethodInfo should totally work. There are already plenty of test cases for them. Report any issues please :-D

I just want to clarify, Tuple is not implemented yet right?  So, we have to make our own classes to mimic the Tuple class?


New 11 digit numbers in Brazil to be added

Currently libphone marks 11 digit Brazilian phone numbers as valid only if the first digit after the country code is 9. Recently Brazlian carriers added numbers such as +5548490420375 where the overall number is 11 digits long and the first number after the country code is a 4.
Validation needs to accommodate 11 digits Brazlian phone numbers where the first number after country code is a 4, as those are now in use by carriers in Brazil.

+1

@rzaryan and mateusmoura
Thank you for taking the time to improve libphonenumber!
We are supporting other 11 digit numbers that start with [2378] as well. Ex: +5522990420375. Brazil has been migrating from 10 to 11 digits by inserting a 9 before the last 8 digits. But the number you have mentioned do not have 9 before last 8 digits.
We were not able to connect to +5548490420375, please provide some other valid numbers. We are not able to find official evidence  as well.  We can't support single numbers, we need context about the prefix that makes them valid. Please share any official evidence you may have. See our guidelines.
Are these numbers mobile / landline?

Hello,
some valid numbers:

5531994772712
55031994772712
5531998563256
55031998563256

Changed only numbers mobile others continue normal.
Then the mask must accept 10 or 11 digits.
Thanks! ;)

@penmetsaa  Thanks for responding... I have not activated any of these numbers as I can't validate them yet via the libphone. They are all for sale within Twilio and I plan on buying a bunch of them for my Brazilian clients once they are added to the libphone. See attached screenshot within Twilio's interface for buying phone numbers to use in your applications.

@mateusmoura Are you reporting an unrelated issue? Every single one of the numbers you supplied is already identified as valid and mobile by the library.

Sorry @dlyongemallo
the version in my project is older! Now it is working!
Thanks!

@rzaryan
The library strives to reflect the real world. +5548490420375 is not connecting so the library is working as intended when it says it's "invalid".
Please give us 11-digit numbers that start with 4 and are already active. You mentioned in the first comment that "those are now in use by carriers in Brazil", can you give examples?

@keghani Twilio is a cloud communications vendor that sells phone numbers and allows developers to program what those phone numbers do -- be it for a IVR type of setup or for uses such as Uber facilitating text messaging between a driver and a person. They only sell valid phone numbers that actually work, and I wanted to make sure you had a good example to draw on when making this update.
I bought one of the new phone numbers from Twilio and manually set it up. If you call this number it should direct to one of our clients (Sheraton hotel in Salvador, State of Bahia, Brazil)
+5548490420386

@rzaryan +5548490420386 does not connect either.

Closing as none of the reported numbers were valid, the library is working as intended.
Please open a new issue following the contribution guidelines if there are valid Brazil numbers that we need to support.


intl 0.19.0

Hello. I change the version of the intl package from 0.18.0 to 0.19.0 to solve the compilation problem in the new stable version of flutter 3.22.0

Related #363. Sorry I was forgetting about this plugin. I've just realized from buymeacoffee.

Unfortunately with intl 0.18.1 I get:
Because flutter_calendar_carousel >=2.4.3 depends on intl ^0.18.1 and every version of flutter_localizations from sdk depends on intl 0.19.0, flutter_calendar_carousel >=2.4.3 is incompatible with flutter_localizations from sdk. So, because travelvu depends on both flutter_calendar_carousel ^2.4.3 and flutter_localizations from sdk, version solving failed.
But it can be worked around by each flutter project like this:
dependency_overrides:
  intl: ^0.19.0


Support hybrid Open Cloud usage to reduce dependence on cookies

Some users are experiencing issues with cookies getting cancelled by Roblox. This makes CI integrations harder to manage. We can introduce a hybrid setup so that if an Open Cloud token is available, Mantle will use it for operations that it supports. Mantle will still require cookie auth for many APIs but since the most common API it uses is probably the place upload API, this should significantly help users with CI stability.

For a possible workaround, see https://github.com/marketplace/actions/savetoroblox

This was implemented in v0.11.15


update rio-tiler and refactor overviews

This PR does:

Update for rio-tiler 2.0b2 (COGReader)
add changes from #91 (using in-memory/temp file)
add merge cli to create high resolution image from a mosaicJSON 🤷♂

cc @kylebarron

How does merge differ from overview?

add merge cli to create high resolution image from a mosaicJSON 🤷♂

That's not what I'd expect from cogeo-mosaic merge... I would've expected merge to combine multiple MosaicJSONs..

add changes from #91 (using in-memory/temp file)

To be clear I never succeeded in that PR in low-memory use by iterating over windows. When I used it I still ended up having huge amounts of data stored in memory at once. You could see that the output file held 0 bytes until the entire process was finished.

@kylebarron

To be clear I never succeeded in that PR in low-memory use by iterating over windows. When I used it I still ended up having huge amounts of data stored in memory at once. You could see that the output file held 0 bytes until the entire process was finished.

This might be due to GDAL Cache, you can try setting GDAL_CACHEMAX really low and see how it goes

That's not what I'd expect from cogeo-mosaic merge... I would've expected merge to combine multiple MosaicJSONs..

renamed the cmd to mosaic-to-cog

renamed the cmd to mosaic-to-cog

you don't like just overview?

this is replacing the merge command @kylebarron


phrase-cli: 2.33.1 -> 2.34.1

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/phrase/phrase-cli/releases.
meta.description for phrase-cli is: PhraseApp API v2 Command Line Client
meta.homepage for phrase-cli is: http://docs.phraseapp.com
meta.changelog for phrase-cli is: https://github.com/phrase/phrase-cli/blob/2.34.1/CHANGELOG.md
Updates performed

Golang update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact
Checks done

built on NixOS
The tests defined in passthru.tests, if any, passed
found 2.34.1 with grep in /nix/store/h10zanyn2yp1bazkzilwnynysc71z3cs-phrase-cli-2.34.1
found 2.34.1 in filename of file in /nix/store/h10zanyn2yp1bazkzilwnynysc71z3cs-phrase-cli-2.34.1

Rebuild report (if merged into master) (click to expand)

2 total rebuild path(s)

2 package rebuild(s)

First fifty rebuilds by attrpath

phrase-cli

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/h10zanyn2yp1bazkzilwnynysc71z3cs-phrase-cli-2.34.1 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A phrase-cli https://github.com/r-ryantm/nixpkgs/archive/3b4d2f4c5c9e352d89179fb5664582e30d676efd.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/3b4d2f4c5c9e352d89179fb5664582e30d676efd#phrase-cli

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/h10zanyn2yp1bazkzilwnynysc71z3cs-phrase-cli-2.34.1
ls -la /nix/store/h10zanyn2yp1bazkzilwnynysc71z3cs-phrase-cli-2.34.1/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
nixpkgs-review result
Generated using nixpkgs-review.
Command: nixpkgs-review

x86_64-linux

:white_check_mark: 1 package built:

phrase-cli

Maintainer pings
cc @juboba for testing.

[!TIP]
As a maintainer, if your package is located under pkgs/by-name/*, you can comment @NixOS/nixpkgs-merge-bot merge to automatically merge this update using the nixpkgs-merge-bot.

Add a :+1: reaction to pull requests you find important.

nixpkgs-review result
Generated using nixpkgs-review.
Command: nixpkgs-review pr 360129

aarch64-darwin

:white_check_mark: 1 package built:

phrase-cli


Revert "Siouxcide"

Reverts Goob-Station/Goob-Station#506
#506 is stupid, its literally a felinid nerf PR disguised as a fix PR.
do i need to explain why barring an entire species from command is a bad idea?
(this doesnt revert the age req fix though)

"mald PR" yes this is a mald PR

Not disguised as a "fix"

bruh, i would say "1984" but that would degrade my actual argument.

so your telling me that nanotrasen is no longer hiring an entire species as command, and also that felinids are now far worse than humans as opposed to just slightly worse. #506 should have been three different PRs not one, and it certainly shouldnt have been merged instantly.

so your telling me that nanotrasen is no longer hiring an entire species as command

yes

so your telling me that nanotrasen is no longer hiring an entire species as command

yes

do we need to copy TG though? if this is your reasoning then ban all non humans from command.


update plugin on pub.dev

On pub.dev package is not updated, kindly update the new version that is moved to null safety

would love to see that, this is a widget I would definitely use


Exception in state module

I'm trying to set up salt-vault and getting the following exceptoins
When doing read_secret:
[ERROR   ] Failed to get token from master! An error was returned: Missing ']' in format string
[ERROR   ] Failed to read secret! CommandExecutionError: {'error': "Missing ']' in format string"}
Traceback (most recent call last):
  File "/usr/lib/python2.7/dist-packages/salt/cli/caller.py", line 197, in call
    ret['return'] = func(*args, **kwargs)
  File "/var/cache/salt/minion/extmods/modules/vault.py", line 48, in read_secret
    raise salt.exceptions.CommandExecutionError(e)
CommandExecutionError: {'error': "Missing ']' in format string"}
Error running 'vault.read_secret': {'error': "Missing ']' in format string"}

When doing list_secrets:
[ERROR   ] Failed to get token from master! An error was returned: Missing ']' in format string
[ERROR   ] Failed to list secrets! CommandExecutionError: {'error': "Missing ']' in format string"}
Traceback (most recent call last):
  File "/usr/lib/python2.7/dist-packages/salt/cli/caller.py", line 197, in call
    ret['return'] = func(*args, **kwargs)
  File "/var/cache/salt/minion/extmods/modules/vault.py", line 115, in list_secrets
    raise salt.exceptions.CommandExecutionError(e)
CommandExecutionError: {'error': "Missing ']' in format string"}
Error running 'vault.list_secrets': {'error': "Missing ']' in format string"}

What I'm doing wrong ?

Could you share the configuration section policies? I suspect that there might be something amiss there.

@carlpett yep, I used {grains[ec2_tags:Environment]}
changed to {grains[ec2_tags][Environment]} and that fixed it ..
Thanks

Great!


Clean up old implementation of metadata parsing and file computation inside of Project::load_data

Context

At the conclusion of all of the additive changes listed below,

https://github.com/AlexsLemonade/scpca-portal/issues/710
https://github.com/AlexsLemonade/scpca-portal/issues/711
https://github.com/AlexsLemonade/scpca-portal/issues/731
https://github.com/AlexsLemonade/scpca-portal/issues/732
https://github.com/AlexsLemonade/scpca-portal/issues/739
https://github.com/AlexsLemonade/scpca-portal/issues/735
https://github.com/AlexsLemonade/scpca-portal/issues/740

it is now possible to fully integrate these updates into the codebase and to clean up the old implementation of metadata parsing and file computation.
Solution or next step
Ultimately, this refers to

The unpacking of Project::handle_samples_metadata and pulling out Project::load_samples_metadata, Project::load_libraries_metadata, and adding a function which then updates Sample and Project aggregate values.
The changing of the references inside of Project::load_data

From Project::create_project_computed_file to Project::create_computed_file,
From Sample::create_sample_computed_file to Sample::create_computed_file

Going through the Project and Sample models and deleting any helper functions which are no longer in use after the rewiring.

According to the following comment: https://github.com/AlexsLemonade/scpca-portal/pull/773#discussion_r1651707595

Let's handle moving Modality and Format constants from the models to common.py
(@davidsmejia as per our conversation 2024-07-01)

Addressed in PR https://github.com/AlexsLemonade/scpca-portal/pull/788


zos: use pthread helper functions to implement missing functionality

zOS does not implement some pthread_barrier functions. So we will use the provided helper functions in src/unix/pthread*.

This PR seems to have a lot of unrelated commits.  Rebase gone wrong?

I will create separate PRs for each platform function implementation.

Can you add the relevant changes to uv.gyp too and ensure the commit log conforms to the style guide?  Thanks.

LGTM, can you rebase?

Cheers, landed in 00c0ff1.


[Feature request] Add to market action (nostr-market ext)

A simple button to add to market list
In the search option in nostr-market, once you find a merchant, you can buy directly, but once you close the page the search is gone.
Will be handy to have an option to add that merchant pubkey into your personal shopping list after you find it.

This is now possible in the new marketplace UI: https://motorina0.github.io/nostr-market-app/dist/#/


fix dataset links

Fixes documentation links to example datasets.
Resolves #349

@FlicAnderson Thanks it looks fine to me. Feel free to merge and close!


Unclear how to use data from props "this is undefined"

Hi,
I'm passing data through props as the component should just render it and not contain it. I'm unable to find a way to access these props as 'this' is not defined. It's probably me not understanding this flavor of javascript syntax.
For example:
    const my_labels = computed(() => {         console.log('generating labels')         console.log(this.chart_data)         let labels = [];         this.chart_data.forEach((item) => {           for (let i = 0; i < item.data.length; i++) {             labels.push(item.data[i].date);           }         });         console.log(labels);         return labels;     })

Hi, I think you are mixing composition-api and object-api. Composition-api does not have access to this.


Add support for polymorphic has_one to eager loading

Description
Polymorphic has_one relations are currently not supported by eager-loading it just throws an error that DataObject is not a valid data class.
Additional context or points of discussion
No response
Validations

[X] You intend to implement the feature yourself
[X] You have read the contributing guide
[X] You strongly believe this feature should be in core, rather than being its own community module
[X] You have checked for existing issues or pull requests related to this feature (and didn't find any)

PRs

#11204

PR merged. This will be automatically tagged by GitHub actions


Multiple signature in one request using eosjs

I have written a smart contract in which several action require multiple signature in one request. How to get the transaction signed by say user and admin and push to to the blockchain using eosjs?

You can check out this code if you're using Scatter,
https://github.com/EOSEssentials/Scatter/blob/master/readme.md#multi-part-signatures-involving-the-application-and-an-identity
You can also pass multiple keys into keyProvider or multiple awaited promises into signProvider which converge as a single array


[Protected var] Report 11308 "VAT Annual Listing"

Describe the request
Can you please make all variables from the requestpage of report 11308 "VAT Annual Listing" available as protected vars? This allows us to act upon the options when extending the report.
Please move below globals to the protected region:

WrongVATRegNoList
VATAnnualList
intYear
Minimum
IncludeCountry
Country

Additional context
x
Internal work item: AB#550475

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.
Build ID: 25470.

Availability update: We will publish a fix for this issue in the next update for release 25.
Build ID to track: 25584.


Where can I download the Dockerfile for the docker image quay.io/coreos/etcd-operator:latest?

Where can I download the Dockerfile for the docker image quay.io/coreos/etcd-operator:latest and other non-latest tags?  The various tags are listed at https://quay.io/repository/coreos/etcd-operator?tag=latest&tab=tags

I need to make some changes to the Dockerfile locally and then build my own image.
I have the source code of etcd-operator and vault-operator and searched for Dockerfile but I can't seem to find the relevant Dockerfile for quay.io/coreos/etcd-operator:latest.
Thank you very much.

https://github.com/coreos/etcd-operator/blob/master/hack/build/Dockerfile


Allow targeted seq cnv calling with different kits

Is your feature request related to a problem? Please describe.
We currently cannot run targeted seq cnv calling with different kits in one family.
Describe the solution you'd like
Re-use the old cnv/sv merging tool do this.
Describe alternatives you've considered
N/A
Additional context
N/A

@holtgrewe Any specific project, where this is an issue right now?

@xiamaz in our largest exome study


logs: Stop using the querystring module

querystring is now marked as deprecated in npm. Interestingly enough it's not in our package.json (!) and this was not failing in the tests b/c it's also a dependency of browserify.
Change-type: patch
Signed-off-by: Thodoris Greasidis<EMAIL_ADDRESS>
Resolves: #
HQ:
See:
Depends-on:
Change-type: major|minor|patch

Contributor checklist

[ ] Includes tests
[ ] Includes typings
[ ] Includes updated documentation
[ ] Includes updated build output

@balena-ci rebase

@balena-ci I self-certify!


Create a Database Model

As a technique team
I need to create a database
So that we could store promotions
Details and Assumptions

[document what you know]

Acceptance Criteria
Given [some context]
When [action taken]
Then [outcome observed]

What all attributes should the db have? Promotion id, active (Boolean to signify if promotion is active), discount amount, discount percentage etc.?
Is each promotion customer specific or product specific?

I don't think we could easily get access to the information about products for now. So, maybe we don't have to include it.
Besides, a promotion might not be a discount. It could also be "buy one get one". Therefore, maybe it's enough to store the promotion information as a string.


[ENH] boilerplate layer, streamlied extension contract

This PR streamlines the extension contract for adding more estimators. There are minimal breaking changes, imo these do not require deprecation due to changes affecting only buggy interfaces.
Changes:

the extension locus for bootstraps is moved to _bootstrap and _get_n_bootstraps with a clearly documented extension template. These are called from bootstrap and get_n_bootstraps.
Repetitive boilerplate code is moved to the space between public and private method.
Input checking is moved to a single function, and added to get_n_bootstraps where it was missing.
the unused (or buggy) groups argument is removed from get_n_bootstraps.

Q from meeting today: is X and y necessary in get_n_bootstraps? That is, isn't this always identical to the param, n_bootstraps?

Compatibility reasons
On Fri, Apr 12, 2024, 5:18 PM Franz Király @.***> wrote:

Q from meeting today: is X and y necessary in get_n_bootstraps? That is,
isn't this always identical to the param, n_bootstraps? Or, is this
present for compatibility reasons?
—
Reply to this email directly, view it on GitHub
https://github.com/astrogilda/tsbootstrap/pull/135#issuecomment-2052544869,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AFTOOHSQDN2PXPKXZRFS56DY5BFTRAVCNFSM6AAAAABGEJWXAWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANJSGU2DIOBWHE
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

... with ... ?

... with ... ?

sorry forgot to respond. compatibility with crossvalidation in sklearn, which has a get_cv method iirc.


Open Task Counter is now correct on Projects

421

@NolanChan verified fix in review app, working perfectly. Merging and deploying with next push. Thanks so much for the bug fix!!


[SPARK-15456][PYSPARK] Fixed PySpark shell context initialization when HiveConf not present

What changes were proposed in this pull request?
When PySpark shell cannot find HiveConf, it will fallback to create a SparkSession from a SparkContext.  This fixes a bug caused by using a variable to SparkContext before it was initialized.
How was this patch tested?
Manually starting PySpark shell and using the SparkContext

cc @andrewor14

oops, LGTM

Test build #59044 has started for PR 13237 at commit 2ddd5d0.

Test build #59045 has started for PR 13237 at commit 015c244.

Test build #59044 has finished for PR 13237 at commit 2ddd5d0.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/59044/
Test PASSed.

Thanks merging into master 2.0

Test build #59045 has finished for PR 13237 at commit 015c244.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/59045/
Test PASSed.


Release Version 3.0

This (currently WIP) PR is a complete reimplementation of cargo-lipo (what 2.0 should have been originally).
The main new features are:

Reimplementation following current best-practices, including a switch to the 2018 edition.
Use cargo_metadata to understand the project rather than some custom logic.
Automatically remove environment variables that can cause issues with build scripts.
Simplify integration with XCode build scripts: Automatically discover targets and profile from the environment.

This PR is still missing some tests (the basic functionality was manually tested, the XCode integration not at all).
Todo:

[ ] Add tests for:

[ ] Building a simple project
[ ] Building a workspace with multiple packages, only some of which are staticlibs
[ ] Building only specific packages in a workspace
[ ] Building a package with a build script and dependencies with build scripts

[ ] Improve CI:

[ ] Run & enforce no-warnings clippy
[ ] Run & enforce no-diff rustfmt

[ ] Improve Readme.md:

[ ] Document important options
[ ] Document XCode integration

Fixes #22.

Automatically remove environment variables that can cause issues with build scripts.

Does this mean I can probably get rid of nenv uses?

Automatically remove environment variables that can cause issues with build scripts.

Does this mean I can probably get rid of nenv uses?

Yes, once this PR is merged, this should mean exactly that!

@eoger:

Does this mean I can probably get rid of nenv uses?

I've just published version 3.0, which has the sanitization logic. If you're still having issues, I would love to hear about that.


treewide: fix updateScripts for all packages using gitUpdater

Description of changes
I noticed that https://github.com/NixOS/nixpkgs/pull/161144 broke my updateScript for git-review, and realized it also broke the updateScript for every other package now using gitUpdater except for bamf and iproute.
The problem is that url defaults to src.url, so packages using fetchFromGitHub, fetchFromGitLab, fetchFromGitea... broke, because those fetchers grab tarballs by default.
I was originally going to explicitly add the urls back to each of the broken packages, but then realized it would probably be better to prioritize src.meta.homepage over src.url in list-git-tags to avoid this in general.
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 169999 run on x86_64-linux 1

2 packages built:

common-updater-scripts
hubstaff


convert-to-for-of-loop / convert-to-foreach-loop linting and refactoring not working.

Hi @lgrammel,
Linting for convert-to-for-of-loop / convert-to-foreach-loop is not showing. Also, no refactoring option is available for to convert simple for loop to for-of loop.

Hi @chandan192 - thanks for the bug report. I was able to reproduce the issue and will look into a fix.

This is because record[i] is inlined. If you extract it into its own variable, the refactoring will become available. I'll look into extending the refactoring, so that the extraction is not necessary.

Hey @chandan192 - I finally got around to implementing your idea. It is available in version 1.71.0 and higher. Thanks for the suggestion!


removes arrow in breadcrumbs if no following folder or name

before

after

please add changelog

@FinalAngel thanks. changelog is updated


[Bug]: Drawer not working in  nuxt production

Reproduction
https://github.com/AloisH/drawer-shadcn-nuxt
Describe the bug
When building a nuxt application with a Drawer, the Drawer won't work.
You can reproduce it using the following github:
https://github.com/AloisH/drawer-shadcn-nuxt
$ npm run install
$ npm run dev # Work in dev mode -> http://locahost:3000 -> Big button with drawer
$ npm run build
$ node .output/server/index.mjs # Drawer not working anymore

System Info
System:
    OS: Linux 5.15 Ubuntu 22.04.3 LTS 22.04.3 LTS (Jammy Jellyfish)
    CPU: (12) x64 Intel(R) Core(TM) i7-9750H CPU @ 2.60GHz
    Memory: 12.75 GB / 15.58 GB
    Container: Yes
    Shell: 3.3.1 - /usr/bin/fish
  Binaries:
    Node: 18.20.3 - ~/.volta/tools/image/node/18.20.3/bin/node
    npm: 10.7.0 - ~/.volta/tools/image/node/18.20.3/bin/npm
    pnpm: 9.0.6 - ~/.local/share/pnpm/pnpm
    bun: 1.1.8 - ~/.bun/bin/bun
  npmPackages:
    nuxt: ^3.12.2 => 3.12.2
    radix-vue: ^1.8.4 => 1.8.4
    shadcn-nuxt: ^0.10.4 => 0.10.4
    vue: ^3.4.29 => 3.4.30

Contributes

[ ] I am willing to submit a PR to fix this issue
[ ] I am willing to submit a PR with failing tests

Linked to a prisma error (closing)


Allow for activation store to accept user and request information

Other ActivationStore implementations, Elasticsearch for instance, will need user and request information.
Description

Related issue and scope

[ ] I opened an issue to propose and discuss this change (#????)

My changes affect the following components

[ ] API
[ ] Controller
[ ] Message Bus (e.g., Kafka)
[ ] Loadbalancer
[ ] Invoker
[ ] Intrinsic actions (e.g., sequences, conductors)
[ ] Data stores (e.g., CouchDB)
[ ] Tests
[ ] Deployment
[ ] CLI
[ ] General tooling
[ ] Documentation

Types of changes

[ ] Bug fix (generally a non-breaking change which closes an issue).
[ ] Enhancement or new feature (adds new functionality).
[ ] Breaking change (a bug fix or enhancement which changes existing behavior).

Checklist:

[x] I signed an Apache CLA.
[x] I reviewed the style guides and followed the recommendations (Travis CI will check :).
[ ] I added tests to cover my changes.
[ ] My changes require further changes to the documentation.
[ ] I updated the documentation where necessary.

PG4 1863 ⏳

Codecov Report

Merging #3798 into master will increase coverage by 0.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #3798      +/-   ##
==========================================
+ Coverage   75.15%   75.16%   +0.01%
==========================================
  Files         132      132
  Lines        6142     6145       +3
  Branches      373      380       +7
==========================================
+ Hits         4616     4619       +3
  Misses       1526     1526

Impacted Files
Coverage Δ

...la/whisk/core/entity/ArtifactActivationStore.scala
92.85% <ø> (ø)
:arrow_up:

...main/scala/whisk/core/controller/Activations.scala
96.77% <100%> (+0.16%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 92a64c2...0140629. Read the comment docs.

@markusthoemmes, very concerned about this polling behavior. https://github.com/apache/incubator-openwhisk/blob/1d79fa395de32c6a774efeb4f53563689e9cbb7e/core/controller/src/main/scala/whisk/core/controller/actions/PrimitiveActions.scala#L585

@dubee concerned in which way? I believe this is the database fallback polling in case an active ack goes missing.

@dubee Can you share some more details on how Elasticsearch implementation would make use of user and request data. Would it like to use any aspect of request or we can extract explicit parts from request and pass it on.
For now it appears that passing request param is making SPI usage more coupled to web requests

@chetanmeh, certain Elasticsearch deployments require additional authentication which can be passed through the controller via HTTP headers. This allows the controller to communicate to Elasitcsearch for users making requests. Currently our Elasticsearch log store works in the same way. When required headers are specified via the OpenWhisk Ansible configuration for the log store, the log store will pass those headers from the client to Elasticsearch to perform a query.
See the log store for example:
https://github.com/apache/incubator-openwhisk/blob/92a64c291156a2cd3d6b304babc2a193a46d0699/common/scala/src/main/scala/whisk/core/containerpool/logging/ElasticSearchLogStore.scala#L103

@dubee Now its more clear. So we pass on some sort of "user context" to ES. May be we make that notion explicit via having a UserContext as parameter type
case class UserContext(user:Option[Identity], request: Option[HttpRequest])
-  def get(activationId: ActivationId, user: Option[Identity] = None, request: Option[HttpRequest] = None)(
-  def get(activationId: ActivationId, userContext: Option[UserContext] = None)(

PG2 3475 🔵

@markusthoemmes, anything else on this one?

@chetanmeh, where do you think the UserContext case class should live?

Added UserContext in the third commit. The case class definition should probably be moved elsewhere though.

PG4 2057 🔵

where do you think the UserContext case class should live

Adding it to ActivationStore looks fine

@markusthoemmes, any other comments on this one?

@mdeuser, can you review this one?


Update the EKS DPDK install section in the calico/vpp Getting Started

Description
Update the EKS DPDK install section in the calico/vpp Getting Started
doc with the new installation method using preBootstrapCommands.
Related issues/PRs
Todos

[ ] Tests
[ ] Documentation
[ ] Release note

Release Note
TBD

Reminder for the reviewer
Make sure that this PR has the correct labels and milestone set.
Every PR needs one docs-* label.

docs-pr-required: This change requires a change to the documentation that has not been completed yet.
docs-completed: This change has all necessary documentation completed.
docs-not-required: This change has no user-facing impact and requires no docs.

Every PR needs one release-note-* label.

release-note-required: This PR has user-facing changes. Most PRs should have this label.
release-note-not-required: This PR has no user-facing changes.

Other optional labels:

cherry-pick-candidate: This PR should be cherry-picked to an earlier release. For bug fixes only.
needs-operator-pr: This PR is related to install and requires a corresponding change to the operator.

Hi @caseydavenport, this is the other PR which needs merging. Just rebased it.

/sem-approve


docs(forge/inspect): Forge Inspect Subcommand Documentation

Overview
Added forge inspect documentation to cli/README.md.

nice nice

live by: leave it better than you found it :)


What about permissions?

Android runtime permissions prior to Android M is already handled inside the library.

Thanks

I don't see this for android.permission.READ_EXTERNAL_STORAGE if I want to use only camera.

@long1eu it is because we get the images from MediaStore.Images.Media.EXTERNAL_CONTENT_URI
I don't know why i have the permission lying around the manifest.


Add PitchShift operation

This PR is still a work in progress, but here is the gist of it:

I made a separate library called torch-pitch-shift that calculates pitch-shift targets that can be computed quickly using tensor operations beforehand. The PitchShift class basically just calls this library to transform each sample in the batch.
One caveat is that the current implementation requires the sample rate to be passed during the Compose process. I'm sure yall can figure something out, the current class is just a proof of concept.
I haven't added any tests. Please help! (the only demo file present is test.py at the root of the repo, which I'll have to delete later.)

The library I made is still undocumented, so I don't want to make it public just yet. If you want to verify that the code is not malicious, let me know so I can add you to the repo!

It's in a working and semi-usable state!
Input
# TODO: WRITE SOME REAL TESTS

import torch
from torch_audiomentations import Compose, PitchShift

# Initialize augmentation callable
apply_augmentation = Compose(
    transforms=[
        PitchShift(16000, p=1),
    ]
)

torch_device = torch.device("cuda" if torch.cuda.is_available() else "cpu")

# Make an example tensor with white noise.
# This tensor represents 8 audio snippets with 2 channels (stereo) and 2 s of 16 kHz audio.
import time

audio_samples = (
    torch.rand(size=(8, 2, 32000), dtype=torch.float32, device=torch_device) - 0.5
)

# Apply augmentation. This varies the gain and polarity of (some of)
# the audio snippets in the batch independently.
start = time.process_time()
perturbed_audio_samples = apply_augmentation(audio_samples, sample_rate=16000)
print(time.process_time() - start)

Output
1.53125

i haven't implemented any tests, I'll leave that up to you guys :)
plz let me know what you think of what I have so far!

Thanks for making this, and thank you for your patience. I'll have a look at this soon 👍

i tried using it in my own project, and it seems like there's a memory leak somewhere? vram usage keeps increasing when i include pitch shift. will investigate.

Interesting. The memory leak should ideally be fixed before we merge this :)

Thanks for the reviews, will

Alright gonna get some sleep now, good night 😴

Adding Batched_Pitch_Shift as a separate class might be a good idea. Currently working on batched shifting in the library itself :)

Implementation of batches transforms is done in the library! Will update the fork when I have time later.

timed in seconds. really liking how fast it runs! this is with 8 samples with sr=16000 and clips each 2 seconds long

@iver56 what's new:

wrote tests, they pass now :)
added 3 modes: per_batch, per_example, and per_channel. per_batch is default cuz it's fast
added assertions and error messages

Thanks for the improvements 👍 I will re-review this soon-ish (my availability is a bit limited, thanks for your patience)

I would like "per_example" to be the default mode. Although "per_batch" is faster, variation within each batch is typically a good idea when training models :)

The other transforms have "per_example" as the default mode too

Something happened to the commits after the force push - I can't see the commits in the pull request anymore

I think would also prefer a bit more modest default parameters - pitch shifting a whole octave up or down is a bit extreme. In audiomentations the default is -4 to +4 semitones. -4 semitones is down a third of an octave, and +4 semitones is up a third of an octave. This default would give a range of two thirds of an octave.
In audiomentations, the pitch shifting parameters are input as semitones. Could that be relevant here too? I personally find it easier to relate to the numbers when they are given in semitones (e.g. -12 and +12) instead of fractions (e.g. 0.5 and 2.0)

@iver56 I think what happened is that the force push overwrote all my commits. I'll patch it up and open a new PR


attempt local face detection

The app keeps hitting the Rekognition API quota, and doing detection in a library would make the responses happen much faster. Suggested libraries (based on a couple hours of research):

http://cmp.felk.cvut.cz/~uricamic/flandmark/
ASM

https://code.google.com/p/asmlib-opencv/
http://blog.greatyao.me/2012/05/06/Introduction-to-ASMLibrary/

LBP
http://webcache.googleusercontent.com/search?q=cache:ioIRRRgx0xYJ:answers.opencv.org/question/313/facial-feature-detection/+&cd=2&hl=en&ct=clnk&gl=us
OpenBR
facedetect
OpenFace
clmtrackr

will keep adding to this list

Using Docker might make this a lot easier:
https://github.com/steeve/docker-opencv

OpenBR

Did you give tracking.js a try? https://trackingjs.com/examples/face_tag_friends.html

I haven't! Would happily accept a pull request for anything.

Extra points for OpenCV:
http://www.pyimagesearch.com/2016/06/20/detecting-cats-in-images-with-opencv/

maybe you can use this:
https://trackingjs.com/
I know it not ruby but maybe reconding in nodejs would lead to a faster application

Most of the actual detection code for the libraries above is in C/C++, but I'm open to anything at this point!
Note that any new detection code would be added to https://github.com/afeld/face_detect.

@afeld I've been working on a small node.js face detection app and have a docker container built if you think it might be of use. https://github.com/neufeldtech/funnyface.

https://www.npmjs.com/package/faced

Faced looks really promising and since its using OpenCV this should be incredibly fast :D

Faced looks good!

Hey !
Checkout this API : FacePlusPlus

Hey @afeld check above suggestions. They look promising.

Yep, open to any of them, with a strong preference for local rather than an external API (for $$ and latency reasons). Pull requests welcome!

I've been itching to whip something up recently- AWS Lambda has come a long way w/r/t python packaging. I recently learned you can boot a aws linux docker container and build out your compiled deps, in this case opencv, and bundle that compiled virtualenv with your deployment payload.
Could be neat! I hope to have some free time to try this in the near future. Our hipchat has had a severe mustache shortage :flushed:


Runner Comparison / Capability Matrix revamp

The goal for this project has changed: We now want to create a completely new Capability Matrix that is based on the ValidatesRunner tests that we run on the various Apache Beam runners.
We can use the test in ./test-infra/validates-runner/ to generate a JSON file that contains the capabilities supported by various runners and tested by each individual test.
----------------------------------------------------

Discussion<EMAIL_ADDRESS>Summarizing that discussion, we have a lot of issues/wishes. Some can be addressed as one-off and some need a unified reorganization of the runner comparison.
Basic corrections:

Remove rows that impossible to not support (ParDo)
Remove rows where "support" doesn't really make sense (Composite transforms)
Deduplicate rows are actually the same model feature (all non-merging windowing / all merging windowing)
Clearly separate rows that represent optimizations (Combine)
Correct rows in the wrong place (Timers are actually a "what...?" row)
Separate or remove rows have not been designed ([Meta]Data driven triggers, retractions)
Rename rows with names that appear no where else (Timestamp control, which is called a TimestampCombiner in Java)
Switch to a more distinct color scheme for full/partial support (currently just solid/faded colors)
Switch to something clearer than "~" for partial support, versus ✘ and ✓ for none and full.
Correct Gearpump support for merging windows (see BEAM-2759)
Correct Spark support for non-merging and merging windows (see BEAM-2499)

Minor rewrites:

Lump all the basic stuff (ParDo, GroupByKey, Read, Window) into one row
Make sections as users see them, like "ParDo" / "side Inputs" not "What?" / "side inputs"
Add rows for non-model things, like portability framework support, metrics backends, etc

Bigger rewrites:

Add versioning to the comparison, as in BEAM-166
Find a way to fit in a plain English summary of runner's support in Beam. It should come first, as it is what new users need before getting to details.
Find a way to describe production readiness of runners and/or testimonials of who is using it in production.
Have a place to compare non-model differences between runners

Changes requiring engineering efforts:

Gather and add quantitative runner metrics, perhaps Nexmark results for mid-level, smaller benchmarks for measuring aspects of specific features, and larger end-to-end benchmarks to get an idea how it might actually perform on a use case
Tighter coupling of the matrix portion of the comparison with tags on ValidatesRunner tests

If you care to address some aspect of this, please reach out and/or just file a subtask and address it.
Imported from Jira BEAM-2888. Original Jira may contain additional context.
Reported by: kenn.

The following subtask(s) are associated with this issue: #18604


Bean Shell hangs when "Tab" key is pressed

Bean shell is wonderfull and i am using xbsh,however there seems to be a problem with xbsh....while typing when "Tab" key is pressed....it hangs. i use kubuntu.
-Ajay Kumar .N.S
Reported by: ajaykumarns
Original Ticket: "beanshell/bugs/289":https://sourceforge.net/p/beanshell/bugs/289

Need more info: how did you run bsh?

Can't reproduce. No info. Stale


Made Sign In and Sign Up Pages responsive.

Made Sign In and Sign Up Pages responsive. #27
Please tell in case there is any problem. I will work on it. Also since this issue has no difficulty tag attached, is it possible to get medium or higher level tag attached because understanding already written CSS was a challenge and it took me a complete day to understand the already written CSS and make changes to it.

hey @GauravGupta993
Everything is nice and fine
but

hey @GauravGupta993 Everything is nice and fine but it is not redirecting back to sign in page from the register page after clicking the sign in page can you check the issue I am adding hard label

Will do

Is this issue completed or do i need to do something else ?

Is this issue completed or do i need to do something else ?

it is approved I will merge it
I am testing some workflows on this pr 👍


babashka: 0.8.1 -> 0.8.2

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for babashka is: "A Clojure babushka for the grey areas of Bash"
meta.homepage for babashka is: "https://github.com/babashka/babashka"
meta.changelog for babashka is: "https://github.com/babashka/babashka/blob/v0.8.2/CHANGELOG.md"
Updates performed

Ran passthru.UpdateScript

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact

Checks done (click to expand)

built on NixOS
The tests defined in passthru.tests, if any, passed
found 0.8.2 with grep in /nix/store/wizwikfn3s8kzv6ndlp2gri7cfwd0d2n-babashka-0.8.2
found 0.8.2 in filename of file in /nix/store/wizwikfn3s8kzv6ndlp2gri7cfwd0d2n-babashka-0.8.2

Rebuild report (if merged into master) (click to expand)

5 total rebuild path(s)

3 package rebuild(s)

2 x86_64-linux rebuild(s)
3 x86_64-darwin rebuild(s)

First fifty rebuilds by attrpath
babashka
neil
obb

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/wizwikfn3s8kzv6ndlp2gri7cfwd0d2n-babashka-0.8.2 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A babashka https://github.com/r-ryantm/nixpkgs/archive/90fe3b144bcd2e05e1b44857e56d42340ea66a61.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/wizwikfn3s8kzv6ndlp2gri7cfwd0d2n-babashka-0.8.2
ls -la /nix/store/wizwikfn3s8kzv6ndlp2gri7cfwd0d2n-babashka-0.8.2/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

2 packages built:

babashka
neil

Maintainer pings
cc @bandresen @bhougland18 @DerGuteMoritz @jlesquembre @thiagokokada for testing.

Result of nixpkgs-review pr 171888 run on x86_64-linux 1

2 packages built:

babashka
neil


Is ZLUDA or Directml support possible?

Just wondering if a fork or supportt for ZLUDA/Directml for windows AMD machines is possible...

I'm sorry but I don't have the skills about this area at all. Hopefully someone else can answer this question for you.

I understand. Thank you for taking the time to respond :)


OIDC login via Instagram

References

https://developers.facebook.com/docs/instagram-basic-display-api/getting-started

Closing this as Instagram Basic Display API as it is "not an authentication solution".

Data returned by the API cannot be used to authenticate your app users or log them into your app. If you need an authentication solution we recommend using Facebook Login instead.


Callouts don't work or render if they part of a list item

I am using this in my docusaurus based site (v1). This works really great but I noticed it doesn't work very well inside list item. For example, my markdown could be:
- list item 1

    Brief description of this list item

    :::tip
    Here's a tip in this case
    :::

- list item 2

The above mardown snippet does get rendered properly except the tip.
If you need more details, please let me know. Thanks.

Thank you for reporting, I'll check it soon and I'll update you

Hi, this has been solved thanks to @mterrel! Closing this


Self-closing tags

I'm having a problem with self-closing tags. I have jade installed at v1.11.0 and grunt-contrib-jade installed at 0.15.0, but if I have, for instance, a meta tag in my jade file, it doesn't get closed in the outputted html.
I know this was brought up before as a problem with jade, but if i do echo "meta" | jade at the command prompt it gets closed fine, so it isn't just a jade problem.
Unfortunately this is causing the concat:generated from usemin to not properly read the source and so is causing all sorts of problems.
Edit: A temporary solution seems to be flushing like so:
<!-- -->
<!-- build:js /scripts/app.js -->
script(src="/scripts/test.js")
<!-- -->
<!-- endbuild -->

grunt-contrib-jade v0.15.0 successfully compiles meta to <meta/>. Maybe other tools affect the result.


CUDA Error: no CUDA-capable device is detected

`0 CUDA Error: no CUDA-capable device is detected
CUDA Error: no CUDA-capable device is detected: Bad file descriptor
[darknet_ros-1] process has died [pid 15933, exit code -6, cmd /home/zaphkiel/catkin_ws/devel/lib/darknet_ros/darknet_ros __name:=darknet_ros __log:=/home/zaphkiel/.ros/log/c17b16f2-4839-11eb-aa2e-f0038c4d290f/darknet_ros-1.log].
log file: /home/zaphkiel/.ros/log/c17b16f2-4839-11eb-aa2e-f0038c4d290f/darknet_ros-1*.log
`
how can i fix this error?

Hey. Same issue how to solve it?

Does nvidia-smi show you any results?

nvidia-smi no result for me

I am having this same error as well. I am using VMWare with Ubuntu 18.04. Is there a way to run darknet without needing a CUDA GPU?

I'm having the same problem, the nvidia-smi output comes out like this

If you don't have / want to use a NVidia GPU, don't install CUDA on your system.
Try commenting out line 17 https://github.com/leggedrobotics/darknet_ros/blob/master/darknet_ros/CMakeLists.txt#L17 of the CMakeLists.txt when you get CUDA errors but you don't have a CUDA GPU.
If you do see output, like @leeisack , then you actually should not get this error. Try running darknet with the following environment variable set:
CUDA_VISIBLE_DEVICES=0, this will instruct CUDA to only make the first device visible.
(In a single bash session for example, run export CUDA_VISIBLE_DEVICES=0)

If you don't want to use GPU, you can delete "find_ package(CUDA QUIET)" in Cmakelists

I solved this, thank you

@leeisack could you please share how you solved it?

Well... I don't know we build the same problem first. However, in the case of me, the driver was automatically installed when cuda was installed, but if you do this, the latest driver is installed and the version of cuda is automatically increased. So, I installed the driver and cuda by setting the correct version separately.

@leeisack
Thank you for your reply. Can you maybe share what you mean with "So, I installed the driver and cuda by setting the correct version separately."? Maybe you can provide us with the commands you used.

i still have the same problem.

my nvidia-smi;

I didn't use a special method... It was solved by installing the driver according to the gpu version I am using. It seems that cuda and cudnn are installed according to the driver. So, in my case, I wanted to install the old versions of cuda and cudnn, but since the gpu is gtx1080, relatively latest version of the driver was installed and cuda and cudnn were automatically upgraded.
As a result, it was resolved by completely removing cuda, driver, and cudnn, and installing all three by entering the desired version directly. There is nothing I can advise other than this...

I dont know which version required to be installed according to my gpu.
When i choose GPU as hardware acceleration from notebook settings, gpu is not connected to backend. Can be it caused of this problem?

From: Lee Isack @.>
Sent: Friday, May 28, 2021 9:22:14 AM
To: leggedrobotics/darknet_ros @.>
Cc: tayfurg7 @.>; Comment @.>
Subject: Re: [leggedrobotics/darknet_ros] 0 CUDA Error (#288)
I didn't use a special method... It was solved by installing the driver according to the gpu version I am using. It seems that cuda and cudnn are installed according to the driver. So, in my case, I wanted to install the old versions of cuda and cudnn, but since the gpu is gtx1080, relatively latest version of the driver was installed and cuda and cudnn were automatically upgraded.
As a result, it was resolved by completely removing cuda, driver, and cudnn, and installing all three by entering the desired version directly. There is nothing I can advise other than this...
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHubhttps://github.com/leggedrobotics/darknet_ros/issues/288#issuecomment-850172200, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ATPWFC4KTV6VSFXTMYGG4KLTP4ZBNANCNFSM4VKYCSLA.

i still have the same problem.  my nvidia-smi;

did you solve the issue?


turkish localization

added 3 string resources just to change "select country", "no results found" and "search" texts

Thank you for the PR, but I can't merge this because it won't integrate with the current library. Could you translate both the  library/src/main/res/values/strings.xml and library/src/main/res/values/strings_country.xml so I can merge your PR? You can create the Turkish translation to library/src/main/res/values-tr_TR/

values-tr.zip
here is values-tr if you want to add, cheers

Thank you for the translation. I have added it and adding your user name to credit ;)


Engine crashes when changing the focus of the window

Bug description
When changing from one GUI template to another, if one changes the focus of the Godot window while the files of the new template are being copied, and then comes back to Godot, the engine crashes (doesn't respond to clicks) and the only way to solve it it's by force-closing the process (using the Task Manager).
Steps to reproduce

Open the Setup popup and change to one of the following templates: 9 Verbs, Sierra or 2-click Context-sensitive (it's easier with any of this because the process takes longer).
After confirming the change, and once the copy process starts showing that it is in progress, change the focus of the Godot's window to another one (or change to another virtual desktop).
Go back to Godot. The popup that shows the process will keep visible, preventing interaction with the engine.
The popup won't close. (it seems that the copying process itself has stopped).

Expected vs observed behavior
If the process is stoping, it should continue no matter where the focus of the OS is. In case the process continues, the blue window popup should close itself once it finishes. And there is no way to close it manually.
Environment information (please complete):

OS type and version: Windows 11
Godot version: 4.2.1
Plugin version or branch: Beta 1

Additional context
I tested this in Ubuntu and the same happens.

Will be fixed with #163


Update 0L project link

The 0L github organization has been renamed. Announcement: https://discord.com/channels/833074824447655976/923114375122931732/1053116482298576968.

Hi @willrnch Thanks for updating this link. Would you please submit the PR against the main branch instead of devnet? Thanks!

@randall-Mysten https://github.com/MystenLabs/sui/pull/7376


Change how false/true positives/negatives are calculated

Only compute TP, FP = pred_count - TP, FN - gt_count - TP
Move IoU computation outside of class/confidence loop => much faster
Use boolean mask of IoU instead of IoU => faster

You may not like this change since I change the definition of FP you give in README.
I don't want to count class z predicts gt x in class x.
The problem is that:

It's not a problem of class x, rather problem of class z, so it shouldn't affect precision of class x.
When you count it, for one prediction you may get 2 FP. One in class z, one in class x. Kind of wrong IMHO.
So, it's up to you to accept it or not.
Thanks for the code, anyway.

Hi mrshurik,
I believe you are right, thanks for pointing that out, but indeed class z prediction should not affect the precision of x. I merge your code, update the tests and ReadMe.
Thanks for your contribution!


Merging Games and Fun Section and Making it Responsive

Please assign me this @ghulamyazdani

go ahead @snahashisk !!


Call listeners asynchronously to debounce updates

Suppose you have 20 listeners, and you get a bulk update in from the server and dispatch a bunch of actions all at once. Then those listeners will each be called once for each applied action.
I think it would be nice to debounce this with a setTimeout 0 and a dirty flag so they only get called once after the JS event loop clears.
The code in question is at https://github.com/gaearon/redux/blob/848bb8e175715bedaccd10bbcbe62b1dbbe09ffa/src/createStore.js#L109

So the problem is, how to intercept the listener chain using a store enhancer, since the core version will remain as-is.
Alternatively, debounce actions and bulk-update state with before passing an action with the complete new state to a wrapped store with a single reducer?

Explanation about why to keep core version pure:

This is where I chime in and advertise how fun our Slack channel is and how you should totally join it

Seconded - http://reactiflux.com, channel #redux

I just published a package redux-batched-subscribe which allows for debounced subscribe notifications (or using batchedUpdates from react)

redux-batched-subscribe appears to solve this problem.


Validation of server identify in a CaaS environment #358

@NicholasAzar Changes have been checked in. Please review.

@dz-1 Yeah, working on it! Just need to spend a bit of time setting up a local test to ensure everything's still working

Verified mTLS still works (expected fail):
Statistics        Avg      Stdev        Max
  Reqs/sec       298.14     585.49   10628.82
  Latency      512.83ms   301.55ms      2.81s
  HTTP codes:
    1xx - 0, 2xx - 0, 3xx - 0, 4xx - 0, 5xx - 0
    others - 2479
  Errors:
    remote error: tls: bad certificate - 2479
  Throughput:     1.84MB/s

Verified happy path still works:
Statistics        Avg      Stdev        Max
  Reqs/sec     72647.93   10670.97   94776.09
  Latency        1.72ms     4.29ms   384.78ms
  HTTP codes:
    1xx - 0, 2xx - 726205, 3xx - 0, 4xx - 0, 5xx - 0
    others - 0
  Throughput:    18.52MB/s

MTLS Sample Timings:
    data_received..............: 270 MB  4.5 MB/s
    data_sent..................: 116 MB  1.9 MB/s
    http_req_blocked...........: avg=2.19µs   min=0s      med=0s       max=229.99ms p(90)=1µs      p(95)=1µs
    http_req_connecting........: avg=8ns      min=0s      med=0s       max=2.03ms   p(90)=0s       p(95)=0s
    http_req_duration..........: avg=233.32µs min=77µs    med=210µs    max=125.04ms p(90)=309µs    p(95)=360µs
    http_req_receiving.........: avg=17.11µs  min=3µs     med=13µs     max=75.06ms  p(90)=17µs     p(95)=25µs
    http_req_sending...........: avg=27.67µs  min=10µs    med=21µs     max=100.2ms  p(90)=25µs     p(95)=32µs
    http_req_tls_handshaking...: avg=1.66µs   min=0s      med=0s       max=228.48ms p(90)=0s       p(95)=0s
    http_req_waiting...........: avg=188.53µs min=0s      med=170µs    max=125ms    p(90)=262µs    p(95)=299µs
    http_reqs..................: 2703697 45061.313876/s
    iteration_duration.........: avg=306.21µs min=105.5µs med=268.71µs max=242.28ms p(90)=400.54µs p(95)=501.05µs
    iterations.................: 2703693 45061.247209/s
    vus........................: 20      min=20 max=20
    vus_max....................: 20      min=20 max=20

Verified one-way TLS still works:
Statistics        Avg      Stdev        Max
  Reqs/sec     71607.72   10502.07   96170.75
  Latency        1.74ms     4.52ms   419.07ms
  HTTP codes:
    1xx - 0, 2xx - 715896, 3xx - 0, 4xx - 0, 5xx - 0
    others - 0
  Throughput:    18.24MB/s

One-way TLS Sample Timings:
data_received..............: 274 MB  4.6 MB/s
    data_sent..................: 118 MB  2.0 MB/s
    http_req_blocked...........: avg=2.03µs   min=0s      med=0s       max=211.75ms p(90)=1µs      p(95)=1µs
    http_req_connecting........: avg=3ns      min=0s      med=0s       max=587µs    p(90)=0s       p(95)=0s
    http_req_duration..........: avg=225.74µs min=71µs    med=204µs    max=75.38ms  p(90)=300µs    p(95)=347µs
    http_req_receiving.........: avg=16.93µs  min=4µs     med=13µs     max=68.33ms  p(90)=17µs     p(95)=24µs
    http_req_sending...........: avg=27.36µs  min=10µs    med=21µs     max=75.37ms  p(90)=25µs     p(95)=31µs
    http_req_tls_handshaking...: avg=1.52µs   min=0s      med=0s       max=209.97ms p(90)=0s       p(95)=0s
    http_req_waiting...........: avg=181.44µs min=0s      med=165µs    max=68.49ms  p(90)=254µs    p(95)=289µs
    http_reqs..................: 2744219 45736.872701/s
    iteration_duration.........: avg=297.6µs  min=100.3µs med=262.89µs max=213.41ms p(90)=387.76µs p(95)=483.53µs
    iterations.................: 2744216 45736.822701/s
    vus........................: 20      min=20 max=20
    vus_max....................: 20      min=20 max=20


fix: Add missing quotes to block_duration_minutes

Description
Adds missing quotes to the block_duration_minutes value in spot_options.
Motivation and Context
Without these quotes terraform will think it's a resource and will throw an Invalid reference error :
│ Error: Invalid reference
│
│   on .terraform/modules/reactive_cluster.eks.eks/modules/self-managed-node-group/main.tf line 161, in resource "aws_launch_template" "this":
│  161:           block_duration_minutes         = lookup(spot_options.value, block_duration_minutes, null)
│
│ A reference to a resource type must be followed by at least one attribute access, specifying the resource name.

Breaking Changes
None
How Has This Been Tested?

[X] I have tested and validated these changes using one or more of the provided examples/* projects

Great, done @bryantbiggs. Thanks for the quick review!

This PR is included in version 18.7.1 :tada:


Fix bar-less text output

This is my attempt at fixing #447.
The code in draw_to_term is a bit of mess, with double definitions, complex branching, and I tried cleaning it up. I introduce a LineType enum to differentiate between text, bars and empty lines. The variables names have been renamed to reflect better what they represent. Some code has been shuffled around. Tests pass and I ran examples at random with no issues.
 Donec nec viverra massa. Nunc nisl lectus,
auctor in lorem eu, maximus elementum est.";

fn generate_logs(manager: &indicatif::MultiProgress, i: u32) {
    if i % 20 == 0 {
        let _ = manager.println(LOREM_BIG);
    } else if i % 10 == 0 {
        let _ = manager.println(LOREM_SMALL);
    }
}

fn main() {
    let display_manager = indicatif::MultiProgress::new();
    let bar = display_manager.add(indicatif::ProgressBar::new(100));

    for i in 0..100 {
        generate_logs(&display_manager, i);
        std::thread::sleep(std::time::Duration::from_millis(10));
    }

    for i in 0..100 {
        bar.inc(1);
        generate_logs(&display_manager, i);
        std::thread::sleep(std::time::Duration::from_millis(100));
    }
}

This is the output of the above before the PR:

Thank you for taking the time to review this. My tests omitted the --all-features flag and it shows. It did not help that this PR is the result of a caffeine overdose and subsequent insomnia. Comments duly noted this PR will either be force pushed or a new one will be opened with working tests and better commits. Thanks again !

Thanks! Force pushing is fine IME.

https://github.com/console-rs/indicatif/blob/5396704f8e9fe781d21a5475c8d3af292d0155fe/src/draw_target.rs#L554-L556
I think my main issue stems here. For wrapping lines, this calculation is not accurate. However the concept itself seems strange to me. Why fill the line with whitespace and expect the terminal to wrap instead of moving the cursor down when needed ? This means when resizing the terminal the formatting will fall apart.
Any objections to me investigating changing this behaviour ?

The new commit passes all the tests but two, and that is because the filler is not only printed when needed (removing one variable definition).  For wrapping lines, this calculation is not accurate. However the concept itself seems strange to me. Why fill the line with whitespace and expect the terminal to wrap instead of moving the cursor down when needed ? This means when resizing the terminal the formatting will fall apart.
Any objections to me investigating changing this behaviour ?

I never have objections to other people investigating things. 😄 Suggest reading git blame to figure out why this change was made, pretty sure it wasn't just for funsies.

The new commit passes all the tests but two, and that is because the filler is not only printed when needed (removing one variable definition).

Removing the empty writes from the test seems fine to me.

Suggest reading git blame to figure out why this change was made, pretty sure it wasn't just for funsies.

I believe this is working in tandem with this check:
https://github.com/console-rs/indicatif/blob/5396704f8e9fe781d21a5475c8d3af292d0155fe/src/draw_target.rs#L549-L551
This means that for everyline line other than the first one, a newline is added. The first is expected to wrap automatically due to the filler set in my previous comment.

This effectively fixes #447. I deeply want to keep going, because there is a lot of further refactoring that can be done, and the current solution of padding the last line will break any resizing. This is for future reference, the watermark to go back to if the PR spins out of control

In a rare moment of lucidity I will not change the line padding in this PR. It is now ready for review again @djc !

Alright, thanks for all your work on this!

Thank you, it was a pleasure, I just am travelling a lot at the moment. Cheers !


Enable PyPSA-USA to run state-level analyses

Feature Request
It would be amazing if PyPSA-USA supported state-level analysis! No idea what would be involved, but @ktehranchi has mentioned that he would provide guidance on how to do it. I can edit this feature request as our conversation develops.
Suggested Solution
No response
Additional Info
No response

Feature request ticket already exists in #292 !


No source checked and no outputs

Environment
"styled-components": "^3.4.10",  or the latest version 4@beta
"stylelint": "^9.6.0",
"stylelint-config-recommended": "^2.1.0",
"stylelint-config-styled-components": "^0.1.1",
"stylelint-processor-styled-components": "^1.5.0"

.stylelintrc
{
  "processors": ["stylelint-processor-styled-components"],
  "extends": [
    "stylelint-config-recommended",
    "stylelint-config-prettier",
    "stylelint-config-styled-components"
  ]
}

package.json  command
"stylelint './sr/**/*.{js, ts, tsx}' --formatter verbose"
Steps to reproduce

fresh normal create-react-app or typescript version project with the above versions

// styled-component code.
export const TestHello = styled.h1`
  fonttss-size: 1.5em;
      text-align: center;
  col--or: palevioletred;
  whatt: he~~ck;
`;

Expected Behavior
Should show me which lines have a problem such as "property-no-unknown"
Actual Behavior
$ stylelint './sr/**/*.{js, ts, tsx}' --formatter verbose"
0 source checked
0 problems found

are showned at the command line after running npm script.
If I install vscode extension, It works fine. Though I want to use it normally like the instruction on styled-components site. I followed all the steps and there is no source checked and no errors outputting. Maybe relates to #218 stylelint/stylelint#3261     I also added rules to .stylelintrc, still It's not checking any files. Maybe I've done something wrong

@lonyele Did you write a wrong glob pattern, './sr/**/*.{js, ts, tsx}'? Usually, you source files may locate in src.

Oh, sorry that's a typo. My project is using this one  "stylelint './src/**/*.{js, ts, tsx}' --formatter verbose"

@chinesedfan Yeah that's right. That is the weird part I think...    I cannot make it check any source. I've tested with any js, ts, tsx and also I tested with directly reference component something like `./src/components/MyComonents.tsx'
If It doesn't bother you, can you git clone my repo that can reproduce this problem and check what has been done wrong?   here is the repo https://github.com/lonyele/test-project-setting.git

@lonyele I didn't find  an offical glob specification, but if changed the pattern without inner spaces, it works.
-    "lint:css": "stylelint './src/**/*.{js, ts, tsx}' --formatter verbose",
+    "lint:css": "stylelint './src/**/*.{js,ts,tsx}' --formatter verbose",

I git clone it again and failed again...   It seems like there are no similar issues opened/closed. Probably something is wrong with my usage...     Thank you for checking it

yarn lint:css
I see "0 source checked"...

@lonyele In fact, after cloned your test repository without any changes, I can see 1 source(src/setupTests.js) is checked. And if changed like my previous comment, 9 sources will be checked.

I've tested with any js, ts, tsx and also I tested with directly reference component something like `./src/components/MyComonents.tsx'

If something like "npx stylelint test.js --formatter verbose" in your side still returns "0 source checked", that is really weird. Maybe you can clone your repository in another computer, or ask another friend to test. At last, I will close this issue because it should not be a problem of this processor.

Just the follow-up. I tested at new environment(Ubuntu) and It works fine...    something has been messed up with my laptop


Keybase NEEDS an auto logout timer

Keybase requires a auto logout timer if it ever can be considered a serious option for secure communication, having your KBFS mounted 247 if you forget to logout, letting anyone see your messages on a communal PC, preventing snooping on your phone.
This program is amazing but without a logout timer i cant use it.

I've been using sleepwatcher on mac to run keybase logout when my macbook sleeps or is idle for too long. It would be nice if Keybase had something like this built in.


Real-time pose estimation

Hi, I'm trying to use the DPVO to get the pose for each frame in a real-time fashion, for example, printing xyz and quaternion. Do you have any hints for this? Looking at the function https://github.com/princeton-vl/DPVO/blob/4f2f0cc7efbfe2547e788844412a3a2a72a923bd/dpvo/dpvo.py#L153 I'm trying to print lietorch.SE3(slam.poses_[-1]).data.cpu().numpy(), but I always get value [0. 0. 0. 0. 0. 0. 1.].
Here is the modified loop inside the run function of demo.py:
while 1:
        (t, image, intrinsics) = queue.get()
        if t < 0: break

        image = torch.from_numpy(image).permute(2,0,1).cuda()
        intrinsics = torch.from_numpy(intrinsics).cuda()

        if slam is None:
            slam = DPVO(cfg, network, ht=image.shape[1], wd=image.shape[2], viz=viz)

        image = image.cuda()
        intrinsics = intrinsics.cuda()

        with Timer("SLAM", enabled=timeit):
            slam(t, image, intrinsics)

        print(lietorch.SE3(slam.poses_[-1]).data.cpu().numpy())

What am I doing wrong?
Thanks in advance

You should be doing print(lietorch.SE3(slam.poses_[n-1]).data.cpu().numpy())

Internally, DPVO stores poses as a mapping from world coordinates to camera coordinates. The actual camera poses are the inverse of this, i.e. a mapping from camera coordinates to world coordinates. So to return the correct camera poses per-frame, you should actually do
lietorch.SE3(slam.poses_[n-1]).inv().data.cpu().numpy()
FYI different datasets and libraries represent rotation quaternions differently, usually either [qx, qy, qz, qw] (e.g. lietorch) or [qw, qx, qy, qz] (e.g. pytorch3d)

Thank you very much, all clear now.

Only a side comment on this, @lahavlipson you are saying that the last pose is given by lietorch.SE3(slam.poses_[n-1]).inv().data.cpu().numpy() but n is the keyframe number, so you are not effectively giving the last pose of the last frame, but rather of the last keyframe that might be far in time, depending on your configs.
The real pose corresponding to time t (I guess that is what @Lanzo98 is asking) is only obtainable after running slam.terminate(), that interpolates the missing poses in-between keyframe and therefore the "real" pose at time t is got. Correct me if I'm wrong.
Is it really feasible in DPVO to get the estimated pose for each new frame ?

@senecobis DPVO treats every new frame as a keyframe, and only removes keyframes when they are 3 timesteps old or fall out of the optimization window. So keyframes t-1, t-2 and t-3 are indeed the most recent 3 frames

@lahavlipson but then what is the whole purpose of this code part inside dpvo evaluation script.
I understood that, if the estimated flow between i and j is less then self.cfg.KEYFRAME_THRESH that is 15.0 then we remove the last frame from keyframes.
Where i is the 5th to last keyframe (since self.cfg.KEYFRAME_INDEX = 4) and j is the 3rd to last keyframe.
Or you were referring to training? in training is for sure true that every frame is keyframe.

@senecobis Your understanding of the code part is almost correct; we don't remove the last frame if the flow between (n-3) and (n-5) is small, we remove the in-between frame (n-4)

Hi @lahavlipson, I'm publishing the result of lietorch.SE3(slam.poses_[n-1]).inv().data.cpu().numpy() in a PoseStamped ros message. I can view the position correctly but the rotation quaternions seems wrong (please see image). Do you have any idea of why? I'm taking into account that the format is [qx, qy, qz, qw] of the pose vector.


add default EnvSpec for RetroEnv

this helped me fix a spec-related error when trying to use Retro envs thru Gym HTTP API.
also see https://github.com/openai/gym-http-api/pull/65

Thanks for the PR!  I think that spec = None is meant to be a supported configuration based on the comment here: https://github.com/openai/gym/blob/master/gym/core.py#L40
It may be a bug in Gym HTTP API that is causing the issue.  I will close this for now, we can reopen if spec = None is not an allowed config for gym environments.


Sometimes voices for females become male

Check the logs

Let's have the age_converter use:
>>> isinstance(a, int)
True
>>> b = "asdf"
>>> isinstance(b, int)
False
>>>


Parsing error when name includes . character

The resource cloud_run_domain_mapping has a name attribute that must be a verified domain. Running tftools on a cloud_run_domain_mapping resource with name = "verified-domain.com", for example, yields a parsing error from convert2erb.py due to the dot.
cloud_run_domain_mapping.tf.txt

Hi @rogerthatdev Thank you for the detailed bug report. Thanks to you, I made necessary changes for resolving this issue in our updated version.
Note: update version needs install of ANTLR4
Can you please check?

Request you to re-open this issue, if needed be! Thanks.


Restore AC failing tests

The tests failing here are all on OpenAPI 2.0 — the problem is that our http spec translator is not correctly creating an example per each content type, but rather a single example with multiple keys inside.

This is the fix we need: https://github.com/stoplightio/http-spec/pull/2

@philsturgeon @lag-of-death Boom! Graphite updated, and tests are now green!


add clarifications around oc / plugin strategy

Fixes https://github.com/openshift/jenkins-plugin/issues/46
@bparees @ullgren PTAL - here is my attempt at the doc update discussed around why the plugin is not providing a new-app equivalent.  It also clarifies some of the "why" around using the plugin vs. oc (which has come up in some internally reported issues).

one nit and lgtm

lgtm

Thanks @bparees .  I'm going to go ahead and merge this change, but if @ullgren responds with any comments / suggestions on the doc change afterward I'll still process them.