Obj.Insert/Ojb.Remove were both removed

The methods Insert and Remove have been removed. They were superseded by InsertAt, RemoveAt, Push, Pop, Delete and ObjRawSet in v1.1.21.

see the v1 Objects help page for conversions

Do we have anything to deal with properties?
If not we could use a regex like i)^([\s]*[a-z_][a-z_0-9]*\.(Insert|Remove)(?!At)) as an easy workaround
Example v1 script
MyArray := ["1","2","3"]

MyArray.Insert(2, "4", "5")   ; InsertAt
MyArray.Insert("6")           ; Push

MyArray.Remove(4)             ; RemoveAt
MyArray.Remove()              ; Pop

Partially fixed in #151
Still needs

Fix Key-Value pairs
Handling vars (a var will fail IsDigit())
Handling cases that don't match if statements
Lots of warnings ;-;

I'm attempting to fix Key-Value pairs, but can't test it as ArrayMethods is only used for, well arrays MyArr := []
For Key-Value pairs (defined by MyObj := Object() or MyObj := {}) ArrayMethods don't do anything
So should these objects stay with 4ArrayMethods, or should they get their own file?
  } else if (!IsDigit(p[1])) {
    Obj := p[1], val := false
    for i, v in p {
      if !val { ; Obj.Key
        Str .= Obj "." v
      } else {
        Str .= " := " v ", "
      }
      val := !val
    }
    if !val { ; Last key has no val, assign empty string
      Str .= "`"`""
    } else { ; Otherwise trim trailing ", "
      Str := RTrim(Str, ", ")
    }
    Return Str

As far as I know, no one has attempted that yet, so its up to your discretion

Is this fixed? If not can you provide details as to what needs to be addressed? I'm unable to figure out what is needed specifically to put this issue to rest. Can you provide examples to show what needs to be corrected? (v1 code, current conversion, and expected result). Thanks!

This just needs to be implemented on maps
If you want to fix you may find https://github.com/mmikeww/AHK-v2-script-converter/issues/9#issuecomment-2001749314 useful
The functions _InsertAt and _RemoveAt already exist, unless you want to make the fix for both in the same function, I recommend naming the map fix functions something like _InsertAt2

Correct me if I am wrong...
in v1

InsertAt() and Remove() are only valid for linear arrays (according to docs)
The user can declare an array with MyObj := [] or MyObj := {}, but both CAN BE be treated as an array in v1

in v2

InsertAt() and Remove() are non-existent for objects or arrays
MyObj := [] is considered an array
MyObj :={} is considered an object, and never considered an array

Based on this, it looks like the most effective course of action would be to determine which data type was intended when MyObj := {} is used in v1 code. Then change it to MyObj := [] if it looks like an array instead of an object.
How to do this? The block-masking may come in handy here. Before conversion of a particular code block, it can look for var := {} and then look for tell tale signs [like .insert(), .remove()] to determine whether it should be changed to var := [].
Because honestly, I'm at a loss as to how to get v2 to treat ":= {}" as an array in the first place. Because when it encounters this, it sets that var data type as an object, not an array. Is this not correct?
The other solution would be to create a newly defined Insert() and Remove() method for Object. But that is a whole other set of checks that need to be made within the new methods to determine how to handle the data based on which type of object is being considered. Probably 1000 times the work. And this is not what the converter should be about anyway.
Again, I may not be correct with all this. And maybe you already have an idea of how to handle this so that v2 will treat an object created with {} as a linear array instead?
What are your thoughts?

Correct me if I am wrong...
in v1

InsertAt() and Remove() are only valid for linear arrays (according to docs)
The user can declare an array with MyObj := [] or MyObj := {}, but both CAN BE treated as an array in v1

in v2

InsertAt() and Remove() are non-existent for objects or arrays
MyObj := [] is considered an array
MyObj :={} is considered an object, and never considered an array

Based on this, it looks like the most effective course of action would be to determine which data type was intended when MyObj := {} is used in v1 code. Then change it to MyObj := [] if it looks like an array instead of an object.
How to do this? The block-masking may come in handy here. Before conversion of a particular code block, it can look for var := {} and then look for tell tale signs [like .insert(), .remove()] to determine whether it should be changed to var := [].
Because honestly, I'm at a loss as to how to get v2 to treat ":= {}" as an array in the first place. Because when it encounters this, it sets that var data type as an object, not an array. Is this not correct?
Any solution we put in place will have to treat the var as an array, and then change the Insert() to something else, but it cannot be InsertAt, because v2 will not consider this valid for the object created initially with ":= {}" (I already tried it). I think making the check to see if var is an actual object or an array will be much easier than any other bandage that can be applied. Or simple add a v2 comment that tells the user that they may need to change the var manually to ":= []".
The other solution would be to create a newly defined Insert() and Remove() method for Object. But that is a whole other set of checks that need to be made within the new methods to determine how to handle the data based on which type of object is being considered. Probably 1000 times the work. And this is not what the converter should be about anyway.
Again, I may not be correct with all this. And maybe you already have an idea of how to handle this so that v2 will treat an object created with {} as a linear array instead?
What are your thoughts?
BTW... one of the objectives of the block-masking/isolation is to make a list of vars found within that block and "assign" the most appropriate scope and datatype so that situations like this can be handled more effectively. That part has not been implemented yet (not sure how long it will take) but is planned. This idea will never be 100% effective because v1 allows changing var datatypes every line (and even on the same line), so the idea may not work. But it probably could for some situations... maybe like this one?
The biggest challenge (at this point) for the list of vars within the blocks is to create a database of all AHK commands/functions/etc. that can weeded out as possible variables. But of course, even v2 allows some of those to used as user-defined variables or to be changed by the coder at will. So the idea may face significant challenges from that perspective as well. But again, it might be effective in some cases.
Side note... I use the block isolation as part of a tool I built to view the structure of a .ahk files at a glance. List of all functions, classes, vars, comments, strings, other code blocks (growing), etc.... The gui shows this info in a treeview that will eventually be used as a code navigator for quick access during editing. (That is one of the goals). Will soon be able to hover over a file in Win Explorer and have a popup with all this info without opening the file (working on that part now). It's such a pain to open the file just to see whats inside... and then seeing a mess that is hard to navigate once open... need a quick/organized view instead. I will probably post this tool on the AHK forum at some point.

my opinion is that we shouldnt be changing user code to change their objects into arrays. v2 objects are different than v1 and imo users should be expected to learn the new functionality and adapt their code accordingly. as you say, it will be extremely hard for a converter to try to guess what type of object the author originally intended

BTW... one of the objectives of the block-masking/isolation is to make a list of vars found within that block and "assign" the most appropriate scope and datatype so that situations like this can be handled more effectively.

Great idea, but I guess in this case it's almost impossible to guess the correct type without actually running it.
But guessing the most likely type, I think it can save a lot of time for people who use conversion tools, and avoid duplication of work.
#Requires AutoHotkey v<IP_ADDRESS>

fn1()
fn1() {
    a := []
    a.Push(1)

    ; after not need
    ; a := ""

    fn2(A) ; Initialized/set-value by func, but with old variable names
}

fn2(ByRef a) {
    a := {"k":"v"}
}

off topic

I use the block isolation as part of a tool I built to view the structure of a .ahk files at a glance. List of all functions, classes, vars, comments, strings, other code blocks (growing), etc....

Maybe you could consider some existing tools
v2 can use thqby AutoHotkey v2 Language Support
v1 can use my AutoHotkey NekoHelp ?

I guess in this case it's almost impossible to guess the correct type without actually running it.
#Requires AutoHotkey v<IP_ADDRESS>

fn1()
fn1() {
    a := []
    a.Push(1)

    ; after not need
    ; a := ""

    fn2(A) ; Initialized/set-value by func, but with old variable names
}

fn2(ByRef a) {
    a := {"k":"v"}
}

Within fn1 'a' would be considered an array due to " := []" and .push()
fn2(A) would have no special conversion
within fn2, 'a' would be considered an object
byref would be changed to &a

This converts fine at the moment, and should not need any special treatment. So determining the var types is not always needed (the detection good or bad will not lead to any special conversion in this case). What I was referring to is certain checks that we could implement prior to conversion that may be helpful with certain situations that are common. Like v1 coders using {} to define an array (out of habit). Obviously all possibilities are impossible to predict, but we could have a place within the script that handles special cases once identified by people who submit "Issues". If it's common, we could make that check and handle it going forward. Which is basically what happens now. This just provides additional tools for more specialized cases that are not easily handled within the main conversion loop.

Maybe you could consider some existing tools v2 can use thqby [AutoHotkey v2 Language Support]

These work fine within a host editor that supports them, but not when simply viewing the code with notepad or you want a quick summary of what is in the file. The tool I mention is designed to provide that summary (birds-eye preview) by just hovering over the file within explorer (acting much like a tooltip). If you want to open the file after seeing the preview, you have that option. You can quickly just move your mouse from file to file to get the preview, just like you can receive the file date/size/author/etc now within explorer now. The mentioned preview simply shows the code details in an organized manner.
Some people may not need this, but it is very helpful to me.

we shouldnt be changing user code to change their objects into arrays.

Ok... perhaps @Banaanae solution for the arrays should be sufficient to put this topic to rest? Maybe implementation for objects is not needed. Have there been any other 'issue' submissions to address .Insert() or .Remove() for objects (over the last 8 years)? And if another "issue" is posted for objects, it can be considered then? That would be a quick and easy way to place this topic in the "done" pile.

we shouldnt be changing user code to change their objects into arrays.

Ok... perhaps @Banaanae solution for the arrays should be sufficient to put this topic to rest? Maybe implementation for objects is not needed. Have there been any other 'issue' submissions to address .Insert() or .Remove() for objects? And if another "issue" is posted for objects, it can be considered then? That would be a quick and easy way to place this aging topic in the "completed" pile.

we shouldnt be changing user code to change their objects into arrays.

Ok... perhaps @Banaanae solution for the arrays should be sufficient to put this topic to rest? Maybe implementation for objects is not needed. Have there been any other 'issue' submissions to address .Insert() or .Remove() for objects? And if another "issue" is posted for objects, it can be considered then? That would be a quick and easy way to place this aging topic in the "completed" pile.
My point about changing them was... according to documentation, .Insert() and .Remove() are only valid for arrays. Which tends to suggest that when the v1 coder used those methods, they were intending the {} to be an array and should have used [] instead anyway. This is not changing an object into an array, it's simple defining the var as an array the way it should have been done from the beginning (by the v1 author).
By defining it as an array, the code will be converted correctly without the need to define a "way" to convert it correctly. Arrays are already being handled correctly. This justs lets the converter do the job it already does well.

we shouldnt be changing user code to change their objects into arrays.

My point about changing them was... according to documentation, .Insert() and .Remove() are only valid for arrays. Which tends to suggest that when the v1 coder used those methods, they were intending the {} to be an array and should have used [] instead anyway. This is not changing an object into an array, it's simple defining the var as an array the way it should have been done from the beginning (by the v1 author).
By defining it as an array, the code will be converted correctly without the need to define a "way" to convert it correctly. Arrays are already being handled correctly. This justs lets the converter do the job it already does well.
Or... perhaps @Banaanae solution for the arrays should be sufficient to put this topic to rest? Maybe implementation for objects is not needed. Have there been any other 'issue' submissions to address .Insert() or .Remove() for objects? And if another "issue" is posted for objects, it can be considered then? That would be a quick and easy way to place this aging topic in the "completed" pile.

we shouldnt be changing user code to change their objects into arrays.

My point about changing them was... according to documentation, .Insert() and .Remove() are only valid for arrays. Which tends to suggest that when the v1 coder used those methods, they were intending the {} to be an array and should have used [] instead anyway. This is not changing an object into an array, it's simple defining the var as an array the way it should have been done from the beginning (by the v1 author).
By defining it as an array, the code will be converted correctly without the need to define a "way" to convert it correctly. Arrays are already being handled correctly. This justs lets the converter do the job it already does well.
Or... perhaps @Banaanae solution for the arrays should be sufficient to put this topic to rest? Maybe implementation for objects is not needed. Have there been any other 'issue' submissions to address .Insert() or .Remove() for objects? And if another "issue" is posted for objects, it can be considered then? That would be a great way to place this aging topic in the "completed" pile after all these years.
Just a thought...

we shouldnt be changing user code to change their objects into arrays.

My point about "changing" them was... according to documentation, .Insert() and .Remove() are only valid for arrays. Which tends to suggest that when the v1 coder used those methods, they were intending those vars to be arrays and act upon array elements. Unfortunately the author declared the array using braces instead of brackets. The v2 converter sees and treats those intended arrays (that have braces) as objects instead. The converter is only doing what it is programmed to do... treat {} as and object, and [] as an array. So my thought was... tell the converter that it is an array and not an object, so that it treats it correctly. The array portion of this fix has already been done, so if we simply tell the converter that .Insert() and .Remove() should be considered array methods, it will already convert them correctly with no further tweaking of the script. The only way to tell the converter that it should be handled as an array, is to define it as the array up front. Because the resulting code will interpret var := {} as an object and generate an error when the v2 converted code is run. How do we know the author intended these vars as an array and not an object? Because they used methods that only act on array data (Insert() and/or .Remove().). We are simply defining them correctly as the original author should have done from the beginning (using brackets instead of braces).
This explicit definition will eliminate the need to create a way to "handle objects that use those methods". The converter will take care of that automatically thru the array conversion.
Or... perhaps @Banaanae solution for the arrays should be sufficient to put this topic to rest? Maybe implementation for objects is not needed. Have there been any other 'issue' submissions to address .Insert() or .Remove() for objects? And if another "issue" is posted for objects, it can be considered then? That would be a great way to place this aging topic in the "completed" pile after all these years.
Just a thought...

we shouldnt be changing user code to change their objects into arrays.

My point about "changing" them was... according to documentation, .Insert() and .Remove() are only valid for arrays. Which tends to suggest that when the v1 coder used those methods, they were intending those vars to be arrays and act upon array elements. Unfortunately the author declared the array using braces instead of brackets. The v2 converter sees and treats those intended arrays (that have braces) as objects instead. The converter is only doing what it is programmed to do... treat {} as and object, and [] as an array.
So my thought was... tell the converter that it is an array and not an object, so that it treats it correctly. The array portion of this fix has already been done, so if we simply tell the converter that .Insert() and .Remove() should be considered array methods, it will already convert them correctly with no further tweaking of the script. The only way to tell the converter that the var should be run through array conversion is to, is to define it as the array up front. If we simply apply the same treatment for those methods to an object (changing to InsertAt/RemoveAt) the resulting v2 script will still generate an error since those methods are not supported by object. At that point, the user of the script will need to change the declaration of those vars to ':= []' instead of ':={}' to eliminate the error. I'm simply suggesting that the converter do this automatically.
How do we know the author intended these vars  to be arrays and not objects? Because the author used methods that only apply to arrays (.Insert() and/or .Remove()). We are simply defining them correctly (for the converter) so that the authors original intention is preserved. This explicit definition will eliminate the need to create a way to "handle objects that use those methods". The converter will take care of that automatically thru the array conversion.
Or... perhaps @Banaanae solution for the arrays should be sufficient to put this topic to rest? Maybe implementation for objects is not needed. Have there been any other 'issue' submissions to address .Insert() or .Remove() for objects? And if another "issue" is posted for objects, it can be considered then? That would be a great way to place this aging topic in the "completed" pile after all these years.
Just a thought...

we shouldnt be changing user code to change their objects into arrays.

My thinking was to use .Insert/Remove to determine the authors intended use for the variable... however, after some experimenting this is not 100% safe assumption.
I did a little experimenting and apparently arrays in v1 act as tho they are key/value pairs (objects) with numeric keys, and the "array element" is the value portion of that pair. This means that a v1 object can hold keys that are numeric or something else (not surprising). With numeric keys, Insert/Remove can act upon those key/val pairs within that object. But not upon any other type of key/val in that same object. So essentially an object can act like a combination of a key/val pair (map) and an array all in the same unit. MaxIndex() seems to report only the last index that has an array type key/val pair. But .Count() seems to report all elements within that object. Length() seems to report only the array type elements in that object. It's very confusing but essentially the author could intend to use a single object like a Map AND and an array at the same time. So there is really no way to know the original intention.
Just a thought... perhaps @Banaanae solution for the arrays should be sufficient to put this topic to rest? Maybe implementation for objects is not needed. Have there been any other 'issue' submissions to address .Insert() or .Remove() for objects? And if another "issue" is posted for objects, it can be considered then? That would be a great way to place this aging topic in the "completed" pile after all these years.

Just a thought... perhaps @Banaanae solution for the arrays should be sufficient to put this topic to rest? Maybe implementation for objects is not needed. Have there been any other 'issue' submissions to address .Insert() or .Remove() for objects? And if another "issue" is posted for objects, it can be considered then? That would be a great way to place this aging topic in the "completed" pile after all these years.

For issues like this it's best to leave them open, so for people who convert their scripts in the future are aware of issues like this

so people who convert their scripts in the future are aware of issues like this

As well as the people working on the script going forward... good point.


Can't get the characters shown when using Chinese input method

Terminal vim does show the characters

I'm using MacVim snapshot-93, is it possible for MacVim to support it?

Have you tried defaults delete org.vim.MacVim?

@splhack just tried, I can see the characters.
but I can't choose chinese characters any more, looks like it's a problem with one of my plugins, it works fine if I use mvim -N -u NONE


PresentrTransitionContext fields changed to public

What does this PR do?

Fixes issue #96

PresentrTransitionContext fields have to be public in order to be accessible in projects that try to subclass PresentrAnimation

@danlozano LGTM


Fixed Tone.Note.dispose

Good catch. Thanks. Can you please make this commit on the dev branch instead of master?

Cool, see https://github.com/Tonejs/Tone.js/pull/83


#167 Ceil

As per #167
Ceil introduced.

@rultor merge

@rultor merge

@vssekorin The pull request is closed already, so I can't merge it

@rultor merge

@vssekorin I'm sorry, I don't understand you :( Check this page and try again please


Encoding the email returns unwanted characters

I have entered this email:
<EMAIL_ADDRESS>and mailchecker returned this suggestion:
<EMAIL_ADDRESS>The problem is in line 224 of mailcheck.js where the replace after the encode does not replace all. This should be modified to do a replace all. For example for replacing all occurrences of %25, it should be .replace(/%25/g, '%')
Can you please look into it?

@christinamcx good catch! I fixed it here: https://github.com/ZooTools/email-spell-checker/pull/4
Let me know if you have any feedback.

Disclaimer: This library is no longer maintained.
I rewrote it entirely and update it for 2022 and onward: https://github.com/ZooTools/email-spell-checker

💙 Written in TypeScript and removed jQuery
✅ Fixed a couple of bugs like this or this
🚀 Reduced bundle size to <2KB.
✨ Update TLDs (69+) and added modern startup domains (like .io, .so, .xyz or .dev)
🙏 Implemented suggestions that people made in this repo that were ignored.

Link: https://github.com/ZooTools/email-spell-checker
Come check it out and give it a ⭐ for the effort.


Release notes for mcr.microsoft.com/windows:ltsc2019 base docker image

I see that mcr.microsoft.com/windows:ltsc2019 image has been updated as per the info provided on dockerhub, image mentioned was updated on 08/13/2024. By any chance is there a way to check what has been updated I mean release notes for the same. mentioning hot fixes applied in case any.
I wanted to make sure that is it necessary/better practice to update base images frequently(to accommodate new updates in base images) in order to be inline with the new updates/security patches on container host machines.

I use {docker,podman image history for this purpose
PS C:\Users\Avinesh> docker image history mcr.microsoft.com/windows:ltsc2019
IMAGE          CREATED         CREATED BY                       SIZE      COMMENT
8c4498ace9e0   2 weeks ago     Install update 10.0.17763.6189   3.08GB
<missing>      14 months ago   Apply image 10.0.17763.4499      7.31GB

As you can see, the latest image is built from build 10.0.17763.6189 and its corresponding release notes are at https://support.microsoft.com/en-us/topic/august-13-2024-kb5041578-os-build-17763-6189-522a6305-63d2-40e3-8084-2ab8f9589bc6
However I do agree this should be standardized and there should be a way to obtain out container specific release note items

@viniciusl-msft do you have any thoughts on update/release notes?


Upgrade to can-symlink 1.0.0

Fixes race condition in multiprocess environment (raytiley/can-symlink#3).

LGTM thanks :)

Not sure what happened with the AppVeyor build. The Node.js 0.10 target timed out?

seemed unrelated, triggering node 0.10 rebuild...

Thanks! Released in 1.1.1.


[2.0] ❌ conflict between Handlers

[x] Conflict between on_raw_update() used in trivial.py and the other handlers used in the modules

Fixed and solved


add **/datasets in gitignore file

running the code in pytorch/tut1_basics/walkthrough.py generates a datasets folder that is not yet ignored by git. several other files will also generate this folder owing to downloading of the fashion mnist dataset.

Hi Xu Dong, thank you for your PR - we will look at your suggestion internally.


Possible duplicate lumi sections

Might be legit or not:
https://its.cern.ch/jira/browse/CMSCOMPPR-5251
but let me create this GH issue to keep the investigation status here.

#9098 ?

#9074 ?

The first issue is mainly for Unified, given that the agents are already filtering out duplicate job failures when fetching ACDC data (as done in 9074)

https://its.cern.ch/jira/browse/CMSCOMPPR-5220 this is similar and I think it should help you. @amaltaro FYI

This one has less ACDCs:
https://its.cern.ch/jira/browse/CMSCOMPPR-5217
making our life easier.

@khurtado , this is the GH ticket to follow up on that JIRA ticket. We can record details and maybe scripts used here. Even better, depending on the script (usefulness), we might even push it into WMCore.

I was ready to post a bunch of comments, when I noticed I should have debugged something else, so here are my findings.
The original workflow was suppose to process 100 lumis in ~34 jobs, with 3 lumi sections per job
https://cmsweb.cern.ch/reqmgr2/fetch?rid=pdmvserv_task_HIG-RunIIFall17wmLHEGS-03538__v1_T_190222_091942_5061
agent url: cmsgwms-submit7.fnal.gov
  "TotalInputLumis": 100,
Task1
    "RequestNumEvents": 100000
    "EventsPerLumi": 1000,
    "EventsPerJob": 3000,

then looking at the ACDCServer and getting a summary of failures (docs uploaded for that original workflow), these are the stats to recover:
amaltaro@vocms0192:/data/amaltaro/ReqMgr2_scripts $ python checkACDCCollections.py -w pdmvserv_task_HIG-RunIIFall17wmLHEGS-03538__v1_T_190222_091942_5061 -v
Found 18 failures/rows in total.
Summary of failures is as follows:
{u'/pdmvserv_task_HIG-RunIIFall17wmLHEGS-03538__v1_T_190222_091942_5061/HIG-RunIIFall17wmLHEGS-03538_0': {'files': 18,
                                                                                'jobs': 18,
                                                                                'listLumis': 'set([10, 11, 12, 13, 14, 15, 16, 40, 41, 42, 43, 44, 45, 46, 47, 48, 49, 50, 51, 52, 53, 54, 55, 56, 57, 58, 59, 60, 61, 62, 63, 64, 65, 66, 67, 68, 69, 70, 71, 72, 73, 74, 75, 76, 77, 78, 79, 80, 81, 82, 83, 84, 85, 86, 87, 88])',
                                                                                'lumis': 72,
                                                                                'uniqueLumis': 56}}

Now printing duplicate files + run + lumis per fileset

with no duplicate ACDC doc and a total of 56 lumis (18 x 3), minus 2 lumis due to the annoying inclusiveMask to be discussed later in this thread.
Now looking into vocms0256, which was processing the first ACDC
https://cmsweb.cern.ch/reqmgr2/fetch?rid=vlimant_ACDC0_task_HIG-RunIIFall17wmLHEGS-03538__v1_T_190313_075148_8329
we can see that 18 jobs got created to process 54 lumi sections
SQL> SELECT wmbs_job_mask.*
  FROM wmbs_job INNER JOIN wmbs_job_mask ON wmbs_job.id=wmbs_job_mask.job
  INNER JOIN wmbs_job_assoc ON wmbs_job.id=wmbs_job_assoc.job
  WHERE cache_dir like '%vlimant_ACDC0_task_HIG-RunIIFall17wmLHEGS-03538__v1_T_190313_075148_8329/HIG-RunIIFall17wmLHEGS-03538_0/JobCollection%'
  ORDER BY wmbs_job_mask.firstlumi;  2    3    4    5

       JOB FIRSTEVENT  LASTEVENT  FIRSTLUMI   LASTLUMI	 FIRSTRUN    LASTRUN I
---------- ---------- ---------- ---------- ---------- ---------- ---------- -
   2081869	66001	   69001	 67	    70		1	   1 T
   2081870	69001	   72001	 70	    73		1	   1 T
   2081871	72001	   75001	 73	    76		1	   1 T
   2081872	75001	   78001	 76	    79		1	   1 T
   2081873	78001	   81001	 79	    82		1	   1 T
   2081874	81001	   84001	 82	    85		1	   1 T
   2081875	84001	   87001	 85	    88		1	   1 T
   2081876	87001	   90001	 88	    91		1	   1 T
   2081877	90001	   93001	 91	    94		1	   1 T
   2081878	93001	   96001	 94	    97		1	   1 T
   2081879	96001	   99001	 97	   100		1	   1 T
   2081880	99001	  102001	100	   103		1	   1 T
   2081881     102001	  105001	103	   106		1	   1 T
   2081882     105001	  108001	106	   109		1	   1 T
   2081883     108001	  111001	109	   112		1	   1 T
   2081884     111001	  114001	112	   115		1	   1 T
   2081885     114001	  117001	115	   118		1	   1 T
   2081886     117001	  120001	118	   121		1	   1 T

18 rows selected.

first problem though are those lumi numbers which don't match with what was available in the ACDCServer.

That means lumi sections between 88 and 100 would have been produced twice, once in the original workflow and the second by this first ACDC workflow. Which also matches a summary of 87 lumi sections (unique) available in the output datasets.

And the problem is here:
https://github.com/dmwm/WMCore/blob/master/src/python/WMCore/JobSplitting/EventBased.py#L242
we use the first lumi in the lumi list of a file (unordered) and then start iterating from it adding the lumisPerJob to each job. That's why it eventually goes through lumis already produced.
According to my previous comment, the final lumi list (after merging data from ACDC) is bigger than what it should be, and the reason is that annoying inclusiveMask (providing lumi sections that are actually not produced in a job).
If that is completely deterministic and reliable, then we can get a range of them (but we need to check the source code and a few examples as well). Otherwise, the only way to fix it for the moment is to stop merging ACDC docs...

The real real fix will have to touch something very deep/wide in the code (the Mask object) :(
While testing the wmagent branch workaround, I can confirm that the lumi list (job mask) is completely misleading in certain cases. E.g.:
https://cmsweb-testbed.cern.ch/couchdb/acdcserver/_design/ACDC/_view/byCollectionName?key="amaltaro_TaskChain_MC_HG1904_Validation_3Lumis_190405_073420_3661"&include_docs=true&reduce=false
has an original MCFake input file with 30 lumis (1 to 30). Each job processed 3 lumis, from the wmbs_job_mask:
MariaDB [wmagent]> select * from wmbs_job_mask;
+-----+------------+-----------+-----------+----------+----------+---------+---------------+
| job | FirstEvent | LastEvent | FirstLumi | LastLumi | FirstRun | LastRun | inclusivemask |
+-----+------------+-----------+-----------+----------+----------+---------+---------------+
|  11 |          1 |        61 |         1 |        4 |        1 |       1 |             1 |
|  12 |         61 |       121 |         4 |        7 |        1 |       1 |             1 |
|  13 |        121 |       181 |         7 |       10 |        1 |       1 |             1 |
|  14 |        181 |       241 |        10 |       13 |        1 |       1 |             1 |
|  15 |        241 |       301 |        13 |       16 |        1 |       1 |             1 |
|  16 |        301 |       361 |        16 |       19 |        1 |       1 |             1 |
|  17 |        361 |       421 |        19 |       22 |        1 |       1 |             1 |
|  18 |        421 |       481 |        22 |       25 |        1 |       1 |             1 |
|  19 |        481 |       541 |        25 |       28 |        1 |       1 |             1 |
|  20 |        541 |       601 |        28 |       31 |        1 |       1 |             1 |
+-----+------------+-----------+-----------+----------+----------+---------+---------------+

then if we look at those 2 ACDC docs, first one has
"runs":[{"run_number":1,"lumis":[22,23,24,25]}]
while the second one (last job for that MCFake file) has
"runs":[{"run_number":1,"lumis":[28,29,30]}]
This clearly needs fixing!

And another example of how confusing this job mask is!
ReReco workflow with 1 lumi per job:
MariaDB [wmagent]> SELECT wmbs_job_mask.* FROM wmbs_job_mask
    ->   INNER JOIN wmbs_job ON wmbs_job.id = wmbs_job_mask.job
    ->   INNER JOIN wmbs_jobgroup ON wmbs_job.jobgroup = wmbs_jobgroup.id
    ->   INNER JOIN wmbs_subscription ON wmbs_jobgroup.subscription = wmbs_subscription.id
    ->   INNER JOIN wmbs_workflow ON wmbs_subscription.workflow = wmbs_workflow.id
    -> WHERE wmbs_workflow.name = 'amaltaro_ReReco_RunBlockWhite_Apr2019_Validation_190412_135713_1626';
+-----+------------+-----------+-----------+----------+----------+---------+---------------+
| job | FirstEvent | LastEvent | FirstLumi | LastLumi | FirstRun | LastRun | inclusivemask |
+-----+------------+-----------+-----------+----------+----------+---------+---------------+
|  40 |       NULL |      NULL |       115 |      115 |   283171 |  283171 |             1 |
|  41 |       NULL |      NULL |       118 |      118 |   283171 |  283171 |             1 |
|  42 |       NULL |      NULL |       121 |      121 |   283171 |  283171 |             1 |
+-----+------------+-----------+-----------+----------+----------+---------+---------------+
3 rows in set (0.00 sec)

MonteCarlo from scratch with 1 lumi per job as well:
MariaDB [wmagent]> SELECT wmbs_job_mask.* FROM wmbs_job_mask
    ->   INNER JOIN wmbs_job ON wmbs_job.id = wmbs_job_mask.job
    ->   INNER JOIN wmbs_jobgroup ON wmbs_job.jobgroup = wmbs_jobgroup.id
    ->   INNER JOIN wmbs_subscription ON wmbs_jobgroup.subscription = wmbs_subscription.id
    ->   INNER JOIN wmbs_workflow ON wmbs_subscription.workflow = wmbs_workflow.id
    -> WHERE wmbs_workflow.name = 'amaltaro_TC_OneTask_Apr2019_Validation_1Lumi_190412_085947_8260';
+-----+------------+-----------+-----------+----------+----------+---------+---------------+
| job | FirstEvent | LastEvent | FirstLumi | LastLumi | FirstRun | LastRun | inclusivemask |
+-----+------------+-----------+-----------+----------+----------+---------+---------------+
|  11 |          1 |     90001 |         1 |        2 |        1 |       1 |             1 |
|  12 |      90001 |    180001 |         2 |        3 |        1 |       1 |             1 |
|  13 |     180001 |    270001 |         3 |        4 |        1 |       1 |             1 |
|  14 |     270001 |    360001 |         4 |        5 |        1 |       1 |             1 |

so it's clear that we must fix those job masks if we want to avoid this problem recurring in the future.


Feature/disable win setup prompts

Sorry forgot to post an update here - I was able to run this on the Ramble PC without any issues! @benjaminbojko


Mac Build Failing

Just tried building the current master (30214f843b44442c2f3db660e1f117e5ce18689a) on my current mac cloud and got the following error:
/Users/anthony/miniconda/conda-bld/wxpython_1521647577133/work/build/wxbld/bk-deps clang++ -isysroot /Library/Developer/CommandLineTools/SDKs/MacOSX10.13.sdk -mmacosx-version-min=10.6 -c -o netdll_protocol.o -I./.pch/wxprec_netdll -D__WXOSX_COCOA__      -DWXBUILDING -I/Users/anthony/miniconda/conda-bld/wxpython_1521647577133/work/build/wxbld/src/tiff/libtiff -I/Users/anthony/miniconda/conda-bld/wxpython_1521647577133/work/ext/wxWidgets/src/tiff/libtiff -I/Users/anthony/miniconda/conda-bld/wxpython_1521647577133/work/ext/wxWidgets/src/jpeg -I/Users/anthony/miniconda/conda-bld/wxpython_1521647577133/work/ext/wxWidgets/src/png  -I/Users/anthony/miniconda/conda-bld/wxpython_1521647577133/work/ext/wxWidgets/src/regex  -DwxUSE_GUI=0 -DWXUSINGDLL -DWXMAKINGDLL_NET -dynamic -fPIC -DPIC -Wall -Wundef -Wunused-parameter -Wno-ctor-dtor-privacy -Woverloaded-virtual -Wno-deprecated-declarations -D_FILE_OFFSET_BITS=64 -I/Users/anthony/miniconda/conda-bld/wxpython_1521647577133/work/build/wxbld/lib/wx/include/osx_cocoa-unicode-3.0 -I/Users/anthony/miniconda/conda-bld/wxpython_1521647577133/work/ext/wxWidgets/include -D__ASSERT_MACROS_DEFINE_VERSIONS_WITHOUT_UNDERSCORES=1 -I/Users/anthony/miniconda/conda-bld/wxpython_1521647577133/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_/include -DWX_PRECOMP -O2 -fno-strict-aliasing -mmacosx-version-min=10.9 -stdlib=libc++ -m64 -fno-common -fvisibility=hidden -fvisibility-inlines-hidden /Users/anthony/miniconda/conda-bld/wxpython_1521647577133/work/ext/wxWidgets/src/common/protocol.cpp
1 error generated.
make: *** [basedll_cocoa_utils.o] Error 1
make: *** Waiting for unfinished jobs....
Error building
ERROR: failed building wxWidgets
Traceback (most recent call last):
  File "build.py", line 1295, in cmd_build_wx
    wxbuild.main(wxDir(), build_options)
  File "/Users/anthony/miniconda/conda-bld/wxpython_1521647577133/work/buildtools/build_wxwidgets.py", line 498, in main
    exitIfError(wxBuilder.build(dir=buildDir, options=args), "Error building")
  File "/Users/anthony/miniconda/conda-bld/wxpython_1521647577133/work/buildtools/build_wxwidgets.py", line 85, in exitIfError
    raise builder.BuildError(msg)
buildtools.builder.BuildError: Error building
Finished command: build_wx (7m2.759s)
Finished command: build (7m2.761s)
WARNING: Building this way assumes that all generated files have been
generated already.  If that is not the case then use build.py directly
to generate the source and perform the build stage.  You can use
--skip-build with the bdist_* or install commands to avoid this
message and the wxWidgets and Phoenix build steps in the future.

"/Users/anthony/miniconda/conda-bld/wxpython_1521647577133/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_/bin/python" -u build.py build
Command '"/Users/anthony/miniconda/conda-bld/wxpython_1521647577133/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_/bin/python" -u build.py build' failed with exit code 1.
Traceback (most recent call last):
  File "/Users/anthony/miniconda/bin/conda-build", line 6, in <module>
    sys.exit(conda_build.cli.main_build.main())
  File "/Users/anthony/miniconda/lib/python3.6/site-packages/conda_build/cli/main_build.py", line 420, in main
    execute(sys.argv[1:])
  File "/Users/anthony/miniconda/lib/python3.6/site-packages/conda_build/cli/main_build.py", line 411, in execute
    verify=args.verify)
  File "/Users/anthony/miniconda/lib/python3.6/site-packages/conda_build/api.py", line 199, in build
    notest=notest, need_source_download=need_source_download, variants=variants)
  File "/Users/anthony/miniconda/lib/python3.6/site-packages/conda_build/build.py", line 2097, in build_tree
    notest=notest,
  File "/Users/anthony/miniconda/lib/python3.6/site-packages/conda_build/build.py", line 1370, in build
    utils.check_call_env(cmd, env=env, cwd=src_dir, stats=build_stats)
  File "/Users/anthony/miniconda/lib/python3.6/site-packages/conda_build/utils.py", line 294, in check_call_env
    return _func_defaulting_env_to_os_environ('call', *popenargs, **kwargs)
  File "/Users/anthony/miniconda/lib/python3.6/site-packages/conda_build/utils.py", line 273, in _func_defaulting_env_to_os_environ
    raise subprocess.CalledProcessError(proc.returncode, _args)
subprocess.CalledProcessError: Command '['/bin/bash', '-e', '/Users/anthony/miniconda/conda-bld/wxpython_1521647577133/work/conda_build.sh']' returned non-zero exit status 1.

Any ideas?

Take a deep breath and dive in...

Haha, well, if there is a PR that someone wants me to try, I am happy to help out in that way.

Fails for me too -- looks like this is the actual failure:
In file included from /Users/Chris/miniconda3/conda-bld/wxpython_1521673702151/work/ext/wxWidgets/include/wx/string.h:46:
/Users/Chris/miniconda3/conda-bld/wxpython_1521673702151/work/ext/wxWidgets/include/wx/strvararg.h:25:14: fatal error: 'type_traits' file not found
    #include <type_traits>
             ^~~~~~~~~~~~~

looks like there is stuff on build.sh that is supposed to correct that :-(
I'm trying outside conda-build now -- hasn't crashed yet....
no idea what/where type_traits is..... I'll do a bit of research.
@scopatz: is that where it fails for you, too?
-CHB

OK:
a plain python setup.py build
worked fine on my machine, but when I tried to do that inside conda-build, I got the same failure:
/Users/Chris/miniconda3/conda-bld/wxpython_1521677390646/work/ext/wxWidgets/include/wx/strvararg.h:25:14: fatal error: 'type_traits' file not found
    #include <type_traits>

This is OS-X 10.13
$ clang --version
Apple LLVM version 9.0.0 (clang-9<IP_ADDRESS>)
So what's different about how conda-build sets things up???

I believe that was fixed. Please re-open if it is still relevant.


hash: expose text param for md5 hashing in top level API calls

prereq for https://github.com/iterative/dvc/issues/4658

Codecov Report
Patch coverage: 71.42% and no project coverage change.

Comparison is base (be6748b) 58.07% compared to head (eaf1df2) 58.07%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #359   +/-   ##
=======================================
  Coverage   58.07%   58.07%
=======================================
  Files          54       54
  Lines        3611     3611
  Branches      638      638
=======================================
  Hits         2097     2097
  Misses       1417     1417
  Partials       97       97

Impacted Files
Coverage Δ

src/dvc_data/hashfile/build.py
17.32% <50.00%> (ø)

src/dvc_data/hashfile/hash.py
75.75% <100.00%> (ø)

src/dvc_data/index/save.py
76.47% <100.00%> (ø)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


lot of issues on Android

I've build a video player for iPhone but when I open the same codebase on Android, a lot of functionality is broken. Preview images don't show. Stop doesn't work, Rate (slow motion) doesn't work. Videos keep playing when navigating away.
Before I start filing issues, am I suppose to build a separate player for Android? Are there known issues on Android? Other people experiencing similar issues using one codebase  for both platforms?
Thanks.
"react": "^15.2.1",
"react-native": "0.30.0",
"react-native-video": "^0.8.0",

I also have similar problems, I hope Android issues can be solved soon. Thanks!

@beebase There are a number of android issues open at the moment, I would recommend perhaps searching the known issues, and for any issues you don't see, please feel free to open individual issues for the problems you are seeing.


10px white circle in OHLCTooltip

I'm not sure what the goal was with this white circle in the OHLCTooltip?  It exists only in /v0.6.0-beta.7 and /v0.6.0-beta.6.
It is positioned right on top of the text, covering up part of the word "Date".  I had to hide it with CSS.

https://github.com/rrag/react-stockcharts/blob/v0.6.0-beta.7/src/lib/tooltip/OHLCTooltip.jsx#L61

my bad, will publish a new beta version removing it

👍 Cool, thanks!

You can temporary fix this with css, for example:
circle {
dyslay: none;
}

published 0.6.0-beta.8 install latest as
npm i -S react-stockcharts@next


Enhanced build version.h collisions

The CMAKE build system CFE/cmake/version.cmake code generates a version.h file that overrides the version.h required to build for VxWorks.
Suggested fix is to change the generated filename to cmake_version.h, and make the change to CFE/cmake/target/src/target_config.c to include the new filename

Trac comment by mgrubb on 2016-04-27 16:44:59:
Pushed proposed fixes to new branch trac-155-cmake-version-h at commit [https://babelfish.arc.nasa.gov/trac/cfs_cfe/changeset/cd8c168e7aac812797cd059c17fa9f6ffe372a93/ cd8c168]

Imported from trac issue 155.  Created by mgrubb on 2016-04-26T13:39:52, last modified: 2019-03-05T14:57:55

Trac comment by glimes on 2016-05-03 12:09:57:
Recommend approve/accept.
As a quick check, I kicked off a Bamboo run for this fix, see
https://babelfish.arc.nasa.gov/bamboo/browse/CFS-CFSCFE68/latest
We do not bring up any ground-station software, so we do not capture
any of the NOOP command responses, but the EVS initialzation message
looks correct:
{{{
EVS Port1 42/1/CFE_EVS 1: cFE EVS Initialized. cFE Version <IP_ADDRESS>
}}}
There is a minor conflict between this change and the version numbering
fix provided in #184 (commit [changeset:cd8c168]) but resolution is trivial;
Git only flags it because one commit adds a line before the line that
the other commit modifies. I am comfortable with resolving this conflict
during the integration merge.
The trial merge test results can be found at
https://babelfish.arc.nasa.gov/bamboo/browse/CFS-CFSCFE69/latest
Checking the resulting logs from the merge, the only mention I see of 6.4
is where we are reporting the most recent Git TAG, which is correct as we
have not yet tagged the 6.5 release. Also note, this is confirming that
the fix for #184 is still effective after merge conflict resolution.
Otherwise, reports of version numbers are showing <IP_ADDRESS> correctly.

Trac comment by sstrege on 2016-05-03 11:10:22:
Approve/accept with confirmation that the new cmake version.h filename produces the correct version information when run.

Trac comment by glimes on 2016-05-18 10:05:17:
Verfied integrated to development as part of 2016-05-03 integration.

Trac comment by jhageman on 2019-03-05 14:57:55:
Milestone renamed


why does cross entropy kernel uses if label_idx != -100?

Hello,
Thanks for your nice repo!
I was looking at your cross entropy loss Triton kernel and have a question. What is the reason for using if label_idx != -100 on this line and this line? Is the condition not always true?

-100 is generally accepted value for masked tokens. Why do you say that this expression will always be True? It will be only true for some tokens when training MLM or padding batches.

@mgrabban Yep @tdolega is correct :) -100 is generally for masked out tokens or padding tokens, so we must ignore them in the CE Loss calculation.
For example:
10, 20, 30, -100, -100, -100
31, 35, 12, 123,    123,   312

2 sentences are different in length, so we have pad the first shorter one with -100s. We then mask them out during the cross entropy loss calculation

Ok I got it now. I did not know. Thanks for clarifying!


Add foldNames function

Oh my. Forgot to update doc when renaming the function. I'll fix that.

Finished. Ready for merging, @garyb , @jdegoes .

@chrisdotcode Looks good, can you resolve conflicts?

Will do.

I don't quite get the purpose of this fold-func. The same result can be achieved using following
peel <<< (maybe defaultValue (either (runDirName >>> handleDirName) (runFileName >>> handleFileName)))

Closing this pr as in #33 structure of Pathy was simplified and similar fold function was added.
@chrisdotcode thanks for the work anyways!


wsl mount vhd not working

Version
Microsoft Windows [Version 10.0.22000.556]
WSL Version

[X] WSL 2
[ ] WSL 1

Kernel Version
<IP_ADDRESS>
Distro Version
Ubuntu 20.04
Other Software
No response
Repro Steps
wsl --mount --vhd workdata.vhdx
but if use Mount-VHD command, and mount with DiskPath will successful mount.
Expected Behavior
mount vhd successful
Actual Behavior
K:\>wsl --mount --vhd workdata.vhdx
拒绝访问。

Diagnostic Logs
No response

The --vhd option is only available via the Store version of WSL.

my wsl is store version
wsl --version
WSL 版本： <IP_ADDRESS>
内核版本： <IP_ADDRESS>
WSLg 版本： 1.0.30
MSRDC 版本： 1.2.2924
Direct3D 版本： 1.601.0
Windows 版本： 10.0.22000.556

/logs

Hi @SquallATF , try this:
If you mounted the disk in the past using wsl --mount, before installling the wsl preview from the store:
1. run wsl --shutdown

2. make a copy of the vhdx file

3. try now wsl --mount --vhd 'vhdx copy'

Does it show the same error?

I have make a copy of the vhdx and mount successful. Then I tested create new vhd and vhdx, all of them can mount successful.
But I still have a question the vhdx file that cannot be mounted is actually a new one created by Device Manager. That vhdx file still mount failed.

Hi @SquallATF , try this:
If you mounted the disk in the past using wsl --mount, before installling the wsl preview from the store:
1. run wsl --shutdown

2. make a copy of the vhdx file

3. try now wsl --mount --vhd 'vhdx copy'

Does it show the same error?

I have make a copy of the vhdx and mount successful. Then I tested create new vhd and vhdx, all of them can mount successful. But I still have a question the vhdx file that cannot be mounted is actually a new one created by Disk Management. That vhdx file still mount failed.
I seem to have found the cause of the problem, if vhd/vhdx is created by Disk Management and did not detach from Disk Management, then run wsl --mount --vhd command to mount that vhdx will report access denied. Then detach that vhdx from Disk Management, wsl mount will always report access denied. After that, even delete the vhdx and then create a new vhdx with the same name, it still cannot be mounted. Even after reboot the computer.
Some test, message is translated from Chinese
K:\>wsl --mount --vhd test1.vhdx
access denied.

K:\>copy test1.vhdx test2.vhdx
         1 file(s) copied.

K:\>ren test1.vhdx test3.vhdx

K:\>wsl --mount --vhd test2.vhdx
Disk attached but mount failed: Operation not permitted.
For more information, run 'dmesg' in WSL2.
To detach the disk, run 'wsl.exe --unmount \\?\K:\test2.vhdx'.

K:\>wsl --mount --vhd test3.vhdx
access denied.

K:\>wsl --unmount test2.vhdx
The operation completed successfully.

K:\>ren test2.vhdx test1.vhdx

K:\>ren test3.vhdx test2.vhdx

K:\>wsl --mount --vhd test1.vhdx
Disk attached but mount failed: Operation not permitted.
For more information, run 'dmesg' in WSL2.
To detach the disk, run 'wsl.exe --unmount \\?\K:\test1.vhdx'.

K:\>wsl --mount --vhd test2.vhdx
access denied.

Yes, you can run
wmic diskdrive get Availability,Capabilities,CapabilityDescriptions,DeviceID,InterfaceType,MediaLoaded,MediaType,Model,Name,Partitions
and check the states of the disks after a restart to see it.

Yes, you can run
wmic diskdrive get Availability,Capabilities,CapabilityDescriptions,DeviceID,InterfaceType,MediaLoaded,MediaType,Model,Name,Partitions
and check the states of the disks after a restart to see it.

vhdx is not show in that list

Yes, you can run
wmic diskdrive get Availability,Capabilities,CapabilityDescriptions,DeviceID,InterfaceType,MediaLoaded,MediaType,Model,Name,Partitions
and check the states of the disks after a restart to see it.

vhdx is not show in that list

Yes, the same happens here. Even if the disk is not mounted, we get the message access denied. I uploaded the logs with the 2 scenarios.

I found the reason for wsl return access denied. if the vhd is created under the user profile directory , the vhd owner is BUILTIN\Administrators and access is NT AUTHORITY\SYSTEM. But if  the vhd is created outsise the user profile directory,  the vhd access will changed to BUILTIN\Administrators, then wsl --mount --vhd will get access denied. when make a copy of that vhd the owner will changed to local user and mount will succeed.

After fix vhd acl, the vhd can be mounted successfully.

I found the reason for wsl return access denied. if the vhd is created under the user profile directory , the vhd owner is BUILTIN\Administrators and access is NT AUTHORITY\SYSTEM. But if the vhd is created outside the user profile directory, the vhd access will changed to BUILTIN\Administrators, then wsl --mount --vhd will get access denied. when make a copy of that vhd the owner will changed to local user and mount will succeed.

After fix vhd acl, the vhd can be mounted successfully.

I just checked th ACL on the vhdx files like you said.
But my vhdx files always are created and kept outside user profile directory.
I tried New-VHD and the Disk Manager for creating the files, both creates it with the same ACL.
I wonder, isn´t the original ACL the correct way? Should we really changed it? For now, it works.

I just checked th ACL on the vhdx files like you said.
But my vhdx files always are created and kept outside user profile directory.
I tried New-VHD and the Disk Manager for creating the files, both creates it with the same ACL.
I wonder, isn´t the original ACL the correct way? Should we really changed it? For now, it works.

There is a small mistake in the previous explanation, the local user has access rights to the vhdx created in the user profile directory but does not have access rights to the vhdx created outside the user profile directory.

Thanks for reporting this @SquallATF.
Looking at the logs, WSL is getting access denied when trying to attach the disk to the VM, which shows that the ACL on the file don't allow full control the user.
Closing since this is by-design (WSL can't bypass the filesystem ACL when mounting vhd's).


add keycloak to allauth

Related to #456
adds logo and snippet

Coverage remained the same at 90.46% when pulling b9f5457c4b6c87900d51158ba6f7e592ce96635c on MyPyDavid:dev-add-keycloak-to-allauth into dbdcc1f2eb6e033e377898a8bf198282f82813c1 on rdmorganiser:dev.

@MyPyDavid This is ready right? Not draft anymore?

yes, this part just adds the logo and the login button


Code to get cleaned_html from raw_html

Is there code available to get the cleaned_html from the raw_html
Thanks

Duplicate of https://github.com/OSU-NLP-Group/Mind2Web/issues/27, will update that issue.


Member variable should not be a reference; causing crash when used in destructor.

Please simplify line 293 to:
targets_.emplace(name, MakeOrphanable<WeightedChild>(Ref(DEBUG_LOCATION, "WeightedChild"), name))
Thanks!

@jtattermusch We'll need to back-port this to the 1.31 branch before the release.


fix startup on pthreads

Emscripten doesn't run preRun, onRuntimeInitialized or postRun on
pthread workers.  it sets insantiateWasm to a custom callback that
receives the wasm code using postMessage from the main thread, so we
don't need our instantiateWasm, either.

I did something similar. We could close this one


ZEP 2 - Sharding storage transformer

Preview of the draft for ZEP2, for internal reviews.
View it rendered with docker run -p 4000:4000 -v $(pwd):/site bretfisher/jekyll-serve

@philippotto @normanrz Thanks a lot for the great feedback! I incorporated most of it, could you please have another look?


Utility functions to escape strings

Would it be possible to provide a utility module to provide functions for, say, search filters? I am sure there are other stuff that needs escaping, or some sort of special handling.
I wrote something, but I am not even sure if it's correct, because I am not familiar with LADP.

Note that escaping is needed only for value literals in the string representation of a filter, but yes, having a utility function for that is a good idea. I'll try add one for the next development release of the library (0.5.x).
What you wrote is correct AFAICS, as it completely captures the UTF1SUBSET production from RFC 4515.

Right. I am guessing we don't have to worry about invalid UTF-8 for Rust because the strings are guaranteed to be valid UTF-8 and would have error-ed elsewhere.
Thanks.

Escaping function added in 5db4c395dfef97a5128d4df36a6b4a255230b561, but I won't close the issue until there's a published version on crates.io.

ldap_escape() is in 0.5.0, so this issue can be closed.


Using multipart/form-data with multer causes CRA app to crash and dev server restart intermittently

Is this a bug report?
Yes
Did you try recovering your dependencies?
Yes
yarn --version
1.5.1
Which terms did you search for in User Guide?
Upload, form-data, multipart, fetch
Environment

node -v: v8.9.4
npm -v: 5.6.0
yarn --version (if you use Yarn): 1.5.1
npm ls react-scripts (if you haven’t ejected<EMAIL_ADDRESS>C:\Users\mikem\OneDrive\Desktop\ecommerce-platform\Omni-Commerce
`--<EMAIL_ADDRESS>
Then, specify:

Operating system: Windows 10
Browser and version (if relevant): Firefox

I am having a frustrating bug that I can't pin down - my entire React application is refreshing with a The development server has disconnected. Refresh the page if necessary. - This is occurring after I send a multipart/form-data fetch request to my API from the client. Something is wrong with the fetch request - it is causing the entire CRA app to reset, flushing the state.
The path to this bug is through a simple form that should allow the user to upload a new item to the database, as well as attaching an image through a file type input. The JSON data is used to create a new DB entry, the API handles the file upload using the multer library, and the filepath of the image is appended to the DB entry so an image can be loaded dynamically upon React DOM render.
Something is really going wrong with the fetch request. About 50% of the time it will proceed without a problem. However, something is inherently problematic about using FormData as the Body of a multipart/form-data fetch request. To test, I have repeatedly submitted this upload form. It can work 10 or 20 times. Then, for no reason, the dev server will reset, the page will go blank and reload. There is no change in the CRA terminal.
The behavior of the requests is strange as well - a successful request will be logged with a status code
i.e. POST /storeItem 200 14.994 ms - 281
Yet a failed request will lack a status code in the network tab and in the API terminal
i.e. POST /images/marketplace-item - - ms - -
Here is a gist of some code to reproduce the issue:
https://gist.github.com/Mikhail-MM/5c843ef8c77cf6d534c09f536ab0c06a

I can confirm this. CRA setup, axios and a multipart/form-data request causes a refresh (no crash for me).

self professed nuub here ... would it be too much to ask for a repo that reproduces the issue?
I'm interested as I have used FormData and multer to push mixed data to mongo via express in last few projects and have not encountered this behaviour. That said, I use passport.js for auth and use c-r-a built-in proxy (so no cors), if that makes a difference.

Hi @nikrb. Where do you keep your uploaded files? I was keeping them in client's public directory as I explained here: https://github.com/expressjs/multer/issues/566#issuecomment-374043055
So, when I change my logic problem solved for me. But, still I wonder if this is normal or not.


Syntax highlighting not being applied

First of all, thanks for this extension. It has made my life a bit easier and my code navigation a bit more comfortable :)
It seems however, that something is preventing syntax highlighting to be applied to the docs. In the attached image you can see some (Haskell) code on the right, and then the docs on the left, all in black and white. I've double-checked, and the documentation is coloured in the hover view.

For the record, I have some extensions installed which work on Markdown: Github Markdown Preview, Markdown Checkboxes and Markdown Emoji. I don't know if those conflict in any way.
I am also happy to contribute a patch with some guidance. After all, it's Hacktoberfest season!

Please share steps to reproduce this issue (including example code as text)

Install VSCode and the Haskell extension
Create a file named Module.hs with the following contents:

module Module where

f :: Int
f = 5

Wait a while until the Haskell extension is set up for the first time and loads the file.
If you hover over Int you see Int :: * with syntax highlighting, but on the Documentation panel this is on black.


Slim 637 couple mbus device

SonarQube analysis reported 2 issues

 1 major
 1 info

Watch the comments in this conversation to review them.
1 extra issue
Note: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:

 InstallationService.java#L92: Complete the task associated to this TODO comment.

All is well.

SonarQube analysis reported 2 issues

 1 major
 1 info

Watch the comments in this conversation to review them.
1 extra issue
Note: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:

 InstallationService.java#L90: Complete the task associated to this TODO comment.

All is well.

SonarQube analysis reported 2 issues
Note: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:

 ActionMapperService.java#L144: Private method 'postConstruct' is never used.
 InstallationService.java#L91: Complete the task associated to this TODO comment.

All is well.

The actual right merge is done in: https://github.com/OSGP/Platform/pull/473
This PR can be forgotten


Version 2.0.0-alpha.31

Landed in https://github.com/metarhia/impress/commit/0cc120744f685aa2b3cdb70b178a702c767f158d


React.createClass is deprecated and will be removed in version 16.

Warning: Tappable: React.createClass is deprecated and will be removed in version 16. Use plain JavaScript classes instead.
https://facebook.github.io/react/blog/2017/04/07/react-v15.5.0.html

Fix is in Pull Request


[en] Update go lang link kubelet-config.v1beta1.md

/lgtm
Verified new link goes to expected place.

thank you for updating the links
/approve


Option for using local file upload

Give developers an option to use local file upload instead of relying only on Cloudinary CDN.
Details will be coming.

Can I know where I can found local file upload version of it?

I guess I have problem with uploading image with Cloudinary.


Bug on creating repos

When the user that sign-up is the owner of the repo, the repo is being created without the owner on it's name.

I just tested that and that works fine on my branch

I was able to reproduce the bug.
404 is only returned the first time.

This does not seems to apply to "forked only" projects.

I was not able to reproduce on localhost...


[Feature Request] Cache next page

Is your feature request related to a problem? Please describe.
I have some heavy file (the page are about 2mb each). When I use the reader via internet only one page is loaded. When I go to the next it takes some time to load it.
Describe the solution you'd like
Cache the 1 or more next page

Hi! Did you use a paged mode on the viewer? I have a similar experience on that.

Yes, the paged mode don't load any of the next pages

Hi! It's implemented on my machine but waiting for #214 merged


Keep screen on

I'm using a custom mount with no power cord to try rthis out.
I would suggest to use android:keepScreenOn="true" on the https://github.com/osunick/candash/blob/main/android/app/src/main/res/layout/activity_fullscreen.xml
Since most people would not want their screen to turn off if the app is open.
Alternatively if you feel someone would not want this feature it could be a new pref in the settings allowing the end-user to eventually decide if they want or not the flag toggled.

The main reason it behaves this way is so that it will power down when the
car sleeps, as my goal was an experience that didn't need any interaction
if you wanted to leave it alone, and I'll think about changing this
behavior when I do feature work again, but as a non default pref.
On Sat, Feb 19, 2022, 9:06 AM Andrea @.***> wrote:

I'm using a custom mount with no power cord to try rthis out.
I would suggest to use android:keepScreenOn="true" on the
https://github.com/osunick/candash/blob/main/android/app/src/main/res/layout/activity_fullscreen.xml
Since most people would not want their screen to turn off if the app is
open.
Alternatively if you feel someone would not want this feature it could be
a new pref in the settings allowing the end-user to eventually decide if
they want or not the flag toggled.
—
Reply to this email directly, view it on GitHub
https://github.com/osunick/candash/issues/6, or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAD72K5Y4HFSON72ALCPE2LU37E2ZANCNFSM5O2YKA6A
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

It could also work this way. If car is in "P" then setscreenalwayson to
false. If car is in drive then set it to true?
Il sab 19 feb 2022, 19:20 Nick Nguyen @.***> ha scritto:

The main reason it behaves this way is so that it will power down when the
car sleeps, as my goal was an experience that didn't need any interaction
if you wanted to leave it alone, and I'll think about changing this
behavior when I do feature work again, but as a non default pref.
On Sat, Feb 19, 2022, 9:06 AM Andrea @.***> wrote:

I'm using a custom mount with no power cord to try rthis out.
I would suggest to use android:keepScreenOn="true" on the

https://github.com/osunick/candash/blob/main/android/app/src/main/res/layout/activity_fullscreen.xml

Since most people would not want their screen to turn off if the app is
open.
Alternatively if you feel someone would not want this feature it could be
a new pref in the settings allowing the end-user to eventually decide if
they want or not the flag toggled.
—
Reply to this email directly, view it on GitHub
https://github.com/osunick/candash/issues/6, or unsubscribe
<
https://github.com/notifications/unsubscribe-auth/AAD72K5Y4HFSON72ALCPE2LU37E2ZANCNFSM5O2YKA6A
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

—
Reply to this email directly, view it on GitHub
https://github.com/osunick/candash/issues/6#issuecomment-1046076710, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AABQ6S7SCEN4WNY4KLH6EFDU37NQBANCNFSM5O2YKA6A
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you authored the thread.Message ID:
@.***>

That's a really good idea. I'll implement that it a bit.
On Sat, Feb 19, 2022, 1:05 PM Andrea @.***> wrote:

It could also work this way. If car is in "P" then setscreenalwayson to
false. If car is in drive then set it to true?
Il sab 19 feb 2022, 19:20 Nick Nguyen @.***> ha scritto:

The main reason it behaves this way is so that it will power down when
the
car sleeps, as my goal was an experience that didn't need any interaction
if you wanted to leave it alone, and I'll think about changing this
behavior when I do feature work again, but as a non default pref.
On Sat, Feb 19, 2022, 9:06 AM Andrea @.***> wrote:

I'm using a custom mount with no power cord to try rthis out.
I would suggest to use android:keepScreenOn="true" on the

https://github.com/osunick/candash/blob/main/android/app/src/main/res/layout/activity_fullscreen.xml

Since most people would not want their screen to turn off if the app is
open.
Alternatively if you feel someone would not want this feature it could
be
a new pref in the settings allowing the end-user to eventually decide
if
they want or not the flag toggled.
—
Reply to this email directly, view it on GitHub
https://github.com/osunick/candash/issues/6, or unsubscribe
<

https://github.com/notifications/unsubscribe-auth/AAD72K5Y4HFSON72ALCPE2LU37E2ZANCNFSM5O2YKA6A

.
You are receiving this because you are subscribed to this
thread.Message
ID: @.***>

—
Reply to this email directly, view it on GitHub
https://github.com/osunick/candash/issues/6#issuecomment-1046076710,
or
unsubscribe
<
https://github.com/notifications/unsubscribe-auth/AABQ6S7SCEN4WNY4KLH6EFDU37NQBANCNFSM5O2YKA6A
.
Triage notifications on the go with GitHub Mobile for iOS
<
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
<
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub
.
You are receiving this because you authored the thread.Message ID:
@.***>

—
Reply to this email directly, view it on GitHub
https://github.com/osunick/candash/issues/6#issuecomment-1046102330, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AAD72K42PI7DPH7CLM3KHR3U4AAX5ANCNFSM5O2YKA6A
.
You are receiving this because you commented.Message ID:
@.***>

Closed because @carleeno implemented a better version of this idea.


Remove non-existing empty_like from Sphinx autosummary

I noticed that empty_like is listed in the top-level function API:
http://xarray.pydata.org/en/latest/api.html#top-level-functions
But I think it doesn't exist in xarray.
This PR removes the entry from the automodsummary list.
Also: I was the 100th person to fork xarray a minute ago.
What's my prize? I could use a better :car:  or a :house_with_garden: .

Thanks.  This snuck through in #668.  FWIW, there is a private method xarray.core.common._full_like.


Dispatch BAILOUT Event to Reducer when bailout function returns true.

I currently have the following logic using this middleware.
state = {     items: { itemID: itemObj, .... },     viewingItemID: itemID, }
Case 1:
'REQUEST' View Item> 'SUCCESS' Add new item to state -> Update viewingItemID to the item ID
OR
Case 2:
'REQUEST' View Item -> Bailout because View Item is already in the state (unable to update viewingItemID)
I then need to change the state's viewingItemID to the ID of the item the user would like to view .
However there is no action emitted to the reducer, so I cannot update the state after the bailout.
At the moment I get around this by dispatching actions 1: fetchItem, 2: setViewingItemID. However, this results in unnecessary state changes/react renders.
Would it be possible to add a bailout action that would be sent to the reducer?
Can I submit a pull request?

I'm not a maintainer of the project but it looks like it's been brought up before:
https://github.com/agraboso/redux-api-middleware/issues/94
Also, I support this idea of being able to bail out. For instance and autocomplete box would be a perfect use case. I would like to bail out of all of the http requests except the most recent one when the user is typing.


feat: group deps files together by filename

Not sure if you would prefer deps_server.ts. I used x.x.ts because it's similar to fresh.gen.ts.

Actually, this isn't so nice because deps.test.ts matches as a test file for deno test and in vscode.


required library (Eleccore) causing rendering issues with other mods

The ElecCore library required for deep resonance in 1.10.2 is breaking rendering of several other mods cause the items not to render at all (completely invisible). There is an open issue on the Eleccore github as well (https://github.com/Elecs-Mods/ElecCore/issues/67) but wanted to notify you additionally. Currently anyone wanting to use deep resonance and needing this library is subject to the render breaking in other mods.

What kind of rendering issues? Deep Resonance is in a lot of packs (FTB Infinity Lite, FTB HermitCraft, All The Mods, FTB Unstable) and nobody has ever reported rendering issues to me related to ElecCore. So what kind of render issue is this?

It's about the problem that his TEISR doesn't chain, it just calls super.renderByItem ... - which is bad if someone else already uses that same "hook" to render his things and then ElecCore just overwrites it. Details on the issue are added on ElecCore's issue that Saereth referenced.

Has already been fixed


High overhead in lu_solve due to get_lapack_funcs

I'm using Scipy 0.17.0 and Numpy 1.11.0 on Python 3.4.3 on a 64 bit Gentoo system.
I need to apply the inverse of several moderately sized dense matrices repeatedly and thought that LU factorization is perfect for the job. However, the implementation in Scipy seems to suffer from significant overhead. The following benchmark demonstrates my issue:
import numpy as np
import scipy.linalg
import cProfile

def bench_lu(n=100):
    A = np.random.rand(n,n)
    A_lu = scipy.linalg.lu_factor(A, check_finite=False)

    f = np.random.rand(n)
    for i in range(50000):
        f = scipy.linalg.lu_solve(A_lu, f, check_finite=False)

cProfile.run('bench_lu(n=100)', sort='tottime')

On my box, it produces the following output:
         2450029 function calls in 2.487 seconds

   Ordered by: internal time

   ncalls  tottime  percall  cumtime  percall filename:lineno(function)
   100002    0.760    0.000    1.000    0.000 numerictypes.py:942(_can_coerce_all)
    50000    0.692    0.000    2.418    0.000 decomp_lu.py:75(lu_solve)
    50001    0.243    0.000    1.642    0.000 blas.py:223(_get_funcs)
   700000    0.184    0.000    0.184    0.000 numerictypes.py:951(<listcomp>)
    50001    0.161    0.000    1.327    0.000 blas.py:177(find_best_blas_type)
    50001    0.082    0.000    1.119    0.000 numerictypes.py:964(find_common_type)
        1    0.067    0.067    2.487    2.487 numpy-benchmark.py:5(bench_lu)
   800003    0.056    0.000    0.056    0.000 {built-in method len}
    50001    0.035    0.000    0.050    0.000 numeric.py:414(asarray)
    50001    0.031    0.000    0.031    0.000 {built-in method isinstance}
    50001    0.031    0.000    0.031    0.000 numerictypes.py:1015(<listcomp>)
    50001    0.027    0.000    1.669    0.000 lapack.py:405(get_lapack_funcs)
    50001    0.026    0.000    0.026    0.000 blas.py:206(<listcomp>)
   100002    0.020    0.000    0.020    0.000 {method 'get' of 'dict' objects}
    50002    0.019    0.000    0.019    0.000 {built-in method getattr}
    50001    0.014    0.000    0.014    0.000 {built-in method array}
    50001    0.013    0.000    0.013    0.000 {method 'index' of 'list' objects}
    50001    0.008    0.000    0.008    0.000 {method 'append' of 'list' objects}
    50001    0.007    0.000    0.007    0.000 misc.py:169(_datacopied)
    50001    0.007    0.000    0.007    0.000 numerictypes.py:1016(<listcomp>)
        1    0.001    0.001    0.001    0.001 decomp_lu.py:17(lu_factor)
        2    0.000    0.000    0.000    0.000 {method 'rand' of 'mtrand.RandomState' objects}
        1    0.000    0.000    2.487    2.487 {built-in method exec}
        1    0.000    0.000    2.487    2.487 <string>:1(<module>)
        1    0.000    0.000    0.000    0.000 {method 'disable' of '_lsprof.Profiler' objects}

As you can see, more than half of the total time is spent in get_lapack_funcs, which is called by lu_solve. Of course, this is a per-call overhead for lu_solve and becomes less significant for larger matrices, but to me it seems excessively high for my test case of 100x100 matrices.

Under the hood lu_solve is using ?getrs, which can be accessed directly using the Cython bindings for Lapack:
https://docs.scipy.org/doc/scipy/reference/linalg.cython_lapack.html
That would eliminate the overhead.

Also, if you are absolutely sure about your data type you can call the corresponding LAPACK routine yourself.
def bench_lu(n=100):
    A = np.random.rand(n,n)
    A_lu, a_piv = scipy.linalg.lu_factor(A, check_finite=False)
    f = np.random.rand(n)
    for i in range(50000):
        x = scipy.linalg.lapack.dgetrs(A_lu, a_piv, f)

But this has no finiteness checks and size mismatch detections. So it is pretty fragile to use it like so.

get_lapack_funcs however probably can be sped up, since it's not doing
anything complicated.

I'm not seeing this at all:
   Ordered by: internal time

   ncalls  tottime  percall  cumtime  percall filename:lineno(function)
    50000  116.507    0.002  117.731    0.002 decomp_lu.py:75(lu_solve)
   100002    0.471    0.000    0.573    0.000 numerictypes.py:942(_can_coerce_all)
    50001    0.226    0.000    1.127    0.000 blas.py:226(_get_funcs)
    50001    0.157    0.000    0.830    0.000 blas.py:177(find_best_blas_type)
   800003    0.102    0.000    0.102    0.000 {len}
    50001    0.070    0.000    0.643    0.000 numerictypes.py:964(find_common_type)
        1    0.063    0.063  117.795  117.795 tmp14.py:5(bench_lu)
    50001    0.036    0.000    1.162    0.000 lapack.py:417(get_lapack_funcs)
    50001    0.035    0.000    0.050    0.000 numeric.py:463(asarray)
    50001    0.026    0.000    0.026    0.000 {isinstance}

And the line profiler results for
import numpy as np
import scipy.linalg

n = 100

A = np.random.rand(n,n)
A_lu = scipy.linalg.lu_factor(A, check_finite=False)

f = np.random.rand(n)
for i in range(1000):
    f = scipy.linalg.lu_solve(A_lu, f, check_finite=False)

are:
$ kernprof.py -l -v tmp14.py
Wrote profile results to tmp14.py.lprof
Timer unit: 1e-06 s

File: /home/rgommers/Code/scipy/scipy/linalg/decomp_lu.py
Function: lu_solve at line 75
Total time: 1.64857 s

Line #      Hits         Time  Per Hit   % Time  Line Contents
==============================================================
    75                                           @profile
    76                                           def lu_solve(lu_and_piv, b, trans=0, overwrite_b=False, check_finite=True):
    77      1000          972      1.0      0.1      (lu, piv) = lu_and_piv
    78      1000          901      0.9      0.1      if check_finite:
    79                                                   b1 = asarray_chkfinite(b)
    80                                               else:
    81      1000         2131      2.1      0.1          b1 = asarray(b)
    82      1000         1941      1.9      0.1      overwrite_b = overwrite_b or _datacopied(b1, b)
    83      1000         1379      1.4      0.1      if lu.shape[0] != b1.shape[0]:
    84                                                   raise ValueError("incompatible dimensions.")
    85
    86      1000        61475     61.5      3.7      getrs, = get_lapack_funcs(('getrs',), (lu, b1))
    87      1000      1577477   1577.5     95.7      x,info = getrs(lu, piv, b1, trans=trans, overwrite_b=overwrite_b)
    88      1000         1400      1.4      0.1      if info == 0:
    89      1000          895      0.9      0.1          return x
    90                                               raise ValueError('illegal value in %d-th argument of internal gesv|posv'
    91                                                                                % -info)

@rgommers Why does your program take 117s to execute, when mine ran in 2.4s?

no clue, would need to compare that between builds on that machine and my other one. maybe some lapack related issue. will do that later.

I have similar timings as reported. It is just quite inefficient implementation of _can_corece_all, right?

For get_blas_? I think the overhead might be justified but for the lapack funcs I think indeed this is an unnecessary effort to pick the right lapack routine. It can simply check the dtypes instead of jumping all the hoops.


crypto/sm2/sm2_pmeth.c: add sm2 default userid

Checklist

[ ] documentation is added or updated
[ ] tests are added or updated

This should definitely be cherry-picked up to master as well, so I've labelled this for both master and 1.1.1.  To anyone who merges: it should be absolutely fine to start with applying this on 1.1.1 and cherry-pick it up to master, but the reverse should be harmless as well.

It looks like this triggered a bug somewhere, see https://travis-ci.org/openssl/openssl/jobs/605862230
More precisely, there's a memory leak.  And just FYI, it's not this PR's fault as far as I can see, so I think we've a case of sloppy cleaning somewhere else.
    # [05:46:59]  3748 file=crypto/sm2/sm2_pmeth.c, line=43, thread=47963119216704, number=17, address=0x13fe600
    # [05:46:59]  4537 file=crypto/sm2/sm2_pmeth.c, line=43, thread=47963119216704, number=17, address=0x13fe640
    # [05:46:59]  3555 file=crypto/sm2/sm2_pmeth.c, line=43, thread=47963119216704, number=17, address=0x1401100
    # 51 bytes leaked in 3 chunks
/home/travis/build/openssl/openssl/util/shlib_wrap.sh /home/travis/build/openssl/openssl/test/evp_extra_test => 1
not ok 1 - running evp_extra_test

@InfoHunter - please take a look at this.

@InfoHunter - please take a look at this.

sorry for commit nothing, just ignore it

I am not sure yet if we need to set the default ID to SM2 - discussions welcome ;-)

We use the default ID in most cases. User defined ids only appear in TEST scripts.

We use the default ID in most cases. User defined ids only appear in TEST scripts.

I was not saying the default ID should not be used. I was just explaining why OpenSSL doesn't set the ID by default. And there is indeed a reason about this:
For what OpenSSL has discussed before, we decided at that time it's the application's responsibility to set the default SM2 ID instead of OpenSSL's. So I don't know it's worth to change this consideration or not...

It looks like this triggered a bug somewhere, see https://travis-ci.org/openssl/openssl/jobs/605862230
More precisely, there's a memory leak. And just FYI, it's not this PR's fault as far as I can see, so I think we've a case of sloppy cleaning somewhere else.
    # [05:46:59]  3748 file=crypto/sm2/sm2_pmeth.c, line=43, thread=47963119216704, number=17, address=0x13fe600
    # [05:46:59]  4537 file=crypto/sm2/sm2_pmeth.c, line=43, thread=47963119216704, number=17, address=0x13fe640
    # [05:46:59]  3555 file=crypto/sm2/sm2_pmeth.c, line=43, thread=47963119216704, number=17, address=0x1401100
    # 51 bytes leaked in 3 chunks
/home/travis/build/openssl/openssl/util/shlib_wrap.sh /home/travis/build/openssl/openssl/test/evp_extra_test => 1
not ok 1 - running evp_extra_test

This would need to be submitted against the master branch to be considered. This is not a bug fix to be done on a released branch.


Mistake. The translator for the display does not work.

Hi. I'm facing a very big problem for me. In the translator settings, you can select a specific window (application) that will be translated. But also there you can choose not a window, but a computer screen (display). I select it, click "ok", but after that an error pops up: "This window cannot be captured. Make sure the window is activated."
Please help me solve this problem. This is the best translator that will help me a lot if I can translate the screen and not the computer window. The application that I want to translate into my native language, its interface with many phrases and words are in separate large and small windows. The "display translation" function + text translation overlay is just right for this. I will be very glad and grateful if you explain to me how to fix this error.
Thank you very much.

hello thank you for using mort
This function has been blocked intentionally.

You can replace it by selecting the OCR area for the screen area of the desired monitor.
Display import cannot handle overlays
This is because overlay results are also imported to the relevant display screen.

This will cause OCR to recognize it incorrectly.


Roll Engine from dbc97a09b495 to ea2a12375753 (1 revision)

https://github.com/flutter/engine/compare/dbc97a09b495...ea2a12375753
2021-09-05<EMAIL_ADDRESS>Roll Fuchsia Linux SDK from DzxXYKzlk... to GpAkjCJKU... (flutter/engine#28466)
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from DzxXYKzlkAQ9 to GpAkjCJKUcwV
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC<EMAIL_ADDRESS>on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Commit queue failed; closing this roll.


PySlice::new converts isize to c_long which is incorrect on Windows

Bug Description
When trying to take a large slice with PySlice::new(start, stop, step) one, can overflow and get back an erroneous answer on Windows platform.
Core of the issue seems to be here:
https://docs.rs/pyo3/latest/src/pyo3/types/slice.rs.html#43-52
https://doc.rust-lang.org/stable/std/ffi/type.c_long.html Which is said to be  i32 on Windows platform.
It seems using c_longlong https://doc.rust-lang.org/stable/std/ffi/type.c_longlong.html should fix the issue along with pyo3::ffi::PyLong_FromLongLong(start as std::ffi::c_longlong) which are defined to be at least i64 on most systems (including Windows x64bit where isize is i64 and c_long is not, which is the core of this issue)
Steps to Reproduce
Create a slice with either value being over i32::MAX. (it will silently overflow to negative values).
Backtrace
No response
Your operating system and version
Windows (any afaik)
Your Python version (python --version)
Any (afaik)
Your Rust version (rustc --version)
1.65 (but any)
Your PyO3 version
0.17.2
How did you install python? Did you use a virtualenv?
pyenv but all are affected afaik
Additional Info
Original report: https://github.com/huggingface/safetensors/issues/95
Temporary fix in the lib itself https://github.com/huggingface/safetensors/pull/99
Happy to contribute a PR if wanted.
@davidhewitt for visibility.

PyLong_FromSsize_t should be used; isize is what Python calls Py_ssize_t.


Environment variables in collections

I have a request with path <<root>>/public/blogger, which I want to run against different environments. I save this request in a collection. I would expect to be able to change the environment (and, hence, root) again later. But when I load the saved request, root is already replaced with the value it had when I saved the request.
Video: https://fashiontale.org/index.php/s/Aaz77P7breqAeK8

Thanks for reporting the issue.


Access to current non finished sagas

Is there a way to access to the rootSagas array or all the non finishes sagas?
I'm trying to make a graph of my sagas (threads) executing at a given time.

This would be nice to have -- some sort of analysis capability to check if there are runaway sagas not be handled.  Especially since spawn() can make this situation happen extremely easily since it also detaches from the ROOT saga (something I dont agree with personally - i think spawn should just be a separate context still attached to the root saga so that you can cancel it knowing ALL sagas are cancelled)

I think this should be possible to be built on sagaMonitor.
@bradennapier could u create an issue thread with the description of the problem and proposed solution?

for an example of use see
https://github.com/redux-saga/redux-saga/blob/master/examples/sagaMonitor/index.js
https://github.com/redux-saga/redux-saga-devtools/blob/master/src/store/createSagaMonitor.js
Esp. root Sagas can be recognized with the field root: true during the EFFECT_TRIGGERED event.

I actually (kind of) already have a solution built that could possibly be extended upon to provide a graph-like functionality.  I use it for redux-saga-process v2 which is a signifcant upgrade of the entire concept there.
It includes the capability to get a graph-like result of all your running tasks as well as keeping them all organized, logging errors in a much more helpful way, etc etc.
https://github.com/Dash-OS/saga-task-manager
It's definitely not something i would use in production -- it's definitely reliable but may require some code reading to understand the internals.
Also has some nice logging options:

@bradennapier awesome! I will take a look! thank you!

The more I use it, the more I realize how essential it is truthfully.  In terms of handling tons of forks and spawns while making sure it all comes together nicely it is critical.  Today was troubleshooting a few things and it made fixing something that would no doubt take hours extremely simple.
@Andarist @yelouafi - i wonder if the option to enable a high-quality logging option internally may not be extremely useful?  sagas introduces a concept which can be hard to understand what is really occurring behind the scenes.  I feel it's probably fairly easy to have things accidentally happening in the background that are eating up users performance if they don't understand some of the core details of how it all works.
Perhaps some way of monitoring things like if there seems to be a high number of running tasks that are not completing (memory leaks), etc?

Yeah, monitoring options would be really cool - integrated in some kind of redux-saga-devtools. But those are rather plans for the future.


Add drivers for icp101xx and icp201xx

You will need to modify also the https://github.com/tdk-invn-oss/zephyr.hal_tdk/blob/main/CMakeLists.txt file

You may also update the README.txt to expose new drivers available

Good spot, now fixed


error when using the vsd --capture behind cloudflare warp connection

description
specific sites are blocked in my country. i need to use cloudflare warp to unblock the targeted sites. but the problem occurs when using the vsd within the cloudflare warp connection.
command
vsd https://www.youtube.com/watch?v=vT1HI_-dJwA --capture

command vsd https://test-streams.mux.dev/x36xhzz/x36xhzz.m3u8 -o video.mp4 working perfectly. the problems only occur in the capture & collect feature.

error

tech stack
vsd

google-chrome

ffmpeg

cargo

os
wsl 2 with ubuntu 20 distro within windows 11
another
also, gui version of the google-chrome usually works within wsl 2

--captureand --collect works on same principle. So if collect fails capture will also fail and vice versa. For --collect flag I mentioned the reason for it's fail.

@clitic sometimes i got the error, and sometimes it's just worked. I'm a little confused about what's the reason. for now, i'll close this issue. i am not sure the cause comes from cloudflare warp. thanks.


Update use cases for AniList

Resolve #13.

Codecov Report

Merging #20 (9ccfee7) into master (f1f4638) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master      #20   +/-   ##
=========================================
  Coverage     72.15%   72.15%
  Complexity      399      399
=========================================
  Files            70       70
  Lines          1232     1232
  Branches        125      125
=========================================
  Hits            889      889
  Misses          311      311
  Partials         32       32

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f1f4638...9ccfee7. Read the comment docs.

Probably should label each use case with specific id for easier identification.

not lgtm, merge conflict first


[AVM Module Issue]: Cognitive Services Module should add the output account.properties.endpoints

Check for previous/existing GitHub issues

[X] I have checked for previous/existing GitHub issues

Issue Type?
Feature Request
Module Name
avm/res/cognitive-services/account
(Optional) Module Version
No response
Description
Please add the output account.properties.endpoints.
For example (azd):

https://github.com/Azure/azure-dev/blob/main/templates/common/infra/bicep/core/ai/cognitiveservices.bicep#L54

CC: @jongio
(Optional) Correlation Id
No response

@NanaXiong00 Thanks for submitting this. I will take a look at adding this next week.

@ilhaan, just checking in on how you are getting on with this ask as @jongio and team require this for some azd dependencies on AVM 👍
Can you provide us an update and rough ETA?
Thanks

@jongio @jtracey93  just checking, you only need the raw output of the properties.endpoints right? I saw in most kinds of cognitive services these are just replica's of the single endpoint output, but for OpenAI there are some differences.

@NanaXiong00 & @jongio to answer here :)

THe raw typed output makes sense to me.

Related to PR: https://github.com/Azure/bicep-registry-modules/pull/2735


I fix bug 1

I added an additional line to fix the layout... the simplest way.

Add new Geothink logo


create a tag page

a tag page can be useful for users to add tags to their page and to dislay the results based on the tags filter.
the tag page can be based on json format for easier treatment of the info.

Th tag page has been included in model and test case template


In the inventory, Soul Glass Panes shows the + shape instead of the typical glass item model

This issue will be fixed in the next release.


Alternate native preload

Turns out that the PATH manipulation in the Unity code doesn't work well (at all) with the SetDllDirectory static constructor I had added here. Thus, as suggested in https://github.com/OSVR/OSVR-Unity/issues/19#issuecomment-90218483, I've switched to doing LoadLibrary calls of the DLLs in dependency order. Further, I've moved that out of a static constructor and just into a plain static method, for optional calling if you want that added help in ensuring you can find the native libs.
I can confirm that running the examples on a 64-bit machine (in 64-bit mode) works, and the assembly works when used with the Unity integration.
Caveats to my testing or design: I don't know if there's a way to only call the LoadLibrary code if it's required (in a static constructor, so it would be automatic in a more cautious way), or if Mono or other runtimes do a mapping so that a pinvoke of LoadLibrary makes something happen on non-Windows platforms thus making my inclusion of lib*.so code worthwhile. Also, at the moment we're just basically "leaking" the library handles - just a one-time thing, though, automatically cleaned up at process exit, (if the static method is called again, additional loadlibrary calls just increase a per-process ref count, so no way it will leak more than 4 library handles), and I wouldn't really expect to be able to change the native DLLs out from under an app while it's running anyway.

@JeroMiya Pushed changes to reflect your feedback and generally make the code more consumable

Per comment in the Unity issue, merging this as OK.


no file about model_concat_upsa_1nn_cycle_nuscenes.py ?

@HimangiM Hi, in your command_train_cycle_nuscenes.sh file, there seems an model named model_concat_upsa_1nn_cycle_nuscenes. However, we couldn't find it in your repo. Would you mind provide it later?

Hi,
Thank you for pointing it out. You can use the model named model_concat_upsa_cycle under the src folder.

@HimangiM Hi, thanks for answering the question. Just a few small questions and it would be appreciated a lot if you could help to answer.
1). In the paper, you mention that you are using the Flownet3d pre-trained model on the FlyingThing3D dataset. I am just wondering is it supervised pretraining? During this pretraining process, have you applied the flip strategy?
2). I am trying to rewrite your work with pytorch module and will release it later to contribute the community. But I found the knn_l2_loss could converge quickly but the cycle_l2_loss cannot converge at all. Do you have any idea of this problem?


Here is v2.4.2

https://github.com/vthierry/wordpress-add-meta-tags

I see! 2.11.3 is later.

Thanks @szepeviktor - I should perhaps look for existing forks first, but I'm not going to make any big changes anyway, mainly make sure the plugin still runs on PHP 8...

This plugin is very close to a script. Flowing statements.
It need a rewrite to be application-like.


continue_link is added to every header, even when no link is present

https://github.com/getgrav/grav-theme-quark/commit/6fd5946ba1d9748c861702fa65878131bfebc9b2 added continue_link to the blueprint. Now every page saved using the admin plugin contains continue_link: true, even if no link is supplied at all, which is ugly.

Fixed


Apply Import Validation checks against Workspace Source Data to Import API

Existing Import API enpoint:
https://api.epa.gov/easey/dev/monitor-plan-mgmt/swagger/#/Plans %26 Configurations/MonitorPlanWorkspaceController_importPlan
Validate MP Unit Stack information with existing wokrspace tables
[ ] Import Check 1 - MP Facility Present in the Production Facility Table
[ ] Import Check 2 - Unit/Stack Present in the Production Unit Table and associated to the import facility
For Import Check 2, consider both scenarios:
When importing files for single Units

Confirm camd.unit table contains at least one record with unitid=locations.UnitID from file and fac_id= camd.plant record with the ORISCode from the file

When importing files for Stack Pipes

Confirm the camdecmpswks.stack_pipe contains one record with stack_name=UnitStackConfiguration.StackPipeID from file and fac_id=camd.plant record with the ORISCode from the file - foreach UnitStackConfiguration element
Confirm camd.unit table contains one record with unitid=locationData.UnitID from file and fac_id= camd.plant record with the ORISCode from the file - foreach UnitStackConfiguration element
Confirm camdecmpswks.unit_stack_configuration contains one record for each combination of (UnitStackConfiguration.StackPipeId, UnitStackConfiguration.UnitID)

Update current import checks to account for Import Check 1 and rename Import Checks' description

TC604 Passed