System.Runtime requires NuGet 3.0

The message from  I tried to add System.Runtime in monodevelop:
The 'System.Runtime 4.0.20' package requires NuGet client version '3.0' or above, but the current NuGet version is '<IP_ADDRESS>'.

I started to add it because of compiler messages:
/var/calculate/remote/distfiles/egit-src/X.PagedList.git/src/X.PagedList.Mvc.Example/Controllers/BaseController.cs(13,13): Error CS0012: The type `System.Collections.IEnumerable' is defined in an assembly that is not referenced. Consider adding a reference to assembly `System.Runtime, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a' (CS0012) (X.PagedList.Mvc.Example)

NuGet 3 support has also been reported on bugzilla
NuGet 3 support is a fairly big change and just adding support for being able to install NuGet 3 packages into a project with MonoDevelop or Xamarin Studio is not enough. NuGet 3 packages generally only have assemblies for .NET Core and ASP.NET 5. To support NuGet 3 fully we will need support in the build system so the assemblies are resolved at build time for other target frameworks.

please explain your words about "build system"
I thought that it's already implements that - https://github.com/mono/mono/blob/ad9226cec75f67b5e4954f2b2cccb57df590b883/man/xbuild.1#L110-L150

If you install a NuGet 3 package into a project with Visual Studio it will create a project.json file with NuGet package id and version added. On Windows there is a NuGet specific MSBuild .targets file that resolves the assemblies required by the NuGet package in this project.json file. These NuGet .targets are not currently available on non-Windows systems.

I'm curious if there is anything new in this area a year and a half later.  Can someone confirm the most recent version of Nuget which will work wtih monodevelop on linux?  It seems everything I can find is years old.

@genterminl - It depends which version of MonoDevelop you are using. Later MonoDevelop versions uses more recent NuGet versions.

MonoDevelop 5.10 - uses NuGet 2.8.7
MonoDevelop 6.1 - uses NuGet 3.4.3
MonoDevelop 6.2 - uses NuGet 3.5
MonoDevelop 7.0 - uses NuGet 4.0

If you are using MonoDevelop before 6.1 then you cannot just upgrade the NuGet support. The change from NuGet v2 to v3 involved many changes on the MonoDevelop side.


Documentation references deprecated azure-sb package

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 6b4435f8-c50c-57a3-c98c-c089b280afec
Version Independent ID: 545a9fa0-0f61-4a67-4de0-7356fe399259
Content: Sending push notifications with Azure Notification Hubs and Node.js
Content Source: articles/notification-hubs/notification-hubs-nodejs-push-notification-tutorial.md
Service: notification-hubs
GitHub Login: @sethmanheim
Microsoft Alias: sethm

@ndrone-kr
Thanks for your feedback! We will investigate and update as appropriate.

@ndrone-kr Thanks for the feedback! I have assigned the issue to the content author to review further and update the document as appropriate.

@ndrone-kr Very sorry for the slow response here. We are aware that this documentation is out of date and are working with the engineering team to update it. In the meantime, you can find information about the updated Node.js SDK packages here: https://github.com/azure/azure-sdk-for-node#announcing-the-new-azure-sdk-for-javascript. If you still need assistance, please contact Microsoft Support. #please-close


assert_shapes in code instead of just comments

Adds shape asserts to some of the modules listed in #1241:

conditionals.mo_conditionals (not 100%)
conditionals.util
kullback_leiblers
logdensities (only multivariate_normal)

I think this PR should be split into many small tasks rather than one big change. Could you make an issue and put it on GPflow feature board (it is enhancing code feature)?
Thanks

How do you think this PR should be split up? (As far as GPflow PRs go, this doesn't seem to be a particularly large one?)

I've made a new issue #1241 to handle the rest of the code base (hopefully by an army of volunteer contributors ;)) - can we review this PR and get it merged in then?

if you add some tests that will raise testing asserts with dodgy shapes that would also be good, if poss

Do you have any idea if all these checks slow down our code?

I would have thought most of the execution time in GPflow code would be in data manipulation. And I'd expect (but I don't really know) tf.Tensor to store their shapes as values on the object, and so would be really quick to access. The rest of the check logic is probably insignificant.
If however they do slow things down, it's a good reason to wrap them all along with some kind of flag to turn them on and off. The obvious flag when checking code consistency (e.g. return value shapes) would be python's in built __debug__. We could have another config flag for argument checks.


Upstream i915 GUC load failed on Ubuntu 24.04 Kernel 6.8.0-31 with Arc A770

OS Ubuntu 24.04
Kernel 6.8.0-31-generic
Error message
[   18.393201] i915 0000:0d:00.0: [drm] BAR2 resized to 16384M
[   18.393290] i915 0000:0d:00.0: [drm] Local memory IO size: 0x00000003fa000000
[   18.393296] i915 0000:0d:00.0: [drm] Local memory available: 0x00000003fa000000
[   18.409701] i915 0000:0d:00.0: vgaarb: VGA decodes changed: olddecodes=io+mem,decodes=none:owns=none
[   18.422225] i915 0000:0d:00.0: [drm] Finished loading DMC firmware i915/dg2_dmc_ver2_08.bin (v2.8)
[   18.430827] i915 0000:0d:00.0: [drm] GT0: GUC: ADS capture alloc size changed from 32768 to 36864
[   18.431927] i915 0000:0d:00.0: [drm] GT0: GuC firmware i915/dg2_guc_70.bin version 70.20.0
[   18.431930] i915 0000:0d:00.0: [drm] GT0: HuC firmware i915/dg2_huc_gsc.bin version 7.10.15
[   18.432046] i915 0000:0d:00.0: [drm] GT0: GUC: ADS capture alloc size changed from 32768 to 36864
[   18.432614] i915 0000:0d:00.0: [drm] GT0: GUC: load failed: status = 0x40000056, time = 0ms, freq = 2400MHz, ret = 0
[   18.432617] i915 0000:0d:00.0: [drm] GT0: GUC: load failed: status: Reset = 0, BootROM = 0x2B, UKernel = 0x00, MIA = 0x00, Auth = 0x01
[   18.432619] i915 0000:0d:00.0: [drm] GT0: GUC: firmware production part check failure
[   18.432684] i915 0000:0d:00.0: [drm] *ERROR* GT0: GuC initialization failed -ENOEXEC
[   18.432688] i915 0000:0d:00.0: [drm] *ERROR* GT0: Enabling uc failed (-5)
[   18.432690] i915 0000:0d:00.0: [drm] *ERROR*
GT0: Failed to initialize GPU, declaring it wedged!
[   18.434676] i915 0000:0d:00.0: [drm:add_taint_for_CI [i915]] CI tainted:0x9 by intel_gt_set_wedged_on_init+0x34/0x50 [i915]

intel-gpu/intel-gpu-i915-backports#194

Hi @huiwangnick
From https://github.com/intel-gpu/intel-gpu-i915-backports/issues/194 log, you are using out of tree driver (version <IP_ADDRESS>.2406<IP_ADDRESS>.0.40+i1-1, package name intel-dmabuf-drm-i915-dkms) rather than upstream driver.
It's different from our recommended driver version (i.e., intel-i915-dkms  in https://github.com/intel-analytics/ipex-llm/blob/main/docs/mddocs/Quickstart/install_linux_gpu.md#for-linux-kernel-65).
Can you share your driver installation steps and commands?

Hi @qiyuangong
I apologize for not being clearer earlier. In the issue discussed in intel-gpu/intel-gpu-i915-backports#194, I am using the out-of-tree driver; however, in this case, I am utilizing the upstream driver from the Linux kernel. I have also attempted your recommendation of using intel-i915-dkms, but all the drivers exhibit the same GUC load failure issue that I mentioned earlier.

Hi @qiyuangong
I apologize for not being clearer earlier. In the issue discussed in intel-gpu/intel-gpu-i915-backports#194, I am using the out-of-tree driver; however, in this case, I am utilizing the upstream driver from the Linux kernel. I have also attempted your recommendation of using intel-i915-dkms, but all the drivers exhibit the same GUC load failure issue that I mentioned earlier.

That's fine. :)
First of all, please check GPU installation (PCIe and power), the BIOS config and firmware of these GPUs. It seems they cannot be correctly initialized. We previous encountered GUC related errors when GPU is not correctly installed.
[   18.422225] i915 0000:0d:00.0: [drm] Finished loading DMC firmware i915/dg2_dmc_ver2_08.bin (v2.8)
[   18.430827] i915 0000:0d:00.0: [drm] GT0: GUC: ADS capture alloc size changed from 32768 to 36864
[   18.431927] i915 0000:0d:00.0: [drm] GT0: GuC firmware i915/dg2_guc_70.bin version 70.20.0
[   18.431930] i915 0000:0d:00.0: [drm] GT0: HuC firmware i915/dg2_huc_gsc.bin version 7.10.15
[   18.432046] i915 0000:0d:00.0: [drm] GT0: GUC: ADS capture alloc size changed from 32768 to 36864
[   18.432614] i915 0000:0d:00.0: [drm] GT0: GUC: load failed: status = 0x40000056, time = 0ms, freq = 2400MHz, ret = 0
[   18.432617] i915 0000:0d:00.0: [drm] GT0: GUC: load failed: status: Reset = 0, BootROM = 0x2B, UKernel = 0x00, MIA = 0x00, Auth = 0x01
[   18.432619] i915 0000:0d:00.0: [drm] GT0: GUC: firmware production part check failure
[   18.432684] i915 0000:0d:00.0: [drm] *ERROR* GT0: GuC initialization failed -ENOEXEC
[   18.432688] i915 0000:0d:00.0: [drm] *ERROR* GT0: Enabling uc failed (-5)
[   18.432690] i915 0000:0d:00.0: [drm] *ERROR* GT0: Failed to initialize GPU, declaring it wedged!

Then , 6.8.0 kernel (with its upstream driver version) is not recommended by ipex-llm. It requires higher level-zero and oneAPI versions. Using 6.8 will encounter level zero mismatch with our recommended package. Please change to the recommended kernel version, i.e., 6.5.0.

Thank you. I will try 6.5.0 kernel to see if I can get it to work.
In the meantime, I’d like to add that when the BAR is not resized to 16,384 MB and remains at 256 MB, the driver loads successfully. This suggests that the issue is not related to GPU installation or GPU firmware. It seems possible that the Resizable BAR feature could be causing this problem.
[   18.110784] i915 0000:0d:00.0: [drm] Failed to resize BAR2 to 16384M (-ENOSPC)
[   18.110792] i915 0000:0d:00.0: BAR 2 [mem 0x13ffe0000000-0x13ffefffffff 64bit pref]: assigned
[   18.110938] i915 0000:0d:00.0: [drm] Local memory IO size: 0x0000000010000000
[   18.110943] i915 0000:0d:00.0: [drm] Local memory available: 0x00000003fa000000
[   18.110946] i915 0000:0d:00.0: [drm] Using a reduced BAR size of 256MiB. Consider enabling 'Resizable BAR' or similar, if available in the BIOS.
[   18.132145] i915 0000:0d:00.0: [drm] Finished loading DMC firmware i915/dg2_dmc_ver2_08.bin (v2.8)
[   18.141268] i915 0000:0d:00.0: [drm] GT0: GuC firmware i915/dg2_guc_70.bin version 70.20.0
[   18.141273] i915 0000:0d:00.0: [drm] GT0: HuC firmware i915/dg2_huc_gsc.bin version 7.10.3
[   18.149102] i915 0000:0d:00.0: [drm] GT0: GUC: submission enabled
[   18.149104] i915 0000:0d:00.0: [drm] GT0: GUC: SLPC enabled
[   18.149347] i915 0000:0d:00.0: [drm] GT0: GUC: RC enabled
[   18.177938] [drm] Initialized i915 1.6.0 20230929 for 0000:0d:00.0 on minor 1

Thank you. I will try 6.5.0 kernel to see if I can get it to work.
In the meantime, I’d like to add that when the BAR is not resized to 16,384 MB and remains at 256 MB, the driver loads successfully. This suggests that the issue is not related to GPU installation or GPU firmware. It seems possible that the Resizable BAR feature could be causing this problem.
[   18.110784] i915 0000:0d:00.0: [drm] Failed to resize BAR2 to 16384M (-ENOSPC)
[   18.110792] i915 0000:0d:00.0: BAR 2 [mem 0x13ffe0000000-0x13ffefffffff 64bit pref]: assigned
[   18.110938] i915 0000:0d:00.0: [drm] Local memory IO size: 0x0000000010000000
[   18.110943] i915 0000:0d:00.0: [drm] Local memory available: 0x00000003fa000000
[   18.110946] i915 0000:0d:00.0: [drm] Using a reduced BAR size of 256MiB. Consider enabling 'Resizable BAR' or similar, if available in the BIOS.
[   18.132145] i915 0000:0d:00.0: [drm] Finished loading DMC firmware i915/dg2_dmc_ver2_08.bin (v2.8)
[   18.141268] i915 0000:0d:00.0: [drm] GT0: GuC firmware i915/dg2_guc_70.bin version 70.20.0
[   18.141273] i915 0000:0d:00.0: [drm] GT0: HuC firmware i915/dg2_huc_gsc.bin version 7.10.3
[   18.149102] i915 0000:0d:00.0: [drm] GT0: GUC: submission enabled
[   18.149104] i915 0000:0d:00.0: [drm] GT0: GUC: SLPC enabled
[   18.149347] i915 0000:0d:00.0: [drm] GT0: GUC: RC enabled
[   18.177938] [drm] Initialized i915 1.6.0 20230929 for 0000:0d:00.0 on minor 1

OK. If it's Resizable BAR (Base Address Register) related issue. Please check the BIOS config.
https://www.intel.com/content/www/us/en/support/articles/000090831/graphics.html


Template Editor

This issue is a collection of improvements for the Template editor introduced with #6541:
### Ideas
- [ ] add plugin interface to let plugins provide different editors/previews (to let plugins provide e.g. drag and drop editors)
- [ ] easily upload report assest via drag and drop in code editor
- [ ] add ability to edit report snippets (maybe also the ability to switch between them using tabs)
- [ ] add custom template filters api form field component to visually edit template filters
- [ ] codemirror infer available django context variables
- [x] add vertical resize drag handler
- [ ] add printcss preview type (https://printcss.live/)
- [ ] define a custom language for django templates to be more accurate (example: https://github.com/codemirror/lang-liquid)
- [ ] ??? maybe switch to monaco ???
- [ ] allow previewing without saving the template (ref: https://github.com/inventree/InvenTree/issues/5841#issuecomment-1963014776)
- [ ] show warning if there are unsaved changes before closing the drawer

@wolflu05 with the changed UI customisation options of PUI - has any of the items above changed?


[in_app_purchase] It's possible to miss payment queue events on iOS

Hi,
First I'd like to express my gratitude for all you flutter devs for creating such an amazing product! Writing apps with flutter is so much easier and more fun than writing native apps, not to mention faster ❤
I'm having this problem with the in_app_purchase plugin on iOS that  sometimes the purchase events are not resubmitted to the purchaseStream upon app restart after an initial failure. By initial failure I mean that the purchase was not completed by calling completePurchase when the purchase was submitted to the purchaseStream. A realistic example of this is a bad network connection causing the receipt verification call to the server to fail.
This document states that the non-finished transactions are sent to the SKPaymentTransactionObserver as soon as an observer is registered.
The in_app_purchase plugin registers that observer here before the dart code is running and could have registered a listener to the purchaseStream. So there is a random amount of time between registering the SKPaymentTransactionObserver and the time a listener could be added for purchaseStream. Isn't it possible that the transaction events are lost during that time? Or is there some kind of cache somewhere I'm not aware of?
A solution to this would be to register SKPaymentTransactionObserver after a listener has been added for purchaseStream as the the apple document clearly states that no events are produced before an observer is installed.
Unfortunately I can't write a reproduction as this only happens very rarely when the SKPaymentTransactionObserver gets notified before a listener is installed. Here are the theoretical reproduction steps though:

Make a purchase
Don't call completePurchase for the purchase when it's submitted to purchaseStream.
Restart the app
If the planets are aligned, the purchase is not resubmitted to the app because no listener was installed for purchaseStream when SKPaymentTransactionObserver received the event.

Note that I do install the purchaseStream listener as soon as possible in the main function.
Thank you!

Hi @koskimas

Don't call completePurchase for the purchase when it's submitted to purchaseStream.

Can you please provide your flutter doctor -v, a complete reproducible minimal code sample
Thank you

Closed this because I can't reproduce the bug (as mentioned in the original message). The bug is there, it's easy to see just by looking at the place in code I linked, but I understand that you don't believe me without proof. Hope this gets fixed one day.

Hi @koskimas
Reproducible cases are always better but I also appreciate your details. If there is a chance we could miss payment queue events, we would definitely take it seriously
I lack knowledge here, somebody from plugins can help with additional triage
cc @mvanbeusekom

@koskimas I made a draft PR (flutter/plugins#4035) which should fix this issue. I still have to test this by writing unit tests and actually testing it on a device. It would be great if you are willing to verify that this fixes the issue, but I can imagine that it's hard when it only happens some times.

I tested the new implementation on a real device with adding and removing listeners to the purchase stream and everything works fine for me.

@renefloor Thank you so much for working on this so quicky, I really appreciate it! The implementation seems foolproof to me and I'm not able to reproduce the bug now, though it could just be bad luck in theory as it was nearly impossible to reproduce in the first place 😄


BUG:Misaligned Icons in Travel Discussion Forum

Is there an existing issue for this?

[X] I have searched the existing issues

What happened?
Issue: Misaligned Icons in Travel Discussion Forum
Description:
In the Travel Discussion Forum, the icons for interactions such as replying, liking, sharing, and other actions are not well structured. This misalignment makes the layout appear inconsistent and unorganized, which negatively impacts the overall user experience. Properly aligning these icons is necessary to enhance visual clarity and usability.

Steps to Reproduce:

Navigate to the Travel Discussion Forum.
View the interaction icons (e.g., reply, like, share, etc.) in the posts or comments.
Observe that the icons are misaligned, which disrupts the clean layout of the forum.

Expected Behavior:
The interaction icons should be evenly spaced and aligned properly with the content, ensuring a visually consistent and professional-looking interface.

Actual Behavior:
Currently, the icons are not aligned properly, resulting in a cluttered and uneven layout that diminishes the user experience.

Priority: Medium
Impact: This affects user navigation and interaction within the Travel Discussion Forum, potentially causing confusion or frustration.

Screenshots/Visuals:

Record

[X] I agree to follow this project's Code of Conduct
[X] I'm a GSSOC'24 contributor
[X] I want to work on this issue

hey @PriyaGhosal  please merge this PR

@PriyaGhosal  i have resolved the conflicts you can merge now


fix(react-server): tree shake unused references by __NO_SIDE_EFFECTS__

#336  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @hi-ogawa and the rest of your teammates on  Graphite


feat(deps): upgrade runtime dependencies

Upgrades project dependencies. See details in workflow run.

Automatically created by projen via the "upgrade-runtime-dependencies-1.x" workflow

⚪ Backport skipped
The pull request was not backported as there were no branches to backport to. If this is a mistake, please apply the desired version labels or run the backport tool manually.
Manual backport
To create the backport manually run:
backport --pr 1588

Questions ?
Please refer to the Backport tool documentation


Wording of person form error validation messages should be consistent

Description
The error messages displayed in the person form upon validation failures are not consistent. In particular, when a required non-text input field has not been populated by a user, the message that appears variously states the property "is missing" or "is required".
See: English language configuration file for the SimpleReport frontend
Acceptance criteria

Standardize on phrasing for missing and/or invalid required fields

Translations

[x] Translations are required

Our translation needs will likely be close to nil, but whoever picks up this ticket should make sure to loop in @Rebecca-LM for approval before merging

[ ] Translation request has been submitted
[ ] Translations have been received

We would like to change the label and validation error message for the ethnicity field as well. It should read as follows:
Question: “Are you Hispanic or Latino/a?”
Error: “Hispanic or Latino/a ethnicity is required” Please correct before submitting
(see: https://skylight-hq.slack.com/archives/C01SY3DRMNY/p1643742610961149)


Automatic translation errors in the Japanese version

[Enter feedback here]
The Japanese version of this page has multiple errors that make the document difficult to comprehend: some language is unnatural (e.g. translating No as いいえ、そうではありません。), and multiple words are just not translated ( see screenshot)

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: c9b9efc6-78cd-1f1e-bcd5-3e02130b7bd9
Version Independent ID: 9ce2e642-96f3-ec9c-e8bd-1e5c8846d1e1
Content: HoloLens 2 cleaning FAQ
Content Source: hololens/hololens2-maintenance.md
Product: hololens
Technology: windows
GitHub Login: @Teresa-Motiv
Microsoft Alias: v-tea

I'm no longer working on the HoloLens docs, but I've filed a bug for this issue so that it can get triaged to the correct group.

I'm no longer working on the HoloLens docs, but I've filed a bug for this issue so that it can get triaged to the correct group.

Created ADO Task 34251120: [HoloLens Docs] Incorrect Japanese localization in HoloLens Cleaning page to address the issue.


Update file structure

Make the game backbone file structure more similar to VS structure.

This has been finished. There are now folders. stdafx has been removed from all but the unit test project. leave that project that way until further notice.


nebula: 1.8.1 -> 1.8.2

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://repology.org/project/nebula-overlay-networking/versions.
meta.description for nebula is: Overlay networking tool with a focus on performance, simplicity and security
meta.homepage for nebula is: https://github.com/slackhq/nebula
meta.changelog for nebula is: https://github.com/slackhq/nebula/blob/v1.8.2/CHANGELOG.md
Updates performed

Golang update

To inspect upstream changes
Impact
Checks done

built on NixOS
The tests defined in passthru.tests, if any, passed
found 1.8.2 with grep in /nix/store/gsx0syfjkv47b11dp8ikrnwjz6xv16b4-nebula-1.8.2
found 1.8.2 in filename of file in /nix/store/gsx0syfjkv47b11dp8ikrnwjz6xv16b4-nebula-1.8.2

Rebuild report (if merged into master) (click to expand)

1 total rebuild path(s)

1 package rebuild(s)

First fifty rebuilds by attrpath
nebula

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/gsx0syfjkv47b11dp8ikrnwjz6xv16b4-nebula-1.8.2 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A nebula https://github.com/r-ryantm/nixpkgs/archive/7ea4f98f7ff1b8570557b5c07435201985d6e108.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/7ea4f98f7ff1b8570557b5c07435201985d6e108#nebula

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/gsx0syfjkv47b11dp8ikrnwjz6xv16b4-nebula-1.8.2
ls -la /nix/store/gsx0syfjkv47b11dp8ikrnwjz6xv16b4-nebula-1.8.2/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package built:

nebula

Maintainer pings
cc @Br1ght0ne @numinit for testing.

@ofborg eval

LGTM, added tag for backport.

@GrahamcOfBorg eval


chore: updates

Codecov Report

Merging #138 (dc69a7f) into master (f411965) will not change coverage.
The diff coverage is n/a.

:exclamation: Current head dc69a7f differs from pull request most recent head 6918ad9. Consider uploading reports for the commit 6918ad9 to get more accurate results

@@           Coverage Diff           @@
##           master     #138   +/-   ##
=======================================
  Coverage   78.71%   78.71%
=======================================
  Files         123      123
  Lines       11394    11394
  Branches     1209     1209
=======================================
  Hits         8969     8969
  Misses       2425     2425

Flag
Coverage Δ

unittests
78.71% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f411965...6918ad9. Read the comment docs.


description label changes on open/close

when a transaction is being updated, the label changes.

it's "August 2022 pay..." when the sum up of the transaction is shown (we should not cut the label btw)

It's "Galoy inc payment" when the transaction is opened

also the fact we are changing the date format is somewhat unexpected

i'm working on this now. I guess we should show the full description on larger screens but truncate it on smaller screens and would you like the format to be paymentDescription (settlementtype) e.g. August 2022 Payment (Galoy payment)?

milli can probably provide input on the best format. not sure what her github handle is.

This is actually similar to the behaviour of the mobile app.  We show friendly dates on the transaction list but if you tap on one transaction to get more details we show the full date.  I think the difference is that in the mobile app it navigates you to a new screen whereas in the web wallet we are expanding the view.


Hyak Latest Version (1.1.3) restricts to Newtonsoft.Json < 10.0.0 (REOPEN Issue #3002 )

#3002
was marked closed, but this issue has not been fixed!
The Hyak dependency still depends on a Max Newtonsoft.Json library version of 9.x. Newtonsoft is now up to 10.
The difference between Newtonsoft 9.x and 10.x is the removal of a section of the Newtonsoft Library that was marked as Deprecated 2 YEARS AGO.
Either make the Hyak Common Library work with the current version of Newtonsoft supported features, or remove the dependency on Hyak Common Library from the Microsoft.Azure.Common dependency.

@markcowl the problem is that the entire library of Microsoft.Azure.Common depends on Hyak. what library should I use in place of all the areas where Microsoft.Azure.Common is required.
I don't mean to be snarky (or at least not much..) but isn't something called "Azure.Common" kinda, well Commonly used?  If it has a dependency on a Library that will not be maintained shouldn't a new version of something called "common" be updated to no longer require that deprecated library (like Hyak)?

Microsoft.Azure.Common is the name of the old common library.  The new one, on which almost all ARM clients is based is Microsoft.Rest.ClientRuntime.
Which package are you using that requires this, and why were you unable to move to a later version that depends on Microsoft.Rest.ClientRuntime?

We are using it for two purposes,
one is for checking the infrastructure of the Cloud Service we are running on
And the second is for reading from the Role Environment RoleEnvironment.GetConfigurationSettingValue( "overrideSlot" )

[ ] Update .NetCore version of Hyak.Core to remove upper limit on Newtonsoft.Json
[ ] Verify no test issues with remaining 5 packages

Cost: 2

At this point I understand there are no plans to update Hyak, the recommendation is to move forward to new versions of these libraries. Moving forward, the Azure SDK is planning to remove references to JSON.NET to avoid pinning dependencies like this. It will take time to get through all the different places where this dependency exists but over time, the pain should go away. We want people to be able to use whatever JSON.NET version they want without the Azure SDK causing problems.
You can get a glimpse of the first wave of libraries doing this here: https://azure.microsoft.com/en-in/blog/previewing-azure-sdks-following-new-azure-sdk-api-standards/


Datastore namespace fix

When using allocateId the namespace option was ignored due to a typo

Thank you! Could you also fix the tests? https://travis-ci.org/GoogleCloudPlatform/gcloud-node/jobs/121357907#L3059

:+1:

Thanks!


HDFS-17339:Skip cacheReport when one blockPool does not have CacheBlock on this DataNode

Now, DataNode will cacheReport to all NameNode when CacheCapacitySize is not zero. But sometimes, not all NameNodes have CacheBlock on this DataNode. So BPServiceActor should skip cacheReport when one blockPool does not have CacheBlock on this DataNode. If so, the NameNode will reduce unnecessary lock contention

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 34s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s

The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
41m 28s

trunk passed

+1 :green_heart:
compile
1m 18s

trunk passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
compile
1m 11s

trunk passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08

+1 :green_heart:
checkstyle
1m  8s

trunk passed

+1 :green_heart:
mvnsite
1m 21s

trunk passed

+1 :green_heart:
javadoc
1m  6s

trunk passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
1m 34s

trunk passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08

+1 :green_heart:
spotbugs
3m 18s

trunk passed

+1 :green_heart:
shadedclient
34m 23s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m 11s

the patch passed

+1 :green_heart:
compile
1m 11s

the patch passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javac
1m 11s

the patch passed

+1 :green_heart:
compile
1m  4s

the patch passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08

+1 :green_heart:
javac
1m  4s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
0m 57s

the patch passed

+1 :green_heart:
mvnsite
1m 12s

the patch passed

+1 :green_heart:
javadoc
0m 52s

the patch passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
1m 27s

the patch passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08

+1 :green_heart:
spotbugs
3m 12s

the patch passed

+1 :green_heart:
shadedclient
34m 38s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
224m 56s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
0m 42s

The patch does not generate ASF License warnings.

358m 56s

Reason
Tests

Failed junit tests
hadoop.hdfs.server.datanode.TestDirectoryScanner

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6456/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/6456

JIRA Issue
HDFS-17339

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux d66402a1d269 5.15.0-91-generic #101-Ubuntu SMP Tue Nov 14 13:30:08 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / cf86aebca44e5e2a0f64551f92e7560b9fb382c7

Default Java
Private Build-1.8.0_392-8u392-ga-1~20.04-b08

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_392-8u392-ga-1~20.04-b08

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6456/1/testReport/

Max. process+thread count
4408 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6456/1/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

@ThinkerLei Please check if the failed tests are related to the changes.

@ThinkerLei Please check if the failed tests are related to the changes.

@zhangshuyan0 Thanks for your comment.  The failed tests are  not related to my changes. I successfully ran the failed tests on my computer. Any changes about CI recently?

I don't know what changes have happened to CI recently. This patch looks great to me and can alleviate the pressure on NN. Let's wait and see if others have any opinions.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 34s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s

The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
43m  9s

trunk passed

+1 :green_heart:
compile
1m 19s

trunk passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
compile
1m 10s

trunk passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08

+1 :green_heart:
checkstyle
1m  9s

trunk passed

+1 :green_heart:
mvnsite
1m 22s

trunk passed

+1 :green_heart:
javadoc
1m  5s

trunk passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
1m 39s

trunk passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08

+1 :green_heart:
spotbugs
3m 14s

trunk passed

+1 :green_heart:
shadedclient
34m 23s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m  9s

the patch passed

+1 :green_heart:
compile
1m 11s

the patch passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javac
1m 11s

the patch passed

+1 :green_heart:
compile
1m  4s

the patch passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08

+1 :green_heart:
javac
1m  4s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
0m 55s

the patch passed

+1 :green_heart:
mvnsite
1m 11s

the patch passed

+1 :green_heart:
javadoc
0m 52s

the patch passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
1m 30s

the patch passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08

+1 :green_heart:
spotbugs
3m 18s

the patch passed

+1 :green_heart:
shadedclient
34m 32s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
225m 18s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
0m 41s

The patch does not generate ASF License warnings.

360m 57s

Reason
Tests

Failed junit tests
hadoop.hdfs.server.datanode.TestDirectoryScanner

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6456/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/6456

JIRA Issue
HDFS-17339

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux efee4dd1d356 5.15.0-91-generic #101-Ubuntu SMP Tue Nov 14 13:30:08 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 243af8bea73098685bbca84a7c22e9e98fedcd57

Default Java
Private Build-1.8.0_392-8u392-ga-1~20.04-b08

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_392-8u392-ga-1~20.04-b08

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6456/2/testReport/

Max. process+thread count
4168 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6456/2/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 35s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s

The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
41m 27s

trunk passed

+1 :green_heart:
compile
1m 22s

trunk passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
compile
1m 11s

trunk passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08

+1 :green_heart:
checkstyle
1m  7s

trunk passed

+1 :green_heart:
mvnsite
1m 21s

trunk passed

+1 :green_heart:
javadoc
1m  4s

trunk passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
1m 38s

trunk passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08

+1 :green_heart:
spotbugs
3m 15s

trunk passed

+1 :green_heart:
shadedclient
34m 35s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m 10s

the patch passed

+1 :green_heart:
compile
1m 11s

the patch passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javac
1m 11s

the patch passed

+1 :green_heart:
compile
1m  6s

the patch passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08

+1 :green_heart:
javac
1m  6s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
0m 55s

the patch passed

+1 :green_heart:
mvnsite
1m 13s

the patch passed

+1 :green_heart:
javadoc
0m 52s

the patch passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
1m 28s

the patch passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08

+1 :green_heart:
spotbugs
3m 12s

the patch passed

+1 :green_heart:
shadedclient
34m 32s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
226m  0s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
0m 42s

The patch does not generate ASF License warnings.

360m 20s

Reason
Tests

Failed junit tests
hadoop.hdfs.server.datanode.TestDirectoryScanner

Subsystem
Report/Notes

Docker
ClientAPI=1.44 ServerAPI=1.44 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6456/3/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/6456

JIRA Issue
HDFS-17339

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux 266aec254a03 5.15.0-91-generic #101-Ubuntu SMP Tue Nov 14 13:30:08 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / df3e56a5916c02e08b170596de411f4dd33a5cf2

Default Java
Private Build-1.8.0_392-8u392-ga-1~20.04-b08

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_392-8u392-ga-1~20.04-b08

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6456/3/testReport/

Max. process+thread count
3841 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6456/3/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 33s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+0 :ok:
detsecrets
0m  1s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

-1 :x:
test4tests
0m  1s

The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
42m 12s

trunk passed

+1 :green_heart:
compile
1m 18s

trunk passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
compile
1m 14s

trunk passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08

+1 :green_heart:
checkstyle
1m  8s

trunk passed

+1 :green_heart:
mvnsite
1m 21s

trunk passed

+1 :green_heart:
javadoc
1m  5s

trunk passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
1m 32s

trunk passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08

+1 :green_heart:
spotbugs
3m 15s

trunk passed

+1 :green_heart:
shadedclient
34m 39s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m  9s

the patch passed

+1 :green_heart:
compile
1m 11s

the patch passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javac
1m 11s

the patch passed

+1 :green_heart:
compile
1m  4s

the patch passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08

+1 :green_heart:
javac
1m  4s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
0m 55s

the patch passed

+1 :green_heart:
mvnsite
1m  9s

the patch passed

+1 :green_heart:
javadoc
0m 50s

the patch passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
1m 30s

the patch passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08

+1 :green_heart:
spotbugs
3m 14s

the patch passed

+1 :green_heart:
shadedclient
34m 19s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
221m 46s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
0m 41s

The patch does not generate ASF License warnings.

356m 32s

Reason
Tests

Failed junit tests
hadoop.hdfs.server.datanode.TestDirectoryScanner

Subsystem
Report/Notes

Docker
ClientAPI=1.44 ServerAPI=1.44 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6456/4/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/6456

JIRA Issue
HDFS-17339

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux 7e1249026dbe 5.15.0-91-generic #101-Ubuntu SMP Tue Nov 14 13:30:08 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / d24a148a2660ba0e523100146e650e413c08f61e

Default Java
Private Build-1.8.0_392-8u392-ga-1~20.04-b08

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_392-8u392-ga-1~20.04-b08

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6456/4/testReport/

Max. process+thread count
3794 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6456/4/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 36s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s

The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
42m 49s

trunk passed

+1 :green_heart:
compile
1m 20s

trunk passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
compile
1m 10s

trunk passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08

+1 :green_heart:
checkstyle
1m 10s

trunk passed

+1 :green_heart:
mvnsite
1m 22s

trunk passed

+1 :green_heart:
javadoc
1m  8s

trunk passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
1m 35s

trunk passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08

+1 :green_heart:
spotbugs
3m 18s

trunk passed

+1 :green_heart:
shadedclient
34m 30s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m  8s

the patch passed

+1 :green_heart:
compile
1m 12s

the patch passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javac
1m 12s

the patch passed

+1 :green_heart:
compile
1m  5s

the patch passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08

+1 :green_heart:
javac
1m  5s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
0m 56s

the patch passed

+1 :green_heart:
mvnsite
1m 12s

the patch passed

+1 :green_heart:
javadoc
0m 51s

the patch passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
1m 29s

the patch passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08

+1 :green_heart:
spotbugs
3m 15s

the patch passed

+1 :green_heart:
shadedclient
34m 32s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
223m 50s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
0m 40s

The patch does not generate ASF License warnings.

359m 29s

Reason
Tests

Failed junit tests
hadoop.hdfs.server.datanode.TestDirectoryScanner

Subsystem
Report/Notes

Docker
ClientAPI=1.44 ServerAPI=1.44 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6456/5/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/6456

JIRA Issue
HDFS-17339

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux 6f51d45a66fc 5.15.0-91-generic #101-Ubuntu SMP Tue Nov 14 13:30:08 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / aaefaae238c86cdf1827994c2767256236baa3f7

Default Java
Private Build-1.8.0_392-8u392-ga-1~20.04-b08

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_392-8u392-ga-1~20.04-b08

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6456/5/testReport/

Max. process+thread count
3866 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6456/5/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 35s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+0 :ok:
detsecrets
0m  1s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s

The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
45m 36s

trunk passed

+1 :green_heart:
compile
1m 28s

trunk passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
compile
1m 18s

trunk passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08

+1 :green_heart:
checkstyle
1m 16s

trunk passed

+1 :green_heart:
mvnsite
1m 31s

trunk passed

+1 :green_heart:
javadoc
1m 14s

trunk passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
1m 45s

trunk passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08

+1 :green_heart:
spotbugs
4m  4s

trunk passed

-1 :x:
shadedclient
44m 11s

branch has errors when building and testing our client artifacts.

_ Patch Compile Tests _

-1 :x:
mvninstall
0m 22s
/patch-mvninstall-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch failed.

-1 :x:
compile
0m 22s
/patch-compile-hadoop-hdfs-project_hadoop-hdfs-jdkUbuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04.txt
hadoop-hdfs in the patch failed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04.

-1 :x:
javac
0m 22s
/patch-compile-hadoop-hdfs-project_hadoop-hdfs-jdkUbuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04.txt
hadoop-hdfs in the patch failed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04.

-1 :x:
compile
0m 23s
/patch-compile-hadoop-hdfs-project_hadoop-hdfs-jdkPrivateBuild-1.8.0_392-8u392-ga-1~20.04-b08.txt
hadoop-hdfs in the patch failed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08.

-1 :x:
javac
0m 23s
/patch-compile-hadoop-hdfs-project_hadoop-hdfs-jdkPrivateBuild-1.8.0_392-8u392-ga-1~20.04-b08.txt
hadoop-hdfs in the patch failed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08.

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
0m 21s
/buildtool-patch-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt
The patch fails to run checkstyle in hadoop-hdfs

-1 :x:
mvnsite
0m 22s
/patch-mvnsite-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch failed.

-1 :x:
javadoc
0m 22s
/patch-javadoc-hadoop-hdfs-project_hadoop-hdfs-jdkUbuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04.txt
hadoop-hdfs in the patch failed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04.

-1 :x:
javadoc
0m 22s
/patch-javadoc-hadoop-hdfs-project_hadoop-hdfs-jdkPrivateBuild-1.8.0_392-8u392-ga-1~20.04-b08.txt
hadoop-hdfs in the patch failed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08.

-1 :x:
spotbugs
0m 22s
/patch-spotbugs-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch failed.

+1 :green_heart:
shadedclient
5m 15s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
0m 22s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch failed.

+0 :ok:
asflicense
0m 23s

ASF License check generated no output?

110m  5s

Subsystem
Report/Notes

Docker
ClientAPI=1.44 ServerAPI=1.44 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6456/7/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/6456

JIRA Issue
HDFS-17339

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux 48fad95d1a96 5.15.0-91-generic #101-Ubuntu SMP Tue Nov 14 13:30:08 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 878d65bc657a99fc20c4071cd45ee92cefd54b7a

Default Java
Private Build-1.8.0_392-8u392-ga-1~20.04-b08

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_392-8u392-ga-1~20.04-b08

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6456/7/testReport/

Max. process+thread count
700 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6456/7/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 36s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s

The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
43m  8s

trunk passed

+1 :green_heart:
compile
1m 19s

trunk passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
compile
1m 16s

trunk passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08

+1 :green_heart:
checkstyle
1m  9s

trunk passed

+1 :green_heart:
mvnsite
1m 20s

trunk passed

+1 :green_heart:
javadoc
1m  5s

trunk passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
1m 39s

trunk passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08

+1 :green_heart:
spotbugs
3m 13s

trunk passed

+1 :green_heart:
shadedclient
36m 31s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m 11s

the patch passed

+1 :green_heart:
compile
1m  9s

the patch passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javac
1m  9s

the patch passed

+1 :green_heart:
compile
1m  7s

the patch passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08

+1 :green_heart:
javac
1m  7s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
0m 56s

the patch passed

+1 :green_heart:
mvnsite
1m  9s

the patch passed

+1 :green_heart:
javadoc
0m 51s

the patch passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
1m 34s

the patch passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08

+1 :green_heart:
spotbugs
3m 13s

the patch passed

+1 :green_heart:
shadedclient
34m 22s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
224m  2s

hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
0m 42s

The patch does not generate ASF License warnings.

361m 58s

Subsystem
Report/Notes

Docker
ClientAPI=1.44 ServerAPI=1.44 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6456/8/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/6456

JIRA Issue
HDFS-17339

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux 2f855617c0f0 5.15.0-91-generic #101-Ubuntu SMP Tue Nov 14 13:30:08 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / e6c5711eac75ae90128c57ae55293930053585a5

Default Java
Private Build-1.8.0_392-8u392-ga-1~20.04-b08

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_392-8u392-ga-1~20.04-b08

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6456/8/testReport/

Max. process+thread count
4493 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6456/8/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.


add tooling dependencies

This demonstrates how to lock down to specific versions of the tooling dependencies, rather than potentially getting a different version of tooling dependencies each time.
It also allows the dependencies to be run with go run -mod=vendor in the future, meaning greater consistency between platforms, faster deploys via docker, drone, etc.
We may not want all of the tooling locked down like this, but I think it would be particularly helpful for go-bindata (anything that's part of go:generate, for sure).

This is the particularly important part:
https://github.com/go-gitea/gitea/pull/6565/files#diff-f0e0c1740f44d2288ec4c6976535d50e

You probably need to run make vendor and commit the result to get the ci to run.

I just want to open this for discussion as to whether or not it's desirable.
The advantages that come from it (aside from locking down the version) can't be fully realized until the minimum Go version is 1.11.
As long as it's Go 1.10, we can't even get the speed-up from having it all pre-downloaded.

Codecov Report

Merging #6565 into master will decrease coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #6565      +/-   ##
==========================================
- Coverage   40.35%   40.35%   -0.01%
==========================================
  Files         405      405
  Lines       54260    54260
==========================================
- Hits        21899    21898       -1
- Misses      29346    29347       +1
  Partials     3015     3015

Impacted Files
Coverage Δ

modules/log/event.go
64.46% <0%> (-1.53%)
:arrow_down:

models/repo_list.go
67.89% <0%> (+1.05%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2664adf...3e6841e. Read the comment docs.

Thoughts?

I'm for locking also tool versions and vendoring them

I'm for locking also tool versions and vendoring them

Both this and the remove sed PR will be easiest to accomplish once the decision is made that explicit support for go1.10 and below is not necessary.
I realize some of the lint-style tooling still requires earlier versions, but that's not necessary for building and contributing in general.

The change is too big that made it difficult to review.

@lunny I think you misunderstood what the change is.
There was only one change, which was to add tooling dependencies:

https://github.com/go-gitea/gitea/pull/6565/files#diff-37aff102a57d3d7b797f152915a6dc16

Everything else is locking down dependencies in vendor/
However, this is way out of date. It looks like someone has since added files to vendor.

@lunny:
Rebased

1 file change: add tooling dependencies - e5daaa9
Dependencies Updated: go mod tidy; go mod vendor c2f5004
Missing Dependencies Resolved: update vendor/ ed53c16

We have used vsfgen instead go-bindata. And could you also change Makefile to use -mod=vendor ?

I think we decided that we can't change the Makefile until after the 1.9 release due to some issues with previous versions of Go that are till supported.
Once we drop support for GOPATH and use Go modules exclusively I'll circle back around to this and the PR for removing sed.

Since v1.9 branch is created, could you resolve the conflicted files?

https://github.com/Masterminds/glide was recommended to me for dependencie management ...

@6543

https://www.youtube.com/watch?v=F8nrpe0XWRg
https://github.com/golang/go/wiki/Modules
https://blog.golang.org/using-go-modules

Go now has the best module system on the planet, nay, the universe.

ok you got me

the best module system on the planet, nay, the universe.

Ever used composer?


Add Wallet API Interactive Demos

Adds embedded interactive demos inline for each method
Adds documentation for the getWalletProviderStatus method
Small fix on createToken example

These changes will need to be merged in after the updates to the site:
https://github.com/bitcoin-portal/bitcoincom-developer/pull/50
These documents were originally merged into master. This PR merges master back into stage, and adds the updates listed above.

These changes are fine to add so long as the proper branch merge order has been sorted out.


Created Frederic (code) for Frederic Lestage (new administration).

Authored by<EMAIL_ADDRESS>
Frederic: Best developper
New aboriginal administration Frederic Lestage
--
Automated submit by PRB0t

Test


Submit PR to pre-commit hooks list

Given that this repo better supports bazel buildifier than the alternative hook listed at https://pre-commit.com/hooks.html, it would be good to add this repo to that list. That way people like me can more easily find this hook.

Thank you for the bug report, and I'm sorry I didn't see it.
Fixed in 9324084e078b125400b1d369f3a7b9c8940f5615.


[Bug] [Super URL Bar] Bookmarks Star is layered over other icons

Affected Theme

Super URL Bar
Version 1.3.0

Affected Theme Settings
Zen Version: 1.0.1-a.7
System OS: MacOS 12.1
Describe the bug
The Bookmarks Star fades in on top of other icons, like the Reader Mode icon. This makes it impossible to click the icon underneath (I love the new way the icons fade in, though. Thank you for implementing!)
To Reproduce
Steps to reproduce the behavior:

In Super URL Bar settings, click "Hide the Bookmarks (Star) icon"
Navigate to a website
Hover mouse over the right end of the URL bar
See error

Expected behavior
Clicking "Hide the Bookmarks (Star) icon should keep the star from appearing at all.
Screenshots/Videos
Here you can see the star layered over Container Tabs, RSS Feed, and Reader Mode, depending on the site.

Wow, that's hella weird. Does this also happen on a new profile?, so that it's sure that it isn't due to conflicting css. You're using the hover option (at the bottom) in mod settings, right? The problem is that i can't seem to reproduce it ....
Is there anything else noteworthy that could help me reproduce that?

Since there is no answer, i'll close this now. I suspect that there was other custom css, since this shouldn't be the case with the mod alone and i couldn't reproduce it


⚠ BCR Bot has degraded performance

In 4d92386, BCR Bot (https://bcr.alternativasinteligentes.com/BCRApi/web/chatbot) experienced degraded performance:

HTTP code: 200
Response time: 1218 ms

Resolved: BCR Bot performance has improved in d8ede0e.


utf8 encoder speedup for large amounts of data processing

Same as PR #10 but with fixed coverage, code style and versions.

Coverage increased (+0.32%) to 92.91% when pulling 4e1e9a66115d622de98c671324d2a89c35aea7b4 on antelle:master into 792fdab75cb771514de0f9c902b9352b718a3a8b on mathiasbynens:master.

Coverage increased (+0.54%) to 93.13% when pulling 0ff4e30d00092fbae1df8b611aae55793a2ce55a on antelle:master into 792fdab75cb771514de0f9c902b9352b718a3a8b on mathiasbynens:master.

I have removed unrelated formatting modifications and fixed coverage, are you ok with other changes?

@mathiasbynens Any updates on this?..


Documentation missing for SPFx v1.14 ListViewAccessorStateChanges

What type of issue is this?
Documentation issue / typo
What SharePoint development model, framework, SDK or API is this about?
💥 SharePoint Framework
Target SharePoint environment
SharePoint Online
What browser(s) / client(s) have you tested

[ ] 💥 Internet Explorer
[ ] 💥 Microsoft Edge
[ ] 💥 Google Chrome
[ ] 💥 FireFox
[ ] 💥 Safari
[ ] mobile (iOS/iPadOS)
[ ] mobile (Android)
[X] not applicable
[ ] other (enter in the "Additional environment details" area below)

Additional environment details

SPFx version 1.14

Issue description
In this link, it says (see ListViewAccessorStateChanges). But, could not find the documentation related to ListViewAccessorStateChanges anywhere.

@NewGHUser4321 - thanks for reporting this one.
It has been fixed: https://docs.microsoft.com/en-us/javascript/api/sp-listview-extensibility/listviewaccessorstatechanges?view=sp-typescript-latest


how to set transcription language

Is there a way to set the transcription language?

There should be a combobox for it on the top section of the main window like on this image

The from combobox is for the transcription language / source language of the input
The to combobox is for the translation target / what you want to translate into


is transformation of REQUEST_URI actually needed (could it be removed?)

Wondering if it's possible to drop transformation of REQUEST_URI for simplification...
REQUEST_URI env this is not actually part of the Rack api and is not needed for supporting case-insensitive routing?  This stems from the CGI standard which defines PATH_INFO but not REQUEST_URI.

https://github.com/rack/rack/blob/master/SPEC.rdoc#label-The+Environment
but also compare https://github.com/rack/rack/search?q=REQUEST_URI and https://github.com/rack/rack/search?q=PATH_INFO
https://tools.ietf.org/html/rfc3875#page-13

I would propose to remove REQUEST_INFO and then you could release as 2.0.
Maybe also could release a final 1.x with support for rails 4.2 (I don't think there's actually anything preventing this in the code base at present, other than the gemspec, but I could test it).

To be honest, I have no idea why we're even touching REQUEST_URI. As far as I can tell it's always been like that, but I can't see any real reason to. PATH_INFO contains the part of the URI that we want to downcase and doesn't contain any querystring arguments that we'd have to worry about.
Removing REQUEST_URI would simplify the code a good deal, I suspect. Care to take a stab at it?


ControlNet - WARNING - No ControlNetUnit detected in args. It is very likely that you are having an extension conflict.Here are args passed to ControlNet: (<scripts.controlnet_ui.controlnet_ui_group.UiControlNetUnit object at 0x000001BE7F1D2C80>, <scripts.controlnet_ui.controlnet_ui_group.UiControlNetUnit object at 0x000001BE7BD9A980>, <scripts.controlnet_ui.controlnet_ui_group.UiControlNetUnit object at 0x000001BE7BD9BBB0>).

2023-06-23 13:04:26,147 - ControlNet - WARNING - No ControlNetUnit detected in args. It is very likely that you are having an extension conflict.Here are args passed to ControlNet: (<scripts.controlnet_ui.controlnet_ui_group.UiControlNetUnit object at 0x000001BE7F1D2C80>, <scripts.controlnet_ui.controlnet_ui_group.UiControlNetUnit object at 0x000001BE7BD9A980>, <scripts.controlnet_ui.controlnet_ui_group.UiControlNetUnit object at 0x000001BE7BD9BBB0>).
2023-06-23 13:04:26,152 - ControlNet - WARNING - No ControlNetUnit detected in args. It is very likely that you are having an extension conflict.Here are args passed to ControlNet: (<scripts.controlnet_ui.controlnet_ui_group.UiControlNetUnit object at 0x000001BE7F1D2C80>, <scripts.controlnet_ui.controlnet_ui_group.UiControlNetUnit object at 0x000001BE7BD9A980>, <scripts.controlnet_ui.controlnet_ui_group.UiControlNetUnit object at 0x000001BE7BD9BBB0>).
100%|██████████████████████████████████████████████████████████████████████████████████| 15/15 [00:05<00:00,  2.90it/s]
Total progress: 100%|██████████████████████████████████████████████████████████████████| 15/15 [00:02<00:00,  5.83it/s]
2023-06-23 13:09:03,823 - ControlNet - WARNING - No ControlNetUnit detected in args. It is very likely that you are having an extension conflict.Here are args passed to ControlNet: (<scripts.controlnet_ui.controlnet_ui_group.UiControlNetUnit object at 0x000001BE7BD98C70>, <scripts.controlnet_ui.controlnet_ui_group.UiControlNetUnit object at 0x000001BE7BD9BD00>, <scripts.controlnet_ui.controlnet_ui_group.UiControlNetUnit object at 0x000001BE7BD99630>).
2023-06-23 13:09:03,824 - ControlNet - WARNING - No ControlNetUnit detected in args. It is very likely that you are having an extension conflict.Here are args passed to ControlNet: (<scripts.controlnet_ui.controlnet_ui_group.UiControlNetUnit object at 0x000001BE7BD98C70>, <scripts.controlnet_ui.controlnet_ui_group.UiControlNetUnit object at 0x000001BE7BD9BD00>, <scripts.controlnet_ui.controlnet_ui_group.UiControlNetUnit object at 0x000001BE7BD99630>).

same.  Was doing tiles with ultimate upscaler.
2023-06-23 15:06:55,255 - ControlNet - WARNING - No ControlNetUnit detected in args. It is very likely that you are having an extension conflict.Here are args passed to ControlNet: (<scripts.controlnet_ui.controlnet_ui_group.UiControlNetUnit object at 0x0000019AC0D3B160>,).
2023-06-23 15:06:55,257 - ControlNet - WARNING - No ControlNetUnit detected in args. It is very likely that you are having an extension conflict.Here are args passed to ControlNet: (<scripts.controlnet_ui.controlnet_ui_group.UiControlNetUnit object at 0x0000019AC0D3B160>,).

looks like it was an issue with the latest update. there's been a patch to the controlnet extension. updating it seems to have corrected error. Open pose isn't generating wireframe previews after img generation though. so not sure it's entirely fixed

Can confirm.  An update fixed it.

how did you update it, when i go to my available extension everything seems to be updated

I have the same problem here and I have updated everything

I have same issue with slightly different output in CLI:

I have disabled all Extensions (Ext&Int) then restarted UI to see if it help, no luck either.

Any fix for this?

Same problem here as @syousip

same issue for img2img. no problem with txt2img. i am not using any controlnet with img2img but warning generated. any update?

I got that same - try to turn off move2move extension if U use it or other extensions and try to find that one witch conflict

Same problem, cant solve ;((
I reinstalled VENV Folder and deinstalled my last installed extensions. Controlnet stopped working

I got that same - try to turn off move2move extension if U use it or other extensions and try to find that one witch conflict

its actually worked

I got that same - try to turn off move2move extension if U use it or other extensions and try to find that one witch conflict

its actually worked

That worked, thanks! but why has this conflict with mov2mov??

I got that same - try to turn off move2move extension if U use it or other extensions and try to find that one witch conflict

yeah that works for me i hope mov2mov2 works again soon

I

I got that same - try to turn off move2move extension if U use it or other extensions and try to find that one witch conflict

its actually worked

That worked, thanks! but why has this conflict with mov2mov??

its strange but i think that it have something to do with new version of Controlnet.  WIth older controlnet it works fine.
I think we need to wait for new version of controlnet or mov2mov.

I turned off SD-CN-Animation ext and it fixed it.

I turned off SD-CN-Animation ext and it fixed it.

its worked for me thanks

i turn off sd-dynamic-prompts and then it started working with no errors

I also got it working by disabling other plugins, but I don't think it's a wise thing to do because I had to disable 7 plugins to get it to work. However, in many cases many plugins are required to work together.
In addition, after I rolled back the stable diffusion for several versions, it can also be used normally

having the same issue even after disabling almost every extension

having the same issue even after disabling almost every extension

you can also try reinstall these plugins, it also works for me

Same proble here but I have no extension and it says "Here are args passed to ControlNet: ()...
I have no window to put my image in img2img too, don't know if it's the same problem.
Has anyone found a solution other than disabling extensions (I don't have any)?

Same problem, I disabled all the extensions, didn't work

Same here. On text2img and Img2img it's ok but on deforum, isn't working. Is there any solution?

Mine was doing this exact same thing but at some point (either during load or during run press maybe?) was throwing an error from the preset.py module.
Error calling: H:\wusd\stable-diffusion-webui\extensions\sd-webui-controlnet\scripts\controlnet.py/ui
Traceback (most recent call last):
  File "H:\wusd\stable-diffusion-webui\modules\scripts.py", line 243, in wrap_call
    res = func(*args, **kwargs)
  File "H:\wusd\stable-diffusion-webui\extensions\sd-webui-controlnet\scripts\controlnet.py", line 283, in ui
    group, state = self.uigroup(f"ControlNet", is_img2img, elem_id_tabname)
  File "H:\wusd\stable-diffusion-webui\extensions\sd-webui-controlnet\scripts\controlnet.py", line 258, in uigroup
    group.register_callbacks(is_img2img)
  File "H:\wusd\stable-diffusion-webui\extensions\sd-webui-controlnet\scripts\controlnet_ui\controlnet_ui_group.py", line 825, in register_callbacks
    self.preset_panel.register_callbacks(
  File "H:\wusd\stable-diffusion-webui\extensions\sd-webui-controlnet\scripts\controlnet_ui\preset.py", line 177, in register_callbacks
    ).then(
AttributeError: 'dict' object has no attribute 'then'

as I have no need for presets and they seemed to have been implemented poorly, I just went and removed any reference to the preset stuff.  I can share what I did but it'll have to be later if someone is interested.

@Whippetz thank you.  I had the same problem.   ControlNet - WARNING - No ControlNetUnit detected in args fails when the  SD-CN-Animation extension enabled.  (comment left for the internets to find)

Same problem, but the error message do not contain anything.
No ControlNetUnit detected in args. It is very likely that you are having an extension conflict.Here are args received by ControlNet: ().

In my case, the SD-CN-Animation extension https://github.com/volotat/SD-CN-Animation.git. It causes the conflict ( ControlNet - WARNING - No ControlNetUnit detected in args. It is very likely that you are having an extension conflict.Here are args received by ControlNet: ().)

set COMMANDLINE_ARGS= --update-check --update-all-extensions

In my case, the SD-CN-Animation extension https://github.com/volotat/SD-CN-Animation.git. It causes the conflict ( ControlNet - WARNING - No ControlNetUnit detected in args. It is very likely that you are having an extension conflict.Here are args received by ControlNet: ().)

I confirm this occured with my issue the same.  Unchecked SD-CN-Animation extension in extensions tab and APPLY / Restart.  The error went away.

Possibly same issue with SD-CN-Animation in Automatic1111. Causes ControlNet to be ignored or weird results.

I turned off SD-CN-Animation ext and it fixed it.

Yes,it works!!! Many thanks god


[design] recipe-run card

The recipe run card is one of the most used components in the current dashboard. The current design looks like this:

@rabernat suggested removing the border and doing some minor style updates (alternating colors, etc.). I've held off on this mostly because I think a larger redesign is needed.

@jhamman would a dataset card for https://pangeo-forge.org/catalog be included in this, or should I open a new issue for that? Datasets are just a filtered subset of recipe-runs, but I suppose we may want to feature different information for them?


Client-Service Relationship Bug

Trust relationships between processes are represented by inferred AuthChannel assets. Where the service authenticates the client (if it chooses to do so), the ClientChannel subclass is used.
The construction sequence first creates ClientChannels where there is direct client-service communition. Client-service network paths are then found and represented by inferred ServiceChannel assets, representing the means of communication (which may be compromised, so must exist as a target for certain threats). Then ClientChannels are created where a client communicates with a service indirectly, via intermediaries, and an authentication or access token is passed through so the service can decide whether to accept the (indirect) connection. No associated ServiceChannel assets are created in that case. Finally, AuthChannels are created where data flows between the client and service, and the data on the service end is protected by keys from a vault, meaning that access tokens (but not authentication tokens) must be exchanged. No ServiceChannel assets are created in this case either.
For this to work, three types of relationship links are used:

Those representing direct client-service connections, subtypes of 'Client-accessesService-Service'.
Those representing possible indirect authentication relationships, represented by subtypes of 'usesIndirectly', and created iteratively from Client-accessesService-Service-accessesService-Service patterns where the second service controls client access.
An 'indirectAuthZ' link representing the use of keys from a common OAuth-style token service, and hence the use of an access token passed from the (authorized) client enabling access to keys by the service.

The three construction patterns look for these types of relationships. However, there are some complications for ClientChannel creation. Firstly, a direct 'Client-accessesService-Service' link doesn't always mean there is a direct client-service connection. In some situations, a reverse proxy is inferred to exist between the Client and Service, e.g., if the Service is hosted by a DataCentre and access is via an inferred K8S IngressProxy. Secondly, usesIndirectly links represent all possible client-service communications via chains of intermediaries, which may be reverse proxies, an authorization deputy, or just any service that receives requests from clients and uses other services. We need a restriction to cases where there is a need for client-service communication.
In practice, therefore:

The first ClientChannel construction pattern looks for a direct 'Client-accessesService-Service' link where there is no inferred 'Client-usesIndirectly-Service' link (direct communication between the Client and Service).
The second ClientChannel construction pattern looks for an inferred 'Client-usesIndirectly-Service' link and a 'Client-accessesService-Service' link.

The second pattern is triggered if either:

there is an asserted 'Client-accessesService-Service', but access is via an inferred reverse proxy, e.g., at a DataCentre, causing there to also be an indirect 'Client-usesIndirectly-Service' link
there is a potential indirect communication path represented by a 'Client-usesIndirectly-Service' link, and there is an asserted 'Client-accessesService-Service'
there is a potential indirect communication path represented by a 'Client-usesIndirectly-Service' link, and there is an inferred 'Client-accessesService-Service' representing a need to communicate with an onboard IoT service, or a OAuth-style token service
there is a potential indirect communication path represented by a 'Client-usesIndirectly-Service' link, and there is an inferred 'Client-accessesService-Service' added because there is a data flow between the Client and Service.

Unfortunately, because 'usesIndirectly' covers three separate situations, this doesn't always produce the desired outcome. It is possible for there to be a direct Client-uses-Service relationship, where the client also uses a second service that (directly or indirectly) uses the first. In this situation, a Client-usesIndirectly-Service relationship will be inferred, suppressing creation of a direct ClientChannel. Subsequently, the Client-Service network path (ServiceChannel) inference does not occur, and the whole relationship gets missed.
To fix this, a refinement in the relationship type hierarchy is needed, such that 'Client-usesIndirectly-Service' does not inhibit creation of a direct ClientChannel (and ServiceChannel), nor lead to an indirect ClientChannel, but does still create the possibility of an AuthChannel if a token exchange is needed to enable an encrypted data flow.

This issue was addressed in branch 40, and has now been merged.


MB-6437 Add script/data to benchmark doc viewers

Description
We need to ensure that the document viewer is performant & reliable in
the transportation offices, which are known to have bandwidth issues.
This PR adds a script to populate a single move with any supported files
from the /pkg/testdatagen/testdata/bandwidth_test_docs directory. Supported
file types are PNG, JPG, and PDF. Unsupported files will display an error in the console
when running the script, but should not prevent the script from continuing to run.
This PR includes 3 files of varying sizes, that both the TOO and TIO can view in the
orders document viewer and proof of service document viewer respectively.
Reviewer Notes
To run the script:
make db_bandwidth_up

To verify the docs were created and can be viewed, follow these steps:

Start the server and client:

make server_run
make office_client_run

Click on "Local Sign in" when the office app appears
Sign in with the single office user that the script created, and
view the docs as a TOO, and then as a TIO.

As a TOO:

Click on the only move in your queue
Click on "Orders" in the left sidebar
Click on "View & edit orders" in the top right

As a TIO:

Click on "Change user role" in the top left
Click on "Select transportation_invoicing_officer"
Click on the only payment request in your queue
Click on "Review service items"

Other things to test:

Add more files, or replace the files in the bandwidth_test_docs directory with files of your choosing.
Verify that all supported file types are uploaded, but that no unsupported files types are uploaded.

Is there anything you would like reviewers to give additional scrutiny?
Code Review Verification Steps

[ ] If the change is risky, it has been tested in experimental before merging.
[ ] Code follows the guidelines for Logging
[ ] The requirements listed in Querying the Database Safely have been satisfied.
Any new migrations/schema changes:

[ ] Follow our guidelines for zero-downtime deploys (see Zero-Downtime Deploys)
[ ] Have been communicated to #g-database
[ ] Secure migrations have been tested following the instructions in our docs

[ ] There are no aXe warnings for UI.
[ ] This works in Supported Browsers and their phone views (Chrome, Firefox, IE, Edge).
[ ] Tested in the Experimental environment (for changes to containers, app startup, or connection to data stores)
[ ] User facing changes have been reviewed by design.
[ ] Request review from a member of a different team.
[ ] Have the Jira acceptance criteria been met for this change?

References

Jira story for this change

Messages

:book:
:link: MB-6437

  Generated by :no_entry_sign: dangerJS against 98d4b95e6af609aa87340e5d85a5ac08f2501ed0

@monfresh I'm worried this doesn't work for uploading to s3.  I tried changing my STORAGE_BACKEND env variable but it looks like we're ignoring that and always using the local storage:
https://github.com/transcom/mymove/blob/58270b71cdd5e9e426ddf7c002345552f0c8d04e/cmd/generate-test-data/main.go#L164-L167

I just tested it and it looks like the network throttling will still work with local files, so hopefully my above comment is not a blocker but a nice to have.  I think we'll want the ability to test in a deployed environment though not just locally for other reasons too.

@duncan-truss That's a great point about being able to change the storage system with the STORAGE_BACKEND env var. Unfortunately, it's not as easy as using that line from serve.go. From what I can tell, the storer that is defined in /cmd/generate-test-data/main.go is not even used in any of the scenarios (like e2ebasic and devseed). I also don't see any mention of the storer in our various testdatagen files for creating uploads. I need to dig into the code to see where (or if) the env var is used.

Ah! I see it now. It's passed into the userUploader and primeUploader, which are used by the testdatagen scenarios and Make functions. I'll create a new ticket for this and fix it on Monday.


Did anybody manage to get tsserver working?

I've tried a bunch of different things, but I always get the same error:
Dec 31 17:00:14.293 DEBG To server: {"jsonrpc":"2.0","method":"initialize","params":{"capabilities":{"textDocument":{"codeAction":{"codeActionLiteralSupport":{"codeActionKind":{"valueSet":["quickfix","refactor","refactor.extract","refactor.inline","refactor.rewrite","source","source.organizeImports"]}}},"colorProvider":null,"completion":{"completionItem":{"documentationFormat":["plaintext"],"snippetSupport":false}}},"workspace":{"workspaceEdit":{"documentChanges":true,"resourceOperations":["create","delete","rename"]}}},"processId":42082,"rootUri":"file:///Users/vincent/lighthouse/w4/d5","trace":"off"},"id":0}, module: kak_lsp::language_server_transport:175
Dec 31 17:00:14.596 DEBG From server: {"seq":0,"type":"response","command":"unknown","request_seq":0,"success":false,"message":"Error processing request. Unexpected token C in JSON at position 0\nSyntaxError: Unexpected token C in JSON at position 0\n    at JSON.parse (<anonymous>)\n    at IOSession.Session.onMessage (/usr/local/lib/node_modules/typescript/lib/tsserver.js:140952:36)\n    at Interface.<anonymous> (/usr/local/lib/node_modules/typescript/lib/tsserver.js:142270:27)\n    at Interface.emit (events.js:203:13)\n    at Interface._onLine (readline.js:314:10)\n    at Interface._normalWrite (readline.js:459:12)\n    at Socket.ondata (readline.js:170:10)\n    at Socket.emit (events.js:203:13)\n    at addChunk (_stream_readable.js:294:12)\n    at readableAddChunk (_stream_readable.js:275:11)\n    at Socket.Readable.push (_stream_readable.js:210:10)\n    at Pipe.onStreamRead (internal/stream_base_commons.js:166:17)"}
, module: kak_lsp::language_server_transport:149
Dec 31 17:00:14.596 ERRO Invalid call from language server: Null, module: kak_lsp::controller:108
Dec 31 17:00:14.596 DEBG From server: {"seq":0,"type":"response","command":"unknown","request_seq":0,"success":false,"message":"Error processing request. Unexpected end of JSON input\nSyntaxError: Unexpected end of JSON input\n    at JSON.parse (<anonymous>)\n    at IOSession.Session.onMessage (/usr/local/lib/node_modules/typescript/lib/tsserver.js:140952:36)\n    at Interface.<anonymous> (/usr/local/lib/node_modules/typescript/lib/tsserver.js:142270:27)\n    at Interface.emit (events.js:203:13)\n    at Interface._onLine (readline.js:314:10)\n    at Interface._normalWrite (readline.js:459:12)\n    at Socket.ondata (readline.js:170:10)\n    at Socket.emit (events.js:203:13)\n    at addChunk (_stream_readable.js:294:12)\n    at readableAddChunk (_stream_readable.js:275:11)\n    at Socket.Readable.push (_stream_readable.js:210:10)\n    at Pipe.onStreamRead (internal/stream_base_commons.js:166:17)"}
, module: kak_lsp::language_server_transport:149
Dec 31 17:00:14.596 ERRO Invalid call from language server: Null, module: kak_lsp::controller:108
Dec 31 17:00:14.597 DEBG From server: {"seq":0,"type":"event","event":"typingsInstallerPid","body":{"pid":42119}}

Any help is appreciated! :)

Ironically tsserver is not a language server (it has its own protocol). For TypeScript you can try the language servers https://github.com/theia-ide/typescript-language-server and https://github.com/sourcegraph/javascript-typescript-langserver.

Are there any plans to support tsserver in addition to the other language servers? Like Ale does for vim?
Both TypeScript language server implementations mentioned above are severely lacking. For example:

https://github.com/theia-ide/typescript-language-server doesn't understand TSX at all
https://github.com/sourcegraph/javascript-typescript-langserver doesn't understand advanced types like Omit<...

I know it is not your fault that these language servers suck. Still, it would be nice to have tsserver support. Though I have no idea how much effort an implementation would be.

I'm not sure if the current kak-lsp architecture is flexible enough to accommodate support for a different protocol but I'd say that PR is welcome if you are willing to try.
kak-lsp is aimed to bring IDE-like convenience to Kakoune in the first place, not be a reference LSP implementation or something like that. If something is orthogonal and could stay separate then it's good but if pragmatically it benefits from extending kak-lsp, why not?

Theia's TS langserver actually does support tsx but you have to configure kak-lsp like so:
[language.tsx]
filetypes = ["typescript"]
roots = ["package.json"]
offset_encoding = "utf-8"
command = "typescript-language-server"
args = ['--stdio']

From the discussion on https://github.com/ul/kak-lsp/issues/211

Thanks, @danr , that helped a lot.
@ul it seems Ale has a lot of if (tsserver) {} else {} parts in its code, which would probably be a lot of work and not necessarily the maintainable thing to do in kak-lsp.
If someone wanted to add support for tsserver, I could imagine the first step would be to extract all calls to the LSP behind an interface which could then be implemented by tsserver. What do you think?
If you point me in the right directions, I could give the creation of such an interface a shot.

You can start with https://github.com/theia-ide/typescript-language-server, which is a wrapper around tsserver, and then add custom LSP methods to support functionality you are missing. It's fairly straightforward to add calls to those bespoke methods in kak-lsp, we already have plenty of them (introduced by ccls, cquery and eclipse-jdt language servers).

Yeah, adding tsserver support to kak-lsp would be a huge task. For example, kak-lsp has jsonrpc hard coded in many places and tsserver also doesn't speak jsonrpc. And then in addition to that, you would need to check everywhere which (de)serialization to do based on the running server.
Unfortunately, https://github.com/theia-ide/typescript-language-server is currently unmaintained. Last PR was merged in October and that is also the last commit.
Well, maybe one day tsserver will speak lsp. So long, I will need to stay buggy, I guess 😅 Maybe I find a fork that fixes the most annoying thing: when I move the cursor over an undefined, I get an error message covering the whole screen, see below.
Thank you for all your support and detailed answers (and kak-lsp in the first place).

Good news! Support for LSP protocol has been included in TypeScript 4.3 Iteration Plan.
https://github.com/microsoft/TypeScript/issues/39459#issuecomment-696179304

Great! That's a relief.

Nice! In the meantime, I’ve had some success with Deno’s LSP implementation. 🙂


Improve documentation - resume session parameter for browserbase sessions

We now have the ability to resume a browserbase session by passing in an existing session ID
https://github.com/browserbase/stagehand/blob/main/lib/index.ts#L315
need documentation on it.

Addressed in #223 (thanks @pkiv!)


Updates for Bevy 0.13

I believe this is all you need to update the crate to Bevy 0.13
That said, your patched version of bevy_tweening is a few commits behind, and without it the examples run into runtime problems.

Oh! Sorry about that. Not sure what I was doing there.
Try that.

Sorry about the delay, now I merge your changes, you're very thanks for your contribution :D


Update README.md

What type of PR is this? (check all applicable)

[x] 🚀 Added Name
[ ] ✨ Feature
[ ] ✅ Joined Community
[ ] 🌟 ed the repo
[ ] 🐛 Grammatical Error
[ ] 📝 Documentation Update
[ ] 🚩 Other

Description
Add Link of GitHub Profile

Hi @abhisheknaiidu, could you merge it?😃


[WIP] Support rejson module commands

[x] Add support to parse rejson module commands in dynomite
[ ] Add command tests.

Will have a look by EOD.

Code LGTM. It will be good to add some tests.


Bug: --no-cache leads to no embeddings found

I have a promptfooconfig.yaml with promptfoo==0.25.0 that looks like this:
---
defaultTest:
    options:
        provider: localai:embeddings:bert-embeddings
prompts: [prompts.txt]
providers: ["ollama:llama2:13b"]
sharing: false
tests:
    - vars:
          area: foo
          result: bar
      assert:
          - type: similar
            value: {{ result }} <redacted> {{ area }}.

Running promptfoo eval --no-cache, I get:
[FAIL] API response error: Error: No embedding found in LocalAI embeddings API response: {"error":{"code":500,"message":"rpc error: code = Unavailable desc = error reading from server: EOF","type":""}}

I think somehow the --no-cache option is preventing promptfoo from using LocalAI embeddings.  It seems there's still a dependency on cache entries to pass data.

I'm having trouble reproducing this issue with the config you provided.  My steps are:

clear the cache promptfoo cache clear (or delete ~/.promptfoo manually)
run promptfoo eval normally to fill the cache
run promptfoo eval --no-cache to make sure it doesn't use the cache

Any more detail on your end I should be paying attention to?

What I was seeing yesterday was:

Usage without --no-cache: worked fine
Usage with --no-cache: failed with the original post's error

However, today I can't repro it either 😵 .  Going to close this out, sorry for the churn