ListBox template for a grid view layout

Just an adaption of the ListBox template to lay out the items in a grid. The card version is not adapted because cards are a DON'T in grids according to the official specs.

Gonna come back to this because a) we haven't got a proper actual ListView.GridView yet, so there might be some naming conflict and I don't want to have to rename later, b) quickly looking at the markup there might be some duplication we can remove.

I just added basic templates for the Expander and the TabControl.

@spiegelp thanks for your contributions.

I purposefully don't want a TabControl template.  I want Dragablz to be the de-facto TabControl, and don't want the extra code to have to support; Dragablz is already far from complete, and taking up a lot of my time.  It does look nice but I know from experience there will soon be requests for vertical tabs, etc and I can't have the duplication.

Expander: can we tidy this up a little?  Bring all the spacing in-line with the TreeView and use the same animations?  Then we will have some nice consistency.  If you can do this and put the Expander in a separate PR, I'll bring it in.

Thanks.

Thank you, sorry for the delay on this one.


Feed images don't respect ComfyUI's output directory.

As you can see in the above screenshot, images in the feed don't seem to actually exist where the feed is looking for them.
From what I can tell, it looks like the reason is simple.  I'm using ComfyUI's "--output-directory" paramater to change the output directory, and it seems like the feed doesn't check with ComfyUI to make sure it's actually looking in the right folder for the output images.

Hey, thank you for the report. I've pushed an update that may fix this, but I can't reproduce it myself so I'm not sure.
If this issue isn't resolved, can you please respond with your operating system, browser, and logs, both browser and python logs.

Looks to me like the fix is working perfectly.  Thanks for the help!


DateTime, Date, Time, JSON - scalars proposal

What do you think to add those scalars out of the box:
DateTime, Date, Time, JSON
and make it configurable to disable them.
I think I will need them in all of my apps, especially DateTime.
If you think it's good idea I can send PR.

I think there's definitely value in supporting a common set of schema definitions + type resolvers as a standalone package (which then could be used by graphql-yoga).
I remember @RomanGotsiy and @IvanGoncharov coming up with the same idea. Would be great to hear their thoughts!

We still have this idea and to release such package. However, it blocked by https://github.com/facebook/graphql/pull/326 since if
you define custom scalars without specifying underlying serialization type you create a lot of problems for tooling and especially for code generation.

@IvanGoncharov as I guess its still a draft implementation and I think we can add those scalars today and describe serialization type for them when it will be possible and stable.

There's already graphql-iso-date for date scalars, and graphql-type-json for JSON types. I don't think we need to reinvent them again.

@kbrandwijk my proposal was just to use already implemented scalars and put the in graphql-yoga out of the box.

@playerx Yes, and I completely agree with that. My response was more for @IvanGoncharov who mentioned releasing another package like that.

This is also related to https://github.com/graphcool/graphcool-binding/issues/15

@kbrandwijk In graphql-js 0.12.x you don't need to use any external package for JSON scalar since all scalars by default will accept all values:
https://github.com/graphql/graphql-js/blob/master/src/type/definition.js#L498
Just define it as scalar JSON inside your SDL schema 🎉
As for package I planning to do I have a few very specific features in mind not sure if it will work like intended but I will try 😄

Hey, @Urigo from The Guild here!
You might know us from projects such as graphql-code-generator, envelop or graphql-tools.
For a long time we thought that the Javascript ecosystem is still missing a lightweight cross-platform, but still highly customizable GraphQL Server.
In the past the awesome Prisma team took on that great challenge and now we are happy to announce that we are continuing them and just released GraphQL Yoga 2.0 - Build fast, extensible, and batteries-included (Subscriptions, Serverless, File uploads support) GraphQL APIs in Node.js 🚀
And regarding the issue here, we also maintain the GraphQL Scalars library
We have been working a long time on version 2.0 and have been using it in our clients projects for a few months now and shared a couple of alpha cycles here.
Thank you all for your feedback and suggestions, you made this release possible!
Please try Yoga out again, give us feedback and help us spread the word on the new release!

Announcement and blog post
https://github.com/dotansimha/graphql-yoga/issues/704
https://www.graphql-yoga.com/


PHOENIX-5975 Index rebuild/verification page size should be configura…

…ble from IndexTool

JIRA already committed, closing PR


I.clearField('#name') not working

I.clearField() not working,I am trying to remove a input filed text which i first filled with I.fillFIled('#name','zee').Fill field is working fine but clear field not clearing the input text which earlier filled by fill field

Please use the issue template. You didn't specify which helper you are using


Claim values are truncated at first comma

Library name and version
Microsoft.Azure.WebJobs.Extensions.SignalRService 1.6.0
Describe the bug
It appears that claim values when populated into InvocationContext are incorrectly truncated if they contain a comma.  We noticed this looking at the name claim for a user; one had like so:
FirstName LastName (Company, Inc.)
What actually gets into the name claim is:
FirstName LastName (Company,
This appears to be because https://github.com/Azure/azure-sdk-for-net/blob/main/sdk/signalr/Microsoft.Azure.WebJobs.Extensions.SignalRService/src/TriggerBindings/Utils/SignalRTriggerUtils.cs line 39 is splitting on all commas, not just the first.
Expected behavior
Claim values end up in InvocationContext without modification.
Actual behavior
Claim values are truncated at the first embedded comma.
Reproduction Steps
Pass a claim with a comma in the value.
Environment
.NET Core 3.1
Visual Studio 2019

Label prediction was below confidence level 0.6 for Model:ServiceLabels: 'Service Bus:0.20174699,Extensions:0.0898339,Functions:0.08797858'

@jasmcc Thanks for sharing details.  We are looking into it and get back to you for any questions.

@Y-Sindo please take a look

Currently we use commas as a separator for different claims in the HTTP request header (see serverless protocol for more details), which seems problematic. We plan to add a new HTTP header which contains the base64 encoded claims to solve the problem.  Before that fix is released, you could try to encode your claim values with base64 yourself as a mitigation.


fix(RCTContacts): Fix thumbnail path missing on string search

This PR is to allow thumbnail pictures to show on search. For whatever reasons, it was disabled.

lgtm


How can one predict on new data using the glm ?

Thank you

GML doesn't support predicting new data because the purpose of GML is to know which model is best for your data, but in future, we have plan to add that functionality as well. however you can contribute as well it should be just a few lines of code.


custom 404 and 500 pages

Let's implement custom 404 not found and 500 error pages.

Simple solution. For example, the 404:


Updated visual-studio-code (0.10.10)

Lots of changes and bug fixes at https://code.visualstudio.com/Updates

Thank you for the contribution. It needed some fixes, so they were made in 36b4e6c9bed13ae1b718eedbb566342c47a219d4. Your contribution is still included (and still credited to you), with the appropriate modifications. Please feel free to ask about any of the changes.


Live demo endpoint not working

I am following this tutorial series.
Found that live demo endpoint is not working.
Tried with:
https://eve-demo.herokuapp.com/people
also tried:
http://myapi/people

Ho @rahulsalgare. Heroku has just recently dropped support for the free Cedar instances (the type on which the eve-demo app was running). So yes, unfortunately, the endpoint which has been running for years is not working anymore. You can still install and run the demo app on your local server (you'll find the eve-demo repository in the pyeve organization here on GitHub).

Okay Thank you @nicolaiarocci.


Circular link

The Numeric Property Properties link refers to itself

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: c0e4674f-88bb-2fed-e110-3995500284cc
Version Independent ID: 3b06b603-5996-3e72-95f8-a785757ca3e3
Content: Numeric Property - Business Central
Content Source: dev-itpro/developer/properties/devenv-numeric-property.md
Service: dynamics365-business-central
GitHub Login: @SusanneWindfeldPedersen
Microsoft Alias: solsen

Hi, thanks for your feedback, this has been fixed.


Set --cloud-provider=external in kubelet flags

Otherwise things like cpem won't work.

Fixed in latest commit.


Template Map don't working in Windows Pt Language.

I found an Issue when i build a new template from image (on Design) and Save.
When I Load this template, the page border references saves the X,Y Coordinates wrong.
I think it can be the Float property.
In en-US language float is (ex.) 10.00.
In pt-Br language float is (ex.) 10,00.
I can fix this issue adding the following code in Program.cs >> Main() thread:
[STAThread]
static void Main()
{
Application.EnableVisualStyles();
Application.SetCompatibleTextRenderingDefault(false);
System.Globalization.CultureInfo cultureInfo = new System.Globalization.CultureInfo("en-US");
Application.CurrentCulture = cultureInfo;
Application.EnableVisualStyles();
Application.SetCompatibleTextRenderingDefault(false);
Application.Run(new frmMain());
}

Hmmm.... That is interesting... Do you have a patch you can submit? I would be more than happy to merge as we are also looking to leverage this base platform in other regions.


add AllenAI's Olmo if they release an instruction tuned version

https://blog.allenai.org/olmo-open-language-model-87ccfc95f580

Possibly a dumb question, but why only if they release an instruction-tuned version?

Because this repo tracks only those — too many base models for us to (also) track...

Seems to have arrived: https://huggingface.co/allenai/OLMo-7B-Instruct


integration-cli: Generate unix-style volume paths for tests

Some tests in docker_api_containers_test.go assume the
docker daemon is running at the same machine as the cli
and uses ioutil.TempDir to create temp dirs and use them
in the test.
On windows ioutil.TempDir and os.TempDir would create win-style
paths and pass them to daemon. Instead, I hardcoded /tmp/test.{{randString}}
and test generates some random path manually and allow daemon to create
the directory on daemon-side.
Fixes tests:

TestContainerApiStartVolumeBinds
TestContainerApiStartDupVolumeBinds
TestVolumesFromHasPriority

Downside:

Does not clean the temp dirs generated on the remote daemon machine unless delete container deletes them.

Signed-off-by: Ahmet Alp Balkan<EMAIL_ADDRESS>cc: @unclejack @cpuguy83 @estesp @jfrazelle
Label: #windows

https://jenkins.dockerproject.com/job/Windows-PRs/36/console
=== RUN TestContainerApiStartVolumeBinds
[PASSED]: container REST API - check volume binds on start
--- PASS: TestContainerApiStartVolumeBinds (1.21s)
=== RUN TestContainerApiStartDupVolumeBinds
[PASSED]: container REST API - check for duplicate volume binds error on start
--- PASS: TestContainerApiStartDupVolumeBinds (0.94s)
=== RUN TestVolumesFromHasPriority
[PASSED]: container REST API - check VolumesFrom has priority
--- PASS: TestVolumesFromHasPriority (1.92s) :+1:

So, we need paths a lot in the tests. Maybe we should make a helper for creating temp paths like this since we can't use the normal mechanisms.

@cpuguy83 extracted into a helper.

Sweet, LGTM

kewl LGTM


Added Latvian and Lithuanian translations of country names.

Added Latvian and Lithuanian translations of country names.
Please add Latvian and Lithuanian support, we need this feature in our project.

Thank you for your contribution. Released in v2.0.16.


Read_write _sequence complete on 30-09-2020

Testcbench Document - Priya , -  basic structure by 14/09/2020
Env - Multiple master slave instantiation, basic environment
Sequences - Rahul (exclusive) , Vishnupriya (basic sequenecs, Wrap and increment) -14/9/2020
Agent - Abhinandan , Deeksha - Master  - 19/09/2020
Driver - Abhinandan Master Master - 9/09/2020 completed
Monitor - Abhinanadan -16/09/2020
Agent - Slave Vaibhav -19/09/2020
Scoreboard - Jitendra - completed
Virtual Sequencer - Sreeram - 16/09/2020
virtual Sequence - Sreeram -16/09/2020
Coverage - Kavita- 19/09/2020
master
Slave
interface - completed

Testcbench Document - Priya , - basic structure by 14/09/2020
Env - Multiple master slave instantiation, basic environment
Sequences - Rahul (exclusive) , Vishnupriya (basic sequenecs, Wrap and increment) -14/9/2020
Agent - Abhinandan , Deeksha - Master - 19/09/2020
Driver - Abhinandan Master Master - 9/09/2020 completed
Monitor - Abhinanadan -16/09/2020
Agent - Slave Vaibhav -19/09/2020
Scoreboard - Jitendra - we need to do for out of order  and exclusive order (basic read write completed)
Virtual Sequencer - Sreeram - 16/09/2020
virtual Sequence - Sreeram -16/09/2020
Coverage - Kavita- 19/09/2020
master
Slave
interface - completed

testbench document delayed - Priya to complete the basic on 16/9/2020

opening new issue asnew people assigned


Transfer ownership to the Teclib Organization on GitHub

Hi, I will propose to move this repo to @teclib.

Hi, @orthagh
Could you help us with this task?
This plugin can be integrate in any other project (iOS and Android) 👍
Thank you.

Hello @ajsb85
You don't have admin right on this current repo ?

Done
https://github.com/TECLIB/fastlane-plugin-xcov_report
Thank you!


⚠ Bofrost.es has degraded performance

In bef3885, Bofrost.es (https://www.bofrost.es) experienced degraded performance:

HTTP code: 200
Response time: 1502 ms

Resolved: Bofrost.es performance has improved in 0f74928 after 6 minutes.


Enable webhooks for FreeBSD buildbot

Currently the FreeBSD buildbot is polling github for changes to mio.  Builds will be faster if you enable webhooks.  To do that, go into Settings->Webhooks.  Click "Add Webhook".  For the payload url, use "https://alan.ci/buildbot/change_hook/github?project=carllerche/mio".  For events, select "Let me select individual events", and check "Pushes" and "Pull Requests".  Finally, check "Active" at the bottom.  You'll also need a secret key for the "Secret" field.  Send me a private message on Gitter for the key.

I added it but got the following error:
Headers
Connection: keep-alive
Content-Length: 33
Content-Type: text/html
Date: Tue, 03 Jul 2018 23:19:59 GMT
Server: nginx/1.12.1
Transfer-Encoding: chunked

Body
Request has no required signature

Is that error from GitHub or buildbot?  I wonder if "no required signature" is because the secret key was missing.

I did not put in a secret key. It looks like that is the HTTP response returned from your server.


Documentation refactors april

Codecov Report

Merging #449 (90203c5) into develop (dabe76f) will decrease coverage by 0.13%.
The diff coverage is 0.00%.

:exclamation: Current head 90203c5 differs from pull request most recent head 18af09a. Consider uploading reports for the commit 18af09a to get more accurate results

@@             Coverage Diff             @@
##           develop     #449      +/-   ##
===========================================
- Coverage    54.75%   54.61%   -0.14%
===========================================
  Files           35       35
  Lines         2442     2448       +6
===========================================
  Hits          1337     1337
- Misses        1105     1111       +6

Impacted Files
Coverage Δ

...ns/DistributionOperation/DistributionOperation.res
44.44% <0.00%> (ø)

...script/Distributions/SymbolicDist/SymbolicDist.res
73.62% <0.00%> (-0.88%)
:arrow_down:

...Interface/ReducerInterface_GenericDistribution.res
57.71% <0.00%> (-1.19%)
:arrow_down:

packages/squiggle-lang/src/rescript/Utility/E.res
41.34% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dabe76f...18af09a. Read the comment docs.

inline code doesn't do great within the Tabs, in firefox at least.

inline code doesn't do great within the Tabs, in firefox at least.
Yea, I noticed. Basically, in the tabs, it changes to us using HTML, not their markdown.

Yea, I noticed. Basically, in the tabs, it changes to us using HTML, not their markdown. This is definitely an area for improvement at some point.

Doesn't this mean you can just do <code> </code>?

Bugs
Arrays don't display correctly:

A bunch of function errors,

Improvements
In /docs/Features/Node-Packages, it would be good to give an example of how to use the docs package.

I added some tweaks. I have a call, but will continue looking at this later

(Merging. @NunoSempere : Feel free to change later, and submit future PRs)


fixing issue #1167

It seems that the android package uses a too generic package name. Changed this to have a distinct namespace com.aksonov.routerflux.example

Thanks for android example improvements!


Thanks!

Lol...
Really appreciate this. The solidworks is something that can be had sometimes on student license, or other institutional arrangement. So it's great to have as a possiblilty on linux.
Of course solidworks (as a cad program) has it's own set of issues. But it's great that you will try to help put together guides and information, and describe any bugs here. So that people knows about it.
Many thanks

I use for my tests the Maker-License of SOLIDWORKS and I hope that I also get to work this program on Linux like as Autodesk Fusion 360. 😊
So can I help all people’s they will use this. 👌


MaxListenersExceededWarning when creating multiple diff streams

Version
hyperdrive: 9.15.0
random-access-memory: 3.1.1
Code to reproduce
const hyperdrive = require('hyperdrive')
const ram = require('random-access-memory')

let archive = hyperdrive(ram)

for (let i = 0; i < 20; i++) {
  archive.writeFile('foo', 'bar')
}

setTimeout(() => {
  console.log(archive.version) // version = 20

  for (let i = 0; i < 20; i++) {
    let diff = archive.createDiffStream(i)
  }
  /*
  (node:40126) MaxListenersExceededWarning: Possible EventEmitter memory leak detected. 11 append listeners added. Use emitter.setMaxListeners() to increase limit
  (node:40126) MaxListenersExceededWarning: Possible EventEmitter memory leak detected. 11 extension listeners added. Use emitter.setMaxListeners() to increase limit
  (node:40126) MaxListenersExceededWarning: Possible EventEmitter memory leak detected. 11 error listeners added. Use emitter.setMaxListeners() to increase limit
  (node:40126) MaxListenersExceededWarning: Possible EventEmitter memory leak detected. 11 error listeners added. Use emitter.setMaxListeners() to increase limit
  */
}, 1000)

Detail
I believe the core issue is here: https://github.com/mafintosh/hyperdrive/blob/master/index.js#L329.
When we create a diff stream, hyperdrive will create(checkout) a new archive version sharing the same metadata feed. The version archive will register its own event listeners on the same metadata feed. Therefore the leak.
I'm not sure how to fix it. Is there a way to close only the version archive without closing the origin archive too?

Just tried the same code on hyperdrive v10. It still leaks listeners.
(node:94165) MaxListenersExceededWarning: Possible EventEmitter memory leak detected. 11 ready listeners added. Use emitter.setMaxListeners() to increase limit

We probably need some way to 'detach' an archive from hypercore feeds. Maybe we can freeze an archive and it will remove all its listeners from the feeds?
I'm going to play around it for a bit and see if it's reasonable.

Is it really a leak if it's attaching new listeners? Maybe we need some sort of soft "close" method which will detach listeners on the old checked out archive once it's not needed. Or on the checked out archive once we're done listening to it.

IIUC currently there's no way to detach these new listeners after creating a diff stream. Hence I was thinking that it's a leak.
I agree that calling it a leak might be too harsh. A "soft close" can definitely help in this situation!

Hmm, if it's keeping the listeners there after you've finished with the diff stream it's definitely a memory leak. 😁
I'd imagine something like diffstream.end() should be cleaning up any listeners.
Just to confirm, are you seeing this with hyperdrive v9 or v10? (v10 is in the master branch and uses a different data structure for the filesystem representation)

I've tried on v9 and v10 and can reproduce the warning on both versions.

There are total 6 six event listeners leaked whenever we create a new checkout. Their corresponding events are:

append
error
extension
peer-add
peer-remove
ready

For the first 5, they're created in the _ready callback in the index.js. Every time we create a new checkout, a new set of listeners is attached onto the same metadata feed used by the origin archive.
Currently there's no way to remove these listeners. Hence I added a new method closeCheckout which works like a "soft close" mentioned in the previous comment.
The last one happens in the mountable-hypertrie. I've also submitted a PR for it.

Hey @poga,
As per the comment in the closeCheckout PR, I think it'd make more sense to just not register those listeners on checkouts at all and opt for another approach. append, for example, won't make sense on a checkout in the first place, and we might want to say that the others are only available on the base drive.
Another option is for the base drive to track all checkouts and dispatch events to them, instead of registering new listeners. The first way (no events on checkouts) is much simpler, but it's not immediately clear if that would be a confusing limitation. @mafintosh have thoughts on this?

Yeah, not registering these listeners on checkouts definitely make more sense.
One limitation I can think of it is that error events will only triggered on the base archive. If an error happened on the base archive, people need to keep track of the relation between archives and checkouts, and propagate error by themself, which might be confusing.


Sample ids of covariates and phenotype do not match.

Hi. I am trying to run your software on my dataset. My genotype data is a binary plink file. Without any covariate, the software runs just fine. As soon as I add covariates, I get the title error message. I have checked extensively for any mismatch between the cov and pheno files, and found none. I even used R to arrange the IDs so they appear in the same order in both files, but this has not changed anything. I tried to convert the plink file to H5 (in case the double ID columns were causing the issue) but it didn't work. I do not know what else I can do. I am copying the head of both files down below. Any help would be appreciated. I will use the opportunity to ask how should I code missing data (empty, NAs, etc)? Also, if my phenotype is binary, how it should be coded? Plink asks for 2 for cases and 1 for controls. Does your software accepts that?
PHENO:
FID,aod_FR
10E1,1
10E3,1
10E4,1
10E6,1
10N1,1
10N3,1
10N3b,1
10S1,1
10S6,1
COV:
FID,RainfallAve_1km_91to20,Elevation_1haAve,Ca_Mg,SO2_SO4_1,NO2_NO3__1,DDEG,DBH
10E1,761.0971351,86.05000114,4.5,2.5,9.2,378.7459472,78.7
10E3,761.0971351,86.05000114,4.5,2.5,9.2,378.7459472,49.8
10E4,761.0971351,86.05000114,4.5,2.5,9.2,378.7459472,52.1
10E6,761.0971351,86.05000114,4.5,2.5,9.2,378.7459472,68.1
10N1,761.0971351,86.05000114,4.5,2.5,9.2,378.7459472,71
10N3,761.0971351,86.05000114,4.5,2.5,9.2,378.7459472,59
10N3b,761.0971351,86.05000114,4.5,2.5,9.2,378.7459472,59
10S1,761.0971351,86.05000114,4.5,2.5,9.2,378.7459472,88.8
10S6,761.0971351,86.05000114,4.5,2.5,9.2,378.7459472,65

Hi rcarleial,
Unfortunately, I was not able to recreate your error with my own data. Could you maybe send me some sample data via email (maura.john@tum.de)? Then I can try and find the issue.
Regarding your second question:
Missing data should either be empty or coded as np.nan.
Regarding your third question:
Yes, permGWAS should accept binary data coded as 1 and 2.


Documentation

Tasks

[ ] Create better README.md (18.02)
[ ] Create CONTRIBUTING.md and CODE_OF_CONDUCT.md (21.02)

some tasks will add later

Literature

My Templates
Your Templates

Branch
master
Folder
root

Now I have a problem with adding this repository to Codacy, but I'll try to solve it. If everything is good, I'll notice you.

@VsIG-official
As you can see, Codacy already works. I'll do some magic so we have the highest score.

In lines 5-10(README.md) change in links Templates to song-helper
Move Codacy badge to Code style paragraph
Site for TOC generating
Look at this tasks, maybe something need to changing. It will be better, if we can discuss these tasks in Discussions
If you have questions about Templates, write here or in Discussions

Maybe you wanted to work with these problems I wrote earlier, so I apologize

@VsIG-official

Badge on the line 77 is unnecessary, you can remove it.
In paragraph Build status you can add these badges:

[![Bot CI](https://github.com/mezidia/song-helper/actions/workflows/bot.yml/badge.svg)](https://github.com/mezidia/song-helper/actions/workflows/bot.yml)
[![Formate Code](https://github.com/mezidia/song-helper/actions/workflows/formatter.yml/badge.svg)](https://github.com/mezidia/song-helper/actions/workflows/formatter.yml)
[![song-helper CI](https://github.com/mezidia/song-helper/actions/workflows/song-helper.yml/badge.svg)](https://github.com/mezidia/song-helper/actions/workflows/song-helper.yml)
[![Django CI](https://github.com/mezidia/song-helper/actions/workflows/django.yml/badge.svg)](https://github.com/mezidia/song-helper/actions/workflows/django.yml)

In paragraph Tech/framework used :wrench: add this text:

- [NumPy](https://numpy.org/)
- [TensorFlow](https://www.tensorflow.org/)
- [aiogram](https://github.com/aiogram/aiogram)
- [python-dotenv](https://pypi.org/project/python-dotenv/)

In paragraph Tests :microscope: add this text:
We use [unittest](https://docs.python.org/3/library/unittest.html) as framework for testing. All results you can see [here](https://github.com/mezidia/song-helper/actions). For tests look in folders of each part of this project.

All your done work is very good!

Done

Done

THE BEST!

Done

Issue with Django.yml badge is normal. It's because Django CI hasn't started even

Finish the second item

Finish the second item

Perfect!


Roles are evaluated in the wrong order

https://github.com/zendframework/zend-permissions-acl/blame/master/src/Acl.php#L903
The line above uses array_pop().
The manual reads

array_pop — Pop the element off the end of array

The function roleDFSVisitOnePrivilege loads the parent roles from the top down
https://github.com/zendframework/zend-permissions-acl/blame/master/src/Acl.php#L956
        foreach ($this->getRoleRegistry()->getParents($role) as $roleParent) {
            $dfs['stack'][] = $roleParent;
        }

The result of roles being added to the stack from the most permissioned to the least then reading the roles from the least permissioned to the most causes the ACL to fail when a role hierarchy such as

Admin > User > Guest

where the permission allows a User.

I think this is a serious issue which has backwards breaking written all over it.
This line https://github.com/zendframework/zend-permissions-acl/blame/master/src/Acl.php#L905
loops until a true or false is returned.  I think a valid way to correct this is to modify the loop to check all roles until a true is found and if a false is found within them return that if no true is found.

https://github.com/zendframework/zend-permissions-acl/pull/31/files

So I may be dyslexic but I'm not.  When roles are added as parents of a role their logical order in my mind should be most privileged to least.  But when ordered this way the least privileged role is evaluated before any of the other parents.
I'm going to change api-skeletons/zf-oauth2-doctrine-permissions-acl to load parents in reverse order from what I feel is the natural order.

@TomHAnderson can you provide a unit test to proof the issue? Thanks!

https://github.com/zendframework/zend-permissions-acl/pull/31/files

I've got a pending project which is waiting on a decision for this issue.  The dark side easy way is to fix api-skeletons/zf-oauth2-doctrine-permissions-acl to load roles backwards and I'm not keen on the dark side.  Please let me know how you'd like to proceed with this.

ping @ezimuel  - any word on this?

Here is an alternative fix for the same problem:  https://github.com/zendframework/zend-permissions-acl/pull/32

#33 corrects the existing unit tests.  Please look into these library updates asap, @ezimuel

@TomHAnderson I reviewed #33, waiting for your replies. Thanks!

Close because it's not an issue, see my comment here.


Test If A Timeline Exists

I needed a way to test if a timeline with a specific name existed, for automated validation testing for my project. There is a function that almost does exactly waht I need, but it's internal. So I made up this quick external one:
static func timeline_exists(timeline: String):
var timeline_file = _get_timeline_file_from_name(timeline)
if timeline_file:
return true
else:
return false

as an addendum to this, the _get_timeline_file_from_name() function seems to fallback for searching the entire tree for a timeline, so it can't be used directly the way I have it for example. this also means that calling Dialogic.start() without an actual path could lead to calling the wrong node since it just goes for the first one it finds in the JSON order, rather than the sorted Dialogic order, which would seeem to be a bug:
Example timelines setup:

The absolute paths work for the most part, except for checking if one's in the root that one returns True even though there isnt one there. In this setup, the Test3/Sub/Auto timeline was created before Test2/Auto, so a call to Dialogic.start('Auto') ends up creating the subfolder timeline since its the first one found in creation order:

if you were to call Dialogic.start('Test2/Auto'), it will call the proper timeline. also trying to call Dialogic.start('Test1/Auto') will give the  "No Timeline Speicified" error as expected, since that one doesn't exist.

Using the full path is the recommended way of doing it. Using just the timeline name (which doesn't always work as you pointed out) was only kept in to not break compatibility to older projects.

yeah I agree, and it seems just fine on that account other than trying to address any timelines in the root folder


Marion ignores the storage backend and always tries saving documents to the file system

Bug Report
Expected behavior/code
Documents should be persisted via the storage backend configured in the Django project running Marion.
Actual Behavior
We write files directly to the file system regardless of the storage backend:
https://github.com/openfun/marion/blob/5428dcac6306e9be1dba9d700109f3666debd60c/src/marion/marion/issuers/base.py#L367
Steps to Reproduce

Install Marion in a project where DEFAULT_FILE_STORAGE = 'storages.backends.s3boto3.S3Boto3Storage' configured to connect to an S3 bucket,
Create a persisted document,
Notice that it wasn't created in the bucket but on the file system

Environment

Marion version: v0.3.2
Platform: Docker

Possible Solution
Get the generated file and save it using the active storage backend.

In fact you can deal with persistence in your issuer, but you are right: we should default to the configured storage backend.


Support Subscription Preview Change

Supporting preview change. Finishing up this abandoned PR: https://github.com/recurly/recurly-client-net/pull/72
Example use:
var sub = Subscriptions.Get("31f0e253f90804f5a0db4b4a82a0ff62");
sub.UnitAmountInCents = 5000;

// PreviewChange returns a new Subscription object
var subPreview = sub.PreviewChange();
Console.WriteLine(subPreview.UnitAmountInCents);

+1 ✨


Margin/Padding String shorthand

This allows for the use of a syntax like margin="20 15 10" as suggested by #12, while also maintaining compatibility with margin={20} and also margin={[20.15]}.

@c-moss-talk and @eightyfive Let me know what you think


Improve gradient docs

Description

there are 2 problems:

the stops arg doesnt have a name in the signature. It takes some time for me to figure out
the stops accept array but the discription of format is missing. Proving more examples should be better.

ctx: I'm trying to do this: https://typst.app/project/r0ylIFbUVdjsbK8498-qVT

#let grad = gradient.linear((black, 0%),(black, 50%),(white, 50%),(white, 75%), (black, 75%),(black, 100%), dir: ttb)
#rect(fill: grad, width: 100%, height: 4pt)

Reproduction URL
No response
Operating system
Web app, Windows, Linux, macOS
Typst version

[X] I am using the latest version of Typst

I think that's more of an overall improvement to the docs for variadic arguments 🤔

It's not specific to variadics either. That's just how positional arguments are displayed in the docs because that's also how they work in code.

Hi, I'd like to try to contribute to this project. This seems easy enough to start but I don't see how you guys are generating the docs in order to see the results of the changes I make. Could anybody help me here?

Sadly, it's only partly open-source at the moment because it's still entangled with our web site. We plan to change that as soon as HTML export is ready enough.

To replicate the docs look, you need to set
#set page(width: 240pt, height: auto, margin: 15pt)

That doesn't answer my question. But I've figured part of it out. I've found that the typst-docs directory contains the project that generates the documentation. Or at least a JSON file and a bunch of images. I'm missing how to turn that into a webpage.

I'm missing how to turn that into a webpage.

Sadly, it's only partly open-source at the moment because it's still entangled with our web site. We plan to change that as soon as HTML export is ready enough.

Is it possible then, for a person without access to the HTML export to test these changes to the documentation?

You can test whether they compile by running the typst-docs unit tests, but you can't look at them currently. (Note that it's not about access to any kind of Typst HTML export. There is no secret HTML export. The current docs are just rendered from the JSON with our web framework.)

I ran across this issue as well trying to specify a gradient. The type signature in the documentation isn't strong enough to fully specify what stops should be, and unfortunately there's no usage example or link to the typst library code


Run before a user profile is configured?

What does this mean and how is it accomplished?

Basically a lot of the changes the debloater makes won't fully effect or properly take hold on an existing account, so you need to a do a little back and forth for a truly clean experience. This is my method:

Fresh install of Windows
First user account created during install should be generic (like "admin")
Run debloater
Create new user account you'll actually be using (like "dave")
Use "admin" to change "dave" to administrator
Use "dave" to delete "admin"

lol at that last one, i use linux, but proton isnt refined enough and i cant play games outside of steam

I spent far too long configuring power management on my T580 only to get 2-3 hours of battery life at best, Windows gets 10+ easily so I run Linux on my desktops/servers and Windows on my laptops.

Is it possible to omit running the script again for news users, if they script was ran on a clean profile, then made into the default user profile?

You shouldn't need to run the script again for new profiles after running on a default profile @mtmartis


Add auto-use and auto-lock features to Keyring mod.

Features to automatically use rather than just select key items. Upon further review, I don't think this functionality is 100% safe, and it may be best to leave it in the branch for curious enthusiasts rather than risk pain to general users.

Upon further review, I don't think this functionality is 100% safe, and it may be best to leave it in the branch for curious enthusiasts rather than risk pain to general users.


Update WTS workflow

add qualimap tool
add WTS-QC workflow (in case we need to update QC data/samples)
update dragen-transcriptome workflow
update configs

Tested and validated in wfr.4f7ddd2760e541ffaa09014f7e991a48

To ensure correct merging of configuration files and sync is correct - waiting on merge of PR #110 and then merging main into this branch


Memory leak in iOS WebView communication

I'm investigating using a WebView for a long-lived worker process. However, I've noticed that the message passing via injectJavaScript/window.ReactNativeWebView.postMessage seems to leak memory.
I've created a simple repro at https://github.com/hypergeometric/WebViewLeak with the following App code.
export default class App extends Component {
  state = { messageCount: 0 };

  render() {
    const html = `
      <html>
      <head></head>
      <body>
        <script>
          const message = "Hello!".repeat(1000000);
          setInterval(function () {
            window.ReactNativeWebView.postMessage(message);
          }, 1000);
        </script>
      </body>
      </html>
    `;

    return (
      <View style={{ flex: 1, justifyContent: 'center', alignItems: 'center' }}>
        <View style={{ height: 0 }}>
          <WebView
            originWhitelist={['*']}
            source={{ html }}
            onMessage={() => {
              this.setState(state => ({
                messageCount: state.messageCount + 1
              }));
            }}
          />
        </View>
        <Text style={{ fontSize: 20 }}>{this.state.messageCount}</Text>
      </View>
    );
  }
}

I'm sending ~6MB using postMessage every second but this seems to allocate memory that is never released, even after applying memory pressure in the simulator (the same happens on a physical device). The size of the message doesn't seem to matter in my testing, it just obviously affects the speed of memory consumption.
Profiler at startup:

Profiler at 30s:

Profiler at 60s:

This also happens with injectJavaScript and both UIWebView and WKWebView.
I've found this report which I think is the same problem and points to an iOS issue. This obviously means I can't use a WebView as a long lived process if every message consumes memory.
Does anyone with more experience than me know if there could be a bug in my usage or with react-native-webview that could be causing this or if we're at the mercy of an iOS bug?

This is very worrying. Have you tried profiling with chrome?

If the leak is on the native side you need xcode to debug this ofc

Hey guys, look at this:
If you change
const message = "Hello!".repeat(1000000);
to
var message = "Hello!".repeat(1000000);
And then after
window.ReactNativeWebView.postMessage(message);
you add
message = undefined;
There is no leak anymore.
So, must be something related to const vars management.

Yep that absolutely works! Fascinating.
Thanks so much for figuring this out!

@prcode
Why we not code like this ?
window.ReactNativeWebView.postMessage("Hello!".repeat(1000000));


Added command/response logging support to EventNotificationMessage.

New Features

Added new EventType enums to capture commands and responses
Display commands and responses on the p1_display events table
Added IsCommand() and IsResponse() helper functions
Added return_in_order option to DataLoader.read() to return a single list of all message types in the order they were recorded
Added return_bytes option to DataLoader.read() to return the original binary header+payload for each message

Changes

Made to_string() functions constexpr where possible (requires C++14; functions set as inline for C++11)

Example event table output:


Multiple instances of SignaturePad causes UWP crash

When a UWP application instantiates an instance of the SignaturePad and the frame is navigated away from, it appears that the underlying InkCanvas is never disposed, even when the containing page no longer exists and nothing else apparently holds a reference to a SignaturePad.
A memory profile using dotMem shows an instance for each visit to a frame containing a SignaturePad still residing in memory but it doesn't seem to think it is a leak (that they could be garbage collected). Explicitly calling garbage collection (GC.Collect()) does not work around it.
To help show the issue, I created a simple 2-page app at:
https://github.com/jneno/SignaturePadLeakDemo
When Page 2 is navigated to, it creates a SignaturePad instance (page caching is left at the default disabled configuration). If you navigate back and forth between Pages one and two 128 times, the app crashes with this out of memory error:
System.OutOfMemoryException: 'Insufficient memory to continue the execution of the program.

I am happy to say that this bug has been fixed! The UWP UI has been totally rewritten and now even supports templating. This means that the objects are no longer managed manually.

Probably somewhere in here the world changed for a little SignaturePad control: d77cdf787175179212856074e71e7a5dcc050062


ENH: Add --fs-subjects-dir flag

Changes proposed in this pull request
Follow-up to poldracklab/smriprep#27.
Doc updates pending.
Closes #1900.
Closes #1573.
Documentation that should be reviewed

@oesteban Does your "trick" (linked here) still apply? How do you envision this?

I guess it doesn't apply anymore, having a more explicit option. We could leave that as an alternative for advanced users. However, the examples given across the documentation should be updated with the new option.


python311Packages.dnfile: 0.13.0 -> 0.14.1

Diff: https://github.com/malwarefrank/dnfile/compare/refs/tags/v0.13.0...v0.14.1
Changelog: https://github.com/malwarefrank/dnfile/blob/v0.14.1/HISTORY.rst
Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 255612 run on x86_64-linux 1

16 packages built:

python310Packages.dnfile
python310Packages.dnfile.dist
python310Packages.karton-autoit-ripper
python310Packages.karton-autoit-ripper.dist
python310Packages.karton-config-extractor
python310Packages.karton-config-extractor.dist
python310Packages.malduck
python310Packages.malduck.dist
python311Packages.dnfile
python311Packages.dnfile.dist
python311Packages.karton-autoit-ripper
python311Packages.karton-autoit-ripper.dist
python311Packages.karton-config-extractor
python311Packages.karton-config-extractor.dist
python311Packages.malduck
python311Packages.malduck.dist


yeet alloy_uuid from knock_people table

Once again... should be the last column update today 🤞. Sibling PR here

Since I got @kh3dron's sign-off, i'm  bypassing merge requirements to get this taken care of.


loggerd: switch to v4l encoder

Not ready yet. Advantages:

simpler code, remove closed source dep
input is VisionBuf, no need for a copy
reduced latency, OMX polls! (slowly)
same underlying kernel API as OMX

Hmm, seems to use 70 mW more. My guess is because the qcamera is making the big copy now :)
comma@tici:/data/openpilot/selfdrive$ hardware/tici/precise_power_measure.py
measuring for 5 seconds at 123hz 3 times
mean 6171.17 std 433.52
mean 6169.16 std 423.70
mean 6171.89 std 468.98
comma@tici:/data/openpilot/selfdrive$ hardware/tici/precise_power_measure.py
measuring for 5 seconds at 123hz 3 times
mean 6237.49 std 437.15
mean 6247.45 std 409.67
mean 6243.15 std 397.05

I expect tests to pass now. This is a net loss of 200 lines and should be functionally identical to the OMX version. I'll do the OMX deletion in another PR, but after review and checking that the files are fine I'm okay with merging this.

These tests are so good, found a minor bug in the h264 output size. Fingers crossed it passes now.

TESTS PASS!
@adeebshihadeh @pd0wm I'm ready to merge into master, any thoughts?

Last test failure seems like noise in modeld power draw...

It doesn't run on PC, there's no encoder hardware. But RawLogger still works.

I would like to merge this very soon, as it's a prereq for:

encoderd
NV12


SIGSEGV Error in fresh Conda and Basic Code

My Code:
from pyrosm import OSM
from pyrosm import get_data

fs = get_data('muenchen')
print(fs)
osm = OSM(fs)
print(osm)
natural = osm.get_natural()
print(natural)

The output:

/home/leo/miniconda3/envs/pyrosm/lib/python3.7/site-packages/geopandas/_compat.py:115: UserWarning: The Shapely GEOS version (3.9.1-CAPI-1.14.2) is incompatible with the GEOS version PyGEOS was compiled with (3.10.1-CAPI-1.16.0). Conversions between both will be slow.
  shapely_geos_version, geos_capi_version_string
/tmp/pyrosm/Muenchen.osm.pbf
<pyrosm.pyrosm.OSM object at 0x7f5df1d0c1d0>

Process finished with exit code 139 (interrupted by signal 11: SIGSEGV)

@leohoy : Could you please provide more information about your system/setup? With this information it is not possible to say what might be causing this error. Sigsegv error can arise from various reasons..

What OS are you using?
What packages (and versions) do you have in your environment?
Is geopandas working normally otherwise?

Ah Geopandas is not working indeed. Error message:
/home/leo/miniconda3/envs/pyrosm/lib/python3.7/site-packages/geopandas/_compat.py:115: UserWarning: The Shapely GEOS version (3.9.1-CAPI-1.14.2) is incompatible with the GEOS version PyGEOS was compiled with (3.10.1-CAPI-1.16.0). Conversions between both will be slow.
  shapely_geos_version, geos_capi_version_string
Traceback (most recent call last):
  File "fiona/_shim.pyx", line 83, in fiona._shim.gdal_open_vector
  File "fiona/_err.pyx", line 291, in fiona._err.exc_wrap_pointer
fiona._err.CPLE_OpenFailedError: Failed to read GeoJSON data

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/home/leo/Leo/Arbeit/ImmoAPI/Python/PrepareData.py", line 5, in <module>
    gp.read_file('/home/leo/Leo/Arbeit/ImmoAPI/test.geojson')
  File "/home/leo/miniconda3/envs/pyrosm/lib/python3.7/site-packages/geopandas/io/file.py", line 201, in _read_file
    with reader(path_or_bytes, **kwargs) as features:
  File "/home/leo/miniconda3/envs/pyrosm/lib/python3.7/site-packages/fiona/env.py", line 408, in wrapper
    return f(*args, **kwargs)
  File "/home/leo/miniconda3/envs/pyrosm/lib/python3.7/site-packages/fiona/__init__.py", line 257, in open
    layer=layer, enabled_drivers=enabled_drivers, **kwargs)
  File "/home/leo/miniconda3/envs/pyrosm/lib/python3.7/site-packages/fiona/collection.py", line 162, in __init__
    self.session.start(self, **kwargs)
  File "fiona/ogrext.pyx", line 540, in fiona.ogrext.Session.start
  File "fiona/_shim.pyx", line 90, in fiona._shim.gdal_open_vector
fiona.errors.DriverError: Failed to read GeoJSON data

I use Ubuntu Ubuntu 20.04.3 LTS
I installed pyrosm as the first package in a fresh Conda environment with Python 3.7 with conda install -c conda-forge pyrosm . I did not install any other packages.
Package            Version
------------------ ---------
attrs              21.2.0
certifi            2021.10.8
click              8.0.3
click-plugins      1.1.1
cligj              0.7.2
cykhash            2.0.0
Cython             0.29.25
Fiona              1.8.20
geopandas          0.10.2
importlib-metadata 4.8.2
Jinja2             3.0.3
MarkupSafe         2.0.1
munch              2.5.0
numpy              1.21.4
pandas             1.3.4
pip                21.2.2
pygeos             0.12.0
pyproj             3.2.1
pyrobuf            0.9.3
pyrosm             0.6.1
python-dateutil    2.8.2
python-rapidjson   1.5
pytz               2021.3
setuptools         58.0.4
Shapely            1.8.0
six                1.16.0
typing_extensions  4.0.1
wheel              0.37.0
zipp               3.6.0

Yes, i am running this on my own computer

So i got to run geopandas, but still I get the same SIGSEV error, when running the script..

Solved it by reinstalling header files and static libraries: sudo apt-get install python3-dev

@leohoy: Okay, great so I assume everything is working now? I'll close this now, but in case you have issues still, feel free to re-open.


add support for flagr

have you considered adding support for flagr here?

Hey @dagadbm  👋  I hadn't even heard of it before. Working on a PR now.

This issue is resolve by https://github.com/andrewdmaclean/awesome-feature-flag-management/pull/6


Issue occured while building the salesforce unlock package - error code:<PHONE_NUMBER>-694 (-852365351)

Summary
We were building the salesforce unlock package through salesforce sfpowerscript command and are getting below error.
Expected result
Package should be built.
Actual result
Package is failing with below error.
System Information
Package Creation Failed for gdpr-core
Source converted successfully to /builds/hcl-da/salesforce/master-repository/.sfpowerscripts/dxElp_source/.sfpowerscripts/BSbTa_mdapi
command: create  package
package name: gdpr-core
package type: unlocked
package directory: src/compliance/gdpr-core
Fetching Package Type Info from DevHub
Package gdpr-core
IsOrgDependent No
Package Id 0Ho090000004CdKCAU
Package creation for gdpr-core Initiated
Status: Initializing, Next Status check in 30 seconds
Status: VerifyingFeaturesAndSettings, Next Status check in 30 seconds
Status: VerifyingFeaturesAndSettings, Next Status check in 30 seconds
Status: VerifyingDependencies, Next Status check in 30 seconds
Status: VerifyingDependencies, Next Status check in 30 seconds
Status: VerifyingDependencies, Next Status check in 30 seconds
Status: VerifyingDependencies, Next Status check in 30 seconds
Status: VerifyingDependencies, Next Status check in 30 seconds
Status: VerifyingDependencies, Next Status check in 30 seconds
Status: VerifyingDependencies, Next Status check in 30 seconds
Status: VerifyingDependencies, Next Status check in 30 seconds
Status: VerifyingDependencies, Next Status check in 30 seconds
Status: VerifyingDependencies, Next Status check in 30 seconds
Status: VerifyingDependencies, Next Status check in 30 seconds
Status: VerifyingDependencies, Next Status check in 30 seconds
Status: VerifyingDependencies, Next Status check in 30 seconds
Status: VerifyingDependencies, Next Status check in 30 seconds
Status: VerifyingDependencies, Next Status check in 30 seconds
Status: VerifyingDependencies, Next Status check in 30 seconds
Status: VerifyingDependencies, Next Status check in 30 seconds
Status: VerifyingDependencies, Next Status check in 30 seconds
Status: VerifyingDependencies, Next Status check in 30 seconds
Status: VerifyingDependencies, Next Status check in 30 seconds
Status: VerifyingDependencies, Next Status check in 30 seconds
Status: VerifyingDependencies, Next Status check in 30 seconds
Status: VerifyingDependencies, Next Status check in 30 seconds
Status: VerifyingDependencies, Next Status check in 30 seconds
Status: VerifyingDependencies, Next Status check in 30 seconds
Status: VerifyingDependencies, Next Status check in 30 seconds
Status: VerifyingDependencies, Next Status check in 30 seconds
Status: VerifyingDependencies, Next Status check in 30 seconds
Status: VerifyingDependencies, Next Status check in 30 seconds
Status: VerifyingDependencies, Next Status check in 30 seconds
Status: VerifyingDependencies, Next Status check in 30 seconds
Status: VerifyingDependencies, Next Status check in 30 seconds
Status: VerifyingDependencies, Next Status check in 30 seconds
Status: VerifyingDependencies, Next Status check in 30 seconds
Status: VerifyingDependencies, Next Status check in 30 seconds
Status: VerifyingDependencies, Next Status check in 30 seconds
Status: VerifyingDependencies, Next Status check in 30 seconds
Status: VerifyingDependencies, Next Status check in 30 seconds
Status: VerifyingDependencies, Next Status check in 30 seconds
Status: VerifyingDependencies, Next Status check in 30 seconds
Status: VerifyingDependencies, Next Status check in 30 seconds
Status: VerifyingDependencies, Next Status check in 30 seconds
Status: VerifyingDependencies, Next Status check in 30 seconds
Status: VerifyingDependencies, Next Status check in 30 seconds
Status: VerifyingDependencies, Next Status check in 30 seconds
Status: VerifyingDependencies, Next Status check in 30 seconds
Status: VerifyingDependencies, Next Status check in 30 seconds
Status: VerifyingDependencies, Next Status check in 30 seconds
Status: VerifyingDependencies, Next Status check in 30 seconds
Status: VerifyingDependencies, Next Status check in 30 seconds
Status: VerifyingDependencies, Next Status check in 30 seconds
Status: VerifyingDependencies, Next Status check in 30 seconds
Status: VerifyingDependencies, Next Status check in 30 seconds
Status: VerifyingDependencies, Next Status check in 30 seconds
Status: VerifyingDependencies, Next Status check in 30 seconds
Status: VerifyingDependencies, Next Status check in 30 seconds
Status: VerifyingDependencies, Next Status check in 30 seconds
Status: VerifyingDependencies, Next Status check in 30 seconds
Status: VerifyingDependencies, Next Status check in 30 seconds
Status: VerifyingDependencies, Next Status check in 30 seconds
Status: VerifyingDependencies, Next Status check in 30 seconds
Status: VerifyingDependencies, Next Status check in 30 seconds
Status: VerifyingDependencies, Next Status check in 30 seconds
Status: Error, Next Status check in 30 seconds
Unable to create gdpr-core due to
Creation errors:

An unexpected error occurred. Please contact Salesforce Support and provide the following error code:<PHONE_NUMBER>-694 (-852365351)
Removed all childs of gdpr-core from queue

This server side error:<PHONE_NUMBER>-694 (-852365351) has details of: ZipException: only DEFLATED entries can have EXT descriptor so I would suspect something wrong with the zipped metadata being packaged.  Please re-open if you're continuing to have problems.


Automated backport of #3073: Fix testGatewayPodRestartScenario for ROKS platform

Backport of #3073 on release-0.18.
#3073: Fix testGatewayPodRestartScenario for ROKS platform
For details on the backport process, see the backport requests page.

@tpantelis
I need to make smal correction to the backport.
In the devel branch, the following PR was applied and merged - https://github.com/submariner-io/submariner/pull/3069
It removed the following line. alongside with other piece of code:
submEndpoint := f.AwaitSubmarinerEndpoint(primaryCluster, subFramework.NoopCheckEndpoint)
In release-0.18 branch, this was not applied and the line above exists.
Now, in order to avoid line duplication, I'm going to remove that duplicate line.
Will update the backport patch.

@tpantelis
I've updated the PR.
The line I've removed, already appears in line number 82.


Use the HTML5 history API for cleaner URLs.

This pull request exchanges hash-based urls (http://localhost:8000/#/home) for regular urls.

Coverage remained the same at 88.7% when pulling c6b165de601ff630b175ab3dcc3ffd87a6770179 on paulyoung:clean-urls into 95df1fdfbf62a588cf238eb2ccefa8f36b50d8e0 on pheuter:master.

:+1:


Pin Zarr to <3

Zarr's updates for v3 have some new dependencies and have shuffled around some functionality that Xpublish uses, so lets limit the maximum version that Xpublish supports for now.

xref #1777


fix: infinite loop caused by build updating files

fixes: https://github.com/TBD54566975/ftl/issues/1202
Changes:

file watch service now allows transactions that pause file update logic on modules, and allows specific file changes to be explicitly allowed (ie does not count as an update that triggers another build)
building a go module uses a transaction to handle go mod tidy commands

@wesbillman I was not able to repro the original issue on main. Not sure if that's due to other changes? Or just that you have to be unlucky with timing to get the watch service to check at the same time as go.mod is in an interim state...

@wesbillman I was not able to repro the original issue on main. Not sure if that's due to other changes? Or just that you have to be unlucky with timing to get the watch service to check at the same time as go.mod is in an interim state...

@wesbillman I was not able to repro the original issue on main. Not sure if that's due to other changes? Or just that you have to be unlucky with timing to get the watch service to check at the same time as go.mod is in an interim state...

Yeah it's been super hard to repro. When it happens it seems to loop over and over for a while, but getting it to start looping is super random afaict.
One thing that I recall triggered this more frequently was when I pulled down the other customer repo changes and ftl dev . (or just dev) the first time. It seemed to get into the loop and then stopping and restarting fixed it. Which might be related to updating the ftl version perhaps triggering the change more frequently. So it might be worth trying. Clone that other repo, do a hermit upgrade ftl then just dev and see if it happens. Maybe that will provide some clues.

thanks @wesbillman. I gave up hoping for (un)lucky timing. I did the following instead:
For this issue to be reproduced, the watcher needs to do a scan for file changes between when the build system adds ftl to the go.mod's requirements and when it takes it away in go mod tidy. That's really hard, so the way to force reproduce this, add time.Sleep(3 * time.Second) in go-runtime/compile/build.go:92 which will make sure we hit the bad case.
Can confirm that it allows us to repro the issue with the time module, and this PR fixes it.


[DCOS-49103][SDK Utils] Nightly CI fixes, read SECURITY env var as fallback.

Read environment variable if call to GET dcos-metadata/bootstrap-config.json fails.

Merging this PR to resolve nightly CI failures on DC/OS Open.


[v2]  Can't display complete images

Describe the Bug
When I get dicom images through wadouri in my interface, it has a problem with incomplete display, but the console does not report an error, as shown below.

when i change windowlevel, the image will show a part of complete image

Steps to Reproduce

set my configuration

window.config = {
  routerBasename: '/',
  extensions: [],
  showStudyList: true,
  filterQueryParam: false,
  disableServersCache: false,
  studyPrefetcher: {
    enabled: true,
    order: 'closest',
    displaySetCount: 3,
    preventCache: false,
    prefetchDisplaySetsTimeout: 300,
    maxNumPrefetchRequests: 100,
    displayProgress: true,
    includeActiveDisplaySet: true,
  },
  servers: {
    dicomWeb: [
      {
        name: 'DCM4CHEE',
        wadoUriRoot: 'http://localhost:8010/dataset',
        qidoRoot: 'http://localhost:8010/dataset',
        wadoRoot: 'http://localhost:8010/dataset',
        qidoSupportsIncludeField: false,
        imageRendering: 'wadouri',
        thumbnailRendering: 'wadouri',
        enableStudyLazyLoad: true,
        supportsFuzzyMatching: true,
      },
    ],
  },
}

get images from interface

The current behavior
The viewer shows a part of dicom image.
The expected behavior
The viewer shows complete image.
The viewer can show complete images when I download  them from interface and then upload them locally, as shown below

OS
MacOS 13.1
Node version
14.21
Browser
Chrome 113.0.5672.92

Please review the latest code in the master branch. I am confident that this issue has been resolved. If it persists, kindly reopen the issue with updated details.
Try viewer-dev.ohif.org instead of viewer.ohif.org
Our viewer.ohif.org is deployed from release branch while viewer-dev.ohif.org is our master  branch
Read more about branch explanations here https://docs.ohif.org/development/getting-started#developing


(MODULES-7854) Stub out default values for puppet6

Puppet6 modified basemodulepath so it's default value depends on the
env_windows_installdir fact. It also added a new setting,
vendormoduledir, that does the same. This commit stubs out the default
values for these settings as is done with modulepath. This behavior only
occurs when testing against Puppet6, so it's shouldn't affect older
puppet versions which don't define the vendormoduledir setting or use a
fact to determine the default basemodulepath.
See also PUP-8582.

DO NOT MERGE, still testing

Coverage decreased (-0.02%) to 91.474% when pulling c18ecbf292ac0ed567e6061a5133cfd22c147b3f on joshcooper:puppet6-support-modules-7854 into 7a49bef36884da50d399cdf74aff59e2e8f37389 on rodjek:master.

It looks like rspec-pupppet#master fails against puppet#master unrelated to this PR. I filed it as https://tickets.puppetlabs.com/browse/MODULES-7855.

Still need to address the issue where Puppet:Util.path_to_uri gets called and rspec-puppet's monkey patching leaves puppet in an inconsistent state. I created a foo module and class using pdk
require 'spec_helper'

describe 'foo' do
  on_supported_os.each do |os, os_facts|
    context "on #{os}" do
      let(:facts) { os_facts }

      it { is_expected.to compile }
    end
  end
end

When I run the following the windows? and microsoft_windows? don't match, causing path_to_uri to fail with a path of the form C:/foo/.../component.rb, because the code for prepending a leading slash to the windows path is skipped.
C:\foo>bundle exec rspec spec
...
foo
  on centos-7-x86_64
** ALT_SEPARATOR
** Puppet::Util::Platform.windows? true
** Puppet.features.microsoft_windows? true
** ALT_SEPARATOR \
** Puppet::Util::Platform.windows? false
** Puppet.features.microsoft_windows? true
    should compile into a catalogue without dependency cycles (FAILED - 1)

The first time path_to_uri is called, everything is consistent. But then it's called again seemingly after we're switched back to Windows.

Hey @joshcooper / @rodjek - do you guys have a rough idea on timeline for this fix?

@davidmalloncares never closer, hopefully very soon.

Travis passed, but shows as pending... not sure what's up there. Looks good to me @rodjek

Super close! Just poking the timed out tests (it happens sometimes) so that we can have a nice green merge. Thanks for the help @joshcooper!


A lot of classes changed in 2.0

I've just downloaded the 2.0 version and while I was aware that i  may had to do some adjustmente I found very boring that some classes changed their name apparently without reason.
For example .container-fluid became .fluid-container, topbar to navbar...

That maybe before the final release these name may be changed to the old name

what about a document for migration from 1.4 to 2.0?

You can't see that .fluid-container makes more sense than .container-fluid?

I like the new class names and simplified structure, they make more sense.
@4vanger's suggestion of a migration document is great, though.

@paglias They aren't going to revert all their work.

At this point of the development the best solution is the one proposed from 4vanger, I think

We have an ongoing upgrade document available at /docs/upgrading.html. You can see it on our demo at http://markdotto.com/bs2/docs/upgrading.html. We're still actively overhauling things, so do expect some lag and variation in that document for now.


Update EGU1 and IPC interrupts example in readme.md

with the removal of the old interrupt binding method in embassy, update the example to use the cortex-m-rt method.

Oh hey, thanks for the PR! Yeah I forgot to update this.


Re-training SSD-model

@dusty-nv Hi, Thanks for your great job firstly.
I have a question that need your help. I want to do some changes on the bounding box, what should I do?
Where I can find the code to change?

Hi @huansu, do you mean modifying the bounding boxes during training, or during inference.
As @themannoshoes pointed out, the inferencing code is in jetson-inference/c/detectNet.cu
During training, I think it depends on which type of dataset you are using.  For example, if using Pascal VOC type dataset, the code that parses the bounding boxes is found here:  https://github.com/dusty-nv/pytorch-ssd/blob/e7b5af50a157c50d3bab8f55089ce57c2c812f37/vision/datasets/voc_dataset.py#L139

@dusty-nv Thanks for your reply.I want to modify the bounding boxes  during inference. I will have a shot at it.
@themannoshoes Thank you.

@dusty-nv thanks, but I want to use python to run during inference, what should I do? Where I could find the *.py to run as <detectnet --model=$NET/ssd mobilenet.onnx --labels=$NET/labels.txt --input-blob=input_0 --output-cvg=scores --output-bbox=boxes csi://0>. Where should I change the code with bbox during inference?

You should just be able to edit the members of the detectNet.Detection objects.  See this page:
https://rawgit.com/dusty-nv/jetson-inference/dev/docs/html/python/jetson.inference.html#detectNet
Scroll down for the jetson.inference.detectNet.Detection members


added Before hook to make Url https if forwarded header present

Added optional before hook to make url scheme https if forwarded header present
Usage : SSLProxy. MakeNancyUrlSecure(pipelines)
Addresses #1679

LGTM :shipit:

I'm not sure I can come up with a better name, but MakeNancyUrlSecure sounds a bit weird considering what the method is doing IMO.

Yeah I had Enable before but that wasn't right either :(
On 16 February 2015 at 10:00, Kristian Hellang<EMAIL_ADDRESS>wrote:

I'm not sure I can come up with a better name, but MakeNancyUrlSecure
sounds a bit weird considering what the method is doing IMO.
--
Reply to this email directly or view it on GitHub
https://github.com/NancyFx/Nancy/pull/1815#issuecomment-74484000.

:boom: I added the "Update Documentation" label, @jchannon: want to update the wiki?


Proposal: Add a new Series/Sesson/Episode indexer.

Proposal
I want Jellyfin's "series" to be used to group together Shoko's series (all kinds, e.g. series, web and movies) in something along the lines of Shoko's "groups", where Jellyfin's "sessions" are used to order the items in the group. The "session"'s details will be filled from the series in Shoko,  and the "series"'s details will be filled from the the staring point (not necessary the first "session") of the "group". The starting point will be considered the first release in the group (e.g Fate/Stay Night for the fate series)
All misc. (other and parody), trailers and credits will be grouped at "session" index 97, 98 and 99 respectively, specials will be grouped after the episodes from the series they are in, but in a separate "session" ending with " Specials" (or localized equivalent), and the rest of the episodes will be ordered in one of the following ways:

By chronological order - meaning the first "session" may have been released later then the second "session", and so on. The story is followed from the first prequel to the last sequel.

By release date - meaning the order of which they were released. Some series expand the backstory of the original by releasing a prequel at a later time. The story may jump a bit, if you watch in this order, but sometimes that may be preferred.

Conflicts

All Shoko series will be stored under the same "group", so finding a series will be more difficult if you don't know the "group" it belongs to, and individual series will not be searchable.

Currently undefined behavior when a group of series contain alternate versions with the same prequel/sequel or both. Help needed!

Goal
So if this proposal goes though, we will have three ways to index our library:

A one-to-one relation between Jellyfin Series and Movies and Shoko Series.

A one-to-many relation between Jellyfin Series and Shoko Series.

Whatever TvDB decides. (Because I don't know).

Implementation To-Do

[ ] Add a new API call to get all related sequels and prequels for a series. Either prepossessed, or we can to process it client-side.

This will be used to set the session order.

[ ] Modify Shokofin.Providers.SeriesProvider to calculate and generate the structure beforehand (including the session and episode tree) if the "add missing" option is enabled on a library.

[ ] Expand Shokofin.Providers.SessionProvider to create better sessions.

[ ]  We need to somehow add an episode, preferably with both relative and absolute numbering according to our order type.

Maybe use Shokofin.Providers.EpisodeProvider to optionally recalculate positions on every import if on.

Other solutions? Do tell!

[ ] Implement a new SeriesMetadataService and MissingEpisodeProvider, since the default relays heavily on TvDB ids being present, and creates sessions in a TvDB fasion, and there are no way to only implement the later (since it is a one-off class and not an interface), but for Shoko.
https://github.com/jellyfin/jellyfin/blob/f50348ca0b03a7928e58eb3b188532b98d6f46fa/MediaBrowser.Providers/TV/SeriesMetadataService.cs#L19
https://github.com/jellyfin/jellyfin/blob/384ab39f5b3dfb940cb9f612f5b64541c9ec935b/MediaBrowser.Providers/TV/MissingEpisodeProvider.cs#L22

When you mention session do you mean season?

When you mention session do you mean season? I think we can have arbitrary season names in Jellyfin, so no need for numbers 97, 98, 99 or something like that.

@EraYaN Yes, I meant season. And no I did not mean the name, but the season index number.

I suppose in that case the numbers are purely used for ordering and can be arbitrary (I would use some spacing between all of them for future use).

I think the season numbers should not matter here, and be recalculated if the users changes the ordering method or if a new entry appears (i.e. in-between existing entries, or at the beginning).

One should definitely use season numbers that plugins like the Trakt one and so on will ignore (so either very high or something like 0 for specials)

Well, most of the features i wanted here is implemented in #14, so I'm closing this for now.

The chronological ordering will be added at a later date.

Regarding season naming...
https://github.com/jellyfin/jellyfin/issues/2187
Jellyfin supports custom paths now that go beyond Show / Season 1, 2, .... & Specials.
One could use the following logic:
Anime / Franchise name (as in the Shoko Group) / Season's show name (either romaji-JP or En or whatever we prefer) <instead of Season 1, 2 , ...>
Also refer to: https://github.com/jellyfin/jellyfin/issues/2446
You can even put specials within the season now. So no more specials per show (JF), but per season! (if I understood everything correctly!)
Thoughts?


Fix review duration dropdown (RR scheduled track)

 Fix potential issue with the review duration dropdown for scheduled track in some corner-cases


Bomb additive support

In GitLab by @sirrus233 on May 23, 2022, 22:34
Noticed today that the Burn It! Feat now adds damage to relevant rolls! Great news! Unfortunately I also noticed a bug.
For alchemical bombs, the feat should apply a damage bonus equal to 1/4 the item's level (rounded down, minimum 1). This generally seems to work correctly, but does not take into account bombs with additives (such as Debilitating Bomb) which change the item's level.
As an example, a Greater Alchemist's Fire (a level 11 item), thrown by a character with Burn It! should do an extra +2 damage. The same bomb thrown with a Smoke Bomb additive is now a level 12 item, and should do an extra +3 damage.

Reframing as a request to actually support bomb additives


fix: Restore original Action::is_enabled condition during replays w…

…here the result is always true

Closing because actually this breaks replay.


[SPARK-12869] Implemented an improved version of the toIndexedRowMatrix

Hi guys,
I've implemented an improved version of the toIndexedRowMatrix function on the BlockMatrix. I needed this for a project, but would like to share it with the rest of the community. In the case of dense matrices, it can increase performance up to 19 times:
https://github.com/Fokko/BlockMatrixToIndexedRowMatrix
If there are any questions or suggestions, please let me know. Keep up the good work! Cheers.

Can one of the admins verify this patch?

cc @mengxr

ok to test

ok to test

Test build #52080 has started for PR 10839 at commit 4d7c297.

Test build #52080 has finished for PR 10839 at commit 4d7c297.

This patch fails Scala style tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/52080/
Test FAILed.

Test build #53036 has started for PR 10839 at commit 67fd902.

Test build #53036 has finished for PR 10839 at commit 67fd902.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/53036/
Test PASSed.

Test build #53238 has started for PR 10839 at commit ba7791f.

I've improved the PR based on the feedback. Beside that I've also updated the benchmark:
https://github.com/Fokko/BlockMatrixToIndexedRowMatrix
If there are any questions, please let me know.

Test build #53239 has started for PR 10839 at commit a9bc894.

Test build #53239 has finished for PR 10839 at commit a9bc894.

This patch fails to build.
This patch does not merge cleanly.
This patch adds no public classes.

Build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/53239/
Test FAILed.

ok to test

Test build #53240 has started for PR 10839 at commit fe1842e.

Test build #53238 has finished for PR 10839 at commit ba7791f.

This patch passes all tests.
This patch does not merge cleanly.
This patch adds no public classes.

Build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/53238/
Test PASSed.

Test build #53240 has finished for PR 10839 at commit fe1842e.

This patch passes all tests.
This patch does not merge cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/53240/
Test PASSed.

Build finished. Test PASSed.

@Fokko The implementation doesn't take care of sparsity yet. I created https://github.com/apache/spark/pull/11757 to add row/column iterators to local matrices. After that one gets merged, you can simply the implementation here.

Nice work, as soon as the PR will be merged I will update the code accordingly.

@Fokko That PR was merged. Could you merge the current master and update your implementation?  Allocating a dense vector directly could be expensive.

Test build #53401 has started for PR 10839 at commit c043e77.

Test build #53401 has finished for PR 10839 at commit c043e77.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/53401/
Test PASSed.

Merged build finished. Test PASSed.

Test build #53419 has started for PR 10839 at commit d3c780d.

Test build #53419 has finished for PR 10839 at commit d3c780d.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/53419/
Test PASSed.

@mengxr I've updated the code according to your PR :)

Btw, you also need to merge with the current master to resolve conflicts.

Test build #53722 has started for PR 10839 at commit 25c5f66.

Test build #53722 has finished for PR 10839 at commit 25c5f66.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/53722/
Test PASSed.

@mengxr did you had a chance to look at the updated version? I also extended the test to check the conversion to dense/sparse vectors.

Sorry for late response! This LGTM. Merged into master. Thanks!


Run application as non-root user in the container - #10568

Hi @chris48s,
Updated the dockerfile, now the application runs as non-root user or (appuser with appgroup) in the container. Can you please review the changes.
Also, gentle reminder to include "hacktoberfest-accepted" label to this PR, such that it counts under my hacktoberfest contributions. Thank you
closes #10568
Looking forward to contribute more.

I gave this a quick test. There's a fairly obvious problem here, which is that we're running the app as this new appuser here, but then 2 lines down we're changing everything to be owned by root so anything that relies on writing to the filesystem fails with Permission denied. We need to change everything to be owned by appuser:appgroup.
So anyway, I did that. There were also a couple of other more minor changes I wanted to make which were:

using long args for clarity and
using known ids for the gid and uid

so I was then working with
diff --git a/Dockerfile b/Dockerfile
index<PHONE_NUMBER>..87c909a828 100644
--- a/Dockerfile
+++ b/Dockerfile
@@ -29,11 +29,11 @@ LABEL fly.version=$version
 ENV NODE_ENV=production

 # Create and Run the app as non-root user
-RUN addgroup appgroup && adduser -S -G appgroup appuser
+RUN addgroup appgroup --system --gid 1001 && adduser --system --uid 1001 --ingroup appgroup appuser
 USER appuser

 WORKDIR /usr/src/app
-COPY --from=builder --chown=0:0 /usr/src/app /usr/src/app
+COPY --from=builder --chown=appuser:appgroup /usr/src/app /usr/src/app

 CMD ["node", "server"]

That worked fine locally.
The next question I wanted to answer was: Creating a system user sets the user's shell to /sbin/nologin. Does that break our ability to shell into the container with flyctl ssh console? So I tried deploying to fly, and I'm hitting an issue when we deploy the container to fly. The container just fails to boot, but the only error I've got is exit_code=1,oom_killed=false,requested_stop=false. Trail runs cold there.
Thanks for attempting to help with this, but we'll need to work that out and I'm not sure it is something you can easily help with as the remaining issue doesn't reproduce locally. I need to spend some more time on it to work out why we're hitting this issue when we deploy but I think it will have to be something I come back to another day.


ObviousAlexC/penPlus Undefined fix for #1712

!format

Dang it didn't work. Will fix it manually, thanks


Fix 11.4 86 bug

Fixes bug discovered during demo

I know this is already merged, but it seems like the safer fix is to sort CUDA_ARCHES and CODES and document that some are "unofficial" instead of expecting the user to sort them if they want to use these arrays properly


stm32f4 error in adc register size in dtsi files. Missing adc nodes from stm32f405.dtsi

Describe the bug
stm32f4.dtsi incorrectly states that adc1 node starts at 0x40012000 with size 0x400. Although that RM0368 states that adc spans from 0x40012000 to 0x400123FF if we take a closer look at adc register mapping here we can see that we have slots for multiple adcs that are reserved and their size is 0x4d.
To Reproduce
Compare stm32f4.dtsi against this
Compare stm32f405.dtsi against this
Expected behavior
Expected to have adc1 node in stm32f4.dtsi having reg property equal to <0x40012000 0x4d>
Expected to have adc2 and adc3 in stm32f405.dtsi having reg properties equal to  <0x40012100 0x4d>  <0x40012200 0x4d> accordingly.
Impact
Showstopper
Environment (please complete the following information):

Linux
Zephyr SDK
92ecc7866cbe02815f66e4783f044ca7ee22284a

Correct,
Note that in RefMan RM0090 and RM0383 for stm32f411 the ADC1 is mapped from 0x000 - 0x04C in the ADC area (0x4001 2000 - 0x4001 23FF)

Correct,
Note that in RefMan RM0090 and RM0383 for stm32f411 the ADC1 is mapped from 0x000 - 0x04C in the ADC area (0x4001 2000 - 0x4001 23FF)

So I have added the missing nodes. But I cannot add the interrupts because python script complains. Is there any work-around for that?

So I have added the missing nodes. But I cannot add the interrupts because python script complains. Is there any work-around for that?

Which python script fails ?
I can still compile the  tests/drivers/adc/adc_api/  for the  nucleo_f401re board after changing the adc area of the stm32f4.dtsi

Which python script fails ?
I can still compile the  tests/drivers/adc/adc_api/  for the  nucleo_f401re board after changing the adc area of the stm32f4.dtsi

gen_isr_tables.py: error: multiple registrations at table_index 18 for irq 18 (0x12)
Existing handler 0x80259e5, new handler 0x80259e5 . Thats the error if i modify stm32f405.dtsi by adding
adc2: adc@40012100 { 			compatible = "st,stm32-adc"; 			reg = <0x40012100 0x4d>; 			clocks = <&rcc STM32_CLOCK_BUS_APB2 0x00000100>; 			interrupts = <18 0>; 			status = "disabled"; 			label = "ADC_2"; 			#io-channel-cells = <1>; 		};
and
		adc3: adc@40012200 { 			compatible = "st,stm32-adc"; 			reg = <0x40012200 0x4d>; 			clocks = <&rcc STM32_CLOCK_BUS_APB2 0x00000100>; 			interrupts = <18 0>; 			status = "disabled"; 			label = "ADC_3"; 			#io-channel-cells = <1>; 		};
If i declare them as nodes on my board dts then I get the error I mentioned in the beggining.

gen_isr_tables.py: error: multiple registrations at table_index 18 for irq 18 (0x12)
Existing handler 0x80259e5, new handler 0x80259e5 . Thats the error if i modify stm32f405.dtsi by adding
adc2: adc@40012100 { 			compatible = "st,stm32-adc"; 			reg = <0x40012100 0x4d>; 			clocks = <&rcc STM32_CLOCK_BUS_APB2 0x00000100>; 			interrupts = <18 0>; 			status = "disabled"; 			label = "ADC_2"; 			#io-channel-cells = <1>; 		};
and
		adc3: adc@40012200 { 			compatible = "st,stm32-adc"; 			reg = <0x40012200 0x4d>; 			clocks = <&rcc STM32_CLOCK_BUS_APB2 0x00000100>; 			interrupts = <18 0>; 			status = "disabled"; 			label = "ADC_3"; 			#io-channel-cells = <1>; 		};
If i declare them as nodes on my board dts then I get the error I mentioned in the beggining.

Ok I see.
BTW : STM32_CLOCK_BUS_APB2 0x00000200  for adc2 and STM32_CLOCK_BUS_APB2 0x00000400 for adc3

Ok I see.
BTW : STM32_CLOCK_BUS_APB2 0x00000200  for adc2 and STM32_CLOCK_BUS_APB2 0x00000400 for adc3

Is that correctly classified as a bug? Since I am missing the nodes? Is it something that I dont see?

Is that correctly classified as a bug? Since I am missing the nodes? Is it something that I dont see?

Well, not really a bug. This is the zephyr interrupt handler configuration which limits to only one active (in the board dts) at a time.
All ADC instances can share the same irq vector (18) but cannot be all activated simultaneously.
If you need more than one ADC, maybe a global ADC dtsi is better (with large reg = <0x40012000 0x400>) instead of splitting in 3 ADC areas as you only have one interrupt handler (and you may miss the 'Common' register bank).

Well, not really a bug. This is the zephyr interrupt handler configuration which limits to only one active (in the board dts) at a time.
All ADC instances can share the same irq vector (18) but cannot be all activated simultaneously.
If you need more than one ADC, maybe a global ADC dtsi is better (with large reg = <0x40012000 0x400>) instead of splitting in 3 ADC areas as you only have one interrupt handler (and you may miss the 'Common' register bank).

This would be good to add!
My suggestion:

Add 3 register ranges of size 0x4D, one for each ADC (compatible with sm32-adc)
Add a ADC common register range

Open issue: how to deal with the common register settings?

This would be good to add!
My suggestion:

Add 3 register ranges of size 0x4D, one for each ADC (compatible with sm32-adc)
Add a ADC common register range

Open issue: how to deal with the common register settings?

I suppose this issue is related to: https://github.com/zephyrproject-rtos/zephyr/issues/26874

Closing in favor of #26874


[io] add generic parser for BED files

This parser parses any TSV type bed file and returns a
BEDEntry instance where all elements are accessible as attributes.
Closes #144

rerun tests

rerun tests


Hide coins from E2 chips

Make pull request to wiremod to allow adding more forbidden classes instead of forking wiremod please.


Containers not unregistering from DNS if it is removed

Reproduction

start a container docker start <container> or docker run image
remove the container docker rm <container>
check registered containers curl -X GET http://dns.mageddo/containers
the container is at the list yet

Fixed


[BEAM-52] KafkaIO sink support

Added sink/write support in KafkaIO. The interface is similar to KafkaIO source. KafkaIO.write() returns a transform that writes the records to a Kafka topic.
TODO:

[x] decide on caching scheme for producer
[x] decide on what we want to do with Kafka write failures
[x] fix coder issue with KafkaValueWriter (unit test disabled)

R: @dhalperi & @aljoscha : please take a look when you get a chance.
Added totally 3 unit tests, one of which injects publish failures. Because of the way MockProducer works, I had to add another thread to 'mark each send() complete'. Overall the code in the tests looks a bit large. I left comments at multiple places.

@jbonofre

I'm building and reviewing.

The code looks very good. I just had some minor inline remarks.
The tests also look good, very thorough with the manual acknowledge and error propagation checking.
I have one general question, unrelated to this PR: whats the reason for splitting into Read and TypedRead, same for Write?

LGTM. I have an issue during test but not sure it's related to the sink (I'm investigating).

The build is failing due to a more strict checkstyle file, AFAIK.

Yes, I disabled checkstyle on Kafka for now (I will provide a PR to fix it).

It's very easy to fix before merging, just 5 places.

+1
@rangadi can you fix checkstyle errors ? I can do it for you if you prefer.

The code looks good to me. Can you just please fix checkstyle errors ?

Thanks for the review guys.. addressing all the comments now.

fixed check style errors and addressed other comments. I haven't changed how 'values' transform is applied.

I have one general question, unrelated to this PR: whats the reason for splitting into Read and TypedRead, same for Write?

@aljoscha,
Both Read and Write have some configuration parameters that depend on the type. E.g. timestamp function for Read, producer factory function for Write. We wanted to make sure a user can not change the type once one of these type dependent parameters are set. TypedRead/TypedWrite achieves that. We wanted to avoid the following for e.g. :
KafakIO.read()
   .withKeyCoder(StringUtf8Coder.of())
   .withValueCoder(ByteArrayCoder.of())
   .withTimestampFn(fn_that_takes(KV<String, byte[]>)
   .withKeyCoder(BigEndianLongCoder.of()) // <====== oops this invalidates timestampFn.

@rangadi I see, that's a very good reason indeed. Thanks for the explanation!

LGTM

Tested sink in an app.

R: @dhalperi , I forgot to add this to your queue.

R: @dhalperi the latest update includes couple of changes we discussed:

increase publish retries to 3 (default is 0). User can override this if required.
use CoderUtils.encodeToByteArray()

The unit test that induces failures was not affected by increase in retries since MockProducer does not seem to obey the retries.

LGTM
Tried to merge this, but the rebase on top of master failed. I think maybe you have some fun out of order CLs. Can you rebase and squash?

squashed all the commits into one (did this manually, rebase didn't apply properly).


Transforming DisplayStyles with huge amounts of element references has a big impact on memory and performance

The test iModel I tested it on had 210 DisplayStyle3D Elements. Each of those had more than 250k element references in jsonProps.excludedElements.
Cloning each DisplayStyle takes close to 1minute of processing time (later on it takes more than that because of a different issue).
Because transformer processes definition elements first, all those references are not found in the target iModel at the moment the DisplayStyle is processed, so remapping them is impossible and the DisplayStyle is inserted as a "partial element". Currently transformer is very inefficient in storing the partially committed entity references and in this specific scenario it amounts to a large performance hit and requires a lot of memory.

I actually recorded this proposal already in the last bullet point here:
https://github.com/iTwin/imodel-transformer/issues/83#issue-1774935962


Create more meetings for MP Metrics group

MP Metrics teams needs to create weekly Thursday calls from this week 2:00-3:00 British Summer Time and last for 2 months.
I was no longer able to log into zoom account using microprofile-marketing. I got this error

We need to work out a better strategy for the login issue. In the meanwhile, @jclingan can you schedule the meetings first? Thanks

I did add more meetings, but we still have to get the code (with help from Eclipse Foundation staff) so you can log in.

what is the status of this issue @jclingan ?
Does MP need to buy its own Zoom account?

This week during the MP mktg call we noticed that Zoom is working ok with access to Admin calls. Closing ticket.


Observer throws on diffing rows with Object

Original report https://groups.google.com/forum/#!topic/lovefield-users/Vgfo0rWDnH8
Repro: (need small modification: change:any is TypeScript and need fix)
(async function() {
 const builder = lf.schema.create('Test', 1)
 const tableBuilder = builder.createTable('Post')

  tableBuilder.addColumn('_id', lf.Type.STRING)
   .addColumn('object', lf.Type.OBJECT)
   .addColumn('name', lf.Type.STRING)
   .addPrimaryKey(['_id'])

  const database = await builder.connect({
   storeType: lf.schema.DataStoreType.MEMORY
 })

  const table = database.getSchema().table('Post')

  const row = table.createRow({
   _id: '1111',
   object: { a: 1, b: 2 },
   name: 'post 1'
 })

  await database.insert()
   .into(table)
   .values([row])
   .exec()

  const q = database.select()
   .from(table)
   .where(table['_id'].eq('1111'));

  database.observe(q, (change) => {
   console.log(change);
 });

  await database.update(table)
   .set(table['name'], 'post 2')
   .where(table['_id'].eq('1111'))
   .exec();
 // so far it's ok

  await database.update(table)
   .set(table['name'], 'post 3')
   .where(table['_id'].eq('1111'))
   .exec();

  // once JSEngine execute this line, there's an error will be shown in console
})();

Exception stack screenshot

The bug is in DiffCalculator and only shows when the same row has changed twice.
Reason: DiffCalculator falsely get EQ operator for Object, which is not normal EQ logic (i.e. not deepEquals).  I've created a test file to demo that.

So I did some investigation and figured out why the issue is happening.
For user issued queries, we disallow comparing any OBJECT columns to anything else other than null at https://github.com/google/lovefield/blob/master/lib/eval.js#L269. So when our internal algorithm tries to reuse the same column evaluation mechanism to determine whether the row was changed it compares on OBJECT column with its previous value which violates the constraint.
I need to think about what the proper fix would be, but at least now we know why it is happening.


Add social text tag only when necessary

hello,
when using the social component, I wanted to display only icon, without any text so I set xyz-content=""
as expected, there's no text displayed but the td>a tags still exist in HTML code, with a padding-right so this element has a width
these tags should be added only if text is not empty

Have you tried with text-mode = false?
Example:
https://mjml.io/try-it-live/b665980d71b571adeace00e283ded09e

exactly what I needed so I think documentation should be improved on this particular point as it is written:

attribute
unit
description
default value

text-mode
string
vertical/horizontal
true

I didn't understand why true was the default value if authorized values were vertical and horizontal
now I get it...
thanks


Columns order not respected for columns containing other columns

material-react-table version
1.0.4
Describe the bug and the steps to reproduce it
When there is columns containing other columns they seem to be pushed at the end of the table, not respecting order of the column definitions.
Your Minimal, Reproducible Example - Sandbox (Recommended) or code snippets
Columns order not respected for columns containing other columns
Screenshots or Videos (Optional)
No response
Do you intend to try to help solve this bug with your own PR?
No, because I don't know how
Terms

[X] I understand that if my bug cannot be reliably reproduced in a debuggable environment, it will probably not be fixed and this issue may even be closed.

Thanks for reporting this. This should be fixed as of v1.0.5
https://codesandbox.io/s/confident-orla-rtpp44?file=/src/App.js

So quick. It works fine for me. Thx again


Add Support for Min/Max ASG size in cluster creation

Finished in PR https://github.com/jonahjones777/eksboot/pull/16


KEB should wait for reconciler deletion

Description
Currently KEB does not wait for reconciler deletion and the deprovisioning process is not adjusted to work with reconciler yet.

Reasons
We already use reconciler for spinning up Kyma 2.0 clusters when provisioning, but the deprovisioning part is not implemented yet.

Attachments

PR: https://github.com/kyma-project/control-plane/pull/1088


[DOC] add contributing guidelines to add figures in the specs

The need for guidelines regarding figures in the specifications was mentioned in a meeting related to BEP005 and was also pointed in the PET BEP.
This is a PR to get some sort of guidelines started.
Questions

Do we want to have specific format recommendations for non-vector graphics? png?
Maybe some size limits on the images too to avoid having people send us 15 Mo images. :-)

I might be overlooking some aspects with the pdf conversion process too that I don't know too well.

Other questions
Should we mention that the main specs should be for very "comprehensive" figures and that for "smaller" figures they could go in the appendices or the starter kit?

Should we mention that the main specs should be for very "comprehensive" figures and that for "smaller" figures they could go in the appendices or the starter kit?

yes
Just an early comment that I'd like all people who upload an image to include a README file that details where the image came from and how it can be reproduced. Preferably with a link to the file that generated the figure.
Also, I think that several people may advocate for not having image files in this repository at all, and instead including them in a submodule or in some other way. :thinking: so that may be worth thinking about as well. The motivation behind that would be that image files are usually not well tracked with git, and tend to bloat up the history and repo size unnecessarily.

* discuss if it makes more sense to have an "images" repo and include it as a [git submodule](https://git-scm.com/book/de/v2/Git-Tools-Submodule) in bids-specification, rather than adding images here in this repo directly

I am tempted to kick that one down the road and cross that bridge when we get to it. The reason is that I don't exactly expect the specification to start accumulating images like a "family album".
Another reason is that sub-module adds another layer of technological complexity that could make it harder for people to contribute. ( "A repo within a repo?? I just want to add an image, not shoot a remake of Inception!" :wink: )
So I would suggest clear guidelines on not submitting 15 mb images as a first line of defense.
What do people think?

What do people think?

I agree with that. We don't strictly need the technologically advanced method right now.

Thanks! I think that figures are always enriching, so would very much like to have illustrations in the specs to facilitate comprehension. I don't know about the technical details. But probably each bep may have max 2 or 3, is this too much? Maybe if in the future, the technical details are difficult to handle, we can explore these repos within repos, but for now we can proceed the simple way, with some indications :)
I also wonder if it could be useful to recommend each bep to have at least one explanatory figure.

Thanks @Remi-Gau

Thanks @Remi-Gau