copilot: Introduced support for organizations and team metrics visualization

Hey, I just made a Pull Request!

This update introduces support for both organizations and team metrics visualization in the GitHub Copilot plugin. With these new features, users can now select specific teams within their organization and compare their metrics with overall data, providing more insightful analysis and management capabilities.
Additionally, the images included in this update, which showcase various visual aspects of the plugin, were generated using the GPT AI model. To the best of our knowledge, these images are free to use, as they were created by the AI without any existing copyright restrictions.
:heavy_check_mark: Checklist

[x] A changeset describing the change and affected packages. (more info)
[x] Added or updated documentation
[ ] Tests for new functionality and regression tests for bug fixes
[x] Screenshots attached (for UI changes)
[x] All your commits have a Signed-off-by line in the message. (more info)

Im not sure how or why but this plugin manages to nuke my homepage when i install it

Hi @esw-afabiano, would it be possible to break this up? Ideally one PR focused on the initial feature and then another for the theme and style changes? There also seems to be GitHub integration/token changes. These large PRs are hard to review and lead to what you are experiencing where you are having to do follow up work based on Adopter feedback.
Also, can you post a screenshot of the images in use? Are they really needed? They don't really fit into the look and feel of Backstage and images are not really used like this anywhere. I realize I'm being the "no fun police" but a lot of Orgs are going to be frustrated by this as they have specific brand standards they follow. Maybe this is opt in?

Hi @esw-afabiano, would it be possible to break this up? Ideally one PR focused on the initial feature and then another for the theme and style changes? There also seems to be GitHub integration/token changes. These large PRs are hard to review and lead to what you are experiencing where you are having to do follow up work based on Adopter feedback.
Also, can you post a screenshot of the images in use? Are they really needed? They don't really fit into the look and feel of Backstage and images are not really used like this anywhere. I realize I'm being the "no fun police" but a lot of Orgs are going to be frustrated by this as they have specific brand standards they follow. Maybe this is opt in?

I can certainly break this up, but I'll need to wait for this PR to be merged first. There have been significant changes to the project, and the style updates are based on the new layout. If you’d like me to separate them, I can do that!
Regarding the image, I felt that there wasn't much creativity in designing that screen, so I decided to include an image. I've also added a GIF that shows its usage: demo.gif.
Let me know if you need any adjustments!

Needs rebase and maybe to split into smaller PRs?

@awanlin, regarding the issue raised about the image, does it make sense as it is now, or do we need to change it?
As for splitting this into two PRs, one for the feature and another for the theme fix, as I mentioned earlier, it can be done. However, the structure has been significantly altered. This also ties into the point raised by @nickboldt about breaking it into smaller PRs. The complicating factor is that one part depends on the other, and splitting it into smaller PRs would likely break the application. We already have a functional version of this, so I'm not sure if it's the right approach for this PR. I'm willing to do whatever is necessary, but I also want to avoid creating additional problems and rework.
Looking forward to the next steps and seeing this version used by the community!

@awanlin, regarding the issue raised about the image, does it make sense as it is now, or do we need to change it?
As for splitting this into two PRs, one for the feature and another for the theme fix, as I mentioned earlier, it can be done. However, the structure has been significantly altered. This also ties into the point raised by @nickboldt about breaking it into smaller PRs. The complicating factor is that one part depends on the other, and splitting it into smaller PRs would likely break the application. We already have a functional version of this, so I'm not sure if it's the right approach for this PR. I'm willing to do whatever is necessary, but I also want to avoid creating additional problems and rework.
Looking forward to the next steps and seeing this version used by the community!

@vinzscam, @awanlin  Do you have any idea what's going on here? Locally, the command yarn install --immutable worked normally. Here, it seems to be throwing an error without detail.

@vinzscam, @awanlin Do you have any idea what's going on here? Locally, the command yarn install --immutable worked normally. Here, it seems to be throwing an error without detail.

I think if you rollback the changes made to the yarn.lock at the root of the project it should fix the issue!

report.md

Did not work!

@vinzscam, @awanlin Do you have any idea what's going on here? Locally, the command yarn install --immutable worked normally. Here, it seems to be throwing an error without detail.

I think if you rollback the changes made to the yarn.lock at the root of the project it should fix the issue!

did not work!

I still see some changes to the yarn.lock at the root of the community-plugins (not under copilot's workspace)

@vinzscam Well.. the resolution was to have to uninstall my yarn package and reinstall using npm in version 1.22.19, and then it was able to get the yarn version defined in the project. It seems to be 100% now

Hey @vinzscam, any chance to merge this?

It would be great to have it released 🙏🏻

sorry for the long waiting time. Just a few minor comments then we can ship this

Hey, thanks for reviewing.. I guess it's done 😆

Hi @esw-afabiano,
The new changes seem to have altered the behaviour of average acceptance rate calculations:
The new way has a much lower acceptance rate and its because of this change to the calculations:
total_lines_accepted/total_lines_suggested
instead of
total_acceptances_count/total_suggestions_count
Is this the correct behaviour now? I hope that the PRs title can reflect what was actually changed as end users it looks like the chart data suddenly changed on us without prior notice.
Previously in Oct this PR was introduced to use total_acceptances_count/total_suggestions_count to be inline with other plugins
[https://github.com/backstage/community-plugins/pull/1503]
But now its back to using total_lines_accepted/total_lines_suggested
Please let us know!
Thanks,
Eric


Fix udc deployment with constructor test

Describe your changes

Update Sepolia testnet classHash used in test udc deploy with constructor

Linked issues

Closes #464
Breaking changes

[ ] This issue contains breaking changes

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 69.65%. Comparing base (f43b8b5) to head (cf26145).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #488      +/-   ##
==========================================
+ Coverage   69.62%   69.65%   +0.02%
==========================================
  Files          88       88
  Lines        3381     3384       +3
  Branches      368      368
==========================================
+ Hits         2354     2357       +3
+ Misses        868      866       -2
- Partials      159      161       +2

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Unit tests and new task names

[Breaking]: Change naming convention for tasks. The names primary part is
the target, then the action (lib:build instead of build:lib) to group
the tasks per target.
[Breaking]: Use typeRoots instead of definitions in configuration to
specify Typescript definition files.
Generate tsconfig.json file (mainly for editors)
Implement the test target to run unit-tests with mocha.

There was an issue with the new test command (because of the change of the name). The branch was deleted and pushed again with a fix. See #6


CI: run build_mac twice, if setup script changed

This would run the build_mac job twice, to test a cache, if any of the setup scripts changed.
This would prevent a situation like this: https://github.com/commaai/openpilot/pull/29456, where the first run succeeds, but the one after that, fails due to missing files in build cache.

@adeebshihadeh any thoughts on this?
I don't see any other option for testing macos build cache, other than building it twice - once to rebuild the cache, and the to test if it builds with it.

Is the issue with the cache itself or restoring a bad cache?

Restoring cache works well, the issue is when cache is incomplete - usually caused by someone forgetting to add some paths to it. Then this step fails - because we skip any setup/installation step if we hit cache, to speed it up.

This seems pretty janky, and we don't have to do this for our other jobs' caches. Can we just make the bug harder to write?

I agree it feels janky...


Unable to connect Databrick's Unity catalog

Describe the bug
ModuleNotFoundError: No module named 'unitycatalog'
To Reproduce
Steps to reproduce the behavior:

Go to '...'  Create a standalone python program
Click on '....' added this code mentioned in this page https://www.getdaft.io/projects/docs/en/latest/user_guide/integrations/unity-catalog.html
Scroll down to '....'
See error
File "/Users/user/PycharmProjects/daft_project/.venv/lib/python3.11/site-packages/daft/unity_catalog/init.py", line 1, in
from .unity_catalog import UnityCatalog, UnityCatalogTable
File "/Users/user/PycharmProjects/daft_project/.venv/lib/python3.11/site-packages/daft/unity_catalog/unity_catalog.py", line 6, in
import unitycatalog
ModuleNotFoundError: No module named 'unitycatalog'

getdaft version used :- 0.2.28
python version 3.11
Expected behavior
To connect the databricks unity catalog
Screenshots
If applicable, add screenshots to help explain your problem.
Desktop (please complete the following information):

OS: [e.g. iOS]
Browser [e.g. chrome, safari]
Version [e.g. 22]

Smartphone (please complete the following information):

Device: [e.g. iPhone6]
OS: [e.g. iOS8.1]
Browser [e.g. stock browser, safari]
Version [e.g. 22]

Additional context
Traceback (most recent call last):
File "/Users/user/PycharmProjects/daft_project/test.py", line 1, in
from daft.unity_catalog import UnityCatalog
File "/Users/user/PycharmProjects/daft_project/.venv/lib/python3.11/site-packages/daft/unity_catalog/init.py", line 1, in
from .unity_catalog import UnityCatalog, UnityCatalogTable
File "/Users/user/PycharmProjects/daft_project/.venv/lib/python3.11/site-packages/daft/unity_catalog/unity_catalog.py", line 6, in
import unitycatalog
ModuleNotFoundError: No module named 'unitycatalog'

Hey @cn-dinakarsundar thanks for the comment!
We will fix this in our docs and error messages, but to have this work you need the unitycatalog pip package. You can install Daft this way to get both: pip install getdaft[unity]
Alternatively, you can manually install the unitycatalog package like so: pip install unitycatalog
Good luck! Let us know if this works in Databricks as well -- we've heard from our partners at Databricks that this might require some private preview functionality in Databricks to allow for credentials vending so if you encounter errors that look like this feel free to let us know!

Docs incoming! https://github.com/Eventual-Inc/Daft/pull/2440

Hey @cn-dinakarsundar thanks for the comment!
We will fix this in our docs and error messages, but to have this work you need the unitycatalog pip package. You can install Daft this way to get both: pip install getdaft[unity]
Alternatively, you can manually install the unitycatalog package like so: pip install unitycatalog
Good luck! Let us know if this works in Databricks as well -- we've heard from our partners at Databricks that this might require some private preview functionality in Databricks to allow for credentials vending so if you encounter errors that look like this feel free to let us know!

@jaychia  .. How did you resolve the issue
Request to generate access credential for table '2557c82e-*****' from outside of Databricks Unity Catalog enabled compute environment is denied for security. Please contact Databricks support for integrations with Unity Catalog```

Is there any special setting in Databricks required to access UC via daft ?

Yes that is a known issue!

Good luck! Let us know if this works in Databricks as well -- we've heard from our partners at Databricks that this might require some private preview functionality in Databricks to allow for credentials vending so if you encounter errors that look like https://github.com/unitycatalog/unitycatalog/issues/2 feel free to let us know!

Here is a private preview form you can use to activate your private preview -- just specify that you want to use Daft with Databricks and someone from Databricks will get in touch with you.


refactor(reactivity): Ascending function, Avoid every times creation.

Ascending add and run
and rename addEffect/runEffect

You seem to reduce two function expressions, but added two arrow functions. The actual difference is very small.

^ what @Picknight says.

都是自己人而且已经关闭了,  那我就说中文了哈....
一个箭头函数的成本真的和一个完整函数体的成本是一样的或者相近的吗  这点我挺吃惊的 谢谢
另外一点  把函数提出来而不是作为变量嵌在里面是不是可读更高呢
如果我这样改会不会好点呢 谢谢 https://github.com/zhangenming/vue-next/commit/ad80018109ca138be3c304a556c61c7cb4a8ccfd
可能是我强迫症了吧

About arrow funtion's performance, see stackoverflow.
Regarding code readability, frankly speaking, I think the difference is not much.


POL-412 error message with Running Instance Count policy

Description
Fix for bug POL-412 error message with Running Instance Count policy
Issues Resolved
Modified policy template to collect instance id and formatted the template and README files.
Contribution Check List

[x] All tests pass.
[ ] New functionality includes testing.
[ ] New functionality has been documented in the README if applicable
[x] New functionality has been documented in CHANGELOG.MD

          1 Error

:no_entry_sign:
cost/instance_anomaly/README.md:10: MD022 Headers should be surrounded by blank lines
A detailed description of the rules is available at https://github.com/markdownlint/markdownlint/blob/master/docs/RULES.md

  Generated by :no_entry_sign: Danger

          1 Error

:no_entry_sign:
cost/instance_anomaly/README.md:10: MD022 Headers should be surrounded by blank lines
A detailed description of the rules is available at https://github.com/markdownlint/markdownlint/blob/master/docs/RULES.md

  Generated by :no_entry_sign: Danger


Support to YAML files as config

I really like YAML, and I like YAML as config file. It has a beautiful syntax and has so many interesting features that makes YAML able to be used as config files, supporting those features and still readable.
And, I really like decouple, so I decided to make this PR in order to be able to use this together.
Thx.

Thank you for you proposal. However this PR is very similar to #39 and it has the same design issues that make me unable to accept it.
Yaml implicitly deal with (1) data hierarchy and (2) type conversion while Decouple align itself with how envars works as pure strings.


Dashboard actions menu enhancement

The icons on the upper right corner of each Dashboard card add visual complexity without adding information.

The row of icons should be replaced by a vertical ellipse icon that will hide and show on hover. When the icon is clicked, it should display a menu with all of the actions for the dashboard card. This will preserve access to the actions, and even allow for a greater number if needed in the future, while enabling the user to focus on the information that is relevant to them.

The suggested vertical ellipsis icon can be found here.
http://fortawesome.github.io/Font-Awesome/icon/ellipsis-v/

@serenamarie125 Is this something someone from your team could work on?

This functionality will be added to PatternFly.  We didn't think it was an immediate requirement.  Are you thinking for 4.1 or 4.0 timeframe?

@serenamarie125 No rush at all. We didn't realize it was going to be in Patternfly - keep us posted. Thanks.


Getting a 500 when assigning a new droplet after cancelling a deployment

Issue
I am unable to set the current droplet for my app after cancelling a deployment.
Steps to Reproduce

push an app with cf push dora
scale the app to 10 instances: cf scale dora -i 10
start a deployment that restarts the app: cf curl -X POST /v3/deployments -d '{"relationships": {"app": {"data": {"guid": "'"$(cf app dora --guid)"'"}}}}'
cancel the deployment and immediately start a new depoyment: cf cancel-deployment dora
try and push dora again cf push dora

Expected result
A successful follow up push
Current result
A 500
{\"errors\"=>[{\"title\"=>\"UnknownEr
ror\", \"detail\"=>\"An unknown error occurred.\", \"code\"=>10001, \"test_mode_info\"=>{\"detail\"=>
\"undefined method `health_check_timeout' for nil:NilClass\", \"title\"=>\"CF-health_check_timeout\",
 \"backtrace\"=>[\"/var/vcap/data/packages/cloud_controller_ng/e938b29c6a2d46357cbceeed131bea2c404eee
2b/cloud_controller_ng/app/models/runtime/deployment_model.rb:67:in `failing?'\", \"/var/vcap/data/pa
ckages/cloud_controller_ng/e938b29c6a2d46357cbceeed131bea2c404eee2b/cloud_controller_ng/app/models/ru
ntime/app_model.rb:117:in `any?'\", \"/var/vcap/data/packages/cloud_controller_ng/e938b29c6a2d46357cb
ceeed131bea2c404eee2b/cloud_controller_ng/app/models/runtime/app_model.rb:117:in `failing?'\", \"/var
/vcap/data/packages/cloud_controller_ng/e938b29c6a2d46357cbceeed131bea2c404eee2b/cloud_controller_ng/
app/controllers/v3/apps_controller.rb:258:in `assign_current_droplet'\"...

Cancelling a deployment leaves deployments with nil as their deploying_web_process:
app.deployments.map(&:deploying_web_process)
=> [nil,
 #<VCAP::CloudController::ProcessModel @values={...}>]

When assigning a new droplet we check if the app is failing which inspects the deployment's deploying_web_process's health check. Because the process is nil we get a 500.

Closing as the fix (https://github.com/cloudfoundry/cloud_controller_ng/commit/3cd2b9cd000ba7782634924601b12474c0c827ec) was in 1.87


Stored value type does not match pointer operand type

I was playing with fun and found something. I try to show you a minimal example:
fun print_chrray(value : Char[5])
  puts value
end

print_chrray(StaticArray(Char, 5).new('x'))

The above code produce the following message:
Module validation failed: Stored value type does not match pointer operand type!
  store [5 x i32]* %value, [5 x i32]* %value1, !dbg !54
 [5 x i32]
0x53c10e: ??? at ??
0x14e67a0: ??? at ??
0x1422e3d: ??? at ??
0x1cac555: ??? at ??
0x597c79: ??? at ??
0x56374d: main at ??
0x7f2f715c4291: __libc_start_main at ??
0x53b831: ??? at ??

Error: you've found a bug in the Crystal compiler.
Please open an issue, including source code that will allow us to reproduce the bug:
https://github.com/crystal-lang/crystal/issues

I don't think static arrays can be passed around in C, so maybe this shouldn't even compile. Maybe it's a bug, but it has very low priority.

What do you mean by passing array literal in C, I got this to work: (C code)
#include <stdio.h>

int func(const int bla[3])
{
  return bla[0];
}

int main()
{
  printf("%d\n", func( (const int[3]){42, 43, 44} )); // => 42
  return (0);
}

Is it what you're trying to do in Crystal @faustinoaq ?

@bew You're right. I was confused. My mistake :sweat_smile:

@bew Actually, you're just passing a pointer to the first element of the array, because C is C and reasons unknown.

@kirbyfan64 You're right, and I was confused too, so @faustinoaq you're right 😄

@bew Well...
Actually, C already completely ignores the bound on an array parameter. So, like you already said, value is of type char* in C. Therefore, the equivalent in Crystal is just Char* (no [5]).

Maybe C ignore bounds, but Crystal doesn't, so i like this little bit of additional typesafety in bindings: https://github.com/konovod/monocypher/blob/master/src/monocypher/libmonocypher.cr. Never encountered this issue though, maybe because i wrap all staticarrays in a structs with to_unsafe method.


feat: add asciidoc snippets

Alternatively, I could also provide my AsciiDoc snippets as a pull request.
They are mostly inspired by the Asciidoctor documentation.

thats great. so how it gonna be done?
im new to this pr stuffs. so you can contribute to this pr? or i should update my pr with your snippets?

I would clean up and complete my AsciiDoc snippets over the next few days and could then create a separate pull request.

so can i withdraw this now?


Implement create_data_integrity_proof for VerifiableCredential in SSI library

Implement create_data_integrity_proof for VerifiableCredential in SSI library using specification: https://www.notion.so/Create-Integrate-Core-SSI-Rust-Library-Design-9eb9e58093a04a7d84bb476ac0324a7d#9ae9eb4daaba48a9a430cfd5146dac1a

Once this issue is closed we need to:

[ ] Create an issue to integrate DIDVerifier trait in the DynamicVerifier struct in Interbank
[ ] Create an issue to integrate DIDSigner trait in the DynamicSigner struct in Interbank
You can find the current implementations here - https://github.com/monetae/core/blob/f4ef10f5c169a11f5eaf79317751e29b109b3b74/promissory/src/dynamic_signature.rs#L340-L343


support ST 4

This PR adds support of python 3.3 and 3.8 packages. The trick is to dynamically spawn a new package AutomaticPackageReloader33 dynamically and run
package_reloader33_reload if the package cannot be found in the current runtime.

There is no functionality to remove this dyanmic package yet, or is there?


issue with sharepoint success site

hi im having issue deploying sharepoint success site, yesterday i installed learning pathways and sharepoint success site, but when i tried to access sharepoint success site  the page didnt load  ok
this is the error
Microsoft 365 learning pathways has a configuration issue. Ask your administrator for assistance. [Administrators: Please see the browser console for detailed logs. For technical assistance check out the issues list at https://github.com/pnp/custom-learning-office-365/issues.]

Hello @cdlpty
Please review the Diagnosing Pre-Check and submit the information to us to further assist.
https://github.com/pnp/custom-learning-office-365/blob/main/installation/DiagnosisPreCheck.md

@cdlpty - you probably should also review that you completed the provisioning steps for the SharePoint Success Site; many, many people miss the final step of confirming the content pack setup. Please see this short video for more information: https://www.youtube.com/watch?v=HZjxBAKVnJs

Closed due to inactivity. If this is still an issue please create a new ticket and reference this one.


Adding strings for Poke2

Noticed there's no support for Poke2. Added strings as per this excellent guide and verified that it's working fine with Magisk.

Thanks for your strings! Merged.


RWC Won't Load New Wallpapers

Yo man!
I'm using RWC for far too long, only last week I found out there was an 'updated' version.
Since I've updated the software I can't get it to change wallpapers.
See attached log - https://pastebin.com/BJNstAf5
Thanks a whole lot for helping the community.
Cheers,

Hay chap.  Disable the "Validate wallpaper sizes" option. This option forces RWC to only apply wallpapers that match your exact screen resolution (3360x1158). Disabeling this and saving will get it working again. :)

Thanks dude it works great!


Want to contribute? 👇

Contributions to this project are very, very welcome. We'd love for you to use the project yourself, in your own work, then contribute back, so that we can improve the project for everyone. Treat it like your own. We'll do our best to make it as contributor friendly as possible. We are currently organising ourselves via the Open Up The Cloud community. Please reach out to Lou on Twitter, or LinkedIn so we can add you to the project. Feel free to drop a comment below, too !
How to contribute?
Many people can contribute in different ways. It's not just code contributions that are useful for open source projects like this one.

Raise an issue with a suggestion or question (e.g. https://github.com/openupthecloud/open-cloud-dev-box/issues)
Make a documentation contribution. Open a PR for changes to the README to link to documentation, explain things, add FAQs, etc.
Review a pull request you don't have to be an expert, you can help test the change, ask any questions, clarify, etc.
Make a code contribution. You can open PR's for code changes to the project if you'd like, too.

@santhoshnimmala ! Hey and welcome !! 👋
Shoot me a message on Twitter or LinkedIn, then I can add you to the community slack. There are a few open issues here, if you want: https://github.com/openupthecloud/open-cloud-dev-box/issues. Or, you could take a look at the list above. There are some technologies mentioned on the README, you could go and check those out, and possibly add to the documentation, sharing useful links to relevant resources, to people who are new to the space.


Add new trading rule: Bollinger Band

Bollinger Band
Bollinger band calculates a signal which characterizes the prices and volatility over time. There are three lines that compose Bollinger Bands. By default:

1. Middle band: A 20-day simple moving average
2. The upper band: 2 standard deviations above from a 20-day simple moving average (SMA)
3. The lower band: 2 standard deviations - from a 20 day SMA

Allocation Strategy
The strategy is to identify overvalued or undervalued market conditions.

Undervalued: Price breaks below the lower band of the Bollinger Bands.
lower-valued: Price breaks above the upper band of the Bollinger bands.

Relies on the concept of `mean reversion:
The theory suggests that asset price volatility and historical returns eventually will revert to the long-run mean. So:

if price>=upper_band_value then allocation = -max_allocation
if price<=lower_band_value then allocation = max_allocation
else: allocation = 0

@Cal231995 Take a look at this. Am I missing anything? Can this rule be made stronger?
This post talks about 22 rules. Can you do a research on this?
https://www.investopedia.com/terms/b/bollingerbands.asp

@Cal231995 Take a look at this. Am I missing anything? Can this rule be made stronger?
This post talks about 22 rules. Can you do a research on this?
https://www.investopedia.com/terms/b/bollingerbands.asp

Yes I'll send a chart here.
This is the best way for this indicator
Relies on the concept of `mean reversion:
The theory suggests that asset price volatility and historical returns eventually will revert to the long-run mean. So:
if price>=upper_band_value then allocation = -max_allocation (short position)
if price hits the middle band then close short position
if price<=lower_band_value then allocation = max_allocation (long position)
if price hits the middle band then close long position
else: allocation = o
ideal approach would be to take a short position when the price breaks above the bollinger bands and closed that position when the price hits the middle band
vice versa only take long position when the price is below the lower bollinger bands and close the position when the price hits the middle band
Because in real tradin somtimes it takes too long for the price to reach the opposite side the of the bands

What Is a Bollinger Band?
Bollinger Bands developed by John Bolinger in the 1980s, is a technical indicator that is used to identify when an asset is overbought and oversold. The bands comprise a volatility indicator that measures the relative high or low of a security’s price in relation to previous trades. It is comprised of the upper, middle, and lower band which envelopes the price range levels. An asset is considered oversold when it breaks below the lower band and considered overbought when it breaks above the upper band.
Formula :

Allocation Strategy :
The theory suggests that asset price volatility and historical returns eventually will revert to the long-run mean. So:
if price>=upper_band_value then allocation = -max_allocation (short position)
if price hits the middle band then close short position
if price<=lower_band_value then allocation = max_allocation (long position)
if price hits the middle band then close long position
else: allocation = o
@fhashim you can use this definition, free of copyright issues. Thank you.


Frontend Tooling

[ ] vite
[ ] HTMX
[ ] leaflet-html
[ ] linting (prettier, eslint)
[ ] Storybook
[ ] testing (vitest)

Can we skip front end tooling and ship a prototype?

Good idea, I'll throw together a couple of wireframes and user flow diagrams as PNGs into a design/ directory at the root of the repo for some prototype ideas


'cuda' is not a valid DistributedType

Hi when I train the humansd model, I met the 'cuda' is not a valid DistributedType'
I set the GPU to 1 can not fix.

Hi when I train the humansd model, I met the 'cuda' is not a valid DistributedType' I set the GPU to 1 can not fix.

Hello, did you follow up on this issue? I had a similar problem when I reproduced it. I changed the 'cuda' to 'gpu' and the bug was solved, but then opt.train=False and I couldn't get to trainer.fit(model, data), have you encountered this?


Calls Not done directly from the App , It uses the platform dial pad to continue making call

Hello ,
I'm trying to make a phone call directly from my app and track it's state ,
I've used Your plugin but It redirects my to the phone dialpad to continue make the call .
I've found another package which is "package:flutter_phone_direct_caller" and it makes a direct call but dose not support tracking the phone call state ,
Any one have an idea ?
how can I merge these two packages ?

I did it by creating new function inside flutter_phone_state.dart
and call it instead of _openTelLink
Future _makeDirectCall(String number) async {
if (number == null) {
return CallStartResult.invalidInput;
}
if ( await FlutterPhoneDirectCaller.callNumber(number)) {
return (await FlutterPhoneDirectCaller.callNumber(number))
? CallStartResult.success
: CallStartResult.failed;
} else {
return CallStartResult.unsupported;
}
}


Update

Hi, @Arjan-Zuidema !
I updated the action a bit:

Switched to TypeScript
Added functionality to remove caches from multiple pages

Hi @deemp!
Thanks for your pull request! Looks good for the most part. I added some comments, if you can reply/fix those we can merge it 🙂

@Arjan-Zuidema, unfortunately, I don't see your comments

Just scroll up in this window 🙂

Here's what I see :)

Check files changed tab

This is how the comments should look like

@deemp I added mentions and request changes

@deemp What is NODE_OPTIONS=--openssl-legacy-provider used for?

@Arjan-Zuidema, I answered in a review. Is it visible?

My bad, I didn't submit

I updated the workflow to use it as an example

As there are a lot of commits, I guess it'd be better to squash them before merging

@Arjan-Zuidema , please, have a look

Workflows in my fork fail. Will look into it later

Seems like a permission issue. But I think that should not happen on a GitHub action run. I think this case needs to be handled so the rest of the run will continue. Could you add that in the PR? Just wrap it with a try catch and log the error

This is merged in #3 🚀


@conda-forge-admin,please add bot automerge

@conda-forge-admin,please add bot automerge

Hi! This is the friendly automated conda-forge-webservice.
I just wanted to let you know that I added bot automerge in conda-forge/geoarray-feedstock#18.


br don't have end tag

Resolves #125

Have you seen this error too?
Unexpected closing tag "p". It may happen when the tag has already been closed by another tag. For more info see https://www.w3.org/TR/html5/syntax.html#closing-elements-that-have-implied-end-tags (1:686)
It's on this page for example:
https://design.geovistory.org/?path=/story/contributing-tutorial-server-side-rendering--server-side-rendering


trailer headers for stream responses

My php service generates a very big list of items.
I decided to stream items on the fly as they are generated to save memory.
I implemented response body as a custom stream that wraps a generator which yields items.
Now I need to append a checksum trailer header to that stream response, so clients can check response validity.
What is a proper way of appending trailer header to a stream response in diactoros?

This repository has been closed and moved to laminas/laminas-diactoros; a new issue has been opened at https://github.com/laminas/laminas-diactoros/issues/15.


Single Type for artithmetics in Q#

Hello everybody!
I am not an expert, and I have been (unsuccessfully) trying to multiply two real numbers using the QuantumSimulator.
Simulation works fine using Toffolis, but I want to use the full qubit, here is the code:
operation Multab(fstNbr: Double, scdNbr: Double) : Double {
    let numBits = 3;
    mutable result = 0.0;
	using ((register1, register2, carry) = (Qubit[numBits], Qubit[numBits], Qubit[numBits])) {
		let qa = FixedPoint(1,register1);
		let qb = FixedPoint(1,register2);
		let qab = FixedPoint(1,carry);

		// initialize the quantum numbers:
		PrepareFxP(fstNbr, qa);
		PrepareFxP(scdNbr, qb);
		PrepareFxP(0.0, qab);

		// perform product
		MultiplyFxP(qa, qb, qab);

                   set result = MeasureFxP(qab);
                   ResetAll(register1 + register2 + carry);
	}

Using 3 bits, the result is 0 for any numbers, reasonable for 3 bits, but if I try 4 bits, simulation fails,
My point is: having available the Single precision type, avoiding use of Double type, could help to solve this issue?
Thanks a lot!

Thanks for the report, @griffonsjla, we really appreciate the feedback. If apologize, though, that I'm not sure I entirely understand your questions. You mentioned that your program works well on the Toffoli simulator target machine, but fails on the quantum simulator target machine, is that correct? How does the simulation fail when using 4-qubit registers?
In any case, I don't believe that single-precision versus double-precision would help in this case, as double-precision refers to the representation used by classical registers. In the program you provided, the quantum registers are represented by the FixedPoint type on an arbitrary number of qubits (numBits in your example).

We will be closing this for now. If additional info can be provided please re-open the issue.


Include learn resources to online courses

Just the awesome list collected by @ivan-pi in https://github.com/fortran-lang/fortran-lang.org/issues/200#issuecomment-776134553 for now.
Closes #200

#build_preview

Thank you, this has been open for a while without complaints, so I will merge.

#delete_preview


Using an empty object as default state with React.createContext

Hi, @sw-yx , I believe I know what the issue is: My prettier set up changes double quotes to single quotes and I think that is the issue. I'm not sure how problematic that will be if you merge ? If you cannot merge I'll simply close the PR, change the prettier setup and re-open the PR. Have a good day and stay safe !

nope this looks good!! thank you very much!

cool! thanks for your contribution! https://github.com/typescript-cheatsheets/react-typescript-cheatsheet/pull/202#issuecomment-606253643


[GSSoC'23] implement authentication in sign up and login with jwt

I want to implement authentication in sign up and login with jwt. please assign me this task!

Yes yes..go ahead!
Thankyou..

ok, Thank you!


PrimateLabs.Geekbench3 version 3.4.4

[ ] Have you signed the Contributor License Agreement?
[ ] Have you checked that there aren't other open pull requests for the same manifest update/change?
[ ] This PR only modifies one (1) manifest
[ ] Have you validated your manifest locally with winget validate --manifest <path>?
[ ] Have you tested your manifest locally with winget install --manifest <path>?
[ ] Does your manifest conform to the 1.4 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.

Microsoft Reviewers: Open in CodeFlow

On a 64-bit VM, this package installs normally. On launch, it gives this message:

Then it runs normally:

I'm guessing the x86_32 executable is there for 32-bit benchmarking on 64-bit OSes, not necessarily for a 32-bit OS.


Synthetic Canary Runtime Deprecated

https://github.com/cdklabs/cdk-ecs-codedeploy/blob/622c1f7bc553ae51858e21c4d652d42db6bb43c8/src/api-canary/index.ts#L226C24-L226C55
this canary version runtime: Runtime.SYNTHETICS_NODEJS_PUPPETEER_4_0, is deprecated
https://docs.aws.amazon.com/AmazonCloudWatch/latest/monitoring/CloudWatch_Synthetics_Canaries_Library.html#CloudWatch_Synthetics_Canaries_runtime_support, please upgrade to a supported synthetic runtime

https://github.com/cdklabs/cdk-ecs-codedeploy/blob/eed5fc61c39416626749c93941faa4a75261fc52/src/api-canary/index.ts#L226
Has been updated


Allow for Age Restricted Videos to be Accessed

If you try to access an age-restricted video, like GU7qYaYzd-0, without cookies you get back the The video is no longer available error. There should be functionality added to allow a user to load their Youtube cookies so they have the authorization required to access the age-restricted video.
I have almost finished a small PR to complete this, so if you're ok with it I will open up said PR.

Hi @danielcliu,
thanks for the report. Looking forward to the PR! 😊👍
But doesn't fixing this require some sort of login?


Does not work with rack < 2.0.0

NoMethodError - undefined method `add_header' for #Rack::Response:0x007fa048c907d0:
add_header was added in rack 2.0.0 :(

check this PR: https://github.com/arkency/image_placeholder/pull/2
I think it little hack but it works for me also with older Rack (1.6.0)


Misspelling corrections on Dimensions table

Looks like there has been some errors. When using CQDPowerShell 2.0.1 you could get the correct dimensions from the CQD.
I also verified these from CQD GUI and see the same errors.

Learn Build status updates of commit 8aa4cb8:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

Teams/dimensions-and-measures-available-in-call-quality-dashboard.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel

@CarolynRowe
PR has been copyedited and is ready for final review, could you please check and merge? Thanks!


Add RPCS3 persist files and folders.

There are some files and folders that aren't persisted for RPCS3:

Folder
Explanation

dev_flash
Where the firmware is installed to. Persisting this avoids having to reinstall the firmware every updated.

cache
PPU modules can take quite bit of time to compile on first run of a game, persisting this allows cache from the previous version to work.

config.yml
The global emulator configuration.

config
Game-specific emulator configuration and controller configurations.

games.yml
The games visible in the game list when you start RPCS3.

Icons
Custom icon location.

patches
Downloaded game patches.

To my knowledge, the built-in RPCS3 updater persists these files and folders, so scoop should too.

The CI error is from a different app:
[-] files have no lines containing trailing whitespace 82ms
    RuntimeException: The following 1 lines contain trailing whitespace:
    File: C:\projects\scoop-games\bucket\opdessertstorm.json, Line: 31
    at <ScriptBlock>, C:\projects\scoop\test\Import-File-Tests.ps1: line 123

This PR only added some things to the persist list, so it shouldn't have caused any new errors.


Support notifications api

https://developer.github.com/v3/activity/notifications/

Done toward 1.65.

Thank you! :smiley:


SEAL - Utilizing multiple edge features

Hello SEAL Team,
thank you very much for the great implementation!
I noticed that you can incorporate the node features and edge weight into the SEAL learning process (--use_feature and --use_edge_weight). Dealing with edge weight seems pretty straightforward for me, but have you thought about a possibility of combining further edge features (not only one weight) in SEAL? Is there a possibility of doing this as well?

Hi,
Absolutely! You may replace the graph convolution layers in SEAL with a GNN that deals with edge features, such as GINE. Since there are currently no link prediction datasets with edge features, I did not add such a GNN.

Thank you very much!

I am currently implementing this and I have one remaining question. Currently, you are compressing the edge features into one edge weight.
The k-hop_subgraph extraction method is relying on A, and no longer obtains the edges via edge_index, thus obtaining the edge features by indexing of Data.edge_attr is not easily feasible.  So in my opinion, it would be nicest to extend the dimensions of the ssp.csr_matrix, so that we have (num_edge_features, num_nodes, num_nodes). But, this is not easily feasible, if I understand the documentation of CSR Matrix correctly. Do you know a straightforward solution for this?

@bits-glitch One possible solution is to create a dictionary storing the map from (i,j) to edge attribute vector, and feed this dict into the subgraph extraction function.
One other built-in data structure is the "Hybrid sparse COO tensors" in PyTorch. Check this doc. It supports querying a dense tensor via sparse indices, and slicing along a dense dimension. You may convert the edge_attr into this format and do the querying.

Thank you for the advice, that was really helpful!
Getting all edge attributes by using the map (as you suggested) was straightforward:
      # assemble (node1id,node2id) similar to scipy.sparse.csr_matrix notation
      node1id = subgraph.tocoo().col
      node2id = subgraph.tocoo().row

      node1id = [nodes[i] for i in node1id]
      node2id = [nodes[i] for i in node2id]

      edg_idx = list(tuple(zip(node1id,node2id)))
      # Remove target link between the subgraph.
      edg_idx.remove((src,dst))
      edg_idx.remove((dst,src))

      edge_features = torch.tensor([map[i].numpy() for i in edg_idx]).t()

Two questions remain:

how to order the edge attributes, i.e. if the ordering is correct in this implementation. Could you give me some advice concerning that matter?
how to feed the edge attributes to GINE. I get a dimensionality problem with GINE
The dimensions of edge_index and edge_attr should be consistent, but I am not sure how to fix the problem with x:

x:torch.Size([270, 32])
edge_attr:torch.Size([6, 422])
edge_index:torch.Size([2, 422])

Do we need to use a different GNN operator?

I guess the order is correct here. When you construct the pyg subgraph here, you stack the row and col indices returned by ssp.find(). If a scipy coo matrix's col and row attributes have a consistent order as the find(), then it is fine. My guess is that they should be consistent (both row-first expanding). You may verify this by feeding in a small test example.

According to GINE, it needs x and edge_attr to have the same feature dimension for summing them up. You may use other GNNs supporting edge features, such as NNConv, or manually add a linear layer to transform edge_attr to have the same dimension as x.


Fix lint issues

addresses issue https://github.com/fossasia/open-event-webapp/issues/402

@championswimmer Conflicts here ..


refactor: make decorator document more simple

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

[x] N
[ ] Y

refactor: make decorator document more simple

2. What is the scope of this PR (e.g. component or file name):

kclvm/sema/src/builtin/decorator.rs

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

[ ] Affects user behaviors
[ ] Contains syntax changes
[ ] Contains variable changes
[ ] Contains experimental features
[ ] Performance regression: Consumes more CPU
[ ] Performance regression: Consumes more Memory
[x] Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

[x] N
[ ] Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

[x] Unit test
[ ] Integration test
[ ] Benchmark (add benchmark stats below)
[ ] Manual test (add detailed scripts or steps below)
[ ] Other

kclvm/tools/src/LSP/src/hover.rs

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

2 of 2 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.007%) to 71.898%

Totals

Change from base Build<PHONE_NUMBER>:
-0.007%

Covered Lines:
44474

Relevant Lines:
61857

💛  - Coveralls


Disable linter

How do i disable linter? It is really annoying.

You can disable the linter through the usual settings files.

@Varrinout, i closed topic because already managed to do that.


The day of Month goes wrong with L last day of month

expr := "30 9 L */3 *"

tick, err := gronx.NextTickAfter(expr, time.Date(2023, 4, 1, 0, 0, 0,0,time.Local), true)
if err != nil {
return
}

fmt.Println(tick)

Result is 2023-06-30 09:30:00 +0800 +08 which is correct.
But change the time as 5 May, then the result will be 2023-09-30 09:30:00 +0800 +08 which is wrong

thanks, i think it is because of month 05 (May) has 31 days and month 04 (April) has 30 days.
the L for 5 is 31 and when it bumps month it becomes 06-31 which is invalid for June, so next valid is 09-30.
would you be willing to contribute a fix? thanks

@adhocore please what is the status of this is bug?


Scales on the left.

Hi, is there a good reason (and I'm sure there is) I wouldn't want to default my scales to the right?

I'd say this is mostly personal preference. You could make the argument that, since most charts will be read left-to-right, left-scales help make sure people know the magnitudes before reading. At the same time, you could argue this way for putting them on the right, since you want people to know the value of the final/recent data point.
Would say it's up to you based on aesthetics. We have also tried to make the scale settings pretty abstract, namely it asks for primaryScale and secondaryScale versus left and right, so it should be configurable to make right the default.

Thanks. I might try to get it right-aligned. I looked around - where does it specify that primaryScale is left-aligned? I can't seem to find it.

I'm not sure how well we've tested this, but the default axis locations are defined here https://github.com/Quartz/Chartbuilder/blob/dadc6f99649b10927b961d2d255b36033d05f8b4/src/js/charts/cb-xy/draw-xy.js#L64-L67
For the record, I'm on team right axis first.

Yes, I'm team right axis first too.
I've swapped this around and it seems to ignore my instruction.
It also brings up a console error if you try and force all axes to be right-hand side.: "Uncaught TypeError: Cannot read property 'ticks' of undefined"
I tried playing around with the mixin but it clearly yearns for left-hand axis first. Any suggestions?

So I'm having a bit of a hard time convincing myself that we should "fix" this or whether we should just remove the (broken) feature entirely.
Where it stands right now: The branch referenced above kinda closes this issue. It gives a way to define primary as either left or right that works (although not in a DRY way at the moment) however if you switch off default left-as-primary the chart will look broken, because that change requires changes to the default margin, padding, and post-render axis adjustments.
Of course, picking which side the axis should be on first is a nice option to have but the amount of customization needed to make it work properly out of the box makes it feel like it's something that is best left to someone in the midsts of creating a custom xy chart type for their organization.
Anyone have any thoughts on how we should proceed on this?

Hi, I tend to agree with you. It's probably not worth the effort to fix and make a default to the right-hand side. An alternative would be to have an option to show the exact number of the final datapoint on the right-hand side? Ed.


[ONNX] add test images to repo

This is better than the status quo:

Test doesn't download files from the internet -> faster and more
reliable.
Test doesn't leave the git working directory dirty.

Making the same change to PyTorch here: pytorch/pytorch#61553

@fmassa could you PTAL?

Rebased and resolved conflicts. Please pull when ready.

Thanks @garymm !


Tab completion should suggest unambiguous path

With version 1.1.5, switching between tab completion suggestions only yields the name of the deepest directory. This is not sufficient to unambiguously identify the directory in question, so if you have e.g. the following directories in history:

E:\depot\git\TypeScript
E:\depot\untracked\typescript11821

There is no way to tab select E:\depot\git\TypeScript. Selecting either option takes you to E:\depot\untracked\typescript11821.

Thanks for submitting this issue.
z will chose a directory based on 'frecency', unless you are explicit with the -Option parameter.
I just tried your directory structure by creating the same folder names and indeed, doing a z typescript did go to typescript11821, however, if I 'cd' into 'typescript' a few times then it will have a higher rank and will be chosen in favour of typescript 11821

@vincpa Yes, but if I wanted to go to the closest match I wouldn't be using tab selection anyway, I'd just do z typescript. In this particular case I did z typescript, realize the best match is not the one I need, and now need to go to a different match. I don't think cd-ing to the other folder manually an indeterminate number of times is a good workflow for choosing between multiple options that are all used frequently.

z is about chosing a match based on frequency of access as determined by this formula
https://github.com/vincpa/z/blob/master/z.psm1#L383
You shouldn't have to cd in to a directory to get a higher rank. I agree, this is a bad workflow. You can press  multiple times to get to your selection based on frequency.
I'm sorry if I don't understand the problem you're having. Perhaps you can make a change to the script via a PR or explain it a bit further with a full example with repeatable steps.

@vincpa Hopefully a recording will help explain better: https://y8xx7w.by3302.livefilestore.com/y3muzHoUhfrjrgX2AqGmN7ElKwUJ7W2XFkpcidqShC4bElV-8PEDCtMLeSVtLrrSpm4D8xE4emveD2Mp67SiQNUEilg-xqhM1B-jkJm0AWAcp3hUkdSPc0gwmTb81TTW-CVIn7Hhc8E_0o72cY_FT69pxqCn4jo687HIJ7s5rkkwCI/2016-10-24_21-39-00.gif?psid=1
I understand that z uses a particular formula to order matches according to usefulness, which is excellent. However, when an option is selected using tab completion (implemented in #17), the user should be taken to the option that they explicitly selected, instead of once again to the most 'frecent' match. If tab selection is also going to take you to the most 'frecent' match, instead of allowing you to explicitly select which match you want to navigate to, there is no point to having tab selection.

I understand what you are saying now. Thanks for that video :)
Suppose you have two directories with the same name, such as "Temporary
Internet Files" which exists for different versions of .NET. What does
explicit selection then mean? The whole purpose of tab is to present you
with a list in order of 'frecency'.
I do however see usefulness in what you are saying. Let me see if I can fix
this behaviour.
On 25 October 2016 at 12:45, Asad Saeeduddin<EMAIL_ADDRESS>wrote:

@vincpa https://github.com/vincpa Hopefully a recording will help
explain better: https://y8xx7w.by3302.livefilestore.com/
y3muzHoUhfrjrgX2AqGmN7ElKwUJ7W2XFkpcidqShC4bElV-
8PEDCtMLeSVtLrrSpm4D8xE4emveD2Mp67SiQNUEilg-xqhM1B-
jkJm0AWAcp3hUkdSPc0gwmTb81TTW-CVIn7Hhc8E_0o72cY_
FT69pxqCn4jo687HIJ7s5rkkwCI/2016-10-24_21-39-00.gif?psid=1
I understand that z uses a particular formula to order matches according
to usefulness, which is excellent. However, when an option is selected
using tab completion (implemented in #17
https://github.com/vincpa/z/issues/17), the user should be taken to the
option that they explicitly selected, instead of once again to the most
'frecent' match. If tab selection is also going to take you to the most
'frecent' match, instead of allowing you to explicitly select which match
you want to navigate to, there is no point to having tab selection.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/vincpa/z/issues/28#issuecomment-255913685, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAa9d-p2nyi3FyVV52J7VfI5CKaMhWmRks5q3V9EgaJpZM4KfapC
.

Suppose you have two directories with the same name, such as "Temporary
Internet Files" which exists for different versions of .NET. What does
explicit selection then mean?

I would still want to be able to select either of them via tab selection, as differentiated by the full path. Thanks for considering the change.
My personal suggestion would be to do the following:

Change the behavior of the positional -JumpLocation argument in the following way: if the argument can be parsed as a rooted path (e.g. ../foo or ./foo or C:/foo/bar), forward the arguments to cdX. Otherwise, treat as a regex as usual
Change the behavior of tab completion so that the full path is suggested instead of only the name of the deepest directory. E.g. instead of tab completion suggesting z typescript, suggest z E:\depot\git\typescript

Two suggestions implemented. Closing ticket and will create a release shortly on PowerShell gallery. Thank you for your useful suggestions.


Increase discoverability of CI pipeline in README

Spelling this out in the README is arguably nicer for users who are either searching the README or typing something like cloud foundry ci pipeline into a search engine.

@fj Hey, could you open this PR against the develop branch please?  See https://github.com/cloudfoundry/cf-release#contributions for more details.

@Amit-PivotalLabs Done, apologies for missing that step.


Make npm run dev fast again.

#34 seems to have made npm run dev a bit slower; we should try to see if we can speed it up a bit to make development easier.

Previously, we were running electron background.js directly (i.e. no compilation time); now that we're pulling in things like class-private members we need it.  Currently I'm seeing ~50s from starting npm run dev to preferences window showing up.  It used to be closer to ~8s.

Previously, we were running electron background.js directly (i.e. no compilation time); now that we're pulling in things like class-private members we need it.  Currently I'm seeing ~50s from starting npm run dev to preferences window showing up.  It used to be closer to ~8s.


The delegate file size is zero after restart VM

The flannel runs properly until the VM was restarted, the pod could not delete normally.
We checked the delegate file created by the flannel: /var/lib/cni/flannel/43bd9329948d3095ru40323009fd9s00erer0dd00s9edfad9edss0y9999se9de, found that the file size is 0.
Maybe we can add the sync function in saveScratchNetConf(containerID, dataDir string, netconf []byte), refer to the etcd's code ioutil.WriteAndSyncFile, thanks.
# ls -l /var/lib/cni/flannel
-rw------- 1 root root 238 Jun  8 22:11 f913be9f5cd806f8ac8801f6b6abf51865783be347b3d3f66b0010fc922a06c6
-rw------- 1 root root   0 Jun 12 16:12 43bd9329948d3095ru40323009fd9s00erer0dd00s9edfad9edss0y9999se9de

Makes sense, we'll try to do it in the next weeks


Add xsltLocation parameter to ExternalRules

Following this checklist to help us incorporate your
contribution quickly and easily:

[x] https://issues.apache.org/jira/browse/MENFORCER-507

[x] Each commit in the pull request should have a meaningful subject line and body.

[x] Format the pull request title like [MENFORCER-XXX] - Fixes bug in ApproximateQuantiles

[x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.

[x] Run mvn clean verify to make sure basic checks pass. A more thorough check will
be performed on your pull request automatically.

[x] You have run the integration tests successfully (mvn -Prun-its clean verify).

[x] I hereby declare this contribution to be licenced under the Apache License Version 2.0, January 2004

Would anybody like to review? @slawekjaranowski maybe?

abca51d:

Rebased
Added some docs to enforcer-rules/src/site/apt/externalRules.apt.vm

Would you like to re-review, @slawekjaranowski ?


dispatch: rebalance users with a fixed count

Fixes https://github.com/locustio/locust/issues/2091

Resets the user worker count before rebalancing since _user_gen compares the expected number of fixed count users with the users in self._users_on_workers
Sets self._try_dispatch_fixed = True to include fixed users in the rebalance
Extends TestAddWorker and TestRemoveWorker to add a test for fixed count (which both fail without this commit) - these just copy test_remove_worker_during_ramp_up and test_add_worker_during_ramp_up with a fixed user

Looks fine. @cyberw @mboutet can you review too?

Lgtm, but @mboutet is the user distribution expert :)

LGTM also! Thank you all.


Add script tag after installation but the old user didn't accept write_script_tag scope

I need to add a script tag from my server but from the first version that scope wasn't in the config file...
SO I add it now, and the new user will accept 'write_script_tag' , but how to force old users to accept the same because they already installed app?
They need to uninstall and install again or there is some more elegant way?

You could add a field called "upgraded" to your users table.
Either make a middleware, or do a check when they land on the homepage of your app.
Middleware method... you'd check if upgrade is not yet set, if it isent, then redirect to /authenticate with the shop query param.
Homepage method... display a notice to the customer that they need to click a button to upgrade permissions, if they click it, reidrect to /authenticate with the shop query param.
Force them back through the full authentication flow essentially.
Please move to discussions for any more questions.


Rewriting the VAO (IMeshDataFormatDesc) system for multiple contexts

This is because each thread needs an OpenGL context and VAOs are not shared objects.
So use a per-context hash/cache of VAOs and use separate attribute binding.
Depends on #25  Implementing OpenGL State Tracking

Left to do:

Rename COpenGLVAO.* files


Add Kogito to the list of implementations

Signed-off-by: Ricardo Zanini<EMAIL_ADDRESS>Many thanks for submitting your Pull Request :heart:!
What this PR does / why we need it:
We are adding the Kogito in the list of projects implementing the spec

website updated - https://serverlessworkflow.io/
if the image for kogito is wrong please update from main branch thanks!


Fix refreshing page causes double navigation on workspace page

Details

We always push a new screen if it's not a report screen, so the screen is added twice to the stack.
Fixed Issues

$ https://github.com/Expensify/App/issues/35614
PROPOSAL: https://github.com/Expensify/App/issues/35614#issuecomment-1925645437
Tests

Same as QA Steps

[x] Verify that no errors appear in the JS console

Offline tests

Same as QA Steps
QA Steps

Web/Desktop/mWeb
Resize you web/desktop to small screen

Go to settings page and select any workspace
Open reimbursement menu
Refresh the page
Press back button
Verify you are navigated to workspace setting page

Android/iOS
Can't refresh

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

https://github.com/Expensify/App/assets/50919443/5eaefba0-db8d-4198-9d22-1cef231dd9db

iOS: Native

iOS: mWeb Safari

https://github.com/Expensify/App/assets/50919443/f890ebd9-7386-4cc7-ac4a-48a99f6735b8

MacOS: Chrome / Safari

https://github.com/Expensify/App/assets/50919443/ce749c38-6b68-4370-908b-6ef5de66667b

MacOS: Desktop

https://github.com/Expensify/App/assets/50919443/1cb333d7-2402-4613-b62e-6914ab2e5628

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by https://github.com/hayata-suenaga in version: 1.4.42-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/chiragsalian in version: 1.4.42-5 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


Update chainlist

[x] https://github.com/Koniverse/SubWallet-ChainList/issues/339
[x] https://github.com/Koniverse/SubWallet-ChainList/issues/340
[x] https://github.com/Koniverse/SubWallet-ChainList/issues/341
[x] Update GSX (G6 testnet) logo

DOTON (JAMTON) holder: tg6ncJa93YqL5thZW4x9Ndo5WZFmkJF51JEaJpnewvdq1vUGD
XTZ(Etherlink) holder: 0x5d66Ec78664F4a0b0929a41270316a6CD4d8BD4b
DOT(Polkadot People) holder: 13xAUHVDyG1v9LLHYtMm7XZFyKNVxoj47oWV431XQ9kjXN38
LAOS (EVM) holder: 0x28E0E629c97601713642A2950eeE6520C4487387
LAOS holder: 0xAbf2D779EAB95ef6CfA4af8b787DB0186200ecB9

Version test: v1.3.8(http://<IP_ADDRESS>:8900/s/XfmGoA73zAGC3LD)

[ ] Add multi-chain asset LOVA token
[ ] Re-check multi-chain asset VBNC (add account have balance)

Version test: v1.3.8 merge
Validation passed.

Add support for JAMTON network

Add support for Etherlink network

Add support for Polkadot People network

[ ] Update GSX (G6 testnet) logo


Modules should return assets and liabilities through admin routes

We're currently returning net_assets to the admin routes we use for the guardian UIs, modules should return assets and liabilities and any net calculations can be done client side.

Thanks for flagging 👍
We should consider this as part of https://github.com/fedimint/fedimint/issues/4283

Imo we should just require modules to either hold assets or liabilities (for one asset type, if we implemented multi-asset support modules could hold assets of one type and liabilities of another), then we can just use the sign on the amount to distinguish.


Fix a comment in heap.js

In a min heap, where smaller keys rise to the top, the up-heap operation should move the parent of a node down if the parent is greater than the node.

@googlebot I signed it!


[Function Expose] Codeunit 8906 - Email Editor - GetRelatedAttachments (Reopen)

Dear ALAppExtensions team,
Through this issue we would like to request procedure GetRelatedAttachments(EmailMessageId: Guid; var EmailRelatedAttachmentOut: Record "Email Related Attachment") to be exposed.
We would like to retrieve the attachments for when we are sending e-mails with attachments via code. It is now not possible to retrieve the related attachments.
Could you please expose this procedure or add a wrapper procedure in another public codeunit that exposes this?
As another alternative, perhaps you could expose the following event publishers which allow for retrieving the attachments?
    /// <summary>
    /// Integration event to get the names and IDs of attachments related to a source record.
    /// </summary>
    /// <param name="SourceTableId">The table number of the source record.</param>
    /// <param name="SourceSystemID">The system ID of the source record.</param>
    /// <param name="EmailRelatedAttachments">Out parameter to return attachments related to the source record.</param>
    [IntegrationEvent(false, false)]
    internal procedure OnFindRelatedAttachments(SourceTableId: Integer; SourceSystemID: Guid; var EmailRelatedAttachments: Record "Email Related Attachment")
    begin
    end;

    /// <summary>
    /// Integration event that requests an attachment to be added to an email.
    /// </summary>
    /// <param name="AttachmentTableID">The table number of the attachment.</param>
    /// <param name="AttachmentSystemID">The system ID of the attachment.</param>
    /// <param name="MessageID">The ID of the email to add an attachment to.</param>
    [IntegrationEvent(false, false)]
    internal procedure OnGetAttachment(AttachmentTableID: Integer; AttachmentSystemID: Guid; MessageID: Guid)
    begin
    end;

Thank you in advance. This would be very useful for extensibility with regards to e-mailing from BC.
And in reply to the question in https://github.com/microsoft/ALAppExtensions/issues/18049 (I was partially on holiday, therefore the delayed response): This would help us to some extent, but we would still need these events for automated mailing, which is why I am reopening this.

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.
Build ID: 49467.


Dialogue Stuck in Loop

Describe the bug
When the dialogue ends, it starts from the first title again.
Affected version

Dialogue Manager version: 2.31.0
Godot version: 4.1

To Reproduce
Steps to reproduce the behavior:
My dialogue file:
~ start

hello
this is a test dialogue file
how are you today
=> END

This loops once the end has been reached. I think the problem is in  lines 324-326 of dialogue_manager.gd
# Key is blank so just use the first title
if key == null or key == "":
  key = resource.first_title

When the conversation ends, key is set to an empty string for me. This if clause causes it to loop around to the beginning instead of ending. Is this intentional? Commenting this if clause out fixes the issue for me

I can't seem to replicate the looping that you're seeing with that dialogue snippet. The => END line should be encoded with the "end" jump and not null or "" anyhow.
If you open the matching tres file in the .godot/imported folder, can you paste in the contents?

When the conversation ends, key is set to an empty string for me. This if clause causes it to loop around to the beginning instead of ending. Is this intentional? Commenting this if clause out fixes the issue for me

I am also having this problem. Just installed this addon today. Even the example dialog the addon comes loaded with loops when I run the dialog in my scene. However when running with the 'Test Dialog' it seems to work fine.

@Joshua-Dugas Can you paste the contents of the corresponding tres file in your .godot/imported folder?

@Joshua-Dugas Can you paste the contents of the corresponding tres file in your .godot/imported folder?
 I've got bad news bosssssss...",
"text_replacements": ArrayDictionary,
"translation_key": "Oh no you are awake! I've got bad news bosssssss...",
"type": "dialogue"
},
"4": {
"character": "Scrugz",
"character_replacements": ArrayDictionary,
"id": "4",
"next_id": "5",
"parent_id": "2",
"tags": PackedStringArray(),
"text": "It seems you accidentally drank that sleep potion on the table.",
"text_replacements": ArrayDictionary,
"translation_key": "It seems you accidentally drank that sleep potion on the table.",
"type": "dialogue"
},
"5": {
"character": "",
"character_replacements": ArrayDictionary,
"id": "5",
"next_id": "7",
"parent_id": "2",
"tags": PackedStringArray(),
"text": "I know, I know! It looks just like your wine jug but I think I misplaced the wine and
accidentally filled your jug with the sleep potion from the shelf. Whoops!",
"text_replacements": ArrayDictionary,
"translation_key": "I know, I know! It looks just like your wine jug but I think I misplaced the wine and
accidentally filled your jug with the sleep potion from the shelf. Whoops!",
"type": "dialogue"
},
"7": {
"character": "Scrugz",
"character_replacements": ArrayDictionary,
"id": "7",
"next_id": "8",
"parent_id": "2",
"tags": PackedStringArray(),
"text": "Who am I!? I am your housekeeper and have been for years!",
"text_replacements": ArrayDictionary,
"translation_key": "Who am I!? I am your housekeeper and have been for years!",
"type": "dialogue"
},
"8": {
"character": "Scrugz",
"character_replacements": ArrayDictionary,
"id": "8",
"next_id": "9",
"parent_id": "2",
"tags": PackedStringArray(),
"text": "The nerve....",
"text_replacements": ArrayDictionary,
"translation_key": "The nerve....",
"type": "dialogue"
},
"9": {
"character": "Scrugz",
"character_replacements": ArrayDictionary,
"id": "9",
"next_id": "11",
"parent_id": "2",
"tags": PackedStringArray(),
"text": "Anyhow you have been out cold for months and the place is in disrepair.
Also all of your dogs got out...",
"text_replacements": ArrayDictionary,
"translation_key": "Anyhow you have been out cold for months and the place is in disrepair.
Also all of your dogs got out...",
"type": "dialogue"
}
}
metadata/dialogue_manager_version = "2.31.0"`

@Joshua-Dugas That appears to be fine. Can you share the code you're using to run the dialogue in your scene?

@nathanhoad  sure thing!
`extends Area2D
@export var dialogue_resource: DialogueResource
@export var dialogue_start: String = "lizard_npc"
func action() -> void:
DialogueManager.show_example_dialogue_balloon(dialogue_resource, dialogue_start)`
And here is the dialog script itself(I've tried without the double 'end' statements as well was just trying anything):
~ lizard_npc if has_met_scrugz == false 	Scrugz: Oh no you are awake! I've got bad news bosssssss... 	Scrugz: It seems you accidentally drank that sleep potion on the table.  	I know, I know! It looks just like your wine jug but I think I misplaced the wine and  		accidentally filled your jug with the sleep potion from the shelf. Whoops! 	Scrugz: Who am I!? I am your housekeeper and have been for years! 	Scrugz: The nerve.... 	Scrugz: Anyhow you have been out cold for months and the place is in disrepair.  		Also all of your dogs got out... 	Scrugz: If I were you I would get ready and go find those dogs! 	set has_met_scrugz = true => END else 	Scrugz: You should probably get ready... => END

If you put a log inside action(), just before calling show_example_dialogue_balloon I'm going to guess that it will log each time the dialogue is "looping". My assumption is that the dialogue itself isn't looping but your action method is being run instantly once the dialogue finishes. Are you handling input via _unhandled_input?

I'm closing this until there is reproducible as an actual bug.


Fix #118: Re-instate service override functionality

I would much rather fix this via #120.  This issue however points out a huge difference in the way services are loaded for passthrough versus multi-process.  We should do the workaround now but revisit so that both have the same behavior.

Fixed by #120


ASP.NET 5

I’d like to use this project in aspnet 5 applications.
I’ve started by trying to get everything to build in the dnx4.5.1 framework using the new project structure.  I’ll post my project.json file below. I've found it easier to start with dnx4.5.1 rather then to try to flesh out all the kinks using both dnx4.5.1 and dnxcore50 simultaneously.
I’ve replaced Microsoft.VisualStudio.TestTools.UnitTesting with Xunit.  It seems that Xunit is generally the recommended framework for testing aspnet 5 applications.
https://github.com/aspnet/Testing
http://blogs.msdn.com/b/webdev/archive/2015/08/06/unit-testing-with-dnx-asp-net-5-projects.aspx
After everything is building on 4.5.1 using the new project structure and all tests are passing, my plan is  to add ‘ dnxcore50’ as an additional framework in the project.json file and continue to weed out the problems.
This is my first time porting a project to aspnet 5 and would welcome advice on how best to go about this.  I'm currently stuck trying to get everything to run on dnx4.5.1..
Current project.json file:
{
"version": "2.0.0-*",
"description": "A .NET NoSQL Document Store in a single data file",
"authors": [ "Maurício Davi" ],
"tags": [ "LiteDB", "NoSQL" ],
"projectUrl": "https://github.com/mbdavid/LiteDB",
"dependencies": {
"xunit": "2.1.0",
"xunit.runner.dnx": "2.1.0-beta5a-build188"
},
"commands": {
"test": "xunit.runner.dnx"
},
"frameworks": {
"dnx451": { }
}
}

#86


Accessibility

I work on test automatization and timepicker items are not accessible and can't be inspected using Appium inspector.

Anyone working on this?

Created PR for this https://github.com/xgfe/react-native-datepicker/pull/258


fix: initial scrollbar behaviour in inactive tab

Channel views could sometimes have their scrollbar be at the top instead
of bottom when they were first activated if it had messages in it
Scrollbars now assume their default behaviour is: "I'm scrolled down to the bottom" - this seems reasonable & fixes the issue


[DO NOT MERGE] canary build images if not found by compat

Canary:

remove slack logs
stacked on previous PRs, edits in a813bb4

/canary

:broken_heart: Test Failed - commit-workflow


[BUG] VM only shows the IPV6 address

Describe the bug
When the VM has been assigned with both IPV4 and IPV6 addresses, by default the VMI will only store the IPV6 address, it should store both.
 conditions:
  - lastProbeTime: null
    lastTransitionTime: "2021-09-08T10:51:50Z"
    status: "True"
    type: Ready
  - lastProbeTime: null
    lastTransitionTime: null
    status: "True"
    type: LiveMigratable
  guestOSInfo: {}
  interfaces:
  - ipAddress: fd31:f874:bf29:0:14df:8ff:fefe:a2bf
    ipAddresses:
    - fd31:f874:bf29:0:14df:8ff:fefe:a2bf
    mac: 16:df:08:fe:a2:bf
    name: default

==== VM info ====
ubuntu@vmtest1:~$ ip a
1: lo: <LOOPBACK,UP,LOWER_UP> mtu 65536 qdisc noqueue state UNKNOWN group default qlen 1000
    link/loopback 00:00:00:00:00:00 brd 00:00:00:00:00:00
    inet <IP_ADDRESS>/8 scope host lo
       valid_lft forever preferred_lft forever
    inet6 ::1/128 scope host
       valid_lft forever preferred_lft forever
2: enp1s0: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1500 qdisc pfifo_fast state UP group default qlen 1000
    link/ether 16:df:08:fe:a2:bf brd ff:ff:ff:ff:ff:ff
    inet <IP_ADDRESS>/16 brd <IP_ADDRESS> scope global dynamic enp1s0
       valid_lft 83428sec preferred_lft 83428sec
    inet6 fd31:f874:bf29::c0b/128 scope global dynamic noprefixroute
       valid_lft 40230sec preferred_lft 40230sec
    inet6 fd31:f874:bf29:0:14df:8ff:fefe:a2bf/64 scope global mngtmpaddr noprefixroute
       valid_lft forever preferred_lft forever
    inet6 fe80::14df:8ff:fefe:a2bf/64 scope link
       valid_lft forever preferred_lft forever
3: tunl0@NONE: <NOARP> mtu 1480 qdisc noop state DOWN group default qlen 1000
    link/ipip <IP_ADDRESS> brd <IP_ADDRESS>
4: sit0@NONE: <NOARP> mtu 1480 qdisc noop state DOWN group default qlen 1000
    link/sit <IP_ADDRESS> brd <IP_ADDRESS>

To Reproduce
Steps to reproduce the behavior:

create a VM e.g with ubuntu focal image
set the first network to use VLAN network
create the VM and wait for it to be ready.

Expected behavior

the VMI should include both the IPV4 and IPV6 address

Support bundle

Environment:

Harvester ISO version:
Underlying Infrastructure (e.g. Baremetal with Dell PowerEdge R630):

Additional context
Add any other context about the problem here.

@guangbochen I cannot reproduce this issue on my setup (Harvester deployed as a KVM VM). Does the VM has guest agent installed?
Without the guest agent, the VMI has no ipAddresses info:
  guestOSInfo: {}
  interfaces:
  - mac: ea:9c:c7:ea:64:47
    name: default

With the guest agent, both IPv4 and IPv6 are there:
  guestOSInfo:
    id: ubuntu
    kernelRelease: 5.4.0-84-generic
    kernelVersion: '#94-Ubuntu SMP Thu Aug 26 20:27:37 UTC 2021'
    name: Ubuntu
    prettyName: Ubuntu 20.04.3 LTS
    version: "20.04"
    versionId: "20.04"
  interfaces:
  - interfaceName: enp1s0
    ipAddress: <IP_ADDRESS>
    ipAddresses:
    - <IP_ADDRESS>
    - fe80::605c:67ff:fee2:aeb6
    mac: 62:5c:67:e2:ae:b6
    name: default

Move to v1.0.0 due to unable to reproduce.

close as this is no longer reproducible with the v1.1.0 version.


Check batch requests return same number of results

It could be possible that a batch request returns less results than the number of payloads
We should catch and log those if that's the case

It seems that the tests need to be adjusted.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>4
Warning: This coverage report may be inaccurate.
This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

For more information on this, see Tracking coverage changes with pull request builds.
To avoid this issue with future PRs, see these Recommended CI Configurations.
For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

12 of 15 (80.0%)  changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.03%) to 93.52%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

safe_eth/eth/ethereum_client.py
8
11
72.73%

Totals

Change from base Build<PHONE_NUMBER>0:
-0.03%

Covered Lines:
8991

Relevant Lines:
9614

💛  - Coveralls


issues/23: render unformatted //test comment correctly

What(What have you changed/added/removed?)

render unformatted //test comment correctly
Previously if you had a go.mod file like

module someModule
require (
    golang.org/someNonTestModule v0.4.2 //test
)

When you run ote on it, it would render as;
module someModule
require (
    golang.org/someNonTestModule v0.4.2 //st
)

ote would be unable to remove the //test comment completely because there was no space between the // and test

This is a bug inherited from the golang.org/x/mod code[2]

Why(Why did you change/add/remove it?)

Fixes: https://github.com/komuw/ote/issues/23
https://github.com/komuw/ote/blob/ae34c4ef8690fb90ddf0aaf55b8e7402639695da/comment.go#L13-L16

Codecov Report

Merging #24 (d6bcbd0) into main (ae34c4e) will not change coverage.
The diff coverage is 100.00%.

:exclamation: Current head d6bcbd0 differs from pull request most recent head 4a9e929. Consider uploading reports for the commit 4a9e929 to get more accurate results

@@           Coverage Diff           @@
##             main      #24   +/-   ##
=======================================
  Coverage   53.55%   53.55%
=======================================
  Files           5        5
  Lines         239      239
=======================================
  Hits          128      128
  Misses         89       89
  Partials       22       22

Impacted Files
Coverage Δ

comment.go
87.50% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ae34c4e...4a9e929. Read the comment docs.


Sending test results failed with channel_not_found

We just set up the slack reporter as an app in our Slack workspace, installed the npm module and ran the tests with the OAuth token generated by the app, however the Slack reporter seems to be unable to find the channel I set up for it:
[   {     "channel": "test-results",     "outcome": "❌ Message not sent to test-results \r\n An API error occurred: channel_not_found"   } ]
We just changed the channel visibility to private, could that be the reason why? Does the channel need to be public for the bot to work? Or could it be some other issue?

hey @azad-derakhshani-GS
I was able to reproduce this.

Yes, you are correct.  The channel you are posting to will need be Public.  Unfortunately, there doesn't seem to be an easy way to convert a private change into a public channel.
"https://twitter.com/slackhq/status/835541575144992769?lang=en"
You may need to create another public channel instead.
I'll update the instructions in the readme to mention this restriction.

Ah ok thanks, that's good to know!
Oh wow didn't know turning them back to public is not possible, what an odd restriction of Slack. I'll ask our Slack admins to create a new channel for me then.

Ok it worked with a public channel now!
Closing this issue.
However I've got a few questions regarding the custom layout, I followed the instructions but my IDE throws some errors even when I just copy-paste the examples.
Should I just create an issue for that - possibly with some suggestions for the documentation - or contact you elsewhere? @ryanrosello-og


[build-presets] Disabled SourceKit-LSP tests for all SwiftPM Linux jobs

Disable SourceKit-LSP testing for everything that uses mixin_swiftpm_linux_platform instead of mixin_swiftpm_package_linux_platform.

@swift-ci Please smoke test


Re-add additionalVolumes and additionalVolumeClaims; absence breaks major functionality for power users

Details
Helm chart name:
common
Describe the solution you'd like:
I agree the current persistence code works very well for most users most of the time; but it seriously breaks things for power users; and the workarounds necessary to make every configuration possible within the confines of persistence are IMO nowhere near worth it.
The forced pairing between volumes and volumemounts is fundamentally incompatible with most workarounds that could be made. Separating the concept of a mount and volume is required for a functional solution, but would be unnecessarily confusing for most users.
IMO best solution is just re-adding a way to specify volumes and volumemounts in standard yaml as is common in many other charts.
Anything else you would like to add:
persistence cannot properly define complex CSI volumes, nor even handle mounting one volume multiple times.
I can whip up a PR if this is received well.

Didn't see #65 ; only searched additionalVolumes.
Just read it; I still think this is just as valid.
We do not want to support interpolating every possible parameter for CSI while also providing mechanisms to conditionally exclude assumed-necessary arguments while recreating the conceptual split between volumes and mounts in a user-facing way.
Not when two 3-line escape hatches exist that even match common practices.

Hi! Thanks for taking the time to write up this issue.
Specifying complex CSI volumes should very well be possible by using the custom persistence type: http://docs.k8s-at-home.com/our-helm-charts/common-library-storage/#custom
Whilst I agree that a small bit of functionality might have potentially been "lost" with the removal of these two keys, I am still curious for any real-world examples you can provide.


Use the JEST test to find Referenceer: ATYPOGRAPHY is not defined

@bit-ocean/auto-import configure:

jest use:

components use:

@bit-ocean/auto-import automatically imports the antd component. Use the JEST test to find Referenceer: ATYPOGRAPHY is not defined
How to solve it? @recallwei

Reference: https://github.com/recallwei/unplugin-auto-import-antd/issues/4#issuecomment-2265601706


MAINT: Import BoundedSemaphore from gevent.lock.

gevent.coros was moved to gevent.lock as of 2012.  Importing from
gevent.coros raises a DeprecationWarning indicating that the module
has been moved.

c.f. https://github.com/gevent/gevent/commit/b02a047cd0194553e2b1a7096cc5aaf3e94733ed

Repro:
In [1]: from warnings import simplefilter

In [2]: simplefilter('always')

In [3]: from logbook.concurrency import *
/home/ssanderson/.virtualenvs/qexec/local/lib/python2.7/site-packages/logbook/concurrency.py:37: DeprecationWarning: gevent.coros has been renamed to gevent.lock
  from gevent.coros import BoundedSemaphore

Thanks!


Versions chromebook 13

Here is my experience with a Acer ARM chromebook 13:
ubuntu 12.04 precise unity - works
update 14.04 unity - do not work
ubuntu 16.04 unity - do not work
ubuntu 16.10 unity - do not work

ubuntu 16.10 xfce - works !

That hasn't been my experience.
I'm not sure if you're just posting your findings, which is fine, or if you want help getting unity to work on the other releases???
If you want help give us some more details about what failed, etc.
Hope this helps,
-DennisL

It was just a summary of current experience.

System chromebook Acer 13:
32 GB Harddisk
4 GB Memory
current crouton version
encrypted chroot
Asus Chromebook C 300 ubuntu 16.04 unity - works !

Cool, I'll close this non-issue then.


Add back hot reloading for Scenes

SceneSpawner refactor
This PR reworks the scene_spawner.rs module in bevy_scene. After
hunting for the bug causing #3759, I determined that it was the
culprit. Having difficulties parsing the code myself, I decided
to refactor it.
Relationship with merging of Scene and DynamicScene
There has been discussion about getting rid of either Scene or
DynamicScene, or merging the two.
This PR does not merge Scene and DynamicScene it only limits
itself to refactoring scene_spawner.rs. However, the changes
introduced will likely make it easier to transition to an
implementation where only a single Scene type exists.
Improvements

Merge code in SceneSpawner for managing DynamicScene and Scene.

Add back hot reloading for Scenes, fixes #3759

Add documentation to SceneSpawner methods.
Add write_to_world method to Scene (does the same as DynamicScene::write_to_world)

Tests
The tests would require manipulating ResMut<Assets<T>>, which I don't
know how to do. So I left them out.
Further cleanup
Removing duplication in API surface
An earlier version of this PR merged the SceneSpawner::dynamic_foo and
SceneSpawner::foo methods by making them generic over the handle they accept.
However, it was judged too burdensome for the user. It required adding type specification
on existing code, since it doesn't play nice with asset_server.load() which introduces
an unbound type variable.
User migration guide
After the second commit, the migration guide consists of:

Change all calls to SceneSpawner::despawn to SceneSpawner::despawn_dynamic (note that you should be using SceneBundles and removeing the Handle<Scene> and Handle<DynamicScene> component instead in any case)

Question for reviewers

Should we revert the <T: Into<SceneHandle>> change? Now that scenes are mostly added through SceneBundle, there is not as much use of the SceneSpawner API with unbound generic types.

I'm going to remove the generic parameter. I don't like it and I think it's a major ergonomic loss. I'll not rebase so that it's possible to revert the removal if deemed appropriate.

@nicopap merge conflicts, sorry! Should be simple ones.

[11:29 AM] Gibooonus: I updated the test case I designed in #3759 with more entities, and now it just crashes

Removing the Ready-For-Final-Review label until this is fixed.

This will require an entire rewrite soon enough. I'll close it


FIX: get releases with changelog instead of just the tag

It used to work until 12.0.6 but then it changed, fix it. It's not really a huge change but it was nicer.

Not fixed as expected with the plugins, needs more work.


Line numbers for validation input

After using the online validator for the first time recently, I thought it would be really useful if the textarea with the to-be-validated content would also display line numbers - especially since the validation errors reference line numbers in the input.

Perhaps something like CodeMirror could be added without too much trouble.

I agree with this completely. It will be the next issue I take on. Thank you for the feedback.


[BUG] debug messages (console.log) currently do not show

Due to a recent update to the test-runner, these messages do not show. Working on a fix. You can subscribe to the issue on the right side of the screen to get an update when it is fixed.


[Dubbo Compatible with hessian1] Fix hessian1 serialized short, byte is converted to int

What is the purpose of the change

Fix hessian1 serialized short, byte is converted to int, compatible with hessian1, see: https://github.com/apache/incubator-dubbo/issues/1609

Brief changelog

HessianInput for hessian1 protocol, compatible with hessian2

Verifying this change

com.alibaba.com.caucho.hessian.io.Hessian1StringShortTest
2.com.alibaba.com.caucho.hessian.io.Hessian2StringShortTest

Follow this checklist to help us incorporate your contribution quickly and easily:

[x] Make sure there is a GITHUB_issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
[x] Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
[x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
[x] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
[x] Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test  to make sure integration-test pass.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

Codecov Report

Merging #1616 into master will increase coverage by 0.27%.
The diff coverage is 41.37%.

@@             Coverage Diff             @@
##             master   #1616      +/-   ##
===========================================
+ Coverage     34.52%   34.8%   +0.27%
- Complexity     3685    3719      +34
===========================================
  Files           621     621
  Lines         30875   30892      +17
  Branches       5448    5466      +18
===========================================
+ Hits          10660   10752      +92
+ Misses        18376   18287      -89
- Partials       1839    1853      +14

Impacted Files
Coverage Δ
Complexity Δ

...om/alibaba/com/caucho/hessian/io/HessianInput.java
19.58% <41.37%> (+6.36%)
42 <7> (+17)
:arrow_up:

...ba/dubbo/remoting/transport/netty/NettyClient.java
74.13% <0%> (-8.63%)
12% <0%> (-1%)

...libaba/com/caucho/hessian/util/IdentityIntMap.java
25% <0%> (-5.96%)
5% <0%> (-2%)

...rpc/protocol/dubbo/telnet/InvokeTelnetHandler.java
51.89% <0%> (-3.8%)
11% <0%> (-2%)

...m/alibaba/com/caucho/hessian/io/Hessian2Input.java
18.61% <0%> (+0.58%)
60% <0%> (+2%)
:arrow_up:

...alibaba/com/caucho/hessian/io/MapDeserializer.java
50.87% <0%> (+1.75%)
13% <0%> (+1%)
:arrow_up:

...ibaba/com/caucho/hessian/io/SerializerFactory.java
64.76% <0%> (+3.91%)
51% <0%> (+5%)
:arrow_up:

...a/dubbo/remoting/transport/netty/NettyChannel.java
66.25% <0%> (+5%)
21% <0%> (+1%)
:arrow_up:

...om/alibaba/dubbo/rpc/filter/ActiveLimitFilter.java
83.33% <0%> (+5.55%)
6% <0%> (+1%)
:arrow_up:

... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4d885b8...0c0ec6b. Read the comment docs.

Looks good to me!

I will merge this PR. We can remove hessian1 from dubbo lately, what do you think? @diecui1202

Yes, firstly, we can deprecated hessian1, then delete it in next major release.


Why return a caches.match when failed to fetch?

I don't understand this line:

from here: https://github.com/mdn/sw-test/blob/gh-pages/sw.js#L37
Can someone help me out?

Hi there @trungdq88 ,
This is a fallback if the network is not available and a fetch attempt is made on an image that can't be fetched. If that is the case, this image will be served instead, which we cache when the service worker is first installed.
It's a bit trivial, but at least illustrates a fallback concept.


Really backport PRs 134 135 139 138 140 to swift-3.0-branch

held github wrong in #145 and merged to the wrong branch...

the ci failure is unrelated to libdispatch, it built and tested fine:
============================================================================
Testsuite summary for libdispatch 1.3
============================================================================
# TOTAL: 26
# PASS:  26

going ahead with the merge