Basic project structure

Description
Basic structure for ESP32 C++ code

Header files are .hpp
Header files are in include/
Source files are in src/
Following the naming convention of #1

ℹ make sure you have read the contributing guidelines first
Have a look here

Thank you for outlining the project structure. Happy with all the content but was wondering if all the README files (include/README, lib/README, test/README) would be better to be .md files to match the GitHub formatting? I know they didn't use .md files in the platformio-examples, but think this might be a better option?

Good point. I'll update them.

@jamie-54 done


add 3 new psp tools

TODO: Please replace this header with a description of your pull request.
Installation sequence for tool-installers

[ ] Test using @galaxybot test this
[ ] Inspect CI output for expected changes
[ ] Deploy using @galaxybot deploy this if test install was successful
[ ] Merge this PR

@galaxybot test this

you're missing .lock files; check out https://github.com/galaxyproject/usegalaxy-tools?tab=readme-ov-file#requesting-a-new-tool-or-updating-a-tool

@galaxybot deploy this

thanks guys!!


23

What kind of change does this PR introduce? (check at least one)

[x] Bugfix
[ ] Feature
[ ] Code style update
[ ] Refactor
[ ] Build-related changes
[ ] Other, please describe:

Does this PR introduce a breaking change? (check one)

[x] Yes
[ ] No

If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:

[x] It's submitted to the dev branch for v2.x (or to a previous version branch), not the master branch
[ ] When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)
[x] All tests are passing: https://github.com/vuejs/vue/blob/dev/.github/CONTRIBUTING.md#development-setup
[ ] New/updated tests are included

If adding a new feature, the PR's description includes:

[x] A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

121

Please do not abuse this repo's Pull Requests. Do experiments in your own repo.

Please do not abuse this repo's Pull Requests. Do experiments in your own repo.

sorry！！


Bug: Assertion error

Hi guys,
I am using Boogie to verify my program but have experienced an issue:
It seems the following code should pass the test but the verifier reports that the assertion might not hold... Is this a bug or I missed something?
var array:[int]int;

procedure F(n: int) returns (r: int)
modifies array;
{
  var a:int;
  var b:int;

  assume a < b;

  assume (forall i:int :: 0 <= i && i <= b-a ==> array[i+a] == a+i);
  assert (forall i:int :: a <= i && i <= b ==> array[i] == i);

}

Thanks,
Jianyi Cheng

I do not see any precondition that characterizes the contents of array.  I
would not expect this program to verify.
On Mon, Mar 11, 2019 at 8:19 AM Jianyi Cheng<EMAIL_ADDRESS>wrote:

Hi guys,
I am using Boogie to verify my program but have experienced an issue:
It seems the following code should pass the test but the verifier reports
that the assertion might not hold... Is this a bug or I missed something?
var array:[int]int;
procedure F(n: int) returns (r: int)
{
var a:int;
var b:int;
assume a < b;
assume (forall i:int :: 0 <= i && i <= b-a ==> array[i+a] == a+i);
assert (forall i:int :: a <= i && i <= b ==> array[i] == i);
}
Thanks,
Jianyi Cheng
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/boogie-org/boogie/issues/116, or mute the thread
https://github.com/notifications/unsubscribe-auth/AHURFrVLudAVrV7pfRMXc2MVD7RcW3FCks5vVnPzgaJpZM4bo3Mg
.

Hi @shazqadeer,
Thank you for instant reply!
I am trying to describe a group of array data indexed from a to b is overwritten in the procedure F using assume. The original array data can be arbitrary values. This information can be used for other assertions (so we know array[i] where i >= a && i <= b have certain values).
Maybe I wrote the program in a wrong way? I do not want to unroll the assignments to array[] in a big loop and think that using assume and forall may describe the same conditions.
Interestingly I found Boogie works with the following statements:
assume (forall i:int :: a <= i && i <= b ==> array[i] == i); // cond 2
assert (forall i:int :: 0 <= i && i <= b-a ==> array[i+a] == a+i); // cond 1

Does it means that Boogie takes cond 2 as only the sufficient condition of cond 1 but not necessary condition?
Jianyi

I did not spot the assume before the assert.  The assertion in your program indeed holds.  Sorry for the confusion.
You are running into the problem of incomplete handling of quantifier instantiations in the automated theorem prover behind Boogie.  To prove the assertion  a <= i0 && i0 <= b ==> array[i0] == i0 for an arbitrary i0, the quantifier in the assume statement must be instantiated at i0-a but the theorem prover is not smart enough to figure it out.  This is a well-known limitation and could be addressed by providing an instantiation-triggering expression as follows:
var array:[int]int;
function f(int): bool {
true
}
procedure F(n: int) returns (r: int)
{
var a:int;
var b:int;
assume a < b;
assume (forall i:int :: {f(i)} 0 <= i && i <= b-a ==> array[i+a] == a+i);
assert (forall i:int :: f(i-a) && a <= i && i <= b ==> array[i] == i);
}
Now the prover attempts to prove f(i0-a) && a <= i0 && i0 <= b ==> array[i0] == i0.  The triggering hint expression {f(i)} in the assume statement looks for any expression of the form f(_) and instantiates _ for i in the quantifier.  In this case, i0-a will be chosen and that does the job.

Thank you so much for your solution and explanation!
Great to know what happens behind the scene. :)

The difference between
assume (forall i:int :: 0 <= i && i <= b-a ==> array[i+a] == a+i);

and
assume (forall i:int :: a <= i && i <= b ==> array[i] == i);

is significant.
For the latter, the subexpression array[i] will automatically be selected as a matching trigger. This is good--anytime the verifier sees an expression of the form array[X] for any expression X, it will instantiate the quantifier with i := X.
The former has no good matching trigger for the quantifier. The subexpression array[i+a] is close, but no cigar. To use it as a trigger would be asking the verifier to instantiate the quantifier anytime it sees an expression of the form array[X+a], but since + is an interpreted function symbol, it would only be by luck that you might get an appropriate instantiation. Specifically, in your original program, the verifier is trying to prove something about array[k] (where I'm using k instead of i in your assertion, to avoid name clashes in my explanation). The verifier would then need to invent an X such that X+a equals k, and it won't do that.
In general, try to arrange so that the bound variable you want instantiated sits in a good place, like array[i] or f(i), not array[i+a] or f(i+a). You can read more about matching-trigger considerations here:

K. Rustan M. Leino, Clément Pit-Claudel:
Trigger Selection Strategies to Stabilize Program Verifiers. CAV (1) 2016: 361-381

or here:

Nada Amin, K. Rustan M. Leino, Tiark Rompf:
Computing with an SMT Solver. TAP 2014: 20-35

As described in the CAV paper, the Dafny verifier performs some rewrites of user-provided quantifications in order to get better triggers.
Rustan

@RustanLeino
Thank you so much for the comments and literatures!
It helps a lot!


ng serve - add special header to some files in assets (proxy)

🐞 Bug report
Command (mark with an x)

[ ] new
[ ] build
[x] serve
[ ] test
[ ] e2e
[ ] generate
[ ] add
[ ] update
[ ] lint
[ ] xi18n
[ ] run
[ ] config
[ ] help
[ ] version
[ ] doc

Is this a regression?

I don't know - but probably yes according to this.
Description
I need to add some header to file /assets/unity/webgl.wasm e.g. my-header: some-token-value - this file will not works without this header - so it is important.
🔬 Minimal Reproduction
I try solutions described on internet: in angular.json  I set key projects.my-project.serve.options.proxyConfig: "proxy.config.js"
Then I create "proxy.config.js"
const PROXY_CONFIG = {
  // "/assets/unity/webgl.wasm": {       // I try many combinations of PATH
  // "/assets/*": {
  // "/assets": {
  // "/": {
  // "/*": {
  // "*": {
  "/assets/unity/*.wasm": {
       // "target": "http://my-project:3002/assets",
      "secure": false,
      //"logLevel": "debug",
      "selfHandleResponse": true,
      "onProxyRes": function (proxyRes, req, res) {
          console.log('PRRRRROOOXXXXYYYY RUN');
          proxyRes.headers['Content-Type'] = 'application/json';
          res.headers["X-KKCustom-Header"] = "yes";
        },
      // "bypass": function (req, res, proxyOptions) {
      //   console.log('PRRRRROOOXXXXYYYY RUN');
      //   proxyRes.headers['Content-Type'] = 'application/json';
      //   res.headers["X-KKCustom-Header"] = "yes";
      // },
    },
};

console.log('PRRRRROOOXXXXYYYY INIT');
module.exports = PROXY_CONFIG;

And try run it in many configurations - but not works. After run server I only see

'PRRRRROOOXXXXYYYY INIT'
..
[HPM] Subscribed to http-proxy events:  [ 'proxyRes', 'error', 'close' ]
(if I use bypass I don't see 'proxyRes')

🔥 Exception or Error
Just not works - header is not included to serwer response (and on server console I DON'T see 'PRRRRROOOXXXXYYYY RUN' so I guess onProxyRes/bypass function is never  triggered). I try many combinations of paths, and PROXY_CONFIG fields.
🌍 Your Environment

Angular CLI: 8.0.2
Node: 12.11.1
OS: linux x64
Angular: 8.0.0

I run angular on MacOs High Sierra using inside docker node by:
ng serve --host <IP_ADDRESS> --port 3002 --disable-host-check --poll 1
and outside docker in browser application works on http://my-project.local:3002
Anything else relevant?

Hi @kamil-kielczewski,
You need to add the new header to proxyRes and not res.
See: https://github.com/angular/angular-cli/issues/15095#issuecomment-511967756

@alan-agius4 In above code I use both but I also try with proxyRes, and res separatley - not works (the onProxyRes function is never executed at all)

Hi @kamil-kielczewski,
I had a bit of a look at this and it seems that the middleware proxy in webpack-dev-server is used as fallbacking when a request is not resolved.
You can opt to add this header to all responses using the headers option (https://webpack.js.org/configuration/dev-server/#devserverheaders-) by extending the default Webpack configuration. This can be done using a 3rd party builders such as https://github.com/manfredsteyer/ngx-build-plus or https://github.com/just-jeb/angular-builders

Closing as this is not actionable from our end.
Kindly let me know if you have any further queries.
Thanks.


Quantity dropdown

Is your feature request related to a problem? Please describe.
There is no quantity menu dropdown provided .
Describe the solution you'd like
Add a dropdown menu named Quantity with values ranging from 1 to 5 next to the price written on the products page.

hey @Bhavya1403  could you assign this issue to me ?

You can start working on the issues without requesting to be assigned.


Stability improvements

Increment default ping_timeout time to 10s
Report healthy values at startup, during the first health_check_delay seconds (set to 45)

@lennardseah @giantballofyarn @yangbin @dineshsaravanan

:+1: went through this with Tim

:+1: and merging/deploying this before meltdown

tried on one box - didn't make much of a difference


[Improvement-15692][task-datasync] rewrite the mockito test file for DatasyncTaskTest.

Purpose of the pull request
rewrite the mockito test file for the task-datasync
Brief change log
rewrite the mockito test file for the task-datasync
Verify this pull request
I have tested locally.

linked to #15693

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 39.04%.  Consider uploading reports for the commit 382025a to get more accurate results

Additional details and impacted files
@@             Coverage Diff              @@
##                dev   #15693      +/-   ##
============================================
+ Coverage     38.96%   39.04%   +0.08%
- Complexity     4840     4844       +4
============================================
  Files          1316     1316
  Lines         45010    45010
  Branches       4818     4818
============================================
+ Hits          17539    17576      +37
+ Misses        25575    25527      -48
- Partials       1896     1907      +11

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Hi @Tianqi-Dotes can you add some description for why need to rewrite this UT?


examples: Add gadgets examples

Add some examples showing how to use the Golang packages of our gadgets.
Part of https://github.com/kinvolk/inspektor-gadget/issues/723.

I think I handled all the comments. Please review again :smile:


Clicking on 'fix the errors' button first input border is cut off at the top

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Go to URL https://staging.new.expensify.com/
Login with Expensifail account
Go to Settings => Payments => Add a debit card
Without entering any data, click "Save"
Click on 'fix the errors' button
System should focus on the first input

Expected Result:
The first input should NOT be cut off from above
Actual Result:
The first input is cut off from above
Workaround:
Unknown
Platform:

Where is this issue occurring?

IOS
Android

Version Number: 1.2.30-0
Reproducible in staging?: y
Reproducible in production?: y
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:

https://user-images.githubusercontent.com/43996225/203416843-0f7ba9d7-ad2e-4f50-aab2-2aa895ce5b47.mp4
Expensify/Expensify Issue URL:
Issue reported by: Applause internal team
Slack conversation:
View all open jobs on GitHub

Hmmm its similar but I guess technically different bugs? This PR made changes to the form component. I'm not sure if this was an issue before or after this PR because we only tested it on forms that did not require a scroll

Taking a look!

IMO this is ok and a known drawback of using the focus() method to bring the input into view, instead of a much more complex implementation of scrolling to the input position with an offset. I don't feel strongly about it though and could entertain solutions for scrolling up and adding an offset.

Proposal
As mentioned by @luacmartins, this is a known drawback of using focus method. We can therefore, scroll to the input position - an offset of 10.
diff --git a/src/components/Form.js b/src/components/Form.js
index 4734381bc..afdf1a06f 100644
--- a/src/components/Form.js
+++ b/src/components/Form.js
@@ -1,6 +1,6 @@
 import lodashGet from 'lodash/get';
 import React from 'react';
-import {ScrollView, View} from 'react-native';
+import {ScrollView, View, findNodeHandle} from 'react-native';
 import PropTypes from 'prop-types';
 import _ from 'underscore';
 import {withOnyx} from 'react-native-onyx';
@@ -78,8 +78,8 @@ class Form extends React.Component {
         };

         this.inputRefs = {};
+        this.scrollViewRef = null;
         this.touchedInputs = {};
-
         this.setTouchedInput = this.setTouchedInput.bind(this);
         this.validate = this.validate.bind(this);
         this.submit = this.submit.bind(this);
@@ -249,6 +249,7 @@ class Form extends React.Component {
                     style={[styles.w100, styles.flex1]}
                     contentContainerStyle={styles.flexGrow1}
                     keyboardShouldPersistTaps="handled"
+                    ref={ref => this.scrollViewRef = ref}
                 >
                     <View style={[this.props.style]}>
                         {this.childrenWrapperWithProps(this.props.children)}
@@ -263,6 +264,9 @@ class Form extends React.Component {
                                 const errors = !_.isEmpty(this.state.errors) ? this.state.errors : this.props.formState.errorFields;
                                 const focusKey = _.find(_.keys(this.inputRefs), key => _.keys(errors).includes(key));
                                 this.inputRefs[focusKey].focus();
+                                this.inputRefs[focusKey].measureLayout(findNodeHandle(this.scrollViewRef), (x, y) => {
+                                    this.scrollViewRef.scrollTo({x, y: y - 10, animated: true});
+                                });
                             }}
                             containerStyles={[styles.mh0, styles.mt5]}
                             enabledWhenOffline={this.props.enabledWhenOffline}

Result
https://user-images.githubusercontent.com/30054992/204090564-a92acae7-37c1-4e61-89df-81563a337c3a.mp4

Hey people! Please check the linked PRs before working on proposals! I grabbed this last week and the PR has been around since wednesday or so 😬

Issue not reproducible during KI retests. (First week)

Seeing as this PR hit prod and is not reproducible this should be closed, right @Gonals?

Yep!


Set eventSource to the EdgeEventHandle type in AEP Response Event Handle

Sets the event source for edge response events to the value of the handle type.
More info: https://github.com/adobe/aepsdk-edge-ios/issues/108

@nporter-adbe Can you investigate why the coverage dropped for this PR?  It appears all your changes have 100% coverage, but I wonder if the changes to the tests are causing a code path to no longer get executed.

@kevinlind Yeah, that's interesting given the additions have 100% diff coverage. From what I can tell, it's caused by the fact I removed/simplified some code covered by testing, thus reducing the overall file size. Reducing the file size by removing tested code has resulted in the uncovered code to represent a larger portion of the file, which is NetworkResponseHandler.swift in this case.

@nporter-adbe Okay, that makes sense. It's odd that Codecov is reporting -17 lines because that appears to include lines removed and lines changed. The PR only removes about 6 lines.

I'm still debating whether it should be set to event source or type.

@shalehaha My take is that type has been used to signify which extension the event is coming from, even though this is a bit backward from how I'd expect source and type to be populated. So in this case I think we went with keeping that standard by having type set to com.adobe.edge.

@shalehaha Yeah, I can see both sides of the coin here, I wish we could revisit the definition of type/source for all events. My preference here is to keep as much consistency as possible and have com.adobe.edge be the type. It seems to not make much of a difference either way as long as we document them properly given that both options have valid reasons.

@shalehaha we discussed this originally for the Edge extension, we wanted to swap the type and source as it feels like it makes more sense that way, but we gave up to that idea for consistency across extensions. I think it shouldn't matter that much since we are using constants anyways when registering the listeners.


Handle guaranteed phis conservatively in a few more places.

@swift-ci test

@nate-chandler @meg-gupta you've seen most of theses commits already but may want to glance over them again. I added a few commits while merging PRs.

@swift-ci smoke test

@swift-ci smoke test


validate leaf selection of scalar & enum

Partial implementation of https://github.com/apollographql/apollo-rs/issues/307
From https://spec.graphql.org/October2021/#sec-Leaf-Field-Selections
If selectionType is a scalar or enum:

    The subselection set of that selection must be empty

Closed in favor of https://github.com/apollographql/apollo-rs/pull/465


Type inference is fuzzy / blackbox-y

TypeScript Version:  2.5.0-dev.20170627
When a generic type has multiple constraints (through extends in generic declaration), it is very hard to predict which one the compiler uses for type inference. I would expect this to be deterministic/predictable.
Two examples (and excuse the verbosity of the code, found it hard to replicate with less):
Listing 1
class Data<T> {
	constructor(v: T) {}
}

type Bound<O> = {
	[K in keyof O]: string | number | boolean
}

type Binding<O> = {
	[K in keyof O]: O[K] | Data<O[K]> | (() => Data<O[K]>)
}

function bind<O extends Bound<O>>(b: Binding<O>, c: ( (a: O) => {} )): null {
	return null
}

var MyComponent = bind({
	a: () => new Data<number>(123),
	b: new Data<boolean>(true)
},
function({a,b}) {
	var j : number = a;
	var l : boolean = b;
	return null;
});

MyComponent is type inferred as bind<{},{a: number, b: boolean}>... as I would expect. This snippet compiles fine.
Listing 2
class Data<T> {
	constructor(v: T) {}
}

type Bound<O> = {
	[K in keyof O]: string | number | boolean
}

type Binding<O> = {
	[K in keyof O]: O[K] | Data<O[K]> | (() => Data<O[K]>) | (() => O[K])
}

function bind<O extends Bound<O>>(b: Binding<O>, c: ( (a: O) => {} )): null {
	return null
}

var MyComponent = bind({
	a: () => new Data<number>(123),
	b: new Data<boolean>(true)
},
function({a,b}) {
	var j : number = a;
	var l : boolean = b;
	return null;
});

Binding<..> now has an additional map value in the form of  | (() => O[K]). For some reason, this triggers MyComponent to be inferred as bind<{}, { a: string | number | boolean, b: string | number | boolean }> (which is the type of the Bound). And it then fails to compile because the assignment in the function is incorrect.
I can certainly see type inference under these kind of complex conditions is never going to be trivial, but it's really hard to have any clue as to what's happening here.
Does it work like this because of the spec, because (of some exploration bounds in) the implementation? And is there something I can do to force the inference towards the first case?
I'm posting here as to maybe have a more generic discussion about how such complex cases might be made more approachable by normal programmers. If this is better suited on SO, please do close the ticket.

Can you simplify your examples to not depend on things from the React namespace?

@RyanCavanaugh Apologies, it was a long evening. I've updated the code.

I would expect this to be deterministic/predictable.

It is definitely deterministic.
As for predictable, well, it's generic type inference and I can't guarantee anyone will be able to keep the entire program state in their head as well as a computer can.
A short version of the inference process is:

"Line up" the types as best we can so that type parameters appear in positions corresponding to concrete types (e.g. given string | {x : T}, figure out that {x: number} is an inference for the object type)
Collect those places where we find concrete types matching the generic types (e.g. add number to the candidate list)
Choose the "best" candidate from the candidate list

In your case, the problem is here:
[K in keyof O]: O[K] | Data<O[K]> | (() => Data<O[K]>) | (() => O[K])
                                    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Both of those function types create inference sites for the corresponding property and we can't figure out which to prefer.
A simpler example with a possible fix:
    class Data<T> {
        x: T;
        constructor(v: T) { }
    }

    type Binding1<O> = {
        [K in keyof O]: Data<O[K]> |
        (() => Data<O[K]>) |
        (() => O[K]);
    }

    type Binding2<O> = {
        [K in keyof O]: Data<O[K]> |
        (() => (Data<O[K]> | O[K]));
    }

    declare function bind1<O>(b: Binding1<O>): O;
    declare function bind2<O>(b: Binding2<O>): O;

    const obj = {
        a: () => new Data<number>(123),
        b: new Data<boolean>(true)
    };
    const b1 = bind1(obj);
    b1.a.toFixed();
    const b2 = bind2(obj);
    b2.a.toFixed();

Alternatively:
    class Data<T> {
        x: T;
        constructor(v: T) { }
    }

    type Primitive = string | number | boolean
    type Bound<O> = {
        [K in keyof O]: Primitive
    }

    type Binding<O> = {
        [K in keyof O]: O[K] | Data<O[K]> | (() => Data<O[K]>) | (() => Primitive)
    }

    function bind<O extends Bound<O>>(b: Binding<O>, c: ((a: O) => {})): null {
        return null
    }

    var MyComponent = bind({
        a: () => new Data<number>(123),
        b: new Data<boolean>(true)
    },
    function ({ a, b }) {
        var j: number = a;
        var l: boolean = b;
        return null;
    });

@RyanCavanaugh You're a legend, thanks for your time.
I still have the feeling inference could be better with those generic constrains. I've simplified a bi further:
Basic case:
class Data<T> {
    constructor(v: T) { }
}

type Binding<O> = {
    [K in keyof O]: O[K] | Data<O[K]> | ( () => O[K] | Data<O[K]> )
}

declare function bind<X>(b: Binding<X>): void;

bind({
    a: 123,
    b: () => 123,
    c: new Data(234),
    d: () => new Data(234)
});```

This now gets inferred as: `function bind<{ a: number; b: number | ( () => number ); c: number; d: number }>`. This already surprises me, because without any constraints in this definition, I would have expected:

`function bind<{ a: number; b: number | (() => number); c: number | Data<number>; d: Data<number> | number | (() => Data<number>); }>`

So am I correct in assuming the matcher already makes some "choices" here (perhaps the part you're referring to as "best candidate" in your answer)?

Now, let's add a Constraint indicating we really want primitive values in X:

```ts
class Data<T> {
    constructor(v: T) { }
}

type Constrain<O> = {
    [k in keyof O]: number | string | boolean
}

type Binding<O> = {
    [K in keyof O]: O[K] | Data<O[K]> | ( () => O[K] | Data<O[K]> )
}

declare function bind<X extends Constrain<X>>(b: Binding<X>): void;

bind({
    a: 123,
    b: () => 123,
    c: new Data(234),
    d: () => new Data(234)
});

Because of the added constrain, the matcher now seems to go in an entirely different direction: bind<Constraint<{     a: number;     b: number | (() => number);     c: number;     d: number; }>>
(which is equal to bind<a: number | string | boolean, b: number | string | boolean, c: number | string | boolean, d: number | string | boolean>).
Would it be hard for the inference to explore all the types, and properly evaluating Constrain<X> with previously known bounds of X?
In this case:
X: { a: number; b: number | (() => number); c: number | Data<number>; d: Data<number> | number | (() => Data<number>); }
Constrain<X>: {a: number | string | boolean, b: number | string | boolean, c: number | string | boolean, d: number | string | boolean}
ergo X extends Constrain<X>: {a: number, b: number, c: number, d: number}

I believe your example there might require multiple passes, which effectively turns it into a unification algorithm. See also #30134


Issue with OSX

I am getting this error message on Mac OSX when following the installation instructions:

from matplotlib.backends import _macosx
RuntimeError: Python is not installed as a framework. The Mac OS X backend will not be able to function correctly if Python is not installed as a framework. See the Python documentation for more information on installing Python as a framework on Mac OS X. Please either reinstall Python as a framework, or try one of the other backends. If you are using (Ana)Conda please install python.app and replace the use of 'python' with 'pythonw'. See 'Working with Matplotlib on OSX' in the Matplotlib FAQ for more information.

Virtualenv has issues with GUI frameworks that matplotlib works on. The Stack Overflow link should help you out.
Refer to these links:
Stack Overflow Link
Matplotlib wiki


udpated kanaloa

Also typo (udpated) in the commit message, though I guess you can change that on merge (assuming we are doing squash-and-merge on this repo)

📻


use bloomfilter for crdt state

Codecov Report

Merging #10 (c6ed293) into alpha.0 (6ccd96c) will decrease coverage by 2.32%.
The diff coverage is 40.74%.

@@             Coverage Diff             @@
##           alpha.0      #10      +/-   ##
===========================================
- Coverage    62.94%   60.62%   -2.33%
===========================================
  Files            7        7
  Lines          726      739      +13
===========================================
- Hits           457      448       -9
- Misses         184      203      +19
- Partials        85       88       +3

Flag
Coverage Δ

unittests
60.62% <40.74%> (-2.33%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

internal/repo/repo.go
50.68% <30.00%> (-10.80%)
:arrow_down:

mobile/datahop.go
63.77% <60.00%> (-0.48%)
:arrow_down:

internal/replication/replication.go
59.72% <100.00%> (-0.56%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6ccd96c...c6ed293. Read the comment docs.


Responsively align last line of text using utils

For themes that modify the alignment of the last line of text, the responsive utils do not update the alignment of the last line of text. This keeps the responsiveness consistent with the rest of the text block.

This is not supported in Safari: https://caniuse.com/#feat=css-text-align-last

@MartijnCuppens That is true, but why close the issue? It is CSS3 compliant. If it is being used, this makes bootstrap handle responsiveness correctly. For browsers that don't handle it, there doesn't appear to be a negative effect.


Jenkins Alpha Deployment Failing

It appears that the Jenkins Alpha deployment script is failing during cleanup because uwsgi process wasn't found to be running (see issue #180).
http://jenkins.learningregistry.org/job/LR Alpha Deployment/22/console
[alpha.learningregistry.org] run: killall -9 uwsgi;
[alpha.learningregistry.org] out: uwsgi: no process found
Fatal error: run() encountered an error (return code 1) while executing 'killall -9 uwsgi;'
Aborting.
Can we check to ensure the uwsgi process is running before running the killall command?

Looks like uwsgi failed to start on a previous deployment due to the change in the model processing.  These failure was logged but didn't cause this task to fail.  When the next deployment ran stopping uwsgi failed.  The server is up now

I don't know the specifics regarding which phase of the script this exists, but uwsgi doesn't run during the nosetests (paste is used instead). Uwsgi would only be running during jmeter tests.
On Jan 25, 2012, at 11:20 AM<EMAIL_ADDRESS>wrote:

It appears that the Jenkins Alpha deployment script is failing during cleanup because uwsgi process wasn't found to be running (see issue #180).
http://jenkins.learningregistry.org/job/LR Alpha Deployment/22/console
[alpha.learningregistry.org] run: killall -9 uwsgi;
[alpha.learningregistry.org] out: uwsgi: no process found
Fatal error: run() encountered an error (return code 1) while executing 'killall -9 uwsgi;'
Aborting.
Can we check to ensure the uwsgi process is running before running the killall command?

Reply to this email directly or view it on GitHub:
https://github.com/LearningRegistry/LearningRegistry/issues/181

this is the deployment script not the unittests,  It does a killall -9 uwsgi to make sure all running processes are cleaned up


Application

Grant Application
This application is (select one):

[x] Speculative (use this by default)
[ ] an RFP response

This application is (select one):

[ ] Public (fully)
[x] Public with private finances

Abstract
Financial pallet provides means to calculate various statistical measures of users' crypto asset portfolios for the purposes of risk calculations and financial modeling.

It gathers prices from price oracle
It calculates returns
It calculates volatilities and correlations
It calculates portfolio risk
It calculates Value at Risk measure

Checklist

[x] The grants document has been read and understood.
[x] The Google Form will be completed accurately. Note that the Google Form requires the pull request URL.
[x] Abstract (above) is succinct and complete.
[x] The application is being included into the correct directory: either 'targeted' or 'speculative'.
[x] The application includes a project description.
[x] The application includes all names of team members.
[x] The application includes a description of the team's experience.
[x] The application includes all necessary links (e.g. GitHub and LinkedIn)
[x] The "Development Roadmap" section in the application has a timeline of development ("milestones").
[ ] The "Development Roadmap" section in the application has an estimate of funds required.
[x] The "Development Roadmap" section gives an indication of the team's long term plans.
[x] The "Development Roadmap" section includes documentation as a deliverable for at least one milestone.

added link to the detailed specification of the pallet architecture https://equilibrium-1.gitbook.io/financial-pallet


Qt5 modular

Moved over to using the submodule builds for Qt, and ported the most important modules. If you want one of the other ones, shouldn't be too hard to get it going, though the docs module is broken because of the whole packagedir/installdir issue. If someone wants to patch the source files to not put the prefix paths in the binaries, that'd probably fix this issue but I don't feel like deciphering qt source.
Few notes:

A lot of the original patches had to go because they were either no longer applicable or broke things -can add them in later if they're required I guess.
debug includes need to stay - they are used by debug builds of the qt libraries and tools - they've been moved into the share directory for qt5 under debug.
debug tools need to stay - they are used by debug builds of qt modules - these have also been moved into the share directory for qt5 under debug
Qt5Bootstrap.lib shouldn't have been removed from the debug directory, it is used when building qt modules
Please don't move qtmain or qtmaind - we can figure out another solution to the issue with ActiveX - really it's bad design on vcpkg's part to just blindly link everything by default anyway. For now it's not an issue since that module has not been included yet.
I've added 4 scripts for debug/release builds with qmake - these correctly set the paths for debug/release configuration and builds. Qt modules (besides base) are all built with qmake - so just follow the pattern in any of the other qt5 module portfiles if you're going to add them. Should be fairly straightforward.

good job

Please don't move qtmain or qtmaind - we can figure out another solution to the issue with ActiveX - really it's bad design on vcpkg's part to just blindly link everything by default anyway. For now it's not an issue since that module has not been included yet.

Just curious, what alternative solutions do you suggest then?

The CMake files provide explicit grouping of the modules already (selection of modules, and components within those modules) that are safe. There's really only a handful safe options:

Force users to explicitly specify all their dependencies (more work for users)
Force users to use CMake (learning curve, refactoring work)
Provide some way for the port file to specify modules as groupings of libraries provided by a package (more work for portfile and library writers)
Leverage CMake FindModules to generate package and component groupings and allow users to select these from a list inside Visual Studio (more work for vcpkg core and VS developers)

Each of these has downsides but all of them are better than assuming that everything "just works".

This PR is awesome.
I've confirmed at dba0884fb4a that all the added ports work for x86-windows. I am currently seeing a failure in qt5base:x64-windows-static, though that's not a regression since I think we currently have severe issues in that area anyway.
When do you think this PR is suitable for merging? I understand that our current QT5 port has a lot of modules, so do we need to wait until we're at parity here?
As for moving qtmain/qtmaind, could you explicitly call out what is broken when they are moved?

All of the main modules have been ported already (base has almost all the functionality that anyone uses, and declarative has all the new qt quick stuff), everything else is pretty much icing on the cake, but I'll spend some time over the weekend adding some of the other ones since the process is pretty quick now. If there's any modules you think should be higher priority, let me know: http://download.qt.io/official_releases/qt/5.9/5.9.2/submodules/
The main reason for moving qtmain in the first place was because of the ActiveX support which hardly anyone cares about - creating extra maintenance work for CMakeFiles and diverging that far from the normal setup is quite risky and means that using qt in a visual studio without CMake requires additional effort, even though linking qt main is the use case for 99.99% of people. If making the minor use case work means the use case for the vast majority of people becomes more annoying (and more maintenance work), we should probably just skip the ActiveX support and not include that module.

Maybe we need to add qt5 as a metapackage for all modules?

@Mixaill Not sure how to do that
@ras0219-msft Vast majority of modules have been merged in, should be good to merge now

Ok, I ran a build on all the ports added here:
Total elapsed time: 1.408 h

RESULTS
    libjpeg-turbo:x86-windows: SUCCEEDED: 30.5 s
    libpng:x86-windows: SUCCEEDED: 21.92 s
    freetype:x86-windows: SUCCEEDED: 45.33 s
    harfbuzz:x86-windows: SUCCEEDED: 54.73 s
    libpq:x86-windows: SUCCEEDED: 32.04 s
    double-conversion:x86-windows: SUCCEEDED: 38.25 s
    qt5base:x86-windows: SUCCEEDED: 24.37 min
    qt53d:x86-windows: SUCCEEDED: 19.39 min
    qt5charts:x86-windows: SUCCEEDED: 2.75 min
    qt5datavisualization3d:x86-windows: SUCCEEDED: 1.966 min
    qt5declarative:x86-windows: BUILD_FAILED: 16.89 min
    qt5gamepad:x86-windows: SUCCEEDED: 42.27 s
    qt5imageformats:x86-windows: SUCCEEDED: 47.99 s
    qt5multimedia:x86-windows: SUCCEEDED: 4.945 min
    qt5scxml:x86-windows: SUCCEEDED: 1.237 min
    qt5serial:x86-windows: SUCCEEDED: 19.38 s
    qt5speech:x86-windows: SUCCEEDED: 30.9 s
    qt5svg:x86-windows: SUCCEEDED: 42.21 s
    qt5tools:x86-windows: CASCADED_DUE_TO_MISSING_DEPENDENCIES: 2.108 ms
    qt5virtualkeyboard:x86-windows: SUCCEEDED: 59.01 s
    qt5websockets:x86-windows: SUCCEEDED: 37.23 s
    qt5winextras:x86-windows: SUCCEEDED: 1.007 min
    qt5xmlpatterns:x86-windows: SUCCEEDED: 3.544 min

While investigating the failures, I notice that in the logs there are lots of copy commands that appear to be copying directly into the installed folder instead of the staging directory.
copy /y ..\..\lib\Qt5QuickTestd.pdb D:\src\vcpkg\installed\x86-windows\debug\tools\qt5\Qt5QuickTestd.pdb

It looks like none of the packages besides qt5base are actually installing into the staging folder:
D:\src\vcpkg> ls packages\qt5*\lib | % fullname
D:\src\vcpkg\packages\qt5base_x86-windows\lib

Since it seems like this might be quite hard to deal with in qmake (I see lots of multi-stage patching going on), perhaps we should completely ignore the install target and perform the staging ourselves?

Ok, updates are:

Added qt5 metapackage
Extracted out a qt5modularscripts package which deduplicates all the portfiles for the individual modules
Fixed the declarative failure
Added some more dependencies -- more testing needs to be done here
Removed the entirely duplicate copy of includes and tools; instead, we just generate the correct qt.conf just-in-time. This also improves performance of the build since we don't use the debug version of qmake :)

Still to do:

qtmain.lib needs to be handled (Note: not just for Qt's ActiveX support, this is a general policy across all libraries which affects boost, gtest, gmock, and sdl2). The only way to cooperate with our MSBuild integration strategy that I see is to push it into a subdir, patching the cmake files appropriately. This subdir will be added as a -L flag on all consumers, so it is a transparent change.
A "minimal deps" testing pass that confirms we have all the correct dependencies listed.

The full build of qt5 takes me nearly 2 hours to build; I'd appreciate it if others could confirm that this isn't just "Works On My Machine"!

awesome
ok I'll reintroduce the qtmain stuff today or tomorrow and double check that the declarative failure is fixed, and do some more checks for the minimal deps - most of the modules build pretty quickly so it shouldn't take too long

I tried this pull request and I have a failure while building qt5declarative after successuly installing qt5base and qt5charts . The error is:
Elapsed time for package qt5charts:x64-windows: 1.043 ms
Starting package 3/5: qt5declarative:x64-windows
Building package qt5declarative:x64-windows...
-- CURRENT_INSTALLED_DIR=C:/vcpkg/installed/x64-windows
-- DOWNLOADS=C:/vcpkg/downloads
-- CURRENT_PACKAGES_DIR=C:/vcpkg/packages/qt5declarative_x64-windows
-- CURRENT_BUILDTREES_DIR=C:/vcpkg/buildtrees/qt5declarative
-- CURRENT_PORT_DIR=C:/vcpkg/ports/qt5declarative/.
-- Using cached C:/vcpkg/downloads/qtdeclarative-5.9.2.tar.xz
-- Testing integrity of cached file...
-- Testing integrity of cached file... OK
-- Extracting done
-- Configuring x64-windows-dbg
-- Configuring x64-windows-dbg done
-- Package x64-windows-dbg
-- Package x64-windows-dbg done
-- Package x64-windows-dbg
CMake Error at scripts/cmake/vcpkg_execute_required_process.cmake:43 (message):
    Command failed: C:/vcpkg/downloads/tools/jom/jom-1.1.2/jom.exe
    Working Directory: C:/vcpkg/buildtrees/qt5declarative/x64-windows-dbg
    See logs for more information:
      C:\vcpkg\buildtrees\qt5declarative\package-x64-windows-dbg-out.log
      C:\vcpkg\buildtrees\qt5declarative\package-x64-windows-dbg-err.log

Call Stack (most recent call first):
  scripts/cmake/vcpkg_build_qmake_debug.cmake:21 (vcpkg_execute_required_process)
  installed/x64-windows/share/qt5modularscripts/qt_modular_library.cmake:63 (vcpkg_build_qmake_debug)
  ports/qt5declarative/portfile.cmake:5 (qt_modular_library)
  scripts/ports.cmake:72 (include)

Error: Building package qt5declarative:x64-windows failed with: BUILD_FAILED
Please ensure you're using the latest portfiles with `.\vcpkg update`, then
submit an issue at https://github.com/Microsoft/vcpkg/issues including:
  Package: qt5declarative:x64-windows
  Vcpkg version: 0.0.97-2017-11-25-e4d93082e660a5fdab3b80f5d1b1f66bf9338883

Additionally, attach any relevant sections from the log files above.

The content of package-x64-windows-dbg-err is:
jom 1.1.2 - empower your cores

Error: dependent 'C:\vcpkg\installed\x64-windows\debug\tools\qt5\uic.exe' does not exist.
jom: C:\vcpkg\buildtrees\qt5declarative\x64-windows-dbg\tools\qmleasing\Makefile [debug] Error 2
jom: C:\vcpkg\buildtrees\qt5declarative\x64-windows-dbg\tools\Makefile [sub-qmleasing-make_first] Error 2
jom: C:\vcpkg\buildtrees\qt5declarative\x64-windows-dbg\Makefile [sub-tools-make_first] Error 2

The qwt port is also failing if you merge this branch with master, with the following message:
Starting package 1/1: qwt:x64-windows
Building package qwt:x64-windows...
-- CURRENT_INSTALLED_DIR=C:/vcpkg/installed/x64-windows
-- DOWNLOADS=C:/vcpkg/downloads
-- CURRENT_PACKAGES_DIR=C:/vcpkg/packages/qwt_x64-windows
-- CURRENT_BUILDTREES_DIR=C:/vcpkg/buildtrees/qwt
-- CURRENT_PORT_DIR=C:/vcpkg/ports/qwt/.
-- Using cached C:/vcpkg/downloads/qwt-6.1.3.zip
-- Testing integrity of cached file...
-- Testing integrity of cached file... OK
-- Extracting done
-- Applying patch C:/vcpkg/ports/qwt/build-shared-lib.patch
-- Applying patch C:/vcpkg/ports/qwt/build-shared-lib.patch done
-- Configuring x64-windows
-- Configuring x64-windows done
-- Package x64-windows
CMake Error at scripts/cmake/vcpkg_execute_required_process.cmake:43 (message):
    Command failed: C:/vcpkg/downloads/tools/jom/jom-1.1.2/jom.exe
    Working Directory: C:/vcpkg/buildtrees/qwt/x64-windows
    See logs for more information:
      C:\vcpkg\buildtrees\qwt\package-x64-windows-out.log
      C:\vcpkg\buildtrees\qwt\package-x64-windows-err.log

Call Stack (most recent call first):
  scripts/cmake/vcpkg_build_qmake.cmake:22 (vcpkg_execute_required_process)
  ports/qwt/portfile.cmake:31 (vcpkg_build_qmake)
  scripts/ports.cmake:72 (include)

Error: Building package qwt:x64-windows failed with: BUILD_FAILED
Please ensure you're using the latest portfiles with `.\vcpkg update`, then
submit an issue at https://github.com/Microsoft/vcpkg/issues including:
  Package: qwt:x64-windows
  Vcpkg version: 0.0.97-2017-11-25-e4d93082e660a5fdab3b80f5d1b1f66bf9338883

Additionally, attach any relevant sections from the log files above.
PS C:\vcpkg>

The log files referenced are not even created.

Upgraded the ports to version 5.9.3 and moved all necessary files into my working branch
First Problem:
qt5base did not build due to ANGLE using flex for building.
Solution:
Use different open-gl options. It worked with -opengl desktop -no-angle
Adding vcpkg_find_acquire_program(FLEX) and vcpkg_find_acquire_program(GPERF) to configure_qt.cmake did not help (Must I added the folders manually to the path variable somehow?)
Second Problem:
Current option "-opengl desktop" is not the default option.
Why not use the default "-opengl dynamic" ?
Will report more problems if I encounter them.

^yup, the problem was the removal of the debug tools, which the debug build of qt5declarative depend on. That seems to have fixed the qt5declarative build issue. I'm gonna just leave it as 5.9.2 for now, and then we can do 5.9.3 regressions afterwards. Didn't want to merge your working branch since it seems like you have a couple of non-qt things in there.
Put the manual link change back in, and made a few changes to get declarative build properly - will do further testing.

ok, so went through all the packages and built each individually (discovered the 3d module is dependent on the declarative module). Also did the full metapackage build for both x64 and x86 builds and it seems to be working now. Anyone want to pull the latest and do a quick test to make doubly sure it's all working?

Had some strange problems with jomon my desktop PC. One jomprocess seems to randomly hang at the end of one step (configuration/building/installing; STRG+C did not close the process) so I had to use nmake. So i am still trying to build the available ports but compared with the full qt package there are still modules missing (e.g. qt5serialbus, qt5translation,...)

Meanwhile, Qt 5.10 was released. :)
http://blog.qt.io/blog/2017/12/07/qt-5-10-released/

@Neumann-A
Yes, jom can be finicky at times and not exactly sure why it seems to hang. Seems to be quite a rare issue and it's preferrable to nmake because nmake can increase the build time by an order of magnitude. Regarding the other modules, qt5serialbus is not for windows so it doesn't matter, and qttranslation only provides ts files for certain qt applications and plugins so it's not really necessary.
See here:
http://code.qt.io/cgit/qt/qttranslations.git/tree/translations

Hi there!
What state of this great rework?
why just push qt5base?

Hi there!
What state of this great rework?
just push qt5base is ok

Anyone else want to do a check to see that it all works? I think I've addressed all comments.

@traversaro can you let me know if your previous issues have now been fixed?


[allow-insecure] Allow insecure packages with devbox.json field

Summary
This allows installing insecure packages using the permitted_insecure_packages devbox.json field (see example). I chose "permitted" instead of "allow" because that is the word nix uses in nixpkg config. Though they also use "allow" for the environment variable so we could go either way.
TODO (in follow up):

When installing an insecure package, ask the user if they want to allow it, update the devbox.json, and install it.

How was it tested?
See examples/insecure
Alternative config format
Another, slightly more complicated syntax could be:
"packages": [
  {"name": "nodejs", "version": "16", "allow_insecure": true}
],

This would be a bigger change since we need to support text packages and also object packages. I'm also not 100% sure we want to go in this direction or a map, so I'm thinking we punt on this.

@mikeland73 should I hold off on reviewing this for now?


Middleware options don't work

I'm using apollo-graphql and I tried to use graphql-playground as a graphiql replacement. I found that the middleware options don't work.
I tried something like the following:
app.use('/api/graphiql', playground({
  endpointUrl: '/api/graphql',
  subscriptionsUrl: '/api/graphql/subscriptions'
});

but when I load playground on my browser, the endpointUrl and subscriptionsUrl on the settings popup are as follows:
GraphQL Endpoint: {APP_URL}/api/graphiql
Subscriptions Endpoint: {APP_URL}/api/graphql

I have a similar issue, when I followed the example for express
app.use('/playground', playgroundMiddleware({ endpointUrl: '/graphql' }))
But if i go to /playground the route is ${APP_URL}/playground, not /graphql as expected..

fan-tastic ❤  @timsuchanek


feat(spanner): add support for RPC priority

Adds support for RPC priority to Cloud Spanner.

I can look at this on Monday, but it won't be before that

cc @skuruppu

I can look at this on Monday, but it won't be before that

No rush, the proto changes haven't been merged yet.

I've added the do not merge label and will be adding it to the other PRs. There's now a check that won't allow merging if the label is set.

I've added the do not merge label and will be adding it to the other PRs. There's now a check that won't allow merging if the label is set.

Thanks. I don't have permission to add labels to PRs in this repo.

https://github.com/googleapis/google-cloud-dotnet/pull/6265 has now been merged, so I suspect this PR can be rebased and potentially merged.

#6265 has now been merged, so I suspect this PR can be rebased and potentially merged.

It's been rebased and the tests are succeeding. It's still awaiting a final approval from the backend team that it can be merged.

@larkee please confirm whether this PR can be merged now.

The PR should be okay to merge two days from now. I'll let you know if that changes :+1:


⚠ Bofrost.de has degraded performance

In 55be302, Bofrost.de (https://www.bofrost.de) experienced degraded performance:

HTTP code: 200
Response time: 1855 ms

Resolved: Bofrost.de performance has improved in 88f712b.


Use more recent snappy

This PR updates rebar.config with new snappy version, that includes fix which makes Mac users' life easier.

This would really help me too!


Create make_goal node

This node inputs a text file of GPS coordinates (see rules for how this will be formatted)
Output a simple_goal to send to move_base

We have some code written, but we have yet to test it


portico: Fix cursor set to pointer incorrectly for input elements.

This commit fixes the code which incorrectly set the cursor property to "pointer" for
input and textarea elements where only select elements should have it.
The code causing this bug was added in d708bc338.

Screenshots and screen captures:

Self-review checklist

[ ] Self-reviewed the changes for clarity and maintainability
(variable names, code reuse, readability, etc.).

Communicate decisions, questions, and potential concerns.

[ ] Explains differences from previous plans (e.g., issue description).
[ ] Highlights technical choices and bugs encountered.
[ ] Calls out remaining decisions and concerns.
[ ] Automated tests verify logic where appropriate.

Individual commits are ready for review (see commit discipline).

[ ] Each commit is a coherent idea.
[ ] Commit message(s) explain reasoning and motivation for changes.

Completed manual review and testing of the following:

[ ] Visual appearance of the changes.
[ ] Responsiveness and internationalization.
[ ] Strings and tooltips.
[ ] End-to-end functionality of buttons, interactions and flows.
[ ] Corner cases, error conditions, and easily imagined bugs.

@timabbott I haven't tested; let me know if you need me to.

I have tested this on current Firefox (109.0.1), works as shown on the screenshot.
One minor note: cursor is also in "edit" shape when over "Your organization" and "Your account" labels, which may be confusing, so may be worth fixing while you are at it.

Merged, thanks @sahil839! I agree it's worth fixing the "edit" shape over those labels -- but probably worth doing as a follow-up since it's less glaring of an issue than this bug.


add checking for auth response

Signed-off-by: greg<EMAIL_ADDRESS>

good idea, but pls resolve conflicts

closed, decided not to merge it. Let's keep examples as minimal as possible.


Feature/s16 francis 35

Changes included server side and front end exception handling/logging and externalization of configuration files

As these changes has been peer reviewed, merging with develop branch


Feature 1555 iao extraction

Summary of the discussion
I opened a clean PR that contains the wanted changes from #1474
The aim is to update the extraction process from IAO.
Type of change (CHANGELOG.md)
Added

src/scripts/iao/extract-iao-module.sh
src/scripts/iao/iao-w-hierarchy.txt

Updated

src/ontology/imports/iao-module.owl

Removed

src/scripts/iao/extract-iao-module.bat

Workflow checklist
Automation
Closes #
PR-Assignee

[ ] 🐙 Follow the Pull Request Workflow
[ ] 📝 Update the CHANGELOG.md
[ ] 📙 Add #'s to term tracker item

Reviewer

[ ] 🐙 Follow the Reviewer Guide
[ ] 🐙 Provided feedback and show sufficient appreciation for the work done

There is only one thing that bothers me, we are not extracting term tracking item from IAO, for some reason it is still appearing properly in Protegé but it is not appearing in the Ontology. Should we add it to the list of terms?

Was the copyright property relationship manually added? I think the healthy way of managing it is to put it in oeo-shared, is that possible? If you can come up with a fast solution let me know, otherwise I will figure it out this afternoon.

@areleu : What exactly do you mean? The object property has licence (OEO_00020188) and subproperties? Be aware, that PR #1547 did here some changes, but the changes in the IAO file were not done manually but via Protégé.

I agree. But to set up Protégé that it does not add thing to the iao file but to oeo-shared instead?

I will pick it up this afternoon, I noticed it is not that simple

I added the changes from #1547 when resolving merge conflicts. But I see the problem.
With respect to #1268 the right place is oeo-import-edits.owl, not oeo-shared.

I already extracted the axioms, it should be working but I think it makes sense that someone checks it.

@l-emele do you also want to review before I merge?

I am not able to review this PR as I don't now any detail about importing external ontologies...

I think the most critical thing is to check if the "has license" axioms are appearing properly in protege for someone else, to make sure my local setup is not tricking me into believing its working

for the import to work, one has to rename the files accordingly in the catalog, the catalog is what synchronises the imports.

I am not able to review this PR as I don't now any detail about importing external ontologies...

I think the most critical thing is to check if the "has license" axioms are appearing properly in protege for someone else, to make sure my local setup is not tricking me into believing its working

I've checked all has licence axioms introduced in #1547 and they work here properly. I thus will approve.

Shared is also importing the iao module, fixed the naming in that file as well


 This patch removes the error
by changing semantics.
@kparichay thank you for the report.
resolves #1012
Self evaluation:

Build test: [X]Passed [ ]Failed [ ]Skipped
Run test: [X]Passed [ ]Failed [ ]Skipped

Signed-off-by: Jihoon Lee<EMAIL_ADDRESS>

:memo: TAOS-CI Version: 1.4.20191203. Thank you for submitting PR #1014. Please a submit 1commit/1PR (one commit per one PR) policy to get comments quickly from reviewers. Your PR must pass all verificiation processes of cibot before starting a review process from reviewers. If you are new member to join this project, please read manuals in documentation folder and wiki page. In order to monitor a progress status of your PR in more detail, visit http://nnsuite.mooo.com/.

retry deepcode


WebSocket - java.lang.RuntimeException

websocket connection closed automatically and crash app ,getting following crash report java.lang.RuntimeException:
at com.facebook.react.modules.websocket.WebSocketModule.send (WebSocketModule.java:221)

Hey, thanks for reporting this issue!
It looks like your description is missing some necessary information, or the list of reproduction steps is not complete. Can you please add all the details specified in the template? This is necessary for people to be able to understand and reproduce the issue being reported.
I am going to close this, but feel free to open a new issue that meets the requirements set forth in the template. Thanks!


Add SIZEOF_OFF_T.H

Add SIZEOF_OFF_T.H
#1
Posix

This is a data type defined in the sys/types.h header file (of fundamental type unsigned long) and is used to measure the file offset in bytes from the beginning of the file. It is defined as a signed, 32-bit integer, but if the programming environment enables large files off_t is defined to be a signed, 64-bit integer.

Always 4 on windows

This line:
#elif __x86_64__ || __ppc64__ || _FILE_OFFSET_BITS == 64

I think is better re-written like this:
#elif defined(__x86_64__) || defined(__ppc64__) || (defined(_FILE_OFFSET_BITS) && _FILE_OFFSET_BITS == 64)

(It's true that undefined evaluates to false but some compilers warn about this implicit conversion).
Also, should we include some header to get the _FILE_OFFSET_BITS macro?

@boris-kolpackov Updated to using defined(), Not sure what header we would include for the _FILE_OFFSET_BITS. From my understanding this is set by the user to support large files.https://digital-domain.net/largefiles.html


Add chat app

Hi there, thanks so much for the PR and example. There is already a chat example here: https://github.com/ollama/ollama/blob/main/examples/python-simplechat/client.py. My concern is it might be too similar and ideally we have one example. Would it be possible to make any improvements to the existing one? Sorry about that.


Update apply-windows-license.md

Added section on Windows server requirements, in consultation with Eva and Alexis

@TomHickling : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@TomHickling : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@ktoliver : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@ktoliver : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@ChristianMontoya Could you review the update to your article? Thanks.

@ChristianMontoya Could you review the update to your article? Thanks.

@TomHickling : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@TomHickling : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@Heidilohr : You might also want to get sign-off from @rick-man .

@Heidilohr : You might also want to get sign-off from @rick-man .

#sign-off

@Heidilohr: I'm sorry - only the author of this article, @ChristianMontoya, can sign off on your changes. But we do have an exception process - if you are on the Microsoft content or product team for this product area, you can ask the PR review team to review and merge it by sending mail to the techdocprs alias.

#sign-off


Fix grammar-o in CONTRIBUTING

(for the openssl team, there's a review tool that I just used...)

Oh....what branches?

It exists back to 1.0.2

Ok. My plus 1 applies to master, 1.1.0 and 1.0.2

It goes all the way back to 1.0.1 if you want :)

No strong view. If you want to push it there, my plus one applies.

+1 to merge to all branches, since it was introduced as the "retire RT" commit in 12 oct.

I'm fine with all branches, for the record

pushed to all releases, closing.


IRecaptchaService adds a method for directly passing in a token

RecaptchaService has implemented Task Validate(string responseCode), but the interface does not add this method.

This was not intended for use by Mvc users using Injection but rather to be used directly. This is also why you can now construct the class directly without using IOptions. This is not needed.

This has been reconsidered. The original intention of that method was to beta test a feature for WebApi, and Azure Function users that also use this library. In those cases there not need for the "front end" portion of this library. It also seemed like the added requirement of Microsoft.AspNetCore.Mvc.ViewFeatures might create an issue.
However this turns out to not be true. So i have returned the method to it's working state, and i'm approving this pull request to add the method to the interface for usage by both users using injection, and those choosing not to.
Thanks again for the contribution.


Bug in _get_topk

Hi, thanks for making this useful tool!  Looks great.
Here is a minimal working example of how I can produce the bug:
  1 import numpy as np
  2 import xclib.evaluation.xc_metrics as xc_metrics
  3
  4 scores = np.array([[0.1, 0.2, 0.99, 0.2]])
  5 labels = np.array([[0, 0, 1, 1]])
  6
  7 inv_propen = xc_metrics.compute_inv_propesity(labels, 0.55, 1.5)
  8 acc = xc_metrics.Metrics(true_labels=labels, inv_psp=inv_propen)
  9 args = acc.eval(scores, 1)
 10 print(xc_metrics.format(*args))

What I get is
  File "tmptest.py", line 9, in <module>
    args = acc.eval(scores, 1)
  File "/home/fs01/wz346/.local/lib/python3.7/site-packages/xclib-0.96-py3.7-linux-x86_64.egg/xclib/evaluation/xc_metrics.py", line 446, in eval
    self.inv_psp, k=K)
  File "/home/fs01/wz346/.local/lib/python3.7/site-packages/xclib-0.96-py3.7-linux-x86_64.egg/xclib/evaluation/xc_metrics.py", line 162, in _setup_metric
    num_labels, k)
  File "/home/fs01/wz346/.local/lib/python3.7/site-packages/xclib-0.96-py3.7-linux-x86_64.egg/xclib/evaluation/xc_metrics.py", line 118, in _get_topk
    return indices
UnboundLocalError: local variable 'indices' referenced before assignment

Looking at it closely, it seems like the if condition here fails to capture the np.ndarray type, so the indices never got created
    elif type(X) == np.ndarray:
        if np.issubdtype(X.dtype, np.integer):
            warnings.warn("Assuming indices are sorted.")
            indices = X[:, :k]
        elif np.issubdtype(X.dtype, np.float):
            _indices = np.argpartition(X, -k)[:, -k:]
            _scores = np.take_along_axis(
                X, _indices, axis=-1
            )
            indices = np.argsort(_scores, axis=-1)
            indices = np.take_along_axis(_indices, indices, axis=1)

where X is created here in the setup_metric():
    if inv_psp is not None:
        ps_indices = _get_topk(
            true_labels.dot(
                sp.spdiags(inv_psp, diags=0,
                           m=num_labels, n=num_labels)),
            num_labels, k)

Any ideas how I may fix it?  Thanks for any help you may be able provide.

Hi @wenting-zhao. Thank you for reaching out. We have updated pyxclib. This should now work as expected.
Anshul Mittal

the bug still exists,  since np.issubdtype(X.dtype, np.float)) returns True for float64 but False for float32

@qixiang109 , Could you please share a code snippet to reproduce this issue? Also, make sure you have the updated version of pyxclib.

Since no new updates were given and module works at our end


fix(TextCarousel): Fix the component

Impediment: https://trello.com/c/JG2Xg71C/465-textcarousel-updates
Preview:  https://storybook-k9o4ap7ai-treely.vercel.app/?path=/story/slices-textcarousel--minimal

[x] Gap between cards is reduced (same as for customer stories grid)
[x] Add scroll icons

Isn't this gap on mobile too big?


Added optional argument for the output file

Added an optional parameter to control the output file.

Hi just wanted to follow up with this and see if you're accepting pull requests.

Sorry for the delay: I've been away from my computer for the last 10 days or so. I like the idea of having an optional output argument, however I think it'd be better with an explicit flag (-o), and argparse. Simply reading sys.argv[3] seems risky in that the user is liable to accidentally put an input file as the third argument, thereby overwriting it.

No problem at all, I appreciate the reply. Argparse makes a lot of sense. I haven't done too much python work so I wasn't aware of a best practice. I'll update the codebase and issue another PR if that's OK with you.

No problem!


rename from "cognitive-search" to "azure-ai-search"

Azure Cognitive Search was rebranded to Azure AI Search on November 2023.
https://learn.microsoft.com/en-us/azure/search/whats-new#new-service-name
We should rewrite the document and rename the npm package name.

how to rename published npm module
https://stackoverflow.com/questions/28371669/renaming-a-published-npm-module


Reflect changes in prod_builders.json in commits when refreshing github commits/tasks to datastore

Existing refresh-github-commits API used prod_builders from master, rather than TOT. This will make changes in commits not reflected immediately, such as marking luci post test as flaky.
It needs to updated to use configs from TOT.

This is finished with the ci.yaml migration


update to nushell 0.84.1

This updates your plugin to 0.84.1. I realize you may not accept this because it points to a development version of nushell but you can still see what needs to be updated pretty easily. Just wanted to share.

Thank you, I'll merge this I think :)


[Do not merge yet] Use git short sha format for the docker image tag

We need to use the git short sha format accordingly.

LGTM


Generating waveform during recording and then saving it

Hi, I've seen #272 but I don't know the current status of that, also I have one more question, so here goes.

Is it possible with the microphone plugin to show the full waveform of the recording, not the current process? So the waveform would get longer as the recording continues.
Is it possible to save the recording afterwards? I mean can the audio blob be fetched somehow?

If there is no straightforward way to achieve these things, some kind of a hint or direction would be much appreciated.
@thijstriemstra, tagging you as the creator of the awesome microphone plugin.
Thanks.

I've tried to implement this but couldn't figure out a way to show the full waveform due to canvas performance issues. I did implement a sort of scrolling waveform that flows to the left during recording/playback but that code is still in a branch that I haven't updated in a while but hopefully will get to that again soon.

Yes that's possible, take a look at https://github.com/collab-project/videojs-record and it's internals

I wonder how these guys manage to do it: http://waveformjs.org/#fly
I'm trying to dig through https://github.com/soundcloud/waveformjs

Personally I would like to create a waveform that shrinks as it becomes longer so it's basically always the same size (what you see in software like Ableton, Logic etc). That 'fly example' is not the same effect unfortunately.

I get that, but all I need is about 15-20 seconds of recording, so I don't think shrinking would be needed in my case.

@thijstriemstra and @d0ragon, have you made any progress on this?
Thanks!

I've been trying to work with this as well.
Looking at the plugin, it seems that it might not actually store the data at all? The play command on this looks like it might actually be a trigger to start recording rather than play back - I can't seem to get the resulting data out of it.

same for me the recorder by mic is not working for me

wavesurfer.js currently does not have a ' recorder by mic' @davidtorroija so not sure what you mean.

wavesurfer.js currently does not have a ' recorder by mic' @davidtorroija so not sure what you mean.

I'm using the "microphone" plugin, but I don't know how to get the recorded audio and play, save, get the buffer etc

@davidtorroija use videojs-record for example, e.g. https://collab-project.github.io/videojs-record/examples/audio-only.html or help implement #1030

@thijstriemstra ok I will use that library I think, thanks

Guys, what do you think of the following implementation:
https://codepen.io/Sambego/pen/VmBJJN

I Created a POC of this functionality working, I'm rendering in canvas the recording peaks of sound in real time https://codepen.io/davidtorroija/pen/ZZzLpb?editors=0010
It was hard and I get help from an expert in web audio here: https://stackoverflow.com/questions/55407563/web-audio-api-and-javascript-get-the-correct-picks-from-microphone

@davidtorroija Thank you for sharing with this treasure!
I also saw that you mentioned the sample (https://online-voice-recorder.com/es/) and I'm wondering how I can achieve the selection and be able to delete it.

@davidtorroija that looks really coo! Could you rework this into a pull request so it can be used in wavesurfer.js by others as well?

@davidtorroija Thank you for sharing with this treasure!
I also saw that you mentioned the sample (https://online-voice-recorder.com/es/) and I'm wondering how I can achieve the same selection (start and end) and be able to trim and record over it.

Thanks for your comments!, and yes @thijstriemstra, @alisherakb I think that is harder! haha, I do not want to promise anything, but if I find the time I will keep investigate this integration with wave surfer

Check it out to record and replay audio from microphone plugin:
https://github.com/katspaugh/wavesurfer.js/issues/1515#issuecomment-590705075

is this functionality already in wavesurfer.js? Or do we still need to manually interact with canvas in order to show real time recording waveform?

It shows waveform when we do recording but their is no callback function
which provide recorded data after stop recording.
currently it only provide stream object by which we further use media
object to record stream.
On Wed, 28 Apr, 2021, 11:53 PM Dmitry Mylnikov, @.***>
wrote:

is this functionality already in wavesurfer.js? Or do we still need to
manually interact with canvas in order to show real time recording waveform?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/katspaugh/wavesurfer.js/issues/392#issuecomment-828678201,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AHNXVGLXVMOBFBNLC7LGYJLTLBHCJANCNFSM4A5NKXRQ
.

@davidtorroija Thank you so much for the POC it's so helpful! I just have one question: In line 36 in this codepen: https://codepen.io/davidtorroija/pen/ZZzLpb?editors=0010 what does 650 signify? Why are you multiplying the max variable with 650? And why 650 and not any other number?
Hoping to hear back from you. Thanks once again :)

So, I made a React package where you can record and playback your audio in real-time with the waveform graph animation! If anyone's interested, please check it out here: https://www.npmjs.com/package/react-voice-recorder-player.

@davidtorroija Thank you so much for the POC it's so helpful! I just have one question: In line 36 in this codepen: https://codepen.io/davidtorroija/pen/ZZzLpb?editors=0010 what does 650 signify? Why are you multiplying the max variable with 650? And why 650 and not any other number?
Hoping to hear back from you. Thanks once again :)

Sorry I did not see these messages

So, I made a React package where you can record and playback your audio in real-time with the waveform graph animation! If anyone's interested, please check it out here: https://www.npmjs.com/package/react-voice-recorder-player.
(thanks to https://github.com/d0ragon for his playback waveform implementation)

Your react plugin looks really good 💯


Refactor ReagentGrinder

It can now process partial stacks. (Before it would do nothing if the entire stack's solution didn't fit in the output container)
Get rid of SharedReagentGrinderComponent, move shared stuff to SharedReagentGrinder.cs.
Subscribe to events instead of massive switch/case.
Get rid of update queue thing.
Change DoWork so it's less duplicate code for grinding/juicing.
Get rid of ExtractableScalingEvent and just scale directly based on item stack count.
Add message for when you try to put something into the reagent grinder that doesn't fit.
Fix obsolescence warnings.

Changelog
:cl:

fix: Reagent grinder can now process partial stacks if the solution of the entire stack won't fit in the beaker.

Rebased to fix merge conflict

Rebased again to fix merge conflicts


Add the ability to create custom filters (for 3rd parties)

Right now, we support the following filters (in the io.github.jacobmarshall.meloooncensor.filter package).

ClassicFilter - censors individual words that violate the policy
StrictFilter - censors entire messages that violate the policy

It would be simple to allow people to write their own, in case they have a specific requirement. And even open it up to allow chaining, so multiple filters have the ability to catch violations.

As I noted in https://github.com/jacobmarshall/meloooncensor/pull/14#issuecomment-183830273 - this feature has been approved, but is in beta until it has been tested.

Actually I'll open a new issue so the milestone shows as complete :)


Caching can not work

I just looked at the code of the repository and discovered code like this:
return $this->cached("$manual.$version.toc",
				Markdown::parse($this->files->get($tocFile), $manual.'/'.$version));

The second argument is passed to Laravel's Cache::remember(). Since it is already evaluated (and therefore called) in this piece of code, there is absolutely no gain in caching this value - in fact, there's a little bit of overhead from storing the value in the cache.
You need to pass a Closure for this to have any effect.

I removed this from Codex 2.0 (which is using the core package) - I'm going to leave it up to the developer to implement caching for their own application.


Permanently exclude properties/fields

A lot of our classes derive from a base class which has a DateTime property. This property almost always makes the tests fail because of milliseconds difference. The thing is that it shouldn't even be compared since it's automatically initialized, so we always have to manually use the Excluding method to skip it. Is there a way to exclude it from all the assertions? Any attribute maybe?

You can consider to set some global settings on the AssertionOptions class.

Thanks a lot, @dennisdoomen, that did the trick.


Update strings.po ukr

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[x] Translation

Checklist:

[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[x] All new and existing tests passed.

please review Ukranian language changes

@alebastrov Do you plan to complete translation? Or should I close this PR?

@elgatito : reject PR ? It contains nothing relevant :)

@elgatito I think this can be closed. It was not updated for a almost a year.


Sourcemap issues

Getting this error when enabling sourcemaps (vite-plugin-import-markdown plugin) Sourcemap is likely to be incorrect: a plugin (vite-plugin-import-markdown) was used to transform files, but didn't generate a sourcemap for the transformation. Consult the plugin documentation for help

Did you resolve this?


TICI default for PC

If you change this you also need to fix the CARLA side

What needs to change in the CARLA side and where is that?

That code is here: https://github.com/commaai/openpilot/blob/master/tools/sim/bridge.py#L64
We'd need to add a second camera and make sure the vof/resolution match the tici cams.

This is the proper fix: https://github.com/commaai/openpilot/issues/22574


Update toolchain version

This bumps the toolchain to version 1.1.10, which includes git/ruby version bumps and removes fakeroot.
@chef-cookbooks/omnibus-maintainers
@chef-cookbooks/engineering-services

👍

👍

👍

Tests are failing pending merge of https://github.com/chef/omnibus/pull/698

@chef-cookbooks/engineering-services please re-review - I've added some changes that require toolchain 1.1.11 and am currently testing these changes locally.

@scotthain Looks like integration tests are failing with:
Mixlib::Install::Backend::Bintray::VersionNotFound
--------------------------------------------------
Specified version (1.1.11) not found for omnibus-toolchain in stable channel.

@schisamo Yep I'm working on releasing it right now.

Verified against the newest release and locally tested with full builds.


UML-1417 - BUG - Fix post production release slack message

Purpose
Post-production release salck message notification jobs are returning an invalid payload message.
Fixes UML-1417
Approach
Learning
Checklist

[ ] I have performed a self-review of my own code
[ ] I have added relevant logging with appropriate levels to my code
[ ] I have updated documentation (Confluence/GitHub wiki/tech debt doc) where relevant
[ ] I have added tests to prove my work
[ ] I have added welsh translation tags and updated translation files
[ ] I have run an accessibility tool on any pages I have made changes to and fixed any issues found
[ ] The product team have tested these changes

New slack post-release message for production using Python


Please add a license

https://build.opensuse.org/package/show/openSUSE:Tools/obs-service-node_modules claims that the package is licensed under the MIT license, but this repository has no license. If the MIT license is correct, then I can submit a PR.

The only license is in node_modules.py which is MIT so it's not just a claim ;)
If you wish, please make a PR with the license.


A simpler conda recipe setup

This is a simpler conda build setup that:

keeps pyproject.toml
has a minimal setup.py

I'll close this in favour of getting #16 as there's more discussion on that.


ENH (logic): adding coloring capabilities to the microscopy extension

apply color function (pixel color, min and max) is a requirement to investigate data in the microscopy extension.

Closing, superdensed by https://github.com/OHIF/Viewers/issues/2199


syntax error in generated aws-auth file when no workers defined

I have issues
I'm submitting a...

[X ] bug report
[ ] feature request
[ ] support request - read the FAQ first!
[ ] kudos, thank you, warm fuzzy

module version
7.0.1
What is the current behavior?
If you do not specify any worker groups, the aws-auth file has a syntax error, however you define roles in map_roles,  a syntax error is generated from the template file.
Notice the number 2 in the mapRoles line:
kubectl get cm aws-auth -n kube-system -o yaml
apiVersion: v1
data:
  mapRoles: |2

    - "groups":
      - "system:authenticated"
      "rolearn": "arn:aws:iam::role/(edited)"
      "username": "'{{SessionName}}'"

kind: ConfigMap
metadata:
  creationTimestamp: "(edited)"
  name: aws-auth
  namespace: kube-system

If this is a bug, how to reproduce? Please include a code sample if relevant.
define one or more map_roles
keep workers empty (do not defined any workers)
What's the expected behavior?
The aws-auth is generated without syntax errors, even when no worker configuration is defined (worker config is an empty list [] )
Are you able to fix this problem and submit a PR? Link here if you have already.
Environment details

Affected module version:
OS:
Terraform version:

Any other relevant info

this issue was incorrectly opened. this was a user error.

needs further testing to determine if this is a user-error or a template rendering error


feat: :sparkles: support for more available modifiers (#2543)

Description
support for more available modifiers

change ModifierKey namespace to Modifier class and add some come true methods
Motivation and Context

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Enhancement (changes that improvement of current feature or performance)
[ ] Refactoring (changes that neither fixes a bug nor adds a feature)
[ ] Test Case (changes that add missing tests or correct existing tests)
[ ] Code style optimization (changes that do not affect the meaning of the code)
[ ] Docs (changes that only update documentation)
[ ] Chore (changes that don't modify src or test files)

Self Check before Merge

[ ] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.

这是什么原因？


HIVE-27163: Addendum: Column stats are not getting published after an…

… insert into an external table with custom location

What changes were proposed in this pull request?

Why are the changes needed?
When the iceberg table is recreated - a new snapshot is generated, so any leftover files would be ignored.
Mark the stats as accurate when creating the Iceberg table

Does this PR introduce any user-facing change?

How was this patch tested?
mvn test -Dtest=TestIcebergCliDriver -Dtest.output.overwrite=true
col_stats.q.out is restored before the change.

Hi @deniskuzZ @ayushtkn, @simhadri-g could you please take a look if have a chance? Thanks in advance!


dump don't work with SPATIAL data

mysql version is 5.5, i have a table with spatial data field, when i use canal.run with dump,  don't work.

what is the log output?


Finish docker (HotFix)

Coverage remained the same at 68.817% when pulling e451b313c7e0f7e1ee12700e92f7fe9c9a259281 on develop into 9a65c92564dc9b591293c389eda18fb2d4cab735 on master.


Autologin not working

I got autologin working for a day, following all the instructions with regards to encrypting your password, pasting that into config.
However, I tried to use autologin again and this time WoW opens, but instead of the usual "connecting" followed by "success" dialogue, an empty dialogue box shows, with only the cancel button (pictured). I have redownloaded wowreeb, tried both x64 and x32, remade by config file, deleted both WDB and WTF, run wowreeb as admin, set WoW to run as admin, and tried different servers. None of that worked.
I'm running Windows 10 and trying to get wowreeb to start WoW 1.12. I am able to login if I open WoW normally and type my password.
Also attached is my config.txt as a .txt (as that's all Github allows), with my username and password removed.

Interesting. You’re the second person to say this. I will try and look at it more closely. Can you alter your configuration file to enable the console and post what the console output is when you see this blank status box?  To open the console press ` and note that you can use your mouse to drag the console window down to fit more output on the screen.

Here you go!

Interesting, i have the same problem on my laptop, even tho it works perfectly on my desktop.

Indeedy. Didn't change a thing, no weird driver updates or even a restart of my PC. Just kinda stopped.

Ultimately we want to keep the server alert message, if for no other reason than that some servers may use it, now or in the future.  With that in mind, note to self: add serverAlertUrl setting

Fixed in release 3.1.


An easy way to add validators

The example at https://vaadin.com/components/vaadin-text-field/html-examples/text-field-validators-demos#synchronous-custom-validator shows you can implement your own validation in a custom component which extends text field. What I would like to do is dynamically add or remove one or more validators to a field. It seems currently doable through something like
const originalCheck = field.checkValidity;
field.checkValidity = () => {
field.invalid = false;
if (!originalCheck.call(field))
    return false;

return ownChecks();
};

This is not a very intuitive way, especially that you need to reset the invalid flag manually to falseunless the field happens to have some other validation rules enabled (failing to do so will make the the field become invalid but it will never become valid again).

Moved the issue to vaadin-core and labelled with "next" to research for the next generation.
We can use Lion web components validate package for some inspiration.

Additional research topic: investigate Form participation API support.
Use FormElementMixin from Elix as an example.

One fundamental question is whether it's the field itself or an external "form controller" who is responsible for managing the field's validation status.
In the case of components controlled from server-side Java, the status is controlled by an external entity and any built-in validation logic is only getting in the way. The same is often also the case if you try to use 3rd party form binding libraries such as Final Form. What such solutions usually need is some way of disabling internal validation and only controlling the visual appearance (i.e. whether a required indicator is displayed and whether and error message is displayed).

Closing in favor of https://github.com/vaadin/vaadin-web-components/issues/81, let's continue discussion there.


Update for UploadUserData Improvements and Getter Operations

Summary
This PR introduces an update to the documentation to reflect the recent improvements made to the UploadUserData operation and the addition of new getter operations. The documentation has been revised to include the following changes:

Updated Documentation for UploadUserData:

Added detailed explanations on the new support for uploading user data as a JSON array.
Included information about the internal conversion of the JSON array into a Google Ads API UserData object.
Explained the normalization process for user identifiers and the supported formats (phone numbers, emails, mobile IDs, third-party user IDs, and address information).

Updated Documentation for Getter Operations:

Added a section on the new getUserLists operation, including the optional filterByName feature for filtering user lists by name.
Included documentation for getCustomers and getCampaigns to provide clarity on their functionality and usage.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Bring back 2.11 support?

First, thanks for the new release.
This is a general question as how hard is it to bring back 2.11 support and if you guys are open to it if someone contributes a PR. I'm asking since a lot of data pipelines are still on 2.11 because of Spark or other complications.

Also wondering if #157 is the only blocker and if it can be worked around.

No, there is a deeper issue with lazy vals encoding in 2.11 and this line:
https://github.com/propensive/magnolia/blob/master/core/shared/src/main/scala/magnolia.scala#L501
We had a discussion about it on some issue a long time ago but I couldn't find it right now.

Ah here it is: #78

Currently Magnolia is being used in zio-config and apparently, we had to remove 2.11 support as well. It will be a great help for the users to get back the support of 2.11 for some more time.

Who are these users of Scala 2.11? ;) I just reread the discussion on #78 (which I had forgotten) and it seems like it would be disproportionately hard to fix. Not impossible, certainly, but not a high priority.
We haven't had support for Scala 2.11 for nearly two years, and it doesn't seem like the right time to bring it back now. I'm actually happy to be adding a little bit more pressure to the ecosystem to move off unmaintained versions of Scala, so I'll close this issue. There is still an old version of Magnolia published for 2.11, which should be usable.


Save Images and Bounding Boxes in CARLA with Apollo

Hello! I am using CARLA with Apollo, and when I create a route in Apollo, I would like to be able to store the images as well as the bounding boxes of the objects that appear for the main Apollo vehicle in the CARLA rendering. Does anyone have any idea how this can be done using Python and could help me?

If you are interested in saving data to run them later in Apollo, you can use cyber_recorder to save data of cyber channels in bags and rerun whenever you need.


Add Grid row-gap aatribute

Add a new row-gap attribute to control the vertical axis of the gap.
Has the exact same functionality as the default gap attribute.
Additionally updated documentation to clarify sizes and breakpoints.
Brought back breakpoints on all settings to avoid conflicts and misconfigurations.

Changeset TBD


Who needs high-quality lip sync - contact me!

I can do lip sync for any character. I reduced the quality to 10 MB in order to upload video. If you are interested, write to me in telegram: The_best_result
https://github.com/OpenTalker/video-retalking/assets/152233811/03cbc9d4-404e-476d-a52b-0707f3f85633
https://github.com/OpenTalker/video-retalking/assets/152233811/77c38405-1cec-43bd-9d02-d54a0ca419c6
https://github.com/OpenTalker/video-retalking/assets/152233811/952314f8-5348-41bc-9b95-bfbba67781a8

How I can do this??

How I can do this??

order from me

I need to check on my dataset also... I have 1 minute video.. du lyo
syncing on that
On Fri, 10 May, 2024, 4:36 pm Chechgroup, @.***> wrote:

How I can do this??
order from me
—
Reply to this email directly, view it on GitHub
https://github.com/OpenTalker/video-retalking/issues/235#issuecomment-2104414897,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/A3XZGAGWCUPYRHSIV2DCDK3ZBSS2PAVCNFSM6AAAAABHP3E4WWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMBUGQYTIOBZG4
.
You are receiving this because you commented.Message ID:
@.***>

I need to check on my dataset also... I have 1 minute video.. du lyo syncing on that
[…]

I accept orders.
On Fri, 10 May, 2024, 9:47 pm Chechgroup, @.***> wrote:

I need to check on my dataset also... I have 1 minute video.. du lyo
syncing on that
[…]
I accept orders. If you need, write to telegram
—
Reply to this email directly, view it on GitHub
https://github.com/OpenTalker/video-retalking/issues/235#issuecomment-2104879103,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/A3XZGABWINXP2XMLUDGU7YLZBTXJJAVCNFSM6AAAAABHP3E4WWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMBUHA3TSMJQGM
.

On Fri, 10 May, 2024, 9:47 pm Chechgroup, @.> wrote: I need to check on my dataset also... I have 1 minute video.. du lyo syncing on that […] I accept orders. If you need, write to telegram — Reply to this email directly, view it on GitHub <#235 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/A3XZGABWINXP2XMLUDGU7YLZBTXJJAVCNFSM6AAAAABHP3E4WWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMBUHA3TSMJQGM . You are receiving this because you commented.Message ID: @.>

I don't do tests, I've been making orders for a year now


Improve logo highlighting

When highlighting the logo, the color should, for instance, end at the last character of each line.

This is actually done by purpose, because most logos are mono color, so this way it is simpler in the most cases. What is the use case for color ending then encountering \n for you?

I considered both options, but came to the conclusion, that overall its less work to design logos, if i leave it as is.


release(versioning): update version to 1.2.0

Automated PR to bump the version pre-release.

:tada: This PR is included in version 1.2.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


[Codegen] Map coin test folder name to coin-id so cointest

Codegen/cointests generate duplicate folders for existing coins.
This is because some legacy tests are not using coin-id as a directory name, so we should either rename those directories or add mapping (like XRP -> tests/Ripple) to the script.
Please see discussion on PR-2485 for more context.

I am for rename.  Coin ID should not change ever, if name changes we can use DisplayName.


data-equalize-on not working

For some reasons, the data attribute data-equalize-on isn't working. The equalizer is triggered on all media queries.
How can this bug be reproduced?
Create a sample markup:

	<?php
	$locations = new WP_Query( array(
		'post_type'      => 'location',
		'posts_per_page' => 30,
		'post_status'    => 'publish',
	) );

	if ( ! empty( $locations->posts ) ) {

		foreach ( $locations->posts as $location ) {

			$name       = apply_filters( 'the_title', $location->post_title );
			$address1   = get_post_meta( $location->ID, 'location_address_1', true );
			$address2   = get_post_meta( $location->ID, 'location_address_2', true );
			$province   = get_post_meta( $location->ID, 'location_province', true );
			$city       = get_post_meta( $location->ID, 'location_city', true );
			$postcode   = get_post_meta( $location->ID, 'location_postcode', true );
			$phone      = get_post_meta( $location->ID, 'location_phone', true );
			$email      = get_post_meta( $location->ID, 'location_email', true );
			$opening    = get_post_meta( $location->ID, 'location_open', true );
			$phone_call = 0 == substr( $p = str_replace( array( ' ', '-' ), '', $phone ), 0, 1 ) ? '+66' . substr( $p, 1 ) : $p;
			?>

<?php echo $name; ?>

						<?php echo $address1; ?>,

						<?php echo $address2; ?>,

						<?php echo $province; ?>
						<?php echo $postcode; ?>,

						Thailand

<?php echo $opening; ?>

					<a class="location-phone" href="tel:<?php echo $phone_call; ?>" itemprop="telephone"><?php echo $phone; ?>

					<a class="location-email" href="mailto:<?php echo $email; ?>" itemprop="email"><?php echo $email; ?>
					Locate on map

		<?php }

	}
	?>

Then resize the viewport to a small screen. Reload the page. Each columns height gets a fixed height in pixels, while they shouldn't.
What did you expect to happen?
The equalizer should only trigger on medium screens and larger.
What happened instead?
The equalizer works on all media queries. My temporary fix is the following:
.location-box {
	// Only affects small screens
	@include breakpoint(small down) {
		height: auto !important;
	}
}

Hi @SiamKreative . Your sample code seems ok to me. Your implementation is according to the equalizer plugin documentation. Are you experiencing the same issues in a plain Foundation install (without FoundationPress)? I suspect this might be a bug with the equalizer plugin. Let's find out if that might be the case.

We have had a similar issue before regarding data equalizer.
"data-equalizer-watch" should not be on the DIV that defines the number of columns i.e. "large-4 columns", but rather on the DIV you want "equalized".