Moving content between insertion points is not working in 1.0

In a component which you can supply child light DOM elements as actions, I have two insertion points - one for action buttons (<content select="[button]"></content>) and one for an action menu (the rest - <content></content>).
If the screen has enough space to display buttons, I set the button attribute on one of the menuitems, and it will be moved to the first insertion point.
This worked great in 0.5 but I can't get it to work in 1.0: http://jsbin.com/qozitubuyo/2/edit?html,console,output
Example with classes instead of attributes, but no difference.
Is this a bug or was the previous behavior a bug?
If it is not supported, what is the recommended approach?

Actually, the problem was me not using Polymer.dom() to mutate the classList.


Refactor as monorepo & introduce auth tools

Todo

[x] Implementation
[x] Documentation
[ ] Tests

Hi @djhi ! Do you have a release date in mind?

Hey, I'm currently in vacation but I'll work on it in a week or so

@florian-lefebvre I'd love a review if you have time :)

@florian-lefebvre I'd love a review if you have time :)

Sure, I will do it!


Native Graph-as-Text URLs (JSON I think)

Maybe this is common knowledge, but it might be helpful to know that desmos hosts a native text-representation of every graph.
It is fetchable via a URL.
Take the graph with the ID qfzqejspct as an example:
https://www.desmos.com/calculator/qfzqejspct
Accessing this URL: https://saved-work.desmos.com/calc-states/production/qfzqejspct
returns:
{
	"version":9,
	"randomSeed":"feec3866eba2d1fb44f38db220329d1b",
	"graph":{
		"viewport":{
			"xmin":-9.998391734489985,
			"ymin":-6.276256152833961,
			"xmax":10.001608265510018,
			"ymax":6.273039621813929
		}
	},
	"expressions":{
		"list":[
			{
				"type":"text",
				"id":"3",
				"text":"URL Test"
			},
			{
				"type":"expression",
				"id":"1",
				"color":"#c74440",
				"latex":"y=2x^{2}",
				"labelSize":"medium"
			},
			{
				"type":"folder",
				"id":"4",
				"title":"Test Folder"
			},
			{
				"type":"text",
				"id":"10",
				"folderId":"4",
				"text":"Folder Test"
			},
			{
				"type":"expression",
				"id":"11",
				"folderId":"4",
				"color":"#2d70b3",
				"latex":"y=\\frac{1}{e^{x}}"
			},
			{
				"id":"7",
				"type":"table",
				"folderId":"4",
				"columns":[
					{
						"values":["0","1"],
						"hidden":true,
						"id":"5",
						"color":"#388c46",
						"latex":"x_{1}"
					},
					{
						"values":["1","2"],
						"id":"6",
						"color":"#6042a6",
						"latex":"y_{1}"
					}
				]
			}
		]
	}
}

Note: I added whitespace for readability. The raw output has no whitespace.
You can similarly fetch a thumbnail of the graph from here:
https://saved-work.desmos.com/calc_thumbs/production/qfzqejspct.png

URL Syntax:
https://saved-work.desmos.com/calc-states/production/<graph_ID>
https://saved-work.desmos.com/calc_thumbs/production/<graph_ID>.png

Thanks for sharing! Do you have any corresponding feature request for DesModder or is this just a discussion/fyi?
Btw this can also be achieved through an Accept header on the original link, and it gives a little more information
const stream = await fetch("https://www.desmos.com/calculator/qfzqejspct", {
  headers: {
    Accept: "application/json",
  },
});
const data = await stream.json();

The data variable then holds:
{
    "hash": "qfzqejspct",
    "parent_hash": null,
    "thumbUrl": "https://saved-work.desmos.com/calc_thumbs/production/qfzqejspct.png",
    "stateUrl": "https://saved-work.desmos.com/calc-states/production/qfzqejspct",
    "title": null,
    "access": "link",
    "created": "Wed, 27 Jul 2022 18:15:16 GMT",
    "state": {
        "version": 9,
        "randomSeed": "feec3866eba2d1fb44f38db220329d1b",
        "graph": {
            "viewport": {
                "xmin": -9.998391734489985,
                "ymin": -6.276256152833961,
                "xmax": 10.001608265510018,
                "ymax": 6.273039621813929
            }
        },
        "expressions": {
            "list": [ (etc. same as your original post) ]
        }
    }
}

Oh, even cooler!
I created the issue just as and FYI.
There ARE two desmos features on my Wishlist, but I believe they're out of reach for a tool like DesModder.

Graph URLs that don't change after every update (anyone with a link to my work should be taken to the latest version)
Keywords for the Viewport's xmin/ymin/xmax/ymax that can be used in expressions

Thanks Jared,
You're doing some fantastic work on here!
-Ben

To encourage more discussion, I've enabled the discussions feature on Github. Going to migrate this issue to a discussion post.


Agents suggestion

Relative to issue #1565
As discussed on slack

@spolu On design of ConvMessage/Agentmessage/UserMessage, working on this got me to think
AgentMessage / UserMessage should stick to rendering the "inside" content (what's on the middle column, only related to the message itself)
ConversationMessage is in charge of displaying Agent/UserMessage in the context of the Conversation view (similarly we could have SidebarMessage, or SharingMessage etc.)--as such it would belong to Conversation.tsx. For conversation view we want an avatar displayed on left, some buttons on the right, a follow-up for users who don't enter... => all this is handled by ConversationMessage
Therefore, Agentmessage / usermessage should be children of ConversationMessage in Conversation.tsx VS at the time they encapsulate a convmessage
I would take 30' to push a refactor if you agree

Looks great! On you proposal we can chat separately and in a different PR

I really hesitated to dry editUserMessage / postUserMessage which have a lot in common
Decided not to do it for now since

functions may diverge
2.the differences are interspersed: the result may not be hyper readable + abstraction would not be very clear

The downside is, when we change one, we'll probably forget to update the other

Bullish on no drying at this stage


NFC MANAGER FACING PROBLEM WHILE LOCKING THE TAG ONCE THE SESSION IS GETTING STARTED.

I/abgroup.nfclabs( 6591): Thread[6,tid=6597,WaitingInMainSignalCatcherLoop,Thread*=0xb400007bc1699dd0,peer=0x13fc0220,"Signal Catcher"]: reacting to signal 3
I/abgroup.nfclabs( 6591):
I/abgroup.nfclabs( 6591): Wrote stack traces to tombstoned
IT IS GETING CRASHED

Same issue I can't lock my card

Can you share little more about the your issues as it is same

Same issue I can't lock my card

Same issue I am facing I can't lock my card

can you share more about the issue faced by you are you able to lock the tag with andriod 12 and ios ?


Update sql-database-libraries.md

Let's kill the Wikipedia mention until it is live... Looks like we are making the community work for us now... Also fixing some typos, title and the community table referencing Python instead of node.

Hi @tobbox, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!

This seems like a small (but important) contribution, so no contribution license agreement is required at this point. Real humans will now evaluate your PR.

TTYL, AZPRBOT;


Improved Python bindings.

I created (yet another) Python binding for BGFX as the current one linked in the documentation seems a little abandoned. This one use native C++ function wrapping and, contrary to the CTypes implementation, is quite fast.
https://github.com/fbertola/bgfx-python
I also provide source and wheel distribution (Linux, Max and Windows) and I plan to use it to update Cocos-Python.
Thanks again for this wonderful project!

Cool, I'll add it to the list. Thanks!


[Intel MKL] Supporting MatMul, Transpose and Softmax with BFloat16 type

This PR enables _MklMatMul, _MklTranspose and _MklSoftmax with BFloat16 type.
Some of the changes are suggested by Clang format checker.

hi @penpornk, thanks for review. I have addressed your points. Pls take a look.

Thank you a quick review @penpornk!


Form validation error inside Wizard using  is not popping up

Describe the bug
The issue is observed in Wizard with Form Validation: the input field has class="clr-input ng-pristine ng-invalid ng-touched" but the  dirctive doesn’t show up.
How to reproduce
This issue cannot be reproduced in (https://stackblitz.com/@clr-team), but it is observed in (https://clarity.design/documentation/wizards) Wizard with Form Validation section. If you click “WIZARD + FORM VALIDATION” button, in the wizard “Enter a number” step, click “Your number” field, then mouse away and click elsewhere on the same wizard page, the error messaage doesn’t show up as expected. The validation error message will show up when you repeat the click the input field and mouse away.
Steps to reproduce the behavior:

Go to (https://clarity.design/documentation/wizards) Wizard with Form Validation section.
Click on “WIZARD + FORM VALIDATION” button.
Fill out the name field, then clisk "NEXT" button.
In the “Enter a number” page, click “Your number” field, then mouse away and click elsewhere on the same wizard page.
See error: the error messaage doesn’t show up as expected.
The validation error message will show up when repeat the click the “Your number” field and mouse away and click elsewhere on the same wizard page.

Expected behavior
the error message should show up when input field is touched and invalid.
Versions
App

Angular: 9.1.1
Node: 10.15.0
Clarity: 3.1.0

Device:

Type: Macbook Pro
OS: MacOS
Browser: Chrome and Firefox
Version: Chrome 80, Firefox 74

Additional notes

Leaving this comment here for future reference:
Even the solution we implement is a workaround, there is one more solution to this bug. By setting @HostListener('blur') to @HostListener('focusout'). For some reason, the blur event on <input type="number" /> added by WrappedControl is called before theblur event of  ngControl  that sets the ng-touched. This is the reason, the component on its first blur does not display as invalid.


fix: compatible chrome cookie file position change

Inlatest version of chrome, cookie file position has changed

it is enough to check the name of the directory (it is now in the "Network" folder) containing the Cookies database, that saves the file stat.
dir := filepath.Dir(s.FileNameStr)
if filepath.Base(dir) == `Network` { // Chrome 96
		dir = filepath.Dir(dir)
}
stateFile, err := filepath.Abs(filepath.Join(filepath.Dir(dir), `Local State`))
...


HBASE-24602 Add Increment and Append support to CheckAndMutate

Summary of the change:

Add build(Increment) and build(Append) methods to the Builder class of the CheckAndMutate class. After this change, we can perform checkAndIncrement/Append operation as follows:

// Build a CheckAndMutate object with a Increment object
CheckAndMutate checkAndMutate = CheckAndMutate.newBuilder(row)
  .ifEquals(family, qualifier, value)
  .build(increment);

// Perform a CheckAndIncrement operation
CheckAndMutateResult checkAndMutateResult = table.checkAndMutate(checkAndMutate);

// Get whether or not the CheckAndIncrement operation is successful
boolean success = checkAndMutateResult.isSuccess();

// Get the result of the increment operation
Result result = checkAndMutateResult.getResult();

After this change, HRegion.batchMutate() is used for increment/append operations.

As the side effect of the above change, the following coprocessor methods of RegionObserver are called when increment/append operations are performed:

preBatchMutate()
postBatchMutate()
postBatchMutateIndispensably()

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 40s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+0 :ok:
mvndep
0m 24s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 40s
master passed

+1 :green_heart:
checkstyle
1m 44s
master passed

+1 :green_heart:
spotbugs
2m 56s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 13s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 24s
the patch passed

-0 :warning:
checkstyle
1m  9s
hbase-server: The patch generated 3 new + 270 unchanged - 10 fixed = 273 total (was 280)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
11m 23s
Patch does not cause any errors with Hadoop 3.1.2 3.2.1.

+1 :green_heart:
spotbugs
3m 10s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 26s
The patch does not generate ASF License warnings.

37m 19s

Subsystem
Report/Notes

Docker
Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2228/1/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2228

Optional Tests
dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle

uname
Linux d3bbb4ef2c61 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 7b099eaa75

checkstyle
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2228/1/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt

Max. process+thread count
94 (vs. ulimit of 12500)

modules
C: hbase-client hbase-server U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2228/1/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 36s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 22s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 47s
master passed

+1 :green_heart:
compile
1m 21s
master passed

+1 :green_heart:
shadedjars
5m 39s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
1m  3s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 17s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 32s
the patch passed

+1 :green_heart:
compile
1m 23s
the patch passed

+1 :green_heart:
javac
1m 23s
the patch passed

+1 :green_heart:
shadedjars
5m 37s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 59s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
1m  3s
hbase-client in the patch passed.

-1 :x:
unit
141m 46s
hbase-server in the patch failed.

169m 31s

Subsystem
Report/Notes

Docker
Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2228/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2228

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 9161152b1fe1 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 7b099eaa75

Default Java
1.8.0_232

unit
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2228/1/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2228/1/testReport/

Max. process+thread count
4273 (vs. ulimit of 12500)

modules
C: hbase-client hbase-server U: .

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 16s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
4m  1s
the patch passed

+1 :green_heart:
compile
1m 35s
the patch passed

+1 :green_heart:
javac
1m 35s
the patch passed

+1 :green_heart:
shadedjars
5m 42s
patch has no errors when building our shaded downstream artifacts.

-0 :warning:
javadoc
0m 26s
hbase-client in the patch failed.

-0 :warning:
javadoc
0m 40s
hbase-server in the patch failed.

_ Other Tests _

+1 :green_heart:
unit
1m 11s
hbase-client in the patch passed.

-1 :x:
unit
140m 33s
hbase-server in the patch failed.

169m 50s

Subsystem
Report/Notes

Docker
Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2228/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2228

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 42d98b22665d 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 7b099eaa75

Default Java
2020-01-14

javadoc
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2228/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-client.txt

javadoc
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2228/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt

javadoc
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2228/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-client.txt

javadoc
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2228/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt

unit
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2228/1/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2228/1/testReport/

Max. process+thread count
4111 (vs. ulimit of 12500)

modules
C: hbase-client hbase-server U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2228/1/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 34s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+0 :ok:
mvndep
0m 22s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 44s
master passed

+1 :green_heart:
checkstyle
1m 39s
master passed

+1 :green_heart:
spotbugs
3m  1s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 14s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
4m  0s
the patch passed

+1 :green_heart:
checkstyle
0m 40s
The patch passed checkstyle in hbase-client

+1 :green_heart:
checkstyle
1m 37s
hbase-server: The patch generated 0 new + 291 unchanged - 10 fixed = 291 total (was 301)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
15m  9s
Patch does not cause any errors with Hadoop 3.1.2 3.2.1.

+1 :green_heart:
spotbugs
4m 20s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 25s
The patch does not generate ASF License warnings.

44m 42s

Subsystem
Report/Notes

Docker
Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2228/2/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2228

Optional Tests
dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle

uname
Linux eed1ca1b272a 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 6fd7dcef28

Max. process+thread count
94 (vs. ulimit of 12500)

modules
C: hbase-client hbase-server U: .

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 14s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
4m  7s
the patch passed

+1 :green_heart:
compile
1m 34s
the patch passed

+1 :green_heart:
javac
1m 34s
the patch passed

+1 :green_heart:
shadedjars
6m  7s
patch has no errors when building our shaded downstream artifacts.

-0 :warning:
javadoc
0m 27s
hbase-client in the patch failed.

-0 :warning:
javadoc
0m 52s
hbase-server in the patch failed.

_ Other Tests _

+1 :green_heart:
unit
1m 21s
hbase-client in the patch passed.

+1 :green_heart:
unit
158m 27s
hbase-server in the patch passed.

190m 12s

Subsystem
Report/Notes

Docker
Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2228/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2228

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux f001ead924ca 4.15.0-65-generic #74-Ubuntu SMP Tue Sep 17 17:06:04 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 6fd7dcef28

Default Java
2020-01-14

javadoc
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2228/2/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-client.txt

javadoc
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2228/2/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt

javadoc
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2228/2/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-client.txt

javadoc
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2228/2/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2228/2/testReport/

Max. process+thread count
3776 (vs. ulimit of 12500)

modules
C: hbase-client hbase-server U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2228/2/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 30s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 24s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 44s
master passed

+1 :green_heart:
compile
1m 22s
master passed

+1 :green_heart:
shadedjars
5m 31s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 59s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 16s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 35s
the patch passed

+1 :green_heart:
compile
1m 20s
the patch passed

+1 :green_heart:
javac
1m 20s
the patch passed

+1 :green_heart:
shadedjars
5m 40s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 57s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
1m  4s
hbase-client in the patch passed.

+1 :green_heart:
unit
168m 59s
hbase-server in the patch passed.

197m 35s

Subsystem
Report/Notes

Docker
Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2228/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2228

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 19fe4dc550f2 4.15.0-65-generic #74-Ubuntu SMP Tue Sep 17 17:06:04 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 6fd7dcef28

Default Java
1.8.0_232

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2228/2/testReport/

Max. process+thread count
3827 (vs. ulimit of 12500)

modules
C: hbase-client hbase-server U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2228/2/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 38s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+0 :ok:
mvndep
0m 15s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
4m 17s
master passed

+1 :green_heart:
checkstyle
2m  3s
master passed

+1 :green_heart:
spotbugs
3m 25s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 15s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
4m 22s
the patch passed

+1 :green_heart:
checkstyle
0m 36s
The patch passed checkstyle in hbase-client

+1 :green_heart:
checkstyle
1m 29s
hbase-server: The patch generated 0 new + 307 unchanged - 10 fixed = 307 total (was 317)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
14m 38s
Patch does not cause any errors with Hadoop 3.1.2 3.2.1.

+1 :green_heart:
spotbugs
3m 52s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 24s
The patch does not generate ASF License warnings.

46m 48s

Subsystem
Report/Notes

Docker
Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2228/3/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2228

Optional Tests
dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle

uname
Linux 1879ce80155e 4.15.0-65-generic #74-Ubuntu SMP Tue Sep 17 17:06:04 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 6fd7dcef28

Max. process+thread count
94 (vs. ulimit of 12500)

modules
C: hbase-client hbase-server U: .

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 15s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
4m 10s
the patch passed

+1 :green_heart:
compile
1m 34s
the patch passed

+1 :green_heart:
javac
1m 34s
the patch passed

+1 :green_heart:
shadedjars
6m 49s
patch has no errors when building our shaded downstream artifacts.

-0 :warning:
javadoc
0m 32s
hbase-client in the patch failed.

-0 :warning:
javadoc
0m 53s
hbase-server in the patch failed.

_ Other Tests _

+1 :green_heart:
unit
1m 23s
hbase-client in the patch passed.

+1 :green_heart:
unit
149m 35s
hbase-server in the patch passed.

181m 20s

Subsystem
Report/Notes

Docker
Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2228/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2228

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux b2a2ab2f98fb 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / ea130249ae

Default Java
2020-01-14

javadoc
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2228/3/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-client.txt

javadoc
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2228/3/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt

javadoc
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2228/3/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-client.txt

javadoc
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2228/3/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2228/3/testReport/

Max. process+thread count
4077 (vs. ulimit of 12500)

modules
C: hbase-client hbase-server U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2228/3/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 30s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 22s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 50s
master passed

+1 :green_heart:
compile
1m 17s
master passed

+1 :green_heart:
shadedjars
5m 37s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
1m  0s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 17s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 33s
the patch passed

+1 :green_heart:
compile
1m 22s
the patch passed

+1 :green_heart:
javac
1m 22s
the patch passed

+1 :green_heart:
shadedjars
5m 36s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 55s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
1m  5s
hbase-client in the patch passed.

+1 :green_heart:
unit
160m  2s
hbase-server in the patch passed.

187m 57s

Subsystem
Report/Notes

Docker
Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2228/3/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2228

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux b186b053fb58 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / ea130249ae

Default Java
1.8.0_232

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2228/3/testReport/

Max. process+thread count
3927 (vs. ulimit of 12500)

modules
C: hbase-client hbase-server U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2228/3/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 28s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+0 :ok:
mvndep
0m 24s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 43s
master passed

+1 :green_heart:
checkstyle
1m 46s
master passed

+1 :green_heart:
spotbugs
2m 56s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 13s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 24s
the patch passed

+1 :green_heart:
checkstyle
0m 33s
The patch passed checkstyle in hbase-client

+1 :green_heart:
checkstyle
1m 11s
hbase-server: The patch generated 0 new + 307 unchanged - 10 fixed = 307 total (was 317)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
11m 17s
Patch does not cause any errors with Hadoop 3.1.2 3.2.1.

+1 :green_heart:
spotbugs
3m 13s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 26s
The patch does not generate ASF License warnings.

37m  8s

Subsystem
Report/Notes

Docker
Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2228/4/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2228

Optional Tests
dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle

uname
Linux 3ebdbf1d5b48 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / ea130249ae

Max. process+thread count
94 (vs. ulimit of 12500)

modules
C: hbase-client hbase-server U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2228/4/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 28s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 22s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 35s
master passed

+1 :green_heart:
compile
1m 20s
master passed

+1 :green_heart:
shadedjars
5m 47s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
1m  1s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 15s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 36s
the patch passed

+1 :green_heart:
compile
1m 26s
the patch passed

+1 :green_heart:
javac
1m 26s
the patch passed

+1 :green_heart:
shadedjars
6m 14s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
1m  2s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
1m  6s
hbase-client in the patch passed.

+1 :green_heart:
unit
147m 58s
hbase-server in the patch passed.

176m 33s

Subsystem
Report/Notes

Docker
Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2228/4/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2228

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 5c670acf1058 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / ea130249ae

Default Java
1.8.0_232

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2228/4/testReport/

Max. process+thread count
3947 (vs. ulimit of 12500)

modules
C: hbase-client hbase-server U: .

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 15s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
5m 39s
the patch passed

+1 :green_heart:
compile
2m  6s
the patch passed

+1 :green_heart:
javac
2m  6s
the patch passed

+1 :green_heart:
shadedjars
7m 46s
patch has no errors when building our shaded downstream artifacts.

-0 :warning:
javadoc
0m 34s
hbase-client in the patch failed.

-0 :warning:
javadoc
0m 55s
hbase-server in the patch failed.

_ Other Tests _

+1 :green_heart:
unit
1m 50s
hbase-client in the patch passed.

+1 :green_heart:
unit
223m 32s
hbase-server in the patch passed.

263m  7s

Subsystem
Report/Notes

Docker
Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2228/4/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2228

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 589060d61d0a 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / ea130249ae

Default Java
2020-01-14

javadoc
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2228/4/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-client.txt

javadoc
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2228/4/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt

javadoc
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2228/4/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-client.txt

javadoc
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2228/4/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2228/4/testReport/

Max. process+thread count
2627 (vs. ulimit of 12500)

modules
C: hbase-client hbase-server U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2228/4/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@Apache9 @joshelser Can you please review this when you have time? Thank you in advance.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 30s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+0 :ok:
mvndep
0m 23s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 49s
master passed

+1 :green_heart:
checkstyle
1m 48s
master passed

+1 :green_heart:
spotbugs
3m 10s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 13s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 31s
the patch passed

+1 :green_heart:
checkstyle
0m 30s
The patch passed checkstyle in hbase-client

+1 :green_heart:
checkstyle
1m  9s
hbase-server: The patch generated 0 new + 307 unchanged - 10 fixed = 307 total (was 317)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
11m 24s
Patch does not cause any errors with Hadoop 3.1.2 3.2.1.

+1 :green_heart:
spotbugs
3m 14s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 22s
The patch does not generate ASF License warnings.

38m 16s

Subsystem
Report/Notes

Docker
Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2228/5/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2228

Optional Tests
dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle

uname
Linux c505e7a73862 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / c81ef7368e

Max. process+thread count
94 (vs. ulimit of 12500)

modules
C: hbase-client hbase-server U: .

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 15s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
5m  0s
the patch passed

+1 :green_heart:
compile
1m 51s
the patch passed

+1 :green_heart:
javac
1m 51s
the patch passed

+1 :green_heart:
shadedjars
6m 43s
patch has no errors when building our shaded downstream artifacts.

-0 :warning:
javadoc
0m 27s
hbase-client in the patch failed.

-0 :warning:
javadoc
0m 44s
hbase-server in the patch failed.

_ Other Tests _

+1 :green_heart:
unit
1m 11s
hbase-client in the patch passed.

+1 :green_heart:
unit
134m 22s
hbase-server in the patch passed.

167m 30s

Subsystem
Report/Notes

Docker
Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2228/5/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2228

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 6cc2d5e18949 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / c81ef7368e

Default Java
2020-01-14

javadoc
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2228/5/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-client.txt

javadoc
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2228/5/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt

javadoc
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2228/5/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-client.txt

javadoc
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2228/5/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2228/5/testReport/

Max. process+thread count
3968 (vs. ulimit of 12500)

modules
C: hbase-client hbase-server U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2228/5/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
8m 18s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 24s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 47s
master passed

+1 :green_heart:
compile
1m 26s
master passed

+1 :green_heart:
shadedjars
5m 54s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
1m  2s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 18s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 38s
the patch passed

+1 :green_heart:
compile
1m 20s
the patch passed

+1 :green_heart:
javac
1m 20s
the patch passed

+1 :green_heart:
shadedjars
5m 30s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 59s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
1m  4s
hbase-client in the patch passed.

+1 :green_heart:
unit
149m 45s
hbase-server in the patch passed.

185m 40s

Subsystem
Report/Notes

Docker
Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2228/5/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2228

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 326f29661072 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / c81ef7368e

Default Java
1.8.0_232

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2228/5/testReport/

Max. process+thread count
4185 (vs. ulimit of 12500)

modules
C: hbase-client hbase-server U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2228/5/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

Ping @joshelser @Apache9. Thanks.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 18s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+0 :ok:
mvndep
0m 21s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
4m  5s
master passed

+1 :green_heart:
checkstyle
1m 49s
master passed

+1 :green_heart:
spotbugs
3m  9s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 12s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 50s
the patch passed

-0 :warning:
checkstyle
1m 16s
hbase-server: The patch generated 1 new + 341 unchanged - 11 fixed = 342 total (was 352)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
12m 24s
Patch does not cause any errors with Hadoop 3.1.2 3.2.1.

+1 :green_heart:
spotbugs
3m 29s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 24s
The patch does not generate ASF License warnings.

41m  0s

Subsystem
Report/Notes

Docker
Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2228/6/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2228

Optional Tests
dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle

uname
Linux 210a9534b30a 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 25fcc40f6a

checkstyle
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2228/6/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt

Max. process+thread count
84 (vs. ulimit of 12500)

modules
C: hbase-client hbase-server U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2228/6/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 12s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+0 :ok:
mvndep
0m 11s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 49s
master passed

+1 :green_heart:
checkstyle
1m 46s
master passed

+1 :green_heart:
spotbugs
3m  5s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 12s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 48s
the patch passed

+1 :green_heart:
checkstyle
0m 31s
The patch passed checkstyle in hbase-client

+1 :green_heart:
checkstyle
1m 14s
hbase-server: The patch generated 0 new + 341 unchanged - 11 fixed = 341 total (was 352)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
12m 26s
Patch does not cause any errors with Hadoop 3.1.2 3.2.1.

+1 :green_heart:
spotbugs
3m 25s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 21s
The patch does not generate ASF License warnings.

40m  5s

Subsystem
Report/Notes

Docker
Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2228/7/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2228

Optional Tests
dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle

uname
Linux 5173b60ba1b4 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 25fcc40f6a

Max. process+thread count
84 (vs. ulimit of 12500)

modules
C: hbase-client hbase-server U: .

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 15s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
4m  2s
the patch passed

+1 :green_heart:
compile
1m 33s
the patch passed

+1 :green_heart:
javac
1m 33s
the patch passed

+1 :green_heart:
shadedjars
6m 30s
patch has no errors when building our shaded downstream artifacts.

-0 :warning:
javadoc
0m 26s
hbase-client in the patch failed.

-0 :warning:
javadoc
0m 39s
hbase-server in the patch failed.

_ Other Tests _

+1 :green_heart:
unit
1m  9s
hbase-client in the patch passed.

+1 :green_heart:
unit
131m 53s
hbase-server in the patch passed.

162m 57s

Subsystem
Report/Notes

Docker
Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2228/7/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2228

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 87d829ee6b39 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 25fcc40f6a

Default Java
2020-01-14

javadoc
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2228/7/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-client.txt

javadoc
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2228/7/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt

javadoc
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2228/7/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-client.txt

javadoc
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2228/7/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2228/7/testReport/

Max. process+thread count
3937 (vs. ulimit of 12500)

modules
C: hbase-client hbase-server U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2228/7/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 35s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 14s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 40s
master passed

+1 :green_heart:
compile
1m 27s
master passed

+1 :green_heart:
shadedjars
7m  2s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 59s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 16s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 43s
the patch passed

+1 :green_heart:
compile
1m 28s
the patch passed

+1 :green_heart:
javac
1m 28s
the patch passed

+1 :green_heart:
shadedjars
7m  0s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 58s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
1m  4s
hbase-client in the patch passed.

+1 :green_heart:
unit
146m 55s
hbase-server in the patch passed.

177m 35s

Subsystem
Report/Notes

Docker
Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2228/7/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2228

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 30f04493adc3 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 25fcc40f6a

Default Java
1.8.0_232

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2228/7/testReport/

Max. process+thread count
4455 (vs. ulimit of 12500)

modules
C: hbase-client hbase-server U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2228/7/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

Looks the QA is okay.
I moved the nonce operation logic to HRegion.batchMutate() to keep the behavior of the nonce operation. Can you please review this when you have time? @Apache9 @joshelser

@Apache9 @joshelser Can you please review this? I think no behavior change other than what I commented as follows after this change:
https://github.com/apache/hbase/pull/2228#issue-465416205
Thank you in advance.

BTW, this change doesn't break org.apache.hadoop.hbase.client.TestAsyncTableNoncedRetry that checks the nonce operation logic. Thanks.

Ping @Apache9 @joshelser Thanks.

 Let me take a look.

Thank you very much for taking a look at this! @Apache9
I will commit this tomorrow if no objection.


Mocking with Mock Service Worker (MSW)

Hi, first of all, thanks for this amazing library, I find it useful both serverside and in React apps!
This is my first post here, so please let me know if I can provide more info or code samples.
I have been looking into ways of mocking gqty in test cases, and have tried a few different options.
My first attempt was to mock the gqty generated client with Jest and then replace the implementations of query / mutation etc.
jest.mock('../src/gqty', () => ({
This works to some extent but my tests aren't as real-world as I would like them to be.
My latest efforts are to use Mock Service Worker, which is partially working for me, with the following conditions:

gqty uses anonymous operations so MSW graphql.query an graphql.mutation options are not available, instead I had to use graphql.operation.. See https://mswjs.io/docs/getting-started/mocks/graphql-api
gqty appears to use aliases (I think for caching purposes) when building the graphql commands, so the graphql.operation needs to run regexes on the query and match preconfigured operation names.
jsonb fields are also aliased within the query (I guess also for caching purposes), so these would need some regex/pattern matching to resolve (I haven't done this yet)

The following code addresses the first two points above but not the third. I think it would be possible to address the third but it feels quite complex, and I am wondering if there might be another way to solve this.
export const MOCK_GRAPHQL_API = 'http://test-graphql.api/'

jest.mock('next/config', () => () => ({
  publicRuntimeConfig: {
    publicGraphqlUrl: MOCK_GRAPHQL_API
  }
}))
import { SetupServer, setupServer } from "msw/node";
import { RequestHandler, graphql } from "msw";

const mockGraphqlAPI = graphql.link(MOCK_GRAPHQL_API);

export interface MockGraphqlResponse {
  type: string;
  operation: string;
  response: object | object[];
}

let server: SetupServer;

export const mockAPI = (mockResponses: MockGraphqlResponse[]) => {
  const handlers: Array<RequestHandler> = [
    mockGraphqlAPI.operation(async (req, res, ctx) => {
      const m = await req.json()
      // console.log(m)
      const matchedOp = mockResponses.reduce((acc, {type, operation, response}) => {
        // It appears that gqty uses dynamic aliases for mutations/queries.
        // So we use a regex to find the alias and return the given data for the alias
        const typeRe = new RegExp('^(' + type + ')\\(');
        const typeMatches = m.query.match(typeRe)
        const operationRe = new RegExp('\\{(' + operation + '_.*)\:' + operation + '\\(');
        const opMatches = m.query.match(operationRe)
        if (typeMatches && opMatches) {
          const alias = opMatches[1];
          const data = {} as any;
          data[alias] = response;
          acc = { data }
        }
        return acc;
      }, null as any)

      if (matchedOp?.data) {
        return res(ctx.data(matchedOp.data));
      } else {
        return;
      }
    })
  ];

  server = setupServer(...handlers);
  server.listen({
    onUnhandledRequest: 'error',
  })
}

export const closeMockServer = () => {
  server?.close();
}

The above can then be used in test cases as follows:
//Define mock responses for the Graphql operations.
const mockAPIResponses = [{
  type: 'query',
  operation: 'user_by_pk',
  response: {
    id: 'userId123',
    name: 'Test User',
    email<EMAIL_ADDRESS>  }
}];
beforeEach(() => {
  mockAPI(mockAPIResponses);
})
afterEach(() => {
  closeMockServer();
})

This allows my react test cases to fully test the gqty code within the rendering, however it feels a little clunky.
I'm wondering if anyone here knows of a better way of using MSW for this type of testing?
If it was possible to override the aliasing or switch it off in the test cases it may simplify things.

Operation names are added in canary for some hooks, and it is supported for all API in the upcoming new core as we strive to a more complete support on the mocking side.
For a complete server mockibg, we uses graphql-ez ourselves in tests. You may not need it right now, but when your projects grows to that point, please do take a look on our tests for reference!

thanks @vicary for this info, I will take a look at the tests!


Feature/tickets

added a tickets-disabled.md partial for the temporary message (thanks @cirpo)
we can use tickets.md when eventbrite is ready again cc @cirpo @fgandellini
i'm going to auto-approve this PR, just to notify you and speed up the thing :-)

thanks!


Question: get request headers from beast::websocket::stream?

Hello,
At first I've used beast::websocket::streamboost::beast::tcp_stream based on you're async websocket client/server example. Therefore I came to situation that I need to parse the headers on the server side to get the client IP from CDN. I've solved this by rewritting server to hybrid mode, at first do http::async_read and then upgrade with beast::websocket::stream::async_accept. For this I need to declare 4 new variables which are only used to do the http::async_read and parse the headers:
    // http
    boost::beast::tcp_stream stream_;
    boost::beast::flat_buffer buffer_;
    std::shared_ptr<std::string const> doc_root_;
    boost::beast::http::request<boost::beast::http::string_body> req_;
    std::string m_ipHeader;

    // websocket
    std::optional<boost::beast::websocket::stream<boost::beast::tcp_stream>> ws_;

Is there a way to somehow read the headers only from the websocket::stream object? My application is pure websocket, http serving is not needed. It's already 3rd issue I create here but you guys seems very helpful and I think it may be helpful for other developers in the future.
I also want to include my server-side http/websocket acceptor code:
    // first we need to check if http request is with upgrade websocket and get client IP from headers
    req_ = {};
    stream_.expires_after(std::chrono::seconds(30));
    auto self = getThis();
    boost::beast::http::async_read(stream_, buffer_, req_, [self] (const boost::system::error_code& ec, std::size_t bytes_transferred) {
        if (ec) {
            boost::beast::get_lowest_layer(self->stream_).socket().close();
            return;
        }
        if (boost::beast::websocket::is_upgrade(self->req_)) {
            for (auto& h : self->req_.base()) {
                if (h.name_string() == "CF-Connecting-IP") { // cloudflare
                    self->m_ipHeader = std::string(h.value());
                    break;
                } else if (h.name_string() == "X-Real-IP") { // Gcore
                    self->m_ipHeader = std::string(h.value());
                    break;
                } else if (h.name_string() == "Incap-Client-IP") { // imperva
                    self->m_ipHeader = std::string(h.value());
                    break;
                } else if (h.name_string() == "X-Forwarded-For") { // google/amazon
                    if (h.value().find(",")) { // google send 2 IPs
                        self->m_ipHeader = std::string(h.value()).substr(0, h.value().find(","));
                    } else {
                        self->m_ipHeader = std::string(h.value());
                    }
                }
            }
            boost::system::error_code ecc;
            self->m_ip = boost::asio::ip::address_v4::from_string(self->m_ipHeader, ecc).to_ulong();
            if (ecc) {
                self->m_ip = boost::beast::get_lowest_layer(self->stream_).socket().remote_endpoint(ecc).address().to_v4().to_ulong();
            }
            self->ws_.emplace(self->stream_.release_socket());
            self->ws_->set_option(
                boost::beast::websocket::stream_base::timeout::suggested(
                        boost::beast::role_type::server));

            // Set a decorator to change the Server of the handshake
            self->ws_->set_option(boost::beast::websocket::stream_base::decorator(
                [](boost::beast::websocket::response_type& res)
                {
                    res.set(boost::beast::http::field::server,
                            std::string("Boost.Beast/300 Server"));
                }));
            boost::beast::get_lowest_layer(*self->ws_).socket().set_option(boost::asio::ip::tcp::no_delay(true), ecc);
            boost::beast::websocket::permessage_deflate opt;
            opt.server_enable = false;
            self->ws_->set_option(opt);

            self->ws_->async_accept(self->req_, [self](const boost::system::error_code& ec) {
                if (ec) {
                    return self->terminate();
                }
                // START BI-DIRECTIONAL COMMUNICATION HERE
            });
            return;
        } else {
            boost::beast::get_lowest_layer(self->stream_).socket().close();
        }
    });

You can capture when you perform the handshake (on the client side) with the second overload as shown here:
https://www.boost.org/doc/libs/master/libs/beast/doc/html/beast/ref/boost__beast__websocket__stream/async_handshake/overload2.html

@klemens-morgenstern
I am trying to achieve it in server-side. Is there serverside solution too?

Ah sorry, got it now. This is not a  "hybrid mode", a websocket is just a very long http request. So the above code is the way to do this.
The websocket doesn't keep the headers around.
If your issue is that the code doesn't look nice with the callback hell, you might want to look into asio::async_compose. See here for an example: https://cppalliance.org/richard/2020/04/30/RichardsAprilUpdate.html

@klemens-morgenstern
What about limiting server to be able to response to GET requests only? Just to prevent abusing of POST/PUT requests with big body size. Does Beast limit maximum body size? Does it load body to memory even if requested method is GET?

I also need access to the headers server-side in a pure websockets application, in particular the Sec-WebSocket-Protocol field.

Just wanted to report that the workaround suggest by gunzino works for me. Also, manually parsing the HTTP upgrade request is covered in the documentation.
It would be nice to have an websocket::stream::async_accept overload that takes an extra parameter for a user-supplied callback for inspecting the upgrade request and possibly rejecting it.

You can set a limit on the buffer you are using with http::async_read by, for example, passing a limit to the flat_buffer constructor.
Another option would be to instantiate an http::parser and set the body_limit on it, and then use the http::async_read overload that accepts an http::parser.

@klemens-morgenstern
What about limiting server to be able to response to GET requests only? Just to prevent abusing of POST/PUT requests with big body size. Does Beast limit maximum body size? Does it load body to memory even if requested method is GET?

You can set a limit on the buffer you are using with http::async_read by, for example, passing a limit to the flat_buffer constructor.
Another option would be to instantiate an http::parser and set the body_limit on it, and then use the http::async_read overload that accepts an http::parser.


WIP: Add companies as standalone section and page

This is to add companies as standalone section and page to the site. It was partially discussed in opensourcecities/toronto#18 and added in opensourcecities/osc-theme#12.

@RichardLitt what do you think of this? Should we proceed with the distinctions for all the sites?

Awesome! I'm gonna proceed with this for Toronto and Montreal, then you can continue/adjust your work for opensourcecities/toronto#22


[WIP] Enable passing return values from non-C# functions.

Proposed change to function.json schema. As a preliminary step of enabling Durable Functions for Node, this is a rough draft of enabling non-C# function return value passing for functions with a binding including the new "returnsSomething" Boolean parameter (name subject to change,) like so:
"bindings": [
{
"name": "nameJs",
"type": "activityTrigger",
"direction": "in",
"returnsSomething": true
}

@kashimiz,
Thanks for having already signed the Contribution License Agreement. Your agreement was validated by .NET Foundation. We will now review your pull request.
Thanks,
.NET Foundation Pull Request Bot

Can you add a test (or even adhoc) that demonstrates this working end-to-end?

As we discussed, let's open a separate issue to track fully removing HttpBinding. We can't do it right now because that will break code that explicitly checks for the existence of the output binding, like the node worker (which will need to be updated) and any function code that tries to assign the output binding directly.  With this PR, the use of the HTTP binding becomes effectively optional.


Make simple RPC extension.

I think one of the nice things is that this library has minimal Unity dependencies internally. Introducing RPCs would require more knowledge of unity inside the library. This aspect is nice if you want to run a non-unity server. I feel any RPCManager should be written as an extension / addon outside of the core project. 2 cents.

I am writing RPC extension that not compatible with Unity3d RPC (based on UNET). It looks like old RPC in unity3d. And will be compatible only with this library (i think :)).

Was taking a look at your RPC extension.
https://github.com/RevenantX/LiteNetLib/blob/dev_rpc/LiteNetLib/LiteRPC.cs#L144
I noticed we are serializing a large string into the header of every message. Could we key the RPC methods with a short instead?

@NVentimiglia this is "Work In Progress" prototype. Maybe i will create some 64bit hash. I don't know) If you have good working solution - you can suggest)

@RevenantX
What do you think of this draft ?

Allows daisy chaining of RPCs. e.g. Root--> Zones --> GameObjects --> Components
No reflection

https://github.com/NVentimiglia/LiteNetLib/commit/7af28415d98b522f686d9581765249d4bc0562bb

Added simple and fast packet serializer.


Remove unused styles

Is your feature request related to a problem? Please describe.
Probably about half of our css is unused, they should be removed
Describe the solution you'd like
Remove unused css
Describe alternatives you've considered
🦗
Additional context
Get https://www.npmjs.com/package/ngx-unused-css or https://marketplace.visualstudio.com/items?itemName=rcore.rcore-unused-css-classes and try to find unused css classes.  Beware of Angular's shadow dom. Even if they say it's unused, it might still be.
┆Issue is synchronized with this Jira Story
┆Fix Versions: Open-ended research tasks
┆Issue Number: DOCK-1808
┆Sprint: Backlog
┆Issue Type: Story

The extension is saying styles that are obviously used is unused. The npm package is not even looking at the styles.scss and it seems to report very few things (which are used in a weird way by Angular)


Question: mget/mset in cluster mode?

This document: https://aws.amazon.com/premiumsupport/knowledge-center/elasticache-crossslot-keys-error-redis/ mentions that redis-py-cluster can handle getting and setting keys (mget/mset) from slots located in different shards. Is this not possible with ioredis in cluster mode?

Checked out redis-py-cluster. There is no magic. Its just a wrapper that iterates over the keys and performs a regular 'GET`'. Closing this Issue.
def mget(self, keys, *args):
        """
        Returns a list of values ordered identically to ``keys``
        Cluster impl:
            Itterate all keys and send GET for each key.
            This will go alot slower than a normal mget call in Redis.
            Operation is no longer atomic.
        """
        return [self.get(arg) for arg in list_or_args(keys, args)]


Add SF API GraphQL explorer to the template

Issue summary
If we are building a Sales channel we need access to SF API selector in GraphQL explorer so we can run and test queries, even after generating the SF Token using the app we can't run them.

[ x] Upgraded to the latest version of the @shopify packages

Affected @shopify/shopify-* package and version:
Node version: v20
Operating system: mac

[x ] Set { logger: { level: LogSeverity.Debug } } in my configuration

Expected behavior
We should be able to select the API we want to work with in the explorer based if the app is a sales channel or not.
What do you think should happen?
I have access to unauthenticated_read_product_listings but I can't use it in the explorer.

hey that doesn't resolve the issue because the GraphQL app doesn't have all access scopes.


Udpated with new arguments.

HI @toru-takahashi , i've updated the example to reflect new arguments, Can you take a look when you get a chance?

This is already merged by another PR.


Handle empty object references in Image Streams

The ImageStream{}.Tags[].From is a pointer to a corev1.ObjectReference and, and if it's missing, we'll panic because we access a field within without checking if it exists.
This PR updates this logic so that it will only pull the reference if it exists. A corresponding test entry has been added.

/test 4.13-e2e


Update readme with gif of trace window

shows features of tracing tool since the newest version
fixes #55

It's lovely :sparkles:
(and I like how it is representative of our actual todos :D )

Great!


How to get this dirs? I can't find These imgs.

fg_path_test = 'data/fg_test/'
a_path_test = 'data/mask_test/'
bg_path_test = 'data/bg_test/'

These photo data need to contact Adobe

These photo data need to contact Adobe
Thanks, I got in touch

If I don't have an Adobe dataset, can I run a certain file of the project?
E.g. demo.py or test.py


Testing of model, argument parsing options and automatic logging in corresponding wandb run.

Forgot to add python-dotenv to requirements.txt to build test will likely fail.


502 Bad Gateway [mupx]

Sometime we´re getting a "502 Bad Gateway" error on our Server, particularly when it tries to load a bunch of static resources at once occasionally one of the requests gets back a "502 Bad Gateway".
It seems meteor isn´t responding quickly enough to the requests and Ngix is dropping them.
Is there a way to increase the timeout for Ngix on a mupx deployment?

Isn't the timeout a 504?
http://nginx.org/en/docs/http/ngx_http_proxy_module.html#proxy_read_timeout
the timeout default is 60 seconds?

in mupx nginx runs in a container via...
https://github.com/arunoda/meteor-up/blob/mupx/templates/linux/start.sh#L58
and that's the mup-frontend-server
https://github.com/meteorhacks/mup-frontend-server
There it in turns runs another
https://github.com/meteorhacks/mup-frontend-server/blob/master/run.sh
calls meteorhacks:mup-ssl-server
This currently appears to be not listed officially?
I don't see anyway settings like proxy_read_timeout are easily transferring over there?
...so it would probably qualify this issue as a feature request.
You could try the settings and even environment variables somehow just to see if maybe somehow?

Yea, I guess the right error code should be a 504, yet when I restart/deploy the app, I also seem to get the 502 error for the brief time it´s unavailable... Not quite sure why...


Closes #1: Only include disqus in jekyll production mode.

For an explanation, see:
https://github.com/bk2dcradle/Chaplin/issues/1#issue-145389458

Hey, thanks for pointing it out. Thing is I, there shouldn't be two branches, only one, i.e gh-pages.
So give me a few minutes, I will delete the master branch so the repo only has gh-pages


[Image] Add support for an image caption.

[Image] Add text overlays #3459
Use the format: [Image] Add support for a caption
Closed Issues
#3459
Description
Added support to be able to use a caption with an .ui.image

Such functionality was implemented as a dimmer-variant in Fomantic-UI 2.6.4
See http://fomantic-ui.com/modules/dimmer.html#partially-dimmer
Thanks for the idea @kenhkelly

@lubber-de Cool! Guess this project died off right around when I opened this. I will check out Fomantic-UI


Support VT-x nesting?

Can HyperPlatform work(nest) with other VT-x/EPT project except VMware and VirtualBox?
I tried HyperPlatform with some VT-x projects and all of them crashed the vmware's virtual CPU while initializing.
it even crashed when I tried to load HyperPlatform twice.

Hi,
No. HyperPlatform works inside VMware or any VMs supporting virtualized VT-x, but not with any hypervisors including HyperPlatform is self.
This is by design at this time, but there is an enhancement request for this design limitation (https://github.com/tandasat/HyperPlatform/issues/14).


Add a MIT license for this project

Sorry in advance if this belongs somewhere else other than feature request, let me know if you want me to move it elsewhere.
Is your feature request related to a problem? Please describe.
Yes, the problem is that I can't legally use this component because it doesn't have a license that explicitly says that it's free to be used, so the default copyright laws are applied. This means all rights are reserved to the author and I can't legally copy, distribute, or create derivative work from the code. This also applies to the npm package, even tho it's publicly available the default copyright laws still applies.
Describe the solution you'd like
Add a license that clearly describes how a individual can use this code (preferably a MIT licence)

hey! sorry for the delay. sure, it deserves a license. I'll add it whenever possible

https://github.com/guilhermerodz/input-otp/commit/6d74289761f3c24fbb2ab907aff481e1038b7e06


Don't log tokens in JdbcTokenStore

Please review this simple patch which prevents logging tokens in JdbcTokenStore. The patch fixes #1472

Thanks for the PR @artem-smotrakov. This is now in master.


fzf: missing manpage

Issue description
Fzf has a manpage as you can see athttps://github.com/junegunn/fzf/tree/36702737191c2fc26290dee531095f7d66f3461e/man/man1
but it is not installed with fzf.

buildGoPackage defines outputs = args.outputs or [ "bin" "out" ];
What you could do is define outputs = ["bind" "man" "out"]; and extend the postInstall to move the man pages to the man output.
http://nixos.org/nixpkgs/manual/#multiple-output-file-type-groups

Ok, will try. Also, isn't there an error in that manual? It says is '$outputMan: is for man pages (except for section 3). They go to man or doc or $outputBin by default.How can it go intomanif it already is in$outputMan`?

I can't even get it to install normally with a nixpkgs clone :(
no idea what's wrong
installing ‘go1.7-fzf-0.15.9’
these derivations will be built:
  /nix/store/x0d1yxw2h7zcfi4hjhwzafzw9n06k7l8-go1.7-fzf-0.15.9.drv
building path(s) ‘/nix/store/c4qkdnbkjqgkswcvl3p6mlc62qy1icdg-go1.7-fzf-0.15.9’, ‘/nix/store/ijac3vkld9kn166y2dkwhi0mdv2dn7xq-go1.7-fzf-0.15.9-bind’
unpacking sources
unpacking source archive /nix/store/4hq1nwgiqa5ka5izybsj320fj24xz59g-fzf-0.15.9-src
source root is fzf-0.15.9-src
patching sources
configuring
grep: Invalid range end
unpacking source archive /nix/store/nw94wyz4qcw5d1mvhk61r66r75spbrzz-go-isatty-66b8e73
unpacking source archive /nix/store/4sxxnbzd6vj9zn919kwxl7svqpal522r-go-runewidth-63c378b
unpacking source archive /nix/store/mkz4pcccg9syazjqjhqjyd7bx0waymi2-go-shellwords-35d512a
building
github.com/junegunn/go-isatty
github.com/junegunn/fzf/src/util
github.com/junegunn/go-isatty
github.com/junegunn/fzf/src/util
github.com/junegunn/fzf/src/algo
github.com/junegunn/fzf/src/tui
# github.com/junegunn/fzf/src/tui
ld: warning: /System/Library/Frameworks/CoreFoundation.framework/Versions/A/CoreFoundation, ignoring unexpected dylib file
github.com/junegunn/go-isatty
github.com/junegunn/go-runewidth
github.com/junegunn/fzf/src/tui
github.com/junegunn/go-shellwords
github.com/junegunn/fzf/src/util
github.com/junegunn/fzf/src/algo
# github.com/junegunn/fzf/src/tui
ld: warning: /System/Library/Frameworks/CoreFoundation.framework/Versions/A/CoreFoundation, ignoring unexpected dylib file
github.com/junegunn/fzf/src
github.com/junegunn/go-isatty
github.com/junegunn/fzf/src/tui
github.com/junegunn/go-runewidth
github.com/junegunn/go-shellwords
github.com/junegunn/fzf/src/util
github.com/junegunn/fzf/src/algo
# github.com/junegunn/fzf/src/tui
ld: warning: /System/Library/Frameworks/CoreFoundation.framework/Versions/A/CoreFoundation, ignoring unexpected dylib file
github.com/junegunn/fzf/src
github.com/junegunn/fzf/src/fzf
installing
/private/var/folders/f9/659cvst9763_lpjmfmqvvtnw0000gn/T/nix-build-go1.7-fzf-0.15.9.drv-0/go /private/var/folders/f9/659cvst9763_lpjmfmqvvtnw0000gn/T/nix-build-go1.7-fzf-0.15.9.drv-0
/private/var/folders/f9/659cvst9763_lpjmfmqvvtnw0000gn/T/nix-build-go1.7-fzf-0.15.9.drv-0
mkdir: missing operand
Try 'mkdir --help' for more information.
builder for ‘/nix/store/x0d1yxw2h7zcfi4hjhwzafzw9n06k7l8-go1.7-fzf-0.15.9.drv’ failed with exit code 1
error: build of ‘/nix/store/x0d1yxw2h7zcfi4hjhwzafzw9n06k7l8-go1.7-fzf-0.15.9.drv’ failed

Oh haha, you had a typo in your post :)

How can I build fzf again once I've built it before? Just to see the build happening again?
With nix-build ~/code/nixpkgs/pkgs/top-level/all-packages.nix -A fzf I get error: cannot auto-call a function that has an argument without a default value (‘system’). What can I do to fix this?

I don't know, can't help you with this one.

@LnL7 on irc helped me out, I had to use nix-build ~/code/nixpkgs -A fzf --check.


Added models for Create Deployment

This has been superseded by #26, #27, #28

Overtaken by other PRs


Add section for comparing your implementations with original papers!

Hi
I've tested a few of your implementation and compared the results with original papers. but the results were not even close to the original ones. It will be good to have a section which we can see your implementation results on benchmark datasets(PASCAL VOC, Cityscapes). so we will know if we are doing something wrong or not!
thanks
@qubvel

Hi @ali-masoudi
I am not going for now train models with such datasets
Final results depends on a lot of different factors:

model architecture
image preprocessing
data sampling
training hyperparams like optimizer, lr sheduling, losses
etc.

Even if you will have this params described in paper this will not guarantee to reproduce result.
I am not concentrated on training pipeline. I would like to give you an easy tool with flexibility to build your own model for you experiments. That is why there are a lot of parameters that can be passed while model initialization.
If you have a goal to reproduce result, I would be happy to answer your questions regarding models architectures. May be you will be able to find best params or bugs in architectures, please let me know opening an issue or creating a PR.


'onnxruntime_cxx_api.h' file not found

环境：
mac m1
Building for simulator (x86_64) SHERPA_ONNXRUNTIME_LIB_DIR: /Users/yaoyajie/open-source/sherpa-onnx/build-ios/ios-onnxruntime/onnxruntime.xcframework/ios-arm64_x86_64-simulator
error msg:
open-source/sherpa-onnx/sherpa-onnx/csrc/cat.h:9:10: fatal error: 'onnxruntime_cxx_api.h' file not found
#include "onnxruntime_cxx_api.h"  // NOLINT

该怎么解决呢，多人多台设备尝试均是此错误

Please see https://github.com/k2-fsa/sherpa-onnx/pull/430
It has been merged and please use the latest master.

thanks,  The project can run normally, but without the TTS related Api interface, I am unable to perform it. it only contain SherpaOnnxRecognizer

thanks, The project can run normally, but without the TTS related Api interface, I am unable to perform it. it only contain SherpaOnnxRecognizer

Will add tts API for iOS before Sunday. Please wait for a while.

@csukuangfj thanks,
 the model is large for iOS app, The probability of crashing is increasing - oom . Is there any way to solve this problem?

Which model is large for iOS?

You can always  use the .int8.onnx model.

You can always use the .int8.onnx model.

OK ,thanks, I will try!

Sorry, do you have any plans to provide TTSDemo for testing? I will provide a detailed test report

出ios demo 的，正在写

Thank you very much to the author. The TTS voice broadcasting sound is very good. The only concern currently is that the mobile end integrates onnxruntime. xcframework, which also has 60M in a release environment. Additionally, with vits-aishell3. int8. onnx 39M, the resource file size is nearly 100M, which is not acceptable on the mobile end. How can we reduce the package size？

The only concern currently is that the mobile end integrates onnxruntime. xcframework, which also has 60M in a release environment.

It is a static library and the final executable can be further stripped. Have you tried that?

The above is the archive file size (without model files).

Here is the file size of the final IPA, not including model files.
You can see that it is only 5.3MB.

thanks, i will Integrate into project summary for packaging testing, thank you


Make React a peer dependency?

I ran into a problem late last week where, after I upgraded my node.js + webpack (client-side) app to react 0.12, the flux-router-component NavLink started spitting out gobbledygook. If I copied that file into my source directory, and included it that way, everything worked (with warnings, because NavLink uses react syntax/features that have been deprecated in 0.12). Closer inspection of my JS rollup client-side shows that webpack is including two versions of React in my rollup - 0.12.0, which I include, and 0.11.1, which flux-router-component declares as a dependency. It seems likely that this is because of the way flux-router-component declares its dependency on react.
I think that declaring React a Peer Dependency will alleviate this issue. As I read it, npm will then install react for anyone who uses 'npm install' to install flux-router-component, and it will complain if the versions aren't compatible. I'm also fairly new to node + npm + webpack, so I could be totally off...

It's a good pratice for a react library to have it as peer dependency. It saves us a lot of time and bugs.
https://github.com/facebook/react/issues/2402

To clarify my previous comment, it makes little difference whether you make it a peerDependency or just don't list it in the dependencies.
If you put in the readme a mapping of flux-router-component releases to react releases it'd be much more useful.

react
flux-router-component

0.12.x
0.5.x

0.11.x
<0.5

numbers above made up for example purposes

@brigand Sure.  I can add a table like you proposed to the README.  The source of truth is always in the package.json.

@brigand Added, https://github.com/yahoo/flux-router-component/blob/master/README.md#compatible-react-versions

It makes a lot diference. React is the in a peerDependency. If you, like me, uses flux-router-component on the server AND client; You gonna have trouble if you update react and not reinstall flux-router-component. Like I just did today and lost 4 hours.
It runs a different version on the server (the one npm installed just for flux-router-component) and on the client uses the new you installed for your project. Making it a peerDependency (with version boundaries and so) solves it.
It's a recommendation from React.js guys for libraries and every other lib/component that I'm aware of uses React this way.
Please, take in consideration this issue. It's not about peerDependencies being a good feature, but about being the best one available.

@peleteiro  I am digging into the issues we might've had with peer dependencies in the past, to see if those were significant enough to stop this change.  I hope they are not.  Will get back to you soon.

@peleteiro
Ok. We have seen issue with npm shrinkwrap, when there is a peerDependencies declared (say react), but its parent module does not have it as dependency.  Then the issue is npm install still installs react as an extraneous package.  But then when you run npm shrinkwrap, it will fail.
This might not be a big issue in our case, as very likely the app will include react as dependency.  But then there will be more hairy issues when it comes to npm link and other things :(   Check out this super-long debate npm issue about deprecating peerDependencies: https://github.com/npm/npm/issues/5080
There are suggestions about using dependencies and npm dedupe in that thread as well.  But I am not 100% sure if that is the magic bullet either.

I updated my npm modules today and I started to get an error: Cannot read property 'firstChild' of undefined.
It was flux-router-component having it's own version of React again.
http://stackoverflow.com/questions/27153166/typeerror-when-using-react-cannot-read-property-firstchild-of-undefined
rm -rf node_modules/flux-router-component/node_modules/react will fix it.

Yeah, that is frustrating.  Lets bite the bullet, see what other pandora's box it will open :)  I will file a PR.

I still think just leaving it out of the dependencies is the smartest move from a technical standpoint.  There's no gain to putting it in peerDependencies or dependencies, other than correctness and readability of package.json.
When in doubt, don't break things imo.

other than correctness and readability of package.json

I think that's important.
Also, even if we put it in peerDependencies it'll probably end up in devDependencies so during continuous integration/deployment, it'll get installed. peerDependencies are not installed via $ npm install.

Understood, I guess we'll have to agree to disagree and hope for the best.

0.5.8 released for addressing this issue: https://github.com/yahoo/flux-router-component/releases/tag/v0.5.8
We had to add react also to devDependencies to get unit tests to pass with npm 1.x, because npm 1.x does not install peerDependencies, while npm 2.x does.


feat: Add a pizza fact

Description
This PR adds a pizza fact
What type of PR is this? (check all applicable)

[ X] ☝ Add a pizza fact or trivia
[ ] 🧑🍳 Add a pizza recipe
[ ] 🗺 Add a regional pizza
[ ] 🍴 Add a traditional food
[ ] 📝 Documentation Update

Related Tickets & Documents
Related to #36
Added to documentation?

[ ] 📜 README.md
[ X] 🙅 no documentation needed

[optional] What GIF best describes this PR or how it makes you feel?

@prw760 we've merged a PR before yours. So, please resolve the merge conflicts before we review your PR.
Thank you! 🙂

Hi, Ayu.   I accepted your changes, but I cannot click the resolve conflicts area because I don't have write access to the main repo.  Do I have an actionable still -- or am I waiting for the repo managers?   Thanks again for your patience while I'm learning.

Hey @prw760,
Answering your question, whenever you see merge conflicts in you PR, you need to resolve them yourself.
Most of the time, maintainers won't do this for you because they don't have the resources to do so.
I've actually gave you the link to resolve conflicts in my previous comment, but I'm dropping it here again.
I wrote a blog post as well about resolving merge conflicts if you'd like to learn further. 🙂

If you haven't deleted your local branch, I encourage you to try resolving the merge conflicts to practice. 😊


Insert of an extra C if there are cystines in the classI/classII

In the CTEP 029 case, Mariam noticed that the TP53 sequence did not match the one represented in the candidates 51mer.fa.manufacurability. The C's in purple should not be there.

The problem seems to be that when there is a C within the classI or classII, the code appends an extra C. The script does not account for cystines within the classI and classII.
https://github.com/griffithlab/neoag_vaccine_scripts/blob/7de6ef1c074b83af12a146f724e9780f4f322410/scripts/color_peptides51mer.py#L208-L218

Resolved by removing some logic:
https://github.com/griffithlab/neoag_vaccine_scripts/blob/66fc980e2f02f6083038250bbe93a95fc94a8e0c/scripts/color_peptides51mer.py#L195-L224
To look like this:
https://github.com/griffithlab/neoag_vaccine_scripts/blob/1514326d1f42a610212c93c9fb9397b2c9d59635/scripts/color_peptides51mer.py#L204-L228
The logic of how the values of each amino acid is set is a little confusing. A TP53 sequence which looks like this:

Is represented view the AminoAcid class like this:
Nucleotide:  S
Open Tag:  False
Close Tag:  False
Bold:  False
Color:  False
Underline:  False
Large:  False
Nucleotide:  G
Open Tag:  False
Close Tag:  False
Bold:  False
Color:  False
Underline:  False
Large:  False
Nucleotide:  T
Open Tag:  False
Close Tag:  False
Bold:  False
Color:  False
Underline:  False
Large:  False
.
.
.
Nucleotide:  T
Open Tag:  False
Close Tag:  False
Bold:  False
Color:  False
Underline:  False
Large:  False
Nucleotide:  C
Open Tag:  True
Close Tag:  False
Bold:  False
Color:  False
Underline:  False
Large:  True
Nucleotide:  T
Open Tag:  True
Close Tag:  True
Bold:  False
Color:  False
Underline:  False
Large:  False
.
.
.
Nucleotide:  L
Open Tag:  False
Close Tag:  False
Bold:  True
Color:  True
Underline:  False
Large:  False
Nucleotide:  W
Open Tag:  True
Close Tag:  True
Bold:  True
Color:  False
Underline:  False
Large:  False
Nucleotide:  V
Open Tag:  False
Close Tag:  False
Bold:  True
Color:  False
Underline:  False
Large:  False
Nucleotide:  D
Open Tag:  False
Close Tag:  False
Bold:  True
Color:  False
Underline:  False
Large:  False
Nucleotide:  S
Open Tag:  False
Close Tag:  False
Bold:  True
Color:  False
Underline:  False
Large:  False
Nucleotide:  T
Open Tag:  False
Close Tag:  False
Bold:  True
Color:  False
Underline:  False
Large:  False
Nucleotide:  P
Open Tag:  True
Close Tag:  True
Bold:  False
Color:  False
Underline:  False
Large:  False
Nucleotide:  P
Open Tag:  False
Close Tag:  False
Bold:  False
Color:  False
Underline:  False
Large:  False
So the character after the final character that needs to format "holds" the closing tag. Also note that this code will put span tags around characters that need no formatting. This also seems like it might be confusing/incorrect.
See example of what the HTML output would look like:


Support JavaScript

Currently the template tool only supports TypeScript.
To support JavaScript, basically here is what you need to do:

in scripts/create-next-app.js -> createNextApp(), change to not using --ts flag when creating the NextJS application
we need a separate template folders containing corresponding templates (pages and layouts) that are coded in JavaScript instead (.jsx, .js)

Hi @xmliszt,
I'm willing to work on this issue. But can you please explain the second point ?

Hi @xmliszt, I'm willing to work on this issue. But can you please explain the second point ?

Hi @ptech12, thanks a lot! Sure let me explain:
If you look at the source code under template/ folder, you realise all the files are currently in TypeScript. So in order to support JavaScript, I think we need to have a corresponding copy of JavaScript file. So I'm thinking we refactor the code base in the following structure:
Previous
template/
     | -- components/ (contains typescript files)
     | -- layout/ (contains typescript files)
     | -- page/ (contains typescript files)

New
template-ts/
     | -- components/ (contains typescript files)
     | -- layout/ (contains typescript files)
     | -- page/ (contains typescript files)
template-js/
     | -- components/ (contains javascript files)
     | -- layout/ (contains javascript files)
     | -- page/ (contains javascript files)

@ptech12 let me know if you have any other questions along the way :) Thanks for your help!


RFC: Add Windows Hypervisor Platform APIs

I'm looking to get some advice on how to get this merged. This adds the Windows Hypervisor Platform APIs.
There is one type that has been especially troublesome, WHV_UINT128. It represents a 128 bit integer. I have had to manually specify the alignment on it and all unions using it to ensure it has the correct 16 byte alignment. Unfortunately u128 in Rust is not stable over the FFI boundary and in any case, it currently has the wrong alignment, see https://github.com/rust-lang/rust/issues/54341
It seems to me that at least the following still need doing:

[ ] Structs/unions should have tests to at least ensure they are the expected size/alignment
[ ] .def file needs writing for non msvc platform - only x86_64 is supported by WHVP.

Because WHV_UINT128 does require #[repr(align(16))] I will likely be unable to merge this until work on winapi 0.4 commences.


In what ways does the IPW option change the role of covariates?

Hello,
The option IPW or inverse probability weighting causes the model to potentially exclude observations based on covariates. My interpretation is that there is some propensity score matching being done with these covariates, and that it is similar to the inverse propensity score reweighting being described by Abraham and Sun (2018) in their appendix C. Is this correct, or is this only a reweighting of cohorts based on cohort size like many other weighting methods?
Also: does this mean that the role of covariates (when the IPW option is specified) is solely a means of matching treated individuals to matched untreated individuals or comparing a weighted average of treated individuals to a weighted average of untreated individuals with similar enough propensity scores?
Best,
Halvard

Hi @Halvard123,
The ipw=TRUE set of options implement a reweighting of control units based on the propensity score modeled using supplied covariates, and using these propensity scores as weights in the final event study regression. You are correct that when ipw=TRUE, covariates are only used in estimating the propensity score, but do not enter the final event study regression directly.

I'm closing this issue for now as it seems the question was answered, but feel free to re-open if not.


What breakpoint library should I use?

I'm using a single bam file, hg19 as reference, and the breakpoint library dated 20150129, but breakseq does not produce any result. Is the breakpoint library only applicable to hg37? Should I use a different breakpoint library?

I have the same problem. I ran breakseq2 using hg38 as reference and got an empty vcf.

Hi @jiangyuanluo and @YiweiNiu , the breakpoint library file should be in the same reference as the BAM being used. The BreakSeq library posted at http://sv.gersteinlab.org/phase1bkpts/breakseq2_bplib_20150129.zip seems to be for hg37. In order to use it with hg19, it would need to be modified to fix the chromosome names in the files to be hg19 style. For using the breakpoint library with hg38, it would need to be lifted over to hg38. One simple way is to lift the GFF file in the breakpoint library to hg38 and use the GFF as the input. However, this would only work for deletions. I am attaching a tar-gzipped archive of the library which should work for hg19. Please give it a try and let me know if it worked or not.
breakseq2_bplib_20150129.hg19.tar.gz

Hi @marghoob Thank you for providing the breakpoint library for hg19. I tested and it worked on my bam files.


Remove deprecated org.gradle.logging.LoggingManager

Context
See #15599

@bot-gradle test RFM

Sorry some internal error occurs, please contact the administrator @blindpirate

@bot-gradle test QF

@bot-gradle test QF

OK, I've already triggered QuickFeedback build for you.

OK, I've already triggered QuickFeedback build for you.

@bot-gradle test this

@bot-gradle test this

OK, I've already triggered ReadyForMerge build for you.

OK, I've already triggered ReadyForMerge build for you.

Superseded by #15767

Superseded by #15767