executor: enable extra coverage on OpenBSD

Recently added[1] to the kcov implementation on OpenBSD.
[1] https://github.com/openbsd/src/commit/8430bc4bce9f93dce843b53971377b7afd96cdb1

On Sat, Aug 01, 2020 at 11:58:39PM -0700, Dmitry Vyukov wrote:

@dvyukov commented on this pull request.

@@ -66,6 +66,13 @@ static void cover_open(cover_t* cov, bool extra)
unsigned long cover_size = kCoverSize;
if (ioctl(cov->fd, KIOSETBUFSIZE, &cover_size))
fail("ioctl init trace write failed");

if (extra) {

struct kio_remote_attach args;

args.subsystem = KCOV_REMOTE_COMMON;

args.id = 0;

Shouldn't this use procid somewhere? Without passing procid to the kernel, I am not sure it can possibly work.
The point of remote coverage is to associate coverage from a background kernel thread/interrupt with a particular syzkaller test process N. If there is something happens in a background thread, kernel needs to know what is that associated N to attribute that coverage to.
Also I assume some kernel annotations were added as well for some subsystems, right? Without kernel annotations remote coverage won't collect anything. At least that's how it works on linux and how it's supposed to be used.

KCOV_REMOTE_COMMON is a special thing where the id field is assigned by
the kernel. All tasks and timeouts that are scheduled by the syzkaller
process that issued the KIOREMOTEATTACH command ends up being traced.

On Sat, Aug 01, 2020 at 11:58:39PM -0700, Dmitry Vyukov wrote: @dvyukov commented on this pull request. > @@ -66,6 +66,13 @@ static void cover_open(cover_t* cov, bool extra) unsigned long cover_size = kCoverSize; if (ioctl(cov->fd, KIOSETBUFSIZE, &cover_size)) fail("ioctl init trace write failed"); + if (extra) { + struct kio_remote_attach args; + args.subsystem = KCOV_REMOTE_COMMON; + args.id = 0; Shouldn't this use procid somewhere? Without passing procid to the kernel, I am not sure it can possibly work. The point of remote coverage is to associate coverage from a background kernel thread/interrupt with a particular syzkaller test process N. If there is something happens in a background thread, kernel needs to know what is that associated N to attribute that coverage to. Also I assume some kernel annotations were added as well for some subsystems, right? Without kernel annotations remote coverage won't collect anything. At least that's how it works on linux and how it's supposed to be used.
KCOV_REMOTE_COMMON is a special thing where the id field is assigned by the kernel. All tasks and timeouts that are scheduled by the syzkaller process that issued the KIOREMOTEATTACH command ends up being traced.

Ah, ok, this makes sense.
Now I am remembering the reason why we went with explicit IDs and considered them as a mandatory part is because our first/main use case, USB, required explicit IDs because all hubs that we trace are global and created during boot.


OwinFeatureCollection: regression

After some recent changes in the hosting pipeline, the OwinFeatureCollection is no longer handling requests (requests do not even get read by the request pipeline). If I populate a FeatureCollection using an OwinFeatureCollection, the requests gets handled by the request pipeline but the response never surfaces out to the client.

After further investigation, the failures are happening as the setter is throwing a NotSupportedException. Certain features like the one for service providers, send file and request cookies are being set triggering the exception. If one removes the throw statement, nothing is fixed and the same client side behaviour persists.

Stack trace?

The method in question is the indexer's setter. Will add a stack trace later.

@borgdylan I'm interested in what changed that started to cause these problems.

https://github.com/aspnet/Hosting/commit/435215b542586f2ab2f2a34df8e89b5bc7e52873
This I bet. The context factory assumed the incoming feature collection was read-only, so it wrapped it in mutable  collection. That wrapper was dropped in the last change, so it sounds like you're getting a notsupportedexception trying to call Set on a read-only feature collection.
Sent from my Windows Phone

From: David<EMAIL_ADDRESS>Sent: 2/28/2015 10:37 PM
To<EMAIL_ADDRESS>Cc: Chris<EMAIL_ADDRESS>Subject: Re: [HttpAbstractions] OwinFeatureCollection: regression (#207)
@borgdylan I'm interested in what changed that started to cause these problems.

Reply to this email directly or view it on GitHub:
https://github.com/aspnet/HttpAbstractions/issues/207#issuecomment-76583131

Ah, good catch.

@Praburaj Can you look at this? It's a regression caused by the code changes we made as a result of the API review. Add a test for it as well.

@davidfowl  I agree with @Tratcher that this started to occur with IFeatureCollection being needed instead of an env object in the request handling delegate.
@Tratcher  Wrapping inside a mutable feature collection solves the exception issue as I have tried it. But the response body still does not get sent back to the client side.

As an aside, Kestrel uses the mutable FeatureCollection directly. With that technique requests work OK. However I do get SignalR errors with respect to invalid delegate instructions.

@borgdylan @Tratcher @davidfowl - I'll have a look at this today and add a test as well.

@borgdylan what's the best way to reproduce this issue?

I tried running a couple of OWIN based entropy samples and they seem to run fine.

i have an updates server factory for nowin. Ill put it on github and you can try with it. It is what I am using.

https://github.com/borgdylan/nowinfactory

@borgdylan these changes already look to be in https://github.com/aspnet/Entropy/tree/dev/samples/Owin.Nowin.HelloWorld sample. This app seems to run fine. Does it require more than this to reproduce this issue?

My code is similar but has a logger for exceptions. With that the code will fail but the exception will be silently hidden.
Regards,
Dylan Borg B. Sc. (Hons) ICT (Melit.)
<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>+00356 99214902
Date: Mon, 2 Mar 2015 14:49:08 -0800
From<EMAIL_ADDRESS>To<EMAIL_ADDRESS>CC<EMAIL_ADDRESS>Subject: Re: [HttpAbstractions] OwinFeatureCollection: regression (#207)
@borgdylan these changes already look to be in https://github.com/aspnet/Entropy/tree/dev/samples/Owin.Nowin.HelloWorld sample. This app seems to run fine. Does it require more than this to reproduce this issue?
—
Reply to this email directly or view it on GitHub.

@borgdylan Thanks. Got it.
Sent out a PR. https://github.com/aspnet/Hosting/pull/174

merged the fix https://github.com/aspnet/Hosting/commit/fde3b0d2af5a7d8b595ef4f42e793c6263482caa


Update dependencies

Update bazel to 6.3.2 (from 5.3.0)
Update rules_python to 0.25.0 (from 0.11.0)
Update google-java-format to 1.17.0 (from 1.15.0)
Update buildifier-prebuilt to 6.3.3 (from 5.1.0)

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Added commands, version check and now throws exception

Added tests for dashboard client

I've merged the changes from this PR into https://github.com/UniversalRobots/Universal_Robots_Client_Library/pull/127 and will do the review / final changes there.


Upgrading to scalajs 1.1.0

Updated to use sbt-scalajs since crossProject as deprecated and removed
after scala.js-0.6.x
Updated to circe 0.13.0, first release supporting scalajs 1.0.0.
Still have to upgrade boopickle once it's released for scalajs 1.0.0.
https://github.com/suzaku-io/boopickle/pull/118
Closes https://github.com/cornerman/sloth/pull/50

Thank you - that is great!
I think, we can just drop boopickle instead of waiting, because it is only used in tests. So there we would just use circe instead. It should be enough to show it works.

@cornerman on the very last commit on this PR I removed the dependency on boopickle.
However we still depend on chamaleon which itself depends on boopickle.
See https://github.com/cornerman/chameleon/pull/53.

Awesome. Thank you! Will need to wait for chameleon then :)

@vic @cornerman FYI: couldn't wait for boopickle to be fixed, so I build local releases of boopickle (current master branch) and chameleon/sloth of @vic PR's (with minor changes, upgradeing kind-projector to 0.11.0 and sjs to 1.0.1) and everything compiles and runs flawlessly

@ioleo Thank you! Great to know :)

Boopickle is now on Sonatype :-)
https://repo1.maven.org/maven2/io/suzaku/boopickle_sjs1_2.13/

@cornerman removed  the WIP tag from this branch, all test green. Feel free to review now.

This is released in version 0.3.0 now!


Tags API Data Disappears

When i run a publish i have the data and i see the tags immediately when i query the /api/v1/tags. The weird this is that after the metadata rebuild the tag disappears and is no longer showing in the call to /api/v1/tags.
I can replicate this issue if you use a start time of now() in my case<PHONE_NUMBER>358). The tags stick around. If you use a start time of<PHONE_NUMBER>000. The tags disappear after rebuild. Is there some time constraint on listing of the tags? Below is memory.conf for testing purposes.......
atlas {

  core {
    model {
      step = 1 minute
    }

    db {
      class = "com.netflix.atlas.core.db.MemoryDatabase"
      //class = "com.netflix.atlas.core.db.StaticDatabase"

      // How often to rebuild the index for the memory database
      rebuild-frequency = 8s

      // 1h with 1m step
      block-size = 60

      // 6h of data overall
      num-blocks = 6
    }
  }

  webapi {
    main {
      port = 7101
    }

    graph {
      // Change default start time on graph to smaller range more typical for testing
      start-time = e-30m
    }

  publish {

      // Max age for a datapoint. By default it is one step interval. If the timestamps are
      // normalized locally on the client 2 times the step is likely more appropriate.s
      max-age =  600000000
    }
  }

  akka {
    api-endpoints = ${?atlas.akka.api-endpoints} [
      "com.netflix.atlas.webapi.PublishApi"
    ]
  }
}

Looking at the times:
1465416849358 => Wed, 08 Jun 2016 20:14:09 GMT
1465326029000 => Tue, 07 Jun 2016 19:00:29 GMT

Assuming now, is the first time, the second time would be too old and should get rotated out. From the sample config:
      // 1h with 1m step
      block-size = 60

      // 6h of data overall
      num-blocks = 6

So it should only keep up to the last 6h of data. In practice it will be 5 to 6 hours for a time series that is regularly reported.

yea i'm an idiot........it was a long yesterday sorry about this......


Adding SonarCloud Config for AutoScan

Fix #1553

Added .sonarcloud.properties file to the root directory. This will
allow the DevOps team to configure auto-scan in SonarCloud so we can
review the output. This may get rolled back if we aren't satisfied.

Signed-off-by: Trevor Conn<EMAIL_ADDRESS>

Codecov Report

Merging #1604 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1604   +/-   ##
=======================================
  Coverage   25.68%   25.68%
=======================================
  Files         121      121
  Lines       10867    10867
=======================================
  Hits         2791     2791
  Misses       7896     7896
  Partials      180      180

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1e74f75...231987c. Read the comment docs.


[Outlook] (shared scenarios) item is null if address is hidden from u…

…ser's address list

Docs Build status updates of commit 60179c1:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/outlook/delegate-access.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit 1ce53ec:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/outlook/delegate-access.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


Separate project source files in persistence and domain layers

The project as it is now is organized in a raw list of files. However, there is at list two clear levels of abstraction:

The PERSISTENCE (or storage) layer is the group of entities that deals with the repository (or, in general, database structure) operations. Basically, all files that deals with GIT are to be here.
The DOMAIN is te group of entities that represents the queue objects, at a higher (independent from storage and particular technology-based descriptions) level.

It would be easy and convenient to make explicit those layers by creating two folders inside the root source folder and sorting the files between them.

I've created this diagram with "belongs-to" relationships.

I do not think it makes sense to create the two layers because:

We still have very few classes.
Our domain classes are coupled to the persistence layer. Some commands return the Job class and other commands return CommitInfo which contains persistence details. I suppose we consider git commits part of our domain, it's not only storage for queue jobs. In fact, the commit is more important than the job state. We do not even store the job state in the Job class.

On the other hand, in the version 2.0 we might not use event sourcing to store job state.
@yeraydavidrodriguez @da2ce7 what do you think? Maybe before implementing this change we should review the queue API and decide if we want to decouple the persistence.
Maybe we could return a new object containing the Job and the CommitInfo although I would do it after refactoring the Queue. I think the code would be simpler if we introduce an array of Job in memory with the current state of the jobs, instead of dealing with messages. The array of messages would be only a way to store jobs.

You are right that creating the two layers is not as easy as moving files to folders, and probably is not possible in the current version without a big refactor that may not be worth, as the new version is going to be developed soon.
However, it looks somehow weird to me considering git commits part of the domain. It's true that "it's not only storage for queue jobs" and "the commit is more important than the job state", but maybe that's is a symptom of some design flaw.
I do not think that this implementation should be refactored, but I think we should answer now those questions for the queue 2.0:

It's clear that we want to store domain information on the actual GIT commits, but, do we want to keep this information on the classes that represent those commit, or shall we use those classes as a converter tool to a higher-level representation?

Do we want to couple the representation classes to GIT? Although GIT-based storage is part of the core concept, maybe it's not actually needed to actually coupling it.


Risk Recon importer does not include Unique Finding ID from tool

@cody-m-tibco
Hi Cody,
Could you add The Unique Finding ID from tool to the Finding object while doing Risk Recon import? I am trying to close the Finding on the Risk Recon side using automation, but I can't correlate the DD finding with the RR finding.
If you don't have time I can take a stab at adding it.

@37b @cody-m-tibco  hello Chris and cody , if you don't mind, I can take this one.

pushed a pull request to cover this one https://github.com/DefectDojo/django-DefectDojo/pull/4444

Closing it as it was merged long time ago.


Fix: Memoize user profile for performance improvement

Fixes Issue
Closes #5003
Changes proposed

Navigating to different tabs ("My Links", "Milestones", .... ) in user profile. Top hero section of user  flickers.
Cause: As navigating to different tabs cause re-rendering of userProfile component.
Solution: Memoize userProfile component, as user data doesn't change on a simple tab change. So no need to re-render component on every change.

Check List (Check all the applicable boxes)

[ ] My code follows the code style of this project.
[ ] My change requires changes to the documentation.
[ ] I have updated the documentation accordingly.
[ ] All new and existing tests passed.
[X] This PR does not contain plagiarized content.
[X] The title of my pull request is a short description of the requested changes.

Screenshots
https://www.loom.com/share/c0b4d8c001734d86931668b43d53e51f
Note to reviewers

Hi @psavan1655
One edge case got missed. When clicking on the sort icon in the My Links tab in the profile page, the flickering still happens.

Hi @FrozenHearth, Thanks for pointing out, WIll surely take a look into it.
@eddiejaoude Should i work on it? I have reproduced the issue and verified it.

Sure, but please also raise an issue (bug)

#5535 Created this issue. You can assign me there.


refactor(headers): export all headers and utils directly under header

Currently headers are exported at many places. For example you can access
Transfer-Encoding header at header, header::common and
header::common::transfer_encoding. Per discussion on IRC with
@seanmonstar and @reem, all contents of headers will be exposed at header
directly. Parsing utilities will be exposed at header::parsing. Header
macros can now be used from other crates.
This breaks much code using headers. It should use everything it needs
directly from header::, encodings are exposed at header::Encoding::,
connection options are exposed at header::ConnectionOption.

Can you please merge it?

@pyfisch Thanks for pushing this though, it's a very worthwhile change.

@pyfisch and @reem, I think the Basic scheme for Authorization headers is no longer publicly available after this change, unless I'm missing something?

It looks like we accidentally dropped a few things from public exports - @pyfisch think you could do a pass to make sure we get everything and PR the fixes?

I will look if there are things I have forgotten.


Add Avalia Systems to ADOPTERS list

Signed-off-by: Olivier Liechti<EMAIL_ADDRESS>Hey, I just made a Pull Request!
Hi there. Just added Avalia Systems to the list of ADOPTERS. Great to be part of the community!
:heavy_check_mark: Checklist

[ ] A changeset describing the change and affected packages. (more info)
[ ] Added or updated documentation
[ ] Tests for new functionality and regression tests for bug fixes
[ ] Screenshots attached (for UI changes)
[X] All your commits have a Signed-off-by line in the message. (more info)

Hey and welcome 👋


Update setup.py

Not sure if you take pull requests but this should close #6.

Sorry it took a bit, I don't get notifications here but this does fix that issue.


ImportError: cannot import name 'Transformer' from 'pali.model' (/home/PALI-main/pali/model.py)

我在运行“import torch
from pali import Pali
model = Pali()
img = torch.randn(1, 3, 256, 256)
prompt = torch.randint(0, 256, (1, 1024))
mask = torch.ones(1, 1024).bool()
output_text = torch.randint(0, 256, (1, 1024))
result = model.process(img, prompt, output_text, mask)
print(result)
”时出现以下报错：
Traceback (most recent call last):
File "test.py", line 2, in
from pali import Pali
File "/home/PALI-main/pali/init.py", line 1, in
from pali.model import VitModel, Transformer, Pali
ImportError: cannot import name 'Transformer' from 'pali.model' (/home/PALI-main/pali/model.py)，原因是model.py文件中没有class transformer的内容，请问具体代码有补充和修改吗？

Upvote & Fund

We're using Polar.sh so you can upvote and help fund this issue.
We receive the funding once the issue is completed & confirmed by you.
Thank you in advance for helping prioritize & fund our backlog.

@YilinGeStudy Please excuse me try again!


ISPN-6193 Deprecate the endpoint topology cache-suffix attribute

https://issues.jboss.org/browse/ISPN-6193
Please apply to master and 8.1.x

Integrated in both.


Division 1/3 = 0

Step to reproduce:

Open Calculator
Enter number 1
Press operation: /
Enter number 3

Actual result: 0
Expected result: 0.33333

Delete int (switch-case and library operations)


Implement language service

Must haves

[x] Syntax highlighting (colorizer)
[x] Tools | Options page (under Text Editors -> Docker File)
[x] Comment/uncomment support
[x] Dark theme support

Nice to haves

[x] Auto-completion of quotes and braces
[x] Validation of unknown keywords
[x] Intellisense for keywords
[x] Keyword hover tooltips
[x] Brace completion
[ ] Signature help
[x] Outlining/code folding
[ ] Code snippets

This is what it currently looks like:

Quick info tooltips added:

Outlining added:

Added dark theme support:


Investigate Windows bot reference test failures

The most recent PR had no problems at all on the Windows bot (see https://github.com/mozilla/pdf.js/pull/8003#issuecomment-275842152), but since today form text fields are no longer rendered (see https://github.com/mozilla/pdf.js/pull/8004#issuecomment-275941348). The weird thing is that nothing seems to have changed, i.e., the Firefox 53 update has not been performed on the Windows bot yet.
@Snuffleupagus Could you test this on Windows to see if the bot is just wrong or if the text form fields really do not render anymore?
@yurydelendik Do you have any idea what can cause this? Maybe we should manually update the Windows bot to Firefox 53 to see if that works out?

Closing since this is tracked for both the Windows and Linux bot in the issue above.


Add numerals to namespace and githubTeam input

Codecov Report
Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (a3e426b) 37.82% compared to head (4ea41bf) 37.82%.

Files
Patch %
Lines

pkg/environment/githubTeamNameValidator.go
0.00%
1 Missing :warning:

pkg/environment/namespaceNameValidator.go
0.00%
1 Missing :warning:

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #521   +/-   ##
=======================================
  Coverage   37.82%   37.82%
=======================================
  Files          50       50
  Lines        3191     3191
=======================================
  Hits         1207     1207
  Misses       1855     1855
  Partials      129      129

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


ipld updates

[x] ipld1.0 - PR #402
[x] ipld1.1 - PR #404
[x] ipld1.2 - PR #407
[x] ipld1.3 - PR #409
[x] ipld1.4 - PR #415
[x] ipld1.5 - PR #408
[x] ipld1.6 - PR #430

putting this on my list to review, will try and get to it asap, don't consider me a blocker since I'm a bit stretched with responsibilities, but I'd like to be able to offer an eye here (since this was originally my material!)


Implement interrupt driven GPIO on LPC families

Enable PINT device to use GPIO interrupts.
Affects LPC54xxx and LPC55xxx.

Closed via #19714, feature will be available once #18530 is merged


Uploading custom images via haproxy doesn't work

I have a three-node deployment where haproxy is configured to use a VIP.
If I point the maas client to port 80, it doesn't matter if it's the VIP or the real IP, the command to upload the image succeeds.
However, if I look at the UI, I can see that the status of the image is "Queued for download". Also, if I look at the filesystem, I can see that there's an .incomplete file for the image on two of the regions, and on the third it's completely missing.
If I instead point the client to the 5240 port, which goes directly to the region server, the image gets uploaded correctly.

The issue here is that we are hardcoding the port 5240 in the temporal workflow activity https://github.com/canonical/maas/blob/d869acf9b6e4e3ee27d80eeb2e701d3c9fa3e22b/src/maasserver/workflow/bootresource.py#L148


Wikibase: Layout and label changes to schema alignment tab

Fixes #5346

After:

To me, the labels of the buttons "Save schema edits" (now called "Save schema changes") and "Save schema" should be swapped to match their actual behavior.


Is there a way to override the "Base class" elimination but only for specific types

Event Grid system events uses the inheritance model in our TypeSpec models. typespec-go helpfully just removes those vestigial types, which is great, but sometimes you need to keep those types because they are actually models, not just composition types:

MediaJobOutputStateChangeEventData
MediaJobStateChangeEventData

This might just become a question with an easy answer (just decorate this with 'x'), but otherwise this is a bug. I have a workaround for now, where I literally just copied the old models over, but I'd love to remove those soon.

after this pr merge, you could use the new release to try with @usage.


'Error 525 SSL handshake failed' while accessing https://analytics.coronasafe.network/

Accessing https://analytics.coronasafe.network/ results in the following error..
Error 525 SSL handshake failed

Looks okay now!


Don't change input file in spike_log_to_trace_csv.py

Yesterday, I spent half an hour getting very confused about why my
Spike logs (which didn't some magic lines) were getting replaced with
the empty file when I tried to use them as inputs to this script.
This patch replaces the 'sed -i' invocations with equivalent logic in
the actual Python. It also factors out the code that parses the trace
from the code that uses it, which I think makes things a bit more
obvious.
Finally, the patch adds lots of comments, explaining the control flow:
when writing this, I really struggled to figure out what the existing
code was trying to do with things like WFI and ECALL instructions and
architectural updates. Hopefully, this is much clearer now.
Other than not rewriting input files, there are two known changes
caused by this patch. Firstly, the previous code wrote out the jr
instruction at 0x1010, but only if called with full_trace=1. I don't
believe that can have been intentional, so I've picked the behaviour
that is used when we compare traces in Ibex.
Secondly, the instruction counting has changed. I think that the
counting previously included the jump at 0x1010 (which we now don't
write out). We don't include that any more, so the "Processed
instruction count" message will decrease by 1.

@googlebot I signed it!

For any reviewer: the force push is just to fix a silly typo in the commit message.

Thanks for the refactoring. Tried it locally and it works well.


[flutter_tools] partial revert of start app change

Description
Partial revert of the change to use startApp, since the devicelab started getting flakier after those changes: https://github.com/flutter/flutter/commit/fd11d149f7281824f6a600414cbbb7fd8287d7e7#diff-506febb83ec2b9e3efc8cc4fa3a0b33b6bdcd931a285e20ac6a04d917452b5ef

Moved the uninstall to the stopApp phase


Packages: Move e2e-test-utils to new structure

Context

Summary
Move files into the new e2e-test-utils to new package structure.
Relevant Technical Choices

To-do

User-facing changes

Testing Instructions

QA

[ ] This is a non-user-facing change and requires no QA

This PR can be tested by following these steps:

UAT

[ ] UAT should use the same steps as above.

This PR can be tested by following these steps:

Reviews
Does this PR have a security-related impact?

Does this PR change what data or activity we track or use?

Does this PR have a legal-related impact?

Checklist

[x] This PR addresses an existing issue and I have linked this PR to it in ZenHub
[x] I have tested this code to the best of my abilities
[x] I have verified accessibility to the best of my abilities (docs)
[x] I have verified i18n and l10n (translation, right-to-left layout) to the best of my abilities
[x] This PR contains automated tests (unit, integration, and/or e2e) to verify the code works as intended (docs)
[x] I have added documentation where necessary
[x] I have added a matching Type: XYZ label to the PR

Fixes #6048

@swissspidy It is worth noting, that @wordpress/e2e-test-utils is still installing heavily used in our end to end tests. I can import these in this new package and export them, but I am not sure I see the point. The e2e tests are heavily linked to WordPress so will not be decoupled, I believe. Willing to do this work, if you think it makes sense..

@swissspidy It is worth noting, that @wordpress/e2e-test-utils is still installing heavily used in our end to end tests. I can import these in this new package and export them, but I am not sure I see the point. The e2e tests are heavily linked to WordPress so will not be decoupled, I believe. Willing to do this work, if you think it makes sense..

yeah no I was not planning on doing that. can keep as-is.


[bug]Cannot reconnect Metamask after disconnecting

Is there an existing issue for this?

[X] I have searched the existing issues

RainbowKit Version
2.1.2
wagmi Version
2.9.8
Current Behavior
After connecting and then disconnecting using Metamask, you are not able to reconnect with Metamask until the page is refreshed. Additionally, if you first connect using Metamask, then disconnect, then connect using another option such as Walletconnect, and then disconnect, you will be reconnected to your original Metamask wallet. The wagmi.store found in the Local Storage is also not being reset when disconnecting from Metamask.
Expected Behavior
The expected behavior is that after disconnecting from your Metamask wallet, you should be able to reconnect again to Metamask without having to reload the page. It also should not reconnect your Metamask session after disconnecting from another provider.
Steps To Reproduce

Open any of the rainbowkit examples (tested each of the CodeSandbox examples as well as running the project on my own computer)
Connect with Metamask on desktop using the browser extension
Click on your wallet profile and disconnect
Again click the Connect Wallet button and select Metamask
See how it hangs and does not open the Metamask extension to prompt you to connect
Exit the Metamask connection and connect a different wallet using WalletConnect
Disconnect from your current WalletConnect session
See how it instantly reopens your previously disconnected Metamask wallet session
Refreshing the page you will briefly see a quick flash of your previously connected wallet, only then will you be able to reconnect using Metamask

Link to Minimal Reproducible Example (CodeSandbox, StackBlitz, etc.)
https://codesandbox.io/p/sandbox/github/rainbow-me/rainbowkit/tree/main/examples/with-vite
Anything else?
Connect using Metamask

Disconnect

Trying and failing to reconnect using Metamask

Hey @magiziz thanks for checking that out. You might be able to close this as just a problem on my end. I had tried on both chrome and firefox and was seeing the issue, but then a friend had no issues himself.

@theawkwardchild Mhmm this is weird. Let me know if you still get stuck on this otherwise feel free to re-open this issue 👍


Update result details in list results

Changes
Reduces information shown in result card in search result list view
Screenshots

## Checklist

~[ ] if changes filter/search functionality, adds or updates unit tests~
~[ ] if adds a new page, adds accessibility tests~
~[ ] if adds a new page or new interaction, adds e2e test~
~[ ] if adds a new page or new interaction, sends google analytics events and updates GA doc~
~[ ] if changes filter functionality, updates filters doc~

Fixes [DEV: Slim Results](https://app.asana.com/0/1202105544020589/1203746097625282/f

@alex-cds let's separate that out. I see now that adam added a comment with new icons, but that feels like a different piece of work to me! Also, I need to create SVG versions of the icons since that's how were implementing them in the site and the ones provided by adam in google drive are png. This is easy to do from figma, just takes a moment.


Reload Apache on site change

We need to reload Apache when the site template change in tasks/manage_sites.yml, not only when enabling or disabling sites.

Should be fixed


Update AboutUs

This issue has been addressed by a previously merged PR, so I will close this issue.


Default admin set, does not have an active workflow.

When I run the Actor (without having previously created the default AdminSet) i get this error:
     ActiveRecord::RecordNotFound:
       Couldn't find Sipity::Workflow with [WHERE "sipity_workflows"."active" = $1 AND "sipity_workflows"."permission_template_id" IN (SELECT "permission_templates"."id" FROM "permission_templates" WHERE "permission_templates"."admin_set_id" = 'admin_set/default')]
     # /Users/jcoyne/.rbenv/versions/2.4.0/lib/ruby/gems/2.4.0/gems/activerecord-5.0.1/lib/active_record/relation/finder_methods.rb:550:in `find_nth!'
     # /Users/jcoyne/.rbenv/versions/2.4.0/lib/ruby/gems/2.4.0/gems/activerecord-5.0.1/lib/active_record/relation/finder_methods.rb:129:in `first!'
     # /Users/jcoyne/.rbenv/versions/2.4.0/lib/ruby/gems/2.4.0/bundler/gems/hyrax-22714f043af3/app/models/sipity/workflow.rb:34:in `find_active_workflow_for'
     # /Users/jcoyne/.rbenv/versions/2.4.0/lib/ruby/gems/2.4.0/bundler/gems/hyrax-22714f043af3/app/models/concerns/hyrax/in_admin_set.rb:10:in `active_workflow'
     # /Users/jcoyne/.rbenv/versions/2.4.0/lib/ruby/gems/2.4.0/bundler/gems/hyrax-22714f043af3/app/services/hyrax/workflow/workflow_factory.rb:41:in `active_workflow'
     # /Users/jcoyne/.rbenv/versions/2.4.0/lib/ruby/gems/2.4.0/bundler/gems/hyrax-22714f043af3/app/services/hyrax/workflow/workflow_factory.rb:32:in `create'
     # /Users/jcoyne/.rbenv/versions/2.4.0/lib/ruby/gems/2.4.0/bundler/gems/hyrax-22714f043af3/app/services/hyrax/workflow/workflow_factory.rb:12:in `create'
     # /Users/jcoyne/.rbenv/versions/2.4.0/lib/ruby/gems/2.4.0/bundler/gems/hyrax-22714f043af3/app/actors/hyrax/actors/initialize_workflow_actor.rb:15:in `create_workflow'
     # /Users/jcoyne/.rbenv/versions/2.4.0/lib/ruby/gems/2.4.0/bundler/gems/hyrax-22714f043af3/app/actors/hyrax/actors/initialize_workflow_actor.rb:8:in `create'

@jeremyf should DefaultAdminSetActor create the PermissionTemplate with an active workflow? If not, we should refactor DefaultAdminSetActor to raise an error if no admin sets exist.

This is now an issue, because the WorkflowFactory used to load the workflows automatically in this commit: https://github.com/projecthydra-labs/hyrax/pull/459/files#diff-3e949475c3590985b8ae20f49560f323L48

Two paths that I see straight away:

Ensure that we have a magic default workflow that can be activated when we create the admin set
Raise an error if no admin set exists (instead of creating them outright)

However, I believe there is work being done to ensure that we have a default admin set as part of the initialization. Which means we likely need a default workflow as part of the initialization. Perhaps a configuration option?

Will https://github.com/projecthydra-labs/hyrax/pull/433 resolve this?

@jcoyne I don't think so - the workflow importer does not make a decision on activation. We could add an attribute to the workflow config saying "active"; I think the better mechanism is to have a configuration option that says "this is the default active workflow name for the admin_set".


OOB Publish

default branch name updates

Docs Build status updates of commit a06d89a:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

.openpublishing.publish.config.json
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


Remove ShipmentLocation and Location handling from SI

We no longer allow updates to ShipmentLocation via POST/PUT SI and we
no longer expose ShipmentLocation via the SI either.
Closes: #42
Signed-off-by: Niels Thykier<EMAIL_ADDRESS>

Needs https://github.com/dcsaorg/DCSA-API-Validator/pull/32


Add Brick Breaker Game

I want to add a new JS game, Brick Breaker, that uses Javascript and HTML5

Kindly open this as an issue.


std.system: adds enum OS.otherNonPosix

It is not supported something like "Non-Posix" version in the compilers so I propose this enum here.
Related:
https://github.com/denizzzka/d_c_arm_test/issues/18#issuecomment-766745608

Unknown would be a better name. It is not tying itself to another platform.

Unknown would be a better name.

unknownNonPosix ?


Added text/xml mimetype for CCCS

What are you changing?

[ ] Releasing a new version of Notify
[ ] Changing kubernetes configuration

Provide some background on the changes
Added text/xml in addition to the application/xml mimetype that was already added. Per the RFC, the text/xml mimetype is an alias to the application/xml variant. This makes things confusing because it seems that some of the XML files are identified as text/xml and others as application/xml by the python-magic library. Hence we need to cover both alias and this PR adds both to the EXTRA_MIME_TYPES environment variable for the notification-document-donwnload-api to pick up!
If you are releasing a new version of Notify, what components are you updating

[ ] API
[ ] Admin
[ ] Documentation
[ ] Document download API
[ ] Document download frontend

Checklist if releasing new version:

[ ] I made sure that the changes are as expected in Notify staging
[ ] I have checked if the docker images I am referencing exist

[ ] api lambda (requires Notification-Production / AdministratorAccess login)
[ ] api k8s
[ ] admin
[ ] documentation
[ ] document download API
[ ] document download frontend

Checklist if making changes to Kubernetes:

[ ] I know how to get kubectl credentials in case it catches on fire

After merging this PR

[ ] I have verified that the tests / deployment actions succeeded
[ ] I have verified that any affected pods were restarted successfully
[ ] I have verified that I can still log into Notify production
[ ] I have verified that the smoke tests still pass on production
[ ] I have communicated the release in the #notify Slack channel.

The make-diff staging and production returned:
the application type keys with the templates. This PR can be merged.


Rename offence to offense in documentation and specs

Since offense is used throughout the codebase instead of offence, harmonize its usage in documentation and specs.
Also renames parantheses and paranthesses to parentheses.
I did not change the CHANGELOG entries, though, I think they should keep their original spelling.

Before submitting the PR make sure the following are checked:

[x] Wrote good commit messages.
[x] Commit message starts with [Fix #issue-number] (if the related issue exists).
[x] Feature branch is up-to-date with master (if not - rebase it).
[x] Squashed related commits together.
[ ] Added tests.
[ ] Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
[x] The PR relates to only one subject with a clear title
and description in grammatically correct, complete sentences.
[x] Run rake default or rake parallel. It executes all tests and RuboCop for itself, and generates the documentation.

Probably.
Many of those are on me - I'm used to British English and I can never write anything with the US spelling unless I really think about this. :-)


Approach for circular references in prisma objects

What is the intended approach for addressing circular references for nested relations in prisma objects?
For example, suppose there is a many-to-many relationship between posts and users. The declaration of the Post prisma object and User prisma object reference each other.
export const Post = builder.prismaObject('Post', {
  fields: (t) => ({
    id: t.exposeID('id'),
    // ...

    authors: t.field({
      type: [User], // <--- problem
      select: (args, context, nestedSelection) => ({
        authors: {
          select: {
            user: nestedSelection()
          }
        }
      }),
      resolve: post => post.authors.map(({ user }) => user)
    })
  })
})

export const User = builder.prismaObject('User', {
  fields: (t) => ({
    id: t.exposeID('id'),
    // ...

    posts: t.field({
      type: [Post], // <--- problem
      select: (args, context, nestedSelection) => ({
        posts: {
          select: {
            post: nestedSelection()
          }
        }
      }),
      resolve: user => user.posts.map(({ user }) => user)
    }),
  })
})

This causes typescript to complain about circular declarations
'User' implicitly has type 'any' because it does not have a type annotation and is referenced directly or indirectly in its own initializer.

The circular references section of the guide resolves this by first declaring the object and then implementing the fields that would cause the circular reference in a call to .implement(). However, it seems that there is not an equivalent to .implement() for builder.prismaObject.
Any help or advice would be greatly appreciated :)

This is something that there isn't a good for right now.
I can think of 2 workarounds:
export const User = builder.prismaObject('User', {
  fields: (t) => ({
    id: t.exposeID('id'),
    // ...
  })
})

// Move the field out into it's own field, this isn't optimimized
builder.objectField(User, 'posts', t => t.prismaField({
    resolve: (query, user) => prisma.post.findMany({ ...query, where: { users: { userId: user.id } } })
}))

// create a manually typed ref to break the circular dependency
const PostRef: ObjectRef<Prisma.Post> = Posts as

export const User = builder.prismaObject('User', {
  fields: (t) => ({
    id: t.exposeID('id'),
    // ...
    posts: t.field({
      type: [PostRef],
      select: (args, context, nestedSelection) => ({
        posts: {
          select: {
            post: nestedSelection()
          }
        }
      }),
      resolve: user => user.posts.map(({ user }) => user)
    }),
  })
})

That works well, cheers!

There isn't a way to completely avoid this issue, but I will probably be adding a simpler workaround.
I'll have to do some investigation, but it would likely be something like adding a builder.prismaObjectField(s) helper, or or a new method on the prisma ref itself like: PrismaObjectRef.field(s)(t => ....).  The other option would be a builder.prismaObjectRef method that would let you split defining the ref and implementing it into separate steps.  This may be the easiest option.
The underlying issue of typescript reverting to any as soon as you have the circular reference is unfortunately not something that can be worked around right now, so the best option is to provide ways to define those circular references in a separate statement.

I did solve this with a complex workaround using RxJS until something simpler shows up...
Just sharing if this helps anyone :eyes:
// getProducer.ts
import { Observable, shareReplay, take } from "rxjs";

/**
 * an observable that must happen in sync, that will be shared between everyone that uses a common key.
 * once emmited, it will be shared between everyone that uses that key.
 * if didn't emit, it will wait for the same event to happen, and then share it.
 */
export const getProducer = <Fn extends (args: any) => any | Observable<any>, Args extends Parameters<Fn>[0]>(
  fn: Fn,
  getKeyFn: (args: Args) => any
) => {
  const producersMap = new Map<string, Observable<any>>();

  return (args: Args) => {
    const key = getKeyFn(args);
    const prevObservable = producersMap.get(key);
    if (prevObservable) {
      return prevObservable;
    }

    const observable = new Observable<any>((subscriber) => {
      const result = fn(args);
      if (result instanceof Observable) {
        result.subscribe(subscriber);
      } else {
        subscriber.next(result);
      }
    }).pipe(shareReplay(1), take(1));

    producersMap.set(key, observable);

    return observable;
  };
};

then everything I want to be shared by a common key (the operation name, for example), thus not provoking any circular dependency or other problem, I use this getProducer wrap on it.
for example:
import type { MainBuilder } from "../setupBuilder/getBuilder";
import { prismaWhereForObjectFromArgs } from "./whereForPrismaObject";
import { map } from "rxjs";
import {getProducer} from "../getProducer";

type BuildListRelationFilterArg = {
  builder: MainBuilder;
  modelName: string;
};

export const listRelationFilterFromArgs = getProducer(({ builder, modelName }: BuildListRelationFilterArg) => {
  const name = modelName + "ListRelationFilter";

  const where$ = prismaWhereForObjectFromArgs({
    builder: builder,
    modelName: modelName
  });
  return where$.pipe(map(WhereForObject => builder.prismaListFilter(WhereForObject, {
    ops: ["every", "some", "none"] as const,
    name: name
  })))
}, ({ modelName }) => modelName + "ListRelationFilter");

and to make this observable sync (nothing async running inside all these)
import type { Observable } from "rxjs";

/**
 * if a observable can be produced in sync mode, it will. Otherwise it will fail.
 * @param observable
 */
export const syncObservable = <T>(observable: Observable<T>): T => {
    let emitted = false;
    let value: T = undefined;
    const subscription = observable.subscribe((v) => {
        emitted = true;
        value = v;
    });
    subscription.unsubscribe();

    if (!emitted) {
        throw new Error("observable did not emit");
    }
    return value;
};

not proud of it, but it is helping me with a relatively large schema

I am working on some improvements for the prisma plugin in #671, I'll try to add a way of creating prismaRefs in that PR before it gets merged

Add builder.prismaObjectField(s) methods that can be used to definition je circular references without type issues.


Add device dump at exit on python only runs with tracy module

Similar to conftest.py  calls to device profiler dumps. We should call dump for non python calls as well.
Solutions:

Call dump in device profiler destructor
Call dump in python atexit
Call dump at the end of tracy.py ?? Is that possible?

@nsmithtt Actually Nick even the destructor api is dangerous. It get's called after python is finished with ttlib, meaning we can easily run into scenarios where device is closed and profiler destructor is trying to read profiling data.
Until we remove device close from ttnn/ttlib and fully leave it to  the C++ destructor, we can't bring profiler dumps in profiler destructor.
I am afraid python only runs should call profiler dump explicitly. Until we can have FD2.0 in and can work on https://github.com/tenstorrent-metal/tt-metal/issues/5662 to have device notify host on when to do dumps

@mo-tenstorrent, thanks for looking into this, seems like we should hold off then until FD2 is in.  It's not too big a deal to convert a python script into a pytest.

Great, will close this ticket then.


Documentation/add example anchors

the (not yet final) effects can be viewed at:  http://<IP_ADDRESS>/devel2/HTTP/UserManagement/#RestGrantDatabase_container
when hovering the documentation-div; the v^ will also un/fold the examples to be discussed whether this is what we want.

A way to show/hide the result is a good idea IMO. Currently, you can only show, but no more hide a possibly long result. Not sure how to design and style this yet.
Some random ideas:

Remove prefixes like shell> and rather indicate in what context the example is supposed to be run as caption somewhere above the example
Button to copy example to clipboard?
Use separate boxes for example code and result block, possibly with captions?
Give each example a meaningful caption to describe what it does?

@dothebart does the script check if there are collisions in IDs (duplicate anchors)? It's possible that a single page contains two headlines with the same slug (we had plenty of this before we removed the Example and Examples headlines), which may not be obvious because of DocuBlocks.

no, didn't add a check for this yet, but was already thinking about that.
In this case you will only get duplicate anchors if you have the same example used twice in a file - which means that the anchor would essentially bring you to the same content.
I think show/hide should be in one row with the chain, and maybe also hide/unhide the show/hide link so that essentially only one link is there.

I've now changed the ^V to become 'hide' similar to the show. @sleto-it have a look ;-)

To reduce confusion if one hides the result, I propose the following:
 ______________________       ______________________
|                      |     |                      |
| Example code box     | ==> | Example code box     |
|______________________|     |______________________|

[ Show result body]          [ Hide result body]
                              ______________________
                             |                      |
                             | Result box           |
                             |______________________|

The Show/Hide button can be one DOM element which changes text, but keeps its position, so that it act more like a toggle. If the user has expanded the result and scrolled to the end, there will be no button anymore which would lead to an unpleasant jump of content if used. It is sufficient to show the result box if the button is clicked (you can also click the code box currently).


Few improvements

Fellas, here are few improvements of many that could be done.

Some changes are not changes we want in this repository (such as aligning variables)

@thecodeassassin sure.

Can you update the PR with the latest change in the master branch? Then i vote to merge.

@thecodeassassin that's it.

@danibrutal vote yes to merge?

+1!


feat: billing plans

What does this PR do?
This PR is all about Billing plans.
How should this be manually tested?
Send a POST request to /api/v1/billing-plans to seed the data in the database.
Send a GET request to /api/v1/billing-plans to get all plans.
Send a GET request to /api/v1/billing-plans/:id to get a single plan.
Checklist of what you did

[x] Implemented endpoint to seed billing plans to the db.
[x] Implemented endpoint to get all billing plans.
[x] Implemented endpoint to get a single billing plan.
[x] Returned success message with the right response payload.
[x] Added unit tests for the billing plan service

Linked Issue
#456 & #457  &  #458

@Homoakin619 @TheCodeGhinux @davidolanrewaju  Please review


Update azure-waf-bypass.yaml

Hi, why did you close the PR?

My apologies, I was making some change and it got closed unintentionally.
let me reopen it.
Thanks

Could you please add public references showing that Azure WAF in particular was vulnerable to command injection bypass using globbing patterns, and that this issue was fixed on July 16th, 2021?

@korniko98
So I reported this issue last year to Azure on 24 Jun 2021, 02:50.

You can see the payload and snapshot with fix status.
I am not getting time to update the blog hence there is no reference. Let me know if this snapshot works?
Thanks

I think it's important that we link to some public url as reference, maybe you could publish a short summary of your azure portal submission on twitter / github / linkedin and add a link to the tweet? or add a short note to the blogpost? and then after the item is added to the database, if you find the time to update your blog with more information you could add that as another reference as well.

@korniko98, thanks for great suggestion.
I have published a short summary with screenshot on twitter: https://twitter.com/justm0rph3u5/status/1542943538857799680
As well as on Linkedin: https://www.linkedin.com/feed/update/urn:li:activity:6948709212621266944/
I will update the blog over the weekend.
Thanks


Handle parsing of component children with function-like syntax

The parsing logic for components in a view was missing a check for children using function-like calling.
Before this commit, the following snippet would compile:
view! { cx, Component { Child {} } }
view! { cx, Component { div {} } }

...while this would not:
view! { cx, Component { Child() } }
view! { cx, Component { div() } }

Tests are added to ensure that either way of calling a component compiles.

Looks great. Thanks!


Update checkout

References to checkout need updated. Should have the -b flag after the Checkout command.

working on this


Looking good, but maybe remove inheritance?

Hey, how are you! I am shopping for a Telegram Bot C++ library, and yours seems great. I've only looked at it for a few minutes and I see mostly what I like to see. Most importantly, only a few dependencies, and reasonable ones (cpr, nlohmann::json).
What I don't see myself doing, is inheritance... It's been a long time since I left that style of programming. I mean, with templates and/or callables, you can achieve the same with a lot more flexibility and even getting a plus of performance and general stability by not resorting to vtables.
Your valuable opinion will be appreciated.

Hi @ignacionr,
I am good thank you! how about you ?
First, thank you for your interest in this project! although its still on beta and not 100% complete, you can still make decent bots (which don't use the inline mode as its not implemented yet).
I understand your concern about the inheritance-based extensibility technique used here and actually you are right, there is no strong reason behind it except few ones of my own:

Simplicity:  My goal was to create a user-friendly experience when working with bot callbacks.
In my opinion, the inheritance-based extensibility technique provides a well-organized and easily manageable structure. I drew inspiration from the olcPixelGameEngine and found it intuitive to override callbacks and define actions when they're triggered.

Flexibility: I started the library with the idea that someone might want to run multiple bots within the same program (a requirement I encountered in a previous project). Using polymorphism simplifies managing multiple bots, which will be something like:

std::vector<Bot*> bots;
bots.push_back(new MyBot1());
bots.push_back(new MyBot2());
bots.push_back(new MyBot3());

// Run all bots simultaneously
for (Bot* bot : bots) {
  std::thread([&]{
   bot->start();
  }).detach();
}
...

Uniqueness: There are many Telegram bot C++ libraries out there such as tgbot-cpp, tgbot ... I want to give this one some sort of uniqueness on how it's used.

Regarding performance, I agree that the use of inheritance is unlikely to significantly impact clock cycles. This library listens for updates from Telegram server and as soon as there are new updates, it dispatches them to the relevant callbacks. Whether we use inheritance with overridden methods or std::function callbacks, the difference in performance is negligible.
However, I remain open to new ideas and alternative techniques. If you have any suggestions or recommendations, please don't hesitate to share them with me.
Once again, thank you for your interest, and I wish you a good rest of day!


dawsoncollege

Dawson College (in Montreal, Canada) students have emails in the form of<EMAIL_ADDRESS>

This needs to end in .txt

@astormybread Flagging as inactive.


Catalog Import Showing Wrong Entity Type

After the latest release, When I import any entity type it always says a location entity was imported. For example i will import a template type using the catalog-import plugin and i get this:

I cant find the template type, only the location when searching or going to the /create page.

@j021006 can we see the template.yaml that you're trying to register? It could be invalid.

Template file encoding was UTF-8 once changed to UTF-16 worked fine.


id-token verification using signature is not doing

Hi,
We are doing PKCE model, it is not verifying id_token by using signature .  after debugging the code we can see that control never come to _validateIdToken method in library.

I don't recall if id_token validation is being performed when using code flow, but:
https://openid.net/specs/openid-connect-core-1_0.html#IDTokenValidation
see point 6.


Fixing formatting for Dv2-series table

Missing a column causing the table to not render

@lukerogers : Thanks for your contribution! The author, @jonbeck7, has been notified to review your proposed change.

Already fixed, not needed anymore.


Continuously printing error messages when zooming to a tileset that cannot be loaded

Tested with Cesium 1.91, with the current state of main, on Google Chrome, Version 99.0.4844.82 - although the latter is likely not relevant here
The following sandcastle tries to load a tileset that does not exist, and then zoom to it:
const viewer = new Cesium.Viewer("cesiumContainer");
const tileset = viewer.scene.primitives.add(
  new Cesium.Cesium3DTileset({
    url: "http://example.com/tileset.json"
  })
);
viewer.zoomTo(tileset);

It causes the following error to be printed continuously, flooding the console:
Uncaught (in promise) RequestErrorEvent {...

This happens regardless of what caused the loading error - a malformed JSON or any other invalid element in the tileset causes the same behavior, with a different error message.

My gut feeling is that somewhere around Viewer#updateZoomTarget, there should be something like
if (target.failedToLoad()) { return nopeNotGonnaTryThatAgain(); }
else { return target.readyPromise().then(...); }

or maybe the Error that is thrown from trying to load the tileset should cause a call to cancelZoom or clearZoom or so in the chained promise that is created there, but these are just guesses until now.

Thanks @javagl, there's a few areas where we're in the process of cleaning up error handling after the transition from when.js to native promises-- https://github.com/CesiumGS/cesium/issues/10178. I believe this should be addressed as part of that effort.

This still seems to happen in 1.95 - OK to reopen this?

@javagl Sure, if you're testing from the latest main. We thought the was fixed in https://github.com/CesiumGS/cesium/pull/10523.

I might have got the release cycles wrong. It happens in 1.95, but no longer in main. Sorry for the noise.


Remove generation of deprecated non-select statements.

BUILD SUCCESSFUL in 1m 57s
175 actionable tasks: 171 executed, 4 up-to-date

@AlecStrong approved this pull request.
On Sun, Sep 10, 2017 at 12:48 PM Jared Burrows<EMAIL_ADDRESS>wrote:

@jaredsburrows approved this pull request.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/square/sqldelight/pull/658#pullrequestreview-61689164,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABmQwGLLIglXhOMPmKsbKSWEBT5FUk4iks5shBLogaJpZM4PSJ_h
.


bug-fixed: avoid dirty on blur without changes

#15 fixed

Looks like it helped to solve that awkward bug. 🙃


chore: 🤖 ignore a vulnerability for now

Codecov Report
Patch coverage has no change and project coverage change: +8.93 :tada:

Comparison is base (e8f3d1c) 90.14% compared to head (69bc8a2) 99.08%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1208      +/-   ##
==========================================
+ Coverage   90.14%   99.08%   +8.93%
==========================================
  Files         180        4     -176
  Lines        9995      109    -9886
==========================================
- Hits         9010      108    -8902
+ Misses        985        1     -984

Flag
Coverage Δ

jobs_cache_maintenance
99.08% <ø> (ø)

jobs_mongodb_migration
?

libs_libcommon
?

services_admin
?

services_api
?

services_worker
?

Flags with carried forward coverage won't be shown. Click here to find out more.
see 176 files with indirect coverage changes

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.


Template preprocessor in GDScript

There's a feature that some other new languages implemented and that proved to be very powerful, which is a template preprocessor. I mention Nim because it had some nice implementation of it. But in a nutshell it's about replacing some keywords with custom text/script during the startup time when a project is launched.
This aims for more concise, cleaner and more reusable code.

Syntax sugar + in runtime...
Instead, how about macro function returning code string which is injected to the script at compile time?

Similar to #10948. IMO this an unneeded over-complication of the language.

Are you referring to Macros then I am gonna say it out loud, don't anyone dare to mess with the dear ol' GDScript.
Macros are not good for a simple language that GDScript is. It is just over-complicated and wrongly used garbage. If you want something like this then use the Nim Bindings for Godot.
The grounds on which I hate them are,

Macros can't be debugged
Can create unwanted effects
Already have decent alternatives

@vnen , yes, it looks like a duplicate from #10948 . But it is essential that macros are located in another file and not in the script which uses it.
However I think it would allow different kind of writing, like for instance state machine configuration.
@swarnimarun , I'm aware that it makes debugging more difficult and it can introduce side effects, but what alternatives offer to write functional programming and the said state machine configuration concisely and in a human readable way?
Also, well tested macros have the advantage to not have to be debugged. If someone writes a framework based on macros and he does his job perfectly, you can use those new keywords without having to worry about them. And by extent it can help artists and real beginners to use a framework that makes most of the work for them. A bit like the visual language.

@gokudomatic I am not saying that I don't like Macros, I love them but they aren't a good fit for a simple and easy to use language, you can always create abstraction using other methods and make it human readable.
My point is simply, don't add a feature unless you absolutely need it.
This might be helpful for syntactic sugar but other than that I don't know of any specific use cases for it, in the realm that belongs to GDScript.

My point is simply, don't add a feature unless you absolutely need it.

Let other people discuss what they need or not before arrogantly deciding it for them.

@starry-abyss The thing is it's not only for one or two or for three people, it's a feature for everyone. I can say that I don't need it and ask you to think if you absolutely need it.
I would have been arrogant if I had said that it's a waste of time and put a sock and move on, close this thread. But rather I am just stating stuff in my head.
Macros have always been a debate starting topic and I don't think there is any programmer that hasn't changed his views on the matter with experience or time or advice.
Why don't you or OP try to convince me and the devs by giving some examples and code, feature proposals are made to convince the people especially in the open-source community.
I would love to have Macros but why bloat GDScript?
Why do you need them?
Is there something that languages that don't have macros just can't do that is relevant in the context of Godot and Game Development?
Overall this is a bad feature request not cause it's a bad feature but cause no one even gives a proper reason to have the above-mentioned feature. No examples with code...
And functional programming doesn't absolutely require meta-programming and Macros but it's more of a feature there to help with making the code better.
Good Macros and meta-programming systems are there to help the advanced and the beginner programmers alike but need some experience to get good at.
Overall the adding more things to GDScript will make it slower and increase the level of complexity.
And adding Macros means adding a huge feature to GDScript, it will not only be a feature but a whole new concept in itself, Meta Programming.
This means we need to think of all the reason to not do it and check them out before anyone tries to implement it.
This one talks about lots of reason for why Macros are not there in lots of modern languages, https://softwareengineering.stackexchange.com/questions/937/why-arent-macros-included-in-most-modern-programming-languages
I want one list that can counter that list or just show me(and people here) enough pros that make it worth it to have a feature like this in GDScript.
And, I hope no one finds it arrogant.

Well, @swarnimarun has an important point: no one here is saying why they need this. As stated in the FAQ, requests should come from use cases. Not only that, but the feature should be used often or be really difficult to work around, and I think a language preprocessor is neither of those.

@vnen My use case here is the configuration of a state machine.

Why don't you or OP try to convince me and the devs by giving some examples and code, feature proposals are made to convince the people especially in the open-source community.
Use case: in the project I work on (not Godot one), macros are used to get a list of all entity classes (about 300 total) to populate them in an in-game editor menu.

Convince? I don't know if I need this in GDScript (yet). Neither do I know if I don't need it.

And functional programming doesn't absolutely require meta-programming and Macros but it's more of a feature there to help with making the code better.
Programming doesn't absolutely require IDEs, profilers, code reviews, unit tests, and whatnots, they are more of a feature to help with making the code better.

And adding Macros means adding a huge feature to GDScript, it will not only be a feature but a whole new concept in itself, Meta Programming.
I worked in Haxe with AST macros - they are over-complicated, and text-based hygienic ones - they are not at all.
Sure, for them to be really useful, there are some helper concepts like class-building function. Nobody said it's a couple lines of code to add.

why Macros are not there in lots of modern languages
Time to revisit the "modern" part. D, Rust, Nim, to name a few, have some type of macros.

I want one list that can counter that list or just show me(and people here) enough pros that make it worth it to have a feature like this in GDScript.
Just wait for some months for other people to give their 2 cents (or for this feature request to be just buried and forgotten among others). What is the point of generic comments like "I don't know what it does, but I know we don't need this"?

@starry-abyss I again quote lots of modern languages. Not all or most.

Use case: in the project, I work on (not Godot one), macros are used to get a list of all entity classes (about 300 total) to populate them in an in-game editor menu.

I have used Unity for a long time, done all the things like getting the entity classes, adding them to an editor menu and lots more and C# has no Macros.

Programming doesn't absolutely require IDEs, profilers, code reviews, unit tests, and whatnots, they are more of a feature to help with making the code better.

That's the reason many people don't use IDEs. And still, make awesome things. Like my favourite programmers like Jonathan Blow and Casey use Emacs or Vim or something like that.
Even I like to use VS Code cause I am not a fan of most modern IDEs. They are bloated and slow.
While others(profiler and unit tests) you mentioned come under best practices for coding they aren't like Macros. They are more of like browsers, you can go through the web through Terminal too but you will miss a lot of things(graphics and stuff) so it's not an alternative. Just like Profilers have no alternatives.

Just wait for some months for other people to give their 2 cents (or for this feature request to be just buried and forgotten among others). What is the point of generic comments like "I don't know what it does, but I know we don't need this"?

Why aren't you someone who starts and shows me an example of something that you should be able to do in Godot but can't cause you don't have macros.
And who said I don't know why and how Macros are used, my current favourite language is Rust and I use them a ton. It's just that I don't feel a need for them in GDScript.

No one here is saying "I don't know what it does, but I know we don't need this"?
I just want to know where are you coming from saying that add this to Godot.
@gokudomatic that's a good thought but from my perspective you can also use methods to make do, please be more specific. Some code helps nothing major just a basic example.
Hope this clears things up.

my favourite programmers like Jonathan Blow

Then you should watch this talk, it's about their new programming language, which does have macros. ;)

I just want to know where are you coming from saying that add this to Godot.

I'm coming from making games in not editor-oriented engines. That's why I'm not sure if GDScript needs this feature or not. Godot does use some metaprogramming though at Scons side, for the lack of modern macros in C++.

@starry-abyss Ok now I get your point.
I have watched that talk already, twice actually was hard to wrap around my head in just a single run.
And as I said I love Macros they are super helpful when needed but GDScript needing them is a different issue.
And just as you said I am also looking forward to seeing how some more experienced guys than me react to this proposal.
Do they think that GDScript needs Macros, personally I don't. But I am an open-minded person.
And so I did love to see some examples of code that proves that Macros will be a essential part of GDScript.
And yes I know that Godot uses them at the scons side not very knowledgeable with scons build system though.

for the lack of modern macros in C++.

Another reason I like Rust.

Feature and improvement proposals for the Godot Engine are now being discussed and reviewed in a dedicated Godot Improvement Proposals (GIP) (godotengine/godot-proposals) issue tracker. The GIP tracker has a detailed issue template designed so that proposals include all the relevant information to start a productive discussion and help the community assess the validity of the proposal for the engine.
The main (godotengine/godot) tracker is now solely dedicated to bug reports and Pull Requests, enabling contributors to have a better focus on bug fixing work. Therefore, we are now closing all older feature proposals on the main issue tracker.
If you are interested in this feature proposal, please open a new proposal on the GIP tracker following the given issue template (after checking that it doesn't exist already). Be sure to reference this closed issue if it includes any relevant discussion (which you are also encouraged to summarize in the new proposal). Thanks in advance!


perf: address django admin timeout issue

User Status Django Admin is too slow to respond for Modal View
TNL-8371

BUMP the version and add the change-log.

@awais786 Versions bumped and updated the changelog. Can you please review it now?
thanks.


Avoid empty author and email

User may not also have user.email and user.name configured, so fetch_email and fetch_author will return an empty string (instead of "[your-email-here]" or "[your-name-here]").
Suggested on https://github.com/amberframework/amber/pull/434#discussion_r154794069

@RX14 Can this PR get merged before v0.24.1?

@faustinoaq no because 0.24.1 has already been tagged.


Adding scripts and updating README.

Updated the deployment scripts to point to the correct config file and correct image.
Added the heapster deployment yaml.
These are standalone script only changes.

@ICGog @dhilipkumars

/lgtm

/lgtm cancel

@shivramsrivastava this is still [WIP] are you planning to do more work in this?

@dhilipkumars I have removed the WIP flag.
/assign @dhilipkumars

/lgtm

/approve


Update DI docs

Use context instead of providers/containers

This is for every container now right? Which means that every sample in the documentation will need to be updated...

it is not the big change, almost all containers is using word "context", the idea - just omit confusing :)


Mitra/ Move total assets and regulation switcher component

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

29 of 71 (40.85%)  changed or added relevant lines in 8 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.5%) to 39.068%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/components/TotalAssets/TotalAssets.tsx
5
7
71.43%

src/components/RegulationSwitcher/RegulationSwitcherDesktop.tsx
6
14
42.86%

src/components/RegulationSwitcher/RegulationSwitcherMobile.tsx
6
14
42.86%

src/hooks/useRegulationSwitcher.ts
6
30
20.0%

Totals

Change from base Build<PHONE_NUMBER>:
-0.5%

Covered Lines:
666

Relevant Lines:
1292

💛  - Coveralls


Dockerize

please review in your free time..
Description
Setting up a simple Rails development environment with Docker
fixes https://github.com/proiectus/yet-another-personal-diary/issues/10
Type of change

[x] New feature (non-breaking change which adds functionality)

How Has This Been Tested?
I wrote workflow to README

@tjnet, thanks for your contribution 💐


ontology unit tests

@memartone and @koweilin can I get a list of your demo terms so that I can run them against scigraph and our various services? This will be helpful as I start making changes for dknet.

Warn on mismatch after ttlcmp (need for single files too) suggesting that there might be a misspelling.
Empty prefix usage grep -r "^:" should return nothing.
Reasoning unsatisfiable.
Known namespace start that doesn't shorten (suggesting a fake fragment prefix).
Warn on owl:imports does not match the ontology iri (and submit a protege bug).

Do you intent to implement these via travis? I'm always curious about different groups approach to ontology unit tests.
We're moving towards extensive use of sparql (robot verify) for validation. But some of your checks might be difficult to do this way requiring some kind of programmatic checking.

I will implement some of the basic sanity checks as python or shell scripts first, and then in all likelihood will use travis so we can run the script whenever there is a pull request (or something similar). My own workflow means that I like to be able to run the tests whenever I need them, so that usually comes first, but also means that they are often not efficient enough to run all the time unless it is on a workstation.
I would also like to use robot for checks as well if I can get it up and running. However, due to the fact that we keep the raw ontology in git instead of generating it I also need to run sanity checks on the serialized output to prevent people (me) from making copy/paste errors (which turn out to have been extremely common over the history of nifstd). So enforcing certain norms on the serialized format to prevent certain classes of errors is also needed.

If it helps, there is a template repo here, including download of robot (we may switch to docker later) as well as template Makefile https://github.com/INCATools/ontology-starter-kit/tree/master/template


make_new_lints adds lints in sorted order

Resolves #730
Script now imposes some additional requirements on query.rs which are all documented in the comments.
Note: "" var is an awk idiom that concatenates with empty string to force a variable to be string typed and not numeric. Not that I expect any lint names to start with a number but done out of caution anyways.

Thanks for your kind words. Working on this project has been a very pleasant experience and a lot of that has to do with your efforts as a maintainer providing prompt feedback on PR's and writing clear and detailed issues and docs.

Sure, let me know what you had in mind and I'd be happy to help out where I can.

Do you have a preference toward a particular facet of the code?
Broadly speaking, there are four major facets in cargo-semver-checks in use today:

the user-facing CLI and surrounding code
cargo-semver-checks as a library
lints and the diagnostics they output
test infrastructure and associated tooling

One possible way to give you more leverage and autonomy is to have you work toward owning one of these areas. So instead of me opening issues and you implementing solutions, you could independently get a sense for what's needed and work toward building it or helping others build it.
There are other ways to do this as well, of course. Another example is to delegate a broad, cross-cutting area for improvement, like "help cargo-semver-checks be better in GitHub Actions" or "help cargo-semver-checks be better when used in a workspace with many crates" and then have you work across all the functional facets to improve the experience there.
Does either of these approaches strike you as appealing?
I'm not set on a particular way of doing things, and I'm happy to experiment until we find something that feels right.

Based on the issues I've worked on so far I have some familiarity with the CLI and lints but very little with the other two (the library aspect or testing), so can't say I have a strong preference yet. I've mostly been picking issues to work on by estimated size (anything that fits into a few hours on a weekend works well for me) and also the issues are a good way to learn by doing so I try to throw in some variety every once in a while too. I can keep doing that or I'd also be happy to work on whatever areas are higher priority, and of course you would have a better idea of what those are.

Sounds good. I can keep an eye out for issues that match those parameters (fit into a few hours + some variety across the tool) and we can go from there.
Thanks again, and know that I really appreciate everything you do!


Cluster Autoscaler: Does not set node to unschedulable when trying to scale down

Version: CA 0.5.0
Still digging through the code, but here's what I'm seeing in the logs.
I0323 14:13:03.952083       1 scale_down.go:292] Scale-down: removing node ip-172-31-45-132.us-west-2.compute.internal, utilization: 0.1, pods to reschedule: default/prometheus-operator-188658439-l50sl,default/parametric-aggregator-2173763796-zggm3,default/part-processor-2731341995-b6qp4
I0323 14:13:03.952628       1 event.go:217] Event(v1.ObjectReference{Kind:"ConfigMap", Namespace:"kube-system", Name:"cluster-autoscaler-status", UID:"81f28c35-0fc1-11e7-a76e-02fda4b511cb", APIVersion:"v1", ResourceVersion:"2556450", FieldPath:""}): type: 'Normal' reason: 'ScaleDown' Scale-down: removing node ip-172-31-45-132.us-west-2.compute.internal, utilization: 0.1, pods to reschedule: default/prometheus-operator-188658439-l50sl,default/parametric-aggregator-2173763796-zggm3,default/part-processor-2731341995-b6qp4
I0323 14:13:04.110792       1 delete.go:53] Successfully added toBeDeletedTaint on node ip-172-31-45-132.us-west-2.compute.internal
I0323 14:13:04.110997       1 event.go:217] Event(v1.ObjectReference{Kind:"Pod", Namespace:"default", Name:"prometheus-operator-188658439-l50sl", UID:"affad382-0fcf-11e7-a76e-02fda4b511cb", APIVersion:"v1", ResourceVersion:"2553091", FieldPath:""}): type: 'Normal' reason: 'ScaleDown' deleting pod for node scale down
I0323 14:13:04.111046       1 event.go:217] Event(v1.ObjectReference{Kind:"Pod", Namespace:"default", Name:"parametric-aggregator-2173763796-zggm3", UID:"185ab916-0fd1-11e7-a76e-02fda4b511cb", APIVersion:"v1", ResourceVersion:"2554692", FieldPath:""}): type: 'Normal' reason: 'ScaleDown' deleting pod for node scale down
I0323 14:13:04.111075       1 event.go:217] Event(v1.ObjectReference{Kind:"Pod", Namespace:"default", Name:"part-processor-2731341995-b6qp4", UID:"185b2c33-0fd1-11e7-a76e-02fda4b511cb", APIVersion:"v1", ResourceVersion:"2554683", FieldPath:""}): type: 'Normal' reason: 'ScaleDown' deleting pod for node scale down
I0323 14:13:04.111414       1 event.go:217] Event(v1.ObjectReference{Kind:"Node", Namespace:"", Name:"ip-172-31-45-132.us-west-2.compute.internal", UID:"5769d390-0f4f-11e7-a5d1-02fda4ca2c4b", APIVersion:"v1", ResourceVersion:"2556463", FieldPath:""}): type: 'Normal' reason: 'ScaleDown' marked the node as toBeDeleted/unschedulable
E0323 14:13:04.361220       1 scale_down.go:435] Not deleted yet &Pod{ObjectMeta:k8s_io_apimachinery_pkg_apis_meta_v1.ObjectMeta{Name:prometheus-operator-188658439-l50sl,GenerateName:prometheus-operator-188658439-,Namespace:default,SelfLink:/api/v1/namespaces/default/pods/prometheus-operator-188658439-l50sl,UID:affad382-0fcf-11e7-a76e-02fda4b511cb,ResourceVersion:2556482,Generation:0,CreationTimestamp:2017-03-23 13:50:34 +0000 UTC,DeletionTimestamp:2017-03-23 14:15:03 +0000 UTC,DeletionGracePeriodSeconds:*120,Labels:map[string]string{operator: prometheus,pod-template-hash: 188658439,},Annotations:map[string]string{kubernetes.io/created-by: {"kind":"SerializedReference","apiVersion":"v1","reference":{"kind":"ReplicaSet","namespace":"default","name":"prometheus-operator-188658439","uid":"6bae9c80-0f70-11e7-8473-02fda4cfdadf","apiVersion":"extensions","resourceVersion":"2550663"}}

Basically... what I'm seeing is that CA identifies the node is eligible for scale down.  It tries to mark the node as unschedulable.  It deletes the pods.  Then it checks if the pods are deleted.
What is happening is the pods are being rescheduled immediately on the same node.  And if I look in my k8s dashboard, it shows unschedulable = false on the node details while CA is waiting for the pods to be deleted in its 5s loop.

So for some reason, CA is not successfully setting unschedulable to true.

cc @mwielgus @davidopp @fgrzadkowski

I'm seeing a similar issue, which leads to deleted pods on that node being rescheduled on the same node, which leads to timeouts on the drain loop.

Maybe I just need to set maxPodEvictionTime I'll do some debugging and post updates here

What version of Kubernetes are you on?

We are using taints for marking the node unschedulable. Taints changed in 1.6 - moved from alpha annotations to beta field in node. If you are running 0.5.0 CA on K8S 1.5.X then there might be some problems.

Nodes aren't considered "unscheduable"  if you use taints so this issue can probably be closed. I opened another issue re: compatibility with 1.4. Works fine for me with 1.5 after I applied this fix https://github.com/kubernetes/contrib/pull/2494

@andrewsykim  CA 0.5.0 is not compatible with 1.4 in two places:

it uses taint structs which were not present in 1.4
it uses eviction requests for evicting pods under pod disruption budget

I guess it also fails on 1.5 due to lack of taint structs in the api. Using short graceful terminations may hide this issue a bit.

@mwielgus I'm on k8s 1.5.x.

@mwielgus is there any reason why we can't add both the taint and the annotation for the time being?

I guess we could do it. Some utility code for handling taints was removed on the way of graduating them from alpha to v1 but we could probably hack it around in 0.5.1

@mwielgus Can you remind me why we thought this wouldn't be a problem for people upgrading from 1.5 to 1.6? Is it that we thought they would upgrade scheduler and CA approximately atomically so this problem, while it would happen, would only be for the short duration while they were out of sync? We should definitely add something to the release notes about this. (Likewise for rescheduler but I think @piosz already said he was going to write a release note for that.)

I don't recall the discussion fully however it was more like this:

CA is not a critical component of the system can be turned off for 10 min without much problems. Some new pods may potentially not get a new node but as the administrator is quite close he can probably react quite fast.

CA, contrary to rescheduler, won't get to infinite loop here. The worst thing that can happen here is that that some pods (backed by RS,D,Job, etc) may be killed twice. First by CA and then couple seconds later, if it is rescheduled to the same machine, by node deletion. Rescheduler, with broken taints, can go crazy and cause mess in the whole cluster running from node to node and deleting stuff while trying to schedule a critical pod.

I will add release notes to this.


Update README.md with Composer example

Update README.md to include a fully working example using Composer

Really enjoy using this library, a lot cleaner to integrate compared to using SimpleSAMLphp. Wanted to share a sample setup with Composer, hope you find this useful.


[WIP] feature: nix ast to python

Working on adding python representation of AST. Obviously a work in progress. Still thinking about the representation in python for the AST.

As of now the issue I see is that I have to use typeof to determine the type of the expression.

Not sure if this applies here, but this is how libclang exposes the AST https://github.com/llvm-mirror/clang/blob/master/bindings/python/clang/cindex.py

But it seems like the same object graph that nix uses internally can be represented in python as well.

I am going to close this PR as I have not had enough time for it. The main issue is that I did not initially understand that parsing AST for evaluation is different from parsing for linting and code formatting. The current lex/bison code in nix does not keep track of comment locations which is an issue for code formatting.

@costrouc rnix might have been a better choice in this case.

That looks like a great approach thanks for sharing. Wish I had more knowledge of rust.


Build fails

Your Environment

Plugin version: 2.3.3+
Platform: iOS or Android Android
OS version:
Device manufacturer and model:
Cordova version (cordova -v): 8.0.0
Cordova platform version (cordova platform ls):
Plugin configuration options:
Link to your project:

Context

Ionic config is:
ionic info
cli packages: (C:\Users\shatf\AppData\Roaming\npm\node_modules)
@ionic/cli-utils  : 1.19.1
ionic (Ionic CLI) : 3.19.1

global packages:
cordova (Cordova CLI) : 8.0.0

local packages:
@ionic/app-scripts : 3.1.8
Cordova Platforms  : android 6.4.0
Ionic Framework    : ionic-angular 3.9.2

System:
Android SDK Tools : 26.1.1
Node              : v8.9.4
npm               : 5.6.0
OS                : Windows 10

Plugin list is:

cordova plugin ls
cordova-plugin-advanced-http 1.11.0 "Advanced HTTP plugin"
cordova-plugin-device 2.0.1 "Device"
cordova-plugin-device-orientation 1.0.7 "Device Orientation"
cordova-plugin-file 6.0.1 "File"
cordova-plugin-geolocation 4.0.1 "Geolocation"
cordova-plugin-ionic-keyboard 2.0.5 "cordova-plugin-ionic-keyboard"
cordova-plugin-ionic-webview 1.1.16 "cordova-plugin-ionic-webview"
cordova-plugin-mauron85-background-geolocation 2.3.3 "CDVBackgroundGeolocation"
cordova-plugin-splashscreen 5.0.2 "Splashscreen"
cordova-plugin-whitelist 1.3.3 "Whitelist"
cordova-sqlite-ext 2.1.1 "Cordova sqlite storage plugin with extra features"
uk.co.workingedge.cordova.plugin.sqliteporter 1.0.2 "sqlite porter"

Expected Behavior

Actual Behavior

Build always fails (aapt).  Seems like a couple of Android resources are now missing:, esp:
C:\Users\shatf.gradle\caches\transforms-1\files-1.1\support-compat-28.0.0-alpha1.aar\8fd2e5c5360dfd02afef69d7a5d3d7ce\res\values\values.xml:20:5-70: AAPT: error: resource android:attr/fontVariationSettings not found.
C:\Users\shatf.gradle\caches\transforms-1\files-1.1\support-compat-28.0.0-alpha1.aar\8fd2e5c5360dfd02afef69d7a5d3d7ce\res\values\values.xml:20:5-70: AAPT: error: resource android:attr/ttcIndex not found.
C:\Users\shatf\Projects\t2\platforms\android\build\intermediates\incremental\mergeDebugResources\merged.dir\values\values.xml:94: error: resource android:attr/fontVariationSettings not found.
C:\Users\shatf\Projects\t2\platforms\android\build\intermediates\incremental\mergeDebugResources\merged.dir\values\values.xml:94: error: resource android:attr/ttcIndex not found.
error: failed linking references.
Possible Fix

Steps to Reproduce

Context

Debug logs

using one of the suggestions in that thread i got it working. in the plugin.xml change framework src="com.android.support:support-v4:+" to framework src="com.android.support:support-v4:23+". builds successfully now.

Yes it's seems latest android support libraries are not compatible. #381 need to be merged.

Just ran into the same issue @SpencerHehl your solution did not work for me. Might it be because i run cordova-android 7.0.0?
cli packages: (C:\Users\Metadeath\AppData\Roaming\npm\node_modules)
@ionic/cli-utils  : 1.19.1
ionic (Ionic CLI) : 3.19.1

global packages:
cordova (Cordova CLI) : not installed

local packages:
@ionic/app-scripts : 3.1.8
Cordova Platforms  : android 7.0.0
Ionic Framework    : ionic-angular 3.9.2

System:
Android SDK Tools : 26.1.1
Node              : v6.10.1
npm               : 3.10.10
OS                : Windows 10

Plugins:
cordova-plugin-device 2.0.1 "Device"
cordova-plugin-firebase 0.1.25 "Google Firebase Plugin"
cordova-plugin-ionic-keyboard 2.0.5 "cordova-plugin-ionic-keyboard"
cordova-plugin-ionic-webview 1.1.16 "cordova-plugin-ionic-webview"
cordova-plugin-mauron85-background-geolocation 2.3.3 "CDVBackgroundGeolocation"
cordova-plugin-splashscreen 5.0.2 "Splashscreen"
cordova-plugin-whitelist 1.3.3 "Whitelist"
cordova-sqlite-storage 2.2.1 "Cordova sqlite storage plugin"

The solution isn't working for me unfortunately. When I change to the fixed android support version, I start receiving a lot of "Cannot find symbol" errors.
\platforms\android\app\src\main\java\com\tenforwardconsulting\cordova\BackgroundGeolocationPlugin.java:563: error: cannot find symbol     @TargetApi(Build.VERSION_CODES.KITKAT)                                   ^   symbol:   variable KITKAT   location: class VERSION_CODES

The proposed fix, changing the framework version to 23+, doesn't appear to
work.
A fresh project, at latest revisions, does not build.
Steps to reproduce:
Start a new Ionic project: ionic start projectname blank
Change to directory: cd projectname
Add Android platform: ionic cordova platform add android
Add this one plugin: ionic cordova plugin add
cordova-plugin-mauron85-background-geolocation
Then change the framework settings or not - errors change but neither builds
Attempt build: ionic build android
Build fails.
On Fri, Mar 9, 2018 at 6:08 AM, osietrz<EMAIL_ADDRESS>wrote:

The solution isn't working for me unfortunately. When I change to the
fixed android support version, I start receiving a lot of "Cannot find
symbol" errors.
\platforms\android\app\src\main\java\com\tenforwardconsulting\cordova
BackgroundGeolocationPlugin.java:563: error: cannot find symbol
@TargetApi(Build.VERSION_CODES.KITKAT) ^ symbol: variable KITKAT
location: class VERSION_CODES
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/mauron85/cordova-plugin-background-geolocation/issues/380#issuecomment-371783757,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AWK2nbEpYadneeDoW4Gi7_efkWle1dM9ks5tcmK7gaJpZM4ShMiI
.

@shatfield04970 can you plz provide:

Plugin version:
Platform: iOS or Android
OS version:
Device manufacturer and model:
Cordova version (cordova -v):
Cordova platform version (cordova platform ls):
Plugin configuration options:
Link to your project:

It's pretty much an "all-current" configuration...
ionic info
cli packages: (C:\Users\shatf\AppData\Roaming\npm\node_modules)
@ionic/cli-utils  : 1.19.1
ionic (Ionic CLI) : 3.19.1

global packages:
cordova (Cordova CLI) : not installed

local packages:
@ionic/app-scripts : 3.1.8
Cordova Platforms  : android 7.0.0
Ionic Framework    : ionic-angular 3.9.2

System:
Android SDK Tools : 26.1.1
Node              : v8.9.4
npm               : 5.6.0
OS                : Windows 10

Environment Variables:
ANDROID_HOME : C:\Users\shatf\AppData\Local\Android\Sdk

Misc:
backend : pro

PS C:\Users\shatf\Projects\t4> ionic cordova plugin

cordova plugin ls
cordova-plugin-device 2.0.1 "Device"
cordova-plugin-ionic-keyboard 2.0.5 "cordova-plugin-ionic-keyboard"
cordova-plugin-ionic-webview 1.1.16 "cordova-plugin-ionic-webview"
cordova-plugin-mauron85-background-geolocation 2.3.3
"CDVBackgroundGeolocation"
cordova-plugin-splashscreen 5.0.2 "Splashscreen"
cordova-plugin-whitelist 1.3.3 "Whitelist"

On Fri, Mar 9, 2018 at 2:48 PM, Marián Hello<EMAIL_ADDRESS>wrote:

FYI: If you want to "experiment" with android support library versions.
The quickest way (without reinstallation) is to edit file
platforms/android/project.properties and edit line
cordova.system.library.2=com.android.support:support-v4:+
eg.
cordova.system.library.2=com.android.support:support-v4:23+
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/mauron85/cordova-plugin-background-geolocation/issues/380#issuecomment-371926142,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AWK2nWvwqJa7hirkTgR2B91U_Yt0DmZ4ks5tctxzgaJpZM4ShMiI
.

Added option to override android library version in config.xml
<plugin name="cordova-plugin-mauron85-background-geolocation">
    <!-- may contain other variables as shown above -->
    <variable name="GOOGLE_PLAY_SERVICES_VERSION" value="11.0.1" />
    <variable name="ANDROID_SUPPORT_LIBRARY_VERSION" value="23+" />
</plugin>

This should fix this issue.

hello, i still have this issue
at first, i added this plugin
then added the option in config.xml and then
cordova platform add android
cordova build android
it still build failed
but change the project.properties file worked
option in config.xml seems doesn't work
is there anything i did wrong?

@myamolane
config.xml only works when plugin was not installed yet. if plugin was installed any changes to config.xml are ignored. You have to remove plugin and reinstall plugin to reapply changes.


[Bug] Label layout error while zoom

Version
5.4.1
Link to Minimal Reproduction
https://echarts.apache.org/examples/zh/editor.html?c=graph-label-overlap
Steps to Reproduce

set normal label position: right
set select label position: inside
select some node
zoom graph

Current Behavior
selected node's label position is right
Expected Behavior
selected node's' label  position should be inside
Environment
- OS:
- Browser:
- Framework:

Any additional comments?
No response

not-a-bug.  Zoom does not make any selection. Also not to forget to enable select with selectedMode:
        selectedMode: true,
        select: {label: { position: 'inside'}},

Then just click on any node to select it and see label inside.

不是错误。缩放不会进行任何选择。另外不要忘记使用_选定模式_启用选择：
        selectedMode: true,
        select: {label: { position: 'inside'}},

然后只需单击任何节点即可选择它并查看其中的标签。

Sorry I missed some steps, please try again after modification, you should see the problem

yes, I see it now - label of selected does not stay inside on zoom. One must hover with mouse to put label back in.
Could be considered a bug 🐛


A Circle and Two Squares

Before jumping into PR, first comment for assignment of the Problem.
All Problems are from Edabit. Link is mandatory to add
Problem statement: Imagine a circle and two squares: a smaller and a bigger one. For the smaller one, the circle is a circumcircle and for the bigger one, an incircle. Create a function, that takes an integer (radius of the circle) and returns the difference of the areas of the two squares.
Problem Link: https://edabit.com/challenge/NNhkGocuPMcryW7GP

Before submitting a PR please Check some details. Check Edabit for problem task

[ ] fileName formet should be in camelcase
example- returnTheNextNumber.py
[ ]  Add label for Problem
[ ]  In file there should be problem statement and link to problem
example -

'''
    Problem Task : This program will add two numbers
    Problem Link : https://edabit.com/challenge/SFzHtm63XT6EYNHWY
'''
*/
def main():
    return a + b

This repository is valid for HacktoberFest2020
Read before making PR - How to contribute on Github
Good Luck,

@aayushi-droid Kindly assign this issue to me, I'd love to work on it! 😄

please assign me an issue

I would like to work on this

I would like to solve this problem. Please assign it to me

Hey can I solve this problem, this would be a oneliner

Can work on this issue?

Can I work on this?

question already solved


Use mu-search for process steps

OPH-335
Corresponding PR frontend: https://github.com/lblod/frontend-openproceshuis/pull/51
For better performance, all data regarding the displaying of process steps, is indexed by mu-search.
The highlighted parts show which attributes are indexed:

@nbittich I've made sure deltas are sent to mu-search and indeed, when new process steps are inserted, the indexes are correctly updated. However, when any of these change, the indexes are not updated properly:

process title
process status (set when process is archived)
file status (set when file is archived)

I can't figure out why this is, would you have a clue?

@MartijnBogaert hard to tell by only looking at the config, seems correct. However, using nested objects can be tricky some times with elastic search, I'll try to see if I have some time to test locally this week, but if it's super urgent, you can flatten the nested objects and it should work

@nbittich would be nice if you could take a look at it, thanks! It's not super urgent, this is just a performance boost.


[1.10-rc1] issues w/ quay.io?

The following does not work in 1.10
$ docker pull quay.io/coreos/etcd
Using default tag: latest
Error response from daemon: unsupported manifest mediatype: text/html; charset=utf-8

Whats up, where do I point the finger?  quay.io or Docker 1.10

If you are reporting a new issue, make sure that we do not have any duplicates already open. You can ensure this by searching the issue list for this repository. If there is a duplicate, please close your issue and add a comment to the existing issue instead.
If you suspect your issue is a bug, please edit your issue description to include the BUG REPORT INFORMATION shown below. If you fail to provide this information within 7 days, we cannot debug your issue and will close it. We will, however, reopen it if you later provide the information.
For more information about reporting issues, see CONTRIBUTING.md.
You don't have to include this information if this is a feature request
(This is an automated, informational response)

BUG REPORT INFORMATION
Use the commands below to provide key information from your environment:
docker version:
docker info:
Provide additional environment details (AWS, VirtualBox, physical, etc.):
List the steps to reproduce the issue:
1.
2.
3.
Describe the results you received:
Describe the results you expected:
Provide additional info you think is important:
----------END REPORT ---------
#ENEEDMOREINFO

Duplicate of #19526, already fixed.