Add support for custom namespaces for commands

This PR adds the ability to register commands with other namespaces than just minecraft:.
However, minecraft: is still the default if no namespace is given.
A bit of works still needs to be done:

[x] The Kotlin DSL needs to be updated to support this feature
[x] Documentation
[x] Velocity needs to be figured out
[ ] Tests need to be figured out
[x] Global changelog entry
[ ] Maybe a bit more, depending on what else comes to my mind or something that reviews suggest
[x] Example command in CommandAPIMain.java has to be removed
[x] Test compatibility with #417

It's also easy to remove those commands from the resources dispatcher ourselves, similar to what CommandAPIBukkit#unregisterInternal does. This way we also don't need to call syncCommands again.

In fact, I did what unregisterInternal does. I double checked any mistakes I may have made. It didn't work until I called syncCommands.
Although, if there is a way to get rid of the extra call to syncCommands, I would be really happy to remove it.
As for the current structure, I think the way it is set up currently makes the most sense. At least, it makes the most sense to me. Again, happy to take suggestions if it generally improves the readability of the code and/or removes some extra stuff I am doing right now which doesn't necessarily need to be there.

In fact, I did what unregisterInternal does. It didn't work until I called syncCommands.

Ah, I think the one detail missing from setupNamespaces compared to unregisterInternal is this line of code:
https://github.com/JorelAli/CommandAPI/blob/38a1a7682633a2095366095db183850e1a9d99eb/commandapi-platforms/commandapi-bukkit/commandapi-bukkit-core/src/main/java/dev/jorel/commandapi/CommandAPIBukkit.java#L594-L598
... which uses these functions:
https://github.com/JorelAli/CommandAPI/blob/38a1a7682633a2095366095db183850e1a9d99eb/commandapi-platforms/commandapi-bukkit/commandapi-bukkit-core/src/main/java/dev/jorel/commandapi/CommandAPIBukkit.java#L611-L650
The important thing happening there is that commands are being removed from what I call the "resources dispatcher". Bukkit copies commands from the vanilla CommandDispatcher into its own CommandMap, which is accessible in the API. Notably, the CommandMap is also used for tab-completing and running console commands. However, the code that sends commands to the player and handles player tab-complete and execution is based on Brigadier. So, Bukkit copies all the commands in the CommandMap into a second CommandDispatcher, the "resources dispatcher".
The syncCommands method is the method Bukkit calls to copy commands from the CommandMap to the "resources dispatcher". If you call it again, I'm pretty sure it does properly handle rebuilding the "resources dispatcher". However, it does process all of the commands from scratch. That's probably fine here since setupNamespaces is only called once, but I wanted to avoid it in unregisterInternal since that could be called many times.
If you do want to avoid calling syncCommands, you'll just need to add and remove same commands from the "resources dispatcher" as you're already doing for the CommandMap. My suggestion makes it so you only need to remove commands from the CommandMap and "resources dispatcher", but it should work either way. My suggestion also avoids the double nested loop over all known commands for all RegisteredCommands to find matches (and searching through the alias list), which could be a lot of work. It's probably fine since setupNamespaces is only called once, but it's just something to think about in combination with how Velocity namespaces will work.

Yeah, currently, Velocity commands do not have namespaces. Since it's just a proxy, it doesn't include Minecraft server commands like Bukkit does, so I guess they didn't bother with automatically assigning minecraft or plugin namespaces. We can definitely still create namespaced versions of commands ourself if we want to (just put register namespace:command as well), and I think it is helpful in case another plugin tries to use the same command name.
Velocity plugins do have IDs (see https://docs.papermc.io/velocity/dev/api-basics#create-the-plugin-class), which would make sense as the namespace to use for a Velocity Plugin. It looks like you can get that ID given a plugin object with something like this:
CommandAPIVelocity.getConfiguration().getServer().getPluginManager().fromInstance(/* Plugin object here */).get().getDescription().getId();

So this is basically done. I need to test compatibility with #417 because when I read it I got worried it would only work with a minecraft: namespace. It's probably fine, I just want to make sure.
As for the tests, I tested this ingame extensively so with confidence I can say it works. Also, I have no idea how to test for a correct namespace registration so I'll leave this to someone who knows more :D
@willkroboth Would be great if you'd review this, after all you made this issue #367 and probably had an idea how it could work.

So, this is done. If there's nothing else, we could even say we still put this into 9.3.0.

 I am not gonna do this today though.

We should definitely add some tests before merging. All the ways of setting namespaces should work. Two commands registered with different namespaces also shouldn't conflict.
Everything should also work the same once these lines are called to simulate the server finishing enabling:
disablePaperImplementations();
assertDoesNotThrow(() -> server.getScheduler().performOneTick());

We should make sure the namespace logic that is triggered after the server is enabled works the same as before enabling. The minecraft: version of commands should also be properly removed from the CommandMap and resources dispatcher.
Those tests can probably be added to CommandRegistrationTests and OnEnableTests. I'd be happy to figure out the OnEnableTests, mostly because they're a big mess that I should probably clean up anyway.

Yeah, well, I thought about tests too. It's probably enough to simply test the registration and then whether the correct values have been removed and added by simply invoking the commands.
It should be that easy, right?

Alright. I now consider this feature finished. After multiple revisions started by @willkroboth pointing out mistakes I made, I am now confident in saying that this feature works now.
The current caveat is that some test don't succeed but manual test have confirmed that the failing automated tests actually succeed in a real Minecraft environment.
@willkroboth @JorelAli
If one of you or even both of you could do a code review, I believe this PR could be merged until Sunday or so :)


Add support for state migrations in infer

Adds support for state migrations in the infer provider. Resources opt into state migrations when they implement the infer.CustomStateMigrations[O] interface:
type CustomStateMigrations[O any] interface {
	// StateMigrations is the list of know migrations.
	//
	// Each migration should return a valid State object.
	//
	// The first migration to return a non-nil Result will be used.
	StateMigrations(ctx p.Context) []StateMigrationFunc[O]
}

StateMigrationFunc[O] are created via:
func StateMigration[Old, New any, F func(p.Context, Old) (MigrationResult[New], error)](f F) StateMigrationFunc[New]

This allows each resource to define a list of (possibly typed) migrations from old to new state. This design makes the common case of migrating from StateV1 to StateV2 fully typed, but permits an untyped to typed escape hatch.
Fixes #193

This is required for https://github.com/pulumi/pulumi-pulumiservice/issues/84, since pulumi-pulumiservice already maintains it's own state migrations.


Vendor Kubernetes v1.24.0

What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Update Kubernetes to the latest release.
Which issue(s) this PR fixes:

None
Special notes for your reviewer:
None
Does this PR introduce a user-facing change?

None

Ready for review @mrunalp @feiskyer @mikebrow PTAL


IE11 Problems with sap.ui.unified.FileUploader

Hello,
I'm running an application on the OpenUI5 ver. 1.26.7 - 1.26.9.
The FileUploader works as intended in Firefox and Chrome.
However, it is not possible to upload files in Internet Explorer 11.
There seems to be a problem with the browser switch when Xhr-requests are enabled.
This was implemented in the file "FileUploader-dbg.js" on line 819 looks like this:
if (sap.ui.Device.browser.internet_explorer) {
var sContentType = oFiles[0].type;
oXhr.xhr.setRequestHeader("Content-Type", sContentType);
oXhr.requestHeaders.push({name: "Content-Type", value: sContentType});
}
I'm pretty sure that the bug is not caused by my application since this error is also apparent on your demopage on the third Fileuploader sample: https://sapui5.hana.ondemand.com/sdk/test-resources/sap/ui/commons/demokit/FileUploader.html
Kind Regards,
Wolfram Ganz

Hi,
i created an internal ticket for this<PHONE_NUMBER>
BR,
Tobias

It was fixed in master and 1.28 but 1.26 is still missing so i keep this ticket open

The fix will be applied to SAP UI5 version 1.26.11.
Cheers
Stanley

hi Stanley,
I am facing the same problem in IE 11 so is it confirmed that FIleUploader will start working from sapui5 version 1.26.11.
thanks,
Anshul D

Yes, the issue was a side-effect from another fix and is repaired with 1.26.11.
Cheers
Stanley

thanks a lot Stanley,
can you please tell me when 1.26.11 is getting released ??

Around middle of April.

Hello, I am facing same issue, the upload cllection works fine in Chrome but in IE11 after uploading one file, it throws error 'InvalidStateError'. The version of UI5 is 1.32 . Please advise urgently  if any workaround is possible
Regards


CI: debug HPU flow

What does this PR do?
Checking why the HPU is not running
Before submitting

[x] Was this discussed/approved via a GitHub issue? (not for typos and docs)
[x] Did you read the contributor guideline, Pull Request section?
[x] Did you make sure your PR does only one thing, instead of bundling different changes together?
[ ] Did you make sure to update the documentation with your changes? (if necessary)
[ ] Did you write any new necessary tests? (not for typos and docs)
[ ] Did you verify new and existing tests pass locally with your changes?
[ ] Did you list all the breaking changes introduced by this pull request?
[ ] Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

[ ] Is this pull request ready for review? (if not, please submit in draft mode)
[ ] Check that all items from Before submitting are resolved
[ ] Make sure the title is self-explanatory and the description concisely explains the PR
[ ] Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?
Make sure you had fun coding 🙃

the problem here seems to be that we install the package, but even just after it is not found...
Installing collected packages: pytorch-lightning
  Running setup.py develop for pytorch-lightning
Successfully installed pytorch-lightning

but pip list does not list it... :confused:


metrics

Coverage remained the same at 100.0% when pulling 31980704ef831d4ff7aae66e74c938755bcdfbfa on metrics into 36d33cf3b68f48dda8f38ac6496416b04ba5621f on master.

Coverage remained the same at 100.0% when pulling 31980704ef831d4ff7aae66e74c938755bcdfbfa on metrics into 36d33cf3b68f48dda8f38ac6496416b04ba5621f on master.


Enable deployment actions in server deployments list view

Currently there's an exception when trying to run actions on server deployments list (Provider > Server > Deployments):

This fixes by passing the proper arguments to the operation call.
BZ https://bugzilla.redhat.com/show_bug.cgi?id=1404877

@miq-bot add_label providers/hawkular, ui, bug
cc @pilhuhn, @bronaghs

LGTM
@miq-bot assign @bronaghs

LGTM

@miq-bot assign @dclarizio
cc @martinpovolny @h-kataria

@ammendonca - darga? euwe?

@miq-bot add_label darga/no euwe/yes

@bronaghs @ammendonca we will need a BZ link added to the top comment to get this backported to euwe.

@ammendonca -  I do not know the BZ, can you find it and add it to the PR description?

@bronaghs, @dclarizio createad the BZ and added the link to it on the top comment.

Euwe backport details:
$ git log -1
commit 1d0f05420eab3fbae2f4e7eedd2a418011d88d93
Author: Dan Clarizio<EMAIL_ADDRESS>Date:   Tue Dec 13 15:58:54 2016 -0800

    Merge pull request #12991 from ammendonca/MIQ-MW-FIX-ACTIONS-DEPLOYMENTS-LIST

    Enable deployment actions in server deployments list view
    (cherry picked from commit 4c8f892d6b05b192beca9c4d61ce0b4f2e29eccf)

    https://bugzilla.redhat.com/show_bug.cgi?id=1411983


DATA NOT FETCHING from MONGODB ATLAS Database to Mobile app.

I already disalbed Public network to my firewall. Already set up my .env file on my moblie/.env but when I try to search for properties and also if I try to log in I got error everytime.
Perhaps do I need to deploy my database on docker? I preferably want not to deploy it on docker and since I am using MONGO DB Atlas I am expecting that my mobile app can fetch the data at ease, but its not. I think I just did something wrong with the localhost/<IP_ADDRESS>:4004 cause I think this is a double hostname or IP. I'm not sure though.

In ./mobile/.env replace localhost by your local IP address:

Open powershell
Run ipconfig

Your local IP should be something like <IP_ADDRESS>.

I did your suggestion sir sadly ites still the same, it doesnt fetch and sends the same errors. @aelassas

It still tries to connect to localhost. The mobile app should point to a local IP not localhost and not <IP_ADDRESS>. Replace all localhost occurences in mobile/.env by your local IP and run a clean start of the mobile app with npm run start:clean. You can get the local ip with ipconfig command.

still not working sir, perhaps do we need to be connected the both devices in a SAME WIFI network? or is it good even though we are not, the screenshot below is the IP config: @aelassas

It's fine now sir :) thank you so much. I just need to apply the port <IP_ADDRESS> cause its the same network that we are connected with the mobile device. Thanks :) I already did this multiple times earlier, but my mistake is I didnt start clean with npm run start:clean

The author and owner of this repo is the best, so accomodating and fast to response :) Godbless people like him


Two album and book art styles may be broken

Example images here: https://github.com/amiantos/AI-Horde-Styles-Previews/blob/main/categories/album_and_book_art.md
I don't think "children's book illustration" and "mastodon album cover" are working properly. I did not look into the issue myself so I can't suggest what it may be, but I assume the Loras aren't working. I tried regenerating the image multiple times to control for worker variance and they came out the same.

"children's book illustration" lora (https://civitai.com/models/670727?modelVersionId=755617) should work fine, it's small enough and not login-gated
"mastodon album cover" lora (https://civitai.com/models/685221/mastodon-album-cover?modelVersionId=766910) is also small enough but that one is login-gated

Did a quick test with fixed seed 1, prompt "tree", results were all basically the same image with only minor differences, so the loras are not being applied correctly. I see they are both for Flux Dev (I don't know if there are any loras for Schnell? haven't checked) but I have used some other Flux Dev loras before and they do work with our version of Schnell

It's possible that it's a worker issue. You can see the styles working as intended in the party:
Mastodon Album Cover
children's book illustration
If you search discord for the style names, you'll likely find a free attempts at both styles that didn't work, so I'm guessing there's at least one worker that isn't downloading loras properly, or it could also be issues on Civitai's side.

There was no report of failed downloads on the API response, and like I said, all three images (with fixed seed) were slightly different from each other, but nothing that would indicate that it was the effect of a lora

Okey, I'll update my script and try to get successful previews to generate. I'll come back and close this issue then.

Children's illustration should be fixed with 678f3ecd8db5dde3bf0ccb70fb04c307031520e2


Update Build instructions for Docker 19.03

Description of issue (what needs changing):
Docker Build from Source documentation seems to be out of date for docker 19.03.
For example there is no --runtime=nvidia flag available any more.

yes. as stated here the command needs to be changed.
docker < 19.03:
docker run --runtime=nvidia -it -w /tensorflow -v $PWD:/mnt -e HOST_PERMS="$(id -u):$(id -g)"
tensorflow/tensorflow:devel-gpu-py3 bash
docker >= 19.03:
docker run --gpus all -it -w /tensorflow -v $PWD:/mnt -e HOST_PERMS="$(id -u):$(id -g)"
tensorflow/tensorflow:devel-gpu-py3 bash

Added PR #33367 with docs updated.


Fix status_request and SCT extensions

They are valid for use in a CertificateRequest message, but we did not
allow it. If a server sent such a message using either of those two
extensions then the handshake would abort.
This corrects that error, but does not add support for actually processing
the extensions. They are simply ignored, and a TODO is inserted to add
support at a later time.
This was found during interoperability testing with btls:
https://gitlab.com/ilari_l/btls
Prompted by these errors I reviewed the complete list of extensions and
compared them with the latest table in draft-24 to confirm there were no
other errors of a similar type. I did not find any.

Checklist

[ ] documentation is added or updated
[ ] tests are added or updated

ready for merge ?

Pushed. Thanks.


how can i remove an existing xxx.framework(not imported from apple's libraries) from my project

my project AAA.xcodeproj contains bbb.framework which is added to ccc.target.
and i want to remove bbb.framework
how can i make it

i tried this:
XCProject *asProject = [[XCProject alloc]<EMAIL_ADDRESS>        XCTarget *aTarget = [asProject targetWithName:@"ccc"];
        XCSourceFile *file = [asProject<EMAIL_ADDRESS>        NSLog(@"%d",originTarget.members.count);
        [aTarget removeMemberWithKey:file.key];
        NSLog(@"%d",aTarget.members.count);
        [asProject save];

but it didnt work.

1.Find your framework group
2.Use XCGroup memberWithDisplayName function
3.target removeMemberWithKey:file.key

Actually, i made it a couple days after i post this issue.
But i got this issue on the very condition that i duplicate my target.
So this is still a bug, when i duplicate a target and i will fail to remove a source file  on the original target.

Yes, duplicate a target have some bug,So i remove file first, and then duplicate target.......


US25: The invited friend can either accept or decline the lobby invitation.

See user story for explanation.


SurveillanceStation/sendMethod

I try to enable camera , but it doesnt work
i put the following to the sendMethod object:
{"method":"Enable","params":{"cameraIds":"1"}}
i also tried:
{"method":"Enable","params":{"cameraIds":1}}
In both cases the iobroker log says:
Error JSON parse command {}

fixed


Ability to delete properties completely

Currently the only way to delete a property completely is to use the JSON editor.
It would be usefull to be able to do it also in the UI somewhere near the input fields.
Example use cases:

https://github.com/maputnik/editor/issues/129, https://github.com/maputnik/editor/issues/422 (text-font)
https://github.com/maputnik/editor/issues/507 (fill-pattern)

Fixed in #531


bug: fix ci after #5396

#5396 was a little too simplistic and caused ci not to fail if make build failed, fortunately this was always caught at the next step (build library search cache) anyway but we should restore the correct behaviour

bors merge


[tests] Include 'long_test' in 'check-swift-all-*' test targets

What's in this pull request?
build-script -T --long-test
check-swift-all should include long_test test cases.

Before merging this pull request to apple/swift repository:

[ ] Test pull request on Swift continuous integration.

@rintaro Thank you!

@swift-ci Please smoke test OS X platform

@swift-ci Please smoke test Linux platform


DTS:X is not detected in lossy streams like DTS-HD HRA

Hello.
While mediainfo 23.03 fixed detection of some DTS:X streams in DTS HD-MA (#422), it still fails to detect DTS:X in lossy streams. Some 4K UHD disks (e.g. Furions 6 and Furious 7 by Universal) use DTS:X with DTS-HD HRA codec instead of lossless DTS-HD MA. Mediainfo doesn't show DTS:X, while actual AVR does recognize and render audio through height speakers (in detailed audio info it will show DTS:X instead of DTS:X MA).
Example here with Furious 6 (theatrical, remuxed to mkv container. Original disk uses rather complicated system with different audio codecs for different cuts):
{
"creatingLibrary": {
"name": "MediaInfoLib",
"version": "23.03",
"url": "https://mediaarea.net/MediaInfo"
},

...

{
"@type": "Audio",
"StreamOrder": "1",
"ID": "2",
"OriginalSourceMedium_ID": "4352",
"UniqueID": "3",
"Format": "DTS",
"Format_Commercial_IfAny": "DTS-HD High Resolution Audio",
"Format_Settings_Mode": "16",
"Format_Settings_Endianness": "Big",
"Format_AdditionalFeatures": "XBR",
"CodecID": "A_DTS",
"Duration": "7803.307000000",
"BitRate_Mode": "CBR",
"BitRate": "3456000",
"Channels": "8",
"ChannelPositions": "Front: L C R, Side: L R, Back: L R, LFE",
"ChannelLayout": "C L R LFE Lb Rb Lss Rss",
"SamplesPerFrame": "512",
"SamplingRate": "48000",
"SamplingCount": "374558736",
"FrameRate": "93.750",
"FrameCount": "731560",
"BitDepth": "24",
"Compression_Mode": "Lossy",
"Delay": "0.000",
"Delay_Source": "Container",
"Video_Delay": "0.000",
"StreamSize": "3371028480",
"Language": "en",
"Default": "Yes",
"Forced": "No",
"extra": {
"OriginalSourceMedium": "Blu-ray"
}

Same problem for Furious 7.
Could it be that mediainfo (wrongly) assumes that DTS:X is only to be searched if the codec is MA? That is not a requirement, DTS:X extensions can be present over lossy HRA and even low bitrate DTS (Disney+ is planning or already is streaming videos with DTS:X using low bitrate lossy DTS). It's the same as Atmos which is delivered in streaming services as extensions to low bitrate EAC3.
If you need a sample, please tell me where to upload it and what kind (how big and if you need video stream or just .mka will suffice).

I've sent you email with link to the samples. Both trigger DTS:X on my Denon AVR. Unfortunately I don't have the specs...
Disney+ IMAX Enhanced is still in the making. They promised "later this year" but so far it's not yet available.

Yes also noticed DTS:X does not get detected as "Lossless," instead it seems to have no "compression_mode."

Detection of DTS:X in another part of the stream is now added.
In order to keep track of what is "under" DTS:X, I keep now the underlying commercial name.
Note that it is like what is done in FFmpeg.
I shortened "Master Audio" and "High Resolution Audio" when DTS:X is present else it becomes a so long string.

DTS-HD MA + DTS:X
DTS-HD MA + IMAX Enhanced
DTS-HD HRA + DTS:X

Hope it is coherent with what your AVR display, else please report incoherencies.
Development snapshot: Windows, macOS

Yes also noticed DTS:X does not get detected as "Lossless," instead it seems to have no "compression_mode."

Added

Thanks. I've checked that it detects DTS:X correctly both on full mkv rip and on original 4K media of Furious 6 (when used with playlist or .ts container).
Regarding IMAX Enhanced, small inconsistency is that my AVR displays it as "IMAX DTS:X", not "IMAX Enhanced". Well the display on AVR and the screen information panel use limited characters, so it uses abbreviations like "DTS:X MA" for the display and "DTS:X MSTR" for info panel. There are not enough characters to write "IMAX DTS:X MA" there. Still, the point is that it displays both IMAX and DTS:X strings, while mediainfo only shows "IMAX Enhanced". I have no idea if IMAX extensions make any sense without DTS:X but whatever...
Another problem is regarding "Independence Day (1996)" movie. Check the list of IMAX Enhanced movies: - it's not there. Out of these movies, I have "Bad Boys for Life", "A Beautiful Planet" and "Journey to the South Pacific" and all correctly detected as IMAX DTS:X by AVR and by mediainfo. However, mediainfo insists that "Independence Day" is IMAX enhanced:
{
"@type": "Audio",
"StreamOrder": "1",
"ID": "2",
"OriginalSourceMedium_ID": "4352",
"UniqueID": "2",
"Format": "DTS",
"Format_Commercial_IfAny": "DTS-HD MA + IMAX Enhanced",
"Format_Settings_Mode": "16",
"Format_Settings_Endianness": "Big",
"Format_AdditionalFeatures": "XLL X IMAX",
"CodecID": "A_DTS",
"Duration": "9213.387000000",
"BitRate_Mode": "VBR",
"BitRate": "6139461",
"Channels": "8",
"ChannelPositions": "Front: L C R, Side: L R, Back: L R, LFE, Objects",
"ChannelLayout": "C L R LFE Lb Rb Lss Rss Objects",
"SamplesPerFrame": "512",
"SamplingRate": "48000",
"SamplingCount": "442242576",
"FrameRate": "93.750",
"FrameCount": "863755",
"BitDepth": "20",
"Compression_Mode": "Lossless",
"Delay": "0.000",
"Delay_Source": "Container",
"Video_Delay": "0.000",
"StreamSize": "7070654024",
"Language": "en",
"Default": "Yes",
"Forced": "No",
"extra": {
"OriginalSourceMedium": "Blu-ray"
}

My AVR doesn't detect any IMAX there. It just shows DTS:X MA. I checked online and no one ever claimed that it has IMAX Enhanced. If you any samples of what's mentioned here, I can share.

Regarding IMAX Enhanced, small inconsistency is that my AVR displays it as "IMAX DTS:X", not "IMAX Enhanced".

It seems very complicated also for DTS themselves to have a consistency there, e.g take this screenshot there is no display of "DTS:X" at all, and the website is https://www.imaxenhanced.com without any reference to DTS:X so the name seems to be more "IMAX Enhanced" than "IMAX DTS:X".
But FFmpeg uses "DTS:X IMAX" in the naming, maybe I should do same, maybe not, for the moment I let as is without saying that I won't change later.

There are not enough characters to write

And looks like that anyone is free to do what they want, DTS brand has some issues there...

My AVR doesn't detect any IMAX there. It just shows DTS:X MA. I checked online and no one ever claimed that it has IMAX Enhanced. If you any samples of what's mentioned here, I can share. Or should I open a new ticket for that?

Let's open a new ticket with trying to differentiate DTS:X and IMAX, with name of movies, how MI detects, and what should be detected if not same as the AVR.
Remind that due to lack of communication from DTS, it is reverse engineering, so the more different content I have + info about what an AVR does, the best it is.

It seems very complicated also for DTS themselves to have a consistency there, e.g take this screenshot there is no display of "DTS:X" at all, and the website is https://www.imaxenhanced.com/ without any reference to DTS:X so the name seems to be more "IMAX Enhanced" than "IMAX DTS:X".

Actually in that case they are referring only to the video part. The sound is marked 5.1, and uses Dolby Digital in all current streaming services anyway. It only means that it's a movie from this list - in practice most of movies in that list use Atmos for 4K UHD disks. Of course they wouldn't write IMAX DTS:X because it's not X and not DTS in the first place even. Just 5.1 Dolby Digital Plus with Atmos extensions at best.

Actually in that case they are referring only to the video part

Headache :(.
So maybe "DTS:X IMAX" instead of "IMAX Enhanced" is the best approach, but pinging @rg9400 @parasiteoflife, who were using "IMAX Enhanced", for opinion, before I change the wording.

So maybe "DTS:X IMAX" instead of "IMAX Enhanced" is the best approach, but pinging @rg9400 @parasiteoflife, who were using "IMAX Enhanced", for opinion, before I change the wording.

I am quite sure that IMAX Enhanced is the correct term, e.g. take a look at branding on AVR. Here it  means audio part. In manual they also mention IMAX Enhanced audio. They write "IMAX DTS:X" because of lack of characters on the on-screen display.
But yes, thanks to crappy marketing, there is no differentiation whether it's about only video or both video and audio, when they say "IMAX Enhanced". Some studios just use Atmos no matter what, so DTS:X is impossible in these home releases. "IMAX Enhanced" is also the name of certification
You should make the wording as it's convenient for you, I don't think "Enhanced" part is a huge deal. But it's the correct term.

This is interesting: https://manuals.marantz.com/U19_1_MZ_1/EU/en/BIAJSYdvfivvph.php
According to this manual, IMAX Enhanced DTS might exist as well, not only DTS:X. And AVR can detect some flag in the stream to automatically activate that mode. I think it's a theoretical support though, not (yet) used by any content. Just FYI @JeromeMartinez

Gonna post a link here to my comment to bring more awareness to it.
The IMAX Enhanced designation; at least the way MediaInfo sees it, is incorrect. That means there's more to DTS:X than we know:
https://github.com/MediaArea/MediaInfo/issues/422#issuecomment-2016671741


For the quota and limits of custom metrics

Hi team.

Category
Limit

Active time series/subscriptions/region
50,000

May I know the 50,000 limitation is applied at a tenant or subscription level?
Where I can monitor how many active time series I have actual time?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 09e9e6a7-4b37-e559-f719-63199aa78a0a
Version Independent ID: 398a63dd-0e08-9ff3-da4e-e26fb50cb287
Content: Custom metrics in Azure Monitor (Preview) - Azure Monitor
Content Source: articles/azure-monitor/platform/metrics-custom-overview.md
Service: azure-monitor
Sub-service: metrics
GitHub Login: @anirudhcavale
Microsoft Alias: ancav

@xuegao0112 Thanks for your comment! We will review and provide an update as appropriate.

@xuegao0112 Thanks for your comment! We will review and provide an update as appropriate.

@anirudhcavale Any insights on this please?

@anirudhcavale Any insights on this please?

@anirudhcavale Thanks a lot for providing insights offline.
@xuegao0112 The 50,000 time series limit is set at a subscription AND region level. So Subcription A in West US has 50K, and Subscription A in East US is another 50K. For the second question, currently there is no really good way to determine this yet.
Just FYI, this azure-docs repository deals about feedback related to particular Azure document page (like correcting Azure doc bugs, Azure doc enhancements, Azure product issues related to wrong doc instructions, etc.) so going forward if issue is intended to update / correct / enhance anything in an Azure document then please share that kind of feedback here.
But on the other hand, if you need help in resolving an Azure product related issue or question then I suggest you to ask the question in public forums like Microsoft Q&A, etc. but not here in this azure-docs repository. Hope this clarifies.

@anirudhcavale Thanks a lot for providing insights offline.
@xuegao0112 The 50,000 time series limit is set at a subscription AND region level. So Subcription A in West US has 50K, and Subscription A in East US is another 50K. For the second question, currently there is no really good way to determine this yet.
Just FYI, this azure-docs repository deals about feedback related to particular Azure document page (like correcting Azure doc bugs, Azure doc enhancements, Azure product issues related to wrong doc instructions, etc.) so going forward if issue is intended to update / correct / enhance anything in an Azure document then please share that kind of feedback here.
But on the other hand, if you need help in resolving an Azure product related issue or question then I suggest you to ask the question in public forums like Microsoft Q&A, etc. but not here in this azure-docs repository. Hope this clarifies.


Definition of "plan specification" and subtype "study design"

From<EMAIL_ADDRESS>on May 22, 2011 11:12:05
I have some issues with plan specification (ps), namely the fact that the ps tells its bearer what to do. Actually I have no issues was that, but where do we put a kind of specification that tells people (which are not the bearer of the specification) how to act, namely a coding schema (an information artefact telling people how to code medical services, procedure and supplies).
Regarding this problem, I was wondering whether "study design" really is a subtype to plan specification.
Any ideas?
Best,
Mathias
Original issue: http://code.google.com/p/information-artifact-ontology/issues/detail?id=112

From<EMAIL_ADDRESS>on May 23, 2011 02:57:15
Should say tells the bearer of it's concretization what to do. That would be true of agents that bear concretizations though not for all. Needs work.

From<EMAIL_ADDRESS>on May 23, 2011 07:41:00
[I also send a 'reply all' email to the list, thinking that would end up in the tracker, but apparently it doesn't, so I am repeating that email here].
The current definition states is:
"a directive information entity that when concretized it is realized in a process in which the bearer tries to achieve the objectives, in part by taking the actions specified. Plan specifications includes parts such as objective specification, action specifications and conditional specifications."
This already refers to 'bearer', and only concretizations of GDCs can have bearers. More specifically, it also says that the concretization can be realized, which implies that the specific concretization is a realizable entity (and not e.g. a document). This whole line of thought becomes a little clearer when looking at OBI rather than IAO. There, the intermediary class 'plan' is named, and the logical definitions of 'planned process' are present that are missing in IAO.

From<EMAIL_ADDRESS>on May 25, 2011 04:03:09
sorry, I still don't seem to get, although I agree with Bjoern that the way OBI gives it is slights more understandable and consistent.
But to me it seems that what is represented by this class is something like a computer program. The bearer of the program tries to achieve the the objectives. If you have a clinical study design the bearer most likely is a document (digital or not). The bearer does not try anything, but the agents managing the study (machine or human agents, both) do try to achieve the objectives specified.
Maybe what we need is to distinguish "directive information entity" which is always something like a program, service or tool from plans (directives) which have bearers, but are basically informing third parties about objectives. In that case directive information entity might be ill-named (but what are names in ontologies, right?). Furthermore, in that case study design cannot possibly be a subclass to directive information entity.
Best,
Matt

From<EMAIL_ADDRESS>on May 25, 2011 07:38:33
Let's see if I can explain the thinking better (I would argue that this part of OBI / IAO could use a formal writeup as a small paper; it is hard to understand). I may also miss parts of your concern, but first I want to be sure we are on a common understanding what the current implementation is meant to mean:
There is NO bearer of a plan specification. A plan specification is an 'information content entity' (ICE). An ICE can be 'concretized' in several forms, for example the content of 'Moby Dick' is an instance of an ICE that is concretized in several instances of patterns of ink in books, electromagnetic patterns on hard disks and neuron patterns in human brains. All of these patterns are specifically dependent continuants that are borne by material entiteis. In contrast, the ICE is a generically dependent continuant (because destroying a single one of its concretizations does not change it).
A concretization of a plan specification can be written down, memorized and communicated like other ICEs. But there is a specific concretization, namely a 'plan' which is only in those bearers that not only know of the plan specification but have the intend to realize it. A plan is therefore a realizable entity (like role, disposition and function).
In the case of a complex study design the bearer of the corresponding plan is typically a group of people. These people can still rely on written concretizations of the study design as a common reference, or verbal communication between each other to e.g. instruct technicians, which is just ICE exchange as usual. But as people are carrying out planned processes that are part of the study design execution, they are bearer of (parts of) the concretization of the study design.
Does that make sense?

Bjoern

From<EMAIL_ADDRESS>on May 25, 2011 08:27:56
Bjoern, thanks for your clarification which is helpful, because it pointed me to a mistake I made: I forgot that human minds can be bearers of ICEs.
Yet, some problems remain:
Why can we say plan specifications have no bearers, when the definition states the opposite?
I think, by now I have the impression that your argumentation introduces a double bottom that looks somewhat superfluous from the point of view that BFO (and probably IAO, too) tend to be quite re-iterative with respect to ICE anyway (and rightly so).
You say (correct me if I am wrong) that of any plan specification exists in multiple concretizations in specific pattern (very different ones). These patterns (SDC opposed to our original plan specification which is a GDC) are now borne by different bearers, which are IC. These pattern look like something similar to a quality. Even though that might be, we need to be careful this quality like thing is not to be mistaken as a plan or plan specification. A specific pattern of ink on paper can be a study design in one language and a poem in another language.
Anyways, the definition as given in IAO (and maybe in OBI) two seems to be wrong, because given that we have , say, of my cancer study design. One concretizations is such that it is a pattern in my brain, whereas another concretization is such that it is a specific pattern of ink on a piece of paper. Both of these concretizations would, as far as I understand you, have bearers. One would be e, the other would be the sheet of paper in front of me. In case of the sheet of paper neither the plan specification, nor the concretized plan specification tell its bearer anything.
I like the idea of making a difference between the two concretizations above in saying the concretization my mind is a plan, but we must check which BFO whether this is a fourth subtype of realizable entity.
Given all that the definition in IAO rings wrong to me and since this is what people see we ought to work on optimizing it. I offer my assistance there.
Best,
Matt
PS: Does any of this make sense?

From<EMAIL_ADDRESS>on May 25, 2011 08:57:07
In the textual definition:
"a directive information entity that when concretized it is realized in a process in which the bearer tries to ... "
the "bearer" is supposed to refer to the bearer of the concretization. I agree that this is confusing - mostly because we were aiming for short and readable english definitions, which should be read side-by-side with the logical ones (which are missing from IAO). So I would suggest to change it to
"a directive information entity that when concretized it is realized in a process in which the bearer of the concretization tries to ... "
I believe the 'plan' class, which is present in OBI and is a sibling of other realizable entities does what you are asking for: distinguish concretizations of plan specifications that are e.g. qualities of a piece of paper of the bearer from those that are realizables.
One thing this discussion is pointing out is that the split between IAO and OBI is problematic. IAO was originally only going to deal with pure ICEs, and therefore was not going to take planned process, plan and such things, all of which were originally developed in OBI.
One option would be to make a slim extension of BFO that would be imported by both IAO and OBI that would have only a minimal set of classes and relations including

information content entity
plan specification
objective specification
plan
planned process

Alan had in the past been reluctant to do this because he still wanted flexibility to change definitions for ICE, but I think at this point it is time to bite that bullet.

From<EMAIL_ADDRESS>on May 25, 2011 09:17:43
I think your original question arose from a maybe not very clear definition of "plan specification": "a directive information entity that when concretized it is realized in a process in which the bearer tries to achieve the objectives, in part by taking the actions specified. Plan specifications includes parts such as objective specification, action specifications and conditional specifications."
Here bearer means "the bearer of the concretization of the plan specification". This is probably clearer if we look at the parent class, directive information entity: "An information content entity whose concretizations indicate to their bearer how to realize them in a process."
Any directive information entity is concretized as an SDC.
This SDC then has bearers, and those are the bearers referred to in the definition (which could be made clearer)
Let us consider your example of cancer study. You are thinking about that study, making "plans" of how this should be done. You will probably write a grant, recruit patients, have an experimental protocol to follow, collect results, analyze those results, and then draw a conclusion. You will then summarize this in a publication.
This is all part of the plan specification, and all the elements described above are subparts: e.g., your objective specification may be "determine effect of drug X on malignant cell proliferation". Your study design would be "recruit 50 patients, obtain their consent, administer them a drug etc." Specific protocols would be "take 50ml of drug X, dilute to 1/10, and administer sub cutaneously, repeat 3h later"
At some point, those will get written down, and your plan specification is then concretized into its SDC, the plan. Your team of scientists will read and aim at execute your protocols, you will submit your proposal to an IRB etc...
The bearer of the concretization of your plan specification is for example the scientist, which aims at performing tasks as described by the concretization of the plan specification. When you will write up a publication summarizing your results you will be a bearer etc.

From<EMAIL_ADDRESS>on May 25, 2011 09:23:50
As OBI imports IAO, would it make sense to consolidate everything into IAO (i.e., your set of minimal classes and relations)? I agree that having plan in IAO would really help make things clearer. I also think we should document this better on the wiki: I started a page at https://code.google.com/p/information-artifact-ontology/wiki/DirectiveInformationEntity . Feel free to update.

From<EMAIL_ADDRESS>on May 25, 2011 09:25:50
Melanie,
thanks for summarizing what i think. I only slightly disagree with the last paragraph which seems to be a bit sloppy (if I may say so): The written down (thus concretized) plan specification is already an SDC which is borne by  piece of paper. This bearer does nothing, regardless of the fact that there really exists bearers (my  brain, your brain) that invest or trigger some action towards fulfilling the plan.
By now I am absolutely sure that a definition that needs so much explaining is suspicious of being wrong. Why mention the bearers of a completely different entity (concretization) anyway?

From<EMAIL_ADDRESS>on May 26, 2011 02:14:49
here is an afterthought:
what is the realizable entity a plan specification is about? That seems to be something different from the plan which (as I think) showed in my last e-mail (since the plan can be pattern of ink on a paper; correct me if I am wrong).
Best,
Matt

From<EMAIL_ADDRESS>on May 26, 2011 17:16:57
A 'plan' can not be patterns of ink on a paper (I think Melanie didn't write that intentionally). It must be borne by an entity that intends to realize it.
There are two views what a plan specification is about. In my mind, an instance of a plan specification is about the class of planned processes (and participants in those processes) that realize its concretizations. Alan suggests that an instance of a plan specification is about instances rather than classes.

From<EMAIL_ADDRESS>on May 28, 2011 01:17:46
OK. I think I am with Alan here.  But maybe let me give you my version and see what your reaction to that turns out to be:
(before I start I need to say I am feeling extremely uncomfortable with the verb "concretize" and the term "concretization" since I am not really sure what this would be in BFO and I have a feeling we are creating unnecessary extra-entities.
S, there are plans which as Bjoern are borne by entities that intend to realize them. Thus, plans are good realizable entities (subclass to SDC). All plan specifications are about plans (all ICE needs to be about somthing, right?). Every instance of a plan specification can x (fill in whatever verb you like "inhere in", "be borne by" maybe even "concretize", whatever your preferred name for the relation between DCs and ICs you like) in different material entity (my brain, this sheet of paper, this audio tape). What is realized is the plan, not the plan specification. But the plan specification can transport my plan of how to seize world power to you, resulting in you having a similar but not same (SDC!!!) plan of how to seize world power).
What do you think?

From<EMAIL_ADDRESS>on March 10, 2014 10:21:06
After a discussion on an IAO/OBI call I wanted to point out a parallel issue with Objective Specification and Plan Specification. Both can be concretized as either quality or realizable entity (though at least one) and perhaps this dual concretization is an  important differentia for the terms. When editing the terms both should be constructed on concert so that they are parallel.


ORDER BY two columns. Result differs from manual SQL query

I have the following records:

end_date
position

2017-12-10
0

2017-12-12
10

2017-11-10
10

2017-02-10
10

2017-12-13
10

2017-12-23
0

I want to ORDER them BY position AND by end_date so I wrote:
$datas = $database->select("events", "*", ["category" => "music"], ["ORDER" => "position DESC, end_date DESC"]);

But the result given was the following. Records have been ordered by position but not by end_date

end_date
position

2017-11-10
10

2017-02-10
10

2017-12-12
10

2017-12-13
10

2017-12-10
0

2017-12-23
0

The query written using square brackets as explained in the DOCs generates an error:
"ORDER" => ["position" => "DESC", "end_date" => "DESC"]
Whilst the same query typed in phpMyAdmin or HeidiSQL actually ordered the records correctly:
SELECT * FROM eventsWHEREcategory = "music" order by position DESC, end_date DESC

end_date
position

2017-12-13
10

2017-12-12
10

2017-11-10
10

2017-02-10
10

2017-12-23
0

2017-12-10
0

$datas = $database->select(     "events",     "*",     [         "AND" => ["category" => "music"],         "ORDER" => [             "position" => "DESC",             "end_date" => "DESC"         ]     ], );
Was not able to run this but the idea here is that your 'WHERE' clause and the 'ORDER BY' clause (many others) are passed at the 3rd argument's position under the same array separated by different respective indexes.

Thanks for answering. I understand that WHERE and ORDER must be passed as 3rd argument but I tried many solutions without success:

Warning: Invalid argument supplied for foreach()
$datas = $database->select("eventi", "*", ["AND" => ["category" => "live"], "ORDER" => ["position" => "DESC", "end_date" => "DESC"]]);

Warning: PDO::quote() expects parameter 1 to be string, array given
$datas = $database->select("eventi", "*", ["AND" => ["category" => "live"], ["ORDER" => ["position" => "DESC", "end_date" => "DESC"]]]);

This does not report errors but it orders only by the first clause:
$datas = $database->select("eventi", "*", ["AND" => ["category" => "live"], "ORDER" => ["position DESC, end_date DESC"]]);


Replace u128s with equivalent byte array representations

u128s are not supported in the serde frameworks we intend to use,
so represent them as an equivalent array type (which ARE) supported.
Signed-off-by: Connor Kuehl<EMAIL_ADDRESS>Closes #27

I modified the GitHub Actions matrix in this PR, the 1.42.0 checks will never start.

I modified the GitHub Actions matrix in this PR, the 1.42.0 checks will never start.

I guess they were once a github task and setup to be required for merge but have been removed since.
@npmccallum would have to modify the repo settings

I modified the GitHub Actions matrix in this PR, the 1.42.0 checks will never start.

I guess they were once a github task and setup to be required for merge but have been removed since.
@npmccallum would have to modify the repo settings

oh, I see they are in the matrix

I modified the GitHub Actions matrix in this PR, the 1.42.0 checks will never start.

I guess they were once a github task and setup to be required for merge but have been removed since.
@npmccallum would have to modify the repo settings

@connorkuehl You changed the version.. so the repo settings don't match anymore.
https://github.com/enarx/sev/pull/29/files#diff-faff1af3d8ff408964a57b2e475f69a6b7c7b71c9978cccc8f471798caac2c88L24

Yeah, this is just how it is when a PR "removes" a check that the master branch expects to run. This'll need to be manually merged, I think.


Files created by PowerShell have execute bit on owner set

Steps to reproduce
PS /home/demo> Get-Process > output.gp
PS /home/demo> ps > output.ps

Expected behavior
Create file based on umask for system
Actual behavior
File created by PowerShell cmdlets have execute bit set on file owner
-rwxrw-r--. 1 demo demo 21K Mar 29 08:10 output.gp
-rw-rw-r--. 1 demo demo 248 Mar 29 08:10 output.ps

Environment data
Name                           Value
----                           -----
PSVersion                      6.0.0-alpha
PSEdition                      Core
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0...}
BuildVersion                   <IP_ADDRESS>
GitCommitId                    v6.0.0-alpha.17
CLRVersion
WSManStackVersion              3.0
PSRemotingProtocolVersion      2.3
SerializationVersion           <IP_ADDRESS>

Dupe of https://github.com/PowerShell/PowerShell/issues/2481


frontend: revert button fix

This commit reverts the last fix to the button, since it introduced
another issue. Also, it addressed the root cause of the original
problem, which was that one of the templates was missing the correct
class.

lgtm. merging on green


Error: Cannot find module "node-v46-win32-x64\debug.node"

OS: Windows 10
node: v4.4.3
node-inspector: v0.12.8
nvm-windows: v1.1.0
Error: Cannot find module 'C:\Users\...\AppData\Roaming\npm\node_modules\v8-debug\build
\debug\v0.7.7\node-v46-win32-x64\debug.node'

Inside of the folder *v8-debug\build\debug\v0.7.7*
There is only v47 there is no v46 ... node-v47-win32-x64

I have found the issue when nvm is run, v8-debug version will vary depending on currently selected version of node in NVM...
Although it would have be nice if we could somehow choose which environment/s we want to add ...

re install


Add Conditional SSL Support for Redis Connection

Problem:
Currently, our application connects to Redis without SSL/TLS. This potentially exposes sensitive data during transmission, especially when connecting to a remote Redis instance. We need to provide a way to optionally secure our Redis connection using SSL/TLS.
Proposed Solution:

Use environment variables to determine if a secure Redis connection should be established.
If REDIS_SSL is set to "true", the application should:

Read the CA certificate specified in REDIS_CA_CERT.
Use this certificate to create a TLS configuration.
Apply this TLS configuration when establishing a connection to Redis.

Additionally, introduce new environment variables REDIS_CLIENT_CERT and REDIS_CLIENT_KEY to specify paths to the Redis client certificate and key respectively.

Implementation Details:

Introduce environment variables: REDIS_SSL, REDIS_CA_CERT, REDIS_CLIENT_CERT, and REDIS_CLIENT_KEY.
Conditionally create a tls.Config based on the value of REDIS_SSL.
Use this tls.Config when initializing the Redis client.

Working on it.


FTP Source - large files can make the connector crash

Version: Confluent Platform 3.3
What is the expected behaviour?
When reading a big file from an FTP source, it is processed correctly
What was observed?
When reading a file from an FTP server with the FTP Source Connector, the connector crashes (out of memory).
From what I understand, the whole file is read in memory directly, meaning the big files will be an issue even if I increase the memory available to my connector.
Is this by design ? Is there a way around this ? Could we expect the source connector to become better with big files ?
java.lang.OutOfMemoryError: Java heap space
    at java.util.Arrays.copyOf(Arrays.java:3236)
    at java.io.ByteArrayOutputStream.grow(ByteArrayOutputStream.java:118)
    at java.io.ByteArrayOutputStream.ensureCapacity(ByteArrayOutputStream.java:93)
    at java.io.ByteArrayOutputStream.write(ByteArrayOutputStream.java:153)
    at org.apache.commons.net.io.Util.copyStream(Util.java:124)
    at org.apache.commons.net.ftp.FTPClient._retrieveFile(FTPClient.java:1924)
    at org.apache.commons.net.ftp.FTPClient.retrieveFile(FTPClient.java:1889)
    at com.datamountaineer.streamreactor.connect.ftp.source.FtpMonitor.fetch(FtpMonitor.scala:74)
    at com.datamountaineer.streamreactor.connect.ftp.source.FtpMonitor$$anonfun$fetchFromMonitoredPlaces$3.apply(FtpMonitor.scala:142)
    at com.datamountaineer.streamreactor.connect.ftp.source.FtpMonitor$$anonfun$fetchFromMonitoredPlaces$3.apply(FtpMonitor.scala:142)
    at scala.collection.immutable.Stream.flatMap(Stream.scala:489)
    at com.datamountaineer.streamreactor.connect.ftp.source.FtpMonitor.fetchFromMonitoredPlaces(FtpMonitor.scala:142)
    at com.datamountaineer.streamreactor.connect.ftp.source.FtpMonitor$$anonfun$poll$1$$anonfun$apply$1.apply(FtpMonitor.scala:190)
    at com.datamountaineer.streamreactor.connect.ftp.source.FtpMonitor$$anonfun$poll$1$$anonfun$apply$1.apply(FtpMonitor.scala:189)
    at scala.collection.immutable.Stream.flatMap(Stream.scala:489)
    at com.datamountaineer.streamreactor.connect.ftp.source.FtpMonitor$$anonfun$poll$1.apply(FtpMonitor.scala:189)
    at com.datamountaineer.streamreactor.connect.ftp.source.FtpMonitor$$anonfun$poll$1.apply(FtpMonitor.scala:189)
    at scala.util.Try$.apply(Try.scala:192)
    at com.datamountaineer.streamreactor.connect.ftp.source.FtpMonitor.poll(FtpMonitor.scala:189)
    at com.datamountaineer.streamreactor.connect.ftp.source.FtpSourcePoller.fetchRecords(FtpSourceTask.scala:78)
    at com.datamountaineer.streamreactor.connect.ftp.source.FtpSourcePoller.poll(FtpSourceTask.scala:69)
    at com.datamountaineer.streamreactor.connect.ftp.source.FtpSourceTask.poll(FtpSourceTask.scala:121)
    at org.apache.kafka.connect.runtime.WorkerSourceTask.execute(WorkerSourceTask.java:163)
    at org.apache.kafka.connect.runtime.WorkerTask.doRun(WorkerTask.java:146)
    at org.apache.kafka.connect.runtime.WorkerTask.run(WorkerTask.java:190)
    at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
    at java.util.concurrent.FutureTask.run(FutureTask.java:266)
    at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
    at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
    at java.lang.Thread.run(Thread.java:745)
``

For your information, we are working on a fix. euranova/stream-reactor#1 .
We will submit a pull request to you when happy with the result. In the mean time, feel free to participate. Any input would be very appreciated.

Hi,
I try to extract a xml file from a remote server using Apache FTPclient and size of the file varies from 2 to 3 GB. When the retrieveFile(FTPClient) method is called, it returns the error message.  java.lang.OutOfMemoryError: Requested array size exceeds VM limit
at java.util.Arrays.copyOf(Arrays.java:2271)
at java.io.ByteArrayOutputStream.grow(ByteArrayOutputStream.java:113)
at java.io.ByteArrayOutputStream.ensureCapacity(ByteArrayOutputStream.java:93)
at java.io.ByteArrayOutputStream.write(ByteArrayOutputStream.java:140)
at org.apache.commons.net.io.Util.copyStream(Util.java:119)
at org.apache.commons.net.ftp.FTPClient.retrieveFile(FTPClient.java:1286)
The application is deployed in Jboss app server and the maximum heap is set to 4GB at present. The application uses Java language to do the same. Request your help to resolve the issues.

@JoeInigo Increase the heap space available to the Connect workers.

@andrewstevenson, Yes. I have tried that.  The buffer size of the OutputStream exceeds while calling the retrieve the file. Any suggestions like reading the contents by parts or file slices and then storing them

@JoeInigo "The application is deployed in Jboss app server"? Which version of the FTP Kafka Connector or you running?

Yes.. The Application is deployed in Jboss. We are not using FTP Kafka connector rather using FTPClient from org.apache.commons.net.ftp version 2.0

@JoeInigo We can't help you I'm afraid. I would ask on stackoverflow as we aren't supporting the FTPClient and your custom app.

@andrewstevenson , Thanks. Is there any other FTP clients that can be used for this case.


Fix broken pending block fetching

This PR aims to address the issue raised in #51 and #41
When the page is longer than 100 blocks, it cannot be retrieved in a single call to the Notion private API. There was code to go through the "pagination" to retrieve missing blocks, but it was not working. I replaced it something simpler that does the following:

Get the list of all block ids on the page
Check which one are missing from the list of blocks we have
Fetch missing blocks
Do that again if there are still missing blocks.

Because my code is simpler, I may have broken other things. I don't have any knowledge about the Notion private API, so if you have more experience, please review the change made.

Looking good. Thanks for this!


1.6 istio-proxy SDS not updating certificates SSLV3_ALERT_CERTIFICATE_EXPIRED

Bug description
In our 1.6 qualifying environment we have an application that is rejecting requests with upstream connect error or disconnect/reset before headers. reset reason: connection failure.
We have three (almost) identical test apps:

istio-test-app-1
istio-test-app-2
istio-test-app-3 (this is the broken one)

We continually send load that goes 1 -> 2 -> 3.
We rolling restart istio-test-app-1 every 10 minutes to create config churn

The pod is 25 hours old, however as you can see here something happened at 14:35 which broke istio-test-app-3 (1 and 2 remain fine).
The istio proxy logs contain lots of sds noise:
{"level":"info","time":"2020-10-17T14:39:40.757245Z","scope":"sds","msg":"resource:default new connection"}
{"level":"info","time":"2020-10-17T14:39:40.757366Z","scope":"sds","msg":"Skipping waiting for ingress gateway secret"}
{"level":"info","time":"2020-10-17T14:39:40.757625Z","scope":"cache","msg":"GenerateSecret from file default"}
{"level":"info","time":"2020-10-17T14:39:40.757772Z","scope":"sds","msg":"resource:default pushed key/cert pair to proxy"}
{"level":"info","time":"2020-10-17T14:39:40.875744Z","scope":"sds","msg":"resource:default new connection"}
{"level":"info","time":"2020-10-17T14:39:40.875865Z","scope":"sds","msg":"Skipping waiting for ingress gateway secret"}
{"level":"info","time":"2020-10-17T14:39:40.876142Z","scope":"cache","msg":"GenerateSecret from file default"}
{"level":"info","time":"2020-10-17T14:39:40.876315Z","scope":"sds","msg":"resource:default pushed key/cert pair to proxy"}
{"level":"info","time":"2020-10-17T14:44:40.680854Z","scope":"sds","msg":"resource:default connection is terminated: rpc error: code = Canceled desc = context canceled"}
{"level":"info","time":"2020-10-17T14:44:40.680939Z","scope":"sds","msg":"resource:default connection is terminated: rpc error: code = Canceled desc = context canceled"}
2020-10-17T14:44:40.681104Z	warning	envoy config	[bazel-out/k8-opt/bin/external/envoy/source/common/config/_virtual_includes/grpc_stream_lib/common/config/grpc_stream.h:92] StreamSecrets gRPC config stream closed: 2, resource:default Close connection to proxy "sidecar~<IP_ADDRESS>~istio-test-app-3-69d695bf8b-b256m.istio-test-app-3~istio-test-app-3.svc.cluster.local-44"
2020-10-17T14:44:40.681167Z	warning	envoy config	[bazel-out/k8-opt/bin/external/envoy/source/common/config/_virtual_includes/grpc_stream_lib/common/config/grpc_stream.h:92] StreamSecrets gRPC config stream closed: 2, resource:default Close connection to proxy "sidecar~<IP_ADDRESS>~istio-test-app-3-69d695bf8b-b256m.istio-test-app-3~istio-test-app-3.svc.cluster.local-45"
{"level":"info","time":"2020-10-17T14:44:40.989664Z","scope":"sds","msg":"resource:default new connection"}
{"level":"info","time":"2020-10-17T14:44:40.989763Z","scope":"sds","msg":"Skipping waiting for ingress gateway secret"}
{"level":"info","time":"2020-10-17T14:44:40.989996Z","scope":"cache","msg":"GenerateSecret from file default"}
{"level":"info","time":"2020-10-17T14:44:40.990130Z","scope":"sds","msg":"resource:default pushed key/cert pair to proxy"}
{"level":"info","time":"2020-10-17T14:44:41.101797Z","scope":"sds","msg":"resource:default new connection"}
{"level":"info","time":"2020-10-17T14:44:41.101917Z","scope":"sds","msg":"Skipping waiting for ingress gateway secret"}
{"level":"info","time":"2020-10-17T14:44:41.102142Z","scope":"cache","msg":"GenerateSecret from file default"}
{"level":"info","time":"2020-10-17T14:44:41.102384Z","scope":"sds","msg":"resource:default pushed key/cert pair to proxy"}
{"level":"info","time":"2020-10-17T14:49:40.680826Z","scope":"sds","msg":"resource:default connection is terminated: rpc error: code = Canceled desc = context canceled"}
{"level":"info","time":"2020-10-17T14:49:40.680922Z","scope":"sds","msg":"resource:default connection is terminated: rpc error: code = Canceled desc = context canceled"}
2020-10-17T14:49:40.681068Z	warning	envoy config	[bazel-out/k8-opt/bin/external/envoy/source/common/config/_virtual_includes/grpc_stream_lib/common/config/grpc_stream.h:92] StreamSecrets gRPC config stream closed: 2, resource:default Close connection to proxy "sidecar~<IP_ADDRESS>~istio-test-app-3-69d695bf8b-b256m.istio-test-app-3~istio-test-app-3.svc.cluster.local-46"
2020-10-17T14:49:40.681109Z	warning	envoy config	[bazel-out/k8-opt/bin/external/envoy/source/common/config/_virtual_includes/grpc_stream_lib/common/config/grpc_stream.h:92] StreamSecrets gRPC config stream closed: 2, resource:default Close connection to proxy "sidecar~<IP_ADDRESS>~istio-test-app-3-69d695bf8b-b256m.istio-test-app-3~istio-test-app-3.svc.cluster.local-47"
{"level":"info","time":"2020-10-17T14:49:40.853145Z","scope":"sds","msg":"resource:default new connection"}
{"level":"info","time":"2020-10-17T14:49:40.853301Z","scope":"sds","msg":"Skipping waiting for ingress gateway secret"}
{"level":"info","time":"2020-10-17T14:49:40.853587Z","scope":"cache","msg":"GenerateSecret from file default"}
{"level":"info","time":"2020-10-17T14:49:40.853768Z","scope":"sds","msg":"resource:default pushed key/cert pair to proxy"}
{"level":"info","time":"2020-10-17T14:49:40.917526Z","scope":"sds","msg":"resource:default new connection"}
{"level":"info","time":"2020-10-17T14:49:40.917640Z","scope":"sds","msg":"Skipping waiting for ingress gateway secret"}
{"level":"info","time":"2020-10-17T14:49:40.917876Z","scope":"cache","msg":"GenerateSecret from file default"}
{"level":"info","time":"2020-10-17T14:49:40.918032Z","scope":"sds","msg":"resource:default pushed key/cert pair to proxy"}
{"level":"info","time":"2020-10-17T14:54:40.680797Z","scope":"sds","msg":"resource:default connection is terminated: rpc error: code = Canceled desc = context canceled"}
{"level":"info","time":"2020-10-17T14:54:40.680866Z","scope":"sds","msg":"resource:default connection is terminated: rpc error: code = Canceled desc = context canceled"}
2020-10-17T14:54:40.680941Z	warning	envoy config	[bazel-out/k8-opt/bin/external/envoy/source/common/config/_virtual_includes/grpc_stream_lib/common/config/grpc_stream.h:92] StreamSecrets gRPC config stream closed: 2, resource:default Close connection to proxy "sidecar~<IP_ADDRESS>~istio-test-app-3-69d695bf8b-b256m.istio-test-app-3~istio-test-app-3.svc.cluster.local-48"
2020-10-17T14:54:40.681040Z	warning	envoy config	[bazel-out/k8-opt/bin/external/envoy/source/common/config/_virtual_includes/grpc_stream_lib/common/config/grpc_stream.h:92] StreamSecrets gRPC config stream closed: 2, resource:default Close connection to proxy "sidecar~<IP_ADDRESS>~istio-test-app-3-69d695bf8b-b256m.istio-test-app-3~istio-test-app-3.svc.cluster.local-49"
{"level":"info","time":"2020-10-17T14:54:40.758052Z","scope":"sds","msg":"resource:default new connection"}
{"level":"info","time":"2020-10-17T14:54:40.758157Z","scope":"sds","msg":"Skipping waiting for ingress gateway secret"}
{"level":"info","time":"2020-10-17T14:54:40.758426Z","scope":"cache","msg":"GenerateSecret from file default"}
{"level":"info","time":"2020-10-17T14:54:40.758584Z","scope":"sds","msg":"resource:default pushed key/cert pair to proxy"}
{"level":"info","time":"2020-10-17T14:54:41.127609Z","scope":"sds","msg":"resource:default new connection"}
{"level":"info","time":"2020-10-17T14:54:41.127721Z","scope":"sds","msg":"Skipping waiting for ingress gateway secret"}
{"level":"info","time":"2020-10-17T14:54:41.127964Z","scope":"cache","msg":"GenerateSecret from file default"}
{"level":"info","time":"2020-10-17T14:54:41.128115Z","scope":"sds","msg":"resource:default pushed key/cert pair to proxy"}
{"level":"info","time":"2020-10-17T14:59:40.680900Z","scope":"sds","msg":"resource:default connection is terminated: rpc error: code = Canceled desc = context canceled"}
{"level":"info","time":"2020-10-17T14:59:40.680941Z","scope":"sds","msg":"resource:default connection is terminated: rpc error: code = Canceled desc = context canceled"}
2020-10-17T14:59:40.681091Z	warning	envoy config	[bazel-out/k8-opt/bin/external/envoy/source/common/config/_virtual_includes/grpc_stream_lib/common/config/grpc_stream.h:92] StreamSecrets gRPC config stream closed: 2, resource:default Close connection to proxy "sidecar~<IP_ADDRESS>~istio-test-app-3-69d695bf8b-b256m.istio-test-app-3~istio-test-app-3.svc.cluster.local-50"
2020-10-17T14:59:40.681147Z	warning	envoy config	[bazel-out/k8-opt/bin/external/envoy/source/common/config/_virtual_includes/grpc_stream_lib/common/config/grpc_stream.h:92] StreamSecrets gRPC config stream closed: 2, resource:default Close connection to proxy "sidecar~<IP_ADDRESS>~istio-test-app-3-69d695bf8b-b256m.istio-test-app-3~istio-test-app-3.svc.cluster.local-51"
{"level":"info","time":"2020-10-17T14:59:40.795179Z","scope":"sds","msg":"resource:default new connection"}
{"level":"info","time":"2020-10-17T14:59:40.795280Z","scope":"sds","msg":"Skipping waiting for ingress gateway secret"}
{"level":"info","time":"2020-10-17T14:59:40.795539Z","scope":"cache","msg":"GenerateSecret from file default"}
{"level":"info","time":"2020-10-17T14:59:40.795689Z","scope":"sds","msg":"resource:default pushed key/cert pair to proxy"}
{"level":"info","time":"2020-10-17T14:59:41.114830Z","scope":"sds","msg":"resource:default new connection"}
{"level":"info","time":"2020-10-17T14:59:41.114952Z","scope":"sds","msg":"Skipping waiting for ingress gateway secret"}
{"level":"info","time":"2020-10-17T14:59:41.115164Z","scope":"cache","msg":"GenerateSecret from file default"}
{"level":"info","time":"2020-10-17T14:59:41.115318Z","scope":"sds","msg":"resource:default pushed key/cert pair to proxy"}
{"level":"info","time":"2020-10-17T15:04:40.680881Z","scope":"sds","msg":"resource:default connection is terminated: rpc error: code = Canceled desc = context canceled"}
{"level":"info","time":"2020-10-17T15:04:40.680970Z","scope":"sds","msg":"resource:default connection is terminated: rpc error: code = Canceled desc = context canceled"}
2020-10-17T15:04:40.681071Z	warning	envoy config	[bazel-out/k8-opt/bin/external/envoy/source/common/config/_virtual_includes/grpc_stream_lib/common/config/grpc_stream.h:92] StreamSecrets gRPC config stream closed: 2, resource:default Close connection to proxy "sidecar~<IP_ADDRESS>~istio-test-app-3-69d695bf8b-b256m.istio-test-app-3~istio-test-app-3.svc.cluster.local-52"
2020-10-17T15:04:40.681126Z	warning	envoy config	[bazel-out/k8-opt/bin/external/envoy/source/common/config/_virtual_includes/grpc_stream_lib/common/config/grpc_stream.h:92] StreamSecrets gRPC config stream closed: 2, resource:default Close connection to proxy "sidecar~<IP_ADDRESS>~istio-test-app-3-69d695bf8b-b256m.istio-test-app-3~istio-test-app-3.svc.cluster.local-53"
{"level":"info","time":"2020-10-17T15:04:40.980455Z","scope":"sds","msg":"resource:default new connection"}
{"level":"info","time":"2020-10-17T15:04:40.980561Z","scope":"sds","msg":"Skipping waiting for ingress gateway secret"}
{"level":"info","time":"2020-10-17T15:04:40.980783Z","scope":"cache","msg":"GenerateSecret from file default"}
{"level":"info","time":"2020-10-17T15:04:40.980906Z","scope":"sds","msg":"resource:default pushed key/cert pair to proxy"}
{"level":"info","time":"2020-10-17T15:04:41.180954Z","scope":"sds","msg":"resource:default new connection"}
{"level":"info","time":"2020-10-17T15:04:41.181074Z","scope":"sds","msg":"Skipping waiting for ingress gateway secret"}
{"level":"info","time":"2020-10-17T15:04:41.181312Z","scope":"cache","msg":"GenerateSecret from file default"}
{"level":"info","time":"2020-10-17T15:04:41.181612Z","scope":"sds","msg":"resource:default pushed key/cert pair to proxy"}
{"level":"info","time":"2020-10-17T15:09:40.680961Z","scope":"sds","msg":"resource:default connection is terminated: rpc error: code = Canceled desc = context canceled"}
2020-10-17T15:09:40.681152Z	warning	envoy config	[bazel-out/k8-opt/bin/external/envoy/source/common/config/_virtual_includes/grpc_stream_lib/common/config/grpc_stream.h:92] StreamSecrets gRPC config stream closed: 2, resource:default Close connection to proxy "sidecar~<IP_ADDRESS>~istio-test-app-3-69d695bf8b-b256m.istio-test-app-3~istio-test-app-3.svc.cluster.local-54"
2020-10-17T15:09:40.681253Z	warning	envoy config	[bazel-out/k8-opt/bin/external/envoy/source/common/config/_virtual_includes/grpc_stream_lib/common/config/grpc_stream.h:92] StreamSecrets gRPC config stream closed: 2, resource:default Close connection to proxy "sidecar~<IP_ADDRESS>~istio-test-app-3-69d695bf8b-b256m.istio-test-app-3~istio-test-app-3.svc.cluster.local-55"
{"level":"info","time":"2020-10-17T15:09:40.681058Z","scope":"sds","msg":"resource:default connection is terminated: rpc error: code = Canceled desc = context canceled"}
{"level":"info","time":"2020-10-17T15:09:40.842526Z","scope":"sds","msg":"resource:default new connection"}
{"level":"info","time":"2020-10-17T15:09:40.842666Z","scope":"sds","msg":"Skipping waiting for ingress gateway secret"}
{"level":"info","time":"2020-10-17T15:09:40.842911Z","scope":"cache","msg":"GenerateSecret from file default"}
{"level":"info","time":"2020-10-17T15:09:40.843082Z","scope":"sds","msg":"resource:default pushed key/cert pair to proxy"}
{"level":"info","time":"2020-10-17T15:09:40.893759Z","scope":"sds","msg":"resource:default new connection"}
{"level":"info","time":"2020-10-17T15:09:40.893894Z","scope":"sds","msg":"Skipping waiting for ingress gateway secret"}
{"level":"info","time":"2020-10-17T15:09:40.894106Z","scope":"cache","msg":"GenerateSecret from file default"}
{"level":"info","time":"2020-10-17T15:09:40.894256Z","scope":"sds","msg":"resource:default pushed key/cert pair to proxy"}

The only difference that istio-test-app-3 has vs 1 and 2 is that it uses:
    - name: OUTPUT_CERTS
      value: /etc/certs

As per this documentation.
To write certs to this volumeMount:
  - emptyDir:
      medium: Memory
    name: istio-certs

In order to write the certs to disk (as I was experimenting with for prometheus)
Looking at the logs I see:
2020-10-17T15:15:40.611175Z     debug   envoy conn_handler      [external/envoy/source/server/connection_handler_impl.cc:411] [C59921] new connection
2020-10-17T15:15:40.612284Z     debug   envoy connection        [external/envoy/source/extensions/transport_sockets/tls/ssl_socket.cc:191] [C59921] handshake expecting read
2020-10-17T15:15:40.612317Z     debug   envoy connection        [external/envoy/source/extensions/transport_sockets/tls/ssl_socket.cc:191] [C59921] handshake expecting read
2020-10-17T15:15:40.612704Z     debug   envoy connection        [external/envoy/source/extensions/transport_sockets/tls/ssl_socket.cc:198] [C59921] handshake error: 1
2020-10-17T15:15:40.612717Z     debug   envoy connection        [external/envoy/source/extensions/transport_sockets/tls/ssl_socket.cc:226] [C59921] TLS error: 268436501:SSL routines:OPENSSL_internal:SSLV3_ALERT_CERTIFICATE_EXPIRED
2020-10-17T15:15:40.612723Z     debug   envoy connection        [external/envoy/source/common/network/connection_impl.cc:200] [C59921] closing socket: 0
2020-10-17T15:15:40.612752Z     debug   envoy conn_handler      [external/envoy/source/server/connection_handler_impl.cc:111] [C59921] adding to cleanup list
2020-10-17T15:15:40.679479Z     debug   envoy filter    [external/envoy/source/extensions/filters/listener/original_dst/original_dst.cc:18] original_dst: New connection accepted
2020-10-17T15:15:40.679512Z     debug   envoy filter    [external/envoy/source/extensions/filters/listener/tls_inspector/tls_inspector.cc:78] tls inspector: new connection accepted
2020-10-17T15:15:40.679541Z     debug   envoy filter    [external/envoy/source/extensions/filters/listener/tls_inspector/tls_inspector.cc:148] tls:onServerName(), requestedServerName: outbound_.80_._.app.istio-test-app-3.svc.cluster.local
2020-10-17T15:15:40.679607Z     debug   envoy conn_handler      [external/envoy/source/server/connection_handler_impl.cc:411] [C59922] new connection
2020-10-17T15:15:40.680782Z     debug   envoy connection        [external/envoy/source/extensions/transport_sockets/tls/ssl_socket.cc:191] [C59922] handshake expecting read
2020-10-17T15:15:40.680811Z     debug   envoy connection        [external/envoy/source/extensions/transport_sockets/tls/ssl_socket.cc:191] [C59922] handshake expecting read
2020-10-17T15:15:40.681162Z     debug   envoy connection        [external/envoy/source/extensions/transport_sockets/tls/ssl_socket.cc:198] [C59922] handshake error: 1
2020-10-17T15:15:40.681181Z     debug   envoy connection        [external/envoy/source/extensions/transport_sockets/tls/ssl_socket.cc:226] [C59922] TLS error: 268436501:SSL routines:OPENSSL_internal:SSLV3_ALERT_CERTIFICATE_EXPIRED

Which makes me check:
❯ ./src/1.6.12/bin/istioctl pc secret istio-test-app-3-69d695bf8b-b256m.istio-test-app-3
RESOURCE NAME     TYPE           STATUS     VALID CERT     SERIAL NUMBER                               NOT AFTER                NOT BEFORE
default           Cert Chain     ACTIVE     true<PHONE_NUMBER>71782252960640586806792969930     2020-10-17T13:34:41Z     2020-10-16T13:34:41Z
default           Cert Chain     ACTIVE     true<PHONE_NUMBER>71782252960640586806792969930     2020-10-17T13:34:41Z     2020-10-16T13:34:41Z
ROOTCA            CA             ACTIVE     true<PHONE_NUMBER>870835277565802163895395946       2030-10-07T07:55:53Z     2020-10-09T07:55:53Z

Which shows the certificates are indeed out of date - and expired exactly when we started seeing issues.
This made me check another app where we mount certificates in this way (prometheus) and sure enough I see its certs are out of date too:
❯ ./src/1.6.12/bin/istioctl pc secret prometheus-0.app-metrics
RESOURCE NAME     TYPE           STATUS     VALID CERT     SERIAL NUMBER                              NOT AFTER                NOT BEFORE
default           Cert Chain     ACTIVE     true<PHONE_NUMBER>7091452019065727082748990393     2020-10-16T18:43:59Z     2020-10-15T18:43:59Z
default           Cert Chain     ACTIVE     true<PHONE_NUMBER>7091452019065727082748990393     2020-10-16T18:43:59Z     2020-10-15T18:43:59Z
ROOTCA            CA             ACTIVE     true<PHONE_NUMBER>870835277565802163895395946      2030-10-07T07:55:53Z     2020-10-09T07:55:53Z

Restarting the pod renewed the certificates:
❯ ./src/1.6.12/bin/istioctl pc secret istio-test-app-3-69d695bf8b-87x6j.istio-test-app-3
RESOURCE NAME     TYPE           STATUS     VALID CERT     SERIAL NUMBER                               NOT AFTER                NOT BEFORE
default           Cert Chain     ACTIVE     true<PHONE_NUMBER>09398884220511848353340100457     2020-10-18T15:21:26Z     2020-10-17T15:21:26Z
default           Cert Chain     ACTIVE     true<PHONE_NUMBER>09398884220511848353340100457     2020-10-18T15:21:26Z     2020-10-17T15:21:26Z
ROOTCA            CA             ACTIVE     true<PHONE_NUMBER>870835277565802163895395946       2030-10-07T07:55:53Z     2020-10-09T07:55:53Z

[ ] Docs
[ ] Installation
[ ] Networking
[ ] Performance and Scalability
[ ] Extensions and Telemetry
[x] Security
[ ] Test and Release
[x] User Experience
[ ] Developer Infrastructure
Expected behavior
SDS certs to be updated correctly when using OUTPUT_CERTS
Steps to reproduce the bug
No idea
Version (include the output of istioctl version --remote and kubectl version --short and helm version if you used Helm)
1.6.12
How was Istio installed?
Helm
Environment where bug was observed (cloud vendor, OS, etc)
GKE

cc. @howardjohn @mandarjog 🤷

@JimmyCYJ @myidpt

@Stono 1.6 updates will EOL when 1.8 releases in mid November. I am wondering if you considered moving directly to 1.7 instead to stay in the window?

Absolutely not.   Do you know how many istio users are not on 1.7?
  There needs to be a focus on stability where you are right now, not enhancements.    12 patch versions into 1.6 and I wouldn't describe it as anything other than broken.

I am not super familiar with this option without looking into it but from the logs it looks like we are refreshing the cert from the file rather than istiod. The doc suggests this option is for VMs where the user is providing the (long expiry) cert which would explain this behavior although I am not sure it's expected since I think this is how we recommended Prometheus getting certs.

Looks like sds-agent uses existence of /etc/certs as a signal of rotating cert based on file, this does not make sense to me and it should be controlled by an env var, or at least should be based on a less general path.
Could you mount /etc/istio-certs or something even specific like /etc/istio-prom-certs and try again?

But as far as I can tell, there's nothing for the OUTPUT_CERTS.

You probably want to try proxyMetadata in proxyConfig.

I think I recall now the /etc/certs mounting is controlled by .Values.global.mountMtlsCerts which is for legacy citadel secret mounting or integration with external CAs that load certs via the same mechanisms. I think there is a collision with OUTPUT_CERTS being the same dir as @bianpengyuan mentioned

FYI we have .Values.global.mountMtlsCerts=false in our configuration.  It might be worth driving the behaviour around rotation of certs from that setting instead rather than the existence of a directory?
I've updated our mount as you have suggested and will update here if it worked.

I can confirm changing the directory means we're now getting certificate rotation, however that seems to have highlighted a cli bug: https://github.com/istio/istio/issues/28099
Do you want me to keep this issue open to track UX improvements as I think this path needs to be documented clearly as others are going to need to do it?  I've documented what I did in https://karlstoney.com/2020/10/15/istio-upgrades-prometheus-sds/index.html

@Stono you can do it with:
      annotations:
        proxy.istio.io/config: |
          proxyMetadata:
            OUTPUT_CERTS: /tmp/certs

I think we need to update some of the mesh config docs for this annotation though, it was new

Basically anything under meshConfig.defaultConfig can be overriden per-pod

@Stono Yes, please keep this issue open. I am going to add the document and will borrow some content from your blog.

FYI we have .Values.global.mountMtlsCerts=false in our configuration. It might be worth driving the behaviour around rotation of certs from that setting instead rather than the existence of a directory?
And then as extra belt and braces, not allowing folks to use /etc/certs in OUTPUT_CERTS (and documentation update)?

I will read through the logic and see how to make it not depend on presence of the cert dir.

@bianpengyuan re ISTIO_META_, where is the documentation explaining how that works? We only want it on a single proxy, not them all.

John beat me on it, the option is still hidden from doc, we should update that.

I will update the doc for mesh config

Can confirm this combo of annotations does the job:
        proxy.istio.io/config: |
          proxyMetadata:
            OUTPUT_CERTS: /etc/istio-output-certs
        sidecar.istio.io/userVolume: '[{"name": "istio-certs", "emptyDir": {"medium":"Memory"}}]'
        sidecar.istio.io/userVolumeMount: '[{"name": "istio-certs", "mountPath": "/etc/istio-output-certs"}]'

Closing this issue as there's a PR merged to document it.


HeaderCreator leaking file descriptors

Hi,
recently we were having serious troubles using sbt-header plugin on Windows 10 with git. Especially with enabled AutomateHeaderPlugin. While running SBT almost every operation with git failed (pull, revert, rebase) with odd errors about unable to unlink old file. You have to turn SBT off, then execute git operation and then turn SBT back on to continue development (which is pretty annoying).
I've located cause to the HeaderCreator, line val fileContent = scala.io.Source.fromInputStream(input)(Codec.UTF8).mkString. Source.fromInputStream is not closing input, so file descriptor is open till SBT is closed, thus preventing git and sometimes event IntelliJ IDEA to modify file. Even in case file was not modified by the user, but only check for correct header.
Simply wrapping it and close input stream will do the magic (I'm not sure why InputStream is passed down, instead of Path):
    val fileContent = try {
      scala.io.Source.fromInputStream(input)(Codec.UTF8).mkString
    } finally {
      input.close()
    }

Thanks for reporting and analyzing. PR very welcome.


[#21] Configure missing git identity

Fixes deployment failing because git username/mail are not configured, as described here: https://github.com/GermanZero-de/klimaschutzmonitor/issues/21#issuecomment-1745000927
I tested the fix locally using act.

The build fails with some weird nodejs/npm error, although all I did was change the deploy script and workflow. The error can't be related to my changes...


map for futureSuitability w/ fish categories

Under the sankey, build a static map of part of WI, with a click-out to "explore more" as a leaflet map.
click lakes to get probabilities.

Iterating w/ GH on this, but here is the start for the WMS:

at https://www.sciencebase.gov/catalog/item/imap/57854d3de4b0e02680bf201d

Iterating with GH and @mhines-usgs on this. Megan created the fiddle:  http://jsfiddle.net/mkhines/m8q1xs19/
Ultimately, what we would like to do here is

[ ] host three different WMSs for the three different periods (jordan will do this)
[ ] create a radio button to toggle between time periods (toggle between those layers). Force the user to have == one selected at all times
[ ] on click of a feature, we bring back a tool tip that has a filtered subset of the attributes come back (assuming we can alter that css when the attributes are locked in)
[ ] include a legend (like what we have in the screen-cap)
[ ] have this be something can wrap up and deploy as part of the viz, but as its own "explore more" subpage.

I've got a few of these ticked off, I'll start on the radio toggle/layer toggle now. May just use other irrelevant layers until you have the other WMSs ready. Let me know any feedback on what is ticked.

Re: the legend, I'm using the legend graphic coming from ScienceBase WMS getCaps. If you want a No Data swatch, you should have one in the original shapefile/layer so that it'll feed in from there. Is that possible?

For the last checkbox (have something that can be wrapped up and deploy as part of the viz)

You'll have to copy & paste the html/js and css into new files and check into repo.
You'll also want the leaflet.css, leaflet.js and jquery-1.10.1.min.js files that are "External Resources" in the fiddle currently.
These will need to be referenced in the html file. make sure the html file also has a div with the id of map.

three layers
1989-2014:

https://www.sciencebase.gov/catalog/item/57924eafe4b0fc973c6bcc6d
https://www.sciencebase.gov/catalogMaps/mapping/ows/57924eafe4b0fc973c6bcc6d?service=wms&request=getcapabilities&version=1.3.0

2040-2064:

https://www.sciencebase.gov/catalog/item/57924fd3e4b0fc973c6bccdf
https://www.sciencebase.gov/catalogMaps/mapping/ows/57924fd3e4b0fc973c6bccdf?service=wms&request=getcapabilities&version=1.3.0

2065-2089:

https://www.sciencebase.gov/catalog/item/57925024e4b0fc973c6bcce3
https://www.sciencebase.gov/catalogMaps/mapping/ows/57925024e4b0fc973c6bcce3?service=wms

One for all:
https://www.sciencebase.gov/catalogMaps/mapping/ows/57927e39e4b0d02dcaaeed1d?service=wms&request=getcapabilities&version=1.3.0

I think we're good here @jread-usgs !
Do you want me to check files into the repo? Or is someone else prepared to do that? Not sure how you'd like to work it into the viz.

yes, if you can check those files into the sandbox dir, we can figure out where @jiwalker-usgs wants them to live when we get that far.

@gjahansen2 ☝

:heart_eyes:

completed with: https://github.com/USGS-VIZLAB/climate-fish-habitat/pull/86


Wildcards not supported

I assume this is not compatible with permission wildcards, as I can't get it to work
using: {{ this.$laravel.getPermissions() }} results in [ "*.view", "*.create" ] but v-can="'users.create'" doesn't trigger
Ref: Spatie wildcard permissions docs
Could you please add support for wildcards ?

Great idea, I'll work on it!

Resolved in v2.0.0! 🎉


Removed unused minSDK and targetSDK on android manifest

The minSDK and targetSDK are configured on build.gradle, this settings are unused

I tought that may be the case but does that apply to new projects created
with Gdx Setup? And for people with such custom builds, shouldn't they know
how to configure those custom environments and add whatever is missing on
the manifest for them to work?
On Mon, Aug 6, 2018, 10:24 Tomski<EMAIL_ADDRESS>wrote:

There are other ways to build still, we dont enforce Gradle, so this would
break projects for those people building outside of Gradle.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/libgdx/libgdx/pull/5335#issuecomment-410628403, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ABthvF3yGSBZKAPdRSPMgk6Pg6qOHC0Zks5uN_1SgaJpZM4VvVOe
.

It should be as complete as possible from the get go. And yes you can use the generator to create projects and still not build with Gradle.

Ok, I thought Android could not be built without Gradle anymore. Can be
closed.
On Mon, Aug 6, 2018, 10:55 Tomski<EMAIL_ADDRESS>wrote:

It should be as complete as possible from the get go. And yes you can use
the generator to create projects and still not build with Gradle.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/libgdx/libgdx/pull/5335#issuecomment-410637200, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ABthvEmkkFIFd_7pkdMzQR1vY6XasHlSks5uOASAgaJpZM4VvVOe
.

Yeah, its possible. Painful and not recommended, but there are those out there that like that kind of thing. So I think it would be best to just leave it there, its not doing too much harm, and prevents an additional step for those wanting to go down that path.


C# Remove troublesome indefinite articles

Fixes #784

Codecov Report

Merging #1046 into master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #1046   +/-   ##
=========================================
  Coverage     85.32%   85.32%
  Complexity     3455     3455
=========================================
  Files           360      360
  Lines         13745    13745
  Branches       1568     1568
=========================================
  Hits          11728    11728
  Misses         1563     1563
  Partials        454      454

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c510b9f...2eba412. Read the comment docs.


Make this work with mini-html-webpack-plugin?

Do you think it would be worthwhile to try to make the plugin work with mini-html-webpack-plugin? I'm curious what it would take on that side to integrate. We should just 1. generate files 2. write references. I could possibly add some hook.

I think it's a great idea if you're willing to expose a hook that provides write access to the html data.
For reference, this is where we hook onto html-webpack-plugin and this is how tags are injected


Publish 7.6-20221027165012+0000

Publish 7.6-20221027165012+0000

@bot-gradle test and merge

OK, I've already triggered a build for you.


[11.x] Adds intended_to_route helper

Introducing intended_to_route highly inspired from 'to_route`.
// return redirect()->intended(route('users.show', ['user' => $user]));
return intended_to_route('users.show', ['user' => $user]);

Thanks for your pull request to Laravel!
Unfortunately, I'm going to delay merging this code for now. To preserve our ability to adequately maintain the framework, we need to be very careful regarding the amount of code we include.
If possible, please consider releasing your code as a package so that the community can still take advantage of your contributions!
If you feel absolutely certain that this code corrects a bug in the framework, please "@" mention me in a follow-up comment with further explanation so that GitHub will send me a notification of your response.


add missing dependencies to module pattern

I am not entirely sure why, but Scala 3 needs these modules to be available in order to compile. Strange that Scala 2 does not also require them :-) It could of course also be a bug in Scala 3 so take this with a grain of salt :-)

Yes, I've seen this when switched to dotty. Weird.


[feature-request] Mac OS X version

Are you guys going to make a Mac OS X, Swift 2 version as well?

Hello @avioli, this is already written in Swift 2, an OS X app isn't in the pipes yet, the focus here isn't the client but the core functionality.


Azure Batch

Azure Batch allows you to choose Marketplace Images, but I can't find the configuration option to enable Hybrid use for Azure Batch. Is it supported?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 6ef4a337-5ded-458c-9131-fee7a8fa99a6
Version Independent ID: 094498ab-3275-a114-8d47-1722c1af5388
Content: Azure Hybrid Benefit for Windows Server - Azure Windows Virtual Machines
Content Source: articles/virtual-machines/windows/hybrid-use-benefit-licensing.md
Service: virtual-machines-windows
GitHub Login: @xujing-ms
Microsoft Alias: xujing

Thanks for the feedback! We are currently investigating and will update you shortly.

@MatthewSteeples Apologies in delayed response, I was checking with internal team on this.
In the VirtualMachineConfiguration section of the Add Pool API here, you will see licenseType which will allow you to utilize AHUB.

@MatthewSteeples
Hope the provided information is helpful.
We will now close this issue. If there are further questions regarding this, please tag me in a comment. we will continue the discussion.


Add ProtocolSupport plugin

added tag for player's protocol version.
Resource Page: http://www.spigotmc.org/resources/protocolsupport.2367/

... You've never used Github before, have you?

Also, why should we link this plugin and not just copy over the code for this one tag you want?

Nevermind, misunderstood the purpose of the plugin

@DNx5 pls...


docs deployment

Making a few tweaks to @thazhemadam's excellent start and then will merge this in and deploy our real docs so we can jettison the wiki ones! 😁

Just a reminder to change the CI script's branch for the documentation workflow.

Haha thanks, just did that, then realized I hadn’t set up the gh-pages in the repo and I think I might have to trigger the build again for it to actually go…almost there!
Best,
Rachel Kurchin, PhD
MolSSI Postdoctoral Fellow
Carnegie Mellon Mechanical Engineering and Materials Science
rkurchin.github.io
On Mar 18, 2021, 7:45 PM -0400, Anant Thazhemadam @.***>, wrote:

Just a reminder to change the CI script's branch for the documentation workflow.
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub, or unsubscribe.

Codecov Report

Merging #51 (4e101ae) into main (5261341) will not change coverage.
The diff coverage is 66.66%.

@@           Coverage Diff           @@
##             main      #51   +/-   ##
=======================================
  Coverage   93.44%   93.44%
=======================================
  Files           6        6
  Lines         412      412
=======================================
  Hits          385      385
  Misses         27       27

Impacted Files
Coverage Δ

src/atomgraph.jl
86.02% <ø> (ø)

src/atomfeat.jl
92.80% <50.00%> (ø)

src/pmg_graphs.jl
98.92% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5261341...4e101ae. Read the comment docs.

Still to do here:

[ ] update things for restructure
[ ] finish changelog
[ ] add some examples

@thazhemadam, I'm inclined to just merge this if you think the general skeleton is okay. It's getting painful to rebase because it's kind of old. We can fill in the other gaps in a smaller PR.

I'm inclined to just merge this if you think the general skeleton is okay

@rkurchin the overall skeleton lgtm.

It's getting painful to rebase because it's kind of old.

I concur. This PR is painfully behind main and the restructure as is.

We can fill in the other gaps in a smaller PR.

Just a note here that we're yet to set up doctests, and some more docstrings too.


Zero division error while training a hindi model

Hello @jaywalnut310
I am new to the field, Hence forgive me if my question is naive.
It would really help me if you answer.
I am training a LJ Hindi phoneme model and have updated the ipa characters based on the phonemes in the data set.
How ever when I start Training I keep getting the Zero Division error.
I have tried to check for corrupt data but there were none, also while debugging it seems data loader is making this problem.
Also, when I train an english model on same data set with english transcription it work, but keeps giving error in hindi model.
Can you help understand what is causing the error?
I am attaching the screen shot of the error in the image below.

See https://github.com/jaywalnut310/vits/issues/54
code in lines 323 in data_utils.py:
    for i in range(len(buckets) - 2, -1, -1):
        if len(buckets[i]) == 0:
            buckets.pop(i)
            self.boundaries.pop(i+1)

@l1006986533 , I tried this but this is still creating error and it depends on data, because on other data I was able to run

I fix this by rewrite the boundaries, it's in line 70 in train.py.
[32,300,400,500,600,700,800,900,1000]
Delete the 2 or 3 front boundaries and rerun the program. In my program, I delete 32, 300 and it works.
[400,500,600,700,800,900,1000]
I haven't read the source code, so I'm not quite understanding why it work and whether it can fix your problem.

i go the same problem . I did change the boundaries to [400,500,600,700,800,900,1000] but synthesized speech lost information . For example, when i input "I haven't read the source code, so I'm not quite sure whether it can fix your problem" it output an audio that speaks : "I haven't read the source code, so I'm not quite sure whether it" . Do you know why?

@tuannvhust so, based on the function description based on boundaries as input there are 3 values selected from the boundaries, and if boundaries = [b1, b2, b3] -> any x s.t. length(x) <= b1 or length(x) > b3 are discarded.
but I have tried changing the boundaries based on my input data still zero division error keeps coming.
Can anyone please help?
@l1006986533 @jaywalnut310 @nikich340

changing the boundaries to [32,400,500,600,700,800,900,1000] works for me

Hello, my situation is very similar to yours, but the problem arises during training Chinese, can you tell us about the duration and amount of your data, maybe our problem is in the same place @tieincred

Hello, my situation is very similar to yours, but the problem arises during training Chinese, can you tell us about the duration and amount of your data, maybe our problem is in the same place @tieincred

早上好，中午好，以及晚上好。
1.你用的是哪个库呢，原版的库不能训练中文的，应该是CjangCjengh的吧
2.在报错的前一行加一行输出self.lengths，根据self.lengths的值调整train.py(或train_ms.py)里的boundaries,也就是[32,300,400,500,600,700,800,900,1000]，避免某个区间的bucket为空就不会报错了

非常感谢，但是我不知道是否误解了您的意思，我的报错如上图，我在‘ids_bucket = ids_bucket + ids_bucket * (rem // len_bucket) + ids_bucket[:(rem % len_bucket)]’前面加了一行‘print（self .lengths）’但是输出的是空列表，我不知道这是否正常，接下来该怎么做，或者我误解了您的意思，期待您的回复。@l1006986533

正常情况如图，我有278个音频作为训练数据，所以len(self.lengths)为278。输出空列表说明训练数据没有读进来，检查一下你filelists中的txt文件(例如filelists/train.txt)和config.json。

感谢，但是依然无济于事，我检查了config和list，参考https://www.bilibili.com/read/cv21153903?spm_id_from=333.1007.0.0   ，我确认应该是没有问题了，但是错误依然存在。输出值依然是空列表，我不知道该怎么做
此外，这是我的配置及报错

（我总共有20个近4分钟的数据，可能问题在这）
期待您的回复
@l1006986533

@Xiaoxiaosito 不好意思最近比较忙，回复会比较慢。
和你说的一样，不能直接放长文本，否则会没法读进去。具体来说，一句话最长为190个字符，约等于30秒的音频。建议每个音频控制在10到20秒。

关于音频的分割处理，教程(https://www.bilibili.com/read/cv21153903?spm_id_from=333.1007.0.0)已经写的很详细了，不再重复

非常感谢，问题已解决 @l1006986533

@Xiaoxiaosito 不好意思最近比较忙，回复会比较慢。
和你说的一样，不能直接放长文本，否则会没法读进去。具体来说，一句话最长为190个字符，约等于30秒的音频。建议每个音频控制在10到20秒。

So, as I understand after translate your comment. the audio lengths should be in the range 10 - 20 second right ?

@Xiaoxiaosito 不好意思最近比较忙，回复会比较慢。
和你说的一样，不能直接放长文本，否则会没法读进去。具体来说，一句话最长为190个字符，约等于30秒的音频。建议每个音频控制在10到20秒。

So, as I understand after translate your comment. the audio lengths should be in the range 10 - 20 second right ?

Yes it is.