systemd: 246 -> 246.4

This bumps systemd to the latest stable maintenance release.

dc2e82af33 core: create per-user inaccessible node from the service manager
0b3c497347 nspawn,pid1: pass "inaccessible" nodes from cntr mgr to pid1 payload via /run/host
2239965c29 coredump: don't convert s → µs twice
61d29b7f8c firstboot: fill empty color if ansi_color unavailable from os-release
9678a3daf6 varlink: do not parse invalid messages twice
4e516dcbc1 userdbctl: add forgotten --output mode in help
aee20dfbd8 shared/{user,group}-record-nss: adjust filtering of "valid" passwords
5933d77afe doc: cross link sd_listen_fd() docs a bit
97fdde3239 Rework how we cache mtime to figure out if units changed
0500968241 core: always try to reload not-found unit
8ae22f0d64 pid1: use the cache mtime not clock to "mark" load attempts
715507c277 core: rename manager_unit_file_maybe_loadable_from_cache()
20ad76d0a7 man: document fd ownership for sd-bus fd marshalling
38ae73fafd resolved: make sure we initialize t->answer_errno before completing the transaction
a1ba0fbef6 homed: fix log message to honor real homework path
d6b1e659b3 src/shared/dissect-image.c: fix build without blkdid (#16901)
e42f9add21 analyze: fix error handling in one case
4804ce1488 units: add missing usb-gadget.target
5ad4e68c37 man: extend on the usec/sec discrepancy
2fb612371d login/logind: Include sys/stat.h for struct stat usage
5e884e7ee0 partition/makefs: Include missing sys/file.h header
7bbc3807da network: dhcp6: logs only new address
2056429e0f Don't run test-repart when loop devices are not available
dcbea51c5a man: clarify that several networkctl commands takes device names
16e4cfcc82 networkctl: label command does not take any argument
2352921244 missing: Add new Linux capability
8b29c4a4f9 tty-ask-pw-agent: properly propagate error
f7ce2e9839 tty-ask-pw-agent: the message string might not be set
29cba5c9ef tty-ask-pw-agent: make sure "--list" works correctly
e1ce367d73 add "list" verb to autocompleted commands
1f4cb5da1e shell-completion/zsh: add missing verbs for networkctl
a4236a2764 path: Improve $PATH search directory case
b7cef386bd path: Skip directories when finalising $PATH search
122945f315 rules: don't install 80-drivers.rules when kmod is disabled
42fab2d454 zsh: correct journalctl command completion parsing
ed3f97f962 basic/missing_syscall: fix syscall numbers for arm64 :(
ba6e7f7c46 shared/install: fix preset operations for non-service instantiated units
d39f139348 nss-resolve: treat BUS_ERROR_NO_SUCH_UNIT the same as SD_BUS_ERROR_SERVICE_UNKNOWN too
9bb3e64d71 various: treat BUS_ERROR_NO_SUCH_UNIT the same as SD_BUS_ERROR_SERVICE_UNKNOWN
6d802dd596 man: drop reference to long gone .busname unit type
a29656804b man: fix a fix of a typo in systemd.service example
21ce0f5b33 network: can: Fix CAN initialization
cab5cde8c9 man: update autogenerated dbus api lists
0d8000522b man: fix invalid tag place
ea94f218be man: add conditionals to more man pages
ef91325349 meson: add ENABLE_ANALYZE conditional
83f7c0a7ec core: add missing conditions/asserts to unit file parsing
716718155d analyze: rework condition testing
5c4c7581bc sd-bus: fix error handling on readv()
6cd058f305 user-runtime-dir: deal gracefully with missing logind properties
6a2d73638d shared/seccomp: do not use ifdef guards around textual syscall names
7355ac9689 machine-id-setup: don't use KVM or container manager supplied uuid if in chroot env
496a71f444 man: Fix typo in systemd-tmpfiles
6c5d216ad8 homework: downgrade chattr failure log message
1708f06a00 homework: explicitly close cryptsetup context, to not keep loopback device busy
a21eaa2a3a homework: correct error passed into log message
3a2d169f36 homework: sync everything to disk before we rename LUKS loopback file into place
84e1ab74d2 homed: downgrade quota message in containers
8b62cadf36 analyze-security: do not assign badness to filtered-out syscalls
29854a5437 NEWS: clarify two points
4cb4fb82f7 meson: add min version for libfdisk
76331f86f6 load-fragment: fix grammar in error messages
1e53c2d70f Fix function description in logind man page
669066564d network: do not fail if UseMTU=yes on DHCP lease lost
a2a3f16cdc missing_syscall: do not use function name that may conflict with glibc
4091dcd469 missing_syscall: fix pidfd_{send_signal,open} numbers for alpha
7875daf52b network: wait for previous address removal before configuring static addresses
120064b4a1 network: only process non-error message
f44ec1de15 test: accept that char device 0/0 can now be created witout privileges
946e4c43bb tools/make-man-index: fix purpose text that contains tags
dae0586e91 test-fs-util: skip encrypted path test if we get EACCES
0d026c9b0d Newer Glibc use faccessat2 to implement faccessat
fde6520d46 namespace: fix minor memory leak
208ba581f4 man: fix incorrectly placed full stop
6c81d57828 man: fix typo
53a8d2588e bless-boot: add missing verb to --help
4cfa0ac4fd user-record: deal with invalid GECOS fields gracefully
ae5234ef48 user-util: add mangle_gecos() call for turning strings into fields suitable as GECOS fields
972391ac39 fix typo in systemctl help
443aacfcda man: clarify that LogNamespace= is for system services only
5aec8fe54e _sd-common.h: avoid parsing errors with Coverity
f9ad4ea2ca analyze: fix 'cat-config systemd/zram-generator.conf'
dda6fec1df man: describe that changing Storage= does not move existing data
2bbd33e476 core: reset bus error before reuse
b81504a3c7 nspawn: Fix incorrect usage of putenv
cb263973ac man: fix typo in systemd.service
73b432e7ef network: fix DHCPv6 Prefix Delegation example after option rename

Motivation for this change
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[ ] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[ ] Fits CONTRIBUTING.md.

I've been running this today on my router and desktop. It did not wreck my world so far.
I'm always scared about validating such big changes. Especially provided the past data of us breaking things after bumping systemd.
We need to find a way to improve the test coverage here. I'm still not sure how.

Maybe also ask more people to test it (with instructions)? I think there are a few people (including me) that would be fine with testing it especially as it's easy to revert a nixos configuration.
Do I need to just checkout this pr and rebuild or are there additional steps? Also do you get prebuild packages?

@mohe2015 Thanks for asking!
I'd essentially be a nixos-rebuild switch -I nixpkgs=/path/to/this/checkout.
Unfortunately, there's no hydra jobset, so you'd need to build everything by yourself.

Are there any estimationa? I'm using flakes and it says it needs to rebuild 1982 packages and I have a laptop with an nvme ssd, 16 gb ram, some swap and AMD Ryzen 7 4700U (8 cores, max is 4 GHz or so). I don't think it will manage it.

Depends on the particular packages, but I'd expect this to be fine e.g. as one overnight build.  Some packages take several seconds, some can take an hour on their own (chromium, libreoffice).

I think you're right - thanks for the heads up. I didn't interpret the output correctly at first (its nix unstable).

@vcunat what do you think of creating a systemd branch and jobset that builds nixos/release-small.nix? We could also have such branch and jobset for gcc/binutils and future PR's could reuse those jobsets. At least that way the core is being build.

Doesn't look like the sha256 was updated, only the version?
https://github.com/NixOS/nixpkgs/pull/97658/files#diff-dd830f049b8e42facd9261dc425529f1

Indeed, just pushed a new commit fixing that :-D

At this moment, it feels like adding more "rebuild branches" can only come at the expense of some of those that we already have.  There are four with much work to do ATM: staging-{next,20.09,20.03} and glibc-232.
  I think the glibc update might be already good enough to merge to staging, though we want more of the jobs to finish to know better ;-)
Generally it would be nice (wrt. efficiency) if we only had one or two feature branches (e.g. glibc-232) with many rebuilds active at one time, though I understand it may be hard for priorities of the contributors.

builder for '/nix/store/5i38nzfljv8hnxj1ck453x0id1d3zr3f-bash-completion-2.10.drv' failed with exit code 1; last 10 log lines:
    /build/source/test/t/unit/test_unit_variables.py:39: PytestUnknownMarkWarning: Unknown pytest.mark.complete - is this a typo?  You can register custom marks to avoid this warning - for details, see https://docs.pytest.org/en/latest/mark.html
      @pytest.mark.complete(": ${#___v")

  -- Docs: https://docs.pytest.org/en/latest/warnings.html
  =========================== short test summary info ============================
  FAILED test/t/test_installpkg.py::TestInstallpkg::test_3 - AssertionError: as...
  ERROR test/t/test_installpkg.py::TestInstallpkg::test_2 - pexpect.exceptions....
  ERROR test/t/test_installpkg.py::TestInstallpkg::test_4 - AssertionError: Error running "cd 'slackware/home'": exit status=130, output="
  ERROR test/t/test_installpkg.py::TestInstallpkg::test_4 - AssertionError: Env...
  = 1 failed, 959 passed, 411 skipped, 22 xfailed, 1 xpassed, 1326 warnings, 3 errors in 904.55s (0:15:04) =

anyone any ideas? (this was at the point I commented - I will retry with the current commit). btw I'm using home-manager, nix-unstable and flakes

bash-completion package is very flakey and the test suite takes 2 hours on
my machine.
We should just completely disable the test suite on that package. It's a
recurring issue and totally unrelated to this PR.
I was wanting to make a pr for this for quite some time now but I keep
forgetting
On Sat, Sep 12, 2020, 12:50 Moritz Hedtke<EMAIL_ADDRESS>wrote:

builder for '/nix/store/5i38nzfljv8hnxj1ck453x0id1d3zr3f-bash-completion-2.10.drv' failed with exit code 1; last 10 log lines:
/build/source/test/t/unit/test_unit_variables.py:39: PytestUnknownMarkWarning: Unknown pytest.mark.complete - is this a typo?  You can register custom marks to avoid this warning - for details, see https://docs.pytest.org/en/latest/mark.html
@pytest.mark.complete(": ${#___v")
-- Docs: https://docs.pytest.org/en/latest/warnings.html
=========================== short test summary info ============================
FAILED test/t/test_installpkg.py::TestInstallpkg::test_3 - AssertionError: as...
ERROR test/t/test_installpkg.py::TestInstallpkg::test_2 - pexpect.exceptions....
ERROR test/t/test_installpkg.py::TestInstallpkg::test_4 - AssertionError: Error running "cd 'slackware/home'": exit status=130, output="
ERROR test/t/test_installpkg.py::TestInstallpkg::test_4 - AssertionError: Env...
= 1 failed, 959 passed, 411 skipped, 22 xfailed, 1 xpassed, 1326 warnings, 3 errors in 904.55s (0:15:04) =
anyone any ideas? (this was at the point I commented - I will retry with
the current commit). btw I'm using home-manager, nix-unstable and flakes
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
https://github.com/NixOS/nixpkgs/pull/97658#issuecomment-691468164, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AAEZNIZ2W64NL2YCDJEPVU3SFNG65ANCNFSM4RFAXMFQ
.

bash-completion package test suite s very flakey and the test suite sometimes randomly takes hours on my machine. We should just completely disable the test suite on that package. It's a recurring issue and totally unrelated to this PR. I was wanting to make a pr for this for quite some time now but I keep forgetting.
…

I actually submitted a PR a while ago that should at least make it execute in parallel and thus massively speed up the execution. Was that reverted due to (the previously existing) flakiness?
Anyway, I've built the tested nixos set of this PR on my hydra instance and you can use it if you trust my binary cache. Most/all of the tests did finish and I just restarted a all the failed once again since there appeared to be some issue with one of the builders.
The result can be seen at https://hydra.h4ck.space/build/263996 (ipv6 only).
Just pass the following to the nix-build invocation:
--option substituters "https://cache.nixos.org/ https://cache.h4ck.space/" --option trusted-public-keys "zeta:9zm3cHRlqz3T9HnRsodtQGGqHOLDAiB+8d0kOKnFI0M= cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY="

246.5 was released a couple of hours ago, containing the bootctl fix: https://github.com/systemd/systemd-stable/releases

This unfortunately also includes https://github.com/systemd/systemd-stable/commit/d0f0f048ec86be122d9fa41ad50a15d97e629bbe, and I'm not sure if there's any fallout - see https://github.com/systemd/systemd/pull/17009#issuecomment-691659488.
I'd prefer to tackle 246.5 as a follow-up, and merge this in first.

This would also need the be picked into staging-20.09, but I won't get to it in the next hours.

Why should this go to 20.09 as well?  I've missed that part so far.

246 is in 20.09, and these maintenance releases contain bugfixes and potentially security fixes. It's not blocking the release, but we should keep, and did so far provide these point releases too.

After successfully running nixosTests.systemd, I pushed the 246.4 bump to staging-20.09 as a1abac1f1fcfca18b9d49d7549388745fd089f95.

I opened a PR to disable tests for bash-completion at https://github.com/NixOS/nixpkgs/pull/97987.

Regarding 246.5: Turns out https://github.com/systemd/systemd/pull/17009/commits/6e65df89c348242dbd10036abc7dd5e8181cf733 was /not/ backported, which means 246.4 -> 246.5 should be simple.
I'll file a PR shortly.

246.5 PR is at https://github.com/NixOS/nixpkgs/pull/97989.

@vcunat I'm in favor of porting this to 20.09 since systemd-246` has a bug where my network doesn't get up again after a suspend (https://github.com/systemd/systemd/issues/16696).
Didn't read the full release-notes yet, but there are probably more things fixed :)


Generate a funny loading message

Generates a funny loading message from a random seed. Not sure if this is useful, just a fun experiment.
Unable to do a test due to expect(result).toStrictEqual(expectedResult); because funnies.message() generates a random (unstable) message every time.
e.g. .withTest({seed: "Glide"}, funnies.message()) gives the following error. Not sure if there is another way to do this or if it's even important.
Funny Loading Message { seed: "Glide" } = "(Insert quarter)"

    expect(received).toStrictEqual(expected) // deep equality

    Expected: "(Insert quarter)"
    Received: "If you type Google into Google you can break the internet"

      23 |             );
      24 |             const result = await definition.run(...params);
    > 25 |             expect(result).toStrictEqual(expectedResult);
         |                            ^
      26 |         });
      27 |     }
      28 | });

      at src/columns.test.ts:25:28
      at fulfilled (src/columns.test.ts:5:58)

Use withFailingTest to allow the test to fail.


New Account Page

@COP4331C-Project-Group/front-end

This will be the same page as login, we'll use javascript to determine whether to show the register or login prompt.


Azure App Service not listed in Azure  Chaos Studio Targets

Azure App Service not listed in Azure  Chaos Studio Targets
I am not seeing Azure App Service listed as Azure  Chaos Studio Targets

I have registered Chaos Studio resource provider for the subscriptions
The app service is hosted in "Central US" region; region that's supported by Chaos Studio Targets
App service (windows) is running and in P1V3 Sku

Are you able to help

@TharinduK
Since we have not heard back from you, we will now proceed to close this thread.
If there are further questions regarding this matter, please tag me in your reply. We will gladly continue the discussion and we will reopen the issue.


Support thebelab's predefined output

One of the important use cases for incorporating thebelab into a project is to allow tweaking already existing outputs. Out of the box, IIUC the already computed outputs would be duplicated by whatever thebelab produces.
At the same time, thebelab supports specifying predefined arguments, which are made into cell outputs as soon as thebelab is activated, see the required config here.
This would require modifying thebelab configuration, as well as ensuring that DOM is appropriate (the outputs must be in a div that directly follows the input).

What should happen is that when the thebelab button is clicked, all of the outputs get removed first. Does that not happen?

That does happen, but jupyter-book could instead keep the existing outputs and make them recognized by thebelab. That makes for a better user experience, since content doesn't just disappear from clicking a button. Not sure what is the best example out there in the wild, but check e.g. here (click the "magic wand" icon for thebelab).

Ah I see - yeah that makes sense, I wonder if we could just do some re-arranging with the DOM when the button is clicked before running thebelab (that's basically what we do now). For some reason (at least for me), I find that much simpler than adding complexity to the doctree nodes of the page

I think the DOM should be mostly good as it is, thebelab doesn't require anything exotic. But otherwise indeed rearranging it on init makes most sense.

I believe this is now fixed within sphinx-thebe 👍


[feat/aut169] Add getID, getName and getDescription to SequenceProcessor

✅ Add IProcessorDescription interface,
✅ Implement IProcessorDescription interface in SequenceProcessor classes,
✅ Add unit tests for relevant SequenceProcessor's getters.
📌 Disclaimer:

Assigned IDs are now set to -1, this probably needs an update,
Descriptions might be not descriptive enough - I copied class docs to the string,
Since I created IProcessorDescription interface, I can also update other Processor classes with this interface (out of the scope of this ticket)
Maybe location of IProcessorDescription can be under new directory interface or iface:

Yes, would be nice to use this interface for other processors. I'm not sure it's so out of scope of the ticket. since you introduce an interface, it may impact other class. is it lot of work? i feel if it's very easy you could go ahead. if not create a story once it is merged.

Yes, would be nice to use this interface for other processors. I'm not sure it's so out of scope of the ticket. since you introduce an interface, it may impact other class. is it lot of work? i feel if it's very easy you could go ahead. if not create a story once it is merged.

Should not be much work to add IProcessorDescription interface to another Processor classes.
I am not sure however what you mean by moving all interface to one directory - at least if it comes to processor classes, I can see plenty of abstract classes, but not many classes that have only pure virtual functions. Moreover, these classes have very close process() function signatures, but still different. I think such work of defining interfaces for these classes would be, as you mentioned, another task, refactoring of code base

Should not be much work to add IProcessorDescription interface to another Processor classes.
I am not sure however what you mean by moving all interface to one directory - at least if it comes to processor classes, I can see plenty of abstract classes, but not many classes that have only pure virtual functions. Moreover, these classes have very close process() function signatures, but still different. I think such work of defining interfaces for these classes would be, as you mentioned, another task, refactoring of code base

I haven't check if there are other interfaces - sorry. If there is no other interface, you can go create the iface directory and put yours inside. I just would like (it's my point of view) not to have some interfaces in one directory, other (if they exist) in another.

I haven't check if there are other interfaces - sorry. If there is no other interface, you can go create the iface directory and put yours inside. I just would like (it's my point of view) not to have some interfaces in one directory, other (if they exist) in another.


the trait std::clone::Clone is not implemented for [i8; 100]

I am using this script https://gist.github.com/fitzgen/187381e358f60efa8194d0b276b4d11a.
I am using bindgen version 0.32.1 with hashtag 04591f01d96 .
$ ./b.sh bindgen abc.h
clang-4.0: warning: treating 'c' input as 'c++' when in C++ mode, this behavior is deprecated [-Wdeprecated]
Error { repr: Custom(Custom { kind: Other, error: StringError("Cannot find binary path") }) }
error[E0277]: the trait bound `[i8; 100]: std::clone::Clone` is not satisfied
 --> /tmp/bindings-efx3Xl.rs:3:182
  |
3 | # [ repr ( C ) ] # [ derive ( Copy , Clone ) ] pub struct a { pub __bindgen_anon_1 : a__bindgen_ty_1 , } # [ repr ( C ) ] # [ derive ( Copy , Clone ) ] pub struct a__bindgen_ty_1 { pub b : [ :: std :: os :: raw :: c_char ; 100usize ] , } # [ test ] fn bindgen_test_layout_a__bindgen_ty_1 ( ) { assert_eq ! ( :: std :: mem :: size_of :: < a__bindgen_ty_1 > ( ) , 100usize , concat ! ( "Size of: " , stringify ! ( a__bindgen_ty_1 ) ) ) ; assert_eq ! ( :: std :: mem :: align_of :: < a__bindgen_ty_1 > ( ) , 1usize , concat ! ( "Alignment of " , stringify ! ( a__bindgen_ty_1 ) ) ) ; assert_eq ! ( unsafe { & ( * ( :: std :: ptr :: null :: < a__bindgen_ty_1 > ( ) ) ) . b as * const _ as usize } , 0usize , concat ! ( "Offset of field: " , stringify ! ( a__bindgen_ty_1 ) , "::" , stringify ! ( b ) ) ) ; } # [ test ] fn bindgen_test_layout_a ( ) { assert_eq ! ( :: std :: mem :: size_of :: < a > ( ) , 100usize , concat ! ( "Size of: " , stringify ! ( a ) ) ) ; assert_eq ! ( :: std :: mem :: align_of :: < a > ( ) , 1usize , concat ! ( "Alignment of " , stringify ! ( a ) ) ) ; }
  |                                                                                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the trait `std::clone::Clone` is not implemented for `[i8; 100]`
  |
  = help: the following implementations were found:
            <[T; 24] as std::clone::Clone>
            <[T; 6] as std::clone::Clone>
            <[T; 16] as std::clone::Clone>
            <[T; 0] as std::clone::Clone>
          and 29 others
  = note: required by `std::clone::AssertParamIsClone`

error: aborting due to previous error

Interesting: bindgen emitted Rust code that won't compile!

$ cat abc.h
struct a {
  struct {
    char b[100];
  };
};

Which version of rustc are you using? That code compiles for me.

It's
rustc 1.20.0 (f3d6973f4 2017-08-27)

Yup, per the previous commit this report is invalid. Running bindgen with --rust-target 1.0 should make it build even in that rustc version.
Thanks @dimbleby!


Enable and disable config for multiple messages concatenation.

#27 is a bit related but in my use case I would like to disable the default concatenation when I pass multiple messages to the log functions. This is because I don't want my main log message to be cluttered with stringified stuff and I would like to handle my other passed messages in a custom way already.
I can still access additional objects via the rawMsg prop but my main message is still cluttered with the stringified version of it. It would be great to have this things as optional via the config.
Regards.

I can't understand why rawMsg is not sufficient, can you give me an example of your use case?

I don't fully remember everything as it's been exactly one year but I think the problem was related to taking complete control over how the final message that gets sent to the logs is formatted. This will allow developers to have one central logger interface. This interface/class will have let's say a log method that accepts an object aka rawMsg and based on what values inside the raw message have been defined, the developer would format the message before sending it off.
The problem I am sure was that while you can define a rawMsg but then you have to accept whatever format this package comes up with using the contents of the rawMsg.

Okay I get it, basically you would like to have both the ability to use rawMsg and the ability to disable message formatting to use both systems together. This change is not related to transports so it would probably involve several breaking changes, for now I have added the ability to set in configuration a custom function for message stringify, we will evaluate other changes in the future. Thanks and sorry for delay;)

Thanks for the update. Yeah, that was pretty much it. For e.g. Some developers might want to format the timestamp that's concatenated to the log message differently. Some developers might want to change the position of the timestamp (which if I remember correctly always appears at the beginning). So in summary, the formatting of the log message should have a default that's not enforced otherwise.


docs: Merge manuals

Note: This is a large PR and the easiest way to review it will be via the preview: https://deploy-preview-8087--devel-docs-dagger-io.netlify.app/api/

Help currently needed with the following (specific positions are marked with FIXME in each file below):

[ ] One page overview of Dagger Engine: docs/current_docs/manual/engine/index.mdx
[ ] Decision on documenting alternative methods of calling Dagger API: SDK, HTTP client, shell query, core fn: docs/current_docs/manual/api/requests.mdx
[ ] Decision on whether to document additional types: docs/current_docs/manual/api/types.mdx
[ ] Raw API query examples for Secret and Service types:  docs/current_docs/manual/api/types.mdx
[ ] Top-level component diagram improvement: docs/current_docs/manual/components.mdx
[ ] Function sample code for Container argument: docs/current_docs/manual/functions/arguments.mdx

After the 8/6 meeting, here are the updates to @vikram-dagger 's list above.
To-do from the rest of the team:

[ ]  Review of screenshots for Dagger Cloud and Dagger TUI - @crjm can you please review and update screenshots as you see fit?
[ ]  One page overview of Dagger Engine: docs/current_docs/manual/engine/index.mdx  - @sipsma @aluzzardi or @jedevc can you provide 2-3 paragraphs for this engine page?

Will cover in followup meeting with @shykes :

[ ]  Decide on documenting alternative methods of calling Dagger API: SDK, HTTP client, shell query, core fn: docs/current_docs/manual/api/requests.mdx
[ ]  Decide whether to document additional types: docs/current_docs/manual/api/types.mdx
[ ]  Raw API query examples for Secret and Service types: docs/current_docs/manual/api/types.mdx
[ ]  Top-level component diagram improvement: docs/current_docs/manual/components.mdx
[ ]  Function with Container argument example: docs/current_docs/manual/functions/arguments.mdx

@vikram-dagger to remove these pages/content:

[ ]  Decide whether to document Runs and Changes UI in Dagger Cloud: docs/current_docs/manual/cloud/runs.mdx
[ ]  Decide whether to retain Known Issues page: docs/current_docs/manual/known-issues.mdx

I would remove this image as the instructions are self-descriptive, and it's badly rendered.

Also, in the Traces section of the docs, I would segregate between CI and Local traces, because they are different views in the UI, and each requires some kind of context.
For example, a few questions that might come up to a user are:

Why am I seeing dagger functions in the local trace list
What makes my traces appear in the CI view, and what makes my traces appear in the local view?
What are orphaned traces?
What is the "focused view" of a group (when clicking a group in the CI view)?

Some of these questions also require some screenshots, so let me know if we want to answer them in this PR.

I would remove this image as the UI is self-descriptive on par with the documentation. If we choose to keep it, we should improve the quality of the image.

Removed

Summary of discussion with @shykes today:

The current component-based structure in this PR does not work. We should document a unified "Dagger" experience, not a per-component experience. Also, there are overlaps between components e.g. chaining is discussed separately in CLI and Functions sections when it could be combined. Similarly, TUI and Traces should be considered as part of a single visualization experience.
The component diagram is close but not perfect. It's probably not possible to make a single diagram that explains Dagger at a high-level due to multiple dimensions involved. Instead we should write the story we want to tell and then illustrate it.
We should make the Dagger API the centrepiece of the docs and frame the content around that. This also includes documenting the different approaches to calling the API, including implementation limitations or issues.
We should remove the Manual section and have a top-level Features section, which documents "big" Dagger features in one place e.g. caching, secrets, services, visualization, artifacts, etc. Then reorganize existing content under each of those topics. Some content may not fit, we can decide how to handle these later.
There is no clear boundary between Dagger Engine and Dagger CLI, they may even become the same thing in future. We are dropping the component approach in any case. For the current Dagger Engine content, we should move it to a Configuring Dagger section.

Next steps:

Create a new structure that reflects the above for discussion and iteration

@shykes please feel free to add comments in case I missed or misunderstood anything.

@jedevc @TomChv can you please have a look at the sdk python lint error, which seems like it could be a false positive to me? I'm not very sure how to fix it, will appreciate any suggestions!

@vikram-dagger some notes from the live review:
Features section
That section works well overall.

"Programmable builds": this one felt "fuzzy" in both title and content, there's a question mark on what to call this, and what it should actually be about.

"language interoperability": it felt like this should be about a cross-language component system - so the modules etc. So this is more of a scope expansion. What the exact title should be is unclear.

The other sections are clearly scoped and work well. We agreed to dispatch review of those pages as individual  tasks.

Feedback from live review on 11/9:

We couldn't review all the pages, we only managed 3
Features:

"Programmable Builds" title will change to "Programmable Pipelines"

"Language Interop" title will change to "Reusable Modules" and move to second position in the features sub-tree

"Language Interop" content to be refocused on modules

Dagger API:

"Calling the API" list to be restructured

"Dagger Functions" section to have more content on modules, core functions vs custom functions, how to call, etc

Debate ongoing about "calling" vs "extended" sections split, no decision yet

@helderco can you please suggest a fix for this lint error? https://github.com/dagger/dagger/actions/runs/10909340273/job/30277341371?pr=8087

@helderco can you please suggest a fix for this lint error? https://github.com/dagger/dagger/actions/runs/10909340273/job/30277341371?pr=8087

Pushed a fix.

@helderco can't quite figure out what the linter needs here, the file has been reformatted with black already:  https://github.com/dagger/dagger/actions/runs/11077326317/job/30782329525?pr=8087

@helderco can't quite figure out what the linter needs here, the file has been checked with ruff and black already: https://github.com/dagger/dagger/actions/runs/11077326317/job/30782329525?pr=8087

black should no longer be used. It's just ruff now.

(Python) module description should be first line

There should be a blank line between anyio and dagger because they're different groups (third-party vs own package). I.e., our linter considers dagger to be a "first-party" package:
https://github.com/dagger/dagger/blob/f4f41af8527786deed8c90a8c010594dfbc939b6/sdk/python/ruff.toml#L97-L98

I pushed a fix.

The following changes have been made based on the 7/10 call and after further (solo) review. These may need revisiting.

Pages under "Custom Types" category moved into "Custom Functions" section
"Dagger Modules" category renamed to "Working with Modules" - this could perhaps go up one level
"Dependencies" page under "Dagger Modules" category moved into "Custom Functions" section
"Entrypoint Function" renamed to "Constructors"
"State as Functions" renamed to "State" (we previously decided "Fields" but after reviewing various other doc sites, "State" and "Getters" seem more commonly used)

Redirects have been added in https://github.com/dagger/dagger/pull/8087/commits/9c6e3d41c016a15de11915754dd2d3310a083304


Health endpoint for load balancing

Reference new /health?ready=1 endpoint in cloud deployment tutorials.
Update HAProxy docs to cover health checks (1.1 and 2.0).

Fixes #2594

This change is

http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/664638b6c0e4562e97d8c16a93aff37cf983ca5a/

http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/b68f6c95d8b51322b9765a4d9458e6748d625d56/

Reviewed 8 of 8 files at r1, 6 of 6 files at r2.
Review status: :shipit: all files reviewed at latest revision, all discussions resolved, all commit checks successful.

v2.0/deploy-cockroachdb-on-aws.md, line 94 at r1 (raw file):

1. [Add AWS load balancing](http://docs.aws.amazon.com/AWSEC2/latest/UserGuide/ec2-increase-availability.html). Be sure to:
    - Set forwarding rules to route TCP traffic from the load balancer's port **26257** to port **26257** on the nodes.
    - Configure health checks to use HTTP port **8080** and `/health?ready=1`. This [health endpoint](monitoring-and-alerting.html#health-ready-1) ensures that load balancers don't direct traffic to nodes that are live but not ready to receive requests.

Any reason why you removed the word "path" from all but one of these files? It reads more clearly to me with it left in.

v2.0/deploy-cockroachdb-on-premises.md, line 89 at r2 (raw file):

        balance roundrobin
        option httpchk GET /health?ready=1
        server cockroach1 <node1 address>:26257

For all the v2.0 files, this should be
        server cockroach1 <node1 address>:26257 check port 8080

And ditto for the two lines below. You may then want to add info to the table below about the "check port" keywords as well

v2.0/generate-cockroachdb-resources.md, line 248 at r2 (raw file):

</div>

By default, the generated configuration file is called `haproxy.cfg` and looks as follows, with the `server` addresses pre-populated correctly:

Without this intro text, given the way it's presented a user might expect the cockroach gen haproxy command to print this output, when in reality the command outputs nothing. This is what you'd see in the haproxy.cfg file after running the command.

Comments from Reviewable

http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/878fd4bea3b3e729e01175b8695086b405f6af57/

v2.0/deploy-cockroachdb-on-aws.md, line 94 at r1 (raw file):
Previously, a-robinson (Alex Robinson) wrote…
Any reason why you removed the word "path" from all but one of these files? It reads more clearly to me with it left in.

Mistake. Fixed.

Comments from Reviewable

http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/9604500da662afa559a458c1dc31884c6f0ff4a0/

Reviewed 3 of 3 files at r3, 9 of 16 files at r4, 6 of 6 files at r5, 3 of 3 files at r6.
Review status: all files reviewed at latest revision, 2 unresolved discussions, all commit checks successful.

v1.1/recommended-production-settings.md, line 77 at r3 (raw file):

## Load Balancing

Each CockroachDB node is an equally suitable SQL gateway to a cluster, but to ensure client performance and reliability, it's important to use TCP load balancing:

nit: it isn't really important that the load balancing is TCP load balancing. Application-aware (L7) load balancing would be fine too, so I'd just say "it's important to use load balancing".

v1.1/recommended-production-settings.md, line 81 at r3 (raw file):

- **Performance:** Load balancers spread client traffic across nodes. This prevents any one node from being overwhelmed by requests and improves overall cluster performance (queries per second).

- **Reliability:** Load balancers decouple client health from the health of a single CockroachDB node. To ensure that traffic is not directed to failed nodes or nodes that are not ready to receive requests, load balancers should use [CockroachDB's health check](monitoring-and-alerting.html#health).

In v1.1 our health check isn't all that useful to a load balancer. Our gen haproxy config just uses whether it's able to connect to a node's serving port as the signal of whether it's healthy.
If it doesn't make the wording here too weird, I'd just leave out the recommendation to use the health endpoint in the v1.1 docs.

v2.0/recommended-production-settings.md, line 76 at r3 (raw file):

## Load Balancing

Each CockroachDB node is an equally suitable SQL gateway to a cluster, but to ensure client performance and reliability, it's important to use TCP load balancing:

nit: it isn't really important that the load balancing is TCP load balancing. Application-aware (L7) load balancing would be fine too, so I'd just say "it's important to use load balancing".

Comments from Reviewable

Review status: 2 of 35 files reviewed at latest revision, 5 unresolved discussions.

v1.1/recommended-production-settings.md, line 81 at r3 (raw file):
Previously, a-robinson (Alex Robinson) wrote…
In v1.1 our health check isn't all that useful to a load balancer. Our gen haproxy config just uses whether it's able to connect to a node's serving port as the signal of whether it's healthy.
If it doesn't make the wording here too weird, I'd just leave out the recommendation to use the health endpoint in the v1.1 docs.

Np, I'll just revert to what we had before.

v2.0/generate-cockroachdb-resources.md, line 248 at r2 (raw file):
Previously, a-robinson (Alex Robinson) wrote…
Without this intro text, given the way it's presented a user might expect the cockroach gen haproxy command to print this output, when in reality the command outputs nothing. This is what you'd see in the haproxy.cfg file after running the command.

That was a mistake. Thanks for catching it.

Comments from Reviewable

http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/a021a39c8c1ca67d24e51b6fba792638e4e104e1/

Review status: 2 of 35 files reviewed at latest revision, 5 unresolved discussions, all commit checks successful.

v1.1/recommended-production-settings.md, line 77 at r3 (raw file):
Previously, a-robinson (Alex Robinson) wrote…
nit: it isn't really important that the load balancing is TCP load balancing. Application-aware (L7) load balancing would be fine too, so I'd just say "it's important to use load balancing".

Done.

v2.0/deploy-cockroachdb-on-premises.md, line 89 at r2 (raw file):
Previously, a-robinson (Alex Robinson) wrote…
For all the v2.0 files, this should be
        server cockroach1 <node1 address>:26257 check port 8080

And ditto for the two lines below. You may then want to add info to the table below about the "check port" keywords as well

Done.

v2.0/recommended-production-settings.md, line 76 at r3 (raw file):
Previously, a-robinson (Alex Robinson) wrote…
nit: it isn't really important that the load balancing is TCP load balancing. Application-aware (L7) load balancing would be fine too, so I'd just say "it's important to use load balancing".

Done.

Comments from Reviewable

Great changes!

Reviewed 33 of 33 files at r7.
Review status: all files reviewed at latest revision, 1 unresolved discussion, all commit checks successful.

v1.1/recommended-production-settings.md, line 77 at r3 (raw file):
Previously, jseldess (Jesse Seldess) wrote…
Done.

I didn't realize this would involve changing so many files. Thanks for tracking them all down!

Comments from Reviewable

TFTR, @a-robinson. I also added a link from rolling upgrade to load balancing, and I reorganized the sidenav a bit to put monitoring content together under deployment.

http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/5a56b9c6b944024102037c3b219dfc6a91616ecd/

http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/e9acac1f71ff189e83a91881778174769e95aff9/


throw new WebpackOptionsValidationError(webpackOptionsValidationErrors);

Version
2.4.0
Reproduction link
https://jsfiddle.net/chrisvfritz/50wL7mdz/
Steps to reproduce
npm run dev, the error happens
What is expected?
npm run dev without error
What is actually happening?
npm run dev, the error happens

The error in server.js at "app.use(webpackDevMiddleware(webpack(WebpackConfig), {".
It seems the webpack can't do webpack() function. And if I use<EMAIL_ADDRESS>it will not has this error. But it will have another error...it can't handle the .vue files
Details:
WebpackOptionsValidationError: Invalid configuration object. Webpack has been initialised using a configuration object that does not match the API schema.

configuration.entry should be one of these:
object { : non-empty string | [non-empty string] } | non-empty string | [non-empty string] | function
The entry point(s) of the compilation.
Details:

configuration.entry should NOT have less than 1 properties ({
"keyword": "minProperties",
"dataPath": ".entry",
"schemaPath": "#/oneOf/0/minProperties",
"params": {
"limit": 1
},
"message": "should NOT have less than 1 properties",
"schema": 1,
"parentSchema": {
"minProperties": 1,
"additionalProperties": {
"oneOf": [
{
"description": "The string is resolved to a module which is loaded upon startup.",
"minLength": 1,
"type": "string"
},
{
"description": "All modules are loaded upon startup. The last one is exported.",
"$ref": "#/definitions/common.nonEmptyArrayOfUniqueStringValues"
}
]
},
"description": "Multiple entry bundles are created. The key is the chunk name. The value can be a string or an array.",
"type": "object"
},
"data": {}
}).
object { : non-empty string | [non-empty string] }
Multiple entry bundles are created. The key is the chunk name. The value can be a string or an array.
configuration.entry should be a string.
configuration.entry should be an array:
[non-empty string]
configuration.entry should be an instance of function
function returning an entry object or a promise..
at webpack

This is completely unrelated to vue-router and your repro link is invalid.

yeah, it seems something wrong with webpack. I'm just curious that how could your vue-router don't get the error. I got this error when I used your package.json, server.js and webpack.config.js in an empty project. (same directory with you)
Sorry, I don't know how to show you in the repro link.

@zhuyuanwen You should ask questions on the forum or StackOverflow. Github issues are for bug reports and feature requests only 🙂

OK. Thanks.


Feature request: allow copying networks

Long touching network seems to have Edit and Remove options. It would be nicei f there was also copy or clone as the only thing changing with ZNC networks is the network name in username.

Will be available in the upcoming version 0.9


chore(main): release 0.8.1

:robot: I have created a release beep boop
0.8.1 (2022-10-06)
Bug Fixes

Search: Limit the quicksearch results to 10 entries (941338c)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/BLSQ/openhexa-frontend/releases/tag/0.8.1 :sunflower:


added a few og meta tags and also organized/added folders

Description

Trello URL for the card that this PR attempts to solve
Added dependencies/external libraries:
Type of change

[ ] Bug fix (non-breaking change which fixes an issue)
[x ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update
[ ] Removes code or a feature that is either outdated or has been deemed unnecessary

How Has This Been Tested?

Just added some og meta tags

Checklist:

[ x ] I have the latest code from staging branch
[x  ] I have performed a self-review of my own code
[ x ] I have commented my code, particularly in hard-to-understand areas
[ x ] I have made corresponding changes to the documentation (you can mark this in case documentation is not relevant)
[ x ] My changes generate no new warnings

I moved components and pages in the src file - The imports should have been updated but it's possible some may need to be done manually - sorry for the trouble

LGTM  Thanks for doing it


feat: define Flat index as a scan over VectorStorage

Stack from ghstack (oldest at bottom):

-> #2380
#2378
#2377
#2376

Codecov Report
Attention: Patch coverage is 0% with 48 lines in your changes are missing coverage. Please review.

Please upload report for BASE (gh/chebbyChefNEQ/5/base@893ed4c). Learn more about missing BASE report.

Files
Patch %
Lines

rust/lance-index/src/vector/v3/subindex.rs
0.00%
48 Missing :warning:

Additional details and impacted files
@@                    Coverage Diff                     @@
##             gh/chebbyChefNEQ/5/base    #2380   +/-   ##
==========================================================
  Coverage                           ?   79.96%
==========================================================
  Files                              ?      200
  Lines                              ?    54526
  Branches                           ?    54526
==========================================================
  Hits                               ?    43599
  Misses                             ?     8407
  Partials                           ?     2520

Flag
Coverage Δ

unittests
79.96% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


$.ajax can't POST uri encoded data

The code uses encodeURIComponent on the passed data as a single entity, whatever it is passed. This means that form data gets all the = and & characters encoded out. As far as I can tell, $.post isn't affected by this, but it's API isn't as powerful or flexible.
In an ideal world, an object would be encoded properly, but I could live without any encoding. My 2 second reading of the jQuery docs are that a string passed to $.ajax is not encoded, only objects are. I can provide a PR if it'll help.

Sure, I'd like to see what your trying to do so I can set up a test case on my end to fix this.

The relevant fragment of code is (CS syntax) below. What actually gets posted is: username%3Dtest%26password%3Dpass. Basically, the = and & in my query string get put into encodeURIComponent again, and therefore never get sent to the server. In effect, $.ajax can't POST regular application/x-www-form-urlencoded form data.
The jQuery docs for $.ajax describe the data parameter as:

Data to be sent to the server. It is converted to a query string, if not already a string.

So my reading is that if data is a string, it can be passed transparently. Being a subset, you don't need to support objects, but if you do, you can assemble a query string by encodeURIComponent on values alone.
  queryString = "username=" + encodeURIComponent(username) + "&password=" + encodeURIComponent(password)

  $.ajax({
    url : "http://localhost:3001/api/data"
    type: "POST"
    headers: {
      "Content-Type" : "application/x-www-form-urlencoded"
    }
    data: queryString
    success: (data) ->
      console.log "Success", data
    error: (data) ->
      console.log "Error", data
  })

The short version is the following lines in $.ajax can be likely deleted and then it'll behave like a subset of jQuery:
      if (options.data) {
        options.data = encodeURIComponent(options.data);
      }

Oh weird. Now I see there are two different implementations in the src folder, in ajax.js and xhr.js. The ajax.js version doesn't do this, but the dist (which is using xhr.js, seemingly) does. There are bunch of other differences which I don't really want to go through now.
This explains why $.post isn't available either. I've tried $.ajax.post which does exist, but doesn't seem to POST.
It looks to me like the promises logic somehow broke xhr.js, so that basic GET requests using $.ajax are probably okay but everything else is out of whack.
Hope that helps, as before, I can provide a PR if needed.

So, they're are slightly different versions depending on whether you build ChocolateChipJS with support for the older jQuery style Deferred object or the newer ECMAScript 6 Promises spec. By default it builds with support for Promises, which incorporates the xhr file. Otherwise, using the flag gulp --deferredSupport true it builds with jQuery-style Deferred object support that incorporates ajax.js. The main difference between these is that xhr returns Promises and expects Promise specific functionality. And the build with Deferred support implements Ajax with jQuery style deferred usage.
I hope that's clear.
I'm setting up an Ajax test server so I can run a bunch of tests to sort this out so bear with me.

By the way, which version are you using?

I've been using the 8.9.10 tag, which seems the most recent available from bower, because 8.9.11 isn't tagged. It's the dist bundled code, which includes Promises.
I'll switch to jQuery or raw XHR  for now so I can complete my development, and then maybe switch back. That'll get you off my critical path.

Thanks, I'm just winding down from a complete rewrite of it in TypeScript, which was a job, but caught lots of niggly things that even unit tests never caught. Looks like I need to add a serialize method to match what jQuery does.

Well, we decided to do something radical. We dumped the Ajax module totally and replaced it with the Fetch API from WHATWG. It's simpler and cleaner. There's a $.serialize method to properly serialize form content. And lots of examples of GET, POST, PUT and DELETE using PHP controllers. Look in the fetch folder. Of course, you need to run this in a PHP server instance. Also check out the updated docuemntation on the site under Fetch.

Great plan, sounds perfect.

Download latest and take a look. Seems to be working for my PHP tests. You can find out more about fetch:
https://jakearchibald.com/2015/thats-so-fetch/
https://developer.mozilla.org/en-US/docs/Web/API/Fetch_API
One thing, the spec is dependent on a number of streaming buffers being available. Unfortunately these are not available if your target is Android (Native Android Browser) or iOS.
I've deviated from the speck by adding in the ability to timeout a request. Not sure why they couldn't figure that out yet. If they come up if a means of canceling promise/requests, I'll look into updating our fetch API to match it.


[6.5.x] RHBRMS-2730, RHBRMS-2729

@manstis, the only difference than that you showed me is adding the full stack trace also to logger.debug. Even adding the exception message to:
        final String msg = MessageFormat.format( ERROR_EXTERNAL_CLASS_VERIFICATION,
                                         toFQCN( packageName, className ),
                                         e.getMessage() );

... sometimes it is still not clear. In that jira even fixing the message it will show only "Underlying system error is Lme/lazarotti/SaySomething;" - however if added the stacktrace we will see in the stack:
"Caused by: java.lang.ClassNotFoundException: me.lazarotti.SaySomething"
That's why I also added it.

As I did different commits while creating the test, instead if rebasing this PR i create the one:
https://github.com/droolsjbpm/kie-wb-common/pull/635


[Address book page] App crashes when tap 'Add new Address'

Environment: iOS 14.1, iPhone 11 Pro Max (appetize.io emulator)
Reproducible: always
Build found: build 1.0.80
Preconditions

Open 'My profile' homepage
Tap 'Address book'

Steps to reproduce

Tap 'Add new Address'

Actual result
App closes
Expected result
'Add Address' page should be opened
User story and test case links
User story #31

Maps on IOS not implemented yet


Donation link

This app is honestly one of the most helpful and reliable things I use, you should definitely add a donation link to the project, would be happy to throw you a few bucks

Yes! 😮


enum format

Example: https://github.com/octokit/routes/blob/fe0a25467e167c54628c2072884911a50c93269a/routes/pulls/list-pull-requests.json#L21-L26
In octokit/rest.js/lib/routes.json, we currently do
          "type": "string",
          "enum": [
            "merge",
            "squash",
            "rebase"
          ],

I think the latter format is better, because it tells the type of the value, the enum is just an addition. I’ve no opinion on wether to call the array key enum or options
Any thoughts @philschatz?

Maybe while talking about "type", I do prefer e.g. "string[]" over "array". In comparison to octokit/rest.js/lib/routes.json we also do "type": "object" instead of "type": "json" which I think is fine.

here is an issue/PR with a failing test to work on this: https://github.com/octokit/routes/issues/62

type: "string", enum: [...] seems fine to me. Having type:"enum", options: [...] does not really save anything and it is nice to record that the field is actually a string.
The only downsides of using type: "string[]" (rather than a field like isArray: true) that I can think of are:

the string will need to be parsed in order to determine whether the return type is an Array
more complex return types like Repository[] may be difficult to describe

To the 2nd concern: if a JSON Schema is provided for the return type, I am not sure how it would be described in this file. I can try creating a Swagger JSON (#55) of the routes to see if it is a problem.

Okay so let’s move forward with at least the change of type: "enum" to type: "string".
The current v3 documentation does only have two types of arrays for parameters, string[] and number[], maybe that’s simple enough? I’m okay with isArray: true, we’d need to adapt the PR here accordingly: https://github.com/octokit/routes/pull/77. Maybe let’s continue discussion about array types there, as it’s out of the original scope of this issue?


fix: removed unnecessary stripe call from boot sequence

Pre-Submission Checklist

[x] Your pull request targets the staging branch of freeCodeCamp.
[x] Branch starts with either fix/, feature/, or translate/ (e.g. fix/signin-issue)
[x] You have only one commit (if not, squash them into one commit).
[x] All new and existing tests pass the command npm test. Use git commit --amend to amend any fixes.

Type of Change

[x] Small bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds new functionality)
[ ] Breaking change (fix or feature that would change existing functionality)
[ ] Add new translation (feature adding new translations)

Checklist:

[ ] Tested changes locally.
[x] Addressed currently open issue (replace XXXXX with an issue no in next line)

Closes #17510
Description

Hey @Bouncey, I updated the PR with the changes you mentioned.  I did make the connectToStripe function return a promise but it's setup so that the "done" function will be called before there is a response from the Stripe API, but after the requests were made. I hope that's what you expected, if not just let me know.
Also, still haven't been able to test the /external/donate/charge-stripe API. I did try testing it with Postman but I was a bit confused on what parameters should be passed and also I think I need to be logged in to get a valid JWT.

Hrm, seems like the build is running into some linting error.
Locally I ran npm run test, npm run lint and npm run lint-js none of which produced any errors.
Any suggestions?

Yikes, had to update one more time because I forgot to name the export function. O_O'
@Bouncey These changes are done though. Looks like there's still some issues with the build but all tests are passing locally.

@cmoss3 the linking error will be fixed once #17609 is merged. It is caused due to wrong location of eslint when the command gets executed.


Support readonly fields

Note that this issue is talking about readonly fields, not properties. That is, fields that are decalred as readonly or generated from read only auto properties. They have the "initonly" flag set in CLR metadata.
The issues:

The expression compiler won't compile an Assign expression to a field with "initonly" flag set. Exception is: " Expression must be writeable". So normal mechanism for compiling a delegate to set the field doesn't work.
If you get around that, for example by creating the expression tree with the AssignBinaryExpression directly (using Reflection since this is internal), you then get an exception from the expression compiler: "VerificationException: Operation could destabilize the runtime."

The only way to set the field that works is using Reflection with FieldInfo.SetValue. We can compile this method call into the expression tree (only doing so if "initonly" flag is set). Since the FieldInfo is cached performance is not horrendous, but it is a lot worse than just compiling an assign--approximately 100 times slower.
So the question is should we use Reflection for this, or should we throw saying not to use readonly fields or read only auto-properties?
Keep in mind that we will support these types of fields in some scenarios when we support materialization through parameterized constructors. This would be ideal for normal materialization, but it won't support things like key propagation or fixup.

We'll throw for the moment and can always support it later.


Remove lighter font weights on new dashboard

Fixes #2335
This is how things would look on Chrome:

@carlostallon @xavijam @saleiva as instructed in the issue I've removed the lighter fonts. I'd suggest we do a deploy on staging (none available yet) to really check if this solves it. Thoughts?

Frontend tests were OK :+1: (details)

It is a pity we have to "remove" it, but if some browsers don't render properly, this is the best solution.

bump, any feedback on this please?

Frontend tests were OK :+1: (details)

Frontend tests were OK :+1: (details)

Frontend tests were OK :+1: (details)

Not the same, but... let's go with it :)

If we remove the lighter fonts, may be we could try use this property of css
text-rendering: optimizeLegibility;

Frontend tests were OK :+1: (details)

Frontend tests were OK :+1: (details)

Frontend tests were OK :+1: (details)

@saleiva @piensaenpixel @xavijam changes based on feedback, see PR desc for screenshots. also deployed on staging (ded02) if you want to have a look yourself cc @Kartones

Frontend tests were OK :+1: (details)

Frontend tests were OK :+1: (details)

Screenshot from kartones with the new changes:

OK?

:jp:

Frontend tests were OK :+1: (details)

Frontend tests were OK :+1: (details)


Tiktoken says ChatGPT's API, gpt-3.5-turbo, uses the cl100k_base encoder, but it appears to use p50k_base in openai

Describe the bug
Tiktoken (https://github.com/openai/tiktoken/blob/3e8620030c68d2fd6d4ec6d38426e7a1983661f5/tiktoken/model.py#L14) shows ChatGPT's API, gpt-3.5-turbo, tiktoken encoder to be cl100k_base; however, when using the openai package if I use the cl100k_base encoder to truncate my prompt, I get the following error, but if I use p50k_base, I don't get the error. So, it appears that either the correct tokenizer is p50k_base or the wrong tokenizer may be set in openai.
openai.error.InvalidRequestError: This model's maximum context length is 4097 tokens. However, your messages resulted in 4104 tokens. Please reduce the length of the messages.

To Reproduce
It will fail if you run the code as is with full_text longer than 4061 tokens. However, if you change
tokenizer = tiktoken.get_encoding("cl100k_base" if model_name == "gpt-3.5-turbo" else "p50k_base")

to
tokenizer = tiktoken.get_encoding("p50k_base")

everything works as expected.
Code snippets
import tiktoken
from langchain import OpenAI, PromptTemplate

full_text = "The content of this article, https://nymag.com/news/features/mark-zuckerberg-2012-5/?mid=nymag_press"
model_name = "gpt-3.5-turbo"
num_keyphrases = 5

# Define the prompt template
template = """Suggest the top {num_keyphrases} keywords that best describe the most important topics or themes in following text:

###

TEXT: {full_text}

###

Top {num_keyphrases} Keywords:"""

prompt_template = PromptTemplate(
    input_variables=["num_keyphrases", "full_text"], template=template
)

# Get the top keyphrases from the article

# Load the model
llm = OpenAI(model_name=model_name, temperature=0)
# Get the maximum length of the text
tokenizer = tiktoken.get_encoding("cl100k_base" if model_name == "gpt-3.5-turbo" else "p50k_base")
model_context_size = (
    4097 if model_name == "gpt-3.5-turbo" else llm.modelname_to_contextsize(model_name)
)
text_max_length = model_context_size - len(
    tokenizer.encode(
        prompt_template.format(num_keyphrases=num_keyphrases, full_text="")
    )
)

# Truncate the text if it is too long
full_text = tokenizer.decode(tokenizer.encode(full_text)[:text_max_length])

# Get the top keyphrases from the article
response = llm(
    prompt_template.format(num_keyphrases=num_keyphrases, full_text=full_text)
)

print(response)

OS
macOS
Python version
Python v3.10.9
Library version
openai v0.27.2

@CMobley7 that's not a bug, it's just specific to how tokens are actually counted for ChatML models, see https://github.com/openai/openai-cookbook/blob/main/examples/How_to_count_tokens_with_tiktoken.ipynb (section 6) to see how to count tokens properly for models with messages instead of the traditional prompt.
Pasted from there for quick reference:
def num_tokens_from_messages(messages, model="gpt-3.5-turbo-0301"):
    """Returns the number of tokens used by a list of messages."""
    try:
        encoding = tiktoken.encoding_for_model(model)
    except KeyError:
        encoding = tiktoken.get_encoding("cl100k_base")
    if model == "gpt-3.5-turbo-0301":  # note: future models may deviate from this
        num_tokens = 0
        for message in messages:
            num_tokens += 4  # every message follows <im_start>{role/name}\n{content}<im_end>\n
            for key, value in message.items():
                num_tokens += len(encoding.encode(value))
                if key == "name":  # if there's a name, the role is omitted
                    num_tokens += -1  # role is always required and always 1 token
        num_tokens += 2  # every reply is primed with <im_start>assistant
        return num_tokens
    else:
        raise NotImplementedError(f"""num_tokens_from_messages() is not presently implemented for model {model}.
See https://github.com/openai/openai-python/blob/main/chatml.md for information on how messages are converted to tok

@Ziggyware https://platform.openai.com/tokenizer only has the tokenizers for the Codex model and GPT-3, and gpt-3.5-turbo (and gpt-4) has a different tokenizer from base GPT-3 models like davinci or text-davinci-003, so there's nothing wrong with the encoding.

Thanks, I guess it's just really confusing, I'm sure I'm not the only one scratching my head :)

@Ziggyware I think it's mainly confusing because OpenAI still hasn't updated their website to include the GPT 3.5/4 tokenizer, which is quite baffling, I agree.

Still trying to figure out this part. My code working well for gpt 3.5 to 4.0 turbo. Started getting the "error message: get_num_tokens_from_messages() is not presently implemented for model cl100k_base" error with gpt 4o.


The bot sometimes tries to remove a manifest without asking for a replacement.

Something I've noticed is that the bot will sometimes make a PR to remove a manifest without waiting for a replacement (either by opening an issue or by doing it itself). In the last 24 hours, ZeroTier and Google Chrome (#11266 and #11313) have been removed and since the PRs haven't cleared for their replacements, they are no longer in the repo at all, which means this happens:
PS C:\Users\Easton Pillay\projects\winget-pkgs> winget install Google.Chrome
No package found matching input criteria.
PS C:\Users\Easton Pillay\projects\winget-pkgs> # Oh no!

instead of the client just saying "hey! The hash hasn't been updated! use --force" which means the end-user can at least override instead of wondering why Chrome isn't offered by winget at all.
Ideally, whoever is checking PRs would catch it and merge the PR to add the new one to the repo first, but the bot shouldn't even try to open a PR to remove something at all unless it is sure that it should be removed (to the extent it can be).

@jedieaston thanks for informing us. You are correct, this shouldn't be the way these are handled. We should merge the add before the delete gets merged.

We have a workaround in place. We will provide a "permanent" fix for this in the future.

@jedieaston, we've implemented the changes so we don't delete the "last" manifest for a given package. Let us know if you see this behavior again.


New BC7 CPU encoder

New BC7 CPU encoder, significantly improves speed and quality.
Uses a mix of existing techniques (PCA + k-means clustering/LLS refinement) and a new one that tries to trade index precision for endpoint precision, and processes 8 blocks at once using SSE2.
Based on benchmarks against every other BC7 compressor that I'm aware of (both existing DirectXTex encoders, FasTC, Intel ISPC Texture Compressor, NVTT, Compressonator, bc7_gpu), it's roughly tied for best quality with NVTT and Compressonator, but is about 35x as fast as both of those and 10x as fast as the existing BC7 CPU encoder.

Thanks. I appreciate the work here and the contribution. I do need to take some time to review it in detail, and I'm a little concerned about the comingling of various licenses here (i.e. it's just not MIT).

The Squish license and the Convection license are both MIT, so it's all one license.

What exactly came from libsquish?

Just the initial endpoint selector code (a.k.a. the EndpointSelectorRGB and EndpointSelectorRGBA).

Replaced the Squish dependency with a fresh implementation and fixed channel weighting in the process, merged in an important speed optimization.  I think that should be it for any significant changes until review.

Is this PR still in work? It would be very useful on Linux


Copying files  from windows to bash

Hi everyone,
im using Bash on windows 10, what i need to copy a folder from windows to the path inside the bash: "C:\Users<User>\AppData\Local\lxss\home..."  i already tried that but once i start the bash and went to the location that i have copied the folder to and its not visible, and i tried ls -a and same result
Thanks

I'm not sure copying files there will work.   Don't do that :-)  It's hidden for a reason (many settings dirs are not hidden), and that reason is that it's not user-editable and changing files in that location will typically corrupt your WSL installation.
https://blogs.msdn.microsoft.com/commandline/2016/11/17/do-not-change-linux-files-using-windows-apps-and-tools/
Windows cannot access Linux-specific paths in WSL.  Instead, WSL can access Windows-specific paths.  So the way you do this is to open up a bash shell and do:
$ mv /mnt/c/path/to/your/files ~

(or whatever other paths you want to work with.)
Alternatively, it may make more sense to just point your Linux tools directly at your files in /mnt/c.

see, the reason why i want to do such a strange thing like copying files from windows to Linux, because sometimes its much more easier that the official way, my background is Microsoft technologies, .Net, VS, Windows OS...etc. but i got a task that i have to deal with open source and its a small one, SUPPOSEDLY.
it was only to install the tesserocr engine, but believe it or not that took me more than couple of days :(  although i followed the instruction on the net, the last step was to use something called "git pull ..." to get some resources from the internet and didn't work at all, so i though as a work around to install it manually from the site and just copy it  and place it there, and i wasn't surprised when that didn't work....but eventually worked, and by eventually i mean after posting many question here and there for an answer.
so at the end, with a small step like that i didn't want to become a professional in Linux and just get it over with .....if you use Microsoft technologies and not a fan of open source, you would understand ;)

@ibr123 -- so, I totally do understand why you would want to use official Windows tools to edit files in Linux.  That would be a very valuable feature; I would also love to see that exist, as would many others according to existing tickets.
(And yes, the open-source world can be quite a mess, and even the better projects/environments can have a big learning curve.  Microsoft's curated APIs have a lot of value in a lot of situations.)
All I don't understand is why fellow Windows users might be confused that a particularly-locked-down private app-data directory might not work as expected :-)

well, to be honest its the first time that i use bash on windows, one month ago i didn't even know that it comes with windows 10, so i didn't know that some directories are locked, but anyways that is the biggest problem, because the installation finally worked but now i have to deal with the engine itself :( and i know it would be a total mess.
surprisingly although this engine is Linux based, its installation was much easier on windows than Ubuntu!!

Same problem, thank you~

Same problem here.

Creating the file from a linux program should work, so you could use the wsl command to run a linux command like cp to copy the file from Windows into the Linux subsystem. For example:

Create a file (say, "foorc") in a staging location such as: C:\stage\foorc
Use wsl to copy it to the default user's home directory: wsl cp /mnt/c/stage/foorc ~/.foorc

You can delete the staging file afterwards if you like. For more information, see:
https://docs.microsoft.com/en-us/windows/wsl/interop

Thanks, @daiconrad. I actually thought to try that a day after I posted this, but still couldn't get it to work. With fresh eyes today, I realized I'd simply typed the wrong name for the config file! I can confirm that your suggestion works.

@aseering - I can completely see "fellow Windows users might be confused that a particularly-locked-down private app-data directory might not work as expected": your fellow Windows users had no idea that the private app-data directory was "particularly-locked-down". I typed "Explorer.exe ." from my home directory and voila! - there I was in that locked-down directly. Why would I do that? OS X and the Linux UI itself set a very high bar in terms of expectations of UI-command-line integration. WSL is a great start but is clearly a ways off from my expectations.

@zielot Interop between Linux and Windows has greatly improved by leaps and bounds since this issue was first posted. No you can't straight move files or directly edit from Windows created in Linux but software tools such as VS Code are increasing compatiblity in this arena so that you can use both Windows and Linux tools to modify Linux files. As someone who had to treat Windows and Linux as separate beasts, WSL has greatly harmonized the two far more than what would of been expected a few years ago. WSL still has a long ways to go but it's quite ususable as it is now. As far as "UI-command-line  integration", you'll want to refer to https://github.com/Microsoft/Console as conhost is responsible for rendering the terminal for CMD/Powershell/WSL and has greatly improved interop in Skip-Ahead builds.

@DarthSpock  - I agree; WSL is a far cry from the POSIX compatibility layer and an entirely different world from the cmd console. I will for sure check out the ColorTool on the Console GitHub account.


x/exp/typeparams: a new module with a transitional API for tools

Background
With Go 1.18, we are adding a large number of new APIs in go/* packages such as go/ast and go/types to represent the new languages features introduced with generics (see proposals #47781 and #47916). Those proposals describe the new types and functions, but do not comprehensively discuss their semantics nor offer guidance on how to update existing tools. Recently, we've updated many tools in x/tools, such as gopls and vet analyzers, and it would be great to share what we learned from that work with the larger community, to help others update their tools.
There were two notably difficult aspects of updating our tools to support generics:

We need to handle the new syntax and types while continuing to build at older Go versions.
For analyzers in particular, we often needed to compute a representation of the structural restrictions on a type parameter's type set. For example, this is necessary in the printf analyzer to report a diagnostic if any members of the type set to not match the corresponding printf verb.  go/types does not yet expose an API for this, because at the time we weren't sure what the correct interface for a type set should be.

Our solutions to both of those problems are contained in the x/tools/internal/typeparams package. This package exposes a transitional API, which at Go 1.18 is just a proxy for the corresponding go/* APIs, and at earlier Go versions is a stub.  For example, it exports a typeparams.Union type, which is an alias for go/types.Union at Go 1.18 but a placeholder at Go 1.17. Furthermore the typeparams.StructuralTerms function computes the 'structural' terms of a type parameter, i.e. the normalized list of structural restrictions, after reducing unions and intersections.
Proposal
I propose that we to add a new module to x/exp, golang.org/x/exp/typeparams, which contains the functionality currently exposed by x/tools/internal/typeparams (modulo improved documentation and other superficial improvements). By being publicly importable, this module would provide the same functionality to other tools as x/tools/internal/typeparams has provided x/tools. Furthermore, this module could serve as a home (or entrypoint) for more detailed documentation on how to update tools to support generics. As an initial pass, it could include guidance in its package documentation or in an associated README.
I considered instead suggesting that tools simply copy x/tools/internal/typeparams, but particularly with the typeparams.StructuralTerms API it is possible that we will release bug-fixes, so we should make updating easy.
As for why a new module, and why x/exp, consider the following:

This package will be small and have no dependencies.
At some point we may want to tag a final version and delete it. This could possibly occur upon the release of Go 1.21 (two versions after 1.19, which will probably also contain API additions).

Putting this code in a new module in x/exp identifies it as experimental/transient, and means that we won't break builds depending on x/tools for other reasons, if/when it is deleted.
Caveats
If we add x/exp/typeparams, it makes sense to use it to replace the existing usage of x/tools/internal/typeparams. In that case, x/exp/typeparams would not only be required by  x/tools, it would be vendored into cmd by way of cmd/vet. ~It might not be a good precedent to include code from x/exp in the go distribution, though I'm not aware of a practical problem with this. We could alternatively create a new submodule of x/tools.~  Since this is disallowed, we'll have to keep using x/tools/internal/typeparams, and sync it with x/exp via a script.
Aside: suggestions for improved APIs are certainly welcome, but I'd like to keep the initial focus of the discussion here about whether or not to create such a module, and where to put it. If this proposal is accepted, we can shift discussion to the details.

This proposal has been added to the active column of the proposals project
and will now be reviewed at the weekly proposal review meetings.
— rsc for the proposal review group

It may be worth emphasizing that without this package [or something similar] it is challenging to develop tools that deal with the types package that can be compiled with pre-Go 1.18 compilers and also supports generics.

If we add x/exp/typeparams, it makes sense to use it to replace the existing usage of x/tools/internal/typeparams. In that case, x/exp/typeparams would not only be required by x/tools, it would be vendored into cmd by way of cmd/vet.

A way to avoid the vendoring from x/exp into cmd is to have another vendored copy in something like x/tools. Which x/tools/internal/typeparams already is. Maintaining both x/tools/internal/typeparams and a x/exp/typeparams is clearly not ideal, but neither is vendoring x/exp into cmd.

Furthermore the typeparams.StructuralTerms function computes the 'structural' terms of a type parameter, i.e. the normalized list of structural restrictions, after reducing unions and intersections.

We may need a permanent home for the hard to implement utilities like this. x/tools/go/types comes to mind. Might be good to resolve this now? Not sure if this is feasible now though.

Indeed. Right now tip.golang.org/pkg/constraints/?m=old is failing for precisely this reason.
(It is built against Go 1.16 because that's what App Engine provides.)

It is disallowed to have any x repo, nor the main repo, depend on x/exp.
Please leave things as they are and just make a copy in x/exp.
It's fine if there is a script to update the x/exp copy.

It is disallowed to have any x repo, nor the main repo, depend on x/exp.
Please leave things as they are and just make a copy in x/exp.
It's fine if there is a script to update the x/exp copy.

SGTM. It is better for us to maintain two copies than have every tool to maintain its own copy...

@timothy-king

We may need a permanent home for the hard to implement utilities like this. x/tools/go/types comes to mind. Might be good to resolve this now? Not sure if this is feasible now though.

I think this should eventually be a part of go/types itself, perhaps in 1.19.  We just didn't want to commit to an API before we understood the subtleties and applications of type sets (and FWIW I'm still glad we made this decision).

Out of curiosity, would this be a v0 or a v1+ module? "tag a final version and delete it" makes me think that we may not need to reach a v1.0.0.

We have no v1 in x repos yet (working on it) so I don't think we'd start with this one.

Based on the discussion above, this proposal seems like a likely accept.
— rsc for the proposal review group

No change in consensus, so accepted. 🎉
This issue now tracks the work of implementing the proposal.
— rsc for the proposal review group

This was blocked by beta2 and some outstanding concerns about predicates on generic types (#50887), with both of those hopefully resolved, I'll work on implementing this tomorrow.  I'll put together a CL for the new module, and leave it open for at least a week to invite comments.

Hi! Please add comments on https://golang.org/cl/383375 if you have opinions on the API for this new module. Even naming suggestions are appreciated.
I am pretty content with the current API, though one likely upcoming change is the name StructuralTerms: the word structural is being revisited in the spec this week, and we'll likely want to align with whatever terminology emerges there.

I've submitted the initial CL for this module: https://pkg.go.dev/golang.org/x/exp/typeparams
I didn't get much feedback on the CL, so decided to add a caveat that the API is still experimental. Please try to use it in your projects, and let me know if you have opinions.  I will remove the caveat in around a week, at which point we will not break the API (though we may still deprecate things).
Meanwhile, I am lagging behind on documentation, unfortunately. With 1.18 issues more or less resolved at this point, it is my highest priority.


bug: Auto hiding header bar on keyboard input

Type: bug
Platform: ios 8 webview
Hi, I've consulted so many posts about keyboard hiding header bar and found the solution to be:
add a keyboard plugin cordova plugin add https://github.com/driftyco/ionic-plugins-keyboard.git using command line.
add cordova.plugins.Keyboard.disableScroll(true); to the javascript.
Following post also says so:
http://ionicframework.com/docs/api/page/keyboard/1
But when i do above steps, i get an error cordova is not defined. I added the disableScroll function to my controller.
The bar doesn't hide in browser, but on simulator or on actual device it does.
I'm sure it's something silly that i'm doing, but can please anybody lend some help. Thanks.

http://forum.ionicframework.com/t/auto-hiding-header-bar-on-keyboard-input/26117

Greetings @meparashar!
My sensors indicate that you need to update your issue through our custom issue form. We are now requiring all issues to be submitted this way, to ensure that we have all of the information necessary to fix them as quickly as possible.
Click Here To Update Your Issue
I will have no choice but to close this issue if it is not resubmitted through the form. Please fill out the rest of the form, so that I may use my friendly robot powers to assist you.
Thank you!

@mhartington I guess the processor is not even going inside if statement (checked that with console.log) and since cordova is not found, window.cordova is returning false. i checked the plugin, when i try to install it, the console returns the message that the plugin is already installed.
the problem is that it's working in browser. only on simulator and device it doesn't work.
any suggestions are welcome.

Are you referencing cordova.js inside of your index.html?

yup.
`
`

woah, that shouldn't be like that. You shouldn't be referencing cordova_plugin.js in your index.html. Any way you could push this to github for me to look at?

@mhartington not sure how to do that. Here's the public link to my ionic dummy project:
https://www.dropbox.com/s/8eu9sujycchrl49/fm 2.zip?dl=0 (you just need to build it)
if you face any difficulty.. lemme know.. i'll learn how to use github then and send the project if that's ok with you.
thanks a lot again for your help.

@mhartington here's the git url:
https://github.com/meparashar/tempapp

hi @mhartington finally i have resolved the issue. i uninstalled the keyboard plugin from the project, reinstalled it. removed the ios platform, and added it back. that finally solved it. thanks for all your help guiding me to find a solution. really appreciate it.


Obtaining System.ArgumentException when loading a Collection

Im trying to execute the function 'find' in a collection of the object type "Character".
The function being is var C = col.Find(x => x.Name.ToLower().StartsWith(name.ToLower())); and it returns the following StackTrace:
System.ArgumentException occurred   HResult=0x80070057   Message=Incorrect number of arguments supplied for call to method 'Char get_Chars(Int32)'   Source=System.Linq.Expressions   StackTrace:    at System.Linq.Expressions.Expression.Property(Expression expression, PropertyInfo property)    at System.Linq.Expressions.Expression.MakeMemberAccess(Expression expression, MemberInfo member)    at LiteDB.Reflection.CreateGenericGetter(Type type, MemberInfo memberInfo)    at LiteDB.BsonMapper.BuildEntityMapper(Type type)    at LiteDB.BsonMapper.GetEntityMapper(Type type)    at LiteDB.QueryVisitor1.GetField(Expression expr, String prefix, Boolean showArrayItems)
at LiteDB.QueryVisitor1.VisitExpression(Expression expr, String prefix)    at LiteDB.LiteCollection1.Find(Expression1 predicate, Int32 skip, Int32 limit)    at ERA20.Modules.Classes.Character.GetCharacter(String name) in C:\Users\yoshisman\source\repos\E.R.A.-Discord-Bot\ERA2.0\ERA2.0\Modules\Classes\Actors.cs:line 138

Forgot to add the function that's being run:
public IEnumerable<Character> GetCharacter(string name)         {             var col = Database.GetCollection<Character>("Characters");             col.EnsureIndex(x => x.Name);             var C = col.Find(x => x.Name.ToLower().StartsWith(name.ToLower()));             return C;         }
Its a simple function, but it gets that stacktrace when trying to execute it.

Hi @yoshisman8, there is no support for function (in this way) in LiteDB. If you are using v4, you can create an index to support that, like this:
// create index using lower function
col.EnsureIndex("Name", "LOWER($.Name)");

// query using index (using Query helper)
col.Find(Query.StartsWith("Name", name.ToLower()));

// query using Linq (do not use ToLower in field/index name)
col.Find(x => x.Name.StartsWith(name.ToLower())

Hi! With the objective of organizing our issues, we are closing old unsolved issues. Please check the latest version of LiteDB and open a new issue if your problem/question/suggestion still applies. Thanks!


deps: update cloud spanner to 6.17.4

Updates to latest cloud spanner library version.
I executed this version against the quickstart (https://github.com/brianfrankcooper/YCSB/tree/master/cloudspanner#running-a-workload) and it worked fine.

Closing in favour of https://github.com/brianfrankcooper/YCSB/pull/1600


Update csrf.py

Forgot to add a default value.

Thanks! The changes are live in v0.4.1:
https://pypi.org/project/Starlette-WTF/0.4.1/
Let me know if you run into any other issues.


Unnecessary complexity?

In this script:
https://github.com/redhat-canada-gitops/catalog/blob/master/sealed-secrets-operator/scripts/get-sealed-secret-key.sh
You have:
oc get $(oc get secret -n sealed-secrets -l sealedsecrets.bitnami.com/sealed-secrets-key=active -o name) -n sealed-secrets -o yaml >  ~/.bitnami/sealed-secrets-secret.yaml
You can use the label in the outer command like this to get the same results:
oc get secret -l sealedsecrets.bitnami.com/sealed-secrets-key=active -n sealed-secrets -o yaml >  ~/.bitnami/sealed-secrets-secret.yaml

Provided a fix


Region border toggle

Can you check the shortkey 'e' functionality for nuclei borders. Seems its now conditioned upon when your mouse is hovering on the region table -- sorry, i just don't have time yet to make an issue in github!

Fixed

Fixed


completing getSupportedPlatformInfoFunctions conversion

Description
Fixes #1085
Updates the following functions to use getSupportedPlatformInfoFunctions

getProduct*
supported32BitAbis*
getInstallReferrer*
getIncremental*
getSecurityPatch*
getBaseOs*
getTags*
getHost*
getFingerprint*
getIpAddress*
getSerialNumber*

This should be all of the remaining conversions.
Compatibility

OS
Implemented

iOS
✅

Android
✅

Windows
✅

Checklist

[X] I have tested this on a device/simulator for each compatible OS

tested on iOS and Android, but unable to do so on Windows

[ ] I added the documentation in README.md
[ ] I mentioned this change in CHANGELOG.md
[ ] I updated the typings files (privateTypes.ts, types.ts)
[ ] I added a sample use of the API (example/App.js)

@mikehardy,
No worries!
We all understand the struggles.
October ends up being somewhat of a downtime for me every year — quite the coincidence for Hacktoberfest.
I plan on adding jest tests in a GitHub action, so expect that maybe sometime this week; It should take some of the load off someone's shoulders.
Do you have any resources on how you'd like to perform releases? I can look into getting that setup; maybe get a ball rolling.

Do I have ideas for release :-) :-) - semantic-release is the gold standard I think, react-native-webview for instance works beautifully and I believe react-native-share also has it all set up and working.
I'm pro-delegation and don't mind mistakes as long as someone is trying their best. If you want to set up a little testing and semantic-release I can grant power on the repo and the npmjs package repository
I have worked on react-native-firebase's CI a lot and those .github workflows are pretty good with regards to starting an iOS and Android emulator and running an app although those E2E tests are extraordinarily complex. I think simply building the app for iOS and Android along with jest tests would be an amazing first step, and then either semantic-release or a "workflow_dispatch" triggered publish
Those are the ideas anyway :-)

Sounds good to me.
I'll start going through the repos you've mentioned, then set up jest testing in a GH action.


unexpected behaviour of Tree.children

calling .children of a tree doesn't always return what I would expect.
someTree.parent.map(_.children.contains(someTree)) is not always true it seems
Here an example:
https://gist.github.com/johannegger/c0adc6e8a23318e3513f

Wow, that's indeed unexpected. How did you come across this bug?

i was looking for groups of imports similar to the example in the gist.
after finding all imports i wanted to know their sibling relations (are they neighbours in their parent's .children Seq ) and boom, the parent had no children.
do you think it's easy to fix?

Fixed and published in 0.1.0-SNAPSHOT.

that was fast, thank you :+1:


About training data process

Hi,
Thank you for your outstanding work! I have a question regarding the training process. When generating the conditioning signal, I understand that the point cloud is obtained from a single frame. However, during rendering, is the camera pose derived from running dust3r on a single frame, or from a clip of 25 frames? If it's the latter, could there be any discrepancies between the pose predicted from 25 frames during rendering and the one predicted from a single frame during inference?
Thank you for your help and for the excellent work you’ve done!

Thanks for your interest!
During training, the camera poses are derived from all 25 frames. During inference, the reference camera pose is not predicted; instead, it is fixed at (r, 0, 0) in the world coordinate system, and the subsequent camera poses are specified by the users, so there should be no discrepancies.


Rebuild for CVE-2024-24790

Security scanners state the binary of the current release is vulnerable to CVE-2024-24790 because it's built with an outdated go (stdlib) version.
Can you rebuild the binary and release a new version?

Hi, yes i can.

Done :-)

Thanks :)


Cpanel Mail Quota Display

Is there any plan to create package to display cpanel mail box quota and usage after logged in?

There is a usage indicator beneath the message list, but for me it shows the wrong quota.
(I have 2GB cpanel storage and a 1GB mailbox quota, but the indicator shows I'm using 1.3MB out of 2GB)

Is the indicator working properly for your installation?

No. How do you enabled it. I don't have it

I don't know how to implement a progress bar instead of a percentage indicator. I can imagine it should be quite easy to implement. Unfortunately I'm not part of the rainloop team.

The actual issue with quotas is Rainloop displays the cPanel Account Quota and not the Mailbox Quota, i can't remember from which version this changed but it used to display the mailbox quota correctly in previous versions.
For example, in my server Rainloop displays a quota use of 31% as shown in the next image:

But it should be displaying the Mailbox quota, which in my case, should be 3% as i have 29mb used of 1gb allowed, this is showed by the roundcube webmail:

If this happens for a wrong configuration in the Rainloop app, please let me know so i can fix it in my server, if this is not the case, i'm gladly reporting it in this message.
Thanks.

Did anyone find a fix for this problem yet? Rainloop is unusable for me right now because this will give my users a totally wrong usage indication.

@dodedodo
RainLoop uses GETQUOTAROOT command to get mail usage information.
It means your IMAP server returns 20GB instead 1GB.

@RainLoop
So can it be fixed? if yes, how?

It be fixed?

My rain loop return no usage information ,how can i fix it ?

Any updates?
I having the same problem like others which I assigned 30GB to this account but it display the entire space.

Thanks

I'm also having this after moving to a 3GB disk space cpanel account and created 1GB mailbox but space shows as 1.9GB of 3GB (1.9GB is the total disk space not the email used space)


Fix type for AppConfig

Description
Fix type for AppConfig, change introduced by https://github.com/openshift/lightspeed-service/pull/943
Type of change

[ ] Refactor
[ ] New feature
[x] Bug fix
[ ] CVE fix
[ ] Optimization
[ ] Documentation Update
[ ] Configuration Update
[ ] Bump-up dependent library

/approve

/retest

/lgtm
/approve

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 94.90%. Comparing base (0867837) to head (f67aae7).
Report is 23 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #956      +/-   ##
==========================================
- Coverage   95.17%   94.90%   -0.27%
==========================================
  Files          54       54
  Lines        2030     2120      +90
==========================================
+ Hits         1932     2012      +80
- Misses         98      108      +10

Files
Coverage Δ

ols/app/metrics/metrics.py
100.00% <100.00%> (ø)

... and 3 files with indirect coverage changes

/retest

/retest

/retest


Change debug serial

Can you add some functionality to change debug serial port?

Hi,
Why do you need this? please give me more information.
Regards
Joao

Sometimes Serial connected to sensor or controlled device and only way to send logs is send them via Serial1 or SoftwareSerial....

Hi,
The purpose this library is the telnet, not serial.
Why you not use telnet to see the logs ?
Regards,
Joao


Games layout and game's components

Blocked by #122 , so do it when one will be done
Part of #110 . It is important to read.
Provide games-layout for application from old mocks which gets all data to show and pass it to related components such as game-list.component, game-card.component and others.

Create list that show all games and their:

name
logo
genre
description.

There should be two ways of views: cards and list. Header should be sticky.
Implement animation and loader.


How to update the config of an existing Flatcar instance?

Current situation
I am interested in giving Flatcar a try but was unable to find an answer to the following question: Assuming I have successfully installed a Flatcar instance and would like to update its config, how do I do this? I understand I would have to use ct to transform it into an ignition.json, but how do I actually apply it? The way I understand it is that it depends on the environment, but I am unable to find specifics.
Ideal future situation
There is a section that explains how to update the configuration of a given instance.
Additional information
I am new to Flatcar, so I might just have missed the obvious 😄

Hello,
if you follow the principle of immutable infrastructure, then you don't modify a config of an instance but delete the instance and create a new one.
When you provision an instance with an Ignition config, you either have the config coming from the metadata servers in EC2, an explicit URL via a kernel command line parameter, or from the config partition, etc. You can change this JSON config and tell Ignition to run again but you have to be aware that Ignition won't undo anything done in the old config. However, since you can tell Ignition to format the root partition, this would be a workaround – or you just make small config changes.
Here is the docs link that also tells how to ensure that a systemd service is enabled when running Ignition again (without having it format the root partition):
https://docs.flatcar-linux.org/ignition/boot-process/#reprovisioning

Thanks!


err: clear flags better when clearing errors.

An attempt to clear an error with malloced data didn't clear the flags.  Now it clears all flags except the malloced flag.
Fixes #12530

[x] tests are added or updated

There are failing CIs -- asan is detecting leaks with this change.  I'm yet to investigate why or how this can happen...

Fixed the leak, ready for review.

Merged, thanks for the reviews.


Updated jose to 1.8. Updated elixir version requirement to >= 1.2

#138

Coverage remained the same at 84.324% when pulling 109001ed01ab87428d411dca2c6c33898b9c4a24 on update_jose_and_elixir_deps into 52a532d7f293a118c87f2cebe16877376d8580e6 on master.

Coverage remained the same at 84.324% when pulling 4bff9a6c6c929179cab347f574e93bcebbef1963 on update_jose_and_elixir_deps into 52a532d7f293a118c87f2cebe16877376d8580e6 on master.

I guess that is the way the community is dealing with versions. If anyone still use Elixir 1.0 or 1.1 they can still use older versions of Joken.
Just one thing that would be necessary, IMHO, is to have a long-lived branch with Joken 1.2.x series just in case, since this is a somewhat security related library.

Yeah I think that is a good idea

Created v1.2 branch based on 1.2.2 https://github.com/bryanjos/joken/tree/v1.2

With the branch for 1.2 created, I think it is safe to merge this


KISS sites listed are fake sites

The KISS sites listed here are fake and not frequently updated. Please just note KISS sites such as kissanime, kissasian and kimcartoon to link to official kissanime reddit page for users to find official links.
https://www.reddit.com/r/KissAnime/

Which sites specifically are fake?

KissAnime is dead.


Update readme.md

made the icon list more structured

next time maybe think about sorting it in alphabetic order


Verify the chosen JSON parser is valid and can be loaded

The system previously did not do any validation on the provided json parser.  This meant it was not invoked until it was inside the EventMachine loop.  It is unlikely anyone would want to handle an invalid parser during the event loop instead of fixing the initialization error.  I added this check to avoid problems like I had where the client was dying silently due to a configuration typo.

Thanks for the PR


ImportError: No module named web.routes

Hi,
thanks for the tutorial!
When I start python daemon.py I get the following error:
Traceback (most recent call last):
File "daemon.py", line 25, in
from web.routes import routes
ImportError: No module named web.routes
Do you have an idea what the problem is? Which package shall I install?

Hi,
It seems that i miss __init__.py file in web dir.
Can you create this file(should be empty) and run daemon.py?
It should help.

thanks a lot! It works!
But I'm still not connected to the device:
$[ERROR] 2018-03-15 19:30:44,539: Devicehive is not connected

Thanks for your feedback. I will fix __init__.py issue and some other minor fixes once i have some time.
About your second question: Once you have run daemon.py you need go to http://<IP_ADDRESS>:8000/ and configure devicehive connection. Settings will be saved to file and connection should be established.


Idris packages

@vcunat for documentation offer, if you were serious :wink:

@vcunat for documentation offer, if you were serious :wink:

I was serious but got delayed by some personal mishaps. These docs are included in nixpkgs manual now.

Thanks!