Model Checkpoint NOT saved, Eval Loss "Inf"

System Info
torchrun
--nproc_per_node 3
llama_finetuning.py
--enable_fsdp
--low_cpu_fsdp
--use_peft
--dataset custom_dataset
--peft_method lora
--model_name /Llama-2-13b-chat-hf
--pure_bf16
--dist_checkpoint_root_folder /dist_chkpt_root_folder
--output_dir /llama-recipes/models"
Information

[ ] The official example scripts
[ ] My own modified scripts

🐛 Describe the bug
The following is a snippet of the last few lines of the log files for the llama-2-13b-chat fine-tuned on the custom dataset, The training finished; however, the eval loss shows to be inf
And the model checkpoint was not saved, and I did not see any error message either. Any help will be appreciated. I spent four days of computing on training, and it got wasted.
........
Epoch 3: train_perplexity=1.3212, train_epoch_loss=0.2786, epcoh time<PHONE_NUMBER>7786875s
Key: avg_train_prep, Value: 1.387495994567871
Key: avg_train_loss, Value: 0.3265116214752197
Key: avg_eval_prep, Value: nan
Key: avg_eval_loss, Value: inf
Key: avg_epoch_time, Value:<PHONE_NUMBER>1801738
Key: avg_checkpoint_time, Value: 0.00011723674833774567
Error logs
And the model checkpoint was not saved, and I did not see any error message either. Any help will be appreciated. I spent four days of computing on training, and it got wasted.
........
Epoch 3: train_perplexity=1.3212, train_epoch_loss=0.2786, epcoh time<PHONE_NUMBER>7786875s
Key: avg_train_prep, Value: 1.387495994567871
Key: avg_train_loss, Value: 0.3265116214752197
Key: avg_eval_prep, Value: nan
Key: avg_eval_loss, Value: inf
Key: avg_epoch_time, Value:<PHONE_NUMBER>1801738
Key: avg_checkpoint_time, Value: 0.00011723674833774567
Expected behavior
The model checkpoint should have been saved in the mentioned output directory

Hi, the eval loss being inf will prevent saving the checkpoint as we compare against an initial best eval loss of inf
Comparison is here
Initial best eval value here
To better investigate the issue you can deactivate the comparison with the best value in the source file to get a checkpoint and then run an eval manual to figure out why your eval loss is inf on your data.

I tried commenting out the valid loss, and the training finished, however when saving the checkpoint, OOM was raised,
evaluating Epoch: 100%|██████████| 1/1 [00:12<00:00, 12.43s/it]
eval_ppl=tensor(1.5420, device='cuda:0') eval_epoch_loss=tensor(0.4330, device='cuda:0')
we are about to save the PEFT modules
Traceback (most recent call last):
File "/../llama-recipes/llama_finetuning.py", line 253, in
fire.Fire(main)
.................................................
torch.cuda.OutOfMemoryError: CUDA out of memory. Tried to allocate 2.00 MiB. GPU 0 has a total capacty of 79.15 GiB of which 2.06 MiB is free. Including non-PyTorch memory, this process has 79.13 GiB memory in use. Of the allocated memory 77.91 GiB is allocated by PyTorch, and 187.64 MiB is reserved by PyTorch but unallocated. If reserved but unallocated memory is large try setting max_split_size_mb to avoid fragmentation.  See documentation for Memory Management and PYTORCH_CUDA_ALLOC_CONF
Exception raised from malloc at ../c10/cuda/CUDACachingAllocator.cpp:1438 (most recent call first):

any solution now? Same problem


[ML] test: Fix unittest failing in CI because of urllib3>2

Description
This pull requests fixes a unit test failure that only happens in CI due to a change in urllib3>2
Background
Until about 18 hours ago, running the ML testsuite would install urllib3<2 (see last merged ML PR) and all our tests would pass.
For some reason soon after that PR was merged, urllib3==2.0.5 started getting installed in our CI runs (was a cache invalidated?) and we started seeing a single unittest failure with the message:
Error message:

assert "Failed to establish a new connection" in str(ex)

E       assert 'Failed to establish a new connection' in '<ExceptionInfo ServiceRequestError("<urllib3.connection.HTTPSConnection object at 0x0000000016532c98>: Failed to resolve \'fake.localhost\' ([Errno -2] Name or service not known)") tblen=14>'

I'm guessing we're starting to see urllib3==2.0.5 in our CI builds since azure-sdk-tools no longer pins urllib`<2 after the Sphinx upgrade from a few days ago.
[Errno -2] Name or service not known suggests a DNS resolution failure, and urllib3 was changed to raise a NameResolutionError in version 2.0.0 which has a different message than the one the test checked for. I'm guessing our CI is doing weird stuff with the DNS, since running the test locally with urllib3==2.0.5 works as we'd expect.
All SDK Contribution checklist:

[x] The pull request does not introduce [breaking changes]
[x] CHANGELOG is updated for new features, bug fixes or other significant changes.
[x] I have read the contribution guidelines.

General Guidelines and Best Practices

[x] Title of the pull request is clear and informative.
[x] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

[x] Pull request includes test coverage for the included changes.

API change check
APIView has identified API level changes in this PR and created following API reviews.
azure-ai-ml


Optimize repeated commands

According to the SVG spec, repeated commands can be omitted. While this is not shorter if a space is needed in its place, the space can be omitted if the next number is negative. This optimization does exactly that. The reduction in file size is very small, in my tests much less than 1%, but it does help and it's a relatively small change.

Actually convertPathData already does this. However, it's cannot be done always, since it can break image. You almost never can omit a curve, lines depends on directions, etc. You change breaks tests, by the way.


The golang:v1.22-alpine3.18 image uses golang v1.22.3

The golang:v1.22-alpine3.18 image uses golang v1.22.3 . The Dockerfile.builder of version v4.2.1 fails to build.
https://github.com/neutron-org/neutron/blob/ac620c19ae88c9d8697190664f709931f33b007d/Dockerfile.builder#L10

It uses go toolchain v1.22.6 inside https://github.com/neutron-org/neutron/blob/ac620c19ae88c9d8697190664f709931f33b007d/Dockerfile.builder#L17
And make build-static-linux-amd64 command works as expected


feat: improve initial startup information

Should we be asking users to "wait while we establish a connection" when we have unauthorized ADB state? Isn't this unrecoverable? Or is it normal during bootup time?
"If the issue persists, please restart the emulator." Can we include instructions on how to restart emulators? e.g. emucli restart


Develop a pipeline with snakemake for anaconda

Is your feature request related to a problem? Please describe.
How to develop a pipeline based in snakemake in a way it can be submitted to Anaconda, and accessed remotely, without calling snakemake?
Describe the solution you'd like
I want to adapt my pipeline  that is already available through bioconda to using snakemake - the main script would be converted into a Snakefile, and this snakefile could be called as a regular tool.
Describe alternatives you've considered
How should the Snakefile be configured to be run as a Conda tool?

This should be asked on stackoverflow, but to answer your question:
Take a look at https://github.com/vanheeringen-lab/seq2science (my work) or snakepipes (https://github.com/maxplanck-ie/snakepipes)

The parsing of samples and config is indeed a bit unclear.
The samples are "checked" in this part: https://github.com/vanheeringen-lab/seq2science/blob/master/seq2science/rules/configuration_generic.smk#L113
We check a couple things, like if it is filled in correctly. And for some of this we make use of sample schemas: https://github.com/vanheeringen-lab/seq2science/tree/master/seq2science/schemas/samples
Since the configuration file is included before the rest of the code it is executed before the samples are used in the lower part of the Snakefile. The actual sample file and configuration you pass to the seq2science command line interface, which passes it through the snakemake API to snakemake. Let me know if you need more help :+1:

How do you iterate over the pandas DF for every rule? As an example, when I want to run
import pandas as pd

configfile: "config.json"

experiments = pd.read_csv(config["experiments"], sep = '\t')

rule all:
  input:
    expand("{output}/Assembly/{experiment[1][Sample]}/contigs.fasta",
            output = config["output"], experiment = experiments)

it says
TypeError in line 10 of /path/to/Snakefile:
string indices must be integers
  File "/path/to/Snakefile", line 10, in <module>

This makes sense, but how can I access the values in each line? Are the iterator methods, like read_table, required?

I did follow you advise and raised the same question over at StackOverflow  :)

Moved to StackOverflow


Question: How do I change a raw statement in a hook/callback?

Your Question
I have been leveraging the gorm.DB struct as a generic database provider. In my unit tests I've been running with SQLite and switch to Postgres for integration tests. SQLite doesn't have a truncate statement, but postgres does (which we use in production for performance reasons). For my unit tests, I'd like to register a callback to modify the callback to conform to SQLite's syntax.
I tried to do this, and I can actually debug with DLV and see my code getting executed but it doesn't look like the actual raw statement is replaced:
Test Code
// ...
gormDB.Callback().Raw().Register("sqlite-truncate-mapping", sqliteTruncateMapping)
// ...

// SQLite does NOT have a truncate statement. It has a truncate
// optimization that occurs with an unqualified delete statement.
// https://www.sqlite.org/lang_delete.html
func sqliteTruncateMapping(db *gorm.DB) {
	if rawSQL := db.Statement.SQL.String(); strings.HasPrefix(rawSQL, `TRUNCATE`) {
		updatedSQL := strings.Replace(rawSQL, `TRUNCATE`, `DELETE FROM`, 1)
		db.Statement.SQL.Reset()
		db.Statement.SQL.WriteString(updatedSQL)
	}
}

// ...
if err := tx.Exec(`TRUNCATE projects`).Error; err != nil {
    return err
}

The document you expected this should be explained

https://gorm.io/docs/hooks.html#Modify-current-operation (Probably most likely here)
https://gorm.io/docs/sql_builder.html

Expected answer
I expected the raw statement to be changed from:
TRUNCATE projects

to:
DELETE FROM projects

However I still get the SQLite syntax error showing the command hasn't been changed:
--- FAIL: TestProjectRepository_Set (45.23s)
    repository_test.go:49:
        	Error Trace:	repository_test.go:49
        	Error:      	Received unexpected error:
        	            	could not set projects: near "TRUNCATE": syntax error
        	Test:       	TestProjectRepository_Set
        	Messages:   	should not recieve an error, but did: could not set projects: near "TRUNCATE": syntax error
FAIL

Actually I have this working. After doing some debugging and seeing how the callbacks were handled, my callback was being called AFTER the database was being hit. I found gorm:raw was defined as the callback for execution, so I placed mine before it and it is executed in order now.
My question is now, is this the most correct way to implement this or have I overlooked anything in my ignorance?
gormDB.Callback().Raw().Before("gorm:raw").Register("sqlite:truncate-mapping", sqliteTruncateMapping)
// ...

// SQLite does NOT have a truncate statement. It has a truncate
// optimization that occurs with an unqualified delete statement.
// https://www.sqlite.org/lang_delete.html
func sqliteTruncateMapping(db *gorm.DB) {
	truncate := `TRUNCATE `
	deleteFrom := `DELETE FROM `
	if rawSQL := db.Statement.SQL.String(); strings.HasPrefix(strings.ToUpper(rawSQL), truncate) {
		log.Infof("raw-sql: `%s` mapping to `%s` for SQLite compatibility", truncate, deleteFrom)
		updatedSQL := deleteFrom + rawSQL[len(truncate):]
		db.Statement.SQL.Reset()
		db.Statement.SQL.WriteString(updatedSQL)
	}
}

hello @paul-nelson-baker, Is this question whether   Execute different SQL for different databases ?
if you can know gorm 's DB is sqlite or pg,you can solve it.
use DB.Statement.Dialector.Name() to get db type ,sqlite or pg.

Thanks for answering! Fortunately, I don't need to go that in-depth. I'd like to keep this test centric code separate from the final binary. That way I won't need to validate that it isn't accidentally being run on my execution environment.
Thanks for your feedback, it's much appreciated!!


Place emanation templates at token center and disable template movement

Depends on #11759
Movement can be enabled by a new emanation area property:

Does this block all previewing of the ghost template if you mouse elsewhere, or does it only block placement?
Not sure what unconstrained is meant for.

The preview is rendered on the token center and can't be moved. Right click still cancels and left click still places the preview.

Reworked to allow free movement of the preview template but the created template will be centered on the token (with a notification if it was off center) unless unconstrained is set.

Sweet. Abilities like https://2e.aonprd.com/Feats.aspx?ID=4354 might be rough to use if you can't preview a good position to stride into. What purpose does unconstrained solve? Emanations that get left behind?

There are some spells that are emanations and specify a range like https://2e.aonprd.com/Spells.aspx?ID=613

There are some spells that are emanations and specify a range like https://2e.aonprd.com/Spells.aspx?ID=613

Not sure how to make sense of that range. It's LO:G&M, though, so really anything goes.

Yeah, that should probably have been a burst instead of an emanation.
Maybe a better example: https://2e.aonprd.com/Spells.aspx?ID=38


OOPS PR #2670 requires Atlas tagged version 0.38

OOPS PR #2670 requires Atlas 0.38 to run.
From @srherbener: I've heard requests for updating Altals from several sources, so we should get the full version number agreed upon. There currently exists versions 0.38.0 and 0.38.1. Is there any reason why we shouldn't go to the latests version: 0.38.1? Or are we waiting for another update?
Is version 0.38.1 good for your needs?

[ ] OOPS PR 2670 (@odlomax, @DJDavies2)
[x] JEDI model interface work (@fmahebert)
[x] SOCA (@travissluka)

All I need is something newer than the current 0.36, beyond that I don't think it matters to the oops::Diffusion

@odlomax just want to double check - when you say version 0.38, then 0.38.1 would be acceptable? Thanks!

@srherbener I will test the jedi-bundle with atlas 0.38.1 and confirm everything looks ok.

@srherbener I have tested jedi-bundle with atlas 0.38.1 and all looks good. It'd be great if @odlomax can confirm it looks good from the UKMO side as well.
Note that 0.38.1 is a minor bugfix on 0.38, so I see no reason to prefer 0.38.
In addition to the interpolator improvements that motivated the OOPS PR 2670 and this particular spack-stack issue, atlas 0.38+ also brings GPU related improvements, so we'll be happy to see this version for the GPU project too (though regardless we may end up working on custom branches).

I don't have edit permissions on the original issue, but please go ahead and check the "JEDI model interface work" box on my behalf. I am satisfied with this version.
As soon as we agree on a version here for spack-stack, I'll open a discussion so partners using their own envs know to prepare for a future atlas update.

I don't have edit permissions on the original issue, but please go ahead and check the "JEDI model interface work" box on my behalf. I am satisfied with this version.
As soon as we agree on a version here for spack-stack, I'll open a discussion so partners using their own envs know to prepare for a future atlas update.

@fmahebert thank you for testing 0.38.1! I checked the box. Also thank you for your upcoming help with coordinating the switch to the new atlas version!

@srherbener I have tested jedi-bundle with atlas 0.38.1 and all looks good. It'd be great if @odlomax can confirm it looks good from the UKMO side as well.
Note that 0.38.1 is a minor bugfix on 0.38, so I see no reason to prefer 0.38.
In addition to the interpolator improvements that motivated the OOPS PR 2670 and this particular spack-stack issue, atlas 0.38+ also brings GPU related improvements, so we'll be happy to see this version for the GPU project too (though regardless we may end up working on custom branches).

This all going well from my point of view now. I think there's a known orca issue. @twsearle, could you comment?

This all going well from my point of view now. I think there's a known orca issue. @twsearle, could you comment?

This is not so much an orca-jedi issue, as a deployment issue - we need to update our CI as the results of orca-jedi tests are impacted by the fixes in atlas 0.38.1. The changes are in progress and I don't think they should be a blocker.

@twsearle thank you for the response. Sounds like atlas 0.38.1 will be acceptable.
I propose that we target atlas 0.38.1 for spack-stack-1.8.0. Any objections?

@twsearle thank you for the response. Sounds like atlas 0.38.1 will be acceptable.
I propose that we target atlas 0.38.1 for spack-stack-1.8.0. Any objections?

I take the silence as "no objections" so the plan is to move to atlas 0.38.1 for spack-stack-1.8.0.

@srherbener just FYI we have fixed our orca-jedi CI issue so there are definitely no blockers from us now.

@twsearle thanks for the update


[SPARK-1987] EdgePartitionBuilder: More memory-efficient graph construction

https://issues.apache.org/jira/browse/SPARK-1987
To save overhead of Edge objects, separate an array of Edge objects into three arrays of srdId, dstId and data, for later EdgePartition(srcIdsTrim, dstIdsTrim, dataTrim, index, vertices).
To sort arrays directly, I use ParallelSorter from mockito.cglib
Can't compile at the moment and I don't really know to solve.
[info] Compiling 8 Scala sources to /home/xd/Developer/spark/graphx/target/scala-2.10/classes...
[error] /home/xd/Developer/spark/graphx/src/main/scala/org/apache/spark/graphx/impl/EdgePartitionBuilder.scala:49: type mismatch;
[error]  found   : Array[Array[_ >: ED with Long]]
[error]  required: Array[Object]
[error] Note: Array[_ >: ED with Long] <: Object, but class Array is invariant in type T.
[error] You may wish to investigate a wildcard type such as `_ <: Object`. (SLS 3.2.10)
[error]     val sorter = ParallelSorter.create(edgeArray)
[error]                                        ^
[error] one error found
[error] (graphx/compile:compile) Compilation failed
[error] Total time: 5 s, completed Sep 18, 2014 9:01:14 PM

@ankurdave @larryxiao This PR has gone stale.
Do we want to update it, or close and revisit it later?

@nchammas
The QA test result is not available now, I'll run the test again tomorrow.

Can one of the admins verify this patch?

Can one of the admins verify this patch?


index-url and extra-index-url in wrong order

If running the command poetry export --format requirements.txt --output requirements.txt with a poetry project that defines a default source as well as other sources, e.g.:
[[tool.poetry.source]]
name = "primary-pypi"
url = "https://private-primary/pypi/simple"
default = true

[[tool.poetry.source]]
name = "secondary-pypi"
url = "https://private-secondary/pypi/simple"

The resulting requirements.txt has the index-url and extra-index-url flags defined at the top of the file as such:
--extra-index-url https://private-primary/pypi/simple
--index-url https://private-secondary/pypi/simple

This is intended behaviour, as can be seen in test case test_exporter_exports_requirements_txt_with_default_and_secondary_sources.
However, because the extra-index-url is specified before index-url, pip does not recognise it when running the pip install --user -r requirements.txt. I can verify this because when I have a package in the secondary-pypi that's not in the primary-pypi, pip cannot find any versions of the package until I manually edit the requirements.txt file to switch the order of the flags (i.e. having index-url defined in the first line and extra-index-url defined below that). Once I re-order the flags in requirements.txt pip installs the defined packages without issue.

Sounds like a pip bug - I don't see any hint in https://pip.pypa.io/en/stable/reference/requirements-file-format/ that the order of these lines should matter.
If you agree - and are sure that this is really the problem - suggest raising a bug with pip saying that this should not make any difference.

Sounds like a pip bug - I don't see any hint in https://pip.pypa.io/en/stable/reference/requirements-file-format/ that the order of these lines should matter.
If you agree - and are sure that this is really the problem - suggest raising a bug with pip saying that this should not make any difference.

Agreed. I have lodged an issue on pip. I'll close this issue, and will re-open if pip decides this is a "feature not a bug" (in which case, the fix on their end will be to clarify this in their documentation).

I thought that this might have been fixed in Poetry 1.5.1 with the migration away from default/secondary, but it's not. I'm frustrated to see it's more of a pip problem, too.
Our default repo, which we had set to default = false, we've had to set to priority = "primary" in order to get the same requirements.txt output and keep in place our manual override of the default in pip settings to keep our builds from talking to PyPI.


Proper way to define types

Hello
When I define classes, I need to add some columns to every class. e.g. status, remark
To be simple, it goes like this.
class ModelBase extends Model<ModelBase> {
  @Column
  status: number;

  @Column
  remark: string;
}

class Foo extends ModelBase {
  @Column
  foo: string;
}

When I using v0.6.1, it's ok with var bar = new Foo ({ foo: 'foo' })
But with v0.6.3, I cannot compile because foo  doesn't exists in type FilteredModelAttributes<ModelBase>

Hey @urielvan, this is because you do not pass the generic type up to Model, so that the type information for the constructor typings (which are defined in Model)  cannot know of Foo's properties.
Try it like so instead:
class ModelBase<T extends Model<T>> extends Model<T> {
  @Column
  status: number;

  @Column
  remark: string;
}

class Foo extends ModelBase<Foo> {
  @Column
  foo: string;
}

@RobinBuschmann Thanks so much for the help ! 😄


Adds Terser Webpack plugin to drop console in production

Summary of changes

Removes console logs from bridge and stats dApp using Terser webpack plugin.

Proposed area of change

[x] apps/bridge-dapp
[x] apps/stats-dapp
[ ] apps/webbsite
[ ] libs/webb-ui-components

Reference issue to close (if applicable)

Closes #797

Screen Recording
https://user-images.githubusercontent.com/53374218/223024505-482fd57f-ce0d-4d59-ba0f-3e9606e77ef0.mp4

Code Checklist
Please be sure to add .stories documentation if any additions are made to libs/webb-ui-components.

[ ] I have added tests that prove my fix is effective or that my feature works
[ ] I have added necessary documentation (if appropriate)

@dutterbutter This only drops console logs (warn, error etc) but not the loggers. @AtelyPham suggests we keep logger info in production.


WRF-CMAQ: Average ELMO Output File Gives Erroneous Results

Description
It has been discovered that the ELMO output file gives erroneously low results (about 90% low) for all variables when the WRF-CMAQ model is used. This issue does not impact the standard offline CMAQ model, which applies to the vast majority of use cases.
Scope and Impact
If you are using WRF-CMAQ with CMAQv5.4, you should not trust the output data on the ELMO files for now.
Solution
The temporary solution is to continue using the output variables from CONC and ACONC if you are running WRF-CMAQ. Please also continue to use the SpecDef files with the combine utility from CMAQv5.3.3.
We will solve the bug in the WRF-CMAQ implementation of ELMO and issue the fix as a Pull Request to this repository.
Additional context
Again, this only impacts WRF-CMAQ with CMAQv5.4 for output from the ELMO processing module.

When is it expected to be repaired?

We have a proposed fix that has been tested and is currently under internal review. If you have a specific immediate need, let us know and we can send you the updates for your individual use.

My email is<EMAIL_ADDRESS>I am very willing to help you test together

Thanks for your offer! Please see Pull Request #181

This issue has been resolved in PR #181 which was merged into the CMAQv5.4+ branch.  The fix will also be included in the next CMAQ release.


Support QueueSort

QueueSort is used to build a priority queue in the scheduler to determine which Pod should be scheduled first.
Less is called very frequently and if we implemented QueueSortPlugin as we do for other extension points, it'd have a critical performance degradation in building the priority queue in the scheduler.
Concequently, I intentionally didn't include QueueSort in https://github.com/kubernetes-sigs/kube-scheduler-wasm-extension/issues/72, it's not as easy as other extension points.
This issue is to discuss how we deal with QueueSort.
/kind feature

/remove-lifecycle stale

/remove-lifecycle stale


Arduino: how can BLE Client detecting RSSI in Connecting with server,not only for scan?

I connect two esp32s through the BLE server to the Client, when i  use
int ble_rssi = myDevice->getRSSI();
Serial.println(ble_rssi);
in the loop function, become the same value which got  in the Scan
I want the Client to always test the signal strength of the server. Is this possible?
thank you in advance

what is myDevice? BLEClient, BLEServer, BLEAdvertisedDevice?

@chegewara hello, it's BLEAdertisedDevice.
myDevice = new BLEAdvertisedDevice(advertisedDevice);
I want the client to keep detecting RSSI of the server while it is connected, but I failed.
Is this possible?
thank you in advance

https://github.com/nkolban/esp32-snippets/blob/810aeb810a15ff6cf8742080ea5a413447cd0b92/cpp_utils/BLEClient.cpp#L366
You need to use it on connected client.
myDevice = new BLEAdvertisedDevice(advertisedDevice); is static structure of data, never updated.

I am using  ble_client   in the example. It uses BLEDevice. https://github.com/nkolban/ESP32_BLE_Arduino/blob/master/examples/BLE_client/BLE_client.ino
How can this Code be cloned from BLEClient to BLEDevice. I am a beginner and im not very clear how to do it. Can someone help me. thanks

@chegewara Thank you for your reply

i want to try it in loop();
BLEClient*  pClient  = BLEDevice::createClient();
int rssi= pClient->getRssi();
Serial.println("RSSI Value is :" + rssi);

Use only this in loop:
int rssi= pClient->getRssi();
Serial.println("RSSI Value is :" + rssi);

@chegewara  Thank you I was successful
I defined it globally   BLEClient* pClient, and use in loop:
if (connected) {
int rssi = pClient->getRssi();
Serial.println(rssi);

}

@DeJason-lsng What he meant with globally defined is he declared the object outside of the loop and setup. This enables a global access for every call/use on it.
Ps. Sorry, Im not so good on what they are called.


tests: shared build directory

Note to sel: on OSX, it reduces the time from 343 seconds to 89 seconds.


python3Packages.pelican tests fail

Describe the bug
Building pelican fails due to two broken tests on master and the 20.03 channel.
To Reproduce
Steps to reproduce the behavior:
> nix run -f channel:nixos-unstable python3Packages.pelican -L
(...)
ython3.7-pelican> test_custom_pagination_pattern (pelican.tests.test_paginator.TestPage) ... ok
python3.7-pelican> test_save_as_preservation (pelican.tests.test_paginator.TestPage) ... ok
python3.7-pelican> test_basic_generation_works (pelican.tests.test_pelican.TestPelican) ... FAIL
python3.7-pelican> test_custom_generation_works (pelican.tests.test_pelican.TestPelican) ... FAIL
python3.7-pelican> test_cyclic_intersite_links_no_warnings (pelican.tests.test_pelican.TestPelican) ... ok
python3.7-pelican> Test that a warning is issued if MD_EXTENSIONS is used ... ok
(...)
python3.7-pelican> Ran 251 tests in 6.438s
python3.7-pelican> FAILED (SKIP=19, failures=2)
builder for '/nix/store/qjf1b71v9iy12jgv3qcfhlgrchvf9pcy-python3.7-pelican-4.2.0.drv' failed with exit code 1; last 10 log lines:
  pelican.generators: INFO: Copying /build/source/samples/content/extra/robots.txt to robots.txt
  pelican.utils: INFO: Copying /build/source/samples/content/pictures/Fat_Cat.jpg to /build/pelicantests.fanq_r16/pictures/Fat_Cat.jpg
  pelican.generators: INFO: Copying /build/source/samples/content/pictures/Fat_Cat.jpg to pictures/Fat_Cat.jpg
  pelican.utils: INFO: Copying /build/source/samples/content/pictures/Sushi_Macro.jpg to /build/pelicantests.fanq_r16/pictures/Sushi_Macro.jpg
  --------------------- >> end captured logging << ---------------------

  ----------------------------------------------------------------------
  Ran 251 tests in 6.438s

  FAILED (SKIP=19, failures=2)
[0 built (1 failed)]

Metadata
Please run nix-shell -p nix-info --run "nix-info -m" and paste the result.

system: "x86_64-linux"
host os: Linux 5.3.16, NixOS, 19.09.2260.3b9b10e49be (Loris)
multi-user?: yes
sandbox: yes
version: nix-env (Nix) 2.3.3
channels(root): "nur, home-manager-19.09, lorri, mozilla-overlay, nixos-19.09.2260.3b9b10e49be, nixos-hardware, nixos-unstable-20.09pre217261.a2e06fc3423, nixpkgs-19.09.2260.3b9b10e49be"
channels(addy): "home-manager-19.09, lorri, mozilla-overlay, nixos-19.09.2284.bf7c0f0461e, nixos-hardware, nixos-unstable-20.09pre217537.d96bd3394b7, nixpkgs-19.09.2284.bf7c0f0461e, nur"
nixpkgs: /home/addy/.nix-defexpr/channels/nixpkgs

Maintainer information:
# a list of nixpkgs attributes affected by the problem
attribute:
  - python3Packages.pelican
# a list of nixos modules affected by the problem
module:

cc @prikhi

Searching for workarounds on 20.03, I can confrim this is the case for python 3.6, 3.7 and 3.8.

Could not find out what was actually causing the test to fail. :/ As a workaround, the pelican checks can be disabled, and pelican generally seems to still work for me, so it seems like it is nothing too serious.
(python.pkgs.pelican.overrideAttrs (oldAttrs: { doCheck = false; doInstallCheck = false; } ))

I was finally able to trace it to pygments update. E.g. I was not able to build pelican on commit abc938446eb28bbe1f040757589e3192a4c10ec6, but was able with previous one. So we can re-import pygments 2.4 or skip those checks for now and wait for next release of pelican. I see that fix for this issue is already in pelican repository.

Another option would be to fetch that change as a patch for the pelican derivation, if it applies cleanly

I've extracted patch from https://github.com/getpelican/pelican/commit/9a0a08f460c784053b113a8de709eb4b1bdb6b80. Now I able to build and pass tests without problem. Tested on both master and release-20.03.

A slight improvement would be to get the patch via fetchpatch like in https://github.com/NixOS/nixpkgs/blob/df81d9a41c94792e02527dc9fa105153155f2e7c/pkgs/applications/office/scribus/unstable.nix#L46
But already a big thanks for tracking this down. ;)

Closed in favor of PR #87600


HmIP-SCTH230 - Formatting of ppm value

Home Assistant version (if applicable):
2021.11.5
Describe the bug

The upper two sensors are Netatmo, the third the HmIP-SCTH230.
As you can see, there is always an appended ",0" for the value, suggesting more precision than it has.
Expected behavior
In the CCU only integers are shown:

As this is fake precision, it would be better to use integers as well.

I think this is an UI issue of Home Assistant. It seems as it is displaying decimals for values greater than 999, even though the thousands-separator would be sufficient.

It also happens <999:

And since the Netatmo integrations manages to show it without ",0" I would say it's integration specific.

Well, it does not in the screenshot above. That's why I thought this might be the reason. 🤔 Nevertheless, I still think this is an issue on the Home Assistant side. In pyhomematic we just forward the value we get from the CCU. How are the values displayed with the new custom integration in comparison?

Just installed the new hahomematic custom integration and it shows them also with the appended ",0":

I think this is where the formatting is coming from. But I have never worked with the UI part of Home Assistant. So I can't help with that. And I don't know how it would be possible to tell HA to render certain numbers differently.

How is the value reported from hahomematic side? https://github.com/home-assistant/frontend/blob/e94fc493b8b49ee5e85ecdf1db664282fa67efd1/src/common/number/format_number.ts#L99 says it's keeping the trailing zeros if they are present in a string numeric value.

It's a FLOAT. So it's really the device reporting it this way.

So it's technically correct to add the trailing zero, I see. But doesn't make much sense because the device only ever returns values with a leading zero and even the original web interface doesn't show it (see screenshot above). Any idea how this could be handled? Is there a possibility included in hahomematic for device specific workarounds for this kind of weirdness?

Well, as sooner or later the pyhomematic based integration will be obsolete anyways, I won't address this minor cosmetic issue. Feel free to create an issue for hahomematic. Maybe Markus has an idea on how to solve this elegantly.
The correct way to solve this would actually be, that eq3 changes the type of the parameter to be an integer. But that will probably never happen. We can't use any generic approach for this like always converting floats to ints, because obviously other float-based parameters make use of the decimals. So this would be some sort of custom device (like blinds or thermostats). And honestly, I don't think this is worth the effort.


Sub-directory names update on SCIP optimization suite 4.0.1

Sub-directory names do not include the version number, causing make to fail to create the required symbolic links

oh right! Thanks! forgot to update this. We can also remove the *, can you do that please?

We could, but then it would not work anymore for 4.0.0, right?

yes, but that is alright, we do not really provide support for 4.0.0 anyway.

Ok, but then we would also need to update the readme of CSIP and SCIP.jl

You are right. I'll do it later. Let us merge this now. Thanks!


Add zap stanza for vagrant to remove ~/.vagrant.d

homebrew-cask/Casks@cf23ebeb66acaa860fc30b40fc4d1e1a5b0d2460 vagrant.rb doesn't currently have a zap stanza and leaves a ~/.vagrant.d folder after brew cask uninstall vagrant.
~/.vagrant.d stores Vagrant Boxes and/or full Virtual Machine images.
I can provide a pull request but it's not yet clear to me whether or not this folder location is configurable and/or if this is an accepted usage of the zap stanza given this folder contains user created data.

it's not yet clear to me (…) if this is an accepted usage of the zap stanza given this folder contains user created data.

Neither to us. Care to voice your opinion?

A decision has been made. Care to submit the PR to add those directories?


inverted navigation arrows for right to left languages

When datepicker is rendered under dir="rtl" (for example in an application in arabic language) the navigation arrows used to increment/decrement the month were not inverted.
The change consists in rendering the buttons in a different order by playing on the css.

This looks good, if you can add a test we can merge it.


Fix counters in callback streaming QPS benchmarks

Latency histograms are supposed to be for each ping-pong pair, not from the start of the RPC (otherwise, the latencies all look like 1 minute, etc, as the test goes on)

Issues: #17681 ( https://source.cloud.google.com/results/invocations/9c2251eb-c76a-4ff8-a420-932dc4738c40/targets/github%2Fgrpc%2Fcpp_linux_tsan_native_x64_clang7.0/tests )


Update openai-embeddings.adoc

update azure openai to openai
Thank you for taking time to contribute this pull request!
You might have already read the [contributor guide][1], but as a reminder, please make sure to:

Sign the contributor license agreement
Rebase your changes on the latest main branch and squash your commits
Add/Update unit tests as needed
Run a build and make sure all tests pass prior to submission

Thanks @wstever

谢谢你的邮件，我收到啦


Update installation instructions

The installation steps are a bit outdated: https://packit.dev/docs/guide/#have-packit-tooling-installed-locally

We don't need to enable updates-testing repo.
We now have Copr projects for master and releases.

(You can look at the README of packit.)

+1 I added it to the upstream project


No gallery specified.

After exhentai huge updates few days ago it's causing the userscript to stop working properly, when I tried to add a gallery to my Favorites it returned a "No gallery specified." message with a blank white background... Can you please look into this, thanks.

Oh yeah you're right. I will asap look into this will probably take me a few days though sadly.
probably should clean this up anyways. thanks for the report.

Still getting this error.

The bug itself should know be fixed. Sorry for the delay.
Design is still inconsistent and I haven't heavily tested it.
Will revamp a lot of the code and hopefully fix anything else in the coming days.


Make CircuitBreaker.setState public.

Makes the CircuitBreaker.setState method public, to allow developers to implement functionality that can change the breaker's state from outside of the breaker.

@Joel-Duff is this pr violating the breaker rule? Like we can change the state even it is not successful.

it's not a good idea to make it public here. the state shoud be controlled by the circuit breaker. it should be internal logic.


feat: replace secret references in the preview

What type of PR is this?

What this PR does / why we need it:
Which issue(s) this PR fixes:

Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?

Additional documentation e.g., design docs, usage docs, etc.:

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

11 of 31 (35.48%)  changed or added relevant lines in 2 files are covered.
3 unchanged lines in 1 file lost coverage.
Overall coverage increased (+0.03%) to 54.217%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

pkg/engine/operation/graph/resource_node.go
10
30
33.33%

Files with Coverage Reduction
New Missed Lines
%

pkg/engine/operation/parser/parser.go
3
79.27%

Totals

Change from base Build<PHONE_NUMBER>:
0.03%

Covered Lines:
9109

Relevant Lines:
16801

💛  - Coveralls


zoom password leak

for the Join Zoom with DTMF Zoom Tools project:
the zoom password is included in the zoomcrc.com url, like<EMAIL_ADDRESS>this issue prevents this script from being used in public meeting rooms as meeting passwords would be leaked in the call history.
instead, consider using an event listener for CallSuccessful and then dial the password via DTMF

function sleep(ms) {
    return new Promise(resolve => setTimeout(resolve, ms));
}

async function dialPassword(){
    if(meetingpassword.length > 0){
      await sleep(500); // do not type password right on connect, on slower units like DX80 the first digit would get cut off
      pressNumbers(meetingpassword + "#");
      meetingpassword = "";
  }

}
/* trigger when a call is successful */
xapi.event.on('CallSuccessful', (event) => {
  dialPassword();
});

oops wrong repo. where am i???!


about dragged.lobiPanel

Thank you for your excellent plugin. Now, I'm testing it. One issue exists on my environment. My environment is same with "Multiple panels with drag & drop" example.
http://lobianijs.com/site/lobipanel#lobipanel-multiple
When I dragged panel, "dragged.lobiPanel" event do not occur. But, another panel events occur.
For example, when I dragged panelA from left side to right side, events of panelB and panelC occur.
Do I have a basic misunderstanding about "dragged.lobiPanel" event?
Best regards.

Ok. I agree. There is problem in this event. Arguments are not given correctly

Thanks arboshiki.


New and improved Praxis generated docs

New docs accessible through bundle exec rake praxis:docs:generate_beta:

More compact format available, and

1 file per api version: including info, resources, schemas and traits.
1 single index file with global info plus just a list of version names
Follow reachable types through memory objects for more robust discovery

NOTE: current doc generation tasks and code are intact. We will move to the new format once we have adapted the doc browser for it

Old and new experimental docs now include examples for payloads, responses, headers, url parameters...etc
Signed-off-by: Josep M. Blanquer<EMAIL_ADDRESS>

Why not merge this?

LGTM


Proposal: An alias for stuct{} similar to "any" for interface{}

e.g. nothing, void, empty or null

I think it can add a bit of complexity. What's good about Go is that it's very minimal in terms of its keywords. Go's strength lies in its elegant simplicity, and the introduction of new aliases might disrupt this balance.


update test description

Coverage remained the same at 100.0% when pulling e587521eb3f1eb609982cdb3a8129eb4c3b45cc0 on staging into 1a9bc550ea0934691934dfbef2c406211e1419f4 on master.


Component: Embedded Video Player Design QA testing

User Story

As a [user role below]:
DDS Designer and Developer

I need to:
test the Embedded Video Player

so that I can:
be sure the developer's code correctly works as designed

Additional Information

alpha Dev link (#1108 )
January 8 & 13 Design meeting notes and recording Box Link
Functional specs (#1066 )
Media component designs

Tasks
Ensure the Embedded Video Player component has been tested and reviewed by design + dev.
Acceptance criteria

[ ] Pattern is reviewed by designer and design defects are identified
[ ] New issues are opened to log individual defects
[ ] Screenshots of as-is and to-be design should be added to the issue when needed
[ ] Developer associated with building the pattern is assigned to the new issues
[ ] Appropriate labels are added to the issue  eg.  bug, dev

@jeffchew @photodow I left a comment in #1066 but it's closed, and I can't find a task here for devs to update Image, Video, Media, and Media Switcher functional specs?
It would be good to update the link to the correct and latest functional spec in this story.   At the moment, I placed previous functional specs here in this folder:
https://ibm.box.com/s/gpzvplwa5gyj1vvg1adl5apqmcnfa686


deps: Removed varnish as it was moved to the operations collector

Proposed Change
Removed Varnish as it was added to the operations collector in https://github.com/GoogleCloudPlatform/opentelemetry-operations-collector/pull/94. This will be imported into the collector in a future PR.
Checklist

[ ] Changes are tested
[ ] CI has passed

Is there any reason to not import now rather than later?

Yeah two reasons:

We weren't importing it before so. If we were I would have done the full swap.
There's a chance we'll hit some issues with otel imports that we'll have to solve when v0.50.0 releases this week so I'm waiting on that to only solve them once.


FIX/ENH: picking channels should update the info['bads']

But it does not.
This can lead to bugs.
The culprit is pick_info, it does not look at the bads.
Only the picked bads should remain.
cc @mainakjas @teonlamont @Eric89GXL

see https://github.com/mne-tools/mne-python/pull/2148 :)
@jmontoyam needs to finish. Or take over of you're in a hurry.

Ahh this was it. Closing then.


⚠ Empornium has degraded performance

In 058ef04, Empornium ($EMP) experienced degraded performance:

HTTP code: 200
Response time: 18550 ms

Resolved: Empornium performance has improved in fdd4c0f after 33 minutes.


Target .Net Core 3.0 desktop

Fixes #54.

Targeting netcoreapp3.0 with wpf does mean we lose out of x-platform ability, at least until we can use system.xaml as a separate nuget component.

Yes, but I've no better idea. This is a clean way to bring System.Xaml into the mix. In theory System.Xaml shouldn't depend on anything Windows specific, but who knows :)


Better profiler docs

on how to run all the pieces for each connector.
We need to migrate some more info from gitbook to the new docs

New API and workflow should also be added in 0.12.0 release


Instructions with less indentation than previous ones cannot be written to the board

Example: try to write the attached program to the board
allumer_tout.xml.zip

Fixed with https://github.com/claudiosousa/HepiaBlocks/commit/82a5f0f78bea1aef32a778a60bca10f48a65708d


fix: Call onFailure for code flow too

Issue #, if available:
Fixes #176
Description of changes:
parseCognitoWebResponse doesn't call onFailure for code, only for token.
This PR adds error checking for code flow.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Duplicate of #135


customresourcedefinitions.apiextensions.k8s.io "certificates.certmanager.k8s.io" already exists

Bugs should be filed for issues encountered whilst operating cert-manager.
You should first attempt to resolve your issues through the community support
channels, e.g. Slack, in order to rule out individual configuration errors.
Please provide as much detail as possible.

Describe the bug:
I've installed two cert-manager into different custom namespaces (stage, demo).
the first installment into stage works flawless.
helm upgrade --namespace stage --install --wait --set ingressShim.defaultIssuerName=letsencrypt-prod --set ingressShim.defaultIssuerKind=Issuer --set rbac.create=false --set serviceAccount.create=false stage-cert-manager stable/cert-manager

the second installment into demo fails
helm upgrade --namespace demo --install --wait --set ingressShim.defaultIssuerName=letsencrypt-prod --set ingressShim.defaultIssuerKind=Issuer --set rbac.create=false --set serviceAccount.create=false demo-cert-manager stable/cert-manager
> Error: release demo-cert-manager failed: customresourcedefinitions.apiextensions.k8s.io "certificates.certmanager.k8s.io" already exists

That's the existing customresourcedefinitions in my cluster:
kubectl get customresourcedefinitions --all-namespaces=true
NAME                                AGE
apprepositories.kubeapps.com        2d
certificates.certmanager.k8s.io     19m
clusterissuers.certmanager.k8s.io   19m
issuers.certmanager.k8s.io          19m

And this the definition of certificates.certmanager.k8s.io:
apiVersion: apiextensions.k8s.io/v1beta1
kind: CustomResourceDefinition
metadata:
  creationTimestamp: 2018-09-06T09:22:39Z
  generation: 1
  labels:
    app: cert-manager
    chart: cert-manager-v0.4.1
    heritage: Tiller
    release: demo-cert-manager
  name: certificates.certmanager.k8s.io
  resourceVersion: "7379719"
  selfLink: /apis/apiextensions.k8s.io/v1beta1/customresourcedefinitions/certificates.certmanager.k8s.io
  uid: 668f36bf-b1b6-11e8-a174-ee96761aa8f6
spec:
  additionalPrinterColumns:
  - JSONPath: .metadata.creationTimestamp
    description: |-
      CreationTimestamp is a timestamp representing the server time when this object was created. It is not guaranteed to be set in happens-before order across separate operations. Clients may not set this value. It is represented in RFC3339 form and is in UTC.

      Populated by the system. Read-only. Null for lists. More info: https://git.k8s.io/community/contributors/devel/api-conventions.md#metadata
    name: Age
    type: date
  group: certmanager.k8s.io
  names:
    kind: Certificate
    listKind: CertificateList
    plural: certificates
    shortNames:
    - cert
    - certs
    singular: certificate
  scope: Namespaced
  version: v1alpha1
  versions:
  - name: v1alpha1
    served: true
    storage: true
status:
  acceptedNames:
    kind: Certificate
    listKind: CertificateList
    plural: certificates
    shortNames:
    - cert
    - certs
    singular: certificate
  conditions:
  - lastTransitionTime: 2018-09-06T09:22:39Z
    message: no conflicts found
    reason: NoConflicts
    status: "True"
    type: NamesAccepted
  - lastTransitionTime: null
    message: the initial names have been accepted
    reason: InitialNamesAccepted
    status: "True"
    type: Established
  storedVersions:
  - v1alpha1

I guess the certificate is now assigned with the demo instance, right? -> release: demo-cert-manager
Expected behaviour:
I guess the cert-manager should be installable without issues in two namespaces.
Steps to reproduce the bug:
see above.
Anything else we need to know?:
Environment details::

Kubernetes version (e.g. v1.10.2): 1.11.2
Cloud-provider/provisioner (e.g. GKE, kops AWS, etc): azure
cert-manager version (e.g. v0.4.0): 0.4.1
Install method (e.g. helm or static manifests): helm

/kind bug

I could disable the creation of the custom resource with "createCustomResource=false" but I can't find any documentation what would be the impact of it. could you help me out?

The issue with this is that the issuer type is now not recognizable...
error: unable to recognize "/home/vsts/work/r1/a/_HelmConfigs/shared/issuer.yaml": no matches for kind "Issuer" in version "certmanager.k8s.io/v1alpha1" /opt/hostedtoolcache/kubectl/1.11.2/x64/kubectl failed with return code: 1

@SeriousM for what it's worth, I had this issue when running cert-manager chart version 0.4.1 Once I updated my help repo & deployed 0.5.0 this issue disappeared.

I am I am getting this issue even on 0.5.0

Same issue.

Same issue on v0.5.0, is there a workaround?

Same issue on v0.5.0

I fixed worked around this with:
kubectl get customresourcedefinition
kubectl delete customresourcedefinition xxxxxxxx

But that may well do horrible things if used in production, I don't know.

I fixed worked around this with:
kubectl get customresourcedefinition
kubectl delete customresourcedefinition xxxxxxxx

But that may well do horrible things if used in production, I don't know.

This works.. Thanks for sharing

Is there any way this can be tackled by the cert-manager team? This is really painful in practice to have to delete things by hand and co.
There seems to be a beginning of solution in this comment: https://github.com/jetstack/cert-manager/issues/870#issuecomment-419092047
@munnerz ? :)

There's an issue tracking this upstream: https://github.com/helm/helm/issues/4259
The only solution for mitigating the issue currently is to delete the CRD, which will delete all data.
The 'proper' workaround for the time being is something like:
$ kubectl get issuer,clusterissuer,certificate -o yaml --all-namespaces > cert-manager-resources-backup.yaml
$ kubectl delete crd issuer,clusterissuer,certificate
$ {run cert-manager install via Helm}
$ kubectl create -f cert-manager-resources-backup.yaml

Workaround.
I have made a little check before making Helm release.
kubectl api-resources -o name | grep certificates.certmanager.k8s.io
create_custom_resource=$( if [[ $? == 0 ]]; then echo false; else echo true; fi; )
...
helm upgrade --install \
...
 --set cert-manager.createCustomResource=$create_custom_resource
...

I had this problem because I ran the initial command and forgot to set rbac=false - helm managed to install these custom resources and purge did not clean up after it. 🤔
I tried with `--set cert-manager.createCustomResource=false' but was still the same error 🤔
So i followed the tip kubectl get issuer,clusterissuer,certificate -o yaml --all-namespaces > cert-manager-resources-backup.yaml and the yaml was empty.. so nothing important there 😄
I just deleted the custom resources and did the helm package again with rbac=false and it installed properly.
Who has the responsibility of cleaning up of custom resources after delete / purge?

We’ve changed the way we install the CRDs in the helm chart for the next
release due to issues with Helm. You can see a bit more info here!
https://github.com/jetstack/cert-manager/pull/1138
On Thu, 6 Dec 2018 at 10:44, Piotr Kula<EMAIL_ADDRESS>wrote:

I had this problem because I ran the initial command and forgot to set
rbac=false - helm managed to install these custom resources and purge did
not clean up after it. 🤔
I tried with `--set cert-manager.createCustomResource=false' but was still
the same error 🤔
So i followed the tip kubectl get issuer,clusterissuer,certificate -o
yaml --all-namespaces > cert-manager-resources-backup.yaml and the yaml
was empty.. so nothing important there 😄
I just deleted the custom resources and did the helm package again with
rbac=false and it installed properly.
Who has the responsibility of cleaning up of custom resources after delete
/ purge?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/jetstack/cert-manager/issues/870#issuecomment-444829107,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAMbP_f6SDvz-Y2imDZteoma04aDDsViks5u2PT0gaJpZM4WcmsP
.

Ran into these symptoms deploying on a new/clean aks cluster today and the above solution.  I was able to work-around by first doing a helm install --set createCustomResource=false, then following that up with a helm upgrade without setting that variable.

I had the same problem with a fresh install on a aws cluster. As @michaelsteven I solved it with:
helm install --name cert-manager --namespace yournamespace stable/cert-manager --set createCustomResource=false
helm upgrade --install --namespace yournamespace cert-manager stable/cert-manager --set createCustomResource=true

I had the same problem with a fresh install on a aws cluster. As @michaelsteven I solved it with:
helm install --name cert-manager --namespace yournamespace stable/cert-manager --set createCustomResource=false
helm upgrade --install --namespace yournamespace cert-manager stable/cert-manager --set createCustomResource=true

Yep, works for me as well.  But what about setting ingressShim.defaultIssuerName and ingressShim.defaultIssuerKind?

This is a bug introduced on Helm v2.12.0 and is now corrected on v2.12.1. Just upgrade Helm and it will work.

Is this still required after the 2.12.1 revert, or should #1138 be removed? https://github.com/helm/charts/pull/10255 open to remove the existing kubectl apply requirement

Also having this issue, using Windows and it doesn't look like 2.12.1 is out on the Win binary release yet. It states its there but when you download, unzip and upgrade its still on 2.12.0.

Any ideas when this can be fixed?

We've extended our upgrading documentation and installation documentation to include troubleshooting tips.
Please carefully read these, including the troubleshooting page, if you are running into issues 😄
The #cert-manager slack channel on slack.k8s.io is also a great place to get support if you're still having trouble 😄

My shortcut to purge:
kubectl delete customresourcedefinitions clusterissuers.certmanager.k8s.io issuers.certmanager.k8s.io certificates.certmanager.k8s.io
helm delete --purge cert-manager
kubectl delete namespaces cert-manager

1 minute after I've deleted customresourcedefinitions something creates all of it again. Every time. Have any idea what is it?
I try to install cert-manager / release-0.11, it uses *.cert-manager.io CDRs but then I try to create apiVersion: cert-manager.io/v1alpha2  kind: ClusterIssuer it doesn't create instance becouse of old clusterissuers.certmanager.k8s.io .
How I can stop recreating of *.certmanager.k8s.io CDRs ?
Thanks


Add authors - enable quick access to ORCID values

[ ] After having the orcid added to the user profile, the default value while adding the authors should be that orcid.

[ ] An alternative would be to suggest a list of recently used orcids and enable the user to pin some of them without the need to access the user profile.

screen-capture (7).webm

merged and tested


[New API] : Galaxy API

Brief Description 🤓
The Galaxy Search API is a simple web service that allows users to search for information about galaxies. It provides endpoints for searching, creating, updating, and deleting galaxy records.
How will you develop it?🤩

Setup:

Installation: Install Node.js and required packages (Express.js, Body-parser, etc.).
Project Structure: Organize files and directories for the API code.
Sample Data: Define sample data for galaxies to use during development.

Implementation:

Define Endpoints: Create routes for handling various CRUD operations on galaxies.
Data Handling: Implement logic for handling data (e.g., fetching, creating, updating, deleting).
Error Handling: Implement error handling to respond appropriately to client requests.
Testing: Test each endpoint to ensure it works as expected using tools like Postman or cURL.

Frontend Integration:

HTML & CSS: Create a simple HTML form for user input and apply CSS for styling.
JavaScript: Write JavaScript code to handle user input, send requests to the API, and display results.

Deployment
No
Select the open source program you are contributing to
Other
Code of Conduct

[X] I follow CONTRIBUTING GUIDELINES of this project.

Greetings @Asymtode712🎀 ! , We are excited to have you dive into another issue with us!🚀
Your involvement in our project has been invaluable, and we're confident that your skills and insights will help us conquer this challenge😇.  Use command /gssoc24 to self assign the issue.  This issue represents an exciting opportunity for us to improve and enhance our project, and we are thrilled to have you on board.
We request you to follow CONTRIBUTING GUIDELINES.
Looking for your PR soon!
In case of any issues, you can contact us on Discord.❣

/gssoc24

Hey @Asymtode712 ! I wanted to inform you that we have closed issue.Thank you for your understanding, and we look forward to your continued engagement with our repository🤗.
In case of any issues, you can contact us on Discord.
Thank you! ❣
Happy Coding! ✨
Will See you soon❣


event + parameter request - table 61 "Electronic Document Format" - GetAttachmentFileName() - OnBeforeGetAttachmentFileName(RecordVariant, ...)

Please add this event so that we can customise filenames used when downloading PDFs or creating zips of multiple PDFs.
procedure GetAttachmentFileName(DocumentNo: Code[20]; DocumentType: Text; Extension: Code[3]) Result: Text[250]
var
    FileMgt: Codeunit "File Management";
    IsHandled: Boolean;
begin
    OnBeforeGetAttachmentFileName(DocumentNo, DocumentType, Extension, IsHandled, Result);

    if IsHandled then
        exit;

    exit(
      CopyStr(
        StrSubstNo('%1 - %2 %3.%4', FileMgt.StripNotsupportChrInFileName(CompanyName), DocumentType, DocumentNo, Extension), 1, 250));
end;

published as
[IntegrationEvent(false, false)]
local procedure GetAttachmentFileName(
    DocumentNo: Code[20]; DocumentType: Text; Extension: Code[3];
    var IsHandled: Boolean; var Result: Text[250])

Thanks!

Actually, this will be of limited usefulness without knowing the record being printed. Can this function be updated to take a RecordVariant: Variant, and table 77 "Report Selections" be updated to pass that from its callers, so that we can then e.g. include the customer's name in the case of sales invoices, etc.

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.


Addr && be not stable during read req

I'm seeing data_addr_o and data_be_o change, while data_req_o is high, and data_gnt_i has not been received.
Is it possible I'm misreading the spec?  (or that there are illegal things I might have in the environment which could cause this?)
Thank you.

Hi @elchanan18 ,
thanks for reporting this issue.
The address changing in Cycle 5 with request high but without getting a grant does indeed not look good. Would you mind to provide some more details? Ideally a VCD file for the whole processor? This would help me to look into it.
Best regards,
Pirmin

Hi Pirmin,
Thanks for the quick response.
Is it possible to attach a VCD file to this thread?  (about 75K)

Yes, that should work. You can just attach it here.

I had to rename the file type to .txt.
It would let me drag a .vcd
addr_not_stable.txt

Thanks for uploading the VCD (to get around the restriction regarding the name and save some space, you can also do a zip).
I had a look on the VCD. The problem is complicated. The core tries to do a non-aligned load. Non-aligned loads are split into two consecutive aligned loads. The first of these two loads fails (the bus returns an error in data_err_i). To store the faulting address in the mtval CSR, the LSU cannot store the address incoming for the second load. This results in the output address being changed despite not getting a grant. This could be solved by just aborting the LSU operation on the error.
What makes the situation more complicated is that in your case, while the LSU informs the controller (ibex_controller.sv) about the load error, the controller is not sensitive to this information as it is in another state (DBG_TAKEN_ID instead of DECODE). This is part of a bigger problem we currently have in the controller. There are other issues open because of the same thing. I am working on it.
Best regards,
Pirmin

Hi @elchanan18
I have reworked the faulty controller FSM to solve the second part of the problem you reported. However, this fix depends on other changes currently under review here #120 . Thus I did not create a PR for these latest changes.
Nevertheless, the changes are available on my development branch here: https://github.com/vogelpi/ibex/tree/vogelpi-dev
Would you mind to checkout this branch and give me some feedback if it properly works in your setup?
Best regards and have a nice weekend,
Pirmin

Here's what I'm getting now.

addr_stable.zip

Thanks for getting back, I obviously had made an error before. Fixed that now. You can retry, be careful though, I did a force push to my dev branch.

I think I got the new code.

addr_stable2.zip

Thanks @elchanan18 !
I analyzed the waves. Behavior of the processor looks good now.

It jumps into debug mode at the beginning and then reads a fence instruction with bits [14:12] != 000.
This is illegal. The core thus raises an exception and jumps into the debug-mode exception handler (at address 0x1A110808).
The first instruction in there is a LOAD, which returns an error from the bus.
This again raises an exception, the core jumps back to the debug-mode exception handler (again at address 0x1A110808).
The first instruction it gets now from memory is a JAL. This is strange. As the IF stage reads at the same address as before but gets a different value from memory. Is this to be expected in your setup?
Anyway, it computes the correct target and stores the PC in a register 1.
The core then jumps to the computed target.

Is it expected in your test setup that the memory returns a different value in 5 and 3? If not, this could mean we have a new bug in the IF stage. Please let me know.
Best regards,
Pirmin

Hi.  No, I'm using Formal, and not restricting reads to return the same data.
Are you saying that you made another fix, or that what I'm seeing now is correct?
If the latter, is it OK for addr and be to change w/o gnt ?

If the latter, is it OK for addr and be to change w/o gnt ?

yes, please see https://ibex-core.readthedocs.io/en/latest/instruction_fetch.html
"The IF protocol differs from the LSU protocol in that the address can change while the request is valid (instr_req_o is high)."

Right.  For instr it would be OK.  But we're looking at the LSU data interface.

Hi @elchanan18,
yep that is still wrong. I did not see it on Friday sorry. But thanks for getting back. I am working on a fix for this now.

@elchanan18 ,
I fixed the problem. The problem was that while the LSU aborted the first failing misaligned transaction, some internal control logic did not get cleared. This prevented the next misaligned transaction to be recognized as such.
I again force-pushed to my dev branch in case you want to retry execution.
Best,
Pirmin

Hi,
Now I'm getting an issue with byte enables.

addr_stable3.zip

Thanks @elchanan18 , also this should be fixed now.

This looks better.  I've been running Formal for over an hour, and it hasn't found a counter-example yet.  (the other failures popped up in a few seconds)

Confirmed.  After 2 hours, Formal says it will never happen.

Great! Thanks a lot @elchanan18 , your help is much appreciated!
I consider this issue solved, but I'll keep the issue open until the bug fixes are merged into master.


#44 issue:Error Message Line Numbers

This is the kind of change we're looking for, it just doesn't deal with it everywhere. Check line 162 of Lexer.java. Fix that line and you'll be good to go.

Hi, I have made changes in Lexer.java line 162.


New logo for Hammer

Coverage remained the same at 73.256% when pulling 1f8ad1ee066122d4b3616a009281771b7e041abd on reallinfo:master into 2ce48ec382f3849ab4a936be251871a116cfbfe0 on ExHammer:master.


Add arrow-down icon & decoration for selector

Please provide proper description along with screen shots.
Explain what your change does and test it one different devices and provide screen shtos


Support multi-package action deployments or add an error message

Describe the bug
If multiple OpenWhisk packages are defined in the manifest.yml, the deployment succeeds but actions that are not in the first package will not be built correctly.
This might lead to unexpected bugs because the user might think we support multi-package deployments.
To Reproduce

aio app init
rewrite the manifest.yml:

packages:
  package1:
    license: Apache-2.0
    actions:
      generic:
        function: actions/generic/index.js
        web: 'yes'
        runtime: 'nodejs:10'
        inputs:
          LOG_LEVEL: debug
        annotations:
          final: true
  package2:
    license: Apache-2.0
    actions:
      generic2:
        function: actions/generic/index.js
        web: 'yes'
        runtime: 'nodejs:10'
        inputs:
          LOG_LEVEL: debug
        annotations:
          final: true

aio app deploy --skip-static

➜  ~/work/junk-apps/a aio app deploy --skip-static
> Build actions
ℹ dist/actions/generic.zip
✔ Build actions

> Deploy actions
ℹ Info: Deploying package [package1]...
ℹ Info: package [package1] has been successfully deployed.

ℹ Info: Deploying package [package2]...
ℹ Info: package [package2] has been successfully deployed.

ℹ Info: Deploying action [package1/generic]...
ℹ Info: action [package1/generic] has been successfully deployed.

ℹ Info: Deploying action [package2/generic2]...
ℹ Info: action [package2/generic2] has been successfully deployed.

ℹ Success: Deployment completed successfully.
✔ Deploy actions

Your deployed actions:
  -> https:/<ns>.adobeio-static.net/api/v1/web/package1/generic
  -> package2/generic2
Well done, your actions are now online 🏄

invoke the action in the second package

➜  ~/work/junk-apps/a curl https://<ns>.adobeio-static.net/api/v1/web/package2/generic2
{
  "code": "NjU56AeOtEhjOPOlflAtCiXDPhvUpMoI",
  "error": "There was an error processing your request."
}

Expected behavior
As multi-packages are not supported we should at least add an error message

@meryllblanchet good question, for now this happens in app-scripts when we parse the manifest to build the action. Multi pkg deployments from the runtime plugin work fine.
However now that we are moving the build logic from app-scripts to aio-lib-runtime, this might become a problem there too 🙂

@moritzraho let's keep an eye on it and move the issue if needed.


Random Data Resource loading issue with genesyscloud_routing_skill_group

I use Data Source to load skill for a queue.
I always have multiple Queues to be created which depends on multiple skill groups.
I first apply the skill group with Terraform using GC Provider.
When I use Data Source  of skill group during queue creation, It fails to load some of the skill groups even if it exists in UI.
E.g there there were total new 6 skill groups created through TF.
Later when using this for creating queue, 3 of them were identifiable, rest 3 its says "Error: context deadline exceeded"
I check for the spelling and its correct.
I tried to push this to a different org , then issue persists but this time , issue was with different set of skills groups.
If I hard code the id I got from state and comment the data source call, it works.
I tried different versions from 1.33 to 1.37 issue persists
data "genesyscloud_routing_skill_group" "Test123" { name = "Test123" }
skill_groups       = ["${genesyscloud_routing_skill_group.Test123.id}"]

In the logs it shows something like below
data.genesyscloud_routing_skill_group.Test123: Still reading... [6m0s elapsed]
Many retries with below
 Retry #1 for GET https://api.usw2.pure.cloud/api/v2/routing/skillgroups:
Many 429 errors
Response 429 Too Many Requests for request:GET https://api.usw2.pure.cloud/api/v2/routing/skillgroups:

Hi @viniljose
You mentioned that you first apply the skill group with Terraform. In that case, why are you using the skill group data source when you can reference the skill group resource directly? Data sources are usually used to reference existing Genesys Cloud objects that aren't managed under Terraform.

@charliecon
I have a different backend state file for queue and skill group..I want to manage the resources separately.
So TF state of queue,wont be knowing about the skill group.
I use Data sources for dependency resolution in other places as well , all works except skill group.
In skill group, some of them works and some of the wont work.
I need help to understand why some of them are not working.

Thank You , I will check and update back.

@charliecon I tried with 1.40.0 and 1.40.1 but same issue persists.
Can you please help me to understand which particular PR in changelog talks about the skill group changes you mentioned above?

@charliecon did you get a chance to check this?

Hi @viniljose . Sorry for the delay.
I was referring to PR 1064. I was wrong to refer to that PR. It edited the skill data source - not skill groups.
I was just looking through the code for the skill groups data source and I think I found a mistake that could have caused the behaviour that you're seeing. I will get to work on it now and keep you posted here.

Hey @viniljose
I just made the required changes. If you want, you can locally compile our project and test out the changes yourself. This may also be a way for you to get around your problem until the next release. It will also let us know if my changes fix the behaviour you're seeing, before the official release.
You will just need to clone this project, make sure you are on the branch no-jira-issue-1086, then run make sideload from the root of the project. Then you will need to update the reference to our provider in your Terraform configuration to look like this:
genesyscloud = {
  source  = "genesys.com/mypurecloud/genesyscloud"
  version = "0.1.0"
}

After running terraform init -upgrade , you should be using the locally compiled version.
This process is described here in our README file
Otherwise, you can wait for our next release which is scheduled for next Tuesday, the 25th of June.
-Charlie

Thank You @charliecon for the update I will check this and update back

Hey @viniljose
Quick update - the changes I made were released in v1.41.0
I'm going to close this issue for now. If the problem persists, feel free to re-open the issue or create a new one.
-Charlie


Dav.txt

@tuananhbuii First stage of verification passed, official domain is dav.edu.vn as far as I verified. This is just an informational note. Pull request is still in the review. I appreciate your patience while waiting for the final decision.

@tuananhbuii Please provide us with an URL of a page on the official website where the school offers an IT-related long-term (>1 year) course. Thank you.

@philipto My uni doesn't have any IT related courses, but I research them myself so I need an IDE account. So can you help me browse? Thank you !

@philipto My uni doesn't have any IT related courses, but I research them myself so I need an IDE account. So can you help me browse? Thank you !

@tuananhbuii I am sorry, in this circumstances I cannot add the domain to the trusted list. Please apply for free educational license individually, with an official document which proves that you are a student. You can do it using "OFFICIAL DOCUMENT" tab at https://www.jetbrains.com/shop/eform/students.
I have to close the request without merging.
Thank you for your understanding!


Error running example on kubernetes v.1.20

When applying changes to module.efs_csi_driver.kubectl_manifest.storage_class[0], provider
│ "provider["registry.terraform.io/gavinbunney/kubectl"]" produced an unexpected new value: Root resource was present,
│ but now absent.
I get this running your example with a newly created efs instance:
resource "aws_efs_file_system" "gb-efs" {
  creation_token = "gb-efs"
}

module "efs_csi_driver" {
  source = "git::https://github.com/DNXLabs/terraform-aws-eks-efs-csi-driver.git?ref=0.1.0"
  enabled = true

  depends_on = [
    aws_efs_file_system.gb-efs
  ]
}

Hey @happy-machine, have you added the kubeclt provider to your terraform code?
provider "kubectl" {
  host                   = data.aws_eks_cluster.cluster.endpoint
  cluster_ca_certificate = base64decode(data.aws_eks_cluster.cluster.certificate_authority.0.data)
  token                  = data.aws_eks_cluster_auth.cluster.token
  load_config_file       = false
}

And also make sure that you have this provider in a version >= 1.9.4
terraform {
  required_version = ">= 0.13"

  required_providers {
    kubectl = {
      source  = "gavinbunney/kubectl"
      version = ">= 1.9.4"
    }
  }
}

Having this, delete .terraform folder and run terraform init, terraform plan, terraform apply


Add KMNIST dataset

I added Kuzushiji-MNIST dataset. https://github.com/rois-codh/kmnist
It's a drop-in replacement for the MNIST dataset, so it's implemented just like FashionMNIST dataset.

You should add KMNIST here as well: https://github.com/pytorch/vision/blob/master/torchvision/datasets/init.py#L21

Oh, thanks! I overlooked it.


chore: bdd-spring-1575458628 to 0.0.1

chore: Promote bdd-spring-1575458628 to version 0.0.1

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approvers:
If they are not already assigned, you can assign the PR to them by writing /assign  in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


Back to Front VC at any time

How can I go back to front VC from anywhere in app?

I found an answer that,
create a new table view cell and add a new VC to storyboard and use segue to connect these each other
and then in viewDidAppear() call this code block:
let storyboard = UIStoryboard(name: "Main", bundle: nil)
    let main = storyboard.instantiateViewControllerWithIdentifier("SWRevealViewController")
    //SWRevealViewController
    self.presentViewController(main, animated: true, completion: nil)

    self.revealViewController().pushFrontViewController(self.revealViewController().frontViewController, animated: true)


Add GitHub action for static analysis to CI

Extend CI workflow to include static analysis with flake8 and mypy.

Already changed and addressed some of these in #8
Will add the GH action enhancement to that PR


_log_on_evaluation_epoch_end_metrics() still expects a Results object instead of a dict

🐛 Bug

Please reproduce using the BoringModel and post here

https://colab.research.google.com/drive/1Z1hOL_r67zcPnvgCkkjq3LZ4E58tFp7l?usp=sharing
To Reproduce

Expected behavior
On testing, using multiple datasets should not raise an error. It looks like it's still expecting one of the now deprecated *Results objects, but the loop only passes dicts around.
Environment
* CUDA:
	- GPU:
		- Tesla T4
	- available:         True
	- version:           10.1
* Packages:
	- numpy:             1.18.5
	- pyTorch_debug:     False
	- pyTorch_version:   1.6.0+cu101
	- pytorch-lightning: 1.0.4
	- tqdm:              4.41.1
* System:
	- OS:                Linux
	- architecture:
		- 64bit
		-
	- processor:         x86_64
	- python:            3.6.9
	- version:           #1 SMP Thu Jul 23 08:00:38 PDT 2020

Ah, wait, I see this is being handled in #4136 😬


Add configuration EnsureSSHAccessDisabled for workers settings

How to categorize this PR?

/area security
/area compliance
/kind enhancement
What this PR does / why we need it:
This PR adds a new configuration .provider.workersSettings.ensureSSHAccessDisabled in the shoot spec which allows users to disable ssh access to worker nodes and stop currently established ssh connections. This configuration is set to false by default and when its is disabled it does not guarantee that sshd.service is enabled. If this configuration is set to true then edited to false the sshd.service will not be enabled automatically even if it is enabled by default for the specific os.
This PR is in sync with Kubernetes' STIG. See rules 242393 and 242394 for more details.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
This changes have been tested on worker machines with gardenlinux and suse-chost.
cc @dimityrmirchev
Release note:

It is now possible to configure `ensureSSHAccessDisabled` field for the workers settings in the `Shoot` API via `.spec.provider.workersSettings.ensureSSHAccessDisabled`. It is set to `false` by default and when enabled it ensures that the `sshd.service` on the worker nodes is disabled and all already established ssh connections are terminated.

/assign

Maybe we can also extend gardenctlv2 to prompt with a friendly message that ssh access is disabled when this config is enabled and someone tries to ssh to a node via a bastion.
cc @gardener/gardenctl-v2-maintainers

Maybe we can also extend gardenctlv2 to prompt with a friendly message that ssh access is disabled when this config is enabled and someone tries to ssh to a node via a bastion. cc @gardener/gardenctl-v2-maintainers

As all workers are affected with this setting, shouldn't the creation of Bastion resources be prevented by gardener? Gardenctl would then show the respective error message.
Also all created Bastion resources for this Shoot could be deleted by gardener.

As all workers are affected with this setting, shouldn't the creation of Bastion resources be prevented by gardener?

Good point. I guess we can add another validating webhook that will prevent the creation of such resources. @rfranzke do you agree with this approach?

Also all created Bastion resources for this Shoot could be deleted by gardener.

I agree. We can delete them (if any exist) during the reconciliation flow.

As all workers are affected with this setting, shouldn't the creation of Bastion resources be prevented by gardener?

Good point. I guess we can add another validating webhook that will prevent the creation of such resources. @rfranzke do you agree with this approach?

Instead of a webhook, the existing Bastion admission plugin should be augmented.

As all workers are affected with this setting, shouldn't the creation of Bastion resources be prevented by gardener?

Good point. I guess we can add another validating webhook that will prevent the creation of such resources. @rfranzke do you agree with this approach?

Instead of a webhook, the existing Bastion admission plugin should be augmented.

Thanks for pointing this out! I somehow missed that in my quick search for already existing validations on the Bastion resources.

/test pull-gardener-integration


Fix logo anchor such that it is clickable again

In this patch, the logo is assigned a z-index such that it can be used again to navigate to the homepage. Prior to this patch, the div#navbar was overlapping the logo, only allowing to the top border of the logo to be clickable.
Note that I am no expert in CSS and therefore I am not sure if this the best solution. Let me know what you think 😬

@hacksparrow PTAL

@iamropo ping!

LGTM, Thanks @aaronang

@iamropo It was my pleasure 😄


docs(plugin): add docs for installing gitsigns.nvim with lazy.nvim

this did not added an event as you suggested.

I think I'm going to just adjust the README to not list any package manager and simply document the setup() function.

I think I'm going to just adjust the README to not list any package manager and simply document the setup() function.

Ok :)


correct description of upgrade

The text did not fit to the commands, now it is correct.

Ah, the known identation problem. Thank you :)
PS. @maxlazio I'll merge this since it's just docs hope you don't mind.

@axilleas No problem!


Include keys in notofy message

add a parater to add some specifed keys to the count line..
config parameter
include_keys host,sessionid,......
for ex {"count":2,"message":[....],"host":["asp01","asp02",....],.......}
this will include the keys speciefed in the config and add them (usefull for application clusters)

@sonots Is this feature request going to be implemented? It would be really useful for me as well.


Fix CocoaPods spec

The last release hasn't updated the podspec accordingly which can be problematic for projects using Rex through CocoaPods. This PR fixes that.
I noticed that #93 already fixes the warning already included in this PR so I can strip that commit if you want.

Thanks!

Thanks for merging this @neilpa!
It's not yet published on the main cocoapods repo, do you need to do that or is @bjarkehs the person that needs to do this?


Register 2022-08-15

@JuliaRegistrator register

Registration pull request created: JuliaRegistries/General/66310
After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.
This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:
git tag -a v0.1.10 -m "<description of version>" 9bc6ab2a1b9ddfa8b9eaacdd5d05d38eaeac0b6e
git push origin v0.1.10


Added Ansh's Profile

Changes made:
Added my profile to the contributors in README.md

Could you also add me as a part of your organization ?

Sure @anshdhinhgra47 👍 , can you raise an issue here (plus you will get another green square 🟩 ) https://github.com/EddieJaoudeCommunity/support/issues

Sure


TearDownTest called before all sub-tests are done?

Should this fork address https://github.com/stretchr/testify/issues/934 such that TearDownTest gets called after all the subtests are done? The line in the readme below this header: https://github.com/huma-engineering/testify#parallel-test-suites seems to imply this is the case.
This reproducible example shows that TearDownTest is called before the subsets are complete:
package example

import (
	"math/rand"
	"testing"
	"time"

	"github.com/huma-engineering/testify/v2/suite"
)

func TestSuiteParallelSubTests(t *testing.T) {
	suite.Run(t, &Suite{})
}

type Suite struct{}

func (s *Suite) TearDownSuite(t *suite.T) {
	t.Log(">> suite tear down", time.Now().Format(time.ANSIC))
}

func (s *Suite) SetupTest(t *suite.T) {
	t.Log(">> single test setup", t.Name())
}

func (s *Suite) TearDownTest(t *suite.T) {
	t.Log(">> single test tear down", t.Name(), time.Now().Format(time.ANSIC))
}

func (s *Suite) TestOne(t *suite.T) {
	for _, v := range []string{"sub1", "sub2", "sub3"} {
		t.Run(v, func(a *suite.T) {
			a.Parallel()
			r := rand.Intn(3)
			a.Log("started to run: ", a.Name(), "will wait: ", r, time.Now().Format(time.ANSIC))
			time.Sleep(time.Duration(r) * time.Second)
			a.Log("end  run: ", a.Name(), time.Now().Format(time.ANSIC))
		})
	}
}

func (s *Suite) TestTwo(t *suite.T) {
	for _, v := range []string{"sub1", "sub2", "sub3"} {
		t.Run(v, func(a *suite.T) {
			a.Parallel()
			r := rand.Intn(3)
			a.Log("started to run: ", a.Name(), "will wait: ", r, time.Now().Format(time.ANSIC))
			time.Sleep(time.Duration(r) * time.Second)
			a.Log("end  run: ", a.Name(), time.Now().Format(time.ANSIC))
		})
	}
}

The output of a sample run is:
=== RUN   TestSuiteParallelSubTests
=== CONT  TestSuiteParallelSubTests
    suite.go:64: >> suite tear down Fri May 31 01:52:06 2024
--- PASS: TestSuiteParallelSubTests (4.00s)
=== RUN   TestSuiteParallelSubTests/All
    --- PASS: TestSuiteParallelSubTests/All (4.00s)
=== RUN   TestSuiteParallelSubTests/All/TestOne
    suite.go:64: >> single test setup TestSuiteParallelSubTests/All/TestOne
=== CONT  TestSuiteParallelSubTests/All/TestOne
    suite.go:64: >> single test tear down TestSuiteParallelSubTests/All/TestOne Fri May 31 01:52:02 2024
        --- PASS: TestSuiteParallelSubTests/All/TestOne (0.00s)
=== RUN   TestSuiteParallelSubTests/All/TestOne/sub1
=== PAUSE TestSuiteParallelSubTests/All/TestOne/sub1
=== CONT  TestSuiteParallelSubTests/All/TestOne/sub1
=== CONT  TestSuiteParallelSubTests/All/TestOne/sub1
    suite.go:64: started to run:  TestSuiteParallelSubTests/All/TestOne/sub1 will wait:  2 Fri May 31 01:52:02 2024
=== CONT  TestSuiteParallelSubTests/All/TestOne/sub1
    suite.go:64: end  run:  TestSuiteParallelSubTests/All/TestOne/sub1 Fri May 31 01:52:04 2024
            --- PASS: TestSuiteParallelSubTests/All/TestOne/sub1 (2.00s)
=== RUN   TestSuiteParallelSubTests/All/TestOne/sub2
=== PAUSE TestSuiteParallelSubTests/All/TestOne/sub2
=== CONT  TestSuiteParallelSubTests/All/TestOne/sub2
    suite.go:64: started to run:  TestSuiteParallelSubTests/All/TestOne/sub2 will wait:  2 Fri May 31 01:52:02 2024
=== CONT  TestSuiteParallelSubTests/All/TestOne/sub2
    suite.go:64: end  run:  TestSuiteParallelSubTests/All/TestOne/sub2 Fri May 31 01:52:04 2024
            --- PASS: TestSuiteParallelSubTests/All/TestOne/sub2 (2.00s)
=== RUN   TestSuiteParallelSubTests/All/TestOne/sub3
=== PAUSE TestSuiteParallelSubTests/All/TestOne/sub3
=== CONT  TestSuiteParallelSubTests/All/TestOne/sub3
=== CONT  TestSuiteParallelSubTests/All/TestOne/sub3
    suite.go:64: started to run:  TestSuiteParallelSubTests/All/TestOne/sub3 will wait:  0 Fri May 31 01:52:02 2024
    suite.go:64: end  run:  TestSuiteParallelSubTests/All/TestOne/sub3 Fri May 31 01:52:02 2024
            --- PASS: TestSuiteParallelSubTests/All/TestOne/sub3 (0.00s)
=== RUN   TestSuiteParallelSubTests/All/TestTwo
    suite.go:64: >> single test setup TestSuiteParallelSubTests/All/TestTwo
=== CONT  TestSuiteParallelSubTests/All/TestTwo
    suite.go:64: >> single test tear down TestSuiteParallelSubTests/All/TestTwo Fri May 31 01:52:04 2024
        --- PASS: TestSuiteParallelSubTests/All/TestTwo (0.00s)
=== RUN   TestSuiteParallelSubTests/All/TestTwo/sub1
=== PAUSE TestSuiteParallelSubTests/All/TestTwo/sub1
=== CONT  TestSuiteParallelSubTests/All/TestTwo/sub1
    suite.go:64: started to run:  TestSuiteParallelSubTests/All/TestTwo/sub1 will wait:  2 Fri May 31 01:52:04 2024
=== CONT  TestSuiteParallelSubTests/All/TestTwo/sub1
    suite.go:64: end  run:  TestSuiteParallelSubTests/All/TestTwo/sub1 Fri May 31 01:52:06 2024
            --- PASS: TestSuiteParallelSubTests/All/TestTwo/sub1 (2.00s)
=== RUN   TestSuiteParallelSubTests/All/TestTwo/sub2
=== PAUSE TestSuiteParallelSubTests/All/TestTwo/sub2
=== CONT  TestSuiteParallelSubTests/All/TestTwo/sub2
    suite.go:64: started to run:  TestSuiteParallelSubTests/All/TestTwo/sub2 will wait:  0 Fri May 31 01:52:04 2024
    suite.go:64: end  run:  TestSuiteParallelSubTests/All/TestTwo/sub2 Fri May 31 01:52:04 2024
            --- PASS: TestSuiteParallelSubTests/All/TestTwo/sub2 (0.00s)
=== RUN   TestSuiteParallelSubTests/All/TestTwo/sub3
=== PAUSE TestSuiteParallelSubTests/All/TestTwo/sub3
=== CONT  TestSuiteParallelSubTests/All/TestTwo/sub3
    suite.go:64: started to run:  TestSuiteParallelSubTests/All/TestTwo/sub3 will wait:  1 Fri May 31 01:52:04 2024
=== CONT  TestSuiteParallelSubTests/All/TestTwo/sub3
    suite.go:64: end  run:  TestSuiteParallelSubTests/All/TestTwo/sub3 Fri May 31 01:52:05 2024
            --- PASS: TestSuiteParallelSubTests/All/TestTwo/sub3 (1.00s)
PASS

Process finished with the exit code 0

In particular note that:
single test tear down TestSuiteParallelSubTests/All/TestOne Fri May 31 01:52:02 2024

is called before:
suite.go:64: end  run:  TestSuiteParallelSubTests/All/TestOne/sub1 Fri May 31 01:52:04 2024

any thoughts on this @denist-huma ?


Update DoubleNegation.test.js

Created more test cases for the Double Negation test suite

Nice! Try to think more outside the box for more tests. This is a good start. Add some tests that should come back false as well. For example add something with thee ~'s and get rid of two (should be true). or get rid of all three (should be false). Try it with 4 of them. Try the two ~'s in different spots. Try it where it will return true, but there is a change not related to the ~'s. Etc... Just think about weird cases. Great base for the general cases though.

Shamar arent you iron 1?


Unknown syntax error on German double quotes

note[unknown-token]: Unknown syntax token found

The third li contains unknown syntax

Test List

Pay Later

New „Payment Upon Invoice“ (Germany)

Seamless checkout experience

Easy integration into your Shopware shop

FYI: The rule unknown-token is not necessary most of the time (can be removed from ludtwig-config.toml). It was created in the beginning of the project to check that the lexer can lex the whole template.
It just reports unknown tokens (which aren't defined in the parser / don't have any meaning).
I guess I can also remove this rule if it only causes confusion 🙈


Closured instance variable of a struct results in invalid memory access

A closured ivar in a struct can be accessed but when calling a method on it, it runs into a segfault:
struct Foo
  def initialize
    @foo = ["foo"]
    -> do
      @foo << "bar" # Error: Invalid memory access
    end.call
  end
end

Foo.new

This works however:
struct Foo
  def initialize
    @foo = ["foo"]
    -> do
      @foo # => ["foo"]
    end.call
  end
end

Foo.new

The access working is just a result of the access being optimized out as the value is never used.
I'm certain that this example cannot compile.

Hm, I'm pretty sure I had an example where the value could actually be used... But it seems that's not the case.
When it can't work, closuring a struct ivar should be a compiler error.

I'll try to debug it today, but I don't think closuring structs work well at all.

Actually, it seems related to initialize...

Yeah, the problem is that the compiler detects that self is closured, so it allocates that in the heap and stores the struct there... when the initialize method begins. At that point everything is zero inside the struct. Then it's never changed in the closured data (because it's not a reference, like a class).
Try this:
struct Foo
  def initialize
    @bar = 1
    ->do
      p @bar
    end
  end
end

Foo.new

I don't have a solution for this. Maybe structs shouldn't be allowed to be closured.

Actually, maybe it can be done, but it has to be specific to initialize: reading and assigning to instance vars there must write to the closured data (self). But at the end a copy of the struct will be returned... I guess that at long that it doesn't segfault it will be fine. I'll see if I can fix it somehow.

Regardless of the fix (which I might not do soon because the use case is a bit contrived): how did you stumble upon this? What were you trying to do?

IIRC this was mentioned by someone else, I just wrote the issue. But I'm not sure right now .. usually I mention the source.

I feel like this issue needs a bump, since #9311 was closed as duplicate of this

This was encountered on the discord when using at_exit within initialize. E.g. something along the lines of this, with a TCPServer also running.
require "socket"

struct Client
  def initialize(host : String, port : Int32)
    @tcp_socket = TCPSocket.new host, port

    at_exit do
      @tcp_socket.send "foo"
    end
  end
end

client =Client.new "<IP_ADDRESS>", 1234


[RFC] Change installation for extra packages

What does this PR do?
We recently divided requirements into several wrt data types (e.g. pip install lightning-flash[image]), but I don't think it's intuitive to users as I left a comment in https://github.com/PyTorchLightning/lightning-flash/pull/215#discussion_r615151847.
TODO
I'll update the docs and fix failing CI (if there is) once I get positive comments from core members.

[x] Fix CI
[x] Update installation docs

Description of the changes
Before
dev      = vision + tabular + text + image
dev-test = dev + test
all      = dev + docs

After
# for users
all = vision + tabular + text
# for Flash contributors/developers
dev = all + tests + docs

Before submitting

[RFC] Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
[x] Did you read the contributor guideline, Pull Request section?
[x] Did you make sure your PR does only one thing, instead of bundling different changes together?
[ ] Did you make sure to update the documentation with your changes?
[n/a] Did you write any new necessary tests? [not needed for typos/docs]
[x] Did you verify new and existing tests pass locally with your changes?
[x] If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

[x] Is this pull request ready for review? (if not, please submit in draft mode)

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃

@tchaton @Borda @ethanwharris I'd love to know your thoughts on this change.

@Borda not sure about urls but afaik you can definitely do pip install "./some/path[images]"
you just need the quotation marks :)


Calibre uses its own style instead of using adwaita / gnome

Describe the bug
Calibre uses its own style instead of using adwaita / gnome
Steps To Reproduce
 environment.sessionVariables = {
    CALIBRE_USE_SYSTEM_THEME = "true";
  };

 environment.systemPackages = with pkgs; [
    adwaita-qt
    calibre
    qgnomeplatform
 ];

Metadata
Please run nix-shell -p nix-info --run "nix-info -m" and paste the result.
[nix@87a9f8f3b6a231:~] nix-shell -p nix-info --run "nix-info -m"
 - system: `"x86_64-linux"`
 - host os: `Linux 6.6.36, NixOS, 24.11 (Vicuna), 24.11pre646099.00d80d13810d`
 - multi-user?: `yes`
 - sandbox: `yes`
 - version: `nix-env (Nix) 2.18.4`
 - channels(root): `"home-manager, nixos"`
 - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos

Did you reboot after setting the envvar and rebuilding?

Did you reboot after setting the envvar and rebuilding?

Yes, looks like all app in calibre package are affected

Works fine on my end. Maybe you've not configured your QT theme appropriately?

Problem still exist even with this options
  environment.sessionVariables = {
    CALIBRE_USE_SYSTEM_THEME = "true";
    QT_STYLE_OVERRIDE = "adwaita";
    QT_WAYLAND_DECORATION = "adwaita";
    QT_QPA_PLATFORMTHEME = "gnome";
    QT_QPA_PLATFORM = "wayland";
  };

That looks like Qt's CSD. PrismLauncher also shows that when using Wayland on GNOME.


Cosmos DB: Diagnostics for operations

Similarly to other Cosmos DB SDKs, expose Diagnostics for each operation that includes relevant troubleshooting information.
Initially it can be scoped to:

Relevant client configuration (like which Preferred Regions)
All requests involved in an operation, including retries handled by cross-region management

Notes: Time :)

https://github.com/Azure/azure-sdk-for-go/pull/22288 Added logging support and examples.

https://github.com/Azure/azure-sdk-for-go/pull/22593 and https://github.com/Azure/azure-sdk-for-go/pull/22598 add logging of account and client settings


Fix mysql_remap plugin build with MySQL 8

Starting MySQL 8.0.1 release, the my_bool type has been removed, leading mysql_remap build to fail.
Details in https://dev.mysql.com/doc/relnotes/mysql/8.0/en/news-8-0-1.html#mysqld-8-0-1-compiling state that my_bool should be replaced with C type bool.
Although not yet tested with MySQL 8, this changes is backwards-compatible with older versions of MySQL and MariaDB.

[approve ci]


Log coordinates of artifacts published

Because the staging repo is dropped, and the artifacts don't show up in searches for several hours, it is very hard to know what actually got published. It'd be nice to have a message like "Successfully published group:artifact:version" in the build logs for each artifact as confirmation.
For example, Gradle Plugin Development Plugin prints the following:
Publishing plugin com.asarkar.gradle.build-time-tracker version 2.1.0
Publishing artifact build/libs/build-time-tracker-2.1.0.jar
Publishing artifact build/libs/build-time-tracker-2.1.0.jar
Publishing artifact build/publications/pluginMaven/pom-default.xml
Publishing artifact build/publications/pluginMaven/module.json
Activating plugin com.asarkar.gradle.build-time-tracker version 2.1.0

@szpak @marcphilipp Any word on this?

@asarkar Would you like to provide a PR?

Happy to, if you will kindly point me in the general direction of where to start. If I’ve to go through every class and understand the codebase first, that’ll be prohibitively time consuming.

Sure @asarkar.
The already existing publishing tasks enhancement is performed here:
https://github.com/gradle-nexus/publish-plugin/blob/3bca62861986833da247b7f955d7b0296e7499ff/src/main/kotlin/io/github/gradlenexus/publishplugin/NexusPublishPlugin.kt#L187
You can start by try to extending the already displayed log statement.

I wasn't able to make a PR but chance this issue might be worked on by a maintainer?


update documentation around react-app

Signed-off-by: Augustin Husson<EMAIL_ADDRESS>

thanks @beorn7 for the review, @juliusv is already aware how bad I am to document things, so pretty sure you simplified him (by a lot) the final review !

I changes the nodeJS version to the v16. Note that it's not super required to use nodeJS 16. nodeJS 14 can be enough. I think we are mostly using nodeJS v16 in prometheus because it brings npm v7 immediately. Which is not the case with the previous nodeJS version.
I added a short description of the manual step required to update the dependencies version. I hope it's enough and clear like that @roidelapluie.


Handoff caching is now in an a-list instead of a dictionary.

Also added a suite of eunit tests.

Tests pass, coverage shows the right thing is tested, riak_control runs. All looks good to me +1 to merge.


Use export_env function correctly

The earlier use was incorrect, and resulted in nothing being exported. I'm surprised it didn't error out though.

Fixes #76