Fix typo in Linf equation

Hi! This commit fixes a small typo in the Linf equation (Eq. 5).

@arni-magnusson,
Thanks for the correction.
From the GitHub Actions artifact, it looks like the resulting equation

matches A.1.5 in the Methot & Wetzel (2013) supplemental material

Great work, @iantaylor-NOAA, with deriving the equation in the first place!

Wasn't me doing the deriving and credit goes to @chantelwetzel-noaa for adding the additional detail from the 2013 paper into the User Manual.

Ha, that's interesting. In 982e553, Rick  added a comment
//Ian Taylor derived the formula for Linf
so I took that at face value :)
I find it appropriate that just as L1, L2, and Linf are all pointing at each other, @chantelwetzel-noaa, @iantaylor-NOAA, and @Rick-Methot-NOAA are doing the same...
In the current draft of our tuna assessment reference handbook, the section heading now reads "Wetzel-Taylor Theorem of Growth Transformation".

Maybe I just have very bad memory.
@arni-magnusson is your tuna assessment reference handbook just an internal SPC document, or publicly accessible.
In reciprocity I offer this link to the Unofficial NWFSC and SWFSC Groundfish Stock Assessment Handbook https://pfmc-assessments.github.io/pfmc_assessment_handbook/ which is intended for internal use but is publicly accessible.

Thanks for sharing the NWFSC and SWFSC Groundfish Stock Assessment Handbook. It's well organized and super informative.
Sorry to disappoint, but the tuna assessment reference handbook I was referring to only contains one section, the
Wetzel-Taylor Theorem of Growth Transformation :)
Nonetheless, we have:

https://capamresearch.org/recordings-tuna-stock-assessment-good-practices-workshop from March this year.

Proper - Quality Assurance and Quality Control for SPC Assessments, which is taking shape. It consists mainly of:

A standard directory tree.
General guidelines on how to write reproducible R scripts and organize selected parts of the assessment work on GitHub.
An R package that checks how well a given assessment conforms to the agreed way to work, measuring how well an assessment has been parked. (Currently a single-function package skeleton, created last week.)

SPC Proper is partly inspired by ICES TAF and GFCM STAR, which have somewhat comparable aims. The latter includes an R package that runs a suite of QC functions to check which quality criteria are fulfilled, before database import of GFCM stock assessment results. Above all, though, Proper is tailored to address the top priority need at SPC to ensure that all the elements of a stock assessment can be picked up 3 years later by a new stock assessor, as efficiently as possible.


Validate/Fix rebuilding for OSCAR Doc

[x] Fix silent failing of rebuilding due to no sorting on rebuilding information
[x] Fix off-by-one content length calculation
[ ] Write integration test that generates rebuild files and then rebuilds a corpus to check conformity of rebuilding

Currently rebuilding recreates the same documents, but not in the same order.

related to #61

Integration test is yet to be pushed but may require additional setup (download shards, etc)


columnDef visible not working with responsive

I have noticed that when I initialize DataTable with responsive: true, columnDefs marked with visible: false still get rendered on the table.
In this case, first column gets rendered when it shouldn't
"responsive": true,
"ajax": {
    "url": "<SOME URL>"
},
"columnDefs": [
	{
		"targets": 0,
		"visible": false
	}
   ...

Hi - this will be addressed with Responsive 2.0. This feature has already been committed if you wish to try out a pre-release version. For v1.x you would need to use the never class to address this.
If you do a search on the DataTables forums you will find a number of discussions about this issue.

@DataTables Thanks for the information. I was looking for similar issues but couldn't find any that reported this problem.
Will try the pre-release version.


Caching bug

Hi, thanks for sharing this repo.
I have encountered a bug where I get different results depending on the order in which I parse two names. Specifically, I would like to parse:
DPB10401 -> HLA-DPB1*04:01
DPB110401 -> HLA-DPB1*104:01
but the second name that I parse always parses incorrectly.
Here is the first ordering:
>>> import mhcgnomes
>>> mhcgnomes.parse("DPB10401").to_string()  # Correct
'HLA-DPB1*04:01'

>>> mhcgnomes.parse("DPB110401").to_string()  # Incorrect
'HLA-DPB1*11:04:01'

Now I restart the python interpreter (this is important for clearing the cache) and run the second ordering:
>>> import mhcgnomes
>>> mhcgnomes.parse("DPB110401").to_string()  # Correct
'HLA-DPB1*104:01'

>>> mhcgnomes.parse("DPB10401").to_string() # Incorrect
'HLA-DPB1*104:01'

I am using mhcgnomes 1.8.4 and Python 3.9.16.
Any help would be appreciated!

this is still happening in 1.8.6 with python 3.10.14

also 1.9

It can be avoided by using the uncached Parser, cf. mhcgnomes.Parser().parse("DPB10401").to_string() but indeed quite nasty bug 😅


Some thoughts on the front page md file

Suggestion

🔍 Search Terms

List of keywords you searched for before creating this issue. Write them down here so that others can find this suggestion more easily and help provide feedback.
✅ Viability Checklist

My suggestion meets these guidelines:

[ ✔] This wouldn't be a breaking change in existing TypeScript/JavaScript code
[ ✔] This wouldn't change the runtime behavior of existing JavaScript code
[ ✔] This could be implemented without emitting different JS based on the types of the expressions
[ ✔] This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, new syntax sugar for JS, etc.)
[ ✔] This feature would agree with the rest of TypeScript's Design Goals.

⭐ Suggestion
First, we can create a new home page MD file (in other languages) for people who can't speak English. Second, we can add Other entries to the original one, which can put links to some tools, such as ts-node, to facilitate debugging and learning.
One suggestion: you can add the yarn installation method to the home MD file, because some learners are not good at NPM (or bugs) or don't want to use NPM to install type script
📃 Motivating Example
There is nothing to say here, the main thing is to add some practical debugging tools to the home page MD file.
💻 Use Cases
1.The utility can be increased so that useful tools can be discovered.
2.It makes the document less concise because now there is only one change.
3.My approach is to keep the text as simple as possible, as easy to read as possible and as aesthetically pleasing as possible.

This feedback doesn't really align with other feedback we've heard.


fzf - match whole word option

fuzzy search can sometimes be too easy-going and cannot filter out unwanted results, especially when the input set is large, of course we don't want extract match either because it is too strict in most cases.
I suggest having a mode that is somewhere between fuzzy search and normal search, which will match whole words in fuzzy style:
For e.g.
cat dog will keep cat and dog but remove can go with dog
What do you think?

For that purpose, I use extended-search mode which allows me to selectively enable exact match by quoting search terms. e.g. 'cat dog: exact match for cat and fuzzy match for dog. It's pretty good, you'll like it when you get used to it. (Try using it with ALT-B) I also suggest that you enable it by default with export FZF_DEFAULT_OPTS='--extended'.


TypeError: Cannot destructure property 'content' of 'this.props.tag' as it is undefined.

This came up when I was working in another file, wasn't sure how to debug because you're pulling from content of tags which makes sense to me.

taking a crack at this!


Update to v2.6.3

This PR updates ray packages to a newer version, and adds support for linux-aarch64 that was previously missing. This required updating some minor bazel dependencies, which has been done here through a patch.

Linter check found the following problems:
The following problems have been found:
ERROR: clone/recipe/meta.yaml:34: cython_must_be_in_host: Cython should be in the host section
ERROR: clone/recipe/meta.yaml:35: cython_must_be_in_host: Cython should be in the host section
WARNING: clone/recipe/meta.yaml:46: build_tools_must_be_in_build: The build tool pkg-config is not in the build section.
ERROR: clone/recipe/meta.yaml:46: host_section_needs_exact_pinnings: Packages in host must have exact version pinnings, except python build tools.
ERROR: clone/recipe/meta.yaml:76: cython_must_be_in_host: Cython should be in the host section
ERROR: clone/recipe/meta.yaml:77: no_git_on_windows: output "ray-core": git should not be used as a dependency on Windows.
ERROR: clone/recipe/meta.yaml:78: cython_must_be_in_host: Cython should be in the host section
WARNING: clone/recipe/meta.yaml:88: build_tools_must_be_in_build: output "ray-core": The build tool pkg-config is not in the build section.
ERROR: clone/recipe/meta.yaml:88: host_section_needs_exact_pinnings: output "ray-core": Packages in host must have exact version pinnings, except python build tools.
Errors were found

Linter check found the following problems:
The following problems have been found:
WARNING: clone/recipe/meta.yaml:47: build_tools_must_be_in_build: The build tool pkg-config is not in the build section.
ERROR: clone/recipe/meta.yaml:47: host_section_needs_exact_pinnings: Packages in host must have exact version pinnings, except python build tools.
WARNING: clone/recipe/meta.yaml:85: build_tools_must_be_in_build: output "ray-core": The build tool pkg-config is not in the build section.
ERROR: clone/recipe/meta.yaml:85: host_section_needs_exact_pinnings: output "ray-core": Packages in host must have exact version pinnings, except python build tools.
Errors were found

Linter check found the following problems:
The following problems have been found:
WARNING: clone/recipe/meta.yaml:102: python_build_tool_in_run: output "ray-core": The python build tool setuptools is in run depends
Warnings were found

Linter check found the following problems:
The following problems have been found:
WARNING: clone/recipe/meta.yaml:101: python_build_tool_in_run: output "ray-core": The python build tool setuptools is in run depends
Warnings were found

Linter check found the following problems:
The following problems have been found:
WARNING: clone/recipe/meta.yaml:103: python_build_tool_in_run: output "ray-core": The python build tool setuptools is in run depends
Warnings were found

Linter check found the following problems:
The following problems have been found:
WARNING: clone/recipe/meta.yaml:101: python_build_tool_in_run: output "ray-core": The python build tool setuptools is in run depends
Warnings were found


Improved BiMPM in AllenNLP

@handsomezebra
Sorry to bother you via this channel, i thought it would be more adequate to use an issue here than emailing you directly.
We are starting to use your BiMPM implementation in AllenNLP. Compared to the paper (https://arxiv.org/pdf/1702.03814.pdf) you not only pass on the final context representation to the matching layer, but also the "intermediate context representation" (encoder1) and the word embeddings.
What was your motivation? Did you do some comparison between these settings?
Sorry again to bother you with this "old" stuff.
Have a great day!

Hi, Sorry for late response. I totally missed it.
For the question, I didn't do a the comparison. But usually when there is enough data, the more you include in the representation you can get better results. This is also the case in other models, for example, when you use BERT as features. There are many layers in BERT model, and when you use more layers you can get better results.


PWN-6090 - make a warning screen when address does not have account

Jira Ticket
https://p2pvalidator.atlassian.net/browse/PWN-6090
Description of Work
PWN-6090 - make a warning screen when address does not have account

any screen shots please?

оукай


Update controller release flow

Created automated GH releases with generated changelog
Change the appVersion in the Chart.yaml automatically during release

the existing app's Makefile command to update the app version should update appVersion in Chart.yaml instead of version.
it would be helpful (tho not critical) to have a separate command to iterate the Helm chart version.
we can update the GHA workflow release-qa  to do helm upgrade on the qa cluster instead of just updating the image.  it can use the source within the qa branch without packaging a Helm chart version and without doing a GitHub release. We'll look at the helm CLI options we're using in Terraform now, and maybe try the dependency-update flag too.

When running helm upgrade within a GHA workflow, here are some helpful CLI options:

--install "if a release by this name doesn't already exist, run an install" idempotent!
--atomic "if set, upgrade process rolls back changes made in case of failed upgrade." don't leave the cluster broken!
--dependency-update hopefully pulls new dependency charts
--cleanup-on-fail probably safe here
--timeout 15m more time to troubleshoot if it hangs (default 5m)
--verify good for any CI/CD workflow
--render-subchart-notes sure why not

We might need to use --reuse-values but it's better if we don't. Test by running helm get values on the release before and after this workflow first runs.
you can read about these options and more here: https://helm.sh/docs/helm/helm_upgrade/

The flag --render-subchart-notes show us. I think this is not relevant for us
NOTES:
The ingress-nginx controller has been installed.
It may take a few minutes for the LoadBalancer IP to be available.
You can watch the status by running 'kubectl --namespace uffizzi get services -o wide -w uffizzi-ingress-nginx-controller'

An example Ingress that makes use of the controller:
  apiVersion: networking.k8s.io/v1
  kind: Ingress
  metadata:
    name: example
    namespace: foo
  spec:
    ingressClassName: nginx
    rules:
      - host: www.example.com
        http:
          paths:
            - pathType: Prefix
              backend:
                service:
                  name: exampleService
                  port:
                    number: 80
              path: /
    # This section is only required if TLS is to be enabled for the Ingress
    tls:
      - hosts:
        - www.example.com
        secretName: example-tls

If TLS is enabled for the Ingress, a Secret containing the certificate and key must also be provided:

  apiVersion: v1
  kind: Secret
  metadata:
    name: example-tls
    namespace: foo
  data:
    tls.crt: <base64 encoded cert>
    tls.key: <base64 encoded key>
  type: kubernetes.io/tls

cert-manager v1.12.4 has been deployed successfully!

In order to begin issuing certificates, you will need to set up a ClusterIssuer
or Issuer resource (for example, by creating a 'letsencrypt-staging' issuer).

More information on the different types of issuers and how to configure them
can be found in our documentation:

https://cert-manager.io/docs/configuration/

For information on how to configure cert-manager to automatically provision
Certificates for Ingress resources, take a look at the `ingress-shim`
documentation:

https://cert-manager.io/docs/usage/ingress/

CHART NAME: flux
CHART VERSION: 0.3.11
APP VERSION: 0.36.1

** Please be patient while the chart is being deployed **

The following controllers have been deployed:
  - helm-controller
  - source-controller

Check the status of the pods by running this command:

  kubectl get pods --namespace "uffizzi" -l app.kubernetes.io/instance=uffizzi

Read the upstream flux documentation to start working with the controllers:

  https://fluxcd.io/flux/components/

The flag --verify does not work with unpacked chart
Error: unpacked charts cannot be verified


Internal error (to do with NodeJS?) when trying to make an SSL certificate

Have you pulled and found the error with jc21/nginx-proxy-manager:latest docker image?

Yes

Are you sure you're not using someone else's docker image?

Yes

Have you searched for similar issues (both open and closed)?

Yes

Describe the bug
When trying to make an SSL certificate I get an internal error with the following error message
CommandError: Saving debug log to /tmp/letsencrypt-log/letsencrypt.log
An unexpected error occurred:
Error creating new order :: Cannot issue for "thuis.home": Domain name does not end with a valid public suffix (TLD)
Ask for help or search for solutions at https://community.letsencrypt.org. See the logfile /tmp/letsencrypt-log/letsencrypt.log or re-run Certbot with -v for more details.

    at /app/lib/utils.js:16:13
    at ChildProcess.exithandler (node:child_process:430:5)
    at ChildProcess.emit (node:events:518:28)
    at maybeClose (node:internal/child_process:1105:16)
    at Socket. (node:internal/child_process:457:11)
    at Socket.emit (node:events:518:28)
    at Pipe. (node:net:337:12)

Nginx Proxy Manager Version
2.11.1
To Reproduce
Steps to reproduce the behavior:

Go to SSL certificates > make new certificate
Enter domain name
Enable agree to terms
Click save and wait

Expected behavior
I expect it to make a certificate succesfully
Screenshots

Operating System
Raspberry Pi OS, version 12 64 bit on a Raspberry Pi 4
Additional context
Docker version 26.0.2, build 3c863ff
Portainer Community Edition 2.19.5
Firefox 124.0.2 (64-bits)

Same issue to me.
It is not possible to renew existing certificates and it is not possible to obtain new certificates.

CommandError: WARNING: Retrying (Retry(total=4, connect=None, read=None, redirect=None, status=None)) after connection broken by 'NewConnectionError(': Failed to establish a new connection: [Errno -3] Temporary failure in name resolution')': /simple/certbot-dns-duckdns/
WARNING: Retrying (Retry(total=3, connect=None, read=None, redirect=None, status=None)) after connection broken by 'NewConnectionError(': Failed to establish a new connection: [Errno -3] Temporary failure in name resolution')': /simple/certbot-dns-duckdns/
WARNING: Retrying (Retry(total=2, connect=None, read=None, redirect=None, status=None)) after connection broken by 'NewConnectionError(': Failed to establish a new connection: [Errno -3] Temporary failure in name resolution')': /simple/certbot-dns-duckdns/
WARNING: Retrying (Retry(total=1, connect=None, read=None, redirect=None, status=None)) after connection broken by 'NewConnectionError(': Failed to establish a new connection: [Errno -3] Temporary failure in name resolution')': /simple/certbot-dns-duckdns/
WARNING: Retrying (Retry(total=0, connect=None, read=None, redirect=None, status=None)) after connection broken by 'NewConnectionError(': Failed to establish a new connection: [Errno -3] Temporary failure in name resolution')': /simple/certbot-dns-duckdns/
ERROR: Could not find a version that satisfies the requirement certbot-dns-duckdns~=0.9 (from versions: none)
ERROR: No matching distribution found for certbot-dns-duckdns~=0.9

    at /app/lib/utils.js:16:13
    at ChildProcess.exithandler (node:child_process:430:5)
    at ChildProcess.emit (node:events:518:28)
    at maybeClose (node:internal/child_process:1105:16)
    at ChildProcess._handle.onexit (node:internal/child_process:305:5)

I have been working on this problem for about 10 hours now. I have done everything possible. Restarted everything possible and set it up differently.
I have not been able to generate certificates for 2 days.
I am now testing the previous version again. The current version is definitely not working.

Docker Hub
The problem occurred at the same time as the update to Docker Hub.

Found the culprit!!!!!!!
It is not nginx-proxy-manager, but a change of the way to work of Let's Encrypt.
Basically if you have geoblocking in your firewall, this is not allowing the automated procedure to obtain a Let's Encrypt certificate.
Please see here: https://community.letsencrypt.org/t/unexpected-renewal-failures-during-april-2024-please-read-this/216830

Found the culprit!!!!!!! It is not nginx-proxy-manager, but a change of the way to work of Let's Encrypt. Basically if you have geoblocking in your firewall, this is not allowing the automated procedure to obtain a Let's Encrypt certificate.   I've been fighting with this for HOURS, turns out it was Geo blocking in my Unifi gear ... I thought to check that but it wasn't logging the block on the Unifi side, so I moved on to other things.
Thanks!!!!


Reimplement generation of "average" school

modify daily regeneration job to save unvalidated yaml to s3 when enabled by feature toggle
rake task to download files from s3 and run calculation and save to yaml (code copied from https://github.com/Energy-Sparks/energy-sparks_analytics/blob/master/script/modelling/generate_average_school.rb)

rollout plan

enable save_unvalidated_data_to_s3 feature toggle for an overnight run to generate current unvalidated data
run rake school:calculate_average to generate new data
commit updated data with https://github.com/Energy-Sparks/energy-sparks_analytics/pull/714 to use it

Do you have a sense of the impact of adding the generation and upload of the YAML to s3 adds to the overall timing and memory overhead of the daily regeneration process? That process is already quite slow, so am wary about it running for longer even on a day when we're just dumping these files, unless we do it over a weekend perhaps? I'm wondering about whether it would be better to just have a separate job to do this.

It ran ok on test but did take longer than the production run that day.  I will look at AggregateSchoolService.


[AutoPR devtestlabs/resource-manager] [Hub Generated] Review request for Microsoft.DevTestLab to add version stable/2018-09-15

Created to sync https://github.com/Azure/azure-rest-api-specs/pull/6623

(message created by the CI based on PR content)

This PR has been merged into https://github.com/Azure/azure-sdk-for-python/pull/6414


Recognize Props Passed to router-view As Reactive

What problem does this feature solve?
Currently having an issue where I want to

Create a nested router-view
Do some API fetching in the parent
Pass down data to all the children components
Have the children re-render when the reactive values update

What I tried was this
/* my-view.vue */

<template>
  <router-view
    :data="data"
    :loading="loading"
    :error="error"
    :lastUpdated="lastUpdated"
  />
</template>

<script>
import { useAPIRequest } from '@/hooks/useAPIRequest';

export default {
  setup() {
   /* this will make the API request on mount and update the appropriate values on resolve/reject */
    const {
      data,
      loading,
      error,
      lastUpdated,
    } = useAPIRequest(
      () => Promise.resolve([]),
    );

    return {
      data,
      loading,
      error,
      lastUpdated,
    };
  },
};
</script>

<style lang="scss" scoped></style>

/* useAPIRequest.js */

import { ref } from '@vue/composition-api';
/**
 *
 * @param { () => Promise<any> } request
 * @param { any } initialData
 *
 * @returns {
 *  loading: boolean;
 *  error: any;
 *  lastUpdated: number;
 *  data: any;
 * }
 */
export const useAPIRequest = (
  request,
  initialData,
) => {
  const data = ref(initialData || null);
  const loading = ref(true);
  const error = ref(null);
  const lastUpdated = ref(0);

  const handleRequest = () => {
    if (!request) {
      return Promise.resolve();
    }

    if (lastUpdated.value === 0) {
      loading.value = true;
    }
    return request()
      .then((response) => {
        data.value = response;
        loading.value = false;
        lastUpdated.value = Date.now();
        error.value = null;
      })
      .catch((err) => {
        error.value = err;
        loading.value = false;
      });
  };

  handleRequest();

  return {
    data,
    loading,
    error,
    lastUpdated,
    update: handleRequest,
  };
};

export default useAPIRequest;

But this doesn't work because the components that are rendered in the nested routes have access to these values through attrs.data, attrs.loading, attrs.lastUpdated, etc. They are not reactive and the children components don't re-render when these values change
What ended up working for me was passing the values down as refs, like so
/* my-view.vue */

<template>
  <router-view
    :data="data"
    :loading="loading"
    :error="error"
    :lastUpdated="lastUpdated"
  />
</template>

<script>
import { computed } from '@vue/composition-api';
import { useAPIRequest } from '@/hooks/useAPIRequest';

export default {
  setup() {
    const {
      data,
      loading,
      error,
      lastUpdated,
    } = useAPIRequest(
      () => Promise.resolve([]),
    );

    return {
      data: computed(() => data),
      loading: computed(() => loading),
      error: computed(() => error),
      lastUpdated: computed(() => lastUpdated),
    };
  },
};
</script>

<style lang="scss" scoped></style>

But I'm assuming passing down refs is an anti-pattern and probably isn't recommended.
My ask is that I want the ability to pass down reactive values to <router-view /> children and have them re-render when these values change
What does the proposed API look like?
Possibly <router-view render="(Component => <Component myProp="something" />)" />

Some questions that hopefully I can answer before they're asked.

Why not just make the API request in each route?

Because I want to make the API request once and not have to keep making it every time the user navigates to another sibling page. There's no reason the network request needs to be made a second time after it's requested once.

Why not just make the request in a wrapper component and use v-if conditionals on the route.fullPath to determine which child component to render?

Because that defeats the purpose of using the children prop on the router instance entirely. I might as well just never use children in that case.

Hi, thanks for your interest but Github issues are for bug reports and feature requests only. You can ask questions on the forum, the Discord server or StackOverflow.

If you are reporting a bug please follow https://new-issue.vuejs.org/?repo=vuejs/vue#why-repro

ok this is a feature request. There is something vue router doesn't do, that I want it to do. react-router already solves this problem with the proposed API posted above.
I've also already asked on Discord and was directed here.
thanks for closing though extremely helpful :+1:

@posva this is already a thing in vue-router next
https://github.com/vuejs/vue-router-next/blob/master/src/RouterView.ts#L177
So can we get this into this project as well??

In my understanding, the component that's being rendered by the router-view should update.
In Vue 2 / VueRouter 3, props passed to the router-view are passed down to the child. And when these props change, router-view is re-rendered, passing new values to the component it renders for the current route.
Demo: https://jsfiddle.net/Linusborg/15verdpx/
If that doesn't work for you, maybe start demonstrating that?

It has been 2 years, I am wondering what's the up-to-date approach to deal with this issue, assuming we don't introduce pinia or vuex. Also see the recent update here, passing massive data via props is not allowed anymore. Thank you!


feat: image vite transform

Zero runtime, zero JS
Simplest API surface possible (zero props by default)
Strongly typed (You cant referenced 404 images)
Autocompletion supported by typescript
Immutable cached images (hashed files)
Optimized to webp
Automatic width/height (prevent layout reflows)
Automated srcSet generation (ideal image size)
Extendable (add any <img> attribute)
Loading lazy and async decoding
Lightweight, a single <img> node in the HTML

https://www.loom.com/share/23c21ef8d4be464dab59eae6064c918a
import { component$ } from<EMAIL_ADDRESS>import Image from '~/media/image2.jpg?jsx';

export default component$(() => {

  return (
    <div>
      <Image alt='Unsplash image' />
    </div>
  );
});

Output:

It could work, but CDN images should be able to deliver the srcset automatically, this is build-time...
I think something like unpic-qwik should be a better fit for external images

https://github.com/ascorbic/unpic-img

https://github.com/qwikifiers/qwik-image


Web interface not loading

Hello,
I paste my web interface that I received from running the xteve program to my internet browser url search box.  It displays hmmm... can't reach this page the ip address took too long to respond.  I get a ERR_CONNECTION_TIMED OUT.
l want to use xTeVe, but I can't get through to access it.  This is my first time using this program.

Take a look at the documentation, everything is described there:
https://github.com/xteve-project/xTeVe-Documentation/blob/master/en/configuration.md#console-information

I have installed xteve and also cannot get the url shown to work.  Can anybody help? Xteve seems to be running.  I am using a Linux mint system.  Thanks.


merge into opscode-cookbooks/chef-client

chef-client has a ticket (COOK-3155) to add the feature set of omnibus_updater. And there's a pull request that provides some of that functionality (but without any tests).
I'd really like to see this codebase just become the one in chef-client. Interested?

Fwiw, the ability for chef to upgrade itself is going to be built in per this RFC.


feat: dutch locales

Related Issue or Design Document

Checklist

[x] I have read the contributing guidelines and signed the CLA.
[x] I have referenced an issue containing the design document if my change introduces a new feature.
[x] I have read the security policy.
[x] I confirm that this pull request does not address a security vulnerability.
If this pull request addresses a security vulnerability,
I confirm that I got approval (please contact<EMAIL_ADDRESS>from the maintainers to push the changes.
[x] I have added tests that prove my fix is effective or that my feature works.
[x] I have added the necessary documentation within the code base (if appropriate).

Further comments

I've fixed it up and it should be alright

Thanks Alano!


Headless JS  doesn't work when app is killed

Environment
React Native Environment Info:
System:
OS: Windows 10
CPU: (4) x64 Intel(R) Core(TM) i5-3337U CPU @ 1.80GHz
Memory: 860.27 MB / 3.89 GB
Binaries:
Yarn: 1.12.3 - C:\Program Files (x86)\Yarn\bin\yarn.CMD
npm: 6.4.1 - C:\Program Files\nodejs\npm.CMD
IDEs:
Android Studio: Version  <IP_ADDRESS> AI-181.55<IP_ADDRESS>56338
react: "16.6.3",
react-native: "0.57.8",
Description
I'm looking for a way to run task or service when the app is killed (not in background state), I tried to use Headless JS but it's working in foreground only, then I tried the JobScheduler but it doesn't seem work when app is killed.
My task is about fetching data from server and push notification in some conditions.
Any help please.

you cannot run anything when app is killed.

@RittaIbrahim did you get Headless running while app in background ?
can you share any code base for it.

Same issue here. I disagree with @dulmandakh that you cannot run anything.
After I kill the app, then send it a push notification, I can see in logcat that the app wakes up and Firebase handles the notification. I also want to let JS handle the notification. Then the app crashes because of the following: https://stackoverflow.com/questions/46445265/android-8-0-java-lang-illegalstateexception-not-allowed-to-start-service-inten/49846410#49846410.

It seems like HeadlessJsTaskService needs to be updated to use Job / JobScheduler https://developer.android.com/reference/android/app/job/JobScheduler.html

import {AppRegistry} from 'react-native';
import App from './App';
import {name as appName} from './app.json';

AppRegistry.registerComponent(appName, () => App);

AppRegistry.registerHeadlessTask('RNFirebaseBackgroundMessage', () =>
  console.log('bgMessaging: ', new Date()),
);

Headless works when the app is in the background but not when app is killed

@RittaIbrahim Headless JS seamlessly works when the app is killed i.e even when it is not in background. I had to handle In-line reply for push notification in my android app and Headless JS was the perfect solution for it. The documentation is very neat provided by them and it doesn't. Try setting to the timeout to 0 sec or min as required by your task and that should work fine.

import {AppRegistry} from 'react-native';
import App from './App';
import {name as appName} from './app.json';

AppRegistry.registerComponent(appName, () => App);

AppRegistry.registerHeadlessTask('RNFirebaseBackgroundMessage', () =>
  console.log('bgMessaging: ', new Date()),
);

Headless works when the app is in the background but not when app is killed

The above code doesn't work.


samples: updates samples to v1 (1 of several)

This updates the java-aiplatform samples to use the v1 version of the samples.

Note: I'm still working on this PR a little bit (adding in resource IDs for tests)--I just wanted to get more results from CI. I'll repost when it's fully ready for review.

Samples now ready for review. This PR also picked up some linter fixes unrelated to the primary changes.


llvmPackages.clang: don't pass -Wno-maybe-uninitialized to clang

Description of changes
If building clang under clang, don't pass -Wno-maybe-uninitialized;
this is a gcc-only warning and clang emits a diagnostic for every TU
about the unknown warning flag.
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Thank you for the PR, will review this later.


About register-update behavior

According to "OMA-TS-LightweightM2M-V1_0_2-20180209-A", when object instances are created or deleted, "Register-update" message should convey all the supported Objects and Object Instances available on the LwM2M Client.
But in leshan client, payload of Register-update contains nothing even when object instances are created or deleted, is this behavior expected?
Please refer to Figure: 6.2.2.-2 Update Example Flow #2.
'When any of the parameters listed in Table: 6.2.2.-1 Update Parameters changes, the LwM2M Client MUST send an "Update" operation to the LwM2M Server. This "Update" operation MUST contain only the parameters listed in Table:6.2.2.-1 Update Parameters which have changed compared to the last registration parameters sent to the LwM2M Server.'
'When present,the Objects and Object Instance list MUST contain all the supported Objects and Object Instances available on the LwM2M Client.'
Thanks.

Thx to reporting this, we are aware of this but this is currently not implemented ...  :cry:
(see #433 and #434)


Gardenlet panics when deleting Shoot

How to categorize this issue?

/area quality
/kind bug
/priority blocker
What happened:
#2449 seems to have introduced a regression: when the gardenlet tries to cleanup webhooks in the shoot with the kube-apiserver deployment scaled down to 0, it panics here:
https://github.com/gardener/gardener/blob/f120f2c74a503ab4a388aa055cd08d4081eaf5ed/pkg/operation/botanist/cleanup.go#L183
This is probably because the Shoot clients are not initialized anymore, if the kube-apiserver is scaled down:
https://github.com/gardener/gardener/blob/f120f2c74a503ab4a388aa055cd08d4081eaf5ed/pkg/operation/operation.go#L293-L300
What you expected to happen:
gardenlet not to panic
How to reproduce it (as minimally and precisely as possible):
Anything else we need to know?:
Environment:

Gardener version: v1.7.0-dev-e47e4c057e49b2245529ac3a7bffc943973f40d1
Kubernetes version (use kubectl version):
Cloud provider or hardware configuration: azure (but probably also applies to others)
Others:

Hmm, this seems to be a race condition between gardenlet and dwd.

/assign


[WIP] PostgreSQL State Store

Description
Work in Progress - please review for feedback. This PR implements a state store in PostgreSQL.
Open Questions:

All keys are treated as strings by this store. I can add configuration to instruct Postgres on which data type to use for the key, and validate based on that type, similar to how the SQL Server state store implements it. Key lookups for integer keys would be faster.
Does Dapr impose a limit on key size? I currently have a limit of 200 characters and treat all keys as strings.

Remaining work:

Implement consistency flags
Implement TransactionalStore
Implement limits and validation on key size
Parameter validation for request structs
Use logger where appropriate
Update the vendor folder for third party code where necessary
Manual integration testing with a full Dapr application
Run benchmark tests
Extend documentation

Package tests cover 83.7%. Non covered code is mostly error returns from calling other functions.
Issue reference
Please reference the issue this PR will close: #225
Checklist

[x] Code compiles correctly
[x] Created/updated tests
[ ] Extended the documentation / Created issue in the https://github.com/dapr/docs/ repo: dapr/docs#[issue number]

@youngbupark, @yaron2

I'm looking at build failures. One timeout and two failures at the go.mod check-diff step.

If so,
Do go mod tidy and push the changes.

Yes
go version go1.14.2 linux/amd64

Thanks for the feedback on go mod tidy

Thanks for this PR!

All keys are treated as strings by this store. I can add configuration to instruct Postgres on which data type to use for the key, and validate based on that type, similar to how the SQL Server state store implements it. Key lookups for integer keys would be faster.

I think its Ok to add a data type metadata which is optional and then validated.

Does Dapr impose a limit on key size? I currently have a limit of 200 characters and treat all keys as strings.

Dapr does not impose a limit on key size.

The TransactionalStore interface is now implemented.

@brooke-hamilton can you please update the progress on description ?
JFYI - I added checkbox for each remaining work items. :)

@youngbupark I updated the progress in the description.
One question: the CONTRIBUTING.md document states "All third-party code must be placed in the vendor/ folder." I don't see any specific configuration that puts dependencies into the vendor folder. Is there an additional step I need to take, or is this an automatic part of the build?

@youngbupark I updated the progress in the description.
One question: the CONTRIBUTING.md document states "All third-party code must be placed in the vendor/ folder." I don't see any specific configuration that puts dependencies into the vendor folder. Is there an additional step I need to take, or is this an automatic part of the build?

CONTRIBUTING.md doc is wrong, we will update it. We no longer use /vendor after switching go mod. 3rd party pkg will be downloaded when we build the code. So you do not need to care about it.

@brooke-hamilton are there any more outstanding items for this PR?

@brooke-hamilton are there any more outstanding items for this PR?

@yaron2, I have only one more potential change I would like to get your opinion on. Currently the PostgreSQL table name is hard coded, but I would like to have the table name as a configuration item. However, PostgreSQL does not allow table names to be used as parameters in SQL statements, which forces me into using string concatenation to build the table name into each query. If the table name becomes a user configurable item, then that would potentially expose the code to SQL injection attacks. I am still looking for a good alternative, like a golang function that will check a string for malicious input, but haven't found a solution. Any ideas? How do you feel about the table name being hard coded?

@brooke-hamilton are there any more outstanding items for this PR?

@yaron2, I have only one more potential change I would like to get your opinion on. Currently the PostgreSQL table name is hard coded, but I would like to have the table name as a configuration item. However, PostgreSQL does not allow table names to be used as parameters in SQL statements, which forces me into using string concatenation to build the table name into each query. If the table name becomes a user configurable item, then that would potentially expose the code to SQL injection attacks. I am still looking for a good alternative, like a golang function that will check a string for malicious input, but haven't found a solution. Any ideas? How do you feel about the table name being hard coded?

Most of our state stores have the table name hard-coded. This is fine as long as it's mentioned in the docs.

@yaron2, I implemented the requested changes. (Thank you for the review!) I'm not sure if I pressed the right buttons to correctly update this PR, but the changes are there.

This is merged and will make it to next week's release.
Thanks a bunch @brooke-hamilton!

@brooke-hamilton Thanks a lot for this contribution!

@yaron2, should I submit a PR in the dapr/dapr repo for cmd/daprd/main.go to integrate the postgres state store?

Yes, for sure!


feat: Migrate extensions into CCA (entry-extension-collapsible) [EXT-2566]

Ticket: https://contentful.atlassian.net/browse/EXT-2566
This PR is the first of several PRs which implement the migration of the extensions from CCE into CCA.
In this PR we are migrating the entry-extension-collapsible extension.
PS: I decided to do one PR per extension for readability and easier/faster code reviews. :)

Thanks for the review @kdamball! Made updates relevant to your comments. 🚀


Add researcher

There are various ai-researcher options out there, AutoGPT, BabyAGI, gpt-researcher, MS AutoGen, etc. Wade through them all and find something that works in this context

The current :search feature using LangChain's Agent with DuckDuckGo. It's ok but behaves more like a chain and autonomous agent. It's also single-agent

I tried LangChain's WebResearcher but the :search agent actually performed better

I really like the idea of multiple agents that communicate to solve a problem. MS's AutoGen is intriguing but I ran into problems just testing things in their notebook like long latency and exceeded context windows. Need to dig in deeper


Issue 41827: Exp schema very slow (and sometimes non-responsive) to lookup to or open the schema browser

Rationale
ensureFileData crawls all files under the current directory (every 5 minutes or when accessed) to make sure all files have a corresponding exp.data record. This could be a very expensive action if the number of files are large. In the case of browsing schema tree for exp, there is no need to sync files since only basic metadata of the table is needed.
Related Pull Requests

Changes

skip ensureFileData for exp.files on expanding schema tree

I like the idea of being able to construct a table for the purposes of "metadata only" in general. I think @labkey-matthewb had some thoughts that in the past so maybe he can chime in.
However, I question the need to crawl the file system root at all when creating the table. It seems orthogonal to ensuring there are exp.data rows which could be done in a background service. Crawling the fileroot every 5 minutes seems excessive to me as well, but I don't know the original scenario.

For background, see original spec at https://docs.google.com/document/d/1DvpuDaAtDMCz00Tk1cAVBNmLRhHsz4ShMatQ_9yscrI/edit

Two ideas to reduce the scope of the change but perhaps still meet the original requirements:

Make the file system scan run in a background thread. Since we're not guaranteeing it's fully consistent (due to the 5 minute timer) this might be a trivial change.
Keep the scan synchronous, but move it from the constructor to when we generate SQL, which would prevent it from running when we're creating the TableInfo for metadata purposes. This could be done by overriding getFromSQL(), kicking off the scan, and then calling the superclass method.

To answer Kevin's question.  We do have a lightweight object called TableDescription, it would be great to use this in more places that just need to know that a table exists and its name, but not ColumnInfo.  It could be very useful for UserSchema to implement getTableDescriptions() or something like that.  But that's too much for 21.3.
To Josh's suggestion.  Yes!  I've done a ton of work to push work out of TableInfo constructors into
TableInfo.getFromSQL() or ColumnInfo.getValueSql().  There is a lot of work that can be delayed until the TableInfo is actually used get fetch data.  I always support this!
_getTableOrQuery is already so complicated that (especially now with caching), I'm wary of having yet another kind of TableInfo construction option.

new PR https://github.com/LabKey/platform/pull/2043


Puppeting an existing Mattermost user

Hello!
Disclaimer, I honestly had no better idea for a shorter title, sorry for that...
Basically, I used to frequent the JS++ Mattermost instance to talk to the people there but now that I use Matrix as my daily driver for just about all my IM needs, I wanted to bring this group back into my setup so I could talk to them again.
I only own a regular account and really only need this one to be puppeted. How would I go setting up a scenario like this, where just one user is puppeted and all channels it can access are thus bridged?
Thanks in advance!
Kind regards,
Ingwie

I don't know of a good way to do this.


soc02h-cc-Jessica-Sanchez Jessi_RS [Gold]

Solution hackathon WK2
Jessica Abigail Sanchez Cervantes

Sorry for the mess.. I'm still learning GitHub, I accidentally loaded a wrong version and tried to correct it.
Please review the tab Correct File with the  CORRECT soc02h-cc-Jessica-Sanchez.zip
Thanks in advance,
Jess Sanchez

Great job on building a fully working boggle game!
To level up your solution you could also have the computer find all the possible words in the board and then turn your game into player vs computer and show the computer’s result as well as the player’s result.
I really liked how you showed which words were found in the dictionary and which weren’t, that’s a really nice user-friendly addition.
One of the times I played your boggle game, I couldn’t find any words at all when looking at the board so I pressed enter straight away and that caused an error. You could level up your code by checking all the sections where the user input could be wrong or unexpected to ensure the user can’t break the program whether accidentally or intentionally.
I like that you load the dictionary from the internet rather than relying on the user to download or upload a file before they can play. It’s also great that you offer multiple sizes of boggle boards
Congratulations on creating your solution for the week 2 hackathon, I hope you enjoy the rest of the summer!

Branch name changed from 27072018 to HackathonWk2


Solutions submitted are not fully visible sometimes

I came accross some solutions in the classroom that at first I thought were incomplete but were actually not being displayed correctly.
See this one as an example, the solution #27
http://pdep-utn.classroom.mumuki.io/#/pdep-utn/2016-tar-mi/mumuki-guia-funcional-practica-valores-y-funciones/auth0|56f6a79f9a7df0726f99e57e/12
It looks like it's only
esBisiesto n1 = (esMultiploDe n1 4) && not(esMultiploDe n1 100)
but if you double click to select the whole thing and copy it somewhere else it actually says
esBisiesto n1 = (esMultiploDe n1 4) && not(esMultiploDe n1 100) ||(esMultiploDe n1 400)
I was really confused at first cause all tests were passing, even the one that verified that missing condition.

Fixed.
@mmatos please check now


Investigate using BigInt's with < 4 limbs for FieldElement's

Problem
bn254 FieldElement's are defined in acir_field
pub type FieldElement = field_element::FieldElement<ark_bn254::Fr>;

Where field_element::FieldElement wraps its argument and ensures it's a PrimeField:
pub struct FieldElement<F: PrimeField>(F);

ark_bn254::Fr is defined as:
pub type Fr = Fp256<MontBackend<FrConfig, 4>>;

Where Fp256 defines the contents (MontBackend.. defines the FpConfig):
pub type Fp256<P> = Fp<P, 4>;

And Fp:
pub struct Fp<P: FpConfig<N>, const N: usize>(pub BigInt<N>, _);

Is an N-limbed BigInt:
pub struct BigInt<const N: usize>(pub [u64; N]);

So our bn254 FieldElement's are always represented by [u64; 4], even when their values are much smaller than u64::MAX
Happy Case
Investigate client-size memory savings and performance overhead of using a flexibly-sized big integer type instead of BigInt<N>, e.g. this BigInt, which uses a Vec of limbs
Workaround
None
Workaround Description
No response
Additional Context
No response
Project Impact
Nice-to-have
Blocker Context
No response
Would you like to submit a PR for this Issue?
None
Support Needs
No response

Isn't this expected however? We have 4 u64s because it's a bn254 field representation, if you provide a different AcirField implementation for another field modulus then it'll be backed by a different number of limbs, etc.

@TomAFrench yes, this is somewhat expected because we can need 4 u64's to represent a bn254 element, but we don't need exactly 4 u64's for smaller field elements. For example, GMP uses a variable number of limbs that are dynamically (re)allocated as needed. E.g. 8 uses only one limb, 2^65 uses two limbs, etc.

My point is that you can use anything which satisfies the AcirField trait and we're not enshrining a particular number of limbs (until you get further up into nargo which isn't yet generic)


Ubuntu 16 fix

Ubuntu 16 has an old version of fio, so one of the argument names is different.
Also, for unclear reasons, ubuntu 16 tests on the c3 machine type hang.

/lgtm


Allow ActionList.Item to be a link

Description
Allow ActionList.Item to be a link
Design

[ ] Design is finalized. Link to mockups/prototypes:
[ ] Design is being finalized by feature team. Link to any in progress mockups:
[ ] Assistance requested in finalizing design

Component API
Possibilities:
<Item as={Link} href={...} />

<LinkItem href={...} />

Usage
Describe how the component should be used, and/or link to usage guidelines.
Implementation
Please describe how you would like this component to be built. Design systems is happy to help with the implementation of new components (as time/roadmap allows) but also recognizes that sometimes feature teams prefer to implement components themselves.

[ ] Feature team would like to implement this component
[ ] Feature team would like the Design Systems team to implement this component
[ ] This component is already built, feature team requests assistance moving it to Primer React Components from outside application
[ ] Other: (please describe below)

Timeline
Please describe any deadlines or context around prioritization that would be helpful for us to use when building our roadmap.
What to expect next
A Design Systems engineer will read through your component proposal and get in touch! We'll gather any additional information needed and set up a Zoom call only if necessary. Once we have all relevant information, we'll add the component to our Primer React Components Roadmap. If you opt to build the component yourself, we are happy to help with pairing, brainstorming, etc. Generally, component work requested from internal feature teams receives higher priority over general (non-requested) improvements to the library.

As far as the component API - I think the case of
<Item as={Link} href="" /> might be better generalized as <Item as={Link} {...LinkProps} /> which would encapsulate the react-router scenario of <Item as={ReactRouterLink} {...ReactRouterLinkProps} />

To generalize upon what @mattcosta7 was saying, <Item as={T} {...P} /> where T is string | React.ComponentType and P is React.ComponentProps<T> & ItemProps.

From @mattcosta7 in https://github.com/primer/react/issues/1413#issuecomment-915409164:

As far as the component API - I think the case of
<Item as={Link} href="" /> might be better generalized as <Item as={Link} {...LinkProps} /> which would encapsulate the react-router scenario of <Item as={ReactRouterLink} {...ReactRouterLinkProps} /> (which would use to={LinkDescriptor} instead of href directly)

From @jclem in https://github.com/primer/react/issues/1413#issuecomment-915413364:

To generalize upon what @mattcosta7 was saying, <Item as={T} {...P} /> where T is string | React.ComponentType and P is React.ComponentProps<T> & ItemProps.

We’ve previously explored type-safe as using @radix-ui/react-polymorphic. Here’s a quick demo of how this could work: https://codesandbox.io/s/as-prop-demo-forked-ox2b1?file=/src/App.tsx

Given these usage options...
        <ActionList
          items={[
            {text: 'A) Vanilla link', as: 'a', href: '/about'},
            {text: 'B) as React Router link', href: '/about', as: ReactRouterLikeLink},
            {text: 'C) React Router link via renderItem', href: '/about', renderItem: props => (
              <ReactRouterLikeLink component={ActionList.Item} {...props} />
            )},
            {text: 'D) NextJS style via renderItem', renderItem: props => (
              <NextJSLikeLink>
                <ActionList.Item as="a" {...props} />
              </NextJSLikeLink>
            )}
          ]}
        />

Is there anything else we'd need? Is there a reason to support B if C is an option?

From the perspective of Next.js, D looks great. I'm less familiar with react-router, but @mattcosta7 can probably weight in there.

React Router is supposedly dropping support for as/component type stuff, I believe in v6 in a push to make sure people actually render 'a' tags for links, so i'm not sure if that will be supported in the future, but <ActionList.Item as={ReactRouteLikeLink}> would be

Okay, I think we can drop B... and maybe we could drop A too? It's syntactic sugar for
            {text: 'A. Vanilla link', as: 'a', renderItem: ({...props}) => (
              <ActionList.Item as="a" href="/about" {...props} />
            )},

And maybe that wouldn't be used very often if everyone needs to use RR links or Next links anyway?


Bug: clicking on badge does not remove note

When a user creates a note, a 'cross' is shown inside a 'badge'.
Clicking on cross removes note but not clicking no badge.
Either remove the badge and only show cross, or make sure that clicking on badge also deletes the note

I would like to work on this issue.


Project Programmer fails to compile

Description
Building the Programmer project with error:
Programmer\TargetTester.cpp(448,16): error C2039: 'status': is not a member of 'ETarget'
Programmer\Programmer.hpp(21,7): message : see declaration of 'ETarget'

Repro steps

Build solution

Environment
Visual Studio 2022
C++ ver: /std:c++latest
Tested commit: 211c74d1f14c6585e94b28bed1e976f73730ffb9

The problem is caused because I'm not commited a changes in the Programmer.h. This project is in the early stages of development, and I'm not quite following the rules. I promise to behave better :)


Add a sleeping_state_changed signal to RigidBody and RigidBody2D

Closes #3911
Also, I tested both classes, and they work :smile:.

Looks good, very nice feature ,removes need for polling in GDScript.
I think there are so many places that need things like this, I need to look at some my project to see where I needed to excessively poll things from script....


Answers integrated into Q&A page

Issue that this pull request solves
Closes: #885
Screenshots

Other information
Any other information that is important to this pull request

Hey @Kajol-Kumari
Please review the request


Windows fixes

Remaining issue The system cannot move the file to a different disk drive. (os error 17) needs better selection of cache dir. Will be done on main.


Bump to Kubernetes 1.26.2

Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

/approve

/lgtm


Metrics base url

This changes the call to metrics url, by adding a tvm specific key to the base-url passed as a param
Checklist:

[x] I have signed the Adobe Open Source CLA.
[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[x] I have added tests to cover my changes.
[x] All new and existing tests passed.

Changes look good!
One thing, I noticed we're not checking for a metricsUrl before calling incBatchCounter, and if I'm not mistaken the implementation of incBatchCounter doesn't perform that check either. Is this going to result in us not being able to process errors correctly if metricsUrl isn't set? I.e we end up not returning the appropriate error response to the user, because we errored out in the catch?


112x: fix rateParameters ranges

This is a bug appearing from the 112x series.
Likely something has been enforced in the roofit factory expression creation.
factory expressions now needs to be in range to be created correctly. I assign as default +/- twice the value for such parameters. this should fix it for both rateParams and extArgs.
Notice that this range is going to be removed after.
For the rateParameters, I put an additional check for those ranges that are input in the datacard, raising eventually an exception.
This has been tested on comb_2021_tth_multilepton.root
It should affect all the 112x series; namely 112x, 112x-comb2021, 112x-comb2022, and root626

this seems good: https://gitlab.cern.ch/cms-hcg/performances/ci/-/pipelines/4308317

In the last run, I change the minimizer to run w/ as many calls as it needs and everything is aligned.

So previously some const rateParams were being clamped to [0, 1] interval and hence the fit results disagreed?

Yes, parameters were cropped in the [0,1] interval. In previous versions of ROOT, the factory seemed to have a different behavior. Although,  I remember that in doing setParameters the range was already an issue in the 102x root version.


Swiper has different behaviour when using the '--prod' flag

I have the following issue:
I have a swiper which behaviour is correct when I serve my Angular project.
When I build or serve it with the --prod flag, the swiper behaviour is no longer correct, ad it's different from the serve without the --prod flag.
This happens only with a swiper in the entire app, but I can't figure the problem out.
The only thing I've added, it's a function to hide the slides, adding only a class (in this case _off) which only gives opacity: 0 to the slide.
I cannot provide you a working demo of the project, but I can provide you 2 GIF and the configs.
The correct behaviour is:

The --prod (incorrect) behaviour is:

(The GIFs are a little bit slower than the real video, sorry about that)
My config params are:
{
  direction: 'vertical',
  slidesPerView: 1,
  mousewheel: {
    invert: true
  },
  effect: 'coverflow',
  coverflowEffect: {
    rotate: 0,
    stretch: 150,
    depth: 170,
    modifier: 1,
    slideShadows : false
  },
  pagination: {
    el: '.swiper-pagination',
    clickable: true,
  },
}

If you need also the "custom" function for the _off class, here you are:
checkSwiper(index, swiper, visibleSlides) {
  let nodes = swiper.swiperSlides.nativeElement.childNodes;
  let slides = [];
  for(let i = 0; i < nodes.length; i++) {
    if (nodes[i].nodeType != Node.TEXT_NODE && nodes[i].nodeType != Node.COMMENT_NODE) {
      slides.push(nodes[i]);
    }
  }
  // Remove hidden class to all slides before the check
  for(let i = 0; i < slides.length; i++) {
    slides[i].classList.remove('_off');
  }
  // Set hidden class to all slides from the first one to the active one
  for(let i = 0; i < index - visibleSlides; i++) {
    slides[i].classList.add('_off');
  }
  // Set hidden class to all slides from the active one to the end
  for(let i = index + (visibleSlides + 1); i < slides.length; i++) {
    slides[i].classList.add('_off');
  }
}

Other useful info:

@angular/cli: 7.3.3
ngx-swiper-wrapper: 7.2.1
swiper (if you need also this one): 4.5.0

I hope someone can help me, because I really can't figure it out.

That does seem rather odd. The only thing I can think of is some sort of change detection problem. The only difference between the normal and prod build should be that the extra change detection cycle is dropped off. So I would try adding change detector detectChanges call to the functions that changes the swiper elements.

@sconix Thank you for your answer, I assume the only thing I have to do is wait for your testing, and a solution or an update of the package.
If there's something I can do in order to help, please tell me!
Thanks!

I meant that you need to test it in your app, I do not believe it has nothing to do with this library. To me it sounds like a change detection issue in you application. So I could not even test this without a reproduction.

Ok, so after a lot of debugging and compiling, I found out what causes the wrong behaviuor:
My old HTML was like:
<swiper
	#swiperRequests
	[config]="requestsSwiperConfig"
	[index]="requestsCard.length - 1"
	(indexChange)="checkSwiper($event, swiperRequests, 2)">

		[...]

</swiper>

I found out that nothing brake if I remove the *ngFor and copy-paste the markup in order to have more slides, so like this:
<swiper
	#swiperRequests
	[config]="requestsSwiperConfig"
	[index]="requestsCard.length - 1"
	(indexChange)="checkSwiper($event, swiperRequests, 2)">

		[...]

		[...]

		[...]

</swiper>

In the end, the problem was caused by the reverse() function, and using the slice() function before the reverse() function, solves the problem. The actual solution is the following:
<swiper
	#swiperRequests
	[config]="requestsSwiperConfig"
	[index]="requestsCard.length - 1"
	(indexChange)="checkSwiper($event, swiperRequests, 2)">

		[...]

</swiper>

I don't know if it's the correct solution, maybe reversing the array in the TS without using the slice() works as well, and it's more correct than the actual version.
Anyway, thanks for your time!

Ah that kinda makes sense, since in debug mode the change detection is run twice so your array always reverted back to correct order, but with aot the change detection is run once so the every second time you array was in wrong order and caused weirdness on the rendering side. At least I think thats what happened. Anyway good that you got it solved.


chore: implement new way of claiming all rewards

Purpose

How does the solution address the problem

Changes made

prnet cleaned-up successfully


Can't login due to an infinite loop.

I tried to update to the most recent build, delete the config file, and past back in the username/password/cookie/oauth, but no matter what I do, I keep getting this error message.
Error at doLogin(): (<class 'mechanize._response.get_seek_wrapper_class..httperror_seek_wrapper'>, <httperror_seek_wrapper (urllib.error.HTTPError instance) at 0x43fe268 whose wrapped object = <HTTPError 302: 'The HTTP server returned a redirect error that would lead to an infinite loop.\nThe last 30x error message was:\nFound'>>, <traceback object at 0x043FD808>)
Cannot Login!
Since I've tried everything I could think of I'm relatively sure the issue is program side.

ensure the useragent value also matching with the browser you used to get the cookie from.

I have exact same problem. Cannot login due to redirect error that would lead to an infinite loop

for me the problem was that the cookie value in the config was old, got the new one from the browser and it worked

might be useful for reference #814


🔧 Add pre-commit config and first run

🔧 Add pre-commit config and first run

This was done in https://github.com/tiangolo/sqlmodel/pull/661 and https://github.com/tiangolo/sqlmodel/pull/667


v0.3.0 Homebridge crashes on Pairing

Description
When attempting to pair device Homeebridge crashes (sigterm) and restarts.
Reproduction Steps
Steps to reproduce the behavior:

Start Homebridge
Authenticate plugin
Add new devices in Home

Expected Behavior
Expected behavior is that device will pair and homebridge will not be effected. Actual results is that Homebridge crashes and device never completes pairing.
Logs
[11/24/2020, 15:13:16] TypeError: Cannot read property 'params' of undefined
    at HAPServer._this._handlePairStepOne (/usr/local/lib/node_modules/homebridge/node_modules/hap-nodejs/src/lib/HAPServer.ts:380:27)
    at HAPServer._this._handlePair (/usr/local/lib/node_modules/homebridge/node_modules/hap-nodejs/src/lib/HAPServer.ts:362:12)
    at IncomingMessage.<anonymous> (/usr/local/lib/node_modules/homebridge/node_modules/hap-nodejs/src/lib/HAPServer.ts:280:24)
    at IncomingMessage.emit (events.js:315:20)
    at endReadableNT (_stream_readable.js:1220:12)
    at processTicksAndRejections (internal/process/task_queues.js:84:21)

Additional Context
I'm also still having a general problem with discovery in HK, and the only device that is discovered is my Echo Show. Clicking the "add anyway" to pair is what causes homebridge to crash.

This seems like something wrong in HAP-NodeJS or its fast-srp-hap  dependency: https://github.com/homebridge/HAP-NodeJS/blob/master/src/lib/HAPServer.ts#L380

You’re right. I have had external accessories before, but I just tried to add another one from a different plugin and same results.

Yeah, something is funky with your Homebridge installation. I would try reinstalling and/or filing a bug with Homebridge directly.

For posterity sake -  I did get the crashing issue resolved by running a reinstall of Homebridge.


Question: <template> syntax

Quick question as I'm out of the loop here. What's the deal with the <template> syntax below execution result comments that gets thrown around?

Is there some special tooling that creates them or is that simply the way we standardized on to represent JSX and other DOM framework variants in pseudocode?

@JosXa I believe that's specific to one library in particular. But I think these examples are mostly used to provide some way of showing how things might integrate with the DOM. Syntax/framework may vary.

adding on to what @EisenbergEffect said,
in signal-utils, I wanted to use a made up syntax -- I didn't want to use JSX, because it has assumptions that are implementation dependent -- and that could lead to subtle miscommunications.
I didn't want to exactly use any framework (that I know of)'s syntax to try to not show favoritism (in reality this is a Svelte and Ember hybrid, which are, in turn, influenced by a few other things).
The goals of this psuedo code is to demonstrate that things are "mostly JS" (as to not be too distracting to foreign syntax), but a rendering system brings you through the final mile, implying that the framework handles effects, etc -- the purpose of all is to mainly look more like something you might encounter in the wild, rather than lower-level things (like rendering effects as in the proposal's README's examples)

Great, thank you for thorough explanation! :)


AttributeError: 'Role' object has no attribute 'has_permissions'

I'm trying to insert the roles in the table via shell and I'm met with this error.
Checking with Google was met with a probable indentation error but I checked extensively and it was not it.
Code is here: https://pastebin.com/xsVEhtcn
Any help?

The method is called has_permission, in singular. In this particular usage you entered has_permissions in plural.

Damn, I completely missed that.
Thanks for your quick reply!

@miguelgrinberg Other than having permissions as strings, Is their a work around or a similar alternative when using bits as permissions in case you have more than 63 permissions?


History DDL generation for Postgres does not respect non-public schema

Expected behavior
Have a @History entity that specifies a schema (in this case "gen")
@History
@Entity
@Table(name = "o_country", schema = "gen")
public class Country ...

Generate the DDL.
Actual behavior
The generated table, history table and history view are all good.
The issue is with the stored procedure in that it does not use the schema.  The effect of this is that when the history trigger fires to insert into the history table this fails with an error.
  ERROR: relation "o_country_history" doe snot exist Where: PL/pgSQL function o_country_history_version() line 4 at SQL statement

The generated stored procedure (that is missing the use of "gen" schema is):
create or replace function o_country_history_version() returns trigger as $$
begin
  if (TG_OP = 'UPDATE') then
    insert into o_country_history (sys_period,code, name) values (tstzrange(lower(OLD.sys_period), current_timestamp), OLD.code, OLD.name);
    NEW.sys_period = tstzrange(current_timestamp,null);
    return new;
  elsif (TG_OP = 'DELETE') then
    insert into o_country_history (sys_period,code, name) values (tstzrange(lower(OLD.sys_period), current_timestamp), OLD.code, OLD.name);
    return old;
  end if;
end;
$$ LANGUAGE plpgsql;

With this fixed the resulting ddl is:
Note the "gen" schema used in the procedure name, internally in the procedure and also the trigger.
alter table gen.o_country add column sys_period tstzrange not null default tstzrange(current_timestamp, null);
create table gen.o_country_history(like gen.o_country);
create view gen.o_country_with_history as select * from gen.o_country union all select * from gen.o_country_history;

create or replace function gen.o_country_history_version() returns trigger as $$
begin
  if (TG_OP = 'UPDATE') then
    insert into gen.o_country_history (sys_period,code, name) values (tstzrange(lower(OLD.sys_period), current_timestamp), OLD.code, OLD.name);
    NEW.sys_period = tstzrange(current_timestamp,null);
    return new;
  elsif (TG_OP = 'DELETE') then
    insert into gen.o_country_history (sys_period,code, name) values (tstzrange(lower(OLD.sys_period), current_timestamp), OLD.code, OLD.name);
    return old;
  end if;
end;
$$ LANGUAGE plpgsql;

create trigger o_country_history_upd
before update or delete on gen.o_country
for each row execute procedure gen.o_country_history_version();

So the fix here is just to remove the 'normalisation' of the table name (which strips the schema and quoted identifiers).  This might be a problem if/when people desire to use quoted identifiers with @History (but we might have a problem there anyway).  I personally discourage the use of quoted identifiers so I'm happy enough to not handle that case and see if the need actually arises.
So yes, I'm happy enough with this fix (removing the normalisation of the base table name).


Remote Desktop Services: URLs redirected from MSDN

Description:
While answering the question in ticket #4385 (URL format is not clear), I found that most of the linked attribute URLs in this page (Remote Desktop client Universal Resource Identifier (URI) scheme support)
(https://docs.microsoft.com/windows-server/remote/remote-desktop-services/clients/remote-desktop-uri) were pointing to TechNet or MSDN pages, permanently redirected to their current docs.microsoft.com pages. I found it useful to replace the original TechNet/MSDN URLs with their docs.microsoft.com counterparts.
Changes proposed:

Replace TechNet or MSDN URLs with docs.microsoft.com redirects
Replace "No newline at end of file" with a newline (line break)
Add a blank line between the metadata section and the page title
Add MarkDown indent marker compatibility spacing (1 space)
Remove end-of-line whitespace (blanks) (2 lines)
Align a few of the table row columns in close proximity

Ticket closure or reference:
Closes #4385

#sign-off


PDF Journal Fade at Bottom

Hi,
I noticed that with your module enabledthe PDF page has a bit of a fade into the bottom of the journal that works fine for text journals but not for pdf as the page doesn't fully load in.
Is there a way to disable this? I noticed it seems to happen with the SWADE Rifts journals but not the core SWADE journals unless this module is enabled.
If that isn't possible, learning how to move the title of the journal over from on top to the left like you have would be great. It all comes back to the PDF. If I can get that title moved and the fade into bottom mechanic gone, I'd have more space for the page.
Thank you!

Hi, wanted to up this issue, it is also problematic for me

I believe something in Foundry caused this, because from PDF Pager module, the author has undone a previous change:
https://github.com/farling42/fvtt-pdf-pager/commit/a77b04fc58463b712ca24c4ed73671e0e43887f5
which originally was added here
https://github.com/farling42/fvtt-pdf-pager/commit/821f50a2562a08d77616f7d107a94ad5e2180bf1
.sheet.journal-entry .journal-entry-page.pdf {
    height: 100%;
}

.journal-entry-page.pdf iframe {
    min-height: unset;
    flex-basis: unset;
}

Anyways @ClipplerBlood - the CSS snippet above will fix this in journal-improvements.css
Will submit a patch, althogh it seems that Farlon in PDF Pager removed it since now Foundry 10.290+ fixes this out of the box. But I could investigate why it doesn't impact this module.

Submitted PR https://github.com/ClipplerBlood/journal-improvements/pull/12


Verify number of requests when interceptors attached

Should not duplicate any requests

Current coverage is 99.30% (diff: 100%)

Merging #30 into master will not change coverage

@@             master        #30   diff @@
==========================================
  Files             8          8
  Lines           143        143
  Methods          35         35
  Messages          0          0
  Branches         15         15
==========================================
  Hits            142        142
  Misses            1          1
  Partials          0          0

Powered by Codecov. Last update ce7f4fb...4f7d659

Closing for now until problem resolved


Error Fixes, Code Tidy and Completing Maintenance Mode

I have fixed many errors in the code that were causing errors when using the module.
I have also completed the Maintenance Mode feature, which now show's a Down For Maintenance page when this option is selected, however, instead of using the Store Settings to set the message, you can edit a page in the SiteTree which the user see's.
As well as all this I have tidied up some of the code to make it cleaner and easier to read/follow
TODO:

Fix basket as products are not showing for anyone except the admin (ie. not listing what products are in the basket)  - but the Basket Total are working correctly to go further into the checkout process
Payment is not going to PayPal when trying to complete the checkout, just skips that part and goes straight to an Order Summary
Product Options (with inventory count) & Downloadable Products
Allow Parent & Child Categories (So that we can eventually create a navigation (eg. Mens -> T-Shirts, etc)
Additional checkout gateways (Payment Express, Cash/Cheque, etc)

sanjansharmanz,
Thank you for your efforts with this module. It's very early days and it's great to see a contribution with all considered. Might I ask what spiked your interest in it? Are you planning to use it on a project?
Thanks,
George.

Hi George,
Firstly thank you for the merge and a great start to the module. Im actually fairly new to the SilverStripe scene only having discovered it towards the end of 2015 and absolutely fell in love with it. However, saying this the other E-Commerce solutions i felt were always missing something or were not elegant/user friendly, I myself decided I wanted to try make something similar to Magento as possible that was clean and easy to use (im self-taught and still only very limited knowledge on coding with SS so this was a longshot), and then i discovered this module via a SS blog. The foundation was a perfect start and it seem to be on its way to everything ive been looking for, hopefully we can have it completed at some stage with documentation as I would love to incorporate it into my projects for friends/clients, as well further build on it as i feel it has large potential :)


SAK-46837 - Make assignment submission export sort order consistent with other aspects of Sakai

When exporting submissions from an assignment, the grade spreadsheets use AssignmentSubmissionComparator, which has code duplication and minor inconsistencies from comparators used elsewhere in Sakai. Make it use UserSortNameComparator when appropriate.

Makes sense to me. @ern?


⚠ MineVN Website has degraded performance

In 864547d, MineVN Website (http://minevn.net) experienced degraded performance:

HTTP code: 200
Response time: 18173 ms

Resolved: MineVN Website performance has improved in ba00206.


[WIP] docs for v2

Mostly there. The REPL is slightly buggy (something to do with the observe implementation, I think), and some more copy probably needs updating. Not now though, I'm going to bed.
Will need to add a link to svelte-upgrade

Ignore the remark about the bug — was caused by this.get(key). Still need to add some more docs though

Doesn't look like I can comment on it because it's not near a diff, but the store section still has a reference to store: true.

Am assuming we caught this one, don't know how to highlight the pr ...

To tell Svelte that you're going to be using Store, you must pass the store: true compiler option. This will change in version 2, when the compiler will automatically generate store-aware components.

shouldn't these have destructuring syntax?
store.compute(
	'volume',
	['width', 'height', 'depth'],
	(width, height, depth) => width * height * depth
);

...

store.compute(
	'mass',
	['volume', 'density'],
	(volume, density) => volume * density
);

Hrm @tomcon's raises an interesting point. afaik, no, the store hasn't changed its computed properties syntax - but should it? (And would a destructuring-based syntax prevent stuff from getting minified and allow us to look at the function and deduce the dependencies at runtime in a sane way, without having to separately list them?)

If it was easy to extract the keys from a function argument then yeah, we could do that. Unfortunately I think it's a little tricky to do reliably. See e.g. the source code to fn-args, which doesn't even handle destructuring — it's as big as Store itself.
So I think that realistically we need to continue to pass in the dependencies manually, in which case there's probably no real advantage to destructuring.

reminder about my comment before last re.

Am assuming we caught this one, don't know how to highlight the pr ...

@tomcon yep, got that one — thanks

I'm taking a look at the REPL examples running the site locally, and I'm not seeing the issue on the SVG clock that is seen on https://sveltetechnology-xalledbeee.now.sh/repl?version=local&demo=svg-clock so ... I don't know. Maybe it was a bad deployment or the wrong version of Svelte being used for 'local'?
What I do see are a few examples that need to be updated for this.observe and this.get('foo'). I'm going to try to get all those working and commit back to this branch.

I could have sworn that the 7guis-circles example used to adjust the size of the circles immediately after closing the 'adjusting' interface - or perhaps live while moving the slider - but it looks like it's not changing until after placing another circle. This is happening on the deployed version of the REPL using v1 of Svelte. I'll poke into this a bit but I don't know how much this is worth delaying v2 over. If it takes too long, I'll just push up what I have now which seems to be about as functional as what's deployed currently.
The hacker news example also has some Problems (mostly relating to navigation, I think because of the REPL's iframe), but, again, it seems to have the same problems that the deployed one does.

yeah, the circles thing is old :( https://github.com/sveltejs/svelte.technology/issues/258

Okay, just pushed up me changes for the this.observe/this.get stuff then


feat(#135): remove custom POP instructions insert during parsing

Remove an ad-hoc solution for adding pop instructions before labels.
Closes: #135.

History:

feat(#135): rename OpeoNodes to XmirParser
feat(#135): remove HexString duplicate
feat(#135): remove strange POP instructions handling
feat(#135): remove the puzzle for POP instructions
feat(#135): fix compilation errors and linter suggestions

PR-Codex overview
Detailed summary
This PR focuses on updating the version of jeo-maven-plugin and jeo.version in the pom.xml file. It also updates the OpeoTree.java file by replacing the OpeoNodes class with XmirParser class. Additionally, it adds an import statement for HexString in the HasInstructions.java file and renames the test class OpeoNodesTest to XmirParserTest.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@rultor merge

@rultor merge

@volodya-lombrozo OK, I'll try to merge now. You can check the progress of the merge here

@rultor merge

@volodya-lombrozo Done! FYI, the full log is here (took me 3min)


Trailing zeroes in factorial

❗Write Code in Only One Language ( CPP , C , Java , Python )
Give File Name :  Trailing-Zero-In-Fact  ✅ In respective language folder
📑 DESCRIPTION
Trailing zeroes in factorial

For an integer N find the number of trailing zeroes in N!.
You may assume that each input would have exactly one solution, and you may not use the same element twice.
You can return the answer in any order.
Example 1:
Input:
N = 5
Output:
1
Explanation:
5! = 120 so the number of trailing zero is 1.

Example 2:
Input:
N = 4
Output:
0
Explanation:
4! = 24 so the number of trailing zero is 0.

Constraints:
-1 <= N <= 109

Your Task:
You don't need to read input or print anything. Your task is to complete the function
trailingZeroes() which take an integer N as an input parameter and returns the count of trailing zeroes in the N!.

Expected Time Complexity:  O(logN)
Expected Auxiliary Space:  O(1)

Assign me this issue

Kindly assign me this issue as I am a beginner in open source contributions and want to start from somewhere but have good knowledge of programming mainly in C++.

Please assign this task to me. I believe I can efficiently solve this data structure and algorithm problem with a time complexity of O(log5(n)).

fixee: #19

PR: #19


redis support

Hello,
Redis seems to me quite good to be efficient eventstore.
I'd like to implement it.
Can I get some concrete information what EventStore and Serialization API I have to implement for create axon-redis module?
Thanks

Regards,
Maksim

If you want a different way of storing your events, you should typically implement your own EventStorageEngine.
The EventStorageEngine is what Axon uses to do the actual appending of events and fetching from some form of data source.
So it would mean you'd have to introduce a RedisEventStorageEngine.
We however have our doubts with Redis being a good fit for long term storage of large numbers of events. Hence, we wouldn't have put this on the road map ourselves I'd assume.
You're of course free to give a pull request with a RedisEventStorageEngine.

Sorry, cannot finish that.
At the moment don't have free time fir it.
I think it's better close that issue unless no one needed except me

Regards,
Maksim


QUOTED_IDENTIFIERS_IGNORE_CASE option is false SLF4J: Failed to load class "org.slf4j.impl.StaticLoggerBinder". SLF4J: Defaulting to no-operation (NOP) logger implementation

Which version and edition of Flyway are you using?
7.9.2
If this is not the latest version, can you reproduce the issue with the latest one as well? (Many bugs are fixed in newer releases and upgrading will often resolve the issue)
Which client are you using? (Command-line, Java API, Maven plugin, Gradle plugin)
CLI
Which database are you using? (Type & version)
Snowflake
Which operating system are you using?
Linux Ubuntu and CentOS
What did you do? (Please include the content causing the issue, any relevant configuration settings, the SQL statement(s) that failed (if any), and the command you ran)
flyway -info
Any flyway command will throw this.
What did you expect to see?
Nothing, just the return of the flyway -info command
What did you see instead?
Flyway Community Edition 7.9.2 by Redgate
QUOTED_IDENTIFIERS_IGNORE_CASE option is false
SLF4J: Failed to load class "org.slf4j.impl.StaticLoggerBinder".
SLF4J: Defaulting to no-operation (NOP) logger implementation
SLF4J: See http://www.slf4j.org/codes.html#StaticLoggerBinder for further details.

This is due to some other dependencies that come bundled with the CLI, and shouldn't affect actual functionality
You can remove these messages regarding SLF4J by deleting the aad folder in lib, more specifically the slf4j-api-1.7.30 JAR inside the aad folder
This folder of dependencies is only required for Azure Active Directory authentication and can be safely removed if you do not need this

Thank you, we will give this a shot over the weekend.  Much appreciated.


Laravel 5.8 Support

Hey @florianv,
Can you please add support for Laravel 5.8? As i update my app to 5.8, i get the following error. I suppose it's because the tagged method signature has been changed.
Thanks for this great package.
`   Symfony\Component\Debug\Exception\FatalThrowableError  : Argument 1 passed to Exchanger\Service\Chain::__construct() must be of the type array, object given, called in /Users/carbon/www/crm/vendor/florianv/laravel-swap/src/SwapServiceProvider.php on line 130
at /Users/carbon/www/crm/vendor/florianv/exchanger/src/Service/Chain.php:38
34|      * Creates a new chain service.
35|      *
36|      * @param ExchangeRateService[] $services
37|      */

38|     public function __construct(array $services = [])
39|     {
40|         $this->services = $services;
41|     }
42|

Exception trace:
1   Exchanger\Service\Chain::__construct(Object(Illuminate\Container\RewindableGenerator))
/Users/carbon/www/crm/vendor/florianv/laravel-swap/src/SwapServiceProvider.php:130`

Hey @carbonvader, you will have to upgrade Swap to the latest version, which works correctly on Laravel 5.8 (just tested it).

@florianv I am getting this error after upgrading laravel-swap to 2.0:
No PSR-17 request factory found. Install a package from this list: https://packagist.org/providers/psr/http-factory-implementation
Anything else that's missing?


undefined is not an object

When running the JS tests for my app (radar/twist@cf161237e30ee96d618bf058435a7f7c4654a12b) (my-sass branch), they fail with this error:
     Failure/Error: click_button "Create Account"
     Capybara::Poltergeist::JavascriptError:
       One or more errors were raised in the Javascript code on the page. If you don't care about these errors, you can ignore them by setting js_errors: false in your Poltergeist configuration (see documentation for details).

       TypeError: undefined is not an object (evaluating 'this.views[this.currentView].handleRequestNonce')
       TypeError: undefined is not an object (evaluating 'this.views[this.currentView].handleRequestNonce')
           at https://assets.braintreegateway.com/dropin/1.3.12/braintree-dropin-internal.min.js:7 in handleNonceRequest
           at https://assets.braintreegateway.com/dropin/1.3.12/braintree-dropin-internal.min.js:5 in e
           at https://assets.braintreegateway.com/dropin/1.3.12/braintree-dropin-internal.min.js:3 in _handleRequest

I don't know why this is. I would expect the Braintree drop-in to Just Work(tm), but that is definitely not the case here.
I have tried following the advice in #19, but it is cryptic. You can see my attempt here.
Please advise what I need to do to prevent this error from happening.

@radar I'm cloning your repo now and will try to reproduce this—stay tuned!

@radar I was unable to get your app running in a VM. Could you try updating to https://js.braintreegateway.com/js/braintree-2.14.2.js (looks like it's this line) and seeing if that fixes things?

Hi @EvanHahn, I tried updating it to 2.14.2 but I get the same error there.
What problems did you run into with the application?

@radar I set up a Vagrant box and was unable to install the json gem when doing a bundle install. I had a colleague of mine with much more Rails experience take a look, but he was stumped too.
Do you happen to have step-by-step instructions for getting this set up on an Ubuntu VM? That would really help.

Please follow the instructions here: http://ryanbigg.com/2014/10/ubuntu-ruby-ruby-install-chruby-and-you/. That should give you a decent setup for Ruby and Rails.
If you tell me exactly what steps are failing then I can guide you from there. Give me as much info as possible.

@radar have you tried disabling Turbolinks in your rails app? It has been known to cause issues with some of our SDK functionality.

Please kindly point out where in the application's Gemfile I am using turbolinks. I do not see it anywhere.

It may not be in your Gemfile or Gemfile.lock as I believe Rails 4+ ships with turbolinks by default. (described in Rails' guide on Working with JavaScript in Rails)
Some known issues that cause trouble are documented in the turbolinks README and may apply to the phantomjs versions used by Capybara/Poltergeist.
Could you try Opting out of Turbolinks and see if it makes any difference?

I wrote a book about Rails. I know how it works. There is no Turbolinks within this application.
For proof: If I look for "turbolinks" in either Sublime Text 3 or iTerm by running "ack 'turbolinks'", neither of them return a result.
Can I please get someone to help with this who knows Rails?

Sorry, I've been told that was a bit harsh. I would like to apologise for that. It's upsetting to me to be told that this is a turbolinks problem because I can see very obviously it isn't, and it makes me feel like you haven't even bothered to clone down my application and run it.
Is there something that is preventing you from doing that? I would really appreciate some help with this and anything I can do to get the help of an experienced Braintree developer.
Would it make it easier if we could pair on this over something like Skype/Google Hangouts?

@radar We have successfully reproduced the error on our end and will dig further into the issues causing it. Upon first glance, the issue appears to be isolated to the testing suite.

Thank you @pblesi.

@radar, We have identified the issue. The issue is that you are attempting to click the "Create Account" submit button before Drop-in is fully loaded. This is an issue that a user could encounter as well if they click the submit button before Drop-in has loaded. It is for this reason that we recommend you disable the button by default and then enable it once Drop-in has loaded.
<%= account.submit class: "btn btn-primary", disabled: true %>

  braintree.setup(
    "<%= @client_token %>",
    'dropin', {
      container: 'dropin',
      paymentMethodNonceReceived: function (event, nonce) {
      },
      onReady: function () {
        console.log('Braintree is ready');
        $('#new_account input[type=submit]').removeProp('disabled');
      }
    }
  );

Let us know if you run into any more issues.

Excellent, thank you @pblesi :) I will try filling in the field for Braintree's form before hitting the "Create Account" button and I'll let you know how it goes.


cpu jump 99% after reload

I want to update the plugin, so upload the code to the server, overwrite the original .lua file, and then execute the "kong prepare" and "kong reload" commands. The old nginx process never ends, and it takes up 99% of the cpu.
the version is 2.1.0.

looks like https://github.com/Kong/kong/issues/6178

I found that if the -c parameter is not specified when executing the "kong prepare" and "kong reload "commands, the above situation will occur. There is no problem specifying the -c parameter, why? Isn't the default /etc/kong/kong.conf? Anyway, my problem is solved.

what OS are you using?
also, if you start it without -c but with --vv, can you paste the output? (and verify it also happens)

use --vv ,This is because of the permissions of the config file.  It's my carelessness， thank you very much.
Error:
/usr/local/share/lua/5.1/kong/conf_loader/init.lua:989: attempt to index local 'file_conf' (a nil value)
stack traceback:
	/usr/local/share/lua/5.1/kong/conf_loader/init.lua:989: in function 'fun'
	/usr/local/share/lua/5.1/pl/tablex.lua:504: in function 'pairmap'
	/usr/local/share/lua/5.1/kong/conf_loader/init.lua:1286: in function 'conf_loader'
	/usr/local/share/lua/5.1/kong/cmd/reload.lua:18: in function 'cmd_exec'
	/usr/local/share/lua/5.1/kong/cmd/init.lua:88: in function </usr/local/share/lua/5.1/kong/cmd/init.lua:88>
	[C]: in function 'xpcall'
	/usr/local/share/lua/5.1/kong/cmd/init.lua:88: in function </usr/local/share/lua/5.1/kong/cmd/init.lua:45>
	/usr/local/bin/kong:9: in function 'file_gen'
	init_worker_by_lua:51: in function <init_worker_by_lua:49>
	[C]: in function 'xpcall'
	init_worker_by_lua:58: in function <init_worker_by_lua:56>

@nullpointerxyz thank you for reporting back!


Dedicated or embedded capacity?

Under "Considerations and limitations":
"Dedicated Premium capacity is required when moving to production."
Is this correct, or is "Embedded capacity" meant?
Embedded capacity was the requirement under the old app-owns-data sing-in model with a master user. It would make sense here, too - or does using the new service-principal sign-in actually require the (much more expensive) "Dedicated Premium Capacity"?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: c135bb4c-618b-478d-bce7-ac8608e3caac
Version Independent ID: a297498b-afa2-575d-417c-0cb4696a90af
Content: Service principal with Power BI - Power BI
Content Source: powerbi-docs/developer/embed-service-principal.md
Service: powerbi
Sub-service: powerbi-developer
GitHub Login: @rkarlin
Microsoft Alias: rkarlin

Thanks for your comment, @dirk-seifert-obungi. This issue has been assigned to the doc author for review.

Good eye, @dirk-seifert-obungi!
I've addressed this by editing to now show as "Dedicated capacity" as it does in the Power BI service.
This change should go live by the end of the week.
Did you know: For minor things like typos, you can edit the doc! Click the little Edit pencil icon in the article, then click the little Edit pencil in GitHub, make your change, scroll to the bottom, and click Propose file change. And voila! It's sent directly to the writer.
Then all the writer has to do is sign off and it goes into the publishing queue.
Thanks again!

We will now proceed to close this thread. If there are further questions regarding this matter, please tag me in your reply. We will gladly continue the discussion, and we will reopen the issue.

@markingmyname Hi Mark,
Thanks fo so quickly taking care of this!!
Should it not actually be "embedded capacity"? - as described here:
https://docs.microsoft.com/en-us/power-bi/developer/azure-pbie-create-capacity


Theme variant style is ignored with multiple props

[x] The issue is present in the latest release.
[x] I have searched the issues of this repository and believe that this is not a duplicate.

Current Behavior 😯
When applying a variant with multiple props in styled(), the style is ignored. Removing the extra props (but keep the variant) results in the style being applied.
Expected Behavior 🤔
Expected is the variant style to apply with multiple props.
Steps to Reproduce 🕹
https://codesandbox.io/s/cocky-fast-r9fe1?file=/src/Demo.tsx
Steps:

Run above demo
Comment line 20 to have it apply the style.

You need to apply someOtherProp on the component too if you want those styles to be applied. See https://codesandbox.io/embed/angry-night-bmu89?codemirror=1

thanks for looking into this @mnajdova. But in your example I still don't see the div having the red border. Are you sure you posted it correctly?
Are you sure its not a bug? I dont understand how setting the variant props (they should just be forwarded right?) disable the variant style.

@kwek sorry for some reason the code was not saved. Take a look here - https://codesandbox.io/s/angry-night-bmu89?from-embed=&file=/src/Demo.tsx
On line 35 I am setting the someOtherProp on the component.
The definition of props in the theme's variants, indicates that if the props specified in the props object are applied then the defined styles would be added.

Are you sure its not a bug? I dont understand how setting the variant props (they should just be forwarded right?) disable the variant style.

No, they are not forwarded. Maybe you are confusing them with the defaultProps?


TypeScript type safety for toJS()

When using ImmutableJS with TypeScript, it would be nice to have better type safety for the return value of toJS().
toJS() is defined like this in interface Iterable:
/**
 * Deeply converts this Iterable to equivalent JS.
 *
 * `Iterable.Indexeds`, and `Iterable.Sets` become Arrays, while
 * `Iterable.Keyeds` become Objects.
 *
 * @alias toJSON
 */
toJS(): any;

I think it should be possible to redeclare toJS() with the appropriate, more specific type (using covariance) in Iterable.Indexeds, Iterable.Sets, and Iterable.Keyeds. E.g. in Indexed and Set, I think the declaration would be:
toJS(): T[];

And in Keyed, I think it would be:
toJS(): { [key: K]: V };

@mmorearty interesting suggestion although there are plenty of edge cases that might make this tricky (what key type results when you convert an Immutable JS map which has a complex key type?)
The following however:
toJS(): T[];

does not work because toJS is not defined as a generic method in your definition. If T is instead a reference to the type of the contained type, then this also will not be correct because toJS is a deep conversion.
Instead I would propose something like:
// Iterable.Indexeds, and Iterable.Sets
toJS(): {}[];

But at a minimum it's unsafe for toJS() to be declared of type any - it should be:
toJS(): {};

(which forces people to assert the resulting type)


chore: override the ETCD put and delete methods

Signed-off-by: Chao Zhang<EMAIL_ADDRESS>

POST doesn't work either.
How to replicate:

Use the MySQL configuration

Create a route:
curl -H 'X-API-KEY: edd1c9f034335f136f87ad84b625c8f1' -X PUT -d '{
   "methods": ["GET"],
   "uris": ["/get"],
   "upstream": {
   "nodes": {
      "httpbin.org:80": 1
    }
  }
}' http://localhost:9180/apisix/admin/routes

Test the route: curl localhost:9080/get

Result: {"error_msg":"404 Route Not Found"}
Also, getting all routes returns {"header":{"revision":"1689689596"},"message":"Key not found"}
Should I open new issues?


Groovy colors in preview

There are already tickets for .twig & Javascript, I guess for groovy files the problems lies in the same place. Creating ticket as a possible future enhancement anyway :)

Moved to https://github.com/Vektah/CodeGlance/issues/165