[Bug]: Tray stays on top of fullscreen apps

Checklist

[X] I have read the appropriate section in the contributing guidelines
[X] I believe this issue is a problem with polybar itself and not a misconfiguration on my part
[X] I have searched for other open and closed issues that may have already reported this problem
[X] I have checked the known issues page for this problem.
[X] I have followed the debugging guide to narrow down the problem to a minimal config.

Steps to reproduce
Run polybar with the below config
Minimal config
[bar/right]
enable-ipc = true
width = 100%
height = 30

modules-right = tray date

[module/tray]
type = internal/tray
format = <tray>

[module/date]
type = internal/date
interval = 1
time = %H:%M:%S
label = %time%

Polybar log
otice: Parsing config file: config_test.ini
- config_parser: Parsing config_test.ini
* Created legacy ipc fifo at '/tmp/polybar_mqueue.60857'
* Opening ipc socket at '/run/user/1000/polybar/ipc.60857.sock'
notice: Listening for IPC messages (PID: 60857)
* Loaded monitor eDP (1920x1080+0+0)
* Configured DPI = 96x96
* Bar geometry: 1920x30+0+0; Borders: 0,0,0,0
- bar: Attach X event sink
- bar: Attach signal receiver
- controller: Setup user-defined modules
notice: Loading module 'tray' of type 'internal/tray'
notice: Loading module 'date' of type 'internal/date'
notice: Loaded 2 modules
* Starting application
- controller: Main thread id = 1
* Starting module/tray
* Starting module/date
* Entering event loop (thread-id=1)
- bar: Create renderer
- renderer: Get TrueColor visual
- renderer: Allocate colormap
- renderer: Allocate output window
- module/date: Thread id = 2
- renderer: Allocate window pixmaps
- renderer: Allocate graphic contexts
- renderer: Allocate alignment blocks
- renderer: Allocate cairo components
- renderer: Load fonts
warn: No fonts specified, using fallback font "fixed"
notice: Loaded font "fixed" (name=Noto Sans, offset=0, file=/usr/share/fonts/noto/NotoSans-Regular.ttf)
* Bar window: 0x1c00001
- bar: Reconfigure window
- bar: Set window WM_NAME
- bar: Set window _NET_WM_WINDOW_TYPE
- bar: Set window _NET_WM_STATE
- bar: Set window _NET_WM_DESKTOP
- bar: Set window _NET_WM_PID
- bar: Map window
- bar: Draw empty bar
- bar: Setup tray manager
- tray: Find systray selection atom for the default screen
* Activating tray manager
- tray: Create tray window
* Tray window: 0x1c00006
- tray: Restacking tray window
- bar: Set window WM_NAME / WM_CLASS
- tray: Set window WM_PROTOCOLS
- tray: Set window _NET_WM_WINDOW_TYPE
- tray: Set window _NET_WM_STATE
- tray: Set window _NET_WM_PID
- tray: Set window _NET_SYSTEM_TRAY_VISUAL
- tray: Set window _NET_SYSTEM_TRAY_ORIENTATION
- tray: Set _NET_SYSTEM_TRAY_COLORS to ffffffff
- tray: Change selection owner to 0x1c00006
- tray: visibility_change (state=0, activated=1, mapped=0, hidden=0)
* module/tray: Rebuilding cache
* module/date: Rebuilding cache
- bar: Force update
* Redrawing bar window
- tray: Reconfigure window (mapped=0, clients=0)
- tray: visibility_change (state=1, activated=1, mapped=0, hidden=1)
- renderer: flush(3 geom=62x30+1858+0, falloff=0)
- tray: visibility_change (state=1, activated=1, mapped=0, hidden=0)
- tray: visibility_change (state=1, activated=1, mapped=0, hidden=0)
- bar: Received expose event
* Notifying pending tray clients
- tray: Received client_message
* Processing docking request from 'Bluetooth Active
<b>1 Active Connection</b>' (0x2001ca4)
- tray: xembed = true
- tray: version = 0x1, flags = 0x1, XEMBED_MAPPED = true
- tray: Update client window
- tray: Configure client size
- tray: Add client window to the save set
- tray: Reparent client
- tray: Send embbeded notification to client
- tray: Map client
- tray: Received client_message
* Processing docking request from 'xfce4-power-manager' (0x1401e31)
- tray: xembed = true
- tray: version = 0x1, flags = 0x1, XEMBED_MAPPED = true
- tray: Update client window
- tray: Configure client size
- tray: Add client window to the save set
- tray: Reparent client
- tray: Send embbeded notification to client
- tray: Map client
- tray: Received client_message
* Processing docking request from 'Wi-Fi network connection “Auto dd-wrt” active: dd-wrt (58%)
VPN connection active' (0x1001ccb)
- tray: xembed = true
- tray: version = 0x1, flags = 0x1, XEMBED_MAPPED = true
- tray: Update client window
- tray: Configure client size
- tray: Add client window to the save set
- tray: Reparent client
- tray: Send embbeded notification to client
- tray: Map client
- tray: Received client_message
* Processing docking request from 'flameshot' (0x2600072)
- tray: xembed = true
- tray: version = 0x0, flags = 0x1, XEMBED_MAPPED = true
- tray: Update client window
- tray: Configure client size
- tray: Add client window to the save set
- tray: Reparent client
- tray: Send embbeded notification to client
- tray: Map client
- tray: Received map_notify
- tray: Set client mapped
- tray: Reconfigure clients
- tray: Reconfigure window (mapped=0, clients=4)
- tray: Reconfigure window / map
- tray: New window values, width=30, x=1858
- tray: Received map_notify
- tray: Set client mapped
- tray: Reconfigure clients
- tray: Reconfigure window (mapped=0, clients=4)
- tray: Reconfigure window / map
- tray: New window values, width=53, x=1858
- tray: Received map_notify
- tray: Set client mapped
- tray: Reconfigure clients
- tray: Reconfigure window (mapped=0, clients=4)
- tray: Reconfigure window / map
- tray: New window values, width=76, x=1858
- tray: Received map_notify
- tray: Set client mapped
- tray: Reconfigure clients
- tray: Reconfigure window (mapped=0, clients=4)
- tray: Reconfigure window / map
- tray: New window values, width=99, x=1858
- tray: Received map_notify
- tray: Update container mapped flag
* Redraw tray container (id=0x1c00006)
- tray: Refreshing window
* Redraw tray container (id=0x1c00006)
- tray: Refreshing window
* Redraw tray container (id=0x1c00006)
- tray: Refreshing window
* Redraw tray container (id=0x1c00006)
- tray: Refreshing window
* Redraw tray container (id=0x1c00006)
- tray: Refreshing window
* Redraw tray container (id=0x1c00006)
- tray: Refreshing window
* module/tray: Rebuilding cache
- bar: Force update
* Redrawing bar window
- tray: Reconfigure window (mapped=1, clients=4)
- tray: New window values, width=99, x=1759
- renderer: flush(3 geom=161x30+1759+0, falloff=0)
* module/date: Rebuilding cache
* Redrawing bar window
- tray: Reconfigure window (mapped=1, clients=4)
- tray: New window values, width=99, x=1759
- renderer: flush(3 geom=161x30+1759+0, falloff=0)
* module/date: Rebuilding cache
* Redrawing bar window
- tray: Reconfigure window (mapped=1, clients=4)
- tray: New window values, width=99, x=1759
- renderer: flush(3 geom=161x30+1759+0, falloff=0)
* module/date: Rebuilding cache
* Redrawing bar window
- tray: Reconfigure window (mapped=1, clients=4)
- tray: New window values, width=99, x=1759
- renderer: flush(3 geom=161x30+1759+0, falloff=0)
* module/date: Rebuilding cache
* Redrawing bar window
- tray: Reconfigure window (mapped=1, clients=4)
- tray: New window values, width=99, x=1759
- renderer: flush(3 geom=161x30+1759+0, falloff=0)
* module/date: Rebuilding cache
* Redrawing bar window
- tray: Reconfigure window (mapped=1, clients=4)
- tray: New window values, width=99, x=1759
- renderer: flush(3 geom=161x30+1759+0, falloff=0)
* module/date: Rebuilding cache
* Redrawing bar window
- tray: Reconfigure window (mapped=1, clients=4)
- tray: New window values, width=99, x=1759
- renderer: flush(3 geom=161x30+1759+0, falloff=0)
* module/date: Rebuilding cache
* Redrawing bar window
- tray: Reconfigure window (mapped=1, clients=4)
- tray: New window values, width=99, x=1759
- renderer: flush(3 geom=161x30+1759+0, falloff=0)
* module/date: Rebuilding cache
* Redrawing bar window
- tray: Reconfigure window (mapped=1, clients=4)
- tray: New window values, width=99, x=1759
- renderer: flush(3 geom=161x30+1759+0, falloff=0)
* module/date: Rebuilding cache
* Redrawing bar window
- tray: Reconfigure window (mapped=1, clients=4)
- tray: New window values, width=99, x=1759
- renderer: flush(3 geom=161x30+1759+0, falloff=0)
* module/date: Rebuilding cache
* Redrawing bar window
- tray: Reconfigure window (mapped=1, clients=4)
- tray: New window values, width=99, x=1759
- renderer: flush(3 geom=161x30+1759+0, falloff=0)
* module/date: Rebuilding cache
* Redrawing bar window
- tray: Reconfigure window (mapped=1, clients=4)
- tray: New window values, width=99, x=1759
- renderer: flush(3 geom=161x30+1759+0, falloff=0)
* module/date: Rebuilding cache
* Redrawing bar window
- tray: Reconfigure window (mapped=1, clients=4)
- tray: New window values, width=99, x=1759
- renderer: flush(3 geom=161x30+1759+0, falloff=0)
* module/date: Rebuilding cache
* Redrawing bar window
- tray: Reconfigure window (mapped=1, clients=4)
- tray: New window values, width=99, x=1759
- renderer: flush(3 geom=161x30+1759+0, falloff=0)
* module/date: Rebuilding cache
* Redrawing bar window
- tray: Reconfigure window (mapped=1, clients=4)
- tray: New window values, width=99, x=1759
- renderer: flush(3 geom=161x30+1759+0, falloff=0)
* module/date: Rebuilding cache
* Redrawing bar window
- tray: Reconfigure window (mapped=1, clients=4)
- tray: New window values, width=99, x=1759
- renderer: flush(3 geom=161x30+1759+0, falloff=0)
* module/date: Rebuilding cache
* Redrawing bar window
- tray: Reconfigure window (mapped=1, clients=4)
- tray: New window values, width=99, x=1759
- renderer: flush(3 geom=161x30+1759+0, falloff=0)
* module/date: Rebuilding cache
* Redrawing bar window
- tray: Reconfigure window (mapped=1, clients=4)
- tray: New window values, width=99, x=1759
- renderer: flush(3 geom=161x30+1759+0, falloff=0)
* module/date: Rebuilding cache
* Redrawing bar window
- tray: Reconfigure window (mapped=1, clients=4)
- tray: New window values, width=99, x=1759
- renderer: flush(3 geom=161x30+1759+0, falloff=0)
* module/date: Rebuilding cache
* Redrawing bar window
- tray: Reconfigure window (mapped=1, clients=4)
- tray: New window values, width=99, x=1759
- renderer: flush(3 geom=161x30+1759+0, falloff=0)
* module/date: Rebuilding cache
* Redrawing bar window
- tray: Reconfigure window (mapped=1, clients=4)
- tray: New window values, width=99, x=1759
- renderer: flush(3 geom=161x30+1759+0, falloff=0)
* module/date: Rebuilding cache
* Redrawing bar window
- tray: Reconfigure window (mapped=1, clients=4)
- tray: New window values, width=99, x=1759
- renderer: flush(3 geom=161x30+1759+0, falloff=0)
* module/date: Rebuilding cache
* Redrawing bar window
- tray: Reconfigure window (mapped=1, clients=4)
- tray: New window values, width=99, x=1759
- renderer: flush(3 geom=161x30+1759+0, falloff=0)
* module/date: Rebuilding cache
* Redrawing bar window
- tray: Reconfigure window (mapped=1, clients=4)
- tray: New window values, width=99, x=1759
- renderer: flush(3 geom=161x30+1759+0, falloff=0)
- tray: visibility_change (state=0, activated=1, mapped=1, hidden=0)
- tray: Received unmap_notify
- tray: Update container mapped flag
* module/date: Rebuilding cache
* Redrawing bar window
- tray: Reconfigure window (mapped=0, clients=4)
- tray: New window values, width=99, x=1759
- tray: visibility_change (state=1, activated=1, mapped=0, hidden=1)
- renderer: flush(3 geom=161x30+1759+0, falloff=0)
- tray: Received map_notify
- tray: Update container mapped flag
* Redraw tray container (id=0x1c00006)
- tray: Refreshing window
* Redraw tray container (id=0x1c00006)
- tray: Refreshing window
* module/date: Rebuilding cache
* Redrawing bar window
- tray: Reconfigure window (mapped=1, clients=4)
- tray: New window values, width=99, x=1759
- renderer: flush(3 geom=161x30+1759+0, falloff=0)
* module/date: Rebuilding cache
* Redrawing bar window
- tray: Reconfigure window (mapped=1, clients=4)
- tray: New window values, width=99, x=1759
- renderer: flush(3 geom=161x30+1759+0, falloff=0)
* module/date: Rebuilding cache
* Redrawing bar window
- tray: Reconfigure window (mapped=1, clients=4)
- tray: New window values, width=99, x=1759
- renderer: flush(3 geom=161x30+1759+0, falloff=0)
* module/date: Rebuilding cache
* Redrawing bar window
- tray: Reconfigure window (mapped=1, clients=4)
- tray: New window values, width=99, x=1759
- renderer: flush(3 geom=161x30+1759+0, falloff=0)
* module/date: Rebuilding cache
* Redrawing bar window
- tray: Reconfigure window (mapped=1, clients=4)
- tray: New window values, width=99, x=1759
- renderer: flush(3 geom=161x30+1759+0, falloff=0)
* module/date: Rebuilding cache
* Redrawing bar window
- tray: Reconfigure window (mapped=1, clients=4)
- tray: New window values, width=99, x=1759
- renderer: flush(3 geom=161x30+1759+0, falloff=0)
* module/date: Rebuilding cache
* Redrawing bar window
- tray: Reconfigure window (mapped=1, clients=4)
- tray: New window values, width=99, x=1759
- renderer: flush(3 geom=161x30+1759+0, falloff=0)
* module/date: Rebuilding cache
* Redrawing bar window
- tray: Reconfigure window (mapped=1, clients=4)
- tray: New window values, width=99, x=1759
- renderer: flush(3 geom=161x30+1759+0, falloff=0)
- tray: visibility_change (state=1, activated=1, mapped=1, hidden=0)
* Redraw tray container (id=0x1c00006)
- tray: Refreshing window
- tray: visibility_change (state=1, activated=1, mapped=1, hidden=0)
* Redraw tray container (id=0x1c00006)
- tray: Refreshing window
- bar: Received expose event
* Redraw tray container (id=0x1c00006)
- tray: Refreshing window
* module/date: Rebuilding cache
* Redrawing bar window
- tray: Reconfigure window (mapped=1, clients=4)
- tray: New window values, width=99, x=1759
- renderer: flush(3 geom=161x30+1759+0, falloff=0)
* module/date: Rebuilding cache
* Redrawing bar window
- tray: Reconfigure window (mapped=1, clients=4)
- tray: New window values, width=99, x=1759
- renderer: flush(3 geom=161x30+1759+0, falloff=0)
* module/date: Rebuilding cache
* Redrawing bar window
- tray: Reconfigure window (mapped=1, clients=4)
- tray: New window values, width=99, x=1759
- renderer: flush(3 geom=161x30+1759+0, falloff=0)
* module/date: Rebuilding cache
* Redrawing bar window
- tray: Reconfigure window (mapped=1, clients=4)
- tray: New window values, width=99, x=1759
- renderer: flush(3 geom=161x30+1759+0, falloff=0)
* module/date: Rebuilding cache
* Redrawing bar window
- tray: Reconfigure window (mapped=1, clients=4)
- tray: New window values, width=99, x=1759
- renderer: flush(3 geom=161x30+1759+0, falloff=0)
* module/date: Rebuilding cache
* Redrawing bar window
- tray: Reconfigure window (mapped=1, clients=4)
- tray: New window values, width=99, x=1759
- renderer: flush(3 geom=161x30+1759+0, falloff=0)
* module/date: Rebuilding cache
* Redrawing bar window
- tray: Reconfigure window (mapped=1, clients=4)
- tray: New window values, width=99, x=1759
- renderer: flush(3 geom=161x30+1759+0, falloff=0)
* module/date: Rebuilding cache
* Redrawing bar window
- tray: Reconfigure window (mapped=1, clients=4)
- tray: New window values, width=99, x=1759
- renderer: flush(3 geom=161x30+1759+0, falloff=0)
* module/date: Rebuilding cache
* Redrawing bar window
- tray: Reconfigure window (mapped=1, clients=4)
- tray: New window values, width=99, x=1759
- renderer: flush(3 geom=161x30+1759+0, falloff=0)
notice: Received signal(2): Interrupt
* Eventloop finished
notice: Termination signal received, shutting down...
- controller: Detach signal receiver
- controller: Stop modules
* module/tray: Stopping
- module/tray: Release sleep lock
* Deconstruction of module/tray took 0 ms.
* module/date: Stopping
- module/date: Release sleep lock
* Deconstruction of module/date took 0 ms.
- module/tray: Deconstructing
- module/date: Deconstructing
* Deactivating tray manager
- tray: Unset selection owner
- tray: Unembed clients
- tray: Destroy window
- ipc: Removing named pipe at: /tmp/polybar_mqueue.60857
* Waiting for spawned processes to end
* Reached end of application...

Expected behavior
Tray should not be visible on a full-screen window.
Actual behavior
Tray stays visible on top of a full screen window. F.e.: Run mpv with a video in full screen mode.
Window Manager and Version
i3-gaps 4.20.1
Linux Distribution
Arch Linux
Polybar version
polybar 3.5.7-337-gb7e321bb

Features: +alsa +curl +i3 +mpd +network(libnl) +pulseaudio +xkeyboard

X extensions: +randr (+monitors) +composite +xkb +xrm +xcursor

Build type: Release
Compiler: /usr/bin/c++
Compiler flags: -march=x86-64 -mtune=generic -O2 -pipe -fno-plt -fexceptions         -Wp,-D_FORTIFY_SOURCE=2 -Wformat -Werror=format-security         -fstack-clash-protection -fcf-protection -Wp,-D_GLIBCXX_ASSERTIONS -O3 -DNDEBUG -Wall -Wextra -Wpedantic -Wsuggest-override
Linker flags: -Wl,-O1,--sort-common,--as-needed,-z,relro,-z,now -Wall -Wextra -Wpedantic -Wsuggest-override  -Wall -Wextra -Wpedantic -Wsuggest-override

Additional Context / Screenshots
No response

I think this is a duplicate of #425

I think this is a duplicate of #425

Not sure. This issue occurred after https://github.com/polybar/polybar/commit/b2c5d8e0e228031844f28ecd91fb841f11842fb2

The underlying issue is still the same as #425


Easy creation of WSLv1 variant of WSLv2 profiles (easy management of WSL versions)

Currently there are no such options in Ubuntu profile settings.
I have WSLv2 installed, but I'd also like to use WSLv1 sometimes because (I hope) it might consume less memory. I found this documentation https://docs.microsoft.com/en-us/windows/wsl/install on changing WSL version for a given distro. It would be nice if Terminal helped with cloning a distro and toggling WSL version and so on. It could be placed into Ubuntu profile settings, but it'd be a useful feature.
Main scenario: bash+ssh+some light python script debugging. For now I'm just running a bash (without even a ssh session) , and it consumes full 700Mb of RAM (in Vmmem process) which seems an overkill.

I'm gonna tap in @craigloewen-msft for thoughts on this one. It's not a bad idea, but it's a lot of tight coupling with WSL that I'm not sure we'd be able to adequately maintain. Maybe better suited as an extension idea. That would raise a LOT of potential scenarios - modifying fragments, but also adding custom UI to the settings UI for certain types of profiles.

Given that Terminal is very often used with WSLv1/v2 and is aspiring to drive the Terminal / Linux experience on Win, it might be good to have some strategy about this.
I'm not even sure if you must have two separate distros (two Ubuntus of the same versions differing only by wsl version) and if it's possible. The easiest would be if it just required padding an extra flag to wsl.exe

It might be good if tab tooltip or profile name specified which WSL version it's using

@vadimkantorov are you switching between distros often? Is this more of a need to take some of the WSL commands and settings and put them into some form of GUI?

I mostly use WSLv1 as it doesn't allocate a big VM RAM process upfront and sometimes I need WSLv2.
I now think the real problem of duplicating the distro as both WSLv1 and WSLv2 should be tackled both by WSL and Terminal together: discussed in https://github.com/microsoft/WSL/issues/8271. Questions to be decided: 1) instantiating a distro from a pristine version without figuring out the obscure paths; 2) can a Linux partition file be shared between WSLv1 and WSLv2? If not, how to manage the both partitions so that UX / command line arguments to wsl.exe in a convenient way
Right now WSL could display somewhere in UI (tab tooltip? tab color?) which version of WSL is the prfile/distro running.

So, I'm going to have to reject this feature request (and some of its sub-requests).  It's an I/O-heavy operation that's supposed to be done a small number of times. I know there's an ask to make it toggleable at launch time, or offer a quick way to copy-and-convert, but ...
... it doesn't look like the WSL team has plans to continue investing in WSLv1, and I don't think that they'll be spending time on improving the migration tools, and ...
... while we're good friends with the WSL team, we're trying to avoid putting WSL into Terminal. I feel like that's really what this boils down to: us coupling WSL and Terminal enough to give Terminal control over how and when WSL distributions are installed. I'm willing to take on that coupling as an extension, but doing it in-box just to support transforming a distro from v1 to v2 and back is just too niche of a use case to justify investing in.[1]

[1] Power users already have a way to do this, even if it is not ergonomic. Importing and exporting is well-documented and somebody could certainly write a UI around it. Non-power-users, on the other hand, likely have no need of this and would not benefit from a UI anyway. Even displaying the version somewhere[2] benefits only the folks who would have otherwise already known.
[2] That having been said, allowing generated profiles to control some display-related information (software version, origin, type, etc.) would be broadly useful outside of WSL, and I am not against it. We would need to make sure we surface it in a way users will actually care about.


Matrix Diagonal Sum solution.py

Pull Request Template
Description
Please include a summary of the problem and about the approach to solve the solution. Please also include relevant motivation and context.
List any dependencies that are required for this change.
Put check marks:
Have you made changes in README file ?

[x] Added problem & solution under correct topic.
[x] Specified Space & Time complexity.
[x] Specified difficulty level, tag & Note(if any).

How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Please also note any relevant details for your test configuration.

[x] Test A
[x] Test B

Make sure all below guidelines are followed else PR will get Reject:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[ ] I have commented my code so that it is easy to understand
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] Any dependent changes have been merged and published in downstream modules

Thanks for raising the pull request !!!
My comments

There are 7 files changed. Please check since you only have to push 1 new file.
Update README file with the Python solution link
Check naming convention of the file.


Help command cleaned for readability.

Updated the 'usage' property of commands to use them in the help command.
Instead of Hard-coding what the command does in the embed, I just simply used the collection of commands and used their data.
Rewrited some values like color or link to avoid repetition and ambiguity
.join('\n') is used for an easier visualisation of new lines in the embed.
Instead of using object liiterals property (object['prop']) which is a bad practice in my opinion. I destructured the prefix directly when dealing with nested object.
Deleted the next embed because we also don't want to repeat ourselves since the command didn't worked directly in dm with as many conditionals I have written. const { Bot_info: { prefix } } = require('../../config.json')

The code have been tested on another bot and should work fine. :)

Please submit a new and reworked pull request for clarity!


any plans to build for 5.2?

i tried to run it.
G:\unreal\UE_5.2\Engine\Build\BatchFiles\RunUAT.bat BuildPlugin
it builds socket.ioclient fine on its own but the unreal js errors with this i dont know how to procede from here
Unable to find plugin 'SocketIOClient' (referenced via command line -> NodeJs.uplugin). Install it and try again, or remove it from the required plugin list.
thanks in advance

I will try build blui later tonight.

I usually hit the latest production engine with most of my plugins within a month or so of release, if you need it sooner you'll need to check the compile errors yourself; as you've started doing already.

On Thu, 1 Jun 2023 at 17:38, Jan Kaniewski @.***> wrote:

I usually hit the latest production engine with most of my plugins within
a month or so of release, if you need it sooner you'll need to check the
compile errors yourself; as you've started doing already.
—
Reply to this email directly, view it on GitHub
https://github.com/getnamo/NodeJs-Unreal/issues/59#issuecomment-1572383805,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AB2BKF7RGJVUKXALSMD3WFDXJDAQHANCNFSM6AAAAAAYWXCYGA
.
You are receiving this because you authored the thread.Message ID:
@.***>

The only error is that one for linking the sockets client built files. I
was wanting to make a start with it on 5.2 but I can just use 5.1 make it
all up test it the port it
Thanks for the response

5.2 release made here: https://github.com/getnamo/NodeJs-Unreal/releases/tag/v1.4.0 it still has #41 issue sometimes. May require starting the script twice to resolve.

wow brilliant thanks. i will try it out in 5.2 and 5.3 somepoint soon. hopefully i find the project i used it in.


lexicon: 3.3.22 -> 3.3.26

Semi-automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/AnalogJ/lexicon/releases.
meta.description for lexicon is: "Manipulate DNS records on various DNS providers in a standardized way."
meta.homepage for lexicon is: "https://github.com/AnalogJ/lexicon"
meta.changelog for lexicon is: ""
Updates performed

Version update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact

Checks done (click to expand)

built on NixOS

The tests defined in passthru.tests, if any, passed

0 of 0 passed binary check by having a zero exit code.

0 of 0 passed binary check by having the new version present in output.

found 3.3.26 with grep in /nix/store/q2nrkykl8brmb0bg6saqmj4sz268amaw-lexicon-3.3.26

directory tree listing: https://gist.github.com/7a4b91287fdac7a7a6976fde8292d10a

du listing: https://gist.github.com/2165ef5312650400149f86cb860e8a71

Rebuild report (if merged into master) (click to expand)

8 total rebuild path(s)

2 package rebuild(s)

2 x86_64-linux rebuild(s)
2 i686-linux rebuild(s)
2 x86_64-darwin rebuild(s)
2 aarch64-linux rebuild(s)

First fifty rebuilds by attrpath
ape
lexicon

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/q2nrkykl8brmb0bg6saqmj4sz268amaw-lexicon-3.3.26 \
  --option binary-caches 'https://cache.nixos.org/ https://r-ryantm.cachix.org/' \
  --option trusted-public-keys '
  r-ryantm.cachix.org-1:gkUbLkouDAyvBdpBX0JOdIiD2/DP1ldF3Z3Y6Gqcc4c=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(r-ryantm's Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A lexicon https://github.com/r-ryantm/nixpkgs/archive/07e09428a651b6e6db97c2813b06a80bdd5232bb.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/q2nrkykl8brmb0bg6saqmj4sz268amaw-lexicon-3.3.26
ls -la /nix/store/q2nrkykl8brmb0bg6saqmj4sz268amaw-lexicon-3.3.26/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review 1

1 package failed to build:
- ape

1 package built:
- lexicon

Maintainer pings
cc @flyfloh for testing.

botocore is broken on master, should wait for staging-next to merge

Tested it and looks good.


CI: Move to Github Actions

This has already been asked for in #358 and #361.
I think it would be good - to keep it simple - to have several configuration files:

[ ] run HTML builder with many Python and Sphinx versions

this is currently done on Travis-CI (config: https://github.com/spatialaudio/nbsphinx/blob/d5d352c5440cc7a185751bdf0d1ba263b7a2026d/.travis.yml)
I don't think we need to do this on multiple operating systems? Ubuntu should suffice?

[ ] run HTML builder on Windows, using default versions

[ ] run HTML builder on macOS, using default versions (#559)

[ ] run HTML builder with default versions (whatever OS), upload HTML artifacts

Github still doesn't allow non-zipped artifacts, see #361.
I don't think we need multiple versions of the HTML artifacts, one OS (using default versions) should suffice

[ ] create PDF with TexLive, upload artifact

one OS should be sufficient?
if tectonic turns out to be much faster (while still producing a correct PDF), we can remove the TeXLive action

[ ] create PDF with tectonic, upload artifact

one OS should be sufficient?

[x] run linkcheck (only once), see #491

Any further suggestions?
cc @s-weigand

I got pretty much all of this running, besides building of PDF on windows (see this workflow, still WIP with an ugly commit history).
For tests on windows to pass I had to use python<3.8 (#496 ) and add the raises-exception tag to the bash-magic cell.
Latex and Windows
The problem with creating PDFs on Windows is due to the difference in the created nbsphinx.tex file.
textonic and pdflatex both fail with:
LaTeX Warning: Reference `a-normal-rst-file:example_python_function' on page 23
 undefined on input line 2056.

[23]
! FancyVerb Error:
  Empty verbatim environment
.
\FV@Error ...ncyVerb Error:^^J\space \space #1^^J}

l.2292 \end{sphinxVerbatim}

When looking at the diff of the linux and windows generated nbsphinx.tex
$ diff -Z --color latex-linux/nbsphinx.tex  latex-win/nbsphinx.tex

you find the following:
2292,2294c2292,2339
< 1
< 2
< 3
---
> \end{sphinxVerbatim}
> }
>
> {
>
> \kern-\sphinxverbatimsmallskipamount\kern-\baselineskip
> \kern+\FrameHeightAdjust\kern-\fboxrule
> \vspace{\nbsphinxcodecellspacing}
>
> \sphinxsetup{VerbatimColor={named}{white}}
> \sphinxsetup{VerbatimBorderColor={named}{nbsphinx-code-border}}
> \begin{sphinxVerbatim}[commandchars=\\\{\}]
> \textcolor{ansi-red-intense}{\textbf{---------------------------------------------------------------------------}}
> \textcolor{ansi-red-intense}{\textbf{CalledProcessError}}                        Traceback (most recent call last)
> \textcolor{ansi-green-intense}{\textbf{<ipython-input-1-7f4108180772>}} in \textcolor{ansi-cyan}{<module>}
> \textcolor{ansi-green-intense}{\textbf{----> 1}}\textcolor{ansi-yellow-intense}{\textbf{ }}get\_ipython\textcolor{ansi-yellow-intense}{\textbf{(}}\textcolor{ansi-yellow-intense}{\textbf{)}}\textcolor{ansi-yellow-intense}{\textbf{.}}run\_cell\_magic\textcolor{ansi-yellow-intense}{\textbf{(}}\textcolor{ansi-blue-intense}{\textbf{'bash'}}\textcolor{ansi-yellow-intense}{\textbf{,}} \textcolor{ansi-blue-intense}{\textbf{''}}\textcolor{ansi-yellow-intense}{\textbf{,}} \textcolor{ansi-blue-intense}{\textbf{'for i in 1 2 3\textbackslash{}ndo\textbackslash{}n    echo \$i\textbackslash{}ndone\textbackslash{}n'}}\textcolor{ansi-yellow-intense}{\textbf{)}}
>
> \textcolor{ansi-green-intense}{\textbf{C:\textbackslash{}hostedtoolcache\textbackslash{}windows\textbackslash{}Python\textbackslash{}3.7.9\textbackslash{}x64\textbackslash{}lib\textbackslash{}site-packages\textbackslash{}IPython\textbackslash{}core\textbackslash{}interactiveshell.py}} in \textcolor{ansi-cyan}{run\_cell\_magic}\textcolor{ansi-blue-intense}{\textbf{(self, magic\_name, line, cell)}}
> \textcolor{ansi-green}{   2379}             \textcolor{ansi-green-intense}{\textbf{with}} self\textcolor{ansi-yellow-intense}{\textbf{.}}builtin\_trap\textcolor{ansi-yellow-intense}{\textbf{:}}
> \textcolor{ansi-green}{   2380}                 args \textcolor{ansi-yellow-intense}{\textbf{=}} \textcolor{ansi-yellow-intense}{\textbf{(}}magic\_arg\_s\textcolor{ansi-yellow-intense}{\textbf{,}} cell\textcolor{ansi-yellow-intense}{\textbf{)}}
> \textcolor{ansi-green-intense}{\textbf{-> 2381}}\textcolor{ansi-yellow-intense}{\textbf{                 }}result \textcolor{ansi-yellow-intense}{\textbf{=}} fn\textcolor{ansi-yellow-intense}{\textbf{(}}\textcolor{ansi-yellow-intense}{\textbf{*}}args\textcolor{ansi-yellow-intense}{\textbf{,}} \textcolor{ansi-yellow-intense}{\textbf{**}}kwargs\textcolor{ansi-yellow-intense}{\textbf{)}}
> \textcolor{ansi-green}{   2382}             \textcolor{ansi-green-intense}{\textbf{return}} result
> \textcolor{ansi-green}{   2383}
>
> \textcolor{ansi-green-intense}{\textbf{C:\textbackslash{}hostedtoolcache\textbackslash{}windows\textbackslash{}Python\textbackslash{}3.7.9\textbackslash{}x64\textbackslash{}lib\textbackslash{}site-packages\textbackslash{}IPython\textbackslash{}core\textbackslash{}magics\textbackslash{}script.py}} in \textcolor{ansi-cyan}{named\_script\_magic}\textcolor{ansi-blue-intense}{\textbf{(line, cell)}}
> \textcolor{ansi-green}{    140}             \textcolor{ansi-green-intense}{\textbf{else}}\textcolor{ansi-yellow-intense}{\textbf{:}}
> \textcolor{ansi-green}{    141}                 line \textcolor{ansi-yellow-intense}{\textbf{=}} script
> \textcolor{ansi-green-intense}{\textbf{--> 142}}\textcolor{ansi-yellow-intense}{\textbf{             }}\textcolor{ansi-green-intense}{\textbf{return}} self\textcolor{ansi-yellow-intense}{\textbf{.}}shebang\textcolor{ansi-yellow-intense}{\textbf{(}}line\textcolor{ansi-yellow-intense}{\textbf{,}} cell\textcolor{ansi-yellow-intense}{\textbf{)}}
> \textcolor{ansi-green}{    143}
> \textcolor{ansi-green}{    144}         \textcolor{ansi-red-intense}{\textbf{\# write a basic docstring:}}
>
> \textcolor{ansi-green-intense}{\textbf{<decorator-gen-104>}} in \textcolor{ansi-cyan}{shebang}\textcolor{ansi-blue-intense}{\textbf{(self, line, cell)}}
>
> \textcolor{ansi-green-intense}{\textbf{C:\textbackslash{}hostedtoolcache\textbackslash{}windows\textbackslash{}Python\textbackslash{}3.7.9\textbackslash{}x64\textbackslash{}lib\textbackslash{}site-packages\textbackslash{}IPython\textbackslash{}core\textbackslash{}magic.py}} in \textcolor{ansi-cyan}{<lambda>}\textcolor{ansi-blue-intense}{\textbf{(f, *a, **k)}}
> \textcolor{ansi-green}{    185}     \textcolor{ansi-red-intense}{\textbf{\# but it's overkill for just that one bit of state.}}
> \textcolor{ansi-green}{    186}     \textcolor{ansi-green-intense}{\textbf{def}} magic\_deco\textcolor{ansi-yellow-intense}{\textbf{(}}arg\textcolor{ansi-yellow-intense}{\textbf{)}}\textcolor{ansi-yellow-intense}{\textbf{:}}
> \textcolor{ansi-green-intense}{\textbf{--> 187}}\textcolor{ansi-yellow-intense}{\textbf{         }}call \textcolor{ansi-yellow-intense}{\textbf{=}} \textcolor{ansi-green-intense}{\textbf{lambda}} f\textcolor{ansi-yellow-intense}{\textbf{,}} \textcolor{ansi-yellow-intense}{\textbf{*}}a\textcolor{ansi-yellow-intense}{\textbf{,}} \textcolor{ansi-yellow-intense}{\textbf{**}}k\textcolor{ansi-yellow-intense}{\textbf{:}} f\textcolor{ansi-yellow-intense}{\textbf{(}}\textcolor{ansi-yellow-intense}{\textbf{*}}a\textcolor{ansi-yellow-intense}{\textbf{,}} \textcolor{ansi-yellow-intense}{\textbf{**}}k\textcolor{ansi-yellow-intense}{\textbf{)}}
> \textcolor{ansi-green}{    188}
> \textcolor{ansi-green}{    189}         \textcolor{ansi-green-intense}{\textbf{if}} callable\textcolor{ansi-yellow-intense}{\textbf{(}}arg\textcolor{ansi-yellow-intense}{\textbf{)}}\textcolor{ansi-yellow-intense}{\textbf{:}}
>
> \textcolor{ansi-green-intense}{\textbf{C:\textbackslash{}hostedtoolcache\textbackslash{}windows\textbackslash{}Python\textbackslash{}3.7.9\textbackslash{}x64\textbackslash{}lib\textbackslash{}site-packages\textbackslash{}IPython\textbackslash{}core\textbackslash{}magics\textbackslash{}script.py}} in \textcolor{ansi-cyan}{shebang}\textcolor{ansi-blue-intense}{\textbf{(self, line, cell)}}
> \textcolor{ansi-green}{    243}             sys\textcolor{ansi-yellow-intense}{\textbf{.}}stderr\textcolor{ansi-yellow-intense}{\textbf{.}}flush\textcolor{ansi-yellow-intense}{\textbf{(}}\textcolor{ansi-yellow-intense}{\textbf{)}}
> \textcolor{ansi-green}{    244}         \textcolor{ansi-green-intense}{\textbf{if}} args\textcolor{ansi-yellow-intense}{\textbf{.}}raise\_error \textcolor{ansi-green-intense}{\textbf{and}} p\textcolor{ansi-yellow-intense}{\textbf{.}}returncode\textcolor{ansi-yellow-intense}{\textbf{!=}}\textcolor{ansi-cyan-intense}{\textbf{0}}\textcolor{ansi-yellow-intense}{\textbf{:}}
> \textcolor{ansi-green-intense}{\textbf{--> 245}}\textcolor{ansi-yellow-intense}{\textbf{             }}\textcolor{ansi-green-intense}{\textbf{raise}} CalledProcessError\textcolor{ansi-yellow-intense}{\textbf{(}}p\textcolor{ansi-yellow-intense}{\textbf{.}}returncode\textcolor{ansi-yellow-intense}{\textbf{,}} cell\textcolor{ansi-yellow-intense}{\textbf{,}} output\textcolor{ansi-yellow-intense}{\textbf{=}}out\textcolor{ansi-yellow-intense}{\textbf{,}} stderr\textcolor{ansi-yellow-intense}{\textbf{=}}err\textcolor{ansi-yellow-intense}{\textbf{)}}
> \textcolor{ansi-green}{    246}
> \textcolor{ansi-green}{    247}     \textcolor{ansi-green-intense}{\textbf{def}} \_run\_script\textcolor{ansi-yellow-intense}{\textbf{(}}self\textcolor{ansi-yellow-intense}{\textbf{,}} p\textcolor{ansi-yellow-intense}{\textbf{,}} cell\textcolor{ansi-yellow-intense}{\textbf{,}} to\_close\textcolor{ansi-yellow-intense}{\textbf{)}}\textcolor{ansi-yellow-intense}{\textbf{:}}
>
> \textcolor{ansi-red-intense}{\textbf{CalledProcessError}}: Command 'b'for i in 1 2 3\textbackslash{}ndo\textbackslash{}n    echo \$i\textbackslash{}ndone\textbackslash{}n'' returned non-zero exit status<PHONE_NUMBER>.
2588,2589c2633,2634
< /opt/hostedtoolcache/Python/3.8.5/x64/lib/python3.8/site-packages/traitlets/traitlets.py:2939: FutureWarning: --rc=\{'figure.dpi': 96\} for dict-traits is deprecated in traitlets 5.0. You can pass --rc <key=value> {\ldots} multiple times to add items to a dict.
<   warn(
---
> C:\textbackslash{}hostedtoolcache\textbackslash{}windows\textbackslash{}Python\textbackslash{}3.7.9\textbackslash{}x64\textbackslash{}lib\textbackslash{}site-packages\textbackslash{}traitlets\textbackslash{}traitlets.py:2945: FutureWarning: --rc=\{'figure.dpi': 96\} for dict-traits is deprecated in traitlets 5.0. You can pass --rc <key=value> {\ldots} multiple times to add items to a dict.
>   FutureWarning,
2611c2656
< \llap{\color{nbsphinxout}[18]:\,\hspace{\fboxrule}\hspace{\fboxsep}}[<matplotlib.lines.Line2D at 0x7f7fb2c631c0>]
---
> \llap{\color{nbsphinxout}[18]:\,\hspace{\fboxrule}\hspace{\fboxsep}}[<matplotlib.lines.Line2D at 0x15b196f4648>]
2722,2726c2767,2771
< 0  23  38  91  66
< 1  13  28  17   1
< 2  45  25  20  83
< 3  55  41  75  98
< 4  87  72  25   7
---
> 0  64  64  71  58
> 1  72  63  10  56
> 2  10  88  40  51
> 3   9  83  58   8
> 4  25  63  41   0
2810,2819c2855,2864
< 0 &         9 &       95 &        88 &        80 \\
< 1 &        99 &       59 &        29 &        29 \\
< 2 &        10 &       71 &        76 &        46 \\
< 3 &        88 &       20 &        56 &        70 \\
< 4 &        46 &       61 &        62 &        43 \\
< 5 &        97 &       93 &        79 &         7 \\
< 6 &         9 &       53 &        24 &        78 \\
< 7 &        10 &       35 &        56 &         4 \\
< 8 &         8 &       49 &         4 &        67 \\
< 9 &        89 &       47 &        70 &        99 \\
---
> 0 &        93 &       32 &        41 &         1 \\
> 1 &        62 &       15 &        66 &        23 \\
> 2 &        90 &       74 &        23 &        66 \\
> 3 &        84 &        7 &        78 &        29 \\
> 4 &         4 &       47 &        53 &        48 \\
> 5 &        70 &       10 &        12 &        49 \\
> 6 &        97 &       64 &         2 &        96 \\
> 7 &        96 &       86 &        42 &        13 \\
> 8 &        94 &       35 &        99 &        40 \\
> 9 &        68 &       93 &        66 &        73 \\
3605,3608c3650,3653
< \textcolor{ansi-red}{---------------------------------------------------------------------------}
< \textcolor{ansi-red}{NameError}                                 Traceback (most recent call last)
< \textcolor{ansi-green}{<ipython-input-1-7dd4c0df649c>} in \textcolor{ansi-cyan}{<module>}
< \textcolor{ansi-green}{----> 1}\textcolor{ansi-red}{ }nonsense
---
> \textcolor{ansi-red-intense}{\textbf{---------------------------------------------------------------------------}}
> \textcolor{ansi-red-intense}{\textbf{NameError}}                                 Traceback (most recent call last)
> \textcolor{ansi-green-intense}{\textbf{<ipython-input-1-7dd4c0df649c>}} in \textcolor{ansi-cyan}{<module>}
> \textcolor{ansi-green-intense}{\textbf{----> 1}}\textcolor{ansi-yellow-intense}{\textbf{ }}nonsense
3610c3655
< \textcolor{ansi-red}{NameError}: name 'nonsense' is not defined
---
> \textcolor{ansi-red-intense}{\textbf{NameError}}: name 'nonsense' is not defined
3631,3634c3676,3679
< \textcolor{ansi-red}{---------------------------------------------------------------------------}
< \textcolor{ansi-red}{ZeroDivisionError}                         Traceback (most recent call last)
< \textcolor{ansi-green}{<ipython-input-1-52cebea8b64f>} in \textcolor{ansi-cyan}{<module>}
< \textcolor{ansi-green}{----> 1}\textcolor{ansi-red}{ }\textcolor{ansi-cyan}{42} \textcolor{ansi-blue}{/} \textcolor{ansi-cyan}{0}
---
> \textcolor{ansi-red-intense}{\textbf{---------------------------------------------------------------------------}}
> \textcolor{ansi-red-intense}{\textbf{ZeroDivisionError}}                         Traceback (most recent call last)
> \textcolor{ansi-green-intense}{\textbf{<ipython-input-1-52cebea8b64f>}} in \textcolor{ansi-cyan}{<module>}
> \textcolor{ansi-green-intense}{\textbf{----> 1}}\textcolor{ansi-yellow-intense}{\textbf{ }}\textcolor{ansi-cyan-intense}{\textbf{42}} \textcolor{ansi-yellow-intense}{\textbf{/}} \textcolor{ansi-cyan-intense}{\textbf{0}}
3636c3681
< \textcolor{ansi-red}{ZeroDivisionError}: division by zero
---
> \textcolor{ansi-red-intense}{\textbf{ZeroDivisionError}}: division by zero
3657,3660c3702,3705
< \textcolor{ansi-cyan}{  File }\textcolor{ansi-green}{"<ipython-input-1-653b30cd70a8>"}\textcolor{ansi-cyan}{, line }\textcolor{ansi-green}{1}
< \textcolor{ansi-red}{    print 'Hello, world!'}
<           \^{}
< \textcolor{ansi-red}{SyntaxError}\textcolor{ansi-red}{:} Missing parentheses in call to 'print'. Did you mean print('Hello, world!')?
---
> \textcolor{ansi-cyan-intense}{\textbf{  File }}\textcolor{ansi-green-intense}{\textbf{"<ipython-input-1-653b30cd70a8>"}}\textcolor{ansi-cyan-intense}{\textbf{, line }}\textcolor{ansi-green-intense}{\textbf{1}}
> \textcolor{ansi-yellow-intense}{\textbf{    print 'Hello, world!'}}
> \textcolor{ansi-white-intense}{\textbf{                        \^{}}}
> \textcolor{ansi-red-intense}{\textbf{SyntaxError}}\textcolor{ansi-red-intense}{\textbf{:}} Missing parentheses in call to 'print'. Did you mean print('Hello, world!')?
3682,3685c3727,3730
< \textcolor{ansi-cyan}{  File }\textcolor{ansi-green}{"<ipython-input-1-8300b2622db3>"}\textcolor{ansi-cyan}{, line }\textcolor{ansi-green}{1}
< \textcolor{ansi-red}{    6 \textasciitilde{} 7}
<       \^{}
< \textcolor{ansi-red}{SyntaxError}\textcolor{ansi-red}{:} invalid syntax
---
> \textcolor{ansi-cyan-intense}{\textbf{  File }}\textcolor{ansi-green-intense}{\textbf{"<ipython-input-1-8300b2622db3>"}}\textcolor{ansi-cyan-intense}{\textbf{, line }}\textcolor{ansi-green-intense}{\textbf{1}}
> \textcolor{ansi-yellow-intense}{\textbf{    6 \textasciitilde{} 7}}
> \textcolor{ansi-white-intense}{\textbf{      \^{}}}
> \textcolor{ansi-red-intense}{\textbf{SyntaxError}}\textcolor{ansi-red-intense}{\textbf{:}} invalid syntax
3766,3769c3811,3814
< \textcolor{ansi-red}{---------------------------------------------------------------------------}
< \textcolor{ansi-red}{NameError}                                 Traceback (most recent call last)
< \textcolor{ansi-green}{<ipython-input-1-526ab3a89ffc>} in \textcolor{ansi-cyan}{<module>}
< \textcolor{ansi-green}{----> 1}\textcolor{ansi-red}{ }problem
---
> \textcolor{ansi-red-intense}{\textbf{---------------------------------------------------------------------------}}
> \textcolor{ansi-red-intense}{\textbf{NameError}}                                 Traceback (most recent call last)
> \textcolor{ansi-green-intense}{\textbf{<ipython-input-1-526ab3a89ffc>}} in \textcolor{ansi-cyan}{<module>}
> \textcolor{ansi-green-intense}{\textbf{----> 1}}\textcolor{ansi-yellow-intense}{\textbf{ }}problem
3771c3816
< \textcolor{ansi-red}{NameError}: name 'problem' is not defined
---
> \textcolor{ansi-red-intense}{\textbf{NameError}}: name 'problem' is not defined
4225c4270
< \sphinxcode{\sphinxupquote{\strut doc/subdir/a-notebook-in-a-subdir.ipynb}} \dotfill}}
---
> \sphinxcode{\sphinxupquote{\strut doc/subdir\textbackslash{}a-notebook-in-a-subdir.ipynb}} \dotfill}}
4283c4328
< doc/subdir/a-notebook-in-a-subdir.ipynb}} ends here.}}
---
> doc/subdir\textbackslash{}a-notebook-in-a-subdir.ipynb}} ends here.}}
4289c4334
< \sphinxcode{\sphinxupquote{\strut doc/subdir/gallery.ipynb}} \dotfill}}
---
> \sphinxcode{\sphinxupquote{\strut doc/subdir\textbackslash{}gallery.ipynb}} \dotfill}}
4344c4389
< \sphinxcode{\sphinxupquote{\strut doc/gallery/cell-tag.ipynb}} \dotfill}}
---
> \sphinxcode{\sphinxupquote{\strut doc/gallery\textbackslash{}cell-tag.ipynb}} \dotfill}}
4370,4371c4415,4416
< /opt/hostedtoolcache/Python/3.8.5/x64/lib/python3.8/site-packages/traitlets/traitlets.py:2939: FutureWarning: --rc=\{'figure.dpi': 96\} for dict-traits is deprecated in traitlets 5.0. You can pass --rc <key=value> {\ldots} multiple times to add items to a dict.
<   warn(
---
> C:\textbackslash{}hostedtoolcache\textbackslash{}windows\textbackslash{}Python\textbackslash{}3.7.9\textbackslash{}x64\textbackslash{}lib\textbackslash{}site-packages\textbackslash{}traitlets\textbackslash{}traitlets.py:2945: FutureWarning: --rc=\{'figure.dpi': 96\} for dict-traits is deprecated in traitlets 5.0. You can pass --rc <key=value> {\ldots} multiple times to add items to a dict.
>   FutureWarning,
4395c4440
< \llap{\color{nbsphinxout}[2]:\,\hspace{\fboxrule}\hspace{\fboxsep}}[<matplotlib.lines.Line2D at 0x7fd27c7b3940>]
---
> \llap{\color{nbsphinxout}[2]:\,\hspace{\fboxrule}\hspace{\fboxsep}}[<matplotlib.lines.Line2D at 0x177441b7a08>]
4412c4457
< doc/gallery/cell-tag.ipynb}} ends here.}}
---
> doc/gallery\textbackslash{}cell-tag.ipynb}} ends here.}}
4418c4463
< \sphinxcode{\sphinxupquote{\strut doc/gallery/cell-metadata.ipynb}} \dotfill}}
---
> \sphinxcode{\sphinxupquote{\strut doc/gallery\textbackslash{}cell-metadata.ipynb}} \dotfill}}
4455,4456c4500,4501
< /opt/hostedtoolcache/Python/3.8.5/x64/lib/python3.8/site-packages/traitlets/traitlets.py:2939: FutureWarning: --rc=\{'figure.dpi': 96\} for dict-traits is deprecated in traitlets 5.0. You can pass --rc <key=value> {\ldots} multiple times to add items to a dict.
<   warn(
---
> C:\textbackslash{}hostedtoolcache\textbackslash{}windows\textbackslash{}Python\textbackslash{}3.7.9\textbackslash{}x64\textbackslash{}lib\textbackslash{}site-packages\textbackslash{}traitlets\textbackslash{}traitlets.py:2945: FutureWarning: --rc=\{'figure.dpi': 96\} for dict-traits is deprecated in traitlets 5.0. You can pass --rc <key=value> {\ldots} multiple times to add items to a dict.
>   FutureWarning,
4506c4551
< \llap{\color{nbsphinxout}[5]:\,\hspace{\fboxrule}\hspace{\fboxsep}}<matplotlib.image.AxesImage at 0x7f6cf86517f0>
---
> \llap{\color{nbsphinxout}[5]:\,\hspace{\fboxrule}\hspace{\fboxsep}}<matplotlib.image.AxesImage at 0x247c3a7ffc8>
4523c4568
< doc/gallery/cell-metadata.ipynb}} ends here.}}
---
> doc/gallery\textbackslash{}cell-metadata.ipynb}} ends here.}}
4529c4574
< \sphinxcode{\sphinxupquote{\strut doc/gallery/multiple-outputs.ipynb}} \dotfill}}
---
> \sphinxcode{\sphinxupquote{\strut doc/gallery\textbackslash{}multiple-outputs.ipynb}} \dotfill}}
4611c4656
< doc/gallery/multiple-outputs.ipynb}} ends here.}}
---
> doc/gallery\textbackslash{}multiple-outputs.ipynb}} ends here.}}
4617c4662
< \sphinxcode{\sphinxupquote{\strut doc/gallery/no-thumbnail.ipynb}} \dotfill}}
---
> \sphinxcode{\sphinxupquote{\strut doc/gallery\textbackslash{}no-thumbnail.ipynb}} \dotfill}}
4628c4673
< doc/gallery/no-thumbnail.ipynb}} ends here.}}
---
> doc/gallery\textbackslash{}no-thumbnail.ipynb}} ends here.}}
4634c4679
< \sphinxcode{\sphinxupquote{\strut doc/gallery/thumbnail-from-conf-py.ipynb}} \dotfill}}
---
> \sphinxcode{\sphinxupquote{\strut doc/gallery\textbackslash{}thumbnail-from-conf-py.ipynb}} \dotfill}}
4678,4679c4723,4724
< /opt/hostedtoolcache/Python/3.8.5/x64/lib/python3.8/site-packages/traitlets/traitlets.py:2939: FutureWarning: --rc=\{'figure.dpi': 96\} for dict-traits is deprecated in traitlets 5.0. You can pass --rc <key=value> {\ldots} multiple times to add items to a dict.
<   warn(
---
> C:\textbackslash{}hostedtoolcache\textbackslash{}windows\textbackslash{}Python\textbackslash{}3.7.9\textbackslash{}x64\textbackslash{}lib\textbackslash{}site-packages\textbackslash{}traitlets\textbackslash{}traitlets.py:2945: FutureWarning: --rc=\{'figure.dpi': 96\} for dict-traits is deprecated in traitlets 5.0. You can pass --rc <key=value> {\ldots} multiple times to add items to a dict.
>   FutureWarning,
4717c4762
< doc/gallery/thumbnail-from-conf-py.ipynb}} ends here.}}
---
> doc/gallery\textbackslash{}thumbnail-from-conf-py.ipynb}} ends here.}}
4721c4766
< doc/subdir/gallery.ipynb}} ends here.}}
---
> doc/subdir\textbackslash{}gallery.ipynb}} ends here.}}
4727c4772
< \sphinxcode{\sphinxupquote{\strut doc/subdir/toctree.ipynb}} \dotfill}}
---
> \sphinxcode{\sphinxupquote{\strut doc/subdir\textbackslash{}toctree.ipynb}} \dotfill}}
4823c4868
< doc/subdir/toctree.ipynb}} ends here.}}
---
> doc/subdir\textbackslash{}toctree.ipynb}} ends here.}}
5224c5269
< \sphinxcode{\sphinxupquote{\strut doc/gallery/uno-rst.ipynb}} \dotfill}}
---
> \sphinxcode{\sphinxupquote{\strut doc/gallery\textbackslash{}uno-rst.ipynb}} \dotfill}}
5235c5280
< doc/gallery/uno-rst.ipynb}} ends here.}}
---
> doc/gallery\textbackslash{}uno-rst.ipynb}} ends here.}}
5241c5286
< \sphinxcode{\sphinxupquote{\strut doc/gallery/due-rst.pct.py}} \dotfill}}
---
> \sphinxcode{\sphinxupquote{\strut doc/gallery\textbackslash{}due-rst.pct.py}} \dotfill}}
5310c5355
< doc/gallery/due-rst.pct.py}} ends here.}}
---
> doc/gallery\textbackslash{}due-rst.pct.py}} ends here.}}

The fist diff is due to, allowing the bash magic cell to fail.
Some other diffs are also trivial (random numbers in the table or different memory addresses).
Noteworthy is the mixing of / and \ in paths, i.e.:
< doc/gallery/due-rst.pct.py}} ends here.}}
---
> doc/gallery\textbackslash{}due-rst.pct.py}} ends here.}}

I guess this could be saniticed within nbsphinx.
But I couldn't find that bug yet, which causes latex to fail the build.
Maybe you have a keener eye for this (donwload i.e. this artifact)
tectonic vs TexLive
While tectonic is much quicker to build PDF (about 5sec, when all downloaded packages are cached) vs. texlive image based action (about 3min), I found that it also causes some formatting/encoding error.
I.e. see page 4 the If you are using the conda package manager (e.g.˘awith
nbsphinx.pdf
Also tectonic comes with its own bibtex implementation, as far as I know.
So IMHO tectonic would be suiteable to check if the latex code is valid, but to check if it looks properly TexLive will be needed.
Some other points to look out for

The old build folder needs to be removed before starting a new build or it starts nesting in itself.
Since actions/upload-artifact only supports files with valid windows names, so python:nbsphinx.pdf needs to be removed for latext builds before uploaded, when sphinx<2.4 is used

Conclusion

As #496 shows, multiple versions of python should be tested on windows
TexLive while slower than textonic provides the correct PDF
Only test PDF creation on Linux (at least not windows) for now, since this is mostly done only on RTD anyway?
Run linkcheck as separate job with github actions since it has 20 parallel jobs

Just found the Error in the Windows version of nbsphinx.tex, it was caused by an extra empy sphinxVerbatim envionment.
{

\kern-\sphinxverbatimsmallskipamount\kern-\baselineskip
\kern+\FrameHeightAdjust\kern-\fboxrule
\vspace{\nbsphinxcodecellspacing}

\sphinxsetup{VerbatimColor={named}{white}}
\sphinxsetup{VerbatimBorderColor={named}{nbsphinx-code-border}}
\begin{sphinxVerbatim}[commandchars=\\\{\}]
\end{sphinxVerbatim}
}

This was caused by allowing the bash magic cell to fail with raises-exception.

After some more investigation i found the problem with the malformed tectonic output.
At some point when generating nbsphinx.tex a utf-8 none breaking space (b"\xc2\xa0") gets inserted after e.g. and i.e..
Since tectonic skips inputenc, but leaved the utf8 as is, this won't be converted to b"~". But since the font (pplr9d which is adobe palatino) doesn't support it, the PDF end up with ˘a.
One possible solution would be to replace b"\xc2\xa0" with b"~" after the *.tex file got created, but than we still get warning about other missing characters (…, ’, ”, ”, —, ł, ō). The characters ł and ō aren't displyed correctly as well.
The other solution would be to differentiate between different tex engines in the preamble and change the font for xelatex, which tectonic is dirived from. But since I'm a pdflatex user, I have no idea how to do this xelatex with fontspec, all my experiments did fail so far at least.
Another interesting point is that the tectonic generated PDF at some places looks more like the wanted result, than the pdflatex generated one.
I.e. section <IP_ADDRESS>, the link with adding copy to clipboard buttons, has the ” while the pdflatex version doesn't has it.
nbsphinx-pdflatex.pdf
nbsphinx-tectonic.pdf

Thanks for your work on this!
So it looks like it would be good to use both TeXLive and Tectonic (because of the encoding differences, which we hopefully can fix at some later point).
But do we need PDF generation on multiple OSs?
I have the feeling that one would be enough.
And the setup file would be simpler in case people want to use it as a template for their own CI.

Only test PDF creation on Linux (at least not windows) for now, since this is mostly done only on RTD anyway?

Yes, I think that's enough for now.
We can always add more configurations later, if we feel like it.

[...] and add the raises-exception tag to the bash-magic cell.

Alternatively, we could just get rid of this example.
Maybe we can use another cell magic as an example?
Or we completely delete it, because there is a %%javascript example further down, anyway.

Noteworthy is the mixing of / and \ in paths, i.e.:
< doc/gallery/due-rst.pct.py}} ends here.}}
---
> doc/gallery\textbackslash{}due-rst.pct.py}} ends here.}}

I guess this could be saniticed within nbsphinx.

This can be fixed by changing nbsphinx_prolog, either by changing the slash to a backslash, or by filtering the rest of the path through posix_path.

The old build folder needs to be removed before starting a new build or it starts nesting in itself.

This should not be necessary if the build directory is outside the source directory.
But we can discuss this in more details if you make a concrete PR.

The other solution would be to differentiate between different tex engines in the preamble and change the font for xelatex, which tectonic is dirived from. But since I'm a pdflatex user, I have no idea how to do this xelatex with fontspec, all my experiments did fail so far at least.

I don't have experience with that either, probably some if-clauses like in https://tex.stackexchange.com/a/44701/ should be used?
But anyway, we can leave this as is for now and try to fix it later.
Would you like to start with a PR for one of the setups (we don't have to do everything at once)?.

I've just merged #491 which adds a workflow for linkcheck.

@s-weigand Any news?

I've just added #559 for building HTML on macOS.
@s-weigand Do you want to provide your work on the other variants as a PR (or multiple PRs)?
Doesn't matter if it's incomplete, we can keep working on the individual PRs.


Fuchsia SDK autoroller is paused

I reverted the most recent roll and paused the auto roller for a failing time zone unit test:
https://github.com/flutter/engine/pull/20770
[ RUN      ] FuchsiaShellTest.LocaltimesVaryOnTimezoneChanges
../../flutter/shell/common/shell_fuchsia_unittests.cc:188: Failure
Expected equality of these values:
  initial_dart_isolate_time_str
    Which is: "2020-08-26 02"
  final_dart_isolate_time_str
    Which is: "2020-08-25 20"
Local time in Europe/Amsterdam rounded down to nearest hour read twiceshould be the same but this test says they are not; time zone handling in the dart VM is likely broken.
[  FAILED  ] FuchsiaShellTest.LocaltimesVaryOnTimezoneChanges (352 **ms)**

Possibly related:
https://github.com/dart-lang/sdk/commit/0e1d32f10c
@kf6gpe @iskakaushik @arbreng

Even though the test didn't start failing until the Fuchsia SDK roll, the test continues to fail even after reverting the roll.

https://github.com/dart-lang/sdk/commit/0e1d32f10c was reverted, and rolled into the engine, but the test is still failing as above. Leaving P0 because the engine tree is closed on this.

Well, on the upside, the test did what it was designed to do -- which is to fail if setting time fails...

This behavior is very likely broken prior to the test being added, I filed: https://github.com/dart-lang/sdk/issues/43199 to fix the underlying problem. I will revert the test to enable the autorollers.


Update next Pipelines release to indicate PipelineResources is deprecated

In TEP-0074 we have decided to officially deprecate PipelineResources.
We need to announce this to our users via the deprecation warnings in the Pipelines release notes and also to update our docs to make this clear.
Adding this issue so I can put it in the next milestone and make sure we track it in case it slips my mind :D
/assign

/assign


"Building" pop-up obscures the integrated terminal

Brief Issue Summary
When compiling my project, the pop-up window hovers over the integrated terminal and cannot be dismissed.
Compiling can take some time, and for the duration I cannot use the terminal 🙁
Expected:
Compile stuff and still be able to use the terminal.
Either:

Be able to dismiss the pop-up
Be able to move it
Be able to disable it completely

Apparent Behavior:

Platform and Versions

Operating System: macOS
VSCode Version: 1.45.1
CMake Tools Extension Version: 1.4.0

Are you able to hide it by clicking the bell icon in the status bar?  (You might have to click it twice)

That one bothers me too, but double clicking at least hides the pop-up.
It would be great to have a generic vsc-wide solution for showing/hiding pop-ups.


Release Google.Cloud.CloudControlsPartner.V1 version 1.0.0-beta01

Changes in this release:
Initial release.

Created release for Google.Cloud.CloudControlsPartner.V1-1.0.0-beta01


fix: add "use strict"; to style macro cjs output

Should fix:

When projects use size: 'control' via style macros, it's built as an arbitrary value, [2rem], which isn't valid css, because this is set as a global this instead of undefined. This is supposed to be undefined or a MacroContext. Adding "use strict"; prevents this from becoming the global this which causes values to be defined as arbitrary.

✅ Pull Request Checklist:

[ ] Included link to corresponding React Spectrum GitHub Issue.
[ ] Added/updated unit tests and storybook for this change (for new code or code which already has tests).
[ ] Filled out test instructions.
[ ] Updated documentation (if it already exists for this component).
[ ] Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

🧢 Your Project:

@snowystinger Yeah we decided we can look at expanding this to more files later. It might introduce some unexpected bugs if we apply it everywhere at once.


float_format string error

The float_format string works for single values i.e. float_format='%.1f', but it does not appear to work for a formatted string of columns. For example, If I had four columns with increasing significant digits, separated with tabs:
fmt_string='%.1f\t%.2f\t%.3f\t%.4f'

Then for some DataFrame X, I should be able to use:
X.to_csv('./out.txt',float_format=fmt_string,index=False)

But it unfortunately balks at me:
TypeError: not enough arguments for format string

see #4668
I think there is a wish to support a float_format=dict_of_formatters, but it is not implemented
want to submit a pull-request?


Fix python name in macOS menu bar

Description

My favourite kind of change! Hacky and workaround-y!
In macOS, having python3.9 (or whatever version) in the menu bar when launched from the console is not pretty. macOS takes this title from the base name of running process (e.g. /usr/bin/python3.9 -> python3.9), without resolving symlinks!
That means we can sneak in whatever name we want if we craft a symlink to sys.executable and relaunch the process, right? Say no more.
This PR creates a temporary symlink to sys.executable, intentionally named napari. We then restore the original sys.executable value to whatever it was before the relaunch.
Questions:

We are already using the subprocess approach to launch pythonw if available. This would add a second subprocess. Is that too much of an overhead?
Any reason we are not using os.exec(ve) to replace the process instead of running a subprocess?

Type of change

[X] Bug-fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

References

Closes #4910
How has this been tested?

[X] Locally, running napari or python -m napari makes the menu bar show the right name.

Current main:

This PR:

Final checklist:

[X] My PR is the minimum possible work for the desired functionality
[X] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] If I included new strings, I have used trans. to make them localizable.
For more information see our translations guide.

@tlambert03 This was even more fun! I structured everything in a separate function. Let me know how you like it!

LGTM!
(I wish in the future we have a single place for the platform-specific logic, instead of scattered through different files, though)

@jaimergp @potating-potato
Since the merging of this PR, I'm not able to run napari from main.
First posted about this on zulip: https://napari.zulipchat.com/#narrow/stream/212875-general/topic/Unable.20to.20launch.20napari.20on.20main/near/297078294
I used git bisect to diagnose this error when trying to launch napari from the terminal:
Traceback (most recent call last):
  File "/Users/piotrsobolewski/Dev/miniforge3/envs/apple-TF29/lib/python3.9/runpy.py", line 197, in _run_module_as_main
    return _run_code(code, main_globals, None,
  File "/Users/piotrsobolewski/Dev/miniforge3/envs/apple-TF29/lib/python3.9/runpy.py", line 87, in _run_code
    exec(code, run_globals)
  File "/Users/piotrsobolewski/Dev/napari/napari/__main__.py", line 504, in <module>
    sys.exit(main())
  File "/Users/piotrsobolewski/Dev/napari/napari/__main__.py", line 500, in main
    _run()
  File "/Users/piotrsobolewski/Dev/napari/napari/__main__.py", line 214, in _run
    from napari import Viewer, run
ImportError: cannot import name 'run' from 'napari' (unknown location)

This is on macOS 12.5.1 arm64 python 3.9 conda-forge

@psobolewskiPhD did you check that in your site-packages there is no napari directory?

Yup, first thing I tried.
Did a debug with @jaimergp just now, it's due to me having all my python stuff in one folder, which is also the parent of my napari git repo. napari launches from any other folder.


Optimize auto-configuring parameters

Since the introduction of named parameters in PHP 8.0, it has become useful to remove unused parameters from being passed.
This PR addresses this issue and optimizes auto-configuring parameters for a bit of performance.

Codecov Report

Merging #30 (49b9a28) into master (b330261) will decrease coverage by 0.09%.
The diff coverage is 91.66%.

@@             Coverage Diff              @@
##             master      #30      +/-   ##
============================================
- Coverage     92.54%   92.45%   -0.10%
- Complexity      657      665       +8
============================================
  Files            24       24
  Lines          1302     1312      +10
============================================
+ Hits           1205     1213       +8
- Misses           97       99       +2

Impacted Files
Coverage Δ

src/Traits/ResolveTrait.php
79.88% <50.00%> (-0.36%)
:arrow_down:

src/Resolvers/Resolver.php
99.09% <92.30%> (-0.91%)
:arrow_down:

src/Resolvers/AutowireValueResolver.php
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b330261...49b9a28. Read the comment docs.


CI fixes

Conveniently, Travis makes private variables unavailable to forks by default:
https://docs.travis-ci.com/user/environment-variables/#Defining-Variables-in-Repository-Settings


Select space by name?

Love this so much, first of all. It's super helpful for automating my workflow switching between projects.
One limitation I've run into is that I sometimes reorder my spaces for convenience week to week. But since space 4 won't always be project A, I have to remember to update my script any time I reorganize.
How feasible is it for this cli to find a space by name?

Closing this in favor of a #2


rosindex landing page is garbled version of README.md. How to replace with rosdoc2 generated page?

The landing page of my ros package is a somewhat disfigured version of the README.md that is on github (note the  numbered items 1), 2) etc  at the bottom under the "About timestamps"  heading are all gone and merged into one blob).
I had hoped that somehow I could get the page generated by rosdoc2 to show up instead of the translated README.md.
Note: this issue is a follow-up to issue #58

This issue should really be in rosindex.
rosdoc2 uses python and the myst md parser, while rosindex uses ruby, jekyll and the "red carpet" parser (though that might need to switch to kramdown since "red carpet" support is deprecated in jekyll. So your literal request, "make them the same" is not really feasible.
I think though that your issue is that the formatting in rosindex does not match what you want toward the end, with the numbered list in ## About Timestamps. Right?
Markdown is not a well-defined specification, so there is no "right" way to do things. But generally, numbered lists are created like:

An Item

NOT

An Item

Both seem to work here in Google markdown, but the period format is more normal IIUC.
Also, you ran together your numbered paragraphs:

First
Second

Many markdown implementations will merge that into a single paragraph, as you can see in rosindex. I've seen different specs on how to prevent that, one says "add a blank line" another says "add two spaces at the end of the line".
I did a rosindex run where I replaced the parentheses with periods at the end of your README, like so:

## About timestamps

A message in a recorded rosbag has three sources of time information:

1. The recording timestamp. This is when the message was written into
the bag by the rosbag recorder. It is the least precise of all time
stamps and therefore usually not used.
2. The message time stamp in the header (header.stamp). This is the
time when the ROS driver host received the first event packet from the SDK
for that ROS message. Remember that a ROS message can contain multiple
SDK packets, but the header.stamp refers to the first SDK packet
received.
3. The sensor time encoded in the packets. This time stamp depends on
the encoding.

You can see the result of that (temporarily) at http://test.caspia.com/p/event_camera_py/  The numbered list is now separated. You could also have accomplished the same thing by adding two spaces at the end of the numbered lines to force new lines.
Inconsistencies in markdown are a pain, and I wish rosindex was in python instead of ruby/jekyll. But that is where we are at, and that is not likely to change.

@rkent Thank you very much for the fast, detailed, and very helpful response!
Sorry I was blissfully unaware of rosindex vs rosdoc2. I just assumed that rosindex would run rosdoc2, but apparently not so. Thank you clarifying that.
I fixed the markdown in my README.md. Hopefully this will render better now on rosindex.


How to add a progress bar with %age while loading data?

assuming the data is being uploaded from only from s3 bucket.

If you are looking for a progress bar that shows when downloading your dataset into Glance, then check out https://github.com/Kitware/glance/pull/442. Once that is merged, then that will report download progress.

yeah, that is what i am looking for, thanks for the update but when do think that process will be done by?


Regression Defect - Usage by Course - Course Dropdown width is small

Course dropdown should be required more width because unable to see complete course name

Select any course option from user progress report - Download Report button is not aligned properly

This issue is not covered in v5.0 and to be analyzed

@htvenkatesh @pandutibil - request you to include this enhancement in v5.0 as part of February sprints.

This Course program not consider in the current Sprint will be taken in to analysis


Check that service methods are supported by the resource endpoint, otherwise throws

For now methods don't throw, simply they are no-op (e.g.: https://github.com/sphereio/sphere-node-sdk/releases/tag/v1.3.0)


Add searchbar clear button styles

Codecov Report

Merging #128 (3b40e09) into metadata (e089c7a) will not change coverage.
The diff coverage is n/a.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@            Coverage Diff            @@
##           metadata     #128   +/-   ##
=========================================
  Coverage     48.18%   48.18%
=========================================
  Files           129      129
  Lines          4568     4568
=========================================
  Hits           2201     2201
  Misses         2367     2367

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Focus a channel by joining it, refactor user commands #1189

This should work for focusing channels by joining them, the switch statement might need further refactoring. Thoughts?

@realies, are you willing/able to pursue work on this? :)


Unable to set state 0. Segmented control has only 0 states from 0 to -1.

Great work! When I was trying to set it up, I kept receiving this error message : 'Unable to set state 0. Segmented control has only 0 states from 0 to -1.' any idea what's going on?

Hi, thanks for report! I've just pushed a fix. This happens because of control try to setup with state 0, but it hasn't data source, so has no state. To use segmented control, set its data source and implement methods numberOfStatesInSegmentedControl: and segmentedControl:titleForStateAtIndex:.
For more detailed explanation of usage, check out https://github.com/LunApps/LUNSegmentedControl#usage


AWS Amplify icon is missing

Hi - first off, I LOVE THIS tool.
I do miss the AWS Amplify logo though.

Not sure how that's missed, let me check :)

@renebrandel do you have an SVG copy of it?

I don't have the exact SVG copy of it but I do have the logo available from docs.amplify.aws.
Amplify Logo.svg.zip

Thanks @renebrandel all sorted!
Converted it all to a svg and added it to the website. Thanks for raising the issue!

Thanks!! Love the tool!


Add integer suffixes to the parser

Right now there is compiler support for signed int types, but no way to create them. Per https://github.com/dada-lang/dada/pull/56#issuecomment-1013675589, add Rust-style integer suffixes to the parser so it can produce signed int types.
@nikomatsakis what suffixes do you want for these? "uint" / "int", "u64", "i64"?

Hmm, regarding suffixes, I don't know! Let's run with i and u for now?


Operator configuration with OLM deployment

As described, the function mesh operator can be configured.
Since https://github.com/streamnative/function-mesh/pull/339 these configurations can be applyed in helm based deployments but not via OLM.
Is there any way to parameterize without manually patching the deployed operator "ClusterServiceVersion" on the cluster?

looks like the only way to configure operator is using env: https://github.com/operator-framework/operator-lifecycle-manager/blob/master/doc/design/subscription-config.md
I created a PR to parse env for flags


fix whitespace creation

This should fix https://github.com/shama/bel/issues/72
patch notes

now creates strings on the server, leading to a 10x speed improvement for rendering
detects if in Electron, Node, or browser and runs the right version
fixes random text node creation in lists

Ok, so right now things are not solved. The current state is:

browser tests pass, behavior is patched
server tests fail, we now rely on .lastChild in the critical path and min-document does not recognize that
this means that running code on the server could already fail, but it wasn't caught by the tests

What I'm thinking we should do:

unpublish the last version: it's broken and oh no that's not good
merge the patch in this PR to master
split browser & server code, and replace server code with https://github.com/shuhei/pelo/blob/master/index.js

We should get a 10x server render improvement in the process, but also do a semver major release. With that happening we could get cheeky and also add https://github.com/shama/bel/pull/69.
I have a feeling this is a fair amount of changes, so input would be greatly appreciated! Thanks heaps!

IRC dump
02:55 <yoshuawuyts> URGH
02:55 <yoshuawuyts> ok, so I got this whole mad thing working in the browser - fixed the regression
02:55 <yoshuawuyts> (talking about `bel`)
02:55 <yoshuawuyts> but now the server is failing
02:56 <yoshuawuyts> and worse: it's failing because of a pre-existing bug in `bel` - e.g. min-document is an incomplete DOM implementation, and stuff like .nodeValue and .lastChild does not exist
02:57 <yoshuawuyts> so either: 1) we do a revert and pretend nothing changed. This will disallow child-node reordering tho. Or 2) we merge and break server rendering
02:57 <yoshuawuyts> I'm not thrilled about either option
02:59 <yoshuawuyts> well, technically we're not breaking server rendering - it's already broken - it just makes it, err, well more apparent
03:00 <yoshuawuyts> could be a cool opportunity to complete move to https://github.com/shuhei/pelo btw
03:00 <yoshuawuyts> option 3?
03:00 <yoshuawuyts> (anyone got thoughts on this?)
03:05 <sethvincent> would it be worth working on min-document or an alternative?
03:07 <yoshuawuyts> sethvincent: pelo uses string concatenation which provides a 20x speed improvement over object based approaches. I think if we're going to change anything specifically for server stuff that'd be the clearest path
03:07 <sethvincent> hmm, that makes sense

woot, it works!

Ok, so we're now running pelo in node / electron main process, and regular ol' bel code in electron renderer / browser. This means we got a 10x or so perf improvement for rendering in Node. Yay!
Semver major because the intermediate representation on the server also changed. Thanks!

That little whitspace fix got out of hand, right? 😆

v5.0.0


SquareSolid icon builds as undefined

https://carbon-icons-svelte.onrender.com/

Thank you for reporting.
Fixed in v12.11.1


[Enhancement] Implement retry strategy based on Pulsar message middleware

Search before asking

[X] I had searched in the issues and found no similar issues.

Enhancement Request
This issue is a sub issue of #4556 and aims to implement retry strategy based on Pulsar middleware
Describe the solution you'd like
Implement a retry strategy based on Pulsar
Are you willing to submit PR?

[X] Yes I am willing to submit a PR!

Code of Conduct

[X] I agree to follow this project's Code of Conduct *

Hi @pandaapo I have creted a PR for this issue.Could you please review it? Here's the link https://github.com/apache/eventmesh/pull/4898

In Pulsar the retry queue is triggered by the consumer.ReconsumeLater() method so I tried to leverage it in here.


Add PR template

[ ] Wait for issue template feedback
[ ] Iterate on content here
[ ] Update commit authors to include @GeoSot

Wait for issue template feedback

Just out of curiosity did you have any feedback of the issue template?
On my side I would love having access to this PR template. Tried it in several PR description and it helps me to fight against laziness and force me to add more details 😄 Really like the "Live preview" part which can help the reviewer to save some time without having to search the modification in the documentation.

I here you on your feedback about the checkboxes and progress... if you have thoughts on how to rewrite this to avoid that, I'm down to review. Otherwise I'm inclined to close this as stale :).

Do we have any knowledge, if github is planning to support form templates (yml) on PRs too?

Note: Issue forms are currently in beta for public repositories on GitHub.com only.

I suppose we'll have to wait some time unfortunately.
@mdo Please let this PR open a little, I'll try to propose something.


refactor(connector): [Shift4]Enhance currency Mapping with ConnectorCurrencyCommon Trait

Type of Change

[ ] Bugfix
[ ] New feature
[ ] Enhancement
[x] Refactoring
[ ] Dependency updates
[ ] Documentation
[ ] CI/CD

Description

This pull request introduces the get_currecny_unit from ConnectorCommon trait for shift4. This function allows connectors to declare their accepted currency unit as either "Base" or "Minor".
Additional Changes

[ ] This PR modifies the API contract
[ ] This PR modifies the database schema
[ ] This PR modifies application configuration/environment variables

Motivation and Context

Closes #2245
How did you test it?

(Please review the changes and let me know if any further issues or changes to be made.)
Checklist

[x] I formatted the code cargo +nightly fmt --all
[x] I addressed lints thrown by cargo clippy
[ ] I reviewed the submitted code
[ ] I added unit tests for my changes where possible
[ ] I added a CHANGELOG entry if applicable

Hi @sanketmp ,
Please use following cargo commands -
cargo clippy --all-features
ref - Cargo commands, and fix the errors thrown by clippy for the checks to pass and also use cargo +nightly fmt to fix the failing formatting check

ran the cargo +nightly fmt and gave no errors. Please review @srujanchikke

cargo clippy --all-features

You might also should run cargo clippy --all-features

cargo clippy --all-features

You might also should run cargo clippy --all-features

I have done that too. I don't know what is happening.

Hello @prasunna09, made the requested changes.

Hey @sanketmp, could you address the failing CI checks?

I couldn't figure out @SanchithHegde

@sanketmp As mentioned earlier in https://github.com/juspay/hyperswitch/pull/2557#issuecomment-1759244561, you must run cargo clippy --all-features and address the errors thrown.

I have done that but I'll try again


Indian Postal Code Tracker

Project title
Indian Postal Code Tracker
Project Description
I am a GSSOC'22 Participant and I want to add one Pincode Tracker web application which will fetch and display information regarding any Indian postal code using India post API.
Stack:
And in order to tick the check box just but x inside them for example - [x] like this. Please delete options that are not relevant.

[x] Html
[x] CSS
[x] JavaScript

/assign


Will this support multi-window?

The official Flutter Windows embedder doesn't support multi-window. The NativeShell does, but it only support for old Flutter version. So I wonder if this embedder support.

This embedder is still very much a WIP, mostly experimental right now.
But yes, i do plan to look into supporting multi window at some point.


Maintenance Mode Site Validation Access

Summary
In order to give administrators confidence that their GitHub Enterprise Server instance is ready for all users to access after it is put in maintenance mode, they will be given the ability to specify an IP exception list of addresses that can access application services on the GitHub Enterprise Server instance while maintenance mode is enabled.
Those users accessing from the allowed IP address will be able to verify the instance's operations while the server is in maintenance mode for all other users.
Intended Outcome
Problems can occur when upgrading GHES versions, adding or updating hardware and carrying out other maintenance functions; some of these problems cannot be detected, diagnosed, and in some cases do not even manifest, until certain git, user, web or other interactions are performed.
This function will enable basic validation of system consumer interactions that will reduce the impact of encountering errors at scale when turning off maintenance mode and receiving production traffic. These basic tests may cover the different interaction models (web, API, git) and may be executed by direct user interaction or as customer-driven test suites.
How will it work?
GitHub Enterprise Server administrators will be able to add a list of IP Addresses that can be granted access while the instance is in maintenance mode for all others. They will do so via the Management Console.
Access will respect user permissions, and actions will be logged as per normal operation.
Should those users identify problems with the instance, access can be blocked, essentially reverting the server back to standard maintenance mode for further fault analysis and problem resolution.

🚢 This has shipped: https://github.blog/changelog/2022-05-31-github-enterprise-server-3-5-is-now-generally-available/


[FEATURE REQUEST] Support with TrueNas Scale or TrueCharts

Are there any plans or intent on getting nakama to run in TrueNas Scale in future ??

You can run it as a docker image on the  TrueNAS, see Docker instructions

The docker image pull defaults to cockroachDB and there is not way to switch to postgres since as from as I can tell these are not set up as environmental variables.

This doesn’t make sense as environment variables - we already have two separate Docker Compose files for the two databases.


[FEATURE] create end to end samples with instructions

Is your feature request related to a problem?
As a customer, I do not know how this dashboard can be used in real world
What solution would you like?
Create end to end samples for each ingestions, so that I can try the samples by myself
What alternatives have you considered?
N/A
Do you have any additional context?

Leverage the AWS Solution (CLO) to complete the end to end ingestion
https://docs.aws.amazon.com/solutions/latest/centralized-logging-with-opensearch/aws-services-logs.html

Or

Leverage the opensource Opensearch data-prepper for endto end samples
https://github.com/dlvenable/data-prepper-samples/blob/master/samples/s3-source-vpc-s3-sink/data-prepper/pipelines/vpc-flow-log-pipeline.yaml

Please note: both suggestions need to tweak based on the SImple Schema.

great idea !!
@wanghd89 can u plz create an initial PR with a README file describing these use cases ?

AWS - VPC flow logs (S3 source) use the next data-prepper pipeline
AWS ELB logs (S3 source) use the next data-prepper pipeline
AWS Cloud Trails (S3 source) use the next data-prepper pipeline


Single Sign-out

Good morning,
I am trying to implement the simple sign out, but I encounter a problem. Indeed, I use keycloak as a provider and if I understand the front-channel logout protocol the provider calls a url in an iframe, the problem is that pomerium sets the X-Frame-Options response header to SAMEORIGIN and therefore the browser blocks the response. How to modify this header in the pomerium authentication service? In the doc it is specified that we must not create an ingress for the authentication route, and if I understand the doc, the new way to modify the headers is an annotation in the ingress. Thanks

You can use the "Set Response Headers" option to disable these headers: https://www.pomerium.com/docs/reference/set-response-headers
set_response_headers:
  disable: true

This can be set the ingress.pomerium.io/set_response_headers annotation.


MB-11874 Show Automatic Reweigh Request by the Prime Updating Weights in Move History

Jira ticket for this change
Summary
Created a new event for documenting when a reweigh request is automatically generated by the prime updates the actual weights and total weight > 90% of weight allowance.
Setup to Run Your Code

💻 You will need to use three separate terminals to test this locally.
Terminal 1
Start the UI locally.
make office_client_run

Terminal 2
Start the Go server locally.
make server_run

Additional steps

Access the office app
Login as a prime simulator user
Select a move that already as payment requested (I used PENDNG) - remember the move locator
Click the update the shipment button
Update the shipment weight such that the actual weights and total weight > 90% of weight allowance (I set the weight requested to be 9,000) and save.
Log out and log in as a TIO
Select the move of the move locator you updated
Go to the move history page
There should be an entry for a requested reweigh

Verification Steps for Author
These are to be checked by the author.

[ ] Request review from a member of a different team.
[x] Have the Jira acceptance criteria been met for this change?

Verification Steps for Reviewers
These are to be checked by a reviewer.

Frontend

[ ] User facing changes have been reviewed by design.
[ ] There are no aXe warnings for UI.
[ ] This works in Supported Browsers and their phone views (Chrome, Firefox, IE, Edge).
[ ] There are no new console errors in the browser devtools
[ ] There are no new console errors in the test output

Screenshots

Messages

:book:
:link: MB-11874

  Generated by :no_entry_sign: dangerJS against 5b69e5dc755033a8b6456c668f53b4a3eed9201e

I noticed that when I updated the actual weight for one of the shipments - the move history page shows that "Updated shipment / HHG shipment, reweigh requested" twice. I'm not sure if it's because this move had two HHG shipments but I only updated the actual weight for one of them. GBLOC: KKFA MOVE CODE: XVWY93

Ooo interesting, it does look like it is requesting a reweigh for both shipments even though it's just the one over the reweigh weight. I will investigate further!

I noticed that when I updated the actual weight for one of the shipments - the move history page shows that "Updated shipment / HHG shipment, reweigh requested" twice. I'm not sure if it's because this move had two HHG shipments but I only updated the actual weight for one of them. GBLOC: KKFA MOVE CODE: XVWY93

@juliemoon Looks like this is expected behavior!
#7293


Cuda version

What Cuda version is needed to run Racon in GPU mode? I am running with Cuda v11.1.105 and it is not working. The readme says Cuda 9.0+.
When I run this command:
racon -m 8 -x -6 -g -8 -w 500 -t 10 -f -q -1 -c 2 -b --cudaaligner-batches 2  intermediate.long.fastq long_corr.paf.gz input.fastq

I get this error:
terminate called after throwing an instance of 'std::runtime_error'
  what():  GPU Error:: CUDA driver version is insufficient for CUDA runtime version /racon-v1.4.3/src/cuda/cudapolisher.cpp 46

Here is the output from running nvcc --version:
nvcc: NVIDIA (R) Cuda compiler driver
Copyright (c) 2005-2020 NVIDIA Corporation
Built on Mon_Oct_12_20:09:46_PDT_2020
Cuda compilation tools, release 11.1, V11.1.105
Build cuda_11.1.TC455_06.29190527_0

I am running this from this docker image: nvidia/cuda:11.1-cudnn8-devel-ubuntu18.04

I have now also tried it using Cuda version 9.2 and got the same error.
Docker image: nvidia/cuda:9.2-devel-ubuntu18.04
Output from running nvcc --version:
nvcc: NVIDIA (R) Cuda compiler driver
Copyright (c) 2005-2018 NVIDIA Corporation
Built on Tue_Jun_12_23:07:04_CDT_2018
Cuda compilation tools, release 9.2, V9.2.148

Hi,
try adding cuda path when running cmake, something like this  -DCUDA_TOOLKIT_ROOT_DIR=/usr/local/cuda-10.0/.
Best regards,
Robert


chore(deps): fix the distlib issue

Pull Request description

How to test these changes

...

Pull Request checklists
This PR is a:

[ ] bug-fix
[ ] new feature
[ ] maintenance

About this PR:

[ ] it includes tests.
[ ] the tests are executed on CI.
[ ] the tests generate log file(s) (path).
[ ] pre-commit hooks were executed locally.
[ ] this PR requires a project documentation update.

Author's checklist:

[ ] I have reviewed the changes and it contains no misspelling.
[ ] The code is well commented, especially in the parts that contain more complexity.
[ ] New and old tests passed locally.

Additional information

Reviewer's checklist
Copy and paste this template for your review's note:
## Reviewer's Checklist

- [ ] I managed to reproduce the problem locally from the `main` branch
- [ ] I managed to test the new changes locally
- [ ] I confirm that the issues mentioned were fixed/resolved .

not sure if this one would be the definitive solution for this issue. but at least, it seems it fixed here.
I will monitor the problem if that happens again


Update configuration-service-provider-reference.md

Changes made per Lavinder and Task 33226532.

@Dansimp - I resolved the conflict. Is there anything else I need to do on my end to get this resolved?  Thank you!


Deployment not working without node_modules folder

I'm trying to deploy my app to a Ubuntu server, using GitLab. I'm currently building in GitLab, and then copying the build folder to the server. This however doesn't work when I try to node server.js:
Error: Cannot find module 'react'
I found out that it works when I copy my node_modules folder to the server, but is it designed to work that way?

That's because of webpack-node-externals package.
https://www.npmjs.com/package/webpack-node-externals
Razzle has kind of this snippet inside webpack configuration (createConfig.js):
nodeExternals({
			whitelist: [
				!isProduction ? 'webpack/hot/poll?300' : null,
				/\.(eot|woff|woff2|ttf|otf)$/,
				/\.(svg|png|jpg|jpeg|gif|ico)$/,
				/\.(mp4|mp3|ogg|swf|webp)$/,
				/\.(css|scss|sass|sss|less)$/
			].filter(x => x)
		})

So, yeah, it's designed to work that way


Exclude all Redirector templates, not just RedirectorPage

Classes that extend RedirectorPage are still included in the sitemap if exclude_redirector_pages is enabled. This change excludes all subclasses as well.

Thanks @mikenz Looks good, tests pass.


corebot updates fixes #1558

Fixes #1558
Proposed Changes
update AdapterWithErrorHandler.cs to work with gov cloud
update csproj to reference 4.4.5 bot fx assemblies
remove ICredentialProvider from startup.cs

going to redo this and split out just corebot from the other work


Add release notes for <IP_ADDRESS>

Signed-off-by: Eric Lobdell<EMAIL_ADDRESS>Description
Adds release note file for <IP_ADDRESS> release
Issues Resolved
https://github.com/opensearch-project/index-management-dashboards-plugin/issues/98
Check List

[X] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Codecov Report

Merging #124 (bbca8ff) into main (b65a8f0) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #124   +/-   ##
=======================================
  Coverage   63.35%   63.35%
=======================================
  Files         155      155
  Lines        4410     4410
  Branches      731      731
=======================================
  Hits         2794     2794
  Misses       1404     1404
  Partials      212      212

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b65a8f0...bbca8ff. Read the comment docs.


Limit access to national identification number and create person

Approved with a small worry that something is escaping my attention because of the PR size. Try to hold the PRs up to 250 lines


POSIX arch: Give a nicer error message if built in unsuported platform

Instead of failing badly later, let's give a clear error message if the user tries to build in an unsupported platform.

On @tejlmand 's request  :)

Just added DNM as it will cause a merge conflict with the native_sim PR, and this one will be way faster to rebase and have CI rerun than the other

The PR has just been rebased, there is no changes otherwise.


How can I distinguish fingerprints?

Hi, is there possibility to distinguish fingerprints?
For example, how to get name of fingerprint or its ID after successful authentication.
The idea is storing different information for different fingerprints in local storage and get it after authentication.
Thanks!

No, check the native SDK’s please. It’s a binary thing: either the fingerprint is ok or it isn’t.


Conversations are marked as deleted rather than destroyed

Destroy is still possible via an explicit boolean
conversations lib: by default, deleted conversations are not returned unless explicitely requested

(looks great otherwise)

\o/


Apply pdf rules

This PR will allow users to apply pdf cleaning rules on normal text files.
For example, if we have a sentence This is a sentence\ncut off in the middle because pdf. in a normal text, we would get This is a sentence and cut off in the middle because pdf.
This PR will return This is a sentence cut off in the middle because pdf. instead.

@neogyzhu : It is better to use doc_type=pdf in such cases rather than making it a part of a common use case.


Consider unset variables to be an error.

If a command uses a variable that has not previously been set, the command will not be executed, and an error message will be printed identifying the unset variable.
Fixes #136

Thanks for the review, @mike-burns.


Adding support for external triggers

This PR adds the functionality to:

Output frames for time stamps where an external trigger occurred
Supports trigger events in the encoded data
Supports triggers extracted with this script.
Allows to set the maximal time difference between the trigger time stamp and event time stamps.

One more thing: the CI checks are currently broken so I will update those.
Before you resubmit, please run
colcon test --packages-select frequency_cam
colcon test-result --verbose

The checks are not running right now but almost certainly you will get linter complaints about the formatting.

Thanks for the @berndpfrommer. I'm aware that I didn't update the documentation and that the code needs some cleanup. I should have mentioned it in the PR that I did want to have a first check, if the way, how I implemented it does actually make sense. It would be too bad, if I spent time to make the code more clean, but the way how I solved it doesn't make sense.
I will try to address your points withing the next days.

In that case, hold off for now, because I have not looked at the code thoroughly enough.

My eyes grew heavy and my sight grew dim when reading makeFrequencyAndEvent() in frequency_cam.cpp. Too long a function, too many conditionals and stuff like distance_too_big that is probably data specific. It would take me a long time and much testing before I feel comfortable with the code. What to do here? I don't want to merge code that I don't understand and don't trust to work reliably. Here is a counter proposal that you may not like because the code works for your purpose and the paper is submitted :):
If I were to write this code, I'd structure it like this (for offline use, playing from ROS bag only for now)

make a full pass through the bag or your trigger file, and get the time stamps of the triggers into a ordered collection (vector).

I don't think it makes sense to make a full pass through the bag, but we could simply rely on the trigger file (and add the trigger export script to the repo)

Iterate through the trigger time stamps. Play back the events that come before the current trigger time stamp. There is a decoder functions especially for this. Just talking about the ROS2 implementation now for simplicity: modify eventMsg() to not make the decoder->decode() call, but leave otherwise intact. Instead, call decodeUntil() right after the call to eventMsg(), in the loop while(reader.has_next()), and pass in the current trigger stamp as time limit. It will only decode until that time stamp, or the end of the message, whatever comes first. From the number of bytes decoded you can tell whether there are more events left in the message buffer, and you will have to keep track of how many bytes of a message have been consumed because you must use the remaining bytes for the next frame. This logic is sufficiently complex that it warrants writing a separate function, e.g. playFromBagFrameBased(), but it should be more readable and general purpose than what is currently in this PR.

I like this idea. I will see how far I will get before ICRA.

@AndreasAZiegler I accidentally committed a bunch of changes against the branch with my alternative implementation so I went ahead and merged it into master. A lot of changes have happened over the last few days with respect to the event camera repos. In preparation for making the driver and support software available as installable apt packages, a lot of them have been renamed e.g. from event_array_msgs -> event_camera_msgs. Repos are now no longer under my personal (berndpfrommer) github account but under the ros-event-camera organization. The event_camera_codecs API has undergone changes to make it more user friendly, and frequency_cam was adapted to use the new API.
The upside is that it's now easier to play event up to a certain time. Please have a look at the event_camera_codecs repo, and of course the sample code in frequency_cam.


Images added

Images added related to the respective achievements

@anushbhatia I have searched and found these images related to the achievement section. Kindly check.

@anushbhatia Kindly check

@anushbhatia it's the same image which i have added i guess

it's square so u don't have to squeeze the image

actually I set the height of all the images so that cards are of same size.
Should i put the picture as it is without setting the height?

yep use this image without setting height

@anushbhatia Here it is :)

ok then keep it like this

@anushbhatia, okay!
Kindly merge it