Issue when using KMS Keys

#post-scan-actions/aws-python-promote-or-quarantine
Problem to solve
By default, the plugin will not consider any KMS key. So, after the deployment in an s3 bucket that is using a KMS key for encryption the plugin will not work until manually adding the "PromoteOrQuarantineLambdaRole" IAM Role as a user in the Keys in use for the Bucket, SQS, and SNS.
Proposed solution
Request the Keys as parameters in the CloudFormation Template to add the "PromoteOrQuarantineLambdaRole" IAM Role as a user in the KMS Keys.
Alternatives
Add a documentation topic describing the action needed. So, that is necessary to add the  "PromoteOrQuarantineLambdaRole" IAM Role as a user in the KMS Keys
Additional context

@jack-c-tang any updates here?

It's not a good practice to update resources outside of the stack. I would suggest the alternative solution to update the document.

@fafiorim any comments on that?

Hi @felipecosta09 and @carpusherw. As it isn't a good practice to update resources outside the stack, let move to the alternative solution that is the documentation of the additional steps needed.

@jack-c-tang I think we can close this issue as resolved

@jack-c-tang I think we can close this issue as resolved

I thought the document still needs to be updated?

@fafiorim, take a look at PR #139, as soon is merged, it should fix your issue.

It's supported now.


On the chart editing screen, the icon of dataset should be similar to those used on the “Dataset” screen.

Hello,
Physical and virtual data sets do not have the same pictogram.

On the chart editing screen, the icon should be similar to those used on the “Dataset” screen.

Hello,
Physical and virtual data sets do not have the same pictogram.
On the chart editing screen, the icon should be similar to those used on the “Dataset” screen.

Hi, thanks for raising this! I definitely agree, do you think it's something you would be able to change? 🙏

I can try but I'm a novice.
Could you help me to identify files to changed ?
After, I will try to see how to add the control on the kind of dataset and apply the good SVG :
Physical dataset :

Virtual Dataset :


Gradle simulate task fails

The gradle simulate task doesn't work, looks like there is a configuration missing for snobotSimLibs.
This is my build.gradle setup:
plugins {
    id "java"
    id "jaci.openrio.gradle.GradleRIO" version "2018.03.06"
    id "com.snobot.simulator.plugin.SnobotSimulatorPlugin" version "2018.05.23" // Should point to the latest version at https://login.gradle.org/plugin/com.snobot.simulator.plugin.SnobotSimulatorPlugin
}

apply plugin: com.snobot.simulator.plugin.SnobotSimulatorPlugin

def TEAM = 0000
def ROBOT_CLASS = "frc.team0000.robot.Robot"

// Define my targets (RoboRIO) and artifacts (deployable files)
// This is added by GradleRIO's backing project EmbeddedTools.
deploy {
    targets {
        target("roborio", jaci.openrio.gradle.frc.RoboRIO) {
            team = TEAM
        }
    }
    artifacts {
        artifact('frcJava', jaci.openrio.gradle.frc.FRCJavaArtifact) {
            targets << "roborio"
        }
    }
}

// Defining my dependencies. In this case, WPILib (+ friends), CTRE Phoenix (Talon SRX)
// and NavX.
dependencies {
    compile wpilib()
    compile ctre()
    compile navx()
    compile openrio.powerup.matchData()

    testCompile snobotSimCompile()
    testCompile snobotSimJavaCompile()
}

// Setting up my Jar File. In this case, adding all libraries into the main jar ('fat jar')
// in order to make them all available at runtime. Also adding the manifest so WPILib
// knows where to look for our Robot Class.
jar {
    from configurations.compile.collect { it.isDirectory() ? it : zipTree(it) }
    manifest jaci.openrio.gradle.GradleRIOPlugin.javaManifest(ROBOT_CLASS)
}

task wrapper(type: Wrapper) {
    gradleVersion = '4.4'
}

// SnobotSim
build.dependsOn snobotSimUnzipNativeTools

And the result of running gradle simulate is:
> Configure project :
Eclipse not configured, will not update classpath

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':simulate'.
> Configuration with name 'snobotSimLibs' not found.

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. Run with --scan to get full insights.

* Get more help at https://help.gradle.org

Deprecated Gradle features were used in this build, making it incompatible with Gradle 5.0.
See https://docs.gradle.org/4.5.1/userguide/command_line_interface.html#sec:command_line_warnings

BUILD FAILED in 2s
1 actionable task: 1 executed

This appears to be the same issue as: #14

Update the snobot simulator plugin to "2018.05.23", snobot sim version to "0.11.0"

That got me further along. It launches the settings window, but it's stops at 80% execution and repeats the same error.
Here is the truncated output (the last two lines are repeated continuously)

> Task :runSnobotSim
  C:\Users\wisaa\.gradle\caches\modules-2\files-2.1\com.snobot.simulator\snobot_sim_gui\0.11.0\e1a97cc451c5fddf77085a07846bd882b1f2e188\snobot_sim_gui-0.11.0-all.jar;
  C:\Users\wisaa\.gradle\caches\modules-2\files-2.1\jfree\jcommon\1.0.16\376f19a7c317509a57dfc684cdfd4081db7c082c\jcommon-1.0.16.jar;
  C:\Users\wisaa\.gradle\caches\modules-2\files-2.1\jfree\jfreechart\1.0.13\b5fbdc552c4caec3dac4b4dcbc10d119a194946e\jfreechart-1.0.13.jar;
  C:\Users\wisaa\.gradle\caches\modules-2\files-2.1\org.apache.logging.log4j\log4j-api\2.11.0\bede79a3f150711634a3047985517431bf6499f2\log4j-api-2.11.0.jar;
  C:\Users\wisaa\.gradle\caches\modules-2\files-2.1\org.apache.logging.log4j\log4j-core\2.11.0\e6b751e02120c08702d98750f6a80bc25343b7f5\log4j-core-2.11.0.jar;
  C:\Users\wisaa\.gradle\caches\modules-2\files-2.1\org.yaml\snakeyaml\1.18\e4a441249ade301985cb8d009d4e4a72b85bf68e\snakeyaml-1.18.jar;
  C:\Users\wisaa\.gradle\caches\modules-2\files-2.1\com.miglayout\miglayout-swing\4.2\ca85067488e79a2078ba4eb8e2617653e9172388\miglayout-swing-4.2.jar;
  C:\Users\wisaa\.gradle\caches\modules-2\files-2.1\com.miglayout\miglayout-core\4.2\70f2bfa2a077ee1632cc8229deffa1d942825c78\miglayout-core-4.2.jar;
  C:\Users\wisaa\.gradle\caches\modules-2\files-2.1\org.opencv\opencv-jni\3.2.0\5c6a5b457a6a4071007cf53b8bab479933e01327\opencv-jni-3.2.0-all.jar;
  C:\Users\wisaa\.gradle\caches\modules-2\files-2.1\net.java.jinput\jinput\2.0.7\7795d3dbbcfecd03e3d2bf964b04c0cd042415f7\jinput-2.0.7.jar;
  C:\Users\wisaa\.gradle\caches\modules-2\files-2.1\net.java.jutils\jutils\1.0.0\e12fe1fda814bd348c1579329c86943d2cd3c6a6\jutils-1.0.0.jar;
  C:\Users\wisaa\.gradle\caches\modules-2\files-2.1\com.snobot.simulator\snobot_sim_java\0.11.0\e0bd8716659eba70a05c773e1f768a5f493349d5\snobot_sim_java-0.11.0-uber_native-windows.jar;
  C:\Users\wisaa\.gradle\caches\modules-2\files-2.1\edu.wpi.first.ntcore\ntcore-jni\4.1.0\c1ad0b0938157416131580a988e5e7c2e976c983\ntcore-jni-4.1.0-all.jar;
  C:\Users\wisaa\.gradle\caches\modules-2\files-2.1\edu.wpi.first.cscore\cscore-jni\1.3.0\9a49af3f76e0122517f53a65b2cd73c6452c0a9\cscore-jni-1.3.0-all.jar;
Info    C:/projects/snobotsim/snobot_sim_java/cpp/lib/SnobotSimJava/Jni/RegisterCallbacksJni.cpp:32 - Initializing the simulator
Jun 21, 2018 9:05:17 PM net.java.games.input.ControllerEnvironment log
INFO: Failed to initialize device HIDI2C Device because of: java.io.IOException: Failed to acquire device (8007001e)

21:05:17.201 [main] ERROR com.snobot.simulator.joysticks.JoystickDiscoverer - Unknown joystick name T.Flight Hotas X
Warning, this is the example robot bundled with the simulator!
To configure this for your robot, change <project_dir>/simulator_config/simulator_config.properties, and update the robot_class field
Setting velocity : -nan(ind)
21:05:18.463 [SimulatorThread] ERROR com.snobot.simulator.jni.standard_components.EncoderCallbackJni - Unknown Encoder callback Period - HalCallbackValue [mType=2, mBoolean=false, mInt=0, mLong=0, mDouble=NaN]
Setting velocity : -nan(ind)
21:05:18.463 [SimulatorThread] ERROR com.snobot.simulator.jni.standard_components.EncoderCallbackJni - Unknown Encoder callback Period - HalCallbackValue [mType=2, mBoolean=false, mInt=0, mLong=0, mDouble=NaN]
Default teleopInit() method... Overload me!
Default robotPeriodic() method... Overload me!
Setting velocity : -nan(ind)
21:05:18.486 [SimulatorThread] ERROR com.snobot.simulator.jni.standard_components.EncoderCallbackJni - Unknown Encoder callback Period - HalCallbackValue [mType=2, mBoolean=false, mInt=0, mLong=0, mDouble=NaN]
Setting velocity : -nan(ind)
21:05:18.487 [SimulatorThread] ERROR com.snobot.simulator.jni.standard_components.EncoderCallbackJni - Unknown Encoder callback Period - HalCallbackValue [mType=2, mBoolean=false, mInt=0, mLong=0, mDouble=NaN]
Setting velocity : -nan(ind)

The task doesn't launch the simulator as a background task but as a blocking one, so that is why it is "stuck" at 80%.  I bet if you close it it will finish up.
Apparently I made a messy release with some debug stuff getting printed out.  Neither of these lines should affect your simulation.  If it does have a negative effect I can try to make a new release, but I'm currently focusing on supporting all of the changes that are currently going on in wpilib for 2019 instead of making updates to the 2018 version unless people find it unusable.
21:05:18.487 [SimulatorThread] ERROR com.snobot.simulator.jni.standard_components.EncoderCallbackJni - Unknown Encoder callback Period - HalCallbackValue [mType=2, mBoolean=false, mInt=0, mLong=0, mDouble=NaN]
Setting velocity : -nan(ind)

That window that appears is the GUI for the simulator, simply meant as a debugging tool.  Your robot code should be running, and if you have a SmartDashboard or some println's in your code, they should be getting updated.

Thanks, that works!


Extend execution context

In Integration branch, introduce the notion of execution scope. There shall be 3 execution scopes:

JavaScript
Pyodide
Python

Each execution scope shall handle a dataPoints dictionnary. DataPoints|"dataNodeName"] should contain the latest output from the corresponding dataNode. It might be a Python object for Pyodide or Python dataNodes.

No longuer pertinent, since Taipy coupling


Add validations method.

It is not possible to add another method called 'validations' to this package to write a section to put url validations there.

please give me more explanation about this

https://roocket.ir/discuss/سیستم-Routing-پیشرفته-تر-برای-Expressjs

Router.post("/foo/bar", indexController.index).middleware(Validation());


I would like to support you in this project

I'm Frontend Developer, could i help you?

I'm Frontend Developer, could i help you?

Hiya @zeekias, I will be waiting your pull request.

Am a frontend developer, how can I help?


Writing an Authentication Store in Svelte

title: Writing an Authentication Store in Svelte
slug: svelte-auth
category: tutorial
tags: ['Tech', 'Svelte', auth, AWS]
description: This is my attempt today wrapping an Authentication workflow into a Svelte Store
date: 2020-01-22
Chris Dhanaraj, one half of the AMAZING Toolsday duo with the equally talented Una Kravets, and serial mispronouncer of my name, recently schooled me that Svelte Stores are very similar to React Hooks. I objected at first, but Rich Harris confirmed he was right.
This is my attempt today wrapping an Authentication workflow into a Svelte Store, just like I did with Netlify Identity and React Hooks + Context. This example uses Amplify Auth, but really its going to be the exact same for any auth library/system.
Bottom Line Up Front
You can see my Live Demo here: https://d1tdmagl19vwso.cloudfront.net/
and the source code is at: https://github.com/sw-yx/svelte-amplify-auth-demo

Sequel post: Optimistic, Offline-First Apps with Svelte and Amplify DataStore

Process - setup from Scratch

⚠Note: this is a backward reconstruction of my process, I have not doublechecked that I have accounted for every step of the process if you followed this tutorial from top down. Thinking caps on!

Originally I set out to try out Amplify's new DataStore, but quickly got sidetracked because it requires auth and there is no Amplify Svelte adaptor. So I embarked on a little bit of yak shaving to implement auth in a simple Svelte app.
I think the best way to start is to boot up a standard Svelte app:
npx degit sveltejs/template-webpack svelte-app # must use webpack, Amplify doesnt work with rollup
cd svelte-app
npm install
npm run dev

And then follow some of the steps on Amplify's Auth docs:

https://aws-amplify.github.io/docs/js/authentication#configure-your-app
https://github.com/aws-amplify/amplify-js/blob/master/README.md#2-add-authentication-to-your-app

npm i @aws-amplify/auth @aws-amplify/core aws-amplify
npx amplify-app
amplify init
amplify add auth

You will also need to modify Svelte's root js page to use amplify's generated config files (adapting their Configuration docs):
// src/main.js
import App from './App.svelte';

import Amplify from '@aws-amplify/core';
import Auth from '@aws-amplify/auth';
import aws_exports from './aws-exports';

Amplify.configure(aws_exports);

const app = new App({
  target: document.body,
  props: {
    name: 'world'
  }
});

export default app;

You are now ready to add Svelte stores.
Adding a Svelte Store
Svelte stores are dead easy to use. I gave an Intro to Svelte Stores recently. You could also RTFM but where's the fun in that??
// auth.js
import { writable } from 'svelte/store';

export const store = writable(null); // start with no user

And so we have a two line store we can now use in our app. Let's also create a login component:

Sign In

{JSON.stringify($store, null, 2)}

  <form on:submit|preventDefault={handleSubmit}>

      Username:
      <input type="text" bind:value={username} placeholder="your username"/>

      Password:
      <input type="password" bind:value={password} />

      Email:
      <input type="email" bind:value={email} />

    <button type="submit">Submit</button>
  </form>

Here we are using two way binding and the $ store autosubscribe syntax to make creating the form easy.
Implementing logout is even easier:

You are logged in <button type="button" on:click={logout}>Log Out</button>

    {JSON.stringify($store, null, 2)}

and you can tie them together in your main app:

	{#if $store != null}

	{:else}
		<Login />
	{/if}

Adapting the Auth Library
Now lets actually wire up the submit handler to sign up the user:

Ok, this lets us sign people up but then we also need to confirm the user.  Amplify requires a two step signup process - a sign up and then a confirm step for 2FA verification (in this case, your email, but they also do SMS). Because this is Amplify specific, I'm going to handwave over it and ask you to look at my demo if you need details. It's gonna be dependent on whatever you actually end up using.
Showing Promise State
It's a good user experience to tell the user exactly what's going on with their login, while it happens. Svelte helps with this too with the super handy await syntax. The trick to this is assigning a promise to a variable, and then letting Svelte track/unroll the state of the promise as it goes inflight and results in either success or failure:

{#await promise}

Logging in...

{:catch error}

Something went wrong: {error.message}

{/await}

You can test the rejection case works by assigning
promise = new Promise((yay, nay) => setTimeout(() => nay({message: 'rejected'}), 1000)

Moving Logic into the Store
What we've made isn't really reusable. I like wrapping up reusable behavior in UI-less libraries - this was the original impetus behind hooks, which Merrick Christensen called Headless Components. This way, you get to reuse this code however you like with whatever UI you like. We're also mixing a lot of business logic into our Login component, and it might be nice to split it out a bit.
So lets revisit the store and do the move:
// src/auth.js
import { writable } from 'svelte/store';
import Auth from '@aws-amplify/auth';

export const store = writable(null);
export const logout = () => store.set(null);
export async function signUp(username, password, email) {
  return Auth.signUp(username, password, email)
          .then((data) => void store.set(data));
}
// etc, as needed

Now I can import { logout, signUp } from './auth' anywhere in my app and use this logic!
Draw the rest of the Owl
Do more of the same for signing in an already signed up user.
Bonus: persisting state to localStorage
It can be annoying to lose the logged in user state on refresh. People expect their session to stick around. so you might want to sync up the user object to localStorage:
// src/auth.js
import { writable } from 'svelte/store';
import Auth from '@aws-amplify/auth';

let _user = localStorage.getItem('amplifyUser');
export const store = writable(_user ? JSON.parse(_user) : null);
store.subscribe((value) => {
  if (value) localStorage.setItem('amplifyUser', JSON.stringify(value));
  else localStorage.removeItem('amplifyUser'); // for logout
});

Note some caveats - this may need an isomorphic wrapper if you are doing server side rendering, and that there are some security situations in which you should not store JWT's in localStorage. You can adapt your code to your needs but this will get you started.
That's all I've got - even getting here took longer than I thought! I hope to return to DataStore at some point but figured I would write up what I have.

Sequel post: Optimistic, Offline-First Apps with Svelte and Amplify DataStore

As an enthusiastic Svelte beginner, this was very helpful.  I was trying to figure out what the right way of solving all these problems was, thanks!
I'd love to see an updated version which solves the same set of problems but in a way that makes sense with SvelteKit.
Thanks again!

thanks adam - maybe look at https://vercel.com/templates/svelte/sveltekit-authentication now


Android Screenshots not working API 25

New Issue Checklist

[x] Updated fastlane to the latest version
[x] I read the Contribution Guidelines
[x] I read docs.fastlane.tools
[x] I searched for existing GitHub issues

Issue Description

Fastlane generate_screenshots fails always
The instrument tests navigates the app fine (screen change, button click, etc)
I checked the emulator using adb shell and I cannot find any screenshots being written. This would explain why it cannot read the contents when it tries
Same error on devices: Pixel 2 API 25 and Nexus 7 API 25

Command executed

bundle exec fastlane generate_screenshots

Complete output when running fastlane, including the stack trace and command used

 ➜  SikhLifeAndroid git:(master) ✗ bundle exec fastlane generate_screenshots
[✔] 🚀
+----------------------------------+---------+----------------------------+
|                              Used plugins                               |
+----------------------------------+---------+----------------------------+
| Plugin                           | Version | Action                     |
+----------------------------------+---------+----------------------------+
| fastlane-plugin-versioning_andr  | 0.1.0   | android_get_version_name,  |
| oid                              |         | android_set_version_code,  |
|                                  |         | android_set_version_name,  |
|                                  |         | android_get_version_code   |
+----------------------------------+---------+----------------------------+
19:47:02: --- Step: default_platform ---
19:47:02: ------------------------------
19:47:02: Driving the lane 'android generate_screenshots' 🚀
19:47:02: -----------------------------------------
19:47:02: --- Step: capture_android_screenshots ---
19:47:02: -----------------------------------------
+-----------------------------+-----------------------------------------------------+
|                          Summary for screengrab 2.191.0                           |
+-----------------------------+-----------------------------------------------------+
| locales                     | ["en-US", "pa-IN"]                                  |
| device_type                 | phone                                               |
| clear_previous_screenshots  | true                                                |
| app_apk_path                | app/build/outputs/apk/debug/app-debug.apk           |
| tests_apk_path              | app/build/outputs/apk/androidTest/debug/app-debug-  |
|                             | androidTest.apk                                     |
| tests_package_name          | com.surreal.interactive.sikhLife.test               |
| android_home                | /Users/satindersingh/Library/Android/sdk            |
| output_directory            | fastlane/metadata/android                           |
| skip_open_summary           | false                                               |
| app_package_name            | com.surreal.interactive.sikhLife                    |
| test_instrumentation_runner | androidx.test.runner.AndroidJUnitRunner             |
| ending_locale               | en-US                                               |
| use_adb_root                | false                                               |
| exit_on_test_failure        | true                                                |
| reinstall_app               | false                                               |
| use_timestamp_suffix        | true                                                |
+-----------------------------+-----------------------------------------------------+
19:47:02: Limiting the test classes run by screengrab to just those that generate screenshots can make runs faster.
19:47:02: Consider using the :use_tests_in_classes or :use_tests_in_packages option, and organize your tests accordingly.
19:47:02: Clearing phoneScreenshots within fastlane/metadata/android
19:47:02: $ /Users/satindersingh/Library/Android/sdk/platform-tools/adb -s emulator-5554 shell echo $EXTERNAL_STORAGE
19:47:02: ▸ /sdcard
19:47:02: $ /Users/satindersingh/Library/Android/sdk/platform-tools/adb -s emulator-5554 shell echo $ANDROID_DATA
19:47:02: ▸ /data
19:47:02: Cleaning screenshots on device
ls: /sdcard/com.surreal.interactive.sikhLife/screengrab/en-US/images/screenshots: No such file or directory
[19:47:03]: Exit status: 1
ls: /sdcard/Android/data/com.surreal.interactive.sikhLife/files/screengrab/en-US/images/screenshots: No such file or directory
[19:47:03]: Exit status: 1
ls: /sdcard/com.surreal.interactive.sikhLife/screengrab/pa-IN/images/screenshots: No such file or directory
[19:47:03]: Exit status: 1
ls: /sdcard/Android/data/com.surreal.interactive.sikhLife/files/screengrab/pa-IN/images/screenshots: No such file or directory
[19:47:03]: Exit status: 1
ls: /data/user/0/com.surreal.interactive.sikhLife/files/com.surreal.interactive.sikhLife/screengrab/en-US/images/screenshots: No such file or directory
[19:47:03]: Exit status: 1
ls: /data/data/com.surreal.interactive.sikhLife/files/com.surreal.interactive.sikhLife/screengrab/en-US/images/screenshots: No such file or directory
[19:47:03]: Exit status: 1
ls: /data/data/com.surreal.interactive.sikhLife/app_screengrab/en-US/images/screenshots: No such file or directory
[19:47:03]: Exit status: 1
ls: /data/data/com.surreal.interactive.sikhLife/screengrab/en-US/images/screenshots: No such file or directory
[19:47:03]: Exit status: 1
ls: /data/user/0/com.surreal.interactive.sikhLife/files/com.surreal.interactive.sikhLife/screengrab/pa-IN/images/screenshots: No such file or directory
[19:47:03]: Exit status: 1
ls: /data/data/com.surreal.interactive.sikhLife/files/com.surreal.interactive.sikhLife/screengrab/pa-IN/images/screenshots: No such file or directory
[19:47:03]: Exit status: 1
ls: /data/data/com.surreal.interactive.sikhLife/app_screengrab/pa-IN/images/screenshots: No such file or directory
[19:47:03]: Exit status: 1
ls: /data/data/com.surreal.interactive.sikhLife/screengrab/pa-IN/images/screenshots: No such file or directory
[19:47:03]: Exit status: 1
[19:47:03]: $ /Users/satindersingh/Library/Android/sdk/platform-tools/adb -s emulator-5554 shell getprop ro.build.version.sdk
[19:47:03]: ▸ 25
[19:47:03]: Installing app APK
[19:47:03]: $ /Users/satindersingh/Library/Android/sdk/platform-tools/adb -s emulator-5554 install -t -r app/build/outputs/apk/debug/app-debug.apk
[19:47:03]: ▸ Performing Streamed Install
[19:47:07]: ▸ Success
[19:47:07]: Installing tests APK
[19:47:07]: $ /Users/satindersingh/Library/Android/sdk/platform-tools/adb -s emulator-5554 install -t -r app/build/outputs/apk/androidTest/debug/app-debug-androidTest.apk
[19:47:07]: ▸ Performing Streamed Install
[19:47:08]: ▸ Success
[19:47:08]: Granting the permission necessary to change locales on the device
[19:47:08]: $ /Users/satindersingh/Library/Android/sdk/platform-tools/adb -s emulator-5554 shell pm grant com.surreal.interactive.sikhLife android.permission.CHANGE_CONFIGURATION
[19:47:09]: Granting the permissions necessary to access device external storage
[19:47:09]: $ /Users/satindersingh/Library/Android/sdk/platform-tools/adb -s emulator-5554 shell pm grant com.surreal.interactive.sikhLife android.permission.WRITE_EXTERNAL_STORAGE
[19:47:09]: $ /Users/satindersingh/Library/Android/sdk/platform-tools/adb -s emulator-5554 shell pm grant com.surreal.interactive.sikhLife android.permission.READ_EXTERNAL_STORAGE
[19:47:09]: Enabling clean status bar
[19:47:09]: $ /Users/satindersingh/Library/Android/sdk/platform-tools/adb -s emulator-5554 shell pm grant com.surreal.interactive.sikhLife android.permission.DUMP
[19:47:09]: $ /Users/satindersingh/Library/Android/sdk/platform-tools/adb -s emulator-5554 shell settings put global sysui_demo_allowed 1
[19:47:09]: $ /Users/satindersingh/Library/Android/sdk/platform-tools/adb -s emulator-5554 shell am force-stop com.surreal.interactive.sikhLife.test
[19:47:10]: $ /Users/satindersingh/Library/Android/sdk/platform-tools/adb -s emulator-5554 shell am force-stop com.surreal.interactive.sikhLife
[19:47:10]: Running tests for locale: en-US
[19:47:10]: $ /Users/satindersingh/Library/Android/sdk/platform-tools/adb -s emulator-5554 shell am instrument --no-window-animation -w
-e testLocale en-US
-e appendTimestamp true
com.surreal.interactive.sikhLife.test/androidx.test.runner.AndroidJUnitRunner
[19:47:56]: ▸ com.surreal.interactive.sikhLife.MainActivityTest:.
[19:47:56]: ▸ Time: 45.245
[19:47:56]: ▸ OK (1 test)
[19:47:56]: Pulling captured screenshots for locale en-US from the device
[19:47:56]: $ /Users/satindersingh/Library/Android/sdk/platform-tools/adb -s emulator-5554 shell echo $EXTERNAL_STORAGE
[19:47:56]: ▸ /sdcard
[19:47:56]: $ /Users/satindersingh/Library/Android/sdk/platform-tools/adb -s emulator-5554 shell echo $ANDROID_DATA
[19:47:56]: ▸ /data
ls: /sdcard/com.surreal.interactive.sikhLife/screengrab/en-US/images/screenshots: No such file or directory
[19:47:56]: Exit status: 1
ls: /sdcard/Android/data/com.surreal.interactive.sikhLife/files/screengrab/en-US/images/screenshots: No such file or directory
[19:47:56]: Exit status: 1
ls: /data/user/0/com.surreal.interactive.sikhLife/files/com.surreal.interactive.sikhLife/screengrab/en-US/images/screenshots: No such file or directory
[19:47:56]: Exit status: 1
ls: /data/data/com.surreal.interactive.sikhLife/files/com.surreal.interactive.sikhLife/screengrab/en-US/images/screenshots: No such file or directory
[19:47:56]: Exit status: 1
ls: /data/data/com.surreal.interactive.sikhLife/app_screengrab/en-US/images/screenshots: No such file or directory
[19:47:56]: Exit status: 1
ls: /data/data/com.surreal.interactive.sikhLife/screengrab/en-US/images/screenshots: No such file or directory
[19:47:57]: Exit status: 1
[19:47:57]: Make sure you've used Screengrab.screenshot() in your tests and that your expected tests are being run.
+------------------+------------------------------+
|                  Lane Context                   |
+------------------+------------------------------+
| DEFAULT_PLATFORM | android                      |
| PLATFORM_NAME    | android                      |
| LANE_NAME        | android generate_screenshots |
+------------------+------------------------------+
[19:47:57]: No screenshots were detected 📷❌
+------+-----------------------------+-------------+
|                 fastlane summary                 |
+------+-----------------------------+-------------+
| Step | Action                      | Time (in s) |
+------+-----------------------------+-------------+
| 1    | default_platform            | 0           |
| 💥   | capture_android_screenshots | 54          |
+------+-----------------------------+-------------+
[19:47:57]: fastlane finished with errors
[!] No screenshots were detected 📷❌

Environment

 ✅ fastlane environment ✅
Stack

Key
Value

OS
11.5.1

Ruby
2.7.0

Bundler?
true

Git
git version 2.29.2

Installation Source
~/.rvm/gems/ruby-2.7.0/bin/fastlane

Host
macOS 11.5.1 (20G80)

Ruby Lib Dir
~/.rvm/rubies/ruby-2.7.0/lib

OpenSSL Version
OpenSSL 1.1.1g  21 Apr 2020

Is contained
false

Is homebrew
false

Is installed via Fabric.app
false

Xcode Path
/Applications/Xcode.app/Contents/Developer/

Xcode Version
12.5.1

Swift Version
5.4.2

System Locale

Variable
Value

LANG
en_US.UTF-8
✅

LC_ALL

LANGUAGE

fastlane files:
`./fastlane/Fastfile`
# This file contains the fastlane.tools configuration
# You can find the documentation at https://docs.fastlane.tools
#
# For a list of all available actions, check out
#
#     https://docs.fastlane.tools/actions
#
# For a list of all available plugins, check out
#
#     https://docs.fastlane.tools/plugins/available-plugins
#

# Uncomment the line if you want fastlane to automatically update itself
# update_fastlane

default_platform(:android)

platform :android do
  desc "Screenshot with Debug Build Debug"
  lane :build_for_screengrab do
    if prompt(text: "Clean Build?", boolean: true)
      gradle(task: 'clean')
      build_android_app(task: 'assemble', build_type: 'Debug')
      build_android_app(task: 'assemble', build_type: 'AndroidTest')
    end
    generate_screenshots
  end

  desc "Generates AppStore Screenshots"
  lane :generate_screenshots do |options|
    capture_android_screenshots(
      locales: ["en-US", "pa-IN"],
      device_type: "phone",
      clear_previous_screenshots: true,
      app_apk_path: "app/build/outputs/apk/debug/app-debug.apk",
      tests_apk_path: "app/build/outputs/apk/androidTest/debug/app-debug-androidTest.apk"
    )
  end
end

`./fastlane/Appfile`
json_key_file("fastlane-key.json") # Path to the json secret file - Follow https://docs.fastlane.tools/actions/supply/#setup to get one
package_name("com.surreal.interactive.sikhLife") # e.g. com.krausefx.app

fastlane gems

Gem
Version
Update-Status

fastlane
2.191.0
✅ Up-To-Date

Loaded fastlane plugins:

Plugin
Version
Update-Status

fastlane-plugin-versioning_android
0.1.0
✅ Up-To-Date

Loaded gems

Gem
Version

did_you_mean
1.4.0

executable-hooks
1.6.0

bundler-unload
1.0.2

rubygems-bundler
1.4.5

bundler
2.1.4

rake
13.0.6

CFPropertyList
3.0.3

public_suffix
4.0.6

addressable
2.8.0

artifactory
3.0.15

atomos
0.1.3

aws-eventstream
1.1.1

aws-partitions
1.484.0

aws-sigv4
1.2.4

jmespath
1.4.0

aws-sdk-core
3.119.0

aws-sdk-kms
1.46.0

aws-sdk-s3
1.98.0

babosa
1.0.4

claide
1.0.3

colored
1.2

colored2
3.1.2

highline
2.0.3

commander
4.6.0

declarative
0.0.20

digest-crc
0.6.4

unf_ext
<IP_ADDRESS>

unf
0.1.4

domain_name
0.5.20190701

dotenv
2.7.6

emoji_regex
3.2.2

excon
0.85.0

faraday-em_http
1.0.0

faraday-em_synchrony
1.0.0

faraday-excon
1.1.0

faraday-httpclient
1.0.1

faraday-net_http
1.0.1

faraday-net_http_persistent
1.2.0

faraday-patron
1.0.0

faraday-rack
1.0.0

multipart-post
2.0.0

ruby2_keywords
0.0.5

faraday
1.6.0

http-cookie
1.0.4

faraday-cookie_jar
0.0.7

faraday_middleware
1.1.0

fastimage
2.2.4

gh_inspector
1.1.3

jwt
2.2.3

memoist
0.16.2

multi_json
1.15.0

os
1.1.1

signet
0.15.0

googleauth
0.17.0

httpclient
2.8.3

mini_mime
1.1.0

trailblazer-option
0.1.1

uber
0.1.0

representable
3.1.1

retriable
3.1.2

rexml
3.2.5

webrick
1.7.0

google-apis-core
0.4.1

google-apis-androidpublisher_v3
0.10.0

google-apis-playcustomapp_v1
0.5.0

google-apis-iamcredentials_v1
0.6.0

google-apis-storage_v1
0.6.0

google-cloud-env
1.5.0

google-cloud-errors
1.1.0

google-cloud-core
1.6.0

google-cloud-storage
1.34.1

json
2.5.1

mini_magick
4.11.0

naturally
2.2.1

plist
3.6.0

rubyzip
2.3.2

security
0.1.3

simctl
1.6.8

terminal-notifier
2.0.0

unicode-display_width
1.7.0

terminal-table
1.8.0

tty-screen
0.8.1

tty-cursor
0.7.1

tty-spinner
0.9.3

word_wrap
1.0.0

nanaimo
0.3.0

xcodeproj
1.20.0

rouge
2.0.7

xcpretty
0.3.0

xcpretty-travis-formatter
1.0.1

fastlane-plugin-versioning_android
0.1.0

generated on: 2021-08-08

Thanks for sharing this information.


Fix description of snake/camel case in template.

GOV.UK Template used snake case; GOV.UK Frontend uses camel case. So this sentence is backwards.

You can preview this change here:
Built with commit d52c7f425a96c9584654d41afd396da2ac44301d
https://deploy-preview-405--govuk-design-system-preview.netlify.com


--upload-only flag seems to be ignored for dev sync

What happened?
When running dev sync --config=./devspace.yaml --upload-only=true, files from the pod are still downloaded prior to uploads being processed. I've also attempted running using --upload-only without the assignment, same outcome.
What did you expect to happen instead?
Do not download any files if that flag is specified.
How can we reproduce the bug? (as minimally and precisely as possible)

Run devspace deploy on any project.
(Re)move a file locally that matches a sync rule.
Start devspace sync --config=./devspace.yaml --upload-only=true from the root of your project.
Note the file (re)moved in step 2 is downloaded.

Local Environment:

DevSpace Version: 4.6.0
Operating System: Windows (WSL)
Deployment method: helm

Kubernetes Cluster:

Cloud Provider: google
Kubernetes Version:

Client: v1.15.5
Server v1.14.8-gke.33

Anything else we need to know?
Here's the relevant config section:
dev:
  sync:
  - imageName: plaidcloud/superset
    labelSelector:
      plaid: superset
    containerName: "superset"
    localSubPath: ./superset
    containerPath: /app/superset
  - imageName: plaidcloud/superset-node
    labelSelector:
      plaid: superset
    containerName: "node"
    localSubPath: ./superset-frontend/src
    containerPath: /app/superset-frontend/src

Here's a screenshot of the output:

And another for the second rule:

/kind bug

@gbates101 Thanks for reporting this.
--upload-only should probably automatically set --initial-sync=mirrorLocal. Otherwise this behavior is very unexpected. What do you think, @FabianKramm?

@gbates101 yes currently the flags --upload-only and --download-only are not respected when using in conjunction with --config. As a workaround you can either set dev.sync.disableDownload to true or use the devspace sync command without the --config

@FabianKramm Ah, good to know. dev.sync.disableDownload is exactly what I'm looking for.

implemented in v4.8.0


Add coverage guided fuzzing

It would be really nice if we could have coverage guided fuzzing.

For each input, record the code coverage from that input.
If the input exercises new code, add it to the corpus.

We'll still want random fuzzing, but this will help us make sure we at least cover as many error paths as possible.
Originally posted by @Stebalien in https://github.com/filecoin-project/go-f3/issues/219#issuecomment-2111064226

We should first add test coverage to CI! @masih would you look into this?
I predict this will show some holes in our unit testing at the level of explicitly testing message sequences given to the participant. This is a gap between the simple data structure unit tests and sim-level exercises we currently have.

Ah, actually, go fuzzing already works this way. It just stores the entries in $(go env GOCACHE)/fuzz. We need to upload this somewhere when the test finishes (success or failure) and download it afterwards.
We could use caching but... ideally we'd push it to a git repo somewhere. @Kubuxu should be able to help here.

We should first add test coverage to CI! @masih would you look into this?

Will do; that should be quick.

ideally we'd push it to a git repo somewhere

I would just push those to testdata next to the tests. That would be easier; no?

Coverage reporting is added here

It might be more optimal to move away from seed fuzzing and instead fuzze an array of latencies or something similar, but seed-based fuzzing is a great initial step.
Giving more precise control over latencies to the fuzzer would make it more expressive, allowing it to test more scenarios and allow it to make smaller changes to the scenario as it evolves.

We could use caching but... ideally we'd push it to a git repo somewhere. @Kubuxu should be able to help here.

In my opinion, we should minimize the fuzz corpus in this repo. The separate repo works but is a bit hacky, and I've done it in the past mostly because the fuzzer used was AFL, and I was fuzzing complex scenarios with large churn.

Hmm, looks like go doesn't support corpus minimization right now :/

I will close this as Golang's fuzzing is coverage-guided. We might want to open a new issue for a more advanced fuzzing strategy (message reordering).


Demo of searching using Google Maps

Jira ticket URL
https://dfedigital.atlassian.net/browse/TEVA-1495
Explanation
This is a demo of searching by map (a spike).
I couldn't get the review app to work so I've opened up a route to my development server here: http://1c264c905af8.ngrok.io/
This is a mock-up to demonstrate the possibilities that Google Maps offers for enhancing search. It's an example, to spark ideas and be provocative food for thought, rather than being a full-fledged suggestion based on any user research (I am not a UX Designer).
That said, given the importance of location to users, I think it's a safe bet that it's useful to visualize both the search area and the results' locations.
For example, I discovered that if I search in Oxford, I can instantly see that (for whatever reason) the polygon we use is excluding central and west Oxford.
Features to play with:

Visualize searches that use polygons
Edit the polygon and search using the polygon
Visualize the bounds of a search by radius
Drag the centerpoint of the radius around the map to search from a new centerpoint

This map-search might be made redundant by a commute time widget. Or maybe it could be evolved to show commute time information in some way. This is mainly to demo what kinds of possibilities there are to combine maps and search.
Screenshots of UI changes:
Visualize a polygon:

Make it editable (reduce number of points):

Drag its points and search from there:

Visualize a radius-based search:

Dragging the points is cumbersome (especially on mobile) - we could also have the user click to create points or drag a lasso

Closing. Branches can be restored from closed PRs.


[Paper] Regularizing Class-wise Predictions via Self-knowledge Distillation implemented

@Het-Shah Updated with the changes you suggested. Kindly check.


avoid RevWalk.fileHistoryWalk(*)

replace RevWalk.fileHistoryWalk(*) calls with own implementation.
RevWalk.fileHistoryWalk(*) has several issues, see https://github.com/nodegit/nodegit/issues/1575#issuecomment-435936688.
most importantly it blocks updating the nodegit dependency to 0.23.0, see https://github.com/nodegit/nodegit/issues/1575#issuecomment-433865536 and https://github.com/adobe/git-server/issues/13#issuecomment-433998137.

blocks https://github.com/adobe/git-server/issues/13

fixed in 0b26336ddf275b9499869dd51e93b1375f20756f


Can't create new bins

When I try to create a new bin, I'm presented with the following page:

I've been working around this since last night by just modifying existing bins, but it's a bit annoying since now the list won't separate them.
Thanks for this awesome tool, by the way! I use it almost daily, even when I'm not doing web development work (it's really handy to quickly prototype an algorithm).

This should have been fixed a little whilst ago. Happy to reopen if you're still seeing it.

Works now, thanks!


vs-select inside vs-prompt not showing items

When you insert a vs-select inside a vs-prompt all items are showing below the prompt. Should be a matter of z-index. It is possible to correct this?

same problem

the error was fixed thank you very much for the contribution


TIGER / NYC data disagreeing on street name

i readed the https://github.com/osmlab/nycbuildings/wiki/Common-issues, but i can't find solution for this. when i have validated,
http://www.openstreetmap.org/way/5711983/history
Red rows
the buildins has tag addr:street: Fort Hill Circle but Tiger road called   name: Fort Hill Place,  could i rename the building ? or how could i work in this case?
Green row:
it's possible to add tag addr:street: Fort Hill Circle on the build if it not has this tag

@lxbarth : I checked those  issues  but there are  not  much differences between New and misaligned TIGER roads and TIGER 2012.
However  I fixed  a error:

Fixed way on comment https://github.com/osmlab/nycbuildings/issues/121#issuecomment-36366039

And the other was fixed by other users:

Fixed way on comment https://github.com/osmlab/nycbuildings/issues/121#issuecomment-36398842

Fixed way on comment https://github.com/osmlab/nycbuildings/issues/121#issuecomment-36378343

Would be good that someone who know those places  can fix  the other errors.

Would be good that someone who know those places can fix the other errors.

Can you open notes for them?

Can you open notes for them?

I've opened notes for each error.
http://www.openstreetmap.org/note/340719
http://www.openstreetmap.org/note/340721
http://www.openstreetmap.org/note/340723
http://www.openstreetmap.org/note/340727
http://www.openstreetmap.org/note/340729

@Rub21 - next actions here?

@lxbarth , there are not other action here,  Close here.


Feature: add support for vultr

(removing the template as it didn't seem applicable for this issue)
would you consider adding support for other providers like vultr and linode/akamai? thank you :)

We'll work on this on a best-effort basis. Voting on the issue helps us with prioritization.


Button breakpoints consistent across site and chapters 2+ hidden behind 'coming soon'

Closes #176 and #234
All buttons now have the same breakpoint across the site, I chose a medium (768px) breakpoint.
Below demonstrates what the 2nd chapter will look like after lessons have been added but the chapter remains 'locked'

First attempt at squashing my commits :sweat_smile:

@ecurrencyhodler feel free to merge after tack


[4.0.0-rc05] Repeat mode does not work on iOS

Describe the Bug
Repeat mode causes very strange and inconsistent behavior on iOS.
On the emulator, everything works as expected: A track finishes and then restarts as expected.
On a real device however, this does not happen. Once the track is finished, instead of repeating the track the player goes into a paused state. When that happens and I switch the track, the state changes but sometimes the progress just doesn't get updated (though this part is not reproduceible consistently).
I also experience progress updates getting fired with position set to below zero (e.g. -0.51), but I figure that is a different issue.
I opened https://github.com/doublesymmetry/react-native-track-player/issues/1995 back in April, but that was for 4.0.0-rc05. There I incorrectly stated, that the issue does not appear anymore in rc05. It does appear, but I was working with an emulator where is works as expected.
Steps To Reproduce
Set the player to RepeatMode.Track on a real iOS device.
Code To Reproduce
await TrackPlayer.setRepeatMode(RepeatMode.Track)
Replicable on Example App?
Yes.
Environment Info:
System:
    OS: macOS 13.2.1
    CPU: (12) arm64 Apple M2 Pro
    Memory: 255.80 MB / 32.00 GB
    Shell: 5.8.1 - /bin/zsh
  Binaries:
    Node: 16.10.0 - ~/.nvm/versions/node/v16.10.0/bin/node
    Yarn: 1.22.19 - ~/.nvm/versions/node/v16.10.0/bin/yarn
    npm: 7.24.0 - ~/.nvm/versions/node/v16.10.0/bin/npm
    Watchman: 2<IP_ADDRESS> - /opt/homebrew/bin/watchman
  Managers:
    CocoaPods: 1.12.0 - /usr/local/bin/pod
  SDKs:
    iOS SDK:
      Platforms: DriverKit 22.4, iOS 16.4, macOS 13.3, tvOS 16.4, watchOS 9.4
    Android SDK:
      Android NDK: 25.2.9519653
  IDEs:
    Android Studio: Not Found
    Xcode: 14.3/14E222b - /usr/bin/xcodebuild
  Languages:
    Java: 16.0.2 - /usr/bin/javac
  npmPackages:
    @react-native-community/cli: Not Found
    react: 18.2.0 => 18.2.0
    react-native: 0.71.7 => 0.71.7
    react-native-macos: Not Found
  npmGlobalPackages:
    *react-native*: Not Found

Paste the exact react-native-track-player version you are using
4.0.0-rc5
Real device? Or simulator?
Real device
What OS are you running?
iOS 16.4.1
How I can Help
What can you do to help resolve this?
If you point me in the right direction, I'll try my best but I only have very limited swift experience.

Hey @dcvz, we've recently did some tests on version 4.0.0-rc06 and, although the issue doesn't occur consistently, we still encounter it from time to time. Unfortunately, we haven't identified a reliable way to reproduce it. Approximately every 5-10 attempts, the player pauses, and the playback state transitions from loading to paused to ready.
Additionally, we've observed a separate issue on iOS, where progress updates occasionally show negative values (e.g., -0.286526) after repeating a track. Upon restarting, the progress update is called multiple times in quick succession, and the sequence looks like this (example): 0, 0, 0, 0, -0.22, -0.22, 1. I'm not sure if this is directly related to the repeat mode issue, but I thought I'd share it as it may provide some useful insights.

@TobiDevloft @jr00n I added a fix/workaround in https://github.com/doublesymmetry/SwiftAudioEx/pull/62 - if you have time and desire you can test it 👀

@kirillzyusko @dcvz This seems to have fixed it! Thank you so much for fixing this, you've saved me a bunch of headaches haha


Add support to turn on experiments in tests

For Native Notebooks, I'm updating package.json & then updating the settings.json to ensure the extension is running under NativeNotebooks experiment.
Would be bettter to add an environment variable, easier to write tests in the future.
E.g. set environment varialbe JVSC_EXPERIMENTS_OPTED_INTO would be a delimited list of experiments.
Didn't want to make this change in the core repo, we should make this now, the NB test are hacky (updating package.json & settings.json).

Doing this here https://github.com/microsoft/vscode-jupyter/pull/443

Easy, just update the json file today and update env variable.
Done


flutter_markdown blockquoteDecoration does not respect dark theme

Hello
blockquote background does not respect dark theme. It has hardcoded color:  Colors.blue.shade100
see https://github.com/flutter/packages/blob/master/packages/flutter_markdown/lib/src/style_sheet.dart
lines 118-121:
      blockquoteDecoration: BoxDecoration(
        color: Colors.blue.shade100,
        borderRadius: BorderRadius.circular(2.0),
      ),

I guess code to reproduce the issue and further comments are not needed because everything is obvious from the code.
Even my flutter doctor doesn't matter because the code block above is from current master branch.

flutter doctor -v

[✓] Flutter (Channel master, 2.3.0-1.0.pre.242, on Mac OS X 10.15.4 19E2269
    darwin-x64, locale en-GB)
    • Flutter version 2.3.0-1.0.pre.242 at
      /Users/dhs/documents/fluttersdk/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 3ab799bbc9 (2 hours ago), 2021-05-06 19:49:02 -0700
    • Engine revision f57e986aa8
    • Dart version 2.14.0 (build 2.14.0-74.0.dev)

[!] Xcode - develop for iOS and macOS
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 12.3, Build version 12C33
    ! CocoaPods 1.9.3 out of date (1.10.0 is recommended).
        CocoaPods is used to retrieve the iOS and macOS platform side's plugin
        code that responds to your plugin usage on the Dart side.
        Without CocoaPods, plugins will not work on iOS or macOS.
        For more info, see https://flutter.dev/platform-plugins
      To upgrade see
      https://guides.cocoapods.org/using/getting-started.html#installation for
      instructions.

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] VS Code (version 1.55.2)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.21.0

[✓] Connected device (2 available)
    • macOS (desktop) • macos  • darwin-x64     • Mac OS X 10.15.4 19E2269
      darwin-x64
    • Chrome (web)    • chrome • web-javascript • Google Chrome 90.0.4430.93

! Doctor found issues in 1 category.
dhs@Dhss-MacBook-Pro ~ %

In dark mode, light blue background and white foreground style is somehow hard to read.

@antonio-gravity Sure (not that after two years it could be topical but others might still need it, considering that it's still not fixed, even if it's a no-brainer):
  Markdown(
    styleSheet: MarkdownStyleSheet.fromTheme(Theme.of(context)).copyWith(
      blockquoteDecoration: BoxDecoration(
        color: Theme.of(context).colorScheme.secondaryContainer,
        borderRadius: BorderRadius.circular(2.0),
      ),
    ),

Actually, that's exactly what should be done in the original code...

@antonio-gravity Sure (not that after two years it could be topical but others might still need it, considering that it's still not fixed, even if it's a no-brainer):
  Markdown(
    styleSheet: MarkdownStyleSheet.fromTheme(Theme.of(context)).copyWith(
      blockquoteDecoration: BoxDecoration(
        color: Theme.of(context).colorScheme.secondaryContainer,
        borderRadius: BorderRadius.circular(2.0),
      ),
    ),

Actually, that's exactly what should be done in the original code...

Right, but I would prefer colorScheme.surfaceContainer or at least colorScheme.surface.


Change manual link to be visible to the new user

Description
The manual link is not visible to the new user, while the main purpose of the manual is to help the new user get started.

It's only shown to already-signed users.

Verified,
Devnet, d9d6f02
Manual link is now displayed in both tabs.

Verified:

Devnet
ec2ed3d


Conceptual issue: how to handle child components with vue-apollo

Hey there folks.
I am struggling to find a nice architecture with vue-apollo.
Currently I have a setup like this:
App.vue
Calendar.vue <-- has apollo queries, pushes to Vuex store
Event.vue <-- uses Vuex getters to use data pushed by Calendar.vue

Now, this works fine if your user goes the following way:

initializes App
uses /calendar route
this populates Vuex store
uses /calendar/event/:id route
accesses previously initialised Vuex Store 🔢

Now comes the fun. Event.vue is a child component of Calendar.vue, but I wouldn't want to render it via <render-view> inside my Calendar, for obvious reasons.
This means, that when I access the route directly, it will result in an empty store.
Usually one would fall back either to the created hook, or navigation guards, and simply re-populate the Store if it is empty.
This however is not easily possible with VueApollo. I tried to do the following:
import Vue from 'vue'
import Calendar from ' ./Calendar.vue'

export default {
    created() {
        if (!this.$store.getters.events.length) {
           let CalendarComponent = Vue.extend(Calendar)
           let calendar = new CalendarComponent()
           calendar.$apollo.queries.events.refetch() # <- here comes the fun. Events query does not exist
       }
       this.event = this.$store.getters.eventById(this.$route.params.id) // needs a pre-populated list, obviously
    }
}

How could one achieve this sanely with VueApollo? I've been trying various other ways, but the only thing I could come up with is Mixins. But. This would be essentially bad because

one would mix up the original component that is designed to do the query
this effectively destroys all decoupling
doing things like reactive queries with mixins may become an unpredictable mess
(...) the list can go on for a while

I hope somebody has an idea how this could be achieved.
Regards, Fohlen

What about this:

Don't use vuex for this
Use the same GraphQL query on multiple components (Apollo is smart)

@Akryum well this does of course work but leads to non-DRY code and overly complicated structure. I'll close it for now because it is of no more interest to me but generally there could be some work done.


Enhancement:  Flag instructions for switching on Exception handling

There are C++ classes in cpp_utils that require exception handling to be enabled.  If not, let us detect this and log an error that they must be turned on.

The definition in make menuconfig appears to be "CONFIG_CXX_EXCEPTIONS" and if set to 1 then it is on.  We have some options for logging messages including:
#pragma message string

for example
#pragma message "Hello World"

or with the C Preprocessor we have
#error message

The one I think we will use is:
#if CONFIG_CXX_EXCEPTIONS != 1
#error ...
#endif

Code changes made


Opening a FStar file raises an exception

On my Macbook, opening any .fst file using 'vim' gives this error.
Error detected while processing /Users/anithagollamudi/.vim/bundle/VimFStar/ftplugin/fstar.vim:
line   47:
Traceback (most recent call last):
  File "<string>", line 1, in <module>
  File "/Users/anithagollamudi/.vim/bundle/VimFStar/ftplugin/fstar-inter.py", line 62, in fstar_init
    fst=Popen([fstarpath,'--in'],stdin=PIPE, stdout=PIPE,bufsize=1,close_fds=ON_POSIX)
  File "/usr/lib/python2.7/subprocess.py", line 710, in __init__
    errread, errwrite)
  File "/usr/lib/python2.7/subprocess.py", line 1335, in _execute_child
    raise child_exception
OSError: [Errno 8] Exec format error

Yeah I use vim but I don't use this plugin. As far as I know, I never could get it to work reliably...

@ngrimm Any interest in reviving the vim plugin?


Separate Admin Panel for "Owner" of Events

That's for the Breeze Club heads
Each Event will be given an owner. For example all the quizzing events will have FACTion as the owner. By logging into their owner account, FACTion can see the list with details of everyone whose registered for each of their events.

Hey.
We want to create an Admin Panel here. Using Angular. Check http://startangular.com/product/rdash-angularjs/
Need to find a way to connect this to MongoDB database so that we can pull all the emails registered for the event.

[  ] Create an admin dashboard. http://startangular.com/product/rdash-angularjs/
[  ] Connect to MongoDB  to get emails


docs(mocha-webpack): replace mocha-webpack by mochapack fork

Hey!
This PR fix current documentation about testing with webpack + mocha.
As mocha-webpack seems not maintained anymore the current guide doesn't works anymore. A fork named mochapack fix the issue, so I fixed the doc accordingly.

I arrived here after trying to follow the guide and use mocha-webpack. It looks like mochapack has been updated since this ticket.

I can report that I was able to run vue-test-utils successfully with webpack4 and mochapack.

The staleness of mocha-webpack was the reason why we didn't include it in @quasar/testing. Will look into this new repo and report back.

+1 for moving to mochapack. I went down the same route of broken tests and finally discovering mochapack.

OK, it's been a few months and mochpack is being actively maintained.
Can you resolve the conflicts in this PR @alexbonhomme?

Sure, I'll have a look on it quickly

Thank you for handling this! 🎉


feat: avm/res/container-service/managed-cluster Update parameter's description which is in preview feature.

Description

Fixes https://github.com/Azure/bicep-registry-modules/pull/3104#issuecomment-2438488253
Pipeline Reference

Pipeline

Type of Change

[ ] Update to CI Environment or utilities (Non-module affecting changes)
[x] Azure Verified Module updates:

[ ] Bugfix containing backwards-compatible bug fixes, and I have NOT bumped the MAJOR or MINOR version in version.json:

[ ] Someone has opened a bug report issue, and I have included "Closes #{bug_report_issue_number}" in the PR description.
[ ] The bug was found by the module author, and no one has opened an issue to report it yet.

[ ] Feature update backwards compatible feature updates, and I have bumped the MINOR version in version.json.
[ ] Breaking changes and I have bumped the MAJOR version in version.json.
[ ] Update to documentation

Checklist

[x] I'm sure there are no other open Pull Requests for the same update/change
[x] I have run Set-AVMModule locally to generate the supporting module files.
[x] My corresponding pipelines / checks run clean and green without any errors or warnings

@AlexanderSehr, @jongio for notification.

Hey @zedy-wj ,
Firstly, thanks for your work on this PR!
We have made some changes to the AVM CI, detailed below, which means we need you to update your fork to pull in these latest changes and re-run your tests to show they still are passing prior to approving and merging this PR, as we don't and it fails once merged the publishing of your module will fail and will be blocked going forward until the test pass again via additional PRs.
Changes to CI That Have Been Made That You Need To Take Action On

https://github.com/Azure/bicep-registry-modules/pull/3745

Adds WAF Security PSRule Checks using this custom baseline of rules (/avm/utilities/pipelines/staticValidation/psrule/.ps-rule/cb-waf-security.Rule.yaml)
Action Required By You:

Ingest/pull-in these changes into your PR branch and re-run your tests to ensure they pass

If any issues with the rules and you think it should apply, please ping/reach out to the core team

Any questions reach out to the AVM Core Team by tagging us in your PR here or internally via Teams
Thanks
Jack (AVM Core Team)

Hey @zedy-wj ,
Firstly, thanks for your work on this PR!
We have made some changes to the AVM CI, detailed below, which means we need you to update your fork to pull in these latest changes and re-run your tests to show they still are passing prior to approving and merging this PR, as we don't and it fails once merged the publishing of your module will fail and will be blocked going forward until the test pass again via additional PRs.
Changes to CI That Have Been Made That You Need To Take Action On

feat: Add WAF Security PS Rule Config #3745

Adds WAF Security PSRule Checks using this custom baseline of rules (/avm/utilities/pipelines/staticValidation/psrule/.ps-rule/cb-waf-security.Rule.yaml)

Action Required By You:

Ingest/pull-in these changes into your PR branch and re-run your tests to ensure they pass

If any issues with the rules and you think it should apply, please ping/reach out to the core team

Any questions reach out to the AVM Core Team by tagging us in your PR here or internally via Teams
Thanks
Jack (AVM Core Team)

Updated. The rerun tests have all passed.

@rajeshkamal5050 Could you please contact Jongio and Wallace to review this PR? Here are the comments they left.

For reference, this is why this PR is so important

@zedy-wj please resolve the conflicts be updating bicep cli and run the SetAvmModule script again.
Thanks a lot.

Closing this PR in favor of https://github.com/Azure/bicep-registry-modules/pull/3920


Add new actions to confirm and compare test behaviour from pip install. / pip install -e .

Use GitHub actions to confirm the repo test / package structure work for both installed and local testing

Done
Test added as part of workflow actions


Add mage target: test:unitfailfast (Side-Effect: Exposes data races in unit tests)

Why? Two reasons:

To help debugging data races in our tests (hopefully not in the tested code) because the unit tests flake on data races way more often with -failfast than without.
It is convenient for local development not having to search for the failed test logs.

Signed-off-by: Josh Gwosdz<EMAIL_ADDRESS>
Summary

Change Type

Check List Before Merging

[ ] This PR passes all pre-commit hook validations.
[ ] This PR is fully tested and regression tests are included.
[ ] Relevant documentation has been updated.

Additional Information

/hold


Problem with prisma generate

Hi, i have this problem when a run "docker-compose up -d"
 ERROR [6/6] RUN npx prisma generate

An idea ?

I think it's problem with node alpine and my mac m1 i change Dockerfile with node:14.16.0 and it's work
`FROM node:14.16.0
Create app directory
WORKDIR /usr/src/app
COPY package*.json ./
RUN npm install
COPY . .
EXPOSE 5000
RUN npx prisma generate
CMD [ "npm", "run", "dev" ]`

Hey, thank you for spotting this. I should close the issue now as it's resolved


Replace exception_notification integration with Errbit/Airbrake

Errbit is the current approach in our stack for tracking errors.
Related PRs:

https://github.gds/gds/puppet/pull/3390
https://github.gds/gds/deployment/pull/706
https://github.gds/gds/alphagov-deployment/pull/1053

/cc @jamiecobbett @alext

Merge when ready :+1:

:+1:
You can also remove action_mailer now I think: https://github.com/alphagov/static/blob/master/config/application.rb#L4

@tijmenb well spotted, https://github.com/alphagov/static/pull/653


Add missing @Override and make methods static

Found via error-prone.

Does anything block merging this?

Does anything block merging this?

Time and resources

LGTM

@rfscholte
Not sure how about you, but I started the build in few seconds and seen changes (static private method and one Override annotation).

Build passed, merging...

@gaul Thx for contributing. You are welcome with new pullrequests.


Detect wordpress

What would you like to be added:
Detect wordpress
Why is this needed:
Syft does not detect wordpress.
$ syft wordpress | grep wordpress
 ✔ Loaded image                                                                                wordpress:latest   ✔ Parsed image                                                                                sha256:2fc2a7b0412945f6cc3d75420013cbb6d31d764128d06150b7e7deb61173ba2a
 ✔ Cataloged contents                                                                                3d3f197740a201268ecbe340ccd9a95833995b7d2daa9d53664411eca16967a5
   ├── ✔ Packages                        [275 packages]
   ├── ✔ File digests                    [10,715 files]
   ├── ✔ File metadata                   [10,715 locations]
   └── ✔ Executables                     [1,284 executables]
Akismet Anti-spam: Spam Protection  5.3.1                           wordpress-plugin

Additional context:
docker scout can detect wordpress.
$ docker scout sbom --format list wordpress | grep wordpress
{"level":"info","msg":"Provenance obtained from attestation","time":"2024-02-21T14:42:04+09:00"}
{"level":"info","msg":"SBOM obtained from attestation, 382 packages indexed\n","time":"2024-02-21T14:42:09+09:00"}
{"level":"info","msg":"Pulling","time":"2024-02-21T14:42:09+09:00"}
{"level":"info","msg":"Pulled","time":"2024-02-21T14:42:10+09:00"}
  wordpress                  6.4.3                           generic

From https://github.com/docker/scout-cli/releases, docker scout seems to use syft.
And in json, docker scout seems to check version.php file.
Maybe they use binary cataloger like https://github.com/anchore/syft/pull/2445
$ docker scout sbom wordpress | jq '.artifacts[] | select(.name == "wordpress")'
{"level":"info","msg":"Provenance obtained from attestation","time":"2024-02-21T14:53:47+09:00"}
{"level":"info","msg":"SBOM obtained from attestation, 382 packages indexed\n","time":"2024-02-21T14:53:51+09:00"}
{"level":"info","msg":"Pulling","time":"2024-02-21T14:53:51+09:00"}
{"level":"info","msg":"Pulled","time":"2024-02-21T14:53:52+09:00"}
{
  "type": "generic",
  "name": "wordpress",
  "version": "6.4.3",
  "purl"<EMAIL_ADDRESS>  "author": "NOASSERTION",
  "locations": [
    {
      "path": "/usr/src/wordpress/wp-includes/version.php",
      "digest": "sha256:3f4af3e34785188118e119dc0189bea540851fe9a46947fcd631643df8bcad80",
      "diff_id": "sha256:426987b031bec9147d4a532539e731aa9dc2928a52a36a7d022d8123a289943c"
    }
  ]
}

Hi @witchcraze, thanks for the report. I did a little digging and we do have a binary cataloger for Wordpress: https://github.com/anchore/syft/blob/main/syft/pkg/cataloger/binary/default_classifiers.go#L407 -- it looks for wp-cli, which apparently isn't on this wordpress image. It might be the case that we need to expand our classifier for Wordpress bits.
Interestingly enough, I tried your docker command but I don't get the same results from Scout:
tgerla@Timothys-MacBook-Pro-2 wp % docker scout sbom --format list wordpress | grep wordpress
{"level":"info","msg":"SBOM of image already cached, 381 packages indexed\n","time":"2024-02-21T08:37:00-05:00"}

Thank you for your confirmation.
Let me report my environment (WSL2).
$ cat /etc/os-release
PRETTY_NAME="Ubuntu 22.04.4 LTS"
NAME="Ubuntu"
VERSION_ID="22.04"
VERSION="22.04.4 LTS (Jammy Jellyfish)"
VERSION_CODENAME=jammy
ID=ubuntu
ID_LIKE=debian
HOME_URL="https://www.ubuntu.com/"
SUPPORT_URL="https://help.ubuntu.com/"
BUG_REPORT_URL="https://bugs.launchpad.net/ubuntu/"
PRIVACY_POLICY_URL="https://www.ubuntu.com/legal/terms-and-policies/privacy-policy"
UBUNTU_CODENAME=jammy

$ docker version
Client: Docker Engine - Community
 Version:           25.0.3
 API version:       1.44
 Go version:        go1.21.6
 Git commit:        4debf41
 Built:             Tue Feb  6 21:13:09 2024
 OS/Arch:           linux/amd64
 Context:           default

Server: Docker Engine - Community
 Engine:
  Version:          25.0.3
  API version:      1.44 (minimum version 1.24)
  Go version:       go1.21.6
  Git commit:       f417435
  Built:            Tue Feb  6 21:13:09 2024
  OS/Arch:          linux/amd64
  Experimental:     false
 containerd:
  Version:          1.6.28
  GitCommit:        ae07eda36dd25f8a1b98dfbf587313b99c0190bb
 runc:
  Version:          1.1.12
  GitCommit:        v1.1.12-0-g51d5e94
 docker-init:
  Version:          0.19.0
  GitCommit:        de40ad0

$ docker scout version

      ⢀⢀⢀             ⣀⣀⡤⣔⢖⣖⢽⢝
   ⡠⡢⡣⡣⡣⡣⡣⡣⡢⡀    ⢀⣠⢴⡲⣫⡺⣜⢞⢮⡳⡵⡹⡅
  ⡜⡜⡜⡜⡜⡜⠜⠈⠈        ⠁⠙⠮⣺⡪⡯⣺⡪⡯⣺
 ⢘⢜⢜⢜⢜⠜               ⠈⠪⡳⡵⣹⡪⠇
 ⠨⡪⡪⡪⠂    ⢀⡤⣖⢽⡹⣝⡝⣖⢤⡀    ⠘⢝⢮⡚       _____                 _
  ⠱⡱⠁    ⡴⡫⣞⢮⡳⣝⢮⡺⣪⡳⣝⢦    ⠘⡵⠁      / ____| Docker        | |
   ⠁    ⣸⢝⣕⢗⡵⣝⢮⡳⣝⢮⡺⣪⡳⣣    ⠁      | (___   ___ ___  _   _| |_
        ⣗⣝⢮⡳⣝⢮⡳⣝⢮⡳⣝⢮⢮⡳            \___ \ / __/ _ \| | | | __|
   ⢀    ⢱⡳⡵⣹⡪⡳⣝⢮⡳⣝⢮⡳⡣⡏    ⡀       ____) | (_| (_) | |_| | |_
  ⢀⢾⠄    ⠫⣞⢮⡺⣝⢮⡳⣝⢮⡳⣝⠝    ⢠⢣⢂     |_____/ \___\___/ \__,_|\__|
  ⡼⣕⢗⡄    ⠈⠓⠝⢮⡳⣝⠮⠳⠙     ⢠⢢⢣⢣
 ⢰⡫⡮⡳⣝⢦⡀              ⢀⢔⢕⢕⢕⢕⠅
 ⡯⣎⢯⡺⣪⡳⣝⢖⣄⣀        ⡀⡠⡢⡣⡣⡣⡣⡣⡃
⢸⢝⢮⡳⣝⢮⡺⣪⡳⠕⠗⠉⠁    ⠘⠜⡜⡜⡜⡜⡜⡜⠜⠈
⡯⡳⠳⠝⠊⠓⠉             ⠈⠈⠈⠈

version: v1.5.0 (go1.21.6 - linux/amd64)
git commit: 5661a7fce57851c49627a79c9d181e87833df7e8

Thanks @witchcraze! I upgraded Docker and now I'm on Scout 1.4.1 and I get the same results as you. I will see if I can figure out what Scout is doing differently from stock Syft.

I had a look around the wordpress:6.4.3 image, and (excluding some irrelevant matches) the only things I see present are:
# grep --exclude-dir=proc --exclude-dir=sys --exclude=*.svg --exclude=*.js -r '6\.4\.3' /
grep: /usr/lib/python3.11/__pycache__/ssl.cpython-311.pyc: binary file matches
/usr/lib/python3.11/ssl.py:    """Matching according to RFC 6125, section 6.4.3
/usr/src/wordpress/wp-includes/version.php:$wp_version = '6.4.3';
/usr/src/wordpress/wp-admin/about.php:						'6.4.3',
/usr/src/wordpress/wp-admin/about.php:							sanitize_title( '6.4.3' )

It sure looks like using the wp-includes/version.php would be the just about the only reasonably correct way to identify this, as @witchcraze noted. I have an idea how I might like this to work generally for things like this in .php, .rb, and similar source files, but probably not by directly using the binary cataloger, which is really intended to identify individual binary files (hence the name).

In addition to that I wonder how we could also add detecting wordpress-plugins (and versions) once we identified a wordpress. Once we found a path containing WordPress itself we could maybe use a dependent check from there to check for plugins. Or if you prefer that more maybe call a found wp-cli tool with that given path and get a "wp plugin list"-listing from there? I tend to detecting plugins directly (but only checking for them once we detected a WordPress-installation).

@neufeind Syft detects WordPress plugins with their versions since https://github.com/anchore/syft/pull/2218. Please open a new issue if that functionality is giving you any trouble! This issue is about detecting the installation of WordPress itself.

Here's the concrete proposal I think we should build:

Add a new cataloger that is meant to detect the wordpress server code itself.
The new cataloger should look for a path like **/wordpress/wp-includes/version.php and parse out the value of the $wp_version variable from a line like $wp_version = '6.4.3';.

This should not be part of the binary cataloger, though it will be pretty similar in structure.
One remaining open question is: what type of package should it emit? There aren't a log of great candidates at https://github.com/package-url/purl-spec/blob/master/PURL-TYPES.rst - composer is used for PHP composer packages, but we don't have PHP composer packages in this case, we just have a pile of PHP files that we believe represents an installation of the wordpress server process. We use wordpress-plugin for WordPress plugins, but WordPress itself isn't really a WordPress plugin.
I'm adding the needs-discussion label to discuss as a team what package type this new cataloger should emit. Once that's decided this is probably ready to work on.

I think the package url type would just be generic and the syft package type probably just binary as well with a language type set to php for now?


Error Beautifying Sass - (pathing issue)

Hello,
I am trying to get the SassBeautify Plugin to work, I have Ruby 2.2.2p95 installed and Sass 3.4.13 installed. I used the RubyInstalled and selected "Add Ruby executables to your PATH" during installation.
When I try to run SassBeautify in ST3 I get the following error - Error Beautifying Sass - [Errno 32] Broken Pipe
Update-3 - I attempted a different file and the 'Sassbeautify' command gave a different result. 'sass-convert is not recognized as an internal or external command' I am assuming this is a pathing issue, can someone shed some light on how to fix pathing? I am a python / cmd noob.
When I try to use "Command prompt with ruby" and run the following command '$sass-convert --from scss --to scss forms.scss', I receive an error "$sass-convert' is not recognized as an internal or external command
Any assistance is appreciated.
Update-1 - I have looked at the readme and I don't understand echo $path as it returns $path
Update-2 - I ran the command without the '$' as 'sass-convert --from scss --to scss forms.scss' and the command prompt outputted all of the css, but it does not 'beautify' my code.
Update-4 - I ran 'gem env' will post my results soon

Fixed! I wasn't pointing to the /bin directory for ruby!


TinyJSON: Fix polymorphic support and add nullable (T?) support

TinyJSON
Fix polymorphic support
TinyJSON by design supports polymorphic fields with type hint. It seems like the de-duplication attempt back in v0.2.3 broke this feature. By copying the body of DecodeFields back into DecodeType, the feature starts working again.
As someone who doesn't understand enough to explain the issue, my assumption is MethodInfo.MakeGenericMethod does not cover inferred generic method calls inside the method body.
Nullable support
A conditional block is added to DecodeType to detect Nullable types. When decoding into T?, the method decodes the underlying type T instead, then cast it into T? and return.

TinyJSON isn't really used anymore and will most likely be deprecated in the next patch. Users should use either System.Text.Json (on il2cpp) or Newtonsoft.Json (on mono)

TinyJSON isn't really used anymore and will most likely be deprecated in the next patch. Users should use either System.Text.Json (on il2cpp) or Newtonsoft.Json (on mono)

I came from The Long Dark (IL2CPP) and I honestly suggest keep it as an alternative option, even only for the polymorphic feature.
The polymorphic support of System.Text.Json requires annotating the base type. Say, given an interface I, and implementation A and B. To support serializing and decoding A and B into a member of I, A and B must be referenced on I with a attribute from System.Text.Json.
As you may have noticed, it weirdly makes the base type depend on derived types.
This wouldn't be a problem only if we expects our projects are "closed" and do not interact with anything external. Yet, in modding scene, API/Framework mods exist, IMO we want stuff to be as open as possible.
This is why TinyJSON polymorphic feature is superior in modding scene. It simply uses Activator to create instances from type hint(Type.FullName). Any mod can freely derive types from other mods and serialize/deserialize their own types without issue.

Isn't this already a thing with Newtonsoft Json?

Does Json.NET natively works in IL2CPP?
Either way I suddenly realized by

TinyJSON isn't really used anymore
maybe you meant it's not used by ML anymore? In that case yeah I understand why it's going out.

I personally find it more pleasant to use and convenient as part of ML. But It's not like I can't just include TinyJSON in my projects or use it as a package.

maybe you meant it's not used by ML anymore?

Not sure if it ever was, but it isn't. Since Newtonsoft Json and System.Text.Json are the go-to packages, there is no point in keeping an outdated package on this repo.


Use proper path to command

Very nice catch! Thanks :) I even spotted another small issue in the same section:

(if you use Composer to download Releaser)

makes no sense there (it is probably a copy-paste issue).


rfc: always poll for I/O in uv_run()?

Refs: https://github.com/nodejs/node/issues/28502
Libuv does not poll for I/O when there are no ref'd handles. In the linked issue that causes Node.js to miss the SIGTERM event because the uv_signal_t is unref'd and it's the only active handle.
We can do 1 of 3 things:

Do nothing. It's the documented behavior.

Special case : poll with a zero timeout when any signal handles are active, ref'd or unref'd. Complicated because uv_loop_t doesn't track them explicitly.

General case: always poll for I/O in uv_run(). It's an easy fix but a change in behavior. Maybe it's the behavior most people expect though.

diff --git a/src/unix/core.c b/src/unix/core.c
index 202c75bb..2d15a934 100644
--- a/src/unix/core.c
+++ b/src/unix/core.c
@@ -351,8 +351,11 @@ int uv_run(uv_loop_t* loop, uv_run_mode mode) {
   int ran_pending;

   r = uv__loop_alive(loop);
-  if (!r)
+  if (r == 0) {
     uv__update_time(loop);
+    mode = UV_RUN_NOWAIT;
+    r = 1;
+  }

   while (r != 0 && loop->stop_flag == 0) {
     uv__update_time(loop);

Makes the check_ref, idle_ref and prepare_ref tests fail because they don't expect to have their callbacks called.
Has a minor inefficiency calling uv__update_time() twice when loop->stop_flag == 0 but that can be fixed.

I'd go for 1) and err on the side of caution.

I'd go for 1) and err on the side of caution.

I agree.

I agree as well.

So decided then. :-)

Belated: this issue is a duplicate of #276 from 2015, also reported by yours truly.


Proper table printing broken with R 3.5

Setup:

R 3.5.0
rtichoke 0.1.2
Windows 10
ConEmu

Reproducible example:
data.frame(a = 1:2, x = c("a", "b"))
#> ☻ÿþa♥ÿþ ☻ÿþx♥ÿþ
#> ☻ÿþ1♥ÿþ ☻ÿþ1♥ÿþ ☻ÿþa♥ÿþ
#> ☻ÿþ2♥ÿþ ☻ÿþ2♥ÿþ ☻ÿþb♥ÿþ

For the record, it works fine on macOS.

Data.table looks to be affected too:
data.table(a = 1:2, x = c("a", "b"))
#>  ☻ÿþa♥ÿþ ☻ÿþx♥ÿþ
#>☻ÿþ1:♥ÿþ ☻ÿþ1♥ÿþ ☻ÿþa♥ÿþ
#>☻ÿþ2:♥ÿþ ☻ÿþ2♥ÿþ ☻ÿþb♥ÿþ

Not tibbles though:
tibble(a = 1:2, x = c("a", "b"))
#> # A tibble: 2 x 2
#>       a x
#>   <int> <chr>
#>  1     1 a
#>  2     2 b

It works fine both on Cmder and Command Prompt.

It looks like your R version is 3.4.3. Here's what I'm getting with 3.5:

Oh, yeah. I can reproduce it via R 3.5.

Yeah regular R works fine--I'm using cmder as well FWIW.
I dug around a bit in the R repo and didn't see any major changes to printing, nor was there anything in the release notes. Very odd.

That is just odd...what has changed do you think?

I notice that rstudio has code related to these escaped characters.

The relevant commit from Joe Cheng, if you didn't see that already. Looks like R output needs to be homogenized to utf-8.

4e29747 should fix it.

I don't know if this helps, but 0xFEFF is the UTF-16 encoding of the byte order mark.

@randy3k Confirmed working on Command Prompt and Cmder with the most recent version. Nice work!

But I still what happens to R 3.5 is causing this.


Can no longer use construction model without MSBuild on the path

Since upgrading MSBuild builds, our unit tests are now failing in VS with:
Message: System.TypeInitializationException : The type initializer for 'BuildEnvironmentHelperSingleton' threw an exception.
---- System.InvalidOperationException : Could not determine a valid location to MSBuild. Try running this process from the Developer Command Prompt for Visual Studio.

     "Microsoft.Build": "15.1.262-preview5",
     "Microsoft.Build.Framework": "15.1.262-preview5",
     "Microsoft.Build.Utilities.Core": "15.1.262-preview5",
     "Microsoft.Build.Tasks.Core": "15.1.262-preview5",
     "Microsoft.Build.Engine": "15.1.262-preview5",

What should we be using instead?

@RaulPerez1

Can you point me to the unit test code so I can see what they're doing?  You might need to use the runtime package which has MSBuild.exe, use a different code path that doesn't hit this exception, or we have a bug somewhere.

https://github.com/dotnet/roslyn-project-system/blob/b22cf2e196665e747a00c60d53aba0865567f329/src/Microsoft.VisualStudio.ProjectSystem.CSharp.VS.UnitTests/ProjectSystem/VS/CSharpProjectCompatibilityProviderTests.cs#L30

@AndyGerlicher this was caused by this change which made this code throw if you're just using our OM:
ProjectRootElement projectRootElement = ProjectRootElement.Create();

It works in MSBuild 14.0.
@davkean I've marked this as Pri 1 for RC.3, does that seem appropriate?

Thanks find, I just want my unit tests to run again...

How does this going? My unit tests are still broken...

Sorry I forgot to update you.  This PR have addressed the issue: https://github.com/Microsoft/msbuild/pull/1482
I've confirmed that version 15.1.0-preview-000503-01 of our packages let you create new projects like your unit tests are.


Add ability to set otel options on HTTP tracing client

Codecov Report

Merging #104 (f2e4de5) into main (69099fc) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #104   +/-   ##
=======================================
  Coverage   92.73%   92.74%
=======================================
  Files          28       28
  Lines        1349     1350    +1
=======================================
+ Hits         1251     1252    +1
  Misses         71       71
  Partials       27       27

Flag
Coverage Δ

micro
92.74% <100.00%> (+<0.01%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

trace/http.go
88.88% <100.00%> (+0.31%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 69099fc...f2e4de5. Read the comment docs.


Duplicates!

We found 21M duplicates on one of our cluster.
Use case: replace-mode
Distribution:
4,4,4,5,5,7,12,15,19,22,23,24,48,73,102,115,137,164,168,179,198,277,296,372,548,564,636,744,2814,3477,8654

And about 20M more of 2 and 3.
We suspect setVersion(1) in both x-fix and bg, we will have to see if it helps.

This code was not modified lately, so there may be more causes for that.

We are trying to reproduce the same scenario on a lab environment


fix(vite-plugin-nitro): use proxy for API requests instead of custom middleware

PR Checklist

Closes #
What is the new behavior?
Because API routes are built under /api during development, and / in the production build, requests made to API routes are configured using routeRules instead of custom internal middleware. This allows the API routes to properly preserve cookies and headers with direct requests and redirects.
Existing routeRules configuration is merged with the internal configuration.
Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information
[optional] What gif best describes this PR or how it makes you feel?

Thanks a lot @brandonroberts for this fix! Really appreciated!

I was checking what was happening with the headers that weren't being set in prod using Vercel for a couple of days. Initially I thought it was a problem with h3 in Vercel, but in the end, I figured out the problem could be in the nitro vite plugin but I hadn't a chance to keep digging.
I really appreciate this fix @brandonroberts, thanks 😄


Enforce git-flow, PR and squash commit

Enforce git-flow, PR and squash commit

Merging to master is possible only if

A PR received approval
Status check with Travis passed
Performed by an administrator

In addition, only squash commit from PR is enabled.

When working on a change:

A github issue must be created
The name of the branch must be feature/[issue number], E.g. feature/66
The description of the PR has to be explicit. E.g.

Title: Introducing new curve ABCD

Motivation: ABCD is used in blockchain Z
Test: Unit test added and integration test against Z done etc...
Related Issue: 66

I am closing this task.
Feel free to re-open if you have any questions.


[BUG] Dune 2 mouse cursor doesn't move (because of missing mouse callback, or missing mouse driver)

Is this still an issue?
The mouse cursor seems to move fine in Dune.
But not at all in Krondor :(

Yes indeed, this is still an issue.
Dune uses an older method compared to newer games.
I had a few shots at this, but didn't get very far due to lack of time.

Interesing code from JDOSBox related to this:
case CB_IRQ12:    // ps2 mouse int74
if (!use_cb) Log.exit("int74 callback must implement a callback handler!");
Memory.phys_writeb(physAddress, 0x1e);        // push ds
Memory.phys_writeb(physAddress + 0x01, 0x06);        // push es
Memory.phys_writew(physAddress + 0x02, 0x6066);    // pushad
Memory.phys_writeb(physAddress + 0x04, 0xfc);        // cld
Memory.phys_writeb(physAddress + 0x05, 0xfb);        // sti
Memory.phys_writeb(physAddress + 0x06, 0xFE);        //GRP 4
Memory.phys_writeb(physAddress + 0x07, 0x38);        //Extra Callback instruction
Memory.phys_writew(physAddress + 0x08, callback);            //The immediate word
return 0x0a;
case CB_IRQ12_RET:    // ps2 mouse int74 return
if (use_cb) {
Memory.phys_writeb(physAddress, 0xFE);    //GRP 4
Memory.phys_writeb(physAddress + 0x01, 0x38);    //Extra Callback instruction
Memory.phys_writew(physAddress + 0x02, callback);        //The immediate word
physAddress += 4;
}
Memory.phys_writeb(physAddress, 0xfa);        // cli
Memory.phys_writew(physAddress + 0x01, 0x20b0);    // mov al, 0x20
Memory.phys_writew(physAddress + 0x03, 0xa0e6);    // out 0xa0, al
Memory.phys_writew(physAddress + 0x05, 0x20e6);    // out 0x20, al
Memory.phys_writew(physAddress + 0x07, 0x6166);    // popad
Memory.phys_writeb(physAddress + 0x09, 0x07);        // pop es
Memory.phys_writeb(physAddress + 0x0a, 0x1f);        // pop ds
Memory.phys_writeb(physAddress + 0x0b, 0xcf);        //An IRET Instruction
return (use_cb ? 0x10 : 0x0c);

I implemented the missing code in the branch feature/mouse_callback
This is the only callback needed for Dune II according to my testing (disabling it in JDOSBox stops the mouse from moving), but it seems I just can't write it at the right addresses to save my life...
The latest code comes from DOSBox Staging.


Tutorial Cross Contract Communication

What does this PR fix/introduce?
Tutorial for Cross Contract Communication
Additional context
Step by step tutorial on writing contracts and interacting with them using the CLI and passing parameters to the deploys.
The goal is to provide enough information to be able to grasp one of most important topics in the development of the cross contract communication on the Casper Network.
Checklist

[x] Docs are successfully building - yarn install && yarn run build.
[x] For new internal links I used relative file paths (with .md extension) - e.g. ../../faq/faq-general.md - instead of introducing absolute file path, or relative/absolute URL.
[x] All external links have been verified with yarn run check:externals.
[x] My changes follow the Casper docs style guidelines.
[x] All technical procedures have been tested (if you want help with this, mention it in Reviewers).
[x] If structural changes are introduced (not just content changes), cross-broswer testing has been completed.

Reviewers
// Tag whoever needs to review. If you're not sure, leave blank.

Superseded by #165.


Bound form does not have form.handle

I'm trying to use two independent forms with the same options, and I'm having problems using form.handle() on the newly bound form object. If I do this:
var form2 = form1.bind(data);
The form works just fine. But calling form2.handle() on the new form returns an error saying the function is undefined. Doing a console.log on form2 does indicate that handle is missing. The documentation says that newly bound form objects should have all properties of the parent form object, but this isn't the case.
I'm aware that since the form options are the same, I could just validate the data using the same form and two different data sets. I'd just like to have the two separated if at all possible, versus having this overlap.

A bound form also doesn't have a .bind method - both .bind and .handle do binding, and once bound, a form can't be rebound - the intention is that you keep the unbound form and reuse that across requests - creating a new bound instance on every request.

Gotcha. The documentation was misleading when it said that newly bound form objects inherited all their parent form's properties. Thanks!

A pull request to clear that up would be appreciated :-) (also tho, properties, not methods)


fields for create quarkus maven does not have keyboard focus

When starting Quarkus create maven project I seem to almost always have to use the mouse or tab to get the field to have focus.
Expectation: not having to use the mouse nor tab around fields to go through the flow.

I'm having trouble replicating this issue.
When I call the command to create the project, the field is always highlighted for me. Because of this, I can just go ahead and start typing. After I'm done, I can hit Enter and the next field is also highlighted:

Although, I have to use tab to use the back button without the mouse.
Are the fields not highlighted on your end?

I can't reproduce the exact issue  now - just remember that the field did not have focus.
What I'm seeing now is that the field does have focus (text is highlighted) but when pressing Enter on  project name it doesn't do anything.
I have to go edit it and then it highlights and says "Invalid artifactId"  for "MyQuarkusProject" (the default) which seem to be because it want it to have all lower case...which isn't invalid imo. I'll open separate issue on that.

Reopening because I came across this issue on a Windows machine

I've ran into this issue when I open the wizard when I have a webview open (vscode-quarkus welcome page, java extension pack overview, gitlens welcome page etc.)
This issue is likely related to this issue: https://github.com/microsoft/vscode/issues/76316