Special characters display issue after windows restart.

Environment

Windows 10 :  10.0.18362.0
Windows Terminal version (if applicable):Windows Terminal (Preview) Version: 0.9.433.0
posh-git
oh-my-posh
Theme: Agnoster

Steps to reproduce

Install https://github.com/adam7/delugia-code font
Open windows terminal settings and apply it in simmilar fashion:

            {
                // Make changes here to the powershell.exe profile
                "guid": "{61c54bbd-c2c6-5271-96e7-009a87ff44bf}",
                "name": "Windows PowerShell",
                "commandline": "powershell.exe",
                "fontFace" : "Delugia Nerd Font",
                "colorScheme": "Mocha Dark",
                "hidden": false
            },

Open $profile for powershell and add following lines:

Import-Module posh-git
Import-Module oh-my-posh
Set-Theme Agnoster

Open in Windows Terminal PowerShell and confirm that font is changed and is displayed correctly.

Restart windows
Open in Windows terminal PowerShell and confirm that font is changed bust special characters are not displayed correctly.

Reinstall font
Reopen PowerShell in windows termianal and confirm that font is working fine now.

Expected behavior

After restart font should be working fine, all characters are displayed correctly
Actual behavior

In PowerShell everything is working fine, but when PS is opened in Windows terminal, after restart some characters are not displayed correctly.

It should help to note that the characters widely used for those triangles are in the private use range of Unicode.  https://unix.stackexchange.com/q/320735/5132

This looks a lot like /dup #3257


Web Status?

I am finding myself very much wanting to know how many discs I have queued up for transcoding, and how much space I have on my drive where the raw RIPs are stored.
I have put together the following Python script to provide this basic info, as well as displaying the empty.log file that seems to be where all activity is logged, in reverse order so newest is at top.
https://gist.github.com/audioeng/fd36d74cf5ee7e2eb3ca7e910f74d39e
Run it as the same user that ARM is running as, root in my case so I use sudo. Go to /info/ URI for the Info page with queue, it auto refreshes every 60 seconds.
If anyone else likes this, I can probably make this into a PR, but I don't want to clean it up too much unless others find value in it.
Screenshot:

Nice, I think it's useful.  ... we really need to get ARM running as not root. |:-)

Ehh, not a huge deal in my opinion, it’s not like I am going to make this
box externally available or doing anything else... but yes, running as
non-root would be preferred.
I’ll look into pulling some of the hard coded locations out to make it more
universal for a pr (free space is just looking at “/“ now, instead of the
variables in the config file.
I’m not sure how to plug it into running on boot, I am just kicking it off
via ssh right now.
On Thu, Sep 21, 2017 at 12:41 AM Benjamin Bryan<EMAIL_ADDRESS>wrote:

Nice, I think it's useful. ... we really need to get ARM running as not
root. |:-)
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/ahnooie/automatic-ripping-machine/issues/87#issuecomment-331049308,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AQVLdcnb98sHZkTZQB0dWx5PCD8XqtL3ks5skejggaJpZM4PeyaR
.

Interestingly enough, because I am seeing all of the queued scripts in mostly real time, I think I figured out why the ID_FS_LABEL variable was showing up for the rip but not the transcode, in #85.
I never see the {media}_rip.sh process run as it is called directly from the identify.sh script, whereas the the video_transcode.sh is handed off to batch (|at now) to be queued. That is why the rip script has access to the ID_FS_LABEL variable but the transcode script does not.
Not a big deal, as I think moving to the nicer looking label variable would be preferred anyway.

Has anyone had a chance to test out the basic status and log viewing webpage I put together for #90 ?
The only log I have seen on my instance is empty.log, everything is going there, so that is all I am handling at the moment.
Are others getting other log file names as it looks like the code has in it? If so, I can add the logic in to display the list of log files and allow you to select the one to view.
I find I rarely look at the log now that I can see the queue and disk status. If others find it useful, I could add in other options like cancelling a queued item or something.
Thanks @ahnooie again for this project, I am making my way through my DVD collection with much greater speed than I was previously, entirely manually!

Manually pulled into V2.


MM-42278 Initial Playwright setup for visual testing

Summary
This PR introduced Playwright initially for visual testing, then eventually for accessibility and frontend performance testing. Once it reached stability and maturity based on our use case, completed other important items like reporting, integration, pipeline, etc. and accepted for dev/community to write tests, it will be used to automate tests of new features while Cypress will go on maintenance mode. Files and folders are to be found at /e2e/aesthetic/.  Used "aesthetic" as it will test initially the "beauty" of the webapp but very much open to suggestion for a better name.
Files and folders of Cypress were moved to /e2e/functional/.
Visual testing is known to be problematic for elements that render dynamic information like date/time, name of teams/channels/users, etc. To deal with it, I introduced option on that makes it easier to hide specific element thru new props of custom theme (hideInVisualTesting). There are other ways to do that like specifically adding new user preference, but I thought it makes sense to extend the use of custom theme.
I've extended Client4 and made some changes to its properties and relocated couple of helper functions to make it compatible as node client. Client4 was more of a browser client, though.
For local development and in-house visual test run, screenshots were created using the official Playwright docker container which uses Linux/Ubuntu (focal) distribution. Using such container makes the screenshot consistent even with developers using different local environment and will match with the same container we'll use in the pipeline.
To test screenshots in wide-range of different environments (OS, browser and mobile clients) and easy enough for QA to handle during release testing, I've added the ability to run both using applitools and percy. Nothing official yet but both provided so we'll get enough time to evaluate which tool is best for us.
To follow in separate PR:

Support for Cloud server
Support with Calls product
Reporting - to community, dashboard and Zephyr
Gitlab pipeline
Docs on best practices, semi-opinionated patterns and styles

Ticket Link
https://mattermost.atlassian.net/browse/MM-42278
Related Pull Requests

Has server changes (link here)

Release Note
NONE

I haven't had a chance to look through all this, but with the number of changes in this PR, is it possible for us to break it down any further? Also, I've actually got similar changes to Client4 that I've been working on which will conflict with these, so we'll have to consolidate those.
As for dealing with those problematic elements, I wonder if we could instead have a fixed username and time somehow since I feel like hiding elements of the page could cause other problems by having the tests not reflect the actual UI. If we're doing that though, I'd rather do it by injecting CSS directly into the web page instead of adding something into the theme to do that. Looking at the docs for Playwright, it sounds like we might be able to use something like this to add those rules without changing the theming code

@hmhealey Thanks for the general review! I haven't had a chance to work/look into this but will try within this week.
Sorry for the massive changes. I do understand the overhead in reviewing the changes, unfortunately, they are related to each other and I thought it's the minimum change I could provide. The changes typically were:

moved /e2e to /e2e/functional/
modify Client4 to be compatible with node client
basic Playwright setup at /e2e/aesthetic/
few tests with screenshots
And submitting separately will not make sense since they are related to each other. I hope it's fine but let me know how you'd like to proceed.

Well noted on your (upcoming) changes in Client4.
We can use fixed values but at one point, we'll still going to deal with dynamic element. Besides, randomness will help us with test isolation as well. I didn't know there's a way/feature to do that directly in Playwright. Thanks for sharing and I'll take a look.

@Phrynobatrachus @furqanmlk Adding you for quick check and feel free to post comments.


Consolidation of prerequisites

Reworking the prerequsites to make it as easy to use as possible.
Placing the dependencies left inside a new file with the convienient short name tr.py (from termux requirements) in master.
Things to go inside the new tr.py
pkg install termcolor wget proot

Java : wget https://raw.githubusercontent.com/Hax4us/java/master/installjava && sh installjava
ADB (Android Debug Bridge) Drivers : wget https://github.com/MasterDevX/Termux-ADB/raw/master/InstallTools.sh && bash InstallTools.sh

I'll open a less confusing one


RuntimeError: Max post-process passes exceeded.

Hi,
I'm trying to combine pipline with S3 storage, so I'm using it like
class NonPackagingS3PipelineCachedStorage(
        NonPackagingMixin, PipelineMixin, CachedFilesMixin, S3BotoStorage):

When calling collect static, its failing and give me
  File "venv/lib/python3.6/site-packages/django/contrib/staticfiles/management/commands/collectstatic.py", line 188, in handle
    collected = self.collect()
  File "venv/lib/python3.6/site-packages/django/contrib/staticfiles/management/commands/collectstatic.py", line 134, in collect
    raise processed
RuntimeError: Max post-process passes exceeded.

The project is almost clean, and can't think of any clue.
I've added some logs at django.contrib.staticfiles.storage.HashedFilesMixin#post_process: line 254, seems like its trying to post process these files before failing [admin/css/base.css, admin/css/fonts.css, admin/css/forms.css, admin/css/widgets.css]
I'm using
Django==2.1.2
django-pipeline==1.6.14
django-storages==1.7.1

When using S3 if query-string authentication is enabled, you can end up in a situation where CSS files contain URLs with query-string parameters such as AWSAccessKeyId=...&Signature=...=&Expires=... -- and each time each file is hashed, these can change, creating an endless loop of differing hashes. Turing AWS_QUERYSTRING_AUTH off might help.

When using S3 if query-string authentication is enabled, you can end up in a situation where CSS files contain URLs with query-string parameters such as AWSAccessKeyId=...&Signature=...=&Expires=... -- and each time each file is hashed, these can change, creating an endless loop of differing hashes. Turing AWS_QUERYSTRING_AUTH off might help.

Works with Digital Ocean spaces, thanks!


ArgReduce 64 bit indices

@gcwenger very good point, but if the array is supported by cuDNN, it's guarantee the dimension size < 32bit.


ci: update the release workflow to ensure finalize runs after the image creation

Description
This pull request changes the following:

update the release workflow to ensure finalize runs after the image creation

Related Issues

Closes #3

No security issues with this commit, reviewed and approved.


Cannot read properties of undefined (reading 'getUserForContext')

err: {
      "type": "TypeError",
      "message": "Cannot read properties of undefined (reading 'getUserForContext')",
      "stack":
          TypeError: Cannot read properties of undefined (reading 'getUserForContext')
              at Proxy.$audit (file:///home/devbaraus/labbaraus/qurvo-server/node_modules/@stouder-io/adonis-auditing/build/index.js:133:49)
              at ModelWithAudit.afterSaveHook (file:///home/devbaraus/labbaraus/qurvo-server/node_modules/@stouder-io/adonis-auditing/build/index.js:151:30)
              at Runner.#exec (/home/devbaraus/labbaraus/qurvo-server/node_modules/@poppinss/hooks/src/runner.ts:119:13)
              at Runner.run (/home/devbaraus/labbaraus/qurvo-server/node_modules/@poppinss/hooks/src/runner.ts:136:17)
              at Proxy.save (file:///home/devbaraus/labbaraus/qurvo-server/node_modules/@adonisjs/lucid/build/src/orm/base_model/index.js:1369:55)
              at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
              at async User.create (file:///home/devbaraus/labbaraus/qurvo-server/node_modules/@adonisjs/lucid/build/src/orm/base_model/index.js:438:9)
              at HTTPLoggerMiddleware.handle (/home/devbaraus/labbaraus/qurvo-server/app/middleware/http_logger_middleware.ts:67:5)
      "status": 500
    }

Hi.
I'm getting the same error in a seeder which attempts to create a user with User.updateOrCreate() or User.create() methods.

Hey, I'd look into it. You have no other warning in console right?

Hi.
I'm getting the same error in a seeder which attempts to create a user with User.updateOrCreate() or User.create() methods.

Could you test if enabling asyncLocalStorage this error persists?

@devbaraus asyncLocalStorage was enabled when the error occurs.


[Request for External] page 5540 "Item Availability by Timeline" - Protected variables

Hello, we need the following currently global variable/-s to be set as protected. Can you please check this? Thank you!
protected var
   ItemNo: Code[20];
   LocationFilter: Text;
   VariantFilter: Text;
   ForecastName: Code[10];

Sorry, this page is deprecated and not going to work on web client. Please check latest version.

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.
Build ID: 41864.


[fsevent_watch_guard] Support 32bit kernels

Copied from: https://github.com/guard/guard/pull/206
Running Mac OS X 10.6.8 on a MacBook1,1
 > uname -a
Darwin mobile 10.8.0 Darwin Kernel Version 10.8.0: Tue Jun  7 16:33:36 PDT 2011; root:xnu-1504.15.3~1/RELEASE_I386 i386

Current rb-fsevent
 > gem install guard
Fetching: guard-0.9.4.gem (100%)
Successfully installed guard-0.9.4
1 gem installed

 > guard
[...]
~/.rbenv/versions/1.9.2-p290/lib/ruby/gems/1.9.1/gems/guard-0.9.4/lib/vendor/darwin/lib/rb-fsevent/fsevent.rb:89:in `popen': Bad CPU type in executable - ~/.rbenv/versions/1.9.2-p290/lib/ruby/gems/1.9.1/gems/guard-0.9.4/bin/fsevent_watch_guard (Errno::E086)
  from ~/.rbenv/versions/1.9.2-p290/lib/ruby/gems/1.9.1/gems/guard-0.9.4/lib/vendor/darwin/lib/rb-fsevent/fsevent.rb:89:in `pipe'
  from ~/.rbenv/versions/1.9.2-p290/lib/ruby/gems/1.9.1/gems/guard-0.9.4/lib/vendor/darwin/lib/rb-fsevent/fsevent.rb:46:in `stop'
  from ~/.rbenv/versions/1.9.2-p290/lib/ruby/gems/1.9.1/gems/guard-0.9.4/lib/vendor/darwin/lib/rb-fsevent/fsevent.rb:42:in `ensure in run'
  from ~/.rbenv/versions/1.9.2-p290/lib/ruby/gems/1.9.1/gems/guard-0.9.4/lib/vendor/darwin/lib/rb-fsevent/fsevent.rb:42:in `run'
  from ~/.rbenv/versions/1.9.2-p290/lib/ruby/gems/1.9.1/gems/guard-0.9.4/lib/guard/listeners/darwin.rb:18:in `start'
  from ~/.rbenv/versions/1.9.2-p290/lib/ruby/gems/1.9.1/gems/guard-0.9.4/lib/guard.rb:202:in `start'
  from ~/.rbenv/versions/1.9.2-p290/lib/ruby/gems/1.9.1/gems/guard-0.9.4/lib/guard/cli.rb:74:in `start'
  from ~/.rbenv/versions/1.9.2-p290/lib/ruby/gems/1.9.1/gems/thor-0.14.6/lib/thor/task.rb:22:in `run'
  from ~/.rbenv/versions/1.9.2-p290/lib/ruby/gems/1.9.1/gems/thor-0.14.6/lib/thor/invocation.rb:118:in `invoke_task'
  from ~/.rbenv/versions/1.9.2-p290/lib/ruby/gems/1.9.1/gems/thor-0.14.6/lib/thor.rb:263:in `dispatch'
  from ~/.rbenv/versions/1.9.2-p290/lib/ruby/gems/1.9.1/gems/thor-0.14.6/lib/thor/base.rb:389:in `start'
  from ~/.rbenv/versions/1.9.2-p290/lib/ruby/gems/1.9.1/gems/guard-0.9.4/bin/guard:6:in `<top (required)>'
  from ~/.rbenv/versions/1.9.2-p290/bin/guard:19:in `load'
  from ~/.rbenv/versions/1.9.2-p290/bin/guard:19:in `<main>'

 > file ~/.rbenv/versions/1.9.2-p290/lib/ruby/gems/1.9.1/gems/guard-0.9.4/bin/fsevent_watch_guard
/Users/johannesh/.rbenv/versions/1.9.2-p290/lib/ruby/gems/1.9.1/gems/guard-0.9.4/bin/fsevent_watch_guard: Mach-O 64-bit executable x86_64

Patched rb-fsevent
 > rake install
guard 0.9.4 built to pkg/guard-0.9.4.gem
guard (0.9.4) installed

 > guard
[...]
0 scenarios
0 steps
0m0.000s

Runs just fine now, all specs pass :)

that seems ok for you @ttilley ?


Login fields fixed (username to email)

PR related to issue #118
Changes made related to the ALTA log-in page :

Changed the required input field from username to email address

Added error message when email field is not completed with a correct email address

When email field is empty, other error message

[Important details from @RobertBeaudenon’s comment to avoid confusion] :
Back-end : since the user is now authenticated through its email, request.user return an email and not a user_name.

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@c516a25). Click here to learn what that means.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##             master     #126   +/-   ##
=========================================
  Coverage          ?   99.75%
=========================================
  Files             ?       12
  Lines             ?      416
  Branches          ?        0
=========================================
  Hits              ?      415
  Misses            ?        1
  Partials          ?        0

Impacted Files
Coverage Δ

server/organization/migrations/0001_initial.py
100.00% <ø> (ø)

server/user_account/models.py
100.00% <100.00%> (ø)

server/user_account/serializers.py
100.00% <100.00%> (ø)

server/user_account/tests.py
100.00% <100.00%> (ø)

server/user_account/views.py
98.79% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c516a25...f7b34e5. Read the comment docs.

I took a quick look at what you changed and looks good to me. Nice work. I might go more in depth tomorow if I have time to dig a bit more.
Regarding the backend Its worth specifying inside the description of the pull request that since the user is now authenticated through its email, request.user return an email and not a user_name, just to avoid confusion.

Ok if you want to do another look over I will refrain from merging now and you can do it tmrw.


Bad (obsolete) link to QUIC IETF draft in README.md

The Overview section of README.md has a link to the Version Negotiation section. It was written in May 2017:
IETF draft specification - https://tools.ietf.org/html/draft-ietf-quic-transport-03#section-7.1
This document has "Expires November 22, 2017" written on all of its pages (76 pages in total).
The most up to date IETF draft I found is here: https://tools.ietf.org/html/draft-ietf-quic-transport-20#section-6. I've changed the anchored section since Version Negotiation is now in section 6. This draft was published less than a month ago (April 23, 2019) and has "Expires October 25, 2019" written on all of its pages (143 pages in total).
There could be consequences if anyone relies on the information in this obsolete document (especially if they are writing code).

Good catch, thank you! We'll update the readme.


API rate limits

In #11, daveajones mentioned that the purpose of the API keys is to block keys that are "hammering the API". Do you have a rough estimate what you mean with that? Are 10k requests per day considered okay? What about 100k requests (for things like live suggestions while typing the search term)?

I’m sorry this hasn’t been documented anywhere yet. I’ve been frying some bigger fish and there are a few things I haven’t gotten down yet in the docs.
You want to keep your requests at less than one per second in the case of sustained traffic. Search as you type is OK as long as you debounce it so that it’s not going over that rate.  We will hopefully have our TOS finalized and up soon.


Add more tests to wrappers

Add few specific tests to Go, NodeJS, Python, Ruby, C++ wrappers. These tests make sure the wrapper API gives error (exception) when we try to create Secure Session with a key different from EC private one.
While adding these tests, few bugs were discovered in Python and Ruby wrappers. To be precise, it was wrong way of checking whether secure_session_create() returned NULL. The tests were not failing as expected. This PR also brings fixes for them.
Speaking about other wrappers, some of them seem to handle this kind of errors as well: Java (JNI), PHP, another PHP, JS (WASM)
And others may be missing the check: Objective C
I've also updated .gitignore to include some stuff like generated Ruby packages, some Python package metadata, another Rust target directory.
Checklist

[X] Change is covered by automated tests
[X] The coding guidelines are followed

And others may be missing the check: Objective C

Yep, it definitely is missing the check. The correct way will be to check for self.session value and return nil out of the initializer.
Please keep a note of which wrappers still need checks and tests.

@iamnotacake, currently I don't have my macBook available so I'm in the same boat as you: I can only make blind changes and test them by submitting it to CI :grin: Since you have been kind enough to enable the Allow edits by maintainers check box, I have simply pushed the commit into this branch (please git pull it on your machine). Unfortunately, Secure Session is not tested at all in ObjCThemis so no tests at the moment.

Also, since this PR does change the behavior of some wrappers, I believe it should update the changelog for relevant languages.

Also, since this PR does change the behavior of some wrappers, I believe it should update the changelog for relevant languages.

Does this look good?
- **Python**

  - Fixed bug where `SSession` constructor did not throw an exception if `secure_session_create()` returned `NULL` ([#710](https://github.com/cossacklabs/themis/pull/710)).

- **Ruby**

  - Fixed bug where `Ssession` constructor did not throw an exception if `secure_session_create()` returned `NULL` ([#710](https://github.com/cossacklabs/themis/pull/710)).

BTW, should we put news in changelog in alphabetical order or append them (in the same _Code:_ section) or it doesn't matter?
And if we add these things to changelog, I guess #698 should be mentioned too?

@vixentael,

I suggest to add test to check EC private keys as well (test should pass)

Aren't EC private keys – the happy path – tested in other tests that verify that Secure Session works as expected? Or you suggest just a complementary test for the constructor alone to complete the puzzle?

you suggest just a complementary test for the constructor alone to complete the puzzle?

yes, I suggest to complete the puzzle, because future us will totally forget why one case is not tested (which looks like we've missed that case)

@iamnotacake,

Does this look good?
[...]
Maybe you mean mentioning that sec session wrappers don't allow RSA keys anymore? Or both this and bugfixes? Now I'm a lil bit confised

The changelog is mostly for the users and they probably don't (and shouldn't) know about Themis Core functions. So I'd write there something like "${Secure Session constructor name} now (throws an exception | returns null | does a dance) when given incorrect keys", or maybe RSA keys specifically.
The idea is to describe the expected behavior to the user. With this change, the constructors may start failing due to incorrect keys. This changelog entry might help debugging.

BTW, should we put news in changelog in alphabetical order or append them (in the same Code: section) or it doesn't matter?

I'd ask to keep them alphabetical. That's one predictable order to look for a language.

And if we add these things to changelog, I guess #698 should be mentioned too?

Yeah, makes sense. Please do.


Direct Mode, OLSR Status Page, dhcp reservations as OLSR Hosts

Hi, my brother Rodney and I have been working on modifying hmm-pi to support Direct as well as NAT mode on the LAN, adding a link to the OLSR Status Page and adding DHCP reservations as OLSR hosts, all of which were missing from the published version.  I've completed the work and would now like to commit the changes.  To this end, I've created a fork at cbegg50/hsmm-pi and will put my changes in there.  Changed files are:
/webroot/files/olsrd/olsrd.conf.templage
/Model/NetworkSetting.php
/View/Layouts/default.ctp
/View/NetworkSettings/edit.ctp
/Controller/AppController.php
/Controller/NetworkSettingsController.php
I'm new to web based Git, where do I go from here?
Regards,
Colin Begg

Hi Colin - not involved in hsmm-pi (well, not yet).
With github, in order to contribute your code changes:

Fork hsmm-pi to your own github page  (you've apparently done that).
Clone from your github to your local machine.
Make and test your changes locally.
Commit your local changes.
Push your local branch to your github.
Go to the hsmm-pi github and do a pull request.  It will know you forked a copy, and
thus to pull from your github.
Wait for the maintainer of hsmm-pi to review and if agreeable, to Merge your changes.
The maintainer may or may not agree, of course.

-- Tom, N5EG

Thanks, Tom.  In the meantime, I've done the first few bits but named the directory hmm-pi-direct.  Should I keep the original hmm-pi directory name?
Colin, G4MCF

I think github (and git) require the original directory naming be exactly the same. That's one reason for forking the original.  Many folks will git checkout a new branch to put their changes on, and push that branch up to their github and thence pull request to origin. Then the maintainer will be able to decide whether to keep a separate branch, or to merge into the master branch.
-- Tom, N5EG

I've started working on my fork now, so naming should be fine.  I should be able to pull down my changed files one by one and add them to branches on my fork.
Thanks, Colin, G4MCF

The directory name does NOT have to be even similar. Everything is in the .git folder. If you have this problem in the future, I recommend:

Git clone the repo
Copy your changes over to the new repo folder
Git commit (make sure everything is as you want it first)

The name of the directory doesn't matter at all.
@urlgrey You may want to close this issue.


updated README.md

Simplification to the description in the README.md

Would this project be up for grabs in gsoc 2019 as well?

Hi @himanshuc3, I am not sure whether this project will be up for grabs in gsoc 2019 or not.


Update the readme for new contributors

Is your feature request related to a problem? Please describe.
I have recently added Contributing. md and Code-of-conduct. md files in my project. The links should be added in readme to redirect them to the files before they contribute to the project
Describe the solution you'd like
The links should be added in readme to redirect them to the files before they contribute to the project

Hey @kaiwalyakoparkar, I would like to add this.

Sure go for it. I'll assign it to you.

Thanks for working on it @shikharcodes


You call onDraggedColumnChange INSIDE a render -- big no no

The whole point is this is supposed to be a callback that might cause state change and have you rerender the table (basically to make column order 'controlled and rememberable and changeable').  You call it inside a render() -- big no no

OK I'll close myself -- my state should change in onDropSuccess, I get it now. I guess you could do some local recordkeeping (no setState or mobx or redux or anything in onDraggedColumnChange.  Really onDropSuccess should just pass the new column definitions ---


BUG: Do not impact limit fill price

Fix for https://github.com/quantopian/qexec/issues/2206

Coverage decreased (-0.03%) to 87.51% when pulling 7d37ecf1bd8e8e63a57b20271520dd7200ed75c4 on limit-slippage into ef598c713056060580e7faed84dd0cc0bb8fd89c on master.

Coverage decreased (-0.03%) to 87.51% when pulling 7d37ecf1bd8e8e63a57b20271520dd7200ed75c4 on limit-slippage into ef598c713056060580e7faed84dd0cc0bb8fd89c on master.

Nope, it is clear, thanks. I think this is good to merge.
Assigning @ehebert for another pair of eyes.

@jbredeche @ehebert performance looks good to me:
http://performance.dynoquant.com:8060/compareFlights?start=151&end=152


Dbg/osx 64 version issue

Checklist

[x] Used a personal fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[x] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[x] Ensured the license file is being packaged.

Awaiting resolution: https://github.com/conda-forge/status/issues/181


Feature/345 unknown issn share url

For https://github.com/antleaf/jct-project/issues/345 and https://github.com/antleaf/jct-project/issues/431#issuecomment-946694749

There was a bug in this, and I have fixed it, @anusharanganathan good for re-review


coverage.md updates

A few check marks missing for the Skender column:

LINREG returned with Slope
ZSCORE returned with Standard Deviation
LWMA is the same as WMA (duplicate, I think)
NATR returned with ATR
ADXR returned with ADX
AD is same as ADL
DMI returned with ADX
TRIX
CORREL
TR returned with ATR
HT Trendline

There’s a few others in the Skender library that aren’t in the list too, but I’m not sure if wanted to add those.  There’s so many out there, I know, it’s hard to choose and prioritize which to add to these sort of libraries.

I noticed that different TA libraries mix Population StdDev/Variance and Sample StdDev/Variance - and instead of starting an argument, I rather included both.

If I remember back to my school days, I think sampling is only used when you can’t otherwise get data on the full population.  I think most uses cases here are for a discrete known look back window, but can appreciate the option to estimate a larger population.

I also found out that people don't look 'inside' an indicator to find out what else it returns - so I plan to make all relevant returns independent classes (for example, you packaged MAPE/MAD/MSE within SMA, or TR within ATR)

Yah, some are a bit hidden in my library.  I can probably do better with documentation.  I only bundled for efficiency as they’re calculated together (one pass).

Also relevant for your library: check my validation tests (SMA_Validation.cs) and how I am calling your library to cross-validate results; As I am strict on non-nulls, I have to use a bang (!) to let your nullable results pass without null warning:
double s1 = Math.Round((double) SKsma.Last().Sma!, 7);

Yes, you’d have to deal with the null.  How are you handling these incalculable results, are you excluding, returning NaN, or just zeroing out?

Using null-forgiving operator:
https://docs.microsoft.com/en-us/dotnet/csharp/language-reference/operators/null-forgiving

Regarding list of indicators - perhaps we gang together and create one unified list of known/implemented indicators, with links to specific source files (or docs)?

Lol.  For as much fun as that sounds, I'll pass on that.  There's literally thousands of indicators out there and 10x as many really bad source site options to reference.  As you get into this more, you'll find that sources on the internet are quite unreliable.  That and there's probably sites out there already that catalog and try to define all of these.

Regarding Null values: that's what NaN (not a number) was made for. Null throws exceptions (and makes non-nullable compiler complain), zeros are actual numbers and exclusion would ignore the fact that measurement was created/calculated. NaN can stay in the data, supports all mathematical operations and serves its purpose.

We're just going to have to respectfully disagree on this one 😃; but, I do appreciate that you're considering and handling it.  You could probably have a little NullToNan() helper function to make your life easier when comparing the library output.

You do you.
There has been vast amounts written on why null was the billion dollar mistake, but to get very specific to C# coding style, Anders Hejlsberg was very clear in an interview why he is on a war path to eradicate null out from the future of C#: "50% of the bugs that people run into today, coding with C# in our platform, are probably null reference exceptions."

There has been vast amounts written on why null was the billion dollar mistake, but to get very specific to C# coding style, Anders Hejlsberg was very clear in an interview why he is on a war path to eradicate null out from the future of C#: "50% of the bugs that people run into today, coding with C# in our platform, are probably null reference exceptions."

I've seen the rhetoric on it and totally agree with the null problem, especially in C#.  I think it comes down to intentional design and handling -- if you're not handling it, it is a problem.  NaN has the same conundrum.  The big question is, how are we supposed to represent incalculable data?
I've started a learning discussion here: https://github.com/DaveSkender/Stock.Indicators/discussions/767

Math.Log(Double.NaN) == NaN
Math.Log(null) == error CS1503: Argument 1: cannot convert from '' to 'double'

Math.Log(Double.NaN) == NaN
Math.Log(null) == error CS1503: Argument 1: cannot convert from '' to 'double'

Yah, that Math library doesn't do nulls.  That is really annoying.  IMO it should work the exact same as NaN in that use case.  Most normal math, like 4*null=null, so you'd expect the same for the Math lib.


How to implement a resizable terminal?

Is the following code snippet supposed to create a resizable application? It doesn't resize itself on my terminal (Plasma Konsole), but the example applications do. I grep'd through the example code and didn't find any explicit calls to terminal.resize(terminal.size()?), so I assume the resizing must be automatic. Any idea why it doesn't work for me?
use std::io;
use termion::{
    event::Key, input::MouseTerminal, input::TermRead, raw::IntoRawMode, screen::AlternateScreen,
};
use tui::{
    backend::TermionBackend,
    //layout::{Constraint, Layout},
    style::{Color, Style},
    text::Span,
    widgets::{Block, BorderType, Borders},
    Terminal,
};

fn main() {
    // Terminal initialization
    let stdout = io::stdout().into_raw_mode().unwrap();
    let stdout = MouseTerminal::from(stdout);
    let stdout = AlternateScreen::from(stdout);
    let backend = TermionBackend::new(stdout);
    let mut terminal = Terminal::new(backend).unwrap();

    'main: loop {
        terminal
            .draw(|f| {
                let block = Block::default()
                    .border_style(Style::default().fg(Color::Green))
                    .borders(Borders::ALL)
                    .title(Span::styled(
                        "Gremlin",
                        Style::default().fg(Color::LightCyan),
                    ))
                    .border_type(BorderType::Rounded);
                f.render_widget(block.clone(), f.size());
            })
            .unwrap();
        for c in io::stdin().keys() {
            match c.unwrap() {
                Key::Ctrl('c') => break 'main,
                _ => {}
            }
        }
    }
}

I tried calling the resize method explicitly on a key press as well, but this just makes the whole screen go blank. I can provide a screen recording if necessary.

You need two things:
terminal.autoresize()?;

and optionallyasync stdin

Thanks for the reply @qiujiangkun. My issue was fixed after I removed the for loop handling user input and replacing it with code running in another thread. Doing this fixed the resizing issue and an issue where my paragraphs couldn't be scrolled.
I don't think terminal.autoresize()? is necessary as my code works without it, and the paragraph.rs example does too.


Add expectations for office hours and sprints.

Automated message from Dropbox CLA bot
@brainwane, it looks like you've already signed the Dropbox CLA. Thanks!

Merged, after taking the opportunity to update the times when folks are online.  Thanks @brainwane!


Prebuilt docker image does not work

Describe the bug
Starting from SynapseML website and launching container with a pre-built docker image, nothing appears on the localhost, I am using Ubuntu 20.04.
Container does not log anything (this is unusual) but it is up and run.
To Reproduce
Following docs try to run on terminal:
docker run -it -p 8888:8888 -e ACCEPT_EULA=yes mcr.microsoft.com/mmlspark/release

What I obtain is a bash open in a folder notebooks like:
root@c9711d3de3f8:/notebooks#

Expected behavior
As documentation says: I could run some sample notebooks at the port 8888, but nothing appears.
Info (please complete the following information):

SynapseML Version: latest on mcr.microsoft.com/mmlspark/release
OS : Ubuntu 20.04

Stacktrace
No stacktrace is available because there are no logs.
Additional context
Inside the notebooks folder there are some contents, listed here:
.
`-- features
    |-- classification
    |   |-- Classification\ -\ Adult\ Census\ with\ Vowpal\ Wabbit.ipynb
    |   |-- Classification\ -\ Adult\ Census.ipynb
    |   |-- Classification\ -\ Before\ and\ After\ SynapseML.ipynb
    |   `-- Classification\ -\ Twitter\ Sentiment\ with\ Vowpal\ Wabbit.ipynb
    |-- cognitive_services
    |   |-- CognitiveServices\ -\ Celebrity\ Quote\ Analysis.ipynb
    |   |-- CognitiveServices\ -\ Create\ a\ Multilingual\ Search\ Engine\ from\ Forms.ipynb
    |   |-- CognitiveServices\ -\ Overview.ipynb
    |   `-- CognitiveServices\ -\ Predictive\ Maintenance.ipynb
    |-- lightgbm
    |   `-- LightGBM\ -\ Overview.ipynb
    |-- onnx
    |   `-- ONNX\ -\ Inference\ on\ Spark.ipynb
    |-- opencv
    |   `-- OpenCV\ -\ Pipeline\ Image\ Transformations.ipynb
    |-- other
    |   |-- AzureSearchIndex\ -\ Met\ Artworks.ipynb
    |   |-- ConditionalKNN\ -\ Exploring\ Art\ Across\ Cultures.ipynb
    |   |-- CyberML\ -\ Anomalous\ Access\ Detection.ipynb
    |   |-- DeepLearning\ -\ BiLSTM\ Medical\ Entity\ Extraction.ipynb
    |   |-- DeepLearning\ -\ CIFAR10\ Convolutional\ Network.ipynb
    |   |-- DeepLearning\ -\ Flower\ Image\ Classification.ipynb
    |   |-- DeepLearning\ -\ Transfer\ Learning.ipynb
    |   |-- HyperParameterTuning\ -\ Fighting\ Breast\ Cancer.ipynb
    |   |-- TextAnalytics\ -\ Amazon\ Book\ Reviews\ with\ Word2Vec.ipynb
    |   `-- TextAnalytics\ -\ Amazon\ Book\ Reviews.ipynb
    |-- regression
    |   |-- Regression\ -\ Auto\ Imports.ipynb
    |   |-- Regression\ -\ Flight\ Delays\ with\ DataCleaning.ipynb
    |   |-- Regression\ -\ Flight\ Delays.ipynb
    |   `-- Regression\ -\ Vowpal\ Wabbit\ vs.\ LightGBM\ vs.\ Linear\ Regressor.ipynb
    |-- responsible_ai
    |   |-- DataBalanceAnalysis\ -\ Adult\ Census\ Income.ipynb
    |   |-- Interpretability\ -\ Explanation\ Dashboard.ipynb
    |   |-- Interpretability\ -\ Image\ Explainers.ipynb
    |   |-- Interpretability\ -\ Snow\ Leopard\ Detection.ipynb
    |   |-- Interpretability\ -\ Tabular\ SHAP\ explainer.ipynb
    |   `-- Interpretability\ -\ Text\ Explainers.ipynb
    |-- spark_serving
    |   `-- SparkServing\ -\ Deploying\ a\ Classifier.ipynb
    `-- vw
        `-- Vowpal\ Wabbit\ -\ Overview.ipynb

11 directories, 33 files

Probably this issue should be linked with the #1280, feel free to merge the issue or close this reporting this info the #1280 .

Once the docker container instance is started, run jupyter lab from the /notebooks directory and open browser to http://<IP_ADDRESS>:8888/lab on the host and you will be able to play with the notebooks.


[1.19.2] Attempting to start a Tier 3 Cold Snap Horde via commands crashed the game

trying to start a tier 3 cold snap horde via any method (snow globe or w/ commands) caused the game to instantly crash; looking at the crash report, this seems to be the result of a missing element that no null check is in place for
this crash weirdly seems to only happen sometimes
to reproduce exactly:

create a new superflat world with snow (or some sort of environment that confuses the horde?)
try to start a tier 3 CSH via commands
the game responds with an instant crash

crash report below:
crash-2022-11-19_23.11.17-server.txt

This is an interesting issue. Somehow, either the data isn't being set properly for the horde to determine who the anchor player should be, or the data is being nullified. Admittedly it is a flaw in the design to not prevent an NPE in this case, but the fact that this is null in the first place is a bit concerning. Will look into it with the steps to see if I can gather any insight, thank you for reporting!

Was able to reproduce the crash by summoning in a void world and tripping the failsafe. May be a bug with the horde lib instead. In any case, amazing find, thank you so much. Will close issue when a patch is pushed.

Version 1.8.1 uploaded to curseforge and processing now. Adds the null check which happens to be present in the tier 1 and 2 overrides, but not the tier 3 override.


Add 3 sensors for SOH, SOC, and Odometer

They show unavailable after HA restart, and reappear after receiving data once again.

Thanks so much for the PR! Two requests:

This code probably works (based on my testing of what you shared before) but is repetitious. Can you find a way to write this without repeated code? I was poking around at other core integrations to see how they do it. I'm not sure which core integrations are the best ones to draw inspiration from, but most do something like this to make sure no code is repeated. Do you want to try giving something like that a shot? I know you used the device_tracker.py from this repository as a template with Claude but I'm not sure it's the ideal model; it's probably fairly out of date in terms of Home Assistant standards. There are probably good ways to prompt Claude to do all this!
Can you also include all of the other sensors that LeafSpy exposes (except the ones that go into the device_tracker)? Taking care of the above should make this a cinch!

Oof. Ok, I can try.
Re the other sensors, which ones you mean? The attributes within the device_tracker are all that are exposed AFAIK. I know because I tried creating Quick Charge count sensors, till I found the docs saying those weren't sent to server (even if logged by Leafspy in its txt).
I didn't see many others that were too useful. I can still try, but please clarify which ones.
Here they are (page 71):
• user=xxx User ID
71
• pass=xxx Password
• DevBat=xx Phone Battery Level %
• Gids=xxx
• Lat=xxx.xxxxx
• Long=xxx.xxxx
• Elv=xxx Elevation in meters
• Seq=xx Sequence number of transfer
• Trip=xx Trip number
• odo=xxx Odometer in km
• SOC=xx.xx State of Charge
• AHr=xx.xxxx Current AHr capacity
• BatTemp=xx.x Average Battery Temperature
• Amb=xx.x Ambient Temperature
• Wpr=xx Front Wiper Status (FB)
• PlugState=x Plug State (EL)
• ChrgMode=x Charge Mode (EM)
• ChrgPwr=xxxx Charge Power in watts
• VIN=xxxxxxxxxxxxxxxx
• PwrSw=x Power Switch state 0=off 1=on
• Tunits=x Temperature Units (C/F)
• RPM=x Motor RPM
• SOH=xx.xx State of Health
• Hx=xx.xx Hx
• Speed=xx.x Speed m/sec
• BatVolts=xxx.xx Battery Voltage
• BatAmps=x.xx Battery Amps

Sorry, my bad—I forgot that I had been using device_tracker.see to spin out latitude/longitude into a separate device_tracker.
I would include all of those except for user, pass, lat, and long. (Almost all of these are already included as device_tracker attributes. Ideally, with this PR, we'll also remove all non-location-related attributes from the device_tracker, and I wouldn't want to decrease the overall functionality provided by the integration). This would be in keeping with the general approach by Home Assistant components to expose lots of entities and leave it to the user to ignore or disable the ones they don't think are useful. I could imagine a user doing something creative or useful with many of these!

Ok, it's ready. I have only been able to test using the test packets from Leaf Spy and a single car trip, but apparently everything is working fine.

Great work! Works well for me. Thanks for the legwork here. (I mean that literally, given that testing it requires getting in your car.)
A few outstanding things that I want to address before merging. Feel free to take a crack at them, or I can get to them eventually.

Whether to interpret temperatures as C or F (e.g., here) should be determined by the "Temperature unit" that LeafSpy reports. (I noticed this because my temperatures being reported were way too high because of units being incorrect.) And then we don't need temperature unit to be a dedicated sensor.
"Power switch" should be a binary_sensor with device_class running
I turned on the wiper but the status remained "unknown," not sure why. Might have to do with the decoding dictionary.
Do you know what the Leaf "Sequence number of transfer" is? It looks like just an integer that increments by 1 periodically. The LeafSpy documentation isn't much help. We might not need this one.
It would definitely good to address the problem where the entities don't restore after a restart, so that people could depend on these entities to show their current battery status, for example. I took a crack at this but couldn't make it work. I see you already posted about this in the HA dev-support Discord channel. Hopefully someone chimes in! (Eventually it might also be good to see if anyone there wants to look over this integration in general to make sure we're doing things basically right.)

Great! I'll test this later today, but it looks good. Thanks for your thoughts re: the wiper sensor and the sequence number.
The reason I want to get all these fixes done is that, with the removal of the attributes, this will be a breaking change for the (tens of?) integration users. So I am hesitant to merge into the main branch or make a release until it's totally ready! But if you want to try to do the restoration work in a second PR, I get that. Once I can test this and confirm that the new changes work, I'll merge this PR into a sensor_entities branch that I just made.
(By the way—and this is maybe a conversation to save for that second PR—in looking through the branches just now, I see that the original integration author @jesserockz had been working in a separate branch on sensor entities, but didn't finish the work. Someone reported "hitting several issues immediately" with those changes, so your PR is probably farther along. I haven't tested his code or even noticed it until just now. But you could perhaps look to the code in that branch to see if the restoration functionality works.)

Thanks!
No worries, I understand and you're right. Tbh I don't know what's good practice in dev in Github, so happy to go along with your call.
I will have a look at that other PR, but tbh looking at other code is not super helpful to me personally, as I cannot reproduce or see what is it exactly that makes it work. But yeah I can provide it to the AI and ask to use the key points. Will work on that when I can during the next few days and report on progress.

Awesome, thanks! Yeah, how to handle partially-complete code is a judgment call. This is a relatively sleepy HACS integration, so people are probably comfortable with some measure of experimentation, but I'd like to have stable sensors before I push the release out to users (with a big "breaking change" warning).
For the sensors, you could also try testing out the branch and seeing if the restoration works!


walk(Array, )

In addition to walk(String, ...) it would be feasible to have walk_many(Array, ...) to merge the results of walking across multiple sources. This would ease honoring globing arguments in ndoc and hopefully other tools.

I don't think it should be a library feature. I believe library should stay as tiny as possible. walk_many is dead simple and can be implemented right in place:
// walk_many(Array, ...)
function walk_many(paths, pattern, iterator, callback) {
  function next(err) {
    var path = paths.shift();

    if (err || !path) {
      callback(err);
      return;
    }

    fstools.walk(path, pattern, iterator, next);
  };

  next();
}

This should go to wiki, after fixing the wrong assumption that !path denotes the end of array. Arrays can freely contain null, '', 0,false -- any falsy values.
Thanks for feedback

Any extentions of code/wiki/examples in libraries expects, that we have at least 2 strong use cases from real life. In other case we can fall into to writing useless frameworks instead of doing really significant things.
Currently, there is only 1 use case, so nothing to discuss.

@dvv Yes, I absoutey agree about the check, the only thing is that I was showing this example from the real place, where I'm sure about what is going to be in that array ;))

Updated code sample


Update sbt-coursier to 2.0.0-RC3

Updates io.get-coursier:sbt-coursier from 2.0.0-RC2-1 to 2.0.0-RC3.
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention @scala-steward in the comments below.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [{ groupId = "io.get-coursier", artifactId = "sbt-coursier" }]

labels: semver-pre-release

Running into https://github.com/coursier/sbt-coursier/pull/113.


remove getAsTag as thats obsolete with the new usernames.

Is the username rollout finished though? What happens in this case if the user still has a tag?

Yeah you'll want a misc util method for friendlyName() that gets the tag if discrim > 0 or just the username otherwise

Discord will be automatically changing tags to usernames on March 4th from what i've heard, we could wait until then?

Usernames are now fully migrated, we could move ahead with this PR 👀


Build language information graph

Goal
We want to use a tree-structured graph that contains languages and their linguistic and geographic relations. We hypothesize that this improves the performance of the GNN-based edge prediction model for dictionary creation.
Tasks

[ ] see A.1.4 in proposal
[ ] acquire and parse language information in Ethnologue
[ ] acquire and parse language information in WALS

Closed because completion on time is not realistic.


Generic Reusable Module as the Base Module

Writing a new module requires a reasonable amount of work and knowledge of Mill internals and API. So is it possible to have a more generic module where one can:

implement a method to provide the compile command
similarly for tests and
other tasks

If command-line tools are invoked, OS-specific command list if there is a variation. Source lists, dir lists, lib paths, etc. can be made available with OS-specific file separators so more generic command strings can be written. Also, library-based/API-based tools can be evoked.
This will bring down the barrier to add new test runners, code coverage tools and compilers where the user specifies the bear minimal boilerplate to make it work without the need of new plugins or modules to be written.
Language-specific modules just "inject" the bare minimal to compiler and tools to work. The majority of the code in these modules ideally should be just these command lists, for clarity, with the plumbing handled elsewhere.

@lihaoyi Let me know what additional information you might want.
E.g. I want to set up TestNG testing without writing a plugin.

@sirinath In the first comment you make a very abstract claim which I think @lihaoyi isn't able to reconstruct. Me neither. In fact, writing new modules is very easy and doesn't require any deep knowledge of mill besides the documentation. So I think you need to be more specific about your issues. Probably you want to ask in the Gitter channel first.
Setting up TestNG is documented (http://www.lihaoyi.com/mill/page/contrib-modules.html#testng). I think you also need to add the testng contrib module to the ivyDeps though.

When looking at https://github.com/lihaoyi/mill/blob/3f1f1856c7d9af1e8d269d9dd80a2a8cf0f5f243/scalalib/src/JavaModule.scala what I was expecting is the module will mainly just have (1) build of the classpath (2) javac command (3) Javadoc commands (4) Jar commands (5) dependency downloading (6) testing, in a very simple way. Essentially these are there but a lot of the plumbing is also exposed.

But it isn't that simple and if you need to support more complicated cases, your have an easy way to re-plumb exactly what you want. Also, in contrary to your implication, the complexity is not smaller in other tools. E.g. in Maven you also have much more steps than only the ones you mentioned, but still you'll have a hard time to adapt the workflow. The thing is, if you just want to replace the compiler in mill, just override the compile target. If you want to override the packaging, override jar step, and so on. It's the easiest experience I've ever seen under all build tools targeting the JVM.

OK. This is the 1st time I have looked into the code of any Build tool. Anyway, what I felt is that some of the code here can be refactored into traits leaving just the Java-specific stuff in the Java module. E.g. dependency management, managing classpath, jars, etc. may be used by other JVM languages. So they can be in smaller sized traits. Also perhaps there can be an abstract module leaving just the compile and language-specific items as abstract and finally implemented in Java module.

In general, the issue tracker is for issues, not for questions. It’s great to discuss these things, but such discussion should go in the gitter channel


Mapleader support based on the prototype of a Vim script expressions evaluator

Currently only very simple let and echo commands are supported. Using the mapleader value in mappings is coming next.

I haven't done any plugin development before. I'm wondering if it would be trivial to add a rudimentary ":command" method that would allow to alias ":action intellijinternalcommands" to be abbreviated to a shorter name? Thanks!

I just update IdeaVim to version 4.1 and so happy with mapleader support. But went I use my old mapleader settings, I still can't use space like leader.
let mapleader = "\<Space>"
nnoremap <silent> <Leader>i :action ReformatCode<CR>

@tthanh Please file a bug about it here.

To use a space as a mapleader you can simply do:
let mapleader = " "

I can't seem to get the backslash mapleader to work.  I have the following currently:
let mapleader="\\"

let mapleader=" " didn't work for me. I had to do let mapleader=<Space> for it to recognize space as my leader.

What is up to date way to use space key as a leader?
Tried both
let mapleader=<Space>
let mapleader=" "
On lastest IDEA and IdeaVim, and seems like both are not working...

Hi
it is still let mapleader = " "
You may try noremap <SPACE> <Nop> as well to disable any space actions


Update 03_one-to-many.md

Fixed twill command to create module in the One to Many relations docs

Description
Changed
php artisan twill:module
to
php artisan twill:make:module
in the one to many relation docs

Related Issues

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Bug: Bots stopped working after last update

Describe The Bug
Bots are no longer executing manually or in automations
To Reproduce
Click switch, or try running a test automation
Expected behavior
Bot executes
Relevant log output
[17/10/2022, 14:04:54] [Homebridge UI] [@switchbot/homebridge-switchbot] Terminating child process...
[17/10/2022, 14:04:54] [Homebridge UI] [@switchbot/homebridge-switchbot] Child process ended

When I try to click on the switches manually in the Home App, I am no longer seeing any communications to Homebridge.

I did update them to BLE/Open API with the latest update and rebooted the server.

Config for homebridge-switchbot
"name": "SwitchBot",
            "credentials": {
                "token": “XXX”,
                "notice": "Keep your token a secret!"
             I would guess there is a log that says you don't have a secret. you need to input that from the SwitchBot App.

@donavanbecker Nevermind, figured it out. It's now working again. Thanks.


Re-enable link detection (fixes #34026)

This change brings back a handy feature: clickable file links for stack traces in the Debug Console and Exception Widget.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: mymikemiller sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.

Hi thanks for this PR. However I am not so happy how this is done.
In a perfect world the code should be shared across multiple locations: debug console, exception widget and so on. And here there does not seem to be any reuse and we are just creating html elements on the fly.
That feature is not so straight forward for Pull Requests that is why it does not have a label "Help Wanted".
A proper solution would requrire more refactoring and rewriting which I currently do not have time for.
Thanks again for the PR and next time before submitting a PR starting a discussion is usually best

I understand, and thanks for taking a look at the code! This is my first attempt at contributing to an open source project; I guess I don't quite know the ropes yet.
From what I can see, the handleLinks function is only used in the two places you mentioned, and both of the callers have special logic depending on whether the returned value is a string (i.e. nothing was changed) or an HTMLElement (links were added). Is there a reason not to have handleLinks always return its result wrapped in a span element, even if no links were added? That way, the line-splitting logic I added to exceptionWidget could be put into handleLinks (where it probably belonged in the first place), both callers could be simplified and future callers wouldn't have to handle the results differently depending on the return type.
Would you mind if I made these changes and added them to the PR? I know it's not the proper solution, but I think it would make users happy until you have time for the refactor.
Let me know if you'd be willing to take a look at an updated PR, otherwise I'll wait patiently for the official fix from the pros.

I will take a look at the updated PR but I do not guarantee we will merge it in.
Thanks

I understand if you choose not to merge my changes. I mostly did it for my own benefit, as clickable links in stack traces make my debugging a lot easier.
My recent commit also fixes another issue I spotted. Previously (well, if execution could get past the "if (!resource)" check that currently always fails), if anyone ever added another regex to FILE_LOCATION_PATTERNS, and multiple patterns found matches, the text would be duplicated (once for each pattern that found a match) in the returned HTMLElement. My fix uses recursion to run handleLinks only on the parts of the text that didn't match the pattern.


allowMultipleFiles does not let you pick multiple files

Using the mobile/tablet app, I have Xrm.Device.pickFile working fine for a single file, but when I use the pickFileOptions for allowMultipleFiles, I cannot choose multiple files (I can still only choose I file).
Code
var pickFileOptions = {};
pickFileOptions.allowMultipleFiles = true;
Xrm.Device.pickFile(pickFileOptions).then( ...
Please note that you can pick multiple files if you use the web client.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 79ed47be-b625-a433-4456-3251de4bf7c6
Version Independent ID: 16728e22-98b9-6ce3-bdbc-5d68f50cfb20
Content: pickFile - PowerApps
Content Source: powerapps-docs/developer/model-driven-apps/clientapi/reference/Xrm-Device/pickFile.md
Service: powerapps
GitHub Login: @KumarVivek
Microsoft Alias: kvivek

@alano444 Can you confirm if you are still facing the issue.

@alano444
Thanks for contacting us. As we haven’t heard back from you, I am closing this issue. If you need further help, please reopen the issue or open a new issue.


Replace synchronized blocks with ReentrantLocks for virtual thread support

Replace synchronized methods and blocks with ReentrantLocks in a few classes in Spring Functions Catalog to improve compatibility with virtual threads. This changes the synchronization mechanism in:
CassandraConsumerConfiguration.PayloadToMatrixTransformer
InMemoryTraceRepository
The change helps avoid blocking virtual threads when using Spring Functions Catalog in Project Loom environments while maintaining thread safety.

Let’s see if such an action is really necessary is those cases: https://mikemybytes.com/2024/02/28/curiosities-of-java-virtual-threads-pinning-with-synchronized/! In other words: if there is really no blocking operation inside that synchronized, no reason to change it. Plus it looks like some changes are coming to Java down the road : https://openjdk.org/jeps/491

@artembilan Thank you very much for all the valuable information you provided. The links you provided contain really great information.
However, I believe that ReentrantLock offers us more flexibility. Additionally, ReentrantLock provides features like interruptible lock acquisition, timed lock attempts, and finer control with the Condition API, which are not available with synchronized. Of course, the current code doesn't involve very complex operations, but I don't think ReentrantLock would introduce significant overhead either. Therefore, I think we could implement this improvement instead of using synchronized. However, if you disagree, I can close the pull request.

Sure! I’ll give it a second look when back from vacation next week .

@artembilan I've applied the changes you recommended. And thank you for your guidance.

All good, but I cannot merge it yet until I cut 5.0.x branch. We are planning to release 5.1.0 soon enough. Thank you!

Thank you very much for everything. Best regards.

@omercelikceng ,
I've changed my mind.
Since it looks like we are going to have 5.0.2 soon enough, this is a good candidate to be included there having its only internal nature.
Thank you and looking forward for more!


Use nvm to install node in docker image

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

https://github.com/awslabs/aws-c-common/pull/518


Recent Version Fails Due to Missing Modules That Exist

Build/Submit details page URL
No response
Summary
I've been trying to update our app over-the-air using the same process I used a month ago. I have set up the app to receive updates and went through the standard process.  Each time I get to eas update --channel production --message "in quotes"
I get this error that stops the whole process:
Error: Cannot find module 'minimatch'
This module does exist, but it is not at ./node_modules/minimatch
If I run npm ls minimatch in the node_modules folder of the project, I find three instances of this module.
I assume that Minimatch is typically installed as a dependency in the "node_modules" folder of the project. I use npm to install dependencies.
To test my "theory", I had a look at my package-lock.json file when this update worked a month ago, and minimatch did exist at ./node_modules/minimatch
I don't get asked where these modules should be stored as a user.  But maybe the update can make a more thorough look for the module.  If not, we are dependent, I guess, on npm to install it correctly.
Managed or bare?
Managed
Environment
expo-env-info 1.0.5 environment info:
System:
OS: macOS 13.4.1
Shell: 5.9 - /bin/zsh
Binaries:
Node: 18.16.0 - ~/.nvm/versions/node/v18.16.0/bin/node
Yarn: 1.22.19 - ~/.nvm/versions/node/v18.16.0/bin/yarn
npm: 9.6.7 - ~/.nvm/versions/node/v18.16.0/bin/npm
SDKs:
iOS SDK:
Platforms: DriverKit 22.4, iOS 16.4, macOS 13.3, tvOS 16.4, watchOS 9.4
IDEs:
Xcode: 14.3.1/14E300c - /usr/bin/xcodebuild
npmPackages:
expo: ^48.0.0 => 48.0.19
react: 18.2.0 => 18.2.0
react-native: 0.71.8 => 0.71.8
npmGlobalPackages:
eas-cli: 3.15.0
expo-cli: 6.3.8
Expo Workflow: managed
✔ Check package.json for common issues
✔ Validate global prerequisites versions
✔ Validate Expo Config
✔ Check for conflicting global packages in project
✔ Check for incompatible packages
✔ Check compatible dependency versions for the installed Expo SDK
✔ Verify prebuild support package versions are compatible
Didn't find any issues with the project!
Error output
No response
Reproducible demo or steps to reproduce from a blank project
Finish a blank project, check package-lock.json for the minimatch module folder..if it exists, first run
npm ls minimatch
to ensure the module exists somewhere else, like:
/node_modules//node_modules/minimatch
if it does, delete /node_modules/minimatch
then try to update..you'll get an error.

@allenweiss just to sanity check before we debug any further, let's make sure your project conforms to Node.js' module resolution algorithm. Could you elaborate on how minimatch is referenced, and what the output of npm ls minimatch is?
Example with expected error
In the case where you reference minimatch directly in your project:
// App.js
import minimatch from 'minimatch';

If npm ls minimatch tells you minimatch is installed at ./node_modules/foo-module/node_modules/minimatch and nowhere else, your error is expected. In our example, only foo-module uses minimatch and we'll only ever look under ./node_modules/foo-module/node_modules when resolving dependencies declared by the foo-module.
If your project directly imports minimatch, the standard module resolution will look for it in ./node_modules/minimatch and recurse up your directory if it is not found. In this case, you will need to declare minimatch in your package.json main dependencies and run npm install (or yarn if you use that)

Thank you...we do not directly import minimatch and never have.  I was just using npm ls minimatch in my investigation after we started getting an error.

Thanks for the info @allenweiss . To further debug, could you try the following:

run rm -rf node_modules
npm install your dependencies again. This should ensure your dependencies are consistent with your lock file.
run eas update. If you get the same error, please report back with the module that is not found.
Attach your package-lock.json and your package.json. feel free to remove any sensitive information from package.json, I'm only interested in the dependencies you declare.
Report output of npm ls <missing-module> (assuming it is something other than the minimatch example)

before running npm install, should I delete package-lock.json?  Also, I was concerned about doing this before because I thought if anything changed, I shouldn't run an update (instead just do the update as a new store submission.)

Ok...I didn't delete, ran install, and then eas update...got the same error (not finding minimatch).   Here are the files you asked for.
Archive.zip

HI @quinlanj.  Any update on this?  I need to figure out how to do an update else I need to submit this to the stores tomorrow because I use this app in a class I teach that starts on Thursday.

HI @quinlanj...I had to submit an update to the stores.  But just now I tried to do an over-the-air update and got the same error as I brought up before.  Also, I updated eas-cli to the most recent version.

hi @allenweiss , I'm very sorry for the late reply and any inconveniences to your class. I was able to reproduce your issue without manually changing the lock file. We use the metro bundler to package our code, so I'll need to confirm a couple things on our end and then look into filing an issue upstream in their project.
In order to unblock you in the meantime, you can run npm dedupe. It should deduplicate nested dependencies like in node_modules/foo/node_modules/minimatch and move them to the top level if possible. For more details, please read the repro details section
repro details
I repro'ed your issue by doing the following:

declaring minimatch 9 in the main package dependencies, then npm install
minimatch 9 should be in node_modules/minimatch and minimatch 3 used by the other dependencies will be nested in their respective directories like node_modules/foo/node_modules/minimatch
removing minimatch 9, npm installing again
minimatch should be gone from node_modules/minimatch but still present in the nested directories. This is not the most efficient way to declare dependencies, but it is still a valid lock file.

Thank you, @quinlanj....I'll try your suggestions.

I've filed an issue upstream with metro: https://github.com/facebook/metro/issues/1039

Update: this issue persists in SDK 48 and 49, but it should be fixed in the upcoming SDK 50 - I've confirmed this with the repro steps mentioned above . SDK 50 is slated to be released in a couple months.
For folks that are encountering this issue in 48/49, you can unblock yourselves by running npm dedupe.  If anyone encounters a similar issue in SDK 50, please file another issue.


[Feature] Add JS library to encode/decode JWT within Appsmith client

Summary
Being able to encode/decode JWT within an Appsmith application will be useful for a lot of users
Motivation
At times, we want to send some JWT encoded information to backend APIs. Having a way to easily perform this encoding/decoding within Appsmith will make it easier for users to be able to do this.

Related to #2430

Will be possible after the release of Custom JS Libs https://github.com/appsmithorg/appsmith/issues/2430


Support MerkleSet definitions via CLI .inputs file

We should implement support for the MerkleSet data structure in the CLI .inputs file.  The CLI currently supports MerkleTree and SparseMerkleTree which is probably sufficient for now but MerkleSet will be needed in the future.

Closed by #1072.


Building the endpoints 3/5 -> /experiences

/experiences path and query parameters

/experiences Parameters
Path Parameters

Parameter
Required/Optional
Description
Type

{ experienceId }
integer
required
The value for the Experiences object you want to look up.

Query Parameters /experiences

Parameter
Required/Optional
Description
Type

company
string
optional
The name of the company I work(ed) for.

position
string
optional
The name of the position I took during the company.

dateStarted
string
optional
The starting date in the [ month, year ] format.

dateEnded
string
required
The ending date in the [ month, year ] format.

image
string
required
The image of the company I work(ed) for.


Add validation for ConcurrentSyncs field in ControllerConfiguration of GCM Controllers

How to categorize this PR?

/area control-plane
/kind bug
What this PR does / why we need it:
This PR adds validation for ConcurrentSyncs fields in ControllerConfiguration of GCM Controllers.
Which issue(s) this PR fixes:
Fixes #5758
Special notes for your reviewer:
Release note:

NONE

I am not sure if we want to add validation for all controllers now. Once it is confirmed, I will add unit tests accordingly.

I am not sure if we want to add validation for all controllers now. Once it is confirmed, I will add unit tests accordingly.

It's better to add for all, we will be needing this validation even though this will not occur very often.

/test pull-gardener-e2e-kind

Do we really want to enforce that concurrentSyncs > 0 for all the controllers? This way, we cannot disable individual controllers anymore, right? Wouldn't the better approach be to make the concurrentSyncs field optional and default it if unset (nil)?

So drop the validation functions templates, as well? we can add them once there is something we want to validate, or do we just keep them empty?

/title Make ConcurrentSyncs field in ControllerConfiguration of GCM Controllers optional and Default them

/cla

/lgtm
/approve


Support for resource value files

Add the --res-values options to specify resource value files to copy to src/main/res/values in the dist directory. This allows customizing styles.xml and colors.xml, for example.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

2 of 2 (100.0%)  changed or added relevant lines in 1 file are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage decreased (-0.01%) to 60.802%

Files with Coverage Reduction
New Missed Lines
%

pythonforandroid/pythonpackage.py
1
57.23%

Totals

Change from base Build<PHONE_NUMBER>:
-0.01%

Covered Lines:
4507

Relevant Lines:
6854

💛  - Coveralls

LGTM!

Thanks! I tagged this as v2022.09.04-endless11 so it could be used in the android app.


Updated hp-ilo

Please check and resolv the conflicts!

Can you please help me?
I can't find any problems?! I only changed versiondate and version number.

fixed ... in the meantime the date ws remoed from repo file ...


Ctrl-L not working in Home screen

The Ctrl-L shortcut seems to work everywhere except the Home screen.
Desktop (please complete the following information):

OS Version: [e.g. Windows 10 20H2
App version: <IP_ADDRESS>

I'll fix

@KAMiKAZOW This issue should be resolved with #3473.


Azure Event Hub - The partitionId (1) set on sendBatch does not match the partitionId (1) set when creating the batch

Package Name:  @azure/event-hubs
Package Version:  5.3.1
Operating system: Win

version: 10

Describe the bug
When specifying an explicit and same partition id in the create batch and in the send batch methods I'm getting the following error:
The partitionId (1) set on sendBatch does not match the partitionId (1) set when creating the batch
To Reproduce
Steps to reproduce the behavior:
`const options = {partitionId: 1};
const eventDataBatch = await producerClient.createBatch(options);
while (numberOfEventsToSend > 0) {
let wasAdded = eventDataBatch.tryAdd({ body: event});
if (!wasAdded) {
break;
}
numberOfEventsToSend--;
}
await producerClient.sendBatch(eventDataBatch, options);
await producerClient.close();
`
Expected behavior
Sends the event in the indicated partition id

partitionId should be string and not number...

partitionId should be string and not number...


[WIP] Externalize the extension configuration templates

Building on the overlay-support branch.
There's a lot of work left to do on this but I wanted to get this out early with just one template done to work out the design issues.

[ ] default extension template path as per https://github.com/ehazlett/interlock/blob/overlay-support/config/utils.go#L8
[ ] externalize all templates
[ ] docs

I'm testing by building a Swarm with swarmer and this
docker run -it \
  --name dev \
  --net mynetwork \
  --publish 8080:8080 \
  --volume $(pwd)/config.toml:/bin/config.toml \
  --volume $(pwd)/docs/examples/nginx/nginx.conf.template:/etc/interlock/nginx.conf.template \
  --volume $DOCKER_CERT_PATH:/etc/docker/ \
  --volume `pwd`:/go/src/github.com/ehazlett/interlock \
  golang:1.6-wheezy \
  /bin/bash

cd src/github.com/ehazlett/interlock/
make build
cmd/interlock/interlock -D run

Closes #91

Yuck. I must have messed up my branch off of the overlay-support branch. I'll try to clean up the commits.

I just need to PR to the overlay-support branch rather than master, see https://github.com/ehazlett/interlock/pull/104 for a cleaner version of this PR.


pvc -> pv mismatch when bindng

Now, moving from dev to staging got into the following issue:
$ kubectl get pv core-volume
NAME          CAPACITY   ACCESS MODES   RECLAIM POLICY   STATUS   CLAIM                        STORAGECLASS   REASON   AGE
core-volume   10Gi       RWO            Retain           Bound    core-dump/host-storage-pvc   hostclass               36m
$ kubectl get pv host-volume
NAME          CAPACITY   ACCESS MODES   RECLAIM POLICY   STATUS      CLAIM   STORAGECLASS   REASON   AGE
host-volume   1Gi        RWO            Retain           Available           hostclass               16m
$ kubectl get pvc -n core-dump
NAME               STATUS    VOLUME        CAPACITY   ACCESS MODES   STORAGECLASS   AGE
core-storage-pvc   Pending                                           hostclass      7m40s
host-storage-pvc   Bound     core-volume   10Gi       RWO            hostclass      37m

As you can see the host-storage-pvc is bound to core-volume pv, which makes it impossible for core-storage-pvc to bind (1Gi vs 10Gi)
Looks like you either need to pre-bind or use some other creative idea.
Will think about something, but I don't have anything rn.

That's a nasty one that was missed because the default is to create the core directory as a sub-folder of the host directory.
Looking at the docs this can be fixed with a reservation using a claimRef.
diff --git a/charts/core-dump-handler/templates/core-storage-pv.yaml b/charts/core-dump-handler/templates/core-storage-pv.yaml
index a89c5a7..c8ed150 100644
--- a/charts/core-dump-handler/templates/core-storage-pv.yaml
+++ b/charts/core-dump-handler/templates/core-storage-pv.yaml
@@ -6,6 +6,9 @@ metadata:
     type: local
 spec:
   storageClassName: {{ .Values.storageClass }}
+  claimRef:
+    name: core-storage-pvc
+    namespace: {{ .Release.Namespace }}
   capacity:
     storage: {{ .Values.coreStorage }}
   accessModes:
diff --git a/charts/core-dump-handler/templates/host-storage-pv.yaml b/charts/core-dump-handler/templates/host-storage-pv.yaml
index 840a4fd..2e69897 100644
--- a/charts/core-dump-handler/templates/host-storage-pv.yaml
+++ b/charts/core-dump-handler/templates/host-storage-pv.yaml
@@ -6,6 +6,9 @@ metadata:
     type: local
 spec:
   storageClassName: {{ .Values.storageClass }}
+  claimRef:
+    name: host-storage-pvc
+    namespace: {{ .Release.Namespace }}
   capacity:
     storage: {{ .Values.hostStorage }}
   accessModes:

This now gives the intended result
$ kubectl get pv core-volume
NAME          CAPACITY   ACCESS MODES   RECLAIM POLICY   STATUS   CLAIM                      STORAGECLASS   REASON   AGE
core-volume   10Gi       RWO            Retain           Bound    observe/core-storage-pvc   hostclass               6m32s

$ kubectl get pv host-volume
NAME          CAPACITY   ACCESS MODES   RECLAIM POLICY   STATUS   CLAIM                      STORAGECLASS   REASON   AGE
host-volume   1Gi        RWO            Retain           Bound    observe/host-storage-pvc   hostclass               6m42s

$ kubectl get pvc -n observe
NAME               STATUS   VOLUME        CAPACITY   ACCESS MODES   STORAGECLASS   AGE
core-storage-pvc   Bound    core-volume   10Gi       RWO            hostclass      6m55s
host-storage-pvc   Bound    host-volume   1Gi        RWO            hostclass      6m55s

And passes the integration tests.
.Release.namespace is picked up by helm template so it should work for you.
If your in agreement I'll commit and release.

Added to this branch https://github.com/IBM/core-dump-handler/tree/claim-ref

I think claimRef should work, yeah. Thanks!
Will test it later though, doing some different stuff rn.

Yup, works fine

Hey @pkit
Released in v8.1.1

Thanks!


Error handling for rulechecker

We still miss a small number of rulechecker submissions in some cases - for PSQL insertion. Need to figure out how to gracefully catch if it isn't inserted.

Need to create a generic function in pyclowder to handle this instead of in rulechecker.


Fix verify-previous-version check

Missing squared brackets around all "if" conditions.

/test 4.15-openshift-e2e

/lgtm


add domain student.tajen.edu.tw

add domain student.tajen.edu.tw
The website of the school is located at  https://www.tajen.edu.tw/
The introduction of the school also can be found at  https://en.wikipedia.org/wiki/Tajen_University

@chun0826 Pull request merged. Thank you!


Fix #define for jnr-gen

The uint32_t define constants are broken in JNRGen because they are cast and currently any casts are ignored.
This isn't critical cause Kgpu doesn't use those bitflag values in the Wgpu header (they are just defined in kgpu-core/common

jnr-gen is not longer used 😄


Requirement for anyio module

It seems like there is a minimum version for anyio required. At least on my current version 2.2.0 with Python 3.9.7 an error occurred:
"AttributeError: module 'anyio' has no attribute 'CancelScope'"
With version 4.1.0 it works.

anyio is no direct dependency of this library. httpx has this dependency, but it should be new enough.
Github actions run on 3.8, 3.9, 3.10, 3.11 and 3.12 without issues as well.
Can you pinpoint why you have the older version on your system?

I just have an older python installation - never updated in the last two years. It seems like installing httpx 0.26.0 did not update anyio. The problem might even be on httpcore (1.0.3) which has not defined the dependency to anyio with versions higher than 3.0.
File "/Users/xxx/opt/anaconda3/lib/python3.9/site-packages/httpcore/_synchronization.py", line 207, in init
self._anyio_shield = anyio.CancelScope(shield=True)
AttributeError: module 'anyio' has no attribute 'CancelScope'
Therefore, you could just close the issue.


Suggestion: Crafting low-tier affixes into higher-tier ones

Hello Shadows-of-Fire,
I noticed that there is an option to convert higher rarity affix shards into lower rarity ones. I was wondering if you've ever considered adding a feature to convert lower tier affixes into higher tier ones? It would definitely need to be much more demanding than when downgrading, but I think it could give lower rarity items (or to be more precise, affixes) more use.
On another note, I am really enjoying your mod! It adds many new and entertaining things to the mix. Although I am using all the modules, I especially love the Deadly one. I have personally made a small modpack based on Apotheosis and other mods like Project MMO and The Gems Project, and it is a blast to play.

you could probably achieve that with some crafting recipe editing shenanigans via datapack or crafttweaker I would think? so you can salvage lower shards into higher shards in their empty state.
but I guess you probably mean combining like shards as if they were enchantments, right? if so, I second this suggestion.

you could probably achieve that with some crafting recipe editing shenanigans via datapack or crafttweaker I would think? so you can salvage lower shards into higher shards in their empty state.
but I guess you probably mean combining like shards as if they were enchantments, right? if so, I second this suggestion.

Thanks for the comment! I wasn't necessarily referring to combining them like enchantments, but that could definitely be an option. Given the extra features related to spawners and enchantments that boost experience and make it easy to run exp farms, I do think that experience shouldn't be the only requirement to get higher grade shards.
Also, thanks for the suggestion, I might try creating a crafting recipe for it on my own!

This is not realistically something I want to support by default - the management of affixes is meant to be difficult (and even more so for the higher rarities).

WELP, datapack it is... ish.


adduser fails for Ubuntu 22.04

For Ubunut 22.04 this command:
  runChrootCommand "adduser $BREATH_USER && usermod -aG sudo $BREATH_USER"

fails, saying something like command not found.
Using the full path: /usr/sbin/adduser seems to work.

What exactly are you trying to do?


i18n migration collation. Make it utf8_bin instead of utf8_unicode_ci

It's more of a suggestion/question.
When you create tables source_mesage and message with Yii migration the default collation used is utf8_unicode_ci
if ($this->db->driverName === 'mysql') {
            $tableOptions = 'CHARACTER SET utf8 COLLATE utf8_unicode_ci ENGINE=InnoDB';
        }

MySQL treats strings as accent insensitive. "Revolución" is same as "Revolucion".
Now in Yii2 isset in array is used to find translations.

if (isset($this->_messages[$key][$message]) && $this->_messages[$key][$message] !== '') {
            return $this->_messages[$key][$message];
        }

Inconsistency, what happened to me is that in my back office there is a translation for "Revolución", cause MySQL returned results for it. But in front office, Yii fails to source language cause of php isset.
My question/proposition is to change the collation to utf8_bin on source_message.message. So in the back office, there won't be any misleading translation loaded.
Additional info

Q
A

Yii version
2.0.12?

PHP version

Operating system

That's just a default. You can use whatever collation you want for your app.
I can't really see the need to change this on framework level.

ofc I can use my collation and I already use.
I disagree.

By changing migration you don't change the framework.
It makes more sense and a time saver for others.

The default doesn't mean best. I personally lost some time wondering why some translations were not loaded.

Using utf8_bin should be done ONLY when you the developer knowingly decide so. It has many disadvantages and is not suitable as a default value.
Do you even know all the disadavantages/differences?

Well - I read now that you mean to change only the migration of i18n. Thet's different thing. At first I understood you want to change the migration template.
In this case your proposal is not all bad and utf8_bin seems to suit there well.
Sorry for the misunderstanding.

Right, no problem. The issue is that php isset in array is case sensitive, when getting the translation.
So there is no actual use of utf8_unicode_ci.


StringEnumConverter does not work in "5.0.0-rc5"

Hello, I've been testing the latest release candidate version "5.0.0-rc4" and "5.0.0-rc5", and I have detected a bug.
In "rc5" the string enum conversion to string does not work.
I have the same conversion configuration in ConfigureServices:

Result schema in rc4:

Result schema in rc5:

As System.Text.Json is now the default serializer for ASP.NET Core, Swashbuckle honors it's options/attributes by default as well. To honor the Newtonsoft settings/attributes instead, you need to install a separate Swashbuckle package and opt-in.

I have the same problem. The difference is I have separate property attribute for viewmodel [JsonConverter(typeof(StringEnumConverter))]
And 'services.AddSwaggerGenNewtonsoftSupport();' is used

Did you call services.AddSwaggerGenNewtonsoftSupport() after you call services.AddSwaggerGen()? I've been able to get mine to work, but am experiencing some strange issues where camel casing isn't respected for enum values, even though I'm using the camel casing strategy via this:
builder.AddNewtonsoftJson(options =>
{
	var converter = new StringEnumConverter(namingStrategy: new CamelCaseNamingStrategy());
	options.SerializerSettings.Converters.Add(converter);
});

I'm still investigating why that might be the case...

Yes, the code:
services.AddSwaggerGen(c =>
            {
                c.CustomSchemaIds(r => r.FullName);
            });
            services.AddSwaggerGenNewtonsoftSupport();

and I don't use camelCase for enums, but reneral camel-case converter
.AddNewtonsoftJson(opt =>
                {
                    var resolver = new CamelCasePropertyNamesContractResolver();
                    resolver.NamingStrategy.ProcessDictionaryKeys = true;
                    opt.SerializerSettings.ContractResolver = resolver;
                });

Hi @josalper , @Transmuter
Swashbuckle.AspNetCore 5.0.0 stable version was released several hours ago. I tested this issue and it works for me.
Thanks @domaindrivendev !

Thank you for fixes! Yes, it works for
.AddNewtonsoftJson( { options.SerializerSettings.Converters.Add(new StringEnumConverter()); })
Unfortunately, property attribute  [JsonConverter(typeof(StringEnumConverter))] still has problem

While global converters (i.e. via options) and type-level converters (i.e. via JsonConverter on the enum definition) will work, you're correct that the property-level attribute will not work. As it happens, this would be a non-trivial feature to support.
With that said, I can't think of too many use cases where you would want to serialize an enum one way for a certain property and a different way for another. Perhaps you could elaborate on your particular use case. If nothing else, it would help me understand your needs a little better and allow me to prioritize making the tricky enhancement accordingly.


Upgrade the minimum php version to 8.0 for config.

fix https://github.com/hyperf/hyperf/issues/4238


Minor improvements

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 100.00%. Comparing base (35faae4) to head (0a31752).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #409   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files          115       115
  Lines         3430      3430
  Branches       277       277
=========================================
  Hits          3430      3430

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

🚨 Try these New Features:

Flaky Tests Detection - Detect and resolve failed and flaky tests


Md3 addition

First pull request...

Give me a call to discuss if you like. This Github review process is new to me too, so we can figure it out together!

And I meant to say, WOW, you've done heaps in a short time. Looking forward to merging in and having a closer look.
Neil.

I ended up merging into a feature branch. There were other changes I had to make to get things building under Linux, and so I could execute tests without visual studio, so I recommend you pull those changes back into your fork.

I was looking at it yesterday, the catch version I used was a
  special one that allowed the Test framework to find the tests.
I will pull the changes back. Still getting the hang of things.
Spent some time using Microsoft Message Analyser to take the big
  packet capture and bring it down to only the MD3 messages. I used
  a filter that the message length was always mod 6, last byte of
  each 6 is zero and first byte of first message could not be zero
  and it was pretty accurate.
Started looking at the lua wireshark filter, so I can generate
  good function stats into excel.
Scott

On 14/04/2018 1:44 PM, Neil Stephens
  wrote:

  I ended up merging into a feature branch. There were other
    changes I had to make to get things building under Linux, and so
    I could execute tests without visual studio, so I recommend you
    pull those changes back into your fork.
  —
    You are receiving this because you authored the thread.
    Reply to this email directly, view it on GitHub, or mute the thread.

  {"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/neilstephens/opendatacon","title":"neilstephens/opendatacon","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/neilstephens/opendatacon"}},"updates":{"snippets":[{"icon":"PERSON","message":"@neilstephens in #41: I ended up merging into a feature branch. There were other changes I had to make to get things building under Linux, and so I could execute tests without visual studio, so I recommend you pull those changes back into your fork. "}],"action":{"name":"View Pull Request","url":"https://github.com/neilstephens/opendatacon/pull/41#issuecomment-381300787"}}}

--
  Scott Ellis

      Principal

    Novatex Research - Excellence in Electronic Research &
    Development
    41 Yule Road, Merewether, Newcastle, NSW 2291, Australia
    Phone: 0412 988408

I still used catchvs.hpp for your stuff, I just added an entry point to
call the tests from an exe. It should still work with the visual studio
hooks.
Neil.
On Sat., 14 Apr. 2018, 18:25 Scott Ellis<EMAIL_ADDRESS>wrote:

I was looking at it yesterday, the catch version I used was a
special one that allowed the Test framework to find the tests.
I will pull the changes back. Still getting the hang of things.
Spent some time using Microsoft Message Analyser to take the big
packet capture and bring it down to only the MD3 messages. I used
a filter that the message length was always mod 6, last byte of
each 6 is zero and first byte of first message could not be zero
and it was pretty accurate.
Started looking at the lua wireshark filter, so I can generate
good function stats into excel.
Scott
On 14/04/2018 1:44 PM, Neil Stephens
wrote:
I ended up merging into a feature branch. There were other
changes I had to make to get things building under Linux, and so
I could execute tests without visual studio, so I recommend you
pull those changes back into your fork.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.
{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/neilstephens/opendatacon","title":"neilstephens/opendatacon","subtitle":"GitHub
repository","main_image_url":"
https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png
","avatar_image_url":"
https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open
in GitHub","url":"https://github.com/neilstephens/opendatacon"}},"updates":{"snippets":[{"icon":"PERSON","message":"@neilstephens
in #41: I ended up merging into a feature branch. There were other changes
I had to make to get things building under Linux, and so I could execute
tests without visual studio, so I recommend you pull those changes back
into your fork. "}],"action":{"name":"View Pull Request","url":"
https://github.com/neilstephens/opendatacon/pull/41#issuecomment-381300787
"}}}
--
Scott Ellis
Principal
Novatex Research - Excellence in Electronic Research &
Development
41 Yule Road, Merewether, Newcastle, NSW 2291, Australia
Phone: 0412 988408
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/neilstephens/opendatacon/pull/41#issuecomment-381313102,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AIoHZn0j6rOoxb5-c0yCXfz0hXvQN-Pmks5tobJkgaJpZM4TPP81
.


py.test freezes and errors

https://gist.github.com/anonymous/a406b6172e7cf3bc984f1ad5d9b9f935 shows the error output when running the full pytest unit test suite.

@ArcTanSusan this could be an environmental issuem and the test is just waiting for consul to show up. Looking at the logs; it seems you're running under vagrant; this could be an issue since the test suite expects consul to be started and bound to a random port as part of the test environment setup. It could be that you have to configure your vagrant environment such that it allows this behavior.

Yes, you are correct, the python-consul requires a running local consul server. 🎆


Maria trial

To code review the file of "CopyMaria-Data Integration".

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.0 out of 2 committers have signed the CLA.:x: Mferna38:x: amarchveYou have signed the CLA already but the status is still pending? Let us recheck it.