add query tip block header for consensus

共识模块获取 tip block height 全部改成查询区块头并非查询整个区块。

Codecov Report

Merging #274 (527fc55) into master (f9ce2b6) will increase coverage by 0.03%.
The diff coverage is 83.33%.

@@            Coverage Diff             @@
##           master     #274      +/-   ##
==========================================
+ Coverage   46.55%   46.58%   +0.03%
==========================================
  Files         136      136
  Lines       12085    12085
==========================================
+ Hits         5626     5630       +4
+ Misses       5295     5290       -5
- Partials     1164     1165       +1

Impacted Files
Coverage Δ

bcs/consensus/tdpos/schedule.go
47.70% <66.66%> (ø)

bcs/consensus/tdpos/tdpos.go
48.30% <75.00%> (+0.96%)
:arrow_up:

bcs/consensus/pow/pow.go
42.96% <100.00%> (ø)

bcs/consensus/xpoa/schedule.go
48.64% <100.00%> (ø)

bcs/consensus/xpoa/xpoa.go
53.76% <100.00%> (-1.08%)
:arrow_down:

bcs/contract/xvm/code_manager.go
63.63% <0.00%> (-2.73%)
:arrow_down:

kernel/consensus/base/driver/chained-bft/smr.go
42.93% <0.00%> (+0.79%)
:arrow_up:

bcs/network/p2pv2/server.go
52.40% <0.00%> (+1.06%)
:arrow_up:

... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f9ce2b6...527fc55. Read the comment docs.


Improve the network performance about trace segment, and collect statistic data of every service

Provide new mechanism about registering serviceName and Network address.
New cross-propagation protocol.
Compress serviceName, peer, port, peers (Maybe combine these three).
New ref structure of SegmentTrace.
New trace context, named AnalyticTracerContext. And send the analytic data in batch mode with agent-side memory merged.

All these adjustments are for providing better performance, and topological graph of services, which is very important for micro-services eco-system, such as spring cloud, even dubbo(x) services clusters.
cc @pengys5 @ascrutae

First thing first, we should support three types span in tracer context, Entry, Exit( Replace leaf ) and Local. Each one of them has different characteristics.

Entry Span, based stack-depth structure, one instance covers multi inject-points in a trace context. Begin at every service provider, like Tomcat plugin. When the second Entry Span is asked to create, just increase the stack depth, instead of creating new span. But will reset the span data, except start time.
Exit Span, just like what Leaf Span did, right now. Record data in the first leaf, ignore others belong to it.
Local Span, like the recent Span, do what to be asked.

These three types of span have to face the situation, which is How to be an OpenTracing supported tracer. Here is my proposals:

SkyWalkingSpan construction need span.type, otherwise throw exception. Users must set this tag by SkyWalkingSpanBuilder.withTag.
The opentracing SkyWalkingSpan interceptor creates Real Span by this tag.
Forbid to reset span.type again by SkyWalkingSpan.setTag.

By doing these, seem all things are in the same system, again. 😊

Register serviceName and Network address.

ServiceName is a subset of span's operationName. It only used when the span is type of Entry or Exist. So serviceName didn't contain hostname, ip, port or anything about machine or network, just as same as a concept of naming in micro-service background.
Network address including hostname, ipv4, ipv6, cluster-ip-group( ip1:port1,ip2:port2 ) and port.

For improving performance for uplink segment and analytic traces, and also reducing the cost of tracing-context cross-thread/process propagation. New Agent will send these two to collector for exchanging integers, which represent them.
Following these rules:

Same Identify for ServiceName, iff the SericeName and Application Code are same.
Same Identify for Network address, if literaly same. Only if it is a  cluster-ip-group, the collector should split by , and sort the ip array, then compare for equal.

Here are some examples:

Application Code
Identify (Integer Represent)
Actual Type
Actual Value

ProdApp
1
serviceName
/prod/rest/order

AcountApp
5
serviceName
/prod/rest/order ( Unlikely naming like this, just for demonstration)

ProdApp
2
network
2<IP_ADDRESS>:3007

AcountApp
2
network
2<IP_ADDRESS>:3007

AcountApp
3
network
<IP_ADDRESS>:7001,<IP_ADDRESS>:7002

ProdApp
3
network
<IP_ADDRESS>:7002,<IP_ADDRESS>:7001

New cross-propagation protocol
Here is the 3.1 cross-process propagation data structure.
Through considering Register serviceName and Network address feature, and in 3.3 we want to provide Topological graph of service. So the ref will contain the path of prev-services, all of them.
In 3.1, the propagation is like this:
parent_segment_id|parent_span_id|CLIENT_APP_CODE|<IP_ADDRESS>:8080|Trace.global.id.123,Trace.global.id.222

My proposal for 3.3, just an example
1. parent_segment_id
1. parent_span_id
1. 1,3,4,10     (sequence of service chain)
1. 11     (application id of client side)
1. 12     (network id of server id, which from client)
1. Trace.global.id.123  (global trace ids)

The purpose of this is for reducing the size of cross-process propagation data, even by now these are

Intend to use GRPC-java as core rpc framework, instead of HTTP rest
This is typical segment in 3.2
{
    "ts": "Segment.1498093854594.-1661571660.5160.1.1",
    "st":<PHONE_NUMBER>521,
    "et": 0,
    "rs": [
        {
            "ts": "parent_trace_0",
            "si": 1,
            "ac": "REMOTE_APP",
            "ph": "<IP_ADDRESS>:8080"
        },
        {
            "ts": "parent_trace_1",
            "si": 5,
            "ac": "REMOTE_APP",
            "ph": "<IP_ADDRESS>:8080"
        },
        {
            "ts": "parent_trace_2",
            "si": 5,
            "ac": "REMOTE_APP",
            "ph": "<IP_ADDRESS>:8080"
        }
    ],
    "ss": [
        {
            "si": 1,
            "ps": -1,
            "st":<PHONE_NUMBER>722,
            "et": 0,
            "on": "/serviceA",
            "ts": {
                "span.layer": "http"
            }
        },
        {
            "si": 2,
            "ps": 1,
            "st":<PHONE_NUMBER>724,
            "et": 0,
            "on": "/db/sql",
            "ts": {
                "span.layer": "db"
            },
            "logs": [
                {
                    "tm":<PHONE_NUMBER>727,
                    "fi": {
                        "stack": "java.lang.NullPointerException\r\nat org.skywalking.apm.agent.core.context.trace.TraceSegmentTestCase.testSerialize(TraceSegmentTestCase.java:104)\r\nat sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)\r\nat sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)\r\nat sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)\r\nat java.lang.reflect.Method.invoke(Method.java:498)\r\nat org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)\r\nat org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)\r\nat org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)\r\nat org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)\r\nat org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325)\r\nat org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78)\r\nat org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:57)\r\nat org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)\r\nat org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)\r\nat org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)\r\nat org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)\r\nat org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)\r\nat org.junit.runners.ParentRunner.run(ParentRunner.java:363)\r\nat org.junit.runner.JUnitCore.run(JUnitCore.java:137)\r\nat com.intellij.junit4.JUnit4IdeaTestRunner.startRunnerWithArgs(JUnit4IdeaTestRunner.java:68)\r\nat com.intellij.rt.execution.junit.IdeaTestRunner$Repeater.startRunnerWithArgs(IdeaTestRunner.java:51)\r\nat com.intellij.rt.execution.junit.JUnitStarter.prepareStreamsAndStart(JUnitStarter.java:242)\r\nat com.intellij.rt.execution.junit.JUnitStarter.main(JUnitStarter.java:70)\r\n",
                        "error.kind": "java.lang.NullPointerException",
                        "event": "error"
                    }
                }
            ]
        }
    ],
    "ac": "billing_app",
    "gt": [
        "Trace.1498093854633.-1661571660.5160.1.2"
    ]
}

In earlier version, we use JsonObject for better readability. Now we focus on performance, so I intend to use grpc-java and protobuf-java ( After https://github.com/grpc/grpc-java/issues/3123 confirmed by grpc-team ).  cc @ascrutae
And collector should provide a HTTP service to lookup the gprc services listening port. The segment receive service will be deprecated and removed. cc @pengys5

I just provide the prototype of new segment service: https://github.com/wu-sheng/sky-walking/blob/b29881c6fbebc6dc0e7f8c7409f16252008f61fe/apm-network/src/main/proto/TraceSegment.proto
cc @pengys5 @ascrutae

Provided 5 GRPC services definition:

TraceSegmentService: Actual trace segment receive service.
AggregatedMetricsService: Aggregate the service metric, if TraceSegmentService can't collect all, for performance and network cost consideration.
RegisterService: Ask for application id and instance id, at starting stage, before other services.
JVMMetricsService: Not finished yet, uplink jvm info about GC, memory, CPU in certain cycle, maybe per 15 seconds .

cc @pengys5 @ascrutae

All new feature finished in #252


TagBot trigger issue

This issue is used to trigger TagBot; feel free to unsubscribe.
If you haven't already, you should update your TagBot.yml to include issue comment triggers.
Please see this post on Discourse for instructions and more details.
If you'd like for me to do this for you, comment TagBot fix on this issue.
I'll open a PR within a few hours, please be patient!

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/54753

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/55149

Triggering TagBot for merged registry pull request
This extra notification is being sent because I expected a tag to exist by now, but it doesn't.
You may want to check your TagBot configuration to ensure that it's running, and if it is, check the logs to make sure that there are no errors.


[PokemonTabletopAdventures_v3]: New Feature - Adds advanced class to hybrid character details

Submission Checklist
Required

[x] The pull request title clearly contains the name of the sheet I am editing.
[x] The pull request title clearly states the type of change I am submitting (New Sheet/New Feature/Bugfix/etc.).
[x] The pull request makes changes to files in only one sub-folder.
[x] The pull request does not contain changes to any json files in the translations folder (translation.json is permitted)

Changes / Description

Adds an extra section to the Hybrid-style character details section at the top of the character page sheet, intended for filling in the Advanced Class for any Pokémon Class characters.
This is backed by an additional attribute that isn't used anywhere else, for now.

Character Sheet Info Roll20 Internal Use only.


Perform clipping / splitting an general polygons and then triangulate

Perhaps it can be drop in replaceable for the triangle splitter

Relating to #49 - implementing a better strategy for clipping and then triagulating polygons will leave more edges full intact and ultimately afford more connectivity in addition to being faster. Polygon splitting should occur by gathering all intersections edges with triangles and deriving new polygon edges from those connected lines.

Polygon triangulation:

https://algo.kaust.edu.sa/Documents/cs372l05.pdf
https://en.wikipedia.org/wiki/Polygon_triangulation

Three.js may already have a good implementation:

https://github.com/mrdoob/three.js/blob/master/src/extras/Earcut.js

Construct polygon edge sets with a set of pre-connected edges for the triangle
When a splitting by a triangle

Find the intersection edge overlap
If the edge intersects another edge then split it into two edges and connect it to the split side edges
Unconnected edges should be added to a list so they can be easily found for future splits

Notably, Earcut is fast (and is technically a separate library vendored into Three: https://github.com/mapbox/earcut), but it is far, far from ideal/Delaunay triangulation.

Closing in favor of #51


Unread badge in sourcelist

Love this theme! But found a small bug:

Fixed in https://github.com/noahbuscher/N1-Taiga/commit/ce4e5b82f87d00138e83963121bf74d059e384ff


Security <IP_ADDRESS> changes

Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Is this a cherry-pick from master?


trying to create a new wallet, but when you get to the 2nd screen to enter the pass phrase in the correct order it won't let you click Finish and move on.  Nothing happens

<!--
  Is this a bug report?
  If so, go back and select the "Bug report" option or your issue WILL be closed.
--!>

hey @bigbellyho ! thnx for the issue
could you pls provide more details such version/OS/etc ?
also would be really helpful to have a video of an issue.
I've just tested v0.2.1 on macOS (10.14.1 Mojave) and it seems it works for me
https://user-images.githubusercontent.com/67793194/119785127-97441680-bed7-11eb-9944-35a15c6d53b8.mov

closing as duplication of #1460

I am running windows 8.1 pro 64 bit version.  I downloaded win. exe.  here
is the video of finishing being clicked and nothing happening.
https://photos.app.goo.gl/sHPxQCRAd2J1Vp2n6
also posted. to the issue 1460
bigbellyho
On Thu, May 27, 2021, 1:51 AM thatStrangeGuyThorchain, <
@.***> wrote:

Closed #1463 https://github.com/thorchain/asgardex-electron/issues/1463.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/thorchain/asgardex-electron/issues/1463#event-4803991808,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AUHWWUCTAVBDL4NNEZBAPUDTPX2Y7ANCNFSM45TRSNLQ
.


review[vnv-4.2]: add exhaustive test cases for all NFRs: #160

#160

Please refer to the comment here about creating review issues. Thanks.


Review ServiceBus swagger spec

Run the swagger spec against linter and model validator tools
Manually review the swagger against swagger checklist
Open new issues that are found in the process

Closing since review completed - https://github.com/Azure/azure-rest-api-specs/pull/879


migrations.ALLOWED_DOMAINS config value does not default to allow everything

Description
Repositories can not be migrated anymore unless the following lines are present in Gitea's configuration file:
[migrations]
ALLOWED_DOMAINS = *

When this not present, starting a mirror migration from github.com results in this error message being shown:

The documentation's config cheat sheet for v1.22.1 tells that if this config value is undefined, it should not block anything:

ALLOWED_DOMAINS: empty: Domains allowlist for migrating repositories, default is blank. It means everything will be allowed.

I have first noticed this issue in v1.22.0, and the issue is also present after updating to v1.22.1.
On an other instance of mine, which is still running v1.21.4, migrations can be created fine, without overriding the default value of the migrations.ALLOWED_DOMAINS.
Gitea Version
v1.22.1
Can you reproduce the bug on the Gitea demo site?
No
Log Gist
https://gist.github.com/mpeter50/8a50ed8f4605ee833b3e7dc552e6eb2b
Screenshots
No response
Git Version
No response
Operating System
No response
How are you running Gitea?
Docker Compose, with a locally built image from unmodified source at versioned tag.
Database
MySQL/MariaDB

Can you provide more settings in your app.ini?
I tested it in local, and there's no problem to migration from Github.

我的也是如此,配置如下:
APP_NAME = DevWiki Gitea
RUN_MODE = prod
RUN_USER = git
WORK_PATH = /data/gitea

[repository]
ROOT = /data/git/repositories

[repository.local]
LOCAL_COPY_PATH = /data/gitea/tmp/local-repo

[repository.upload]
TEMP_PATH = /data/gitea/uploads

[server]
APP_DATA_PATH = /data/gitea
DOMAIN = git.devwiki.net
SSH_DOMAIN = git.devwiki.net
HTTP_PORT = 此处打码
ROOT_URL = https://git.devwiki.net/
DISABLE_SSH = false
START_SSH_SERVER = true
SSH_PORT = 22
SSH_LISTEN_PORT = 此处打码
LFS_START_SERVER = true
LFS_JWT_SECRET = 此处打码
OFFLINE_MODE = false
LANDING_PAGE = explore

[lsf]
PATH = /data/git/lfs

[database]
PATH = /data/gitea/gitea.db
DB_TYPE = sqlite3
HOST = localhost:3306
NAME = gitea
USER = root
PASSWD =
LOG_SQL = false
SCHEMA =
SSL_MODE = disable
CHARSET = utf8

[indexer]
ISSUE_INDEXER_PATH = /data/gitea/indexers/issues.bleve

[session]
PROVIDER_CONFIG = /data/gitea/sessions
PROVIDER = file

[picture]
AVATAR_UPLOAD_PATH = /data/gitea/avatars
REPOSITORY_AVATAR_UPLOAD_PATH = /data/gitea/repo-avatars
DISABLE_GRAVATAR = false
ENABLE_FEDERATED_AVATAR = true

[attachment]
PATH = /data/gitea/attachments

[log]
MODE = console
LEVEL = info
## ROUTER = console
ROOT_PATH = /data/gitea/log

[security]
INSTALL_LOCK = true
LOGIN_REMEMBER_DAYS = 3
SECRET_KEY =
REVERSE_PROXY_LIMIT = 1
REVERSE_PROXY_TRUSTED_PROXIES = *
INTERNAL_TOKEN = 此处打码
PASSWORD_HASH_ALGO = 此处打码

[service]
# 禁用注册，启用后只能用管理员添加用户
DISABLE_REGISTRATION = true
# 是否所有页面都必须登录后才可访问
REQUIRE_SIGNIN_VIEW = false
# 是否显示注册按钮
SHOW_REGISTRATION_BUTTON = false
# 启用注册邮件激活，前提是 Mailer 已经启用
REGISTER_EMAIL_CONFIRM = false
# 是否发送工单创建等提醒邮件，需要 Mailer 被激活
ENABLE_NOTIFY_MAIL = false
ALLOW_ONLY_EXTERNAL_REGISTRATION = false
ENABLE_CAPTCHA = true
REQUIRE_CAPTCHA_FOR_LOGIN = true
DEFAULT_KEEP_EMAIL_PRIVATE = true
DEFAULT_ALLOW_CREATE_ORGANIZATION = true
DEFAULT_ENABLE_TIMETRACKING = true
NO_REPLY_ADDRESS = noreply.localhost
RESET_PASSWD_CODE_LIVE_MINUTES = 5
ENABLE_CACHE_AVATAR = true

[migrations]
ALLOWED_DOMAINS =
ALLOW_LOCALNETWORKS = true
SKIP_TLS_VERIFY = true
BLOCKED_DOMAINS =

[mailer]
ENABLED = false

[openid]
ENABLE_OPENID_SIGNIN = false
ENABLE_OPENID_SIGNUP = false

[oauth2]
JWT_SECRET = 此处打码

经测试,ALLOWED_DOMAINS 设置为空不行, 必须设置具体的域名才可以
[migrations]
ALLOWED_DOMAINS =
ALLOW_LOCALNETWORKS = true
SKIP_TLS_VERIFY = true
BLOCKED_DOMAINS =

@Dev-Wiki are you having the same problem?

I cannot reproduce this on main branch(0d24c9f383255605d68a92cc5f087c3f16a1d735) and release/v1.22 branch(3913ef69d5a9a268bc44ef17a3bb8717ba924627)

To be more complete, these are the complete migration settings:

Maybe this is helpful. Not sure why did I cut the issue screenshot that way.

Hmm just did an additional test, and maybe this is happening while the Gitea container does not have internet access, e.g. because of container settings.
Of course its fine that it cannot do the migration without access to the source service. The problem may be that the failure is handled incorrectly.
If you have the capacity, it might be nice to allow creating migrations regardless of accessibility of the source service, but delay it until intenet access is available. It could be useful for when internet is genuinely not accessible for some time, or for when the target server is unstable, so that users may have a slightly easier time rescuing their repos. Not sure how realistic are these scenarios, probably not too much.

I also cannot reproduce it in main and release 1.22

@Dev-Wiki are you having the same problem?

problem resolved!
ini config for this:
[migrations]
ALLOW_LOCALNETWORKS = true
SKIP_TLS_VERIFY = true
ALLOWED_DOMAINS = *
BLOCKED_DOMAINS =

use * not empty!
use * not empty!
use * not empty!

I also cannot reproduce it in main and release 1.22

problem resolved!
ini config for this:
[migrations]
ALLOW_LOCALNETWORKS = true
SKIP_TLS_VERIFY = true
ALLOWED_DOMAINS = *
BLOCKED_DOMAINS =
use * not empty!
use * not empty!
use * not empty!

@mpeter50 has mentioned this in the description

@mpeter50 has mentioned this in the description

But I can not reproduce it even I left it empty in my app.ini

你使用的什么版本? 我是1.22.1, 这样配置没有提示任何错误, 但是我本地重新搭建了一个gitea 使用1.22.0 什么都没配置这个, 也能迁移任意网站, 现在还不清楚这个设置的逻辑.
我这个配置目前只在我自己的nas上测试可以,
另外一种可用的方式为:
[migrations]
ALLOW_LOCALNETWORKS = true
SKIP_TLS_VERIFY = true
ALLOWED_DOMAINS = *.github.com,github.com

The reason is simple: the sentence Blank means everything will be allowed. is wrong, it is from #13610 (2020-11-29), which is older than the security fix by  #20016 (2022-06-19), since #20016, "empty" means allowing external hosts by default.
The document is just outdated and needs to be updated.

Oh yes, re-read the code again, it is a bug. Will fix it.

Well, no code problem, it is well covered by a test. Maybe some users are using fake-IP proxies to access GitHub?

To add a bit of a clarification, it seems that to me the problem was caused by my Gitea container being configured like this:

The proxy net is a reverse proxy through which I access Gitea, it does not work in the other direction.
Normally the container is not given the network that Docker Compose calls as default, and that means Gitea does not have access to the network to which the Docker Host is connected. This is when the discussed error occurs.
When I uncomment the default network, and recreate the Gitea container, the migration will work on the next try.

Well, that's my guess, you are using proxy ......

Well, no code problem, it is well covered by a test. Maybe some users are using fake-IP proxies to access GitHub?

I do not know about such happening here. I have an internal DNS server if that counts, but shouldnt modify anything.

More contexts:

#20325
#20328

This is the definition of the proxy network from above:

Here it is seen that it is externally defined, outside of the compose file.
According to running docker network inspect proxy-internal, the network only hosts a few other services' frontends, and an Nginx, which is only configured as a reverse proxy.
The default network is a network created by docker compose, technically named as gitea_default, according to docker network inspect gitea_default it uses the bridge driver. Only the Gitea container is connected to it.

If I can help with diagnosing in any way, let me know.
This is the result of nslookup github.com executed inside the Gitea container when it is not given access to the internet:
sudo docker exec -it gitea bash
fce11f93a4df:/var/lib/gitea$ nslookup github.com
Server:         <IP_ADDRESS>
Address:        <IP_ADDRESS>:53

** server can't find github.com: SERVFAIL

** server can't find github.com: SERVFAIL

fce11f93a4df:/var/lib/gitea$

This is the result of nslookup github.com executed inside the Gitea container when it is given access to the internet:
sudo docker exec -it gitea bash
cd1b6e0424cd:/var/lib/gitea$ nslookup github.com
Server:         <IP_ADDRESS>
Address:        <IP_ADDRESS>:53

Non-authoritative answer:

Non-authoritative answer:
Name:   github.com
Address: <IP_ADDRESS>

cd1b6e0424cd:/var/lib/gitea$

I was wondering if maybe Gitea would be processing the SERVFAIL response as an empty IP address being resolved or something like that, when trying to check if the migration source is allowed, and detecting that as a not-a-public address?

Sorry but no more idea from my side ..... maybe it needs a reproducible setup and some code level debugging work, I am not able to provide more support at the moment. (and will leave keyboard for a while)

I just noticed that there are related entries in the System Notices:

However, by doing further tries with revoked internet access, these do not appear to be generated when the discussed disallowed host error apepars. I have tried to migrate a new repo several times, every time producing the error, but no new system notices have appeared.

By the hit of this comment https://github.com/go-gitea/gitea/issues/31733#issuecomment-2297912917
I added this into my hosts file.
<IP_ADDRESS> github.com

Then I got same error.

By the hit from https://github.com/go-gitea/gitea/issues/31733#issuecomment-2297912917
I added this in my hosts
<IP_ADDRESS> github.com

Then I got the same error.

We close issues that need feedback from the author if there were no new comments for a month. :tea:

Can we reopen this issue? I do not know what additional feedback I can give. Though if you ask for something, of course I may be able to give more information.

I do not know what additional feedback I can give. Though if you ask for something, of course I may be able to give more information.

https://github.com/go-gitea/gitea/issues/31733#issuecomment-2297915772
it needs a reproducible setup (to make sure others could reproduce in their environments)

I will try to make a copy of the instance and trim it down to what is needed for this to happen. This will take some time, though.
If anyone else having this issue is reading this, please consider of you can make a reproducer too.

We close issues that need feedback from the author if there were no new comments for a month. :tea:

Can we reopen this issue? I did not yet find the time to make a minimal reproducer installation.


Improved handling of scoped column names

When incorporating joins in unioned queries, it is often necessary to specify a table or scope name as the column name to resolve column ambiguity.
In the example below, using "comments.id" is essential due to the ambiguity introduced by the join. (This example is based on the structure in the test.)
relation = ActiveRecord.union(:id, :post_id) do |union|
  comments = Comment.joins(:post).where(posts: { published: true })
  posts = Post.none

  union.add comments, "comments.id", "comments.post_id"
  union.add posts, nil, "posts.id"
end

first_comment = relation.first

Attempting to access the attributes of the results yields unexpected results:
first_comment.post_id # => missing attribute 'post_id' for Comment

The populated attributes include the table/scope name:
first_comment.attributes_names # => ["comments.id", "comments.post_id"]

During the record filling via the mappings, the created attribute names are "comments.id" and "comments.post_id" instead of "id" and "post_id".
This pull request proposes a simple (though not perfect) solution for this issue. It essentially splits the column mapping name on the '.' and takes the last part.

Sorry for some reason I wasn't notified about this! This is a great contribution!

No problem!
Thanks for merging ☺


Restore apply_resources for scenario2 of upgrade test

Changes
This commit restores the apply_resources function to enable the 2nd scenario of the upgrade test work by applying the resources from the old server version of pipeline.
/kind misc

Submitter Checklist
As the author of this PR, please check off the items in this checklist:

[ ] Has Docs if any changes are user facing, including updates to minimum requirements e.g. Kubernetes version bumps
[ ] Has Tests included if any functionality added or changed
[ ] Follows the commit message standard
[ ] Meets the Tekton contributor standards (including functionality, content, code)
[ ] Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
[ ] Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings). See some examples of good release notes.
[ ] Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes
NONE

maybe add a link to the issue/discussion?

/remove-kind misc
/kind bug

Example gist: https://gist.github.com/JeromeJu/86e7b96e2716db77ee3b79903527c0cb
Some of the tests failed as expected ie. pipelinerun.yaml because the KO_DOCKER_REPO is not set the same as in CI because we need a kind cluster locally.

Based on your gist, it looks like the script is still not working as intended. I see
=========================================
==== APPLYING THE RESOURCES TASKRUNS ====
=========================================
>> Applying the resource taskrun
error: error when deleting "STDIN": resource name may not be empty
Error: exit status 1
2023/06/22 19:16:52 error during command execution:exit status 1
taskrun.tekton.dev/tkn-arg-test-d7st5 created
error: error when deleting "STDIN": resource name may not be empty
Error: exit status 1
2023/06/22 19:16:52 error during command execution:exit status 1
taskrun.tekton.dev/array-with-default-xfb59 created
secret "ssh-key-for-git" deleted
serviceaccount "ssh-key-service-account" deleted
Error from server (NotFound): error when deleting "STDIN": taskruns.tekton.dev "authenticating-git-commands" not found
Error: exit status 1
....

I think we want the script to fail if any of these steps fail, rather than relying on specific checks. This will make failures more clear, rather than having to inspect logs to determine success/failure. You can do this with set -e: https://www.tutorialspoint.com/aborting-a-shell-script-on-any-command-fails

I totally agree with this that we want the test to fail once any step fails and wouldn't want any red herring in the logs.
But I think these logs come from the ko delete -f - I added at line 186 just to make sure there were no previous examples happen to be created in the namespace then the correct version of resources couldn't get created. These error messages are indicating the resources are not existent in the namespace for the upgrade test, I think they could be ignored.
If this makes sense I hope adding the doc string could help resolve this confusion here?

I totally agree with this that we want the test to fail once any step fails and wouldn't want any red herring in the logs.
But I think these logs come from the ko delete -f - I added at line 186 just to make sure there were no previous examples happen to be created in the namespace then the correct version of resources couldn't get created.

It sounds like you're trying to make sure resources get cleaned up between runs of the test, so each local run starts with a clean slate. This is a good idea, but this isn't how I'd recommend doing it. Instead, it would be better to have a function that cleans up any resources that were created when the script exits, regardless of whether it exited with success or failure. Here's an example of where we use trap to undo setup steps when a script exits.

These error messages are indicating the resources are not existent in the namespace for the upgrade test, I think they could be ignored. If this makes sense I hope adding the doc string could help resolve this confusion here?

It's not beneficial to have lines in any script that don't execute successfully. Take a look at the section of this bash cheatsheet titled "Writing robust scripts and debugging". If commands don't execute successfully (i.e. exit status 0), we'd prefer a fail-fast behavior of exiting the script immediately and failing tests. Exiting as soon as an error occurs makes subsequent steps easier to debug, and makes it clear (via test failure) that there is a problem with the script. I don't think it's realistic here to document what error messages the tests are supposed to output, and for someone to have to read through test logs and documentation to understand if the test is working correctly or not.
Let me know if you'd like to pair on this script together, and please address all previous feedback (incl. commit message + PR title) before requesting another round of review.

Thanks @lbernick for the pointers!
I've added the gist at https://gist.github.com/JeromeJu/92058e20dc2a15ac7a470c71248bd211 for the scenario ii part.
Created a simple Task and Pipeline in the upgrade directory within the upgrade namespace because the verify_pipeline_installation would delete all pipeline CRDs in the current namespace.
After some attempts I also felt that it might be easier to keep the whole script in shell script for now and migrate it to go in a whole due to the reasons that there are helpers in the vendor library i.e. https://github.com/tektoncd/pipeline/blob/7b23f931d4f93aab8688f87536a75b50085f1285/vendor/github.com/tektoncd/plumbing/scripts/library.sh#L444.

/hold
I'd like https://github.com/tektoncd/pipeline/pull/6871 to be merged first, as it will give us more confidence in the changes we're making to these tests.

/unhold
since https://github.com/tektoncd/pipeline/pull/6871 has merged

/assign

/lgtm


pkg/aws: check cluster name and worker pool name length

There are tight restrictions on resource name length on AWS. Check
cluster name and worker pool name against those.
Fixes #179

Does worker pool name combines with cluster name in any place? If not, is it possible to have 2 worker pools with the same name on 2 different clusters? If so, should we also add a check for it's maximum length?

I don't think it does, I've tested with both cluster name and worker pool name being 18 characters and it worked fine.
I think having two worker pools with the same name results in errors like the one solved in https://github.com/kinvolk/lokomotive/pull/171

I think having two worker pools with the same name results in errors like the one solved in #171

I wonder if we should document/report that :thinking:

I wonder if we should document/report that thinking

I created https://github.com/kinvolk/lokomotive/pull/186

I think having two worker pools with the same name results in errors like the one solved in #171

I wonder if we should document/report that

In the same cluster , if there are two worker pools with same name, then there an appropriate error message provided.


[feature request] Ruku (section) wise navigation

I'm submitting a ...

[ ] bug report
[x] feature request
[ ] other

Current behavior:
Ruku wise navigation is missing
Expected / new behavior:
Please add Ruku (section) wise navigation
Jzakallahu khairan

Just to give a good message
here is a link preview on staging.quran.com
(it has surah (chapters) and juz)
http://imgur.com/8Syu74zl.png
staging.quran.com

Thank you @mrtugicom
May Allah give you a proper reward.


add com.kazurayam.materialstore.report.MaterialListReporter and MProductGroupReporter

it is necessary to do #150

done in v0.4.6-SNAPSHOT


How to get require.context working

Requiring tags files work properly if I use require('./tags/buddy-list.tag');. The JS output properly sets up a riot.tag(...). However, when I try to use require.context('./tags', true, /\.tag$/), what I get in the JS output is this instead:
var map = {
  "./baron-chat.tag": 13,
  "./buddy-list.tag": 14
};

It looks like the tags aren't getting compiled properly. Any idea how I can get require.context working?

Figured it out:
var context = require.context('./tags');
context.keys().forEach(key => {
  context(key);
});

require.context returns an object where each key's value is a require() function.


mongodb-replicaset fails when auth is enabled

Error: render error in "mongodb-replicaset/templates/mongodb-keyfile-secret.yaml": template: mongodb-replicaset/templates/mongodb-keyfile-secret.yaml:13:33: executing "mongodb-replicaset/templates/mongodb-keyfile-secret.yaml" at : wrong number of args for b64enc: want 1 got 0
auth:
enabled: true
adminUser: admin
adminPassword: password
key: keycontent
existingKeySecret:
existingAdminSecret:
What are the values I have to provide to the adminUser, adminPassword, key, existingKeySecret.
I have tried to provide values and it still didn't work.

hey @rjain15 can you post this at https://github.com/kubernetes/charts? Any chart-related support questions should go to the owners of those charts. Thanks!


Using LinuxAdmin for starting and stopping the application daemon

Allows us to remove these functions from miqnet.sh
@Fryguy @jrafanie

@gtanzillo @Fryguy please review


Describe what Kubeflow is, in practical terms

I've chatted to a couple of developers recently, who've found it difficult to grasp what Kubeflow actually is, even after reading the docs. One of these conversation partners was an engineer who is very well versed in Kaggle.
At the high level of our docs, we tend to describe our mission rather than giving an overview of how we accomplish that mission.
Let's add a practical description of what Kubeflow is.

/assign


User form for creating entries

We should consider that maybe users will be discouraged by GitHub's online GUI, and creating a file and so on may seem daunting. An alternative may be to create an entry could be an input form.
This form would be linked to the landing page button "+ Add DIYbio initiative"

I am hopeful that by requiring a github account and adding just a little bit of friction, this will reduce spam, but NOT real contributions.  As long as there are clear instructions on how to contribute, hopefully this will work fine.

Yes, I guess you are right!

I get Jason's point about the advantages of creating some friction, but I think that people not familiar with GitHub will find this daunting and won't contribute. I would go either with a form or asking people to become diplomats.

@DIYbiosphere/coders, can this be done? Can we create a simple form that people can fill in and submit with their GitHub user account?

A workaround might be creating a form to fill out that provides a better UI. However, the fork, new file, commit, and pull request action sequence should still be done by contributors.

Here is a sketchup of how the form could look like:

How about a WYSIWYG markdown editor for the body of the entry? It might start to get some people familiar with Markdown!! This is [Bootstrap Markdown], which might work. (http://www.codingdrama.com/bootstrap-markdown/)

I have started with a codepen

The form is being set up. For Date picking we could use this

closing since it's so old - will revisit

I reopened this issue because it has some information which is related to the google form submission that is being discussed in #286.
@sjamesparsonsjr there a nice form design here


fix: Add secrets.go which handles secret replacement from various pro…

…viders.

:tada: This PR is included in version 1.1.2 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Module for message passing and queueing via pop/push on Redis lists

I wrote a module that blocks asynchronously until something is pushed into a Redis lists. This can be used as a messaging queue between servers or processes. You can "watch" Redis keys for something to pop. Here is an example usage of the module.
Let me know if this module is something you would like to see published on npm. Also let me know if something similar exists!
var redisKeysToWatch = ['message_queue', 'secret_message_queue'];
var looper = new RedisLooper(redisClient, redisKeysToWatch);

looper.startWithCallback(function(channel, value) {
	// called each time BLPOP() returns with data. Channel = name of key that BLPOP was called on.
});

@objectiveSee I'm not aware of something like that existing, but I did not check either.
If you already wrote that module, why not publish it? If someone thinks it's useful, that great, if not, that should not be an issue as you already did most of the work.


Camera Pan for Academy Exterior (Courtyard map)

The first time the player enters the courtyard.json map, a camera pan (like the one at the tower of infinite knowledge) should go across the academy building. It might be nice to add in the telescope somewhere here again as well, so the player can view it again after the initial pan.

Closing this as it was covered in PR #93


SK is blank after the first frame when running MRC on HL2

Description
Hey Nick, I found a pretty niche issue when launching an SK app while streaming MRC on the HL2. Reporting here since this would occur when customers want to stream the application for other people to see.
To reproduce,

Start Mixed Reality Capture from the Device Portal with Render from Camera enabled
Launch StereoKit app (latest dev)

Important Notes:

MRC and Render from Camera works with an already running SK app
The SK app renders for the first frame, then everything disappears and SK continues to step without rendering anything
I couldn't reproduce this behavior with MSFT's BasicXrApp, which leads me to believe this might be SK-related

Platform / Environment

UWP HoloLens 2
Latest develop

Logs or exception details
The initialization is successful and there is nothing notable to report from the logs.
[SK diagnostic] Creating view: PrimaryStereo color:bgra32_sRGB depth:depth16 blend:Additive
[SK diagnostic] Set view: PrimaryStereo to 1440x936@1msaa
[SK diagnostic] Creating view: SecondaryMonoFPO_Msft color:bgra32_sRGB depth:depth16 blend:Alpha Blend
[SK diagnostic] Created unbounded app space at an offset of (0.0025,0.00017,-0.00034) (0,-0.0089,0,1)
[SK info] Initialization successful

After the first step, the following error repeats for xrAcquireSwapchainImage (throws here):
ERROR (OpenXR) : Invalid XrSwapchain handle with value 'XR_NULL_HANDLE'.
Exception thrown at 0x76BF56FF in SKApp.UWP.exe: Microsoft C++ exception: msxr::XrResultException at memory location 0x0470E6B0.
ERROR (OpenXR) : Invalid XrSwapchain handle with value 'XR_NULL_HANDLE'.
Exception thrown at 0x76BF56FF in SKApp.UWP.exe: Microsoft C++ exception: msxr::XrResultException at memory location 0x0470E6B0.

I'm wondering if there is anything else I could check for differences between the two apps?
Also, the OpenXR app defaults to XR_ENVIRONMENT_BLEND_MODE_ADDITIVE and the color & depth swapchains seem similar to SK:

In the latest \develop branch after the backend refactoring, the HL2 is unable to stream or record video while running StereoKit.
The exception is "Access violation reading ..." when calling xrEndFrame. When the secondary view is active (HL2 is recording), it successfully renders a frame once, but for the second frame it throws the exception.
I was able to find a workaround by doing the following:

If the camera is recording before the SK app initializes, the secondary view config is active. Since we assume it starts as inactive, the swapchain doesn't get updated.

Commenting out the XR extension

I can't wrap my ahead around it since the lifetime of the XrSecondaryViewConfigurationFrameEndInfoMSFT and XrSecondaryViewConfigurationLayerInfoMSFT should still be alive for xrEndFrame to have them in the header. The bytes and offset arrays seem to be valid for the header. I've also tried disabling the color swapchain's surface and reverting back to the non-list approach of xr_display_2nd_layers. Is there any chance you might know what info to grab next?

Off the top of my head, I can't really think of much! I skimmed it now and didn't see anything obvious. I don't believe that the xrEndFrame chain code gets used in this codebase except for this secondary view stuff, so it doesn't get much exercise!
I'll try and peek a little more tomorrow. Do you have any more info about the Access Violation error? Can you tell what bit is causing that? Is it actually the chained data?


Getting error(Unhandled Exception: PlatformException(VideoError, Failed to load video: The operation could not be completed, null, null)) for some of the vedio urls

I am using   video_player: ^2.2.17 for some of the urls in iOS getting PlatformException and unable to play those videos.

@vikramsinghrajpoot
Can you provide flutter doctor -v and an example url that throws the said excpetion ?
See this similar open issue for your reference: https://github.com/flutter/flutter/issues/56665

Urls:
http://commondatastorage.googleapis.com/gtv-videos-bucket/sample/BigBuckBunny.mp4
http://commondatastorage.googleapis.com/gtv-videos-bucket/sample/ElephantsDream.mp4
flutter doctor -v
[✓] Flutter (Channel stable, 2.5.3, on macOS 11.6 20G165 darwin-x64, locale en-IN)
• Flutter version 2.5.3 at /Users/vikram/Documents/flutter
• Upstream repository https://github.com/flutter/flutter.git
• Framework revision 18116933e7 (5 months ago), 2021-10-15 10:46:35 -0700
• Engine revision d3ea636dc5
• Dart version 2.14.4
[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.3)
• Android SDK at /Users/vikram/Library/Android/sdk
• Platform android-31, build-tools 30.0.3
• Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
• Java version OpenJDK Runtime Environment (build 11.0.8+10-b944.6916264)
• All Android licenses accepted.
[✓] Xcode - develop for iOS and macOS
• Xcode at /Applications/Xcode.app/Contents/Developer
• Xcode 13.0, Build version 13A233
• CocoaPods version 1.11.2
[✓] Chrome - develop for the web
• Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome
[✓] Android Studio (version 4.2)
• Android Studio at /Applications/Android Studio.app/Contents
• Flutter plugin can be installed from:
🔨 https://plugins.jetbrains.com/plugin/9212-flutter
• Dart plugin can be installed from:
🔨 https://plugins.jetbrains.com/plugin/6351-dart
• Java version OpenJDK Runtime Environment (build 11.0.8+10-b944.6916264)
[✓] VS Code (version 1.57.1)
• VS Code at /Users/vikram/Downloads/Visual Studio Code.app/Contents
• Flutter extension version 3.25.0
[✓] Connected device (3 available)
• iPhone 8 (mobile)  • 70590BD9-28AC-45DD-9D64-4FB44E80D144 • ios            • com.apple.CoreSimulator.SimRuntime.iOS-15-0 (simulator)
• iPhone 11 (mobile) • 3B7919C4-A627-4D02-9E6A-F70DE423B98C • ios            • com.apple.CoreSimulator.SimRuntime.iOS-15-0 (simulator)
• Chrome (web)       • chrome                               • web-javascript • Google Chrome 99.0.4844.51
• No issues found!

this NSAppTransportSecurity tag is already there

Channel stable, 2.5.3

Can you upgrade to latest stable and try again ?

Same error

@vikramsinghrajpoot
Thanks for the update. I used the video links you shared above and used them in video_player plugin example, ran it on iOS simulator 15.2 on which both played properly as below:

@override
  void initState() {
    super.initState();
    _controller = VideoPlayerController.network(
      'http://commondatastorage.googleapis.com/gtv-videos-bucket/sample/ElephantsDream.mp4',
      closedCaptionFile: _loadCaptions(),
      videoPlayerOptions: VideoPlayerOptions(mixWithOthers: true),
    );

    _controller.addListener(() {
      setState(() {});
    });
    _controller.setLooping(true);
    _controller.initialize();
  }

Can you try the same on simulators (different OS versions) and confirm on which it works and on which devices it throws the error ? That way we'll know if this is device or OS specific issue or not.


features/plugins

Hey this repo seems really cool.  Do you have the grafana plugin for druid that's mentioned in the readme?  I couldn't see the features/ folder that you reference in your symlink instruction and config.js module definition.  Either way, this work and similar visualization work for Druid is really exciting, thanks!

Hi @milimetric,
Yes, the Druid plugin for Grafana is here.  The way I install it is to download Grafana 1.9.1 as is, open it up and put a sym link to this plugin in the plugins/features directory.
cd grafana-1.9.1
ln -s /path/to/druid/plugin/grafana-plugins/features plugins/features

Thanks!  You rock, I'll be trying this soon.

Cool.  Let me know how it goes.


Extract and import text content of documents and blocks

This adds the functionality to extract contents of the page tree node (title, slug) and the attached document (DocumentInterface) and copy to the clipboard, as well as to import contents from the clipboard to parts of the page tree (Page Tree Node, Documents, Blocks).
The method extractTextContents recursively extracts text contents from documents and blocks. These are copied to the clipboard in csv format:
Original;ReplaceWith
My first text;My first text

Inline styles and links are marked with pseudo tags (e.g. First paragraph, has some <inline id="1">inline styles</inline> and Second paragraph, has a <entity id="1">link</entity>).
The replaceTextContents method enables the import of text content in csv format into the page tree. The Original value represents the exported text, while the ReplaceWith value represents the text to replace the current content.
Original;ReplaceWith
My first text;Translation of my first text

Contained pseudo tags are removed and the indices of the inline styles and links are adjusted.

At bit late, but what do you think about splitting this PR into two parts?
PR1: Text contents import/export extraction (should be 95% finished).
PR2: Draft.js handling. In PR1 you may simply ignore all formatting and links entities.
I believe we could merge PR1 quickly, and then review PR2 more in-depth.
@nsams what do you think of this idea? May this help, or is it just busy work?


The build jobs should use existing testgrid distribution

Description:
Right now, each build job unzip the testgrid distribution into /testgrid/testgrid-home/testgrid_dist folder. This is not scalable when doing parallel testing. So, we need to remove this.
This has lead to numerous issues.
Affected Product Version:
m29
OS, DB, other environment details and versions:
Steps to reproduce:
https://github.com/wso2/testgrid/blob/master/jenkins/pipelines/test-jobs/wso2is-5.3.0-LTS/Jenkinsfile#L65
Related Issues:

Fixed in https://github.com/wso2/testgrid/pull/792


Fix issue in raise_for_status section of docs

Fixes https://github.com/prkumar/uplink/issues/122
Changes proposed in this pull request:

Fixes a minor issue in error handling section of docs

@prkumar

Thanks for the fix! 😃


Add an environment variable for OVERPASS_CLONE_SOURCE

Problem: init mode takes too long for fresh deployments.
Solution: use clone mode instead.
New problem: the cloned image uses minute diffs, and my instances can't cope with changes that frequent.
New solution: be able to specify a new URL for clones.
Hence, OVERPASS_CLONE_SOURCE.
I added it to the documentation too, and also cleaned up the README file while I was at it. Let me know if you want to split the pull request into just the environment variable, and a separate one for documentation changes.
P.S. can you push the latest image onto your official docker repository please?

Thank you for your contribution. Docker images are still built by Docker hub and latest tag is not always build as last one. I'll retrigger the build on the last version of the image tomorrow (as I hope that then all builds will finish)

Thank you for your contribution. Docker images are still built by Docker hub and latest tag is not always build as last one. I'll retrigger the build on the last version of the image tomorrow (as I hope that then all builds will finish)


Non-Dummy variable codings in ContinuousEncoder

Right now, MLJModels.jl has ContinuousEncoder, which automatically transforms into one of two codings:

Dummy variable coding (one-hot with last category dropped)
Redundant variable coding (one-hot)

However, these aren't always the most useful codings for effective regularization, and there are many others in common use. For example, the most common way to encode ordinal variables is with sequential difference encoding; with this encoding, regularization pulls adjacent categories closer together, which improves model performance relative to either treating ordered variables as categorical (discarding ordering information) or treating them as continuous (using an equal-distance assumption that is often incorrect). Similarly, effect coding allows you to regularize categories towards the grand mean (rather than regularize every category towards 0, or regularize all categories towards one other category).

Sounds like a good idea to me. PR welcome.

Summer project: https://julialang.org/jsoc/gsoc/MLJ/#categorical_variable_encoding


Prometheus producer

This PR introducers a producer for Prometheus - a first-class Prometheus endpoint with no need to install third-party tools.
By default the Prometheus endpoint is found on each node on port 9273, the same port as used as the default Prometheus port in telegraf.
As we are using the prometheus_client library, the metrics endpoint supports both text and protobufs.

http.ErrServerClosed is not available in go 1.7. I updated the build server to run with go 1.8.

retest this please

@collinvandyck thanks very much for the very quick and tolerant review!
I addressed all your feedback.


Adding Functionality needed by openCARP

So far, I think we are missing the following functionalities:

diagonal scaling: openCARP needs to compute LMR where L and R are diagonal matrices. This could potentially be done with a new diagonal matrix format

matrix axpy: openCARP needs to compute a * A + b * B. This is not trivial as it potentially changes the sparsity pattern, if new zero entries occur even to something else that the union of the sparsity patterns of A and B

extract the diagonal from a matrix

initialize a matrix with all zeros

Any ideas / comments on how to handle a diagonal matrix format?

Matrix axpy: For sparse matrices that's called spgeam and we already have an implementation hidden inside the HIP advanced spgemm and I could easily add it for the other executors as well. We only need to figure out how to represent/call it. If you call advanced Csr->apply(alpha, Identity, beta, Csr) maybe?

Matrix axpy: For sparse matrices that's called spgeam and we already have an implementation hidden inside the HIP advanced spgemm and I could easily add it for the other executors as well. We only need to figure out how to represent/call it. If you call advanced Csr->apply(alpha, Identity, beta, Csr) maybe?

That would be awesome! I think then we could just call the advanced spgemm, right?

Matrix axpy: For sparse matrices that's called spgeam and we already have an implementation hidden inside the HIP advanced spgemm and I could easily add it for the other executors as well. We only need to figure out how to represent/call it. If you call advanced Csr->apply(alpha, Identity, beta, Csr) maybe?

Your representation makes sense, it would be awesome if you could add this :)

For diagonal scaling: I see two approaches:

Add a new diagonal matrix format as you suggest.
Add a diagonal scaling operation to all the matrix formats.

I personally think the second approach might be better because it would be easier to implement and I dont see any particular reason to add a new format for representing a diagonal matrix format. Additionally, you would also need to implement conversions from one diagonal to all other formats and vice versa which I am not sure is such a good idea. The diagonal scaling operation could look like :
auto mat = gko::matrix::Csr<>::create(...);
auto scaled_matmat = gko::matrix::Csr<>::create(...);
auto diag = gko::Array<>{exec, {values}};
mat->scale_diagonal(lend(diag), lend(scaled_mat));

You could similarly have a extract diagonal operation. I think we already have some similar kernels for the CSR format within the ParIX classes .

The reason I would prefer a diagonal matrix type is that it better matches with Ginkgo's position as a linear operator library. When we add special functions for these kinds of features, we can't use them within solvers, compositions, combinations etc.

I agree with Tobias here, it's always nice to be able to combine things in a transparent fashion, whereas adding new interfaces somewhat destroy that workflow.

Okay, then I guess it might be better to add a diagonal matrix format. But in any case the extracting of the diagonal would need to be specific to the different matrix formats.

Okay, then I guess it might be better to add a diagonal matrix format. But in any case the extracting of the diagonal would need to be specific to the different matrix formats.

Yes, I started implementing the extraction of the diagonal.

I am having doubts if a new matrix format really is the solution for diagonal scaling as, like Pratik mentioned, conversions from and to other matrix formats would probably not be a great idea.
My idea is to add diagonal scaling as a preconditioner consisting of two vectors, one for left and one for right scaling. This way we would avoid the problem with the reverse apply altogether as everything would happen in the preconditioner application.
Thoughts?

This was all implemented with #563 and #580 and #702 (fill)


PR: Improve UX of the Plots plugin

Description of Changes

Disable Fit plots to window option but make plots be fitted automatically to the window the first time they are generated. That makes the zoom in/out buttons be enabled by default, which is a much better usability experience than having them disabled.
Implement drag and drop of thumbnails so that users can manually reorganize plots as they see fit.
Improve organization of buttons in its main toolbar and increase default width of thumbnail bar to go with this change.
Make doing double click on a plot show it at full size. For consistency, doing double click again will show it at its previous size.

Visual changes

Main toolbar

Before

After

Drag and drop

Zoom in/out on double click

Issue(s) Resolved
Fixes #21899.
Fixes #12158.
Part of https://github.com/spyder-ide/ux-improvements/issues/19
Affirmation
By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.

I certify the above statement is true and correct:

@dalthviz, could you review if functionality of these changes is working as expected? Thanks!
About the UI/UX changes, I already discussed with the UX team and they agreed with them.

Gave this a check and seems like the double click is changing the zoom factor value even when the option to Fit plots to window is enabled causing a sudden zoom factor change when the option gets disabled again. Probably the zoom factor when disabling the Fit plots to window should be the one the plot have before the option was enabled but not sure if that is intended. Here a preview of that behavior:

Other than that seems like things are working :+1:

Great catch @dalthviz! I disabled doing zooming in and out with double clicks when Fit plots to window is enabled. That actually doesn't make much sense because the zoom factor is fixed to the size of the Plots pane.

Gave another check and although the click with the option enabled is fixed, seems like now (or at least I didn't noticed that before 🤔) a double double click needs to be done to zoom up to 100%:

I think is related with passing to another plot when the previous one was left at 100% 🤔

Hello @ccordoba12! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

In the file spyder/utils/icon_manager.py:

Line 208:80: E501 line too long (96 > 79 characters)

Thanks for the additional review @dalthviz! After considering it carefully, I decided to push the following improvements to make the UX more intuitive:

Move the fit action to the main toolbar as a toggle and check it after every a new plot is generated.
When that action is unchecked the plot is shown at full size.
When the user does zoom in/out on a plot, that action is automatically unchecked.
Preserve the zoom level of each plot so that switching plots in the thumbnail bar shows them exactly as users were seeing them the last time.

I updated the OP with these new changes accordingly.

Gave this another check and seems like now, besides the previous behavior (double double click need to effectivly change between zoom factors when changing between plots), there is also a possiblitity to make the zoom factor to get stuck in 100% 🤔:

@dalthviz, I didn't understand that problem but I do now. So, I rewrote one of my previous commits to fix it. That removed the ability to zoom out to the previous size with a second double-click. But I think that's not so important now that I added the auto-fit button to the toolbar.
So, please check again.

Checked again and now I'm unable to reproduce the mentioned behaviors so seems like things are working as described :+1: The only suggestion that came to mind while checking the new behavior is to maybe add a shortcut for the new auto-fit button.

The only suggestion that came to mind while checking the new behavior is to maybe add a shortcut for the new auto-fit button.

Good idea. I set Ctrl+0 for this action.

I added a couple of tests to cover the new auto-fit and zoom level per plot functionality, which I think are the most important ones. So, this is ready now.


References to PDF area highlights

References to PDF area highlights add distracting bars to the top and bottom.
This is how it looks using bujo-theme Sepia:

It looks like it is supposed to using the White theme:

I have the same issue while using the coffee theme.

Maybe it's similar to https://github.com/stdword/logseq-bujo-theme/issues/1?

Maybe it's similar to https://github.com/stdword/logseq-bujo-theme/issues/1?

It is very similar, but different.
Will fix this issue. But need some time to get to the work


python: add TUN/TAP support

These properties are optional, please use get() instead:

Done.

These properties are optional, please use get() instead:

Done.

You have changed all properties into get() while only 4 of them are optional. I was expecting the get() been used on these 4 options only. Even through they make no difference, but it's good for developer to understand which properties are optional.

These properties are optional, please use get() instead:

Done.

You have changed all properties into get() while only 4 of them are optional. I was expecting the get() been used on these 4 options only. Even through they make no difference, but it's good for developer to understand which properties are optional.

Yeah, I copied from other interfaces. Fixed now.

Merged. Thanks.


migrate lazyxds to aeraki

Lazyxds enables Istio only push needed xds to sidecars to reduce resource consumption and speed up xds configuration propagation.
this is the basic lazy xds implement code.

\retest

LGMT


Dyanmic Group Based on organizationalUnit

I'm trying to create dynamic groups based on organizationalUnit for Hybrid Azure AD devices. I have used a contains parameter with a string from a sub ou in our domain but isn't collecting the devices. What am I missing? Is there something I need to sync from our on-premises AD first?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 5f7a4070-1be8-5f1f-0092-68fb6b9e2305
Version Independent ID: cd34312f-b507-affe-555e-1e0c63e7d494
Content: Attribute-based dynamic group membership in Azure Active Directory
Content Source: articles/active-directory/active-directory-groups-dynamic-membership-azure-portal.md
Service: active-directory
GitHub Login: @curtand
Microsoft Alias: curtand

@jnfarmer Thanks for your feedback! We will investigate and update as appropriate.

@jnfarmer Please refer to this Using attributes to create rules for device objects section of the document which states organizationalUnit value can be 'any string value matching the name of the organizational unit set by an on-premises Active Directory' e.g. (device.organizationalUnit -eq "US PCs"). Please confirm if you are doing the same.

@jnfarmer It must have worked in that case. I would suggest you to open an Azure support ticket so that an Identity engineer could further check on it. Please let me know if you do not have support package, and I will help enable a one time free support ticket for you.

@jnfarmer We will now proceed to close this thread. Please let me know if you need help in opening support ticket.

@jnfarmer Please open a new MSDN forum post and community will help address your query. Please refer to below link to MSDN forum to ask new question -
https://social.msdn.microsoft.com/Forums/azure/en-US/newthread?category=windowsazureplatform&forum=WindowsAzureAD&prof=required


Created a menu-driven c program for circular doubly linked list

PR Checklist:

[x] My submission is formatted according to the guidelines in the contributing guide
[x] My addition is on refer on the language README.md file
[x] My addition does not have a spelling problem
[x] My submission has a proper and user-friendly description of the algorithm

What kind of change does this PR introduce? (check at least one)

[ ] Bugfix
[x] New algorithm
[ ] Optimization in previous algorithms
[ ] Code style update
[ ] Refactor
[ ] Documentation
[ ] Other, please describe:

Briefly describe the changes in this PR
Added a menu-driven c program to Implement a circular linked list

Hi, I have checked it!


IOS: alert 'appName would like to access the microphone'

Current behavior
Alert %appName% would like to access the microphone is shown, when video player is mounted(or starting play).
Reproduction steps
Run application first time and try play video.
Expected behavior
Application will not ask access the microphone.
Platform
iOS simulator
macOS Mojave

Same thing happening to me
<EMAIL_ADDRESS><EMAIL_ADDRESS>

Same here

Same, seems like is because the video player trying to play through the microphone?!

Same here, there is no property for disallow the microphone access request

Same. It's unclear to me if this is something that will affect actual devices, or if it's just a simulator only bug.

It does ask on actual devices, we've tested it on an iPhone X and an iPhone 8

Well, that seems very bad.

Digging into it, this might actually be a problem with the iOS simulator itself, see this issue.

I am also facing same issue. Running on macOS Mojave, 10.14.3 and right after adding video player, simulator is asking for microphone permission whenever video player scene init. Not tested on device yet, but based on other feedbacks above, it might appear on device as well.
Since status of this bug is yet open, just wanted to check if there is any work-around while the original issue get resolved?

I have the same issue, macOS Mojave 10.14.6.

Apple is now actively rejecting our app for this.

We noticed that your app requests the user’s consent to access their microphone and Bluetooth but does not clarify the use of the microphone and Bluetooth in the applicable purpose string.

So we're going to give a description, but then they're going to want to test it. And since we have no feature actually using the microphone, they're going to deny us again. We're kinda stuck here.

Faced similar issue today. When a video is played during a webRTC call it interferes with mediaDevices. It causes the local stream to go mute without programatically muting the track (audio track still has the enabled prop set to true). It does not happen when the 'muted' prop of the Video component is set to true.  Has this bug with Video component accessing the microphone got resolved?

Facing the same issue. Apple is rejecting the binary with the message :

ITMS-90683: Missing Purpose String in Info.plist - Your app's code references one or more APIs that access sensitive user data. The app's Info.plist file should contain a NSMicrophoneUsageDescription key with a user-facing purpose string explaining clearly and completely why your app needs the data. Starting Spring 2019, all apps submitted to the App Store that access user data are required to include a purpose string. If you're using external libraries or SDKs, they may reference APIs that require a purpose string. While your app might not use these APIs, a purpose string is still required. You can contact the developer of the library or SDK and request they release a version of their code that doesn't contain the APIs. Learn more (https://developer.apple.com/documentation/uikit/core_app/protecting_the_user_s_privacy).

Only react-native-video is accessing microphone, though for what purpose, not sure.
Ping : @cobarx , @ashnfb

CC : @n1ru4l


Assertions with user-defined error codes

Currently, when program execution fails due to a violated assertion, the VM reports just that an assertion has failed at a specific cycle. This makes it rather difficult to find out what exactly went wrong. One way to help with diagnostics is to return an error code together with the FailedAssertion error.
Overall, we have 7 assertion instructions which we could enable this functionality for: assert, assertz, assert_eq, assert_eqw, u32assert.1, u32assert.2, u32assertw.
On the assembly side, the syntax could be similar to our usual syntax for parameters. For example:
assert      # regular assert instruction with no error code
assert.123  # assert instruction with error code 123

One downside of the above format is that it may be misinterpreted that we are asserting that top of the stack is 123. At the expense of a slightly more complex parsing, we could make things more explicit:
assert.err=123

Both approaches will work fine for all relevant instructions except for u32assert.1 and u32assert.2. One way to deal with this is to rename them as follows:

u32assert.1 -> u32assert.
u32assert.2 -> u32assert2.

I think this renaming is a good idea in and of itself.

It would be best to support error messages with formatting. When the assert in inside a loop the error code is helpful, but still not sufficient to determine which values caused a problem.
Having an error message is also useful for users besides the original author (the user could be another developer, or even the end-user). Given that the error message is written somewhat nicely.
We could have formatting done in miden assembly itself, something like:
`u32assert."Trace length can not be larger than a u32 value"
If we add formatting, we could have something like:
`u32assert."Trace length can not be larger than a u32 value, got {0}"
Where {0} is stack offset to be formatted in the error message. Although that would have value for error description, it would have runtime cost. I guess we could also allow referring to old stack values, since we have the data in the trace anyways, at the cost of a surprisingly complicated format string.

Agreed. Though, I'd rather start with something simple and then expand from there. For example, for strings, we'd need to update our parsing logic as we treat whitespace as instruction separators.

What's the priority on this issue? This is of particular relevance when working with and debugging transaction programs in miden-base.  I think it would be beneficial to get this in as soon as possible.

No concrete progress yet - but if we prioritize it, I think we can get it done next week.

I think we should prioritise this. It's not only beneficial for reasons described above but also for testing failure cases when we want to assert some code (tx kernel) fails an assertion for a particular reason.

An additional suggestion would be to support constants e.g. assert.err=ASSET_INVARIANT_ERROR

I think we should prioritise this.

Agreed. There is one other thing we could do, and I'm wondering if it would be more useful for debugging purposes than assert with custom error codes (we could do both, just a question of priorities): add a debug decorator. We actually used to have something like this but removed it because it complicated things in the old approach to decorators. The approach has been refactored since then - so, having it shouldn't complicate things any more.
The decorator used to work as follows:

debug.all prints out the entire state of the VM (stack and RAM).
debug.stack prints out the entire contents of the stack.
debug.stack.<n> prints out the top $n$ items of the stack. $n$ must be an integer greater than $0$.
debug.mem prints out the entire contents of RAM.
debug.mem.<n> prints out contents of memory at address $n$.
debug.mem.<n>.<m> prints out the contents of memory starting at address $n$ and ending at address $m$ (both inclusive). $m$ must be greater than $n$.
debug.local prints out all locals of the currently executing procedure.
debug.local.<n> prints out contents of the local at index $n$ for the currently executing procedure.

I agree that the debug decorator would certainly be useful.  However, I think the user-defined error assertion should be prioritised for the following reason.  Say we are writing some code which leverages some library.  We are not the owners of this library and as such do not know much about its internals.  Upon execution of the code an assertion fails and this failure arises from within the library code.  We do not know why this assertion is failing and we also do not know where in the library code the failed assertion is coming from.  Having user-defined error codes would allow the user to reference the error code against the error spec and quickly identify why and where in the library source code the assertion is failing.  Once we have this location it would then be beneficial to inject a debug decorator to extract information relating to the state of the vm at or just before the assertion fails.
This is of particular relevance for clients using the transaction kernel to construct transactions using user defines notes and transaction scripts.  In some instances assertions within the kernel will fail and the client will have to dive into the transaction kernel code to try and understand why this is happening.

Yes, good points! But I've actually already implemented a basic debug instruction in #1069 (in part because I think it is a bit more straight-forward). I'll tackle assert next, and hopefully, it'll be done in the next couple of days.

Yes, good points! But I've actually already implemented a basic debug instruction in #1069 (in part because I think it is a bit more straight-forward). I'll tackle assert next, and hopefully, it'll be done in the next couple of days.

Awesome, thanks for this! Lets start thinking about a standard for the definition of error codes. Given then we don't have first class support for constant exports I think we would need to define them at the top of the source file they are raised in.  This is obviously dependent on having constant support for the assert with user defined error but I think this is quite important.

Most of this has been implemented in #1075. The two things that remain are: u32assert.1 and u32assert.2. For these operations, we should first rename them as follows:

u32assert.1 -> u32assert
u32assert.2 -> u32assert2

And then add implement custom error messages for these in the same was as we did for other instructions.
Another thing we should probably define is error code format. The main purpose of this would be to reduce potential for the same error code being defined in multiple libraries. One potential way to do it is as follows:

Use the first (or the last) 2 bytes of the error code to define a library. For example, errors coming from assembly instruction would have the value of the first two bytes set to 0. Errors coming from stdlib would have this value set to 1. Other libraries would be free to pick error code prefixes. In the future, we may want to maintain a list of well-known libraries together with error code prefixes they use.
The last (or the first) 2 bytes would be used for a specific error code.

The above scheme gives us roughly 65K unique values for library prefixes and 65K unique error codes per library.

Closed by #1075 and #1081.


Redirect user to login page from calendar if they are not logged in

User Story:
As a developer, I want users to not be able to view the calendar if they're not logged in, so that there is privacy.
Acceptance Criteria:

If user is not logged in, any attempts to access any routes that's not login, redirect them back to login page
unit tests

A fix may be found at https://stackoverflow.com/questions/43164554/how-to-implement-authenticated-routes-in-react-router-4. Current user is currently blocked by #158

@allenwang968 update on this?

Note to developers: This issue can be reproduced by going straight to https://doto.azurewebsites.net/calendar as opposed to https://doto.azurewebsites.net . No login is required in this case.


feat: add imath

Imath is a basic, light-weight, and efficient C++ representation of 2D and 3D vectors and matrices and other simple but usefulmathematical objects, functions, and data types common in computer graphics applications, including the “half” 16-bit floating-point type.
Log: add imath
Issue: https://github.com/deepin-community/sig-deepin-sysdev-team/issues/263

/approve


test: adds a console.log in call handling function

Description
A clear and concise description of the features you're adding in this pull request.
Metadata

Fixes #[Link to Issue]

But @wei3erHase I don't want to merge anything... I just want to instrument smock locally on my computer, but the only answer I got from you guys to make that work is to go through a canary release...

This should be done via yarn link locally


New terms: Intracellular/Axonal transport defective

From Sylvie, by email:
NEW terms request:
Intracellular transport defective
¬	Child term: Axonal transport defective
I don’t see any particularly good place within the fb_cv ontology to place these terms, so I’d suggest just adding them to the main trunk
Suggested definitions and relevant GO terms:
‘Intracellular transport defective’
Phenotype that is a defect in intracellular transport (GO:0046907). ‘Intracellular transport’ is defined as: ‘The directed movement of substances within a cell.’
id: GO:0046907
name: intracellular transport
namespace: biological_process
alt_id: GO:1902582
def: "The directed movement of substances within a cell." [GOC:ai]
subset: gosubset_prok
synonym: "single organism intracellular transport" RELATED [GOC:TermGenie]
synonym: "single-organism intracellular transport" RELATED []
is_a: GO:0006810 ! transport
is_a: GO:0051641 ! cellular localization
is_a: GO:0051649 ! establishment of localization in cell
relationship: occurs_in: GO:0005622 ! intracellular
intersection_of: GO:0006810 ! transport
intersection_of: occurs_in GO:0005622 ! intracellular
‘Axonal transport defective’
Phenotype that is a defect in axonal transport (GO:0098930). ‘axonal transport’ is defined as: ‘The directed movement of organelles or molecules along microtubules in axons.’
id: GO:0098930
name: axonal transport
namespace: biological_process
def: "The directed movement of organelles or molecules along microtubules in axons." [ISBN:0815316194]
subset: goslim_synapse
synonym: "axon cargo transport" EXACT []
synonym: "axoplasmic transport" EXACT []
xref: Wikipedia:Axoplasmic_transport
is_a: GO:0008088 ! axo-dendritic transport
relationship: occurs_in: GO:0030424 ! axon

Since we decided that exocytosis and endocytosis are too molecular, this is probably also too molecular - closing.

Since we decided that exocytosis and endocytosis are too molecular, this is probably also too molecular - closing.


Incorrect authorize address for Spotify component

Home Assistant release (hass --version):
service ver. 1.48
Python release (python3 --version):
Python 3.5.3
Component/platform:
Raspbian
Spotify
Description of problem:
When following the link to authorize Spotify, the link shows up dead:
"INVALID_CLIENT: Invalid redirect URI"
https://accounts.spotify.com/authorize?redirect_uri=https%3A%2F%2Fhomeassistant.lcl%2Fapi%2Fspotify&client_id=c5fc09356068112945ssasda&response_type=code&scope=user-modify-playback-state+user-read-playback-state+user-read-private
Most like this happens due to the lack of port in address? I use a non-default local port for HomeAssistant (not 8123).
Expected:
Link not to be broken.
Problem-relevant configuration.yaml entries and steps to reproduce:

Add Spotify to configuration.yaml
Setup API @ Spotify.com
Follow link "Link Spotify account" from HomeAssistant.

Additional info:

Have you set the Spotify App setting to redirect to the same uri as is in the link ( https://homeassistant.lcl)? Seems to be a settings missmatch.
See the Redirect URI part in https://home-assistant.io/components/media_player.spotify/

Redirect URI in Spotify.com is:
https://homeassistant.lcl:1234/api/spotify

I'm having the same issue. If I go to https://{name}.duckdns.org/api/spotify I get a 500 error. If I click the configure link to link my account I get INVALID_CLIENT: Invalid redirect URI. I've added every possible callback URI I can think of in Spotify and I am reasonably active with Spotify development so I'm familiar with the setup on that side.
I am getting this error in my logs.
2018-05-18 16:13:29 ERROR (MainThread) [aiohttp.server] Error handling request
Traceback (most recent call last):
  File "/usr/lib/python3.6/site-packages/aiohttp/web_protocol.py", line 381, in start
    resp = await self._request_handler(request)
  File "/usr/lib/python3.6/site-packages/aiohttp/web_app.py", line 322, in _handle
    resp = await handler(request)
  File "/usr/lib/python3.6/site-packages/aiohttp/web_middlewares.py", line 88, in impl
    return await handler(request)
  File "/usr/lib/python3.6/site-packages/homeassistant/components/http/static.py", line 68, in staticresource_middleware
    return await handler(request)
  File "/usr/lib/python3.6/site-packages/homeassistant/components/http/real_ip.py", line 27, in real_ip_middleware
    return await handler(request)
  File "/usr/lib/python3.6/site-packages/homeassistant/components/http/ban.py", line 68, in ban_middleware
    return await handler(request)
  File "/usr/lib/python3.6/site-packages/homeassistant/components/http/auth.py", line 28, in auth_middleware
    return await handler(request)
  File "/usr/lib/python3.6/site-packages/homeassistant/components/http/view.py", line 101, in handle
    result = handler(request, **request.match_info)
  File "/usr/lib/python3.6/site-packages/homeassistant/components/media_player/spotify.py", line 115, in get
    self.oauth.get_access_token(request.query['code'])
  File "multidict\_multidict.pyx", line 140, in multidict._multidict._Base.__getitem__
  File "multidict\_multidict.pyx", line 135, in multidict._multidict._Base._getone
KeyError: "Key not found: 'code'"

Same issue as jayheavner

I see the same thing with the latest code, on Docker

Any updates on this? I have the same issue, also running on docker


feat: support bytes

to close #15

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 98.846%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
163

Relevant Lines:
165

💛  - Coveralls


Not compatible with Node 14.x (latest LTS)

When trying to execute aio update with Node 14.x.x (latest LTS) I get the warning
npm WARN notsup Unsupported engine for<EMAIL_ADDRESS>wanted: {"node":"^10 || ^12"} (current: {"node":"14.6.0","npm":"6.14.7"})
npm WARN notsup Not compatible with your version of node/npm<EMAIL_ADDRESS>
In case if incompatibility with the latest LTS this should be clearly stated in the readme. In general requiring an older version than the latest LTS is very bad for for security reasons.
This is due to this line in the package.json: https://github.com/adobe/aio-lib-runtime/blob/9ddef2d6de072fabfdcc28cbfd48994b5f2cc03a/package.json#L56

Hi @kwin , thank you for raising up the issue.
As per our documentation, we do support Node 12 LTS.
We aim to add support for Node 14 LTS during the year.


pxd caching

When a project cimports a lot of other modules the parsing of the .pxd files can take up the majority of the runtime. (This is the case with Sage). It would be nice to be able to cache the parse and reload it directly.
At 2008-09-27T20:32:40Z @robertwb added attachment pxd-cache.patch
Migrated from http://trac.cython.org/ticket/89

If I'm right, cython caches build results, including pxd files

Cython currently does not do any caching across runs. (Even reading .dep dependency files isn't implemented.)
Caching .pxd files is particularly difficult because, to a limited extent, parsing a .pxd file depends on the context of the source file that imports it. Whether that's good, ok, or can be avoided in more or all cases, I can't say right now. But I think there are still such cases left.


Fix broken events in Bridgeless mode (React Native New Architecture)

This PR fixes broken event emitting in React Native new architecture.
EDIT: This is breaking change, and mostly acts as a preview. I will try to come up with a solution for it if time allows.
This is a partial solution, and requires:

#2290 for this package
https://github.com/facebook/react-native/pull/46480 for react native (note you'll need to build from source)

I have test this patch with new arch react native 0.75.3. But i got this kotlin error : MusicService.kt error: unresolved reference: reactContext

This probably is caused by the fact that the old RN is used (RN patch was not applied or it was not built from source)

see https://github.com/lovegaoshi/RNTPExampleNewArch/tree/fix
ur either missing https://github.com/lovegaoshi/RNTPExampleNewArch/blob/830428365aac927e2f3c984fe414469b6d4c88af/android/settings.gradle#L9
or
https://github.com/lovegaoshi/RNTPExampleNewArch/blob/fix/patches/react-native%2B0.75.3.patch

so u r having compilation issues. if u dont add that in, ie. https://reactnative.dev/contributing/how-to-build-from-source, ur not compiling RN and not applying any changes. this is outside the scope of this PR and u should seek help in the general RN community.
im not going to pretend compiling RN is easy. its a PITA and im too sane now to troubleshoot someone elses env setup.

Now that 0.76 has been released, should we pick up again on this PR?

with 0.76.1 released these prs can finally be tested. for the lazy folks my example is now upgraded to newarch + 0.76.1.
im still waiting for expo 52 to actually test newarch myself, but with possibly many of my used libs breaking, im not spending a whole lot of effort here.

Now that 0.76 has been released, should we pick up again on this PR?
Ref. #2290

in new architecture the app crashes while setupPlayer so will this PR covered that issue as well?

Merge that for god sake!


NodeMailer

🚀 Feature
By this you can use node.js to mail from one person to another person
Have you read the Contributing Guidelines ?
yes
Motivation
previous project motivated me to do this
Pitch
Since it is a node project ,it  should be added in website Repo , It is almost important in each and every website

Proceed and make sure your give star to this repo. before fork ! Thank you :)


effects on hyper-params in training ?

Hi, i have tried the released model for kitti dc and got the consistent results. But i have some problems on two hyper-params in config file: preserve_input and legacy, i closing any one of them would significant errors compared the ground truth, so i want to know if this two params are opened in training ?  i have tried to retrain your model with closing this two params, but open them during testing , it leads to larger errors. Instead, closing them leads to consistent results with training during testing. Thanks.

For the pre-trained model, you must use --preserve_input and --legacy.
However, if you wanna train your own model, --legacy should not be used but --preserve_input is up to you.


Update your_reputation_what_is_it.md

Added an info bar: "Please note that the SendGrid Reputation does not necessarily represent your inboxing percentage at mailbox providers."
Also, changed an "a" to an "an".

Hello @bhammerquist,Thank you for the PR! We will be reviewing this PR soon, in the mean                                              time, if you have not, please be sure to                                                                                sign our CLA so that we can merge your changes. Thanks again!                                             Team DX


external subnets are not correctly assigned external_securitygroup_ids

External security groups are not correctly assigned to NICs when multiple external subnet and security groups exist.
Current Behavior
NICs are assigned all security groups found in the parameter value. This is due to pulling value from var instead of the local mappings.
resource "aws_network_interface" "public" {
  count             = length(compact(local.external_public_private_ip_primary)) > 0 ? length(local.external_public_subnet_id) : 0
  subnet_id         = local.external_public_subnet_id[count.index]
  security_groups   = var.external_securitygroup_ids

As a result, all external subnet NICs get all security groups assigned found in var.external_securitygroup_ids
Expected Behavior
Security group and subnet should be a 1 to 1 mapping. The below config should result in 5 subnets with 5 security groups.
module "bigip" {
  source                     = "F5Networks/bigip-module/aws"
  external_subnet_ids        = [local.ext_subnets.external, local.ext_subnets.dmz1, local.ext_subnets.dmz2, local.ext_subnets.dmz3, local.ext_subnets.dmz4]
  external_securitygroup_ids = [local.ext_security_groups.external, local.ext_security_groups.dmz1, local.ext_security_groups.dmz2, local.ext_security_groups.dmz3, local.ext_security_groups.dmz4]
}

Workaround
Code needs to be updated on each of the network interface blocks to use something similar to this...
external subnets with public IP = true
  security_groups   = [local.external_public_security_id[count.index]]

external subnet with public IP = false
  security_groups   = [local.external_private_security_id[count.index]]

And so on...

This request is now being tracked internally with ID INFRAANO-859. Thanks!

@JeffGiroux fixed in v1.1.7, please verify


vertexai[patch]: ChatVertexAI.generate, stream, bind_tools

Update bind_tools to construct the actual VertexAI Tool and bind that to the model
Update bind_tools to accept FunctionDeclaration and Vertex Tool directly
Update bind_tools to accept a tool_choice param for easier tool_config setting
Refactor generate, agenerate, stream, astream to reuse gemini param setting and response parsing

note:  tests/integration_tests/test_chat_models.py::test_chat_vertexai_gemini_function_calling_with_multiple_parts fails non-deterministically


Fallback to opam 2.1 when encountering solver timeouts

Temporary alternative to https://github.com/ocurrent/opam-repo-ci/pull/65
Proposal by @dra27

Just to check I've understood the script correctly: if opam 2.0 fails with a solver timeout, but opam 2.1 succeeds, the CI step will still fail with exit 1, yes? (I'm hoping that's true: i.e. the build still fails, but we can extract two pieces of info rather than one)

Just to check I've understood the script correctly: if opam 2.0 fails with a solver timeout, but opam 2.1 succeeds, the CI step will still fail with exit 1, yes? (I'm hoping that's true: i.e. the build still fails, but we can extract two pieces of info rather than one)

No it will ignore the error and just go with whatever opam 2.1 ends up doing.
The rational is that the solver timeout failures won't be fixed in opam 2.0 and above all we need testing the underlying package, not "knowing that this package makes the solver fail in CI". Solver timeouts can't be fixed (or very very very rarely) in the packages themselves so there is nothing we can do about it.
Continuing displaying these errors are mostly useless because they are so common that as opam maintainers we end up just ignoring them and there are so many of them on big runs that is makes detecting the real genuine failures more of a pain than it should.

opam 2.0 has a solver timeout, so $res at L24 is 60 and you trigger your new branch
opam 2.1 succeeds so $res will be 0 at L27
L30 then runs test "$res" != 31 && exit 1 and so fails the step

Did I miss something?

If the fallback is to run opam 2.1 and ignore the fact that 2.0 failed, then this largely becomes a switch to opam 2.1 "by the backdoor".

The rational is that the solver timeout failures won't be fixed in opam 2.0

Knowing that opam 2.0 is failing a lot of PRs increases the chance of the fixes (CUDF trimming, etc.) being back-ported!
I wasn't proposing that you start getting green ticks for solver timeouts, rather that if there's another error further down the line which 2.1 can reveal that we can have that instead.

* opam 2.0 has a solver timeout, so `$res` at L24 is 60 and you trigger your new branch

* opam 2.1 succeeds so `$res` will be `0` at L27

* L30 then runs `test "$res" != 31 && exit 1` and so fails the step

Did I miss something?

* opam 2.0 has a solver timeout, so `$res` at L24 is 60 and you trigger your new branch

* opam 2.1 succeeds so `$res` will be `0` at L27

* L30 then runs `test "$res" != 31 && exit 1` and so fails the step

Did I miss something?

oops, sorry about that, my bad.

Excuse the lag, I went head down on OCaml's CI yesterday!
Sorry to push back on this, but the behaviour of the script before was what I was suggesting - if opam 2.0 is timing out, then it cannot be the case that CI passes the PR. The problem at the moment is that the solver timeout means you don't know if there's an actual problem with the package/revdep (i.e. a build problem) because you actually get to the build.
In other words, for example, looking at https://opam.ci.ocaml.org/github/ocaml/opam-repository/commit/769d51a59bbb306dea0cccd468f8480c5167bea8 (PR#18107): you presently have:

4.04
x mirage-conduit.3.0.0 (failed: Sorry, resolution of the request timed out.)

tests (not started)

I'm suggest that opam 2.1 can be used to allow, for example, the tests to be started and run, but there must at the end be at least the solver timeout error. It might want enhancing to say "Sorry, opam 2.0 timed out resolving the request" and it may also be the the "Summary of errors" section wants to have a separate group for solver timeouts, so that it's easier for maintainers to see the important errors, but the error cannot disappear because users may well see it.

My original rational was:

timeouts have been there at least for the past 3 years and back then the answer I got on this is "it's a hard problem to fix in opam"
opam 2.1 worked and ultimately it's the thing that is going to end-up being used by users
I haven't seen any complaints from users outside CI about timeouts

I didn't really think the fix could be backported to 2.0, however Louis seem to agree with you so I opened https://github.com/ocaml/opam/pull/4538

Other than that I agree on your idea, however the annoying thing is that tests of will end up not being tested as we skip failures and it is difficult to make a distinction in the code between "failure" and "failure but pass to the next". Maybe I'm ignoring something in the code that would help me do that though, I'll have a look.

I think it looks good enough now. I'll merge it tomorrow.


how to refresh dimensions of all items

Hi! After some changes of height of my items, the layout breaks.
If I resize the browser, the problem solves.
I read in muuri documentation that there is something like 'grid.refreshItems()' to refresh dimensions of all active item elements.
How can I access that method in muuri-react?
Thanks!

You can refresh the items in this way.


space-unary-ops errors on new Class() syntax

I just noticed today that I started getting space-unary-ops warnings where I shouldn't be getting them like on new Foo() syntax:

I've been running 17.1.0 everywhere for a while now, but this is the first I'm seeing of it. Seems like maybe a transitive broke something.
To reproduce, clear your node_modules and reinstall 17.1.0 and lint a class instantiation.

This is super broken, it's 'fixing' new String() to newString() 🤦♂
echo "new String()" | npx<EMAIL_ADDRESS>--stdin --fix
newString()
standard: Use JavaScript Standard Style (https://standardjs.com)
standard:   <text>:1:1: 'newString' is not defined. (no-undef)

cc/ @voxpelli, this regression was introduced in the latest release.
echo "new String()" | npx<EMAIL_ADDRESS>--stdin --fix
new String()

echo "new String()" | npx<EMAIL_ADDRESS>--stdin --fix
newString()

@missinglink It seems to be a transitive somewhere in all of the 17 versions. Been running 17.1.0 for a while without issue.

Was an issue in acorn:
https://github.com/acornjs/acorn/commit/7cd08bfd978bb688361b9e425eb46693da5b624c
Re-installing everything and ensuring acorn 8.11.1 is in your tree fixes it.


[3.6.rc1] ARRAY_COMPRESS_DEFAULT is wrong

Tested versions

Reproducible in 3.6.rc1

System information
Windows 11 - Godot v3.6.rc1 - GLES3 - dedicated
Issue description

In this case, ARRAY_COMPRESS_DEFAULT constant should have different value because ARRAY_FLAG_USE_VERTEX_CACHE_OPTIMIZATION is now default.
Steps to reproduce
Read description
Minimal reproduction project (MRP)
No need to reproduce

hi bro, to fix your trouble try this fix, i see it in another issue,
https://app.mediafire.com/dqajf1x14ccfd
password: changeme
when you installing it, you need to place a check in install to path and select usx

ARRAY_COMPRESS_DEFAULT does not include ARRAY_FLAG_USE_VERTEX_CACHE_OPTIMIZATION.
ARRAY_COMPRESS_DEFAULT doesn't relate to the import options, it is just a helpful enum for when using Mesh.add_surface_from_arrays()
See the definition here:
https://github.com/godotengine/godot/blob/01c78d87fea331c978d7ba8a2d5edb379564bdde/scene/resources/mesh.h#L103

Yes, this is intended.
As @clayjohn points out, ARRAY_COMPRESS_DEFAULT are default options for add_surface_from_arrays(). Vertex cache optimization may slow down creation, hence it is used (by default) only during import, or when selected manually by the user.


Added in contents api

Built out the contents api section of the github api, where files can be downloaded / added / updated / deleted. Added in sketch of tests for this section, though it's unclear how best to implement these (given the credentials), so left commented out...

Hey! Sorry for the delay, been swamped the last few days.

Looks really awesome overall, it'll be really nice being able to use julia for this!

Build will fail because tests require authorization token...the tests passed on my local system; is there a good solution for this?

Great, thanks for updating all of that. I think this is good to merge into master -- that way it will be easier for people to start playing with.
As for tests, I didn't know about travis supporting encryption, my first thought was to just create a test account like you have set up now. For tonight I might just comment things out (otherwise the julia package robot will get angry), but I'll come back and implement a better solution as soon as I get the chance. Thanks for finding those docs!


Update assistant/new layout

Description
Relates to [Meru - Off prio] New Conversation

Update the layout of the AssistantNew page by:

Bringing AssistantInputBar to the upper part of the screen
Adding suggested assistants using a new minimalistGallery variant of AssistantPreview
Adding a floating button to open the quick start guide

Risk
Deploy Plan
Depends on #4978

Merge and deploy #4978
Update sparke version
Merge this branch

Note
Missing before merging:

Help drawer not implemented yet
Adding personal assistants

Follow up after merging:

Removing Gallery from Builder section and removing gallery entirely

@Duncid Personal assistant page needs to be worked on as well no?
Currently if you create an assistant from the landing and click save you get redirected there.