[DISCUSSION] Resource linking failed during Android Studio build

About this discussion
I tried building Lawnicons from my fully up-to-date fork but it failed with an exception. The drawables it's looking for (referenced in lines 4-23 of grayscale_icon_map.xml) are indeed not located in res/drawable anymore, but so are all the other drawables in grayscale_icon_map.xml? Is this a known issue during the transition to the new icon system or is there something I can do to fix it? If there is any more information you need in order to be able to understand this behaviour I'll be happy to provide it.
The exact output is as follows:
`Execution failed for task ':app:processAppDebugResources'.

A failure occurred while executing com.android.build.gradle.internal.res.LinkApplicationAndroidResourcesTask$TaskAction
Android resource linking failed
app.lawnchair.lawnicons.app-main-59:/xml/grayscale_icon_map.xml:4: error: resource drawable/aliucord_installer (aka app.lawnchair.lawnicons:drawable/aliucord_installer) not found.
app.lawnchair.lawnicons.app-main-59:/xml/grayscale_icon_map.xml:5: error: resource drawable/animiru (aka app.lawnchair.lawnicons:drawable/animiru) not found.
app.lawnchair.lawnicons.app-main-59:/xml/grayscale_icon_map.xml:6: error: resource drawable/bitrix24 (aka app.lawnchair.lawnicons:drawable/bitrix24) not found.
app.lawnchair.lawnicons.app-main-59:/xml/grayscale_icon_map.xml:7: error: resource drawable/camera (aka app.lawnchair.lawnicons:drawable/camera) not found.
app.lawnchair.lawnicons.app-main-59:/xml/grayscale_icon_map.xml:8: error: resource drawable/camera_date_folders (aka app.lawnchair.lawnicons:drawable/camera_date_folders) not found.
app.lawnchair.lawnicons.app-main-59:/xml/grayscale_icon_map.xml:9: error: resource drawable/coinvero (aka app.lawnchair.lawnicons:drawable/coinvero) not found.
app.lawnchair.lawnicons.app-main-59:/xml/grayscale_icon_map.xml:10: error: resource drawable/combined (aka app.lawnchair.lawnicons:drawable/combined) not found.
app.lawnchair.lawnicons.app-main-59:/xml/grayscale_icon_map.xml:11: error: resource drawable/coolapk (aka app.lawnchair.lawnicons:drawable/coolapk) not found.
app.lawnchair.lawnicons.app-main-59:/xml/grayscale_icon_map.xml:12: error: resource drawable/dialer (aka app.lawnchair.lawnicons:drawable/dialer) not found.
app.lawnchair.lawnicons.app-main-59:/xml/grayscale_icon_map.xml:13: error: resource drawable/duelyst (aka app.lawnchair.lawnicons:drawable/duelyst) not found.
app.lawnchair.lawnicons.app-main-59:/xml/grayscale_icon_map.xml:14: error: resource drawable/eksi_sozluk (aka app.lawnchair.lawnicons:drawable/eksi_sozluk) not found.
app.lawnchair.lawnicons.app-main-59:/xml/grayscale_icon_map.xml:15: error: resource drawable/erste_hilfe (aka app.lawnchair.lawnicons:drawable/erste_hilfe) not found.
app.lawnchair.lawnicons.app-main-59:/xml/grayscale_icon_map.xml:16: error: resource drawable/files (aka app.lawnchair.lawnicons:drawable/files) not found.
app.lawnchair.lawnicons.app-main-59:/xml/grayscale_icon_map.xml:17: error: resource drawable/fix_price (aka app.lawnchair.lawnicons:drawable/fix_price) not found.
app.lawnchair.lawnicons.app-main-59:/xml/grayscale_icon_map.xml:18: error: resource drawable/fxxxs_given (aka app.lawnchair.lawnicons:drawable/fxxxs_given) not found.
app.lawnchair.lawnicons.app-main-59:/xml/grayscale_icon_map.xml:19: error: resource drawable/goodline (aka app.lawnchair.lawnicons:drawable/goodline) not found.
app.lawnchair.lawnicons.app-main-59:/xml/grayscale_icon_map.xml:20: error: resource drawable/gramotnee (aka app.lawnchair.lawnicons:drawable/gramotnee) not found.
app.lawnchair.lawnicons.app-main-59:/xml/grayscale_icon_map.xml:21: error: resource drawable/grill_one (aka app.lawnchair.lawnicons:drawable/grill_one) not found.
app.lawnchair.lawnicons.app-main-59:/xml/grayscale_icon_map.xml:22: error: resource drawable/homeworker (aka app.lawnchair.lawnicons:drawable/homeworker) not found.
app.lawnchair.lawnicons.app-main-59:/xml/grayscale_icon_map.xml:23: error: resource drawable/kinopoisk (aka app.lawnchair.lawnicons:drawable/kinopoisk) not found.`

Ok so I tried removing one of the problematic lines in grayscale_icon_map.xml and adding the corresponding line in appfilter.xml and the error for that line disappeared. A new error appeared for line 24 though (previously the last line mentioned in the error message was 23), so I assume all lines in grayscale_icon_map.xml are effected and causing this error, but only 20 of them are shown.

As there is unchanged activity here I assume no one else is having this problem, does anyone know why this (having these resources mentioned in grayscale_icon_map.xml but not actually located in res/drawable) is not causing an error for you? It seems pretty logical to me, so I'm confused as to why this seemingly faulty code would run elsewhere (including, strangely, the Action Build Debug APK on this repo and on my fork). I tried reinstalling Android Studio and re-cloning the fork as well in the mean time, but that didn't change anything either. Any ideas would be greatly appreciated

I've temporarily solved the build error by commenting out all icon-tags inside grayscale_icon_map.xml.
It seems the missing drawables were removed in the process of switching to appfilter.xml, even though the respective lines weren't yet migrated from grayscale_icon_map.xml. They should be added to appfilter.xml now anyway, right? I know the needed information for one of the remaining lines of grayscale_icon_map.xml and I will add it at the end of this so somebody can add it, but I don't want to open any PRs myself until I am able to build properly again.
In doing that, I've run into a new problem, though, a RuntimeException, more specifically a ClassNotFoundException, which always occurs immediately after building when I try to open or apply Lawnicons. Obviously this could also be caused by whatever is causing the build error to be a problem for me, when it runs everywhere else regardless of the missing drawables.
Once again, any ideas as to why either of these problems is occurring or why the build error is not occurring anywhere else would be greatly appreciated.
The log output for the latter exception is as follows:
E/AndroidRuntime: FATAL EXCEPTION: main
    Process: app.lawnchair.lawnicons, PID: 6605
    java.lang.RuntimeException: Unable to instantiate application app.lawnchair.lawnicons.LawniconsApplication package app.lawnchair.lawnicons: java.lang.ClassNotFoundException: Didn't find class "app.lawnchair.lawnicons.LawniconsApplication" on path: DexPathList[[zip file "/data/app/~~xWIHus-tAqgf2eC01b73sw==/app.lawnchair.lawnicons-YVk_ID21uazr0ylO68WanQ==/base.apk"],nativeLibraryDirectories=[/data/app/~~xWIHus-tAqgf2eC01b73sw==/app.lawnchair.lawnicons-YVk_ID21uazr0ylO68WanQ==/lib/arm64, /system/lib64, /system_ext/lib64]]
        at android.app.LoadedApk.makeApplicationInner(LoadedApk.java:1513)
        at android.app.LoadedApk.makeApplicationInner(LoadedApk.java:1437)
        at android.app.ActivityThread.handleBindApplication(ActivityThread.java:7161)
        at android.app.ActivityThread.-$$Nest$mhandleBindApplication(Unknown Source:0)
        at android.app.ActivityThread$H.handleMessage(ActivityThread.java:2288)
        at android.os.Handler.dispatchMessage(Handler.java:106)
        at android.os.Looper.loopOnce(Looper.java:240)
        at android.os.Looper.loop(Looper.java:351)
        at android.app.ActivityThread.main(ActivityThread.java:8355)
        at java.lang.reflect.Method.invoke(Native Method)
        at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:584)
        at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1013)
     Caused by: java.lang.ClassNotFoundException: Didn't find class "app.lawnchair.lawnicons.LawniconsApplication" on path: DexPathList[[zip file "/data/app/~~xWIHus-tAqgf2eC01b73sw==/app.lawnchair.lawnicons-YVk_ID21uazr0ylO68WanQ==/base.apk"],nativeLibraryDirectories=[/data/app/~~xWIHus-tAqgf2eC01b73sw==/app.lawnchair.lawnicons-YVk_ID21uazr0ylO68WanQ==/lib/arm64, /system/lib64, /system_ext/lib64]]
        at dalvik.system.BaseDexClassLoader.findClass(BaseDexClassLoader.java:259)
        at java.lang.ClassLoader.loadClass(ClassLoader.java:379)
        at java.lang.ClassLoader.loadClass(ClassLoader.java:312)
        at android.app.AppComponentFactory.instantiateApplication(AppComponentFactory.java:76)
        at androidx.core.app.CoreComponentFactory.instantiateApplication(CoreComponentFactory.java:52)
        at android.app.Instrumentation.newApplication(Instrumentation.java:1251)
        at android.app.LoadedApk.makeApplicationInner(LoadedApk.java:1505)
        at android.app.LoadedApk.makeApplicationInner(LoadedApk.java:1437)
        at android.app.ActivityThread.handleBindApplication(ActivityThread.java:7161)
        at android.app.ActivityThread.-$$Nest$mhandleBindApplication(Unknown Source:0)
        at android.app.ActivityThread$H.handleMessage(ActivityThread.java:2288)
        at android.os.Handler.dispatchMessage(Handler.java:106)
        at android.os.Looper.loopOnce(Looper.java:240)
        at android.os.Looper.loop(Looper.java:351)
        at android.app.ActivityThread.main(ActivityThread.java:8355)
        at java.lang.reflect.Method.invoke(Native Method)
        at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:584)
        at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1013)
    	Suppressed: java.lang.NoClassDefFoundError: Failed resolution of: Lapp/lawnchair/lawnicons/Hilt_LawniconsApplication;
        at java.lang.VMClassLoader.findLoadedClass(Native Method)
        at java.lang.ClassLoader.findLoadedClass(ClassLoader.java:738)

The line for homeworker.svg:
<item component="ComponentInfo{info.xolf.homeworker/info.xolf.homeworker.MainActivity}" drawable="homeworker" />

Yeah, i am getting the same thing myself.
Deleting the file causes the compilation to fail, and deleting all of the entries in the file (for some reason), successfully compiles the app, but with no icons, even while working on a version of the repo completely up to date with the master branch.

@badlydrawnface Are you able to open the Lawnicons app after it's built or does it crash like it does for me? Because, as I've said, for me it installs but I can't open it, because of the ClassNotFoundException.
@naveenccmsd You largely managed the transition away from grayscale_icon_map.xml, right? Do you have any idea why having these remaining lines in grayscale_icon_map.xml without the corresponding drawables doesn't prevent you from building? Because as I've said, it is more of a mystery to me why y'all are not getting any exception during build.
All of that being said, I might also try opening a PR after all just to see whether it would run for others. And once again, if there is anything I can try or anything you need to know in order to be able to understand my problem, do please ask.

To resolve resource file missing issue , run sub module svg-proceasor before creating apk build.
https://github.com/LawnchairLauncher/lawnicons/blob/develop/.github/workflows/build_debug_apk.yml#L53
It will create all the vector files from svg and create other XML files like drawlbke.xml and appfilter.xml...

About Other issue while opening dex file / java.lang.ClassNotFoundException. Even today I'm getting same exception in my machine but same exception not appearing on some other machine after this version bump
https://github.com/LawnchairLauncher/lawnicons/pull/830
As a workaround I always use 1.17 version in my local and won't push the changes to remote. May be you try the same.

@naveenccmsd Thanks for that info, could you explain how I can run svg-processor? Also, do I have to run this manually before every build?

@naveenccmsd  Ok so using your advice I successfully fixed the Resource Linking problem, did have to comment out line 15 from grayscale_icon_map.xml, though, as there is no svg for fxxxs_given (and as it seems there never has been). Thanks for that!
I've gotten a weird error, though, after changing version from 1.19 to 1.17 in build.gradle.kts, which I don't understand. Do you have any idea what the problem could be?
Output:
\lawnicons\app\build\generated\source\napt_trigger\main\main\app\NaptTrigger.java:3: error: duplicate class: main.app.NaptTrigger
class NaptTrigger {}
^
1 error

[...]

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':app:compileAppDebugJavaWithJavac'.
> Compilation failed; see the compiler error output for details.

* Try:
> Run with --info or --debug option to get more log output.

* Exception is:
org.gradle.api.tasks.TaskExecutionException: Execution failed for task ':app:compileAppDebugJavaWithJavac'.
	at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.lambda$executeIfValid$1(ExecuteActionsTaskExecuter.java:149)
	at org.gradle.internal.Try$Failure.ifSuccessfulOrElse(Try.java:282)
	at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.executeIfValid(ExecuteActionsTaskExecuter.java:147)
	at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.execute(ExecuteActionsTaskExecuter.java:135)
	at org.gradle.api.internal.tasks.execution.FinalizePropertiesTaskExecuter.execute(FinalizePropertiesTaskExecuter.java:46)
	at org.gradle.api.internal.tasks.execution.ResolveTaskExecutionModeExecuter.execute(ResolveTaskExecutionModeExecuter.java:51)
	at org.gradle.api.internal.tasks.execution.SkipTaskWithNoActionsExecuter.execute(SkipTaskWithNoActionsExecuter.java:57)
	at org.gradle.api.internal.tasks.execution.SkipOnlyIfTaskExecuter.execute(SkipOnlyIfTaskExecuter.java:74)
	at org.gradle.api.internal.tasks.execution.CatchExceptionTaskExecuter.execute(CatchExceptionTaskExecuter.java:36)
	at org.gradle.api.internal.tasks.execution.EventFiringTaskExecuter$1.executeTask(EventFiringTaskExecuter.java:77)
	at org.gradle.api.internal.tasks.execution.EventFiringTaskExecuter$1.call(EventFiringTaskExecuter.java:55)
	at org.gradle.api.internal.tasks.execution.EventFiringTaskExecuter$1.call(EventFiringTaskExecuter.java:52)
	at org.gradle.internal.operations.DefaultBuildOperationRunner$CallableBuildOperationWorker.execute(DefaultBuildOperationRunner.java:204)
	at org.gradle.internal.operations.DefaultBuildOperationRunner$CallableBuildOperationWorker.execute(DefaultBuildOperationRunner.java:199)
	at org.gradle.internal.operations.DefaultBuildOperationRunner$2.execute(DefaultBuildOperationRunner.java:66)
	at org.gradle.internal.operations.DefaultBuildOperationRunner$2.execute(DefaultBuildOperationRunner.java:59)
	at org.gradle.internal.operations.DefaultBuildOperationRunner.execute(DefaultBuildOperationRunner.java:157)
	at org.gradle.internal.operations.DefaultBuildOperationRunner.execute(DefaultBuildOperationRunner.java:59)
	at org.gradle.internal.operations.DefaultBuildOperationRunner.call(DefaultBuildOperationRunner.java:53)
	at org.gradle.internal.operations.DefaultBuildOperationExecutor.call(DefaultBuildOperationExecutor.java:73)
	at org.gradle.api.internal.tasks.execution.EventFiringTaskExecuter.execute(EventFiringTaskExecuter.java:52)
	at org.gradle.execution.plan.LocalTaskNodeExecutor.execute(LocalTaskNodeExecutor.java:42)
	at org.gradle.execution.taskgraph.DefaultTaskExecutionGraph$InvokeNodeExecutorsAction.execute(DefaultTaskExecutionGraph.java:338)
	at org.gradle.execution.taskgraph.DefaultTaskExecutionGraph$InvokeNodeExecutorsAction.execute(DefaultTaskExecutionGraph.java:325)
	at org.gradle.execution.taskgraph.DefaultTaskExecutionGraph$BuildOperationAwareExecutionAction.execute(DefaultTaskExecutionGraph.java:318)
	at org.gradle.execution.taskgraph.DefaultTaskExecutionGraph$BuildOperationAwareExecutionAction.execute(DefaultTaskExecutionGraph.java:304)
	at org.gradle.execution.plan.DefaultPlanExecutor$ExecutorWorker.execute(DefaultPlanExecutor.java:463)
	at org.gradle.execution.plan.DefaultPlanExecutor$ExecutorWorker.run(DefaultPlanExecutor.java:380)
	at org.gradle.execution.plan.DefaultPlanExecutor.process(DefaultPlanExecutor.java:116)
	at org.gradle.execution.taskgraph.DefaultTaskExecutionGraph.executeWithServices(DefaultTaskExecutionGraph.java:136)
	at org.gradle.execution.taskgraph.DefaultTaskExecutionGraph.execute(DefaultTaskExecutionGraph.java:121)
	at org.gradle.execution.SelectedTaskExecutionAction.execute(SelectedTaskExecutionAction.java:35)
	at org.gradle.execution.DryRunBuildExecutionAction.execute(DryRunBuildExecutionAction.java:51)
	at org.gradle.execution.BuildOperationFiringBuildWorkerExecutor$ExecuteTasks.call(BuildOperationFiringBuildWorkerExecutor.java:54)
	at org.gradle.execution.BuildOperationFiringBuildWorkerExecutor$ExecuteTasks.call(BuildOperationFiringBuildWorkerExecutor.java:43)
	at org.gradle.internal.operations.DefaultBuildOperationRunner$CallableBuildOperationWorker.execute(DefaultBuildOperationRunner.java:204)
	at org.gradle.internal.operations.DefaultBuildOperationRunner$CallableBuildOperationWorker.execute(DefaultBuildOperationRunner.java:199)
	at org.gradle.internal.operations.DefaultBuildOperationRunner$2.execute(DefaultBuildOperationRunner.java:66)
	at org.gradle.internal.operations.DefaultBuildOperationRunner$2.execute(DefaultBuildOperationRunner.java:59)
	at org.gradle.internal.operations.DefaultBuildOperationRunner.execute(DefaultBuildOperationRunner.java:157)
	at org.gradle.internal.operations.DefaultBuildOperationRunner.execute(DefaultBuildOperationRunner.java:59)
	at org.gradle.internal.operations.DefaultBuildOperationRunner.call(DefaultBuildOperationRunner.java:53)
	at org.gradle.internal.operations.DefaultBuildOperationExecutor.call(DefaultBuildOperationExecutor.java:73)
	at org.gradle.execution.BuildOperationFiringBuildWorkerExecutor.execute(BuildOperationFiringBuildWorkerExecutor.java:40)
	at org.gradle.internal.build.DefaultBuildLifecycleController.lambda$executeTasks$7(DefaultBuildLifecycleController.java:172)
	at org.gradle.internal.model.StateTransitionController.doTransition(StateTransitionController.java:258)
	at org.gradle.internal.model.StateTransitionController.lambda$tryTransition$8(StateTransitionController.java:185)
	at org.gradle.internal.work.DefaultSynchronizer.withLock(DefaultSynchronizer.java:44)
	at org.gradle.internal.model.StateTransitionController.tryTransition(StateTransitionController.java:185)
	at org.gradle.internal.build.DefaultBuildLifecycleController.executeTasks(DefaultBuildLifecycleController.java:172)
	at org.gradle.internal.build.DefaultBuildWorkGraphController$DefaultBuildWorkGraph.runWork(DefaultBuildWorkGraphController.java:209)
	at org.gradle.internal.work.DefaultWorkerLeaseService.withLocks(DefaultWorkerLeaseService.java:249)
	at org.gradle.internal.work.DefaultWorkerLeaseService.runAsWorkerThread(DefaultWorkerLeaseService.java:109)
	at org.gradle.composite.internal.DefaultBuildController.doRun(DefaultBuildController.java:172)
	at org.gradle.composite.internal.DefaultBuildController.access$000(DefaultBuildController.java:47)
	at org.gradle.composite.internal.DefaultBuildController$BuildOpRunnable.run(DefaultBuildController.java:191)
	at org.gradle.internal.concurrent.ExecutorPolicy$CatchAndRecordFailures.onExecute(ExecutorPolicy.java:64)
	at org.gradle.internal.concurrent.ManagedExecutorImpl$1.run(ManagedExecutorImpl.java:49)
Caused by: org.gradle.api.internal.tasks.compile.CompilationFailedException: Compilation failed; see the compiler error output for details.
	at org.gradle.api.internal.tasks.compile.JdkJavaCompiler.execute(JdkJavaCompiler.java:58)
	at org.gradle.api.internal.tasks.compile.JdkJavaCompiler.execute(JdkJavaCompiler.java:41)
	at org.gradle.api.internal.tasks.compile.daemon.AbstractIsolatedCompilerWorkerExecutor$CompilerWorkAction.execute(AbstractIsolatedCompilerWorkerExecutor.java:78)
	at org.gradle.workers.internal.DefaultWorkerServer.execute(DefaultWorkerServer.java:63)
	at org.gradle.workers.internal.AbstractClassLoaderWorker$1.create(AbstractClassLoaderWorker.java:49)
	at org.gradle.workers.internal.AbstractClassLoaderWorker$1.create(AbstractClassLoaderWorker.java:43)
	at org.gradle.internal.classloader.ClassLoaderUtils.executeInClassloader(ClassLoaderUtils.java:100)
	at org.gradle.workers.internal.AbstractClassLoaderWorker.executeInClassLoader(AbstractClassLoaderWorker.java:43)
	at org.gradle.workers.internal.FlatClassLoaderWorker.run(FlatClassLoaderWorker.java:32)
	at org.gradle.workers.internal.FlatClassLoaderWorker.run(FlatClassLoaderWorker.java:22)
	at org.gradle.workers.internal.WorkerDaemonServer.run(WorkerDaemonServer.java:87)
	at org.gradle.workers.internal.WorkerDaemonServer.run(WorkerDaemonServer.java:56)
	at org.gradle.process.internal.worker.request.WorkerAction$1.call(WorkerAction.java:138)
	at org.gradle.process.internal.worker.child.WorkerLogEventListener.withWorkerLoggingProtocol(WorkerLogEventListener.java:41)
	at org.gradle.process.internal.worker.request.WorkerAction.run(WorkerAction.java:135)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:36)
	at org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:24)
	at org.gradle.internal.remote.internal.hub.MessageHubBackedObjectConnection$DispatchWrapper.dispatch(MessageHubBackedObjectConnection.java:182)
	at org.gradle.internal.remote.internal.hub.MessageHubBackedObjectConnection$DispatchWrapper.dispatch(MessageHubBackedObjectConnection.java:164)
	at org.gradle.internal.remote.internal.hub.MessageHub$Handler.run(MessageHub.java:414)
	at org.gradle.internal.concurrent.ExecutorPolicy$CatchAndRecordFailures.onExecute(ExecutorPolicy.java:64)
	at org.gradle.internal.concurrent.ManagedExecutorImpl$1.run(ManagedExecutorImpl.java:49)

Just delete NaptTrigger.java file which was created by napt plugin

@naveenccmsd That worked, thank you so much! Finally able to work on new icons again!


[AutoScheduler] Support early_stopping per task

Per discussion in https://discuss.tvm.apache.org/t/ansor-task-scheduler-spending-too-much-trial-on-dead-end-tasks/8955, this PR improves the early stopping criteria in the task scheduler. Now we have two early stopping factors:

TuningOptions.early_stopping: Like other options in this object, the early_stopping in TuningOptions affects each task.
task_scheduler.tune(..., early_stopping=None): Since this is only for task_scheduler, this early_stopping applies to an entire tuning process.

Accordingly, when setting TuningOptions.early_stopping, a task will be stopped early if it has no improvement for N measurements, but the task scheduler will keep tuning rest tasks. On the other hand, task_scheduler.tune(..., early_stopping) serves as the original functionality that early stops an entire tuning process after no improvement for N measurements (regardless which tasks).
cc @merrymercy @masahi

I suggest that we can use TuneOption.early_stopping for all tasks, because TuneOption.num_measure_trials is the sum of measurements for all tasks.
We can use task_scheduler.tune(..., per_task_early_stopping=None) for per task early stopping.

I suggest that we can use TuneOption.early_stopping for all tasks, because TuneOption.num_measure_trials is the sum of measurements for all tasks.
We can use task_scheduler.tune(..., per_task_early_stopping=None) for per task early stopping.

I suggest that we can use TuneOption.early_stopping for all tasks, because TuneOption.num_measure_trials is the sum of measurements for all tasks.
We can use task_scheduler.tune(..., per_task_early_stopping=None) for per task early stopping.

Fair enough. Updated.

@comaniac please kick the CI again

seems CI is having an issue

Thanks @comaniac @merrymercy


Add quality badges to README

Add badges to let us keep an eye on outdated dependencies, test coverage and dependency vulnerabilities.

I know this is very nitpick-y but I would prefer it if unrelated codestyle changes weren't part of the PR.

Well I think changes in other files arrived from rebasing with another PR, to avoid later conflicts

Pardon, those changes actually don't have anything to do with any other PR, they were made by pre-commit githook, and when I try reverting them, the same githook re-applies them. So what do we do? And does it mean we don't have same pre-commit settings across the guild?

The coverage one Doesn't seem to do much

The coverage one Doesn't seem to do much

Of course it doesn't, it's because we are not covered :)

The coverage one Doesn't seem to do much

Of course it doesn't, it's because we are not covered :)

😂 okayy. Fair enough. So did anyone decide on using this tool? Vs what alternatives there are on the market?

The coverage one Doesn't seem to do much

Of course it doesn't, it's because we are not covered :)

😂 okayy. Fair enough. So did anyone decide on using this tool? Vs what alternatives there are on the market?

No one explicitly decided on this particular tool, it's used on the example given in this Trello ticket https://trello.com/c/T8qrdLr7/79-add-dependencies-up-to-date-badge
From what I can see, the main competition to Coveralls is Codecov, however it seems that Coveralls is more widely used (https://stackshare.io/stackups/codecov-vs-coveralls), so it's likely to have better community support and all.
But we can easily change that on guild day, there's no such thing as Saint Coveralls :)


Reformat

Reformat to 88 and enforce f-strings

Pull Request Test Coverage Report for Build 1a6ed3eac77c0cf6d69b0aba2d00261be95c419d-PR-9

10 of 10 (100.0%)  changed or added relevant lines in 4 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 95.116%

Totals

Change from base Build 62ad1c9ba26475759a9a398fd4a88ac4d1893e6d:
0.0%

Covered Lines:
370

Relevant Lines:
389

💛  - Coveralls


Confusion about the assignment rules for lane traffic topology

Hi, thanks for your great work.
In this scenario, the go straight sign is only placed on the segment of the middle lane that is closer to us. So, why isn’t the sign placed on segments of the lane that are further away (In fig. 2)? Is there a default rule that assigns traffic signs to the road segments closer to the vehicle? Based on this rule, can we assume that the lane where this segment is located is designated for going straight, and thus we don’t need to delve into which specific segment within the same lane should be assigned?

Hi, could you provide the identifier of the frame, so that we can have a closer look?


Speedup mtype density creation from probability maps using voxcell's ValueToIndexVoxels

Instead of doing the unraveling here, it has to wait for: https://github.com/BlueBrain/voxcell/pull/31
Comparison on 70 nodes:
Before    : 6276
After       : 60s
Speedup : ~100x
Script used for profiling (Before time was taken from here):
from pathlib import Path
from atlas_densities.app import mtype_densities
from click.testing import CliRunner

OUTPUT_DIR = str(Path(__file__).parent / "out")
DATA_DIR = "/gpfs/bbp.cscs.ch/data/project/proj84/atlas_pipeline_runs/2024-03-11T09:54:30/"
CONFIG_DIR = DATA_DIR + "rules_config_dir/mtypes/"
DENSITY_DIR = DATA_DIR + "inhibitory_neuron_densities_linprog_correctednissl_validated/"

arglist = [
    "--log-output-path",
    OUTPUT_DIR,
    "-v",
    "create-from-probability-map",
    "--hierarchy-path", DATA_DIR + "hierarchy_ccfv2_l23split_barrelsplit.json",
    "--annotation-path", DATA_DIR + "annotation_ccfv2_l23split_barrelsplit_validated.nrrd",
    "--probability-map", CONFIG_DIR + "probability_map_L1.csv",
    "--probability-map", CONFIG_DIR + "probability_map_L23.csv",
    "--probability-map", CONFIG_DIR + "probability_map_L4.csv",
    "--probability-map", CONFIG_DIR + "probability_map_L5.csv",
    "--probability-map", CONFIG_DIR + "probability_map_L6.csv",
    "--probability-map", CONFIG_DIR + "probability_map_TH_INH.csv",
    "--marker", "gad67", DENSITY_DIR + "gad67+_density.nrrd",
    "--marker", "pv", DENSITY_DIR + "pv+_density.nrrd",
    "--marker", "sst", DENSITY_DIR + "sst+_density.nrrd",
    "--marker", "vip", DENSITY_DIR + "vip+_density.nrrd",
    "--synapse-class", "INH",
    "--n-jobs", "70",
    "--output-dir", OUTPUT_DIR,
]
print(" ".join(arglist))

res = CliRunner().invoke(
    mtype_densities.app,
    arglist,
    catch_exceptions=False,
    color=True,
)

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

:exclamation: No coverage uploaded for pull request base (main@fba1e3f). Click here to learn what that means.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #79   +/-   ##
=======================================
  Coverage        ?   97.68%
=======================================
  Files           ?       22
  Lines           ?     1509
  Branches        ?        0
=======================================
  Hits            ?     1474
  Misses          ?       35
  Partials        ?        0

Flag
Coverage Δ

pytest
97.68% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

I ran the old code path, and the new ones, and all the outputs are exactly the same.
The runtime is very much improved:
Old: python3 test.py  303289.59s user 825.91s system 5872% cpu 1:26:18.56 total
New python3 test.py  2073.11s user 142.77s system 2978% cpu 1:14.40 total


Provide a option to search R help when pressing F1

Pressing F1 to search the keyword under the cursor is very useful function of 0.4.
But usually I use internal R help to find information of the keyword first.
So if RTVS have a option to search internal R help, I think the function becomes more useful.

Ctrl+F1 or Right Click => Help On ...

Thanks for the comment. I found it.


Edit Permissions for Partnerships

Restrict access to edit the MOU Signed & Financial Reporting Type fields on a Partnership to users who have one of the following roles:

Financial Analyst
Controller

Needs API work


error in nuxtjs after upgrade to latest version

Version
2.6.13
Reproduction link
https://admin.yalladealz.com/
Steps to reproduce
after i upgrade today<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>i got this error when rendering my nuxt app on the server  Nuxtjs v2.15.6
ERROR in ./node_modules/vuetify/src/components/VGrid/VGrid.sass (./node_modules/css-loader/dist/cjs.js??ref--6-oneOf-1-1!./node_modules/postcss-loader/src??ref--6-oneOf-1-2!./node_modules/sass-loader/dist/cjs.js??ref--6-oneOf-1-3!./node_modules/vuetify/src/components/VGrid/VGrid.sass)
Module build failed (from ./node_modules/sass-loader/dist/cjs.js):
SassError: @use rules must be written before any other rules.
╷
3 │ @use 'sass:math'
│ ^^^^^^^^^^^^^^^^
╵
node_modules/vuetify/src/components/VGrid/VGrid.sass 3:1  root stylesheet
@ ./node_modules/vuetify/src/components/VGrid/VGrid.sass 4:14-204
@ ./node_modules/vuetify/lib/components/VGrid/VCol.js
@ ./node_modules/vuetify/lib/components/VGrid/index.js
@ ./pages/en/dashboard/subscriptions/_id.vue
@ ./node_modules/.cache/nuxt/router.js
@ ./node_modules/.cache/nuxt/index.js
@ ./node_modules/.cache/nuxt/client.js
@ multi ./node_modules/.cache/nuxt/client.js
What is expected?
to resolve compatibility for latest version
What is actually happening?
ERROR in ./node_modules/vuetify/src/components/VGrid/VGrid.sass (./node_modules/css-loader/dist/cjs.js??ref--6-oneOf-1-1!./node_modules/postcss-loader/src??ref--6-oneOf-1-2!./node_modules/sass-loader/dist/cjs.js??ref--6-oneOf-1-3!./node_modules/vuetify/src/components/VGrid/VGrid.sass)
Module build failed (from ./node_modules/sass-loader/dist/cjs.js):
SassError: @use rules must be written before any other rules.
╷
3 │ @use 'sass:math'
│ ^^^^^^^^^^^^^^^^
╵
node_modules/vuetify/src/components/VGrid/VGrid.sass 3:1  root stylesheet
@ ./node_modules/vuetify/src/components/VGrid/VGrid.sass 4:14-204
@ ./node_modules/vuetify/lib/components/VGrid/VCol.js
@ ./node_modules/vuetify/lib/components/VGrid/index.js
@ ./pages/en/dashboard/subscriptions/_id.vue
@ ./node_modules/.cache/nuxt/router.js
@ ./node_modules/.cache/nuxt/index.js
@ ./node_modules/.cache/nuxt/client.js
@ multi ./node_modules/.cache/nuxt/client.js

This could be of interest.

https://github.com/vuetifyjs/vuetify/issues/13737

Open the issue on Nuxt instead with a boiled down repro, not your whole website


fix: git clone on non-default branch fails

Fixes Issue 5629.

Signed-off-by: Kenny Trytek<EMAIL_ADDRESS>Checklist:

[ ] My organization is added to USERS.md.

I don't think this change should cause catastrophic failure of the tests. Closing/reopening to try again...

Can you please add a test?

@alexec:
Can you please add a test?

Added test to verify the revision used is in the expected format. A full e2e test seemed a bit heavy for this change.

Rebased onto latest master. No merge conflicts.

Rebased onto latest master. No merge conflicts.

Please fix lint.

Sorry, didn't realize there was a lint target locally; I'll be sure to do that before pushing for future changes.

Test unrelated to changes failed:
--- FAIL: TestDAGTemplateParallelismLimit (0.11s)
    operator_test.go:1519:
        	Error Trace:	operator_test.go:1519
        	Error:      	Not equal:
        	            	expected: 2
        	            	actual  : 4
        	Test:       	TestDAGTemplateParallelismLimit

Re-running build.


sixel inside tmux and ssh workaround

Windows Terminal version
1.22.240823002-preview
Windows build number
10.0.22631.4037
Other Software
tmux next 3.5 (latest so far 34807388b064 commit built with --enable-sixel)
Steps to reproduce
In WSL2 tab img2sixel logo.png just works, hurray. It also works if I ssh to a remote server from the WSL2 tab.
Then I start tmux and run the same command. It outputs in a fallback mode
$ img2sixel logo.png
SIXEL IMAGE (12x6)
++++++++++++
++++++++++++
++++++++++++
++++++++++++
++++++++++++

Then I (similarly to a suggestion at https://github.com/wez/wezterm/issues/1236)

go to a Windows "Command Prompt" tab
ssh to WSL2 from there
create tmux session and type "img2sixel logo192.png" .

sixel output starts to work, even on a remote server + tmux combination. This is weird, because if it wasn't so, I would think it's a tmux bug. But now it seems something is off with how WSL2 tab works.
Expected Behavior
sixel output inside tmux
Actual Behavior
tmux outputs
SIXEL IMAGE (12x6)
++++++++++++
++++++++++++
++++++++++++
++++++++++++
++++++++++++
but works correctly if ssh to WSL2 from Windows

Huh. That's super bizarre. Our best guess right now is that it's the same thing as #17813, but we'll leave this open for now to make sure we check this too. Thanks for filing!

As far I can recall, tmux relies on a TIOCGWINSZ ioctl query to calculate the terminal's cell size, and if it doesn't get back something meaningful, it disables the sixel functionality. I'm not particularly knowledgable about Linux, but my understanding is that it's the responsibility of the terminal to communicate its window size to the OS (also via an ioctl call), and the OS can then pass that on to any apps that query it.
Obviously that's not going to work on Windows because we aren't a Linux app. I'm assuming WSL generates the character dimensions itself by using one of the win32 console APIs to monitor the console buffer size, but it can't know the pixel size, so it leaves those values as 0x0. This is actually not that uncommon a situation, because the pixel fields are not really standard AFAIK, and not all terminals fill them in.
And when it comes to a remote connection to Linux, it's up to ssh to pass the window dimensions to the remote server, but the WSL version of ssh would itself depend on the local TIOCGWINSZ state, so it still won't be able to provide the pixel size.
So why does it work when you ssh from Windows to WSL? That's the bit that was a surprise to me, so I just checked, and it seems that the Windows version of ssh just fakes the pixel dimensions - they're hardcoded to 640x480 regardless of the terminal size. This should be enough to get tmux to work, but I would expect images to be misshapen unless the terminal was exactly 64 columns by 24 rows. I don't have a recent copy of tmux, though, so I haven't actually tested that.
As for fixing this, I don't think there's anything we can do about it. It could be fixed by tmux if they used one of the CSI t queries to determine the cell size (and that would enable them to support a number of other terminals too). It could also possibly be fixed in WSL if they faked the TIOCGWINSZ pixel dimensions (taking the char dimensions and multiplying them by 10x20). That wouldn't work for most third-party terminals though.

but I would expect images to be misshapen unless the terminal was exactly 64 columns by 24 row

That's true: if the window size is larger than ~24 rows, there is a big black area.

Closing this as the patch suggested by @j4james in the last comment here was accepted to tmux (89adec0ca5)
I tested on 1.22.240823002-preview and the 25b1cc1e8e tmux build from github

@galchinsky Thank you for doing the work to get this fixed in tmux. It's much appreciated.


Table Storage: Get Table ACL

See spec at https://docs.microsoft.com/en-us/rest/api/storageservices/get-table-acl

closing feature issues for legacy api


[Do not merge] Debug integration test failure

To debug the integration test failure in #14364:

revert all commits after the commit bd0859b, which is merged in master branch on 5-24-2019.

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: lei-tang
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: linsun
If they are not already assigned, you can assign the PR to them by writing /assign @linsun in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS
prow/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@lei-tang: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/integ-security-k8s-presubmit-tests.sh
f41e1fa1a2a48e38537673ebd9f4f1aaa78d250b
link
/test integ-security-k8s-presubmit-tests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@lei-tang: PR needs rebase.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.


play well with zsh-syntax-highlight

Is this meant to address #126?

@ericfreese: Yes, it is. Sorry, I didn't look for existing issues. Just fixed by myself.

@ericfreese: ping?

@seletskiy Sorry, i've been busy with work. Will get to this as time allows.

Just had a play with this (I was trying to resolve the same issue on the syntax-highlighting side). Seems to resolve the issue, I no longer get a segfault when re-sourcing my .zshrc in the active session.

It didn't work for my system. Using zsh 5.2 (x86_64-apple-darwin14.5.0) and latest version of both plugins.

Worked for me on zsh 5.2 (x86_64-apple-darwin14.5.0)
@danielshahaf 's patch in Issue 126 also worked.

fixes the issue for me, tested on cygwin64 loading with zplug
will test on arch later and update this
hope this will be merged

Thank you for this. I've implemented something very similar on the develop branch, which should solve the problems with z-sy-h plugin. Please let me know if it doesn't.

with `zplug "zsh-users/zsh-autosuggestions", at:develop``
and forcing a update the issue of zsh crashing after sourcing this plugin a second or third time was fixed for me


Add meta title to the routes

closes https://github.com/hypha-dao/dho-web-client/issues/1151

@arsenijesavic could you review the conflict please?

@jmgayosso fixed


Feature request: Show only current space on current monitor

Hey!
I'm checking if I can add/build this myself but I would love it if Spaceman could show only the current space on the current windows (like Whichspace) does. For example, I have 2 monitors with 10 spaces (5 on each monitor) showing as:
1 2 3 4 5  6 7 8 9 10

I would love the option to show them as follows if I would be on space 2 and 8:
2 | 8

Or in named mode like:
2: NET | 8: DEV

I currently have 21 spaces. There is absolutely no room for them all to be shown, even just by number, much less by three-letter codename. Even without the spaces shown, some apps have so many menus that other icons are hidden. Showing the list of all spaces just makes that problem worse.

What I really want is for the toolbar on each screen show only that screen's space or spaces, but this would definitely help!

I too would like an option to only show the current space. Thank you.

Yep me too! and ONE extra character in the name please


doc/md: fmt consistency and update spelling

remove extraneous spaces
add spacing around code fences to match code fence formatting
correct spelling (e.g., Buliding -> Building)
consistent line length

I can un-do the line-wrapping, but it seemed read weird on the CLI.


Download Kindlegen if it can't be found

If Kindlegen can't be found (because the gem wasn't install or we can't install gems like in AsciidoctorJ), then download Kindlegen on demand, extract it to a temporary location and use that executable. This will allow mobi generation to work consistently everywhere and will give us control over the Kindlegen download.

In the Gradle plugin for Asciidoctor we take care of this automatically, but it fails on Windows due to an issue on how kindlegen access is imlementd in the GEM.


Remove Dependencies on Pearson Libraries

There is actually only one pearson library which is open source:
http://developer.pearson.com/pearson-scorm-services/getting-started
What's even better is that this functionality was walled off by a License key flag which no one ever requested, so probably could just be removed completely.

https://docs.google.com/spreadsheets/d/1GYyQ2jdw9IKccQDVt-cpcvgJuI5MuCUgOAzCkr4JIYw/edit?usp=sharing

@doolse -- Can you handle removing this dependency/feature?

@abidingotter Did most of the deletion here, done!


Update Composer dependencies (2023-07-03-00-09)

Visual regression test passed!
View the visual regression test report


Add styling for cookie banner

What
Style the notification banner as agreed.
Who needs to know about this
Developers, designers
Depends on

Add Nunjucks macro template, tests and examples for cookie banner

Done when

[ ] Styles added
[ ] Styles have been reviewed by a designer

Note: We may want to add a border-bottom to make it easier for users using high contrast mode to be able to identify where the banner ends.

Note: We may want to add a border-bottom to make it easier for users using high contrast mode to be able to identify where the banner ends.


[GHSA-fccv-jmmp-qg76] Apache Tomcat Improper Input Validation vulnerability

Updates

Affected products

Comments
Improve visibility for org.apache.tomcat.embed:tomcat-embed-core
Reasoning -> fixed components are also part of tomcat-embed-core package:
(11.0.x) https://github.com/apache/tomcat/commit/6f181e1062a472bc5f0234980f66cbde42c1041b
(10.1.x) https://github.com/apache/tomcat/commit/b5776d769bffeade865061bc8ecbeb2b56167b08
(9.0.x) https://github.com/apache/tomcat/commit/7a2d8818fcea0b51747a67af9510ce7977245ebd
(8.5.x) https://github.com/apache/tomcat/commit/aa92971e879a519384c517febc39fd04c48d4642

Similar to https://github.com/github/advisory-database/pull/3105 I don't follow the linkage from the commits to the org.apache.tomcat.embed:tomcat-embed-core artifact. Can you expand on that?

Hi @darakian , please see details here: https://github.com/github/advisory-database/pull/3105#issuecomment-1866943412
thanks


Bug: idc._disassemble fails on idaapi.get_inf_structure().procName

Just need to change to procName
Here's the git diff:
diff --git a/idb/idapython.py b/idb/idapython.py
index 2d5e2e2..bb71a32 100644
--- a/idb/idapython.py
+++ b/idb/idapython.py
@@ -874,7 +874,7 @@ class idc:
         inst_buf = self.GetManyBytes(ea, size)
         segment = self._get_segment(ea)
         bitness = 16 << segment.bitness# 16, 32, 64
-        procname = self.api.idaapi.get_inf_structure().procname.lower()
+        procname = self.api.idaapi.get_inf_structure().procName.lower()

         dis = None
         if procname == "arm" and bitness == 64:

It was fixed since fdbbb77d


Spatial Audio

Leverage Omnitone
See https://github.com/littlstar/axis/tree/omnitone

cc @agrathwohl

ref https://github.com/GoogleChrome/omnitone/pull/15

LGTM


fix: update cargo version

Codecov Report

Merging #230 (cd3138b) into main (d83f9c6) will increase coverage by 2.15%.
Report is 3 commits behind head on main.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #230      +/-   ##
==========================================
+ Coverage   78.64%   80.79%   +2.15%
==========================================
  Files          21       20       -1
  Lines        2721     2708      -13
==========================================
+ Hits         2140     2188      +48
+ Misses        581      520      -61

Files
Coverage Δ

taos/_version.py
100.00% <100.00%> (ø)

taos/tmq.py
88.42% <100.00%> (+18.57%)
:arrow_up:

... and 3 files with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Fix mouse move over an unfocused window

Fixes #95754
Fixes #96612

This issue seems a regression from #65496 where the mouse move event is always sent to the focused windows. It's ok the send the mouse movement to the focused window when it's captured by it, but not always.
Adding a condition to call _get_focused_window_or_popup only when the mouse mode is MOUSE_MODE_CAPTURED, MOUSE_MODE_CONFINED or MOUSE_MODE_CONFINED_HIDDEN fixed the problem.
I don't fully understand why the same problem does not occur on Linux or Mac. I cannot test on Mac, but on Linux, the problem is different, it's the button release event that is not sent to the unfocused window. But #95044 fixes this problem on Linux.
I retested the Color picker, the number slider in the inspector and the environment settings.
Edited: Added #96612 as a fixed issue

Thanks!

Note for self, shouldn't be cherry-picked to 4.3 due to the regression it causes: #99287 (unless also cherry-picking the regression fix).

I reopened #96612 because this PR does not fix this issue. I made a mistake in the PR comment, it's the PR #95606 that should fix #96612.


NUNumericTextField: Support negative numbers

@natabal pls review. need this for supporting -ve numbers in spec director.

@natabal pls review, simplified earlier checks


Remove moot version property from bower.json

Per bower/bower.json-spec@a325da3

Nice. Would this adversly affect older Bower installations?

Not that I am aware of. To my knowledge this property wasn't ever actually used but was included to foster the development of a package management system which never came to be.

Let's find out.


Clicking on the quick fix light bulb doesn't show the context menu

monaco-editor version: Monaco Editor Playground
Browser:
Google Chrome 60.0.3112.113 (Official Build)
Microsoft Edge 38.14393.1066.0 EdgeHTML 14.14393
OS: Windows 10

Open the Monaco Editor Playground.
Replace the JavaScript with the following snippet.

monaco.languages.registerCodeActionProvider("json", {
    provideCodeActions: function(model, range, context, token) {
        return [
            {
                command: {
                    id: "command.id",
                    title: "command title"
                },
                score: 0
            }
        ]
    }
});

monaco.editor.create(document.getElementById("container"), {
	value: "{ \"key\": \"value\" }",
	language: "json",
    glyphMargin: true
});

Run the code.
The light bulb should appear. If not, click inside the JSON string. The light bulb should then appear if it's not already visible.
Click on the light bulb, no context menu will appear.
Hit CTRL + . to get the command to popup. The menu will appear but there the menu item has no text in it.

@alexandrudima is there a way to fix it and make 0.10.1? It seems to be regression and was working fine in 0.8.x.

@alexandrudima Was this supposed to be closed by Microsoft/vscode#41927?

... sometimes the GH auto-closing back-fires ...
https://github.com/Microsoft/vscode/pull/41927#issue-164174861

Stumbled on it trying to fix Microsoft/monaco-editor#574

This is now working in the latest version of the Monaco Playground.
monaco.languages.registerCodeActionProvider("json", {
    provideCodeActions: function(model, range, context, token) {
        return [
            {
                title: "action title"
            }
        ]
    }
});

monaco.editor.create(document.getElementById("container"), {
	value: "{ \"key\": \"value\" }",
	language: "json",
    lightbulb: {
        enabled: true
    }
});


Cleandead removes input files that used to be outputs in a previous build.

The Fuchsia build, which uses GN + Ninja, found out that the Ninja cleandead tool would incorrectly remove input files that used to be output files in a previous build [1]. This of course breaks our incremental builds (which all run cleandead after regenerating all ninja build manifests).
This can be reproduced independently with a simple example that first uses this build.ninja file to create an empty "test_file" in the build directory.
rule touch_file
  command = touch $in
rule test_file: touch_file
rule dummy: touch_file test_file

This also adds an entry in .ninja_log for it.
Then modify the build.ninja file to read:
rule dummy: touch_file | test_file

while test_file is still in the build directory (assume it is now generated by the generator).
Running ninja -t cleandead will remove test_file even though it is listed as an input.
I have found that this comes from the following logic in Cleaner::CleanDead():
  for (BuildLog::Entries::const_iterator i = entries.begin(); i != entries.end(); ++i) {
    Node* n = state_->LookupNode(i->first);
    if (!n || !n->in_edge) {
      Remove(i->first.AsString());
    }
  }

In other words, anything that is in the build that is no longer an output in the build graph is removed, even if it is now an input.
By changing this to:
  for (BuildLog::Entries::const_iterator i = entries.begin(); i != entries.end(); ++i) {
    Node* n = state_->LookupNode(i->first);
    if (!n || (!n->in_edge && n->out_edges().empty())) {
      Remove(i->first.AsString());
    }
  }

The issue disappears for us. I can provide a PR with the fix and an associated CleanDeadTest instance. However, I was wondering first if this would break other things.
Also, we tried to use recompact before cleandead, but the former fails to remove the entry from the build log, due to the logic in IsPathDead() in src/ninja.cc, so the problem persists without changing the cleandead logic.
[1] https://bugs.fuchsia.dev/p/fuchsia/issues/detail?id=80734

Friendly ping. Any specific thing that would prevent the current PR from being submitted?

No, thanks for the PR with the test and your explanations!

However, I was wondering first if this would break other things.

I don't think it would, but maybe @ikifof can comment on this.

Thanks then :-)


FTS5 is not working with encryption on windows

FTS5 is working fine with the default sqlite3_flutter_libs but when using sqlcipher_flutter_libs with precompiled sqlcipher .dll file it does not work and throw an error.
error message
flutter: SqliteException(1): no such module: FTS5
  Causing statement: CREATE VIRTUAL TABLE IF NOT EXISTS "table_name" USING FTS5(id, content);

StackTrace
flutter: #0      DriftCommunication.request
package:drift/…/remote/communication.dart:109
simolus3/drift#1      _RemoteQueryExecutor.ensureOpen
package:drift/…/remote/client_impl.dart:137
simolus3/drift#2      DatabaseConnectionUser.doWhenOpened
package:drift/…/api/connection_user.dart:156
simolus3/drift#3      InsertStatement.insert
package:drift/…/statements/insert.dart:73
simolus3/drift#4      provider.add
package:myapp/…/my_db/provider.dart:34
simolus3/drift#5      screen.build.<anonymous closure>
package:myapp/screen.dart:35
simolus3/drift#6      _InkResponseState.handleTap
package:flutter/…/material/ink_well.dart:1072
simolus3/drift#7      GestureRecognizer.invokeCallback
package:flutter/…/gestures/recognizer.dart:253
simolus3/drift#8      TapGestureRecognizer.handleTapUp
package:flutter/…/gestures/tap.dart:627
simolus3/drift#9      BaseTapGestureRecognizer._checkUp
package:flutter/…/gestures/tap.dart:306
simolus3/drift#10     BaseTapGestureRecognizer.handlePrimaryPointer
package:flutter/…/gestures/tap.dart:239
simolus3/drift#11     PrimaryPointerGestureRecognizer.handleEvent
package:flutter/…/gestures/recognizer.dart:615
simolus3/drift#12     PointerRouter._dispatch
package:flutter/…/gestures/pointer_router.dart:98
simolus3/drift#13     PointerRouter._dispatchEventToRoutes.<anonymous closure>
package:flutter/…/gestures/pointer_router.dart:143
simolus3/drift#14     _LinkedHashMapMixin.forEach (dart:collection-patch/compact_hash.dart:617:13)
simolus3/drift#15     PointerRouter._dispatchEventToRoutes
package:flutter/…/gestures/pointer_router.dart:141
simolus3/drift#16     PointerRouter.route
package:flutter/…/gestures/pointer_router.dart:127
simolus3/drift#17     GestureBinding.handleEvent
package:flutter/…/gestures/binding.dart:460
simolus3/drift#18     GestureBinding.dispatchEvent
package:flutter/…/gestures/binding.dart:440
simolus3/drift#19     RendererBinding.dispatchEvent
package:flutter/…/rendering/binding.dart:337
simolus3/drift#20     GestureBinding._handlePointerEventImmediately
package:flutter/…/gestures/binding.dart:395
simolus3/drift#21     GestureBinding.handlePointerEvent
package:flutter/…/gestures/binding.dart:357
simolus3/drift#22     GestureBinding._flushPointerEventQueue
package:flutter/…/gestures/binding.dart:314
simolus3/drift#23     GestureBinding._handlePointerDataPacket
package:flutter/…/gestures/binding.dart:295
simolus3/drift#24     _invoke1 (dart:ui/hooks.dart:167:13)
simolus3/drift#25     PlatformDispatcher._dispatchPointerDataPacket (dart:ui/platform_dispatcher.dart:341:7)
simolus3/drift#26     _dispatchPointerDataPacket (dart:ui/hooks.dart:94:31)

note:
Encryptions works fine without adding FTS5 and I am facing this issue only on windows.

I've never tested the availability of fts5 in sqlcipher_flutter_libs, I'll look into that. Out of interest, on which platform did encrypted fts5 work at all?

Hi @simolus3
It works on Android, IOS and MacOS out of the box.
I haven't test it on Linux yet

This issue is related to the compiled lib, the package works perfectly fine (both sqlite and drift).


Migrate id-generation from uuid() to React's useId() to avoid hydration errors in SSR environments

When using uuidv4's id generator, you will encounter hydration errors in SSR environments. The React hook useId() solves it and has been created for this purpose. We should migrate to this hook in all the components using uuid.

Jeg kan nok få fikset dette selv snart - men lager issue foreløpig.


Pre release v2.5.0rc1

Checklist

[x] Used a personal fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[x] Reset the build number to 0 (if the version changed)
[ ] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[ ] Ensured the license file is being packaged.

Hi! This is the friendly automated conda-forge-linting service.
I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.
Here's what I've got...
For recipe:

Recipe maintainer "jvegasbsc" does not exist
requirements: run: scipy>=1.6 must contain a space between the name and the pin, i.e. scipy >=1.6

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

Closes #19

@conda-forge-admin, please rerender

@zklaus @valeriupredoi is there anything else I need to do?

I think that's all. We'll just have to wait for the infrastructure to come back to see the tests go through and do the final review.

looking good, cheers @schlunma and @zklaus :+1: I am a bit concerned by the use of boa - I don't fully understand the context in which it's used, but I know a few months ago boa was not up to the job (well, neither was conda for the matter), but since that's part of the auto build am gonna trust the conda folk

@conda-forge-admin, please rerender

@conda-forge-admin, please rerender

Closing this, will branch off from the rc branch to keep the history clean and open another PR.


Facility list inconsistent in BOPIS app

Current behavior

Facility selection drop down showing an inconsistent list of facilities when compared to Fulfillment app.
https://jam.dev/c/a87a40f5-c230-43bf-8c77-05b5b648e3db
Maybe because facility is not enabled for BOPIS. Not sure if that should impact this list or not.

Update: I checked if it was because of "allow BOPIS" and it was. Closing this task since CSR should not be allowed to release to a location which does not support BOPIS anyway.


Datatype Error in field OBRisk#CountrySubDivision version 3.1.6

Description
Version: 4.1.6
Ticket description: Post consent failure - 400 Error returned
"Message": "Malformed JSON request. Cannot deserialize instance of `java.util.ArrayList` out of VALUE_STRING token\n at [Source: (PushbackInputStream); line: 1, column: 773] (through reference chain: uk.org.openbanking.datamodel.payment.OBWriteDomesticConsent4[\"Risk\"]->uk.org.openbanking.datamodel.payment.OBRisk1[\"DeliveryAddress\"]->uk.org.openbanking.datamodel.payment.OBRisk1DeliveryAddress[\"CountrySubDivision\"])",

The field CountrySubDivision is defined like String in the swagger file version 3.1.6 but in the current implementation version 3.1.6 is defined like as List and stored like a Array, it must necessary upgrade the datatype of countrySubDivision to String.
OB applied the fix fixed CountrySubDivision string committed on 27 May 2020 after release the version 3.1.5 but they applied the fix for all old 3.x.x versions without create a new object, it means that we need upgrade all objects creating a breaking change.

Tasks

[ ] Generate the source from payment initiation swagger file v3.1.6 to update uk-datamodel
[ ] Create a data base upgrade to upgrade the countrySubDivision datatype from Array to String

Solved.


Fix git workflow

📦 Published PR as canary version: 0.0.1-canary.7.67.0

:sparkles: Test out this PR locally via:
npm install<EMAIL_ADDRESS># or
yarn add<EMAIL_ADDRESS>

:rocket: PR was released in v1.0.0 :rocket:


Update out of date dependencies to latest versions

Features
I updated dependencies to be up to date.
eventemitter3, fbjs & hoist-non-react-statics, were out of date

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

For some reason I couldn't resign CLA agreement.


Add link to custom repository documentation in readme

Added a link to the HACS documentation on how to set up custom repositories as mentioned in https://github.com/smartHomeHub/SmartIR/issues/649#issuecomment-905551643.

Nice


Handle multiple RAM regions

Currently this only checks for overflows in single-ram region called RAM.
Eventually it would be awesome to support multi region layouts like:
MEMORY
{
    RAM             : org = 0x20000000, len = 96k      /* SRAM1 */
    RAM2            : org = 0x10000000, len = 32K      /* SRAM2 */
}

The "line-by-line" parser only looks for RAM: org = ..., but I am not sure if this is the actual blocker?
Also minor side issue;
This line: https://github.com/knurling-rs/flip-link/blob/e123f17ba307832d8287ceb708099f2be8100a83/src/main.rs#L61
Should probably read MEMORY.RAM not found after scanning linker scripts ? Missing the not

Eventually it would be awesome to support multi region layouts like:

What kind of layout do you have in mind? For instance, if you place the stack in RAM2 and the rest of sections in RAM then already have stack overflow protection and flip-link should be a no-op.
This definitively seems doable but we need to list the potential arrangements of stack, static variables and heap. Also more than 2 RAM regions seems possible though I'm not sure cortex-m-rt supports that particularly well.

if you place the stack in RAM2 and the rest of sections in RAM then already have stack overflow protection and flip-link should be a no-op.

if we rely solely on standard sections like .bss and .data we may miss the cases where the user puts a custom section (.my_section) in RAM2 -- that could result in a collision. Perhaps we should look at the addresses of symbols instead of at the sections in that (2 RAM regions) case?

 I was waaay to fast on an early monday morning! Totally forgot we are only talking about stack. Please disregard this issue! Feel free to close.

I'm going to leave this open because I think we want to "support" at least the 2 RAM region configuration. By support I mean flip-link should not error and panic and it should produce a binary that won't result in memory corruption due to stack overflow (even if that means doing nothing = linking normally).
Also, I'm not sure what the behavior is in the 2 RAM regions case; that's an scenario I haven't really tested.

In my case i am using both ram regions, but only for static queues and buffers:
#[init(None)]
#[link_section = ".ram2"]
res_queue: Option<ResQueue<AtatRxBufLen, consts::U5>>,
#[init(None)]
#[link_section = ".ram2"]
urc_queue: Option<UrcQueue<AtatRxBufLen, consts::U10>>,
#[init(None)]
#[link_section = ".ram2"]
com_queue: Option<ComQueue<consts::U3>>,

// Cellular Socket Buffer
#[init(None)]
#[link_section = ".ram2"]
socket_set: Option<SocketSet<consts::U2, consts::U2048>>,


update docker version of docker build

Status
Ready/In Progress/In Hold (Reason for hold)
Related Content Pull Request
Related PR: link to the PR at demisto/content
Related Issues
Related: link to the issue
Description
A few sentences describing the overall goals of the pull request's commits.

Docker Image Ready - Dev
Docker automatic build at CircleCI has deployed your docker image: devdemisto/dockerbuild:<IP_ADDRESS>250
It is available now on docker hub at: https://hub.docker.com/r/devdemisto/dockerbuild/tags
Get started by pulling the image:
docker pull devdemisto/dockerbuild:<IP_ADDRESS>250

Docker Metadata

Image Size: 896.41 MB

Image ID: sha256:c4c8f3791ed6f576db6a8e47f73740ad6708a44426a19dc91205eb857ae73b11

Created: 2022-06-27T14:33:20.948612598Z

Arch: linux/amd64

Command: ["bash"]

Environment:

PATH=/home/circleci/.pyenv/shims:/home/circleci/.pyenv/bin:/home/circleci/.poetry/bin:/home/circleci/bin:/home/circleci/.local/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin
DEBIAN_FRONTEND=noninteractive
TERM=dumb
PAGER=cat
LANG=en_US.UTF-8
LANGUAGE=en_US:en
LC_ALL=en_US.UTF-8
DOCKER_VERSION=5:20.10.14~3-0~ubuntu-
COMPOSE_VERSION=2.4.1
COMPOSE_SWITCH_VERSION=1.0.4
PYENV_ROOT=/home/circleci/.pyenv
DOCKER_IMAGE=devdemisto/dockerbuild:<IP_ADDRESS>250

Labels:

maintainer:Community/Partner Engineering<EMAIL_ADDRESS>org.opencontainers.image.authors:Demisto<EMAIL_ADDRESS>org.opencontainers.image.revision:2da2296da155109b792160d33bfd102b035d23f5
org.opencontainers.image.version:<IP_ADDRESS>250


Create a sort of database to persist data

It would be important, for the api to persist data and not lose it all after a server
reload.
Without a lib, this is going to become way more complex.
So add it to a file and consume that file

closed by #4


doc: extensions: kconfig: fix module prefix handling and allow to copy link to results

First commit fixes an issue with module prefixes. Second commit adds the option to copy a link to results:

Very nice link logo. Did you steal it? ;)

Very nice link logo. Did you steal it? ;)

updated to unicode link symbol, so no need to license anything :-)


Properly handle someone sending in both excludedetails and thumbsize

Currently, if someone sends in both excludedetails=true and thumbsize=##, the server responds with a 500 error as it will try to generate thumbnails based on non-existence image fields (since excludedetails results in only the required fields being queried).
API should be updated to properly account for this case by returning a 400 error indicating that one or the other should be provided, not both.

Resolved via https://github.com/Nookipedia/nookipedia-api/pull/25


Create ka.yaml

Translation for Georgian (ka).

@gnadare Please add the file to modules/blox-tailwind/i18n/ too

@gcushen I just created a new pull request by adding translation file (ka.yaml) to modules/blox-tailwind/i18n/. Sorry, new to github, I do not know if this is the simplest way.

I added new pull request which incorporates all needed changes for Georgian.


Problem Homebridge Samsung Air Conditioner Smartthings

Describe Your Problem:

Logs:
[08/11/2023, 13:31:57] [homebridge-samsung-air-conditioner-smart-things] This plugin slows down Homebridge. The read handler for the characteristic 'Active' was slow to respond! See https://homebridge.io/w/JtMGR for more info.

Plugin Config:
Show your Homebridge config.json here, remove any sensitive information.

Screenshots:

Environment:

Plugin Version:
Homebridge Version:
Node.js Version:
NPM Version:
Operating System:

Today:
[09/11/2023, 06:12:12] [homebridge-samsung-air-conditioner-smart-things] Error: Request failed with status code 500
at createError (/var/lib/homebridge/node_modules/homebridge-samsung-air-conditioner-smart-things/node_modules/axios/lib/core/createError.js:16:15)
at settle (/var/lib/homebridge/node_modules/homebridge-samsung-air-conditioner-smart-things/node_modules/axios/lib/core/settle.js:17:12)
at IncomingMessage.handleStreamEnd (/var/lib/homebridge/node_modules/homebridge-samsung-air-conditioner-smart-things/node_modules/axios/lib/adapters/http.js:269:11)
at IncomingMessage.emit (node:events:525:35)
at endReadableNT (node:internal/streams/readable:1359:12)
at processTicksAndRejections (node:internal/process/task_queues:82:21)


#291 replaceOne query added ()

replaceOne functionality added based on issue
https://github.com/Automattic/monk/issues/291

Please merge this!


Fix: Typos and Code translation

[x] I have read freeCodeCamp's contribution guidelines.
[x] My pull request has a descriptive title (not a vague title like Update index.md)
[x] My pull request targets the master branch of freeCodeCamp.
[x] None of my changes are plagiarized from another source without proper attribution.
[x] My article does not contain shortened URLs or affiliate links.

If your pull request closes a GitHub issue, replace the XXXXX below with the issue number.
Closes #XXXXX

Could someone from @freeCodeCamp/portuguese-language-editors have a look and fix the merge conflicts? Thanks


Use transaction.atomic on various do_... functions in actions.py

This PR may not manage to add transaction.atomic in each one of the functions that need it, but it should at least get us closer to it. More commits may be added over time.

I merged most of these as the series ending with 74f4e3e9147e3e9bb4b7cec9155397f81dd35cac; posting a comment on do_set_realm_property.

Merged, after applying the small change noted above.  Thanks @mateuszmandera and @abhijeetbodas2001!


Add an option to throw on extra keys during deserialization

Specifically for the yaml use case, but really whenever json is coming from hand written code, it is important to be able to give an error about unused keys.
This helps people realize common typo and other mistakes in their yaml files.

This is all you, @jakemac53 😄


Responsive without breakpoints

short description of the bug / issue, provide more detail below.
Hi,

I really like your slick slider. I'm just wondering whether it's possible to change the number of slides dynamically? The number of slides would be dynamically determined  based on the size of the parent div on initial load and then on window resize. I know I could use your responsive slider and set all the breakpoints but a dynamic solution would be preferable.
Thanks for ideas / help / solutions...
====================================================================
[  paste your jsfiddle link here  ]
use this jsfiddle to reproduce your bug:
http://jsfiddle.net/simeydotme/fmo50w7n/
we will likely close your issue without it.
====================================================================
Steps to reproduce the problem

...
...

====================================================================
What is the expected behaviour?
...
====================================================================
What is observed behaviour?
...
====================================================================
More Details

Which browsers/versions does it happen on?
Which jQuery/Slick version are you using?
Did this work before?

I am also dealing with the same issue. It looks great at full width. But I would like to change the slides based on the width of the screen. Currently I am using instafeed with slick. it works great till the browser is resized smaller. The only solution I can come up with is using very small images. But then it kind of defeats the purpose because it does not look very good that way.

I'm also looking for this feature. I need my items to have constant width, but depending on the width of the screen I'd love slick to automatically show as many uncropped images as possible.
The only way to do this currently is to set up a whole lot of breakpoints, but the problem is that I do not know what is the maximum width of the screen possible, so I don't know what should the last breakpoint be set at. And actually programatically setting up dozens of breakpoints does not seem to be a good design idea.


Exclude from fee checks if originSender is whitelisted

Description

Type of change

[ ] Docs change / dependency upgrade
[ ] Configuration / tooling changes
[ ] Refactoring
[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Requires changes in customer code

High-level change(s) description - from the user's perspective

Related Issue(s)
Fixes
Related pull request(s)

@wanglonghong which issue is this for?

@wanglonghong which issue is this for?

3136, I can see it linked to the issue.


as-element or custom elements breaks when used in tables

Have tried to comment in closed issue but seems dead?

ViewModel

rowmodel.html

<template>
<require from="somerequirement"></require>

${model.property1}
${model.property2}

${model.detail1}
${model.detail2}

</template>

Currently works without require in chrome but not with, does not work at all in IE. Renders without any tr or td containers.
See plunkr

are you sure you want to repeat a tbody element?  Did you mean to use a tr element?

Yes, this is because of our perticular setup where we have 3 identical lists with spacing inbetween (future, current and historical itemgroups). And each itemgroup contains several items(tbody) and a item(tbody) has n number of tr groups depending on the items setup. Normally there are 2 sets of tr(row details and expanded info) but depending on the amount of changes made to the item the amount of tr grows. So grouping each item inside a tbody makes it alot smoother when styling and managing the item.
Although we are flexible if you can provide us with anoter way to have a custom element with multiple tr and repeat that custom element it would suffice :)

I'm guessing that having multiple tbody elements is a problem for certain browsers.

Well as you can see in the plunkr, rendering it normally (without custom elements) and just repeating on the tbody and having all the html inside the repeated tbody. Everything will render correctly. Problem with this is that we have to copy paste all that html for each of the three sections making it really unmanageable when we change in one place.

${model.property1}
${model.property2}

${model.detail1}
${model.detail2}

To me this looks like the classic bug with IE for example. It doesn't allow
This is an issue posted with a lot of frameworks around the community but as far as I know there are no workarounds for it yet.

bump, any news on this bug?

It's an IE bug. As stated above, it's a problem that all frameworks suffer from and there isn't a way to work around it. Try taking a completely different approach.

@4nderss I have the same problem with as-element with a
, and in Chrome. Easy work around is to move the require inside the first child element within the inner view.
Table:

Inner view

<template>

    <require from="../utils/value-formatter"></require>

</template>

+1 same issue @robharper solution worked. If the require tag is a direct child of the template tag, weird things happen.

You can also remove the <require> statements from the view/template and use the @viewResources decorator on the accompanying VM instead (assuming you have one):
import {viewResources} from 'aurelia-framework';

@viewResources('./path/to/something', './path/to/another/thing')
export class XYZ {
...
}

Aurelia documentation: http://aurelia.io/hub.html#/doc/article/aurelia/templating/latest/templating-custom-elements/7

Not that this is ever getting fixed... but contrary to what has been said here., this is an aurelia problem, not an IE problem. Every other framework I has a solution to this.
Anyways, as said earlier, take a different approach as this won't work

@ggayowsky It'da been fixed long ago, if it was actionable, but maybe let's try to see how your template looks like first? There could be something missing from the framework side?

Here is a easily reproducable of this problem:
custom-table-component.html
<template>
  <require from="./custom-row-component"></require>

        Header A
        Header B
        Header C

</template>
``

custom-row-component.html

```
Both JS classes are just stubs.
The output in IE is (cleaned for readability):

	  Header A
	  Header B
	  Header C

      A B C

      A B C

      A B C

      A B C

      A B C

>

As you can see the TD element are stripped from the custom-row-component output

@ggayowsky Is the content of custom-row-component missing?

@ggayowsky Though, I think I can guess what the content of custom-row-component is, it's probably like:
<template>
  A
  B
  C
</template>

If so, it's as you saw. As per following simple test:

With the latest version of Aurelia templating, we have a way to overcome this, though. Instead of relying on the HTML parser to transform HTML string into HTML template, and potentially mess up the structured intended, we can do that transformation ourselves, or build the HTML template ourselves, to be precise.
An example:
function buildTemplate() {
  const template = document.createElement('template');
  const firstTd = document.createElement('td');
  firstTd.textContent = 'A';
  // ...second, third etc
  template.appendChild(firstTd);
}

export class CustomRowComponent {
  static $view = buildTemplate()
}

Yea missed a backtick which mucked up the formatting.
While I appreciate the work around, I think in our case it was just easier to use divs + table layouts

For:

most templates have bound values in there (much like ours does)

You can achieve the same thing with the following template
<template>
  ${someContentA}
  ${someContentB}
  ${someContentC}
</template>

by the following template building code
function td(text) {
  const $td = document.createElement('td');
  $td.textContent = text;
  return $td;
}
function buildTemplate() {
  const template = document.createElement('template');
  template.appendChild(td('${someContent1}'));
  template.appendChild(td('${someContent2}'));
  template.appendChild(td('${someContent3}'));
  return template;
}

Basically we are building the template, to be bound with data later, not the final view of a custom element. So whatever the expression/template syntax you use, you can do the same, just have to write them in a more tedious form.

Thanks for the workaround. I still think the issue should be reopened


Alternative fix for #1935

Instead of working around the test discovery issue as in PR #1935, try to fix it.

@stefanseefeld, your input would be appreciated.

(tested successfully with conda build on Python 2.7 and 3.5, Ubuntu)

[Current coverage][cc-pull] is 87.36%

Merging [#1936][cc-pull] into [master][cc-base-branch] will increase coverage by <.01%

@@             master      #1936   diff @@
==========================================
  Files           299        299
  Lines         52911      52909     -2
  Methods           0          0
  Messages          0          0
  Branches       5457       5456     -1
==========================================
  Hits          46226      46226
+ Misses         5771       5769     -2
  Partials        914        914

Powered by Codecov. Last updated by [ecbac23...5eb47c5][cc-compare]
[cc-base-branch]: https://codecov.io/gh/numba/numba/branch/master?src=pr
[cc-compare]: https://codecov.io/gh/numba/numba/compare/ecbac23bd107530aa0f2632f7076c7c6d19b6c3d...5eb47c5c110d871da3db038df268323e5767bc5f
[cc-pull]: https://codecov.io/gh/numba/numba/pull/1936?src=pr


Add bg-color to no-matches drop-down

Currently, the no-matches drop-down does not have a background color. If there is any content below the selector, the no-matches text will be mixed with the component under it.

Hi, I've added this in version 1.0.0. Thanks for flagging it!


If there is more information, the class will be OAuth2Exception, not the opposite.

If we can get an OAuth2Exception already from the body, it is likely to have more information than the header does, so just re-throw it here.

this pull request closes #618


GH2325: Added aliases for creating/updating .nuspec files

Implements https://github.com/cake-build/cake/issues/2325
Some details on implementation:

extracted the common parts from NuGetPackSettings and ChocolateyPackSettings into NuSpecSettings

added the missing NuSpec elements as defined in the  latest nuspec.xsd

NuGetPackSettings and ChocolateyPackSettings use internally NuSpecSettings

both NugetPacker and ChocolateyPacker use NuSpecProcessor

added 2 aliases :

NuSpec("./nuspec/TestNuget.nuspec", nuGetPackSettings);
NuSpec(nuGetPackSettings);

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: arturcic sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.

@pascalberger thank you for the feedback. I will take in consideration to keep the implementation separate for Chocolatey and Nuget specs.
In this case, based on the #1037 (comment) I suggest we have such aliases:

NuSpec(FilePath nuspecFilePath, NuGetPackSettings settings) - update the nuget nuspec
NuSpec(FilePath nuspecFilePath, ChocolateyPackSettings settings)  - update the chocolatey nuspec
NuSpec(NuGetPackSettings settings) -  add nuget nuspec
NuSpec(ChocolateyPackSettings settings) -  add chocolatey nuspec

I will review the changes and will try to not introduce breaking changes.

@arturcic apologies for the delay in getting back to you about this one.  We just wanted to pick up on this one.  Are you still interested in working on this?  If not, should we go ahead and close it?

I'll close it for now

@arturcic thanks for following up.  We can definitely discuss this later if you want to continue with it.

Sure, there is still a need to create valid nuspec files, but for now I don't have the time to work on it


Update README.md

Fixed spelling error.

Hello and Thanks for your PR. This pull request came without changes :question:

Thanks...

Ah yeah just noticed a typo :)


Tighten env var security in browser bundles

See https://github.com/reactql/kit/pull/107#issuecomment-339238321

There still needs to be a way to, from userland, allow additional env vars through to the client.
Things like api hostnames/credentials(ie. dev vs stage vs prod) and analytics keys are environment level settings that are needed in the browser bundle. (And for the former example also needed server side for SSR.)

Is there any documentation about using custom process.env variables on the server side? I've just realized that the Webpack setup inside kit was clobbering my environment variables in .env when trying to load through motdotla/dotenv.

env vars will be totally flexible in kit v3.0. There won't be any major changes to the current branch, because it'll wind up being Typescript in 3.0 anyway. Hold tight - hoping to release before the month's out.

mrsteele/dotenv-webpack seems like a popular choice for this problem. It's a Webpack plugin that can bundle only process.env values used in the source code - server side or client.

What can I do now if I want to pass an env var from Heroku for example, and use it from my client code?
I tried changing my build script in package.json to:
"build": "cross-env NODE_ENV=production WEBPACK_CONFIG=browser_prod,server_prod MYVAR=$MYVAR webpack --colors"
(added MYVAR=$MYVAR)
...hoping that when the build script runs on Heroku, Webpack will replace
process.env.MYVAR with the value of MYVAR. But when the client code runs, process.env.MYVAR is undefined.

No, env vars added there won’t do anything. You’ll need to change the kit folder’s source code so they get included in the Webpack build for the server until the next version.
On Tue, Nov 28, 2017 at 7:37 PM, YoniH<EMAIL_ADDRESS>wrote:
What can I do now if I want to pass an env var from Heroku for example, and use it from my client code?
I tried changing my build script in package.json to:
"build": "cross-env NODE_ENV=production WEBPACK_CONFIG=browser_prod,server_prod MYVAR=$MYVAR webpack --colors"
(added MYVAR=$MYVAR)
...hoping that when the build script runs on Heroku, Webpack will replace
process.env.MYVAR with the value of MYVAR. But when the client code runs, process.env.MYVAR is undefined.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub [https://github.com/reactql/kit/issues/109#issuecomment-347723557] , or mute the thread [https://github.com/notifications/unsubscribe-auth/AA6AKuyhNLtn4aKRJy2lzJZXk3Wkr0cxks5s7LVCgaJpZM4QFiyQ] .

Apologies for the generic response, but I've released a new v3.0 kit, which has been re-written from the ground up.
It bumps the ReactQL stack to Webpack 4, React 16.4, Apollo Client 2.0, and adds Styled Components, full SSR (even in development), and has been re-written in Typescript. It's leaner, faster and has been brought completely up-to-date.
If you're still using ReactQL (and I appreciate you may not be, given the time lag in my response), I'd recommend checking out the new kit to see if your issue has been answered. If not, please feel free to post a new issue at https://github.com/leebenson/reactql


result on AV2

Argoverse 2 dataset has been released. Have you ever tried to use DenseTNT on it? And what about the result?

We haven't tested it on Argoverse 2 yet. If it goes well, we will update results on Argoverse 2 in August.

Hello, I am also interested in the results on Argoverse 2. Have you finished the work yet ? When will it be released ? Looking forward to your reply.

We are tuning DenseTNT on Argoverse 2. We add the training code of Argoverse 2 for reference: https://github.com/Tsinghua-MARS-Lab/DenseTNT/tree/argoverse2

We are tuning DenseTNT on Argoverse 2. We add the training code of Argoverse 2 for reference: https://github.com/Tsinghua-MARS-Lab/DenseTNT/tree/argoverse2

Hello, Thank you for your wonderful work.
I try to use your code to train DenseTNT on Argoverse 2, and there was no problem with the training process. But when I started starting the validation phase(i.e. add --do_eval --do_eval --eval_params optimization MRminFDE=0.0 cnt_sample=9 opti_time=0.1), an error will occur. May I ask that the author's code on Argoverse 2 validation set hasn't been released yet? Looking forward to your reply.

We are tuning DenseTNT on Argoverse 2. We add the training code of Argoverse 2 for reference: https://github.com/Tsinghua-MARS-Lab/DenseTNT/tree/argoverse2

Hi,  do you have plans for  updating the Argoverse2 result?
Have you finished the branch argoverse2? I mean the code could run

Hi, we have just added evaluation metrics for Argoverse2.

We are tuning DenseTNT on Argoverse 2. We add the training code of Argoverse 2 for reference: https://github.com/Tsinghua-MARS-Lab/DenseTNT/tree/argoverse2

Hi, do you have plans for updating the Argoverse2 result? Have you finished the branch argoverse2? I mean the code could run

Hi, we have just added evaluation metrics for Argoverse2.

We are tuning DenseTNT on Argoverse 2. We add the training code of Argoverse 2 for reference: https://github.com/Tsinghua-MARS-Lab/DenseTNT/tree/argoverse2

Hi, do you have plans for updating the Argoverse2 result? Have you finished the branch argoverse2? I mean the code could run

Hi, we have just added evaluation metrics for Argoverse2.

Could I ask a simple question? If we use Argeverse2 dataset,  do we also need Argoverse1 API?  Or we just need av2-api?

We are tuning DenseTNT on Argoverse 2. We add the training code of Argoverse 2 for reference: https://github.com/Tsinghua-MARS-Lab/DenseTNT/tree/argoverse2

Hi, do you have plans for updating the Argoverse2 result? Have you finished the branch argoverse2? I mean the code could run

Hi, we have just added evaluation metrics for Argoverse2.

Could I ask a simple question? If we use Argeverse2 dataset, do we also need Argoverse1 API? Or we just need av2-api?

We only need to install av2 use pip


Training error (bash run.sh): libprotobuf FATAL google/protobuf/stubs/common.cc:61

Hello all,
I met a libprotobuf version problem, when I tried to train network by comment "bash run.sh". It gave the error message:
[libprotobuf FATAL google/protobuf/stubs/common.cc:61] This program requires version 3.9.0 of the Protocol Buffer runtime library, but the installed version is 2.6.1.  Please update your library.  If you compiled the program yourself, make sure that your headers are from the same version of Protocol Buffers as your link-time library.  (Version verification failed in "google/protobuf/descriptor.pb.cc".)
terminate called after throwing an instance of 'google::protobuf::FatalException'
what():  This program requires version 3.9.0 of the Protocol Buffer runtime library, but the installed version is 2.6.1.  Please update your library.  If you compiled the program yourself, make sure that your headers are from the same version of Protocol Buffers as your link-time library.  (Version verification failed in "google/protobuf/descriptor.pb.cc".)
I think it should be the Protocol Buffers version conflict problem of System (2.6.1) and Anaconda (3.9.0). I tried to solve this problem but failed. Any one can give the detailed instruction about how to solve it. Thanks in advance! @foolwood

I solved this problem, therefore I just close this issue. Thanks all!


Add Highlight token to marked

As I am already on a blasphemy streak, this is a PR to overload the tradition  mapping for __thing__ to <mark>thing</mark>.

A side note - if this is intended to only be used for a strikeout pattern then it is redundant vs the GHM ~ based pattern.It should be used differently or the markup indicators should be saved for another purpose.

I'm kind of assuming there was discussion in Gitter about this back when you first opened it, but I couldn't find it with a quick search.
I hesitate with this because I'm not sure I see the utility in being able to <mark> text, beyond just having one more html tag we can then style.  Personally, I just use the <del> tag that is easily available with ~~text~~ and then style it with css.  I do think that mark is likely a more semantically appropriate tag for this, and in another environment I would fully support having more tags in the toolchest...
...but:

or the markup indicators should be saved for another purpose.

as you mention here, we have limited prime indicators available and thus we have to be very conservative.  I don't think <mark> is unique/useful enough to use a good indicator on.

as you mention here, we have limited prime indicators available and thus we have to be very conservative. I don't think <mark> is unique/useful enough to use a good indicator on.

I tend to agree, however, I have failed, utterly, to think of a single better use for the markup that also suits the pattern.

At the end of the day, we can use this for another feature if we think of it for v4, i say we give this a go.

Taking more inspiration from Obsidian, they use ==Content== for highlighting. May be we could just follow that precedent again here and not have to worry about overriding underscores for now (plus, if we use _content_ for underline later, __content__ for highlighting might be similar enough to be confusing.)

Taking more inspiration from Obsidian, they use ==Content== for highlighting. May be we could just follow that precedent again here and not have to worry about overriding underscores for now (plus, if we use _content_ for underline later, __content__ for highlighting might be similar enough to be confusing.)

Good thought.


spirv-fuzz: IdIsAvailableBeforeInstruction doesn't support unreachable blocks

fuzzerutil::IdIsAvailableBeforeInstruction and fuzzerutil::IdIsAvailableBeforeUse use DominatorAnalysis and domination rules are undefined for unreachable blocks.
Related to #3714 and #3713.

@paulthomson, this issue affects many existing transformations.

A simple solution is to just return false if the block is unreachable. However, I think it is OK to use a reachable instruction from an unreachable block (at least spirv-val has no complaints). Thus, I think we can support this case.


Add username paramter to the query params when user is locked on Email OTP

Is your suggestion related to an experience ? Please describe.
As mentioned in https://github.com/wso2/product-is/issues/16333#issuecomment-1679205342, when a user is locked, following params are sent.
TOTP
username: <username>
authFailure: true
authFailureMsg: login.fail.message

Email OTP
authFailure=true
authFailureMsg=user.account.locked

The request is to add username param in the Email OTP flow as well.

This issue is being closed due to extended inactivity. Please feel free to reopen it if further attention is needed. Thank you for helping us keep the issue list relevant and focused!


Aimbot doubt.

Is there any option to avoid locking to another target after a kill?

Disable "Between shots" and set Max Inaccuracy to very low, play around with the settings.
If that doesn't help try to decrease the FOV.

What "Between shots" do?

What "Between shots" do?

if disabled(between shots) aimbot does not activate until a bullet is ready. So basically if you one deag someone with high fov low smooth it will not snap to another target until you can shoot again.


Nuget install/restore vsts feed warning

##[warning]To connect to NuGet feeds
hosted in your Team Services account/TFS project collection with
NuGet 3.1 or below, edit your build definition to specify a path
to a NuGet.config containing the package sources you wish to use.
This warning occurs even though using higher version of Nuget tool or do not restore package from VSTS feed.

Thanks for reporting.  I see the issue in the code coming from our transition from depending on assets coming with the agent to being deployed with the task.  You can get around this by either (1) choosing to use the Nuget 3.5 version radio button in the task config or (2) supplying a path to your nuget.config.

Thanks.


Use new VersionTools submodule updaters

Add submodule dependency tooling: part 1 of https://github.com/dotnet/source-build/issues/151. For part 2 (submodule update PRs), I'll be setting up a scheduled build in VSTS.
Configuration for submodules goes in .gitmodules. The commands here will only affect submodules with a branch. Auto-updates can be disabled without removing the branch by adding sourceBuildAutoUpdate = false to the submodule config.
The reason for using .gitmodules is that it lets devs use git submodule update --remote if they want to.
The new upgrade-related targets (not all necessarily useful, just stuff we get for free with VersionTools):

/t:PullSubmodules or /t:UpdateToRemoteDependencies

Check out the latest remote commit of each submodule.

/t:UpdateDependencies

Update each submodule to the hash in the index. (Same result as running git submodule update.)

/t:VerifyDependencies

Check if the commit of any checked-out submodule doesn't match the hash in the Git index of source-build.

/t:UpdateToRemoteDependencies /t:CreatePullRequestIfChanged or /t:UpdateDependenciesAndSubmitPullRequest

Updates to the latest remote commit of each configured submodule, then submits a PR.

All targets support /p:TargetSubmodule=src/corefx to specify a single submodule.
I'm able to run all the targets on Windows and Fedora 26.
@dotnet/source-build-contrib

A more practical reason is that I can't think of a clear way to "extract" a property from each submodule's .proj. (I can think of parsing or building each one with a target that writes the property to a file. Maybe I'm missing something.)

You can put a new target in the dir.targets file in the folder, and then invoke that target on each project.  We do this quite often for things like project-to-project references, or even that's how we do multiple TargetFrameworks support.
Here are a few examples:
How ProjectA => ProjectB knows the output file from ProjectB to reference:
https://github.com/Microsoft/msbuild/blob/57ae27cf0812bf262c6f8be456ed527a1542dba7/src/Tasks/Microsoft.Common.CurrentVersion.targets#L1723-L1735
How a Project builds for multiple TargetFrameworks:
https://github.com/dotnet/sdk/blob/b5aa4a2b0db4f6203050063139e1873fa024337a/src/Tasks/Microsoft.NET.Build.Tasks/buildCrossTargeting/Microsoft.NET.Sdk.targets#L65-L69

@eerhardt Ah, neat, I looked at TargetOutputs, but I'd always thought that a target's Outputs had to be an actual file. I just tried it out with arbitrary values and it works. I'll stick with .gitmodules for now for the other reason, but I'll keep this in mind for the future.

Now that BuildTools is up to date, should be able to finally merge this.
In my last push I updated CoreCLR, CoreFX, and Core-Setup to point to their release/2.0.0 branches because dev/release/2.0.0 was merged in.


Implement CH4 Challenge 2 - Address generation

Use the ScriptingChallenge component to implement chapter 4 challenge 2. For our lesson IDs we can use CH4AD1 and CH4AD2.
Link to Figma
Is currently blocked by https://github.com/saving-satoshi/saving-satoshi/issues/624

Can I work on this issue?

ATM blocked by #701 due to need for saveData => getData


Metro reload crashes - segfault

Describe the bug
When a db connection has a updateHook(), and you reload in metro the whole app crashes from a segfault.
Versions:

OS and version: android 14
op-sqlite version: latest 2.0.9
RN version: 0.73.1 and 0.72.6

Reproducible example
https://github.com/Zoxive/op-sqlite/tree/UpdateHookCrashes
(Idk why cpp/sqlite3.h shows up in the diff, i tried creating the branch 2 times.. did it both times)
Basically just need a updateHook registered, and in metro if you press "R" to cause a reload it crashes.
Tested it on device, and in android simulator.
I get a very rough stacktrace in sentry:

libop-sqlite +0x06d44c <unknown> libop-sqlite +0x05d110 opsqlite::registerUpdateHook libop-sqlite +0x06d0ac <unknown> libhermes_executor +0x3e269c <unknown> libhermes_executor +0x3e25c4 std::__ndk1::function<T>::operator() libhermes_executor +0x3e2530 facebook::jsi::DecoratedHostFunction::operator() libhermes_executor +0x3e24b8 <unknown> libhermes_executor +0x3e2404 std::__ndk1::__invoke_void_return_wrapper<T>::__call<T> libhermes_executor +0x3e2340 <unknown> libhermes_executor +0x3e10d0 std::__ndk1::__function::__func<T>::operator()

Thanks for creating the reproduction, super helpful. It's fixed on 2.0.10

same on 3.0.4

@talaikis can you create a reproduction so I can take a look? In the sample app everything is working

@talaikis can you create a reproduction so I can take a look? In the sample app everything is working

Seems solved after deleted gradle cache.