Adding Social Share Example

Covers all regular examples

Has the extension been already released to prod as the validation in the build fails?

Please don't merge this until amp-social-share is published (merged to release). https://github.com/ampproject/amphtml/commit/519b3e8877a672d40461beb15b69181dc83b7526
Should be later this week.
https://github.com/ampproject/amphtml/commits/release

If it is already available as an experiment you can add the following block:
<!---{
  "experiment": true,
  "component": "amp-experimenal-component"
}--->

This will exclude it from validation and show a card on how to enable experiments.


Repository link

https://crates.io/crates/license-exprs currently doesn’t link to this repository, but I see you’ve already added the link ba71da572508be385cffcc3a21279ef91aa09e52. Could you publish a new version with it? Thanks!

Thanks for reminding me. I had changed my github username between creating the crate and pushing those changes, and couldn't upload to cargo at the time. Then I got busy and it slipped my mind.


Used urlparse and urlsplit from urllib

The bespoke _urlparse and _urlsplit methods were included
in Django so that a patch awiating merge to Python could be applied.
This patch has now been merged into Python and backported to Python 3.8
and so special methods in Django are no longer required.

This patch has been reverted in Python 3.8.2 (see https://github.com/python/cpython/pull/18525), so vendored versions should still be required.

But not reverted in Python3.9? I see the test suite passing locally for me with 3.9.
My Python repo searching skills are (clearly) not that good :-)

But not reverted in Python3.9? I see the test suite passing locally for me with 3.9.

Yes, exactly.


Failed e2e tests don't appear to be stored

What steps did you take and what happened:
e2e fails some conformance tests, but sonobuoy retrieve doesn't store the failures.
$ sonobuoy e2e<PHONE_NUMBER>34_sonobuoy_b7635f06-19b1-4037-9c46-e6b35dd62ece.tar.gz
ERRO[0000] could not get tests from archive: failed to find results file "plugins/e2e/results/global/junit_01.xml" in archive

What did you expect to happen:
To be able to inspect and list the failures that have occurred.
Anything else you would like to add:
[Miscellaneous information that will assist in solving the issue.]
Running the logs on the e2e containers shows that the test ran and displayed errors. Two sig-network tests failed.
The e2e container has gone once the run completes.
Environment:

Sonobuoy version: 0.16.0
Kubernetes version: (use kubectl version):
Server Version: version.Info{Major:"1", Minor:"16", GitVersion:"v1.16.0", GitCommit:"2bd9643cee5b3b3a5ecbd3af49d09018f0773c77", GitTreeState:"clean", BuildDate:"2019-09-18T14:27:17Z", GoVersion:"go1.12.9", Compiler:"gc", Platform:"linux/amd64"}
Kubernetes installer & version:
kubeadm version: &version.Info{Major:"1", Minor:"16", GitVersion:"v1.16.0", GitCommit:"2bd9643cee5b3b3a5ecbd3af49d09018f0773c77", GitTreeState:"clean", BuildDate:"2019-09-18T14:34:01Z", GoVersion:"go1.12.9", Compiler:"gc", Platform:"linux/amd64"}
Cloud provider or hardware configuration:
Brightbox
OS (e.g. from /etc/os-release):
Ubuntu 18.04.3 LTS
Sonobuoy tarball (which contains * below)

Could you share your tarball with me?
This is a somewhat common failure mode where the plugin fails to report the results to Sonobuoy.
Only because Sonobuoy gathers logs afterwards do we see that tests ran. You can usually figure out what went wrong with the reporting with the info in the rest of the tarball.
Without seeing the logs it is hard to diagnose though.

The logs from the e2e container (captured in a terminal session running sonobuoy logs -p e2e -f)
Sep 28 08:19:20.448: INFO: Running AfterSuite actions on all nodes
Sep 28 08:19:20.448: INFO: Running AfterSuite actions on node 1
Sep 28 08:19:20.448: INFO: Skipping dumping logs from cluster

Summarizing 2 Failures:

[Fail] [sig-network] Services [It] should be able to change the type from ExternalName to NodePort [Conformance]
/workspace/anago-v1.16.0-rc.2.1+2bd9643cee5b3b/src/k8s.io/kubernetes/_output/dockerized/go/src/k8s.io/kubernetes/test/e2e/framework/service/jig.go:821

[Fail] [sig-network] Services [It] should be able to create a functioning NodePort service [Conformance]
/workspace/anago-v1.16.0-rc.2.1+2bd9643cee5b3b/src/k8s.io/kubernetes/_output/dockerized/go/src/k8s.io/kubernetes/test/e2e/framework/service/jig.go:821

Ran 22 of 4897 Specs in 752.071 seconds
FAIL! -- 20 Passed | 2 Failed | 0 Pending | 4875 Skipped
--- FAIL: TestE2E (752.21s)
FAIL

Ginkgo ran 1 suite in 12m34.479661122s
Test Suite Failed

namespace="sonobuoy" pod="sonobuoy-e2e-job-91599be9d346456e" container="sonobuoy-worker"
time="2019-09-28T08:24:23Z" level=info msg="received a signal. Waiting then sending the real shutdown signal."  Use `sonobuoy retrieve` to get results.

$ sonobuoy retrieve
201909280805_sonobuoy_94247daa-c113-4ad4-a100-5079409bdebe.tar.gz

201909280805_sonobuoy_94247daa-c113-4ad4-a100-5079409bdebe.tar.gz

Thanks so much for the logs.
Some things expected, some things not:
Expected:

the aggregator doesnt ever report being given results for that plugin

Unexpected

So the tests do seem to run fully (22 tests expected and I see them all reported on in the logs)
I dont see any timeouts

Note:
The e2e container did terminate with a non-zero status and I am concerned that it is this, and some flaw in the upstream e2e image, that caused the reporting to not take place:
"exitCode": 1,
"finishedAt": "2019-09-28T08:19:20Z",
"reason": "Error",

Continuing to investigate.

From pod info, the container exited 1 at
"finishedAt": "2019-09-28T08:19:20Z"

And in the Sonobuoy logs, it stopped waiting for results at:
time="2019-09-28T08:24:20Z" level=info msg="Last update to annotations on exit"

So it did wait 5 more miniutes after the container terminated to see results.

I think more logging was needed here to make this clear. There are logs in place
for when we get results, but apparently the logs are not sufficiently clear when
this error mode occurs.
The error reported mentioned the termination, it would have also been helpful to list the
time that the error message was generated (so I didn't have to cross-reference the other set of logs)
It does seem to be an issue with the upstream issue. Going to take a look there and try
to repro. This sort of thing has happened before unfortunately and caused us to push our own
conformance image to patch the issue.

So it does seem the problem lays in the upstream image.
https://github.com/kubernetes/kubernetes/commit/2242718e1790446deeb9322dfd0851dfe77e9663#diff-0efd26687540ba2cbfd9547019622551R70 modified the code to run the tests in the foreground and eliminated a race.
However, when it exits non-zero it causes the script to exit immediately without saving results and sending them to sonobuoy.
Remediation:
I'll have to fix the upstream image bash runner, but this is part of the reason I personally wanted to get away from a bash script like this (clarity, logging, testing, etc).
You can leverage the go-based runner which was added this release as well by setting E2E_USE_GO_RUNNER=true.
It may be that we need to make this default for Sonobuoy sooner than expected. We wanted to use it in our testing but let it soak a bit but if the e2e image isn't reporting results in failure situations then we need to address it.
We may be able to publish a new e2e conformance image once fixing it, but in the past, I think we had to just wait until the next release, especially if Sonobuoy was able to mitigate the problem.


Help react in action letters

Hello,
So i've read the book up to chapter 4 and so far so good. I'm having issues running the app in developer 'mode' locally. I tried to clone the letters repo, and run it but it didn't work (picture1).
npm run dev
<EMAIL_ADDRESS>dev
cross-env NODE_ENV=development npm-run-all -p api client:dev server:dev styles:w
sh: cross-env: command not found

So then I tried to clone the repo with the command given in the book, and it didn't work either (picture2).
git clone git@github.com:react-in-action/letters-social.git
Cloning into 'letters-social'...
Warning: Permanently added the RSA host key for IP address '<IP_ADDRESS>' to the list of known hosts.
<EMAIL_ADDRESS>Permission denied (publickey).
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.

Can you please give me a step by step way to make things work?
Lastly I was wondering why is the app not running on this link? https://social.react.sh
Did you deploy it somewhere else?
Thanks for your work. I appreciate it.
Zouhir

Hello, need some help to get the app running. what scripts do I have to run to make things work locally? please.
The book just says:
"As I mention in other places in this book, tooling around JavaScript applications can be a complex and fast-moving target. It’s also a domain that deserves its own treatment. For these reasons, I won’t be covering how to set up things like Webpack, Babel, or other tools. The application source code has a development and build process in place, and you’re free to explore the configuration I’ve set up, but that’s outside the scope of this book, so I won’t be covering it."
thanks
@markthethomas


Languages menu

I discovered that there is a "Languages" option in the menu widget. Unfortunately I did not find any documentation on the topic of internationalising the dev portal or where to configure the languages...

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 54c705a3-b106-e0dd-8f50-a74c3752ab40
Version Independent ID: 748e587e-7617-8c9e-0a17-7d070a7b99ce
Content: Tutorial - Access and customize the developer portal - Azure API Management
Content Source: articles/api-management/api-management-howto-developer-portal-customize.md
Service: api-management
GitHub Login: @dlepow
Microsoft Alias: danlep

@innoforce-dev , There is no support for multilanguage support yet. Please see : https://github.com/Azure/api-management-developer-portal/issues/137
I am closing this issue. Feel free to reopen if required


database is locked

Call to function 'ExpoSQLite.exec' has been rejected.
→ Caused by: android.database.sqlite.SQLiteDatabaseLockedException: database is locked (code 5 SQLITE_BUSY): , while compiling: PRAGMA journal_mode
估计是哪里没 close
后台放一会儿，分享东西过去，然后删除条目就会这样了。

在关闭 wiki 时尽量关闭链接 https://github.com/tiddly-gittly/TidGi-Mobile/commit/31eab4163c4bc09422dd60016d806827e5a2a540
实在不行，把文件移来移去就能解锁 https://github.com/tiddly-gittly/TidGi-Mobile/commit/b23306cb419c4c28412a23a1354dc29a91727962


QA Cert Data: Display Date and Time Together

For QA Cert Events Data, the grid displays the Event Date, Hour; Begin Date, Hour and End Date and Hour as separate columns. Update the format for these fields as follows:

QA Cert Event Date and Time
Conditional Begin Date and Time
Completion Test Date and Time

Format: YYYY/MM/DD H
Note: If end date is not available and hours/mins are, it should just leave it blank

QA Cert Data- Display Date and Time Together 4965 Logged In

QA Cert Data- Display Date and Time Together 4965 Logged Out

Updates completed


Add create_metadata_file utility for existing parquet datasets

This PR adds a simple utility to construct a global _metadata file from the footer metadata in a list of files.  Since Dask's read_parquet code is optimized to leverage this shared metadata source, it makes a lot of sense to make this file easy to generate.
Use Example
import glob
import dask.datframe as dd

# Specify the list of parquet files to collect metadata from
paths = glob.glob("/my/dataset/*.parquet")

# Use `create_metadata_file` to generate `_metadata`
dd.io.parquet.create_metadata_file(paths)
...

TODO:

[x] Add better description to this PR
[x] Remove temporary cudf-based test (open separate cudf PR)
[x] Avoid use of os.path.relpath
[x] General cleanup (and add comments)

NOTE: This will help resolve to NVT#429 (Updating the CudfEngine engine in dask_cudf will avoid the "inconsistent schema" error altogether)

Thanks for the review @jsignell - I agree that this change is isolated and therefore "low risk."  Even so, it would be nice to see passing CI... it's pretty frustrating that a failure cancels all subsequent checks :/

Even so, it would be nice to see passing CI... it's pretty frustrating that a failure cancels all subsequent checks :/

Yeah I agree - CI should pass. You might be able to toggle this temporarily to get all the tests to run: https://github.com/dask/dask/blob/5543d936a91bad3844adf4045266735b44415dcf/.github/workflows/ci.yml#L9

Yeah I agree - CI should pass. You might be able to toggle this temporarily to get all the tests to run:

Okay - I tried this and everything passed anyway that time :)
Thanks again!

That error looks unrelated although I can't figure out exactly what's going on.

That failure is strange - It is definitely unrealated to this PR.  Perhaps pandas_datareader is just failing to retreive the stock data?  It does seem like we can pass a retry_count parameter to this pandas_datareader.DataReader call.  If this failure shows up again, it may be worth experimenting with that.


Implement Trace Logging as A Partial Method

Let's see if we can take our current trace logging facility and wrap it as a partial method, so that logging methods can log using logger.trace

I have trace logging running within a local feature branch. Trace logging is configured using a bootstrapping method integrated within server handlers
def add_trace_logging():
    """
    Adds trace level logging support to logging and the root logging class
    """

    def trace(self, message, *args, **kwargs):
        """
        Generates a TRACE log record
        """
        self.log(5, message, *args, **kwargs)

    logging.addLevelName(5, "TRACE")
    logging.getLoggerClass().trace = trace

Logging config
version: 1
disable_existing_loggers: false
formatters:
  simple:
    format: '%(asctime)s - %(name)s - %(levelname)s - %(message)s'
handlers:
  console:
    class: logging.StreamHandler
    level: TRACE
    formatter: simple
    stream: ext://sys.stdout
root:
  level: WARN
  handlers: [console]
loggers:
  connect:
    level: TRACE
  uvicorn:
    level: INFO

I will also test with the handler set to DEBUG to verify that we aren't emitting log events.

So, with this approach, does getting the logger and using trace look like:
logger = logging.getLogger(__name__)
logger.trace("message")

?  If so, that's exactly what we are looking for.

So, with this approach, does getting the logger and using trace look like:
logger = logging.getLogger(__name__)
logger.trace("message")

? If so, that's exactly what we are looking for.

@ccorley - exactly! We still may not have "auto-completion" support since we're appending a function to the type at runtime, but we can look at refining that later if needed.


[User story] ....Splitting up parent class Azure for the purpose of extending Azure importer

As a  I want  so that .

FYI @yelghali


Add new topic button translation

I noticed that there is a button in the topic template that is not translated and is hard coded.

I've added the [[category:new_topic_button]] translation to the topic.tpl file.

Thanks, the headline was tested and the text was not the most important.


test: Migrate some files to snapbox

What does this PR try to resolve?
 tests/testsuite/credential_process.rs
 tests/testsuite/cross_compile.rs
 tests/testsuite/cross_publish.rs
 tests/testsuite/custom_target.rs

part of #14039

Thank you.
@bors r+

:pushpin: Commit b1a157f47bb5fb1e3d51a75b000d34d20c69d484 has been approved by weihanglo
It is now in the queue for this repository.

:hourglass: Testing commit b1a157f47bb5fb1e3d51a75b000d34d20c69d484 with merge 50e1e53f0e9f3e1ad347bbb7e9a072661f9e4387...

:sunny: Test successful - checks-actions
Approved by: weihanglo
Pushing 50e1e53f0e9f3e1ad347bbb7e9a072661f9e4387 to master...


Possibility to customize mailgun api base url

Need to modify api base url (cf. https://github.com/notifme/notifme-sdk/issues/70).
When the domain is tagged as "EU" for example, api base url is api.eu.mailgun.net and not api.eu.mailgun.net

Thanks for your PR, I'll review it as soon as I can (I was off last week).

I'm catching up, sorry for the delay.


Fix incorrect package in ServerHandler

The server actually work
I think the problem is incorrect package imported in ServerHandler

Thanks, good catch. Working now.


Annotate config setup tables as optional

[x] I have read CONTRIBUTING.md
[x] I have read CODE_OF_CONDUCT.md

Currently, not all mini modules have their config setup tables annotated as optional even though they have noted:

-- No need to copy this inside setup(). Will be used automatically.

E.g.: https://github.com/echasnovski/mini.nvim/blob/main/readmes/mini-trailspace.md#installation
For those modules it results in a type error.

Of course a user can just pass an empty {} to silent the error.
But I feel like the right solution would be to annotate them correctly as optional.
Usually marking a param as optional is done by adding a question mark, <type>?. But I followed the convention in the modules that have marked it's config tables as optional by addling |nil. If this should changed, please let me know. I think it could be nicely done in one wash with this PR.

Thank you for PR!
Yeah, I've been meaning to do this for while. Not only in setup() but also for all functions which have default values. I'll try to make time for this in the near future.

This should be in main now. Along with the massive update of all annotations. Thanks for the push!


libgpiod: 1.5 -> 1.5.1

Semi-automatic update generated by nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/libgpiod/versions.
meta.description for libgpiod is: "C library and tools for interacting with the linux GPIO character device"
meta.homepage for libgpiod is: "https://git.kernel.org/pub/scm/libs/libgpiod/libgpiod.git/about/"
Updates performed:

Version update

Checks done (click to expand)

built on NixOS

The tests defined in passthru.tests, if any, passed

0 of 0 passed binary check by having a zero exit code.

0 of 0 passed binary check by having the new version present in output.

found 1.5.1 with grep in /nix/store/15xqcx2m4qhb2zp3a2l8w3nvk0z8f3w4-libgpiod-1.5.1

directory tree listing: https://gist.github.com/dbc4d9f5ded2ed7e85da3f536b7b01b6

du listing: https://gist.github.com/63211103821dfb1714ebe90507b3b320

Rebuild report (if merged into master) (click to expand)

9 total rebuild path(s)
3 package rebuild(s)
3 x86_64-linux rebuild(s)
3 i686-linux rebuild(s)
0 x86_64-darwin rebuild(s)
3 aarch64-linux rebuild(s)
First fifty rebuilds by attrpath
libgpiod
python37Packages.libgpiod
python38Packages.libgpiod

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/15xqcx2m4qhb2zp3a2l8w3nvk0z8f3w4-libgpiod-1.5.1 \
  --option binary-caches 'https://cache.nixos.org/ https://r-ryantm.cachix.org/' \
  --option trusted-public-keys '
  r-ryantm.cachix.org-1:gkUbLkouDAyvBdpBX0JOdIiD2/DP1ldF3Z3Y6Gqcc4c=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(r-ryantm's Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A libgpiod https://github.com/r-ryantm/nixpkgs/archive/3646e5c0edc9999e4ddfbb3c7f2e08ecb5d89a3c.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/15xqcx2m4qhb2zp3a2l8w3nvk0z8f3w4-libgpiod-1.5.1
ls -la /nix/store/15xqcx2m4qhb2zp3a2l8w3nvk0z8f3w4-libgpiod-1.5.1/bin

cc @expipiplus1 for testing.

Cross compilation for armv7l-linux is broken, but it was broken in 1.5 so this is no worse and otherwise things seem to work.


Tables coming as a stack

Hello, thank you for this amazing library. I'm trying to place 4 tables side by side on the same y panel but they keep on appearing one after another. Gave the same y value for all 4 but still coming on top of each other.

r

Hi, @nabiltkarim. Thanks to come here.
You found a bug! :)
Upgrade version:
$ npm install pdfkit-table@latest
Check this:
https://github.com/natancabral/pdfkit-table#0170

document-4.pdf

Sample
document.pdf

Legend! Thank you so much


NotFoundHttpException in RouteCollection.php

I made everything like in instruction, but when I try use url it throws NotFoundHttpException in RouteCollection.php
http://stackoverflow.com/questions/43865524/laravel-hesto-multi-auth-notfoundhttpexception/43866844?noredirect=1#comment74769585_43866844

The right url is student.yourdomain.com/login
You can edit your HOSTS file,but you can‘t direct use php artisan serve,you should use Homestead,or deploy code in Linux+PHP+Nginx+MySQL.
I prefer use Homestead.
Example:
my HOSTS:
<IP_ADDRESS> dev.app

my homestead.yaml
ip: "<IP_ADDRESS>"


fix(swagger): Solve problem with the inheritance class

Closes: #289

Informations

Type
Status
Migration

Feature/Fix/Doc/Chore
Ready/In development/Hold
Yes/No

Description
A few sentences describing the overall goals of the pull request's commits.
Usage example
Example to use your feature and to improve the documentation after merging your PR:
import {} from "@tsed/common";

Todos

[ ] Tests
[ ] Coverage
[ ] Example
[ ] Documentation

:tada: This PR is included in version 5.1.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Does this project stand with Ukraine?

🇺🇦🇺🇦🇺🇦🇺🇦?

I think #27 talks about this a little

I think #27 talks about this a little

Maybe they talk about it a little, but nowhere near enough imo

This truly is an issue for the master branch, do you not agree @Natsumi-sama

its kinda far to just be next to it, airplane tickets are expensive rn

its kinda far to be next to it, airplane tickets are expensive rn

Please be serious, I don't want to use communist software that deals with the bad guys.


Idea: Add Mod Config Menu support

Most other script mods have sliders in the mod config menu, Therapeutic Gold should add this feature to be more in-line with those  mods.

Menu Support implemented!


travis: removed caching since this produces some errors

Signed-off-by: Miquel Sabaté Solà<EMAIL_ADDRESS>

Minor fix again. Cleaning up my own mess...


FIX: Limit Azure OpenAI embeddings chunk size

Hi!
This short PR aims at:

Fixing OpenAIEmbeddings' check on chunk_size when used with Azure OpenAI (thus with openai < 1.0). Azure OpenAI embeddings support at most 16 chunks per batch, I believe we are supposed to take the min between the passed value/default value and 16, not the max - which, I suppose, was introduced by accident while refactoring the previous version of this check from this other PR of mine: #10707
Porting this fix to the newest class (AzureOpenAIEmbeddings) for openai >= 1.0

This fixes #13539 (closed but the issue persists).
@baskaryan @hwchase17

thank you @mspronesti!


Automated project structure updation using github workflows, python scripts and action bot

What does this PR do?
Automated project structure updation using github workflows, python scripts and action bot
Fixes #28
Screenshots

Type of change

New feature (non-breaking change which adds functionality)

How should this be tested?
Check the README.md and PROJECT_STRUCTURE.md
Mandatory Tasks

[x] Make sure you have self-reviewed the code. A decent size PR without self-review might be rejected.

@iamkanhaiyakumar Could u please review the PR and merge it?

Sure
On Wed, Oct 23, 2024 at 10:23 PM Mugundh J B @.***>
wrote:

@iamkanhaiyakumar https://github.com/iamkanhaiyakumar Could u please
review the PR and merge it?
—
Reply to this email directly, view it on GitHub
https://github.com/iamkanhaiyakumar/ai-content-generator/pull/32#issuecomment-2432849360,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AXQK7TARG3LY2JKJ4OSDIV3Z47IBXAVCNFSM6AAAAABQMELJZGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMZSHA2DSMZWGA
.
You are receiving this because your review was requested.Message ID:
@.***>


Support feature packages of vcpkg

Is your feature request related to a problem? Please describe.
I used ffmpeg and x264 in a library. I used the vcpkg versions since the xmake versions do not support windows. To be able to use ffmpeg with x264 you have to build it using --enable-libx264. In vcpkg this is achieved by installing ffmpeg[x264]. But if you use add_requires("vcpkg::ffmpeg[x264]") in xmake.lua it doesn't work.
Describe the solution you'd like
This can be implemented by just supporting add_requires("vcpkg::ffmpeg[x264]") or by add_requires("vcpkg::ffmpeg", {features = "x264"}). Every other implementation is alright of course.
Describe alternatives you've considered
An easy workaround is to just seperatly install ffmpeg using vcpkg install ffmpeg[x264] and then just writing add_requires("vcpkg::ffmpeg") in xmake.lua. But you would have to tell people that they should build ffmpeg seperatly and this would certainly lead to errors if it is forgotten.

add_requires("vcpkg::ffmpeg[x264]") in xmake.lua it doesn't work.

Please run xmake f -c -vD and let me see the all output log.

I executed xmake f -c -vD.
xmake.lua
set_project("test")

add_requires("vcpkg::ffmpeg[x264]", {alias = "ffmpeg"})
add_requires("vcpkg::x264", {alias = "x264"})

target("test")
    set_kind("binary")

    add_packages("ffmpeg", "x264")

    if is_os("windows") then
        add_links("ole32", "Ws2_32", "Secur32", "user32", "Bcrypt")
    end

    add_files("test.cpp")

test.cpp
#include <iostream>

int main(int argc, char *argv[]) {
  std::cout << "Hello World" << std::endl;

  return 0;
}

Output
checking for the architecture ... x64
checking for the vswhere.exe ... C:\Program Files (x86)\Microsoft Visual Studio\Installer\vswhere.exe
checking for the cl.exe ... C:\Program Files (x86)\Microsoft Visual Studio\2019\BuildTools\VC\Tools\MSVC\14.27.29110\bin\HostX64\x64\cl.exe
checking for the Microsoft Visual Studio (x64) version ... 2019
checking for the dmd ... no
checking for the ldc2 ... no
checking for the gdc ... no
checking for the unzip ... ok
checking for the git ... ok
checking for the gzip ... no
checking for the 7z ... ok
checking for the ping ... ok
pinging for the host(gitlab.com) ... 4 ms
pinging for the host(github.com) ... 16 ms
pinging for the host(gitee.com) ... 216 ms
finding ffmpeg[x264] from vcpkg ..
checking for the vcpkg directory ... E:\vcpkg
checking for the vcpkg::ffmpeg[x264] ... no
finding x264 from vcpkg ..
checking for the vcpkg::x264 ... 157-303c484ec828ed0
note: try installing these packages (pass -y to skip confirm)?
in vcpkg:
  -> vcpkg::ffmpeg[x264] latest
please input: y (y/n)
y
installing ffmpeg[x264] from vcpkg ..
E:\vcpkg\vcpkg install ffmpeg[x264]:x64-windows-static
Computing installation plan...
The following packages are already installed:
    ffmpeg[avcodec,avdevice,avfilter,avformat,avresample,core,gpl,postproc,swresample,swscale,x264]:x64-windows-static
Package ffmpeg:x64-windows-static is already installed

Total elapsed time: 17.9 ms

finding ffmpeg[x264] from vcpkg ..
checking for the vcpkg::ffmpeg[x264] ... no

error: @programdir\actions\require\impl\action\install.lua:191: fetch vcpkg::ffmpeg[x264]-latest failed!
stack traceback:
    [C]: in function 'error'
    [@programdir\core\base\os.lua:792]: in function 'raiselevel'
    [@programdir\core\sandbox\modules\utils.lua:181]: in function 'assert'
    [@programdir\actions\require\impl\action\install.lua:191]:
    [C]: in function 'trycall'
    [@programdir\core\sandbox\modules\try.lua:121]: in function 'try'
    [@programdir\actions\require\impl\action\install.lua:127]: in function 'install'
    [@programdir\actions\require\impl\package.lua:619]: in function 'jobfunc'
    [@programdir\modules\private\async\runjobs.lua:185]:
    [C]: in function 'trycall'
    [@programdir\core\sandbox\modules\try.lua:121]: in function 'try'
    [@programdir\modules\private\async\runjobs.lua:182]: in function 'cotask'
    [@programdir\core\base\scheduler.lua:317]:

  => install vcpkg::ffmpeg[x264] latest .. failed
error: @programdir\modules\private\async\runjobs.lua:207: @programdir\actions\require\impl\action\install.lua:250: install failed!
stack traceback:
    [C]: in function 'error'
    [@programdir\core\base\os.lua:792]: in function 'raise'
    [@programdir\actions\require\impl\action\install.lua:250]: in function 'catch'
    [@programdir\core\sandbox\modules\try.lua:127]: in function 'try'
    [@programdir\actions\require\impl\action\install.lua:127]: in function 'install'
    [@programdir\actions\require\impl\package.lua:619]: in function 'jobfunc'
    [@programdir\modules\private\async\runjobs.lua:185]:
    [C]: in function 'trycall'
    [@programdir\core\sandbox\modules\try.lua:121]: in function 'try'
    [@programdir\modules\private\async\runjobs.lua:182]: in function 'cotask'
    [@programdir\core\base\scheduler.lua:317]:

stack traceback:
        [C]: in function 'error'
        @programdir\core\base\os.lua:792: in function 'raise'
        @programdir\modules\private\async\runjobs.lua:207: in function 'catch'
        @programdir\core\sandbox\modules\try.lua:127: in function 'try'
        @programdir\modules\private\async\runjobs.lua:182: in function 'cotask'
        @programdir\core\base\scheduler.lua:317: in function <@programdir\core\base\scheduler.lua:315>

This is because find_package("vcpkg::ffmpeg[x264]") does not support package names with [x264] strings. I will try to improve it.
https://github.com/xmake-io/xmake/blob/master/xmake/modules/package/manager/vcpkg/find_package.lua

I attempt to fix it, you can run xmake update -s dev to update the lua scripts of dev branch. and try it again.

I updated xmake with xmake update -s dev. Then I executed xmake f -p windows -a x64 -m release -c -vD. This is another computer so ffmpeg was not installed.
xmake.lua
set_project("test")

add_requires("vcpkg::ffmpeg[x264]", {alias = "ffmpeg"})
add_requires("vcpkg::x264", {alias = "x264"})

target("test")
    set_kind("binary")

    add_packages("ffmpeg", "x264")

    if is_os("windows") then
        add_links("ole32", "Ws2_32", "Secur32", "user32", "Bcrypt")
    end

    add_files("test.cpp")

test.cpp
#include <iostream>

int main(int argc, char *argv[]) {
  std::cout << "Hello World" << std::endl;

  return 0;
}

Output
checking for the vswhere.exe ... C:\Program Files (x86)\Microsoft Visual Studio\Installer\vswhere.exe
checking for the cl.exe ... C:\Program Files (x86)\Microsoft Visual Studio\2019\BuildTools\VC\Tools\MSVC\14.27.29110\bin\HostX64\x64\cl.exe
checking for the Microsoft Visual Studio (x64) version ... 2019
checking for the dmd ... no
checking for the ldc2 ... no
checking for the gdc ... no
checking for the unzip ... ok
checking for the git ... ok
checking for the gzip ... ok
checking for the tar ... ok
checking for the ping ... ok
pinging for the host(gitlab.com) ... 12 ms
pinging for the host(github.com) ... 23 ms
pinging for the host(gitee.com) ... 215 ms
finding ffmpeg[x264] from vcpkg ..
checking for the vcpkg directory ... E:\git_repositories\vcpkg
checking for the vcpkg::ffmpeg[x264] ... no
finding x264 from vcpkg ..
checking for the vcpkg::x264 ... no
note: try installing these packages (pass -y to skip confirm)?
in vcpkg:
  -> vcpkg::ffmpeg[x264] latest
  -> vcpkg::x264 latest
please input: y (y/n)
y
installing ffmpeg[x264] from vcpkg ..
E:\git_repositories\vcpkg\vcpkg install ffmpeg[x264]:x64-windows-static
Computing installation plan...
The following packages will be built and installed:
    ffmpeg[avcodec,avdevice,avfilter,avformat,avresample,core,gpl,postproc,swresample,swscale,x264]:x64-windows-static
  * x264[core]:x64-windows-static
Additional packages (*) will be modified to complete this operation.
Detecting compiler hash for triplet x64-windows-static...
Starting package 1/2: x264:x64-windows-static
Building package x264[core]:x64-windows-static...
Could not locate cached archive: C:\Users\Jonas\AppData\Local\vcpkg/archives\d8\d80d89daabc52df009875efe6bb863042b6cd151.zip
-- Downloading https://github.com/mirror/x264/archive/303c484ec828ed0d8bfe743500e70314d026c3bd.tar.gz...
-- Extracting source E:/git_repositories/vcpkg/downloads/mirror-x264-303c484ec828ed0d8bfe743500e70314d026c3bd.tar.gz
-- Applying patch uwp-cflags.patch
-- Using source at E:/git_repositories/vcpkg/buildtrees/x264/src/14d026c3bd-bca2ebf740.clean
-- Acquiring MSYS2...
-- Downloading https://sourceforge.net/projects/msys2/files/Base/x86_64/msys2-base-x86_64-20190524.tar.xz/download...
-- Downloading https://repo.msys2.org/msys/x86_64/msys2-keyring-r21.b39fb11-1-any.pkg.tar.xz...
-- Downloading https://repo.msys2.org/msys/x86_64/msys2-keyring-r21.b39fb11-1-any.pkg.tar.xz.sig...
gpg: /etc/pacman.d/gnupg/trustdb.gpg: trustdb created
gpg: no ultimately trusted keys found
gpg: starting migration from earlier GnuPG versions
gpg: porting secret keys from '/etc/pacman.d/gnupg/secring.gpg' to gpg-agent
gpg: migration succeeded
gpg: Generating pacman keyring master key...
gpg: key FCC1026910D7E0BA marked as ultimately trusted
gpg: directory '/etc/pacman.d/gnupg/openpgp-revocs.d' created
gpg: revocation certificate stored as '/etc/pacman.d/gnupg/openpgp-revocs.d/807694BD683F43481DC1EBDBFCC1026910D7E0BA.rev'
gpg: Done
==> Updating trust database...
gpg: marginals needed: 3  completes needed: 1  trust model: pgp
gpg: depth: 0  valid:   1  signed:   0  trust: 0-, 0q, 0n, 0m, 0f, 1u
==> Appending keys from msys2.gpg...
==> Locally signing trusted keys in keyring...
  -> Locally signing key D55E7A6D7CE9BA1587C0ACACF40D263ECA25678A...
  -> Locally signing key 123D4D51A1793859C2BE916BBBE514E53E0D0813...
  -> Locally signing key B91BCF3303284BF90CC043CA9F418C233E652008...
  -> Locally signing key 9DD0D4217D75A33B896159E6DA7EF2ABAEEA755C...
==> Importing owner trust values...
gpg: setting ownertrust to 4
gpg: setting ownertrust to 4
gpg: setting ownertrust to 4
gpg: inserting ownertrust of 4
==> Updating trust database...
gpg: marginals needed: 3  completes needed: 1  trust model: pgp
gpg: depth: 0  valid:   1  signed:   4  trust: 0-, 0q, 0n, 0m, 0f, 1u
gpg: depth: 1  valid:   4  signed:   3  trust: 0-, 0q, 0n, 4m, 0f, 0u
gpg: depth: 2  valid:   3  signed:   0  trust: 3-, 0q, 0n, 0m, 0f, 0u
==> Checking E:/git_repositories/vcpkg/downloads/msys2-keyring-r21.b39fb11-1-any.pkg.tar.xz.sig...
gpg: assuming signed data in 'E:/git_repositories/vcpkg/downloads/msys2-keyring-r21.b39fb11-1-any.pkg.tar.xz'
gpg: Signature made Mon Jun 29 07:36:14 2020
gpg:                using DSA key AD351C50AE085775EB59333B5F92EFC1A47D45A1
gpg: Good signature from "Alexey Pavlov (Alexpux<EMAIL_ADDRESS>[full]
loading packages...
resolving dependencies...
looking for conflicting packages...

Packages (1) msys2-keyring-r21.b39fb11-1

Total Installed Size:  0.05 MiB
Net Upgrade Size:      0.03 MiB

:: Proceed with installation?
:: Processing package changes...
upgrading msys2-keyring...
==> Appending keys from msys2.gpg...
==> Locally signing trusted keys in keyring...
  -> Locally signing key 6E8FEAFF9644F54EED90EEA0790AE56A1D3CFDDC...
  -> Locally signing key D55E7A6D7CE9BA1587C0ACACF40D263ECA25678A...
  -> Locally signing key 123D4D51A1793859C2BE916BBBE514E53E0D0813...
  -> Locally signing key B91BCF3303284BF90CC043CA9F418C233E652008...
  -> Locally signing key 9DD0D4217D75A33B896159E6DA7EF2ABAEEA755C...
  -> Locally signing key 69985C5EB351011C78DF7F6D755B8182ACD22879...
==> Importing owner trust values...
gpg: setting ownertrust to 4
gpg: setting ownertrust to 4
==> Disabling revoked keys in keyring...
  -> Disabling key B19514FB53EB3668471B296E794DCF97F93FC717...
==> Updating trust database...
gpg: marginals needed: 3  completes needed: 1  trust model: pgp
gpg: depth: 0  valid:   1  signed:   6  trust: 0-, 0q, 0n, 0m, 0f, 1u
gpg: depth: 1  valid:   6  signed:   6  trust: 0-, 0q, 0n, 6m, 0f, 0u
gpg: depth: 2  valid:   6  signed:   0  trust: 6-, 0q, 0n, 0m, 0f, 0u
gpg: next trustdb check due at 2021-06-19
:: Synchronizing package databases...
downloading mingw32.db...
downloading mingw32.db.sig...
downloading mingw64.db...
downloading mingw64.db.sig...
downloading msys.db...
downloading msys.db.sig...
resolving dependencies...
looking for conflicting packages...

Packages (3) libzstd-1.4.5-2  zstd-1.4.5-2  pacman-5.2.2-1

Total Download Size:    11.31 MiB
Total Installed Size:   34.03 MiB
Net Upgrade Size:      -12.57 MiB

:: Proceed with installation?
:: Processing package changes...
installing libzstd...
installing zstd...
upgrading pacman...
checking dependencies...

Packages (2) rebase-4.4.4-1  dash-<IP_ADDRESS>-1

Total Removed Size:  1.12 MiB

:: Do you want to remove these packages? [Y/n]
:: Processing package changes...
removing rebase...
removing dash...
:: Synchronizing package databases...
 mingw32 is up to date
 mingw64 is up to date
 msys is up to date
:: Starting core system upgrade...
warning: resolving dependencies...
terminate other MSYS2 programs before proceeding
looking for conflicting packages...

Packages (5) bash-4.4.023-2  filesystem-2020.02-7  mintty-1~3.3.0-1  msys2-runtime-3.1.6-3  pacman-mirrors-20200329-1

Total Download Size:    5.27 MiB
Total Installed Size:  24.38 MiB
Net Upgrade Size:       1.26 MiB

:: Proceed with installation?
:: Processing package changes...
upgrading msys2-runtime...
upgrading bash...
upgrading filesystem...
upgrading mintty...
upgrading pacman-mirrors...
:: To complete this update all MSYS2 processes including this terminal will be closed. Confirm to proceed [Y/n] warning: terminating MSYS2 processes failed

-- Acquiring MSYS2... OK
-- Acquiring MSYS Packages from E:/git_repositories/vcpkg/downloads/tools/msys2-20200812...
-- Acquiring MSYS Packages... OK
-- Configuring x64-windows-static-dbg
-- Configuring x64-windows-static-rel
-- Building x64-windows-static-dbg
-- Building x64-windows-static-rel
-- Installing x64-windows-static-dbg
-- Installing x64-windows-static-rel
-- Fixing pkgconfig file: E:/git_repositories/vcpkg/packages/x264_x64-windows-static/lib/pkgconfig/x264.pc
-- Fixing pkgconfig file: E:/git_repositories/vcpkg/packages/x264_x64-windows-static/debug/lib/pkgconfig/x264.pc
-- Installing: E:/git_repositories/vcpkg/packages/x264_x64-windows-static/share/x264/copyright
-- Performing post-build validation
-- Performing post-build validation done
Stored binary cache: C:\Users\Jonas\AppData\Local\vcpkg/archives\d8\d80d89daabc52df009875efe6bb863042b6cd151.zip
Building package x264[core]:x64-windows-static... done
Installing package x264[core]:x64-windows-static...
Installing package x264[core]:x64-windows-static... done
Elapsed time for package x264:x64-windows-static: 6.15 min
Starting package 2/2: ffmpeg:x64-windows-static
Building package ffmpeg[avcodec,avdevice,avfilter,avformat,avresample,core,gpl,postproc,swresample,swscale,x264]:x64-windows-static...
Could not locate cached archive: C:\Users\Jonas\AppData\Local\vcpkg/archives\33\33fc8ddf878f270316c3357298c24975a2206eef.zip
-- Downloading https://github.com/ffmpeg/ffmpeg/archive/n4.2.tar.gz...
-- Extracting source E:/git_repositories/vcpkg/downloads/ffmpeg-ffmpeg-n4.2.tar.gz
-- Applying patch 0001-create-lib-libraries.patch
-- Applying patch 0003-fix-windowsinclude.patch
-- Applying patch 0004-fix-debug-build.patch
-- Applying patch 0005-fix-libvpx-linking.patch
-- Applying patch 0006-fix-StaticFeatures.patch
-- Applying patch 0007-fix-lib-naming.patch
-- Applying patch 0008-Fix-wavpack-detection.patch
-- Applying patch 0009-Fix-fdk-detection.patch
-- Applying patch 0010-Fix-x264-detection.patch
-- Applying patch 0011-Fix-x265-detection.patch
-- Applying patch 0012-Fix-ssl-110-detection.patch
-- Using source at E:/git_repositories/vcpkg/buildtrees/ffmpeg/src/n4.2-2f6d2343f6.clean
-- Downloading https://www.tortall.net/projects/yasm/snapshots/v<IP_ADDRESS>.g1962/yasm-<IP_ADDRESS>.g1962.exe...
-- Installing: E:/git_repositories/vcpkg/downloads/tools/yasm/<IP_ADDRESS>/yasm.exe
-- Acquiring MSYS Packages from E:/git_repositories/vcpkg/downloads/tools/msys2-20200812...
-- Acquiring MSYS Packages... OK
-- Building Options: --enable-asm --enable-yasm --disable-doc --enable-debug --enable-runtime-cpudetect --enable-gpl --disable-ffmpeg --disable-ffplay --disable-ffprobe --enable-avcodec --enable-avdevice --enable-avformat --enable-avfilter --enable-postproc --enable-swresample --enable-swscale --enable-avresample --disable-avisynth --disable-bzlib --disable-iconv --disable-libfdk-aac --disable-lzma
--disable-libmp3lame --disable-cuda --disable-nvenc --disable-nvdec  --disable-cuvid --disable-opencl --disable-openssl --disable-libopus --disable-sdl2 --disable-libsnappy --disable-libsoxr --disable-libspeex --disable-libtheora --disable-libvorbis --disable-libvpx --disable-libwavpack --enable-libx264 --disable-libx265 --disable-zlib  --extra-cflags=-DHAVE_UNISTD_H=0 --pkg-config-flags=--static
-- Building Release Options:  --extra-cflags=-MT --extra-cxxflags=-MT
-- Building ffmpeg for Release
-- Building Debug Options: --debug --extra-cflags=-MTd --extra-cxxflags=-MTd
-- Building ffmpeg for Debug
-- Installing: E:/git_repositories/vcpkg/packages/ffmpeg_x64-windows-static/share/ffmpeg/copyright
-- Performing post-build validation
-- Performing post-build validation done
Stored binary cache: C:\Users\Jonas\AppData\Local\vcpkg/archives\33\33fc8ddf878f270316c3357298c24975a2206eef.zip
Building package ffmpeg[avcodec,avdevice,avfilter,avformat,avresample,core,gpl,postproc,swresample,swscale,x264]:x64-windows-static... done
Installing package ffmpeg[avcodec,avdevice,avfilter,avformat,avresample,core,gpl,postproc,swresample,swscale,x264]:x64-windows-static...
Installing package ffmpeg[avcodec,avdevice,avfilter,avformat,avresample,core,gpl,postproc,swresample,swscale,x264]:x64-windows-static... done
Elapsed time for package ffmpeg:x64-windows-static: 1.054 h

Total elapsed time: 1.157 h

finding ffmpeg[x264] from vcpkg ..
checking for the vcpkg::ffmpeg[x264] ... 4.2
{
  links = {
    "avcodec",
    "avdevice",
    "avfilter",
    "avformat",
    "avresample",
    "avutil",
    "postproc",
    "swresample",
    "swscale"
  },
  linkdirs = {
    "E:\git_repositories\vcpkg\installed\x64-windows-static\lib"
  },
  version = "4.2",
  includedirs = {
    "E:\git_repositories\vcpkg\installed\x64-windows-static\include"
  }
}

  => install vcpkg::ffmpeg[x264] latest .. ok
installing x264 from vcpkg ..
E:\git_repositories\vcpkg\vcpkg install x264:x64-windows-static
Computing installation plan...
The following packages are already installed:
    x264[core]:x64-windows-static
Package x264:x64-windows-static is already installed

Total elapsed time: 477.3 us

finding x264 from vcpkg ..
checking for the vcpkg::x264 ... 157-303c484ec828ed0
{
  links = {
    "libx264"
  },
  linkdirs = {
    "E:\git_repositories\vcpkg\installed\x64-windows-static\lib"
  },
  version = "157-303c484ec828ed0",
  includedirs = {
    "E:\git_repositories\vcpkg\installed\x64-windows-static\include"
  }
}

  => install vcpkg::x264 latest .. ok
configure
{
    arch = x64
    ccache = true
    ndk_stdcxx = true
    clean = true
{
    arch = x64
    ccache = true
    ndk_stdcxx = true
    clean = true
    host = windows
    mode = release
    plat = windows
    kind = static
    buildir = build
    vs = 2019
    vcpkg = E:\git_repositories\vcpkg
}

Now feature packages work. Good job.

ok


nimble/host: Convert gatt services array to linked list

ble_gatts_svc_entries list implementation is slightly more convenient for handling insertions and deletions of the elements in the list than an array.
List implementation of ble_gatts_svc_entries resembles the attributes list implementation at the att layer, hence easy to understand.

Hi @sjanc, can you please take a look at this?

Change included in the https://github.com/apache/mynewt-nimble/pull/1498


Connected event followed by disconnected event repeatedly

Changed version to 0.8.3 and installed on phone, repeatedly getting disconnected event. On android 7.0

Sorry for late response but it happen some time when you are using ELB (elastic load balancing )server at back end side ...
If you notice ..... when disconnected receiver call at your end you got and argument  with error reason, and it was transports error.
you need to do this when init socket in application class.
please make sure that are you using Option during init socket
IO.Options opt = new IO.Options();
opt.reconnection = true;
opt.upgrade = false;
//opt.port = 443;
/////// for the resolve of transport error you need to tell WebSocket name
opt.transports = new String[]{WebSocket.NAME};
mSocket = IO.socket(AppConstants.CHAT_SERVER_URL,opt);
I hope it will help you.


Academy view todos

[ ] Add interactive action from chapters 2 to 5 within the Basics of the blockchain module.

[x] Redo button is broken, needs be to fixed. "Have a doubt" button is non-interactive, link cryptoverse support group channel to it. (https://t.me/joinchat/FA99PXywCizUbfE7)

[ ] Compiled code is overflowing

[ ] Taquito's module code runner is broken. It's not showing the output.

[ ] Run Code, and Show Answer buttons are cut-off in module-4.

@bhaskarSingh and @manangouhari are the todos mentioned on this thread fixed?

@bhaskarSingh and @manangouhari are the todos mentioned on this thread fixed?

Apart from minor UI fixes, it's sorted.


on  off => allumé éteint => actif inactif

ON =  "sur" like in " the hat is ON the head"
OF = "de"   like in "The hat of John"
ON/OFF =>  allumé/éteint  (or actif/inactif)
actif = enabled
inactif = disabled
So it' would be allumé / éteint  but in french it's use for a real think ( a light/lamp, a television, a computer, ...) not for a feature in an application.
So I propose  the translation of  enable/disabled ==> Actif/ Inactif. Did you agree ? WDT ?

Sounds good, thanks!


deno.lang unaware of new version of third party module

I published a new tagged version v1.3.0 to Github but deno.land is unaware of the new version.
16 hours later it's not showing on deno.land:

<EMAIL_ADDRESS>ERROR: 404 - Not found:
https://github.com/srackham/drake/tree/v1.3.0/ OK
https://github.com/srackham/drake/blob/v1.3.0/mod.ts OK

The previous latest version was and still is OK:

<EMAIL_ADDRESS>OK
https://github.com/srackham/drake/tree/v1.2.6/ OK
https://github.com/srackham/drake/blob/v1.2.6/mod.ts OK

@srackham Did you add the webhook after the recent changes to the registry? See https://deno.land/posts/registry2

No I didn't. I've just set up the webhook in my repo and now I can see that one webhook delivery has been successfully made to https://api.deno.land
Thanks for answering so quickly.
I'm guessing that I now need to publish a new release to Github to trigger a release update on deno.land?

Yup, exactly

Thanks, all sorted.


hopefully fix the online counter

ok so apparently NON_PRIVILEDGED isn't a thing anymore

wait, this is still v12, not v13. so it should still work


feat: add default dynamics RelativisticBW

Addresses #118, but does not close it. Since #116, dynamics are not provided from the recipe file, so we need some default.

if we want the same default behavior as before

For me this PR is just putting the finger in the dike: a bug fix that is not meant to tackle the bigger design.

if we want the same default behavior as before

For me this PR is just putting the finger in the dike: a bug fix that is not meant to tackle the bigger design.

But like I said this version will not deliver the same results as before, since no the top node is also using a BW unless the user specifies that explicitly

Yeah but that is already the case since #116: the program just dies because when it searches for non-existing dynamics.

Ok, I was missing the info that non dynamics is still specified by the expert system on the top node by default. So the default behavior does stay the same. Not the prettiest bugfix though.

Yes, so to my understanding, the expertsystem already adds 'non-dynamic' dynamics for the top node:
https://github.com/ComPWA/expertsystem/blob/94231dea8b200097edd1a8c8be1d56a5210a0735/expertsystem/amplitude/_yaml_adapter.py#L31-L36
It's super dirty, because this happens only for YAML, but we don't really want to support XML for tensorwaves anyway.


chore: resolve obj store dep update and update hakari

This PR makes the mutable_batch_lp/fuzz crate part of the workspace, and removes its Cargo.lock file, which was holding an old version of object_store. Now, mutable_batch_lp/fuzz uses the object_store from the workspace, which is the latest version.
I also fixed and updated the workspace-hack crate using cargo-hakari. This then required some manual changes to Cargo.toml files to bring in features for some dependencies. This is a bit odd, because now, when a sync from IOx is done, those changes may get overwritten. It is likely that IOx has the features for these crates specified in some other, non-core crate, so the compiler errors are not seen there.
In addition to those changes, I removed the pprof and tikv members from the third-party section in the hakari config file.
I wonder if we even need to use the workspace-hack crate at all here, but removing it would likely make the sync process from IOx, at least in its current form, a pain.

so much code deleted 😍


Tidy up Kubernetes watcher synchronization

Cilium should no longer register or wait to sync k8s resources that are disabled such as LRP.
See commits for more details.

test-me-please

Hitting #16938.

test-1.16-netnext job hit https://github.com/cilium/cilium/issues/12511 and #14598.
ci-eks hit several failures, but only in the encryption setup.
Other CI jobs are not required.
Reopened for review since these failures seem flaky (all these tests passed in other jobs, they seem like failures we've seen before from others).

I've also triaged ci-eks failures as #16938 / https://github.com/cilium/cilium-cli/issues/367 .

Adding @jibi for review as janitor. @nebril , your review request is just for a one-liner variable -> function rename in the test directory so I think that's fine to bypass as long as we have maybe one extra sanity check from janitor.

/test


Close connection explicitly

This PR adds a method allowing users to close the connection explicitly and wait until it is closed.

Thank you.


/new nav bar with a navigation panel db connection checked twice w3-css main selction with minor local css changes/

d

sdfsdf


Correctly parse but reject certs for EC keys with implicitCurve

RFC 5480 section 2.1.1 requires that implicitCurve and specifiedCurve MUST NOT be used in PKIX.
Lacking a suitable example/test cert it is currently unclear if OpenSSL can parse ECC certs with implicitCurve.
While #12683 handles the specifiedCurve case, I suspect that rejection of both cases can be achieved simply by checking
EC_GROUP_get_curve_name(EC_KEY_get0_group(EVP_PKEY_get0_EC_KEY(pkey))) != NID_undef

This is a spin-off of the discussion in https://github.com/openssl/openssl/pull/12683#discussion_r486980401.

EC_GROUP_get_curve_name(EC_KEY_get0_group(EVP_PKEY_get0_EC_KEY(pkey))) != NID_undef

No, that would not work. The curve name is actually set accordingly when parsing a certificate whose explicit parameters happen to match one of the named curves.

Besides, how would you like to "correctly parse" the implicitCurve certs when you do not really know the parameters when parsing a single cert. Do you want to try to look up the CA cert somewhere? And if you mean something else by the "correctly parse" then please specify.

EC_GROUP_get_curve_name(EC_KEY_get0_group(EVP_PKEY_get0_EC_KEY(pkey))) != NID_undef

No, that would not work. The curve name is actually set accordingly when parsing a certificate whose explicit parameters happen to match one of the named curves.

I meanwhile found where this conversion is done, in ec_lib.c:
static EC_GROUP *ec_group_explicit_to_named(const EC_GROUP *group, OPENSSL_CTX *libctx, const char *propq, BN_CTX *ctx)
{
...
    if ((curve_name_nid = ec_curve_nid_from_params(dup, ctx)) != NID_undef) {
        /*
         * The input explicit parameters successfully matched one of the
         * built-in curves: often for built-in curves we have specialized
         * methods with better performance and hardening.
         *
         * In this case we replace the `EC_GROUP` created through explicit
         * parameters with one created from a named group.
         */

As I already wrote in https://github.com/openssl/openssl/pull/12683#discussion_r487542782,
if an explicit curve happens to match a named (predefined) curve, which means that they are semantically equal,
I'd say this does not need to be flagged as wrong because the essence of the RFC requirement is that
'custom' curves must not be used (due to security considerations).

Besides, how would you like to "correctly parse" the implicitCurve certs when you do not really know the parameters when parsing a single cert. Do you want to try to look up the CA cert somewhere? And if you mean something else by the "correctly parse" then please specify.

@t8m, look what I've just digged out - the ancient function X509_get_pubkey_parameters() in x509_vfy.c
available from the very beginning of OpenSSL:
commit 58964a492275ca9a59a0cd9c8155cb2491b4b909
Author: Ralf S. Engelschall<EMAIL_ADDRESS>Date:   Mon Dec 21 10:56:39 1998 +0000

    Import of old SSLeay release: SSLeay 0.9.0b

which is undocumented but apparently fills in implicit public key parameters!

And if you mean something else by the "correctly parse" then please specify.

Well, I was uncertain on this, but meanwhile I found another interesting piece of code in x_pubkey.c that essentially answers this:
EVP_PKEY *X509_PUBKEY_get0(const X509_PUBKEY *key)
{
..
    if (key->pkey != NULL)
        return key->pkey;

    /*
     * When the key ASN.1 is initially parsed an attempt is made to
     * decode the public key and cache the EVP_PKEY structure. If this
     * operation fails the cached value will be NULL. Parsing continues
     * to allow parsing of unknown key types or unsupported forms.
     * We repeat the decode operation so the appropriate errors are left
     * in the queue.
     */

And in fact I was able to produce a test cert file with an implicitCurve:
123  11:       SEQUENCE {
125   7:         OBJECT IDENTIFIER ecPublicKey (1 2 840 10045 2 1)
134   0:         NULL
       :         }

and it does get parsed with the following entries in the error queue being ignored deliberately:
openssl x509 -noout -text -in test/certs/p384-server-cert-implicitCurve.pem
Certificate:
    Data:
        Version: 3 (0x2)
        Serial Number: 2 (0x2)
        Signature Algorithm: ecdsa-with-SHA256
        Issuer: CN = ECDSA P-384 root
        Validity
            Not Before: Feb 18 18:49:54 2017 GMT
            Not After : Feb 19 18:49:54 2117 GMT
        Subject: CN = P-384 Server Cert
        Subject Public Key Info:
            Public Key Algorithm: id-ecPublicKey
            Unable to load Public Key
140582513763456:error:100DC08E:elliptic curve routines:eckey_type2param:decode error:../crypto/ec/ec_ameth.c:124:
140582513763456:error:100D7010:elliptic curve routines:eckey_pub_decode:EC lib:../crypto/ec/ec_ameth.c:151:
140582513763456:error:0B09407D:x509 certificate routines:x509_pubkey_decode:public key decode error:../crypto/x509/x_pubkey.c:125:
        X509v3 extensions:
            X509v3 Subject Key Identifier:
                98:F9:F7:EA:00:A7:81:A6:24:25:E1:BE:A1:8D:43:97:B8:16:C8:96
            X509v3 Authority Key Identifier:
                keyid:26:D0:8F:1D:7B:5F:DC:1E:7F:41:80:7D:63:CA:1C:75:81:D6:85:69

            X509v3 Basic Constraints:
                CA:FALSE
            X509v3 Extended Key Usage:
                TLS Web Server Authentication
            X509v3 Subject Alternative Name:
                DNS:P-384 Server Cert
    Signature Algorithm: ecdsa-with-SHA256
         30:65:02:31:00:c3:d6:ec:e6:0c:cc:40:9a:4c:a8:90:89:b3:
         5f:88:56:e9:fd:87:c6:df:e2:64:98:53:e8:2d:79:cc:28:d8:
         7e:85:9c:05:d3:ff:12:21:79:9b:61:4c:3d:4b:f1:ab:ed:02:
         30:09:8a:3a:77:5c:7c:ec:10:ec:ea:1a:11:4c:92:c7:6a:b5:
         d2:25:e0:ae:41:38:d8:7b:13:bc:51:11:f0:55:0d:ee:b7:a9:
         39:49:c3:26:10:bd:50:a2:56:ec:8e:40:f7

As I already wrote in #12683 (comment),
if an explicit curve happens to match a named (predefined) curve, which means that they are semantically equal,
I'd say this does not need to be flagged as wrong because the essence of the RFC requirement is that
'custom' curves must not be used (due to security considerations).

I disagree with that. I do not see anything like that could be inferred from the RFC wording. There is simply:  -- implicitCurve and specifiedCurve MUST NOT be used in PKIX. I do not see how you could interpret it in the above way.

OK, so a cert with implicitCurve is parsed correctly, but errors are left on the error stack. But the certificate won't be usable with the current chain verification code anyway.

OK, so a cert with implicitCurve is parsed correctly, but errors are left on the error stack.

Right, but the errors were misleading too bulky. This is fixed by #13003.

But the certificate won't be usable with the current chain verification code anyway.

This is also fixed by #13003, using a new -inherit_pkparam option etc.

I do not see anything like that could be inferred from the RFC wording. There is simply: -- implicitCurve and specifiedCurve MUST NOT be used in PKIX. I do not see how you could interpret it in the above way.

I agree with @t8m -- the meaning of the text is clear, even if it is arguably overzealous in terms of what is needed to provide the security benefits.

Marking as inactive, to be closed at the end of 3.4 dev, barring further input


tippecanoe gets stuck while generating certain types of files

While the tile generation part is smooth in most cases while generating tiles tippecanoe get stuck in tile generation state while generating tile in some cases. It does not throw an error in that case even after hours. File size is very low 1.5MB tippecanoe --minimum-zoom=1 --read-parallel --buffer=127 --simplification=1 --layer=layer_id_name --no-feature-limit --no-tiny-polygon-reduction --preserve-input-order --no-line-simplification --extend-zooms-if-still-dropping --force --drop-rate=0 --maximum-tile-bytes=500000 --coalesce-densest-as-needed --output-to-directory=/outputfolder /usr/src/app/local/AfghanistanRoads_UTM42N.geojson 1409 features, 157464 bytes of geometry, 18455 bytes of separate metadata, 555 bytes of string pool
If there is an error while processing certain files tippecanoe should ideally throw an error . I am attaching my geojson file in zip format since github doesnot allow geojson format file
AfghanistanRoads_UTM42N.zip

Perhaps this is a bug that has since been fixed in https://github.com/felt/tippecanoe? For me it completes in less than 6 seconds:
➤ ./tippecanoe --version
tippecanoe v2.26.1
➤ time ./tippecanoe --minimum-zoom=1 --read-parallel --buffer=127 --simplification=1 --layer=layer_id_name --no-feature-limit --no-tiny-polygon-reduction --preserve-input-order --no-line-simplification --extend-zooms-if-still-dropping --force --drop-rate=0 --maximum-tile-bytes=500000 --coalesce-densest-as-needed --output-to-directory=outputfolder ../Downloads/AfghanistanRoads_UTM42N.geojson
../Downloads/AfghanistanRoads_UTM42N.geojson:188: Reached EOF without all containers being closed: in JSON object {"type":"FeatureCollection","name":"AfghanistanRoads_UTM42N","crs":{"type":"name","properties":{"name":"urn:ogc:def:crs:EPSG::32642"}},"features":[]}
../Downloads/AfghanistanRoads_UTM42N.geojson:250: Found ] at top level:
1409 features, 176394 bytes of geometry, 1095 bytes of string pool
  99.9%  14/11305/6659

real	0m5.723s
user	0m7.258s
sys	0m4.605s

This tile generation can take time due to less I/O PS of the file system


JDBC Url need support urls with underscores (RFC3986)...

Generaly when you use docker-compose the hosts are formed with underscore between component... like <docker-compose directory name>_<app name>_<instance number>...
This url are rejected by clickhouse-jdbc, with error "host is missed or wrong" or "port is missed or wrong" depend on clickhouse-jdbc version... or not get the good port (respond the default port by default = 8123)...
The problem seem to come from a bug/strictness in java.net.URI from jdk used by clickhouse-jdbc...
java.net.URI are used in https://github.com/ClickHouse/clickhouse-jdbc/blob/master/clickhouse-jdbc/src/main/java/ru/yandex/clickhouse/ClickhouseJdbcUrlParser.java#L42 to decode jdbc url...
Is related to bugs in jdk : https://bugs.openjdk.org/browse/JDK-8221675 and https://bugs.openjdk.org/browse/JDK-8019345 and https://stackoverflow.com/questions/22203111/is-javas-uri-resolve-incompatible-with-rfc-3986-when-the-relative-uri-contains.
In fact java.net.URI are based on old dns name RFC2396 that not authorize underscore... them this RFC had been updated in RFC3986 that authorize underscore...
Also spring had the same pb... https://github.com/spring-projects/spring-framework/issues/24439, and had create alternate class that resolve the pb...
The prefered solution while be to fix in java.net.URI... but the bug are old, maybe may corrected in jdk18+... but i think that can continue to wait for long time...
https://bugs.openjdk.org/browse/JDK-8291591 and https://cr.openjdk.java.net/~dfuchs/writeups/updating-uri/
The other solution are to use alternative URI parse in clickhouse jdbc driver like in spring... with org.springframework.web.util.UriComponentsBuilder...
https://docs.spring.io/spring-framework/docs/current/javadoc-api/org/springframework/web/util/UriComponentsBuilder.html

Thanks for the report @mcarbonneaux. URI should not be mandatory except for the optional HttpClient implementation. URL on the other hand is less strict and it works for the case. I'll add a custom class(with toJavaUri() method to create a patched URI for HttpClient or such) and a loose parser to replace URI.
Meanwhile, if you're using docker-compose, can you use service name(app name in your example) instead? Since service name may contain underscore as well, depending on your scenario, perhaps a custom DNS like consul or gateway like traefik can be of use?

Is not the only the underscore the problem, if you see the rfc matrix https://cr.openjdk.java.net/~dfuchs/writeups/updating-uri/...
For my docker compose the default search domain are not the domain of the network... And the network also had underscore too....


Carthage install hang

version: 3.0.0
carthage version: 0.33.0

Yes. It takes horrible long time :/

Maybe  carthage bug

same on 4.0.0 / carthage 0.33.0
did anyone find a workaround / fix ?

fixed


HandTool mode of Viewer inside iFrame Does not work correctly

I tried to load pdf.js inside an iFrame and there is an issue when enabling hand tool mode.
When I drag it and the mouseup ends up outside the iFrame, and when i move the mouse cursor back inside the iFrame, it ends up being in dragged mode.
Is there a way to programmatically set the hand tool drag event as finished when the mouse cursor ends up outside the iFrame.

Thanks for the report, I created a new ticket at https://github.com/Rob--W/grab-to-pan.js/issues/4


Fixing memory management issue

This PR fixes https://github.com/microsoft/qsharp-compiler/issues/1089.
See the code comments and the issue above for more detail.
To properly validate the change, I set up execution tests for QIR bitcode. These test work via JIT compilation and should not require llvm or clang to be installed on the system. They did require me to create and use a runtime package with the necessary extern C exposed.

Disclaimer: I do not feel that I am the best person to review this PR as it assumes deep knowledge on how Q# handles variables and values with respect to reference and alias counting.
With that in mind, overall it looks OK to me. As it seems that there are tests written which could be part of this PR, I think it would be great to include those. Another thing I personally really like, would be two diagrams that maps out all the different paths through which a variable a may increase or decrease its reference count. I will leave it up to you whether you wish to include that.
Approved, with a recommendation of getting a second pair of eyes to look at it.

Yes, as far as the tests are concerned, that was the plan and I've added execution tests for them. I believe in this case the most reliable way to test them is to check the execution rather than checking the abstraction/compiled code (also, that is much more feasible to maintain for the large set of tests that is required). I just needed to first set it up.
As far as the diagram is concerned, I will defer the challenge of drawing a diagram in this case. Rather than with a diagram, I would in this case rather keep a description of the logic and also that requires quite a bit of explanation. The good news is that all of that logic is contained in the scope manager, and looking at the code there in detail should give sufficient information to follow the logic.


feat: add support for check runs

Thanks for opening this PR! I should have time over the next couple days to take a look and add some comments 😃 - excited to add support for querying GitHub actions

Codecov Report

Merging #174 (28e8a40) into main (8adfe39) will decrease coverage by 3.64%.
The diff coverage is 0.88%.

@@            Coverage Diff             @@
##             main     #174      +/-   ##
==========================================
- Coverage   67.95%   64.31%   -3.65%
==========================================
  Files          41       42       +1
  Lines        1969     2082     +113
==========================================
+ Hits         1338     1339       +1
- Misses        409      520     +111
- Partials      222      223       +1

Impacted Files
Coverage Δ

extensions/internal/github/check_suite.go
0.00% <0.00%> (ø)

extensions/internal/github/github.go
69.44% <100.00%> (+0.87%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8adfe39...28e8a40. Read the comment docs.


Proposal: typed tachyons

I have an idea for Typescript/Flowtype support in Tachyons and I'm wondering what you think about it, is it worth implementing or there's another solution.
One of the biggest issues of using Tachyons in React apps (or other kinds of apps, it's not React-specific, of course) for me is that once you choose to use this framework it's hard to opt out without breaking your layouts. Using typed definitions could help that (obviously, it would also help with other benefits of typed language like autocompletion)
The definition could look like this (in Typescript):
enum Tachyons {
    aspectRatio = 'aspect-ratio',
    aspectRatio16x9 = 'aspect-ratio--16x9',
	...
};

// maybe a classname builder object for convenience

type TachyonsBuilder = {
  [k in Fields]: TachyonsBuilder;
} & {
  toString: () => string;
};

let tb: TachyonsBuilder;

// ...

<div className={`${Tachyons.cover} ${Tachyons.br2}`} />

// or

// or maybe with a getter that returns a string

Does it make sense for you?

I don't use typescript or flow so not looking to maintain any code around it. Any reason this wouldn't be the best place to keep typescript defs? https://github.com/DefinitelyTyped/DefinitelyTyped

@alexkuz I use this approach with Tachyons / Tailwind / (whatever atomic CSS framework) via CSS modules and VSCode code autocomplete.
import c from 'style.css'
import cx from 'classnames'

export const C1 = () =>

import nanostyled from 'nanostyled'

const C2 = nanostyled('div', {
    font: cx(c.serif,c.f1),
    base: cx(c.red,c.flex)
})


chore: start a local server for testing when run dev #17868

Brief Information
This pull request is in the type of:

[ ] bug fixing
[ ] new feature
[x] others

What does this PR do?

Start a local server when run npm run dev and update the README. Hopefully, this can better help new contributors to get started.
Fixed issues
#17868
Details
Before: What was the problem?

After: How does it behave after the fixing?

Document Info
One of the following should be checked.

[x] This PR doesn't relate to document changes
[ ] The document should be updated later
[ ] The document changes have been made in apache/echarts-doc#xxx

Misc
ZRender Changes

[ ] This PR depends on ZRender changes (ecomfe/zrender#xxx).

Related test cases or examples to use the new APIs
N.A.
Others
Merging options

[ ] Please squash the commits into a single one when merging.

Other information

The former command may block the latter command.

It doesn't seem to be blocked to me.  In my environment, Bundled with esbuild is printed after the command and it prints again on file changes in src.
npx concurrently gives extra prompt for developers to confirm so I think if it works without concurrently, it would be better:
Need to install the following packages:
<EMAIL_ADDRESS>Ok to proceed? (y)

And there are other problems with your suggestion:
[0] /bin/sh: -c: line 0: unexpected EOF while looking for matching `"'
[0] /bin/sh: -c: line 1: syntax error: unexpected end of file
[1] /bin/sh: run: command not found
[0] "npm exited with code 2
[2] /bin/sh: -c: line 0: unexpected EOF while looking for matching `"'
[2] /bin/sh: -c: line 1: syntax error: unexpected end of file
[1] run exited with code 127
[2] dev:fast" exited with code 2
[3] /bin/sh: -c: line 0: unexpected EOF while looking for matching `"'
[3] /bin/sh: -c: line 1: syntax error: unexpected end of file
[3] "npx exited with code 2

I'm using Bash on Mac terminal.

It seems Windows and Mac shell have some differences. @plainheart 's suggestions works well in scripts in package.json so I used this command. Thanks!

npx concurrently gives extra prompt for developers to confirm so I think if it works without concurrently, it would be better:

Thanks for accepting the suggestion! Maybe we can pass -y to npx to avoid the installation tip.

Thanks @Ovilia
That's why echarts' better than other Chinese open source softwares.


Enhance Readme

Is your feature request related to a problem? Please describe.
Enhancing Readme to improve overall documentation
Describe the solution you'd like
adding clear and concise description of various features of testcontainers.net and various other information to make readme useful for first time usage of project.
Describe alternatives you've considered
NA
Additional context
Additonally, there are enhancements will be added for contributing.md and overall documentation of project.
#docs

Please assign to myself.


fix: error with empty records

Description
A problem with the histogram terminating in error when an empty Records is inputted has been resolved.
After the resolve, an empty histogram is displayed.

Related links
Jira: https://tier4.atlassian.net/browse/RT2-1202

Notes for reviewers

Pre-review checklist for the PR author

[x] I've confirmed the contribution guidelines.
[x] The PR is ready for review.

In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.

[x] The PR has been properly tested.
[ ] The PR has been reviewed.

Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.

[x] (Optional) The PR has been properly tested with CARET_report verification.
[ ] There are no open discussions or they are tracked via tickets.
[x] The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@taro-yu
Please review.

@taro-yu or @emori-ctc
Please review.


[WIP] DataMap Access Path Optimization

Optimization for DataMap AccessPath decision and execution based on coverage and stats.

SDV Build Fail , Please check CI http://<IP_ADDRESS>:8080/job/ApacheSDVTests/1294/

Build Failed  with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/657/

Build Failed  with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/668/

SDV Build Fail , Please check CI http://<IP_ADDRESS>:8080/job/ApacheSDVTests/1305/

Build Failed  with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/1412/

Build Failed with Spark 2.2.1, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder/3062/

Build Failed  with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/4306/

Build Failed  with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/5194/

Build Failed with Spark 2.2.1, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder/3984/

Build Failed  with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/7132/

Build Failed with Spark 2.2.1, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder/5908/

Build Failed  with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder2.1/59/

Build Failed  with Spark 2.3.1, Please check CI http://<IP_ADDRESS>:8080/job/carbondataprbuilder2.3/8808/

Build Failed with Spark 2.2.1, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/741/

Build Failed  with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder2.1/563/

Build Failed  with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder2.1/2011/

Build Failed with Spark 2.2.1, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/2188/

Build Failed  with Spark 2.3.2, Please check CI http://<IP_ADDRESS>:8080/job/carbondataprbuilder2.3/10263/

Build Failed  with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbonPRBuilder2.1/86/

Build Failed  with Spark 2.3.2, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbonPRBuilder2.3/85/

Build Failed  with Spark 2.4.4, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbon_PR_Builder_2.4.4/83/

Build Failed  with Spark 2.4.5, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbon_PR_Builder_2.4.5/2020/


[Bug][Grafana] PR Cycle TIme doesn't Respect Time Interval

Search before asking

[X] I had searched in the issues and found no similar issues.

What happened
Working:

Not Working:

What do you expect to happen
I expect that when the time interval option in the board changes that the PR Cycle Time graph respects that change.
How to reproduce

Go to https://devlake.apache.org/livedemo/EngineeringLeads/EngineeringThroughputAndCycleTime
Change Time Interval to 'Week'
The Pr Cycle Time doesn't respect the change

Anything else
Problem is here: https://github.com/apache/incubator-devlake/blob/main/grafana/dashboards/EngineeringThroughputAndCycleTime.json#L1161
Specifically, in the main select statement, the first column definition (and the subsequent group by) should have INTERVAL -$interval(date(pr_issued_date))+1 DAY as the second function parameter in the DATE_ADD function call.
WITH _prs AS (
  SELECT pr.id
    , pr.created_date AS pr_issued_date
    -- convert null to 0 if a PR has no cycle_time to make sure cycle_time equals the sum of the four metrics below
    , COALESCE(prm.pr_cycle_time/60,0) AS cycle_time
FROM pull_requests pr
LEFT JOIN project_pr_metrics prm ON pr.id = prm.id
INNER JOIN project_mapping pm ON pr.base_repo_id = pm.row_id AND pm.table = 'repos'
WHERE $__timeFilter(pr.created_date)
AND pr.created_date >= DATE_ADD(DATE_ADD($__timeFrom(), INTERVAL -DAY($__timeFrom())+1 DAY), INTERVAL +1 MONTH)
AND pm.project_name in (${project:sqlstring}+'')
GROUP BY pr.id
  , pr.created_date
  , COALESCE(prm.pr_cycle_time/60,0)
)

SELECT
  DATE_ADD(date(pr_issued_date), INTERVAL -DAYOFMONTH(date(pr_issued_date))+1 DAY) AS time
  , AVG(cycle_time) AS 'PR Cycle Time(h)'
FROM _prs
GROUP BY DATE_ADD(date(pr_issued_date), INTERVAL -DAYOFMONTH(date(pr_issued_date))+1 DAY)
ORDER BY time

Version
Latest: v0.19.0
Are you willing to submit PR?

[ ] Yes I am willing to submit a PR!

Code of Conduct

[X] I agree to follow this project's Code of Conduct

@ldmoose Thanks a lot, we will fix it in v0.21.0-beta3.


Fix dubious pthread_cond_signal not in lock

Based on #2615

Codecov Report

Merging #2619 into master will not change coverage.
The diff coverage is 100%.

OK, looks good.  Merging.


add Prettier check to the CircleCI lint job

This PR adds the Prettier check of latest docs (next) and blog posts to the CircleCI lint job. This should be run with every PR to help contributors follow the style guidelines and formatting. I decided to skip the versioned docs just to spare some time (changes there are not that often and whole check takes ~15-20x CPU time on my machine).

Thanks for looking into that!
As a bit of context, we didn't include it into the lint job as most people were editing the docs directly from GitHub, and most of those pull requests were blocked or would have been blocked by this check. For people that cloned the repo and installed dependencies, we have a husky pre-commit hook to run prettier.
So, what we were doing was to run prettier manually before cutting a new release or sometimes.
If we're okay that some PRs (a lot) may need a manual prettier fix from us (maintainers), I'm okay with that! But I think it may be more convivial to run it ourselves instead of forcing the contributors to do so. 😬
Could we setup a cronjob to automatically fix prettier on master? Or rely on a GitHub action that will automatically apply prettier on pull requests? 🤔

As a bit of context, we didn't include it into the lint job as most people were editing the docs directly from GitHub, and most of those pull requests were blocked or would have been blocked by this check. For people that cloned the repo and installed dependencies, we have a husky pre-commit hook to run prettier.

As you can see this PR has this check turned on and there an no Prettier issues at all (https://app.circleci.com/pipelines/github/facebook/react-native-website/2476/workflows/9851ba08-8bb1-45bb-96e9-6ca8c26ef52d/jobs/12826). It would be ideal to maintain the code quality like that and this job should help with that.

Running git hooks on push can be easily disable when working and committing from the local copy (you can't assume that those files were checked).

So, what we were doing was to run prettier manually before cutting a new release or sometimes.

IMO This is not a good practice or approach.

If we're okay that some PRs (a lot) may need a manual prettier fix from us (maintainers), I'm okay with that! But I think it may be more convivial to run it ourselves instead of forcing the contributors to do so. 😬

GitHub allows an PR author to edit files included in the PR from the web.
Maintainer to fix this properly need to add remote, checkout the PR branch and push changes there, which is very annoying and slows down the review and accept process a lot.
When there are style guides and code formatting rules defined many repositories enforce those standards and it's usual to  expect these policies to be followed  by the contributors when editing the code.

Could we setup a cronjob to automatically fix prettier on master? Or rely on a GitHub action that will automatically apply prettier on pull requests? 🤔

Prettier can introduce some necessary or breaking changes (https://github.com/facebook/react-native-website/pull/1900#discussion_r419774676), so IMO the changes should not be applied automatically.

Sorry for the intent here, @simek.
I don't want to say that this is not a good idea, actually, I think your pull request is the best scenario of all. Having no Prettier issues is great, and having a CI check to ensure it should be mandatory, but.
I agree that git hooks can be easily disabled. In fact, they're rarely enabled as people who are cloning the repo aren't installing dependencies, they're just editing files and committing them.
There are 3 ways to contribute to react-native-website:

Edit the file directly from GitHub or follow the Edit button from the website.
Clone the repository locally, edit files, commit them, and wait on the deploy preview to view your changes.
Clone the repository locally, install dependencies, run Docusaurus locally, edit files, view your changes locally, and commit them.

Usual contributors are probably all using the latest option, but first-time contributors and people submitting PRs on the fly probably don't have their setup done.
Yes, the recommended way of contributing is by forking the repository, but it could be done on the web and directly by following the "Edit" button from the docs.

Maintainer to fix this properly (before accepting and merge) need to add remote, checkout the PR branch and push changes there, which is very annoying and slows down the review and accept process a lot.

That's why we were exhausted from dealing with that, so we handled it ourselves instead of expecting it from contributors.
Contributors—except top contributors—are not going to look for the style compliance, they want to submit a quick fix for an issue they came through will reading the docs. Most of them will never go back to it to address the reviewer's comments, and collaborators are mostly applying those suggestions to get the pull request merged.

Prettier can introduce some necessary or breaking changes (#1900 (comment)), so IMO the changes should not be applied automatically.

Sure, but those are rare cases, and the pre-commit hook could apply them automatically anyway.

TL;DR What I want to bring here is that enforcing Prettier on pull requests could/will add a lot more stale pull requests that maintainers will fix by hand anyway, and that's annoying.

I see both perspectives here, and I have to say that @charpeni's has the Spirit of React Native.
In an ideal world, I'd love if we could automate Prettier for people from all three use cases and only intervene if there are breaking changes. Otherwise, we risk alienating eager contributors with pedantry ("Hey, you can't contribute here unless you commit to running this thing on your computer first! Take 30 minutes out of your life to fix this typo or go home!")
Ideas on how that workflow could work?


Add concurrency variable from client settings

Allows sensu clients to set maximum number of concurrent event machine workers.
Needs this pull request from sensu/sensu to be applied as well: https://github.com/sensu/sensu/pull/1186
Resolves this issue: https://github.com/sensu/sensu/issues/1184

@mnguyen1289 thanks for the pr :+1: similar functionality has been added https://github.com/sensu/sensu-spawn/blob/master/CHANGELOG.md#200---2016-05-16 Sensu 0.24, which will be available sometime next week includes it :-)


aggregate template instantiations

Just looked at Instance Function and there were many individual entries of the form class<T>::method<U>.
It would be nice to have the option to aggregate them by method, by class or both (displayed like class<...>::method<...>).

Sounds good! That's a really good idea.
It think this might need to be an option for the data extractor itself, as I can't properly merge on the extension the accumulated times when dealing with nested initializations and such. As you don't want a child instantiation to count double time. Also collapsing template arguments on the class level will mean that nested structures will all have its template arguments collapsed.
This should be a simple string replace when reading the symbols.

I also saw that ClangBuildAnalyzer does something similar, using <$> notation.

And WPA: https://devblogs.microsoft.com/cppblog/profiling-template-metaprograms-with-cpp-build-insights/
Thinking about it, maybe CompileScore could offer to open the .etl file that probably gets generated anyway in WPA for advanced analysis.
Then I could save that manual step:
vcperf -start -level3 MyVCSession
vcperf -stop -templates MyVCSession build.etl
wpa build.etl

I am not sure I follow the question here. Are we talking about the CompileScore App or Visual Studio Extension?
You can perform the same .etl generation that vcperf does using the ScoreDataExtractor. This way you can build the project once, extract the .etl/.ctl and then extract different .scor ( aggregation of data ) with different parameters and sizes.
When performing the stop and generating the scor directly, the .etl generation is skipped as it is not needed and we can instead parse the events directly and faster.
tldr: the ScoreDataExtractor can generate:

build -> scor
build -> etl/ctl
etl/ctl -> scor

Technically if we want to allow the App to process .etl directly, we can just make the App perform :
ScoreDataExtractor.exe -extract -msvc -i Provided.etl -o TempScore.scor. And load that temporary file.
Tbh, the more flexible the input format is the better, it could even be a folder with the .json files that clang produces too.
Is this what you meant?

The Visual Studio extension.
I thought there would be a temporary .etl anyway that can be offered to open in WPA.

I understand, Adding an option in the extension options to also generate the etl when recording the events should pretty simple to add.
If I may ask, for what features do you need to use WPA?

Well it was inspired by this topic, aggregating template instantiations.
But of course in general WPA allows advanced usage like defining your own columns and grouping by select columns.
They have an interesting article series about what you can do:
https://learn.microsoft.com/en-us/cpp/build-insights/get-started-with-cpp-build-insights
Includes a feature to estimate wall clock time impact in addition to just simply adding up the times.
And it's really useful to see average, min and max too (though I'd prefer median and deviation):
https://github.com/Neargye/magic_enum/issues/239#issuecomment-1419206424

Closing this issue as the template arguments can now be collapsed on version 1.8.1 (enabled by default).

Thanks!
Should we create a separate ticket for

Adding an option in the extension options to also generate the etl when recording the events should pretty simple to add.

Yes please.


question - load term from db

hi, fist thanks for great work.
Im just curious if there is a way to load i18 translations dynamicaly via fetch call from backend? any idea or example would be helpfull.

vue-i18n-loader don't support dynamicaly loading.
close.


Sort class members

#595
Suggested commit message
Introduce `MemberOrder` check (#636)

Notes
Most of the implementation's 'plot holes' are addressed through comments, here's a concise summary:
Implementation

[ ] IIRC we don't use explanation in @BugChecker, but I though we should include the preferred order of members in some description of this checker and it seemed too detailed for the summary.

Tests

[ ] I couldn't manage to verify that whitespace is not modified when a suggestion is applied. I'm not sure if this something that we want to verify. -> more detailed comment

What do you think?

Verifying that the whitespace is untouched may be a bit harder than I thought because TestMode.TEXT_MATCH formats both input and output

ErrorProneTokens#getTokens(String, Context) doesn't include comments as it relies on the start position of the provided member (e.g., the position of void). Comments don't count as tokens but do affect token positions.
To include comments, we can use VisitorState#getOffsetTokens(int, int) to obtain tokens in a specific range. By starting the range at the end position of the previous token and ending it at the end of the current member, we'll obtain the same tokens, now including comments in the resulting ErrorProneToken.

Thanks oxkitsune for the ErrorProneTokens#getTokens(String, Context)!

Looks good!
However blocks (both static and instance) are also considered class members:
class Foo {
	private static final int bar;
	private final int baz;

	// some static initializer block
	static {

		bar = 110 ^ 67;
	}

	// some instance initializer block
	{
		baz = (1395 ^ 1059) >> 3;
	}
}

Currently these are not sorted, I'm unsure what their order should be though.
Something like this perhaps?

static fields
static blocks
non-static fields
non-static blocks

WDYT :smile:

However blocks (both static and instance) are also considered class members: ...

Good point, they're indeed non-handled. My reasoning to ignore this case was that using static blocks are very rare and specific. It would be hard to put these very specific edge cases into a rule, if even possible. Seems more practical to not sort them in this rule (or at all).
Afaik the general opinion on static blocks is that we should just not use them. Considering this, (imo) if we want to do anything with static blocks in error-prone, we should just flag them as errors.

Hehe, I'll check it out soon (this week 🤞) and will update it with the open questions!

Seems PiTest in CI consistently fails in ~1m w/
Failed to execute goal org.pitest:pitest-maven:1.15.3:mutationCoverage (default-cli) on project error-prone-contrib: Execution default-cli of goal org.pitest:pitest-maven:1.15.3:mutationCoverage failed: Coverage generation minion exited abnormally! (UNKNOWN_ERROR)

Didn't deep-dive in its logs nor tried executing it locally yet, just flagging!

Seems PiTest in CI consistently fails in ~1m w/
Failed to execute goal org.pitest:pitest-maven:1.15.3:mutationCoverage (default-cli) on project error-prone-contrib: Execution default-cli of goal org.pitest:pitest-maven:1.15.3:mutationCoverage failed: Coverage generation minion exited abnormally! (UNKNOWN_ERROR)

Didn't deep-dive in its logs nor tried executing it locally yet, just flagging!

If you rebase this should be fixed, thanks to #976 :)
W.r.t. other questions: I'll have to get back to you, hopefully later this week. Tnx for reviving this PR!

Hey @benhalasi! I figured out why I hadn't pushed that October review until recently. I found a local branch with unpushed changes; apparently I just abandoned the review midway. I suspect that by now you've applied the relevant feedback, but just to be sure I pushed a commit with my local changes: 997099e957ecc2281b75b652d45fa8a3a0b9aaa1; perhaps there's something useful in it still (didn't check).
Will circle back to this PR later!

Small progress update: I rewrote most of the checker's logic, (much inspired by https://github.com/PicnicSupermarket/error-prone-support/commit/997099e957ecc2281b75b652d45fa8a3a0b9aaa1).
The main changes:

track unmovable members too so we can track source-code between members - including unmovable ones too.
accommodate enums. I left XXX: To accommodate enums comments at their support's main pillars, and it's not even that horrifying!
combine BY_PREFERRED_TYPE_MEMBER_ORDER Comparator with the logic that determines which members are movable.
split the tests between classes, interfaces, and enums.

I'm yet to sleep one on it and have a final round of changes mark parts where I have minor questions, but ofc any input is appreciated!

/integration-test

/integration-test

/integration-test

/integration-test

/integration-test

It's not working as this check is in the experimental module 😬. So we will need to tweak something, or to run it locally 😄 @benhalasi.


Run local built container on swarm

I know this is probably something hard to do, but will (or is it right now?) be possible to run a docker image built on the host machine to be ran on a swarm machine? I just figure this out when I tried to run the simplest demo from compose and swarm, where one of the containers is built on my machine.

You can either:

Push the container somewhere, then you'll be able to run it, or
docker build on Swarm (instead of the local machine) then docker run using image affinities (no need of image affinities once we address #743)

@aluzzardi Where does swarm stores the image made by docker build? I mean, is it possible the built result would end up on a node and docker run will be addressed to a different node?

@aanm Yes, very likely. docker build uses the same scheduling as docker run, so it will end up on a machine depending of your filters and strategy. docker run will likely try to run on a different node.
Right now, you can solve this by using image affinities:
docker build -t foo .
docker run -e affinity:image==foo foo

The former will build an image on the cluster while the latter will schedule a run and force it to be on a machine that has the foo image.
#743 will do that for you automatically

Thanks, that helped me.

@aanm The affinity is not required anymore in master (and on the upcoming 0.4.0) thanks to a PR by @jimmyxian

@aluzzardi Thanks for the heads up! Can you tell me the PR number?

Proposal is #743 and implementation #971


Initial commit for High-poly refrain

Just upload whole project and fill about.md

:trollface::cn:


changing loggers in worker runner to log waiting for master

Adding logger for the worker when waiting for the master to connect and also when the maximum of retries were exeeded
cc: @cyberw

Nah, too spammy for info logging, especially if you run lots of workers and aggregate the logs (like with locust-swarm) Use -L debug if you need to know.


[CAMEL-16504] YAML Dsl : support for "flow" like route definition

see:

https://issues.apache.org/jira/browse/CAMEL-16504
https://issues.apache.org/jira/browse/CAMEL-16510

@davsclaus should be ready now, mind doing another review ?


Change the regex expression:  remove only the mask characters '.', '-', '/'.

This pull request fixes the bug on issue # 11. Please check it up.

Este PR fecha a issue #11

@felquis thank you for reviewing it 💟 I didn't know that was possible tho

Changes available on npm via<EMAIL_ADDRESS>

@cyberglot https://github.com/cyberglot/bradoc/pull/14#issuecomment-287700294 neither I :smile:


Helm chart?

Title

Summary
I would like to install via a helm chart. I see there is an old keycloak-proxy chart. Is there any plan to upgrade/replace this?

Why?

Helm is a standard way to deploy to kubernetes.
How

I see you recently added a Dockerfile, and some manifests. Are these going to be packaged into a chart? Any visibility as to when?
Acceptance criteria

Additional Information

@shaunc this is out of the scope for the Louketo project. If this is something that you would like to see included, I'd suggest to create an issue at https://github.com/helm/charts or submit a PR.


Xcode 8.1 - Can't return anything with SMCKit

Running this code (on MacBookPro13,2 with 10.12.1):
import Cocoa
import SMCKit

do {
    let fans = try SMCKit.fanCount()
    print(fans)
} catch {
    print("Error")
}

Prints "Error". It happens with fan speed, fan names, etc. What am I doing wrong?

Hello @PKBeam!
open() must be called first to get a connection to the SMC driver (and make sure to call close() when your done!). See SMCKitTool for an example. README/docs should be updated to make that clear, since a number of folks have asked about this, (so my bad!).
Hope that helps!
P.S New Macbook? Nice! :)

Ah, I see. Thanks.


Optional in Hash Input for Struct

I have a few cases when doing StructClass.new(foo: 1, bar: 2) and there is an attribute e.g. baz that has a default value where it feels pretty unnecessary to have to specify baz in the call.
Not sure if I am missing how to do this, or it doesn't support it.
Thanks for any help :)

@AlexRiedler is this what you're looking for https://github.com/dry-rb/dry-types/issues/127#issuecomment-241357190 ?

Yup @flash-gordon thanks for the quick reply; that will work :)