HBASE-24491 Remove HRegionInfo

Could pass compile. Let's see the UTs.
And I guess we also need to deal with hbase-shell.
Will take a look soon.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 34s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+0 :ok:
mvndep
0m 23s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 42s
master passed

+1 :green_heart:
checkstyle
3m 27s
master passed

+1 :green_heart:
spotbugs
5m 45s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 14s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 34s
the patch passed

+1 :green_heart:
checkstyle
0m 31s
hbase-client: The patch generated 0 new + 179 unchanged - 58 fixed = 179 total (was 237)

-0 :warning:
checkstyle
1m 17s
hbase-server: The patch generated 2 new + 761 unchanged - 34 fixed = 763 total (was 795)

+1 :green_heart:
checkstyle
0m 19s
hbase-mapreduce: The patch generated 0 new + 31 unchanged - 2 fixed = 31 total (was 33)

+1 :green_heart:
checkstyle
0m 39s
The patch passed checkstyle in hbase-thrift

+1 :green_heart:
checkstyle
0m 17s
The patch passed checkstyle in hbase-it

+1 :green_heart:
checkstyle
0m 15s
hbase-rest: The patch generated 0 new + 1 unchanged - 2 fixed = 1 total (was 3)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
11m 46s
Patch does not cause any errors with Hadoop 3.1.2 3.2.1.

+1 :green_heart:
spotbugs
8m 28s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
1m  9s
The patch does not generate ASF License warnings.

53m 20s

Subsystem
Report/Notes

Docker
Client=19.03.11 Server=19.03.11 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1830/1/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1830

Optional Tests
dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle

uname
Linux a039e0fce97e 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / e5345b3a7c

checkstyle
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1830/1/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt

Max. process+thread count
94 (vs. ulimit of 12500)

modules
C: hbase-client hbase-server hbase-mapreduce hbase-thrift hbase-it hbase-rest U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1830/1/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 34s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 22s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 39s
master passed

+1 :green_heart:
compile
3m 15s
master passed

+1 :green_heart:
shadedjars
5m 42s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
2m 28s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 15s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 28s
the patch passed

+1 :green_heart:
compile
3m 13s
the patch passed

+1 :green_heart:
javac
3m 13s
the patch passed

+1 :green_heart:
shadedjars
5m 32s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
2m 22s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
1m  1s
hbase-client in the patch passed.

-1 :x:
unit
6m 36s
hbase-server in the patch failed.

+1 :green_heart:
unit
13m 24s
hbase-mapreduce in the patch passed.

+1 :green_heart:
unit
4m 46s
hbase-thrift in the patch passed.

+1 :green_heart:
unit
0m 59s
hbase-it in the patch passed.

+1 :green_heart:
unit
3m 12s
hbase-rest in the patch passed.

63m 29s

Subsystem
Report/Notes

Docker
Client=19.03.11 Server=19.03.11 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1830/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1830

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 2bbf8effd6dc 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / e5345b3a7c

Default Java
1.8.0_232

unit
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1830/1/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1830/1/testReport/

Max. process+thread count
5415 (vs. ulimit of 12500)

modules
C: hbase-client hbase-server hbase-mapreduce hbase-thrift hbase-it hbase-rest U: .

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 15s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 59s
the patch passed

+1 :green_heart:
compile
3m 32s
the patch passed

+1 :green_heart:
javac
3m 32s
the patch passed

+1 :green_heart:
shadedjars
5m 37s
patch has no errors when building our shaded downstream artifacts.

-0 :warning:
javadoc
0m 26s
hbase-client in the patch failed.

-0 :warning:
javadoc
0m 39s
hbase-server in the patch failed.

-0 :warning:
javadoc
0m 20s
hbase-mapreduce in the patch failed.

-0 :warning:
javadoc
0m 51s
hbase-thrift in the patch failed.

-0 :warning:
javadoc
0m 21s
hbase-rest in the patch failed.

_ Other Tests _

+1 :green_heart:
unit
1m  5s
hbase-client in the patch passed.

-1 :x:
unit
7m  3s
hbase-server in the patch failed.

+1 :green_heart:
unit
12m 11s
hbase-mapreduce in the patch passed.

+1 :green_heart:
unit
3m 42s
hbase-thrift in the patch passed.

+1 :green_heart:
unit
0m 54s
hbase-it in the patch passed.

+1 :green_heart:
unit
2m 59s
hbase-rest in the patch passed.

64m  1s

Subsystem
Report/Notes

Docker
Client=19.03.11 Server=19.03.11 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1830/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1830

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux a5cf0a47be0a 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / e5345b3a7c

Default Java
2020-01-14

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1830/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-client.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1830/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-mapreduce.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1830/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-rest.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1830/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1830/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-thrift.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1830/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-client.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1830/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1830/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-mapreduce.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1830/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-thrift.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1830/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-rest.txt

unit
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1830/1/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1830/1/testReport/

Max. process+thread count
6032 (vs. ulimit of 12500)

modules
C: hbase-client hbase-server hbase-mapreduce hbase-thrift hbase-it hbase-rest U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1830/1/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

Seems the ut was not trigger in previous HBase QA?

Seems the ut was not trigger in previous HBase QA?

There are failurs for small tests so the medium and large tests are skipped. Let me take a look.

The method too long checkstyle warning is not introduced by the PR here.
Can open a follow on issue to remove HBaseTestCase and rewrite TestHStoreFile.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 34s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+0 :ok:
mvndep
0m 28s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 25s
master passed

+1 :green_heart:
checkstyle
3m 27s
master passed

+1 :green_heart:
spotbugs
5m 39s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 13s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 29s
the patch passed

+1 :green_heart:
checkstyle
0m 30s
hbase-client: The patch generated 0 new + 179 unchanged - 58 fixed = 179 total (was 237)

-0 :warning:
checkstyle
1m 16s
hbase-server: The patch generated 1 new + 761 unchanged - 34 fixed = 762 total (was 795)

+1 :green_heart:
checkstyle
0m 18s
hbase-mapreduce: The patch generated 0 new + 31 unchanged - 2 fixed = 31 total (was 33)

+1 :green_heart:
checkstyle
0m 40s
The patch passed checkstyle in hbase-thrift

+1 :green_heart:
checkstyle
0m 17s
The patch passed checkstyle in hbase-it

+1 :green_heart:
checkstyle
0m 15s
hbase-rest: The patch generated 0 new + 1 unchanged - 2 fixed = 1 total (was 3)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
11m 43s
Patch does not cause any errors with Hadoop 3.1.2 3.2.1.

+1 :green_heart:
spotbugs
8m 21s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
1m 13s
The patch does not generate ASF License warnings.

52m 47s

Subsystem
Report/Notes

Docker
Client=19.03.11 Server=19.03.11 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1830/2/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1830

Optional Tests
dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle

uname
Linux dcae7d50b6f6 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / f71f1cdfa0

checkstyle
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1830/2/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt

Max. process+thread count
94 (vs. ulimit of 12500)

modules
C: hbase-client hbase-server hbase-mapreduce hbase-thrift hbase-it hbase-rest U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1830/2/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 34s
Docker mode activated.

-0 :warning:
yetus
0m  4s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 27s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 24s
master passed

+1 :green_heart:
compile
3m 15s
master passed

+1 :green_heart:
shadedjars
5m 31s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
2m 26s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 15s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 26s
the patch passed

+1 :green_heart:
compile
3m  8s
the patch passed

+1 :green_heart:
javac
3m  8s
the patch passed

+1 :green_heart:
shadedjars
5m 31s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
2m 20s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
1m  1s
hbase-client in the patch passed.

-1 :x:
unit
144m 10s
hbase-server in the patch failed.

+1 :green_heart:
unit
13m 28s
hbase-mapreduce in the patch passed.

+1 :green_heart:
unit
4m 56s
hbase-thrift in the patch passed.

+1 :green_heart:
unit
1m  8s
hbase-it in the patch passed.

+1 :green_heart:
unit
3m 21s
hbase-rest in the patch passed.

201m 52s

Subsystem
Report/Notes

Docker
Client=19.03.11 Server=19.03.11 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1830/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1830

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 38d42fbedfab 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / f71f1cdfa0

Default Java
1.8.0_232

unit
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1830/2/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1830/2/testReport/

Max. process+thread count
5447 (vs. ulimit of 12500)

modules
C: hbase-client hbase-server hbase-mapreduce hbase-thrift hbase-it hbase-rest U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1830/2/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 36s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  2s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+0 :ok:
mvndep
0m 23s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 38s
master passed

+1 :green_heart:
checkstyle
3m 38s
master passed

+1 :green_heart:
spotbugs
5m 41s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 14s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 28s
the patch passed

+1 :green_heart:
checkstyle
0m 31s
hbase-client: The patch generated 0 new + 179 unchanged - 58 fixed = 179 total (was 237)

-0 :warning:
checkstyle
1m 17s
hbase-server: The patch generated 1 new + 761 unchanged - 34 fixed = 762 total (was 795)

+1 :green_heart:
checkstyle
0m 19s
hbase-mapreduce: The patch generated 0 new + 31 unchanged - 2 fixed = 31 total (was 33)

+1 :green_heart:
checkstyle
0m 57s
The patch passed checkstyle in hbase-thrift

+1 :green_heart:
checkstyle
0m 10s
The patch passed checkstyle in hbase-shell

+1 :green_heart:
checkstyle
0m 17s
The patch passed checkstyle in hbase-it

+1 :green_heart:
checkstyle
0m 17s
hbase-rest: The patch generated 0 new + 1 unchanged - 2 fixed = 1 total (was 3)

-0 :warning:
rubocop
0m 13s
The patch generated 2 new + 166 unchanged - 1 fixed = 168 total (was 167)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
11m 38s
Patch does not cause any errors with Hadoop 3.1.2 3.2.1.

+1 :green_heart:
spotbugs
8m 27s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
1m 29s
The patch does not generate ASF License warnings.

54m  8s

Subsystem
Report/Notes

Docker
Client=19.03.11 Server=19.03.11 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1830/3/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1830

Optional Tests
dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle rubocop

uname
Linux b85dcf58638e 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / f71f1cdfa0

checkstyle
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1830/3/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt

rubocop
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1830/3/artifact/yetus-general-check/output/diff-patch-rubocop.txt

Max. process+thread count
94 (vs. ulimit of 12500)

modules
C: hbase-client hbase-server hbase-mapreduce hbase-thrift hbase-shell hbase-it hbase-rest U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1830/3/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12 rubocop=0.80.0

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

The failed UT is caused by a serious problem of our RegionInfo related API.
Let me open a new issue for fixing it.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 36s
Docker mode activated.

-0 :warning:
yetus
0m  4s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 25s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 38s
master passed

+1 :green_heart:
compile
3m 38s
master passed

+1 :green_heart:
shadedjars
5m 43s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
2m 40s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 16s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 26s
the patch passed

+1 :green_heart:
compile
3m 35s
the patch passed

+1 :green_heart:
javac
3m 35s
the patch passed

+1 :green_heart:
shadedjars
5m 32s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
2m 33s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
1m  1s
hbase-client in the patch passed.

-1 :x:
unit
144m 56s
hbase-server in the patch failed.

+1 :green_heart:
unit
13m 21s
hbase-mapreduce in the patch passed.

+1 :green_heart:
unit
4m 55s
hbase-thrift in the patch passed.

+1 :green_heart:
unit
7m 29s
hbase-shell in the patch passed.

+1 :green_heart:
unit
1m 11s
hbase-it in the patch passed.

+1 :green_heart:
unit
3m 24s
hbase-rest in the patch passed.

211m 58s

Subsystem
Report/Notes

Docker
Client=19.03.11 Server=19.03.11 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1830/3/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1830

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux ef7dfc7aa1cf 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / f71f1cdfa0

Default Java
1.8.0_232

unit
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1830/3/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1830/3/testReport/

Max. process+thread count
5566 (vs. ulimit of 12500)

modules
C: hbase-client hbase-server hbase-mapreduce hbase-thrift hbase-shell hbase-it hbase-rest U: .

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 14s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
4m 31s
the patch passed

+1 :green_heart:
compile
4m  3s
the patch passed

+1 :green_heart:
javac
4m  3s
the patch passed

+1 :green_heart:
shadedjars
6m 26s
patch has no errors when building our shaded downstream artifacts.

-0 :warning:
javadoc
0m 25s
hbase-client in the patch failed.

-0 :warning:
javadoc
0m 40s
hbase-server in the patch failed.

-0 :warning:
javadoc
0m 19s
hbase-mapreduce in the patch failed.

-0 :warning:
javadoc
0m 58s
hbase-thrift in the patch failed.

-0 :warning:
javadoc
0m 20s
hbase-rest in the patch failed.

_ Other Tests _

+1 :green_heart:
unit
1m 22s
hbase-client in the patch passed.

-1 :x:
unit
214m 12s
hbase-server in the patch failed.

+1 :green_heart:
unit
45m 12s
hbase-mapreduce in the patch passed.

+1 :green_heart:
unit
10m 27s
hbase-thrift in the patch passed.

+1 :green_heart:
unit
10m 41s
hbase-shell in the patch passed.

+1 :green_heart:
unit
1m  5s
hbase-it in the patch passed.

+1 :green_heart:
unit
4m 25s
hbase-rest in the patch passed.

332m 55s

Subsystem
Report/Notes

Docker
Client=19.03.11 Server=19.03.11 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1830/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1830

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux a80d174faa74 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / f71f1cdfa0

Default Java
2020-01-14

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1830/3/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-client.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1830/3/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-mapreduce.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1830/3/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-rest.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1830/3/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1830/3/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-thrift.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1830/3/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-client.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1830/3/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1830/3/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-mapreduce.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1830/3/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-thrift.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1830/3/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-rest.txt

unit
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1830/3/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1830/3/testReport/

Max. process+thread count
3682 (vs. ulimit of 12500)

modules
C: hbase-client hbase-server hbase-mapreduce hbase-thrift hbase-shell hbase-it hbase-rest U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1830/3/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
4m 46s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+0 :ok:
mvndep
0m 25s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
5m  7s
master passed

+1 :green_heart:
checkstyle
3m 51s
master passed

+1 :green_heart:
spotbugs
6m  4s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 13s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 48s
the patch passed

+1 :green_heart:
checkstyle
0m 30s
hbase-client: The patch generated 0 new + 179 unchanged - 58 fixed = 179 total (was 237)

-0 :warning:
checkstyle
1m 26s
hbase-server: The patch generated 1 new + 952 unchanged - 34 fixed = 953 total (was 986)

+1 :green_heart:
checkstyle
0m 19s
hbase-mapreduce: The patch generated 0 new + 31 unchanged - 2 fixed = 31 total (was 33)

+1 :green_heart:
checkstyle
0m 46s
The patch passed checkstyle in hbase-thrift

+1 :green_heart:
checkstyle
0m  9s
The patch passed checkstyle in hbase-shell

+1 :green_heart:
checkstyle
0m 15s
The patch passed checkstyle in hbase-it

+1 :green_heart:
checkstyle
0m 15s
hbase-rest: The patch generated 0 new + 1 unchanged - 2 fixed = 1 total (was 3)

-0 :warning:
rubocop
0m 17s
The patch generated 2 new + 166 unchanged - 1 fixed = 168 total (was 167)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
12m 30s
Patch does not cause any errors with Hadoop 3.1.2 3.2.1.

+1 :green_heart:
spotbugs
6m 41s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
1m 13s
The patch does not generate ASF License warnings.

58m  6s

Subsystem
Report/Notes

Docker
Client=19.03.11 Server=19.03.11 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1830/4/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1830

Optional Tests
dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle rubocop

uname
Linux 008430c31a45 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 8de8c44029

checkstyle
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1830/4/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt

rubocop
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1830/4/artifact/yetus-general-check/output/diff-patch-rubocop.txt

Max. process+thread count
84 (vs. ulimit of 12500)

modules
C: hbase-client hbase-server hbase-mapreduce hbase-thrift hbase-shell hbase-it hbase-rest U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1830/4/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12 rubocop=0.80.0

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 42s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 32s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
4m 35s
master passed

+1 :green_heart:
compile
4m  5s
master passed

+1 :green_heart:
shadedjars
7m 28s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
2m 47s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 17s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 24s
the patch passed

+1 :green_heart:
compile
3m 29s
the patch passed

+1 :green_heart:
javac
3m 29s
the patch passed

+1 :green_heart:
shadedjars
6m 20s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
2m 36s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
1m  2s
hbase-client in the patch passed.

+1 :green_heart:
unit
146m 26s
hbase-server in the patch passed.

-1 :x:
unit
1m  8s
hbase-mapreduce in the patch failed.

+1 :green_heart:
unit
4m 20s
hbase-thrift in the patch passed.

+1 :green_heart:
unit
7m 20s
hbase-shell in the patch passed.

+1 :green_heart:
unit
1m 15s
hbase-it in the patch passed.

+1 :green_heart:
unit
4m 21s
hbase-rest in the patch passed.

205m 39s

Subsystem
Report/Notes

Docker
Client=19.03.11 Server=19.03.11 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1830/4/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1830

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 17d87515a0dc 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 8de8c44029

Default Java
1.8.0_232

unit
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1830/4/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-mapreduce.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1830/4/testReport/

Max. process+thread count
3866 (vs. ulimit of 12500)

modules
C: hbase-client hbase-server hbase-mapreduce hbase-thrift hbase-shell hbase-it hbase-rest U: .

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 15s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
4m 35s
the patch passed

+1 :green_heart:
compile
4m  5s
the patch passed

+1 :green_heart:
javac
4m  5s
the patch passed

+1 :green_heart:
shadedjars
6m 32s
patch has no errors when building our shaded downstream artifacts.

-0 :warning:
javadoc
0m 27s
hbase-client in the patch failed.

-0 :warning:
javadoc
0m 41s
hbase-server in the patch failed.

-0 :warning:
javadoc
0m 20s
hbase-mapreduce in the patch failed.

-0 :warning:
javadoc
1m  0s
hbase-thrift in the patch failed.

-0 :warning:
javadoc
0m 22s
hbase-rest in the patch failed.

_ Other Tests _

+1 :green_heart:
unit
1m 26s
hbase-client in the patch passed.

+1 :green_heart:
unit
202m 28s
hbase-server in the patch passed.

+1 :green_heart:
unit
20m 16s
hbase-mapreduce in the patch passed.

+1 :green_heart:
unit
5m 39s
hbase-thrift in the patch passed.

+1 :green_heart:
unit
8m 39s
hbase-shell in the patch passed.

+1 :green_heart:
unit
1m 10s
hbase-it in the patch passed.

+1 :green_heart:
unit
4m 19s
hbase-rest in the patch passed.

286m 45s

Subsystem
Report/Notes

Docker
Client=19.03.11 Server=19.03.11 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1830/4/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1830

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 8c0ccb3bb870 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 10:07:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 8de8c44029

Default Java
2020-01-14

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1830/4/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-client.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1830/4/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-mapreduce.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1830/4/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-rest.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1830/4/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1830/4/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-thrift.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1830/4/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-client.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1830/4/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1830/4/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-mapreduce.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1830/4/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-thrift.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1830/4/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-rest.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1830/4/testReport/

Max. process+thread count
3676 (vs. ulimit of 12500)

modules
C: hbase-client hbase-server hbase-mapreduce hbase-thrift hbase-shell hbase-it hbase-rest U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1830/4/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 32s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+0 :ok:
mvndep
0m 28s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 25s
master passed

+1 :green_heart:
checkstyle
3m 43s
master passed

+1 :green_heart:
spotbugs
5m 27s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 15s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 22s
the patch passed

+1 :green_heart:
checkstyle
0m 27s
hbase-client: The patch generated 0 new + 0 unchanged - 58 fixed = 0 total (was 58)

-0 :warning:
checkstyle
1m 26s
hbase-server: The patch generated 1 new + 952 unchanged - 33 fixed = 953 total (was 985)

+1 :green_heart:
checkstyle
0m 19s
hbase-mapreduce: The patch generated 0 new + 31 unchanged - 2 fixed = 31 total (was 33)

+1 :green_heart:
checkstyle
0m 42s
The patch passed checkstyle in hbase-thrift

+1 :green_heart:
checkstyle
0m 12s
The patch passed checkstyle in hbase-shell

+1 :green_heart:
checkstyle
0m 16s
The patch passed checkstyle in hbase-it

+1 :green_heart:
checkstyle
0m 16s
hbase-rest: The patch generated 0 new + 1 unchanged - 2 fixed = 1 total (was 3)

-0 :warning:
rubocop
0m 11s
The patch generated 2 new + 166 unchanged - 1 fixed = 168 total (was 167)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
11m  3s
Patch does not cause any errors with Hadoop 3.1.2 3.2.1.

+1 :green_heart:
spotbugs
6m 22s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
1m 25s
The patch does not generate ASF License warnings.

48m 49s

Subsystem
Report/Notes

Docker
Client=19.03.11 Server=19.03.11 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1830/5/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1830

Optional Tests
dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle rubocop

uname
Linux 61a8d019d471 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 2c2b1f0174

checkstyle
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1830/5/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt

rubocop
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1830/5/artifact/yetus-general-check/output/diff-patch-rubocop.txt

Max. process+thread count
94 (vs. ulimit of 12500)

modules
C: hbase-client hbase-server hbase-mapreduce hbase-thrift hbase-shell hbase-it hbase-rest U: .

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 15s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
5m  7s
the patch passed

+1 :green_heart:
compile
5m  2s
the patch passed

+1 :green_heart:
javac
5m  2s
the patch passed

+1 :green_heart:
shadedjars
8m  0s
patch has no errors when building our shaded downstream artifacts.

-0 :warning:
javadoc
0m 30s
hbase-client in the patch failed.

-0 :warning:
javadoc
0m 50s
hbase-server in the patch failed.

-0 :warning:
javadoc
0m 24s
hbase-mapreduce in the patch failed.

-0 :warning:
javadoc
1m 11s
hbase-thrift in the patch failed.

-0 :warning:
javadoc
0m 26s
hbase-rest in the patch failed.

_ Other Tests _

+1 :green_heart:
unit
1m 25s
hbase-client in the patch passed.

-1 :x:
unit
146m 57s
hbase-server in the patch failed.

+1 :green_heart:
unit
11m 42s
hbase-mapreduce in the patch passed.

+1 :green_heart:
unit
4m 23s
hbase-thrift in the patch passed.

+1 :green_heart:
unit
7m 10s
hbase-shell in the patch passed.

+1 :green_heart:
unit
1m  7s
hbase-it in the patch passed.

+1 :green_heart:
unit
3m 15s
hbase-rest in the patch passed.

221m 10s

Subsystem
Report/Notes

Docker
Client=19.03.11 Server=19.03.11 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1830/5/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1830

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 3aef661921e1 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 2c2b1f0174

Default Java
2020-01-14

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1830/5/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-client.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1830/5/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-mapreduce.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1830/5/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-rest.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1830/5/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1830/5/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-thrift.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1830/5/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-client.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1830/5/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1830/5/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-mapreduce.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1830/5/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-thrift.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1830/5/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-rest.txt

unit
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1830/5/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1830/5/testReport/

Max. process+thread count
5651 (vs. ulimit of 12500)

modules
C: hbase-client hbase-server hbase-mapreduce hbase-thrift hbase-shell hbase-it hbase-rest U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1830/5/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 27s
Docker mode activated.

-0 :warning:
yetus
0m  4s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 36s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
4m 21s
master passed

+1 :green_heart:
compile
3m 38s
master passed

+1 :green_heart:
shadedjars
6m 17s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
2m 37s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 14s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
4m  3s
the patch passed

+1 :green_heart:
compile
3m 39s
the patch passed

+1 :green_heart:
javac
3m 39s
the patch passed

+1 :green_heart:
shadedjars
6m 16s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
2m 35s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
1m 18s
hbase-client in the patch passed.

+1 :green_heart:
unit
216m 31s
hbase-server in the patch passed.

+1 :green_heart:
unit
20m 55s
hbase-mapreduce in the patch passed.

+1 :green_heart:
unit
6m  6s
hbase-thrift in the patch passed.

+1 :green_heart:
unit
7m 23s
hbase-shell in the patch passed.

+1 :green_heart:
unit
1m 20s
hbase-it in the patch passed.

+1 :green_heart:
unit
5m 25s
hbase-rest in the patch passed.

297m 56s

Subsystem
Report/Notes

Docker
Client=19.03.11 Server=19.03.11 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1830/5/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1830

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux a3b45c4e6e99 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 2c2b1f0174

Default Java
1.8.0_232

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1830/5/testReport/

Max. process+thread count
3712 (vs. ulimit of 12500)

modules
C: hbase-client hbase-server hbase-mapreduce hbase-thrift hbase-shell hbase-it hbase-rest U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1830/5/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 36s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+0 :ok:
mvndep
0m 26s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 28s
master passed

+1 :green_heart:
checkstyle
3m 37s
master passed

+1 :green_heart:
spotbugs
5m 38s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 13s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 19s
the patch passed

+1 :green_heart:
checkstyle
0m 27s
hbase-client: The patch generated 0 new + 0 unchanged - 58 fixed = 0 total (was 58)

-0 :warning:
checkstyle
1m 25s
hbase-server: The patch generated 1 new + 952 unchanged - 33 fixed = 953 total (was 985)

+1 :green_heart:
checkstyle
0m 18s
hbase-mapreduce: The patch generated 0 new + 31 unchanged - 2 fixed = 31 total (was 33)

+1 :green_heart:
checkstyle
0m 40s
The patch passed checkstyle in hbase-thrift

+1 :green_heart:
checkstyle
0m 11s
The patch passed checkstyle in hbase-shell

+1 :green_heart:
checkstyle
0m 17s
The patch passed checkstyle in hbase-it

+1 :green_heart:
checkstyle
0m 15s
hbase-rest: The patch generated 0 new + 1 unchanged - 2 fixed = 1 total (was 3)

-0 :warning:
rubocop
0m 11s
The patch generated 1 new + 166 unchanged - 1 fixed = 167 total (was 167)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
11m 14s
Patch does not cause any errors with Hadoop 3.1.2 3.2.1.

+1 :green_heart:
spotbugs
6m 32s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
1m 18s
The patch does not generate ASF License warnings.

48m 55s

Subsystem
Report/Notes

Docker
Client=19.03.11 Server=19.03.11 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1830/6/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1830

Optional Tests
dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle rubocop

uname
Linux 4e0ce252d4ac 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 2c2b1f0174

checkstyle
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1830/6/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt

rubocop
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1830/6/artifact/yetus-general-check/output/diff-patch-rubocop.txt

Max. process+thread count
94 (vs. ulimit of 12500)

modules
C: hbase-client hbase-server hbase-mapreduce hbase-thrift hbase-shell hbase-it hbase-rest U: .

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 15s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 57s
the patch passed

+1 :green_heart:
compile
3m 48s
the patch passed

+1 :green_heart:
javac
3m 48s
the patch passed

+1 :green_heart:
shadedjars
5m 42s
patch has no errors when building our shaded downstream artifacts.

-0 :warning:
javadoc
0m 25s
hbase-client in the patch failed.

-0 :warning:
javadoc
0m 40s
hbase-server in the patch failed.

-0 :warning:
javadoc
0m 20s
hbase-mapreduce in the patch failed.

-0 :warning:
javadoc
0m 49s
hbase-thrift in the patch failed.

-0 :warning:
javadoc
0m 19s
hbase-rest in the patch failed.

_ Other Tests _

+1 :green_heart:
unit
1m 11s
hbase-client in the patch passed.

+1 :green_heart:
unit
132m 56s
hbase-server in the patch passed.

+1 :green_heart:
unit
15m  0s
hbase-mapreduce in the patch passed.

+1 :green_heart:
unit
4m 41s
hbase-thrift in the patch passed.

+1 :green_heart:
unit
7m 16s
hbase-shell in the patch passed.

+1 :green_heart:
unit
1m 18s
hbase-it in the patch passed.

+1 :green_heart:
unit
3m 45s
hbase-rest in the patch passed.

203m 27s

Subsystem
Report/Notes

Docker
Client=19.03.11 Server=19.03.11 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1830/6/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1830

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 0770f4012f8f 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 2c2b1f0174

Default Java
2020-01-14

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1830/6/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-client.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1830/6/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1830/6/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-mapreduce.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1830/6/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-thrift.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1830/6/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-rest.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1830/6/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-client.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1830/6/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1830/6/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-mapreduce.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1830/6/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-thrift.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1830/6/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-rest.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1830/6/testReport/

Max. process+thread count
5802 (vs. ulimit of 12500)

modules
C: hbase-client hbase-server hbase-mapreduce hbase-thrift hbase-shell hbase-it hbase-rest U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1830/6/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
2m  6s
Docker mode activated.

-0 :warning:
yetus
0m  4s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 13s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
4m 23s
master passed

+1 :green_heart:
compile
4m  8s
master passed

+1 :green_heart:
shadedjars
6m 55s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
3m 22s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 15s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
4m 28s
the patch passed

+1 :green_heart:
compile
3m 57s
the patch passed

+1 :green_heart:
javac
3m 57s
the patch passed

+1 :green_heart:
shadedjars
6m 18s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
2m 37s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
1m 22s
hbase-client in the patch passed.

+1 :green_heart:
unit
217m 16s
hbase-server in the patch passed.

+1 :green_heart:
unit
20m 24s
hbase-mapreduce in the patch passed.

+1 :green_heart:
unit
5m 45s
hbase-thrift in the patch passed.

+1 :green_heart:
unit
7m 16s
hbase-shell in the patch passed.

+1 :green_heart:
unit
1m 14s
hbase-it in the patch passed.

+1 :green_heart:
unit
5m 34s
hbase-rest in the patch passed.

300m 46s

Subsystem
Report/Notes

Docker
Client=19.03.11 Server=19.03.11 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1830/6/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1830

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux ecd92f435b91 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 2c2b1f0174

Default Java
1.8.0_232

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1830/6/testReport/

Max. process+thread count
3900 (vs. ulimit of 12500)

modules
C: hbase-client hbase-server hbase-mapreduce hbase-thrift hbase-shell hbase-it hbase-rest U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1830/6/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.


Elementwise simd: generate simd code with broadcast from a scalar

When we have broadcast of a single tensor to one or more scalar, we can generate SIMD code without any issues.
e.g.
  %0 = "onnx.Add"(%arg0, %arg1) : (tensor<?x?x64xf32>, tensor<f32>) -> tensor<*xf32>

This PR add this with two lit-tests.
This PR also consolidate the SIMD code generation from unary/binary/variadic patterns into a single function, to cut down on redundancy.

Has code generation issues that are fixed in #2161. #2161 is also more general and subsumes new features being added here


Metamodel of locals tests fail

This is due to Gavin's changes in scopes, which puts declarations like Object o = object {} in scope of o rather than its container. I had to work around it in the JVM metamodel to make sure I attribute the object class as belonging to the container if the attribute is not lazy, as is proper. You probably have to do the same workarounds.

This is what you get if you run the tests:
[ceylon-run-js] Failed local types
[ceylon-run-js] ceylon.language::AssertionError "Assertion failed: 'c1.container == `package metamodel`' at Locals.ceylon (469:10-469:46)"
[ceylon-run-js]     at ceylon.language::AssertionError (Locals.ceylon 469:4-469:47)
[ceylon-run-js]     at metamodel::locals_testPackageLocals
[ceylon-run-js]     at metamodel::locals
[ceylon-run-js]     at metamodel::checkLocalTypes
[ceylon-run-js]     at metamodel::run
[ceylon-run-js] ceylon.language.jsint::AppliedMemberConstructor<metamodel::Constructors<ceylon.language::String>,metamodel::Constructors.Member,[]>
[ceylon-run-js]
[ceylon-run-js] /home/stephane/src/java-eclipse/ceylon.language/build/test/metamodel/0.1/metamodel-0.1.js:7605
[ceylon-run-js] }else{throw $2q6}
[ceylon-run-js]             ^
[ceylon-run-js] ceylon.language::NativeError "ReferenceError: $prop$get$2nl is not defined"

OK so I managed to reproduce this with:
  Object o = object{};
  value t = type(o);

and the problem is indeed with the specified container for the anonymous class.


ls: Windows - Friendlier Windows listing

When ls -l is used on a windows system you receive:
---------- 1 somebody somegroup      0 May 19 10:04 ls.exe -> 'C:\Users\andre\Programs\Bin\coreutils.exe'

In powershell using Get-ChildItem (powershell ls) on a linux system this is translated well showing permissions, user and group:
lrwxrwxrwx andre    andre    5/18/2022 10:24    26 coreutils ->  ../lib/coreutils/coreutils

To make ls more NTFS friendly; ls could mirror the powershells output for handling the list output
and utilize the object type indicator instead and ignore USER and GROUP
Below you can see a output using Get-ChildItem on a windows:
la---          2022-05-18    16:06              0 coreutils.exe -> C:\Programs\Lib\coreutils\coreutils.exe

l (link)
d (directory)
a (archive)
r (read-only)
h (hidden)
s (system)
https://docs.microsoft.com/en-us/powershell/module/microsoft.powershell.management/get-childitem?view=powershell-7.2

As a example this could then be the output for a Windows file system:
PS > ls.exe -l
total 2707968
la---    1          0 May 18 16:06 coreutils.exe -> 'C:\Programs\Lib\coreutils\coreutils.exe'
la---    1          0 May 19 10:04 ls.exe -> 'C:\Users\andre\Programs\Bin\coreutils.exe'
-a---    1      89088 Dec  2 11:57 steam.exe

Screenshots of terminals

Windows - Powershell

Linux - Bash Powershell

Thanks! This is very much a design decision, with a couple of different things to consider:

What do Windows users expect/want?
What do Unix users working on Windows expect/want? (Because we aim to be a rewrite of the GNU coreutils, it makes sense to expect the same behaviour on Windows as on Unix)
What do script writers expect/want?

Arguably, the last point is less important for ls, because it should not be used in scripts, but I think it is still used a lot and we don't want to break those. So let's try to answer these questions.

This is what you suggest. ls on Windows should behave like ls in cmd or Powershell. It should show the information that is relevant to the OS you're on.
This is tougher to answer. I think it's probably what we have now. It's the same command as on Unix with some (admittedly ugly) filler for missing information. One might also expect some slight translation from unix concepts to windows concepts where possible.
Script writers mostly want the output to be consistent on all platforms, so any parsing (which, again, is discouraged) would not fail on Windows, while it succeeds on unix platforms. Also if scripts are currently running on Windows, it might be through Git Bash, which I think does the same thing that we currently do.

With those conflicting expectations, I don't think there's a lot we can do. Maybe there are some small improvements we can make while preserving the general format. Some possibilities (not sure if they are correct):

Use the read-only flag to fill in the permissions somewhat. I.e. if read-only is active we do r--r--r-- and otherwise rwxrwxrwx.
Figure out the owner of the file and use that in the user column (somewhat equivalent to this stackoverflow answer)

Using WSL this is the output when navigating to the windows file system i would return the owner and group belonging to the current main user of the WSL system su will not change owner or group to root or anything else. WLS ls -la using default coreutils example below:

Picture

Windows groups and user system work complacently different from how Linux does and is not directly applicable.
Groups and user example below:
PS > whoami
b-station\andre
Administrator in B-Station in C:\bin
PS > whoami /groups

GROUP INFORMATION
-----------------

Group Name                                                    Type             SID                                                                                Attributes
============================================================= ================ =========================================================================================================== ===============================================================
Everyone                                                      Well-known group S-1-1-0                                                                                Mandatory group, Enabled by default, Enabled group
NT AUTHORITY\Local account and member of Administrators group Well-known group S-1-5-114                                                                                Mandatory group, Enabled by default, Enabled group
BUILTIN\Administrators                                        Alias            S-1-5-32-544                                                                                Mandatory group, Enabled by default, Enabled group, Group owner
BUILTIN\Users                                                 Alias            S-1-5-32-545                                                                                Mandatory group, Enabled by default, Enabled group
NT AUTHORITY\NETWORK                                          Well-known group S-1-5-2                                                                                Mandatory group, Enabled by default, Enabled group
NT AUTHORITY\Authenticated Users                              Well-known group S-1-5-11                                                                                Mandatory group, Enabled by default, Enabled group
NT AUTHORITY\This Organization                                Well-known group S-1-5-15                                                                                Mandatory group, Enabled by default, Enabled group
NT AUTHORITY\Local account                                    Well-known group S-1-5-113                                                                                Mandatory group, Enabled by default, Enabled group
<EMAIL_ADDRESS>                   User             S-1-11-96-3623454863-58364-734123-14623123-1597581903-9464323-63323446572-1234663523-18084664304-5764345346 Enabled group
NT AUTHORITY\NTLM Authentication                              Well-known group S-1-5-64-10                                                                                Mandatory group, Enabled by default, Enabled group
Mandatory Label\High Mandatory Level                          Label            S-1-16-12288

Answering from my point:

What do Windows users expect?, What do Unix users working on Windows expect? (Because we aim to be a rewrite of the GNU coreutils, it makes sense to expect the same behaviour on Windows as on Unix), What do script writers expect?
To be able to utilize ls in a powershell environment witch is does today with no problems see below.PS > ls.exe | Foreach-Object { echo "$_" }
coreutils.exe
ln.exe
ls.exe

for the list param you could eather sow the object owner and group this would probably majority of time return BUILTIN\Administrators or Computer\Name don't se the direct usefullness tho.PS > Get-Acl .\coreutils.exe

    Directory: C:\Programs\Bin

Path          Owner                  Access
----          -----                  ------
coreutils.exe BUILTIN\Administrators BUILTIN\Administrators Allow  FullControl…

PS > Get-Acl .\.bin\adb-push.cmd

    Directory: C:\Users\andre\.bin

Path         Owner           Access
----         -----           ------
adb-push.cmd B-Station\andre NT AUTHORITY\SYSTEM Allow  FullControl…

What i expect from the ls command should be similar but same cross each platform which relevant adjustments ether showing proper windows user or not showing it at all due to the OS relevance. I would never expect a shell script to function on a windows system outside of WSL. Powershell tho do function cross platform but ls usage as of shown above do function as expected especially using non list format.

Some experiments
When piping list in powershell when piping to Select -First 1 it will show size.
PS > ls.exe -l | Select -First 1
total 14697

ls.exe -l | Format-Table -AutoSize does nothing in particular cause it will not be able to  make a table out of if.
Same goes for filter actions when tempting to do anything with the "table":
ls.exe -l | Format-Table -AutoSize | ForEach-Object { echo $_.Name }
ls.exe -l | Format-Table -AutoSize | ForEach-Object { echo $_.total }

I like WSL as an example! I think that should be our role model so to speak. They seem to have made some sensible choices there. Don't hesitate to open PRs to fix this issue. I don't work on Windows myself so I can't really work on this directly.

For reference, GetSecurityInfo will return the SID of the user and group*.
Another question is how to handle SIDs that can't be mapped to a username. This is a common occurrence on Windows (especially when used with capability SIDs (see also) or when a name can't be resolved over the network for whatever reason.
Perhaps we might want a cached_sid2name function for Windows (similar to cached_uid2usr and cached_gid2grp) and if a lookup fails, just fallback to the SID itself (this is the Windows permissions dialogs do)?
It is theoretically possible to go through the ACL and see if read, write, and execute permissions are allowed on the SIDs for the user and group.
Other really doesn't have an equivalent in Windows (Everyone is inaccurate, as POSIX other doesn't include the user or group). Regardless, rwxrwxrwx isn't the best (and nor is r-xr-xr-x).
Relevant Windows API functions and articles:

GetSecurityInfo
LookupAccountSid
How AccessCheck Works

* It's worth noting, although perhaps irrelevant, that technically these aren't users and groups per se. In fact, on a lot of files, the SID returned isn't (SYSTEM isn't a user or group for example. In some cases, service SIDs can own stuff too (most notable with TrustedInstaller)).


Add saliency functionality to performance [SwiftUI]

Updated storage rules

Please update https://github.com/firebase/quickstart-ios/blob/master/performance/SwiftUIPerformanceQuickstart/PerformanceExample/README.md that describes the four buttons including a definition of saliency. It should be a user-facing version of what goes into the design doc.

Could that be added as a separate "update docs" PR? I was thinking of adding a new markdown file (e.g. OUTLINE.md) which also contained the app screenshots and function descriptions, but I am still finalizing on the design doc.

Yes. The doc can be a separate PR, but in the meantime please add a definition of saliency to the description of this PR.

Just did ✅  Please feel free to leave feedback.


Test UI upgrade path

Install latest UI
Install old kubewarden stack
Upgrade kubewarden into latest version
Run tests

https://github.com/rancher/kubewarden-ui/pull/615


Add support for postgres and mysql numeric and decimal types in migrations

Currently if you have a field.Float("price").SchemaType(map[string]string{dialect.Postgres: "numeric(6, 4)"}) field then the migration will forever think that it needs to change the type because when scanning the existing table structure it will see it as just numeric without the precision and scale.
This PR fixes that by looking at the numeric_precision and numeric_scale fields which are present in the information_schema.columns for both engines.
I chose to use the c.SchemaType instead of adding the metadata to the Column{} since currently that's also how it's being created anyway.
I suppose in the future we could maybe add a field.Decimal field type and use big.Float or https://github.com/shopspring/decimal as the GoType for it ...
I added 2 test cases, one to check it no longer continuously keeps trying to migrate the column and one which checks that you can actually migrate the column.
Also added a better error message to make it a little easier to figure out which entity is causing issues.

I've seen this behavior too. Thanks for proposing a fix!

thanks for the suggestions, squashed them all into my commit.
and as always: thanks for the time and effort you put into maintaining this <3

thanks for the suggestions, squashed them all into my commit.
and as always: thanks for the time and effort you put into maintaining this <3

Thanks for the kind words and for your contribution ❤


failed to toggle bookmark

Issue
When an item is bookmarked, it can only be cleared on the main page, clicking the bookmark Item will do nothing
How to reproduce

randomly select a stop (e.g. https://thomassth.github.io/ttc-eta/stops/14684)
bookmarked it by clicking the bookmark button
try clicking the button again to un-bookmark it

expected behaviour

un-bookmarking a stop smoothly

actual behaviour

failed to un-bookmark a stop

Closed with #23


Gruvfox

addresses #364.
This is my implementation of  the Gruvbox theme. however, I only implemented the Gruvbox hard variant.
Here are some screenshots:

Lemme know if anything need a fix.

I might need some input to see if the colors are accurate.

After the latest commit. the colorscheme looks lie this.

This looks pretty nice actually, thank you for the effort!
I just have one minor suggestion, personally I would prefer less red (I typically associate reds to errors).


[WIP] Try to fix CI when exceptions are disabled

Includes #115

are we stuck on this one?

bors r=kvark


Assign specific jobs to dedicated workers

#507

@muursh One thing we might to check is when queue messages expire.

@muursh One thing we might to check is when queue messages expire.

Yeah for sure. We should also open issues for the bits we discussed.

@muursh One thing we might to check is when queue messages expire.

Yeah for sure. We should also open issues for the bits we discussed.

Have asked leo to also confirm on a few test cases

@Nashtare final review from your side pls

@Nashtare final review pls


Add trunk.io enabled badge to README.md

Thank you to the maintainers for initializing Trunk in this OSS project. I lead DevRel for Trunk, and am adding this badge to the project readme. Trunk is and will always be free to use for all Open Source projects. Please feel free to join us in the Slack community if you aren't already, and we are here to support you in any way we can with any problems, feature requests, etc.
http://trunkcommunity.slack.com
-Tim D
Signed-off-by: Tim Davis<EMAIL_ADDRESS>

Awesome, LGTM!


Uniform the color prop of typography components

Closes #421
This PR uniforms the color prop definition of the typography components.
The supported colors are now the following

Body
Display
Headline
Label
Title

Primary
✅
✅
✅
✅
✅

Secondary
✅
✅
✅
✅
✅

PrimaryInverse
✅
✅
✅
✅
✅

SecondaryInverse
✅
✅
✅
✅
✅

Interactive
✅

✅

Informative
✅

✅
✅

Positive
✅

✅
✅

Warning
✅

✅
✅

Negative
✅

✅
✅

Disabled
✅

✅

All the components also support the inherit value.
The default value is' primary' for all the components except Label (to not alter its behaviour).

I understand the concern about the breaking change in the recipes, but I'm not that sure that preserving retro compatibly, in this case, is worth introducing an inconsistency between the recipes, where color is mandatory somewhere and optional elsewhere.


[WIP] Span class.

Implement span class from ISO++20 for safer pointer indexing.
TODOs:

[x] Fix convert and container constructor.
[x] Fix as_bytes.
[x] Make the naming consistent with xgboost instead of ISO.
[x] Structure tests for CUDA tests.
[x] Fix errors in test farm.
[x] Make an example use in xgboost.

@RAMitchell  I will re-visit all test cases, see what's been missing.
For the as_bytes, it did came across my mind. Maybe one needs to serialize a segment of memory, like a trained model? I don't know, so obliging to the standard is just me making a safe bet.

Not ready yet, seems tests is still not thorough enough.

@hcho3 as noted by @trivialfis there is actually an array_view class in dmlc-core. After a brief look it seems it is used by the nvvm/tv projects. We could replace array_view with our span which is more powerful,  better tested and compliant with the upcoming standard. What do you think?

@RAMitchell You should file a pull request at dmlc-core and make a case for upgrading array_view with the span class. There seems to be a good amount of code using array_view already and it would take some work to replace all occurrences.
For the sake of lesser friction, you could simply add the span class to dmlc-core and have DMLC projects gracefully adopt it.

@RAMitchell Ready for another review. The Travis failed fetching packages in Python test, it should be fine on a good day.
The last commit is just a toy show case for using Span in kernel code. It could be reverted for a more formal integration.

Looks good. One more thing to consider, span will incur a performance overhead when using the operator[], these changes will have worsened performance in places like this: https://github.com/dmlc/xgboost/blob/a96039141a8dd2d053ae8f415c8fc8e52223216e/src/data/simple_dmatrix.cc#L61
This can be fixed by changing this to a range based for loop, I believe this does not need to do any index checking.

DVec can be dealt with later. My idea is that we can gradually enforce the usage of span across the code base using the clang-tidy linter. The most important algorithm for us is gpu_hist as it is used a lot in production, so maybe we can start there when you are ready.
I think this should be good to merge when the CI tests pass.

@RAMitchell So it passed. \0/


Add environment variables as a source

Hey, first thanks for this amazing tool!
Could it possible to add environment variables as a source?
Keep it coding!

I like that. What about something that allows you to use ENV as a source?


Add a mutex which guards access to pods in Kubelet.

As per #4462.

Added copying to guarded Get... methods and applied the fix.

PR #4494 addresses the same thing and is IMHO cleaner (less changes).

Closing in favor of #4494


chore: nox doctests only in Python 3.12

What type of PR is this? (check all applicable)

[ ] 💾 Refactor
[ ] ✨ Feature
[ ] 🐛 Bug Fix
[ ] 🔧 Optimization
[ ] 📝 Documentation
[ ] ✅ Test
[x] 🐳 Other

Related issues
Checklist

[ ] Code follows style guide (ruff)
[ ] Tests added
[ ] Documented the changes

If you have comments or can explain your changes, please do so below.
To be consistent with CI #1189 we should just run doctests in Python 3.12 in nox

thanks both!


bug(python): table update yields unterminated string literal

LanceDB version
No response
What happened?
From discord https://discord.com/channels/1030247538198061086/1258912681168212051
For example:
table.update(where=f"id = '{msg.id}'", values={"content": "I'm good, how are you?"})

yields a ValueError: Invalid user input: LanceError(IO): Unterminated string literal. Notably, this doesn't happen for Table.add

The schema is
pa.schema(
    [
        pa.field("id", pa.string()),
        pa.field("content", pa.string()),
        pa.field("vector", pa.list_(pa.float32(), 384), False),
    ]
)

Are there known steps to reproduce?
No response

This is most likely due to the fact we are not escaping single quotes when converting the literal values to a SQL string.
Should be an easy fix here:
https://github.com/lancedb/lancedb/blob/fd5ca20f344803c6eddf84c637dd578f488d6a65/python/python/lancedb/util.py#L231


A question for Daniel Noord

@DanielNoord I have a favour to ask privately if I could (it's a positive/manager thing, but I would prefer to not ask publicly about it). You don't have a public way to reach you listed at https://github.com/DanielNoord , so I'm not quite sure how to reach out to you about the favour. Would you be willing to email me at<EMAIL_ADDRESS>or provide a way via Mastodon or X/Twitter?

Hi @brettcannon, just reached out via email!


Poor visibility of menu bar icons when DesktopNotifications is enabled on mac

OS: macOS 15.0.1
version: goneovim-nightly
GonvimVersion: v0.6.10

Icons improved by nightly-1-g1e29eea.


UHID keyboard - IME benefits question

Hi,
It says in your docs that UHID lets you used IME's
in a new and better way than ever before.
I use Chinese IME in Windows all the time,
but switching input languages on my phone isn't so smooth.
Can you explain what this new improved method of (e.g.) Chinese input is?
How it works or how to use it with SCRCPY?
Thanks!

The UHID feature basically behaves the same as plugging (on connecting via bluetooth) a physical keyboard to the device.
I have no experience with Chinese IME (I'm French), so maybe @yume-chan (or others) may give more details.
But for now, here is a video someone posted on Twitter, which shows what typing Chinese on Android from scrcpy looks like: https://twitter.com/amatetest/status/1764625600512499714

I only use Gboard and don't have any issue with SDK injection.
Based on #1055, some Chinese IMEs (including Sogou, TouchPal and others) don't respond to SDK injection, but work correctly with physical keyboards (over USB or Bluetooth) and AoA injection (the old --hid-keyboard option).
Like AoA injection, the new UHID injection method also simulates a physical keyboard. But unlike AoA injection, it works on Windows (while mirroring) and TCP/IP (ADB over Wi-Fi). This is the main benefit of UHID injection.

which shows what typing Chinese on Android from scrcpy 2.4 looks like: https://twitter.com/amatetest/status/1764625600512499714

(This is Japanese, not Chinese)

I use Chinese IME in Windows all the time,

UHID keyboard simulates a physical keyboard, it doesn't work directly on IME level. It can't take inputs from Windows IME and inject Chinese characters into Android system. That requires installing a custom IME app on Android, which is a different feature request.


Ignore any UnsupportedOperationExceptions thrown during scan

Description
When doing a deep scan on KMS keys in AWS, if a key's origin is external (imported key material), the scan fails and the AWS API throws an UnsupportedOperationException with the error message "origin is EXTERNAL which is not valid for this operation." This failure should be ignored and the scan should continue without regarding this failed key.
Environment

OS: MacOS and Linux
driftctl version: v0.38.2
terraform version: v1.3.2
terraform providers versions<EMAIL_ADDRESS>
How to reproduce

Create a key with an origin that is external
Scan KMS keys
An UnsupportedOperationException is thrown

Possible Solution

Check for UnsupportedOperationException in the error message in enumeration/remote/terraform/provider.go
Log a warning message but do not return the error. This results in the resource being nil
Continue scanning as normal

Additional context
I've only ran into this with AWS KMS keys but it might be possible on other resources.

I was able to get past this issue by modifying the code in provider.go with the following code block on line 211:
if err != nil {
		if strings.Contains(err.Error(), "UnsupportedOperationException") {
			logrus.Warn("Operation is not supported")
		} else {
			return nil, err
		}
	}


chore(package): update kronos-interceptor to version 1.4.0

http://greenkeeper.io/

Current coverage is 82.58%

Merging #12 into master will not affect coverage as of 549beb9

@@            master     #12   diff @@
======================================
  Files           11      11
  Stmts          580     580
  Branches       181     181
  Methods          0       0
======================================
  Hit            479     479
  Partial          0       0
  Missed         101     101

Review entire Coverage Diff as of 549beb9

Powered by Codecov. Updated on successful CI builds.


new(driver/modern_bpf): Support syscall specific dropping logic into modern bpf probe

What type of PR is this?
/kind feature
Any specific area of the project related to this PR?
/area driver-modern-bpf
/area tests
Does this PR require a change in the driver versions?
No
What this PR does / why we need it:
This PR supports the syscall-specific dropping logic we have in the other 2 drivers. This logic is disabled by default but it can be enabled by using dropping_mode=true
The code section that I'm implementing here is this one (in the old probe)
switch (evt_type) {
case PPME_SYSCALL_CLOSE_X:
case PPME_SOCKET_BIND_X: {
	long ret = bpf_syscall_get_retval(ctx);

	if (ret < 0)
		return true;

	break;
}
case PPME_SYSCALL_CLOSE_E: {
	struct sys_enter_args *args;
	struct files_struct *files;
	struct task_struct *task;
	unsigned long *open_fds;
	struct fdtable *fdt;
	int close_fd;
	int max_fds;

	close_fd = bpf_syscall_get_argument_from_ctx(ctx, 0);
	if (close_fd < 0)
		return true;

	task = (struct task_struct *)bpf_get_current_task();
	if (!task)
		break;

	files = _READ(task->files);
	if (!files)
		break;

	fdt = _READ(files->fdt);
	if (!fdt)
		break;

	max_fds = _READ(fdt->max_fds);
	if (close_fd >= max_fds)
		return true;

	open_fds = _READ(fdt->open_fds);
	if (!open_fds)
		break;

	if (!bpf_test_bit(close_fd, open_fds))
		return true;

	break;
}
case PPME_SYSCALL_FCNTL_E:
case PPME_SYSCALL_FCNTL_X: {
	long cmd = bpf_syscall_get_argument_from_ctx(ctx, 1);

	if (cmd != F_DUPFD && cmd != F_DUPFD_CLOEXEC)
		return true;

	break;
}
default:
	break;
}

Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
NONE

/milestone next-driver

LGTM label has been added.  Git tree hash: 76b4dc85de5569059756a3c307e4d481d9b08427

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: Andreagit97, FedeDP
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [Andreagit97,FedeDP]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: Andreagit97, FedeDP, jasondellaluce
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [Andreagit97,FedeDP,jasondellaluce]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


logging: excessive log write time on Cloud Functions

Originally reported by @deremer at https://github.com/GoogleCloudPlatform/google-cloud-node/issues/2438#issuecomment-323405864.

I've also discovered that in our cloud functions write.log() is taking about 15s to log to StackDriver... If I revert to console.error it is almost instantaneous. I've zeroed the delay in precision on to the call of log.write. If I print to console just before that line and then just after it is routinely 10-15s.

We thought degraded performance of our functions was related to load, when in fact it seems to just be this method call...

Repro:
const functions = require('firebase-functions');
const logging = require('@google-cloud/logging')();

const syslog = logging.log('mylog');

exports.helloWorld = functions.https.onRequest((request, response) => {
  let t = process.hrtime();
  syslog.error('sample stackdriver log entry').then(() => {
    t = process.hrtime(t);
    const ms = (t[0] * 1000) + (t[1] / 1e6);
    response.send(`Hello from Firebase! took ${ms}ms.`);
  }).catch((e) => {
    response.send(`syslog.error gave error ${e}`);
  });
});

Hello from Firebase! took 16715.34293ms.

I suspect that the problem is that logging (and other veneer libraries) do things lazily. For example, application default credentials, default resource detection, etc. are all done lazily and happen to take 16 seconds on the first request. Since cloud functions are aggressively throttled, this means that independent request take this long unless they happen to hit a warm function (i.e. if the request load is high enough).
/cc @stephenplusplus @jasonpolites

application default credentials, default resource detection, etc. are all done lazily and happen to take 16 seconds on the first request

Have you tested that it takes 16 seconds locally?

Some initial profiling:
helloHttp ebzwjsaqqgdv<PHONE_NUMBER>728 Function started helloHttp ebzwjsaqqgdv
helloHttp ebzwjsaqqgdv<PHONE_NUMBER>730 Log#write helloHttp ebzwjsaqqgdv
helloHttp ebzwjsaqqgdv<PHONE_NUMBER>004 Log#write#writeWithResource helloHttp ebzwjsaqqgdv
helloHttp ebzwjsaqqgdv<PHONE_NUMBER>005 Log#write#logging.request helloHttp ebzwjsaqqgdv
helloHttp ebzwjsaqqgdv<PHONE_NUMBER>192 Log#write#callback from logging.request helloHttp ebzwjsaqqgdv
helloHttp ebzwjsaqqgdv<PHONE_NUMBER>194 Function terminated helloHttp ebzwjsaqqgdv

The timestamps are in milliseconds. It seems that the majority of the time is spent in Metadata#getDefaultResource.

Majority of the time is in google-auto-auth:getEnvironment:
  getEnvironment (callback) {
    async.parallel([
      cb => this.isAppEngine(cb),
      cb => this.isCloudFunction(cb),
      cb => this.isComputeEngine(cb),
      cb => this.isContainerEngine(cb)
    ], () => {
      callback(null, this.environment);
    });
  }

Specifically, isContainerEngine is the slowest operation (probably because that looks for a key in the metadata service 404 in the metadata service).
I wonder if using async.parallel is the best choice here. The slowest operation becomes the bottleneck, even though, for cloud functions, the local environment is enough for us to make the determination.

@deremer -- we believe we've chased down the fix. Would you mind testing again? The fix should be automatically picked up by a new install of @google-cloud/logging.

Seems to be fixed in my own experiments. Let's keep this issue open until we can get feedback from @deremer.

I believe this is fixed. @deremer Please re-open if you still see issues.

@ofrobots Sorry, I lost track of this one... but I did want to let you know that based on my usage, this issue does in fact appear to be resolved. Also confirmed that only a redeploy of the function is required for the fix to take hold. Thanks for the fix!


Consider upstream integration

Hi again,
Did you consider submitting your work upstream to be integrated directly into Doxygen? While I really like your solution, I'm a little concerned about incompatibilities with future Doxygen versions. Furthermore, this would allow a much larger group of people to benefit from you work. Just a thought...

Yep, that's a good idea. I am already in contact with the Maintainer of doxygen: https://github.com/doxygen/doxygen/issues/6658
Nevertheless I' prefer to give the theme some time to incubate in this repository, with a smaller user base. And I expect bringing the theme officially to Doxygen to be very labor intensive. As long as I can achieve what I want by patching the existing theme I guess my incentive to contribute to Doxygen will be too small for it to happen anytime soon.  It is probably a very good idea to mature the theme here before integrating upstream. Indeed fewer users, but also much faster release cycle. However, I too would love to see it integrated upstream. In the end that is  simpler as a user, but probably limits the number of work-arounds in the long run.

It seems that doxygen has released a dark theme : https://github.com/doxygen/doxygen/issues/8404 . I would feel that the time is right to integrate upstream. Since there is now a configuration option HTML_COLORSTYLE your style could potentially just be one of the options?

I feel like I should give you an update about my current thoughts on this topic as a maintainer:
Atm I have to patch the theme for new releases of doxygen on a regular basis, which I realized is a risky strategy to go forward. There may at one point be changes that cannot be "fixed" with a few more lines of CSS overrides added to the theme. In fact this has already happened with the doxygen 1.9.5 release.
I'll definitely have to evaluate strategies on how to mitigate this risk in the near future.
My current plan is to work on a standalone version of the theme that does not depend on the default doxygen.css. This would decouple the styling from new doxygen releases. It is still risky though bc the HTML may also change over time.
At that point one may propose in doxygen/doxygen to add a switch to choose between the "default" and the "awesome" (🤭) theme variant. Thanks @tdegeus for the idea to make this a HTML_COLORSTYLE option!
Any initiative from my side to create the standalone version of the theme and discuss at doxygen/doxygen how an integration would be possible will likely not happen in the next couple of months. But working towards this goal seems inevitable for the future of this theme and it will be my main focus in the mid term.


Correctly record the rawInputBytes metric in TableScan

Follow up https://github.com/facebookincubator/velox/pull/8536 and https://github.com/facebookincubator/velox/pull/8147.
This PR adds a check to set the size to 0 if the difference between the size and overread is less than 0.

@Yuhta Can you help to review again? Thanks for your help.


hsevm: v0.3.2 -> v0.6.4

Motivation for this change
Features etc, but also Cabal version bound fixes to make build work.
Things done

[x] Tested using sandboxing
(nix.useSandbox on NixOS,
or option build-use-sandbox in nix.conf
on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] Linux

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Fits CONTRIBUTING.md.

Fails to build for me:
configuring hsevm-0.3.2...
Setup: Encountered missing dependencies:
brick >=0.17.2 && <0.18, vty ==5.15.*
builder for ‘/nix/store/7phd9xrzl0zl7r57ssxz25d7mc42ik4a-hsevm-0.3.2.drv’ failed with exit code 1
error: build of ‘/nix/store/7phd9xrzl0zl7r57ssxz25d7mc42ik4a-hsevm-0.3.2.drv’ failed

@fpletz that looks like your computer tried to build the previous version that this commit upgrades from!

Oh, well… I've been checking too many PRs in parallel. Sorry. :)


Doc issue

On this page you have
For multinode systems, the user portal URL is formatted as https://management..
I believe this should be
For multinode systems, the user portal URL is formatted as https://portal..

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 2d05155b-09e6-313e-de80-44de4eee68a3
Version Independent ID: 4f8eacf4-5ecb-4e15-5535-e0ca289b0c77
Content: Configure multi-tenancy in Azure Stack Hub - Azure Stack Hub
Content Source: azure-stack/operator/enable-multitenancy.md
Service: azure-stack
Sub-service: azure-stack-hub
GitHub Login: @BryanLa
Microsoft Alias: bryanla

@brcart Thank you for bringing this to our attention!  It looks like we have different text for the portal versus PowerShell.  We'll get a PR out to address that.
Portal

PowerShell

Thanks for this feedback @brcart. I've gone ahead and fixed this - it should republish later today.
#please-close


Unclear documentation for scipy.special.lpmn

There was an issue thread a few years ago about this same uncertainty with scipy.special.lpmv, as to whether or not the Condon-Shortley phase was included. The documentation only saying it calculates the associated Legendre polynomials and their derivatives, with no accompanying equation or note that the phase is included, is pretty unclear.
For the record, the specfun.lpmns code called in scipy.special.lpmn does appear to include the Condon-Shortley phase, and I think the documentation really would benefit from including this.

Hi @thezoltan94
It looks like the latest scipy release does indeed include a sentence in the notes:
https://github.com/scipy/scipy/blob/1ff7107669f3f861197fe47354c3a320e68d0147/scipy/special/add_newdocs.py#L6693
you can check your scipy version by starting your python environment and running:
import scipy
print(scipy.__version__)

and check, if you have 1.4.0 you should see the sentence.
It looks like that line has been in the special package for a couple years based on this commit:
https://github.com/scipy/scipy/commit/ca9d7fca69a683b5394f27f86f43c7a6a535dd7a
Perhaps you have an older version prior to adding that into the docs?

Question was answered and no further follow-up, so I'll close this. Thanks both.

Reopening this as the question was not answered. The above reference to the docs is a note for lpmv() rather than lpnm()


Make backend code respond correct JSON when creating PR

Fix #25351

Has some test failures.

Looks like there is no frontend changes?

Has some test failures.

Fixed the tests

Looks like there is no frontend changes?

Frontend has changed ahead.

Auto merge doesn't work due to " docker-dryrun Expected — Waiting for status to be reported "

Auto merge doesn't work due to " docker-dryrun Expected — Waiting for status to be reported "

Strange, as per https://github.com/go-gitea/gitea/pull/25329#issuecomment-1596398551, the check should have been removed.


Delete extracted files when loading dataset

Close #2481, close #2604, close #2591.
cc: @stas00, @thomwolf, @BirgerMoell

Sure @stas00, it is still a draft pull request. :)

Yes, I noticed it after reviewing - my apologies.

The problem with this approach is that it also deletes the downloaded files (if they need not be extracted). 😟

The problem with this approach is that it also deletes the downloaded files (if they need not be extracted). worried

Right! These probably should not be deleted by default, but having an option for those users who are tight on disc space?

Right! These probably should not be deleted by default, but having an option for those users who are tight on disc space?

I propose leaving that for another PR, and leave this one handling only with "extracted" files. Is it OK for you? :)

Awesome thanks !
I just have one question: what about image/audio datasets for which we store the path to the extracted file on the arrow data ?
In this case the default should be to keep the extracted files.
So for now I would just make keep_extracted=True by default until we have a way to separate extracted files that can be deleted and extracted files that are actual resources of the dataset.

@lhoestq, current implementation only deletes extracted "files", not extracted "directories", as it uses: os.remove(path). I'm going to add a filter on files, so that this line does not throw an exception when passed a directory.
For audio datasets, the audio files are inside the extracted "directory", so they are not deleted.

I'm still more in favor of having keep_extracted=True by default:

When working with a dataset, you call load_dataset many times. By default we want to keep objects extracted to not extract them over and over again (it can take a long time). Then once you know what you're doing and you want to optimize disk space, you can do keep_extracted=False. Deleting the extracted files by default is a regression that can lead to slow downs for people calling load_dataset many times, which is common when experimenting
This behavior doesn't sound natural as a default behavior. In the rest of the library, things are cached and not removed unless you explicitly say do (map caching for example). Moreover the function in the download manager is called download_and_extract, not download_and_extract_and_remove_extracted_files

Let me know what you think !

I think the main issue is that after doing some work users typically move on to other datasets and the amount of disc space used keeps on growing. So your logic is very sounds and perhaps what's really needed is a cleansweep function that can go through all datasets and clean them up to the desired degree:

delete extracted files
delete source
delete old unaccessed datasets in 6 months?
more?

So a user can launch a little application, choose what they want to clean up and voila they have just freed up a huge amount of disc space. Makes me think of Ubuntu Tweak's Janitor app - very useful.
At the moment, this process of linting is very daunting and error-prone, especially due to all those dirs/files with hash names.

@stas00 I've had the same idea. Instead of the full-fledged app, a simpler approach would be to add a new command to the CLI.

oh, CLI would be perfect. I didn't mean to request a GUI-one specifically, was just using it as an example.
One could even do a crontab to delete old datasets that haven't been accesses in X months.

@lhoestq I totally agree with you. I'm addressing that change.
@stas00, @mariosasko, that could eventually be addressed in another pull request. The objective of this PR is:

add an option to pass to load_dataset, so that extracted files are deleted
do this deletion file per file, once the file has been already used to generate the cache Arrow file

I also like the idea of having a CLI tool to help users clean their cache and save disk space, good idea !


Issues with SSR

Usage in Nuxt fails due to the dependency on document
There should be a built in check for SSR to ignore style injection in a node context.

@genu @whipsterCZ @michelle-article
This issue was probably resolved in v1.0.0. If it continues to occur, please open it again.


The animate function should not trigger a rotation if called multiple times with same properties

Describe the bug
The animate function should not trigger a rotation if it is called with the exact same animate properties.
When I run the following animation multiple times:
view.animate({
  zoom: 7,
  center: fromLonLat([14.250512, 51.433444]),
  rotation: -6,
});

Everything is fine and the second animation does nothing as expected.
To Reproduce
Replace rotation: -6 in the previous example with rotation: -6.2 and the animation restarts from 0 although the first animation should have set the rotation already to -6.2 and the second call should not trigger an animation. At least this was my understanding.
You can try it out via clicking "rotate clockwise" multiple times here. And the "counterclockwise" button is the expected behaviour - i.e. it won't do anything if clicked on it multiple times.
Expected behavior
The second animation with the same rotation property should not rotate.

It does not happen if constrainRotation: false is specified in the view options.  Unless constrainRotation: false is specified the view will snap to 0 with any user interaction or when an animation starts if it is within 5 degrees of 0.

This makes sense from a code point of view but it is still quite counter-intuitive. Maybe we could improve developer experience on this specific case?

This makes sense from a code point of view but it is still quite counter-intuitive. Maybe we could improve developer experience on this specific case?

It is not specific to this case.  The same happens if an animation exceeds other constraints, such as view extent.  The view remains in that state until a user interaction or another animation is triggered before snapping back to comply with the constraint.  The only exception seems to be multiWorld: false, which is enforced during animations (and also has no smooth option).


waybar: symbol lookup error: waybar: undefined symbol: g_once_init_leave_pointer

error: waybar: symbol lookup error: waybar: undefined symbol: g_once_init_leave_pointer
Just installed waybar in Arch. And I am getting this. I used to use waybar-git from aur before.
That's the latest version i am running.
1 extra/waybar 0.10.0-3 [0B 1.80MiB] [Installed]

Did a full system update and it fixed the issue. Idk what that was.


alert: tackle the false-postive case where alerting gc not work.

What is changed and how it works?

Issue Number: Close #15796
What's Changed:
Tackle the false-postive case by extending the checking interval of the Gc can not work alerting.

Related changes

PR to update pingcap/docs/pingcap/docs-cn:
Need to cherry-pick to the release branch

Check List
Tests

Unit test
Integration test
Manual test (add detailed scripts or steps below)
No code

Side effects

Performance regression

Consumes more CPU
Consumes more MEM

Breaking backward compatibility

Release note
None

/cc @AndreMouche PTAL

/merge