ISPN-12261 Protocol Management

https://issues.redhat.com/browse/ISPN-12261

I've now added docs /cc @oraNod

I've now added docs /cc @oraNod

@tristantarrant can you rebase this?

@tristantarrant can you rebase this?

@tristantarrant needs rebase

@pruivo I've made the changes

@tristantarrant needs rebase :(

@pruivo I've rebased and addressed all issues

@tristantarrant there is bug somewhere. The protostream is not being registered soon enough

start server1
enable IP-filter (I used the following CLI command): server connector ipfilter set endpoint-default --rules=ACCEPT/<IP_ADDRESS>/32)
start server2

server2 fails to start with
11:14:47,085 ERROR (jgroups-11,pedro-desktop-25804) [org.infinispan.CLUSTER] ISPN000474: Error processing request 20@pedro-desktop-18635 java.lang.IllegalArgumentException: Unknown type id : 5403

on server1
11:14:47,071 INFO  (jgroups-5,pedro-desktop-18635) [org.infinispan.CLUSTER] [Context=org.infinispan.CONFIG]ISPN100002: Starting rebalance with members [pedro-desktop-18635, pedro-desktop-25804], phase READ_OLD_WRITE_ALL, topology id 7
11:14:47,089 ERROR (jgroups-5,pedro-desktop-18635) [org.infinispan.statetransfer.OutboundTransferTask] Failed to send entries to node pedro-desktop-25804: ISPN000217: Received exception from pedro-desktop-25804, see cause for remote stack trace org.infinispan.remoting.RemoteException: ISPN000217: Received exception from pedro-desktop-25804, see cause for remote stack trace
...
Caused by: java.lang.IllegalArgumentException: Unknown type id : 5403

I am now registering the serialization context in the server's lifecycle callback.

@oraNod should we add a "Server IP filtering" section to the security docs?
here: https://infinispan.org/docs/stable/titles/security/security.html

@pruivo Yes, but let's do that with a separate PR. I've opened this issue: https://issues.redhat.com/browse/ISPN-12701

@pruivo I have made the following changes:

added includeCurrentState = true to ConnectorIpFilterListener  so that it applies state on join
ProtocolServers now can have a parent
IP Filters can be applied to Hot Rod connectors when they are bound to a single port endpoint

what about other listeners? Shouldn't the connector listener apply the state from other nodes? Ignore caches can receive the same treatment :)
can we have IP filters for the REST connector too?

* what about other listeners? Shouldn't the connector listener apply the state from other nodes? Ignore caches can receive the same treatment :)

Right, I'll do that.

* can we have IP filters for the REST connector too?

I'll try to make that work: the Single Port endpoint is effectively the REST connector in disguise with an additional handler for the Hot Rod detection. This means we need to have two ipfilter handlers: one at the front and one after the Hot Rod detector

@pruivo I've made the following changes:

the filter is now called AccessControlFilter and can handle filters as well as enabling/disabling the connector
attempting to stop the connector from the connector itself is refused
attempting to install a rejection filter for the connector which would close the connection is refused

I found some authorization issues. I guess some doAs() are missing .
config:
      <security>
         <authorization>
            <identity-role-mapper />
            <role name="admin" permissions="ALL" />
            <role name="reader" permissions="READ" />
            <role name="writer" permissions="WRITE" />
            <role name="supervisor" permissions="READ WRITE EXEC"/>
         </authorization>
      </security>

User created like this:
[disconnected]> user create admin -p admin -g admin
[disconnected]> connect
Username: admin
Password: *****

Unable to descript "endpoint-default"

[pedro-laptop-3-52395@cluster//containers/default]> server connector describe REST-rest-default
{
  "name" : "REST-rest-default",
  "enabled" : true,
  "ip-filter-rules" : [  ]
}
[pedro-laptop-3-52395@cluster//containers/default]> server connector describe HotRod-hotrod-default
{
  "name" : "HotRod-hotrod-default",
  "enabled" : true,
  "ip-filter-rules" : [  ]
}
[pedro-laptop-3-52395@cluster//containers/default]> server connector describe endpoint-default
The user is not allowed to access the server resource: ISPN000287: Unauthorized access: subject 'null' lacks 'ADMIN' permission

Unable to clear/ser ipfilters

[pedro-laptop-3-52395@cluster//containers/default]> server connector ipfilter set REST-rest-default --rules=ACCEPT/<IP_ADDRESS>/8
The user is not allowed to access the server resource: ISPN000287: Unauthorized access: subject 'null' lacks 'ADMIN' permission
[pedro-laptop-3-52395@cluster//containers/default]> server connector ipfilter set HotRod-hotrod-default  --rules=ACCEPT/<IP_ADDRESS>/8
The user is not allowed to access the server resource: ISPN000287: Unauthorized access: subject 'null' lacks 'ADMIN' permission
[pedro-laptop-3-52395@cluster//containers/default]> server connector ipfilter clear HotRod-hotrod-default
The user is not allowed to access the server resource: ISPN000287: Unauthorized access: subject 'null' lacks 'ADMIN' permission

Unable to start/stop connectors

[pedro-laptop-3-52395@cluster//containers/default]> server connector start endpoint-default
The user is not allowed to access the server resource: ISPN000287: Unauthorized access: subject 'null' lacks 'ADMIN' permission
[pedro-laptop-3-52395@cluster//containers/default]> server connector start HotRod-hotrod-default
The user is not allowed to access the server resource: ISPN000287: Unauthorized access: subject 'null' lacks 'ADMIN' permission
[pedro-laptop-3-52395@cluster//containers/default]> server connector start REST-rest-default
The user is not allowed to access the server resource: ISPN000287: Unauthorized access: subject 'null' lacks 'ADMIN' permission
[pedro-laptop-3-52395@cluster//containers/default]> server connector stop endpoint-default
Error: Connector matches request address
[pedro-laptop-3-52395@cluster//containers/default]> server connector stop HotRod-hotrod-default
The user is not allowed to access the server resource: ISPN000287: Unauthorized access: subject 'null' lacks 'ADMIN' permission
[pedro-laptop-3-52395@cluster//containers/default]> server connector stop REST-rest-default
Error: Connector matches request address

I've addressed all of the issues, as well as securing some more of the server endpoints

@tristantarrant is this change intentional?
[disconnected]> user create pedro -p pedro -g reader
[disconnected]> user create admin -p admin -g admin
[disconnected]> connect
Username: pedro
Password: *****
The user is not allowed to access the server resource: ISPN000287: Unauthorized access: subject 'Subject with principal(s): [pedro, RolePrincipal{name='reader'}]' lacks 'ADMIN' permission
[disconnected]>

non-admin users can't use the CLI anymore.

the ipfilter/connector stop&start still don't have a state transfer

includeCurrentState=true => it is only supported for clustered listeners

also, would it be possible to add enabled=true|false to the connector describe? I mean, for rest & hot rod.
[pedro-laptop-3-27252@cluster//containers/default]> server connector stop HotRod-hotrod-default
[pedro-laptop-3-27252@cluster//containers/default]> server connector ipfilter set REST-rest-default --rules=REJECT/<IP_ADDRESS>/16
[pedro-laptop-3-27252@cluster//containers/default]> disconnect
[disconnected]> connect <IP_ADDRESS>:11322
Username: admin
Password: *****
[pedro-laptop-3-51674@cluster//containers/default]> server connector describe endpoint-default
{
  "name" : "endpoint-default",
  "ip-filter-rules" : [  ],
  "host" : "<IP_ADDRESS>",
  "port" : 11322,
  "local-connections" : 1,
  "global-connections" : 1,
  "io-threads" : 16,
  "pending-tasks" : 0,
  "total-bytes-read" : 0,
  "total-bytes-written" : 0,
  "send-buffer-size" : 0,
  "receive-buffer-size" : 0,
  "enabled" : true
}
[pedro-laptop-3-51674@cluster//containers/default]> server connector describe REST-rest-default
{
  "name" : "REST-rest-default",
  "ip-filter-rules" : [  ]
}
[pedro-laptop-3-51674@cluster//containers/default]> server connector describe HotRod-hotrod-default
{
  "name" : "HotRod-hotrod-default",
  "ip-filter-rules" : [  ]
}

@pruivo I've made the listeners clustered and postponed registration so they now work.
I've also fixed the security issue.
I really need to refactor the server startup and the single port router config to make them simpler...

nit:
sed @since 12.0 => @since 12.1 in the following classes:
IpFilterConfiguration
IpFilterRule
ServerStateManager
DummyServerStateManager
IpSubnetFilterRuleTest

Done

@tristantarrant looks good to me :+1: .
I'm not sure if others want to take a look or not.
If you need this merged, just ping me (after CI is done)

@pruivo I've made the relevant changes

Failures are unrelated

integrated! thanks @tristantarrant :tada:

I feel like congrats are in order @tristantarrant this one was epic :taco:


[settings] explicitly forbid to use both Set and Add on the given key

Currently Settings API defines two functions which create/update/add a record.

otPlatSettingsSet()
otPlatSettingsAdd()

In the current OpenThread implementation, above APIs are always used exclusively for given keyId. In fact, otPlatSettingsAdd() is only used for storing a new entry in Child Table.
However, the API description for Set function says: If there was more than one value previously associated with aKey, then they are all deleted and replaced with this single entry.
For certain platforms and KVS implementations, this requirement translates to perform both Delete (or if Count > 1 then Delete)  and Add/Update operations, which may cause unnecessary cpu and flash operations - compare to just performing Add/Update operation (if we would be sure that otPlatSettingsAdd was not called before on the given keyId).
I wonder, if we could change the API descirption to have a contract that on the specific keyId either otPlatSettingsSet() or otPlatSettingsAdd() operation can be used, but never both of them.

Evaluating Count > 1 takes one flash read, and it is always false for setting keys that do not use otPlatSettingAdd() so there should be no Delete.
Is it really a concern?

Evaluating Count > 1 takes one flash read, and it is always false for setting keys that do not use otPlatSettingAdd() so there should be no Delete.
Is it really a concern?

Thanks for the feedback @simonlingoogle. This is possible, however evaluating Count_Entries(keyId) > 1 may take quite a lot of time on some platforms, especially if there is quite a lot of entries already stored.
As you correctly pointed out, this evaluation will return always false for current OT implementation - but API documentation theoretically does not forbid OT core to change this behavior. That's why I would like to consider changing the contract in the API documentation for the future. I don't think that removing otPlatSettingAdd is necessary.

I wonder, if we could change the API descirption to have a contract that on the specific keyId either otPlatSettingsSet() or otPlatSettingsAdd() operation can be used, but never both of them.

@LuDuda I think what are you proposing sounds good and reasonable to me.
OT stack either uses a settings key as a single-value property or a list-based property.
We should require such a contract for any key id (not tied to any specific key - in general I think platform should not care or be aware of what each key means or represents).
Maybe something like this:
OT stack guarantees that to use otPlatSettingsSet() for a aKey that was either previously set usingotPlatSettingsSet() (i.e., contains a single value) or is empty and/or fully deleted (contains no value). Platform layer can rely and use this fact for optimizing its implementation .
And then something similr for otPlatSettingsAdd().
@jwhui any concern?

Being unfamiliar with how Settings work, I wonder why otPlatSettingsAdd is necessary as an interface.
Having to implement both Set and Add may complicate the platform implementation.
I think we can implement Add functionality by only using Set .

@simonlingoogle, it make sense for platform to implement Add since they can do this more efficiently (can use different approaches based on the capability of the underlying settings mechanism). It is an unordered list and items can be removed in any order.

One thing to consider is that we can only guarantee this behavior (not use Set and Add for same key) from OT stack.
If the otPlatSettings APIs happen to be used by app layer code (above OT stack) or maybe internally in platform implementation, we cannot know how they may be used. Though I found it unlikely that a key is used as both single-value and list-based model.
Technically all otPlat APIs are only intended for use by OT stack but I know they have been cases where the OT platform APIs were used by app or platform layer code. This is something that I highly discourage.

One thing to consider is that we can only guarantee this behavior (not use Set and Add for same key) from OT stack.

Agree. We can add such restriction to the API contract.

If the otPlatSettings APIs happen to be used by app layer code (above OT stack) or maybe internally in platform implementation, we cannot know how they may be used. Though I found it unlikely that a key is used as both single-value and list-based model.

App developers should read the API doxygen and use API correctly. Platform code should already honor its own implementation restrictions.
Maybe it's fine to define such restriction in API contracts after all.

Thank you! I will create a PR with proposed changes.


Micro SD Card

hey there i have a question regarding the format of the Micro SD Card? I formatted my 8 GB SD Card to FAT 16; it should work like that right?
Thanks :)

You can always format it directly on the performer to make sure it has the correct file system.


Update to Emerge gradle plugin 4.0.0

#128  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @rbro112 and the rest of your teammates on  Graphite


Send me my bitcoin to paypal.me/ashnic12

paypal.me/ashnic12

Patch

Tha is guys

Access to<EMAIL_ADDRESS>

Access to merge pull giveth<EMAIL_ADDRESS>

bc1qchl0dursnqqjwzma38kqfkhumtju5jjnzqwgx4


jnp.linalg.inv gave incorrect results

Description
I was trying to use jax.numpy.linalg.inv as a replacement for numpy.linalg.inv but found that jax.numpy.linalg.inv behaved differently from numpy.linalg.inv and gave incorrect results for matrix inversion. See below for a reproducible example:
from jax import numpy as jnp
import numpy as np
from jax.numpy.linalg import inv as jnp_inv
from numpy.linalg import inv as np_inv

def kernel_np(X1, X2, l, sigma_f):
    X1 = np.expand_dims(X1, axis=1)
    X2 = np.expand_dims(X2, axis=1)
    sqdist = np.sum(X1 ** 2, 1).reshape(-1, 1) + np.sum(X2 ** 2, 1) - 2 * np.dot(X1, X2.T)
    return sigma_f ** 2 * np.exp(-0.5 / l ** 2 * sqdist)

def kernel_jnp(X1, X2, l, sigma_f):
    X1 = jnp.expand_dims(X1, axis=1)
    X2 = jnp.expand_dims(X2, axis=1)
    sqdist = jnp.sum(X1 ** 2, 1).reshape(-1, 1) + jnp.sum(X2 ** 2, 1) - 2 * jnp.dot(X1, X2.T)
    return sigma_f ** 2 * jnp.exp(-0.5 / l ** 2 * sqdist)

# np matrix inverse
X_train = np.linspace(0, 5, num=11)
Y_train = np.tanh(X_train)
K_np = kernel_np(X_train, X_train, 1.3773659885652723, 1.0147686098215838)
K_np_inv = np_inv(K_np)

# jnp matrix inverse
X_train_jnp = jnp.asarray(X_train)
Y_train_jnp = jnp.asarray(Y_train)
K_jnp = kernel_jnp(X_train_jnp, X_train_jnp, 1.3773659885652723, 1.0147686098215838)
K_jnp_inv = jnp_inv(K_jnp)

Multiplying the original matrix with its jnp inverse matrix does not return an identity matrix:
(K_jnp.dot(K_jnp_inv) - jnp.eye(K_jnp.shape[0])).max()
Out[19]: Array(1.5, dtype=float32)

but numpy.linalg.inv gave the correct results:
(K_np.dot(K_np_inv) - np.eye(K_np.shape[0])).max()
Out[21]: 1.6896939953329645e-09

What jax/jaxlib version are you using?
jax-0.4.1, jaxlib-0.4.1
Which accelerator(s) are you using?
GPU
Additional system info
Python 3.9.5
NVIDIA GPU info
+-----------------------------------------------------------------------------+
| NVIDIA-SMI 470.103.01   Driver Version: 470.103.01   CUDA Version: 11.4     |
|-------------------------------+----------------------+----------------------+
| GPU  Name        Persistence-M| Bus-Id        Disp.A | Volatile Uncorr. ECC |
| Fan  Temp  Perf  Pwr:Usage/Cap|         Memory-Usage | GPU-Util  Compute M. |
|                               |                      |               MIG M. |
|===============================+======================+======================|
|   0  Tesla T4            Off  | 00000001:00:00.0 Off |                    0 |
| N/A   41C    P0    26W /  70W |   1350MiB / 15109MiB |      0%      Default |
|                               |                      |                  N/A |
+-------------------------------+----------------------+----------------------+

+-----------------------------------------------------------------------------+
| Processes:                                                                  |
|  GPU   GI   CI        PID   Type   Process name                  GPU Memory |
|        ID   ID                                                   Usage      |
|=============================================================================|
+-----------------------------------------------------------------------------+

Thanks for the question – this comes from the fact that JAX defaults to 32-bit computations which are more friendly on accelerators. If you enable X64 mode before running your computation, you'll see that the JAX accuracy is consistent with that of NumPy:
>>> (K_jnp.dot(K_jnp_inv) - jnp.eye(K_jnp.shape[0])).max()
DeviceArray(1.14232535e-09, dtype=float64)

>>> (K_np.dot(K_np_inv) - np.eye(K_np.shape[0])).max()
1.6896939953329645e-09

Thanks! That worked.


Add interest topic

https://trello.com/c/9gtwSbOM/1133-add-interest-topic-to-subject-token

Was tested with: runner, schedule, replay, worker(http), worker(k8s)


Add onreact trigger type

Suggestion: Add onreact trigger type that takes 2 trigger forms
1st form: Message to watch required, message ID
2nd form: Emote to trigger optional
Variables to be passed:
User ID (who reacted/triggered)
Emote reacted (what emote was used)
React Count (for individual emotes)
Also trigger type onunreact would be good
How it would look like:

suggestion by caskd

Yup, would be really helpful!

I recommend that there is an "Events" trigger type category and under that there are things such as on react. on unreact, on role given / taken.

go for it


issue collector for documentation/online issues

this is a collection of low-priority issues related to documentation.

The online page about building gasnet should refer to the StanfordLegion/gasnet project and tell how to build gasnet that way

Closing this as it's being subsumed into the new documentation tracking bug(s).


Why input size is d × (T · H · W )  ?

Some questions:

In Section 3.1, you use d × (T · H · W ) as input size. Why not  T × (d · H · W )?
CNN feature is reshaped to B×C×THW. However, the input token size is HW × B  × C  for transformer encoder in code. It seems confusing.

hi @WinstonDeng

The d is the number of the feature dimension, we want to take the whole video as a whole, i.e., the spatial and temporal features should be flattened together to 1 dimension, therefore we use d × (T · H · W ).
Don't know what you mean by "input token size is HW × B × C". As we modified our 3D feature to suit the 2D version of transformer code, the names in the transformer encoder are confusing, please ignore it.

@Epiphqny, great thanks for your reply!
For question1:
The reason why I'm confused is that the transformer model in DETR  seems to be different from the traditional seq2seq transformer.
In seq2seq model, input for encoder is (B,Encode_Seq_Len,C),  and input for decoder is (B,Decode_Seq_Len,C) when training.
Thus, taking the encoder for an example, Multihead-Attention captures relationships between input seq items. Following this theory, T × (d · H · W ) is an intuitive idea instead of d × (T · H · W ).
Another difference is that DETR and VisTR use non-autoregress schema for decoding stage, so that you can predict all results directly.
I'm not clear about the reasons.
For question2:
In models/transformer.py, line 47
def forward(self, src, mask, query_embed, pos_embed):
        # flatten NxCxHxW to HWxNxC
        bs, c, h, w = src.shape
        src = src.flatten(2).permute(2, 0, 1)
        pos_embed = pos_embed.flatten(2).permute(2, 0, 1)
        query_embed = query_embed.unsqueeze(1).repeat(1, bs, 1)
        mask = mask.flatten(1)

        tgt = torch.zeros_like(query_embed)
        memory = self.encoder(src, src_key_padding_mask=mask, pos=pos_embed)
        hs = self.decoder(tgt, memory, memory_key_padding_mask=mask,
                          pos=pos_embed, query_pos=query_embed)
        return hs.transpose(1, 2), memory.permute(1, 2, 0).view(bs, c, h, w)

@WinstonDeng For question2 , As shown in https://github.com/Epiphqny/VisTR/blob/cfa6fa9391338ae8ef7365b40ee06777a9d41e95/models/segmentation.py#L93, the dimension of h and w has already been flattened to suit the transformer, therefore the HW of transformer code is not the real h w.

I got it.
The attention map size is thw*thw according to your config, thus you can model spatial-temporal interactions.
Thanks again!


Generate Private Key not working

Hello
I have installed Open SSL under C:/Program Files and then also done copy/paste both the files libeay32.dll, ssleay32.dll. But after that when I am trying to do this
#Generate private key
openssl genrsa -aes256 -out key\private.key 2048
Its showing could not open open ssl. Please help.

Hello @Rituparna007,
Thanks to continue to discuss into the  issue you've  already created here https://github.com/Cocolabs-SAS/cocorico/issues/393


Remove unnecessary DQL date functions in Doctrine

I think I used them back when the project was built using MongoDB. It's no more necessary.
Related https://github.com/j0k3r/f43.me/issues/1083

Coverage remained the same at 97.426% when pulling 7f712725375a8b3695549d49dc86d0d1baf1ea80 on fix/remove-dql-date into ff006b92731dfac198fabe6c61eb00db454c7121 on master.


tocdata package incompatible

Data added with the tocdata is tagged as Artifact (not necessarily an issue, not sure) and suppressed entirely if in line with the dotted line as it is with lof or lot.
\DocumentMetadata
  {
    lang=en-US,
    pdfversion=2.0,
    pdfstandard=ua-2,
    testphase={phase-III,math,title,table,firstaid}
  }
\documentclass{article}

\usepackage{tocdata}
\usepackage{hyperref}

\title{tocdata tagging test}

\begin{document}

\tableofcontents

\listoffigures

\tocdata{toc}{Some author}
\section{Some section}
\subsection{Some subsection}

\tocdata{toc}{Another author}
\section{Another section}

\begin{figure}
Content.
\tocdata{lof}{Some author}
\caption{Some figure}
\end{figure}

\begin{figure}
Content.
\captionauthor{Some figure}{Some}{Author}
\end{figure}

\end{document}

The package does correctly warn
Package tocdata Warning: Could not patch LaTeX core \@dottedtocline.
(tocdata)                Authors may not appear in TOC, LOF.

to me that sounds as if it should be labeled as currently incompatible


chore: release 1.12.0

:robot: I have created a release beep boop
1.12.0 (2024-10-04)
Features

bigquery: bump cloud.google.com/go/bigquery from 1.62.0 to 1.63.1 (#204) (882d8b6)
redshift: bump github.com/aws/aws-sdk-go-v2/service/redshiftdata from 1.27.3 to 1.29.4 (#206) (408beec)

Miscellaneous

bump go version to 1.23 (#205) (84d0de7)
deps: bump github.com/aws/aws-sdk-go-v2/config from 1.27.35 to 1.27.40 (#207) (8a8f430)
deps: bump github.com/aws/aws-sdk-go-v2/service/sts from 1.30.8 to 1.31.3 (#202) (4d6aee0)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/rudderlabs/sqlconnect-go/releases/tag/v1.12.0 :sunflower:


Resurrect TestPASESession unit test

Problem
TestPASESession unit test is disabled.
Summary of Changes
The PASE session code was modified to use exchange context. This required reworking of test transport plumbing.

rebased


[#4351] Add warnings for Attribute.remove() and Attribute.getAndRemove()

Motivation:
Using Attribute.remove() and Attribute.getAndRemove() in a multi-threaded enviroment has its drawbacks. Make sure we document these.
Modifications:
Add javadocs and mark Attribute.remove() and Attribute.getAndRemove() as @Deprecated.
Result:
Hopefully less suprising behaviour.

@trustin @Scottmitch PTAL.. not sure if marking these methods as @Deprecated is needed but I wanted to stress the point.

seems kind of nasty to deprecate these unless I am using it incorrectly..?
@ChannelHandler.Sharable
public class ProxyHandler ..

    private static final AttributeKey<ClientSession> PROXY_SESSION = AttributeKey.valueOf(ProxyHandler.class.getName() + ".proxySession");

    @Override
    public void channelActive(ChannelHandlerContext context) throws Exception {
        ClientSession clientSession = new ClientSession(context.channel());
        context.attr(PROXY_SESSION).set(clientSession);
        super.channelActive(context);
    }

    @Override
    public void channelInactive(ChannelHandlerContext context) throws Exception {
        ClientSession clientSession = context.attr(PROXY_SESSION).getAndRemove();
        if (clientSession != null) {
            clientSession.onConnectionClosed();
        }
        super.channelInactive(context);
    }

    @Override
    public void channelRead0(ChannelHandlerContext context, ..) throws Exception {
        ActorTaskContext taskContext = ActorTaskContext.pushNew();
        try {
            ClientSession clientSession = context.attr(PROXY_SESSION).get();
            messageDispatcher.dispatchMessage(clientSession, message);
            ...
    }

@johnou - Can you clarify the problem here? All access is on the IO thread then there shouldn't be any concurrency.

lgtm

@Scottmitch I would argue that the Deprecated annotation should not be used to warn developers of usage but instead only if that class or method will be removed in a future release. Since all my access is on the IO thread I am going to see deprecated warnings even though there is no alternative / perferred solution..

@johnou - Good point. IMO these APIs are rather unconventional and can lead to issues as indicated in this PR. I think considering them for removal in a future release. AttributeMap having a remove method similar to the Map interface would be a more conventional approach ... @normanmaurer - should we add this as an alternative?

Yes in 4.2.

Am 24.07.2016 um 15:22 schrieb Scott Mitchell<EMAIL_ADDRESS>@johnou - Good point. IMO these APIs are rather unconventional and can lead to issues as indicated in this PR. I think considering them for removal in a future release. AttributeMap having a remove method similar to the Map interface would be a more conventional approach ... @normanmaurer - should we add this as an alternative?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

@johnou @Scottmitch so remove the @Deprecated for now ?

@normanmaurer go for it, just came to me that I can use getAndSet null :+1:

@normanmaurer come to think of it the documentation could just refer to getAndSet / remove instead..?

   @Override
    public void channelInactive(ChannelHandlerContext context) throws Exception {
        try {
            Attribute<ClientSession> attribute = context.attr(PROXY_SESSION);
            ClientSession clientSession = attribute.get(); // or getAndSet(null);
            if (clientSession != null) {
                clientSession.onConnectionClosed();
                attribute.remove();
            }
        } finally {
            super.channelInactive(context);
        }
    }

@normanmaurer apologies for taking so long to back flip but I am ok with this change now (keeping the @Deprecated annotations) now that I have found an alternative solution.

the current mindset is the API will change in the future, and use of this API is generally discouraged. It is true there is no direct replacement but I'm fine with referencing  set(null) / getAndSet(null) as "the next best thing" until we can change AttributeMap.
If we keep @Deprecated annotation should we also add something for {@deprecated ...} in the javadocs?

@Scottmitch @johnou ok cool let me do this.

@Scottmitch @johnou done... PTAL again

lgtm

lgtm

Cherry-picked into 4.1 (7f8b5f8) and 4.0 (0625986)

Belated LGTM


Add group events

PR Title/Tagline
What does this PR change and why?
How to Test

Please add or build upon a testing card to the Notion page and link it here

Important Changes

Database change / migration to run
Environment config change
Breaking API change

Related Github Issues

#[Number of Issue]
Or, remember to link to an issue on the sidebar

Related PRs

#PRNUMBER

Checklist

[ ]  Database schema docs have been updated or are not necessary
[ ]  Code follows design and style guidelines
[ ]  Code is commented with doc blocks
[ ]  Tests have been written and executed or are not necessary
[ ]  Latest code has been rebased from base branch (usually develop)
[ ]  Commits follow guidelines (concise, squashed, etc)
[ ]  Github issues have been linked in relevant commits
[ ]  Relevant reviewers (Senior Dev/EM/Designers) have been assigned to this PR

There are a couple of issues with this pull request:

The Standard Event tab and the Group Event tab are currently switched.
The organization information is not shown on the Event Page.
The event creation time on the Event Page is incorrect.
There are no fields to input the event host's contact information as we create an event, and this information is not displayed on the Event Page (We may need to rearrange the Event Information section when creating an event).

Please see this report for more details: https://go.playerzero.app/share/632b79b86e4db9da68e5a342

@ShmulTomer's comment from the other PR:
Changed the UI for the create event modal to more reflect the UI Colin sent me
Still some issues to fix:
inconsistent margins on the left and right side
email and name input box not taking up all the space it can

Blank description crashes app.  Our current server side validation process is very dangerous for optional fields, this is a reminder for me to look more into this

Wow all the issues above were fixed elegantly!! The additional labels made the fields much more understandable. Everything works perfectly and looks very neat!
One thing is that there seem to be some problems with the Standard Event: when I input all the fields and click on the "create event" button, it does not respond to me.
Please see this report for more details: https://go.playerzero.app/share/63389bd8c9268136e7aa2396


weave attach non zero exit code on success

if a command run with docker --rm fails to remove the container after a successful run docker will return a non-zero exit.
when using weave attach I frequently see
Error removing intermediate container 9b63e9a1e9bf: Driver aufs failed to remove root filesystem 9b63e9a1e9bf1aaa97d943b4c082eaa152e38d55bf1884bc28d88de1cc891f1a: rename /docker/aufs/mnt/9b63e9a1e9bf1aaa97d943b4c082eaa152e38d55bf1884bc28d88de1cc891f1a /docker/aufs/mnt/9b63e9a1e9bf1aaa97d943b4c082eaa152e38d55bf1884bc28d88de1cc891f1a-removing: device or resource busy

and the command return non-zero so our tools think the command failed, however the attach actually did go through.
the above error was coming from this line due to the --rm bug
https://github.com/weaveworks/weave/blob/master/weave#L74
docker issue https://github.com/docker/docker/issues/9665#issuecomment-121759275
info
root@zapdos:/home/zapdos#  sudo weave version
weave script 0.11.1
weave router 0.11.1
weave DNS 0.11.1
weave exec 0.11.1

root@zapdos:/home/zapdos# docker -D version && docker -D info
Client version: 1.6.0
Client API version: 1.18
Go version (client): go1.4.2
Git commit (client): 4749651
OS/Arch (client): linux/amd64
Server version: 1.6.0
Server API version: 1.18
Go version (server): go1.4.2
Git commit (server): 4749651
OS/Arch (server): linux/amd64
Containers: 650
Images: 8317
Storage Driver: aufs
 Root Dir: /docker/aufs
 Backing Filesystem: extfs
 Dirs: 9626
 Dirperm1 Supported: false
Execution Driver: native-0.2
Kernel Version: 3.13.0-29-generic
Operating System: Ubuntu 14.04 LTS
CPUs: 32
Total Memory: 58.81 GiB
Name: zapdos
ID: HHHH:IIII:MRNF:OYNJ:FZNT:X4EA:ZWQR:TF7G:EEEE:HSP6:RYBS:F3ER
Debug mode (server): false
Debug mode (client): true
Fds: 1111
Goroutines: 3753
System Time: Wed Jul 15 18:54:22 UTC 2015
EventsListeners: 1
Init SHA1:<PHONE_NUMBER>1dbf64c1111c27861111027c
Init Path: /usr/bin/docker
Docker Root Dir: /docker
WARNING: No swap limit support

As you discovered already; this is a docker bug. I can't see what we can do about this. Any suggestions?

I suggest upgrading to Docker 1.7 though.

the only suggestion I have would be to do a string search on the output (this is the workaround we are currently doing). Not sure if that is something weave would want in its logic. I can make a PR for it if this is something you want. I filed this in case other people run into the same issue.

the only suggestion I have would be to do a string search on the output

That's horrible, especially since users may expect the stdout and stderr come to contain output from the container, so you'd somehow have to remove the error message.
Are you definitely seeing this in the latest 1.7.1 Docker release? Also, have you tried different storage backends than aufs?


Error with running deploy.ps1

Good evening,
I am getting the following error when I run the PowerShell script to deploy the solution:
PackageManagement\Install-Package : No match was found for the specified search criteria and module name 'AzureADPreview'. Try Get-PSRepository to see all available registered module repositories.
At C:\Program Files\WindowsPowerShell\Modules\PowerShellGet\<IP_ADDRESS>\PSModule.psm1:1809 char:21

...          $null = PackageManagement\Install-Package @PSBoundParameters

                 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

CategoryInfo          : ObjectNotFound: (Microsoft.Power....InstallPackage:InstallPackage) [Install-Package], Exception
FullyQualifiedErrorId : NoMatchFoundForCriteria,Microsoft.PowerShell.PackageManagement.Cmdlets.InstallPackage

Failed to install module AzureADPreview
At C:\Users\X\Desktop\RequestTeam\microsoft-teams-apps-requestateam-master\Deployment\Scripts\deploy.ps1:744 char:9

    throw('Failed to install module {0}' -f $module)

    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

CategoryInfo          : OperationStopped: (Failed to install module AzureADPreview:String) [], RuntimeException
FullyQualifiedErrorId : Failed to install module AzureADPreview

When I attempt to install the module manually, I get the following error:
WARNING: Unable to resolve package source 'https://www.powershellgallery.com/api/v2'.
PackageManagement\Install-Package : No match was found for the specified search criteria and module name 'AzureADPreview'. Try Get-PSRepository to see all available registered module repositories.
At C:\Program Files\WindowsPowerShell\Modules\PowerShellGet\<IP_ADDRESS>\PSModule.psm1:1809 char:21

...          $null = PackageManagement\Install-Package @PSBoundParameters

                 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

CategoryInfo          : ObjectNotFound: (Microsoft.Power....InstallPackage:InstallPackage) [Install-Package], Exception
FullyQualifiedErrorId : NoMatchFoundForCriteria,Microsoft.PowerShell.PackageManagement.Cmdlets.InstallPackage

Any assistance is appreciated, thank you,
Hyde

Yes, I did, but for the life of my I am not sure what did it.  I ended up having to play around with it quite a bit to get it to deploy.  Thank you for following up.  If I can recall what finally did it, I will update the ticket.


Ensure that 'iocage exec' treats 'cmd' as opaque

When the string provided to 'cmd' for the 'exec' mode
contains options which match iocage's options, iocage
absorbs them instead of passing them along. This patch
adds '--' in the correct position in the 'iocage exec'
command string to ensure that iocage treats
everything afterwards as the command to be executed.
Signed-off-by: Kevin P. Fleming<EMAIL_ADDRESS>

This bug was found when a command being executed contained an option of -f, which is also an option for iocage itself.


[SPARK-36979][SQL] Add RewriteLateralSubquery rule into nonExcludableRules

What changes were proposed in this pull request?

Add RewriteLateralSubquery rule into nonExcludableRules.
Why are the changes needed?

Lateral Join has no meaning without rule RewriteLateralSubquery. So now if we set spark.sql.optimizer.excludedRules=org.apache.spark.sql.catalyst.optimizer.RewriteLateralSubquery, the lateral join query will fail with:
java.lang.AssertionError: assertion failed: No plan for LateralJoin lateral-subquery#218

Does this PR introduce any user-facing change?

no
How was this patch tested?

add test

cc @allisonwang-db @cloud-fan

Test build #144115 has started for PR 34249 at commit c2c3da2.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48593/

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48593/

It has conflicts with 3.2, @ulysses-you can you open a backport PR? thanks!

Thanks for adding this!


Break many functions out of services.ts and into their own modules.

Since many of these functions used to be inside a big closure in services.ts, I've had to add new parameters to many of them.
Note that when moving functions out I often create closure/no-closure pairs.
For example, when extracting out getDocumentHighlights, the new signature has new parameters:
export function getDocumentHighlights(typeChecker: TypeChecker, cancellationToken: CancellationToken, sourceFile: SourceFile, position: number, sourceFilesToSearch: SourceFile[]): DocumentHighlights[] {

So to satisfy the old signatures, we get parameters from the closure and then pass them in.
// Inside closure in services.ts
function getDocumentHighlights(fileName: string, position: number, filesToSearch: string[]): DocumentHighlights[] {
    synchronizeHostData();
    const sourceFilesToSearch = map(filesToSearch, f => program.getSourceFile(f));
    const sourceFile = getValidSourceFile(fileName);
    return DocumentHighlights.getDocumentHighlights(program.getTypeChecker(), cancellationToken, sourceFile, position, sourceFilesToSearch);
}

Here are the changes:
allocators.ts: 625 lines
Exports: getServicesObjectAllocator, a new function I made so that this module would need only 1 export.
classifier.ts: 982 lines
Exports: createClassifier, getSemanticClassifications, getEncodedSemanticClassifications, getSyntacticClassifications, getEncodedSyntacticClassifications
New parameters:

checkForClassificationCancellation: cancellationToken
getSemanticClassifications: typeChecker, cancellationToken, sourceFile, classifiableNames
getEncodedSemanticClassifications: typeChecker, cancellationToken, sourceFile, classifiableNames
getSyntacticClassifications: cancellationToken, sourceFile
getEncodedSyntacticClassifications: cancellationToken, sourceFile

completions.ts: 1186 lines
Exports: getCompletionsAtPosition, getCompletionEntryDetails
New parameters:

getCompletionEntryDisplayNameForSymbol: typeChecker
getCompletionEntryDetails: typeChecker, log, target, sourceFile
getCompletionsAtPosition: typeChecker, log, target, sourceFile
getCompletionData: typeChecker, log, sourceFile

documentHighlights.ts: 638 lines
Exports: getDocumentHighlights
New parameters:

getDocumentHighlights: typeChecker, cancellationToken, sourceFile

findAllReferences.ts: 1102 lines
Exports: getReferencedSymbolsForNode
New parameters:

getReferencedSymbolsForNode: typeChecker, cancellationToken

goToDefinition.ts: 257 lines
Exports: getDefinitionAtPosition, getTypeDefinitionAtPosition
New parameters:

getDefinitionAtPosition: program, sourcefile
(I didn't want to pass in the whole program, but tryResolveScriptReference requires it and I don't want to do any refactoring in this commit.)
createDefinitionFromSignatureDeclaration: typeChecker
getDefinitionFromSymbol: typeChecker
getTypeDefinitionAtPosition: typeChecker, sourceFile

jsDoc.ts: 403 lines
Exports: getJsDocCommentsFromDeclarations, getAllJsDocCompletionEntries
symbolDisplay.ts: 524 lines
Exports: getSymbolKind, getSymbolModifiers, getSymbolDisplayPartsDocumentationAndSymbolKind
New parameters:

getSymbolDisplayPartsDocumentationAndSymbolKind: typeChecker
getSymbolKindOfConstructorPropertyMethodAccessorFunctionOrVar: typeChecker
getSymbolKind: typeChecker

utilities.ts:
Has 428 lines of new utilities at the top, taken out of services.ts.
I've checked that these are all used in multiple modules (else I would have moved them to the module they are used in).
Breaking the now 1376 lines of utilities apart into logical categories will be a job for another PR.
Other changes

Many calls to program.gettypeChecker() have been replaced to just typeChecker parameter accesses. This should have no effect since getTypeChecker only has side effects the first time it is called.
Removed BreakContinueSearchType, since that doesn't seem to be used.

Are there any perf impact of these changes?

Generally looks ok to me. Though I noticed that getReferencesAtPosition and findReferences functions are not put in the findAllReferences.ts file, is it intended?
Also it seems the services.ts is still dividable, for example the navigate-to and navigate-bar related things may be grouped together, and rename, formatting, disgnostics etc. Are those planned or not necessary as for now?

Closed in favor of  #10753.


flyway unable to locate folder specified in locations option

What version of Flyway are you using?
4.0.3
Which client are you using? (Command-line, Java API, Maven plugin, Gradle plugin, SBT plugin, ANT tasks)
Command-line
What database are you using (type & version)?
mysql 5.7
What operating system are you using?
Windows 7
What did you do?
(Please include the content causing the issue, any relevant configuration settings, and the command you ran)
Ran the following from the commandline:
C:\Users\pmc2010\PycharmProjects\OperationsPortal>C:\flyway\flyway-4.0.3\flyway -configFile=C:/Users/pmc2010/PycharmProjects/OperationsPortal/flyway/flyway.conf -locations=filesystem:C:/Users/pmc2010/PycharmProjects/OperationsPortal/flyway/sql migrate
What did you expect to see?
I hoped flyway would be able to run migrations stored in a different location from the flyway install
What did you see instead?
WARNING: Unable to resolve location filesystem:C:/Users/pmc2010/PycharmProjects/OperationsPortal/flyway/sql

nm, I made a mistake in the path I used.


Update server.js

A small change to make it that it outputs "localhost:{port}" or "<IP_ADDRESS>:{port}"

This pull request is now managed with CodeReviewHub. Refresh.

:shipit:

:shipit:

:shipit:

:shipit:

:shipit:

This is really misleading and shouldn't have been merged at all. If an IP address is passed to http.listen(), node will listen on that IP, not localhost. Otherwise, node would listen on <IP_ADDRESS> (or :: on IPv6), not <IP_ADDRESS>.


Error when running Ulubis from image in shell: "Inappropriate ioctl for device"

Ubuntu: 20.04 -- Focal Fossa
SBCL: sbcl-2.0.1.debian-linux-x64 (from distribution)
The image created by cat build-ulubis.lisp | sbcl is failing to launch when run from the bash shell. If the project is loaded via ASDF and launched interactively in lisp, e.g.
;; As a local quicklisp project
(ql:quickload :ulubis-sdl)
(ulubis::run-compositor)

It works fine. Below is the backtrace, attached is the .ulubu.lisp init file (the default suggested in the readme)
ulubis.txt
:~/dev/common-lisp/egl/ulubis$ ./ulubis

Oops! Something went wrong with ulubis...we throw ourselves at your mercy! Exiting wih error:
Date/time: 2020-11-24-16:47!
An unhandled error condition has been signalled:
   #<ENOTTY OSICAT-POSIX::%IOCTL-WITH-ARG 25 :ENOTTY "Inappropriate ioctl for device">

Backtrace for: #<SB-THREAD:THREAD "main thread" RUNNING {10005F8083}>
0: (TRIVIAL-BACKTRACE:PRINT-BACKTRACE-TO-STREAM #<SYNONYM-STREAM :SYMBOL *TERMINAL-IO* {1000023AD3}>)
1: (TRIVIAL-BACKTRACE:PRINT-BACKTRACE #<OSICAT-POSIX:ENOTTY OSICAT-POSIX::%IOCTL-WITH-ARG 25 :ENOTTY "Inappropriate ioctl for device"> :OUTPUT NIL :IF-EXISTS :APPEND :VERBOSE NIL)
2: ((FLET "H0" :IN ULUBIS::INITIALISE) #<OSICAT-POSIX:ENOTTY OSICAT-POSIX::%IOCTL-WITH-ARG 25 :ENOTTY "Inappropriate ioctl for device">)
3: (SB-KERNEL::%SIGNAL #<OSICAT-POSIX:ENOTTY OSICAT-POSIX::%IOCTL-WITH-ARG 25 :ENOTTY "Inappropriate ioctl for device">)
4: (ERROR #<OSICAT-POSIX:ENOTTY OSICAT-POSIX::%IOCTL-WITH-ARG 25 :ENOTTY "Inappropriate ioctl for device">)
5: (OSICAT-POSIX:POSIX-ERROR 25 NIL OSICAT-POSIX::%IOCTL-WITH-ARG)
6: (OSICAT-POSIX::SYSCALL-SIGNAL-POSIX-ERROR #<unused argument> NIL OSICAT-POSIX::%IOCTL-WITH-ARG)
7: (OSICAT-POSIX::%IOCTL-WITH-ARG 4 19268 #.(SB-SYS:INT-SAP #X7F30298C7FF0))
8: ((:METHOD ULUBIS-BACKEND:INITIALISE-BACKEND (ULUBIS-BACKEND:BACKEND T T T)) #<ULUBIS-BACKEND:BACKEND {10047A3363}> 1920 1080 NIL) [fast-method]
9: (ULUBIS::INITIALISE)
10: ((FLET SB-UNIX::BODY :IN SAVE-LISP-AND-DIE))
11: ((FLET "WITHOUT-INTERRUPTS-BODY-14" :IN SAVE-LISP-AND-DIE))
12: ((LABELS SB-IMPL::RESTART-LISP :IN SAVE-LISP-AND-DIE))

debugger invoked on a SB-KERNEL:CASE-FAILURE in thread
#<THREAD "main thread" RUNNING {10005F8083}>:
  :SHUTTING-DOWN fell through ECASE expression.
  Wanted one of (:SUSPENDED :ACTIVE).

Type HELP for debugger help, or (SB-EXT:EXIT) to exit from SBCL.

restarts (invokable by number or by possibly-abbreviated name):
  0: [ABORT] Exit from the current thread.

(CEPL.LIFECYCLE::FROM-UNITIALIZED :SHUTTING-DOWN)
   source: (ECASE TARGET-STATE
             (:SUSPENDED (TO-SUSPENDED TARGET-STATE))
             (:ACTIVE (TO-SUSPENDED TARGET-STATE)))
0]

I don't suppose you're using an nvidia card?


interlock does not ssl_only

com.docker.lb.ssl_only is not recognized by Interlock

Deploy preview for docsdocker ready!
Built with commit f2db93ad5432c7f0d1467ce887aee74e7c92ce9f
https://deploy-preview-8181--docsdocker.netlify.com

Deploy preview for docsdocker ready!
Built with commit a12e460932c6521fc3d0c6cf618a1f0b62a078b9
https://deploy-preview-8181--docsdocker.netlify.com

Good to go. Thanks, @trapier


replace leafo/lessphp with marcusschwarz/lesserphp

This is a better maintained fork of lessphp. It seems to be fully
compatible, so this is more or less a drop in replacement.
Dokuwiki switched to this fork:
https://github.com/splitbrain/dokuwiki/pull/1969

tests pass. merging


gccgo: internal compiler error with cyclic function declaration (esoteric)

With
$ gccgo --version
gccgo (google-gccgo-257955) 8.0.1 20180223 (experimental)
Copyright (C) 2018 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.  There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

compiling the following program:
$ cat x.go
package main

func g() [g()[0]]int { panic(0) }

func main() {
}

leads to an internal compiler error:
$ gccgo x.go
gccgo: internal compiler error: Segmentation fault signal terminated program go1
Please submit a full bug report,
with preprocessed source if appropriate.
See <http://go.ext.google.com/go/> for instructions.

cc: @thanm

I hope that program is not valid Go.

I don't think it is. But it probably shouldn't crash. But certainly not important in any case. Just reporting another test case for the cycle test suite...

Related to https://github.com/golang/go/issues/25315, https://github.com/golang/go/issues/25677, https://github.com/golang/go/issues/25299. Should be able to fix them together (at least for gccgo).

I hope that program is not valid Go.

It isn't. Array lengths are defined as follows:
The length is part of the array's type; it must evaluate to a non-negative constant representable by a value of type int.

Since [g()[0]]int is an array, and g()[0] is not a constant this is not valid Go.


Misaligned rows when saving memory to file

As shown in the image below, when a user saves the memory as a file (txt file) using the "Save to file..." button in the "Memory" tab, the address column is misaligned with the data.
For example, the row with the address ending in 0x110 in the "Memory" tab in VSCode shows byte 0 as 0x43 but the saved file shows that same byte at the address ending in 0x100 instead.

Hmmm Weird. The problem started in the first two rows. The first address is duplicated in the text output.
Were these shots taken at different times? I see another problem beyond misalignment. The misaligned row does not have same data for columns 0x04

Yes, they were taken at slightly different times, I just use them to showcase the misaligned rows. The data for columns 0x04 isn't an issue.

Thanks for confirming. I was super scared when I saw that.

Should be fixed. I pushed the update to the marketplace. You should be getting it in a few hours...
Please close this issue after confirming the fid.

Look for version V0.0.19

@haneefdm Sorry for the late reply, the issue is fixed, thank you!


New Component: Swapper

Reference:
https://daisyui.com/components/swap/
Implementation should be as follows:
Should use the context API to communicate between parent/child components. This allows for an infinite number of items to toggle through. This would be useful for things like dark mode toggles where you have multiple states: system | dark | light
<Swapper state={stringValue}>
    <SwapperItem value="a">Item A</SwapperItem>
    <SwapperItem value="b">Item B</SwapperItem>
    <SwapperItem value="c">Item C</SwapperItem>
</Swapper>

Please follow our contribution guidelines when implementing any new component!
https://skeleton.brainandbonesllc.com/docs/contributions

Alternative idea: apply a Svelte action to a parent element. Then follow the same logic flow. Initially on the first item is visible, each tap toggles to the next, and when you reach the end it returns to the start to loop again.

I'll take this

I've assigned it to you. Thanks!


Crash after delete image from photo library

iOS 11.2.x
iPhone X
Hey guys, I found this issue. If you are in library section in YPImagePicker and go to native photo library of the device and delete an image, the app crash when you come back to it.

@cikpis this bug is supposed to have been fixed as well :)

YPImagePicker (2.6.0):

SteviaLayout (~> 4.2.0)

I'm using cocoapods
source 'https://github.com/CocoaPods/Specs.git'
platform :ios, '9.3'
inhibit_all_warnings!
use_frameworks!

target 'YPImagePickerTester' do
pod 'YPImagePicker'
end

I had to update my cocoapod master repo. Now I have the 2.7.2

Awesome! Cheers 👍


useRouter not updating state without useResponse

Not exactly sure what is leading to this issue.
In a functional component, using useRouter without useResponse leads to the state update not propogating to component.
Code:
import React, { useEffect } from 'react';
import { Link, useRouter, useResponse } from '@curi/react-dom';

const App = () => {
  // const { response } = useResponse();
  const router = useRouter();
  const route = router.route(router.current().response.name);
  useEffect(() => {
    console.log('App useEffect');
  }, [route]);

  return (
    <div>
		App
		<Link name="Some Link">Link</Link>
	</div>
  )
}

export default App;

App useEffect is printed only once (component mount) and not when link is followed. If I unComment the useResponse hook call then App useEffect is also printed when following the link.

This is the expected behavior.
React has an internal optimization that skips re-rendering an element if its props are the same as the previous render and its context has not changed.
My assumption is that you are rendering your App like this:
ReactDOM.render((
  <Router>
    <App />
  </Router>
), root);

in which case the App has no props, so the App will only re-render when the context has changed.
Curi uses two context providers: a router provider for accessing the router and a response provider for accessing the response/navigation objects. These are kept separately so that components that only need to access the router, like a Link, aren't forced to re-render when there is a new response.
When there is a new response, the response context is updated, so any component that accesses it (e.g. one that uses useResponse) will be re-rendered.
useRouter doesn't have the same effect; when there is a new response, the router context is still the same router object.
Does this make sense? I can update the documentation if it wasn't very clear on this.

Thanks!
I was actually using useRouter for router.current().response.name which I changed to useResponse and response.name.


V4 constants change overhaul

Pull Request Key Information
Reason for Change
In the codebase, locating constants was challenging, and there were instances where hard-coded values led to potential errors. To mitigate this issue and enhance code maintainability, introduced the usage of constants. Moreover, consolidated all constants into a single module for easy access.
Changes Made

Utilized constants where applicable to minimize errors stemming from hard-coded values.
Migrated all constants to a dedicated module for streamlined access.

Objective
The primary objective of these changes is to enhance code reliability by reducing potential errors and improving code readability and navigability.
Testing Undertaken
All existing unit tests passed and performed manual simulations
results.txt

results.txt
Unit test results after initial PR review updates/changes.

results.txt
Unit test results.


config: fix config generation

The path to the fact is not correct.
In any case, we will retrieve the IP address in hostvars, the variable
is the way we get the interface name according where it has been set
(eg.: inventory host file vs. group_vars/)
Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1510906
Signed-off-by: Guillaume Abrioux<EMAIL_ADDRESS>

@leseb done

jenkins test playbook syntax

jenkins test Docs

jenkins test playbook syntax

it looks like ovh cloud is getting trouble, merging without Docs and playbook syntax jobs anyway


Put TestEz under dev-dependencies in wally.toml

Resolves #62

This will need to update the project to place the dev packages somewhere during testing only as well as updating test runners to access it in the new location.

I think that squashed it 😬


UI: Fetch user profile for Activity Feed

Feed APIs will only give a username in the response for "created by", we should fetch the profile picture from elastic search API and render it for Activity Feeds.

Duplicate of #4543


Task003_tumor dataset cannot be trained?

I am using data from this folder:  ../DATASET_Tumor/unetr_pp_raw/unetr_pp_raw_data/Task03_tumor/Task003_tumor/nnFormerData_plans_v2.1
###############################################
self.crop_size in init train: [128 128 128]
[0.57142857 0.28571429 0.14285714]
loading dataset
loading all case properties
2023-09-15 15:03:28.663895: Using splits from existing split file: ../DATASET_Tumor/unetr_pp_raw/unetr_pp_raw_data/Task03_tumor/Task003_tumor/splits_final.pkl
2023-09-15 15:03:28.664275: The split file contains 5 splits.
2023-09-15 15:03:28.664320: Desired fold for training: 0
2023-09-15 15:03:28.664411: This split has 387 training and 73 validation cases.
unpacking dataset
done
Traceback (most recent call last):
File "../unetr_pp/run/run_training.py", line 171, in
main()
File "../unetr_pp/run/run_training.py", line 142, in main
trainer.initialize(not validation_only)
File "/home/lcl/unetr_plus_plus/unetr_pp/training/network_training/unetr_pp_trainer_tumor.py", line 150, in initialize
self.initialize_network()
File "/home/lcl/unetr_plus_plus/unetr_pp/training/network_training/unetr_pp_trainer_tumor.py", line 189, in initialize_network
model_flops = flops.total()
File "/home/lcl/anaconda3/envs/unetr_pp/lib/python3.8/site-packages/fvcore/nn/jit_analysis.py", line 248, in total
stats = self._analyze()
File "/home/lcl/anaconda3/envs/unetr_pp/lib/python3.8/site-packages/fvcore/nn/jit_analysis.py", line 583, in _analyze
op_counts = self._op_handles[kind](inputs, outputs)
File "/home/lcl/anaconda3/envs/unetr_pp/lib/python3.8/site-packages/fvcore/nn/jit_handles.py", line 181, in einsum_flop_jit
assert len(inputs) == 2, len(inputs)
AssertionError: 3

Hi, I met the same problem. Did you solve it?

Could you please share the command you use for running?
It seems there is an issue in the input shape for measuring the FLOPs. Is the training working when you comment measuring the FLOPs?


updating the pre-command code to include habitat/test

Description
This fix updates a number of things going sideways in the build process.

The pre-command file did not have proper definitions for the various pipelines, habitat-test and mac_universal, so those pipelines would just not run or and throw an error. That was corrected by updating the regex string
The Linux and Windows testers were failing because

the version of the chef-infra-client specified was wrong - corrected by getting the correct version from bldr
the correct version wasn't actually published to 'stable' on https://bldr.habitat.sh - corrected by logging into bldr and moving them to stable
the environment variable that specified the correct version was getting borked by buildkite and being interpolated into a string instead of an actual environment variable. That was corrected by moving all the code to discreet shell scripts that ran separately. For the Windows script, I added the correct bldr definition to pull down.

Related Issue

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Chore (non-breaking change that does not add functionality or fix an issue)

Checklist:

[ ] I have read the CONTRIBUTING document.
[ ] I have run the pre-merge tests locally and they pass.
[ ] I have updated the documentation accordingly.
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.
[ ] All commits have been signed-off for the Developer Certificate of Origin.

Closing, thing are fixed in https://github.com/chef/chef/pull/13649


Bumping version to 1.2.4

@marceloboeira 1.2.4 is already the current version: https://rubygems.org/gems/enumerate_it/versions/1.2.4

Well, the code shows otherwise, shouldn't the gem version be 1.2.4 at the module?
https://github.com/cassiomarques/enumerate_it/blob/49c163c7ccf46c0f49f8d8cb185a839b787a87db/lib/enumerate_it/version.rb#L2

Sorry, as I said in the PR comment, it looks like I forgot to push the changes to the code, however the new version got published. This is why you're able to install it locally. The fact that it's out dated on Github shouldn't cause any problem.

@cassiomarques you can change a tag revision at github, but I believe that wouldn't get any effect at the published version. :disappointed:

Yup, that's true.
We are currently using enumerate_it 1.2.4 in one of our projects, with the build on CircleCI, all working fine. For me it looks like a temporary problem with your CI server.

Closing, since the problem was resolved in https://github.com/cassiomarques/enumerate_it/issues/45


Plot only displays latest build

Thanks for providing this plugin!
I installed it and it works. However it only displays the plot of the latest build.
Did I do something wrong or is this a bug?

Have you checked your csv-file that contains the plot data?
Do you get multiple csv-files or is it that the file only contains one post of plot data?
I will double check the plugin as soon as possible.
The plugin has not been heavily tested but I have made some simple testing on my computer as well as the company I worked for when making the plugin.
Best regards
Markus

26 sep. 2016 kl. 10:54 skrev Yosh<EMAIL_ADDRESS>Thanks for providing this plugin!
I installed it and it works. However it only displays the plot of the latest build.
Did I do something wrong or is this a bug?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub https://github.com/MarkusDNC/plot-plugin/issues/1, or mute the thread https://github.com/notifications/unsubscribe-auth/AJyXQCNqSnOYdZHufj9vv9Ry4Q5JYjahks5qt4hRgaJpZM4KGSCC.

It is one csv file with 2 lines, header line and data line.
It looks like it doesn't remember plots of previous builds.

I have the same exact issue with this. I'm using the PlotBuilder pipeline syntax. What is the keepRecords parameter for? Would that potentially help?

I'm sorry! I have not had the time to dig deeper into this. It was a work I did during a summer and I have forgotten a lot of this and I had some help making it. I believe keepRecords is a parameter from the original Plot-plugin.


pravni fakultet u beogradu

@nitrocinema Regrettably, this request has signs of fraud. I have to close it without merging. If you are a student of this school, please apply with official document ("OFFICIAL DOCUMENT" tab at https://www.jetbrains.com/shop/eform/students).
To be precise: (1) the email domain is registered with details that make the registration suspicious;
(2) the university does not mention this email domain anywhere at the university website.


Advertise wl_seat version 7

This does not require any code changes, as we already copy the keymap
data separately for each client.
For details, see https://gitlab.freedesktop.org/wayland/wayland/commit/905c0a341ddf0a885811d19e2b79c65a3f1d210c

Relevant code: https://github.com/swaywm/wlroots/blob/460a630a43c3aa914a84e2a2a0f879f8042d6c7f/types/seat/wlr_seat_keyboard.c#L346-L373
We could implement that with proper fd sealing, but since that's linux-specific, I doubt that's going to happen.

Thanks!


Possible to disable Open Policy check?

From a recent conversation with @georgepadayatti in https://github.com/GovStackWorkingGroup/bb-consent/pull/67#issuecomment-1842852086, it appears that the policy check doesn't work and has to be disabled to make things run.
To be more specific, these are the lines that are suggested to be removed:
https://github.com/chukmunnlee/caddy-openapi/blob/8f6d29d6eb297634da9460b49c187a2b451cd45c/handler.go#L71C1-L91
@chukmunnlee I'll try to get some more input about why it's failing. Would you be interested in commenting out this code or should we run a fork without it?

Don't load any policies in your Caddyfile

Don't load any policies in your Caddyfile

Hi @chukmunnlee
Thanks for the quick response. I haven't loaded any policies in the Caddyfile. Here is the Caddyfile for reference - link.
Am I doing something wrong?

I have used for following Dockerfile to build caddy with the caddy-openapi module:
FROM caddy:2.7.3-builder AS builder

RUN xcaddy build --with<EMAIL_ADDRESS>
FROM caddy:2.7.3-alpine

COPY --from=builder /usr/bin/caddy /usr/bin/caddy

COPY consent-openapi.yaml /consent-openapi.yaml

CMD ["caddy", "run", "--config", "/etc/caddy/Caddyfile"]

At first used the module from upstream, but since the APIs were not responding I decided to remove the resolve policy code block in ServeHTTP func in my fork.

Sharing the OpenAPI yaml file if it helps in debugging here - https://github.com/decentralised-dataexchange/bb-consent-wg/blob/main/examples/igrantio/consent-openapi.yaml

@benjaoming @georgepadayatti
I've tested the code. OPA is not enable if you don't load any policies. I originally suspect your custom field x-specification-usecase, etc might have triggered the evaluation. I could not reproduce that either.
This is the repo I used from testing https://github.com/chukmunnlee/deckofcards
I ran both caddy and a server natively on my machine

caddy run --config Caddy
go run ./...
Tried curl localhost:8080/api/decks and localhost:8080/api/abc123

Since you have a Dockerfile, I though you might be deploying to k8s. I created a deployment with 1 pod, 2 containers and 1 service; port-forwarded 8080, could not reproduce the error you are discribing. See deckofcards.yaml.
Can you let me know what error you are seeing?
BTW I merged a PR for caddy-openapi but that should not affect OPA part. The PR adds a new placeholder openapi.response_error

Will check and revert with more details. Like you suspected it could be the custom extensions.

I have made a PR to handle the same - https://github.com/chukmunnlee/caddy-openapi/pull/6


(field:: data) round brackets format does not hide the field in callouts (reading mode)

What happened?
Using the format using round brackets should hide the field in reading mode.
This does not work in callouts.
DQL
No response
JS
No response
Dataview Version
0.5.41
Obsidian Version
1.0.0
OS
Windows

Cannot repro on version 5.47 in Sandbox vault. Screenshot:

> [!INFO]
> this is a callout
> (field:: value)

Sorry,
This issue happens only when the dataview info is entered in the title of the callout (I tend to use them this way to format some note "items" with frames without the wasteful title row):

Note that the data is returned perfectly in queries, this is only a visual bug.


Step by step guideline for an issue for finding an valid issue or bug!

I want someone to mention a step by step instructions on how to raise an issue and check for a bug as a beginner.

This is not the right place for this, sorry.


Remove rule label FOUNDRY.foundry.call from kevm_prove

First refactor kevm_prove so that foundry_prove can inject FOUNDRY.foundry.call  when calling the function.

Extract a function that creates the list of labels from the flags.
Pass the rule configuration directly.

Then drop the rule label from the factory function.
After addressing the issue, the kontrol team should be notified so that the corresponding changes can be made in foundry_prove.

Attaching this to the PR https://github.com/runtimeverification/kontrol/pull/161


Porting tests from PlanOut's Python implementation to Go

(1) https://github.com/facebook/planout
(2) https://github.com/URXtech/planout-golang
Porting test cases from (1) to (2).
While most of the tests/fixes have been ported, there are couple of tasks pending.
-[ ] For tests of random ops, assert on allowed distribution error.
-[ ] Port fix for max segment in namespace handling.

Merged to master. @GregBowyer


fixed #18 supporting List to List attribute conversion

Codecov Report

Merging #29 into master will increase coverage by 0.2%.
The diff coverage is 98.27%.

@@             Coverage Diff             @@
##             master      #29     +/-   ##
===========================================
+ Coverage     91.88%   92.08%   +0.2%
- Complexity      641      658     +17
===========================================
  Files            82       83      +1
  Lines          1749     1807     +58
  Branches         74       80      +6
===========================================
+ Hits           1607     1664     +57
  Misses          110      110
- Partials         32       33      +1

Impacted Files
Coverage Δ
Complexity Δ

.../dynodao/processor/schema/parse/SchemaParsers.java
100% <100%> (ø)
3 <0> (ø)
:arrow_down:

...o/processor/schema/parse/ListTypeSchemaParser.java
98.24% <98.24%> (ø)
17 <17> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ea0b6fc...c86d535. Read the comment docs.


Need a dijkstra's pathfinder

Dikstra's handles single-source many-target pathfinding better than A* and JPS (which we have implementations of).
Probably doesn't need to go through the JobQueueSystem as it will likely only ever get called by other jobs.
This is needed for (AI only):

Influence maps
Entity accessibility (so many access doors ahhhhh). Currently the AI has no knowledge of what entities are accessible and what aren't so they get stuck on saltern trying to pathfind through locked doors.
If trying to pathfind to something that's on a blocked tile but there might be an accessible one nearby.

Bonus points if you make an EntityAccessibilityManager that caches the result so it can be re-used.

Added in #1283


Adds JSCS for gulpfile and scripts

install JSCS globally npm install jscs -g
use npm run jscs
Now as far as actually fixing the issues.....
uses google styleguide: https://github.com/jscs-dev/node-jscs/blob/master/presets/google.json

lol: https://travis-ci.org/roots/roots/jobs/48082617#L451

you got an editorconfig plugin running? .jscsrc uses 4 spaces, needs to be 2
other than that, :+1:

Huh? Jscsrc is 2 spaces

currently it mixes them

@retlehs u happy now or nah?

yeah we might need something that tests json syntax for you next to get dat spacing right :+1:


setup-git-commit-signing.sh installation script fails

Running on a macbook air m2, /usr/local/bin directory does not exist.
Creating it manually then puts me into all kinds of permissions hell
❯ tea https://github.com/teaxyz/demos/blob/main/setup-git-commit-signing.sh
downloading
installed: ~/.tea/gnu.org/bash/v5.1.16

  simple setup for git GPG

  signing your commits is important for the security of the entire software industry, both open and closed

  ▌ what to expect from this script

  • installs  withoutboats/bpb † using  tea
  • add its binary to your  PATH
  • configures  git  to use it
  • help you add your GPG key to GitHub

  │ †  bpb  is a much simpler way to sign your commits than using GnuGPG
  │ https://github.com/withoutboats/bpb
installed: ~/.tea/crates.io/bpb/v1.1.0
  k first up, we’ll configure your GPG key
-----BEGIN PGP PUBLIC KEY BLOCK-----
REDACTED
-----END PGP PUBLIC KEY BLOCK-----

Password:
ln: /usr/local/bin/bpb: No such file or directory

Yeah we should check the directory exists and that it is in PATH. Maybe check for ~/.local/bin first.
We're not sure about these scripts. I'm getting to thinking that the better way is via our GUI app later this year, where people can declare integrations between packages in some kind of markdown that show up once you have multiple packages installed.


feat: at auth package

- What I did
- How I did it
- How to verify it
- Description for the changelog

Raising another PR


fix: correct name for self.silent_entities

Closes #45

@goldyfruit If you'd care to test, please, this should solve your issue

Reviewing the diff, did you find/replace all silent_entities references with silent_devices?
I like the change to properties to handle settings changes 👍

Reviewing the diff, did you find/replace all silent_entities references with silent_devices?
I like the change to properties to handle settings changes 👍

Other way around - it should be silent_entities.
I caught the properties issue when I found my tests weren't working. Love that pattern!

All good, no more error!
Aug 08 09:53:48 mark2 ovos-core[11595]: 2024-08-08 09:53:48.683 - skills - ovos_core.transformers:transform:64 - DEBUG - ovos-utterance-cancel: {}
Aug 08 09:53:48 mark2 ovos-core[11595]: 2024-08-08 09:53:48.687 - skills - ovos_core.transformers:transform:64 - DEBUG - ovos-utterance-normalizer: {'client_name': 'mycroft_cli', 'source': 'debug_cli', 'destination': ['skills'], 'lang': 'en-us'}
Aug 08 09:53:48 mark2 ovos-core[11595]: 2024-08-08 09:53:48.688 - skills - ovos_core.transformers:transform:64 - DEBUG - ovos-utterance-corrections: {'client_name': 'mycroft_cli', 'source': 'debug_cli', 'destination': ['skills'], 'lang': 'en-us'}
Aug 08 09:53:48 mark2 ovos-core[11595]: 2024-08-08 09:53:48.694 - skills - ovos_core.intent_services:get_pipeline:241 - DEBUG - Session pipeline: ['stop_high', 'converse', 'padatious_high', 'ocp_high', 'adapt_high', 'ocp_medium', 'fallback_high', 'stop_medium', 'adapt_medium', 'padatious_medium', 'adapt_low', 'common_qa', 'fallback_medium', 'fallback_low']
Aug 08 09:53:48 mark2 ovos-core[11595]: 2024-08-08 09:53:48.696 - skills - ovos_core.intent_services:handle_utterance:382 - DEBUG - no match from <bound method StopService.match_stop_high of <ovos_core.intent_services.stop_service.StopService object at 0x7f90319450>>
Aug 08 09:53:48 mark2 ovos-core[11595]: 2024-08-08 09:53:48.711 - skills - ovos_core.intent_services:handle_utterance:382 - DEBUG - no match from <bound method ConverseService.converse_with_skills of <ovos_core.intent_services.converse_service.ConverseService object at 0x7f91c79750>>
Aug 08 09:53:48 mark2 ovos-core[11595]: 2024-08-08 09:53:48.713 - skills - ovos_core.intent_services.padatious_service:_match_level:48 - DEBUG - Padatious Matching confidence > 0.95
Aug 08 09:53:48 mark2 ovos-core[11595]: 2024-08-08 09:53:48.722 - skills - ovos_core.intent_services:handle_utterance:370 - INFO - padatious_high match: IntentMatch(intent_service='Padatious', intent_type='neon_homeassistant_skill.mikejgray:turn.on.intent', intent_data={'entity': 'plafonnier'}, skill_id='neon_homeassistant_skill.mikejgray', utterance='turn on plafonnier')
Aug 08 09:53:48 mark2 ovos-core[11595]: 2024-08-08 09:53:48.729 - skills - ovos_core.intent_services:handle_utterance:388 - DEBUG - intent matching took: 0.03458356857299805
Aug 08 09:53:48 mark2 ovos-core[11595]: 2024-08-08 09:53:48.789 - neon_homeassistant_skill.mikejgray - INFO - {'utterances': ['turn on plafonnier'], 'lang': 'en-us', 'utterance': 'turn on plafonnier', 'entity': 'plafonnier'}
Aug 08 09:53:48 mark2 ovos-core[11595]: 2024-08-08 09:53:48.790 - neon_homeassistant_skill.mikejgray - INFO - Trying to turn on device plafonnier
Aug 08 09:53:48 mark2 ovos-core[11595]: 2024-08-08 09:53:48.806 - skills - ovos_bus_client.client.client:on_default_session_update:166 - DEBUG - synced default_session
Aug 08 09:53:48 mark2 ovos-core[11595]: 2024-08-08 09:53:48.902 - neon_homeassistant_skill.mikejgray - DEBUG - Handling turn on response to {'device': 'plafonnier'}

Thanks @mikejgray

When verbose is set to true, it spokes only the first sentence.
 turn on ambiance
 >> Sure thing.
 >> I turned on ambiance!

Only Sure thing. got a playback.

When verbose is set to true, it spokes only the first sentence.

 turn on ambiance

 >> Sure thing.

 >> I turned on ambiance!

Only Sure thing. got a playback.

That's a separate issue, but let's diagnose a little...did the message go over the bus? Or did it just not go out at all? Could be an audio service issue or something else, or could be here

I guess it went to the bus as its showing within the ovos-cli-client.

I guess it went to the bus as its showing within the ovos-cli-client.

If it got sent to the bus but didn't play back I think that's an OVOS-audio problem. Any logs there to indicate why it didn't play?

I guess it went to the bus as its showing within the ovos-cli-client.

If it got sent to the bus but didn't play back I think that's an OVOS-audio problem. Any logs there to indicate why it didn't play?

No error.
 turn off ambiance
 >> Okay.
 >> I turned off ambiance!

Aug 08 18:16:44 mark2 ovos-audio[17975]: 2024-08-08 18:16:44.236 - audio - ovos_audio.service:execute_tts:384 - INFO - Speak: Okay.
Aug 08 18:16:44 mark2 ovos-audio[17975]: 2024-08-08 18:16:44.249 - audio - ovos_plugin_manager.templates.tts:get_from_cache:125 - INFO - Found 2342c97172f86615a4ae27c63e4aaefc.mp3 in TTS cache
Aug 08 18:16:44 mark2 ovos-audio[19035]: /run/user/1000/tts/ovos-tts-plugin-polly/Danielle/en-us/2342c97172f86615a4ae27c63e4aaefc.mp3:
Aug 08 18:16:44 mark2 ovos-audio[19035]:  File Size: 4.22k     Bit Rate: 48.5k
Aug 08 18:16:44 mark2 ovos-audio[19035]:   Encoding: MPEG audio
Aug 08 18:16:44 mark2 ovos-audio[19035]:   Channels: 1 @ 16-bit
Aug 08 18:16:44 mark2 ovos-audio[19035]: Samplerate: 24000Hz
Aug 08 18:16:44 mark2 ovos-audio[19035]: Replaygain: off
Aug 08 18:16:44 mark2 ovos-audio[19035]:   Duration: 00:00:00.70
Aug 08 18:16:45 mark2 ovos-audio[19035]: [312B blob data]
Aug 08 18:16:45 mark2 ovos-audio[19035]: Done.

I guess it went to the bus as its showing within the ovos-cli-client.

If it got sent to the bus but didn't play back I think that's an OVOS-audio problem. Any logs there to indicate why it didn't play?

No error.
 turn off ambiance
 >> Okay.
 >> I turned off ambiance!

Aug 08 18:16:44 mark2 ovos-audio[17975]: 2024-08-08 18:16:44.236 - audio - ovos_audio.service:execute_tts:384 - INFO - Speak: Okay.
Aug 08 18:16:44 mark2 ovos-audio[17975]: 2024-08-08 18:16:44.249 - audio - ovos_plugin_manager.templates.tts:get_from_cache:125 - INFO - Found 2342c97172f86615a4ae27c63e4aaefc.mp3 in TTS cache
Aug 08 18:16:44 mark2 ovos-audio[19035]: /run/user/1000/tts/ovos-tts-plugin-polly/Danielle/en-us/2342c97172f86615a4ae27c63e4aaefc.mp3:
Aug 08 18:16:44 mark2 ovos-audio[19035]:  File Size: 4.22k     Bit Rate: 48.5k
Aug 08 18:16:44 mark2 ovos-audio[19035]:   Encoding: MPEG audio
Aug 08 18:16:44 mark2 ovos-audio[19035]:   Channels: 1 @ 16-bit
Aug 08 18:16:44 mark2 ovos-audio[19035]: Samplerate: 24000Hz
Aug 08 18:16:44 mark2 ovos-audio[19035]: Replaygain: off
Aug 08 18:16:44 mark2 ovos-audio[19035]:   Duration: 00:00:00.70
Aug 08 18:16:45 mark2 ovos-audio[19035]: [312B blob data]
Aug 08 18:16:45 mark2 ovos-audio[19035]: Done.

Interestingly, I only get the second message spoken...

Okay, when I add "verbose": true to my settings.json file, I get both replies. I only get the second otherwise. Have you set any silent_devices in your skill settings? That would cause the second reply not to be spoken.

silent_devices

Nop, here is my settings.json
{
  "disable_intents": false,
  "__mycroft_skill_firstrun": false,
  "verbose": true
}

silent_devices

Nop, here is my settings.json
{
  "disable_intents": false,
  "__mycroft_skill_firstrun": false,
  "verbose": true
}

Is this new behavior since this patch?


Fix two bugs with polygon clipping

Fixes #914
Fixes CesiumGS/cesium-unreal#1461
I should really write some tests for the bounding volume changes...

I still found a tile that didn't want to be excluded, though it seems to be a one-off?

I'm not sure. I wasn't able to find a case that was working incorrectly, but I can't promise no such case exists. At any rate, before this PR, small-ish tiles were never excluded. So this PR is surely an improvement. If we find a problem case later we'll just have to fix it then.

I wasn't sure how to reproduce the other error you were fixing (though, it seemed like it was fickle to reproduce). If there's a reliable way to see this error, I can sanity check it on my end.

The key is to use Google Photorealistic 3D Tiles and set up your clipping polygon in an area with a lot of tall buildings. Then fly around within the clipping area, zoomed in pretty close, and bits of building will randomly appear.


validation-test: correct typo in ParseableInterface.verify_all_overlays

The %{python} substitution was typoed with the % sigil being
replaced with $.

Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.

Resolves SR-NNNN.

CC: @jrose-apple @harlanhaskins

@swift-ci please smoke test and merge


Rule proposal: Enforce empty line below imports

I'm aware this is purely stylistic, but thought I'd propose it since it seems this plugin will soon expand to stylistic rules with the adoption of https://github.com/jfmengels/eslint-plugin-import-order
Fail
import foo from 'foo';
import bar from 'bar';
const unicorn = true;

const foo = require('foo');
const bar = require('bar');
const unicorn = true;

Pass
import foo from 'foo';
import bar from 'bar';

const unicorn = true;

const foo = require('foo');
const bar = require('bar');

const unicorn = true;

// @jamestalmage @jfmengels

Sounds good to me, will accept a PR.

Oh weird, expected #245 to close this but I guess it didn't mention it explicitly.


Implement Statistics Section Component

Description
Implement a statistics section in the third theme. So that user can see the statistics about an institute or organization.
Reference: https://www.figma.com/file/rX1jl4pa04VD9itnzneeih/Webiu?node-id=1%3A3
Changes proposed in the pull request

Implement statistics section component
Implement the story for the component
Create documentation for the component

Screenshots (In case of UI changes):

Types of changes

[x] New feature (non-breaking change which adds functionality)

Checklist:

[x] My code follows the code style of this project.
[x] My change requires a change to the documentation.
[x] I have updated the documentation accordingly.
[x] All new and existing tests have passed and it does not give any unexpected error for the same.

Steps to test

npm i
npm run storybook (story will be displayed in LearningManagementSystem/StatisticsSection )

Resolves https://github.com/scorelab/Webiu/issues/297

@charithccmc @dinithminura can you review the PR please :)


[feature request] Interactive request for credentials

I'd really like to not have my password in plaintext on my disk. It would be great if I could do one of the following:

get prompted for my password and TOTP code (and maybe even username) at runtime
set a command to get my password (e.g. for use with https://www.passwordstore.org/) and TOTP code

Somewhat-related:
Passwords may contain the : character, so I don't think that's a good separator for the PASSWORD env var. Maybe a separate TOTP env var should be used?

@cole-h The username and password just need to be present in the environment to be picked up by reddsaver. So, you could omit username and password from .env file. You can use an external script or a tool like direnv to set the username, password by running a command. As long as it is present in the environment, it should be picked up.
With regards to the : delimiter: that is a Reddit API setting, so I'm afraid it's something that's out of my control.

Ah, I was under the impression it only wanted to read from a .env file. That makes sense. I can do that, thanks!

Ah, I was under the impression it only wanted to read from a .env file. That makes sense. I can do that, thanks!

Great. Please file an issue in case you encounter any problems. You can use the reddsaver --show-config command to check if the variables are picked up properly.

Since TOTP changes so frequently, I had to run reddsaver with direnv exec . cargo run -- [args] which works a charm (otherwise, I'd have to cd .. and cd -, or direnv reload first). Thanks for reminding me of something so obvious!

Since TOTP changes so frequently, I had to run reddsaver with direnv exec . cargo run -- [args] which works a charm (otherwise, I'd have to cd .. and cd -, or direnv reload first). Thanks for reminding me of something so obvious!

Great! Just wanted to leave a reminder to use --release profile for cargo run to run the optimized artifact (Not sure if you're using that already)

Yep, thanks, I left that out of my hand-typed command line :P
(Though I did run it in debug mode a few times -- speed wasn't that bad for me)

Awesome! Running the release binary makes a huge difference compared to the debug binary for me.


mitotic catastrophe

mitotic catastrophe (FYPO:0001047) obsolete
mitotic catastrophe with cut, elongated cell -> rename cut, elongated cell
mitotic catastrophe with cut, normal size cell -> rename cut, normal size  cell
mitotic catastrophe with cut, small cell -> rename, cut, small cell
mitotic catastrophe, elongated cell -> merge into elongated cell (FYPO:0000017)
mitotic catastrophe, small cell  -> merge into small cell (FYPO:0000023)
mitotic catastrophe would be a  synonym of "cut" and can be added to other terms if required
@JackyVH

Transferring content from #3906
from @ValWood :

Also, this term
cut with abolished mitotic sister chromatid separation, with mononucleate and anucleate compartment formation (FYPO:0005070)
Definition | Parents
An inviable phenotype observed in the vegetative growth phase of the life cycle in which a cell undergoes septation despite abolished mitotic sister chromatid separation, producing inviable daughter cells, and in which the septum forms in a position that partitions the nucleus into one compartment. Cell separation may or may not be completed.
Is the same thing. At one point  we decided to call this  "cut" because it accompanies 'cut' but this is not a 'cut'  because the nucleus is not bisected
.
Illustrated really nicely here:
The nucleus is either 'displaced" or it is 'cut'

Update from today's meeting:

As currently defined, cut and mitotic catastrophe are different, but we may not really need the distinction the defs currently make.
Val to review annotations using mitotic catastrophe (FYPO:0001047) and any of its descendants, and make any adjustments to the list of merges etc. in the original summary.

mitotic catastrophe, elongated cell -> merge into elongated cell (FYPO:0000017)
mitotic catastrophe, small cell -> merge into small cell (FYPO:0000023)

I don't agree with these merges, because only having abnormal cell size is too much broader than abnormal size plus a big problem with mitosis (also, if it were otherwise OK, we'd merge into the "vegetative" terms).
If you don't need a distinction between "cut" and "mitotic catastrophe", we could merge

'mitotic catastrophe, elongated cell' into 'cut, elongated cell' (fka mitotic catastrophe with cut, elongated cell)
'mitotic catastrophe, normal size cell' into 'cut, normal size cell' (fka mitotic catastrophe with cut, normal size cell)
'mitotic catastrophe, small cell' into 'cut, small cell' (fka mitotic catastrophe with cut, small cell)

Or we could make FYPO:0001049-1051 obsolete along with FYPO:0001047 (all of the non-cut mitotic catastrophe terms).

Sorry, I think I'm still a little confused about FYPO:0005070 -- I'm not even sure whether it's relevant to this ticket, #3906, or both. Does anything need to be done with it?

The annotation review is done. Direct annotation fixed. The others will be handled by merges.

Or we could make FYPO:0001049-1051 obsolete along with FYPO:0001047 (all of the non-cut mitotic catastrophe terms).

OK let's do this. It is few annotations. I can review them

cut with abolished mitotic sister chromatid separation, with mononucleate and anucleate compartment formation (FYPO:0005070)
this term isn't a true cut, because the nucleus is not bisected.
I  found it after I requested the new term, and it sounds very close to what I was trying to describe, if you ignore the 'cut' part it becomes:
abolished mitotic sister chromatid separation, with mononucleate and anucleate compartment
is the same as
septated mononucleate vegetative cell with misplaced nucleus
i.e. there is no chromosome segregation, and a single nucleus  is displaced and forms an anucleate  compartment (therefore must be septated)

I don't know. It depends whether you agree that it is logically equivalent to the term I requested. The term I requested is in a different place, because it is not 'cut', but the existing term   FYPO:0005070
could possibly be repurposed?
If not,  FYPO:0005070 will need to be obsoleted and I will reannotate to the new term.
requested in
https://github.com/pombase/fypo/issues/3906
and make
abolished mitotic sister chromatid separation, with mononucleate and anucleate compartment formation
an exact synonym  of the proposed new term
"septated mononucleate vegetative cell with misplaced nucleus"

All of the annotations to any mitotic catastrophe term which does not mention cut should now be removed in the next update.

commented on FYPO:0005070 in #3906

One more question: what should we do with FYPO:0006690 and FYPO:0006691? It looks like they don't have direct annotations, so it'll be easy enough to make them obsolete. But should the related synonym "cut-like" go onto any other term?

id: FYPO:0006690
name: mitotic catastrophe with abnormal chromosome segregation
def: "A cell phenotype observed in the vegetative growth phase of the life cycle in which a cell proceeds through the mitotic metaphase/anaphase transition in the presence of an uncorrected problem (such as chromosome structure or kinetochore attachment), and as a result undergoes abnormal chromosome segregation and subsequently dies." [PomBase:mah]
is_a: FYPO:0001047 ! mitotic catastrophe
id: FYPO:0006691
name: mitotic catastrophe with abnormal nuclear envelope partitioning
def: "A cell phenotype observed in the vegetative growth phase of the life cycle in which a cell proceeds through the mitotic metaphase/anaphase transition in the presence of an uncorrected problem (such as chromosome structure or kinetochore attachment), and as a result undergoes abnormal nuclear envelope partitioning and subsequently dies." [PomBase:mah]
comment: In this phenotype, two daughter nuclei form, usually of unequal size. The septum may be formed between the nuclei, or both may end up in one compartment. Note that in higher eukaryotes, mitotic catastrophe is more broadly defined as any phenotype in which cells undergo an aberrant mitosis that arrests before completion, and subsequently die by necrosis or apoptosis.
synonym: "cut-like" RELATED [PomBase:vw]
is_a: FYPO:0001047 ! mitotic catastrophe

all non-cut mitotic catastrophe terms now obsolete, including those last two, i.e.
FYPO:0001047, FYPO:0001049-1051, FYPO:0006690, FYPO:0006691
renamed FYPO:0001052-1054 as requested
I'll close this but let me know if "cut-like" should become a synonym of any active term, or if I missed any other synonyms.


Find old domain links in docs and update them

I'll update the description later.
http://docs.sphinxdocs.com/en/latest/step-2.html

Fixed


Inject text for key stories

I think that even our current draft text would be useful to see on the page

@aappling-usgs want me to go ahead on this?...it looks like the text in the Google Doc is still in flux. I can...just double-checking

Yes, please do. I know it's still in flux, but I think having most of the text in there will help us to see how the stories are shaping up visually. Just copy in something that seems approximately like where we're headed. I'm sure there will be a round or two of revisions of this text later, but I think it'll be worth it to have previews along the way.

We'll need revisions, but #141 is everything I was hoping for this time around. @ldecicco-USGS , what's your final time estimate?

3 hours


Is it possible to disable offline page completely (in the manifold for example)?

I'm aware of hostedwebapp.disableOfflinePage(), but that only loads after deviceready has fired and I'm afraid that if a device is offline it will go to the offline page, before that this function is called.

Sure, what is the expected behavior if your offline, would you want them to get an error or are you having other content you pointing to?

The default cordova behaviour is to keep the page the same, and only show an error after a link is clicked (then it finds out that the internet connection is lost and then it ends/kills the application with this error).
I would like to keep the page the same (so no offline page or whatsever, maybe a small Offline on the page) and when a user clicks a link that it shows an alert('No connection!'). This is ideal. But the cordova default is already better for my application then the offline page.

I don't want to push, but do you think this would be possible? I have no experience with writing java code, but it doesn't seem to hard (I'm looking at the Android code, as I'm only targetting Android anyway).

Hi @gabn88  let me talk to the guys who focus on android, we should be able to make an easy way to go back

+1 for this.
I'm having problems getting the offline page to work in ios (https://github.com/manifoldjs/ManifoldCordova/issues/59)
However, using cordova-network-information via the javascript api DOES work fine.. So I can use that to handle the device going off/on-line. BUT - I need to disable the manifold offline page in entirety to get this to work.
Thanks
Matt

I also had a case where I wanted to disable the offline feature and also get rid of the extra WebViews that are created for it. I created https://github.com/manifoldjs/ManifoldCordova/pull/68 as a draft about an option how it could be made optional.
@boyofgreen: I have a feeling that it is somewhat a "no-brainer" to allow optionally getting rid of the offline feature, but probably the biggest discussion point is should it be opt-in or opt-out. In my initial PR above, I changed the feature opt-in, because I feel that it is a ManifoldJS-specific thing that might come as a "surprise" for a regular Web developer unless explicitly turned on.
I am happy to amend my commit based on the discussion and feedback, but just wanted to throw it out there to get a feeling what others think about this.


The app wont start corretely after enable the option "Start with Windows" in Alienfx-gui.exe

Describe the bug
A clear and concise description of what the bug is.
To Reproduce
Steps to reproduce the behavior:

Go to 'Open Alienfx-gui.exe and tab settings'
Click on 'Start with Windows'
Scroll down to '....'
See error

Expected behavior
The icon in the tray for make changes or update the configuration in the app
Screenshots
If applicable, add screenshots to help explain your problem.

System (please complete the following information):

Model: Dell G15 5510
Model details: [e.g. per-key rgb keyboard]
OS: Windows 11 Pro Version 21H2 22000.856

Additional context
Add any other context about the problem here.

Update: I just enabled "start with windows" in alienfx-gui.exe and disabled the option "start with windows" in Alienfx-gui.exe and reboot like 3 times and the app alienfx-gui.exe starts fine

Update: I just enabled "start with windows" in alienfan-gui.exe and disabled the option "start with windows" in Alienfx-gui.exe and reboot like 3 times and the app alienfan-gui.exe starts fine

Seems like you use bugged set (first 7.0.0 have a bug there) and don't read release notes for fix - i recommend to do this into it.

This?
Application behavior control block at right:
"Start with Windows" - Start application at Windows start. It will not work if application request run as admin level (see below) (default - off).


Snow web component

Respects prefers-reduce-motion.
https://fediverse.zachleat.com/@zachleat/111502606503275340
This was a popular jQuery plugin thing, and I think it should be a popular Web Component thing too.
See: https://github.com/loktar00/JQuery-Snowfall (and probably many others)

Here’s one! https://hawkticehurst.com/writing/12-days-of-web-components/day-1/

I did it https://www.zachleat.com/web/snow-fall/


Different timezones?

I've seen in the Alfred forum post that you were working on a tz parameter.
Did you publish it after all? If so, how one use it?
Thanks 🙂

Hope support timezone feature~


MAINT: integrate._tanhsinh: improvements after further testing

Reference issue
gh-18650
What does this implement/fix?

_tanhsinh would perform a full iteration even if NaNs were present in the limits of integration or the function evaluated at the midpoint of the limits of integration. d93ee4f9aef01615dd167e50b42f4595ca6c3597 fixes that.
_tanhsinh generated a ComplexWarning if the first integral evaluated had a complex result type and subsequent integrals were real. (This was caused by complex abscissae and weights being cached and converted to reals.) 81874e12297717834320d206a956769db1d986d4 fixes that.
_tansinh previously used rtol=1e-12 regardless of dtype, but this is unrealistic for lower-precision float types. 84a0cbaf47196440f6f29067e411bdf78284299f makes the rtol depend on the dtype.
_tanhsinh produced an error with size-0 input. 33dc64450ab5f71de24084f1ce9e830563d543e0 fixes that.
During review, it was suggested that "fixed-precision" in the docsstring should be "finite-precision". d36b27eff0bb45b4e74177713cd04b59fa81b5e5 fixes that.

Me too! Thanks for taking a look.

Oops looks like there were runtime warnings on one platform.

Oops looks like there were runtime warnings on one platform.

ah, right. i've gotten used to CI always having something broken and glossed over that that was relevant

Yes, me too.
I think this will do the trick.

@steppi Looks like the failure is unrelated this time.


docs: Add audiobook generation example

Related Issues/PRs

#xxx
What changes are proposed in this pull request?
Briefly describe the changes included in this Pull Request.
How is this patch tested?

[ ] I have written tests (not required for typo or doc fix) and confirmed the proposed feature/bug-fix/change works.

Does this PR change any dependencies?

[ ] No. You can skip this section.
[ ] Yes. Make sure the dependencies are resolved correctly, and list changes here.

Does this PR add a new feature? If so, have you added samples on website?

[ ] No. You can skip this section.
[ ] Yes. Make sure you have added samples following below steps.

Find the corresponding markdown file for your new feature in website/docs/documentation folder.
Make sure you choose the correct class estimators/transformers and namespace.
Follow the pattern in markdown file and add another section for your new API, including pyspark, scala (and .NET potentially) samples.
Make sure the DocTable points to correct API link.
Navigate to website folder, and run yarn run start to make sure the website renders correctly.
Don't forget to add <!--pytest-codeblocks:cont--> before each python code blocks to enable auto-tests for python samples.
Make sure the WebsiteSamplesTests job pass in the pipeline.

/azp run

Codecov Report

Merging #1852 (89c68af) into master (d64563f) will decrease coverage by 78.50%.
The diff coverage is n/a.

 Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

/azp run

/azp run