Reify fails on attributes not in columns

At our company we use a jsonb data field to create a form of single table inheritance. We have a concern which allows you to create store_attributes which are backed by the data field, but are otherwise normal rails attributes. When working with PaperTrail we noticed that the first version is reified incorrectly. Firstly our values are duplicated, since both the store and the store_attributes are attributes and mapped in RecordTrail. We hoped that skipping the store would solve our issues, however then we noticed that the attributes are versioned with their current values instead of their previous values. Tracking this lead us again to RecordTrail. Our store_attributes have no column, thus the current value is stored.
At reify we noticed that the correct values stored in the store were being overwritten by the store_attributes. Reproduce with
# Use this template to report PaperTrail bugs.
# Please include only the minimum code necessary to reproduce your issue.
require "bundler/inline"

# STEP ONE: What versions are you using?
gemfile(true) do
  ruby "2.4.1"
  source "https://rubygems.org"
  gem "activerecord", "5.0.0"
  gem "minitest", "5.9.0"
  gem "paper_trail", "7.0.2", require: false
  gem "pg"
end

require "active_record"
require "minitest/autorun"
require "logger"

# Please use sqlite for your bug reports, if possible.
ActiveRecord::Base.establish_connection(adapter: "postgresql", database: "repro")
ActiveRecord::Base.logger = nil
ActiveRecord::Schema.define do
  # STEP TWO: Define your tables here.
  drop_table :users if table_exists? :users
  create_table :users, force: true do |t|
    t.jsonb :data
    t.timestamps null: false
  end

  drop_table :versions if table_exists? :versions
  create_table :versions do |t|
    t.string :item_type, null: false
    t.integer :item_id, null: false
    t.string :event, null: false
    t.string :whodunnit
    t.jsonb :object
    t.jsonb :object_changes
    t.integer :transaction_id
    t.datetime :created_at
  end
  add_index :versions, %i[item_type item_id]
  add_index :versions, [:transaction_id]

  drop_table :version_associations if table_exists? :version_associations
  create_table :version_associations do |t|
    t.integer  :version_id
    t.string   :foreign_key_name, null: false
    t.integer  :foreign_key_id
  end
  add_index :version_associations, [:version_id]
  add_index :version_associations, %i[foreign_key_name foreign_key_id],
            name: "index_version_associations_on_foreign_key"
end
ActiveRecord::Base.logger = Logger.new(STDOUT)
require "paper_trail/config"

# STEP THREE: Configure PaperTrail as you would in your initializer
PaperTrail::Config.instance.track_associations = true

require "paper_trail"

# STEP FOUR: Define your AR models here.
class User < ActiveRecord::Base
  # Also fails has_paper_trail skip: [:data]
  has_paper_trail

  store_accessor :data, :name
  attribute :name, :string

  def name
    self['name']
  end

  def name=(value)
    self['name'] = value
    write_store_attribute(:data, :name, value)
  end
end

# STEP FIVE: Please write a test that demonstrates your issue.
class BugTest < ActiveSupport::TestCase
  def test_1
    u = User.new(data: {})
    u.name = 'First'
    u.save
    u.name = 'Second'
    u.save
    previous = u.versions.last.reify

    assert previous.name == 'First'
  end
end

# STEP SIX: Run this script using `ruby my_bug_report.rb`

The only workaround I currently see is skipping all the store_attributes in PaperTrail. This leaves only the correct store field being versioned. However this is problematic for us as the has_paper_trail call happens on the super class of the models calling store_attribute, so we'd somehow have to switch that order around.

Hi Boudewijn, Thanks for the bug report. Thanks also for testing the experimental associations tracking feature.
I don't understand this line of your test:
assert previous.name == 'First'

Shouldn't it be as follows?
assert previous.name == 'Second'

Your record has gone through three states.

Nonexistence
"First"
"Second"

versions[0] represents the transition from state 1 to 2 and versions[1] represents the transition from state 2 to 3. When you reify versions[1], you are asking for state 2, aka "Second".
What am I missing? Thanks.

Oh, wait a second, I think I see .. I think your test makes sense now. When you reify versions[1], you are asking for state 2, aka "First".

Possibly relevant: I'm reading the documentation for ActiveRecord::Store (at the top of lib/active_record/store.rb) and it says to use super in your accessor method (name=).
  # == Overwriting default accessors
  #
  # All stored values are automatically available through accessors on the Active Record
  # object, but sometimes you want to specialize this behavior. This can be done by overwriting
  # the default accessors (using the same name as the attribute) and calling <tt>super</tt>
  # to actually change things.
  #
  #   class Song < ActiveRecord::Base
  #     # Uses a stored integer to hold the volume adjustment of the song
  #     store :settings, accessors: [:volume_adjustment]
  #
  #     def volume_adjustment=(decibels)
  #       super(decibels.to_i)
  #     end
  #
  #     def volume_adjustment
  #       super.to_i
  #     end
  #   end

Can you try using super please?

Hi Jared,
I'm pretty sure the super in the accessor method isn't related. I tried simply removing the accessor methods like so:
# Use this template to report PaperTrail bugs.
# Please include only the minimum code necessary to reproduce your issue.
require "bundler/inline"

# STEP ONE: What versions are you using?
gemfile(true) do
  ruby "2.4.1"
  source "https://rubygems.org"
  gem "activerecord", "5.0.0"
  gem "minitest", "5.9.0"
  gem "paper_trail", "7.0.2", require: false
  gem "pg"
end

require "active_record"
require "minitest/autorun"
require "logger"

# Please use sqlite for your bug reports, if possible.
ActiveRecord::Base.establish_connection(adapter: "postgresql", database: "repro")
ActiveRecord::Base.logger = nil
ActiveRecord::Schema.define do
  # STEP TWO: Define your tables here.
  drop_table :users if table_exists? :users
  create_table :users, force: true do |t|
    t.jsonb :data
    t.timestamps null: false
  end

  drop_table :versions if table_exists? :versions
  create_table :versions do |t|
    t.string :item_type, null: false
    t.integer :item_id, null: false
    t.string :event, null: false
    t.string :whodunnit
    t.jsonb :object
    t.jsonb :object_changes
    t.integer :transaction_id
    t.datetime :created_at
  end
  add_index :versions, %i[item_type item_id]
  add_index :versions, [:transaction_id]

  drop_table :version_associations if table_exists? :version_associations
  create_table :version_associations do |t|
    t.integer  :version_id
    t.string   :foreign_key_name, null: false
    t.integer  :foreign_key_id
  end
  add_index :version_associations, [:version_id]
  add_index :version_associations, %i[foreign_key_name foreign_key_id],
            name: "index_version_associations_on_foreign_key"
end
ActiveRecord::Base.logger = Logger.new(STDOUT)
require "paper_trail/config"

# STEP THREE: Configure PaperTrail as you would in your initializer
PaperTrail::Config.instance.track_associations = true

require "paper_trail"

# STEP FOUR: Define your AR models here.
class User < ActiveRecord::Base
  # Also fails has_paper_trail skip: [:data]
  has_paper_trail

  store_accessor :data, :name
  attribute :name, :string
end

# STEP FIVE: Please write a test that demonstrates your issue.
class BugTest < ActiveSupport::TestCase
  def test_1
    u = User.new(data: {})
    u.name = 'First'
    u.save
    u.name = 'Second'
    u.save
    previous = u.versions.last.reify

    assert previous.name == 'First'
  end
end

# STEP SIX: Run this script using `ruby my_bug_report.rb`

As I said this is mostly related to the check in RecordTrail. For the name attribute there is no column, so the attributes_before_change returns the current value instead of the previous value.

Hi Boudewijn, any progress on this? Need any help?

Hi Jared, unfortunately we lacked time in our project to fix this bug and simply displayed a message to the user that we can't display the first version. I'm currently in the process of making finalizing the project, so fixing this would be useful. I think the main question is why RecordTrail#attributes_before_change works the way it does. Could you elaborate on that?

When I apply the following patch to your bug report, it passes.
-   gem "activerecord", "5.0.0"
+  gem "activerecord", "5.0.6"

So, I guess rails fixed it for us? (I can hope) I'll close this. Let me know if you still have problems with rails >= 5.0.6


Password logic is implementated and the test is also successfully run…

Now when the user will create the password then the user have to enter the required fields to create the pasword successfully

Issue resolved.


Api cli close modal on linode create

Description 📝
Address UX Feedback
Automatically closes commands modal upon creating Linode from terminal.
How to test 🧪

Go to Linode create page and fill required fields.
Click on Create Command Line button.
Copy command and execute in terminal.
Observe behavior of closing modal and navigating user back to Linode's page.

Test creating Linode, clone Linode, Deploy Linode from backup
How do I run relevant unit or e2e tests?

yarn test
yarn cy:run

Thank you @bnussman-akamai and @jdamore-linode.


Unable to claim Responsive web design certificate

I have completed all the projects relevant to responsive web design certificate but unable to claim it and getting below error message.

Hi @Vijayalakshmi25 thanks for reporting.
We will get this checked. As you may know that beta can be unstable at times, we regret the inconvenience.
Happy coding!

/cc @Bouncey

I am having the same problem

Unable to claim Responsive web design certificate

Where can i claim my responsive web design certificate?

Please connect with me via an email mrugesh at freecodecamp dot org for login issues. Be sure to include screenshots of your browser console:
On Windows:
Press F12 and then switch to the Console Tab
On macOS:
Press ⌘+⌥+i and then switch to the Console Tab
Other Systems:
Please lookup on google on how to open Browser Dev tools


Question: do nested transactions work as you would expect?

Seems like they work right (i.e. nothing is calculated until the outermost transaction exits), but I am not sure how to tell. Maybe something to add to the docs?

Correct, computations are delayed until the most outer transaction finishes. I'll add it to the docs.


PropertiesDescriptor.Remove() usage

On PropertiesDescriptor<T>, there is a Remove(string name) method. From my understanding, this is intended to be used to opt out a property from being included in the mapping for a type i.e. the fluent mapping version of [ElasticProperty(OptOut = true)].
This appears to work fine when the property is at the top of the object graph (root object) and the property name is camel-cased, but it doesn't seem to work for properties of object or nested properties, using a camel-cased property name (not a string of the path to the property name from the root object).
Looking through the source, the nearest I can get to [ElasticProperty(OptOut = true)] using fluent mappings is to cast my ConnectionSettings to IConnectionSettingsValue and add the MemberInfo for each type to the PropertyMappings collection with Ignore set to true, similar to
var propertyInfos = typeof(Model).GetProperties().Where(p => PropertiesToIgnore.Contains(p.Name));
var propertyMapping = new PropertyMapping { Ignore = true };

foreach (var propertyInfo in propertyInfos)
{
      ((IConnectionSettingsValues)connection).PropertyMappings.Add(propertyInfo, propertyMapping);
}

I guess what I'm asking is two-fold:

Is my understanding of what  Remove() is supposed to do correct? If it is, how do I go about using it for nested/object property properties?
Could we have an expression based way to ignore properties when using fluent-mappings?

The Remove is a bit of an ugly duckling, its there to remove a property that MapFromAttributes() would find but that you do not want mapped.
This is old, wrong and will be marked for removal!
If you want OptOut behaviour in code use:
new ConnectionSettings()
    .MapPropertiesFor<T>(m=>m
         .Ignore(p=>p.PropertyOnT)
    );

Now not only MapFromAttributes() ignores it but also it will be ignored when indexing (serialization in general).
Hope this explains it!

Thanks! I did see the MapPropertiesFor<T> - if I were to use it to ignore some properties, I take it the rest of an object's properties would adhere to the MapFromAttributes() and Properties() set up?
Any thoughts about exposing Ignore on the PropertyDescriptor<T>?


Win10 vs 11 and 0x80090325: certificate chain issue

Co-worker and I are updating our app from .Net 6 to .Net 8.
This morning I upgraded to 8.0.3 libraries and started getting the exception: (0x80090325): The certificate chain was issued by an authority that is not trusted
We encountered this previously due to the .net7 breaking change, and we updated our database connection string to include:

Integrated Security=True; TrustServerCertificate=true; Encrypt=false

I get the error, on Windows 11
Co-Worker on Win10 has no error.
Clean-Rebuild of app, we synced our changes through Git and confirmed we are on the same baselines.
I'm not sure what else to check, so not sure if this is a weird Win11 difference.
Include stack traces
Microsoft.Data.SqlClient.SqlException (0x80131904): A connection was successfully established with the server, but then an error occurred during the login process. (provider: SSL Provider, error: 0 - The certificate chain was issued by an authority that is not trusted.)
 ---> System.ComponentModel.Win32Exception (0x80090325): The certificate chain was issued by an authority that is not trusted.

Include provider and version information
EF Core version: 8.0.3 / SqlClient 5.1.5
Database provider: Microsoft.EntityFrameworkCore.SqlServer to SQL Server 2016 DB
Target framework: .NET 8.0
Operating system: Windows 11 vs Windows 10
IDE: Visual Studio 2022 17.9

I managed to get the DB Connection to work on Win11, for me, finally... and I don't think it is the SqlClient.
We use EF Core Power Tools to generate/update the models our database project.
I just found that EF Core Power Tools is creating an OnConfiguring method:
    protected override void OnConfiguring(DbContextOptionsBuilder optionsBuilder)
        => optionsBuilder.UseSqlServer("Data Source=OurServer;Initial Catalog=OurDB;Integrated Security=True;Encrypt=false");

During startup of the app, even though we've configured the context in Startup.cs ConfigureServices(), this OnConfiguring is getting called instead.
[External Code]
App.dll!Services.CommonUtilities.ValidateOrAddUser(Lib.DB.Services.Database.MainDBContext _context, Lib.DB.Services.Database.WarehouseDB.WarehouseDBContext _prismContext, string ntid) Line 81	C#
 	App.dll!Controllers.UserClaimsController.GetCurrent() Line 37	C#
 	[External Code]
>	App.dll!Startup.Configure.AnonymousMethod__8_0(Microsoft.AspNetCore.Http.HttpContext context, System.Func<System.Threading.Tasks.Task> next) Line 190	C#

I'm not sure why it is calling the OnConfiguring method, rather than using what is configured in ConfigureServices (and getting pulled from user.secrets and appsettings.json.
But, it I add TrustServerCertificate=true it works properly.
I don't know why I'm seeing this on Win11 and my coworker isn't on Win10, wondering if we might be on a different version of VS2022...

@awdorrin it seems like this is related to different setup on different machine and does not have anything to do with SqlClient.


Calculating the devicePixelRatio for the pdf to display with less pixels than the limit of the platform

Details
Each platform has a different max canvas size that can change without notice, we use canvas-size library to calculate that limit. Then we calculate the devicePixelRatio that allows the pdf to be displayed with less pixels than this limit
Fixed Issues
$ https://github.com/Expensify/App/issues/23327
PROPOSAL: https://github.com/Expensify/App/issues/23327#issuecomment-1674766196
Tests

Go to any report
Click on add attachment and select a pdf with big pages, for example this one
Verify that the pdf is displayed correctly in the preview

[x] Verify that no errors appear in the JS console

Offline tests
Same tests
QA Steps
Same tests

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

https://github.com/Expensify/App/assets/19537677/7853eb4b-9e3a-49b6-8370-31460b9c1d99

Mobile Web - Chrome

https://github.com/Expensify/App/assets/19537677/941266cc-9e3b-401b-bf14-d42be854c712

Mobile Web - Safari

https://github.com/Expensify/App/assets/19537677/afb9e8cf-a9bb-48c0-8c5f-c239e1a1b694

Desktop
https://github.com/Expensify/App/assets/19537677/b6760600-f190-46c1-be4b-04932ef5d464

iOS
https://github.com/Expensify/App/assets/19537677/a2309b33-8be3-40dc-b0d2-ec35ce9264f1

Android
https://github.com/Expensify/App/assets/19537677/14b924fb-376c-4586-8f68-c7c4a9f6bfb4

Hello @eVoloshchak  This is the first version but I have some problems:

canvasSize.maxArea takes some time and it's slowing the render of the page, I think we should calculate it only once but I am not sure how to store it, is it a good use case for storing in onyx ?
You mentionned passing the prop devicePixelRatio only when the size of the pdf is above the max size of the canvas, I am not sure how to do that cleanly
Some PR checks (license and security) are not successfull for some reason

It looks like I still have to find a better calcul because on web when I have the full window (not with the dev tool opened) it shows blank. I did a testing thing where I show the calculated max ratio and I can input the device ratio that I want to use, in my case the ratio calculated was 2.95 and at 2.6 it was showing blank, not only that but the more I increase the ratio the slower it is for the pdf to render and to scroll. I think on web the default ratio is 1 so puttin it above that at 2.9 or even 2.5 seems wrong but still weird that it is crashing.
Here is a video where I put 2.9, 2 and 1.2 to see the different behaviours:
https://github.com/Expensify/App/assets/19537677/89a873a5-49fa-4012-a253-e1312777f66e

Weird behaviour on ios and android, I am checking tomorrow

canvasSize.maxArea takes some time and it's slowing the render of the page, I think we should calculate it only once but I am not sure how to store it, is it a good use case for storing in onyx ?

Yes, we can absolutely store it on onyx. Also, have you tried if useWorker: true makes any difference in performance?

Some PR checks are not successfull and I am not sure why

There are linter errors
I think Verify Podfile check is failing because when you add a new package, you also have to include package-lock.json and Podfile.lock to the PR

Some PR checks are not successfull and I am not sure why

There are linter errors
I think Verify Podfile check is failing because when you add a new package, you also have to include package-lock.json and Podfile.lock to the PR

I will resolve this but there are also security, license and jest that are in error

I still have to do this:

Add the canvas limit into onyx and retrieve them, should I store them as one object or 3 is fine ? I think 3 is easier because there are 3 callbacks onSuccess and I don't have to create a new type
Verify if the displaying on ios and android was like this before (not zoomed in)
Fix lint errors after all is done

So yes the zoom in problem is also on main
https://github.com/Expensify/App/assets/19537677/4240dac9-784f-48b7-93d6-0bb65116b3e1

@eVoloshchak I think the PR is almost ready for review but there is a problem with the checks

Ready for review

@ShogunFire, lint test is failing

@ShogunFire, could you also verify if this works on native platforms?
I remember testing this and it definitely worked on iOS, but now it's failing for both Android and iOS
https://github.com/Expensify/App/assets/9059945/dbce2dd9-4206-41a8-9244-9d5b907f0e5e
https://github.com/Expensify/App/assets/9059945/cde56307-4e63-4d23-aafb-9cb1b8091bfb

@ShogunFire, could you also verify if this works on native platforms? I remember testing this and it definitely worked on iOS, but now it's failing for both Android and iOS

It is unrelated to this PR and also crash on main

Reviewer Checklist

[ ] I have verified the author checklist is complete (all boxes are checked off).
[ ] I verified the correct issue is linked in the ### Fixed Issues section above
[ ] I verified testing steps are clear and they cover the changes made in this PR

[ ] I verified the steps for local testing are in the Tests section
[ ] I verified the steps for Staging and/or Production testing are in the QA steps section
[ ] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[ ] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[ ] I checked that screenshots or videos are included for tests on all platforms
[ ] I included screenshots or videos for tests on all platforms
[ ] I verified tests pass on all platforms & I tested again on:

[ ] Android / native
[ ] Android / Chrome
[ ] iOS / native
[ ] iOS / Safari
[ ] MacOS / Chrome / Safari
[ ] MacOS / Desktop

[ ] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[ ] I verified proper code patterns were followed (see Reviewing the code)

[ ] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[ ] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[ ] I verified that comments were added to code that is not self explanatory
[ ] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[ ] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[ ] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[ ] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[ ] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[ ] I verified the JSDocs style guidelines (in STYLE.md) were followed

[ ] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[ ] I verified that this PR follows the guidelines as stated in the Review Guidelines
[ ] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[ ] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[ ] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[ ] If a new component is created I verified that:

[ ] A similar component doesn't exist in the codebase
[ ] All props are defined accurately and each prop has a /** comment above it */
[ ] The file is named correctly
[ ] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[ ] The only data being stored in the state is data necessary for rendering and nothing else
[ ] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[ ] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[ ] All JSX used for rendering exists in the render method
[ ] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[ ] If any new file was added I verified that:

[ ] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[ ] If a new CSS style is added I verified that:

[ ] A similar style doesn't already exist
[ ] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[ ] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[ ] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[ ] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[ ] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[ ] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[ ] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[ ] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

I think the end of the bonus is in 2 hours @pecanoro I know it's fast but if you can review this before that would be awesome !!

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by https://github.com/pecanoro in version: 1.3.59-0 🚀

platform
result

🤖 android 🤖
failure ❌

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to staging by https://github.com/pecanoro in version: 1.3.60-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
failure ❌

🕸 web 🕸
success ✅

🚀 Deployed to staging by https://github.com/pecanoro in version: 1.3.60-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/luacmartins in version: 1.3.59-5 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
failure ❌

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/luacmartins in version: 1.3.60-3 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


experiment: diagnosing and addressing Issue 3057

Don't merge this - its just a branch for investigating issue #3057.

adds another repro
limits recursion depth for subtyping and bi_matching to generate useful short stack-traces.
hack definition of expansiveness (totally broken though). Needs some thought on how to recognize polymorphic recursion via a bound type parameter.

Just doing some repo cleanup for better focussing on active work:
Closing PR as it seems inactive for a longer time. Please re-open if it is still relevant and after it has been updated with latest master changes.


Bug: Export UI modal shouldn't go away by clicking outside

Tell us where you are using Dejavu (Hosted web app, Chrome extension, Docker Image, Within appbase.io)
Hosted web app
What is the version of Dejavu that you are using?
1.5.0
Describe the issue that you are seeing, or the feature request :-), include any screenshots as necessary.
When in the process of exporting the data, if you click outside the modal area - the modal closes.

The above GIF shows this. Since exporting runs a scroll query to fetch all the data in the view, we shouldn't let a click outside the modal area to close the export modal.
If your issue deals with a UI issue, share with us a screenshot of the failing network request or the browser console log showing the error.
We should only close this modal if a user clicks on the close icon. And ensure there are no side-effects caused by this to the behavior of other modals.

Hey @siddharthlatest, do you mind if I work on this fix? :)

That would be awesome @MPierre9!


It says the piskel exe has a detected virus

First of all this isn't really a bug. but when I scanned the piskel.exe file on VirusTotal, it said that the file had a detected virus from Cylance.  I'm just making sure this is safe.  Thank you!

@NaminBeforeGamin thanks for the info! Which version did you download? The latest from piskelapp.com?

Ok it looks like this happens with the last version and is probably related to nwjs. I tried checking the latest nwjs.exe (from https://nwjs.io/downloads/ ) on VirusTotal, and it shows the same warning.
I'm fairly sure this is a false positive, but I will log an issue on the nwjs repository to get some more insights.

@NaminBeforeGamin see the answer on the issue I opened.
I don't plan on requesting nwjs.exe to be whitelisted.


update identity server version to 1.6.2

update identity server version to 1.6.2
.net framework to 4.5.1
Fixes Issue: https://github.com/IdentityServer/IdentityServer3.Samples/issues/150

Hi @vairam-svs, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. I promise there's no faxing. https://cla2.dotnetfoundation.org.

TTYL, DNFBOT;

CLA already signed

@vairam-svs, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR.
Thanks, DNFBOT;


[Optimize] Speed up converting the data of other type to string in mysql_result_writer

Proposed changes
Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue.
Types of changes
What types of changes does your code introduce to Doris?
Put an x in the boxes that apply

[ ] Bugfix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation Update (if none of the other choices apply)
[ ] Code refactor (Modify the code structure, format the code, etc...)
[x] Optimization. Including functional usability improvements and performance improvements.
[ ] Dependency. Such as changes related to third-party components.
[ ] Other.

Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

[x] I have created an issue on (Fix #6385 ) and described the bug/feature there in detail
[ ] Compiling and unit tests pass locally with my changes
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] If these changes need document changes, I have updated the document
[ ] Any dependent changes have been merged

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

ut failed at test/util/tdigest_test

Did you do the benchmark ? how much it can improve ?

Did you do the benchmark ? how much it can improve ?

CREATE TABLE baseall (
k1 tinyint(4) NULL COMMENT "",
k2 smallint(6) NULL COMMENT "",
k3 int(11) NULL COMMENT "",
k4 bigint(20) NULL COMMENT "",
k5 decimal(9, 3) NULL COMMENT "",
k6 char(5) NULL COMMENT "",
k10 date NULL COMMENT "",
k11 datetime NULL COMMENT "",
k7 varchar(20) NULL COMMENT "",
k8 double NULL COMMENT "",
k9 float NULL COMMENT ""
) ENGINE=OLAP
DUPLICATE KEY(k1, k2, k3, k4)
COMMENT "OLAP"
DISTRIBUTED BY HASH(k1) BUCKETS 10
PROPERTIES (
"replication_num" = "1",
"in_memory" = "false",
"storage_format" = "V2"
);
and insert more than one hundred thousand record， the TupleConvertTime reduced from about 350ms to 180ms


feat: More Climater Data

This PR introduces 3 new sensors from the update_vehicle_climater data.

Remaining Climatisation Time (int) minutes

Displays the remaining minutes for climatisation when running

Park Time (datetime) timestamp

Displays when the vehicle was last parked

Glass Surface Heating (bool) binary sensor - running

Displays if glass surface heating is active or not during climatisation

Other Changes:

Unified update_vehicle_climater debugging with update_vehicle_position debugging
Redacted vin

All except "Glass Surface Heating" (not available on my car) was tested successfully.


$transactionId as return when createAccountTransaction is called

Hi,
In order to direct check if transaction was successfully created or is completed later, I would like to get the $transactionId at same time when transaction is created.
Is this requested return already implemented?
$transaction = Transaction::send([
'toBitcoinAddress' => 'ADDRESS',
'amount'           => new Money(5, CurrencyCode::USD),
'description'      => 'Your first bitcoin!',
'fee'              => '0.0001' // only required for transactions under BTC0.0001
]);
$client->createAccountTransaction($account, $transaction);
Thanks!

I believe the original $transaction object will have the transaction id after createAccountTransaction() is called. You can try accessing it like $transaction->getNetwork()-> getHash()


Slack message garbled

After installing the plugin and setting the config similar to bellow (not exact token and team)
slack.team = team
slack.token = b424ItUa313HtUcbbGEuyBY
slack.defaultChannel = sandbox

The messages sent to slack looks like:
psa has pushed 1 commit to </log?r=limego/go.git&h=feature/auto-signup-2|feature/auto-signup-2> in </summary?r=limego/go.git|limego/go>
</commit?r=limego/go.git&h=7bccb1fac9a4385d6db486cb700f0c9823eb9e64|`7bccb1`> Show information of signups in admin

What would be wrong for this to happen?

Can you confirm that you have specified web.canonicalUrl?  This is the addressable base URL of your Gitblit install and is used for plugin link generation and email notifications.

True, that was not set making the links invalid.
Thank you for quick reply.
PS. Documenting that the "token" is the last part of an webhook would be good since it was a hassle to figure out.

It was correctly documented, but then Slack changed the presentation of the hook configuraiton which makes my current documentation look incorrect.  But I agree, the documentation needs to be updated to reflect Slack's current preferred configuration.  I presume you discovered #1.


error saving PyTorch model

A user on discord shared this example that gave an error and I was able to reproduce. This seems to be how you are supposed to call it but it is unclear if we are doing something wrong?? I am not super familiar with the pertained models in torch vision but looking at the source there doesn't seem to be anything special going on there and I reproduced it with a model I have also to be sure.
I am using the 0.2.2 release installed with pip. I am on the nightly PyTorch but installed stable and reproduced it also.
This is the provided example code:
from mlem.api import save
from torchvision import models

model = models.resnet18(pretrained=True)
save(model, 'resnet18')

This is the error with mlem 0.2.2 installed with pip:
Traceback (most recent call last):
  File "/opt/homebrew/Caskroom/miniforge/base/envs/pytorch/lib/python3.10/site-packages/mlem/core/metadata.py", line 34, in get_object_metadata
    return MlemData.from_data(
  File "/opt/homebrew/Caskroom/miniforge/base/envs/pytorch/lib/python3.10/site-packages/mlem/core/objects.py", line 675, in from_data
    data_type = DataType.create(
  File "/opt/homebrew/Caskroom/miniforge/base/envs/pytorch/lib/python3.10/site-packages/mlem/core/data_type.py", line 74, in create
    return DataAnalyzer.analyze(obj, **kwargs).bind(obj)
  File "/opt/homebrew/Caskroom/miniforge/base/envs/pytorch/lib/python3.10/site-packages/mlem/core/hooks.py", line 107, in analyze
    return cls._find_hook(obj).process(obj, **kwargs)
  File "/opt/homebrew/Caskroom/miniforge/base/envs/pytorch/lib/python3.10/site-packages/mlem/core/hooks.py", line 135, in _find_hook
    raise HookNotFound(
mlem.core.errors.HookNotFound: No suitable DataHook for object of type "ResNet". Registered hooks: [<class 'mlem.core.data_type.PrimitiveType'>, <class 'mlem.core.data_type.OrderedCollectionHook'>, <class 'mlem.core.data_type.DictType'>, <class 'mlem.contrib.torch.TorchTensorDataType'>, <class 'mlem.contrib.numpy.NumpyNumberType'>, <class 'mlem.contrib.numpy.NumpyNdarrayType'>]

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/opt/homebrew/Caskroom/miniforge/base/envs/pytorch/lib/python3.10/site-packages/mlem/core/metadata.py", line 96, in save
    meta = get_object_metadata(
  File "/opt/homebrew/Caskroom/miniforge/base/envs/pytorch/lib/python3.10/site-packages/mlem/core/metadata.py", line 38, in get_object_metadata
    return MlemModel.from_obj(
  File "/opt/homebrew/Caskroom/miniforge/base/envs/pytorch/lib/python3.10/site-packages/mlem/core/objects.py", line 611, in from_obj
    mt = ModelAnalyzer.analyze(model, sample_data=sample_data)
  File "/opt/homebrew/Caskroom/miniforge/base/envs/pytorch/lib/python3.10/site-packages/mlem/core/model.py", line 298, in analyze
    return super().analyze(obj, sample_data=sample_data, **kwargs)
  File "/opt/homebrew/Caskroom/miniforge/base/envs/pytorch/lib/python3.10/site-packages/mlem/core/hooks.py", line 107, in analyze
    return cls._find_hook(obj).process(obj, **kwargs)
  File "/opt/homebrew/Caskroom/miniforge/base/envs/pytorch/lib/python3.10/site-packages/mlem/contrib/torch.py", line 155, in process
    "torch_predict": Signature.from_method(
  File "/opt/homebrew/Caskroom/miniforge/base/envs/pytorch/lib/python3.10/site-packages/mlem/core/model.py", line 163, in from_method
    result = method(**call_kwargs)
  File "/opt/homebrew/Caskroom/miniforge/base/envs/pytorch/lib/python3.10/site-packages/torch/nn/modules/module.py", line 1130, in _call_impl
    return forward_call(*input, **kwargs)
TypeError: ResNet.forward() got an unexpected keyword argument 'data'

Could this fix maybe get tagged in a release? It seems like PyTorch wouldn't be working for anyone right now.


Training Phrase array ends up as a single text in dialogflow console

The training phrase ends up as a single phrase after running my code.
this is my code
`string[] trainingPhrasesParts =
{
"Book a fligt",
"check cheap flights"
};
        var phraseParts = new List<Intent.Types.TrainingPhrase.Types.Part>();
        foreach (var part in trainingPhrasesParts)
        {
            phraseParts.Add(new Intent.Types.TrainingPhrase.Types.Part()
            {
                Text = part
            });
        }

        var trainingPhrase = new Intent.Types.TrainingPhrase();
        trainingPhrase.Parts.AddRange(phraseParts);

        var intent = new Intent();
        intent.DisplayName = "test";
        //intent.Messages.Add(message);
        intent.TrainingPhrases.Add(trainingPhrase);`

This is how it shows in dialogflow

Book a fligtcheck cheap flights

@amanda-tarafa

Please first note that the maintainers of this repo and of googleapis/google-cloud-dotnet are not experts on each individual API, just on the client libraries themselves.
That said, the result you are seing seems to be the expected result (see in the documentation for TrainingPhrase the discription for parts). I believe that what you want to do is add different TrainingPhrases and not a single TrainingPhrase with different parts.
I'll be closing this issue now since the problem you are experiencing doesn't seem to be related to the client library itself but is about API usage. If you still feel this is a problem with the client library please do leave another comment and I will reopen the issue if needed.
If you are having questions around how to use the Dialogflow API, you can go through the documentation here or take advantage of the support options available here.
Please do create issues in googleapis/google-cloud-dotnet if you are experiencing problems with the client library or in this repo if the samples shown are failing or otherwise incorrect.


xCertReq friendly name?

Would be nice to be able to specify this. I want to create the cert, but later I want to use the name in another task or script. Nothing to key off of otherwise.

@wasabii - thanks for raising this. This sounds like a great idea to me. It should be a reasonably minor change too.

@wasabii - I'll have a go at adding this over the weekend.

Hi @wasabii - sorry about taking so long. But I've completed this change now. It is in the Dev branch and will be released in a few weeks. Feel free to try this now and let me know if you have any problems.


Repo timeout locks full reconciliation cycle

Reflector-version: 0.6.0
Image:         ghcr.io/fluxcd/image-reflector-controller:v0.6.0
    Image ID:      docker-pullable://ghcr.io/fluxcd/image-reflector-controller@sha256:3f2f7e14681e92165b6bcd86fb28cf87bda60628535ab7613a3d3095426cf7b4
    Ports:         8080/TCP, 9440/TCP
    Host Ports:    0/TCP, 0/TCP
    Args:
      --events-addr=http://notification-controller/
      --watch-all-namespaces=true
      --log-level=info
      --log-encoding=json
      --enable-leader-election
      ```

Please take a look on ts. 15:41:18. -->(~2 minutes) -->  15:43:52 --> 15:43:52
{"level":"info","ts":"2021-06-02T15:41:18.217Z","logger":"controller-runtime.manager.controller.imagerepository","msg":"reconciliation finished in 114.811428ms, next run in 1m0s","reconciler group":"image.toolkit.fluxcd.io","reconciler kind":"ImageRepository","name":*********","namespace":"flux-system"}
{"level":"error","ts":"2021-06-02T15:43:52.355Z","logger":"controller-runtime.manager.controller.imagerepository","msg":"Reconciler error","reconciler group":"image.toolkit.fluxcd.io","reconciler kind":"ImageRepository","name":"*********,"namespace":"flux-system","error":"Get \"https://git.something.com:5050/v2/\": dial tcp **********:5050: i/o timeout"}
{"level":"info","ts":"2021-06-02T15:43:52.535Z","logger":"controller-runtime.manager.controller.imagerepository","msg":"reconciliation finished in 179.660488ms, next run in 1m0s","reconciler group":"image.toolkit.fluxcd.io","reconciler kind":"ImageRepository","name":"********","namespace":"flux-system"}

Imagerepo reconciliation is stoped in case of timeout for one of the repo.
In this case, one broken image repo(even temporary) breaks all ci/cd.

Another problem (small one, the first point is more relevant) -  by default timeout is equal to the interval. And in theory, an interval for 15 minutes(which is a quite possible scenario) can lock all reconciliation for 15 minutes.
Can it be 1 minute by default to prevent such cases?

To solve it we need to set the concurrent flag, so that the controller can process resources in parallel. Implementation example here: https://github.com/fluxcd/kustomize-controller/blob/main/main.go#L78

@stefanprodan  thanks, concurrent will solve it, I'll try
what do you think the second point?  Few broken images repo with large interval can still break all reconciliation.
Or maybe there is an exact reason why default timeout is equal to the interval.

You can't try it, it needs to be implemented first.

fyi: I started work on the fix.


cannot use OSC 7 sequence and 'autoshelldir' to synchronize Vim CWD with fish shell CWD

Steps to reproduce
Run these shell commands:
$ rm -rf /tmp/home/user/.config/fish/
$ mkdir -p /tmp/home/user/.config/fish/

$ tee >/tmp/home/user/.config/fish/config.fish <<'EOF'
    if test -n "$VIM_TERMINAL"
        function _vim_sync_PWD --on-variable=PWD
            printf '\033]7;file://%s\033\\' "$PWD"
        end
    end
EOF

$ rm /tmp/log

$ XDG_CONFIG_HOME=/tmp/home/user/.config/ vim -Nu NONE --log /tmp/log \
  +'set autoshelldir' \
  +'autocmd TerminalWinOpen * call term_sendkeys("", "cd /tmp\<CR>")' \
  +'terminal fish'

An error is given:
E1179: Failed to extract PWD from /tmp^[\, check your shell's config related to OSC 7

Next, execute this Ex command to quit Vim:
:quitall!

Finally, run this shell command to read the RECV lines from the logfile:
$ vim -Nu NONE +'vglobal /RECV/ delete _' /tmp/log

You should see that the OSC 7 sequence has been received in several chunks.  For example:
RECV on 0(out): '^[]7;fi'
RECV on 0(out): 'le:///tmp^[\'

Expected behavior
No error is given.  The Vim current working directory is synchronized with the one of the shell running in the Vim terminal buffer.
Version of Vim
9.0 Included patches: 1-230
Environment
Operating system: Ubuntu 20.04.4 LTS
Terminal: XTerm(353)
Value of $TERM: xterm-256color
Shell: fish, version 3.5.1-252-gada925141
Additional context
The issue is not deterministic.  You might need to cd into several directories to get an error.

The issue is specific to the fish shell.  No issue if we use the bash hook in bash, or the zsh hook in zsh.

If we send the OSC 7 sequence manually, 'autoshelldir' works as expected.  No error is given, and Vim's CWD is synchronized with the shell's one.

I think the issue comes from the fact that Vim receives the OSC 7 sequence in chunks.  I guess fish bufferizes the output of its printf builtin (but – for some reason – only when run from a hook).

The workaround given at :help terminal-autoshelldir – which relies on an OSC 51 sequence instead of OSC 7 – works as expected:
# in a Vim init file
def g:Tapi_lcd(_, args: path)
    execute $'silent lcd {path}'
enddef

# in a fish init file
if test -n "$VIM_TERMINAL"
    function _vim_sync_PWD --on-variable=PWD
        printf '\033]51;["call", "Tapi_lcd", "%s"]\007' "$PWD"
    end
end

It might be a regression in fish because the code worked fine until this commit.
However, I open the issue here, because I don't understand the code well enough, and the error is given in Vim.
Is it a bug in fish which should be reported on their bug tracker instead?  Or is there something which could be done on Vim's side to somehow join these meaningless chunks into a complete OSC 7 sequence?

Shell: GNU bash, version 5.0.17

Sorry, I meant this shell version:
fish, version 3.5.1-252-gada925141

XDG_CONFIG_HOME=/tmp/home/user/.config/ vim -Nu NONE --log /tmp/log
+'set autoshelldir'
+'autocmd TerminalWinOpen * call term_sendkeys("", "cd /tmp<CR>")'
+'terminal /home/lgc/VCS/fish/build/fish'

And I meant this shell command:
XDG_CONFIG_HOME=/tmp/home/user/.config/ vim -Nu NONE --log /tmp/log \
 +'set autoshelldir' \
 +'autocmd TerminalWinOpen * call term_sendkeys("", "cd /tmp\<CR>")' \
 +'terminal fish'

The fact that no error is given when using an OSC 51 sequence makes me think that somehow fish is confused by the presence of the "file" pattern in the OSC 7 sequence (which is absent from OSC 51).  I guess fish thinks that the output is intended to a file, and thus it's OK to bufferize the output of printf(1).  Although no idea why it does that only from a hook.  And I still wonder whether Vim could handle this by re-assembling the chunks.

Unrelated, but the code given at :help terminal-autoshelldir could be improved:
def g:Tapi_lcd(_, args: string)
    execute 'silent lcd ' .. args
enddef

First, the function is meant to receive a path to a directory, and :help :lcd itself names the parameter {path}.  So path would be a better name than the generic args.
Second, we might want to check that the received path is indeed a directory, just to make the code safer; since security is a concern here:

g:Tapi_exe() would execute any command the shell sends, that doesn't seem safe.

As a suggestion, here is a patch:
diff --git a/runtime/doc/terminal.txt b/runtime/doc/terminal.txt
index 56f0dc82d..9e2270262 100644
--- a/runtime/doc/terminal.txt
+++ b/runtime/doc/terminal.txt
@@ -1022,8 +1022,10 @@ create a security problem.
 						*terminal-autoshelldir*
 This can be used to pass the current directory from a shell to Vim.
 Put this in your .vimrc: >
-	def g:Tapi_lcd(_, args: string)
-	    execute 'silent lcd ' .. args
+	def g:Tapi_lcd(_, path: string)
+            if path->isdirectory()
+                execute $'silent lcd {path}'
+            endif
 	enddef
 <
 And, in a bash init file: >

Unrelated, but the code given at :help terminal-autoshelldir could be improved:
def g:Tapi_lcd(_, args: string)
    execute 'silent lcd ' .. args
enddef

First, the function is meant to receive a path to a directory, and :help :lcd itself names the parameter {path}.  So path would be a better name than the generic args.
Second, we might want to check that the received path is indeed a directory, just to make the code safer; since security is a concern here:

g:Tapi_exe() would execute any command the shell sends, that doesn't seem safe.

As a suggestion, here is a patch:
diff --git a/runtime/doc/terminal.txt b/runtime/doc/terminal.txt
index 56f0dc82d..9e2270262 100644
--- a/runtime/doc/terminal.txt
+++ b/runtime/doc/terminal.txt
@@ -1022,8 +1022,10 @@ create a security problem.
 						*terminal-autoshelldir*
 This can be used to pass the current directory from a shell to Vim.
 Put this in your .vimrc: >
-	def g:Tapi_lcd(_, args: string)
-	    execute 'silent lcd ' .. args
+	def g:Tapi_lcd(_, path: string)
+            if path->isdirectory()
+                execute $'silent lcd {path}'
+            endif
 	enddef
 <
 And, in a bash init file: >

Right.  On top of that fnameescape() should be ued.
--
Q: What's orange and sounds like a parrot?
A: A carrot
/// Bram Moolenaar -- @.*** -- http://www.Moolenaar.net   \
///                                                                      \
\\        sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ ///
\\            help me help AIDS victims -- http://ICCF-Holland.org    ///

Steps to reproduce
Run these shell commands:
$ rm -rf /tmp/home/user/.config/fish/
$ mkdir -p /tmp/home/user/.config/fish/

$ tee >/tmp/home/user/.config/fish/config.fish <<'EOF'
    if test -n "$VIM_TERMINAL"
        function _vim_sync_PWD --on-variable=PWD
            printf '\033]7;file://%s\033\\' "$PWD"
        end
    end
EOF

$ rm /tmp/log

$ XDG_CONFIG_HOME=/tmp/home/user/.config/ vim -Nu NONE --log /tmp/log \
  +'set autoshelldir' \
  +'autocmd TerminalWinOpen * call term_sendkeys("", "cd /tmp\<CR>")' \
  +'terminal /home/lgc/VCS/fish/build/fish'

An error is given:
E1179: Failed to extract PWD from /tmp^[\, check your shell's config related to OSC 7

Next, execute this Ex command to quit Vim:
:quitall!

Finally, run this shell command to read the RECV lines from the logfile:
$ vim -Nu NONE +'vglobal /RECV/ delete _' /tmp/log

You should see that the OSC 7 sequence has been received in several chunks.  For example:
RECV on 0(out): '^[]7;fi'
RECV on 0(out): 'le:///tmp^[\'

Expected behavior
No error is given.  The Vim current working directory is synchronized
with the one of the shell running in the Vim terminal buffer.

Can you simulate this without an actual fish shell doing this?
Perhaps the code in parse_osc() that collects a JSON string can also be
used to concatenate fragments of the OSC 7 sequence.  This is in
src/terminal.c, parse_osc().  Currently sync_shell_dir() is called on
the fragment itself, while for OSC 51 we collect them until the final
piece is received.
I'll make a patch, please try it out.  I haven't added a test, that
takes some puzzling.
--
Q: What do you call a fish without an eye?
A: fsh!
Q: What do you call a deer with no eyes?
A: no eye deer.
Q: What do you call a deer with no eyes and no legs?
A: still no eye deer.
/// Bram Moolenaar -- @.*** -- http://www.Moolenaar.net   \
///                                                                      \
\\        sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ ///
\\            help me help AIDS victims -- http://ICCF-Holland.org    ///

Can you simulate this without an actual fish shell doing this?

Sorry, but that's above my level.  I just stumbled on the issue.

I'll make a patch, please try it out.

I can confirm that the patch fixes the issue.  Thank you very much.


[Looking for info]DocumentDbBotDataStore causes HTTP 404 responses under normal operating conditions #57

Hi All,
when can we expect the fix for the below to make it into the botbuidler sdk?
https://github.com/Microsoft/BotBuilder-Azure/pull/56
DocumentDbBotDataStore causes HTTP 404 responses under normal operating conditions #57
Kind Regards,
Thomas

Thank you for opening an issue against the BotBuilder-Azure repo. As part of the Bot Framework v4 release, we’ve moved all the Azure related work to the platform SDK repo. We will continue to support and offer maintenance updates via this repo.
From now on, https://github.com/Microsoft/botframework-sdk repo will be used as hub, with pointers to all the different SDK languages, tools and samples repos.
As part of this restructuring, we are closing all tickets in this repo.
For defects or feature requests, please create a new issue in the Bot Framework repo found here:
https://github.com/Microsoft/botframework-sdk/issues
For product behavior, how-to, or general understanding questions, please use Stackoverflow.
https://stackoverflow.com/search?q=bot+framework
Thank you.
The Bot Framework Team


 Are you able to fix the conflicts so we can merge the PR? Alternatively, you can close it and make a new one for the Code Fixes. Let us know😄

Yeah, I can. I just might need a few days if that's okay.

@dario-coscia Yeah, I can. I just might need a few days if that's okay.

Yes, take your time. Thank for the help :)


SRCDS Errors / Wont Start

Seems the server wont start, let alone look in the public directory.
18:47:28 - verbose: Creating base config file for e759b977-c0eb-426a-b0c8-7229251dc014 meta=undefined
18:47:28 - verbose: Creating user pp-gmod-t_u9fdt on the server... meta=undefined
18:47:28 - verbose: User pp-gmod-t_u9fdt created. meta=undefined
18:47:28 - verbose: Finished basic install process for new server, preparing to complete full install process. meta=undefined
18:47:28 - warn: Running major installer process for e759b977-c0eb-426a-b0c8-7229251dc014 which could take a few minutes to complete... DO NOT SHUTDOWN SCALES DURING THIS PROCESS. meta=undefined
18:48:31 - verbose: Config for server 6528be33-c28e-4fe5-89d9-7e156e4421ff has been updated by a remote source. meta=undefined
18:49:55 - verbose: Installer process has completed for for e759b977-c0eb-426a-b0c8-7229251dc014 meta=undefined
18:49:55 - verbose: Major install process completed and PufferPanel notified. meta=undefined
18:55:40 - verbose: Config for server e759b977-c0eb-426a-b0c8-7229251dc014 has been updated by a remote source. meta=undefined
19:14:04 - verbose: Config for server e759b977-c0eb-426a-b0c8-7229251dc014 has been updated by a remote source. meta=undefined
19:14:14 - verbose: Running preflight for server e759b977-c0eb-426a-b0c8-7229251dc014 meta=undefined
19:14:14 - verbose: Completed permissions preflight for server e759b977-c0eb-426a-b0c8-7229251dc014 meta=undefined
19:14:14 - verbose: Running plugin preflight for server e759b977-c0eb-426a-b0c8-7229251dc014 meta=undefined
19:14:14 - error: Error detected while trying to open and read /home/pp-gmod-t_u9fdt/srcds_run errno=-2, code=ENOENT, path=/home/pp-gmod-t_u9fdt/srcds_run
19:14:14 - error: ENOENT, open '/home/pp-gmod-t_u9fdt/srcds_run' meta=undefined

This is a better issue for the @PufferPanel/Scales repository if you could remake it there.

Closed for reason above.


Support for Heroku 16

I recently used this build pack to generate PDF file using unoconv on Heroku 16. I am documenting my finding and issue so in case other folks are running into similar issue and can help out.

Out of the box, after libreoffice is installed, when I ran unoconv, it threw an error saying office installation is not found.  To fix it, I had to set UNO_PATH in compile file at the bottom

# Set UNO_PATH so unoconv can search for libreoffice
echo 'export UNO_PATH="$HOME/vendor/libreoffice"' >> $PROFILE_PATH

After that, unoconv complained as follows:

error: "Traceback (most recent call last): File "/app/unoconv", line 810, in connect unocontext = resolver.resolve("uno:%s" % op.connection) uno.NoConnectException: Connector : couldn't connect to socket (Success) During handling of the above exception, another exception occurred: Traceback (most recent call last): File "/app/unoconv", line 1392, in <module> main() File "/app/unoconv", line 1306, in main convertor = Convertor() File "/app/unoconv", line 789, in __init__ unocontext = self.connect(resolver) File "/app/unoconv", line 821, in connect product = self.svcmgr.createInstance("com.sun.star.configuration.ConfigurationProvider").createInstanceWithArguments("com.sun.star.configuration.ConfigurationAccess", UnoProps(nodepath="/org.openoffice.Setup/Product")) __main__.CannotActivateFactoryException: loading component library <file:///app/vendor/libreoffice/program/../program/libmergedlo.so> failed "

I ran ldd libmergedlo.so. It said three shared libraries are missing - libGL, libSM, libICE. We are running on heroku 16. After reading  https://devcenter.heroku.com/articles/stack-packages, it seems Heroku removes corresponding libraries from runtime which explains the issue. So I used https://elements.heroku.com/buildpacks/heroku/heroku-buildpack-apt as well with Aptfile as

libice-dev
libice6
libsm-dev
libsm6

This fixed the issue complaining that libSM, libICE shared libraries are missing. However, it is still looking for libGL.so.1 (which is 32 bit version I believe).
I am stuck here. I tried various thing such as trying to instruct apt buildpack to download 32 bit version of libGL or creating a link of libGL.so.1 to libGL.so.8 (under /app/vendor/libreoffice/program) but both approach failed and running ldd libmergedlo.so still complains that libGL.so.1 is missing.
Any help would be greatly appreciated.

Hello @jjalan!
Got the same problem, and I solved it the following way:

Used https://elements.heroku.com/buildpacks/heroku/heroku-buildpack-apt from the beggining with the following Aptfile:

libreoffice
libxfixes3
libxinerama-dev
libxinerama1
libxdamage1
libglu1-mesa:i386

(libreoffice asked me for another libraries after step 2, that's why those extra dependencies are there)

Ran the following command (to create a link):
ln -s  ~/.apt/usr/lib/x86_64-linux-gnu/mesa/libGL.so.1 ~/.apt/usr/lib/x86_64-linux-gnu/

And it worked!
I didn't use unoconv, but I really hope you can solve it with these steps!


Refactor render functions for AML & Kubeflow into series of isolated common functions

Closing since a lot of this refactoring work is done, and we aren't planning to support AML right now.


Update docs to v2 config

Config changed in #1163

/ok-to-test

anything else here?

no just waiting for Lantau to get back as he had worked on this..


Login not working

I'm logged to the chat.openai.com, but It just keeps asking to login and doesn't give me answer

I figured out it was the brave browser's fingerprint option. It works well!


decouple find IndexSegment with SQLStatement

For #4342.

Codecov Report

Merging #4364 into master will increase coverage by 0.01%.
The diff coverage is 100%.

@@             Coverage Diff             @@
##             master   #4364      +/-   ##
===========================================
+ Coverage     53.88%   53.9%   +0.01%
  Complexity      351     351
===========================================
  Files          1047    1047
  Lines         19288   19296       +8
  Branches       3550    3553       +3
===========================================
+ Hits          10393   10401       +8
  Misses         8238    8238
  Partials        657     657

Impacted Files
Coverage Δ
Complexity Δ

...rite/token/generator/impl/IndexTokenGenerator.java
100% <100%> (ø)
1 <0> (ø)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6ce5057...3b4d01e. Read the comment docs.

Pull Request Test Coverage Report for Build 9644

12 of 12 (100.0%)  changed or added relevant lines in 1 file are covered.
4 unchanged lines in 2 files lost coverage.
Overall coverage increased (+0.007%) to 57.359%

Files with Coverage Reduction
New Missed Lines
%

sharding-orchestration/sharding-orchestration-center/sharding-orchestration-center-apollo/src/main/java/org/apache/shardingsphere/orchestration/center/instance/ApolloInstance.java
1
59.46%

sharding-orchestration/sharding-orchestration-core/src/main/java/org/apache/shardingsphere/orchestration/internal/util/IpUtils.java
3
76.0%

Totals

Change from base Build 880:
0.007%

Covered Lines:
11068

Relevant Lines:
19296

💛  - Coveralls


Can't Dynamically Render Markers?

Hey There,
So I have a situation where I am capturing the geolocation and placing it on the map.  This is not available on initial load so it is just null should it not be available yet.
Unfortunately GoogleMap produces errors in this situation as it tries to render null as a marker and fails.  I've tried everything I can think of but it seems that any value at all must be a valid marker at time of rendering or you can't use it?

Here is the example with null as map child, no error
https://jsbin.com/worufiredo/edit?js,console,output


Figure out a sane way to load Tern definition files for browser, es5

If you look at how the JS hints code works, it's expecting to be able to load JSON definition files directly from the filesystem: https://github.com/humphd/brackets/blob/bramble/src/extensions/default/JavaScriptCodeHints/ScopeManager.js#L59-L109
This works well in desktop Brackets, but won't work in browser, unless you somehow seed the filesystem with these files before they are needed (an option).  I'd like to figure out how expensive it would be (in terms of download size) to alter this code to use require and the text plugin to just load them on startup vs. trying to get them from disk.  Having at least defs/browser.json and defs/ecma5.json is probably smart, since it means we get really useful autocomplete for things you'd often use in browser-based JS.
Another option would be to somehow download these JSON files after startup if they don't exist in the filesystem, and then cache them for future use.

See http://ternjs.net/doc/manual.html#typedef to understand the way that these files work.

NOTE: we killed the WebPlatformDocs extension for doing this exact same thing, and maybe the solution we use here will also mean we can do the same for it.

I think we can fork these files and drop the !url and !doc bits to save a bunch of space.  It don't think Brackets uses them at present, and they will just add download size we don't need.


variable passing to Lua Plugins issue

When trying to get C# type variables like "long" from a Datafile which was created by a C# plugin, the lua plugin already recieves the value as a lua number type. Lua does not like these values, so the values are not correct. Would propably be fixable using :ToString(), but as Oxide already passed it to the plugin as a "number" type variable, its to late for that.

---
Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/28045977-variable-passing-to-lua-plugins-issue?utm_campaign=plugin&utm_content=tracker%2F6855523&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F6855523&utm_medium=issues&utm_source=github).

From @Mughisi:

The variable passing for Lua is something plugin authors just need to keep in mind. Lua just doesn't support the long ints.


Auto record on start

How can I set the application to auto start recording?
I have tried to insert these lines inside the fragment onViewCreated but without success:
mIsRecordingVideo = true;
or startRecordingVideo();
Can someone help?
Thanks in advance

I could make my app with auto recording. What I've done was to write the whole code inside the activity instead of using Fragment. And here is my code to enable auto recording:
`private CameraDevice.StateCallback mStateCallback = new CameraDevice.StateCallback() {
    @Override
    public void onOpened(@NonNull CameraDevice cameraDevice) {
        mCameraDevice = cameraDevice;
        startPreview();
        mCameraOpenCloseLock.release();
        if (null != mTextureView) {
            configureTransform(mTextureView.getWidth(), mTextureView.getHeight());
        }

        // auto record
        if (mIsRecordingVideo) {
            try {
                createVideoFileName();
            } catch (IOException e) {
                e.printStackTrace();
            }

            startRecordingVideo();
            mMediaRecorder.start();
            runOnUiThread(new Runnable() {
                @Override
                public void run() {
                    countDownTimer.start();
                }
            });
        }
    }

    @Override
    public void onDisconnected(@NonNull CameraDevice cameraDevice) {
        mCameraOpenCloseLock.release();
        cameraDevice.close();
        mCameraDevice = null;
    }

    @Override
    public void onError(@NonNull CameraDevice cameraDevice, int error) {
        mCameraOpenCloseLock.release();
        cameraDevice.close();
        mCameraDevice = null;
        finish();
    }

};`

This sample has been migrated to a new location where we can accept Pull Requests (check README for more information).
As recommended by GitHub, we are closing all issues and pull requests now that this older repo will be archived.
If you still see this issue in the updated repo, please reopen the issue/PR there. Thank you!


README uninformative

The README says how to install semsimian but doesn't say what it is.

closed by #94


[beta] Improve Instructions for "Regular Expressions: Ignore Case While Matching"

Challenge ignore-case-while-matching has an issue.
User Agent is: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/56.0.2924.76 Safari/537.36.
It feels like these two sentences could be combined into a shorter alternative.

There are other flags but here you'll focus on the flag that ignores case.
The flag that ignores case is the i flag.

I suggest we replace the sentences above with

There are other flags, but here you'll focus on the one that ignores case - the i flag.

Sounds good to me. I wrote these instructions and thought it would be nice to preface the introduction with some motivation. But I also like conciseness 👍
So the third paragraph should now read

You can match both cases using what is called a flag. There are other flags, but here you'll focus on the flag that ignores case - the i flag. You can use it by appending it to the regex. An example of using this flag is /ignorecase/i. This regex can match the strings "ignorecase", "igNoreCase", and "IgnoreCase".

I'll take this up..


Special enumerator leads to InvalidOperationException in TypeKey class

DockPanel Suite assembly compiled by Roslyn compiler has special enumerators such as WeifenLuo.WinFormsUI.Docking.AutoHideStripBase/TabCollection/<System.Collections.Generic.IEnumerable<WeifenLuo.WinFormsUI.Docking.AutoHideStripBase.Tab>.GetEnumerator>d__0.
The name contains two namespaces (<System.Collections.Generic.IEnumerable<WeifenLuo.WinFormsUI.Docking.AutoHideStripBase.Tab> for itself, and WeifenLuo.WinFormsUI.Docking for its declaring type), and confuses Obfuscar TypeKey class. The first namespace is not processed, which leads to InvalidOperationException.

Fixed in 1d6ab9317b9475a017a8af0e09ec0abf8456c863.


Port Script as s-c-s processor

From @sabbyanandan on November 14, 2015 0:14
As a developer, I'd like to port script module from XD to s-c-s repo, so I can use it as processor module to build streaming pipeline.
Acceptance:

script as processor module is available in spring-cloud-stream-modules repo
maven repo includes script module with respective group/artifact/version detail

Copied from original issue: spring-cloud/spring-cloud-stream-modules#84

This issue was moved to spring-cloud-stream-app-starters/app-starters-release#16


[MXNet-1211] Factor and "Like" modes in BilinearResize2D operator

Description
This PR adds few options to BilinearResize2D operator. This options are needed for Fully-Convolutional realization of nets, that uses bilinear resize. The added modes are "odd_scale", "like" and few options to change height and width of tensor to even or odd: "to_even_down", "to_even_up", "to_odd_down", "to_odd_up".
Such transformations couldn't be done in other ways because when we use symbolic models we can't get tensors shapes from Python or any other frontend.
With these mods it is is possible to realize segmentation network ICNet that could work with input of any size.
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.

[x] Changes are complete (i.e. I finished coding on this PR)
[x] For user-facing API changes, API doc string has been updated.
[x] To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

"Odd-scale" is for getting odd height and width, for example for pooling, which is recommended by authors of DeepLab and ICNet. So if we have tensor with shape (n, c, 65, 33) we can resize it to (n, c, 33, 17) with parameters (scale_height=0.5, scale_width=0.5, mode='odd_scale') and back with parameters (scale_height=2, scale_width=2, mode='odd_scale')
"Like" is also useful mode which could be used in decoders of segmentation networks. It resizes first input to the shape of second input.
"to_even_..." and "to_odd_..." modes changes height and width to even and odd value respectively adding or subtracting 1 from h and w if required.
Changes in visualization.py are needed for normal graph visualization when using mode "Like". In this mode there are two input nodes, but actually one of them is used only for getting desired shape. Information about it in graph isn't important but graph becomes too complicated. So this change just deletes dependence from "like"-node.

Comments

The changes are almost backward-compatible: since we added mode "like", the operator takes two inputs, so in other modes second positional argument in Python (or other) should be None, and height and width became third and forth positional arguments respectively. So, some code, which used height and width as positional argument will not work.

@mxnet-label-bot add [pr-awaiting-review]

@apeforest @samskalicky @yuxihu @ChaiBapchya could you please take a look at this?

I'm realy sorry for force push, I get confused with rebase and commited all master to this branch, after that tried to roll back and finally erased my first commits. :(

Thank you, @ChaiBapchya.
As I understood the build has failed because of the timeout.
Branches [GPU: MKLDNN ] and [GPU: MKLDNN_CUDNNOFF] has failed.
In pipeline there are lines:
[GPU: MKLDNN] Running on mxnetlinux-cpu_x4398dm2a1 in /home/jenkins_slave/workspace/alidation_unix-gpu_PR-13226-7WOHJMMJA2UQ45SCSTCQK6UH3VENFWCLRGEEC4X3CRC25ELVL4IQ
[Pipeline] [GPU: MKLDNN] {
[Pipeline] [GPU: MKLDNN] ws
[GPU: MKLDNN] Running in /home/jenkins_slave/workspace/build-mkldnn-gpu
[Pipeline] [GPU: MKLDNN] {
[Pipeline] [GPU: MKLDNN] timeout
[GPU: MKLDNN] Timeout set to expire in 2 hr 0 min
[Pipeline] [GPU: MKLDNN] {

And in the log file of build there is no error and it starts at 19:30 and fails at 21:30:
[build-mkldnn-gpu] Running shell script
+ ci/build.py --docker-registry mxnetci --platform ubuntu_build_cuda --docker-build-retries 3 --shm-size 500m /work/runtime_functions.sh build_ubuntu_gpu_mkldnn
build.py: 2018-11-30 19:30:49,272Z INFO MXNet container based build tool.
...
Sending interrupt signal to process
build.py: 2018-11-30 21:30:29,503Z WARNING Signal 15 received, cleaning up...
build.py: 2018-11-30 21:30:29,503Z WARNING Cleaning up containers
Terminated
script returned exit code 143

The same for [GPU: MKLDNN_CUDNNOFF]. No error in log, build script lasts for 1h 59m 55s and receives interrupt signal. Jenkins build description.
What should I do with this problem?

@lobanov-m this was around the time we were changing our CI. can you retrigger the build (push an empty commit).

@anirudhacharya @azai91 - ping for review :-)

@mxnet-label-bot update [pr-awaiting-response]

Rebase done.

@mxnet-label-bot update [pr-awaiting-review]

@mxnet-label-bot add [pr-awaiting-merge]
@lobanov-m please rebase your PR to resolve conflicts.

@mxnet-label-bot remove[pr-awaiting-review]

@mxnet-label-bot add[pr-awaiting-response]

@lobanov-m please rebase your PR to resolve conflicts so it can be merged

@mxnet-label-bot add[pr-awaiting-review]

@mxnet-label-bot remove[pr-awaiting-response]

@pinaraws rebase done

Built failed because of
test_model.R:129: error: Fine-tune
cannot open URL 'http://data.dmlc.ml/models/imagenet/inception-bn/Inception-BN-0126.params'
1: GetInception() at R-package/tests/testthat/test_model.R:129

and the second error:
--2019-03-25 08:58:30--  (try: 2)  http://data.dmlc.ml/mxnet/models/imagenet/inception-bn.tar.gz
Connecting to data.dmlc.ml (data.dmlc.ml)|<IP_ADDRESS>|:80... failed: Connection timed out.
Retrying.

Rscript -e "library(devtools); library(methods); options(repos=c(CRAN='https://cloud.r-project.org/')); install_deps(pkg='R-package', dependencies = TRUE)"
Error in library(devtools) : there is no package called 'devtools'

@anirudhacharya Are all your concerns addressed on this PR ?
Is this good to merge ?

@piyushghai yes, my concerns are addressed, please see here - https://github.com/apache/incubator-mxnet/pull/13226#pullrequestreview-191881862

@ChaiBapchya Are your concerns also addressed on this PR ?

@lobanov-m Can you please resolve conflicts?

@Roshrini rebase done.

Glad to merge it. Thank you!

It's good news. Thank you!


Minor: Use ::create() instead of new on GridFieldConfig_RelationEditor

I was refactoring some of my own code when I stumbled upon this in the framework, instantiating a child instance of GridFieldConfig via new keyword instead of the ::create() injector.
https://github.com/silverstripe/silverstripe-framework/blob/3/security/Group.php#L111
What branch would a quick fix for something like this go? Maybe 3.1?

I'd put this into 3.2 one for now. :) 3.1 isn't going to get much love once 3.2 is stable.

@patricknelson nice work. That's always niggled at me, that one.

Ok super simple; posted a PR.
In my case I had to override ALL of the children of GridFieldConfig  (along with the intended override of that class itself) since apparently instantiating GridFieldConfig_RelationEditor would end up giving me an instance of the custom class which was intended only for the parent class.
For example: If you setup ClassA and ClassB (B extending A) but inject only ClassA with InjectA class and then call ClassB::create(), SilverStripe will only give you an instance of InjectA -- completely avoiding ClassB.

Fixed with https://github.com/silverstripe/silverstripe-framework/pull/4600


[Bug] Failure to test RMWC TabBar using React Testing Library - onActivate not called when click on tab

What RMWC Version are you using: 5.7.1
Name your build system: Jest and React Testing Library
Describe the bug with as much detail as possible: Using React Testing Library, I'm trying to simulate clicking on a tab. However, onActivate function is not called.
What happened, and what was supposed to happen: onActivate callback is not called when clicking on a tab using fireEvent.click. onActivate is supposed to be called.

How to reproduce

Render a TabBar with 3 tabs (Sandbox: https://codesandbox.io/s/rmwc-typescript-sandbox-forked-mj0c0)

import { TabBar, Tab } from '@rmwc/tabs'

<TabBar
  activeTabIndex={1}
  onActivate={evt => {
    const tabIndex = evt.detail.index
    console.log({ tab: tabIndex })
}}>
  <Tab>Tab 1</Tab>
  <Tab data-testid="tab-2">Tab 2</Tab>
  <Tab>Tab 3</Tab>
</TabBar>

Try to click Tab 2 with fireEvent.click

import { render, fireEvent } from '@testing-library/react'

it('should call onActivate', () => {
    const wrapper = render(<Sandbox />)
    fireEvent.click(wrapper.getByTestId('tab-2'))
    // console.log not called, no log
})

The button is rendered properly with testId though

<button class="mdc-tab" data-testid="tab-2">

      Tab2

</button>

Workaround: The above code work if I listen to onClick event directly on Tab component

<Tab data-testid="tab-2" onClick={() => console.log('clicked')}>Tab 2</Tab>

Can you try using user-event? https://github.com/testing-library/user-event

Thank for your suggestion, I tried using user-event, onActivate is still not called :(
import userEvent from '@testing-library/user-event'

it('should call onActivate', () => {
    const wrapper = render(<Sandbox />)
    userEvent.click(wrapper.getByTestId('tab-2'))
    // still console.log is not called
})

I experience the same issue in 6.14. My workaround is to put the callback on <Tab onInteraction={callback}>Tab 1</Tab>

I experience the same issue in 6.1.4. My workaround is to put the callback on <Tab onInteraction={callback}>Tab 1</Tab>

Yeah I can also use onClick on everytab Tab component itself. I feel like it's not the ideal solution :(

onInteraction is better since it supports both click and keyboard events.


Closing bracket scope reported as "source.cpp" when preceded by a #endif

Checklist

[x] This problem exists even with the setting "C_Cpp.enhancedColorization": "Disabled"

The code with a problem is:
if (1 === 1) {
    #ifdef DIRECTIVE

    #endif
} // <- the scope of this bracket is only "source.cpp"

It looks like:
The closing bracket scope is source.cpp.

This seem to happen due to this line: https://github.com/jeff-hykin/better-cpp-syntax/blob/master/syntaxes/cpp.tmLanguage.json#L558
I don't have a lot of experience with Textmate grammars, but I am wondering why the second part of the regex is needed there.
(?=\s*#\s*(?:elif|else|endif)\b)
They seem to have some weird matches on: https://regex101.com/r/Xhdau3/1 and I don't see how those #endif directives can close a block? Could you help me understand what's the issue?
It should look like:
The closing bracket scope should be:
punctuation.section.block.end.bracket.curly.cpp
meta.block.cpp
source.cpp
This is correct if I remove the second part of the regex:

don't see how those #endif directives can close a block?

You and me both. The only time things should get chomped like that are if a while was used, or if there was an inline pattern that first matches a chunk of text then internally includes a pattern-range on that one-line-or-less match (the pattern range will not ever exceed the one-line-or-less chunk). However neither of those are the case here. Makes me wonder if its actually an issue with the implementation of Textmate.
Anyways, while I was busy being baffeled by that I found some other issues with the preprocessor patterns, specifically the one you mentioned. Your case was fixed, but other test cases were failing.
I removed all the endif patterns entirely and the behavior was still happening.  That chunk was from some really old legacy code from before this repository.
That said, now the actual issue is fixed on v1.17.2


Updated link to pretrained fastText vectors

Current link leads to a 404 page.
Proposed changes:

...

Status (please check what you already did):

[ ] made PR ready for code review
[ ] added some tests for the functionality
[ ] updated the documentation
[ ] updated the changelog
[ ] reformat files using black (please check Readme for instructions)

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Adding new task for configuring iis application pool

Hi @adsurang, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. I promise there's no faxing. https://cla.microsoft.com.

TTYL, MSBOT;

I'm concerned that this is a granular action which puts us back on a course to be a workflow engine.  Should the task instead be DeployIISSite and that course grained task has appool options on it.

@adsurang, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR.
Thanks, MSBOT;

Yes Bryan I agree , we initially planed to make this task  part if IIS web application deployment task but then IIS web application deployment task was becoming big and points of failure for task were increasing. So we decided to create a seperate task for app pool and web site creation will be other task. Also User does not need to use this task if he want to deploy his web site on already existing app pool


Highlighting feature

Would be great to have such feature. In any form, either highlighted matched words (configurable to which elements/tags to wrap) or just positional information of matched tokens (so highlighting itself could be done outside of the elasticlunr.js).

Hi, @vladimiry , thanks very much for your idea.
Your idea is great, but currently our data structure doesnot support record the position of each word, that means increase the index size. But your idea is really brilliant.
In the future I will add support for your idea.

Any update on this feature request?


add java client link

Adds java client link to the Client libraries list:

Merge after the Client library is ready

Should also add examples for each library.
Also, consider refactor to have one codeblock contain examples for each language, like they are on the openapi redoc page:

This prevents examples from being cluttered.


StopAudio() and conference.mute()

My app contains a functionality to mute other participants. Currently to do this, I am using conference.mute() along with ably events to allow participants to mute other remote participant. I want to use StopAudio() to achieve this, because it works for remote participant as well. But stopAudio() fails in the case when I have already switched off the video and then use stopAudio() to mute other remote participant. In this case, the participant is removed from the conference. How can I use stopAudio() to mute a remote participant?

Hi @kunal13053, what do you mean by “removed from the conference”?
In the getting started application (if Dolby Voice is off), you can turn off both audio and video for a participant. This will remove the DOM element that represents the participant but (s)he is still in the conference.

Hi @kunal13053, what do you mean by “removed from the conference”?
In the getting started application (if Dolby Voice is off), you can turn off both audio and video for a participant. This will remove the DOM element that represents the participant but (s)he is still in the conference.

I was able to get it working by using just stopAudio(). I completely removed my implementation of using conference.mute() in the ably channels. It's working fine now. Thanks!

I was able to get it working by using just stopAudio(). I completely removed my implementation of using conference.mute() in the ably channels. It's working fine now. Thanks!


Accessibility page refreshed to incorporate Research Library

Link to subfeature: https://wellcomecollection.productboard.com/feature-board/planning/features/4869650

Closing as context lost.


THRIFT-4303 Update ubuntu-xenial to use D 2.087.0

Update the ubuntu-xenial Docker container to use D 2.087.0.

[X] Did you create an Apache Jira ticket?  (not required for trivial changes)
[X] If a ticket exists: Does your pull request title follow the pattern "THRIFT-NNNN: describe my issue"?
[X] Did you squash your changes to a single commit?  (not required, but preferred)
[X] Did you do your best to avoid breaking changes?  If one was needed, did you label the Jira ticket with "Breaking-Change"?
[ ] If your change does not involve any code, include [skip ci] anywhere in the commit message to free up build resources.

Found a problem with this PR. Closing.


down and dirty filter to use a pipe delimiter in markdown image descr…

This is a very simple filter that iterates each line of text and mangles alt="this is the alt|classes here" into alt="this is the alt" class="classes here", eg:
{{ item.content | markdown | imgAltClass }}
Ideally, and IMO, marked should be replaced with something that supports Markdown Extras, so you can use the {.class key=val} stuff, but I think this will suffice for now.

@gpbmike @snide @LtSquigs - Thoughts on this PR?

Ian and I talked about it today. It IS a hack, but to be honest so are all the markdown "extra" libraries. Ian will give this a test later tonight.

Understood. The goal was to not interfere with anything else, but rather to just provide a dirty regexp to reformat the image alt tags from the marked output (via the WH "markdown" filter.)


Error "Required value: must specify a platform" for field "spec.platform".

We are encountering the following issue when trying to create a clusterdeployment fo IBM cloud:

Is this because our version of Hive is outdated?

This is an issue with our ValidatingWebhookConfiguration.


[webview_flutter] Add Android debug mode

Add configurable debug parameters to debug in browsers

Thanks for the contribution!
This was already added by https://github.com/flutter/plugins/pull/1401


Added translations for new features & few improvements

Added translations for:

Settings.DisableLAN
Settings.Audio.Master

+ few improvements on stuff found while going trough the locale.
(this comment will be updated if more changes will be made before this pull request's merge/closing)

Thank you for the additions and improvements!


WinVind stops when right-clicked in tray [Bug]

Describe the bug
Recently, whenever I right click the win-vind icon in the tray, the app closes. This wasn't the behavior before, where a menu appears with options like showing the configuration file location. This issue is only with win-vind, all other icons show their menus.
Environment (please complete the following information):

Windows 10 Edition: Home
OS Type: 64bit
OS Version: 10.0.19042
OS Build: Build 19042
win-vind Version: 4.0.1
win-vind Type: installer
Is it reproducible?: Not sure

What I tried:

Uninstalling/installing
Removing my .vindrc file
Restarting the computer

Thanks

Thank you for using it!
Are there any errors in ~/.win-vind/log/error_*.log after it?

Hi,
Thanks for replying.
There is an error log file, but it's unfortunately empty.
Thanks.

Thanks, I understand.
When right-clicking on the tray icon (code), win-vind scans shortcut files in the startup folder (code) and show a checkmark of Startup with Windows in the popup menu. I guess that the scanning was crashed for some reason.
So, please try opening the folder by shell:startup with Win+R and delete the win-vind shortcut files manually.

By the way, also try the zip version to see if there is the same problem, and check log files as well.
If these solution does not work, I will try my best to debug and test.
I hope it works.

Hi,
Unfortunately, neither methods worked :( .
Thanks

To confirm that it is not an app interfering, I booted in safe mode, and the same issue persists.
Thanks

Hi, thank you for trying everything. I will try to further the logic test.
I ran on three different computers in the same environment as yours, but could not reproduce.
If you allow it, we find the cause by running win-vind for debug. In this case, you can either run the debug build I prepared (open source, of course), or build and debug the code in the popup section programmatically in your environment.
Thanks.

Hi,
Thanks for replying.
I am really not sure why this happens. It was working perfectly before.
Where can I find the debug version of the app? I am not that technical, so I would be grateful if you could provide me with detailed steps.
Thanks again.

I built debug version to log the behavior right-click and crashing.
Here are the steps.

Download this version win-vind_4.0.1_issue25_1_64bit.zip. BTW, code is here.
Unzip it and place it in the user permission directory (e.g. ~/Desktop)
Execute it and right-click on its icon in the tray.
Copy the texts of win-vind/log/error*.log and share them with me. However, since the user name will be collected, so please show it in a limited public scope (e.g. Gist Private).

I hope it works.
Thanks

Hi again,
I can confirm that it was an issue from my side. I reset my Windows 10 OS, and Win-Vind now functions normally. However, from my humble investigation, the issue might be related to ntdll.dll.  Thanks for your cooperation and support. I hope no one faces this issue again. Thanks for making this great piece of software.
Kind regards

I'm glad it works!
I wish I knew the cause of the problem... I'll investigate using the ntdll.dll as a clue more.
Thanks for your contribution and the sponsorship!
Please let me know if you have any more problems. Thanks!


Revert "Use the new Telegram logo for the Bot API badge (#198)"

This reverts commit a4a17ec40cff663bd4eae9a6c3314fa9807c3769.
Reason for the revert:

shields.io was updated and is using the new Telegram logo now (https://github.com/badges/shields/pull/7831).

Have you considered signing your commits in the future?
I'll merge this now either way.

You usually do this, right? 🤔

I usually do what? 🤔

Signing