Privacy leak when resharing tag+ posts

From @solstag on November 28, 2014 20:14
Ni!

Click to reshare an item posted @someforum+

Add a mention to @!someforum, or @someforum and use the ACL so only it can see

(perhaps you want to privately call the owner's attention to an evil post on his wall)

The post ends up in the forum's wall!

(seems like the + is being interpreted although it is within the [share] element)
I've frobbed with this and those seem to be the only cases where this happens.
Copied from original issue: friendica/red#714

From @friendica on January 8, 2015 2:45
Have followed this set of steps precisely and cannot duplicate. The private post (private mention in this case) is visible in the forum's network stream as a private post, but is not visible on the forum's wall. So something else is necessary to trigger this behaviour.

From @solstag on February 4, 2015 6:34
Thanks for looking into this. After the last month of changes I can't reproduce this behavior anymore. No idea why :/ but if I recall correctly there were some changes to tag handling, so probably got fixed along the way. Closing :)


Test: Kubectl helper print stdout instead of write a new step.

When use BY a new STEP header is written, to debug make it difficult
to understand in what status the test is. If we use GinkgoPrint will
print the output, but no with the STEP header.
Signed-off-by: Eloy Coto<EMAIL_ADDRESS>

This change is

test-me-please

Coverage decreased (-0.006%) to 43.396% when pulling 622ccbacdf2462e0e9e8a5a42e0e467dc17b933c on eloycoto:ByONHealth into ba50f395eaf3b8599ccf1ed9c8413d55739caac9 on cilium:master.

test-me-please


Update from Phore upstream v1.2.2

DON'T merge this PR to master branch. Please create a new branch named update-v1.2.2 and merge there.
And when merging it, be sure to keep the commit history, don't squash the PR into a single commit.
This update has some problems that we need to investigate.
When running this update on mainnet, it reports error "incorrect proof of work (DGW pre-fork)" at block 37 and the sync can't continue. The PoW related code was not changed in this update.
When I tried the send-qt downloaded from the official site, send-qt doesn't sync at all and report error "Check your wallet version, there is a new protocol on the network.".
We need to make send-qt works, then see if it has issues on block 37.

I build the master and do a test, the sync gets stuck at block 37 for PoW verification error, same as the one in the PR.

I build the master and do a test, the sync gets stuck at block 37 for PoW verification error, same as the one in the PR.

I have the same issue.  It was a missed problem between version <IP_ADDRESS> and <IP_ADDRESS>. I am not sure exactly what the change or issue is yet..  Version <IP_ADDRESS> should not have this issue and is able to sync.
The warning about protocol version is just an alert message about a protocol version change, and should not effect anything.

When I tried the send-qt downloaded from the official site, send-qt doesn't sync at all and report error "Check your wallet version, there is a new protocol on the network.".

Please try adding some nodes manually.  I am not sure if the seed nodes listed in the older version are still online.  Ignore the protocol version warning..
Try these nodes to get synced up:

fr.socialsend.io
de.socialsend.io
us-e1.socialsend.io
us-e2.socialsend.io

I will create the PR to https://github.com/TheSocialSendProject/SocialSend


Cosmetic: the home screen's swipe animation is enlarged, offsetted and partially disappears off-screen because of that

Maybe what could cause this if for some reason the Get package's media queries return different width/height in the early phase of game start. Because inherently everywhere in the code I request width/height from there.

This is still an issue after Sound null safety upgrade!

Maybe this is normalized now with Dart 3+ and Flutter SDK 3+? Need to retest.


Fully automate the creation of cluster VMs

30/JUN/21

@RoyWilliams and @tms-epcc agreed this is being dealt with in Cycle-4 under Architecture Development

See ansible scripts
https://github.com/lsst-uk/lasair-lsst/tree/master/ansible
https://github.com/lsst-uk/lasair-lsst-web/tree/master/ansible


Strange error message after INSERT

Hello,
when executing the following query
IF NOT EXISTS (SELECT * FROM dbo.V_TUR_IMP WHERE toursno = '123619') INSERT INTO dbo.V_TUR_IMP (system, toursno, ifid, DATLIEF, STATUS, kmstart, kmend, azeit, ezeit, abfahrtzeit, ankunftzeit, pausenzeit, CRD, CRUSER, CHD, CHUSER, FAHRER, BEIFAHRER, KFZ, HAENGER) VALUES ('LIEFERMAX', '123619', 'FVS_TRCK', CONVERT(datetime, '2018-07-25 00:00:00', 120), 1, 120555, 120617, '0603', '0553', '0603', '0553', 0, CONVERT(datetime, '2018-07-25 06:03:17', 120), 'LIEFERMAX', CONVERT(datetime, '2018-07-26 05:53:18', 120), 'LIEFERMAX', 521, 69, 20, -1);
the server responds with the following error message:
"Conversion failed when converting the varchar value '123619)' to data type int."
Why is there a bracket inside the number? Even if we try to write it like Convert(int, 123123)... very strange. We are clueless. Would be great if anyone could help us.
Best regards

Yes, it does work in SSMS or similar.
Yes, we tried it without quotes, but without success.
We are using SQL Server 2012, could that cause this issue? Because your supported FreeTDS Version is just up to 7.3

I think the problem is with your IF statement:
IF NOT EXISTS (SELECT * FROM dbo.V_TUR_IMP WHERE toursno = '123619')
SQL server is attempting to convert 123619') to an INT. Try removing the single quotes, or removing that IF statement entirely to see if the insert succeeds.

Yes, here's your problem:
https://stackoverflow.com/questions/20105641/sql-if-not-exists-syntax-error


Introduce arbitrary orientation for lumped ports

Description of changes:

Introduces the ability to specify the orientation of a lumped port using a 3 vector [x,y,z], in addition to the existing key word "X", "-Y", "+R" style interface.
Introduces algorithms for computing BoundingBox and BoundingBall. These work by reducing onto the dominant rank all data associated with a marked portion of the mesh, then applying sorting/separation approaches based on a a highly restricted subset of the QuickHull algorithm.
The rings example has been changed to apply a π/6 around (0,0,1). This requires regeneration of the baseline data, and changing of the probe example location and data.

Nuances:

The choice to avoid a full QuickHull implementation or Chan's algorithm (generalizes across processors) was based on pragmatism. The upside is relative simplicity (each algorithm requires at most two projections and distance measurements, and some lexicographic sorting) but at the cost of applying a serial bottle neck. This was viewed as not a practical issue however, as generally a) the number of vertices in a port is small and b) most of these vertices are on one rank. If however there was a port that had many vertices, and was uniformly split amongst processors, this would be problematic for these algorithms.
Though these algorithms will work for 3D objects, they should not in general be used for large (made up of many vertices) objects, due to the reduction potentially placing a large quantity of data on the dominant rank (the rank with the largest number of initial vertices).
Usage of the bounding box algorithms in lumpedelement.hpp is to decide upon a length/width of a rectangular port, and outer radius of a coaxial port.

The appropriate specification of the "+R" direction in a coaxial port is non ambiguous, however the specification of circumferential or azimuthal forcing would be ambiguous. This ambiguity was not resolved, as at present neither of these forcing types have been needed.

Issue #, if available:
Closes https://github.com/awslabs/palace/issues/71

Reverting to draft after discussion about bug in the bounding box length calculation.

I'm pushed a branch sjg/lumped-port-orientation-fixes which contains some final fixes (almost all style/formatting) to this branch. If it looks good to you, feel free to merge it here before this gets merged.

@hughcars, I've rebased this on main and it should be ready now. Can you please check out the final commit b9c26d714d230c3800d7219d12ecf186763f1554 which I added to reduce some duplicate code between the BoundingBoxFromPointCloud and BoundingBallFromPointCloud methods? If you're OK with the changes there I will go ahead and mark this for merge.

@hughcars, I've rebased this on main and it should be ready now. Can you please check out the final commit b9c26d7 which I added to reduce some duplicate code between the BoundingBoxFromPointCloud and BoundingBallFromPointCloud methods? If you're OK with the changes there I will go ahead and mark this for merge.

Looks good, slight change to the comment wording, and two missing const is all.


docs: adjust SetNAT1To1IPs docstring

Description
Adjust formatting and grammar.
I did not check if the formatting is actually fixed.

Hi @WofWca. FYI there is a linter error in the commit message.


Update Readme and Rename Screenshots folder to Assets.

Update README to have the latest Screenshots. And Change the name of the Screenshots folder to Assets. If you do not have access to an iOS Device, do let me know I will send you fresh new Screenshots.

Hi!! I would love to work on this issue

Hey, I would like to make these changes!

I don't have access to any ios device, it would be nice if you could send the screenshots

Sure thing. I will be adding screenshots soon

You should crop the tap bar which says iPhone 11

Sir , i would love to do this !
Do let me know whether you will be willing to assign this task to me.

@ryanvarghese I have currently assigned this task to @gokulkannan7, I think he is currently working on it. If I feel like no work has been done, I can definitely assign it to you. I will be posting more such simple tasks, so I would recommend keeping this repo in your watching list.
Also while you are here. Do star the repo.

yes sir, i am working on it, will update you soon

Sir the quality of the pics is decreasing on my laptop when I download it

@ryanvarghese I have currently assigned this task to @gokulkannan7, I think he is currently working on it. If I feel like no work has been done, I can definitely assign it to you. I will be posting more such simple tasks, so I would recommend keeping this repo in your watching list.
Also while you are here. Do star the repo.

Okay no problem. Will star your repo!

@gokulkannan7 you can download screenshots from this Drive link https://drive.google.com/drive/folders/1tt0sy6V4pUdci7bYwpl_5dVuDNaMuayY?usp=sharing

Sir, since this PR is a part of hacktoberfest, can I open the PR on Oct 1?

cool no problems

A few considerations, @pushpinderpalsingh :

Remove unnecessary full stops from bullet points
Typos, maybe run the text through Grammarly

A huge shoutout to r/SpaceX for there API

Remove white space below the image and section

A few considerations, @pushpinderpalsingh :

Remove unnecessary full stops from bullet points

Typos, maybe run the text through Grammarly

A huge shoutout to r/SpaceX for there API

Remove white space below the image and section

That would be awesome. Can you open a new issue and I will assign it to you. While your are doing that, You can maybe proofread all the docs including contributing.md and code of conduct?

That would be awesome. Can you open a new issue and I will assign it to you. While your are doing that, You can maybe proofread all the docs including contributing.md and code of conduct?

I've added the issue, I was going to include a consideration for adding a "Technologies" section within the README.md. I could probably figure out the build process from the project files 🙂

I've added the issue, I was going to include a consideration for adding a "Technologies" section within the README.md. I could probably figure out the build process from the project files 🙂

That would be great. Since you are an iOS Developer, I think you can also add an architecture.md file? Explaining the MVP design pattern this app is using as providing some references where one can learn more about the same?

That would be great. Since you are an iOS Developer, I think you can also add an architecture.md file? Explaining the MVP design pattern this app is using as providing some references where one can learn more about the same?

Yeah, more than happy to help! Let me create an additional issue to cover architectural design etc. So the tickets can be separate.

@clarkeben if you want to contribute to iOS App, I would recommend joining slack (The link is in the readme). BTW, while you are here can you star the repo?

@pushpinderpalsingh yeah I'd love to help out, I've got a few bits on my plate currently - but I'll see what can be done with the current version 😀

@pushpinderpalsingh I have opened a PR, pls do check

Cool let me check

@gokulkannan7 if you are still working on this let me know. If you don't respond within 24 hours, I will assign it to someone else.

Hey, @jamie-brannan can you work on this?

Hello 👋 @pushpinderpalsingh, certainly! Assign this it me please and I'll work on it this week.

Hey @pushpinderpalsingh , commenting to run through some of the objectives for this issue

[x] Change Screenshot folder to Assets

[ ] Edit text for spelling and grammar errors

[ ] Add screen shots ◀ A screenshot section, or a features section?

Are there any other aspects of the README.md you'd like to look at?

You need to remove any and all assets which will not be used. The assets folder should have spaceAgencies.md and two other folders namely Screenshots and Mockups. Screenshots folder should contain the images which are going to be used in Readme while mockups can have images of mockups. While you are editing the Mockups folder, can you also add mockups from issue #23? Make sure the name of the mockup image is relevant to the kind of mockup.
If you find any spelling and grammatical errors in Readme, sure go ahead and edit that. @jamie-brannan

Certainly, for #23 mockups however...
How can I tell the difference between a Screenshoot and a Mockup for this project?
What I'm used to a screenshot is just a capture of what's on the device screen where as a mockup has the screen framed in the device, but Assets/iPad-Mockup has pictures I'd categorize as screenshots.
Assets/collage.png is a college on mockups ➡ would you like to keep this as a Mockup?
├── Download_on_the_App_.png
├── Extended
│   ├── Home_Black.png
│   └── Home_Colour.png
├── about.png
├── collage.png
├── details.png
├── home_black.png
├── home_colour.png
├── iPad-Mockup
│   ├── #1.png
│   ├── #2.png
│   └── #3.png
└── spaceAgencies.md

What's the preferred image file and size?
Is there a central Google Drive folder that they're being stored or should I just save them from my browser?
I'd like to keep them as uniform as possible.

Remove everything except iPad-Mockup, spaceAgencies.md, and Download_on_the_App.png. I think it would be fine if you saved them from your browser. You are talking about #23 mockups, right?
I think you might want to pull the latest version of the repo as recently, we have also added twitter banners.

Okay, that's clear thank you. I'll pass through another commit and submit an PR today once I rebase. 👍


Update [MV]_Christmas.pwn

Changed from 2017 on 2018 year.

so much improvement, wow!

Is this necessary?

Yes

Why you closed?

Because it doesn't add anything, you're just changing a define which is the purpose of a define depending on the things the server owner wants. Not helpful to do that on git also


Window frames aren't auto restored

I'm not sure if this is handled automatically by Cocoa but,

Should restarting Xi automatically re-open the same documents & document window (position + size) as when we quit?
Should closing a document & opening it again restore the last frame it had?  Right now it seems like all documents share the same initial frame size.

Cocoa should handle reopening existing windows, and should save the position of individual windows on close, although this is also dependent on user settings; specifically in System Preferences > General, there's a checkbox for 'close windows when quitting an app', which if checked will disable the restore behaviour. Restoring tabs is currently broken; if you had a window open with multiple tabs, they will not be restored correctly.

All new windows are opened to a fixed size and location, which is dependent on the position of the last window the user had moved or resized before exiting, and offset down and to the right with each new window, wrapping when it hits the edges. I picked this behaviour because it was the behaviour of Terminal.app; chosen because it was a default system app provided by apple, and because it actually opens new windows (which is less and less the fashion). I don't really like our current behaviour, though; my thinking right now is that we should open all new windows at the same size as the currently frontmost window, offset by ~the height of the title bar. Thoughts?

The most annoying issue with current state restoration behaviour occurs when closing Xi while in Full Screen. Cocoa's restoration does not honour Full Screen mode. Instead, Xi windows restore to maximum screen width and minimum height.

@lukf Ah interesting, thanks for that. I hadn't been testing full screen at all.

I've been experiencing similar issue when restoring a session but instead of a maximum w/h values like @lukf, I have the smallest possible w/h values when opening a new Xi session.
I couldn't figure out where was it placed in the screen, luckily (thanks to Magnet) I was able to center it and manually resizing it.

@tatoalo was this also in relation to fullscreen mode? In any case good to know, maybe I'll add a minimum allowable width/height.

@cmyr Nono it wasn't related to fullscreen mode, actually I've never used it in such mode.
Trying to "fix" I've also tried:

Resizing window, quitting Xi and restarting
Resizing window, write something in the buffer, save it, restarting
Resizing, go in fullscreen mode, write, save, restarting

But so far none of the aforementioned actions seems to do the trick...

@tatoalo #141 should solve your problem, but I'm still curious about what's actually causing this.
Can you paste the results of entering defaults read com.levien.XiEditor at the command prompt?
If you resize the window to some reasonable size, and then (without quitting) make a new window, what size is the new window?
If you have Xcode, one more thing i'd be curious about: if you could add print statements in XiDocumentController:windowChangedNotification (printing out frameString) and then in Document:frameForNewWindow (printing out lastFrame). The first should print the frame of any window that is moved, resized, or gains focus; the second should print anytime you create a new window, with the value last printed from the previous function.

@cmyr
Ok, I'm gonna post the output results:

defaults read com.levien.XiEditor {BEFORE manually centering window}

{
    NSNavLastRootDirectory = "~/Downloads";
    NSNavPanelExpandedSizeForOpenMode = "{712, 448}";
    NSNavPanelExpandedSizeForSaveMode = "{712, 448}";
    "NSWindow Frame xi-editor-dev-01" = "102 856 0 22 0 0 1440 877 ";
    "io.xi-editor.settings.preferredWindowFrame" = "{{102, 856}, {0, 22}}";
    "io.xi-editor.settings.theme" = "Solarized (dark)";
}

defaults read com.levien.XiEditor {AFTER manually centering window}

{
    NSNavLastRootDirectory = "~/Downloads";
    NSNavPanelExpandedSizeForOpenMode = "{712, 448}";
    NSNavPanelExpandedSizeForSaveMode = "{712, 448}";
    "NSWindow Frame xi-editor-dev-01" = "720 427 73 23 0 0 1440 877 ";
    "io.xi-editor.settings.preferredWindowFrame" = "{{720, 427}, {73, 23}}";
    "io.xi-editor.settings.theme" = "Solarized (dark)";
}

Xcode output

**frameString value** -->  {{102, 878}, {0, 0}}

**frameString value** -->  {{102, 855}, {0, 22}}

If I resize the windows and then cerate a new one, the size of the new one will be matched with the old one from which the new window command has been invoked.

Okay, thanks for that. we're at least saving the state. If you're up for it, this would be my next step:
replace Document:frameForNewWindow with the following: (leaving your current print statement in XiDocumentController:windowChangedNotification)
    func frameForNewWindow() -> NSRect {
        let offsetSize: CGFloat = 22
        let screenBounds = NSScreen.main!.visibleFrame
        Swift.print("screenBounds \(screenBounds)")
        let lastFrame = UserDefaults.standard.string(forKey: USER_DEFAULTS_NEW_WINDOW_FRAME)!
        Swift.print("lastFrame \(lastFrame)")
        var nextFrame = NSOffsetRect(NSRectFromString(lastFrame), offsetSize, -offsetSize)
        Swift.print("nextFrame init \(nextFrame)")

        if nextFrame.maxX > screenBounds.maxX {
            nextFrame.origin.x = screenBounds.minX + offsetSize
        }

        if nextFrame.minY <= 0 {
            nextFrame.origin.y = screenBounds.maxY - nextFrame.height
        }
        Swift.print("nextFrame final \(nextFrame)")
        return nextFrame
    }

And then do the following:

Hit Xcode 'run'
center the window
manually resize the window, to a size you would actually use to edit text
cmd + N to open a new window

Can you paste the entire contents of the Xcode console after those steps?

@cmyr Of course, nb, here it is
**frameString value** -->  {{80, 900}, {0, 0}}
error loading plugins from "/Users/tatoalo/Library/Application Support/XiEditor/plugins", error:
Error { repr: Os { code: 2, message: "No such file or directory" } }
starting plugins for view-id-1
starting plugin at path "/Users/tatoalo/Library/Developer/Xcode/DerivedData/XiEditor-grmjztglxilfpsaipoxuhsldmqlk/Build/Products/Debug/XiEditor.app/Contents/Resources/plugins/syntect/bin/xi-syntect-plugin"
screenBounds (0.0, 0.0, 1440.0, 877.0)
lastFrame {{80, 900}, {0, 0}}
nextFrame init (102.0, 878.0, 0.0, 0.0)
nextFrame final (102.0, 878.0, 0.0, 0.0)
starting plugin syntect
2018-02-16 20:31:56.057914+0100 XiEditor[3484:64932] Unknown Window class (null) in Interface Builder file,
	 creating generic Window instead
2018-02-16 20:31:56.080392+0100 XiEditor[3484:64954] [default] [ERROR] Failed getting container for URL: file:///Users/tatoalo/Documents/GitHub/latex_paper/README.md, error: Error Domain=BRCloudDocsErrorDomain Code=12 "App library not found: 'com.apple.Documents'" UserInfo={NSDescription=App library not found: 'com.apple.Documents'}
2018-02-16 20:31:56.081070+0100 XiEditor[3484:64956] [default] [ERROR] Failed getting container for URL: file:///Users/tatoalo/Documents/GitHub/latex_paper/NEW_dbms_implementation.asm, error: Error Domain=BRCloudDocsErrorDomain Code=12 "App library not found: 'com.apple.Documents'" UserInfo={NSDescription=App library not found: 'com.apple.Documents'}
**frameString value** -->  {{102, 878}, {0, 0}}
client: plugin started syntect
syntect using Plain Text
**frameString value** -->  {{720, 427}, {73, 23}}
**frameString value** -->  {{720, 427}, {494, 23}}
**frameString value** -->  {{720, 52}, {699, 398}}
**frameString value** -->  {{608, 124}, {699, 398}}
**frameString value** -->  {{471, 256}, {699, 398}}
**frameString value** -->  {{410, 314}, {699, 398}}
**frameString value** -->  {{351, 355}, {699, 398}}
**frameString value** -->  {{282, 399}, {699, 398}}
**frameString value** -->  {{262, 413}, {699, 398}}
**frameString value** -->  {{263, 412}, {699, 398}}
**frameString value** -->  {{263, 277}, {957, 533}}    [Here I've finished adjusting the window to a size I'm comfortable editing(similar to what I use for Atom when not fullscreen)]
screenBounds (0.0, 0.0, 1440.0, 877.0)
lastFrame {{263, 277}, {957, 533}}
nextFrame init (285.0, 255.0, 957.0, 533.0)
nextFrame final (285.0, 255.0, 957.0, 533.0)
starting plugins for view-id-3
starting plugin syntect
2018-02-16 20:32:26.314216+0100 XiEditor[3484:64932] Unknown Window class (null) in Interface Builder file,
	 creating generic Window instead
starting plugin at path "/Users/tatoalo/Library/Developer/Xcode/DerivedData/XiEditor-grmjztglxilfpsaipoxuhsldmqlk/Build/Products/Debug/XiEditor.app/Contents/Resources/plugins/syntect/bin/xi-syntect-plugin"
**frameString value** -->  {{285, 255}, {957, 533}}
**frameString value** -->  {{285, 255}, {957, 533}}
client: plugin started syntect
syntect using Plain Text  [After here I'm quitting both with Cmd+Q]
waiting on process 3488
process ended Ok(ExitStatus(ExitStatus(9)))
waiting on process 3490
process ended Ok(ExitStatus(ExitStatus(9)))

Hope to have helped even a little bit 😊

Okay, so reading that it looks like view you create with cmd+N has a reasonably sized frame, is that correct?
If you quit and relaunch the application, new windows you create still start with the small size?
I wonder if somehow your defaults are being overridden? Want to try that command we used before to print them?
defaults read com.levien.XiEditor.

before launching the app
after resizing the window
after quitting the app

@cmyr

Okay, so reading that it looks like view you create with cmd+N has a reasonably sized frame, is that correct?

Exactly

If you quit and relaunch the application, new windows you create still start with the small size?

Precisely, also not centered(just as before)

before launching the app

{
    NSNavLastRootDirectory = "~/Downloads";
    NSNavPanelExpandedSizeForOpenMode = "{712, 448}";
    NSNavPanelExpandedSizeForSaveMode = "{712, 448}";
    "NSWindow Frame xi-editor-dev-01" = "720 427 73 23 0 0 1440 877 ";
    "io.xi-editor.settings.preferredWindowFrame" = "{{720, 427}, {73, 23}}";
    "io.xi-editor.settings.theme" = "Solarized (dark)";
}

after resizing the window

{
    NSNavLastRootDirectory = "~/Downloads";
    NSNavPanelExpandedSizeForOpenMode = "{712, 448}";
    NSNavPanelExpandedSizeForSaveMode = "{712, 448}";
    "NSWindow Frame xi-editor-dev-01" = "204 136 1032 606 0 0 1440 877 ";
    "io.xi-editor.settings.preferredWindowFrame" = "{{204, 136}, {1032, 606}}";
    "io.xi-editor.settings.theme" = "Solarized (dark)";
}

after quitting the app

{
    NSNavLastRootDirectory = "~/Downloads";
    NSNavPanelExpandedSizeForOpenMode = "{712, 448}";
    NSNavPanelExpandedSizeForSaveMode = "{712, 448}";
    "NSWindow Frame xi-editor-dev-01" = "204 136 1032 606 0 0 1440 877 ";
    "io.xi-editor.settings.preferredWindowFrame" = "{{204, 136}, {1032, 606}}";
    "io.xi-editor.settings.theme" = "Solarized (dark)";
}

Going to treat this as the tracking issue for overall window restoration behaviour; #163 describes another related problem with how restored windows are positioned.


[ISSUE #1536] Method uses integer based for loops to iterate over a List [Subscription]

Fixes #1536.
Motivation
There are two for loops in the method writeTo that use integer based loops to iterate over the subscriptionItems list. Because the integer is not used for any other reason, it's better to use an iterator or a for-each loop.
Modifications
I changed the integer based for loops in the writeTo method to for-each loops
Documentation
none

@sclark268626 please check your commit email with your github email, if they are different, this contribution will not be counted in.


Does this support GCPs (Ground control points), if not, can you provide guidance on how to implement it here?

Do you mean using ground control points to stitch sub map?

I mean ground control points with know georeferenced location and pixel locations in various images for model alignment and also to include them as constraints in the bundle adjustments.

Okay, I also found some useful information on the webpage https://www.pix4d.com/blog/why-ground-control-points-important.
(1) Then, with GCPs, we can obtain the absolute scale of point clouds. If we want to align models by ground control points, we might implement it by following the steps below:

Suppose each sub-model has some GCPs, thus we can compute the similarity transformation to register the sub-model into world frame / earth frame by 3D-3D correspondences. See function FindSimilarityTransform in https://github.com/AIBluefisher/GraphSfM/blob/dev/src/controllers/sfm_aligner.cpp for how to compute accurate similarity transformation.

With known similarity transformation, all camera poses and 3D points can be transformed into the earth frame by this similarity transformation.

When all sub-models are registered into the earth frame, we can simply put  these sub-models together, as they are already in a global world frame.

I'm not sure whether I totally understand what you want to do. We could discuss it if not.
(2) For how to include GCPs as constraints in bundle adjustment, I'm not aware of the usage of GCPs in improving the model accuracy. As far as I currently know, we could simply set the ground control points as constant variables in the optimization, because these points can be seen as ground truth and we don't need to optimize these points.


rgb_only_on_original in Nerfiller_model.py

https://github.com/ethanweber/nerfiller/blob/main/nerfiller/nerf/nerfiller_model.py
if self.config.rgb_only_on_original:
     loss_dict["rgb_loss"] = self.rgb_loss(gt_rgb * batch["original_mask"], pred_rgb * batch["original_mask"])
should have an "else" case?
else:
     loss_dict["rgb_loss"] = self.rgb_loss(gt_rgb, pred_rgb)

I am a little confused with nerfstudio code, can you point out where makes the masked out part (by an additional mask image) not be used during the training.
Is it the "erode_mask" function in PatchPixelSampler ?
Besides, I wonder how to set breakpoint into the code to check the immediate features, such like outputs after dealing with the ray_bundle. I tried the breakpoint() or pdb.set_trace(). They both didn't work.
For example:
Adding the breakpoint to the nerfiller_pipeline.py
ray_bundle, batch = self.datamanager.next_train(step)
model_outputs = self._model(ray_bundle)
breakpoint())

Loss function
Hi @Harr7y, interesting catch! I think it should have an else case. It must not have mattered in my results (surprisingly) because I first pretrain with Nerfacto and then fine-tune with Nerfiller. This would imply that LPIPS loss can do the heavy lifting of adding the content consistently. Let me know if the else case helps your results, as I'd be very curious and eager to modify the code if so. Thanks!
Masks
Here is some masking logic in the datamanager, where we sample from the images.
Breakpoints
I typically use import pdb; pdb.set_trace();, which has worked fine for me. It doesn't work for me when I am using a rich progress bar, but otherwise it's been good for me.

Thanks for your reply~
Masks
I apologize if my words have caused any misunderstanding. What I meant to ask is which part of NerfStudio ensures that the content under the mask is not used in the training process.
Breakpoints
After adding the breakpoint to the nerfiller_pipeline.py and pip install -e ., then I run ns-train train-occluder with "grid-prior-du" config. It just didn't work. :disappointed_relieved: Can you provide some advice?
ray_bundle, batch = self.datamanager.next_train(step)
model_outputs = self._model(ray_bundle)
pdb.set_trace()

Masks
Oh yes, for masks it's coming from the pixel sampler for Nerfacto, but I sample everything for the custom methods. I actually set the images after inpainting in the pipeline file, which is why I can sample everything and put a loss everywhere on the patch.
Breakpoints
Oh I think you mean ns-launch train-occluder with grid-prior-du, instead of "ns-train". Make sure you don't launch with multiple processes when you run this. You'll want to run the command ns-train grid-prior-du ... in its own thread, rather than relying on the command that launches many python commands at once. So, you can run with --dry-run and then copy paste the command into its own terminal. This way I think pdb will start working, since the terminal is for just one command. (If you've already done this, I'm a bit lost for why pdb wouldn't work.)

It works, thanks a lot!!! :clap::clap:

Hey @Harr7y, I just wanted to follow up from a while ago. Did you ever implement the "else statement" above for the rgb loss and did it prove to be important? I'd like to update the codebase if that ended up being important for results.

t["rgb_loss"]

Sorry, this experiment is a little too long ago, and I've cleaned up the test records. In my (not very clear) memory, the implement of 'else statements' has little effect on the result. It seems that LPIPS loss has played a great role.

No worries at all, and thanks for the reply! :) I thought the same, as I double checked my code and experiments before releasing the code. Thanks @Harr7y! Going to leave the issue open in case anyone has similar questions regarding this topic.


fix(sec): upgrade golang.org/x/net to 0.7.0

What happened？
There are 1 security vulnerabilities found in golang.org/x/net v0.2.0

CVE-2022-41723

What did I do？
Upgrade golang.org/x/net from v0.2.0 to 0.7.0 for vulnerability fix
What did you expect to happen？
Ideally, no insecure libs should be used.
The specification of the pull request
PR Specification from OSCS

your local project's go.mod should be upgraded, not the dep of a dep.


Only restrict webhook's rbac secret resourceName on get

resourceNames cannot be restricted on create
Remove redundant mutatingwebhookconfigurations rbac
Convert RoleBinding on ClusterResources to ClusterRoleBinding

Codecov Report

Merging #323 into master will not change coverage by %.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #323   +/-   ##
=======================================
  Coverage   68.19%   68.19%
=======================================
  Files          79       79
  Lines        3201     3201
=======================================
  Hits         2183     2183
  Misses        767      767
  Partials      251      251

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9e2a53d...447217b. Read the comment docs.


Add missing current pose topic for simple planning simulator

This line is unsed so far so it would be better to remove this line and assume pose from simulator is coming from odometry message.
https://github.com/autowarefoundation/autoware.universe/blob/272645304e8acda0a13dc4bf9935edbf50c12b32/simulator/simple_planning_simulator/src/simple_planning_simulator/simple_planning_simulator_core.cpp#L112
or
add /current_pose topic like autoware.iv
The same information is in odometry message but ,It seem no package refer to pose from odometry message
i think it's better to publish PoseStamped message from simulator for better compatibility.
cc : @isamu-takagi

TODO
decide output topic name


AKPlayer (pause, isPaused) is broken

Here is my coded:
Button 1 call: player.pause()
Button 2 call:
if player.isPaused{     <------ this line is always false.
player.resume
}
Confirmed it's broken on iOS v4.5.4, and it's working on iOS v4.5.3
Also, I realized AudioKit.start() take significant longer on v4.5.4 than v4.5.3

I don't see how start up time can be affected, core files weren't changed.  What's in the signal chain?

@aure I think Im wrong about startup time.
But the isPause flag is indeed broken.

also seeing this, looks like the pauseTime gets nilled out immediately after getting set by stopCompletion(). I'm also noticing that after calling pause() on an AKPlayer, it starts broadcasting a currentTime of 0 because the internal player node has been stopped (and therefore reset to t=0 in the timeline). Is that expected behavior?

I will look at this, sorry for the delay.

The issue is here: https://github.com/AudioKit/AudioKit/blob/78800e4b58d5cdf033ba0365194453f8ef2a14b9/AudioKit/Common/Nodes/Playback/Players/Player/AKPlayer%2BPlayback.swift#L52

As a temporary fix, use AKAudioPlayer. It works with pause/resume as well as looping.

Hi, there is a PR in that will fix this issue. Will have an update soon.


Update node sdk README

Codecov Report

Merging #98 (e3a250c) into develop (1eceb67) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop      #98   +/-   ##
========================================
  Coverage    88.54%   88.54%
========================================
  Files           81       81
  Lines         1274     1274
  Branches       125      125
========================================
  Hits          1128     1128
  Misses         145      145
  Partials         1        1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1eceb67...e3a250c. Read the comment docs.


add support to getTopLevelDecls for clang submodules

Resolves rdar://126031510
This PR adds partial support for Clang submodules in the ClangModuleUnit code. Specifically, it allows getTopLevelDeclsForDisplay (and the crawling methods it calls) to correctly load decls when given a submodule.
This is a behavior change for this function; specifically, passing in the top-level module now only returns the decls declared specifically in that module, as opposed to adding in the decls from its submodules as well. This broke the module interface printer, which i updated in this PR.
The goal of this was to allow swift-symbolgraph-extract to receive the name of a Clang submodule and correctly load its constituent symbols (without tripping an assertion on assertions builds), which this now enables.

@swift-ci Please test

To aid code review, i'll provide a bit of a writeup of what i changed:
AST
@hborla @slavapestov @xedin
I added the ClangNode::getOwningClangModule method, which gets the owning module of the underlying Clang decl, if it exists. Module nodes are returned as-is, and MacroInfo macros return nullptr since they do not have a recorded owning module.
IDE
@ahoppen @bnbarham @hamishknight @rintaro
I had to update the module interface printer to accommodate the change in behavior surrounding Clang modules. Parent Clang modules now no longer report the decls of their submodules, so they will need to be crawled separately. I split out a list of "modules to crawl" and added submodules to it if VisitSubmodules is given as a traversal option. Then getTopLevelDeclsForDisplay is called repeatedly with the same output vector to accumulate all the requested decls.
I also updated the test output for SourceKit/DocSupport/doc_clang_module.swift and SourceKit/InterfaceGen/gen_clang_module.swift when printing the interface for the submodule. The import FooHelper statement was actually not present in the original submodule, and this update changed the printer behavior to reflect that.
SymbolGraphGen
@daniel-grumberg
I tweaked the SymbolGraphASTWalker to probe the underlying Clang module of any Clang nodes when determining which symbol graph to sort a symbol into. Since the owning module still reports the top-level module, this step is required to accurately sort symbols.
ClangImporter
@zoecarver @hyp @egorzhdan @beccadax @ian-twilightcoder
To collect decls into the right module when crawling a Clang module, i updated isDeclaredInModule to compare the owning module as reported by Clang against our ModuleFilter, rather than using the owning module as reported by Swift. As mentioned above, i did not update the owning module given to imported decls. (Doing so created deserialization errors when building the stdlib that i didn't want to debug fully.) So to accommodate that, we need to circumvent it and ask Clang for the owning module instead, which accurately reports the submodule. This way, if a submodule is given to getTopLevelDeclsForDisplay (which creates a swift::ModuleDecl that wraps the submodule itself), we can correctly report which decls belong to that submodule.
I also updated ClangModuleUnit::getTopLevelDecls to double-check that any Objective-C categories in the ClangImporter lookup table actually belong to this module before adding them to the output. When getTopLevelDeclsForDisplay is called repeatedly, like i did in the module interface printer, the lookup table is not cleared, leading to categories appearing multiple times. This filter prevents that from happening.
Finally, i removed the CMU->isTopLevel() component of the assertion in the FilteringDeclaredDeclConsumer constructor, since we now support submodules in the decl crawler.

Since the biggest conceptual changes are in the ClangImporter and the module interface printer, i would most appreciate a review from those code owners. Thanks!

@ahoppen IIRC it has to do with how the decls were being collected before. Import decls are filtered separately from other kinds of decls, which means the decl filtering that was being done skipped any import decls. Since printing submodules involved crawling the top-level module, that meant that any import from the top-level module also made its way into the submodule, regardless of whether the submodule actually imported it. That's what happened in this situation.

I am not entirely sure but it seems like generating symbol graphs for a top level module doesn't include symbols from submodules. This seems incorrect as unfortunately most ObjC frameworks in SDK have a modulemap that looks something like:
framework module MyFramework {
    umbrella header "MyFramework.h"

    export *
    module * {
        export *
    }
}

which basically says reexport all the modules it pulled in by the umbrella header (that's the export *), and that every header is it's own submodule that's the part (that's the module *), So effectively most ObjC symbols are actually in a submodule and would get dropped if I interpreted this change correctly.

@swift-ci Please test

@daniel-grumberg I've just pushed a commit that should fix that. It required some tweaks in the export-import logic and around SymbolGraphGen, but it should automatically treat Clang submodules as re-exported if they were declared with the export *; module * { export * } structure.

@swift-ci Please test

@swift-ci Please test

@daniel-grumberg I've pushed an update that handles export statements in Clang modules, as well as simplifies the isSubmoduleOf implementation. Can you take another look?

@swift-ci Please test

I pushed a new commit that tweaks the behavior of collectExportedImports to deal with Clang modules that have Swift overlays. Previously we were not properly crawling the Clang module for its exports, since we were skipping underlying Clang modules in this function. We still don't want to process the import and include its symbols twice, but we do want to process its re-exports for header-based submodules. This should fix an issue we saw when trying this change offline. /cc @daniel-grumberg

@swift-ci Please test

I've had to update the PR again to handle an edge case when using this code against some test data offline. It turns out that some modules don't properly add an export * statement in their module map, which means that technically the top-level module doesn't actually export the symbols from its submodules. To counteract this, i introduced a workaround in SymbolGraphGen to consider umbrella headers to implicitly export a module's submodules if there's an umbrella statement but no export statements. This means that it no longer accurately reflects the actual module structure, but it should reflect the intended module structure, and that feels like a better solution for something documentation-focused. I'll do more offline testing before merging this, in case there are yet more issues i need to handle.

@swift-ci Please test


Call the listeners close method when stopJob is called.

It is the responsibility of the QueryBatcher and the WriteBatcher to call any close() methods of the listeners registered with them. If the listeners had to close any resources, they can implement AutoCloseable interface and close the resources in the close() method. QueryBatcher and WriteBatcher would iterate all the listeners and call any close() methods when stopJob is called on the batcher.
Similarly, it is the responsibility of the listeners to close any resources opened by the consumers registered with them. It should implement AutoCloseable and iterate all the Consumers and call close() methods as necessary. This should be done in the close() method of the listener which would be closed by the Batcher when stopJob is called.
Batcher(QueryBatcher/WriteBatcher) -> calls the listeners' close method (which are registered with the Batcher)
Listeners -> calls the Consumers close() method (which are registered with the listeners)

For QA
Added private method closeAllListeners to both WriteBatcher and QueryBatcher which would close all the listeners (both success and failure listeners) if they are instances of AutoCloseable by calling the close() method of the listeners. This is done when stopJob() is called on the Batcher.
For Docs
We take care of calling the close() method of the listeners which are registered with the Batcher.
Batcher(QueryBatcher/WriteBatcher) -> calls the listeners' close method in stopJob() method (which are registered with the Batcher)
Although the following needs to be implemented at the listener level, it is our responsibility to convey the customers that they have to call the Consumers' close() method. For example: See ExtractViaTemplateListener.java close() method (It is in a feature branch issue839 for now which will eventually get into develop branch before 4.0.4)
Listeners -> calls the Consumers close() method (which are registered with the listeners)


Add hyperterm-focus-reporting

I wrote this little plugin to add focus gained & focus lost reporting when running terminal vim inside hyperterm.  This way when a terminal loses focus vim will receive the focus lost event & in my setup it autosaves all the buffers.  I don't think there's a really good way to show a visual representation of this, but I think I've hit every other item on the checklist!
Checklist for submitting an awesome plugin, theme, or resource:

[x] The title for my package or theme uses its npm title (hyperterm-plugin-example)
[x] The link for my package or theme uses the npmjs.com link (https://www.npmjs.com/package/hyperterm-plugin-example)
[ ] There is a visual representation of what my plugin or theme does in the repo. (Plugin: screenshot or gif || Theme: screenshot of the theme applied to HyperTerm)
[x] Put your awesome item at the BOTTOM of the correct (plugin, theme, or resource) list.
[x] VERY IMPORTANT: I've written a short (one sentence) description for my package or theme as the description of the awesome plugin, theme, or resource in the README.md file I'm submitting in the PR.

Thanks for the contribution! ☺


Additional spectral feature transformations

While torchaudio provides a Mel-scaled spectrogram transformation (torchaudio.transforms.MEL), there’re a few additional spectral feature transformations that are extremely useful for pre-processing and data augmentation. For example, two feature transformations that I’d love to see in torchaudio are Mel-frequency cepstral coefficients (MFCC) and Chroma Energy Normalized (CENS) chromagrams.

I might take a stab at MFCCs after my finals (approx a month from now) if you fancy waiting that long :)

bjuncek, could you confirm that you are working on the MFCC? I would be willing to work on this if your plans have changed. Thanks

@MuzzleTheWolf I'm working on it but the progress is slowed down by graduation requirements.
If you can get it done before June, it's all yours.

Hey did this get anywhere? I'll look into implementing too if not.

I dont think anyone made progress. PRs definitely welcome :)

https://github.com/pytorch/audio/pull/83


Add option to restore latest snapshot with optional path and source filters

eg restic -r r1 restore latest --target restore2 --path "D:\dev\restic\bin\s1"
path and source filters also added to snapshot cmd
eg restic -r r1 snapshots --source nucore --path="D:\dev\restic\bin\s1"
Moved FindLatestSnapshot and SamePaths from cmd_backup to snapshot so backup,restore,snapshot commands can share and made the most sense to put it in snapshot.
This is very useful for automating testing of backups and scripted latest restores.

Hey, thanks for your contribution! I have a few comments.

Ok, only two issues remaining:

I propose changing --source to --host and changing the table header for snapshots accordingly
Could you add a few sentences about these new features to doc/Manual.md?

When these two issues are resolved I'm glad to merge this, thanks again!

Hey, are you still interested in getting this merged? Or are you just super busy right now? :)

yeah sorry have not had time to look at this. Will try to make time tonight.

No need to rush, take your time. It'd be good to rebase on the current master, the samePaths fucntion was modified, maybe you can directly resolve the conflict.
Thanks!

OK all the checks pass and I think I implemented all the suggestions.

LGTM, thanks!


Submitting Varuna Connector for Certification (Non-Microsoft Publisher)

When submitting a connector, please make sure that you follow the requirements below, otherwise your PR might be rejected. We want to make you have a well-built connector, a smooth certification experience, and your users are happy :)
If this is your first time submitting to GitHub and you need some help, please sign up for this session.
Please note that we are experiencing a significant delay due to COVID delays, unanticipated team leaves, and high volume of connector submissions.

[ ✓ ] I attest that the connector works and I verified by deploying and testing all the operations.
[ ✓ ] I attest that I have added detailed descriptions for all operations and parameters in the swagger file.
[ ✓ ] I attest that I have added response schemas to my actions, unless the response schema is dynamic.
[ ✓ ] I validated the swagger file, apiDefinition.swagger.json, by running paconn validate command.
[ ✓] If this is a certified connector, I confirm that apiProperties.json has a valid brand color and doesn't use an invalid brand color, #007ee5 or #ffffff. If this is an independent publisher connector, I confirm that I am not submitting a connector icon.

If you are an Independent Publisher, you must also attest to the following to ensure a smooth publishing process:

[ ] I have named this PR after the pattern of "Connector Name (Independent Publisher)" ex: HubSpot Marketing (Independent Publisher)
[ ] Within this PR markdown file, I have pasted screenshots that show: 3 unique operations (actions/triggers) working within a Flow. This can be in one flow or part of multiple flows. For each one of those flows, I have pasted in screenshots of the Flow succeeding.
[ ] Within this PR markdown file, I have pasted in a screenshot from the Test operations section within the Custom Connector UI.
[ ] If the connector uses OAuth, I have provided detailed steps on how to create an app in the readme.md.

Hi,
How can I run API Properties Validator in my local environment? I did not understand why it is failing.
Thanks.

Hi @mertcdnmz. Congratulations your pull request is approved and merged.
After the pull request is merged, you may submit the files to ISV Studio, please allow us 1-2 weeks to review your submission, and our Engineers will notify you in the “Activity Control” area in ISV Studio.
5.	Create an environment in the Preview region. You will use this environment later to test your connector after Microsoft is done with the functional verification for your connector.
We expect all tests to be completed within 1-2 weeks.
6.	If your connector passes all tests, the deployment process begins, and it typically takes 5 to 6 weeks to deploy your connector to all of our regions.
Please let me know if you have any questions.
Thank you very much.


1.11.2 Crashes

http://pussh.us/txt/475bb.txt With other mods
http://pussh.us/txt/59291.txt on its own
Downgrading to 5.76 seems to work though

Not RFTools problem. You have buggy nvidia drivers. This is a known problem with nvidia. These versions don't work for modded. Upgrade or downgrade them:
GL info: ' Vendor: 'NVIDIA Corporation' Version: '4.5.0 NVIDIA 378.49' Renderer: 'GeForce GTX 750 Ti/PCIe/SSE2'

BTW: more info on this bug:
https://www.reddit.com/r/feedthebeast/comments/5pydv9/dont_install_nvidia_gpu_driver_version_37849_it/


Faces image looks blurry when viewport <375px wide

D'oh, I tried to use an existing thumb for small screen sizes, but of course that has a hard crop applied. Fixed now.


add special check for parameter initializer lookup if targeting es2015+

Fixes #22769

@RyanCavanaugh probably worth noting that even though this is a bugfix, it is also a breaking change. Also, in the context of parameter properties it doesn't make sense (ie, it is wrong), since those will still get downleveled, eg:
class Foo {
    constructor(public x = 12, public y = x.toFixed()) {}
}

we have breaks in RWC along these lines.


fix(ci): use new infra configuration

Release Note
fix(ci): use new infra configuration

No need to run checks.


precompilation error when using module with PythonCall.jl in another module

Affects: PythonCall
Describe the bug
I have a module Foo which imports a Python package and defines some functions using this Python package. All tests pass and it works great. I have another module Bar which uses Foo. During precompilation of Bar I get this error:
Failed to precompile Bar [03231224-7cb2-45ca-b412-3b82d488d8bd] to "/home/kylebeggs/.julia/compiled/v1.9/Bar/jl_8mIASd".
hwloc/linux: Ignoring PCI device with non-16bit domain.
Pass --enable-32bits-pci-domain to configure to support such devices
(warning: it would break the library ABI, don't enable unless really needed).
ERROR: LoadError: InitError: LoadError: Evaluation into the closed module `Foo` breaks incremental compilation because the side effects will not be permanent. This is likely due to some other module mutating `Foo` with `eval` during precompilation - don't do this.

In Foo, I load the Python package and some user defined Python functions as
const MP = PythonCall.pynew()

function __init__()
    PythonCall.pycopy!(MP, pyimport("some_package"))
    include(joinpath(@__DIR__, "python-funcs.jl"))
    return nothing
end

Your system
Please provide detailed information about your system:

Linux - PopOS 22.04
Julia 1.9.2
PythonCall v0.9.13
CondaPkg v0.2.18

Julia Version 1.9.2
Commit e4ee485e909 (2023-07-05 09:39 UTC)
Platform Info:
  OS: Linux (x86_64-linux-gnu)
  CPU: 20 × 12th Gen Intel(R) Core(TM) i7-12700H
  WORD_SIZE: 64
  LIBM: libopenlibm
  LLVM: libLLVM-14.0.6 (ORCJIT, alderlake)
  Threads: 8 on 20 virtual cores
Environment:
  LD_PRELOAD = /usr/lib/x86_64-linux-gnu/libstdc++.so.6
  JULIA_EDITOR = code
  JULIA_NUM_THREADS = 8
  JULIA_IMAGE_THREADS = 1

I don't think this is a problem with PythonCall, the error message is pretty clear:
ERROR: LoadError: InitError: LoadError: Evaluation into the closed module Foo breaks incremental compilation because the side effects will not be permanent. This is likely due to some other module mutating Foo with eval during precompilation - don't do this.
I suspect it's because you are calling include in __init__.

Ok, thank you very much for the response. I will look into using include in __init__.

Using include in __init__ is indeed the issue. This confuses me as I thought include simply pastes the code into that spot. Why would manually copy/pasting the code in include into __init__ fix this issue?

include doesn't literally paste the code in (after all, include is an ordinary function, and a function cannot do such a thing, only a macro can). Roughly speaking, include(file) does eval(Meta.parse(read(file, String))). If you do this at the top level of a module, it has the same effect as pasting the code into the module (because eval evaluates the code in the top-level scope of the module), but if you do it in a function, then it has all the same caveats as calling @eval from within a function.

Ahh, I see, thank you very much for the response/explanation.


SassError: File to import not found or unreadable: @bentley/ui-core/lib/ui-core/scrollbar.

I am trying to create a basic OIDC SignIn page using the provided components of ImodelJS on an external project to the monorepo.
To do so, I used npm install to install what I think are the minimal dependencies needed. Here's is the partial content on my package.json file:
"dependencies": {
    "@bentley/bentleyjs-core": "^1.11.0",
    "@bentley/geometry-core": "^1.11.0",
    "@bentley/imodeljs-clients": "^1.11.0",
    "@bentley/imodeljs-common": "^1.11.0",
    "@bentley/imodeljs-frontend": "^1.11.0",
    "@bentley/imodeljs-i18n": "^1.11.0",
    "@bentley/imodeljs-quantity": "^1.11.0",
    "@bentley/presentation-common": "^1.11.0",
    "@bentley/presentation-frontend": "^1.11.0",
    "@bentley/ui-components": "^1.11.0",
    "@bentley/ui-core": "^1.11.0",
    "@bentley/ui-framework": "^1.11.0",
    "@bentley/ui-ninezone": "^1.11.0",
    ...

Based on the ui-test-app code, I wanted to write a basic SignIn component, but I end up with the following error during compilation:
<EMAIL_ADDRESS><EMAIL_ADDRESS>SassError: File to import not found or unreadable: @bentley/ui-core/lib/ui-core/scrollbar.
        on line 5 of<EMAIL_ADDRESS>        from line 6 of<EMAIL_ADDRESS>>> @import "@bentley/ui-core/lib/ui-core/scrollbar";

   ^

My code, at the present, only consist of:
import * as React from "react";
import { UiFramework } from "@bentley/ui-framework";
import { Redirect} from "react-router-dom";

const SignIn = () => {
  const isAuthorized = !!UiFramework.oidcClient && UiFramework.oidcClient.isAuthorized;
  if (isAuthorized) {
    return (<Redirect to="/StandIn"/>);
  }

  // Todo: use IModelJS SingIn component here
  return (
    <div>
      Sign In.
    </div>
  );
}

export default SignIn;

The error is related to sass-loader and how the Sass partial files are being imported. Are you using the iModel.js webpack tools or your own? If you're using your own, a webpack configuration rule like the following is required:
const config: webpack.Configuration = {
module: {
rules: [
. . .
{
loader: require.resolve("sass-loader"),
options: {
includePaths: [path.resolve(__dirname, "..", "node_modules")],
},
test: /.scss$/,
},
. . .


ETC1Data IO fix and update

In this PR:
Commit 1:

matryoshka new DataOutputStream(new GZIPOutputStream(file.write(false))); was refactored to allow closing gzipStream and dataStream

new method write(OutputStream outputStream) added

output fileStream properly closed to avoid locking output file.

Commit 2:

another matryoshka new DataInputStream(new BufferedInputStream(new GZIPInputStream(pkmFile.read()))); refactored for the same reasons

new method static ETC1Data.read(inputStream) introduced to replace unsafe constructor

input fileStream properly closed to avoid locking input file.

Commit 3:

class final modifier removed to allow class extension for custom implementations.

Please squash into one commit.

@Tom-Ski something like this: https://github.com/libgdx/libgdx/pull/3925 ?

You have committed the merge, which isn't ideal.  Could you also close PRs that are no longer in use, it is very confusing to have multiple issues/PRs open for the same problem/issue.

I need some help with that. How can I remove/avoid the merge commit from appearing?

@Tom-Ski https://github.com/libgdx/libgdx/pull/3926


Can not reconstruct with raw data[data type is unsigned short]

When I perform reconstruction, encounter the following error:
......
Ignoring file: E:/RawData/raw.0357
Ignoring file: E:/RawData/raw.0358
Ignoring file: E:/RawData/raw.0359
ExceptionObject caught with reader->UpdateOutputInformation() in file c:\opensourcelibrary\itk-5.1.0\include\itk-5.1\rtkggofunctions.h line 273
itk::ExceptionObject (000000C54091B338)
Location: "void __cdecl rtk::ProjectionsReader<class itk::CudaImage<float,3> >::GenerateOutputInformation(void)"
File: c:\opensourcelibrary\itk-5.1.0\include\itk-5.1\rtkprojectionsreader.hxx
Line: 160
Description: itk::ERROR: Cannot create ImageIOFactory for file E:/RawData/raw.0000

Yes, ITK does not recognize raw data file format. You need to convert it to a known file format, e.g., by creating a mhd header in the MetaIO format.

Yes, ITK does not recognize raw data file format. You need to convert it to a known file format, e.g., by creating a mhd header in the MetaIO format.

THANDS

THANDS


Change TEST2/3 to reflect FR

Currently we have TEST3 (dev) and TEST2 (test) on FreeCEN, which is the opposite of what is used on FreeREG. This has led to issues/confusion in the past, particularly in relation to cms updates on Refinery. There appears to be less work involved in changing FC, so let's do that in order for both projects to have the saming naming conventions.

@smrr723 @Vino-S @Captainkirkdawson do you anticipate any hidden problems we might face in changing the naming conventions? Any possible conflict on Github or our deployment process?

On REG test2 is a development deployment. test3 is a production deployment. Both are for testing code. Complex code development is applied to test2. We apply bug fixes etc to test3 for final checkout before deployment to the production servers. The terms development and production in the above have a rails meaning. They serve static assets differently and they can have different performance settings.

Thanks @Captainkirkdawson. IF we were to swap the naming conventions around on FR (as we are investigating for FC), would you anticipate any errors or major issues?

@richpomfret
Why would we change the FR scheme??? Its been that way since day 1. Everyone knows it
We would have to get lemon to change the urls in Apache to point to different folders if you wanted to make such a change
Sorry but I do not see any benefit.
CEN has never actively used 2 sites on vervet at least not to my knowledge So why don't they adopt the same logic as REG?????
The logic was actually based on a progression. test1 were our personal servers, test2 open to users for their testing of development code and test3 pre-deployment of minor code fixes. We abandoned the personal servers as the costs were too high when we were using our own servers and went to our own machines

I can't see any negative side effect from changing the FC scheme to match FR.  We don't have anything on there tied to our production deployments.
@Captainkirkdawson I think Rich meant that we will be changing FC's test servers to match the (correct) FR naming convention.  Right now, FC test2 is equivalent to FR test3 and causes confusion occasionally.  The FR setup will be untouched if I understand correctly.

Sorry but that is not how I read the penultimate post

@smrr723 is correct, we are investigating changing FC to match FR (not the other way around). @Captainkirkdawson my previous question perhaps wasn't clear in that respect, but was one designed to flag/elicit what might go wrong with such a change by considering it from a FR perspective.
Thanks both. I think we can go ahead and roll this out later this week (if you're around @lemon-ukgen). Please keep us informed here and on the Slack sprint channel.

I have made the change to FreeCEN2 test sites:
https://test2.freecen.org.uk/ -> /home/apache/hosts/freecen2/development (RoR root)-> freecen2_development (db)
https://test3.freecen.org.uk/ -> /home/apache/hosts/freecen2/production (RoR root) -> freecen2_production db (db)


Do we need childSpanCount on SpanData

What's the use case to have childSpanCount in API?
We eliminated scenario when span data produced by SDK can be re-consumed by API as we removed all the dropped events counts. Perhaps this is in the same category of non-needed for API surface

This can be used by the backends to determine when a trace is completed, if someone pushes spans this information may be needed.

Decision: This will be on the protobuf, but not on SpanData.
For out-of-band recording, it is generally not possible to know this information, so it is not useful in that scenario.


Remove dependency on DID method name in operation payload and operation processor

Consider removing dependency on DID method name in operation payload and operation processor.
Such as the did property in update operation payload.
This issue would be of high-priority since it breaks backwards compatibility.

seems like a good idea, since all the operations are stored by didUniqueSuffix, did:methodName seems like a waste of space.
I'm considering the case where a user creates the same did document on 2 implementations of sidetree.
after which the previousOperationHash is the same,  then the user updates their bitcoin did... then an attacker attempts to replay their update operation on their other sidetree account...
Having the did method name in the update operation locks the update to the did method.
What other mechanism ensures this? Is it not the case that removing the method name would allow updates that are valid in one method to be valid in another (assuming they are played in the same order).
Maybe this is a desirable feature? or maybe i'm missing something.

@OR13, you are spot on as usual:
Is it not the case that removing the method name would allow updates that are valid in one method to be valid in another (assuming they are played in the same order).
This would be a feature, but we can debate if such feature is desirable/undesirable. @csuwildcat and I have talked about the possibility for the operations to exists on Sidetree methods running on different chains, or even potential migration if the underlying chain is compromised.

Fixed in 930ffe0276d5f0d3cb941b0595d27636c91448e6.


Setting project_id does not work to overwrite the project of the service account which is getting the credentials

TL;DR
Workload identity provider lives in a different project than the GKE cluster I want to access from a GitHub workflow. get-gke-credentials tries to access the GKE cluster in the project of the workload identity provider. Service account also lives in the workload identity provider project.
Expected behavior
project_id should be correctly picked up and overwrite any other projects (e.g. service account project)
Observed behavior
project_id is not respected. It seems that always the project ID of the service account is used
Action YAML
name: Deploy service

on:
  workflow_dispatch:
  push:
    branches:
      - main
    paths:
      - 'it/service/**'
      - 'it/k8s/service/**'

env:
  PROJECT_ID: "project-one"
  GKE_CLUSTER: "project-one-gke"
  LOCATION: "europe-west3-b"
  PROVIDER_NAME: "projects/NUMBER-OF-PROJECT-TWO/locations/global/workloadIdentityPools/github-actions-sa/providers/github-actions-sa"
  SA_EMAIL<EMAIL_ADDRESS>
jobs:
  push-to-it:
    name: Push service
    runs-on: ubuntu-latest

    permissions:
      contents: 'read'
      id-token: 'write'

    steps:
      - name: 'Checkout Config repo'
        uses: actions/checkout@v2
        with:
          path: config-repo
      - name: 'Checkou Oviva Github Actions'
        uses: actions/checkout@v2
        with:
          repository: oviva-ag/actions
          path: actions
          ssh-key: ${{ secrets.GH_ACTIONS_REPO_KEY }}
      - name: 'Checkout Helm Charts'
        uses: actions/checkout@v2
        with:
          repository: oviva-ag/k8s-test
          path: k8s
          token: ${{ secrets.GH_CI_PAT }}
      - name: 'Google auth'
        uses: google-github-actions/auth@v0
        with:
          workload_identity_provider: ${{ env.PROVIDER_NAME }}
          service_account: ${{ env.SA_EMAIL }}
      - name: 'Setup kubectl'
        uses: google-github-actions/get-gke-credentials@v0
        with:
          project_id: ${{ env.PROJECT_ID }}
          cluster_name: ${{ env.GKE_CLUSTER }}
          location: ${{ env.LOCATION }}
      - name: 'Install Helm Chart'
        uses: './actions/it-k8s-deploy'
        with:
          helm-path: 'k8s/helm'
          namespace: 'it'
          chart-name: 'service'
          release-name: 'service'
          config-repo-path: 'config-repo'
          value-files: 'k8s/helm/it-values.yaml config-repo/it/k8s/service/values.yaml'
      - name: 'Notify developers'
        env:
          CHAT_WEBHOOK: ${{ secrets.GOOGLE_CHAT_NOTIFICATION_CHANNEL }}
        run: |
          curl -H "Content-Type: application/json" -X POST -d '{ "text":"Deployed service" }' "$CHAT_WEBHOOK"

Log output
Error: google-github-actions/get-gke-credentials failed with: kubernetes Engine API has not been used in project NUMBER-OF-PROJECT-TWO before or it is disabled. Enable it by visiting https://console.developers.google.com/apis/api/container.googleapis.com/overview?project=NUMBER-OF-PROJECT-TWO then retry. If you enabled this API recently, wait a few minutes for the action to propagate to our systems and retry.

Additional information
Project one owns the cluster.
Project two owns the service account to access the cluster and also the workload identity provider.
The service account in project two has roles/container.developer access in project one.
No matter which environment variable I overwrite, the logs always show that get-gek-credentials is trying to fetch credentials from project two. I tried all of the environment variables mentioned here: https://github.com/google-github-actions/auth#usage => export_environment_variables.

I don't really understand it, but I just had to enable the Kubernetes API in project two (workload identity provider project) for this to work.


Profile tool: Fix reporting app contains Dataset

Found a bug where we aren't reporting the plan contains dataset properly. The issue here is timing when we set it and when we discover the dataset, which happens later.
Signed-off-by: Thomas Graves<EMAIL_ADDRESS>

build

build


error with installing qiime2R

Hello. I've tried installing qiime2R in the following ways
install.packages("remotes")
library(remotes)
remotes::install_github("jbisanz/qiime2R")

if (!requireNamespace("devtools", quietly = TRUE)){install.packages("devtools")}
library(devtools)
devtools::install_github("jbisanz/qiime2R")

Both ways received the same error
Downloading GitHub repo jbisanz/qiime2R@HEAD
Error: Failed to install 'qiime2R' from GitHub:
  'from' must be of length 1

What does this error mean and how else should I try installing qiime2R?
Thank you.

Could you post your session info?  You could also try installing from source:
download.file("https://github.com/jbisanz/qiime2R/archive/master.zip", "source.zip")
unzip("source.zip")
install.packages("qiime2R-master", repos = NULL, type="source")

Here is my session info
R version 4.2.3 (2023-03-15 ucrt)
Platform: x86_64-w64-mingw32/x64 (64-bit)
Running under: Windows 10 x64 (build 22621)

Matrix products: default

locale:
[1] LC_COLLATE=English_United States.utf8  LC_CTYPE=English_United States.utf8
[3] LC_MONETARY=English_United States.utf8 LC_NUMERIC=C
[5] LC_TIME=English_United States.utf8

attached base packages:
[1] stats     graphics  grDevices utils     datasets  methods   base

other attached packages:
[1] remotes_2.4.2

loaded via a namespace (and not attached):
[1] compiler_4.2.3  tools_4.2.3     rstudioapi_0.14 curl_5.0.1

Just tried your previous suggestion
download.file("https://github.com/jbisanz/qiime2R/archive/master.zip", "source.zip")
unzip("source.zip")
install.packages("qiime2R-master", repos = NULL, type="source")

and received this error
ERROR: dependencies 'Biostrings', 'rhdf5', 'zCompositions', 'phyloseq' are not available for package 'qiime2R'
* removing 'C:/Users/bugsj/AppData/Local/R/win-library/4.2/qiime2R'
Warning in install.packages :
  installation of package ‘qiime2R-master’ had non-zero exit status

Should I download the above dependencies and re-try?

Yes, when in doubt, manually install the dependencies. Not sure why you would have this problem, could be something about where they are being installed on windows.


Updated profile page

Updated profile page design, with added option to

make an email address primary and
delete an external ID (#231)

Also touched upon #189 and #190.

One issue with the removal of external IDs we saw the other day - because twitter auth doesn't return email address, if someone deleted twitter extid, there doesn't seem to be any way to add it again. Twitter auth right now asks for email address after login. Which wont work for an existing account.

That should be in this PR: buttons for all login services should be included in an "add external id" section.

The buttons can link to the existing /login/<service> endpoints. Lastuser will add them to the current profile if the user is already logged in. It will also prompt the user to merge accounts if there's an overlap with another account.

Account merger reversal is discussed in #230. It'll become high priority once we include the option of adding external services as people will start accidentally merging accounts.

The pending verification text should be a link to where the user can resend a verification link to themselves.


Remove check to the master if etcd membership

What changes are proposed in this pull request?
Remove check to the master if etcd membership.
Why are the changes needed?
Remove check to the master if etcd membership.
Otherwise, it will fail the following command with etcd membership

./bin/alluxio fsadmin report nodestatus

Does this PR introduce any user facing changes?
NA

alluxio-bot, merge this please


[pacman] redis sink docker image riferrei/redis-sink is missing in docker hub

I think we should publish it in a repository controlled by confluent?

I think we should publish it in a repository controlled by confluent?

To move ahead I pushed this image in bleporini/redis-sink and I promise I won't delete it 😉.

To move ahead I pushed this image in bleporini/redis-sink and I promise I won't delete it 😉.

@bleporini can this be closed?

@bleporini can this be closed?


sensu_gem does not install sensu-plugin.rb gem

Am I using this wrong?
After installing sensu with LWRP sensu_gem, like so:
sensu_gem "rest-client"

or
sensu_gem "sensu-plugin" do
    version node["monitor"]["sensu_plugin_version"]
end

I can see these gems in the folder
/opt/sensu/embedded/lib/ruby/gems/2.0.0/gems

But it is not found using
 gem list

and in my checks I keep getting errors about missing gms
{"timestamp":"2014-06-10T07:53:49.062045+0000","level":"info","message":"publishing check result",
"payload":{"client":"precise32","check":{"type":"metric","command":"rabbitmq-overview-metrics.rb",
"handlers":["metrics"],"standalone":true,"interval":30,
"name":"rabbitmq_overview_metrics","issued":1402386829,
"executed":1402386829,
"output":"/opt/chef/embedded/lib/ruby/site_ruby/1.9.1/rubygems/custom_require.rb:36:in `require':
cannot load such file -- sensu-plugin/metric/cli (LoadError)\n\tfrom /opt/chef/embedded/lib/ruby/site_ruby/1.9.1/rubygems/custom_require.rb:36:in `require'\n\tfrom /etc/sensu/plugins/rabbitmq-overview-metrics.rb:36:in `<main>'\n","status":1,"duration":0.039}}}

Without manually installing these gems my sensu checks don't work.
I use the default sensu cookbook installation parameters regarding embedded ruby:
 override["sensu"]["use_embedded_ruby"] = false

@kmejka There was an issue with the gemspec of the plugins. The binstubs weren't being created under /opt/sensu/embedded/bin/ , so that was the reason for the failures that we saw in the log. If you update the gems that you're using to version 0.0.2, you'll see that the plugins will be available on that location.
As that location is being added to the path if embedded ruby is used, it'll work.

In addition to the binstub issues mentioned above, sensu packages now default EMBEDDED_RUBY to true (as of sensu version 0.21), which should alleviate confusion around this issue. If you are still having problems. please feel free to open a new issue.


gh-11: added prettier to project configuration and formatted all files

Pull Request Test Coverage Report for Build 57

34 of 35 (97.14%)  changed or added relevant lines in 3 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 98.286%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/main/pom-parser/pom-parser.js
29
30
96.67%

Totals

Change from base Build 53:
0.0%

Covered Lines:
114

Relevant Lines:
115

💛  - Coveralls


Texture.from(htmlVideoElement) - image problem with green color

I use PIXI.Texture.from(htmlVideoElement).
If the video is a stream (from my webcam) and the viedo background color is a strong green, there is a problem with the video on my canvas element (see images).
The green pixels have changed.
The problem only exists if the video is a stream and only with that green color.
Images:
on top: as expected
on bottom: with problem

The correct green is important for me, because i use chroma keying with green screen:

If i use Seriously.js https://github.com/brianchirls/Seriously.js/ or p5.js https://p5js.org/ there is no problem. But i want to use pixi.js.
p5.js webcam excample: https://p5js.org/examples/dom-video-capture.html
Comment out the "filter(INVERT);" line and klick run.
Expected Behavior
Display the video correct on canvas.
Current Behavior
Display the video with changed green pixels on canvas.
Steps to Reproduce
https://jsfiddle.net/q3sewpk1/
(On top is the original video element, on bottom is the canvas.)
I have tested it with different intigrated and external webcams.
//pixi.js
<script src="https://cdnjs.cloudflare.com/ajax/libs/pixi.js/5.0.4/pixi.min.js"></script>

//original video
<video id="videoElement" crossorigin="anonymous"></video>

//Texture.from(htmlVideoElement) on canvas
<canvas id="Canvas" width="800" height="600"></canvas>

<script>

    //video element
    var video = document.querySelector("#videoElement");

    //webcam to video element
    if (navigator.mediaDevices.getUserMedia) {
      navigator.mediaDevices.getUserMedia({ video: { width: 800, height: 600 } })
        .then(function (stream) {
        video.srcObject = stream;
      })
        .catch(function (err0r) {
        console.log("Something went wrong!");
      });
    }

    //create a Pixi Application
    let app = new PIXI.Application({
      width: 800,         // default: 800
      height: 600,        // default: 600
      view: document.getElementById("Canvas")
    });

    //webcam to sprite
    var texture = PIXI.Texture.from(video);
    var videoSprite = new PIXI.Sprite(texture);
    videoSprite.width = app.renderer.width;
    videoSprite.height = app.renderer.height;

    //sprite to canvas
    app.stage.addChild(videoSprite);

</script>

Environment

pixi.js version: 5.0.4
Browser & Version: Chrome 75.0.3770.100 (64-Bit), Firefox 67.0.4 (64-Bit), Edge 44.17763.1.0 (Microsoft EdgeHTML 18.17763)
OS & Version: Windows 10 Pro
Running Example: https://jsfiddle.net/q3sewpk1/

We have no way to control linear->sRGB conversion on pixijs side. ThreeJS has something with "gamma" but i didnt look what exactly they can do.
There are examples when image passed through createImageBitmap does wrong sRGB conversion, so its not only video problem.
I suggest you to take that video, use it with PURE WEBGL demo, like in https://developer.mozilla.org/en-US/docs/Web/API/WebGL_API/Tutorial/Animating_textures_in_WebGL  , and then if problem persists , report it to chromium bugtracker.
The only closest issue that i see is https://bugs.chromium.org/p/chromium/issues/detail?id=825578 , but there's nothing about webgl and windows.
https://bugs.chromium.org/p/chromium/issues/list?q=video texture srgb&can=2 - here's my search. I think you can report it :)


Wip - start/stop acknowlege and Cb + tests

Hi,
You might be interested by some of the following changes.
The commit are simple enough I believed to be easily understood.
I don't expect it to be merged as it,
but as I won't be available in the following weeks to work or discuss about Pigato,
feel free to do what you want with it ;)

Thank you. I think they are interesting but I'll take some time to review them and merge.
Hopefully we'll have you back after some weeks :-)

Yes you will ;)
Take your time and don't hesite to cherry-pick ;)

For information, the first commit was because I am used to start a specific test with mocha -g '<regexp>' , but have been disturbated by stuff happening in a file not even needed for that test.

Quite finished to integrate your changes. Tomorrow I'll publish the update

Awesome. I should be able to give it a look by the end of next week.
On May 17, 2015 11:49 AM, "Paolo Ardoino"<EMAIL_ADDRESS>wrote:

Quite finished to integrate your changes. Tomorrow I'll publish the update
—
Reply to this email directly or view it on GitHub
https://github.com/prdn/pigato/pull/36#issuecomment-102822369.

Wow, I'm impressed.
Thanks for the good job.

All the credits for this commit are yours :-)
Thank you!!
On 22 May 2015 at 15:14, Dalmais Maxence<EMAIL_ADDRESS>wrote:

Wow, I'm impressed.
Thanks for the good job.
—
Reply to this email directly or view it on GitHub
https://github.com/prdn/pigato/pull/36#issuecomment-104656554.

--
Paolo Ardoino


Firefox Add-on Button is Broken

The Firefox Add-on button on the main page is broken.

Do you have a screenshot of this? It works fine on my end.

The button is linked to : https://addons.mozilla.org/en-US/firefox/addon/jacks-mousehunt-helper/
Whereas, it should be linked to : https://addons.mozilla.org/en-US/firefox/addon/mhct-mousehunt-helper/

Which button are you referring to exactly? The one on the main page was fixed 9 months ago as per https://github.com/mh-community-tools/mh-hunt-helper/commit/ef55bd6d1c0073b0c517a2ca7833240fc7e9637e

The Firefox one on this page.
https://github.com/mh-community-tools/mh-helper-extension

Thanks for clarifying! This has been fixed in #108


Save patches to temporary files

This PR saves patches directly to a temporary file rather than read these directly into memory - this fixes a number of issues but not the issue that spurred me to look at this.
This could be backported to 1.10 as it doesn't make any significant changes to the code structure.

Codecov Report

Merging #9296 into master will decrease coverage by <.01%.
The diff coverage is 38.23%.

@@            Coverage Diff             @@
##           master    #9296      +/-   ##
==========================================
- Coverage   41.19%   41.18%   -0.01%
==========================================
  Files         559      559
  Lines       73073    73120      +47
==========================================
+ Hits        30099    30115      +16
- Misses      39205    39229      +24
- Partials     3769     3776       +7

Impacted Files
Coverage Δ

modules/git/repo_compare.go
68.18% <100%> (ø)
:arrow_up:

models/pull.go
53.69% <25%> (-0.72%)
:arrow_down:

models/repo.go
47.84% <35.29%> (-0.09%)
:arrow_down:

routers/api/v1/repo/pull.go
35.24% <40%> (+0.06%)
:arrow_up:

routers/repo/pull.go
30.33% <43.75%> (+0.2%)
:arrow_up:

services/pull/pull.go
39.43% <50%> (ø)
:arrow_up:

modules/indexer/indexer.go
44.73% <0%> (-10.53%)
:arrow_down:

modules/migrations/migrate.go
23.78% <0%> (-1.63%)
:arrow_down:

modules/migrations/gitea.go
8.82% <0%> (-0.64%)
:arrow_down:

... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update baae90e...f86ac61. Read the comment docs.

So is this obsolete or complementary regarding #9302 ?

This one is simpler, the other is more of a refactor but also likely fixes the issue that spurred me to look at this.
We could probably backport this one - if we think the efficiency is worth it.

I'm gonna close this. We can re-examine this technique if 1.10 has lots of problems with its current structure.


Delete unnecessary spaces

Delete unnecessary spaces: When copying from the web page, there is an unnecessary space after the code.
Fix indent: Indentation is misaligned.

@changeworld : Thanks for your contribution! The author, @craigshoemaker, has been notified to review your proposed change.

@changeworld : Thanks for your contribution! The author, @craigshoemaker, has been notified to review your proposed change.

Thanks, @changeworld!
#sign-off

@changeworld - Thank you for your submission. We are not able to accept these kinds of changes (formatting and spacing changes) in the repo at this time.


Undefined make()

Hello,
I have error when I use this package on my sample search. The error says  "Call to a member function make() on null" :(
Below is my model:
namespace App;

use Illuminate\Database\Eloquent\Model;
use Illuminate\Database\Eloquent\SoftDeletes;

use Sofa\Eloquence\Eloquence;

class Thesis extends Model
{
    use SoftDeletes;

    use Eloquence;

    protected $table = 'test_table';

    protected $searchableColumns = ['column1', 'column2'];

}

Any help is greatly appreciated!!!

Its like the error is on the vendor\sofa\Eloquence\src\Builder.php on line 77 :(

Hi, you need to add Sofa\Eloquence\ServiceProvider::class to your service provider list in app/config/app.php.

How can I use this outside of Laravel?

Sorry. #18 got my back.


Instance Bot Parameters

Adding parameters that allow the member instances to sync properly with the Discord API
Should these parameters also push their updates to the database instead of requiring an SQL commit to be made manually whenever a parameter is modified?

Should these parameters also push their updates to the database instead of requiring an SQL commit to be made manually whenever a parameter is modified?

sounds like a good idea to force DB and instances be in sync, yeah

It's still missing some documentation in places as well as some potentially helpful comments but its fully functional as far as I can tell.
This will also allow us to start writing tests.


Add a whiteboard sample as webapp integration

Moved to https://github.com/Azure-Samples/socket.io-webapp-integration


Fixed a typo in the last "WM_PAINT".

@Tamjow : Thanks for your contribution! The author(s) have been notified to review your proposed change.


CDT-000: Update the dependencies.

Update the dependencies to the latest versions.

@AlviMurtaza, is this a WIP PR? What do we need to do to merge it and move on?

@hussainweb This is the initial update for the packages of the generator, there is a copy directory that will have the separate updates. I will raise a different PR for that.

@AlviMurtaza got it. But what's blocking us from merging this? And any ETA on the other PR that you mentioned?

I don't have the rights to merge this, @hussainweb can you check from your end if you have the rights?


libnvidia-container-1.0.6.drv fails to build: missing rpcgen

Describe the bug
When I tried to run a system upgrade, it failed to build libnvidia-container. Trying to build this derivation separately also fails. I guess a missing dependency.
$ nix build /nix/store/gw0dz18pykg8zimmr3hs856szh1xqc92-libnvidia-container-1.0.6.drv
builder for '/nix/store/gw0dz18pykg8zimmr3hs856szh1xqc92-libnvidia-container-1.0.6.drv' failed with exit code 2; last 10 log lines:
  patching file src/nvc_info.c
  patching file src/nvc_ldcache.c
  configuring
  no configure script, doing nothing
  building
  build flags: SHELL=/nix/store/k8p54jg8ipvnfz435mayf5bnqhw4qqap-bash-4.4-p23/bin/bash WITH_LIBELF=yes prefix=\$\(out\)
  rm -f /build/source/src/driver_rpc.h
  cd /build/source/src/ && rpcgen -h -C -M -N -o driver_rpc.h /build/source/src/driver_rpc.x
  /nix/store/k8p54jg8ipvnfz435mayf5bnqhw4qqap-bash-4.4-p23/bin/bash: rpcgen: command not found
  make: *** [Makefile:174: /build/source/src/driver_rpc.h] Error 127
[0 built (1 failed)]
error: build of '/nix/store/gw0dz18pykg8zimmr3hs856szh1xqc92-libnvidia-container-1.0.6.drv' failed

To Reproduce
Steps to reproduce the behavior:

nix build /nix/store/gw0dz18pykg8zimmr3hs856szh1xqc92-libnvidia-container-1.0.6.drv

Expected behavior
libnvidia-container should build without errors.
Additional context
Add any other context about the problem here.
Notify maintainers

Metadata
these paths will be fetched (0.05 MiB download, 0.28 MiB unpacked):
/nix/store/hfvjs6abgzadrv9f387v1ip5mr206jh9-bash-interactive-4.4-p23-dev
copying path '/nix/store/hfvjs6abgzadrv9f387v1ip5mr206jh9-bash-interactive-4.4-p23-dev' from 'https://cache.nixos.org'...

system: "x86_64-linux"
host os: Linux 5.4.70, NixOS, 21.03pre246543.24c9b05ac53 (Okapi)
multi-user?: yes
sandbox: yes
version: nix-env (Nix) 2.3.7
channels(root): "nixos-21.03pre248170.007126eef72"
nixpkgs: /nix/var/nix/profiles/per-user/root/channels/nixos

Maintainer information:
# a list of nixpkgs attributes affected by the problem
attribute:
# a list of nixos modules affected by the problem
module:

Fails to build for me as well
Seems to be missing rpcgen in buildInputs
https://github.com/NixOS/nixpkgs/blob/4a704c653b06b423b771f92af4f5c069df7dd682/pkgs/applications/virtualization/nvidia-docker/libnvc.nix#L45-L47

I can also see the same problem here:
https://github.com/NixOS/nixpkgs/issues/89166
After looking around, I can't seem to find a proper rpcgen. I tried the following:
{ stdenv, lib, fetchFromGitHub, pkgconfig, libelf, libcap, libseccomp }:

with lib; let

  modp-ver = "396.51";

  nvidia-modprobe = fetchFromGitHub {
    owner = "NVIDIA";
    repo = "nvidia-modprobe";
    rev = modp-ver;
    sha256 = "1fw2qwc84k64agw6fx2v0mjf88aggph9c6qhs4cv7l3gmflv8qbk";
  };

in stdenv.mkDerivation rec {
  pname = "libnvidia-container";
  version = "1.0.6";

  src = fetchFromGitHub {
    owner = "NVIDIA";
    repo = "libnvidia-container";
    rev = "v${version}";
    sha256 = "1pnpc9knwh8d1zqb28zc3spkjc00w0z10vd3jna8ksvpl35jl7w3";
  };

  # locations of nvidia-driver libraries are not resolved via ldconfig which
  # doesn't get used on NixOS. Additional support binaries like nvidia-smi are
  # not resolved via the environment PATH but via the derivation output path.
  patches = [ ./libnvc-ldconfig-and-path-fixes.patch ];

  makeFlags = [
    "WITH_LIBELF=yes"
    "prefix=$(out)"
  ];

  postPatch = ''
    sed -i 's/^REVISION :=.*/REVISION = ${src.rev}/' mk/common.mk
    sed -i 's/^COMPILER :=.*/COMPILER = $(CC)/' mk/common.mk

    mkdir -p deps/src/nvidia-modprobe-${modp-ver}
    cp -r ${nvidia-modprobe}/* deps/src/nvidia-modprobe-${modp-ver}
    chmod -R u+w deps/src
    touch deps/src/nvidia-modprobe-${modp-ver}/.download_stamp
  '';

  nativeBuildInputs = [ pkgconfig ];

  buildInputs = [ libelf libcap libseccomp ];

  meta = {
    homepage = "https://github.com/NVIDIA/libnvidia-container";
    description = "NVIDIA container runtime library";
    license = licenses.bsd3;
    platforms = platforms.linux;
  };
}

that provides a rpcgen, but got errors
gcc -fPIC -std=gnu11 -O2 -g -fdata-sections -ffunction-sections -fstack-protector -fno-strict-aliasing -fvisibility=hidden -Wall -Wextra -Wcast-align -Wpointer-arith -Wmissing-prototypes -Wnonnull -Wwrite-strings -Wlogical-op -Wformat=2 -Wmissing-format-attribute -Winit-self -Wshadow -Wstrict-prototypes -Wunreachable-code -Wconversion -Wsign-conversion -Wno-unknown-warning-option -Wno-format-extra-args -Wno-gnu-alignof-expression  -DNV_LINUX -isystem /build/source/deps/nix/store/chz7gx3jbzqpsaj5hxyf2a7ws294q33i-libnvidia-container-1.0.6/include -include /build/source/src/build.h -DWITH_LIBELF -DWITH_SECCOMP -I/nix/store/mmcj5dvbjc6d9rac1hb0an658s3lbd0q-libseccomp-2.5.0-dev/include -D_GNU_SOURCE -D_FORTIFY_SOURCE=2  -DNDEBUG -MMD -MF /build/source/src/driver.d -c -o /build/source/src/driver.lo /build/source/src/driver.c
In file included from /build/source/src/driver.c:24:
/build/source/src/driver_rpc.h:9:10: fatal error: rpc/rpc.h: No such file or directory
    9 | #include <rpc/rpc.h>
      |          ^~~~~~~~~~~
compilation terminated.
make: *** [Makefile:177: /build/source/src/driver.lo] Error 1

The issue is related to https://github.com/NixOS/nixpkgs/pull/95089. I tried using the recommended approach of settings NIX_CFLAGS_COMPILE + NIX_LDFLAGS but that doesn't work because no matter what libnvidia-container wants to build and install every target. Even with a patch, it's not clear if nvidia-docker needs all of the build outputs of libnvidia-container or just the shared libraries.

Looks like nvidia-docker definitely needs the nvidia-container-cli binary :(

Ok, I was able to get a successful build of the SOs and the binary by using a sort-of-gross patch to the libnvidia-container top-level Makefile.

The issue is related to #95089. I tried using the recommended approach of settings NIX_CFLAGS_COMPILE + NIX_LDFLAGS but that doesn't work because no matter what libnvidia-container wants to build and install every target. Even with a patch, it's not clear if nvidia-docker needs all of the build outputs of libnvidia-container or just the shared libraries.

Looks like nvidia-docker definitely needs the nvidia-container-cli binary :(

As I understand it, you investigated whether it was possible to skip the phase that required rpcgen or not, correct ?
Thanks for doing that 👍

Ok, I was able to get a successful build of nvidia-docker by using a sort-of-gross patch to the libnvidia-container top-level Makefile.

Could you please share your finding ? It could help either propose a fix or find the root cause.

@GuillaumeDesforges Yeah, I was looking into whether I could build nvidia-docker using libtirpc as per the recommendation in #95089. You still need the rpcgen phase I believe, but as you found adding rpcsvc-proto is sufficient to get past that part of the build.
What I found was not very encouraging:
First, I tried depending on libtirpc. This doesn't work because the Makefile that ships with libnvidia-container will build the shared, static, and tools builds. static is problematic because the libtirpc package doesn't contain static libraries (it's also a different version [1.1.4] than what nixpkgs contains, though I don't know if that's problematic).
I tried patching the Makefile enough to get only the shared and tools targets to build, and then realized that I needed to set the -DWITH_TIRPC define compiler flag.
This seems to work, though the patch is quite a hack. I can put up a PR for this if you'd like.
I another approach to avoid patching but it didn't work out and that was to vendor in the right version of libtirpc (using fetchurl). That doesn't seem to work because for whatever reason the compiler cannot find the libtirpc includes even though they exist in a location that AFAICT was consistent with how the Makefile operates. This of course probably wasn't actually true but by this point I was pretty annoyed and didn't feel like digging any further.

I'll put up a PR, and we can hash things out there.


reduce build size, run a docker user, give it a place to log

forked your work and would like to push these optimizations back into yours, taking the dev libraries out of the base image has reduced the compressed image from ~45MB on yours to ~28MB on mine.. I also changed it so direwolf does not run as root, and gave it a place to stash logs into.

Thank you for the contribution, I've merged it into my branch and reenabled the GitHub actions to get a test build going


Add prediction feedback

This adds predictionFeedback? to the base question, and displays it in the Lock component if it exists.

Note that the old LARA models had both give_prediction_feedback: boolean and prediction_feedback: string, both of which had to be set to see any feedback. It seemed simpler to condense into just predictionFeedback: string. We'll have to remember this when creating the migration, however.

Looks great to me, thanks.
One suggestion would be to try to use schema dependencies. JSONSchema and react-jsonschema-form seem to support that. Then we could show prediction feedback input only if the question is required (as otherwise this feedback is never shown, right?).
I think it might be enough to use basic conditional dependency if unchecked/false value is treated the same as "undefined":
https://react-jsonschema-form.readthedocs.io/en/latest/usage/dependencies/#conditional
Otherwise, dynamic should work (but the syntax is more complex):
https://react-jsonschema-form.readthedocs.io/en/latest/usage/dependencies/#dynamic

Thanks, I started looking at conditional dependencies on Friday, and was not able to get it to work easily, as it was hidden with undefined but visible with false. I expect it should be simple enough, though, so will keep looking.


bucketsample: locking isnt necessary due to atomics

@jschlather @jhaber

ya the downside to this is like the sum/count could be mismatched with the bucket data... I think thats an ok tradeoff?

I was mostly just being pessimistic without looking at the code (theoretically we could be splitting or resizing buckets in the write path). However it seems like we're just lazily initializing the long arrays, so this seems fine to me

ya I think b/c its just the lazy init and even that is done as a compareAndSet on an atomic we should be safe.


Get Payment Pages (similar to Payment Links)

🚀 Feature Proposal
Thank you for the great PHP interface! All my orders are from Payment Pages. I'd like to be able to get those orders from those pages. So, Just as we have paymentLink, could we also have have paymentPage? If necessary the only functionality at first could be $api->paymentPage->all(); (similar to paymentLink->all) with parameters for payment_id and reference_id.
Suggested Solution
Implement REST calls and PHP wrapper just the same as paymentLink, but for paymentPage.
Alternatives
No response
Additional Information
This is a feature request.

My payments

Hi there. I'm just checking in as to whether or not payment pages could be added to the PHP library? This would really help the operation of my business.


URL Blocked by lightspeed

From what I know the only way to bypass it is by getting a new url and I don't even know if that will work

You can always for this repository and deploy it yourself.

Also a duplicate of #6.


Feature Request: Live image cropping

Hello,
First of all thanks for this amazing library and all the hard work you put into it.
What would be nice to have is be able to crop the imported images in real time like this:

Library used for this: https://github.com/ctessier/nova-advanced-image-field
Because now you don't really now the right positions to crop the images.

Hello, I will do it as soon as possible. Thanks for your kind words!


Commiting appveyor yaml file enabling windows CI

vs2013 x64 release mode builds with nmake

I normally wouldn't approve my own PR, but I feel this one is important enough to merge in as early as possible.  Future PR's should benefit from this one.  The risk is low, as almost all work affects build files (but I did fix compile problems that recently crept in on windows).  This is the first PR that Travis verified that the merge request succeeds across three toolchains: GCC, Clang and Visual Studio.

:+1:


Behavior - When sleeping, connecting to BLE doesn't stop idle animation

When the robot is sleeping, if one connects to it with the iPad, the robot wakes up, the idle animation start and is not stopped.
When the robot is not sleeping, connecting stop the idle animation.
Behavior should be the same.

closed by 7f0ab378c89970d8da9fffd1fab25a654984b085