Finalized block won't increase until new authority set is selected.

After upgrading our dependency to the master substrate, our finalized block won't increase as normal unless new era changed.
I just run a local test network with alice and bob.
I tried to dig into the code. Looks like Voter's state stuck at Prevoted state and cannot become Precommitted state due to the following line.
self.votes.state().prevote_ghost.as_ref().map_or(false, |p_g| {
p_g == &last_round_estimate ||
	self.env.is_equal_or_descendent_of(last_round_estimate.0, p_g.0.clone())
})

I think there should be something wrong in my node/service.rs. But I cannot figure out the reason. Any hint would be really appreciated. 😄

Some logs
2021-01-06 14:16:27.105   INFO tokio-runtime-worker substrate:💤 Idle (1 peers), best: #18 (0xe0de…5e15), finalized #0 (0x3d92…0d29), ⬇ 24.1kiB/s ⬆ 30.0kiB/s
2021-01-06 14:16:28.028  TRACE tokio-runtime-worker afg:Polling round 1, state = State { prevote_ghost: None, finalized: None, estimate: None, completable: false }, step = Some(Prevoted)
2021-01-06 14:16:28.304   WARN tokio-runtime-worker libp2p_mdns::service:Parsing mdns packet failed: LabelIsNotAscii
2021-01-06 14:16:29.129  TRACE tokio-runtime-worker afg:Polling round 1, state = State { prevote_ghost: None, finalized: None, estimate: None, completable: false }, step = Some(Prevoted)
2021-01-06 14:16:30.229  TRACE tokio-runtime-worker afg:Polling round 1, state = State { prevote_ghost: None, finalized: None, estimate: None, completable: false }, step = Some(Prevoted)
2021-01-06 14:16:30.468  TRACE tokio-runtime-worker afg:Polling round 1, state = State { prevote_ghost: None, finalized: None, estimate: None, completable: false }, step = Some(Prevoted)
2021-01-06 14:16:30.469  TRACE tokio-runtime-worker afg:Polling round 1, state = State { prevote_ghost: None, finalized: None, estimate: None, completable: false }, step = Some(Prevoted)
2021-01-06 14:16:30.469  TRACE tokio-runtime-worker afg:Polling round 1, state = State { prevote_ghost: None, finalized: None, estimate: None, completable: false }, step = Some(Prevoted)
2021-01-06 14:16:30.471   INFO tokio-runtime-worker substrate:✨ Imported #19 (0x7beb…0fac)
2021-01-06 14:16:31.332  TRACE tokio-runtime-worker afg:Polling round 1, state = State { prevote_ghost: None, finalized: None, estimate: None, completable: false }, step = Some(Prevoted)
2021-01-06 14:16:32.090  TRACE tokio-runtime-worker afg:Polling round 1, state = State { prevote_ghost: None, finalized: None, estimate: None, completable: false }, step = Some(Prevoted)
2021-01-06 14:16:32.090  TRACE tokio-runtime-worker afg:Polling round 1, state = State { prevote_ghost: None, finalized: None, estimate: None, completable: false }, step = Some(Prevoted)
2021-01-06 14:16:32.090  TRACE tokio-runtime-worker afg:Polling round 1, state = State { prevote_ghost: None, finalized: None, estimate: None, completable: false }, step = Some(Prevoted)
2021-01-06 14:16:32.108   INFO tokio-runtime-worker substrate:💤 Idle (1 peers), best: #19 (0x7beb…0fac), finalized #0 (0x3d92…0d29), ⬇ 13.4kiB/s ⬆ 16.3kiB/s
2021-01-06 14:16:32.432  TRACE tokio-runtime-worker afg:Polling round 1, state = State { prevote_ghost: None, finalized: None, estimate: None, completable: false }, step = Some(Prevoted)
2021-01-06 14:16:33.536  TRACE tokio-runtime-worker afg:Polling round 1, state = State { prevote_ghost: None, finalized: None, estimate: None, completable: false }, step = Some(Prevoted)
2021-01-06 14:16:34.637  TRACE tokio-runtime-worker afg:Polling round 1, state = State { prevote_ghost: None, finalized: None, estimate: None, completable: false }, step = Some(Prevoted)
2021-01-06 14:16:34.759   WARN tokio-runtime-worker libp2p_mdns::service:Parsing mdns packet failed: LabelIsNotAscii
2021-01-06 14:16:35.063   WARN tokio-runtime-worker libp2p_mdns::service:Parsing mdns packet failed: LabelIsNotAscii
2021-01-06 14:16:35.742  TRACE tokio-runtime-worker afg:Polling round 1, state = State { prevote_ghost: None, finalized: None, estimate: None, completable: false }, step = Some(Prevoted)
2021-01-06 14:16:36.468   INFO tokio-runtime-worker substrate:✨ Imported #20 (0x27ee…a840)
2021-01-06 14:16:36.468  TRACE tokio-runtime-worker afg:Polling round 1, state = State { prevote_ghost: None, finalized: None, estimate: None, completable: false }, step = Some(Prevoted)
2021-01-06 14:16:36.845  TRACE tokio-runtime-worker afg:Polling round 1, state = State { prevote_ghost: None, finalized: None, estimate: None, completable: false }, step = Some(Prevoted)
2021-01-06 14:16:37.093  TRACE tokio-runtime-worker afg:Polling round 1, state = State { prevote_ghost: None, finalized: None, estimate: None, completable: false }, step = Some(Prevoted)
2021-01-06 14:16:37.109   INFO tokio-runtime-worker substrate:💤 Idle (1 peers), best: #20 (0x27ee…a840), finalized #0 (0x3d92…0d29), ⬇ 17.1kiB/s ⬆ 21.4kiB/s
2021-01-06 14:16:37.947  TRACE tokio-runtime-worker afg:Polling round 1, state = State { prevote_ghost: None, finalized: None, estimate: None, completable: false }, step = Some(Prevoted)
2021-01-06 14:16:39.049  TRACE tokio-runtime-worker afg:Polling round 1, state = State { prevote_ghost: None, finalized: None, estimate: None, completable: false }, step = Some(Prevoted)
2021-01-06 14:16:40.155  TRACE tokio-runtime-worker afg:Polling round 1, state = State { prevote_ghost: None, finalized: None, estimate: None, completable: false }, step = Some(Prevoted)
2021-01-06 14:16:41.258  TRACE tokio-runtime-worker afg:Polling round 1, state = State { prevote_ghost: None, finalized: None, estimate: None, completable: false }, step = Some(Prevoted)
2021-01-06 14:16:41.857  TRACE tokio-runtime-worker afg:Polling round 1, state = State { prevote_ghost: None, finalized: None, estimate: None, completable: false }, step = Some(Prevoted)
2021-01-06 14:16:42.096  TRACE tokio-runtime-worker afg:Polling round 1, state = State { prevote_ghost: None, finalized: None, estimate: None, completable: false }, step = Some(Prevoted)
2021-01-06 14:16:42.096  TRACE tokio-runtime-worker afg:Polling round 1, state = State { prevote_ghost: None, finalized: None, estimate: None, completable: false }, step = Some(Prevoted)
2021-01-06 14:16:42.096  TRACE tokio-runtime-worker afg:Polling round 1, state = State { prevote_ghost: None, finalized: None, estimate: None, completable: false }, step = Some(Prevoted)
2021-01-06 14:16:42.110   INFO tokio-runtime-worker substrate:💤 Idle (1 peers), best: #20 (0x27ee…a840), finalized #0 (0x3d92…0d29), ⬇ 19.6kiB/s ⬆ 27.2kiB/s
2021-01-06 14:16:42.132   INFO tokio-runtime-worker sc_basic_authorship::basic_authorship:🙌 Starting consensus session on top of parent 0x27ee035b640ee060572bb1227b4602ccc6c5ec1f4f39258845636b29891ea840
2021-01-06 14:16:42.247   INFO tokio-runtime-worker sc_basic_authorship::basic_authorship:🎁 Prepared block for proposing at 21 [hash: 0xb23524dc2b6a7a0582a389e62e2492fb4f4716a39902489981374dd232fae367; parent_hash: 0x27ee…a840; extrinsics (1): [0x97ca…9d38]]
2021-01-06 14:16:42.358  TRACE tokio-runtime-worker afg:Polling round 1, state = State { prevote_ghost: None, finalized: None, estimate: None, completable: false }, step = Some(Prevoted)
2021-01-06 14:16:42.363   INFO tokio-runtime-worker sc_consensus_slots:🔖 Pre-sealed block for proposal at 21. Hash now 0x507e110c52087f91c5c008d49b0be2b7493ce68c0027a41f2fd73348601854db, previously 0xb23524dc2b6a7a0582a389e62e2492fb4f4716a39902489981374dd232fae367.
2021-01-06 14:16:42.364   INFO tokio-runtime-worker substrate:✨ Imported #21 (0x507e…54db)
2021-01-06 14:16:42.364  TRACE tokio-runtime-worker afg:Polling round 1, state = State { prevote_ghost: None, finalized: None, estimate: None, completable: false }, step = Some(Prevoted)
2021-01-06 14:16:43.459  TRACE tokio-runtime-worker afg:Polling round 1, state = State { prevote_ghost: None, finalized: None, estimate: None, completable: false }, step = Some(Prevoted)
2021-01-06 14:16:44.561  TRACE tokio-runtime-worker afg:Polling round 1, state = State { prevote_ghost: None, finalized: None, estimate: None, completable: false }, step = Some(Prevoted)
2021-01-06 14:16:44.701  TRACE tokio-runtime-worker afg:Polling round 1, state = State { prevote_ghost: None, finalized: None, estimate: None, completable: false }, step = Some(Prevoted)
2021-01-06 14:16:45.663  TRACE tokio-runtime-worker afg:Polling round 1, state = State { prevote_ghost: None, finalized: None, estimate: None, completable: false }, step = Some(Prevoted)
2021-01-06 14:16:45.673  TRACE tokio-runtime-worker afg:Polling round 1, state = State { prevote_ghost: None, finalized: None, estimate: None, completable: false }, step = Some(Prevoted)
2021-01-06 14:16:46.764  TRACE tokio-runtime-worker afg:Polling round 1, state = State { prevote_ghost: None, finalized: None, estimate: None, completable: false }, step = Some(Prevoted)
2021-01-06 14:16:47.096  TRACE tokio-runtime-worker afg:Polling round 1, state = State { prevote_ghost: None, finalized: None, estimate: None, completable: false }, step = Some(Prevoted)
2021-01-06 14:16:47.096  TRACE tokio-runtime-worker afg:Polling round 1, state = State { prevote_ghost: None, finalized: None, estimate: None, completable: false }, step = Some(Prevoted)
2021-01-06 14:16:47.097  TRACE tokio-runtime-worker afg:Polling round 1, state = State { prevote_ghost: None, finalized: None, estimate: None, completable: false }, step = Some(Prevoted)
2021-01-06 14:16:47.110   INFO tokio-runtime-worker substrate:💤 Idle (1 peers), best: #21 (0x507e…54db), finalized #0 (0x3d92…0d29), ⬇ 16.4kiB/s ⬆ 20.8kiB/s
2021-01-06 14:16:47.864  TRACE tokio-runtime-worker afg:Polling round 1, state = State { prevote_ghost: None, finalized: None, estimate: None, completable: false }, step = Some(Prevoted)
2021-01-06 14:16:47.966   WARN tokio-runtime-worker libp2p_mdns::service:Parsing mdns packet failed: LabelIsNotAscii
2021-01-06 14:16:48.132   INFO tokio-runtime-worker sc_basic_authorship::basic_authorship:🙌 Starting consensus session on top of parent 0x507e110c52087f91c5c008d49b0be2b7493ce68c0027a41f2fd73348601854db
2021-01-06 14:16:48.580   WARN tokio-runtime-worker libp2p_mdns::service:Parsing mdns packet failed: LabelIsNotAscii
2021-01-06 14:16:48.596   INFO tokio-runtime-worker sc_basic_authorship::basic_authorship:🎁 Prepared block for proposing at 22 [hash: 0x0bb957c54d55d32d258126ea5c79b6815677b6d9ada1ea0a5d261ee075513f5b; parent_hash: 0x507e…54db; extrinsics (1): [0xbe2a…7745]]
2021-01-06 14:16:48.708   INFO tokio-runtime-worker sc_consensus_slots:🔖 Pre-sealed block for proposal at 22. Hash now 0x0ac27c1a381259d75d6c9dba77b53dd0ca2269379db97788f21ffc0871b08b59, previously 0x0bb957c54d55d32d258126ea5c79b6815677b6d9ada1ea0a5d261ee075513f5b.
2021-01-06 14:16:48.709   INFO tokio-runtime-worker substrate:✨ Imported #22 (0x0ac2…8b59)
2021-01-06 14:16:48.709  TRACE tokio-runtime-worker afg:Polling round 1, state = State { prevote_ghost: None, finalized: None, estimate: None, completable: false }, step = Some(Prevoted)
2021-01-06 14:16:48.709  TRACE tokio-runtime-worker afg:Polling round 1, state = State { prevote_ghost: None, finalized: None, estimate: None, completable: false }, step = Some(Prevoted)
2021-01-06 14:16:48.710  TRACE tokio-runtime-worker afg:Polling round 1, state = State { prevote_ghost: None, finalized: None, estimate: None, completable: false }, step = Some(Prevoted)
2021-01-06 14:16:48.967  TRACE tokio-runtime-worker afg:Polling round 1, state = State { prevote_ghost: None, finalized: None, estimate: None, completable: false }, step = Some(Prevoted)
2021-01-06 14:16:50.072  TRACE tokio-runtime-worker afg:Polling round 1, state = State { prevote_ghost: None, finalized: None, estimate: None, completable: false }, step = Some(Prevoted)
2021-01-06 14:16:51.177  TRACE tokio-runtime-worker afg:Polling round 1, state = State { prevote_ghost: None, finalized: None, estimate: None, completable: false }, step = Some(Prevoted)
2021-01-06 14:16:52.098  TRACE tokio-runtime-worker afg:Polling round 1, state = State { prevote_ghost: None, finalized: None, estimate: None, completable: false }, step = Some(Prevoted)
2021-01-06 14:16:52.099  TRACE tokio-runtime-worker afg:Polling round 1, state = State { prevote_ghost: None, finalized: None, estimate: None, completable: false }, step = Some(Prevoted)
2021-01-06 14:16:52.099  TRACE tokio-runtime-worker afg:Polling round 1, state = State { prevote_ghost: None, finalized: None, estimate: None, completable: false }, step = Some(Prevoted)
2021-01-06 14:16:52.113   INFO tokio-runtime-worker substrate:💤 Idle (1 peers), best: #22 (0x0ac2…8b59), finalized #0 (0x3d92…0d29), ⬇ 10.2kiB/s ⬆ 12.6kiB/s
2021-01-06 14:16:52.280  TRACE tokio-runtime-worker afg:Polling round 1, state = State { prevote_ghost: None, finalized: None, estimate: None, completable: false }, step = Some(Prevoted)
2021-01-06 14:16:53.380  TRACE tokio-runtime-worker afg:Polling round 1, state = State { prevote_ghost: None, finalized: None, estimate: None, completable: false }, step = Some(Prevoted)
2021-01-06 14:16:54.464  TRACE tokio-runtime-worker afg:Polling round 1, state = State { prevote_ghost: None, finalized: None, estimate: None, completable: false }, step = Some(Prevoted)
2021-01-06 14:16:54.464   INFO tokio-runtime-worker substrate:✨ Imported #23 (0xacf6…b92c)
2021-01-06 14:16:54.482  TRACE tokio-runtime-worker afg:Polling round 1, state = State { prevote_ghost: None, finalized: None, estimate: None, completable: false }, step = Some(Prevoted)
2021-01-06 14:16:55.586  TRACE tokio-runtime-worker afg:Polling round 1, state = State { prevote_ghost: None, finalized: None, estimate: None, completable: false }, step = Some(Prevoted)
2021-01-06 14:16:55.646   WARN tokio-runtime-worker libp2p_mdns::service:Parsing mdns packet failed: LabelIsNotAscii
2021-01-06 14:16:56.260   WARN tokio-runtime-worker libp2p_mdns::service:Parsing mdns packet failed: LabelIsNotAscii
2021-01-06 14:16:56.687  TRACE tokio-runtime-worker afg:Polling round 1, state = State { prevote_ghost: None, finalized: None, estimate: None, completable: false }, step = Some(Prevoted)
2021-01-06 14:16:57.103  TRACE tokio-runtime-worker afg:Polling round 1, state = State { prevote_ghost: None, finalized: None, estimate: None, completable: false }, step = Some(Prevoted)
2021-01-06 14:16:57.103  TRACE tokio-runtime-worker afg:Polling round 1, state = State { prevote_ghost: None, finalized: None, estimate: None, completable: false }, step = Some(Prevoted)
2021-01-06 14:16:57.104  TRACE tokio-runtime-worker afg:Polling round 1, state = State { prevote_ghost: None, finalized: None, estimate: None, completable: false }, step = Some(Prevoted)
2021-01-06 14:16:57.113   INFO tokio-runtime-worker substrate:💤 Idle (1 peers), best: #23 (0xacf6…b92c), finalized #0 (0x3d92…0d29), ⬇ 7.6kiB/s ⬆ 9.6kiB/s
2021-01-06 14:16:57.793  TRACE tokio-runtime-worker afg:Polling round 1, state = State { prevote_ghost: None, finalized: None, estimate: None, completable: false }, step = Some(Prevoted)
2021-01-06 14:16:58.897  TRACE tokio-runtime-worker afg:Polling round 1, state = State { prevote_ghost: None, finalized: None, estimate: None, completable: false }, step = Some(Prevoted)
2021-01-06 14:17:00.001  TRACE tokio-runtime-worker afg:Polling round 1, state = State { prevote_ghost: None, finalized: None, estimate: None, completable: false }, step = Some(Prevoted)

Some logs
2021-01-06 14:16:27.105   INFO tokio-runtime-worker substrate:💤 Idle (1 peers), best: #18 (0xe0de…5e15), finalized #0 (0x3d92…0d29), ⬇ 24.1kiB/s ⬆ 30.0kiB/s
2021-01-06 14:16:28.028  TRACE tokio-runtime-worker afg:Polling round 1, state = State { prevote_ghost: None, finalized: None, estimate: None, completable: false }, step = Some(Prevoted)
2021-01-06 14:16:28.304   WARN tokio-runtime-worker libp2p_mdns::service:Parsing mdns packet failed: LabelIsNotAscii
2021-01-06 14:16:29.129  TRACE tokio-runtime-worker afg:Polling round 1, state = State { prevote_ghost: None, finalized: None, estimate: None, completable: false }, step = Some(Prevoted)
2021-01-06 14:16:30.229  TRACE tokio-runtime-worker afg:Polling round 1, state = State { prevote_ghost: None, finalized: None, estimate: None, completable: false }, step = Some(Prevoted)
2021-01-06 14:16:30.468  TRACE tokio-runtime-worker afg:Polling round 1, state = State { prevote_ghost: None, finalized: None, estimate: None, completable: false }, step = Some(Prevoted)
2021-01-06 14:16:30.469  TRACE tokio-runtime-worker afg:Polling round 1, state = State { prevote_ghost: None, finalized: None, estimate: None, completable: false }, step = Some(Prevoted)
2021-01-06 14:16:30.469  TRACE tokio-runtime-worker afg:Polling round 1, state = State { prevote_ghost: None, finalized: None, estimate: None, completable: false }, step = Some(Prevoted)
2021-01-06 14:16:30.471   INFO tokio-runtime-worker substrate:✨ Imported #19 (0x7beb…0fac)
2021-01-06 14:16:31.332  TRACE tokio-runtime-worker afg:Polling round 1, state = State { prevote_ghost: None, finalized: None, estimate: None, completable: false }, step = Some(Prevoted)
2021-01-06 14:16:32.090  TRACE tokio-runtime-worker afg:Polling round 1, state = State { prevote_ghost: None, finalized: None, estimate: None, completable: false }, step = Some(Prevoted)
2021-01-06 14:16:32.090  TRACE tokio-runtime-worker afg:Polling round 1, state = State { prevote_ghost: None, finalized: None, estimate: None, completable: false }, step = Some(Prevoted)
2021-01-06 14:16:32.090  TRACE tokio-runtime-worker afg:Polling round 1, state = State { prevote_ghost: None, finalized: None, estimate: None, completable: false }, step = Some(Prevoted)
2021-01-06 14:16:32.108   INFO tokio-runtime-worker substrate:💤 Idle (1 peers), best: #19 (0x7beb…0fac), finalized #0 (0x3d92…0d29), ⬇ 13.4kiB/s ⬆ 16.3kiB/s
2021-01-06 14:16:32.432  TRACE tokio-runtime-worker afg:Polling round 1, state = State { prevote_ghost: None, finalized: None, estimate: None, completable: false }, step = Some(Prevoted)
2021-01-06 14:16:33.536  TRACE tokio-runtime-worker afg:Polling round 1, state = State { prevote_ghost: None, finalized: None, estimate: None, completable: false }, step = Some(Prevoted)
2021-01-06 14:16:34.637  TRACE tokio-runtime-worker afg:Polling round 1, state = State { prevote_ghost: None, finalized: None, estimate: None, completable: false }, step = Some(Prevoted)
2021-01-06 14:16:34.759   WARN tokio-runtime-worker libp2p_mdns::service:Parsing mdns packet failed: LabelIsNotAscii
2021-01-06 14:16:35.063   WARN tokio-runtime-worker libp2p_mdns::service:Parsing mdns packet failed: LabelIsNotAscii
2021-01-06 14:16:35.742  TRACE tokio-runtime-worker afg:Polling round 1, state = State { prevote_ghost: None, finalized: None, estimate: None, completable: false }, step = Some(Prevoted)
2021-01-06 14:16:36.468   INFO tokio-runtime-worker substrate:✨ Imported #20 (0x27ee…a840)
2021-01-06 14:16:36.468  TRACE tokio-runtime-worker afg:Polling round 1, state = State { prevote_ghost: None, finalized: None, estimate: None, completable: false }, step = Some(Prevoted)
2021-01-06 14:16:36.845  TRACE tokio-runtime-worker afg:Polling round 1, state = State { prevote_ghost: None, finalized: None, estimate: None, completable: false }, step = Some(Prevoted)
2021-01-06 14:16:37.093  TRACE tokio-runtime-worker afg:Polling round 1, state = State { prevote_ghost: None, finalized: None, estimate: None, completable: false }, step = Some(Prevoted)
2021-01-06 14:16:37.109   INFO tokio-runtime-worker substrate:💤 Idle (1 peers), best: #20 (0x27ee…a840), finalized #0 (0x3d92…0d29), ⬇ 17.1kiB/s ⬆ 21.4kiB/s
2021-01-06 14:16:37.947  TRACE tokio-runtime-worker afg:Polling round 1, state = State { prevote_ghost: None, finalized: None, estimate: None, completable: false }, step = Some(Prevoted)
2021-01-06 14:16:39.049  TRACE tokio-runtime-worker afg:Polling round 1, state = State { prevote_ghost: None, finalized: None, estimate: None, completable: false }, step = Some(Prevoted)
2021-01-06 14:16:40.155  TRACE tokio-runtime-worker afg:Polling round 1, state = State { prevote_ghost: None, finalized: None, estimate: None, completable: false }, step = Some(Prevoted)
2021-01-06 14:16:41.258  TRACE tokio-runtime-worker afg:Polling round 1, state = State { prevote_ghost: None, finalized: None, estimate: None, completable: false }, step = Some(Prevoted)
2021-01-06 14:16:41.857  TRACE tokio-runtime-worker afg:Polling round 1, state = State { prevote_ghost: None, finalized: None, estimate: None, completable: false }, step = Some(Prevoted)
2021-01-06 14:16:42.096  TRACE tokio-runtime-worker afg:Polling round 1, state = State { prevote_ghost: None, finalized: None, estimate: None, completable: false }, step = Some(Prevoted)
2021-01-06 14:16:42.096  TRACE tokio-runtime-worker afg:Polling round 1, state = State { prevote_ghost: None, finalized: None, estimate: None, completable: false }, step = Some(Prevoted)
2021-01-06 14:16:42.096  TRACE tokio-runtime-worker afg:Polling round 1, state = State { prevote_ghost: None, finalized: None, estimate: None, completable: false }, step = Some(Prevoted)
2021-01-06 14:16:42.110   INFO tokio-runtime-worker substrate:💤 Idle (1 peers), best: #20 (0x27ee…a840), finalized #0 (0x3d92…0d29), ⬇ 19.6kiB/s ⬆ 27.2kiB/s
2021-01-06 14:16:42.132   INFO tokio-runtime-worker sc_basic_authorship::basic_authorship:🙌 Starting consensus session on top of parent 0x27ee035b640ee060572bb1227b4602ccc6c5ec1f4f39258845636b29891ea840
2021-01-06 14:16:42.247   INFO tokio-runtime-worker sc_basic_authorship::basic_authorship:🎁 Prepared block for proposing at 21 [hash: 0xb23524dc2b6a7a0582a389e62e2492fb4f4716a39902489981374dd232fae367; parent_hash: 0x27ee…a840; extrinsics (1): [0x97ca…9d38]]
2021-01-06 14:16:42.358  TRACE tokio-runtime-worker afg:Polling round 1, state = State { prevote_ghost: None, finalized: None, estimate: None, completable: false }, step = Some(Prevoted)
2021-01-06 14:16:42.363   INFO tokio-runtime-worker sc_consensus_slots:🔖 Pre-sealed block for proposal at 21. Hash now 0x507e110c52087f91c5c008d49b0be2b7493ce68c0027a41f2fd73348601854db, previously 0xb23524dc2b6a7a0582a389e62e2492fb4f4716a39902489981374dd232fae367.
2021-01-06 14:16:42.364   INFO tokio-runtime-worker substrate:✨ Imported #21 (0x507e…54db)
2021-01-06 14:16:42.364  TRACE tokio-runtime-worker afg:Polling round 1, state = State { prevote_ghost: None, finalized: None, estimate: None, completable: false }, step = Some(Prevoted)
2021-01-06 14:16:43.459  TRACE tokio-runtime-worker afg:Polling round 1, state = State { prevote_ghost: None, finalized: None, estimate: None, completable: false }, step = Some(Prevoted)
2021-01-06 14:16:44.561  TRACE tokio-runtime-worker afg:Polling round 1, state = State { prevote_ghost: None, finalized: None, estimate: None, completable: false }, step = Some(Prevoted)
2021-01-06 14:16:44.701  TRACE tokio-runtime-worker afg:Polling round 1, state = State { prevote_ghost: None, finalized: None, estimate: None, completable: false }, step = Some(Prevoted)
2021-01-06 14:16:45.663  TRACE tokio-runtime-worker afg:Polling round 1, state = State { prevote_ghost: None, finalized: None, estimate: None, completable: false }, step = Some(Prevoted)
2021-01-06 14:16:45.673  TRACE tokio-runtime-worker afg:Polling round 1, state = State { prevote_ghost: None, finalized: None, estimate: None, completable: false }, step = Some(Prevoted)
2021-01-06 14:16:46.764  TRACE tokio-runtime-worker afg:Polling round 1, state = State { prevote_ghost: None, finalized: None, estimate: None, completable: false }, step = Some(Prevoted)
2021-01-06 14:16:47.096  TRACE tokio-runtime-worker afg:Polling round 1, state = State { prevote_ghost: None, finalized: None, estimate: None, completable: false }, step = Some(Prevoted)
2021-01-06 14:16:47.096  TRACE tokio-runtime-worker afg:Polling round 1, state = State { prevote_ghost: None, finalized: None, estimate: None, completable: false }, step = Some(Prevoted)
2021-01-06 14:16:47.097  TRACE tokio-runtime-worker afg:Polling round 1, state = State { prevote_ghost: None, finalized: None, estimate: None, completable: false }, step = Some(Prevoted)
2021-01-06 14:16:47.110   INFO tokio-runtime-worker substrate:💤 Idle (1 peers), best: #21 (0x507e…54db), finalized #0 (0x3d92…0d29), ⬇ 16.4kiB/s ⬆ 20.8kiB/s
2021-01-06 14:16:47.864  TRACE tokio-runtime-worker afg:Polling round 1, state = State { prevote_ghost: None, finalized: None, estimate: None, completable: false }, step = Some(Prevoted)
2021-01-06 14:16:47.966   WARN tokio-runtime-worker libp2p_mdns::service:Parsing mdns packet failed: LabelIsNotAscii
2021-01-06 14:16:48.132   INFO tokio-runtime-worker sc_basic_authorship::basic_authorship:🙌 Starting consensus session on top of parent 0x507e110c52087f91c5c008d49b0be2b7493ce68c0027a41f2fd73348601854db
2021-01-06 14:16:48.580   WARN tokio-runtime-worker libp2p_mdns::service:Parsing mdns packet failed: LabelIsNotAscii
2021-01-06 14:16:48.596   INFO tokio-runtime-worker sc_basic_authorship::basic_authorship:🎁 Prepared block for proposing at 22 [hash: 0x0bb957c54d55d32d258126ea5c79b6815677b6d9ada1ea0a5d261ee075513f5b; parent_hash: 0x507e…54db; extrinsics (1): [0xbe2a…7745]]
2021-01-06 14:16:48.708   INFO tokio-runtime-worker sc_consensus_slots:🔖 Pre-sealed block for proposal at 22. Hash now 0x0ac27c1a381259d75d6c9dba77b53dd0ca2269379db97788f21ffc0871b08b59, previously 0x0bb957c54d55d32d258126ea5c79b6815677b6d9ada1ea0a5d261ee075513f5b.
2021-01-06 14:16:48.709   INFO tokio-runtime-worker substrate:✨ Imported #22 (0x0ac2…8b59)
2021-01-06 14:16:48.709  TRACE tokio-runtime-worker afg:Polling round 1, state = State { prevote_ghost: None, finalized: None, estimate: None, completable: false }, step = Some(Prevoted)
2021-01-06 14:16:48.709  TRACE tokio-runtime-worker afg:Polling round 1, state = State { prevote_ghost: None, finalized: None, estimate: None, completable: false }, step = Some(Prevoted)
2021-01-06 14:16:48.710  TRACE tokio-runtime-worker afg:Polling round 1, state = State { prevote_ghost: None, finalized: None, estimate: None, completable: false }, step = Some(Prevoted)
2021-01-06 14:16:48.967  TRACE tokio-runtime-worker afg:Polling round 1, state = State { prevote_ghost: None, finalized: None, estimate: None, completable: false }, step = Some(Prevoted)
2021-01-06 14:16:50.072  TRACE tokio-runtime-worker afg:Polling round 1, state = State { prevote_ghost: None, finalized: None, estimate: None, completable: false }, step = Some(Prevoted)
2021-01-06 14:16:51.177  TRACE tokio-runtime-worker afg:Polling round 1, state = State { prevote_ghost: None, finalized: None, estimate: None, completable: false }, step = Some(Prevoted)
2021-01-06 14:16:52.098  TRACE tokio-runtime-worker afg:Polling round 1, state = State { prevote_ghost: None, finalized: None, estimate: None, completable: false }, step = Some(Prevoted)
2021-01-06 14:16:52.099  TRACE tokio-runtime-worker afg:Polling round 1, state = State { prevote_ghost: None, finalized: None, estimate: None, completable: false }, step = Some(Prevoted)
2021-01-06 14:16:52.099  TRACE tokio-runtime-worker afg:Polling round 1, state = State { prevote_ghost: None, finalized: None, estimate: None, completable: false }, step = Some(Prevoted)
2021-01-06 14:16:52.113   INFO tokio-runtime-worker substrate:💤 Idle (1 peers), best: #22 (0x0ac2…8b59), finalized #0 (0x3d92…0d29), ⬇ 10.2kiB/s ⬆ 12.6kiB/s
2021-01-06 14:16:52.280  TRACE tokio-runtime-worker afg:Polling round 1, state = State { prevote_ghost: None, finalized: None, estimate: None, completable: false }, step = Some(Prevoted)
2021-01-06 14:16:53.380  TRACE tokio-runtime-worker afg:Polling round 1, state = State { prevote_ghost: None, finalized: None, estimate: None, completable: false }, step = Some(Prevoted)
2021-01-06 14:16:54.464  TRACE tokio-runtime-worker afg:Polling round 1, state = State { prevote_ghost: None, finalized: None, estimate: None, completable: false }, step = Some(Prevoted)
2021-01-06 14:16:54.464   INFO tokio-runtime-worker substrate:✨ Imported #23 (0xacf6…b92c)
2021-01-06 14:16:54.482  TRACE tokio-runtime-worker afg:Polling round 1, state = State { prevote_ghost: None, finalized: None, estimate: None, completable: false }, step = Some(Prevoted)
2021-01-06 14:16:55.586  TRACE tokio-runtime-worker afg:Polling round 1, state = State { prevote_ghost: None, finalized: None, estimate: None, completable: false }, step = Some(Prevoted)
2021-01-06 14:16:55.646   WARN tokio-runtime-worker libp2p_mdns::service:Parsing mdns packet failed: LabelIsNotAscii
2021-01-06 14:16:56.260   WARN tokio-runtime-worker libp2p_mdns::service:Parsing mdns packet failed: LabelIsNotAscii
2021-01-06 14:16:56.687  TRACE tokio-runtime-worker afg:Polling round 1, state = State { prevote_ghost: None, finalized: None, estimate: None, completable: false }, step = Some(Prevoted)
2021-01-06 14:16:57.103  TRACE tokio-runtime-worker afg:Polling round 1, state = State { prevote_ghost: None, finalized: None, estimate: None, completable: false }, step = Some(Prevoted)
2021-01-06 14:16:57.103  TRACE tokio-runtime-worker afg:Polling round 1, state = State { prevote_ghost: None, finalized: None, estimate: None, completable: false }, step = Some(Prevoted)
2021-01-06 14:16:57.104  TRACE tokio-runtime-worker afg:Polling round 1, state = State { prevote_ghost: None, finalized: None, estimate: None, completable: false }, step = Some(Prevoted)
2021-01-06 14:16:57.113   INFO tokio-runtime-worker substrate:💤 Idle (1 peers), best: #23 (0xacf6…b92c), finalized #0 (0x3d92…0d29), ⬇ 7.6kiB/s ⬆ 9.6kiB/s
2021-01-06 14:16:57.793  TRACE tokio-runtime-worker afg:Polling round 1, state = State { prevote_ghost: None, finalized: None, estimate: None, completable: false }, step = Some(Prevoted)
2021-01-06 14:16:58.897  TRACE tokio-runtime-worker afg:Polling round 1, state = State { prevote_ghost: None, finalized: None, estimate: None, completable: false }, step = Some(Prevoted)
2021-01-06 14:17:00.001  TRACE tokio-runtime-worker afg:Polling round 1, state = State { prevote_ghost: None, finalized: None, estimate: None, completable: false }, step = Some(Prevoted)

fn process_incoming(&mut self, cx: &mut Context) -> Result<(), E::Error> {
while let Poll::Ready(Some(incoming)) = Stream::poll_next(Pin::new(&mut self.incoming), cx) {
	trace!(target: "afg", "Round {}: Got incoming message", self.round_number());

It won't enter the inner scope at all.

fn process_incoming(&mut self, cx: &mut Context) -> Result<(), E::Error> {
while let Poll::Ready(Some(incoming)) = Stream::poll_next(Pin::new(&mut self.incoming), cx) {
	trace!(target: "afg", "Round {}: Got incoming message", self.round_number());

It won't enter the inner scope at all.

I found out the reason. I miss this line so other validators cannot receive the message.
config.network.notifications_protocols.push(sc_finality_grandpa::GRANDPA_PROTOCOL_NAME.into());

I found out the reason. I miss this line so other validators cannot receive the message.
config.network.notifications_protocols.push(sc_finality_grandpa::GRANDPA_PROTOCOL_NAME.into());


schedule, config: use leading dollar sign to mark exclusive labels

What problem does this PR solve?
We need maintain exclusive labels list in code. Not extensible.
What is changed and how it works?

labels start with '$' are recognized as exclusive.
use different format check for label keys and label values

Check List
Tests

Unit test
Manual test (test setting and deleting labels)

/merge

/merge

/merge

/merge


Update Version to follow k8s GroupAPI naming convention

Based on docs and guideline here https://kubernetes.io/docs/concepts/overview/kubernetes-api/#api-versioning It's better to follow the same standard and change the API version

After a discussion with the Ops team, we agreed our operator is not mature to version as a beta. Update Version to Alpha level


add xcode template

Added template to avoid writing a lot of boilerplate code

Codecov Report

Merging #75 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #75   +/-   ##
=======================================
  Coverage   92.42%   92.42%
=======================================
  Files           6        6
  Lines         132      132
=======================================
  Hits          122      122
  Misses         10       10

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8f52836...7a7f49f. Read the comment docs.

Thanks for your work but I'm worried about this to be included in the official repository. Actually I have some snippets that is used in my company, so how about maintaining those templates in the independent repository? I can feature that repository in the README.md.

@devxoul I can create a separate repository for Xcode templates

i'm created repository with xcode template
ReactorKit template

I am writing an article for a Russian audience of programmers about rxswift and paid attention to your architecture, when I finish, can you make a code review of my examples?)

@gre4ixin sorry for late reply. Of course I can. Please don't hesitate requesting me a code review on ReactorKit stuff :)

@gre4ixin Sure! I have my email address on my GitHub profile page.

@gre4ixin Sure! I have my email address on my GitHub profile page.

can you add link to my repository with template in your repository?)
https://github.com/gre4ixin/ReactorKit-Template


Fix a crash in _WritePseudoWindowCallback

Fixes MSFT:40853556
There's a small race here. The renderer thread in ConPTY might notice the terminal is gone, call CloseOutput, and release the vt renderer, and then the window proc fires and decides to minimize/restore the window, triggering an A/V.
I'm 100% confident that this has NEVER happened to a real user. But the test labs hit it so much that it makes up ~26% of our crashes.
I haven't tested this cause again, it doesn't hit in the wild

Could this also be MSFT:40913882?

LOL, thanks for fixing my fixe. I did the same thing to a contributor's PR this exact same week.

Could this also be MSFT:40913882?

Nah, I'll reply with investigation in that bug.

Just from reading the diff, I don't quite get why we wouldn't have to add these guards everywhere else. What makes SetWindowVisibility so special here?

Just from reading the diff, I don't quite get why we wouldn't have to add these guards everywhere else. What makes SetWindowVisibility so special here?

Presumably, this is the only bit of code that can be called from another thread in an unsafe way here. Typically everything else we were doing was always during startup or immediately on shutdown, but now we've got this pesky user32 input thread to deal with window messages that can get in here too now

That explanation makes sense to me!

@msftbot merge this in 5 minutes


Option to update overload_manager stop_accepting_requests_scale_percent manually

Title: Option to update stop_accepting_requests_scale_percent manually
Description:
With help on overload_manager configuration, we can able to overload_actions.stop_accepting_requests partially, if cpu threshold breached (resource_monitors.injected_resource)
Here the stop_accepting_requests_scale_percent will be calculate with below formula
Sets the action state to 0 when the resource pressure is below the scaling_threshold,
(pressure - scaling_threshold)/(saturation_threshold - scaling_threshold) when scaling_threshold < pressure < saturation_threshold,
and to 1 (saturated) when the pressure is above the saturation_threshold.”
https://www.envoyproxy.io/docs/envoy/latest/configuration/operations/overload_manager/overload_manager.html#triggers

In our cases, it's not giving the the result efficiently. cpu and stop_accepting_requests_scale_percent is in the state of flip-flop pattern. Some testing result give below.
scaling_threshold = 65
saturation_threshold = 100

block_percent = (pressure - scaling_threshold)/(saturation_threshold - scaling_threshold)

RPS     CPU%    stop_accepting_requests_scale_percent
---     ---     -----
1K      4       0
5K      18      0
10K     37      0
15K     57      0
20K     71      17  [(71 - 65)/(100 - 65) = 17]
        70      14  [(70 - 65)/(95 - 65) = 14]
        45      0
        83      51  [(81 - 65)/(95 - 65) = 51]
        48      0
        79      40  [(79 - 65)/(95 - 65) = 40]
        55      0
25K     92      77  [(92 - 65)/(95 - 65) = 77]
        57      0
        96      88  [(96 - 65)/(100 - 65) = 88]
        49      0
        99      97  [(99 - 65)/(100 - 65) = 97]

In order to gradually blocking/releasing the request, we planning to calculate the stop_accepting_requests_scale_percent manually. We need option to update the this config in envoy. Is it currently possible ?

cc @KBaichoo

We need option to update the this config in envoy. Is it currently possible ?
You might be able to do this using https://github.com/envoyproxy/envoy/blob/main/source/extensions/resource_monitors/injected_resource/injected_resource_monitor.h#L20 though you'd then need an additional program maintaining the file generation that contains the CPU usage and could dampen that.

How are you computing CPU usage?

we are calculating based on cpuacct.usage.
start=$(cat /sys/fs/cgroup/cpu/cpuacct.usage)
sleep 10
end=$(cat /sys/fs/cgroup/cpu/cpuacct.usage)
allocated=$(cat /sys/fs/cgroup/cpu/cpu.shares)

diff=$(($end - $start))
usage=$(printf '%.2f\n' $(echo $diff / 10000000 | bc -l))
usage_percent=$(printf '%.2f\n' $(echo $usage / $allocated | bc -l))


Port Forwarding not working on Secondary Network Interface

Summary
I have an ec2 instance with 2 network interfaces (eth0 & eth1).  If I do nc -l 9090 for example, I can verify that connection can be established via either NIC.  However, when I create a container with docker run -p 9090:9090, and inside it I run nc -l 9090, I can only connect via eth0.  When I try to connect via eth1, the telnet hangs in connecting state.
Note that both NICs were up before I started the docker daemon, and I can verify that the docker-proxy has occupied port 9090 on eth1 (address in use).  Also evident is that the telnet hangs (it otherwise would immediately returns "Connection refused").  Also note that multiple IP addresses on same NIC works fine.
Configuration
Linux box with 2 network interfaces and Docker.
  In terminal A, do:
$ nc -l 9090

In terminal B, do:
$ telnet [nic-1-ip] 9090
$ telnet [nic-2-ip] 9090

In both cases, connection should be established.  In fact they're just loopback connections.  Now, in terminal A do:
$ docker run -ti -p 9090:9090 centos bash

In terminal B, do the same thing as before.  Verify that only nic-1 successfully connects.  Nic-2 is stuck in connecting state.
Please let me know if I missed anything, perhaps it's already fixed in latest version.

Hi!
Please read this important information about creating issues.
If you are reporting a new issue, make sure that we do not have any duplicates already open. You can ensure this by searching the issue list for this repository. If there is a duplicate, please close your issue and add a comment to the existing issue instead.
If you suspect your issue is a bug, please edit your issue description to include the BUG REPORT INFORMATION shown below. If you fail to provide this information within 7 days, we cannot debug your issue and will close it. We will, however, reopen it if you later provide the information.
This is an automated, informational response.
Thank you.
For more information about reporting issues, see https://github.com/docker/docker/blob/master/CONTRIBUTING.md#reporting-other-issues

BUG REPORT INFORMATION
Use the commands below to provide key information from your environment:
docker version:
docker info:
uname -a:
Provide additional environment details (AWS, VirtualBox, physical, etc.):
List the steps to reproduce the issue:
1.
2.
3.
Describe the results you received:
Describe the results you expected:
Provide additional info you think is important:
----------END REPORT ---------
#ENEEDMOREINFO


TypeScript does not infer excess property check for union of optional keys in object literal when using computed property names

🕗 Version & Regression Information
This is the behavior in every version I tried in TS playground.
⏯ Playground Link
https://www.typescriptlang.org/play/?#code/GYVwdgxgLglg9mABMAFDMAHEUBciDeiA1gKYCeAjAPx4DOUATugOYC+AlAQFCtdcD0-RACESACwCGAN3ggGiCGJIQieKEoYlEMWoglISADwzKoJACaISDBnHkB3GOsTqtwOABsPcR2GYKJLy5gfHxSMgAmPAAiKUCQEmjWXmDwaHgkYAiUcJjwimjOfC5EUuQUfABtcIBdGLiPBKT2Hj5QSFgEZABmHPI88gjC7jLEQUQAQV0jE2gLFyVkT29ffwhAj2QJGA9dR2d9Kxs7HBKy8YB5ACMAK1NEDydrQMQAWwkyRAQPT9pZmGAnyIYB8SAwthMDFgJFoABo9GBLAByarkGpIxDmOAwxAgqBWQw6fHoFxkEyIJGEfI0RD0Jh+RAAH0Q4HMJGA6AsAG5EKwkQA6M6lVBVWr1eKJDitVIdDLIAAsfTIA0o0SZiGi4SGRSFYyEABVFu4vD4WA9ObSxHAQB5LJoMHZ8YdrLZ5I9SNpMt1EFdsJjsbo8bqRaiyHUNQ0mlLeEA
💻 Code
function f(input: { key1?: string}) {
}

// Behaviour check: there is an expected error with the following call
f{{key2: "value"}}

function f2(key: "key1") {
    f({[key]: "value"})
}

function f3(key: "key2") {
    // As expected the following call fails with an error:
    // Object literal may only specify known properties, and '[key]' does not exist in type '{ key1?: string | undefined; }'.
    f({[key]: "value"})
}

function f4(key: "key1" | "key2") {
    // The following line should report an error like in f3 but does not
    f({[key]: "value"})
}

🙁 Actual behavior
TypeScript allows f({[key]: "value"}) in f4(key: "key1" | "key2") without an error, even when key is "key2", which isn't a valid property in the input type.
🙂 Expected behavior
TypeScript should report an error in f4 when key is "key2", just like it does in f3, since "key2" is not a known property of the type { key1?: string }.

Related or possibly even a duplicate: #36920

This isn't a bug. Excess property checks are there to ensure that you don't statically pass a misnamed property, but this property is possibly valid, therefore not excess.


Suggested Idea: Moved Session to eval package

Moved Session and all functions related to evaluation to eval package.
Exported some functions needed from main.go on Session.

I don't know if this is something that you would be interested in but I wanted to get the evaluation functionality of gore in a library for a project I am planning. So I moved the Session struct and all functions needed to the eval package which is then imported from main. I had to export some functions such as completeWord to be used from main.go. I didn't export unused functions outside of the eval package but since I don't have an overall view of the project and how you are thinking of evolving the project some other functions may also need to be exported. The API for the eval package is probably not stable because of that. Let me know what you think.
A few things I noticed is that the stdin, stdout and stderr of the command in goRun is linked directly to os.Stdin, etc... I would like to have the `func (s *Session) Eval(in string) error {' return the stdout, stderr and the pretty printed output seperately. This would be nicer from an library API point of view though may add some complexity for the normal repl.
Lastly one thing I think could be improved is that when running a function that does some output, every subsequent run includes the output from that function. To prevent that we could save the previously seen output and remove already seen output from the new output.

Ah, really nice work! Gonna look into it shortly. The suggested interface change of Session.Eval also looks reasonable, I'll do that in separate issue.

@motemen
I don't mind trying to do the interface change to Session.Eval. After thinking about it, I think we have 2 options to implement that change. Either taking as arguments an io.Writer and io.Readers for os.Stdin, os.Stdout and os.Stderr to read and write to, or return io.Writer and io.Readers for them.
As for seperating, raw output and pretty printed output, my idea was to create a temp file through which the pretty printer would communicate and return an io.Reader to that file.
What do you think?

Thanks!
I prefer including writers/readers to the arguments so that
the user can pass io.Stdout or &bytes.Buffer.
Communicating with a temp file might be an overkill for this issue, so let's not do it here.
(Actually I don't quite understand what and how they transfer values)


[BUG]: UnboundLocalError: local variable 'num_gpus' referenced before assignment

Describe the bug
A clear and concise description of what the bug is.
Screenshots

Desktop (please complete the following information):

OS: MacOS

When device is cpu or mps, this error will be occur.

I Will fix this by add a default value.
def huggingface_loader(llm_adapter: BaseLLMAdaper, model_params: ModelParams):
    device = model_params.device
    max_memory = None

    # if device is cpu or mps. gpu need to be zero
    num_gpus = 0

...


Infer Schema Should Have Option To Cache

Problem: Frequently I use this to parse csv files from AWS S3. I want to cache these RDDs so I don’t have to keep hitting S3. When I enable inferSchema this adds a pass to the data. There is currently no way to make spark-csv cache the data when it does its pass for inferSchema.
Suggested Fix: Add another option to spark-csv that allows the user to specify whether to cache the RDD on inferSchema. This can be false by default to preserve the current behavior.

Why wouldn't caching the DataFrame after reading it (with inferSchema) solve your problem? After you cache the DataFrame that is returned by spark-csv, all access to data will be answered from the cache and spark-csv does not get involved.


Fix rst formatting in documentation

Whitespace is required before ":sup:". Using backslash-escaped whitespace
prevents it from appearing in the processed document.
Thanks for contributing to TVM!   Please refer to guideline https://tvm.apache.org/docs/contribute/ for useful information and tips. After the pull request is submitted, please request code reviews from Reviewers by @ them in the pull request thread.

This is to fix the formatting of the page and index at https://tvm.apache.org/docs/deploy/arm_compute_lib.html
@lhutton1 could you review?


ArgumentError: wrong number of arguments (given 3, expected 1..2) on records.error.add

There seems to be an issue in the gem. When trying to add error to the record it gives the error -
ArgumentError: wrong number of arguments (given 3, expected 1..2)
the error is coming from the file lib/validates_timeiness/validator.rb
module ValidatesTimeliness
  class Validator < ActiveModel::EachValidator
    def add_error(record, attr_name, message, value=nil)
      value = format_error_value(value) if value
      message_options = { message: options.fetch(:"#{message}_message", options[:message]), restriction: value }
      record.errors.add(attr_name, message, message_options)
    end
  end
end

But this works if I use splat operator
record.errors.add(attr_name, message, message_options)
The issue was caused after I updated the gemfile.

What version of the gem are you using?
What version of Rails/Activetecord?
What version of Ruby?
On 7 Dec 2021, 5:36 PM +1100, Jigme Tashi Namgyal @.***>, wrote:

There seems to be an issue in the gem. When trying to add error to the record it gives the error -
ArgumentError: wrong number of arguments (given 3, expected 1..2)
the error is coming from the file lib/validates_timeiness/validator.rb
module ValidatesTimeliness
class Validator < ActiveModel::EachValidator
def add_error(record, attr_name, message, value=nil)
value = format_error_value(value) if value
message_options = { message: options.fetch(:"#{message}_message", options[:message]), restriction: value }
record.errors.add(attr_name, message, message_options)
end
end
end
But this works if I use splat operator
record.errors.add(attr_name, message, message_options)
The issue was caused after I updated the gemfile.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

What version of the gem are you using? What version of Rails/Activetecord? What version of Ruby?
…
On 7 Dec 2021, 5:36 PM +1100, Jigme Tashi Namgyal @.***>, wrote: There seems to be an issue in the gem. When trying to add error to the record it gives the error - ArgumentError: wrong number of arguments (given 3, expected 1..2) the error is coming from the file lib/validates_timeiness/validator.rb module ValidatesTimeliness class Validator < ActiveModel::EachValidator def add_error(record, attr_name, message, value=nil) value = format_error_value(value) if value message_options = { message: options.fetch(:"#{message}_message", options[:message]), restriction: value } record.errors.add(attr_name, message, message_options) end end end But this works if I use splat operator record.errors.add(attr_name, message, message_options) The issue was caused after I updated the gemfile. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or unsubscribe.

Ruby version ruby 3.0.2p107 (2021-07-07 revision 0db68f0233) [arm64-darwin20]
Rails version Rails <IP_ADDRESS>
validates_timeliness version 6.0.0.alpha1

Try the beta1 version of the gem.
On 7 Dec 2021, 5:50 PM +1100, Jigme Tashi Namgyal @.***>, wrote:

What version of the gem are you using? What version of Rails/Activetecord? What version of Ruby?
…
On 7 Dec 2021, 5:36 PM +1100, Jigme Tashi Namgyal @.***>, wrote: There seems to be an issue in the gem. When trying to add error to the record it gives the error - ArgumentError: wrong number of arguments (given 3, expected 1..2) the error is coming from the file lib/validates_timeiness/validator.rb module ValidatesTimeliness class Validator < ActiveModel::EachValidator def add_error(record, attr_name, message, value=nil) value = format_error_value(value) if value message_options = { message: options.fetch(:"#{message}_message", options[:message]), restriction: value } record.errors.add(attr_name, message, message_options) end end end But this works if I use splat operator record.errors.add(attr_name, message, message_options) The issue was caused after I updated the gemfile. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or unsubscribe.
Ruby version ruby 3.0.2p107 (2021-07-07 revision 0db68f0233) [arm64-darwin20]
Rails version Rails <IP_ADDRESS>
validates_timeliness version 6.0.0.alpha1
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or unsubscribe.

Try the beta1 version of the gem.
…
On 7 Dec 2021, 5:50 PM +1100, Jigme Tashi Namgyal @.>, wrote: > What version of the gem are you using? What version of Rails/Activetecord? What version of Ruby? > … > On 7 Dec 2021, 5:36 PM +1100, Jigme Tashi Namgyal @.>, wrote: There seems to be an issue in the gem. When trying to add error to the record it gives the error - ArgumentError: wrong number of arguments (given 3, expected 1..2) the error is coming from the file lib/validates_timeiness/validator.rb module ValidatesTimeliness class Validator < ActiveModel::EachValidator def add_error(record, attr_name, message, value=nil) value = format_error_value(value) if value message_options = { message: options.fetch(:"#{message}_message", options[:message]), restriction: value } record.errors.add(attr_name, message, message_options) end end end But this works if I use splat operator record.errors.add(attr_name, message, message_options) The issue was caused after I updated the gemfile. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or unsubscribe. Ruby version ruby 3.0.2p107 (2021-07-07 revision 0db68f0233) [arm64-darwin20] Rails version Rails <IP_ADDRESS> validates_timeliness version 6.0.0.alpha1 — You are receiving this because you commented. Reply to this email directly, view it on GitHub, or unsubscribe.

The error seems to be from beta1. alpha works fine for me

The error seems to be from beta1. alpha works fine for me

That’s confusing as you just said you were using alpha1 with this error.
On 7 Dec 2021, 5:55 PM +1100, Jigme Tashi Namgyal @.***>, wrote:

The error seems to be from beta1. alpha works fine for me
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or unsubscribe.

Yeapp made a mistake. Edited the comment again. The error is from beta

Worked Thank you

beta2 works!


NPM 7 installs very old version

This might be related to the #1986 issue so if it is apologies for the noise.
Running npm i --save-dev eslint-plugin-import eslint-config-import  in an empty project brings in a super old version of the plugin that seems pinned to the eslint-config-import version (0.13.0). In turn this is causing me problems when using eslint-import-resolver-alias which expects<EMAIL_ADDRESS>But all is fine if I force the npm install.
$ node -v
v15.11.0
$ npm -v
7.6.0

What is eslint-config-import?

https://www.npmjs.com/package/eslint-config-import

I would suggest not using that package, as it hasn’t been maintained in 5 years, i don’t have publish rights on it, and i can’t find any record of that package.json file in this repo.

Additionally, it’s peer dep on 0.13 of this plugin means that you are forced to use 0.13 of the plugin with it, otherwise your dep graph is invalid.

OK thanks. Is an old project, will remove eslint-config-import and see what breaks :)

For posterity, here’s https://github.com/benmosher/eslint-plugin-import/tree/v0.13.0/config, and it was removed in https://github.com/benmosher/eslint-plugin-import/commit/369c9ddb6036b7e4f139ed88107a53ecd50bc489#diff-b79606fb3afea5bd1609ed40b622142f1c98125abcfe89a76a661b0e8e343910 before this plugin reached v1.


Allow constructing Sh descriptors wrapping an existing Wsh/Wpkh

Useful if you already have an W{s,pk}h descriptor and wish to wrap it with P2SH.
This used to be possible before the new inner types for the Descriptor enum variants, which has private fields that cannot be initialized externally.

Actually, re-reading it. I have some complaints about the names :(.
This is not consistent with the other names in the API. We have names like Descriptor::new_wsh() instead of Descriptor::new_with_wsh. I would prefer to change to new_<name> from new_with_<name> without the with for consistency with other APIs.
We want to be more rust-idiomatic with names like Descriptor::with_wsh (instead of new_with_wsh (as suggested in this PR), or new_wsh as implemented in master). But that is another issue.

@sanket1729 Descriptor::new_sh_wsh(), Descriptor::new_sh_wpkh(), Sh::new_wsh() and Sh::new_wpkh() already exists though, with a different meaning (they accept the underlying Miniscript and wrap it with a W{s,pk}h descriptor, rather than accept the descriptor directly).


feature request

it would be nice to have image URL just like you have for video, add link or upload if needed

I think this will be not yet possible because its limited from ContentTools but i can look at it and maybe extend it.


docker-compose to docker compose

What this PR does / why we need it:
Change docker-compose to docker compose in the plugin ci.yml workflow.
Which issue(s) this PR fixes:

Fixes #1044

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

There are other instances of docker-compose. I wasn't sure whether to change them all or not.

@6nv Thanks so much for contributing but I'm sorry to write that we discovered this earlier today and it was fixed in this PR which has now been merged before checking for already open PRs. 😞
As such I'm afraid we're gonna have to go ahead and close the PR. My apologies again. We do appreciate your time and your contributions. This is on me and in the future I'll make sure to check for open PRs before doing anything else.

@jackw no problem. Glad it got fixed.


SELECT max (day) as max_day FROM statistics - not works

Hey. I can not execute a query like this:
SELECT max (day) as max_day FROM statistics
does not show anything at all!

Is there any update on this query failed error

If to write here so SELECT * FROM statistics
then everything works!

query with join is not working

This is not a join, it's an aggregation of max (day)

Yeah i know that but in my case join is not working


Change default signing algorithm to not use broken SHA-1 hashing algorithm

@pitbulk I just wanted to follow up on #269; using a hashing algorithm that's been broken in an authentication library isn't a reasonable default, even for backwards-compatibility.  The right thing to do is to do a release that changes the default (and document that the SHA-1 algorithms are deprecated).
See https://duo.com/decipher/sha-1-fully-and-practically-broken-by-new-collision and https://duo.com/decipher/openssh-will-deprecate-sha-1 for background -- SHA-1 is deprecated and should not be used.

Ok, I will implement such change on next release of python-saml / python3-saml and on rest of toolkits.
I will also implement the "reject unsecure algorithms" by default enable

Done


Feature :: formula step

Add a formula step to add a computed column:
{
   name: 'formula',
   new_column: 'new_col', // new_column can be an existing column to be updated with the formula result
   formula: '(column_1 + column_2) / column_3 - column_4 * 100'
}

Codecov Report

Merging #106 into master will decrease coverage by 0.39%.
The diff coverage is 81.25%.

@@            Coverage Diff            @@
##           master     #106     +/-   ##
=========================================
- Coverage   84.98%   84.59%   -0.4%
=========================================
  Files          11       11
  Lines         293      305     +12
  Branches       33       36      +3
=========================================
+ Hits          249      258      +9
- Misses         38       39      +1
- Partials        6        8      +2

Impacted Files
Coverage Δ

src/lib/pipeline.ts
94.59% <ø> (-0.28%)
:arrow_down:

src/lib/translators/base.ts
97.77% <100%> (ø)
:arrow_up:

src/lib/translators/mongo.ts
96.19% <80%> (-2.72%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5414aaa...b56e64e. Read the comment docs.

 ETQC, je suis capable de traduire une step formula


Bumps vulnerable dependencies elliptic, ws, and express

This PR resolves npm audit findings for elliptic, ws, and express.

I'm seeing increased incidence of ECONNREFUSED in the pipeline, which may be caused by https://github.com/webdriverio/webdriverio/issues/13553. Let's wait for that issue to be resolved and see if the problem goes away.

Apparently still not fixed: https://github.com/webdriverio/webdriverio/issues/13553#issuecomment-2370799598

@romainmenke Do you have any idea what's going on with the BrowserStack test failures? I see a mix of error messages in different steps. Do you think we should give up on the webdriverio upgrade, for now?

This seems problematic and something that should be configurable for our use case: https://github.com/webdriverio/webdriverio/blob/74346f930b035a475733748974dcec8893c08865/packages/webdriverio/src/index.ts#L86-L90
Webdriver should not be applying their own polyfills as that makes it impossible for us to test polyfills.
So I think we should reach out and try to resolve those issues.

I will try to do a run with those things manually disabled and check if tests start to pass.

Webdriver should not be applying their own polyfills as that makes it impossible for us to test polyfills.

It looks like we can skip polyfills by not using BiDi: https://github.com/webdriverio/webdriverio/blob/74346f930b035a475733748974dcec8893c08865/packages/webdriverio/src/polyfill.ts#L33
I will try that.

I am also opening an issue with WebDriverIO to see if they will use a safer polyfill.

Here's a PR against webdriverio to fix NAME_POLYFILL for old browsers: https://github.com/webdriverio/webdriverio/pull/13751.

@romainmenke This PR is ready to review.


New version: VPNetwork.TorGuard version 4.8.9-build.144.1+g3174a6b

[X] Have you signed the Contributor License Agreement?
[X] Have you checked that there aren't other open pull requests for the same manifest update/change?

[ ] Have you tested your manifest locally with winget install --manifest <path>?
[X] Does your manifest conform to the 1.0 schema?

Microsoft Reviewers: Open in CodeFlow

winget upgrade outputs this:
VPNetwork LLC - TorGuard -… VPNetwork.TorGuard           "4.8.9-build.144.1+g3174a6b" 4.8.9-build.144.1+g3174a6b winget
does the package version need to be changed to: '"4.8.9-build.144.1+g3174a6b"'? or does that cause even more problems with version comparison?

winget upgrade outputs this: VPNetwork LLC - TorGuard -… VPNetwork.TorGuard "4.8.9-build.144.1+g3174a6b" 4.8.9-build.144.1+g3174a6b winget
does the package version need to be changed to: '"4.8.9-build.144.1+g3174a6b"'? or does that cause even more problems with version comparison?

I see..
'"4.8.9-build.144.1+g3174a6b"' gives  String does not match the pattern of "^[^\\/:\*\?"<>\|\x01-\x1f]+$".


can i use in objective-c

Can I use in objective-c or consider have a objective-c demo? thx.

OK,I know. thx

If you fork and replace all the swift structs with classes it should work :)

If you fork and replace all the swift structs with classes it should work :)

I have done that in "Source" folder throughout, do I need a bridging header now?

Was anyone ever able to get this going with an ObjC project?

@EpicDraws I don't think so (yet). I could become compatible by switching swift struct to class.
The future proof way would be to migrate the Obj-C project to swift though 🙃

I created a swift bridge then a callback function to return the image in Objective-C
import Foundation
import UIKit
import YPImagePicker

@objc class ImagePicker: NSObject {

   @objc func pickImage(viewController:UIViewController, completion:(@escaping(_ result: UIImage)->())){

        var config = YPImagePickerConfiguration()

              config.screens = [.library, .photo]
              config.library.mediaType = .photo
              config.usesFrontCamera = true;

              let picker = YPImagePicker(configuration: config)
              picker.didFinishPicking { [unowned picker] items, _ in
                  if let photo = items.singlePhoto {
                      print(photo.fromCamera) // Image source (camera or library)
                      print(photo.image) // Final image selected by the user
                      print(photo.originalImage) // original image selected by the user, unfiltered

                    completion(photo.image);

                  }

                  picker.dismiss(animated: true, completion: nil)
              }
              viewController.present(picker, animated: true, completion: nil)
    }
}

@peakerWu , similar to @victors1681 , I wrapped it to expose it to Objective C with the settings I want for my app. Calling it from Objective-C becomes very simple.
import Foundation
import YPImagePicker
import UIKit

@objc class MyImagePicker: UIViewController {

    var selectedItems = [YPMediaItem]()
    var selectedPhotos = [UIImage]()

    var callback: ((_ img: UIImage?) -> Void)?
    var callbackWithArray: ((_ img: [UIImage]?) -> Void)?

    private func defaultConfig() -> YPImagePickerConfiguration {
        var config = YPImagePickerConfiguration()

        config.usesFrontCamera = false
        config.shouldSaveNewPicturesToAlbum = false
        config.startOnScreen = .library
        config.screens = [.library, .photo]
        config.showsPhotoFilters = false
        config.onlySquareImagesFromCamera = false
        config.showsPhotoFilters = false

        config.library.mediaType = .photo
        config.library.onlySquare = false
        config.library.isSquareByDefault = false

        return config
    }

    @objc public func pickImage(completion: @escaping (_ img: UIImage?) -> Void) {

        callback = completion;
        var config = defaultConfig()
        config.library.maxNumberOfItems = 1

        let picker = YPImagePicker(configuration: config)

        self.addChild(picker);
        self.view.addSubview(picker.view)
        picker.didMove(toParent: self);

        /* Single Photo implementation. */
        picker.didFinishPicking { [unowned picker] items, _ in
             self.selectedItems = items
             // var image = UIImage(ciImage: items.singlePhoto?.image)
            completion(items.singlePhoto?.image)
            picker.dismiss(animated: true, completion: nil)
        }
    }

    @objc public func pickImages(completion: @escaping (_ img: [UIImage]?) -> Void) {

        callbackWithArray = completion;
        var config = defaultConfig()
        config.library.maxNumberOfItems = 10

        let picker = YPImagePicker(configuration: config)

        self.addChild(picker);
        self.view.addSubview(picker.view)
        picker.didMove(toParent: self);

        picker.didFinishPicking { [unowned picker] items, cancelled in

            if cancelled {
                print("Picker was canceled")
                picker.dismiss(animated: true, completion: nil)
                return
            }

            self.selectedItems = items
            self.selectedPhotos.removeAll()

            for item in items {
                switch item {
                case .photo (let photo):
                    self.selectedPhotos.append(photo.image)
                case .video:
                    // no video supported yet
                    print("no video support at this time")
                }
            }

            self.callbackWithArray!(self.selectedPhotos)
            picker.dismiss(animated: true, completion: nil)
        }
    }
}

Then call it as follows from Objective C.
- (void)showMultiImagePicker {
    MyImagePicker *picker = [MyImagePicker new];
    picker.modalPresentationStyle = UIModalPresentationFullScreen; // for iOS 13

    [picker pickImagesWithCompletion:^(NSArray<UIImage *> * _Nullable images) {

        for (UIImage *image in images) {
            // ... do something here with image
        }
    }];

    [self presentViewController:picker animated:YES completion:nil];
}


ci: add python static analysis

Sets up GitHub Actions YML CI file to perform non-gating linting (w/ flake8)
and gating security scans (w/ bandit) of python scripts in opae-sdk.
Signed-off-by: Asgard Marroquin<EMAIL_ADDRESS>

Coverage remained the same at 82.285% when pulling cea465fcfdf667917972c0f59f266884953dc74e on asgardkm/python-static-analysis into b220c46b999786d8775226506e074c1142673f8c on master.


SubConnect - Review and test Subconnect

Describe the task
Review and test Subconnect
Link doc : https://www.notion.so/subwallet/Other-notes-5968b0d4f34349f8963167001315214a
Link design : https://www.figma.com/file/2nYhrm0rlJtfJoMwrT51Ep/SubWallet-Apps?type=design&node-id=4833-129911&mode=dev
To reproduce the bug

[x] Update connect with Ledger : Ledger EVM and Ledger Live

[x] Remove this modal

[x] Disable Select network type when connect with Ledger

[x] Navigate to link in tab when click hyperlink I don't have a wallet
Expect : Navigate to link on new tab

[x] Logo is small

[x] UI bugs on Firefox

[x] When connect WalletConnect, change to "w3o-demo.subwallet.app" on Signature request screen, WalletConnect screen

[x] Don't display account name and show scroll bar on Select account screen
Expect : Display Account name

[x] Remove scroll bar

[x] Can not navigate to link when click SubWallet (Substrate), Talisman, Polkadot{.js} on Brave and Cốc cốc

[x] Add popup Disconnect wallet when click Disconnect

Expect : https://www.figma.com/file/2nYhrm0rlJtfJoMwrT51Ep/SubWallet-Apps?type=design&node-id=17097-212101&mode=design&t=8rR2UE7FtC9cA8EK-0

[x] Can not change account

[x] When click button Sign Dummy in WalletConnect, showing no support on the wallet

[x] Message popup displays for a long time

[x] Connection successful screen closes slowly
Expect : Connection successful screen closes quickly

[x] Displays incorrect text when connecting successfully

[x]  Improve scroll
Expect : When scroll, the top of the layout must remain the same

Version test : https://w3o-demo.subwallet.app/

[ ] Update logo according to design

[ ] Update Scan QR code screen

[ ] For quick popup display time

[ ] Error popup automatically appears

[ ] Error of not being able to change network when connecting with Ledger EVM

[ ] UI bug

[ ] When connecting WallConnect EVM, can not Transfer

Improve responsive

Chrome

[ ] Must be separated from the margin

[ ] Title is wrong

[ ] Error display Scan QRcode screen

Firefox

[ ] Remove scroll bar, title is wrong, must be separated from the margin


Rewrite/Cleanup of alarm_config and json_ipc

Remove json_ipc since it isn't used anywhere.  Rerwrite alarm_config to simplify what history information is being tracked.

json_ipc removed


add note on overriding "Update When Offscreen" with an animation

Tested on latest SDK, reproducibly fixes a culling issue I had. Note that I ran the animation in a loop every frame, not just once - not sure if it matters.

Thanks


Combine similar converter tests + lint test files

Every directory in src/test/converter is a separate test. Even for trivial tests like the variable test that only have 3 lines, we have to re-start the TypeScript compilation, so these tests take at least a couple seconds. Quite a few of these tests could be combined. I think we should be able to get the test running time down to under a minute, I'd really like to get it down to 30 seconds or less, but I'm not sure if that's possible without sacrificing test organization.
Further, most of the test files currently do not pass TSLint rules, when rebuilding the tests, this should be fixed to avoid IDE warnings.

Resolved by 1fd2185e2148bd319a094cfaa25c636533e8c4bf


supprt for Llama3-8b

Hi，thanks for your great job
I have tried to follow your job in Llama3-8B
It is smooth in step "Calibration Dataset Generation"
As for the step "Profile"
It is OK for 2k and 4k, but for the 8k case, it rasied the error
"Total number of data samples: 0
Collecting Grad: 0it [00:00, ?it/s]
Traceback (most recent call last):
File "MoA/scripts/pipeline/pipeline_profile.py", line 244, in
grad_W_dict, grad_Attn_tensor = Grad_Collect(model, tokenizer, args, dataset, args.max_length, user_prefix=user_prefix, assistant_prefix=assistant_prefix)
File "MoA/scripts/pipeline/pipeline_profile.py", line 170, in Grad_Collect
grad_Attn_tensor = torch.sum(model.model.attention_matrix_log[key][0], dim=0) / num_data
IndexError: list index out of range
"
Do you have any suggestions ?
And could you change the gurobi to other opensource lib?

Hi @shiyuetianqiang , thank you for your interest in our work. The problem seems to be the empty dataset passed to Grad_Collect: Total number of data samples: 0. Can you check why the dataset is empty?
If it is not empty before filtering (suggesting successful Calibration Dataset Generation), I think the main problem may come from tokenization: Llama3 tokenizer is more efficient than Llama2. Yet, the lengths of our data items on HuggingFace are calculated with Llama2 tokenizer. As a result, the data items do not reach 7-8k as expected by "Profile".
To fix this, we provide two optional solutions:

We add a re-calculation of lengths in "Calibration Dataset Generation" based on the current tokenizer. Please check our latest commit. Rerun "Calibration Dataset Generation" to see if the longest length reaches 8k
Set a smaller "--max_length" (e.g., 6k) or larger "--total_length_level_down" during "Profile"

Please let us know if the problem still exists. Welcome to open PRs if you come up with better solutions.

As for gurobi, you can apply free academic license for in class or research uses here

As for gurobi, you can apply free academic license for in class or research uses here

Thanks，for gurobi， we have applied a 30-day trail license

Hi @shiyuetianqiang , thank you for your interest in our work. The problem seems to be the empty dataset passed to Grad_Collect: Total number of data samples: 0. Can you check why the dataset is empty? If it is not empty before filtering (suggesting successful Calibration Dataset Generation), I think the main problem may come from tokenization: Llama3 tokenizer is more efficient than Llama2. Yet, the lengths of our data items on HuggingFace are calculated with Llama2 tokenizer. As a result, the data items do not reach 7-8k as expected by "Profile".
To fix this, we provide two optional solutions:

We add a re-calculation of lengths in "Calibration Dataset Generation" based on the current tokenizer. Please check our latest commit. Rerun "Calibration Dataset Generation" to see if the longest length reaches 8k
Set a smaller "--max_length" (e.g., 6k) or larger "--total_length_level_down" during "Profile"

Please let us know if the problem still exists. Welcome to open PRs if you come up with better solutions.

Yes, you r right,
When come back to the step of "Calibration Dataset Generation" by Llama3 tokenizer， the max sequence length is no no longer than 8k.
Follow your suggestion, we set a smaller "--max_length"


ARROW-10461: [Rust] Fix offset bug in remainder bits

@jorgecarleitao @nevi-me Can you take a look at this bugfix?

@jhorstmann , bit operations is one of my weaknesses; I can't review this due to my lack of knowledge on that topic.

FYI @jorgecarleitao  / @nevi-me  I think we should merge this PR.

@nevi-me @alamb @jorgecarleitao I had a quick chat with @vertexclique and we think we can merge this PR with the bugfix first and then rebase and integrate his refactoring. Those PRs shouldn't block each other.

I agree @jhorstmann  -- I think we should merge this. I don't yet have the permissions set up to merge things, so I need to wait for one of the other committer such as @andygrove , @nevi-me  or @jorgecarleitao  to do so

@jhorstmann thanks a lot for this fix!
@alamb, congrats on your push!!!!! 🎉 🎉 🎉 🎉 🎉


Project not listed in search results or preceded by non-maintened projects

I am not sure if it is possible to fix or is a request that is processable. I did search issues and PRs for similar requests but could not find any. So if this is an issue that is out of scope then we (the maintainers of some projects) know it is what it is.
Describe the bug
Project Bootstrap-Flask (also without hyphen but with a sapce) is not listed in search restults or is preceded by non-maintened projects.
Expected behavior
Search for Bootstrap-Flask or Bootstrap Flask and view all the result orderings.
To Reproduce
See these screenshots:

My Platform
n/a
Additional context
n/a

Yes, duplicate.


testing please ignore

Motivation

Test plan

See included automated tests.

We have a policy of testing changes to Sorbet against Stripe's codebase before
merging them. I've kicked off a test run for the current PR.  When the build
finishes, I'll share with you whether or how it failed. Thanks!
Stripe employees can see the build results here:
→ https://go/builds/bui_L3BaJSEcPlgYjJ
→ https://go/builds/bui_L3BaRLMBY3kUBu


[#5470] Add realtime mode in the inspector page

Codecov Report

Merging #5508 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master   #5508   +/-   ##
======================================
  Coverage    40.8%   40.8%
======================================
  Files        2820    2820
  Lines       84799   84799
  Branches    11298   11298
======================================
  Hits        34603   34603
  Misses      47174   47174
  Partials     3022    3022

Impacted Files
Coverage Δ

...vercorp/pinpoint/rpc/packet/ClientClosePacket.java
55.55% <0%> (-11.12%)
:arrow_down:

...rc/main/java/com/navercorp/pinpoint/test/Item.java
70% <0%> (-3.34%)
:arrow_down:

...orp/pinpoint/rpc/server/DefaultPinpointServer.java
79.92% <0%> (-0.36%)
:arrow_down:

...r/response/DefaultResponseTimeMetricCollector.java
100% <0%> (+14.28%)
:arrow_up:

...p/pinpoint/rpc/client/WriteFailFutureListener.java
75% <0%> (+18.75%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 05f81d5...ad06011. Read the comment docs.


I see a weird error when not using Html.Events

The error I see:

elm-hot-loader is incompatible with this version of Elm.

My environment:
$ npm ls --depth 0 | grep elm
├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>
Example code (App.elm)
module App exposing (..)

import Html exposing (..)

main =
    Html.program
        { init = initialState
        , update = update
        , subscriptions = (always Sub.none)
        , view = view
        }

type alias Model =
    Int

type Msg
    = X

initialState : ( Model, Cmd Msg )
initialState =
    ( 3, Cmd.none )

update : msg -> Model -> ( Model, Cmd Msg )
update msg model =
    ( model, Cmd.none )

view : Model -> Html Msg
view model =
    span [] [ text "Hello world!" ]

With this code, webpack will fail with the error message pasted above.
Now, if I add this line...
import Html.Events

...the loader stops complaining and everything works.

Thanks, it's fixed now

I have a similar issue.  Said error message appears for when as soon as I add import List.Extra to a module, with latest webpack, elm-loader and elm-hot-loader.


test,unix: fix logic error in test runner

Fix the logic that guards against the system clock jumping back in time.
Fixes: https://github.com/libuv/libuv/issues/667
R=@saghul
CI: https://ci.nodejs.org/job/libuv+any-pr+multi/224/

LGTM


PDFs damaged when downloading with script

When I download the pdf documents with the script, all of them are damaged and can't be opened. Is there anyone else facing this issue or is it only me?

Please provide more information, in this form this cannot be debugged.

What operating system are you on?
Which Python version are you using?
Do the PDFs work when downloaded from the UI directly?
What version of the script are you using (commit hash)

MacOS Ventura 13.2 (22D49)
Python 3.11.1
YES
Current main branch (checked out yesterday)

@kaulex99 would you mind mailing me one of the corrupted PDFs?

@mitsuhiko No, I will send you a general one via email.

I looked at the PDF and it's not a PDF, but a HTML error page ("Blocked"). It's because flatex blocked the script again. Needs investigation.

Maybe some error handling in the script would be great, just to not download all the pdfs if they are broken. Because the script output looks like if nothing went wrong in general.

FYI: having the same problem.
I'm using Ubuntu 22 (in WSL 2), Python 3.10.6 using current main branch. I'm using the SESSIONID param if that makes any difference.

Happy to accept PRs. Sadly I don't have much time to deal with this myself.

maybe #8 solves this issue

i just checked out the PR locally and it worked for me (using session-id and flatex.at). thank you 👍

@mitsuhiko can you please merge :D

Merged. Thank you.


Flux support in Kubernetes 1.6?

On Kubernetes 1.6, everything looks to deploy correctly, but I'm unable to view the images. Is this a known issue or something with my configuration?
$ fluxctl list-images --service=sock-shop/front-end
SERVICE  CONTAINER  IMAGE  CREATED

$ fluxctl release --service=sock-shop/front-end --update-all-images
Submitting release job...
Release job submitted, ID 607101aa-4ed4-7ca5-6b0c-10340bf0848e
Status: Complete.

Here's what happened:
SERVICE   STATUS   UPDATES
Took 16.119216s

Thanks for the report! Looking into it now.

@BenHall a few questions:

Which version of flux are you using?
Are you running it standalone or with Weave Cloud?
Thanks!

This is related to Weave Cloud, using the latest release.
I applied a RBAC fix from the Cortex issue (https://github.com/weaveworks/cortex/issues/392#issuecomment-292713631). This allowed images to be viewed via list-images but rolling out changes would indicate 0 services required updating. This happened via the CLI and the web UI.

Hrm, I could not replicate the '0 services required updating' issue - instead I get this:
$ fluxctl-0.2.0 --token=<REDACTED> list-images --service=sock-shop/front-end
SERVICE              CONTAINER  IMAGE                                      CREATED
sock-shop/front-end  front-end  index.docker.io/weaveworksdemos/front-end
                                |   master-ac9ca707                        07 Apr 17 13:06 UTC
                                |   master-3fad5eda                        30 Mar 17 08:51 UTC
                                |   master-bdc6f3ff                        29 Mar 17 10:45 UTC
                                '-> 0.3.12                                 21 Mar 17 11:32 UTC
                                    latest                                 21 Mar 17 11:32 UTC
                                    master-b2308a3e                        21 Mar 17 11:24 UTC
                                    0.3.11                                 20 Mar 17 12:13 UTC
                                    master-fe7f9828                        17 Mar 17 14:24 UTC
                                    0.3.10                                 16 Mar 17 13:31 UTC
                                    master-30f06738                        16 Mar 17 13:30 UTC
$ fluxctl-0.2.0 --token=<REDACTED> release --service=sock-shop/front-end --update-all-images
Submitting release job...
Release job submitted, ID f7636083-65ff-3b4c-4b0c-958ce1eb1778
Status: Failed: sock-shop/front-end: applying definition to sock-shop/front-end: running kubectl: error: group map[federation:0xc8203caf50 :0xc8203cafc0 apps:0xc8203cb030 autoscaling:0xc8203cb110 componentconfig:0xc8203cb1f0 policy:0xc8203cb2d0 rbac.authorization.k8s.io:0xc8203cb340 authorization.k8s.io:0xc8203cb0a0 batch:0xc8203cb180 extensions:0xc8203cb260 authentication.k8s.io:0xc8203cb420] is already registered

Here's as far as we got:
 1) Queued.
 2) Calculating updates for release.
 3) Cloning git repository.
 4) Finding defined services.
 5) Found service sock-shop/front-end
 6) Found 1 services.
 7) Looking up images.
 8) Will update sock-shop/front-end container front-end: weaveworksdemos/front-end:0.3.12 -> master-ac9ca707
 9) Pushing changes.
 10) Applying changes.
 11) Sending notifications.
 12) Failed: sock-shop/front-end: applying definition to sock-shop/front-end: running kubectl: error: group map[federation:0xc8203caf50 :0xc8203cafc0 apps:0xc8203cb030 autoscaling:0xc8203cb110 componentconfig:0xc8203cb1f0 policy:0xc8203cb2d0 rbac.authorization.k8s.io:0xc8203cb340 authorization.k8s.io:0xc8203cb0a0 batch:0xc8203cb180 extensions:0xc8203cb260 authentication.k8s.io:0xc8203cb420] is already registered

Took 19.718682s
== Error ==

Internal error: sock-shop/front-end: applying definition to sock-shop/front-end: running kubectl: error: group map[federation:0xc8203caf50 :0xc8203cafc0 apps:0xc8203cb030 autoscaling:0xc8203cb110 componentconfig:0xc8203cb1f0 policy:0xc8203cb2d0 rbac.authorization.k8s.io:0xc8203cb340 authorization.k8s.io:0xc8203cb0a0 batch:0xc8203cb180 extensions:0xc8203cb260 authentication.k8s.io:0xc8203cb420] is already registered

We don't have a specific help message for the error above.

It would help us remedy this if you log an issue at

    https://github.com/weaveworks/flux/issues

saying what you were doing when you saw this, and quoting the message
at the top.

This is with flux 0.2.0 installed on a 1.6.0 k8s cluster via the launch generator:
kubectl apply -f 'https://cloud.weave.works/k8s/flux.yaml?service-token=<REDACTED>'

which includes the required service account.
ISTM that the 'group already registered' error is due to an incompatibility with the kubectl shipped inside fluxd (v1.3.5) - I'm about to open a PR that updates that, and with which I have successfully released sock-shop/front-end to a 1.6 cluster...

The service 0 was from the Flux / Weave Cloud UI
Release via fluxctl 0.2.0
root@master:~/weave-front-end# fluxctl release --service=sock-shop/front-end --update-all-images
Submitting release job...
Release job submitted, ID 15dc7bd0-2ea5-2c2f-9621-2cf1192c33a7
Status: Complete.

Here's what happened:
SERVICE   STATUS   UPDATES
Took 18.771451s
root@master:~/weave-front-end# fluxctl list-images --service=sock-shop/front-end
SERVICE              CONTAINER  IMAGE                                                             CREA
TED
sock-shop/front-end  front-end<PHONE_NUMBER>-4567-kitek01.environments.katacoda.com/root/front-end
                                |   1d8e9cd73cc781c91aa4fcbc87afda2a464da343                      10 A
pr 17 16:50 UTC
                                '-> latest                                                        28 O
ct 16 20:22 UTC
root@master:~/weave-front-end#

## Release via Weave Cloud
 Dry Run: Calculating plan to release sock-shop/front-end
Release job submitted, ID 855b5454-0df1-abdd-f381-9c10287f4b2b
Status: Complete.

1) Queued.
2) Calculating updates for release.
3) Cloning git repository.
4) Finding defined services.
5) Found 0 services.
6) Looking up images.
7) No updates to do, finishing.
Success

Sorry, didn't mean to close this yet - you clearly have some other issue as well (although you would hit the k8s 1.6 problem once we get past whatever it is)

@BenHall can you paste the result of running kubectl --namespace sock-shop get all -o wide against that cluster?  Is the config repository public?

It's part of Katacoda so it's only short lived. It is public at the time. Why do you ask? To reproduce?

To reproduce?

Yes. The set of services listed by list-images is the one obtained from k8s, whereas the services used by release are further filtered by what's defined in the config repo. Since the former is successfully finding sock-shop/front-end and it is missing from the latter ('Found 0 services.'), the finger points at the config repo...
I gather from the subject of your issue that you think the problem is caused by k8s 1.6 - is there a way to check that this doesn't also happen with earlier versions?

The current Katacoda (https://www.weave.works/docs/tutorials/core/interactive/part-2-deploy-continuous-delivery/) is using v1.5 and works as expected.
The same repository with a Kubernetes v1.6 cluster fails
fluxctl release --service=sock-shop/front-end --update-all-images
Submitting release job...
Release job submitted, ID 97e450be-09e3-cfba-081a-1b84c57a0b08
Status: Complete.

Here's what happened:
SERVICE              STATUS   UPDATES
sock-shop/front-end  skipped  not found in repository
Took 10.98256s

A copy of the microservices-demo repo we use can be found at http://assets.joinscrapbook.com/weavecloud/weave-micro-0604.tar.
Would the fact that I'm using :latest be causing an issue? I noticed the image Kubernetes returns is<PHONE_NUMBER>-4567-kitek01.environments.katacoda.com/root/front-end

Flux 0.* is no longer supported. Please file a new issue if you are having difficulties with Flux 1.*, Ben.


Pat.Ctor#toExpr didn't insert arguments for ownerTele.

Minimum code:
open data Single (A : Type) | single {A}
def justMatch {A : Type} (s : Single A) : Single A
  | single => s

 Aya said
In file main.aya:3:4 ->

  1 | open data Single (A : Type) | single {A}
  2 | def justMatch {A : Type} (s : Single A) : Single A
  3 |   | single => s
          ^----^

Error: Cannot check the expression
         _5
       of type
         A
       against the type
         Type 0

at (96-101) [3,4-3,9]

The clause | single => s is expanded to | {A}, single {_5} => s {_5} which is incorrect.

Thanks!!! I expected this bug, but I didn't come up with a counterexample. Apparently you are better than me lmao


Update notification doesn't include package name and version [Bug]

Sailfish OS VERSION: <IP_ADDRESS> and earlier
HARDWARE: Sony Xperia XA2
SailfishOS:Chum GUI application VERSION: 0.6.8-1 and earlier

BUG DESCRIPTION
According to the locale string %1 %2 updated, %1 is supposed to act as a placeholder for the package name and %2 as a placeholder for the package version, that get displayed in a notification popup after a successful package update. However, package name and version never get displayed on my end, and have never done so (at least to my recollection) in the past either, it only displays "updated", or in my German case "aktualisiert" (which was the original thing that made me pay attention, since if indeed intended as a single word, it should be spelled with a capital "A" in that scenario). The notifications after Install or Remove operations however do include package name and version, as intended.
STEPS TO REPRODUCE
If there's at least one update for a package available (unfortunately not that easy to re-create on demand..), execute it from the pulley menu and observe the notification pop-up banner after it is done.
ADDITIONAL INFORMATION
As mentioned in #167:
Affected strings in source TS file:
https://github.com/sailfishos-chum/sailfishos-chum-gui/blob/main/translations/sailfishos-chum-gui.ts#L39-L56
Corresponding code:
https://github.com/sailfishos-chum/sailfishos-chum-gui/blob/main/qml/sailfishos-chum-gui.qml#L13-L30
[Please consider which other pieces of information may be relevant: Denote if this is not always reproducible, if this is a regression (then name to which older version), attach relevant data such as log files or the systemd journal, provide screenshots etc.]

Thank you very much @spodermenpls for this excellent bug report.  I will take a look at it, when I find some time for SailfishOS-related things (but not the next couple of days, unfortunately).

Now that rinigus pushed updates for OSM Scout Server (and Pure Maps), I was able to make two screenshots of the phenomenon I was describing above:

Oops, I intended to do the same, what you did now: Look at it when update candidates are there rsp. when updating them.  Unfortunately I forgot, hence thank you for reminding me of this issue.
I now tried to understand the code location, for which you nicely provided a link in the OP.  Now I wonder, too: Why is not the usual scheme for emitting notifications used (as e.g. here), and where is the corresponding qtTrId(), which ultimately outputs these strings (as in the Qt documentation example) etc.?  But as I avoid writing JavaScript code as much as I can, I have very little knowledge and experience with QML and JavaScript.
@piggz, as you authored this, can you please take a look at this issue.

@piggz, sorry to have stubbornly assigned this issue to you, as I suppose this still is an less-annoying way to get your attention (and within the functionality of GH's web-frontend) than writing a PM.
It can be re- or un-assigned if you wish.

I must say it is a low priority right now for me and I suspect the same is for @piggz. I am personally swamped with another SFOS project and would prefer to focus on that. @piggz is busy with Qt6 and probably few other projects. So, unless someone steps in, it would have to wait.


Added make:subscriber Artisan Command

Usage examples:
php artisan make:subscriber AuthEventsSubscriber
php artisan make:subscriber AuthEventsSubscriber --event="Illuminate\\Auth\\Events\\Login"

No plans to add this right now.

@taylorotwell Any plans for this feature?


Add char validator to text inputs

https://trello.com/c/xfyBplpT/261-content-screen-tweak-error-verbiage-when-over-character-count
This adds a charValidator to the Input component.

We added 3 props to the input:

withCharValidator (a clause so that we can block from default input)
charValidatorShowAt (determines when the charValidator becomes visible)
charValidatorLimit (how many chars are allowed in the input)

cc: @digitaldesigner

Only feedback would be to make the pill go red when it reaches the limit, such as "100/100" in your example, not above.
Also is it possible to animate (fade) in/out the pill?

Pull Request Test Coverage Report for Build 2391

16 of 16 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build 2379:
0.0%

Covered Lines:
12308

Relevant Lines:
12308

💛  - Coveralls

@buzz, updated with animation:

 Content Screen: Tweak error verbiage when over character count

 Content Screen: Tweak error verbiage when over character count

Love it, ship it

@buzz, updated with animation:

Please stop to mention my username.
Thank you

Haha this is awesome, but also probably a security/privacy issue... sorry (other) Buzz!


Allow user to mark a project preferences as hidden

Related to talk discussion - https://www.zooniverse.org/talk/14/1005060
Users want to better curate their recent projects and stats banner UI components to only ignore certain projects. Adding a ignore or hidden attribute to the project preferences can be used by the API clients to filter out these projects.

partially closed by #3583 - needs some UI component work in https://github.com/zooniverse/panoptes-front-end to allow the user to update this attribute

closing this as it's supported by the API right now.


Boot genesis block helper

Before this change, if you wanted to use a new Transaction
feature in the genesis block, you'd need to extend its
Creator object and associated methods.  With yesterday's
addtions to Transcation, it's now so easy to work with
Transactions directly that we can get rid of the middleman.
Also added a KeyPair type alias, so that ring could be easily swapped
out with a competing library, if needed.

Codecov Report

Merging #54 into master will increase coverage by 0.24%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master      #54      +/-   ##
==========================================
+ Coverage   94.31%   94.56%   +0.24%
==========================================
  Files          13       13
  Lines         616      589      -27
==========================================
- Hits          581      557      -24
+ Misses         35       32       -3

Impacted Files
Coverage Δ

src/signature.rs
100% <100%> (ø)
:arrow_up:

src/accountant.rs
94.49% <100%> (-0.92%)
:arrow_down:

src/transaction.rs
98.63% <100%> (ø)
:arrow_up:

src/genesis.rs
90% <100%> (+2.12%)
:arrow_up:

src/accountant_stub.rs
89.41% <100%> (-0.13%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 54340ed...9834c25. Read the comment docs.