WebBuildTools install not being committed to image?

Hi all,
I am facing a very strange issue while attempting to add WebBuildTools to a dotnetframework:4.7.2-sdk image. My Dockerfile is as follows:
# escape=`
FROM microsoft/dotnet-framework:4.7.2-sdk

RUN Invoke-WebRequest -UseBasicParsing https://download.visualstudio.microsoft.com/download/pr/12210059/e64d79b40219aea618ce2fe10ebd5f0d/vs_BuildTools.exe -OutFile vs_BuildTools.exe; `
    # Installer won't detect DOTNET_SKIP_FIRST_TIME_EXPERIENCE if ENV is used, must use setx /M
    setx /M DOTNET_SKIP_FIRST_TIME_EXPERIENCE 1; `
    Start-Process vs_BuildTools.exe -ArgumentList '--add', 'Microsoft.VisualStudio.Workload.WebBuildTools', '--quiet', '--norestart', '--nocache' -NoNewWindow -Wait; `
    Remove-Item -Force vs_buildtools.exe; `
    Remove-Item -Force -Recurse \"${Env:ProgramFiles(x86)}\Microsoft Visual Studio\Installer\"; `
    Remove-Item -Force -Recurse ${Env:TEMP}\*; `
    Remove-Item -Force -Recurse \"${Env:ProgramData}\Package Cache\"
RUN Get-ChildItem -Directory \"${Env:ProgramFiles(x86)}\Microsoft Visual Studio\2017\BuildTools\MSBuild\Microsoft\VisualStudio\v15.0\"
CMD powershell

When I build it, the output of the Get-ChildItem is as follows:
$ docker build -t rsaus/dotnet-webbuildtools -f .\Dockerfile.dockerfile .

Directory: C:\Program Files (x86)\Microsoft Visual
    Studio\2017\BuildTools\MSBuild\Microsoft\VisualStudio\v15.0

Mode                LastWriteTime         Length Name
----                -------------         ------ ----
d-----        5/23/2018  12:55 PM                Python Tools

Now, I manually start a container using the above built image and execute the above installation manually:
> docker run -ti rsaus/dotnet-webbuildtools powershell

PS C:\> Invoke-WebRequest -UseBasicParsing https://download.visualstudio.microsoft.com/download/pr/12210059/e64d79b40219aea618ce2fe10ebd5f0d/vs_BuildTools.exe -OutFile vs_BuildTools.exe
PS C:\> setx /M DOTNET_SKIP_FIRST_TIME_EXPERIENCE 1

SUCCESS: Specified value was saved.

PS C:\> Start-Process vs_BuildTools.exe -ArgumentList '--add', 'Microsoft.VisualStudio.Workload.WebBuildTools', '--quiet', '--norestart', '--nocache' -NoNewWindow -Wait

PS C:\> Get-ChildItem -Directory \"${Env:ProgramFiles(x86)}\Microsoft Visual Studio\2017\BuildTools\MSBuild\Microsoft\VisualStudio\v15.0\"

 Directory: C:\Program Files (x86)\Microsoft Visual Studio\2017\BuildTools\MSBuild\Microsoft\VisualStudio\v15.0

Mode                LastWriteTime         Length Name
----                -------------         ------ ----
d-----        5/23/2018  12:55 PM                Python Tools
d-----        5/23/2018   1:00 PM                Web
d-----        5/23/2018   1:00 PM                WebApplications

And, I can see that the web build tools have been installed.
I have tried pretty much everything I can think of (introducing sleep after the install, for example), but I can't figure out what is going on here.  Any ideas at all as to what I can try?
Thanks in advance.

@amitsaha, Do the latest sdk images eliminate your need for this?  With #89, the web targets and tasks were added which should allow you to build aspnet projects.

Do the latest sdk images eliminate your need for this? With #89, the web targets and tasks were added which should allow you to build aspnet projects.

@MichaelSimons thanks a lot - yes indeed it fixes my issue.
Still not sure what's happening with my Dockerfile or the one you pasted - it has the same earlier problem - but that's not required any more 👍


Small conversion

This PR contains a small conversion from js to ts. The rich-node-tree-modification.ts contained some initializations with missing arguments, but I didn't know what they should be. So maybe we can't merge this.

while useful, I'll close without merging here, since its not a critical change


TimeSeriesLabels:  fillColor, strokeWidth, and opacity not working

The attributes fillColor, strokeWidth, opacity, and maybe others are not working for TimeSeriesLabels:
To Reproduce
Steps to reproduce  the behavior, create a Labelling Config with this Code
<View>
<TimeSeriesLabels name="labelTS" toName="TS" opacity="0.01" strokeWidth="10">
<Label value="Region of Interest"/>
</TimeSeriesLabels>
<TimeSeries name="TS" value="$csv" valueType="url">
<Channel column="column A"/>
</TimeSeries>
</View>
Expected behavior
Setting these attributes should have an effect on the appearance of the labels
Environment

Label Studio Cloud, Label Studio Version 2.4.8dev-6
Label Studio Playground

Additional context
Similar to #1745

Hi! Good point, thanks, we have to update doc. These params are really not working, and apparently no one used it.
You can use rgba() for labels colors, but there is already hard-coded fill-opacity there. But you can use hacky styles to fix appearance of time series regions:
<Style>
rect.selection {
    fill-opacity: 0.8;
    stroke-width: 4;
    stroke-opacity: 1;
}

And to apply styles only to selected region you can use even more hacky rect.selection[fill-opacity="0.6"]


More granular RBAC permissions needed for documentation

Is your feature request related to a problem?/Why is this needed
Have now worked with 2 enterprise customers that have expressed concerns about requiring a Service Principal with Contributor permissions on a specific Resource Group. This is viewed as too broad of a set of permissions, and they are unsure which endpoints/services are even necessary for integrating Kubernetes within their Azure subscription.
Describe the solution you'd like in detail
Enhanced documentation to list all Azure endpoints, services, and permissions  that are used by the Cloud Provider for various features
Describe alternatives you've considered
Using Managed Identity instead of a Service Principal would render this moot. However, with the SP being older and more well-known by corporate security teams, MI is an uphill battle to get new approval processes in-place.
Additional context
Feedback is that the cloud integration "feels like a black box" and short of reverse engineering the code it is difficult
I would be happy to help do the writeups if I could get a hand with the necessary data points.
Thanks!

@stevenfollis Both MSI and SPN are supported. I'm working on the permission docs.

Thanks @feiskyer! Appreciate you capturing this information in a doc.


Update ConvertToEntity.cs

Fix if statement and destroy components on gameobjects cause if not TryGetEntity will return "dead"\non-existent entities

@Sod3n
Thanks for the PR! There is a potential problem with this - then gameObject.TryGetEntity, which works on the principle of “find the parent ConvertToEntity and take the converted entity through it,” will not work. Do you think there is any other way to solve this problem? Or should TryGetEntity be implemented differently?

Thanks for the PR!

Sorry for Breaking Changes before version 2.0.0 :)

I merged it, but github considered that there were conflicts. Changes can be found in the master branch.


Clarify argument to register-python-argcomplete

Fixes #165

Current coverage is 88.10% (diff: 100%)

Merging #190 into master will not change coverage

@@             master       #190   diff @@
==========================================
  Files             4          4
  Lines           597        597
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
  Hits            526        526
  Misses           71         71
  Partials          0          0

Powered by Codecov. Last update 33eaa94...6054f61


Unidentified icons

Can not find out what those Icons should be, and why they are not displayed. Please look at the provided Screenshot.
Is there a way to exclude them?
environment

vim: NVIM v0.5.0-dev+974-gf2be59d8f
vim-airline: Current
OS: macOS Big Sur
Have you reproduced with a minimal vimrc:  Yes
What is your airline configuration:

let g:airline#extensions#ale#enabled = 1
let g:airline_powerline_fonts = 1

if you are using terminal:

terminal: iTerm2
$TERM variable: xterm-256color
color configuration (:set t_Co?):
bluewery-light
if you are using Neovim:
does it happen in Vim: No VIM installed

actual behavior

expected behavior
I am not sure if there should be some icon or not. I am also fine with no Icons.
screen shot (if possible)
See actual behaviour

Some symbols cannot be displayed correctly. This is likely a font or terminal issue.

Am 30.12.2020 um 20:12 schrieb Patrick Haller<EMAIL_ADDRESS>
Can not find out what those Icons should be, and why they are not displayed. Please look at the provided Screenshot.
Is there a way to exclude them?
environment
vim: NVIM v0.5.0-dev+974-gf2be59d8f
vim-airline: Current
OS: macOS Big Sur
Have you reproduced with a minimal vimrc: Yes
What is your airline configuration:
let g:airline#extensions#ale#enabled = 1
let g:airline_powerline_fonts = 1
if you are using terminal:
terminal: iTerm2
$TERM variable: xterm-256color
color configuration (:set t_Co?):
bluewery-light
if you are using Neovim:
does it happen in Vim: No VIM installed
actual behavior
expected behavior
I am not sure if there should be some icon or not. I am also fine with no Icons.
screen shot (if possible)
See actual behaviour
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

I don't think this is a vim-airline problem. It is out of our scope.

I don't think this is a vim-airline problem. It is out of our scope.


updating patch server after running the patchstarter script

Ability to send new definition directly to on prem patch server or the community patch server

@danengh could you provide some more detail for what you're asking?

Add a switch that will automatically post the patch or definition to a specified server.
--post
if  left blank, server could be hardcoded into a plist file for retreival


flapping IDNs in autopull PRs

The issue where the nightly autopull PRs show flapping ascii <-> IDN domains is back:
Here's PR #628:

Here's #627:

It happened again in #630 yesterday.

Closing this, it hasn't been an issue.


Date.UTC() doesn't interpret two-digit years correctly

According to the ES5.1 and ES2015 spec, Date.UTC(year, month, ...) should add 1900 to year when 0 ≤ year ≤ 99, but Jurassic (tested with commit https://github.com/paulbartrum/jurassic/commit/a22ef7ca7c47f156282f19d2c1180f8a3701ab6a) currently interprets it as full year (whereas for the new Date(...) constructor, the behavior is correct).
Expected behavior:
console.log(Date.UTC(70, 0)); // Should print "0"

Actual behavior:
console.log(Date.UTC(70, 0)); // Prints "-59958144000000"

Thanks!

Thanks for the bug report :-)


Find architecture diagram

https://github.com/jetstack/tarmak/blob/master/docs/introduction.rst#architecture-overview
I think you @mattbates created some diagrams for the puppetconf talk not too sure if you still are able to find those.
I am thinking about the wing arch and also the puppet roles

If this isn't the diagram you're referring to, I'm slowly putting an architecture diagram together to help me familiarise myself with Tarmak anyway, so you could assign this issue to me

That's the diagram I'd been looking for when I asked you whether Tarmak runs the kubelet alongside the API server.

I think it should be included into https://docs.tarmak.io/introduction.html#architecture-overview with some description about how we use wing to run puppet.

/assign @alljames

Issue would be closed with #655


Change tag to use Google Analytics 4

Thank you for contributing to the CF CLI Plugin Repository!
This repo contains both the plugin repo server and the metadata for CLI
community plugins.
Some of the requirements for PRs will apply to only one of these parts.
We're not allowed to accept any PRs without a signed CLA, no matter how small.
If your contribution falls under a company CLA but your membership is not public, expect delays while we confirm.
Submitting Plugins
If you haven't yet, please review our contributing guidelines:
https://github.com/cloudfoundry/cli-plugin-repo#submitting-plugins
In particular ensure the following requirements are being met:

[ ] The plugin's name field in repo-index.yml matches the Name field in the plugin's plugin.PluginMetadata section
[ ] The plugin's url field in repo-index.yml contains the same version from the version field

Submitting PRs to CLIPR (the CLI Plugin Repo server)
All new code requires tests to protect against regressions.
Description of the Change
Use latest GA tag to use Google Analytics 4.
Why Is This PR Valuable?
What benefits will be realized by the code change? What users would want this change? What user need is this change addressing?
Applicable Issues
List any applicable Github Issues here
How Urgent Is The Change?
Is the change urgent? If so, explain why it is time-sensitive.
Other Relevant Parties
Who else is affected by the change?

I'm curious how end 2 end testing was done.


Focus management on open / close

I've been looking at the accessibility of the dialogs, notably whether they comply with the WAI-ARIA best practices for dialogs. The native renderer introduced in https://github.com/aurelia/dialog/pull/338 helped a lot. Notably, it ensures focus is placed on the dialog when it opens and cannot leave the dialog. Perhaps similar functions should be added to the standard renderer to make it properly accessible, but that's not what I'm here for.
One accessibility problem remains and that is that focus is not properly returned to the underlying document when the dialog closes. This can make it very difficult to navigate using only a keyboard, and can result in very unclear situations for screenreaders.
The solution is pretty straight forward: the last focused element at the moment a dialog opens needs to be remembered, and focus should be returned to this element when it closes. If that element is no longer available, focus needs to be returned somewhere else in the document. This process needs to be overridable for specific dialogs, since the user may know a better place to return focus to once the dialog closes. See the WAI-ARIA notes as well.

So, I'll try to be as structured as possible(all is personal opinion):

About the concerns of this issue:
1.1 About not allowing focus to leave the dialog, I don't agree that it should be provided by the dialog. A complete cross-platform tab trap  implementation seems quite the challenge. If there is some library that does this then wrapping it in custom attribute seems way more logical.
1.2 Capturing and restoring a focused element seems to be one of the appropriate things to be done in a Renderer, and it would be nice if it can be done as a reusable logic that other renderers can utilize. Also it must be taken into consideration any possible implications of having multiple open dialogs.
Current weak points of the dialog:
2.1 The Rederer concept does not seem well defined, it seems that it's only concern should be attaching/detaching, but it is used for other purposes as well, like adding common dialog elements(backdrop, etc.), common behaviors(keyboard, mouse). This behaviors are internal impls of the default renderer, no other renderer can just plug them in(I don't mean inheritance). Also there are some settings in DialogSettings concerning them, so does this make them mandatory for every renderer? If it is, does adding a new setting(about locating a fallback element to focus) make other custom renderers "broken"?
2.2 No official way to pass custom settings - be it to the view model, Renderer, etc.
2.3 Lack of proper separation - all out-of-the-box custom elements/attributes, renderers, etc., should be in separate package/s. Currently I see this as a burden for the build setups.

@timfish @bigopon Any thoughts?

Maybe we can have an interface for this, say IFocusManager:
interface IFocusManager {
  // return element to be focused when this dialog is closed
  // return null means don't focus anything?
  onDialogOpen(lastActiveElement: HTMLElement): HTMLElement;

  // only invoked when onDialogOpen returns an element?
  // return null means don't focus anything?
  onDialogClosed(toBeFocusedElement: HTMLElement): HTMLElement;
}

Basically when dealing with form, focus strategy may need to be more than just simple last blurred first focused.

@bigopon I went for a simpler interface. If a developer wants to restore focus to a different element they can simply override the restoreFocus setting and track the element themselves.
@StrahilKazlachev I went for a simple addition to both renderers. While I agree that the code could do with some refactoring, I think it's out of scope for this bug.


Release 0.0.7

These changes will be handled by https://github.com/TenKeyLabs/wagmi-magic-connector/pull/10


Extensions list is out of date

In the README.md file:
kartik-v/yii2-markdown now uses michelf's markdown instead of cebe. See https://github.com/kartik-v/yii2-markdown/blob/master/composer.json

Seems it has never used it but has planned to use it in 2014 :)

https://github.com/kartik-v/yii2-markdown/issues/17#issuecomment-40749471
Note though... I have a plan to upgrade the Markdown parser using cebe's Markdown parser down the line (maybe sometime in May when he adds the MarkdownExtra support).

I'll remove the line from readme for now :)

Fixed, thanks for the hint!


Test benchmark publication system [ no functional change ]

Pull request
Description
Dummy Pr to test bench triggering

Coverage increased (+0.03%) to 85.254% when pulling 3700f043b7bcc13447cbdc5f28d8a8d4cd1e6b62 on push-test into e7c4a0e3d0462165e1c7db297d0e29268cbf264c on main.


"Error response from daemon: unknown log opt 'max-file' for journald log driver"

Get this error when trying to deploy to an older docker version.
See pull request for resolution

https://github.com/solace-iot-team/async-apim/pull/45

PR meged


Segfault during use of sfizz_render

When trying to convert the attached MIDI file with the Salamander soundfont to WAV, sfizz_render crashes.
The used version was compiled from 6cd063da8c6973447b0f86b63100e2aa1f2b1d48 under Ubuntu Focal.
Backtrace:
0  __memmove_avx_unaligned_erms ()
    at ../sysdeps/x86_64/multiarch/memmove-vec-unaligned-erms.S:436
#1  0x00005555555e1e85 in sfz::copy<float> (output=..., input=...)
    at /home/michael/sfizz/src/sfizz/SIMDHelpers.h:540
#2  sfz::Voice::Impl::amplitudeEnvelope (this=this@entry=0x555555a59fe0,
    modulationSpan=...) at /home/michael/sfizz/src/sfizz/Voice.cpp:900
#3  0x00005555555e554a in sfz::Voice::Impl::ampStageStereo (
    this=this@entry=0x555555a59fe0, buffer=...)
    at /home/michael/sfizz/src/sfizz/Voice.cpp:949
#4  0x00005555555e7e56 in sfz::Voice::renderBlock (
    this=this@entry=0x555555a1fbf8, buffer=...)
    at /home/michael/sfizz/src/sfizz/AudioSpan.h:209
#5  0x00005555555aae03 in sfz::Synth::renderBlock (this=<optimized out>,
    buffer=...) at /home/michael/sfizz/src/sfizz/AudioSpan.h:209
#6  0x0000555555576fd8 in main (argc=8, argv=0x7fffffffdf68)
    at /home/michael/sfizz/src/./sfizz/AudioSpan.h:194

Elgar_From_Bavarian_Highlands_Lullaby-Alt.zip

Same file works fine with the Win64-build shipped in release 1.2.3.

@michaelkaeppler I love the potential of this project, but I'm not sure how active development is now. Have you had any success with getting a response from the developers?

I don't have much time for it no, and I'm the main/sole maintainer these days. Some people use sfizz downstream though and can maybe help sometimes.

What exact CPU/OS are you using? Typically such illegal instructions vary alot between CPUs...


Leaky null bytes with InputTextCallback combined with enter_returns_true

With current main branch as of f00b5707c0e3a4916d15228f2e0b19301424ffc8
use imgui::*;

mod support;

fn main() {
    let system = support::init(file!());
    let mut buf = String::default();

    system.main_loop(move |_, ui| {
        ui.window("Input text callbacks")
            .size([500.0, 300.0], Condition::FirstUseEver)
            .build(|| {
                struct CB {}

                impl imgui::InputTextCallbackHandler for &mut CB {
                    fn on_history(
                        &mut self,
                        _dir: imgui::HistoryDirection,
                        _data: imgui::TextCallbackData,
                    ) {
                    }
                }

                let mut cb = CB {};
                ui.input_text("Example", &mut buf)
                    .callback(imgui::InputTextCallback::HISTORY, &mut cb)
                    .enter_returns_true(true)
                    .build();
                ui.text(dbg!(&buf));
            });
    });
}

Typing abc in the input works flawlessly, but if I press backspace twice the buffer is filled with two nulls:
[imgui-examples/examples/callback_bug.rs:29] &buf = "a\u{0}\u{0}"

Bizarrely only happens with enter_returns_true enabled :shrug:

Well, I don't like that.

Frankly this whole abstraction here needs to be cleaned up by me. I kind of hacked it in, as it was better than nothing, but I needs some rigorousness

I worked around this with
self.text = self.text.chars().filter(|x| *x != '\0').collect();

and nothing can possibli go wrong
The new callbacks are quite useful btw - I was about to roughly emulate the on_history callback before but it was a fragile mess of set_keyboard_focus_here calls

Fixed it in the recent commit! Lmk if there's any issues for ya. I added an example for a "test" thing


Shereida's new adventures here

I am new to this and, it is a bit overwhelming. Fun though trying to follow these directions.
This is something I have never done before!!!


Overlapping library widgets on hovering

Describe the bug
The library widgets grow underneath each other on 4k
To Reproduce
Steps to reproduce the behavior:

Open files on a 4k monitor.
Hover over a library widget.

Expected behavior
The widget should expand over other widgets while hovering and not expand behind other widgets.
Screenshots

Desktop (please complete the following information):

OS Version: [Windows 10 20h2 19042.685]
App version: [v0.24.1]

Additional context
Add any other context about the problem here. Does this problem occur again after restarting the app?
Log file
debug_fulltrust.txt
debug.txt

Duplicate of #2246.

Duplicate of #2246.


Load resource template

I think this is finished.

The dropdown list is created from resource template ids stored in verso profiles.
When a profile is created, updated, or deleted, then the templateRefs get zapped from local storage and refreshed the next time the user loads a profile.
I spent most of my time trying to workout performance issues.  I believe the problem is with Angular's rendering of the large (350 items) option list.  I couldn't get it working better (it was sluggish even before this change.)

If we use the select element on it's own, we get a very fast response (as expected).  I guess we won't need an input/select combo any more since the cataloger will no longer need to manually enter template reference.  I think this is probably the way to go.  Oh yeah, I sorted the templateRef list so that it is in alpha order.


Read SO_REUSEPORT on socket before setting

See if we're able to read the value from the
socket. If that fails, skip setting the value on
the port.
Note: I don't have any machines with an old enough kernel lying around to test that it fails correctly, but perhaps someone out there could jump in and give it a try.
Given this comment: https://github.com/miekg/dns/issues/802#issuecomment-433618478
I'm not sure where you want this to live, or if it's on the user to know they can use SO_REUSEPORT or not.

Might be simpler to always do this, instead of the conditional compilation? Would there be any downsides to that?

Based on this comment: https://github.com/miekg/dns/issues/654#issuecomment-375315602
It sounds like this behavior is only supported in go1.11+?

[ Quoting<EMAIL_ADDRESS>in "Re: [miekg/dns] Read SO_REUSEPORT o..." ]

chantra commented on this pull request.

@@ -16,6 +17,11 @@ const supportsReusePort = true
func reuseportControl(network, address string, c syscall.RawConn) error {
var opErr error
err := c.Control(func(fd uintptr) {

 _, err := unix.GetsockoptInt(int(fd), unix.SOL_SOCKET, unix.SO_REUSEPORT)

 if err != nil {

 	opErr = fmt.Errorf("could not get SO_REUSEPORT: %s", err.Error())

 	return

shouldn't this explicitly return opErr?

this code already has a toggle to allow you to use it, there is no direct reason
to tweak this. In coredns we ignore the error here.

Closing, as users are allowed to opt-in to this code.


Implement pubsub_listen_ordered_messages sample

Subscribe to some messages and manually sort them.
https://github.com/googleapis/nodejs-pubsub/blob/dcdec71e3a496b041dc8d1d0f03eda85d5d0cf63/samples/listenForOrderedMessages.js#L49-L114

The region tags for publishOrderedDate was updated 23 days ago but listenForOrderedMessages hasn't been updated in 6 months. I modelled my PR after that sample (including the logic to use a timeout to wait for messages and then sort them by a counterId) so if that is also outdated, I'll wait for updated information how to proceed.

I think we are not going to implement any specific examples for receiving ordered messages.  The same code as receiving regular messages "Just Works":tm:


Remarks to "Create your first kata" tutorial

Review and address useful remarks reported on Gitter

Ajay Mishra @XRFXLP 16:55
It also allows you to see how others write their tests.
I'm newbie, how can I see the tests? from where?
(I am actually not sure how to put it properly there without disturbing the brevity)
jonatan @namedots 16:59
However, authors sometimes do not realize the fact that creating a good quality kata
probably condencending to the reader, in "this document only applies to you if this holds"
however true and neutral, it is being said to the reader and isn't good salesmanship
Ajay Mishra @XRFXLP 17:06
Sharing a link to a draft is a very good way to get quick feedback about the most obvious problems.
It is not clear to me, where to share?
jonatan @namedots 17:07
learnign
is wellcrafted a word? idk it's not too offensive :P
jonatan @namedots 17:08
There's too many kata
that's probably are
There's too many kata which require just to iterate over a sequence
There are too many kata only requiring iterating over a sequence
(.... I'm not trustworthy on this, honestly nvm, get somebody else for this)
Ajay Mishra @XRFXLP 17:10
From https://docs.codewars.com/authoring/kata/create-first-kata/#train-on-your-kata :
If you do not understand some guideline or you are not sure whether your kata violates it, just ask more experienced users for advice.
jonatan @namedots 17:11
Many topics has been already
have
Ajay Mishra @XRFXLP 17:11
It would be better if you(maybe) link this room or other.
If you do not understand some guideline or you are not sure whether your kata violates it, just ask more experienced users for advice.
jonatan @namedots 17:12
and understand them, before you apply them to your kata.
remove the comma :(
Ajay Mishra @XRFXLP 17:14
There's a link to the chat in "Support for authors" section. You think it's not enough?
I think most of the people won't read it all, or maybe just read some segment. (and I don't think attaching a link would disturb the clarity or make it verbose in any sense)
Ajay Mishra @XRFXLP 17:25
Would it be good if you can attach link of those github issues/wiki of duplicate kata somewhere in here: https://docs.codewars.com/authoring/kata/create-first-kata/#kata-idea-and-duplicates ?
Ajay Mishra @XRFXLP 17:35
there are already over 6500 approved kata
There are 6923, make it 7000?

Addressed with #317


Suggest handling live-reload in development by default

I had to add <script src="http://localhost:3808/webpack-dev-server.js"></script> to my layout template in order to get livereload working. I'd suggest enabling this by default or via configuration so that it "just works".

Interesting (not on laptop, so email will have to do).
We've only used react-hot-reload here.
I'd prefer to add a hint to the documentation rather than make this
standard behaviour.
On Sat, Nov 21, 2015 at 9:28 AM, Chris Nicola<EMAIL_ADDRESS>wrote:

I had to add  to my layout template in order to get livereload working. I'd
suggest enabling this by default or via configuration so that it "just
works".
—
Reply to this email directly or view it on GitHub
https://github.com/mipearson/webpack-rails/issues/7.

--
Michael Pearson

That sounds good to me. I'll likely put together some sort of config though so if you are interested I'd be happy to submit a pull request.

BTW, thanks so much for this. Saved me so much time and made it really easy to get started. Switching to Webpack has been a huge improvement over Sprockets.

FYI, I've found that starting the webpack dev server with --inline also fixes this. It loads the webpack server inline with the other scripts automatically. This is what we do now.


mDNS

boot2docker-cli is going to use mDNS to find out things like the hostonly ip address - the iso OS will need to tell us - at least until we implement that as a docker daemon plugin

@SvenDowideit Would this in any way be helpful to you, w.r.t. this issue? https://github.com/boot2docker/boot2docker/pull/497#issuecomment-247808093


[R3] FAQ Content

https://taskman.eionet.europa.eu/issues/147637

Conflicts with develop resolved using the files already in develop (theirs), for:

theme/themes/eea/extras/header.less
theme/themes/eea/extras/header.variables
theme/themes/eea/extras/publicationCard.less

@eea-jenkins build all

The feature tha provided a custom content with hardcoded tags, actions and language dropdown dropped.
Reopen in case that we have a use for it, but refactor it with the logic of sections/slots for the components inside the content.


Github: Contact detailed changelog

Concat "Detailed changelog" pull request into one message, if have duplicates, example:
Update translations from Tolgee by @github-actions in #615
Update translations from Tolgee by @github-actions in #617
Update translations from Tolgee by @github-actions in #619

-- >

Update translations from Tolgee by @github-actions in (#615, #617 and #619)

https://github.com/marticliment/WingetUI/releases/tag/1.6.0
I did not found "release script" inside this project.
@marticliment

There's no release script, I use the release notes generator from the releases tab.
I will take this in account for future releases, and update v1.6.0


Running Danesfield - Demo

Greetings!
First of all, I would to thank you for sharing the demonstration.. It is helping a lot.
And also, I would like to apologize since I have been asking many questions the last period.
Well, I have downloaded a part of data (more specifically the Jacksonville data), the docker image...etc.
But whenever I try to run the script, it always prompt this message
Is there any idea for what could be the cause of that?

@jacobderosa can you take a look at this and respond?

@NourSoltani It doesn't look like your input_Jacksonville.ini is in your config directory (that you mounted to /configs)

@jacobderosa Well It exists in the /configdir folder which i have mounted to /configs

Thank you!
I think there is some advancement..
But it stopped.. here is what I found

@NourSoltani this often happens when there is insufficient GPU memory to run the VisSat step. There are ways to lower the GPU requirements if you are interested, as well as running VisSat with CPUs instead of GPUs (this will take much longer). Or if you already have a point cloud, there is an option to start Danesfield with that cloud instead of generating one.

You could also try a different site or manually shrink the specified region of interest for Jacksonville to cover a smaller areas.  Jacksonville is the largest of our test datasets.  Larger sites will require more GPU memory.  We don't currently have tiling implemented to break the problem into smaller subproblems.  What GPU hardware are you using?

@mleotta  @jacobderosa  We have a Quadro RTX 6000 with 24 GB of GPU memory..
So I think it is sufficient.. isn't it?

Yeah, I think 24GB should be enough.  Looking closer, this error doesn't look like a GPU memory issue.  It looks like VisSat is trying to compute a np.percentile on and empty z_values on line 99 of VisSatSatelliteStereo/reparam_depth.py.  @jacobderosa can you help debug why z_values could be empty?  Those processing times for previous steps look very quick.  Maybe it's not actually finding the images?

I recommend checking the log files for the clean_data and crop_image steps. You can find them at outdir/vissat/logs. They will have more clues as to what's going wrong here. Post them here and I can look through them.

Oh Okay! I understand you.
You can find below all the log files.
log_sfm_perspective.txt
log_reparam_depth.txt
log_derive_approx.txt
log_crop_image.txt
log_clean_data.txt


Remove avoid_null_checks_in_equality_operators from recommended

[x] I’ve reviewed the contributor guide and applied the relevant portions to this PR.

Contribution guidelines:

See our contributor guide for general expectations for PRs.
Larger or significant changes should be discussed in an issue before creating a PR.
Contributions to our repos should follow the Dart style guide and use dart format.
Most changes should add an entry to the changelog and may need to rev the pubspec package version.
Changes to packages require corresponding tests.

Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.

Thanks! The change proposal seems straightforward. I'd like to hold off on landing this until we have our next regular review.

Thank you!

Oops, I should have written this fixes https://github.com/dart-lang/lints/issues/200.


fix proptype for dropzone element option

Fixes the PropType for dropzone components element option. It expects a DOM node, which is an object.

Thanks for this. Curious if you've been able to test passing an element prop to a <Dropzone />. And if so, can you provide some code to illustrate the context of your choice to use this prop?

I did test something like
<Dropzone
  uploader={this.uploader}
  element={document.body}
/>

and
<Dropzone
  uploader={this.uploader}
  element={document.querySelector('body')}
/>

and this works (except for the warning about invalid proptype). But I think the element needs to exist when the component is rendered. I do not have a specific use case myself.
I did test passing something else than a dom node, like
const el = (

);

<Dropzone
  uploader={this.uploader}
  element={el}
/>

and this will give errors like
Uncaught TypeError: Cannot read property 'replace' of undefined
at Object.removeClass (dnd.js:73)
at dnd.js:901
at Function.qq.each (dnd.js:428)
at dnd.js:899

great - thanks for the confirmation, report, and fix

@danielsarin
I had the same error when passing a reactElement, its because when dnd, tries to set the active class to active, it tries to replace the classname on the (dom) element, which it is not.
So i wrapped the ref within ReactDOM.findDOMNode(this.ref.dropZone)
within DropZone.js
import ReactDOM from 'react-dom'; ... const dropzoneEl = element || ReactDOM.findDOMNode(this.refs.dropZone);
So its able to change the classname on the element.


It doesn't work at least on breath of the wild

I installed all of it, but when i try to play breath of the wild link doesn't move, the camera either, i cannot do anything.

Try this release: https://github.com/HiDe-Techno-Tips/Mouse2Gamepad_for_Yuzu/releases/latest

Try v1.2.0
https://github.com/HiDe-Techno-Tips/Mouse2Gamepad_for_Yuzu/releases/latest

It does not work. I don't know, but maybe the problem is my yuzu's input settings. I'll attach a photo of my input setup and see if it helps.


CollectionRepository does not use custom models

The driver allows to specify a different EntryModel in config/statamic-eloquent-driver.php by setting entries.model.

However, the CollectionRepository is currently hardcoded to use the shipped EntryModel:

This leads to errors when updating entries. A PR will be provided to fix it.

Can you check this against v1? I think this issue can be closed.


[DROOLS-1378] Option: Force reading String from a Numeric type cell i…

…n SpreadSheet
Introduced a system property "drools.spreadsheet.numeric.disabled" which avoids to read a double value and relies on DataFormatter instead.
This system property is enabled only in SpreadsheetCompilerUnitTest#testDisableNumeric(). But I also tested the all drools-decisiontables test cases with this property and confirmed that only SpreadsheetCompilerUnitTest#testProcessSheetForExtremeLowNumbers() failed. It's expected because the test is intended to read a double value.
Note: the Numeric cell ("6600") in the test case XLS (Numeric.xls) was copied from customer's cell which was generated by VBA macro.
Feel free to let me know your thought on this.

@tkobayas Hi, it would be better, IMO, if you made the flag work the same as other flags already present (for example EscapeQuotes). and Sequential. There is a test showing use of EscapeQuotes that will be useful to understand how it works (the flag is set in the "RuleSet" section of the decision table).
The new flag would also need inclusion in the documentation.

Thank you for the suggestion, Mike! Sure I'll make changes soon.

Made changes and also sent a doc PR (https://github.com/droolsjbpm/kie-docs/pull/191).
Btw, please check with Mario if he agrees this feature request (See comments in https://issues.jboss.org/browse/DROOLS-1378).


[Experiment] Add rack-cache gem and back it by Redis

I'm playing around to see if we can get a performance bump by adding https://github.com/rtomayko/rack-cache backed by Redis.

I might be mistaken but right now, the site is aggressively cached by Cloudflare and in a mode of serving static content. So I'm not sure we could gain much in trying to cache things at Heroku level.
See https://github.com/git/git-scm.com/blob/master/ARCHITECTURE.md

Nope, you're not mistaken. My gut says that further caching at Heroku isn't going to make a huge difference, and load / reponse time at Heroku is pretty manageable right now. That said, if somebody really wants to dig into it and there are easy wins to lower that load, I'm not opposed to it (keep in mind that we're already using redis for some caching, so these new entries may compete for space, though).

Great things to know 😃 closing this out.
Thanks everyone!


Add PersonDetailsPanel

Pull Request Test Coverage Report for Build 449

49 of 62 (79.03%) changed or added relevant lines in 3 files are covered.
50 unchanged lines in 10 files lost coverage.
Overall coverage increased (+1.9%) to 84.239%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/main/java/seedu/address/ui/InfoPanel.java
8
11
72.73%

src/main/java/seedu/address/ui/PersonDetailsCard.java
40
50
80.0%

Files with Coverage Reduction
New Missed Lines
%

src/main/java/seedu/address/logic/parser/AliasCommandParser.java
1
91.67%

src/main/java/seedu/address/model/alias/UniqueAliasList.java
1
94.74%

src/main/java/seedu/address/ui/BrowserPanel.java
2
69.23%

src/main/java/seedu/address/ui/TimeTablePanel.java
3
91.38%

src/main/java/seedu/address/logic/commands/AliasCommand.java
4
83.33%

src/main/java/seedu/address/logic/commands/VacantCommand.java
4
78.95%

src/main/java/seedu/address/model/building/Building.java
4
87.76%

src/main/java/seedu/address/model/AddressBook.java
4
87.5%

src/main/java/seedu/address/logic/commands/ExportCommand.java
10
0.0%

src/main/java/seedu/address/model/ModelManager.java
17
73.53%

Totals

Change from base Build 421:
1.9%

Covered Lines:
2758

Relevant Lines:
3274

💛  - Coveralls


Update ws to 1.0.1 due to security vulnerability

Quick dependency version change due to a recent security advisory in ws https://nodesecurity.io/advisories/67

Do you know if this affects clients that aren't running ws server-side? 1.0.1 only supports node >0.12 and above, whereas the client is (currently) specced for >0.10, which gives me a little hesitation

Ok, first off, I apologize for how long it's taken us to resolve this issue.
I just pushed the 2.0.0 release for this library, which is a ground up refactor with the aim of building a lib that both Slack and our external contributors can easily work with and improve.
I meant to include the jump to ws >= 1.0.1 as part of the 2.0.0 release, but it slipped my mind, so I'll leave this PR open as a prompt to do so. The 2.0.0 release targets node >= 0.12, so my concern above isn't an issue anymore.

https://github.com/slackhq/node-slack-client/commit/88b504e73f25c3254e820488a769beaea0f2f320 fixes this


TiddlyWiki Node Server error

Hi,
I am hosting local TW with Node, and receiving this message after installing the Firefox clipper.
Blocked attempt to GET /recipes/default/tiddlers.json with filter: [tags[]]
I added my local url to the 'Options' for TiddlyWiki Collector. Interested to try the plug-in, but no luck getting it to work yet.

It seems I had to add $:/config/Server/AllowAllExternalFilters with text field set to yes. Working now :)


Configure embedding setup doublet score plot

Background
Link to issue
https://biomage.atlassian.net/browse/BIOMAGE-491
Link to staging deployment URL
https://ui-ui-api-martin-doublet-plot.scp-staging.biomage.net/
Links to any Pull Requests related to this
https://github.com/biomage-ltd/api/pull/54
Anything else the reviewers should know about the changes here
Changes
Code changes
Definition of DONE
Your changes will be ready for merging after each of the steps below have been completed:
Testing

[ ] Unit tests written
[x] Tested locally with Inframock
[x] Deployed to staging

To set up easy local testing with inframock, follow the instructions here: https://github.com/biomage-ltd/inframock
To deploy to the staging environment, follow the instructions here: https://github.com/biomage-ltd/biomage-utils
Documentation updates
Is all relevant documentation updated to reflect the proposed changes in this PR?

[ ] Relevant Github READMEs updated
[ ] Relevant wiki pages created/updated

Approvers

[ ] Approved by a member of the core engineering team
[ ] (UX changes) Approved by vickymorrison (this is her username, tag her if you need approval)

Just before merging:

[ ] After the PR is approved, the unstage script in here: https://github.com/biomage-ltd/biomage-utils is executed. This script cleans up your deployment to staging

Optional

[ ] Photo of a cute animal attached to this PR

I am not sure if it is related to this, but in the staging link, the "coloured by sample" view in configure embedding does not load. Do you know what the issue is?


Can AAD B2B works for Jira and Confluence?

Azure documentation issue guidance
Thanks for opening an issue in the Azure technical documentation repository.
We use GitHub issues as the primary channel for customer and community feedback about the Azure documentation.
Creating an issue
We prefer that you create documentation feedback issues using the Feedback link on the published article - the feedback control on the doc page creates an issue that contains all the article details so you can focus on the feedback part.
You can also create a feedback issue here in the repo. If you do this, please make sure your issue lists:

[ ] The relevant Azure service or technology.
[ ] A link to the published documentation article that you have feedback about.
[ ] Clear, specific feedback that the author can act on.

Pull requests and article contributions
If you know the change that is needed in an article, we encourage you to submit the changes directly using a pull request. If the change is large, or if you want to contribute an entire article, follow these guidelines:

[ ] Don't surprise us with a big pull request or a pull request with a new article! Submit an issue that describes the details of the proposed large change or new article.
[ ] Include the service or technology area.

We'll route the issue to the appropriate content team for review and discussion.
Tech support and product feedback
If you would like to contact Microsoft about other things, such as product feedback or tech support, please review these guidelines:

If you need technical support using Azure, the paid and free support options are described here: https://azure.microsoft.com/support/options/.

Each article in the Azure technical documentation contains a product feedback button - it's best to submit product feedback directly from a relevant article. Otherwise, you can submit product feedback for most Azure products in the following product feedback forum: https://feedback.azure.com/forums/34192--general-feedback.

@sunkada , Can you please provide the documentation link to further assist ?

Hello Karthik,
As per the documentation of this extension it appears that it helps in authenticating Jira and Confluence through Azure Active Directory for any organization.
My use case is
Organization A owns AAD , Jira and confluence.
Organiation A has may vendors V1 V2, and so on
Organization A wants all its vendor to access Jira and confluence by authenticating AAD without adding V1, V2 users into AAD. Ideally they are ready to setup AAD B2B. Does it works authenticating Jira and Confluence for B2B users without adding them as users in AAD with their own org Ids.
I hope I am clear with my use case.
Thanks,
Narendra
Advance OOF Notifications
Leaves:
From: KARTHIK SRINIVAS<EMAIL_ADDRESS>Sent: Wednesday, March 11, 2020 3:52 PM
To: MicrosoftDocs/azure-docs<EMAIL_ADDRESS>Cc: Sunkada Narendra Rao<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: Re: [MicrosoftDocs/azure-docs] Can AAD B2B works for Jira and Confluence? (#49926)
@sunkadahttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fsunkada&data=02|01|Narendra.Sunkada%40microsoft.com|24e717c706db48253a3908d7c5a6186e|72f988bf86f141af91ab2d7cd011db47|1|0|637195189474359010&sdata=rFh3veMyjszSsWMKgfObzeJdIyLDB3zDtfymSoUCHgk%3D&reserved=0 , Can you please provide the documentation link to further assist ?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMicrosoftDocs%2Fazure-docs%2Fissues%2F49926%3Femail_source%3Dnotifications%26email_token%3DALO2QNT7VM6EBKPNNONXL4LRG5Q6DA5CNFSM4LFPBKJ2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEOO63ZI%23issuecomment-597552613&data=02|01|Narendra.Sunkada%40microsoft.com|24e717c706db48253a3908d7c5a6186e|72f988bf86f141af91ab2d7cd011db47|1|0|637195189474359010&sdata=l2SEqRpGBPGjbgGx1dijEG95Yftlvv1VFs%2FjQJMwGDA%3D&reserved=0, or unsubscribehttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FALO2QNQOKAEXCTSPKDEW4ULRG5Q6DANCNFSM4LFPBKJQ&data=02|01|Narendra.Sunkada%40microsoft.com|24e717c706db48253a3908d7c5a6186e|72f988bf86f141af91ab2d7cd011db47|1|0|637195189474369003&sdata=bvudPXeED3O686nAi1OKc3%2BMZkO2NMryCDDDbbePC3M%3D&reserved=0.

@sunkada Could you please share the link to the documentation that you are referring to? If this question is not related to any Microsoft Documentation, I would suggest you to post this question at Microsoft Q&A as we use this platform for document enhancement and to fix document bugs.

@sunkada We did not hear back from you. I am proceeding with closure of this thread. Please post your question along with the document link at Microsoft Q&A and we can work on it.


Fix user warning when applying normalize

Fixes #804

Codecov Report

Merging #810 into master will decrease coverage by 0.06%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #810      +/-   ##
==========================================
- Coverage   37.45%   37.39%   -0.07%
==========================================
  Files          33       33
  Lines        3268     3268
  Branches      522      522
==========================================
- Hits         1224     1222       -2
  Misses       1964     1964
- Partials       80       82       +2

Impacted Files
Coverage Δ

torchvision/transforms/functional.py
70.47% <100%> (+1.26%)
:arrow_up:

torchvision/transforms/transforms.py
82.29% <0%> (-1.38%)
:arrow_down:

torchvision/datasets/imagenet.py
21.21% <0%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6eac421...b6ff9dc. Read the comment docs.


VideoClassificationData.from_files() does not work

🐛 Bug
VideoClassificationData.from_files() does not work. VideoClassificationData objects can only be constructed using the from_folders() classmethod - which unfortunately doesn't work for multilabel tasks :)
To Reproduce
I wrote a Colab notebook to reproduce this in a self-contained environment: https://colab.research.google.com/drive/1X7UvZDndCc0dzcUZ_fGdmQz0ZMTTsj_U?usp=sharing
Code sample
See link to colab above
Expected behavior
A VideoClassificationData object should be constructed from a list of paths and their labels

Dear @Darktex,
It should be too hard to support. Would you be interested to give it a try and open a PR ? I would help you if needed
Best,
T.C

Of course! I tried for a bit on my own, but I wasn't able to track down the root cause - lots of delegation going on :(
I think I'd need some pointers to unblock

See #823


Implement "Only download updates when connected to wifi" in settings screen

Many applications have the option to only update content when wifi is available. Please implement this functionality in the settings area and activate it as standard.

@mariobehling Do we keep this only or we ask the user at the start of the app if her wants to update to latest schedule as well?


Ability to click on any point and find out its classification value (if any)

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
When working with large LIDAR datasets it's quite common to find datasets that are contaminated with noisy data.
Using tools like LASTools can help remove a lot of the noise but I often find that there is still a lot left over which can severely diminish the visual impact of the data (especially if the LIDAR is not colourized).
Having this feature to merely identify the classification of the noisy data or its return type could really help speed up the noisy data removal process.
Alternatively, it would be useful to have a tool that would allow you to draw a box/cube or draw a polyline fence around noisy data areas and then export the coordinates to a text file that could be used by LASTools to remove the noisy data falling inside of those regions.
Describe the solution you'd like
A clear and concise description of what you want to happen.
Vault is great at showing you where the noisy data is but it may not be able to help you very much with figuring out the classification values associated with that data (depending on who acquired the data and how well they stuck to the classification system). Data from the surface of the sea or lakes is often a good example of data that usually escapes being filtered out as noise and looks pretty bad.
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Tried using LASTools to help with the process.
It's very iterative and slow at the moment and is only made worse with larger datasets.
Additional context
Add any other context or screenshots about the feature request here.

I've had a local branch for this locally for a little while, I'll try submit it this afternoon.

One other thing that could be a useful option during the conversation process from LAS to UDS:
Give the user the option to generate multiple UDS files instead of just one UDS file.
Each UDS file would then act like a "layer" in Autocad and could represent an individual:

intensity value
return value
scan angle
scan line flag
classification value
point source
RGB values

The user can then load all of the UDS files into Vault and then turn them on/off individually in order to better determine whether the data that they contain is worth keeping or not.
I think that this could dramatically improve the speed and the reliability of the QC process for companies that carry out the acquisition of aerial lidar datasets.

This is in #290 but has not been accepted yet.

This is working with the voxel inspector tool.


Error Downloading

Tried downloading Juno in Atom and I kept on getting this error
Error: Installing<EMAIL_ADDRESS>failed.

Have you Solved it?
I am also facing this  problem.

http://docs.junolab.org/dev/man/update/#Update-Instructions-1

Have you Solved it?
I am also facing this problem.

Yeah
I've found an alternative

https://medium.com/@Ifihan_/an-alternative-way-to-install-juno-853f1455cf39


Add the marshal.Marshaler interface

This lets types provide their own Noms value marshaling.

There were some subtle things here, if you can think of any other reasonable test cases, LMK.
marshal.Unmarshaler is almost ready, it was a little trickier.


Where is CFG?

How to create cfg file?

Did you read the README file ? I guess you did not.
You can run make setup to create it automatically if you have make installed on your system, or just create it manually. The field that you need to specify are written in the README.


Programming exercises: Allow instructors to create assignment repository after due date passed

Checklist
General

[ ] I tested all changes and their related features with all corresponding user types on a test server.
[ ] This is a small issue that I tested locally and was confirmed by another developer on a test server.
[x] Language: I followed the guidelines for inclusive, diversity-sensitive, and appreciative language.
[x] I chose a title conforming to the naming conventions for pull requests.

Server

[ ] Important: I implemented the changes with a very good performance and prevented too many (unnecessary) database calls.
[x] I followed the coding and design guidelines.
[ ] I added multiple integration tests (Spring) related to the features (with a high test coverage).
[x] I added pre-authorization annotations according to the guidelines and checked the course groups for all new REST Calls (security).
[ ] I documented the Java code using JavaDoc style.

Changes affecting Programming Exercises

[ ] I tested all changes and their related features with all corresponding user types on Test Server 1 (Atlassian Suite).
[ ] I tested all changes and their related features with all corresponding user types on Test Server 2 (Jenkins and Gitlab).

Motivation and Context

Resolves #6430
When trying to create an assignment repository for an instructor after the due date of the programming exercise has passed, an error is thrown. Instructors should be able to create an assignment repository for a programming exercise even after the exercise due date has passed.
Description

If the exercise is a type of programming exercise, then to start participation the due date should not be passed. If the due date is passed, instructors still can create an assignment repository and students can only participate as a test run.
To solve this issue a a check if the user's role is an instructor is added to the start participation conditions.
Steps for Testing

Prerequisites:

1 Instructor
1 Programming Exercise with due date passed

Log in to Artemis
Go to Course Management and look for the exercise with the due date in the past as an instructor.
Click on 'Edit in editor'
Click on 'Create assignment repository'

Exam Mode Testing

Review Progress

Code Review

[ ] Code Review 1
[ ] Code Review 2

Manual Tests

[ ] Test 1
[ ] Test 2

Exam Mode Test

[ ] Test 1
[ ] Test 2

Test Coverage

Screenshots

Codecov Report

Merging #6824 (9f3e40f) into develop (83f5bd3) will decrease coverage by 4.54%.
The diff coverage is 100.00%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #6824      +/-   ##
=============================================
- Coverage      84.93%   80.40%   -4.54%
- Complexity     13920    13921       +1
=============================================
  Files           1148     2437    +1289
  Lines          44912    93237   +48325
  Branches        4641    13106    +8465
=============================================
+ Hits           38148    74968   +36820
- Misses          4249    10048    +5799
- Partials        2515     8221    +5706

Impacted Files
Coverage Δ

...n/www1/artemis/web/rest/ParticipationResource.java
83.16% <100.00%> (+0.04%)
:arrow_up:

... and 1291 files with indirect coverage changes

Flag
Coverage Δ

client
76.20% <ø> (?)

server
84.92% <100.00%> (-0.02%)
:arrow_down:

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 83f5bd3...9f3e40f. Read the comment docs.


Add kulkarniRa.s file new

created a branch, created a file and made a commit, and opened a pull request

looks good


nit: Allocated slightly bigger vec than needed

I think this is slightly more correct as the rest of the algorithm is focusing on chars not bytes, so this is more consistent.

r? @alexcrichton
(rust-highfive has picked a reviewer for you, use r? to override)

Thanks!  That's pretty subtle, but seems fine to me.
@bors r+

:pushpin: Commit c7a79be6f8a8da1d6dee54fe3f5c137d293692b0 has been approved by ehuss

:hourglass: Testing commit c7a79be6f8a8da1d6dee54fe3f5c137d293692b0 with merge a821e2cb24d7b6013433f069ab3bad53d160e100...

:sunny: Test successful - checks-actions
Approved by: ehuss
Pushing a821e2cb24d7b6013433f069ab3bad53d160e100 to master...


Abolish Unittest

Nothing for release notes
Abolish unittest.TestCase and replace it with pytest's simpler and more powerful syntax.
Beyond consistency, the other reason to do this is so that we can use fixtures in these classes.

I'm excited about this, but I don't think all the tests are running:
on main:
2555 passed, 20 skipped, 494 warnings in 115.14s (0:01:55)
989 lines missing coverage
on this branch:
2390 passed, 20 skipped, 136 warnings in 108.25s (0:01:48)
1531 lines missing coverage

@prescod Here are the test classes that are not getting run:
cumulusci/core/tests/test_flowrunner.py::FullParseTestFlowCoordinator
cumulusci/core/tests/test_flowrunner.py::PreflightFlowCoordinatorTest
cumulusci/core/tests/test_flowrunner.py::SimpleTestFlowCoordinator
cumulusci/core/tests/test_flowrunner.py::StepSpecTest
cumulusci/core/tests/test_source.py::TestGitHubSource
cumulusci/robotframework/tests/test_template_util.py::TemplateUtils
cumulusci/salesforce_api/tests/test_metadata.py::BaseTestMetadataApi
cumulusci/tasks/github/tests/test_merge.py::TestMergeBranch
cumulusci/tasks/salesforce/tests/test_CreateCommunity.py
cumulusci/tasks/salesforce/tests/test_ListCommunities.py
cumulusci/tasks/salesforce/tests/test_ListCommunityTemplates.py
cumulusci/tasks/salesforce/tests/test_PublishCommunity.py
cumulusci/tasks/tests/test_datadictionary.py

In most cases because they don't follow the Test* pattern that pytest is looking for, I think. But I don't know yet why TestGitHubSource and TestMergeBranch are missing.

@davisagli Thanks! I was just doing that diff. :)

@davisagli
"cannot collect test class 'TestGitHubSource' because it has a init constructor "
I can fix that.


degs_analysis Errors

Hi, I'm trying to run degs_analysis and am getting the following error.
Input: cellphonedb method degs_analysis  \     "cellphone_db_input_meta.tsv"  \     "cellphone_db_input"  \     "cellphone_db_input_DEGs.tsv"  \     --counts-data gene_name \     --threshold 0.1 \     --project-name "CellphoneDB_DEGS" \     --threads 32
Error:
[ ][CORE][01/03/23-04:47:04][INFO] Initializing SqlAlchemy CellPhoneDB Core
[ ][CORE][01/03/23-04:47:04][INFO] Using custom database at /home/ubuntu/.cpdb/releases/v4.0.0/cellphone.db
[ ][APP][01/03/23-04:47:04][INFO] Launching Method cpdb_degs_analysis_local_method_launcher
[ ][APP][01/03/23-04:47:04][INFO] Launching Method _set_paths
[ ][APP][01/03/23-04:47:04][INFO] Launching Method _load_meta_counts
[ ][APP][01/03/23-04:47:17][INFO] Launching Method _check_counts_data
[ ][APP][01/03/23-04:47:17][INFO] Launching Method _load_degs
[ ][CORE][01/03/23-04:47:17][INFO] Launching Method cpdb_degs_analysis_launcher
[ ][CORE][01/03/23-04:47:17][INFO] Launching Method _counts_validations
[ ][CORE][01/03/23-04:47:22][INFO] Launching Method get_interactions_genes_complex
[ ][CORE][01/03/23-04:47:22][INFO] [Cluster DEGs Analysis] Threshold:0.1 Iterations:1000 Debug-seed:-1 Threads:32 Precision:3
[ ][CORE][01/03/23-04:47:22][WARNING]

DEGs ANALYSIS IS AN EXPERIMENTAL METHOD STILL UNDER DEVELOPMENT!

[ ][CORE][01/03/23-04:47:24][INFO] Running Real Analysis
[ ][CORE][01/03/23-04:47:24][INFO] Running DEGs-based Analysis
[ ][APP][01/03/23-04:47:24][ERROR] Unexpected error
Traceback (most recent call last):
File "/home/ubuntu/miniconda3/envs/cpdb/lib/python3.7/site-packages/cellphonedb/src/api_endpoints/terminal_api/method_terminal_api_endpoints/method_terminal_commands.py", line 300, in degs_analysis
debug
File "/home/ubuntu/miniconda3/envs/cpdb/lib/python3.7/site-packages/cellphonedb/src/local_launchers/local_method_launcher.py", line 176, in cpdb_degs_analysis_local_method_launcher
output_path
File "/home/ubuntu/miniconda3/envs/cpdb/lib/python3.7/site-packages/cellphonedb/src/core/methods/method_launcher.py", line 212, in cpdb_degs_analysis_launcher
output_path)
File "/home/ubuntu/miniconda3/envs/cpdb/lib/python3.7/site-packages/cellphonedb/src/core/methods/cpdb_degs_analysis_method.py", line 153, in call
counts_data)
File "/home/ubuntu/miniconda3/envs/cpdb/lib/python3.7/site-packages/cellphonedb/src/core/methods/cpdb_degs_analysis_method.py", line 362, in build_degs_matrix
d = d.groupby(d.index).max()
File "/home/ubuntu/miniconda3/envs/cpdb/lib/python3.7/site-packages/pandas/core/groupby/groupby.py", line 1560, in max
numeric_only=numeric_only, min_count=min_count, alias="max", npfunc=np.max
File "/home/ubuntu/miniconda3/envs/cpdb/lib/python3.7/site-packages/pandas/core/groupby/groupby.py", line 1001, in _agg_general
how=alias, alt=npfunc, numeric_only=numeric_only, min_count=min_count,
File "/home/ubuntu/miniconda3/envs/cpdb/lib/python3.7/site-packages/pandas/core/groupby/generic.py", line 1022, in _cython_agg_general
how, alt=alt, numeric_only=numeric_only, min_count=min_count
File "/home/ubuntu/miniconda3/envs/cpdb/lib/python3.7/site-packages/pandas/core/groupby/generic.py", line 1135, in _cython_agg_blocks
assert len(locs) == result.shape[1]
AssertionError
Thanks for the help!

Hi @connerlambden
Could you please share the header of your cellphone_db_input_DEGs.tsv?
Best,
Luz

@luzgaral

That worked. Thanks!!


virtual_hid_device_client is not connected yet with latest macOS

After the latest mac update Karabiner is showing "virtual_hid_device_client is not connected yet. Please wait for a while." in the log and is not working.
Karabiner 12.4.0
macOS 10.14.5 (18F132)

I had the same problem which was fixed by updating to 12.14.2 (beta release)
Go to Karabiner-Elements -> Misc -> "Check for beta updates"

It is a macOS problem.
Restarting macOS after macOS upgrade solves this issue.


[WIP] Update cluster init before upgrade

Why is this PR needed?
For migration between CaaSP 4.2.1 and CaaSP 4.3 cluster addons directory should be updated. It was already covered by release notes
https://github.com/SUSE/caasp-release-notes/pull/51/files
This has to be also covered by our CI framework
What does this PR do?
skuba cluster init --control-plane <PUBLIC_IP> /tmp/test-cluster
mv /tmp/test-cluster/addons/cri/conf.d <CURRENT-CLUSTER-NAME>/addons/cri/
rm <CURRENT-CLUSTER-NAME>/addons/cri/default_flags

Merge restrictions
(Please do not edit this)
We are in v4-maintenance phase, so we will restrict what can be merged to prevent unexpected surprises:
What can be merged (merge criteria):
    2 approvals:
        1 developer: code is fine
        1 QA: QA is fine
    there is a PR for updating documentation (or a statement that this is not needed)

related to #1251

it is not  needed any  more


KAFKA-10212; Describing a topic with the TopicCommand fails if unauthorised to use ListPartitionReassignments API

Since https://issues.apache.org/jira/browse/KAFKA-8834, describing topics with the TopicCommand requires privileges to use ListPartitionReassignments or fails to describe the topics with the following error:

Error while executing topic command : Cluster authorization failed.

This is a quite hard restriction has most of the secure clusters do not authorize non admin members to access ListPartitionReassignments.
This patch catches the ClusterAuthorizationException exception and gracefully fails back. We already do this when the API is not available so it remains consistent.
Committer Checklist (excluded from commit message)

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation (including upgrade notes)

ok to test

retest this please

@omkreddy I have opened https://github.com/apache/kafka/pull/8951 for 2.5.

@dajac We have ambiguous reference error for scala 2.12
21:45:50 > Task :core:compileTestScala
21:45:50 [Error] /home/jenkins/jenkins-slave/workspace/kafka-pr-jdk8-scala2.12/core/src/test/scala/unit/kafka/admin/TopicCommandWithAdminClientTest.scala:815: ambiguous reference to overloaded definition,
21:45:50 both method doReturn in class Mockito of type (x$1: Any, x$2: Object*)org.mockito.stubbing.Stubber
21:45:50 and  method doReturn in class Mockito of type (x$1: Any)org.mockito.stubbing.Stubber
21:45:50 match argument types (org.apache.kafka.clients.admin.ListPartitionReassignmentsResult)

@omkreddy I just pushed a fix.

retest this please

ok to test


feat(private-auth): add a form to initiate private auth flow

Fixes

https://issues.redhat.com/browse/HAC-5453
Description

Type of change

[ ] Feature
[ ] Bugfix
[ ] Code style update (formatting, renaming)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] Documentation content changes
[ ] Other (please describe):

Screen shots / Gifs for design review

How to test or reproduce?

Browser conformance:

[ ] Chrome
[ ] Firefox
[ ] Safari
[ ] Edge

If I enter invalid repo and then change to valid repo, looks like the auth section is not removed

@rottencandy fixed this issue. Please test again.


Add missing break after HTTP errors. Change 'Nothing to integrate' case to 400.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (a78734d) 55.99% compared to head (7e1a551) 55.99%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #73   +/-   ##
=======================================
  Coverage   55.99%   55.99%
=======================================
  Files           8        8
  Lines         759      759
=======================================
  Hits          425      425
  Misses        265      265
  Partials       69       69

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


add tests for ecube data gen

i added more comprehensive tests for the ecube data generation / loading since i wasn't getting the same thing back when i loaded a test signal.
but there doesn't seem to be anything wrong with it.. i'm stumped

ok i figured it out, the data just has to have small enough values otherwise it gets clipped when you divide by voltsperbit.

i still can't figure out why the images are slightly different in the test, causing the failure. it also seems to depend on who is running the test because it passes on my machine but not here.

changes made elsewhere


UpdateTask doesn't run when app/package is updated from UWP/desktopBridge to WindowsAppSdk

Describe the bug
I have a UWP/DesktopBridge app (in Microsoft Store) that I am migrating to use WindowsAppSDK Desktop.
When the UWP app is installed (e.g. v1.2.47) on my system and I then deploy the WindowsAppSDK version (e.g. v2.1.0) I don't see the windows.updateTask process (defined in the manifest) being executed.
If I then later do an update of the newly deployed package, e.g. from v2.1.0 to v2.1.1, the UpdateTask does get executed.
The problem is that I want to execute some update code that is related with the migration to WindowsAppSDK and I wan't this to happen in the background.
The update code is required since the 'old' UWP version is using a inproc timer background task which should keep on running when the package is updated. In WindowsAppSDK Desktop the timer background task must be OOP. After the update the background processes apparently have to be re-registered and I want this to happen without user intervention.
Steps to reproduce the bug
Create UWP app and deploy.
Create WindowsAppSDK app with the same package ID's, a UpdateTask and a different version number, and deploy.
Expected behavior
UpdateTask should run.
Screenshots
No response
NuGet package version
1.1.5
Packaging type
Packaged (MSIX)
Windows version
Windows 11 version 22H2 (22621, 2022 Update)
IDE
Visual Studio 2022
Additional context
No response

@gabbybilka I saw that this issue is getting the "Documentation" label. How should I interpret this? Would it mean that what I am bringing up is not a bug? That it will never be corrected but will be documented as "not possible"?

@gabbybilka, wondering if there are any updates regarding OOP background tasks.


feat: Proper recursive naming of rules and construction of prefixes in nested modules

Description
This PR suggests a quick and dirty modification to achieve recursive renaming of rules and prefixing of paths in nested modules, addressing https://github.com/snakemake/snakemake/issues/2084, or the earlier https://github.com/snakemake/snakemake/issues/1626 .
I expect this to break stuff. But it does what I need it to do.
After applying the modification, I realized that another PR with the same aim exists already, https://github.com/snakemake/snakemake/pull/1625 . I am suggesting this PR anyway, since the other has not been discussed yet neither, and the implementations differ.
Will fill in samples and tests when able to find some time.
QC

[x] The PR contains a test case for the changes or the changes are already covered by an existing test case.
[x] The documentation (docs/) is updated to reflect the changes or this is not necessary (e.g. if the change does neither modify the language nor the behavior or functionalities of Snakemake).

The current documentation touches modularization at

https://snakemake.readthedocs.io/en/v7.24.1/snakefiles/deployment.html#using-and-combining-pre-exising-workflows and
https://snakemake.readthedocs.io/en/v7.24.1/snakefiles/modularization.html#modules,

but does not mention any limitations in handling of nested modules and paths, hence no modification needed.
With proper tests and the whole test suite running through, I think it's fair to cross out the initial "quick and dirty" warning above.

Have to understand how test System works. At the current point, the inserted test case succeeds even If I intentionally corrupt the expected results.

Test now works as expected, issue were . (dot)-prefixed filenames not being checked against.

@johanneskoester would you please consider rerunning the CI workflows and discussing this

@johanneskoester Is there an update on this PR? My research group is making extensive use of SnakeMake (a fantastic tool, thank you) and it would be important for us to get this or at the functionality of this PR merged.

@jotelha has this been fixed on #1817?


BModal: Focus trap exception on modal display with custom header and footer hidden

Describe the bug
Hello,
I have the following exception occurring when trying to show a modal with a custom header and footer hidden. See reproduction below.
Operational consequences: modal not working and application is blocked

Kind regards,
Tvore
Reproduction
https://stackblitz.com/edit/github-hspdt1?file=src%2FApp.vue
Used Package Manager
pnpm
Validations

[X] Have tested with the latest version. This is still alpha version and sometime things change rapidly.
[X] Follow our Code of Conduct
[X] Read the Contributing Guide.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] Check that this is a concrete bug. For Q&A, please open a GitHub Discussion instead.
[X] The provided reproduction is a minimal reproducible of the bug.

.23.3


Upgrade to wasmd 0.29.1

Resolves #448 #453

Codecov Report

Merging #470 (d28981b) into wasmd029rc1 (d8f5c5f) will increase coverage by 0.02%.
The diff coverage is 57.89%.

@@               Coverage Diff               @@
##           wasmd029rc1     #470      +/-   ##
===============================================
+ Coverage        56.65%   56.67%   +0.02%
===============================================
  Files               72       73       +1
  Lines             5807     5824      +17
===============================================
+ Hits              3290     3301      +11
- Misses            2197     2200       +3
- Partials           320      323       +3

Impacted Files
Coverage Δ

app/test_access.go
0.00% <0.00%> (ø)

app/test_helpers.go
1.00% <ø> (+0.01%)
:arrow_up:

app/upgrades/v3/upgrades.go
62.50% <62.50%> (ø)

app/app.go
87.59% <100.00%> (+0.03%)
:arrow_up:

Closing in favor of #471


Create meaningful log message if auth-server can't be reached.

As @mirabilos pointed out in auth-server#55 the resource server doesn't generate a meaningful log message if it refuses to validate an access token because of an unreachable auth server.

Yes, it should log such a scenario. But just a simple log message, without stacktrace. Otherwise the log will be bloated after a few minutes on a busy resource server.


Observatory doesn't print where it's listening when receiving SIGQUIT

One can make observatory start by sending (at least on Linux) SIGQUIT to it.
Back in the day it printed to the terminal where it was listening so one could open it up and be on ones way.
Now, however, nothing is printed.
Sending SIGQUIT again and it prints something like
Observatory no longer listening on http://<IP_ADDRESS>:36721/VPYtH1GXBBY=/

but considering it's no longer listening that's not all that useful.
(a workaround for me for now is that while the port changes when sending SIGQUIT again, the auth code does not, so sending SIGQUIT a third time and running lsof -Pnl +M -i4 | grep dart | grep LISTEN can give me a port so I can recreate the url myself --- it's not very user-friendly though).
Please make it print the url again.

@jensjoha can you elaborate on what feature of Observatory you rely on that is not available in devtools.
//cc @bkonyi

I have no experience with devtools --- from the link I
a) Need to install something extra, and
b) Still need to uri to observatory for it to do anything which is what this issue is about: I don't have that.


Add hyper-arc-dark-controls

Hi there @moso!
Thank you so much for the PR, I can't wait to merge this.
Firstly, could I request that you take a screenshot of the plugin at 2x density whilst being 600px in width (if possible)
Also, for me to merge this PR, we'd need the image to be solely of the plugin in Hyper, not including other plugins and themes (like hyper-statusline at the bottom of your image).
If the image could just be vanilla Hyper with your plugin, it'd be perfect 🤞
Once you have these things (and if you could rebase), I'd be happy to merge!
Sorry for not making this clear in the wiki, I'll work on that!
If you need any help with the image, let me know

Rebase done!

I have uploaded a new screenshot with a slightly larger fontsize, inspired by looking at the latest submission of hyper-flat. It's the same size (600 x 2 = 1200), and clear of all other plugins.
If the image isn't okay, please do let me know :smile:

Thank you 👍


How to make update the configuration easier

Expected Behavior
When I update detekt my configuration of detekt is updated too to reflect the new defaults/rules/flags.
Current Behavior
Right now detekt doesn't do that and it's a pain to keep it updated.
Context

https://github.com/mozilla-mobile/android-components/pull/11540 is a PR I made updating the detekt configuration. The work that I needed to do there to be sure that I update the new configuration but without loosing the previous configuration was huge. And, it's not clear if the previous documentation is the old default one or is a custom one so, maybe, it is using old default values.
I usually use this script/algorithm to update my configuration: https://github.com/detekt/detekt/discussions/3558#discussioncomment-483027 but it uses generic merges that doesn't know about how yaml work so usually there are some conflicts. The good part of updating like this is that all the default values are updated correctly.
https://github.com/detekt/detekt/pull/4352#issuecomment-1019417360 there are users that use this file https://github.com/detekt/detekt/blob/main/detekt-core/src/main/resources/default-detekt-config.yml to make diffs between it's configuration and the default one.

To be honest, I don't know how we can fix this issue. In my case I like to have ALL the configurations in my project so I can see all the flags of all the rules and configure it easily. I use the configuration like documentation or a documentation index. Using the script/algorithm linked in point 2 I can keep my documentation up to date but it's not as fast and easy as it should be. Problems:

In the middle of the script you need to update manually the detekt version so it's easy to automatice. In my project I know where the version of detekt is defined so I could use sed. But that's not replicable to other projects.
I'm merging two yamls but I'm not using the fact that they are yaml. So I get lots of conflicts that could be avoided if the merger would interpret the yaml instead of treting it as a plain file.

Any ideas about how to make it easier? Should we include a detektUpdate task on our gradle plugin? How could we implement it?

Just dropping this here: https://github.com/detekt/detekt/pull/3002#issuecomment-687082930
IMHO this issue should be part of the broader discussion on how the configuration of detekt can be improved overall. Perhaps a config that allows for enabling all rules by default means the actual detekt config can be stripped back to either enable or disable app rules by default, then enabling or disabling individual rules as required.
That should avoid requiring any wholesale changes to the config file with new detekt releases.

I'm late to the conversation, but if the old configuration method is being thrown out, this is a good opportunity to design the way configuration works from the ground up. From what I understand the main driver of this change is to get auto-complete in the IDE? This could also be achieved with JSON schema for YAML which can be achieved with zero config in IntelliJ. I can open another issue for that.
There are so many other possible areas of improvement for the config that I would want to see before a DSL.
I played with Ruby in the past and the Rubocop linter is extremely popular, with a very similar feature set to detekt. Looking at the configuration docs for that I see so many benefits of the approach they took (using YAML!) that solve some problems raised by detekt users.
Features I'd want from the new configurator (some already mentioned above in this thread) based on inspiration from Rubocop:

Including/excluding files for all rules (Allow globally defined exclusion pattern #2581, Don't analyse Kotlin files generated by kapt detekt-compiler-plugin#10)

Enable or disable all rules by default (failFast configuration #1528 (comment))

Explicit inheritance rules. This makes things like multi-project configs in Gradle very simple - each project can have its own config which inherits from a root config, and this can be set within the config file and doesn't require any CLI flags or Gradle config (though that could also be implemented, as long as the order of inheritance were clearly defined)

All config would always inherit from detekt's default config. Where this is not desired, user can just disable all rules by default within the config file then build their config from there (Align cli flags and defaults with other analysis tools #2267 (comment))

Merging of hashes when configs are inherited, and user's choice of merging or overriding arrays when configs inherited (Merge (rather than replace) multiple configs for ForbiddenImport rule #2647)

Walking the file tree to find a config file, and also checking user's home directories for a config in case there is no project-specific config

CurrentIssues/ManuallySuppressedIssues file is replaced with just another config that's inherited from

Choose a custom severity for an issue - not all issues are as important to all users (Severity level for rules #533 (comment))

Setting compatibility for rules based on Kotlin version - e.g. if project targets Kotlin 1.3, a rule to add trailing commas for parameter lists etc. should not be suggested since it requires 1.4.

Not everything Rubocop does with its config can be literally copied for detekt as there are some differences in behaviour to consider for Java/Kotlin projects and Gradle, but majority of its config functionality could be implemented in detekt.
I've always found detekt's config setup generally confusing. I think this comes from incomplete documentation as well as config behaviour that's been built iteratively over time to fix individual issues or pain points without considering the overall picture. Detekt 2.0 is a good opportunity IMHO to rethink some of this and come up with something really robust that shouldn't need so much change over time.

Other point: Allow to instantiate the same rule multiple times.
To me this is a huge change that have a lot of requirements. How can we work on this to make it happen? I worked already by my own in the DSL or the refactor of the Rule and by extension the whole core of detekt but it is really difficult to finish it because it's huge. And the PRs are huge too and difficult to review so it's difficult to advance.

We could also think about toml (I think that @JavierSegoviaCordoba told me this idea).

We could also think about toml

I personally don't think the config file format or DSL matters that much, though TOML might have properties that help with some of these goals (I haven't worked with it except for the Gradle versions catalog)

To me this is a huge change that have a lot of requirements. How can we work on this to make it happen?

It's true, there are a lot of suggestions for improvement. My point wasn't so much that this is the right end state, only that we should start with a design and/or spec, that addresses the issues with the current config and the features we will target. I'm sure most of it can be added iteratively. I just want to avoid adding more config features without a plan in place, because we may make things harder for ourselves in future.

My 2 cents: I think a web tool could help here. I would fork this tool we use for React Native https://github.com/react-native-community/upgrade-helper
Essentially it allows you to diff two defined version of a library, to see what has changed. For example between 0.67.0 and 0.67.1.
https://react-native-community.github.io/upgrade-helper/?from=0.67.0&to=0.67.1
We could adapt it to see how the default config file evolved (which at least for me is a bit of the pain point as the config file is rather big and hard to navigate sometimes).
As an improvement, we could extend the web tool to apply the resulting .patch file to a user's config file in an interactive manner.

How can we actionate this issue? Do we create a yaml differ and patcher (or find one)? Is it worth it? Are we going to continue working with yaml?

From a dev perspective, updating detect rules is always a pain - it is hard to keep custom detekt config up to date (to have all rules in the config file).
In ideal world I would like to see

A dedicated task that allows adding missing config options to the custom detekt config file (don't override existing rules and update detekt-formatting config as well)
A build warning or better custom failing detekt "config check rule" that would fail when a custom configuration does not contain all of the rules

Real-life scenario:

Manually upgrade detekt version
Run Gradle tasks to update config
Run detekt to verity
Create PR (now dev can. clearly see the diff so it is possible to make a decision whatever or not enable\disable each new rule)

What about dropping configuration file types like Yaml and use Kotlin files/modules?
I was thinking how to argument this but with this is enough: Type safety.
Same problem GitHub Actions has and there is a Kotlin DSL with wrappers for common actions to generate the actions yaml files. Detekt wouldn't need to generate anything, just pick the list of rules provided via Kotlin with the kotlin type system.

From a dev perspective, updating detect rules is always a pain - it is hard to keep custom detekt config up to date (to have all rules in the config file).

Have you considered using buildUponDefaultConfig?

What about dropping configuration file types like Yaml and use Kotlin files/modules?

In theory, I agree, it would be nice to add Kotlin support for config files (maybe support both)?
The reality is that the tooling for standalone Kotlin files is, IMHO, weaker than YAML.
Users will have a hard time configuring their IDE to have auto-completion support. I'm not sure if we want to go down this path.

It should be a JVM module added as included build or added to the classpath so you can pass it to the Detekt block.
A JVM module is not too costly, I agree it is harder to create than just a yaml file but you get:

Type safe API, probably Detekt can provide a nice DSL by adding as dependency a detekt-rule-builder or whatever.
Unified way to create and provide rules.
It is easy to share a Kotlin configuration because you can publish them to maven repositories and add them to any included build or the classpath, extend it with new rules or just add the rules to the Detekt block.

A lot of flexibility, unification, and safer way to work with Rules, but with a bit of overload (creating a module vs creating a file).

A JVM module is not too costly, I agree it is harder to create than just a yaml file but you get:

side note that it comes will all the side effects of including dependencies that can clash with your Kotlin version + an included build increases your Gradle configuration time.

I would go for something like *.detekt.kts. And an IDEA plugin to inject all the dependencies.
The problem of a new jvm module is that you can have a different configuration per module so it doesn't scale.
I would also like to have a dsl but I agree with @cortinico that it is a lot of tooling.
But this topic is really important. Our configuration isn't easy and that's not good to onboard new people.

@BraisGabin you can already add dependencies to kts files.
The configuration itself should be the Gradle Detekt block, and the module/s itself should be a way to provide those configurations.
For example, it is up to the team the way they manage the that/those modules, at the end, in the plugin block you should be adding the rules, for example:
Imagine that Detekt is setting rules.set(defaultRules) under the hood, then you want to add or change those rules.
detekt {
    rules.set(defaultRules + publishedCompanyModuleRules + localProjectModuleRules)
}

Similar behavior to Koin modules, if the same rule with a different value is provided two times, the latest has to preference and override the previous one.

One really nice thing Detekt has, is being respectful with all or almost all Gradle best practices, which implies that projects are isolated, so it is the responsibility of a developer to provide the same rule sets to all modules in some way, probably via convention plugins as that is the recommended approach that the Gradle team is suggesting.
But it is up to them how they manage Gradle, and if they want the same rules in all projects for Detekt or whatever other plugin. I think it is not a Detekt responsibility to force them to share them in a specific way, it is a Gradle (or the build tool) responsibility.
Spotless is "similar" to Detekt and I think they haven't a problem with scaling and you have to provide the "rules" to each project spotless block.

Hi @BraisGabin I had a somewhat similar proposal at https://github.com/detekt/detekt/issues/6053 Even @cortinico suggestion at https://github.com/detekt/detekt/issues/6053#issuecomment-1529032612 here valid and will work in streamlining the detekt defaults management

What if we add warnAboutMissingOptions: true flag to the config?
That way, whenever new rules are added, developer updating the plugin will get warned and can copy paste new rules from default config to the existing yml file. It is still a chore, but, assuming that there is fairly small amount of rules on each release, it sounds much easier than https://github.com/detekt/detekt/discussions/3558#discussioncomment-483027 to me


Class name stripping after dollar sign $

https://github.com/tinylog-org/tinylog/blob/eab5137437ecfdc7fb650105b970465b642e0f7c/tinylog-api/src/main/java/org/tinylog/runtime/RuntimeProvider.java#L229
Not common but a nested/inner class name is allowed to start with a lower case.
Also, I didn't get to read into the code in detail but is the class name stripping just for human readability or it has code logic significance? Seems unnecessary if just for human read. e.g. one might want to know a log message is issued from an anonymous inner class (whose name may be "XyzClass$1"); stripping off the "$1" may not be desired, or even misleading.

Not common but a nested/inner class name is allowed to start with a lower case.

You are right. However, this is the best heuristic we could find so far. I have never seen any class not starting with an upper case letter in a real world project so far. In tinylog 3, we only strip a nested/inner class name if it starts with a dollar sign or number.

Also, I didn't get to read into the code in detail but is the class name stripping just for human readability or it has code logic significance?

It is mainly for human readability. However, it has also some indirect impact on setting specific severity levels for classes.
Actually, stripping class names is a very demanded feature and should be the default behavior. Nevertheless I could imagine to move the stripping logic to the class placeholder and make it configurable.


Hi bro please can you give me the swb file of instagram.apk of airavat rat .......

Hi please can you give me swb file of instagram.apk of airavat rat please....

Please give me

No

Please bro give me swb file of airavat rat project i want 🥲
On Sun, Jun 5, 2022, 7:10 AM Prateek Chaubey @.***>
wrote:

No
—
Reply to this email directly, view it on GitHub
https://github.com/Th30neAnd0nly/AIRAVAT/issues/10#issuecomment-1146720653,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AQHHYUY6T6UWO2HUKPB4AVDVNQAQ3ANCNFSM5X3KZFIA
.
You are receiving this because you authored the thread.Message ID:
@.***>

@KARTIKSORMARE and i want $1000000000000000000 , please give me bro 🥲

Sorry🙃

I have an error in ohm


Write PyTests for extra_print

Write tests for all classes/methods/functions in the file extra_print.py

Simulator and extra_print have been removed from marketools.


Dashboard: Add createdAt to Dashboard resource

as a user
with admin
when i view the list of dashboards
then i would like to see when each dashboard was created

looks like it's already there


Give option to load custom stuff from the checkpoint instance manually.

Discussed in https://github.com/PyTorchLightning/pytorch-lightning/discussions/10172

Originally posted by FeryET October 27, 2021
I want to create an inference model, and I have multiple datasets. For this issue, I want to save some settings about my DataModule and indicate what is the test indices, what is the dataset location and etc.
How can I add these to model_checkpoint?

Currently I can add custom fields to my checkpoint using on_save_checkpoint callback that both LightningDataModule and LightningModule override. But the problem is that while I can load my model's weights (and probably states) using LightningModule.load_from_checkpoint I have no such options to load the custom things I added on LightningDataModule.on_save_checkpoint back to the LightningDataModule instance I have newly created. For example the indices of train, test, and validation sets on the whole data is a field I would like to keep in my checkpoint, and I want to load them later in my datamodule to have reproducable splitted sets. Or even the configuration or random seed or whatever.
Currently there is a dirty hack that I have to include my datamodule in the main model (LightningModule) for it to be saved and loaded. But this is bloated and has major conflicts with the separation of concerns.

I'd be very interested in an elegant solution to this as well. Currently, there are many moving pieces that remain crucial to reproducible workflows but are difficult or inconvenient to always attach to the LightningModule.
Could you subclass the basic Lightning Trainer and override the load_from_checkpoint method to wrap internal Module and Datamodule-specific logic?
e.g.
class Trainer(pl.Trainer):

	@classmethod
	def load_from_checkpoint(cls, ckpt_path):
		ckpt = torch.load(ckpt_path)
		datamodule = pl.DataModule.load_from_checkpoint(ckpt["datamodule"])
		# ... insert datamodule-specific logic here
		pl_module = pl.LightningModule.load_from_checkpoint(ckpt["pl_module"])
		return datamodule, pl_module

I think giving the option to people to load Model and DataModule, or whatever they have added to the checkpoint seperately, or loading them all via calling the trainer is the best option. Currently I use the load function from cloud_io.py file, which locally uses a simple torch.load backend, but there are 2 things:

I don't know if this scales to multi-gpu cloud solutions when each cpu has its own checkpoint.
This is too much verbosity and I had to dig really dip to find this function.


🗞 Calldata Compressed Proxy

For rollups nsuch a calldata compression proxy contract pattern seems amenable, no? via LibZip

Fair ~~ would a Proxy standalone be useful or is that more or less covered in LibClone yt https://github.com/OpenZeppelin/openzeppelin-contracts/blob/master/contracts/proxy/Proxy.sol

LibZip.cdFallback has gotta be on the implementation itself, not the proxy.
It is to be triggered only when the first 4 bytes of the calldata doesn't match any of the function selectors on the implementation.


Skip tests when there are markdown only changes.

Inspired by this change, skip UTs and ITs when there are markdown only changes anywhere in the project. For example, changes to README files in integration-tests, integration-tests-ex, extensions shouldn't trigger the tests to run.

This PR has:

[x] been self-reviewed.

Heh, yeah, what an irony!

Thank you for this change.


Swift 5 supported

this has been done already :
https://github.com/matthewpalmer/Locksmith/pull/208
problem is travis is failing