Custom toolbar and iPad

Hi,
Does the custom toolbar work on iPad Safari?
I tried this sample:
https://openseadragon.github.io/examples/ui-toolbar/
and selected full screen and the toolbar disappeared.
thanks in advance!
Darryn

Good catch! This is a subtle one.
iOS Safari doesn't have a true full screen mode, so we just fill the page with our content when you hit the full screen button. If you haven't scrolled the page before hitting the full screen button, everything works properly and you can see the toolbar. If you have scrolled the page, however, the browser's own toolbar (with the URL bar and other buttons) has shrunk down, but for some reason when you hit the full screen button it springs back to its full size. Meanwhile, the OSD viewer has resized itself to the full size the window had before the browser's toolbar grew back to full size. The result is that the OSD toolbar is scrolled up under the browser toolbar. You can verify this by tapping on the clock at the top of your iPad screen; this will scroll the top back into view.
A quick fix would probably be to force a scroll to the top a little after the full screen transition (to give the browser's toolbar a chance to grow). You could probably do this in your own code.
Of course ideally we should fix this issue in OSD itself. That would happen somewhere in setFullPage, starting around here:
https://github.com/openseadragon/openseadragon/blob/master/src/viewer.js#L901
Things to explore:

Why does the browser toolbar pop back to full size? Presumably that's in response to us changing the document/body size. Is there some way to work around this?
If the browser toolbar pop is unavoidable, how can we detect it's happening and reset our size to match? It may be as simple as a setTimeout, although it would be interesting to know if we get a resize event in this situation. At any rate, hopefully if we update our size at that point everything will work out.
Failing that, we could at least force a scroll to the top in the OSD code, perhaps after enough of delay for the toolbar pop to happen.

Would you be up for investigating a possible fix?

I'm also working on this bug that also affect mobile, I think there was another thread on this same subject that was closed but I will comment on this one instead of opening a new issue.
It was not easy to figure out what was happening first as desktop safari is crashing when I try to connect to my testing device but I eventually figured that there was kind of a scroll (as if the size of the toolbar was ignored in size calculation?). I was also able to see in other implementation that things where working fine with Openseadragon UI within OpenSeadragon.
I was able to hack a first level of correction (instead of full disable of the fonctionnality) by forcing the style of the toolbar to absolute + a z-index and the same for OpenSeadragon, so the the toolbar. It works but when doing a reset of the view the image can be displayed under the toolbar and there is empty zone at the bottom (space lost by using absolute after the calculation was done with relative positionning).
It's usable but you do lose the screen estate from the false fullscreen and the display of the url and IOS toolbar at the bottom.
I tought that I could force a bigger content zone and set the scrolltop (and I have seen other people try to work things like that but it does feel like a huge hack. I was not able to get it working, I will probably have to manipulate the nodes to have another level of container instead of the current one :
body
toolbar
openseadragon
But maybe this will break openseadragon calculation.
Not sure if it's worth the effort if there is the possibility that other events could bring the UI back (tapping at the top by ex?).
It would be nice to have a more sane way to implement fullscreen on IOS but the incomplete fullscreen is still better that our default view (with all our apps headers and menus).

Glad to hear you're making progress on this. Have you been able to find a way to detect when it's happening? Unfortunately I haven't heard of anyone else digging into it further... hopefully someone will respond!

It's possible that I wont get the point of having a correction that could be added to OpenSeadragon, but I will share what I find that could be useful.
I have found an article about other projects having issues too with the IOS behavior : https://www.eventbrite.com/engineering/mobile-safari-why/
I have read in another thread that the change should trigger a resize event but I'm not sure if there is currently a Handler in OpenSeadragon (search in code got nothing)for this, I will have to dig in the code further I guess to understand how resize is handled (should be similar to orientation change).
Currently I'm try to get Firefox IOS debugger to work (http://syntaxwarriors.com/p/17/Debug-Safari-on-iOS-using-Windows-10-and-Firefox) and hopefully get a some more cues of what I can to do get it to work more nicely (even if it is with incomplete fullscreen, with url and toolbar always visible).

The setup with "Valence" seem to work fine (http://syntaxwarriors.com/p/17/Debug-Safari-on-iOS-using-Windows-10-and-Firefox) but there is a bug :
I have to use the option "Chrome Desktop" in Firefox WebIDE instead of "Safari, Firefows and other WebViews on IOS" to get the tab listed to the right. I tought it was connecting to Chrome IOS (would not be usefull as the UI is not working the same) but I closed the application and it really connected on Safari.
What I did:

get x64 proxy
Installed Itune and started it
Did some app retart and reconnect and restart of the proxy and eventually saw:
Listing devices on :9221
Connected :9222 to Touch 2 (dad30eee24423c2be5ee852257771b3188302e0b)

I can see the remote DOM now.

I have the impression I was looking way too far.
It looks like Openseadragon take 100% of the height and doesnt account for the height of the toolbar.
If I manually set the height of OpenSeadragon to the it's height minus toolbar height, I get a state that is good enough (with the adress and toolbar but clicking in the view doesnt set a scroll (having the same value as the height of toolbar) that push the toolbar out of view.

So the base external hack (it's really context specific) I have looks like this:
var _setFullPage = function (event) {
    if (event.fullPage === true) {
            $( ".openseadragon-container" ).height($( ".openseadragon-container" ).height() - $( "#toolbarContainer" ).height());
            $(document).scrollTop(0);
    } else {
        $( ".openseadragon-container" ).height("100%");
    }
};

I would have saved myself alot of headache if I had access to the debugger earlier!
The only thing that doesnt work so well, not directly related, is that when I'm in not scroll view, the first touch (focus?) on OpenSeadragon does a autoscroll... it looks like a bug but it's probably a browser behavior.

This is what I have to handle orientation change, that will probably good enought for our need, I will have to test on Android if this work.
var _setFullPage = function (event) {
    var fullPageResizeViewerDelay = 0;
    var fullPageResizeHandler = function() {
        setTimeout(function() {
            var bodyHeight = document.body.offsetHeight;

            $( ".openseadragon-container" ).height(bodyHeight - $( "#toolbarContainer" ).height());
            $(document).scrollTop(0);
        }, fullPageResizeViewerDelay);
    };

    if (event.fullPage === true) {
        window.addEventListener("resize", fullPageResizeHandler);
        fullPageResizeHandler();
    } else {
        $( ".openseadragon-container" ).height("100%");
        window.removeEventListener("resize", fullPageResizeHandler);
    }
};

The timer is probably not required but I had a few "missed" change where I have the same bug of the custom toolbar disapearing offscreen.
I have read about the hacks that could be done to force a scroll (and "real" fullscreen") but I'm not sure it is worth the effort (read pain) for me as the UI is at the top that is also the trigger zone for making the IOS UI reapear.

The solution is working fine on Android except that the message that Android is displaying is not making much sense, something like "swipe up and down and then click back to exit fullscreen".
I tought it would be in conflict with OpenSeadragon own gesture handling but the back button seems to work anyway (and it's possible to exist fullscreen using the toolbar button).

Wonderful... thank you for documenting your progress! This seems like it will be quite helpful to anyone wanting to make a patch for OpenSeadragon.

Had to get back to this one. I had a regression where clicking in OpenSeadragon the first time when in fullscreen would hide the toolbar.
We have fixed it by playing with z order but it's not working well because then the viewer is under the toolbar and the recenter button doesnt work as expected.
I think that the problem that we have is that the toolbar is outside OpenSeadragon view and the calculation of OpenSeadragon is done to take all the space with the widgets inside the view.
I guess I will have to dig in the code further to see if I can modify the calculation.

Thank you for the update... let us know what you find!


Support for bluetooth rtl8761 based devices

I have got an amitosai mts-bt5 bluetooth dongle which uses the realtek rtl8761, gamer-os don't recognize it.
It works after install this AUR package, tested on my personal machine with Arch.

Firmware is already present on newer versions. Could you test that? If is still not working for you, please comment and we will reopen the issue.


Bug: Footer should be updated

Footer is looking boring and also there should be icons for discord ,github and hover effects could be added

I want u to assign this issue to me under gssoc

I want to contribute to this project so please assign this to me,

I would like to contribute for this project. Please assign this task to me under GSSoC'24 with required labels.


{Active: Failed} Tried to run debug but ImportError:No module named parse

Your hardware platform and model you are running on:
Hardware : RaspberryPI 3 model B rev 1.2
Python version : 3.5.3
Description of problem:
I install AlexPi on opt then check the status by run sudo systemctl status AlexaPi.service
I got : ● AlexaPi.service - Alexa client for all your devices
   Loaded: loaded (/usr/lib/systemd/system/AlexaPi.service; enabled; vendor preset: enabled)
   Active: failed (Result: exit-code) since Mon 2019-04-01 07:26:14 EST; 1h 2min ago
     Docs: https://github.com/alexa-pi/AlexaPi/wiki
 Main PID: 488 (code=exited, status=1/FAILURE)

Apr 01 07:26:09 raspberrypi python3[488]: ALSA lib conf.c:4996:(snd_config_expand) Args evaluate error: No such file or directory
Apr 01 07:26:09 raspberrypi python3[488]: ALSA lib pcm.c:2495:(snd_pcm_open_noupdate) Unknown PCM bluealsa
Apr 01 07:26:09 raspberrypi python3[488]: connect(2) call to /tmp/jack-999/default/jack_0 failed (err=No such file or directory)
Apr 01 07:26:09 raspberrypi python3[488]: attempt to connect to server failed
Apr 01 07:26:11 raspberrypi python3[488]: INFO: Checking Internet Connection ...
Apr 01 07:26:12 raspberrypi python3[488]: INFO: Connection OK
Apr 01 07:26:12 raspberrypi python3[488]: CRITICAL: AVS refresh_token not found in the configuration file. Run the setup again to fix your installation (see project wiki for installation instructions).
Apr 01 07:26:14 raspberrypi systemd[1]: AlexaPi.service: Main process exited, code=exited, status=1/FAILURE
Apr 01 07:26:14 raspberrypi systemd[1]: AlexaPi.service: Unit entered failed state.
Apr 01 07:26:14 raspberrypi systemd[1]: AlexaPi.service: Failed with result 'exit-code'.

Then I tried to run dubug by : /opt/AlexaPi/src/main.py -d
I got : Traceback (most recent call last):
  File "/opt/AlexaPi/src/main.py", line 23, in <module>
    import alexapi.tunein as tunein
  File "/opt/AlexaPi/src/alexapi/tunein.py", line 10, in <module>
    from urllib.parse import urlparse
ImportError: No module named parse

PS : Thank you .w.

Same here... manually installed dependencies until I got to a point there are some that although installed it is still reported as missing

Hello,
it seems you didn't run the install script/correctly followed the installation process.
Please follow: https://github.com/alexa-pi/AlexaPi/wiki/Installation

did you guys fix it somehow? having the same error


Pre-rendered card support

[ ] fix deprecations

The ember deprecation warnings emitted by fastboot are very noisy, perhaps there is a way to silence those so we can monitor our server logs?

ugh--the tests have slowed waaaaay down. mostly because we do an ember build to make the dist for fastboot which adds an extra 5 min(!!)


Gradle 4.8 no longer considers versions equal when using dependencySubstitution and failOnVersionConflict

Expected Behavior
Depending on both a sub-project  and something which is substituted to the same sub-project triggers a failure when the configuration is configured with failOnVersionConflict. This only happens with Gradle 4.8.
Current Behavior
The dependency resolutions should succeed just like in 4.7
Context
The [elastic/elasticsearch] build uses failOnVersionConflict and substitutions to be able to build some sub-projects (also) stand-alone.  We encountered this issue trough a chain of transitive dependencies, much less obvious than the example below.
Steps to Reproduce (for bugs)
git clone git@github.com:atorok/gradle4.8_dependencySubstitution_failOnVersionConflict_reproduce.git
./gradlew assemble

this fails with:
* What went wrong:
Could not determine the dependencies of task ':compileJava'.
> Could not resolve all dependencies for configuration ':compileClasspath'.
   > A conflict was found between the following modules:
      - gradle_test:sub1:0.0.1
      - gradle_test:sub1:0.0.1

Your Environment

https://gradle.com/s/n2eopjnp2bx5a fails with 4.8
https://gradle.com/s/rkmntk62zdyow works with 4.7

Thanks for the report and reproducible test case.
Looks like some refactoring around dependency management made a shortcut disappear which was handling modules having the exact same version.


Revert "Roll Engine from bf259226b224 to e66a720137d9 (3 revisions)"

Reverts flutter/flutter#69857
Back button is broken on Android
flutter_gallery__back_button_memory_4bd89b3_2 (2).log

TBR @cbracken


Update CONTRIBUTING.md

fix capitalisation of:
** "Core Contributors"
** "Technical Team"

just spotted an outdated section on TravisCI thus converting to draft

can't find what I was wondering about with that, please proceed with reviewing

found it rephrased it to match the current GitHub Actions CI.

Sorry, thought that I had pushed the merge button :/ Thanks for the update.


Update to current sCASP once it works in MQI

BlawxBot is not working properly in v1.3.20-alpha, evidently because of existence errors that are being thrown by SWIPL when input predicates are not defined in the code.

I have tried throwing some try/except code into the reasoner similar to what is done for the run test endpoint, but that has not solved the problem. Will need to come up with a more permanent and less kludgy solution before the release will work properly.

Checked today, and there have been no updates to the code or the forum. Added an issue to GitHub repository for MQI.

MQI developer confirms that a fix to cause MQI to throw warnings, not errors, when it receives blobs, will come through next week. SWI-Prolog developer suggests there is an source(false) flag that might be available in the s(CASP) library that would prevent s(CASP) from trying to return the blobs. That should be the first thing to try.

The source(false) option has been added to scasp/2 in the latest version of the scasp library, now. Need a PR that adds that feature and ends the version pinning.

Resolved in #405


Sql api platform limits notification

This PR fixes #12597.

This PR improves the SQL notification, to inform the user about that scenario. It introduces a couple of helpers to deal with locales, that could be helpful in other places.
Also, this fixes an infinite loop when the query models fail to fetch and the user enters in the style panel. To deal with this, every of those models has a threshold of 3 failed requests in a row before to stop making requests.
Those models are pretty important in the app, so besides the limit notification, their behavior should be tested deeply. In order to test the limit notification, execute these queries at psql level: https://github.com/CartoDB/CartoDB-SQL-API/blob/master/test/support/test-client.js#L110-L140

Limits error works like a charm:

But I found out this:

Seems like the key should be notifications.sql.unknown

I've realized another thing, debugging the unknown problem (because I tried to fix it and failed) I found out that we are showing a message:

Then getNotificationMessage it's called and tries to find a message for the 400 status code, and it returns nothing, falling back to the unknown error which gives less information that we had before.

Please.

Any acceptance criteria for the infinite loop thing?

Make the query to fail and enter in the style panel. Eventually the
requests stop.
El 10 oct. 2017 9:12, "Javier Álvarez Medina"<EMAIL_ADDRESS>escribió:

Any acceptance criteria for the infinite loop thing?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/CartoDB/cartodb/pull/12916#issuecomment-335382038,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABTbOzJLjiUzAhQ913-hN5gM7CRZkk_iks5sqxjSgaJpZM4PvEcD
.

Hum, it is not happening that, but I feel someone has overtaken my staging assets 😬 .

I've checked it again in staging and it is not working @nobuti. Try it in RUIs.

Is it in staging?

Yep. Ruis.

Special :k:

Ole, infinite loop working, testing rest of the things, thanks @nobuti 💋 .

Deploying to DED15 in order to check proper limits. 💃

👏 👏

Uhm, we have found a weird scenario:

Create a map with a layer of points (populated places is ok).
Go to the DATA tab, add two histogram widgets and a category one.
Then go to the SQL panel.
Add a LIMIT 1 to the query and apply it.
Clear the query.
Then apply again another query, adding LIMIT 10 to the end and apply it.
Map is not refreshed.
If you apply another query changing the limit, the applying query... message doesn't disappear and map is not refreshed either.

(No JS itself)

How is this related to this issue?

Not sure if it is related, but let me check if it is happening in production too.

It is not happening in production. Let me deploy it again in staging and check it.

Could you try again @xavijam? I didn't deploy it to ded15 because I wasn't sure you were still using it.

Tried again, and working as expected, 👍  🔝  🥇 .

I'll make the whole acceptance again, just in case 💋 .

All frontend checks passing, backend is not needed, so 🚀 .


Auto optimize

Does it auto optimize images on upload?
The console command is working, but if I upload a new image, the image is not optimized.

Hi @dev-ea ,
It should auto optimize. Let me check it for you, maybe something is changed in the releases of magento 2.2.6


Modal height with no results bugs out

Seems like the user results are being calculated but not being shown...? Not sure why else it would get smaller when you put text it

fixed this


Zooming and camera does not move on mouse move

On this example https://codesandbox.io/s/r3f-sky-dome-forked-614gw?file=/src/index.js, does anyone know how to fix zooming on jpg since zooming does not work. Also, I wanted to ensure that camera moves on the mouse move, that is, if we move mouse pointer to the left then camera slightly moves to the left and so on.

issues for bugs and features please


Update Default.sublime-keymap

ctrl+n is used for jumping line in linux/osx env, it would be better to allow users to choose the shortcut key.

I don't really agree with letting the user choose it's shortcut. Although it sounds good, when you install a package, you just want it to work, you don't want to have to configure before using it.
What about alt+n to create a new file?

Yes, it  is much better than ctrl+n, since terminal-like shortcut is a convinient way for mac os users to move up/down lines without installing vintageous.
Alt+n will type ˜ in Mac OS, I do not know others' opinion, I never use this combination to type this special character so I have no objection with this change. Thanks.

Ok, I don't have a mac, and I'm really confused about the modifiers...
Do you the equivalent of ctrl, alt, shift of window on mac?

on mac, there are four modifiers... shift, ctrl, cmd(refer to super) and alt. ctrl is for terminal modifier and cmd is for GUI modifier, while on windows, ctrl does everything. When I switch to Mac, it also costs me a bit time to adapt this new set of short-cut keys.
For example, ctrl+c/v is for copy/paste under windows, but since it is GUI operation, the corresponding shortcut on mac is cmd+c/v.
By the way, are you planning to add a "new folder" command? that would  be very helpful.

Thank you for these infos.

By the way, are you planning to add a "new folder" command? that would be very helpful.

No I don't. If you want to create a folder, just choose New, and finish your path with a / (for example, ~/mynewfolder/. Did you know this, or you're expecting something else?
So, what are you going to choose as a shortcut to fm_create, if you do?

Thanks! So the function of "creating a folder" has been implemented. I did not realize it before.
as you suggested, "alt+n" is fine for fm_create.

Ok, then it's going to be alt+n. Have a look at the wiki, I'm going to post some tips on the create command.

I've change the shortcut, it's now alt+n.


Doku - improvements

While trying to upload several Datasets via the API on the SEDOS Project I faced some issues that possibly could be fixed by a improved dokumentation/description and examples:
Metadata

[ ] It should be mentioned how Name and Shema and what they do (Giving the Name to the Metadata on the OEP and defining where it is saved)
[ ] List available data types and how they should be formatted in the csv
[ ] Harmonize datatype names in examples and doku (sometimes integers are called int and text is called string... ) Maybe a larger set of accepted data types would also be a handy solution?
[ ] Metadata must contain "@context" to register on Databus and be SPARQL-able contain:
"@context": "https://raw.githubusercontent.com/OpenEnergyPlatform/oemetadata/master/metadata/latest/context.json"

CSV files:

[ ] Formatting information for data types with an example maybe:

dtype
csv formatting example
comment

json
"{""key1"": ""text"", ""key2"": ""text""}"
csv seperator should not be "," , keys as text, what happens to floats?

float array
[float, float]
arrays with strings should be formatted as strings ("['string1', 'string2']"

text
"text"
String data should have text as datatype

integer
integer
int data should have integer as datatype

Databus:

[ ] Create user ondatabus (what are they?)
[ ] Generate API-key on Profile->settings  at bottom of page
[ ] "Databus Account Name" reffers to profile name on Databus (not e-mail adress)

Thanks for collecting the documation improvements. Maybe start a new branch from develop, e.g. feature-10-improve-docs and push your commits there. Then someone can review your changes once you finished implementation.


chore(components): reduce concurrent workers in testing

Overview
Github action provides a "2-core CPU" runner for tests. Stencil uses 8 workers by default, which might cause some issues. So we are reducing the max workers limits to 2.
And this change does not increase the execution time for local testing. It even reduces the total running time.
2 workers:
> time npm run test

><EMAIL_ADDRESS>test
> stencil test --spec

[02:46.3]  @stencil/core
[02:46.5]  v2.17.4 🐞

[ WARN  ]  Build Warn
           dist-custom-elements-bundle is deprecated and will be removed in a future major version release. Use
           "dist-custom-elements" instead. If "dist-custom-elements" does not meet your needs, please add a comment to
           https://github.com/ionic-team/stencil/issues/3136.

[02:46.7]  testing spec files
[02:46.7]  jest args: --spec --max-workers=2
...
Test Suites: 12 passed, 12 total
Tests:       32 passed, 32 total
Snapshots:   0 total
Time:        7.306 s
Ran all test suites.

npm run test  13.58s user 2.64s system 174% cpu 9.316 total

default 8 workers:
> time npm run test

><EMAIL_ADDRESS>test
> stencil test --spec

[03:42.1]  @stencil/core
[03:42.3]  v2.17.4 🐞

[ WARN  ]  Build Warn
           dist-custom-elements-bundle is deprecated and will be removed in a future major version release. Use
           "dist-custom-elements" instead. If "dist-custom-elements" does not meet your needs, please add a comment to
           https://github.com/ionic-team/stencil/issues/3136.

[03:42.4]  testing spec files
[03:42.4]  jest args: --spec --max-workers=8
...
Test Suites: 12 passed, 12 total
Tests:       32 passed, 32 total
Snapshots:   0 total
Time:        8.512 s
Ran all test suites.

npm run test  28.37s user 6.01s system 329% cpu 10.446 total

My guess is creating a worker consumes more time.
Legal
This project is available under the Apache 2.0 License.

It looks like Jest defaults to the number of cores on the machine - https://jestjs.io/docs/cli#--maxworkersnumstring
For example, in your other PR it seems to run with 2 workers already - https://github.com/awslabs/iot-app-kit/actions/runs/3176518397/jobs/5175910316


ux: changed color of pending status icon

Changed from green to gray. The reason behind this is that green
is usually associated with a success operation and gray is a
more neutral color that doesn't add much meaning.
This change was a quick suggestion from Cynthia when I showed her Velum.
before

after

Heads up for @kravciak, this might break openQA.


DSD-1138: Adding isClearable prop to TextInput component

Fixes JIRA ticket DSD-1138
This PR does the following:

Adds an isClearable prop to the TextInput component. This adds a "close" button that renders above the input field on its right side.
When set to true, the button will be set to render once the user types in any value.
When the close button is clicked, the value in the input field will be cleared and the button is removed.
Had to add internal state to the TextInput to keep track of the input value and also make it a "controlled" component since it will always need an onChange function to keep track of the state changes.

How has this been tested?
Locally.
Accessibility concerns or updates

We cannot have any empty buttons so there is a hidden span with text. This allows the "text" buttonType to render appropriately. Otherwise, the other option is to add an aria-label to the button. The problem with the aria-label approach is that the "icon-only" type takes precedence and it's harder to override the button styles. To make it look closer to the Figma design, I added the span with hidden text and used the "text" type. @bigfishdesign13 let me know what you think and what the text inside the span should be after asking Clare.

Checklist:

[ ] I have updated the Storybook documentation accordingly.
[ ] I have added relevant accessibility documentation for this pull request.
[ ] All new and existing tests passed.

Front End Review:

[ ] Review the Vercel preview deployment once it is ready.

Ready.


skaffold vulnerabilities found in edge binary

@GoogleContainerTools/skaffold-team
Vulnerabilities were found in skaffold binary, please fix the issues.
Please make a patch release if the issues are in lts release.
Vulnerabilities details: see here.

Closing as the issue is tracked in https://github.com/ericzzzzzzz/kokoro-codelab-ericwork/issues/40


[DocC] Fix typo at docs/CppInteroperability/CppInteroperabilityManifesto.md

Fix typo at docs/CppInteroperability/CppInteroperabilityManifesto.md
This is just the updated typo, so it does not link to any issue.

@swift-ci please smoke test

@swift-ci please test


Now ci4 product development can be used? Or how long before they can be released? Very much looking forward

Now ci4 product development can be used? Or how long before they can be released? Very much looking forward

Glad to hear you're excited about CI4! But....It is not recommended to use it in production as it's still very much under development and in an Alpha state with portions that are not finished yet. We don't have an exact time frame for release, but my guess is early Spring.

If used for project development, is not the latter part of the impact will not have api changes

Now is the end of the three stages of ci in the first few stages of it

I cannot say whether there will be API changes or not. But there are surely security issues and bugs...

When is it expected to release? Can be released in January next year

Probably longer than that. I wouldn't start a new project on it, personally.

Can I take part in the development of Ci

It's an open source project, so absolutely. Make sure to read the Contributing to CodeIgniter section of the user guide first. And take time to get familiar with the new code. Then look for topics that have the label "help wanted" and start pitching in.

CodeIgniter4 Roadmap - Phase 2 When can I expect to finish?

@yuchonghua This is a forum topic, NOT a github issue.


Manage the project XFails under a different job type for the stress tester

Currently we’re in a state again in which some project succeed to build in the stress tester CI job but fail to build in the source compatibility suite CI job (rdar://82333521). We are thus mistakingly receiving UPASSes in the stress tester CI job.
To work around this, introduce the notion of job types to the source compatibility runner and its associated XFails. By default everything runs as the "source-compat" job, only the stress tester overrides the job to "stress-tester". That way we can selectively XFail jobs only for the stress tester in projects.json.
Since the stress tester now controls its own project build XFails, a project build failure will also cause a stress tester failure.
rdar://62080167

@swift-ci Please test

@swift-ci Please test

@ahoppen Can you also update the README with this info?

Sure: Opened https://github.com/apple/swift-source-compat-suite/pull/608


Pagination and Filtering for endpoints

This idea is from @dan0x09:
At the moment, we get a list of all users if the admin opens the user management configuration dialog. With respect to performance we should start to implement pagination as shown in the Gitlab API.
However, I do not want to clutter all potential endpoints of potential services with the same code. Maybe we can use a response filter or something else to limit (in this case) the list of users with respect to the passed query parameters.

Merged


Remove io.circe.auto._ from example in README

Replaced by import io.circe.generic.auto._

Current coverage is 54.32%

Merging #47 into master will increase coverage by +0.08% as of a5b57da

Powered by Codecov. Updated on successful CI builds.

Thanks, @groz! One thing—do you mind changing the line to import io.circe.generic.auto._ instead of deleting it, so that this represents a complete REPL session?

@travisbrown isn't it already imported on the first line?

@groz The idea is that that whole code section should represent a copy-and-pasted REPL session, so when you see this:
scala> sealed trait Foo
defined trait Foo

The second line is what the REPL prints after you enter everything after the prompt in the first.
The Scala REPL allows you to paste in a complete REPL session like this (it'll ignore the prompts and result lines), so using it in documentation has the advantage of both showing what will happen and being directly copy-and-paste-able.

Ah, understood. Thanks.

@groz Thanks again for catching this! Will merge when green.


It should not be possible to delete paths under /storages/${storageId}/${repositoryId}/.index directories in Maven 2 repositories

We need a test case that checks this.
If the test case proves that this is currently possible, then the required changes should be applied in order to disallow it.

@fuss86 , @sbespalov ,
I assume this should be covered using Spring Security, or is there another way?

@ptirador ,
Is this something that you could maybe pick as one of your next tasks?

@fuss86 / @sbespalov : I assume this is now obsolete, right?

Why so ? :) We will still provide packaged index to download, right ?

Ah, you're right!


improve(filesystem-hadoop): support path without scheme for gvfs api

What changes were proposed in this pull request?
It will use the path without scheme in tensorflow. This MR will support the path without gvfs scheme.
https://github.com/tensorflow/io/blob/master/tensorflow_io/core/filesystems/hdfs/hadoop_filesystem.cc#L618
https://github.com/tensorflow/io/blob/master/tensorflow_io/core/filesystems/hdfs/hadoop_filesystem.cc#L116
Why are the changes needed?

support path without Scheme for Hadoop API
#2860

Does this PR introduce any user-facing change?

no

How was this patch tested?

UTs pass

@jerryshao @xloya Please help review this MR when you have time. Thanks.

Overall LGTM, left a minor suggestion.

Is it the limitation of tensorflow? If so, how does tensorflow distinguish different filesystems?

Seems you don't create a related issue, please please create one and associate with this PR?

Seems you don't create a related issue, can you please create one and associate with this PR?

create issue #2860

Is it the limitation of tensorflow? If so, how does tensorflow distinguish different filesystems?

Yes. I added a description of the issue.
Tensorflow will parseHadoopPath after creating the HadoopFileSystem(GravitinoVirtualFIleSystem). After that, it will use the path that has no scheme prefix to invoke API.
void ParseHadoopPath(const std::string& fname, std::string* scheme,
                     std::string* namenode, std::string* path) {
  size_t scheme_end = fname.find("://") + 2;
  // We don't want `://` in scheme.
  *scheme = fname.substr(0, scheme_end - 2);
  size_t nn_end = fname.find("/", scheme_end + 1);
  if (nn_end == std::string::npos) {
    *namenode = fname.substr(scheme_end + 1);
    *path = "";
    return;
  }
  *namenode = fname.substr(scheme_end + 1, nn_end - scheme_end - 1);
  // We keep `/` in path.
  *path = fname.substr(nn_end);  // here, truncate the scheme prefix
}

 ParseHadoopPath(path, &scheme, &namenode, &hdfs_path);

  auto handle = libhdfs->hdfsOpenFile(fs, hdfs_path.c_str(), O_WRONLY, 0, 0, 0);   // here. the hdfs_path has no gvfs:// prefix

@jerryshao @xloya I have fixed. Please take a look. Thanks.

@jerryshao Github CI is passed. Please help review this when you have time.  Thanks.

Just one minor issue, @coolderli can you please clarify it?


RFP - bomi

bomi is a multimedia player formerly known as CMPlayer, which is aimed for easy usage but also provides various powerful features and convenience functions. Just install and enjoy it! There will be already what you expect. If you don't like, you can configure almost everything.
Downloads: https://sourceforge.net/projects/bomi/files/windows/

Abandoned.

Last Update: 2015-05-20


Node ordering

This commit attempts to solve the issue https://github.com/oxinabox/LayeredLayouts.jl/issues/12 to set the ordering of selected nodes.
This branch is also the updated version of previous #17 ; it is built on top of the pull request #16 where the tests are modified to accommodate optional arguments.

Codecov Report

Merging #19 (34b619a) into main (88117f5) will decrease coverage by 0.50%.
The diff coverage is 91.30%.

@@            Coverage Diff             @@
##             main      #19      +/-   ##
==========================================
- Coverage   92.72%   92.22%   -0.51%
==========================================
  Files           4        4
  Lines         165      180      +15
==========================================
+ Hits          153      166      +13
- Misses         12       14       +2

Impacted Files
Coverage Δ

src/layering.jl
95.91% <87.50%> (-4.09%)
:arrow_down:

src/zarate.jl
90.51% <100.00%> (+0.33%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 88117f5...34b619a. Read the comment docs.

@oxinabox Done; I also set the input type to be Vector{Pair}

Nice LGTM


material with textures in different UV map channels

Hi! I have a problem with processing material with textures in different UV map channels.
When I upload a model to the editor - https://modelviewer.dev/editor/
Everything is shown correctly!
But if I download files using the "Download scene" button and place them on my server, there is a problem with the display - https://arguv.com/ar_viewer/custom/0/bug/UV_map_channels/
3D model - https://arguv.com/ar_viewer/custom/0/bug/UV_map_channels/Sangens_W30S.glb
Can you tell me what the problem might be?

Hi, are you editing the model in the modelviewer editor? If you place the downloaded glb in model viewer editor again, does it show any difference?

Hi! No, I'm not editing the model in the Model viewer editor.
If I load the model again, there is no difference. It's still the same mistake.
As if the editor uses another library, not this one - https://ajax.googleapis.com/ajax/libs/model-viewer/3.0.1/model-viewer.min.js
I attached a link to the model, you can try it yourself.

By the way, if you return the old version of the connection with the files below, then everything works fine!

Here is the version with the previous script - https://arguv.com/ar_viewer/custom/0/bug/UV_map_channels_old/

It looks to me like the problem is that you're using v3.0.1 when the latest is v3.2.0: https://modelviewer.dev/


[python3, pybind11] Move Py_DEBUG to python, and use python from vcpkg

Alternative to #36585

This looks correct to me but poking other maintainers.

Please resolve the build failures on CI pipeline https://github.com/microsoft/vcpkg/pull/37758/checks?check_run_id=23861207594.


Add list of external resources to search_index

Description
As a developer, I want to be able to query the list of external resource names a model is linked to. The information should be in a new column in search_index.
Acceptance Criteria

[x] New column resources available in search_index
[x] New attribute resources in api/search_index endpoint.

Split column into raw_data_resources and cancer_annotation_resources as per conversation with Zina

@zperova done


Support macros when cross-compiling

Depends on https://github.com/apple/swift-package-manager/pull/7164.
Motivation:
Not supporting macros in cross-compilation is a major limitation, especially for libraries like https://github.com/apple/swift-mmio.
Modifications:
Added enum BuildTriple { case buildTools, buildProducts } and var buildTriple: BuildTriple on ResolvedTarget and ResolvedProduct. Corresponding value is assigned to this property depending on target and product type: buildTools for macros, plugins, and their dependencies, buildProducts for everything else (the default). Based on this property we can choose between buildParameters.hostTriple and buildParameters.targetTriple during build plan construction.
Result:
Resolves https://github.com/apple/swift-package-manager/issues/6950
Resolves rdar://105991372

@swift-ci test

@swift-ci test

@swift-ci test windows

What happens if we need to build a target for both triples?
Separately, it feels like eventually we have to resolve the idea that there is a singular destination triple since that doesn't actually match the reality on Apple platforms.

I don't have answers to these questions. This is a draft PR that doesn't fully work yet.

@swift-ci test

@swift-ci test

@swift-ci test

@swift-ci test

@swift-ci test

@swift-ci test windows

@swift-ci test

@swift-ci test

@swift-ci test

@swift-ci test

@swift-ci test

@swift-ci test windows

What happens if we need to build a target for both triples?

We build that target (or product) twice.

Separately, it feels like eventually we have to resolve the idea that there is a singular destination triple since that doesn't actually match the reality on Apple platforms.

Correct, and with separate buildParameters property on each build description type there are no more limitations in supporting that. "Just" need to assign build parameters correctly for each platform, in this PR we're limited only to two sets of build parameters though (tools and destination).

@swift-ci test

@swift-ci test

@swift-ci test windows

We could do an optimization when destination and tools build parameters are the same.

@swift-ci test

@swift-ci test windows

@swift-ci test windows

@swift-ci test

@swift-ci test windows

@swift-ci test

@swift-ci test

@swift-ci test windows

@swift-ci test windows

@swift-ci test

@swift-ci test windows


The example should include something that actually works in Kusto, i.e.

[Enter feedback here]

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 8d431578-4425-3bda-f5a5-1e048117893e
Version Independent ID: 26c98c8f-350d-f8cf-f1fc-fb764b6049da
Content: iff() - Azure Data Explorer
Content Source: data-explorer/kusto/query/ifffunction.md
Service: data-explorer
GitHub Login: @shsagir
Microsoft Alias: shsagir

Duplicate of #1294


Add grpc-dotnet to stable GKE benchmarks

Followup for https://github.com/grpc/grpc/pull/28975 (which added grpc-dotnet to "experimental" GKE benchmarks).

I looked at the history of the "experimental" job: https://fusion.corp.google.com/projectanalysis/summary/KOKORO/prod:grpc%2Fcore%2Fmaster%2Flinux%2Fgrpc_e2e_performance_gke_experiment and the grpc-dotnet benchmark scenarios seem stable.

Test failures looks like test infra problem (why do the jobs show up as "cancelled"?), unrelated to the PR.


test: with dependency_override at_commons to test changes made in at_…

- What I did
- How I did it
- How to verify it
- Description for the changelog

This PR will never be merged. has only been created to test integration with latest at_Commons in trunk


E: Package 'mesos' has no installation candidate for Ubuntu 14.10

Hello, I installed Ubuntu 14.10 server and I tried to install Mesos.  I did add the key and also the following commands, however, I still got the error which Ubuntu is not able to find the repo for Mesophere? I google and found the commands and steps are right, but just Ubuntu 14.04 is different than 14.10 which I use.
Any idea? Thanks for your answer
commands:
$sudo apt-key adv --keyserver keyserver.ubuntu.com --recv E56151BF
$echo "deb http://repos.mesosphere.io/${DISTRO} ${CODENAME} main" | sudo tee /etc/apt/sources.list.d/mesosphere.list
$ cat mesosphere.list
deb http://repos.mesosphere.io/ubuntu utopic main
error:
$ sudo apt-get -y install mesos marathon
Reading package lists... Done
Building dependency tree
Reading state information... Done
Package mesos is not available, but is referred to by another package.
This may mean that the package is missing, has been obsoleted, or
is only available from another source
E: Package 'mesos' has no installation candidate

hello, same error for me but with ubuntu 12.04. should i replace precise with the same(trusty)
Thanks

Hi @rv0147 There are mesos and marathon packages for precise available. Please make sure to check your /etc/apt/sources.list.d/mesosphere.list. It should look something like:
deb http://repos.mesosphere.io/ubuntu precise main

Then run an apt-get update && apt-get install mesos marathon


Add routes for retrieving account data

Original proposal: https://github.com/matrix-org/matrix-doc/issues/1339
This contains no known differences to what was ultimately decided upon and implemented.

Is an option to GET all of account data at once (https://github.com/matrix-org/matrix-doc/issues/1339#issuecomment-410401861) deliberately omitted?

Yes, they were deliberately descoped due to lack of feedback later on in the thread.


Bug-fixes and improvements.

First of, sorry for this being so "big" - but its actually small changes/fixes. There is no real code change, except for some additional 'const' and the fixes for the broken bindings/examples.
Most of the changes are documentation, and there will be more of that - as we trying to document all public APIs, using Doxygen.
Fixes #94.
This will be merged in on Friday the 31st, unless I hear otherwise :)
Changelog:
Fixed compile issues in Python bindings and examples, after introducing new init/configuration concept.
Consistently use csp_qfifo_write(), instead of a mix between csp_new_packet() and csp_qfifo_write().
Updated documentation.
Removed unused options from wscript, after introducing new init/configuration concept.
csp_conf_get_defaults() ensure all members are initialized (prevent valgrind errors).
Made API arguments 'const', where pointers are read-only.
Added csp_transaction2(), supporting socket/connection options.
Removed unused functions/defines: csp_new_packet, usart_stdio_msgwaiting(), csp_route_get_mac()
Added new Python bindings: csp_send, csp_sendto, csp_connec( rtable_check, rtable_load, peek, pooke, clock
Added internal csp_qfifo_wake_up() for testing purposes.
Added examples/buildall.py for verifying build with different options.

csp_transaction() has been changed to a static inline function in the header file csp.h - so its all compatible, no need for code change - but do require a re-compilation.

Renamed csp_transaction2() to csp_transaction_w_opts().
Branch merged into release-1.6.


[Help] Pass appVersion parameter

Hello,
I noticed today that bugsnag can display the app version used when an exception has been thrown.
How can we pass the app version as meta information to bugsnag? Is that even possible?
Many thanks!

Sure, you can set appVersion manually on the $bugsnag object. Here is the documentation in bugsnag-php.


Poor error message for ambiguous_extension_member_access when two extensions exist with the same name.

Describe the issue
In my local project I have an extension:
extension StringAsProcess on String {
  /// run
  Future<void> get run async {
    await HalfPipe().commandAndArgs(this).print();
  }

My project also imports the dcli project which has a similar extension
extension StringAsProcess on String {
  void get run {
    cmd.start(
      this,
      terminal: true,
      progress: Progress(print, stderr: printerr),
    );
  }

When I tried to use the 'run' method in a unit test:
import 'package:dcli/dcli.dart' as dcli;
import '../../../lib/src/shorthand.dart';
import 'package:test/test.dart';

void main() {
  test('stderr stream ...', () async {
    'dart /path/to/exc -e 10'.run;
  });
}

The linter reported the error:
ambiguous_extension_member_access
 "A member named 'run' is defined in extension 'StringAsProcess' and extension 'StringAsProcess', and none are more specific.\nTry using an extension override to specify the extension you want to be chosen.",

Expected behavior
The linter should provide details on what library each of the extensions was included from.
 "A member named 'run' is defined in extension 'StringAsProcess' from package dcli/src/string_as_process.dart and local extension 'StringAsProcess'  from lib/src/shorthand.dart, and none are more specific.\nTry using an extension override to specify the extension you want to be chosen.",

additional context
This error was particularly confusing as I had forgotten about the packages local extension and when I aliased the dcli import (as dcli) I expect that to remove the error but I guess extensions bypass the alias?

About extension bypassing aliases, you're right and today there is an error using the expression evaluation: https://github.com/dart-lang/sdk/issues/56555

I'd like to work on improving the error message for ambiguous extension member access, as described in this issue.
Proposed Enhancement:
When the analyzer encounters multiple extensions with the same member name, the error message should clearly indicate:

Full extension names: Including the package or file path where each extension is defined.
Type being extended:  Reaffirm the type the extensions are applied to (e.g., String in this case).

Example:
Instead of:

"A member named 'run' is defined in extension 'StringAsProcess' and extension 'StringAsProcess', and none are more specific."

The error could be:

"A member named 'run' is defined in extension 'package:dcli/src/string_as_process.dart'.StringAsProcess and extension 'lib/src/shorthand.dart'.StringAsProcess (both extending 'String'), and none are more specific."

Benefits:
Faster Debugging: Developers can immediately identify the conflicting extensions without manually searching through imports.
Clearer Context: The error message explicitly shows that the conflict arises from extensions operating on the same type.
I'm happy to submit a pull request with this improvement if the approach aligns with the project's goals. Please advise on the preferred implementation details.

Sorry @Vinay-Khanagavi I only just saw your comment after I landed mine! ☹  Didn't mean to step on toes.
We have over 150 open issues with the label "analyzer-ux" which are "user experience" issues, which might be similar to this one. I've found there are often low-hanging fruit in there.

@srawlins  No worries at all! 😊 Thanks for letting me know. I’ll definitely check out the "analyzer-ux" label and explore those user experience issues.
Thanks for the tip!


Cask was detected as formula with --only-formulae

I have a tap providing casks only. Today when I opened https://github.com/muzimuzhi/homebrew-texstudio-beta/pull/16 to update cask texstudio-beta, it was detected as formula hence the workflow failed with log
Run brew test-bot --only-formulae --root-url=https://ghcr.io/v2/muzimuzhi/homebrew-texstudio-beta
==> Using Homebrew/homebrew-test-bot 09eca62 (Merge pull request #896 from carlocab/remove-debug-output)
==> Using Homebrew/brew [4](https://github.com/muzimuzhi/homebrew-texstudio-beta/actions/runs/4589072932/jobs/8103716422#step:8:5).0.10-119-g931327df1 (Merge pull request #15116 from ZhongRuoyu/bump-cask-pr-sha256)
==> Testing muzimuzhi/homebrew-texstudio-beta 2e3a69f (Merge 4aed83a1[5](https://github.com/muzimuzhi/homebrew-texstudio-beta/actions/runs/4589072932/jobs/8103716422#step:8:6)d3fecf22d961f7a092d764e72b56838 into da40a90d1b055e6c123d1b926eefd2290a241861):

==> Running FormulaeDetect#detect_formulae!
==> git -C /home/linuxbrew/.linuxbrew/Homebrew/Library/Taps/muzimuzhi/homebrew-texstudio-beta fetch origin +refs/heads/master
    url               https://github.com/muzimuzhi/homebrew-texstudio-beta/pull/1[6](https://github.com/muzimuzhi/homebrew-texstudio-beta/actions/runs/4589072932/jobs/8103716422#step:8:7)/checks
    tap origin/master da40a90 (texstudio: fix style violations)
    HEAD              2e3a69f (Merge 4aed83a15d3fecf22d961f[7](https://github.com/muzimuzhi/homebrew-texstudio-beta/actions/runs/4589072932/jobs/8103716422#step:8:8)a092d764e72b56[8](https://github.com/muzimuzhi/homebrew-texstudio-beta/actions/runs/4589072932/jobs/8103716422#step:8:9)38 into da40a[9](https://github.com/muzimuzhi/homebrew-texstudio-beta/actions/runs/4589072932/jobs/8103716422#step:8:10)0d1b055e6c[12](https://github.com/muzimuzhi/homebrew-texstudio-beta/actions/runs/4589072932/jobs/8103716422#step:8:13)3d1b926eefd2290a241861)
    diff_start_sha1   da40a90d1b055e6c123d1b926eefd2290a241861
    diff_end_sha1     2e3a69fbc6b7a778c4[14](https://github.com/muzimuzhi/homebrew-texstudio-beta/actions/runs/4589072932/jobs/8103716422#step:8:15)4dbf803957f1e8be2a08

    testing_formulae  muzimuzhi/texstudio-beta/texstudio-beta
    added_formulae    (none)
    modified_formulae muzimuzhi/texstudio-beta/texstudio-beta
    deleted_formulae  (none)
Error: No available formula with the name "muzimuzhi/texstudio-beta/texstudio-beta".
Error: Process completed with exit code 1.

In the past, the log of such step looked like
==> Running FormulaeDetect#detect_formulae!
==> git -C /usr/local/Homebrew/Library/Taps/muzimuzhi/homebrew-texstudio-beta fetch origin +refs/heads/master
    url               https://github.com/muzimuzhi/homebrew-texstudio-beta/pull/15/checks
    tap origin/master 1bac692 (texstudio-beta 4.5.1beta6)
    HEAD              3ff9554 (Merge 099a069fcdc5bc86eea44cb751d716716[12](https://github.com/muzimuzhi/homebrew-texstudio-beta/actions/runs/4031951927/jobs/6931540308#step:8:13)d8704 into 1bac692b95acf1a2ab4a8d8aa56ed42[13](https://github.com/muzimuzhi/homebrew-texstudio-beta/actions/runs/4031951927/jobs/6931540308#step:8:14)dcc0d63)
    diff_start_sha1   1bac692b95acf1a2ab4a8d8aa56ed4213dcc0d63
    diff_end_sha1     3ff9554480db77dd866728012c66f9e5b86853a6

    testing_formulae  (none)
    added_formulae    (none)
    modified_formulae (none)
    deleted_formulae  (none)
All steps passed!

Today's failed workflow run https://github.com/muzimuzhi/homebrew-texstudio-beta/actions/runs/4589072932/jobs/8103716422
A successful workflow run in the past (on Jan 28, 2023) https://github.com/muzimuzhi/homebrew-texstudio-beta/actions/runs/4031951927/jobs/6931540308

Likely caused by e60740fa5d4ac289b269bfb2b80cb4d7c2522808.
Can you try reverting that commit to see if it fixes your problem? You may need to revert bba212de7ecfb8240bd1694712abcfec99fef1fc first.

No luck, see https://github.com/muzimuzhi/homebrew-texstudio-beta/actions/runs/4589702164/jobs/8104777253
Run brew test-bot --only-formulae --root-url=https://ghcr.io/v2/muzimuzhi/homebrew-texstudio-beta
==> Using Homebrew/homebrew-test-bot 07b949e (Revert "Formula: "shard" directory.")
[...]
    testing_formulae  muzimuzhi/texstudio-beta/texstudio-beta
    added_formulae    (none)
    modified_formulae muzimuzhi/texstudio-beta/texstudio-beta
    deleted_formulae  (none)
Error: No available formula with the name "muzimuzhi/texstudio-beta/texstudio-beta".
Error: Process completed with exit code 1.

Hmm. Odd. Can you try going back a few months to see if you can find a commit where this was working properly?

After setting some env vars I managed to run brew test-bot --only-formulae locally, which enables me to debug easier (by adding puts).  Then I find it's probably caused by https://github.com/Homebrew/brew/commit/f280ce069ba12f185ffd64f75e1d8ad48543da3f. It made tap.formula_file?() method too loose if tap is non-official.
In https://github.com/muzimuzhi/homebrew-texstudio-beta/pull/16/commits/bb7eac7152dc9e467dd99c984c02e880fc128b89 I reverted https://github.com/Homebrew/brew/commit/f280ce069ba12f185ffd64f75e1d8ad48543da3f, then the checks passed.
Currently,

since my tap has no Formula directory, hence in line 120, formula_path is set to /usr/local/Homebrew/Library/Taps/muzimuzhi/homebrew-texstudio-beta, the path to tap;
then in method diff_formulae, Casks/texstudio-beta.rb is caught as a formula candidate;
finally tap.formula_file?(file) in line 194 returns true thus cask Casks/texstudio-beta.rb is wrongly classified as a formula.
https://github.com/Homebrew/homebrew-test-bot/blob/09eca62c20c0925d3c79e7c248b70195cd260b35/lib/tests/formulae_detect.rb#L119-L127
https://github.com/Homebrew/homebrew-test-bot/blob/09eca62c20c0925d3c79e7c248b70195cd260b35/lib/tests/formulae_detect.rb#L185-L198

I'll report this to https://github.com/Homebrew/brew.

I'll report this to https://github.com/Homebrew/brew.

I need a better use case that's easier to run locally and involves a third-party tap and tap.formula_file?(file) method.  Do you happen to know such one brew usage?

IMO this is the type of thing where we're unlikely to fix this ourselves but will review and help you with a PR.
We don't support using brew test-bot with cask taps, really, but will consider fixes to improve behaviour there.

We don't support using brew test-bot with cask taps, really, ... .

@MikeMcQuaid Perhaps this should be stated in doc for brew tap-new because the support for cask taps once existed, which made the new behavior looks like more a regression than undocumented feature.
It seems the tap class needs a more intelligent formula_file?(file) method that could distinguish between class Foo < Formula ... end and cask "Foo" do ... end.

Came across an easier idea: in formula_file?(file), filter out ruby files that reside in Cask directory or one of its sub-directories.

Came across an easier idea: in formula_file?(file), filter out ruby files that reside in Cask directory or one of its sub-directories.

This seems like a good idea 👍🏻

Actually, thinking about it more: I've found a one-liner test-bot solution based on the fact that casks can only ever be in one directory. PR opened.

@MikeMcQuaid Thank you! #899 does fix my original problem, see this workflow run.
Still I think tap.formula_file?(file) (in Homebrew/brew) could be tightened because IMO it's wrong to have tap.formula_file?(file) and tap.cask_file?(file) both true for some file.
diff --git a/Library/Homebrew/tap.rb b/Library/Homebrew/tap.rb
index 3439ec0c9..fb09122cb 100644
--- a/Library/Homebrew/tap.rb
+++ b/Library/Homebrew/tap.rb
@@ -570,7 +570,7 @@ class Tap
     file = file.expand_path(path)
     return false unless ruby_file?(file)

-    file.to_s.start_with?("#{formula_dir}/")
+    file.to_s.start_with?("#{formula_dir}/") && !file.to_s.start_with?("#{cask_dir}/")
   end

   # return true if given path would present a {Cask} file in this {Tap}.


Table from HTML to MD w/ fixes

Proposed changes

Unreleased project version (optional)

Related issues (optional)

Deploy preview for docsdocker ready!
Built with commit 15c200cd7e224a5c60b5b61a88b7f81b3042cd08
https://deploy-preview-7627--docsdocker.netlify.com

Deploy preview for docsdocker ready!
Built with commit 3168bc4008f638d68bb62f8e6cfbc9b790ad9cc7
https://deploy-preview-7627--docsdocker.netlify.com


networkmanager: unmanage any uap interface

Since NetworkManager can't play nice with uap interfaces, we're marking them as unmanaged, so this won't affect other connections.

I wanted to hear you opinion on this. Ok, this is something we already have to to whenever we're trying to enable AP on a device, but for this specific connection issue, there might be a possibility of fix.
This is one workaround that was also shared in the issue, so it's not like the issue is a blocker anymore....
I don't really like this and would rather wait to see if we get a proper fix on this. What do you guys think?

@EdTheBearded, the BSP team accepts the issue as a driver bug.
I would suggest we accept this solution of unmanaging UAP in the short-term, and then revert this once the BSP bug is fixed.

Doing this as a short term solution seems sensible to me, as long as we keep a reminder for undoing it later once the driver problem is solved.

Doing this as a short term solution seems sensible to me, as long as we keep a reminder for undoing it later once the driver problem is solved.

Maybe we could have a ticket on our backlog to remove this. @leograba?


How to preload images?

Is there a way for this component to expose the dropzone object so i can call myDropzone.emit("thumbnail", mockFile, "/image/url"); to preload images?
See  https://github.com/enyo/dropzone/wiki/FAQ#how-to-show-files-already-stored-on-server

Not yet, but I'm more than happy to include a callback as soon as the dropzone is initialized. I'll add that right away :+1:

The eventHandlers can now contain a handler for init, which will be called when the dropzone object is initialized, passing the dropzone as a the first argument.
I hope this works for you. I'm closing this for now, but feel free to reopen if it doesn't!

great, will you push a release to npm with this soon?

Already pushed :rocket:


man: add missing --remove option from aur sync

I wouldn't add a new repo-add section to the man page like in the aur-build man page, since aur-sync forwards it to aur-build, but it's an repo-add option, so I also could add a new section in the man page.

In this case, the reference should be (aur build -R) because aur sync doesn't talk to repo-add directly, it just passes the -R option to aur build, which happens to pass it it to repo-add.
Otherwise looks good to me.
nitpick: "Add remove from repo option" is a bit hard to read, I would reword the subject, e.g.
man: add missing --remove option from aur sync

Looks good to me. Note you can easily merge/reword the commits with git rebase, e.g. git rebase -i HEAD~2.

Branch squashed and rebased onto master

Thanks for merging!


add scopes extension to simple_enum extensions

Hi, would you consider to add my extension to your documentation ?
https://github.com/aovertus/simple_enum-scopes
I'll improve it over time with new ideas.
Alexandre<EMAIL_ADDRESS>)

Hi @aovertus, sure thing. Thanks a lot, looks interesting!


Amplitude analytics-browser 2.11.0 with autocapture: true freezes on click on dropdown menu

Expected Behavior
Not freeze and capture the interaction
Current Behavior
We recently upgraded from:
    "@amplitude/analytics-browser": "^2.9.3",
    "@amplitude/plugin-session-replay-browser": "^1.6.5",

to
    "@amplitude/analytics-browser": "^2.11.0",
    "@amplitude/plugin-session-replay-browser": "^1.6.21",

and enabled autocapture. But it broken one of our dropdown menu select and had to revert back to previous version. Essentially when a user clicked on a dropdown menu it would just freeze any interaction like JS thread was in an infinite loop. Does anyone else had this problem?
Possible Solution
downgrade to ^2.9.3
Steps to Reproduce
I haven't tried to reproduce it on a clean repo with just amplitude enabled as that's a lot of work. Just trying to understand if anyone else is having this issue. Can do further digging if needed.
Environment

SDK Version: mentioned above
Node version: v20.13.1

@mjsilva - I see that the issue is marked closed. Were you able to resolve the issue? This shouldn't be happening so checking in to see if there's an issue with the SDK.

I think this is the new issue? https://github.com/amplitude/Amplitude-TypeScript/issues/861


excluded

Fixes #288

Coverage remained the same at 79.402% when pulling 5b13d4c3e7b1a0bf30181a3d4aa047896c2bf90d on 288 into 3b15cf2eb496001c5ad07ff2315e523590f0be77 on master.

@rultor merge it

@rultor merge it

@amihaiemil OK, I'll try to merge now. You can check the progress of the merge here

@rultor merge it

@amihaiemil Done! FYI, the full log is here (took me 3min)


Replaces deprecated method and bumps deployment target

Fixes only the actual library and disregards the demo project. Not meant to be upstreamed as the project seems to be discontinued anyway.

:shipit:


Figuring out which polyfills I actually need

I would love to be able to automatically compute the needed polyfills by running my compiled javascript through a script or something.

See https://github.com/azproduction/autopolyfiller for one solution, albeit a bit out of date now.  We don't have any plans to build this feature but it should be possible for you to build it on top of our project.


[AKS] Add support for SGX addon 'confcom'

Description

Add support for SGX addon 'confcom'. AKS cluster created with confcom addon enabled will have support with SGX device plugin for Gen2 VMs.
Testing Guide

Add tests for: a) AKS cluster creation with confcom addon enabled with default option; b) AKS cluster creation with confcom addon enabled with SGX quote helper option; c) enablement of confcom addon for an AKS cluster; d) disablement of confcom addon for an AKS cluster.
History Notes

[Component Name 1] BREAKING CHANGE: az command a: Make some customer-facing breaking change.
[Component Name 2] az command b: Add some customer-facing feature.

This checklist is used to make sure that common guidelines for a pull request are followed.

[x] The PR title and description has followed the guideline in Submitting Pull Requests.

[x] I adhere to the Command Guidelines.


short term doc fixes

A list of doc fixes that we may consider before an initial release:

Add more to the homepage, probably stuff from README.py.
Describe the relation to PVPMC, PVLIB-Matlab.
Make a text link for the tutorials instead of my usual url dump.
Different page for each module?

Any other relatively easy and important doc fixes?

Issues found in docs, likely from auto-gen content that hasn't been updated in code? Perhaps not all of these qualify as easy to fix before release:
Ineichen doesn’t provide info on single df output
function is now aoi, but docs reference getaoi throughout, except in actual function doc
lots of references to pvl_function not function

Thanks.
The numpydoc convention is to avoid using "See also" unless it's really important. I think that we can follow that rule now now that the library structure is in better shape.
More issues:

The doc title capitalization needs to be updated.
Copyright needs to be updated.
pvlib.pvsystem.snlinverter has a poorly formatted table.
References to maketimestruct, makelocationstruct in pvlib.clearsky.haurwitz, maybe more.
pvlib.irradiance.beam_component has no documentation.
All modules need a better introduction to what's in them.
pvlib.pvsystem.I_from_V has no documentation.
pvlib.pvsystem.Voc_optfcn has no documentation.
pvlib.pvsystem.calcparams_desoto says that module_parameters can be a Series, which, although true, is probably confusing (does anybody really use a Series as a dict?). In any case, the doc's dict keys do not match the code's dict keys.
Misspelling in pvlib.pvsystem.retrieve_sam example.
Format equation in pvlib.pvsystem.singlediode
pvlib.pvsystem.systemdef as described in #17
pvlib.tmy.readtmy2 refers to a metadata struct instead of a dict. Could be addressed in #7.

Closed from #22


Ulauncher

can i request ulauncher

It seems there is no current ebuild right now, seems it was dropped.
I may try build it when the migration to Plasma 6 is done.

ok thanks, I'll wait

Working on it, but there are long time issues like this: https://github.com/Ulauncher/Ulauncher/issues/114
I'll add the standard distribution of the latest stable version and you can tune it up for starting as a service, for example.

Done. Please check and report any issue related to the package and not to the application itself.


upgrade to python 3

Current module does not work any longer on macOS 12.3 which removed the python command. Need to update to use python3 which should work universally across most systems via PEP 394.

I guess just as a quick followup I switched over to https://registry.terraform.io/modules/terraform-aws-modules/lambda/aws/latest instead of this package and found that it was more up to date and feature compatible for my use cases incase it helps anyone else.

Thanks, I'll have to read PEP 394 and see what makes sense. The actual Python code used in this module is compatible with Python 2 and 3 so I'd prefer to support both if it's not difficult.
The main reason one might use this module over https://registry.terraform.io/modules/terraform-aws-modules/lambda/aws/latest is that this module doesn't require any of the build toolchain (pip/npm/go/etc) or Docker to be available on the machine running Terraform. The Lambda package gets built inside a Lambda or CodeBuild environment.

The actual Python code used in this module is compatible with Python 2 and 3 so I'd prefer to support both if it's not difficult.

Python 2 is very dead so I'd argue against trying to continue supporting it. Regardless, the pep basically calls out that python3 is the command to use for python3. Python 2 is not installed by default on most modern operating systems so just switching over to using python3 is the best answer. Alternatively you can try to detect the command but I'd push for just using the python3 command as it will work in the majority of scenarios.

We just had this issue on Terraform Cloud. Fixed by changing python to python3 for the external scripts in a fork of this repo and on terraform-archive-stable.
Happy to raise PRs for the fixes, but I'm unsure if the module should retain backwards compatibility with the python 2 executable.
Thoughts?


remove #[deprecated(...)] attributes

it makes problems with #[feature(staged_api)] when used inside rustc code.
introduced by #859
see https://github.com/rust-lang/rust/pull/46760

Ah sorry but I think https://github.com/rust-lang/libc/pull/876 beat this PR to the punch!

ok, just see than #876 already covers it. thanks @asomers.


Added check if a number is power of 2

Have you read the Contributing Guidelines on Pull Requests?
YES.
Description
Given a number , check whether the number is power of 2 or not.
We can check this by doing some bitwise operation. Bitwise operations are best because they perform the operation in least possible time.
Checklist

[x] I've read the contribution guidelines.
[x] I've checked the issue list before deciding what to submit.
[x] I've edited the README.md and link to my code.

Related Issues or Pull Requests
#2989

I see that most of the recent PR's got failed in DeepSource Java beta check ! Don't know why :(

@HarshCasper  Sir , Knidly review

@iamrajiv @ankitaggarwal23  Kindly review.

@iamrajiv  Thanks for the approve. is it looks good for merging?

@iamrajiv  also knidly add labels.

@RaiyanMahin Don't worry about labels we will add labels later. You can continue contributing.


Upgrade sops to v3.8.1

Description
Fixes #2890

TODOs
Read the Gruntwork contribution guidelines.

[x] Update the docs.
[x] Run the relevant tests successfully, including pre-commit checks.
[x] Ensure any 3rd party code adheres with our license policy or delete this line if its not applicable.
[x] Include release notes. If this PR is backward incompatible, include a migration guide.

Release Notes (draft)

Added / Removed / Updated [X].

Upgrade sops to new location with dependencies.

Basically a copy of https://github.com/gruntwork-io/terragrunt/pull/2891 but updating the docs also - hoping to get this through 🙈


chore(deps): upgrade dev dependencies

Upgrades project dependencies. See details in workflow run.

Automatically created by projen via the "upgrade-dev-dependencies-k8s-26-main" workflow

⚪ Backport skipped
The pull request was not backported as there were no branches to backport to. If this is a mistake, please apply the desired version labels or run the backport tool manually.
Manual backport
To create the backport manually run:
backport --pr 3527

Questions ?
Please refer to the Backport tool documentation


[Table Designer] renaming a col that's referenced in other tables won't fail the validaiton

Fixed by STS bump in #19912


How to fineturn UniLM on Text genration task

Dear authors of UniLM,
Thanks for your great work. I would like to ask how can I fineturn UniLM on Text genration task? I have looked at the UniLM folder and I just saw the README file. Could you please give me a guide on how I could do that?
Thank you!

https://github.com/microsoft/unilm/tree/master/s2s-ft


add serialization tests

Codecov Report

Merging #86 (5cce9a4) into main (1137a9b) will increase coverage by 0.29%.
The diff coverage is 84.07%.

@@            Coverage Diff             @@
##             main      #86      +/-   ##
==========================================
+ Coverage   82.37%   82.67%   +0.29%
==========================================
  Files          11       12       +1
  Lines         817      935     +118
  Branches      234      263      +29
==========================================
+ Hits          673      773     +100
- Misses        144      162      +18

Impacted Files
Coverage Δ

src/test-serialization/message.pb.ts
84.07% <84.07%> (ø)

src/autogenerate/index.ts
95.10% <0.00%> (+0.13%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1137a9b...5cce9a4. Read the comment docs.


Proposal to automate advanced feats

I looked for a way to manually create this feat, but it is impossible without the appropriate changes to the system.
You need to create a self:halflevel variable (along the lines of self:level). This will make it possible to use it in the feat.

For example, in the Advanced Trickery feat when I inserted the following condition, I could select level feat up to the character's level (example for a 14th level character):
     "lte": [
                "item:level",
                "self:level"
              ]

I would ask you to consider such a possibility.
P.S.
It works, when I created manually

P.P.S.
I know that there have already been several attempts to solve this problem, but this option seems to be the least destructive. I searched for all occurrences of self:level in the pf2e.mjs file and manually added the following code after those occurrences:

this.rollOptions.all[self:halflevel:${this.level/2}]=!0

This gives us a variable that we can use in a condition, as I gave in the example above, in place of "self:level".

I actually have a working implementation here https://github.com/foundryvtt/pf2e/pull/14636 but it broke when the v12 branch was rebased and merged into master. I just need to recreate it, but I have an alternative idea that should be more performant and simpler to work with that I want to present as an alternative.

My way would allow you to use this safely in Rule Element. Therefore, I found that this is the least destructive way to solve this problem.

What you have here doesn't seem to handle a level 10 actor adding an advanced archetype feat to a level 6 slot. halflevel is relative to the actor, not the slot. The active effect to inject a temporary variable idea is also employed by kineticist.
I'll close this for now, but thanks for writing the issue at least. So far the major ideas are the approach I took, and some other ones that have been juggled around behind the scenes regarding the UI of it. The issue right now isn't a technical one, its that people seem to have a habit of missing the dropzone which will alter the options.

I understand. I forgot about kineticist. I'm hoping that this will be resolved in the near future and everyone will be able to use advanced feats. Good luck.


More details on the purpose of each package/SDK and its intended use

Hey, thanks for these great SDK libs!
I've been wondering what the specific purpose of each of the packages is as listed in https://github.com/gnosis/safe-core-sdk#packages
Especially I had hard time figuring out how to add delegates using gnosis-core-sdk. It occurred that use case is supported in service client package.
So, could you

improve the details about purpose of each of the packages
provide an example use cases and limitations
maybe a rough sketch of the roadmap of what you plan for each of the SDKs.

That would help consume the libs with less confusion.

Hello @marcin-trust,
Thank you very much for your feedback, it makes sense and adds value to the repo!
For 1) I added this last week: https://github.com/gnosis/safe-core-sdk/tree/main/packages/guides (I'm referring to the README, not the guide). There you have an explanation of each package. Let me know if you find it useful or if you miss some information there. I will also try to make it easier to find and link to it from the README file in the root folder.
I'll try to improve 2) by adding examples with real values for each method. I guess the API Reference of the Safe Core SDK is a bit better documented than the API Reference of the Safe Service Client, but both are missing examples with values.
Regarding 3), for now you can check the open issues on this repo and follow the progress on these boards (filtered by safe-core-sdk repo):

backlog: https://github.com/orgs/gnosis/projects/8?card_filter_query=repo%3Agnosis%2Fsafe-core-sdk
sprints: https://github.com/orgs/gnosis/projects/17/views/11?filterQuery=repo%3Agnosis%2Fsafe-core-sdk

In the following weeks there will be a planning session and we will be able to provide a better roadmap overview.
Thank you!

That's great answer, thx for detailed info @germartinez !


Datagrid wrapped DIV height looks too lower to contain the component.

Datagrid wrapped DIV height looks too lower to contain the component.

Select one ...  (check one with "x")
[X] bug
[ ] feature request
[ ] enhancement

Expected behavior

Don't want to show vertical scroll bar beside the grid.
Here is my HTML code structure.
<div class="col-lg-12 col-md-12 col-sm-12 col-xs-12">
<clr-datagrid [(clrDgSelected)]="selected">
<!-- Omitted -->
</clr-datagrid>
</div>
Actual behavior

Vertical scroll bar always display and the DIV height looks too lower.
Reproduction of behavior

Environment details

Angular version: 2.4.1

Clarity version: 0.8.0

OS and version: OS X 10.12.3

Browser: [all | Chrome 56 | Firefox 51 ]

@wknet123 could you post a plnkr with the issue so we're able to reproduce it?

Hi @wknet123,
Thanks for submitting the issue. We haven't heard back from you so I'm assuming the issue was resolved on your end.


Assertion failure in the aiger back end

Steps to reproduce the issue
See the attached .zip file.  Running sby -f wbpriarbiter.sby will crash yosys when the solver is either abc pdr or suprove
mcve-arbiter.zip
Expected behavior
The design shouldn't cause Yosys to crash.  It should pass verification, much as the SMT solvers do.
Actual behavior
An assertion failure in the Aiger back end.

I can reproduce it using two files from that example: issue1385.tar.gz
It turns out that the aiger backend is trying to output the two cells below
  attribute \src "wbpriarbiter.v:218|fwb_slave.v:162"
  cell $assert $techmap\f_wba.$assert$fwb_slave.v:162$882
    connect \A $abc$3384$techmap\f_wba.$0$formal$fwb_slave.v:162$706_CHECK[0:0]$921
    connect \EN $0$formal$wbpriarbiter.v:179$7_EN[0:0]$111
  end

where $111 is driven by:
  attribute \module_not_derived 1
  attribute \src "wbpriarbiter.v:208|fwb_master.v:165"
  cell $initstate $techmap\f_wbm.$initstate$975
    connect \Y $0$formal$wbpriarbiter.v:179$7_EN[0:0]$111
  end

The backend fails because it doesn't know what the signal $111  is -- it's not an PI/PO/AND/NOT/FF.
Assigning @cliffordwolf because I'm not sure how the $initstate cell should be treated here.


ZXImage crash #380

Fixes #380
Recent changes appear to trigger overflow protection code that crashes on latest iOS + devices. Doesn't occur on debug builds, only release. The issue is that components for setting color intensities are declared as int8_t (signed) when they shouldn't be. See linked issue for more explanation, but the fix is to a) declare proper storage type and b) clamp component values to [0.0, 1.0].

Thanks for the fix @nrivard :)


Refactor zip to ensure type consistency

What's in this pull request?
This change does for zip what #250 did to fromElements, i.e. forces type equality between the Gen type and the generic static zip variant.
Why merge this pull request?
This fixes the following issues with zip:

let gen = Gen<Int>.zip(Gen.pure(1), Gen.pure(2)) compiles but unexpectedly returns Gen<(Int, Int)>. This will not compile after applying these changes
let z = Gen.zip(Gen.pure(1), Gen.pure(2)) did not compile (`Generic parameter 'A' could not be inferred). This will now compile.

This also removes the generic return type from Gen.map, instead map now always returns Gen<A>.
What's worth discussing about this pull request?
Using zip within Gen is now a bit more verbose, e.g. let x = zip(...) now needs to be let x = Gen<...>.zip(...).
I haven't written any gyb before, please let me know if I can improve anything.
What downsides are there to merging this pull request?
This is a breaking change and some code might not compile anymore.

Here’s an idea: The map variants should be called zipWith.  Update the template to deprecate the old names and also generate these new ones.

⛵


Fix redirect to posts list when saving a new post as an author

no issue

replace deprecated normalizeHash with normalize in post serializer
ensure we check for both post and posts properties as it will vary depending on the expected response type

Closing in favor of #6713


Automator: update istio/api@a8a0065 dependency in<EMAIL_ADDRESS>

Generated by Automator - 2020-02-06T18:35:47+00:00

@istio-testing: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

gencheck_istio_release-1.5
5692d7d24cdf8c0a364bb112409afc914d2ba087
link
/test gencheck_istio_release-1.5

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@istio-testing: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

gencheck_istio_release-1.5
5692d7d24cdf8c0a364bb112409afc914d2ba087
link
/test gencheck_istio_release-1.5

unit-tests_istio_release-1.5
5692d7d24cdf8c0a364bb112409afc914d2ba087
link
/test unit-tests_istio_release-1.5

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

This has been superseded by https://github.com/istio/istio/pull/20903


New tutorial for argonaut-codecs

What does this pull request do?
Closes #48 and adds an in-depth tutorial to introduce new users to the library, provide them with the tools they need to perform common tasks, and includes a few problem situations along with their solutions at the end. I think it's critical that a new Argonaut user feels comfortable creating encoders and decoders for simple data types without having to look at tests, search for random examples across the web, or rely on Haskell or Scala documentation instead.
Where should the reviewer start?
All changes are to the README.
How should this be manually tested?
There is no new code to test, but if you'd like to try things out in the REPL and make sure there aren't errors, that would help; this also deserves an error-checking proofread.
To read the pretty, non-diff version of the file, use this link:
https://github.com/purescript-contrib/purescript-argonaut-codecs/blob/c96395f4395a8e88c9669d0b42b6d74879b1def7/README.md
Other Notes:
If I am missing any common scenarios that really ought to be covered by a tutorial, I am happy to add them in as well and am open to suggestions to improve this! They can also be subsequent pull requests.

As someone who's been confused about Argonaut and about how I was supposed to do things, this tutorial is awesome! It answers pretty much all my questions and after reading I feel like I have a good grasp on things.
Here's some minor ideas on how to make things even better:

This seems to be a general introduction to Argonaut so maybe it should actually be in the purescript-argonaut-core repository? Perhaps that is where new users will look first and expect to find beginner documentation? At the very least, the overview over the Argonaut ecosystem in the Documentation system feels like it belongs in the core repo.

It would be useful if, the first time a type or function is mentioned, there is a link to it's Pursuit documentation.

To me, the very start of the tutorial seemed to repeat some things also mentioned earlier. For instance, it start with "Argonaut is a library for working with JSON in PureScript.". I don't think it's necessary to mention that at this point. Then the tutorial mentions that Json is defined in the core which is also mentioned earlier in the documentation section.

Anyway, this tutorial is great. Thanks a lot for writing it.

Thanks for the feedback!

This seems to be a general introduction to Argonaut so maybe it should actually be in the purescript-argonaut-core repository? Perhaps that is where new users will look first and expect to find beginner documentation? At the very least, the overview over the Argonaut ecosystem in the Documentation system feels like it belongs in the core repo.

Good points!
It's a bit confusing having three separate libraries which can be used separately but which are designed to be used together. In each case a possible newcomer ought to get a feel for what Argonaut is about, even if they aren't looking at the -core repository. And so I'm of the opinion that all of the Argonaut libraries ought to include a short snippet about Argonaut, including the overview of the Argonaut ecosystem. Maybe that's overkill; regardless, I'm thinking to open PRs for each of the repositories including the main argonaut repo.
With regards to being a general introduction to Argonaut: that's true. The -core repo focuses on the core Json type and the basic functions for operating on it, as people can import that library and use it without this one (for example, purescript-affjax and others use the Json type from core only). This repo focuses on a more common application use case, the EncodeJson and DecodeJson type classes.
I don't feel like the topics talked about here (encoding and decoding Json) are appropriate for the -core repo for that reason; it doesn't touch encoding / decoding.

It would be useful if, the first time a type or function is mentioned, there is a link to it's Pursuit documentation.

This is a good point. I'll add those links.

To me, the very start of the tutorial seemed to repeat some things also mentioned earlier. For instance, it start with "Argonaut is a library for working with JSON in PureScript.". I don't think it's necessary to mention that at this point. Then the tutorial mentions that Json is defined in the core which is also mentioned earlier in the documentation section.

Yes, there are some redundancies there. I think the tutorial would be better with those removed as well. Thanks!

And so I'm of the opinion that all of the Argonaut libraries ought to include a short snippet about Argonaut, including the overview of the Argonaut ecosystem. Maybe that's overkill; regardless, I'm thinking to open PRs for each of the repositories including the main argonaut repo.

That sounds like a great idea. And each of these could have a "beginners see this tutorial" link.
The changes looks great :+1:

Excellent! I'll let this sit for another day or two, but if there are no further comments then I will merge this in. Further updates can always be made.


forge debug doesn't show source code

Component
Forge
Have you ensured that all of these are up to date?

[ ] Foundry
[X] Foundryup

What version of Foundry are you on?
nightly 0e72b71
What command(s) is the bug in?
forge script --debug
Operating System
Linux
Describe the bug
Source code debugging seems to have recently broken.  In the current nightly (0e72b71), I can do the following:

foundryup --commit 0e72b71
forge init
forge script --debug script/Counter.s.sol

..and where the source should be, it says "Unknown contract at address 0x5b73...0519"
Earlier versions, for example 288ab2e from about 2 week ago, correctly show and step through the source.
Also, I have not been able to get any recent versions to show source code when stepping into on-chain contracts, even though I've set my ETHERSCAN_API_KEY in env and toml.

Seeing this on my end as well.

Same here, with the latest version.

Closing @Evalir ?

Verified, working on my side.

the docs says it should show source code https://book.getfoundry.sh/forge/debugger

I got same issues on my side.

cc @iFrostizz @Evalir, this seemed to be mitigated at the time, but I am frequently (inconsistently) not able to view sourcemap for te actual contract(s) I am testing – the test contract sourcemap works fine, but calls to the actual logic contract show no sourcemap.
Looks like other users are running into this as well.

Hard to say without having a reproducible example @emo-eth

I can look to work up a MCVE for this, if useful because we're hitting the same.
I just want to make sure I understand how it's meant to work correctly to rule out any false assumption on my part. So at the moment I'm trying to debug a deployed contract via forking like this:
CONTRACT=<contract-address> forge debug --debug scripts/DebugRemote.s.sol --fork-url $RPC_URL

DebugRemote.s.sol then looks like this:
pragma solidity ^0.8.22;
import {Script} from "forge-std/Script.sol";
import {console2} from "forge-std/console2.sol";

import {MyContract} from "../src/MyContract.sol";

contract DebugRemote is Script {

    address private CONTRACT = vm.envOr("CONTRACT", address(0));

    function run() public {
        require(CONTRACT != address(0), "CONTRACT env var missing");
        MyContract(INFO_CONTRACT).fooBar();
    }
}

When I'm walking through the debugger it shows me the source code for the DebugRemote script itself no problem, but as soon as it steps into fooBar() it says:

Unknown contract at address <contract-address>

MyContract.sol exists in my local repo (though it's not validated on-chain). I've ran a full forge clean && forge build before running the script, and the repo code matches the deployed.
Should forge debug be able to link the source code in this scenario and display it or have I misunderstood?

#7058 will hopefully resolve some of these issues

Hi @0xGuybrush, sorry for the delay. Would be great to have a minimal reproduction of this!
@emo-eth are you still experiencing issues with this since https://github.com/foundry-rs/foundry/issues/7111 + https://github.com/foundry-rs/foundry/pull/7058?

Hi @0xGuybrush, sorry for the delay. Would be great to have a minimal reproduction of this!

Hi @zerosnacks. Yes absolutely! Please check it out here. I've just added a script to the default foundry init project, and then written up steps to reproduce in the README.
Happening still with foundryup as of this morning.
I'm seeing a flow like this:

1. Behaving as expected in the DebugRemote contract itself:

2. Sometimes gives "No source map for contract DebugRemote":

I think that's just for certain opcodes though, then keeps going and shows source again on the DebugRemote contract:

3. Gives error when it drops into deployed Counter contract:

4. Shows source again when it returns to DebugRemote:

Hope this helps, let me know if I can give more details

Hope this helps, let me know if I can give more details

Awesome! This helps a ton


[OceanBase] Hyperlink in SQL editor works only for fully-qualified names

Description
Ctrl+left click won't open the data editor for the table if the name doesn't contain database name
DBeaver Version
23.2.0
Operating System
Any
Database and driver
MySQL 5.7.25
MySQL Connector Java mysql-connector-java-5.1.44 ( Revision: b3cda4f864902ffdde495b9df93937c3e20009be )
Steps to reproduce

Type a table name in the SQL editor
Ctrl+click on the name

Expected: Table is opened in the new tab
Actual: Nothing happens
Additional context
No response

Open Defect in TestQuality


Validation issue for +18765245411

Hello,
number +18765245411 is marked as not valid, but user says it's valid Jamaica number.
Country/region affected : Jamaica
Example number(s) affected :<PHONE_NUMBER>1
The phone number range(s) to which the issue applies : Unsure
The type of the number(s) : Mobile
The cost, if applicable: N/A
Supporting evidence - NPAnxxsource.com/nalennd.php

Hi,
Thanks for providing all the details we need! We've accepted this issue and will fix this in an upcoming release.
Please note that you have submitted this information with the knowledge that we may use, modify, reproduce, publicly display, and distribute the information in accordance with our open source policies. Please let us know if you did not intend to submit the information for such use.

@kkeshava Thanks for information. Do you know when you're going to make this release?

@palodelincak  We have a release tomorrow so will try to push this fix else you might have to wait for another 2 weeks. We'll update this thread when it's released.

Hello, any news about this issue? 2 weeks passed and it looks like it has not been released?

http://libphonenumber.appspot.com/phonenumberparser?number=+%2B18765245411 -- seems it has been?

Yep, seems this was fixed in release 7.7.3. Apologies for not letting you know.


Importing unnamed project

Version
3.2.1
Environment info
 System:
    OS: Windows 10
    CPU: (4) x64 Intel(R) Core(TM) i5-2500K CPU @ 3.30GHz
  Binaries:
    Node: Not Found
    Yarn: Not Found
    npm: 6.5.0 - D:\Program Files\nodejs\npm.CMD
  Browsers:
    Edge: 42.17134.1.0
  npmPackages:
    @vue/babel-preset-app:  3.2.0
    @vue/cli-overlay:  3.2.0
    @vue/cli-plugin-babel: ^3.2.0 => 3.2.0
    @vue/cli-service: ^3.2.0 => 3.2.0
    @vue/cli-shared-utils:  3.2.0
    @vue/component-compiler-utils:  2.3.1
    @vue/preload-webpack-plugin:  1.1.0
    @vue/web-component-wrapper:  1.2.0
    babel-helper-vue-jsx-merge-props:  2.0.3
    babel-plugin-transform-vue-jsx:  4.0.1
    vue: ^2.5.21 => 2.5.21
    vue-hot-reload-api:  2.3.1
    vue-loader:  15.4.2
    vue-router: ^3.0.2 => 3.0.2
    vue-style-loader: ^4.1.2 => 4.1.2
    vue-template-compiler: ^2.5.21 => 2.5.21
    vue-template-es2015-compiler:  1.6.0
    vuex: ^3.0.1 => 3.0.1
  npmGlobalPackages:
    @vue/cli: Not Found << Dont know why it says that, it is installed and running fine...

Steps to reproduce
Import a project containing a package.json with no "name" property.
{
    "private": true,
    "scripts": {
        "serve": "vue-cli-service serve",
        "build": "rm -rf public/{js,css,img} && vue-cli-service build --no-clean"
    },
    "devDependencies": {
        "@vue/cli-plugin-babel": "^3.2.0",
        "@vue/cli-service": "^3.2.0",
        "axios": "^0.18",
        "babel-core": "^6.26.3",
        "babel-jest": "^23.6.0",
        "file-loader": "^2.0.0",
        "lodash": "^4.17.11",
        "node-sass": "^4.11.0",
        "popper.js": "^1.14.6",
        "sass-loader": "^7.1.0",
        "vue": "^2.5.21",
        "vue-router": "^3.0.2",
        "vue-style-loader": "^4.1.2",
        "vue-template-compiler": "^2.5.21",
        "webpack": "^4.27.1",
        "vuex": "^3.0.1"
    }
}

What is expected?
Should default to string Undefined or Unnamed.
What is actually happening?
vue ui client blank screen behavior.
ApolloError.js:37 Uncaught (in promise) Error: GraphQL error: Cannot return null for non-nullable field Project.name.
Adding missing "name" to package.json and forcing reload fixes issue.

Well, vue-cli 3 projects are always generated with a name, it's kind of required. We could enhance the error though.

Yes but, if you build your project by any other means or on top of say Laravel and forget to put the name because it is omitted in a laravel package file or say your a newbie and take it out by mistake, the vue cli becomes badly bricked.

Importing an unnamed project has caused this issue #2198 as I am now seeing this error:
An error occured
vue-apollo.js:55 GraphQL error: Cannot return null for non-nullable field Project.name.
I checked in .vue-cli-ui/db.json and I can see:
    {
      "id": "8XUD7L3Iu",
      "path": "D:\\var\\www\\vhosts\\laravue-spa-sessions",
      "favorite": 0,
      "type": "vue",
      "openDate":<PHONE_NUMBER>106
    },

As you can see the name is missing, the only way to get out of this catastrophic simple mistake is to know to wipe the database.
This issue seems to permanently break vue cli ui.
Project lists breaks, Dashboard and Analyzer all get totally wreaked, Plugins and Dependencies don't fully render, you cant even switch to another project.
Fixing the bad entries in the database restores all functionality.

The project import feature could sure get some love. I was thinking of auto-installing deps if node_modules is missing and we could add this to the list. 😸


Remove git revert message as the action can be achieves by pressing C…

Fixes #43625 by removing code related to showing intrusive "revert" window alert.

This would be great, current behaviour with the alter box is a pain.

Closing as it's resolved already, didn't notice this was here first... sorry! Thanks for the contribution though!


Add vault strategy contribution disclaimer

Closes #106
Footer disclaimer on vaults page to link to the new doc

@wirjo need exact numbers here, see FAQ for info: https://docs.yearn.finance/faq#what-are-the-fees

1/ Clarified number in footer disclaimer:

2/ Corresponding docs also updated with clarification:


S3 | Add a unit test for the /alive route in the hunts-api

API Request
Story

As a developer
I need a bootstrapped test suite
So that I can test my application as it changes

Acceptance Criteria

Mocha, should, and supertest installed in the project

a test for GET /alive js that asserts the message given back.

Test is written in a hunts-api/test/routes/alive.js file

Links for docs
-- https://mochajs.org/
-- https://github.com/tj/should.js/
-- https://github.com/visionmedia/supertest

This is Ziwei's

//alive.js
var assert = require('assert');
const request = require('supertest');
const express = require('express');
const app = express();
app.get('/alive', function(req, res) {
res.status(200).json({testMessage: 'This is very important Message!!!!' });
});//res status code 200 and json object testMessage
describe('GET /alive', function() {
it('respond with json', function() {
return request(app)
.get('/alive')
.set('Accept', 'application/json')
.expect('Content-Type', /json/)//make sure content type is json that we get
.expect(200)
.then(response =>{
assert(response.body.testMessage);//assert testMessage
})
});
});
//app.listen(5000,console.log("app is on!!"));//tesing on port 5000

this is my alive.js code , i have problem with push to my own branch so post the code in here !

You need to make a proper PR, otherwise code is not added correctly :-) You also need to include the new dependencies into the package.json by installing them with --save

@shalayiding Still need this