Roadmap

Do you guys have any sort of roadmap published?
Here's the problem I'm facing. Despite being "planned in the roadmap" since 2018, you guys still haven't moved the spatial classes into a separate NuGet package, https://github.com/Azure/azure-cosmos-dotnet-v3/issues/15
Unfortunately, I've now got developers using NetTopologySuite.IO.GeoJSON because they don't want to pull in your SDK because it's close to 4MB. While it serializes identically, I can't query the objects when they make it into Cosmos.
So where does that leave me? I just cloned your repository, thinking maybe I could extract the spatial classes. I could do that, but it doesn't look like there is a way to inject stuff into your expression parsing logic. I've reached the point where I'm thinking, screw it, I'll just clone your code, do a little refactoring, and publish my own version of Microsoft.Azure.Cosmos to our private NuGet.
To be blunt, THIS IS INSANITY, but waiting until 2087 for a half day refactor (if that much) is simply no longer an option.

@jackbond Thanks for the feedback, I would love to understand more about the scenario and some clarification would be nice.
It seems the text seems to define two main group of developers:

You mentioned that some developers don't want to pull the SDK due to size, how are they interacting with the Cosmos DB account then? Are they using some REST API wrapper?
Are they only pulling the SDK in for the Spatial types and nothing else? Is that the reason to ask for a Spatial-only package?
If they are not using the SDK, how is the expression parsing logic in the SDK related?

Would be good to dissect the scenario you are describing a bit more to understand how all these are related or if they are separate issues.

I don't think our organization is unique in need to pass spatial data up and down our stack. Our database guys could care less about a 4MB dependency, but our Blazor guys sure do. So our classes end up with a hodge podge, some using Cosmos spatial types and others using NetTopologySuite spatial types.
All across Microsoft and Azure NuGet packages are isolating lower level classes and interfaces into separate NuGet packages, like Microsoft.Extensions.Configuration.Abstractions.
Here's another example. I've got a microservice that manages a class which contains a Microsoft.Azure.Cosmos.Spatial.Point. It never touches the database, not its job. But CosmosClient and 4MB of other baggage gets deployed along with it.
I've cloned this repository, moved the Spatial classes to a separate NuGet package, it's 13KB. Given that there's already a template to go by, i.e. azure-pipelines-encryption.yml, I estimate it would take me less than two hours to isolate the spatial stuff, including the build pipelines.
I'm already in discussions to stop using the Microsoft.Azure.Cosmos NuGet package in favor of a custom build, which is honestly the last thing in the world I want to be wasting my time on.

Thanks for the clarification, it paints a clearer picture.
If I understand correctly, you use these Spatial types (from NetTopologySuite or SDK or some other source) across your Domain in multiple Models, and at some point, they reach the component that interacts with the SDK to perform some operation (maybe queries?), and you have problems with some of these operations. Could you detail which operations and how are you executing them? Are they queries? Are you using Linq or query texts?

Got it, so the issue would be, LINQ queries when the model uses Spatial types that are not the SDK ones, thanks for all the detailed scenario.
Could you share some of these errors and maybe a small example of how to reproduce them? Not trying to divert the ask for a separate package, but I think the issue might be LINQ related on how it interacts with these other Spatial types. Are you using System.Text.Json by any chance as serialization engine?

Having looked at your code, I can tell you the problem is in ExpressionToSQL.cs, line 696 of the releases/3.21.0 branch. Your code will only do the proper SQL spatial translations when the spatial classes are derived from Microsoft.Azure.Cosmos.Spatial.Geometry. That's why if even just that class were in a separate NuGet, this problem goes away. I don't know if there's a need, but I imagine being able to inject a type / interface into the ExpressionToSQL logic would be useful. Idea being, developers could instruct the Cosmos SDK to use custom logic for user defined types during the LINQ to SQL expression parsing stage. As far as System.Text.Json, we're not using it yet (as you can see in the code for DocumentWrapper.)

So basically the scenario is: LINQ Geo expressions only work with the Spatial types that are part of the SDK.

Bingo. So your options are

Move the spatial types to a separate NuGet.
Provide a mechanism for external types to be handled during LinqToSql expression processing.
Both, whereby the internal spatial types are treated the same as external types.

If you do 2 or 3, then someone is going to write the expression processing code for the Microsoft.Spatial types, share that code, and then the Cosmos team can simply make it official and save themselves a bunch of work. :)

As far as I can tell, this requires

Adding Microsoft.Azure.Cosmos.Spatial to the InternalsVisibleTo list for Microsoft.Azure.Cosmos.Direct (5 seconds)
Creating a new class library, Microsoft.Azure.Cosmos.Spatial (10 seconds)
Moving the spatial files from Microsoft.Azure.Cosmos to the new class library (15 seconds)
Added NuGet reference to new library (5 seconds)
Add TypeForwardedTo attributes for moved classes (about 30 classes, so 8 to 10 minutes)
Fix a few unit tests, e.g. ClientDllNamespaceTest and ContractChanges (a lot of your unit tests fail due to connectivity issues, so hard to gauge. So how about half a day?)
Creating yml and adding build pipeline (maybe 5 minutes)

All and all, not difficult or time consuming. It makes it incredibly frustrating that in three years nobody has tackled this. I can't do steps 1 and 7, but if someone creates me a branch and gives me permissions, I'll happily do the work.

At this moment there are no plans to ship the Spatial types as a separate package in the immediate term, it is not part of the roadmap or planning in terms of prioritization.
For V4, work alignment needs to follow the Azure SDK team, and https://github.com/Azure/azure-cosmos-dotnet-v3/issues/2755 captures the essence and the problem described in this thread. In V4 we can do breaking changes and extract the Spatial types from the SDK.


Sak 42335 sak 42336 sak 42345

FYI, I did add new properties that will need translations.  Not sure what the process looks like for that.


Accept two root resolvers

#128

I like this in theory (and I was also confused originally why mutation and query resolvers got merged into the same place even though they're different types in the schema), but personally I'd rather not break backcompat at the moment, especially since there's no proper versioning scheme for this repo yet.

Hi @vergenzt , the reason why i'm trying to do this is because i want to structure my schema in products, and then each product will have their own queries and mutations. For example:
schema{
    query:Query
    mutation:Mutation
}

type Query {
    apple: AppleQuery
    samsung: SamsungQuery
}

type Mutation {
     apple: AppleMutation
     samsung: SamsungMutation
}

type AppleQuery {
    mcbook: Mcbook
}

type AppleMutation {
    createMcbook: Mcbook
    updateMcbook: Mcbook
    deleteMcbook: Mcbook
}

The only way to do this now is to have 2 different schemas. To merge all in the same IDL schema i need to apply my patch.


[FEATURE] Host meta endpoint

[FEATURE] Redirect root to host meta, link to docs
[FEATURE] Display codius host version in host meta
[FEATURE] List billing modules supported and prices
[FEATURE] Display RSA public key of host
[Finishes #89446660]
[Finishes #89445636]

+r

LGTM :+1:

The build is good and I'm seeing 1 +1s from the following folks:

wilsonianb

As such, I'll attempt to merge and close this pull request.


Please add suport for Dunst

Hello. Thank you for your hard work with this project. I have one request. Would it be possible to extend the functionality of the program by adding dunst (it is a lightweight replacement for the notification-daemons provided by most desktop environments) support?

You can customize and use this little script to reload dunst with wal colors with -o reload_dunst.sh (if I remember correctly I've dug this out of some old commits on this repository)
#!/usr/bin/env bash
#
# Script to set colors generated by 'wal'
# https://github.com/dylanaraps/wal
 # Source generated colors.
. "${HOME}/.cache/wal/colors.sh"

 reload_dunst() {
    pkill dunst
    dunst \
	-frame_width 0 \
        -lb "${color0}" \
        -nb "${color0}" \
        -cb "${color0}" \
        -lf "${color7}" \
        -bf "${color7}" \
        -cf "${color7}" \
        -nf "${color7}" &
}

reload_dunst

You can customize and use this little script to reload dunst with wal colors with -o reload_dunst.sh

Hello. It works partly. In urgency_low, theme changed, but in urgency_normal, not. Here screenshot. I'm hoping this will help

You can customize and use this little script to reload dunst with wal colors with -o reload_dunst.sh

Hello. It works partly. In urgency_low, theme changed, but in urgency_normal, not. Here screenshot. I'm hoping this will help

Hmm, I can't reproduce this error, the script is working for me. I'm using Dunst version 1.3.0 (2018-01-05)

I'm using Dunst version 1.3.0 (2018-01-05)

I'm using Dunst version 1.1.0 (i am on Debian 9.5)...Maybe you could give advice on this? If not, it does not matter. It should be as it is 😄

It seems dunst has deprecated such flags (https://github.com/dunst-project/dunst/issues/328) BUT here's the funny thing: Deprecation seems to have happened in version 1.2.0 according to their changelog, I'm using a later version and it's working, your using one pre-deprecation and getting this weird behaviour.....

It seems Dunst has deprecated such flags

It does not matter anymore. I made the configuration manually. Thank you for the help.

I will close this issue.

If anyone else is interested, I solved this issue by writing my dunstrc as a user template file and symlinking the resulting cache file to ~/.config/dunst/dunstrc.

I solved this issue

Thank you for this idea. In the near future I will try.

If anyone else is interested, I solved this issue by

Thank you,  GloverDonovan, very much for this tip. Now dunst working the way I wanted.

Finally, with a calm heart😊💗, I can close this problem. Good luck.

If anyone else is interested, I solved this issue by writing my dunstrc as a user template file and symlinking the resulting cache file to ~/.config/dunst/dunstrc.

ohhh ty! <3

If anyone else is interested, I solved this issue by writing my dunstrc as a user template file and symlinking the resulting cache file to ~/.config/dunst/dunstrc.

I am getting this error, I have done symlinking but still getting this error
WARNING: Invalid color string: '{foreground}'
WARNING: Invalid color string: '{background}'
WARNING: Invalid color string: '{color4}'
WARNING: Invalid color string: '{foreground}'
WARNING: Invalid color string: '{background}'
WARNING: Invalid color string: '{color4}'

I know this is a year later, but @Rockenstien, you need to create the symlink to the generated file in ~/.cache/wal/dunstrc, not the dunstrc file in ~/.config/wal/templates/dunstrc. You have to run pywal at least once to get that file generated from the template.


Rename C256Mgr into FoenixMgr

For historical reasons the scripts are named after the C256, and the messages in the script mention the C256.
Now that the scripts are used for all Foenix computers, not only the C256, it would make sense to rename this like "FoenixMgr" (suggestions welcome).

You may want to consider closing this request and moving it to the https://github.com/pweingar/C256Mgr project. I know the utility is bundled with the kernel, but it is not part of it.

There was a suggestion from someone earlier to rename the script "foenix," which seems pretty reasonable to me. And yes, this is more properly in the other repository. I'll make it an issue there.

See: https://github.com/pweingar/C256Mgr/issues/5


private key is leaked in error logs

2017/05/06 12:14:37 [error] 9610#9610: *68 [lua] lets_encrypt.lua:62: issue_cert(): auto-ssl: dehydrated manual hook.sh failed: env HOOK_SECRET=32cffc43cb.... HOOK_SERVER_PORT=8999 /usr/local/openresty/luajit/share/lua/5.1/resty/auto-ssl/shell/letsencrypt_hooks deploy_cert xxx /etc/resty-auto-ssl/letsencrypt/certs/xxx/privkey.pem /etc/resty-auto-ssl/letsencrypt/certs/xxx/cert.pem /etc/resty-auto-ssl/letsencrypt/certs/xxx/fullchain.pem /etc/resty-auto-ssl/letsencrypt/certs/xxx/chain.pem<PHONE_NUMBER> status: 256 out: hook request failed
(...)
++ cat /etc/resty-auto-ssl/letsencrypt/certs/xxx/privkey.pem
+ local 'PRIVKEY=-----BEGIN RSA PRIVATE KEY-----
(...)

When the hook fails, the private key is written to the log verbatim. While logs are usually only readable by root, this can still be a problem in systems which stream logs via syslog-ng. There are also many setups using the ELK stack to collect logs centrally.

Sorry for the delay in response, but thanks for reporting this. This would definitely be good to cleanup. I'll take a look to see if we can eliminate this from the logging.
It may just be as simple as eliminating the set -x from our hook script, but I haven't verified that yet, and I'd still like to ensure we get some useful debug output if things fail.

This should actually no longer be an issue in v0.10.5+ due to this pull request which changed how we sent the certificates via curl: https://github.com/GUI/lua-resty-auto-ssl/pull/53 After that change, it had the side effect of changing the debug output so that it would only contain the path to the files, rather than the file content. So in these newer versions, the debug output would look more like:
2017/06/18 23:35:56 [error] 1756#0: *15 [lua] lets_encrypt.lua:70: issue_cert(): auto-ssl: dehydrated manual hook.sh failed: env HOOK_SECRET=zz HOOK_SERVER_PORT=8999 /test/run/build/luajit/bin/resty-auto-ssl/letsencrypt_hooks deploy_cert 7214ed43.ngrok.io /tmp/resty-auto-ssl-test/letsencrypt/certs/7214ed43.ngrok.io/privkey.pem /tmp/resty-auto-ssl-test/letsencrypt/certs/7214ed43.ngrok.io/cert.pem /tmp/resty-auto-ssl-test/letsencrypt/certs/7214ed43.ngrok.io/fullchain.pem /tmp/resty-auto-ssl-test/letsencrypt/certs/7214ed43.ngrok.io/chain.pem<PHONE_NUMBER> status: 256 out: nil err: + HANDLER=deploy_cert
+ shift
+ deploy_cert 7214ed43.ngrok.io /tmp/resty-auto-ssl-test/letsencrypt/certs/7214ed43.ngrok.io/privkey.pem /tmp/resty-auto-ssl-test/letsencrypt/certs/7214ed43.ngrok.io/cert.pem /tmp/resty-auto-ssl-test/letsencrypt/certs/7214ed43.ngrok.io/fullchain.pem /tmp/resty-auto-ssl-test/letsencrypt/certs/7214ed43.ngrok.io/chain.pem<PHONE_NUMBER>
+ local DOMAIN=7214ed43.ngrok.io KEYFILE=/tmp/resty-auto-ssl-test/letsencrypt/certs/7214ed43.ngrok.io/privkey.pem CERTFILE=/tmp/resty-auto-ssl-test/letsencrypt/certs/7214ed43.ngrok.io/cert.pem FULLCHAINFILE=/tmp/resty-auto-ssl-test/letsencrypt/certs/7214ed43.ngrok.io/fullchain.pem CHAINFILE=/tmp/resty-auto-ssl-test/letsencrypt/certs/7214ed43.ngrok.io/chain.pem TIMESTAMP=1497828956
+ curl --silent --show-error --fail -XPOST --header 'X-Hook-Secret: zz' --data-urlencode domain=7214ed43.ngrok.io --data-urlencode<EMAIL_ADDRESS>--data-urlencode<EMAIL_ADDRESS>--data-urlencode<EMAIL_ADDRESS>http://<IP_ADDRESS>:8999/deploy-cert

Still, though, that output caused by set -x is probably overly chatty, so I've updated things to remove this debug output: https://github.com/GUI/lua-resty-auto-ssl/commit/d59e14b189655569be6fafa922d8538cab90c68f It will be part of the v0.11.0 release.
In terms of previous exposure in log files, this certainly isn't ideal, although the only thing I'll note is that hopefully the situation where this got logged should be pretty rare (it would require the certificate to not be in storage, and then the manual call to the hook shell script would need to fail).
Thanks for reporting this!

Thanks :)


Creating Bolg/Post

We can create blogs/posts from the command line/terminal right now.
Add functionality to create blogs through the web interface.

You mean to say we have to create post app in django? right and have to add create blog by clicking create? @harsh-9in

And what what inputs will be there ? like Title, description, image And ??? @harsh-9in

You mean to say we have to create post app in django? right and have to add create blog by clicking create? @harsh-9in

I have already created app for that
you can checkout blog app for that
The thing you have to do is to make a form which takes data for our blog and show it on home page.

And what what inputs will be there ? like Title, description, image And ??? @harsh-9in

You have to take two inputs for now that is Title and description.
we will make a support for image in future.

Okay so I will do this please assign me okay @harsh-9in ?

yeah sure go ahead :)  @nooras

I have 1 request please also tag the task is easy medium or hard . Coz I think due to this we will get points :) Thanks

I want to work in this issue.

Hey @kritikaparmar-programmer task is already done...


Deprecations v2

Another round of deprecated stuff removed.
Also added a method to the errors class to log an error message on the use of 2.0-deprecated functions, the idea is to remove these functions before RC and this can be helpful in testing addons (I hope).

BTW 852271f7b99b67fe0266b76bf4c77d639bd6b538 fixes #3077

Is this ready to merge in?

I think so, yes.

Good enough for me !


Theme kit access app - Invalid API key or access token

Describe the bug
When using the new theme kit access app it always gives me this error: [API] Invalid API key or access token (unrecognized login or wrong password)
To Reproduce
Steps to reproduce the behavior:

run command 'theme get --password=[themeki tapp generated password] --store=store.myshopify.com'

Environment (please complete the following information):

OS: Mac os big sur
Themekit version (run theme version to check): 1.3.0

Additional context
Of all the times that I've tried using it it has only worked once. This is also happening to a lot of my colleagues.

@hugos Your current command does not work since it contains unknown flag --name. If you're trying to create a new theme the proper command is theme new --password=[your-password] --store="[your-store.myshopify.com]" --name=[theme name]

@denisinla My bad that's just a typo on I don't actually write it like that lol. I spoke to Shopify, this is known issue there they are trying to fix it.

I have what seems to be the similar issue.
Theme Kit was working fine on our development store.  Then, I started getting this error whenever I tried to run any theme commands, for example:
Steps:

Using Theme Kit 1.3
OS: Mac os big sur
Run any themekit commant (eg/ theme watch)
After about a minute an error would appear:
request failed after 5 retries with error: Get https://theme-kit-access.shopifyapps.com/cli/meta.json: net/http: request canceled while waiting for connection (Client.Timeout exceeded while awaiting headers)
Follow the JSON in the error message,  https://theme-kit-access.shopifyapps.com/cli/meta.json.  The JSON reads like this: {“errors":"[API] Invalid API key or access token (unrecognized login or wrong password)"
I’ve tried several things to remedy but all unsuccessful - Updating Theme kit, Homebrew, switching between Theme Kit Access App / Private App, Updating OS, different shopify stores.
The only thing that fixed it was switching to a different internet connection.  After switching to a different IP theme kit works like normal.

It's unbelievable that this is still happening.

I've found that you can bypass this problem by creating a custom app and configure the Admin API permission to
read_themes,write_themes.

Yeah, alternatively you can include source code in the repo and use the Github integration.
There are a few options for this, but currently the best one i tried is using git subtrees.

Create repo for source code
Create repo for compiled code
Connect a branch of the compiled repo to a Shopify Theme
Build code from src to dist (include dist in version control)
Push contents of dist on the source repo to the root of the compiled repo with:

git subtree push --prefix dist compiled-repo-url $(git branch --show-current)

Pull contents of compiled repo into dist with:

git subtree pull --prefix dist compiled-repo-url $(git branch --show-current) --squash

You can abstract the process of keeping the dist folder always in sync with the subtree by using git hooks:
flowchart TD
    subgraph pre_commit_hook[pre-commit]
        stash_unchanged[git stash -q --keep-index]-->build_theme
        build_theme[yarn build]-->stage_changed[git add -u]
        stage_changed-->apply_stashed_changes=[git stash pop -q]
    end
    subgraph pre_push_hook[pre-push]
        pull_subtree[yarn subtree:pull]
    end
    subgraph post_push_hook[post-push]
        push_subtree[yarn subtree:push]
    end
    pre_commit_hook-->git_commit[git commit]
    git_commit-->pre_push_hook
    pre_push_hook-->git_push[git push]
    git_push-->post_push_hook

Yeah, alternatively you can include source code in the repo and use the Github integration.
There are a few options for this, but currently the best one i tried is using git subtrees.

Create repo for source code
Create repo for compiled code
Connect a branch of the compiled repo to a Shopify Theme
Build code from src to dist (include dist in version control)
Push contents of dist on the source repo to the root of the compiled repo with:

git subtree push --prefix dist compiled-repo-url $(git branch --show-current)

Pull contents of compiled repo into dist with:

git subtree pull --prefix dist compiled-repo-url $(git branch --show-current) --squash

You can abstract the process of keeping the dist folder always in sync with the subtree by using git hooks:
flowchart TD
    subgraph pre_commit_hook[pre-commit]
        stash_unchanged[git stash -q --keep-index]-->build_theme
        build_theme[yarn build]-->stage_changed[git add -u]
        stage_changed-->apply_stashed_changes=[git stash pop -q]
    end
    subgraph pre_push_hook[pre-push]
        pull_subtree[yarn subtree:pull]
    end
    subgraph post_push_hook[post-push]
        push_subtree[yarn subtree:push]
    end
    pre_commit_hook-->git_commit[git commit]
    git_commit-->pre_push_hook
    pre_push_hook-->git_push[git push]
    git_push-->post_push_hook

I had this issue with Theme Kit Access and was able to fix it by updating Theme Kit to the latest version.

I'm on the latest version and still having this error....

It's still happening to be to this day as well. I just use the private apps method.
I'll be closing this for now as this as been happening for too long and a solution does not seem to be coming any time soon.

I have what seems to be the similar issue.
Theme Kit was working fine on our development store. Then, I started getting this error whenever I tried to run any theme commands, for example:
Steps:

Using Theme Kit 1.3
OS: Mac os big sur
Run any themekit commant (eg/ theme watch)
After about a minute an error would appear:
request failed after 5 retries with error: Get https://theme-kit-access.shopifyapps.com/cli/meta.json: net/http: request canceled while waiting for connection (Client.Timeout exceeded while awaiting headers)
Follow the JSON in the error message,  https://theme-kit-access.shopifyapps.com/cli/meta.json.  The JSON reads like this: {“errors":"[API] Invalid API key or access token (unrecognized login or wrong password)"
I’ve tried several things to remedy but all unsuccessful - Updating Theme kit, Homebrew, switching between Theme Kit Access App / Private App, Updating OS, different shopify stores.
The only thing that fixed it was switching to a different internet connection.  After switching to a different IP theme kit works like normal.

it works, thank a lot


javascript next

Any chance support could be added for JavaScript Next? This is a superset of current JS so it should work for all JS code blocks.
Currently if I have ES6 in my code blocks, things like export mess up syntax highlighting for the rest of document.

hmm, normally all we need to do is add the language that belongs to the extensions defined next to the first fence. see: https://github.com/jonschlinkert/sublime-markdown-extended/blob/master/Syntaxes/Markdown Extended.tmLanguage#L417-L444, and https://github.com/jonschlinkert/sublime-markdown-extended/blob/master/Syntaxes/Markdown Extended.tmLanguage#L441. But - unless I'm missing something, es6 would just be source.js stil, which makes me think the issue might not something I can fix here. I'll try to look into to it, but any help/suggestions are welcome.


Manually update crunchbase

Pre-submission checklist:
Please check each of these after submitting your pull request:

[ ] Are you only including a repo_url if your project is 100% open source? If so, you need to pick the single best GitHub repository for your project, not a GitHub organization.
[ ] Is your project closed source or, if it is open source, does your project have at least 300 GitHub stars?
[ ] Have you picked the single best (existing) category for your project?
[ ] Does it follow the other guidelines from the new entries section?
[ ] Have you included a URL for your SVG or added it to hosted_logos and referenced it there?
[ ] Does your logo clearly state the name of the project/product and follow the other logo guidelines?
[ ] Does your project/product name match the text on the logo?
[ ] Have you verified that the Crunchbase data for your organization is correct (including headquarters and LinkedIn)?
[ ] ~5 minutes after opening the pull request, the CNCF-Bot will post the URL for your staging server. Have you confirmed that it looks good to you and then added a comment to the PR saying "LGTM"?

Deploy preview for landscape ready!
Built with commit 00fe534494e9af443441e2ee04f8fa9c7f682f16
https://deploy-preview-1681--landscape.netlify.app

LGTM.
I changed crunchbase.com/organization/zeit with crunchbase.com/organization/vercel
And I also run npm run update locally with some local changes that were smarter when not finding a stock ticker, see: https://github.com/cncf/landscapeapp/pull/561


HADOOP-19082: Update AWS SDK V2 to 2.24.1

Update the AWS SDK to 2.24.1 from 2.23.5 for latest updates in packaging w.r.t. imds module.
How was this patch tested?
Integration Test using mvn clean verify -Dparallel-tests -DtestsThreadCount=16 -Dscale -fae
For code changes:

[x] Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
[x] Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
[ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
[ ] If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

you will need to update LICENSE-binary
and run the hadoop-aws tests -where?
and run the "qualifying an SDK update" steps -where and what problems surfaced?

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 32s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+0 :ok:
detsecrets
0m  1s

detect-secrets was not available.

+0 :ok:
xmllint
0m  1s

xmllint was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s

The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
44m 50s

trunk passed

+1 :green_heart:
compile
0m 21s

trunk passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
compile
0m 21s

trunk passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08

+1 :green_heart:
mvnsite
0m 26s

trunk passed

+1 :green_heart:
javadoc
0m 26s

trunk passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
0m 23s

trunk passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08

+1 :green_heart:
shadedclient
80m 10s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 14s

the patch passed

+1 :green_heart:
compile
0m 13s

the patch passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javac
0m 13s

the patch passed

+1 :green_heart:
compile
0m 13s

the patch passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08

+1 :green_heart:
javac
0m 13s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
mvnsite
0m 14s

the patch passed

+1 :green_heart:
javadoc
0m 13s

the patch passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
0m 13s

the patch passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08

+1 :green_heart:
shadedclient
36m  6s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
0m 17s

hadoop-project in the patch passed.

+1 :green_heart:
asflicense
0m 34s

The patch does not generate ASF License warnings.

122m 33s

Subsystem
Report/Notes

Docker
ClientAPI=1.44 ServerAPI=1.44 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6568/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/6568

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient codespell detsecrets xmllint

uname
Linux 187f99e9288d 5.15.0-91-generic #101-Ubuntu SMP Tue Nov 14 13:30:08 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 6bde82e57031bb376c7c16136eb6c82597e507d6

Default Java
Private Build-1.8.0_392-8u392-ga-1~20.04-b08

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_392-8u392-ga-1~20.04-b08

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6568/1/testReport/

Max. process+thread count
702 (vs. ulimit of 5500)

modules
C: hadoop-project U: hadoop-project

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6568/1/console

versions
git=2.25.1 maven=3.6.3

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

+1 pending you state which s3 endpoint you ran the tests and what the parameters to your test run were.

@HarshitGupta11 need to know where you qualified the SDK...

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 33s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+0 :ok:
xmllint
0m  0s

xmllint was not available.

+0 :ok:
shelldocs
0m  0s

Shelldocs was not available.

+1 :green_heart:
@author
0m  1s

The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s

The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+0 :ok:
mvndep
14m 42s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
31m 41s

trunk passed

+1 :green_heart:
compile
17m  4s

trunk passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
compile
15m 42s

trunk passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08

+1 :green_heart:
mvnsite
20m 45s

trunk passed

+1 :green_heart:
javadoc
8m 37s

trunk passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
7m 42s

trunk passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08

+1 :green_heart:
shadedclient
48m 35s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
1m  7s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
29m 25s

the patch passed

+1 :green_heart:
compile
16m 39s

the patch passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javac
16m 39s

the patch passed

+1 :green_heart:
compile
15m 42s

the patch passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08

+1 :green_heart:
javac
15m 42s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
mvnsite
15m 29s

the patch passed

+1 :green_heart:
shellcheck
0m  0s

No new issues.

+1 :green_heart:
javadoc
8m 26s

the patch passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
7m 43s

the patch passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08

+1 :green_heart:
shadedclient
49m 59s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
733m 15s
/patch-unit-root.txt
root in the patch failed.

+1 :green_heart:
asflicense
1m 38s

The patch does not generate ASF License warnings.

1018m  4s

Reason
Tests

Failed junit tests
hadoop.yarn.server.resourcemanager.reservation.TestCapacityOverTimePolicy

hadoop.hdfs.server.datanode.TestDirectoryScanner

hadoop.hdfs.protocol.TestBlockListAsLongs

Subsystem
Report/Notes

Docker
ClientAPI=1.44 ServerAPI=1.44 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6568/3/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/6568

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient codespell detsecrets xmllint shellcheck shelldocs

uname
Linux 8ba8950c227c 5.15.0-91-generic #101-Ubuntu SMP Tue Nov 14 13:30:08 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 752b1f33ab596284f2b8f85ac1ac5c4a0900c83e

Default Java
Private Build-1.8.0_392-8u392-ga-1~20.04-b08

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_392-8u392-ga-1~20.04-b08

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6568/3/testReport/

Max. process+thread count
4275 (vs. ulimit of 5500)

modules
C: hadoop-project . U: .

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6568/3/console

versions
git=2.25.1 maven=3.6.3 shellcheck=0.7.0

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

@HarshitGupta11 could you upgrade to the latest version, or at least 2.24.6 instead? We found an issue with the S3 async client not implementing abort which is fixed in 2.24.6. This doesn't really affect us currently, but if someone is using Client side encryption, then it might cause issues. Related to #6164

Hi yeah, I have updated the ticket and ran the hadoop test suite again a normal and directory bucket in us-west-2

@HarshitGupta11 need to know where you qualified the SDK...

Still running all the tests as mentioned, I have run the test suite under normal conditions in both kind of buckets but there are a couple of changes needed with CSE-KMS and access point buckets, trying to figure those out.

Ran all the tests as per the Qualifying sdk update, all seems to be fine.


Clean version API

The "Keep this script simple and easily auditable" install.ps1 script has, at its core, a 20 line mess to determine the latest Deno version for Windows:
https://github.com/denoland/deno_install/blob/bd28456269a17a0809e7ca518e199bb9daad557b/install.ps1#L32-L52
(And I know it's a mess because I wrote the damn mess. :))
Deno being on v1.0.0 now, I think it's time to clean up a bit...
I know @lucacasonato tried to create a version API using a worker in https://github.com/denoland/deno_website2/pull/180.
I'd propose an even simpler API: All it's supposed to do is return the latest version released and available on GitHub Releases for each platform as a string, e.g. GET /api/version/windows returns v1.0.0.
Internally, the API would make the same mess that the installer script does at the moment, e.g. parse the HTML from https://github.com/denoland/deno/releases, check for the first anchor tag that matches a Windows release, return the number (plus some caching maybe).
If we had an API like that, those 20 lines would be a single one...
Not to mention that the same mess happens in the install.sh script which would benefit massively from this API as well.

I built an API like that for a personal project: https://gist.github.com/MarkTiedemann/6ec5dc6b4f968296fa7e7b578ca91ad6
Again, we could greatly simplify both of our installer scripts with an official API like this. :)

@ry PTAL

I've made a pr #152  which looks like this.
@MarkTiedemann

Hi @Summpot. The reason why we can't use the GitHub API to get the latest release is that it is rate-limited, unless you provide a GitHub token. However, we cannot expect everyone to get a GitHub token before installing Deno using the script. That's why we parse the non-rate-limited releases page (https://github.com/denoland/deno/releases), which is plain HTML, to get the latest version reliably.

GitHub provides a mirror to the latest release and it's assets at:

release: https://github.com/:owner:/repo/releases/latest
assets: https://github.com/:owner:/repo/releases/latest/download/:asset

This doesn't depend on github api, so isn't rate limited, and also cleans up the mess to absolute minimal.
see #167


Gtk renderer image

Added basic Image support for GTK and added an example to the demo app.

Apologies, GitHub closed it automatically for some reason, while usually it should've only changed the target branch to main after it was merged. I'll re-create this in a separate PR.


Format float and double with enough digits to not lose any precsion

Template float/double used %f which default to 6 digits.
Data inspector used unnecessary precsion that might be confusing.
Maybe something similar should be done for 16, 80 and 128 bit floats.

This was a good resource to understand more https://stackoverflow.com/questions/16839658/printf-width-specifier-to-maintain-precision-of-floating-point-value


[Education] Tutorials to showcase the work

Some help needed to write tutorials (jupyter notebook) to show how to use the algorithm. There is  a  test on real-word data that could be used as an example. Please refer to https://github.com/elenasuraeva/HeartAxis.

Closing with the following commits:

commit 82ef3e0 - Training on synthetic data.
commit 882c8a5 - Hear Axis Training.


unrar: build on darwin

Things done:

[ ] Tested using sandboxing (nix-build --option build-use-chroot true or nix.useChroot on NixOS)
[x] Built on platform(s): OSX / Linux
[x] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[x] Fits CONTRIBUTING.md.

More
Fixes issue #
cc @ehmry

Please note, that points are not mandatory, but rather desired.

Thanks, looks better!
This doesn't build for me -- Makefile is not found. I think that's because unrar actually has makefile (notice casing) -- because you test it on case-insensitive FS on Mac OS X it doesn't affect you.
Also please use consistent indentation (look at buildPhase for example) and postPatch is preferred over patchPhase because we don't rule out applying other actual patches in the future.

Thanks for the feedback @abbradar
Glossed over the indentation when removing the isDarwin statements. I have also used postPatch as suggested.

Thanks, works for me now.


⚠ Adacta-fintech.com has degraded performance

In 4e9c4d2, Adacta-fintech.com (https://www.adacta-fintech.com) experienced degraded performance:

HTTP code: 200
Response time: 1269 ms

Resolved: Adacta-fintech.com performance has improved in 4b400de.


messageStore How To

Describe the feature
Hello @transitive-bullshit ,
It would be very useful if you could please write an example in README of how to use messageStore, it will help many people (including me :) ) in how to add history to chatgpt-api

See https://github.com/transitive-bullshit/chatgpt-api/blob/main/demos/demo-persistence.ts

This project is undergoing a major revamp; closing out old issues as part of the prep process.
The chatgpt package is pretty outdated at this point. I recommend that you use the openai package or the openai-fetch package instead.


Initialize addresses property with urls array

Initialize the Addresses property using the urls array, instead of allocating a new list (with backing array, possibly with wrong initial size) and copying the contents.

Hi @khellang, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!
The agreement was validated by .NET Foundation and real humans are currently evaluating your PR.
TTYL, DNFBOT;

Spoke to @khellang offline and closing this as a result


Question about field used hash function

Hi, I'm a little wondering the hash function name which used by beast::http::detail::field_table. Seems like it's a multiplying hash function. But I don't exactly know why we should multiple 5 other than other prime values in field_table::digest(). And why the size of hash table is 5155? I have tried to search the relevant materials, but can not find the relevant explanation. Could you help solve the confusion? Thank you.

I believe 5155 is chosen because the table only has two buckets for collision resolution, and that size accommodates everything fitting into the table with at most one collision.
@pdimov, Could you please shed some light on the reasoning behind these?

I believe 5155 is chosen because the table only has two buckets for collision resolution, and that size accommodates everything fitting into the table with at most one collision. @pdimov, Could you please shed some light on the reasoning behind these?

Thanks for such a quick answer:) table does have only two buckets to handle conflicts, and, uh, now I'm getting more curious about how 5155 works better than the other primes in the case of only two buckets.

If I remember correctly, 5155 has been chosen empirically, by trying all sizes until one has the right properties (no collisions in the first 256 names and no collisions in the last n-256 names.)
This should probably be converted into a proper perfect hash table one day as this one is a bit ad hoc. Maybe @joaquintides can find this an interesting application of his latest research.

We might also start removing the least used field constants until we have a set of fields for which a highly performant hash function is discovered.

As for the 5 multiplier, I also don't remember why I chose it; I was probably optimizing lookup time on a synthetic benchmark.
For the multiplicative hash function (H = m*H + c), the traditional multipliers are 5, 31 and 33, because (in the past) they would have been efficiently expressed as (x << 2) + x, (x << 5) - x and (x << 5) + x, respectively. (They aren't the best multipliers by any measure; they were just popular in the past.)

As for the 5 multiplier, I also don't remember why I chose it; I was probably optimizing lookup time on a synthetic benchmark.
For the multiplicative hash function (H = m*H + c), the traditional multipliers are 5, 31 and 33, because (in the past) they would have been efficiently expressed as (x << 2) + x, (x << 5) - x and (x << 5) + x, respectively. (They aren't the best multipliers by any measure; they were just popular in the past.)

Great. I get it. 5 was chosen as a factor for the multiplicative hash function because the multiplication of 5 can be converted into an efficient bit operation. 5155 as the hash table length is derived from the experience value.
Thank you and others for your answers.


Project Parser does not support Wildcards.

The following is a valid ItemGroup entry in a Visual Studio Project:
   <ItemGroup>
        <None Include="WildCardIncludes\**\*.txt">
            <CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>
        </None>
    </ItemGroup>

However, the project parser will fail if it encounters such an entry.

I've updated the project parser and I am willing to submit a PR for review.

Will be interested in seeing the PR in that it may also address the pattern(s) identified in GH-1299

@rpriest1260 @kcamp have both of you tried the Project Parser that lives in Cake.Incubator?  While things were churning in the csproj format, the parser logic was being updated over there.  At some point, I think soon, we need to move the logic from Cake.Incubator into Cake proper.

I haven't attempted the incubator implementation in production implementations; I wound up working around the issue in a different way.   I knocked together a quick test case against the incubator implementation.  While it avoids the unhandled exception, it still doesn't quite meet expectations.
Given a csproj containing this
<ItemGroup>
    <Compile Include="**\*.cs" />
  </ItemGroup>
  <ItemGroup>
    <None Include="packages.config" />
  </ItemGroup>

My, perhaps wrong, expectations would be for the parser to unfold the glob similar to the MSBuild/VS runtime.  As it stands, that sample (above) fails with
.... to not have any items matching x.FilePath.Path.Contains("**"), but found {Cake.Incubator.CustomProjectFile
   {
      Compile = True
      FilePath = Cake.Incubator.ProjectPath
      {
         IsFile = True
         Path = "**\*.cs"
      }
      RelativePath = "**\*.cs"
   }

I had originally introduced the Globber into the mix via PR-1529 as a potential solution, but that branch/PR is quite outdated at this point.
It may be worth resurrecting some of that code for integration into the incubator's implementation to fully address this?  Or at least discussing what the expected return values should be for a wildcarded inclusion?

Did you have any thoughts on this @wwwlicious

I've handled the globbing in my revised code. I will submit a pull request shortly.

@rpriest1260 which PR?  I would suggest a PR to Cake.Incubator would make the most sense, as we will likely take everythign from there into Cake.

I was just about to submit one. I did the work against the current project parser code, not the incubator.  I will create a branch against the incubator, apply my changes there, and submit the PR using that.  I will respond back when complete.

The current incubator project doesn't build. Seems like the cake version isn't pinned?
Preparing to run build script...
Running build script...
Analyzing build script...
Processing build script...
Installing addins...
Error: The assembly 'Cake.Codecov, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=null'
is referencing an older version of Cake.Core (0.22.0).
This assembly need to reference at least Cake.Core version 0.26.0.
Another option is to downgrade Cake to an earlier version.
It's not recommended, but you can explicitly opt-out of assembly verification
by configuring the Skip Verification setting to true
(i.e. command line parameter "--settings_skipverification=true",
environment variable "CAKE_SETTINGS_SKIPVERIFICATION=true",
read more about configuration at https://cakebuild.net/docs/fundamentals/configuration)

I'm pretty sure you don't want me to commit without first building everything :)

@rpriest1260 use  --settings_skipverification=true to build. This is fine.

thanks @wwwlicious , I thought of that. Setting CAKE_SETTINGS_SKIPVERIFICATION=true gets you passed the first error. But then the "DupFinder"  throws an error. I guess it would just help if someone ran a more recent build of the incubator stuff.:
========================================
DupFinder
========================================
Executing task: DupFinder
Deleting file Z:/test/cake/forks/cake_incubator_rpriest1260/92338360-91be-46bf-8320-574ab4e5d07e.cake
JetBrains Duplicates Finder 2017.2
Running in 64-bit mode, .NET runtime 4.0.30319.42000 under Microsoft Windows NT 6.2.9200.0
Collecting files to analyze:
  from project 'Z:\test\cake\forks\cake_incubator_rpriest1260\src\Cake.Incubator.sln' excluding: Z:/test/cake/forks/cake_incubator_rpriest1260/src/Cake.Incubator/**/*.AssemblyInfo.cs;Z:/test/cake/forks/cake_incubator_rpriest1260/src/Cake.Incubator.Tests/*.cs;Z:/test/cake/forks/cake_incubator_rpriest1260/src/Cake.Incubator/CustomProjectParser.cs;Z:/test/cake/forks/cake_incubator_rpriest1260/src/Cake.Incubator/DotNetCoreTestExtensions.cs.
32 files found to analyze.
Duplicates report was written to Z:\test\cake\forks\cake_incubator_rpriest1260\BuildArtifacts\TestResults\DupFinder\dupfinder.xml
Total time: 00:00:08.3906250
User time: 00:00:06.8281250
Peak virtual memory: 4983MB
Peak working set: 279MB
Duplicate Located with a cost of 142, across 2 Fragments
File Name: src\Cake.Incubator.Tests\obj\Debug\net462\Cake.Incubator.Tests.AssemblyInfo.cs Line Numbers: 1 - 24
File Name: src\Cake.Incubator.Tests\obj\Debug\netcoreapp2.0\Cake.Incubator.Tests.AssemblyInfo.cs Line Numbers: 1 - 24
An error occurred when executing task 'DupFinder'.
Deleting file Z:/test/cake/forks/cake_incubator_rpriest1260/8faf14c9-9236-4c7f-b3d5-c143c42089f7.cake
Duplicates were found in your codebase, creating HTML report...
XSL Transformation complete

I've attached a copy of the dupfinder report from my build. FYI - the attach didn't accept .html files so I renamed it to .txt.
dupfinder.txt

I found the issue with the dup finder. It appears there is a missing exclusion.  Here is the diff:
diff --git a/setup.cake b/setup.cake
index a83d396..b761757 100644
--- a/setup.cake
+++ b/setup.cake
@@ -17,6 +17,7 @@ BuildParameters.PrintParameters(Context);
 ToolSettings.SetToolSettings(context: Context,
                             dupFinderExcludePattern: new string[] {
                                                                BuildParameters.RootDirectoryPath + "/src/Cake.Incubator/**/*.AssemblyInfo.cs",

+                                BuildParameters.RootDirectoryPath + "/src/Cake.Incubator.Tests/**/*.AssemblyInfo.cs",
                                 BuildParameters.RootDirectoryPath + "/src/Cake.Incubator.Tests/*.cs",
                                 BuildParameters.RootDirectoryPath + "/src/Cake.Incubator/CustomProjectParser.cs",
                                 BuildParameters.RootDirectoryPath + "/src/Cake.Incubator/DotNetCoreTestExtensions.cs" },

I will leave it for now until I finish the task at hand. If no one else gets to it, I will check it in.

Hello.  Any thoughts on my pull request  to satisfy this issue?  I submitted it yesterday.

@rpriest1260 apologies for the radio silence, I'm away at the moment with limited connectivity. I'll catchup on the PR towards the end of next week

@wwwlicious  sounds good. Thanks for the update.


nix.md

added the github: prefix to the nix run command. Without that, the command only works when you have previously cloned this repo and pwd is in the root folder of the repo. With the prefix, there's no need to clone anything, nix just runs roc.

just saw, that this is a duplicate of https://github.com/roc-lang/roc/pull/6370 now.

Thanks for alerting us @michi-zuri!
It seems most correct to merge the first/old PR so that's what I'll do :smile:


Issue/1/sims module stubs

requested changes addressed:

when generating the population, we read from a sim_config and write output files back to the same folder the sim_config is in
when doing inference, we read the sim_dir which has the output intermediate files from that step and we read the config_dir, from which we get our config params and to which we right the output of inference
added subselection of mc_pairs based on some user specified cuts we want to make. currently the only option is to include all mc_pairs, but we can change that as we see fit

requested changes addressed

@cavestruz bump


Update to latest RML specification

RML-Core Specification

Hi!
We are planning to move towards the new RML specification, but it might take some time before everything is finalized in the RML Core specification.

Implemented in 7.0.0!


Compilation bug with clang 3.4

When compiling with clang 3.4 I get:
[..]minisat/minisat/core/SolverTypes.h:55:16: error:
      friend declaration specifying a default argument must be a definition
    friend Lit mkLit(Var var, bool sign = false);

+1

Same issue here.

This can be worked around by providing another definition for mkLit.
This patch compiles cleanly for me with clang-3.7.
diff --git a/minisat/core/SolverTypes.h b/minisat/core/SolverTypes.h
index 89986d1..9875f7f 100644
--- a/minisat/core/SolverTypes.h
+++ b/minisat/core/SolverTypes.h
@@ -52,7 +52,7 @@ struct Lit {
     int     x;

     // Use this as a constructor:
-    friend Lit mkLit(Var var, bool sign = false);
+    // friend Lit mkLit(Var var, bool sign) ;

     bool operator == (Lit p) const { return x == p.x; }
     bool operator != (Lit p) const { return x != p.x; }
@@ -60,6 +60,7 @@ struct Lit {
 };

+inline  Lit  mkLit     (Var var) { bool sign = false; Lit p; p.x = var + var + (int)sign; return p; }
 inline  Lit  mkLit     (Var var, bool sign) { Lit p; p.x = var + var + (int)sign; return p; }
 inline  Lit  operator ~(Lit p)              { Lit q; q.x = p.x ^ 1; return q; }
 inline  Lit  operator ^(Lit p, bool b)      { Lit q; q.x = p.x ^ (unsigned int)b; return q; }

@niklasso can you please fix this? I don't agree with the fix by @johntyree because it's not clean, but we can just set the default value in the declaration+definition instead of the friend declaration. Please.... it's breaking everything.
Thanks!
Mate


Don't restrict version of VC

This PR attempts to loosen the build requirements by not restricting the version of MSVC that is used.

Checklist

[x] Used a fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[x] Reset the build number to 0 (if the version changed)
[x] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[x] Ensured the license file is being packaged.

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.


filter for self dms

The DMs screen was showing an entry for your own DM, but it contained events from every DM that you've been involved in.
I filtered out the DMs that you sent to yourself for that message, almost like the "note to self" feature on Signal.

FWIW I also have a branch that actually makes this a 'Note to Self' section if that interests anyone:
Screenshots below:


feat: add input function by typing to timepicker

Proposed changes

Following up issue-118 Time Picker allow for typing input, I have added time input by typing functionality. The user can edit the time and minute on the digital clock directly while original functionality remains same. I have updated /js/timepicker.js. But I tested with docs/js/materialize. Please let me know if I picked up the wrong file. Once my direction is accepted, I will also add tests and update the documentation as well. And I would appreciate any feedback or other direction. I will quickly follow up.
Screenshots (if appropriate) or codepen:

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue).
[x] New feature (non-breaking change which adds functionality).
[ ] Breaking change (fix or feature that would cause existing functionality to change).

Checklist:

[x] I have read the CONTRIBUTING document.
[x] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have added tests to cover my changes.
[x] All new and existing tests passed.

Please review my updated code along with my demo on codepen. Thanks!
https://codepen.io/genne23v/pen/oNdmgvM?editors=1111

Code is approved ! Thanks again.
However, the code quality pipeline will fail due to a wrong commit title format.

You either need to rename them or create a new pull request with a fresh commit in order for the pipeline to pass, unfortunately.
To generate a commit message that respect the convention, you can use https://commitlint.io/

I have updated PR title. I'm not sure if this is going to pass the pipeline. Please let me know. Thanks

I have updated PR title. I'm not sure if this is going to pass the pipeline. Please let me know. Thanks

No, by "title" I meant the commit titles 👇

A possible way to fix this is to :

make a local copy of your code somewhere
return to the main branch and create a new branch
paste the code
commit the whole using the correct commit title
Open a new Pull Request

Or by doing a git rebase (see https://stackoverflow.com/a/41987851)
Anyway, make sure to make a save before applying the steps I mentioned before, as the steps involves rewriting your changes.

I have updated PR title. I'm not sure if this is going to pass the pipeline. Please let me know. Thanks

No, by "title" I meant the commit titles 👇

A possible way to fix this is to :

make a local copy of your code somewhere
return to the main branch and create a new branch
paste the code
commit the whole using the correct commit title
Open a new Pull Request

Or by doing a git rebase (see https://stackoverflow.com/a/41987851)
Anyway, make sure to make a save before applying the steps I mentioned before, as the steps involves rewriting your changes.

I removed the failing branch. Please let me know if this works. Sorry for any inconvenience.

Sorry, there are still two commits that are not valid...

I removed other commits too. Hope this passes. Thanks

Thanks for the approval. Yes, it's a part of hacktoberfest.

Thank you a lot for taking your time on this valuable contribution, this project needed it.
It was a bit time-wasting with this story of commit title, but we've made it finally!

It's my pleasure since it's my first open source contribution. I think I will remember this PR for long time. It's really nice framework and I hope I will contribute more to this. Thank you!

btw, I invited you as the member of materializecss. Welcome! 🎉

Thank you for the invite. I'm looking forward to more contributions!

Hello, I just migrate to 1.2.0 and I tested this functionnality but it seems it doesn't work on my side. I can edit time value manually but it doesn't update clock and when I save hour is not save as I choose. As you can see in the following screenshot I put '30' manualy via my keyboard and it doesn't do anything even if I left focus of the input. Did I misunderstand this new feature ?

@AurelienTisserand you need to press enter on the keyboard to confirm it

@AurelienTisserand you need to press enter on the keyboard to confirm it

Thank you for you answer @Smankusors but on my side pressing enter is submitting my form without updating the date. Did I miss something ?

Thank you for you answer @Smankusors but on my side pressing enter is submitting my form without updating the time. Did I miss something ?

hmm... can you create a small reproduceable codepen/jsfiddle for this? 😅


Symbolic links should be checked for validity

When fixing firefoxWrapper's (lack of an) icon, I found that the problem was a broken symlink generated by the package (line, should be ${browserName}${nameSuffix} in the source). @ttuegel suggested on IRC that a check be put in for such problems, "something like if [[ ! -f $(readlink -f $symlink) ]]; then echo "Icon symlink missing!"; exit 1; fi in the postInstall phase". I figured such a check would be useful for all packages, as it's rare that we want to make a broken symlink. I don't know enough to know if it would be plausible to do such a check on all the symlinks generated by packages, or just the ones the Nixexpr makes on its own, but this is mainly to get the idea flowing around.

Yes, I think we can do that. We pass the output a few times already, and another pass probably won't slow us down too much.

Maybe we should use cp -s instead of ln to create symlinks.

Maybe we should use cp -s instead of ln to create symlinks.
That would be a good start, but we don't have control over what make, etc. are doing.

(triage) Anyone interested? Otherwise I suggest we close.


Cook's distance

closes #75

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

42 of 44 (95.45%)  changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.07%) to 93.28%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/sklearn_evaluation/plot/regression.py
41
43
95.35%

Totals

Change from base Build<PHONE_NUMBER>:
0.07%

Covered Lines:
2346

Relevant Lines:
2515

💛  - Coveralls

@edublancas Fixed the review comments but I see some tests are failing after the flake8 addition.

@neelasha23 I just realized I broke the CI, I'll fix it! then you can rebase

@neelasha23 CI fixed, please rebase!


[SwiftSyntaxBuilder] Add support for control flow statements in result builders

Add the buildOptional etc. result builder constructs to add support for control-flow constructs inside the result builders.
CC: @czechboy0

@swift-ci Please test


feat(hardware): Hardware error codes

Now that we can express error codes in all our client interfaces, let's start raising them.
This PR makes the opentrons_hardware module use the new exceptions that have the new error codes. There's a couple new error codes, but mostly all this does is raise different exceptions in the same places.
The two exception is in the can messenger and the movegrouprunner.
CAN Messenger
The CAN messenger has this asyncio task that reads stuff asynchronously from the bus and passes it to registered listeners. In addition, if a message is an error message it would raise an exception. But, it's a task, so that exception doesn't go anywhere. #12963 made this exception just logged and swallowed but, like... why does it exist? So we removed it.
MoveGroupRunner
A similar issue happens in MoveGroupRunner, where a background task accumulates responses and then pops them on over to the caller. This works the same now, but we can also move the move stop condition checking inside that loop. We can also now properly handle having multiple errors in a move group!
Note: You need to run make setup-py again since now hardware depends on shared-data.
Review Requests

Give a skim over most stuff
Look more in-depth at MoveGroupRunner and at CANMessenger

Testing

[x] Cause some errors and maek sure it doesn't break in new ways.

This is great! Is there a follow-up pr on the robot-server side to handle any of these errors getting propagated?

Nope, that one was already merged. All the structures to forward these errors should already be in place in robot server and protocol engine.


Add project board link to readme file

Velntina writes: As per Step 14, could you open the README file, could you add add a heading "Project Boards" and then below that heading to insert the link https://github.com/orgs/Team-DBA-TDD-Training/projects/1

readme updated with the link to the project board


Lesson 19: user genarator to create all the service's crud code

all the code have tested, running properly.

looks no issue, approved


Restructure editor layer so it does not refer directly to types in analysis

In persistence scenario there are no full types. We need to make sure completion, tooltips, etc do not expect full types. Needs #1088.

Not needed, replaced by #1112


PHP Fatal error:  Uncaught Error: Call to a member function error() on null in wp-content/plugins/crowdsec/inc/Bounce.php:339

I have this issue : in STREAM mode, wordpress cron task does not work for updates from the local API.
In /wp-content/debug.log
[11-May-2022 09:17:14 UTC] PHP Fatal error:  Uncaught Error: Call to a member function error() on null in /var/www/clients/client0/web5/web/wp-content/plugins/crowdsec/inc/Bounce.php:339 Stack trace: #0 /var/www/clients/client0/web5/web/wp-content/plugins/crowdsec/inc/bounce-current-ip.php(27): Bounce->safelyBounce() #1 /var/www/clients/client0/web5/web/wp-includes/class-wp-hook.php(307): safelyBounceCurrentIp() #2 /var/www/clients/client0/web5/web/wp-includes/class-wp-hook.php(331): WP_Hook->apply_filters() #3 /var/www/clients/client0/web5/web/wp-includes/plugin.php(474): WP_Hook->do_action() #4 /var/www/clients/client0/web5/web/wp-settings.php(450): do_action() #5 /var/www/clients/client0/web5/web/wp-config.php(106): require_once('/var/www/client...') #6 /var/www/clients/client0/web5/web/wp-load.php(50): require_once('/var/www/client...') #7 /var/www/clients/client0/web5/web/wp-cron.php(44): require_once('/var/www/client...') #8 {main}   thrown in /var/www/clients/client0/web5/web/wp-content/plugins/crowdsec/inc/Bounce.php on line 339
I'm testing this on 4 WP sites (different themes / plugins / WP versions) on the same ISPConfig Debian 11 server with NGINX & PHP 7.4.
Crowdsec plugin version is 1.4.1
I have crowdsec installed locally. In the LIVE mode, i see events in /var/log/crowdsec_api.log.
In STREAM mode i only see expected events when activating the plugin or manually clicking on "Refresh the cache now"
This also blocks all other Wordpress cron jobs. I can see this with Wordpress plugin "WP Crontrol". Manually executing the task from "WP Crontrol" trows the same error.

Update, i noticed that if I use another plugin "Advanced CRON Manager" and issue "Execute now" for the task, it gets executed without error, and in crowdsec_api.log i get the expected result.
time="11-05-2022 12:33:55" level=info msg="<IP_ADDRESS> - [Wed, 11 May 2022 12:33:55 EEST] \"GET /v1/decisions/stream?startup=false&scopes=Ip%2CRange HTTP/1.0 200 61.844197ms \"WordPress CrowdSec Bouncer/v1.4.1\" \""
For the scheduled task the error still persists.
I don't know how each "CRON" plugin manually executes the task, maybe this can help.

Thanks for reporting this. As for the issue https://github.com/crowdsecurity/cs-wordpress-bouncer/issues/90 , it seems that something does not work as expected for some cron process.
We will try to debug this as soon as possible.

Hi.
I am using normal wp-cron.php.
I've also tried disabling it with : define('DISABLE_WP_CRON', 'true'); and setting a system cronjob to run at each minute.  I get the same error in the wp-content/debug.log.
Cronjob used:
* * * * * wget -qO- https://my-example-site.net/wp-cron.php?doing_wp_cron >/dev/null 2>&1
Other info : I'm using a custom port for the API, because 8080 is used by another app. It's set also in the plugin.
And I am using this list of Cloudflare's CDN IP's : <IP_ADDRESS>/20, <IP_ADDRESS>/22, <IP_ADDRESS>/22, <IP_ADDRESS>/22, <IP_ADDRESS>/18, <IP_ADDRESS>/18, <IP_ADDRESS>/20, <IP_ADDRESS>/20, <IP_ADDRESS>/22, <IP_ADDRESS>/17, <IP_ADDRESS>/15, <IP_ADDRESS>/13, <IP_ADDRESS>/14, <IP_ADDRESS>/13, <IP_ADDRESS>/22
I have tested the plugin without any CDN IP's but it's the same.
Another custom option that i have is in NGINX logging, replacing $remote_addr with $http_cf_connecting_ip, but this should't influence the cron jobs.
If you need more info, just let me know.

Hi @cRUSHr2012 ,
I just released a 1.4.2 version on of the crowdsec plugin : this will not solve the issue, but you should find more relevant error messages in your wp_content/debug.log file (assuming the WP_DEBUG and WP_DEBUG_LOG constants are defined to true).
Those messages should begin with safelyBounce error:.
Could you please use the 1.4.2 version and share the messages you will find in your debug.log

Hi, after the update I see this in debug.log :
[13-May-2022 10:45:53 UTC] safelyBounce error:session_start(): Cannot start session when headers already sent (Error level: 2) in file:/var/www/clients/client0/web5/web/wp-content/plugins/crowdsec/inc/Bounce.php(line 322)
But, it works !
crowdsec_api.log
time="13-05-2022 13:45:53" level=info msg="<IP_ADDRESS> - [Fri, 13 May 2022 13:45:53 EEST] "GET /v1/decisions/stream?startup=false&scopes=Ip%2CRange HTTP/1.0<PHONE_NUMBER>12ms "WordPress CrowdSec Bouncer/v1.4.2" ""
time="13-05-2022 13:46:53" level=info msg="<IP_ADDRESS> - [Fri, 13 May 2022 13:46:53 EEST] "GET /v1/decisions/stream?startup=false&scopes=Ip%2CRange HTTP/1.0 200 79.684122ms "WordPress CrowdSec Bouncer/v1.4.2" ""
I've tested it on the WP site running on cPANEL and also works.

Thanks for the update.
Well, the initial error is now well logged without throwing the fatal error. So, I guess it should not break any other processes anymore.
But, the initial error is still there, and I will work on it.
As far as I understand, headers are already sent when we are trying to start the session. I guess some other process is sending the header before the crowdsec plugin loading. I will see what we can do to handle this in a better way.

Hi @cRUSHr2012,
I just released a 1.4.3 version of the crowdsec plugin : it should avoid the "headers already sent" error.
Could you please try it ?
The debug.log file shouldn't have any  safelyBounce error in it anymore.
Thanks

All good now !  Tested on both sites.


Initial UI

Have the initial UI display an infinite slideshow of jobs available, which change every 6 seconds on the entire screen. On the upper left corner, have the current time and date displayed.

The jobs displayed will have the following format:
[Job Description]
[Company]
[Full Location: City, County, Country, Remote/Onsite/Hybrid]
The job description should be displayed in the biggest font, the company in a medium, and the location in the smallest of the three.

please get in touch with Napoleon for UX/UI


BUG : Link not proper when we go from services to contact us

Link is redirecting to "offers" when we click on contact us in footer of services section.
https://github.com/khushi-joshi-05/Food-ordering-website/assets/162733812/24e4b229-c706-4413-a972-cc845befd414

@sunny0625 @khushi-joshi-05 I have solved this issue, please review it and merge it under gssoc level


Support react native 0.73.0

Hi! 👋
Firstly, thanks for your work on this project! 🙂
Today I used patch-package to patch<EMAIL_ADDRESS>for the project I'm working on.
This was done to support Android for react-native v0.73.0, Upcoming 0.73.0 has a breaking change for android due to AGP

[Android] Bump to AGP 8.0 https://github.com/react-native-community/discussions-and-proposals/issues/

breaking changes for libraries -> https://developer.android.com/build/releases/gradle-plugin#namespace-dsl
https://github.com/facebook/react-native/pull/37019
example: https://github.com/expo/expo/pull/22609/files#diff-ef1f15fe3a85e91b5b14cecbe065dd88e055f86f9b54c66fbdfd2c40ce95aa4b

see: https://github.com/reactwg/react-native-releases/discussions/64 for more info
let me know if you would accept PRs.

Here is the diff that solved my problem:
diff --git a/node_modules/react-native-leveldb/android/build.gradle b/node_modules/react-native-leveldb/android/build.gradle
index 4d233b7..c43a7b2 100644
--- a/node_modules/react-native-leveldb/android/build.gradle
+++ b/node_modules/react-native-leveldb/android/build.gradle
@@ -47,7 +47,7 @@ repositories {

 android {
   compileSdkVersion safeExtGet('compileSdkVersion', 28)
-
+  namespace 'com.reactnativeleveldb'
   // Used to override the NDK path/version on internal CI or by allowing
   // users to customize the NDK path/version from their root project (e.g. for M1 support)
   if (rootProject.hasProperty('ndkPath')) {
diff --git a/node_modules/react-native-leveldb/android/src/main/AndroidManifest.xml b/node_modules/react-native-leveldb/android/src/main/AndroidManifest.xml
index 9cdec5b..0a0938a 100644
--- a/node_modules/react-native-leveldb/android/src/main/AndroidManifest.xml
+++ b/node_modules/react-native-leveldb/android/src/main/AndroidManifest.xml
@@ -1,4 +1,3 @@
-<manifest xmlns:android="http://schemas.android.com/apk/res/android"
-          package="com.reactnativeleveldb">
+<manifest xmlns:android="http://schemas.android.com/apk/res/android">

 </manifest>

This issue body was partially generated by patch-package.

Thanks a lot for your changes. Would you like to open a PR with these changes? Else I can integrate them myself.


[BUG] DebugPlugin various updates

Issues with the DebugPlugin

sample.js has wrong namespace
Add search highlight matching
Add simple wildcard search matching
Update search triggering to automatically search during typing delay
Start defining Debug config settings

Fully Deployed to CDN and NPM as version 2.5.7


Easy-add asterisk (Super optional!)

Feel free to reject if it's more trouble than it seems worth to you, but I just added this code to my current table to indicate with an asterisk when something is significant. Could be cool? Or not? Your call. :)
   mutate(Predictor = case_when(`p (FDR)` < .05 ~ paste0(Predictor, "*"),
                                TRUE ~ Predictor))

This was to get around the lack of bold in the fauna tables. Works great as an alternative!

Added. Not the cleanest, but it works (see star, star_source, star_dest, and star_alpha)


LZSS compression interactive not encoding text correctly

For the example below it should replace all but the first 2 characters with a pointer.

New version is an improvement but ignores text that hasn't yet been encoded when encoding the next bit of text. For example:
abababababababa is encoded as ab 0-2 0-4 0-7, but it should be ab 0-13
According to Tim:

It's might seem a bit odd, as the reference includes itself, but it all works out if you decode it.


Docs mention non-existent Finset.univ'

https://github.com/leanprover-community/mathlib4/blob/f1919fd4e80a859f53111cf94437b0f85b5d345a/Mathlib/Data/Finset/Basic.lean#L33-L38
Not sure what this refers to. I searched the Mathlib 3 docs and didn't see Finset.univ' defined there either. Did this exist in some prior iteration of Mathlib? If there's no interest in adding it, then we should update the docs to remove the mention of it.

Looks like it was added in leanprover-community/mathlib#5893 (cc: @winston-h-zhang ), although the referenced file was changed at the last minute from data.finsum (which did not exist) to data.fintype.basic (which did not have any univ' definition): https://github.com/leanprover-community/mathlib/pull/5893/commits/0c0d9517e50dbaaffb16cfbb3d5e0221179e685e#r583254235 . finsum was at the time concurrently going through the PR process in leanprover-community/mathlib#6355, and it's possible that it was a reference to that (since it has a similar case-disjunction definition).


Remove alert note in "Tutorial: Write your first analyzer and code fix"

Remove alert note in Tutorial: Write your first analyzer and code fix, when the Visual Studio 2019 version to fix the template bug is released.
Alert note was added in #19333
Related to:
https://github.com/dotnet/roslyn-sdk/issues/514
https://github.com/dotnet/roslyn-sdk/pull/531

After 16.7 is released, I think the information would still be useful for developers who didn't update to latest versions. The note might just get updated from:

The current Visual Studio template has a known bug in it and should be fixed in Visual Studio 2019 version 16.7. The templates will not compile unless the following changes are made:

to

If you are using a version older than Visual Studio 2019 version 16.7. The template will not compile unless the following changes are made:

Closed in #20070


Add badges to README

Codecov Report
Base: 95.60% // Head: 95.60% // No change to project coverage :thumbsup:

Coverage data is based on head (58cb03a) compared to base (7f8b8ac).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main       #2   +/-   ##
=======================================
  Coverage   95.60%   95.60%
=======================================
  Files           1        1
  Lines          91       91
=======================================
  Hits           87       87
  Misses          4        4

Flag
Coverage Δ

unittests
95.60% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Implement outcome for transactions & spans

What does this PR do?
Fixes #1354
Implementation checklist
add outcome to the following plugins:

[x] public API (so it can be set by user)
[x] gRPC
[x] HTTP client plugins

[x] httpclient
[x] asynchttpclient
[x] jdk-httpclient
[x] ok-http
[x] urlconnection

[x] Servlet
[x] Opentracing
[x] Other plugins

[x] dubbo
[x] es-restclient
[x] JDBC
[x] JMS
[x] Kafka
[x] RabbitMQ
[x] MongoDB
[x] Process - we can't detect proper process termination, thus would be better handled as part of https://github.com/elastic/apm-agent-java/issues/966
[x] Quartz
[x] Redis
[x] Scheduled annotation

Extra:

[x] restore & update gRPC test module with latest version (gRPC 1.35) fixes #1298
[x] add missing HTTP tags for OpenTracing HTTP client spans
[ ] Use a shared agent spec to ensure cross-agent consistent behavior (shared spec in WIP : https://github.com/elastic/apm/pull/402)

Checklist

[x] This is an enhancement of existing features, or a new feature in existing plugins

[ ] I have updated CHANGELOG.asciidoc
[x] I have added tests that prove my fix is effective or that my feature works
[ ] Added an API method or config option? Document in which version this will be introduced
[ ] I have made corresponding changes to the documentation

:green_heart: Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS

Expand to view the summary

Build stats

Build Cause: Pull request #1613 opened

Start Time: 2021-01-13T16:53:25.007+0000

Duration: 42 min 4 sec

Commit: 87680764e1cd2375397590af026b8d6fb34fcd41

Test stats :test_tube:

Test
Results

Failed
0

Passed
1671

Skipped
13

Total
1684

:green_heart: Flaky test report
Tests succeeded.

Expand to view the summary

Test stats :test_tube:

Test
Results

Failed
0

Passed
1671

Skipped
13

Total
1684

:green_heart: Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS

Expand to view the summary

Build stats

Build Cause: Pull request #1613 opened

Start Time: 2021-01-13T16:53:25.007+0000

Duration: 42 min 4 sec

Commit: 87680764e1cd2375397590af026b8d6fb34fcd41

Test stats :test_tube:

Test
Results

Failed
0

Passed
1671

Skipped
13

Total
1684

:green_heart: Flaky test report
Tests succeeded.

Expand to view the summary

Test stats :test_tube:

Test
Results

Failed
0

Passed
1671

Skipped
13

Total
1684

Codecov Report

Merging #1613 (8d30a0d) into master (56bae31) will increase coverage by 20.38%.
The diff coverage is 77.08%.

@@              Coverage Diff              @@
##             master    #1613       +/-   ##
=============================================
+ Coverage     58.75%   79.14%   +20.38%
- Complexity       92     2175     +2083
=============================================
  Files           399      175      -224
  Lines         17864     8376     -9488
  Branches       2475      992     -1483
=============================================
- Hits          10496     6629     -3867
+ Misses         6644     1293     -5351
+ Partials        724      454      -270

Impacted Files
Coverage Δ
Complexity Δ

...va/co/elastic/apm/agent/impl/transaction/Span.java
79.16% <37.50%> (-2.98%)
42.00 <0.00> (+42.00)
:arrow_down:

...lastic/apm/agent/impl/transaction/Transaction.java
79.60% <37.50%> (-2.47%)
46.00 <0.00> (+46.00)
:arrow_down:

...astic/apm/agent/impl/transaction/AbstractSpan.java
75.80% <93.75%> (+1.68%)
62.00 <8.00> (+62.00)

...elastic/apm/agent/impl/context/web/ResultUtil.java
94.44% <100.00%> (+2.77%)
19.00 <8.00> (+19.00)

...co/elastic/apm/agent/impl/transaction/Outcome.java
100.00% <100.00%> (ø)
3.00 <3.00> (?)

.../apm/agent/report/serialize/DslJsonSerializer.java
89.22% <100.00%> (+0.02%)
187.00 <0.00> (+187.00)

...pentracing/impl/ApmSpanBuilderInstrumentation.java

...astic/apm/agent/jdbc/StatementInstrumentation.java

...apm/agent/okhttp/OkHttp3ClientInstrumentation.java

...o/elastic/apm/agent/profiler/ProfilingFactory.java

... and 218 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 56bae31...8d30a0d. Read the comment docs.

Codecov Report

Merging #1613 (8d30a0d) into master (56bae31) will increase coverage by 20.38%.
The diff coverage is 77.08%.

@@              Coverage Diff              @@
##             master    #1613       +/-   ##
=============================================
+ Coverage     58.75%   79.14%   +20.38%
- Complexity       92     2175     +2083
=============================================
  Files           399      175      -224
  Lines         17864     8376     -9488
  Branches       2475      992     -1483
=============================================
- Hits          10496     6629     -3867
+ Misses         6644     1293     -5351
+ Partials        724      454      -270

Impacted Files
Coverage Δ
Complexity Δ

...va/co/elastic/apm/agent/impl/transaction/Span.java
79.16% <37.50%> (-2.98%)
42.00 <0.00> (+42.00)
:arrow_down:

...lastic/apm/agent/impl/transaction/Transaction.java
79.60% <37.50%> (-2.47%)
46.00 <0.00> (+46.00)
:arrow_down:

...astic/apm/agent/impl/transaction/AbstractSpan.java
75.80% <93.75%> (+1.68%)
62.00 <8.00> (+62.00)

...elastic/apm/agent/impl/context/web/ResultUtil.java
94.44% <100.00%> (+2.77%)
19.00 <8.00> (+19.00)

...co/elastic/apm/agent/impl/transaction/Outcome.java
100.00% <100.00%> (ø)
3.00 <3.00> (?)

.../apm/agent/report/serialize/DslJsonSerializer.java
89.22% <100.00%> (+0.02%)
187.00 <0.00> (+187.00)

...pentracing/impl/ApmSpanBuilderInstrumentation.java

...astic/apm/agent/jdbc/StatementInstrumentation.java

...apm/agent/okhttp/OkHttp3ClientInstrumentation.java

...o/elastic/apm/agent/profiler/ProfilingFactory.java

... and 218 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 56bae31...8d30a0d. Read the comment docs.


fix: Don't coerce arbitrary types into strings

This caused an issue when constructing telemetry data where a numeric value was coerced into a string.

:tada: This PR is included in version 0.17.1 :tada:
The release is available on:

v0.17.1
GitHub release

Your semantic-release bot :package::rocket:


fix bug

Description
#1330
Add a short description of:

what changes you made,
why you made them, and
any other context that you think might be helpful for someone to better understand what is contained in this pull request.

This sort of information is useful for people reviewing the code, as well as anyone from the future trying to understand why changes were made or why a bug started happening.

@samijaber please review

the test'snapshots has to change, because I move all <>
@samijaber


Add an event for route change

I have a couple route change handlers which I need to fire (closing overlays on route change, etc) and it would be great to have a route change event.  Currently I have to handle this with a physical DOM component with a setup event checking for !isInitialized to indicate a route change.

According to Mithril's 'stateless' logic, this is controller logic. I've found that for more ambitious routed applications top level components will often have a lot of similar 'setup' logic in the route. The way I handle this is roughly as follows:
const routeMap = { /* ... */ }

let lastRoute = null

Object.values( routeMap ).forEach( [ route, component ] => {
	const { controller } = component

	routeMap[ route ] = {
		controller : function thisRoute(){
			// Universal setup logic here

			if( !( this instanceof lastRoute ) ){
				// Route change logic here
			}

			lastRoute = thisRoute

			return new controller()
		}
	}
} )

m.route( document.body, '/', routeMap )

If that doesn't sit well with your idea of separated concerns (ie you don't feel this logic really belongs in your routed components), you can use this pattern - a mounted component with no host element or view output - to fire on Mithril lifecycle events. If you execute this before your application code, you can ensure the logic will execute before your components initialise / redraw.
m.mount( document.createElement( 'x' ), {
	controller : function routeHandler(){
		// Universal 'onroute' logic
	},
	view : () => {
		// Universal 'onredraw' logic
	}
} )

Your first example is, of course, the prudent one. But the tricksy one is quite clever. I've avoided using components to perform nefarious deeds, like with React. At least with MIthril, I hadn't entertained the thought of using components for lifecycle logic, and I'm sure I'll get myself in trouble with this new power soon enough. Thanks @barneycarroll

event handlers for route changed (and route not found) exist in the rewrite branch

Hi @lhorie -- did event handlers for route changes end up in the rewrite branch?

@doesntgolf yes they did, look for RouteResolvers in the [router docs]. Specifically, the onmatch method...


Vickel: Watch baystate[\W_]*+roofing

Vickel requests the watch of the watch_keyword baystate[\W_]*+roofing. See the MS search here and the Stack Exchange search in text, in URLs, and in code.

baystate[\W_]*+roofing has been seen in 1 true positive, 0 false positives, and 0 NAAs.

Approved by Jeff Schaller in Charcoal HQ


Allow pjit to close over values sharded on multiple devices

Consider the following code fragment:
x = load_checkpoint()

@partial(pjit, in_axis_resources=in_sharding, out_axis_resources=out_sharding):
def foo(a)
  return a + x

y = load_another_checkpoint()
z = foo(y)

The call to foo(y) fails if the value of x is sharded over multiple hosts.
One scenario when supporting this would be very useful is if one need to close over a large static model in order to adapt to the interface required by an existing library they use. E.g. assume one wants to use the XTraner class below, which is a part of a library they don't have control over. I.e. they can't modify or extend XTrainer or loss_fn.
@dataclass
class XTrainer:
  loss_fn: Callable[[Prediction, BatchType], LossValue]

  @partial(pjit, ...)
  def train_step(self, input_batch: BatchType, train_state: TrainState) -> TrainState:
    """Performs a single gradient descent step on the model represented with `train_state`.
       Runs a prediction in the model and computes the value of the loss by calling `loss_fn`.
    """
    ...

There are cases in which one would want to exercise a static pre-trained model inside the implementation of loss_fn. Some that come to mind are:

One wants to train from human feedback as in InstructGPT.
One wants to distill the trained model to be close to a target, pre-trained model.

Unfortunately, if the static model needs to be sharded over multiple hosts, this is currently not supported and AFAIK, one can't use XTrainer without modification in this case.

Yes, please use what @GallagherCommaJack suggested or pass the sharded Array as an argument.
Feel free to reopen if both techniques don't work.


Alternative lookup convention for ng-add schematics

It would be nice to be able to externalize schematics from the package specified in the ng add command.
ng add ionic requires us to include schematics within the ionic package itself, which is not ideal for several reasons:

Separation of Concerns. The ionic package isn't necessarily for Angular, but ng add ionic looks good 👌
Complication of the build within our main package. Including the schematics in our main package would require including a lot of the Angular DevKit into the build.
Slow "add". It requires installing the entire package and all its dependencies (~38M) in a sandbox just to use a few files from the package.

In slack I believe we concluded that the best solution might be to have the ng-add field within package.json be allowed to point to another package.

Yeah, this would be great.
I would love to be able to call ng add nativescript, which could then be redirected to install @nativescript/schematics


error creating admin user

First pass after reorg to using gb build all
./bin/server
Using Postgres running on my local (Mac) system, from brew install postgresql (Highly possible it's not setup correctly.) It's v9.4.5 if that helps.

Error:Error querying database for count: pq: relation "users" does not exist
Query:SELECT COUNT("id") FROM "users" WHERE (email=$1);

I think you haven't run the migrations on the database you're using. If you use psql and open the db, do you find the relation users?
I can't try to reproduce this as it is run against a modified version. Can you try it with a vanilla install, and make sure the db is populated with fragmenta migrate first?

I ran through this error, you have to create the database and restart the server

May be this userful:
You need to run "fragmenta migrate" from "postgres" user, because when you run it as ordinary user you can't create database (and tables) in Postgresql. Also, you can give access to Postgresql for standart system user.

I think this is a dupe of #9 so closing, comment over there.


knitu

https://en.wikipedia.org/wiki/Kazan_National_Research_Technological_University

@DerzkeyBK Pull request merged. Thank you!


lose some early epoch checkpoint file during training

Have I written custom code: Y
OS Platform and Distribution: centos release 6.5
TensorFlow installed from: pip install
TensorFlow version: 1.40
Bazel version: N/A
CUDA/cuDNN version: Cuda 8.0
GPU model and memory: N/A
Exact command to reproduce: N/A
Mobile device: N/A
I found myself losing some checkpoint in the target dir after training. For example, I lose 1-13 epoch checkpoint files after 60-epoch training.
I used tf.train.Saver and tf.train.Supervisor in my code:
tf.train.Supervisor(             is_chief=is_chief,             logdir=FLAGS.log_dir,             global_step=global_step,             saver=tf.train.Saver(var_list=var_list,max_to_keep=80,sharded=True),             save_model_secs=FLAGS.save_model_secs,             save_summaries_secs=FLAGS.save_summary_secs,             init_op=tf.global_variables_initializer(),             local_init_op=tf.group(tf.local_variables_initializer(),tf.tables_initializer())
where save_model_secs=1800, save_summary_secs=1800
FYI, it costs me about 30 minutes for training 1 epoch.WHY?

@suzirui123 Hi, just to confirm, have you looked into protocol buffer to check the list of checkpoints ?

@harshini-gadige I'm using distributed_training, could you please tell me where to find the protocol buffer you mentioned?

@harshini-gadige Do you mean freeze the graph to check the pb of checkpoints? I haven't tried that.

@aselle  - Hi, could you please look into this issue ?

Automatically closing due to lack of recent activity. Please update the issue when new information becomes available, and we will reopen the issue. Thanks!


Why is trAtbBridgeAsyncFreq not applicable for E-trace?

The trPibAsyncFreq and trRamAsyncFreq are specified as providing the interval between synchronization sequence insertion for E-trace packets but the trAtbBridgeAsyncFreq is omitted. Is that intentional? If so why is it not applicable?

Sorry, this is an oversight.  I'll fix

Fixed (sorry - user error with VSCode means I committed straight to main rather than via PR).  Change was trivial though.


[Question] Flutter Run opens FLUTTER_DEV_LOG buffer but also opens a new tab with same buffers. Why?

This might not be the place to ask this question but I'm starting here.
I'm using an "all Lua" Neovim configuration including Flutter-tools, Telescope and Bufferline.
I open a Flutter project, open the main.dart file, start the emulator and it doesn't matter if I use :FlutterRun or use Telescope to run the application. main.dart is in one buffer, FLUTTER_DEV_LOG opens in a second buffer BUT it also opens another tab with the same buffers.
Now I have two tabs with a total of four buffers: 2 main.dart buffers and 2 FLUTTER_DEV_LOG buffers.
Have you seen this or do you have any suggestions of where to look to prevent this from happening?

I'm just going to close this question.
I'm having other issues with Neovim and Flutter and it is challenging to both learn a new language and an editor configuration at the same time.
I'll use Android Studio for the time being and maybe come back to this in the future.

@dastagg that's very fair re. using what works, so you can be productive. Re. the buffers and tabs situation, by default the dev log is opened in a vertical split however you can change this to open in a tab. It sounds like you had it open in a tab buffers are not duplicated in a tab but are actually the same buffers, so there weren't 4 buffers just 2 buffers visible in two tabs.
Either way, I'd have suggested you remove any custom changes you've made to the open_cmd for the dev_log presumable you copied it from the README block, but that block is explicitly not intended to be copied and is just for example sake.

Thank you for your reply.
Yes, that is true, I did copy that block as I was trying to incorporate flutter_tools into a configuration created using chris@machine's "Neovim from Scratch" series.
In that configuration, there is an emphasis for using lsp-installer and a handler which sets up the keyboard commands and other things. I am trying to use that handler with flutter-tools without installing the Dart LSP.
I will take a look at that section in the block and see if I can determine how to fix it.
Thanks again.

Just as a follow-up: Changed dev_log open_cmd = "edit" and that opens the dev log in it's own buffer.
Now it looks and acts the way I want it to.
I'll keep pushing at it until I get it together. Learn a little here... Learn a little there... The process continues...
Thanks for your help and THANKS for making this plugin!


[Fix][UI Next][V1.0.0-Alpha] Fix tenant not exists error while import…

Purpose of the pull request
This pull request fix tenant not exists error while import workflow.
Releated issues
close #8777

Codecov Report

Merging #8797 (cca3a18) into dev (97a0eed) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##                dev    #8797      +/-   ##
============================================
- Coverage     45.30%   45.29%   -0.02%
+ Complexity     4076     4075       -1
============================================
  Files           702      702
  Lines         27110    27110
  Branches       2897     2897
============================================
- Hits          12283    12280       -3
- Misses        13674    13676       +2
- Partials       1153     1154       +1

Impacted Files
Coverage Δ

...e/dolphinscheduler/remote/NettyRemotingClient.java
50.70% <0.00%> (-2.12%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 97a0eed...cca3a18. Read the comment docs.


Examples only advance the paper until empty without printing

Just got my GB03 and the scripts connect and send print data, but the unit doesn't print anything and it advances the paper until it runs out. Looking for an android device so I can capture the packets of the app and compare with what you have. Any tips?

@interlock - how did you resolve this?
I've just taken delivery of a similar device and I'm getting the same results.