HTML conversion adds space into hyperlink incorrectly

To recreate the issue:

Create a link within a sentence
Convert to HTML (leaving all options off)
See the output has added the preceding space into the hyperlink as per the following screenshot:

Do you mean the space between <a and href="http://..."?
That's just broken there naturally because the sidebar is narrow. If you don't select the "Wrap HTML" option, the paragraph will come out as a single line. If you do wrap the HTML, it will often break after the <a because the href="http://..." is often pretty long.
Does the converted HTML render correctly? If there's a problem with that, then we do have a bug, but I haven't seen that yet -- let me know if you do see a problem with the rendered HTML.

I'm sorry - after closer examination... the issue is actually with Google Docs.
In the highlighted text in the screenshot, the link starting with 'A Still, Small...' actually starts in the empty space before 'A'. Google Docs sometimes shows the space character with it's underline, but not other times.
Will report to Google. Thanks for getting back to me.


cache: fix quickstart script, improve checking

Check that SelfURL also doesn't end with a slash since the galaxycache's
code checks whether the strings are equivalent when picking peers, and
peers cannot have slashes at the end so we need the same, exact format
of the URLs.
Fix quickstart script so that it wouldn't have slashes at the end.
Idea for the future: let's add smoke tests for scripts/quickstart.sh
to ensure smooth developer experience?
Signed-off-by: Giedrius Statkevičius<EMAIL_ADDRESS>

Looks good to me +1 One alternative I could imagine is taking care of this for the user (removing trailing slash if one is detected)

What if there are two or more trailing slashes? Maybe someone will have some weird configuration with reverse proxies in front of Thanos Store :thinking: :shrug:


CMake Upgrades

While writing a vcpkg port for glaze (which has since been added by others), I noticed a few areas where glaze's CMake build-system could be enhanced.
Changes

The option glaze_DEVELOPER_MODE was introduced by not used.
Toggling developer mode was always based upon the PROJECT_IS_TOP_LEVEL variable. This caused the glaze_ide binary to be built in any situation where the project was built independently, for example, when building the vcpkg port. The vcpkg port introduced by others still builds this unnecessary target.

The explicitly introduced cache variable CMAKE_INSTALL_INCLUDEDIR doubly nested glaze's installed headers.
When installing glaze, the headers would be placed in .../include/glaze/glaze/ instead of .../include/glaze/. I'm not sure if this nesting was intentional, but assuming it was not, CMake's GNUInstallDirs module already introduces this cache variable.

Tests for installing & finding glaze were registered with CTest.
Now, glaze's installation and the finding & usage of that installed glaze instance are tested as part of glaze's automated tests.

Future Work
Should these changes be incorporated into glaze, I would like to edit the upstream vcpkg port & add basic documentation into glaze for using it through vcpkg.
Questions
Is my understanding correct that Eigen is not treated as a dependency, even though it's part of ext/eigen.hpp?
Would the introduction of the CMake component ext, to provide the target glaze::ext with an interface dependency on Eigen3 be of interest? This would involve adding a call to find_dependency(Eigen3) in install-config.cmake that's conditional upon a user's call to find_package(glaze REQUIRED COMPONENTS ext).

I have not got the faintest clue when it comes to cmake besides the very basics and I don't think @stephenberry does either so I appreciate you making these improvements.

Is my understanding correct that Eigen is not treated as a dependency, even though it's part of ext/eigen.hpp?
Would the introduction of the CMake component ext, to provide the target glaze::ext with an interface dependency on Eigen3 be of interest?

Yeah, it was just exposing some eigen helpers that people could use if they were already using eigen. It's not useful without eigen so It was just kind of assumed if you were using it you already pulled in eigen yourself. However, adding it as a component like you stated sounds like a smarter approach.


Creating dirs when saving file

Thanks.
@homu r+

:pushpin: Commit 19c0040 has been approved by gkoz

:hourglass: Testing commit 19c0040 with merge 5e5a616...

:sunny: Test successful - status


ODP-2695: Commons-lang3 version changed to 3.2.1 for fluent-job-api

commons-lang3 3.2.1 is a dependency of org.jvnet.jaxb2_commons:jaxb2-basics:jar:1.11.1


ydn.error.ArgumentException: store name "NAME" not found

YDN-DB tells me there was no store named 'tasks' when I try clearing it. It definately exists.
ydn.error.ArgumentException: store name "tasks" not found.
    at Error.C (http://localhost:3000/services/common/localStorage/ydndb.js:26:411)
    at ze.l.clear (http://localhost:3000/services/common/localStorage/ydndb.js:109:114)
    at T.l.clear (http://localhost:3000/services/common/localStorage/ydndb.js:182:193)

Please attach runnable code in jsbin or jsfiddle.

Maybe I will tomorrow. clear() doesn't seem to work at all, at least for me:
ydn.error.ArgumentException: number of store names must more than 0

"Does not work for me" is the worst thing a programmer can say. Please improve your bug report skill.


Filter by other fields

Currently it is only possible to filter by name.
Would be very useful to be able to filter by other fields like state or cmdline.

This should have been addressed by the above commits. We can probably extent this in the future to support a filter per column rather (#8173).


Adding bubble sort in python

Python program for implementation of Bubble Sort
def bubbleSort(arr):
n = len(arr)
# Traverse through all array elements
for i in range(n-1):
# range(n) also work but outer loop will repeat one time more than needed.

	# Last i elements are already in place
	for j in range(0, n-i-1):

		# traverse the array from 0 to n-i-1
		# Swap if the element found is greater
		# than the next element
		if arr[j] > arr[j+1] :
			arr[j], arr[j+1] = arr[j+1], arr[j]

Driver code to test above
arr = [64, 34, 25, 12, 22, 11, 90]
bubbleSort(arr)
print ("Sorted array is:")
for i in range(len(arr)):
print ("%d" %arr[i]),

Can you please assign this to me


Refactor more groupby and resample tests

xref #5409
This is a simple copy-paste.

Hello @dcherian! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

In the file xarray/tests/test_dataset.py:

Line 13:1: F401 'pandas.tseries.frequencies.to_offset' imported but unused

can I go ahead and merge this?

can I go ahead and merge this?

For sure!


Complete expression rule

Complete expression rule according https://docs.oracle.com/en/database/oracle/oracle-database/21/sqlrf/Expressions.html .

Focus on literals and functions to fully support thelock table statemement.
Open a new issue for the remaining expressions.


New sort functions

This is pretty much just copying the code from #26, just without taglib
code.

This looks good. Other than the above comment, that I'm not too phased about you changing or not, there is one thing I would like to see before I merge it, and that's that you have some strategy for being backwards compatible, so that for anyone who already has the application, when they spin up the node server it can check if they have discnr and tracknr attributes, and if it isn't present, it goes through all the tracks in the library and rescans them for those attributes. (meaning that a hard rescan isn't required to add those attributes).
What do you think @ohnx ?

Closing due to fixes being committed to master.


Confirming Report... (unclickable)

Under the Reporting Tab, I'm shown a ton of markets and all say Confirming Report.. when I click the button nothing happens.
In the box on the right it says REPORT NOT SUBMITTED
cliffs: have a ton of markets to report, unable to report.
Windows: using both Chrome, and Firefox (imported account)

I believe you have missed the reporting period by "a few seconds" according to the screenshot.  I think the bug is that the "Confirming Report" buttons don't do anything.

Agree this is an issue --- should not make things that look like buttons but actually aren't

Obsoleted by 59f966ae8b6d24f221fec1ec166e75a53216429e.


Permission denied after Docker run command

Hello,
I am having trouble deploying the Docker container the way it is documented.
When I run this command:
docker run --restart unless-stopped --name cache-steam -v /cache/steam/data:/data/cache -v /cache/steam/logs:/data/logs -p <IP_ADDRESS>:80:80 steamcache/generic:latest
As its documented under: https://hub.docker.com/r/steamcache/generic/
I only recieve this error Message:
nginx: the configuration file /etc/nginx/nginx.conf syntax is ok
2017/12/12 12:36:38 [emerg] 10#10: mkdir() "/data/cache/cache" failed (13: Permission denied)
nginx: [emerg] mkdir() "/data/cache/cache" failed (13: Permission denied)
nginx: configuration file /etc/nginx/nginx.conf test failed
When I try and run the Docker passing only "-v /cache/steam:/data" like this:
docker run --restart unless-stopped --name cache-steam -v /cache/steam:/data -p <IP_ADDRESS>:80:80 steamcache/generic:latest
the container actually starts successfully, created the "/cache/steam/data" and "/cache/steam/logs" directorys and even caches Steam downloads, but the internal Docker folder /data is not linked to /cache/steam on the Server itself.
The internal directorys look like this:
docker exec cache-steam /bin/sh -c "ls -al /data/cache"
total 12
drwxr-xr-x    3 nginx    nginx         4096 Dec 12 12:56 .
drwxr-xr-x    4 root     root          4096 Dec 12 12:27 ..
drwx------    2 nginx    root          4096 Dec 12 12:56 cache
e.g: /data/cache/cache
Did I miss a step in the configuration or is the Documentation simply outdated?
Cheers,
Finn

Docker will need write permissions on the directory on the host that you're mounting in; also create the logs and data directories on your host.

Hi Jessica,
I did set the permission to 777 for testing, but that didn't work either.
[root@localhost steam]# ls -al
insgesamt 20
drwxrwxrwx. 5 root root 4096 12. Dez 15:52 .
drwxrwxrwx. 8 root root 4096 12. Dez 13:56 ..
drwxrwxrwx. 2 root root 4096 12. Dez 13:27 cache
drwxrwxrwx. 2 root root 4096 12. Dez 15:52 data
drwxrwxrwx. 2 root root 4096 12. Dez 13:27 logs
Here I created a file through the Docker but it doesn't exist on the host.
[root@localhost steam]# tree
.
├── cache
├── data
└── logs
3 directories, 0 files
[root@localhost steam]# docker exec cache-steam /bin/sh -c "cd /data/cache; ls -al"
total 12
drwxr-xr-x    3 nginx    nginx         4096 Dec 12 14:52 .
drwxrwxrwx    5 root     root          4096 Dec 12 14:52 ..
drwx------    2 nginx    root          4096 Dec 12 14:53 cache
[root@localhost steam]# docker exec cache-steam /bin/sh -c "cd /data/cache/cache; ls -al"
total 8
drwx------    2 nginx    root          4096 Dec 12 14:53 .
drwxr-xr-x    3 nginx    nginx         4096 Dec 12 14:52 ..
-rw-r--r--    1 root     root             0 Dec 12 14:53 test
Since I ran the "docker run" as root it was even able to create the Directorys on startup.
Thanks for your help!

Your original run command should have worked.
docker run --restart unless-stopped --name cache-steam -v /cache/steam/data:/data/cache -v /cache/steam/logs:/data/logs -p <IP_ADDRESS>:80:80 steamcache/generic:latest

The only thing I would have done before running it is to create the /cache/steam/data and /cache/steam/logs directories.
What OS are you running docker under?

I am currently testing on a Fedora 27 Machine with "docker-1.13.1-42.git4402c09.fc27.src.rpm" from the Fedora repositorys.
At home I had the same issues on a CentOS 7 Host which is supposed to become the productive cacheserver.

I gave it another try on Ubuntu 16.04 and it is working flawlessly.
Not my favorite distro but it will work for the next LAN :).
The docker version here is 1.10... I might install this version manually on the CentOS7 Host to see if this is the problem.

I gave it another try on Ubuntu 16.04 and it is working flawlessly.
Not my favorite distro but it will work for the next LAN :).
The docker version here is 1.10... I might install this version manually on the CentOS7 Host to see if this is the problem.


[Connectors] -addnode and -connect don't work together as they should

so i have -connect=IP on command line and in conf i have couple of addnode lines, the expected behavior is that the node should only attempt to connect to that one IP and ignore knowledge from addnodes

@Aprogiena I've had a bit of a look through the history of ConnectionManager and it appears that we always executed AddNode connections even if -connect args was specified?
Old ConnectionManager
So either it was always wrong and we should fix it or this is expected behaviour.
IMO I agree with you,  if -connect args is specified then we should only connect to that peer.
We should maybe think to rename those args to:
-connectexclusive
-connectinclude

we should implement -connect just as bitcoin core has it
then we can add any other arguments if we want to but that connect one should be without name change and behave as in bitcoin core
currently it seems that we don't know how bitcoin core behaves
we have not checked it and i think it behaves differently than we have it now but i have not verified

Bitcoin Core's documentation on the subject:
strUsage += HelpMessageOpt("-connect=<ip>", _("Connect only to the specified node(s); -connect=0 disables automatic connections (the rules for this peer are the same as for -addnode)"));
strUsage += HelpMessageOpt("-addnode=<ip>", _("Add a node to connect to and attempt to keep the connection open (see the addnode RPC command help for more info)"));
My assumption is that they ONLY connect to the nodes specified in -connect if that arg is specified.
Thoughts?

documentation is not clear, we need to investigate the code

Oh man, Im scared to go dig in that code base :P

better lost your virginity sooner than later ;)

So, I've examined the bahavior of Bitcoin Core clone and my understanding of how -connect should work was wrong.
It behaves like this. If you set -connect=address then the node will attempt to connect to that address and it DISABLES peer discovery, BUT it will attempt to connect to all your addnodes as well (this is the part that I thought is different). There was no difference to whether it was specified on command line or conf file.
So the difference between connect and addnode is only that using connect will disable discovery of other peers and you will attempt to connect only to those addresses specified by connect or addnode.
So, very likely our current implementation works exactly like that. @fassadlr could you confirm that and if it does, please close the issue as non-issue.


Lexi 967 Writing Styles

Hey Victor there are some changes that need to be made. This is also reflected in our document
Capitalization > Exception  > UI reference >
Example 2 - Both the do and don’t examples share the same error:
“Use the same mobile device rules found in public pages”
Capitalization > Exception  > Navigation >
This is incorrect, it should read as:
“Navigation items should be title-cased.

Application names are in title case in menus, but within a sentence should be sentence case.”

Numbers >
“Zero through nine rule” should be an H3. And the sentence should start with “in a non-technical…”
Ordinal and cardinal numbers should be h4
Dates >
Description should read:
“Dates are complex when writing for an international audience. We use American english style, to promote consistency for our translation services. We recommend using the full date whenever possible, but abbreviations are acceptable to save space.”
“Months can be abbreviated on UI elements spell out the month name (at least three characters)”

Thanks @cj213x ! I will do all changes once Rushell's comments are reviewed


Migrate exclusively to the v1 progress/metrics API

The Go SDK has continued to send the legacy metrics to runners, simultaneously with the new metrics. We should remove the legacy approach and only use the modern version which is more efficient.
Imported from Jira BEAM-14557. Original Jira may contain additional context.
Reported by: lostluck.

Unable to assign user @riteshghorse. If able, self-assign, otherwise tag @damccorm so that he can assign you. Because of GitHub's spam prevention system, your activity is required to enable assignment in this repo.

This doesn't seem like a release blocker. Does it prevent the Go SDK from being used in the 2.40.0 release?
@lostluck @damccorm @riteshghorse

The core part of it is merged in. This is not a release blocker. Thanks!


chore: bdd-nh-1582606596 to 0.0.1

chore: Promote bdd-nh-1582606596 to version 0.0.1

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approvers:
If they are not already assigned, you can assign the PR to them by writing /assign  in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


Coveo Search Bar feedback

Coveo Search Bar
Medium issues
Unnecessary search API call right before the redirect to the search page (impact on QPM)
Analytics Search event: action cause should be omniboxFromLink when selecting a query suggestion from the standalone search box
Analytics Search event: action cause should be searchFromLink when executing a search from the standalone search box, or when selecting one of the recent searches.
Minor issues (no action needed)
No API call to the /plan endpoint before navigating to the search page; it could be useful if you were to use redirect triggers
Page View Event
No issue

@mhaack  and @davidzochowski  - this is the feedback from Coveo that David requested.


chore: add react-query for incidents and patients search

Fixes #1995
TODO:

[ ] patients
[ ] scheduling
[x] incidents
[ ] imaging
[ ] medication
[ ] labs

This is huge! <3

All seems more clear to me when comes to "fetching" data.

LGTM though coveralls alert


Added dependencies for the Dialog Editor components

@karelhala

@romanblanco please add bootstrap-switch to package.json
yarn add bootstrap-switch

And add it to app.js as well, so changing title of dialog will not throw error with missing dependency.
require('bootstrap-switch');

@karelhala, @AllenBW thanks, corrected

Can we move to export those to individual components?

So.. the point of the ui-components repo is to have all those common components, we are definitely not splitting the repo.
We could theoretically produce multiple npm packages from that repo though, in addition to the bundle (what is now manageiq-ui-components).
So we'd have manageiq-ui-components, manageiq-ui-components-gtl, manageiq-ui-components-toolbar, manageiq-ui-components-siteswitcher, manageiq-ui-components-dialogeditor and manageiq-ui-components-common, upon which all the other 4 depend.
Then, those 5 new packages could either be compiled to es5, the same as before, or maybe left in typescript so that each dependent can compile it themselves.
@karelhala what do you think, any technical challenges there? Does it make sense to open the discussion in such a direction?
But on the other hand, that seems like a lot of work just so that SUI can depend on 3 of the 5 packages anyway. @chriskacerguis I fail to see the benefit now, is there any?

@karelhala, @romanblanco  this is still broken unfortunately :(.
I have no local ui-components.
I have no manageiq-ui-service/node_modules.
I check out this branch, do yarn; yarn start. (Even deleting yarn.lock before then doesn't help.)
I go to Dialogs, click a random one, click Edit.
angular.js:10837 Error: [ManageIQ] [$injector:unpr] Unknown provider: DialogEditorProvider <- DialogEditor

--- a/client/app/states/states.module.js
+++ b/client/app/states/states.module.js
@@ -36,6 +36,7 @@ export const AppRoutingModule = angular
   .module('app.states', [
     'app.core',
     'app.components',
+    'miqStaticAssets.dialogEditor',
   ])
   .run(NotFoundState)
   .run(AboutMeState)

This change makes the page not load, and complain that
Uncaught Error: [$injector:modulerr] Failed to instantiate module app due to:
Error: [$injector:modulerr] Failed to instantiate module app.states due to:
Error: [$injector:modulerr] Failed to instantiate module miqStaticAssets.dialogEditor due to:
Error: [$injector:nomod] Module 'miqStaticAssets.dialogEditor' is not available!

So.. either ui-components is still not incuded, or the component is not there.
(I did check that yarn.lock points to the right place.)

Verified that the above issue is not in this PR, it's in how yarn (0.16.1) doesn't understand branches :(.
Installing via npm instead works just fine :). (And curiously enough reveals that SUI doesn't actually depend on patterfly at all, only patterfly-sass, which it doesnt use at all :).)
Which means I can merge ManageIQ/ui-components#55, release a proper version and this problem should go away.

@himdel so latest yarn is v0.19.1, does using this version allow for correct instillation of the dep?

@AllenBW tested again, yup, 0.19.1 works :).
But I've also released manageiq-ui-components 0.0.12 so we can depend on that now.

@himdel @chriskacerguis @jjlangholtz Good idea about splitting components to some smaller ones. But I am strongly against splitting it into multiple repos/packages. Let's rework build process of these components in a way that the final package will have manageiq-ui-components-gtl.js, manageiq-ui-components-dialog-editor.js, manageiq-ui-components.js... so you will install it from one package, but you can include only some JS files or main manageiq-ui-components.js`.
Not sure if this is right place to discuss this, since it's closed PR, so probably move this to gitter?

@karelhala Agree.  Splitting components = good, splitting repos = no bueno


Subcommands

Is your feature request related to a problem? Please describe.
Change slash-command option with subcommand
Describe the solution you'd like
A clear and concise description of what you want to happen.
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.

Pas pertinent pour l'instant


Public room - Self DM in LHN shows @expensify.anon when visiting public room anonymously

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 1.4.67-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team
Action Performed:

Go to staging.new.expensify.com
Log out if logged in.
Navigate to public room anonymously (https://staging.new.expensify.com/r/2376199970894587
).

Expected Result:
Self DM in LHN will not show<EMAIL_ADDRESS>It should be replaced by "You" or better choice of word
Actual Result:
Self DM in LHN shows<EMAIL_ADDRESS>when visiting public room anonymously.
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos
Add any screenshot/video evidence

https://github.com/Expensify/App/assets/78819774/632e1ccf-dd54-4f61-8576-0525bfcd7f7b
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~0170d176396181cba4
Upwork Job ID:<PHONE_NUMBER>795037184
Last Price Increase: 2024-04-29

@garrettmknight  FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

We think that this bug might be related to #vip-vsp

Proposal
Please re-state the problem that we are trying to solve in this issue.
The self DM in LHN as anonymous user title show an email with @expensify.anon domain.
What is the root cause of that problem?
When we logged in as anonymous user, the email is random with a @expensify.anon domain.

The LHN title for self DM shows the user display name (the email in this case) with (you) as the postfix.
https://github.com/Expensify/App/blob/223672b8b70d7d57d6bd4ab6baaa4ec6e61726c7/src/libs/ReportUtils.ts#L3115-L3117
The self DM is added from the OpenApp request.
What changes do you think we should make in order to solve the problem?

I think I prefer to fix it on the BE so the OpenApp won't return a self DM report, or maybe the BE shouldn't auto create a self DM if it's an anon user, but in case we want to do something on the FE, we can hide self DM from LHN if it's an anonymous user. We can do it in a different way.
We can move this condition
https://github.com/Expensify/App/blob/223672b8b70d7d57d6bd4ab6baaa4ec6e61726c7/src/libs/ReportUtils.ts#L4979-L4981
below this
https://github.com/Expensify/App/blob/223672b8b70d7d57d6bd4ab6baaa4ec6e61726c7/src/libs/ReportUtils.ts#L4913-L4916
so we can control whether to include the self DM or not with the includeSelfDM param. ReportUtils has a global isAnonymousUser variable that we can use, but I prefer to pass it from the param.
https://github.com/Expensify/App/blob/223672b8b70d7d57d6bd4ab6baaa4ec6e61726c7/src/libs/SidebarUtils.ts#L110
includeSelfDM: !isAnonymousUser,

Then pass isAnonymousUser to getOrderedReportIDs here
https://github.com/Expensify/App/blob/223672b8b70d7d57d6bd4ab6baaa4ec6e61726c7/src/hooks/useReportIDs.tsx#L133-L143
const session = useSession();
...
isAnonymousUser(session),

What alternative solutions did you explore? (Optional)
We can add the anonymous and self DM check in canAccessReport so the report screen will show not found page when we access it directly from the browser address bar or deep link.
https://github.com/Expensify/App/blob/223672b8b70d7d57d6bd4ab6baaa4ec6e61726c7/src/libs/ReportUtils.ts#L4793-L4804

Thanks @bernhardoj - I'll take this up internally to figure out which way we want to go.

https://expensify.slack.com/archives/C066HJM2CAZ/p1714384363815759

Setting as internal for the moment, but I will flip it to External if we go FE.

Found another one handling this: https://github.com/Expensify/App/issues/41180


Request for site to be added: jonhnnyweslley.net

Link to GTMetrix results: https://gtmetrix.com/reports/jonhnnyweslley.net/rchqYI9C/
- domain: jonhnnyweslley.net
  url: https://jonhnnyweslley.net
  size: 67.6

Uncompressed size is 125.9KB.


[TCD-1896] Appium Rewrite

Description

Motivation and Context

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Documentation fix (typos, incorrect content, missing content, etc.)

Checklist

[ ] I have read the contributing document.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.

Thanks for your feedback, @wswebcreation! I have addressed most of your requests and had a couple follow-up questions for others, if you have time to provide some clarifications.


allow newer versions of libraries

Hi. I am packaging this for the Fedora project as it will soon be a dependency for Lutris, which I am the package maintainer of. We don't package the exact versions in setup.py, but instead newer versions, so we have had to patch setup.py to get it to build in Fedora.
If you don't think this will break functionality in your library, maybe you could also merge this into the next version of your library?

Thanks, I'll probably rework the dependencies further in the next release


Convert HighlightOverlay to TypeScript

It would be nice to have types for highlights in #1372 so I took a stab at converting HighlightOverlay to TypeScript. But I would like to review a portion of the conversion with someone that is familiar with the TypeScript mixin/trait pattern.
Most notably I needed typing for "A node that mixes ReadingBlock/InteractiveHighlighting". I looked at Poolable and I think I did it in a similar way. It seems to work but duplicates much of the interface of ReadingBlock and InteractiveHighlighting to define a type.
Also, I had to use IProperty<boolean> instead of BooleanProperty for the HIghlightOverlayOptions so that those Properties work well when they are set from the Properties of FocusManager in Display.ts. Is there a reason to use IProperty<boolean> instead of BooleanProperty?
Commits coming.

Conversion is done, I did some fuzz testing and basic spot checking and all seems well. The part I want to review in particular is https://github.com/phetsims/scenery/blob/86fc9734092cedf67b5da314cd587d63ac1dfede/js/accessibility/voicing/InteractiveHighlighting.ts#L31-L52 and the similar one in  ReadingBlock.ts.
@zepumph or @jonathanolson does this seem right to you or is there a way to reduce the duplication of InteractiveHighlightingInterface?

Discussed with @jonathanolson , he recommended looking at the WidthSizableNode example to avoid the duplication.

https://github.com/phetsims/scenery/issues/1375#issuecomment-1067002163 is working great for both InteractiveHighlighting and ReadingBlock. That is it for the TS conversion of HighlightOverlay. Closing.


macOS: Support virtual desktops

VSCode Version: Code 1.15.1 (41abd21afdf7424c89319ee7cb0445cc6f376959, 2017-08-16T17:15:57.756Z)
OS Version: Darwin x64 16.7.0
Extensions:

Extension
Author (truncated)
Version

unity-tools
Tob
0.1.9

unity-debug
Uni
1.2.1

csharp
ms-
1.12.1

vscode-icons
rob
7.12.0

code-spell-checker
str
1.3.8

Steps to Reproduce:

Maximize (to full screen) Unity3d and vs code on Mac OS.
Double click on the script in Unity3d.
vs code is moved to right virtual desktop, but focused on left.

explanation video: https://youtu.be/ZldW8fdPhbE

Reproduces without extensions: Yes

@bpasero should this be closed. It returned back to inbox. I labeled it as a feature request.

@dbaeumer I forgot to add the feature request label, so it can stay open.


yew throw error when try to render svg in a vnode props after Mouseevent is triggered

Problem

I have a component which I pass a vnode in one of its props, in that it has a svg inside of a div tag,
that div tag has a onclick event. Until this point it works and the svg is shown. Now I trigger the onclick event, and I get this error:
wasm-bindgen: imported JS function that was not marked as `catch` threw an error: expected a string argument

Stack:
passStringToWasm0@http://localhost:1234/yew_style_page.js:76:41
init/imports.wbg.__wbg_className_ad0388ecc9b6acf5<@http://localhost:1234/yew_style_page.js:768:37
logError/<@http://localhost:1234/yew_style_page.js:214:22
web_sys::features::gen_Element::Element::class_name::h0c0f0633280c15c0@http://localhost:1234/yew_style_page_bg.wasm:wasm-function[7481]:0x385940
<yew_styles::components::modal::Modal as yew::html::Component>::update::hecb852325cc33e3a@http://localhost:1234/yew_style_page_bg.wasm:wasm-function[971]:0x21e13b
<yew::html::scope::UpdateComponent<COMP> as yew::scheduler::Runnable>::run::h6ce55d74a53b6690@http://localhost:1234/yew_style_page_bg.wasm:wasm-function[298]:0x17a531
yew::scheduler::Scheduler::start::hfcd91cb63ef0302c@http://localhost:1234/yew_style_page_bg.wasm:wasm-function[956]:0x21be86
yew::scheduler::Scheduler::push_comp::h3606bb223f930df8@http://localhost:1234/yew_style_page_bg.wasm:wasm-function[832]:0x20810c
yew::html::scope::Scope<COMP>::update::h563bcd28df6c6777@http://localhost:1234/yew_style_page_bg.wasm:wasm-function[1994]:0x28b223
yew::html::scope::Scope<COMP>::send_message::h974f90d7f6adf72d@http://localhost:1234/yew_style_page_bg.wasm:wasm-function[5436]:0x343a0a
yew::html::scope::Scope<COMP>::callback::{{closure}}::h5352e5a6a241aef0@http://localhost:1234/yew_style_page_bg.wasm:wasm-function[7711]:0x38bf77
yew::callback::Callback<IN>::emit::h92d718f6b06d1fc4@http://localhost:1234/yew_style_page_bg.wasm:wasm-function[1481]:0x25c2e5
<yew::html::listener::listener_web_sys::onclick::Wrapper as yew::virtual_dom::Listener>::attach::{{closure}}::hbe7b8e93ec37a6d9@http://localhost:1234/yew_style_page_bg.wasm:wasm-function[5964]:0x35681f
<dyn core::ops::function::FnMut<(&A,)>+Output = R as wasm_bindgen::closure::WasmClosure>::describe::invoke::h320454d78e9814a4@http://localhost:1234/yew_style_page_bg.wasm:wasm-function[2793]:0x2c31ec
__wbg_adapter_22@http://localhost:1234/yew_style_page.js:245:14
real@http://localhost:1234/yew_style_page.js:201:20

If I put a text for example instead of the svg, it works without get any error.
If I use the same logic outside of the props it works without get any error.
Steps To Reproduce
Steps to reproduce the behavior:

git clone git@github.com:spielrs/yew_styles.git
git checkout no-render-svg-vnode-props
npm install and npm start
click in the left in modal and after in the right side scroll down and click in the button Form modal
inside of the modal opened click in the icon, you will notice that it breaks the browser and you will
see the error that I mentioned before
Now reload and repeat the same process however click in the text instead of the icon, you will see that
the onclick event works

The issue happens because there is a typeof comparator  and when it is not string it throws an error, if you debug it you will realize that in some point you will get the svg object instead of the args variable
Expected behavior
This issue shouldn't happen doesn't matter what I include in this vnode prop
Screenshots

Environment:

Yew version: master
Rust version: 1.44.0 stable
Target, if relevant: [e.g. wasm32-unknown-unknown]
Web library: web-sys
OS, if relevant: Solus linux
Browser and version, if relevant: Firefox 77.0.1

Questionnaire

[ ] I'm interested in fixing this myself but don't know where to start
[ ] I would like to fix and I have a solution
[ ] I don't have time to fix this right now, but maybe later
[x] I can take a look but I cannot promise anything then if someone can take a look and resolve the issue would be great

Could you please add a link to the relevant code for the component?

@siku2  I added already crate/src/page/modal_page.rs

@dancespiele I finally got the chance to take a look, sorry for the delay!
The issue is actually in your Modal component. Its onclick listener fires when you click on the icon and executes the following code:
https://github.com/spielrs/yew_styles/blob/no-render-svg-vnode-props/crate/yew_styles/src/components/modal.rs#L181-L192
The issue here is the call to class_name(). You see, it works perfectly fine for normal html elements but SVGs are special. SVGElement overwrites the className attribute so that it no longer returns a string but an instance of SVGAnimatedString (Please see the notes on Element.className which mentions this).
web-sys doesn't handle this gracefully which is why you get the type error. Please see https://github.com/rustwasm/wasm-bindgen/issues/2091 for more details.
You can verify that this is the issue by commenting out the code.
There are two ways to solve your issue. You can use get_attribute("class") to get the raw attribute string or use the class_list list.

Thanks a lot @siku2! I will try to work around as you suggest and in case that I can I will close the ticket.

I changed to class_list and works. Thanks @siku2 !


Shadow not rendering on web in a mobile layout

I have inset shadows that render fine in web, as long as the layout is "desktop" like.
When I either open it on my phone or when I use the debugger in web to force it into a mobile layout the shadows disappear entirely.
I have no clue what could be causing this, any thoughts?

I'm also facing this issue. Love the package and the way it gives shadows on desktop but it doesn't have the same effect on mobile. I have a word game where I am using this. Here are two images which highlight the difference
On Desktop:

On Mobile:

Any help is appreciated

Hi, sorry I don't know why but I wasn't subscribed to that issue so I didn't received the notification.
Thank you for the screenshots, I will take a look at this again.
Just to be sure, when you say mobile you mean web on a mobile?

Yes I mean web (browser) on mobile
Regards,
Radha
On Fri, Sep 27, 2024, 16:02 Chito @.***> wrote:

Hi, sorry I don't know why but I wasn't subscribed to that issue so
I didn't received the notification.
Thank you for the screenshots, I will take a look at this again.
Just to be sure, when you say mobile you mean web on a mobile?
—
Reply to this email directly, view it on GitHub
https://github.com/chitochi/flutter_inset_shadow/issues/12#issuecomment-2378967721,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AJAJ3U24JJO5L5THEUYMPBTZYUX4XAVCNFSM6AAAAABJ5HBRGWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNZYHE3DONZSGE
.
You are receiving this because you commented.Message ID:
@.***>


Handle interruptions

As a user I want playback to pause when I receive a call or an alarm, then to automatically resume.
Acceptance criteria

Playback pauses when a call is received and resumes automatically when the call ends.
Playback pauses when an alarm is fired and resumes automatically afterwards.

Tasks

[ ] Pause and resume playback when a call is received.
[ ] Pause and resume playback when an alarm is fired.

Some interesting documentation.


I am not sure its bug or wrong coding AlertDoes not popUp

I am just sharing with little code I hope it is all clear if not I will create a new app
1st problem alert does not pop
public let eventFormReducer = Reducer<
  EventFormState, EventFormAction, EventFormEnvironment
> { state, action, environment in
 case . alertDismissed:
  // wanted to go my parent view
 // so i think i can make child state from my parent it will back to parentView
  return .none
  case .successFullMsg: //
    state.alert = .init(
      title: .init("Event: \(state.title)"),
      message: .init("Your event \(state.title) successfully created!"),
      primaryButton: .cancel(send: .alertDismissed),
      secondaryButton: .default(.init("Dismiss"), send: .alertDismissed)
    )

    state.isPostRequestOnFly = false
    return .none

  case let .eventsResponse(.success(event)):

    return Effect(value: EventFormAction.successFullMsg)
      .delay(for: 1, scheduler: environment.mainQueue)
      .eraseToEffect()

  case let .eventsResponse(.failure(error)):
    state.isPostRequestOnFly = false
    return .none

  case .submitButtonTapped:
       return .envirionment.....with data
}
<img width="1237" alt="Screenshot 2021-08-07 at 13 59 07" src="https://user-images.githubusercontent.com/8770772/128598053-032ca368-9ec3-4d56-852c-183de3d00a6d.png">

Environment

Xcode 13 beta 3
Swift 5.5
OS (if applicable): iOS 15

@saroar Unfortunately without more code (ideally a working sample that reproduces the issue) it'll be tough for anyone to troubleshoot. A few questions along the way, though:

Have you set breakpoints in the reducer or used one of our debug helpers to ensure that alert state is getting set?
What does the view code look like that attempts to display the alert?

This doesn't sound like a bug in the library, especially since we have working case studies showing how alerts can be displayed in TCA, so I'm going to convert this issue to a discussion. If it does turn out to be a bug in the library, we can open up another one here with more information.


Paparazzi exploration

Codecov Report

Merging #226 (fa4c9b9) into main (1653efc) will decrease coverage by 0.80%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #226      +/-   ##
==========================================
- Coverage   74.25%   73.44%   -0.81%
==========================================
  Files          66       66
  Lines        2975     2975
  Branches      477      477
==========================================
- Hits         2209     2185      -24
- Misses        500      523      +23
- Partials      266      267       +1

Impacted Files
Coverage Δ

...fe/ui/entrypoints/GameOfLifeAlgorithmEntryPoint.kt
0.00% <0.00%> (-100.00%)
:arrow_down:

...ui/entrypoints/ComposeLifeDispatchersEntryPoint.kt
0.00% <0.00%> (-100.00%)
:arrow_down:

...ui/entrypoints/ComposeLifePreferencesEntryPoint.kt
0.00% <0.00%> (-100.00%)
:arrow_down:

...n/kotlin/com/alexvanyo/composelife/MainActivity.kt
0.00% <0.00%> (-85.72%)
:arrow_down:

...lin/com/alexvanyo/composelife/ui/ComposeLifeApp.kt
0.00% <0.00%> (-80.77%)
:arrow_down:

...lexvanyo/composelife/ui/InteractiveCellUniverse.kt
56.52% <0.00%> (-21.74%)
:arrow_down:

...anyo/composelife/ui/action/ActionCardNavigation.kt
55.17% <0.00%> (-10.35%)
:arrow_down:

.../alexvanyo/composelife/ui/cells/CellWindowState.kt
75.55% <0.00%> (-8.89%)
:arrow_down:

...kotlin/com/alexvanyo/composelife/ui/theme/Theme.kt
40.90% <0.00%> (-4.55%)
:arrow_down:

...vanyo/composelife/model/TemporalGameOfLifeState.kt
92.05% <0.00%> (-0.67%)
:arrow_down:

... and 3 more

:mega: Codecov can now indicate which changes are the most critical in Pull Requests. Learn more


Migrate to pixi

I think that we should add a 'development' section in the docs as a follow-up to this PR; explaining how one can locally

install the environment
install and run pre-commit hooks and
run the tests

The Windows tests are failing - I created an issue to follow up on it after this PR:
https://github.com/Quantco/metalearners/issues/24


error when insert: sql: converting argument $17 type: unsupported type []string, a slice of string

Hi there!
I have a model in golang:
type Transaction struct { 	ID         string db:"id",         Status  int db:"status",          Users  []string db:"users",
and this is the sql for insert:
sqlStr :=
INSERT INTO transactions (data, users)
VALUES (:data, :users)
RETURNING id
 	tx := st.DB.MustBegin() 	defer tx.Commit() 	_, err := tx.NamedQuery(sqlStr, txs) 	return err
But I got an err:
sql: converting argument $17 type: unsupported type []string, a slice of string
Can someone help to fix that, thank you very much!

Same error


Content changed from Episode 4 to Episode 5

new url and, design.
current version is not working.
http://pso2.jp/players/boost/

I'll takes about 2 week to fix,
Because I'm in a place I can't connect to the Internet.


Make the package managers multi instances again

Fix #5517
Will create a bug for the functionality that this is now breaking (install package doesn't trigger test discovery)

Filed https://github.com/microsoft/PTVS/issues/5520


Better plugin interface

Instead of making exports for all ops, use a dispatch like interface.

I think we should use https://nest.land/package/plug for this, it gets rid of the .deno_plugin dir which is great.
@qu4k could you help us set this up, we have a DEV env variable that will tell plug to load from local files.

Sure 👍🏻


Discard obviously absurd window positions.

Looks like winit sometimes writes pos x=-32000.0, y=-32000.0 on multiscreen setups. Clamp this to be at least 0 when we load the window.

On some platforms the (0, 0) coordinate is the top-left corner of the primary screen. So if you have two screens and the right is the primary one, then the left screen will have negative X coordinates. This is true on my Mac, and maybe other platforms too.
Clamping the window position to the screens makes sense to me, but this is not the way to do it.
I think using https://docs.rs/winit/0.24.0/winit/window/struct.Window.html#method.available_monitors we could get a list of all monitor coordinates and then clamp window position to be inside at least one of them.
I've opened an issue on winit on this topic: https://github.com/rust-windowing/winit/issues/1851

Ok! I wonder if I should use DummyStorage in my app as workaround for now so this doesn't hit my users too much?

That sounds reasonable. Persistence and window positioning are both quite under-cooked features, so it is probably wise not to rely on them too much :)


Tracking Issue: DCR: Simplify driver code for running a dialog + State improvements + Add MVC support for C# SDK #5235

Tracking issue for DCR: Simplify driver code for running a dialog + State improvements + Add MVC support for C# SDK
https://github.com/Microsoft/BotBuilder/issues/5235
[enhancement]

Partially handled by https://github.com/Microsoft/botbuilder-dotnet/pull/1358


Improve render

This PR appears to have several breaking changes. Can you provide more details on what you mean by Improve Render. I'll take a deeper look at the PR this week.

I'm so sorry.
I did this pr on wrong repo!
sorry again


fix: Slightly enhanced the typing of createGlobalState

Description
Enhanced the type definition of createGlobalState to condition the state value's type to not be undefined in the case an initial value was passed in.
Type of change

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[x] Breaking change (fix or feature that would cause existing functionality to not work as before)

Checklist

[x] Read the Contributing Guide
[x] Perform a code self-review
[x] Comment the code, particularly in hard-to-understand areas
[x] Add documentation
[x] Add hook's story at Storybook
[x] Cover changes with tests
[x] Ensure the test suite passes (yarn test)
[x] Provide 100% tests coverage
[x] Make sure code lints (yarn lint). Fix it with yarn lint:fix in case of failure.
[x] Make sure types are fine (yarn lint:types).

Thank you. I actually was going to do that. Glad I you did first.

That should also be done to the other hooks. useLocalStorage has the same problem.

@streamich Could you approve this PR? 😁


Print out mount path when replica token file fail to deserialize

Summary
When replication manager starts, it will read the remote replica tokens from a file, and then try to deserialize it. When it fails on deserialization, the ambry-server would fail to start. However, we are not able to see from the log or stack trace which replica file is not able to deserialize. This PR would make sure we print that information out.
Test
Unit test

Codecov Report
Attention: Patch coverage is 0% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 18.17%. Comparing base (4a4ee68) to head (96dd63d).

Files
Patch %
Lines

...ithub/ambry/replication/ReplicaTokenPersistor.java
0.00%
4 Missing :warning:

Additional details and impacted files
@@              Coverage Diff              @@
##             master    #2746       +/-   ##
=============================================
- Coverage     70.65%   18.17%   -52.49%
+ Complexity    11584     2811     -8773
=============================================
  Files           833      833
  Lines         71007    71009        +2
  Branches       8532     8532
=============================================
- Hits          50171    12905    -37266
- Misses        18208    56903    +38695
+ Partials       2628     1201     -1427

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


#343 repro

Closing as this is just a reproducer for https://github.com/quarkiverse/quarkus-openapi-generator/issues/343


Change setUp and tearDown during provider verification to run before and after each interaction verify

We are currently running the setUp and tearDown functions at the start and end of the provider verification process. This should actually be run for each interaction within the verification process.

Fixed in 0e0f669a51e11ec4b12188fa1a938d66cd0fd15d


WIP support specification main branch

Many thanks for submitting your Pull Request :heart:!
What this PR does / why we need it:
Provide support to the specification main branch
Special notes for reviewers:
I understand that the sdk  has to evolve with the specification, so we should be able to generate the code from the main branch.
Should wee publish snapshot version to npmjs registry?
the think is that npmjs does not allow overwrite packages (as maven does) so once one version is published there is no rollback. (I have already messed up things here.. )
Related found documentation

https://stackoverflow.com/questions/31156766/using-snapshot-in-private-npm-like-in-maven
https://www.npmjs.com/package/npm-snapshot
https://github.com/npm/cli/issues/1391 (closed with no response)
https://kevinkreuzer.medium.com/publishing-a-beta-or-alpha-version-to-npm-46035b630dd7

Additional information (if needed):

I must admit I'm not familiar with the concept of snapshot versions, from what I understand it's like prerelease/rc versions? (I'll read a bit about it)
I think we should keep a consistant relation between the spec version and the package version, we can have multiple subversions at the same time.
For instance, let's say 0.6 is stable and 0.7 (main) is next, we can have 2 branches of the SDK, one with a 0.6.x package and one with 0.7.x package. Depending on the configuration, 0.6.x could be tagged as latest and 0.7.x could be tagged as next. Each branch of the project can have it's own independant schema registry URL configured in download-schemas.ts if needed.
One important note though, while porting the tests to the alternative approach` version, I noticed few problems. I think we should stabilize those before branching/handling multiple schemas versions

You can define the release strategy as you see best fit. If it helps some lets have a chat I could go over how we do it for the Java Sdk. Basic idea is to have release branches while "main" is indeed a "snapshot" which follows the specification "main" branch . But again that might not be the best strat for all Sdks.

the only requirement i think we need to have is to have ability to correspond a release with a spec version release. otherwise its really up to you guys tode whats best approach :)

agree about having releases branch,
I will ask for help if I need for sure,
I just was wondering about how to publish "wip/snapshot" versions, probably I am just overcomplicating things, let's keep it simple..

I think it's managed with tags. If I'm not mistaken, by default, if no version is specified when running npm install/publish, the latest tag will be used. So if when you want to publish an unstable/beta version, you'd just use a different tag when publishing/installing.
For instance:

<EMAIL_ADDRESS>latest
<EMAIL_ADDRESS>latest
<EMAIL_ADDRESS>latest
<EMAIL_ADDRESS>beta

Running npm install package will install 1.0.2 and npm install package@beta will install 1.0.3. Publishing a new version, 1.0.4 will make it latest so the next user to install without specifing a tag (or have a semver restriction in the package.json) will get 1.0.4. In other words, you don't get the beta version unless you explicitly ask for it.

I think it's managed with tags. If I'm not mistaken, by default, if no version is specified when running npm install/publish, the latest tag will be used. So if when you want to publish an unstable/beta version, you'd just use a different tag when publishing/installing.
For instance:

<EMAIL_ADDRESS>latest
<EMAIL_ADDRESS>latest
<EMAIL_ADDRESS>latest
<EMAIL_ADDRESS>beta

Running npm install package will install 1.0.2 and npm install package@beta will install 1.0.3. Publishing a new version, 1.0.4 will make it latest so the next user to install without specifing a tag (or have a semver restriction in the package.json) will get 1.0.4. In other words, you don't get the beta version unless you explicitly ask for it.


Can't parse poc error: : no template name field provided

I failed to reproduce locally. Can you add the -- debug option to give me more output?

报错

[18:49] ERROR Raw Error: Can't parse poc error: : no template name field provided
github.com/WAY29/pocV/internal/common/load.LoadPocs.func1
E:/code/go/pocV/pocV-main/internal/common/load/load.go:69
github.com/WAY29/pocV/internal/common/load.LoadPocs
E:/code/go/pocV/pocV-main/internal/common/load/load.go:91
main.cmdRun.func1
E:/code/go/pocV/pocV-main/cmd/pocV/pocV.go:78
github.com/jawher/mow.cli/internal/flow.(*Step).callDo
E:/Program Files(x86)/gopath/pkg/mod/github.com/jawher/mow.cli@v1.2.0/internal/flow/flow.go:55
github.com/jawher/mow.cli/internal/flow.(*Step).Run
E:/Program Files(x86)/gopath/pkg/mod/github.com/jawher/mow.cli@v1.2.0/internal/flow/flow.go:25
github.com/jawher/mow.cli/internal/flow.(*Step).Run
E:/Program Files(x86)/gopath/pkg/mod/github.com/jawher/mow.cli@v1.2.0/internal/flow/flow.go:29
github.com/jawher/mow.cli/internal/flow.(*Step).Run
E:/Program Files(x86)/gopath/pkg/mod/github.com/jawher/mow.cli@v1.2.0/internal/flow/flow.go:29
github.com/jawher/mow.cli/internal/flow.(*Step).Run
E:/Program Files(x86)/gopath/pkg/mod/github.com/jawher/mow.cli@v1.2.0/internal/flow/flow.go:29
github.com/jawher/mow.cli.(*Cmd).parse
E:/Program Files(x86)/gopath/pkg/mod/github.com/jawher/mow.cli@v1.2.0/commands.go:693
github.com/jawher/mow.cli.(*Cmd).parse
E:/Program Files(x86)/gopath/pkg/mod/github.com/jawher/mow.cli@v1.2.0/commands.go:707
github.com/jawher/mow.cli.(*Cli).parse
E:/Program Files(x86)/gopath/pkg/mod/github.com/jawher/mow.cli@v1.2.0/cli.go:76
github.com/jawher/mow.cli.(*Cli).Run
E:/Program Files(x86)/gopath/pkg/mod/github.com/jawher/mow.cli@v1.2.0/cli.go:105
main.main
E:/code/go/pocV/pocV-main/cmd/pocV/pocV.go:134
[18:49] DEBUG Load poc file: pocs\xray\weiphp-sql.yml
[18:49] ERROR Raw Error: Can't parse poc error: : no template name field provided
github.com/WAY29/pocV/internal/common/load.LoadPocs.func1
E:/code/go/pocV/pocV-main/internal/common/load/load.go:69
github.com/WAY29/pocV/internal/common/load.LoadPocs
E:/code/go/pocV/pocV-main/internal/common/load/load.go:91
main.cmdRun.func1
E:/code/go/pocV/pocV-main/cmd/pocV/pocV.go:78
github.com/jawher/mow.cli/internal/flow.(*Step).callDo
E:/Program Files(x86)/gopath/pkg/mod/github.com/jawher/mow.cli@v1.2.0/internal/flow/flow.go:55
github.com/jawher/mow.cli/internal/flow.(*Step).Run
E:/Program Files(x86)/gopath/pkg/mod/github.com/jawher/mow.cli@v1.2.0/internal/flow/flow.go:25
github.com/jawher/mow.cli/internal/flow.(*Step).Run
E:/Program Files(x86)/gopath/pkg/mod/github.com/jawher/mow.cli@v1.2.0/internal/flow/flow.go:29
github.com/jawher/mow.cli/internal/flow.(*Step).Run
E:/Program Files(x86)/gopath/pkg/mod/github.com/jawher/mow.cli@v1.2.0/internal/flow/flow.go:29
github.com/jawher/mow.cli/internal/flow.(*Step).Run
E:/Program Files(x86)/gopath/pkg/mod/github.com/jawher/mow.cli@v1.2.0/internal/flow/flow.go:29
github.com/jawher/mow.cli.(*Cmd).parse
E:/Program Files(x86)/gopath/pkg/mod/github.com/jawher/mow.cli@v1.2.0/commands.go:693
github.com/jawher/mow.cli.(*Cmd).parse
E:/Program Files(x86)/gopath/pkg/mod/github.com/jawher/mow.cli@v1.2.0/commands.go:707
github.com/jawher/mow.cli.(*Cli).parse
E:/Program Files(x86)/gopath/pkg/mod/github.com/jawher/mow.cli@v1.2.0/cli.go:76
github.com/jawher/mow.cli.(*Cli).Run
E:/Program Files(x86)/gopath/pkg/mod/github.com/jawher/mow.cli@v1.2.0/cli.go:105
main.main
E:/code/go/pocV/pocV-main/cmd/pocV/pocV.go:134
[18:49]  INFO Load [0] xray poc(s), [0] nuclei poc(s)

The problem is shiziyu-cms-apicontroller-sqli.yml cannot be successfully resolved to a PoC of xray type, but an error occurred when trying to resolve it to a PoC of nuclei type. There is no problem when I load this POC individually in the local test. Can you put your shiziyu-cms-apicontroller-sqli.yml here？

Is Your Xray Poc v2?

The bug has been tested in the new version and has not been successfully reproduced, so close the issue. If there are any more problems, please re-issue.


Responsiveness not implemented

Add more responsiveness (adding for future reference)

Try implementing through global styles. That will work better rather than going to each component mannually


[Enhancement] Option to delete and rename CE/support Servant image from App

Sometimes event already passed and the rerun is already done, it will help to remove some steps if we can remove unused ce/servant image to save memory from app, can be a little trash bin icon per item (with confirmation) on the selection menu.
EDIT: rename function is good too, to rename image from support maker
Thanks mathew for this good app, really looking forward how this app will grow in the future.

Renaming was implemented in #94


Match route before init stores

This adds back the changes made in #695 ensuring that href, query, params etc. are in the state before the stores are initialized.

Is this a breaking change?

It could be, if a stores is checking for these properties in state to determine if it has been initialized before or not. Also, in combination with https://github.com/choojs/choo/pull/649 these properties will always be in state on initialization, as opposed to only after the first call toString.
@yoshuawuyts mentioned on IRC that the init order has been switched around before, but not as a breaking change and apparently it caused issues for some people.


Cannot access Meteor.user in property declaration

Template.name.viewmodel({property:Meteor.userId()}) returns undefined.
Even if I re-run this from console after template is fully rendered.

That's because you're invoking the method when the app is loaded. Don't use
the parentheses for userId (haven't tried it but it should work)
On Mar 2, 2016 7:13 AM, "Artem Saffron"<EMAIL_ADDRESS>wrote:

Template.name.viewmodel({property:Meteor.userId()}) returns undefined.
Even if I call this from console after template is fully rendered.
—
Reply to this email directly or view it on GitHub
https://github.com/ManuelDeLeon/viewmodel/issues/196.

No, I have this template appear only after I click a button - my app is already fully loaded by that time.
And how can I not user parentheses? Meteor.userId is a function, is it not?

Yes it's a function but you're invoking the function when Meteor loads the
app, not when the template is instantiated. Replace Meteor userId with
console log to see what I mean.
On Mar 3, 2016 2:33 AM, "Artem Saffron"<EMAIL_ADDRESS>wrote:

No, I have this template appear only after I click a button - my app is
already fully loaded by that time.
And how can I not user parentheses? Meteor.userId is a function, is it
not?
—
Reply to this email directly or view it on GitHub
https://github.com/ManuelDeLeon/viewmodel/issues/196#issuecomment-191677983
.

Ok, I've fixed it with
Template.name.viewmodel({
  load:{
    property: Meteor.userId()
  }
})

But is there a way to do it without load??

Use a function that returns the userId
On Mar 3, 2016 6:37 AM, "Artem Saffron"<EMAIL_ADDRESS>wrote:

Ok, I've fixed it with
Template.name.viewmodel({
load:{
property: Meteor.userId()
}
})
But is there a way to do it without load??
—
Reply to this email directly or view it on GitHub
https://github.com/ManuelDeLeon/viewmodel/issues/196#issuecomment-191763389
.

btw, if all you're doing is returning the userId then it's better to put it in a mixin so you can use it on other templates.


Dropdown displays previous list

I have 2 dropdowns and on clicking each displaying data for the respective drop-down. However, it displays same drop-down values for both the drop-down.

Have got this resolved. The issue was with a reactive form element, not getting updated.


Disable background throttling

This will keep running the clock consistently even when the app is in
the background

I had been wondering how to do this, thanks.
You're the best!


Handle multiple API versions for monitored services

Hello
Thanks for this project, it looks really promising.
I would like to start using it and, if it suits my needs, try to add a few specific monitorable items.
Before that, I have about this a couple of questions :

what is the suggested (internal) policy with monitoror about how to handle the versions against which one monitorable object can be used? As you may now, some products may have some API evolutions over time, so a monitorable object working for (let's say) TeamCity 7.x may need some evolutions for TeamCity 9.x - is that kind of situations handled in any way?

EDIT by @Alex-D: See #253. I have split the second part into a distinct issue to have a better follow-up :)

Hey!
First, I've split your issue into two distinct issues. It will be better to follow-up in the future.
To be honest, we had no plan to support that. We talked about it, and we have a pretty solution :D
All of the following is not implemented; it's a draft to talk and find the best solution.
End-user specs
Default: latest
All core monitorable will be on the latest product version, always (except if Monitoror Core code is out of date, obviously ^^').
An environment variable to set an API version
When a monitorable supports multiple versions, we will add a MO_MONITORABLE_{SERVICENAME}_VERSION, or something like that, to choose the product version.
Example:

nothing or MO_MONITORABLE_TEAMCITY_VERSION=2019.2 (the lastest when I post)
MO_MONITORABLE_TEAMCITY_VERSION=7.1

Multiple versions on the same Monitoror instance
To use multiple versions, users can use Configuration Variants to get multiple {SERVICENAME} with different (or same) versions.
Example:
# v7 instance as default variant
MO_MONITORABLE_TEAMCITY_URL="https://old7.teamcity.lan:8888"
MO_MONITORABLE_TEAMCITY_VERSION=7.1

# v9 instance as "v9instance" variant
MO_MONITORABLE_TEAMCITY_V9INSTANCE_URL="https://old9.teamcity.lan:8888"
MO_MONITORABLE_TEAMCITY_V9INSTANCE_VERSION=9.4

Dev specs
One major service API version = one distinct repository.go file
For each API version range, we will need to create a new repository file in the given monitorable. Then the usecase will be in charge of choosing the right repository depending on the version.
Make the product version to repository choice transparent for the end-user
We should consider that multiple service versions can be used with the same repository. So, to keep things simple and transparent for the end-user, we need to allow the user to set the service version and not the API one.
Moreover, some services will introduce breaking changes on "minor" versions since they may not follow semver. So, we cannot only base our check on major versions.
Example 1:
Given that versions 1.0, 1.1, 1.2, and 2.0 use the same API, then the 2.5 introduce a breaking change for use (boo, they are now following semver!); we need to be able to map all 1.0 to 2.4 on a given repository, and 2.5+ to another repository.
Example 2:
JetBrains product use YEAR.QUARTER version convention now.
7.x, 8.x, 9.x, 10.0, 2017.1, ..., 2020.2
Documentation
At the meanwhile, we should add a minimum and currently supported version to each monitorable in the documentation.


Mirror nginx and prom-aggregation-gateway on Quay.io

The deployment keeps breaking b/c of pull rate-limits on Docker.io. Set
up a mirror for these two images on Quay.io.
Signed-off-by: Hunor Csomortáni<EMAIL_ADDRESS>

recheck


Terminal will not run

When I try to start the terminal I get the error:
: Exit 126.
Failed to run '': No such file or directory

I'm getting this too.  How do we fix?

Ways around that:
1. Open powershell
2. Chose a Windows directory to download and install to (must not reside in \wsl$)
3. #> cmd.exe
4. #> wsl bash -c "$(wget https://raw.githubusercontent.com/mskyaxl/wsl-terminal/master/scripts/install.sh -qO -)"


Add helm option enableEgressGateway

The option turns on the egress gateway support, which allows users to
specify Egress NAT policies to redirect and SNAT the egress traffic that
leaves the cluster. It's false by default.
Towards: #13575
Signed-off-by: Yongkun Gui<EMAIL_ADDRESS>

test-me-please

test-gke retest-4.9 retest-4.19

@aanm good findings. I'll fix it.

Question: should the flag stay hidden if we're exposing it through Helm?

If we're now happy enough with the feature to put it in front of users and we don't intend on changing the flags any further, then we can un-hide the flag now as well:
diff --git a/daemon/cmd/daemon_main.go b/daemon/cmd/daemon_main.go
index 82af61b51ea3..2d22cd2c6655 100644
--- a/daemon/cmd/daemon_main.go
+++ b/daemon/cmd/daemon_main.go
@@ -667,7 +667,6 @@ func init() {

        flags.Bool(option.EnableEgressGateway, false, "Enable egress gateway")
        option.BindEnv(option.EnableEgressGateway)
-       flags.MarkHidden(option.EnableEgressGateway)

        flags.String(option.IPMasqAgentConfigPath, "/etc/config/ip-masq-agent", "ip-masq-agent configuration file path")
        option.BindEnv(option.IPMasqAgentConfigPath)

test-me-please

The failure in the test-1.16-netnext was caused by jenkins rebasing the test code but the cilium code is not rebased in the image build process. The test had enabled tunneling mode in https://github.com/cilium/cilium/pull/15716 but this PR was not rebased against master.

test-me-please


Project pre-review

Great work so far!  I have a few things and I believe @ccurtis7 mentioned these in other issues.  Your Examples and Documentation directory are super duper!

[ ] Packages in Python should be one work lower case so the BALLS probably needs to be balls.  Remember that this is only for the package directory and not the repo name.

[ ] The python package should have an __init__.py file.

[ ] I didn't see a setup.py for installing the package.

[ ] Module files (.py files) and functions in PEP8 should be lower case, e.g. Get_Ellipse should be get_ellipse.

[ ] Your tests are a good start.  You might want to look into the setup and teardown functions of your chosen testing framework (i.e. nosetests or py.test).  I notice you have code before the test functions and it isn't guaranteed to be run the way you expect.  If it is working in your existing testing approach, then put something in the README about how to run the tests.

[ ] I would also recommend you run flake8 or pep8 or pylint on your code to find all the PEP8 violations.


Firmware 4.2

FYI.
On 4-7-2023 I installed firmware version 4.2. After installation I get warnings in HA that the hacs bosch module does not recognize this firmware version.
However, it looks like the integration is still working fine.

Had the same issue yesterday, only my integration stopped working completely after a version upgrade. I bet this is only a matter of time for everyone.
Did a quick and dirty fix to get it up and running again. My installation is running from Docker, so some command might be different on other installations.
First, SSH into the docker.

docker exec -t -i  /bin/bash

Then copy the version 4.0 json file to the new 4.2 release.

cd /usr/local/lib/python3.11/site-packages/bosch_thermostat_client/db/easycontrol
cp 040000.json 040200.json

Then edit the 040200.json file so the version number on the first line matches: "versionFirmware": "04.02.00",

vi 040200.json

That's it, restart Home Assistant and you'll be up and running.
My 2 cents, hope it helps someone.

@Barrie99 Thank you so much, it works like a charm!

Hi Barrie99, could you please explain how to do this procedure on home assistant without doker. I'm not very practical. Thank you

@petrotti77 I don't have any other installation handy, but I'm guessing it's more or less the same, taking into account that you're able to SSH into the docker container. (Even HAOS is running from a container)
The Portainer addon should be able to do just that.
https://community.home-assistant.io/t/home-assistant-community-add-on-portainer/68836
But I'm pretty sure there will be an official solution to this issue soon.

@Barrie99 I am not able to perform the changes you recommended due to my lack of experience. If you have any simpler solution to fix this CT200 firmware update issue I will be very grateful.

Had the same issue yesterday, only my integration stopped working completely after a version upgrade. I bet this is only a matter of time for everyone.
Did a quick and dirty fix to get it up and running again. My installation is running from Docker, so some commands might be different on other installations.
First, SSH into the docker.

docker exec -t -i [docker id] /bin/bash

Then copy the version 4.0 json file to the new 4.2 release.

cd /usr/local/lib/python3.11/site-packages/bosch_thermostat_client/db/easycontrol
cp 040000.json 040200.json

Then edit the 040200.json file so the version number on the first line matches: "versionFirmware": "04.02.00",

vi 040200.json

That's it, restart Home Assistant and you'll be up and running.
My 2 cents, hope it helps someone.

thank you!

Bosch thermostat integration for my CT200 with firmware 04.02.00  completely removed and installed again as documented.
The integration is not working, no sensors  are visible and a debug-scan is not created.
Logged error message:
2023-07-09 22:42:37.406 ERROR (MainThread) [custom_components.bosch] You might have unsupported firmware version 04.02.00
System development is not my habitat. Docker and portainer is a bit too much for me. HA 2023.7.1 on a RPi4 is the configuration.
Is there a fix iunder construction? I would be very greatfull to hear. Thank you.

Same issue here. As far as I understand, a custom_component (HACS addon) is not running in a container itself. At least "docker ps" is only listing system-addons.
And in the python-files I can't find where the HACS-addon is getting the firmware-version from. Maybe someone has an idea for a quick fix?

Had the same issue yesterday, only my integration stopped working completely after a version upgrade. I bet this is only a matter of time for everyone.
Did a quick and dirty fix to get it up and running again. My installation is running from Docker, so some commands might be different on other installations.
First, SSH into the docker.

docker exec -t -i [docker id] /bin/bash

Then copy the version 4.0 json file to the new 4.2 release.

cd /usr/local/lib/python3.11/site-packages/bosch_thermostat_client/db/easycontrol
cp 040000.json 040200.json

Then edit the 040200.json file so the version number on the first line matches: "versionFirmware": "04.02.00",

vi 040200.json

That's it, restart Home Assistant and you'll be up and running.
My 2 cents, hope it helps someone.

Thanks a lot, it works. The only cons is, I now have CT200 devices duplicated: once working with fw version 04.02 and second not working with fw v. 04.00.

@suchosj I'm relatively sure your issue has nothing to do with the 040200.json file. (You could test by removing it)
The json only accepts the new firmware but does not duplicate entities or anything else in Home Assistant. Perhaps you tried reinstalling the complete custom component or tried something else prior to running this fix? That would explain.
For now, just disable the firmware updates on the thermostat. That prevents these things happening again :)

hello all, although I have updated the repisitory to v0.22.3dev1, the integration still doesn't work. I've tried uninstalling both the repository and the integration but nothing works. now it only sees the device but no sensors. do you have suckings? Thank you

hello all, although I have updated the repisitory to v0.22.3dev1, the integration still doesn't work.

+1

following this as my bosch thermostat also did an auto update to 4.02 and now the integration is no longer working

following this as my bosch thermostat also did an auto update to 4.02 and now the integration is no longer working 😄

following this as my bosch thermostat also did an auto update to 4.02 and now the integration is no longer working :smile:

Same here.....integration is not working anymore after update to 4.02 👎

same here :(

Same issue.

Same here.

@Barrie99. I did install Portainer. The gap between  Portainer opening screen and the fix instructions assumes a lot of extra knowledge I do not have.
But before I maybe try it again, to me it is not clear the nature of this firmware problem. What is holding back to create a formal solution with a new integration release?  Thanks for your reaction.

What is holding back to create a formal solution with a new integration release?

I have no clue. I'm just a user like you that managed to fix this issue on his Docker installation ;-)
I have nothing to do with Bosch or this integration.
That said, let me look into the HAOS installation, maybe I can make a step-by-step guide.

@Barrie99 if possible that would be very helpful. Available for testing if needed.

@Barrie99, because i am not familiar with such deep programming i have not even try the portainer installation.
I really appreciate your efforts with this issue and it would be great if you can solve this four us, as users.
A few months ago i have had the same problem with the Bosch integration but after a HA update it solves itselfs🤔
In the meantime thx again👍

I wish I had better news but this is a tough nut to crack on HAOS, since I can't find an easy way to fully access the system. (Which makes sense since it's not meant to be fully open).
I'm new to Github, but I managed to fork the bosch-thermostat-client-python branch and added the 040200.json file. The Home Assistant integration uses this bosch-thermostat-client-python code, so hopefully the json will get incorporated into the main branch. If so, we probably don't need to do anything I suppose, except maybe reinstall the integration. I have no clue how this works, if it works or who has to accept or validate this change. So it might take months, it could take hours. Who knows.
So for Docker installations anyone can copy and edit the json file manually as described above. (It looks harder than it is) But for HAOS we appear to be stuck waiting for the developers to do something. As @Raspyguy said, these things usually fix themselves after some time.

I think it should be reported here

@Barrie99   yes HA on raspberryPi

@andrewptw @Jopy2104 @fgraefen @Raspyguy @TomDeSchutter @gitioda @PV-Web
So you're all running the HAOS version of Home Assistant? Since the fix for this problem for Docker installations is in this thread. If HAOS: Has any of you tried Portainer or this method: https://community.home-assistant.io/t/protip-how-to-get-shell-in-actual-homeassistant-or-addon-container-when-using-hassio/48760
Let me know.

I went the quick and dirty path as well. Moved my installation to a docker based one.
Was long overdue for me anyway. Your hack fixed my issues, thank you.

@TomDeSchutter No problem, happy to assist. I think you made a smart move. Was standing in your shoes a couple of weeks ago and haven't regretted moving to Docker for even one second.

I was also able to create the configuration file in the HA Dockeer container via the Advanced SSH & Web Terminal addon.
thanks for your support!

@pszafer it's this time of the year when Bosch releases new firmware and we need your assistance 🙏

@fgraefen It will most likely be overwritten. But chances are it will be overwritten by pretty much the same file, so you won't even notice.

I'll be back home on Sunday, then I'll release new firmware. Sorry you have to wait but it's my vacation time ;)

I'll be back home on Sunday, then I'll release new firmware. Sorry you have to wait but it's my vacation time ;)

Don't be sorry, Many thanks in advance, take you time and enjoy your holliday !  😊

@pszafer here is my scan in case you need it. Thanks again for your continued support!
bosch_scan.txt

Fixed in https://github.com/bosch-thermostat/home-assistant-bosch-custom-component/releases/tag/v0.23.1

Thank you the release @pszafer. It indeed resolves the issue!

Thanks a lot @pszafer issue solved for me too  😀🙏

@pszafer Thank you so much for solving the problem. so far everything works fine.

@pszafer Thanks for the quick action. Seems to work great again. Keep up the good work!

@pszafer Thanks for the fix. Works like a charm.

@Raspyguy update via HACS

Hi, its not visible in HACS?Verzonden vanaf Outlook voor Android

@pszafer,Found it, update become visible after using the 3 dots 🙄Works perfectly 👍Many thanks for the solution!!Verzonden vanaf Outlook voor Android

Hi there,Again after the bosch 04.02.01 update the integration isn't working anymore🥴Anybody familiar with it?Verzonden vanaf Outlook voor Android

@pszafer @Raspyguy
The custom - component 0.23.1 installed three days ago and was working as expected.
However, last night out of the blue the same error: 'You might have unsupported firmware version 04.02.01' came back in logging and on screen.
Only difference is version level now 04.02.01 instead of .00. None of integration sensors are available anymore.
Yesterday I upgraded HA to 2023.7.3. Reverted back to 7.2 but firmware error remains.
Enough information supplied for investigation and possible fix?

I released 0.23.2 with the fix yesterday afternoon

@pszafer does this fix also work with 04.02.00, so I can upgrade HA before the thermostat?

@Jopy2104 yes


Make pypi release

[x] Make tests pass
[x] make all works

@ckindermann , could you please give us permissions to publish this on pypi? Seems like we need it to proceed.

Yes please! Thank you so much!!!

Thanks a lot Chris!


nit: remove preview image from repository

Hey, thanks for making this! This is just a really minor nitpick, not even code related. This is just so that anyone cloning the repo doesn't need to also clone the preview image every time (though the image is quite small, hence this being more of a nit). You can see the image still shows up just fine here.
Feel free to close this if you don't like it / want to do it yourself to get the link to point to your account. To get a link for the image just drag-and-drop it onto a GitHub comment / when editing the README through their UI.

Thanks for the info. Doesn't know github has this feature.
It makes more sense for the image to point to my account. Hence, I'll close this PR and make it myself.

Yep all good


Backend SNI Support

Currently, Traefik does not appear to support SNI on backend connections. This causes it to be incompatible with backend clients with strict SNI enabled, which returns a TCP reset upon an SNI mismatch. The host header forwarding seems to be sufficient for hosts without strict SNI, but with strict SNI, it's impossible.
I would like to propose an additional field, sniHostname, in the backend.
          [backends]
            [backends.adfs]
              [backends.adfs.servers]
                [backends.adfs.servers.adfs01]
                  url = "https://adfs01.example.com:443"
                  sniHostname = "adfs.example.com"
                [backends.adfs.servers.adfs02]
                  url = "https://adfs02.example.com:443"
                  sniHostname = "adfs.example.com"

Alternatively, it could be set on the backend level, like so:
          [backends]
            [backends.adfs]
            sniHostname = "adfs.example.com"
              [backends.adfs.servers]
                [backends.adfs.servers.adfs01]
                  url = "https://adfs01.example.com:443"
                [backends.adfs.servers.adfs02]
                  url = "https://adfs02.example.com:443"

Perhaps both would be useful, allowing it to be overridden on a single backend host basis for maximum flexibility, but not forcing you to duplicate the same data on each host if it's the same.

Closed in favor of #4835


Add (micro/macro) precision and recall to CustomF1

(Currently only aggregates results (and not per class), so not too add too many scores.

The default behavior in sckit learn on divide by zero is to return ‘0’ with a warning.   There is the flag to change to change to 1.0, 0.0 (without warning) and nan (which is a new option).
Set our behavior to 0 as well.


fix(runtime-core): cache the return value from the default factory to avoid unnecessary watcher trigger

Fix: #3471
We should cache the return value from the default factory to avoid unnecessary watcher triggering, which is what Vue2 does.

If we save the cache on the prop definition object, wouldn't it fail with two instances of the same component (as both would use the same reference to the same object)? It could also fail if people use the same prop object in two props (which they shouldn't), no?
Maybe it's safer to save it in the instance? It could also use a Symbol to prevent exposing it

@posva yes, I am aware of this and have corrected it.


Ignore .DS_Store

I considered this instruction:
git config --global core.excludesfile '~/.gitignore_global'
But we ignore .DS_Store in lots of alphagov repos, and can't rely on
everybody to set up their git config in the same way. Ignoring it
explicitly is a common enough convention that it's worth doing here.

Although a minor concern I don’t think we should do this as it creates inconsistencies and breaks Rails conventions. One it contradicts the comment about using gitignore_global for operating system files and two it is the only item in here that is not a product of the application or its dependencies.
Personally I’m for following the Rails convention on this of only adding files produced by the application or dependencies as this is often a slippery slope of adding extra stuff unrelated to the repo. Take the specialist publisher gitignore for example that has .idea ignored, for someone to understand why that is ignored you have to know about IntelliJ text editors producing that directory. I’d actually think a better step would be removing these from other repos as I think the sooner developers are acquainted with gitignore_global the better.

I 100% agree with @kevindew here. People ignoring non-app files in app-level .gitignores is one of my pet peeves. Let's remove them all.


High-level overview of the pedagogical structure

Now that the course content is a bit more mature, should we create a single document kind of summarising the key elements of each notebook so that we can have an idea of the high-level pedagogical structure? This would be a single document so maybe this is a rehash of plan.md that never really worked ...
This helps having a high-level overview of the full content. Very often when changing something locally:

you don't realise that you need to change it in other places
that the pedagogical sequence is a bit weird once you change it
or that originally we did that because we thought we would not introduce a notion until a later module.

Should this be automatically generated (probably not)?
Should we do it now that the course content is fresh in our minds?
Maybe this is YAGNI I don't know

I think that this would be useful. Maybe ask the learning lab team what they think?

We have a table of content in the Mooc : https://lms.fun-mooc.fr/courses/course-v1:inria+41026+session01/496272d6f8444957a7014122a4646116/ and it is very usefull even if we could improve it with some collapse elements. Is it somethink similar that you wish @lesteve ?

For me this is more a single document that includes the table of content but also some text explaining the idea behind each notebook so that we can use it to see the full story of the MOOC (more for us as content writers than anything else).
I'll open a separate issue about having the equivalent of the FUN table of contents, I agree this would be useful to quickly make sure that the contents haven't drifted too much away between FUN and the JupyterBook.

should we create a single document kind of summarising the key elements of each notebook so that we can have an idea of the high-level pedagogical structure?

Maybe a table of contents similar to the one that I use in #398 could come useful for this purpose. Of course my notation can be improved using navigation tools, but it does help keeping track of the pedagogical structure.

Should we do it now that the course content is fresh in our minds?

I am expanding it while following the MOOC.

Let's close this, I don't think this is realistic to have something like this unfortunately ...
Also there is the table of contents now: https://inria.github.io/scikit-learn-mooc/toc.html


please help me

Why can't the scanner read this qrcode? Is this an error or unsupported format.

Hi @bangnguyen794
It looks working on my Pixel 3 with the sample app.

closed due to no response for a week

I'm sorry, I didn't see the message, it happened on iOS.
https://user-images.githubusercontent.com/17409119/113507406-5cc39a80-9574-11eb-910f-456e10b4fe13.mp4

I'm sorry, I didn't see the message, it happened on iOS.
Phim.c.a.toi.4.mp4

I just tested on my iPhone 11 with the sample app and it looks also working.
could you provide your code snippet for your implementation?
https://user-images.githubusercontent.com/12612781/113647461-71f81080-96bd-11eb-921e-0e709ec1a623.mp4

I download souce from github (https://github.com/JimmyPun610/BarcodeScanner.XF) run a test ..
https://user-images.githubusercontent.com/17409119/113655443-01a0bd80-96c4-11eb-8ee2-1f1abc8c2792.mp4

I tried that it would work in some angle, but still hard to scan the code.
It may caused by the quality of the qrcode and the scanning engine.
I could only suggest you try to set the barcode type to QRCode.
Does it happens on other qrcodes with similar texture?

I set the barcode type to Qrcode, it doesn't yield better results. [ Methods.SetSupportBarcodeFormat(BarcodeFormats.QRCode); ]
I used the scanner on the iphone it produced the expected results.
Does it happens on other qrcodes with similar texture? => yes.
I look forward to an update that improves qrcode scanning. Thanks JimmyPun610


urllib3.exceptions.MaxRetryError: HTTPConnectionPool(host='localhost', port=80): Max retries exceeded (Caused by NewConnectionErr or('<urllib3.connection.HTTPConnection object at 0x7fb3be7bca58>: Failed to establish a new connection: [Errno 111] Connection refused',))

Getting this error when executing any fiber function call. Tried giving all permissions and double checked network configuration but everything seems right. As this is the broad error and this is relatively new library couldn't find solution anywhere else.  I'm new to this so please point me in the right direction.
Logs look like this:
Feb 22 18:48:03 test1-797b9fdffb-jz225: Retrying (Retry(total=2, connect=None, read=None, redirect=None, status=None)) after connection broken by 'NewConnectionError('<urllib3.connection.HTTPCon
nection object at 0x7fb3be7bc710>: Failed to establish a new connection: [Errno 111] Connection refused',)': /api/v1/namespaces/default/pods/test1-797b9fdffb-jz225
Feb 22 18:48:03 test1-797b9fdffb-jz225: Retrying (Retry(total=1, connect=None, read=None, redirect=None, status=None)) after connection broken by 'NewConnectionError('<urllib3.connection.HTTPCon
nection object at 0x7fb3be7bc860>: Failed to establish a new connection: [Errno 111] Connection refused',)': /api/v1/namespaces/default/pods/test1-797b9fdffb-jz225
Feb 22 18:48:03 test1-797b9fdffb-jz225: Retrying (Retry(total=0, connect=None, read=None, redirect=None, status=None)) after connection broken by 'NewConnectionError('<urllib3.connection.HTTPCon
nection object at 0x7fb3be7bc940>: Failed to establish a new connection: [Errno 111] Connection refused',)': /api/v1/namespaces/default/pods/test1-797b9fdffb-jz225
something started
Traceback (most recent call last):
  File "/usr/local/lib/python3.6/site-packages/urllib3/connection.py", line 170, in _new_conn
    (self._dns_host, self.port), self.timeout, **extra_kw
  File "/usr/local/lib/python3.6/site-packages/urllib3/util/connection.py", line 96, in create_connection
    raise err
  File "/usr/local/lib/python3.6/site-packages/urllib3/util/connection.py", line 86, in create_connection
    sock.connect(sa)
ConnectionRefusedError: [Errno 111] Connection refused
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
  File "/usr/local/lib/python3.6/site-packages/urllib3/connectionpool.py", line 706, in urlopen
    chunked=chunked,
  File "/usr/local/lib/python3.6/site-packages/urllib3/connectionpool.py", line 394, in _make_request
    conn.request(method, url, **httplib_request_kw)
  File "/usr/local/lib/python3.6/site-packages/urllib3/connection.py", line 234, in request
    super(HTTPConnection, self).request(method, url, body=body, headers=headers)
  File "/usr/local/lib/python3.6/http/client.py", line 1287, in request
    self._send_request(method, url, body, headers, encode_chunked)
  File "/usr/local/lib/python3.6/http/client.py", line 1333, in _send_request
    self.endheaders(body, encode_chunked=encode_chunked)
  File "/usr/local/lib/python3.6/http/client.py", line 1282, in endheaders
    self._send_output(message_body, encode_chunked=encode_chunked)
 File "/usr/local/lib/python3.6/http/client.py", line 1042, in _send_output
    self.send(msg)
  File "/usr/local/lib/python3.6/http/client.py", line 980, in send
    self.connect()
  File "/usr/local/lib/python3.6/site-packages/urllib3/connection.py", line 200, in connect
    conn = self._new_conn()
  File "/usr/local/lib/python3.6/site-packages/urllib3/connection.py", line 182, in _new_conn
    self, "Failed to establish a new connection: %s" % e
urllib3.exceptions.NewConnectionError: <urllib3.connection.HTTPConnection object at 0x7fb3be7bca58>: Failed to establish a new connection: [Errno 111] Connection refused

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/root/main.py", line 55, in <module>
    sharedQue = SimpleQueue()
  File "/usr/local/lib/python3.6/site-packages/fiber/queues.py", line 295, in __init__
    backend = get_backend()
  File "/usr/local/lib/python3.6/site-packages/fiber/backend.py", line 74, in get_backend
    name)).Backend(**kwargs)
  File "/usr/local/lib/python3.6/site-packages/fiber/kubernetes_backend.py", line 64, in __init__
    self.default_namespace)
  File "/usr/local/lib/python3.6/site-packages/kubernetes/client/api/core_v1_api.py", line 22785, in read_namespaced_pod
    return self.read_namespaced_pod_with_http_info(name, namespace, **kwargs)  # noqa: E501
  File "/usr/local/lib/python3.6/site-packages/kubernetes/client/api/core_v1_api.py", line 22894, in read_namespaced_pod_with_http_info
    collection_formats=collection_formats)
  File "/usr/local/lib/python3.6/site-packages/kubernetes/client/api_client.py", line 353, in call_api
    _preload_content, _request_timeout, _host)
  File "/usr/local/lib/python3.6/site-packages/kubernetes/client/api_client.py", line 184, in __call_api
    _request_timeout=_request_timeout)
  File "/usr/local/lib/python3.6/site-packages/kubernetes/client/api_client.py", line 377, in request
    headers=headers)
File "/usr/local/lib/python3.6/site-packages/kubernetes/client/rest.py", line 243, in GET
    query_params=query_params)
  File "/usr/local/lib/python3.6/site-packages/kubernetes/client/rest.py", line 216, in request
    headers=headers)
  File "/usr/local/lib/python3.6/site-packages/urllib3/request.py", line 75, in request
    method, url, fields=fields, headers=headers, **urlopen_kw
  File "/usr/local/lib/python3.6/site-packages/urllib3/request.py", line 96, in request_encode_url
    return self.urlopen(method, url, **extra_kw)
  File "/usr/local/lib/python3.6/site-packages/urllib3/poolmanager.py", line 375, in urlopen
    response = conn.urlopen(method, u.request_uri, **kw)
  File "/usr/local/lib/python3.6/site-packages/urllib3/connectionpool.py", line 796, in urlopen
    **response_kw
  File "/usr/local/lib/python3.6/site-packages/urllib3/connectionpool.py", line 796, in urlopen
    **response_kw
  File "/usr/local/lib/python3.6/site-packages/urllib3/connectionpool.py", line 796, in urlopen
    **response_kw
  File "/usr/local/lib/python3.6/site-packages/urllib3/connectionpool.py", line 756, in urlopen
    method, url, error=e, _pool=self, _stacktrace=sys.exc_info()[2]
  File "/usr/local/lib/python3.6/site-packages/urllib3/util/retry.py", line 573, in increment
    raise MaxRetryError(_pool, url, error or ResponseError(cause))
urllib3.exceptions.MaxRetryError: HTTPConnectionPool(host='localhost', port=80): Max retries exceeded with url: /api/v1/namespaces/default/pods/test1-797b9fdffb-jz225 (Caused by NewConnectionError('<urllib3.connection.HTTPConnection object at 0x7fb3be7bca58>: Failed to establish a new connection: [Errno 111] Connection refused',))

Also I was getting POST method not supported (501) error when trying to run with fiber cli. It also fails. Don't know whether it's a bug.

Could you try pip install kubernetes==10.0.1 when building your Docker image? It seems that newer version of kubernetes python client doesn't work with Fiber. For the Fiber CLI issue, can you open another Github issue with detailed logs so that we can track it over there?

Thanks a lot man. It is finally working now. However it's worth mentioning in readme that this is the case.


UnhandledPromiseRejectionWarning: ArangoError: AQL: collection or view not found: name: /recall_skeleton_vertices (while parsing)

Whilst running the db-setup step after setting up ArangoDB and Recall I am seeing this error pop up.
Truncated compound_events.
(node:1275074) UnhandledPromiseRejectionWarning: ArangoError: AQL: collection or view not found: name: /recall_skeleton_vertices (while parsing)
    at new ArangoError (/home/pecastro/projects/hivemind/node_modules/arangojs/build/error.js:115:21)
    at Object.resolve (/home/pecastro/projects/hivemind/node_modules/arangojs/build/connection.js:369:32)
    at callback (/home/pecastro/projects/hivemind/node_modules/arangojs/build/connection.js:191:26)
    at IncomingMessage.<anonymous> (/home/pecastro/projects/hivemind/node_modules/arangojs/build/lib/request.node.js:108:21)
    at IncomingMessage.emit (events.js:388:22)
    at endReadableNT (internal/streams/readable.js:1336:12)
    at processTicksAndRejections (internal/process/task_queues.js:82:21)
    at emitUnhandledRejectionWarning (internal/process/promises.js:168:15)
    at processPromiseRejections (internal/process/promises.js:247:11)
    at processTicksAndRejections (internal/process/task_queues.js:96:32)
(node:1275074) ArangoError: AQL: collection or view not found: name: /recall_skeleton_vertices (while parsing)
    at new ArangoError (/home/pecastro/projects/hivemind/node_modules/arangojs/build/error.js:115:21)
    at Object.resolve (/home/pecastro/projects/hivemind/node_modules/arangojs/build/connection.js:369:32)
    at callback (/home/pecastro/projects/hivemind/node_modules/arangojs/build/connection.js:191:26)
    at IncomingMessage.<anonymous> (/home/pecastro/projects/hivemind/node_modules/arangojs/build/lib/request.node.js:108:21)
    at IncomingMessage.emit (events.js:388:22)
    at endReadableNT (internal/streams/readable.js:1336:12)
    at processTicksAndRejections (internal/process/task_queues.js:82:21)
(node:1275074) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.
    at emitDeprecationWarning (internal/process/promises.js:180:11)
    at processPromiseRejections (internal/process/promises.js:249:13)
    at processTicksAndRejections (internal/process/task_queues.js:96:32)

Probably the ARANGO_SVC_MOUNT_POINT value in .env.local has a leading slash. If this is so, please remove it and try. It should look like:
ARANGO_SVC_MOUNT_POINT=recall

That solved it.


Feature: job environment variables support linux

Supersedes #345
Closes #322

Codecov Report
Attention: Patch coverage is 78.28571% with 38 lines in your changes are missing coverage. Please review.

Project coverage is 68.40%. Comparing base (f01ff91) to head (944967c).

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #435      +/-   ##
==========================================
- Coverage   70.04%   68.40%   -1.65%
==========================================
  Files          44       45       +1
  Lines        2474     2633     +159
  Branches      526      566      +40
==========================================
+ Hits         1733     1801      +68
- Misses        573      653      +80
- Partials      168      179      +11

Flag
Coverage Δ

unittests
68.09% <77.14%> (-1.39%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Files
Coverage Δ

...loyment_toolbelt/jobs/job_environment_variables.py
78.43% <63.15%> (-2.82%)
:arrow_down:

qgis_deployment_toolbelt/utils/linux_utils.py
80.12% <80.12%> (ø)

... and 7 files with indirect coverage changes


[Help] Different cookies in parallel

Is there a way to send 2 requests to the same url in parallel, but on one request a cookie is set to "Cookie: user=1" and on the 2nd request it's set to "Cookie: user=2" for example?
Thanks!

Sure, just
$request1->getOptions()->set(CURLOPT_COOKIE, 'user=1');
$request2->getOptions()->set(CURLOPT_COOKIE, 'user=2);

then attach requests to queue with
$queue->attach($request1);
$queue->attach($request2);


Correctly detect empty messages

This PR fixes a bug in RMW_Connext_MessageTypeSupport::type_info() which prevents correct detection of empty messages when querying the fastrtps type support.
No test is currently failing because of this (AFAIK), but it seems a critical fix to properly support empty messages.
This bug was spotted by @MiguelCompany and it is already fixed in #14, but since that PR might be delayed to H-turtle, we should probably commit the fix separately.

Full CI:

ci_linux:
ci_osx:
ci_windows:

@hidmic @ivanpauno thank you for the reviews! Is it ok if I merge the PR myself or should I let someone else do it?

@hidmic @ivanpauno thank you for the reviews! Is it ok if I merge the PR myself or should I let someone else do it?

If it's approved (two approvals during the galactic freeze) and there was no comment saying it should be merged after the galactic freeze finishes, you can merge it yourself.


Check cfg during CI and fix feature typos

Objective

Add the new -Zcheck-cfg checks to catch more warnings
Fixes #12091

Solution

Create a new cfg-check to the CI that runs cargo check -Zcheck-cfg --workspace using cargo nightly (and fails if there are warnings)
Fix all warnings generated by the new check

Changelog

Remove all redundant imports
Fix cfg wasm32 targets
Add 3 dead code exceptions (should StandardColor be unused?)
Convert ios_simulator to a feature (I'm not sure if this is the right way to do it, but the check complained before)

Migration Guide
No breaking changes

Wow, this is an incredibly useful check. There are some nasty subtle bugs in there.