Add additional publication fields for serials

For https://github.com/wellcomecollection/platform/issues/5600
This is a vanilla transformation.
I've deliberately avoided any "clever" logic e.g. removing Former frequency: as a prefix from strings in 362, because it affects a relatively small number of records, and it's the sort of thing which would be better to fix in the source data.

I held off merging this before the break so I didn't deploy anything breaking; I'm going to merge this now and reindex so these fields are populated in the API.


Q: how can I share a directory in an OS X host to mount as a Docker volume?

The folder sharing instructions in the README.md suggest a "sharing outwards" approach: the files are in a Docker volume running a server, and the host connects to the server to access the files.
Is it possible to have this work in the opposite direction? In my use case, my Git credentials and code tools are all installed in the OS X host, as well as the projects I am working on. But I want to execute these projects in Docker containers via boot2docker. Is there a convenient way I can share host directories with boot2docker so that Docker can mount them as volumes?
For my development feedback loop, I don't want to have to rebuild Docker images every time I save a file. And it would be terrific if services running in containers (e.g. Jekyll, grunt-watch, etc) could be notified of file changes in the usual way.
Vagrant uses VirtualBox functionality to share a host folder with the guest VM. What I'm wondering about is that step between the guest VM and containers in the guest VM.

i'm facing very slow performance with symfony app with boot2docker due to vboxsf any idea if a solution exists to have a boot2docker with NFS or something?

Take a look at Hodor - https://github.com/gansbrest/hodor where we use Unison with monitoring for reliable and fast syncing.

You can build your iso with NFS or Samba, but it still be very slow with lot's of small files, trust me here. If you will decide to go this road I would advice against changing boot2docker.iso but running separate containers on top of it, so you can always use latest .iso version.

In performance side, what's the difference between a Samba server dockerized and a NFS boot2docker image?

NFS should work a bit faster especially on local interface. But it still
will be slow for reliable use for a big project with lots of files if you
will want to run some kind of files watcher on top of it (like nodemon). My
advice - don't do it, run away if you can. Or try Hodor.
On Jan 9, 2015 9:21 AM, "Simon Paitrault"<EMAIL_ADDRESS>wrote:

In performance side, what's the difference between a Samba server
dockerized and a NFS boot2docker image?
—
Reply to this email directly or view it on GitHub
https://github.com/boot2docker/boot2docker/issues/413#issuecomment-69339390
.

Incidentally, the performance is amazingly variable. I have boot2docker set up on my MBP for dev work, and running our unit test suite varies between taking 6 to 8 minutes and taking 50 to 80 minutes. I have absolutely no insight into what the variability is caused by, and it is giving me absolute fits. If I copy all the files into the docker container, the tests take 5 minutes or so to run.

+1 for file change events. I'm in a situation that sounds identical to @james-nesbitt in development. Works fine for me in Ubuntu, but I'm hoping to use boot2docker for the mac folks on my team, and one of the hopes would be that this alleviates the need for their build tools to poll.

For folks still struggling with the performance of mounted folders and vboxsf, I put together a small open source project called docker-osx-dev that uses Vagrant + Docker + Rsync, and I'm seeing build performance with mounted folders that is on par with native performance and file watchers work correctly as well, without any need for polling. See A productive development environment with Docker on OS X for more info.

+1 for docker-osx-dev, using it so far and it is fast and using a lot less CPU

Similar to @brikis98 docker-osx-dev, using Vagrant to simplify the setup a bit: https://github.com/yeti-support/docker-development-helper


created a calculator to find Place and Face Value of digit

Issue Id you have worked upon -
#199
Briefly explain your program logic -
Face value is the actual value of the digit whereas place value is the position of a digit in a number. For example, the face value of 5 in 5432 is 5 whereas the place value of 5 is 5000 (five-thousands).
Screenshots(Attach 2 screenshots of your own input and output) -

By raising this PR I affirm that -

[x] My code follows the guidelines of this project.

[x] I have performed a self-review of my own code.

[x] I have commented my code.

[x] My code gives the correct output.

[x] I affirm that I strictly follow contributing guidelines and code of conduct.

Congratulations 🎉 @DanishGBU on your contribution.
Thanks for adding value to this repository. 😊
Let's celebrate this fest 😃 by providing more developers 👨💻👩💻 an opportunity to contribute. Help us make this repository reach far and more by sharing this to your friends and colleagues.
Your efforts can make difference.

Hey 👋, may you also encourage us by clicking the star icon on the repository main page. ⭐


termination on ctrl + break

I'm working on an application that launches powershell scripts (using powershell core) to setup and launch processes.
When I create the powershell process I set CREATE_NEW_PROCESS_GROUP which implicitly calls SetConsoleCtrlHandler(NULL,TRUE) which effectively turns off ctrl+c for the created process and its children. So when stopping my launched powershell processes, I call GenerateConsoleCtrlEvent and send the powershell's process group a ctrl+break. While this effectively closes child processes of the powershell process, it puts the powershell process into debug mode which is undesirable.
I have tried 2 strategies to work around this both fail in different ways:

In the powershell process I launch, I call SetConsoleCtrlHandler(NULL,FALSE) to turn ctrl+c back on and have my application generate ctrl+c events. This works perfectly the first time. However, oddly, the parent console now no longer seems to propogate ctrl+c to child processes. For example, if I run my app and start some ps processes and succesfully stop them with ctrl+c events and then terminate my app and THEN run ping <IP_ADDRESS> -t, ctrl+c does nothing.

I register a new handler to capture BREAK events in the powershell process in hopes this will override the powershell behavior that enters debug mode. However, when this handler is called, even if I have it do absolutely nothing, via a ctrl+break signal, an access violation is thrown in the powershell process.

Is there a clean way to disable the debug behavior invoked from ctrl+break or is there any thoughts why ctrl+c signals do not get propogated if I turn that handler on?

I've done a bit more troubleshooting and research here.
I have nailed down why the first workaround above is failing. Watching process explorer while my ctrl+c was being swallowed, I found that conhost had some orphaned handles and closing those handles via process explorer magically "woke up" ctrl+c. Why those handles are not being closed is a mystery but I also discovered that firing GenerateConsoleCtrlEvent after a user invoked ctrl+c is what puts things into this state. Of course if a user enters ctrl+c, the signal is sent to all processes in the console so the call to GenerateConsoleCtrlEvent that my application makes directed to a specific process group is unnecesary. I can't find any documentation verifying this but it certainly appears to be the case.
Ideally, I'd still be able to send a ctrl+break to powershell's process group because that would save me from messing with SetConsoleCtrlHandler and altering powershell's ctrl+c handler state. I could override powershell's ConsoleControl.BreakHandler but I cant access the internal SpinUpBreakHandlerThread which is the default ctrl+c behavior and what I ideally want.
Would the powershell maintainers be open to a PR that performs "ctrl+c - like " behavior on ctrl + break IF $host.DebuggerEnabled is $false or if powershell is in -NonInteractive mode?

The Ctrl+Break -> drop into debugger function was added to make Ctrl+Break more useful with interactive sessions.  So I am fine to revert back to the original the stop-process behavior for non-interactive modes or if the debugger is disabled.

@mwrock the change your proposing seems reasonable to me

Great! BTW: I can totally see how the debugger functionality is an awesome feature for interactive scripts.. I'll get a PR in soon for the non interactive experience.

The design to break into the debugger is especially useful when a script is taking much longer than expected, and you typically have not turned on debugging in such situations.


Testcafe stops/freezes with nativeAutomation true

What is your Scenario?
I use testcafe to test an angular app, and when I use nativeAutomation the browser connection (chrome/edge) seems lost after I use the navigateTo the second time (does not have to be the same url, just another url from our app), as even if the page is loaded it and it's not frozen, testcafe does not get the handle of it somehow.
When this happens, the next script step after navigation is not executed, so everything just stops, and in some cases, if you wait a long time, a java heap memory error is thrown – but this is caused by testcafe looping after.
In my case, the workaround is to just to disable native automation.
I cannot provide a test url/app and I also tried to reproduce it with the testcafe demo page, but I could not.
Instead I was able to get a debug log using the provided steps. (It is attached below)
testcafeDebug.log
What is the Current behavior?
test run just hangs
What is the Expected behavior?
no hanging
What is the public URL of the test page? (attach your complete example)
internal angular app
What is your TestCafe test code?
test.only('nav test', async t => {
const testcafeURL = 'https://devexpress.github.io/testcafe/example/'
const myURL = https://myurl:8443/sfc' // anonymized
const waitTime = 2500
let currentURL
currentURL = testcafeURL
console.log(#1 loading page > ${currentURL})
await t.navigateTo(currentURL)
await t.wait(waitTime)
console.log(accessed : ${currentURL})
console.log(await Selector('body').textContent)
console.log('next page >')
console.log()
console.log(#2 loading page > ${currentURL})
await t.navigateTo(currentURL)
await t.wait(waitTime)
console.log(accessed : ${currentURL})
console.log(await Selector('body').textContent)
console.log('next page >')
console.log()
currentURL = myURL
console.log(#1 loading page > ${currentURL})
await t.navigateTo(currentURL)
await t.wait(waitTime)
console.log(accessed : ${currentURL})
console.log(await Selector('body').textContent)
console.log('next page >')
console.log()
console.log(#2 loading page > ${currentURL})
await t.navigateTo(currentURL) // < page is loaded correctly but then it just gets stuck, next steps are no longer executed
await t.wait(waitTime)
console.log(accessed : ${currentURL})
console.log(await Selector('body').textContent)
console.log('next page >')
console.log()
});
Your complete configuration file
function isWarning(text, warnings) { // identify warnings
const warningHeadingRegexp = /Warnings ((\d)):/;
const warningSplitRegexp   = /--/;
const whiteSpaceRegexp     = /\s/g;
if (warningHeadingRegexp.test(text) || warningSplitRegexp.test(text))
return true;
return warnings.some(msg => msg.replace(whiteSpaceRegexp, '') === text.replace(whiteSpaceRegexp, ''));
}
function hideWarningsHook(writeInfo) { // hide warnings
if (writeInfo.initiator === 'reportWarnings')
writeInfo.formattedText = '';
if (writeInfo.initiator === 'reportTaskDone') {
const warnings = writeInfo.data.warnings || [];
if (!warnings.length)
return;
if (isWarning(writeInfo.formattedText, warnings))
writeInfo.formattedText = '';
};
}
function msToTime(duration) { // calculate mins and s
var seconds = Math.floor((duration / 1000) % 60);
var minutes = Math.floor((duration / (1000 * 60)) % 60);
return (minutes == 0) ? seconds + "s" : minutes + "m " + seconds + "s";
}
function appendTestDurationHook(writeInfo) { // add TC duration info
if (writeInfo.initiator === 'reportTestDone') {
const { name, testRunInfo, meta } = writeInfo.data || {};
const testDurationMs = testRunInfo.durationMs;
const testDurationMins = msToTime(testDurationMs)
writeInfo.formattedText = writeInfo.formattedText + ' (' + testDurationMins + ')';
};
}
function triggerAdjustReportOutputHook(writeInfo) {
hideWarningsHook(writeInfo); // trigger to remove warnings from the 'spec' report output
appendTestDurationHook(writeInfo); // trigger to add TC duration info
}
module.exports = {
"skipJsErrors": true,
"screenshots": {
"pathPattern": "fails/${DATE}/${TEST}/${USERAGENT}${TIME}${QUARANTINE_ATTEMPT}.png",
"takeOnFails": true,
"thumbnails": false
},
"videoPath": "fails/videos",
"videoOptions": {
"failedOnly": true,
"singleFile": true,
"pathPattern": "${DATE}/${USERAGENT}${TIME}${FILE_INDEX}.mp4"
},
"videoEncodingOptions": {
"r": 20,
"aspect": "4:3"
},
hooks: {
reporter: {
onBeforeWrite: {
'spec': triggerAdjustReportOutputHook, // trigger to adjust 'spec' report output
},
},
},
}
Your complete test report
debug log available from edge (also anonymized), as chrome runs are not possible currently for us due to the chrome 130 issue with testcafe
Screenshots
No response
Steps to Reproduce
in our case using the navigateTo function the second time in the same TC
TestCafe version
3.6.2 [or any version above 3.3.0 as for me nativeAutomation worked on this version]
Node.js version
20.15.0
Command-line arguments
npx testcafe edge myScript.js
Browser name(s) and version(s)
edge 130
Platform(s) and version(s)
win 10 pro
Other
No response

Hello,
We have released testcafe 3.7.0-rc.1, which addresses this issue.
I will close this issue as a duplicate of https://github.com/DevExpress/testcafe/issues/8300.
However, you may face a new issue described here: https://github.com/DevExpress/testcafe/issues/8308
Please take a look and let us know your results.

Hello, my issue is also reproducible with testcafe 3.7.0, and also reproducible with both edge (130) and chrome (130). So i don't think it should be closed since its a different problem.

Hello,
We have released testcafe 3.7.0-rc.2, which might address this issue.
Please take a look and let us know your results.


Access control on the Java APIs that can be used in MVEL script.

I went through the script execution flow and couldn't find a way to have access control on the java classes that can be accessed from the script.
So provided an ClassAccessHandler interface and implemented a defaultClassAccessHandler which has the default behaviour. Otherwise, users can have a custom implementation of the interface and register it to ClassAccessHandlerFactory to have their own access controls.
For example please refer to RestrictedClassAccessTestHandler.java
Would also like to block "this" keyword in the script based on a property. Will update the PR.

@mariofusco @mikebrock please review the pull request and help me in releasing the latest jar to maven.

Sorry, but I honestly don't see the usefulness of this or better I don't see why you couldn't use the same effect using the native Java AccessController. See for instance how this has been done in drools https://github.com/kiegroup/drools/blob/master/drools-core/src/main/java/org/drools/core/util/SafeMVELEvaluator.java#L31


Added js import to sample code.

This import is required for the sample code to pass the analyzer, otherwise you'll get an error on the first line.
[error] Annotation can be only constant variable or constant constructor invocation

@jacob314 can you review, please?

@jacob314 any update on this?


remember_device not account specific

Looking at https://github.com/authy/authy-devise/blob/f3fd125f1b8c9539a1a700d3198628cf4fe332cd/lib/devise-authy/controllers/helpers.rb#L12, the remember_device cookie has no link to the current account. This makes it trivial for any attacker to bypass two-factor authentication for a compromised account, rendering authy useless:

Attacker logs into their account with their username and password and two-factor authentication (this will give the attacker a valid remember_device cookie)
Attacker logs out
Attacker logs in to compromised account. Since the cookie is still set, require_token? will return false

I can confirm that this method works using the standard cookie.

Opened a PR to get this issue fixed as quickly as possible


[Snyk] Upgrade io.grpc:grpc-protobuf from 1.47.0 to 1.49.2

This PR was automatically created by Snyk using the credentials of a real user.Snyk has created this PR to upgrade io.grpc:grpc-protobuf from 1.47.0 to 1.49.2.
:information_source: Keep your dependencies up-to-date. This makes it easier to fix existing vulnerabilities and to more quickly identify and fix newly disclosed vulnerabilities when they affect your project.

The recommended version is 6 versions ahead of your current version.
The recommended version was released a month ago, on 2022-10-01.

The recommended version fixes:

Severity
Issue
PriorityScore (*)
Exploit Maturity

Denial of Service (DoS) SNYK-JAVA-COMGOOGLEPROTOBUF-3040284
571/1000  Why? Recently disclosed, Has a fix available, CVSS 5.7
No Known Exploit

(*) Note that the real score may have changed since the PR was raised.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open upgrade PRs.
For more information:
🧐 View latest project report
🛠 Adjust upgrade PR settings
🔕 Ignore this dependency or unsubscribe from future upgrade PRs

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Merge SPA archetype into general archetype

Description

This PR merges the content of the AEM SPA Project Archetype into this more general archetype.
This archetype already supports the generation of frontend projects (see the optionIncludeFrontendModule option and the ui.frontend directory). The SPA project generation is implemented in a consistent way:

The optionIncludeFrontendModule option is renamed to optionFrontendModule and is converted from a boolean to a parameter with the following options: ["none", "general", "angular", "react"].
The archetype now contains separate directories for the three types of frontend projects: ui.frontend.general (the current ui.frontend module), ui.frontend.angular and ui.frontend.react (the two new SPA modules). When generating a project, depending on the value of optionFrontendModule, the corresponding subdirectory is renamed to ui.frontend and the others are deleted. If the option is set to none, all frontend directories are removed. This process happens in the archetype-post-generate.groovy script.

Due to some differences in how non-SPA and SPA projects work with AEM, this PR has to introduce several if/else statements in pom.xml and .content.xml files:

The com.adobe.aem:spa.project.core dependency is required in SPA projects (it contains the implementation of the hierarchy page), but not in other projects.
SPA projects require an additional spa component.
SPA projects currently use different templates (spa-app-template and spa-page-template). It might be a good idea to combine these templates in a future PR to get a cleaner file structure and reduce the number of conditional statements.
SPA projects contain an additional home directory in the content folder. This is required due to AEM's differentiation of apps and pages in the context of SPAs. In a follow-up PR, we could add a rewrite rule that maps /content/${appsFolderName}/us/en.html to the /content/${appsFolderName}/us/en/home.html path (for consistency with non-SPA projects).

Finally, generating an SPA project requires that users are running at least AEM 6.4.7, which is a higher requirement than for non-SPA projects.
Please note that v1.0.6 of com.adobe.aem:spa.project.core is not yet released publicly, this should happen in the coming days.
Related Issue

GitHub: Closes #282
JIRA: CQ-4283742 (blocked by INFRA-5793)

Motivation and Context

This merge should reduce the maintenance effort because the SPA Archetype no longer needs to be manually kept in sync with changes in the Project Archetype. It also simplifies the generation process for users, allowing them to generate different project types from a single archetype.
See #282 for more details.
How Has This Been Tested?

I've extended the integration tests to generate projects with each of the possible optionFrontendModule values.
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[x] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] I have signed the Adobe Open Source CLA.
[x] My code follows the code style of this project.
[x] My change requires a change to the documentation.
[x] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[x] I have added tests to cover my changes.
[x] All new and existing tests passed.

@samuelmeuli - I love this PR! However, I have one major concern about this flag
optionFrontendModule        |   none  | Include a dedicated frontend module (one of `none`, `general`, `angular`, `react`)

My concern here is that on most of the projects standup/maintain we are not using a full SPA approach. We leverage Angular/React only for a small subset of components. The rest of the components are traditional AEM ones. If the flag only allows for one module to be installed then that would mean we would have nothing to leverage if we standup up an instance using either the Angular or React modules. All AEM components at that point would have to be vanilla AEM clientlibs. That would negate what the general module was originally created for.
I can easily see 80%+ of my new projects right now needing a combination of general/angular or general/react. Can we make it so that it is possible to include multiple modules. I don't see why anyone would use React and Angular together, so I will defer to others on whether that should even be a valid use case. Though, I definitely see combining general with one of the others.
@godanny86

@jbmatheson I agree that projects will likely never combine angular and react.  I can see your point that some projects may combine both angular/react and the general ui.frontend module if they were to deploy both a SPA Editor and Traditional based website. However, there is also a balance of how complex the archetype gets.
@samuelmeuli I'm thinking at a minimum it is better to name the client libraries based on the option:
general -> clientlib-site
angular -> clientlib-angular
react -> clientlib-react
This way if a project wants to manually add an additional frontend module later i.e combine angular+general it will be clear which client library is responsible..

@godanny86 Agreed, this makes the code more readable and maintainable. I've updated the PR.

Thanks, @bpauli!


Openzwave 1.6 support?

Hi, thanks again for this library. It works well for my purposes and I'd love to share the MQTT binding if you're interested.
It looks like openzwave 1.6 is out and devices for 1.4 are no longer updated (https://github.com/OpenZWave/open-zwave/wiki/OpenZWave-1.6-Release-Notes). I tried it but ran into some errors like homeId being 0.
Do you have any plans on supporting 1.6?
Cheers
Henk

Hi Henk, sorry for the late reply, I've been working away for a little while.
Thanks for letting my know about v1.6! From what the v1.6 release notes state it looks like the transition will be quite a hefty one! I will definitely look to support this in the future, but not sure when I will be able to spend time on this yet.
From a quick glance at the release notes.. things to do:

Support 16-bit ValueIDs
Handle exceptions
Handle BitSet values
and probably more...

If you'd be willing to share your MQTT binding that would be great. I should also share my Go project that uses this package (will try to do this soon).

No worries James, glad you're still (a little) active :)
The MyZone project with the OpenZwave binding is on gitlab. Do you have an account I can share the repo with?  (I'm not partial to either github or gitlab btw)


Promise rejection logs two error messages in the console

What is the reason for logging two error messages in the console when a promise is rejected?
Can it be merged together to avoid cluttering the console?

@jahtalab, sure, it should only logging one message, I will check it.

@JiaLiPassion ,
This is the piece of code that does the logging:
https://github.com/angular/zone.js/blob/master/lib/common/promise.ts#L21
  api.onUnhandledError = (e: any) => {
    if (api.showUncaughtError()) {
      const rejection = e && e.rejection;
      if (rejection) {
        console.error(
            'Unhandled Promise rejection:',
            rejection instanceof Error ? rejection.message : rejection, '; Zone:',
            (<Zone>e.zone).name, '; Task:', e.task && (<Task>e.task).source, '; Value:', rejection,
            rejection instanceof Error ? rejection.stack : undefined);
      }
      console.error(e);
    }
  };

I'm guessing that the first console.error is for debugging of zone.js, is that right? Does it have another purpose?

@jahtalab , it is not a debug code, the first console.error will print the detail information about the real error, if rejection not exists, wi print error itself, so it should be if/else. I will fix it. Thanks!

@JiaLiPassion ,
It seems to me logging zone.name and task are only relevant if the user knows about zone.js library (why I thought it's useful for debugging).
I think in this case it should behave like the native Promise.reject and not to log zone.name and 'task'

@jahtalab , yes, I understand your meaning, I am not sure which is the better solution, output zone.name and task information will help to debug why unhandled promise rejection exists.
there are way to not output the console.log or even output your own format.

this will disable the output.

// after load zone.js
Zone[Zone.__symbol__['ignoreConsoleErrorUncaughtError']] = true;

add unhandledPromiseRejectionHandler in window, or handleUnhandledPromiseRejection in node to handle unhandled promise error

load your own patch

Zone.__load_patch('ownUncaughtPromiseRejection', (global, Zone, api) => {
  api.onUnhandledError = (e) => {
    // format the error as you will
  }
});

so because we have several ways to let app define how to handle unhandle promise rejection, so I think by default print out zone.name and task is acceptable.
And I am not sure about the native promise behavior, now ZoneAwarePromise pass PromiseA+ test, so Promise A+ spec doesnot seem to define what to do when unhandle promise rejection occurs.

@JiaLiPassion
The code to disable it should be: (At least with Angular 5, it may have been correct before)
Zone[Zone.__symbol__('ignoreConsoleErrorUncaughtError')] = true;

@Cyral , thank you, my typo


Update pronoun in article title to match TOC

Based on guideline https://styleguides.azurewebsites.net/Styleguide/Read?id=2700&topicid=29021
Closes #172

Thanks Brad. I was aware of the impact of changing article filenames but not headers. I will go with your suggestion then.


Redeploying existing app on a new OpenAI resource

This issue is for a: (mark with an x)

[ ] bug report -> please search issues before submitting
[ ] feature request
[X] documentation issue or request
[ ] regression (a behavior that used to work and stopped in a new release)

I have a received a quota increase in a OpenAI location (North Central US) different from the one where I deployed my app in (CanadaEast). The deployment works very well and I've put a lot of time in the frontend, uploading a high volume of docs, as well as fine-tuning the indexes and the prompts for my specific needs and it works really well.
Is there a smooth way of making this transition to take advantage of the increased quotas? I'm new to this and don't want to risk breaking what I already have.
My initial thought was to delete the OpenAI resource from the portal, then run azd up and create a new one in the new location when prompted. Any guidance would be helpful.

Can you follow these steps? https://github.com/Azure-Samples/azure-search-openai-demo#existing-openai-resource


WIP chore(azure): fix property conflict for redis

Description

The default property seems to be publicNetworkAccess: 'Disabled', not possible to both configure private link and disable public network access at the same time it seems. Encountered this issue: https://github.com/Azure/azure-cli/issues/20997
Also, seems like we need to actually create the private DNS Zone manually, although the documentation states otherwise. Other sources say that if we use Bicep for this, we need to create it manually :)
Ran the Bicep manually from local machine, seems to update just fine.
Related Issue(s)

#{issue number}

Verification

[ ] Your code builds clean without any errors or warnings
[ ] Manual testing done (required)
[ ] Relevant automated test added (if you find this hard, leave it and we'll help out)

Documentation

[ ] Documentation is updated (either in docs-directory, Altinnpedia or a separate linked PR in altinn-studio-docs., if applicable)

Waiting for a manual test using a VM before merging this


weird FastTypeTag errors started recently

unexpected FAILED: nyaya
	scala.MatchError: FastTypeTag[sbt.CrossVersion] (of class scala.pickling.FastTypeTag$$anon$2)
unexpected FAILED: ssl-config
	[ssl-config] scala.MatchError: FastTypeTag[sbt.CrossVersion] (of class scala.pickling.FastTypeTag$$anon$2)

@eed3si9n @cunei does the error message give you any immediate insight into what might be going on here? I would have to isolate whether it started with the sbt 1.2.6 upgrade, or the dbuild 0.9.16 upgrade, or what. I could also try to figure out what's special about these two projects.
I have now seen this both on MacOS (my laptop) and Linux (Jenkins), on these two projects in particular.
don't go digging yet, for now I just want to know whether the error message alone rings any bells.

The dbuild 0.9.16 upgrade may not be the cause: the change with respect to 0.9.15 is quite modest. It adds one additional dependency, but it is a simple java library that has no other dependencies, so unlikely to have this effect.

I don't know but maybe 0e619c1c2de97803b5bc5b8549ecf8a57e97a36c will help

a full stack trace:
[ssl-config] scala.MatchError: FastTypeTag[sbt.CrossVersion] (of class scala.pickling.FastTypeTag$$anon$2)
[ssl-config] 	at sbt.CrossVersion$$anon$2.unpickle(CrossVersion.scala:67)
[ssl-config] 	at sbt.ModuleID$SbtModuleIDPicklerUnpickler1$2$.unpickle(ModuleID.scala:167)
[ssl-config] 	at sbt.ModuleReport$SbtModuleReportPicklerUnpickler1$2$.unpickle(UpdateReport.scala:168)
[ssl-config] 	at scala.pickling.Unpickler$class.unpickleEntry(Pickler.scala:79)
[ssl-config] 	at sbt.ModuleReport$SbtModuleReportPicklerUnpickler1$2$.unpickleEntry(UpdateReport.scala:168)
[ssl-config] 	at sbt.serialization.pickler.TravPickler$$anon$1.unpickle(Traversable.scala:89)
[ssl-config] 	at sbt.OrganizationArtifactReport$SbtOrganizationArtifactReportPicklerUnpickler1$2$.unpickle(UpdateReport.scala:71)
[ssl-config] 	at scala.pickling.Unpickler$class.unpickleEntry(Pickler.scala:79)
[ssl-config] 	at sbt.OrganizationArtifactReport$SbtOrganizationArtifactReportPicklerUnpickler1$2$.unpickleEntry(UpdateReport.scala:71)
[ssl-config] 	at sbt.serialization.pickler.TravPickler$$anon$1.unpickle(Traversable.scala:89)
[ssl-config] 	at sbt.ConfigurationReportLite$SbtConfigurationReportLitePicklerUnpickler1$2$.unpickle(JsonUtil.scala:87)
[ssl-config] 	at scala.pickling.Unpickler$class.unpickleEntry(Pickler.scala:79)
[ssl-config] 	at sbt.ConfigurationReportLite$SbtConfigurationReportLitePicklerUnpickler1$2$.unpickleEntry(JsonUtil.scala:87)
[ssl-config] 	at sbt.serialization.pickler.TravPickler$$anon$1.unpickle(Traversable.scala:89)
[ssl-config] 	at sbt.UpdateReportLite$SbtUpdateReportLitePicklerUnpickler1$2$.unpickle(JsonUtil.scala:82)
[ssl-config] 	at scala.pickling.Unpickler$class.unpickleEntry(Pickler.scala:79)
[ssl-config] 	at sbt.UpdateReportLite$SbtUpdateReportLitePicklerUnpickler1$2$.unpickleEntry(JsonUtil.scala:82)
[ssl-config] 	at scala.pickling.functions$.unpickle(functions.scala:11)
[ssl-config] 	at sbt.serialization.JsonValue$$anonfun$parse$1.apply(SerializedValue.scala:108)
[ssl-config] 	at scala.util.Try$.apply(Try.scala:161)
[ssl-config] 	at sbt.serialization.JsonValue.parse(SerializedValue.scala:108)
[ssl-config] 	at sbt.serialization.SerializationFunctions$class.fromJsonFile(SerializationFunctions.scala:18)
[ssl-config] 	at sbt.serialization.package$.fromJsonFile(package.scala:9)
[ssl-config] 	at sbt.JsonUtil$.parseUpdateReport(JsonUtil.scala:17)
[ssl-config] 	at sbt.ivyint.CachedResolutionResolveCache.sbt$ivyint$CachedResolutionResolveCache$$loadMiniGraphFromFile$1(CachedResolutionResolveEngine.scala:165)
[ssl-config] 	at sbt.ivyint.CachedResolutionResolveCache$$anonfun$7.apply(CachedResolutionResolveEngine.scala:176)
[ssl-config] 	at sbt.ivyint.CachedResolutionResolveCache$$anonfun$7.apply(CachedResolutionResolveEngine.scala:176)
[ssl-config] 	at scala.Option.orElse(Option.scala:257)
[ssl-config] 	at sbt.ivyint.CachedResolutionResolveCache.getOrElseUpdateMiniGraph(CachedResolutionResolveEngine.scala:176)
[ssl-config] 	at sbt.ivyint.CachedResolutionResolveEngine$$anonfun$customResolve$1$$anonfun$17.apply(CachedResolutionResolveEngine.scala:363)
[ssl-config] 	at sbt.ivyint.CachedResolutionResolveEngine$$anonfun$customResolve$1$$anonfun$17.apply(CachedResolutionResolveEngine.scala:337)
[ssl-config] 	at scala.collection.TraversableLike$$anonfun$map$1.apply(TraversableLike.scala:244)
[ssl-config] 	at scala.collection.TraversableLike$$anonfun$map$1.apply(TraversableLike.scala:244)
[ssl-config] 	at scala.collection.Iterator$class.foreach(Iterator.scala:727)
[ssl-config] 	at scala.collection.AbstractIterator.foreach(Iterator.scala:1157)
[ssl-config] 	at scala.collection.IterableLike$class.foreach(IterableLike.scala:72)
[ssl-config] 	at scala.collection.AbstractIterable.foreach(Iterable.scala:54)
[ssl-config] 	at scala.collection.TraversableLike$class.map(TraversableLike.scala:244)
[ssl-config] 	at scala.collection.AbstractTraversable.map(Traversable.scala:105)
[ssl-config] 	at sbt.ivyint.CachedResolutionResolveEngine$$anonfun$customResolve$1.apply(CachedResolutionResolveEngine.scala:337)
[ssl-config] 	at sbt.ivyint.CachedResolutionResolveEngine$$anonfun$customResolve$1.apply(CachedResolutionResolveEngine.scala:286)
[ssl-config] 	at scala.collection.mutable.MapLike$class.getOrElseUpdate(MapLike.scala:189)
[ssl-config] 	at scala.collection.concurrent.TrieMap.getOrElseUpdate(TrieMap.scala:632)
[ssl-config] 	at sbt.ivyint.CachedResolutionResolveCache.getOrElseUpdateProjectReport(CachedResolutionResolveEngine.scala:244)
[ssl-config] 	at sbt.ivyint.CachedResolutionResolveEngine$class.customResolve(CachedResolutionResolveEngine.scala:286)
[ssl-config] 	at sbt.IvySbt$$anon$5$$anon$3.customResolve(Ivy.scala:102)
[ssl-config] 	at sbt.IvyActions$$anonfun$updateEither$1.apply(IvyActions.scala:178)
[ssl-config] 	at sbt.IvyActions$$anonfun$updateEither$1.apply(IvyActions.scala:168)
[ssl-config] 	at sbt.IvySbt$Module$$anonfun$withModule$1.apply(Ivy.scala:156)
[ssl-config] 	at sbt.IvySbt$Module$$anonfun$withModule$1.apply(Ivy.scala:156)
[ssl-config] 	at sbt.IvySbt$$anonfun$withIvy$1.apply(Ivy.scala:133)
[ssl-config] 	at sbt.IvySbt.sbt$IvySbt$$action$1(Ivy.scala:57)
[ssl-config] 	at sbt.IvySbt$$anon$4.call(Ivy.scala:65)
[ssl-config] 	at xsbt.boot.Locks$GlobalLock.withChannel$1(Locks.scala:93)
[ssl-config] 	at xsbt.boot.Locks$GlobalLock.xsbt$boot$Locks$GlobalLock$$withChannelRetries$1(Locks.scala:78)
[ssl-config] 	at xsbt.boot.Locks$GlobalLock$$anonfun$withFileLock$1.apply(Locks.scala:97)
[ssl-config] 	at xsbt.boot.Using$.withResource(Using.scala:10)
[ssl-config] 	at xsbt.boot.Using$.apply(Using.scala:9)
[ssl-config] 	at xsbt.boot.Locks$GlobalLock.ignoringDeadlockAvoided(Locks.scala:58)
[ssl-config] 	at xsbt.boot.Locks$GlobalLock.withLock(Locks.scala:48)
[ssl-config] 	at xsbt.boot.Locks$.apply0(Locks.scala:31)
[ssl-config] 	at xsbt.boot.Locks$.apply(Locks.scala:28)
[ssl-config] 	at sbt.IvySbt.withDefaultLogger(Ivy.scala:65)
[ssl-config] 	at sbt.IvySbt.withIvy(Ivy.scala:128)
[ssl-config] 	at sbt.IvySbt.withIvy(Ivy.scala:125)
[ssl-config] 	at sbt.IvySbt$Module.withModule(Ivy.scala:156)
[ssl-config] 	at sbt.IvyActions$.updateEither(IvyActions.scala:168)
[ssl-config] 	at sbt.Classpaths$$anonfun$sbt$Classpaths$$work$1$1.apply(Defaults.scala:1555)
[ssl-config] 	at sbt.Classpaths$$anonfun$sbt$Classpaths$$work$1$1.apply(Defaults.scala:1551)
[ssl-config] 	at sbt.Classpaths$$anonfun$doWork$1$1$$anonfun$122.apply(Defaults.scala:1586)
[ssl-config] 	at sbt.Classpaths$$anonfun$doWork$1$1$$anonfun$122.apply(Defaults.scala:1584)
[ssl-config] 	at sbt.Tracked$$anonfun$lastOutput$1.apply(Tracked.scala:37)
[ssl-config] 	at sbt.Classpaths$$anonfun$doWork$1$1.apply(Defaults.scala:1589)
[ssl-config] 	at sbt.Classpaths$$anonfun$doWork$1$1.apply(Defaults.scala:1583)
[ssl-config] 	at sbt.Tracked$$anonfun$inputChanged$1.apply(Tracked.scala:60)
[ssl-config] 	at sbt.Classpaths$.cachedUpdate(Defaults.scala:1606)
[ssl-config] 	at sbt.Classpaths$$anonfun$updateTask$1.apply(Defaults.scala:1533)
[ssl-config] 	at sbt.Classpaths$$anonfun$updateTask$1.apply(Defaults.scala:1485)
[ssl-config] 	at scala.Function1$$anonfun$compose$1.apply(Function1.scala:47)
[ssl-config] 	at sbt.$tilde$greater$$anonfun$$u2219$1.apply(TypeFunctions.scala:40)
[ssl-config] 	at sbt.std.Transform$$anon$4.work(System.scala:63)
[ssl-config] 	at sbt.Execute$$anonfun$submit$1$$anonfun$apply$1.apply(Execute.scala:228)
[ssl-config] 	at sbt.Execute$$anonfun$submit$1$$anonfun$apply$1.apply(Execute.scala:228)
[ssl-config] 	at sbt.ErrorHandling$.wideConvert(ErrorHandling.scala:17)
[ssl-config] 	at sbt.Execute.work(Execute.scala:237)
[ssl-config] 	at sbt.Execute$$anonfun$submit$1.apply(Execute.scala:228)
[ssl-config] 	at sbt.Execute$$anonfun$submit$1.apply(Execute.scala:228)
[ssl-config] 	at sbt.ConcurrentRestrictions$$anon$4$$anonfun$1.apply(ConcurrentRestrictions.scala:159)
[ssl-config] 	at sbt.CompletionService$$anon$2.call(CompletionService.scala:28)
[ssl-config] 	at java.util.concurrent.FutureTask.run(FutureTask.java:266)
[ssl-config] 	at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
[ssl-config] 	at java.util.concurrent.FutureTask.run(FutureTask.java:266)
[ssl-config] 	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
[ssl-config] 	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
[ssl-config] 	at java.lang.Thread.run(Thread.java:748)

@eed3si9n I see stuff about cached resolution in the stack trace, perhaps this has to do with the cached resolution changes in sbt 1.2.6?

gah, or not, actually both projects are on 0.13.7

ah, but maybe it's a clue regardless. both projects use withCachedResolution(true). they aren't the only two projects to use it, but it isn't a super common thing to have enabled, either

I see Scala Pickling in the stack trace so that probably something specific to sbt 0.13.
I'd recommend we try upgrading the build to use sbt 1.

Looks like HEAD is already at sbt 1 https://github.com/lightbend/ssl-config/blob/f417509e22006baba2a00d42481120b81ad972cd/project/build.properties but it was frozen in August https://github.com/scala/community-builds/commit/3514a6ce32d39417635320c19b1c9a03d2c786f0.

I'd recommend we try upgrading the build to use sbt 1

okay, that's doable, and it's desirable anyway, I'll try that path

@japgolly perhaps you've been meaning to move nyaya to sbt 1 anyway...?

at #808 I'm attempting to bring in ssl-config's sbt 1 upgrade

Hi. Yeah no problem, I'm happy to upgrade to new SBT but I won't have much
computer time until next week. I hope this isn't urgent...?
On Wed., 24 Oct. 2018, 11:45 am Seth Tisue<EMAIL_ADDRESS>wrote:

at #808 https://github.com/scala/community-builds/pull/808 I'm
attempting to bring in ssl-config's sbt 1 upgrade
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/scala/community-builds/issues/806#issuecomment-432471682,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAMYt9O8Ba27nNp0bBOu_Oct662iQXk1ks5un7gQgaJpZM4XxjSe
.

nyaya is on sbt 1 now and I haven't seen this error on any other projects in the last couple months


Fancy Zones Tabs

Description of the new feature / enhancement
It would be helpful if you added an option for the Fanzy Zones to display a tab at the top for each window that is snapped.

This would help to finds windows that are snapped under others.
This would help to select a specific window with a single mouse click instead of using keystroke to toggle.

Also, if the active tab was highlighted (or the others were greyed out), this would help know which window has the focus for any keystroke or mouse click.
There's lots you can do if you implement tabs to Fancy Zones. You could even put up a settings badge. You could right click any tab to manage the settings for that particular window.
Scenario when this would be used?
I would use this all the time. I keep at least 6-10 windows open at a time. I would do all my windows navigation with the tabs.
Supporting information
No response

/dup https://github.com/microsoft/PowerToys/issues/15921


QuickTabs recently disappeared from my extensions!

As you know, I love this extension. Recently, I had deactivated some extensions (using Extensity), but Extensity cannot delete them. Today, I went to turn on QuickTabs, and it was GONE! It didn't even appear in my Chrome extensions list. Of course, I reinstalled it right away (and applied my custom styling that you so kindly featured in your screenshots). Have you heard of this happening to anyone else?

That is very strange, I know that Chrome has taken to deactivating QuickTabs every time I rollout an update (which is very frustrating and I have not found any details online yet) but I have not had anyone mention it being uninstalled :|

Well, I'm keeping an eye on it. ;-)

duplicate of #79?


DataAnnotation validation

DataAnnotation validation is ignored if route parameter has the same name as object variable passed in the body of the HTTP request
Model:
public class TransferInfo
{
        [Range(1, int.MaxValue)] //or CustomValidationAttribute
        public int AccountId { get; set; }
        public double Amount { get; set; }
}

Controller:
[HttpPost("{accountId:int}")]
public IActionResult Transfer(int accountId, [FromBody] TransferInfo transferInfo)
{
    if (!ModelState.IsValid)
    {
        return HttpBadRequest();
    }
    ...
}

Posted data (JSON):
{
     "accountId": 0,
     "amount": 250.0
}

ModelState is valid even if I check that accountId must be greater than 0, using Range or Custom validation attribute.
If I update my TransferInfo class definition and rename "AccountId" by "ToAccountId" and try to send:
{
     "toAccountId: 0,
     "amount": 250.0
}

ModelState Validation will failed

IIRC from digging around in the validation class, this will be because a validation state entry with a key of "AccountId" (case-insensitive) has already been populated. If you place the TransferInfo argument first in the signature, does the validation take effect?

I haven't think of that. You are right, validation works if TransferInfo is first in the signature.
Thanks!

@rynowak thoughts on this? This seems orthogonally tangentially related to the issue with the cancellation token with regard to the truth of what's in the model state dictionary...

@rynowak ping

Yep. This is definitely related to #3743

@Eilon - I don't think this is related to my other validation fix. Self-assigning and will fix.

The issue here is that we don't try to validate something that already appears valid. The idea is to avoid duplicating work when we have a cycle. However, cycles are rare, and validation may depend on the container-object for correctness.
The criteria that we're using in this case is the model state dictionary care, which we've seen can definitely overlap between model objects. We should just change this check to proceed if the state is anything other than Invalid rather than requiring it to be Unvalidated.

@kichalla donating this bug to you, it is a gift from @rynowak .


Adding AUD because Square Register works in Australia

Square Register works in Australia, see https://squareup.com/help/au/article/4956-international-availability which indicates that "Card payment acceptance with the Square Register app is currently available in the US, Canada, Japan and Australia." Adding AUD to the list of supported currencies. Fixes #4.

LGTM


cli: improve help regarding channel selection

Fix https://github.com/nix-community/hydra-check/issues/10 .

sounds good, please remove the result file from the PR :)

OK, maybe add /result to .gitignore?

Thanks for the PR, i incorporated into 374b8aba634652101c65800268129c5e8e4aa498.
Cheers!


Add support for building under gcc 11.2.1 on Linux

This PR fixes some (very simple) build-time issues I had when compiling with gcc 11.2.1 on openSUSE.
It does not currently build with clang-12.
Signed-off-by: Andrew V. Jones<EMAIL_ADDRESS>

Thank you for the contribution!


Create tptlive.txt

File for Tallinn Polytechnic school. E-mail creation is done by school administrators so random person can not register for it.

The best description of different studies is defined at http://www.tptlive.ee/sisseastujale/ Probably goolge translate would be the best to get it translated since after the webpage update the language selector does nothing. Also http://www.tptlive.ee/erialad/ shows the specialities. Hope it makes it a bit easier to verify it.

Comment about school e-mail addresses, only reference I found on web page was on http://www.tptlive.ee/kool/kontakt/ "Õpetajate ja töötajate e-posti aadressid on kujul: eesnimi.perekonnanimi (ät) tptlive.ee (täpitähtedeta)" translates to "Teachers and staff e-mail addresses are in the form: firstname.lastname (at) tptlive.ee (w/o accented characters)"
This also applies for the students and they are created when student has been studying for about a month to avoid creating accounts for students who only come to "test, if the school is right".

School used to use page www.tpt.edu.ee but has not been using it for a while now. Even though that also redirects to tptlive.ee.
For the whole whois on that domain you probably have to use the site provided in most of the foreign whois lookups "internet.ee" A quick link for that whois checkup without hassle of estonian language: http://rwhois.internet.ee/v1/tptlive.ee

@krisavi Thank you for the request and detailed information! Pull request merged.


Eric906 esri/master

Added a few more fixes while I was reviewing

@eric906 Update looks good, will merge with additional updates.

@doneill Thanks boss. My first PR in samples!


Appending state item to async task url

Me again....
Many of the api endpoints in our application require a profileId in the url, eg:
/articles/:profileId/:id
The profileId is stored in the state and previously, when using redux-saga (which we are replacing with redux-arc 🙂) we could get it before making the api call.
Is there a smart way of doing this with redux-arc?
We could intercept the api call with a middleware and detect the :profileId in the url with regex and replace it with the item from the state?
Currently we are getting it in mapStateToProps then passing down to the component then back up to mapDispatchToProps via event handlers which feels a bit messy

The url parsing happens before the middlewares, so, if you would like to use a middleware to do that, you would have to use a different marker in the url, such as /articles/_PROFILE_ID_/:id.
But I think I have a better solution.
When you are defining the arc's action configs, the url can be a string or it can be a function,  which will receive the  meta and should return the proper url. Eg:
const { creators, types } = createActions('user', {
  read: { url: (meta) => `/user/${meta.id}` }
});

creators.read(null, { id: 123 });

With that in mind, we could create a function that gets the profileId in the state, and creates a url with it.
First, you will have to export your store instance, so, you can import in other places and use
store.getState()

Considering you have that....
Let's create a function injectProfileId, which will expect a url to be parsed.
import parseUrl from 'redux-arc/lib/parseUrl';
import store from 'path/to/store';

const injectProfileId = (url) => (meta) => {
  const { profileId } = store.getState().user;

  return parseUrl(url, {...meta, profileId });
};

First, injectProfileId will expect a url, then, it returns the actual function that arc's config will use.
Arc has a function parseUrl, that we use internally to parse the urls that comes in the configs, we can import and use that. The first argument should be the url and the second, should be the params that will be used to parse it.
Finally, the action config.

const { creators, types } = createActions('namespace', {
  getArticles: {
    url: injectProfileId('/articles/:profileId/:id'),
    method: 'get',
  }
});

You can put injectProfileId into a utils file, so, whenever you need to have the profileId in the url, you just import and use it.
Let me know if you decide to use that approach and need some help.

That works perfectly, thanks @viniciusdacal


Add subgroups field to the user group objects and new api endpoints for different user group operations.

First commit adds subgroups field to the user group objects.
Second commit adds functions in actions.py to add and remove subgroups of a user group.
Third commit adds API endpoint for updating subgroups of a user group.
Fourth and Fifith commit add helper functions - get_user_group_member_ids and is_user_in_group.
Sixth and Seventh commit add new api endpoints to check whether a user is part of a user group or not.
Last commit adds endpoint to get members of a user group.

Part of #19525.

This is great, thanks for doing this @sahil839! I posted a batch of immediate comments. A few broader notes:

The API changelog entries seem to be line-wrapped at a much greater width than we normally do; can you clean that up?

@timabbott Updated the PR.

Updated is_user_in_group function as mentioned here.
Updated the line-wrapping in changelog entries. The ones with long endpoints still have larger widths, like we do in other long endpoints. so that link works correctly.
Checked the guest access to API endpoints and replied here
Started a couple of topics in #api-design.

@timabbott Updated the PR.

Updated is_user_in_group function as mentioned here.
Updated the line-wrapping in changelog entries. The ones with long endpoints still have larger widths, like we do in other long endpoints. so that link works correctly.
Checked the guest access to API endpoints and replied here
Started a couple of topics in #api-design.

@timabbott this is ready for next review. Changes have been made as per the recent discussion on CZO. Apart from changes mentioned above-

Updated the endpoints to be accessible only by non-guest users.
Changed the recursive variable name.

I pushed an updated version of this, addressing most of the minor details noted above. I think we are extremely close to being able to merge it. The main things I'm tracking as blockers are:

https://github.com/zulip/zulip/pull/21611#discussion_r856717068
The name for the ``GET /user_groups/{user_group_id}/members/me` endpoint, which I think I mangled while trying to figure out a good name. I think my current thinking is that the best option would be to just have that be a special case of the existing endpoint (i.e. you're allowed to pass "me" for a user ID), rather than an independent endpoint, as I cannot figure out a reasonable name for this and it's not really important. But I'd drop this endpoint from the PR to merge the rest if we get stuck on it.

Please do further updates on this PR by adding new commits (possibly ones to be squashed into their parent) -- I think this is sufficiently close that the time savings of my not re-reading many parts that are ready will be well worth it.  Thanks so much for all the work on this @sahil839!

@timabbott updated the PR. Have added two more commits -

One to address this comment and this can be squashed to its parent commit.
One to do a lint fix. Have also kept this as separate commit for now and mentioned the parent commit in commit message. Can squash once you review the PR.

Have not done follow-ups yet, will do in a separate PR. And replied to one comment here.
Regarding the GET /user_groups/{user_group_id}/members/me endpoint, I tried merging it with the existing endpoint. Something that we do for users/<user_id_or_email>/presence endpoint, where user_id is passed as string only, and then parsed in the view function accordingly (as can be seen in get_presence_backend code . But we do have separate endpoints and separate view functions for a couple of other cases like users/{user_id} and users/me endpoint. If we think having single endpoint is clean and better, we can skip this commit here and add it in separate PR.

Cool. A trick when doing these sort of to-squash commits is to have commit messages starting with fixup! at the start of the title, and placing them immediately after the commit they're to be squashed into -- that prevents merge conflicts when one tries to actually squash them. And also means one can use https://thoughtbot.com/blog/autosquashing-git-commits.


Span isn't available on .NET Core 2.0

Span is new to .NET Core 2.1. This topic incorrectly claims it is available in .NET Core 2.0.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 36ef14f5-5cfc-5d83-971f-18789cf45237
Version Independent ID: 9aa52936-b378-8715-4b31-46a1c0974c43
Content: Span Struct (System)
Content Source: [xml/System/Span1.xml](https://github.com/dotnet/dotnet-api-docs/blob/master/xml/System/Span1.xml)
Service: unspecified
Product: .net
GitHub Login: @dotnet-bot
Microsoft Alias: dotnetcontent

@weshaggard was Span part of extensions found in the master branch when we grabbed the assemblies for 2.0? I remember having discussed this issue before, I just don't remember if we found a way to solve this.

A related problem exists for ReadOnlySpan.DangerousGetPinnableReference() which interestingly enough is documented as only being available on .NET Core 2.0 (which it is not available on), and that it is not available on .NET Core 2.1 (which is where it was introduced).

@AArnott My hunch is that @mairaw is correct tat the docs were generated from extensions for .NET Core 2.0. The ReadOnlySpan<T>.DangerousGetPinnableReference() API changed names to GetPinnableReference  See #5845 and #5767 for details.

@AArnott  you have to install package System.Memory as I've found out just now.

Yes, I've learned that recently as well. Can the docs mention this? The excellent apisof.net site mentions packages that must be installed like this.

Issue #8192 has ongoing discussions on how to ensure this kind of information is readily available.

@Mart-Bogdan Additionally, Assembly names and NuGet-Packages are not always matching 1:1.

Knowing the minimum version that adds the type to the package for a given platform is also important.


TideBit CFD (Contract For Difference) KM

將google doc的CFD文件轉移至GitHub KM

taking 0.5 hrs
https://github.com/CAFECA-IO/KnowledgeManagement/blob/master/tidebit-cfd.md


DX: use modernize_strpos

Needs to have #5754 merged first.
Does it make sense, or it would create too many conflicts now?
@localheinz @julienfalque @kubawerlos @SpacePossum

Coverage increased (+0.002%) to 92.381% when pulling 87242475c4bc0b9a9a70a9775c64999d1f80cc73 on keradus:use_str_pos into 23ccc662249aab2afbaeaacb595d9c9286619e03 on FriendsOfPHP:master.

Thank you @keradus.


Remove old travis files

Since we are using codeship I'm just removing this. I'm also checking if the CI pipeline is working or not since it didn't seem working so good in #228.

Is this ready?

Oh sorry I was gonna close this after I was done with my testing.

I'll open up a new one for removing travis once I find out what's going on with codeship.


Remove Nuget reference to System.IO.Pipes

Since this page doesn't redirect to a different Net version (but previous versions do redirect), it means the API is available since Net 3.5: https://docs.microsoft.com/en-us/dotnet/api/system.io.pipes?view=netframework-3.5
As such, I don't think we need the PackageReference.

Fixed in bf1780a86b974f039b7fb8c0973efbfb47d533ca


I am wondering why all ASM kernels were disabled for gfx803 instead of disabling individual problematic ones?
Also, even without an ASM implementation, can we use a general OpenCL implementation in this case rather than rely on the extremely slow GEMM? (It seems conv_ocl_dir2Dfwd.cpp is not enabled for most 4x4 convolutions)

Which version of miopen do you use?

@atamazov Thanks for asking! I am using the current master of this repository (commit 2fe2ae90)
I also tried the pre-compiled MIOpen shipped with Rocm 3.1.
To obtain the performance of ASM kernels, I manually revert commit ce51a4c on the current master.

@atamazov I tried the just released version 2.3.0 and it is amazing! It is great news that ASM kernels are re-enabled on gfx803.  Thank you so much for the hard work and I am closing this issue.


Plugin no longer works

Plugin just give the following error in windowsgsm
"Fail to install [ERROR] The remote server returned an error: (410) Gone.
Any chance this can be updated/resolved?

Also it looks like someone made a fork of the plugin that mostly resolves this issue

however it still fails to fully create the server in windowgsm for no give reason.

https://github.com/Ada64bit/WindowsGSM.ForgeMC

hey, this appears to be a duplicate of #13, so I am going to close this issue.
fwiw, I don't really have any plans to update this repo myself. I am happy to have @Ada64bit create a PR to merge their changes into this repo, and add them as a contributor.


Revert "Swagger changes for App Gw Server Variables APIs"

Reverts Azure/azure-rest-api-specs#4345.
This PR was not approved or merged by SDK reviewers.

Automation for azure-sdk-for-js

Can one of the admins verify this patch?

Automation for azure-sdk-for-ruby

Automation for azure-sdk-for-java

Automation for azure-sdk-for-node


Add badge. (Mostly interested in whether tests are passing...)

So the parents pass, and this failure doesn't look like the failure I have in the other branch. https://travis-ci.org/WGBH/aws-wrapper/builds/138382974#L553
INFO [2016-06-17 14:59:31]: -A -o StrictHostKeyChecking=no<EMAIL_ADDRESS>ssh: connect to host <IP_ADDRESS> port 22: Connection refused

Going to re-start travis now and see if that makes a different.

Still failing: not able to make the first SSH connection... Has something changed?


Games run in window; alt+tab stops working; Low FPS most of the time

Describe the bug

No matter what game I try, the games most of the time just start in a sort of window, with the monitor resolution just being complety wrong. Also if I Alt+Tab out of the window, I can no longer enter the game again and have to close it through Task Manager as most of the time the game icon disapperas from the task bar.
Also, in most games the FPS dips to 1 or even lower without any reason. This sometimes happens even in menus but always in 3d vieports (e.g., in-game in Chaos Theory)
Which Remix version - 0.1.1
Which GPU - RTX 3080 10gb
Which GPU driver version - 531.61
Which game build (and whether it is from Steam/GOG/Other) - Splinter Cell Chaos Theory (Steam Version )

Attach logs!
NvRemixBridge.log
d3d9.log
splintercell3_d3d9.log
To Reproduce
Steps to reproduce the behavior:

Put RTX Remix into Splinter Cell Chaos Theory "system" folder
Run "splintercell3.exe"
Game starts in weird window and/or lags

Expected behavior
Game should run in fullscreen with the selected ingame resolution and should also not start to run with sub 1 FPS sometimes (especially ingame)
Screenshots

Hello! Will you please test this on the latest release and let us know if the issue persists? Thank you!


Run libpostal without installing

Hi
I am trying to run libpostal without installing it on my system with the src codes
Is there any way to work around the libpostal_data_dir which is set when the make file is build ?
Would appreciate any advice on how to run this library without installing it.

I ended up using docker image with REST API, you won't need to install anything besides docker - https://github.com/johnlonganecker/libpostal-rest-docker


Implemented IsHexDigit/FromHex in HttpEncoder

Part of #2220,
used an IfDef instead of replacement incase ms decides to update something.

Why ifdef at all? Just use the custom implementation.

Yeah, let's just keep the #ifdefs to an absolute minimum. If there's a bug in the implementation, at least it'll be consistent across platforms :wink:

:watch:

fixed.


【GEOSChem-on-cloud user testing and survey】(Phase one)

Dear GEOS-Chem users,
We are excited to invite you to attend the first user testing and survey for the GEOSChem-on-cloud project! Our major purposes are:

Collecting user statistics for our paper aiming at BAMS. The abstract has already been accepted.
Identifying problems with the current documentation, and make it better.

This testing should take you at most an hour and cost less than $0.1.
Why would you bother attending if you already have GEOS-Chem running smoothly on your local computer? Here are some good reasons:

You will be able to get immediate access to the latest version of the model and the full input dataset. (See what's new in the recently-released 12.0.0/12.0.1 in the Newsletter and version history)
You can learn many widely-applicable skills to solve exciting problems in Earth science.
Even with powerful local computers, the cloud is still very useful for quick testing or meeting peak computing needs.
We don't want to lock you in the cloud -- you can easily move the software environment between cloud and local computers using containers.

How to attend the testing & survey:
Part 1. Sign-up for an GitHub account
The survey will be done transparently on GitHub, so the first thing is signing up for an GitHub account if you don't have one already. GitHub is also the currently recommended way to submit your code updates, so it is nice to have an account, anyway.
Please add minimal information to your GitHub profile, such as a picture, one-sentence personal introduction, or a link to personal website / Google scholar site. So we can know who you are and how to contact you. Also consider giving a star to the repositories under the GEOS-Chem team. Just click on the "star" button on the upper-right corner of each repository page. This "shows appreciation to the repository maintainer for their work".
GEOS-Chem has a reasonably large amount of users, but it is sad that its GitHub repo receives so little attention because most scientists don't use GitHub. Here is actually a much better place for discussion compared to private emails, because all discussions are public and can be easily found by anyone with similar problems.
Part 2. Fill-in basic form
You will reply to this survey by simply posting GitHub comments within this GitHub issue (i.e. the current page you are looking at). See the "comment" cell at the bottom of this page, with a big, green "comment" button.
The first part is general info:

Background: University, department, which role.
GEOS-Chem experience: X years

The second part is just a place holder right now. It will be the time you spend on a minimal GEOS-Chem demo on the cloud, as explained in the next section:

Step 1: X minutes
Step 2: X minutes
Step 3: X minutes
Step 4: X minutes
General feedback: For example, is any step confusing?

Part 3. Go through the "Quick start guide" and record the time
We have a very comprehensive documentation, but the most important part for a new user is the Quick start guide. That guide has 5 major steps. We sincerely ask you to go through them and record the time you spend on each step. The timing starts when you begin to follow the instruction for a particular step, and ends according the following rules. Please read through the rules to get a general idea before actually starting the timing.

Step 1. Sign up an AWS account: This step is considered finished when you can log into AWS console with your account. Note that a credit card is needed, although the cost of this short demo is negligible (~$0.1). If you don't have a credit card but still wants to try the cloud, please contact us individually. For this test, I think it is very useful to see how long it takes to get the account. (If you have already signed-up for an account, simply put a rough number of how long that took last time. Additional operations such as subscribing to the educational credit is not included in the timing.)

Step 2: Launching a server with GEOS-Chem pre-installed: This step is considered finished when you can see the running server (also called "EC2 instance") with a green "running" icon in your AWS console.

Step 3: Log into the server and run GEOS-Chem: This step is considered finished when you can execute the simulation by the command ./geos.mp. No need to wait for the simulation to finish. (For Windows users, do not include the time on installing terminal software like Git-BASH).

Step 4: Analyze output data with Python and Jupyter: This step is considered finished when you can see the Jupyter notebook interface in your browser. You will find this step easier if you take a look at our interactive Python tutorial first. However, you don't have to know Python in order to follow this step. You can simply copy and paste the commands shown in the guide. I just want to see if people can successfully connect to the Jupyter notebook program on the cloud. Learning Python can be a separate topic.

 But do remember to shut down the server, otherwise you may be charged by much more than $0.1.

Final comments

This thread (i.e. GitHub issue) is only for replying to the survey. All replies/comments should stick to the format specified above. If a comment doesn't conform to the format, I will edit it (without changing the actual content). To discuss the strategy of the survey, please use #14.
Please be honest about the timing. This survey is not to test you, but to test us... If you spend much longer than others, it is probably because our documentation or AWS's UI is confusing. We could have made the survey private (e.g. using Google Forms), but I really want to make all "raw data" transparently visible. The problem with posting results here is that people might be affected by other's results. So, please do post the actual time you spend.
If you want to dive deeper after going through the quick start guide, please see all the Beginner tutorials and then go through a much more complete workflow.

Thanks very much for your time and help! Hope you find this new cloud computing capability useful!

Background:
GEOS-Chem experience: X years
Step 1: X minutes
Step 2: X minutes
Step 3: X minutes
Step 4: X minutes
General feedback:

Here's a sample reply:
Background: XX University, XX department, Graduate Student
GEOS-Chem experience: X years
Step 1: X minutes
Step 2: X minutes
Step 3: X minutes
Step 4: X minutes
General feedback: None

Background: Harvard University, GEOS-Chem Support Team, Scientific Programmer
GEOS-Chem experience: 4 years
Step 1: 6 minutes
Step 2: 6 minutes
Step 3: 5 minutes (not including wait time for GEOS-Chem simulation to run)
Step 4: 9 minutes
General feedback:

I created a new account different from my existing account for this test. I found that there was latency in Amazon verification of my account that caused me to have to wait to launch my first instance. I recommend doing account set up and then coming back a bit later to complete steps 2+.
In Step 4 I recommend telling users how to exist python and how to log out of the AWS from the command line. Putting this at the point where users have ipython open but are then directed to re-log in to use Jupiter Notebook would be a good place for this.
It is important to note that when you log back in to use Jupyter Notebook you must source activate geo prior to running the Jupiter command. This is missing from the tutorial.
When I went to the Jupiter page on my browser I was not able to navigate to parent directories. This means users should always launch it from their home directory in the instance. A better way, however, is to append --notebook-dir ~ to the Jupyter command such that the home directory is the default. I recommend adding this to the tutorial.
I think the tutorial should up front tell users about stopping and terminating instances to avoid unexpected charges. Move this to end of Step 2.
Finally, the time it took me to complete this would probably be a lower bound for new users since I have done this before.

Background: Harvard University, Environmental Sciences and Engineering, Graduate Student,
GeosChem experience: 1 year
Step 1: 10 minutes
Step 2: 1.5 minutes
Step 3: 3 minutes
Step 4: 13 minutes

I had created an AWS account in my CS205 class. I had used Jiawei's tutorial instead of the class tutorial then. It took around 10 minutes to set up the account.
This step was well documented and easy to follow.
same as above
I think the tutorial was straightforward but I took longer because I wasn't used to using port forwarding to use jupyter notebook. I usually use XQuartz and ssh -X which also allows me to use jupyter notebook in the remote server which can also be an alternative, albeit slower.

Background: Harvard University, GEOS-Chem Support Team, Senior Scientific Programmer
GEOS-Chem experience: 7 years
Step 1: 5 minutes
Step 2: 6 minutes, wait 1 hour for account verification, <1 min to finish
Step 3: 7 minutes
Step 4: 34 minutes
General feedback:

In Step 2, the text 'In the EC2 console, click on “AMI” (Amazon Machine Image)...'  should say "AMIs"
In Step 2, also put red circle around "Launch Instances" in creating key pair figure
After clicking "Launch Instances" the first time, I got "Launch status: Launch Failed. Your account is currently being verified. Verification normally takes less than 2 hours. Until your account is verified, you may not be able to launch additional instances or create additional volumes. If you are still receiving this message after more than 2 hours, please let us know by writing to<EMAIL_ADDRESS>We appreciate your patience."
It might be worth asking participants what OS they use.
I used a PC and MobaXterm, so step 4 took me a while to figure out the port forwarding step. I repeated Step 4 again using Git-BASH as suggested and it took 4 minutes.

Harvard University, GEOS-Chem Support Team, Senior Software Engineer
GEOS-Chem experience: 20+ years
Step 1: 5 minutes
Step 2: 5 minutes
Step 3: 5 minutes
Step 4: 16 minutes
General feedback:

A couple of times I had to re-login because the AWS instance display gave the hostname as<EMAIL_ADDRESS>but you needed to login as<EMAIL_ADDRESS>  That is annoying but I'm not sure what you can do about it.
I installed Git bash (install time not included above).  But in step 4 I often had trouble cutting & pasting into Git bash.  Perhaps that is because I am more familiar with e.g. MobaXterm, but it was an annoyance.
At this command: "Visit http://localhost:8899" etc.  That opens Jupyter notebook in general, but I got hung up trying to get the jupyter notebook to change folders.  If you follow the "Reactivate the python environment and run jupyter notebook..., that will open in the geosfp_4x5_standard folder.  You might want to tell people to change to the ~/tutorial/python_example folder before having the open the notebook.  Then it should be easier to find the notebook file.

Otherwise I found everything pretty straightforward.  Great job!

Harvard University, SEAS, Postdoc
GEOS-Chem experience: 5 years
Step 1: 4 minutes
Step 2: 5 minutes, wait ~ half hour for verification
Step 3: 7 minutes
Step 4: 8 minutes, a little bit confusion in activate python environment
General feedback:
Quite straightforward following the instructions. Thanks!

Harvard University, SEAS, Postdoc
GEOS-Chem experience: 9 months
Step 1: < 10 minutes
Step 2: 7 minutes
Step 3: 3 minutes
Step 4: 2 minutes
General feedback:
Very user friendly. The tutorial is very clear and easy to follow.
Thanks!

Harvard University, EPS, Grad Student
GEOS-Chem experience: Ran for undergrad thesis
Step 1: 5 minutes
Step 2: 6 minutes
Step 3: 4 minutes
Step 4: 6 minutes
General feedback:
Easy to follow this guide and felt like I will use again in the future.

Harvard University, SEAS Postdoc
GEOS-Chem experience: 6 years
Step 1: 10 minutes
Step 2: 30 minutes (had to wait for account verification)
Step 3: 5 minutes
Step 4: 15 minutes
Genreal comments: The quick start guide is well organized and straightforward. After being able to actually run the model and see the output in about an hour, I feel much more confident about using GEOSChem-on-cloud.

Background: Harvard University, Postdoc
GEOS-Chem experience: 7 years
Step 1: 7 minutes
Step 2: 5 minutes (takes ~ 1hour for account verification)
Step 3: 3 minutes
Step 4: 8 minutes
General feedback:

I did my test on a Ubuntu-PC.

The Quick start guide is very helpful and straightforward.

Harvard University, EPS Grad Student
GEOS-Chem experience: None
(Steps 1-4: same as Makoto)
General comments: Easy to follow the guide! Very clear instructions and good intro to GEOS-Chem for non-users.
Specific comments:

Link the "Create an AWS account" button image to "https://portal.aws.amazon.com/billing/signup#/start" rather than the image itself; the "http://aws.amazon.com" website says "Sign up" rather than "Create an AWS account" for the button
More detailed explanation of "preferably $HOME/.ssh" i.e. what is the home folder generally? users will probably cd to the users/xxx/Downloads folder on a mac rather than the home folder; explain how users can move the .pem key with the mv command (step 3)
Maybe write out full command (ssh -i "xx.pem"<EMAIL_ADDRESS>and chmod 400 xx.pem), replacing the xx's and adding it as a code block so users can easily copy the commands for this specific tutorial (step 3)
Explicitly show how to change "root" to "ubuntu" by showing how to edit command, i.e. ssh -i "xx.pem"<EMAIL_ADDRESS>instead of  ssh -i "xx.pem"<EMAIL_ADDRESS>(step 3)

Background: Harvard University, visiting graduate student
GEOS-Chem experience: 0.5 years
Step 1: 5 minutes
Step 2: 5 minutes (account verification takes 15 min)
Step 3: 3 minutes (takes 15 min to install Git-BASH, because I use windows 10 system.)
Step 4: 3 minutes
General feedback:
It will be faster for me to use GEOS-Chem on AWS if I have Git-BASH already installed or if I use Mac.
Thanks! Running GEOS-Chem will be much more convenient!

Background: Harvard University, SEAS, Postdoc
GEOS-Chem experience: 1 year
Step 1: 8 minutes
Step 2: 5 minutes (not including 10 mins waiting time for AWS verification)
Step 3: 10 minutes
Step 4: 7 minutes
General feedback:

The verification of AWS takes some time
The jupyter command could be save to a file to save time to launch

Background: Harvard University, Graduate Student
GEOS-Chem experience: 0 years
Step 1: 8 minutes
Step 2: 13 minutes
Step 3: 14 minutes
Step 4: 20 minutes (lots of time wasting involved though)
General feedback:
AWS account took some time to set up.
I agree with above user: 'Overall excellent tutorial! At end of Step 2 (Launch Instance), had to wait for verification but it quickly worked after hitting "Retry"'

Was slightly confused by order of directions for beginning of step 3.
I'm also not super familiar with using terminal so some of the directions could be made more detailed for people not familiar with terminal (assume someone doesn't know how to move directories, etc.).
Maybe having clear separations from steps would also help

Background: Peking University, Graduate Student
GEOS-Chem experience: 0 years
Step 1: 9 minutes
Step 2: 18 minutes
Step 3: 50 minutes
Step 4: 15 minutes
General feedback:
1.It took some time for the verification of the AWS account.
2.In the Step 3 to log into the server, most of time wasted on my carelessness to change the IP to my own IP. Don't copy the example line directly!
3.For people with 0 experience in Geoschem and nearly no experience in modelling like me, I run the GeosChem within 2 hours (1 hour time wasted on unnecessary things). So it's really a great tutorial. Although it will take aditional time to become fully familiar with the GeosChem in AWS (like the output data analysis and download), it's still a great inspiration if you can start it quickly.
4. Maybe you can add more detailed instructions on how to run our self-designed GeosChem model

Background: MIT, Graduate Student
GEOS-Chem experience: 0 years
Step 1: 5 minutes
Step 2: 5 minutes (waited for another 20 min to verify AWS)
Step 3: 15 minutes
Step 4: 20 minutes
General feedback:
First time to use AWS but found it extremely user-friendly with Jiawei's tutorial. Everything went well under instruction. I am not a python/jupyter wizard but with this pleasant trial I would like to explore more into it.

Background: Harvard University, Postdoc, School of Public Health, Postdoc
GEOS-Chem experience: 0 years
Step 1: 8 minutes
Step 2: 12 minutes (15 min. for AWS verification)
Step 3: 4 minutes
Step 4: 7 minutes
General feedback: None. Thank you for putting this together.

Background: Peking University, Graduate Student
GEOS-Chem experience: 0 years
Step 1: 2 hours (a lot of time waste for phone verification)
Step 2: 12 minutes (another 10 minutes for AWS verification)
Step 3: 18 minutes  (another 10 minutes for simulation)
Step 4: 12 minutes (just analyzed with python, not include Jupyter notebook)
General feedback:

Step1：I cannot received the phone call for phone verification,  the system may have some problem for Chinese users and it took me quite a lot time to ask the support center to do the verification.
Step3：When login used ubuntu, there showed something wrong with authentication and made me really confused. And it took me some time to figure out. Just choose "yes" when they ask you if you still want to establish the connection.
In general, It's a good tutorial. I can finish the test according to these steps. However,  for user without GEOS-Chem experience and people not familiar with Linux. It will take longer time to finish.

Background: Peking University, Undergraduate Student
GEOS-Chem experience: 1 year
Step 1: n/a (see below)
Step 2: 5 minutes
Step 3: 15 minutes (there was considerable SSH lag from China.)
Step 4: 8 minutes (I used the pre-provided output file)
Step 2 took shorter time for me because I already had an AWS account, so I was already verified. From my memory signing up for AWS did require some verification time, around ~10 minutes I believe for Step 1 & 2.
Overall it is a great tutorial! Thanks for putting it together.

Background: University of Lille, LOA/CNRS, Postdoc
GEOS-Chem experience: 2 years
Step 1: 20 minutes (lots of time wasting for account verification and activation)
Step 2: 10 minutes
Step 3: 10 minutes
Step 4: 15 minutes
General feedback:
Great tutorial, easy to follow.

Background: The University of Edinburgh, School of GeoSciences, Graduate Student
GEOS-Chem experience: 0 years
Step 1: 8 minutes
Step 2: 7 minutes plus 13 minutes for acount verification
Step 3: 5 minutes plus 8 min to complete simulation
Step 4: 9 minutes + 3 minutes to use jupyter notebook in Linux environment.
General feedback:
In step 4, everything was ok until I tried open the jupyter url using Google Chrome in Windows environment. I tried for several times and it's still not ok now. Therefore, I tried connect to jupyter notebook in Linux environment and succeeded in less than 3 minutes. I still do not know why I cannot open the url in Windows environment as the Git Bash showed no error.
It's quite inspiring to get the GEOS-Chem model run for a novice like me. I would be grateful if you could write more self-customized GEOS-Chem running tutorials based on AWS!

Closing out this issue now.


Mounted folder appears empty using Docker-PowerShell; fine with 'docker'

The following command executes successfully and I'm able to view my host directory "C:\temp" as "C:\scripts" on the container:
docker run -it -d --name festus -v c:\temp:c:\scripts core_usr_img
...but when performing the same action using the PowerShell module as follows...
$config = [Docker.DotNet.Models.Config]::new();
$config.Hostname="festus";
$dict = new-object 'system.collections.generic.dictionary[string,object]';
$dict.Add("C:\temp:c:\scripts",$null);
$config.Volumes = $dict;
$config;
Run-ContainerImage "core_usr_img" -Configuration $config -name "festus" -Detach -input

...the container starts up, 'scripts' appears as a folder in c:, but it's empty. The container can't see the contents of the folder. Again, this works just fine using the raw 'docker' call. Only when using the PowerShell module does this bug occur. Any ideas?

Just a follow-up on this in case anyone else encounters the same thing. Mounting a host directory actually calls for use of the HostConfig class, not Config as indicated in some of the other forum posts here. Further, it's the 'Bind' property, not 'Volumes' that should be used to construct the mount. The follow revised script works and the directory is now visible from the container:
$config = [Docker.DotNet.Models.HostConfig]::new();
$config.Binds= new-object 'system.collections.generic.list[string]';
$config.Binds.Add("c:\temp:c:\scripts");
Run-ContainerImage "core_usr_img" -name "festus" -Detach -input -HostConfiguration $config


Add timeout to Continuum JS Client connect

Currently this hangs indefinitely. Which is fine unless the server you have configured does not exist.

This was fixed in 1.10.0


Add ? and [ to glob patterns

It would be useful to include tests for specific functionality that this would enable and that you would like to see keep around.
cc @martindurant

I am OK with this change, and issues should be raise elsewhere to make sure that backends other than local can deal with all the possible glob patterns.

What's the status on this.  @martindurant if you approve of this change then can you merge?  Is it reasonable to ask for a test for this behavior?

Certainly tests (for local) wouldn't hurt.

@roman-kh do you have time to add a quick test to this?  You might find good examples by searching for the filetexts context manager

Closing this soon for lack of activity.  @roman-kh any interest in finishing this up?

The failure is test_interrupt (i.e., unconnected) and flake.

The failure is in "?" processing... Will fix it in a few minutes.

Not sure if this would be any easier to implement now than it was in 2017, but since all the docs say the input can be a globstring, I would have thought ? was supported.

@roman-kh , you are welcome to propose better glob handling at fsspec

Is this PR still relevant now that we're using fsspec? Should it be targeted there instead?

fsspec implements this


Log Processor and Writer Providers

Added LogProcessorProviderInterface
Added LogWriterProviderInterface

@weierophinney do we want to still support more Provider classes?

Closing in favor of #46, which handles these via configuration only.


Idle Modal: Basic Implementation

Summary
Fixes https://github.com/rancher/dashboard/issues/8321

Technical notes summary

Added a new <Interactivity /> component
Areas or cases that should be tested

By default the component is disabled (this will change once we take care of the part 2 of the feature), to test it in /shell/layouts/default.vue#L770  change it to enable like this<Inactivity enabled />
Inside the /shell/components/Inactivity.vue they're some props you can play around like after how much time the initial modal will show and how much time does the user have until we unsubscribe from the WS.
While the timer is going on, you can resume the activity by clicking the Resume Session button and it will reset the inactive timer. Moving the mouse, pressing keys etc.. should keep reseting the timer, the moment you stop those actions, it will start counting down and after showModalAfter it will show the countdown.
If the timer reaches 0, we unsubscribe from sockets (having the devtool open you'll see 3 main actions for rancher, manager and, cluster

Screenshot/Video

@scures There's some test failures, can you take a look? Is it ready to come out of draft as well?

@scures no you still have to rebase
https://github.com/scures/dashboard/compare/feat/inactivity-modal...rancher:dashboard:master

Given https://github.com/rancher/dashboard/pull/8775, can this one now be closed?

@scures You have to add the extra fix to the other PR and close this with a comment.
Actually that's true, it's better close than merge at this point 😅


kernel: Fix overriding

Motivation for this change
This was reported in https://github.com/NixOS/nixpkgs/issues/111504 but further complicated in https://github.com/NixOS/nixpkgs/pull/121518
This should clean it up, though I haven't tested it more than just a basic linuxPackages.kernel evaluation, as I'm not familiar with how it's all used.
I'd ideally like @samuela @samueldr, @kira-bruneau, @Atemu and @NeQuissimus to take a look at this, as they've been involved in the above two linked issues
Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[ ] Fits CONTRIBUTING.md.

I think you're looking for @samueldr I'm afraid I'm no help here!

@Atemu Ah good catch, I'm surprised ofborg didn't run this. I fixed it with the latest commit.

Closing for now. Hard to get motivation to fix this, it's really hard to wrap your head around this issue


Allow enabling/disabling of the 1-pixel border of documents in DockWindow

Allow enabling/disabling of the 1-pixel border of documents in DockWindow (as property 'DocumentWithBorder' of DockPanel). Helps to remove flicking of the (IMO unnecessary) border, when doing animated content using OpenGL and Co maximized in the DockWindow.
It is actually only 1 commit. Forgot the comment, ended up with a merge. ;_;
(Sorry for the tabs, just reformat if necessary.)

Thanks. But we could not accept this for the following reasons,

Not yet ready to switch to .NET 4.5.
It is kind of a nice-to-have feature. Not very critical or required by one of the VS themes.

Remember that we only started to accept the close button on tabs till VS 2012/2013 themes require it.

Closed.


Unable to connect to your database server

I Got this error:
A Database Error Occurred
Unable to connect to your database server using the provided settings.
Filename: C:/xampp/htdocs/crm2/system/database/DB_driver.php
Line Number: 436

check your database credentials

Sorry, was it!


[JENKINS-46652] Integration test

Downstream of https://github.com/jenkinsci/jenkins/pull/3254.
@reviewbybees

You can use the do-not-merge label for such cases. (on-hold would be better though we lack such a label in this repo.)

If merging, continue with #83.


Make fixtures cloud-ready

What this PR does:
This PR makes it possible to run e2e tests against cloud-hosted clusters.
The tests can be run with the following make target:
make gke-e2e-test GKE_US_EAST_IP=w.x.y.z GKE_US_NORTH_IP=w.x.y.z

There are a few failures currently, most of them related to heap sizes. I'm still investigating.
Which issue(s) this PR fixes:
Fixes #463
Checklist

[x] Changes manually tested
[ ] Automated Tests added/updated
[ ] Documentation added/updated
[x] CHANGELOG.md updated (not required for documentation PRs)
[x] CLA Signed:  DataStax CLA

Can you provide a minimal set of instructions for running a single test against a GKE cluster? For now pick a test that doesn't require ingress or backup/restore.

Sure, you can run a single test with:
make gke-e2e-test GKE_US_EAST_IP=$GKE_US_EAST_IP GKE_US_NORTH_IP=$GKE_US_NORTH_IP E2E_TEST_TIMEOUT=8h E2E_TEST=TestOperator/CreateMultiReaper

I will send you the IPs privately as I don't want to expose them on GitHub.

For the record, my goal here is to provide 2 ways to run the e2e tests on GKE:

Manual with a make target (done);
Through GitHub Actions, using the get-gke-credentials action (still in progress).

I'm not too concerned about the zone labels. We don't have to use the zone labels. We can use whatever labels we want. We can configured labels on worker nodes with whatever automation we use to configure the k8s clusters.

Oh indeed that's an awesome idea that would simplify a lot the way we configure the e2e tests to run on a cloud provider. I haven't thought of it I confess.

Let's find some time to sync up on this. I would at least like to have some idea how things would look with a more declarative approach vs the templating-heavy approach.

Agreed 👍

Ok I'm considering this ready-ish.
There are plenty of opportunities to improve what we currently have but I think we could tackle them separately.

Revisit the heavy templating to adapt the fixtures to cloud environments as per @jsanda suggestion
Don't use zone names for topology, use fixed labels instead (increased portability) as per @jsanda suggestion
Run e2e tests on GHA: I am not going to propose a solution here because it's going to be involved and includes at least the following:

Use GKE specific actions for credentials: https://github.com/google-github-actions/get-gke-credentials
Need to create service accounts on GKE beforehand
Make ingress routes namespace-aware (allow parallelization of tests)

I can confirm that the remaining failures are flakies. I'm going to merge this now and create the follow-up tickets.


splunk python3

Status
Ready/In Progress/In Hold (Reason for hold)
Related Content Pull Request
Related PR: link to the PR at demisto/content
Related Issues
Related: link to the issue
Description
A few sentences describing the overall goals of the pull request's commits.

Docker Image Ready - Dev
Docker automatic build at CircleCI has deployed your docker image: devdemisto/splunksdk-py3:<IP_ADDRESS>176
It is available now on docker hub at: https://hub.docker.com/r/devdemisto/splunksdk-py3/tags
Get started by pulling the image:
docker pull devdemisto/splunksdk-py3:<IP_ADDRESS>176

Docker Metadata

Image Size: 28.32 MB

Image ID: sha256:e54de0e448e95fc00b61660765b4355804fac3197f35bf9cb34a886bab1d14c9

Created: 2022-11-06T13:02:31.493388143Z

Arch: linux/amd64

Command: ["python3"]

Environment:

PATH=/usr/local/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin
LANG=C.UTF-8
GPG_KEY=A035C8C19219BA821ECEA86B64E628F8D684696D
PYTHON_VERSION=3.10.8
PYTHON_PIP_VERSION=22.2.2
PYTHON_SETUPTOOLS_VERSION=63.2.0
PYTHON_GET_PIP_URL=https://github.com/pypa/get-pip/raw/5eaac1050023df1f5c98b173b248c260023f2278/public/get-pip.py
PYTHON_GET_PIP_SHA256=5aefe6ade911d997af080b315ebcb7f882212d070465df544e1175ac2be519b4
DOCKER_IMAGE=devdemisto/splunksdk-py3:<IP_ADDRESS>176

Labels:

org.opencontainers.image.authors:Demisto<EMAIL_ADDRESS>org.opencontainers.image.revision:ec7af7ab93d2de5c16479f4085269ba6fb62073d
org.opencontainers.image.version:<IP_ADDRESS>176

Docker Image Ready - Dev
Docker automatic build at CircleCI has deployed your docker image: devdemisto/splunksdk-py3:<IP_ADDRESS>189
It is available now on docker hub at: https://hub.docker.com/r/devdemisto/splunksdk-py3/tags
Get started by pulling the image:
docker pull devdemisto/splunksdk-py3:<IP_ADDRESS>189

Docker Metadata

Image Size: 28.32 MB

Image ID: sha256:1c09e4c9b34b67076556359fc3e7038eaf41b5362fcd1b7f121672e5d2be1a43

Created: 2022-12-12T12:42:17.719925928Z

Arch: linux/amd64

Command: ["python3"]

Environment:

PATH=/usr/local/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin
LANG=C.UTF-8
GPG_KEY=A035C8C19219BA821ECEA86B64E628F8D684696D
PYTHON_VERSION=3.10.8
PYTHON_PIP_VERSION=22.2.2
PYTHON_SETUPTOOLS_VERSION=63.2.0
PYTHON_GET_PIP_URL=https://github.com/pypa/get-pip/raw/5eaac1050023df1f5c98b173b248c260023f2278/public/get-pip.py
PYTHON_GET_PIP_SHA256=5aefe6ade911d997af080b315ebcb7f882212d070465df544e1175ac2be519b4
DOCKER_IMAGE=devdemisto/splunksdk-py3:<IP_ADDRESS>189

Labels:

org.opencontainers.image.authors:Demisto<EMAIL_ADDRESS>org.opencontainers.image.revision:0bfed2fd19b2753bf51549c01f2fc0336c82d467
org.opencontainers.image.version:<IP_ADDRESS>189

Docker Image Ready - Production
Docker automatic build at CircleCI has deployed your docker image: demisto/splunksdk-py3:<IP_ADDRESS>234
It is available now on docker hub at: https://hub.docker.com/r/demisto/splunksdk-py3/tags
Get started by pulling the image:
docker pull demisto/splunksdk-py3:<IP_ADDRESS>234

Docker Metadata

Image Size: 28.32 MB

Image ID: sha256:819ee3917fcf3de292f0e7ec5d6b9486962b664657da62848ec84206d344c4c9

Created: 2022-12-12T14:40:52.476140663Z

Arch: linux/amd64

Command: ["python3"]

Environment:

PATH=/usr/local/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin
LANG=C.UTF-8
GPG_KEY=A035C8C19219BA821ECEA86B64E628F8D684696D
PYTHON_VERSION=3.10.8
PYTHON_PIP_VERSION=22.2.2
PYTHON_SETUPTOOLS_VERSION=63.2.0
PYTHON_GET_PIP_URL=https://github.com/pypa/get-pip/raw/5eaac1050023df1f5c98b173b248c260023f2278/public/get-pip.py
PYTHON_GET_PIP_SHA256=5aefe6ade911d997af080b315ebcb7f882212d070465df544e1175ac2be519b4
DOCKER_IMAGE=demisto/splunksdk-py3:<IP_ADDRESS>234

Labels:

org.opencontainers.image.authors:Demisto<EMAIL_ADDRESS>org.opencontainers.image.revision:40e2adfadb4c18f1081bc80c650e8ec002ea764f
org.opencontainers.image.version:<IP_ADDRESS>234


Use Java <IP_ADDRESS> instead of 11.0.20

Use Java <IP_ADDRESS> instead of 11.0.20

Use Java <IP_ADDRESS>_1, not 11.0.20_8

Includes
Testing done
Automated tests run successfully (with make run) on my Ubuntu 22.04 computer with latest Docker Desktop installed.
Submitter checklist

[x] Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
[x] Ensure that the pull request title represents the desired changelog entry
[x] Please describe what you did
[x] Link to relevant issues in GitHub or Jira
[x] Link to relevant pull requests, esp. upstream and downstream changes
[x] Ensure you have provided tests - that demonstrates feature works or fixes the issue

@gounthar I'm curious why the updatecli process did not detect that these versions need to be updated as well.  Do we need to monitor these versions separately or is it possible to include them in the updatecli definition?

@gounthar I'm curious why the updatecli process did not detect that these versions need to be updated as well. Do we need to monitor these versions separately or is it possible to include them in the updatecli definition?

@MarkEWaite we're relying on dependabot for these updates.
updatecli on this repo only tracks Debian versions.
Would you like me to add an updatecli manifest for Java?

Please see #1710 .


train and validating without the label from object detection, (add_od_labels = False)

I have been playing with VinVL models for a while. I was trying to evaluate the model without the labels of the object detector. However after training the model with add_od_label set to False, is causing the following problem. I tried to bebug it but I did not manage to find the main cause of the problem. the error is cause by the shape mismat of input_ids at line 807 of modeling_bert.py file. I would approciate for any help regarding training and evaluating VinVL model without the object detection labels.

Traceback (most recent call last):
  File "oscar/run_captioning.py", line 967, in <module>
    main()
  File "oscar/run_captioning.py", line 961, in main
    evaluate_file = evaluate(args, test_dataloader, model, tokenizer, checkpoint)
  File "oscar/run_captioning.py", line 678, in evaluate
    test(args, val_dataloader, model, tokenizer, predict_file)
  File "oscar/run_captioning.py", line 770, in test
    tsv_writer(gen_rows(), cache_file)
  File "/usr/src/app/Oscar/oscar/utils/tsv_file_ops.py", line 17, in tsv_writer
    for value in values:
  File "oscar/run_captioning.py", line 754, in gen_rows
    outputs = model(**inputs)
  File "/miniconda/envs/py37/lib/python3.7/site-packages/torch/nn/modules/module.py", line 1102, in _call_impl
    return forward_call(*input, **kwargs)
  File "/usr/src/app/Oscar/oscar/modeling/modeling_bert.py", line 631, in forward
    return self.generate(*args, **kwargs)
  File "/usr/src/app/Oscar/oscar/modeling/modeling_bert.py", line 806, in generate
    assert input_ids.shape == (batch_size, self.max_seq_len)
AssertionError

The training stage works without any error, but I am having this problem during evaluation stage

Can you tell me how you solved this problem? thank you


VDS-881: Update PRIVATE DEMO

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.5 out of 6 committers have signed the CLA.:white_check_mark: trueboroda:white_check_mark: pushnitsa:white_check_mark: ilyawzrd:white_check_mark: AleksandraBalabanova:white_check_mark: omnidark:x: GitHub ActionsGitHub Actions seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.