Cleanup flag default value

pflag doesn't print default false boolean or default empty string, that seems to be how it works.
I'm fine with this behavior.
@mikebrow WDYT? Do you think we should always add default ourselves for all false boolean or empty stirng?
Signed-off-by: Lantao Liu<EMAIL_ADDRESS>

$ ./cri-containerd --help
Usage of ./cri-containerd:
      --alsologtostderr                    log to standard error as well as files
      --cgroup-path string                 The cgroup that cri-containerd is part of. Empty string means cri-containerd is not placed in a cgroup.
      --config string                      Path to the config file. (default "/etc/cri-containerd/config.toml")
      --containerd-endpoint string         Path to the containerd endpoint. (default "/run/containerd/containerd.sock")
      --containerd-root-dir string         Root directory path where containerd stores persistent data. (default "/var/lib/containerd")
      --containerd-runtime string          The runtime used by containerd. (default "io.containerd.runtime.v1.linux")
      --containerd-runtime-engine string   Runtime engine used by containerd. Empty string means using containerd default.
      --containerd-runtime-root string     The directory used by containerd for runtime state. Empty string means using containerd default.
      --containerd-snapshotter string      The snapshotter used by containerd. (default "overlayfs")
      --default-config                     Print default toml config of cri-containerd and quit.
      --enable-selinux                     Enable selinux support.
      --log_backtrace_at traceLocation     when logging hits line file:N, emit a stack trace (default :0)
      --log_dir string                     If non-empty, write log files in this directory
      --logtostderr                        log to standard error instead of files
      --network-bin-dir string             The directory for putting network binaries. (default "/opt/cni/bin")
      --network-conf-dir string            The directory for putting network plugin configuration files. (default "/etc/cni/net.d")
      --root-dir string                    Root directory path for cri-containerd managed files (metadata checkpoint etc). (default "/var/lib/cri-containerd")
      --sandbox-image string               The image used by sandbox container. (default "gcr.io/google_containers/pause:3.0")
      --socket-path string                 Path to the socket which cri-containerd serves on. (default "/var/run/cri-containerd.sock")
      --stats-collect-period int           The period (in seconds) of snapshots stats collection. (default 10)
      --stderrthreshold severity           logs at or above this threshold go to stderr (default 2)
      --stream-addr string                 The ip address streaming server is listening on. Empty string means using default host interface.
      --stream-port string                 The port streaming server is listening on. (default "10010")
      --systemd-cgroup                     Enables systemd cgroup support.
  -v, --v Level                            log level for V logs
      --version                            Print cri-containerd version information and quit.
      --vmodule moduleSpec                 comma-separated list of pattern=N settings for file-filtered logging

I think we should take it on a case by case basis. It's important that the user/admin can determine what the flags do, and what their default is. If that requires telling them flat out (the default is false) I don't see why hiding that fact from them helps. Same with "" if that means use the containerd default we should tell them flat out (the default is "", containerd will use it's own default when "" is used)

@mikebrow Addressed comments and replied the last 2.

Apply LGTM based on https://github.com/kubernetes-incubator/cri-containerd/pull/294#pullrequestreview-65955502


Movies.json not public available

Describe the bug
Hello,
The readme file contains a Movies.json which is no longer publicly available. Notion blocks the access to the file. Therefore the curl command below in the readme file is no longer valid.
To Reproduce
Steps to reproduce the behavior:

Open README.md
Scroll to "Create an Index and Upload Some Documents"
Click on "this movie database" OR Use the curl download command

Expected behavior
Preview of the file or direct download
Screenshots

Thank you for finding this one out :)

Hello @Skillkiller, sorry for the disappointment, the link is back online. Thanks for the report.

It should be updated with the new movies.json that has the genre field.


shortcuts for toggling service

Description of Change
Added shortcuts for toggling the service features
Disable notifications
Disable audio
Disable dark mode
Disable service
Motivation and Context
#1636
Screenshots

Dark mode enabled with shortcut :

Service Disabled with shortcut

Checklist

[x] My pull request is properly named
[x] The changes respect the code style of the project (npm run prepare-code)
[x] npm test passes
[x]  I tested/previewed my changes locally

@all-contributors - please add @Dee-Bajaj for code

@all-contributors - please add @DarsiSreelekha for code


Faster muting/deafening at stage change

There is an issue regarding lags during the transition between game stages: #48
I too, can see, that sometimes it takes a while for the bot to mute/unmute everyone one by one.
Looking at the code, this is the reason for such "lag":
for (const player of sortedPlayers) {
      await this.updatePlayerMute(player)
}

The bot always waits for one user to be muted until he initiates the muting of the next user.
I can totally see, why you did this, because of the sorted array. You don't want dead players to shortly be able to talk in discussion. To achieve that, you always first muted users one by one, and then unmuted other users one by one.
First of all: the await here did not have any effect, because this.updatePlayerMute(player) and Utils.editMember() didn't even return a Promise.
That's fixed now.
So to be honest, I am not sure, whether this really speeds up the transition, but see for yourself:
Also there is a faster way to do so:
Using the Promise.all() feature in ES6 (no problem with Node.js 12) it is possible to first mute(and deafen) all players, that have to be muted, at once, wait for all of those to finish, and then unmute everyone else.
This way, the bot doesn't have to wait 10 times (for a full round), but only 2 times.
Because of the waiting (not for a timeout, but for everyone to be muted) in between, it is still guaranteed, that no voice is leaked to people not supposed to hear it.

Thanks for your contribution! I'll get to reviewing it when I have some time later this week.
As for that last part about Promise.all:

Using the Promise.all() feature in ES6 (no problem with Node.js 12) it is possible to first mute(and deafen) all players, that have to be muted, at once, wait for all of those to finish, and then unmute everyone else.
This way, the bot doesn't have to wait 10 times (for a full round), but only 2 times.
Because of the waiting (not for a timeout, but for everyone to be muted) in between, it is still guaranteed, that no voice is leaked to people not supposed to hear it.

This probably won't be possible. Another reason why I use await is to intentionally slow down requests to the Discord API, as the "lag" is way worse if we hit the ratelimit (which is super low at 5req/5s) and have to wait for it to reset.

Hi, of course, do it when you have time.
Also I was not aware of those rate limits.
But as I already wrote the await didn't do anything until now. So all the requests to mute were fired at once.
And there weren't much problems, that point to a rate limit being hit, were there? (except that is already what the lag came from? that would require further investigation...)
So I am certain, that adding all my changes won't make the rate limit issue worse than it is now.
However, if you just put in those two returns that pass the Promises from member.edit() over Game.updatePlayerMute() to the setStage() function, then I guess the code would be what you initially intended with the await. So only then the bot would mute everyone one after another. (Best for rate limits, but slower than now)
After all it's up to you to find the right compromise between performance/speed and holding back in order to stay within the rate limits. I don't have enough experience with that to make a qualified decision/recommendation.


BUG: GESDD fails when GESVD succeeds, depends on number of threads

On latest master:
$ make
...
 OpenBLAS build complete. (BLAS CBLAS LAPACK LAPACKE)

  OS               ... Linux
  Architecture     ... x86_64
  BINARY           ... 64bit
  C compiler       ... GCC  (cmd & version : cc (Ubuntu 10.2.0-13ubuntu1) 10.2.0)
  Fortran compiler ... GFORTRAN  (cmd & version : GNU Fortran (Ubuntu 10.2.0-13ubuntu1) 10.2.0)
  Library Name     ... libopenblas_haswellp-r0.3.13.dev.a (Multi-threading; Max num-threads is 8)

Then
$ export OPENBLAS_NUM_THREADS=2
$ python
>>> import numpy as np, scipy.linalg as linalg
>>> linalg.svd(np.loadtxt('204.txt', delimiter=','), lapack_driver='gesdd')
...  # works
$ export OPENBLAS_NUM_THREADS=1
$ python
>>> import numpy as np, scipy.linalg as linalg
>>> linalg.svd(np.loadtxt('204.txt', delimiter=','), lapack_driver='gesdd')
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/home/larsoner/python/scipy/scipy/linalg/decomp_svd.py", line 129, in svd
    raise LinAlgError("SVD did not converge")
numpy.linalg.LinAlgError: SVD did not converge

And also:
>>> linalg.svd(np.loadtxt('204.txt', delimiter=','), lapack_driver='gesvd')
...  # works

So there is something about the combination of using 1 thread with the GESDD driver on this 204x204 array that causes it to fail.

Unusual that a bug would appear in single-threaded mode when there should be less to go wrong. Is "this 204x204 array" available somewhere ? (And are you sure that your numpy actually picked up the 0.3.13 you built, rather than whatever Ubuntu has linked through its alternatives mechanism ?)

Agreed it's weird. Sorry I forgot to upload the problematic file:
204.txt
I make then sudo make installed OpenBLAS on commit b26e32c3af46645a794a6c89e2222e26f6708569 to the default /opt/OpenBLAS, then built NumPy from source with site.cfg as:
[openblas]
libraries = openblas
library_dirs = /opt/OpenBLAS/lib
include_dirs = /opt/OpenBLAS/include
runtime_library_dirs = /opt/OpenBLAS/lib

And it looks like everything is in order:
$ ls -al /opt/OpenBLAS/lib/libopenblas.so
lrwxrwxrwx 1 root root 35 Dec 18 08:38 /opt/OpenBLAS/lib/libopenblas.so -> libopenblas_haswellp-r0.3.13.dev.so
$ ldd numpy/linalg/lapack_lite.cpython-38-x86_64-linux-gnu.so
...
	libopenblas.so.0 => /opt/OpenBLAS/lib/libopenblas.so.0 (0x00007fbd980fc000)
...
$ python -c "import numpy; numpy.show_config()"
blas_mkl_info:
  NOT AVAILABLE
blis_info:
  NOT AVAILABLE
openblas_info:
    libraries = ['openblas', 'openblas']
    library_dirs = ['/opt/OpenBLAS/lib']
    language = c
    define_macros = [('HAVE_CBLAS', None)]
    runtime_library_dirs = ['/opt/OpenBLAS/lib']
blas_opt_info:
    libraries = ['openblas', 'openblas']
    library_dirs = ['/opt/OpenBLAS/lib']
    language = c
    define_macros = [('HAVE_CBLAS', None)]
    runtime_library_dirs = ['/opt/OpenBLAS/lib']
    extra_compile_args = ['-march=native']
lapack_mkl_info:
  NOT AVAILABLE
openblas_lapack_info:
    libraries = ['openblas', 'openblas']
    library_dirs = ['/opt/OpenBLAS/lib']
    language = c
    define_macros = [('HAVE_CBLAS', None)]
    runtime_library_dirs = ['/opt/OpenBLAS/lib']
lapack_opt_info:
    libraries = ['openblas', 'openblas']
    library_dirs = ['/opt/OpenBLAS/lib']
    language = c
    define_macros = [('HAVE_CBLAS', None)]
    runtime_library_dirs = ['/opt/OpenBLAS/lib']
    extra_compile_args = ['-march=native']

And note that I have the same problem with NumPy's linalg calls directly (I just showed SciPy's linalg because it allows switching betwen GESDD and GESVD backends, whereas NumPy just uses GESDD I think):
>>> import numpy as np
>>> np.linalg.svd(np.loadtxt('204.txt', delimiter=','))
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "<__array_function__ internals>", line 5, in svd
  File "/home/larsoner/python/numpy/numpy/linalg/linalg.py", line 1660, in svd
    u, s, vh = gufunc(a, signature=signature, extobj=extobj)
  File "/home/larsoner/python/numpy/numpy/linalg/linalg.py", line 97, in _raise_linalgerror_svd_nonconvergence
    raise LinAlgError("SVD did not converge")
numpy.linalg.LinAlgError: SVD did not converge

Try to import with dtype="double", at least it converges like a charm in R (where all floats are doubles) like svd(read.csv("file.txt",heading=FALSE)$d

@brada4 what CPU do you have, in case it matters? Mine is:
$ cat /proc/cpuinfo | grep 'model name' | uniq
model name	: Intel(R) Core(TM) i7-7700K CPU @ 4.20GHz
$ cat /sys/devices/cpu/caps/pmu_name
skylake

Maybe it's a problem that I end up with a libopenblas_haswellp build given that I'm on Skylake?

I tried on a broadwell E5-2620
Skylake v1 is served by same HASWELL kernels for sure, it has no AVX512 to qualify as SkylakeX
Only thing you need to upgrade microcode at least once in a lifetime on those CPUs to get hyperthreading right:
https://lists.debian.org/debian-devel/2017/06/msg00351.html

Only thing you need to upgrade microcode at least once in a lifetime on those CPUs to get hyperthreading right:

I have never (manually) upgraded CPU microcode -- are you suggesting that this might be causing the bug? From a quick naive search I already have intel-microcode installed and see:
$ sudo dmesg | grep microcode
[    0.000000] microcode: microcode updated early to revision 0xde, date = 2020-05-26
[    0.844975] microcode: sig=0x906e9, pf=0x2, revision=0xde
[    0.870779] microcode: Microcode Update Driver: v2.2.

So I think it might be up to date already?

date = 2020-05-26

It is perfect, lets deal with software bug ;-)

Cannot reproduce this so far with older versions of gcc

Not reproducible here with gcc 10.2 either (Haswell target, python 3.6, numpy 1.14 in a CentOS 8.2 VM on i7-7500U)

numpy 1.14 in a CentOS 8.2 VM

How did you get 1.14 to use latest OpenBLAS master? Did you build 1.14 from scratch for some reason? Or did you pip install it in which case it's probably using the version it shipped with/vendored?
I could try to figure out what version of OpenBLAS 1.14 used (it's almost 2 years old) and try using that version of OpenBLAS. If I also can't replicate there, it would give me at least some path to git bisecting the issue. Is that worth pursuing?

I took their packaged numpy and overwrote the /usr/lib64/libopenblas.so it linked to (0.3.3 or something equally ancient) with my own build of the current develop branch. Will try to find time to retry with a more recent numpy on physical hardware later today

Not reproduced with a recent snapshot of numpy (1.20.0.dev0+08edcad) built from source against current developon Ryzen5-4600H now either.

Can you retry with a more recent snapshot of OpenBLAS please - in particular, the next commit after the one you built - https://github.com/xianyi/OpenBLAS/commit/c73d8ee40ddd9c3f2cc311b7c45955a234a563c4 worked around an oddity
seen with gcc -mfma

On c73d8ee I don't get any error! I also tried latest master and it's fixed there, too. And on 723776ddf784e3b53792c6a5bbb41b3e20cdb06b which preceded 723776ddf784e3b53792c6a5bbb41b3e20cdb06b, it's broken.
Any sense in adding this matrix as a test case? Either way I'll go ahead and close since it's fixed.

On c73d8ee I don't get any error! I also tried latest master and it's fixed there, too. And on 723776ddf784e3b53792c6a5bbb41b3e20cdb06b which preceded 723776ddf784e3b53792c6a5bbb41b3e20cdb06b, it's broken.
Any sense in adding this matrix as a test case? Either way I'll go ahead and close since it's fixed.


TypeScript is broken for working on VSCode

Noticed this since a few days: TypeScript is broken when working on VSCode, I see stale errors, no errors, missing errors, late errors. For example the in-editor errors seem to be disconnect from the overall building errors.

//cc @jrieken

Log output:
[Info  - 10:30:41.463] Starting TS Server
[Info  - 10:30:41.463] Using tsserver from: /Users/bpasero/Development/Microsoft/vscode/node_modules/typescript/lib/tsserver.js
[Info  - 10:30:41.463] <syntax> Log file: /Users/bpasero/Library/Application Support/Code - Insiders/logs/20220610T095408/exthost3/vscode.typescript-language-features/tsserver-log-qUIkQE/tsserver.log
[Info  - 10:30:41.463] <syntax> Forking...
[Info  - 10:30:41.465] <syntax> Starting...
[Info  - 10:30:41.465] <semantic> Log file: /Users/bpasero/Library/Application Support/Code - Insiders/logs/20220610T095408/exthost3/vscode.typescript-language-features/tsserver-log-WVagqo/tsserver.log
[Info  - 10:30:41.465] <semantic> Forking...
[Info  - 10:30:41.466] <semantic> Starting...

The reason seems to be https://github.com/microsoft/vscode/commit/ba66d68c760a9c0e0a05efc5d4169b408866e02b

https://github.com/microsoft/vscode/tree/ben/151828 branch can be used to reproduce:

run default build task in vscode and notice no errors
open src/vs/workbench/browser/parts/editor/textResourceEditor.ts and see errors in editor

Interestingly I think the errors appear briefly and then resolve when looking at the output:

Errors in the editor and "errors on the console" have nothing to do with each other - it's completely different processes. I don't know (please clarify @bpasero) if some task that reports console errors in the editor is used or not..

The reason seems to be https://github.com/microsoft/vscode/commit/ba66d68c760a9c0e0a05efc5d4169b408866e02b

Is that a guess or did you revert and retry? Would be very surprising because the change adds a function that don't (yet) call.

@jrieken yes I did a revert and retried and saw the errors.

🎩 for non-work day prompt fix 🍻

I'm seeing the same issue of stale errors on the latest insider version along with a terrible slowdown of TS completion (15sec+ for getting suggestions to appear) making it unusable.
Don't know if both related but would be keen on trying out a fix when it's available.
Version: 1.69.0-insider
Commit: ab6ba241145bb81c8bc0f323453bbec45fd66109
Date: 2022-06-10T05:16:48.648Z
Electron: 17.4.7
Chromium: 98.0.4758.141
Node.js: 16.13.0
V8: <IP_ADDRESS>-electron.0
OS: Darwin x64 21.4.0


fix: else node of ifblock may be undefined

i got this error,  please check.
TypeError: Cannot read properties of undefined (reading 'children')

Thank you for that


CDN is not available for latest version 1.15.0

The website specifies a CDN with the latest version 1.15.0.
However, the ASPNETCDN does not serve this version, although it is listed on the jquery.validate website.
http://ajax.aspnetcdn.com/ajax/jquery.validate/1.15.0/jquery.validate.js

Excuse me, duplicate: https://github.com/jzaefferer/jquery-validation/issues/1747


Update logging.md

change to ILoggerFactory, works better with integration testing. Just ILogger throws an nullref exception when testing.

Thanks! I made a couple of tweaks based on v4.


line 0, col 0, Bad option: 'esversion'.

Hi there!
I am using jshint v2.8.0 with node v0.12.7 and trying to use the following .jshintrc config file:
{
    "globals": {
        "jQuery": true,
        "d3": true
    },
    "browser": true,
    "boss": true,
    "curly": true,
    "eqeqeq": true,
    "eqnull": true,
    "expr": true,
    "immed": true,
    "noarg": true,
    "quotmark": "single",
    "undef": true,
    "unused": true,
    "esversion": 3,
    "devel":false,
    "jquery": true
}

I am trying to validate a .js file but I always get the error line 0, col 0, Bad option: 'esversion'.
If I remove  "esversion": 3, it works perfectly, but the option "es3" is deprecated.
Thanks in advance,

esversion was introduced in v2.9.0

Thanks, @nicolo-ribaudo . Is any way to get the documentation from other release?

You can browse to the version of which you are looking for documentation (v2.8.0) and read the comments in src/options.js

Thanks a lot, @nicolo-ribaudo.

@ganzux I know that's kind of a hassle; thanks for being a good sport about it. I have hopes that the website will some day serve your use case: https://github.com/jshint/jshint.github.io/issues/29


Env variables undefined with expo 48

Hi,
After upgrading to expo 48, environment variables come undefined on the mobile app but work fine on react-native-web with expo.
I am using babel-loader 9.x.x with expo 48 due to expo 48 upgrading to webpack 5
I have tried .env .env.local .env.production.local and .env.production all are returning me undefined

To test

[ ] expo 48 with babel-loader 8.x.x

Tested and working

[x] expo 48 with babel-loader 8.x.x

this is my start script:
"start:npx-dev": "NODE_ENV=development&& npx expo start --clear"

Other info on variants in expo:

https://docs.expo.dev/build-reference/variants/
eas.json

if you're using another way to configure your NODE_ENV you're going to have to figure it out yourself

relevant


Under certain conditions, link in Moderation screen cannot be tapped

Describe the bug
Under certain combinations of device screen size, text size setting and app language setting, the "Learn more about what is public on Bluesky." link at the bottom of the Moderation screen cannot be tapped.
To Reproduce
Steps to reproduce the behavior:

Use a device with a screen size at the smaller end of the spectrum, such as iPhone 7, iPhone 8 or iPhone SE (1st, 2nd or 3rd generation).
Set Text Size to the default setting or larger.
Open the Moderation screen, scroll down and try to tap the "Learn more about what is public on Bluesky." link at the bottom.
You cannot tap the link.

Expected behavior
The user should be able to tap the link.
Screenshots
https://github.com/bluesky-social/social-app/assets/149612116/4d34e10f-84b9-42a3-8fec-d3fe1ef24b0c
Details

Platform: iOS
Platform version: 15.8.1
App version: 1.66

Additional context
When some languages other than English are set as the app language, this occurs on my iPhone 7 even when Text Size is set at the smallest setting.

This was fixed by #2749, thanks! :)


[Bug]: Hide Thanks button doesn't keep the 'Thanks' button hidden

Describe the bug
When activating the 'Hide Thanks button' - the 'THANKS' button only stays hidden until you refresh the page. After you refresh the page the 'THANKS' button re-appears, despite the actual 'Hide Thanks button' setting itself being activated. This also applies to any other videos you watch as well - the  'THANKS' button is not removed.
Screenshots
No response
What browser are you using?
Mozilla Firefox. Version: 112.0.2 (64 Bit)
What version of AdashimaaTube are you using?
v2.2.6

Updated Firefox to 113.0.1 and the 'Thanks' button not staying hidden remains.

I think the "thanks" button on your account has a different SVG path. Could you right-click the thanks button, select inspect and copy and paste in this issue?

After right-clicking the "thanks" button and then selecting "inspect" via the 'Search HTML' field I typed: path.style-scope.yt-icon and this is what was highlighted in blue:

let me know if this update works for you.

https://github.com/sapondanaisriwan/AdashimaaTube/raw/master/AdashimaaTube.user.css

Please let me know if this update works for you.

I tried reinstalling the style with that updated version of AdashimaaTube by overwriting but sadly it's still not working with the permanent removal of the 'THANKS' button.

sapondanaisriwan  upon further investigation I've worked out that what is preventing the 'THANKS' button from actually staying hidden has to do with the uBlock Origin web browser ad blocking extension. When enabling the AdGuard add-on for the YouTube website the 'THANKS' button is indeed removed from sight (as it should be).
Would you happen to know what I need to configure within the uBlock Origin add-on itself to get it to cooperate with the removal of the 'THANKS' button for your AdashimaaTube styles?

Closing this because I found a uBlock Origin filter that successfully keeps the 'THANKS' button element removed from the UI. Thank you for your assistance sapondanaisriwan and keep up the amazing work you are doing with  AdashimaaTube. YouTube has never looked or functioned this good with how highly customizable the style is. I've blended elements from the old UI and new UI and couldn't be happier.


Expose a hook for tests to wait for outstanding UiRequest to be finished

#145 and #146 should sufficiently deflake our test suite that I don't think we need this (which wouldn't necessarily improve the flakiness).


html/svgelement_test/PathElement fails on Chrome

Started with the update to Chrome 48 on all platforms.
Currently suppressed in status file tests/html/html.status
Error is:
Expectation:

                                  PathElement pathSegList
                                .

Test failed: Caught NullError: method not found: 'get$iterator' on null

http://<IP_ADDRESS>:60863/root_build/generated_compilations/dart2js-sdk/tests_html_svgelement_test/test.js 1739:166  main__closure.dart.main__closure.call$0
                    http://<IP_ADDRESS>:60863/root_build/generated_compilations/dart2js-sdk/tests_html_svgelement_test/test.js 17928:35  InternalTestCase.dart.InternalTestCase._testFunction$0

Test was obsolete, API removed. Fixed in https://codereview.chromium.org/2902973004/
(by deleting that particular test)


storage: fix minor typo

lgtm

Found one more lexicograph -> lexicographical. Will merge in green lights.
Thanks.

just merged. CI will not help on this kind of fix. :)

right. thanks.


Change 'arrowParens' style to default ('always')

[x] tests and linter show no problems (npm t)
[x] code is properly formatted (npm run fmt)

Landed in https://github.com/metarhia/do/commit/3023b62cb331b4c985527aa77c137483e8b7b6c3


Revert "Add block completion if notification dismissed"

Reverts liufengting/FTIndicator#2
It appears you havn't finish it. I will finish this.

I have finished it.


feat: Have ExecutionManager pass data up

Description
Ensures that OVM_ExecutionManager will pass data upwards. Also modifies OVM_ProxyEOA and OVM_SequencerEntrypoint to pass data upwards and out of the EM.
Additional context
Vastly simplifies the process of giving users relevant return data in Geth. Cuts a lot of code out of evm.go.
Metadata

Fixes roadmap728

Tests might fail, will fix if they do. Want CI to run in the background while I work on some other stuff.

@smartcontracts Can you confirm that this PR is fully backwards compatible?

@smartcontracts Can you confirm that this PR is fully backwards compatible?

I do not think this PR is fully backwards compatible. So we're going to have to keep this one open for a little.


Fix the arrow head on Preset Colour Canvas Arrows

This issue should now be addressed in version 3.2.0.


Strange behavior of topic configuration update

Say you define the following options
options:
    retention.ms: 66574936
    flush.ms: 564939

in your playbook.yml and update the topic configuration.
 So you update your playbook.yml
options:
    retention.ms: 66574936

and perform an update of the topic configuration. Since is_topic_configuration_need_update() checks only the given options it returns False. Therefore update_topic_configuration() will not be called and the value of flush.ms is retained.
Later you modify the retention.ms
options:
    retention.ms: 574936

and perform another update of the topic configuration. Now is_topic_configuration_need_update() returns True and update_topic_configuration() changes the value of retention.ms and resets the value of  flush.ms.
Was this behavior intentional?

Hello,
Thanks for your question.
I may have misunderstood the Kafka protocol since it seemed to me that the AlterConfigs API will only update the given config entries and unchange the others.  Currently this library does not handle the case when a topic configuration is deleted, I totally have to look into this but if you have some time, feel free to submit a PR :)
I come back to you after I do some tests

Thank you for your quick reply. I'm looking forward to your test results.

Due to KIP-248 there is currently an AlterConfigs version 1 in discussion which shall allow incremental operations (set/add/delete) on configs. The AlterConfigs version 0 protocol sets the whole properties object.

You are totally right about the behaviour which was not intented as if. I just created a PR to fix that and better handle topics options (https://github.com/StephenSorriaux/ansible-kafka-admin/pull/4)
I am now using Zookeeper to manager topics options but I will add AlterConfigs version 1 when it will be out.
Feel free to give it a try and send me a feedback. I might merge the PR next week.

Great! I will try it and give you feedback. Thanks!

I reviewed and tested it: it looks good to me.

Thank you, PR's merged!


No response  about application status for becoming a mentee.

I haven't received yet an answer about a mentee application. Please answer me about my application.

Hello, @slim-hmidi.
Thank you for requesting to join the Node.js Mentorship program of the Node.js project. As you likely already know, Node.js collaborators are all volunteers. We are at the beginning stages of this program. We are currently working with our first group of Mentors to get them setup. Once that work is complete, we will begin onboarding Mentees.
In the interim you're invited to join fellow Mentors and Mentees in the #mentorship channel of the Node.js Slack.


Images should not have meaningful names in fields

Images in the documentation should not have meaningful name or expose user information.

Fixed


Export supported function

Export the supported function to be used when there is the need to check whether the FS Access API is supported.

@googlebot I signed it!

hey @kbariotis , i created another PR for the same issue, i even tested it on excalidraw (inside iframe), i am just checking if we are within a third part environment and returning false in supported function. this will not need any change in excalidraw code base i guess.
also if you feel my approach can work, can you please close this PR and maybe let my PR get merged, as it is kindoff a small dream for a college student like to get a PR merged in some well well used repo :)

I’ll have a look on Monday (since this is a work project) and merge this. Thanks for the PR.


Optimizations

Many things.
1 - Slightly updated menu for loadout selection hotkeys (there's 3 choices now + off).
2 - Energy center optimizations (half the updates, only 20% of the sound cues)
3 - Multisound SFXCues now only calculate occlusion linecasts for the first cue and reuse it for the others.
4 - Directional homing sounds now only calculate their position when the sound actually plays rather than -every frame for every projectile- (oops).
5 - Fully removes the AudioLowPassFilter objects when AudioOcclusion is turned off and adds them back in if it's re-enabled.
I don't see a specific conflict that's breaking auto-merge, but you can likely see it from your side. What's got it stuck?

Oh now it shows me what it considers "broken".

@CCraigen This is off a really old version.  Remember to branch from origin/master before working on new stuff.
In the meantime, you'll have to rebase this branch on origin/master to get the merge conflicts to go away.

Not merging this one, the followup got merged instead.


Fix #722

Description
This resolve an inconsistent use of attributes.
Issues Resolved

#722

Check List

[ ] All tests pass. See https://github.com/chef-cookbooks/community_cookbook_documentation/blob/master/TESTING.MD
[ ] New functionality includes testing.
[ ] New functionality has been documented in the README if applicable
[ ] All commits have been signed for the Developer Certificate of Origin. See https://github.com/chef-cookbooks/community_cookbook_documentation/blob/master/CONTRIBUTING.MD

Already fixed in https://github.com/chef-cookbooks/chef-client/pull/727


add ENV PATH, fix the problem of docker-compose exec workspace npm(or…

add ENV PATH for node(nvm),
fix the problem of "docker-compose exec workspace npm(or other node-related script)".
I am a newbie for contributing, Hope these commit help.

@WanchiaTsai Thanks for the fix. Is there any Issue I should close after merging this?

@Mahmoudz, threre is not. thanks.


Typo: "For any values of A, C and C"

Should
https://github.com/riscv/riscv-bitmanip/blob/24df418713a524628d53f87c7cd3cc415eb18064/texsrc/bext.tex#L1176
In fact read  "For any values of A, B and C"?

Oops. Thanks for reporting this.


ci: sync is failing

Describe the bug
The CI is failing to update
Steps To Reproduce
run workflow
Expected behavior
CI updates successfully
Screenshots

Additional context
logs

Add a :+1: reaction to issues you find important.

I believe the fix is changing the command to git remote add fork url

New issue log

My git fu is not great enough to solve this one.

I couldn't verify (it's 00:51 here) but I think that if you add a remote that has commits (nixpkgs certainly does ._.) on a repo that also has commits (this fork), you can't merge them together because git can't know if the diffs have anything to deal with each other (e.g. you could add curl's git as a remote on a local nixpkgs clone and naively try to merge two branches from them). Even if they actually come from the same root, or maybe even if they're exact but-to-bit dupplicates (idk).
There's a --allow-unrelated-history flag for git merge and rebase iirc, but I don't remember when it's safe to use.

So after a bit of discussion with some other contributors, the solution we went for was force pushing to master our changes and to clean the reflog. Hopefully, next time the CI runs we shall know if it works.

So after a bit of discussion with some other contributors, the solution we went for was force pushing to master with our changes. This would clean the reflog and hopefully next time the CI runs we shall know if it works.

Seem the issue still persists log

I have a crazy idea. I think actions/checkout@4 is the reason the action is failing because it fetches with a depth of 1 by default.

You're on the money, checkout does default to not fetching the history because it's slow and often unnecessary for typical CI jobs. Adding fetch-depth: 0 will force it to fetch the full history and should fix the sync job.


Enable native interactive window for VS Code Insiders users who have Python Insiders Daily or Weekly channel

Codecov Report

Merging #6550 (a016439) into main (db93306) will decrease coverage by 0%.
The diff coverage is 100%.

:exclamation: Current head a016439 differs from pull request most recent head 887a3e0. Consider uploading reports for the commit 887a3e0 to get more accurate results

@@          Coverage Diff           @@
##            main   #6550    +/-   ##
======================================
- Coverage     69%     69%    -1%
======================================
  Files        410     410
  Lines      28248   28259    +11
  Branches    4190    4193     +3
======================================
- Hits       19766   19628   -138
- Misses      6829    6967   +138
- Partials    1653    1664    +11

Impacted Files
Coverage Δ

src/client/datascience/serviceRegistry.ts
96% <100%> (+<1%)
:arrow_up:

...ience/variablesView/variableViewMessageListener.ts
22% <0%> (-78%)
:arrow_down:

...ent/common/application/webviewViews/webviewView.ts
14% <0%> (-72%)
:arrow_down:

...c/client/datascience/variablesView/variableView.ts
18% <0%> (-62%)
:arrow_down:

src/client/datascience/webviews/webviewViewHost.ts
19% <0%> (-53%)
:arrow_down:

...on/application/webviewViews/webviewViewProvider.ts
80% <0%> (-20%)
:arrow_down:

.../datascience/variablesView/variableViewProvider.ts
65% <0%> (-16%)
:arrow_down:

...lient/datascience/variablesView/notebookWatcher.ts
80% <0%> (-13%)
:arrow_down:

src/client/datascience/webviews/webviewHost.ts
80% <0%> (-7%)
:arrow_down:

src/client/common/application/webviews/webview.ts
67% <0%> (-6%)
:arrow_down:

... and 20 more

I'm a little nervous that 'single' and 'perFile' mode for IW doesn't work exactly right. This is turning this on for everybody right? Not just insiders?

@rchiodo It's just everyone in Insiders for now since these bits aren't going to Stable customers.


Use ruby 3.2.3

Upgrade bundled ruby from 3.2.2 to 3.2.3
There are some backported fixes such as:
Bug #20096: Ruby 3.2.2 win32/registry: Junk appended to Windows Registry String Value

Note: That bug of Ruby 3.2.2 influences --reg-winsvc-fluentdopt.
Garbage data can be included at the end of fluentdopt.
The possible damage to Fluentd is not yet certain.

Note: That bug of Ruby 3.2.2 influences --reg-winsvc-fluentdopt. Garbage data can be included at the end of fluentdopt. The possible damage to Fluentd is not yet certain.

#619

It will be fixed by using Ruby 3.2.3.
There is NO problem with Fluentd's behavior, so it seems less urgent.

Fixed via #626


Automate certification & introduce basic structure

As a user of this gem,
I want to be able to send cert API requests,
So that I can certify my app(s) with Vantiv.
Basically, I've run through most of the Vantiv DevHub API in Paw, by going through their certification tests. These tests require the user to run requests on all the features an app would use (authorization, capture, etc..) with different payloads (e.g. running auths on valid accounts, invalid cards, accounts with no funds, etc..) to verify that the user is running correct requests.
In this P.R. I want to introduce a structure to automate running these requests. This will also get me an initial (if incomplete and suboptimal) API for the gem to run:

Auths
Captures (of auths)
Auth Reversals
Auth_captures (vantiv calls these Sales)
Voids
Refunds (vantiv calls these "Returns and Credit")

I think that will be a good starting point to then start to change the API of the gem in the context of using it in an application.

This PR is pretty much ready to merge. So far, the requests that are possible to run, and that have been validated inside the Vantiv DevHub for their structure, are:

Auth
Capturing Auths
Reversing Auths
Sales (auth_capture)
Credits (refunds on captures/sales)
Returns (refunds on an account independent of prior txns)
Voids (of credits)

Still need to add the ability to take a paypage registration ID and convert it to a permanent PaymentAccountID, as well as test the above requests using just PaymentAccountID's rather than sending raw credit card data. But these features are being tweaked by Vantiv for use in the DevHub, so they can come individually afterward.

Also the script to run the Cert API requests is a little messy, but I think a better time to refactor that is once we start refactoring the API for use inside a real application. At that point it will be more clear where things fit.


StatefulsetAutoDeletePVC default value update

default valye for StatefulsetAutoDeletePVC  has been changed to true in 1.27

fixes: #43976
/language en

@mengjiao-liu @nate-double-u Can you PTAL?

You are right. Thanks for the catch!
refer to:
https://github.com/kubernetes/kubernetes/pull/116501
/lgtm

The section on page https://kubernetes.io/docs/concepts/workloads/controllers/statefulset/#persistentvolumeclaim-retention should be modified because the StatefulSetAutoDeletePVC feature is enabled by default.
You must enable the
`StatefulSetAutoDeletePVC` [feature gate](/docs/reference/command-line-tools-reference/feature-gates/)
on the API server and the controller manager to use this field.
Once enabled, there are two policies you can configure for each StatefulSet:

/cc @sftim  WDYT?

The page https://kubernetes.io/docs/reference/kubernetes-api/workload-resources/stateful-set-v1/ also exist the issue,but the page needs to modify the upstream kubernetes code .
@kundan2707 Do you want to work on this?  If you don't have time, I can do this.

@mengjiao-liu i will work and update it.

Hello @kundan2707 : Please could you advise if you're working on updating the upstream code?

@divya-mohan0209 yes i am working and will update upstream code too.

updated upstream code related to this
https://github.com/kubernetes/kubernetes/pull/123070

This wont work as the shortcode-based rendering is merged.
/close


Install Quickstart did not work

Bug Report

What did you do?
Attempted to install OLM via the installation guide on a native kubernetes cluster verison 1.15.12.
What did you expect to see?
Custom resources deploy when I ran
kubectl create -f deploy/upstream/quickstart/crds.yaml
What did you see instead? Under which circumstances?
unable to recognize "deploy/upstream/quickstart/crds.yaml": no matches for kind "CustomResourceDefinition" in version "apiextensions.k8s.io/v1"
unable to recognize "deploy/upstream/quickstart/crds.yaml": no matches for kind "CustomResourceDefinition" in version "apiextensions.k8s.io/v1"
unable to recognize "deploy/upstream/quickstart/crds.yaml": no matches for kind "CustomResourceDefinition" in version "apiextensions.k8s.io/v1"
unable to recognize "deploy/upstream/quickstart/crds.yaml": no matches for kind "CustomResourceDefinition" in version "apiextensions.k8s.io/v1"
unable to recognize "deploy/upstream/quickstart/crds.yaml": no matches for kind "CustomResourceDefinition" in version "apiextensions.k8s.io/v1"

Environment

operator-lifecycle-manager version:

release 4.7

Kubernetes version information:
kubernetes version 1.15.12

Kubernetes cluster kind:
native kubernetes
Possible Solution
Not sure what kubernetes version openshift is testing against?

Additional context
could be an api version difference? That should probably be noted in the install guide if that is the case?

same here, running k3s 1.18.4

Off the top of my head, I believe the v1 APIVersion of CRDs was introduced in kube 1.16? So installing v1 CRDs onto a 1.15 cluster would cause the issue you're seeing.
We have upgraded the OLM CRDs to v1 since we are always rebasing off upstream kube, but this raises a fair point of how to install/support OLM on pre-1.16 clusters. Ideally we would have some sort of backwards-compatibility here.


Python.docx is currently not readable by Word.

Python.docx, the document with all topics for the presentations, is currently only available as ~$Python.docx, which is a temporary file that cannot be read by Word.
It would be great if the document could be replaced with the correct document!

Thank you for the hint. I must have deleted it by mistake. I've re-uploaded it.


Add coverage climate

:tada: This PR is included in version 1.0.2 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


OCPEDGE-746: feat!: Micro LVMS - Edge / Low Resource Optimized LVMS

Codecov Report

Merging #533 (50d1252) into main (717528e) will decrease coverage by 0.06%.
The diff coverage is 65.21%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #533      +/-   ##
==========================================
- Coverage   82.10%   82.04%   -0.06%
==========================================
  Files          24       24
  Lines        1788     1816      +28
==========================================
+ Hits         1468     1490      +22
+ Misses        219      215       -4
- Partials      101      111      +10

Files
Coverage Δ

internal/cluster/namespace.go
100.00% <ø> (ø)

internal/controllers/vgmanager/devices.go
81.73% <100.00%> (-0.16%)
:arrow_down:

internal/controllers/vgmanager/lvm/lvm.go
100.00% <100.00%> (ø)

internal/controllers/vgmanager/wipefs/wipefs.go
87.50% <100.00%> (+0.83%)
:arrow_up:

internal/controllers/lvmcluster/controller.go
63.23% <0.00%> (+0.25%)
:arrow_up:

internal/controllers/vgmanager/dmsetup/dmsetup.go
70.00% <20.00%> (-12.36%)
:arrow_down:

internal/controllers/vgmanager/filter/filter.go
79.66% <57.14%> (+6.13%)
:arrow_up:

internal/controllers/vgmanager/status.go
81.81% <56.00%> (+1.11%)
:arrow_up:

internal/controllers/vgmanager/controller.go
74.87% <44.44%> (-1.99%)
:arrow_down:

/test snyk-code

/lgtm

/retest

/lgtm


Update uws.js - just a suggestion

This is just a suggestion. You've chosen to wrap http.Server within another class. As a suggestion, instead of doing what you did (wrapping http.Server in a class and having http.Server as a field in your class)... instead, create a function, and return a new http server from the function; I personally find that even cleaner than composition. If you really need to embellish http.Server, then extend http.Server instead of extending EventEmitter. IDK, just a thought.

Correct we need to account for when cb is not defined, let me fix it, I
havent tested it
On Jan 27, 2017 4:55 PM, "Alex Hultman"<EMAIL_ADDRESS>wrote:

@alexhultman commented on this pull request.
In nodejs/dist/uws.js
https://github.com/uWebSockets/uWebSockets/pull/413:

@@ -439,9 +439,15 @@ class Server extends EventEmitter {

     if (options.port) {
         if (options.host) {

           this.httpServer.listen(options.port, options.host, callback);

           this.httpServer.listen(options.port, options.host, () => {

What happend when callback is undefined?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/uWebSockets/uWebSockets/pull/413, or mute the thread
https://github.com/notifications/unsubscribe-auth/AKn56KHYRhhdhZl1GgjQE9f6DQy0W2_0ks5rWpIYgaJpZM4LwXIb
.

I am 99% certain that the callback takes no arguments


Cannot start hyper with fish shell

[x] I am on the latest Hyper.app version
[x] I have searched the issues of this repo and believe that this is not a duplicate

OS version and name: Ubuntu 16.04.2 LTS Xenial
Hyper.app version: 1.3.3
Link of a Gist with the contents of your .hyper.js: https://gist.github.com/jvrdom/5a84f6b24cf674fbe25b92dde3254b79
Relevant information from devtools (CMD+ALT+I on Mac OS, CTRL+SHIFT+I elsewhere): When run the app in dev console appears:

Uncaught TypeError: Cannot read property 'substr' of null on conditional
if ('rgba' == I.substr(0,4)) on function N.colors.crackRGB.

The issue is reproducible in vanilla Hyper.app: No, with vanilla works fine. It happens with some plugins, in my case with those:

hypercwd
hyper-statusline
hyper-material-box
hyper-pane

Issue
When in my config set the shell to "/usr/bin/fish" and run the app, no cursor appears and i can't do anything, but if i ran /usr/bin/fish as a command work perfectly.

If it works in vanilla, then it’s one of your plugins. Can you narrow it down to which one and post your issue there? I beleive this is not an issue with hyper itself as it works without plugins.

@albinekb Thanks for the quick response, I try the plugins one at a time and the error happens, so I have to post an issue in every plugin :sweat_smile:
Thanks!

@jvrdom Instead of posting in issue in every plugin, try and isolate the plugin that causes the issue and then post an issue to that plugin.

I'm on latest Hyper version (1.4.3) on Ubuntu GNOME 16.04 with latest Fish shell (2.6.0-1~xenial), and I'm experiencing this same issue 100% of the time:
Uncaught TypeError: Cannot read property 'substr' of null
    at Object.t.colors.crackRGB (bundle.js:47)
    at Object.t.colors.mix (bundle.js:47)
    at r.TextAttributes.syncColors (bundle.js:47)
    at r.TextAttributes.setDefaults (bundle.js:47)
    at r.VT.CSI.m (bundle.js:47)
    at r.VT.dispatch (bundle.js:47)
    at r.VT.parseCSI_ (bundle.js:47)
    at r.VT.interpret (bundle.js:47)
    at r.Terminal.interpret (bundle.js:47)
    at l.forEach (bundle.js:41)

Please reopen the issue.

I just forked the repository, cloned, installed deps and ran Hyper in dev mode. Weirdly enough, it's working fine. Then I built the binaries and installed the .deb file through dpkg and the issue is back! (I made sure to purge the old Hyper installation before installing the generated deb file)
So it seems to be an issue in the build process, likely in the minifier or bundler.

I've removed babel from the dist script and the error persists... I've also removed NODE_ENV=production from the build script and the issue still persists:
Uncaught TypeError: Cannot read property 'substr' of null
    at Object.lib.colors.crackRGB (bundle.js:35116)
    at Object.lib.colors.mix (bundle.js:35098)
    at hterm.TextAttributes.syncColors (bundle.js:48690)
    at hterm.TextAttributes.setDefaults (bundle.js:48631)
    at hterm.VT.CSI.m (bundle.js:50974)
    at hterm.VT.dispatch (bundle.js:49503)
    at hterm.VT.parseCSI_ (bundle.js:49351)
    at hterm.VT.interpret (bundle.js:49262)
    at hterm.Terminal.interpret (bundle.js:46351)
    at __WEBPACK_IMPORTED_MODULE_2_runes___default.forEach.rune (bundle.js:34316)

So the issue is either in the electron-builder or perhaps I'm missing something.

I've been trying to run Hyper from the AppImage now, and I noticed that sometimes (rarely) it does not throw an error and works as expected. It's most likely due to a race condition in the app startup logic.

At hterm.TextAttributes.prototype.setDefaults, both received arguments (foreground, background) are null. Perhaps the issue is in the hterm dependency?

Tried to update the hterm-umdjs dependency to the latest published version (1.2.0 which wraps hterm 1.63.sha.a543c06) as well as building hterm-umdjs with the latest hterm (1.71.sha.a3b8fec) and this issue is still not fixed... At least the error looks different (but still the same problem) 😅
Uncaught TypeError: Cannot read property 'startsWith' of null
    at Object.t.colors.crackRGB (bundle.js:47)
    at Object.t.colors.mix (bundle.js:47)
    at r.TextAttributes.syncColors (bundle.js:47)
    at r.TextAttributes.setDefaults (bundle.js:47)
    at r.VT.CSI.m (bundle.js:47)
    at r.VT.dispatch (bundle.js:47)
    at r.VT.parseCSI_ (bundle.js:47)
    at r.VT.interpret (bundle.js:47)
    at r.Terminal.interpret (bundle.js:47)
    at l.forEach (bundle.js:41)

🤔
Can you try this with xterm branch ?

Did you try to remove all your plugins?

Did you try to remove all your plugins?

Yes, I was using a clean install without any plugins.

Can you try this with xterm branch ?

Sure, I'll try tonight.

I've just checked out the xterm branch and built the .deb package, Hyper starts fine with fish now! Thanks @chabou 😄
Though, I noticed there's are issues with vertical split panes in the xterm branch with fish. This is a different issue though, so I'll report it separately.
Just wondering, is there a tracking issue or roadmap to merge xterm branch into master?

@UltCombo Not yet, but we really want to put xterm on Canary update channel ASAP
🔜


Refactor gpu test to use RunIf

What does this PR do?

While working on #12590, came across this test.
Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

[ ] Was this discussed/approved via a GitHub issue? (not for typos and docs)
[x] Did you read the contributor guideline, Pull Request section?
[x] Did you make sure your PR does only one thing, instead of bundling different changes together?
[ ] Did you make sure to update the documentation with your changes? (if necessary)
[ ] Did you write any new necessary tests? (not for typos and docs)
[x] Did you verify new and existing tests pass locally with your changes?
[ ] Did you list all the breaking changes introduced by this pull request?
[ ] Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

[x] Is this pull request ready for review? (if not, please submit in draft mode)
[x] Check that all items from Before submitting are resolved
[x] Make sure the title is self-explanatory and the description concisely explains the PR
[x] Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?
Make sure you had fun coding 🙃
cc @borda @akihironitta

Is this because of something I did?
Sent from Yahoo Mail for iPhone
On Monday, April 4, 2022, 09:35, Kaushik B @.***> wrote:
@kaushikb11 commented on this pull request.
In tests/trainer/test_trainer.py:

 num_gpus = torch.cuda.device_count()

Trainer(**trainer_options, accelerator="gpu", devices=num_gpus, auto_select_gpus=True)

Trainer(default_root_dir=tmpdir, accelerator="gpu", devices=num_gpus, auto_select_gpus=True)

yup, updated!
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.Message ID: @.***>


TypeError: multiple values for argument 'cfg_name'

When running nbdev_test_notebook locally and in CI, I get the following error:
Traceback (most recent call last):
  File "/home/jakub/miniconda3/envs/e39/bin/nbdev_test_nbs", line 8, in <module>
    sys.exit(nbdev_test_nbs())
  File "/home/jakub/miniconda3/envs/e39/lib/python3.9/site-packages/fastcore/script.py", line 105, in _f
    tfunc(**merge(args, args_from_prog(func, xtra)))
  File "/home/jakub/miniconda3/envs/e39/lib/python3.9/site-packages/nbdev/test.py", line 109, in nbdev_test_nbs
    files = nbglob(fname)
  File "/home/jakub/miniconda3/envs/e39/lib/python3.9/site-packages/nbdev/export.py", line 409, in nbglob
    if recursive == None: recursive=get_config().get('recursive', 'False').lower() == 'true'
  File "/home/jakub/miniconda3/envs/e39/lib/python3.9/site-packages/nbdev/imports.py", line 29, in get_config
    config = Config(cfg_path, cfg_name=cfg_name)
TypeError: __init__() got multiple values for argument 'cfg_name'

Given that the entire stacktrace seems to happen outside of my workdir it looks like a bug in nbdev. I have tried 1.1.14 and 1.1.16. When running around in debugger, it is a bit hard to determine where exactly this comes from as
 Config.__file__
*** AttributeError: 'functools._lru_cache_wrapper' object has no attribute '__file__'

And there's so many "*" imports, it is tricky to determine where exactly it all comes from.

Same here,
For the workaround, you can edit this file:
From
config = Config(cfg_path, cfg_name=cfg_name)

To
config = Config(cfg_name)

Hi,
I faced the same issue: CI did stop working because of
TypeError: __init__() got multiple values for argument 'cfg_name'.
I did rerun an old CI run which previously was successful and now stopped working.
After checking the logs, I noticed that there is a new fastcore version. In the requirements.txt I had fastcore version pinned to 1.3.19. Now after changing the requirements to fastcore==1.3.21 CI is running through again.

Hi both, @sakinaljana your fix has worked, but I think the trick has really been to get the versions of fastcore and nbdev to align as @straussmaximilian said.


Crash when using error log

Expected behavior
An error log prints in the debugger.
Actual behavior

Xcode crash
Firstly: the macOS App runs but does not appear (icon in dock but window not open).
Secondly: CMD+R again to re-run causes Xcode to eventually crash.

Steps to reproduce
import Logging

struct Hello: LogHandler {

    var metadata: Logging.Logger.Metadata = [:]

    var logLevel: Logging.Logger.Level = .error

    init(_ label: String) {
    }

    public subscript(metadataKey metadataKey: String) -> Logger.Metadata.Value? {
        get {
            return self.metadata[metadataKey]
        }
        set(newValue) {
            self.metadata[metadataKey] = newValue
        }
    }
}

@main
struct TestApp: App {

    init() {
        LoggingSystem.bootstrap(Hello.init)
    }
...
}

struct ContentView: View {

    var body: some View {
        Text("Hello, World!")
            .onAppear {
                let log = Logger(label: "unique.value")
                log.error("hi")
            }
    }
}

SwiftLog version/commit hash
SHA-1: dc77805fdcb4ebcc5b5897ff99f98e3e518a431d
Swift & OS version (output of swift --version && uname -a)
swift-driver version: 1.62.15 Apple Swift version 5.7.1 (swiftlang-<IP_ADDRESS>.3 clang-14<IP_ADDRESS>)
Target: arm64-apple-macosx13.0
Darwin Roberts-Personal-MacBook-Pro.local 22.1.0 Darwin Kernel Version 22.1.0: Sun Oct  9 20:14:30 PDT 2022; root:xnu-8792.41.9~2/RELEASE_ARM64_T8103 arm64
Xcode Version 14.1 (14B47b)

Removing bootstrap fixes the issue
// LoggingSystem.bootstrap(Hello.init)

The documentation states that bootstrap must be called once, else a crash.
Using a singleton resolves this issue.
final class Client {

    static let shared = Hello("Log")

    private init() {
        LoggingSystem.bootstrap(Hello.init)
    }
}

@main
struct TestApp: App {

    init() {
        _ = Client.shared
//        LoggingSystem.bootstrap(Hello.init)
    }

It might be worth adding some code to display a clear error message for this.

This is the same as https://github.com/apple/swift-log/issues/248 isn't it?
Your LogHandler implementation is incomplete, you must implement a log method for it to work; Please check https://github.com/apple/swift-log/issues/248 for details.


Project does not build when this library is included

Gradle build error, when this library is included. (KMM Project)
After a gradle clean, the app runs again - but if I try to run it again, it shows this error.

If any further information is needed, please let me know 😄

Gradle build error, when this library is included. (KMM Project) After a gradle clean, the app runs again - but if I try to run it again, it shows this error.

If any further information is needed, please let me know 😄

@edlingem did you found a solution or work around? I am facing similar issue.

Hi, could you create a sample project that would recreate the issue? That would help with fixing the problem. Thanks!


[BACKLOG-23109] Change default QoS value to match client default.

Build Completed
:white_check_mark: This pull request has passed all validations.
Build Commands
mvn -B -f 'pom.xml' -pl 'plugins/streaming/impls/mqtt' -P '!assemblies' -Dsurefire.runOrder=alphabetical -Daudit -amd clean install

Cleanup Commands
mvn -B -f 'pom.xml' -pl 'plugins/streaming/impls/mqtt' -P '!assemblies' -amd build-helper:remove-project-artifact

Changed files
  plugins/streaming/impls/mqtt/src/main/java/org/pentaho/di/trans/step/mqtt/MQTTClientBuilder.java


[GSK-2153] removing mlruns artifacts file produced by pytest

very marginal improvement
this is what I get before:
tests/integrations/test_mlflow.py::test_fast[drug_classification_data-drug_classification_model],166.398,593.125
tests/integrations/test_mlflow.py::test_fast[diabetes_dataset_with_target-linear_regression_diabetes],14.398,607.559
tests/integrations/test_mlflow.py::test_fast[hotel_text_data-hotel_text_model],233.000,840.559
3:25
this is after a fix:
tests/integrations/test_mlflow.py::test_fast[drug_classification_data-drug_classification_model],177.035,600.938
tests/integrations/test_mlflow.py::test_fast[diabetes_dataset_with_target-linear_regression_diabetes],14.121,615.059
tests/integrations/test_mlflow.py::test_fast[hotel_text_data-hotel_text_model],227.391,842.480
3:25
basically the file that was used to be produced weighs
860K    mlruns

It seems our hypothesis was wrong @rabah-khalek @Hartorn:
mlflow.exceptions.MlflowException: Could not find a registered artifact repository for: c:\Users\RUNNER~1\AppData\Local\Temp\tmpeieeqloy/da1d290ebe524d5e812f8fb5d02697b9/artifacts

:(

it's working now


Avoid adding acronyms to ActiveSupport::Inflector

Due to https://github.com/rails/rails/issues/17879 and https://github.com/rwz/ember-cli-rails/blob/master/lib/ember-cli/engine.rb#L5 we started seeing addresses in our system render as
123 Example Street, North CLI Ffe WA

Instead of
123 Example Street, NORTHCLIFFE WA

... when we used .titleize or similar.
The fact that ember CLI rails had defined something that changes global state in this way entirely non-intuitive; at least when you expect this to be a self contained library. This should be something that users of the gem opt into; or contained to only the code that requires it - IE; introducing a wrapper function that is aware of the few places this is needed would be a better approach.

This behavior and global state leakage is unacceptable. We'll look into this.
Thank you for bringing this to our attention.

@CloCkWeRX would you mind verifying a potential fix for this issue?
Please update your Gemfile:
# Gemfile
gem "ember-cli-rails", github: "thoughtbot/ember-cli-rails", branch: "sd-remove-inflection"

Then try to reproduce the improperly inflected title.

@CloCkWeRX I've merged that branch, could you retry with master:
# Gemfile
gem "ember-cli-rails", github: "thoughtbot/ember-cli-rails"

Seems happy.


Show logo during startup

🚀 Feature
Right now napari takes a long time to launch the viewer. People can get discouraged as they wait, unsure if napari is loading, or if their data is loading, or if it is just hanging. Showing the napari logo, possibly with / without some text during that time might make it feel better.

Just to clarify here: I think we should only do this in __main__ or even only in the bundled app. It would be very jarring to have this happen when launching from an IPython session. The correct solution for IPython is to dramatically reduce the startup time. To reiterate what I mentioned in the meeting, startup time from the command-line is about 2s on Linux, which is reasonably fast. There's nothing fundamentally slow about our startup, and we need to check what's happening on mac to make it so slow.

We can do it in bundled app with a runtime-hook which will be executed right before execution of our main entry point @jni

@sofroniewn pointed me to this from #744.  Just wanted to hear exactly when people feel like it's slow?  I think the majority of that time might be qt itself spinning up or imports (which is harder to do anything about).  On my system, when running from __main__, the majority of time is in __init__:
start init:    0.000
finish init:   1.413
start main:    1.416
start gui_qt:  1.417
app ready:     1.601
image shown:   2.281

So even if we wanted to do something with, say, QSplashScreen, that splash wouldn't show up until we instantiate the app in main, and then only very briefly... unless we tried to do something completely independent of Qt, at the very beginning of __init__.  I really haven't minded the startup time much, @sofroniewn, is it still slow for you, and under what specific startup procedure?

That's great profiling @tlambert03 - how did you do it? I get about 3.2 seconds between hitting enter on the command line after typing napari and seeing something on my screen (timed using the stop watch on my phone and me pressing buttons). That becomes a little longer if I try to load a small image at the same time too.
If we could get something up at the end right after app ready it still might feel nicer. There are also times when people are launching from scripts doing more fileIO etc inside our gui_qt event loop so it might be nicer there too. Putting it there would also mean people launching from jupyter or IPython wouldn't see it too, which was a concern from @jni, and makes sense to me - I think expectations are different when launching from the command line vs an interactive session.
I might give it a quick try with QSplashScreen and we can also decide against it. It looks like that approach will be only a couple lines, thanks for the tips!

how did you do it?

just import time and printed some time.time() statements at various places 😅
the first statement at the top of __init__ fired pretty much instantaneously after hitting enter.  3.2 seconds is definitely a bit frustrating, and maybe our differences are just computer differences? (but it certainly means that many users will be experiencing 3+ seconds).
I definitely agree with @jni that we should only have splash screens with __main__ or a standalone app... but i'd be curious to hear what you think after trying QSplashScreen

@tlambert03 nice use of timing, I can try that too to be more quantitative. I've added a splash screen PR #745 with the requirements people described. I kinda like it, but we can continue the discussion there.

to isolate the cause of the delay a bit more:
i put some more timing statements during startup and found that almost all of the delay in start comes when importing .viewer, and in that file, the bulk of the time comes from importing ._qt.qt_viewer ... and there the slow imports are spread across the many imports... with vispy being a notable contributor.

Following discussion in #745 I'm closing this issue for now. It was felt the splash screen didn't quite appear fast enough to be warranted. We can always revisit for the bundled app after #496 merges


Allow file presence checks

Previously, it was cumbersome to check if a file is present in a SourceFileSet or not. Now we provide a simple API for that. The need for such API arises because previously, there was only one SourceFileSet per run and now there can be multiple.

@armiol, PTAL.


Change default Select query label to "Take 10" for Kusto tables (#12396)

This PR fixes #
https://github.com/microsoft/azuredatastudio/issues/12410

Pull Request Test Coverage Report for Build 271239223

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 38.905%

Totals

Change from base Build 269438546:
0.0%

Covered Lines:
19238

Relevant Lines:
45114

💛  - Coveralls

/merge


language_lua.lua: added  and

Yesterday Lua 5.4 was released, so I added the attributes <const> and <close> to language_lua.lua.

I've pushed a commit to implement the attribute syntax in a more general manner. Thanks for submitting a pull request and bringing the changes to my attention.


Add basic LDAPIdentityProvider support

Scenario as a cluster administrator, I can set up an LDAP identity provider so that my users can login using LDAP
Given I have the supervisor installed and running
  And I have a FederationDomain configured for the supervisor
  And I have a cluster running the concierge and configured to authenticate via the supervisor
  And I have an LDAP database running and accessible over "ldaps://" with no custom CA
  And I have a user account in the LDAP database
  And I have a service account with bind access in the LDAP database
Then I can create an LDAPIdentityProvider object in the supervisor namespace
  And I can create a Secret of type `secrets.pinniped.dev/ldap-service-account` with service account credentials.
And when I run "pinniped login local-password --supervisor https://my-supervisor-issuer" (new command)
 Then I see a username/password prompt
 And when I enter the correct username and password
 Then I see a JWT token response with my LDAP identity encoded in the `username` claim.

LDAPIdentityProvider CRD Example
apiVersion: idp.supervisor.pinniped.dev/v1alpha1
kind: LDAPIdentityProvider
metadata:
  name: my-ldap-identity-provider
spec:
  server: ldaps://my-server.example.com
  searchBase:  dc=test,dc=com
  usernameAttribute: cn
  client:
    secretName: my-ldap-service-account-secret

Notes
Basic user login with basic LDAP connection. Connect with ldaps://, without any custom CA, authenticate using the provided service account credentials, and perform the user search and bind. No group search. Only support CLI-based username/password prompt. Only support those fields of LDAPIdentityProvider which are required for this basic first story.
More design notes in HackMD.
CLI command syntax and CRD API should be considered a rough sketch.

And I can create a Secret of type `secrets.pinniped.dev/ldap-service-account` with service account credentials.

This secret type looks odd in regards to API group suffix.  It would be really weird to create:
apiVersion: idp.supervisor.walrus.tld/v1alpha1
kind: LDAPIdentityProvider
...

but still have to link it to a secrets.pinniped.dev/ldap-service-account.  Both of these are part of our user facing API surface, and I think they should be consistent.

Hmm, I don't feel like would be weird for an idp.supervisor.walrus.tld.LDAPIdentityProvider to have a secretRef to a Secret of type secrets.pinniped.dev/ldap-service-account, the same way that it wouldn't be weird for it to have a secretRef to a Secret of type kubernetes.io/basic-auth. Seems normal that the data format of the Secret can come from a different project.
Since the service account is just a username and password, maybe we should use kubernetes.io/basic-auth instead of inventing our own in this case?
In regard to the CRD, maybe we want to create some nesting to make it easier to group similar settings together? There will be several settings about how to connect to the server, several settings about how to search for users, and several settings about how to search for groups. Should we group each under a top-level key, e.g. server.url, userSearch.searchBase, groupSearch..., and serviceAccount.secretName?

Since the service account is just a username and password, maybe we should use kubernetes.io/basic-auth instead of inventing our own in this case?

This sounds good to me.

In regard to the CRD, maybe we want to create some nesting to make it easier to group similar settings together?

This sounds good to me as well, maybe something like this?
apiVersion: idp.supervisor.pinniped.dev/v1alpha1
kind: LDAPIdentityProvider
metadata:
  name: my-ldap-identity-provider
spec:
  # where to connect
  endpoint: ldaps://my-server.example.com

  # how to authenticate to the server
  serviceAccount:
    secretName: my-ldap-service-account-secret

  # how to search for and parse user records
  users:
    base:  dc=test,dc=com
    usernameAttribute: cn

  # future: how to search for and parse group records
  groups:
    # TODO later

  # future: add TLS section for configuring custom CA, mTLS, and startTLS/LDAPS/... config
  tls:
    certificateAuthorityData: [...]
    # TODO later

Here are some things I think we will need to support:

AD as a provider
tls and non tls
ability to add a CA to be trusted or set verify to false
bind credential support
multiple Domain support -  many enterprises don't just have one domain and need to add users from multiple.
some ability to be able to validate the LDAP search and connections without having to use ldapsearch would be a huge plus


Keeps Disconnecting All Of My Devices Every Few Seconds

Everything works well, the controller, the driver, the multiple devices, but there's no point in having all of that if the device KEEPS DISCONNECTING EVERY 2 SECONDS. It's really annoying, I thought it would be a great software but now there's no point in having it.
----- I added it to the firewall "or it wouldn't have worked in the first place", they're on the same network, and I installed the driver "ViGEm Bus Driver" and I also tried updating it to the last driver "1.22 instead of 1.18" and I also used touchscreen.exe as administrator, so I hope you don't just give me the common answers.
Hope you solve this,
Thank you.

On the software part, I did my best to reduce these connection related issues. So it is likely that the issue is from other factors like Hardware or the Os. What i think the issue might be:-

Windows Auto-Disconnect: If you are using Hotspot with Internet On, If windows thinks the Internet turned off, it will Automatically disconnects to Search for other Wifi's with Internet, Ultimately disconnecting the Server.
Mobile Hardware: Some times i also noticed that these issue occurs alot in Lower end mobiles, Which can't process the load coming from network, this typically result's in high latency, might also result in disconnection.
Network Traffic: It also might be because of the incapability of the network on high traffic situation, like multiple people connected and consuming high data.

It might also be some other issue, but i can't pin-point unless i know your setup in detail. Let me tell you some tips and work arounds.

In Mobile Server section, long press the server to see the latency between your devices. Use it to benchmark the network or device.
Remember by default, high latency above 5sec leads to disconnection, You can increase this timeout in App setting. This will keep the connection alive for the timeout even if the actual underlying connection like Wifi is broken, giving it some time to auto-reconnect!


Vueify problem with vue hot reload.

Currently using vueify with laravel elixir and i'm running into an issue.
Now it compiles the .vue file just fine and produces what i need, but it appends an vue-hot-reload-api into the production file....
Is that always necessary? can it just process the .vue component and produce the js file without the vue-hot-reload-api included in the JS?
I cant seem to find a way to get rid of it.
Thanks.

When building for production make sure the Node process' process.env.NODE_ENV is set to "production".

I did that, still appends it.


Render MappedParam

Instead of rendering a input type=range for a MappedParam, it would be awesome to see the different mappings, maybe in a select?

Was fixed in https://github.com/NERDDISCO/VisionLord/commit/e54cbaedb35d8e2ce8c858688d01a03626f78d63#diff-fbbc7eb32e6a63e1dd48789843a0192fR77


Provide visual and operator-pending support for delete command

:DeleteDebugPrints already works with visual mode; operator-pending really isn't needed.


Update draft g9 questions

Update draft g9 questions for software, hosting, and support.
Bump version to 5.14.1

Let's do this and tweak later.
I think the multiquestion keys thing is definitely a good thing.
:+1:


NIFI-6814: Fixing DTO due to regression issue

NIFI-6814:

Restored JAXB Adapter

Will review...

Thanks @jsferner! This has been merged to master.


 I made a few changes that can be easily tweaked if they violate whatever principles and all:
*Racks start with InitLoaded false and will not reload normally until it is true
*Said racks load their full capacity at 2 missiles/sec after spawning until full
*Init missiles do not take any ammo, so you could have a full rack without having any ammo in a crate (crate still required to designate ammo type)
*Init missiles do not make loading noise

@MartyX5555
Kinda forgot about this, lol. I've just been leaving ammo crates on the floor...
You probably shouldn't merge this, but I am curious to hear your opinion on these issues

@kerbalcadet, i think i will leave as it is for now, since you can do the same thing by putting a refill next to your racks (which boost reload speed alot + refill used munition of the crate)
The concept is good though

I never found empty racks an issue for me, if you want my opinion


Feature Request: Date Validation?

Hi, Have you considered doing date validation?  I think this would be a huge value add and provide a nice completion for this library.

There is https://www.php.net/manual/en/datetime.createfromformat.php


various panics or hangs on flow.SystemStop()

I see various panics on flow.SystemStop()
DEBUG: System is using 4 cores now. 8 cores are left available.
DEBUG: Current speed of 0 instance of segment1 is 2 PKT/S, cloneNumber: 1 queue number: 16
^CStopping...

The Code looks like this:
package main

import (
        "fmt"
        "os"
        "os/signal"

        "github.com/intel-go/nff-go/flow"
        "github.com/intel-go/nff-go/packet"

        "github.com/google/gopacket"
        "github.com/google/gopacket/layers"
)

func main() {
        port := uint16(0)

        flow.CheckFatal(flow.SystemInit(nil))

        mainFlow, err := flow.SetReceiver(port)
        flow.CheckFatal(err)

        flow.CheckFatal(flow.SetHandler(mainFlow, handler, nil))
        flow.CheckFatal(flow.SetSender(mainFlow, 0))

        go func() {
                flow.CheckFatal(flow.SystemStart())
        }()

        c := make(chan os.Signal, 1)
        signal.Notify(c, os.Interrupt)
        <-c

        fmt.Println("Stopping...")

        flow.CheckFatal(flow.SystemStop())
}

func handler(packet *packet.Packet, context flow.UserContext) {
        gopacket := gopacket.NewPacket(packet.GetRawPacketBytes(), layers.LayerTypeEthernet, gopacket.Default)
        fmt.Printf("Packet: %v", gopacket)
}

My Devices:
Network devices using DPDK-compatible driver
============================================
0000:02:00.0 '82599ES 10-Gigabit SFI/SFP+ Network Connection 10fb' drv=igb_uio unused=ixgbe
0000:02:00.1 '82599ES 10-Gigabit SFI/SFP+ Network Connection 10fb' drv=igb_uio unused=ixgbe

Any Ideas?

Ok, found it:
You have to to disable the builtin signal handler:
        config := flow.Config{
                NoSetSIGINTHandler: true,
        }
        flow.CheckFatal(flow.SystemInit(&config))

Nice finding. I forgot about this setting, and couldn't guess the cause of crash from stack trace.

The crash happens the second time SystemStop() gets called.
Maybe there should be a check in SystemStop() to just return if it is already stopped.
But havent thought much about it yet.

@darinkes Stefan, can you please send some details about the project that you are working on with NFF-Go?

@aregm Thanks for asking. Currently I'm just starting to learn more about DPDK in general and Network Functions in Cloud Environments. Being not a hardcore C-Hacker this library gives me a nice way to work with DPDK.


Has anyone been able to get streaming to work with Humble and Motive?

I recently tried streaming from the latest version of Motive (running on Windows) to the Ubuntu laptop setup with Humble. I've checked that I can ping the other computer. I've also connected both computers to the same router and disabled the firewall on the Windows machine. I matched the local interface address in Motive and the server address in the mocap_optitrack_driver_params.yaml to the windows ip address. I've also ensured all the multicast settings match. When I launch the node, it quickly states ... not connected :(. What am I doing wrong (or how can I determine why it is not connecting)?

I will try it the next week. Let's see if something is broken....

Thank you for offering your help. I really appreciate the support. After a lot of frustration, it turned out to be a networking issue where the companies software was blocking the messages, even when the firewall is disabled. I can confirm that the node works perfectly on humble


Python version upgraded from 3.8 to 3.11

Resolves HASH_SIGN_FOLLOWED_BY_ISSUE_NUMBER
What is being addressed
Describe the current behavior you are modifying. Please also remember to update any impacted documentation.
How is this addressed

Describe the changes made, and if appropriate, why they are addressed this way
Note any pending work (with links to the issues that will address them)
Update documentation
Update CHANGELOG.md if needed
Increment template version if needed, for guidelines see Authoring templates - versioning

not required


Labels

It would be nice to CRUD labels on tasks, links, etc and then be able to query them as well

Isn’t this addressed by the multitree + link model? I think you could just have a “tags” folder and then link to a whole bunch of nodes under each tag.

As @ron-wolf said, we want to use the structure itself for this, see README.md (section on 'pointers').


Label documentation

We need to know what are the changes in the documentation compared to a live version: update, new, deprecated.
Using graphql-inspector for comparing local schema against a ref schema, we can get such information when generating the documentation and placing the correct label N, U, D.
This requires to add a custom theme.

Using the coming custom tag feature:

run schema diff
update local schema ast with custom tags for new and updated types

This should be handled as an optional package.


Discuss Assets and Archives in Programming Model docs

Unless I'm mistaken, we don't document the concept of assets and archives very clearly anywhere, other than having API docs for them. These are core enough concepts that we should cover them, probably in the Programming Model overview, if not a sister page to it.

@leezen This milestone came and went very quickly, and I was tied up in other things, so didn't get to this and it seems unlikely that will change for me. So reassigning back. I've seen this come up in a few places lately so definitely would be good to put on the short-term horizon if we have the cycles.


a plugin for querying more RAM action details

For the reason that RAM amount delta is not included in ram action(buyram, buyrambytes, sellram), the price of RAM trading can not be fetched and calculated from blockchain directly. To record the RAM amount delta for every RAM-related action, a table should be used to record every account's RAM balance, and then compare the balance before and after the action to calculate the delta.
In order to resolve this problem, a plugin for querying RAM action details has been developed for enumivo(website, forum). Here is the repo of the plugin
By including this plugin in config.ini and after blocks replaying, the RAM action details can be fetched from HTTP API http://HOST_ADDRESS:PORT/v1/ram/get_actions by POST method.

I think the plugin might be also useful for EOS, so if there are demands here, I will make a PR to the project.

Work is in progress to accommodate linking plugins from external repositories into nodeos via configuration settings.  See #5026.  A pull request may not be necessary, but if one is made, we will evaluate it as a candidate for inclusion in the base code.

Cool, building external plugin via config is a excellent idea. For the reason that I've add new object type in types.hpp, It maybe not be suitable to build from external repository. It's awesome if the plugin can be reviewed and evaluated by EOSIO even further included in the base code. What's more is that it is used for ENU RAM exchange enutick.com in backend.

I have ported Bancor algorithm from system contract to ram_plugin, it's used to evaluate ENU/RAM exchange rate before the real transaction actually involved. The evaluation can be fetched via HTTP API /v1/ram/evaluate by providing input asset amount and symbol.

External plugins now easily integrated into the build via PRs #5026 and #5539.


[sdl2] build failure

Operating system
windows 11
Compiler
msvc
Steps to reproduce the behavior
`.\vcpkg.exe install sdl2:x64-windows`

Failure logs
Computing installation plan...
error: while looking for sdl2:x64-windows:
error: while loading C:\Users\alex\source\repos\vcpkg\ports\sdl2\vcpkg.json:
$.default-features[0]: mismatched type: expected an identifier
$.default-features[1]: mismatched type: expected an identifier
$.default-features[2]: mismatched type: expected an identifier
Additional context
No response

@alexhsu Could you please run command .\bootstrap-vcpkg.bat and try again?

@alexhsu Could you please run command .\bootstrap-vcpkg.bat and try again?

thanks, it works for me

Closed this by https://github.com/microsoft/vcpkg/issues/37500#issuecomment-2017447159


Discard user cancelation alert on non-english OS

The error message is being shown, translated, on non-english platforms, upon user cancelation.
To prevent this, one can match the error code only.


Drupal auth

Changes

Moves authentication into new AuthController. This fits standard conventions in other Laravel projects, and separates authentication concerns from user resource concerns.
Add authentication to Drupal API class. The first request for an authentication cookie/token will make a login request against the Drupal API, and then cache that session for the following 30 minutes.
Other minor cleanups.

For review: @angaither @jonuy

:+1:


trying to fix unimplemented flock under linux

It fixes https://github.com/rust-lang/cargo/issues/3666

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon.
If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.
Please see the contribution instructions for more information.

Thanks @z1mvader! Could you also add a comment probably referencing #3666 as well?

Sure, its already on the first comment

Eh ok, seems ok to me
@bors: r+

:pushpin: Commit fb6a98f has been approved by alexcrichton

:hourglass: Testing commit fb6a98f with merge c5679e2...

:sunny: Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing c5679e21ef8c7deabce3911ce04ead338ff063be to master...


Added support of AKAudioFile to AKSampler

You have a conflict with the playgrounds file, so you should pull from develop and make sure to discard your own edits to contents.xcplayground and use the version from our develop branch.  Then commit and I can merge.


Rebase master branch with v1.8 changes

What type of PR is this?

/kind code-refactoring

What does this PR do / why we need it:
Rebase GitOps Operator Master branch with v1.8 branch changes. While it looks like there are many changes missing in the master branch, most of the them are the commits where I tried the render_templates implementation.
How to test changes / Special notes to the reviewer:

/retest

/retest

/test v4.10-kuttl-parallel

Will create a new PR to make the review simpler


Running mailrise as service fails

I've installed mailrise using PyPI as recommended:
$ pip install mailrise
and did a basic configuration. Starting it from the command line works fine:
$ /home/sysadmin/.local/bin/mailrise -v /etc/mailrise.conf
When trying to configure it as service on Ubuntu following the suggested systemd unit file, mailrise fails to start:
systemd[1]: Started Mailrise SMTP notification relay.
mailrise[482883]: Traceback (most recent call last):
mailrise[482883]:   File "/home/[user]/.local/bin/mailrise", line 5, in <module>
mailrise[482883]:     from mailrise.skeleton import run
mailrise[482883]: ModuleNotFoundError: No module named 'mailrise'
systemd[1]: mailrise.service: Main process exited, code=exited, status=1/FAILURE
systemd[1]: mailrise.service: Failed with result 'exit-code'.

Any hint to resolve the issue would be appreciated, thanks!
Environment:

Ubuntu 22.04.5 LTS
Python 3.10.12
mailrise 1.4.0

As I've installed mailrise for a user and not system-wide (which seems to be the recommendation, especially from a security perspective), I had to extend the example for the systemd unit file which is stated in the mailrise readme. After some debugging it turns out that a typo in the "User" directive, which I had to add to reference the user under which mailrise is installed, caused the error message. After fixing that, mailrise is starting without any errors!
Please find below my mailrise.service file as an example:
[Unit]
Description=Mailrise SMTP notification relay
After=network.target

[Service]
Type=simple
User=[username]
WorkingDirectory=/home/[username]/.local/bin
ExecStart=/home/[username]/.local/bin/mailrise -v /etc/mailrise.conf
Restart=always
StandardOutput=append:/var/log/mailrise.log
StandardError=append:/var/log/mailrise_error.log

[Install]
WantedBy=multi-user.target

Please note that I'm in no way a systemd expert, it is based on various recommendations, ymmw!


Backend scripts throw out errors when there are test files missing.

I don't think it should be a case that if there is no documents.csv or example.txt in either of faculties directory the build throws out errors

Usually if someone wants to build our repository they won't have these files, so why the script requires them?
In my opinion backend function shouldn't throw out errors if test files are missing.  For now I will add the files to repository, because the deploy fails otherwise.

The backend of the application will be rewritten in the Laravel framework, thus the issue is no longer needed.
The new application will use a database and there will be migrations and faker to generate the necessary data for the site to function properly.


Client Allocation Request for: Big Nautical Image

Client Allocation Questions
Core Information

Name: Big Nautical Image
Website / Social Media: https://www.0755dhh.com/
Region: Greater China Region
DataCap Requested: 10TiB
Addresses to be Notarized: f1znansfgebzncmf6whw6rp5ix3quovunyf2jqquy
Notary Requested: steven004

@huangwenfengwieng Please subscribe to notifications for this Issue to be aware of updates. Notaries may request additional information on the Issue.

@steven004 Hi notary, this request hadn't seen responses until it was closed #2144. Please have a look and feel free to ask for information. Thanks!

@steven004 Hi this request needs progress. Please have a look thx~

Closing this one due to a doubt of multiple applications submitted by one applicant.


Blog Post Featured Image not Scaled Properly

Describe the bug
On my blog, the featured images of blog posts seem to get cropped out of view:
Expected behavior
The image would be scaled to fit inside the viewport, maintaining the aspect ratio.
Screenshots

Hugo & Blowfish versions
Hugo version 0.107.0
Blowfish version 2.24.0
Additional context
If this is the actual expected behavior, maybe some guidelines on featured image sizing would be beneficial.

Hey @mirceanton
Can you check https://github.com/nunocoracao/blowfish/issues/336
It might help solve your problem...
Having said this I might consider going back to the resize VS fill... as the default as multiple users are having a hard trouble with this. And doesn't make much sense for the default to not be what most users expect/want.
Let me know if the hack I suggested on that ticked is the outcome you are looking for.

@nunocoracao Thank you! It mostly fixed it. I copied the article-link/ partials directory to my local partial layouts and made the modifications, as well as setting imaging.anchor: 'Center' in my config.yaml file.
However, this solution makes me a bit worried about breaking something in the future by having these layouts overridden like this (maybe a partial gets moved or renamed).

Leave this open will need to work on this and revert the fill command to resize. Did you test if that has the intended outcome?

Yes, it fixed it.
This is the cardview layout on the home page:

And this is the listview layout in the /posts page:

@mirceanton could you check if just adding
[imaging]
  anchor = 'Center'

fixes the problem? aka without the overrides?

@nunocoracao it does not. I tried that before doing the overrides. It keeps the same "crop level", it's just that the image is now centered instead of showing only the left part of the cropped image.

@mirceanton can you check if keeping the overrides and removing the
[imaging]
  anchor = 'Center'

fixes the problem?

@nunocoracao  here we have a comparison of the 4 scenarios:

No anchoring, no overrides

Only imaging.anchor = Center

Only overrides

Overrides configured and imaging.anchor = Center

To my eyes, 3 and 4 look identical, so I would say that only doing the override is enough

My thoughts... reverting the .fill to .resize should fix this.
Cc @chrisbanes will revert the fill to resize in next version FYI

Yea, I believe that .Resize produces a more sensible outcome that an end user might expect out of the box. I think that expecting the featured image of the blog to be resized in order to be shown properly in the card/list item is reasonable and implementing something different should require the user to override, and not the other way around.
But then again, these are only my thoughts and I am not the only user of this theme


Link to #matrix-static on https://view.matrix.org

thanks!

i think the right solution for this is actually to reenable view.matrix.org support on matrix.to, so the existing hyperlink there gives the option of reading the room on view.matrix.org. We disabled this whilst view.matrix was offline for a few months, but i've now re-added it. therefore if you look at https://matrix.to/#/#matrix-static:matrix.org you should hopefully (once caching clears) see a link to https://view.matrix.org as desired. I think the explicit link is probably redundant in the readme, so going to close (sorry :/)

@ara4n thanks for the speedy turn around on my pull request. At https://matrix.to/#/#matrix-static:matrix.org this is what I see:

a link to https://view.matrix.org as desired

Are you talking about the "Access #matrix-static:matrix.org" column? Thanks.

yup, i'm talking about the link in the second row and final column. matrix.to's UX is... minimal though :/


Simply the configuration for orchestration

Fixes #1328.
Changes proposed in this pull request:

Modify loadMasterSlaveRuleConfiguration()
Modify loadShardingRuleConfiguration()
Modify OrchestrationSpringBootConfiguration
Modify check for loadMasterSlaveRuleConfiguration and loadShardingRuleConfiguration
Modify some tests

Pull Request Test Coverage Report for Build 5337

8 of 25 (32.0%)  changed or added relevant lines in 6 files are covered.
3 unchanged lines in 1 file lost coverage.
Overall coverage decreased (-0.04%) to 63.37%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

sharding-jdbc/sharding-jdbc-orchestration/src/main/java/io/shardingsphere/shardingjdbc/orchestration/internal/datasource/OrchestrationMasterSlaveDataSource.java
0
1
0.0%

sharding-jdbc/sharding-jdbc-orchestration/src/main/java/io/shardingsphere/shardingjdbc/orchestration/internal/datasource/OrchestrationShardingDataSource.java
0
1
0.0%

sharding-orchestration/sharding-orchestration-core/src/main/java/io/shardingsphere/orchestration/yaml/YamlOrchestrationConfiguration.java
0
1
0.0%

sharding-orchestration/sharding-orchestration-core/src/main/java/io/shardingsphere/orchestration/internal/state/datasource/DataSourceService.java
0
2
0.0%

sharding-orchestration/sharding-orchestration-core/src/main/java/io/shardingsphere/orchestration/internal/config/ConfigurationService.java
0
4
0.0%

sharding-jdbc/sharding-jdbc-orchestration-spring/sharding-jdbc-orchestration-spring-boot-starter/src/main/java/io/shardingsphere/shardingjdbc/orchestration/spring/boot/OrchestrationSpringBootConfiguration.java
8
16
50.0%

Files with Coverage Reduction
New Missed Lines
%

sharding-orchestration/sharding-orchestration-reg/src/main/java/io/shardingsphere/orchestration/reg/newzk/client/zookeeper/base/Holder.java
3
70.49%

Totals

Change from base Build 5336:
-0.04%

Covered Lines:
7977

Relevant Lines:
12588

💛  - Coveralls


can't run any files

C:\27\kahoot-hack-master\kahoot-hack-master\kahoot-rand>go run main.go
main.go:17:2: cannot find package "github.com/unixpickle/kahoot-hack/kahoot" in any of:
C:\Go\src\github.com\unixpickle\kahoot-hack\kahoot (from $GOROOT)
C:\27\src\github.com\unixpickle\kahoot-hack\kahoot (from $GOPATH)

You didn't use go get to download the package like you should have.


Use preferred tile.openstreetmap.org URL

I would like to suggest using the now preferred https://tile.openstreetmap.org URL instead of the current one, see
https://github.com/openstreetmap/operations/issues/737

Thanks


add apps.py and translation file

thanks django-taggit, it saves my time!
this is my contribute. hope this is useful. please check it.

CI is failing due to icorrectly ordered imports in taggit/apps.py. If you could fix this so that the rest of the test suite runs that would be great.
ERROR: /home/travis/build/alex/django-taggit/taggit/apps.py Imports are incorrectly sorted.

upgrade,please confirm it.

One suggestion code wise. Not being a Chinese speaker though I can't review the translation, unfortunately.

Looks great, thanks!


Missing file 'co-occur.pk'

Hello!
Great job, great repository thanks for it!
But when I run train.py, I get an error with missing file : 'co-occur.pk'. It is read in a file dataset.py in line 59 (add pic.) and assigned to a variable self.co_occur_matrix, but this variable never used.
Can you help me solve this problem, thanks!

Hi. Thank you for your interest! I have already fixed the issue. Thank you for pointing this out.


Real time result if face detected

Is there any way to know if face is missing from camera or not. I tried everyting but nothing helps.
 setInterval(async () => {
    const detections = await faceapi
      .detectSingleFace(video, new faceapi.SsdMobilenetv1Options())
      .withFaceLandmarks()
      .withFaceExpressions()
      .withAgeAndGender();

    const resizedDetections = faceapi.resizeResults(detections, displaySize);
    console.log(resizedDetections);

    canvas.getContext("2d").clearRect(0, 0, canvas.width, canvas.height);

    if (resizedDetections && Object.keys(resizedDetections).length > 0) {

      facedetected = true;

      faceapi.draw.drawDetections(canvas, resizedDetections);
      faceapi.draw.drawFaceLandmarks(canvas, resizedDetections);

      const age = resizedDetections.age;
      const interpolatedAge = interpolateAgePredictions(age);
      const gender = resizedDetections.gender;
      const expressions = resizedDetections.expressions;
      const maxValue = Math.max(...Object.values(expressions));

      const emotion = Object.keys(expressions).filter(
        item => expressions[item] === maxValue
      );

      predictedAge = interpolatedAge;
      predictedGender = gender;
      predictedEmotion = emotion[0];

      note.innerHTML = 'detected';
      note.style.backgroundColor = "#12A533";

    }else{
     facedetected = false; /// This doest return false
       note.innerHTML = 'not detected';
      note.style.backgroundColor = "#000000";
   }

  }, 100);

if (detections) {
    *code to be executed when face detected*
}


Need an additional field for sending files like apk

In Android team, we are using the environment variable $BITRISE_PUBLIC_INSTALL_PAGE_URL created by the Gradle step to send our apk. Do you think it is possible to add an additional field for this please? 🙏

Will work on it this weekend!

#2 fixed in version 0.0.2 as an install page url! 👍


File width permanently extends because of LSP error

Lapce Version
0.2.7
System information
Intel CPU MacOS
Describe the bug
Rust analyzer output an unusually long error from an unused future, and I noticed afterwards that the horizontal scrollbar extended because of it. The error seems to have permanently resized the file.
In a perfect world I think the LSP output should not resize the file at all, if that's possible.
Additional information
I didn't show all code here, but I promise no other line is longer than ~90 characters :bow:

This is a problem with the document width handling in general. To reproduce this, simply add and delete a very long line. Ideally, it should resize to fit the current max line width.