Gen 101 input validation

This PR set up the code to validate the API endpoint. I still have to create the serialization from the object to the database model.

I've had to make some changes to this code while adding the DB capabilities

I'm going to cancel this PR and just submit another one for the full code with the database integration.


⚠ Bofrost.at has degraded performance

In df7ff62, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 1939 ms

Resolved: Bofrost.at performance has improved in cb80bc3.


Issue with oracle batch insertion query

The raw query syntax for batch insertion in Oracle would be
INSERT ALL
  INTO table (column1, column2, column_n) VALUES (value_1, value_2, value_3)
  INTO table (column1, column2, column_n) VALUES (value_1, value_2, value_3)
  INTO table (column1, column2, column_n) VALUES (value_1, value_2, value_3)
SELECT * FROM dual;

This is the code below which i tried to generate query for bulk insert
oracle_query = OracleQuery.into(table_to_insert).columns(*raw_query_col_names)
for each_row in batch:
    # do_something
    oracle_query = oracle_query.insert(tuple(each_row_to_insert))

But the generated raw query is:
INSERT INTO "table_name" ("column_1","column_2") VALUES ('value_1','value_2'),('value_1','value_2'),('value_1','value_2')
Since it is an incorrect query, I get the error ORA-00933: SQL command not properly ended
Does it have support for this out of the box?

This particular feature is not currently implemented, no, but if you'd like to try your hand at it please feel free to raise a PR


Use syntax highlighting in the readme file

Thank you! Looks good 👍

I actually prefer the old format. It makes easier to read with non-markdown viewers. Also there isn't much highlighting to do.
Thank you for contributing. :+1:


Image validation based on formats available in Glance

container_format and disk_format are enums that have a set of values that are acceptable BY DEFAULT.
Consider adding:

some controller (the cloud one?) that fetches the accepted values and adds them somewhere (in memory? or to the OpenStackCloud status?)
a validating webhook that issues a warning based on the accepted values (which should be memoized so that the validation doesn't trigger a call to the kubeAPI)

e.g. for container format
// +kubebuilder:validation:Enum=ami;ari;aki;bare;ovf;ova;docker
for disk_format
// +kubebuilder:validation:Enum=ami;ari;aki;vhd;vhdx;vmdk;raw;qcow2;vdi;ploop;iso;

@vkmc we could add the static validation you propose if we knew for sure that it is not possible to add acceptable values via configuration/plugins in Glance. Do we?
If not, the validation should probably run in a webhook (either error or just warning)


Remove tailwinds anti-pattern in RepoSubmission.tsx

Context is on the tracking issue - https://github.com/open-sauced/hot/issues/267
This issue only needs changes to this file.

.take

I have some question about this ticket, What I have to do because we have some custom padding,margin. Like 15px, 300px, 5px... We can use mb-[0.313rem], p-[0.938] ?  OR we can add custom properties in tailwind.config.cjs?

Replacing the pixel values with rem/em is still an anti-pattern.
m-[16px] or m-[0.23em] are both anti-patterns.


Keyboard shortcut containing non-US character does not work

VSCode Version: 1.3.1
OS Version: OSX 10.10.5

Steps to Reproduce:

Create custom keyboard shortcut containing non-US character eg. "cmd+shift+æ"

@ankyankyanky Please see https://code.visualstudio.com/docs/customization/keybindings#_accepted-keys and the next section at https://code.visualstudio.com/docs/customization/keybindings#_keyboard-layouts


Adjust Android Extension for Adobe Experience SDK v3

Related issues

Jira issue link: https://adjustcom.atlassian.net/browse/ADAPP-18811

Changes

This PR introduces the migration guide and documentation for the Adjust Android Extension for Adobe Experience SDK.
Required translations

Platform
ZH
JA
KO

Android Adobe extension
:white_check_mark:
:x:
:x:

@shashanksu This is ready for review:

Documentation
Migration guide

@shashanksu This is ready for review:

Documentation
Migration guide

@Sporiff Thanks for the PR.  Docs looks nice 👍  Few minor comments:
Integration guide:

Install the Adjust Extension - Dependency versions:

dependencies {
  implementation 'com.adjust.adobeextension:adobeextension:3.0.0'
  implementation 'com.adjust.sdk:adjust-android:5.0.1'
}

Add callback parameters to Event:
correct name: AdjustAdobeExtension.ADOBE_ADJUST_EVENT_CALLBACK_PARAM_PREFIX

Add partner parameters to Event:
correct name: AdjustAdobeExtension.ADOBE_ADJUST_EVENT_PARTNER_PARAM_PREFIX

Migration guide:

Install the SDK - Dependency versions:

dependencies {
  implementation 'com.adjust.adobeextension:adobeextension:3.0.0'
  implementation 'com.adjust.sdk:adjust-android:5.0.1'
}

@shashanksu @ironnysh  I've updated this content to format it more like a set of guides.

In the integration guide, we take the developer through the whole basic example app setup step-by-step to show them what each step is actually doing.
In each feature guide, we give a short tutorial showing the developer exactly how to use the method or class we describe.
At the end, we show a full example app (in this case just the MainApp.java and MainActivity.java to give the developer an idea of how their code might look.

Could you take a look through and let me know what you think? I will also rework the migration guide in a similar format so that the content actually guides a developer through the process of updating an example app from v2 to v3.

@shashanksu @ironnysh I've updated this content to format it more like a set of guides.

In the integration guide, we take the developer through the whole basic example app setup step-by-step to show them what each step is actually doing.
In each feature guide, we give a short tutorial showing the developer exactly how to use the method or class we describe.
At the end, we show a full example app (in this case just the MainApp.java and MainActivity.java) to give the developer an idea of how their code might look.

Could you take a look through and let me know what you think? I will also rework the migration guide in a similar format so that the content actually guides a developer through the process of updating an example app from v2 to v3.

@Sporiff I did a high level overview of the integration guide.  It looks very helpful especially the "step by step" integration details.  Just a few thoughts:

The code snippet in each step has both surrounding code lines (non-subject) and the relevant code (selected).  I understand this repetition of surround code is important for a user to have the context and relativity.  But can this surrounded code be little greyed/in background/hidden?  So that as a user I don't get an impression that so much code needs to be added in each step (despite having the code of subject highlighted).
Also not sure, but let's say in future there is a change required in the surrounding code.  In such case, I guess we need to make sure that each of the code snippets instances be updated where all it is mentioned, right?
Example app - Since the example we will be updating time to time, would this be automatically updated here as well?  Otherwise, can just having the github link for the examples be an option?

@shashanksu

* The code snippet in each step has both surrounding code lines (non-subject) and the relevant code (selected).  I understand this repetition of surround code is important for a user to have the context and relativity.  But can this surrounded code be little greyed/in background/hidden?  So that as a user I don't get an impression that so much code needs to be added in each step (despite having the code of subject highlighted).

A good solution here is probably to just show the full code up front, then have the steps only show the code that is actually added in each step.

* Also not sure, but let's say in future there is a change required in the surrounding code.  In such case, I guess we need to make sure that each of the code snippets instances be updated where all it is mentioned, right?

This would be resolved by the above suggestion.

* Example app - Since the example we will be updating time to time, would this be automatically updated here as well?  Otherwise, can just having the github link for the examples be an option?

Maybe a good approach here would be for me to build a component that directly fetches the example code from the repository so that the example app you write in GitHub gets pulled in automatically.

I've updated this content to format it more like a set of guides.

Love it!
I made a few copy changes to appease Vale :-)

a component that directly fetches the example code from the repository

Would that work for all of our SKDs?

I made a few copy changes to appease Vale :-)

Great, thanks!

Would that work for all of our SKDs?

Yep, I'd build it be generic. All we'd need is the permalink to the code in the GitHub repo. Leave the rest with me.

@ironnysh @shashanksu I've added a new component for fetching example files from GitHub. We should now be able to copy the link to the file and have it appear as code in the documentation at build time. For example: https://dev-docs-git-adapp-18811-adobe-extension-de7bb9-product-content.vercel.app/en/sdk/adobe-extension/android/example

@ironnysh @shashanksu I've added a new component for fetching example files from GitHub. We should now be able to copy the link to the file and have it appear as code in the documentation at build time. For example: https://dev-docs-git-adapp-18811-adobe-extension-de7bb9-product-content.vercel.app/en/sdk/adobe-extension/android/example

@Sporiff Amazing, this is really nice 👏


create bound container from text element

Same as we allow binding text to a container via contextmenu, we can allow create a text container from text alone.
https://user-images.githubusercontent.com/5153846/188826284-62147351-1502-497f-abf0-dcd2b57b3243.mov
(requested on Discord)

When creating a container from the text - do we support only rectangle? or give user a choice to choose the container ? I think I will go with first one - creating rect as a container for the text


Fix deserialization/decoding of FixNum

The current test deserialize_from_json_should_fail doesn't test anything. The test should verify that the correct error was returned, not that some error was returned. Fix the test, add a test for decoding and write manual implementations of Deserialize and Decode.

related to #1995


Add help files for new variation related cmdlets

@microsoft-github-policy-service agree company="Microsoft"
Thanks
Ying
From: microsoft-github-policy-service[bot] @.>
Sent: Friday, February 10, 2023 3:54 PM
To: MicrosoftDocs/OfficeDocs-SharePoint-PowerShell @.>
Cc: Ying Zhou @.>; Mention @.>
Subject: Re: [MicrosoftDocs/OfficeDocs-SharePoint-PowerShell] Add help files for new variation related cmdlets (PR #385)
@zhoyingmshttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fzhoyingms&data=05|01|zhoying%40microsoft.com|2c80f1b8e440404f91cc08db0b3be703|72f988bf86f141af91ab2d7cd011db47|1|0|638116124170135997|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=HceE8aRXXxu9TfB2dc8WAeEEQ1BURb3lKNh1fEquBJM%3D&reserved=0 please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
@microsoft-github-policy-service agree [company="{your company}"]
Options:

(default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.

@microsoft-github-policy-service agree

(when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term "You" includes me and my employer.

@microsoft-github-policy-service agree company="Microsoft"
Contributor License Agreement
Contribution License Agreement
This Contribution License Agreement ("Agreement") is agreed to by the party signing below ("You"),
and conveys certain license rights to Microsoft Corporation and its affiliates ("Microsoft") for Your
contributions to Microsoft open source projects. This Agreement is effective as of the latest signature
date below.

Definitions.
"Code" means the computer software code, whether in human-readable or machine-executable form,
that is delivered by You to Microsoft under this Agreement.
"Project" means any of the projects owned or managed by Microsoft and offered under a license
approved by the Open Source Initiative (www.opensource.orghttps://nam06.safelinks.protection.outlook.com/?url=http%3A%2F%2Fwww.opensource.org%2F&data=05|01|zhoying%40microsoft.com|2c80f1b8e440404f91cc08db0b3be703|72f988bf86f141af91ab2d7cd011db47|1|0|638116124170135997|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=644jkQdZMQcsZStM9PQb1SCNzEqWtfu3eJQFUjt7o5o%3D&reserved=0).
"Submit" is the act of uploading, submitting, transmitting, or distributing code or other content to any
Project, including but not limited to communication on electronic mailing lists, source code control
systems, and issue tracking systems that are managed by, or on behalf of, the Project for the purpose of
discussing and improving that Project, but excluding communication that is conspicuously marked or
otherwise designated in writing by You as "Not a Submission."
"Submission" means the Code and any other copyrightable material Submitted by You, including any
associated comments and documentation.
Your Submission. You must agree to the terms of this Agreement before making a Submission to any
Project. This Agreement covers any and all Submissions that You, now or in the future (except as
described in Section 4 below), Submit to any Project.
Originality of Work. You represent that each of Your Submissions is entirely Your original work.
Should You wish to Submit materials that are not Your original work, You may Submit them separately
to the Project if You (a) retain all copyright and license information that was in the materials as You
received them, (b) in the description accompanying Your Submission, include the phrase "Submission
containing materials of a third party:" followed by the names of the third party and any licenses or other
restrictions of which You are aware, and (c) follow any other instructions in the Project's written
guidelines concerning Submissions.
Your Employer. References to "employer" in this Agreement include Your employer or anyone else
for whom You are acting in making Your Submission, e.g. as a contractor, vendor, or agent. If Your
Submission is made in the course of Your work for an employer or Your employer has intellectual
property rights in Your Submission by contract or applicable law, You must secure permission from Your
employer to make the Submission before signing this Agreement. In that case, the term "You" in this
Agreement will refer to You and the employer collectively. If You change employers in the future and
desire to Submit additional Submissions for the new employer, then You agree to sign a new Agreement
and secure permission from the new employer before Submitting those Submissions.
Licenses.

Copyright License. You grant Microsoft, and those who receive the Submission directly or
indirectly from Microsoft, a perpetual, worldwide, non-exclusive, royalty-free, irrevocable license in the
Submission to reproduce, prepare derivative works of, publicly display, publicly perform, and distribute
the Submission and such derivative works, and to sublicense any or all of the foregoing rights to third
parties.
Patent License. You grant Microsoft, and those who receive the Submission directly or
indirectly from Microsoft, a perpetual, worldwide, non-exclusive, royalty-free, irrevocable license under
Your patent claims that are necessarily infringed by the Submission or the combination of the
Submission with the Project to which it was Submitted to make, have made, use, offer to sell, sell and
import or otherwise dispose of the Submission alone or with the Project.
Other Rights Reserved. Each party reserves all rights not expressly granted in this Agreement.
No additional licenses or rights whatsoever (including, without limitation, any implied licenses) are
granted by implication, exhaustion, estoppel or otherwise.

Representations and Warranties. You represent that You are legally entitled to grant the above
licenses. You represent that each of Your Submissions is entirely Your original work (except as You may
have disclosed under Section 3). You represent that You have secured permission from Your employer to
make the Submission in cases where Your Submission is made in the course of Your work for Your
employer or Your employer has intellectual property rights in Your Submission by contract or applicable
law. If You are signing this Agreement on behalf of Your employer, You represent and warrant that You
have the necessary authority to bind the listed employer to the obligations contained in this Agreement.
You are not expected to provide support for Your Submission, unless You choose to do so. UNLESS
REQUIRED BY APPLICABLE LAW OR AGREED TO IN WRITING, AND EXCEPT FOR THE WARRANTIES
EXPRESSLY STATED IN SECTIONS 3, 4, AND 6, THE SUBMISSION PROVIDED UNDER THIS AGREEMENT IS
PROVIDED WITHOUT WARRANTY OF ANY KIND, INCLUDING, BUT NOT LIMITED TO, ANY WARRANTY OF
NONINFRINGEMENT, MERCHANTABILITY, OR FITNESS FOR A PARTICULAR PURPOSE.
Notice to Microsoft. You agree to notify Microsoft in writing of any facts or circumstances of which
You later become aware that would make Your representations in this Agreement inaccurate in any
respect.
Information about Submissions. You agree that contributions to Projects and information about
contributions may be maintained indefinitely and disclosed publicly, including Your name and other
information that You submit with Your Submission.
Governing Law/Jurisdiction. This Agreement is governed by the laws of the State of Washington, and
the parties consent to exclusive jurisdiction and venue in the federal courts sitting in King County,
Washington, unless no federal subject matter jurisdiction exists, in which case the parties consent to
exclusive jurisdiction and venue in the Superior Court of King County, Washington. The parties waive all
defenses of lack of personal jurisdiction and forum non-conveniens.
Entire Agreement/Assignment. This Agreement is the entire agreement between the parties, and
supersedes any and all prior agreements, understandings or communications, written or oral, between
the parties relating to the subject matter hereof. This Agreement may be assigned by Microsoft.

Reply to this email directly, view it on GitHubhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMicrosoftDocs%2FOfficeDocs-SharePoint-PowerShell%2Fpull%2F385%23issuecomment-1425351696&data=05|01|zhoying%40microsoft.com|2c80f1b8e440404f91cc08db0b3be703|72f988bf86f141af91ab2d7cd011db47|1|0|638116124170135997|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=lcHLI8RFEjWSCqdGnmADf%2FOli6TV4P5mFCD5qNY2FTA%3D&reserved=0, or unsubscribehttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAWQQLJT4N6AYKZ5KC7KC4GLWWXXXVANCNFSM6AAAAAAUXPPYFM&data=05|01|zhoying%40microsoft.com|2c80f1b8e440404f91cc08db0b3be703|72f988bf86f141af91ab2d7cd011db47|1|0|638116124170135997|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=a9kYCDO%2BgP1Ke0ZwnBeMJC7X8OFvX4T3LN%2F5HzT9YY4%3D&reserved=0.
You are receiving this because you were mentioned.Message ID: @.***>

@JohanFreelancer9

@dariomws Thanks for your suggestions, I have updated the file locations.

@dariomws @get-itips

@get-itips

@tiburd Please merge this PR. Thanks


@TaskAction annotation error with IncrementalTaskInputs in IncrementalTransformTask

I'm encountering a build error related to the New Relic Gradle plugin when building my Android application. The error message indicates that using the @TaskAction annotation on the IncrementalTransformTask.transform() method with IncrementalTaskInputs as a parameter is no longer valid.
Steps to reproduce:
Add the New Relic Gradle plugin to your Android project com.newrelic.agent.android:agent-gradle-plugin:7.5.0.
Attempt to build the project.
Expected behavior:
The project should build successfully without errors.
Actual behavior:
The build fails with the following error:
Cannot use @TaskAction annotation on method IncrementalTransformTask.transform() because interface org.gradle.api.tasks.incremental.IncrementalTaskInputs is not a valid parameter to an action method.

Environment:
New Relic Gradle plugin version: 7.5.1.
Gradle version: 8.1
Android Gradle plugin version: 7.4.2
This issue might be caused by an incompatibility between the New Relic Gradle plugin and the Android Gradle plugin, potentially due to changes in the valid parameter types for @TaskAction methods. Updating the New Relic plugin to the latest version might resolve the problem.
Please investigate this issue and provide a fix or workaround.
Remember to:
Replace the bracketed information with your specific details.

@ritick-plateron can you share sample app for this? Can you also share your flutter version and build.gradle file for this?

@ritick-plateron we are unable to reproduce this. I am closing it .


It shows 3 classes by flow_from_directory when there are only two classes in the destination path.

I am using jypyter notebook in ubuntu and facing the problem in reading directories by 'flow_from_directory' from 'ImageDataGenerator'. It shows 3 classes for two folders in the path.

What did you write in class_mode?

Can you send your code?


RFC: S3 Source

preview: https://github.com/risingwavelabs/rfcs/blob/0cff6144ffdfdfe91ea3d1217d67f0b09b69f7ea/rfcs/0019-s3 source.md

Maybe we can learn from delta lake and use a self maintained log to store changes from SQS, this way different consumer with same source can reuse this log. We can also assign an id to each found object so that we can remove already consumed object.

Maybe we can learn from delta lake and use a self maintained log to store changes from SQS, this way different consumer with same source can reuse this log.

I will look into this solution but our enumerator is stateless and this state can be extensive and it is not proper to keep it in etcd. @yezizp2012 can we let meta directly interact with storage?

We can also assign an id to each found object so that we can remove already consumed object.

I think a LSM tree like structure can do this

Maybe we can learn from delta lake and use a self maintained log to store changes from SQS, this way different consumer with same source can reuse this log.

I will look into this solution but our enumerator is stateless and this state can be extensive and it is not proper to keep it in etcd. @yezizp2012 can we let meta directly interact with storage?

This's much more like create materialized source for s3 source by default. One solution might works for it:

we can create materialized source for s3 source: (every record in s3 object with be added with an additional column 'object name', if we want to not only handle append-only s3 source but also the scenario that object could be removed mentioned by renjie:

Is it possible that user delete an object, and then put an object with same name? In this case we may miss the new one.

Then all materialized view upon S3 source will be MoM, the enumerator will consume the logs from SQS, and generate chunks by SQS message types:

create/append: insert records.
delete: remove all records with specific object name.

I'm not familiar with SQS, correct me if I'm wrong.

@yezizp2012 's idea sounds good to me. This way we can avoid

Too frequent scan of bucket.
Missing renamed object.

Also if we generate an auto incremental id for each object version, we can safely remove consumed object version in state store.

delete: remove all records with specific object name

We can assume s3 source is append-only and delete is no-op?
It doesn't seem possible to do all the deletions within one epoch.

delete: remove all records with specific object name

We can assume s3 source is append-only and delete is no-op?

agree. I prefer s3 source is append-only

Maybe we can learn from delta lake and use a self maintained log to store changes from SQS, this way different consumer with same source can reuse this log. We can also assign an id to each found object so that we can remove already consumed object.

My concern is this solution may lead to frequent config change, which can harm the source reader's efficiency.
Besides, meta is responsible for maintaining every actor's split assignment and pushing it down in failover scenes. It can be tricky to design what the connector persists.

Then all materialized view upon S3 source will be MoM, the enumerator will consume the logs from SQS, and generate chunks by SQS message types:

create/append: insert records.
delete: remove all records with specific object name.

I don't know if it is a common practice to ask users to provide both s3 and sqs. Do we need to provide a solution for users who do not provide sqs. @neverchanje

Could you provide some use cases of S3 sources? What does the schema of the S3 source look like? And what computations that user can do on S3 objects？

Whether to depend on SQS is a crucial problem here.
As mentioned by @waruto210, Flink's FileSystem connector simply scan the file in a fixed interval. The might be the most general cases, and most users don't even know that S3 can be configured to emit events into SQS.

Will propose a new S3 Source design. Close this one


Update Gatsbyjs guide

Add information about how GatsbyJS work which is the future of sites.

[ ] I have read freeCodeCamp's contribution guidelines.
[ ] My pull request has a descriptive title (not a vague title like Update index.md)
[ ] My pull request targets the master branch of freeCodeCamp.
[ ] None of my changes are plagiarized from another source without proper attribution.
[ ] My article does not contain shortened URLs or affiliate links.

If your pull request closes a GitHub issue, replace the XXXXX below with the issue number.
Closes #XXXXX

LGTM! Thanks for adding that detail about Gatsby, @Hassanraja447 and congratulations on your first contribution to the freeCodeCamp repository! 🎉 🥇 ⭐


Setting dates doesn't work properly - they are shifted by one day

Hi, when editing/storing entities with dates, the dates are shifted by one day back. I am not sure if you will be able to reproduce this. I came across similar issue in project using JSF and it was caused by TimeZone settings. My timezone is CET.

I've got the same behavior with GMT+1 timezone

hi @trepel , we are discussing about the new features we would like to have inside Petclinic. Since you have done quite a few pull requests, would you like to be involved?
We were not sure how to contact you. If you'd like you can email me directly on misvy at pivotal dot io.
Michael.


Unused projection layer in AttentionBlock

After wrapping a MONAI AutoencoderKL model in pytorch lightning, I got an error regarding an unused parameter in the custom AttentionBlock implementation.
diffusion_model_unet.py and  autoencoderkl.py line 233:
self.proj_attn = nn.Linear(num_channels, num_channels)

To me, it looks like this layers is completely unused. I cannot tell whether it is a mistake that this parameter is unsued, or if it should have never been defined in the first place.

Hello,
Apologies for the delay.
This repository is going to be archived, as it has all been integrated into MONAI Core (https://github.com/Project-MONAI/MONAI).
I believe this issue has been addressed during the porting.
Could you check by using the latest MONAI version incorporating the generative functions? If the issue persists there, please do open an Issue in MONAI Core and we will have a look as soon as possible.
Thank you very much!
Virginia


Added support for 14.x

Just a new line to support node 14.x runtime

Bump. We would like to use node14 and this is a hard block.

We have upgraded the node version to node14 so require this change to be merged.

We are also facing the same issue in an upgrade to the node14 runtime for our Lambda functions.

Bump. We would like to use node14 and this is a hard block.
@matt-filion

Yes, it was a problem for me too 😞
I made a patch-package to fix it temporarily.
Anyway, the lib doesn't seems to be being maintained.

This has happened before. I wouldn't say this project is abandoned, but it certainly ahs entered a state of stable, and doesnt get frequent attention. I think we found some emails before to some of the repo maintainers, will try to ping those.
@diogogvhenriques Are you able to help out in getting this merged?

Thanks for the help @marcoantoni0 and @matt-filion for pinging me.
We have been having a lot on our plate and has been hard to keep up with the update of the package.


Broken for 0.23.1

Since the release of 0.23.1 I'm getting this from the buildpack:
remote: -----> Crystal app detected
remote: -----> Installing Crystal (0.23.1 due to latest release at https://github.com/crystal-lang/crystal)...
remote: gzip: stdin: not in gzip format
remote: tar: Child returned status 1
remote: tar: Error is not recoverable: exiting now
remote: done
remote: -----> Installing Dependencies... /app/tmp/buildpacks/7cae2d464297fe40ab4f8baf661b5905138e7a4679faeb1e9b99b4ed6b787bc446f63a669c7a918dc21952d53acb6cac9426f13ed74d85acdccff4c0dc00b0f6/bin/compile: line 65: crystal: command not found

Something changed about the upstream filenames, perhaps?

This URL assumes package version 0.23.0-1 but for this release it is acually 0.23.1-3.
CRYSTAL_URL="https://github.com/crystal-lang/crystal/releases/download/$CRYSTAL_VERSION/crystal-$CRYSTAL_VERSION-1-linux-x86_64.tar.gz"

Just ran into this.. am working around it by using 0.22.0 for now, by creating a file .crystal-version with that version in it.

We can either extract the correct tar.gz name from the response of curl https://api.github.com/repos/crystal-lang/crystal/releases/latest or change our naming policy so that the tar.gz name is a function of the version (that means either dropping the -1, -2, -3 suffixes so we end up with CRYSTAL_URL="https://github.com/crystal-lang/crystal/releases/download/$CRYSTAL_VERSION/crystal-$CRYSTAL_VERSION-linux-x86_64.tar.gz or adding them as a 4th component of the version so we end up with CRYSTAL_VERSION=<IP_ADDRESS> in this case).
I'd vote to drop the -X suffixes in tar.gz names. @matiasgarciaisaia thoughts about going that way?

Hi there!
It's effectively because of the released tar.gz name. The published 0.23.1 was the third build - there was a first build published in one of the issues, a second build shared internally that was plain wrong, and this last one that worked.
I'm still not sure about The Way™ to handle this. If it's not that much work to simply extract the name from the URL, I'd love to do that for now.
We have started discussing distribution channels (some beta channel vs a stable one) that will imply betas, release candidates, etc, so I think we should first define that, and then choose between a build version (like the -1, -X we have now) and some other suffix.
But I think a suffix will be there for a while, at least.
Any other thoughts?

To unblock this we can create a fallback from -1 to -5 in case a 404 is reached

The info is there, I just was wondering if it's worth having many builds per version, given the only reason that happens is because of packaging errors.
Anyway, there's an "assets" collection in the json response that holds the exact name of each file we distribute. We can iterate that and look for linux-x86_64.tar.gz suffix, and we'd be pretty sure that's the right file. I had started to work on this but ran out of time and won't be in front of a computer for two weeks. Just sharing the "research" in case someone wants to give it a try before!

Something I neglected to mention in the original bug report is that this error took my app down, because the buildpack didn't fail after the 404 - it tried to deploy the app without a compiler installed.
Whatever the solution to the above, it's probably worth making sure that future filename changes / 404s don't take apps down with them.

Please review #24 so we fix this 👍

Thanks!


documentserver receives redirect 301 code and immediately displays error

When i try to create a new document in nextcloud a new tab is opened that has "Loading, please wait." with a white screen. I checked the logs on the documentserver and it has connection refused.
Im not sure if its the  document server or nginx reverse proxy causing the issue.
==> /var/log/onlyoffice/documentserver/nginx.error.log <==
2020/01/06 11:08:23 [error] 747#747: *2 connect() failed (111: Connection refused) while connecting to upstream, client: 172.20
.0.2, server: , request: "GET /healthcheck HTTP/1.1", upstream: "http://<IP_ADDRESS>:8000/healthcheck", host: "onlyoffice", referr
er: "https://onlyoffice.example.com/welcome/"

2020/01/06 11:08:23 [error] 747#747: *2 connect() failed (111: Connection refused) while connecting to upstream, client: 172.20
.0.2, server: , request: "GET /healthcheck HTTP/1.1", upstream: "http://<IP_ADDRESS>:8000/healthcheck", host: "onlyoffice", referr
er: "https://onlyoffice.example.com/welcome/"

2020/01/06 11:08:24 [error] 747#747: *5 no live upstreams while connecting to upstream, client: <IP_ADDRESS>, server: , request:
"GET /welcome/img/icon-cross.png HTTP/1.1", upstream: "http://docservice/welcome/img/icon-cross.png", host: "onlyoffice", refer
rer: "https://onlyoffice.example.com/welcome/"

#Nginx reverse proxy
server {
	listen 443 ssl http2;
	server_name onlyoffice.example.com;
	location / {
		proxy_set_header Upgrade $http_upgrade;
	        proxy_set_header X-Forwarded-Host $host;
                proxy_set_header X-Forwarded-Proto $scheme;
                proxy_set_header X-Forwarded-For $proxy_add_x_forwarded_for;
                proxy_pass http://onlyoffice;
                proxy_http_version 1.1;
                #proxy_set_header Upgrade $http_upgrade;
                proxy_set_header Connection "upgrade";
		proxy_connect_timeout  3600s;
                proxy_read_timeout  3600s;
                proxy_send_timeout  3600s;

	}
}

Are there errors in the browser console when opening the editor?

yes there are errors in console but after reinstalling the document server i now receive error "the document could not be saved. Attaching screenshots and updated logs.

[2020-01-08T01:19:43.333] [WARN] nodeJS - Plugins watch exception (https://nodejs.org/docs/latest/api/fs.html#fs_availability).
[2020-01-08T01:19:43.360] [WARN] nodeJS - update cluster with 1 workers
[2020-01-08T01:19:43.372] [WARN] nodeJS - worker 764 started.
[2020-01-08T01:19:43.372] [WARN] nodeJS - update cluster with 1 workers
[2020-01-08T01:19:43.857] [WARN] nodeJS - Express server starting...
[2020-01-08T01:19:44.647] [WARN] nodeJS - Express server listening on port 8000 in production-linux mode
[2020-01-08T01:20:08.829] [WARN] nodeJS - Plugins watch exception (https://nodejs.org/docs/latest/api/fs.html#fs_availability).
[2020-01-08T01:20:08.842] [WARN] nodeJS - update cluster with 1 workers
[2020-01-08T01:20:08.849] [WARN] nodeJS - worker 836 started.
[2020-01-08T01:20:08.849] [WARN] nodeJS - update cluster with 1 workers
[2020-01-08T01:20:09.329] [WARN] nodeJS - Express server starting...
[2020-01-08T01:20:09.986] [WARN] nodeJS - Express server listening on port 8000 in production-linux mode
[2020-01-08T01:32:36.164] [ERROR] nodeJS - postData error: docId = 173335947;url = http://nc.m400cloud.com/apps/onlyoffice/track?doc=eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJ1c2VySWQiOiJtaWtlIiwiZmlsZUlkIjoxMTIsImZpbGVQYXRoIjoiXC9hYmMuZG9jeCIsInNoYXJlVG9rZW4iOm51bGwsImFjdGlvbiI6InRyYWNrIn0.EWo6KBqF6-ZtcvfrVlvJR5UFLDjmxTt8XKsNgylBv8s;data = {"key":"173335947","status":1,"users":["ocxhbukekiw0_mike"],"actions":[{"type":1,"userid":"ocxhbukekiw0_mike"}]}
Error: Error response: statusCode:301 ;body:

<title>301 Moved Permanently</title>

301 Moved Permanently

nginx

    at Request._callback (/var/www/onlyoffice/documentserver/server/Common/sources/utils.js:301:23)
    at Request.self.callback (/var/www/onlyoffice/documentserver/server/Common/node_modules/request/request.js:185:22)
    at emitTwo (events.js:126:13)
    at Request.emit (events.js:214:7)
    at Request.<anonymous> (/var/www/onlyoffice/documentserver/server/Common/node_modules/request/request.js:1161:10)
    at emitOne (events.js:116:13)
    at Request.emit (events.js:211:7)
    at IncomingMessage.<anonymous> (/var/www/onlyoffice/documentserver/server/Common/node_modules/request/request.js:1083:12)
    at Object.onceWrapper (events.js:313:30)
    at emitNone (events.js:111:20)
    at IncomingMessage.emit (events.js:208:7)
    at endReadableNT (_stream_readable.js:1064:12)
    at _combinedTickCallback (internal/process/next_tick.js:139:11)
    at process._tickCallback (internal/process/next_tick.js:181:9)

@alexanderonlyoffice thank you thank you, that was the problem. "Server address for internal requests from the Document Editing" defaulted to http://nc.example.com which is wrong, https://nc.example.com is correct. Also must us FQDN not docker service name.

Dont know why the default protocol there is http, it should be https or at least, in some place tell you that he cant save document is related to that.


Add api endpoints for descriptions

Another thing requested by a group of users:
This adds basic GET-only API2 endpoints for name and location descriptions.  It only returns public descriptions, so that we can avoid the whole permissions quagmire.
Also, it moves classification info for names from the high-detail to the low-detail response.  (There are no includes required, so it really belongs there anyway, but I had put it in high-detail because significant parsing is required.)
Basic tests are added for both the tweaks required by Query as well as the new API2 endpoints.
Everything passes tests and rubocop locally.

Coverage: 93.492% (-0.01%) from 93.506% when pulling 9a7f3a2924e06848bfbc613b8d95fec2cfbd5d03 on add-api-endpoints-for-descriptions into efde94dc2b73a9036383ea432f22118d101806fd on main.


Potential for Panic in From Implementation

in the folowing code: https://github.com/GnomedDev/small-fixed-array/blob/101610c061830127811ed3414de1794996a20eb0/src/non_empty_array.rs#L42
two potential panics can occur, one of which is "impossible" as far as the public api is concerned, because only non empty slices will ever call this, but an overflow also immediately panics, this is a poor behavior in the first place (error recovery should be given to users of the crate), however it is also against the From/Into implementation guidelines:
Note: This trait must not fail. The From trait is intended for perfect conversions. If the conversion can fail or is not perfect, use TryFrom.

I personally see this as similar to the panics on allocation failure or similar, it isn't exactly useful for most users to have to deal with "Yes I'm not going to fill this string with 2gb of data", but I'd like to see another opinion other than "but the trait docs say".

I've fixed this by truncating array lengths and triggering a log/tracing warning in From implementations, and removing From where this is not possible.


Prune products on NIH deployment

Currently we have only 2 active products on this deployment. osparc and s4llite. The other two should be removed.

Follwed up in https://github.com/ITISFoundation/osparc-simcore/issues/5337


WOS-336 update ci-dev.yml to use correct command for e2e functional tests

Description
Update ci-dev.yml to use correct command for e2e functional tests.
Motivation and Context
In this PR https://github.com/websight-io/starter/pull/173 I forgot to update ci-dev.yml workflow

Screenshots (if appropriate)
Upgrade notes (if appropriate)

Types of changes

[x] Bug fix (non-breaking change which fixes an issue) labeled with bug
[ ] New feature (non-breaking change which adds functionality) labeled with enhancement
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

[x] My code follows the code standards of this project.
[ ] My change requires updating the documentation. I have updated the documentation accordingly.

I have read the Dynamic Solutions Individual Contributor License Agreement (CLA) Document and I hereby sign the CLA

recheck

recheck


AddIcon doesn't exist?

Description
I'm really new at using gluestack-ui, react native and expo. So the problem is that I can't seems to use the button compenent?
CodeSandbox/Snack link
No response
Steps to reproduce

gluestack-ui Version
3.3.1
Platform

[X] Expo
[ ] React Native CLI
[ ] Next
[ ] Web
[X] Android
[ ] iOS

Other Platform
No response
Additional Information
No response

@Bossburnz Thanks for reporting this. We'll have a look.

Hey @Bossburnz, Could you please provide the code snippet of how you're using the button component? Also, it seems like the AddIcon is not being imported properly. Can you let me know from where you're importing it? It would be really helpful.

For reference you can use it like this:
 import {Icon, AddIcon} from '@gluestack-ui/themed';

 <Icon as={AddIcon} w="$4" h="$4" />


chip-tool write-by-id returns constraint-error while write works

Reproduction steps
./chip-tool thermostat write-by-id 25 10 1 1 -> CONSTRAINT_ERROR,
./chip-tool thermostat write min-setpoint-dead-band 10 1 1 -> success.
log from thermostat linux app:
thermostat-write-by-id.log
Bug prevalence
always
GitHub hash of the SDK that was being used
7026061c16
Platform
other
Platform Version(s)
No response
Anything else?
No response

write-by-id clearly documents how its arguments work:
attribute-values:
...
  * unsigned integer: One of:
      a) The number directly, as decimal.
      b) The number directly, as 0x followed by hex digits. (Only for the toplevel value, not inside structs or lists.)
      c) A string starting with "u:" followed by decimal digits
  * signed integer: One of:
      a) The number directly, if it's negative.
      c) A string starting with "s:" followed by decimal digits

10 is not negative, so it gets treated as "unsigned integer".  But you're trying to write a signed value, so that fails.
You want "s:10" for the value.


Traefik 2.2 middleware annotations on K8s ingress is never found

Do you want to request a feature or report a bug?

Bug

What did you do?
Traefik service:
apiVersion: v1
kind: ServiceAccount
metadata:
  name: traefik-ingress-controller
  namespace: tf

---
kind: Deployment
apiVersion: apps/v1
metadata:
  name: traefik
  namespace: tf
  labels:
    app: traefik

spec:
  replicas: 1
  selector:
    matchLabels:
      app: traefik
  template:
    metadata:
      namespace: tf
      labels:
        app: traefik
    spec:
      serviceAccountName: traefik-ingress-controller
      containers:
        - name: traefik
          image: traefik:v2.2
          args:
            - --log.level=DEBUG
            - --api
            - --api.insecure
            - --entrypoints.web.address=:80
            - --providers.kubernetesingress=true
          ports:
            - name: web
              containerPort: 80
            - name: admin
              containerPort: 8080

---
apiVersion: v1
kind: Service
metadata:
  name: traefik
  namespace: tf
spec:
  type: LoadBalancer
  selector:
    app: traefik
  ports:
    - protocol: TCP
      port: 80
      name: web
      nodePort: 32200
    - protocol: TCP
      port: 8080
      name: admin
      nodePort: 32201

ClusterRole:
---
  kind: ClusterRole
  apiVersion: rbac.authorization.k8s.io/v1beta1
  metadata:
    name: traefik-ingress-controller
  rules:
    - apiGroups:
        - ""
      resources:
        - services
        - endpoints
        - secrets
      verbs:
        - get
        - list
        - watch
    - apiGroups:
        - extensions
      resources:
        - ingresses
      verbs:
        - get
        - list
        - watch
    - apiGroups:
        - extensions
      resources:
        - ingresses/status
      verbs:
        - update
    - apiGroups:
       - traefik.containo.us
      resources:
        - middlewares
        - ingressroutes
        - traefikservices
        - ingressroutetcps
        - ingressrouteudps
        - tlsoptions
        - tlsstores
      verbs:
        - get
        - list
        - watch

---
kind: ClusterRoleBinding
apiVersion: rbac.authorization.k8s.io/v1beta1
metadata:
  name: traefik-ingress-controller
roleRef:
  apiGroup: ""
  kind: ClusterRole
  name: traefik-ingress-controller
subjects:
  - kind: ServiceAccount
    name: traefik-ingress-controller
    namespace: tf
    apiGroup: ""

Middleware:
apiVersion: traefik.containo.us/v1alpha1
kind: Middleware
metadata:
  name: traefik-security-headers
  namespace: tf
spec:
  headers:
    frameDeny: "true"
    contentTypeNosniff: "true"
    browserXssFilter: "true"

Ingress:
kind: Ingress
apiVersion: networking.k8s.io/v1beta1
metadata:
  name: myingress
  namespace: tf
  annotations:
    traefik.ingress.kubernetes.io/router.entrypoints: web
    traefik.ingress.kubernetes.io/router.middlewares: traefik-security-headers
spec:
  rules:
    - http:
        paths:
          - path: /bar
            backend:
              serviceName: whoami
              servicePort: 80
          - path: /foo
            backend:
              serviceName: whoami
              servicePort: 80

The middleware is never detected. I tried with several providers:
traefik.ingress.kubernetes.io/router.middlewares: traefik-security-headers@tf
traefik.ingress.kubernetes.io/router.middlewares: traefik-security-headers@kubernetesrcd

What did you expect to see?
My routes with the Middleware correctly applied to them
What did you see instead?

Output of traefik version: (What version of Traefik are you using?)

Version:      2.2.0
Codename:     chevrotin
Go version:   go1.14.1
Built:        2020-03-25T17:32:57Z
OS/Arch:      linux/amd64

What is your environment & configuration (arguments, toml, provider, platform, ...)?
# (paste your configuration here)

If applicable, please paste the log output in DEBUG level (--log.level=DEBUG switch)
time="2020-04-13T16:57:50Z" level=debug msg="Skipping Kubernetes event kind *v1.Endpoints" providerName=kubernetes
time="2020-04-13T16:57:50Z" level=warning msg="Ingress tf/myingress: the apiVersion 'extensions/v1beta1' is deprecated, use 'networking.k8s.io/v1beta1' instead."
time="2020-04-13T16:57:50Z" level=debug msg="Skipping Kubernetes event kind *v1.Endpoints" providerName=kubernetes
time="2020-04-13T16:57:52Z" level=warning msg="Ingress tf/myingress: the apiVersion 'extensions/v1beta1' is deprecated, use 'networking.k8s.io/v1beta1' instead."
time="2020-04-13T16:57:52Z" level=debug msg="Skipping Kubernetes event kind *v1.Endpoints" providerName=kubernetes
time="2020-04-13T16:57:52Z" level=warning msg="Ingress tf/myingress: the apiVersion 'extensions/v1beta1' is deprecated, use 'networking.k8s.io/v1beta1' instead."
time="2020-04-13T16:57:52Z" level=debug msg="Skipping Kubernetes event kind *v1.Endpoints" providerName=kubernetes
time="2020-04-13T16:57:54Z" level=warning msg="Ingress tf/myingress: the apiVersion 'extensions/v1beta1' is deprecated, use 'networking.k8s.io/v1beta1' instead."
time="2020-04-13T16:57:54Z" level=debug msg="Skipping Kubernetes event kind *v1.Endpoints" providerName=kubernetes
time="2020-04-13T16:57:54Z" level=warning msg="Ingress tf/myingress: the apiVersion 'extensions/v1beta1' is deprecated, use 'networking.k8s.io/v1beta1' instead."
time="2020-04-13T16:57:54Z" level=debug msg="Skipping Kubernetes event kind *v1.Endpoints" providerName=kubernetes
time="2020-04-13T16:57:56Z" level=warning msg="Ingress tf/myingress: the apiVersion 'extensions/v1beta1' is deprecated, use 'networking.k8s.io/v1beta1' instead."
time="2020-04-13T16:57:56Z" level=debug msg="Skipping Kubernetes event kind *v1.Endpoints" providerName=kubernetes
time="2020-04-13T16:57:56Z" level=warning msg="Ingress tf/myingress: the apiVersion 'extensions/v1beta1' is deprecated, use 'networking.k8s.io/v1beta1' instead."
time="2020-04-13T16:57:56Z" level=debug msg="Skipping Kubernetes event kind *v1.Endpoints" providerName=kubernetes
time="2020-04-13T16:57:58Z" level=warning msg="Ingress tf/myingress: the apiVersion 'extensions/v1beta1' is deprecated, use 'networking.k8s.io/v1beta1' instead."
time="2020-04-13T16:57:58Z" level=debug msg="Skipping Kubernetes event kind *v1.Endpoints" providerName=kubernetes
time="2020-04-13T16:57:58Z" level=warning msg="Ingress tf/myingress: the apiVersion 'extensions/v1beta1' is deprecated, use 'networking.k8s.io/v1beta1' instead."
time="2020-04-13T16:57:58Z" level=debug msg="Skipping Kubernetes event kind *v1.Endpoints" providerName=kubernetes
time="2020-04-13T16:58:00Z" level=warning msg="Ingress tf/myingress: the apiVersion 'extensions/v1beta1' is deprecated, use 'networking.k8s.io/v1beta1' instead."
time="2020-04-13T16:58:00Z" level=debug msg="Skipping Kubernetes event kind *v1.Endpoints" providerName=kubernetes
time="2020-04-13T16:58:00Z" level=warning msg="Ingress tf/myingress: the apiVersion 'extensions/v1beta1' is deprecated, use 'networking.k8s.io/v1beta1' instead."
time="2020-04-13T16:58:00Z" level=debug msg="Skipping Kubernetes event kind *v1.Endpoints" providerName=kubernetes
time="2020-04-13T16:58:02Z" level=warning msg="Ingress tf/myingress: the apiVersion 'extensions/v1beta1' is deprecated, use 'networking.k8s.io/v1beta1' instead."
time="2020-04-13T16:58:02Z" level=debug msg="Skipping Kubernetes event kind *v1.Endpoints" providerName=kubernetes
time="2020-04-13T16:58:02Z" level=warning msg="Ingress tf/myingress: the apiVersion 'extensions/v1beta1' is deprecated, use 'networking.k8s.io/v1beta1' instead."
time="2020-04-13T16:58:02Z" level=debug msg="Skipping Kubernetes event kind *v1.Endpoints" providerName=kubernetes

Thanks for your interest in the project!
In fact, when you create a middleware with the kubernetescrd provider, as you can put namespace on the Middleware definition, the name of the middleware can't be the same as the Name in your kubernetes resource. If you want to find the "real" name of your middleware, you can find it in the webui and use the "complete_middleware_name@kubernetescrd" in your ingress.
If you want more help, please join our Community Forum and reach out to us on the Traefik section.


Fix CloseHandle definition

The defining place for CloseHandle is wrong.
I fixed to move it from WinSock to RbWinSock.

Looks good :-)
As we talked offline, welcome to the ServerEngine committers group :+1:
Please merge this commit, and release a new version. https://github.com/fluent/serverengine/commit/a7df7d8613be9cb51ab018e2362ca7672a010e24 will be helpful for the release process.

Thank you very much!
I'll merge this.


Fix server error handling

The current implementation of AsyncClientBase will call success after for TMessageType.EXCEPTION exceptions. The simple fix would have been to return  when getting an AbortException, but I decided to streamline it a bit. Now fail and success are each only called in a single place and there is no separate exception handling anymore.

Codecov Report

Merging #150 into master will increase coverage by <.01%.
The diff coverage is 60%.

@@             Coverage Diff              @@
##             master     #150      +/-   ##
============================================
+ Coverage     65.45%   65.46%   +<.01%
  Complexity      932      932
============================================
  Files            88       88
  Lines          4803     4804       +1
  Branches        562      561       -1
============================================
+ Hits           3144     3145       +1
- Misses         1422     1423       +1
+ Partials        237      236       -1

Impacted Files
Coverage Δ
Complexity Δ

...java/com/microsoft/thrifty/service/ClientBase.java
51.16% <57.14%> (-0.06%)
4 <0> (ø)

...com/microsoft/thrifty/service/AsyncClientBase.java
62.35% <66.66%> (-0.44%)
7 <0> (-1)

...in/java/com/microsoft/thrifty/schema/Location.java
78.04% <0%> (+2.43%)
16% <0%> (+1%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dac6432...65d24fb. Read the comment docs.

ThriftException usually means that client and server are incompatible - they aren't using the same service definitions, or the client is trying to connect to a non-thrift endpoint, etc.  To me, it has always seemed better to just throw it and let someone else decide how to handle it.
Why would we not want that for synchronous clients?

I'm not suggesting to handle the exception inside thrifty for the synchronous client. The current behavior of the sync client (both before and after this pr) is that all ThriftExceptions are thrown. The question is do we want to make it easier for consumers to handle this case of ThriftException on a per method level. The async client does that by passing it to onError() in ServiceMethodCallback. Other ThriftExceptions are thrown, cause a client shutdown and are than passed to AsyncClientBase.Listener.onErrror(). The sync client does not have different callbacks so we could use a different type to do that.

this case of ThriftException
I'm referring to ThriftExceptions caused by a response with metadata.type == TMessageType.EXCEPTION. They seem to happen when the server throws a TException that isn't declared in the schema (not sure if there are other cases where).

As far as I recall, TMessageType.EXCEPTION is sent in response to protocol-level problems, as well as undeclared server exceptions.  I actually forgot about the undeclared-server-exception behavior!  In that light, I agree that we should just pass all of these on to client callbacks, rather than throw some and pass others.
It seems like the Apache implementation does it that way, too - any TMessageType.EXCEPTION in an async client gets passed to the method's callback, as opposed to shutting down the client.

Should be good to go now.

Hm, I didn't realize that this change would require making adapters declare a checked exception! I see that the need arises from the enum validation that we do in GenerateServiceReader.  I think that we should land this change, then I'll switch the generated exception to a RuntimeException of some sort and undo just the adapter change.
Thanks for bearing with me!  Now, on to your larger change...


Embedded video from notebook do not show anymore on static GitHub page

What version of mystjs are you using?
v1.0.3
How did you install myst?
npm
What operating system are you using?
Mac
Which area is this feature request for?
Other
Describe the Bug
I have a notebook with an embedded video (https://github.com/kolibril13/okapi/blob/main/media_notebook.ipynb?short_path=9bf3cf3#L63), which has the label #| label: my-vid-embedded.
2 weeks ago (on Jun 16, 2023), I pushed that notebook to GitHub pages using the workflow described here:
https://mystmd.org/guide/deployment#deploying-to-github-pages
and the video is displayed in the myst document correctly on GitHub pages
https://kolibril13.github.io/okapi/
I just tried to reproduce this in another project, but by today, displaying linked videos on static pages does not work anymore. I made a 100% identical copy of the repo, and it did not work, so I assume it must be related to version updates in GitHub actions.
Expected Behavior
Cross-referenced embedded videos should be displayed on Github Pages.
To Reproduce

Forking this repository https://kolibril13.github.io/okapi/ and activate github actions.
Visit the webpage, the video will render correctly.
Make a commit to that fork, this will trigger the ci.
Visit the github pages page again e.g. https://octoframes.github.io/okapi/ -> now the video won't show anymore.

It would be awesome if this feature could be enabled again! :)

I just did some more testing on Image, GIF and Video in this minimal example repo:
https://github.com/Octoframes/myst-online-media-testing
Images and GIFs are linked correctly, it's only the video that is not displayed, as can be seen here:
https://octoframes.github.io/myst-online-media-testing/hello

Thanks for the bug report! @stevejpurves, I think this is likely the changes that we have made to thebe as we get things ready for being attached to live kernels?

Hey @rowanc1 , thanks for your quick reply :)
Just did some more testing, SVGs are broken as well:
https://github.com/Octoframes/myst-online-media-testing/blob/main/media_notebook.ipynb
https://octoframes.github.io/myst-online-media-testing/hello

ok - i think the recent change in thebe to force explicit creation of a rendermine factory might have impacted this. I'll take a look next!

update: looks like this is actually an issue with how thebe-core is now loaded (which was also changes recently) and it's looking in the wrong location.

We will get this deployed shortly and it should start working again!

tested and working on a fork of your repo @kolibril13 https://stevejpurves.github.io/myst-online-media-testing/hello

It won't work yet -- hoping that we can release this later today! I will follow up here when it is deployed!

Thanks for the response! Your support is absolutely awesome :)

A rerun of the github action should fix things now!
🐶 🚰 📺 🚀

That's awesome!!!
I've just tested this for some more image, video, gif, svg, dataframe and tweet,  and it's all working out of the box! :)
https://octoframes.github.io/myst-online-media-testing/hello


Release 6.0 (spec)

This "issue" is made for a list of potential things that can be included in release 6.0
-> some of them could just be added as a minor release

[x] #356 #373 hasezoey#7 - Continuation of branch feature/4, to remove the Typegoose class [E][B]
[ ] #216 hasezoey#9 - Typegoose Native support for GridFS [E][NN][hasezoey#10]
[x] #186 hasezoey#6 - move ModelOptions to decorator @options [E][B]
[ ] #146 #148 #149 - allow more than just ObjectId on Ref<> or do Ref<Class, Type>, when possible [FP][#369] (~5.10.0?)
[x] #313 - Array for hooks [NN]
[ ] #355 - Array Transforms - waiting for mongoose to fix the issue [FP]
[ ] #333 - Discriminators [FP][B, currently, no way to fix it]
[ ] #367  - Move from TSLint to @typescript-eslint/ [E] (potentially requires code-re-style) - post-pound until vscode-eslint "integrates" it and @typescript-eslint improves more
[x] #366 - Rename InstanceType to something not conflicting [E][B]
[x] hasezoey#5 - modify get & set to be an actual prop [E][B]
[x] hasezoey#3 - Move data.ts collections to Maps [E][B]
[x] #48 #246 #182 - use loadClass instead of self-handling [E][B]
[x] #28 - this is not set - added documentation in 6.0.0 [E]

Tag legend:

[FP] - Feature-Parity
[E] - Enhancement
[NN] - Not-Native (to mongoose)
[B] - Breaking

More could be added, or some could get removed

My favorites are #356 and #258 👍

#258 got removed from the spec, reasons in https://github.com/szokodiakos/typegoose/issues/258#issuecomment-518450690

The Current road-blocks for release 6.0.0 to be finished:

as described in #355, the mongoose issue must be fixed first (release 1.9.2019?)
reinvestigate #333 after all the changes

This is the changelog for 6.0.0, this will be modified until 6.0.0 releases
Changelog
To Migrate, please look at the migration guide

rename InstanceType<T> to DocumentType<T> szokodiakos#366
adding a migration guide from ~5.9 to 6.0.0 108dd7cd38e8ddc8325be38dc87e245a6e4c66ff
adding missing "get" and "set" property options a123c490297197fda77e1adedc39205da5e821ba [szokodiakos#260]
adding @modelOptions and removing it from getModelForClass and setModelForClass
setModelForClass is now deprecated cec331ca04d6844ec8934c1a83452d3a85470181
a7fc359430a72a8c18af2661b70e69ee0d5304a1 [hasezoey#6, szokodiakos#186]
setting the Typegoose Class to abstract bc6ad9cef537a797181d97a7c11823a208c4cdc1
deprecating the Typegoose Class because of making the functions outsourced 4015ea7215cfbf451458cb01c1e0187492c3282c [szokodiakos#356]
hook methods can now be arrays of methods 5b1f29d323eef0835bcd62bd5af51415eb318951 [szokodiakos#313]
completely removed parallel from pre hooks aa86c978edc07c1dc166b3c55a8b4b47e8bec841
refactored the types of hooks aa86c978edc07c1dc166b3c55a8b4b47e8bec841
adding support for any value in prop for plugins 62cac052e54f40bc4b2cf57c86b505686103bb1c [szokodiakos#374]
schema.loadClass is now used instead of @instanceMethod and @staticMethod cec331ca04d6844ec8934c1a83452d3a85470181 [szokodiakos#48 szokodiakos#246 szokodiakos#182]
method decorators are now deprecated cec331ca04d6844ec8934c1a83452d3a85470181
schema generation got refactored (/reconstructed) multiple times
adding count to VirtualOptions cec331ca04d6844ec8934c1a83452d3a85470181
Updated Dependencies<EMAIL_ADDRESS>27d3bbfb84dcfa514baf65cf917f685b58c1d47f
adding discriminator support hasezoey#11
adding default class for (schemaOptions) timestamps 3316a6ed32255b86b139fe8cbcea0b9b61afab27
adding more docs to README & as tsdoc
some changes that are probably forgot
szokodiakos#363 got reverted in favor of<EMAIL_ADDRESS>[IC] Remake data.ts to use Maps hasezoey#3
[IC] adding many tests and bumping coverage
[IC] moving many Types to types.ts f14ba54303f7f36950993627dd6a8955ebef46f7
[IC] removing unneeded dependencies c3211ab808dc70bc227e34a46940bee4d472e6bd
[IC] changed how travis runs jobs multiple times
[IC] many tslint rule changes

([IC] means Internal Change)

@hasezoey many thanks for maintaining this awesome project!

@Ben305  Thanks for all the work that you already get done with Typegoos!
Saved us a lot of time!
What do you think about adding @hasezoey as a contributor to this project? It would simplify the organization for the 6.0.0 version.

@B-Stefan collaborators cant add another collaborators, only the owner of the project can

This is unfortunately true

in version 6.0.0-22 the functions in the Typegoose-Class are re-added with a deprecation warning (and just as a pass-through to the new syntax)

I think version 6 is now stable enough, with many features & bug fixes, so i think to release it on the 30.9.2019
Please know that the new releases only come out on the new repo https://github.com/typegoose/typegoose
and under the package @typegoose/typegoose, but pre-releases are currently in @hasezoey/typegoose

Closing this because Version 6.0.0 got released, under the package name @typegoose/typegoose
here is the changelog


Region Suggest Error

When you attempt to suggest a new region you receive the error: "Request failed: internal server error (500)

This should be fixed now (in your current build). SQL change.

Checked on iPad. All good.


Planning Date vs. Planned Delivery Date

When I change the "Planning Date", the "Planned Delivery Date" changes to match the "Planning Date", and vice versa.  I think this is counter-intuitive.  Why two dates, if they always match?  I would like to have a "Start Date" and "End Date" for each budgeted line item.  The description in the documentation indicates the "Planning Date" is the date a budgeted, billable, or "budget and billable" line is to be delivered.  It says nothing about the "Planned Delivery Date".  Why these two dates are always the same, and why there isn't any "start date" is not explained here.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 9d120b85-a4c6-8a89-ff10-fe19b78ef924
Version Independent ID: dd35a369-e248-d790-9ea8-2b4b896cc059
Content: Set Up and Manage a Budget for a Job - Business Central
Content Source: business-central/projects-how-manage-budgets.md
Service: dynamics365-business-central
GitHub Login: @SorenGP
Microsoft Alias: sgroespe

Thank you for the feedback
I have investigated if the two fields can ever be different, for example per a lead-time setting. This is not the case, so I agree with you that the design is confusing. It seems that only the Planned Delivery Date field is relevant for the user as this is where you define the "end date". The Planning Date field, according to the tooltip, is used for filtering in various job reports.
Please choose the Product feedback button to suggest a product improvements, such as to hide the Planning Date field or resolve the confusion somehow else.
Meanwhile, I have updated the topic to explain this better, and I have explained the relation of the Planned Delivery Date field with the End Date and Start Date fields on the related job task. The updated help will be available in approximately one week.

The Planning Date is changed via the Change Job Dates report. The Planned Delivery Date remains on the same date.
I don't know if this really makes sense.


Dependency on krbclient

It deems like Kerberos support is slated somewhere down the line.  However the current package.json requires krbclient.  When running an NPM install the following output will display:
..\src\krbclient.cc(5): fatal error C1083: Cannot open include file: 'gssapi/gs
sapi.h': No such file or directory [C:\Users\knguyen\AppData\Roaming\npm\node_m
odules\winrmjs\node_modules\krbclient\build\krbclient.vcxproj]
gyp ERR! build error
gyp ERR! stack Error: C:\Program Files (x86)\MSBuild\12.0\bin\msbuild.exe fai
ed with exit code: 1
gyp ERR! stack     at ChildProcess.onExit (c:\Program Files\nodejs\node_modules
npm\node_modules\node-gyp\lib\build.js:267:23)
gyp ERR! stack     at ChildProcess.emit (events.js:98:17)
gyp ERR! stack     at Process.ChildProcess._handle.onexit (child_process.js:810
12)
gyp ERR!  Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>install script.
npm ERR! This is most likely a problem with the krbclient package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     node-gyp rebuild
npm ERR! You can get their info via:
npm ERR!     npm owner ls krbclient
npm ERR! There is likely additional logging output above.
npm ERR! System Windows_NT 6.1.7601
npm ERR! command "c:\Program Files\nodejs\node.exe" "c:\Program Files\node
s\node_modules\npm\bin\npm-cli.js" "install" "winrmjs" "-g"
npm ERR! cwd d:\git\Hurdr
npm ERR! node -v v0.10.31
npm ERR! npm -v 1.4.23
npm ERR! code ELIFECYCLE
npm ERR!
npm ERR! Additional logging details can be found in:
npm ERR!     d:\git\Hurdr\npm-debug.log
npm ERR! not ok code 0
The Readme.md from your node-krbclient project shows that it is very much a work in progress.  Reccomend that you remove this dependency until the other repository is completed.

unfortunately this project has become less of a priority at the moment, but this will be fixed in the next month. in the meanwhile, please manually remove from package.json


Tried To register two Views with the same name RTCVideoView in React Native

I am trying to run my app on Android but I am getting this error I don't know why I am getting this, I don't know what is causing this error in my project I have tried tried many ways to resolve this issue but Still wasn't able to resolve this issue.
Tried To register two Views with the same name RTCVideoView
My Package.json is

{
  "name": "Hello World",
  "version": "0.0.1",
  "private": true,
  "scripts": {
    "start": "react-native start",
    "test": "jest",
    "lint": "eslint ."
  },
  "dependencies": {
    "@ptomasroos/react-native-multi-slider": "^1.0.0",
    "@react-native-community/async-storage": "^1.6.2",
    "@react-native-community/slider": "^2.0.0",
    "axios": "^0.19.0",
    "connectycube-reactnative": "^1.7.3",
    "lodash": "^4.17.15",
    "moment": "^2.24.0",
    "prop-types": "^15.7.2",
    "react": "16.8.6",
    "react-native": "0.60.5",
    "react-native-autogrow-textinput": "^5.2.0",
    "react-native-cache-store": "^1.0.2",
    "react-native-calendars": "^1.212.0",
    "react-native-deck-swiper": "^1.6.7",
    "react-native-image-picker": "^1.1.0",
    "react-native-linear-gradient": "^2.5.6",
    "react-native-modal-datetime-picker": "^7.5.0",
    "react-native-navigation": "^3.0.0",
    "react-native-scrollable-tab-view": "^0.10.0",
    "react-native-swiper": "^1.5.14",
    "react-native-vector-icons": "^6.6.0",
    "react-native-view-overflow": "^0.0.4",
    "react-native-webrtc": "^1.75.0",
    "react-redux": "^7.1.1",
    "redux": "^4.0.4",
    "redux-logger": "^3.0.6",
    "redux-persist": "^6.0.0",
    "redux-thunk": "^2.3.0",
    "rn-prompt": "^1.0.4"
  },
  "devDependencies": {
    "@babel/core": "^7.6.0",
    "@babel/runtime": "^7.6.0",
    "@react-native-community/eslint-config": "^0.0.5",
    "babel-jest": "^24.9.0",
    "eslint": "^6.4.0",
    "jest": "^24.9.0",
    "metro-react-native-babel-preset": "^0.56.0",
    "react-test-renderer": "16.8.6"
  },
  "jest": {
    "preset": "react-native"
  }
}

https://stackoverflow.com/a/46993911
I think this also happens when another lib has this package as a dependency.
I don't even see react-native-video in your package.json
Can you give us more context?


new commit

Add more of content.

Good morning
Couldn't complete step 7
Please help.
Thank you
Get Outlook for Androidhttps://aka.ms/AAb9ysg

From: github-learning-lab[bot] @.>
Sent: Sunday, January 23, 2022 11:21:53 AM
To: SnehaKumariGuptaa/github-slideshow @.>
Cc: SNEHA KUMARI SMIT STUDENT @.>; Author @.>
Subject: Re: [SnehaKumariGuptaa/github-slideshow] new commit (PR #3)
@github-learning-lab[bot] commented on this pull request.
Step 7: Respond to a review
Your pull request is looking great!
Let’s add some content to your file. Replace line 5 of your file with a quotation or meme and witty caption. Remember: Markdownhttps://guides.github.com/features/mastering-markdown/ is supported.
⌨ Activity: Change your file

Click the Files Changed tabhttps://github.com/SnehaKumariGuptaa/github-slideshow/pull/3/files in this pull request
Edit your newly added file
Replace line 5 with something new
Scroll to the bottom and click Commit Changes

Note : Can't find the button to edit the file? It may look like a pencil, or it may look like three dots.

I'll respond when I detect a commit on this branch.
—
Reply to this email directly, view it on GitHubhttps://github.com/SnehaKumariGuptaa/github-slideshow/pull/3#pullrequestreview-860279352, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AXKDETBQYZ2DWFNQPTLIIODUXOJPTANCNFSM5MS5MZUQ.
Triage notifications on the go with GitHub Mobile for iOShttps://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Androidhttps://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you authored the thread.Message ID: @.***>


Update proxy sha for release-0.8 branch

Update proxy sha to cf72117a96cd19e5a4f18d7049f25886f252cbba

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: myidpt
Assign the PR to them by writing /assign @myidpt in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@qiwzhang: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
4b1739c01a41c591cfbb6173e854f2833476dc8e
link
/test istio-pilot-e2e-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@qiwzhang: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
4b1739c01a41c591cfbb6173e854f2833476dc8e
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/istio-pilot-e2e.sh
4b1739c01a41c591cfbb6173e854f2833476dc8e
link
/test istio-pilot-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@qiwzhang: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
4b1739c01a41c591cfbb6173e854f2833476dc8e
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/istio-pilot-e2e.sh
4b1739c01a41c591cfbb6173e854f2833476dc8e
link
/test istio-pilot-e2e

prow/e2e-bookInfoTests-v1alpha3.sh
4b1739c01a41c591cfbb6173e854f2833476dc8e
link
/test e2e-bookInfo-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: rkpagadala
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: myidpt
Assign the PR to them by writing /assign @myidpt in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


Add database encryption using KeyStore

We also need performance measurement - comparing performance with and without encryption, with database size > 1 MB

I guess we have other priorities and it's not worth investing into this. I would close this PR and keep the branch. OK @Kobzol ?

I agree.


Newly updated nes-py wrappers does not have BinarySpaceToDiscreteSpaceEnv

The import statement should change from:
from nes_py.wrappers import BinarySpaceToDiscreteSpaceEnv
to
from nes_py.wrappers import JoypadSpace
and then replace in the code accordingly
Cheers

Hello，I can't find the env gym_super_mario_bros.
Is that the gym env written by yourself?
And could I have a copy?

sure.I clone it from others.You may copy it as well
发自我的iPhone
------------------ Original ------------------
From: ShawnDong<EMAIL_ADDRESS>Date: Tue,Jun 11,2019 0:04 PM
To: vietnguyen91/Super-mario-bros-A3C-pytorch<EMAIL_ADDRESS>Cc: Subscribed<EMAIL_ADDRESS>Subject: Re: [vietnguyen91/Super-mario-bros-A3C-pytorch] Newly updated nes-py wrappers does not have BinarySpaceToDiscreteSpaceEnv (#3)
Hello，I can't find the env gym_super_mario_bros.
Is that the gym env written by yourself?
And could I have a copy?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.


Removed broken dependency to flink-spargel.

I think that this should have been removed as part of #1229.

Thanks for the fix!
Good to merge

Will merge this...

@StephanEwen has this been merged as part of your other commit?


Cookies on redirects are also given from the request header

Now it is taken from the Set-Cookie of the response, but it should be taken from the Cookie of the request.

Close as it is already that way.
However, since this is not the case for consecutive requests, we would like to address this issue as necessary.


Update array type regex to account for missing whitespace

On my machine, using Futhark 0.19.7, the compiler does not emit a space after the declaration of an array type.
This in turn causes the array_types Vec in the code I changed to become empty, and crucial machinery for array types is never generated.
This happens even when using the simple example in examples/. I've attached the full output of that example using sequential_c, see line 49 for an example.
This change just makes that whitespace optional in the regex.

Thanks!

I have published a new version with this fix


feat: add dev portal

memgpt server will now start the dev portal on localhost

Please describe the purpose of this pull request.
Is it to add a new feature? Is it to fix a bug?
How to test
How can we test your PR during review? What commands should we run? What outcomes should we expect?
Have you tested this PR?
Have you tested the latest commit on the PR? If so please provide outputs from your tests.
Related issues or PRs
Please link any related GitHub issues or PRs.
Is your PR over 500 lines of code?
If so, please break up your PR into multiple smaller PRs so that we can review them quickly, or provide justification for its length.
Additional context
Add any other context or screenshots about the PR here.

Has the frontend source code moved elsewhere?

@chadgauth we're deprecating the chat UI code in favor of the new developer portal (it is no longer officially supported), however you should be able to view the code at any time by checking out the https://github.com/cpacker/MemGPT/releases/tag/0.3.8 release tag


meny.xml should be the same when generated on linux and on windows

At least 3 diffs now it seems:
The slaches:
Should be:
The datetime.toString() format:
The currently cheched in is
2023-05-25 15:42:00
Windows generate: 25.05.2023 15:42:00 and linux a third way.
The sortorder;
It seems linux puts  Database/PO before Database/EN.

@petroslikidis What is the desired document order? "PxApiConfiguration": {
"Languages"


Bug in explorer

Hello, I am trying to run my data.
While the program is running, I got the problem of two cases.
First error is below,
Exception raised! Intemediate state saved to "molpal_stock/chkpts/iter_25_2021-12-01_22-26-33/state.json"

Traceback (most recent call last):
  File "/home/njgoo/Data1/program/molpal/run.py", line 73, in <module>
    main()
  File "/home/njgoo/Data1/program/molpal/run.py", line 57, in main
    explorer.run()
  File "/home/njgoo/Data1/program/molpal/molpal/explorer.py", line 326, in run
    self.explore_batch()
  File "/home/njgoo/Data1/program/molpal/molpal/explorer.py", line 422, in explore_batch
    return sum(valid_scores)/len(valid_scores)
ZeroDivisionError: division by zero

I think that valid_scores could be empty so len(valid_scores) is zero.
Second error is below,
Finished exploring!
Exception raised! Intemediate state saved to "molpal_stock/chkpts/iter_51_2021-12-02_10-16-51/state.json"
Traceback (most recent call last):
  File "run.py", line 73, in <module>
    main()
  File "run.py", line 57, in main
    explorer.run()
  File "/home/njgoo/Data1/program/molpal/molpal/explorer.py", line 329, in run
    print(f'FINAL TOP-{self.k} AVE: {self.top_k_avg:0.3f} | '
TypeError: unsupported format string passed to NoneType.__format__

I wonder that the my job is raised to wrong process.
What do I check a intermediate data for fixing bug?
Thank you

The first error looks like all the scores from that round of optimization were invalid, causing molpal to calculate 0/0 and raising that error. That’s an edge case we can look at covering in the code, but it’s generally a cause for concern when every objective calculation failed. I’m undecided on how we should handle this in the code.
the second error looks to be a result of self.top_k_avg being None at the end of optimization. Again, this is likely due to there being too few valid scores from which to calculate a top-k average. This really should not be the case (reasonably), so I’m curious why so many of your objective evaluations are failing

@davidegraff Thanks for your advice.
For lookup process, the score in CSV file was positive value that re-calculated from docking score.
And then, I removed "--minimize" in objective option to apply maximize a optimization.
So the parameter setting could make that objective calculation failed?
I am trying to run the process that change a negative score and add "--minimize" option.
The process would be complete without error. I notice you again.
Have a good day!

Are you sure that your lookup objective is being constructed properly?

@davidegraff What do I check a lookup objective for proper construction?
As I changed docking score in csv into all of negative values, the process was finished completely.
But I got maximum positive value in all_explopred_final.csv
Is it wrong parameter for objective option?
MolPAL will be run with the following arguments:
  batch_sizes: [0.01]
  budget: 1.0
  cache: False
  checkpoint_file: None
  chkpt_freq: 0
  cluster: False
  conf_method: mve
  config: njkoo_config.ini
  cxsmiles: False
  ddp: False
  delimiter: ,
  delta: 0.1
  epsilon: 0.0
  final_lr: 0.0001
  fingerprint: pair
  fps: /home/njgoo/Data1/program/molpal/libraries/ZINC20_Stock.h5
  init_lr: 0.0001
  init_size: 0.01
  invalid_idxs: []
  k: 0.0005
  length: 2048
  libraries: ['/home/njgoo/Data1/program/molpal/libraries/ZINC20_Stock.csv.gz']
  max_iters: 50
  max_lr: 0.001
  metric: random
  minimize: True
  model: mpn
  model_seed: None
  ncpu: 20
  objective: lookup
  objective_config: njkoo_lookup.ini
  output_dir: molpal_stock
  pool: eager
  precision: 32
  previous_scores: None
  radius: 2
  retrain_from_scratch: True
  scores_csvs: None
  seed: None
  smiles_col: 0
  test_batch_size: None
  title_line: True
  verbose: 0
  window_size: 10
  write_final: True
  write_intermediate: True

i would just add in a print statement to see what sort of values you're getting out of objective.calc(...). If all of the values failed, then there's an issue with how you're constructing your MolPAL run

I also noticed that my output files are filled with the positive scores while my lookup file has negative scores (more negative = better compound). I think the sign just got swapped during processing.

It explored compounds with more negative score progressively so I think it was doing what it supposed to

The output files always use positive scores, regardless of the input lookup file

@davidegraff Would we change a positive score of output into negative score? Because of docking score of total energy, more negative values indicate better compounds.

Yes. The framing of MolPAL is a maximization problem. So the output reflects that by the most positive output being the best

I wonder what is meaning of --minimize option .
Before of your comment, I understood that run with 'minimze' option can get more negative score and run without 'minimize' option could get more positive score.

In docking, a more negative score is better, so you want to ‘—minimize’

Thanks for kind explain! As your mention, I understood the same meaning.
However, I'm confused to interpret the output result in all_explored_final.csv.
I got positive value from run with --minimize option, but negative value from run without '--minimize option'.
The result was not same as your mention "The output files always use positive scores, regardless of the input lookup file"
Also, it generated the opposite results that I expect.
Could you check the code for calculation of multiply objective values?
I just change the out value into new value by -1.

I misspoke earlier. The values in the output are not always positive, but they are always reflective of more positive values being "better" in MolPALs view. I.e., if you --minimize your objective, then the true objective values in the output should be multiplied by -1. If you maximize, then you may take the output scores as-is. The different default values are overridden by the supplied minimize value from the arguments, which is False by default.

Thank you very much!


Custom Publish/Subscribe with Flow Router SSR

Hi,
I think I might have a similar issue to #431.
My publish basically looks like:
Meteor.publish("data", function(query) {
  ExternalService.find(query, (err, result) => {
    this.added("data", result.id, result);
    this.ready();
  });
});

And then in my React class I use:
getMeteorData() {
  var dataLoaded = Meteor.subscribe("data", { name: name });
  var data = Data.findOne({ name: name });

  return {
    user: Meteor.user(),
    dataLoaded: dataLoaded.ready(),
    data: data
  };
}

However, when performing an initial render on the server, I get this error:
Publish handler for { name: 'data', params: [ { name: 'Test' } ] } sent no ready signal

I double checked, and I'm on version 3.7.3 of flow-router-ssr, but the issue is still occurring.
Thanks,
Maddi

Put a console.log in your arrow function. Does it fire before, or after error? Or not at all

It's firing after the error.

So thinking that it expecte ready to be called in an async. Ill send you a link when I get off work

So, it looks like I wasn't quite looking in the right place:
I've found the error message- https://github.com/kadirahq/fast-render/blob/master/lib/server/context.js#L105
So apparently, my external service is taking more than 500ms. I guess I'll need to configure that value?

But if it takes more the 500ms, you should not use that publication in SSR.
Do it after page loads.
On 2015 දෙසැ 18, සිකු at පෙ.ව. 7.13 Maddi Joyce<EMAIL_ADDRESS>wrote:

So, it looks like I wasn't quite looking in the right place:
I've found the error message-
https://github.com/kadirahq/fast-render/blob/master/lib/server/context.js#L105
So apparently, my external service is taking more than 500ms. I guess I'll
need to configure that value?
—
Reply to this email directly or view it on GitHub
https://github.com/kadirahq/flow-router/issues/454#issuecomment-165634351
.

Ok, that makes sense.
Thanks for your help.
Cheers,
Maddi


Tracking issue for the bulk memory operations proposal

This is a tracking issue for the bulk memory operations proposal.
TODO:

[x] Enable the bulk memory proposal's test suite

[x] binary.wast
[x] bulk.wast
[x] custom.wast
[x] data.wast
[x] elem.wast
[x] imports.wast
[x] linking.wast
[x] memory_copy.wast
[x] memory_fill.wast
[x] memory_init.wast
[x] table_init.wast
[x] table_copy.wast

[x] Enable bulk memory in the fuzzers

Done!


Remove duplicate file, add settings arrow image.

This PR fixes issues #1 and #2.
I couldn't fix the link to repo settings in the readme. You have to hardcode the github username into the link.
As a workaround, I simply created a png image that explicitly points to the settings button.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.Derek seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


Is it possible to force centering?

I have an image

Smartcrop is shifting centering when I use more square aspect ratio

Is it possible to set detection only for horizontal (top, bottom) so images doesn't shift center?

Smartcrop currently doesn't have a mode that focuses on symmetry but it could be added.


Setup release binary building

At least for Linux and OSX for now.
The LDC updates a special "Latest CI" building tag after every build on master.
See e.g.

https://github.com/ldc-developers/ldc/blob/master/.circleci/config.yml#L254
https://github.com/ldc-developers/ldc/releases/tag/CI

Can be merged anytime

Makes the fork more appealing


[Remote rendering problem] Glitch with model rendering

Describe the problem
I got a model from SketchFab which renders with some weird glitch/artifact using ARR.
See this MRC showing the issue mentioned in-action:
https://1drv.ms/v/s!AiU59qTROkNXmN0d2fic5BJY4-9jbg?e=eacPsS
This is the model I'm using
https://sketchfab.com/3d-models/half-view-of-sars-cov-2-virion-c9ac6b27205a445baa913d6b93989966
Provide additional information
This is the model I'm using. Tried FBX and glTF for the conversion.
https://sketchfab.com/3d-models/half-view-of-sars-cov-2-virion-c9ac6b27205a445baa913d6b93989966
Just using the sample and followed the process to convert which I have been successfully using many times before with other models from SketchFab.
Additional context
Add any other context about the problem here.

Hello Rene, thank you for reporting the issue and for the additional material you provided. I'll update you as soon as we know more about this.

Just tried with a model I converted a few weeks ago and that worked fine back then but now same client code shows the same glitch, so must be some issue that was introduced in the remote rendering.
This is the model which looked fine a weeks ago and now shows the same glitch with ARR:
https://www.youtube.com/watch?v=xiVMOYpjdMo

We can produce the issue as well on our side and are investigating causes and solutions.

Rene, just to clarify your second comment: Did you reimport the model which worked a few weeks ago or did you reuse the model conversion output from back then?

@jumeder I've used the model conversion output from back then, so it's not in the conversion process I guess.

Hi Rene,
the issue should be mitigated if you start a new session now. Sorry for the inconvenience!
Bye,
Marc

Confirmed it works.
Danke!


region issues during installation

During installation, if I have my region set to us-east4 or us-west1, I receive the error: "region not supported."  The only region that worked for me was "europe-west1."

Interesting.  At what step do you get that error?  I use us-central1 without problems, but I don't think I've tried us-east or us-west.  The only component that may have more limited availability is Cloud Functions, but I'm pretty sure that's in multiple regions as well.  Once I have more details I can take a closer look.

@aarontp The error occurs when line 23 of deploy_gcf.py is executed.  It looks like it's a limitation of the gcloud command?  (Maybe?)
A colleague of mine mentioned that the command worked for him in region "us-east1" but not "us-east4".  There are definitely some limitations worth documenting in terms of which region you select.

Ok, yeah, that is for the cloud functions then.  Here are the locations for where that is supported: https://cloud.google.com/functions/docs/locations.  For now Turbinia will have to exist in one of those regions when using GCP, but if that's an issue we can look at running cloud functions from a separate region.
I'll update the docs to reflect this.

Fixed in https://github.com/google/turbinia/commit/2020cf9c11bc9f548efbdbc6f5c9af1b70d81395#diff-64407d3e6d5ef382426bdfbcae040c6a


DEPLOY_ZIP_ERROR with status code 403 after one hour delay deploying Core Bot with Language starter template to Linux App Service

Describe the bug
Bot Framework Composer v2.1.2 has consistently encountered failures from Azure trying to publish new bots targeting Linux plans. This can be replicated in Bot Framework Composer v2.1.2 by creating a new bot using C# and the "Core Bot with Language" template, then going to create a new publish preset, publishing as a web app on Linux in US West with LUIS on US West.
After choosing to create new resources and a new resource group using only the minimally required components, the profile is created and the resources are created on Azure. However, actually publishing causes 45-90 minutes of wait time after the zip uploads, followed by a JSON-based failure message indicating 403 status code (presumably unauthenticated).
Publishing bots to Windows app service plans work following the exact same workflow, but costs significantly more.
Version
Version:  2.1.2
Electron: 8.2.4
Chrome: 80.0.3987.165
NodeJS: 12.13.0
V8: 8.0.426.27-electron.0
Browser

[x] Electron distribution
[ ] Chrome
[ ] Safari
[ ] Firefox
[ ] Edge

OS

[ ] macOS
[x] Windows
[ ] Ubuntu

To Reproduce
Steps to reproduce the behavior:

Create a new bot using C# and the "Core Bot with Language" template in Bot Framework Composer specifying Azure Web App as the runtime type
Click on Publish on the sidebar
Click on Publishing profile on the tab strip
Click on add new
Name it "ThisWillFail" or whatever
Select publishing target of Publish Bot to Azure
Specify Create new resources and click Next
Login as needed
Select your subscription
Choose to create a new resource group and name it something distinct, e.g. this-will-fail
Specify Linux as the operating system
Specify ThisWillFail or similar as the resource name
Specify West US as the region. This will also set LUIS region to West US
Click Next
Uncheck all optional resources
Click Next
Click Create
Wait for the resources to be provisioned and the profile to appear
Note: you can also set up Language Understanding for the bot in the sidebar at this point, it doesn't matter if you do or don't
Click on the Publish tab
Check your bot and specify the publish target
Click Publish Selected Bots
Click OK
Observe long wait time after upload of Zip file in the "waiting for zip upload processing" step. This takes ~45 minutes or so.
Observe DEPLOY_ZIP_ERROR failure message with 403 status code.

Note that these steps do not reproduce the error when targeting Windows.
Expected behavior
Working app deployed to Azure on a Linux app service and ready to be interacted with.
Screenshots
Uploading Process:

Failure Message (after significant delay):

Additional context
I am an individual running chatbots for fun and to teach others about Azure. I want the cheapest available "always on" resource to embed in my low traffic personal website and blog and Windows would run me $50 / month ($600 yearly) whereas Linux would be roughly $150 yearly,

This is a known issue. Please see more information here: https://github.com/microsoft/BotFramework-Composer/issues/8890

Closing due to duplication


Clean up source repository lists.

Dependencies ds_sim, ds_msgs, uuv_simulator, uuv_manipulators, especially our custom forks for uuv_* (currently in noetic_updates branches but presumably will be in master at the time of release?), should be documented, e.g. in a new “Dependencies” section on the installation page https://github.com/Field-Robotics-Lab/dave/wiki/Installation . I was not aware of this, and I just had the upstream repos, which gave various compiler errors. #127

Addressed by PR#137


ocropus-gpageseg: Defective line splitting

Expected Behavior
Simple running text should be consistently split into lines.
Current Behavior
Currently working on data from the Grenzboten project together with @uvius. For some images, line splitting does not work. It is not clear why because very similar images are split correctly.
Steps to Reproduce (for bugs)

Download test files:

Run ocropus-gpageseg on testfile(s).
Inspect results.

Test files have been created with ocropus-nlbin. Tested various command line parameter settings without success.
Your Environment

Python version: Python 2.7.3
Git revision of ocropy:  commit 49c7f9ec943bda2c249b9027776d0e3de477b5ec
Operating System and version: Linux lal 3.2.0-4-amd64 #1 SMP Debian 3.2.73-2+deb7u2 x86_64 GNU/Linux

Okay, I looked at the debug output with  --debug and it seems that the detected scale is too small (approximately half of the correct size):

The disconnected (red) components are then creating the different lines.
If you increase that value by hand by setting the --scale parameter:
ocropus-gpageseg grenzboten.bin.png -n --debug --scale 30

then the output looks good:

(Don't forget to remove all old images from the directory containing the lines.)

Alright, thanks. That fixes the issue for the specific image (and many others). But if I set this parameter globally for the whole (pre-segmented) book, new problems arise with smaller (e.g. on-line images). Is there a known bug in the scale detection?

new problems arise with smaller (e.g. on-line images)

I don't know what exactly you mean with "on-line images", but in general when you have to deal with font sizes which vary much (header vs. body text vs. footnote text), then ocropus has some problems and you might need some other steps.

Is there a known bug in the scale detection?

Nothing I am aware of, but the example you provide looks like not an optimal guess from ocropus for the scale parameter. My guess is that for your test image the binarization will produce characters that are splitted into several connected components, and this influences the estimation of the scale parameter. I tried another binarization method here, and then the result seems also okay.

Sorry @zuphilip. This is a typo and should be "one-line images" (i.e., images which cover only a single line). So it's not the varying font size but rather varying clipping sizes from the whole page image which cause the issues.

I tried another binarization method here, and then the result seems also okay.

This is a great idea. I used ocropus-nlbin which seems the most obvious choice. From my experience, the tesseract line splitting is far superior to ocropous-gpagseg but this probably boils down to binarization.
Many thanks for your ongoing support!

https://github.com/tmbdev/ocropy/blob/master/OLD/ocropus-sauvola

The scale estimation in ocropus for your example will produce this scalemap

As far as I understand the following happen then: For each of these boxes the algorithm continues to calculate the area and then take the square root (i.e. geometric mean of width and height). Overall the median of these numbers (without outliners) is then taken.
( The corresponding Jupyter notebook is here: https://gist.github.com/zuphilip/e551ba6b733b5094749799651e4fbd3e )
Sauvola is one possibility and I the ocropus-nlbin has more parameters to try out. Moreover, it should be possible to mix some of the steps of Tesseract with some of the steps with Ocropus.
@wrznr Thank you for asking interesting questions!

Indeed, using e.g. scantailor for binarization results in an almost error-free line splitting!  Only small one-line segments like page numbers and signature marks (which is probably to be expected) are not correctly processed. Significant step forward!
While this is great for me, is it a problem for ocropus (I.e. problems in the combination of nlbin and gpageseg)?


feat: Added test for Config and fixed errors in it

Added the test for Config which gave this final output:
.
Ran 1 tests in 0.001 seconds, 1 success, 0 failures
OK

@techoner plz review.

@rushitote why close?

@hsluoyz This was implemented with luaunit, I will do again with busted instead.

@rushitote good!


Scheduler

Nice to have a scheduler for timeing server commands.
I'am working on this option. Also Scales will be modified to suport the scheduler

Duplicate of #474. Please keep in mind we are currently in a feature freeze for the PHP version of PufferPanel so we won't be able to include it in a release unless it is done on the kraken branch. Thanks!