Rename "joypad_linux" class to "JoypadLinux"

Since all this refactoring is going on, I took the opportunity to rename this class in GodotCase so it fits with the rest of the codebase.

nice :D
On Sun, Jan 8, 2017 at 6:31 PM, Andreas Haas<EMAIL_ADDRESS>wrote:

Since all this refactoring is going on, I took the opportunity to rename
this class in GodotCase so it fits with the rest of the codebase.
You can view, comment on, or merge this pull request online at:
https://github.com/godotengine/godot/pull/7473
Commit Summary

Rename "joypad_linux" class to "JoypadLinux"

File Changes

M platform/x11/joypad_linux.cpp
https://github.com/godotengine/godot/pull/7473/files#diff-0 (41)
M platform/x11/joypad_linux.h
https://github.com/godotengine/godot/pull/7473/files#diff-1 (6)
M platform/x11/os_x11.cpp
https://github.com/godotengine/godot/pull/7473/files#diff-2 (2)
M platform/x11/os_x11.h
https://github.com/godotengine/godot/pull/7473/files#diff-3 (2)

Patch Links:

https://github.com/godotengine/godot/pull/7473.patch
https://github.com/godotengine/godot/pull/7473.diff

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/godotengine/godot/pull/7473, or mute the thread
https://github.com/notifications/unsubscribe-auth/AF-Z20snobTTUwH_jkeMK5LBk_jmzWOlks5rQVXCgaJpZM4Ldzp6
.


Add MiddlewareMixin to all middleware classes

Django >=1.10 uses a slightly different middleware framework. Using the old framework results in RemovedInDjango20 warnings. Django provides MiddlewareMixin for classes that work as both old-style and new-style middlewares. Inheriting from it allows clients of this library to move to the new middleware framwork and silence the deprecation warnings.

Thanks @mikix. Looking at those docs, it seems like the only difference is exception handling, which shouldn't affect these classes.


Use environment identifier in windows locator

Codecov Report

Merging #15771 (6833bd5) into main (be9fd0c) will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##           main   #15771   +/-   ##
=====================================
  Coverage    46%      46%
=====================================
  Files        12       12
  Lines       429      429
  Branches     60       60
=====================================
  Hits        201      201
  Misses      216      216
  Partials     12       12


It is not possible to rebind / turn off Alt+Space for title bar customization

Does this issue occur when all extensions are disabled?: Yes

VS Code Version: 1.70.2
OS Version: Windows 10

Steps to Reproduce:

I use Alt+Space for window maximizing, which now clashes with title bar customization introduced in July 2022 release. I like the original behaviour of Alt+Space way more, but there seems to be no way to turn off the title bar customization, nor to unbind/change key binding for it. Please allow the original Alt+Space behaviour.

Alt+Space's original behavior still works if the mouse is not over the title bar. Or if you right click the top left corner of the title bar.


Fix WindowState.Saver to not crash on unspecified window size.

Fix WindowState.Saver to correctly save/restore unspecified window size.
Fixes https://github.com/JetBrains/compose-multiplatform/issues/4945
Testing
Manually with
fun main() = singleWindowApplication {
    LazyColumn {
        items(1000) { index ->
            val state = rememberWindowState(size = DpSize.Unspecified)
            Text("$index " + state.size.toString())
        }
    }
}

and also added unit tests for saving/restoring `WindowState` and `DialogState`.

Fixes - Desktop

Correctly save WindowState with unspecified size instead of crashing.

Hi, issue submitter here. Amazing turnaround!
It looks like you'll need to apply the same fix in at least rememberDialogState too, which uses the same logic and has the same crash.

It looks like you'll need to apply the same fix in at least rememberDialogState too, which uses the same logic and has the same crash.

There doesn't seem to be documentation that DialogState.size can be unspecified, but since it works de-facto, I fixed its saver too.

There doesn't seem to be documentation that DialogState.size can be unspecified

We have it in WindowState.size KDoc and in tutorials("By setting one or both dimensions").

But DialogState indeed doesn't contain it compare to WindowState 🤔. It was an oversight


CSV edge case, missing key value on a row

If you have a csv that looks like this:
_key, attr1
1, a
,b
3,c

The second row is skipped and there is no prompt to the user. There are a couple options for how we can handle this. We could just fail and tell the user why, or we could attempt to fill in the key values after asking the user if that's desired. Let me know what you think to these proposals, @waxlamp @AlmightyYakob.

The second row is skipped and there is no prompt to the user.

Can you be more precise about what happens? I'm not sure there's any validation mechanism that can "skip" a row.

The resulting data, at least in the client, shows:
_key, attr1
1, a
3,c

Interesting. Definitely a bug. Thanks for the report!
I think this must just a forgotten edge case in our validation routine for keys, where an empty string passes validation because we didn't consider the possibility. To fix this we should fail empty strings--no need to attempt to fix it.
This reminds me of Hypothesis, which is a really neat tool for automated generation of test cases for situations like this. Not saying we should use it, but if we add more unit tests for low level facilities such as the validation routines here, it could be of some use.

We should test this with the new API


ergoCubSN001-002: Update amcbdlc and amc versions

In relation to the latest PRs in icub-firmware (https://github.com/robotology/icub-firmware/pull/523) and icub-firmware-build (https://github.com/robotology/icub-firmware-build/pull/165), this PR updates the boards as per title:
AMC2C : 3.1
AMCBLDC: 2.1

Hi @mfussi66
I've seen that the PR is still draft, so I imagine you'll be doing some tests.
Hence, what's your strategy to test these changes on the robot?
Ideally, given the small updates, you would be testing the changes on top of the robot-specific fork branches:

https://github.com/icub-tech-iit/robots-configuration/tree/devel-ergoCubSN001
https://github.com/icub-tech-iit/robots-configuration/tree/devel-ergoCubSN002

This guarantees that everything remains consistent on the robot setups.
Those changes will be then propagated back to upstream (aka here) with periodical PRs. Or, we can do that manually straight away.
I'm bringing up this point to get everyone aligned, especially considering that these are the first times we've tested this approach.
cc @S-Dafarra @traversaro

Hence, what's your strategy to test these changes on the robot?

The tests were performed only on ergoCubSN000 (https://github.com/robotology/icub-firmware-models/issues/92) and ergoCubSN001 (https://github.com/robotology/icub-firmware-models/issues/95)
On SN000 since the AMC does not perform motor control, I only tested the AMCBLDCs. on SN001 I tested both the boards.
SN002 is unavailable at the time of this PR, so i was not able to perform tests, but the boards' features should be the same as SN001, hence why this PR targets that one, too.
However, it does not target SN000 since on that robot no check is performed on the AMCBLDC firmware's version, and I did not want to disrupt its operation mode by enforcing a version.
The configuration files I used are stored in my fork and the yarprobotinterface boots up only the wrist boards.
Let me know if this workflow can be considered equivalent to the contributing guidelines, and if this PR can be merged.
I'll mark this as ready for review since the tests were performed, and put it back to draft if deemed insufficient.

The most important point is:

How did you leave the robot?
I imagine you flashed back to the previous version of the FW once you finished testing. Is that correct?

If so, I think we can merge the PR and once AMI decides to align the fork with upstream the boards will need to be updated. This operation is usually performed outright at each Distro release unless there are particular requests.

The configuration files I used are stored in my fork and the yarprobotinterface boots up only the wrist boards.

The tests on the robot should be carried out on the complete setup to avoid underestimating any possible side effects, meaning launching the whole robot with the complete set of conf files.

Regarding this

However, it does not target SN000 since on that robot no check is performed on the AMCBLDC firmware's version, and I did not want to disrupt its operation mode by enforcing a version.

I have a memory of the past when we decided to disable the FW versions, cc @GiulioRomualdi.
Apparently, this is done for SN000 but not for SN001/2.

How did you leave the robot?
I imagine you flashed back to the previous version of the FW once you finished testing. Is that correct?

Yes, the firmware was restored to the version present in icub-firmware-build contained in the robotology-superbuild folder.
So a rebase to devel would require a firmware flash.

The tests on the robot should be carried out on the complete setup to avoid underestimating any possible side effects, meaning launching the whole robot with the complete set of conf files.

Agreed, at the time of testing the robots were not fully functional however, and I would have had to wait for repairs.

Yes, the firmware was restored to the version present in icub-firmware-build contained in the robotology-superbuild folder.

Good 👍🏻
So, let's wait a bit for others to chime in before merging.

Agreed, at the time of testing the robots were not fully functional however, and I would have had to wait for repairs.

Clear 👍🏻

Sure!
Awaiting that https://github.com/robotology/icub-firmware-build/pull/165 is merged before proceeding here.

Thanks for noticing @marcoaccame and @pattacini , the last commits update the missing file.

Thanks @mfussi66 👍🏻

Would it be possible to wait for a release of icub-firmware-build before merging? In this way, when rebasing on top of devel, we also know that we have to update to a new release.

@S-Dafarra, the corresponding PR on icub-firmware-build has been merged, so we're good to go here as well.
We generally don't produce release of the build until the new Distro. I think you're ok with rebasing on top of devel.

We generally don't produce releases of the build until the new Distro. I think you're ok with rebasing on top of devel

Is it a hard dependency? I would like to remain consistent with all the FW of all the boards for a given version of icub-firmware-build. In other words, if we have to update some boards, I would rather update all the boards, otherwise it gets messy. The update usually goes smooth for a release, while for commits it might generate a domino effect with the yarp and icub-main versions. If this cannot be satisfied, I am good in merging this, but I would postpone the rebasing of the robots configuration branches until the next release. Does this sound reasonable?

I think that, in this case, it's safe to update only the boards controlling the wrist of the ergoCub robot. I'm referring here to 2 AMC and 4 AMCBLDC boards handling the left and right wrist.
Tagging icub-firmware-build means that tags should propagate upward, up to a given extent.

I am good in merging this, but I would postpone the rebasing of the robots configuration branches until the next release. Does this sound reasonable?

I would like to merge this PR to remain consistent with the devel of our whole codebase.
When you aim to update the fork branches is not really critical for us, as we're happy with our tests, I'd say.
While waiting for the next Distro, if important devs/patches applied to devel will need to land on the physical robots, we will help with the tests/update.
Calling for feedback on this proposal, @S-Dafarra @mfussi66 @marcoaccame @Nicogene

I think that, in this case, it's safe to update only the boards controlling the wrist of the ergoCub robot. I'm referring here to 2 AMC and 4 AMCBLDC boards handling the left and right wrist.

I would discourage this approach. We have done it a few times in the past and it was never a good situation, ending up in unexpected results. One common assumption is that the robot is aligned to the fw version of icub-firmware-build status in the head/torso. If this is not the case, we might end up in unreproducible situations.


Something Something Persistent Collections Something Something?

cc @reem @matthieum @jurily

So I tried to rework ImmutSList to "look" like a normal stack per @gereeter's musings. push works fine, but pop is a problem. You can only get the value out if you're the unique owner of the current Node. Otherwise all you can do is proceed forward. I considered returning None in that case, but that seems a bit... weird.


set starting point of trajectory & reload new map for pure localization

Hi, I want to achieve two goals by modifying the pure localization mode:

set the starting point in the map coordinate system of the new trajectory.
Reload new .pbstream map, overwrite old map.
1.　part of my code is as follows:

    else if(PEEK_CMD_FF(cmd, "initpose", 8, f1, f2))
    {
        Eigen::Matrix<double, 3, 1> position(f1, f2, 0);
        Eigen::Quaternion<double> rotation(1, 0, 0, 0);
        ::cartographer::mapping::proto::InitialTrajectoryPose pose;
        pose.set_to_trajectory_id(0);
        *pose.mutable_relative_pose() =
            cartographer::transform::ToProto(cartographer::transform::Rigid3d(position, rotation));
        pose.set_timestamp(cartographer::common::ToUniversal(FromRos(ros::Time::now())));
        *last_trajectory_options_.trajectory_builder_options.mutable_initial_trajectory_pose() = pose;
        StartTrajectoryWithDefaultTopics(last_trajectory_options_);
        ROS_INFO("start initpose trajectory");
    }

But I found that the initial coordinates of the settings seem to be based on the odom coordinate system. How to set the coordinates based on map frame?

for second purpose, my code as follows:

 else if(PEEK_CMD_S(cmd, "loadmap", 7, str1))
    {
        LoadState(str1, true);
        ROS_INFO("load: %s", str1);
    }

But calling this function twice will load two maps at the same time, how to clear the previous map and import a new map for pure localization?

There are two options to reload a new map, (a) delete the Node object in node_main.cc and create a new Node with new map. (b) or use python subprocess to relaunch cartographer_node program, the code looks like this

#!/usr/bin/env python

import rospy
import subprocess
import signal

child = subprocess.Popen(["roslaunch","cartographer_ros",
"demo_backpack_2d_localization_start_trajectory.launch",
"load_state_filename:=/home/zh/Downloads/b2-2016-04-05-14-44-52.bag.pbstream",
"bag_filename:=/home/zh/Downloads/b2-2016-04-27-12-31-41.bag"])
# child.wait() #You can use this line to block the parent process untill the child process finished.

print("parent process")
print(child.poll())

rospy.loginfo('The PID of child: %d', child.pid)
print ("The PID of child:", child.pid)

rospy.sleep(5)

# child.send_signal(signal.SIGINT) #You may also use .terminate() method
# child.terminate()

child2 = subprocess.Popen(["roslaunch","cartographer_ros",
"start_trajectory.launch",])
child.wait()

#for more: https://docs.python.org/2/library/subprocess.html

To start a new trajectory with initial pose

rosrun cartographer_ros cartographer_start_trajectory \
-configuration_directory="/home/zh/catkin_cartographer/install_isolated/share/cartographer_ros/configuration_files" \
-configuration_basename="backpack_2d_localization.lua"  \
--initial_pose="{ to_trajectory_id=0, relative_pose={translation={10, 10, 0},rotation={0.0,0.0,0.0} }}"

I've modified start_trajectory_main.cc codes to change starting point at the initial time.

and It worked almost normally (heading of clicked point is not correct, position of clicked point is not correct as well).
but pure localization has failed for my case.
I upload this modified codes and hope it helps for you :-)
start_trajectory_main.cc
https://gist.github.com/tigerk0430/7f67a9ca10824ea56875ad4b7a449b49
init_pose_test.launch
https://gist.github.com/tigerk0430/6ecd59f2f7905f10edc2ec7b93e27264

@tigerk0430
Hi,
I am running 2d slam,i want to set the new trajectory in the new plane(Z-axis ≠ 0),and save the map.how can i do this?
I call rosservice call /finish_trajectory,and set the new trajectory to z-axis=5,i runned:
rosrun cartographer_ros cartographer_start_trajectory -configuration_basename=backpack_2d.lua -configuration_directory=/home/calyu/catkin_ws/install_isolated/share/cartographer_ros/configuration_files -initial_pose="{to_trajectory_id=0,relative_pose={translation={0.0,0.0,5},rotation={0.,0.,0.0}}}
i can see the map look like this:

i want to save this map ,so than i runned rosservice call /finish_trajectory 1,but the Z axis will change to the initial position.(Z-axis = 0m).

How can i to set the new trajectory in the new plane (Z-axis ≠ 0) and save this map? Can you help me.
thank you.

Hello @carl1218,
It might be the problem of cartographer_start_trajectory
rosrun cartographer_ros cartographer_start_trajectory {...} -initial_pose="{to_trajectory_id=0,relative_pose={translation={0.0,0.0,5},rotation={0.,0.,0.0}}}
It generates new trajectory when you run this code. but relative pose is generated from end of the to_trajectory_id's node's pose.
It isn't generated from the start of the to_trajectory_id's node's pose. that's kind of confusing.
for example, when to_trajectory_id = 0,  you should get the end of Trajectory 0's pose to use relative pose.
if you still have same problem. let me know with more detail
Thank you!

@tigerk0430
Hi,
Thank you very much for your reply.
I want to have multiple floors with 2D SLAM, and use separate 2D maps per floor.
I want just process and store the data separately and use separate Cartographer nodes for each floor.
I want to have multiple 2D maps aligned with a z-offset in 3D space, i need an additional coordinate frame to model the floors.maybe i need define an additional parent TF frame (let's call it "world"), in which the floor maps are located. The static transformation from "world" to each map can be adjusted to model the floor height.
Because I don't know much about the cartographer, in order to achieve the effect I need, can you help me modify it, of course, it's not free.
Expected for your  reply.

hello @carl1218
I understand what you're currently working on, but I'm now too busy to cooperate with you ;-/
I think the best way to achieve your goal, email to cartographer developers whenever you've got some problem.
here is a public space and they don't have enough time to give an answer to every person.
have a good day :-)

@cgdsss
Hi, Do you have a good solution to the problem reload maps? I don't want to use the way of rosslaunch.
I also want to load maps dynamically. Thanks.

The /start_trajectory ROS service was simplified recently and should be easier to use now. See #1245

I've modified start_trajectory_main.cc codes to change starting point at the initial time.

and It worked almost normally (heading of clicked point is not correct, position of clicked point is not correct as well).
but pure localization has failed for my case.
I upload this modified codes and hope it helps for you :-)
localization_test.launch
https://gist.github.com/tigerk0430/aee06ddb04c2632c92917d5343e3ba36
start_trajectory_main.cc
https://gist.github.com/tigerk0430/7f67a9ca10824ea56875ad4b7a449b49
init_pose_test.launch
https://gist.github.com/tigerk0430/6ecd59f2f7905f10edc2ec7b93e27264
Instruction

roslaunch   cartographer_ros   localization_test.launch   load_state_filename:=.../.pbstream
rosbag   play   --clock   ....bag
roslaunch   init_pose_test.launch
Rviz, click 2D Nav Goal and click a position you want to

i want to download your code, but this link is fired....plz reply this contents...


[Roots 3] Living Pickaxe is obsidian-level

Considering it's just wood + bark + gold I don't really see how it isn't gold level or jsut plain iron level. Had I realised I wouldn't have bothered hunting around for diamonds before going for obsidian.

Fixed


Vanishing atmosphere when looking up #3347

Fixed #3347
It seems like this problem was caused by commit 4cccade8135aea8070c1daba84fcec43fb892ec1. I think this was to prevent the atmosphere from rendering before tiles were ready, but the way it was handled caused the atmosphere to vanish if no tiles were being rendered (fully skyward view).
Also updated CHANGES.md.

Now we can view the solar eclipse on September 1st of this year! As seen from Madagascar:

Nice fix!

Wow great fix, thanks @likangning93!
Can you please post to this thread (linked from #3347) and let them know that this is fixed and will be in Cesium 1.22 next Wednesday?
Also, if you are interested in solar eclipse, see http://cesiumjs.org/2015/03/19/EclipseTracks-Interactive-Solar-Eclipses-with-Cesium/

Now you just need to make the sky goes dark and the moon casts a shadow on the Earth :)


Trigger onChooseEvent on tab (like enter and click)

Like https://github.com/pawelczak/EasyAutocomplete/issues/101
Steps to reproduce:

enter search
use arrows to select an item from the list (they become grey, like they are active)
hit tab key
the value of the text fields changes

I would expect that the onChooseEvent is triggered, but it is not.

It's exactly what I'm experiencing. This behavior confuses the user so it's really annoying. Can you accept a PR on this?

See #235 and #365.


feat: add multi-hosts

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

7 of 82 (8.54%)  changed or added relevant lines in 4 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-4.1%) to 37.584%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

proxy.go
4
5
80.0%

multi-hosts.go
0
74
0.0%

Totals

Change from base Build<PHONE_NUMBER>:
-4.1%

Covered Lines:
280

Relevant Lines:
745

💛  - Coveralls


Code action command with kind CodeActionKind.QuickFix and no edits has tooltip with preview option

VS Code Version: 1.74.0 (user setup)
Commit: 5235c6bb189b60b01b1f49062f4ffa42384f8c91
Date: 2022-12-05T16:38:16.075Z
Electron: 19.1.8
Chromium: 102.0.5005.167
Node.js: 16.14.2
V8: <IP_ADDRESS>-electron.0
OS: Windows_NT x64 10.0.22621
Sandboxed: No
Steps to Reproduce:

Create a code action command with CodeActionKind set to QuickFix and no edits.
Display the command via light blub and hover over the command to display tooltip. The tooltip text has the preview option "Ctrl+Enter to preview".
Executing the command with either "Enter to apply" or "Ctrl+Enter to preview" results in the same behavior.

Example shown is from C++ extension
Expected behavior:
Only code action commands with edits should offer the preview option.

Thanks for creating this issue! It looks like you may be using an old version of VS Code, the latest stable release is 1.75.1. Please try upgrading to the latest version and checking whether this issue remains.
Happy Coding!

The issue is also in VS Code version 1.17.1

Hi @mjbvz, is anyone working on this issue? if not can I work on it?


⚠ API - Lens has degraded performance

In 8dcf80f, API - Lens ($LENS_API_URL) experienced degraded performance:

HTTP code: 503
Response time: 340 ms

Resolved: API - Lens performance has improved in b4f0be3 after 9 minutes.


support RTL direction

Is there any way to handle RTL direction for no-en language's ?
if not how to implement this for react-table ?

Just use the RTL related CSS properties available to the browser.
This is a question of implementation. We invite you to join the slack channel and ask for help there or on stack overflow. Thanks!


Material icons alternative styles are missing

List of affected icons (that I discovered):

color_lens
palette
format_color_reset
format_color_text
format_color_fill

Flutter has filled and outlined styles for these icons, but missing all the other and shows them the same as filled

rounded
sharp
two-tone (this one is missing for all icons library by the way)

How it looks like

Even though in https://material.io/resources/icons/?search=paint&icon=color_lens&style=baseline
they look different

Filled

Missing ones

Reproducible:
import 'package:flutter/material.dart';

final Color darkBlue = Color.fromARGB(255, 18, 32, 47);

void main() {
  runApp(MyApp());
}

class MyApp extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      theme: ThemeData.dark().copyWith(scaffoldBackgroundColor: darkBlue),
      debugShowCheckedModeBanner: false,
      home: Scaffold(
        body: Row(
          mainAxisAlignment: MainAxisAlignment.center,
          children: [
            Icon(Icons.palette),
            Icon(Icons.palette_outlined),
            Icon(Icons.palette_rounded),
            Icon(Icons.palette_sharp),
          ]
        ),
      ),
    );
  }
}

flutter doctor -v

[✓] Flutter (Channel master, 1.24.0-8.0.pre.374, on Microsoft Windows [Version 10.0.19041.685], locale ru-RU)
    • Flutter version 1.24.0-8.0.pre.374 at c:\dev\src\flutter
    • Framework revision 183f0e797a (5 weeks ago), 2020-11-26 19:12:28 +0100
    • Engine revision 20caf54969
    • Dart version 2.12.0 (build 2.12.0-76.0.dev)
[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.2)
• Android SDK at C:\Users\danya\AppData\Local\Android\sdk
• Platform android-30, build-tools 30.0.2
• Java binary at: C:\Program Files\Android\Android Studio\jre\bin\java
• Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b01)
• All Android licenses accepted.
[✓] Android Studio (version 4.0)
• Android Studio at C:\Program Files\Android\Android Studio
• Flutter plugin version 50.0.1
• Dart plugin version 193.7547
• Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b01)
[✓] VS Code (version 1.52.1)
• VS Code at C:\Users\danya\AppData\Local\Programs\Microsoft VS Code
• Flutter extension version 3.18.0
[✓] Connected device (1 available)
• Redmi Note 5 (mobile) • 40c9f14 • android-arm64 • Android 9 (API 28)
• No issues found!

i also discovered that if i download these icons from the https://material.io/resources/icons/ as svg, they will look the same too

i also discovered that if i download these icons from the https://material.io/resources/icons/ as svg, they will look the same too

flutter doctor -v
[✓] Flutter (Channel stable, 1.22.5, on macOS 11.1 20C69 darwin-x64, locale en-GB)
    • Flutter version 1.22.5 at /Users/tahatesser/Code/flutter_stable
    • Framework revision<PHONE_NUMBER> (4 weeks ago), 2020-12-10 11:54:40 -0800
    • Engine revision ae90085a84
    • Dart version 2.10.4

[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.3)
    • Android SDK at /Volumes/Extreme/sdk
    • Platform android-30, build-tools 30.0.3
    • ANDROID_HOME = /Volumes/Extreme/sdk
    • Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6915495)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 12.3)
    • Xcode at /Volumes/Extreme/Xcode.app/Contents/Developer
    • Xcode 12.3, Build version 12C33
    • CocoaPods version 1.10.0

[!] Android Studio (version 4.1)
    • Android Studio at /Applications/Android Studio.app/Contents
    ✗ Flutter plugin not installed; this adds Flutter specific functionality.
    ✗ Dart plugin not installed; this adds Dart specific functionality.
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6915495)

[✓] VS Code (version 1.52.1)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.18.0

[✓] Connected device (2 available)
    • RMX2001 (mobile)     • EUYTFEUSQSRGDA6D          • android-arm64 • Android 10 (API 29)
    • Taha’s iPad (mobile) • 00008020-000255113EE8402E • ios           • iOS 14.3
    ! Error: Taha’s iPad is busy: Copying cache files from device. Xcode will continue when Taha’s iPad is finished. (code -10)

! Doctor found issues in 1 category.

[✓] Flutter (Channel beta, 1.25.0-8.1.pre, on macOS 11.1 20C69 darwin-x64, locale en-GB)
    • Flutter version 1.25.0-8.1.pre at /Users/tahatesser/Code/flutter_beta
    • Framework revision 8f89f6505b (3 weeks ago), 2020-12-15 15:07:52 -0800
    • Engine revision 92ae191c17
    • Dart version 2.12.0 (build 2.12.0-133.2.beta)

[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.3)
    • Android SDK at /Volumes/Extreme/sdk
    • Platform android-30, build-tools 30.0.3
    • ANDROID_HOME = /Volumes/Extreme/sdk
    • Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6915495)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 12.3)
    • Xcode at /Volumes/Extreme/Xcode.app/Contents/Developer
    • Xcode 12.3, Build version 12C33
    • CocoaPods version 1.10.0

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 4.1)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6915495)

[✓] VS Code (version 1.52.1)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.18.0

[✓] Connected device (3 available)
    • RMX2001 (mobile)     • EUYTFEUSQSRGDA6D          • android-arm64  • Android 10 (API 29)
    • Taha’s iPad (mobile) • 00008020-000255113EE8402E • ios            • iOS 14.3
    • Chrome (web)         • chrome                    • web-javascript • Google Chrome 87.0.4280.88
    ! Error: Taha’s iPad is busy: Copying cache files from device. Xcode will continue when Taha’s iPad is finished. (code -10)

• No issues found!

[✓] Flutter (Channel dev, 1.26.0-1.0.pre, on macOS 11.1 20C69 darwin-x64, locale en-GB)
    • Flutter version 1.26.0-1.0.pre at /Users/tahatesser/Code/flutter_dev
    • Framework revision 63062a6443 (3 weeks ago), 2020-12-13 23:19:13 +0800
    • Engine revision 4797b06652
    • Dart version 2.12.0 (build 2.12.0-141.0.dev)

[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.3)
    • Android SDK at /Volumes/Extreme/sdk
    • Platform android-30, build-tools 30.0.3
    • ANDROID_HOME = /Volumes/Extreme/sdk
    • Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6915495)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 12.3)
    • Xcode at /Volumes/Extreme/Xcode.app/Contents/Developer
    • Xcode 12.3, Build version 12C33
    • CocoaPods version 1.10.0

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 4.1)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6915495)

[✓] VS Code (version 1.52.1)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.18.0

[✓] Connected device (4 available)
    • RMX2001 (mobile)     • EUYTFEUSQSRGDA6D          • android-arm64  • Android 10 (API 29)
    • Taha’s iPad (mobile) • 00008020-000255113EE8402E • ios            • iOS 14.3
    • macOS (desktop)      • macos                     • darwin-x64     • macOS 11.1 20C69 darwin-x64
    • Chrome (web)         • chrome                    • web-javascript • Google Chrome 87.0.4280.88
    ! Error: Taha’s iPad is busy: Copying cache files from device. Xcode will continue when Taha’s iPad is finished. (code -10)

• No issues found!

[✓] Flutter (Channel master, 1.26.0-2.0.pre.168, on macOS 11.1 20C69 darwin-x64, locale en-GB)
    • Flutter version 1.26.0-2.0.pre.168 at /Users/tahatesser/Code/flutter_master
    • Framework revision 299e017e41 (23 hours ago), 2021-01-03 06:29:01 -0500
    • Engine revision 121b67fb85
    • Dart version 2.12.0 (build 2.12.0-179.0.dev)

[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.3)
    • Android SDK at /Volumes/Extreme/sdk
    • Platform android-30, build-tools 30.0.3
    • ANDROID_HOME = /Volumes/Extreme/sdk
    • Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6915495)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 12.3)
    • Xcode at /Volumes/Extreme/Xcode.app/Contents/Developer
    • Xcode 12.3, Build version 12C33
    • CocoaPods version 1.10.0

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 4.1)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6915495)

[✓] VS Code (version 1.52.1)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.18.0

[✓] Connected device (4 available)
    • RMX2001 (mobile)     • EUYTFEUSQSRGDA6D          • android-arm64  • Android 10 (API 29)
    • Taha’s iPad (mobile) • 00008020-000255113EE8402E • ios            • iOS 14.3
    • macOS (desktop)      • macos                     • darwin-x64     • macOS 11.1 20C69 darwin-x64
    • Chrome (web)         • chrome                    • web-javascript • Google Chrome 87.0.4280.88
    ! Error: Taha’s iPad is busy: Copying cache files from device. Xcode will continue when Taha’s iPad is finished. (code -10)

• No issues found!

flutter doctor -v
[✓] Flutter (Channel stable, 1.22.5, on macOS 11.1 20C69 darwin-x64, locale en-GB)
    • Flutter version 1.22.5 at /Users/tahatesser/Code/flutter_stable
    • Framework revision<PHONE_NUMBER> (4 weeks ago), 2020-12-10 11:54:40 -0800
    • Engine revision ae90085a84
    • Dart version 2.10.4

[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.3)
    • Android SDK at /Volumes/Extreme/sdk
    • Platform android-30, build-tools 30.0.3
    • ANDROID_HOME = /Volumes/Extreme/sdk
    • Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6915495)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 12.3)
    • Xcode at /Volumes/Extreme/Xcode.app/Contents/Developer
    • Xcode 12.3, Build version 12C33
    • CocoaPods version 1.10.0

[!] Android Studio (version 4.1)
    • Android Studio at /Applications/Android Studio.app/Contents
    ✗ Flutter plugin not installed; this adds Flutter specific functionality.
    ✗ Dart plugin not installed; this adds Dart specific functionality.
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6915495)

[✓] VS Code (version 1.52.1)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.18.0

[✓] Connected device (2 available)
    • RMX2001 (mobile)     • EUYTFEUSQSRGDA6D          • android-arm64 • Android 10 (API 29)
    • Taha’s iPad (mobile) • 00008020-000255113EE8402E • ios           • iOS 14.3
    ! Error: Taha’s iPad is busy: Copying cache files from device. Xcode will continue when Taha’s iPad is finished. (code -10)

! Doctor found issues in 1 category.

[✓] Flutter (Channel beta, 1.25.0-8.1.pre, on macOS 11.1 20C69 darwin-x64, locale en-GB)
    • Flutter version 1.25.0-8.1.pre at /Users/tahatesser/Code/flutter_beta
    • Framework revision 8f89f6505b (3 weeks ago), 2020-12-15 15:07:52 -0800
    • Engine revision 92ae191c17
    • Dart version 2.12.0 (build 2.12.0-133.2.beta)

[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.3)
    • Android SDK at /Volumes/Extreme/sdk
    • Platform android-30, build-tools 30.0.3
    • ANDROID_HOME = /Volumes/Extreme/sdk
    • Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6915495)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 12.3)
    • Xcode at /Volumes/Extreme/Xcode.app/Contents/Developer
    • Xcode 12.3, Build version 12C33
    • CocoaPods version 1.10.0

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 4.1)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6915495)

[✓] VS Code (version 1.52.1)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.18.0

[✓] Connected device (3 available)
    • RMX2001 (mobile)     • EUYTFEUSQSRGDA6D          • android-arm64  • Android 10 (API 29)
    • Taha’s iPad (mobile) • 00008020-000255113EE8402E • ios            • iOS 14.3
    • Chrome (web)         • chrome                    • web-javascript • Google Chrome 87.0.4280.88
    ! Error: Taha’s iPad is busy: Copying cache files from device. Xcode will continue when Taha’s iPad is finished. (code -10)

• No issues found!

[✓] Flutter (Channel dev, 1.26.0-1.0.pre, on macOS 11.1 20C69 darwin-x64, locale en-GB)
    • Flutter version 1.26.0-1.0.pre at /Users/tahatesser/Code/flutter_dev
    • Framework revision 63062a6443 (3 weeks ago), 2020-12-13 23:19:13 +0800
    • Engine revision 4797b06652
    • Dart version 2.12.0 (build 2.12.0-141.0.dev)

[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.3)
    • Android SDK at /Volumes/Extreme/sdk
    • Platform android-30, build-tools 30.0.3
    • ANDROID_HOME = /Volumes/Extreme/sdk
    • Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6915495)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 12.3)
    • Xcode at /Volumes/Extreme/Xcode.app/Contents/Developer
    • Xcode 12.3, Build version 12C33
    • CocoaPods version 1.10.0

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 4.1)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6915495)

[✓] VS Code (version 1.52.1)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.18.0

[✓] Connected device (4 available)
    • RMX2001 (mobile)     • EUYTFEUSQSRGDA6D          • android-arm64  • Android 10 (API 29)
    • Taha’s iPad (mobile) • 00008020-000255113EE8402E • ios            • iOS 14.3
    • macOS (desktop)      • macos                     • darwin-x64     • macOS 11.1 20C69 darwin-x64
    • Chrome (web)         • chrome                    • web-javascript • Google Chrome 87.0.4280.88
    ! Error: Taha’s iPad is busy: Copying cache files from device. Xcode will continue when Taha’s iPad is finished. (code -10)

• No issues found!

[✓] Flutter (Channel master, 1.26.0-2.0.pre.168, on macOS 11.1 20C69 darwin-x64, locale en-GB)
    • Flutter version 1.26.0-2.0.pre.168 at /Users/tahatesser/Code/flutter_master
    • Framework revision 299e017e41 (23 hours ago), 2021-01-03 06:29:01 -0500
    • Engine revision 121b67fb85
    • Dart version 2.12.0 (build 2.12.0-179.0.dev)

[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.3)
    • Android SDK at /Volumes/Extreme/sdk
    • Platform android-30, build-tools 30.0.3
    • ANDROID_HOME = /Volumes/Extreme/sdk
    • Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6915495)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 12.3)
    • Xcode at /Volumes/Extreme/Xcode.app/Contents/Developer
    • Xcode 12.3, Build version 12C33
    • CocoaPods version 1.10.0

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 4.1)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6915495)

[✓] VS Code (version 1.52.1)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.18.0

[✓] Connected device (4 available)
    • RMX2001 (mobile)     • EUYTFEUSQSRGDA6D          • android-arm64  • Android 10 (API 29)
    • Taha’s iPad (mobile) • 00008020-000255113EE8402E • ios            • iOS 14.3
    • macOS (desktop)      • macos                     • darwin-x64     • macOS 11.1 20C69 darwin-x64
    • Chrome (web)         • chrome                    • web-javascript • Google Chrome 87.0.4280.88
    ! Error: Taha’s iPad is busy: Copying cache files from device. Xcode will continue when Taha’s iPad is finished. (code -10)

• No issues found!

It is expected that some icons will look the same in different styles, but I'll follow up with the icons team to determine what's going on with the filled style vs others (it looks like its shrunk on material.io, but looks the same as others with svgs).
For two-tone, see this comment

It is expected that some icons will look the same in different styles, but I'll follow up with the icons team to determine what's going on with the filled style vs others (it looks like its shrunk on material.io, but looks the same as others with svgs).
For two-tone, see this comment

@guidezpl i stumbled upon upon a few other icons that have wrong styles and decided to take one section ("content") from material icons and compare web and flutter
turns out a some of icons are simply missing, and other have old rounded styles (didn't test others)
flutter (default and rounded)

web (default and rounded)

code for comparison
import 'package:flutter/material.dart';

void main() {
  runApp(App());
}

class App extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      title: 'App',
      home: Scaffold(
        body: DefaultTabController(
          initialIndex: 0,
          length: 2,
          child: TabBarView(
            children: [
              Center(
                child: GridView.count(
                  shrinkWrap: true,
                  crossAxisCount: 12,
                  children: [
                    Icon(Icons.add),
                    Icon(Icons.add_box),
                    Icon(Icons.add_circle),
                    Icon(Icons.add_circle_outline),
                    Icon(Icons.amp_stories),
                    Icon(Icons.archive),
                    Icon(Icons.backspace),
                    Icon(Icons.ballot),
                    Icon(Icons.biotech),
                    Icon(Icons.block),
                    Icon(Icons.calculate),
                    Container(), // Icon(Icons.change_circle),
                    Icon(Icons.clear),
                    Icon(Icons.content_copy),
                    Icon(Icons.content_cut),
                    Icon(Icons.content_paste),
                    Container(), // Icon(Icons.content_paste_off),
                    Container(), // Icon(Icons.copy_all),
                    Icon(Icons.create),
                    Icon(Icons.delete_sweep),
                    Icon(Icons.drafts),
                    Icon(Icons.dynamic_feed),
                    Icon(Icons.file_copy),
                    Icon(Icons.filter_list),
                    Icon(Icons.flag),
                    Icon(Icons.font_download),
                    Container(), // Icon(Icons.font_download_off),
                    Icon(Icons.forward),
                    Icon(Icons.gesture),
                    Icon(Icons.how_to_reg),
                    Icon(Icons.how_to_vote),
                    Icon(Icons.inbox),
                    Icon(Icons.insights),
                    Container(), // Icon(Icons.inventory_2),
                    Icon(Icons.link),
                    Icon(Icons.link_off),
                    Icon(Icons.low_priority),
                    Icon(Icons.mail),
                    Icon(Icons.markunread),
                    Icon(Icons.move_to_inbox),
                    Icon(Icons.next_week),
                    Icon(Icons.outlined_flag),
                    Icon(Icons.policy),
                    Icon(Icons.push_pin),
                    Icon(Icons.redo),
                    Icon(Icons.remove),
                    Icon(Icons.remove_circle),
                    Icon(Icons.remove_circle_outline),
                    Icon(Icons.reply),
                    Icon(Icons.reply_all),
                    Icon(Icons.report),
                    Icon(Icons.report_off),
                    Icon(Icons.save),
                    Icon(Icons.save_alt),
                    Icon(Icons.select_all),
                    Icon(Icons.send),
                    Icon(Icons.sort),
                    Icon(Icons.square_foot),
                    Icon(Icons.text_format),
                    Icon(Icons.unarchive),
                    Icon(Icons.undo),
                    Icon(Icons.waves),
                    Icon(Icons.weekend),
                    Icon(Icons.where_to_vote),
                  ],
                ),
              ),
              Center(
                child: GridView.count(
                  shrinkWrap: true,
                  crossAxisCount: 12,
                  children: [
                    Icon(Icons.add_rounded),
                    Icon(Icons.add_box_rounded),
                    Icon(Icons.add_circle_rounded),
                    Icon(Icons.add_circle_outline_rounded),
                    Icon(Icons.amp_stories_rounded),
                    Icon(Icons.archive_rounded),
                    Icon(Icons.backspace_rounded),
                    Icon(Icons.ballot_rounded),
                    Icon(Icons.biotech_rounded),
                    Icon(Icons.block_rounded),
                    Icon(Icons.calculate_rounded),
                    Container(), // Icon(Icons.change_circle_rounded),
                    Icon(Icons.clear_rounded),
                    Icon(Icons.content_copy_rounded),
                    Icon(Icons.content_cut_rounded),
                    Icon(Icons.content_paste_rounded),
                    Container(), // Icon(Icons.content_paste_off_rounded),
                    Container(), // Icon(Icons.copy_all_rounded),
                    Icon(Icons.create_rounded),
                    Icon(Icons.delete_sweep_rounded),
                    Icon(Icons.drafts_rounded),
                    Icon(Icons.dynamic_feed_rounded),
                    Icon(Icons.file_copy_rounded),
                    Icon(Icons.filter_list_rounded),
                    Icon(Icons.flag_rounded),
                    Icon(Icons.font_download_rounded),
                    Container(), // Icon(Icons.font_download_off_rounded),
                    Icon(Icons.forward_rounded),
                    Icon(Icons.gesture_rounded),
                    Icon(Icons.how_to_reg_rounded),
                    Icon(Icons.how_to_vote_rounded),
                    Icon(Icons.inbox_rounded),
                    Icon(Icons.insights_rounded),
                    Container(), // Icon(Icons.inventory_2_rounded),
                    Icon(Icons.link_rounded),
                    Icon(Icons.link_off_rounded),
                    Icon(Icons.low_priority_rounded),
                    Icon(Icons.mail_rounded),
                    Icon(Icons.markunread_rounded),
                    Icon(Icons.move_to_inbox_rounded),
                    Icon(Icons.next_week_rounded),
                    Icon(Icons.outlined_flag_rounded),
                    Icon(Icons.policy_rounded),
                    Icon(Icons.push_pin_rounded),
                    Icon(Icons.redo_rounded),
                    Icon(Icons.remove_rounded),
                    Icon(Icons.remove_circle_rounded),
                    Icon(Icons.remove_circle_outline_rounded),
                    Icon(Icons.reply_rounded),
                    Icon(Icons.reply_all_rounded),
                    Icon(Icons.report_rounded),
                    Icon(Icons.report_off_rounded),
                    Icon(Icons.save_rounded),
                    Icon(Icons.save_alt_rounded),
                    Icon(Icons.select_all_rounded),
                    Icon(Icons.send_rounded),
                    Icon(Icons.sort_rounded),
                    Icon(Icons.square_foot_rounded),
                    Icon(Icons.text_format_rounded),
                    Icon(Icons.unarchive_rounded),
                    Icon(Icons.undo_rounded),
                    Icon(Icons.waves_rounded),
                    Icon(Icons.weekend_rounded),
                    Icon(Icons.where_to_vote_rounded),
                  ],
                ),
              ),
            ],
          ),
        ),
      ),
    );
  }
}

@guidezpl i stumbled upon upon a few other icons that have wrong styles and decided to take one section ("content") from material icons and compare web and flutter
turns out a some of icons are simply missing, and other have old rounded styles (didn't test others)
flutter (default and rounded)

web (default and rounded)

code for comparison
import 'package:flutter/material.dart';

void main() {
  runApp(App());
}

class App extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      title: 'App',
      home: Scaffold(
        body: DefaultTabController(
          initialIndex: 0,
          length: 2,
          child: TabBarView(
            children: [
              Center(
                child: GridView.count(
                  shrinkWrap: true,
                  crossAxisCount: 12,
                  children: [
                    Icon(Icons.add),
                    Icon(Icons.add_box),
                    Icon(Icons.add_circle),
                    Icon(Icons.add_circle_outline),
                    Icon(Icons.amp_stories),
                    Icon(Icons.archive),
                    Icon(Icons.backspace),
                    Icon(Icons.ballot),
                    Icon(Icons.biotech),
                    Icon(Icons.block),
                    Icon(Icons.calculate),
                    Container(), // Icon(Icons.change_circle),
                    Icon(Icons.clear),
                    Icon(Icons.content_copy),
                    Icon(Icons.content_cut),
                    Icon(Icons.content_paste),
                    Container(), // Icon(Icons.content_paste_off),
                    Container(), // Icon(Icons.copy_all),
                    Icon(Icons.create),
                    Icon(Icons.delete_sweep),
                    Icon(Icons.drafts),
                    Icon(Icons.dynamic_feed),
                    Icon(Icons.file_copy),
                    Icon(Icons.filter_list),
                    Icon(Icons.flag),
                    Icon(Icons.font_download),
                    Container(), // Icon(Icons.font_download_off),
                    Icon(Icons.forward),
                    Icon(Icons.gesture),
                    Icon(Icons.how_to_reg),
                    Icon(Icons.how_to_vote),
                    Icon(Icons.inbox),
                    Icon(Icons.insights),
                    Container(), // Icon(Icons.inventory_2),
                    Icon(Icons.link),
                    Icon(Icons.link_off),
                    Icon(Icons.low_priority),
                    Icon(Icons.mail),
                    Icon(Icons.markunread),
                    Icon(Icons.move_to_inbox),
                    Icon(Icons.next_week),
                    Icon(Icons.outlined_flag),
                    Icon(Icons.policy),
                    Icon(Icons.push_pin),
                    Icon(Icons.redo),
                    Icon(Icons.remove),
                    Icon(Icons.remove_circle),
                    Icon(Icons.remove_circle_outline),
                    Icon(Icons.reply),
                    Icon(Icons.reply_all),
                    Icon(Icons.report),
                    Icon(Icons.report_off),
                    Icon(Icons.save),
                    Icon(Icons.save_alt),
                    Icon(Icons.select_all),
                    Icon(Icons.send),
                    Icon(Icons.sort),
                    Icon(Icons.square_foot),
                    Icon(Icons.text_format),
                    Icon(Icons.unarchive),
                    Icon(Icons.undo),
                    Icon(Icons.waves),
                    Icon(Icons.weekend),
                    Icon(Icons.where_to_vote),
                  ],
                ),
              ),
              Center(
                child: GridView.count(
                  shrinkWrap: true,
                  crossAxisCount: 12,
                  children: [
                    Icon(Icons.add_rounded),
                    Icon(Icons.add_box_rounded),
                    Icon(Icons.add_circle_rounded),
                    Icon(Icons.add_circle_outline_rounded),
                    Icon(Icons.amp_stories_rounded),
                    Icon(Icons.archive_rounded),
                    Icon(Icons.backspace_rounded),
                    Icon(Icons.ballot_rounded),
                    Icon(Icons.biotech_rounded),
                    Icon(Icons.block_rounded),
                    Icon(Icons.calculate_rounded),
                    Container(), // Icon(Icons.change_circle_rounded),
                    Icon(Icons.clear_rounded),
                    Icon(Icons.content_copy_rounded),
                    Icon(Icons.content_cut_rounded),
                    Icon(Icons.content_paste_rounded),
                    Container(), // Icon(Icons.content_paste_off_rounded),
                    Container(), // Icon(Icons.copy_all_rounded),
                    Icon(Icons.create_rounded),
                    Icon(Icons.delete_sweep_rounded),
                    Icon(Icons.drafts_rounded),
                    Icon(Icons.dynamic_feed_rounded),
                    Icon(Icons.file_copy_rounded),
                    Icon(Icons.filter_list_rounded),
                    Icon(Icons.flag_rounded),
                    Icon(Icons.font_download_rounded),
                    Container(), // Icon(Icons.font_download_off_rounded),
                    Icon(Icons.forward_rounded),
                    Icon(Icons.gesture_rounded),
                    Icon(Icons.how_to_reg_rounded),
                    Icon(Icons.how_to_vote_rounded),
                    Icon(Icons.inbox_rounded),
                    Icon(Icons.insights_rounded),
                    Container(), // Icon(Icons.inventory_2_rounded),
                    Icon(Icons.link_rounded),
                    Icon(Icons.link_off_rounded),
                    Icon(Icons.low_priority_rounded),
                    Icon(Icons.mail_rounded),
                    Icon(Icons.markunread_rounded),
                    Icon(Icons.move_to_inbox_rounded),
                    Icon(Icons.next_week_rounded),
                    Icon(Icons.outlined_flag_rounded),
                    Icon(Icons.policy_rounded),
                    Icon(Icons.push_pin_rounded),
                    Icon(Icons.redo_rounded),
                    Icon(Icons.remove_rounded),
                    Icon(Icons.remove_circle_rounded),
                    Icon(Icons.remove_circle_outline_rounded),
                    Icon(Icons.reply_rounded),
                    Icon(Icons.reply_all_rounded),
                    Icon(Icons.report_rounded),
                    Icon(Icons.report_off_rounded),
                    Icon(Icons.save_rounded),
                    Icon(Icons.save_alt_rounded),
                    Icon(Icons.select_all_rounded),
                    Icon(Icons.send_rounded),
                    Icon(Icons.sort_rounded),
                    Icon(Icons.square_foot_rounded),
                    Icon(Icons.text_format_rounded),
                    Icon(Icons.unarchive_rounded),
                    Icon(Icons.undo_rounded),
                    Icon(Icons.waves_rounded),
                    Icon(Icons.weekend_rounded),
                    Icon(Icons.where_to_vote_rounded),
                  ],
                ),
              ),
            ],
          ),
        ),
      ),
    );
  }
}

by the way is this ok that some of the filled icons even in web has very different appearance compared to all other styles?
some examples
filled on top, rounded on bottom
1

2

3

by the way is this ok that some of the filled icons even in web has very different appearance compared to all other styles?
some examples
filled on top, rounded on bottom
1

2

3

Thanks for the report! An upcoming font update should deal with the missing icons and style issue. For your general question about variants having a different look, let me get back to you

Thanks for the report! An upcoming font update should deal with the missing icons and style issue. For your general question about variants having a different look, let me get back to you

According to https://github.com/flutter/flutter/issues/76684, restart_alt is also missing

@guidezpl can you clarify: is https://material.io/resources/icons/ goint to be replaced by https://fonts.google.com/icons ?
the latter seems to be a more maintained

I don't know, but https://fonts.google.com/icons was just launched so I'd go with that. I haven't forgotten about this issue, just need a few PRs to land before more work

ok. i deleted my comment and moved it here, because it's off topic

The style question is with the icons team (b/176798798), who will update the icons as necessary. If they are updated, so will Flutter's. #78311 will fix all of the remaining issues.

The style question is with the icons team (b/176798798), who will update the icons as necessary. If they are updated, so will Flutter's. #78311 will fix all of the remaining issues.

Would you please request to update the Google Fonts package as well? It's pretty outdated 👍
http://fonts.gstatic.com/s/f/directory002.pb

Best thing to do would be to file an issue at https://github.com/material-foundation/google-fonts-flutter/

Best thing to do would be to file an issue at https://github.com/material-foundation/google-fonts-flutter/

There were already some issues mentioning missing fonts.. I have posted another one that groups them all. https://github.com/material-foundation/google-fonts-flutter/issues/158


Fix undefined local var error

Because the method argument is icon, not image...
Very nice project 👍

Yikes.  Thanks!


Please fix the readme stating that Mantis supports macCatalyst but not macOS.

Strictly saying, supporting macOS and supporting macCatalyst are two different things. The former strictly relies on AppKit with zero dependency to UIKit. The latter is vice-versa.

@ShikiSuen
The README initially stated that Mantis only supports Catalyst.
Mantis is an iOS image cropping library written in Swift, designed to mimic the Photo app and provide rich cropping interactions for your iOS or Mac app (Catalyst-only).
Mac Catalyst requires macOS 10.15 or later as the minimum deployment target, which is why macOS 10.15 is listed as a requirement.

@guoyingtao Then the macOS target needs to be removed from package.swift.


add colon (:) to tcp endpoint

The TCP endpoint indicated on the API root (i.e. http://localhost:3000/signalk) was listed without the colon (i.e. tcp://localhostXXXX instead of tcp://localhost:XXXX).

Note that I decided to use string literal syntax using backticks to concatenate the string.

Thanks!


Endpoint to register a new 'worker' user

Description
This Pull Request adds the registration endpoint for type worker user.
Summary of changes

Added Swagger docs.
Environment variables handler.
Registration endpoint.

Related issues
Fixes #3

Please add unit and end2end tests.
Also check if end2end tests are run just by a separate command and not included in just npm test


Add optional Characteristic for humidity

This adds the humidity inside (and target goal for the system) to the details page

Closing as stale


fixing numpy version

Fixes #32

@CarlottaSartore I think this is good for understanding that the problem is 1.24, but I would not merge in this form as it would constrain anyone using ADAM to use 1.23.5. If at the moment ADAM is only compatible with numpy 1.23 (I guess it does not work with 1.22, right?) probably we can pin to 1.23, and open an issue to understand what is going wrong with numpy 1.24 ? In the long term not being compatible with 1.24 would be quite problematic.

Thanks @CarlottaSartore !
I agree with@traversaro.
The problem seems related to the casadi mtimes() implementation. Strange! I'm investigating

Closing this PR since #34 solves the issue by supporting numpy 1.24


Using CSS variables in Mobi.css v3

After some investigating, I think maybe it's time to use css variables in<EMAIL_ADDRESS>First of all, css variables is the future of css. It's already drafted three years ago, and most of modern browsers supports it. There is a demo here.
Secondly, for me, the most useful feature of SASS is variables. Css variables not only extends the all function of SASS variables, but also has some exciting features. Such as scoping, calculating and re-rendering in time.
Last, using css variables can bring us a comfortable way to customizing themes, just need to override some variables. No more compiling!

https://philipwalton.com/articles/why-im-excited-about-native-css-variables/

It's too risky to use css variables now, let's put it in the v3


Deferrable operator should also have poll_interval

We added poll_interval to our armadaOperator.  https://github.com/armadaproject/armada/pull/2444
I noticed that we didn't add this API field to the deferrable operator.  We should add poll_interval as a parameter (https://github.com/armadaproject/armada/blob/master/third_party/airflow/armada/operators/armada_deferrable.py#L83)
┆Issue is synchronized with this Jira Task by Unito

Hey @kannon92 , I am new to this project and would love to take up this issue. Can you please assign it to me?
Thanks in advance.

Assigned!  Thanks for picking it up.

May , I also work in this @kannon92 ?

May , I also work in this?

@Nawaz027 has already started asked.

Need any help @Nawaz027 ?

@kannon92  is this issue still up? May I work on this


YARN-11510. [Federation] Fix NodeManager#TestFederationInterceptor Flaky Unit Test.

Description of PR
JIRA: YARN-11510. [Federation] Fix NodeManager#TestFederationInterceptor Flaky Unit Test.

Issue 1: java.lang.IllegalArgumentException: not a proxy instance

2023-06-10 16:38:39,932 ERROR [main] ipc.RPC (RPC.java:stopProxy(811)) - RPC.stopProxy called on non proxy: class=org.apache.hadoop.yarn.server.MockResourceManagerFacade
java.lang.IllegalArgumentException: not a proxy instance
    at java.lang.reflect.Proxy.getInvocationHandler(Proxy.java:816)
    at org.apache.hadoop.ipc.RPC.stopProxy(RPC.java:802)
    at org.apache.hadoop.yarn.server.AMRMClientRelayer.shutdown(AMRMClientRelayer.java:198)
    at org.apache.hadoop.yarn.server.nodemanager.amrmproxy.FederationInterceptor.shutdown(FederationInterceptor.java:883)
    at org.apache.hadoop.yarn.server.nodemanager.amrmproxy.TestFederationInterceptor.tearDown(TestFederationInterceptor.java:145)
    at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)

Issue Cause and Solution

This issue is because MockResourceManagerFacade does not implement Closeable, so it cannot be closed properly.
We can solve the issue by letting MockResourceManagerFacade implements Closeable.

Issue 2:  TestFederationInterceptor#testRecoverWithoutAMRMProxyHA getTimedOutSCs(SC-1) Error.

// Line 594
Assert.assertEquals(1, interceptor.getTimedOutSCs(true).size());

java.lang.AssertionError:
Expected :1
Actual :0
<Click to see difference>

at org.junit.Assert.fail(Assert.java:89)
at org.junit.Assert.failNotEquals(Assert.java:835)
at org.junit.Assert.assertEquals(Assert.java:647)
at org.junit.Assert.assertEquals(Assert.java:633)
at org.apache.hadoop.yarn.server.nodemanager.amrmproxy.TestFederationInterceptor$3.run(TestFederationInterceptor.java:594)
at java.security.AccessController.doPrivileged(Native Method)
at javax.security.auth.Subject.doAs(Subject.java:422)
at org.apache.hadoop.security.UserGroupInformation.doAs(UserGroupInformation.java:1953)
at org.apache.hadoop.yarn.server.nodemanager.amrmproxy.TestFederationInterceptor.testRecover(TestFederationInterceptor.java:534)
at org.apache.hadoop.yarn.server.nodemanager.amrmproxy.TestFederationInterceptor.testRecoverWithoutAMRMProxyHA(TestFederationInterceptor.java:517)

Issue Cause and Solution

This issue is because we need to wait for the timeout of SC-1, which takes 500ms. However, if the program executes very quickly, this process may take less than 500ms, resulting in an assertion error when judging that the subcluster has expired.
We sleep in the program for 800ms to ensure that SC-1 times out.

Issue 3:  TestFederationInterceptor#ttestSubClusterTimeOut AllocateAsync should not be called before launchUAM

2023-06-10 17:28:24,986 INFO [pool-23-thread-1] uam.UnmanagedAMPoolManager (UnmanagedAMPoolManager.java:launchUAM(210)) - Launching UAM id [SC-1](https://issues.apache.org/jira/browse/SCB-1) for application application_123456_0001
2023-06-10 17:28:24,986 ERROR [main] amrmproxy.FederationInterceptor (FederationInterceptor.java:allocate(780)) - Exception encountered while processing heart beat for appattempt_123456_0001_000001
org.apache.hadoop.yarn.exceptions.YarnException: AllocateAsync should not be called before launchUAM
at org.apache.hadoop.yarn.server.uam.UnmanagedApplicationManager.allocateAsync(UnmanagedApplicationManager.java:325)
at org.apache.hadoop.yarn.server.uam.UnmanagedAMPoolManager.allocateAsync(UnmanagedAMPoolManager.java:325)

Issue Cause and Solution

This issue is because our registration of UAM and allocation of Containers through AllocateAsync are asynchronous. This is reasonable for production environments, as we can allocate containers once the UAM is successfully registered. However, for testing scenarios, we need to wait for the UAM to be registered before we allocate containers.
Our new configuration parameter is 'yarn.nodemanager.amrmproxy.wait.uam-register.done', which is set to false by default.
In the unit tests, we set 'yarn.nodemanager.amrmproxy.wait.uam-register.done' to true to ensure that UAM has completed registration before allocating containers.
How was this patch tested?
Junit Test.
For code changes:

[ ] Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
[ ] Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
[ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
[ ] If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 52s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 2 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
17m 58s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
24m  4s

trunk passed

+1 :green_heart:
compile
8m 10s

trunk passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
compile
7m 28s

trunk passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
checkstyle
2m  7s

trunk passed

+1 :green_heart:
mvnsite
2m 43s

trunk passed

+1 :green_heart:
javadoc
2m 40s

trunk passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
2m 18s

trunk passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
spotbugs
5m 38s

trunk passed

+1 :green_heart:
shadedclient
25m 48s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 30s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
1m 48s

the patch passed

+1 :green_heart:
compile
7m 28s

the patch passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javac
7m 28s

the patch passed

+1 :green_heart:
compile
7m 29s

the patch passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
javac
7m 29s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
1m 58s

the patch passed

+1 :green_heart:
mvnsite
2m 37s

the patch passed

+1 :green_heart:
javadoc
2m 33s

the patch passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
2m 13s

the patch passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
spotbugs
5m 53s

the patch passed

+1 :green_heart:
shadedclient
25m 43s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
1m 10s
/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-api.txt
hadoop-yarn-api in the patch passed.

-1 :x:
unit
3m 34s
/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-common.txt
hadoop-yarn-server-common in the patch passed.

+1 :green_heart:
unit
24m 19s

hadoop-yarn-server-nodemanager in the patch passed.

+1 :green_heart:
asflicense
0m 55s

The patch does not generate ASF License warnings.

192m 21s

Reason
Tests

Failed junit tests
hadoop.yarn.conf.TestYarnConfigurationFields

hadoop.yarn.server.uam.TestUnmanagedApplicationManager

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5733/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5733

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux 81f675c6eaff 4.15.0-206-generic #217-Ubuntu SMP Fri Feb 3 19:10:13 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 5d847ebe7908ed9a1b5e79e6a6a82121c7bb860d

Default Java
Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5733/1/testReport/

Max. process+thread count
556 (vs. ulimit of 5500)

modules
C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager U: hadoop-yarn-project/hadoop-yarn

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5733/1/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 41s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+0 :ok:
detsecrets
0m  1s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 2 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
18m 29s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
20m 42s

trunk passed

+1 :green_heart:
compile
7m 48s

trunk passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
compile
7m 24s

trunk passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
checkstyle
2m  2s

trunk passed

+1 :green_heart:
mvnsite
3m 13s

trunk passed

+1 :green_heart:
javadoc
3m 12s

trunk passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
2m 54s

trunk passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
spotbugs
5m 53s

trunk passed

+1 :green_heart:
shadedclient
23m 17s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 33s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
1m 49s

the patch passed

+1 :green_heart:
compile
6m 58s

the patch passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javac
6m 58s

the patch passed

+1 :green_heart:
compile
7m  7s

the patch passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
javac
7m  7s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
1m 54s

the patch passed

+1 :green_heart:
mvnsite
2m 50s

the patch passed

+1 :green_heart:
javadoc
2m 45s

the patch passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
2m 38s

the patch passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
spotbugs
5m 54s

the patch passed

+1 :green_heart:
shadedclient
23m 15s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
1m 20s
/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-api.txt
hadoop-yarn-api in the patch passed.

-1 :x:
unit
3m 39s
/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-common.txt
hadoop-yarn-server-common in the patch passed.

+1 :green_heart:
unit
24m 57s

hadoop-yarn-server-nodemanager in the patch passed.

+1 :green_heart:
asflicense
1m  4s

The patch does not generate ASF License warnings.

188m 41s

Reason
Tests

Failed junit tests
hadoop.yarn.conf.TestYarnConfigurationFields

hadoop.yarn.server.uam.TestUnmanagedApplicationManager

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5733/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5733

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux 435d2b3c1566 4.15.0-206-generic #217-Ubuntu SMP Fri Feb 3 19:10:13 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / bfd68f61e1dbb7bf18c620a6055232dea7d8fe96

Default Java
Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5733/2/testReport/

Max. process+thread count
560 (vs. ulimit of 5500)

modules
C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager U: hadoop-yarn-project/hadoop-yarn

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5733/2/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 59s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+0 :ok:
xmllint
0m  0s

xmllint was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 2 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
18m 52s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
23m 59s

trunk passed

+1 :green_heart:
compile
8m 24s

trunk passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
compile
7m 26s

trunk passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
checkstyle
2m  1s

trunk passed

+1 :green_heart:
mvnsite
3m 50s

trunk passed

+1 :green_heart:
javadoc
3m 55s

trunk passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
3m  9s

trunk passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
spotbugs
7m 27s

trunk passed

+1 :green_heart:
shadedclient
25m 35s

branch has no errors when building and testing our client artifacts.

-0 :warning:
patch
26m  1s

Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 29s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 24s

the patch passed

+1 :green_heart:
compile
7m 27s

the patch passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javac
7m 27s

the patch passed

+1 :green_heart:
compile
7m 26s

the patch passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
javac
7m 26s

the patch passed

-1 :x:
blanks
0m  0s
/blanks-eol.txt
The patch has 1 line(s) that end in blanks. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply

+1 :green_heart:
checkstyle
1m 50s

the patch passed

+1 :green_heart:
mvnsite
3m 17s

the patch passed

+1 :green_heart:
javadoc
3m 11s

the patch passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
2m 59s

the patch passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
spotbugs
7m 33s

the patch passed

+1 :green_heart:
shadedclient
25m 15s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
1m  9s

hadoop-yarn-api in the patch passed.

+1 :green_heart:
unit
5m 33s

hadoop-yarn-common in the patch passed.

+1 :green_heart:
unit
3m 29s

hadoop-yarn-server-common in the patch passed.

+1 :green_heart:
unit
24m 14s

hadoop-yarn-server-nodemanager in the patch passed.

+1 :green_heart:
asflicense
0m 56s

The patch does not generate ASF License warnings.

207m 40s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5733/4/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5733

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets xmllint

uname
Linux 6c357d1f9657 4.15.0-206-generic #217-Ubuntu SMP Fri Feb 3 19:10:13 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 17b42f9366d51b88a6f223bce45ff91be5461231

Default Java
Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5733/4/testReport/

Max. process+thread count
530 (vs. ulimit of 5500)

modules
C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager U: hadoop-yarn-project/hadoop-yarn

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5733/4/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 53s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+0 :ok:
detsecrets
0m  1s

detect-secrets was not available.

+0 :ok:
xmllint
0m  1s

xmllint was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 2 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
18m 30s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
24m  1s

trunk passed

+1 :green_heart:
compile
8m  1s

trunk passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
compile
7m 25s

trunk passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
checkstyle
2m  0s

trunk passed

+1 :green_heart:
mvnsite
3m 43s

trunk passed

+1 :green_heart:
javadoc
3m 36s

trunk passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
3m 18s

trunk passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
spotbugs
7m 18s

trunk passed

+1 :green_heart:
shadedclient
25m 18s

branch has no errors when building and testing our client artifacts.

-0 :warning:
patch
25m 43s

Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 53s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 20s

the patch passed

+1 :green_heart:
compile
7m 19s

the patch passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javac
7m 19s

the patch passed

+1 :green_heart:
compile
7m 20s

the patch passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
javac
7m 20s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
1m 52s

the patch passed

+1 :green_heart:
mvnsite
3m 17s

the patch passed

+1 :green_heart:
javadoc
3m 13s

the patch passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
3m  1s

the patch passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
spotbugs
7m 34s

the patch passed

+1 :green_heart:
shadedclient
25m 12s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
1m  8s

hadoop-yarn-api in the patch passed.

+1 :green_heart:
unit
5m 33s

hadoop-yarn-common in the patch passed.

+1 :green_heart:
unit
3m 31s

hadoop-yarn-server-common in the patch passed.

+1 :green_heart:
unit
24m 10s

hadoop-yarn-server-nodemanager in the patch passed.

+1 :green_heart:
asflicense
0m 55s

The patch does not generate ASF License warnings.

206m 10s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5733/5/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5733

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets xmllint

uname
Linux b972b1b94512 4.15.0-206-generic #217-Ubuntu SMP Fri Feb 3 19:10:13 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / a357f9be9da29e8bf3e6662c447ca496d7d7c49a

Default Java
Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5733/5/testReport/

Max. process+thread count
529 (vs. ulimit of 5500)

modules
C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager U: hadoop-yarn-project/hadoop-yarn

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5733/5/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
1m  5s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+0 :ok:
detsecrets
0m  1s

detect-secrets was not available.

+0 :ok:
xmllint
0m  1s

xmllint was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 2 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
17m  5s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
23m 51s

trunk passed

+1 :green_heart:
compile
8m 18s

trunk passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
compile
7m 49s

trunk passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
checkstyle
2m 17s

trunk passed

+1 :green_heart:
mvnsite
3m 38s

trunk passed

+1 :green_heart:
javadoc
3m 50s

trunk passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
3m 17s

trunk passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
spotbugs
7m 55s

trunk passed

+1 :green_heart:
shadedclient
26m  4s

branch has no errors when building and testing our client artifacts.

-0 :warning:
patch
26m 29s

Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 29s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 20s

the patch passed

+1 :green_heart:
compile
7m 19s

the patch passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javac
7m 19s

the patch passed

+1 :green_heart:
compile
7m 15s

the patch passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
javac
7m 15s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
1m 51s

the patch passed

+1 :green_heart:
mvnsite
3m 14s

the patch passed

+1 :green_heart:
javadoc
3m 21s

the patch passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
3m  0s

the patch passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
spotbugs
7m 34s

the patch passed

+1 :green_heart:
shadedclient
25m 24s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
1m  7s

hadoop-yarn-api in the patch passed.

+1 :green_heart:
unit
5m 33s

hadoop-yarn-common in the patch passed.

+1 :green_heart:
unit
3m 27s

hadoop-yarn-server-common in the patch passed.

+1 :green_heart:
unit
24m 13s

hadoop-yarn-server-nodemanager in the patch passed.

+1 :green_heart:
asflicense
0m 56s

The patch does not generate ASF License warnings.

207m  8s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5733/6/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5733

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets xmllint

uname
Linux a41898ac143d 4.15.0-212-generic #223-Ubuntu SMP Tue May 23 13:09:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 2f9c78a01e1804b1a1eea28bcc040105e1b1efd9

Default Java
Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5733/6/testReport/

Max. process+thread count
537 (vs. ulimit of 5500)

modules
C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager U: hadoop-yarn-project/hadoop-yarn

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5733/6/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

@goiri Thank you very much for your help in reviewing the code!


anyOrNull() throws null pointer with Int

This throws a null pointer error, whereas if I replace the param with a String it passes. This library is fantastic but this is annoying because I always have to make sure I match any() or anyOrNull() to the actual implementation when I don't actually care about this for the test
class TestClass {
    val thingy: Thingy = mock()

    @Test
    fun failingTest() {
        whenever(thingy.doStuff(anyOrNull())).thenReturn(true)
        thingy.doStuff(1)
    }
}

class Thingy {
    fun doStuff(param: Int): Boolean {
        return false
    }
}

Perhaps anyOrNull() should be constrained to Any?, not Any

@CarsonRedeye It's a mix of using a non-nullable primitive as an argument in your function (and maybe not having an open class - unless you use inline-mock-maker or allOpen which isn't obvious from your description).
Make your class and method open and also change the signature on the doStuff function to use a nullable type. Otherwise use the anyInt() function as your matcher instead of anyOrNull().
Here's a working example:
open class Thingy {
    open fun doStuff(param: Int?): Boolean {
        return false
    }
}

@Test
fun failingTest() {
    val mock = mock<Thingy>()
    whenever(mock.doStuff(anyOrNull())).thenReturn(true)
    assertTrue(mock.doStuff(null))
}

It's the annoying part of mocking with mockito-kotlin, but it's difficult/impossible to do anything about AFAIK.

I'm aware of that workaround, but I'd rather the test framework deal with this, rather than changing the logic in my actual code

@CarsonRedeye But why would you then use anyOrNull() when you could just use any()? You have a nonnull parameter in your function, so it would make no sense IMO to use anyOrNull(). As your method contract says that paramshould not be null.

Because I want to be able to write a generic test that accepts any or null, no matter what the parameter. It just want to be able to write anyOrNull() for every parameter when stubbing, without having to continually match it to the actual implementation. It's more of an annoyance that you might think.


question on interpretation of results

Hi，
I note there is CVcorrelation and CVcorrelation p values in the results. I have read the meaning of CVcorrelation p in the documentation. However, the meaning of CVcorrelation p is not well explained. Dose it mean the correlation between the VLSM map and behavior? And a larger value refer to a strong relationship?

It goes basically like this:
The model finds a set of voxel weights that together maximize the relationship with behavior. This is done only on one part of the data, by default 75%. Then it applies the weights on the remaining 25% of the subjects and computed a predicted behavioral score (reference code is here). This is done in turn until all 100% of the subjects have a prediction. Then correlation is computed between real vs. predicted data on all subjects. This is repeated a few times to make sure the outcome is not random. The average of all repetitions is CVcorrelation.stat (code here).
CVcorrelation.pval is simply the corresponding p-value of that Pearson correlation above for a sample with N subjects (depending on your sample) (reference code here).
So, the answer to your questions is:
CVcorrelation.pval is the probability that the correlation between true and predicted behavioral scores obtained from out of sample cases is null, given the set of voxel weights you see on the map. The p-value is typically lower for stronger relationships (since it is less likely that the result is by chance), but p-values are not linear measures of relationship strength, and are not used for that purpose. The only way to use p-values is to decide when something is significant or not. If you want to comment on the strength of relationship, you can use CVcorrelation itself.
Note that LESYMAP conducts an arbitrary thresholding to eliminate voxel weights <10% of the maximal weight value, and then normalizes the outcome in 0-1 range (code here).  This seemed to work well during simulations. However, CVcorrelation is computed on the real weights which are in rawWeights.img; those weights are much smaller value and there are many more voxels with very small weights.
Hope this clears a bit the confusion.

font{
    line-height: 1.6;
}
ul,ol{
    padding-left: 20px;
    list-style-position: inside;
}

<EMAIL_ADDRESS>

---- Replied Message ----

     From

<EMAIL_ADDRESS>

     Date

    7/19/2022 12:39

     To

<EMAIL_ADDRESS>

     Cc

<EMAIL_ADDRESS>        ,

<EMAIL_ADDRESS>

     Subject

          Re: [dorianps/LESYMAP] question on interpretation of results (Issue #33)

It goes basically like this:
The model finds a set of voxel weights that together maximize the relationship with behavior. This is done only on one part of the data, by default 75%. Then it applies the weights on the remaining 25% of the subjects and computed a predicted behavioral score (reference code is here). This is done in turn until all 100% of the subjects have a prediction. Then correlation is computed between real vs. predicted data on all subjects. This is repeated a few times to make sure the outcome is not random. The average of all repetitions is CVcorrelation.stat (code here).
CVcorrelation.pval is simply the corresponding p-value of that Pearson correlation above for a sample with N subjects (depending on your sample) (reference code here).
So, the answer to your questions is:
CVcorrelation.pval is the probability that the correlation between true and predicted behavioral scores obtained from out of sample cases is null, given the set of voxel weights you see on the map. The p-value is typically lower for stronger relationships (since it is less likely that the result is by chance), but p-values are not linear measures of relationship strength, and are not used for that purpose. The only way to use p-values is to decide when something is significant or not. If you want to comment on the strength of relationship, you can use CVcorrelation itself.
Note that LESYMAP conducts an arbitrary thresholding to eliminate voxel weights <10% of the maximal weight value, and then normalizes the outcome in 0-1 range (code here).  This seemed to work well during simulations. However, CVcorrelation is computed on the real weights which are in rawWeights.img; those weights are much smaller value and there are many more voxels with very small weights.
Hope this clears a bit the confusion.
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you authored the thread.Message ID: @.***>


Added some more (mostly steam scams)

hi

i can sort all of them in alphabetical order if you want

i can sort all of them in alphabetical order if you want

That'll be great thank u

That'll be great thank u

Sure i will later

That'll be great thank u

Sure i will later

Great!


MGDOBR-895: Bump quarkus and other dependencies (#886) - Update kustomization images

This Pull request aims to update the kustomization images for the PR MGDOBR-895: Bump quarkus and other dependencies (#886)

/deploy dev

/deploy stable