Use zstd for ISO and SD images

Motivation for this change
While experimenting with sd-image builds I found out, that zstd is much superior to bzip2 when compressing SD/ISO images (95% reduction of time needed).
Because compression used to compress the distribution images is considered a public interface, I'd like to discuss this in the PR.
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[ ] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

I compressed a 2.7 GB aarch64 NixOS image with the following results:
bzip2

output size: 627353716 bytes
duration: 217 seconds

real	3m36.963s
user	3m35.370s
sys	0m1.552s

zstd -T4:

output size: 614908377 (2% decrease)
duration: 10 seconds (95% faster) :exploding_head:

real	0m10.069s
user	0m36.025s
sys	0m1.431s

It seems that zstd is even in the Debian stable, so this change is worth considering.

I think you forgot the module arg:
hydra-eval-jobs returned exit code 1:
error: "undefined variable 'zstd' at \u001b[1m/nix/store/8n8i7js5i4qzly36vpqvmvwjn3hr6z1b-source/nixos/lib/make-iso9660-image.nix\u001b[0m:51:36"
error: "undefined variable 'zstd' at \u001b[1m/nix/store/8n8i7js5i4qzly36vpqvmvwjn3hr6z1b-source/nixos/lib/make-iso9660-image.nix\u001b[0m:51:36"

@dasJ Can you please review https://github.com/NixOS/nixpkgs/pull/89883 ?

±0 for the SD image compression scheme. Hopefully no one is in a situation where using zstd is much harder than bzip.

Now, I misunderstood the change when I was reading the code, and was building in parallel. The following was written under the assumption that the isos were now default to being compressed.
This should now be read as a warning for someone that wants to change the compressImage default to true for the ISO image.
-1 for the ISO image being compressed with zstd, or compressed further at all. In fact, the only reason the SD image was compressed was because it grew to a bit over the size limits of Hydra.
Compressing the iso image needs changes at other places in the NixOS infrastructure, and documentation. I'm not sure what will happen with the mirror scripts, reading them makes me think it should end up copying the right thing.
The website would need changes.
The docs would need to be adjusted.
And, furthermore, the iso is already compressed using squashfs. Sure, it's not as compressed as this fancy currently in vogue compression, but it is compressed already. The squashfs settings maybe can be looked at to change the compression settings, though.
Note that I have no issues with zstd per se, but with needlessly compressing the iso. It is a usability annoyance, at best.

@prusnak I wonder wether 8a675956362b9873d7b771e1f86848f6aff612fe is necessary. The cost here is that this broke cross building of NixOS systems for me, as zstd currently doesn't cross compile. Also this increases closure size for every NixOS system, even if it is never needed.
I guess it is needed at runtime of the system to decrypt the install ISO/image? Couldn't we include it conditionally in
nixos/modules/installer/cd-dvd/sd-image.nix
nixos/modules/installer/cd-dvd/iso-image.nix

like
{
  environment.systemPackages = lib.optional config.isoImage.compressImage [ pkgs.zstd ];
}

?

@erictapen No strong opinion about 8a67595. If you think zstd does not belong to a base system, open a PR with a revert. The cross-compilation of zstd was fixed in https://github.com/NixOS/nixpkgs/pull/91177

Thanks for the link to the fix, missed that. I just realized that gzip, xz, bzip2 are all part of the base system, so maybe it makes sense to have zstd as well. Sorry for bothering you.


Use latest SBCK, eofs

Pull Request Checklist:

[ ] This PR addresses an already opened issue (for bug fixes / features)

This PR fixes #xyz

[ ] Tests for the changes have been added (for bug fixes / features)

[ ] (If applicable) Documentation has been added / updated (for bug fixes / features)

[x] CHANGES.rst has been updated (with summary of main changes)

[x] Link to issue (:issue:number) and pull request (:pull:number) has been added

What kind of change does this PR introduce?

Sets sbck git-based install to use their master branch at SBCK-python
Adds sbck to conda environment.yml (via git+https install)
Adds sbck and eofs as tox modifier flags for easier testing
Adds step for installing Eigen3 core library to CI build for testing sbck tox builds.
Updates installation documentation for clarity.

Does this PR introduce a breaking change?
No. The package dependencies on typical or upstream installation are unaffected.
Other information:
https://github.com/yrobink/SBCK-python/issues/1
Related? https://github.com/Ouranosinc/xclim/issues/1204

Marking approved to trigger upstream tests only.

Everything seems good. Not sure what #egg=blabla is supposed to mean though

Changes Unknown when pulling efe163d9418afb240c63d5bac67eb1ab93337c84 on use_SBCK_master into ** on master**.


Fix broken ssl wildcard redirect

Example Actual:
http://example.com  >  https://example.com  (works as it should)
http://test.example.com  >  https://*.example.com  (BROKEN)
http://api.example.com  >  https://*.example.com  (BROKEN)
http://app.example.com  >  https://*.example.com  (BROKEN)
( https://*.example.com may appear as https://%2A.example.com depending on browser)
Example Expected:
http://example.com  >  https://example.com  (works as it should)
http://test.example.com  >  https://test.example.com  (Expected)
http://api.example.com  >  https://api.example.com  (Expected)
http://app.example.com  >  https://app.example.com  (Expected)
nginx redirects to https://*.example.com/ which is a bogus url due to the $SSL_SERVER_NAME in the nginx template
Use nginx variable $host to do proper redirect

Are you sure this is still an issue in master? Ostensibly this was fixed via #1202

Im using Dokku v0.3.17
Still seems to be an issue. My use case might be special since I have one dokku instance that accepts multiple sub domain urls, so I need the wildcard ssl redirect to maintain the original url.
Even then, using nginx $host is a better solution than just dumping the domain variable from the bash script into the nginx config

As a side note, you could also provide your own template for these apps instead.
Your explanation makes sense. I'm wondering if we're breaking any assumptions or expected behaviors with this change.
@lmars @josegonzalez thoughts on this?

I'm okay with this change, makes sense to me, so long as tests pass :)

:+1:

:+1:


Switch from travis to GH actions

I was actually thinking about doing this sometime today so if its ok with you Ill update from travis to github. Will basically be what you have here but will drop the deploy and change the release to on tag.
I have looked at release-it a little, but not familiar enough with it to use it yet.
You will note the publish requires a secret. I now have the right to enter the secret, just dont know the value yet :(

@cah-briangantzler I checked "Allow edits and access to secrets by maintainers" so feel free to push to this branch.
Just a note: I was using latest Ember CLI add-on blueprint https://github.com/ember-cli/ember-cli/blob/master/blueprints/addon/files/.github/workflows/ci.yml for ci.yml

Just a note: I was using latest Ember CLI add-on blueprint https://github.com/ember-cli/ember-cli/blob/master/blueprints/addon/files/.github/workflows/ci.yml for ci.yml

yea I copied that as well for my other repo :)

If you run the tests locally, they all pass but the fastboot ones. I disabled them in my other repo with the intent of fixing them later, but here..... do they have to work?
if you do the following
cd test-projects/01-basic-app && yarn test:fastboot

it will run just the fast boot tests. I get the following
---
  message: "Promise rejected during "it includes all modules in test by default": Unexpected token '.'"
  severity: failed
  actual  : null
  expected: undefined
  stack: /Users/brian.gantzler/source-personal/ember-cli-mirage/test-projects/01-basic-app/dist/assets/vendor.js:35521
      this.forEach(item => ret.push(item[methodName]?.(...args)));
                                                     ^

SyntaxError: Unexpected token '.'
    at new Script (vm.js:88:7)
    at /Users/brian.gantzler/source-personal/ember-cli-mirage/node_modules/fastboot/src/ember-app.js:434:12
    at Array.map (<anonymous>)
    at buildScripts (/Users/brian.gantzler/source-personal/ember-cli-mirage/node_modules/fastboot/src/ember-app.js:431:36)
    at new EmberApp (/Users/brian.gantzler/source-personal/ember-cli-mirage/node_modules/fastboot/src/ember-app.js:57:20)
    at FastBoot._buildEmberApp (/Users/brian.gantzler/source-personal/ember-cli-mirage/node_modules/fastboot/src/index.js:130:17)

just curious if you get the same. The line is in ember source code.. I rolled back to a commit  7/12/21 by Sam and get the same error
Dont know fastboot at all.

@cah-briangantzler fixed FastBoot tests by adding node: current to the targets.js.
The issue you seen is that optional chaining is available in Node.js 14+ and I assume you used older version.
This PR should be good to go: we can enable GH actions and work on any failures should they occur one by one.

The weird thing was the regular tests wouldnt run under node 14. I had to switch to node 12. I think it had something to do with the addon docs needing updated.

On the deploy part, I dont see how it works, but it might be possible the deploy part is kicking off some deploy in ember-cli-addon-docs that publishes the versions docs to the docs site.


TMFS: New comments

Would be nice to have a page that lists the latest comments made on the website. I just found one from a while ago, https://themachinefolksession.org/tune/132

The admin pages give you (and only you) this.
The homepage actually used to show latest comments, but that wasn't as good as what's there now. So the code exists, if there's a sensible public place to show such a list.
So before doing anything more, what's the motivation here? Encouraging interaction from users (e.g. comment on this comment) or keeping tabs on things as moderators.

I can't find it on the admin page. The motivation is to see who has said anything about anything. I don't know if some user has left a comment on any of the 200+ tunes. The current batch of users aren't doing much anyway. :/

Ah, my mistake. Yes, the comments are in the admin pages, but I tagged them into each tune's page. I'll add them as a content-type in their own right.


[New translation] Italian Language

Pull request details

Introduced library for translating
Introduce italian language
Introduce language detector

Breaking changes
Nothing
Issues fixed

#55

Other relevant information

@leonardoarcari I kindly ask you to check if all the translations are correct in your opinion

Kind request: any chance you could add a language picker too? I'd like to have a way to switch between translations. We could store chosen locale in the app store (appSlice.js), while defaulting to browser's language if nothing's set.

Currently I used the LanguageDetector provided by the library to select language (in case of language not found set to English).
When I have time I will add this feature in this PR.

Hey @leonardoarcari, what do you think?

Thanks! Think it's good enough for the first iteration 👍 Could you please move it to the very bottom of the menu in the mobile view? Something like justify-self-end

@leonardoarcari

I use i18n.resolvedLanguage, it returns it instead of it-IT
What do you think?

@mattiapitossi thank you so much, I add you as co-author of the commit 056a239d72261ea266e64680c7682f473d10c82d

@leonardoarcari

I use i18n.resolvedLanguage, it returns it instead of it-IT
What do you think?

Good stuff! Looks good to me thanks! 💪


Bash command to clone and run

In my alias.sh script (that auto-loads through my bash profile), I've added a function called newd clones this repo, uses sed to change configuration to Drupal 7 if desired, renames the VM to something other than drupaltest.dev, and starts vagrant up. Nothing to ground breaking but I thought I would share it since I use this all of the time to spin up new sites. I also don't need to remember the exact repo name.
Such as $ newd 7 test-fieldformatter or $ newd 8 drupal8test
https://gist.github.com/rgoodie/9966f30b404a4daa59e1

@rgoodie - Nice! I might have to try the script out a couple times and offer some suggestions for improvment (especially to make sure it doesn't need modifications when certain things (like the drush make file) is changed.
I may add a link to it in the README as well, as an option for managing instances of the dev vm :)

Use as you see fit. Any suggestions welcomed.

I've added a page to the Wiki for newd specifically, but I'm planning on expanding that page to include a few other demonstration scripts and extensions to help people with a Drupal VM-based workflow.


ISPN-14869 Compactor is not closing the file iterator on expiration check and causing heap accumulation

https://issues.redhat.com/browse/ISPN-14869
Please can this be backported to 13.0.x

Failures are unrelated.

Thanks, @FireBurn! Integrated into 13.0.x. Once we have a new release, I'll ping you here.

@FireBurn, 13.0.22.Final is available.


[Runtime][Thread pool]

change yiled to condition_variable for  free CPU time slice when no other threads

@areusch

@areusch

@tkonolige can you review this?

I'm not super familiar with the threading backend, but I'll take a loot. @tqchen it would great if you could review as you are the expert on this.

Thanks @sunjiweiswift . In this case the busy waiting(spinning) is intentional. This is based on the assumption that most of the cases the job in the parallel launcher are symmetric, and the workload is so fine grianed that waiting on conditional variable would result in additional overhead. We want to ensure low overhead of small jobs and can afford to waste a bit of resources
In computation the particular CPU thread is pinned and won't be scheduled for other jobs, while there is wasted cpu cycles (to wait for other jobs to finish), it is less likely going to cause a resource contention.

@tqchen Great explanation.thank


There is no way to perform arbitrary updates on a resource that is marked for deletion

Bug Report
The Reconciler interface is used to perform reconciliation of resources, but it seems that reconcilers do not receive events about resources that are marked for deletion. The Java Operator SDK allows deletion to be controlled via the Cleaner interface, but that only allows deletion to be unblocked by telling the framework to remove the finalizer.
What I would like is to be able to attach a status condition that explains why the resource cannot be deleted. That seems to be impossible using the framework (unless there is some other mechanism that I don't know about), even though it is possible to do with the Kubernetes API and the Fabric8 client directly.
I guess I can use the Kubernetes client within the Cleaner.cleanup() method to perform this update before returning DeleteControl.noFinalizerRemoval(), but that does not allow us to benefit from the good features of the framework like automatic retries of updates.
Ideally, what I would like is to be able to configure the controller to allow reconcilers to receive events about all resources, including those that are marked for deletion.

Hi @adriansuarez

but it seems that reconcilers do not receive events about resources that are marked for deletion

This is not true for secondary resources, all events are received. Except for the primary resource, where there is the cleaner as you mentioned. Cleaner is part of the automatic retry functionality. Not sure what you mean by automatic updates, but basically the patterns says that after a resource is marked for deletion, there should be no other operations than removing the finalizer. You can still do updates however (nothing technically prevents it)

Ideally, what I would like is to be able to configure the controller to allow reconcilers to receive events about all resources, including those that are marked for deletion.

For the primary resources this is very slippery ground, since nothing guarantees that it will receive the delete event if there is no finalizer (thus Cleaner interface),since if the controller is down and not finalizer it will miss the delete event.

What I would like is to be able to attach a status condition that explains why the resource cannot be deleted. That seems to be impossible using the framework (unless there is some other mechanism that I don't know about), even though it is possible to do with the Kubernetes API and the Fabric8 client directly.

This is should be perfectly doable in the cleaner interface, with noFinalizerRemoval as you mentioned.

Thanks for the quick response, @csviri.

This is not true for secondary resources, all events are received. Except for the primary resource, where there is the cleaner as you mentioned.

To make sure that I understand your statement, are you saying that if there is an event mapper from secondary to primary that maps kind/resource B/b to A/a, and A/a is marked for deletion, then any event on B/b will cause the Cleaner.cleanup() method to be invoked on A/a?
That is the behavior I would expect, and I think am also observing that behavior in my own testing, so everything looks good.

This is should be perfectly doable in the cleaner interface, with noFinalizerRemoval as you mentioned.

I have implemented this approach successfully, so feel free to close this issue.


Update default etcdv2 to etcdv3

Since etcdv2 will officially be deprecated and current version v2.2.1 is hard to upgrade to v3 as tested many times;
Therefore, I think we may use etcdv3 as default;

According to this doc - https://github.com/kubernetes/kops/blob/af4df08b694e2a1f8814a7b3649060477be67c86/docs/etcd/roadmap.md
etc3 should become the default for Kops 1.10 but for some reason it is not the default version yet.
To avoid too much customization and make it align to the Kops upstream, I suggest we make it a recommended optional approach and make a note in the README, instread of writing it into the default spec.yml

closing due to lack of activity.


Release v0.0.8

I'm trying to duplicate this PR, and I'm landing on a merge conflict in all submodules and in config/systemconfiguration-htx-tds.yaml.  Did you see the same?

I'm trying to duplicate this PR, and I'm landing on a merge conflict in all submodules and in config/systemconfiguration-htx-tds.yaml. Did you see the same?

Yes, I had to work through those when I did the merge from master.


Removed Copyright notice from sample app

Removed Copyright notice from sample app per request.

Hi @tcunning, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!
The agreement was validated by Microsoft and real humans are currently evaluating your PR.
TTYL, MSBOT;

In CI build.


Add more defensive exceptions

We pass a lot of the "Expect failure" tests in the conformance tool, e.g:

But it's often because of null reference etc. Might be better for a library consumer if we threw more precise exceptions.

Put in a good amount of this.

Do we have many more to add or should we go ahead and close? (unable to run the testing tool for a couple of days)

I think we should go ahead and close this now. Please reopen if you deem necessary.


Fix issue #1496, #1457 and #1531

Revert some changes related to the checkboxes made some weeks ago.
Remove "--scope=machine" argument from winget install, as it blocks some applications from installing.
Add "--force" argument when reinstalling winget.

removing --scope=machine creates all sorts of other problems, we can't just remove it. For example, if you install python or any developer environment it will not put it in the right place and you will not be able to use python properly. Including pip abd other utilities. If we want to fix this properly we need to leave scope as machine by deault and have some kind of flag for installs that breaks.
Can you give me example of installs that get blocked by this scope=machine?

Also I see that you changed look up seach wildcard patterns in the code and the actual controls in inputxaml were not changed back. So you might have broken other things as well with this change. I suggest doing a more surgical Did you test import/export and -Config -run functinality with this change? It relies on Install being in the hashtable WPFInstall and Install and 2 distict code pathways

removing --scope=machine creates all sorts of other problems, we can't just remove it. For example, if you install python or any developer environment it will not put it in the right place and you will not be able to use python properly. Including pip abd other utilities. If we want to fix this properly we need to leave scope as machine by deault and have some kind of flag for installs that breaks.
Can you give me example of installs that get blocked by this scope=machine?

Issue #1494 states some of the applications that don't install with the argument.

There is a bit of work to be done here, I admit, this should have been a draft, but the main thing that I was trying to check out was the root cause of the features not installing.

There is a bit of work to be done here, I admit, this should have been a draft, but the main thing that I was trying to check out was the root cause of the features not installing.

Good job keep up the good work. What I recommend is please try to actually fix the bugs instead of reverting changes. There is other work around the module and planned work, that is in the works, that relies on these changes. Usually it is not a good idea to revert things :-) because this could blow up other features and stall work in progress. But in any case, thank you jumping in and proactively fixing issues.
PS in the nutshell Install and WPFInstall are two sections that are "work in progress" for automating installs and tweaks. WPFInstall secion just sets the Checkboxes on the UI where is Install section will allow us to install apps directly without even having to load the UI. You might argue that you don't really need "Install" section and that might be true because in theory you could lookup all of the commands from the json file but that is a lot more work. Let's finish that feature and think how to optimize it?? :) But at the moment if you nuke all these changes it will break lots of forward looking features.
PS What surprises me is those errors that people report. It must have been a bad merge because we tested it a lot and it was working fine. Chris even had a video where it was working fine on screen. I'm not sure what happened here.

Issue #1494 states some of the applications that don't install with the argument.

agreed. maybe we revert back to local installs and introduce scope variable to the json? I think though I would rather have machine scope by default, because local scope also breaks a lot of apps because winget puts all the apps int overy obscure directory and people can't find it.
C:\Users\CollinSteward\AppData\Local\Microsoft\WinGet\
I would rather have machine scope and have winget put files into c:\program files by default. btw are you sure it is the scope issue? In my branch I'm still setting scope and machine and all of these apps listed in the issue https://github.com/ChrisTitusTech/winutil/issues/1494 install just fine

Thanks for explaining all of that to me konty, I have learned a lot since I started looking at the code. Closing this PR

Thanks for explaining all of that to me konty, I have learned a lot since I started looking at the code. Closing this PR

Thank you for your enthusiasm and thank you jumping in and fixing issues. I think looking into it some more, do you want to remove scope = machine? and maybe if you have time add scope to applications.json? You can either write a macro or a little app to add scope to each node in the json?
Here is a small powershell snippet code  that you can use as a starting point to add scope to all nodes in the applications.json

# Convert JSON to PowerShell object
$jsonObject = $jsonContent | ConvertFrom-Json

# Add "scope": "local" to each node
$jsonObject | ForEach-Object {
    $_.Value.Add("scope", "local")
}

# Convert back to JSON
$jsonWithScope = $jsonObject | ConvertTo-Json -Depth 10

# Output the modified JSON
Write-Output $jsonWithScope

I may try it, but it seems like a band-aid solution

@Yuuh15 do you think a proposal to do it some other way? I'm just thinking local scope definitely breaks some apps and if machine scope breaks others being able to specify scope seems like a logical solution, no? :)

It does seem like the best way :v


pool creation - remove usdb option as base reserve

when a user wants to create a new pool, we allow an initial selection between bnt and usdb as the base token that connects the pool to the network.
please remove the option to select usdb as an option.
https://www.figma.com/file/3yED7o7TgoLwoEjV2EkRLL/Bancor-V2?node-id=1564%3A2

done, going to staging now.


Request for 3D models

I've added a section on the wiki that contains a list of 3D printable parts that are already available, or models that I have received to design.  Please take a look if you can help.  The wiki page will likely get updated as requests come in.
https://github.com/jcl5m1/ventilator/wiki/3D-Printable-Parts

I made a draft CAD model for CPAP outlet filter, feedback appreciated:
Based on this model:
https://www.cpap.com/productpage/generic-bacteria-filter-cpap-machines-10-pack
Files attached to this PR:
https://github.com/jcl5m1/ventilator/pull/44
As far as I've seen all of these parts have same "ports", that is
Male Connector End Outer Diameter: 15mm
Female Connector End Interior Diameter: 22mm
Submitted as draft because I do not have filters themselves to check the dimensions (waiting for delivery)
Also because I set wall thickness to 2.5 it will somehow affect the volume of airflow, so it might require a bit of an extra pressure to produce same throughput.
Recommend to print it with transparent PTE-G
Additionally attaching Fusion360 project in case if somebody could test and do the adjustments sooner

Great, thanks! Would anyone be able to this?
On Sun, Mar 22, 2020 at 2:03 PM RomanTheLegend<EMAIL_ADDRESS>wrote:

I made a draft CAD model for CPAP outlet filter, feedback appreciated:
Based on this model:
https://www.cpap.com/productpage/generic-bacteria-filter-cpap-machines-10-pack
Files attached to this PR:
#44 https://github.com/jcl5m1/ventilator/pull/44
As far as I've seen all of these parts have same "ports", that is
Male Connector End Outer Diameter: 15mm
Female Connector End Interior Diameter: 22mm
Submitted as draft because I do not have filters themselves to check the
dimensions (waiting for delivery)
Also because I set wall thickness to 2.5 it will somehow affect the volume
of airflow, so it might require a bit of an extra pressure to produce same
throughput.
Recommend to print it with transparent PTE-G
Additionally attaching Fusion360 project in case if somebody could test
and do the adjustments sooner
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/jcl5m1/ventilator/issues/49#issuecomment-602272675,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAM6QAVFL5VDGDLDFAYKTETRIZ4LZANCNFSM4LRBZ2VA
.

I've got the filter, reworking the model

I submitted a pull request #89 for CAD based on the filter in the link (they are now back ordered). I want to build the adapter, but I guess I am not sure what we are connecting it to? I can throw together some quick 3D printed barbed hose adapters with some basic o-rings to provide a simple 0.5 atm seal. Let me know if that is what we're looking for.

Let me check your pull request. Did you build it off the actual model or some online blueprints?
I made a CAD based on model as well, but it needs some refinement for better printability

Replied in PR comments. I'll try to push my updated design today along with source project, so we could collaborate and improve it further. Right now the biggest challenge for me is how to build filter's supporting frame without relying on Support structures during 3D printing

@jcl5m1 could you please create a new branch for CPAP ventilators project? Now that there's more than one collaborator we'll need to cooperate

I added you as a collaborator, so you should be able to push new branches
and merge to master.
On Wed, Apr 1, 2020 at 1:55 AM RomanTheLegend<EMAIL_ADDRESS>wrote:

@jcl5m1 https://github.com/jcl5m1 could you please create a new branch
for CPAP ventilators project? Now that there's more than one collaborator
we'll need to cooperate
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/jcl5m1/ventilator/issues/49#issuecomment-607123682,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAM6QAWIYTB5BQ3NZVAYFL3RKL6PTANCNFSM4LRBZ2VA
.

@RomanTheLegend That is just the CAD for an off the shelf, verifiable viral-bacterial filter for CPAP machines. (I bought some from the link in the project before they went out of stock) I added it as a reference. I am still not clear what we want to adapt that too. I was imagining that this would be on the output side of the air compressor/pump, but I don't have any CAD of the compressor/pump to create the mating coupler (which would be a 3D printed part). If there is a part number for one, I can build the coupler relatively quickly.

I made a branch for the model, please PR your CAD here:
https://github.com/jcl5m1/ventilator/tree/cpap-ventilator
You approach idea of having reference model is good and will be useful. I'm putting a quick README with guidelines and suggestions for model design & production and your CAD will be a good starting point.
Apologies for delay in replies, I'm involved with few other projects and sometimes it's hard to give proper answer in time

I created a Wiki page for the part:
https://github.com/jcl5m1/ventilator/wiki/Bacterial-Viral-Filter-for-CPAP-Machines
And pushed first working version to cpap-ventilator branch (guess should've named it cpap-ventilator-filter though)
Once design #2 - a one-piece part with embedded filter is ready I'll merge the PR into master.  BTW, @jcl5m1 for this repo do you prefer merge or rebase?

Hi, we are a team that needs your feedback to complete our idea.
Please visit our pages and comment on it.
github
gitlab


I have exactly the same issue!

Same

No way !? Three of us ? The devs must work on this bug, enough of bugs

@Romain-Jochum More than 3😬

Closing this awsome issue! Feel free to open a new one I needed !

Non vous avez corrigé vos fautes ? 😂😂


Extended configuration to allow customization of storage. #92

Thank you very much for prompt response! It really helped me!

Hi @seniorquico , I think NuGet publishing failed:
https://github.com/OrleansContrib/OrleansTestKit/actions/runs/156942581
Looks like the version number hasn't been updated. Do I need to bump it manually through a code change?

Yes, I really need to automate the version bump. The package and symbols package have been published to NuGet.


Add ProjectHub Theme

Hello I have another theme called ProjectHub that I would like to add.
This is a port from bradfrost's project-hub template https://github.com/bradfrost/project-hub

Nice. Added.


Can I transfer this item to the MCBBS forum?

MCBBS forum is one of the largest Minecraft forums in China, and I hope to post it to let more people know about this excellent integration.

As long as you credit me and keep the post up to date, I don't really see a problem with that. You may go ahead.

As long as you credit me and keep the post up to date, I don't really see a problem with that. You may go ahead.

OK!


Outlier detection healthcheck UNEJECT is confusing

Title: Outlier detection healthcheck UNEJECT is confusing
Description:
I had the following cluster configuration, where I wanted to disable consecutive_5xx completely and only enable it for consecutive_gateway_failure :
     "outlier_detection": {
       "consecutive_5xx": 100000, // this is deliberate. I wanted to turn it off completely as I don't want it to trigger on 500s
       "interval": "2s",
       "base_ejection_time": "10s",
       "max_ejection_percent": 33,
       "enforcing_consecutive_5xx": 0, // This is also supposed to turn off consecutive_5xx
       "success_rate_minimum_hosts": 2,
       "success_rate_request_volume": 20,
       "consecutive_gateway_failure": 3,
       "enforcing_consecutive_gateway_failure": 100,
       "max_ejection_time": "30s",
       "max_ejection_time_jitter": "1s"
      },

After trying to kill a instance in the cluster I would see these kind of logs in the outlier detection logs
{
   action: EJECT
   cluster_name: bounty
   eject_consecutive_event: {
   }
   enforced: true
   num_ejections: 1
   timestamp: 2024-07-08T18:00:50.740Z
   type: CONSECUTIVE_GATEWAY_FAILURE
   upstream_url: <IP_ADDRESS>:24467
}

{
   action: UNEJECT
   cluster_name: bounty
   enforced: false
   num_ejections: 1
   secs_since_last_action: 7
   timestamp: 2024-07-08T18:00:58.521Z
   type: CONSECUTIVE_5XX
   upstream_url: <IP_ADDRESS>:24467
}

{
   action: EJECT
   cluster_name: bounty
   eject_consecutive_event: {
   }
   enforced: true
   num_ejections: 2
   secs_since_last_action: 0
   timestamp: 2024-07-08T18:00:58.536Z
   type: CONSECUTIVE_GATEWAY_FAILURE
   upstream_url: <IP_ADDRESS>:24467
}

The UNEJECT coming from type CONSECUTIVE_5XX was very confusing as:

EJECT was triggered by Gateway failure and not 500
It unejected from CONSECUTIVE_5XX even though the config is set to a very high threshold and enforcing_consecutive_5xx is set to 0.
The log line also had enforced: false which should have meant it didn't action but in fact it actually did UNEJECT. The documentation is also confusing as it states to only be relevant for action eject, but is logged for uneject also  If action is eject, specifies if the ejection was enforced. true means the host was ejected. false means the event was logged but the host was not actually ejected.

It took me a while to figure out why was this happening and that in fact this was because I had my healthcheck configuration set with unhealthy_threshold: 2 and it was the healthcheck(even if first failed, cluster was still considered healthy) that was triggering the UNEJECT and not the CONSECUTIVE_5XX. I managed to get my desired configuration by setting successful_active_health_check_uneject_host to false. It would probably have helped if the section about health checking in the docs were under ejection algorithm and not under gRPC (proposing that change under #35185)
Expected Behaviour
Can the logging be changed so that UNEJECT events triggered by an active health check are of type HEALTH_CHECK instead of defaulting to CONSECUTIVE_5XX?
Relevant Links:
https://www.envoyproxy.io/docs/envoy/latest/intro/arch_overview/upstream/outlier#ejection-algorithm
https://www.envoyproxy.io/docs/envoy/latest/api-v3/data/cluster/v3/outlier_detection_event.proto#data-cluster-v3-outlierdetectionevent

I agree that this is confusing, but unfortunately it is a "feature" of the current implementation. The same type of event is used for EJECT and UNEJECT and some fields are completely not necessary for UNEJECT, one of them is ejection type. When UNEJECT event is sent, type is left with default value and because it is enum, it is interpreted as CONSECUTIVE_5XX.
The second problem is that internally, outlier detection does not store info about which type caused ejection.

I think it still needs to be addressed

․

keep it


application.properties config used even if different file specified

Hi,
I noticed that when I run our Spring Boot application with command line argument to change the application.properties to be used (e. g. out of eclipse), Spring Kafka anyhow fetches Kafka properties from default application.properties.
--spring.config.location=classpath:application-dev.properties
This is unwanted behaviour from my perspective, I do not want to have the default application.properties to be parsed at all if above program argument is used.
I don't know if I am right with that here, or if its more a Spring Boot related issue. However for Kafka I managed to reproduce the issue only.
2.0.0.RC1

Any chance to have that Spring Boot application to play from our side?
Although I can't imagine what may be wrong here in Spring Kafka. That is indeed something related to Boot or your application finally.

Spring Kafka has no knowledge that it is running in a boot application.
Also, please note that 2.0.0.RELEASE is now available.

Hi together,
thanks for the hint. Turns out I got the spring.config.location property wrong. It is a merge rather than a replacement for application.properties. Opened up a thread in Spring Boot project to ask for clarification :)
This one here can be closed I guess.

Thanks for the update.


Update to context. Update Terratest to Golang modules. Allow TF 0.13

what

Update to context.tf
Update Terratest to Golang modules
Allow TF 0.13
Add Security Group ingress for CIDR blocks

why

Standardization and interoperability
Keep the module up to date

related

Closes #42
Closes #45
Closes #46
Closes #48
Closes #49
Closes #54
Closes #36
Closes #44
Closes #52

/test all

/test all

/test all

/test all


ChainService has transaction concurrency of 1

This might be easy to just increase, but right now the concurrency is set to 1. We definitely will need it to be higher to support funding potentially 100s of ledger channels within a somewhat small time frame. Creating this issue to track progress... maybe warrants a discussion.

I am not sure what "concurrency is set to 1" means. Perhaps this means:

only one transaction is submitted at a time. This is necessary to avoid nonce errors. Otherwise nonce management gets tricky. Note that this restriction only applies to transaction submission. Multiple transactions can (and probably will be) mined in one block. Reference https://github.com/ethers-io/ethers.js/issues/972#issuecomment-663732420 to understand the reasons for synchronous transaction submission.
Or maybe you mean something else by concurrency of 1?


[QUESTION] How to pass userId meta in decorator or guard?

Hi!
I want to append userId meta for logs.
Auth is realized via decorator
https://docs.nestjs.com/custom-decorators#passing-data
https://github.com/iamolegga/nestjs-pino#assign-extra-fields-for-future-calls
Assign works just fine in scope of controller, but how to assign meta info in decorator or guard?
I simple cannot access logger instance from controller in decorator.
PinoLogger.root.setBindings does not work there also.
I think docs lack of that info, that is most popular usage of logs meta i think.
Existing example does not represent real usage, nobody will assign userId meta in each controller, agree?
I managed to pass userId meta in customProps of pinoHttp from request but i managed to get userId only in complete request message, all messages between request and response do not have that meta.
Thank you!

I didn't get the question. Are you going to use the logger as a transport for userId between layers?

no.
I have controller that looks like this (simplified versions)
import { PinoLogger } from 'nestjs-pino';
import Auth from "./common/decorators/auth.decorator";

export class AppController {
  constructor(private logger: PinoLogger) {}

  @Get()
  async getHealthcheck(@Auth() user) {
    this.logger.info('test_from_controller');
    return {
      ok: true
    }
  }
}

and i have decorator that looks like this
import {
  createParamDecorator,
  ExecutionContext,
} from '@nestjs/common';

export default createParamDecorator(
  async (data: string, ctx: ExecutionContext) => {
  const user = { id: 1 };
    return user;
  },
);

i want to get test_from_controller message in logs with userId: 1 meta, but i dont want to "assign" userId in each controller method as there might be many of them, i want to assign that meta inside decorator or some another implementation where its assigned once.

Thank you!

i want to get test_from_controller message in logs with userId: 1 meta, but i dont want to "assign" userId in each controller method as there might be many of them, i want to assign that meta inside decorator or some another implementation where its assigned once.

The simplest solution is pass serializers field in config:
  serializers: {
    req: (req) => {
      // take it from session or headers or whatever where you keep it
      // just be sure that logger middleware works after your session/auth middleware
      // if it has to be done before getting access to that field
      req.userId = req.raw.session?.user.id || null,
      return req;
    },
  },

Does it help?

No response, closing


ARROW-9133: [C++] Add utf8_upper and utf8_lower

This is the initial working version, which is very slow though (>100x slower than the ascii versions). It also required libutf8proc to be present.
Please let me know if the general code style etc is ok. I'm using CRTP here, judging from the metaprogramming seen in the rest of the code base, I guess that's fine.

Yes, CRTP is certainly fine. We'll need to make utf8proc a proper toolchain library, @pitrou should be able to help you with that.

We'll need to make utf8proc a proper toolchain library, @pitrou should be able to help you with that.

I can take care of that!

It's not that slow, it was 40% of Vaex' performance (single threaded), so I think there is a bit more to be gained still. But I have added an optimization that tries ASCII conversion first. This gives it a 7x (compared to Vaex) to 10x speedup (in the benchmarks).
Before:
Utf8Lower   193873803 ns    193823124 ns            3 bytes_per_second=102.387M/s items_per_second=5.40996M/s
Utf8Upper   197154929 ns    197093083 ns            4 bytes_per_second=100.688M/s items_per_second=5.32021M/s

After:
Utf8Lower    19508443 ns     19493652 ns           36 bytes_per_second=1018.02M/s items_per_second=53.7906M/s
Utf8Upper    19846885 ns     19832066 ns           35 bytes_per_second=1000.65M/s items_per_second=52.8728M/s

There is one loose end, the growth of the string can cause a utf8 array to be promoted to a large_utf8.

I went ahead and asked https://github.com/ufal/unilib/issues/2

The major difference between unilib and utf8proc in uppercasing a character seems to be that  unilib looks up the uppercase value directly wheras utf8proc first gets a struct with all properties from which it extracts the uppercase value. Pre-computing the uppercase dictionary first could bring utf8proc en par with the performance.

I used valgrind/callgrind to see how where time spent:

I wanted to compare that to unilib, but all calls get inlined directly (making that not visible).
Using unilib, it's almost 3x faster now compared to utf8proc (disabling the fast ascii path, so it should be compared to the items_per_second =5M/s above):
Utf8Lower    74023038 ns     74000707 ns            9 bytes_per_second=268.173M/s items_per_second=14.1698M/s
Utf8Upper    76741459 ns     76715981 ns            9 bytes_per_second=258.681M/s items_per_second=13.6683M/s

This is about 2x faster compared to Vaex (again, ignoring the fast ascii path).
The fact that utf8proc is not inline-able (4 calls per codepoint) will explain part of the overhead already. As an experiment, I make sure the calls to unicode's encode/append are not inlined, and that brings back the performance to:
Utf8Lower   131853749 ns    131822537 ns            5 bytes_per_second=150.543M/s items_per_second=7.95445M/s
Utf8Upper   134526167 ns    134487477 ns            5 bytes_per_second=147.56M/s items_per_second=7.79683M/s

Confirming call overhead plays a role.
Also, utf8proc contains information we don't care about (such as which direction text goes), explaining probably why utf8proc is bigger (300kb vs 120kb compiled).

I don't know how important it is to get good performance on non-ASCII data. Note that the ASCII fast path could well be applied to subsets of the array.

Also crossreferenced this in https://github.com/JuliaStrings/utf8proc/issues/12 to make the utf8proc maintainers aware of what we're doing in case they are interested.

Since the Unilib developer isn't interested in changing the license I think our effort would be better invested in optimizing utf8proc

Would a lookup table in the order of 256kb (generated at runtime, not in the binary) per case mapping be acceptable for Arrow?

Let's step back a bit: why do we care about micro-optimizing this?

I want to move Vaex from using its own string functions to using Arrow. If I make all functions at least faster, I'm more than happy to scrap my own code. I don't like to see a regression by moving to using Arrow kernels.
I don't call a factor of 3x micro optimizing though :)

I think it would be more acceptable to inline the relevant utf8proc functions.

Would a lookup table in the order of 256kb (generated at runtime, not in the binary) per case mapping be acceptable for Arrow?

I would find that acceptable if the mapping is only generated if needed (thus you will have a one-off payment when using a UTF8-kernel). I would though prefer if utf8proc could implement it just like this on their side. Can you open an issue there?

I also agree with inlining the utf8proc functions until utf8proc can be patched to have better performance. I doubt that these optimizations will meaningfully impact the macroperformance of applications

@ursabot build

Added libutf8proc dependency to the ursabot builders, same could be done for the docker-compose images. The tests are failing though.

I've added my own utf encode/decode for now. With lookup tables I now get:
Utf8Lower_median    18414820 ns     18408392 ns            3 bytes_per_second=1078.04M/s items_per_second=56.9618M/s
Utf8Upper_median    17004210 ns     17003407 ns            3 bytes_per_second=1.13976G/s items_per_second=61.6686M/s

which is faster than the 'ascii' version implemented previously (that got items_per_second=53 M/s).
Benchmark results vary a lot between items_per_second=55-66M/s .
Using utf8proc's encode/decode (inlined), this goes down to 18M/s. I have to look a bit into why that is the case since they do a bit more sanity checking. Ideally, some of this goes upstream.

I just merged my changes for the ASCII kernels making those work on sliced arrays

Note that the unitests should fail, the PR isn't done, but the tests seem to run 👍

There is one loose end, the growth of the string can cause a utf8 array to be promoted to a large_utf8.

I'd like to treat in-kernel type promotions as an anti-pattern in general. If there is the possibility of overflowing the capacity of a StringArray, then it would be better to do the type promotion (if that is really what is desired) prior to choosing and invoking a kernel (so you would promote to LARGE_STRING and then use the large_utf8 kernel variant).
A better and more efficient strategy would be to break the array into pieces with Slice (based on some size heuristic, e.g. 1MB-8MB of data per slice at most) and process the smaller chunks separately. This also means that you can execute the kernel in parallel. This is the decision that will be made by the expression execution layer once that is developed (I plan to work on it after the 1.0.0  release) because it permits both parallel execution and operator pipelining.

I'd like to treat in-kernel type promotions as an anti-pattern in general.

There are upsides and downsides to it. The downside is that users of the Arrow library are exposed to the implementation details of how each kernel can grow the resulting array. I see this being quite a burden in vaex, to keep track of which kernel does what, and when to promote.
Vaex does something similar, slicing the array's in smaller chunks, but still, it would need to check the sizes, no matter how small the slices are.
Maybe it's best to keep this PR simple first (so give an error?), and discuss the behavior of string growth on the mailing list?

The downside is that users of the Arrow library are exposed to the implementation details of how each kernel can grow the resulting array.

I'm not saying that. I'm proposing instead a layered implementation approach. You will still write "utf8_lower(x)" in Python but the execution layer will decide when it's appropriate to split inputs or do type promotion. So Vaex shouldn't have to deal with these details.

Validating the utf8 string made the results slightly slower, but still much better then the initial results.
Invalid utf8 characters are now replaced by a '?', as commented in the code. The unicode \U+FFFD would be more appropriate, but can lead to string length growth (3x). I think we can discuss this separately from this PR.
Recap:
Because we cannot use unlib (license issue), and utf8proc gives worse performance (even when inlined), we now have our own utf8 encode/decode. Also, calling upper and lower case functions in utf8proc is quite slow, and is now implemented with a lookup table (also suggested in https://github.com/JuliaStrings/utf8proc/issues/12#issuecomment-645563386) for codepoints up to 0xFFFF.
Initial performance:
Utf8Lower   193873803 ns    193823124 ns            3 bytes_per_second=102.387M/s items_per_second=5.40996M/s
Utf8Upper   197154929 ns    197093083 ns            4 bytes_per_second=100.688M/s items_per_second=5.32021M/s

Current performance:
Utf8Lower           19677038 ns     19672550 ns           35 bytes_per_second=1008.76M/s items_per_second=53.3015M/s
Utf8Upper           20362432 ns     20360109 ns           34 bytes_per_second=974.698M/s items_per_second=51.5015M/s

@xhochy I see at least an undefined reference to _imp__utf8proc_toupper'` in the MinGW builds, hope that helps.

Ah, we need the UTF8PROC_STATIC definition.
Does this work?
diff --git a/cpp/cmake_modules/ThirdpartyToolchain.cmake b/cpp/cmake_modules/ThirdpartyToolchain.cmake
index 5ab29cf2c..aa2bbf0dd 100644
--- a/cpp/cmake_modules/ThirdpartyToolchain.cmake
+++ b/cpp/cmake_modules/ThirdpartyToolchain.cmake
@@ -2060,7 +2060,9 @@ macro(build_utf8proc)
   set_target_properties(utf8proc::utf8proc
                         PROPERTIES IMPORTED_LOCATION "${UTF8PROC_STATIC_LIB}"
                                    INTERFACE_INCLUDE_DIRECTORIES
-                                   "${UTF8PROC_PREFIX}/include")
+                                   "${UTF8PROC_PREFIX}/include"
+                                   INTERFACE_COMPILER_DEFINITIONS
+                                   "UTF8PROC_STATIC")

   add_dependencies(toolchain utf8proc_ep)
   add_dependencies(utf8proc::utf8proc utf8proc_ep)

The change doesn't add UTF8PROC_STATIC definition...

@kou utf8proc should only be used in a small number of compilation units, so what do you think about just using set_target_properties(... PROPERTIES COMPILE_DEFINITIONS UTF8PROC_STATIC) in those files?

I've added a workaround we already used: https://github.com/apache/arrow/pull/7449/commits/782499f8641da4a23d86125bcc812546107f2ce5
But it doesn't solve this yet.
I'm trying reproducing this on my local environment.

@kou What is the problematic CI job that shows your problem? The MinGW ones seem fine.

The R ones probably?

The R ones probably?

For these, we need to add utf8proc to rtools40 and rtools35 and add them to the linker line of the R build.

@xhochy if you're trying to add R Windows dependencies, see the discussion on https://issues.apache.org/jira/browse/ARROW-6960 for pointers

Oh, sorry.
It seems that I saw wrong CI jobs.
The link problem has been fixed by the workaround.
I'll cherry pick the workaround to https://github.com/apache/arrow/pull/7452 and merge it.
Then I'll rebase this branch.

Rebased.

@maartenbreddels let me know if I can help with anything to get this merge-ready -- I want to make the utf8proc-depending code optional so I will need to make a small refactor after this lands

@wesm I can also take this since you already have quite a bit on your plate.

Ok thanks, that's much appreciated

@pitrou many thanks for the review. I've implemented all you suggestions except:

Raising an error on invalid utf8 data (see comment)
Having a benchmark run on non-ascii codepoints (I think we want to do this separate from this PR, but important point).

Btw, I wasn't aware of existing utf8 code already in Arrow. The existing decoder based on http://bjoern.hoehrmann.de/utf-8/decoder/dfa/ was new to me. Very interesting work, but unfortunately led to a performance regression (~50->30 M/s), which I'm surprised about actually. Maybe worth comparing again when we have a benchmark with non-ascii codepoints.
@wesm I hope this is ready to go 👍

We still have 2 failures, one might need a restart (travis / no output), the other is still a linker error:
C:/rtools40/mingw32/bin/../lib/gcc/i686-w64-mingw32/8.3.0/../../../../i686-w64-mingw32/bin/ld.exe: ../windows/arrow-<IP_ADDRESS>00/lib/i386/libarrow.a(scalar_string.cc.obj):(.text+0x45df): undefined reference to `utf8proc_tolower'

The R Windows builds will fail until either utf8proc is not required by default (https://issues.apache.org/jira/browse/ARROW-9220) or until libutf8proc is added as a dependency to https://github.com/apache/arrow/blob/master/ci/scripts/PKGBUILD (@xhochy has done the necessary to get it built for Rtools in https://github.com/r-windows/rtools-packages/pull/124).

Having a benchmark run on non-ascii codepoints (I think we want to do this separate from this PR, but important point).

Yes, I think we can defer that to a separate PR.

The existing decoder based on http://bjoern.hoehrmann.de/utf-8/decoder/dfa/ was new to me. Very interesting work, but unfortunately led to a performance regression (~50->30 M/s), which I'm surprised about actually. Maybe worth comparing again when we have a benchmark with non-ascii codepoints.

Yes, too. The main point of this state-machine-based decoder is that it's branchless, and so it will perform roughly as well on non-Ascii data with unpredictable branching. On pure Ascii data, a branch-based decoder may be faster since the branches will always be predicted right.

Main point remaining is whether we raise an error on invalid UTF8 input. I see no reason not too (an Arrow string array has to be valid UTF8 as per the spec, just like a Python unicode string cannot contain characters outside of the unicode code range).

@pitrou  your size commit made the benchmark go from 52->60 M/s 👍

Yes, too. The main point of this state-machine-based decoder is that it's branchless, and so it will perform roughly as well on non-Ascii data with unpredictable branching. On pure Ascii data, a branch-based decoder may be faster since the branches will always be predicted right.

Yes, it would be interesting to see how the two methods deals with a 25/25/25/25% mix of 1-2-3 or 4 byte encoded codepoints, vs say a few % non-ascii.

I pushed a commit that raises an error on invalid UTF8. It does not seem to make the benchmarks slower.

I just concluded the same :)

@xhochy Could you help on the utf8proc issue on RTools 3.5?
See here: https://github.com/apache/arrow/pull/7449/checks?check_run_id=819772618#step:10:169
It seems that UTF8PROC_STATIC would need to be defined when building Arrow. But it's not set by Findutf8proc.cmake.
Also, libutf8proc.pc.in added in https://github.com/r-windows/rtools-packages/pull/124 doesn't set it either.

@xhochy Could you help on the utf8proc issue on RTools 3.5?
See here: https://github.com/apache/arrow/pull/7449/checks?check_run_id=819772618#step:10:169

This means there also needs to be a PKGBUILD submitted to r-windows/rtools-backports for the old toolchain.

It seems that UTF8PROC_STATIC would need to be defined when building Arrow. But it's not set by Findutf8proc.cmake.
Also, libutf8proc.pc.in added in r-windows/rtools-packages#124 doesn't set it either.

Just a reminder that nothing in the R bindings touches these new functions, so turning off utf8proc in the C++ build is also an option for now.

This means there also needs to be a PKGBUILD

Why? libutf8proc is installed.

This means there also needs to be a PKGBUILD

Why? libutf8proc is installed.

The version installed is compiled with gcc 8. RTools 35 uses gcc 4.9. Most of our deps have to be compiled for both, and this is apparently one of those. That's what https://github.com/r-windows/rtools-backports is for.

The version installed is compiled with gcc 8. RTools 35 uses gcc 4.9

What difference does it make? This is plain C.

Indeed, toolchain incompatibilities only affect C++ code

The version installed is compiled with gcc 8. RTools 35 uses gcc 4.9

What difference does it make? This is plain C.

:shrug: then I'll leave it to you to sort out as this is beyond my knowledge. In the past, undefined symbols error + only compiled for rtools-packages (gcc8) = you need to get it built with rtools-backports too. Maybe something's off with the lib that was built, IDK if anyone has verified that it works.

Phew. It worked. RTools 4.0 is still broken, but there doesn't seem to be anything we can do, except perhaps disable that job. I'm gonna merge and leave the R cleanup to someone else.

thanks @maartenbreddels!

You're welcome. Thanks all for your help. Impressed by the project, setup (CI/CMake), and people, and happy with the results:


[FEATURE REQUEST] - SHRED temporary files

Currently the user can modify the script to change between no shred (default because shred is not installed on FreeBSD by default)
Most Linux users can modify the script and uncomment the SHREDCMD line and comment out the
I would prefer to see the notes application use SHRED if it is available.
The script should be amended to test for the existence for the shred binary and setup it self to use that if available (and default back to rm if note available)

fixed with v2.3 or later


Use upstream ref if possible

When the current branch tracks an upstream branch, generate a link to
that upstream branch (or SHA) rather than using the local one, since it
may not exist upstream.
In the case that the local branch has no upstream, prompt the user for
the branch name to generate a link for.
Partly addresses https://github.com/ruanyl/vim-gh-line/issues/10.
Co-authored-by: souldzin<EMAIL_ADDRESS>

@souldzin and I worked on this last week. It's preliminary, e.g., there are no additional tests for this, hence the draft status.
The main goal was to avoid generating a 404 link in the case that the current HEAD commit doesn't exist on the remote (which, for me, is the case the majority of the time).
Some other possible approaches that might be better:

Expose this functionality via a different command, e.g., :GHPreferRemote
Add a g:gh_prefer_remote variable, default disabled, to enable this behaviour
Replace this via a g:gh_ref_command variable, which is a command/script which gets the ref to use to build the link. For example, this could be used to get the latest tag, or find the "nearest" commit that exists on the remote.

I'd really appreciate any thoughts on how to carry this forward! 🙇


Refactors in-memory storage so that there's a common type across data sets

This rejigs things so that the pair of (traceID, timestamp) is used consistently
across all data sets that grow unbounded. This should make it easier to support
purging later. For example one implementation could be to iterate
traceIdToTraceIdTimeStamps in reverse (using delegate.descendingKeySet()),
which should give the eldest trace ID and delete that. When weak references are
used elsewhere, GC should clean them up. Other mechanisms besides weak
references could be used as well.
See #1528

I suspect there is no value in a list here. I will switch and if tests
still pass, merge it as a set. Nice catch.
On 30 Jun 2017 5:10 pm, "joel-airspring"<EMAIL_ADDRESS>wrote:

@joel-airspring commented on this pull request.
I like this refactor, and will base my changes on them.
Quick question: What's the use case for this being a list:

private final SortedMultimap<Long, Pair> traceIdToTraceIdTimeStamps =

 new LinkedListSortedMultimap<>(Long::compareTo);

instead of a LinkedHashSetMultiMap?
Are you anticipating cases where you want to know that
aaaa --> [<aaaa,July4>, <aaaa,July4>, <aaaa,July5>]
as opposed to just
aaaa --> (<aaaa,July4>, <aaaa,July5>)
(Notice that the first example can and does contain duplicates because
it's a linked list.)
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/openzipkin/zipkin/pull/1636#pullrequestreview-47417599,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAD61wiVQlEOGGm-rEzMFr3tG4IJYtovks5sJQ_TgaJpZM4OHv77
.

@joel-airspring keen eye: LinkedListSortedMultimap would not have helped before or after this change

Thanks.  I only noticed it because I hit a problem with that data structure when trying to evict spans!

oops killing linkedlist broke a test :) It supported reading back raw spans (which helps show when instrumentation sent the same spans twice)

Bummer!  I had run the zipkin/zipkin tests, but not those zipkin/zipkin-junit tests that failed.  Thanks for checking.  I'll keep rolling with the existing linked list implementation.

Bummer! I had run the zipkin/zipkin tests, but not those
zipkin/zipkin-junit tests that failed. Thanks for checking. I'll keep
rolling with the existing linked list implementation.

Note: I moved the linkedlist to the primary data source (as opposed to the
index where it was in the last diff you saw)


Update how-to-contribute.md

Hey there, I have made some changes to grammar.
I hope you will like it.

[x] Have you followed the contributing guidelines?
[x] Have you explained what your changes do, and why they add value to the Guides?

Please note: we will close your PR without comment if you do not check the boxes above and provide ALL requested information.

Thanks for looking at this but "open source" is accepted usage. In the future if you're unsure about how to contribute, please consider opening an issue to discuss your proposed changes before doing the work!

Thanks for looking at this but "open source" is accepted usage. In the future if you're unsure about how to contribute, please consider opening an issue to discuss your proposed changes before doing the work!


deploy to heroku

I'm new to webpack and babel. I'm trying to deploy this to heroku, but i think i need to change something first. Does anyone know of step by step instructions for deploying an app built on react-hot-boilerplate?

@yonahforst you can go through following blog and repository for heroku deployment
Blog Link
Github repo

I'm not sure hot-module replacement is working correctly with that repo.
If you clone it, build it (be sure to switch the build to the dev webpack), then start the server and try changing CSS, nothing happens.

Alright, just got this working. Here is what you need to do:
Step 1. Procfile
Heroku uses a Procfile to run commands to start your server. Add a file named Procfile to your project's root directory.  Put this line in it web: node server.prod.js.  Save it.  That tells Heroku to run the command node server.prod.js.  You don't have a server.prod.js file yet, so let's make that.
Step 2. server.prod.js
Create a server.prod.js file in your root directory.  You already have a server.js from this repo.  Your server.js file has a bunch of react hot reloading stuff in it, great for dev, bad for prod.
In your server.prod.js file, paste this:
var express = require('express');
var app = express();

app.set('port', (process.env.PORT || 5000));

app.use(express.static(__dirname + '/public'));

// views is directory for all template files
app.get('/', function(request, response) {
  response.sendFile(__dirname + '/index.html');
});

app.listen(app.get('port'), function() {
  console.log('Node app is running on port', app.get('port'));
});

It uses express to serve your index.html file.
Step 3. Run npm install express --save
You use Express to serve your index file, so you need to install express and save it.  By the way, Heroku runs npm install when you push.
Step 4. Move /dist/bundle.js into /public/bundle.js
Make a folder in your root directory called "public". Copy your bundle.js file there.
Step 5. Update your webpack.config.js
Change publicPath: '/dist/ to publicPath: /public/. Otherwise you'll get weird errors that modules can't be found when you try to use your server.prod.js`.
Step 6. Update index.html
Have its bundle.js served from /bundle.js. It was being served from /dist/bundle.js which is going to 404 in production.  /bundle.js works since your express app set /public/ as its static asset folder, so any route that doesn't match something is going to be checked in public/ for a match.
Step 7. deploy
Push your app to heroku.
Note: I'm still editing this to work well with development, but at the very least this will get you deployed to prod without totally f*ing your setup. You're just adding a procfile, a server you use for heroku, and placing your files in a place where that server will get them.

@donpinkus want to make a PR and add something like Deploy_to_Heroku.md?

I think create-react-app better serves this purpose, they have extensive guides on building/deploying.


Instructions should mention that you need "sass-rails"

With:
group :assets do
  gem 'compass-rails'
end

I get:
> bundle exec compass init
NoMethodError on line ["15"] of /Users/tyson/.rbenv/versions/1.9.3-p0/lib/ruby/gems/1.9.1/gems/compass-rails-1.0.0.rc.1/lib/compass-rails.rb: undefined method `application' for Rails:Module
Run with --trace to see the full backtrace

But with:
group :assets do
  gem 'sass-rails',    :git => 'git://github.com/rails/sass-rails.git'
  gem 'compass-rails'
end

it works
This is on the latest rails HEAD.

thanks ill get this documented i really that i couldn't directly depend on sass-rails because of rails 2.3 support

Doesn't seem you need this for rails 3.0. Just 3.1 I believe.

I myself hit this today.


Close tag is adding extra characters when using </

Example when using </
p>

I am sometimes experiencing this as well. For a while everything works, then all of a sudden i start getting double closures like Blah Blah Blahp>

I am seeing the same issue above. I installed the tag package on the latest ATOM and I see the same issue reported above. Extra characters are being inserted.

same here
ul>ul>ul>

Same here.

Apparently it's to do with the addon being activated more than once - see advice here: https://github.com/mrhanlon/less-than-slash/issues/47

cooking up a PR real soon

Thanks @MarcoThePoro, looking forward to the PR.

See https://github.com/uzyn/tag/pull/28 😄

Thank you @MarcoThePoro
This issue is fixed now, please update Tag package.

This issue is still present in 0.5.0, has been around for many moons now, probably always.
If I open the same file in multiple tabs, every tab instance will trigger an autocomplete when I write in any of the windows as usual. It also seems that after I close one of the tabs, the plugin from that tab will remain active (i.e. not unloaded) and will also perform autocomplete.


Add Maya Protocol support

Description
Maya Protocol is a fork of THORChain. It shares the same code, along with some new features. Maya Protocol will also integrate new chains, such as Dash, Kujira, Cardano and more. Maya Protocol has 2 coins: $CACAO, which is similar to THORChain's $RUNE, and $MAYA, a coin that captures 10% of the protocol's fees. https://docs.mayaprotocol.com/readme-1/introduction

Name: Maya Protocol

HD Derivation Scheme: m/44'/931'/0'/0

Symbol: $CACAO & $MAYA

Documentation: Fork of THORChain, so it works the same.

Reason:
Checklist

[ ] Finish check list here.
[ ] Coin Definition:
[ ] Add the coin definition to registry.json.
[ ] Execute codegen/bin/newcoin .
[ ] Execute tools/generate-files.
[ ] Add coin dispatcher to src/Coin.cpp.
[ ] Create tests in tests/Xxx/TWCoinTypeTests.cpp.
[ ] Implement functionality in C++. Put it in a subfolder of src/.
[ ] Entry.
[ ] Address.
[ ] Transaction (if necessary).
[ ] Signer.
[ ] Write unit tests. Put them in a subfolder of tests/.
[ ] Mnemonic phrase - > Address derivation test. Put this test in the CoinTests.cpp file.
[ ] Transaction signing tests, at least one mainnet transaction test.
[ ] Add stake, unstake, get rewards tests if the blockchain is PoS like.
[ ] Add relevant constants in TWEthereumChainID, TWCurve, etc., as necessary.
[ ] Implement C interface in src/interface.
[ ] Add tests for TWAnyAddress and TWAnySigner
[ ] Validate generated code in Android an iOS projects. Write integration tests for each.
[ ] Extend central derivation and validation tests: make sure the following tests are extended with the new coin: CoinAddressDerivationTests.cpp and CoinAddressValidationTests.cpp, TWHRPTests.cpp, CoinAddressDerivationTests.kt, CoinAddressDerivationTests.swift.
[ ] Upload coin icon to trustwallet/assets if necessary.

Hello, this is not planned for now - closing


Casper 3 puts { post.custom_excerpt} in the page. Ghost doesn't render that content in the RSS feed or amp template.

Issue Summary
The new Casper theme puts the {post.custom_excerpt} in the post template. The amp.hbs and the rss feed don't. Customizing amp.hbs was easy, but since there is no rss.hbs with the default template, it's not easy to fix that.
To Reproduce
This was introduced with Casper 3.0.It may be a Casper bug or an unwanted use of {post.custom_excerpt}. But at the moment these 2 are conflicting.
Technical details:

Ghost Version: 3
Casper Version: 3

Hi @jessehouwing :wave: Can't really follow what are you referring to by {post.exerpt} here. There is no direct output of {post.excerpt} anywhere in the Casper theme, post.hbs template only outputs {{custom_excerpt}} if anything related to excerpts :) Are you running on a customized version of Casper? Please provide some more details on how to reproduce the problem you are seeing.

You're totally right. Composed this item on my phone.

Ok. In this case, I think it's not a bug but rather intentional behavior of Ghost and how it outputs AMP and RSS information. Would suggest opening a topic on the forum for feature changes like this :wink: Happy Holidays!

I think it was an intentional decision, until ghost 3 came about. Now it feels like an unintentional oversight or bug.

Cross referencing: https://github.com/TryGhost/Casper/issues/645


feature: support for loading sub-folder from repo (like rtp in plug.vim)

Did you check the docs?

[X] I have read all the lazy docs

Is your feature request related to a problem? Please describe.
I'm testing some plugins that have vim specific installation in a repo subdirectory, like https://github.com/sonph/onehalf for example . Plug has rtp option that allows pointing to subdirectory like in the onehalf readme https://github.com/sonph/onehalf#vim . It would be neat to have that here.
Describe the solution you'd like
Something similar to Plug, to do something like rtp = 'vim/' in the plugin settings.
Describe alternatives you've considered
Didn't consider any yet. Seems like a fairly simple feature to add since runtimepath is managed manually.
Additional context
No response

I just pushed a change so you can do this:
  {
    "sonph/onehalf",
    lazy = false,
    config = function(plugin)
      vim.opt.rtp:append(plugin.dir .. "/vim")
    end,
  },

Not planning on adding any other type of rtp support.

Sorry for bumping, let me know if this is the wrong place to ask this.
I tried to use that change, trying to get Unison working:
Plug: 'unisonweb/unison', { 'branch': 'trunk', 'rtp': 'editor-support/vim' }
My Lazy config:
  {
    "unisonweb/unison",
    branch = "trunk",
    ft = "u",
    config = function(plugin)
        vim.opt.rtp:append(plugin.dir .. "/editor-support/vim")
    end,
  },

In .u files I see the plugin loaded, but there are no ft changes or syntax highlighting. It's as if the plugin is loaded, but provided no functionality?
So my question is, is that the right Lua code to configure the plugin?

After appending to the rtp, add the code below:
require("lazy.core.loader").packadd(plugin.dir)

That will source the runtime, do ftdetect and source any after files

So I currently have:
  {
    "unisonweb/unison",
    branch = "trunk",
    ft = "u",
    config = function(plugin)
        vim.opt.rtp:append(plugin.dir .. "/editor-support/vim")
        require("lazy.core.loader").packadd(plugin.dir)
    end,
  },

But still the same situation, should I run some command afterwards?
(Also thank you for the quick response, and the awesome plugins!)

sorry, you need to pass the correct rtp path to packadd, not just plugin.dir

That brings me to:
  {
    "unisonweb/unison",
    branch = "trunk",
    ft = "u",
    config = function(plugin)
        vim.opt.rtp:append(plugin.dir .. "/editor-support/vim")
        require("lazy.core.loader").packadd(plugin.dir)
    end,
  },

but now the unison plugin is not loaded, according to :Lazy

That's why I don't want to support rtp...
Anyway, the problem is that you're using ft=. That normally runs ftdetect for the plugin, but since this is an rtp plugin it won'thave.
So you need to add an init() function where you do:
require("lazy.core.loader").ftdetect(plugin.dir .. "/editor-support/vim")

Sweet, thank you!
This made the whole thing work:
  {
    "unisonweb/unison",
    branch = "trunk",
    ft = "u",
    config = function(plugin)
        vim.opt.rtp:append(plugin.dir .. "/editor-support/vim")
        require("lazy.core.loader").packadd(plugin.dir .. "/editor-support/vim")
    end,
    init = function(plugin)
         require("lazy.core.loader").ftdetect(plugin.dir .. "/editor-support/vim")
    end,
  },

I had to omit the ft = "u" part. Using it, the ftdetect worked out, but syntax did not.


MSDKUI-1837: Integrate HERE Maps SDK 3.10.1

Codecov Report

Merging #83 into master will increase coverage by 0.97%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master      #83      +/-   ##
==========================================
+ Coverage   88.35%   89.33%   +0.97%
==========================================
  Files          89       59      -30
  Lines        5531     3562    -1969
==========================================
- Hits         4887     3182    -1705
+ Misses        644      380     -264

Flag
Coverage Δ

#ios
89.33% <ø> (+0.97%)
:arrow_up:

Impacted Files
Coverage Δ

MSDKUI_Demo/IconButton.swift

MSDKUI_Demo/OptionsViewController.swift

MSDKUI_Demo/ManeuversOverviewViewController.swift

MSDKUI_Demo/GuidanceDashboardViewController.swift

MSDKUI_Demo/ExtensionArray.swift

MSDKUI_Demo/RouteViewController.swift

MSDKUI_Demo/ExtensionUITableViewCell.swift

MSDKUI_Demo/ExtensionBundle.swift

MSDKUI_Demo/ExtensionNMAMapMarker.swift

...UI_Demo/GuidanceDashboardTableViewDataSource.swift

... and 20 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 18dc478...b12a2ea. Read the comment docs.


Add example for the method EditorImportPlugin.append_import_external_resource

This rescues the excellent example created by @ColinHeathman in #82162, freshly rebased and with all suggestions applied.
Quoting the original PR:

This adds a GDScript and C# example for how to successfully use append_import_external_resource.
In my experience, I was not able to get this to work without calling EditorFileSystem.update_file on both the folder and the new file.

What's the current status here? #82162 had a lot of good content, and I'd hate for its revival to go to waste.

If more intensive stress testing is required, what would that look like?


Bug: Deep Endowments with .call on fn instance

cannot assign property call, cuz its override mistake (maybe)
as seen in:

builtin stream.Stream.call
global hasOwnProperty.call

Context?


Is it possible building linux from sratch through wsl

Im just curious to see any guide how to make linux through wsl :)

See the documentation here: https://docs.microsoft.com/en-us/windows/wsl/build-custom-distro

@shoffmeister - I believe @realternate is asking about compiling Linux using WSL.  Yes that's possible, and you should be able to use any instructions you find online to accomplish this.

Here, here, here, and here are good places to start. There is no linux kernel in WSL (or rather, you already have the kernel part) so you skip those bits.


Self-Hosted workbox version

Is your proposal related to a problem?

We need to use a self-hosted version of workbox, we don't want Google to track our traffic 😄
Describe the solution you'd like

Use workbox npm packages

Hm, maybe setting importWorkboxFrom from cdn to local would fix this, at the expense of bundle size.

Yeah @heyimalex, that should do it once this one #5369 is merged, hopefully soon 😅

Setting local works but that creates the workbox files in its own directory build/workbox-v4.3.1 meaning they are not bundled or cached by the service worker itself which hurts performance.
I'm thinking workbox (and service worker) should be opted-in as a dependency and if present, should be bundled like any other module.

This should be closed by https://github.com/facebook/create-react-app/pull/9205, which will go live as part of c-r-a v4.

Thanks @jeffposnick


Lack of validation of duplicate use of removable media with INSERT protobuf command

With the latest develop code:
When using the INSERT protobuf command, rascsi allows you to insert the same removable image file into multiple devices.
This is not reproducible when using rasctl, but can be triggered by using the webapp (currently easily done with the code in https://github.com/akuker/RASCSI/pull/421 )
Can be reproduced with CD, RM, and MO devices/images alike.

$ rasctl -l
+----+-----+------+-------------------------------------
| ID | LUN | TYPE | IMAGE FILE
+----+-----+------+-------------------------------------
|  3 |   0 | SCMO | /home/pi/images/foobar1.mos
|  4 |   0 | SCMO | /home/pi/images/foobar1.mos
+----+-----+------+-------------------------------------

@uweseimet What are you thoughts here? I haven't looked at the code yet, but rascsi does effective validation when you use the ATTACH command, but seemingly not with the INSERT command.

@rdmark Like always, it would be good to have trace logs that show in more detail what's happening.

@uweseimet Here you go. Note that the repeated DEVICES_INFO command is due to the OLED monitor script polling rascsi.
Nov 07 07:10:03 rascsi3b RASCSI[552]: [2021-11-07 07:10:03.986] [trace] Received DEVICES_INFO command
Nov 07 07:10:04 rascsi3b RASCSI[552]: [2021-11-07 07:10:04.734] [trace] Received DEVICES_INFO command
Nov 07 07:10:04 rascsi3b RASCSI[552]: [2021-11-07 07:10:04.740] [info] Validating: operation=INSERT, device id=6, unit=0, type=SCCD, device params='file=Adobe_Photoshop_4.iso', vendor='', product='', revision='', block size=0
Nov 07 07:10:04 rascsi3b RASCSI[552]: [2021-11-07 07:10:04.740] [info] Executing: operation=INSERT, device id=6, unit=0, type=SCCD, device params='file=Adobe_Photoshop_4.iso', vendor='', product='', revision='', block size=0
Nov 07 07:10:04 rascsi3b RASCSI[552]: [2021-11-07 07:10:04.740] [info] Insert file 'Adobe_Photoshop_4.iso' requested into SCCD ID 6, unit 0
Nov 07 07:10:04 rascsi3b RASCSI[552]: [2021-11-07 07:10:04.769] [trace] Received SERVER_INFO command
Nov 07 07:10:04 rascsi3b RASCSI[552]: [2021-11-07 07:10:04.812] [trace] Received DEVICES_INFO command
Nov 07 07:10:04 rascsi3b RASCSI[552]: [2021-11-07 07:10:04.816] [trace] Received DEVICE_TYPES_INFO command
Nov 07 07:10:04 rascsi3b RASCSI[552]: [2021-11-07 07:10:04.821] [trace] Received DEFAULT_IMAGE_FILES_INFO command
Nov 07 07:10:04 rascsi3b RASCSI[552]: [2021-11-07 07:10:04.836] [trace] Received SERVER_INFO command
Nov 07 07:10:04 rascsi3b RASCSI[552]: [2021-11-07 07:10:04.940] [trace] Received NETWORK_INTERFACES_INFO command
Nov 07 07:10:05 rascsi3b RASCSI[552]: [2021-11-07 07:10:05.092] [trace] Received DEVICES_INFO command
Nov 07 07:10:05 rascsi3b RASCSI[552]: [2021-11-07 07:10:05.095] [trace] Received DEVICES_INFO command
Nov 07 07:10:06 rascsi3b RASCSI[552]: [2021-11-07 07:10:06.173] [trace] Received DEVICES_INFO command
Nov 07 07:10:07 rascsi3b RASCSI[552]: [2021-11-07 07:10:07.289] [trace] Received DEVICES_INFO command
Nov 07 07:10:07 rascsi3b RASCSI[552]: [2021-11-07 07:10:07.479] [trace] Received DEVICES_INFO command
Nov 07 07:10:07 rascsi3b RASCSI[552]: [2021-11-07 07:10:07.484] [info] Validating: operation=INSERT, device id=7, unit=0, type=SCCD, device params='file=Adobe_Photoshop_4.iso', vendor='', product='', revision='', block size=0
Nov 07 07:10:07 rascsi3b RASCSI[552]: [2021-11-07 07:10:07.484] [info] Executing: operation=INSERT, device id=7, unit=0, type=SCCD, device params='file=Adobe_Photoshop_4.iso', vendor='', product='', revision='', block size=0
Nov 07 07:10:07 rascsi3b RASCSI[552]: [2021-11-07 07:10:07.484] [info] Insert file 'Adobe_Photoshop_4.iso' requested into SCCD ID 7, unit 0
Nov 07 07:10:07 rascsi3b RASCSI[552]: [2021-11-07 07:10:07.506] [trace] Received SERVER_INFO command
Nov 07 07:10:07 rascsi3b RASCSI[552]: [2021-11-07 07:10:07.543] [trace] Received DEVICES_INFO command
Nov 07 07:10:07 rascsi3b RASCSI[552]: [2021-11-07 07:10:07.549] [trace] Received DEVICE_TYPES_INFO command
Nov 07 07:10:07 rascsi3b RASCSI[552]: [2021-11-07 07:10:07.557] [trace] Received DEFAULT_IMAGE_FILES_INFO command
Nov 07 07:10:07 rascsi3b RASCSI[552]: [2021-11-07 07:10:07.583] [trace] Received SERVER_INFO command
Nov 07 07:10:07 rascsi3b RASCSI[552]: [2021-11-07 07:10:07.697] [trace] Received NETWORK_INTERFACES_INFO command
Nov 07 07:10:08 rascsi3b RASCSI[552]: [2021-11-07 07:10:08.409] [trace] Received DEVICES_INFO command
Nov 07 07:10:08 rascsi3b RASCSI[552]: [2021-11-07 07:10:08.415] [trace] Received DEVICES_INFO command
Nov 07 07:10:09 rascsi3b RASCSI[552]: [2021-11-07 07:10:09.540] [trace] Received DEVICES_INFO command

@rdmark I could reproduce this issue with rasctl after providing an explicit default folder when starting rascsi (-F option) and then running these commands without getting an error:
>rasctl -i 6 -u 0 -t sccd -c a
>rasctl -i 7 -u 0 -t sccd -c a
>rasctl -i 6 -u 0 -c i -f test.hds
>rasctl -i 7 -u 0 -c i -f test.hds

The issue should be fixed with the fix_issue_422 branch and was related to checking the filename before it was expanded to the full name, including the default folder path. Can you please verify?

@uweseimet Thanks for looking into this! I can confirm that rascsi now returns an error when you do the same, but oddly enough it still allows the image to be attached, at least when I use the web app. I will try to reproduce with rasctl as well, but in the meantime:

 $ rasctl -l
+----+-----+------+-------------------------------------
| ID | LUN | TYPE | IMAGE FILE
+----+-----+------+-------------------------------------
|  5 |   0 | SCCD | /home/pi/images/Adobe_Photoshop_4.iso (READ-ONLY)
|  6 |   0 | SCCD | /home/pi/images/Adobe_Photoshop_4.iso (READ-ONLY)
+----+-----+------+-------------------------------------

@uweseimet Reproduces also with rasctl. Could you have a look?
pi@rascsi3b:~/RASCSI $ sudo rascsi -F /home/pi/images/ &
[1] 1843
pi@rascsi3b:~/RASCSI $ SCSI Target Emulator RaSCSI(*^..^*) version 21.99 --DEVELOPMENT BUILD-- (Nov  7 2021, 09:00:52)
Powered by XM6 TypeG Technology / Copyright (C) 2016-2020 GIMONS
Copyright (C) 2020-2021 Contributors to the RaSCSI project
Connect type : FULLSPEC
[2021-11-07 09:39:18.467] [info] Default image folder set to '/home/pi/images/'
[2021-11-07 09:39:18.468] [info] No images currently attached.
No images currently attached.

pi@rascsi3b:~/RASCSI $ rasctl -i 6 -u 0 -t sccd -c a
[2021-11-07 09:39:22.024] [info] Validating: operation=ATTACH, device id=6, unit=0, type=SCCD, vendor='', product='', revision='', block size=0
[2021-11-07 09:39:22.025] [info] Executing: operation=ATTACH, device id=6, unit=0, type=SCCD, vendor='', product='', revision='', block size=0
[2021-11-07 09:39:22.025] [info] Attached read-only SCCD device, ID 6, unit 0
pi@rascsi3b:~/RASCSI $ rasctl -i 7 -u 0 -t sccd -c a
[2021-11-07 09:39:27.329] [info] Validating: operation=ATTACH, device id=7, unit=0, type=SCCD, vendor='', product='', revision='', block size=0
[2021-11-07 09:39:27.329] [info] Executing: operation=ATTACH, device id=7, unit=0, type=SCCD, vendor='', product='', revision='', block size=0
[2021-11-07 09:39:27.329] [info] Attached read-only SCCD device, ID 7, unit 0
pi@rascsi3b:~/RASCSI $ rasctl -i 6 -u 0 -c i -f Adobe_Photoshop_4.iso
[2021-11-07 09:39:50.867] [info] Validating: operation=INSERT, device id=6, unit=0, type=UNDEFINED, device params='file=Adobe_Photoshop_4.iso', 'interfaces=Adobe_Photoshop_4.iso', vendor='', product='', revision='', block size=0
[2021-11-07 09:39:50.867] [info] Executing: operation=INSERT, device id=6, unit=0, type=UNDEFINED, device params='file=Adobe_Photoshop_4.iso', 'interfaces=Adobe_Photoshop_4.iso', vendor='', product='', revision='', block size=0
[2021-11-07 09:39:50.867] [info] Insert file 'Adobe_Photoshop_4.iso' requested into SCCD ID 6, unit 0
pi@rascsi3b:~/RASCSI $ rasctl -i 7 -u 0 -c i -f Adobe_Photoshop_4.iso
[2021-11-07 09:40:10.862] [info] Validating: operation=INSERT, device id=7, unit=0, type=UNDEFINED, device params='file=Adobe_Photoshop_4.iso', 'interfaces=Adobe_Photoshop_4.iso', vendor='', product='', revision='', block size=0
[2021-11-07 09:40:10.862] [info] Executing: operation=INSERT, device id=7, unit=0, type=UNDEFINED, device params='file=Adobe_Photoshop_4.iso', 'interfaces=Adobe_Photoshop_4.iso', vendor='', product='', revision='', block size=0
[2021-11-07 09:40:10.862] [info] Insert file 'Adobe_Photoshop_4.iso' requested into SCCD ID 7, unit 0
[2021-11-07 09:40:10.862] [error] Image file 'Adobe_Photoshop_4.iso' is already used by ID 6, unit 0
Error: Image file 'Adobe_Photoshop_4.iso' is already used by ID 6, unit 0
pi@rascsi3b:~/RASCSI $ rasctl -l
+----+-----+------+-------------------------------------
| ID | LUN | TYPE | IMAGE FILE
+----+-----+------+-------------------------------------
|  6 |   0 | SCCD | /home/pi/images//Adobe_Photoshop_4.iso (READ-ONLY)
|  7 |   0 | SCCD | /home/pi/images//Adobe_Photoshop_4.iso (READ-ONLY)
+----+-----+------+-------------------------------------

@rdmark Can you try again with the latest code in fix_issue_422? Looks as if I cannot prevent some code duplication ...

@uweseimet This did the trick, thanks! Let me merge that code and close this ticket out.

@rdmark PR is available. Maybe you can also have a look at my other PR (for the develop branch).

@rdmark I re-created the PR, because I created the bugfix branch against develop instead of the bugfix branch. After merging everything into develop I will cherry-pick the actual bugfix into the bugfix branch.

PR reviewed & merged. Closing this ticket.

@rdmark This ticket is still open?

@uweseimet Closing it for real now ;)


[API] Building a News App API with Django REST framework and Deploying it to Heroku

Proposed title of article
Building a News App API with Django REST framework and Deploying it to Heroku
Proposed article introduction
Django REST framework is a flexible and powerful library for building web APIs which allow applications to communicate with each other. It is built on top of the Django framework, a Python web development framework. Heroku is a platform as a service (PaaS) that enables developers to build, run, and operate applications entirely in the cloud. It is used for deploying apps to production.
In this tutorial, we will learn how to build a news app API using the Django REST framework and then how to deploy it to production on Heroku.
Key takeaways
At the end of this tutorial, the reader should be able to:

Understand APIs and their use.
Understand CRUD features.
Learn how to set up and run Django REST framework.
Learn how to deploy Django apps on Heroku

Article quality
This article covers more in-depth content by providing handy tips for developing a web API using the Django REST framework to production on Heroku.
References
N/A

Hi @norah254
We tend to stray away or tend not to publish reviews/comparisons of commercial product offerings such as heroku


"FITS File" taxonomy term missing external URI

I just spun up an isle-dc, added an image, and got an error message:
Error generating event: Could not locate derivative term with urihttps://projects.iq.harvard.edu/fits
1 - there should be a space, that's in islandora module, another PR to come.
2 - the term "FITS File", exists in the Islandora Media Use vocabulary but doesn't have any external URI. Is that an ISLE thing? I'm not sure how installation / migrations happen.

Related: there's a note in the isle-dc readme that explains this https://github.com/Islandora-Devops/isle-dc/blame/development/README.md#L251 cc @dannylamb who knows more than he wants to about this

just chiming in to say that running from d4bdd9 still has this error


Remove Sepolia from relay tests

This removes Sepolia from the relay tests as only >=1.3.0 contracts are deployed there.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall first build on remove-sepolia-relay-tests at 93.697%

Totals

Change from base Build<PHONE_NUMBER>:
93.7%

Covered Lines:
6120

Relevant Lines:
6319

💛  - Coveralls


Fuzzy arrow inconsistency

Reproduced on 2.0.0-dev.3.0
void func<T>(List<T> list, int compare(T a, T b), List<T> target) {
  func(list, compare, target);
  //         ^ uses_dynamic_as_bottom

  func(list, compare, <T>[]);
  //         ^ fine

  func(list, compare, target as List<T>);
  //         ^ fine   ^ unnecessary_cast

  func(list, compare, list);
  //         ^ fine
}

Duplicate of https://github.com/dart-lang/sdk/issues/30980 .

Ha! Same code! I cleaned up my example
From mobile. Sorry for brevity and/or spelling.
On Tue, Oct 17, 2017, 09:31 Leaf Petersen<EMAIL_ADDRESS>wrote:

Duplicate of #30980 https://github.com/dart-lang/sdk/issues/30980 .
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/dart-lang/sdk/issues/31119#issuecomment-337279051,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AABCilJMbzReZi8Ep5nzA-ufoV_t9H18ks5stNZlgaJpZM4P7llw
.


Messaging Content Card Support

Description
Adds support for content cards and other proposition types for react native
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] I have signed the Adobe Open Source CLA.
[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[x] I have added tests to cover my changes.
[x] All new and existing tests passed.

Any documentation update?  Or it will be in another PR?


Clarify that path seperators are automatically translated in README.

I understand that the path separator used to formulate the path is irrelevant and autotranslated following the following call in from_local_file:
    if !isabspath(path) && basepath != ""
        path = joinpath(basepath, path)
    end
    path = abspath(path)

While this behavior is fairly common sense, I think it could be clarified in the documentation. As a noobie to Julia I spent a significant amount of time thinking that this was not the case and trying to find some kind of work around.

Sure, please feel free to edit the README and submit a PR!

Will do


Not able to configure a filter for resources of type "ECSTask"

Hi,
somehow I am not able to provide the right filter for ECSTasks.
Tried many ways to write the filter:
accounts:
  "000011112222":
    filters:
       ECSTask:
          - "[ClusterARN: \"arn:aws:ecs:us-east-1:...\", TaskARN: \"arn:aws:ecs:us-east-1:.../75e3fdd99daf49cf9d3fd3ba5c9ea341\"]"
          - "75e3fdd99daf49cf9d3fd3ba5c9ea341"
          - "arn:aws:ecs:us-east-1:../75e3fdd99daf49cf9d3fd3ba5c9ea341"

However, the result is always the same:
us-east-1 - ECSTask - [ClusterARN: "arn:aws:ecs:us-east-1:...", TaskARN: "arn:aws:ecs:us-east-1:.../75e3fdd99daf49cf9d3fd3ba5c9ea341"] - would remove
What would be a proper way of filtering ECSTasks?

Assuming the output is 100% correct, it looks like there is no String() output, so your items 75e3fdd99daf49cf9d3fd3ba5c9ea341 and arn:aws:ecs:us-east-1:../75e3fdd99daf49cf9d3fd3ba5c9ea341 will never match, therefore you have to use properties.
The reason they won't match is because - "75e3fdd99daf49cf9d3fd3ba5c9ea341" is an Exact match against the String() output of the resource.
accounts:
  "000011112222":
    filters:
       ECSTask:
          - property: ClusterARN
            type: equal
            value: arn:aws:ecs:us-east-1:../75e3fdd99daf49cf9d3fd3ba5c9ea341

OR you can use a different type like glob
accounts:
  "000011112222":
    filters:
       ECSTask:
          - property: ClusterARN
            type: glob
            value: *75e3fdd99daf49cf9d3fd3ba5c9ea341*

Thanks @ekristen for your reply. Was not aware of this formulation using properties.


setPlaybackSpeed Issue

 _controller.setPlaybackSpeed(items[index]).then((_) {                                 print("Playback speed set to ${items[index]}");                               });
                          it's not working, items are     List<double> items = [0.5, 1.0, 1.5, 2.0, 2.5, 3.0];

Fix. Please try new version 2.3.6


PyCon Proposal Scrapper

Description
Simple scrapper to scrape PyCon 2020 proposal.
Fixes #7
Type of change

[x] New feature (non-breaking change which adds functionality)

Checklist:

[x] I have named my files and folder, according to this project's guidelines.
[x] My code follows the style guidelines of this project.
[x] My Pull Request has a descriptive title. (not a vague title like Update index.md)
[x] I have commented on my code, particularly in hard-to-understand areas.
[x] I have created a helpful and easy to understand README.md, according to the given README_TEMPLATE.
[x] I have included a requirements.txt file (if external libraries are required.)
[x] My changes do not produce any warnings.
[x] I have added a working sample/screenshot of the script.

@all-contributors please add @chavarera  for review, docs and project management


Some CSS styles aren't applied

Here is a reduced test case:
http://codepen.io/Pauan/pen/c08297ea1143b11bdddf419a7b32ab3c
The width, height, and backgroundColor properties are all applied, however the border and borderRadius properties are not.

These didn't have a shorthand version associated with them in src/util/styleAccessor.js.
I have a fix for this, but need to update the tests.

Actually to be more correct, it's not a problem with shorthand, but a problem with the way Inferno detects CSS Style names in the document. In any case, will have a fix tonight.

@Pauan:
This should be working now: http://codepen.io/anon/pen/dGKXLJ

@tejacques Great, thanks!


Add changelog for v1.3.5 release

Signed-off-by: Waleed Malik<EMAIL_ADDRESS>
What type of PR is this?

/kind documentation
What this PR does / why we need it:
Add changelog for v1.3.5 release.
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?:

NONE

/cherrypick release/v1.4


Content duplication

I found in this page the topic 'VM size' has been described twice. also, the topics 'Quotas' and 'VM limits' seem similar.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: ae844bb3-d0eb-4b74-b06f-bb405cf6b910
Version Independent ID: 6187bbaf-e595-73cc-e2b2-7643d7a4d6e6
Content: Overview of Linux VMs in Azure - Azure Linux Virtual Machines
Content Source: articles/virtual-machines/linux/overview.md
Service: virtual-machines-linux
GitHub Login: @cynthn
Microsoft Alias: cynthn

Thanks for the feedback! I have assigned the issue to the content author to investigate further and update the document as appropriate.

Thanks for pointing this out for us.  We have updated the document and it is live now.  #please-close


Remove "related issues" feature

See https://blog.github.com/changelog/2018-11-05-related-issues/

Yes, we should remove our feature for this. PR welcome.
Here's how it should be done: https://github.com/sindresorhus/refined-github/commit/ba34c09eaac05d54d5ff837edd4fbf504378a9a3

Its still in beta @sindresorhus  can we leave it until it leaves beta?

I think it’s fine to just remove it now. I tried the feature, and even though it’s marked as beta, it feels pretty polished.

It looks to me like GitHub actually removed this feature.

@revolter, it has definitely been removed 😢 (via github staff on the support community site). It was recommended that we open feature request support tickets if we'd like to see it come back.

@revolter, it has definitely been removed 😢 (via github staff on the support community site). It was recommended that we open feature request support tickets if we'd like to see it come back.


BZ-1203696: clear separation between Roles and Groups

http://github.com/uberfire/uberfire/commit/804042269