Travis CI fails tests that require ffmpeg/libavconv

Travis CI's run of  ./devscripts/run_tests.sh fails for tests that require ffmpeg or avconv.
This is a problem, since we don't need more false negatives in CI tests.
For instance, #12364 added test_NBC_4 which just appeared to outright fail in https://travis-ci.org/rg3/youtube-dl/jobs/207841764:
test_NBC_4 (test.test_download.TestDownload) ... ERROR
and it's a little annoying to actually see why, because the error results are after the the 10,000 line limit, so downloading the log is required, but:
======================================================================
ERROR: test_NBC_4 (test.test_download.TestDownload)
----------------------------------------------------------------------
...
[NBC] 3477499: Downloading webpage
[NBC] 3477499: Downloading webpage
[ThePlatform] 3477499: Downloading SMIL data
[ThePlatform] 3477499: Downloading m3u8 information
[ThePlatform] 3477499: Downloading JSON metadata
[info] Writing video description metadata as JSON to: test_NBC_4_3477499.info.json
[debug] Invoking downloader on u'https://nbcmpx-vh.akamaihd.net/i/video/210/775/170228_3477499_SNL_Host_Octavia_Spencer_Finds_Studio_8H_mpx_,1696,1296,896,696,496,306,150,240,64,.mp4.csmil/index_0_av.m3u8?null=0&id=AgA0Lbl1QZ4vXfy2u1iPKxJobgnYEPJ8Zf2nNgnnTbfTccfd1jxvJUrmfsMusy17rO8dw5jcRO2lhw%3d%3d&hdntl=exp=1488783484~acl=%2fi%2fvideo%2f210%2f775%2f170228_3477499_SNL_Host_Octavia_Spencer_Finds_Studio_8H_mpx_*~data=hdntl~hmac=245d3f10800160dd0af94c6fcf17dd311cf3115c24154e866b6acf7ca5b894ca'
[download] Destination: test_NBC_4_3477499.mp4
ERROR: m3u8 download detected but ffmpeg or avconv could not be found. Please install one.

I don't know what all the reasons are or why ffmpeg isn't or can't be in the Travis container. But if it can't be, at least those tests should be marked SKIPPED or something instead of ERROR.
Thanks.

Current practice is marking those tests as skipped.

But if it can't be, at least those tests should be marked SKIPPED or something instead of ERROR.

The reason is simple: we are lacking developers. I've once spent some time on fixing those issues and soon found that fixing them took too much time and real issues were kept untouched. (When I fixed them all and wait some days, there would be such errors in other tests. I don't know why...)
Now, as the native HLS downloader works fine, I think it's time to enable HLS tests.

I'm not quite sure I follow…I understand there aren't the development resources to go and fix all the broken tests. But the test system should be set up so that new pull requests that add tests  from contributors who follow the instructions don't generate false CI negatives. It doesn't seem like fixing the test harness to report SKIPPED here takes much development resource. (Although I think it would take more effort for you to critique a pull request if I did it than to just do it yourself.)

Now, as the native HLS downloader works fine, I think it's time to enable HLS tests.

OK, maybe the above is irrelevant if it's about to change.

But the test system should be set up so that new pull requests that add tests from contributors who follow the instructions don't generate false CI negatives

I guess #8496 is related to what you're referring to

I guess #8496 is related to what you're referring to

Not really. I mean if I add a test (following the instructions in CONTRIBUTING.md) and it passes when I run it locally, it should not then fail when Travis runs it, unless I have done something wrong.
As far as I can tell, I didn't do anything wrong — I followed the instructions for adding the test, but it turns out some kinds of tests always fail when Travis runs them (m3u8 downloads). So either the instructions are wrong (e.g. I should not have added an m3u8 test. Or I should have marked it with skip_download but that seems wrong), or the Travis installation is broken (i.e. it should have ffmpeg, or it should know to skip m3u8 downloads without reporting them as ERROR).
#8496 is really about detecting commits which cause regressions -- which cause existing tests to fail.
But my concern is that I shouldn't be adding tests that I know are going to fail.

Oh I guess I got you. #12362 is the key change. Before that patch, ffmpeg downloads won't stop until finished, so they often go beyond the control and block other tests. After that testing with ffmpeg is possible. A problem is that it's difficult to install ffmpeg on Travis CI. Both Precise (Ubuntu 12.04) and Trusty (Ubuntu 14.04) provide libav but not ffmpeg, while the former has lots of bugs. (https://github.com/rg3/youtube-dl/issues/8622#issuecomment-186667524)

Now, as the native HLS downloader works fine, I think it's time to enable HLS tests.

I forgot to say some new tests already uses the native downloader (by specifying entry_protocol='m3u8_native' in _extract_m3u8_formats). The question is whether it should be the default or not. To sum up, there are two ways:

Use the native downloader
Mark tests relying on ffmpeg with 'skip_download': True if the native downloader can't handle it

IMO updating docs is enough. For me it's not a good idea to silently skip tests that should be handled correctly.

Thanks.

To sum up, there are two ways:

Use the native downloader
Mark tests relying on ffmpeg with 'skip_download': True if the native downloader can't handle it

This still leaves me a bit confused. Let's take the case of test_NBC_4: I don't think I should be adding entry_protocol='m3u8_native' to the test spec, because then the test won't accurately reflect what users are likely to do. Sure, it probably won't break anything, but that's not the standard: it won't be testing the IE the way it normally operates.
And I definitely shouldn't mark the test skip_download, because the test works fine when I run it locally, and there's real value in tests being usable to developers working on code, even if they don't work for Travis. Unless there is some easy way for developers to run local tests ignoring skip_download (obviously we could edit the test parameters...). I thought the purpose of skip_download was for tests where the metadata was the purpose of the test.
It seems to me there should be a parameter to the test harness to tell is to skip tests that it is not capable of running, and that should be enabled for m3u8 tests in today's world when run from Travis. Now, if in the near future this isn't going to be an issue because either Travis will have ffmpeg and the 10k limit works, or because the native downloader will be enabled,  or for some other reason, then it's not worth the effort to add such a skip-m3u8-tests-hack.
Sounds like the native downloaded is coming soon enough. But if we're still here in 3 months, maybe we should revisit this.

I may be inaccurate. I mean specifying the native downloader in the extractor, not in tests.

Unless there is some easy way for developers to run local tests ignoring skip_download

Another good point. We need it. Ignoring 'skip' is also necessary.
By the way, I guess there won't be ffmpeg in Travis CI containers soon. Ubuntu switches back to ffmpeg since Xenial (16.04), and Travis CI doesn't have Xenial yet.

I had a similar problem when installing ffmpeg from apt-repository in Travis CI a while back. Tests using ffmpeg for conversion were failing for some reason.
However, building ffmpeg from source fixed it for me. Travis CI (for ffmpeg compiled with libmp3lame) as below:
before_install:
  - sudo apt-get -qq update
  - sudo apt-get -y install autoconf automake build-essential libass-dev libfreetype6-dev libtheora-dev libtool libva-dev libvdpau-dev libvorbis-dev libxcb1-dev libxcb-shm0-dev libxcb-xfixes0-dev pkg-config texinfo wget zlib1g-dev
  - sudo apt-get -y install yasm nasm libmp3lame-dev
  - mkdir ~/ffmpeg_sources
  - cd ~/ffmpeg_sources
  - wget http://ffmpeg.org/releases/ffmpeg-snapshot.tar.bz2
  - tar jxf ffmpeg-snapshot.tar.bz2
  - cd ffmpeg
  - PATH="$HOME/bin:$PATH" PKG_CONFIG_PATH="$HOME/ffmpeg_build/lib/pkgconfig" ./configure --prefix="$HOME/ffmpeg_build" --pkg-config-flags="--static" --extra-cflags="-I$HOME/ffmpeg_build/include" --extra-ldflags="-L$HOME/ffmpeg_build/lib" --bindir="$HOME/bin" --enable-libmp3lame
  - PATH="$HOME/bin:$PATH" make -s -j
  - make install
  - hash -r
  - cd $TRAVIS_BUILD_DIR

It takes quite a time to build though (around 10 mins) but I can confirm it is invoked correctly from the command-line and ffmpeg conversion tests were passing for me.
This might be helpful.

UPDATE:
I was just messing around and I managed to upload the compiled ffmpeg binary (compiled with libmp3lame) from Travis CI Ubuntu Precise to here.
Now one can just download this same binary on Travis CI Precise without having to build it on every run. So basically, .travis.yml can be reduced to:
before_install:
  - sudo apt-get -qq update
  - sudo apt-get -y install autoconf automake build-essential libass-dev libfreetype6-dev libtheora-dev libtool libva-dev libvdpau-dev libvorbis-dev libxcb1-dev libxcb-shm0-dev libxcb-xfixes0-dev pkg-config texinfo wget zlib1g-dev
  - sudo apt-get -y install yasm nasm libmp3lame-dev
  - mkdir $HOME/bin
  - wget https://transfer.sh/BlsO2/ffmpeg -O $HOME/bin/ffmpeg
  - chmod 755 $HOME/bin/ffmpeg
  - cd $TRAVIS_BUILD_DIR

It only takes a few seconds to download the binary and one does not need to wait for it to compile. I tried it and can confirm it works for me.
You can also build and upload your own ffmpeg binary (with custom parameters) by adding this line at the end to .travis.yml in my previous comment:
- curl --upload-file $HOME/bin/ffmpeg https://transfer.sh/ffmpeg

and checking the log for the resultant URL and replacing it with the one in the sample .travis.yml above, so you won't have to build it on every test run.


Clean up query.ex and improve coverage.

Coverage increased (+0.3%) to 95.283% when pulling 4165f1c4d9b5f3f36b8f38d85f9f400ca5319d87 on query-cleanup into 9be9afaa0bb3f945e666eb4a5990bb01e071f2cf on master.

Coverage increased (+0.3%) to 95.283% when pulling 4165f1c4d9b5f3f36b8f38d85f9f400ca5319d87 on query-cleanup into 9be9afaa0bb3f945e666eb4a5990bb01e071f2cf on master.

Coverage increased (+0.3%) to 95.283% when pulling 4165f1c4d9b5f3f36b8f38d85f9f400ca5319d87 on query-cleanup into 9be9afaa0bb3f945e666eb4a5990bb01e071f2cf on master.

Coverage increased (+0.2%) to 95.253% when pulling 2b23c5602c2af37743b22f62f1ae1da196fa1a1a on query-cleanup into 9be9afaa0bb3f945e666eb4a5990bb01e071f2cf on master.

Coverage increased (+0.2%) to 95.253% when pulling 2b23c5602c2af37743b22f62f1ae1da196fa1a1a on query-cleanup into 9be9afaa0bb3f945e666eb4a5990bb01e071f2cf on master.

Coverage increased (+0.2%) to 95.253% when pulling 2b23c5602c2af37743b22f62f1ae1da196fa1a1a on query-cleanup into 9be9afaa0bb3f945e666eb4a5990bb01e071f2cf on master.

Coverage increased (+0.2%) to 95.253% when pulling 2b23c5602c2af37743b22f62f1ae1da196fa1a1a on query-cleanup into 9be9afaa0bb3f945e666eb4a5990bb01e071f2cf on master.

Coverage increased (+0.2%) to 95.253% when pulling 2b23c5602c2af37743b22f62f1ae1da196fa1a1a on query-cleanup into 9be9afaa0bb3f945e666eb4a5990bb01e071f2cf on master.

Coverage increased (+1.2%) to 96.203% when pulling e7d2db11a550527bff32c26ef7bd503679bbc075 on query-cleanup into 9be9afaa0bb3f945e666eb4a5990bb01e071f2cf on master.

Coverage increased (+1.5%) to 96.508% when pulling d9461ce0f3d9d7b3feced676a07c80e222f839c5 on query-cleanup into 9be9afaa0bb3f945e666eb4a5990bb01e071f2cf on master.

Coverage increased (+1.5%) to 96.508% when pulling d9461ce0f3d9d7b3feced676a07c80e222f839c5 on query-cleanup into 9be9afaa0bb3f945e666eb4a5990bb01e071f2cf on master.

Coverage increased (+1.5%) to 96.508% when pulling d9461ce0f3d9d7b3feced676a07c80e222f839c5 on query-cleanup into 9be9afaa0bb3f945e666eb4a5990bb01e071f2cf on master.

Coverage increased (+1.5%) to 96.508% when pulling d9461ce0f3d9d7b3feced676a07c80e222f839c5 on query-cleanup into 9be9afaa0bb3f945e666eb4a5990bb01e071f2cf on master.

Coverage increased (+1.5%) to 96.508% when pulling d9461ce0f3d9d7b3feced676a07c80e222f839c5 on query-cleanup into 9be9afaa0bb3f945e666eb4a5990bb01e071f2cf on master.

Coverage increased (+2.1%) to 97.125% when pulling a507add84e5f16412bd9b66327219c83d1b82386 on query-cleanup into 9be9afaa0bb3f945e666eb4a5990bb01e071f2cf on master.

Coverage increased (+2.4%) to 97.436% when pulling 32eec3bbbe7bce434a9b26c22192cb1bf3fcfc17 on query-cleanup into 9be9afaa0bb3f945e666eb4a5990bb01e071f2cf on master.

Coverage increased (+2.7%) to 97.756% when pulling e1c6ed64b1d75be4454442cab9cff38e8866fbdc on query-cleanup into 9be9afaa0bb3f945e666eb4a5990bb01e071f2cf on master.

Coverage increased (+2.7%) to 97.756% when pulling e1c6ed64b1d75be4454442cab9cff38e8866fbdc on query-cleanup into 9be9afaa0bb3f945e666eb4a5990bb01e071f2cf on master.

Coverage increased (+2.7%) to 97.756% when pulling e1c6ed64b1d75be4454442cab9cff38e8866fbdc on query-cleanup into 9be9afaa0bb3f945e666eb4a5990bb01e071f2cf on master.

Coverage increased (+2.7%) to 97.756% when pulling e1c6ed64b1d75be4454442cab9cff38e8866fbdc on query-cleanup into 9be9afaa0bb3f945e666eb4a5990bb01e071f2cf on master.

Coverage increased (+2.7%) to 97.756% when pulling e1c6ed64b1d75be4454442cab9cff38e8866fbdc on query-cleanup into 9be9afaa0bb3f945e666eb4a5990bb01e071f2cf on master.

Coverage increased (+2.7%) to 97.756% when pulling 3699b392befe657936a301f16c447d60973b0499 on query-cleanup into 9be9afaa0bb3f945e666eb4a5990bb01e071f2cf on master.

Coverage increased (+2.7%) to 97.756% when pulling 3699b392befe657936a301f16c447d60973b0499 on query-cleanup into 9be9afaa0bb3f945e666eb4a5990bb01e071f2cf on master.


Update sqs transport factory with missing endpoint parameter

This is read only repository. You should open PR on https://github.com/php-enqueue/enqueue-dev


Purpose of fp16.h install

What is the purpose of the fp16.h (https://github.com/Maratyszcza/FP16/blob/master/include/fp16.h) install when it seems to only include fp16/fp16.h and (optionally) fp16/psimd.h?
It isn't in a subfolder and the user could just as easily include fp16/fp16.h themselves.
Should this actually be installed or was it only meant to be used for the benchmark/tests?
I couldn't see PSIMD_H defined anywhere so I assume it only includes it if the upstream header was already included.

FP16 can be installed as a header-only library, and several package managers in fact include it.


[BACKLOG-3960] Refactored "hasMissingPlugins" method.

@mdamour1976 Please Sir!

Performing test build now


Upd: README.md - Add Debian dependencies and easy steps. Add Fastfetch github release link

Add link to fastfetch github releases
Add link to ImageMagick prebuilt .deb from xdavius deb repository to avoid dependencies problems with debian package, and up to latest stable version.

Deleting this old PR.


Naming a model Promise breaks types for PrismaPromise

Bug description

This started happening since Prisma 4.9.0, seemingly since https://github.com/prisma/prisma/pull/17265.
How to reproduce
Clone the linked reproduction repository, generate the Prisma schema, and open index.ts in VSCode. await will not work on the findMany query and trying to call map on the expected awaited array of customers will give an error.
Expected behavior
No response
Prisma information
Reproduction repository
Environment & setup

OS: Manjaro Linux
Database: PostgreSQL
Node.js version: v16.17.0

Prisma Version
4.9.0

Same story if you have something in your schema called PromiseType, in this case an enum. In general it seems like if you're not careful, you could generate types overriding the ones required for the Prisma client types to work properly.

This is fixed and the fix will be published as a part of 5.1 release. You can also check out 5.1.0-dev.25 dev snapshot - we do not recommend using dev snapshots in production, but it should be enough to verify the fix.


Use wildfly-legacy-test 1.0.0.Alpha5

Core - Full Integration Build 504 is now running using a merge of cd5aa93d5010459627497f96400c710e21290956

Windows Build 926 is now running using a merge of cd5aa93d5010459627497f96400c710e21290956

Linux Build 1240 is now running using a merge of cd5aa93d5010459627497f96400c710e21290956

Windows Build 926 outcome was SUCCESS using a merge of cd5aa93d5010459627497f96400c710e21290956
Summary: Tests passed: 3046, ignored: 95 Build time: 0:18:45

Linux Build 1240 outcome was SUCCESS using a merge of cd5aa93d5010459627497f96400c710e21290956
Summary: Tests passed: 3046, ignored: 95 Build time: 0:19:28

Core - Full Integration Build 504 outcome was SUCCESS using a merge of cd5aa93d5010459627497f96400c710e21290956
Summary: Tests passed: 2857, ignored: 381 Build time: 0:48:34


Pull supported chains dynamically from Blockchain API

Instead of hardcoding the list of supported chains, we should pull them dynamically so that we can automatically support any chains that Blockchain API does. This will be enabled by https://github.com/WalletConnect/blockchain-api/pull/571
Use updated lib version in Notify Server and Keys Server.

Implemented in https://github.com/WalletConnect/WalletConnectRust/pull/73


istft has bug,  return [] , code as follow , lws version 1.2.8

#From https://github.com/r9y9/wavenet_vocoder/blob/master/audio.py
def inv_linear_spectrogram(linear_spectrogram, hparams):
'''Converts linear spectrogram to waveform using librosa'''
if hparams.signal_normalization:
D = _denormalize(linear_spectrogram, hparams)
else:
D = linear_spectrogram
S = _db_to_amp(D + hparams.ref_level_db) #Convert back to linear

if hparams.use_lws:
	processor = _lws_processor(hparams)
	D = processor.run_lws(S.astype(np.float64).T ** hparams.power)
	y = processor.istft(D).astype(np.float32)  #error: return void []
	return y
else:
	return _griffin_lim(S ** hparams.power, hparams)

lws init params:  nfft = 1024 ， win_hop=256, win_size =1024, mode = "speech"

Could you please elaborate?
I don't see anywhere where lws is used in the wavenet_vocoder repo.
Also, is this a new issue since the recently updated version 1.2.8, or did it exist prior to that as well?

Could you please elaborate?
I don't see anywhere where lws is used in the wavenet_vocoder repo.
Also, is this a new issue since the recently updated version 1.2.8, or did it exist prior to that as well?

sorry， I made a mistake with the repos address.
the right address is https://github.com/Rayhane-mamah/Tacotron-2/blob/ab5cb08a931fc842d3892ebeb27c8b8734ddd4b8/datasets/audio.py#L147.  And， I have fixed this bug by using version 1.2.0 of lws.

I'm still not getting a bug with 1.2.8 with the following code:
import lws # version 1.2.8
import numpy as np
nfft=1024
win_hop=256
win_size=1024
mode = "speech"
processor = lws.lws(nfft,win_hop,fftsize=win_size, mode="speech")
s = np.random.randn(2000)
S = processor.stft(s)
D = processor.run_lws(S.astype(np.float64))
y = processor.istft(D).astype(np.float32)

sorry，I can't reproduce it either, maybe there was a problem elsewhere before


DO NOT MERGE - TESTING PURPOSES ONLY

[ ] Have you followed the guidelines in our Contributing document?
[ ] Have you created a JIRA and used it in the commit message?
[ ] Have you checked to ensure there aren't other open Pull Requests for the same issue?
[ ] Have you built the project locally prior to submission with mvn clean install?

retest this please

retest this please

retest this please

Reteat this please

Retest this please


⚠ Bofrost.at has degraded performance

In f6d8ea7, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 1241 ms

Resolved: Bofrost.at performance has improved in a1a363a after 22 minutes.


Limit the number of certificates parsed in a chain

This closes a vector for denial of service.
Signed-off-by: Hayden Blauzvern<EMAIL_ADDRESS>
Summary

Ticket Link

Fixes
Release Note

Hm, something in the build broke, looks unrelated to this.

Pulling in the latest changes to sigstore/sigstore broke a few tests, because the sigstore verifiers no longer allow sha1, and alpine is using sha1.

Codecov Report

Merging #823 (4418afb) into main (18f9009) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #823   +/-   ##
=======================================
  Coverage   47.59%   47.60%
=======================================
  Files          62       62
  Lines        5503     5504    +1
=======================================
+ Hits         2619     2620    +1
  Misses       2574     2574
  Partials      310      310

Impacted Files
Coverage Δ

pkg/pki/x509/x509.go
55.42% <100.00%> (+2.08%)
:arrow_up:

pkg/types/alpine/apk.go
59.57% <100.00%> (ø)

pkg/types/alpine/v0.0.1/entry.go
53.75% <0.00%> (-1.25%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 18f9009...4418afb. Read the comment docs.


GH-45 Coinbase transaction serialization

I see a Travis CI job failed:
  1) aec_miner_tests:miner_test_/0: Remove keys while miner runs

     Failure/Error: ?assertEqual({waiting_for_keys,{state}}, sys : get_state ( aec_miner ))

       expected: {waiting_for_keys,{state}}

            got: {running,{state}}

     %% /home/travis/build/aeternity/epoch/_build/test/lib/aecore/test/aec_miner_tests.erl:106:in `aec_miner_tests:-miner_test_/0-fun-3-/0`

This is known fragile test whose fix is deferred, hence I restart job.


In Addition To, or Instead Of?

You should add a note to the Readme: is this supposed to be used in addition to normalize.css, or instead of normalize.css?
Edit to add: I figured it out, but it wasn't immediately obvious, and should be ;-)

@strider72 Which is it ? Looks like it could be whatever you want it to be. Some styles are in both. But some styles are in only one of them (both ways, ie the styles for the html tag)

Yes. This is a non-issue, though I appreciate raising issues with the language of the README.
I may need to change the wording entirely, since normalize.css has gone into development silo.

I had a hard time finding this.


L.geoJSON.AJAX is not a constructor

How do I get this plugin to work when working with npm?
I installed leaflet & leaflet-ajax with npm, and can require leaflet using 'var L = require('leaflet');
however I do not know how to properly include this leaflet-ajax extension with it.
Can anyone point me in the right direction?
Index without using beefy:
<script src="node_modules/leaflet/dist/leaflet.js"></script>     <script src="node_modules/leaflet-ajax/dist/leaflet.ajax.js"></script>
When using beefy I use  var L = require('leaflet');
Along with the accessToken this is the JS code:
var map = L.map('map').setView([52.11, 6.16], 7);

L.tileLayer('https://api.tiles.mapbox.com/v4/{id}/{z}/{x}/{y}.png?access_token={accesToken}', {
    id: 'mapbox.light',
    accesToken: mapboxAccessToken
}).addTo(map);

var geojsonLayer = new L.geoJSON.AJAX("data/townships.json");
geojsonLayer.addTo(map);`
Neither options (with or without beefy) allow me to use the L.geoJSON.AJAX()

Ok so apparently I need to use: new L.geoJson.ajax() instead of new L.geoJSON.AJAX

i have issu like thak did this work for you ?


[Feature] Add extra BIG WARNING before overwriting/deleting a Nostr key

Feature description
I want to suggest adding an additional warning before overwriting or deleting an existing Nostr key. I saw there is already a warning, but I suggest having a second warning either in ALL CAPS or something where it prompts the user to type out "delete this key forever" or something extra cumbersome.
We had one user accidentally overwrite their nostr key.
Describe the solution
Solution described above.
Describe alternatives
No response
Additional context
No response
Are you working on this?
None

Wdyt @jakubszwedo @reneaaron @im-adithya

@escapedcat instead of showing another warning, can we just prompt the user to write something like 'confirm delete' in order to make sure this is not done by accident?

@escapedcat  We do provide a warning prompt for Yes/No, maybe that prompt can have this text field for confirmation.

Oh no 😥 thanks for raising this issue @dannydeezy! I like the idea of having the user type something to confirm this action as it might be irreversible.
This is how DO does it for example:

We could use window.prompt instead of window.confirm for this use case maybe?
cc @jakubszwedo

We could use window.prompt instead of window.confirm for this use case maybe?

Yes exactly!

How about if we display the priv key and ask user to type last 6 digits for example to cofirm? This way we make they double check what they're deleting

Sounds good to me, can I work on this?

I propose following flow:
If user has no keys in Alby (same as currently):

If user has some keys in the extensions, there's additional warning:

Then whichever option they choose (derive/generate new), modal changes to this one:

They need to type 4 digits after "nsec1" to make confirmation button clickable. I think those letters are also the one which users choose to identify keys visually, at least that's what I do, but some users may use the last one.
I want to avoid stacking modal on modal, so it would be great if this modal replaces the first one (or is in-modal flow somehow).
What I also recommend here:

Make modal width 680px, so we can see whole key and the width does not change between 2 modals"
Ideally user shouldn't be able to copy the characters from this disabled input, so they have to type it manually.
Please swap buttons in the modal so the orange one is on the right if possible, like in the screenshots (currently it's on the left side)

Please review flow/copy @escapedcat @reneaaron

Looks good to me but involves quite some things that we would need to implement here. Would having a browser "prompt" window work for now as well?

That would a lot easier to implement and we could potentially ship it with the next release. (and follow up with the full version after that) What do you think?

Sure, this is easer and faster but increases security almost as much!

@ShivamJhaa Do you want to pick this up from here?

@reneaaron Yes, thank you for the clarification.


g:Lf_RootMarkers option seems not work on Windows

use below config,  LeaderF only show file in current directory, not the parent  where target.txt exist
let g:Lf_RootMarkers = ['target.txt']

You should also set let g:Lf_WorkingDirectoryMode = 'ac' or let g:Lf_WorkingDirectoryMode = 'Ac', please refer to below:
https://github.com/Yggdroot/LeaderF/blob/379fe98b1c0b327af1474c84b8de18acbdcab4ea/doc/leaderf.txt#L446-L471

Thank you for your reply!
I should have read the document more carefully. It works now


Fix incorrect note on modifiability of non-Custom templates

The non-Custom templates became modifiable in WS2019, not WS2016.

Docs Build status updates of commit 96694c5:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docset/windows/nettcpip/Set-NetTCPSetting.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Please change the target branch of the PR to master and re-open the PR to continue with the review. Thank you.


DialogBox

Hi all,
does it exist a simple DialogBox with standard buttons (OK, Cancel, Yes, No, ...) like Winform DialogBox to display a simple message?
Thanks

@maxmontgmx There are no styles or templates for such kind of dialog boxes. I might consider this for a future release.

@maxmontgmx The next release features an AlertDialog and a ConfirmationDialog control.

@spiegelp I would like to popup a confirmation dialog box in modal mode (which is blocking), not in async mode. How can I do?
Thanks for your help

        MyDialog dialog = new Dialogs.MyDialog();
        dialog.Owner = Application.Current.MainWindow;
        dialog.WindowStartupLocation = WindowStartupLocation.CenterOwner;
        dialog.ShowDialog();

@spiegelp it's not possible to use AlertDialog or ConfirmationDialog for that? Thanx


Fixed integer mismatch

Pull Request Guidelines
Pull requests are an essential collaborative tool for modern software development.
The below list is intended to help you figure out whether your code is ready to be reviewed
and merged into ArangoDB. The overarching goal is to:

Reduce the amount of recurring defects
Reduce the impact to the other developer’s time and energy spent on defects in your code
Increase the overall autonomy and productivity of individual developers

Acceptance Checklist
The below list is not exhaustive, think thoroughly whether the provided information is sufficient.
Remove options that do not apply
Scope & Purpose
(Can you describe what functional change your PR is trying to effect?)

[ ] Bug-Fix for devel-branch (i.e. no need for backports?)
[ ] Bug-Fix for a released version (did you remember to port this to all relevant release branches?)
[ ] Strictly new functionality (i.e. a new feature / new option, no need for porting)
[ ] The behavior in this PR can be (and was) manually tested (support / qa / customers can test it)
[ ] The behavior change can be verified via automatic tests

Related Information
(Please reference tickets / specification etc )

[ ] There is a GitHub Issue reported by a Community User:
[ ] There is an internal planning ticket:
[ ] There is a JIRA Ticket number (In case a customer was affected / involved):
[ ] There is a design document:

Testing & Verification
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This PR adds tests that were used to verify all changes:

[ ] Added Regression Tests (Only for bug-fixes)
[ ] Added new C++ Unit Tests (Either GoogleTest or Catch-Test)

Did you add tests for a new RestHandler subclass ?
Did you add new mocks of underlying code layers to be able to verify your functionality ?
...

[ ] Added new integration tests (i.e. in shell_server / shell_server_aql)
[ ] Added new resilience tests (only if the feature is impacted by failovers)

Additionally:

[ ] There are tests in an external testing repository (i.e. node-resilience tests, chaos tests)
[ ] I ensured this code runs with ASan / TSan or other static verification tools

(Include link to Jenkins run etc)

Think about whether the new code you added is modular enough to be
easily testable by unit tests written with GTest / Catch. It is not good if your feature is so interconnected
that it prevents other people from writing their own unit gests. It should be possible
to use your code in future without extensively mocking your classes.
A bad example that required some extensive effort would be the storage engine API.

Documentation

All new Features should be accompanied by corresponding documentation.
Bugs and features should furthermore be documented in the changelog so that
developers and users have a concise overview.

[ ] Added a Changelog Entry (referencing the corresponding public or internal issue number)
[ ] Added entry to Release Notes
[ ] Added a new section in the Manual
[ ] Added a new section in the http API
[ ] Added Swagger examples for the http API

CLA Note
Please note that for legal reasons we require you to sign the Contributor Agreement
before we can accept your pull requests.

http://jenkins01.arangodb.biz:8080/view/Windows/job/arangodb-matrix-pr-windows-onlycompile/2288/

http://jenkins.arangodb.biz:8080/view/PR/job/arangodb-matrix-pr/7772/

Jenkins is blue: http://jenkins01.arangodb.biz:8080/view/PR/job/arangodb-matrix-pr/7779/

Jenkins is blue: http://jenkins01.arangodb.biz:8080/view/PR/job/arangodb-matrix-pr/7779/


Add open graph meta data and image

#16
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Will look like this


No seal option for Washington D.C.

While D.C. isn't officially a state, it's important to include its seal.
(https://commons.wikimedia.org/wiki/File:Seal_of_Washington,_D.C..svg)

Added.

Verified.


Support even more patterns of specifying images in FluxHelmRelease

From @justinbarrick's testing of #1258:

A couple of third party charts do not follow any of these patterns:
brigade uses controller.registry and controller.name to form the image name.
stable/influxdb uses image.repo instead of image.repository.
stable/external-dns uses image.name.

These are probably fairly commonly used; even though we (presently) require people to vendor the charts, and they could therefore alter them, it's friendlier if they don't have to.
(This may be a good time to consider implementing some scheme so that people can specify the containers using some scheme, in the FluxHelmRelease.)

One pattern I see in quite a few places is
image:
  image:
  imageTag:

I don't think this is currently supported by flux.
reference: https://github.com/helm/charts/search?q=imageTag%3A&unscoped_q=imageTag%3A

Before we can turn this issue into a PR we must agree on how a user should instruct the operator to look for images at certain paths in the values value.
@stefanprodan iirc you had annotations in mind; can you elaborate on this 'design'?

I propose the following annotations:
repository.flux.weave.works/<arbitrary-name>: "path.to.image.repository"
tag.flux.weave.works/<arbitrary-name>: "path.to.image.tag"
filter.flux.weave.works/<arbitrary-name>: "glob|semver|regexp"

Here is how Jenkins could look:
kind: HelmRelease
  annotations:
    flux.weave.works/automated: "true"
    repository.flux.weave.works/master: "Master.Image"
    tag.flux.weave.works/master: "Master.ImageTag"
    filter.flux.weave.works/master: semver:~2.60
    repository.flux.weave.works/agent: "Agent.Image"
    tag.flux.weave.works/agent: "Agent.ImageTag"
    filter.flux.weave.works/agent: glob:3.27-*
spec:
  chart:
    repository: https://kubernetes-charts.storage.googleapis.com/
    name: jenkins
    version: 0.33.0
  values:
    Master:
      Image: "jenkins"
      ImageTag: "2.60.2"
    Agent:
      Image: jenkins/jnlp-slave
      ImageTag: 3.27-1

@stefanprodan How would you encode this
...
spec:
  values:
    Container:
      Image: jenkins:2.60.2

?

@squaremo if tag.flux.weave.works/<name> is not specified we'll assume the tag is inlined with the image.

We use  chart-image annotation:
kind: HelmRelease
metadata:
  annotations:
    flux.weave.works/automated: "true"
    flux.weave.works/tag.chart-image: semver:~4.0
spec:
  releaseName: redis
  chart:
    repository: https://kubernetes-charts.storage.googleapis.com/
    name: redis
    version: 5.1.3
  values:
    image:
      repository: bitnami/redis
      tag: 4.0.12

With the new format looks less confusing:
kind: HelmRelease
metadata:
  annotations:
    flux.weave.works/automated: "true"
    repository.flux.weave.works/redis: "image.repository"
    tag.flux.weave.works/redis: semver:~4.0
spec:
  releaseName: redis
  chart:
    repository: https://kubernetes-charts.storage.googleapis.com/
    name: redis
    version: 5.1.3
  values:
    image:
      repository: bitnami/redis
      tag: 4.0.12


Add a profile to make use of UMLgraph for javadocs

The new profile can be activated with the CLI argument -Pumlgraph, e.g.
mvn clean package -Pumlgraph. To make this work, a dependency has to be installed on the system: graphviz. One could use sudo apt-get install graphviz to install this.
The UMLGraph software will produce UML class diagram pictures, which will automatically be included in the javadocs. Options for the generation of the diagrams can be found here: http://www.umlgraph.org/doc/cd-opt.html

Gogogo!


fix(core): recover the unbound freeformType contract per module system

the module system can't deal with a proper __functor but doesn't
(yet) implement appropriate validators upstream

so we just move on and implement a sanator here

LGTM.


2 different cases : media_url is a base64 string or is an URL path (local or internet)

There is 2 different cases that need to be handled, if media_url  is a base64 string or is an URL path (local or internet)
Behaviors are supposed to be the same but are not especially when printing the string : it is not possible to log a base64 string

resolved


light: fetch source from gitlab

Description of changes
Fix https://github.com/NixOS/nixpkgs/issues/344482
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

I don't know if its acceptable to move this to by-name, but since we're working on this derivation maybe we can perform marginal cleanup as well?

@Frontear Even though there will be a tree-wide move. I still think we can move it manually if we do other thing together.

@Frontear Even though there will be a tree-wide move. I still think we can move it manually if we do other thing together.

In that case it would be nice to have this moved while we're at it here then

@Frontear Done.

@Mindavi Done.

Looks good! For next time I'd encourage keeping the by-name move as a separate commit.
It's not an officially mandated policy, more of an opinionated one, since at least in my opinion it makes it easier to revert a bad package without subsequently needing to shift it back around the tree, as this can be more error prone and is overall counterproductive to wanting packages in by-name eventually.


cant install

note: This error originates from a subprocess, and is likely not a problem with pip.
error: metadata-generation-failed
× Encountered error while generating package metadata.
╰─> See above for output.
note: This is an issue with the package mentioned above, not pip.
hint: See above for details.

Sorry, I can't help you without more context.


Upgrade eclipse tycho to v1.3.0 to support Java 11+

Current version of eclipse tycho is v1.3.0. This is the first and only version that supports Java 11 snd is compatible with eclipse 2018-12 (v4.10)
Currently DBeaver uses tycho v1.1.0

We'll upgrade to Tycho 1.3 or 1.4 in version 6.1.5


eth2 integration test is not working

What is wrong?
The eth2 integration test in test_demo.py does not seem to be finalizing the chain properly. Investigate why the test is not working.
How can it be fixed
Are the various attestations being created properly?

sounds like @NIC619 did some fruitful debugging here :)

fixed in #1214.


[test] Automate Test_TC_BINFO_1_1.

Problem
Some test suite tests that can be automated with YAML are disabled.
Change overview
Add automation for TC_BINFO_1_1
Testing
Locally with:
./gn_build.sh
./scripts/tests/run_test_suite.py --target Test_TC_BINFO_1_1 --chip-tool ./out/debug/standalone/chip-tool run all-clusters-app ./out/debug/standalone/chip-all-clusters-app

Also CI will cover as well.

Updated the codegen.  Verified test locally (for real this time).
This should be ready given approvals and CI checks.

@turon can you also remove this test case from the manual section and move it to automated here please ?src/app/tests/suites/tests.js

@turon can you also remove this test case from the manual section and move it to automated here please ?src/app/tests/suites/tests.js

Done.  Thanks


In the hd44780 library, how do you use the set_backlight function? The first argument is 'hd44780_t *lcd

In the hd44780 library, how do you use the set_backlight function? The first argument is 'hd44780_t *lcd' whereas the other functions use 'const hd44780_t *lcd' which is &lcd in my code (following the example provided) so I'm wondering what I need to write in set_backlight to get it to work. Context: Trying to turn the backlight on and off with a button.


[Bug]: Unable to migrate the business license to enterprise license on release license manager app

Is there an existing issue for this?

[X] I have searched the existing issues

Description
Unable to migrate the business license to enterprise license on release license manager app

Steps To Reproduce

Create a license from release customer portal make this license as a paid license
now go to https://internal.appsmith.com/app/license-manager-app/view-licenses-649d3e531572505690b1ea7a?branch=release
check for same user and click on Action button
Now select the migration link and now select all the required detailes and click on confirm
The error message is displayed as in the attached screen shot

Public Sample App
No response
Environment
Release
Issue video log
No response
Version
v1.9.58

This issue is happening on backend when we are trying to attach a zero price plan for tracking usage but somehow price we are attaching belongs to an archived product because of which subscription update fails. We need to ensure that we are attaching only an active product's price for tracking usage.

Closing the issue as this is no longer needed


deprecate quick_collection, simplify docs

[x] I agree to follow the project's code of conduct.
[x] I added an entry to CHANGES.md if knowledge of this change could be valuable to users.

The real motivation for this pull request, is that I was trying to look up some basic usage of the geojson crate and it took me uncomfortably long. Our documentation has grown over time and become a bit long winded in my experience.
So I was looking for ways to simplify our documentation, and noticed the couple paragraphs devoted to quick_collection.
Since quick_collection converts &GeoJson -> Result<geo_types::GeometryCollection>, I think it will be more discoverable under the idiomatic TryFrom trait, and because it's working like the idiomatic TryFrom trait, I think we can truncate some of the documentation.

Sorry that I didn't merge this a long time ago!
I've made a couple minor changes but the thrust is the same. Can I get another review?


HBO Comedy East

Source
https://www.tvpassport.com/tv-listings/stations/hbo-comedy-hd-east/7105
Channels
HBOComedyEast.us
Notes
Adding to TVPassport please ? It was added to another links already

Already in tvpassport.


Warning message gets printed multiple times

/kind bug
How did you run odo exactly?
odo push
Actual behavior
[mrinaldas@localhost nodejs-ex]$ odo push
Validation
 ✓  Checking component [1s]

Configuration changes
 ✓  Initializing component
 ✓  Creating component [5s]

Pushing to component nodejs-nodejs-ex-nyyg of type local
 ✓  Checking files for pushing [715424ns]
 ◐  Waiting for component to start [⚠ WARNING x5: BackOff, use `-v` for more inf ◓  Waiting for component to start [⚠ WARNING x5: BackOff, use `-v` for more inf ◑  Waiting for component to start [⚠ WARNING x5: BackOff, use `-v` for more inf ◒  Waiting for component to start [⚠ WARNING x5: BackOff, use `-v` for more inf ◐  Waiting for component to start [⚠ WARNING x5: BackOff, use `-v` for more inf ◓
^C

Waiting for component to start [⚠ WARNING x5: BackOff, use -vfor more inf ◓  gets printed again and again.
Expected behavior
Waiting for component to start [⚠ WARNING x5: BackOff, use -vfor more inf to be printed once

@mik-dass Is your terminal really small? This is what may be causing the issue.. I may have to shorten the info / output)

@mik-dass Is your terminal display really small? This is what may be causing the issue.. I may have to shorten the info / output). Can you re-run it with your terminal display wider?

yes on a wider terminal, the duplication seems to be gone.

@mik-dass Yup. That's normal. It's the terminal doing it's thing with regards to the spinner.
I do realize that the warning message is actually quite long, I'm going to push a PR to reduce the size to hopefully we don't have this occur again on smaller terminals.

I do realize that the warning message is actually quite long, I'm going to push a PR to reduce the size to hopefully we don't have this occur again on smaller terminals.

OK :+1:


Small README.md thing

in https://github.com/raysan5/raylib#basic-example "running while example" link(https://www.raylib.com/examples/web/core/loader.html?name=core_basic_window) returns 404.

@gstjepan2 Thank you very much! Reviewed!


⚠ Bofrost.at has degraded performance

In 4c9df27, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 1795 ms

Resolved: Bofrost.at performance has improved in 60bd379.


Convert SKRect to CGRect correctly

Description of Change
SKRect.ToRect() does not convert to CGRect correctly.
Bugs Fixed

Fixes #2242

API Changes
None.

Behavioral Changes
None.

Required skia PR
None.

PR Checklist

[ ] Has tests (if omitted, state reason in description)
[ ] Rebased on top of main at time of PR
[ ] Merged related skia PRs
[ ] Changes adhere to coding standard
[ ] Updated documentation

I believe the change you made to ToSKRect() is incorrect. The SKRect constructor expects to receive the Right and Bottom values. However, the fix to ToRect() looks good.

@mattleibow I believe the change you made to ToSKRect() is incorrect. The SKRect constructor expects to receive the Right and Bottom values. However, the fix to ToRect() looks good.

Thanks! Also spotted that and then decided it was time to add a test to catch this. Just testing my tests now and will fix it.


Remove user inputs printed in logging and error statements

Signed-off-by: Naveen Tatikonda<EMAIL_ADDRESS>Description
As per the security recommendation, removing user inputs from being printed in logs and error statements
Check List

[x] Commits are signed as per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Codecov Report

Merging #350 (0ff8a79) into main (66f3685) will increase coverage by 0.08%.
The diff coverage is 56.89%.

@@             Coverage Diff              @@
##               main     #350      +/-   ##
============================================
+ Coverage     83.99%   84.07%   +0.08%
  Complexity      900      900
============================================
  Files           130      130
  Lines          3854     3844      -10
  Branches        353      353
============================================
- Hits           3237     3232       -5
+ Misses          457      452       -5
  Partials        160      160

Impacted Files
Coverage Δ

.../main/java/org/opensearch/knn/index/IndexUtil.java
55.73% <0.00%> (ø)

.../main/java/org/opensearch/knn/index/KNNScorer.java
69.23% <0.00%> (ø)

...org/opensearch/knn/index/KNNVectorFieldMapper.java
83.18% <ø> (ø)

.../main/java/org/opensearch/knn/index/KNNWeight.java
78.94% <0.00%> (ø)

...index/codec/KNN80Codec/KNN80DocValuesConsumer.java
89.09% <0.00%> (ø)

...in/java/org/opensearch/knn/indices/ModelCache.java
95.45% <0.00%> (ø)

...in/java/org/opensearch/knn/indices/ModelState.java
89.47% <0.00%> (ø)

...pensearch/knn/plugin/rest/RestKNNStatsHandler.java
90.90% <0.00%> (ø)

...nsearch/knn/plugin/rest/RestTrainModelHandler.java
61.29% <0.00%> (ø)

...arch/knn/plugin/transport/DeleteModelResponse.java
100.00% <ø> (ø)

... and 21 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 66f3685...0ff8a79. Read the comment docs.

Is there any reason for removing it from Error message, since this will be displayed only to the user?

As per our offline discussion, closing this PR.


Transparent materials invisible when shadow-intensity enabled in 1.12.0

Description
The problem is that in new version (1.12.0) material with transparency becomes completly invisible if shadow-intensity is set to value greater than 0. If you open URL below and set value to 0 the "glass" would become visible. Otherwise it's invisible. This bug is only in the newest version 1.12.0. There was no such problem in 1.11.0.
Live Demo
https://quirky-nonchalant-mare.glitch.me
Version

model-viewer: v1.12.0

Browser Affected

[x] Chrome, version: 103.0.5060.66
[x] Edge
[x] Firefox
[ ] IE
[ ] Safari

OS

[ ] Android
[ ] iOS
[ ] Linux
[ ] MacOS
[ ] Windows

AR

[x] WebXR
[ ] SceneViewer
[x] QuickLook

After my own research of the code I can say that the "glass" has property visible (mesh.visible) set to false, because somehow this glass is marked as "bakedShadow".
This issue is similar to #3398
@elalish I believe you are aware of this issue.

The issue here is probably the change between versions 1.11.1 and 1.12.0 in ModelScene.ts in findBakedShadows function:
1.11.1
const material = mesh.material as Material;       if (!(material as any).isMeshBasicMaterial || !material.transparent) {         return;       }
1.12.0
      if (!material.transparent) {         return;       }

It's true, but we did this for a reason (see your PR). At the same time we added bounds checks; I believe if you simply make your glass material smaller (rather than including the frame), then we will see that it is smaller than the bounding box and thus not mark it as a shadow.

That's true that if I make the glass thicker it will work correctly. But I think it's bug anyway. How can I achieve correct result everytime even if object has various dimensions?

It's also about extents: shadow planes have to go all the way to the boundaries of the scene. If you don't overlap your frame object, that should also take care of it. Detecting baked shadows is a heuristic, unfortunately, so it will never be correct always.

Can you provide some examples where baked shadow were created without using an unlit shadow material?
This case is quite interesting because in most of usecases, glass is made with plane (where one of dimension is 0). Will model-viewer mark it as baked shadow too? We need to come up with an idea how to fix this issue, because in version 1.12.0 some of our models stopped working correctly.

No, but we found a bunch. Anyway, all you have to do is ensure your glass doesn't extend past everything else in your model, because we check not just that one dimension is 0, but also that the other dimensions match the bounding box dimensions of the scene. In your model it appears the glass should be smaller than the frame, but I'd guess it actually overlaps it and hence trips the logic.

Someone else just ran into this and found that it started working properly when bounds="tight" is specified. This is going to become the default in v2.0 anyway, but can you check if that helps?

Yea, it helps. I didn't notice that this property somehow affects baked shadows. Anyway, thank you for your help!

Yeah, it shouldn't; it's a bug. But that option will be removed for v2.0 so that no one has to remember anymore.

Fixed by #3683


[STYLE CHANGE]

Issue Description:
I would like to make some modifications to the website's header section at line number 148, where there is a heading. It would be beneficial from the user's perspective if the heading attracts their attention and clearly conveys the purpose of the section, which is 'Moksh Features.' This change aims to help users understand what the section entails and improve their overall experience.
Reason for Change:
There can be several reasons to make modifications to the website's header and improve the heading to attract users and enhance their experience. Here are some potential reasons:
1.User engagement: A compelling heading in the header section can grab users' attention and encourage them to explore further. By clearly conveying the purpose of the section, users are more likely to engage with the content and spend more time on the website.
2.Clarity and understanding: A well-crafted heading helps users quickly understand what the section is about. It sets clear expectations and enables users to navigate the website more efficiently, finding the information they need without confusion.
3.Branding and messaging: The heading in the header section can serve as a branding element, reinforcing the website's identity and message. A strong and captivating heading can align with the overall brand image, leaving a lasting impression on users.
4.User satisfaction: When users can easily comprehend the content and purpose of a section, it enhances their overall satisfaction with the website. By optimizing the heading, you contribute to a positive user experience, leading to increased user engagement, repeat visits, and potential conversions.
5.SEO considerations: Well-optimized headings with relevant keywords can positively impact search engine rankings. By improving the heading in the header section, you can potentially enhance the website's visibility in search engine results and attract organic traffic.
Current Styling:
The Current Styling in the index.html , h1 part is as follows -
margin-bottom: 0.5rem;
font-weight: 500;
line-height: 1.2;
font-size: 2.5rem;
Proposed Styling:
There is no animation in the heading, not even a different color to show that it is a heading. I will add some animations and color, while also maintaining the font-size and font-family CSS. I will change some styling features in the index.html page, including the following:
1.Font-family
2.Font-size
3.Justify-content
4.Some hover properties
5.Animations.
Screenshots or Design Mockups (optional):
Current Heading Text--

Styling Use--

**Priority Level **

[ ] Low
[ ] Medium
[x] High

To update the following codes, please assign this issue to me. As this is very important to attract users. It will be very great of you, if you assign it to me. I will take responsibility for making these changes by June 5th, 2023.

do a fresh fetch, pages have been updated.


How does the chain get the token price?

What should I configure?
cgw logs
{"build_number":"234a559","level":"error","message":"Error getting native coin price: Error ","request_id":"052850c3-0ba6-402e-b422-9aada3087714","timestamp":"2024-08-22T08:51:01.820Z","version":"v1.53.0"}

{"build_number":"234a559","level":"error","message":"Error getting token prices: Error: Error getting 0x5fd55a1b9fc24967c4db09c513c3ba0dfa7ff687 price from provider ","request_id":"7e46512c-42ef-4daf-90e7-35794b0c8b09","timestamp":"2024-08-22T08:51:32.146Z","version":"v1.53.0"}

ui screen capture

cfg admin config

@fmrsabino @hectorgomezv @iamacook

Hello @lance-web3,
We currently use Coingecko to get the fiat prices, so you would need to take those configuration values from the Coingecko API: https://api.coingecko.com/api/v3/asset_platforms
I understand you are trying to get prices on fxCore Mainnet, so:
    {
        "id": "function-x",
        "chain_identifier": 530,
        "name": "Function X",
        "shortname": "",
        "native_coin_id": "fx-coin"
    },

So:
Prices provider native coin: fx-coin
Prices provider chain name: function-x

You can left "Balances provider" configuration keys empty.

Hello @lance-web3,
We currently use Coingecko to get the fiat prices, so you would need to take those configuration values from the Coingecko API: https://api.coingecko.com/api/v3/asset_platforms
I understand you are trying to get prices on fxCore Mainnet, so:
    {
        "id": "function-x",
        "chain_identifier": 530,
        "name": "Function X",
        "shortname": "",
        "native_coin_id": "fx-coin"
    },

So:
Prices provider native coin: fx-coin
Prices provider chain name: function-x

You can left "Balances provider" configuration keys empty.

ok it works, how about for all other tokens? I am wondering.. @hectorgomezv

You'd need to configure the native_coin_id (in the Coingecko response) as Prices provider native coin (in the Config Service Chain configuration). And also id (in the Coingecko response) as Prices provider chain name (in the Config Service Chain configuration).

You'd need to configure the native_coin_id (in the Coingecko response) as Prices provider native coin (in the Config Service Chain configuration). And also id (in the Coingecko response) as Prices provider chain name (in the Config Service Chain configuration).

@hectorgomezv
You mean it can configure multiple in those field? e.g.
Prices provider native coin: fx-coin,coin2,coin3
Prices provider chain name: function-x


Firefox versions not working correctly

I have the following configuration:
required: {
c: -6,
e: -6,
f: -6,
o: -6,
s: -1,
samsung: -6
}
But every version of Firefox under 115 shows the banner.

And safari 15 shows the banner too !!!

chrome every version under 114 !!!

to resume, all except latest version shows the banner... an error in code ?

well, actually I changed to
required: {
    c: 108,
    e: 107,
    f: 101,
    o: 94,
    s: 15,
    samsung: 0
},

same problem

arghhh, stupid me, unsupported = true


Docs for native openRTB

In this PR there are described changes how publisher can utilize native openRTB specification.
This PR is linked to:

pbjs PR
puc PR

https://github.com/prebid/Prebid.js/pull/7847

We should reflect these changes in the adunit-reference.md also.

I'll bring this up in the next PBJS meeting and will find someone to rewrite the docs.

@bretg, so should I close this PR or leave it? I already have enabled Allow edits by maintainers

@FilipStamenkovic - we we discussed in today's PBJS meeting. Updated the code PR with the outcome. I'll take care of this doc PR. Appreciate your draft.

produce a new document that is the recommended way that new native implementations should be done.
leave the current doc in place but warn that new implementations should be done in the ortb-way
hide the old-old doc away, making it more clear that no one should be using that (sendId) approach anymore.

fixed conflicts caused by AdOps section updates

Ok - thanks for the reviews. Merging.


Use Cutlass ops when possible to +15% speed

Use Cutlass ops when possible to +15% speed (for free)
Sampling speed 1.80it/s->2.08it/s on RTX5000.
Won't trigger if MemoryEfficientAttentionCutlassOp is not available.

@danthe3rd


R.ifElse - R.filter in onFalse branch affects onTrue branch

Works as expected (REPL):
R.ifElse(
  R.isNil,
  R.always( 'Nil' ),
  R.always( 'Young' )
)(undefined)
//=> 'Nil'

Works as unexpected (REPL):
R.ifElse(
  R.isNil,
  R.always( 'Nil' ),
  R.filter           // Only difference
)(undefined)
//=> function (t){return n.apply(this,arguments)}

I'm pretty sure this is down to the way Ramda handles the arity of the functions passed to ifElse. If you look here you'll see that the function returned will be will be curried and expecting the same amount of arguments as the function with the greatest arity of those supplied to ifElse. In your case, R.filter expects the most arguments so you get back a curried function of arity 2. I think the bug here is that the docs are misleading and say that the function returned will be unary (although I would prefer to remove the complexity around supporting functions with an artity >1).

Thanks @svozza That helps a lot.
I think this is hugely counterintuitive. There's this hidden logic that is not documented (or as you said - wrongly documented as unary).
Basically, if condition, onTrue or onFalse has different arity, the method won't work as expected.
I'm also not sure I understand why the returned function is curried based on the max rather than the arity of the condition?

Tbh, I never use R.ifElse because, like you, I've been tripped up by it in the past. I find a nicely formatted ternary expression in an arrow function is clear enough.

Tbh, I never use R.ifElse because, like you, I've been tripped up by it in the past. I find a nicely formatted ternary expression in an arrow function is clear enough.

@Izhaki
Sorry, I've been off for a bit, having my head examined* and I missed this.
It's not clear to me what you'd want out of your non-working example.
myFunc :: (String -> Boolean) ->
          (String -> String) ->
          ((String -> Boolean) -> [String] -> [String]) -> ????

If you want to return the filter function itself when the parameter supplied is not nil, then you could use always(filter), although the type of this would be very strange, returning 'Nil' in one case and the filter function in another.  If that's not what you want, I'm not quite sure what it is you do want.
I don't really share @svozza's distaste for ifElse, although I am also interested in moving to unary-only.
But perhaps we should at least update the documentation to have a type something like
ifElse :: (a -> Bool) -> (a -> b) -> (a -> b) -> (a -> b)
       :: (a -> b -> Bool) -> (a -> b -> c) -> (a -> b -> c) -> (a -> b -> c)
       :: (a -> b -> c-> Bool) -> (a -> b -> c -> d) -> (a -> b -> c -> d) -> (a -> b -> c -> d)
       ...

* So, it was just my right eye and one side of my forehead, covered in shingles bumps -- that's still part of my head!

@CrossEye
The actual use case:
A form of 'safeFilter', where:

if a predicate is provided, return a filter function whilst partially applying its first parameter.
if no predicate is provided, just return R.identity.

(I know there are other ways to achieve this, like R.allPass, but the example I gave doesn't seem intuitive to me).

Whist perhaps a discussion for a different issue, the max strategy yields all sorts of non-intuitive results. Consider:
R.converge( R.call, [
  R.add,
  R.add(2)
])(2)

In my head, this is what should happen, step by step:
R.converge( R.call, [
  R.add(2),
  R.add(2)(2)
])

Then:
R.converge( R.call, [
  R.add(2),
  4
])

Then:
R.call( R.add(2), 4 )

6

But this doesn't happen. Instead you get [REPL]:
//=> function (t){return n.apply(this,arguments)}

The actual use case: [...] a form of 'safeFilter'

So you want a points-free version of this?
curry((pred, vals) => isNil(pred) ? vals : filter(pred, vals));

As you noted, there are many ways to achieve this, including
ifElse(isNil, nthArg(1), filter)

which offers a sort of binary version of identity via nthArg(1), or
ifElse(isNil, always(identity), unary(filter))

which reduces filter to a unary function.
The difference between these two is that the former can be called either like
fn(isEven, [1, 2, 3, 4, 5])

or like
fn(isEven)([1, 2, 3, 4, 5])

while the latter can only be called the second way.

All this is a result of trying to handle polyadic functions here and elsewhere.  That is much closer to normal JS behavior than is forcing everything to be unary.  But it's definitely time for Ramda to consider this anyway.

Right then. So @svozza provided the lead, and @CrossEye provided the explanation.
I think there is only one stone left unturned before this issue can be closed, and that's the documentation.
Now I may have missed a legend (have I missed a legend?), but for me this:
*…

means 0 or more arguments of any type.
In the following signature:
(*… → a),*… → a

There is nothing to suggest that the first and the second *... are of the same arity (although in the case of call this is rather obvious).
I personally find
ifElse :: (a -> Bool) -> (a -> b) -> (a -> b) -> (a -> b)
       :: (a -> b -> Bool) -> (a -> b -> c) -> (a -> b -> c) -> (a -> b -> c)
       :: (a -> b -> c-> Bool) -> (a -> b -> c -> d) -> (a -> b -> c -> d) -> (a -> b -> c -> d)
       ...

rather verbose.
Here are some ideas:

n* - (n* → a),n* → a
*n… - (*…n → a),*…n → a
n:*… - (n:*… → a),n:*… → a

Or maybe:
1..n *… => (*… → a),*… → a

At any rate, I think that a legend is more important than the actual syntax, so perhaps just keep it *... but have a legend somewhere saying the arity must match?

We definitely do not have a simple legend.  I did write a long description of how we use type signatures.
But I would like to remove every internal ellipsis from the signatures.  I think they are simply confusing.  I'm afraid I don't find any of your suggested replacements convincing, though.
This really best belongs in a separate issue though.  Please feel free to open one if you want to discuss this further.

For my own signatures, I use … exclusively to denote variadic input, but use a number as well (i.e. a1…aN).  The advantage of this is that complex signatures can vary the a to denote flow of untyped data through stages (i.e. a → b → c) and the N can be matched elsewhere to denote expected matching of argument count.  I've never had a case with 3 different variadic matchings, so it as thus far been sufficient to switch to M when documenting an unrelated variadic set of arguments.
Some examples:
// simple:
// args :: a1…aN → [a]
// applyThese :: [a] → (a1…aN → b) → b

// complex:
// convergeP :: (b1…bN → c) → [a1…aM → Promise(b)] → a1…aM → Promise(c)

@evan-king: That seems a decent syntax, but what I would prefer is what's presented in https://github.com/ramda/ramda/pull/1938#issuecomment-257752500.

@CrossEye Is it possible to update the documentation on ifElse to explain that it curries until the arity of the greatest argument is reached?  This was very confusing as I passed in a function that was single arity into the ifTrue and one that is curried but had 2 params left to fill in the ifFalse.  It made things work acceptably for the ifFalse, but I had to adjust the ifTrue to accomodate.
For instance, here is an example:
(property, initialObject) => ifElse(equals(prop(property, initialObject)), always(dissoc(property)), set(lensProp(property)))

In this example, I expected this ifElse to return a function that when called with a value, would then return a function that, when passed in a state object, would either remove the property if it was not different than the initialObject's property; or would set the value to the new value.  However, this did not work.  I had to adjust the code to allow for the arity difference between always and set.  The new code had to be like this:
(property, initialObject) => ifElse(equals(prop(property, initialObject)), compose(dissoc(property), nthArg(1)), set(lensProp(property)))

This is fine, but it was not understood from the documentation that it would curry the result until it reached the max arity of the arguments.
So, is it possible to add that to the docs?
Thanks!

@Guardiannw We welcome PRs for documentation fixes. Would you be interested in taking a shot?


Blockquotes, indented list, heading 5/6 markdown not rendering properly

Describe the bug
When entering markdown into the text editor, the following formatting is not being rendered correctly:

Blockquotes

The ">" character disappears, but there is no bar on the left to denote the blockquote. Formatting also does not change.

Indented lists

The indented list item shows the list character at the same indentation level as parent instead of indenting properly.

Headers 5 and 6

Are not applying properly. #### H4 works as expected, but ##### H5 and H6 show up as regular text.

Steps to reproduce
Enter the following markdown into the text editor:

Blockquotes:

"> Text"

Indented list:

"- list item 1 (then new line, then 2 spaces, then  '- list item 2')"

H5 and H6

"##### Text or ###### Text" in their own line

The version of Memos you're using
Version: v0.18.2
Screenshots or additional context

Expected blockquote:

Expected indented list:

Markdown in editor:

Actual formatting in app:

Looks like these issues were fixed in fdbf2d8.
On the online demo version, I still do not see a difference between H5 and H6, but I will pull an updated image and see if the list and blockquotes are resolved for me.

I can confirm that the stable image solved the quoteblock and indented list problems.
However I still do not see any difference between the H4, H5, and H6 formatting.


Buy tokens: delivery_address is not optional

When I try to buy tokens and click the Get Started button I get the following:
Error: SavitarWidget: Missing delivery_address
    at payments.js:1
    at uo (framework.4dd1003….js:1)
    at Nu (framework.4dd1003….js:1)
    at t.unstable_runWithPriority (framework.4dd1003….js:1)
    at $l (framework.4dd1003….js:1)
    at Pu (framework.4dd1003….js:1)
    at framework.4dd1003….js:1
    at U (framework.4dd1003….js:1)
    at MessagePort.T.port1.onmessage (framework.4dd1003….js:1)

@savitar-dev, how can a user specify delivery_address?  As far as I can tell, it can only be specified in the config on the server side.

I'm using https://github.com/savitar-exchange/swap-sdk.git#a467f26baf8a4c8c63338c885e879bd6c22cb330.

Can you provide us with widget configuration ?
I think you set payment_type to 'merchant' or 'exchange'.
If you want params to be optional, just leave payment_type empty. 'merchant' and 'exchange' validates configuration against a use case. I will update the doc.

Can you provide us with widget configuration ?
I think you set payment_type to 'merchant' or 'exchange'.
If you want params to be optional, just leave payment_type empty. 'merchant' and 'exchange' validates configuration against a use case. I will update the doc.

You are correct.  I had
 const configTokens = {
    payment_type: "merchant",
    email<EMAIL_ADDRESS>    email_editable: true,
    currency: "iov",
    amount: 100,
    amount_editable: true,
    delivery_address: "star1...",
 };


Use cpu_count instead of NUM_CPUS

closes #1135

The version of blaze in pypi still has this bug, making non-development-branch use of blaze a show-stopper.

Release is coming up likely today or tomorrow

Will put on PyPI when released. Just tidying up some doc stuff


Stormblessed: Watch TripNinjaAdmin

Stormblessed requests the watch of the watch_keyword TripNinjaAdmin. See the MS search here and the Stack Exchange search here.

TripNinjaAdmin has been seen in 0 true positives, 0 false positives, and 0 NAAs.

This appears to be a username. We usually don't watch a username unless the spammer has been persistently spamming and routinely using the same username.


Unit Test: associations_test

Support for Constraint
--- FAIL: TestForeignKeyConstraintsBelongsTo (6.73s)
associations_test.go:163: member id is not equal: expects: 100, got: 1
--- FAIL: TestForeignKeyConstraints (4.58s)
associations_test.go:109: member id is not equal: expects: 100, got: 1

SF does not enforce constraint
https://docs.snowflake.com/en/user-guide/table-considerations.html#referential-integrity-constraints


[Proposal][Android]: SMS TextField.oneTimeCode autofill without user interaction

Use case
When we have an oneTimeCode Textfield:
 TextField(

              autofocus: true,
              keyboardType: TextInputType.text,
              autofillHints: <String>[AutofillHints.oneTimeCode],
 ),

The user needs to tap, "Autofill-code" popup after focusing the TextField to start listening to an SMS.

Proposal
Would it be possible to start listening to the oneTimeCode without user interactions, and start it after the textField is focused or auto-focused for Android? So it will be more similar to iOS which doesn't need user interactions.

Cc: @LongCatIsLooong

AFAIK the user interaction is part of the android autofill workflow: https://developer.android.com/guide/topics/text/ime-autofill#workflow (this is for IME inline suggestions but autofill basically follows the same protocol). In short as a UI framework we currently don't have ways to do that as the user interaction is a required part of the android autofill protocol.

Without additional information, we are unfortunately not sure how to resolve this issue.
We are therefore reluctantly going to close this bug for now.
Please don't hesitate to comment on the bug if you have any more information for us; we will reopen it right away!
Thanks for your contribution.
Could everyone who still has this problem please file a new issue with the exact description of what happens, logs, and the output of flutter doctor -v.
All system setups can be slightly different, so it's always better to open new issues and reference related issues.


Add recursive record support

Thanks @diehuxx for putting the requirements together!
A few comments/questions:

this is useful because we may want to terminate a recursive list of records with a record of the same schema and dataFormat but with different $actions rule

Agree that there is no ambiguity but can this really terminate the list? Can't one just write another chat message as usual and attach to the parent of the "terminating" chat message?

If I understand this correctly, it means that we are allowing a very very very long "chain" to be constructed and ever growing. This would render this feature not usable very quickly with current implementation because of we construct the ancestor chain all the way back to the root. Since we now have protocolPath, we can (and must) try avoiding walking back to the root all altogether (ie. nuke constructAncestorMessageChain()) and just take advantage of protocolPath in order for this feature to be useable.

The ship has sailed on this one it seems: but what problem/scenario does this feature solve/enable?
I understand with this, one can form a very deep tree with very minimal syntax, but why is this needed/useful?

Agree that there is no ambiguity but can this really terminate the list? Can't one just write another chat message as usual and attach to the parent of the "terminating" chat message?

You're right that someone can just continue the conversation in another branch. This is admittedly a contrived example, just meant to illustrate the edge cases.

If I understand this correctly, it means that we are allowing a very very very long "chain" to be constructed and ever growing. This would render this feature not usable very quickly with current implementation because of we construct the ancestor chain all the way back to the root. Since we now have protocolPath, we can (and must) try avoiding walking back to the root all altogether (ie. nuke constructAncestorMessageChain()) and just take advantage of protocolPath in order for this feature to be useable.

Very good point, I'll need to think through implementation and update #389. I'll follow up on this point later today or tomorrow.

The ship has sailed on this one it seems: but what problem/scenario does this feature solve/enable?
I understand with this, one can form a very deep tree with very minimal syntax, but why is this needed/useful?

Gonna sauce this one to @csuwildcat.

There's no non-comical way to do messages as a descending thread for all the many app types that require it without a recursive rule. We definitely need something better than unchained timestamps, and this recursive proposal does it, so for that reason, it's a good idea.

@csuwildcat, why is this proposal less comical? Yes, a chat message can point to another chat message as its parent with this proposal, but A chat message can already do so without this proposal by declaring the logical parent in its data, so what is the problem that this proposal alone solves?
A difference I can see with this proposal is that one can potentially walk the ancestor chain one parent at a time to hit-test if it is a descending message of certain ancestor, but that's a pretty comical thing to do no? So surely this is not the intent.
Just trying to get to the intent succinctly (and it is still not succinct), else we might just be introducing complexity for little gain.
Adding @mistermoe and @frankhinek in case they have a slam dunk answer that's more convincing to me, @diehuxx feel free to take a shot at answering too!

We can't parse and efficiently deliver queries if the linkages are in the encrypted app data portion.

@csuwildcat, got it, so if I am interpreting correctly: this proposal alone does not solve any problems by itself. but, it sets the foundation for future proposals for querying against the tree structure of protocol messages, which would be the first precedence for a query based on a property that does not exist in the message itself (ie. descendantsOf?).
Such proposal sounds pretty cool but also sounds even more complex than this proposal... and still, what is an actual scenario that can't be achieved without the descendantsOf? Using the chat app example, the concept of a 'sub-thread' can be modeled using a sub-thread record type under the main-thread type. This allows developers to query all messages under any sub-thread without requiring additional features.
From a technical stand point, implementing performant tree traversal over relational DB or mongoDB is non-trivial in my book, especially when the proposed use case easily involve tree depths of hundreds or even thousands. Not to mention we'd need to hand-roll implementation in a key-value store called LevelDB... In principle, I would encourage keeping the app data model as flat as possible as the recommendation to web5 apps unless there is no other option.
If the goal is to provide developers with query capabilities to support their application use cases, an alternative approach that would probably offer bigger bang-for-the-buck with minimal complexity (which was proposed last year) is to provide an indexed "metadata" property. This would allow developers to populate and modify it with any desired value. This can support the sub-thread scenario mentioned and beyond.
Again sorry for coming across as uncooperative, I genuinely want to be supportive of all proposals!!! But I also need to fully comprehend them before endorsing them!

How do I reply/quote to a given message in a thread such that even if 100 more messages were sent between them over 2 days the two could be directly associated without decrypting their data?

sub-thread record type; and/or
indexed "metadata" property

Both described above.

@thehenrytsai I'm going to try modeling the sub-thread idea with a few other use cases to think through if that suffices.

Closing as we won't be tackling this anytime soon if ever. Can resurrect this issue if the time comes.


TS6133 (noUnusedLocals): False positives are reported for namespaces used as types

TypeScript Version:  3.2.0-dev.20181117

Search Terms:

TS6133,
noUnusedLocals,
import types,
namespace,
keyof typeof.

Code
Set "noUnusedLocals": true in your tsconfing.json. Create two sibling files.
variables.ts
export const foo = 1;
export const bar = 2;

index.ts
import * as variables from './variables'; // 'variables' is declared but its value is never read.

export type Variable = keyof typeof variables;

Expected behavior:
Compiles without error. variables are used to create a type which is then exported, which is a valid use case.
This pattern (reading types from variables as opposed to coding the design) is often used to reduce Redux boilerplate. When your application has hundreds of actions, it's easier to write:
import { ActionType } from 'typesafe-actions';
import * as actions from './actions';

export type MyActions = ActionType<typeof actions>;

then to define each action type separately and only then create executable code.
One might argue the way to go is to write:
export type MyActions = ActionType<typeof import ('./actions')>;

but this approach has its downsides (e.g. breaks the convention of having import statements in the beginning of the file, encourages duplicate import statements when one decides to use the imported namespace in some other way later).
Actual behavior:
Error in the first line. 'variables' is declared but its value is never read.

This is a regression from 3.1.


missing EF

hi,
I just create a new boilerplate project into an existing solution and I noticed that it miss EF. When I try to add the Nuget package it fails. Into other projects of solution (regular MVC by default VS template is no problem).
Also if I simply try to add Ado.Net Enitity Data Model it fails too.

Any hint please?
L.E.
The other projects that I talk about are build for some time. I noticed that if I try to make a new one it behave similar. I have to suppose that is something broke in my VS after some very recent updates

So you are just adding a NuGet package right? That error does not look very healthy and without knowing anythign else it looks like VS is messed up.

I just did a repair of VS and it's gone.


How to update prepackaged database table contents,, Not schema !

Hi there,
I created an app that contains prepackaged database. At first time I inserted temp data so I can test the app, but when I inserted the real data and copied the new .db file to assets folder I found only the old temp data .
Please Help me. I only want to update the table contents not the structure .

Please leave this for bug or feature requests. Insert real data post copying of the DB.


import esm module from parseTree

This PR aims to resolve the issue of using a temporary hack to run the language server as we are unable to use the bundled output due to a MODULE NOT FOUND error.
Description:
The jsonc-parser dependency has two module implementations in its library, ESM and UMD. Now, VSCode requires us to bundle the code into a single CommonJS module but the thing is esbuild doesn't have a built-in feature for direct UMD to CJS conversion but it does have ESM to CJS. Currently, the import uses the default export of the library which seems to be the UMD module, the solution is to simply change the import to the ESM module instead.

Unfortunately, I had to revert this. Although this fixes the vscode setup, it breaks the neovim setup. We need a solution that works for both.

I managed to stumble on the right solution.


[BEAM-12840] Fix intergration tests after Calcite upgrade

Run Sql Postcommit

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Choose reviewer(s) and mention them in a comment (R: @username).
[ ] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
[ ] Update CHANGES.md with noteworthy changes.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI.

Run Sql Postcommit

Run Sql Postcommit

Run Sql Postcommit

Run Sql Postcommit

Run Sql Postcommit

Run Java PreCommit

Failure is BEAM-10955

Run Java PreCommit

Run Sql Postcommit

@ibzib I've broken this up into 4 sepreate PRs. This shows the post commits pass once all 4 are merged: #15466 #15467 #15468 #15469

Run Sql Postcommit

This has all merged.


Revert language to original until style gets fixed

Description
Temporarily addresses poor display of code in dark mode.
Test Plan
Local

If your changes are not user-facing and not a breaking change, you can skip the following section. Otherwise, please indicate what changed, and then add to the Release Notes section as highlighted during the release process.
Type of Change (Check all that apply)

[ ] protocol change
[ ] user-visible impact
[ ] breaking change for a client SDKs
[ ] breaking change for FNs (FN binary must upgrade)
[ ] breaking change for validators or node operators (must upgrade binaries)
[ ] breaking change for on-chain data layout
[ ] necessitate either a data wipe or data migration

Release notes

Accepting to unblock, but could you not copy the example inline rather than get rid of it entirely?

This approach more closely aligns with similar topics that just provide the links. Integration of code is top of mind so this will get addressed more holistically sooner rather than later.


channel keep alive span

close #5
What I did

Create a listener tree system

Every listener to obtain telemetry data will be generated from RootListener and its child listeners.
Monitoring Engine tells RootListener a fundamental timing and objects
RootListener setups child listeners, e.g. EngineListener.

Create a custom span class (ChannelKeepAliveSpan)
Create OpenTelemeryProxy

Enables fetching the tracer object from anywhere.

Tests

I'm leaving the following related issues
#31
Checklist

[x] Make sure you are opening from a topic/feature/bugfix branch (right side) and not your master branch!
[x] Ensure that the pull request title represents the desired changelog entry
[x] Please describe what you did
[x] Link to relevant issues in GitHub or Jira
[x] Link to relevant pull requests, esp. upstream and downstream changes
[x] All follow-ups are documented as issues and-or TODO comments
[x] Ensure you have provided tests - that demonstrates feature works or fixes the issue
[ ] Please update user documentation if needed
[ ] Please update developer documentation if needed

Close this PR to test reviewer auto assign


[webview_flutter] Add a backgroundColor option to the Android webview

This PR add an option to set the background color of the Android webview.
Original PR :
https://github.com/flutter/plugins/pull/3431
It fixes this issue :
https://github.com/flutter/flutter/issues/29300
Pre-launch Checklist

[x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[x] I read the Tree Hygiene wiki page, which explains my responsibilities.
[x] I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/plugins repo does use dart format.)
[x] I signed the CLA.
[x] The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
[x] I listed at least one issue that this PR fixes in the description above.
[x] I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
[x] I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
[x] I updated/added relevant documentation (doc comments with ///).
[x] I added new tests to check the change I am making, or this PR is test-exempt.
[x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

I made the changes. I also hard code the Colors.green color in the example as jmagman requested it in the iOS PR.


Language/php

Add the 3 endpoints for php with the laravel framework

I deleted most of the stuff that is unnecessary. Most of the staff thats in the project now is somehow necessary to run the applicaton. I think you can delete more stuff if you dig deeper into the config files and edit them but that is beyond my knowledge as of today.

Sounds great! Thank you so much for contributing!


proto: ensure consistency of behavior in Register* functions

At first, panic will not work properly on appengine. In fact, in order to avoid this, deletion by sed is done in appengine official package.
This behavior is not a consistent behavior in Register* functions.
I think that it is enough to just log back and do a return like RegisterType without generating panic.
In addition, RegisterFile also changes to make it behave consistently as well.

Hi, thanks for the PR. I'm in the process of redesigning how registration works. Let's leave changes like for the broader story around #268.

@dsnet Thank you for telling me that you are redesigning. I expect it.
However, is there a reason not to accept this change at the moment?

Log printouts get ignored all the time. The panic provided a loud failure; switching a loud failure to a silent one doesn't seem like change we should make now.

On the flip side, if we switch the silent ones to be loud, then people will be broken now when they weren't before. For now, let's just keep the status quo, even if it isn't ideal.

I will write about the problem I am encountering.
I am currently developing an API using protobuf on appengine. As a matter of course, RegisterEnum needs to be deleted like the official appengine package.
However, in addition to that, I have also developed a CLI corresponding to the API using pb.go, and at that time it has fallen into a condition that can not be developed correctly due to the fact that protoEnum is not registered properly.
I regard this as a fatal defect rather than being not ideal.

Why is the duplicate registration happening in your case?

This is because duplicate loading of all source code including pb.go generated by appengine and dev_appserver.py as standard is done.
I guess this issue is recognized by official appengine package developers. That's why the official package is doing the same.

Can you be more specific? Which proto is being loaded twice?

Source code to be deployed for appengine.
For example, RegisterEnum should exist in the following file, but it has been deleted by sed.
https://github.com/golang/appengine/blob/master/internal/datastore/datastore_v3.pb.go
Is this the correct answer for your question?
If you need a minimal source code set corresponding to appengine, please let me know. I am currently in trouble because of in-house development, so I need to create a new repository for reproduction. Probably it will take a few days.

ping?