fix!: use type module (revert #1411)

Reverts #1411 (and also #1439)
Ref: https://github.com/vitest-dev/vitest/pull/1411#issuecomment-1151632260
It's not needed to remove type module to fix the issue stated in the PR

Will it revert errors for users? If so, what should we recommend people?

Following https://github.com/vitest-dev/vitest/pull/1411#issuecomment-1147530146, if they're using the new nodenext or node16 options, they must name the test files with .mts if "type": "module" is not specified.

Yes it will revert the errors. Following #1411 (comment), if they're using the new nodenext or node16 options, they must name the test files with .mts if "type": "module" is not specified.

In that case, should we also expand our default our defaults?
https://github.com/vitest-dev/vitest/blob/fef00a7328907b7663fa37e06cffa1781b84cd88/packages/vitest/src/defaults.ts#L6
https://github.com/vitest-dev/vitest/blob/fef00a7328907b7663fa37e06cffa1781b84cd88/packages/vitest/src/defaults.ts#L15-L16

I think that makes sense 👍

/cc @aleclarson

I would hold this for a while longer. Indeed the usage in https://github.com/vitest-dev/vitest/pull/1411 might better use .mts for the tests. But as .mts is not wildly supported yet, plus there is not too much harm for us to use .mjs, I would more lean to make it easy for users until we really encounter some blockers for the current workaround.

Following #1411 (comment), if they're using the new nodenext or node16 options, they must name the test files with .mts if "type": "module" is not specified.

The "better solution" I mentioned in that thread goes like this:
".": {
  "require": {
    "types": "./dist/index.d.cts",
    "default": "./dist/index.cjs"
  },
  "types": "./dist/index.d.ts",
  "import": "./dist/index.js"
},

That would be how Vitest's exports should look. Then users aren't required to change their setup at all.
Both dist/index.d.cts and dist/index.cjs can just re-export from the other dist files.

The "better solution" I mentioned in that thread goes like this:

First of all, we already saw in that PR that it doesn't work, does it? TypeScript has a big preventing that.
Second of all, I don't see how this is a "better solution"? We will essentially double package size just to please few people with TypeScript issues that can be resolved on their end? Those files won't even be run in any situation.

First of all, we already saw in that PR that it doesn't work, does it? TypeScript has a big preventing that.

The two differences from your idea are that (1) require.types is defined and (2) it uses a .d.cts extension. Both are required for TypeScript to believe the package is not ESM only.

We will essentially double package size

No, the new .cts and .cjs files are basic re-exports of the ESM dist files.
// dist/index.d.cts
export * from './index.mjs'

// dist/index.cjs
export * from './index.mjs'

But this wouldn't work for the same reason it doesn't work right now, no? You cannot use static import/export inside cjs.

Those modules would never be loaded by Node.js runtime, so no errors would occur.
Correction: The dist/index.cjs module should actually be empty. The dist/index.d.cts allows import/export syntax, and I've tested it myself, so I know it works. :)
It's not a "hack", because the TypeScript team themselves said it's a valid solution.

Those modules would never be loaded by Node.js runtime, so no errors would occur.

No, I mean by TypeScript. Why would importing ESM from cts would work inside a node_module, but not in your own project?
Current problem:

importing Vitest from commonjs gives error from TypeScript typechecker, because it will compile import to require and requiring Vitest is not allowed
but importing inside Vitest's cts magically works? I don't buy it tbh

Ok, I've looked through the threads, and now I see that @aleclarson's idea is valid. We can include it in this PR actually, and safely merge it. @antfu, what do you think?

I am not very familiar with this topic, but sure, if it helps and doesn't break anything else :)

Is there anything blocking this from being merged?

Is there anything blocking this from being merged?

This needs updating, we changed quite a few APIs since then, and if merged, Vitest won't work.

For a package with:

package.json type set to module
tsconfig.json compilerOptions.moduleResolution set to Node16
<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>
Running tsc outputs:
../../node_modules/vitest/dist/config.d.ts:2:27 - error TS1471: Module 'vite' cannot be imported using this construct. The specifier only resolves to an ES module, which cannot be imported synchronously. Use dynamic import instead.

2 export { ConfigEnv } from 'vite'

Is there a known workaround?

I've updated the PR. Tried to update some of the newer places, and the tests seems to be passing, except ubuntu node14 (not sure if it's a fluke).

For a package with:

package.json type set to module
tsconfig.json compilerOptions.moduleResolution set to Node16
<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>
Running tsc outputs:
../../node_modules/vitest/dist/config.d.ts:2:27 - error TS1471: Module 'vite' cannot be imported using this construct. The specifier only resolves to an ES module, which cannot be imported synchronously. Use dynamic import instead.

2 export { ConfigEnv } from 'vite'

Is there a known workaround?

@jroru My workaround until this PR is merged has been to use patch-package to add "type": "module" to the vitest package.json.


Touchpad support

I'm on a Gigabyte A5 K1 right now running Windows 11. It doesn't look like hwinfo reports the touchpad, but I was able to pull it up from the System Information.

It would be particularly helpful if hwinfo could report screwed up drivers.  I had to uninstall the touchpad driver - using the Device Manager - and restart to fix it.

Hi and thanks for the suggestion. To be honest, I think that reporting driver issues is out of the scope for hwinfo (at least for now).
However, reporting input devices such as touchpad sounds reasonable to me. I will evaluate on this!

Noticed you added wontfix, feel free to close this if you can't figure out a good way to grab the touchpad device


Correction of misleading links in the metadata chapter

In the metadata section of the Guidelines, there are numerous links that point to the beginning of Chapter 3, but not to the relevant subchapters that are supposed to describe the respective elements in more detail. Example: physDesc. Here, reference is made to chapters 3.1.4 Manifestations and 3.3 Manuscript Descriptions, but the links lead to nothing for the user.

Just a hint @kepper : In the element specs for <physDesc> the second backlink to the guidelines is encoded in the page as
3.3 Manuscript Descriptions.
Maybe the quotation marks around the id are the problem because the id #"msdesc" can not be fount on the page. I've not checked yet if all cases have exactly this problem., but if yes, a regex like #\"\w{1,}\" coould help to detect them for fixing all the links.

2021-06-24 ODD Thursday: @riedde thanks for the hint! Did you have the testing it? Of course we'd be happy to receive a pull request with a fix ;-)

@bwbohl I just tested if the regular expression matches. I didn't searched for all broken links.

@riedde Just to be sure: Which version of the guidelines are your referring to? MEI4, dev, both?

Oh sry, this issue came up on a discussion on the MEI4 Guidelines.

And are the links working in dev?

As I know the problem just occurs in v4.
Looking at the element definition of physDesc: broken in v4, working in dev.

Thank you @riedde .
There seems to be some really confusing and major reference issue in v4: The backlinks in <physDesc> are referencing the following sub-chapters with the following links:

Backlink name
Backlink value

3.1.4 Manifestations
https://music-encoding.org/guidelines/v4/content/metadata.html#headerManifestationList

3.3 Manuscript Descriptions
https://music-encoding.org/guidelines/v4/content/metadata.html#%22msdesc%22

8.1.3 Transcription of Titlepages`
https://music-encoding.org/guidelines/v4/content/lyricsperfdir.html#sharedTitlePages

But none of these mentioned sub-chapters are actually correct (3.1.4 and 8.1.3 do not exist at all (!), 3.3 is named differently: Common Metadata Concepts). While the link values for (non-existing) 3.1.4 and 8.1.3 chapters would technically work, the referenced ids do not exist in the target document. The referenced id for 3.3 is not working, as @riedde pointed out, because of the quotation marks, but without quotation marks would exist in the target document... obviously as an id to section 3.7 Encoding Sources in MEI (!)

@kepper Is this connected to #749 or do you see any other reason for this behaviour?

Totally, there are 24 references to the quotation-marked msdesc id: https://github.com/music-encoding/guidelines/search?p=3&q=%26%2334%3Bmsdesc%26%2334%3B which are all made from different elements within v4/elements/....
A possible issue with the regex approach above could be that there seem to be indeed valid occurences of quotation marks in the guidelines: https://github.com/music-encoding/guidelines/search?q=%26%2334%3B*%26%2334%3B
So it's hard to find out if there any other quotation-marked id's like the msdesc one.

I don't think this is related to the search issues from #749. Without having had a closer look, I would assume this is coming either from re-arranging the chapters, from preserving v4 as a static dump of the old markdown-based approach, or from a combination of these two…?!

With some digging it seems that the changes to the physDesc backlinks were introduced with https://github.com/music-encoding/guidelines/commit/e33fb8a46b66c24244aa3a746ac499c4252cf349 here: https://github.com/music-encoding/guidelines/commit/e33fb8a46b66c24244aa3a746ac499c4252cf349#diff-d687b90d739509675e8020f2664e9e0080f3e8306e9d48ecb66d3993d3da2ca7L16-R16

Maybe, but that won't help anymore – v4 is static content, and cannot be re-generated easily. Maybe we can use this to make sure a semi-automatic approach like @riedde's regex catches everything, but this will require some manual work :-/

@kepper I could try to fix the static content (using the regex), but I would need a hint where I could find those files.
And yes, @musicEnfanthen , sometimes there are links refering to something that does not exist... The "main" capter those links refer to seems to be correct, as I can see.

There is a total of 55 quoted fragment id's:

fragment
in spec

/guidelines/v4/content/analysisharm.html#"analysis"
encodingdesc

/guidelines/v4/content/scholarlyediting.html#"critApp"
choice

/guidelines/v4/content/scholarlyediting.html#"editTrans"
add, choice, corr, del, orig, reg, sic, unclear

/guidelines/v4/content/textencoding.html#"figTable"
td, th, tr

/guidelines/v4/content/metadata.html#"header"
altid, encodingdesc, extmeta, filedesc, manifestationlist, meihead, revisiondesc, worklist

/guidelines/v4/content/lyricsperfdir.html#"lyricsDesc"
layer, measure, syl

/guidelines/v4/content/metadata.html#"msdesc"
availability, bibllist, classification, componentlist, contents, creation, editionstmt, extmeta, head, history, identifier, item, itemlist, langusage, locusgrp, manifestation, notesstmt, physdesc, physloc, pubstmt, relationlist, seriesstmt, source, titlestmt

/guidelines/v4/content/textencoding.html#"namesDates"
corpname, date, geogname, name, periodname, persname, stylename

The algorithm to resolve this would be to

go to all such links
retrieve the ID to be looked up
identify the corresponding chapter in /v4/content
retrieve the correct number and file name from there
insert it in the element page

Since HTML is not xml-compliant, my favorite tool (XSLT) is of limited use here. I could try another apporach here, but maybe someone with proper python-skills would be faster?

Probably we should move this issue to the guidelines repository?

This is something that does not affect v5. We need to decide how to proceed with that issue and provide a backwards fixing for the v4 guidelines if someone finds the time to fix those more than 400 links.
In general, I would prefer to move the issues from the guidelines repo into this repo here, because there they do not get any attention.

Thanks to @krHero, this issue has been fixed. 🎉


st2 --debug outputs URLs that are not accessible from remote hosts

When trying to determine what the CLI command st2 is doing behind the scenes (and also help learn the API) i often use the --debug flag. However, the URLs shown in this output are only accessible when running commands on the stackstorm host and NOT from an external host:
Example output from an st2 command:
[root@stackstorm .st2]# st2 --debug timer list
# -------- begin 60551632 request ----------
curl -X POST -H  'Connection: keep-alive' -H  'Accept-Encoding: gzip, deflate' -H  'Accept: */*' -H  'User-Agent: python-requests/2.11.1' -H  'content-type: application/json' -H  'Content-Length: 2' -H  'Authorization: Basic xxx' --data-binary '{}' http://<IP_ADDRESS>:9100/tokens
# -------- begin 60551632 response ----------
{"user": "st2admin", "token": "2e325ed4358145aab40fd9e4f3cd84b2", "expiry": "2017-04-11T21:49:01.976485Z", "id": "58ebfdcda814c00d538869c2", "metadata": {}}
# -------- end 60551632 response ------------

2017-04-10 17:49:01,984  DEBUG - Token has been cached in "/root/.st2/token-st2admin"
# -------- begin 60552208 request ----------
curl -X GET -H  'Connection: keep-alive' -H  'Accept-Encoding: gzip, deflate' -H  'Accept: */*' -H  'User-Agent: python-requests/2.11.1' -H  'X-Auth-Token: 2e325ed4358145aab40fd9e4f3cd84b2' http://<IP_ADDRESS>:9101/v1/timers
# -------- begin 60552208 response ----------
[{"uid": "trigger:core:31ae9d8d-a8dd-46d9-89b0-7fca830ee4e4:889c1c0b04f53100997af85f35ad3979", "parameters": {"unit": "seconds", "delta": 5}, "name": "31ae9d8d-a8dd-46d9-89b0-7fca830ee4e4", "type": "core.st2.IntervalTimer", "id": "58c9debfa814c063ec62970a", "pack": "core"}]
# -------- end 60552208 response ------------

+--------------------------+------+--------------------+--------------------+--------------------+
| id                       | pack | name               | type               | parameters         |
+--------------------------+------+--------------------+--------------------+--------------------+
| 58c9debfa814c063ec62970a | core | 31ae9d8d-a8dd-46d9 | core.st2.IntervalT | {u'unit':          |
|                          |      | -89b0-7fca830ee4e4 | imer               | u'seconds',        |
|                          |      |                    |                    | u'delta': 5}       |
+--------------------------+------+--------------------+--------------------+--------------------+

If you try to copy and paste those curl commands to an external host they fail with an error Connection Refused:
$ curl -X POST -H  'Connection: keep-alive' -H  'Accept-Encoding: gzip, deflate' -H  'Accept: */*' -H  'User-Agent: python-requests/2.11.1' -H  'content-type: application/json' -H  'Content-Length: 2' -H  'Authorization: Basic xxx' --data-binary '{}' http://<IP_ADDRESS>:9100/tokens
curl: (7) Failed connect to <IP_ADDRESS>:9100; Connection refused
$ curl -X GET -H  'Connection: keep-alive' -H  'Accept-Encoding: gzip, deflate' -H  'Accept: */*' -H  'User-Agent: python-requests/2.11.1' -H  'X-Auth-Token: 2e325ed4358145aab40fd9e4f3cd84b2'
curl: (7) Failed connect to <IP_ADDRESS>:9100; Connection refused

Looking at the nginx config /etc/nginx/conf.d/st2.conf reveals several things:

http is redirected to https, so all urls should be https:// instead of http://
all urls in the curl output destined for port 9101 (api) should be prefixed with /api/
all urls in the curl output destined for port 9100 (auth) should be prefixed with /auth/
all urls in the curl output destined for port 9102 (stream) should be prefixed with /stream/v1/ (not 100% sure about this one, there's some magic going on here and i haven't seen any curl commands with stream URLs to test with).

Should/could the output of st2 be updated to show the proper url for accessing the API from an external host?
I'm more than happy to do the work, i would just like some direction on how this should be handled.

Looks like the code that's outputting these URLs is here: https://github.com/StackStorm/st2/blob/master/st2client/st2client/utils/httpclient.py#L143-L165

You can adjust both api and auth URLs used by st2 cli via environment variables or via ~/.st2/config file. This way CLI with debug enabled will show updated URLs.
See https://docs.stackstorm.com/reference/cli.html for more info.
Example with ~/.st2/config:
[api]
url = https://your-domain/api/

[auth]
url = https://your-domain/auth/

Example with env variables:
ST2_API_URL=https://your-domain/api/ ST2_AUTH_URL=https://your-domain/auth/ st2 --debug action list

You can find/configure remote endpoints in nginx config which is located in /etc/nginx/conf.d/st2.conf if you installed StackStorm with our installer.
Hope that helps.

It would be great to have those documented in https://docs.stackstorm.com/reference/cli.html as you described.
Currently the documentation simply points to server:9100 and the like.

~/.st2/config options like [api] url and [auth] url as well as environment variable like ST2_API_URL are included in https://docs.stackstorm.com/reference/cli.html
Those are actual StackStorm API endpoints which CLI client st2 tries to access.
But yeah, if you see an improvement, - feel free to open a Pull Request in https://github.com//StackStorm/st2docs/blob/master/docs/source/reference/cli.rst
Since it's OSS, contributions are very welcome! :+1:

Perfect, i didn't realize there was another repo that controlled the documentation!
I'll create a PR tonight.
Thanks!


pci: properly scan all device resources

The change in commit e5349d74ab12d3a4c6c87f8723ed3c9a5355ae1b
results in only one resource being returned for a device with
pci_bus_scan(). The root cause for that issue was actually
because of wrapping around when scanning through BARs, where
BARs were scanned 0->1->2->..->6->0->1->.. in an endless loop
for a single bus:dev.function. So revert that commit and put
in a fix by moving on to the next function after going
through all the BARs.
Fixes #1550
Signed-off-by: Daniel Leung<EMAIL_ADDRESS>

Codecov Report

Merging #14237 into master will decrease coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #14237      +/-   ##
==========================================
- Coverage   52.02%   51.98%   -0.04%
==========================================
  Files         307      307
  Lines       45484    45484
  Branches    10535    10535
==========================================
- Hits        23662    23646      -16
- Misses      17030    17042      +12
- Partials     4792     4796       +4

Impacted Files
Coverage Δ

subsys/testsuite/ztest/include/ztest_assert.h
38.88% <0%> (-38.89%)
:arrow_down:

subsys/testsuite/ztest/src/ztest.c
65.28% <0%> (-7.44%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5ac2461...addc1da. Read the comment docs.

Nothing's wrong... was thinking about the relationships between pci_dev_scan() and pci_bus_scan(), and thought that func++ should be in pci_bus_scan(). But given a deep thought, putting the increment is pci_dev_scan() is correct since this function goes through all the functions too.


New In Chrome 62

Whoops!
There were 2 warnings that will prevent this PR from being merged. Please take a look, and either fix, or provide a justification for why they can't be fixed.
WARNINGS
src/content/en/updates/2017/10/nic62.md - No wf_blink_components field found in metadata. Add if appropriate.
src/content/en/updates/2017/10/nic62.md#L159 - Updates post is missing comment widget: {% include "comment-widget.html" %}

Whoops!
There were 2 warnings that will prevent this PR from being merged. Please take a look, and either fix, or provide a justification for why they can't be fixed.
WARNINGS
src/content/en/updates/2017/10/nic62.md - No wf_blink_components field found in metadata. Add if appropriate.
src/content/en/updates/2017/10/nic62.md#L159 - Updates post is missing comment widget: {% include "comment-widget.html" %}


Documentation or pointers in using release-it in javascript (node 8)

Hi,
After reading the issues it appears that it is supported to call the release-it in javascript using node v8 or later.
Could anyone let me know some further info, any documentation?
I saw this in the issues, anything else I can do ?
Or is it a case of looking inside the javascript file ?
I presume this is the same package as the cli ?
const ReleaseIt = require("release-it").default
ReleaseIt({
  "non-interactive": true,
  npm: {
    publish: false
  }
}).then(…)

Thanks in advance

Yes, this is an undocumented feature indeed. Feel free to use it though, I'll document it shortly.
For now, this is the object the promise resolves with when release-it is done: https://github.com/webpro/release-it/blob/c6d079f7d6bce287b6bf5b48dbf250ab6aed27c8/lib/tasks.js#L213-L217
I'll keep this issue open until it is documented.


feat(#112): Support nonzero execute exit codes via --execute-non-zero

Adds a --execute-non-zero flag that, when set, doesn't error when a --execute commands has a nonzero exit code. This allows you to capture the output of commands that are expected to nonzero exit, such as mkdir ., as a toy example.
Please let me know if there's anything else you'd like me to change in this PR!
Fixes https://github.com/charmbracelet/freeze/issues/112

We need this!

this is usually coded with --exit-code that default to 1, if someone wants 0 they can use it

@ccoVeille could you clarify? Do you mean instead of --execute-non-zero change this to --exit-code (default to 0), which someone would override to --exit-code=1?

I misunderstood what you implemented, I'm sorry. I will let you decide if there is still a need.
git, golangci-lint do like this. And many more.
https://github.com/search?q=language%3Amarkdown+"--exit-code"&type=code
I find the parameters more obvious than defining something by its opposite.
But your need is different

literally just hit this - was pretty sad when i realized I couldn't use freeze to "screenshot" error output.


Error when creating .rt file

I installed the plugin for WebStorm, enabled it, and when I right click to create a new file I use the RT file type, it prompts me for a name, which I provide, and then I get the error below.  The files don't show in the file browser, but if I try to create it again it says the file already exists.  I checked, and it does exist.  Well, THEY exist, as the file also has its .js equivalent present as well.
"Argument for @NotNull parameter 'stream' of com/intellij/openapi/util/io/FileUtil.loadTextAndClose must not be null"

Additional info.  I had left off that I had set the output module system to ES6.  I changed it back to AMD and it is working.  I'd like to be able to use ES6 as I was trying to get up and running with ES2015.  Any ideas?


"Șelaru", "Fierbinți", "Glogoveanu" are listed in the drop-down menu

Description:
When user writes ”Șelaru”, "Fierbinți" and "Glogoveanu" the locations appear in the drop-down menu next to the comune and the county which is a part according to the law.
Precondition:
The website is up an running.

Step 1
Write in the search bar "Șelaru"

Expected results
The location appears in the drop-down menu as "Sat Șelaru, DÂMBOVIȚA (Șelaru)".

Step 2
Press "x" button.

Expected results
The location was deleted from the search bar.

Step 3
Write in the search bar "Fierbinți"

Expected results
The location appears in the drop-down menu as "Sat Fierbinți, DÂMBOVIȚA (Șelaru)".

Step 4
Press "x" button.

Expected results
The location was deleted from the search bar.

Step 5
Write in the search bar "Glogoveanu"

Expected results
The location appears in the drop-down menu as "Sat Glogoveanu, DÂMBOVIȚA (Șelaru)".


Misleading documentation for selecting a theme when creating a new project

The documentation says you can choose between --theme mars-theme or --theme twentytwenty-theme but that does not work, the cli seems to expect NPM package name even for the official themes (@frontity/twentytwenty-theme. and @frontity/mars-theme).

Good catch @nicholasio
Fixed in https://github.com/frontity/docs/pull/208
You can see the final doc here


Rollback issue about mending experience level,

Timings link
No response
Expected behavior
The experience decreases sequentially to the anvil and mending.
Observed/Actual behavior
Mending is operated as an experience before using the anvil.
30lv(1,395xp) -> use anvil and level decrease to 26lv -> use mending with shift+right click -> roll back to 30lv and use exp for mending (in my case, its 5xp)
Steps/models to reproduce

Enable shift-right-click-repairs-mending-points: 5
Use an anvil to consume experience.
Repair(with mending) the equipment with Shift + Right Click like option 1.
In the experience value before using the anvil, the experience value decreases as much as used for bending.

Purpur version
This server is running Purpur version git-Purpur-1394 (MC: 1.17.1) (Implementing API version 1.17.1-R0.1-SNAPSHOT) (Git: acb8a26 on ver/1.17.1)
You are running the latest version
Previous version: git-Purpur-1393 (MC: 1.17.1)
Agreements

[X] I am running the latest version of Purpur available from https://purpur.pl3x.net/downloads.
[X] I have searched for and ensured there isn't already an open issue regarding this.
[X] My version of Minecraft is supported by Purpur.

Other
No response

Been a month since a response


Improve "odo create service" command to create a service (fix #721)

Improve odo create service command  (fix #721) to specify <service_type>/<plan>.
Add a parameter type and new command option to define the plan's parameters
Extend the CreateServiceInstance and CreateService functions to accept as new parameters: plan string, parameters interface{}
Add 2 new functions to the util.go file in order to generate a Map of string from Array of strings and to generate a json object from parameters

End to end test case tested successfully -> https://github.com/snowdrop/spring-boot-cloud-devex/blob/master/examples/persistence-service-catalog.md

Please also fix the travis failures

@cmoulliard would you like me to take over this PR and attempt to move it forward by addressing the concerns that have been put forth during the review?

@kadel What is the strategy currently being employed in the project regarding unit tests? Which methods need unit tests?

@cmoulliard @kadel I have rebased the PR onto the current master and also addressed most of the issues mentioned here.
I will continue to address the rest of the issues on Monday.

@kadel @cmoulliard I believe I have  addressed some (most?) of the concerns specified in this review and also reran the scenario the end-to-end scenario.
Can you please review?

I just saw that I need to improve the devex on this.
Basically the plan flag should be required, but not in the way it's implemented now, since currently the user can't know which plans are available.
So tomorrow I will change the code to show the available plans of the selected service when the user has not selected a plan

The error messages have now been improved to include the valid plans

@geoand , can you provide us a an example to test this PR ?

If anyone has any other simple example that uses a DB, I'd be glad to test it

hi @geoand It looks like you will have to update tests - https://travis-ci.org/redhat-developer/odo/jobs/442523401

@kadel Will, last time I checked they were passing, but I guess I changed something :P

@kadel Fixed, my go n00b mistake with the log formatting :P

Seems like there is another issue, I'll fix it

I need to rebase this PR onto master in order to fix the issues

PR rebased onto current master. The tests should now be fixed

I have just updated the error messages during that might occur during odo link, but that got me thinking.
Should we perhaps make odo service create... wait until the service has actually been provisioned?
Waiting would be beneficial perhaps for users, so they don't try to use the service before it has been provisioned. Also it would be great for environments where odo is being used as part of scripts.
WDYT @jorgemoralespou @kadel @cmoulliard @metacosm ?

@kadel I like your suggestion a lot.
Waiting for the secret to be created does make perfect sense.
I will see if this can be done quickly, but if it's tricky, I propose that we follow up this PR with another that will contain such an enhancement.
How does that sound?

It looks like there is something strange with Secret naming
I've created service called mymysql.
link failed because for some reason secret is called mysql not mymysql as would one expected :-(
▶ odo  service create  mysql-persistent mymysql
Service 'mymysql' was created.

▶ odo service list
NAME        TYPE                 STATUS
mymysql     mysql-persistent     Provisioning

▶ odo service list
NAME        TYPE                 STATUS
mymysql     mysql-persistent     ProvisionedSuccessfully

▶ odo link mymysql
Secret mymysql should have been created along with the service!
If you previously created the service with 'odo service create...', then you might have to wait a few seconds until Openshift provisions it.
If not, then please delete the service and recreate it using 'odo service create mymysql%

▶ oc get secrets
NAME                                   TYPE                                  DATA      AGE
builder-dockercfg-7k5g5                kubernetes.io/dockercfg               1         31m
builder-token-b4lqx                    kubernetes.io/service-account-token   4         31m
builder-token-cq8mq                    kubernetes.io/service-account-token   4         31m
d12fa033-d205-11e8-a200-0242ac110007   Opaque                                0         4m
default-dockercfg-tbc5p                kubernetes.io/dockercfg               1         31m
default-token-fp4jw                    kubernetes.io/service-account-token   4         31m
default-token-z4tk5                    kubernetes.io/service-account-token   4         31m
deployer-dockercfg-4vfn5               kubernetes.io/dockercfg               1         31m
deployer-token-trqpj                   kubernetes.io/service-account-token   4         31m
deployer-token-xq766                   kubernetes.io/service-account-token   4         31m
mysql

It looks like odo service delete is also working :-(
▶ odo service delete mymysql
Are you sure you want to delete mymysql from app? [y/N] y
Service mymysql from application app has been deleted

▶ odo service list
NAME        TYPE                 STATUS
mymysql     mysql-persistent     DeprovisionBlockedByExistingCredentials

I had to manuly delete servicebindings and run odo service delete again.
▶ oc delete servicebindings mymysql
servicebinding.servicecatalog.k8s.io "mymysql" deleted

▶ odo service list
NAME        TYPE                 STATUS
mymysql     mysql-persistent     DeprovisionBlockedByExistingCredentials

▶ odo service delete mymysql
Are you sure you want to delete mymysql from app? [y/N] y
Service mymysql from application app has been deleted

▶ odo service list
There are no services deployed for this application

@kadel I am pretty sure that we you will see an mymysql secret after a little while. Can you please check again?
I am still not sure why there are 2 secrets being created though...

@kadel I am pretty sure that we you will see an mymysql secret after a little while. Can you please check again?
I am still not sure why there are 2 secrets being created though...

I've just noticed that. It looks like i was just too quick. Yep, It weird, I don't have any idea where mysql service is commig from

@kadel I am pretty sure that we you will see an mymysql secret after a little while. Can you please check again?
I am still not sure why there are 2 secrets being created though...

I've just noticed that. It looks like i was just too quick. Yep, It weird, I don't have any idea where mysql service is commig from

I'll try it again for both mysql and postgres and see what I can find. Then I will look at the delete issue

@kadel Deleting a service should now work

Thank you for your thorough review @kadel!!! :+1:
Whatever issues you open regarding to this, feel free to assign them to me :)

Thanks @cdrage!
The issues you mentioned have been fixed

Let's merge! :100: :100: :tada:
Thanks everyone for the great contributions.


How to track changes to windows-2019

Describe the bug
Our team's CI automatically started using VS 16.6. We started to see our code fail to build due to a confirmed regression in the compiler. The readme on the front page says it's still using 16.5.
The "receive updates" links on the readme just mention general github changes (i.e. feature updates), not updates to specific images like windows-2019.
a) how can we know what changes to the windows-2019 image are coming in and when
b) is it possible to set a version of VS so that it doesn't get updated as often? we've been burned by regressions in VS's compiler/linker/packaging pretty much every release.
Area for Triage:
Deployment/Release
Question, Bug, or Feature?:
Question
Virtual environments affected

[ ] macOS 10.15
[ ] Ubuntu 16.04 LTS
[ ] Ubuntu 18.04 LTS
[ ] Windows Server 2016 R2
[X] Windows Server 2019

Hello @asklar,
In order to track status and software installed on upcoming releases, you can table in the main page of virtual environment project and click on "Latest Release & Rollout Progress" for required release.
If additional information is required, please let us know.

Thank you @Darleev - is there a way to stay on a LKG version of an image or VS? Like I mentioned, we've been burned badly with every minor VS release...

@asklar there is no way to preserve Visual Studio version since we always have actual one. As a possible solution, you can consider deploying self-hosted agents with desired version.

In order to track status and software installed on upcoming releases, you can table in the main page of virtual environment project and click on "Latest Release & Rollout Progress" for required release.

I've noticed that there is JSON version of current status: https://actionvirtualenvironmentsstatus.azurewebsites.net/api/status
Am I correctly understood that sum_count_ is current runner count with specified image? So now 20200531.1 has 201 runners, 20200524.1 has 364 runners and 20200517.1 has 480 runners?
    {
      "DisplayName": "windows-2019",
      "ImageVersion": "20200517.1",
      "readMeUrl": "https://github.com/actions/virtual-environments/blob/releases/win19/20200517/images/win/Windows2019-Readme.md",
      "sum_count_": 480
    },
    {
      "DisplayName": "windows-2019",
      "ImageVersion": "20200524.1",
      "readMeUrl": "https://github.com/actions/virtual-environments/blob/releases/win19/20200524/images/win/Windows2019-Readme.md",
      "sum_count_": 364
    },
    {
      "DisplayName": "windows-2019",
      "ImageVersion": "20200531.1",
      "readMeUrl": "https://github.com/actions/virtual-environments/blob/releases/win19/20200531/images/win/Windows2019-Readme.md",
      "sum_count_": 201
    },

@RadRussianRus , it is pretty unusual situation.
Previous week, we have started deployment of 20200524.1 but didn't deploy this image fully due to bug with new version of Azure CLI #948 so this image is deployed on part of agents.
Currently, we are deploying new image (20200531.1).
Usually, link above shows two images. Current one and upcoming

I actually was interested what sum_count_ means, but that's interesting too.
My hopes that 20200531.1 will fix infinite building bug (example) and builds with Visual Studio 16.6.

@RadRussianRus do you have more context on what that infinite building bug is? did you file a VS bug at DeveloperCommunity?

Sadly, no. I only know that it happens only on GitHub Actions windows-2019 image version 20200524.1. On desktop it works fine. If it will happen in 20200531.1, I'll file a proper bug report.

@asklar @RadRussianRus since the initial issue has been resolved, and there are no questions, I'm going to close the issue.
In case of any issues, do not hesitate to contact us.


getPaths: Only find up to maxPaths

Currently getPaths calculates all possible paths through a function and then truncates them to maxPaths. Finding all paths for large and complex functions can take a very long time. Ideally, the function would shortcut the path exploration when maxPaths have been found.

addressed in https://github.com/fireeye/flare-emu/commit/0cc6b0b73feba3ffdd83e0892b18b9b4fcbe0403


Possible error in copy paste action in detection AWS_CreatedCURDLambdaPolicytoPrivilegEscalation.yaml

I don't know if "lambda:Delete" is a valid action, please, could you check with the original author?
Required items, please complete
Change(s):

Change kms by lambda

Reason for Change(s):

I believe KMS and Lambda might not be related for this detection, and there was a mistake copypasting a previous detection.

Version Updated:

Yes

Testing Completed:

I don't know if "lambda:Delete" is a valid action, please, could you check with the original author?

Checked that the validations are passing and have addressed any issues that are present:

Yes

It seems to be Delete actions in lambda, but I still think the original author should be consulted.

Hi @ep3p, have you tested the rule after making these changes?

@v-rbajaj The query is valid and the changes makes sense. But this type of error is a detection logic error. The only way to solve this is asking the original author what was the original intention of this detection, if maybe they commited a mistake copypasting.


Add a micropython mqtt reader adapter

While trying to implement a light strip InputThing, I found in need of a mqtt reader adapter.

I'll be submitting a PR for this issue

Cool!
On Sun, Aug 6, 2017 at 1:46 PM, Daniel Mizyrycki<EMAIL_ADDRESS>wrote:

I'll be submitting a PR for this issue
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/mpi-sws-rse/thingflow-python/issues/5#issuecomment-320531612,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAFSEBZKPna3QDFQYK-IYxs9LPYh9Zrgks5sViYagaJpZM4Ou1kv
.


Update smoke tests and Ace editor

Description
This PR has 3 fixes, the first one is the actual JIRA issue, the second one was blocking the first one, and the third one was noticed while investigating.

The cy.wait() in basic-enduser.ts seems to fix the import error causing flaky tests; hard to tell for sure with flaky bugs, but it worked for me 10 times in a row locally. My theory is that the new, faster Cypress 12 was clicking away from the editor while the editor was still synchronously downloading a JS file, and the aborted download caused the tests to fail.
PR #1704 broke smoke tests on qa only because it changed svg to img for the launch with images. Changed the selector to look for either svg or img, so it will run on both qa and staging/prod. Created a followup ticket, dockstore/dockstore#5372 to remove the check for svg after 1.14 is released.
We are now bundling the ACE editor worker files. This fixes a version mismatch I noticed -- the package-lock.json was bundling ACE editor 1.4.14, but our code was download the worker scripts from 1.4.4. Our files are on a CDN as well, so there's no real performance advantage to downloading them from CloudFlare, plus now we'll be certain the worker scripts are the same version as the core Ace editor.

What are the Ace worker scripts?
I'm hazy on the details, but they're JavaScript files that are downloaded synchronously by the editor itself. Since they are downloaded by name, I put them in the assets directory instead of putting them into one of the JavaScript bundles. In other words, ACE downloads, for example, worker-json.js. Now it will download it from Dockstore instead of CloudFlare.
Review Instructions
Nightly no_auth_tests on CircleCI should pass (auth_tests already passing).
Go to the editor (Files tab) for different file types, published and non-published entries, with browser tools open, and make sure there are network errors.
Issue
https://ucsc-cgl.atlassian.net/browse/SEAB-5240
Security
If there are any concerns that require extra attention from the security team, highlight them here.
Please make sure that you've checked the following before submitting your pull request. Thanks!

[x] Check that your code compiles by running npm run build
[x] Ensure that the PR targets the correct branch. Check the milestone or fix version of the ticket.
[x] If this is the first time you're submitting a PR or even if you just need a refresher, consider reviewing our style guide
[x] Do not bypass Angular sanitization (bypassSecurityTrustHtml, etc.), or justify why you need to do so
[x] If displaying markdown, use the markdown-wrapper component, which does extra sanitization
[x] Do not use cookies, although this may change in the future
[x] Run npm audit and ensure you are not introducing new vulnerabilities
[x] Do due diligence on new 3rd party libraries, checking for CVEs
[x] Don't allow user-uploaded images to be served from the Dockstore domain
[x] If this PR is for a user-facing feature, create and link a documentation ticket for this feature (usually in the same milestone as the linked issue). Style points if you create a documentation PR directly and link that instead.
[x] Check whether this PR disables tests. If it legitimately needs to disable a test, create a new ticket to re-enable it in a specific milestone.

2. PR Tool/Workflow Sidebar Updates - SEAB-5165 #1704 broke smoke tests on qa only because it changed svg to img

Apologies, thanks for resolving Charles :)


[Suggestion] Rename KEYS or keys

Most Unix-style OSs are case-sensitive in file names, meaning that a folder called KEYs is different from a file named keys.
However, Mac OS is not case-sensitive. So whenever developers clone a new repo, the system will delete the folder keys, and a freshly cloned repo may look messy.

The keys folder seems reasonable.  How about renaming the file to, for example, PGP_KEYS, "DEVELOPER_KEYS"?


Abundant broken spawners

Hello,
So I have been playing a SSP map with this mod as well as RotartyCraft. I have been experiencing a 100% drop rate of broken spawners while using both the HLSA steel and bedrock pics. Both un-enchanted. Just wanted to share since I know they are chance based.

No they aren't...? Broken spawners drop 100% of the time.

Thanks. Made me check through the configs and found its an option. Ends up its a config setting. Looks like my last pack had it less the 1 chance which made me think otherwise.


I am getting this error when i try download full series or range of episodes from any site.

I am able to download single episode, but getting the same error when trying to download full series.
I either get the error or download doesn't start after selecting choice.
Img link : https://imgur.com/FHTEPJR

To reproduce

anime dl "dragon ball super" --quality 720p --download-dir "E:\projects"

LOG
```

Same issue. However it works if i use --provider animepahe .

Animepahe works, but there are no dub episodes and the anime downloader skips some episodes.

9anime does not work for now. All other providers should work fine.

Thanks.


Why 2 VNets in "Scenario 4: On-premises traffic to private endpoints"?

As of now the diagram for "Scenario 4: On-premises traffic to private endpoints" shows 2 VNets with VNet peering.
I am trying to understand why there are/needs to be 2 VNets for the described scenario.
It might be would be good to either a) clarify why there are 2 VNets in this scenario titled "On-premises traffic to private endpoints", or b) update the design so that it uses 1 VNet.
Link to the document:
https://docs.microsoft.com/en-us/azure/private-link/inspect-traffic-with-azure-firewall#scenario-4-on-premises-traffic-to-private-endpoints

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 4038a691-c584-2c36-24c5-fa91a5be474a
Version Independent ID: c6bd0573-22ef-f1d5-5553-000bd8f8c1bd
Content: Use Azure Firewall to inspect traffic destined to a private endpoint - Azure Private Link
Content Source: articles/private-link/inspect-traffic-with-azure-firewall.md
Service: private-link
GitHub Login: @jocortems
Microsoft Alias: allensu

@rukasakurai , thank you for your query. We'll review this and get back to you shortly!

@rukasakurai , there is no specific reason for the use of 2 Vnets in Scenario 4. In the article, you can see 3 different scenarios with Vnet only model and the most expandable architecture to connect privately to multiple Azure services using private endpoints is scenario 1 where you have a dedicated Vnet for private endpoint as that configuration reduces administrative overhead and prevents running into the limit of 400 routes.
Hence, the same was used in scenario 4. You are free to use scenario 2 or scenario 3 with your on-premises setup depending upon your existing architecture & requirement.
We are closing this issue for now. If there are further questions regarding this matter, please reply and we will gladly continue the discussion.


⚠ Bofrost.be has degraded performance

In 6cd49b4, Bofrost.be (https://www.bofrost.be) experienced degraded performance:

HTTP code: 200
Response time: 1271 ms

Resolved: Bofrost.be performance has improved in e3ab032 after 20 minutes.


Set up unit tests

I've started the implementation and help / feedback is welcome https://github.com/stefanbuck/atom-shell-starter/tree/add-tests
The goals are:

[ ] Add Jasmine for the render / "front-end"
[ ] Add Mocha or something similar for the browser / "back-end"
[ ] Set up for Travis

[ ] Mac
[ ] Windows
[ ] Linux

@stefanbuck This Issue title is super unclear, mostly it was a note to myself. This TODO isn't to set up unit tests for atom-shell-starter itself, it's to set up the framework for people who use atom-shell-starter to write unit tests for their apps. i.e. the end goal is, that someone using atom-shell-starter can just start writing Jasmine tests, then run script/test or something and see them pass/fail.
The TODO would look something like (copied from the non-OSS app I'm writing where we did this):

[ ] Set up the build system for tests
[ ] Rig up app startup so that we can run tests
[ ] Set up the test framework inside a Renderer context
[ ] Rig a menu item that will run unit tests on-demand
[ ] Pop a Window with Jasmine rigged up which starts executing tests
[ ] Port the Atom spec runner Grunt task

Ahh now I understand. Sound pretty good and I need this :) Any plans to implement this "soon"? If you need help shout.

I'm looking for this as well so might take a stab at this.


Expose RCTTest for consumers via CocoaPods

Enables using RCTTestRunner in app code.

@facebook-github-bot shipit

Thanks!


Send Grid failing on multiple levels

Issue number one can't login to sendgrid.com with valid credentials created in the Azure portal. Why?
When I first started using Send Grid several years ago, it work perfectly. Now it very cumbersome and only 50% reliable.
I also have an existing ticket that I have not heard back from two weeks now about not being able to authenticate my domain. I'm not sure if the issue with GoDaddy or you guys.

Hello @Supertroop6
Thank you for your patience. This does appear to be a support issue more than a docs issue. Do you have a support ticket number? We can ask support about following up.
Best,
Twilio SendGrid Docs Team

Hello @Supertroop6
We hope you've made progress with your issue. If you still need assistance, please add more details and feel free to reopen this Issue.


⚠ Bofrost.at has degraded performance

In d8ebf02, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 1966 ms

Resolved: Bofrost.at performance has improved in d527048.


Allow CSV reader to read max_depth from CmdStan CSV file (take 3)

Submission Checklist

[x] Run unit tests: ./runTests.py src/test/unit
[x] Run cpplint: make cpplint
[x] Declare copyright holder and open-source license: see below

Summary
NOTE: This is a version of the original pull request. Unfortunately, original pull request got messed up due to accidentally adding a commit regarding the lib/stan_math submodule and subsequent problems introduced on my part to try to fix that, so a new pull request has been made.
This is a prerequisite needed to fix the bug described in https://github.com/stan-dev/cmdstan/issues/646 and implements the modifications to the CSV reader described in https://discourse.mc-stan.org/t/modifying-stan-csv-reader-to-fix-a-problem-in-cmdstan/5307.
Copyright and Licensing
Please list the copyright holder for the work you are submitting (this will be you or your assignee, such as a university or company): Myself, i.e., J. J. Ramsey
By submitting this pull request, the copyright holder is agreeing to license the submitted work under the following licenses:

Code: BSD 3-clause (https://opensource.org/licenses/BSD-3-Clause)
Documentation: CC-BY 4.0 (https://creativecommons.org/licenses/by/4.0/)

woo! Thanks for your patience and dedication :)

@seantalts I can't merge stan-dev/stan things anymore, who merges these now?

That's weird... if you can approve, I would have thought you could merge...


RSDK-4844 Add better boilerplate for module development

RSDK-4844

Renames ModuleService_ to ModuleService
Adds a std::shared_ptr<Server> server_ field to ModuleService

ModuleService::server_ is created (not started) in the constructor
ModuleService::server_ is shutdown in the ModuleService destructor

Removes std::shared_ptr<Server> param from add_model_from_registry and add_api_from_registry
Adds a SignalManager signal_manager_ field to ModuleService
Changes the ModuleService::start(std::shared_ptr<Server>) method to ModuleService::serve() and alters its behavior

serve runs the ModuleService::server_ until the ModuleService::signal_manager_ finishes waiting
serve logs API/model pairs the module handles

Creates a new "boilerplate" overloaded ModuleService constructor ModuleService(int argc, char** argv, std::vector<std::shared_ptr<ModelRegistration>>)

Validates the socket path is present in argv and sets it on the class
Sets global boost logger severity based on presence of the --log-level flag in argv
Registers the passed in ModelRegistration classes' models (not APIs)
Adds models and custom APIs from registry to ModuleService

Adds doc comments to SignalManager and ModuleService and makes more methods private

This change breaks modules so will wait until Monday morning to merge and notify C++ module authors of breaking change.


Replace Select in NavigationDropdown with an accessible menu

This PR:

Replaces the Select element in NavigationDropdown with an accessible menu: follows recommendations for WAI-ARIA practices and fully keyboard functional.
Reduces padding on wrapping container in NavigationAccordion.

How to test
Try out the NavigationDropdown and NavigationAccordion (mobile sizes) test cases.
QA checklist

[x] No errors logged to console.
[x] Accessibility score in Chrome DevTools Audit/Lighthouse is 100% with Lighthouse version: #.#.#.
[x] Component is accessible at mobile-size viewport.
[x] Component is accessible at tablet-size viewport.
[x] Component is accessible at laptop-size viewport.
[x] Component is accessible at big-monitor-size viewport.
[x] Create a PR in a site repo, copy the component, and test it. Push to staging and let the reviewer know they can also test the component there.

Open the test cases app locally on:

[x] Chrome, no errors logged to console.
[x] Firefox, no errors logged to console.
[x] Safari, no errors logged to console.
[x] Edge, no errors logged to console.
[x] IE11, no errors logged to console.
[x] Mobile Safari, no errors logged to console.
[x] Android Chrome, no errors logged to console.

Fixes #248

This branch turned into soup after switching the base branch too many times, going to retry in a new branch.


Fix text size for small screen

issue no #843
Just added media screen css for small screen and fix text size small in small screen.

@Kalivarapubindusree @Its-Aman-Yadav Please check it and merge !


Add Support for Prefilling Callsign via URL Parameters in Logging Window

What Feature is Missing?
I would like to request the addition of a feature in Wavelog that allows the logging window to accept query parameters in the URL to prefill form fields, specifically the callsign. This means that when accessing a URL like:
https://wavelog.example.com/index.php/qso?callsign=SE6S

Wavelog would open the logging window with the callsign field already populated with "SE6S". This functionality would enable external applications or scripts to initiate the logging process with prefilled data, enhancing interoperability.
Why is This Feature Important?
I use an SDR radio (SmartSDR connected to a FlexRadio) that displays spots on its panadapter. When I click on one of these spots, my setup can be configured to automatically open a URL in my browser. If Wavelog could accept the callsign as a query parameter, it would streamline the process of start logging a QSO initiated from my radio. This integration would make starting a QSO by clicking a spot in the panadapter quick and seamless, significantly improving my operational efficiency.
Moreover, this feature would reduce manual data entry errors and save time.
Is This Feature Personal or Beneficial to Others as Well?
While this feature addresses my specific use case, I believe it would be beneficial to many other Wavelog users. Operators who use SDR radios or other equipment that can trigger browser actions would find this integration valuable. It would enable them to:

Enhance Efficiency: Quickly start logging QSOs with prefilled information, reducing the steps required.
Improve Accuracy: Minimize manual data entry, reducing the likelihood of errors.
Increase Flexibility: Allow for better integration with various hardware and software setups, catering to diverse operating styles.

Implementing this feature would make Wavelog more versatile and appealing to a broader user base, encouraging adoption and satisfaction among amateur radio operators who seek seamless integration between their equipment and logging software.

Spots appearing on the SmartSDR Panadapter

Is there documentation about this feature? For example parameter names etc.?

Thanks @HB9HIL
Sounds great and I will test it tomorrow and let you know the results!

Implemented

Dear Wavelog Development Team,
I would like to extend my sincere thanks to you all, (especially to  @HB9HIL) for your excellent work on implementing the feature request. It is clear that you have been responsive to user's needs, and I truly appreciate your attention to detail in making this improvement.
This new API will undoubtedly prove to be incredibly useful, especially for those of us integrating Wavelog with SDR setups like FlexRadio. It will enhance the overall experience, improving both efficiency and accuracy in logging QSOs.
Thank you once again for your dedication to making Wavelog better for the entire community. Your hard work does not go unnoticed!


docs(flexbox layout) add flexbox layout code snippets

Adding FlexboxLayout to the https://docs.nativescript.org/ui/layout-containers article so I think those code snippets need to be added here (so Jekyll can extract them for https://github.com/NativeScript/docs/pull/1008).

run ci

run ci


Cumulative Staleness

Compute not just the number of stale reads, but how stale the read is (e.g. amount of time since write).

Staleness on both reads and writes.
My plan is to measure staleness as the time since the newest write (global, magic simulation computation). Do you want me to include fresh reads as well, or just stale reads? Alternatively (or additionally) I can simply count the number of versions behind the global (t-staleness or version-staleness).


DataGrid is a black rectangle

I changed a working collection view to a Uranium DataGrid, which looks great on my Windows machine. However, when I deploy to my Android phone (with EMUI 12), I see the attached.

I have the same problem

I can't reproduce it currently.
Can you share minimal reproduction steps? Or example code to achieve this visual.

I can't reproduce the code, because when I first started using material:DataGrid it was working fine, and then after developing other functions, this problem suddenly appeared. Part of the reason I can find for now is that I placed material:DataGrid.Columns inside a ScrollView container. This problem occurs when the ScrollView sets the Height, and does not occur if the Height property is removed
<uranium:UraniumContentPage.Attachments>         <material:BottomSheetView   IsPresented="{Binding BottomSheetVisible}">             <ScrollView VerticalScrollBarVisibility="Always"  VerticalOptions="Fill"  Background="#f7f7f7" HeightRequest="400" >                 <material:DataGrid ItemsSource="{Binding Propertys}" HorizontalOptions="Center"  >                     <material:DataGrid.Columns>                         <material:DataGridColumn Binding="{Binding Id}" Title="Id"/>                         <material:DataGridColumn Binding="{Binding FieldName}" Title="FieldName"/>                         <material:DataGridColumn Binding="{Binding FieldAlias}" Title="FieldAlias" />                         <material:DataGridColumn Binding="{Binding FieldValue}" Title="FieldValue" />                     </material:DataGrid.Columns>                 </material:DataGrid>             </ScrollView>         </material:BottomSheetView>     </uranium:UraniumContentPage.Attachments>

If someone shares a project that reproduces the problem, I can take an action on this issue. Otherwise I don't have any guess on it.

This issue is reproducible in iOS.
Android works as expected.
It can be easily reproducible with Uranium UI -> Demo  project. (https://github.com/enisn/UraniumUI/tree/develop/demo/UraniumApp)
With UraniumUI -> Demo project. Select Menu ->Datagrid-> "Custom data grid" in iOS device.
Simple data grid works well, but when columns are customized it fails.
I am using VS 2022 (Version 17.5.4), it was working in VS 17.5.0

Still investigating, it's a strange behavior on Apple devices

I finally get some errors from native implementation on MacOS. It might be related to MAUI Grid implementation, I'll check and update this issue soon
Mono.Debugging.Evaluation.EvaluatorException: System.NotSupportedException: Specified method is not supported.
   at Mono.Debugging.Soft.MethodCall.get_ReturnValue() in D:\a\_work\1\s\external\debugger-libs\Mono.Debugging.Soft\SoftDebuggerAdaptor.cs:line 2890
   at Mono.Debugging.Soft.SoftEvaluationContext.RuntimeInvoke(MethodMirror method, Object target, Value[] values, Boolean enableOutArgs, Value[]& outArgs) in D:\a\_work\1\s\external\debugger-libs\Mono.Debugging.Soft\SoftEvaluationContext.cs:line 205
   at Mono.Debugging.Soft.SoftEvaluationContext.RuntimeInvoke(MethodMirror method, Object target, Value[] values) in D:\a\_work\1\s\external\debugger-libs\Mono.Debugging.Soft\SoftEvaluationContext.cs:line 132
   at Mono.Debugging.Soft.PropertyValueReference.GetValue(EvaluationContext ctx) in D:\a\_work\1\s\external\debugger-libs\Mono.Debugging.Soft\PropertyValueReference.cs:line 131
   at Mono.Debugging.Soft.PropertyValueReference.get_Value() in D:\a\_work\1\s\external\debugger-libs\Mono.Debugging.Soft\PropertyValueReference.cs:line 118
   at Mono.Debugging.Evaluation.ObjectValueAdaptor.GetObjectValueChildren(EvaluationContext ctx, IObjectSource objectSource, Object type, Object obj, Int32 firstItemIndex, Int32 count, Boolean dereferenceProxy) in D:\a\_work\1\s\external\debugger-libs\Mono.Debugging\Mono.Debugging.Evaluation\ObjectValueAdaptor.cs:line 609

Another note: I found a workaround for someone who wants to bind the data after page/window loads (until there is a bugfix):

First, you have to set the ItemsSource property inside the constructor. Most importantly, the collection you are assigning to ItemsSource property needs to have AT LEAST one record (if it is dummy data, then it is up to you to figure out what value to display to the user).
After that, you can use the buttons to update the existing collection (if it is ObservableCollection and has the NotifyPropertyChanged delegates) or assign a new collection to the ItemsSource.

Yep... Having the same problem

Another note: I found a workaround for someone who wants to bind the data after page/window loads (until there is a bugfix):

First, you have to set the ItemsSource property inside the constructor. Most importantly, the collection you are assigning to ItemsSource property needs to have AT LEAST one record (if it is dummy data, then it is up to you to figure out what value to display to the user).
After that, you can use the buttons to update the existing collection (if it is ObservableCollection and has the NotifyPropertyChanged delegates) or assign a new collection to the ItemsSource.

👆 This workaround works for now.
Unfortunately, I couldn't identify the problem. It happens on the native platform and it's hard to debug native controls created by the handler on the native platform. I'll change DataGrid implementation logic soon, this will be solved probably too

I had this problem.
It was caused by having a picker on the page with the datagrid and using a converter on the picker, EnumToIntConverter from the community toolkit I believe. Soon as I got rid of that it started working. Have had loads of problems with converters in maui.

I had this problem. It was caused by having a picker on the page with the datagrid and using a converter on the picker, EnumToIntConverter from the community toolkit I believe. Soon as I got rid of that it started working. Have had loads of problems with converters in maui.

It's a strange case, I'll take a look at this condition, thanks for sharing


feat: support bitpacking for signed types

Adds support for bitpacking for signed types Int8, Int16, Int32 and Int64. In this case, we use one extra bit in the encoding for as the sign bit, and when decoding pad using 1 instead of 0 when expanding the bitpacked buffer

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 79.40%. Comparing base (d75b16f) to head (48a826d).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2662      +/-   ##
==========================================
+ Coverage   79.35%   79.40%   +0.04%
==========================================
  Files         222      222
  Lines       64632    64724      +92
  Branches    64632    64724      +92
==========================================
+ Hits        51290    51394     +104
+ Misses      10365    10356       -9
+ Partials     2977     2974       -3

Flag
Coverage Δ

unittests
79.40% <100.00%> (+0.04%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Current date & time unawareness as input parameters

Hi team,
First of all, this library is amazing!
This looks 75% similar to what I've built myself in my LLM/AI project, but more scalable and simple, amazing job!
Here is my problem, it looks like the LLM (gpt-4) is completely aware of the current date & time, if I prompt this in the UI, it responds correctly, when I use the API, it responds correctly, but when I try to use pydantic-ai, it responds with a date somewhere in 2022 (I asked this question yesterday, btw).
@assistant_agent.tool
async def fetch_events(ctx: RunContext[AssistantDependencies], start_datetime: str, end_datetime: str) -> str:
    """Fetches events."""
    print("START DATE", start_datetime)
    print("END DATE", end_datetime)

I've tried to add more context to the Agent, both in the Dependencies and in the system_prompt, but this didn't make it much better.
@dataclass
class AssistantDependencies:
    user: User = Field(description="User object")
    current_datetime: str = Field(description="The current date and time in ISO 8601 format")

assistant_agent = Agent(
    model=model,
    system_prompt=f"You are a helpfull assistant. Today is {datetime.now().strftime('%Y-%m-%d')}.",
)

deps = AssistantDependencies(user=user, current_datetime=datetime.now().isoformat())
result = await assistant_agent.run(text, deps=deps)

Any idea on how to 'make this work'? It's mainly that the start_datetime & end_datetime have wrong values as input.

This works fine for me every time.
from datetime import date

from pydantic_ai import Agent

assistant_agent = Agent(
    model='openai:gpt-4o',
    system_prompt=f'You are a helpful assistant. Today is {date.today():%Y-%m-%d}.',
)

for i in range(10):
    result = assistant_agent.run_sync('What date is it today?')
    print(f'{i}: {result.data}')

Output:
0: Today is December 14, 2024.
1: Today is 2024-12-14.
2: Today's date is December 14, 2024.
3: Today is December 14, 2024.
4: Today is December 14, 2024.
5: Today is 2024-12-14.
6: Today's date is December 14, 2024.
7: Today's date is December 14, 2024.
8: Today is December 14, 2024.
9: Today's date is December 14, 2024.

If you can provide an MRE with the problem, happy to investigate.


set JOB_ID to avoid duplicate executions

Currently, runSerialSolver and runParallelSolver execute all jobs with final label even though --job=id is set.
TODO:

[ ] check if it is required for other operations as well.

Lgtm, please See my recommendation- it will likely fix the integration test


support elixir 3

Updated to work with the elixir v3.

I don't know why but your pull request comes from an unknown repository. @EHLOVader created a pull request with your changes. Thanks for your contribution


Custom page content not appearing

I've been working on a new Mezzanine template and I've run into a problem with content not displaying on custom pages. I have a fairly typical setup (initially copied and then modified from the core Mezzanine templates) with a base.html to define site-wide layout and pages/page.html that extends base.html for page display. In base.html I have a 'main' block where all site content appears (per the core template examples):

{% block title %}{% endblock title %}

        {% block main %}{% endblock main %}

Up to this point, everything works completely as expected. However, for certain pages I need to use the custom page templates described here. When I create a custom page with a name matching the page slug, no content at all appears in the main block (the editing features also do not appear). I've tried extending both base.html and pages/page.html, with the same result. I know it's using the correct template file because I can manually insert content on the custom page as follows:
{% block main %}Testing custom.html{% endblock main %}

That correctly displays the static text on the custom page, but none of the page content as created in the admin interface. I've tried simply copying my pages/page.html to pages/custom.html, but I get the exact same behavior. The template works as expected for pages.html, but as soon as custom.html is used, no content appears. I've tried using both the current release from PyPI as well as the latest code here on GitHub, but both versions demonstrate the same behavior.
Is this a bug, or am I missing something simple here? I've done quite a bit of research on this problem but I cannot seem to find much documentation on this feature outside of the Page Templates paragraph and I haven't been able to locate an existing Mezzanine theme that demonstrates custom pages in action.
Any help would be appreciated!

Hi Stephen and jbittel,
Thanks for bringing this up. An additional question: {% block main%} in page.html automatically rescales images using mezzanine's thumbnails. {{ page.richtextpage.content|safe }}
does not do that. Do you know of an easy solution to accomplish that resizing, for example by adding another filter?
Wim


Fix the fast path for nameprep

char::is_ascii_lowercase() only returns true for alphabetical characters which are lowercase, which makes very common domain characters like '.' miss out on this optimisation.  Instead we use char::is_ascii() && !char::is_ascii_uppercase() to reach the expected outcome.
I have also added a test to not have that regress.
This was found with this commit in the jid crate:
https://gitlab.com/xmpp-rs/xmpp-rs/-/merge_requests/205

The nodeprep fast path seems like it could be cleaned up as well - is_ascii_lowercase and ascii_control_character should be disjoint.

I have also cleaned and optimised both nodeprep and resourceprep, the time spent parsing my entire roster and bookmarks has now been reduced from 127.9 µs to 35.2 µs on my i7-8700K, with only two occurrences using characters from higher codepoints than ASCII.  This will obviously differ from dataset to dataset, but it should already be a pretty nice improvement.

Thanks!


How do I ignore certain filetypes?

I'd like to not have lightline enabled on terminal buffers? I didn't see anything looking through the docs. Can this be configured?

This is not supported in this plugin by design. However, for terminal buffers, you can use the TerminalWinOpen event to override the local statusline (autocmd TerminalWinOpen * setlocal statusline=). I don't recommend this way though.


[5/n] Avoid using hardcoded test credentials

This is 5th part of the PR to clean up the test credentials used in C Core(more specifically, in test/core/end2end/...).
The ultimate goal is to remove the dependencies on test/core/end2end/data/ssl_test_data.h, which contains strings of hard-coded certificates.

@jiangtaoli2016 this PR keeps failing(for three times) on the test Bazel C/C++ Dbg MacOS and Bazel C/C++ Opt MacOS, with errors:

E0415 01:18:52.256368000<PHONE_NUMBER>10944 tls_pthread.cc:26]            assertion failed: 0 == pthread_setspecific(tls->key, (void*)value)

It looks like this issue is very similar to a known flaky issue https://github.com/grpc/grpc/issues/20311. However, I have ran the tests for 3 times and it all failed on the same issue. I am wondering if I introduced some changes that made this flaky issue failing every time. I might need to dig more on this issue.


Manager

https://github.com/GoogleChrome/first-party-sets/blob/main/related_website_sets.JSON

Thank you


Update releases and tags from semver to calver

Proposed Changes

(Describe the changes and rationale behind them)

Related Issues

(Github link to related issues or pull requests)

@coderabbitai review

@coderabbitai full review

@coderabbitai full review

@coderabbitai summary


Scorekeeping Workspace - Basic UI Scaffolding & Separation of Logic

This PR is regarding the following issue: https://github.com/jak103/powerscore/issues/4
For phase 1, I have built several components and tried to get a decent general layout. A couple of points I would like to emphasize:

The style and layout is obviously not final, I just wanted to get something built so we can iterate on it and figure out what actually looks good.

Please note that I have installed tailwind and the required dependencies. This allowed me to get done in a couple hours what would have normally taken several.  The tailwind docs can be found here and are fairly intuitive: https://tailwindcss.com/docs/installation.

Some stuff actually works but most of the components simply contain placeholders for now.

The idea here is that now we have a few specific components needing work done that could be broken into individual tasks if desired. I am also happy to just keep working on them myself if needed.

Proof of concept - Here is what these changes look like on an iPad mini:
https://github.com/jak103/powerscore/assets/50534173/ab60a6f4-93bc-4750-baf9-f5744639e3b6
Please reach out with any questions or concerns!

That looks awesome! Thanks for including a demo video. I'll be sure to use tailwind for the entryboard; it seems simple enough based on your code. If I had approval power I'd approve this PR.


Cannot find lab setup and enumeration

Cannot find
Lab Setup
Enumeration
Exploitation
Mitigation
from the table of contents
This is the table of Content
Description (of the vulnerability)
Lab Setup
Enumeration
Exploitation
Mitigation
(Useful) References

Hello, thanks for reaching out... if you go through any vulnerability you will see this format! For example visit the "AlwaysInstallElevated" vulnerability, you will see Description, Lab set up which contains manual and automated with powershell. (Most sections include manual and powershell script), then you will see enumeration, exploitation, mitigation, references! If you want any other clarifications please let me know! Thanks for using Windows Local Priv Esc Cookbook!


Move to newer Ubuntu

As per https://github.com/actions/virtual-environments/issues/3287 , Ubuntu 16.04 is being dropped.
We should adjust, and not only here, but on all repos at once:

conda-compilers
conda-prog
conda-misc
conda-eda

This is done on all repos


Beta migration

Added Globalization Beta Migration Guide (beta-migration.md) and added the link in README.md

LGTM

Fixes #3


Remove .NET Core requirement for users by using self-contained publish

Summary of the Pull Request
This PR changes the publish method for both Settings and Launcher to self-contained, so all the required .NET core dlls are included in the output directory and can be packaged directly in the MSI.
PR to be merged in after #2561

PR Checklist

[X] Applies to #2542
[X] CLA signed. If not, go over here and sign the CLA

Detailed Description of the Pull Request / Additional comments

.NET Core install script could not be used as it doesn't actually install .NET Core on the system, it just downloads the dlls to a folder in AppData so it doesn't get detected by apps.
Running the .NET Core installer exe directly from the PowerToys MSI did not work as it would throw an error since there would be two MSIs running at the same time.
Bundling was not attempted as that is very likely to affect the auto-update mechanism.
Main disadvantage of this method - all the files need to be copied irrespective of whether the user has/does not have .NET Core. Also since we have 2 .NET Core executables in different folders, we need 2 copies of all the dlls.
MSI file size increased from 42MB to 152MB because of using self-contained. Actual installation size on disk increased from 118MB to 392MB.

Validation Steps Performed
Tested by installing on a machine with .NET Core and a VM without .NET Core.

I'm really worried about maintainability of this approach, beside the fact that we were also planning to migrate the FZ Editor to .NET Core, making a third copies of the same files.
We should really revisit this because it seems it's getting out of control very quickly and it can make a lot of user simply decide to stop using PowerToys.

Let's not merge this PR for now and let's keep it as plan B.
Plan A should be:

create a new PowerToys MSI that installs a custom updater
the custom updater is an executable that first checks if .NET Core is already installed and in case it downloads and installs it
after .NET Core is installed, the custom updater download the real PowerToys MSI and installs it.

Not sure if we can get it done and tested properly for 0.18 but we should at least try.

Since we will install .NET Core, this PR can be closed.


SUGGESTION: Trackpad Support

This app is amazing - I'm using it right now!
The one thing that could make it better - a trackpad!
There's space right under the keyboard in every mode, and it would make this app incredible.
Thanks for reading

Closed as duplicate of #26, #32, #60, #75, #83 and #84.


graalvm native image generation fails due to logback

logback version :  net.logstash.logback:logstash-logback-encoder:6.3**
We are trying to build a graalvm native image for our application (version of graalvm: 21.3.0)  and during image generation, I am seeing the following error and image generation with this error.
rror: Classes that should be initialized at run time got initialized during image building:
net.logstash.logback.Logback11Support was unintentionally initialized at build time. net.logstash.logback.Logback11Support has been initialized without the native-image initialization instrumentation and the stack trace can't be tracked. Try marking this class for build-time initialization with --initialize-at-build-time=net.logstash.logback.Logback11Support
com.oracle.svm.core.util.UserError$UserException: Classes that should be initialized at run time got initialized during image building:
net.logstash.logback.Logback11Support was unintentionally initialized at build time. net.logstash.logback.Logback11Support has been initialized without the native-image initialization instrumentation and the stack trace can't be tracked. Try marking this class for build-time initialization with --initialize-at-build-time=net.logstash.logback.Logback11Support
   at com.oracle.svm.core.util.UserError.abort(UserError.java:73)
   at com.oracle.svm.hosted.classinitialization.ConfigurableClassInitialization.checkDelayedInitialization(ConfigurableClassInitialization.java:555)
    at com.oracle.svm.hosted.classinitialization.ClassInitializationFeature.duringAnalysis(ClassInitializationFeature.java:168)
    at com.oracle.svm.hosted.NativeImageGenerator.lambda$runPointsToAnalysis$12(NativeImageGenerator.java:727)
   at com.oracle.svm.hosted.FeatureHandler.forEachFeature(FeatureHandler.java:73)
   at com.oracle.svm.hosted.NativeImageGenerator.runPointsToAnalysis(NativeImageGenerator.java:727)
   at com.oracle.svm.hosted.NativeImageGenerator.doRun(NativeImageGenerator.java:529)
    at com.oracle.svm.hosted.NativeImageGenerator.run(NativeImageGenerator.java:488)
    at com.oracle.svm.hosted.NativeImageGeneratorRunner.buildImage(NativeImageGeneratorRunner.java:403)
    at com.oracle.svm.hosted.NativeImageGeneratorRunner.build(NativeImageGeneratorRunner.java:569)
    at com.oracle.svm.hosted.NativeImageGeneratorRunner.main(NativeImageGeneratorRunner.java:122)
    at com.oracle.svm.hosted.NativeImageGeneratorRunner$JDK9Plus.main(NativeImageGeneratorRunner.java:599)

Does logback natively supports graalvm native image support or Is there something that logback library need to fix here or can we safely let this class to initialize during build time as suggested in the error message ?

This class is part of the support of older versions of Logback (1.1.x) and has been removed in logstash-logback-encoder:7.0.
I'm not an expert of Graalvm (at all) and have no idea whether this early initialisation at build time is a problem or not, maybe @philsttr can provide more information. As far as I can tell, it shouldn't be a problem if you are using a recent version of Logback, i.e. you are NOT using Logback 1.1.x... In this case, I guess the class will be initialized correctly and the rest of the codebase will not wrongly assume it must adapt itself to an old version of Logback.
If this class is the only warning you get while building your application, I would recommend you upgrade to the latest version of logstash-logback-encoder instead where it has been removed. Whatever happens we are strongly interested in knowing how the project behaves in a Graalvm environment... so please don't hesitate to post any feedback. We'll try to help with any further issue you might encounter.


msbuild: init at 15.6

Motivation for this change
xbuild, which is part of Mono, is deprecated, in favor of the recently open-source MSBuild used on Windows. MSBuild has an incredibly complicated build system, which appears to fail silently on non-FHS systems. Thus, I used the official Ubuntu binaries. These require relatively little patching, as .NET is a bytecode language, so patchelf is not necessary. I don't have a Mac to test, but it may work on MacOS as well for this reason. This is definitely a stopgap; however, MSBuild's custom build system will require extensive work to be used, or even emulated, on NixOS.
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[x] Fits CONTRIBUTING.md.

Don't merge this! It looks for a file in the mono installation whenever it tries to build a project, but it's not there. I'm not sure where that file is supposed to come from.

This file exists, and is in a subdirectory. Weird.

I have an untested fix locally, but it's gonna take a minute to build Mono.

It built, having some difficulty testing it, will push in a few minutes.

Was compiling something, OOMKiller killed nix-env. One minute...

I think I have a working fix, but I had a power outage while I was compiling Mono. It might still be a little while.

Update: It now attempts to build C# (yay!) but is failing to search the GAC (boo), where the standard library is located via.

I have a fixed version, but am having some trouble rebasing onto master. It'll be a few minutes.

Fixed version.

I made those changes, but couldn't test them because I haven't built my patched Mono off master.

It works. I don't know how to remove the "Merge branch 'master' into master" commit, GitHub created it (from the web UI). This would be really nice for 18.09, it would drastically improve .NET support.

@samueldr (pinging because of Discourse post) This would be nice for 18.09. buildDotnetPackage is not updated because that would rebuild all .NET packages, and there may be package breakages from the new build system, but this would still be nice for local development of .NET apps. Many frameworks are beginning to require MSBuild on all platforms.

👋 hi!
I have checked the PR as best as I could... but lacking the experience and knowledge with msbuild I cannot test the changes thoroughly. Could you point me towards a project that needs msbuild to build? Hopefully one that you have tested and is working with msbuild in nixpkgs?
I have looked online for a "hello world" project for msbuild, not really confident this one strains msbuild... I'm saying this because it works without error when removing your fix to pkgs/development/compilers/mono/generic-cmake.nix. (I'm validating the fix is needed).

Mono Maintainers, assemble! @thoughtpolice @obadz @vrthra you are listed, any one of you could take a peek and either yay or nay?

The problem was actually with C# compilation. The last line of this example was what needed the fix: https://github.com/picoe/Eto/wiki/Quick-Start#dotnet-new
The Eto.Forms tests will likely trigger the bug, but I am unable to check right now. If necessary, I can, though. https://github.com/picoe/Eto/tree/master/test/Eto.Test

Also, xbuild implements a subset of MSBuild. As it was deprecated a few years ago, the subset of current MSBuild features is much smaller than it used to be; the project format was completely changed to be (more) human-editable a little while ago, and xbuild never added support.

Hi,
Tried to stumble my way through the links you sent... I was pretty unsuccessful! This does not mean this PR is wrong... I still don't know how to verify, especially verify the change for the copied Microsoft.Common.props file.
While in a checkout of this PR, I entered a shell:
 $ nix-shell -I nixpkgs=$PWD -p msbuild dotnet-sdk dotnetPackages.Nuget

Then, I tried the instructions in the Eto quickstart (dotnet new). This is where I'm uncertain of the results.
[nix-shell:~/tmp/nixpkgs/nixpkgs-PR43680]$ mkdir tmp
[nix-shell:~/tmp/nixpkgs/nixpkgs-PR43680]$ cd tmp/
[nix-shell:~/.../nixpkgs-PR43680/tmp]$ dotnet new -i "Eto.Forms.Templates::*"
 [...]
[nix-shell:~/.../nixpkgs-PR43680/tmp]$ dotnet new etoapp -sln -xm -m xaml
The template "Eto Application" was created successfully.
[nix-shell:~/.../nixpkgs-PR43680/tmp]$ nuget restore
MSBuild auto-detection: using msbuild version '4.0' from '/nix/store/nlazlrj5wnb52mh52zczb8gznn7mjl3v-mono-<IP_ADDRESS>/lib/mono/4.5'.

[nix-shell:~/.../nixpkgs-PR43680/tmp]$ msbuild
Microsoft (R) Build Engine version <IP_ADDRESS> ( Thu May 10 14:00:26 UTC 2018) for Mono
Copyright (C) Microsoft Corporation. All rights reserved.
Build started 2018-09-01 9:42:28 PM.
Project "/Users/samuel/tmp/nixpkgs/nixpkgs-PR43680/tmp/tmp.sln" on node 1 (default targets).
ValidateSolutionConfiguration:
  Building solution configuration "Debug|Any CPU".
Project "/Users/samuel/tmp/nixpkgs/nixpkgs-PR43680/tmp/tmp.sln" (1) is building "/Users/samuel/tmp/nixpkgs/nixpkgs-PR43680/tmp/tmp/tmp.csproj" (2) on node 1 (default targets).
PrepareForBuild:
  Creating directory "bin/Debug/netstandard1.6/".
  Creating directory "obj/Debug/netstandard1.6/".
/nix/store/fx0cv0xr53m4kxw1fx2hh4k73qqvww71-msbuild-15.6/usr/lib/mono/msbuild/15.0/bin/Sdks/Microsoft.NET.Sdk/build/Microsoft.PackageDependencyResolution.targets(327,5): error : Assets file '/Users/samuel/tmp/nixpkgs/nixpkgs-PR43680/tmp/tmp/obj/project.assets.json' not found. Run a NuGet package restore to generate this file. [/Users/samuel/tmp/nixpkgs/nixpkgs-PR43680/tmp/tmp/tmp.csproj]
  Build continuing because "ContinueOnError" on the task "ReportAssetsLogMessages" is set to "ErrorAndContinue".
/nix/store/fx0cv0xr53m4kxw1fx2hh4k73qqvww71-msbuild-15.6/usr/lib/mono/msbuild/15.0/bin/Sdks/Microsoft.NET.Sdk/build/Microsoft.PackageDependencyResolution.targets(167,5): error : Assets file '/Users/samuel/tmp/nixpkgs/nixpkgs-PR43680/tmp/tmp/obj/project.assets.json' not found. Run a NuGet package restore to generate this file. [/Users/samuel/tmp/nixpkgs/nixpkgs-PR43680/tmp/tmp/tmp.csproj]
Done Building Project "/Users/samuel/tmp/nixpkgs/nixpkgs-PR43680/tmp/tmp/tmp.csproj" (default targets) -- FAILED.
Project "/Users/samuel/tmp/nixpkgs/nixpkgs-PR43680/tmp/tmp.sln" (1) is building "/Users/samuel/tmp/nixpkgs/nixpkgs-PR43680/tmp/tmp.Desktop/tmp.Desktop.csproj" (3) on node 1 (default targets).
PrepareForBuild:
  Creating directory "bin/Debug/net461/".
  Creating directory "obj/Debug/net461/".
Done Building Project "/Users/samuel/tmp/nixpkgs/nixpkgs-PR43680/tmp/tmp.Desktop/tmp.Desktop.csproj" (default targets) -- FAILED.
Project "/Users/samuel/tmp/nixpkgs/nixpkgs-PR43680/tmp/tmp.sln" (1) is building "/Users/samuel/tmp/nixpkgs/nixpkgs-PR43680/tmp/tmp.XamMac/tmp.XamMac.csproj" (4) on node 1 (default targets).
/Users/samuel/tmp/nixpkgs/nixpkgs-PR43680/tmp/tmp.XamMac/tmp.XamMac.csproj(92,3): error MSB4019: The imported project "/nix/store/nlazlrj5wnb52mh52zczb8gznn7mjl3v-mono-<IP_ADDRESS>/lib/mono/xbuild/Xamarin/Mac/Xamarin.Mac.CSharp.targets" was not found. Confirm that the path in the <Import> declaration is correct, and that the file exists on disk.
Done Building Project "/Users/samuel/tmp/nixpkgs/nixpkgs-PR43680/tmp/tmp.XamMac/tmp.XamMac.csproj" (default targets) -- FAILED.
Done Building Project "/Users/samuel/tmp/nixpkgs/nixpkgs-PR43680/tmp/tmp.sln" (default targets) -- FAILED.
Build FAILED.
"/Users/samuel/tmp/nixpkgs/nixpkgs-PR43680/tmp/tmp.sln" (default target) (1) ->
"/Users/samuel/tmp/nixpkgs/nixpkgs-PR43680/tmp/tmp/tmp.csproj" (default target) (2) ->
(ReportAssetsLogMessages target) ->
  /nix/store/fx0cv0xr53m4kxw1fx2hh4k73qqvww71-msbuild-15.6/usr/lib/mono/msbuild/15.0/bin/Sdks/Microsoft.NET.Sdk/build/Microsoft.PackageDependencyResolution.targets(327,5): error : Assets file '/Users/samuel/tmp/nixpkgs/nixpkgs-PR43680/tmp/tmp/obj/project.assets.json' not found. Run a NuGet package restore to generate this file. [/Users/samuel/tmp/nixpkgs/nixpkgs-PR43680/tmp/tmp/tmp.csproj]
"/Users/samuel/tmp/nixpkgs/nixpkgs-PR43680/tmp/tmp.sln" (default target) (1) ->
"/Users/samuel/tmp/nixpkgs/nixpkgs-PR43680/tmp/tmp/tmp.csproj" (default target) (2) ->
(RunResolvePackageDependencies target) ->
  /nix/store/fx0cv0xr53m4kxw1fx2hh4k73qqvww71-msbuild-15.6/usr/lib/mono/msbuild/15.0/bin/Sdks/Microsoft.NET.Sdk/build/Microsoft.PackageDependencyResolution.targets(167,5): error : Assets file '/Users/samuel/tmp/nixpkgs/nixpkgs-PR43680/tmp/tmp/obj/project.assets.json' not found. Run a NuGet package restore to generate this file. [/Users/samuel/tmp/nixpkgs/nixpkgs-PR43680/tmp/tmp/tmp.csproj]
"/Users/samuel/tmp/nixpkgs/nixpkgs-PR43680/tmp/tmp.sln" (default target) (1) ->
"/Users/samuel/tmp/nixpkgs/nixpkgs-PR43680/tmp/tmp.XamMac/tmp.XamMac.csproj" (default target) (4) ->
  /Users/samuel/tmp/nixpkgs/nixpkgs-PR43680/tmp/tmp.XamMac/tmp.XamMac.csproj(92,3): error MSB4019: The imported project "/nix/store/nlazlrj5wnb52mh52zczb8gznn7mjl3v-mono-<IP_ADDRESS>/lib/mono/xbuild/Xamarin/Mac/Xamarin.Mac.CSharp.targets" was not found. Confirm that the path in the <Import> declaration is correct, and that the file exists on disk.
    0 Warning(s)
    3 Error(s)
Time Elapsed 00:00:00.93

There are three errors. I do not know the actual expected result, as I do not know about either .NET or Eto. This could be expected in a new project, but I'm thinking this shouldn't happen.
I'll ping again the mono maintainers people @thoughtpolice @obadz @vrthra for help in reviewing.

This is weird. Can you try running dotnet restore? The Xamarin.Mac errors are expected, they require macOS. To run the compiled program on Linux, I believe you'll have to pass -gtk to dotnet new, I don't have access to NixOS to test (graphics drivers decided to break separately on all my computers, have just been using Windows because I don't have time to debug right now).

Ah, just dropping -xm seems to do the trick... Though it compiles I don't really know what it is I compiled and how to run it 😃.
I have confirmed that your added file does (seemingly) fix an issue. This was used to verify:
 $ mkdir -p tmp
 $ cd tmp
 $ dotnet new etoapp -sln -m xaml
 $ dotnet restore
 $ msbuild

With and without the added line to generic-cmake.

I can't currently fix this, I won't have access to any NixOS system until Monday night. Can you check if those work? I'm fine with you adding them to my commit.

I am unfortunately unable to help out with this, but this would be fantastic to have merged (since msbuild is required to be able to use C# support in VScode I imagine this would help adoption as well).

I am unfortunately unable to help out with this, but this would be fantastic to have merged (since msbuild is required to be able to use C# support in VScode I imagine this would help adoption as well).

I am unfortunately unable to help out with this, but this would be fantastic to have merged (since msbuild is required to be able to use C# support in VScode I imagine this would help adoption as well).

I deleted and recreated my fork, which appears to have broken the PR. Recreating...

@jdanekrh  I'm actually blocked by this error message on vscode:
Microsoft.Build.Exceptions.InvalidProjectFileException: The imported project "/nix/store/2acc44zvbm4j9dbw2l302sqp8mramda1-mono-<IP_ADDRESS>/lib/mono/xbuild/15.0/Microsoft.Common.props" was not found. Confirm that the path in the <Import> declaration is correct, and that the file exists on disk.  /nix/store/ibsaidfbhyw1nwwggh6slqh6zqc2dfmx-dotnet-sdk-2.2.203/sdk/2.2.203/Sdks/Microsoft.NET.Sdk/Sdk/Sdk.props

Where the directory 15.0 doesn't exist. I am assuming that msbuild 15.x would solve my problem, but I could be wrong, since the path is referencing xbuild instead.
Here's the same issue report in OmniSharp: https://github.com/OmniSharp/omnisharp-vscode/issues/3180. The workaround reported there is to directly edit the Sdk.props file and hard code the file path.

@billksun Let me try to reproduce that for myself. So far, i got this
$ dotnet new -i "GtkSharp.Template.CSharp"
Getting ready...
  Restore completed in 1.79 sec for /home/jdanek/.templateengine/dotnetcli/v2.2.401/scratch/restore.csproj.
[...]
$ dotnet new gtkapp
The template "Gtk Application" was created successfully.
$ ls
MainWindow.cs  MainWindow.glade  Program.cs  project.csproj
$ dotnet run

Unhandled Exception: System.TypeInitializationException: The type initializer for 'Gtk.Application' threw an exception. ---> System.DllNotFoundException: Gtk
   at GLibrary.Load(Library library)
   at Gtk.Application..cctor()
   --- End of inner exception stack trace ---
   at Gtk.Application.Init()
   at project.Program.Main(String[] args) in /home/jdanek/project/Program.cs:line 11
dotnet run  4.42s user 0.76s system 68% cpu 7.542 total

I run vscode with code ., confirm prompt to install omnisharp, I get your OmniSharp error. OK.

There is msbuild, mono, and dotnet-sdk as separate packages, that nevertheless interact in some ways both at build time and then at runtime, maybe even circularly. It might be hard to untangle this when these packages cannot share files in a FHS filesystem. I don't know enough about .net to be much help there.
Or maybe could be sufficient to package omnisharp for nix and fix things there?
My https://github.com/NixOS/nixpkgs/pull/66134 does not seem to help with this omnisharp issue, btw.

@jdanekrh, this doesn't seem to work for me. Although I put omnisharp.json file in my project root directory and used the path for my mono installation /nix/store/2acc44zvbm4j9dbw2l302sqp8mramda1-mono-<IP_ADDRESS>/lib/mono/xbuild instead, I got exactly the same error message.
So it seems that omnisharp is not picking up on the config file.

@billksun I only tried this with msbuild 16.3 from #66134. Could you wait for that PR to be merged, and try again with that?

@jdanekrh, will do

@jdanekrh, using msbuild from #66134 works!


Checkbox values being lost upon adding/removing options

Expected behaviour
The values entered should be persisted when new options are added and other options are deleted.
Actual behaviour
The entered labels are being lost.
Steps to reproduce the behaviour
Enter some values into the options of a Checkbox answer, add new options or remove some options.
Technical information
Did some preliminary investigation and I believe it's down to the focus logic https://github.com/ONSdigital/eq-author/blob/master/src/containers/QuestionnaireDesignPage/QuestionnaireDesignPage.js#L71
Screenshot

Having tested this, I'm fairly certain we've fixed it via #188


Can we have a support for mongoid Hash inputs.

Example class
Class Test
  include Mongoid::Document
  field :todo_list, type: Hash, default: {}
end

Requirement
= f.input :todo_list, keys: ['cycling', 'study', 'outing']

This should be generated as.
= f.fields_for :todo_list  do |list|
 = list.input :cycling
 = list.input :study
 = list.input :outing

It could also generate fields like checkbox, radio button fields
depending upon the argument passed in as 'as: :checkboxes'
Labels could also be passed as in case of collections
like [['cycling', 'Cycling with friends'], ['outing', 'trek to hills']],

If I got it right, it seems you're proposing a shortcut for something we can already do using fields_for, is that it?
If that's the case, I think we're better off being explicit with the inputs we want.


fix: PrimeVue and Tailwind CSS conflicts

What does it do
We are giving PrimeVue styles priority over Tailwind with a higher CSS specificity.
Usage
It is automatically applied with a PostCSS plugin.
Why is it needed
A lot of styling issues because of Tailwind overriding PrimeVue styles due to a higher specificity with their preflight.

@Miguel445Ar could you check if this PR fixes the styling issues in your branch?


The command "python setup.py test" exited with 1

Traceback (most recent call last):
  File "setup.py", line 45, in <module>
	test_suite='runtests.main',
  File "/opt/python/2.7.9/lib/python2.7/distutils/core.py", line 151, in setup
	dist.run_commands()
  File "/opt/python/2.7.9/lib/python2.7/distutils/dist.py", line 953, in run_commands
	self.run_command(cmd)
  File "/opt/python/2.7.9/lib/python2.7/distutils/dist.py", line 972, in run_command
	cmd_obj.run()
  File "/home/travis/virtualenv/python2.7.9/lib/python2.7/site-packages/setuptools/command/test.py", line 142, in run
	self.with_project_on_sys_path(self.run_tests)
  File "/home/travis/virtualenv/python2.7.9/lib/python2.7/site-packages/setuptools/command/test.py", line 121, in with_project_on_sys_path
	require('%s==%s' % (ei_cmd.egg_name, ei_cmd.egg_version))
  File "/home/travis/virtualenv/python2.7.9/lib/python2.7/site-packages/pkg_resources/__init__.py", line 918, in require
	needed = self.resolve(parse_requirements(requirements))
  File "/home/travis/virtualenv/python2.7.9/lib/python2.7/site-packages/pkg_resources/__init__.py", line 810, in resolve
	raise VersionConflict(dist, req).with_context(dependent_req)
pkg_resources.ContextualVersionConflict: (Django 1.5.12 (/home/travis/virtualenv/python2.7.9/lib/python2.7/site-packages), Requirement.parse('django==1.5'), set(['django-fancy-cronfield']))

The command "python setup.py test" exited with 0.
Done. Your build exited with 1.

The real cause is this:
$ pep8 fancy_cronfield
fancy_cronfield/validators.py:19:80: E501 line too long (133 > 79 characters)
fancy_cronfield/tests/test_validators.py:91:80: E501 line too long (85 > 79 characters)


[MCS-DE-GO] Ability to rename Dialogs

It should be possible to rename Dialogs. Change should be reflected in related filenames as well.
@joaollq @goergenj @garypretty

Closing as a dupe of https://github.com/microsoft/BotFramework-Composer/issues/1741


Use whiptail by default

The default mode being suitable for the installer (not showing download progress) is not good for using frzr via terminal: use whiptail GUI by default

I would not default to whiptail, why not the same as it was before? Just the wget output and the installing... messages?

Important question: do we want whiptail at all?

The new installer won't use whiptail anymore, we're going to update state from ENV.

The new installer won't use whiptail anymore, we're going to update state from ENV.

I understand this. The current behaviour is assuming frzr is being run by the installer and this commit changes back to assuming an Hunan via CLI when not told otherwise to have the old GUI.
If whiptail is not needed anymore I will replace whiptail with textual output.


0.8.1 compatibility

Hello! I love this module; it's one of the few that're indispensible to me. I've been updating my system to be compatible with Foundry 0.8.1 and I've also made some tweaks to MWPM to make it work, too. Let me know if you'd like the edited version.
The changes mostly relate to changes to the hook parameters.

If you have already done this please make a pull request and I can get a version published with those changes! I have unfortunately not been in the mood to keep up with personal projects with my actual job being so busy lately. Pull request will make sure you get the credit on the repo for the changes :)

No problem, I have done that!


Add optional custom icon to Select Component

This pr add the option to define the icon on the select component

@jxnblk could you please take a look on this?)