Removed unnecessary buttons on result page + Fixed the unwanted scroll and footer

title: Issue #222  | Removed unnecessary buttons on result page + Fixed the unwanted scroll and footer

Discord Username: @vigneshgupta
What type of PR is this? (select all that apply)

[x] 🍕 Feature
[ ] 🐛 Bug Fix
[ ] 🚧 Breaking Change
[ ] 🧑💻 Code Refactor
[ ] 📝 Documentation Update

Description

Related Tickets & Documents

Related Issue #222
Closes #222 #230

QA Instructions, Screenshots, Recordings
PREV:

UPDATED:

UI accessibility concerns?
Unwanted button won't be focused so easy navigation.

Added/updated tests?

[ ] 👍 yes
[x] 🙅 no, because they aren't needed
[ ] 🙋 no, because I need help

[optional] Are there any post deployment tasks we need to perform?
[optional] What gif best describes this PR or how it makes you feel?

Something is really wrong with this. So close it!


Error: 'pipelineOperator' requires 'proposal' option whose value should be one of: minimal

@renke
Description:
Can not run import-sort on my code, and the following error is happening for all files:
Error: 'pipelineOperator' requires 'proposal' option whose value should be one of: minimal

based on https://babeljs.io/docs/en/next/babel-plugin-proposal-pipeline-operator.html proposal option only can be 'minimal'
Environment:

Create-react-app v2 (using babel 7)
There is no .babelrc in my project (it is hidden in react-scripts v2)
There is no usage of Pipeline in my code

@renke any comments/idea on these changes

Whats holding this up?

I will release it in a few moments. I couldn't reproduce the problem, but the fix doesn't seem to cause any problems for me so I merged it anyway. Thanks for the PR!


Correction in alphabetical order

@frankiefab100 Please make sure first read the file then make changes. I changed it.
I correct the Franklin Ohaegbulam Name in alphabetical order in file My-PR-Contribution-Practice.md.

Okay, thanks for the review

I already corrected it for you before now!


Create a command.sh script in stack and zip dists to help running dropwiz commands

Now we have more dropwizard commands (see https://gchq.github.io/stroom-docs/user-guide/tools/command-line.html) it would be useful if the stack and zip distributions shipped with a shell script to make it easier to run them.
e.g command.sh reset_password --u USER --p PASSWORD
I.e. the script would know the location of the java binary and the config file (if needed)

This has been done for the docker stack.


Remove abandoned mineshafts

Abandoned mineshafts seem to be generating (and are visible above ground since the entire world is badlands)

I considered removing them but felt like they might actually fit the dead planet vibe. Open to removing them though


Dumping the json result into json file

I have two questions.

How can I dump the json output to a json file instead of printing out?
I currently have docker run -v $(pwd):/tmp mythril/myth analyze /tmp/simple_int_overflow.sol -o json --solv 0.4.24 --execution-timeout 86400 to print out the json output. I tried adding -j /tmp/test.sol, but it doesn't seem like the outputs are the same.

If I want to recursively run mythril on the background to scan through a directory of smart contracts and print the results to .json in Python, how can I do that?

Hi @chinhonglee, you can always redirect the stdout into a file.
For the second part you can write a script that does it.
for each file in directory, run the file with mythril and redirect it's output to a corresponding json file.

Can you provide a simple example how to "run the file with mythril and redirect it's output to a corresponding json file" ? Any pointers will be appreciated!

You can run a bash command with python


Update plugin.xml

Add mode="overwrite" in config file
Add android:exported="true" in two services: com.adobe.phonegap.push.FCMService , com.adobe.phonegap.push.PushInstanceIDListenerService

Description
Added android:exported="true" as these are required in cordova 10.
Added mode="overwrite" to avoid duplication of these attributes in AndroidManifest.xml
Motivation and Context
In the development of an application I encountered this pair of problems, and since it has not been corrected, I thought I would contribute with this solution
How Has This Been Tested?
The proposed changes were tested in applications that are in production today and work correctly.
Screenshots (if appropriate):
Types of changes

[x] Bug fix (non-breaking change which fixes an issue)

Checklist:

[x] All new and existing tests passed.

Looking forward to the merge of this and a hotfix release as this currently prevents us from targeting sdk 31 which other plugins require. Although is similar to #153 which also has more chnges.

Adding mode="overwrite" to config-file shouldn't have any point or action.
From the Cordova documentation, the mode attribute only exists on the edit-config element, not the config-file element.
In this patch, is it OK if you can remove the mode="overwrite" so we can merge in only the android:exported flags?

Cordova Doc: config-file specification
Cordova Doc: edit-config specification


Add ability to define offset planes in UI

It's useful to reference the same plane when creating parts. With the current KCL and modeling app you cannot define a plane outside of KCL. It would be nice to have a tool define offset planes using the UI.
Engine notes
None, offset planes are just another plane to the engine.
API/KCL notes

Ready. There is an ergonomic offsetPlane() standard library function for defining a plane from a default plane or face.
TODO: add an issue to add the ability to use offsetPlane with body faces in addition to the default planes.

Point-and-click notes

The biggest issue with matching existing CAD UX is that we currently don't have a pattern for UI handles for things like setting this offset distance. Related to https://github.com/KittyCAD/engine/issues/2233. This should not block an initial implementation.
A current implementation could be to add a modeling machine event and corresponding command with two arguments:

plane: show default planes and make them selectable. Note: users will expect this to let you select faces for offset planes, so we should add a warning to this argument's step. You can take examples from the Fillet operation's configuration for a selection argument warning.
distance: Until 1 can be supported, we can simply accept a KCL expression for the distance value.

TradCAD demos
https://github.com/user-attachments/assets/9693d194-9144-4f86-a916-203034f5d84c

Thanks for making this @r-barton. I'm gonna make some edits to elaborate on it and get it into our current point-and-click project.

Related https://github.com/KittyCAD/modeling-app/issues/4468, and open PR https://github.com/KittyCAD/modeling-app/pull/4552

Completed by #4552


Improve python implementation

Remove useless ; and remove else statement.

I could even suggest this :
#!/usr/bin/env python
import sys
output = len(sys.argv) == 1 ? "y" : " ".join(sys.argv[1:])
while True:
    print(output)

Although it is not as clear.

@mubaris I might have other improvements to other languages. Is it something you are interested in? Otherwise, I won't carry on with other fixes like this one. 😄

You're more than welcome to contribute this project in any way :smile:


Uncaught SyntaxError: Unexpected token 'export' (at entry.worker.js:5666:1)

Hello!
I'm trying to implement remix-pwa and I'm having an issue with the browser loading the entry.worker.js
Uncaught SyntaxError: Unexpected token 'export' (at entry.worker.js:5666:1)
(index):39 Uncaught (in promise) TypeError: Failed to register a ServiceWorker for scope ('http://localhost:3000/') with script ('http://localhost:3000/entry.worker.js'): ServiceWorker script evaluation failed

versions:
"@remix-pwa/dev": "^3.0.5",
"@remix-pwa/worker-runtime": "^2.1.2",
"@remix-run/react": "^2.8.0",
"@remix-run/server-runtime": "^2.8.0",
my vite config looks like this
import {defineConfig} from 'vite';
import {hydrogen} from '@shopify/hydrogen/vite';
import {oxygen} from '@shopify/mini-oxygen/vite';
import {remixPWA} from '@remix-pwa/dev';
import {vitePlugin as remix} from '@remix-run/dev';
import commonjs from 'vite-plugin-commonjs';
import tsconfigPaths from 'vite-tsconfig-paths';

export default defineConfig({
  plugins: [
    hydrogen(),
    oxygen(),
    commonjs({
      filter(id: string) {
        // `node_modules` is exclude by default, so we need to include it explicitly
        // https://github.com/vite-plugin/vite-plugin-commonjs/blob/v0.10.1/src/index.ts#L143
        if (
          id.includes('node_modules/@sanity/image-url') ||
          id.includes('node_modules/lodash.debounce')
        ) {
          return true;
        }
      },
    }),
    remix({
      presets: [hydrogen.preset()],
      ignoredRouteFiles: ['**/.*', '**/*.test.*', '**/styleguide.tsx'],
      future: {
        v3_fetcherPersist: false,
        v3_relativeSplatPath: false,
        v3_throwAbortReason: false,
      },
    }),
    tsconfigPaths(),
    remixPWA(),
  ],
  optimizeDeps: {
    include: ['clsx', 'lodash.debounce', '@sanity/image-url'],
  },
});

Any ideas on what might be wrong w/ my config?

What does your entry worker look like?

The built service worker is meant to be a standalone js file, meaning no exports. But somehow, your entry.worker file gets built with export still present

The entry worker looks like this
https://gist.github.com/kayluhb/d2e1d0cac8b99d53af45339aa52972e2

@ShafSpecs I had similar problem, check https://github.com/vite-pwa/vite-plugin-pwa/pull/629

Thanks! Would try and replicate it here as well 👍

@ShafSpecs I had similar problem, check vite-pwa/vite-plugin-pwa#629

@userquin Would building into mjs format, then simply renaming to js fix the export issue though? Or do I transform whilst renaming? Looking at his built worker, it's built in a completely different format for some reason:
var __getOwnPropNames = Object.getOwnPropertyNames;
var __commonJS = (cb, mod) => function __require() {
  return mod || (0, cb[__getOwnPropNames(cb)[0]])((mod = { exports: {} }).exports, mod), mod.exports;
};
var require_entry_worker = __commonJS({
  // ...
});
export default require_entry_worker();

Instead of as a script

Rename the js file to mjs (change the rollup input to the mjs file) before Vite build call, then rename it back to the original (don't forget to change also sourcemap file and reference in the js file): the problem is about using esbuild in Vite minify option (the default): check Vite issue https://github.com/vitejs/vite/issues/15379#issuecomment-1861493128
You can try switching Vite minify option to terser (will require adding the dependency).


Improve AppPaths

Hi @gitgabrio, I came across https://github.com/apache/incubator-kie-drools/pull/5777 and noticed a few things that could be improved a little further (in my opinion). So I decided to take a stab at it while it's fresh. Let's see if you find this useful as well.

The isJar flag was useless because it was true on every invocation of the method.
I find it simpler to feed the transformation method with just a path than repeating the same lambda over and over.
I noticed that Paths.get() is deprecated so I replaced it with Path.of().

How to replicate CI configuration locally?

Build Chain tool does "simple" maven build(s), the builds are just Maven commands, but because the repositories relates and depends on each other and any change in API or class method could affect several of those repositories there is a need to use build-chain tool to handle cross repository builds and be sure that we always use latest version of the code for each repository.
build-chain tool is a build tool which can be used on command line locally or in Github Actions workflow(s), in case you need to change multiple repositories and send multiple dependent pull requests related with a change you can easily reproduce the same build by executing it on Github hosted environment or locally in your development environment. See local execution details to get more information about it.

How to retest this PR or trigger a specific build:

for pull request and downstream checks

Push a new commit to the PR. An empty commit would be enough.

for a full downstream build

for github actions job: add the label run_fdb

for Jenkins PR check only

If you are an ASF committer for KIE podling, login to Jenkins (https://ci-builds.apache.org/job/KIE/job/drools/), go to the specific PR job, and click on Build Now button.

Thanks @yurloc , but I just modified this class and, for the moment being, I think it is better to keep it as it is.
Some side notes:

some of the refactoring (mostly, the static methods) are aimed at improve testability (this class has never been tested before), even if currently I had no time to extend them
Path.of and path.resolve have completely different semantics
I saw that the isJar boolean is always true, but for the moment being I preferred to kept it in the static method (see above about tests)


Allow configuration of 'Exclude matrix parents from running on this slave.' for a template

The Cloud template configuration currently lacks options for the Node properties (as we know from the Jenkins node configuration).
We are particularly interested in 'Exclude matrix parents from running on this slave.' option because we need to avoid running matrix parents on dynamically provisioned Windows slaves.
Adding the other configuration properties would be nice to have but not necessary for us at the moment.

I would welcome that option as well.

Personally, I find that telling matrix projects to restrict where they run to just "master" works fine.
...and then you control where the matrix "real work" happens using a (or more than one) matrix axis.

Very true - I agree that it would be better if the end user didn't have to do any configuration to make it "just work".
... so ... FYI the vSphere plugin has code in vSphereCloudSlave.java's canTake method that says:
    @Override
    public CauseOfBlockage canTake(BuildableItem buildItem) {
...
        if(buildItem.task instanceof Queue.FlyweightTask) {
            return CauseOfBlockage.fromMessage(Messages._vSphereCloudSlave_BlockageReason_NoFlyweightTasks());
        }
...
        return super.canTake(buildItem);
    }

where Messages._vSphereCloudSlave_BlockageReason_NoFlyweightTasks() is
    public static Localizable _vSphereCloudSlave_BlockageReason_NoFlyweightTasks() {
        return new Localizable(holder, "vSphereCloudSlave.BlockageReason.NoFlyweightTasks");
    }

and the associated Messages.properties file has the line:
vSphereCloudSlave.BlockageReason.NoFlyweightTasks=Don't run FlyweightTasks on vSphere nodes as they can be terminated.

My understanding of this code is that it is intended to prevent "flyweight" tasks (such as the matrix "parent" job) from running on the node.
A "flyweight" task does not consume an executor, does not make a node "non-idle" and does not affect the retention of a cloud-provisioned node, so without this code, it's possible for a flyweight task to be running on a cloud-provisioned node right at the time when that cloud-provisioned node is being destroyed, thus breaking the flyweight task (e.g. a matrix build's parent job).
So, what we could do is use the same technique that's used by the vSphere plugin so that the OpenStack slaves don't accept flyweight tasks and then this should solve the problem.
Implementing node properties would be another option (and has its own advantages), but then users would have to add that node property to all OpenStack templates themselves in order to prevent matrix parent jobs breaking.
Disclaimer: This code in the vSphere-plugin was written before I became involved in that plugin - I do not have any proof that it's achieving these results.  However, the code looks plausible to me.

@pjdarton, yes that is a straightforward way to do so. Just a minor correction, "flyweight tasks" have special "one off" executors created for the stave it is running on and that prevent the computer to be considered idle. see https://github.com/jenkinsci/jenkins/blob/a17bd1cbfa674f4050bbf5dc1ca7d4721d7e9302/core/src/main/java/hudson/model/Computer.java#L1020-L1027.
So the effect here is the openstack machine is retained for the whole time flyweight task is running.

OK, so it doesn't make it "idle" ... but I'm pretty sure (from experience before I set all my matrix jobs to be restricted to "master") that there's enough race conditions in this area that a node's retention strategy  (e.g. for a single-use node) and/or the "single use slave" flag (on a build) may decide to terminate a node regardless of the presence of flyweight tasks on the node.
i.e. the "one true path to happiness" is to make sure that flyweight tasks do not run on cloud-provisioned slaves.

Agreed

@pjdarton, have just contributed an improvement to this in 2.48.


[NFC] Introduce abstractions for working with generic signatures in the runtime

@swift-ci Please smoke test

@swift-ci Please smoke test and merge


CheckReturnValue for assertThat statements for Findbugs

Check List:

Fixes #157
Unit tests : NA
Javadoc with a code example (API only) : NA

Backports https://github.com/joel-costigliola/assertj-core/pull/695

I also guess that the check is worth mentioning this on wiki or something, @joel-costigliola what do you think? I could document it and open a PR on wiki as well.

Good idea,  I will add a FAQ for that.

@karlicoss I'll do it as part of the 2.5.0/3.5.0 documentation I'm currently writing. You can't really create a PR on something that does not exists ;-)


Nil pointer in actionPreparing if server not found

/kind bug
What steps did you take and what happened:
A nil pointer error occurs if the server is not found due to a wrong error message in https://github.com/syself/cluster-api-provider-hetzner/blob/v1.0.0-beta.22/pkg/services/baremetal/host/host.go#L136
What did you expect to happen:
Do not use the nil server in the error message

https://github.com/syself/cluster-api-provider-hetzner/pull/915


Model Inference Error on Transform

I trained the model with rmvpe-gpu through colab without GUI which is linked to my Google Drive.
I got these files in log folder
1- D_2333333.pth (~857 MB)
2- G_2333333.pth (~435 MB)
3- trained_IVF2593_Flat_nprobe_1_My-Model_v2.index (~8 MB)
4- added_IVF2593_Flat_nprobe_1_My-Model_v2.index (~ 320 MB)
So which one I have to use as transform in Model Inference.
Lastly If I Use GUI to download the Model by connecting to GDrive and try to use Model Inference then I am getting this error
2023-10-03 01:21:19 | WARNING | infer.modules.vc.modules | Traceback (most recent call last):
File "/content/drive/MyDrive/project-main/infer/modules/vc/modules.py", line 191, in vc_single
audio_opt = self.pipeline.pipeline(
File "/content/drive/MyDrive/project-main/infer/modules/vc/pipeline.py", line 410, in pipeline
self.vc(
File "/content/drive/MyDrive/project-main/infer/modules/vc/pipeline.py", line 238, in vc
npy = np.sum(big_npy[ix] * np.expand_dims(weight, axis=2), axis=1)
IndexError: index -1 is out of bounds for axis 0 with size 0
Traceback (most recent call last):
File "/usr/local/lib/python3.10/dist-packages/gradio/queueing.py", line 388, in call_prediction
output = await route_utils.call_process_api(
File "/usr/local/lib/python3.10/dist-packages/gradio/route_utils.py", line 219, in call_process_api
output = await app.get_blocks().process_api(
File "/usr/local/lib/python3.10/dist-packages/gradio/blocks.py", line 1440, in process_api
data = self.postprocess_data(fn_index, result["prediction"], state)
File "/usr/local/lib/python3.10/dist-packages/gradio/blocks.py", line 1341, in postprocess_data
prediction_value = block.postprocess(prediction_value)
File "/usr/local/lib/python3.10/dist-packages/gradio/components/audio.py", line 349, in postprocess
file_path = self.audio_to_temp_file(
File "/usr/local/lib/python3.10/dist-packages/gradio/components/base.py", line 325, in audio_to_temp_file
temp_dir = Path(self.DEFAULT_TEMP_DIR) / self.hash_bytes(data.tobytes())
AttributeError: 'NoneType' object has no attribute 'tobytes'

weights/xxxx.pth(~60MB)
added_IVF2593_Flat_nprobe_1_My-Model_v2.index (~ 320 MB)
these two files

Thanks @RVC-Boss
Appreciate your help and i am able to find training model now.
I am still getting this issue on conversion interface.
2023-10-03 01:21:19 | WARNING | infer.modules.vc.modules | Traceback (most recent call last):
File "/content/drive/MyDrive/project-main/infer/modules/vc/modules.py", line 191, in vc_single
audio_opt = self.pipeline.pipeline(
File "/content/drive/MyDrive/project-main/infer/modules/vc/pipeline.py", line 410, in pipeline
self.vc(
File "/content/drive/MyDrive/project-main/infer/modules/vc/pipeline.py", line 238, in vc
npy = np.sum(big_npy[ix] * np.expand_dims(weight, axis=2), axis=1)
IndexError: index -1 is out of bounds for axis 0 with size 0
Traceback (most recent call last):
File "/usr/local/lib/python3.10/dist-packages/gradio/queueing.py", line 388, in call_prediction
output = await route_utils.call_process_api(
File "/usr/local/lib/python3.10/dist-packages/gradio/route_utils.py", line 219, in call_process_api
output = await app.get_blocks().process_api(
File "/usr/local/lib/python3.10/dist-packages/gradio/blocks.py", line 1440, in process_api
data = self.postprocess_data(fn_index, result["prediction"], state)
File "/usr/local/lib/python3.10/dist-packages/gradio/blocks.py", line 1341, in postprocess_data
prediction_value = block.postprocess(prediction_value)
File "/usr/local/lib/python3.10/dist-packages/gradio/components/audio.py", line 349, in postprocess
file_path = self.audio_to_temp_file(
File "/usr/local/lib/python3.10/dist-packages/gradio/components/base.py", line 325, in audio_to_temp_file
temp_dir = Path(self.DEFAULT_TEMP_DIR) / self.hash_bytes(data.tobytes())
AttributeError: 'NoneType' object has no attribute 'tobytes'

Facing the same issue. What can be done ?


How to convert pretrained tensorflow model to pytorch

How to convert pretrained tensorflow model to pytorch? I have tried some tools like MMDNN, but it doesn't success.

I convert manually.


ndb with ts-node-dev

Steps to reproduce
Tell us about your environment:

ndb version: ^1.1.5
Platform / OS version: Windows 10 Home version 2004
Node.js version: 12.16.3

What steps will reproduce the problem?
Please include code that reproduces the issue.

Install<EMAIL_ADDRESS>and<EMAIL_ADDRESS>Create a script inside your package.json with the following content: ndb tsnd --respawn -- src/main.ts
Run yarn run my-script.

Other relevant information:

I am running a server at localhost:8080.
I am trying to debug an endpoint at localhost:8080/channels.
I am using NestJS.

What is the expected result?
The ndb gui should open, and src/main.ts should be executed.
What happens instead?
The ndb GUI opens, but the code never runs. It just gets stuck with the GUI opened.
Here are a few things that I have tried:

Running ndb yarn run other-script, where the script is the exact code above tnsd --respawn -- src/main.ts. In this case, the code is executed, but I can't use the debugger. It will not stop at the specified breakpoints.
Running ndb . and then running my scripts from the GUI.
Reinstalling node-gyp.
Installing ts-node-dev globally.

See https://github.com/GoogleChromeLabs/ndb/issues/269
downgrade with npm i -g<EMAIL_ADDRESS>may help?
I had a similar issue with debugger; not working inside a process deeper inside npm run test, and the downgrade worked. Maybe it will help you too?

Hey, thanks for the reply.
Unfortunately it didn't help. It's very weird because ndb npm run dev works but ndb <dev script> doesn't.


Add another font family / font style

how can i add another font family/ font style on the font choice ? any idea ?

like this ?

Hi please have a look at https://xdsoft.net/jodit/doc/options/controls/
var editor = new Jodit("#editor", {
controls: { fontsize: {list:  "12,14"},
font    : {list:  { "your new font goes here": "font name" ,
"Helvetica,sans-serif" "Helvetica"      }}}});
Hope this is of any use

Thanks sir ! appreciated

Thanks for that @mdevDE wasn't quite there but got me in the right direction:
var editor = new Jodit("#editor", {     controls: {         font: {             list: {                 "Font Name": "Font Label Appears in List"             }         }     } });

Thanks @mdevDE — wasn't quite there but got me in the right direction:
var editor = new Jodit("#editor", {
    controls: {
        font: {
            list: {
                "Font Name": "Font Label Appears in List"
            }
        }
    }
});

I did custom fontsize and add font-family using:  jodit jodit-react


SkeletonFolder functionality

core has the option to set a skeletonFolder, this is heavily used in the API tests, so having it also in OCIS would make things easier

Note: we have reduced the use of the skeleton directory a lot in the test suite. Now there are not so many scenarios left that have to "fake" the skeleton at the start of a scenario.


ivan: add full iconset

Motivation for this change
A complete set of icons for the ivan package has been added :alien:
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[x] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

@GrahamcOfBorg build ivan

@nh2 Thanks! :alien:


chore: Update ubuntu version to LTS (18.04)

resolves #190

@benja-M-1 tu as testé que ça marche ?

@benja-M-1 @ghamaide  I fix NodeJS install issue by upgrading NodeJS role. Could you review the PR ?

@benja-M-1 C'est bon ça marche !!! 😄


⚠ Jenkins Plugins Artifactory has degraded performance

In 7199eaa, Jenkins Plugins Artifactory (https://get.jenkins.io/plugins/artifactory/) experienced degraded performance:

HTTP code: 200
Response time: 2889 ms

Resolved: Jenkins Plugins Artifactory performance has improved in 2e1f660 after 17 minutes.


NLP-Insights config name not properly identified when deleting a config that doe not exist

When I try to delete a config that does not exist, I get the expected 400 response code, but the message is:
“Error when trying to delete config-\“‘config name’ must exist\“”
Wondering if ’config name” is supposed to be the actual name of the config?       My config name was not ‘config name’

fixed


add explicit instructions for security researchers how to responsibly disclose security related matters

GitHub Issue (If applicable): Related to https://github.com/nventive/Uno/pull/927
PR Type
What kind of change does this PR introduce?

Documentation content changes

What is the current behavior?
No guidance provided for security researchers.
What is the new behavior?
See https://github.com/TryGhost/Ghost/blob/master/SECURITY.md
PR Checklist
Please check if your PR fulfills the following requirements:

[ ] Tested code with current supported SDKs
[ ] Docs have been added/updated which fit documentation template. (for bug fixes / features)
[ ] Unit Tests and/or UI Tests for the changes have been added (for bug fixes / features) (if applicable)
[ ] Wasm UI Tests are not showing unexpected any differences
[x] Contains NO breaking changes
[ ] Updated the Release Notes
[ ] Associated with an issue (GitHub or internal)

What's required before merging

[x] Provision the<EMAIL_ADDRESS>mailbox
[x] Merge the pull-request

/azp run

/azp run


HTTP HeaderMaps (de)serialize support #102

closes #102. Converts existing HashMap<string, string> types to http::HeaderMap.

Just fixed the merge conflicts and the spacebar! Let's hope for green checkmarks from the CI.

Fixed space in expected ts type file
https://github.com/fiberplane/fp-bindgen/runs/7107416665?check_suite_focus=true#step:7:355


More build issues

@marcosmoura You're going to hate me :(
So with the change you just made to externals, now using Vue and VueMaterial from

I now have a working solution, that I believe is the correct solution.
The webpack docs leave much to be desired but after reading full configuration docs here is the syntax that works for both module import and script tags:
  externals: {
    vue: {
        commonjs: "vue",
        commonjs2: "vue",
        amd: "vue",
        root: "Vue",
    }
  }

When using export type umd, we can specify the external name for each type, allowing us to normally use vue for module imports, and Vue for script tag usage.
Does this make sense? I can now understand the hate javascript build environments get... Things never seem to be as simple as they first appear. I apologize for giving you a half-baked solution last time.

Also, one other question which I think is related. In index.js, you set window.VueMaterial.
I can't see anywhere in the entire source where you ever use it again; It looks like you coded this very close to the first release.
This doesn't seem to be a common practice among other Vue plugins. It defeats one of the purposes of using webpack and modules: keeping things contained. Webpack and friends take care of getting VueMaterial to the right place.
My guess is that this is just a forgotten piece of code that should probably be removed since your current webpack takes care of making that variable available.

The externals trick worked flawlessly!
The window variable was created to work with the standalone build, to use the Vue.use(VueMaterial).
But with the new externals this become obsolete:
  externals: {
    vue: {
      commonjs: 'vue',
      commonjs2: 'vue',
      amd: 'vue',
      root: 'Vue',
      var: 'Vue'
    }
  }

Thanks a lot @korylprince!!!


first pass at removing session variable for oauth flow

This is missing a few things:

[ ] tests haven't been updated
[x] verify the behavior when students access a collection page anonymously and then log in
[x] decide if we should remove the 're_login' param handling
[ ] verify the app_name handling in oauth_authorize
[ ] decide if oauth_authorize should do some sanity checks on the params before redirecting
[ ] check if this breaks the ability to use google accounts to sign into the Researcher Report portal instance, it certainly breaks the ability to log into LARA via the researcher portal since it would never redirect back to oauth_authorize. But I think this is separate from logging into the portal with Google.

@pjanik do you have an opinion on (or perhaps the spec has an opinion on) whether oauth_authorize should check the parameters before redirecting to the login page? For example if the client_id is invalid.   This wasn't done before, but it seems it could be useful to catch problems earlier.

Generally, these changes look great. I thought about the same using another session variable, but re-using after_sign_in_path seems much simpler / better.

@pjanik do you have an opinion on (or perhaps the spec has an opinion on) whether oauth_authorize should check the parameters before redirecting to the login page? For example if the client_id is invalid. This wasn't done before, but it seems it could be useful to catch problems earlier.

Yes, my intuition would be that it's a better approach. Also, if you take a look at RFC (https://tools.ietf.org/html/rfc6749#section-4.2.1):

The authorization server validates the request to ensure that all
required parameters are present and valid.  The authorization server
MUST verify that the redirection URI to which it will redirect the
access token matches a redirection URI registered by the client as
described in Section 3.1.2.

If the request is valid, the authorization server authenticates the
resource owner and obtains an authorization decision (by asking the
resource owner or by establishing approval via other means).

Especially this sentence:

If the request is valid, the authorization server authenticates

It seems they even assume that the request will be validated first. And only if it's valid, the authentication happens.


add grid lstm

I added 2D Grid LSTM following https://github.com/coreylynch/grid-lstm
It is pretty slow and I get an out of memory error. Sounds I'm not sure to understand all aspects of Element-research/rnn...

An example of usage of the layer nn.Grid2DLSTM https://github.com/christopher5106/grid-lstm

But it works.
It is more a question on what is happening behind the element research framework... to get it work as fast as the original version, without memory leak.
Could someone advise me on these questions :
1° how does garbage collection work ? training multiple forward / backwards does delete tensors ? shall I call forget method during each step of the training ?
2° if I want to initialize the parameters (https://github.com/christopher5106/grid-lstm/blob/master/train.lua#L163-L180) inside the layer, in which function shall I put it ?
Thanks a lot

Using rnn:forget() solves the memory and speed issue.

Small corrections. Works perfectly now.

@christopher5106 Is it too l ate for me to ask you to include documentation and unit test? Sorry for the delay.

Hello guys! Any updates on this PR! Looks tasty!

What would you like exactly for this?

@christopher5106 For documentation, adding a section to README.md with link to paper and brief explanation should do the trick. For unit tests, add a function to test.lua to make sure GridLSTM behaves as expected. Doesn't have to be extensive.


Dataset access

Hi Mundher,
Would it be possible to get access to the dataset you trained this model with? I'm working on a similar project and am having trouble finding a tagged nsfw dataset.
Thanks!

The dataset is available for research purposes. If you're an academic, please fill out the form and send it from your academic email


Lsort improvements

This adds a -f option to lsort so that a list of files can be provided. It also adds an option (-r) to include sites where all samples in the input VCF are homozygous reference or missing. The new default is to skip these.

Coverage decreased (-0.2%) to 82.711% when pulling 42b28cf80824930d8c83a47047dc09409d8bec3d on ernfrid:lsort_improvements into 7420f8c64856cb0d67932c001496eb1ca47e47d6 on hall-lab:develop.

Coverage decreased (-0.1%) to 82.77% when pulling aa731e3308f2971ac943cc7eec4295bf46814f20 on ernfrid:lsort_improvements into 7420f8c64856cb0d67932c001496eb1ca47e47d6 on hall-lab:develop.

Coverage decreased (-0.1%) to 82.77% when pulling a967f16e7d152ee1f0a7e6968d865821e68a1fa6 on ernfrid:lsort_improvements into 7420f8c64856cb0d67932c001496eb1ca47e47d6 on hall-lab:develop.

Coverage decreased (-0.1%) to 82.77% when pulling a320e82bffc67abf63a8ca37c4b407cdbd1fcd20 on ernfrid:lsort_improvements into 7420f8c64856cb0d67932c001496eb1ca47e47d6 on hall-lab:develop.

+1


[hotfix] user dashboard says '150 weeks'

Coverage increased (+0.005%) to 69.118% when pulling 5dea6dab253656dd7fac6bd4199942e64b594efa on mistercrunch:fix_user_weeks into 66f646ac66c308ca0235e2a62c6d4f5110712640 on apache:master.


Make addition request for connpass API Showcase

http://connpass.com/about/api/

done.
Thank you.


Client Secret Post Authentication not working (missing classes/commits from release build)

Describe the bug
When authenticating with the token endpoint, I am unable to configure client post authentication.
When creating the registered client, but using clientAuthenticationMethod(ClientAuthenticationMethod.POST), the token endpoint client authentication still defaults to Basic authentication.
I did some debugging and found that ClientSecretPostAuthenticationConverter class is missing from the 0.0.3 release when it should have already been added since 0.0.2
Have downloaded the release source to check and the corresponding java files were indeed not present, they are however present on the master branch. Seems like that commit was not included in the release.
To Reproduce

Configure client post authentication for the token endpoint using clientAuthenticationMethod(ClientAuthenticationMethod.POST).

Perform authorization code flow.

When invoking the token endpoint, client_id and client_secret in the POST data result in 401 error. The authentication is defaulted to basic authentication.

Download the release source code for version 0.0.3. And look for the file: spring-authorization-server-0.0.3\oauth2-authorization-server\src\main\java\org\springframework\security\oauth2\server\authorization\web\ClientSecretPostAuthenticationConverter.java. It should be present, but it is not.

Expected behavior

Perform step 1 and 2 as above, token endpoint can be invoked when client_id and client_secret are given in the POST request parameters.

The file spring-authorization-server-0.0.3\oauth2-authorization-server\src\main\java\org\springframework\security\oauth2\server\authorization\web\ClientSecretPostAuthenticationConverter.java should be present in the release build.

@pangyiwei ClientSecretPostAuthenticationConverter is in master and is targeted for the upcoming 0.1.0 release. See #134

@pangyiwei ClientSecretPostAuthenticationConverter is in master and is targeted for the upcoming 0.1.0 release. See #134


Could not find firebase-iid.aar...

Description:
Getting error in debug release
Environment
"react-native-onesignal": "^3.2.4"
yarn add
RN 0.55.4
Steps to Reproduce Issue:

Install the OneSignal SDK using yarn into your project
run react-native run-android

Output:
FAILURE: Build failed with an exception.

* What went wrong:
Could not resolve all files for configuration ':app:debugCompileClasspath'.
> Could not find firebase-iid.aar (com.google.firebase:firebase-iid:12.0.1).
  Searched in the following locations:
      https://jcenter.bintray.com/com/google/firebase/firebase-iid/12.0.1/firebase-iid-12.0.1.aar
> Could not find firebase-common.aar (com.google.firebase:firebase-common:12.0.1).
  Searched in the following locations:
      https://jcenter.bintray.com/com/google/firebase/firebase-common/12.0.1/firebase-common-12.0.1.aar
> Could not find play-services-ads.aar (com.google.android.gms:play-services-ads:12.0.1).
  Searched in the following locations:
      https://jcenter.bintray.com/com/google/android/gms/play-services-ads/12.0.1/play-services-ads-12.0.1.aar
> Could not find firebase-auth-license.aar (com.google.firebase:firebase-auth-license:12.0.1).
  Searched in the following locations:
      https://jcenter.bintray.com/com/google/firebase/firebase-auth-license/12.0.1/firebase-auth-license-12.0.1.aar

android/build.gradle
// Top-level build file where you can add configuration options common to all sub-projects/modules.

buildscript {
    repositories {
        jcenter()
        google()
    }
    dependencies {
        classpath 'com.android.tools.build:gradle:3.0.1'

        // NOTE: Do not place your application dependencies here; they belong
        // in the individual module build.gradle files
    }
}

allprojects {
    repositories {
        mavenLocal()
        jcenter()
        google()
        maven {
            // All of React Native (JS, Obj-C sources, Android binaries) is installed from npm
            url "$rootDir/../node_modules/react-native/android"
        }
    }
}

app/build.gradle:
buildscript {
    repositories {
        maven { url 'https://plugins.gradle.org/m2/' } // Gradle Plugin Portal
    }
    dependencies {
        classpath 'gradle.plugin.com.onesignal:onesignal-gradle-plugin:[0.10.0, 0.99.99]'
    }
}

apply plugin: 'com.onesignal.androidsdk.onesignal-gradle-plugin'

apply plugin: "com.android.application"

import com.android.build.OutputFile

project.ext.react = [
    entryFile: "index.js"
]

apply from: "../../node_modules/react-native/react.gradle"

def enableSeparateBuildPerCPUArchitecture = false

/**
 * Run Proguard to shrink the Java bytecode in release builds.
 */
def enableProguardInReleaseBuilds = false

android {
    compileSdkVersion 26
    buildToolsVersion "26.0.2"

    defaultConfig {
        applicationId "com.realm"
        minSdkVersion 16
        targetSdkVersion 22
        versionCode 1
        versionName "1.0"
        ndk {
            abiFilters "armeabi-v7a", "x86"
        }
    }
    splits {
        abi {
            reset()
            enable enableSeparateBuildPerCPUArchitecture
            universalApk false  // If true, also generate a universal APK
            include "armeabi-v7a", "x86"
        }
    }
    buildTypes {
        release {
            minifyEnabled enableProguardInReleaseBuilds
            proguardFiles getDefaultProguardFile("proguard-android.txt"), "proguard-rules.pro"
        }
    }
    // applicationVariants are e.g. debug, release
    applicationVariants.all { variant ->
        variant.outputs.each { output ->
            // For each separate APK per architecture, set a unique version code as described here:
            // http://tools.android.com/tech-docs/new-build-system/user-guide/apk-splits
            def versionCodes = ["armeabi-v7a":1, "x86":2]
            def abi = output.getFilter(OutputFile.ABI)
            if (abi != null) {  // null for the universal-debug, universal-release variants
                output.versionCodeOverride =
                        versionCodes.get(abi) * 1048576 + defaultConfig.versionCode
            }
        }
    }
}

dependencies {
    compile project(':react-native-onesignal')
    implementation "com.google.firebase:firebase-core:12.0.1"
    implementation "com.google.android.gms:play-services-base:12.0.1"

    // RNFirebase optional dependencies
    implementation "com.google.firebase:firebase-messaging:12.0.1"
    implementation "com.google.firebase:firebase-iid:12.0.1"

    compile project(':realm')
    compile fileTree(dir: "libs", include: ["*.jar"])
    compile "com.android.support:appcompat-v7:26.0.2"
    compile "com.facebook.react:react-native:+"  // From node_modules
}

// Run this once to be able to run the application with BUCK
// puts all compile dependencies into folder libs for BUCK to use
task copyDownloadableDepsToLibs(type: Copy) {
    from configurations.compile
    into 'libs'
}

Can someone help me with these issues?

@rodrigofbm In your android/build.gradle in your repositories section, try moving google() ABOVE jcenter().
It's bizarre, but we've seen this fix this particular issue.

@Nightsd01 lol it works! Thanks so much!

@Nightsd01 Thanks a lot!

Just to clarify for others who may be confused like me:
You need to swap google() and jcenter() in the allprojects.repositories section, NOT the buildscript.repositories section.

FYI cordova & android developers:
This same problem started to occur on our build yesterday and we managed to fix build using this same trick. Thanks!
To fix the problem in cordova, move jcenter() below the allprojects.repositories.maven.


Clarify usage of npmlock2nix

This helps beginners get started with npmlock2nix by clarifying the
README and fixing a few errors in it.
It adds a 'getting started' section that explains how to add npmlock2nix
to NIX_PATH, and replaces nodelock2nix ? <FIXME> with
npmlock2nix ? import <npmlock2nix> in the example nix files.
See my earlier confusion here https://github.com/tweag/npmlock2nix/issues/44

Thanks for the contribution. I am not sure this is a wise idea. Initially I never intended to recommend using a channel for this. I would probably recommend fetching it via builtins.fetchTarball or similar instead and pinning that within your package instead of relying moving targets.

I see, makes sense... I would love to see an example of that.

I see, makes sense... I would love to see an example of that.

Not quite pkgs.fetchTarball but similar one:
{ pkgs ? import <nixpkgs> {} }:
let
  npmlock2nix = import (pkgs.fetchFromGitHub {
    owner = "tweag";
    repo = "npmlock2nix";
    rev = "7a321e2477d1f97167847086400a7a4d75b8faf8";
    sha256 = "10igdxcc6scf6hksjbbgpj877f6ry8mipz97r2v8j718wd233v6a";
  }) { inherit pkgs; };
  src = pkgs.nix-gitignore.gitignoreSource [ ] ./.;
in
  npmlock2nix.build {
    src = src;
    installPhase = "cp -r dist $out";
  }

I think now that we have a completely revamped README we can close this one. If you continue to feel like there is something missing feel free to comment..

While niv seems a good approach, it would be nice to document an installation for a default nixos/nix since likely most nix users aren't using niv. the option sorki wrote didn't work for me i got these
error: anonymous function at /etc/nixos/package/npmlock2nix/default.nix:1:1 called with unexpected argument 'config', at /nix/var/nix/profiles/per-user/root/channels/nixos/lib/modules.nix:312:8
(use '--show-trace' to show detailed location information)
building Nix...
error: anonymous function at /etc/nixos/package/npmlock2nix/default.nix:1:1 called with unexpected argument 'config', at /nix/var/nix/profiles/per-user/root/channels/nixos/lib/modules.nix:312:8
(use '--show-trace' to show detailed location information)
building the system configuration...
error: anonymous function at /etc/nixos/package/npmlock2nix/default.nix:1:1 called with unexpected argument 'config', at /nix/var/nix/profiles/per-user/root/channels/nixos/lib/modules.nix:312:8


Unicode error when updating

Anyone else getting this error or have any idea how to fix it?
$ nfldb-update
-------------------------------------------------------------------------------
STARTING NFLDB UPDATE AT 2016-02-11 00:12:03.987734
Connecting to nfldb... done.
Setting timezone to UTC... done.
Locking write access to tables... done.
Updating season phase, year and week... done.
Bulk inserting data for 7 games...
	Sending batch of data to database.
Traceback (most recent call last):
  File "/home/jane/.local/bin/nfldb-update", line 39, in <module>
    nfldb.update.run(**vars(args))
  File "/home/jane/.local/lib/python2.7/site-packages/nfldb/update.py", line 535, in run
    doit()
  File "/home/jane/.local/lib/python2.7/site-packages/nfldb/update.py", line 525, in doit
    update_games(db, batch_size=batch_size)
  File "/home/jane/.local/lib/python2.7/site-packages/nfldb/update.py", line 397, in update_games
    bulk_insert_game_data(cursor, scheduled, batch_size=batch_size)
  File "/home/jane/.local/lib/python2.7/site-packages/nfldb/update.py", line 195, in bulk_insert_game_data
    do()
  File "/home/jane/.local/lib/python2.7/site-packages/nfldb/update.py", line 188, in do
    nfldb.db._big_insert(cursor, table, bulk[table])
  File "/home/jane/.local/lib/python2.7/site-packages/nfldb/db.py", line 353, in _big_insert
    values = ', '.join(_mogrify(cursor, times(vals(data))) for data in datas)
  File "/home/jane/.local/lib/python2.7/site-packages/nfldb/db.py", line 353, in <genexpr>
    values = ', '.join(_mogrify(cursor, times(vals(data))) for data in datas)
  File "/home/jane/.local/lib/python2.7/site-packages/nfldb/db.py", line 231, in _mogrify
    return cursor.mogrify('%s', (tuple(xs),))
  File "/home/jane/.local/lib/python2.7/site-packages/psycopg2/extensions.py", line 134, in getquoted
    qobjs = [o.getquoted() for o in pobjs]
UnicodeEncodeError: 'ascii' codec can't encode character u'\u2019' in position 20: ordinal not in range(128)

I have all the games schedules and scores but not the detailed play by play it looks like.
nfldb=> select gsis_id,week,away_team,home_team,away_score,home_score from game where season_year = 2015 and season_type = 'Postseason';
  gsis_id   | week | away_team | home_team | away_score | home_score
------------+------+-----------+-----------+------------+------------
<PHONE_NUMBER> |    1 | KC        | HOU       |         30 |          0
<PHONE_NUMBER> |    1 | PIT       | CIN       |         18 |         16
<PHONE_NUMBER> |    1 | SEA       | MIN       |         10 |          9
<PHONE_NUMBER> |    1 | GB        | WAS       |         35 |         18
<PHONE_NUMBER> |    2 | KC        | NE        |         20 |         27
<PHONE_NUMBER> |    2 | GB        | ARI       |         20 |         26
<PHONE_NUMBER> |    2 | SEA       | CAR       |         24 |         31
<PHONE_NUMBER> |    2 | PIT       | DEN       |         16 |         23
<PHONE_NUMBER> |    3 | NE        | DEN       |         18 |         20
<PHONE_NUMBER> |    3 | ARI       | CAR       |         15 |         49
<PHONE_NUMBER> |    5 | CAR       | DEN       |         10 |         24

nfldb=> select * from drive where gsis_id =<PHONE_NUMBER>::gameid;
 gsis_id | drive_id | start_field | start_time | end_field | end_time | pos_team | pos_time | first_downs | result | penalty_yards | yards_gained | play_count | time_inserted | time_updated
---------+----------+-------------+------------+-----------+----------+----------+----------+-------------+--------+---------------+--------------+------------+---------------+--------------

Anyone have any ideas for how to fix this?  Maybe some of my gamecenter-json got corrupted?  I added some code to psycopg2/extension.py to see exactly where the error is occuring
for i in pobjs:
    print i

and I get the following output running nfldb-update
<psycopg2.extensions.NoneAdapter object at 0x7ff967c8d690>
0
0
0
0
0
0
0
0
0
0
0
0
0
0
'NOW()'
'NOW()'
'2016011600'
19
4463
ROW('Q4', 868)::game_time
'NE'
ROW(13)::field_pos
3
13
'(:32) T.Brady kneels to KC 38 for -1 yards.'
<psycopg2.extensions.NoneAdapter object at 0x7ff967c8d690>
0
0
0
0
0
0
0
0
0
1
0
1
0
0
'NOW()'
'NOW()'
'2016011600'
19
4484
ROW('Final', 0)::game_time
'UNK'
NULL
<psycopg2.extensions.NoneAdapter object at 0x7ff967c8d690>
0
Traceback (most recent call last):
  File "/home/jane/.local/bin/nfldb-update", line 39, in <module>
    nfldb.update.run(**vars(args))
  File "/home/jane/.local/lib/python2.7/site-packages/nfldb/update.py", line 535, in run
    doit()
  File "/home/jane/.local/lib/python2.7/site-packages/nfldb/update.py", line 525, in doit
    update_games(db, batch_size=batch_size)
  File "/home/jane/.local/lib/python2.7/site-packages/nfldb/update.py", line 397, in update_games
    bulk_insert_game_data(cursor, scheduled, batch_size=batch_size)
  File "/home/jane/.local/lib/python2.7/site-packages/nfldb/update.py", line 195, in bulk_insert_game_data
    do()
  File "/home/jane/.local/lib/python2.7/site-packages/nfldb/update.py", line 188, in do
    nfldb.db._big_insert(cursor, table, bulk[table])
  File "/home/jane/.local/lib/python2.7/site-packages/nfldb/db.py", line 353, in _big_insert
    values = ', '.join(_mogrify(cursor, times(vals(data))) for data in datas)
  File "/home/jane/.local/lib/python2.7/site-packages/nfldb/db.py", line 353, in <genexpr>
    values = ', '.join(_mogrify(cursor, times(vals(data))) for data in datas)
  File "/home/jane/.local/lib/python2.7/site-packages/nfldb/db.py", line 231, in _mogrify
    return cursor.mogrify('%s', (tuple(xs),))
  File "/home/jane/.local/lib/python2.7/site-packages/psycopg2/extensions.py", line 135, in getquoted
    print i

I tried deleting all the 2016 gamecenter-json, but that did not seem to help.  If I pull the play by play from a different working nfldb for this game I get the following for the last 3 plays
  gsis_id   | drive_id | play_id |   time    | pos_team | yardline | down | yards_to_go |                                                                                description                                                                                |  note   |         time_inserted         |         time_updated          | first_down | fourth_down_att | fourth_down_conv | fourth_down_failed | passing_first_down | penalty | penalty_first_down | penalty_yds | rushing_first_down | third_down_att | third_down_conv | third_down_failed | timeout | xp_aborted
------------+----------+---------+-----------+----------+----------+------+-------------+---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+---------+-------------------------------+-------------------------------+------------+-----------------+------------------+--------------------+--------------------+---------+--------------------+-------------+--------------------+----------------+-----------------+-------------------+---------+------------
<PHONE_NUMBER> |       19 |    4484 | (Final,0) | UNK      |          |      |           0 | END GAME NE-12 Brady’s 22nd career postseason win, extends his NFL record. Bill Belichick 23rd career postseason win, most by head coach in NFL history (Tom Landry, 20). Robert Kraft's 25th career postseason win, 3rd-most all-time by an owner.                                                           |         | 2016-01-28 15:01:16.407711-08 | 2016-01-28 15:01:16.407711-08 |          0 |               0 |                0 |                  0 |                  0 |       0 |                  0 |           0 |                  0 |              0 |               0 |                 0 |       0 |          0
<PHONE_NUMBER> |       19 |    4463 | (Q4,868)  | NE       | (13)     |    3 |          13 | (:32) T.Brady kneels to KC 38 for -1 yards.                                                                                |         | 2016-01-28 15:01:16.407711-08 | 2016-01-28 15:01:16.407711-08 |          0 |               0 |                0 |                  0 |                  0 |       0 |                  0 |           0 |                  0 |              1 |               0 |                 1 |       0 |          0
<PHONE_NUMBER> |       19 |    4442 | (Q4,841)  | NE       | (14)     |    2 |          12 | (:59) T.Brady kneels to KC 37 for -1 yards.

It seems to be failing on the strange end of game play description.

Fixed!  I had to manually delete the apostrophe from the json file in "Brady's" and it seems to work now.
gunzip<PHONE_NUMBER>.json.gz
vim<PHONE_NUMBER>.json
gzip<PHONE_NUMBER>.json


Problem reading vagrant machine IP address

I have a problem with landrush reading my vagrant machine IP address. During vagrant up it logs something like that: [default] [landrush] adding machine entry: mysite.dev => (notice the value is empty). And because of that I cant access mysite.dev.
~/.vagrant.d/data/landrush/hosts.json looks like that:
{
  "mysite.dev": null
}

and when i set there a proper ip, everything works.
I looked up the code and run the statement from read_host_visible_ip_address.rb and it outputs something that looks good to me. The last address is the one i set in Vagrantfie for private_network.
→ ifconfig  | grep 'inet addr:' | grep -v '<IP_ADDRESS>' | cut -d: -f2 | awk '{ print $1 }'
<IP_ADDRESS>
<IP_ADDRESS>

@karmelak  is this still an issue? Can you try Landrush 1.0.0?

I'm having a similar problem, and I think it's because the order of interfaces is unpredictable:
imiell@rothko:/space/git/shutit-openshift-cluster/vagrant_run/shutit_openshift_cluster_QyDYrE  ⑂ master +  $  vagrant landrush ls
master1.vagrant.test           <IP_ADDRESS>
<IP_ADDRESS>.in-addr.arpa      master1.vagrant.test
node1.vagrant.test             <IP_ADDRESS>
<IP_ADDRESS>.in-addr.arpa         node1.vagrant.test

imiell@rothko:/space/git/shutit-openshift-cluster/vagrant_run/shutit_openshift_cluster_QyDYrE  ⑂ master +  $  vagrant ssh master1
Last login: Thu Mar 22 06:28:34 2018 from <IP_ADDRESS>
[vagrant@master1 ~]$ ifconfig
eth0: flags=4163<UP,BROADCAST,RUNNING,MULTICAST>  mtu 1500
        inet <IP_ADDRESS>  netmask <IP_ADDRESS>  broadcast <IP_ADDRESS>
        inet6 fe80::5054:ff:feda:a710  prefixlen 64  scopeid 0x20<link>
        ether 52:54:00:da:a7:10  txqueuelen 1000  (Ethernet)
        RX packets 2772  bytes 2125964 (2.0 MiB)
        RX errors 0  dropped 0  overruns 0  frame 0
        TX packets 1175  bytes 143241 (139.8 KiB)
        TX errors 0  dropped 0 overruns 0  carrier 0  collisions 0

eth1: flags=4163<UP,BROADCAST,RUNNING,MULTICAST>  mtu 1500
        inet <IP_ADDRESS>  netmask <IP_ADDRESS>  broadcast <IP_ADDRESS>
        inet6 fe80::a00:27ff:feb4:358b  prefixlen 64  scopeid 0x20<link>
        ether 08:00:27:b4:35:8b  txqueuelen 1000  (Ethernet)
        RX packets 12  bytes 6088 (5.9 KiB)
        RX errors 0  dropped 0  overruns 0  frame 0
        TX packets 20  bytes 2680 (2.6 KiB)
        TX errors 0  dropped 0 overruns 0  carrier 0  collisions 0
        device interrupt 16  base 0xd240

lo: flags=73<UP,LOOPBACK,RUNNING>  mtu 65536
        inet <IP_ADDRESS>  netmask <IP_ADDRESS>
        inet6 ::1  prefixlen 128  scopeid 0x10<host>
        loop  txqueuelen 1  (Local Loopback)
        RX packets 64  bytes 5568 (5.4 KiB)
        RX errors 0  dropped 0  overruns 0  frame 0
        TX packets 64  bytes 5568 (5.4 KiB)
        TX errors 0  dropped 0 overruns 0  carrier 0  collisions 0

imiell@rothko:/space/git/shutit-openshift-cluster/vagrant_run/shutit_openshift_cluster_QyDYrE  ⑂ master +  $  vagrant ssh node1
Last login: Fri Mar 23 11:06:00 2018 from <IP_ADDRESS>
[vagrant@node1 ~]$ ifconfig
eth0: flags=4163<UP,BROADCAST,RUNNING,MULTICAST>  mtu 1500
        inet <IP_ADDRESS>  netmask <IP_ADDRESS>  broadcast <IP_ADDRESS>
        inet6 fe80::a00:27ff:feb6:64d3  prefixlen 64  scopeid 0x20<link>
        ether 08:00:27:b6:64:d3  txqueuelen 1000  (Ethernet)
        RX packets 4  bytes 2360 (2.3 KiB)
        RX errors 0  dropped 0  overruns 0  frame 0
        TX packets 20  bytes 2664 (2.6 KiB)
        TX errors 0  dropped 0 overruns 0  carrier 0  collisions 0
        device interrupt 16  base 0xd240

eth1: flags=4163<UP,BROADCAST,RUNNING,MULTICAST>  mtu 1500
        inet <IP_ADDRESS>  netmask <IP_ADDRESS>  broadcast <IP_ADDRESS>
        inet6 fe80::5054:ff:feda:a710  prefixlen 64  scopeid 0x20<link>
        ether 52:54:00:da:a7:10  txqueuelen 1000  (Ethernet)
        RX packets 2802  bytes 2129961 (2.0 MiB)
        RX errors 0  dropped 0  overruns 0  frame 0
        TX packets 1181  bytes 147304 (143.8 KiB)
        TX errors 0  dropped 0 overruns 0  carrier 0  collisions 0

lo: flags=73<UP,LOOPBACK,RUNNING>  mtu 65536
        inet <IP_ADDRESS>  netmask <IP_ADDRESS>
        inet6 ::1  prefixlen 128  scopeid 0x10<host>
        loop  txqueuelen 1  (Local Loopback)
        RX packets 64  bytes 5568 (5.4 KiB)
        RX errors 0  dropped 0  overruns 0  frame 0
        TX packets 64  bytes 5568 (5.4 KiB)
        TX errors 0  dropped 0 overruns 0  carrier 0  collisions 0


The same link and command download much larger files on Linux than on Windows.

DO NOT REMOVE OR SKIP THE ISSUE TEMPLATE

[X] I understand that I will be blocked if I intentionally remove or skip any mandatory* field

Checklist

[X] I'm asking a question and not reporting a bug or requesting a feature
[X] I've looked through the README
[X] I've verified that I have updated yt-dlp to nightly or master (update instructions)
[X] I've searched known issues and the bugtracker for similar questions including closed ones. DO NOT post duplicates
[X] I've read the guidelines for opening an issue

Please make sure the question is worded well enough to be understood
The same link and command download much larger files on Linux than on Windows.

why
Provide verbose output that clearly demonstrates the problem

[ ] Run your yt-dlp command with -vU flag added (yt-dlp -vU <your command line>)
[ ] If using API, add 'verbose': True to YoutubeDL params instead
[ ] Copy the WHOLE output (starting with [debug] Command-line config) and insert it below

Complete Verbose Output
No response

You are missing ffmpeg on windows

You are missing ffmpeg on windows
I tried uninstalling ffmpeg on Linux and indeed found it to be the case. I would like to ask if there is any quality difference between the files downloaded in these two ways?

You are missing ffmpeg on windows

I tried uninstalling ffmpeg on Linux and indeed found it to be the case. I would like to ask if there is any quality difference between the files downloaded in these two ways?

Yes. ffmpeg is required for merging split audio and video formats together. Without that, you are limited to 720p on YouTube. Other websites might not even offer premerged formats, so you would end up with two files, one for the audio track and one for the video.
FFmpeg is optional, but strongly recommended.

[info] Available formats for FnnjUMu6PeQ:
22      mp4   1280x720    30  2 │ ≈  5.75GiB
...
623     mp4   2560x1440   60    │ ~ 43.74GiB │ vp<IP_ADDRESS> 14921k
308     webm  2560x1440   60    │   28.85GiB │ vp<IP_ADDRESS>  9843k
251     webm  audio only      2 │  350.73MiB │ opus       117k 48k


Add optional dnsPolicy, dnsConfig to all pods

Allow adding dnsPolicy and/or dnsConfig to all pods.

rebased on master

@armab This is straight forward as well and should be quick to review.
It adds dnsPolicy and dnsConfig to all pods. It only adds lines; it does not change any existing lines.
Thanks again for all your reviews.


feat: Upgrade to Volar 2.2

Changes
Upgrade to Volar 2.2 💪
Testing

Docs

Tried this PR locally and it seems to work, however I noticed an issue with the Prettier formatting, seems like it's not loading the Prettier config anymore.
Not quite sure what's up with the tests, but since the features do work locally I can only assume this is a bug in the test utils / tests

@johnsoncodehk My last commit fixes some of the tests. However, it seems like there's an issue with openInMemoryDocument in Volar 2.2, all the remaining tests that don't pass uses it.
Strangely enough, if I change the fake URI to be one of a file that does exist, no matter its content, then it works.


[BUG] Font Awesome Icon not work

Describe the bug 描述你遇到的错误
Some font awesome icons won't load
A clear and concise description of what the bug is.
一段简短的对于你遇到的错误的描述.
Expected behavior 期待的行为
I tried to load the font awesome icon "instagram-square" and it wouldn't load.
A clear and concise description of what you expected to happen.
一段简短的对于你期待的行为的描述.
Screenshots 屏幕截图

Firefox:

If applicable, add screenshots to help explain your problem.
如果可以的话, 提供屏幕截图对解决问题很有帮助.
Build Environment 构建环境

OS:Fedora Linux
Theme version/commit 1d9709
Hugo version 0.88.1 (lasted)

Please try to use Hugo extended version before opening the issue.
请在创建 issue 之前尝试使用 Hugo extended 版本.
Preview Environment 预览环境

OS: Fedora Linux
Browser Microsoft Edge Beta - but it was tested in other browsers

Additional Information 补充信息
Configuration files or front matter code...
Website Repo

Is this the instagram icon?

size that is the instagram icon that works the one that does not work is "instagram-square"

Should be fixed with the latest commit. The Fontawesome webfont library has not been updated for a long time...

Okay, thanks


Private attachments are publicly accessible

While reimplementing meemo's backend, I noticed that in your implementation, attachments of private notes are visible for outsiders as you have not implemented a way to check for a users credentials when serving these attachments.
I think that this is very bad because private notes are private for a reason, and their attachments shouldn't be treated differently.
Your users probably count on their attachments being private, which means that they might be exposing private documents and photo's to anyone with malicious intent without even knowing it.
I hope you find a way to fix this and roll it out to your users, cheers! :)

That seem indeed to be an oversight on my end.
Out of curiosity, what is the reason to reimplement the backend?

Well, first of all,  I really love the app! Working with tags is just such an easy way to categorize things and the simplistic UI is very nice, as well as the archive feature, it's just perfect for my workflow, and for my private notes as well. You've done a really nice job on the app man! :)
The reason I reimplemented the backend is mostly that I found installing mongoDB a huge pain, and it did not play nicely with my environment. I run most of my apps on a raspberry pi atm, which has an ARM CPU. That ARM CPU meant that I could not install MongoDB version 2.6.x, because the project did not support ARM at the time that version was released. The alternative was to use version 2.4 from the debian repo's, which worked, but the search functionality wouldn't work (something about a syntax error). Then I decided that version 3.0.9 might be worth a try as that does support ARM, but using that version made my entire database process crash (yes I kid you not, the whole thing just panicked and crashed).
After that, I decided that I could not trust MongoDB to work well for my use case, but i really liked the app and I figured that I might as well reimplement the backend and make it work with a mysql(-compliant) database. A huge plus of mysql/mariadadb for me is that it is easy to install and manage, it works well without needing a lot of memory, and that the API does not have as many backwards compatibility breakages between versions.
You can take a look at my fork here: https://github.com/hugot/meemo . I haven't updated the README yet and it is still rough around the edges, but I have all the basic functionalities working and I plan on adding more soon :nerd_face:

@nebulade do you have plans to fix this? Thank you for the great app.

Actually thanks for the heads up, I will have another look at that.


PushEntryRequest more unnecessary transfers

getFirstEntryIndex、getLastEntryIndex、getCount、getTotalSize。
These methods can't start with get, Because fastjson will include them in json string.
Or you can use JSONField(serialize = false) to solve.

Could you submit a pr to slove it?


Scopus400 Error: Exceeds the maximum number allowed for the service level

Using a standard Elsevier API, the maximum service level seems to be only 180 papers when using the enrich metadata function. Is this correct? The example given on LitStudy page shows around 1400 papers - any idea why this might be?
Thanks in advance,
Sam

Thanks for using LitStudy!
Mmmm, not sure what the limit is. LitStudy just passes the query directly to pybliometrics and let's that package handle all communication with Scopus. Maybe you could ask your question on their GitHub page

Sure, I'll take a look. It would seem the enforced limit is 180, which is quite a severe limitation for most query processing.
I'll post on their page and then let you know.
S

Had the same error. Try using a vpn with api subscription like from your University or the like. Solved it for multiple sources.

pybliometrics is tracking this in https://github.com/pybliometrics-dev/pybliometrics/issues/300


FAQ questions

Hi there, there are still a bunch of merge conflcits on this branch. and why would you be wanting to merge into the 03/faq branch from main? I recommend just scrapping this, making a new branch from main, and putting in the FAQ data


#3831 Fix that adds \n at the end of every event

It closes #3831 adding a '\n' to the end of the final event (that it is a TSV)

Closing - this is not a fix.


Code snip is empty for the incidents in the html files

Hi Team,
The code snip frame in the static-report is empty for html, CSS, Json files.
I ran the analysis on the sprint-petclinic and I see the below report data for incidents reported on the html files.
Please see below screenshot:

Closing as duplicate issue
Another Issue: https://github.com/konveyor/kantra/issues/242


Bugfix: Do identify bus stop points uniquely.

Two bus stop points in a route cannot point up to the same value. That's it.
Fixes #11

We'll see, whether this actually fixes the #11 issue. :thinking:


Handle case where redis conn pool size is 0

If the consumer configures the fetch conn pool size to 0, we should not run the processor at all.
What to do if the consumer configures the enqueue conn pool size to 0? Throw an error? Log a warning?

What to do if the consumer configures the enqueue conn pool size to 0? Throw an error? Log a warning?

bb8 throws an error in this case.


net/rpc: server.Register() should not internally log by default

What version of Go are you using (go version)?
$ go version
go version go1.8 linux/amd64

What operating system and processor architecture are you using (go env)?
$ go env
GOARCH="amd64"
GOBIN=""
GOEXE=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOOS="linux"
GOPATH="/home/ppai/work"
GORACE=""
GOROOT="/home/ppai/go"
GOTOOLDIR="/home/ppai/go/pkg/tool/linux_amd64"
GCCGO="gccgo"
CC="gcc"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build142468001=/tmp/go-build -gno-record-gcc-switches"
CXX="g++"
CGO_ENABLED="1"
PKG_CONFIG="pkg-config"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"

What did you do?
https://play.golang.org/p/Y5tF3ruvTw
From the net/rpc source:

// suitableMethods returns suitable Rpc methods of typ, it will report
// error using log if reportErr is true.
func suitableMethods(typ reflect.Type, reportErr bool) map[string]*methodType {
...
...
		if mtype.NumIn() != 3 {
   				if reportErr {
   					log.Println("method", mname, "has wrong number of ins:", mtype.NumIn())
   				}
   				continue
   		}

The unexported caller sets reportErr to true:
func (server *Server) register(rcvr interface{}, name string, useName bool) error {
...
...
	// Install the methods
   	s.method = suitableMethods(s.typ, true)

What did you expect to see?
It is not uncommon for a type to contain methods that do not conform to the method signatures required by net/rpc. The net/rpc should not log these benign log messages by default when it finds such methods. There should be a way to turn this off or ignore it. It should be logged only if a flag or variable is set.
What did you see instead?
2009/11/10 23:00:00 method Name has wrong number of ins: 1

It is not uncommon for a type to contain methods that do not conform to the method signatures required by net/rpc.

What's an example of case where that's acceptable to ignore the warning?

What's an example of case where that's acceptable to ignore the warning?

The type which has one or more RPC method signature conforming methods may also be implementing some other interface and hence can contain other methods. Here's a very simplified example: https://play.golang.org/p/HINYYRn1mU

That comment has bad grammar and needs fixing in any case.
The package is frozen featurewise, but I agree that log message may be spammier than needed. I have no memory of doing the review of https://codereview.appspot.com/6819081, which added the log message along with many others. @minux thought it was important to add them, so I'll pass this one on to him.

OK, sounds like Rob is OK with dropping the log statement. I will note that this makes the failure to invoke the method somewhat more mysterious, at least unexplained.

Well, https://golang.org/cl/87335 just changes the log message but doesn't remove it. It did not fix the issue reported in any way.
It's really annoying and misleading to see these many log messages logged by standard library. The net/rpc package is "frozen" only featurewise.
I can send a patch to remove the log if you guys agree.

I found this issue because I just ran into this myself. I have a type which I want to expose as an RPC endpoint, but it has additional exported methods. The mandatory emission of logs is very bad ergonomics here, and goes against the documentation, which says:
Only methods that satisfy these criteria will be made available for remote access; other methods will be ignored:
  <list of criteria>

Emitting a log is not entirely ignoring other methods.
From this issue it sounds like @robpike was for reverting the mandatory logging, but then the issue got auto-closed after only the error message part changed.
I'm reopening the issue, and will be happy to implement the change. Are there any objections?
@minux

@eliben Perhaps just go ahead and implement the fix?

@neild for thoughts

Removing the message seems fine to me.

Thanks!


UI for Buttons in infoToolbar of List / FacetFilter should be improved in almost all themes.

The (imo) ideal UI of the infoToolbar is implemented in the FacetFilter (light) in sap_belize:
basic

hovering the button

When using the infoToolbar in a List/Table or in newer themes especially buttons don't look that good or are almost impossible to see and use.
OpenUI5 version: Latest
Browser/version (+device/version): All
URL (minimal example if possible):
Here it looks good (button is visible all the time and has nice hover effect):
https://sapui5.hana.ondemand.com/?sap-ui-theme=sap_belize#/entity/sap.m.FacetFilter/sample/sap.m.sample.FacetFilterLight
Here it looks OK-ish (button doesn't have nice hovering effect):
https://sapui5.hana.ondemand.com/?sap-ui-theme=sap_fiori_3#/entity/sap.m.FacetFilter/sample/sap.m.sample.FacetFilterLight
https://sapui5.hana.ondemand.com/?sap-ui-theme=sap_fiori_3_dark#/entity/sap.m.FacetFilter/sample/sap.m.sample.FacetFilterLight
Here it is almost unusable (as soon as you hover the bar the button vanishes):
https://sapui5.hana.ondemand.com/?sap-ui-theme=sap_horizon#/entity/sap.m.FacetFilter/sample/sap.m.sample.FacetFilterLight
https://sapui5.hana.ondemand.com/?sap-ui-theme=sap_horizon_dark#/entity/sap.m.FacetFilter/sample/sap.m.sample.FacetFilterLight
Another sample with a List and infoToolbar:
(looks good when hovered in sap_belize, OK-ish when not hovered, almost unusable when using sap_fiori_3 or sap_horizon).
https://plnkr.co/edit/SrTLTcnthuFmn2QG
What is the expected result?
Buttons are easy to see and use and look visually appealing
What happens instead?
Buttons are hard to see. If the infoToolbar is hovered the buttons are impossible to see (especially with sap_horizon).
Any other information? (attach screenshot if possible)
Some sample screenshots of a List with an active infoToolbar and an "undo" button on the right:
(sap_fiori_3_dark)

(sap_fiori_3 with hover)

(sap_horizon_dark with hover)

(sap_horizon with hover)

What I wished it looked like
(sap_belize with hover, without hover it's also not great)

Hello @OTTOxMarc,
Thank you for sharing this finding. I've created an internal incident<PHONE_NUMBER>. The status of the issue will be updated here in GitHub.
Regards,
Martin


[BottomNavigation] Fix SVG icon positioning

Fixes https://github.com/callemall/material-ui/issues/4981 by setting the icon to 100% width so centering applies in the case of SVGs.
FYI I considered wrapping the icons in a div instead and implementing different centering, but I'd rather avoid adding DOM nodes unless necessary.

This change is

@owencm Could you remove the margin: 'auto', key from the label property. I don't think that we need it here? Thanks.

margin:auto now removed from label

@owencm Squashing down the two commits with the PR title as the commit message would make this contribution almost perfect ✨ .

Commits squashed :)

@owencm Thanks.


[$500]  IOU - RBR disappears from 'amount' field when adding merchant value

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: v1.4.58-4
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4465017
Email or phone of affected tester (no customers<EMAIL_ADDRESS>Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team
Action Performed:

Navigate to a workspace chat
Make an IOU request with a blurred image
Navigate to IOU details report page before the request fails
Add 'Merchant' & Save

Expected Result:
RBR and 'Enter amount' error message should't disappear after appearing
Actual Result:
RBR and 'Enter amount' error message disappear after appearing
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

Screenshots/Videos
https://github.com/Expensify/App/assets/115492554/085270fa-06dd-46c6-b081-d1fc4a3450dc

View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~017baa1a530f155d19
Upwork Job ID:<PHONE_NUMBER>972844032
Last Price Increase: 2024-04-02

@CortneyOfstad I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

We think this issue might be related to the #collect project.

Production
https://github.com/Expensify/App/assets/115492554/c60f3e3e-ebdf-430e-bf61-2c07e797c3c7

@Gonals any updates here? Thanks!

I don't think @gonals is online atm, but this doesn't feel like a deploy blocker to me since the test steps are edge case.

Proposal
Please re-state the problem that we are trying to solve in this issue.
IOU - RBR disappears from 'amount' field when adding merchant value
What is the root cause of that problem?
When we create new IOU scan request and navigate to IOU details page  there are RequestMoney and OpenReport requests in queue . When we update a merchant's information, the optimistic data will be created including the pendingFields key with the value {merchant: 'update'} and  the UpdateMoneyRequestMerchant request will be added to the queue. As we know, optimistic data is updated immediately and in this case the optimistic data of UpdateMoneyRequestMerchant will be set to the ONYX  until the OpenReport request is completed.  And when the OpenReport is completed, in response we will receive an object as shown below which causes the transactions to be updated and the optimistic data of UpdateMoneyRequestMerchant to be lost.
{
  "onyxMethod": "mergecollection",
  "key": "transactions_",
  "value": {
    "transactions_8918703579471352319": {...}
  }
}

What changes do you think we should make in order to solve the problem?
When a user updates merchant and press to save button, we can hold off on updating the merchant until OpenReport is removed from the request queue and display the loader on the "Save" button.

Add persistedRequests: {key: ONYXKEYS.PERSISTED_REQUESTS} in [withOnyx]
Add below code in IOURequestStepMerchant component
(https://github.com/Expensify/App/blob/ee5ab95f2c893738fb48756a9002e9d9dadd9a31/src/pages/iou/request/step/IOURequestStepMerchant.js#L174C5-L174C13)

const holdUpdateValue = useRef()

...

useEffect(()=>{
    if(holdUpdateValue.current && !persistedRequests.find((request)=> request.command === WRITE_COMMANDS.OPEN_REPORT)){
        updateMerchant(holdUpdateValue.current)
        holdUpdateValue.current = undefined
        FormActions.setIsLoading(ONYXKEYS.FORMS.MONEY_REQUEST_MERCHANT_FORM, false);
    }
}, [persistedRequests])

const startUpdatingMerchant =(value)=>{
    if(persistedRequests.find((request)=> request.command === WRITE_COMMANDS.OPEN_REPORT)){
        FormActions.setIsLoading(ONYXKEYS.FORMS.MONEY_REQUEST_MERCHANT_FORM, true);
        holdUpdateValue.current = value
        return
    }

    updateMerchant(value)
}

Replace updateMerchant with startUpdatingMerchant

https://github.com/Expensify/App/assets/46921547/d695dd4c-9484-4afd-9c46-fe0afc42e92c
What alternative solutions did you explore? (Optional)
Since this can also happen while updating "amount" or other details, we can move this logic to "actions/IOU.ts" and create a wrapper function that receives the actionСallback  as param and holds it until the end of OpenReport.  I didn't add this solution simply because it  my suggested approach changes the behavior of the UI, which also needs to be approved. If my approach will approved i can update my proposal and include that option too

@hoangzinh  Could you mention the last version where it works correct

I tried to test the version 1.4.57-5 but it is not possible because server returns error

I want to test this version because I have doubts that it may become from the updates in server side. Currently, receiving an object with "onyxMethod": "mergecollection" in an OpernReport response causes optimistic data of UpdateMoneyRequestMerchant  to be lost. I do not know did the server send an object with such "onyxMethod": "mergecollection" in response before. Maybe this was updated

@hoangzinh any follow-up on the question here?

@hoangzinh I'll check again and come back with updates.

Proposal
Updated.  Update RCA .

@hoangzinh Could you please check an updated RCA ?  let me know If anything is unclear.

Thanks for the update @shahinyan11 . Could you elaborate more on the above? It's hard to link to our issue, why does it make "RBR disappears from 'amount' field when adding merchant value"?

The transaction is first updated based on the data received from the "UpdateMoneyRequestMerchant" request, then it is updated based on the data received from the "OpenReport" request, which does not contain updated details.

@hoangzinh You can past console.log(requestToProcess.command)  on this line and console.log('flushOnyxUpdatesQueue') in flushOnyxUpdatesQueue to make sure that all request will be processed before the flushOnyxUpdatesQueue function is called

@hoangzinh What do you doubt? I've already explained how it works. what do you disagree with ?

@hoangzinh for the proposal, is there is any specific feedback you have that can be shared?
And please keep in mind @shahinyan11, per our guidelines, please keep all correspondence respectful and collaborative. If there are any specific questions or concerns, please let me know.

@CortneyOfstad I apologize if you didn’t like something in my comment. I didn't want to offend anyone, it's just that my English may not be at the highest level.

No worries @shahinyan11! Text can be hard to interpret tone, so I always try to keep that in mind, but all good!

Here we prohibit the update in order due to a specific issue. And I can suggest few options.

Avoid queuing Onyx updates for all requests with type write and do this for a specific list of requests during which we encounter the problem above.

Add new mergeUpdates function which will iterate on queueOnUpdates array and merge all updates with the same key, giving priority to the object whose index is greater. then paste the returned value into Onyx.update

function mergeUpdates(array) {
    // Create a Map to track unique combinations of key and onyxMethod.
    const map = new Map();

    // Iterate through the array from start to end
    array.forEach((item) => {
        const mapKey = `${item.key}`;
        const existingItem = map.get(mapKey);

        // If an object with the same key exists, merge their values.
        if (existingItem) {
            if(item.onyxMethod === Onyx.METHOD.SET){
                // Merge values with priority given to the object with a larger index,
                existingItem.value = {...item.value};
                existingItem.key = Onyx.METHOD.SET;
            }else if(item.onyxMethod === Onyx.METHOD.MERGE || item.key === Onyx.METHOD.MERGE_COLLECTION){
                // Merge values with priority given to the object with a larger index,
                existingItem.value = {...existingItem.value, ...item.value};
            }

            map.set(mapKey, existingItem);
        } else {
            const collectionKey = mapKey.replace(/(.*?_).*/, '$1');
            const collectionUpdates = map.get(collectionKey)

            if(collectionUpdates && collectionUpdates.value[mapKey]){
                collectionUpdates.value[mapKey] = {...collectionUpdates.value[mapKey], ...item.value}
                map.set(collectionKey, collectionUpdates);
                return
            }
            // If it's a new combination, add the item to the map.
            map.set(mapKey, {...item});
        }
    });

    // Return an array of the merged objects.
    return Array.from(map.values());
}

function flushQueue(): Promise<void> {
    return Onyx.update(mergeUpdates(queuedOnyxUpdates)).then(() => {
        queuedOnyxUpdates = [];
    });
}

Proposal
Updated. Add new main solution

@hoangzinh We can open discussion about it in Slack

Yay, we should. @shahinyan11 could you help?

Yes of course

Please make sure any proposed changes to Onyx get discussed in Slack.

@hoangzinh any update on where we're at with this? If you could provide an update by EOD, that would be great 👍

@hoangzinh Sorry but I think you do it better. I don’t know how to write correctly and who to tag

I thought you agreed here. Okay, let me do it.

Sorry. I thought you meant help during discussion

@hoangzinh I oppened disscusion in slack.

But I think I should be compensated if the problem is resolved. I spent a lot of time on this and researched deeply and also came up with a solution close to the one that is currently being developed.
Don't you agree?

@shahinyan11 after discussing this with the team, we would like to offer a partial payment of $125. I've sent you a request in Upwork. Please let me know once you accept and I can get that paid ASAP. Thanks!

@shahinyan11 after discussing this with the team, we would like to offer a partial payment of $125. I've sent you a request in Upwork. Please let me know once you accept and I can get that paid ASAP. Thanks!

I accepted. But isn't it too early? Perhaps the problem will not be solved after the changes

No worries — I just wanted to get the payment in place so we're ready when it launches officially. Thanks @shahinyan11!

On-hold issue is still being worked on 👍

For the on-hold issue, there appears to be a regression tied to the PR here. Bumped for an update 👍

Regression was addressed here — https://github.com/Expensify/react-native-onyx/pull/533 👍

This is on-hold due to merge freeze 👍

Merge freeze will end on Monday 👍

Still waiting for PR associated with the on-hold issue – https://github.com/Expensify/react-native-onyx/pull/523

We're on a merge freeze until next week, so going to be delayed with the PR

Merge freeze goes until Wednesday! 👍

Merge freeze should end today 🤞

Still in reviewing

Still reviewing (latest update here)

Still reviewing 👍

Per this comment, we're in the home stretch!

Still being reviewed as the PR is pretty meaty 👍

Being retested again per the comment here

All changes have been approved in the PR — just waiting for it to be merged!

@hoangzinh can you link me @shahinyan11's original PR for this issue? And do we think the proposed fix will still work or does anything need to be tweaked/adjusted since this issue is from April? Thanks!

Hi there. I had two different solutions. with which we should move forward

@hoangzinh @CortneyOfstad  Hi there. I had two different solutions. with which we should move forward

Thank you @hoangzinh!

@shahinyan11 any updated here? Thanks!

@shahinyan11 any updated here? Thanks!

I can give update on weekend

I am sorry but I have no time to work on it at now

Adjusted — thanks @hoangzinh!

No update on on-hold issue here

That issue is awaiting payment for 7th August. Whatever it was waiting on is now done. Taking it off hold.

@hoangzinh, @CortneyOfstad, is this still an issue?

This works fine for me too, so closing it for now.

@CortneyOfstad Hi, This job is assigned to me on Upwork and is still open. Could you please close this job?

Sorry was OoO — closing now!

Done!


s390x: add s390x travis support

Since we have travis support for s390x. Let's enable it
Signed-off-by: Alice Frosi<EMAIL_ADDRESS>

Coverage decreased (-0.03%) to 79.366% when pulling 6d6b2d88927b6ac858190c70ec9c2185d1457965 on alicefr:enable-travis-s390x into 8cba5a8e5f2816f26f9dc34b8ea968279a5a76eb on intel:master.

Thanks @alicefr.  This is much nicer than the previous solution.


Fix a few issues with e2e-upgrade test

Description
Changes proposed in this pull request:

Allow configuring "master" as the upgrade version to test upgrading to the latest
Separate the e2e-upgrade-azure SKR configmap from the e2e-azure as the two conflict when run concurrently

Related issue(s)

/retest


Youtube Theme

Add Youtube theme using Stylus!
Link for my repo here. You can check the theme here!
Home:

Video:

that was fast!

Hey, very cool! ✨
I just sent you an invitation to join the organization.
I also cloned your repository for Dracula's organization, so you can go ahead and delete or archive yours:

Your repository.
New repository.

Thanks for building this! 🎉

Awesome! Just opened a PR with the install instructions!

Thank you, the theme is already listed on the site! 🚀


[FEATURE] - Aeroponics Drainage Line, Recycling, Flow Sensor

Decide and document how to handle the aeroponics drainage line - partial/selective recycling and waste output? Also implement a flow sensor for subtractive measurement of plant water uptake (vs known spray-flow rate).
Add the decision to the CAD and the solution overview. Maybe edit the script and rerecord the voiceover line covering this to include it?

Will reopen when prototyping resumes

Part of #25


Social Media Buttons

Source: https://bistro125.com/connect.html

[ ] Connect Facebook page or other social media accounts to the right button in Figure 2.
[ ] To connect Email button to D365.

The following task has a similar output when using the Send Message button in Figure 4 but this can be more specific to email but Lead information must merge when using either of the buttons. (TBD: Ask for guidance before starting the following tasks)

[ ] Check if Lead Information is present in D365.
[ ] Check if the dummy customer email receives a welcoming address or AI response.

Figure 1. General photo

Figure 2. Social media needs update

Figure 3. Facebook and Instagram are well connected the the accounts.

Figure 4. Send Message button appears after scrolling down in the right-most part of Figure 1.

@SuzyQuant Can you provide me social media links.


stadusrp_getJobsOnline

ESX.RegisterServerCallback('stadusrp_getJobsOnline', function(source, cb)
Crash cause of
stadusrp_getJobsOnline
TriggerServerCallback => [stadusrp_getJobsOnline] does not exists

It's right here? https://github.com/Stadus/Stadus_Scoreboard/blob/master/scoreboard/server.lua#L53

I think you haven't put the scoreboard after es_extended in server.cfg

TriggerServerCallback => [stadusrp_getJobsOnline] does not exists
Same problem, my scoreboard is after es_extended


CI: only build pushes to master

Summary
What kind of change does this PR introduce? (check at least one)

[ ] Bugfix
[ ] Feature
[ ] Code style update
[ ] Refactor
[ ] Docs
[x] Build-related changes
[ ] Other, please describe:

If changing the UI of web configuration, please provide the before/after screenshot:
Does this PR introduce a breaking change? (check one)

[ ] Yes
[x] No

If yes, please describe the impact and migration path for existing setups:
The PR fulfills these requirements:

[ ] When resolving a specific issue, it's referenced in the PR's body (e.g. Fixes: #xxx[,#xxx], where "xxx" is the issue number)

To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.
Other information:

Hi
After the change, I will not be able to build and upload PR installers myself (only compilation will be performed), and unlocking the upload-artifacts conditions carries some risks. This requires deeper consideration and I need to think about whether this change is necessary and how to secure it.

You could still allow other branches like staging for that.