Add namespace scoping to the Gateway 'port' names (#12500) (#12500)

Currently in order to configure ingressgateway to do TLS termination
using multiple secure virtual hosts with different certificates Istio
requires Gateway 'port' names to be globally unique (i.e. distinct).
I.e. two gateways cannot have secure port named 'https' even if they
reside in different namespaces. Behavior in such case is undefined.
This breaks namespace isolation as a user creating a Gateway in one
namespace might not have access to other namespaces hence can't
if the port name is already 'taken'. Behavior in such case is undefined
and likely to render other virtual hosts unavailable.
This change adds namespace scoping to Gateway port names by appending
namespace suffix to the HTTPS RDS routes. Port names still have to be
unique within the namespace boundaries, but this change makes adding
more specific scoping rather trivial.

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: philrud
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: greghanson
If they are not already assigned, you can assign the PR to them by writing /assign @greghanson in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

pilot/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@philrud: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
5a3804722849739a0121d15b69b5af6056432894
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@philrud: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
5a3804722849739a0121d15b69b5af6056432894
link
/test istio-unit-tests

prow/istio-integ-k8s-tests.sh
5a3804722849739a0121d15b69b5af6056432894
link
/test istio-integ-k8s-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@philrud: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
5a3804722849739a0121d15b69b5af6056432894
link
/test istio-unit-tests

prow/istio-integ-k8s-tests.sh
5a3804722849739a0121d15b69b5af6056432894
link
/test istio-integ-k8s-tests

prow/istio-pilot-multicluster-e2e.sh
5a3804722849739a0121d15b69b5af6056432894
link
/test istio-pilot-multicluster-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@philrud: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-multicluster-e2e.sh
5a3804722849739a0121d15b69b5af6056432894
link
/test istio-pilot-multicluster-e2e

prow/istio-integ-k8s-tests.sh
3d9e254eb381d2089a670b64d4aacb592ff93a8a
link
/test istio-integ-k8s-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@philrud: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-integ-k8s-tests.sh
3d9e254eb381d2089a670b64d4aacb592ff93a8a
link
/test istio-integ-k8s-tests

prow/istio-pilot-multicluster-e2e.sh
3d9e254eb381d2089a670b64d4aacb592ff93a8a
link
/test istio-pilot-multicluster-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test istio-pilot-multicluster-e2e

@philrud: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-integ-k8s-tests.sh
3d9e254eb381d2089a670b64d4aacb592ff93a8a
link
/test istio-integ-k8s-tests

prow/istio-pilot-multicluster-e2e.sh
3d9e254eb381d2089a670b64d4aacb592ff93a8a
link
/test istio-pilot-multicluster-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test istio-pilot-multicluster-e2e

/test istio-integ-k8s-tests

@philrud: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-integ-k8s-tests.sh
3d9e254eb381d2089a670b64d4aacb592ff93a8a
link
/test istio-integ-k8s-tests

prow/istio-pilot-multicluster-e2e.sh
3d9e254eb381d2089a670b64d4aacb592ff93a8a
link
/test istio-pilot-multicluster-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test istio-pilot-multicluster-e2e

@philrud: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-multicluster-e2e.sh
3d9e254eb381d2089a670b64d4aacb592ff93a8a
link
/test istio-pilot-multicluster-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test istio-pilot-multicluster-e2e

This is currently a "draft" as this is unlikely to make it into 1.1. I'm going to rebase this over 1.1.1 once the it's cut. Other than that it's ready for review.

@philrud: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-multicluster-e2e.sh
3d9e254eb381d2089a670b64d4aacb592ff93a8a
link
/test istio-pilot-multicluster-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: philrud
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: rshriram
If they are not already assigned, you can assign the PR to them by writing /assign @rshriram in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

pilot/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@philrud: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-multicluster-e2e.sh
3d9e254eb381d2089a670b64d4aacb592ff93a8a
link
/test istio-pilot-multicluster-e2e

prow/istio-integ-k8s-tests.sh
1e2a68da2bcd0e31a368079299a18707c1b30ad8
link
/test istio-integ-k8s-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@philrud: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-integ-k8s-tests.sh
1e2a68da2bcd0e31a368079299a18707c1b30ad8
link
/test istio-integ-k8s-tests

prow/istio-pilot-multicluster-e2e.sh
1e2a68da2bcd0e31a368079299a18707c1b30ad8
link
/test istio-pilot-multicluster-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rshriram @costinm is there anything else that needs to be addressed? Let me know if not -- I'll squash/rebase this. Thanks!

with this change, is this documentation outdated?
https://istio.io/help/ops/traffic-management/deploy-guidelines/#configuring-multiple-tls-hosts-in-a-gateway


pin to shas and upgrade actions workflows

@cpanato -- Up to you to merge! If you think it's safe, then please do.


Update overview to add new sandbox tutorial links

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/4892/
Test PASSed.

alluxio-bot, merge this please

alluxio-bot, cherry-pick this to master please


GEOMESA-2051 Classpath Documentation for AWS

Infer classpath from 'hadoop classpath' and 'hbase classpath' commands
Better doc for AWS setup

Signed-off-by: Andrew Hulbert<EMAIL_ADDRESS>

i tried to update some more JARS for geoserver. I based it on what I previously added to install-hadoop.sh and install-hbase.sh I will try to do a full validation before release and such but I think its correct for now.

is this ready for merge?

yeah should be. I think that ronq verified it. I will probably try to do some more doc work before 1.4.0 is released.

sounds good, merging


Link to the Azuredeploy.json BYOS gives a 404

When selecting the azuredeploy.json, referenced in the Read.me, it results in a 404
https://github.com/microsoft/OpenHack/blob/main/byos/containers/Instructions/BYOS.md

It's a reference to a file in a private repository, so it won't work. I'm actually currently reworking the containers deployment: https://github.com/microsoft/OpenHack/pull/58


Keras model save error

Hello,
I get another error while saving the magpie model
magpie.save_word2vec_model and magpie.save_scaler works fine but magpie.save_model gives the following error:
File "magpie/main.py", line 270, in save_model
self.keras_model.save(filepath)
AttributeError: 'NoneType' object has no attribute 'save'
So, it might be some issue related to Keras possibly. Any suggestions?
Another question, is there some way to set the number of workers for word2vec model? In the code, I  see that its set to 4 always.

You seem to be trying to save the model before training it. The object is initialized with keras_model=None which is then overwritten when functions like train or batch_train are called. If you save the model before calling one of them, the error will go off. Another point being that Magpie should probably check for None itself and print a reasonable error message, I should fix that.
And for the other question - currently there's no way to do it unfortunately. I'll try to add it to the config.yaml when I have a minute


Hope the anonymous function 'Func' in TypeAliasesKt can add params

We may need permissions that be denied by user to do some extra work. So, I hope the PermissionsRequestFragment's field 'onNeverAskAgain' and 'onPermissionDenied' can  return the denied permissions back.
Related Code:
internal typealias Func = () -> Unit

override fun onRequestPermissionsResult(requestCode: Int, permissions: Array<String>, grantResults: IntArray) {
        super.onRequestPermissionsResult(requestCode, permissions, grantResults)
        if (requestCode == this.requestCode) {
            if (verifyPermissions(*grantResults)) {
                requiresPermission?.invoke()
            } else {
                if (!PermissionUtils.shouldShowRequestPermissionRationale(this, *permissions)) {
                    onNeverAskAgain?.invoke()
                } else {
                    onPermissionDenied?.invoke()
                }
            }
        }
        dismiss()
    }

in my understanding you can easily detect which permission is denied because you explicitly set to a certainwithPermissionsCheck as an argument right?

@hotchemi Yes, but i think we can get denied permissions while verifyPermissions called, then return it by onNeverAskAgain or  onPermissionDenied.
May be more reasonable

@LiPengW Could you elaborate why it's reasonable and convenient if you're seriously proposing the idea? we have not provided the hint even in stable version and we have not got such kind of feedback so.
https://github.com/permissions-dispatcher/PermissionsDispatcher#1-attach-annotations

@hotchemi From my (a ktx lib user) point of view. It is lib's responsablity to tell me Which permissons i applied has be denied, rather than verify by myself.
If you don't think so ,i just close it

Thank you and sorry for the late. After glancing overall your proposal might make sense and let try to come up with a new API interface later on with taking it into account!

@hotchemi thx


Add a rule for missing stop name

What problem in GTFS datasets does this new rule address? Please describe.
The GTFS specification mentions in stops.stop_name:

Conditionally Required:

Required for locations which are stops (location_type=0), stations (location_type=1) or entrances/exits (location_type=2).
Optional for locations which are generic nodes (location_type=3) or boarding areas (location_type=4).

Describe the new validation rule
We should add a rule that would trigger a MissingStopNameNotice if:

(location_type has values 0, 1 or 2) AND (stop_name is missing) for a line in stops.txt

Error vs warning
ERROR

@asvechnikov2 do you have this rule implemented at Google?

Hi @isabelle-dr
Yes, we require for stations and stops to have stop_name. A thing to note that we don't require this for entrances, do you think entrances must have a name?

Hello @asvechnikov2,
Yes, the name is also required for entrances & exits. Would you like to Pull Request the rule you have on this repo, and then we make a second PR with the additional code and use the acceptance test architecture to get the stats? We would know if there are datasets that are passing your rule and that wouldn't pass the new rule. I would be surprised if there are any since it's pretty clear in the specification.

@asvechnikov2 @bdferris-v2
Wanted to bump up this question. I'm able to assist with this issue as needed.

Hello @KClough,
I think we can move forward with this rule. 😊
Are you still planning to write it?

@isabelle-dr yes.


JMatrix should infer size from context

I would like to have a "J" matrix that works similar to uniform scaling. So if I have a matrix A=rand(4,4) for example, I can just write A*JMatrix for example, instead of having to explicitly define the JMatrix(4) size.
I can see two ways of doing this: one way is to just define a new empty type, say SymplecticS, define const S = SymplecticS() (I choose S because in accelerator physics we reserve J for the invariant action and call this matrix S) and then for all operations have it check the size of the other matrix, create the JMatrix and run the current JMatrix operation. This option is least invasive and easy, but redundant.
The other option is to rewrite JMatrix to instead have it not have size n as a field, and infer the size at time of an operation from the other matrix. This option is more invasive, and with my limited knowledge of this package may not be doable/preferred for certain reasons.
Would any of the above options be considered for a PR?

That would be a bit different from the JMatrix type defined here, so in principle it would be a breaking change.  (Though I'm not sure how widely used the skew-Cholesky factorization is in practice; probably not very much.)
(And if it is analogous to UniformScaling, it would also include a scale factor.)


resolved more-always-show-root-contents issue

fixes #3365

Seems that something is borked out in this PR, the GHA do not run...

Seems that something is borked out in this PR, the GHA do not run...

@sneridagh I see all green now.

I think that @tiberiuichim is right... we cannot place the getContent in the Toolbar... I'll test it later, but if I'm not mistaken, that will trigger a double content call (the one in App and this one.
I'll say we have to move it to the contents component, so it only triggers when it's present.

Yeah, two contents:

@MdSahil-oss @tiberiuichim I've moved the re-fetch to Contents.
In the meanwhile ww've discovered a thinggy in the Volto routes definitions, I'll create another PR for fixing it.


Add support for historical uppercase MXIDs

Fix #12
Makes sure to not alter the old logic for fully valid IDs but detects uppercase IDs as historical and doesn't make them lowercase.
This fixes support of IDs like @MTRNord:matrix.ffslfl.net

CI failure is unrelated. Should be fixed on master, please rebase :)

That nasty looking force push is just a rebase ^^


add typing classifier and update maintainers in pyproject

Description
Adds missing typing classifier and updates maintainers in pyproject

@rudolfix I'm not sure what your proposed change is exactly. Put the maintainers as authors and add a comment in the license or what do you have in mind?

@sh-rp nvm. I should stop adding non-actionable thoughts :)


[MM-232] Update plugin with respect to phase 1 upgrades

Summary
Updated plugin with respect to phase 1 upgrades

Updated go version from 1.12 to 1.21
Updated build folder to sync with starter template
Updated package in go modules to use https://pkg.go.dev/github.com/mattermost/mattermost/server/public
Updated Makefile
Updated version in nvmrc file and update package-lock.json file.
Added base setup for typescript
Added base setup for test cases
Fix lint errors
Updated developer docs link in the readme file

Ticket Link

Codecov Report
Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (b60a4e9) 15.03% compared to head (66c0e24) 15.22%.

Files
Patch %
Lines

server/utils.go
72.72%
3 Missing :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #129      +/-   ##
==========================================
+ Coverage   15.03%   15.22%   +0.18%
==========================================
  Files          13       12       -1
  Lines        2301     2306       +5
==========================================
+ Hits          346      351       +5
  Misses       1936     1936
  Partials       19       19

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Enable customization of TabBar's InkWell

Description
TabBar's InkWell is barely customizable. This PR allows greater customization of TabBar.
Related Issues
#69397
Tests
I added the following tests:

[WIP] Tab feedback
[WIP] Tab overlayColors can be applied

Checklist

[x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[x] I signed the CLA.
[x] I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
[x] I read the Tree Hygiene wiki page, which explains my responsibilities.
[x] I updated/added relevant documentation (doc comments with ///).
[x] All existing and new tests are passing.
[x] The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
[x] I am willing to follow-up on review comments in a timely manner.

Breaking Change
Did any tests fail when I ran them?

[x] No, no existing tests failed, so this is not a breaking change.

cc @chunhtai

Also, I need a little help with the tests.

Done!


Using with markdown in vimwiki

I am trying to use nabla.nvim in a md file. However, it keeps reporting expect a lua number line 482. Are there any solutions ?

I cannot reproduce this error on my config.
Does it also give an error on an empty file (not markdown)?

Sorry for late response, i reinstall the plugin and everything works flawlessly. Thank you for your help and great plugins.


nan is not supported when i declare a request body class with an object having default value as nan

I was using fastAPI through swagger UI, In one instance i had defined request body as class with one of the class object of the request body having default value as numpy.nan.
Example code :
import numpy
class Model(pydantic.BaseModel):
    value: float = numpy.nan

app.get('/this')
def get_this(request_body: Model):
    return request_body.value

this is the error i got on the swagger UI when i tried testing the API on swagger UI.

This is the logs:
←[32mINFO←[0m:     <IP_ADDRESS>:58758 - "←[1mGET /openapi.json HTTP/1.1←[0m" ←[91m500 Internal Server Error←[0m
←[31mERROR←[0m:    Exception in ASGI application
Traceback (most recent call last):
  File "C:\ProgramData\Anaconda3\lib\site-packages\uvicorn\protocols\http\h11_impl.py", line 388, in run_asgi
    result = await app(self.scope, self.receive, self.send)
  File "C:\ProgramData\Anaconda3\lib\site-packages\uvicorn\middleware\proxy_headers.py", line 45, in __call__
    return await self.app(scope, receive, send)
  File "C:\ProgramData\Anaconda3\lib\site-packages\fastapi\applications.py", line 181, in __call__
    await super().__call__(scope, receive, send)
  File "C:\ProgramData\Anaconda3\lib\site-packages\starlette\applications.py", line 111, in __call__
    await self.middleware_stack(scope, receive, send)
  File "C:\ProgramData\Anaconda3\lib\site-packages\starlette\middleware\errors.py", line 181, in __call__
    raise exc from None
  File "C:\ProgramData\Anaconda3\lib\site-packages\starlette\middleware\errors.py", line 159, in __call__
    await self.app(scope, receive, _send)
  File "C:\ProgramData\Anaconda3\lib\site-packages\starlette\middleware\cors.py", line 78, in __call__
    await self.app(scope, receive, send)
  File "C:\ProgramData\Anaconda3\lib\site-packages\starlette\exceptions.py", line 82, in __call__
    raise exc from None
  File "C:\ProgramData\Anaconda3\lib\site-packages\starlette\exceptions.py", line 71, in __call__
    await self.app(scope, receive, sender)
  File "C:\ProgramData\Anaconda3\lib\site-packages\starlette\routing.py", line 566, in __call__
    await route.handle(scope, receive, send)
  File "C:\ProgramData\Anaconda3\lib\site-packages\starlette\routing.py", line 227, in handle
    await self.app(scope, receive, send)
  File "C:\ProgramData\Anaconda3\lib\site-packages\starlette\routing.py", line 41, in app
    response = await func(request)
  File "C:\ProgramData\Anaconda3\lib\site-packages\fastapi\applications.py", line 130, in openapi
    return JSONResponse(self.openapi())
  File "C:\ProgramData\Anaconda3\lib\site-packages\starlette\responses.py", line 49, in __init__
    self.body = self.render(content)
  File "C:\ProgramData\Anaconda3\lib\site-packages\starlette\responses.py", line 162, in render
    separators=(",", ":"),
  File "C:\ProgramData\Anaconda3\lib\json\__init__.py", line 238, in dumps
    **kw).encode(obj)
  File "C:\ProgramData\Anaconda3\lib\json\encoder.py", line 199, in encode
    chunks = self.iterencode(o, _one_shot=True)
  File "C:\ProgramData\Anaconda3\lib\json\encoder.py", line 257, in iterencode
    return _iterencode(o, 0)
ValueError: Out of range float values are not JSON compliant

This is a tooling issue. Based on what you shared it looks like an issue with fastAPI, so you should file a  ticket with them.


Update data centre location

Data centre location can be anywhere since GA

Thanks Marian! this is a good spot 👍👍 thank you for contributing


Branch 3.1 dev

Fixes #issue
What type of PR is this:

[ ] BugFix
[ ] Feature
[ ] Enhancement
[ ] Refactor
[ ] UT
[ ] Doc
[ ] Tool

Checklist:

[ ] I have added test cases for my bug fix or my new feature
[ ] This pr will affect users' behaviors
[ ] This pr needs user documentation (for new or modified features or behaviors)

[ ] I have added documentation for my new feature or new function

Bugfix cherry-pick branch check:

[ ] I have checked the version labels which the pr will be auto-backported to the target branch

[ ] 3.1
[ ] 3.0
[ ] 2.5
[ ] 2.4

[FE PR Coverage Check]
:disappointed: fail : 7 / 11 (63.64%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
com/starrocks/privilege/StorageVolumePEntryObject.java
2
6
33.33%
[124, 125, 126, 128]

:large_blue_circle:
com/starrocks/sql/analyzer/PrivilegeCheckerVisitor.java
1
1
100.00%
[]

:large_blue_circle:
com/starrocks/common/ErrorCode.java
2
2
100.00%
[]

:large_blue_circle:
com/starrocks/sql/analyzer/PrivilegeChecker.java
2
2
100.00%
[]


Volt voltage is not displayed

Because Volt voltage (High / Low) is not written, it's confusing to know which is which apart from the APY (can be misleading).
I would put which voltage next to SOL title ==> SOL (low) or SOL (high), otherwise, the only indication is the APY.

had an issue with the "skeleton" placeholder,
problem solved 👍🏻


Unbounded queue in ThresholdBundler.closedBundles

Copying over some possible issues found in https://github.com/GoogleCloudPlatform/google-cloud-java/issues/1432:

com.google.api.gax.bundling.ThresholdBundler has an unbounded queue for closedBundles that will fill endlessly if an application is publishing faster than the queue can be drained, or if draining/publishing can't occur at all for some reason. We've seen on a few instances (3-5 applications out of 1000s) that this eventually leads to a OutOfMemoryError as the heap space fills up.

It seems like if the thread that ThresholdBundlingForwarder starts dies for any reason, it won't be restarted, and the messages accumulating in the Bundler will not be processed at all (eventually leading to the OOM above).

I am only familiar with the bundling behavior as it is used in google-cloud-pubsub, but for the first issue I think it may make sense for the Bundler to allow for specifying a maximum number of bundles/items that it will hold onto, and then either reject new items from being added or drop the oldest bundles/items when this limit is hit.

So the bundling system will propagate service success results and service failures (as exceptions), but it doesn't propagate failures to initiate the service call. If that was propagated to the caller, then the caller wouldn't keep providing more and more messages with no feedback on the failures.

If that was propagated to the caller, then the caller wouldn't keep providing more and more messages with no feedback on the failures.

Do you mean the caller of e.g. com.google.cloud.pubsub.PubSub? This would seem to require the application developer to develop some sort of "should I publish?" state and logic, whereas the ability to set a maximum limit on the number of items stored by the bundling system seems like it could prevent unbounded memory usage at a more foundational level. Of course, these aren't mutually exclusive though.

Here is the scenario I'm describing:

Main thread calls publish 100 times
The bundler combines those publish calls into a bundle, tries to publish to the service
The service call fails with UNAUTHENTICATED
Currently, this will kill the bundling thread, and the main thread will not see any failures. My suggestion: have each call site that called publish throw an exception indicating UNAUTHENTICATED, and clear out the bundle from the bundler because it failed.

Basically, any terminal state on an attempt to publish a bundle should clear out the bundle from closedBundles and propagate the exception to the call sites that called publish. There really shouldn't be any reason to keep them around.

@pongad could you make sure this gets addressed for pubsub?

I think both issues are solved in the new implementation.

You can set FlowControlSettings to either throw or block when there are too many messages in the queue.
The publish method is not asynchronous, returning Future<String>. Any error will propagate to caller of future.get().

@pongad do you mean "now asynchronous"?

@mattnworb Yes I did!

We now have flow control in ThresholdBundler, which is (1) in the requester's list. As for the processing thread dying (2), that might get fixed with converting the bundler to a push model. Assigning to @michaelbausor to verify as part of his bundling changes.

Correct, (1) is resolved by flow control, and (2) is resolved by converting to a pushing bundler, which gets rid of dedicated threads and uses an executor instead.


Added two load events for convenience, which include the module name

Added two load events for convenience, which include the module name in the event name itself, so the user could easily listen for a specific module load.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Fixing progress bar console errors

Pull Request Template

Please provide all of the details below. Pull requests missing any of the information below will be closed!
Providing the issue number/url helps us identify the problem being solved and keep the issues tab clean and tidy

Summarise what this PR fixes
Somebody was selecting an invalid class .scroll-line with querySelector and tried to update the style property of the null element in ProgressBar.js file. I removed the line of code because there doesn't exists any element with class scroll-line. And now there are no errors.
<Detail your PR changes/fixes>
What ISSUE NUMBER does this fix?
Fixes #264

Checklist:
(Add an x between the brackets to check the items)

[x] I have summarised what this PR fixes above
[x] I have provided the issue ID/URL above
[x] This PR fixes only the issue mentioned above (create separate PRs for separate issues)
[x] I was the first one to claim the issue or I created the issue

Pull Request Template

Please provide all of the details below. Pull requests missing any of the information below will be closed!
Providing the issue number/url helps us identify the problem being solved and keep the issues tab clean and tidy

Summarise what this PR fixes
Somebody was selecting an invalid class .scroll-line with querySelector and tried to update the style property of the null element in ProgressBar.js file. I removed the line of code because there doesn't exists any element with class scroll-line. And now there are no errors.
<Detail your PR changes/fixes>
What ISSUE NUMBER does this fix?
Fixes #264

Checklist:
(Add an x between the brackets to check the items)

[x]  I have summarised what this PR fixes above
[x]  I have provided the issue ID/URL above
[x]  This PR fixes only the issue mentioned above (create separate PRs for separate issues)
[x]  I was the first one to claim the issue or I created the issue

You could add a div element at the beginning of the body tag like -  Then the progress bar will show up on top of the website.


feat(icon): export icons for compose

This PR exports the following icons in the Teams theme:

bold
code-snippet
emoji
italic
link
meeting-new
number-list
quote
sticker
table
underline

Also, please take a look into the screener changed, and ensure that only the new icons are added and there is no regression to the previos icons.

@kuzhelov I think it shows as stardust-ui:master because I'm merging from my Fork. I'm not an "official" contributor so I couldn't create a branch within the main fork.

@joheredi, now this omission is fixed :)

Submitting a new PR against master


Feature/13 code clean

Pull request connected to issue #13 tracking changes
Linting

[x] Improve code formatting with uniform spacing and lines
[x] Remove obsolete code disabled by comments

Documentation

[x] Correct spelling and grammar of code comments
[x] Translate remaining code comments to English
[x] Improve documentation regarding installation, setting secrets, and building
[x] Code examples in separate directory

Refactoring

[x] Refactor build params system removing "YES_" and "NOT_", replacing with documentation
[x] Folder structure to make maintenance and code responsibility clearer

@Stef-aap a large amount of refactoring has been made, but only a few things differ from the original code. I would suggest fetching the fork and looking through the project structure rather than trying to look at GitHub diffs, as these are quite hard to follow. Feel free to request changes :)

Following PR closes #13


Mock external resources during testing.

Good testing practice would have us mock external responses.
For example - in many places we hit the autograder.
Here's a way that should be easy enough to mock the autograder http://stackoverflow.com/a/32140760
Key content:
import mock
...
   def my_test(self):
        with mock.patch.object(requests, 'get') as get_mock:
            get_mock.return_value = mock_response = mock.Mock()
            mock_response.status_code = 200
            mock_response.content = {'twitter_handle': '@twitter'}
            assert requests.get('http://fakeeeee.com').status_code == 200

We would mock requests.post to return a 200 (or maybe if the point is not to test the autograder, then we could just mock the send_to_ag function)

This was surprisingly hard to make work in all cases. Maybe the best approach is to use a library that specializes in mocking requests from requests.
https://github.com/getsentry/responses looks interesting.

@Sumukh i could do this one, but it will take time, i'll read the source first.

Cool. Not super mandatory - but good to have so our tests don't hit the production autograder :)

You can assign this to me, i'll try to up my local server. This is the updated docs for autograder right? https://okpy.github.io/documentation/autograder.html

@jezeniel Unfortunately I never got around to documenting the OK integration. Autograder.py in this repo should help though.


Rename hook object to context

As a result of this discussion https://github.com/feathersjs/feathers-hooks/issues/159 .
Already started with https://github.com/feathersjs/feathers-hooks-common/pull/200 .

To avoid confusion we should make sure that we change it everywhere in the docs (especially https://docs.feathersjs.com/api/hooks.html#hook-objects).

Changed in lib/, changed in Buzzard docs. Not changed in tests/.


Expand renderToPipeableStream()’s documentation

The documentation to renderToPipeableStream() is a sparse. For example, the current documentation links out the React source code for a full list of options. It also doesn’t explain that you can opt-out of the inline <script> approach by using the onAllReady callback.
This is a draft that I hope can be iterated on to clarify and expand the documentation. I won’t be offended if you don’t like my long headings or how I’ve structure it. I hope it provides a good first step to explain the core behaviour.
See: https://twitter.com/dan_abramov/status/1521297849593614339
Note that some terms seem interchangeable. I’ve tried using “ready” as that what the callbacks are named. It perhaps would be helpful to settle on canonical terms for:

Suspended content blocks vs suspended content boundaries
Ready vs Resolved vs Loaded vs Unsuspended
Initial HTML vs Initial HTML shell

BTW in a quick search for usage of this function I didn’t find many examples of people “doing it right” with regards to error handling so I feel that documentation might help here: https://github.com/search?q=renderToPipeableStream&type=code

I have created a little project to test renderToPipeableStream() in different scenarios: https://github.com/BurntCaramel/renderToPipeableStreamPlayground

There might be some new stuff to document from the 18.2.0 release: https://github.com/facebook/react/releases/tag/v18.2.0

Addressed this via https://github.com/reactjs/reactjs.org/pull/5339. Thank you for starting this.


Dependabot closes some of its own terraform PRs with no human intervantion

Is there an existing issue for this?

[X] I have searched the existing issues

Related issues include:

https://github.com/dependabot/dependabot-core/issues/439  -- closed in 2018
https://github.com/dependabot/dependabot-core/issues/10019 -- still open, but doesn't exactly describe this issue, and is for a different package ecosystem (npm)

Package ecosystem
terraform
Manifest location and content before the Dependabot update
You can see a minimal reproduction in this git repo.
I have two main.tf files, one in /production and one in /staging.
dependabot.yml content
version: 2
updates:
  - package-ecosystem: "terraform"
    directories:
      - "**/*"
    schedule:
      interval: daily
    open-pull-requests-limit: 5

What you expected to see, versus what you actually saw
I expected to get two similar PRs, one for staging, and one for production.
I actually got the two PRs I expect, but then without any human intervention, dependabot closed the production one.
Looking at the closed PR, we can see why:

Superseded by #2.

To be clear, PR 2 did not accurately supersede PR 1. Both PRs were needed. One updated staging, the other updated prod. Dependabot incorrectly believed that if we updated staging, prod would be fine.
I would like for Dependabot to open the two PRs exactly as it did, but for it not to then immediately close one of them.
Smallest manifest that reproduces the issue
The smallest reproduction I could come up with is at https://github.com/totherme/dependabot-testing

I rewrote the superseding logic the other day, this is fixed now: https://github.com/jakecoffman/dependabot-testing/pulls
Thanks for the minimal reproduction!


How to train on a self-constructed dataset

I want to train DAIN on a self-constucted HD video dataset, can you give me some suggestions on the details? Should I do resize or cropping to make the HD video dataset same as Vimeo90K dataset?
Thank you in advance for your reply.

This is a problem, and I didn't find any document or instructions about this. Maybe we can just setup our own dataset with Vimeo90K dataset. Now I am downloading Vimeo90K dataset, if I succeed , maybe we can discuss on this.


fix(deps): update gomod

This PR contains the following updates:

Package
Type
Update
Change

github.com/IBM/platform-services-go-sdk
require
patch
v0.32.1 -> v0.32.2

github.com/gruntwork-io/terratest
require
patch
v0.41.12 -> v0.41.15

Release Notes

IBM/platform-services-go-sdk
v0.32.2
Compare Source
Bug Fixes

Global Search: remove is_hidden param from search operation (#239) (67937e4)

gruntwork-io/terratest
v0.41.15
Compare Source

Description

Updated dependency golang.org/x/crypto from 0.0.0-20210921155107-089bfa567519 to 0.1.0.

Related links

https://github.com/gruntwork-io/terratest/pull/1254

v0.41.14
Compare Source

Description

Updated dependency github.com/opencontainers/image-spec from 1.0.1 to 1.0.2.

Related links

https://github.com/gruntwork-io/terratest/pull/1255

v0.41.13
Compare Source

Description

Updated dependency golang.org/x/net from 0.1.0 to 0.7.0

Related links

https://github.com/gruntwork-io/terratest/pull/1253

Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.

[ ] If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

:tada: This PR is included in version 1.7.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Create back for products

Need to create backend for GET /api/products for fetching all products from DB and GET /api/products/:id for fetching selected product

Added routes http://localhost:5000/api/games returns all games and their count, http://localhost:5000/api/games/:id returns game by ID, http://localhost:5000/api/games/discounted returns all discounted games and their count


Remove kyuubi dependency of the spark lineage plugin

Why are the changes needed?

Remove kyuubi dependency of the spark lineage plugin.
How was this patch tested?

[X] Add some test cases that check the changes thoroughly including negative and positive cases if possible

[X] Add screenshots for manual tests if appropriate

[X] Run test locally before make a pull request

cc @pan3793 @iodone

Codecov Report

Merging #3537 (71b1150) into master (66f28ef) will decrease coverage by 0.00%.
The diff coverage is 50.00%.

@@             Coverage Diff              @@
##             master    #3537      +/-   ##
============================================
- Coverage     51.66%   51.65%   -0.01%
  Complexity       13       13
============================================
  Files           482      486       +4
  Lines         26933    27015      +82
  Branches       3760     3772      +12
============================================
+ Hits          13914    13955      +41
- Misses        11663    11699      +36
- Partials       1356     1361       +5

Impacted Files
Coverage Δ

...bi/plugin/lineage/helper/SparkListenerHelper.scala
33.33% <ø> (ø)

...in/lineage/helper/SparkSQLLineageParseHelper.scala
63.24% <0.00%> (+0.54%)
:arrow_up:

...kyuubi/engine/spark/events/EngineEventsStore.scala
83.33% <0.00%> (-16.67%)
:arrow_down:

...kyuubi/plugin/lineage/helper/SemanticVersion.scala
39.28% <39.28%> (ø)

...gine/spark/events/SparkOperationLineageEvent.scala
40.00% <40.00%> (ø)

.../SparkOperationLineageQueryExecutionListener.scala
66.66% <50.00%> (ø)

...che/spark/kyuubi/SparkSQLEngineEventListener.scala
41.46% <50.00%> (+0.83%)
:arrow_up:

...ala/org/apache/spark/kyuubi/SparkUtilsHelper.scala
87.50% <80.00%> (-12.50%)
:arrow_down:

...ne/spark/events/OperationLineageEventWrapper.scala
85.71% <85.71%> (ø)

.../plugin/lineage/events/OperationLineageEvent.scala
66.66% <100.00%> (+2.66%)
:arrow_up:

... and 12 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

cc @pan3793 @iodone

What is the reason for the removal? Is it possible to have the lineage plugin applied to the custom spark engine that is not Kyubi Engine?

Is it possible to have the lineage plugin applied to the custom spark engine that is not Kyubi Engine?

Yes, I would prefer it to remove kyuubi dependencies and be able to use it in any spark application.

@iodone , thanks for your review, sorry for replying so late.

@wForget #3444, In order to implement the PlanOnly mode of lineage,  imported SQLParserHelper with spark-lineage-plugin. This will cause the kyuubi spark engine to strongly depend on spark-lineage-plugin.
Are you in favor of this usage, and if that holds true, your implementation here could just refer directly to spark-lineage-plugin. WDYT?

A general question, what a spark plugin has to rely on the kyuubi code path?

A general question, why does a spark plugin have to rely on the kyuubi code path?

The current lineage plugin is more like a kyuubi spark engine plugin, we rely on kyuubi-events module to produce kyuubi lineage event. This pr wants to change lineage to spark event, in order to remove kyuubi dependency.
However, I thought we might use lineage spark event in engine later such as show it on spark ui, so I introduced lineage plugin dependency in kyuubi engine again.

So we can not call it a plugin, it's a upstream package

oh, I mess this PR with @iodone's one

Glancing at the comments, I think the author and reviewers reached a consensus the lineage plugin should be a pure Spark plugin and should not depend on kyuubi-common, kyuubi-event modules, but have some arguments on the relationship between kyuubi-spark-sql-engine and kyuubi-spark-lineage, so, can we narrow this PR scope into making kyuubi-spark-lineage independent w/ kyuubi-event? Some users want to use this plugin along w/ the latest release kyuubi-spark-sql-engine but got class conflict error since there were incompatible changes that occurred in kyuubi-event.

Glancing at the comments, I think the author and reviewers reached a consensus the lineage plugin should be a pure Spark plugin and should not depend on kyuubi-common, kyuubi-event modules, but have some arguments on the relationship between kyuubi-spark-sql-engine and kyuubi-spark-lineage, so, can we narrow this PR scope into making kyuubi-spark-lineage independent w/ kyuubi-event?

Good idea. I will narrow this PR scope.

seems unrelated failure:
AdminResourceSuite:
- delete engine - user share level *** FAILED ***
  List("serviceUri=localhost:32971;version=1.7.0-SNAPSHOT;refId=8bd0f165-37a6-49cf-af67-d82f7a0b3cbb;sequence=0000000000") had size 1 instead of expected size 0 (AdminResourceSuite.scala:103)

seems unrelated failure:
AdminResourceSuite:
- delete engine - user share level *** FAILED ***
  List("serviceUri=localhost:32971;version=1.7.0-SNAPSHOT;refId=8bd0f165-37a6-49cf-af67-d82f7a0b3cbb;sequence=0000000000") had size 1 instead of expected size 0 (AdminResourceSuite.scala:103)

I have the same problem in #3558 , but other unrelated changes do not trigger this failure case.

seems unrelated failure:
AdminResourceSuite:
- delete engine - user share level *** FAILED ***
  List("serviceUri=localhost:32971;version=1.7.0-SNAPSHOT;refId=8bd0f165-37a6-49cf-af67-d82f7a0b3cbb;sequence=0000000000") had size 1 instead of expected size 0 (AdminResourceSuite.scala:103)

I have the same problem in #3558 , but other unrelated changes do not trigger this failure case.

This test case doesn't use the kyuubi-spark-lineage plugin, let me re-run the check.

seems unrelated failure:
AdminResourceSuite:
- delete engine - user share level *** FAILED ***
  List("serviceUri=localhost:32971;version=1.7.0-SNAPSHOT;refId=8bd0f165-37a6-49cf-af67-d82f7a0b3cbb;sequence=0000000000") had size 1 instead of expected size 0 (AdminResourceSuite.scala:103)

I have the same problem in #3558 , but other unrelated changes do not trigger this failure case.

This test case doesn't use the kyuubi-spark-lineage plugin, let me re-run the check.

In my case, this failure case still exists with re-running

In my case, this failure case still exists with re-running

It is being followed up in #3753, let's try again later.

Thanks, merging to master


Thread limits not respected

Cluster runs sometimes fail with CPU limit exceeded. We need to investigate whether an existing mechanism exists and why it is not working, or implement a new mechanism. Tried ompthreads=8, as in documentation, without success.
Threads are from TBB, not OpenMP. Investigate.

See the Known Issues section in Developer Guide


Lower frame rate on route switch or listview scroll with finger

write a simple demo
use fultter built-in navigator
use flutter listview

when route switch （with finger） on iphone xs， frame rate so Lower， the same demo with rn better than flutter demo。
the same on listview scroll with finger。
so，i hope flutter team optimization performance on route switch wih fingre and listview scroll with finger。if this problem can be solve，flutter will perfect。

I think we should first solve the problem of fluency, then solve the engineering and development efficiency of flutter development for Android and IOS platforms, and finally support the web, don't give up all the costs.

In the xian fish app recommended by flutter, the frame rate of the page switching with finger is significantly lower than that of the app native page.

@abarth

@warfrogsdf , I agree with the non as performance as native especially in Android (list view), my iPhone SE works pretty good in list view, and there's issues about iPhone Xs as well

Hi, could you please confirm if this problem still exists with the latest versions on stable or master?
Also does this happen on Android and iOS?
Thanks a lot

this problem only in ios platform, iphone x and iphone xs, maybe skia problem

Could you please add the output of flutter doctor here?

is skia on ihone x xs problem, maybe flutter 1.10.x resovled this problem.

Hi,
what do you mean by * flutter 1.10.x resovled this problem.* have you tried on latest master and the problem is gone?

Without additional information, we are unfortunately not sure how to resolve this issue. We are therefore reluctantly going to close this bug for now. Please don't hesitate to comment on the bug if you have any more information for us; we will reopen it right away!
Thanks for your contribution.


Backport "HBASE-27651 hbase-daemon.sh foreground_start should propagate SIGHUP and SIGTERM" to branch-2.5

Introduce separate traps for SIGHUP vs. the rest. Treat SIGINT, SIGKILL, and EXIT identically, as before. Use the signal name without SIG prefix for increased portability, as per the POSIX man page for trap.
SIGTERM handler will now honor HBASE_STOP_TIMEOUT as described in the file header.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 25s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+0 :ok:
shelldocs
0m  0s
Shelldocs was not available.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ branch-2.5 Compile Tests _

+1 :green_heart:
spotless
0m 46s
branch has no errors when running spotless:check.

_ Patch Compile Tests _

+1 :green_heart:
shellcheck
0m  1s
The patch generated 0 new + 126 unchanged - 12 fixed = 126 total (was 138)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
spotless
0m 39s
patch has no errors when running spotless:check.

_ Other Tests _

+1 :green_heart:
asflicense
0m 10s
The patch does not generate ASF License warnings.

3m 20s

Subsystem
Report/Notes

Docker
ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5127/1/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5127

Optional Tests
dupname asflicense spotless shellcheck shelldocs

uname
Linux b887b387bb6d 5.4.0-137-generic #154-Ubuntu SMP Thu Jan 5 17:03:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2.5 / 0bc7f56a00

Max. process+thread count
43 (vs. ulimit of 30000)

modules
C: . U: .

 U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5127/1/console

versions
git=2.34.1 maven=3.8.6

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.


The performance on NLVR2

Hi, have you ever finetune OFA on NLVR2? I tried to finetune by early-fusion (encoder inputs), mid-fusion (encoder outputs), and late-fusion (decoder outputs), but all the results are not very good (around 74% Acc). How do you think about? Are there better methods to finetune on NLVR2?

@zd11024 We haven't tried finetuning OFA on NLVR2. Since OFA has only processed single image in the pre-training stage, I think a better way might be 1. concat the two images into one image as the input of OFA; 2. fine-tune it like SNLI-VE.

I will try it later. Many thanks!


Add viewfs to HA_SCHEMES to support ViewFs file system

closing #28611

@Abacn can you help to review this PR?

@bvolpato Thanks very much


ts error on custom selectors inside properties

Description
When selecting a custom selector using a string as key in the object, typescript will complain that it only accepts known values:
const className = css({
borderColor: {
base: 'gray.800',
_focusWithin: 'purple.600',
// @ts-ignore
'&:has([aria-invalid])': 'red.7',
}
})
this works, but typescript will complain.
Alternativelly, you can create a condition, like invalidWithin:
conditions: {
extends: {
invalidWithin: '&:has([aria-invalid="true"])',
}
}
this will work, because now typescript recognizes it. But I still think that '&:has([aria-invalid])' should be recognized too.
Link to Reproduction
https://github.com/FilipePfluck/panda-bugs
Steps to reproduce
clone the repo
go to app/layout.tsx
uncomment the //@ts-ignore
JS Framework
React (TS)
Panda CSS Version
0.10.0
Browser
No response
Operating System

[ ] macOS
[ ] Windows
[X] Linux

Additional Information
No response

This is a TS limitation at the moment. Loosening the type to support any selector will break the existing typings.
Please put the selector on the root object instead.


Add options to configure how traits are rendered in Rust

This PR adds the following TraitOptions configuration object to the Rust renderer allowing users to tweak how traits are rendered in their clients.
export type TraitOptions = {
    /** The default traits to implement for all types. */
    baseDefaults?: string[];
    /**
     * The default traits to implement for data enums only — on top of the base defaults.
     * Data enums are enums with at least one non-unit variant.
     */
    dataEnumDefaults?: string[];
    /**
     * The mapping of feature flags to traits.
     * For each entry, the traits will be rendered within a
     * `#[cfg(feature = "feature_name", derive(Traits))]` attribute.
     */
    featureFlags?: Record<string, string[]>;
    /** The complete trait overrides of specific types. */
    overrides?: Record<string, string[]>;
    /**
     * The default traits to implement for scalar enums only — on top of the base defaults.
     * Scalar enums are enums with no variants or only unit variants.
     */
    scalarEnumDefaults?: string[];
    /** The default traits to implement for structs only — on top of the base defaults. */
    structDefaults?: string[];
    /** Whether or not to use the fully qualified name for traits, instead of importing them. */
    useFullyQualifiedName?: boolean;
};

The default values for these options are:
export const DEFAULT_TRAIT_OPTIONS: Required<TraitOptions> = {
    baseDefaults: [
        'borsh::BorshSerialize',
        'borsh::BorshDeserialize',
        'serde::Serialize',
        'serde::Deserialize',
        'Clone',
        'Debug',
        'Eq',
        'PartialEq',
    ],
    dataEnumDefaults: [],
    featureFlags: { serde: ['serde::Serialize', 'serde::Deserialize'] },
    overrides: {},
    scalarEnumDefaults: ['Copy', 'PartialOrd', 'Hash', 'num_derive::FromPrimitive'],
    structDefaults: [],
    useFullyQualifiedName: false,
};

See readme changes for more details.

Some traits like bytemuck's Pod also require #[repr(C)]. Even without bytemuck, some types may want to use this (like enums). Should we include a config for repr?

@buffalojoec Would this be a blocker for you right now on some programs? If not, let's wait until more people ask for it. Otherwise, we can brainstorm a new representation option inside this traitOptions object asap.

Some traits like bytemuck's Pod also require #[repr(C)]. Even without bytemuck, some types may want to use this (like enums). Should we include a config for repr?

@buffalojoec Would this be a blocker for you right now on some programs? If not, let's wait until more people ask for it. Otherwise, we can brainstorm a new representation option inside this traitOptions object asap.

Nope, not a blocker for me. I think if anyone tries to use the new trait configs to set up bytemuck traits then they'll hit the repr problem, but we can wait for that yep.


[Bug?] How to make createVar works?

Hey, I saw all these issues https://github.com/macaron-css/macaron/issues/52 https://github.com/macaron-css/macaron/issues/49 https://github.com/macaron-css/macaron/issues/36
Example doesn't work properly and show an error
Warning: Unsupported style property var(--_1dagh370). Did you mean var(-_1dagh370)?

The I tried to import assignInlineVars but I couldn't
import { assignInlineVars } from "@macaron-css/core/dynamic";

Did I do something wrong?
"@macaron-css/core": "^1.2.0",
"@macaron-css/react": "^1.4.0",
"@macaron-css/vite": "^1.4.3",

Hi @dhutaryan, which version of TS are you using? Older TS versions don't work with the exports condition, but the new ones do.

I use 5.2.2. Updated it to 5.4.5 but it didn't help. Could it be something with tsconfig?

Is the moduleResolution in your tsconfig one of node16, nodenext, or bundler? If not try setting it to one of these, as only these ones support package.json "exports"

"moduleResolution": "bundler" helped, thank you

@Mokshit06 using bundler, yet the issue persists. These are project's versions,
"@macaron-css/core": "1.5.2",
"@macaron-css/react": "1.5.3",
"@macaron-css/vite": "1.5.1",


Use categories file to validate categories

Make add-url and generate-rss use the categories file to validate categories.

Fixed by #112


operator uma-operator (2024.3.2)

/test skip check_pruned_graph

/ok-to-test

/ok-to-test

/ok-to-test


Missmath in State boundary

it is to bring in notice that the state boundary provided in indian shape file is wrong please do check the Telangana & Andrapradesh Boundary where both state should cut Chattisgarh state, but as provided it is not please do rectify it

This issue can be seen in the Khammam  district area.

We need to correct the Boundries according to the map present at http://www.surveyofindia.gov.in/pages/display/117-state-maps


style(form-field): use easing function for underline

Tried to match what I see in this animation, but am curious if there are any official curves/durations from the UX team. In either case, I think some easing function is better than linear.
cc @mmalerba and note that no one is CODEOWNER of form-field

Whoops sorry, missed this PR somehow. I don't think they give any official curves. I just eyed it when I created the original animation, forgot to add the opacity though.


Passing Blade "Additional Attributes" Through Blade Components

Laravel Version
11.9.2
PHP Version
8.2.19
Database Driver & Version
N/A
Description
As we know, Blade offers us convenient attributes as HTML-related directives:

Readonly
Disabled
Checked
Selected
Required

The problem is that when we try to pass these attributes to a Blade component, the directive compiles successfully, but the component does not:
Considering the Laravel Breeze text-input component:

When we write this:

<x-app-layout>
    <x-slot name="header">

            {{ __('Dashboard') }}

    </x-slot>

    <x-text-input label="Name" @required(true) />

                    {{ __("You're logged in!") }}

</x-app-layout>

Note: In the above example, we only wrote <x-text-input label="Name" @required(true) /> in the middle of the file.

The output is:

Steps To Reproduce

Prepare a fresh Laravel 11 application using Laravel Breeze (with Alpine)
Run the application
Open the dashboard.blade.php
Insert the following content in the middle of the file: <x-text-input label="Name" @required(true) />
Use the browser's dev tools to check the HTML rendered as demonstrated in the description of this ticket.

This isn't supported unfortunately: https://laravel.com/docs/11.x/blade#component-attributes


"undefined" string throws error in template with custom syntax

Using the custom syntax from the test in utility.js:
_.templateSettings = {
  evaluate    : /\{\{([\s\S]+?)\}\}/g,
  interpolate : /\{\{=([\s\S]+?)\}\}/g
};

Any semblance of the property undefined or string "undefined" will throw the error:

"'undefined' is not a function (evaluating 'code.replace(/\'/g, "'")')"

For example, the following test will fail:
var customUndefined = _.template("
{{ if (people != 'undefined') { }}
{{= people }}
{{ } }}
");
result = customUndefined({people : "Moe"});
equals(result, "

Moe

", 'can run arbitrary javascript in templates');

Very silly error. Just needed to define "escape" in templateSettings. Since escape was undefined it was matching "undefined" anywhere in the template. Erp!


bash-init.sh

Trying to use this repository with a different debian image due to restrictions for my product. But I don't know see the bash-init.sh anywhere in the repo for reference?
COPY .shared/lib/bash-init.sh /opt/bash-init.sh

It is located here https://github.com/vegardit/docker-shared/blob/v1/lib/bash-init.sh
We use the same bash init script in multiple dockerbrepos/images so it is in a shared repo.


IPv6 known issues

FluentBit cannot start https://github.com/envoyproxy/gateway/pull/4525
Listen on <IP_ADDRESS> stead of ::1 in IPv6 first cluster https://github.com/envoyproxy/gateway/pull/4573
xds_cluster dns faield to reslove, may related to https://github.com/envoyproxy/gateway/pull/4533.
e2e pod like grpc-ext-auth failed to start, may https://github.com/envoyproxy/gateway/issues/3866 help. https://github.com/envoyproxy/gateway/pull/4576
RateLimit cannot start on IPv6 https://github.com/envoyproxy/ratelimit/pull/748
net.SplitHostPort return Failed to parse host "[fc00:f853:ccd:e793::ce:80]": address [fc00:f853:ccd:e793::ce:80]: missing port in address, because // A literal IPv6 address in hostport must be enclosed in square // brackets, as in "[::1]:80", "[::1%lo0]:80".  https://github.com/envoyproxy/gateway/issues/4597

cc @arkodg @juwon8891

Another issue:
kubectl logs -n gateway-conformance-infra setup-keycloak-z2rrm
Defaulted container "setup-keycloak" out of: setup-keycloak, wait-for-keycloak (init)
+ /opt/keycloak/bin/kcadm.sh create users -s username=oidcuser -s enabled=true --server http://keycloak --realm master --user admin --password admin
Logging into http://keycloak as user admin of realm master
HTTPS required [invalid_request]

cc @zhaohuabing

Another issue:
kubectl logs -n gateway-conformance-infra setup-keycloak-z2rrm
Defaulted container "setup-keycloak" out of: setup-keycloak, wait-for-keycloak (init)
+ /opt/keycloak/bin/kcadm.sh create users -s username=oidcuser -s enabled=true --server http://keycloak --realm master --user admin --password admin
Logging into http://keycloak as user admin of realm master
HTTPS required [invalid_request]

cc @zhaohuabing

Fixed in https://github.com/envoyproxy/gateway/pull/4601


Multiple Assertions per HTTP Request

Expected behavior
When adding more than one assertion under an HTTP Request, and one of the assertions fails, the request should be marked as failed, independent of which one of the assertions fails.
Actual behavior
The HTTP Request is marked succeeded when the last assertion succeeds. It seems the result of the previous assertions is overridden by the last one.
Steps to reproduce the problem
The issue was perfectly described in someone elses bug report from june https://github.com/apache/jmeter/issues/5677.
For reasons that I could not see, the issue was closed as invalid.
Yet I run into the same issue. Did I miss something?
JMeter Version
5.5
Java Version
openjdk version "11.0.11" 2021-04-20
OS Version
Windows 11 22H2

I think, this is intended behaviour, as it allows the assertions to switch a failing request to be OK. The most prominent example for this is the ResponseAssertion, that has the ignore status switch for exactly this use case.
That said, I think the referenced issue #5677 was not closed on purpose and the feature is surprising to say at least. We should think about how to better support both use cases.

Can you post a minimal test plan, that exposes the described behaviour?

Hi Felix,
thanks for your quick response. I've tried provide you a sample of the described behavior.
The attached plan contains 4 calls to the github API. Each request is the same.
All four calls use a Response-Assertion that checks the return code only and a JSON-Assertion that checks a property within the response.
The first two calls (A + B) should have a failing response code assertion as they expect 500, which should not happen.
The last two calls (C + D) should have a failing JSON-Assertion, since I put an arbitrary value that will not exist.
The order of Response-Assertion and JSON-Assertion is switched between A + B and C + D.
The Expected result is that all four requests have a failing assertion and should therefore fail.
But case C will only have a failing JSON-Assertion, while the request is still marked as succeeded.
While playing around with it, I noticed that I can get that request to be marked as failed too, when I change
the  ignore status flag of the Response-Assertion next to it.
Ok, strictly seen, in my test example, the ignore status flag doesn't need to be checked, because the response code is 200, thus it won't fail it. But in a scenario where I want to test the contents of a JSON response where the expected code is 400, it would need to have it checked.
I understood the ignore status switch to be scoped to what is defined by the Response-Assertion only without affecting other Assertions. What do you think?
Sample_5734.zip

Hi Felix,
just wanted to check back and see, if the sample I provided helped in any way.
Would be great, if you could hint about it.
Cheers!


[Feature] translate

Problem Summary:
Fixes # 22703
What type of PR is this:

[ ] BugFix
[x] Feature
[ ] Enhancement
[ ] Refactor
[ ] UT
[ ] Doc
[ ] Tool

Checklist:

[x] I have added test cases for my bug fix or my new feature
[ ] This pr will affect users' behaviors
[ ] This pr needs user documentation (for new or modified features or behaviors)

[ ] I have added documentation for my new feature or new function

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

[FE PR Coverage Check]
:heart_eyes: pass : 0 / 0 (0%)

[FE PR Coverage Check]
:heart_eyes: pass : 0 / 0 (0%)

[FE PR Coverage Check]
:heart_eyes: pass : 0 / 0 (0%)

[FE PR Coverage Check]
:heart_eyes: pass : 0 / 0 (0%)

OK , but I wonder if translate should support utf-8 characters?

OK , but I wonder if translate should support utf-8 characters?

@YinZheng-Sun Yes, since the format of VARCHAR in SR is UTF-8.
For now in this PR, translate only considers the ASCII characters, but it cannot deal with the non-ASCII characters, each of which consists of multiple bytes.
For example, SELECT TRANSLATE('测a试', '测试', '12') should return 1a2.
IMO, we should implement two versions of TRANSLATE: one is for from_string and to_string which only contains ASCII characters, and the other is for those contains non-ASCII characters.
You could see StringFunctions::pad_prepare for inspiration:
Status StringFunctions::pad_prepare(FunctionContext* context, FunctionContext::FunctionStateScope scope) {

    state->fill = ColumnHelper::get_const_value<TYPE_VARCHAR>(pad_column);
    // `fill_utf8_index` stores the boundary index of each character in `fill`.
    // `fill_is_utf8==false` indicates that `fill` only contains ASCII characters.
    state->fill_is_utf8 = state->fill.size > get_utf8_index(state->fill, &state->fill_utf8_index);
}

and pad_const_not_null:
    if (src_is_utf8 && pad_state->fill_is_utf8) {
        return pad_utf8_const<true, true, pad_type>(columns, src, (uint8_t*)fill.data, fill.size, len,
                                                    pad_state->fill_utf8_index);
    } else if (src_is_utf8) {
        return pad_utf8_const<true, false, pad_type>(columns, src, (uint8_t*)fill.data, fill.size, len,
                                                     pad_state->fill_utf8_index);
    } else if (pad_state->fill_is_utf8) {
        return pad_utf8_const<false, true, pad_type>(columns, src, (uint8_t*)fill.data, fill.size, len,
                                                     pad_state->fill_utf8_index);
    } else {
        return ascii_pad_ascii_const<pad_type>(columns, src, (uint8_t*)fill.data, fill.size, len);
    }

THX，I will have a try

hi @YinZheng-Sun hows everything going :)


changed profile page, slight alterations to weights page

Centered and made profile page look less empty and made some slight changes to the weights page

The bottom bar covers some information on the profile page for me


Fetch default informations from Github

For open-source tools that have a public repo on GitHub, we could fetch some info directly from GitHub.
When I browse to https://www.thenewdynamic.org/tool/static-man/
Then description, license and stargazers are returned by GitHub API https://api.github.com/repos/eduardoboucas/staticman

When I add a new tool with a GitHub repo
Then description, license and stargazers are automagically filled from GitHub

Related: https://github.com/thenewdynamic-org/thenewdynamic.org/issues/9


Stl generator

Code as is cannot generate more than one object at one time.

Fixed, was a different issue than I had thought


How I can use it over https?

I've getting this error: ERR_SSL_PROTOCOL_ERROR, but http works fine

sorry.


Selecting View Message Log on submission redirects to the user's dashboard

When looking at application details and selecting View Message Log on the right, a client-side error of Uncaught ReferenceError: NProgress is not defined occurs, redirecting the user to their dashboard.

@theskumar Yeah I think I was misguided, seems like that error was a coincidence because it doesn't log anything anymore

@frjo what does it take to be set as is_staff? I was both staff & staff admin

This pipeline should set it on any new user who's e-mail address are in STAFF_EMAIL_DOMAINS.
https://github.com/HyphaApp/hypha/blob/37b2f494a1ec871f425719ff8f13978ee6aea57a/hypha/apply/users/pipeline.py#L7-L13
P.S. We should rename this to make_hypha_staff

@theskumar I think this is still unresolved. I can look at this next though because I don't think that make_otf_staff function is working properly as I wasn't able to see the message log, nor could any of the other staff. Could we just check for staff admin instead of is_staff and get rid of that function as a whole?


Improve search results and add Top 20 Most Popular tokens

Problem:
During user tests, I discover that users have problems understanding how the wallet works. They think if something is not listed in the wallet tab - it is not available. And even if they try to look for a specific coin in the Add/Hide Tokens - if they can't search or find tokens they want to transfer to the wallet - they assume these tokens are not available for this wallet.
One user thought that a coin is not available because it was not listed in the wallet tab. So there was a wrong assumption that if something was not visible, it must be unavailable.
Solution:

Below "Hidden Tokens" add another section called "Popular Tokens" where we list the top 20 most popular erc20 tokens.
https://zpl.io/2j0gqPA
The Search box in Add/Hide Tokens should display (as a result of searching) even those tokens that are out of the wallet, but still, ERC20.
https://zpl.io/bAMM9YP
Add Search bar (working the same way as 2) to the Add Custom Token screen.
https://zpl.io/VQwwLgA

Not related but can be updated along with this change:
4. Update the Plus icon symbol to https://zpl.io/aXxvAAK
5. Remove Plus icon symbol from the wallet (leave just a text "Add/Hide Tokens"
https://zpl.io/aRdOwWK

Hey @hboon: How much time do you think this work will cost us?
Not a priority at the moment, as I am considering the feasibility of testing a beta version of the flow on Android before confirming the final flows and then implementing on iOS.
This is to help iOS to focus on Bartercard and Activity implementations for now.

@AW-STJ Can we scope it down and just do:

The Search box in Add/Hide Tokens should display (as a result of searching) even those tokens that are out of the wallet, but still, ERC20.  https://zpl.io/bAMM9YP

Excluding (1) and (3) means less work to go live, but I also thought that it wouldn't work as well. It's going to be a long list, users wouldn't see it anyway. But we can start with (2) and if works, think a bit more about this?

Below "Hidden Tokens" add another section called "Popular Tokens" where we list the top 20 most popular erc20 tokens.  https://zpl.io/2j0gqPA
Add Search bar (working the same way as 2) to the Add Custom Token screen.  https://zpl.io/VQwwLgA

Process-related, this is a good hint that it shouldn't be written into the same issue: "Not related but can be updated along with this change":

Update the Plus icon symbol to https://zpl.io/aXxvAAK
Remove Plus icon symbol from the wallet (leave just a text "Add/Hide Tokens"
https://zpl.io/aRdOwWK

@AW-STJ we can let Vlad have a go at it. Just keep BC at higher priority and he can sort it out.

Unassigned Vlad for now. Re-assign once it's decided.

Close from inactivity

Reopening the issue as this was pointed out by a user, where the user expected to see the list of popular tokens.
Not a priority item, but opening the issue for tracking.

Closing the issue and creating a new one https://github.com/AlphaWallet/alpha-wallet-ios/issues/2845


Remove dev styling from compiled css and update pipeline

We don't want dev specific css in compiled output in dist, as observed in user research.
This PR addresses this by:

creating separate app only sass entry points where $mq-show-breakpoints is included
updates app layout template to reference app*.css files
modifying scss:compile task to use either app*.scss or govuk-frontend*.scss files as source for compilation
adding test to check for presence of that string in compiled stylesheets

Additionally:

removes magic commenting with gulp-replace and gulp-replaces from dependencies
adds a file helper function to read contents of a file for a given path

the flow is now as follows:

if dev then compile app*.scss with mq-show-breapointsand anthing else we might want to include in teh review app
if dist then compile govuk-frontend*.scss without mq-show-breakpoints

This should also address #556
https://trello.com/c/woTnvOTx/801-remove-active-breakpoint-debug-helper-from-dist-css

reverted removing oldie compilation

@36degrees forgot to add changelog. still ok with it?

LGTM.


Update mqtt.util.js to correct spelling in verbose log message

Very minor PR to correct something which irritates me every day :-)

Thx


Generalize TextDiagramDrawer to allow drawing outline boxes

This issue is harder than it sounds. But I do think it's important for us to start being able to draw multi-qubit boxes in text diagrams and in the latex output.

Box interiors should cover lines but not text entries. The layer order is lines then boxes then text.

When a Box border intersects a line, it should produce the appropriate unicode character.
┌─┬┐
│ ││
├─┼┤
└─┴┘
┏━┳┓
┃ ┃┃
┣━╋┫
┗━┻┛

Including if the line is emphasized and the box is not┍┯┑
┝┿┥
┕┷┙
┎┰┒
┠╂┨
┖┸┚

(Opinion) boxes may have their corners at half-coordinates, so that they can be used to surround a text cell without inserting an extra column or row.

 Each cell specifies a min width, min height, text, left/up/down/right line character, and a center line character. The more general render method can produce a bunch of cells, and then the cell rendered can handle picky layout details like sizing.

Untested code for 4:
TextDiagramCell = NamedTuple('TextDiagramCell', [
    ('center', str),
    ('left_line', str),
    ('right_line', str),
    ('up_line', str),
    ('down_line', str),
    ('text', str),
    ('min_width', int),
    ('min_height', int),
])

def render_cell_lines(cell: TextDiagramCell,
                      width: int,
                      height: int) -> List[str]:
    out = collections.defaultdict(lambda: ' ')
    cy = height // 2
    cx = width // 2

    if cell.left_line:
        for x in range(cx):
            out[(x, cy)] = cell.left_line
    if cell.right_line:
        for x in range(cx + 1, width):
            out[(x, cy)] = cell.right_line
    if cell.up_line:
        for y in range(cy):
            out[(cx, y)] = cell.up_line
    if cell.down_line:
        for y in range(cy + 1, height):
            out[(cx, y)] = cell.down_line
    if cell.center:
        out[cx, cy] = cell.center

    lines = cell.text.split('\n')
    lines_height = len(lines)
    lines_width = max(len(line) for line in lines)
    off_x = (width - lines_width) // 2
    off_y = (height - lines_height) // 2
    for dy, line in enumerate(lines):
        for dx, c in enumerate(line):
            if 0 <= dx < width and 0 <= dy < height:
                out[(off_x + dx, off_y + dy)] = c

    return [
        ''.join(
            out[(x, y)]
            for x in range(width)
        )
        for y in range(height)
    ]

def render_cell_row(cells: List[TextDiagramCell],
                    widths: List[int]) -> str:
    height = max(
        max(cell.min_height, len(cell.text.split('\n')))
        for cell in cells
    )

    cell_lines = [
        render_cell_lines(cell, width, height)
        for cell, width in zip(cells, widths)
        for y in range(height)
    ]

    if not cell_lines:
        return ''

    transposed = zip(*cell_lines)
    return '\n'.join(
        ''.join(line_parts)
        for line_parts in transposed
    )

def render_cell_grid(width: int,
                     height: int,
                     cell_at: Callable[[int, int], TextDiagramCell]) -> str:
    widths = []
    for x in range(width):
        col_width = 0
        for y in range(height):
            c = cell_at(x, y)
            lines = c.text.split('\n')
            min_text_width = max(len(line) for line in lines)
            col_width = max(col_width, c.min_width, min_text_width)
        widths.append(col_width)

    rendered_rows = []
    for y in range(height):
        cells = [cell_at(x, y) for x in range(width)]
        rendered_rows.append(render_cell_row(cells, widths))
    return '\n'.join(rendered_rows)

How would the boxes be specified?

Presumably
diagram.box(x, y, width, height)

I meant at a higher level. I imagibe you'd want to box a set of operations or something like that. Relatedly, what use case(s) do you have in mind?

Ah. I try to keep the functionality of TextDiagramDrawer generic enough that it's not about circuits, but the reason for adding this feature is to do a better job of printing circuits with gates that act on adjacent qubits. For example, if you were printing a linear swap network with swaps between adjacent qubits then you could have a box that says "XX^0.5" instead of an XX^0.5 linked by a line to an XX on the other qubit. Gates could opt into this functionality by specifying additional details in their diagram info.

I see. Something similar is done in qcircuit, but the difference there is that it's just a matter of changing the wire symbols to use the "multigate" macro.

If boxes are "in front" of lines (1), under what circumstances would a line cross a box (2)? Would we need to allow intersecting boxes?

Whenever a box is placed over a line, the line intersects the side of the box as it crosses behind the box. This requires a character to indicate the line apparently terminating into the side of the box.
For intersecting boxes... I guess we could go with last-added-wins and treat previous box boundaries as lines.

The problem I see with the gridlines-at-half-integers approach is that gates on adjacent qubits should look like
    ┌─┐
    │G|
    └─┘
    ┌─┐
    │G│
    └─┘

rather than
    ┌─┐
    │G|
    ├─┤
    │G│
    └─┘

See #1240 for a first step in an alternative direction:

Implement TextDiagramDrawer.vertical_cut a la TextDiagramDrawer.horizontal_cut.
Implement TextDiagramDrawer.add_boxes that
a) Checks that boxes don't intersect.
b) Inserts columns and rows around boxes with zero padding, taking into account that a set of boxes may have the same column or row as a boundary and only adding one there.
c) Writes corner elements as text entries.
d) Cuts existing lines through boxes
e) Writes new lines for box boundaries.

@Strilanc I think this is maybe stale with current BlockDiagramDrawer.  Do you think there is more that needs to be done?

Close this as stale with the current BlockDiagramDrawer. There are also other issues tracking the need to have better visualizations support in Cirq.


Input not working issue

In FL Studio 21, input is not working with the Glicol VST. I saw your demonstration on YouTube using Ableton 11. Thank you.
ps. I have tried it on Windows 11.

Seems to be the same problem using "VSTHost": https://www.hermannseib.com/english/vsthost.htm
I assume the comment on the YT video is relevant:

It doesn't work with Reaper so far. It makes sound on Reaper but the GUI seems to be buggy. I think this will be solved when the relevant GUI dependencies get update some day. For Renoise I haven't used that before.


Suzaku EX timeline ends too early

https://github.com/quisquous/cactbot/blob/master/ui/raidboss/data/timelines/suzaku-ex.txt is ending on the soft enrage(?) rather than the real one (with all fields purple).
I've been going through the logs and it should look like this at the end:
665.2 "Scarlet Hymn" sync /:Suzaku:3237:/
680.6 "Ruthless/Mesmerizing" sync /:Suzaku:32D(A|B):/
685.8 "Hotspot x8" duration 7.7
700.7 "Southron Star" sync /:Suzaku:32DF:/
705.2 "Hotspot x8" duration 7.7
724.1 "Phantom Flurry" sync /:Suzaku:32DD:/
730.3 "Phantom Half" sync /:Suzaku:32DE:/
735.8 "Scarlet Hymn" sync /:Suzaku:3237:/
748.8 "Southron Star"
755.0 "Enrage"

The last Southron Star at 748.8 can also be omitted since it's a long cast, ending after the enrage mechanic.

Perfect, thanks.  I'll add this in before the next release.

I think this is a Bug... sometimes the purple fields will be there at ~8:40 but sometimes you will get a fourth colour phase ... I don't know what the real enrage timer is. Also the cast bar for the enrage is filling up slowly but as the phoenix reaches the first purple thing its a wipe. I think there will be a fix in the next days / weeks.

8:40 would be matching where usually the 4+4+4+4 pattern appears... so apparently you can push dps so hard that you skip two entire phases? 8:40 is definitely a bug/unintended behavior because there are only around 30 groups that killed Suzaku in <9min on fflogs. Enrage at 11:15 (one phase-skip) seems more plausible but I think 12:45 is the "normal" one.

Also the cast bar for the enrage is filling up slowly but as the phoenix reaches the first purple thing its a wipe.
Yea I noticed that as well. She casts a very slow Southron Star while all fields are purple. Not sure what the purpose is.

Actually the timings are off, despite them using log timings, feels like a solid 10 seconds.

Thanks for the log.  I don't know what to do about the early enrage possibility, so I'm just going to leave the timeline assuming it will go long.

Yea it probably makes sense just to keep it one way until square fixes it to however it is intended.


bufferline breaking changes

https://github.com/akinsho/bufferline.nvim/pull/497 did a breaking change in the way hilights are done. I've been trying to poke around at getting things working again but no luck yet to report. Especially problematic is switching between light and dark and back

Same here. And i've made sure that the colorscheme is loaded before bufferline

Hmm, the only bufferline support we have is in https://github.com/rose-pine/neovim/blob/main/lua/rose-pine/plugins/bufferline.lua:
	buffer_visible = {
		guifg = p.subtle,
		guibg = p.base,
	},
	buffer_selected = {
		guifg = p.text,
		guibg = p.surface,
		gui = 'bold,italic',
	},

If you are using that, or a variation of that, perhaps this change would fix it:
	buffer_visible = {
-		guifg = p.subtle,
-		guibg = p.base,
+		fg = p.subtle,
+		bg = p.base,
	},
	buffer_selected = {
-		fg = p.text,
-		bg = p.surface,
+		fg = p.text,
+		bg = p.surface,
		gui = 'bold,italic',
	},

Please let me know if I'm misunderstanding, I don't personally use bufferline.

I wasn't actauly using that file in my setup before. Everything just worked out of the box (both light&dark and swapping between the two while running) without any custom setup for bufferine.
I've since tried

using the file as described in the wiki
editing it to be fg instead of guifg
link to another group that rose-pine creates

With no luck yet. I'll keep poking at it

And i've made sure that the colorscheme is loaded before bufferline

Me too, 100% sure that it's before by not even using the packer setup stuff, manually having rose-pine first, then colorscheme then buffer line. Still bufferline shows up with the dark colors from rose-pine even when starting in light mode.
I have found out though that if I call the bufferline setup function again manually well after everything is loaded, it'll then use the light theme colors.
Then switching to dark mode with set background=dark, bufferline keeps the light mode colors.
I have one last thing I want to try, but figured I should share progress

https://github.com/akinsho/bufferline.nvim/issues/512 seems related maybe? I wonder if you're able to call bufferline setup multiple times (e.g. using an autocmd when background changes) or if that messes things up

That was actually the thing I wanted to try. I've also thought maybe setting all of these groups manually might work, but I'm trying to figure out a programmatic way to get the list and what colors it happened to pick but maybe it'd be faster to just power through it manually

So far, recalling setup in the autocommand seems to be working, but I'll keep my eye out for that causing problems
local use = require("util.packer").use
use "moll/vim-bbye"
use "akinsho/bufferline.nvim"

local config = function()
  require("bufferline").setup {
    options = {
      numbers = "none", -- | "ordinal" | "buffer_id" | "both" | function({ ordinal, id, lower, raise }): string
      close_command = "Bdelete! %d", -- can be a string | function, see "Mouse actions"
      right_mouse_command = "Bdelete! %d", -- can be a string | function, see "Mouse actions"
      left_mouse_command = "buffer %d", -- can be a string | function, see "Mouse actions"
      indicator_icon = "▎",
      buffer_close_icon = "",
      modified_icon = "●",
      close_icon = "",
      left_trunc_marker = "",
      right_trunc_marker = "",
      max_name_length = 30,
      max_prefix_length = 30, -- prefix used when a buffer is de-duplicated
      tab_size = 21,
      diagnostics = false, -- | "nvim_lsp" | "coc",
      diagnostics_update_in_insert = false,
      offsets = { { filetype = "NvimTree", text = "", padding = 1 } },
      show_buffer_icons = true,
      show_buffer_close_icons = true,
      show_close_icon = true,
      show_tab_indicators = true,
      persist_buffer_sort = true, -- whether or not custom sorted buffers should persist
      separator_style = "thin", -- | "thick" | "thin" | { 'any', 'any' },
      enforce_regular_tabs = true,
      always_show_bufferline = true,
    },
  }
end

config()
vim.api.nvim_create_autocmd("OptionSet", {
  pattern ="background",
  callback = config,
  group = vim.api.nvim_create_augroup("bufferline color", { clear = true }),
})

I had it working then it broke again, and now it's always be on exactly the wrong color (like always light bar in dark mode and dark bar in light mode).
So I give up. Every time I launch neovim I start fiddling with it and don’t get much real work done haha. I'm going to just stick on bufferline tag v2.5.1 until that breaks with some neovim change or something and I'm forced to update.

it has been fixed 523

Thanks for keeping track of it @AnthonyK213 and posting here! Everything is great now. I'm going to close it.


Remove dependencies from Green Donut when provided by framework

Product
Green Donut
Is your feature request related to a problem?
I want to reduce the package size & amount of dependencies to reduce surface area for CVE'S.
The solution you'd like
I would like that any dependency that can be provided by the framework ie System.Text.Json the framework is leveraged to reduce dependencies.

Happy to submit this as a PR

You can have a stab at greendonut ... we have started already grouping the references by framework version ...
  <ItemGroup>
    <PackageReference Include="System.Threading.Tasks.Extensions" Version="4.5.0" />
  </ItemGroup>

  <ItemGroup Condition="'$(TargetFramework)' == 'net8.0'">
    <PackageReference Include="System.Diagnostics.DiagnosticSource" Version="8.0.0" />
    <PackageReference Include="Microsoft.Extensions.ObjectPool" Version="8.0.0" />
  </ItemGroup>

  <ItemGroup Condition="'$(TargetFramework)' == 'net7.0'">
    <PackageReference Include="System.Diagnostics.DiagnosticSource" Version="7.0.0" />
    <PackageReference Include="Microsoft.Extensions.ObjectPool" Version="7.0.0" />
  </ItemGroup>

  <ItemGroup Condition="'$(TargetFramework)' == 'net6.0' OR '$(TargetFramework)' == 'netstandard2.1' OR '$(TargetFramework)' == 'netstandard2.0'">
    <PackageReference Include="System.Diagnostics.DiagnosticSource" Version="6.0.0" />
    <PackageReference Include="Microsoft.Extensions.ObjectPool" Version="6.0.0" />
  </ItemGroup>

Start with a PR for GreenDonut and then we will work through this.
I am closing the other issues as they are juts clogging the backlog.

PR will be done before Monday

Pr all submitted. as mentioned in #6869 & #6870 happy to do those libraries in a similar manner to reduce the dependency graph.


chore: upgrade snakenet to v0.9.16

based on #358
fixes #362

spams this message when syncing, but still proceeds to sync
Listener: Ignoring invalid protocol:  due to A protocol (name) is invalid.

spams this message when syncing, but still proceeds to sync
Listener: Ignoring invalid protocol:  due to A protocol (name) is invalid.

spams this message when syncing, but still proceeds to sync
Listener: Ignoring invalid protocol:  due to A protocol (name) is invalid.

protocol name is for grandpa config. currently set to default value. What name can it be set ? any hints ?

spams this message when syncing, but still proceeds to sync
Listener: Ignoring invalid protocol:  due to A protocol (name) is invalid.

protocol name is set for grandpa config. currently set to default value. What name can it be set to ? any hints ?

i would use "standard procotol name" construction as is used in polkadot https://github.com/paritytech/polkadot/blob/43b390f289fbe2054fbc86dd91f79dee314dc689/node/service/src/lib.rs#L777

pls update deps to the latest polkadot-0.9.16 / release-0.9.16 revisions, parity cherrypicked new stuff there


append mode for serializers

fixes #346
adding append feature into the serializers themselves.

@juttle/developers this is the first step to have append feature for file (and other adapters that use the adapter/serializers) I even added the last commit in this PR for adding this feature to the file adapter but will move that to a follow up PR just to show how this works. Currently you can append jsonl and csv and all others will throw an exception.

@davidvgalbraith @demmer you guys would be the best ones to review this.

@davidvgalbraith noicer ?

And I'll move that last commit to its own PR once this is ready to merge and merge without that last commit...

Did we already do jsonl? Don't see it in the diff.

@davidvgalbraith it just "works" as long as you provide a stream that is at the point of appending (which in the case of a file means opening it in append mode). I've added the missing test to the jsonl serializer tests to validate this does in fact work.

+1


Hasan

Pre Steps

Expected Behavior

Current Behavior

Steps to Reproduce (for bugs)

Versions

Homebridge: homebridge --version
Node:       node --version
OS:

Configuration

Homebridge Log / Command Output

hasanmoha webtv


Fix: syntax error, unexpected ')'

I ran into this error yesterday, just removing the "," error solves it.
Error: syntax error, unexpected ')'

https://github.com/laravel/framework/issues?q=is%3Aissue+comma+error+is%3Aclosed+
TL;DR: the syntax is fine, you need PHP 7.3

https://github.com/laravel/framework/issues?q=is%3Aissue+comma+error+is%3Aclosed+
TL;DR: the syntax is fine, you need PHP 7.3

Im using
PHP 7.3.12 (cli) (built: Nov 19 2019 13:58:02) ( ZTS MSVC15 (Visual C++ 2017) x64 )
Copyright (c) 1997-2018 The PHP Group
Zend Engine v3.3.12, Copyright (c) 1998-2018 Zend Technologies

@oscarafdev you pasted your cli version - "PHP 7.3.12 (cli)". I believe your server PHP is 7.2


Switch GCR to Artifact-Registry

/kind technical-debt
Special notes for your reviewer
As discussed with @oliver-goetz :
switch to releases registry (policy: keep all images "forever"):

image: eu.gcr.io/gardener-project/ci-infra/*
--registry=eu.gcr.io/gardener-project/ci-infra
krte

Switch other occurrences to snapshots registry (policy: automatically purge any image after 30d).

@oliver-goetz : thanks for reviewing - I squashed your suggestions


👷 Deduplicate cron GHA through workflow reuse

This patch melts most of the separate cron workflow into the main CI workflow which it then includes as reusable.
Such an approach allows for less duplication of the same CI steps while keeping the cron workflow as a separate entity.

It is a bit complex due to the slight differences. Hopefully, we'll rethink those later. I didn't know that cron tested against the pip main branch but there was also another cron in the main workflow that added the usual latest+previous. Plus, it's not really clear why we skip coverage in one of the cron runs. Maybe we could get rid of that conditional as well. That's if someone wants a follow up improvement..

I think I managed to simple it a bit.