[QUERY] What is the .NET SDK approach to SemVer?

Library name and version
All
Query/Question
Summary: I expect .NET SDK libraries to follow SemVer, but some don't and I'd like to understand why that is and whether it will change in the upcoming new libraries.
Top-level Guidelines
From the overall Azure SDK guidelines, it's pretty clear that SemVer is the north star for package versioning across all supported languages, with the caveat that the SDKs in various languages may follow different conventions.
The .NET-specific guidelines on that page don't explicitly address whether .NET packages use SemVer, but do strongly imply that they do, both by the example of a stable release incrementing after release goes from 1.1.0 to 1.2.0-beta.1, incrementing the minor version as expected, as well as by not calling out any divergence from the top-level guidance.
.NET-specific Guidelines
Unfortunately, the .NET-specific guidelines add some complication by addressing breaking changes in clients in this way:

DO introduce a new package (with new assembly names, new namespace names, and new type names) if you must do an API breaking change.
Breaking changes should happen rarely, if ever. Register your intent to do a breaking change with adparch. You’ll need to have a discussion with the language architect before approval.

These guidelines do imply SevVer:

DO use MAJOR.MINOR.PATCH format for the version of the library dll and the NuGet package.

Some Libraries Don't Follow Semver
As an example, the Azure.Identity library is a new client library that should follow the latest guidelines. However, a recent breaking change was published along with a minor version bump. When this was flagged as an issue, the response was that Azure.Identity doesn't follow SemVer.
Should consumers of the .NET Azure SDK libraries following the latest guidelines expect SemVer? It seems that there should be a unified approach for the new libraries, and SemVer did seem to be expected with the new libraries. I'd love to see all .NET SDK libraries follow SemVer, but at the least, it seems that the documentation should be updated to indicate that not all .NET libraries do.
Environment
No response

//cc: @schaabs, @christothes

Thank you for your feedback.  Tagging and routing to the team member best able to assist.

@SeanFeldman

Library name and version
All
.NET-specific Guidelines
Unfortunately, the .NET-specific guidelines add some complication by addressing breaking changes in clients in this way:

DO introduce a new package (with new assembly names, new namespace names, and new type names) if you must do an API breaking change.
Breaking changes should happen rarely, if ever. Register your intent to do a breaking change with adparch. You’ll need to have a discussion with the language architect before approval.

Hi @jovinson-ms - The Guidelines quoted above essentially state that we will avoid breaking changes if at all possible, but there are some rare exceptions (usually security related). We do document breaking changes explicitly in changlelogs, which seems more discoverable than stating in the guidelines that this may occur without a fully new assembly and type names.

Thank you for the elaborate description, @KrzysztofCwalina.
Personally, I'd rather see Azure SDKs following SemVer than provide a false MAJOR.MINOR.PATCH version on the packages.
I would like to comment on point a. While it's plausible, it's never guaranteed that it can always be achieved. And rather than cornering yourself with no API-breaking changes at all costs, a new major version is a well-established industry indicator of potentially breaking changes.
Looking at SemVer 2 and Azure SDK guidelines, those are not conflicting in a way to avoid following more stricter versioning policies.

Given a version number MAJOR.MINOR.PATCH, increment the:
MAJOR version when you make incompatible API changes
MINOR version when you add functionality in a backwards compatible manner
PATCH version when you make backwards compatible bug fixes

When you write

Having said that, I agree with the point that we should have used the major version bump as a way to communicate (see point c above) to users that this release contains changes (behavioral breaking change) that require a bit more attention when upgrading. We will try to be more careful with this in the future.

You must remember those breaking changes do not require "a bit more attention". They require rigorous testing and verification. And that's precisely what's SemVer's objective is. As a consumer of the libraries that follow SemVer, remove surprises and have clear expectations about the changes a new version introduces.

Really appreciate the replies, @KrzysztofCwalina and @christothes. I think we may be looking at different angles of the versioning issue: I'm focusing on how the breaking change is communicated to the consumer, not on how the build system resolves dependencies.
First off, I appreciate the point that .NET's issues with dependency resolution are not resolved simply by using SemVer - any time breaking changes are introduced, there's the possibility of successfully compiling code that breaks under certain circumstances. As you point out, the current .NET Azure SDK guidelines avoid this problem by saying breaking changes have to be in a new namespace (with no exception mentioned for security patches). This approach makes sense for the runtime, but:

it's quite limiting, and has issues with discoverability when changes are needed
doesn't match the guidance for versioning libraries which suggests using SemVer
most importantly, I don't think it's being followed by the .NET Azure SDKs - API breaking changes are regularly introduced with a minor version bump

As @christothes explains above, the approach that libraries are taking is to communicate a breaking change via minor version bump (in this case, minor) for stable version, while prerelease versions are free to change. So the reality as a consumer of these packages is that every time I upgrade one of the packages, there's a possibility that my code breaks, or that behavior has changed. The risk of encountering a dependency issue is still there whether the bumped version is major or minor. It sounds like communicating this via a major version bump is on the table, which would align with SemVer. That would be great!
As a side point, I read the guidelines to say that a breaking change requires a new namespace, which requires adparch approval, not that a breaking change can be communicated via version bump as long as there's adparch approval. If I'm reading it wrong, I suspect others are as well. If the actual practice is that breaking changes are introduced via minor version bumps, (but only with approval), then the guidelines should say that in my opinion.

+ 1 for semantic versioning in these libraries. Especially on a website where many repositories are having their NuGet packages automatically updated via Dependabot, communicating breaking changes via the version number is incredibly important; it gives consumers a signal that they need to carefully evaluate the change -- automated tests may miss breaking behavioral changes.
Furthermore, most language ecosystems encourage semantic versioning for their packages (or equivalent concept) including NPM, Maven (albeit for SemVer 1.0), Go, pip, and Composer. I think it makes sense for these packages to comply too.

/unresolve
I think it's clear from the discussion that the Azure .NET SDK client libraries do not follow SemVer - what's the process of updating the Azure SDK guidelines for .NET to reflect the approach outlined by @christothes?

/unresolve

@KrzysztofCwalina it seems clear from the discussion that the Azure .NET SDK client libraries are not following SemVer, and the .NET versioning section is at the least ambiguous - what's the process of updating the Azure SDK guidelines for .NET to clarify the approach outlined by @christothes?

Sure, as a consumer here's the changes I would propose:
Release Policies
Package Versioning
This section begins:

The team makes every effort to follow SemVer for versioning.

and concludes in a way that suggests .NET follows SemVer:

While all the languages follow the general versioning scheme, they each have slight differences based on their ecosystem, for those differences see the individual language sections below.

Suggested change:

While some of the languages follow this general versioning scheme, see the individual language sections below for specifics.

.NET
Suggested change: add a link to the .NET-specific versioning guidelines
.NET Guidelines
Versioning
Client Versions
This section says:

✅ DO introduce a new package (with new assembly names, new namespace names, and new type names) if you must do an API breaking change.
Breaking changes should happen rarely, if ever. Register your intent to do a breaking change with adparch. You’ll need to have a discussion with the language architect before approval.

Suggested change:

✅ DO add a note to the changelog if you must do an API breaking change. This should only happen after an approval from adparch.

Package Version Numbers
Suggested addition:

✅ DO increment the major or minor version when adding a breaking change to the public API.

DO add a note to the changelog if you must do an API breaking change. This should only happen after an approval from adparch.

It might be a terminology issue, but we have never done a binary API breaking change and we don't intend to do them. So, I don't think this is a guideline we want to have. Here is what I think would be a good clarification:
Breaking changes can be categorized roughly as: behavioral changes and API breaking changes. API breaking changes can be further grouped into source API breaking changes and binary API breaking changes. Another pivot in this taxonomy is backwards compatibility breaks (breaks when moving from older to newer package) and forward compatibility breaks (when moving from newer to older package), but this distinction is not super relevant to our discussion.
It's obvious what behavioral changes mean. As to binary and source API changes, it might be good to define them: a) source API breaking change is a change where source code compiled using one version of a package does not successfully compile when compiled using a different version of the same package. Binary API breaking change is when a binary calling one version of a package cannot call/bind an API in a different version of the same package.
.NET Azure SDK approach to each of the categories is as follows (and matches very closely what the .NET platform itself is doing):

We have not ever done, nor are planning to do binary API breaking changes. These are extremely disruptive to users of our APIs given how CLR loader and NuGet work, and are relatively easy to avoid. These change can affect programs without developer recompiling the program, and so giving the compiler a chance to alert the developer that there is an issue. Also, even if the developer is aware of the issue, they might not have a way to mitigate such breaks. We of course reserve the right to do such change at some point (e.g. if it's the only way to fix a severe security issue), but in reality we have never needed that.
Source API breaking changes. These are annoying, but are easily detected (in almost all but very corner cases) during component update. These are also unavoidable given the C# type system. For example, adding an overload can result in a source API breaking change. Also, there is a trafeoff here between the degree of the annoyance when moving to a new version of a package and the annoyance that outdated APIs (without proper overloads) can cause. And so here we try to minimize such changes to those that "pay for themselves", i.e. yield net benefit to our user bases. Such changes should be described in our release notes including code sample showing how to fix the calling code in the light of these changes. Keep in mind that these adjustments are always trivial for source breaking changes. If a change requires large source changes, it will always end up being a binary breaking change too, which we don't do.
Behavioral changes. These are super tricky. As you might have noticed, I used the word "breaking" when describing API changes, but not when describing behavioral changes. The reason is that all behavioral changes can break something. Of course, some behavioral changes are more likely to break apps than others, but it does not change the fact that there is a spectrum here. The way we approach these changes is that we assess the likelihood of such changes affecting real apps and if we think the likelihood is more than trivial, we consider these are "non trivial", in which case we often reject such changes. If we cannot reject them, we provide compat switches and document them diligently. For the most severe cases, we intend to increment the major version number (and yes, we have made some mistakes here in the past for which I apologize). But because the effect behavioral changes have on apps is so dependent on the callers code, it's very difficult to have an approach (e.g. to version numbers change) that fits all.

Thanks for talking through this - really appreciate the clarification. With that in mind I'd suggest:
Release Policies
Package Versioning
This section ends:

While all the languages follow the general versioning scheme, they each have slight differences based on their ecosystem, for those differences see the individual language sections below.

Suggested change:

Some languages interpret breaking changes more granularly than SemVer, see the individual language sections below for specifics.

.NET
Suggested change: add a link to the .NET-specific versioning guidelines
.NET Guidelines
Versioning
Suggested change: clarify behavioral, binary and source breaking changes, with links to relevant documentation (OSS guidance)
Client Versions
This section says:

✅ DO introduce a new package (with new assembly names, new namespace names, and new type names) if you must do an API breaking change.
Breaking changes should happen rarely, if ever. Register your intent to do a breaking change with adparch. You’ll need to have a discussion with the language architect before approval.

Suggested change:

✅ DO introduce a new package (with new assembly names, new namespace names, and new type names) if you must do a binary API breaking change.
✅ DO increment the minor version and add a note to the changelog if you must do a source API breaking change.
✅ DO engage adparch if you must do a behavioral breaking change. This may require a major version bump.
All breaking changes should happen only after an approval from adparch.


Activate Enzyme tests on 1.11

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 9.45%. Comparing base (7c60378) to head (ff87be2).

:exclamation:  There is a different number of reports uploaded between BASE (7c60378) and HEAD (ff87be2). Click for more details.
HEAD has 47 uploads less than BASE

Flag
BASE (7c60378)
HEAD (ff87be2)

DI
41
3

DIT
10
1

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #431       +/-   ##
==========================================
- Coverage   93.63%   9.45%   -84.18%
==========================================
  Files         102      88       -14
  Lines        4885    4696      -189
==========================================
- Hits         4574     444     -4130
- Misses        311    4252     +3941

Flag
Coverage Δ

DI
17.08% <ø> (-82.19%)
:arrow_down:

DIT
0.09% <ø> (-86.24%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


collect network metrics for containers

almost same with #764
This functionality requires job-exporter container to be privileged and has host pid namespace. Since this will have security issue, I enabled admission control in api server with recommended policy and DenyEscalatingExec. @ydye please verify this.
It also requires other service to have non-host pid namespace to be accurate.

fixed #721

Coverage increased (+3.06%) to 57.966% when pulling 155773696db57f6aa25281d96f8ee40df1798d26 on dixu/job-network into 2ccc86d08c7b66f3952170ce86d0d1e16be4b644 on master.


Phoenix industries unable to update

Thanks for wanting to bring an issue to our attention!
Before you open a ticket, please do a quick search of the existing issues to see if it's already been brought up.
Please note that this repository is strictly for metadata (issues relating to incorrect information about mods, missing versions, or incorrect installations). If you want to suggest something or report a bug relating to CKAN as a whole, open the issue in: https://github.com/KSP-CKAN/CKAN

Error Report
Downloading "https://spacedock.info/mod/245/Phoenix Industries - Cargo Resupply System/download/2.1"
Downloading "https://spacedock.info/mod/246/Phoenix Industries - Boosters/download/2.0"
Oh no! We tried to overwrite a file owned by another mod!
Please try a ckan update and try again.
If this problem re-occurs, then it maybe a packaging bug.
Please report it at:
https://github.com/KSP-CKAN/NetKAN/issues/new
Please including the following information in your report:
File           : GameData/CTN/Flags/Thumbs.db
Installing Mod : PhoenixIndustriesFlags 2.0
Owning Mod     : PhoenixIndustriesAres
CKAN Version   : v1.20.1-0-gd41fe54 (beta)
Your GameData has been returned to its original state.
Error!
I thought my version (CKAN) was the latest , Plus I have redownloaded the .exe (v1.20.1 / d41fe54) again from the site after the previous attempt.
Was try to update the following :

Phoenix Industries - Cargo Resupply System
Phoenix Industries - Boosters

Fixed with #4678


Add the Vert.x HTTP proxy and the Vert.x Web Session stores (cookie and redis) modules

Fix #662 and #661

Should we add smoke tests like for some other modules?

@jponge the modules are very simple, so didn't plan to add tests.

Would you be interested in a contribution for Vert.x Web session storage with Infinispan Client (i.e. without Vert.x clustering)

Ah yes!
I checked the vertx web project only.


Add additional kubelet metrics

Add additional kubelet metrics:

kubelet client request latency in seconds
network plugin operation latency in microseconds

What does this PR do?
A brief description of the change being made with this pull request.
Motivation
What inspired you to submit this pull request?
Review checklist

[x] PR has a meaningful title or PR has the no-changelog label attached
[x] Feature or bugfix has tests
[x] Git history is clean
[ ] If PR impacts documentation, docs team has been notified or an issue has been opened on the documentation repo

Additional Notes
Anything else we should know when reviewing?

Codecov Report

Merging #2245 into master will increase coverage by 0.29%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2245      +/-   ##
==========================================
+ Coverage   86.59%   86.88%   +0.29%
==========================================
  Files         191        8     -183
  Lines       13309      839   -12470
  Branches     1388      129    -1259
==========================================
- Hits        11525      729   -10796
+ Misses       1397       78    -1319
+ Partials      387       32     -355


Update cameraManager.ts

What's the point of this change?

Trying to strip the rotation on camera. (Sorry inglês)

True ... The camera is sideways which makes it lag more

I will try to make another and last change

No ... It's not last ... There are many things missing ... Like

Autofocus on touch
Screen cracks on start and then works

@starcorroder
The "crack" is just simulated noise meant to show that we're initializing the camera, we could just switch it to pure black but that's boring :P
I'll close this PR as @Ahuge is currently working on this and a bunch of other cameraManager related stuff :)

Ohkay ... So your not only making a windows app ... But also upgrading the actual Snapchat from boring to fun 😂


Success Criteria for Requests returning JSON

I have understood the the basic criteria, but if I have a JSON string returned with nested properties, then I can't find any information on how the success criteria expression must look like. The documentation on the field gives the following example:
for a repsonse like {"status" : "successful"}, the expression can be eq(root['status'], 'successful')
but how does it look like for a repsonse like
{"values" : [{"status":"successful"},{"status":"failed"}]}
or
{"values" : {"status":"successful"}}
A more detailed explanation in this document would improve that.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 89bc6da4-5a1e-5989-f4f0-27465953b5fd
Version Independent ID: fd12f976-5d3b-3b1b-3d0a-a0bf2a60c961
Content: Invoke HTTP REST API task for Microsoft VSTS and TFS
Content Source: docs/build-release/tasks/utility/http-rest-api.md
Service: unspecified
GitHub Login: @alexhomer1
Microsoft Alias: ahomer

Thank you for your feedback. I have passed this on to the product team and will update the topic based on their response.

Can you see if https://github.com/Microsoft/vsts-tasks/blob/master/docs/authoring/servertaskauthoring.md gives you the required information on how to parse jsons for success conditions?

Hi, thanks for the link. I found that one as well. But there are still some information missing, which I needed to find out myself.
For example: In a quality gate I have the following equation, which works:
eq(jsonpath('$.value[*].environments[*].status')[0],'succeeded')
I wanted to check if an environment has the status succeeded from the following VSTS api path
_apis/release/releases/?$top=1&$expand=environments
I needed to find out myself, that I need to specifically access the array, which is returned from json path even though there is just one item returned. Also an information of which version of jsonpath is used would be great.
But still, the link you provided helped me!
Btw. there is a link on that page pointing to GitHub, which does not exist anymore:
https://github.com/Microsoft/vsts-tasks/tree/master/Tasks/InvokeRestApi

is your equation still working?  We are using a similar method
eq(jsonpath('$.environments[?(@.name==''env'')].status')[0],'inProgress')

which has recently stopped working.  The rest returns 200 with valid JSON but the expression returns:
Evaluation of expression 'eq(jsonpath('$.environments[?(@.name==''env'')].status')[0],'inProgress')' failed.

Exception Message: Object reference not set to an instance of an object. (type NullReferenceException)

It would be really useful if this was documented better.

Thanks for reporting the issue. We found it as a code bug on our side and have started a hotfix release for the same. The expression handling should get working again soon (some time next week depending upon the ring you account belongs to).

My response returns a Json array. Could you provide an example on how to check if the length of the array is greater than 0? I've tried root.length() and len(root). Neither works.

Can you add more examples to json arrays? thank you!


post experiments from CIDR paper?

It'd be very helpful to get a sense of an application using ground. Maybe it'd be possible to post the code for the impact analysis experiment? That looks like it's not terribly complicated on external dependencies and should be easy to interpret.

Great idea!  I'll try to aggregate and make things presentable.

Sorry for not following up on this sooner. We're going to have some more interesting / better flushed out use cases in the next month or so; I'm going to close this because we'll just post those instead.
Thanks again for the idea!


Update organization details

Make a controller function to update the organization details

I want to work on this.


Unable to parse line xxx with regular expression kernel: [.] (.)

i have create node-problem-detector daemonset with this file: https://raw.githubusercontent.com/kubernetes/kubernetes/master/cluster/addons/node-problem-detector/npd.yaml
but the log in /var/log/node-problem-detector.log have this :
W0919 13:28:10.176557       1 log_watcher.go:127] Unable to parse line: "Sep 19 13:28:09 172 kernel: overlayfs: upper fs needs to support d_type.\n", no message found in line "Sep 19 13:28:09 172 kernel: overlayfs: upper fs needs to support d_type." with regular expression kernel: \[.*\] (.*)

my os is centos 7 ,i have config rsyslog with this :
kern.*                                                 /var/log/kern.log

the log in /var/log/kern.log like this:
Sep 19 10:29:11 172 kernel: overlayfs: upper fs needs to support d_type.
Sep 19 10:29:11 172 kernel: overlayfs: upper fs needs to support d_type.
Sep 19 11:40:24 172 kernel: overlayfs: upper fs needs to support d_type.
Sep 19 11:40:24 172 kernel: overlayfs: upper fs needs to support d_type.
Sep 19 11:40:24 172 kernel: overlayfs: upper fs needs to support d_type.
Sep 19 11:40:25 172 kernel: IPv6: ADDRCONF(NETDEV_UP): eth0: link is not ready
Sep 19 11:40:25 172 kernel: IPv6: ADDRCONF(NETDEV_CHANGE): eth0: link becomes ready
Sep 19 11:41:28 172 kernel: overlayfs: upper fs needs to support d_type.
Sep 19 11:41:28 172 kernel: overlayfs: upper fs needs to support d_type.
Sep 19 11:41:28 172 kernel: overlayfs: upper fs needs to support d_type.

is there something wrong

@du2016 Looks that the regexp \[.*\] (.*) does not match the kernel log line. You should adjust the regex expression to adjust the kernel log format.

@du2016 In Debian, the kernel log is like:
Nov 12 00:00:01 xn1 kernel: [29044080.001719] Process accounting resumed

@andyxning thanks


Increase .travis.yml consistency between repos

aspnet/Universe#349
minimize dotnet setup time; no need for caching
build with --quiet

820c58a


Improve error message in check_rs2_error for unknown exception type

I am trying to get realsense working on an M1 MacBook. I installed librealsense 2.54.1 with brew install librealsense. I then tried to run demo_435i and got this:
thread 'main' panicked at 'called `Option::unwrap()` on a `None` value', realsense-rust-1.1.0/src/device.rs:82:13
stack backtrace:
   0: rust_begin_unwind
             at std/src/panicking.rs:575:5
   1: core::panicking::panic_fmt
             at core/src/panicking.rs:64:14
   2: core::panicking::panic
             at core/src/panicking.rs:111:5
   3: core::option::Option<T>::unwrap
             at core/src/option.rs:778:21
   4: realsense_rust::device::Device::try_create
             at realsense-rust-1.1.0/src/device.rs:82:13
   5: realsense_rust::context::Context::query_devices
             at realsense-rust-1.1.0/src/context.rs:118:23

With this PR applied this is improved to:
thread 'main' panicked at 'Unknown Rs2Exception: 8', realsense-rust/src/device.rs:82:13
stack backtrace:
   0: rust_begin_unwind
             at std/src/panicking.rs:575:5
   1: core::panicking::panic_fmt
             at core/src/panicking.rs:64:14
   2: realsense_rust::device::Device::try_create::{{closure}}
             at realsense-rust/src/error.rs:150:25
   3: core::option::Option<T>::unwrap_or_else
             at core/src/option.rs:828:21
   4: realsense_rust::device::Device::try_create
             at realsense-rust/src/device.rs:82:13
   5: realsense_rust::context::Context::query_devices
             at realsense-rust/src/context.rs:118:23

I still don't know why we get an 8 here though, considering there are only eight errors, numbered 0-7: https://intelrealsense.github.io/librealsense/doxygen/rs__types_8h.html#ab73d6772c40d1a2fba645a1d0a7eed5e
Perhaps some version mismatch?

PS: in your README.md and on https://crates.io/crates/realsense-rust you say you are happy to receive PRs on GitHub (which is why  opened this PR), but now I see that CONTRIBUTING.md says you only accept them on GitLab 😬

Hey, thanks for the submission!
Apologies about the GitLab / GitHub confusion. We do take contributions on both sites, but we need to move the branch over to GitLab for the purpose of running CI (since we don't have any GitHub actions setup).
I don't have a ton of time to review this ASAP, but I'm more than happy to duplicate this over to GitLab at some point this week and review there proper. We'll leave this open until then.

No hurry on my end!

I've ported it over to GitLab: https://gitlab.com/tangram-vision/oss/realsense-rust/-/merge_requests/50
I will review this shortly -- I can put feedback here and then move work over as necessary.

Changes seem good, although there seems to be some new lint / test errors that have cropped up due to updates in librealsense.
I need to update the library to 2.54.0 or whatever the latest is, and then probably rebase this off of that work before we merge.

https://gitlab.com/tangram-vision/oss/realsense-rust/-/merge_requests/50
Alright, this was reviewed & merged. Apologies for the wait. I'm going to close this now if everything is fine here!


Need some guide for Nextjs/Reactjs webp intregration

Thanks for your awesome project. This is not a direct issue for this library. I am trying to use this library in my Next.js project. But webp image is not rendering in safari browser. Here is what I have tried ; I added this code block in every pages where webp image used.
import React, {useEffect} from "react";
import {WebpMachine} from "webp-hero"

const ExampleComponent = (props) => {
    useEffect(() => {
        const webpMachine = new WebpMachine();
        webpMachine.polyfillDocument();
    });
  return ( //something  )
}

It would be really helpful if anyone knows what I am missing .

hello @pyprism, sorry for my late reply!
you want to create only one instance of the new WebpMachine() for the entire page, then find a way to call polyfillDocument() again whenever you think new webp images might have appeared on the page

I'm giving this a try thusly…
// html.js
const html = () => (
  <html>
    <script type="module" dangerouslySetInnerHTML={{
        __html: `
          import {WebpMachine} from<EMAIL_ADDRESS>          window.webpMachine = new WebpMachine()
          window.webpMachine.polyfillDocument()
        `
      }} />
)

// component
const Image = (props) => {
  const [imageSource, setImageSource] = React.useState("")
  React.useEffect(() => {
    setImageSource(props.src + '?fm=webp') // CDN webp autogenerator
    window.webpMachine.polyfillDocument()
    console.log('ding')
  }, [])
  return (
      <img src={imageSource || ""}
        {...props}
      />
  )
}

Doesn't do anything. A quick console.log(window.webpMachine) shows some stuff but no polyfillDocument() method.
busy: false
cache: {}
webp: Webp {Module: Object, webpToSdl: function, setCanvas: function}
webpSupport: Promise {status: "resolved", result: false}

@EricWVGG — i think the issue you're experiencing may be related to #36

@EricWVGG — also you should upgrade to<EMAIL_ADDRESS>

closing this stale issue — also consider upgrading to the new version of webp-hero published today
please open another issue if you experience any more problems!


Let user add own elements

give option to add own lines to the config which are not in the base software

own lines should also be available in the change order which might be a problem with the current implementation

Requires #16 to be done first


fix: downkeys order error with multi listeners

Fix the order error with multi listeners. https://github.com/jaywcjlove/hotkeys-js/issues/432

@YuxuanWeng thx! Upgrade v3.10.3


x/mobile: attempting to build native package with gomobile build mobile example fails with exit status 2

After installing and configuring android studio per their setup instructions, adding the SDK environment variables, and installing the additional dependencies (CMAKE, NDK, LLDB, platforms for 7.0+), attempts to run through the native package build steps fail with deprecation warnings.
What version of Go are you using (go version)?
Attempted in 1.11.4 and latest 1.12 (As of 2/26/2019)

PS C:\Users\bubth\Development> go version
go version go1.11.4 windows/amd64

Does this issue reproduce with the latest release?
Yes
What operating system and processor architecture are you using (go env)?
go env Output
PS C:\Users\bubth\Development> go env
set GOARCH=amd64
set GOBIN=
set GOCACHE=C:\Users\bubth\AppData\Local\go-build
set GOEXE=.exe
set GOFLAGS=
set GOHOSTARCH=amd64
set GOHOSTOS=windows
set GOOS=windows
set GOPATH=C:\Users\bubth\go
set GOPROXY=
set GORACE=
set GOROOT=C:\Go
set GOTMPDIR=
set GOTOOLDIR=C:\Go\pkg\tool\windows_amd64
set GCCGO=gccgo
set CC=gcc
set CXX=g++
set CGO_ENABLED=1
set GOMOD=
set CGO_CFLAGS=-g -O2
set CGO_CPPFLAGS=
set CGO_CXXFLAGS=-g -O2
set CGO_FFLAGS=-g -O2
set CGO_LDFLAGS=-g -O2
set PKG_CONFIG=pkg-config
set GOGCCFLAGS=-m64 -mthreads -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=C:\Users\bubth\AppData\Local\Temp\go-build580209074=/tmp/go-build -gno-record-gcc-switches
PS C:\Users\bubth\Development>

Android SDK Info:

Android Studio 3.3.1
Build #AI-182.5<IP_ADDRESS>64788, built on January 28, 2019
JRE: 1.8.0_152-release-1248-b01 amd64
JVM: OpenJDK 64-Bit Server VM by JetBrains s.r.o
Windows 10 10.0

What did you do?

PS C:\Users\bubth\Development> gomobile init
PS C:\Users\bubth\Development> gomobile build -target=android golang.org/x/mobile/example/basic
C:\Users\bubth\go\bin\gomobile.exe: go build -buildmode=c-shared -o C:\Users\bubth\AppData\Local\Temp\gomobile-work-069435679\lib\armeabi-v7a\libbasic.so golang.org/x/mobile/example/basic failed: exit status 2
# runtime/cgo
clang++.exe: error: treating 'c' input as 'c++' when in C++ mode, this behavior is deprecated [-Werror,-Wdeprecated]
PS C:\Users\bubth\Development>

After updating to 1.12:

PS C:\Users\bubth\Development> go version
go version go1.12 windows/amd64
PS C:\Users\bubth\Development> go get golang.org/x/mobile/cmd/gomobile
PS C:\Users\bubth\Development> gomobile init
PS C:\Users\bubth\Development> go get -d golang.org/x/mobile/example/basic
PS C:\Users\bubth\Development> gomobile build -target=android golang.org/x/mobile/example/basic
C:\Users\bubth\go\bin\gomobile.exe: go build -buildmode=c-shared -o C:\Users\bubth\AppData\Local\Temp\gomobile-work-076420807\lib\armeabi-v7a\libbasic.so golang.org/x/mobile/example/basic failed: exit status 2
# runtime/cgo
clang++.exe: error: treating 'c' input as 'c++' when in C++ mode, this behavior is deprecated [-Werror,-Wdeprecated]

PS C:\Users\bubth\Development>

What did you expect to see?
Successful build of the example mobile application.
What did you see instead?
Errors when attempting to build.

C:\Users\bubth\AppData\Local\Temp\gomobile-work-076420807\lib\armeabi-v7a\libbasic.so golang.org/x/mobile/example/basic failed: exit status 2
# runtime/cgo
clang++.exe: error: treating 'c' input as 'c++' when in C++ mode, this behavior is deprecated [-Werror,-Wdeprecated]

CC @hyangah @eliasnaur

See https://github.com/android-ndk/ndk/issues/920. It seems the builtin compilers introduced in r19b are broken on Windows. One workaround is to use revision 8b05ea26b5669e5f52084ab001b8e49ec8877955 of gomobile which does not contain the change to use the new compilers.

For folks like me who are still learning golang and it's nuances, what's the simplest way to use that revision of gomobile?  Would I be cherry picking a specific revision from the repo and rebuilding, or is there a simpler way?

You can apply my fix posted above or simply wait; it will probably be reviewed and merged soon enough and then a simple "go get -u golang.org/x/mobile/cmd/..." will do.

@bubthegreat please try again with the newest gomobile. Use go get -u golang.org/x/mobile/cmd/...to upgrade.

@bubthegreat please try again with the newest gomobile. Use go get -u golang.org/x/mobile/cmd/...to upgrade.

It looks good now.

Verified working - thanks!


Renamed main module to be more compatible with name of the application

Description
It's a bit confusing to have the main module named server and then have another package named server as well.
Type of change

Refactor (refactoring code, removing useless files)

Codecov Report

Merging #40 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #40   +/-   ##
=======================================
  Coverage   70.85%   70.85%
=======================================
  Files           7        7
  Lines         175      175
=======================================
  Hits          124      124
  Misses         43       43
  Partials        8        8

Impacted Files
Coverage Δ

service.go
41.26% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 159b00e...5f3e562. Read the comment docs.


Refactor: migrate data tab to shiny modules

Issue
Closes #85
Description

Migrated all code located in tabs/data.R file to shiny module
Migrated related UI code to shiny module
Migrated filter input to module that handles server-related stuff, instead of just a function for generating UI elements
Changed submit button to be global instead of per-filter
TODO: make the filter UI prettier

Definition of Done

[x] Parts of the application related to data tab are migrated to shiny modules.

How to test
Go through the app workflow, check if data is loaded and filtered correctly
Contributor checklist

[x] Code passes lintr checks
[x] Code passes all unit tests
[x] New logic is documented

Notes to reviewer
Please do check whether all functionalities are intact, I have checked to the best of my ability but my understanding about the exact workings of the app is still limited. Data is filtered, all plots are generated.

@Gero1999 I have pushed a commit with some improvements to the filter widget visuals, could you take another look and see if that is alright?


Android implementation is missing regular immersive mode

By using AndroidApplicationConfiguration.useImmersiveMode, one can achieve the sticky immersive mode as described here:
https://developer.android.com/training/system-ui/immersive.html
However, the type of immersive mode used here is "sticky", not "regular". There is no way to achieve "regular immersive" mode. This should be a trivial modification to the code, and I believe a necessary one. Note that the difference between the two is that app does not register a swipe when in regular immersive mode, in sticky immersive mode instead it registers it (which can be very annoying in some cases).

I also found a stackoverflow post about it, posted ~5 years ago:
https://stackoverflow.com/questions/32154485/using-immersive-mode-on-libgdx

Being a games framework it makes sense that default immersive mode is sticky due to games having a lot of interaction with the screen and gestures that could trigger the display of the status bar. It would be possible to add the option to set it to "regular" but I can't think of use cases in which that would be preferrable. Do you have a specific use case for this feature?

Well, the docs say this:

While in sticky immersive mode, if the user swipes from an edge with a system bar, system bars appear but they're semi-transparent, and the touch gesture is passed to your app so it app can also respond to the gesture.

So, I assumed that in normal mode the touch gesture is not passed to the game, which is exactly what I desire. The thing is, on my game, in order to exit from current screen you need to press BACK button, which only appears when you do the swipe from an edge gesture. However, currently, when user does that, it also moves the in-game map (panning is done by touching and moving your finger), which moves the entire map every time you want for the system bar to appear, which is annoying. I was hoping that with regular immersive mode this would be gone, as explained in the quotation from the docs, however I've overridden libgdx's sticky immersive mode with regular one and the panning still persists, so there's not much difference. I guess I misunderstood the concept. That, or the docs are not clear, or my phone is treating this gesture differently.
Still, I think adding a flag to use regular immersive mode makes sense, if someone wants to use it.

Yes, actually for your use case you Must use sticky mode because your game uses swipe gestures anywhere on the screen (have a look at this guide https://medium.com/androiddevelopers/gesture-navigation-handling-gesture-conflicts-8ee9c2665c69 including the section on Immersive mode).
Unless a use case is provided I don't see the need to add non-sticky/regular immersive mode as an option.

@Betalord
I tried using this, and it works for me.  I'm not sure if it will work for what you want.
`public class AndroidLauncher extends AndroidApplication {
//data ... and main method

//todo  Test code for immersive mode.
@Override
public void onWindowFocusChanged( boolean hasFocus ) {
    super.onWindowFocusChanged( hasFocus );
    if ( hasFocus && Build.VERSION.SDK_INT >= 19 ) {
        getWindow().getDecorView().setSystemUiVisibility(
                View.SYSTEM_UI_FLAG_LAYOUT_STABLE
                | View.SYSTEM_UI_FLAG_LAYOUT_HIDE_NAVIGATION
                | View.SYSTEM_UI_FLAG_LAYOUT_FULLSCREEN
                | View.SYSTEM_UI_FLAG_HIDE_NAVIGATION
                | View.SYSTEM_UI_FLAG_FULLSCREEN
                | View.SYSTEM_UI_FLAG_IMMERSIVE);
    }
}

}`

Closing as there seems to be a workaround above.


Update golang links to use https

Many of the golang links point to the old site and don't use https. This pull request updates these outdated links to https://go.dev .
https://github.com/go-gitea/gitea/issues/28979

@macifell I noticed you've updated the locales for non-English languages. These will be overwritten during the sync from our translation tool Crowdin. If you'd like to contribute your translations, please visit https://crowdin.com/project/gitea. Please revert the changes done on these files. :tea:


Status reporting randomly stops

Status reporting randomly stops at 75% or 82% even though the download itself is happening.

Looks it's not downloading that chunk. This creates corrupt files.
Please look into it as soon as possible, because of this the package is unusable.


Adding a Camel CDI example service described by Swagger 2.0

Can one of the admins verify this patch?

add to whitelist


Embedded Content Consumer doc does not render

Issue Description
The Embedded Content consumer doc at this link does not render. It also messes up navigation, so the user can't navigate back to their last page. They have to refresh the previous page to see any content.
Log
terra-dev-site-cc70ac2eceb28ef7393b.js:195 TypeError: Cannot convert undefined or null to object
    at keys (<anonymous>)
    at Object.mount (terra-dev-site-cc70ac2eceb28ef7393b.js:353)
    at t.value (terra-dev-site-cc70ac2eceb28ef7393b.js:62)
    at commitLifeCycles (terra-dev-site-cc70ac2eceb28ef7393b.js:195)
    at t (terra-dev-site-cc70ac2eceb28ef7393b.js:195)
    at D (terra-dev-site-cc70ac2eceb28ef7393b.js:195)
    at _ (terra-dev-site-cc70ac2eceb28ef7393b.js:195)
    at batchedUpdates (terra-dev-site-cc70ac2eceb28ef7393b.js:195)
    at Z (terra-dev-site-cc70ac2eceb28ef7393b.js:195)
    at Pe (terra-dev-site-cc70ac2eceb28ef7393b.js:195)
u @ terra-dev-site-cc70ac2eceb28ef7393b.js:195
terra-dev-site-cc70ac2eceb28ef7393b.js:195 Uncaught TypeError: Cannot convert undefined or null to object
    at keys (<anonymous>)
    at Object.mount (terra-dev-site-cc70ac2eceb28ef7393b.js:353)
    at t.value (terra-dev-site-cc70ac2eceb28ef7393b.js:62)
    at commitLifeCycles (terra-dev-site-cc70ac2eceb28ef7393b.js:195)
    at t (terra-dev-site-cc70ac2eceb28ef7393b.js:195)
    at D (terra-dev-site-cc70ac2eceb28ef7393b.js:195)
    at _ (terra-dev-site-cc70ac2eceb28ef7393b.js:195)
    at batchedUpdates (terra-dev-site-cc70ac2eceb28ef7393b.js:195)
    at Z (terra-dev-site-cc70ac2eceb28ef7393b.js:195)
    at Pe (terra-dev-site-cc70ac2eceb28ef7393b.js:195)

Issue Type

[ ] New Feature
[ ] Enhancement
[X] Bug
[ ] Other

Expected Behavior
Doc should render
Current Behavior
Doc doesn't render.

Steps to Reproduce

Navigate to link

Environment

Component Version:
Browser Name and Version: Chrome Version 64.0.3282.186 (Official Build) (32-bit)
Operating System and version (desktop or mobile): Windows 10 Desktop

You can view the embedded content container documentation at http://engineering.cerner.com/terra-core/#/site/embedded-content-consumer until we get this issue resolved.

This will be resolved in #1254. What is happening is the embedded component examples use the test urls as the examples, but in the terra-ui site, we do not create test routes.

It looks like there are still issues with this page on there terra-ui site
The iFrames seem to be shrinking when navigating to the page. The URLs used with the iFrames will need updating.


ATF-1191 Include terms in classification report

This pull request enables including terms in the GET relationship changes REST API endpoint csv/txt response content.

Thank you @zoliMolnar


SPIKE[4]:Add TQ to the choice of resource

Determine what's needed to add TranslationQuestions as a source text for translation in tC Create.   Does it make sense to add it as is?

@RoyalSix Shouldn't this be blocked by the effort to convert to TSV?
Here is an example of what it will be like then:
https://git.door43.org/unfoldingWord/en_translation-annotations/src/branch/master/tit/tit_tq.tsv

@mandolyte Thanks for dropping this link for me.

It looks like it works in datatable translatable we will just need to provide the chapter/verse columns instead of combining them.
i.e.
Reference	ID	Tags	SupportReference	Quote	Occurrence	Annotation 1:1	dbtj					What was Paul's purpose in his service to God?
His purpose was to establish the faith of God's chosen people and to establish the knowledge of the truth.
Should be
Book	Chapter	Verse	ID	Tags	SupportReference	Quote	Occurrence	Annotation TIT	1	1	dbtj					What was Paul's purpose in his service to God?
His purpose was to establish the faith of God's chosen people and to establish the knowledge of the truth.
https://5f6cd67631b9c90e5fd50367--datatable-translatable.netlify.app/

@RoyalSix can you do a test of the current markdown TQs? https://git.door43.org/unfoldingWord/en_tq

@birchamp https://5f6e328e9fcc720ffb733dd4--tc-create-app.netlify.app


[ADD] Refresh on send view

Please add the possibility to be able to refresh on send view.
This is needed to sometimes fetching empty gas and therefore the user is unable to send a tx
on iOS: on pull down movement, on mac: add refresh button

Fixed in #1586

QA done.


Fix ThermalExpansion being loaded before init

IntegrationThermalExpansion#L25 was sometimes being called before ItemRegistry was initialized, which resulted drops in
ItemEnumBased<EnumDropType> drops = ItemRegister.dropItem;

being null.
Adding a soft after-dependency for thermalexpansion seems to have fixed this.
This should fix issue #6

This is not a way to fix this, the problem was that the FMLInitEvt was called on some modules before  it was called on the main mod, this is because the Guava EventBus does not respect the register order. This will be fixed in an upcoming ElecCore release.

It seems like I just got lucky anyway. I could start the game 10 times without crashes, but now I'm getting them again. So yeah, not a fix.


Unable to read DebuggerConsoleSyntax

After setting up Sublime Debugger, I get the error message ¨Error loading syntax file. Unable to read ../DebuggerConsole.sublime-syntax¨ Am I missing something?

Did you find any solution?

Please provide your Debugger and Sublime Text version, as well as the console log.

I believe this is fixed in the latest release with this https://github.com/daveleroy/sublime_debugger/commit/3bda3b61843901b3d2ed3c4308f5e8bbc7a4b2c8
I think os.path.join creates paths that sublime doesn't like in some places and not others (only on Windows?)


Remove the discussion issue template

Problem

We use GitHub discussions for discussions, not issues (is my understanding), yet we have a "discussions" issue template, adding yet another template to our vast list of issue templates.
Description

Remove the discussion issue template.
Additional context
I think we should remove Infrastructure Improvement Suggestion as well. If this template is meant to encourge requests to improve developer experience, we should have an explicit issue template for documentation improvements, though that could be easily tied in with "code quality improvements" by changing the name of the code quality template to "Documentation and code quality improvements".
I think we should also remove the "project thread" template as (a) it is not that often used, (b) it is used only internally (community contributors are never using it), and therefore (c) we could keep the template in the documentation site, to be copied from there whenever a new one needs to be made. We could probably do the same for the Airflow and Sentry issues as well. They are also only used by maintainers.
Reducing the number of templates is imperative to me. If a new contributor tries to open an issue, rather than the templates helping guide them to give the best issue possible, the list of issue templates is overwhelming and practically baffling. At the very least we could do to sort them better, perhaps by adding some kind of prefix to the internal-only templates that forces them to be sorted to the bottom of the list.

Linking to a post on GitHub's blog about discussion having their own templates, called "category forms".

Thanks, @metabiswadeep! Do comment here if you have any questions or run into issues.

Do I remove the project_thread, airflow and sentry templates as well?

We haven't discussed what to do with those templates yet. I favor removing the Infrastructure Improvement Suggestion and Sentry Bug templates (just adding a label doesn't provide much value over the existing Bug issue type), and moving the Project Thread template to the documentation site, as Sara suggests, it could go under a page like the Implementation Plan Template.
I think we could also merge the Component spec and Design Changes and move the Airflow Alert template to the docs site, but these need inputs from peers.
@metabiswadeep So to sum up, you can delete the Infrastructure Improvement Suggestion and Sentry Bug templates. We'll create another issue to move the others.


Call to undefined method loginUsingId()

Larastan Version: 0.5.5
--level used: 5

Description
 ------ ----------------------------------------------
  Line   LoginController.php
 ------ ----------------------------------------------
  62     Call to an undefined method
         Illuminate\Auth\AuthManager::loginUsingId().
 ------ ----------------------------------------------

Laravel code where the issue was found
auth()->loginUsingId($user->id);

Could you try auth()->login($user); ?

@szepeviktor Ah nice solution. But how about that?

May not be related, but make sure you update for the latest version.

@nunomaduro Yeah, updated to the latest version. Still the same.

For anyone who faced this issue, maybe we can just ignore those error for now:
phpstan.neon
parameters:
    ignoreErrors:
        - '#Call to an undefined method Illuminate\Auth\AuthManager::login()#'

Yep, this looks like a bug. Thanks for reporting @nmfzone
AuthManager has the magic __call method which forwards method calls to guards. We might need a new extension for this behavior.

@canvural Sure, thanks. Keep a good work guys ⚡

Fixed: https://github.com/nunomaduro/larastan/commit/6a7009b23eefd33031b5e0845e1f20a02da968ec
Thank you!

I am not sure if it is related to the fix:
I am on v0.5.8
It is not working properly when auth() helper is called for a custom guard.
For example, I have a custom guard 'employee' and the model is Employee which has the function latest_pending_leave_request.
when I call auth('employee')->user()->latest_pending_leave_request(), larastan says Call to an undefined method Illuminate\Contracts\Auth\Authenticatable::latest_pending_leave_request()

@devfaysal Although custom guards are not supported in Larastan, I believe your issue will be fixed in the next release. You can try to pull the master branch and check now if you want.


Catch SocketError

https://trello.com/c/D9f0qyLL/554-catch-socketerror-in-gds-api-adapters

The code looks good, It'd be good to update the commit message to explain why we're catching SocketError.
We should also update the changelog

I've updated the changelog and commit message @kevindew


[language] remove string from libra_types

Summary
This removes string from libra_types::transaction::TransactionArgument. It's a breaking change as it changes the serialization of TransactionArgument.
Test Plan
cargo test

LD2M!

:umbrella: The latest upstream changes (presumably 51576b3f6e39f9af5da52308e095bca6e82352de) made this pull request unmergeable. Please resolve the merge conflicts.


Appstudio update test-component-pac-ihrz

Pipelines as Code configuration proposal
To start the PipelineRun, add a new comment with content /ok-to-test
For more detailed information about running a PipelineRun, please refer to Pipelines as Code documentation Running the PipelineRun
To customize the proposed PipelineRuns after merge, please refer to Build Pipeline customization

Pipelines as Code CI/test-component-pac-ihrz-on-pull-request has successfully validated your commit.

StatusDurationName

✅ Succeeded
7 seconds
init

✅ Succeeded
20 seconds
clone-repository

✅ Succeeded
24 seconds
build-container

✅ Succeeded
9 seconds
inspect-image

✅ Succeeded
14 seconds
deprecated-base-image-check

✅ Succeeded
10 seconds
clair-scan

✅ Succeeded
36 seconds
clamav-scan

✅ Succeeded
9 seconds
sbom-json-check

✅ Succeeded
7 seconds
label-check

✅ Succeeded
6 seconds
show-summary

✅ Succeeded
4 seconds
show-sbom

Pipelines as Code CI/test-component-pac-ihrz-on-pull-request has successfully validated your commit.


Sticky not working! (F5)

How can we reproduce this bug?

Step one
View my website: https://goo.gl/usRvGL
Step two
Inspect the navigation
Step three
See why the sticky is not working!

What did you expect to happen?
I expected when the user scroll down the page, the main navigation sticks to the top of the browser.
What happened instead?
It doesn't!
--
Hey all,
So I've applied a sticky to the navigation bar on my site here: https://goo.gl/usRvGL
I wrapped my main navigation (logo / menu items) in a div class labelled, "sticky" - just as the F5 docs say! However, the nav certainly doesn't stick as I scroll down.
Just an FYI - when I apply the "fixed" class, that function does work! So the JS is loading. Although fixing the bar immediately is not what I want for that main navigation, as it blocks out the top bar information.
Anyone have any ideas as to why it's not working? It's probably something small!
Cheers,
JD

Anyone?

The Foundation forum would be a great place to seek some help with troubleshooting what might be going on here. If it turns out to be a defect, you'll have some more info to provide here which will help prioritize and get it fixed.
We're trying to keep the issue list focused on confirmed defects in Foundation, so any help everyone can provide to differentiate between usage / troubleshooting and actual defects is appreciated!

I've posted there on this exact issue - http://foundation.zurb.com/forum/posts/48038-sticky-not-working-f5 - and the help has been lacklustre at best. That's why I came here.
@rafibomb - I've seen you give help to people numerous times. Valuable help, in-fact. Unfortunately, instead of a solution, you closed my issue when I actually needed help.
Back to Bootstrap, I guess.


feat: change baseUrl option to baseURL

Switch to baseURL config property name to align with Kitsu and Axios naming.
closes #14

Codecov Report

Merging #15 (a8dd505) into main (db14590) will increase coverage by 2.72%.
The diff coverage is 71.42%.

@@            Coverage Diff             @@
##             main      #15      +/-   ##
==========================================
+ Coverage   77.27%   80.00%   +2.72%
==========================================
  Files           1        1
  Lines          22       25       +3
  Branches       10       11       +1
==========================================
+ Hits           17       20       +3
  Misses          5        5

Impacted Files
Coverage Δ

lib/module.js
80.00% <71.42%> (+2.72%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update db14590...a8dd505. Read the comment docs.


Search filter and mouse click selection does not work together with tag-on-blur directive

Bug description:
I am using code using @mattmcardle along with custom implementation made for single tagging. After spending hours unable to find a way to detect Mouse click event after the user has started typing an initial letter for filtering drop-down options. However, For option selection, KeyUp/KeyDown along with ENTER works fine.
Link to minimally-working plunker that reproduces the issue:
https://plnkr.co/edit/C7Ohsd5IGqfSfLcnBaWD?p=preview
Version of Angular, UI-Select, and Bootstrap/Select2/Selectize CSS
Angular: 1.5.8
UI-Select:0.19.8
Bootstrap/Select2/Selectize CSS (if applicable): 3.1.1

After my look around on this realized that custom directive with blur event gets fired before ui-select click causing which results in creating a new Tag with the entered search term. I wonder if anyone else encountered this problem as I could not find any hook with the library where we can solve it easily.

After my look around on this realized that custom directive with blur event gets fired before ui-select click causing which results in creating a new Tag with the entered search term. I wonder if anyone else encountered this problem as I could not find any hook with the library where we can solve it easily.

I strongly feel that this should be solved within library rather using such custom tag as it is quite common scenarios for a select box.


What code was used to visualize the structures?

It looks a lot like pymatviz (see struct_vis), but I didn't think that pymatviz dealt with transparency, so I'm assuming it's something else.
https://github.com/txie-93/cdvae/tree/main/data/perov_5#visualization-of-structures

We used this: https://wiki.fysik.dtu.dk/ase/ase/visualize/visualize.html

Ah, great! Thank you. I've used the interactive functions before but not the static ones, so didn't recognize them at first. Thanks!


v10 Roadmap

Currently planned for v10

[ ] #91
[ ] Provide all services in root and remove TourModule.forRoot()
[ ] New tour UI: ion-popover
[ ] All directives and components provided as standalone
[ ] Drop support for RxJS v6
[ ] #85
[ ] #86

Hopefully it will be released sometime in January 2023.

Maybe one more thing that would be good to have is some configurable space between the anchor element and backdrop(between border and backdrop in this case):

@mivanyna please create a separate issue for your feature request.

v10 has now been released. Check out the release announcement for more info.


[Enhancement] show workerInfo when show compute node

Fixes #issue
What type of PR is this:

[ ] BugFix
[ ] Feature
[x] Enhancement
[ ] Refactor
[ ] UT
[ ] Doc
[ ] Tool

Checklist:

[x] I have added test cases for my bug fix or my new feature
[ ] This pr will affect users' behaviors
[ ] This pr needs user documentation (for new or modified features or behaviors)

[ ] I have added documentation for my new feature or new function

Bugfix cherry-pick branch check:

[x] I have checked the version labels which the pr will be auto-backported to the target branch

[ ] 3.0
[ ] 2.5
[ ] 2.4
[ ] 2.3

[FE PR Coverage Check]
:heart_eyes: pass : 14 / 14 (100.00%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
com/starrocks/common/proc/ComputeNodeProcDir.java
14
14
100.00%
[]


feat(NumberField/CanonicalEmbedding): define the negAt map

Let s be a set of real places of the number field K. This PR defines the map negAt s on mixedSpace K that swaps the sign at all real places in s and proves some of its properties.
It will be used later in #18231.
This PR is part of the proof of the Analytic Class Number Formula.

There is a merge conflict but otherwise I think it is ready to go.

Thanks!
bors merge


Include line total to webhook payload

add total_price_net_amount and total_price_gross_amount to order's lines payload.
add test to check the line payload

Task linked: SALEOR-1493 Order events do not include line totals, only the unit price and quantity


this.onSignedUrl is not a function

I don't have much time to look into this but I have been getting a this.onSignedUrl is not a function error in v4.7.0, looks likely related to #170, though, I think I see there's a default prop(?). Stepping down to previous version fixes.
Here is the stack (not very useful but here it is anyway):
TypeError: this.onSignedUrl is not a function
    at S3Upload.<anonymous> (http://localhost:1350/app.js:37535:22)

Here is our use of the component:
<ReactS3Uploader
  accept="image/*"
  onError={this.onUploadError}
  onFinish={this.onUploadFinish}
  onProgress={this.onUploadProgress}
  signingUrl="/s3/dash/media/sign"
  ref={input => (this.s3Uploader = input)}
  style={{ display: 'none' }}
/>

To help make up for the lacking stack trace… this happens in S3Upload.prototype.executeOnSignedUrl, looks like L107, in xhr.onreadystatechange().

Hmmm, I can't see any reason why this.onSignedUrl would not be a function, but clearly if you are getting this error, something is wrong.
Looks like that last PR didn't add to the prototype of s3upload, so i'll add a base implementation there, like some of the other handlers.

Pushed v4.7.1 with this change.  Re-open if you still see the issue.


Need the feature to copy dataDir content from hdfs to local container automatically

Currently(version 0.9.1), only codeDir will be copied automatically.

Also, what is the most efficient way to copy dataDir for current version (0.9.1, wrt to the largest dataset size)?  currently I use following command, is this reasonable?
hdfs dfs -get $PAI_DATA_DIR ./data

Thanks.

@gemfield , OpenPAI will not support this feature. for smaller dataset, your approach makes sense. For larger dataset, this approach will lead to out of disk exception.
If you decide to store large data in hdfs, the recommended way is to use the native hdfs reader to read the data in-the-fly. TensorFlow supports hdfs natively. As for PyTorch, we suggest to leverage Python hdfs library to do so (e.g., https://hdfscli.readthedocs.io/en/latest/).


Track title with slash "/"

I have all lyrics saved in "foobar2000\lyrics" folder.
When track title comes with a slash "/" such as "Just Like Fire / Heartbreaker (Live)", it will save the downloaded lyric as "foobar2000\lyrics\P!nk - Just Like Fire\ Heartbreaker (Live).lrc.
i.e. it will create a sub-folder named "P!nk - Just Like Fire"
Steps to reproduce

Expected behavior
lrc file should be saved as "P!nk - Just Like Fire _ Heartbreaker (Live).lrc" within the folder "foobar2000\lyrics".
Versions

foobar2000 version: 2.0
OpenLyrics version: 1.8

Debug logs

Additional information

Working as intended, I should expand the default replacement filter to catch backslashes as well.
See #244 for the previous discussion. I suggest you wrap the configured "File name format" for the local files source in an appropriate "$replace()" call.


Harmonize the dependencies to use a single TLS stack

Summary
Both native-tls/openssl and rustls are present in the dependency tree.
Problem Definition
As of 2e8d8390f731866d30d37627fc66925f4b381fda, there are the following dependency chains:
ibc ⭢ ibc-proto ⭢ tonic ⭢ tokio-rustls ⭢ rustls
ibc ⭢ tendermint-light-client ⭢ tendermint-rpc ⭢ hyper-proxy ⭢ hyper-tls ⭢ native-tls ⭢ openssl
Use of two TLS stacks bloats up the binary size and increases build time.
The need to link the foreign OpenSSL library complicates the build (see #1569).
Proposal
Choose one of the stacks and make sure all crates in the dependency tree use it.
Looking at the state of the dependency tree, tendermint-rpc is an outlier, pulling in OpenSSL perhaps by oversight: hyper-proxy can be switched to rustls, furthermore, tendermint-rpc itself also depends on hyper-rustls.
Acceptance Criteria
native-tls, opentls are not present in the dependency tree.

For Admin Use

[x] Not duplicate issue
[x] Appropriate labels applied
[ ] Appropriate milestone (priority) applied
[ ] Appropriate contributors tagged
[ ] Contributor assigned/self-assigned

Waiting for the next release of tendermint-rs to solve this issue.


Option to daemonize youtube-dl

[x] I'm reporting a feature request
[x] I've verified that I'm running youtube-dl version 2019.10.29
[x] I've searched the bugtracker for similar feature requests including closed ones

Description
There has been one mention of adding an option to daemonize youtube-dl in the past - however I am interested in this option because:

I use newsbeuter as a text-based RSS aggregator and start watching a desired YT video by pressing "O" (capital o - not zero) as a keyboard hot-key to create the new tab in Chrome - as long as I have an existing Chrome window open, the playing of the video starts almost immediately . .
However, I nearly always get advertisments to click through before the desired video starts playing.

BUT when I config mpv to be the newsbeuter "browser":

There are a number of seconds delay before mpv starts playing the video

When I raised the issue on the mpv IRC (thinking it was an mpv problem), a helpful person pointed out that the delay is the time it takes to load youtube-dl and that daemonizing that program might solve my problem.
So, is adding code to youtube-dl to allow it to daemonize a possibility?
Thanks,
Phil.

An ad blocker like uBlock Origin can block YouTube advertisements, and I think the most time-consuming part is downloading webpage from YouTube.


Spelling out numbers less than 10 upgrade folder

Summary
Spelling out numbers less than 10: the update folder. I didn't change "it took 3 minutes and 30 seconds" to "it took three minutes and 30 seconds" because that feels weird for me.
Ticket Link
https://github.com/mattermost/docs/issues/3269

Hello @ctlaltdieliet,
Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.


improve state and method chaining

closes #241

Coverage increased (+0.004%) to 96.567% when pulling 206f4293a0b6672029c7cc19845ace65af992dba on improve-chaining into 06247d0b682a58dc3d51cdf74de1a6930f4b9c4f on master.


Allow spaces as normal path characters

Per https://github.com/kthompson/glob/commit/a4b0562424a259ec0076de97b88b4c915cac0d73#r33027788

Build is available on nuget


Certification tests for Azure Blob Storage Binding

Description
Adds certification tests for the Azure Blob Storage Binding and adds minor fixes to the binding itself
Issue reference
closes #956
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list:

[x] Code compiles correctly
[x] Created/updated tests
[x] Extended the documentation / Created issue in the https://github.com/dapr/docs/ repo: dapr/docs#[issue number]

It is pretty close to be merged. Made some small comments.

It is pretty close to be merged. Made some small comments.

Done @artursouza


Test new migrations against "old" data

This should catch errors like #900

This is fixed with https://github.com/fractal-analytics-platform/fractal-server/commit/6a43082a27a82d39497e8e3a664fc4a0300b0f28.
The only aspect that we can check automatically is that migrations go through, meaning that we would have not caught #900. We also added the logic to catch #900, but that is very specific and won't protect us from similar errors.
For "complex" migration, we can always go back to this test and extend it to check that the expected behavior is obtained.
High-level: with this test we are covering (at least a part of) the errors that could come up during/after a migration applied to an existing database.


when we pass interger array data to drop it give error java.lang  java.double cant convert into java.string

hi @Nasaruddin12 ,
What is your input data?

If there are no more problems. I will close this issue.


Dockerfile for ALP-dense with KunpengBLAS and LAPACK

To ease reproducing the benchmarks, I wrote a Dockerfile. Tested successfully on Kunpeng920 on the public Huawei cloud (the kc1.2xlarge.4 instance, the Ubuntu 18.04 server 64bit with ARM OS).
Build docker image
First install the Docker engine following the official guide. Steps are exactly the same as on x86. When pulling images, will get base images for arm64v8 instead of the usual x86 ones.
Then run docker build -t alp-dense . with the Dockerfile and install_lapack.sh below in the same directory:
FROM ubuntu:20.04

RUN apt-get update \
    && DEBIAN_FRONTEND=noninteractive apt-get install -y \
    git wget zip vim \
    gcc g++ gfortran \
    libnuma-dev \
    libomp-dev \
    make cmake \
    && rm -rf /var/lib/apt/lists/*

WORKDIR /opt

# Install KunpengBLAS
# https://www.hikunpeng.com/zh/developer/boostkit/library/math
# https://www.hikunpeng.com/document/detail/zh/kunpengaccel/math-lib/devg-kml/kunpengaccel_kml_16_0011.html
RUN wget https://kunpeng-repo.obs.cn-north-4.myhuaweicloud.com/Kunpeng%20BoostKit/Kunpeng%20BoostKit%2022.0.RC3/BoostKit-kml_1.6.0.zip \
    && unzip BoostKit-kml_1.6.0.zip \
    && dpkg -i boostkit-kml-1.6.0.aarch64.deb

# Install netlib LAPACK and link to KunpengBLAS
# https://www.hikunpeng.com/document/detail/zh/kunpengaccel/math-lib/devg-kml/kunpengaccel_kml_16_0218.html
RUN wget https://github.com/Reference-LAPACK/lapack/archive/v3.9.1.tar.gz -O lapack-3.9.1.tar.gz
COPY ./install_lapack.sh /opt/
RUN bash ./install_lapack.sh

# Build and test ALP-dense
# https://github.com/Algebraic-Programming/ALP/blob/603-dense-mxm-performance-tests/alpdense.md
ENV BLAS_ROOT="/usr/local/kml"
ENV LAPACK_LIB="/opt/lapack_adapt/netlib/build/lib"
ENV LAPACK_INCLUDE="/opt/lapack_adapt/netlib/lapack-3.9.1/LAPACKE/include/"

# on commit 86e5b43 at the time of my test
RUN git clone -b 603-dense-mxm-performance-tests https://github.com/Algebraic-Programming/ALP.git
RUN cd ALP \
    && mkdir build \
    && cd build \
    && bash ../alpdense.sh | tee run_alpdense.log

where the install_lapack.sh used above is:

# Adapted from https://www.hikunpeng.com/document/detail/zh/kunpengaccel/math-lib/devg-kml/kunpengaccel_kml_16_0218.html

netlib=/opt/lapack-3.9.1.tar.gz
klapack=/usr/local/kml/lib/libklapack.a

mkdir lapack_adapt
cd lapack_adapt

# build netlib lapack
mkdir netlib
cd netlib
tar zxvf $netlib
mkdir build
cd build
cmake -DCMAKE_BUILD_TYPE=Release -DCMAKE_POSITION_INDEPENDENT_CODE=ON ../lapack-3.9.1
make -j
cd ../..

cp netlib/build/lib/liblapack.a liblapack_adapt.a

# get symbols defined both in klapack and netlib lapack
nm -g liblapack_adapt.a | grep 'T ' | grep -oP '\K\w+(?=_$)' | sort | uniq > netlib.sym
nm -g $klapack | grep 'T ' | grep -oP '\K\w+(?=_$)' | sort | uniq > klapack.sym
comm -12 klapack.sym netlib.sym > comm.sym

# update symbols name of liblapack_adapt.a
while read sym; do \
    if ! nm liblapack_adapt.a | grep -qe " T ${sym}_\$"; then \
        continue; \
    fi; \
    ar x liblapack_adapt.a $sym.f.o; \
    mv $sym.f.o ${sym}_netlib.f.o; \
    objcopy --redefine-sym ${sym}_=${sym}_netlib_ ${sym}_netlib.f.o; \
    ar d liblapack_adapt.a ${sym}.f.o; \
    ar ru liblapack_adapt.a ${sym}_netlib.f.o; \
    rm ${sym}_netlib.f.o; \
done < comm.sym

If built successfully, run docker run --rm -it alp-dense and check the out log file at /opt/ALP/build/run_alpdense.log
Reference log file
The printed log should look like this run_alpdense.log, with some caveats:

Ignore the performance numbers here since it was running on a tiny VM.
The last benchmark failed because there are only 8 vCPUs on the VM, while the benchmark explicitly asked for 64 OpenMP threads. Running on a full server should not have this problem.

Should this go into something like dockerhub or should the file go into a separate repository? We used to have <root>/site in this repository where we had site-specific files, and <root>/site/docker (or just directly <root>/docker may be natural also)-- I'm unfamiliar with common practices. @zouzias , might you have suggestions also?


cccccbhcgljugbrcublethcgbgkekhnrengfbvjbnjug

Current dependencies on/for this PR:

main

PR #3611   👈

This comment was auto-generated by Graphite.


Shadows

Add support for shadows in the rendering process

Spotlight and Pointlight shadow support has now been merged. Directional lights still do not cast a shadow as of this comment.

Shadow map rendering still has to be changed into instanced support but doing that requires a rework of the rendering pipeline first

Rendering pipeline has been reworked, so now two things are required to close this ticket

Support for directional Lights
Instancing support for shadow maps

Closing as stale


Issues with AAD Token setup via PowerShell

Frankly, the instructions for setting up the databricks-cli via PowerShell on Windows are terrible.  If nothing else, running the az login, followed by two lines of PowerShell followed by a databricks configure command is a really convoluted way to get two values into a config file.
Also:

These instructions assume the user is running as an admin and is able to modify the system environment variables.  This is a bad assumption.
This stores the user's AAD token as a system variable, available to all users and processes on the machine, which is a BIG security issue if there are any untrusted users or processes on the machine,
The Azure AD token can be larger than 1024 characters, which means the value in the environment variable will get truncated and not work.

Why not just write to the config file directly from Powershell?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 47bb00ae-8ec1-0000-4972-5dfd22983982
Version Independent ID: 8a8a2723-9a42-1f24-80c4-9c44b59372e2
Content: Databricks CLI - Azure Databricks
Content Source: databricks/dev-tools/cli/index.md
Service: azure-databricks
GitHub Login: @mssaperla
Microsoft Alias: saperla

Thanks for the feedback! We have assigned the issue to the content author to further review this and update the document as appropriate.

Thanks for your dedication to our documentation. Unfortunately, we have been unable to review your issue and apologize for the delayed response. The requested updates have not yet been made. The timeline for resolution varies based on resourcing. We've created an internal work item (DOC-7146) to incorporate your suggestions. We are closing this issue for now, but feel free to comment here as necessary.
#please-close

#please-close


Using Seed Names from ZClassic Wallet

I launched the BTCP Electrum Wallet and used the seed names from my ZClassic Electrum Wallet. I had read that this would work !
I have been credited correctly with BTCP but they are all unverified and have been for 14 hours.
The wallet synced ok but still not verified ?
Any help on this would be much appreciated.

Hello, could you try this: https://support.btcprivate.org/464851-Transactions-Are-Unconfirmed-For-HoursDays
You'll need to modify for sure with Electrum, but the procedure should be very similar.

That worked like a charm, thanks IceAge0121 for your help...


NPE in v1.2.0 - SwipeLayout.java line 901

Hi,
I have had a crash report, although I'm unable to recreate myself:
0	java.lang.NullPointerException
1	at com.daimajia.swipe.SwipeLayout.onTouchEvent(SourceFile:901)
2	at android.view.View.dispatchTouchEvent(View.java:5568)

I looked at the code and it occurs here:

Any idea why getParent() would be null?  Could we add a null check here?
Regards,
Colin

same issue as #146


New version: tildearrow.Furnace version 0.6.1

Pull request has been created with komac v2.1.0 :rocket:
Microsoft Reviewers: Open in CodeFlow

@wingetbot run

Hi @OfficialEsco,

This PR's version number 0.6.1 has 3 parameters (sets of numbers between dots - major, minor, etc), which is greater than the current manifest's version 0.6, which has 2 parameters.

Does this PR's version number exactly match the version reported in the Apps & features Settings page? (Feel free to attach a screenshot.)
(Automated response - build 870)


Update Readme.md for better readability

Adding objc tag in code block to apply Markdown color scheme for easier reading of documentation.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


target system_webview_apk has not been supported

make ninja T=system_webview_apk failed

closed due to I'm not working on this now.


AddressSanitizer: heap-use-after-free in 3-arg min_by and max_by applied to (varchar, complex-type, n)

Bug description
The implementation of min_by(varchar, array|map|row, n) fails to write input strings to the arena and ends up storing StringView's pointing to freed memory.
TEST_F(MinMaxByNTest, xxx) {
  std::string s[6];
  for (int i = 0; i < 6; ++i) {
    s[i] = std::string(StringView::kInlineSize, 'x') + std::to_string(i);
  }

  auto data = makeRowVector({
      makeFlatVector<std::string>({s[0], s[1], s[2], s[3], s[4], s[5]}),
      makeRowVector({
          makeFlatVector<int16_t>({1, 2, 3, 4, 5, 6}),
          makeFlatVector<int32_t>({10, 20, 30, 40, 50, 60}),
      }),
  });

  auto expected = makeRowVector({
      makeArrayVector(
          {0},
          makeRowVector({
              makeFlatVector<int16_t>({1, 2, 3}),
              makeFlatVector<int32_t>({10, 20, 30}),
          })),
      makeArrayVector(
          {0},
          makeRowVector({
              makeFlatVector<int16_t>({6, 5, 4, 3}),
              makeFlatVector<int32_t>({60, 50, 40, 30}),
          })),
  });

  testReadFromFiles(
      {data}, {}, {"min_by(c1, c0, 3)", "max_by(c1, c0, 4)"}, {expected});
}

==2585652==ERROR: AddressSanitizer: heap-use-after-free on address 0x62b00000e25e at pc 0x00000262a862 bp 0x7f05e91fa660 sp 0x7f05e91f9e10
READ of size 9 at 0x62b00000e25e thread T73
SCARINESS: 52 (9-byte-read-heap-use-after-free)
    #0 0x262a861 in MemcmpInterceptorCommon(void*, int (*)(void const*, void const*, unsigned long), void const*, void const*, unsigned long) (/data/users/mbasmanova/fbsource/buck-out/v2/gen/fbcode/9c7eecad4ba7475f/velox/functions/prestosql/aggregates/tests/__test__/test+0x262a861)
    #1 0x262af28 in memcmp (/data/users/mbasmanova/fbsource/buck-out/v2/gen/fbcode/9c7eecad4ba7475f/velox/functions/prestosql/aggregates/tests/__test__/test+0x262af28)
    #2 0x7f066f78d578 in facebook::velox::StringView::compare(facebook::velox::StringView const&) const fbcode/velox/type/StringView.h:175
    #3 0x7f067058678c in facebook::velox::StringView::operator<(facebook::velox::StringView const&) const fbcode/velox/type/StringView.h:180
    #4 0x7f0670b29434 in facebook::velox::aggregate::prestosql::(anonymous namespace)::Less<facebook::velox::HashStringAllocator::Position, facebook::velox::StringView>::compare(facebook::velox::StringView, std::pair<facebook::velox::StringView, std::optional<facebook::velox::HashStringAllocator::Position> > const&) fbcode/velox/functions/prestosql/aggregates/MinMaxByAggregates.cpp:1096
    #5 0x7f0670b28a04 in facebook::velox::aggregate::prestosql::(anonymous namespace)::MinMaxByNComplexTypeAccumulator<facebook::velox::StringView, facebook::velox::aggregate::prestosql::(anonymous namespace)::Less<facebook::velox::HashStringAllocator::Position, facebook::velox::StringView> >::compareAndAdd(facebook::velox::StringView, facebook::velox::DecodedVector&, int, facebook::velox::aggregate::prestosql::(anonymous namespace)::Less<facebook::velox::HashStringAllocator::Position, facebook::velox::StringView>&, facebook::velox::HashStringAllocator*) fbcode/velox/functions/prestosql/aggregates/MinMaxByAggregates.cpp:988
    #6 0x7f0670b27d0e in facebook::velox::aggregate::prestosql::(anonymous namespace)::MinMaxByNAggregate<facebook::velox::ComplexType, facebook::velox::StringView, facebook::velox::aggregate::prestosql::(anonymous namespace)::Less<facebook::velox::HashStringAllocator::Position, facebook::velox::StringView> >::addRawInput(char*, int) fbcode/velox/functions/prestosql/aggregates/MinMaxByAggregates.cpp:1344

System information
n/a
Relevant logs
No response

CC: @kagamiori @laithsakka @kgpai @bikramSingh91

is this caught by fuzzer or shadow?

i see those are skipped in the aggregation fuzzer.

@laithsakka I think this would be caught by aggregation fuzzer if we add an option to run aggregations over table scan (vs. values).
@oerling Orri spotted this issue while fixing something else, then I created a simple repro that I put in this issue.

i see those are skipped in the aggregation fuzzer.

I wonder if these are skipped or only results verification is skipped. I assume the latter.

The root cause of this error is that the accumulator of MinMaxBy doesn't support StringView-typed compare (i.e., the second argument). StringView-typed inputs requires special handling because we cannot copy them directly to the accumulator in addRawInput or addSingleGroupRawInput (since the input vector will be released after the call). There is currently a MinMaxByNStringViewAccumulator, but it only supports the first argument to be StringView. A fix would be making accumulator types that allows StringView-typed second argument (or making a template for them to reduce code duplicates).


Forgotten echo engine

the sample at README has no engine.
this fix import int and change the
Echo Run to use the standard engine.
Also add and example directory to run the same example on README

thx


Twitter API v2 / OAuth 2.0 Support

Great work on this repo @cuongdevjs ! Is there any chance to implement the new OAuth 2.0 Flow that was introduced with the Twitter API v2?
The new OAuth 2.0 Flow doesn't require to disclose the client secret, so it would actually be possible to use the gem in production.
See the documentation here for reference:
https://developer.twitter.com/en/docs/authentication/oauth-2-0/authorization-code

ok. that's great. I will research and implement it soon.

Awesome thank you!

@cuongdevjs It looks to me like Twitter might be blocking the tracking of window.open via its CORS policy?

I've tried on https://react-social-login.netlify.app/ and it still works.

@cuongdevjs I meant for the v2 API flow with OAuth 2.0

no, it still works, I am trying to change it to v2 and I think it is possible.

Okay awesome! I was trying to implement it and am having issues with the detecting the end of the auth flow when Twitter redirects and has the code in the URL. If you can get that callback to work would be awesome! 🙌🏼

Hi. Everything is ready to use. Please upgrade to the newest version (v2.5.2)
Thank you.

Awesome, thank you @cuongdevjs
I see it is definitely working on your demo site - however, for me it doesn't redirect from the callback (see screenshot below):

Code is pretty simple:
import React, { useCallback, useEffect, useState } from 'react'
import { ICON_NAMES } from '../../../utils/Constants';
import * as globalStyles from '../../../utils/GlobalStyles';
import ButtonView from '../../atoms/ButtonView';
import { LoginSocialTwitter } from 'reactjs-social-login';

const REDIRECT_URI = 'http://localhost:8000/callback'

export default function TwitterLoginButtonView(props) {
  const {
    sourceObjectType,
    sourceObjectId,
    authGoogle,
    source,
    isBackstageAuthorized,
    buttonText="connect"
  } = props;

  const scope = 'tweet.read%20users.read%20offline.access';
  const state = 'twitter'

  const [provider, setProvider] = useState('');
  const [profile, setProfile] = useState('');

  return (
    <LoginSocialTwitter
      client_id={'SE10ME5MTTM4a3FwSURBdWVfTDU6MTpjaQ'}
      client_secret={''}
      redirect_uri={"http://localhost:8000/callback"}
      onResolve={({ provider, data }) => {
        console.log(provider, data)
      }}
      onReject={(err) => {
        console.log(err)
      }}
    >
      <ButtonView
        text={buttonText}
        customButtonBackgroundColor={source.buttonColor || source.iconColor}
        disabled={!!isBackstageAuthorized}
        rightIcon={!!isBackstageAuthorized ? { name: ICON_NAMES.CHECKMARK, color: globalStyles.colors.text3, size: 12, style: { paddingLeft: 6 } } : undefined}
      />
    </LoginSocialTwitter>
  );
}

Also it would be great if we can pass in state and scope so that we can customize them.

please make sure:

redirect_uri must be the same as the URL where the Twitter Login component is located (example: you put TwitterLogin on URL localhost:3000/login, so redirect_uri must be localhost:3000/login too)
the component TwitterLogin must exist (on DOM) when redirect_uri is returned (you shouldn't destroy or unmount the TwitterLogin component before login successfully)

Also it would be great if we can pass in state and scope so that we can customize them.

Please upgrade to version 2.5.4, both props are available to use.

Amazing, thanks for clarifying @cuongdevjs!
This is now working as expected, and also huge thanks for implementing the state and scope params so quickly!
Last question: Would it be possible to pass down another param to only execute onLogin without calling getAccessToken and getProfile. Essentially all that we need is the code that is coming back from the original authorization window, then we handle the rest server side. Will be great if you can make an option for that!

sure, it is possible. I think I will do that for all components.

can you create a new issue for that?

Will do, thank you!


[Backport staging-23.05] libgit2, http-parser: Fix Windows Build

Description of changes
Manual backport of #269326 due to conflict.
Draft until that one is merged.
Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Priorities
Add a :+1: reaction to pull requests you find important.

Should we really backport this late into 23.05 this many fixes? Also it seems like you picked a few to many commits that are not really based on the PR message.

@SuperSandro2000 I am inclined to do this backport because Nix is currently on 23.05 and upgrading to a new version has unfortunately been a real PITA before.

Then we might as well.
and Windoof 👀 sounds like a new journey to go on


Add table option from ER-diagram view

There should be a way to be able to directly create a new table from this view, something like a new table option in context menu. Maybe this can be added to where the currently existing tables are listed?

Do you mean ERD editor?
Diagram editor (including tables/columns/references creation) is a big task. I'll start to think about that after 4.x release. Till then it'll be read-only.


Make .zero_grad() signature consistent with PyTorch (set_grads_to_None)

Is your feature request related to a problem? Please describe.
The DeepSpeed optimizers have a .zero_grad() method like all optimizers in PyTorch, but the argument that controls whether gradients get zeroed out vs. set to None is named set_grads_to_None
https://github.com/microsoft/DeepSpeed/blob/323c266cfe65f16f522092f1bc84998e04ed7f94/deepspeed/runtime/zero/stage_1_and_2.py#L1534
whereas in PyTorch, it is called set_to_none. This inconsistency requires other frameworks that wrap around deepspeed to have a translation depending on whether a PyTorch optimizer or a DeepSpeed optimizer is used.
Describe the solution you'd like
Rename the argument to set_to_none.
Describe alternatives you've considered
Keeping it as is. This is not a major issue, but it would be nice to be consistent with the naming in PyTorch. Less cognitive overhead for users.
Additional context
Example of how it can be translated in other libraries for now:
https://github.com/Lightning-AI/lightning/pull/16275

Thank you @loadams @jeffra, very nice improvement!


docker build failed to commit changes in base image

Hello,
It seems the docker build has a problem with changes made in the base image... snippet of my Dockerfile, which used a caffe base image that created /opt/caffe:
FROM tleyden5iwx/caffe
...
RUN echo "testing 2" > /opt/caffe/data/ilsvrc12/test2.txt && ls -l  /opt/caffe/data/ilsvrc12/
RUN echo "testing 3" > /opt/test3.txt  && ls -l /opt
RUN echo "checking files..." && ls -l /opt/caffe/data/ilsvrc12 && ls -l /opt

the related output as following:
Step 14 : RUN echo "testing 2" > /opt/caffe/data/ilsvrc12/test2.txt && ls -l  /opt/caffe/data/ilsvrc12/
 ---> Running in e186d33f4c49
total 12
-rwxr-xr-x 1 root root 582 Nov 24 15:53 get_ilsvrc_aux.sh
-rwxr-xr-x 1 root root 637 Dec  7 14:25 get_ilsvrc_aux2.sh
-rw-r--r-- 1 root root  10 Dec  7 15:11 test2.txt
 ---> cb718e60db21
Removing intermediate container e186d33f4c49
Step 15 : RUN echo "testing 3" > /opt/test3.txt  && ls -l /opt
 ---> Running in e3866e28e745
total 648
drwxr-xr-x 15 root  root   4096 Dec  7 15:11 caffe
drwxr-xr-x  7 root  root   4096 Nov 24 15:54 gflags-master
drwxr-xr-x  9 50220 5000   4096 Nov 24 15:54 glog-0.3.3
-rw-r--r--  1 root  root 509676 Feb  1  2013 glog-0.3.3.tar.gz
-rw-r--r--  1 root  root 128407 Nov 24 15:54 master.zip
drwxr-xr-x  2 root  root   4096 Dec  7 15:11 matrix
-rw-r--r--  1 root  root     10 Dec  7 15:11 test3.txt
 ---> 38a20c2aa112
Removing intermediate container e3866e28e745
Step 16 : RUN echo "checking files..." && ls -l /opt/caffe/data/ilsvrc12 && ls -l /opt
 ---> Running in 3955ad62fb82
checking files...
total 8
-rwxr-xr-x 1 root root 582 Nov 24 15:53 get_ilsvrc_aux.sh
-rwxr-xr-x 1 root root 637 Dec  7 14:25 get_ilsvrc_aux2.sh
total 648
drwxr-xr-x 15 root  root   4096 Dec  7 15:11 caffe
drwxr-xr-x  7 root  root   4096 Nov 24 15:54 gflags-master
drwxr-xr-x  9 50220 5000   4096 Nov 24 15:54 glog-0.3.3
-rw-r--r--  1 root  root 509676 Feb  1  2013 glog-0.3.3.tar.gz
-rw-r--r--  1 root  root 128407 Nov 24 15:54 master.zip
drwxr-xr-x  2 root  root   4096 Dec  7 15:11 matrix
-rw-r--r--  1 root  root     10 Dec  7 15:11 test3.txt
 ---> 5dcfefc9bc4e
Removing intermediate container 3955ad62fb82
Step 17 : WORKDIR /opt/matrix
 ---> Running in 87b9118fa704
 ---> 0edd01bf0484
Removing intermediate container 87b9118fa704
Successfully built 0edd01bf0484

As you can see the echo did successfully create those files during the given RUN session, however the change made in the base image directory(test2.txt) was not committed while the one outside of base image (test3.txt)  did. Is this a known bug or I am missing something?
$ docker info
Containers: 0
Images: 108
Storage Driver: aufs
 Root Dir: /mnt/sda1/var/lib/docker/aufs
 Dirs: 110
Execution Driver: native-0.2
Kernel Version: 3.16.7-tinycore64
Operating System: Boot2Docker 1.3.2 (TCL 5.4); master : 495c19a - Mon Nov 24 20:40:58 UTC 2014
Debug mode (server): true
Debug mode (client): false
Fds: 10
Goroutines: 11
EventsListeners: 0
Init Path: /usr/local/bin/docker

ping @cpuguy83

Closing since this is a dup of #8647 and #3639


support hubRegistrationFeatureGates and spokeRegistrationFeatureGates

This PR is depend on the PR in api https://github.com/open-cluster-management-io/api/pull/149, must modifying go.mod and updating vendor afeter api pr 149 is merged
reconcile hubRegistrationFeatureGates and spokeRegistrationFeatureGates to registration deployment()
Signed-off-by: ivan-cai<EMAIL_ADDRESS>

@ivan-cai would you like to rebase this PR thanks!
ok👌🏻

@qiujian16 Plz review again. I have changed to use  api repo's variables DefaultHubRegistrationFeatureGates & DefaultSpokeRegistrationFeatureGates to check registration if valid.

@qiujian16 I have changed by your advices, plz review again.

/test

@qiujian16 I have fix some errors in unit test, plz review again. Thank you very much!

@ivan-cai two small nit comment. PTAL again and we are good to go! Thanks!

@qiujian16 Yes, I see, I will add more integration tests in a followup PR. Could you merge this PR?

ah, sorry, I think I forgot to push the comment...I think you would also need to add default feature gates for registration webhooks

ah, sorry, I think I forgot to push the comment...I think you would also need to add default feature gates for registration webhooks and also this one #230 (comment).

@qiujian16 I have add feature gates for egistration webhook, plz review again.

/lgtm
FYI @zhiweiyin318 I think this pr is pretty careful to avoid any regression failure, but we still need to monitor it


Updated dependencies to Dart3/Flutter 3.10 compatible ones

Update the SDK to v3, additional updates for various packages

Looks like there are some problems with the build, presumably as a result of SDK 3. I don't have time right now to dig in, but am happy to do so when I free up. If you're keen, feel free to take a look @MagnusJohansson.

Yes, I see... it seems that the Dart team  in their infinite wisdom decided to mark the ByteStream class as final, which prevents Mockito to mock it...
I raised an issue with them, let's see what their response is.
I suppose a workaround , as suggested in this Mockito issue, is to create a wrapper around http.

@kentcb Can the tests be modified to not mock the ByteStream, as per this comment?
https://github.com/dart-lang/http/issues/956#issuecomment-1632169699

Resolved by #40 and published


unify mustache template rendering usage

We had a _renderTemplate function that was being used directly in different places. This function would render mustache template with given data. But the data was not following the rules that we had in place for raw and formatted values (by using '_').
Now _renderTemplate function will generate the formatted and raw values if the given data is not formatted. Also _validateTemplate function has been refactored to support both url_pattern and other usages of mustache template.

P.S.

This most probably will break chaise test cases, I will fix those testcases in my chaise PR.

After merging this, I will update the asset annotation document.

@jrchudy You're correct. Previously we just had one _renderTemplate function which wasn't doing any formatting and was using the given data (which I renamed to _renderMustacheTemplate in this PR). It was the callers responsibility to format the values. That's why in some cases we forgot to do it.  I just created a wrapper for that function which will take care of formatting values if needed.
(This is also true for _validateTemplate and _validateMustacheTemplate.)


Test on travis

I've enabled Travis for this repository, so it should just be a matter of getting a .travis.yml going: https://travis-ci.org/disqus/nexus


Take CanvasLayer transform into account for 2D physics

Fixes #18073.
EDIT: No cherry-pick needed, a separate PR for 3.0 will contain this.
This code is donated by an anonymous contributor.

Thanks!

This is clearly generating problems, but I am not sure why

Me neither. But since the main problem to address was picking, I'm taking a different route:
Areas and bodies will have a canvas_instance_id in the Physics2DServer, the same way they have the object id of their corresponding nodes.
With that, intersection queries filtered by canvas id will be possible.
Viewport will have a list of every descendant canvas and it will be able to do filtered queries for picking transforming the touch/mouse position correctly in every case with the canvas transforms.
I'll submit a PR reverting the current broken approach and implementing this new idea. Less overhead, fixes the real issue and is also compatible with 3.0.
Sounds good to you?

Sounds good to me. I'll push the revert of 4839e5f for now to fix issues users are experiencing, then we can review and test your new proposal. (20dc630 seems to be ok according to #21289).

Or do you advise to revert both/the whole PR? (i.e. does 20dc630 makes sense by itself, or should it be used only if 4839e5f is included too?)

OK!
They are independent. Only 4839e5f is bad.

Alright, 4839e5f is reverted as ab3716bd4.


Code deleted after pressing ctr+alt+f

Hi,
I'm using the latest version of sublime text editor and code-formatter, I tried to PHP code but after pressing ctr+alt+f my code deleted, it is strange.
<?php

namespace App\Http\Controllers;

use App\Http\Controllers\Controller;
use App\Models\Test;

class UserController extends Controller
{
....
}

My code use App\Models\Test;  always deleted by code formatter whenever I pressed ctr+alt+f.

https://github.com/akalongman/sublimetext-codeformatter/issues/313

this is not issue it is designed this way you need to set your configuration carefully


RxR fine-tuned model release

Hi,
Is there a chance for you to release your fine-tuned model for RxR just like R2R and CVDN? Thanks!

Hi,
I just upload the RxR ckpt in dropbox: https://www.dropbox.com/sh/ugpdl1q04xj0ht2/AAAANVRq7ZfAHLfuQXJ9bTo4a?dl=0

Best,
Jialu


Teams app publish and update commands

This PR contains the commands to publish and update Teams app to your organization's app catalog.

Coverage remained the same at 100.0% when pulling ab4acb78c86e889bed96842e21c60cf5c2cf9e64 on estruyf:teams-app-publish into 6200f63f350ef22779f70e1ce3a886d97f796841 on pnp:dev.

Thanks! I'll have a look asap!

Merged manually. Thanks! Cool stuff!