Crashes caused by XamlCompiler - not a part of WinUI framework

Right now the Xaml compiler determines if types are built into the WinUI framework by checking if they have our Microsoft.UI.Xaml.WinUIContract on them.  Now that CSWinRT has removed the ContractVersionAttribute projection in 0.5.5, the Xaml compiler thinks all types, even WinUI types, aren't part of the WinUI framework.  When a 0.5.5 app builds against a 0.5.0 library, it can crash because of the incorrect 0.5.5 codegen (which actually works fine on its own, but with needless overhead) interacting with the 0.5.0 codegen.  This also presents a perf issue since the compiler is generating extra type information for built-in WinUI types when it doesn't need to.

it can crash because of the incorrect 0.5.5 codegen

@dayman40 I'm a little confused by this. Does this mean that if I shipped a class library built on top of 0.5.5, that it won't work with an app targeting 0.5.6 and I'm forced to rebuild and ship a v0.5.6 version? Or does this only affect libraries shipped on top off 0.5.0

Tagging @RealTommyKlein to help clarify this for you, @dotMorten! :)

@dotMorten - you technically shouldn't need to rebuild a library targeting 0.5.5, as the runtime crash only occurs if the app targets 0.5.5 while a library it built against targets a different version.  However, the crash present in 0.5.5 mentioned in this bug also increases the memory footprint of 0.5.5 apps/libraries, so you should still rebuild against 0.5.6.

@RealTommyKlein Thanks Tommy. Re-releasing right now on 0.5.6 is a bit disruptive - I'm curious how critical the memory footprint issue is? Is this a memory leak, or just an initial larger hit? Since we're still tagging our package pre-release, I'm leaning towards not generating a new 0.5.6-based build until our next regular release cycle.

@dotMorten - no memory leak, but your binaries will be larger because the Xaml compiler generates unused code due to the metadata issue.

@RealTommyKlein Thanks for confirming. We just have a limited generic.xaml so I think we can live with that for now.

Thank you @RealTommyKlein!!
Please let us know if you have any further questions, @dotMorten.


zigbee2mqtt: 1.16.2 -> 1.22.1

Motivation for this change
Zigbee2mqtt still stuck @1.16.2
Things done
This PR builds on https://github.com/NixOS/nixpkgs/pull/147792 , adds a postInstall hook for typescript transpilation and then updates zigbee2mqtt to version 1.22.1.
It also fixes a small issue, where the module did still pass dataDir to the package.
Removes upgrade warning.

Built on platform(s)

[x] x86_64-linux
[x] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[ ] Fits CONTRIBUTING.md.

Duplicate of https://github.com/NixOS/nixpkgs/pull/147985

This is the continuation of the node2nix packaging for zigbee2mqtt. The other pr tries to rework it using yarn, which has issues that have been explained on the PR.
I prefer this changeset. Rolling out to my local setup as we speak.

@sweber83 Works for me. Added a minor security fixup to the systemd unit. PTAL.

Oh and commits touching the module should be prefixed with nixos/zigbee2mqtt:


Google Voice in-call Audio Silent

Google Voice in-call Audio Silent
— used to work until maybe a month ago (7/2023)
Discovered macOS 13.4.1.(c) Chromium 114.0.5735.198
Also present: macOS 13.5 Chromium 115.0.5790.170 (Official Build, ungoogled-chromium) (arm64)
works with macOS 13.5 Safari 16.6 (186<IP_ADDRESS>.2)
browse to: https://voice.google.com, place call
BUG: in-call audio in/out is silent
— ringing and hang-up sounds work
— listen to voicemail works
— audio test functions work
A periodical problem since 2019 when things no work related to some voice Plugin

I'm having this exact same problem in Windows on the latest x64 version.

@resolutecake Have you tried latest version?

This is an old issue, that didn't show much activity recently and probably lost its significance — closing.
If you have any more information to add, let us know.


How to use the CodeGraphy plugin?

I'm sorry to disturb you. I have some question in using CodeGraphy plugin. When I install this in my vscode, I don't understand how to use it. I run my code, but it is nothing happened. I would appreciate it if you can help me！

Hey @ZSIRS! Thanks for reaching out. I'd be happy to help if you could provide some more info.
What system are you on (mac/windows/linux)?
Is the issue with the plugin on a specific repo or does it occur on any that you try out?
Thanks!

Hey @ZSIRS! Thanks for reaching out. I'd be happy to help if you could provide some more info.
What system are you on (mac/windows/linux)?
Is the issue with the plugin on a specific repo or does it occur on any that you try out?
Thanks!
I‘m so sorry for taking so long to reply to you. I install it in my Linux server, and I use vscode to connect my count. Is there any documentation for the plugin? What I understand is that this plug-in you developed can show the logical structure of the running code. Is my understanding correct?

I‘m so sorry for taking so long to reply to you. I install it in my Linux server, and I use vscode to connect my count. Is there any documentation for the plugin? What I understand is that this plug-in you developed can show the logical structure of the running code. Is my understanding correct?

Hey @ZSIRS. Sorry for the late reply. I just got a new job so I haven't had as much time to work on my sideprojects.
I just released a new 1.1.0 version for CodeGraphyV2. It should have a better compatibility across different OS. Had to rewire how a bunch of the paths were being read, but I was able to verify it on my Mac and Windows machine.
Go ahead and give the latest version a try, see if it works any better for you.
1 tip that might help out, the codegraphy.blacklist is a pretty essential part of running the extension. You need the setting because of how codegraphy reads through every line of every  file. Without it you often end up processing 1000s of files at a time. Heres mine as an example:
"codegraphy.blacklist": [
    "cypress",
    "generated",
    "node_modules",
    "dist",
    ".nuxt",
    ".output",
    ".vscode",
    ".git",
    ".github",
    ".nuxt",
    ".output",
    ".yalc",
    ".husky",
    ".tool-versions",
    ".editorconfig",
    ".circleci",
    ".browserslistrc",
    ".npmignore",
    "CONTRIBUTING",
    "CODEOWNERS",
    "CHANGELOG",
    "LICENSE",
    ".spec.",
    ".d.ts",
    ".storybook",
    ".log",
    ".lock",
    "lerna.json",
    ".excalidraw",
    ".yaml",
    ".DS_Store",
    "types.ts"
  ],

Theres no documentation as of right now but a brief explanation is that CodeGraphy has 2 main modes. Directory or Interaction. Directory mode just shows a simple graphed version of the file hierarchy that your used to navigating in the sidebar. It just is graphed. Interaction mode is where things get interesting, because it reads through your code and shows connections based on how your code connects to each other, rather than where its located in your folder.
Theres a settings wheel with a bunch of different options you can play with to modify the graph to your liking.
A cool feature to play around with is the activeFile and depth slider. Codegraphy calculates the depth of each node from the file your currently looking at and allows you to hide all nodes outside of a certain reach from the 1 your looking at, allowing you to narrow your scope and focus in on a local area of your codebase.
Final tip, everything should have a tooltip if you hover over it. Let me know how it works out for you!

Does not work on a next.js app when at the root directory. I'm on windows.

Does not work on a next.js app when at the root directory. I'm on windows.

Hey @ilbrigz! Thanks for giving the extension a go. Make sure that you add .next to your "codegraphy.blacklist" in your workspace settings. This folder is generated by next and is not supported for analyzing with CodeGraphy. These generated files are 10s of thousands of lines long which combined with CodeGraphys in depth analysis will result in a 422 error from High CPU Load. Adding this, and any other generated folders to the blacklist should alleviate this issue.

I finally got it to work by just copying my .gitignore into the blacklist and formatting it to JSON. That would be a nice default.

Okay and they need to be cleaned up. The logic is if the blacklist name is included in the path at all, it filters it out. So remove / and * and stuff like that. And the settings are taken into account when the extension is loaded, so restarting VSCode applied the setting


[REPLAY-9] Generate Multi-Version Manifest

Takes arguments for start_block_id, end_block_id, snapshot_path, snapshot_type, and expected_integrity_hash, and generate configuration for leap version from 3.1, 3.2, 4.0, 5.0.
Alternatively takes arguments for a config file, and a slice-id and generates the same by parsing the file for the specified index.

closed with PR #66


Implement Quota support in Google service control adapater

@manlinl: Adding do-not-merge/release-note-label-needed because the release note process has not been followed.

One of the following labels is required "release-note", "release-note-action-required", or "release-note-none".
Please see: https://github.com/kubernetes/community/blob/master/contributors/devel/pull-requests.md#write-release-notes-if-needed.
Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@manlinl: Adding do-not-merge/release-note-label-needed because the release note process has not been followed.

One of the following labels is required "release-note", "release-note-action-required", or "release-note-none".
Please see: https://github.com/kubernetes/community/blob/master/contributors/devel/pull-requests.md#write-release-notes-if-needed.
Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

/lgtm /approve

/lgtm


Update to Jest >=0.5.0 so tests can run on Node 4.x

Jest 0.4.x only works on Node 0.12.x and below, so Immutable JS tests can't be run on newer versions of Node.
I started looking into this, and found that while Jest 0.5.x works fine, 0.6.0  and above breaks various tests:
$ npm test

><EMAIL_ADDRESS>test /Users/tboyt/Coding/immutable-js
> ./resources/node_test.sh

Using Jest CLI v0.8.2, jasmine1
 PASS  __tests__/updateIn.ts (0.814s)
 PASS  __tests__/Set.ts (0.181s)
 PASS  __tests__/IterableSeq.ts (0.134s)
 PASS  __tests__/slice.ts (2.206s)
Running 31 test suites.../Users/tboyt/Coding/immutable-js/contrib/cursor/__tests__/Cursor.ts 7:24 Exported external package typings file '/Users/tboyt/Coding/immutable-js/node_modules/immutable/contrib/cursor/index.d.ts' is not a module. Please contact the package author to update the package definition.
 FAIL  contrib/cursor/__tests__/Cursor.ts
● Runtime Error
Error: Compiling /Users/tboyt/Coding/immutable-js/contrib/cursor/__tests__/Cursor.ts failed
    at compileTypeScript (/Users/tboyt/Coding/immutable-js/resources/jestPreprocessor.js:61:9)
    at Object.module.exports.process (/Users/tboyt/Coding/immutable-js/resources/jestPreprocessor.js:74:43)
    at module.exports.config.scriptPreprocessor.config.preprocessorIgnorePatterns.some (/Users/tboyt/Coding/immutable-js/node_modules/jest-cli/src/lib/transform.js:133:33)
    at Loader._execModule (/Users/tboyt/Coding/immutable-js/node_modules/jest-cli/src/HasteModuleLoader/HasteModuleLoader.js:176:25)
    at Loader.requireModule (/Users/tboyt/Coding/immutable-js/node_modules/jest-cli/src/HasteModuleLoader/HasteModuleLoader.js:760:14)
    at jasmine1 (/Users/tboyt/Coding/immutable-js/node_modules/jest-cli/src/testRunners/jasmine/jasmine1.js:233:16)
    at /Users/tboyt/Coding/immutable-js/node_modules/jest-cli/src/TestRunner.js:261:14
 PASS  __tests__/Range.ts (0.399s)
 FAIL  __tests__/concat.ts (1.859s)
● concat › it concats arrays to indexed seq
  - Expected: {
    | 0: 1,
    | 1: 2,
    | 2: 3,
    | 3: 4,
    | 4: 5,
    | 5: 6
    } toEqual: {
    | 0: 1,
    | 1: 2,
    | 2: 3,
    | 3: 4,
    | 4: 5,
    | 5: 6
    }
        at Spec.eval (__tests__/concat.ts:43:40)
● concat › it concats values
  - Expected: {
    | 0: 1,
    | 1: 2,
    | 2: 3,
    | 3: 4,
    | 4: 5,
    | 5: 6
    } toEqual: {
    | 0: 1,
    | 1: 2,
    | 2: 3,
    | 3: 4,
    | 4: 5,
    | 5: 6
    }
        at Spec.eval (__tests__/concat.ts:48:46)
● concat › it concats multiple arguments
  - Expected: {
    | 0: 1,
    | 1: 2,
    | 2: 3,
    | 3: 4,
    | 4: 5,
    | 5: 6,
    | 6: 7,
    | 7: 8,
    | 8: 9
    } toEqual: {
    | 0: 1,
    | 1: 2,
    | 2: 3,
    | 3: 4,
    | 4: 5,
    | 5: 6,
    | 6: 7,
    | 7: 8,
    | 8: 9
    }
        at Spec.eval (__tests__/concat.ts:63:43)
● concat › it can concat itself!
  - Expected: {
    | 0: 1,
    | 1: 2,
    | 2: 3,
    | 3: 1,
    | 4: 2,
    | 5: 3,
    | 6: 1,
    | 7: 2,
    | 8: 3
    } toEqual: {
    | 0: 1,
    | 1: 2,
    | 2: 3,
    | 3: 1,
    | 4: 2,
    | 5: 3,
    | 6: 1,
    | 7: 2,
    | 8: 3
    }
        at Spec.eval (__tests__/concat.ts:68:43)
 PASS  __tests__/Stack.ts (2.413s)
 PASS  __tests__/merge.ts (0.085s)
 PASS  __tests__/List.ts (6.508s)
 PASS  __tests__/flatten.ts (0.264s)
 PASS  __tests__/Map.ts (7.944s)
 FAIL  __tests__/ArraySeq.ts (0.096s)
● ArraySequence › it maps
  - Expected: {
    | 0: 2,
    | 1: 4,
    | 2: 6
    } toEqual: {
    | 0: 2,
    | 1: 4,
    | 2: 6
    }
        at Spec.eval (__tests__/ArraySeq.ts:21:19)
 PASS  __tests__/OrderedMap.ts (0.033s)
 PASS  __tests__/Seq.ts (0.027s)
 PASS  __tests__/Record.ts (0.026s)
 PASS  __tests__/zip.ts (0.766s)
 PASS  __tests__/count.ts (0.029s)
 PASS  __tests__/Equality.ts (3.248s)
 PASS  __tests__/MultiRequire.js (0.11s)
 FAIL  __tests__/groupBy.ts (0.038s)
● groupBy › it groups indexed sequences, maintaining indicies
  - Expected: {
    | 0: {
    | | 1: 2,
    | | 3: 4,
    | | 5: 6
    | },
    | 1: {
    | | 0: 1,
    | | 2: 3,
    | | 4: 5
    | }
    } toEqual: {
    | 0: {
    | | 1: 2,
    | | 3: 4,
    | | 5: 6
    | },
    | 1: {
    | | 0: 1,
    | | 2: 3,
    | | 4: 5
    | }
    }
        at Spec.eval (__tests__/groupBy.ts:19:114)
 PASS  __tests__/ObjectSeq.ts (0.024s)
 PASS  __tests__/OrderedSet.ts (0.029s)
 PASS  __tests__/ListJS.js (0.07s)
 PASS  __tests__/Conversion.ts (4.134s)
 PASS  __tests__/RecordJS.js (0.153s)
 PASS  __tests__/get.ts (0.021s)
 PASS  __tests__/sort.ts (0.031s)
 PASS  __tests__/interpose.ts (0.02s)
 PASS  __tests__/IndexedSeq.ts (0.043s)
 PASS  __tests__/KeyedSeq.ts (1.305s)
 PASS  __tests__/Repeat.ts (0.024s)
 PASS  __tests__/splice.ts (1.375s)
 PASS  __tests__/minmax.ts (5.137s)
 PASS  __tests__/join.ts (3.348s)
6 tests failed, 1 test suite failed, 427 tests passed (433 total in 35 test suites, run time 15.815s)
npm ERR! Test failed.  See above for more details.

It looks like Jest is transforming the objects it's trying to assert in an unexpected way, since the pretty-printed objects in don't match up to what's actually being tested.
Of course, the easy fix to is to just use Jest 0.5.x (which is what I'm doing so I can test without installing nvm and setting up Node 0.12), but long-term it might be better to make sure this works with current versions of Jest.

Thanks for your investigation. Agreed being stuck on old node sucked.


Put back https scheme

Now that port issues are resolved and nginx is configured, I'd like to try adding this again...

lets try it 🙌

#mergeongreen


FutureViewModel with SharedPreferences and issue with not disposing viewmodel when user logs out

How can I call future with FutureViewModel and store the model data in local storage as soon as it's data ready?
And from there on, only read the stored data every time the user visits the view because in my case, this future data will not change automatically.
However, I can definitely not dispose the viewmodel and continue to show the data without requesting extra future calls and also without not storing it and reading it from local storage.
But not disposing the viewmodel brings my next problem below.
When the user logs out (firebase auth) from an account and logs into another account within the same device without destroying the app lifecycle, due to not disposing the viewmodel, the future value from the previous user account shows in the next user screen, whereas it shouldn't!

As a workaround you may namespace the stored data by userId and show to the logged in user only the data relevant to him.
I guess this would make sense only for a very few number of users sharing the same device.

As a workaround you may namespace the stored data by userId and show to the logged in user only the data relevant to him.
I guess this would make sense only for a very few number of users sharing the same device.

Real users won't share the same device in reality. But this is a test case and it should not show such weird behavior.
I am looking for a straightforward and simple approach here. Otherwise, I have to ditch the FutureViewModel but I really don't want to.

Ok, I fixed it by moving all future data model logic to another service just like post_Service in the example. In that file, I created two basic methods: one for fetching from the api/firestore, one for fetching from local storage. After that, it's just basic conditional logic checking in another future function. And then used that conditional method within the viewmodel futureToRun function. That's all.

@nahid18 sounds about right. I inject my database into my services and then read from there. if it's null from the db then I fetch from the API. you don't need two functions, just 1.  It'll be less code and you don't need a conditional in your viewmodel.

@nahid18 sounds about right. I inject my database into my services and then read from there. if it's null from the db then I fetch from the API. you don't need two functions, just 1. It'll be less code and you don't need a conditional in your viewmodel.

How about a tutorial with stacked showing exactly what you said here? Also managing cache, fetching data when user updates some data from app, save it again to local storage and also simultaneously updating the UI with reactiveViewModel etc. This will be much helpful.
One simple use case is: Logging in, reading user data from firestore; based on user's data, make a new request from different firestore collection, also, saving all these value to the local storage and showing it to the UI. Most importantly, when user changes the data, the viewmodel will update everything instantly without going back and forth the view, while also updating the local storage.

@nahid18 I might make a tutorial on sqlite but it won't cover any of the situations you spoke about. I'll show the pattern used which should then cover every situation you encouter when using local storage. it'll be around 13-20 minutes so it won't cover everyhing you're asking for. I don't have weeks to prepare a video, only 2 days every 2 weeks.


Non-global maker key setting

Hello @tobimori , thanks for sharing your plugin to the Elgato Stream Deck!
I was wondering if it was possible to have a setting that no longer makes the maker key global?  I know that in previous versions that was the case (i am able to use v1.3 temporarily for my needs, but I need to uninstrall 2.0 and reinstall 1.3 again after every reboot), but would like to implement something that requires different maker keys which doesn't work in the plugin in its current iteration.
If this is not possible (or a pain in the behind!) I understand, but I am hoping it is doable!
My thanks in advance.

Hi,
this is a very unspecific feature I probably won't add.
As a workaround for the auto updater, you can download v1.3 and change the version number in the json file from 1.3 to something above 2.0.
You. can find the IFTTT plugin either in ~/Library/Application Support/com.elgato.StreamDeck/Plugins/ (macOS) or %appdata%\Elgato\StreamDeck\Plugins (Windows).
Be aware, that v1.3 still depends on an older version of the Stream Deck SDK that might be removed in new versions.

Hi,
thanks for your help, advice and the warning!  This will work great for now and I appreciate you looking into it.


feat(lib): multiple entries for umd/iife

Description
This is a follow up to #7047. This enables multi entry builds for the "umd" and "iife" formats.
Since Rollup does not support code splitting builds for them (see https://github.com/rollup/rollup/issues/2072), the strategy is:

Have one main build for other output formats (and umd/iife if only one entry). Business as usual.
One more separate Rollout build per entry point for umd/iife.

Example outputs:

For normal build:
vite v3.2.0-beta.3 building for production...
✓ 2 modules transformed.
dist/foo.js   97.79 KiB / gzip: 73.58 KiB
dist/bar.js   97.81 KiB / gzip: 73.62 KiB
dist/foo.mjs   97.69 KiB / gzip: 73.50 KiB
dist/bar.mjs   97.73 KiB / gzip: 73.55 KiB

Extra non code splitting build for entry: foo
✓ 1 modules transformed.
dist/foo.umd.js   97.98 KiB / gzip: 73.75 KiB
dist/foo.iife.js   97.81 KiB / gzip: 73.61 KiB

Extra non code splitting build for entry: bar
✓ 2 modules transformed.
dist/bar.umd.js   195.64 KiB / gzip: 147.21 KiB
dist/bar.iife.js   195.47 KiB / gzip: 147.07 KiB

In watch mode:
vite v3.2.0-beta.3 building for production...

watching for file changes...

build started...
✓ 2 modules transformed.
dist/foo.mjs   97.69 KiB / gzip: 73.50 KiB
dist/bar.mjs   97.73 KiB / gzip: 73.55 KiB
dist/foo.js   97.79 KiB / gzip: 73.58 KiB
dist/bar.js   97.81 KiB / gzip: 73.62 KiB
built in 82ms.

build started (Extra non code splitting build for entry: foo)...
✓ 1 modules transformed.
dist/foo.umd.js   97.98 KiB / gzip: 73.75 KiB
dist/foo.iife.js   97.81 KiB / gzip: 73.61 KiB
built in 49ms.

build started (Extra non code splitting build for entry: bar)...
✓ 2 modules transformed.
dist/bar.umd.js   195.64 KiB / gzip: 147.21 KiB
dist/bar.iife.js   195.47 KiB / gzip: 147.07 KiB
built in 62ms.

Drawbacks
Notice that this is not without drawbacks, but depending on the use case it might be perfectly fine. Shared code will be exported multiple times which

causes bigger output
could cause runtime problems (if e.g. a shared state is expected - each chunk would have its own state)

Open questions

Since there are potential problems as described above, should the behaviour be opt-in? Something like allowNonCodeSplittingBuilds: true to state that there is no shared code between entry points or duplication is accepted. Or does the console output make it clear enought?

Is the output fine like this? Should it rather appear as if there was only one build, with one big list of chunks at the end? (Would need heavier modification of the reporter plugin)

Choosing the right label in watch mode is a bit hacky atm. Code reviewers let me know if there is a better way. Or whether we should just leave out the labels there.

What is the purpose of this pull request?

[ ] Bug fix
[x] New Feature
[ ] Documentation update
[ ] Other

Before submitting the PR, please make sure you do the following

[x] Read the Contributing Guidelines.
[x] Read the Pull Request Guidelines and follow the Commit Convention.
[x] Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
[x] Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
[x] Ideally, include relevant tests that fail without this PR but pass with it.

Ah, I see there is a failed test, likely because of the change. I will fix it tomorrow, it's getting late 😁

Tested this out on a large code base and this works well. Thanks for the PR @schummar!

@Kilbourne Not that I know of. I built it manually and then copied the either the dist or the build folder (forgot which one sorry) to my own project's vite to try it out in a real life project.

conflict sir @schummar

conflict sir @schummar

Indeed. Will resolve it this evening or tomorrow.

1 fail sir @schummar

1 failed sir @schummar

Unfortunately, there seem to be some very flaky tests, so I almost always see some error or another when running these tests. I look at them of course and try to see if it could be affected by my changes. In this instance I can't see any connection, so I'm assuming it's nothing I can do. Correct me if I'm wrong.

Thanks for this @schummar, this PR is going to be so helpful! Is there any chance someone can help with getting these test issues sorted out? I see it's just been chilling here for a couple of weeks now. I tried having a look myself, but without any prior experience with the Vite codebase, I felt way out of my depth. 🏊

@keithkirton as I said before, I don't think that the tests are broken because of this PR. Rerunning them might be enough.
There are also merge conflicts again, but I would prefer to solve them once I got some feedback. Otherwise, I will have to redo the same kind of work over and over again. If the team agrees with the PR in general, I will have it cleaned up quickly.

I really like this solution and was actually looking to do this by hand in my own project. However, in my case, I have multiple entry points that are actually extensions to my main library. They all import the main library and add to it in their own way, like plugins.
This gave me an idea to actually support manual code splitting in UMD bundles.
lib: {
  entry: {
    main: 'src/main.js',
    plugin: {
      path: 'src/plugin.js',
      external: ['main']
    },
  },
  name: 'mylib_[name]',
  format: ['es', 'umd']
}

This config would describe a case like mine, where we have a main entry point that we expect everyone to use, and a secondary entry point, that only some people would use. There could be more entry point like these, and if there are any static variables in the main entry point, trying to import multiple plugins built using UMD will not yield the expected result without properly sharing the main bundle between all of them.
The solution here is that, since vite will build each entry point one at a time, it can also generate different configurations for each of them. To deal with code splitting, we provide an additional external property to the plugin entry point. In this case, we say that when 'main' is imported, it should be considered as an external value accessible on the global scope (which is the case for UMD and iife, as long as they are loaded before the plugin). This means that rollup will properly exclude the code of the main module from the plugin, and correctly share static state like it would with an es build with actual code splitting.
This solution would assume that any time the plugin imports shared dependencies from the main module, it does so through its entry point. It couldn't detect a deep import, and would fallback to a non-code splitting solution in that case.
What do you think? Worth adding to this PR or turn it into a separate issue?

I need this 😢

I don't think @logixode is part of the Vite team, he just made a review as anyone can 😉
Mentioning team members is probably not the right thing to do. The team has a lot of PRs and issues to take care of and my guess is that lib mode doesn't have the highest priority. One could try and start a discussion on the Discord server.

I think this solution is exactly what I need! @schummar did u start a discussion in Vite discord? I'd like to contribute. Also I want to test it locally, since it's my first time doing it can you give a hint of what I have to do?

since it's my first time doing it can you give a hint of what I have to do?

https://github.com/vitejs/vite/blob/main/CONTRIBUTING.md

Any updates on this PR ? This is exactly what we require since currently the only way to achieve the above is to loop multiple times for each entry file (IIFE).

Need this for dynamic import.

This is maybe a stupid post, but if anyone else stumbles here because they want multiple entrypoints but they are not building a library, please know that you can already do this like so:
export default {
  build: {
    rollupOptions: {
      input: {
        "foo": __dirname + "/src/foo/index.tsx",
        "bar": __dirname + "/src/bar/index.tsx",
        [...]
     }
  }
}

This is maybe a stupid post, but if anyone else stumbles here because they want multiple entrypoints but they are not building a library, please know that you can already do this like so:
export default {
  build: {
    rollupOptions: {
      input: {
        "foo": __dirname + "/src/foo/index.tsx",
        "bar": __dirname + "/src/bar/index.tsx",
        [...]
     }
  }
}

I got Invalid value "umd" for option "output.format" - UMD and IIFE output formats are not supported for code-splitting builds from your suggestion.

It has been a year since this PR, would really love to see it live :)
Related references (for people looking about this feature):
https://github.com/vitejs/vite/discussions/17363
https://github.com/vitejs/vite/pull/7047
https://github.com/vitejs/vite/pull/10116
https://github.com/rollup/rollup/issues/2072
https://github.com/rollup/rollup/issues/2374

There are also merge conflicts again, but I would prefer to solve them once I got some feedback. Otherwise, I will have to redo the same kind of work over and over again. If the team agrees with the PR in general, I will have it cleaned up quickly.

Makes sense, @schummar. Your PR is now the second most popular one for Vite at the moment (with 25 likes and counting, tied for third right now in the history of Vite, actually)! I know I'd love to see this as well.
Above you also said that maybe it would be best not to tag a team member. While I'm not bold or eloquent enough to do it, hopefully the popularity of this PR at least bolsters the argument of putting it in front of someone so they can take a quick look, maybe at least triage it or even offer that essential feedback you might need. 😄

Any update on this? :smile:

Hello!
Could we expect this pull request to be merged soon? It's crucial for our transition from Webpack to Vite.

Following! Would really like to see this in Vite too!

Any updates on this?

bump

... this would be so awesome ...

I ended up writing an (inline) plugin for vite to generate the .umd & minified files:
https://github.com/rrweb-io/rrweb/blob/a6c933a23f8c6e913067650a199993e38e8b62fc/vite.config.default.ts#L6-L99
Hope this helps someone

Thanks everyone for all the solutions and workarounds shared so far.
For what is worth, I'm also sharing our experience on this topic.
In our case we ended up working around it with something simple & dumb as:
#!/usr/bin/env sh
set -e

//  `bundles.js` is a simple `module.exports = ['my', 'bundles']` containing the bundle names
bundles="$(node -e "bs = require('./src/bundles.js'); bs.forEach((b) => { console.log(b); })")"
if [ -z "$bundles" ]; then; echo "No bundles found!" >&2; exit 1; fi

rm -rf dist/; mkdir dist

for bundle in $bundles; do
	echo "Building '$bundle' bundle..."
	BUNDLE="$bundle" yarn vite build
done

Until this is supported internally I think the added complexity of an inline plugin is not worth it for us.


Fix ts-jest mocked deprecation warning

Checklist

[ ] I left no linting errors in my changes.
[ ] I tested my changes.
[n/a] I updated the documentation according to my changes.
[n/a] I added my change to the Changelog.

Description
Update the tests to move away from ts-jest's mocked utility function. As an added bonus, this refactoring also uncovered some (1) unused mocks and (2) redundant test setup hooks.

The ts-jest dependency cannot be removed here as it's still used to run tests.


Updated README.md: code examples for outline colorboxes now use correct function name

Thank you for the useful package!
I tried out the examples from the typst universe page (as of version 1.3.1) and got an unresolved import error for outlinebox.
This PR should fix this.

Closed? You don't want the README to match the actual code?

Whoops, was on my phone and somehow managed to make a mistake. Of course the readme should match the code. Thanks for noticing my oversight.

Oh, I see. That makes more sense.
Thank you!


Add "source" metadata field

Adding the Tangsa sample text in #25 reminded me that, at some point, someone's going to look at that and think "What is that text? Where did we get it from? Is it the UHDR or is it something else? Where do we report bugs in it?" And they might find the commit log and possibly trace it back to the PR (although I didn't put any notes in the commit log, just in the PR body), but it would be more robust if we could annotate the textproto files themselves with this kind of source information.
I suppose if we don't really need it as a field, we could just add comments.

We can have repeated string source and optional string note for both language and sample_text.
I’m not sure it would be useful to have more specific fields like masthead_source, poster_source, specimen_source.

I think it's probably easier just to add comments.


global: load ACCOUNTS_SESSION_REDIS_URL from enviroment

Issue: On mac when redis is run in a docker machine the host ip is the one of the virtual box vm, not localhost. The default value of ACCOUNTS_SESSION_REDIS_URL is hard coded (https://github.com/inveniosoftware/invenio-accounts/blob/434f56e5c10bf2f7f996d03880c43ff2e094a08b/invenio_accounts/config.py#L29). Thus docker cannot be used when running tests on a mac.
Solution: load ACCOUNTS_SESSION_REDIS_URL from environment if it is set. This solution is already used in invenio-search (https://github.com/inveniosoftware/invenio-search/blob/f19a3c743ad9d578d0840a416e7dd76e6fffca06/invenio_search/config.py#L58)

It is already implemented in Invenio-Base / Invenio-Config.
--
Thanks for the tip in Invenio-Search. I have created issue https://github.com/inveniosoftware/invenio-search/issues/51.


Add support for certificate validation in client

Thank you!
On 04/03/2016 10:49 AM, Nick Sullivan wrote:

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub
https://github.com/bifurcation/mint/issues/52


Failed to create Pod: couldn't get version/kind; json parse error: unexpected end of JSON input (\u003cempty\u003e)

Job failed due to:
Exit Code: -200
Exit Type: USER_FAILURE
Exit Reason:
Pod spec contains permanent error
Failed to create Pod: {"ErrStatus":{"metadata":{},"status":"Failure","message":"the object provided is unrecognized (must be of type Pod): couldn't get version/kind; json parse error: unexpected end of JSON input (\u003cempty\u003e)","reason":"BadRequest","code":400}}

However, the Pod body in http request is fine, so it seems like ApiServer or k8s client-go try to decode http body even if the underlay connection has been dropped.
So seems https://github.com/kubernetes/kubernetes/issues/51353 does not totally fix the issue.
Still need to confirm the root cause.
In the meanwhile, we can treat K8s BadRequest as unknown error instead of permanent (even if k8s code says API calls that return BadRequest can never succeed.), to mitigate this.

Resolved by https://github.com/microsoft/pai/pull/4860
The pod decoding error will always be treated as transient error so forever retry.


Improve core count detection

I drafted and tested this a few months for the RISC-V case (everything was getting concurrency:1) but since we're paying more attention to the AQA test jobs for RISC-V now I want to get this in so we can make use of the multicore machines that we have.
Ref: https://github.com/adoptium/temurin-build/issues/3591

Machine
With this fix
Result

sxa-unl1
No
concurrency:1

test-plct-1
Yes
concurrency:3

test-plct-3
Yes
concurrency:3

build-plct-0
No
?

test-plct-7
No
?

test-plct-6
Yes
concurrency:3

odroid-2
Yes
concurrency:1 (2Gb RAM)

odroid-2
No
concurrency:1 (2Gb RAM)

odroid-1
Yes
concurrency:1

docker-2004-armv7l-1
No
concurrency:4

docker-2004-armv7l-1
Yes
concurrency:81 [*]

aix72-2
Yes
concurrency:1

aix72-5
No
concurrency:1

win2022-1
No
concurrency:2

win2022-2
Yes
concurrency:3

[*] - This value of 81 suggests that the detection in a docker container is not working as it should and will need to be revised before this is merged, hence the draft status at present.

The latest commit in this PR fixes the core count detection for CGROUPS (It was using GB instead of MB) so now has the desired effect.
The run which tried to use concurrency:81 above is now using 4: https://ci.adoptium.net/job/Grinder/8344/consoleText
This is now ready for review.

RIght I believe it's working properly in all cases now , these runs are all with the new branch

Machine
Result

win2016-1
concurrency:2

odroid-2
concurrency:1

docker-armv7-3
concurrency:4

aix72-1
concurrency:1

win2022-1
concurrency:3

lm4a
concurrency:


Add ability to show arrow

First of all thank You for creating this project, it fills perfectly the gap in material 2.
I'd like to ask for restyling popover so it looks more like one used by google.

and below is current style:

As You can see arrow is missing.
Small border around popover and arrow would make it more clear.
I have one additional question: When using Google Maps we have 3 icons in top right corner. Clicking on each one opens popover in exact same place, only arrow position indicates what button is "attached" to that popover. Is same approach possible with Your component?

@mseemann I've fixed screenshot showing current version. Could You please update title to: "Add ability to show arrow". Thanks!

Recently I needed this too, and my solution was use a css arrow, this link can help you.
http://www.cssarrowplease.com/


Org-mode style collapsible headings

I like this idea. Will investigate sometime after #2.

Going to close this as out-of-scope for now. If there is a demand for it, the issue can be reopened. I don't plan on adding this in the near future, though if you would like to I'd happily accept a PR.


feat: add geo/types

node client libraries for LMFS need these types
see:
https://developers.google.com/maps/documentation/transportation-logistics/last-mile-fleet-solution/fleet-performance/fleet-engine/gapic_client#nodejs_typescript
Fixes #1222

We can close this @alexander-fenster

Thank you!


Create XML Storage for menu

An XML file will be used to store the menu of services that can be offered to guests.

PR merged.


no highlighting when multiple word like "ac" and "cc"

Describe the bug
In Contributor, when i try to highligh the word "accusam" with multiple word like "ac" "cc", we should have accusam but we have only accusam.
I tried with "Keyword" and "Array of keywords".

Hello @Daybayzayd,
If the word ac is highlighted, then it will be ignored for cc. Thus it is correct that it will only highlight ac. If I misunderstood your question, please explain it with a bit more details. Thanks.

Hello @julmot !
I understood in the library that "all the str writed by the user are highlighted in the text".
So normally, if i understand correctly,

when we write "ac", we should have "accusam"
when we write "cc", we should have "accusam"

But when we write "ac" AND "cc" we should normally have the third characters highlighted no ?
We should have "ac" and "cc" highlighted.
But actually, if a word is already highlighted (ac) the second word who have the half char in the first word isn't (cc)
For me, when we write "ac" and "cc" we should have :
accusam
AND
accusam
so, we combine it, and we have finally : accusam.
If i misunderstood the library, forgive me please ! :p

Because the "ac" is already marked, it won't include the "cc" because the act of being marked has added an element to the page. You'll need to use the option "Across elements" to highlight "acc".
If you want to highlight the entire word "accusam", then you'll need to switch the accuracy to "complementary"

Ok i understand.
Sorry for the disturbing, :/ i didn't see the option "accross the element".
I'll read with more attention the documentation in the future.
Thanks for your very good library.


Create linter baseline file for azure-sdk-tools.

Create linter baseline file for azure-sdk-tools. See parent issue for full details.
Parent Issue: azure/azure-sdk-tools#7122

This was added as part of this PR


Arena-allocate the ServerContext::CompletionOp

This should save an allocation per RPC in exchange for a ref/unref pair.

****************************************************************

libgrpc.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

****************************************************************

libgrpc++.so

     VM SIZE                                                                                FILE SIZE
 ++++++++++++++ GROWING                                                                              ++++++++++++++
  +4.9%    +219 src/cpp/server/server_context.cc                                                        +219  +4.9%
      [NEW]    +200 void std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >    +200  [NEW]
       +60%     +98 grpc::ServerContext::CompletionOp::FinalizeResult                                        +98   +60%
       +81%     +94 grpc::ServerContext::CompletionOp::Unref                                                 +94   +81%
       +17%     +32 grpc::ServerContext::BeginCompletionOp                                                   +32   +17%

 -+-+-+-+-+-+-+ MIXED                                                                                +-+-+-+-+-+-+-
  -0.0%      -3 [None]                                                                                +661  +0.0%

  +0.0%    +216 TOTAL                                                                                +880  +0.0%

[trickle] No significant performance differences

Objective-C binary sizes
*****************STATIC******************
  New size                      Old size
 1,997,274      Total (=)      1,997,274

 No significant differences in binary sizes

***************FRAMEWORKS****************
  New size                      Old size
11,021,700      Total (>)     11,021,699

 No significant differences in binary sizes

Failure on interop test is go/java so not related.

It looks like bm_diff is dead; @ncteisen what gives?

Addressed reviewer comments.

****************************************************************

libgrpc.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

****************************************************************

libgrpc++.so

     VM SIZE                                                                                FILE SIZE
 ++++++++++++++ GROWING                                                                              ++++++++++++++
  +4.9%    +219 src/cpp/server/server_context.cc                                                        +219  +4.9%
      [NEW]    +200 void std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >    +200  [NEW]
       +60%     +98 grpc::ServerContext::CompletionOp::FinalizeResult                                        +98   +60%
       +81%     +94 grpc::ServerContext::CompletionOp::Unref                                                 +94   +81%
       +17%     +32 grpc::ServerContext::BeginCompletionOp                                                   +32   +17%

 -+-+-+-+-+-+-+ MIXED                                                                                +-+-+-+-+-+-+-
  -0.0%      -3 [None]                                                                                +653  +0.0%

  +0.0%    +216 TOTAL                                                                                +872  +0.0%

Objective-C binary sizes
*****************STATIC******************
  New size                      Old size
 1,997,274      Total (=)      1,997,274

 No significant differences in binary sizes

***************FRAMEWORKS****************
  New size                      Old size
11,021,701      Total (>)     11,021,699

 No significant differences in binary sizes

Corrupt JSON data (indicates timeout or crash):
    bm_call_create.BM_IsolatedFilter_ClientChannelFilter_NoOp_.counters.new: 10
    bm_call_create.BM_IsolatedFilter_ClientChannelFilter_NoOp_.counters.old: 10

[microbenchmarks] No significant performance differences

Remaining interop failure is dart, not related.


Implement /dev/zero

We've created other device blocks. We have a test that uses /dev/zero so it would be nice to have regardless.

This should only take a few lines, I'm on it.

This should only take a few lines, I'm on it.


Use REST API to manage students

As a course manager, I need to manage the students participating in the course so that the student's participation in courses can be tracked.
Acceptance Criteria:
-I can manage the following information about a student:
--first name
--last name
--courses
-I can create a student
-I can view a student
-I can modify an existing student
-I can delete a student

Please add the link to the demo video


Imglib not building properly

Hi!
I just cloned your repo for dlib and was planning on using your fHOG feature extractor for a project I'm working on. Unfortunately the Imglab tool for creating the .xml files used in the extractor doesn't seem to build properly. This is what I've done so far:

Cloned your repo to C:\
Made a build folder inside at C:\dlib\
Run cmake .. -G "Visual Studio 14 2015 Win64" -DCMAKE_INSTALL_PREFIX=C:\dlib
Run cmake --build . --config Release --target install
And cmake --build . --config Debug --target install
Opened the Project.sln and build ALL_BUILD and INSTALL in both Debug and Release mode

I then went into the C:\dlib\tools\imglab folder but noticed that imglab had not been built. I then created a build folder in the imglab folder and repeated the process above by generating the imglab.sln project. I tried to build it's ALL_BUILD and INSTALL in both Debug and Release mode, but for some reason building INSTALL results in this error log:
Severity	Code	Description	Project	File	Line	Suppression State
Error	MSB3073	The command "setlocal
"C:\Program Files\CMake\bin\cmake.exe" -DBUILD_TYPE=Debug -P cmake_install.cmake
if %errorlevel% neq 0 goto :cmEnd
:cmEnd
endlocal & call :cmErrorLevel %errorlevel% & goto :cmDone
:cmErrorLevel
exit /b %1
:cmDone
if %errorlevel% neq 0 goto :VCEnd
:VCEnd" exited with code 1.	INSTALL	C:\Program Files (x86)\MSBuild\Microsoft.Cpp\v4.0\V140\Microsoft.CppCommon.targets	133

Do you know of any fixes for this? I really want to use dlib!

It's probably just telling you that you don't have write access to c:\program files.
Anyway, don't bother running the install target.  Just take the exe file and put it wherever you want and run it.

Well where is this exe file located? I can't seem to find any exe file in the Imglab folder.

The exe file is in the build folder you created.  In a subfolder called Release.  That's how visual studio works.  It has nothing to do with dlib.


validator复用问题修复

Coverage decreased (-0.07%) to 82.093% when pulling dc77075cb19e882ee8f4482e7c7c2d45136d176b on<PHONE_NUMBER>2:master into 4deac01486b5293a0dd240dd9f9ba7e96e6b0ef8 on neoremind:master.


server.connection() is not in current hapi

https://github.com/carbonrobot/hapi-lambda/blob/0c97fbecc3e6861c067fc7f945790ce309627174/index.js#L8
I'm a hapi n00b, but it appears the .connection() method isn't valid anymore.

Running under serverless (local), inside the docker container using only the example code:
START RequestId: c7d8a48f-4733-13d4-dafc-3c44f58945f7 Version: $LATEST
module initialization error: TypeError
at Object. (/var/task/node_modules/hapi-lambda/index.js:8:8)
at Module._compile (module.js:652:30)
at Object.Module._extensions..js (module.js:663:10)
at Module.load (module.js:565:32)
at tryModuleLoad (module.js:505:12)
at Function.Module._load (module.js:497:3)
at Module.require (module.js:596:17)
at require (internal/module.js:11:18)
at Object. (/var/task/lambda.js:16:20)
at Module._compile (module.js:652:30)
END RequestId: c7d8a48f-4733-13d4-dafc-3c44f58945f7

line 8 in hapi-lambda/index.js is:
server.connection(); // no connection details for lambda

NOTE: i've confirmed that if package.json includes
"hapi": "^16.6.3",
then this module seems to work, but it is not compatible with hapi 17+


punishment mode (horny mode)

mommy WILL threaten to punish you if your code won't compile

bruh

perhaps something like...
struct Responses {
    positive: Vec<Response>,
    negative: Vec<Response>,
}

struct Response {
    content: String,
    attributes: Vec<Attribute>
}

#[non_exhaustive]
enum Attribute {
    NSFW,
    Degrading
}

Blessed are those who wash their robes, so that they may have the right to the tree of life and that they may enter the city by the gates. Outside are the dogs and sorcerers and the sexually immoral and murderers and idolaters, and everyone who loves and practices falsehood
Revelation 22:14

this is getting out of control

this is getting out of control

@thedenisnikulin good.

any updates on this? this feature would really be super useful for me, so i was wondering, if anyone's working on this
i could probs also give it a look, but my exp with rust is kinda not much :))))
cheers

any updates on this? this feature would really be super useful for me, so i was wondering, if anyone's working on this i could probs also give it a look, but my exp with rust is kinda not much :)))) cheers

I would be happy to work on this if @Gankra is comfortable with it. I really would like to wait for the go ahead from her, though... and even then, I would wait for #13 to get merged.

Really looking towards this in the tech mommy landscape for 2023. Can it use blockchain and gpt3???

And yet indeed she is my sister; she is the daughter of my tech daddy, but not the daughter of my tech mommy; and she became my waifu.

I find this fragment of Genesis 20:12 deeply motivating towards my soul. It reminds me of this crate, and I think this is the real motive to implement a horny mode into cargo-mommy. Because it is what God wants us to do.

And yet indeed she is my sister; she is the daughter of my tech daddy, but not the daughter of my tech mommy; and she became my waifu.

I find this fragment of Genesis 20:12 deeply motivating towards my soul. It reminds me of this crate, and I think this is the real motive to implement a horny mode into cargo-mommy. Because it is what God wants us to do.

Sadly still waiting on @Gankra approval :(

@Gankra we really need you in this very moment.

When we needed her the most, she didn't return :(

FINE I WILL WRITE YOU SMUT

FINE I WILL WRITE YOU SMUT

It's a miracle!

shipped in 0.2.0, see README for docs

Omg, Christmas came early this year


[3.x] Fix random multithreaded crash that happens when setting the audio stream on a AudioStreamRandomPitch stream.

This was originally a pull request in master here: https://github.com/godotengine/godot/pull/55043
But the way audio is handled has changed and is no longer relevant to 4.x, so this is a 3.x specific fix for https://github.com/godotengine/godot/issues/54866

Thanks!


mWeb - Emoji - "eye_speech_bubble" emoji has a different look on mWeb

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Open ND on mWeb
Open any chat
Write a colon and "eye_speech_bubble" and end it with a colon and send it
Do step 2 and 3 on desktop and compare the emojis that show up on both

Expected Result:
The two emoji's should be the same
Actual Result:
The emoji on mWeb is different from the emoji on desktop or android. The emoji on mWeb is a double emoji
Workaround:
Can the user still use Expensify without this being fixed? Have you informed them of the workaround?
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android / native
[x] Android / Chrome
[ ] iOS / native
[ ] iOS / Safari
[ ] MacOS / Chrome / Safari
[ ] MacOS / Desktop

Version Number:  v1.3.55-4
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
https://github.com/Expensify/App/assets/115492554/4b20ef05-2b31-4e88-b334-75c64e6327bf
https://github.com/Expensify/App/assets/115492554/1b334579-fc2e-4bc3-b5b4-61421f954ef9
Expensify/Expensify Issue URL:
Issue reported by: @NathanMulugeta
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1691497957724559
View all open jobs on GitHub

This is not a bug ig
It's just different designs for different OS
https://emojipedia.org/eye-in-speech-bubble#designs

It is the same OS, Android.

Yes but its just their renderers are different which causes them to change

can you check sending the same emoji from web and try to see on the native app

Looks exactly the same
mWeb

Desktop app


solution for no of 1s

Please add the solution according to the pre-defined code in the Leetcode.

Update the solution as soon as possible, otherwise it will be closed tomorrow.


module.run not executing sometimes

I thought this issue was happen again.
I'm trying to load ngTable module into my App and i realized that sometime the module.run in ngTable module not executing (The template caching part) so it caused the template not found.
It's not happen regularly but sometimes when i try to refresh the current page. If i load the Dashboard page, the go to the page that using ngTable, it was fine. But if i try to refresh the current page that contains the ngTable module, it was failed sometimes.
Please see my pictures below with error and without error.
As you can see, the chunk files was loaded correctly.
Sorry i cant give you a jsfiddle because i dont know how to make it run with webpack.
The error:

The result it should be:

My route configuration

I'm using Angular 1.5.8, angular-ui-router 0.3.1, ocLazyLoad 1.0.9, Webpack 2.1.0-beta.21

I also have an issue similar to @daominhsangvn, but with Angular 1.6.0, angular-ui-router 0.3.2, ocLazyLoad 1.0.9, webpack 1.14.0 . It seems to me that rerun and reconfig works a bit incorrect with webpack(I've tried to use 1.0.4 but magic doesn't happen...)? And here - #89, @amaschas also has problems... We definitely believe in your soon fixes!)

i'm running into this as well


Implement Drawer

Implement the Drawer component
https://ant.design/components/drawer/

Hi supermacro,
I will try to implement the Drawer component in the next days. For now I'm starting from setup the route and some basic documentation into the showcase.
I'm new to Elm, i will start to work on it officially the next week, i want to say that in 15 minutes or less, i was able to understand the functions that you wrote, really impressive how clear is it.
Nice job!!

I believe a drawer is not a good first contribution, because you will need to solve two seperate problems first:

Shade - no matter how many drawers will be displayed, you only ever want to display at most one shade (a shade handles the darkening of the screen)
internal state - how do you want to handle internal state in Elm? There are two approaches: components and reusable views.

I suggest you do the collapse component  first and figure out a good way how to handle internal state. From there you can prototype a shade (which is essentially a global state). Once both are done, the drawer is just the combination of the two.
I've done a implementation of a drawer in orasund/elm-ui-widgets. The solution i went with was to have the shade be controlled by the layout widget. And any widget that wants to trigger a shade would need to be also included into the layout.
As this package has also got a layout widget, this same approach could also be done here.

Hey @effe-megna,
This is great that you're finding Elm approachable! I would say that I agree with @Orasund that this might not be a good first contribution as there are a lot of moving parts.
This might be a good first contribution if you knew Elm well already.
I would recommend one of two things:

Implement missing functionality on an existing components

https://elm-antd.netlify.app/components/button

Compare to: https://ant.design/components/button/

https://elm-antd.netlify.app/components/typography

Compare to: https://ant.design/components/typography/

OR

Find a simpler component to implement that doesn't have state, such as:

https://ant.design/components/divider/
https://ant.design/components/affix/
Lots of things under "Data Display" heading

Example: https://ant.design/components/empty/

HI,
thanks for reply, i've made a pull request with a basic Drawer component, let me know what you think #27 .
Meanwhile i accept the suggestion and move to some component that doesn't have state.


Fix warnings from backwards-loops

Changes backward-loops over lists* from this pattern:
int i;
size_t length_of_list = /* ... */;
for(i=length_of_list-1;i>=0;i--) {
...

to this:
size_t length_of_list = /* ... */;
for(size_t i = length_of_list; i-->0;) {
...

This form enables using an unsigned type for the loop index, which usually fixes a couple of sign conversion warnings.

* or at least those that currently trigger sign-conversion warnings in the for statement or in the loop body

Interesting, and good catch, thanks! Looking at this now; I was out for the past week so there is a bit to catch up on.


K ext: up-to-date the K extension for the V.1.0.0 ratified spec

This PR makes some small changes for K extended instruction set so that it is up-to-date with the ratified v.1.0.0 Scalar cryptography extension spec. Particularly, this PR changes the names of xperm.n -> xperm4 and xperm.b -> xperm8 instructions and remove an unsupported instruction packu. It also added the K extension support for the ibex target.

Not that support for individual targets will be removed in V3 of the framework riscof) and you should be prepared for that eventuality.

Thanks a lot for the note @allenjbaum! is it means the riscv-arch-test repo will be superseded by the riscof repo?
Actually, I am testing an implementation of the K extension for the ibex core. I found the riscv-arch-test (previously know riscv-compliance test) is useful and supports the K_unratified spec. It needs some small changes to up-to-date with the ratified spec sothat I can use to test my implementation. I though it would be good to update it here too.
I looks forward to using the riscof framework.

I will need an entry in the CHANGELOG.md file for a major-version update - 2.7.0.

I have done the update for rv63i_m too. And I added an entry in the CHANGELOG.md file for the update. It's ready for review.

The tests in the current arch-test repo are the same tests that riscof will
use; riscof is the framework, and that framework doesn't use a target
directory.
It does use a python plugin, and there are definitions of those for various
models (including Sail and Spike) in the repo.
On Thu, Dec 9, 2021 at 1:57 AM Thinh Pham @.***> wrote:

Thanks a lot for the note @allenjbaum https://github.com/allenjbaum! is
it means the riscv-arch-test repo will be superseded by the riscof repo?
Actually, I am testing an implementation of the K extension for the ibex
core. I found the riscv-arch-test (previously know riscv-compliance test)
is useful and supports the K_unratified spec. It needs some small changes
to up-to-date with the ratified spec sothat I can use to test my
implementation. I though it would be good to update it here too.
I looks forward to using the riscof framework.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/riscv-non-isa/riscv-arch-test/pull/225#issuecomment-989690581,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AHPXVJVDL2V6Y2U3K7F56BDUQB4PZANCNFSM5JUHL3IQ
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

This looks good to go. For both rv32 and rv64, it

renames the K_unratified directory files to be simply K
-updates the makefile to point at the new directory name
removes both .S and reference output for packu and packuw
renames xperm.b and .n mnemonics to be xperm.8 and .4 in the .S files
It also adds the K directory to IBEX target directory


Allow Disabling Displays

There are times where it is necessary to turn off a display. For example, on a VR headset, you do not want it acting as part of the desktop, so it is best to turn it off. It also seems to break certain parts of my main monitor's tiling while I have my HMD plugged in.
From what I could figure out, displays seem to be initialized in src/config/ConfigManager.ccp at around line 140. I assume a condition could be made to check if the monitor's resolution (in the config file) is 0x0, and then make a condition to not initialize it.

added in 4a966c945bc04982cde1f9ab8f84a67df928c3f1
use
monitor=name,disable


matching done but fails to load in linking gui

10:55 on 20.9 done on Yaqut dataset, linking with Tudela August:

Update the message from "a few minutes" to "up to an hour"

Fixed


Input dataset preparation

We need to find a way to prepare the input data from gridded climate model data (or reanalysis, other source) to the raven format.
1- Connect to processes from PAVICS-1 that can collect meteo data from a shapefile;
2- Download and process the data according to required dates and other parameters;
3- Write the NetCDF with the appropriate conventions including all variables required by RAVEN.

Some thoughts on that...
2- You don't need to cut out time periods from the data for RAVEN. It will read in only the data it requires. Let's say you can provide 1990-2019 data but only do a simulation for 2015.
3- RAVEN does not actually require a specific NetCDF format. I try to do all the implementations in RAVEN such that no pre-processing of the data is required. For example:

data are given in UTC and not local time: use :TimeShift option to shift to local time
data are given in wrong unit: use :LinearTransform that can help to convert, e.g., [m] to [mm] or [K] to [C]
if you receive gridded data (means 3d- lat, lon, time) you can provide a gridded weights file that specifies the contribution of each grid cell to each subunit (e.g., HRU) of RAVEN. You don't need to cut out any subdomain etc. You could technically use the sam (global) forcing dataset to run any watershed. The only thing you have to provide is the weights file. This is a GIS operation. James has written some R-scripts using a given NetCDF file and overlays it with the shape of each subunit and creates the weights file...

The point is that we ant to minimize the computationally expensive preprocessing of forcing datasets and just make RAVEN so flexible that it can handle all the cases that would have initially required a pre-processing.
So, if you have anything that RAVEN can't handle, I would be happy to make those implementations.

I see, and I agree that Raven can do those things, but we need to start with "fixed" rv? files and so I don't think we will be able to change them on the fly depending on the type of input dataset. I'd prefer if we have a given format for our datasets and conform to those. For the dates, yes that is true we can play with those in Raven, but lets say someone wants to do a climate change study on 2070-2010, then we should just extract those data and not the entire GCM run from 1850-2100 just because RAVEN can handle it. That was what I meant, maybe I was not clear :)
Maybe during the maintenance phase we can deploy efforts to generalize raven to a larger scope of models/parameters/hyperparameters, but for now I think we should try and keep things as simple as possible.

The issue with gridded data and weights is that for parallel basin processing, we need to provide the weights for each region. That seemed a little bit more complicated than passing just the column index (region_id).
But that's exactly the discussion we need to have now.

Yes indeed. I think that since our models are lumped, the meteo data will be vector format (single column of weight=1). We can calculate this outside of Raven. Then we can build a region_id x nTimesteps matrix as the NetCDF inputs, without having recourse to the weights.
If we get to distributed modelling, then I guess the only remaining option will be to have a 3D variable: region_id X nTimesteps x Weights...
Another option is to launch the parallel computing just upstream of the Raven Call. Check the NetCDF for number of dimensions. If nDim>2, then parallel computing starts and we launch 1 Raven call per basin. In that call we'd only pass the nTimesteps x Weights matrix to Raven, so Raven would only ever see single-catchment runs. But that might complicate things for the parallel computing aspect, i.e. now system calls might be inappropriate, or maybe we should use the PyWPS parallel implementations at that stage, or whatnot. Punching above my weight class here, so take with a chunk of salt.

The weight file would be provided for each basin. Just similar to the preprocessing you would need to do.
The weights basically convert whichever discretisation of the inputs to whichever discretisation of the model (HRUs, lumped, grid). It is exactly the operation you have to do when you convert the gridded data into a timeseries.
For cutting out periods of time from a full dataset: for my purposes I never want to cut out data because I would have to store the full dataset AND the cut-out dataset. I like that I can basically just use always the same dataset. This changes if you want to provide the users with the forcing data that were used.

Agree with Julie that temporal subsetting should be delegated to Raven. That's how it works at the moment.
For the gridded weights, the interface could accept for region_id a list of (flat_index, weight) that we could write in the rvt file. That might be less complicated than I thought.

I am not sure how the interface looks like that's why I can't really say anything on that. The grid weights file looks like this:
:GridWeights
   #
   # [# HRUs]
   :NumberHRUs       7
   :NumberGridCells  24
   #
   # [HRU ID] [Cell #] [w_kl]
   #     where w_kl is fraction of forcing for HRU k is from grid cell l=(i,j)
   #     and grid cell index l is derived by l = (i-1) * NC + j
   #     where i and j are the row and column of cell l respectively and
   #     NC is the total number of columns.
   #     Following contraint must be satisfied:
   #         sum(w_kl, {l=1,NC*NR}) = 1.0 for all HRUs k
   1     1    0.416533067501
   1    15    0.107722095454
   1    16    0.36656977053
   1    17    0.0383775214918
   1    19    0.00602985999575
   1    21    0.0647676850277
   2     0    0.102856848918
   2     1    0.0334505627711
   2     9    0.00180896483093
   2    13    0.0577007064953
   2    14    0.395953671258
   ...
:EndGridWeights

For the lumped models, you would have only one HRU ID. Let's say 6 grid cells of the forcings are contributing to the lumped basin, you will need to specify the grid cell number (1,15,16,17,19,21 in the example) and how much each grid cell contributes to the basin, e.g., 36% of the basin are covered by grid cell #16.
The documentation for all this is on page 158ff (here).

@huard OK your knowledge of Raven is better than mine so if you say it's feasible, let's do that. I just think we should try and keep things reasonably simple. If it's not too complicated and more future-proof, let's go with that.

Ideally we'd support netcdf files of both types (region, time) and (lat, lon, time). Will start working on it.
@julemai Would you have test inputs files and expected results that I could test with ?

Do the examples necessarily need to be for the Salmon River and for one of our four supported models? I have the test bench for the implementations I do in Raven but it is for another catchment and model (not GR4J, MOHYSE etc). Could work on getting you all for Salmon River but would take me a bit.

Salmon: no.
One of the supported models: ideally.
Is it a global model ? If yes, I can probably add it rapidly to our supported models.

Hm. Nope, it's a distributed version of GR4J for 20+ subcatchments of the York River. Not worth the effort I guess.
Could you get me a NetCDF (lat,lon,time) for the Salmon River? Optimally with the contribution of each grid cell to the domain of the watershed?! Otherwise I would make those values up.

Wait, I'll start with simply taking the existing Salmon file and making copies with two dimensions (region, time), and three dimensions (lat, lon, time), with zeros everywhere expect for lat_0 and lon_0. If that works, I'm confident more realistic files will work too.

@huard @Zeitsperre
Hi guys,
I was wondering if there is any news on this front? It seems that it should be possible by now to extract data from a dataset using a shapefile? I feel like this is the main blocker stopping us from demonstrating the software's capabilities to the outside world, as we have to tell users to build their own NetCDF, which in theory we should be able to do. I know there was a problem with FlyingPigeon, any news on that? Thanks

We've decommissionned the old FP and should be able to deploy the new version this week or the next.

@huard I think we can close this one based on the recent notebooks?

Let's merge the notebooks first and link the PR to this issue.

I think our notebooks for ERA5/NRCan/Canopex are robust enough now to close this issue


DRC handling is not thread-safe

The function impd_drc_read_uni_drc_gain() uses static variable pkt_loss_frm_cnt to count the number of lost packets and disable DRC if it reaches a certain time. Since it is still a global variable, several decoding threads sharing the same memory space may overwrite that value and cause DRC being disabled for another thread without a reason (or prevent it from being disabled with the counter being reset).
P.S. This seems to be the only instance where a static variable is used in the code and probably it should belong to a decoder context instead.

Yes, pkg_loss_frm_cnt should have been a decoder context variable.
In the present implementation there will not be a scenario where the value can be anything other than 0. We will clean this part of the code.
Thanks!


Should clouddrift adopt a shorthand cd?

import numpy as np
import xarray as xr
import clouddrift as cd

Through examples, we could guide the user on how to use clouddrift. One thing that we could show/recommend is to import the clouddrift as cd, like np, xr, or pd.
Has cd been claimed by any library? I'm not aware of it.
One advantage of this style is to provide a single, short import for clouddrift and a 2-letter namespace for users to not have to explicitly import stuff by name.

I like cd but isn't it interpreted by default as "change directory" by python? If you import clouddrift as cd, don't you loose the cd command?
We could import clouddrift as dr?

Good question. I never tried cd in Python before so I just did. It looks like it's not a Python built-in, but an IPython extension:
(venv) milan@hyperion:~/Work/clouddrift/clouddrift$ python
Python 3.9.5 (default, Nov 23 2021, 15:27:38)
[GCC 9.3.0] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> cd
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
NameError: name 'cd' is not defined
>>>
(venv) milan@hyperion:~/Work/clouddrift/clouddrift$ ipython
Python 3.9.5 (default, Nov 23 2021, 15:27:38)
Type 'copyright', 'credits' or 'license' for more information
IPython 8.10.0 -- An enhanced Interactive Python. Type '?' for help.

In [1]: cd
/home/milan

In [2]:

And even if it was, Python doesn't allow you to override built-in stuff like Fortran does.

(clouddrift) selipot@liverbird:clouddrift $ ipython
Python 3.10.9 | packaged by conda-forge | (main, Feb  2 2023, 20:24:27) [Clang 14.0.6 ]
Type 'copyright', 'credits' or 'license' for more information
IPython 8.10.0 -- An enhanced Interactive Python. Type '?' for help.

In [1]: pwd
Out[1]: '/Users/selipot/projects.git/clouddrift'

In [2]: cd tests
/Users/selipot/projects.git/clouddrift/tests

In [3]: import clouddrift as cd

In [4]: cd ..
  Cell In[4], line 1
    cd ..
        ^
SyntaxError: invalid syntax

In [5]: cd?
Type:        module
String form: <module 'clouddrift' from '/Users/selipot/opt/miniconda3/envs/clouddrift/lib/python3.10/site-packages/clouddrift/__init__.py'>
File:        ~/opt/miniconda3/envs/clouddrift/lib/python3.10/site-packages/clouddrift/__init__.py
Docstring:   <no docstring>

In [6]:

Looks good :+1:

Good? cd is a conflict in my typical environment.

By good, I meant your output looks as I expected it to look.
It's a valid argument against doing this if you want to keep IPython's cd (you can still do %cd ..).

So let's plan on using import clouddrift as dr?

Personally, I don't find it recognizable enough. I think longer shorthands become more recognizable, like cdr or cldr, but they have the obvious downsides. I'll keep thinking about this, but for the time being my preferences are:

cd
No shorthand
cdr
cldr
dr

definitively a no for me.
Not a good option as clouddrift is too long
😑
my favorite
😑

Thank you for bringing this issue!

@philippemiron What do you think about cldr or dr?

I guess cldr, but I'm good either way.

Actually I would vote either dr or cl, 4 letters is too long.

It should start with c and the second letter should ideally recall an accent in the name which is why cd would have been perfect but no way since it corresponds to change directory. cl is acceptable to me.

@selipot can you reconsider your use of cd? It's not a Python thing, and in IPython you could use %cd. Ultimately it's your call. I think it would be a shame to pass on cd which I agree is the perfect name. I also think cl is acceptable and my second choice. I did a very brief search and found no major packages that alias as cl.

I am not convinced! We have no other users to ask unfortunatelly

Ok, can we close this? I think cd as a shorthand is doable.

Let's keep it open just until we promote it in a prominent place, for example when I update this page:
https://cloud-drift.github.io/clouddrift/usage.html


Error message "Error: Not allowed" appears when clicks "Show all browsers"

Browser

Google chrome "56.0.2924.87 (64-bit)"

OS

OS X EL CAPITAN

When I click the "Show all browers" the error appears and can not do any actions after that

Silky smooth stop perform animation

This looks to be fixed. Thanks for reporting the issue.


Fix useradd on centos when manage_home is false.

On Centos 6.4/6.5/6.6/7.0 using this code block fails, provided that the
/tmp/foo directory doesn't exist.
user 'my_test' do
  supports :manage_home => false
  home '/tmp/foo/bar'
end

[2015-01-03T05:54:03+00:00] FATAL: Stacktrace dumped to /tmp/kitchen/cache/chef-stacktrace.out
Chef Client failed. 0 resources updated in 1.425418119 seconds
[2015-01-03T05:54:03+00:00] ERROR: user[my_test] (test::default line 1) had an error: Mixlib::ShellOut::ShellCommandFailed: Expected process to exit with [0], but received '12'
---- Begin output of ["useradd", "-d", "/tmp/foo/bar", "my_test"] ----
STDOUT:
STDERR: useradd: cannot create directory /tmp/foo/bar
---- End output of ["useradd", "-d", "/tmp/foo/bar", "my_test"] ----
Ran ["useradd", "-d", "/tmp/foo/bar", "my_test"] returned 12
[2015-01-03T05:54:04+00:00] FATAL: Chef::Exceptions::ChildConvergeError: Chef run process exited unsuccessfully (exit code 1)

This code runs properly on ubuntu/debian.
Adding the "-M" flag solves the problem.

Needs a spec as well

Hi @lamont-granquist,
noted, I will do this before the end of the week as time permit.

Hi @lamont-granquist,
Well, I dig into and it doesn't seem that easy.
First there has been a discussion here and a bug there.  It seems that the default behaviour is to not create the home dir but that has never worked on rhel platform.  So it would break existing code to add the "-M" code.
Then, regarding rspec.
First the only code that would change is this:
diff --git a/spec/functional/resource/user/useradd_spec.rb b/spec/functional/resource/user/useradd_spec.rb
index 6b962c1..9befe0c 100644
--- a/spec/functional/resource/user/useradd_spec.rb
+++ b/spec/functional/resource/user/useradd_spec.rb
@@ -226,15 +226,8 @@ describe Chef::Provider::User::Useradd, metadata do
           expect(pw_entry.home).to eq("/home/#{username}")
         end

-        if %w{rhel fedora}.include?(OHAI_SYSTEM["platform_family"])
-          # Inconsistent behavior. See: CHEF-2205
-          it "creates the home dir when not explicitly asked to on RHEL (XXX)" do
-            expect(File).to exist("/home/#{username}")
-          end
-        else
-          it "does not create the home dir without `manage_home'" do
-            expect(File).not_to exist("/home/#{username}")
-          end
+        it "does not create the home dir without `manage_home'" do
+          expect(File).not_to exist("/home/#{username}")
         end

The reason is that in useradd_based_user_provider.rb, the only case tested is when manage_home true.  So there is nothing to change there.  It would require a new block to test this case ... (unless I am mistaken).
So, is the default to be changed (CHEF-2205) and if so, should I add a new block to the rspec?

I have tried
user "foo" do
  home "/opt/foo"
  supports :manage_home => false
  uid 123
end

and
user "foo" do
  home "/opt/foo"
  manage_home false
  uid 123
end

but  /opt/foo is still created and populated by skeleton files due to this issue and that my /etc/login.defs contains CREATE_HOME yes
I would also like to have -M added for platform_family rhel.
Could either of the above constitute an opt-in for this new somewhat-breaking feature?
opts << "-M" if ['rhel','fedora'].include?(node['platform_family']) && managing_home? === false # as compared to a default value of nil

My use case: I am installing packages that create users for service applications. The user's home directory will be that application's directory. I want to create the user creating a user in Chef with a specific and consistant uid because the rpm package does not specify a uid. Examples include percona and splunk.

So looks like we'd have to set the default of manage_home to true on RHEL systems, and then in Chef 13.0 or whatever normalize the defaults across platforms.
I also tend to think that our default should be manage_home set to true based on the arguments that most of the time the principle of least surprise is that users get homedirs created (if we could flip the default when we have a system account that would be useful).

Should probably revive this, but it doesn't need to be limited to CentOS I would think. The flag should work on any Linux.

@lamont-granquist i assigned you this since you were talking about fixing up the other bits of the user provider

yeah we should still clean this up.

yeah i'm not sure i understand this code, since i think this doesn't work on either rhel or debian families.  its possible on rhel it raises a hard error but on debian it just does the wrong thing?
anyway i'm closing this in favor of #5122 -- if anyone discovers that there's still an issue here, a new issue should get opened (after the fix in #5122 is shipped which is like 12.14.x at this point)


feat: inertnal fix screenshot dom display bug

PR
PR Checklist
Please check if your PR fulfills the following requirements:

[x] The commit message follows our Commit Message Guidelines
[ ] Tests for the changes have been added (for bug fixes / features)
[x] Docs have been added / updated (for bug fixes / features)

PR Type
What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?

[ ] Yes
[] No

Other information

Summary by CodeRabbit

New Features

Introduced a new utility for converting images to Base64 format, enhancing image handling during screenshot processes.
Improved the screenshot functionality by simplifying image processing logic and handling fixed/sticky positioned elements more effectively.

Bug Fixes

Removed outdated image conversion logic that complicated the screenshot process.

Documentation

Updated documentation to reflect changes in image processing and screenshot functionalities.

@zzxming 需要解决下冲突哈

@zzxming 好像现在截图不准确了，不知道是不是和合入 #81 这个PR有关
https://opentiny.github.io/fluent-editor/docs/screenshot

@zzxming 好像现在截图不准确了，不知道是不是和合入 #81 这个PR有关 https://opentiny.github.io/fluent-editor/docs/screenshot

哪方面有错误，我这里看好像是正常


Allow for proper assertions in the Javascript part of the cirriculum

Is your feature request related to a problem? Please describe.
A lot of our code based challenges are written in a way where we have to directly compare the way the user code is written instead of the way it actually performs. It'd be nice to be able to directly check it like we do with the HTML set of challenges. I think I have something ready.
Describe the solution you'd like
We would need to evaluate user code and have the variables scoped in such a way that they're available to the test code. Additionally it must be written in a way that it does not open up FreeCodeCamp to any unnecessary security risks.
Describe alternatives you've considered
NodeJS's vm module is not compatible with the browser based architecture of the curriculum. I've checked multiple times. Given that eval seems like a fairly good option if it can be scoped. It seems ridiculous to keep using regex when they're the same language.
Additional context
No response

Okay I'd more discussion before I try adjusting my PR again. How are things currently accomplished?  Is there any way to evaluate the edit region with it?


Icons are too small

We can increase the size of these icons so the are easily visible

Please assign me this issue under gssoc21

Give it a try @garvitgupta13

I can do it if in any case @garvitgupta13 is not able to complete it.

Working on it, will be creating a PR by today


calculating gas for contract invocation

I'm trying to determine if there is an efficient way to calculate the gas requirements of a contract invocation that runs CheckWitness.
It is easy enough to calculate the actual gas requirement for this contract but becomes significantly more difficult as the contract complexity increases. For the sample contract below:
neo-gui test invocation: Gas Consumed: 1.244
If you comment out the CheckWitness if statement the invocation is correctly calculated at:
neo-gui test invocation: Gas Consumed: 11.054
        public static bool Main(string operation)
        {

            Storage.Put(Storage.CurrentContext, "key0", 1);
            if(!Runtime.CheckWitness(new byte[] { 187, 253, 4, 207, 138, 221, 236, 148, 199, 120, 122, 82, 106, 111, 132, 32, 83, 22, 121, 162 } ))
            {
                return false;
            }

            Storage.Put(Storage.CurrentContext, "key1", 1);
            Storage.Put(Storage.CurrentContext, "key2", 1);
            Storage.Put(Storage.CurrentContext, "key3", 1);
            Storage.Put(Storage.CurrentContext, "key4", 1);
            Storage.Put(Storage.CurrentContext, "key5", 1);
            Storage.Put(Storage.CurrentContext, "key6", 1);
            Storage.Put(Storage.CurrentContext, "key7", 1);
            Storage.Put(Storage.CurrentContext, "key8", 1);
            Storage.Put(Storage.CurrentContext, "key9", 1);
            Storage.Put(Storage.CurrentContext, "key10", 1);
            return true;
        }
    }

Hi @birmas , is this problem still troubling you?
When the gui invokes contract for test, it would not add the witnesses.
So in your contract ,"Runtime.CheckWitness" fails then the contract terminates with the wrong gas consume .

There is a PR in neo-cli that would allow us to have CheckWitness in RPC endpoints. I think this is a critical issue, however, we don't plan to add new features to neo 2.


added team variable

I have the requirement that we use a team in our company.
So i added another environment variable for that.

This is necessary because at the time being, it is not possible to create a ZEIT_API_TOKEN from a team. So the only way to deploy as a team is by using the --team option of the now-cli

@zpnk any chance this will make it into a release in the near future?


Release 0.3.0 plan

The Release itself

[x] Video showing piglet in one window and remote piggui in another
[x] Update readme text with new feature
[ ] Update version in Cargo.toml
[ ] Create a tag
[ ] Publish to crates.io
[ ] Test installing from crates.io and running - on:

[ ] mac
[ ] linux
[ ] pi

[ ] Create release in GitHub with release notes, add text and gifs done here

Communicating the Release

[ ] Mention in reddit for pi
[ ] Mention in reddit for rust
[ ] Mention in pi forums (pending approval by moderator)
[ ] Mention in iced discord showcase
[ ] Mention in rust-lang discord showcase
[ ] Mention in iroh discord
[ ] Send a PR to This Week in Rust, with a longer description this time
[ ] Send to this week in embedded rust
[ ] Let rppal author know
[ ] Create a new discussion topic

Video with Dialog: https://youtu.be/aToJ1aT7NeM
Video using CLI argument: https://youtu.be/zcEa_Oke014


[WIP] Model aggregation index out of range error

Pull Request Checklist:

[ ] Positive Test Case Written by Dev

[ ] Automated Testing

[ ] Sufficient User and Developer Documentation

[ ] Passing Jenkins Build

[ ] Peer Code review and approval

Positive Test Case

[Enter positive test case here]

METRIC
VALUE

NEW BUGS
0

NEW VULNERABILITIES
0

NEW CODE SMELLS
0

NEW DUPLICATED LINES DENSITY
0.0

NEW SECURITY HOTSPOTS
0

https://sonarqube.cuahsi-workstation.com:9000/dashboard?id=hydroshare-4358


Fruit being destroyed by something other than a player (such as tnt) causes a crash in coderfruit

There is a bug in coderfruit that causes a crash when anything explodes (or anything reduces fruit entity HP to 0). The following fix should be made:
-if coderfruit_disable_pickable then return end
+if coderfruit_disable_pickable or not puncher:get_inventory() then return end
+-- ^ if not puncher:get_inventory(), the fruit must have been hit by
+--   an explosion or other HP-reducing event other than a player punch.

moved to https://github.com/Poikilos/EnlivenMinetest/issues/617


Add ability to run tests on remote webdriver.

Resolve #1731, #1732

added parsing env vars like GECKODRIVER_REMOTE  for address of remote webdriver
removed parsing env vars like GECKODRIVER_CLIENT_ARGS
added parsing a file webdriver.json for configure browser's capabilities, like:

{
  "moz:firefoxOptions": {
    "prefs": {
      "media.navigator.streams.fake": true,
      "media.navigator.permission.disabled": true,
    },
    "args": []
  },
  "goog:chromeOptions": {
    "args": [
      "--use-fake-device-for-media-stream",
      "--use-fake-ui-for-media-stream"
    ]
  }
}

Thanks for this and sorry for the delay in reviewing! This is getting complicated enough that would you mind writing up a page in guide/* about all the various options to configure this? Also is the webdriver dependency here necessary, or could we perhaps continue to use raw json blobs using just serde?

You can use a raw JSON blob, as shown in the example - each browser will only process its own section of options.
Of course I will add a configuration description to this guaide.

Thanks! And I'm just thinking that the webdriver dependency isn't really buying us much since it's just a few structures, so would it be possible to remove the dependency on it? Additionally do you know if there's documentation for safari's supported options?

For Safari, unfortunately, did not find anything. Do you mean remove webdriver from here?

Ah ok, seems fine to start out with chrome/firefox in any case. And yeah by removing webdriver I mean the crate used as a dependency.

Looks great to me, thanks!


MTSRE-1571: Fix YAML document split breaks PEM certs

Summary
When loading YAML files, we did blindly split on ---, so if someone added a PEM encoded certificate that is using ------ add start/end, we where splitting the document...
This commit changes the behavior to only split if the --- is in it's own line and there are no preceding characters.
Change Type
Bug Fix
Check List Before Merging

[x] This PR passes all pre-commit hook validations.
[x] This PR is fully tested and regression tests are included.
[x] Relevant documentation has been updated.

Additional Information

/lgtm
Using a decoder would be nicer though but kube's yaml lib does not have one.

/approve


Please add citations to the papers for COLAMD

scipy includes COLAMD as a built-in function (used by SuperLU) but the relevant papers are missing from the documentation.
In particular:
    T. A. Davis, J. R. Gilbert, S. Larimore, E. Ng, Algorithm 836:  COLAMD,
    an approximate column minimum degree ordering algorithm, ACM Trans. on
    Mathematical Software, 30(3), 2004, pp. 377--380.
    https://doi.org/10.1145/1024074.1024080

    T. A. Davis, J. R. Gilbert, S. Larimore, E. Ng, A column approximate
    minimum degree ordering algorithm, ACM Trans. on Mathematical Software,
    30(3), 2004, pp. 353--376.
    https://doi.org/10.1145/1024074.1024079

If there are other codes used from SuiteSparse, please see this list for other papers to cite in the documentation:
https://github.com/DrTimothyAldenDavis/SuiteSparse#how-to-cite-the-suitesparse-meta-package-and-its-component-packages

Thank you for the reminder Tim, references are added to places that we hope to cover all. But please let us know if we missed any other usage with other library components too.

Thanks!  I also posted other issues for scikit-sparse and scikit-umfpack, which is where most of my packages are wrapped for scipy, from what I understand.

Hi @DrTimothyAldenDavis, @ilayn and @melissawm,
I'd like to contribute to this issue, and want to make sure that my work is correct. From my understanding, I would be replicating the documentation from this commit, but for any C or Python files from this search that include COLAMD with no citation (Example file which I think should be changed)
Please let me know if this approach is correct so I can begin moving forward with the issue.
Thanks

You don’t have to change cgssv.c.
On Tue, Apr 5, 2022 at 3:46 PM Tim Davis @.***>
wrote:

Yes, that commit is all you need. Just one cite is fine, in the place
where the colamd option to  linsolve is stated.
Thanks!
On Tue, Apr 5, 2022 at 3:12 PM Leo Sandler @.***>
wrote:

Hi @DrTimothyAldenDavis https://github.com/DrTimothyAldenDavis, @ilayn
https://github.com/ilayn and @melissawm https://github.com/melissawm,
I'd like to contribute to this issue, and want to make sure that my work
is correct. From my understanding, I would be replicating the documentation
from this commit
https://github.com/scipy/scipy/pull/15938/files/26773940bf968173a2fc7b96d96cff79c0c5eaf7,
but for any C or Python files from this search
https://github.com/scipy/scipy/search?q=COLAMD that include COLAMD
with no citation (Example file which I think should be changed
https://github.com/scipy/scipy/blob/8a64c938ddf1ae4c02a08d2c5e38daeb8d061d38/scipy/sparse/linalg/_dsolve/SuperLU/SRC/cgssv.c
)
Please let me know if this approach is correct so I can begin moving
forward with the issue.
Thanks
—
Reply to this email directly, view it on GitHub
https://github.com/scipy/scipy/issues/15936#issuecomment-1089281853,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AEYIIOLYMP5BR4AKLD35U7DVDSNDJANCNFSM5SQSYGZA
.
You are receiving this because you were mentioned.Message ID:
@.***>

--
Sent from Gmail Mobile

--
Sent from Gmail Mobile

@L-Sandler another place this reference can be added is parae.linalg.splu. Please follow the example set by gh-15938. Thanks for your interest!

Thanks for your responses @mdhaber and @DrTimothyAldenDavis.
@mdhaber is there any chance you can direct me to the correct location for sparse.linalg.splu as the one I've interpreted from your reply does not exist for me.
@DrTimothyAldenDavis is there any chance you can explain why no citation is necessary for cgssv.c although COLAMD is referenced on line 199? It would be helpful for discerning whether or not references should be added for any other that come up as I'm searching through SciPy.
I appreciate your help and am looking forward to hopefully solving this issue.

Thanks for all your help on this issue.  All that is really needed are
citations in the documentation, not in the various source codes (such as
SuperLU).  There's no need to cite colamd in superlu itself, just in the
user-facing documentation of scipy where the user is given the option to
use colamd.
The SuperLU papers themselves cite COLAMD, so SuperLU (by Sherry Li)
already cites COLAMD just fine.  That's already taken care of.
On Tue, Apr 5, 2022 at 5:38 PM Leo Sandler @.***> wrote:

Thanks for your responses @mdhaber https://github.com/mdhaber and
@DrTimothyAldenDavis https://github.com/DrTimothyAldenDavis.
@mdhaber https://github.com/mdhaber is there any chance you can direct
me to the correct location for sparse.linalg.splu as the one I've
interpreted from your reply
https://github.com/scipy/scipy/tree/main/scipy/sparse/linalg/splu does
not exist for me.
@DrTimothyAldenDavis https://github.com/DrTimothyAldenDavis is there
any chance you can explain why no citation is necessary for cgssv.c
although COLAMD is referenced on line 199
https://github.com/scipy/scipy/blob/8a64c938ddf1ae4c02a08d2c5e38daeb8d061d38/scipy/sparse/linalg/_dsolve/SuperLU/SRC/cgssv.c#L199?
It would be helpful for discerning whether or not references should be
added for any other that come up as I'm searching through SciPy.
I appreciate your help and am looking forward to hopefully solving this
issue.
—
Reply to this email directly, view it on GitHub
https://github.com/scipy/scipy/issues/15936#issuecomment-1089457459, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AEYIIOLT7MXRI4GGOMMIWOLVDS6IBANCNFSM5SQSYGZA
.
You are receiving this because you were mentioned.Message ID:
@.***>

From what I can tell after downloading scipy and doing a search, is that scipy proper includes only COLAMD.  All of my other codes are wrapped in scikit-sparse and scikit-umfpack.  See:
https://github.com/scikit-sparse/scikit-sparse/issues/75
https://github.com/scikit-umfpack/scikit-umfpack/issues/69
UMFPACK is not in scipy proper, but there is a mention of UMFPACK in this file in scipy:
https://github.com/scipy/scipy/blob/main/scipy/sparse/linalg/_dsolve/linsolve.py
I suppose a cite to an UMFPACK paper could be added there, unless the user is expected to look at the scikit-umfpack documentation for details (where UMFPACK should be cited).  I'm OK either way, however you prefer to cite the codes used in scipy.
Thanks again for your quick response!

@L-Sandler you can usually find where a function lives by clicking on the [source] link from the function's documentation. E.g. the documentation for splu is here and looks like:

Clicking source at the right takes you to the location of the documentation in scipy/sparse/linalg/_dsolve/linsolve.py.

Hi there. I've tried a variety of resources from the SciPy documentation, including the detailed guide for MacOS, to try and set my environment correctly but am unable to build without errors. I've taken multiple steps like reinstalling my command line tools and reinstalling conda without success. Can anyone suggest any next steps for me?
Apologies for the delay in resolving this issue as I'm still learning about open source development. Looking forward to moving past this and resolving the issue. Thank you for your patience.

That link is to the 1.8.1 documentation. There have been major updates to the build setup recently, so you might have better luck with the development version of the contributor guide.

 Just one cite is fine, in the place where
the colamd option to  linsolve is stated.
Thanks!
On Tue, Apr 5, 2022 at 3:12 PM Leo Sandler @.***> wrote:

Hi @DrTimothyAldenDavis https://github.com/DrTimothyAldenDavis, @ilayn
https://github.com/ilayn and @melissawm https://github.com/melissawm,
I'd like to contribute to this issue, and want to make sure that my work
is correct. From my understanding, I would be replicating the documentation
from this commit
https://github.com/scipy/scipy/pull/15938/files/26773940bf968173a2fc7b96d96cff79c0c5eaf7,
but for any C or Python files from this search
https://github.com/scipy/scipy/search?q=COLAMD that include COLAMD with
no citation (Example file which I think should be changed
https://github.com/scipy/scipy/blob/8a64c938ddf1ae4c02a08d2c5e38daeb8d061d38/scipy/sparse/linalg/_dsolve/SuperLU/SRC/cgssv.c
)
Please let me know if this approach is correct so I can begin moving
forward with the issue.
Thanks
—
Reply to this email directly, view it on GitHub
https://github.com/scipy/scipy/issues/15936#issuecomment-1089281853, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AEYIIOLYMP5BR4AKLD35U7DVDSNDJANCNFSM5SQSYGZA
.
You are receiving this because you were mentioned.Message ID:
@.***>

--
Sent from Gmail Mobile