Allow calling out to dxc for "pass through" and DXIL generation

The front can currently call out to fxc and glslang both for use as a "pass-through" compiler (bypassing the Slang compiler almost completely) and as a means to generate DX bytecode ("DXBC") and SPIR-V.
We should add support for calling out to the new HLSL compiler dxc as an HLSL-to-DXIL (and eventually HLSL-to-SPIR-V) compiler.
I would not advocate for putting dxc into our build anywhere, since CMake, LLVM, and clang make for a pretty heavy footprint on what is currently a lightweight project. Instead, we should follow a similar approach to what we do when interacting with d3dcompiler_47.dll for fxc, and assume that clients who want to use dxc will either ensure it is installed on end-user systems, or incorporate it into their build.

This feature is now something that Falcor wants, so it probably needs to be prioritized.

Implemented in #241.


Add support for IntelliJ cron tab feature

Hi and thank you for your PR :) is it ready for review?

yeah should be

I've checked the Cron Descriptor and looks like it have no any opportunity to configure tooltips for crons. Due to the different formats (in original cron it starts from minutes when krontab starts with seconds), it will be incompatible with krontab library.
If I missunderstood something, feel free to write it :) thank you for your PR anyway

I've checked the Cron Descriptor and looks like it have no any opportunity to configure tooltips for crons. Due to the different formats (in original cron it starts from minutes when krontab starts with seconds), it will be incompatible with krontab library.
If I missunderstood something, feel free to write it :) thank you for your PR anyway

I am talking about this official feature, so you need to use IntelliJ EAP to test this

I've checked the Cron Descriptor and looks like it have no any opportunity to configure tooltips for crons. Due to the different formats (in original cron it starts from minutes when krontab starts with seconds), it will be incompatible with krontab library.
If I missunderstood something, feel free to write it :) thank you for your PR anyway

I am talking about this official feature, so you need to use IntelliJ EAP to test this

Got it and will try asap :) thank you :)


Naive syndrome circuit refactor

@amicciche , thank you for taking care of this! I added a couple of minor changes, please check the comments and the last commit for explanation. I will merge this after the tests pass.


Error: Can't convert undefined to object

I'm taking this example and replace constructor initialization like this:
this.state = {
focusedInput: null,
startDate: moment(),
endDate: moment().add(5, "day"),
};
When I click to 'EndDate' input I receive  "TypeError: can't convert undefined to object"

<EMAIL_ADDRESS><EMAIL_ADDRESS>

Can you provide more of the stack trace?

Chrome:

Firefox:

@RodionNikolaev do you have any other props passed into your DateRangePicker?

This looks like the error is coming from moment's diff function.

@ljharb  I have tried to downgrade momentjs version.  Seems like this error occurs from<EMAIL_ADDRESS>until current version.

@RodionNikolaev can you make a test case that just uses moment, and not react-dates at all? If so we should file that on moment itself.

I can't repro though... shouldn't it happen for us as well?

I'm going to close this issue since we can't repo.


[otp_ctrl] Locally escalate upon a fatal alert/error

Previously, only the affected FSM went into a terminal error state upon
encountering a fatal alert.
This commit widens the scope of that local countermeasure, and moves all
partitions controllers and FSMs into a terminal error state if any of
them experienced a fatal error/alert.
This addresses https://github.com/lowRISC/opentitan/issues/5497#issuecomment-818292070
Signed-off-by: Michael Schaffner<EMAIL_ADDRESS>

i kind of wonder if most modules should end up adopting the approach of...
assign escalate_en = escalate_en_i | local_fatal_fault...

i kind of wonder if most modules should end up adopting the approach of...
assign escalate_en = escalate_en_i | local_fatal_fault...

Yeah it sort of makes sense to do that I think...

I will work on the private CI failure. looks like it need some changes on OTP and TOP_LEVEL tb.

Hey @msfschaffner, to pass the CI, would you mind excluding the check_timeout register from CSR write for all tests:
excl:CsrAllTests:CsrExclWrite
The reason is because this will trigger alert and internal escalation, but for now, the interface assertion could not distinguish if this alert is triggered by alert_test or real alert.

Hey Michael,
I would also want to double check the behavior of alert and status regarding this:
If a ECC NONE CORRECTABLE error occurred, this is what I see from the waveform: both fatal_macro_alert and fatal_check_alert triggered:
So it looks like whenever a fatal_macro_alert triggers, a fatal_check_alert will also happen. Is that expected?

Hey Michael,
I would also want to double check the behavior of alert and status regarding this:
If a ECC NONE CORRECTABLE error occurred, this is what I see from the waveform: both fatal_macro_alert and fatal_check_alert triggered:
So it looks like whenever a fatal_macro_alert triggers, a fatal_check_alert will also happen. Is that expected?

I think this is correct since it is a consequence of automatically moving all FSMs into the error state in case of a fatal error.


Memory Leak

avalonia 11.0.6
mapsui 4.1.2
windows 11
if write by control's member that can't be execute destructor function(like annotation). now i use "attach" to reduce the problem.
public sealed class ViewGroupMapSui : ViewGroupBase<ContentControl>
{
    public override bool IsFinishedConstruct { get; protected set; }
    public PropertyValued<Vector2d> Center => GetPropertyEntry<PropertyValued<Vector2d>>(nameof(Center));
    public override bool CanSelectMultiViewNodes => false;
    public override PositionOptions PositionOption => PositionOptions.CoordinateMap2d;
    public override Vector2d SpaceToScreenCoordinate(PositionWorld position)
    {
        var temp = _mapControl.Map.Navigator.Viewport.WorldToScreenXY(position.X, position.Y);
        return new Vector2d(temp.screenX, temp.screenY);
    }

    public override PositionWorld ScreenToSpaceCoordinate(Vector2d position)
    {
        var temp = _mapControl.Map.Navigator.Viewport.ScreenToWorldXY(position.X, position.Y);
        return new PositionWorld(temp.worldX, temp.worldY,0);
    }

    private  MapControl _mapControl;
    public ViewGroupMapSui(XElement dom = null) : base(dom)
    {
        // _mapControl = new MapControl();
        //
        // var map = new Map();
        //
        // //string urlTemplate = "https://t0.tianditu.gov.cn/img_w/wmts?SERVICE=WMTS&REQUEST=GetTile&VERSION=1.0.0&LAYER=img&STYLE=default&TILEMATRIXSET=w&FORMAT=tiles&TILEMATRIX={z}&TILEROW={y}&TILECOL={x}&tk=你的天地图密钥";
        // //string urlTemplate2 = "https://webrd01.is.autonavi.com/appmaptile?lang=zh_cn&size=1&scale=1&style=8&x={x}&y={y}&z={z}";
        // //var tileLayer2 = new TileLayer(new HttpTileSource(new GlobalSphericalMercator(),urlTemplate2));
        // //map.Layers.Add(tileLayer2);
        //
        //
        // var tileLayer = Mapsui.Tiling.OpenStreetMap.CreateTileLayer();
        // _mapControl.Map?.Layers.Add(tileLayer);
        // SelfContentView.Content = _mapControl;
        // // var customerLayer = new Layer();
        // // mapControl.Map?.Layers.Add(customerLayer);
        // // mapControl.Map.DataChanged += MapOnDataChanged;
        // _mapControl.Map.RefreshGraphicsRequest += MapOnRefreshGraphicsRequest;
        // _mapControl.Map.ViewportInitialized += MapOnViewportInitialized;
        // // _mapControl.Map.Navigator.CenterOn(new MPoint(104.06, 30.67));
        // //_mapControl.Map.Navigator.CenterOnAndZoomTo(new MPoint(104.06, 30.67),9);
        // //map.Home = navigator => navigator.CenterOn(104.06, 30.67);
        // Center.PropertyChanged += CenterOnPropertyChanged;
        IsFinishedConstruct = true;
    }

    protected override void OnAttachedToVisualTree(VisualTreeAttachmentEventArgs e)
    {
        base.OnAttachedToVisualTree(e);

        _mapControl = new MapControl();
        var tileLayer = Mapsui.Tiling.OpenStreetMap.CreateTileLayer();
        _mapControl.Map?.Layers.Add(tileLayer);
        SelfContentView.Content = _mapControl;
        _mapControl.Map.RefreshGraphicsRequest += MapOnRefreshGraphicsRequest;
        _mapControl.Map.ViewportInitialized += MapOnViewportInitialized;
        Center.PropertyChanged += CenterOnPropertyChanged;
        IsFinishedConstruct = true;
    }

    protected override void OnDetachedFromVisualTree(VisualTreeAttachmentEventArgs e)
    {
        SelfContentView.Content = null;
        _mapControl?.Dispose();
        _mapControl = null;
        base.OnDetachedFromVisualTree(e);
    }

    private void MapOnViewportInitialized(object sender, EventArgs e)
    {
        _mapControl.Map.Navigator.ZoomTo(5);
        _mapControl.Map.Navigator.CenterOn(new MPoint(104.06, 30.67));
    }

    void CenterOnPropertyChanged(object sender, PropertyChangedEventArgs e)
    {
        Trace.WriteLine($"CenterOnPropertyChanged : {e.PropertyName}");
    }

    private void MapOnRefreshGraphicsRequest(object sender, EventArgs e)
    {
        Dispatcher.UIThread.InvokeAsync(InvalidateChildren);
    }
}

What does the code do? Is this your solution? Or is this to demonstrate the memory leak? How does it show that there is a memory leak?

What does the code do? Is this your solution? Or is this to demonstrate the memory leak? How does it show that there is a memory leak?

—— can't be execute destructor function(like annotation). But if others or this one not contain the mapControl that can execute desctructor. so now i create mapControl on "OnAttachedToVisualTree" to reduce the problem.

What does the code do? Is this your solution? Or is this to demonstrate the memory leak? How does it show that there is a memory leak?

to simple test the problem like this:
class MapControlEx: MapControl
{
    public MapControlEx()
    {
        var tileLayer = Mapsui.Tiling.OpenStreetMap.CreateTileLayer();
        Map?.Layers.Add(tileLayer);
    }

    ~MapControlEx()
    {
        Dispose();
        Trace.WriteLine(GetType().FullName);
    }
}

class ControlEx : ContentControl
{
    ~ControlEx()
    {
        Trace.WriteLine(GetType().FullName);
    }
}

What does the code do? Is this your solution? Or is this to demonstrate the memory leak? How does it show that there is a memory leak?

guess other :
class MapControlEx : MapControl
{
public MapControlEx()
{
var tileLayer = Mapsui.Tiling.OpenStreetMap.CreateTileLayer();
Map?.Layers.Add(tileLayer);
}
~MapControlEx()
{
    Trace.WriteLine(GetType().FullName);
}

}
class ControlEx : ContentControl
{
~ControlEx()
{
Trace.WriteLine(GetType().FullName);
}
}

can't execute the "~MapControlEx()" too.

I created a memory leak test like we had for Xamarin.Forms and it is green https://github.com/Mapsui/Mapsui/pull/2678. I have to investigate your kind of testing next.

I looked into this a bit more. Not completely sure what exactly the problem is your struggling with. My guess is that you do not see an increase in memory use but you want to the finalizer to be called. The MapControl implements IDispose however and you should call Dispose() on it. In the MapControl.Dispose method we call GC.SuppressFinalize(this). So, I you want to cleanup something override the MapControl.Dispose().
Also I wonder if it is a good idea to inherit from the MapControl. Nowadays I am more inclined to make classes sealed because it is hard to correctly design for inheritance, and it is hard to implement a derived class because you have to guess how the parent class works.

I looked into this a bit more. Not completely sure what exactly the problem is your struggling with. My guess is that you do not see an increase in memory use but you want to the finalizer to be called. The MapControl implements IDispose however and you should call Dispose() on it. In the MapControl.Dispose method we call GC.SuppressFinalize(this). So, I you want to cleanup something override the MapControl.Dispose().
Also I wonder if it is a good idea to inherit from the MapControl. Nowadays I am more inclined to make classes sealed because it is hard to correctly design for inheritance, and it is hard to implement a derived class because you have to guess how the parent class works.

Pay attention to the test in the last screenshot. The use of inheritance here is only to simplify the proof that it has not been released by GC. During the usage process (starting from the constructor), I aimed to detect the release of static and dynamic resource management, and then discovered that the view tree could not be cleaned up. Then we investigated various controls and found that there was an issue with locating the map control. As it is an editor (with a history it maybe reuse), it has to be written to the "AttachViusalTree" event and set to null during “DettachVisualTree” so that the parent control can be released and the impact range can be reduced. I will continue to observe the impact of this issue in the future. Thank you for your reply.

If you can provide a minimal reproducible sample I will further investigate this.

If you can provide a minimal reproducible sample I will further investigate this.

public partial class MainWindow : Window
{
    class MapControlEx:MapControl
    {
        ~MapControlEx()
        {
            Console.WriteLine($"------  Destruct:{GetType().Name}");
        }
    }
    class ControlEx : ContentControl
    {
        ~ControlEx()
        {
            Console.WriteLine($"------  Destruct:{GetType().Name}");
        }
    }

    class ControlOnDisposeWithMap00:ContentControl,IDisposable
    {
        private MapControl _cMapControl;
        public ControlOnDisposeWithMap00()
        {
            Content = _cMapControl =  new MapControl();
        }

        ~ControlOnDisposeWithMap00() => Console.WriteLine($"------  Destruct:{GetType().Name}");

        private void Dispose(bool disposing)
        {
            if (disposing)
            {
                _cMapControl.Dispose();
                Content = _cMapControl = null;
            }
        }

        public void Dispose()
        {
            Dispose(true);
            GC.SuppressFinalize(this);
        }
    }
    class ControlWithMapDisposeOnDetach01 : ContentControl
    {
        private MapControl _cMapControl;
        public ControlWithMapDisposeOnDetach01()
        {
            Content = _cMapControl = new MapControl();
        }

        protected override void OnDetachedFromVisualTree(VisualTreeAttachmentEventArgs e)
        {
            base.OnDetachedFromVisualTree(e);
            _cMapControl?.Dispose();//new idea to test... it run to Destructor
        }

        ~ControlWithMapDisposeOnDetach01() => Console.WriteLine($"------  Destruct:{GetType().Name}");
    }

//Now my code like this one
class ControlWithMapCreateAttach02 : ContentControl
{
private MapControl _cMapControl;
        protected override void OnAttachedToVisualTree(VisualTreeAttachmentEventArgs e)
        {
            base.OnAttachedToVisualTree(e);
            Content = _cMapControl = new MapControl();
        }

        protected override void OnDetachedFromVisualTree(VisualTreeAttachmentEventArgs e)
        {
            base.OnDetachedFromVisualTree(e);
            var temp = _cMapControl;
            Content  = _cMapControl = null;
            temp?.Dispose();
        }

        ~ControlWithMapCreateAttach02() => Console.WriteLine($"------  Destruct:{GetType().Name}");
    }

    private Panel _cPanelRoot;
    public MainWindow()
    {
        InitializeComponent();
        Content = _cPanelRoot = new Panel();

        var timer = new DispatcherTimer(TimeSpan.FromSeconds(5), DispatcherPriority.Render, (sender, args) =>
        {
            var temp = _cPanelRoot.Children.OfType<IDisposable>().ToList();
            _cPanelRoot.Children.Clear();
            temp.ForEach(t => t.Dispose());

            _cPanelRoot.Children.AddRange(new Control[]
            {
                new MapControlEx(),
                new ControlEx(),
                new ControlOnDisposeWithMap00(),
                new ControlWithMapDisposeOnDetach01(),
                new ControlWithMapCreateAttach02(),
            });
            GC.Collect();
        });
    }
}

"ControlWithMapDisposeOnDetach01" —— It seems "MapControl" Dispose at first that can run a correct result.
"ControlWithMapDisposeOnDetach01" —— And It is reasonable to explain that there has been no memory leak。
"temp.ForEach(t => t.Dispose());" —— the logic is strange(In principle, i think all instances can execute destructors).
at last i changed the "temp.ForEach(t => t.Dispose());"

but result:

my logic is a bit confusing. Thank you for your enthusiastic help.

If you can provide a minimal reproducible sample I will further investigate this.
“ControlOnDisposeWithMap00”——my earliest implementation method
“ControlWithMapCreateAttach02”——current implementation method
“ControlOnDisposeWithMap01”——The way I just had a sudden idea to add(surprisingly, the result was correct.And It is reasonable to explain that there has been no memory leak)

app.zip


[DOC] Clarify vex output cannot be generated with update all

What kind of documentation improvement is needed?
None
What is the change that is needed?
Clarify Copa will not be able to provide any vex output with upgrade all approach since it doesn't have any info on CVEs associated with the package upgrades in https://project-copacetic.github.io/copacetic/website/output
Are you willing to submit PRs to contribute to documentation?

[ ] Yes, I am willing to implement it.

Hey @ashnamehrotra, I have gone through the codebase structure in this repo, and can improve documentation, can you assign me this documentation update/change issue, and tell or guide me what specific output will you like to add in output.md


[6.5.x] RHBPMS-4275: Guided Decision Table: XLS can not be validated

See https://issues.jboss.org/browse/RHBPMS-4275

Part of an ensemble:

https://github.com/droolsjbpm/guvnor/pull/365
https://github.com/droolsjbpm/kie-wb-common/pull/476
https://github.com/droolsjbpm/drools-wb/pull/298

@romartin Failure is due to https://github.com/uberfire/uberfire/pull/509#issuecomment-248337416
Looking into including a fix with this PR.

+1

+1


fix: accurately track allocatable resources for nodes

Fixes https://github.com/aws/karpenter-provider-aws/issues/5161
Description
The current method of assuming allocatable memory by simply discarding a percentage of usable memory using the VM_MEMORY_OVERHEAD_PERCENT global variable is suboptimal. There is no value that would avoid both over- and underestimating of memory allocatable.
Cluster-autoscaler addresses this issue by learning about the true allocatable memory from actual nodes and retaining that information. In this pull request, I'm applying the same concept.
In this pull request, I'm applying the same concept.
To demonstrate the issue:

Set VM_MEMORY_OVERHEAD_PERCENT to 0
Create a nodepool with a single instance type:

apiVersion: karpenter.sh/v1beta1
kind: NodePool
metadata:
  name: approaching-allocatable-nodepool-0
spec:
  limits:
    cpu: "18"
    memory: 36Gi
  template:
    metadata:
      labels:
        approaching-allocatable: nodepool-0
    spec:
      nodeClassRef:
        apiVersion: karpenter.k8s.aws/v1beta1
        kind: EC2NodeClass
        name: approaching-allocatable-nodeclass-0
      requirements:
      - key: node.kubernetes.io/instance-type
        operator: In
        values:
        - t4g.medium
      taints:
      - effect: NoExecute
        key:  approaching-allocatable
        value: "nodepool-0"
      kubelet:
        systemReserved:
          memory: "1Ki"
        kubeReserved:
          memory: "1Ki"
        evictionHard:
          memory.available: "1Ki"

Create a workload with request close to node's allocatable:

apiVersion: v1
kind: Pod
metadata:
  name: approaching-allocatable-pod
  namespace: default
spec:
  affinity:
    nodeAffinity:
      requiredDuringSchedulingIgnoredDuringExecution:
        nodeSelectorTerms:
        - matchExpressions:
          - key: approaching-allocatable
            operator: In
            values:
            - nodepool-0
  containers:
  - image: public.ecr.aws/eks-distro/kubernetes/pause@sha256:c2518f6d82392ba799d551398805aaa7af70548015263d962afe9710c0eaa1b2
    name: trigger-pod
    resources:
      requests:
        cpu: 10m
        memory: 3686Mi
  tolerations:
  - effect: NoExecute
    key: approaching-allocatable
    operator: Equal
    value: nodepool-0

Observed behaviors

Resolving Resource Overestimation:

v0.37.0 behavior: Karpenter continuously creates and consolidates nodes without realizing the impossibility of fitting the workload.
Patched behavior: Accurately tracks actual allocatable resources, preventing the endless loop of node creation and consolidation.

Addressing Resource Underestimation:

v0.37.0 behavior: Karpenter leaves pods pending indefinitely or chooses an instance type larger than necessary, failing to learn from actual node allocatables when launched for other reasons.
Patched behavior: Remembers true allocatable resources if a node is ever launched, enabling correct node launches for previously pending pods.

Avoiding Extra Churn:

v0.37.0 behavior: Incorrect predicted allocatable resources during consolidation lead to unnecessary churn.
Patched behavior: Scheduling simulations benefit from knowledge about true allocatable resources

The above improvements are implemented using a shared cache that can be accessed from:

lifecycle package: to populate the cache as soon as a node is registered.
scheduling package: to use real allocatable resources when making itFits decisions from the cache, if available.
hash package: to flush the cache for a nodepool after an update.

I tried to avoid introducing a global-like package, but placing the cache in any of the above packages (or others) introduces more coupling between those packages. If there is a definitive place for such a cache, please let me know.
How was this change tested?
For overestimation:
I ran this in one of our preprod EKS cluster with vmMemoryOverheadPercent=0, and it correctly stops re-launching the nodes of a given nodepool-instancetype combination after the first attempt fails. It also uses the correct allocatable memory for scheduling.
For underestimation:
The test was to

set high VM_MEMORY_OVERHEAD_PERCENT value (like 0.2)
Run the workload that was fitting before, observe it's pending
Adding another workload for same nodepool, but with lower request. That launches the real node
Another node would launch for the pod from step 2, and new pods with same requests are now correctly cause new node to be launched

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

33 of 36 (91.67%)  changed or added relevant lines in 5 files are covered.
2 unchanged lines in 1 file lost coverage.
Overall coverage increased (+0.04%) to 78.179%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

pkg/controllers/nodepool/hash/controller.go
2
5
40.0%

Files with Coverage Reduction
New Missed Lines
%

pkg/controllers/node/termination/controller.go
2
62.4%

Totals

Change from base Build<PHONE_NUMBER>:
0.04%

Covered Lines:
8835

Relevant Lines:
11301

💛  - Coveralls

Thanks @BEvgeniyS, very cool!

Given that kubelet section is moved to the nodeclass, it would probably make sense to move this logic to the cloudprovider?
Seems like Kwok provider doesn't have this issue (and it's not obviously how one can replicate it), this could be cloud provider-specific issue

Updated PR with dependency injection
@ellistarn @tallaxes @jackfrancis
Any chance you can take a look?

@ellistarn Can we remove stale label from this pr?

Since we've been running this as our fork in prod, we have discovered that allocatable memory and ephemeral storage may fluctuate due to kernel reservations (confirmed through comparing dmesg outputs, difference in single digit Ki between different instances)
That has caused unnecessary cache updates
I've changed the pr to not update the cache from every new node, but just reuse the cached information until cache is cleared
https://github.com/kubernetes-sigs/karpenter/pull/1420/commits/c818941d8e545586cafc6a84240e6de305525324

Closing in favor of https://github.com/aws/karpenter-provider-aws/pull/7004
Thanks @jmdeal!


Support file streams for attachments

Currently the SDK only supports direct local file references; files by name. It would be really nice if you could read a file from wherever you want and upload it to 4me, so thats why we need to support file streams.

@Gustav16, I already did some tests to support streaming as well. The code is in the latest commit, and I will release a new NuGet this evening. One important thing is that the stream should support seeking as it needs to determine the file size during upload.
For example, the HttpClient.GetStreamAsync() will not work, and HttpResponseMessage.Content.ReadAsStreamAsync() does work.
using (HttpResponseMessage responseMessage = await httpClient.GetAsync("https://example.com/file.pdf"))
{
	using (Stream stream = await responseMessage.Content.ReadAsStreamAsync())
	{
		AttachmentUploadResponse response = await client.UploadAttachment(stream, "file.pdf", "application/pdf");
	}
}

@Gustav16, NuGet 1.0.7 is published. You can now use a stream instead of files by name.


GRUB error 13 (invalid elf format) when code size exceeds 0x1000 bytes

make && objdump -x kernel.elf
Check .text section. If file offset of .text is over 0x2000, executable is considered invalid.

hexdump kernel.elf | grep 'b002 1bad'

Magic bit of multiboot is not within the first 8KiB

Fixed in commit:
https://github.com/sandwichdoge/Little-OS/commit/44aa72d5e306c05c42c1e80671b5c0493f42affe


🧪 [experiment] Saving build time

Will look into other ways to cache or speed up the build before looking into something like this.  Appreciate the idea though.


Add a mutable version of attr

For a project I need to modify an url of a href. Maybe we could add a version of attr which return a mutable variable on the content of the HashMap

Not possible — attrs are deep in an immutable API. I think HTML modification is outside the scope of this crate.


add dlp to includes

This was missed when merging in DLP earlier and is required for content to show up in the nav bar on the doc site. I manually pushed the updates to the doc site, but we will want this for the future when generating new releases.

Sorry, belated LGTM, thanks for fixing this!


Messages are not announced to screen reader

open F1
select Debug: Continue
message appears that saying I am not debugging but explorer has focus, message isn't read

@jrieken using voiceover or nvda?

voiceover


ParticleContainer docs not up to date

It seems that since version 4.5.6 it is possible to add tint so individual sprites in a particle container. However, the docs states this is not possible. Perhaps this should be updated?

4.5.6 official example
4.5.5 official example

Would welcome a PR to fix the ParticleContainer header and be more explicit about tint working since 4.5.6.

Ok, I have done so at #4465. Please bear in mind this is my first PR to PixiJS and I hope it's what you were expecting :)

Merged. Thanks again.


Add hyperlink to N|Solid logo

Added hyperlink to N|Solid page on N|Solid logo in README.md

Closing: In https://github.com/nodesource/nsolid-kubernetes/pull/25


go-mod: remove unecessary go module helper scripts

Scripts under contrib/go-mod don't provide any value to Cilium
repository as the dependencies are properly managed by go modules.
This commit removed all requires that are not necessary and left only
the needed requires. After removing non-essential requires go mod tidy && go mod vendor were executed to re-create the vendor directory with the
indirect dependencies resolved.
Signed-off-by: André Martins<EMAIL_ADDRESS>

This change is

test-me-please

test-me-please

test-missed-k8s

test-docs-please

test-me-please

Coverage increased (+0.01%) to 45.538% when pulling 0d5a193f262e8e63bc602bb4ded428d6dfd58f2e on pr/remove-useless-requires into d8443c543abec9c58e81dfa355d19de790021dea on master.

test-me-please

@aanm These changes look confusing, any idea why they were triggered here?
go.mod:
-	github.com/miekg/dns v1.1.4
+	github.com/miekg/dns v1.0.14
...
 	github.com/miekg/dns => github.com/cilium/dns v1.1.4-0.20190417235132-8e25ec9a0ff3

vendor\modules.txt:
-# github.com/miekg/dns v1.1.4 => github.com/cilium/dns v1.1.4-0.20190417235132-8e25ec9a0ff3
+# github.com/miekg/dns v1.0.14 => github.com/cilium/dns v1.1.4-0.20190417235132-8e25ec9a0ff3

One more note: I kind of liked the instructions on top of go.mod, could we have them back (updated to work without the scripts, of cause)?

@aanm These changes look confusing, any idea why they were triggered here?
go.mod:
-	github.com/miekg/dns v1.1.4
+	github.com/miekg/dns v1.0.14
...
 	github.com/miekg/dns => github.com/cilium/dns v1.1.4-0.20190417235132-8e25ec9a0ff3

vendor/modules.txt:
-# github.com/miekg/dns v1.1.4 => github.com/cilium/dns v1.1.4-0.20190417235132-8e25ec9a0ff3
+# github.com/miekg/dns v1.0.14 => github.com/cilium/dns v1.1.4-0.20190417235132-8e25ec9a0ff3

@jrajahalme the miekg/dns was updated to that version because that's the minimal version of miekg/dns the direct dependencies require. For that particular dependency it does not matter because we are overwriting it with whichever version we have in github.com/cilium/dns

One more note: I kind of liked the instructions on top of go.mod, could we have them back (updated to work without the scripts, of cause)?

there are no more scripts. The instructions were updated in the dev documentation https://docs.cilium.io/en/latest/contributing/development/dev_setup/#add-update-a-golang-dependency
TLDR to add/update a new dependency one simply needs to do:
$ go get<EMAIL_ADDRESS>$ go mod tidy
$ go mod vendor
$ git add go.mod go.sum vendor/


HSEARCH-4616 Rename automatic indexing to something more explicit

https://hibernate.atlassian.net/browse/HSEARCH-4616
This is the first pass at this renaming:

deprecated the hibernate.search.automatic_indexing.enabled
looked where we used automatic indexing and either replaced it or rephrased it to something else.
there're a few TODO: Yoann, .*  with some questions 😃. I'd say that it probably wouldn't make sense to go through all the changes before I address those todos.

Hopefully, this wouldn't be too much "fun" rebasing once we merge the getting-started PR 😆

Ok, so now I think we are mostly left with some tests/packages that still refer to "automatic indexing", and I'm not sure if we should try to change those or not ... 😃

Ok, so now I think we are mostly left with some tests/packages that still refer to "automatic indexing", and I'm not sure if we should try to change those or not ...

I'd usually say yes, but here if those are public, well, we can't, and if they're tests it'll be a pain to rebase the ORM 6 patches on top of the renamings so... let's not :)

Merged, thanks!


Init command in toml file doesn’t create certain configuration options by default.

Describe the bug
Init command in toml file doesn’t create certain configuration options by default.
tkltest-unit config init --file tkltest_config.toml
Environment information
CLI version - tackle-test-generator-cli-v2.0.0-all-deps.zip

OS: [Windows]

Additional context
Was following the quick start guide https://github.com/konveyor/tackle-test-generator-cli/blob/main/doc/unit/quick_start_guide.md
And could not find app_build_type in the generated toml file.
init command should be updated to include this by default.

Fixed and merged via PR: https://github.com/konveyor/tackle-test-generator-cli/pull/228


Add Number with Unit Entity Recognizer in English, Spanish and Chinese

@ejadib,
Thanks for having already signed the Contribution License Agreement. Your agreement was validated by Microsoft. We will now review your pull request.
Thanks,
Microsoft Pull Request Bot


Typos in /Faker/Provider/ru_RU/Person.php and tests/Faker/Provider/ru_RU/PersonTest.php

The function lastName() is incorrrect. You use latin 'a' in 172 string instead of cyrillic 'а'.
So these female last names don't pass my validation, where all symbols should be cyrillic.
There is the same toruble in PersonTest.php
I've made a pull request https://github.com/fzaninotto/Faker/pull/1901.
But it doesn't pass your tests (some troubles with environment?).

Same

Closed with #2045.


fix: contribution operator and refactor unittest

SUMMARY

This PR decouple post-processing unit test and move it from the integration_test to the unit_tests. In order to make life easy, replace class test cases with functional test cases.
fix: when NaN value in contribution operator can't calculate.
add unit test to guarantee nan value in contribution.

closes: https://github.com/apache/superset/issues/18774
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

After

Before

TESTING INSTRUCTIONS

Select birth_name as datasource
Select Line Chart on explore page. notice that, use echart version of Line Chart
Drag ds in x-axis
Select sum(num_boys) in metrics
Drag name in group by
Select total in contribution mode
You can look at a line chart as before screenshort.

ADDITIONAL INFORMATION

[x] Has associated issue: https://github.com/apache/superset/issues/18774
[ ] Required feature flags:
[ ] Changes UI
[ ] Includes DB Migration (follow approval process in SIP-59)

[ ] Migration is atomic, supports rollback & is backwards-compatible
[ ] Confirm DB migration upgrade and downgrade tested
[ ] Runtime estimates and downtime expectations provided

[ ] Introduces new feature or API
[ ] Removes existing feature or API

Love the change to proper unit tests! One question about the change in the contribution operator - should we potentially split this PR in two - the first for the refactor, and the second for the functional change once the refactor has been merged?

it's my bad. I'm gonna split it to 2 PR.


'required' prop on select & multiselect not working

Hi there, I would like my Multiselect and Select option to be mandatory, I see that there's 'required' prop option to realize this. However, after I add the prop, it doesn't seem to have any effect on the multiselect. Any idea how I can solve this? thank you.
dmc.MultiSelect(                     id="baseline-supervised-pipelines-select",                     searchable=True,                     clearable=True,                     required=True,                     withAsterisk=True,                     nothingFound="No pipelines found.",                     placeholder="Select pipelines to run.",                     **PERSISTENCE_PROPS_SESSION,                 )

In terms of what users will see, required component only shows an asterisk against the label.

If you don't want to show label in your select, you can use the 'error' attribute with a custom client side callback.
Here's one example (though the callback is server side here):
https://www.dash-mantine-components.com/components/multiselect#invalid-state-and-error


Streams Listing Pages changes after visting stream detail view

Opening a ticket so we do not forget
On epcr, the stream listing goes kinda out of order when you enter the detail page. Check the video below, I go into the detail of the "stream 01...." and when I go back to the listing view, "stream 01...." in the middle of the page. Let me know if you cannot access the video below.
https://drive.google.com/file/d/1ZyQPbUKc7AD--cKSRyOGNJwdVaFt96Wt/view?usp=sharing

Deployed a fix for this to prod dev

Looks good on prod dev.  I can verify that I am not able to reproduce the issue there.


feat(metrics-operator): add helm chart for metrics operator

closes #2181

I believe also release-please conf needs to be updated to track the value file

we discussed having all pipeline changes done in a single ticket, @thisthat do you think that is not a good idea? 🤔

I believe also release-please conf needs to be updated to track the value file

we discussed having all pipeline changes done in a single ticket, @thisthat do you think that is not a good idea? 🤔

sorry, I miss that discussion. I am fine doing that in a single PR :)

Please remove this file helm/chart/rendered.yaml


use copy_op directly insteadof write_scalar

related: https://github.com/rust-lang/rust/issues/58645

Thank you the review. I will think and fix it.

Maybe I fixed it.

Oops. Sorry. I changed it back before and add test for 'normal' load.

Thanks a lot!


looks like prunings back on the menu

add prune tag and prune them all

grug happier, still more clubbable
need to pc grug the rest

woops


bower update  dont work

there are case in which it dont work correctly
package is A
my case:
A version 1.0.0 in git and bower pointing at git repo directly
in git i remove 1.0.0 tag  change code and then i add again
i go to a project using A as dependency
i executed bower update A
the code remains the old code.
I tried also removing cache. same problem.
For solving the problem i removed it
with bower uninstall A
and bower install A
now code is correct

I think you have a wrong idea about "bower update".
When you run this command, it only updates your modules if there's a newer version available.
In your example you install 1.0.0, modify it check for updates, but the newest version is still 1.0.0, so no files are changed on your machine, unless you reinstall the package.

yes, that's the expected behavior AFAIK, even though there are some issues with bower update. @publicocean0 it works as you expect with bower --force update


Stark P1 spectroscopy experiment

Summary
This PR adds StarkP1Spectroscopy experiment and a dedicated analysis. User can set amplitudes to scan to run this experiment, and the analysis class can convert the amplitudes into frequencies if Stark coefficients are provided. These coefficients can be calibrated with StarkRamseyXYAmpScan experiment introduced in #1009 .
Details and comments
The test experiment result is available in 6799e7ae-414f-4816-b887-b4c3ba498624. This experiment result was obtained with the following experiment code:
from qiskit_experiments.library import StarkP1Spectroscopy

exp = StarkP1Spectroscopy((0, ), backend)
exp_data = exp.run().block_for_results()

The Stark coefficients can be directly set in the analysis options. By the default setting, the analysis class searches for the coefficients in the experiment service. If analysis results for all coefficients are found (i.e. previously saved in the service), it automatically converts the amplitudes into frequencies for visualization.
A public class method StarkP1SpectAnalysis.retrieve_coefficients_from_service is also offered so that a user can set a coefficients dictionary in advance. This is convenient when the experiment instance is run repeatedly, because retrieving analysis data from the service causes a communication overhead. For example,
from qiskit_experiments.library.characterization.analysis import StarkP1SpectAnalysis

# overhead happens only once
coeffs = StarkP1SpectAnalysis.retrieve_coefficients_from_service(
    service=service,
    qubit=0,
    backend=backend.name,
)
exp.analysis.set_options(stark_coefficients=coeffs)

for _ in range(10):
    exp_data = exp.run().block_for_result()
    exp_data.save()

User can make a subclass of this analysis class StarkP1SpectAnalysis to perform custom analysis. This built-in class doesn't perform any analysis except for visualization. Instead, this class provides a convenient hook ._run_spect_analysis that takes (x, y, y_err) data and returns a list of AnalysisResultData.

In my opinion it's better to separate files from T1.

I started to categorize experiments with the type of technologies. StarkRamsyXY and StarkRamseyXYAmpScan experiment are both implemented in qiskit_experiments.library.characterization.ramsey_xy with RasmeyXY which is without Stark tone. This is basically a variant of inversion recovery experiment with Stark tone and fixed delay, and I added this experiment to existing t1 module.

@coruscating started to add minimum examples to documentation of all the experiments, I guess it means that new experiments should come equipped with an example.

I was thinking of this, but this experiment requires full dynamics simulation with calibrated pulses. This needs too lengthy code to fit in with the API doc.

For the case of amplitude x-values, the figure x-axis should be quadratically scaled, after https://github.com/Qiskit-Extensions/qiskit-experiments/pull/1215 is merged (this is not blocking this PR from merging, this can be done later).

This is good suggestion. I can update after the PR is merged (or I can do this in this PR).

The xscale option is added in 846ca09. By default the output would look like below.

The xscale falls back into linear when Stark coefficients are provided.


analyzer: Fix expected results for StackTest

This change is

I believe we need (something like) https://github.com/heremaps/oss-review-toolkit/pull/1556 first.

Abandoned in favor of https://github.com/heremaps/oss-review-toolkit/pull/1556.


feat: Tracking Liquid Level of Labware

Overview
Track liquid level in various containers so pipettes are not submerged in liquid.
Implementation details
We’ve got a problem with the most recent version of the robot. We used to assign additional properties to our labware which doesn’t work anymore (https://github.com/Opentrons/opentrons/issues/7048). Before we go through the very laborious process to rewrite all our protocols, I thought it might be worth describing our intentions to add these additional properties in the first place and maybe you have a much better idea to address the problem.
The main problem is that we need to track liquid levels in the various containers. E.g. we need to know how full a 15 mL falcon tube is. Otherwise the robot will always go straight to the bottom. If the falcon is full however, this leads to the whole pipette being submerged and also the pipette spilling the contents all over the robot. It is also not possible to tell the robot to always go to the top since the liquid level drops over the course of the protocol and at some point it couldn’t aspirate anymore because the tip wouldn’t reach the liquid. That’s why we implemented a dynamic liquid tracking and height calculation to tell the robot always the correct height to aspirate and dispense. To achieve that we assigned additional properties to all the labware. And as mentioned before, this does not work anymore.
My question is now, is there anything in the most recent API that could help us solve this problem? E.g. is there a liquid level tracking function or something similar implemented?
Acceptance criteria
Robot tracks liquid levels of all containers (i.e. Falcon tubes, Eppendorf tubes etc.). According to this liquid level, pipettes are moving always just underneath the surface of the liquid to aspirate and don't move completely down.

Thanks for the feature request @MarcMarc94! This is something that's been on our minds for a long time, but is prohibitively difficult in the current protocol running architecture. Work on a replacement architecture, called the Protocol Engine has started, but is still in its very early stages.
Depending on which liquid handling methods you are using, with various wrapper functions you might be able to implement the same sort of functionality in user-land before the functionality lands in the core. The broad stokes of how liquid level tracking could/would work in the new architecture:

The Protocol Engine maintains a dict mapping amount of liquid in each well by reference
The Protocol API has functionality added to allow the initial liquid state of a given labware to be specified to populate that mapping at the beginning of the protocol
Aspirates, dispenses, etc. result in updates to the liquid map
Helper functions exist to calculate the liquid top:

Given labware / well reference
Pull well geometry from the labware defintion
Pull liquid amount from the liquid map
Calculate a liquid height estimate based on well shape (circular or rectangular) and 2D dimensions

TL;DR: This is an important feature that we feel technically blocked on, so we're working on revamping our protocol running core to unblock this feature. Once it's unblocked, we'll be able to prioritize / estimate actually building it. Until then, given the complexity of your protocols, this may be something you can implement yourself

#Hello - I have implemented a simple version of this in my protocols using the following functions:
#This function roughly estimates height of water column in 2ml tubes so that tip can be lowered as water level drops.
#This also helps keep the robot from dunking the tip, which reduces chance of unwanted carryover
#Height = volume ul / pi * radius^2
#Note that the equation for V-bottom PCR tubes could be better, but I didn't have time to find an equation with better fit.
import math
res_vol = 1000
#Below function tracks water volume it 2ml snap-cap tubes initial volume must be specified volume must be updated with each pipette aspiration.
def res_tip_height(res_vol):
height = (res_vol/(3.14159*((8/2)**2)))-5
if height >= 2:
return height
else:
return 2
def pcr_tip_height(vol):
height = math.log2(vol/(3.14159*((1.8/2)**2)))*2.5
	if height >= 1:
		return height
	else:
		return 1

#example for implementing during aspiration and dispense methods:
pipette20.pick_up_tip()
pipette20.aspirate(vol, plate1[res_loc_list[res_num-1]].bottom(res_tip_height(res_vol)), rate=2.0)
pipette20.dispense(vol, plate2[loc].bottom(pcr_tip_height(vol)), rate=2.0)
pipette20.blow_out()
pipette20.drop_tip()  #drop in the fixed trash on the deck
res_vol-=vol

I'm also interested in this sort of feature as I've got lots of plate filling type operations I'd like to do (prefilling plates of SPRI beads, bulk setup of premade PCR plates etc).
I've been implementing something similar to @JRT3 where I create values for the barrel length and tip length of wells then model them as either a cylinder plus a cone or a cuboid plus a pyramid and calculate the liquid height change based on the aspirate volume. I then reset the aspirate height for the next loop iteration. This generally works well for a series of aspirates and dispenses but not distribute.
As an interim suggestion for the next minor update, rather than maintaining a dict of liquid volumes that get updated, could there be an option in distribute to step down by a percentage of the well height for each aspirate that simply stops at the normal bottom position? It's not perfect as sometime's it'll drop a bit more than you'd like and it requires a little bit of thought to set up (i.e. the user will have to think about how many aspirates they will likely generate from the command and set the values accordingly) but it would be a useful improvement.
E.g. if I want to distribute to 5 plates:
spri_plate_name = "whatever_Im_distributing_to"
dest_plates = [protocol.load_labware(spri_plate_name, str(slot))
      for slot in [available_slots[i] for i in range(number_of_destination_plates)]]

all_dests = [well for plate in dest_plates for well in plate.rows('A')]

for d in all_dests:
        left_pipette.distribute(spri_vol, beads, d, touch_tip = True, aspirate_height = -0.1)

Where aspirate_height = -0.1 tells the opentrons to drop the aspirate height by 10% of the well height each aspirate starting at whatever is supplied by left_pipette.well_bottom_clearance.aspirate =

I'm also interested in this sort of feature as I've got lots of plate filling type operations I'd like to do (prefilling plates of SPRI beads, bulk setup of premade PCR plates etc).
I've been implementing something similar to @JRT3 where I create values for the barrel length and tip length of wells then model them as either a cylinder plus a cone or a cuboid plus a pyramid and calculate the liquid height change based on the aspirate volume. I then reset the aspirate height for the next loop iteration. This generally works well for a series of aspirates and dispenses but not distribute.
As an interim suggestion for the next minor update, rather than maintaining a dict of liquid volumes that get updated, could there be an option in distribute to step down by a percentage of the well height for each aspirate that simply stops at the normal bottom position? It's not perfect as sometime's it'll drop a bit more than you'd like and it requires a little bit of thought to set up (i.e. the user will have to think about how many aspirates they will likely generate from the command and set the values accordingly) but it would be a useful improvement.
E.g. if I want to distribute to 5 plates:
spri_plate_name = "whatever_Im_distributing_to"
dest_plates = [protocol.load_labware(spri_plate_name, str(slot))
      for slot in [available_slots[i] for i in range(number_of_destination_plates)]]

all_dests = [well for plate in dest_plates for well in plate.rows('A')]

for d in all_dests:
        left_pipette.distribute(spri_vol, beads, d, touch_tip = True, aspirate_height = -0.1)

Where aspirate_height = -0.1 tells the opentrons to drop the aspirate height by 10% of the well height each aspirate starting at whatever is supplied by left_pipette.well_bottom_clearance.aspirate =


Issue with k8s.io/docs/concepts/services-networking/dns-pod-service/

This is a...

[x] Feature Request
[ ] Bug Report

Problem:
Currently, dnsPolicy can only be configured on a pod by pod basis. There needs to be a configuration where the DNS policy can be configured cluster-wide. For example, right now I am specifying that my pod dnsPolicy: Default, I'd like to see if there is a configuration available where I can apply that cluster-wide, so that when new pods get scheduled, they automatically obtain that configuration from the cluster instead of putting it in the pod spec on a pod-by-pod basis.
Proposed Solution:
Please allow dnsPolicy to also be applied cluster-wide.
Page to Update:
https://kubernetes.io/...

It sounds like you want to have a new feature in Kubernetes? If that's right, you can raise an issue against the Kubernetes repo.
For this case, I think you're asking for someone to implement an admission controller that adds the behaviour you have in mind.

Right. This is not a doc issue.


quick fix for issue #40 hide if autoplay is on

https://github.com/2fdevs/videogular/issues/40

This repository is only for distribution, please, send your PRs to https://github.com/2fdevs/videogular


FLTR-8425: Removed call to close the bottom sheet from _ModalBottomSheetState._handleDragUpdate

In this PR, the _ModalBottomSheetState._handleDragUpdate() will no longer dismiss the modal sheet.

Let's wait for Max to review this please.
I feel like using this would be a better solution: https://github.com/jamesblasco/modal_bottom_sheet/pull/204/files?diff=unified&w=1

@max-insight
Ping, just in case 🙂

I think it's better Instead of removing the call, maybe better to be able to pass parameter and control with that?
I like what @b-ray suggested
but maybe do it as next improvement?

Thanks @max-insight , I agree that making it optional would be a better choice, I will work on it now.
However, as mentioned by @b-ray , do you think this PR is still necessary after this PR https://github.com/jamesblasco/modal_bottom_sheet/pull/204/files?diff=unified&w=1

After further investigation, this PR is probably not needed - if we remove the WillPopScope from the modal bottom sheet, the dismissing of the modal bottom sheet should not have issue https://insight-timer.atlassian.net/browse/FLTR-8425 anymore.


[Docs] Code of Conduct improvement

Documentation Link
https://github.com/appsmithorg/appsmith/blob/release/CODE_OF_CONDUCT.md
Describe the problem
The articulation of this documentation needs to be improved.
Describe the improvement
There are many sections that start with "Examples of" which is not a good way of writing. So, I want to improve those parts. Then I want to correct some more grammatical errors as well.
Please assign this issue to me for the hacktoberfest, so that I can start improving the documentation.

@SandipPalit Thanks for noticing this issue and offering to help resolve this! This is all yours. Assigning it to you.

Thank You @riodeuno
I am working on this issue and will submit the PR soon.

@riodeuno , I have completed the changes and submitted the PR #8083

Hi @SandipPalit apologies, I don't think this is a very good PR because our code of conduct is a standard one taken from the contributor covenant. As such I don't think we can accept this PR. Do have a look at our many good first issue!


Migrate LGTM.com installation from OAuth to GitHub App

Hi There,
This project is still using an old implementation of LGTM's automated code review, which has now been disabled. To continue using automated code review, and receive checks on your Pull Requests, please install the GitHub App on this repository.
Thanks,
The LGTM Team

LGTM App has been installed. See https://github.com/apps/lgtm-com/installations/5214315.


Feat: Login Page Alignment issue

Describe the feature
@SUGAM-ARORA There is a problem of having footer section in Log In page. Kindly assign this issue to me.
Add ScreenShots

Record

[X] I agree to follow this project's Code of Conduct
[X] I'm a GSSOC'24 contributor
[X] I want to work on this issue

@Ojas-Arora Issue assigned to you


msf simple map create cant exit normally

When I use the msf_simple_map_creator.sh to create a local map , the script will hang on "lossless_map_creator" ---- dont crach dont exit ,cant goto the next dir. just in the middle of  a bundle of dirs.
GetMapNodeSafe: This node don't exist in cache!  load this node from disk now!Map node (Resolution ID: 0 Zone ID: 50 Easting: 1802 Northing: 26135) I0420 11:15:28.663735 3246326 base_map_node.cc:284] []map node compress ratio: 0.0127035 I0420 11:15:28.703687 3246326 base_map.cc:247] []Loaded map node: Map node (Resolution ID: 0 Zone ID: 50 Easting: 1802 Northing: 26135) GetMapNodeSafe: This node don't exist in cache!  load this node from disk now!Map node (Resolution ID: 0 Zone ID: 50 Easting: 1801 Northing: 26136) I0420 11:15:28.733476 3246326 base_map_node.cc:284] []map node compress ratio: 0.0255498 I0420 11:15:28.775014 3246326 base_map.cc:247] []Loaded map node: Map node (Resolution ID: 0 Zone ID: 50 Easting: 1801 Northing: 26136) GetMapNodeSafe: This node don't exist in cache!  load this node from disk now!Map node (Resolution ID: 0 Zone ID: 50 Easting: 1801 Northing: 26135) I0420 11:15:28.805353 3246326 base_map_node.cc:284] []map node compress ratio: 0.0228496 I0420 11:15:28.846132 3246326 base_map.cc:247] []Loaded map node: Map node (Resolution ID: 0 Zone ID: 50 Easting: 1801 Northing: 26135) I0420 11:15:28.846529 3246326 base_map_config.cc:48] []Saved the map configuration to: /apollo/modules/localization/msf_mapdata/lossless_map/config.xml I0420 11:15:29.009377 3246326 base_map_node.cc:66] []Save Map Node to disk: Map node (Resolution ID: 0 Zone ID: 50 Easting: 1803 Northing: 26133). I0420 11:15:29.173291 3246326 base_map_node.cc:66] []Save Map Node to disk: Map node (Resolution ID: 0 Zone ID: 50 Easting: 1803 Northing: 26134).

the command is as follows:
bash /apollo/scripts/msf_simple_map_creator.sh   /apollo/data/record  velodyne_novatel_extrinsics.yaml 50  /apollo/modules/localization/msf_mapdata
the record dir is as follows:
20230419163026.record.00000<PHONE_NUMBER>3026.record.00004<PHONE_NUMBER>3026.record.00008<PHONE_NUMBER>3026.record.00012
20230419163026.record.00001<PHONE_NUMBER>3026.record.00005<PHONE_NUMBER>3026.record.00009
20230419163026.record.00002<PHONE_NUMBER>3026.record.00006<PHONE_NUMBER>3026.record.00010
20230419163026.record.00003<PHONE_NUMBER>3026.record.00007<PHONE_NUMBER>3026.record.00011
the record msg as follow:
/apollo/sensor/livox/compensated                       503 messages: apollo.drivers.PointCloud
/apollo/localization/pose                             6002 messages: apollo.localization.LocalizationEstimate
/apollo/localization/msf_lidar                           0 messages: apollo.localization.LocalizationEstimate
/apollo/localization/msf_gnss

Using strace , found it hang on a mutex
futex(0x56354603922c, FUTEX_WAIT_PRIVATE, 128, NULL) = -1 EAGAIN
futex(0x56354603922c, FUTEX_WAIT_PRIVATE, 132, NULL

Hello, I see that there is livox lidar data in your recording, I want to ask if there is an open source driver package in Apollo access to livox lidar, I looked at the livox official SDK only livox_hub, no livox_lidar.

I met the same problem. I am trying to create a LiDAR map for KITTI odometry sequence 00.

I converted KITTI point clouds to pcl format XYZIT
I extracted poses from KITTI oxts following the required format "pcd_number timestamp x y z qx qy qz qw".
I executed bash scripts/msf_local_map_creator.sh KITTI/2011_10_03_drive_0027_sync/pcds/ KITTI/2011_10_03_drive_0027_sync/poses.txt 32 KITTI/2011_10_03_drive_0027_sync/

It worked and generated the lossy maps (not sure if it is completed), however, it does not exit normally.

I found that there's a segmentation fault in the previous logs in my case
scripts/msf_local_map_creator.sh: line 18: 2096581 Segmentation fault      (core dumped) $APOLLO_BIN_PREFIX/modules/localization/msf/local_tool/map_creation/lossless_map_creator --use_plane_inliers_only true --pcd_folders $1 --pose_files $2 --map_folder $4 --zone_id $3 --coordinate_type UTM --map_resolution_type single

I think that might be the issue. I will open a new issue for it


DEV-14277 Update READMEs for repo name change.

Changed the repo name from terraform-emr-hbase to terraform-aws-emr-hbase for DEV-14277.

:tada: This PR is included in version 1.0.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


IncrementalIndex: Fix multi-value dimensions returned from iterators.

They returned MapBasedRows with arrays as values, which its getDimension doesn't understand and therefore toStrings, leading to dimension values like "[Ljava.lang.Comparable;@67c277a0".
The only uses of these iterators in production code were in IndexGeneratorCombiner and in the v1 groupBy merging code. So useCombiner was likely broken for multi-value dims. groupBy shouldn't have been affected since it doesn't merge with multi-value dimensions.

:+1:

👍


Hash binary values

Which issue does this PR close?

Closes #3050
Rationale for this change

Currently we can not group by binary values
What changes are included in this PR?

Implementing hashing for binary values. Also some first casting support (but depends on https://github.com/apache/arrow-rs/issues/2402 to be impemented).
Are there any user-facing changes?

Codecov Report

Merging #3098 (c563559) into master (9956f80) will decrease coverage by 0.02%.
The diff coverage is 32.00%.

@@            Coverage Diff             @@
##           master    #3098      +/-   ##
==========================================
- Coverage   85.95%   85.92%   -0.03%
==========================================
  Files         290      290
  Lines       52260    52285      +25
==========================================
+ Hits        44919    44928       +9
- Misses       7341     7357      +16

Impacted Files
Coverage Δ

datafusion/sql/src/planner.rs
81.94% <0.00%> (-0.08%)
:arrow_down:

datafusion/core/src/physical_plan/hash_utils.rs
40.05% <34.78%> (-0.38%)
:arrow_down:

datafusion/expr/src/logical_plan/plan.rs
77.43% <0.00%> (ø)

datafusion/core/src/physical_plan/metrics/value.rs
87.43% <0.00%> (+0.50%)
:arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

FYI @waitingkuo


feat: CircleCI pushes basic example server container on release

https://issues.jboss.org/browse/AEROGEAR-8436
Description
Publishes aerogear/voyager-server-example-basic after each release (tag) and on master builds.
Tested in my fork.

Actually it seems both as official way (see link to docs above). I would prefer to leave it the way it is.


Removed Offset

What type of PR is this? (check all applicable)

[X] ♻ Refactor
[ ] ✨ Feature
[ ] 🐛 Bug Fix
[ ] 👷 Optimization
[ ] 📝 Documentation Update
[ ] 🔖 Release
[ ] 🚩 Other

Description
This PR removed the Offset class and moved the offset method into the single curve classes.
Related Tickets & Documents
This PR closes #311
Added tests?

[ ] 👍 yes
[X] 🙅 no, because they aren't needed
[ ] 🙋 no, because I need help

Added to documentation?

[ ] 📓 docs
[X] 🙅 no documentation needed

@cesarecaoduro @d3ssy in this PR was merged this PR #323


Compile with mingw64 not found __builtin_ia32_paddsw128

I'm trying to compile the project with mingw64 and I get the following error:
'__builtin_ia32_phaddsw128' was not declared in this scope; did you mean '__builtin_ia32_paddsw128'
As far as I understand it is the use of SSE that generates this faulty use.
[build] [2/6  33% :: 0.295] No patch step for 'realsense'
[build] [3/6  50% :: 4.120] Performing configure step for 'realsense'
[build] -- Checking internet connection...
[build] -- Internet connection identified
[build] -- Info: REALSENSE_VERSION_STRING=2.53.1
[build] -- Setting Windows configurations
[build] -- Building libcurl enabled
[build] -- using RS2_USE_WMF_BACKEND
[build] -- Building with TM2
[build] -- Fetching recommended firmwares:
[build] -- D4XX_FW_VERSION: <IP_ADDRESS>
[build] -- SR3XX_FW_VERSION: <IP_ADDRESS>
[build] -- T26X_FW_VERSION: <IP_ADDRESS>1
[build] -- L51X_FW_VERSION: <IP_ADDRESS>
[build] -- L53X_FW_VERSION: <IP_ADDRESS>
[build] -- disable link time optimization for fw project
[build] -- https://librealsense.intel.com/Releases/RS4xx/FW/D4XX_FW_Image-<IP_ADDRESS>.bin
[build] -- Download firmware 0;"skipping download as file already exists with expected SHA1 hash" for D4XX_FW_Image-<IP_ADDRESS>.bin
[build] -- https://librealsense.intel.com/Releases/SR300/FW/SR3XX_FW_Image-<IP_ADDRESS>.bin
[build] -- Download firmware 0;"skipping download as file already exists with expected SHA1 hash" for SR3XX_FW_Image-<IP_ADDRESS>.bin
[build] -- https://librealsense.intel.com/Releases/TM2/FW/target/<IP_ADDRESS>1/target-<IP_ADDRESS>1.mvcmd
[build] -- Download firmware 0;"skipping download as file already exists with expected SHA1 hash" for target-<IP_ADDRESS>1.mvcmd
[build] -- https://librealsense.intel.com/Releases/L5xx/FW/L51X_FW_Image-<IP_ADDRESS>.bin
[build] -- Download firmware 0;"skipping download as file already exists with expected SHA1 hash" for L51X_FW_Image-<IP_ADDRESS>.bin
[build] -- https://librealsense.intel.com/Releases/L5xx/FW/L53X_FW_Image-<IP_ADDRESS>.bin
[build] -- Download firmware 0;"skipping download as file already exists with expected SHA1 hash" for L53X_FW_Image-<IP_ADDRESS>.bin
[build] -- Configuring done (3.3s)
[build] -- Generating done (0.2s)
[build] -- Build files have been written to: E:/engine/PA_Engine/EngineEcosystem/Engine/build/deps/Build/realsense
[build] [4/6  66% :: 33.733] Performing build step for 'realsense'
[build] FAILED: deps/Stamp/realsense/realsense-build E:/engine/PA_Engine/EngineEcosystem/Engine/build/deps/Stamp/realsense/realsense-build
[build] cmd.exe /C "cd /D E:\engine\PA_Engine\EngineEcosystem\Engine\build\deps\Build\realsense && "C:\Program Files\CMake\bin\cmake.exe" --build . && "C:\Program Files\CMake\bin\cmake.exe" -E touch E:/engine/PA_Engine/EngineEcosystem/Engine/build/deps/Stamp/realsense/realsense-build"
[build] [10/168   0% :: 12.043] Building CXX object CMakeFiles/realsense2.dir/include/librealsense2/utilities/concurrency/dispatcher.cpp.obj
[build] FAILED: CMakeFiles/realsense2.dir/include/librealsense2/utilities/concurrency/dispatcher.cpp.obj
[build] D:\msys64\ucrt64\bin\c++.exe -DBUILD_EASYLOGGINGPP -DCHECK_FOR_UPDATES -DCOM_MULTITHREADED -DCURL_STATICLIB -DELPP_NO_DEFAULT_LOG_FILE -DELPP_THREAD_SAFE -DHWM_OVER_XU -DNOMINMAX -DRS2_USE_WMF_BACKEND -DUNICODE -DWITH_TRACKING=1 -D_CRT_SECURE_NO_WARNINGS -D__SSSE3__ -IE:/engine/PA_Engine/EngineEcosystem/Engine/build/deps/Source/realsense -IE:/engine/PA_Engine/EngineEcosystem/Engine/build/deps/Build/realsense -IE:/engine/PA_Engine/EngineEcosystem/Engine/build/deps/Source/realsense/src -IE:/engine/PA_Engine/EngineEcosystem/Engine/build/deps/Source/realsense/third-party/realsense-file/rosbag/console_bridge/include -IE:/engine/PA_Engine/EngineEcosystem/Engine/build/deps/Source/realsense/third-party/realsense-file/rosbag/cpp_common/include -IE:/engine/PA_Engine/EngineEcosystem/Engine/build/deps/Source/realsense/third-party/realsense-file/rosbag/rosbag_storage/include -IE:/engine/PA_Engine/EngineEcosystem/Engine/build/deps/Source/realsense/third-party/realsense-file/rosbag/roscpp_serialization/include -IE:/engine/PA_Engine/EngineEcosystem/Engine/build/deps/Source/realsense/third-party/realsense-file/rosbag/rostime/include -IE:/engine/PA_Engine/EngineEcosystem/Engine/build/deps/Source/realsense/third-party/realsense-file/rosbag/roscpp_traits/include -IE:/engine/PA_Engine/EngineEcosystem/Engine/build/deps/Source/realsense/third-party/realsense-file/rosbag/roslz4/include -IE:/engine/PA_Engine/EngineEcosystem/Engine/build/deps/Source/realsense/third-party/realsense-file/rosbag/msgs -IE:/engine/PA_Engine/EngineEcosystem/Engine/build/deps/Source/realsense/third-party/realsense-file/boost -IE:/engine/PA_Engine/EngineEcosystem/Engine/build/deps/Source/realsense/third-party/realsense-file/lz4/lib -IE:/engine/PA_Engine/EngineEcosystem/Engine/build/deps/Source/realsense/include -IE:/engine/PA_Engine/EngineEcosystem/Engine/build/deps/Build/realsense/common/fw -ID:/msys64/ucrt64/include/libusb-1.0 -O3 -DNDEBUG -std=gnu++11 -MD -MT CMakeFiles/realsense2.dir/include/librealsense2/utilities/concurrency/dispatcher.cpp.obj -MF CMakeFiles\realsense2.dir\include\librealsense2\utilities\concurrency\dispatcher.cpp.obj.d -o CMakeFiles/realsense2.dir/include/librealsense2/utilities/concurrency/dispatcher.cpp.obj -c E:/engine/PA_Engine/EngineEcosystem/Engine/build/deps/Source/realsense/include/librealsense2/utilities/concurrency/dispatcher.cpp
[build] In file included from D:/msys64/ucrt64/lib/gcc/x86_64-w64-mingw32/12.2.0/include/immintrin.h:37,
[build]                  from D:/msys64/ucrt64/lib/gcc/x86_64-w64-mingw32/12.2.0/include/x86intrin.h:32,
[build]                  from D:/msys64/ucrt64/include/winnt.h:1658,
[build]                  from D:/msys64/ucrt64/include/minwindef.h:163,
[build]                  from D:/msys64/ucrt64/include/windef.h:9,
[build]                  from D:/msys64/ucrt64/include/windows.h:69,
[build]                  from E:/engine/PA_Engine/EngineEcosystem/Engine/build/deps/Source/realsense/third-party/easyloggingpp/src/easylogging++.h:380,
[build]                  from E:/engine/PA_Engine/EngineEcosystem/Engine/build/deps/Source/realsense/include/librealsense2/utilities/easylogging/easyloggingpp.h:22,
[build]                  from E:/engine/PA_Engine/EngineEcosystem/Engine/build/deps/Source/realsense/include/librealsense2/utilities/concurrency/dispatcher.cpp:5:
[build] D:/msys64/ucrt64/lib/gcc/x86_64-w64-mingw32/12.2.0/include/tmmintrin.h: In function '__m128i _mm_hadd_epi16(__m128i, __m128i)':
[build] D:/msys64/ucrt64/lib/gcc/x86_64-w64-mingw32/12.2.0/include/tmmintrin.h:42:20: error: '__builtin_ia32_phaddw128' was not declared in this scope; did you mean '__builtin_ia32_paddw128'?
[build]    42 |   return (__m128i) __builtin_ia32_phaddw128 ((__v8hi)__X, (__v8hi)__Y);```

Hi @MartyG-RealSense
The project I work on will need to be compiled on Windows (X86 and Arm) and Linux (x86 and Arm). To facilitate the cross-compile, I opted to compile the code and better manage the target platform. With MingW64 I keep the same GNU standard in all compilers and avoid having to deal with specific cases of each compiler in the code.
Another important point for using MingW64 is not having the Visual Studio license costs. As far as I understand the SDK on the windows platform can only be compiled in Visual Studio, correct?
In the windows_config.cmake file, SSE support is enabled, are these instructions essential for the SDK? Or can the SDK be used without SSE support? As far as I've seen the code, if I remove the directive -D__SSSE3__ I won't have the error anymore. Would this change be possible?

SSSE3 is used if CUDA support in the SDK is not enabled.  It is enabled by building the SDK with the flag -DBUILD_WITH_CUDA=true included in the CMake build instruction.  CUDA is dependent on the computer having an Nvidia graphics GPU though, so would not be practical if your application has to be able to run on any computer and not just ones with an Nvidia GPU.
When SSSE3 is enabled, it is typically used for depth to color alignment.  My understanding of the SDK's alignment process is that it uses SSE optimizations if supported, otherwise it uses unoptimized align.
I do not know what the result will be if you remove the directive -D__SSSE3__.

SSSE3 is being enabled in all scenarios when the platform is windows. The way cmake is, it doesn't matter if you use CUDA or not.
You can see in this file:
https://github.com/IntelRealSense/librealsense/blob/master/CMake/windows_config.cmake

I have highlighted your issue to my Intel RealSense colleagues to seek their advice about whether SSSE3 can be disabled.

Thanks very much for your patience.  My colleagues have responded with the advice below.

We recommend to use Visual Studio to compile the SDK on Windows.  SSSE3 can be disabled, but expect potential performance impact in certain performance sensitive usages.
In the SDK, some image processing and transformation, for example, YUY2 image format conversion, depth alignment, and pointcloud, are very computing intensive.  A few different optimizations are implemented in the current SDK to accelerate this processing, including GLSL with GPU, CUDA on Nvidia, and SSSE3 on CPU.
In normal usages, when a graphics context is available (see examples like realsense-viewer and the pointcloud example), GLSL acceleration is used.  CUDA optimization (limited to alignment and pointcloud) will be used if Nvidia GPU is available and the CUDA cmake flag is enabled.
When GPU accelerations are not available, SSSE3 optimized code will be used.
If none of these is available then processing will not be accelerated and performance may be impacted.
So if SSSE3 is disabled, performance will be impacted only when GPU acceleration is also not available.

Thanks for the feedback. Usage on windows will probably be just for testing and development and we don't have high performance requirements. The release version will be used on a Jetson with Cuda enabled.
I'll try unavoiding SSSE and give feedback on the behavior.

Thanks very much.  I look forward to your next report.  Good luck!

I had to work on other areas due to a priority change and I didn't have time to take the test. Once I get the test done I will post the feedback.

Thanks very much @frbitten for the update!

Case closed due to no further comments received.

Hi @MartyG-RealSense, sorry for the delayed response. But I only now had time to look into this problem.
It is not possible to compile the SDK with MingW. Even removing SSSE3 and several error blocks if the visual studio version is old, the code uses Microsoft ATL that only exists in Visual Studio. And there is no way around it.
It would be interesting in the future to allow the SDK to be compiled with MingW for windows. Since it is compiled with GCC for Linux.


Re-design Proposal for beautifier.io

Hello!
As an appreciative user of beautifier.io during my projects, I love this tool and find myself using it and its many options. I would love for it to have a more organised and simplistic design. I feel like making it look more modern and sleek would make a huge difference in the user's experience.
I saw that implementing a CSS library raises the concern of backward compatibility, as mentioned by @bitwiseman in the Dark Mode issue.
I would like to propose, for starters, small re-formatting and alignment changes using CSS, and not a library. After that, I'd love to add a dark mode feature, being triggered on and off with a simple button on the website, if it is not being worked on yet.
Please let me know if I should provide a clearer framework for what I think the website should look like if this is of interest to you.
Thanks!

@sherifsallam
I think the dark mode PR #2058 is okay and I've gone ahead and merged it.  However, if you would like to make further improvements, they would be totally welcomed.


[Bug] dbt_vars raised "This can happen when calling a macro that does not exist"

Astronomer Cosmos Version
Other Astronomer Cosmos version (please specify below)
If "Other Astronomer Cosmos version" selected, which one?
1.4.3
dbt-core version
1.7.16
Versions of dbt adapters
dbt-impala==1.4.3 (but i don't think this issue related with adapter)
LoadMode
DBT_LS
ExecutionMode
LOCAL
InvocationMode
None
airflow version
2.9.1
Operating System
PRETTY_NAME="Debian GNU/Linux 12 (bookworm)" NAME="Debian GNU/Linux" VERSION_ID="12" VERSION="12 (bookworm)"
If a you think it's an UI issue, what browsers are you seeing the problem on?
No response
Deployment
Official Apache Airflow Helm Chart
Deployment details
No response
What happened?
dbt_vars can raise "This can happen when calling a macro that does not exist"
Relevant log output
'data_interval_end' is undefined. This can happen when calling a macro that does not exist. Check for typos and/or install package dependencies with "dbt deps".

How to reproduce
I need to pass variable, start_dt, to dbt_models with data_interval_end macro of airflow. Below is my configuration for cosmos dag and it worked like a charm.
project_config = ProjectConfig(
    dbt_project_path="/opt/airflow/dbt/data-dbt",
    project_name="data_dbt",
    partial_parse=True,
    dbt_vars={
        "start_dt": '{{ data_interval_end }}',
    },
)
profile_config = ProfileConfig(
    profile_name="data_dbt",
    target_name="dev",
    profiles_yml_filepath=Path("/opt/airflow/dbt/data-dbt", "profiles", "profiles.yml"),
)
render_config = RenderConfig(
    load_method=LoadMode.DBT_LS,
    emit_datasets=False,
    test_behavior=TestBehavior.AFTER_EACH,
    select=[
        "models/my_model.sql",
    ],
)
execution_config = ExecutionConfig(
    execution_mode=ExecutionMode.LOCAL,
)
operator_args = {
    "install_deps": True,
}

dbt_op = DbtTaskGroup(
    group_id="dbt_group",
    project_config=project_config,
    profile_config=profile_config,
    render_config=render_config,
    execution_config=execution_config,
    operator_args=operator_args,
)

However, when I tried to call function of macro like below, it raised error:
project_config = ProjectConfig(
    dbt_project_path="/opt/airflow/dbt/data-dbt",
    project_name="data_dbt",
    partial_parse=True,
    dbt_vars={
        "start_dt": '{{ data_interval_end.strftime("%Y-%M-%d") }}',
    },
)

dbt model:
select *
from source("my_source")
where date_time >= '{{ var("start_dt") }}'

error:
  'data_interval_end' is undefined. This can happen when calling a macro that does not exist. Check for typos and/or install package dependencies with "dbt deps".

I think this is due to how yaml.dump works in here (I think using json.dumps will work...).
Is there any way I can pass variable to dbt_models with macro function?
Anything else :)?
written in above
Are you willing to submit PR?

[X] Yes I am willing to submit a PR!

Contact Details
<EMAIL_ADDRESS>

Really important question: Does this error occur in task execution or in DAG rendering?

One more note I didn't mention is that your use case is not atypical. I think injecting DagRun variables like the data interval end should be supported. It's very natural to want to do that. And it clearly is not supported right now. I think we should make this a more explicitly supported pattern. So keep doing what you're doing and don't be discouraged!


Qq

[READ] Step 1: Are you in the right place?

For issues or feature requests related to the code in this repository
file a Github issue.

If this is a feature request make sure the issue title starts with "FR:".

For general technical questions, post a question on StackOverflow
with the firebase tag.
For general Firebase discussion, use the firebase-talk
google group.
For help troubleshooting your application that does not fall under one
of the above categories, reach out to the personalized
Firebase support channel.

[REQUIRED] Step 2: Describe your environment

Operating System version: _____
Firebase SDK version: _____
Library version: _____
Firebase Product: _____ (auth, database, storage, etc)

[REQUIRED] Step 3: Describe the problem
Steps to reproduce:
What happened? How can we make the problem occur?
This could be a description, log/console output, etc.
Relevant Code:
// TODO(you): code here to reproduce the problem

لم أتمكن من تحديد كيفية تصنيف هذه المشكلة، لذا فقد قمت بتصنيفها حتى يتمكن شخص ما من تقييمها. انتظر قليلاً.

شكرا لكم على جهودكم المبذولة

I am closing this due to lack of information. If you are having an issue related to this SDK please open a new issue and provide as much details as you can including any error logs or a minimal repro. That will help us investigate the issue. Thanks!


Precision on the difference between NATIONAL and PERSON_TYPE

I was reading the annotation guidelines about largest entity mention and I'm struggling a bit to draw the line between NATIONAL and PERSON_TYPE. It says:

Let's consider the token British. Depending on the context, British in isolation can labelled with the classes NATIONAL (when introducing a relation to Great Britain), PERSON_TYPE (for the British people) or CONCEPT (when refering to the British English language)

Regarding the British people, for example, do we use PERSON_TYPE only if the token British is in isolation? Like:
- a <ENAMEX type="NATIONAL">British</ENAMEX> historian said this.
- a <ENAMEX type="PERSON_TYPE">British</ENAMEX> said this.

?

I would say, for the particular case of British people, we might also want to label British as PERSON_TYPE when it is clear that we refer to the folks - not just in relation to a location.
For instance, "the British descendants in Canada", the "British emigrants" ?
What do you think?

It makes sense, but what would be the criteria? When it refers to a human? For example in British historian, British would be annotated as PERSON_TYPE ?

Yes, so depending on the context if the historian studies the "ethnic" British or, by default, the country/national.  In the case of "British historian", I think it will be an historian coming from Great-Britain so it would be NATIONAL. I don't think we will find "British historian" in the case of an historian specialised in the history of the British folk, it would be expressed differently.

So we discussed this and here is a recap:

PERSON_TYPE because the entity is a group of people:

- the <ENAMEX type="PERSON_TYPE">British</ENAMEX> are great people.
- the <ENAMEX type="PERSON_TYPE">British emigrants</ENAMEX>
- the <ENAMEX type="PERSON_TYPE">British people</ENAMEX> are not great

NATIONAL because it refers to the LOCATION:

a <ENAMEX type="NATIONAL">British</ENAMEX> historian

@kermitt2 what do you think of our recap? I'm still not sure if emigrants and people are to be included in the tag here.

I would say:

the British are great people.
the British emigrants
the British people are not great

Emigrants and poeple are not named entities rather common words.

For the following sentence:
These were: additional immigration controls, especially for new <ENAMEX type="TITLE">EU members</ENAMEX>; tougher immigration rules for present <ENAMEX type="INSTITUTION">EU</ENAMEX> citizens
We used to annotate EU as INSTITUTION, as shown above.
Now, applying the large entity match principe, we would think, it would be more appropriate to annotate the whole NP (EU citizen), and by doing so, we would consider "citizen" as PERSON_TYPE? Just (US citizen, or British citizen). Note that, However, we thought (British) in this case is NATIONAL.
<ENAMEX type="PERSON_TYPE">EU citizens</ENAMEX>

I think it's not the same as British because British alone is ambiguous as PERSON_TYPE or NATIONAL. EU alone can only be INSTITUTION and citizen is a common name, not an entity, so the largest entity principle does not apply:
EU citizens

In a previous discussion, we decided to annotate British immigrants or British descendants as PERSONNE_TYPE
I think  immigrants and descendants are also common names just like citizens, non?
how the policy would be in the case of British citizens?

Mmm @wigdan I am not sure I understand. Immigrants, descendants are all common words excluded from the entity markup no? Same for citizens.  That's what I suggested in my messages above (5 days ago... "Emigrants and poeple are not named entities rather common words.").

@kermitt2, we are a bit confused.

When something that may be NATIONAL is used to refer to people, we annotate PERSON_TYPE: ex. the <ENAMEX type="PERSON_TYPE">British</ENAMEX> emigrants

We still don't know what to do for cases where the entity refers to a group of people in adhesion with a CONCEPT (issue #29, examples in https://github.com/kermitt2/grobid-ner/issues/29#issuecomment-301034294) like the eurosceptics held a protest

It seems to us the same question is valid for INSTITUTION. After all, the citizens from EU are a group of people, so why not <ENAMEX type="PERSON_TYPE">EU</ENAMEX> citizens?

What do you think?

I also came across (Commonwealth citizens) which defines a person who has that status under British nationality law and may enjoy some privileges in the United Kingdom (Wikipedia). For instance, Sudan used to be belong to the Commonwealth countries...
So, i'm adding this suggestion  <ENAMEX type="PERSON_TYPE">Commonwealth</ENAMEX>
In the case of COORDINATION, it will be helpful, please check the following sentence:
1- The <ENAMEX type="LEGAL">European Union Referendum Act 2015</ENAMEX> dictated that only <ENAMEX type="PERSON_TYPE">British, Irish and Commonwealth</ENAMEX> citizens
2- The <ENAMEX type="LEGAL">European Union Referendum Act 2015</ENAMEX> dictated that only  <ENAMEX type="PERSON_TYPE">British, Irish</ENAMEX> and <ENAMEX type="INSTITUTION">Commonwealth</ENAMEX> citizens
Note that in 2, while annotating "Commonwealth" as INSTITUTION, the COORDINATION with other named entities is somehow lost...

@wigdan 👍 for <ENAMEX type="PERSON_TYPE">Commonwealth</ENAMEX>, for the second question I would keep the first proposal, Commonwealth is an Institution but the citisen are a group of people.

The motivation for annotating British differently from EU is that British alone is ambiguous between PERSON_TYPE and NATIONAL. This is not the case for EU which cannot alone be PERSON_TYPE, it is INSTITUTION.

So when something that may be NATIONAL is used to refer to people, we annotate PERSON_TYPE: ex.

the <ENAMEX type="PERSON_TYPE">British</ENAMEX> emigrants

Citizens from EU are a group of people, but not a named entity because citizens is a common name, and so it leaves EU as the only named entity here - which is not alone a PERSON_TYPE, so

<ENAMEX type="INSTITUTION">EU</ENAMEX> citizens

Suppose we have EU British citizen, British is PERSON_TYPE in this context and a named entity, so from the largest entity principle we have:

<ENAMEX type="PERSON_TYPE">EU British</ENAMEX> citizens

Commonwealth is like the EU an INSTITUTION. Like EU, Commonwealth alone never refer to PERSON_TYPE, it's an institution (like the EU and many institutions, this institution grants some rights to its members, but an institution is more than its members). So the annotation in your example would be the second, given that citizen is common name:

The <ENAMEX type="LEGAL">European Union Referendum Act 2015</ENAMEX> dictated that only <ENAMEX type="PERSON_TYPE">British, Irish</ENAMEX> and <ENAMEX type="INSTITUTION">Commonwealth</ENAMEX> citizens.

@kermitt2 thanks,
so if I understand correctly, things like Eurosceptic could also be PERSON_TYPE when referring to people, because like British it can be ambiguous (between CONCEPTUAL and PERSON_TYPE)?

note for doc, this is related to https://github.com/kermitt2/grobid-ner/issues/29#issuecomment-302898533


Nightly Build

Provide a nightly build (not stable) via the JetBrains repository to handle the R# release cycle.

[x] Use GitHub Actions (#103)
[x] Run job once a every day (only if there are new commits) (#103)
[x] Build and pack (#103)
[x] Create a GitHub Release (#103)
[x] Attach nupkg file to the release (#103)
[x] Increment version in nuspec file* (#103)
[ ] Increment version in assembly file*
[x] Push changes (#103)
[ ] Push nupkg file to the JetBrains repository
[x] Use SemVer in nuspec file (#104)

* Currently recorded version is the current development version

Bug:
nuspec file uses semantic version (major.minor.patch[-pre-release]) instead of major.minor.build.revision

@RicoSuter can you please add a secret for the automated upload or give me the requiered rights.
I will message you the key and the value.
Or can you give me the required rights to add one?
You can find the secret section at Repository > Settings > Secrets

@ManticSic you're admin now.

Thanks @RicoSuter
I will arrange everything this weekend


Error getting my location using the request-location-accuracy plugin

I'm submitting a ...  (check one with "x")

[ ] question
[x] any problem or bug report

OS:  (check one with "x")

[x] Android
[ ] iOS

cordova information:  (run $> cordova plugin list)
cordova-plugin-device 2.0.2 "Device"
cordova-plugin-googlemaps 2.3.8 "cordova-plugin-googlemaps"
cordova-plugin-ionic-keyboard 2.0.5 "cordova-plugin-ionic-keyboard"
cordova-plugin-ionic-webview 1.2.1 "cordova-plugin-ionic-webview"
cordova-plugin-request-location-accuracy 2.2.3 "Request Location Accuracy"
cordova-plugin-splashscreen 5.0.2 "Splashscreen"
cordova-plugin-statusbar 2.4.2 "StatusBar"
cordova-plugin-whitelist 1.3.3 "Whitelist"

If you use @ionic-native/google-maps, please tell the package.json (only @ionic-native/core and @ionic-native/google-maps are fine mostly)
@ionic-native/core :
@ionic-native/google-maps :

Current behavior:

Expected behavior:

Screen capture or video record:

Related code, data or error log (please format your code or data):
Please share your project files on Github or others(Bitbucket, Gitlabs...etc).
If you don't want to share your project files, please create a demo project, then share it.

Screen captures, and/or native logs(such as Logcat, xcode logs) are appreciate.

Giving much information, you are waiting time is less.
Thank you for your cooperation.

Hello, good day, what happens is that I need to activate the gps as long as I do not have it activated, and for that I am using the Location Accuracy plugin, what happens is that when it asks to activate the gps it enters the function of obtaining my position but does not execute it, does not add the marker to the map.
Please help, I'm desperate with this.
Thank you.

Ask to the Location Accuracy plugin author. This plugin is not related.

Is that the plugin correctly activates the gps but when you get the current location with this.map.getMyLocation () does not execute it, it does not enter the .then () nor the .catch ().
Can I share my repository?

I realized, that when the gps is inactive and that it calls the map, and when the GPS status changes to active, the function this.map.getMyLocation () does not run, but when it exits and reopens the application already with the active GPS already recognizes it.
In itself, the this.map.getMyLocation () function obtains the state of the gps that it has at the beginning, it does not hear the event from inactive to active.

Pity, The Location Accuracy plugin was working correctly before having to update the google maps plugin, now for some reason the map.getMyLocation() does not work anymore when the status of the GPS changes from inactive to active, likewise the google maps plugin It is very good and even so I need it 100%, I have to use a third plugin "Geolocation".
I would recommend reviewing this issue of changing the status of the GPS and the getMyLocation function in ionic because the truth was working correctly before the update to 2.3.8


tf.contrib.layers.flatten has neither "name" nor "reuse" parameter.

I think tf.contrib.layers.flatten is just a special case of tf.reshape.
However, while tf.reshape has name parameter, tf.contrib.layers.flatten doesn't have one. Also neither of them has reuse parameter.
Is tf.contrib.layers.flatten a deprecated API?

Just found the flatten has been added to core layers tf.layers recently.
https://github.com/tensorflow/tensorflow/commit/80ed8afc02b16adb209bffeb551e7f0c435985f6
I was curious why reshape is not added into core layers as well.

@fchollet can you comment or redirect? Thanks.

There was an attempt to introduce Reshape in tf.layers at the same time as Flatten, but it was not approved; if I recall correctly this was to limit API surface.
You could use tf.keras.layers.Reshape instead.


OCM notifications endpoint is not published

The OCM spec requires a /notifications endpoint
but it's not listed as Unprotected in https://github.com/cs3org/reva/blob/v1.14.0/internal/http/services/ocmd/ocmd.go#L97

(Fixed some time ago)


The installer should check the presence of Vagrant and VirtualBox

If they are not present, the installer should fail fast.

@masch

I have created a PR adding validation for Git, Vagrant and VirtualBox programs.

Fixed by https://github.com/mumuki/mumuki-development-installer/pull/3


About strict mode and ajv

nodejs version: v18.2.0
        const server = new RPCServer({
            protocols: ['ocpp2.0.1'],
            strictMode: true,
        });

       // after client connected
       client.call('RequestStartTransaction', requestStartTransactionPayload);

After I lauch server, I tried to call "RequestStartTransaction" request.
And I got Error: strict mode: "additionalItems" is ignored when "items" is not an array of schemas.
So I delete the all of "additionalItems" attirbutes in "ocpp2_0_1.json" and it works.
I think it is because of this: https://ajv.js.org/strict-mode.html#ignored-additionalitems-keyword

Thanks for the report.
Can you please provide the content of the requestStartTransactionPayload?

const requestStartTransactionPayload = {
            remoteStartId: new Date().getTime(),
            idToken: {
                idToken: user_uid, // string
                type: 'Central'
            }
        };

Do I miss something required?

Thanks for the report.  You are correct - it seems to be a problem with Ajv's strict validation of the schema.
I've decided to disable the strictSchema validation option in the Ajv constructor.  This should add some flexibility without harming interoperability.
I may expose the Ajv constructor options in a future update if there is a request for it.
This is now fixed in v1.5.1 4a7ed6e5b48e2a81b5df5f9f97b987d23fce11af


Building initial module for 4.19.0-16-amd64

The server is always hanging while installing the script on Building initial module for 4.19.0-16-amd64

Not sure that's related to the script, sorry :/


Introduce a mechanism that can be used to activate debug extensions just in time

With the new debug API we need to register DebugConfigurationProvider early enough so that VS Code has them available when it needs them.
Since DebugConfigurationProvider are typically registered in the activate function of an extension, we have to find a way to activate the corresponding extensions before debugging starts.
I've tried to use these actions to activate the extension that registers a DebugConfigurationProvider:
    "onCommand:workbench.action.debug.selectandstart",
    "onCommand:workbench.action.debug.configure",
    "onCommand:workbench.action.debug.start",

but most of the time the registration in the extension does not happen in time for VS Code  to pick it up. So I had to resort to "*" with the side effect that the extension now starts on startup of VS Code.
So we need a more robust mechanism that allows to activate extensions for registering DebugConfigurationProvider just in time before debugging starts.
@jrieken can provide the details.

Yeah, we don't always for the onCommand:xyz execution events, e.g. not when the extension host is still starting. You can either manually send out that activation events, like tasks does, or (recommended) invent a new event, ala onDebug:<type> or onDebug:* etc

I have introduced a onDebug activation event which should get triggered when a user is setting up his launch.json.
This activation event may be currently sent more than needed but I plan to clean this up once we remove all the depreacted items we plan for october (since then my code will be cleaner and this activation event will be more precies).
I have tried the event and it works fine for my extension

The "onDebug" activation event needs to be fired for everything debug related, not just when a user is setting up his launch.json.
E.g. in the no-folder case when the user has an arbitrary file open in the editor and presses F5. In this case there is no setting up launch.json involved.
The "onDebug" activation event should be as precise as possible even if you could not remove the deprecated code. The problem is that we can only remove the deprecated code if debug extension authors have migrated their extension to the DebugConfigurationProvider, but that needs an "onDebug" activation event that works already today and covers all cases.

@weinand agree. I have cleaned this up via b601113ef6
Notice that I had to add a comment about this event in the schema and I went with the following
An activation event emitted whenever a user is about to start debugging or about to setup debug configurations.

@isidorn the event description is perfect.


Error during model inference: name 'ollama' is not defined

Already these changes are implemented in the earlier PR #215, its about to get merged.

devika-backend-engine-1:
root: ERROR  : Error during model inference: name 'ollama' is not defined
with external ollama server and using the internal ollama server on docker compose

#24


sample requirements for mutational signature analysis

Hi，
I want to know if there are sample requirements for mutational signature analysis?

I think it more than 10 is fine, the more, the better.

I am not aware of any references suggesting a minimum number of samples. But as @ShixiangWang suggested more samples better the resolution. Hope this helps.


Multiple identifiers with implicit multiplication

In the demo, if you input '2xy' it returns 2 multiplied by the identifier 'xy' instead of 2 multiplied by x multiplied by y. This would make something like dividing both sides by y very difficult.

Right now implicit multiplication between variables requires a space between them.  I was thinking of adding an option so that the space wouldn't be necessary.  In that situation though you'd probably want things like sin, cos, etc. to be treated a single identifiers and not s * i * n so there would be additional work to check the identifier before splitting it up.

Hmm does mathjs do this with its parser? If so we should probably get this parser to behave that way too

I believe that it requires spaces between things.  I can double check that later today.  The reason why I'd like this to be configurable is that other things like KAS split up contiguous strings into implicit multiplication so having a single parser capable of both seems beneficial for wider adoption.

oh yeah, I'm pretty sure it does too. e.g. distance * velocity should parse those as symbols and not d*i*s*...
I guess the idea is people would see it was parsed as a single symbol and add a space or * to fix it themselves when using this :)


The following OpenGL functions are missing: glUniform2uiv, ...

Issue details
The following glUniform* functions seem to be missing. This is odd because all other glUniform* functions seem to be present.
From GL30:

glUniform2uiv

From GL20:

glUniform1ui
glUniform2ui
glUniform3ui
glUniform4ui

Reproduction steps/code
N/A. This is about the API.
Version of LibGDX and/or relevant dependencies
Looks like this issue is in HEAD. I am using 1.9.5.
Please select the affected platforms
All platforms.

Since Java does not have unsigned integers, use signed versions of these calls.
Numbers that will from Java's perspective overflow into negative values, will show up in glsl as expected. (At least that seems to be the intent, I haven't tested it. This is pretty common in Java.)

I thought this at first, but there actually are many unsigned versions. In particular, the following functions exist:

glUniform1uiv
glUniform3uiv
glUniform4uiv

...but glUniform2uiv is missing.
Also, the signed/unsigned-ness is not important for the argument passed (as you point out). But the signed-ness of the function you called must match the signed-ness of the corresponding uniform variable in the shader (where there are signed and unsigned ints) otherwise an OpenGL error is generated.

I stand corrected then, sorry.