"Select All" filtered values

When typing into the searchbox, the Select All option disappears. I can override the Select All rendering, to make sure it is always shown, but then it still selects all the options, not just the ones matching the search text.
I would like to be able to select all the options actually shown in the dropdown when filtering and only them. Is there any way to accomplish this?

Using a combination of onFiltered and renderSelectAll you can change what happens inside the custom render.
See this rough example:
https://codesandbox.io/s/picky-only-select-all-filtered-xztnh
When the filter is changed, we store the filtered results in the component state. With the custom select all we check if we're filtered, if so then add the filtered results as the selected values.
I didn't implement de-selecting, that'll need some work to go through the filtered results and remove them if they already exist etc.
The example should get you most of the way.

Thank you :). Are there any plans to add something like this as a standard option?

Not currently, I personally don't use Picky in any of my projects so I don't have much reason to develop. I'll fix bugs, accept PRs, and add enhancements when I'm not busy. Though this seems like a good suggestion. I'll mark this as a good first issue, if no-one gets around to it then I might do eventually.
Probably a prop like:
selectAllMode with options like: default, filtered
or just another boolean selectAllOnlyFiltered the name is nasty but at least it's accurate 😁

Thanks for the quick reply :).

I think I can implement the deselect option , what I'm thinking is static select all and deselect all buttons , will do their selections and deselections for all or just the filters. Would that be right?

Hi @HarishTeens,
No I don't think that would be correct. The behaviour that Simon requested is that when the user has filtered the list and they press "Select All", that it only selects the filtered results.
So let's say you have a list:

Moon
Boo
Cat

You then filter "oo", the list becomes:

Moon
Boo

When you press "Select All", it will select both Moon and Boo, but not Cat.
Currently it will still select all options.
Possible Solution
An additional prop is added called selectAllMode which has 2 modes: default and filtered.
default does as it currently does.
filtered will only select the currently filtered options.
Does that make sense?
Don't be afraid of asking more questions 😀

Yes I understood , when filtered , select all button will select only the filtered ones, i.e. Moon and Boo

And To be honest I don't know how to build or run packages , I've just used them in my projects, I was following the contributing.md file , it said to write a failing test on step 5 , i dont know testing too, would you help me out here?

Hello @HarishTeens,
Apologies for the late reply I was out to a party yesterday after work.
Yes I can help you.
I've updated the contributing.md with steps on how to do some manual testing locally. They may help you.
So if you got up to step 4, we're almost done with the boring stuff.
I understand that testing can be quite daunting but once you grasp it you won't look back. If you're serious about getting into testing I recommend Kent C Dodds' Testing Javascript Course, it's quite expensive but I saw it as an investment in myself.
After looking into this issue there are somethings that need to happen first. Recently there was a code change that hides the "select all" when the component is filtered.
This is quite a tricky issue after thinking about it which requires quite a few code changes.
Firstly, can you sync your fork with master. I've published some changes that will make it a little easier for you to contribute, you can read Syncing a fork on how to do that. Once that's done take another look at the contributing document, I've added an example directory which allows you to view your changes as you make them.
Here is a failing test that I've written, you can paste it into Picky.test.js at line 509:
it('should select only filtered when selectAllMode is "filtered"', () => {
      // We're going to be listening for changes so we're going to need a mock function.
      const mockOnChange = jest.fn();
      // Specify the options that picky is going to use
      const options = ['Boo', 'Moon', 'Cat', 'Dog'];

      // Mount Picky with Enzyme
      const wrapper = mount(
        <Picky
          options={options}
          value={['Dog']}
          onChange={mockOnChange}
          multiple={true}
          filterDebounce={0}
          open={true}
          selectAllMode="filtered"
          includeFilter={true}
          includeSelectAll={true}
        />
      );

      /**
       *  Lets change the filter input to 'oo', this should leave us with 2 options in the filter
       *  - Moon
       *  - Boo
       */
      wrapper
        .find(sel('picky__filter__input'))
        .simulate('change', { target: { value: 'oo' } });
      // Find the Select All button in the DOM
      const selectAllButton = wrapper.find(sel('selectall'));
      // Click the select all button
      selectAllButton.simulate('click');

      // The value should be "Moon" and "Boo"
      // Dog was selected before so it should still be returned
      expect(mockOnChange).toHaveBeenLastCalledWith(['Dog', 'Boo', 'Moon']);

      // Deselect all
      selectAllButton.simulate('click');
      // Should be the original values when we deslect, as we don't want to deselect everything
      expect(mockOnChange).toHaveBeenLastCalledWith(['Dog']);

      // Remove the filter text from 'oo' to ''
      wrapper
        .find(sel('picky__filter__input'))
        .simulate('change', { target: { value: '' } });

      // Lets select all again when we have no filter
      selectAllButton.simulate('click');

      // Should return all values since we're no longer filtered and we can see every option
      expect(mockOnChange).toHaveBeenLastCalledWith([
        'Boo',
        'Moon',
        'Cat',
        'Dog',
      ]);

      // Lets deselect all when we're not filtered. This should completely remove all options
      selectAllButton.simulate('click');
      expect(mockOnChange).toHaveBeenLastCalledWith([]);
    });

Hopefully that makes sense with the comments. Now you don't need to worry about writing the test. You can just focus on adding the feature.
When you're developing, in your terminal run yarn test --watch once you've implemented the feature all tests should pass and we're good to go.

It's worth noting that I've already added the selectAllMode prop to fix a bug that this feature would have caused.
You can see it here: https://github.com/Aidurber/react-picky/pull/181

Wow thank you very for explaining everything, this is really a lot to process definitely  I will go through all of it and get back to you...

You're right there is a lot to process, and as I mentioned above you picked a really tricky issue 😁
Let me know if you have any issues, happy to help where I can.

I have done the part where it selects the filteredOptions only when select all button is clicked,
Now if the filter is cleared or changed what should Happen?
Should I simply deselect everything or select whatever filtered item remaining?

So if we stick with the Moon, Boo, Cat example.
If you search "oo" and select all, that has Moon and Boo selected.
If you clear the filter, Moon and Boo should still be selected and the list should no longer be filtered, so you should see Cat in that list.

Okay cool that is what I have done , Test case has passed  , I'm giving PR in few minutes

Nice work, I'll take a look shortly. I'll be cooking my dinner soon so it might be after that when I get to reviewing it.

going back to my previous question , if i clear the filter , moon and boo should still be selected , but happens to the select all button?

https://github.com/Aidurber/react-picky/pull/185

Okay then , feel free to create a issue so that I can try to do something . And thank you so much for you support .

What's the status on this?

@SimonChris This has been released, thanks to @HarishTeens
I've also done the work to support indeterminate checkbox states. This is in version 5, breaking changes due to a port to TypeScript and minimum React version is now 16.8.0.
Let me know if you have any issues, closing.

"Invariant Violation: Element type is invalid: expected a string (for built-in components) or a class/function (for composite components) but got: object."
I get this error whenever I try to render a Picky component with Picky 5.0. I've tried removing all the props with no effect.

@SimonChris Thank you for testing this and my apologies for breaking the build 😭 I usually symlink into a local sandbox to test the distribution but it's been like a year since I had any issues. My bad!
There seemed to be an issue with default exports and the build with CJS and ESM. I've changed Picky to a named export and updated the docs. Can you take a look at 5.0.1 when you have a chance and see if all of your issues are resolved.
import { Picky } from "react-picky";

I get the same error on 5.0.1.

Hmmm, I can't reproduce it:
https://codesandbox.io/s/simple-example-multi-and-single-select-zttud

I had to change 'import Picky from "react-picky"' to
'import { Picky } from "react-picky";'
It works now :).

Ahh 😂 I did say to do that.
I've updated the docs to reflect that, glad I made this a breaking change 😁
Thanks for all of your help @SimonChris!


Fixed sidebar

#551

Deployed to: http://staging.quran.com:33084

Deployed to: http://staging.quran.com:33085


Divide CSS file in smaller packages?

CSS file is 76 Kb minified, it would be great to be able to select only the kind of charts that we use so we can have a smaller CSS file.
For example, only include what's necessary for column charts.

Since you are using sass, can people just build their own by importing what they need ?
I do this for bootstrap-sass which works well.

IMHO whole src directory can be exported by the package


SagePayForm: Replace hardcoded encrypted params

Problem
The test requests are all hardcoded encrypted params which makes it difficult to change.
Changes
Replace the hardcoded params with dynamically encrypted ones. Now making changes to the test requests is a little easier.
Review
@ThereExistsX @ivanfer

Changes incorporated in to https://github.com/activemerchant/offsite_payments/pull/185


cambio en readme

Related issue

What changes does this PR do?
Screenshots (If any)
Questions

he cambiado el readme


Can Energy be set to Zero in software?

I know the Energy can be set to zero with the key in the LCD display or pressing the reset button on the board but I wondered if there was also a software hack?
If the Pzem is used for remote monitoring there will be nobody around to reset the Energy when each electric bill arrives and is validated as OK.
I have sent a message to Peacefair but just wondered of anyone had found a hack?

Peacefair have replied and said there is no software hack to reset Energy, shame.

I think this could be done with a help of one more optocoupler connected to the button and any mcu pin controlled via software.

@pieman64 I guess we can close the issue?

Yes @olehs ok to close.


Performance app crashes

The performance app may have multiple issues.

Currently it crashes before opening, though @lilleyse found a fix for that (PR pending).
Once that is in place and the app opens, however, clicking a first location works but then the app crashes when a second location is selected. This may be an extension of #425, though notably still happens after that workaround was merged.

I don't see the crashes anymore, most likely fixed by https://github.com/CesiumGS/cesium-omniverse/pull/455.
Though sometimes the tilesets don't load at all when switching between locations...

I also don't see crashes anymore. Closing.


build: CI tasks are failed on testing loading coprocessor plugins.

Bug Report
Introduced by #17466, which has cleared the dependency on example_coprocessor_plugin. And it will cause TiKV failed on related UTs, such as registry_load_and_get_plugin, as the testing lib is not built when building.

And as we can see, the related plugin lib is not built:

What version of TiKV are you using?

Nightly: 3635ff2c8b12015ce379bb5c8e4839af774190a8
What operating system and CPU are you using?

MacOS and Linux-centos.
Steps to reproduce

Clean all caches by make clean, then tests with make nextest.
What did you expect?
Related UTs should be normal.
What did happened?
Related UTs are failed as followings show:
https://do.pingcap.net/jenkins/blue/organizations/jenkins/tikv%2Ftikv%2Frelease-8.4%2Fpull_unit_test/detail/pull_unit_test/11/pipeline/84/

Thx for the help from @purelind and @wuhuizuo .


vendor: switch location of goautoneg to github

What type of PR is this?
/kind failing-test
What does does this PR do / why we need it:
CI jobs are failing on
go<EMAIL_ADDRESS>requires
<EMAIL_ADDRESS>reading https://api.bitbucket.org/2.0/repositories/ww/goautoneg?fields=scm: 404 Not Found

original bitbucket repo is mercurial repo that is unstable and mercurial support on bitbucket is being deprecated
Which issue(s) this PR fixes:
Fixes https://github.com/openshift/odo/issues/3983
PR acceptance criteria:

[ ] Unit test

[ ] Integration test

[ ] Documentation

[ ] I have read the test guidelines

How to test changes / Special notes to the reviewer:

/lgtm

/approve


Build failure: syslinux-unstable and xen and libvirt after staging-next 2024-12-04 #361878

Steps To Reproduce
Steps to reproduce the behavior:

build libvirt

Build log

note: keeping build directory '/tmp/nix-build-syslinux-unstable-2019-02-07.drv-2/build'
error: builder for '/nix/store/wxw7sqwsskv6kg7b6j20zai8fhzkmxh9-syslinux-unstable-2019-02-07.drv' failed with exit code 2;
       last 25 log lines:
       > /build/source/com32/chain/chain.c:172:35: warning: cast from pointer to integer of different size []
       >   172 |                                   (addr_t) data[i].data, data[i].size))
       >       |                                   ^
       > /build/source/com32/chain/chain.c:246:53: warning: cast from pointer to integer of different size []
       >   246 |         if (syslinux_add_movelist(&mlist, endimage, (addr_t) swapstub,
       >       |                                                     ^
       > /build/source/com32/chain/chain.c: In function 'main':
       > /build/source/com32/chain/chain.c:517:44: error: passing argument 3 of 'loadfile' from incompatible pointer type []
       >   517 |         if (loadfile(opt.file, &fdat.data, &fdat.size)) {
       >       |                                            ^~~~~~~~~~
       >       |                                            |
       >       |                                            addr_t * {aka unsigned int *}
       > In file included from /build/source/com32/chain/chain.c:32:
       > /build/source/com32/include/syslinux/loadfile.h:11:37: note: expected 'size_t *' {aka 'long unsigned int *'} but argument is of type 'addr_t *' {aka 'unsigned int *'}
       >    11 | int loadfile(const char *, void **, size_t *);
       >       |                                     ^~~~~~~~
       > make[4]: *** [/build/source/com32/chain/Makefile:28: chain.o] Error 1
       > make[4]: Leaving directory '/build/source/efi64/com32/chain'
       > make[3]: *** [/build/source/com32/Makefile:8: chain] Error 2
       > make[3]: Leaving directory '/build/source/efi64/com32'
       > make[2]: *** [/build/source/Makefile:288: com32] Error 2
       > make[2]: Leaving directory '/build/source/efi64'
       > make[1]: *** [/build/source/Makefile:272: efi64] Error 2
       > make[1]: Leaving directory '/build/source'
       > make: *** [Makefile:102: bios] Error 2
       For full logs, run 'nix log /nix/store/wxw7sqwsskv6kg7b6j20zai8fhzkmxh9-syslinux-unstable-2019-02-07.drv'.

Additional context

Metadata

Notify maintainers
@fpletz
@globin
@lovesegfault

Note for maintainers: Please tag this issue in your PR.

Add a :+1: reaction to issues you find important.

@fpletz @globin @lovesegfault
Can you make zen as an option, please?

@gador Thank you!
Fixed with #367948


Remove LOB as not supported in shared-channels.md

Closes https://github.com/MicrosoftDocs/OfficeDocs-SkypeForBusiness/issues/9187.

@MikePlumleyMSFT, please confirm/review. Thanks!

Docs Build status updates of commit 3723a5b:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

Teams/shared-channels.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


Validator conflicts with datepicker

Validator won't accept the value of a datepicker field as input.

Please give more details.

Hi,
I'm using http://www.eyecon.ro/bootstrap-datepicker/  for a date to and form field:

 to

The parameters are as follows:
$(function() {
var nowTemp = new Date();
var now = new Date(nowTemp.getFullYear(), nowTemp.getMonth(), nowTemp.getDate(), 0, 0, 0, 0);
var checkin = $('#dpd1').datepicker({
onRender: function(date) {
return date.valueOf() < now.valueOf() ? 'disabled' : '';
}
}).on('changeDate', function(ev) {
if (ev.date.valueOf() > checkout.date.valueOf()) {
var newDate = new Date(ev.date)
newDate.setDate(newDate.getDate() + 1);
checkout.setValue(newDate);
}
checkin.hide();
$('#dpd2')[0].focus();
}).data('datepicker');
var checkout = $('#dpd2').datepicker({
onRender: function(date) {
return date.valueOf() <= checkin.date.valueOf() ? 'disabled' : '';
}
}).on('changeDate', function(ev) {
checkout.hide();
$('input[type="submit"]').removeAttr('disabled');
}).data('datepicker');
});
However, I cannot proceed with submission because the validate.js is not accepting the dates as completed.  Any ideas?

The validator shouldn't be complaining about anything because those inputs don't have any validation attributes on them. Are you sure this example matches what you have in your code?

Sorry I removed the validation off them because they weren't working. Assume they have required written on them.

Can you put your whole form markup here? I've already included the validator and datepicker scripts.
http://jsbin.com/girizecucu/edit?html,css,js,output

Ok, I have tried this link but for some reason the calendar doesn't work, in this bin. Try using this as one page (I don't think you can use www.eyecon.ro as a cdn)

//REPLACE ABOVE LOCALLY

JS Bin

Title

Dates

 to

//REPLACE ABOVE LOCALLY

You may need to download the datepicker.

the date picker I am using triggers after the validator has already detected the field is empty and I get an error even though the field is valid. Anyway to fix?

At this point, I'd say your best bet is to ask this question StackOverflow. I'd like to get away from the habit of using the issue tracker as a support forum for integrating with other third-party libraries as it makes it hard to focus on bugs in the plugin itself.


[AKS][DO NOT MERGE] Add support for updating tags

Description

Add support for updating tags of the cluster in aks update.
Testing Guide

History Notes

[Component Name 1] BREAKING CHANGE: az command a: Make some customer-facing breaking change.
[Component Name 2] az command b: Add some customer-facing feature.

This checklist is used to make sure that common guidelines for a pull request are followed.

[ ] The PR title and description has followed the guideline in Submitting Pull Requests.

[ ] I adhere to the Command Guidelines.

[ ] I adhere to the Error Handling Guidelines.

AKS


Fix flaky CheckReportDisable test.

https://github.com/istio/istio/issues/4265

@qiwzhang: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
0d5fa46ce202395155f4ba29d93eac5c3a88ebf1
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


Website is down

Reproduction
https://formkit.com/
Describe the bug
Formkit documentation is not accessible.
Environment
• OS: [e.g. iOS]
• Browser [e.g. chrome, safari]
• Version [e.g. 22]

@Ochoja I'm not seeing this on my end. Are there any errors you are seeing in your dev tools/anyway to reproduce?

This has been the result for me for the past 1 week

@Ochoja We're having a hard time replicating this. I'll reopen this for now in case other people are running into the same issue.

Same issue


I've tested based on issue #275 the download CSV

Using data instead of displayData? there's a specific functionality missing if we use data? we can prevent the React elements?

Coverage remained the same at 78.018% when pulling f65a656161af6d8a2b938c20da19f47468985233 on diegochavez:patch-1 into a18125bd96bd2df0f39d3817ca62d8094f10ee1f on gregnb:master.

With this change I am able to set toString on data objects and make the result show up in the generated CSV.

Thanks for resolving this issue. Merged!

where is the file "MUIDataTableToolbar.js" location?

Still having this issue on nested objects. https://codesandbox.io/s/mutable-darkness-685n4?file=/src/index.js


[test-case-reporting] Improve e2e tests

This is still a draft because the tests are still failing & I don't know what's wrong.
Based off of https://github.com/ampproject/amp-github-apps/pull/943

Finally figured out the bug! Each call to dbConnect() was making a new database, so setupDb was getting called on a different database than the one app.ts was using.


feat: method calculating refund amount

adding method that allows client to determine amount of refund based on order and order's owner market position.

If we're happy with this one today we can hopefully get it included in the v0.13.0 release branch.


Add jsDelivr hits badge

Hey, I noticed that qTip2 is the 16th most popular project on jsDelivr (congrats! :tada:), so I thought you might like this badge.

And here's my thinking the project wasn't as popular as it used to be :) Thanks!


The "Explore the curriculum" button does nothing

Describe your problem and - if possible - how to reproduce it
Clicking on "Explore the curriculum" in the main "Learn" page doesn't do anything.
Add a Link to the page with the problem
https://learn.freecodecamp.org/
Tell us about your browser and operating system

Browser Name: Chrome
Browser Version: 66.0.3359.139 (Official Build) (64-bit)
Operating System: Windows 10 Home

If possible, add a screenshot here

My Browser Name--- Opera
Its 32-Bit
Same Problem

@udidol are you still having this problem? I think it has been fixed - if it's working you can close this issue

@moT01
When I removed the id="" attribute it let me pass the lesson.
Isn't this still a bug since having an id attribute in the <audio> tag still prevents passing the lesson?

@udidol you are referencing an unrelated lesson in your last comment - this issue mentioned the Explore the curriculum button doing nothing - it should be fixed now as learn redirects directly to the curriculum - you should verify that it is working now and close this if it is

@moT01 You are right! I accidentally mixed this issue with a different one, apologies.
Yes, it seems to be fixed. Closing the issue.


Sending data to server from Raspberry Pi

We wanted to start thinking about data transfer from the raspberry pi.
Right now, we are thinking we'll need to create an endpoint to post the data from the images to.
Does it work the same way as it would when we run flask app locally?
Is there a particular package we have to use to post data from raspberry pi to the server our service is being implemented on?
Insights much appreciated!

Hey @yashasaxena, happy to provide some thoughts!
So you have the right idea here that you would need to create an endpoint on a server to receive data from the Raspberry Pi (RPi) to get data off of the Pi. Ultimately what you would want to do is have a program running on the RPi client to acquire an image, transform that data into a base64 string (we talked about this process in class) and then POST that to a server URL.
Ultimately you have two python programs here. One is the server program (the Flask application) which would run on your cloud server as per usual. You will then have a client python application running on the RPi. To issue RESTful API requests from your client python program, you can use the requests library.
Let me know if you have any other questions!

Ok great thanks, I'll look into the requests library.
As far as acquiring the image on the raspberry pi,
should we plan to save images on the raspberry pi sd card or use a separate USB SD card reader or some other method?
appreciate the feedback

You can pick whichever you would prefer--loading the images from a folder on the SD card (or any other media) is totally fine. It's just to simulate a "source" for the images (the folder could be replaced with a camera in the future or something)!

So to clarify, as long as you have a program on your RPi that can read images from a folder, upload them to the server using a RESTful API, and successfully get a response, you are good!

Alright, so referencing an issue brought up on our RFC regarding endpoint set up -->
If I'm posting the image data from the RPi to a server URL,
how can the data that was posted to that server URL be requested from a FLASK APP request?
@ad12 mentioned that we shouldn't have the same endpoint used in more than one request of the same type
I'm a little confused on how to go about this. The only thing that comes to mind is having the Raspberry Pi store the data in a non-local database, but I also don't know how to do that.


Blocks pulled by slime blocks pay again

*Description of issue:
If a block is pulled by a slime block, it is paying money again, even if it was placed by hand. The block has to be pulled, the bug does not occur if the block is pushed or moved along with the slime block. Here is an exemplary picture (the diamond block on the right pays again).
**Server Type (Spigot/Paperspigot/etc): Paper
**Server Version (using /ver): 1.15.2-378
**Jobs Version: 4.16.1

So basically if the block pushed by piston and slime block then should pay, because it changed the position, right? But if the block pushed by piston & slime block and the pistopn extended back, then it shouldn't pay?

Woops, sorry for not being very specific there. So, essentially blocks that are on the list of restricted blocks should not pay at all when you place them and then break them again (like this gold ore). However, this protection can be bypassed by pulling them with a slime block (as shown in the screenshot).


[RR Request]: fipv v1.0.0

Open Source Project name
fipv
What is your project?
fipv (fast ip validator) is a python package build with C language. Simply it includes basic IP address validator functions as a C function, so works faster than others.
Version
1.0.0
Date
May 7, 2023
Description of breaking changes
[1.0.0] - 2023-05-07
Added

Added project documentation page on github pages.
New python version tests.

Changed

Minimum required python version upgraded to 3.9.
Make compatiable for new python versions.

GitHub Repo
https://github.com/eredotpkfr/fipv
Website
https://www.erdoganyoksul.com/fipv/
Link to changelog
https://github.com/eredotpkfr/fipv/blob/main/CHANGELOG.md
Social media
https://twitter.com/eredot_pkfr/status/1655227141494013957
Anything else to add?
No response

Thanks for submitting your project. We had a lot of projects submitted for our latest Release Radar and we couldn't include them all. Please submit your project again for consideration when you have version 2.0.


[KAFKA] Make conversion from old style config to new ServiceSpec style config automatic

retest this please

retest this please

Do not review. Do not merge

Retest this please

Retest this please


Articles synced via FeedBin do not update in NNW when the published version is updated

I have all of my feeds synced via FeedBin. NNW seems to grab the content of articles one time, and never updates them even if the source updates.
For example, this article on DaringFireball has a placeholder instead of a link: https://daringfireball.net/2020/11/disclosing_a_few_thoughts_on_facebooks_ui_design The article started as "I ran into [this piece at MacRumors] about Facebook", and then later the "[this piece at MacRumors]" part was changed to a valid link.
If I view the article in NNW, I still see the placeholder. If I log into FeedBin directly, it has updated correctly. There seems to be no way to even force a refresh in NNW for it to pull the latest, correct version.
I have seen this for a while, and in some cases, gone back to the article in NNW a week or so later and it still has the old information, never seeing content changes when an article has been updated.
Current version of NNW: Version 5.1.2 (3016) (macOS). This report is for the macOS version of NNW, however I believe it's also an issue with the iOS version (just not 100% sure right now).

@benubois Currently we are doing the following to get new and updated article content:
https://api.feedbin.com/v2/entries.json?since=2020-11-04T21:09:07.000000Z&per_page=100&mode=extended
I did some debugging and I don't think we are getting updated articles with the since parameter.  Only new ones.  Am I wrong or do I need to do something else to get the updated articles?

Hi @vincode-io,
The since parameter refers to entries published since the value.
Most article corrections occur pretty quickly, so one change you could make is to backdate since to something like last_sync_date - 1.day.
There's also the Updated Entries API. This can give you IDs of articles with significant changes to the content. This one also supports a since parameter that refers to the updated date.
For example here is an article that had follow-up content added to it later. Feedbin has a special section for these to call attention to the fact that significant content has been added.

@DaveWoodCom We've made a change that will pick up any edits made within 24 hours of the original post being made.  This is the best compromise we make with regards to syncing performance and getting the edits.  These edits may take up to 24 hours to appear, but you can force them to appear by restarting NetNewsWire and doing a Feedbin sync.
This change will be coming in NetNewsWire 6.0.

Thanks. That sounds like a good solution given the way the API works.


Terraform CI

Merges to master ought to trigger a terraform apply operation and update the "deployed version" automatically - Github actions and S3 state storage should be enough to enable this.

May be worth looking at Terraform Cloud as well. Has some nice functionality, like running plans automatically for each PR (and marking the PR build as "failed" if it doesn't work).
It's very new, but I've been pretty happy with it on other projects.


Updated version of parent

Coverage remained the same at 57.168% when pulling 40f5133ae787217c33a2af0d0a65c610e546494d on fixing-versions into e03f3cb8e1bc28238f3c19e424d50f3a00f6bc18 on master.

maybe a line in the changelog would be good?

maybe a line in the changelog would be good?

not a user facing change and this was just forgotten in previous commits. The main pom was bumped but the modules weren't


Version 1.95 does not connect to the container with distrobox

Does this issue occur when all extensions are disabled?: Yes/No

VS Code Version:  1.95
OS Version: Linux Mint 22 Cinnamon
Distrobox with Podman

Steps to Reproduce:

Start ubuntu container with Distrobox
Start VS Code and try to Attach to running container
The vscode dropdown menu list runing "ubuntu" container as always
But dont connect and displays a message stating that the "ubuntu" container does not exist.

It worked perfectly until version 1.94.
Nothing was done other than updating vscode to 1.95
What was attempted to solve:

Uninstall and install version 1.95 again.
Uninstall and install the Dev Container extension.
Tried with pre-release version of Dev Container

Finally I uninstalled version 1.95 and installed version 1.94 and it worked as usual again.

Please append the Dev Containers log from when this happens. (F1 > Dev Containers: Show Container Log)


make: numerically compare the major version of pandoc to be greater then or equal to 2

IMPORTANT: PRs without the template will be CLOSED
Fix man page being built without smart-markdown, because pandoc versions greater 2 are not detected properly

The makefile had a hardcoded major version check of pandoc against 2. In my pandoc 3 installation the check failed and smart-markdown was not used, even though it is available. That caused double dashes to be rendered as single, long dashes.
This fix causes make to numerically compare the major version to be greater then or equal to 2.
Fixes #7046
Template

Before submitting a pull request make sure you have:

[x] At least skimmed through contributing guidelines including yt-dlp coding conventions
[x] Searched the bugtracker for similar pull requests
[x] Checked the code with flake8 and ran relevant tests

In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check all of the following options that apply:

[x] I am the original author of this code and I am willing to release it under Unlicense
[ ] I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

[ ] Fix or improvement to an extractor (Make sure to add/update tests)
[ ] New extractor (Piracy websites will not be accepted)
[x] Core bug fix/improvement
[ ] New feature (It is strongly recommended to open an issue first)

Have you tested the resulting file with pandoc 3 is correct? You can try diffing with pandoc 2 result.

Have you tested the resulting file with pandoc 3 is correct? You can try diffing with pandoc 2 result.

> pandoc -v
pandoc 3.1.2
Features: +server +lua
Scripting engine: Lua 5.4
User data directory: /home/ra1n/.local/share/pandoc
Copyright (C) 2006-2023 John MacFarlane. Web:  https://pandoc.org
This is free software; see the source for copying conditions. There is no
warranty, not even for merchantability or fitness for a particular purpose.
> pandoc2 -v
pandoc2 2.19.2
Compiled with pandoc-types <IP_ADDRESS>, texmath <IP_ADDRESS>, skylighting 0.13,
citeproc <IP_ADDRESS>, ipynb 0.2, hslua 2.2.1
Scripting engine: Lua 5.4
User data directory: /home/ra1n/.local/share/pandoc
Copyright (C) 2006-2022 John MacFarlane. Web:  https://pandoc.org
This is free software; see the source for copying conditions. There is no
warranty, not even for merchantability or fitness for a particular purpose.

pandoc -s -f markdown-smart -t man yt-dlp.1.temp.md -o yt-dlp.1
pandoc2 -s -f markdown-smart -t man yt-dlp.1.temp.md -o yt-dlp.1_pandoc2
diff yt-dlp.1*

With the commands displayed above, the diff is empty on my side. I think the change can be pushed.

@pukkandan Why has this not been merged until now ?


@stacksjs/cloud

Clear and concise description of the problem
A zero-config way to maintain and deploy into serverless infrastructure.
Suggested solution
Utilize the Serverless framework & create an optimized Stacks template/s.
Alternative
No response
Additional context
No response
Validations

[X] Follow our Code of Conduct
[X] Read the Contributing Guide.
[X] Check that there isn't already an issue that request the same feature to avoid creating a duplicate.

I have never quite liked the concept of calling it "serverless" infrastructure. Kind of misleading. "Cloud" is better 😃


fix: reuses shared object mapper instead of recreating them

Fixes #786

code coverage is expected to fail at this stage


Issue warning for duplicate items (Compile, Reference, ProjectReference)

Should the new project system issue a warning when it detects duplicate items? It'd be nice to have a built-in diagnostic to detect this kind of situation and report to the user.

Hmm, I'm split on this. I do not want the project system to issue errors and warnings that MSBuild itself does not produce - otherwise, it leads to developers not trusting the Error List (because they build via the command-line or switch category -> Build) and these errors/warnings go away. Maybe a target that detects this?

You're right, I should have filed this against MSBuild in the first place.
Filed https://github.com/Microsoft/msbuild/issues/804.


Error occurs when joining two models after changing their metabolite IDs

Hi, I am trying to build a community for two models and I've already changed the metabolite IDs for each model. I renamed the metabolite IDs as  +  such as C12145cytoplasm ('C12145' is KEGG ID and 'cytoplasm' is the name of the compartment). Firstly one thing I'd like to double-check is that do I need to change the compartment ID as well even though I didn't use the compartment ID for matching models?
Secondly, when I tried to join the two renamed models an error occurred:
File "/Users/wintermute/opt/anaconda3/lib/python3.7/urllib/parse.py", line 107, in <genexpr>
    return tuple(x.decode(encoding, errors) if x else '' for x in args)
AttributeError: 'Model' object has no attribute 'decode'

Here is my code:
sc = micom.util.load_model('/Users/wintermute/OneDrive - University of Cambridge/cambridge/during_cam/Department/work/code/coculture/yeast7.6_changeID_final.xml')

kp = micom.util.load_model('/Users/wintermute/OneDrive - University of Cambridge/cambridge/during_cam/Department/work/code/coculture/KP_changeID_final3.xml')

community = [sc,kp]

micom.util.join_models(community)

Does anyone have any idea about that? Thanks.

join_models expects a list of filepaths or urls as models and not loaded models. It will figure out how to load the models itself. So just skip the load_model step and use the filepaths. However, I'm wondering if that is want you want to do. This will essentially build a pangenome model of the two models. If you want a community model where both species grow in a shared growth medium this should be done with micom.Community.

Yeah, actually you're right that the community model is what I want, but when I looked though micom.util module it doesn't talk about building a pangenome model so I thought it would just help me join the models together and then let them grow in one shared environment. Is there any command in micom.Community that could make the two .XML files with same metabolite ID a new model? Thanks.

micom.Community does exactly that :smile: For general usage the official docs are probably more informative than the docstrings. For instance have a look at https://micom-dev.github.io/micom/community.html.

Thank you! I've successfully built a community model with that! Appreciate your help!


File Upload

Is a file uploads feature in the roadmap?

Note: Angular currently (as of 1.4) does not support the file input

Note: Not every feature offered is available for all input types. Specifically, data binding and event handling via ng-model is unsupported for input[file].

If angular would support input[file] and 'normalize' the file's data, I would look into adding the ability for angular-sails to send a file.  But as of now, the file API that browsers have is only a working draft and is not implemented in all of the browser that angular tries to support.


The diff coverage is 100%.

@@             Coverage Diff             @@
##           dev-1.5     #249      +/-   ##
===========================================
+ Coverage    14.16%   14.17%   +<.01%
===========================================
  Files          280      280
  Lines        19157    19160       +3
===========================================
+ Hits          2713     2715       +2
- Misses       16444    16445       +1

Impacted Files
Coverage Δ

libstorage/LevelDBStorage.cpp
100% <100%> (ø)
:arrow_up:

libstorage/DBFactoryPrecompiled.cpp
96.42% <100%> (+0.06%)
:arrow_up:

...ttest/libprecompiled/test_DBFactoryPrecompiled.cpp
95.58% <0%> (-1.48%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4461ea8...e5e8b39. Read the comment docs.


audiounit: Handle device change callback coalescing

Handle the case that audio device of the same type coalescing. The general idea is that devids are stored in arrays which are compared when the number of devices before and after change is the same. Also added to unregister callback in cubeb_destroy if necessary.
PR is addressing issue #85

Thanks Alex!


feat: implement s2g tranform

Fixes #49
Draft because it needs some tests and some manual testing with data (either fake, or simulated or real). I'll ask the IDS.
Maybe we should also integrate it with the workflow pipeline and add an example using this in the workflow.

Some very preliminary results
I've applied the transformation to the results in the dream-data-reduction.ipynb example notebook file.
The issue instructions says
S(Q) = \frac{I_\mathsf{coh}(Q) - \sum c_i{|f_i(Q)|}^2}{{|\sum c_i f_i(Q)|}^2} + 1

but I've taken $S(Q)$ to be $I(Q)$ instead where $I(Q)$ is the sample intensity divided by the vanadium intensity.
Here's what $I(Q)$ looks like

and here are the resulting $g(r)$ when using the transform with/without the sinc-filter:

I don't know what the expected results are or what kind of sample this data comes from (it's simulated right?).

I don't think the Lorch filtering makes sense. Seems like it just convolves the output $D(r)$ with a flat window function. Applying the filter or using np.convolve(pdf_default.data.values, np.ones(K)/K, 'same') looks virtually identical if you choose an appropriate K. That indicates to me it doesn't actually deal with the spurious oscillations, it just sweeps them under the rug so to speak, and while doing that it also smooths the physical component of D(r).
Maybe that doesn't matter, if the subsequent data-analysis doesn't care about the widths of the peaks in D(r) then the smoothing procedure maybe doesn't do much harm.
But unless it's something that is explicitly asked for, so far it isn't, I think we should skip it.

I don't think the Lorch filtering makes sense. Seems like it just convolves the output with a flat window function. Applying the filter or using np.convolve(pdf_default.data.values, np.ones(K)/K, 'same') looks virtually identical if you choose an appropriate K. That indicates it doesn't actually deal with the spurious oscillations, it just sweeps them under the rug so to speak, and while doing that it also smooths the physical component of D(r).

This sounds like what people write elsewhere. They smooth out the curve to remove oscillations.
I guess it depends on whether the change to the physical signal is less bad than having the spurious oscillations.

But unless it's something that is explicitly asked for, so far it isn't, I think we should drop the Lorch filtering from this PR.

:+1: I agree. Remove it from this PR. We can always add it later if required.

Can you try and figure out the value of $\rho$ that you need to reproduce the example? And then plot the results in the same figure as well as their difference? We should do a proper comparison to check that we are doing the right thing.

Can you try and figure out the value of that you need to reproduce the example? And then plot the results in the same figure as well as their difference? We should do a proper comparison to check that we are doing the right thing.

:+1: I have a meeting with Celine on Thursday, I'll bring that up with her.

Visualization of the covariance matrix:

Looks like low correlations. But you can compute a correlation matrix (Pearson r) and show r - np.eye(r.shape[0])?

Is it expected that there are negative values in the correlation matrix?

Is it expected that there are negative values in the correlation matrix?

It's expected. A negative covariance basically means, given that this entry increased it's likely the other entry decreased. That could happen if there's, for example, uncertainty in the position of a peak but not it's overall shape. Moving the peak increases some entries and decreases others. The entries affected will have a negative covariance.

Looks like low correlations. But you can compute a correlation matrix (Pearson r) and show r - np.eye(r.shape[0])?

Please explain why you want me to do that

Please explain why you want me to do that

Because the correlation matrix is easier to interpret. The covariances matrix can only be interpreted in combination with the mean values. The correlation matrix has values in [-1, 1]. And I asked for the -eye to remove self-correlations which would make the plot harder to read.

Here is a visualization of the correlation matrix minus the diagonal:

and the same but zoomed in on the lower left corner:

So we have basically 100% correlation between ~10 neighbours for most elements. And fairly strong anti-correlations for slightly farther away elements. This on its own does not mean that follow up operations are wrong if they neglect correlations. But it seems to strongly suggest so.
We should follow up on it with scientists and see if their fits change when they take correlations into account. But for now, I think we should definitely return the covariance matrix.

So we have basically 100% correlation between ~10 neighbours for most elements. And fairly strong anti-correlations for slightly farther away elements. This on its own does not mean that follow up operations are wrong if they neglect correlations. But it seems to strongly suggest so.

Strong correlations between neighboring elements is expected.
I'd expect the width (in terms of pixels) of the region of strong correlation should grow with the density of the output grid (the r-grid).
That there are strong correlations across ~10 neighbors here just indicates I've used a too dense output grid.
Having a too-dense output grid is of course not good, but it would surprise me if later fitting procedures were badly affected by it, unless they are fitting very high frequency components of r, and that seems unlikely.


Testing improvements

migrating to container-based infrastructure in travis-ci
configure pytest with setup.cfg
test sphinx docs with pytest
more python versions to test in travis-ci

For some reason travis-ci doesn't start testing after rebase.

Looks good. Thanks.


HBASE-28468: Integration of time-based priority caching in eviction logic.

HBASE-28468: Integration of time-based priority caching in eviction logic.
The time-based priority caching relies on the presence of file paths in the block-cache key.
However, in case of the persitent cache, the file paths are not persisted in the files.
Hence, when the region server is restarted, the block cache keys need to be
repopulated with the file paths.
This change addresses the following:

Always populate the block-cache key with path during its creation.
Fetch the file paths corresponding to the file names of the block-cache key
during restarts.
Use the Data-Tiering-Manager APIs during cache-full scenario to evict the cold file blocks.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m  0s
Docker mode activated.

-1 :x:
docker
1m 24s
Docker failed to build yetus/hbase:8a715fadd5.

Subsystem
Report/Notes

GITHUB PR
https://github.com/apache/hbase/pull/5826

JIRA Issue
HBASE-28468

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5826/1/console

versions
git=2.17.1

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

You are passing @vinayakphegde 's commit together with yours in this PR, and this is causing conflicts with the target branch (the PR can't be merged). Please rebase your local branch first, resolve any conflicts locally and force push to your branch, making sure the PR is mergeable.

Ack!

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 49s
Docker mode activated.

-0 :warning:
yetus
0m  2s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ HBASE-28463 Compile Tests _

+1 :green_heart:
mvninstall
3m  5s
HBASE-28463 passed

+1 :green_heart:
compile
0m 51s
HBASE-28463 passed

+1 :green_heart:
shadedjars
5m 17s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 27s
HBASE-28463 passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
2m 49s
the patch passed

+1 :green_heart:
compile
0m 51s
the patch passed

+1 :green_heart:
javac
0m 51s
the patch passed

+1 :green_heart:
shadedjars
5m 13s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 26s
the patch passed

_ Other Tests _

-1 :x:
unit
243m  6s
hbase-server in the patch failed.

269m 17s

Subsystem
Report/Notes

Docker
ClientAPI=1.45 ServerAPI=1.45 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5826/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5826

JIRA Issue
HBASE-28468

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux ca34f533425f 5.4.0-172-generic #190-Ubuntu SMP Fri Feb 2 23:24:22 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
HBASE-28463 / b7bb8b9d27

Default Java
Eclipse Adoptium-11.0.17+8

unit
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5826/1/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5826/1/testReport/

Max. process+thread count
5087 (vs. ulimit of 30000)

modules
C: hbase-server U: hbase-server

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5826/1/console

versions
git=2.34.1 maven=3.8.6

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 26s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ HBASE-28463 Compile Tests _

+1 :green_heart:
mvninstall
2m 47s
HBASE-28463 passed

+1 :green_heart:
compile
0m 41s
HBASE-28463 passed

+1 :green_heart:
shadedjars
5m 45s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 25s
HBASE-28463 passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
2m 29s
the patch passed

+1 :green_heart:
compile
0m 41s
the patch passed

+1 :green_heart:
javac
0m 41s
the patch passed

+1 :green_heart:
shadedjars
5m 46s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 23s
the patch passed

_ Other Tests _

-1 :x:
unit
247m 40s
hbase-server in the patch failed.

271m 56s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5826/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5826

JIRA Issue
HBASE-28468

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux f1920bd54ea5 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
HBASE-28463 / b7bb8b9d27

Default Java
Temurin-1.8.0_352-b08

unit
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5826/1/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5826/1/testReport/

Max. process+thread count
4768 (vs. ulimit of 30000)

modules
C: hbase-server U: hbase-server

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5826/1/console

versions
git=2.34.1 maven=3.8.6

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Can we close this PR and favour the #5829 as the solution for HBASE-28468?

Can we close this PR and favour the #5829 as the solution for HBASE-28468?

ack!

Closing this PR in favour of https://github.com/apache/hbase/pull/5829 as the solution for HBASE-28468?


Expose reporter(s) & reportDir via package.json config?

I'm interested in moving --reportDir=tests/output/coverage --reporter=html into the package.json "nyc" config object, but don't know if that's something anyone else would see as being valuable.

@jameswomack sounds like a great configuration option, no objection here :+1:

For that matter, there should be 100% config parity between the CLI and the package.json config.
CLI should take priority, defaulting to the config (which in turn defaults to our set of "sensible" defaults).

@jamestalmage That's what seems intuitive to me

<EMAIL_ADDRESS>is slowly plodding along, this almost feels like something that could be handled by yargs eventually.
I like that both ava and yargs have moved towards using a prefix in the package.json for their config -- one could imagine a world where someone indicates that yargs should automatically parse this stanza and use it to override default settings.

... perhaps we could add this on the yargs 4.x branch, and I could start publishing a 4.x tag of yargs to npm?

perhaps we could add this on the yargs 4.x branch

:+1: The only contentious discussion we had w/ regard to this behavior in AVA, was what to do with array based args (i.e. ava --require babel/register --require some-other-module). What do you do to the require array in package.json if a --require option is used?

The other suggestion was that we append to the existing array. I argued against this because there's no good way to remove items from the default array.
I think our decisions make sense for a --require and --reporter flags. I guess it's possible there's some option out there where appending would be desired. I'm not coming up with one though.

For that matter, there should be 100% config parity between the CLI and the package.json config.
CLI should take priority, defaulting to the config (which in turn defaults to our set of "sensible" defaults).

:+1: That's been working very well for AVA and XO.

I think our decisions make sense for a --require and --reporter flags.

I too feel we made the right choice with that.

Just a note that any implementation done for these options, should also be done for the new --extension arg / config setting that is now implemented in pull request #163.

It seems this does not work for the  --reporter option - the values in package.json always seem to win for me?


Need for additional test unit

Write test unit for post requests (JSON or not)

Done, as of commit 981248e


PKGBUILD: Also use make for installing

And I switched that one back to /usr instead of /usr/local, because the AUR is part of the distribution.

I am not completely fluent with PKGBUILDs, what does specifying /usr do here rather than just make and sudo make install

I basically don't know anything about PKGBUILDs. I also didn't change anything about the PKGBUILD specific stuff. I only changed your manual install command to use make, because why duplicate code? And I just used make install PREFIX=... to install into a custom prefix.
I wouldn't know any reason to use sudo, because you're not trying to install into any protected directory. (at least I assume pkgdir isn't; as I said, I don't know a lot about PKGBUILDs)

This makes sense. I have seen a lot of PKGBUILD's that use this method.

Did you test this?
It doesn't work on my machine.

Oh, it doesn't work on mine, either. I'm pretty sure I know why though: install does some kind of magic that cp doesn't, so using cp doesn't work. The fix for that is pretty easy: Use install in the makefile.

We can just add a new Makefile command if you want, specifically for Arch

I think that would be a really bad idea, something like a INSTALLFLAGS variable would make more sense, but I checked and most AUR packages just do the horrible hacks in the PKGBUILD.

Give your suggestion on either PR, and I'll review, test and review again respectively.

I think that would be a really bad idea, something like a INSTALLFLAGS variable would make more sense, but I checked and most AUR packages just do the horrible hacks in the PKGBUILD.

What sort of hacks do you mean?
Makefile? Or install?

What sort of hacks do you mean?

install -m 755 -D $binary "${pkgdir}/usr/local/bin/$binary"


protocol: update node-avdl-compiler comments for 1.4.2

Looks like the version used by CI changed, so all CI runs fail on this diff now.

Merging over unrelated test flake.


some issues with vignettes

Some of the outputs in our vignettes don't look right on the website. Can this be addressed?
e.g.
https://morinlab.github.io/GAMBLR/articles/utilities_tutorial.html#compare-cnvs-for-multiple-samples
The heatmap in this example has many cluttered/overlapping column labels.
https://morinlab.github.io/GAMBLR/articles/ssm_tutorial.html#lollipop-plot
I don't see a lollipop plot in this example (just an empty white space)
https://morinlab.github.io/GAMBLR/articles/ssm_tutorial.html#rainbow-plots
Does aSHM multi-rainbow plot print out the entire data frame of regions by default? If so, this should be shifted to functionality that only happens in a "verbose" mode because the table shown in the vignette is huge and probably unnecessary.

Thanks, Ryan, I'll go over these. I knew there are a few weird formatting issues with the figures that I also hope to resolve.


Add metrics reguarding notification duration

It would be great to have an histogram with the notifications duration (per integration).

closed by #1335


Rename mocktest.sh to mock_test.sh in Makefile

This changes the reference to match the file names in both projects.

I merged this in a separate PR, thanks for the contribution


Make result bubble appear consistent

Put the result bubble in the right place with run-all  and run-all-above commands.
They appear at the last not empty line.

Boo, don't use while - nobody is secured from endless loops. You can always omit it with
for ... when in coffee style
or
_.filter if you prefer going functional
Another way to achieve last non empty line:
@editor.getBuffer().getText().replace(/\s+$/).split('\n').length

I know this code is full of "while" and you just mimic behavior. But I had fixed issue with while at this project recently, so I want to prevent them. This code is far from functional "pureness", but while is absolute evil.

Could we merge #185 before this PR?

@slavaGanzin I'm not sure I understand. What I would write in Coffeescript is:
endRow = @editor.getLastBufferRow()
endRow-- while @blank(endRow) and endRow > 0

:+1: for readability

I'll make an easy to merge PR.

@n-riesco I think this https://github.com/lgeiger/hydrogen/commit/cb7db1206b4436a928e0e9941901271c01b549d8 is more readable and descriptive.

@slavaGanzin The thing that I find most wrong about https://github.com/lgeiger/hydrogen/commit/cb7db1206b4436a928e0e9941901271c01b549d8 :
endRow = @editor.getBuffer().getText().replace(/\s+$/).split('\n').length - 1

is that it creates unnecessary strings:

replace(/\s+$/) creates a string that, in the worst-case scenario, is as big as the whole document;
split('\n') again creates a number of strings that, again in the worst-case scenario, are as big as the whole document;
all these strings are created and dumped straight way, because we are only interested in the length;

On the other hand, I find @lgeiger 's initial version more readable and descriptive:
endRow = @editor.getLastBufferRow()
while @blank(endRow) and endRow > 0
    endRow -= 1

because it resembles more closely the algorithm that it's trying to implement; namely, that of skipping blank lines, i.e.:

check whether a line is blank
iterate until finding a non-blank line or reaching the the first line

Anyway, I don't feel strongly about while-loops. If Hydrogen, as a project, decided to ban the use of while-loops, I would comply. Personally, I believe that this is a bike-shedding argument, and that, at this time, Hydrogen is better off without this kind of constraints.

If you analyze this code and look underneath you'll find pretty the same: https://github.com/lgeiger/hydrogen/blob/cb7db1206b4436a928e0e9941901271c01b549d8/lib/main.coffee#L367-L369 and even worse. How do you think you can take last line of buffer, except slicing it with '\n'?
If you are so afraid of over consumption memory try to avoid calling functions (inline them!) in a cycle - they copy arguments.
As for me, we don't leave in 90s when "640kb is enough for everyone". Ram  is cheap and our time is not. While cycles often causes problems - they aren't pure.
But generally I don't care. You can use any code you want. But, please, move it to separate function.

On 07/03/16 13:34, Slava wrote:

If you analyze this code and look underneath you'll find pretty the same: https://github.com/lgeiger/hydrogen/blob/cb7db1206b4436a928e0e9941901271c01b549d8/lib/main.coffee#L367-L369 and even worse. How do you think you can take last line of buffer, except slicing it with '\n'?

    blank: (row) ->
        return @editor.getBuffer().isRowBlank(row) or
               @editor.languageMode.isLineCommentedAtBufferRow(row)

I trust Atom implements this efficiently (because that's the purpose of a text editor).
I would imagine that, to avoid the creation of unnecessary strings, Atom uses a scanner.
I also imagine that buffers in Atom have been implemented using a data structure that allows both the efficient edition and scanning of the text in the buffer.

If you are so afraid of over consumption memory try to avoid calling functions (inline them!) in a cycle - they copy arguments.

The right word is "concerned".
Inlining makes no difference. Strings don't get copied (strings get created and references to the strings are passed around).

As for me, we don't leave in 90s when "640kb is enough for everyone". Ram is cheap and our time is not. While cycles often causes problems - they aren't pure.

(bike-shedding)

But generally I don't care. You can use any code you want. But, please, move it to separate function.

I don't understand this last point. Could you give an example?

I trust Atom implements this efficiently (because that's the purpose of a text editor).

https://github.com/atom/text-buffer/blob/master/src/history.coffee
As I can see they don't write something good looking or efficient.

Inlining makes no difference. Strings don't get copied (strings get created and references to the strings are passed around).

Maybe we are talking about different things, but where did you read that?
a = '123'
b = (a) -> a = '1234'
b(a)
console.log a

I wouldn't try to promote functional programming, you can write imperative one's and achieve the same. But taking care about memory nowadays in non highloaded environments is bike-schedding for me.

I don't understand this last point. Could you give an example?

That's easy: if you have something working based on state, and so impure - answer correlates with state; preferably to refactor it to a function - in such way you encapsulate it's side effects.

On 07/03/16 16:34, Slava wrote:

I trust Atom implements this efficiently (because that's the purpose of a text editor).

https://github.com/atom/text-buffer/blob/master/src/history.coffee
As I can see they don't write something good looking or efficient.

Could you be more specific? I don't know what I'm supposed to look at.

Inlining makes no difference. Strings don't get copied (strings get created and references to the strings are passed around).

Maybe we are talking about different things, but where did you read that?
|a = '123' b = (a) -> a = '1234' b(a) console.log a |

I don't understand what the above example is trying to illustrate.
The only thing I see is that the above piece of code allocates memory for two strings '123' and '1234'.

I don't understand this last point. Could you give an example?

That's easy: if you have something working based on state, and so impure - answer correlates with state; preferably to refactor it to a function - in such way you encapsulate it's side effects.

When I said that I din't understand your last point, by "your last point" I meant your last paragraph:

But generally I don't care. You can use any code you want. But, please, move it to separate function.

I don't want to continue this.
My last point - I'm not the one who dictates here. So do like you want.

@slavaGanzin Yes, I agree that it's better that we stop discussion here.
Please, don't say things like "you're not the one who dictates here". You're the person that contributed the most to Hydrogen other than Will, and your opinion is very important.


[updater] fix incorrect class interpretation in Camel exchange

branch: feature/updater
In the updater camel-aas Component, the mapping between Camels Exchange events is currently limited to java.lang.String class.
As a result even explicitly transformed numerical values (via Jsonata $number-filter) are interpreted and represented as String on the AAS server, even if the valueType for the SubmodelElement is set to float, int or byte.
I fixed this issue locally by introducing a new helper method interpretValueType and replacing the process method , by directly utilizing the fixMessage method (added through #75) :
@Override
public void process(Exchange exchange) throws Exception {
	ValueType propertyValueType = connectedProperty.getValueType();
	Object messageBody = exchange.getMessage().getBody(interpretValueType(propertyValueType));
	LOG.info("Interpreted message={} as class={}", messageBody.toString(), interpretValueType(propertyValueType));
	if (propertyValueType.toString().equals("string")){
		connectedProperty.setValue(fixMessage(messageBody.toString()));
	}else{
		connectedProperty.setValue(messageBody);
	}
}

Class<?> interpretValueType(ValueType valueType){
	switch (valueType.toString()) {
		case "int":
			return Integer.class;
		case "float":
			return Float.class;
		case "byte":
			return String.class; // if set to Byte.class, Camel throws an TypeConversionException
		default:
			return String.class;
	}
};

Probably there is already a mapper method between the ValueType enum and Java.Lang classes in the BaSyx ecosphere? Then this could be used here? Unfortunately, I could not find such a mapper on the fly... Let me know if there is one, then I cloud try to craft a PR for it

The mapper functions you are looking for are provided in the ValueTypeHelper


Added tests for the nodeportlocal package

This commit introduces new tests for the pkg/agent/nodeportlocal/rules package.
Fixes: https://github.com/antrea-io/antrea/issues/5650

@luolanzone, the netnat_rule.go file is giving the following warning:
This file is within module ".", which is not included in your workspace.
To fix this problem, you can add a go.work file that uses this directory.
See the documentation for more information on setting up your workspace:
https://github.com/golang/tools/blob/master/gopls/doc/workspace.md.go list

The iptables commands in the iptable_rule.go are failing due to the permission denied error when run during the tests.
Could you share some suggestions on how to fix these issues?

The iptables commands in the iptable_rule.go are failing due to the permission denied error when run during the tests.
Could you share some suggestions on how to fix these issues?

Unit tests shouldn't need to really interact with iptables of the system. Instead, you should replace the iptables instance with a mock implementation and only validate if the expected calls has been made.  Check the following test as an example: https://github.com/antrea-io/antrea/blob/025c3f6ea02275eec20e81e40139fa4629cf4dfc/pkg/agent/route/route_linux_test.go#L584

hi @tnqn, do you know how to enable the github action in this PR for the UT workflow?

The iptables commands in the iptable_rule.go are failing due to the permission denied error when run during the tests.
Could you share some suggestions on how to fix these issues?

Unit tests shouldn't need to really interact with iptables of the system. Instead, you should replace the iptables instance with a mock implementation and only validate if the expected calls has been made. Check the following test as an example:
https://github.com/antrea-io/antrea/blob/025c3f6ea02275eec20e81e40139fa4629cf4dfc/pkg/agent/route/route_linux_test.go#L584

It makes sense, thanks for the suggestion. I've updated the code, I think that this PR is ready for a code review.

I don't see the code reflects the change. It still calls the iptables command of the system. As seen from the test code, none of the call can succeed, so the test can't really ensure code work as expected. TestAddAndDeleteRule can get a "Successfully added DNAT rule" only because it uses an empty iptables.Client{}, which does nothing actually.
I think you should at least replace *iptables.Client in iptablesRules with iptables.Interface then you can use a mock implementation and check whether expected calls are made. The link I shared have more examples.

hi @tnqn, do you know how to enable the github action in this PR for the UT workflow?

First time contributor needs a manual approval before the the tests can run. But since the code is not correct, I haven't clicked it yet.

The iptables commands in the iptable_rule.go are failing due to the permission denied error when run during the tests.
Could you share some suggestions on how to fix these issues?

Unit tests shouldn't need to really interact with iptables of the system. Instead, you should replace the iptables instance with a mock implementation and only validate if the expected calls has been made. Check the following test as an example:
https://github.com/antrea-io/antrea/blob/025c3f6ea02275eec20e81e40139fa4629cf4dfc/pkg/agent/route/route_linux_test.go#L584

It makes sense, thanks for the suggestion. I've updated the code, I think that this PR is ready for a code review.

I don't see the code reflects the change. It still calls the iptables command of the system. As seen from the test code, none of the call can succeed, so the test can't really ensure code work as expected. TestAddAndDeleteRule can get a "Successfully added DNAT rule" only because it uses an empty iptables.Client{}, which does nothing actually.
I think you should at least replace *iptables.Client in iptablesRules with iptables.Interface then you can use a mock implementation and check whether expected calls are made. The link I shared have more examples.

Thanks for sharing the pointer @tnqn. This time, I was able to write some tests using the mockIPTable interface.

It's strange that for each DeleteAllRules call, the ChainExists call is returning false.

@tnqn, I've made some updates to the code. Could you please review it again and let me know if the tests are now effective?

/skip-all

LGTM, thanks @VaibhavMalik4187

Thank you for the code pointers and the code review.


helix-cli: init at 2018.1.1705517

Motivation for this change
While the Perforce Visual Client (p4v) has already been packaged under that name, this change packages the accompanying command-line tools (p4).
The package name matches the convention that Perforce use for their own deb and rpm distributions (https://www.perforce.com/perforce/doc.current/manuals/p4sag/Content/P4SAG/install.linux.packages.install.html).
Things done

[X] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[X] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[X] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[X] Fits CONTRIBUTING.md.

@GrahamcOfBorg build helix-cli

No attempt on x86_64-linux (full log)
The following builds were skipped because they don't evaluate on x86_64-linux: helix-cli
Partial log (click to expand)

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnfree = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnfree = true; }
to ~/.config/nixpkgs/config.nix.

No attempt on aarch64-linux (full log)
The following builds were skipped because they don't evaluate on aarch64-linux: helix-cli
Partial log (click to expand)

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnfree = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnfree = true; }
to ~/.config/nixpkgs/config.nix.

Changes requested by worldofpeace should now be addressed.


Revert [SPARK-50215][SQL] Refactored StringType pattern matching in jdbc code stack

What changes were proposed in this pull request?

I propose reverting the PR for changing pattern matching of StringType in the jdbc code stack, since it may have negative affects in the lakehouse federation.
Why are the changes needed?

These changes are needed in order to preserve proper behavior in the dialects of the LakeHouse Federation.
Does this PR introduce any user-facing change?

No.
How was this patch tested?

No testing was needed.
Was this patch authored or co-authored using generative AI tooling?

No.

@MaxGekk please take a look for this revert as we discussed offline.

The failed GA Run / Run Docker integration tests is not related.
+1, LGTM. Merging to master.
Thank you, @vladanvasi-db.


Error with cocoapods: Command failed with exit code 1

Reproduce Scenario (including but not limited to)
I have this error:  pod: Command failed with exit code 1 when I add the platform ios
Steps to Reproduce

I have created the project with ionic framework: ionic start --v2 myApp tabs
Add the phonegap-plugin-push with ionic plugin add command
Add platform ios with cordova-ios 4.3.1
Display Error with pod: Command failed with exit code 1
I have tried to run "pod repo update" without success.

Cordova CLI version and cordova platform version
cordova --version                                    6.4.0
cordova platform version ios                     4.3.1
cocoapods                                                  1.2.0

Plugin version
cordova plugin version | grep phonegap-plugin-push  1.9.2

I have tried to uninstall the cocoapods but I'm not solve the problem.
Would you have a solution?
Thank you,
David

I have solved with this commands:
1--> sudo gem uninstall nanaimo
and then
2-->sudo gem install nanaimo
Thank you.

Failed to install 'phonegap-plugin-push': Error: pod: Command failed with exit code 1


Documentation Update

[ ] Basic of Fork,Clone & hitting a PR
[ ] Setting up the Project Locally
[ ] Code of Conduct
[ ] Contributing Rules/Style (same as #13)

Hey @Siddhant-K-code, I would like to work on this issue. Could you please guide me?

Basic of Fork, Clone & hitting a PR
It is pretty basic, you just have to add steps for a beginner-friendly ( initial steps you did to fork, clone into your system, creating a PR, upstream commands for updating forked repo with the original repo. ) with Screenshots.
Setting up the Project Locally
Yarn Commands we ran to install dependencies and running it on localhost:
yarn install
if you have to face any ERR regarding ESOCKETTIMEOUT
run:
yarn install --network-timeout 500000
after completion, run yarn start to run it on localhost:3000
you just have to document the above info with proper description and easy to understand manner

does this project work with npm so that I can add that too?

Please assign this issue to me. I would like to work on this.

does this project work with npm so that I can add that too?

Just Go Through the Project Once.
And, Remember this thing for all Similar Tech Stack Projects:
Check if the project has `yarn.lock` (installed with yarn) or `package-lock.json` (installed with npm)

@Siddhant-K-code isn't this just what  #13 asks to do? I can make the issue more descriptive if you want.

@Siddhant-K-code I can take up the Contributing.md part, and then I will close #13 which asks for the same task. Can you assign that part to me? (You could tag me in the issue description for making that doc, so that way we know who is working on what part)

@ritvij14 made the changes, will add your name beside it when you will get assigned by maintainers.

Hey @Siddhant-K-code , I tried to run the project on my local machine using npm as well as yarn for yarn it is showing the error as follow:
yarn run v1.22.10
$ react-scripts start
'react-scripts' is not recognized as an internal or external command,
operable program or batch file.
error Command failed with exit code 1.

Ok I am just setting up the project on my local machine. I will get back to you as soon as I finish exploring the project

There was a problem in package.json in react scripts:
"react-scripts": "^4.0.3", was written as   "react-scripts": "4.0.3", that gave error while running in local machine

Hey I set up the project in my local environment. I tried both npm and yarn to run the project in localhost:3000. Both are working super fine. both yarn.lock and package-lock.json are present in the project. What should I do next?
Also,
There was a problem in package.json in react scripts:
"react-scripts": "^4.0.3", was written as "react-scripts": "4.0.3", that gave error while running in local machine

Please assign this to me I am super excited to do all 4 tasks

Hey I set up the project in my local environment. I tried both npm and yarn to run the project in localhost:3000. Both are working super fine. both yarn.lock and package-lock.json are present in the project. What should I do next?
Also,
There was a problem in package.json in react scripts:
"react-scripts": "^4.0.3", was written as "react-scripts": "4.0.3", that gave error while running in local machine

what was the error?

It was a syntax error for version or react scripts

I resolved that by npm install react-scripts command which also update the pacage-lock.json file

I resolved that by npm install react-scripts command which also updated the package-lock.json file

yeah, it's okay. also, did you face ESOCKETTIMEOUT err ?

after that, it runs on localhost server

I resolved that by npm install react-scripts command which also updated the package-lock.json file

yeah, it's okay. also, did you face ESOCKETTIMEOUT err ?

No

I resolved that by npm install react-scripts command which also updated the package-lock.json file

your yarn.lock should also get updated!! will create a PR for the same.

I resolved that by npm install react-scripts command which also updated the package-lock.json file

yeah, it's okay. also, did you face ESOCKETTIMEOUT err ?

No

But we can add steps to resolve it in the documentation section

I resolved that by npm install react-scripts command which also updated the package-lock.json file

your yarn.lock should also get updated!! will create a PR for the same.

Yes it does gets updated when we run yarn install react scripts

https://github.com/kaiwalyakoparkar/edu-client/tree/documentation

I have also added Contributing.md, Code-of-conduct.md and all you asked. Also I have made changes which fixed the previous errors

I have also added Contributing.md, Code-of-conduct.md and all you asked. Also I have made changes which fixed the previous errors

Please create a PR, We will discuss the rest there.

ok

@Abhishek-kumar09 there are still some mistakes in the documentation which i want to correct it can i do that ??
and also guide me with it


Help me Nothings Working

when downloading anime in 480p, it will download in the highest resolution instead, I used:
anime dl  -e 1:12 -q 480p
Animixplay, 9anime, gogoanime, etc not working
I can still download anime in the highest resolution but I wanted to download in 480p because of the low free space on my drive

Yeah uhh
Most of the providers dont support multiple resolutions....
So uhh, the only advice I can give is to use another provider...
For example an excellent provider that supports multiple qualities is tenshi.moe
Although its library is small.


Feature: Introduce a simple mode to only get code, translations for country and state

In most scenarios, Applications need only code, proper display label(translations) for countries and states,  is it possible to introduce a simple mode to only support those fields to reduce memory cost?

Seems very possible, as there is lots of lazy loading code in place for translations (the bulk of the memory weight)  I think it might be good to first determine the actual benefit.  Which you should be able to do by basically emptying the contents of the yaml files, and running a performance test.
I believe the only thing we need at runtime for the data you request is the code itself, which we could get from just the file name to avoid loading the documents themselves.
That being said, I am way over capacity and won't be able to devote any time to this.  But I am happy to guide you along in a PR.

Thanks for the update.  I'm asking this because I'm implementing country-state cascade select boxes now. An light solution is enough for my need.  But you are right, maybe we should measure the performance first.  :-)


SEAB-4499: Optimize integration test database migrations

Description
This PR improves the speed, reduces the resource consumption, and improves the code clarity of the integration test database migrations.
The database migrations are used to set the state of the database prior to each test, by calling application.run with the db migrate command to apply the named changelogs via the --include argument.  Previously, in most cases, a given migration was applied by calling application.run to apply each constituent changelog, by itself, one by one, successively, in a loop:
https://github.com/dockstore/dockstore/blob/273cd85d5df19491b298111ed36a5e3b15c522ab/dockstore-integration-testing/src/test/java/io/dockstore/common/CommonTestUtilities.java#L260
Each call to application.run incurs significant overhead, so this PR batches and applies the full set of changelogs in a single call to application.run.  On my local install, this change reduced the total migration run time by over 50%.  On circleci, it reduced the run time of the migration-intensive test groups by 1-5 minutes each.  Approximately representative runs:
before: https://app.circleci.com/pipelines/github/dockstore/dockstore/8642
after: https://app.circleci.com/pipelines/github/dockstore/dockstore/8663
I moved one of the changelogs in migrations.xml to correct the ordering.  Without that change, sometimes changelogs would be skipped when batched, causing the migration to fail.  This problem was not visible when the changelogs were applied one-by-one, because the batches were of size 1 and, thus, had no relative ordering issues.  This problem might explain why the migrations were applied one-by-one in the first place.
I also refactored so that all migrations are applied via the same method, thus facilitating the next change...
To further reduce the run time of the migrations, I investigated different ways to save snapshots of the database resulting from each migration (series of changelogs) and use the snapshot, instead of migrating, when possible.  IMHO, the observed gain from the solution I implemented, which theoretically should be [close to] the fastest of the bunch, was minor and did not outweigh the various cons.  So, I didn't include it in this PR.   The basic scheme was to use pg_dump and pg_restore to write/read the snapshots, keyed by a hash of the changelogs applied.  If you want to see it, the prototype is still on the branch: https://github.com/dockstore/dockstore/pull/5161/commits/66efa462d04aec30694ae7480b697987e8076594
Another candidate snapshot mechanism was the CREATE DATABASE newdb TEMPLATE templatedb statement.  It seemed promising, but the requirement that the templatedb have no connected users (when it is invoked) made it hard to integrate with our tests (as currently architected).
Over time, should our migrations grow signficantly more ponderous, we may want to revisit snapshotting migrated databases...
The next step to improve the run time of the ITs would probably be to split the unit_test group.
Issue
https://ucsc-cgl.atlassian.net/browse/SEAB-4499
Please make sure that you've checked the following before submitting your pull request. Thanks!

[x] Check that you pass the basic style checks and unit tests by running mvn clean install
[x] Ensure that the PR targets the correct branch. Check the milestone or fix version of the ticket.
[x] Follow the existing JPA patterns for queries, using named parameters, to avoid SQL injection
[x] If you are changing dependencies, check the Snyk status check or the dashboard to ensure you are not introducing new high/critical vulnerabilities
[x] Assume that inputs to the API can be malicious, and sanitize and/or check for Denial of Service type values, e.g., massive sizes
[x] Do not serve user-uploaded binary images through the Dockstore API
[x] Ensure that endpoints that only allow privileged access enforce that with the @RolesAllowed annotation
[x] Do not create cookies, although this may change in the future
[x] If this PR is for a user-facing feature, create and link a documentation ticket for this feature (usually in the same milestone as the linked issue). Style points if you create a documentation PR directly and link that instead.

I moved one of the changelogs in migrations.xml to correct the ordering. Without that change, sometimes changelogs would be skipped when batched, causing the migration to fail. This problem was not visible when the changelogs were applied one-by-one, because the batches were of size 1 and, thus, had no relative ordering issues. This problem might explain why the migrations were applied one-by-one in the first place

It's quite odd; I looked at the code and tried to understand it, but I couldn't. But given that this file only affects tests, not prod, and tests are passing, seems good.

I moved one of the changelogs in migrations.xml to correct the ordering. Without that change, sometimes changelogs would be skipped when batched, causing the migration to fail. This problem was not visible when the changelogs were applied one-by-one, because the batches were of size 1 and, thus, had no relative ordering issues. This problem might explain why the migrations were applied one-by-one in the first place

It's quite odd; I looked at the code and tried to understand it, but I couldn't. But given that this file only affects tests, not prod, and tests are passing, seems good.

It may not be 100% correct, but it's probably more correct than before.  The new migrations.xml order better matches the ordering of the "partial" migrations in the tests, which doesn't seem like it should matter (but does, strangely enough).


Precomputed annotation and scale level

Hi, for the precomputed annotation, is there a way to specify different annotations for different scale levels (similar to the datasource precomputed format)? I would like to render a large number of annotations, but the highest resolution annotations will only need to be loaded when the user zooms in. Alternatively, is there a way to get the current scale level from the Python API? Thank you!

The neuroglancer precomputed annotation format does support multiple scale levels, but it is designed to subsample when you zoom out, rather than showing different annotations.  Unlike for volumetric data, where low-res data is not shown when high-res data is available (e.g. as you zoom in), with annotations, if you zoom out sufficiently far, only scale level 0 annotations are shown.  As you zoom in, annotations from scale levels 0-1 are shown, then as you zoom in more annotations from scale levels 0-2 are shown, etc.


PowerToys auto scale when launched and app hides under task bar.

the apps don't start at the right position on the screen when launched but rather hides beneath under the task bar. finally app always starts  very a tall UI even when it's scaled to a small size.

@charismaCMD, thanks for the issue, couple q:

what is your windows version
what are your DPI setttings

@CharismaCMD, thanks for the issue, couple q:

what is your windows version
what are your DPI setttings

I'm on windows version 2004 build 19041.264. scaled at 100% with resolution of1366 * 768

@CharismaCMD
the tracker for this issue is https://github.com/microsoft/PowerToys/issues/3685
Closing this as duplicate.
Thanks.


[FEAT]: Create Issue forms and make the issue options more visually appealing

Describe the Feature you want to end

Currently, the issue template for this repo seems to be basic also it is less visually appealing.👇

Changes I will make

Expected behavior

Screenshots (optional)

Additional context (optional )
Will add issue forms to the respective issues to make it easier for the contributor to raise it.
Here is an example of how a Bug Issue Form will look like 👇

Kindly assign me this issue under GSSOC'24

Go ahead @dakshsinghrathore

Any updates? @dakshsinghrathore

@andoriyaprashant Project manager has updated that any PR before 7pm IST today will not be counted as a contribution, hence avoiding to create one ! hope you understand.

@andoriyaprashant Project manager has updated that any PR before 7pm IST today will not be counted as a contribution, hence avoiding to create one ! hope you understand.

no problem @dakshsinghrathore

@andoriyaprashant can u please assign this issue to me ?? I would like to contribute..


Do what I said I would do :v:

Format a datetime for today and put it in the message.

It would be better if we can specify on the page when (accurate to the second) this page is captured so that users can have a reasonable expectation of what will be on the page. Also the current wording suggests that the entire site was captured at the same time, which is not the case.