Height detection when sliding in from the bottom

Hi There!
This is a feature request I think as I haven't seen this in the options. Would it be possible to add an auto height option to the menu when it slides in from below?

It would be great if in the image above the menu slided in just until the more techniques list item :) Wether or not this gets implemented, this is still the best menu script by a long shot :)
Thanks!
Daniel

Hi, not a bad idea. Unfortunately this can't be reproduces with CSS only;
The menu needs a fixed height because all panels have position: absolute (and thus no height for their parent). Also, the DIV#mm-blocker that closes the menu onMouseDown/onTouchStart has a height of 100% minus the menu height.
So the only solution would be to measure the height of the currently opened panel and animate the height of the menu to that height and the height of the DIV#mm-blocker to 100% minus that height.
I guess this behavior could be turned into an add-on. I'll see if I can whip something up.

Hi Fred,
Thanks for giving this some attention :) I'm a bit into other parts of the website just now, but if I can beat you to it I'll try myself :)
Daniel

Happy to inform you there will be an add-on called "autoHeight" in the next release.

Wonderful news, thanks so much!

The js will look like this:
$("#menu").mmenu({
   autoHeight: true
});


Matrix Multiplication

Hey, there..
Added a code for matrix multiplication in C

@shivangdubey Added a descrption..
Kindly review my project..


HADOOP-18851: Performance improvement for DelegationTokenSecretManager.

Description of PR
AbstractDelegationTokenSecretManager's method all synchronized  and are blocking each other, even multiple readers threads are blocking each other. This PR is an efforts towards optimising the synchronization contexts.
For detailed description, please go through the discussion on https://issues.apache.org/jira/browse/HADOOP-18851
How was this patch tested?
Build is working fine. And this is more about a logical change like where to acquire or release a lock. It requires careful review. There is not any functional logic change.
For code changes:

[ Y] Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
[ N/A] Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
[ N/A] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
[ N/A] If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 58s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s

The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
44m 15s

trunk passed

+1 :green_heart:
compile
18m 45s

trunk passed with JDK Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04

+1 :green_heart:
compile
17m  0s

trunk passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
checkstyle
1m 17s

trunk passed

+1 :green_heart:
mvnsite
1m 37s

trunk passed

+1 :green_heart:
javadoc
1m 11s

trunk passed with JDK Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04

+1 :green_heart:
javadoc
0m 47s

trunk passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
spotbugs
2m 35s

trunk passed

-1 :x:
shadedclient
38m 18s

branch has errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 54s

the patch passed

+1 :green_heart:
compile
17m 27s

the patch passed with JDK Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04

+1 :green_heart:
javac
17m 27s

the patch passed

+1 :green_heart:
compile
16m 37s

the patch passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
javac
16m 37s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
1m 10s

the patch passed

+1 :green_heart:
mvnsite
1m 34s

the patch passed

+1 :green_heart:
javadoc
1m  4s

the patch passed with JDK Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04

+1 :green_heart:
javadoc
0m 46s

the patch passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
spotbugs
2m 40s

the patch passed

-1 :x:
shadedclient
38m 35s

patch has errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
18m 44s

hadoop-common in the patch passed.

+1 :green_heart:
asflicense
0m 57s

The patch does not generate ASF License warnings.

230m 13s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6001/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/6001

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux 0fcdd0e8cfdb 4.15.0-212-generic #223-Ubuntu SMP Tue May 23 13:09:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 913d6900b90d5292a41eea2cc6191ea3aef45f59

Default Java
Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6001/1/testReport/

Max. process+thread count
2487 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6001/1/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
1m  1s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+0 :ok:
detsecrets
0m  1s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s

The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
50m  3s

trunk passed

+1 :green_heart:
compile
18m 22s

trunk passed with JDK Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04

+1 :green_heart:
compile
17m 15s

trunk passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
checkstyle
1m 14s

trunk passed

+1 :green_heart:
mvnsite
1m 35s

trunk passed

+1 :green_heart:
javadoc
1m 11s

trunk passed with JDK Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04

+1 :green_heart:
javadoc
0m 46s

trunk passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
spotbugs
2m 34s

trunk passed

+1 :green_heart:
shadedclient
40m 12s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 55s

the patch passed

+1 :green_heart:
compile
17m 27s

the patch passed with JDK Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04

+1 :green_heart:
javac
17m 27s

the patch passed

+1 :green_heart:
compile
16m 43s

the patch passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
javac
16m 43s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
1m 10s

the patch passed

+1 :green_heart:
mvnsite
1m 36s

the patch passed

+1 :green_heart:
javadoc
1m  5s

the patch passed with JDK Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04

+1 :green_heart:
javadoc
0m 45s

the patch passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
spotbugs
2m 38s

the patch passed

+1 :green_heart:
shadedclient
40m 47s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
18m 37s

hadoop-common in the patch passed.

+1 :green_heart:
asflicense
0m 56s

The patch does not generate ASF License warnings.

240m 17s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6001/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/6001

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux c2fdfdb580eb 4.15.0-212-generic #223-Ubuntu SMP Tue May 23 13:09:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 827b881ee969d1c90413980c168377b8257f70b8

Default Java
Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6001/2/testReport/

Max. process+thread count
1245 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6001/2/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 57s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s

The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
43m 45s

trunk passed

+1 :green_heart:
compile
17m 23s

trunk passed with JDK Ubuntu-<IP_ADDRESS>+1-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
compile
16m 25s

trunk passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
checkstyle
1m 22s

trunk passed

+1 :green_heart:
mvnsite
1m 47s

trunk passed

+1 :green_heart:
javadoc
1m 21s

trunk passed with JDK Ubuntu-<IP_ADDRESS>+1-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
1m  0s

trunk passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
spotbugs
2m 35s

trunk passed

+1 :green_heart:
shadedclient
36m 18s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 59s

the patch passed

+1 :green_heart:
compile
16m 30s

the patch passed with JDK Ubuntu-<IP_ADDRESS>+1-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javac
16m 30s

the patch passed

+1 :green_heart:
compile
16m 34s

the patch passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
javac
16m 34s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
1m 19s
/results-checkstyle-hadoop-common-project_hadoop-common.txt
hadoop-common-project/hadoop-common: The patch generated 3 new + 27 unchanged - 0 fixed = 30 total (was 27)

+1 :green_heart:
mvnsite
1m 45s

the patch passed

+1 :green_heart:
javadoc
1m 19s

the patch passed with JDK Ubuntu-<IP_ADDRESS>+1-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
0m 58s

the patch passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

-1 :x:
spotbugs
2m 49s
/new-spotbugs-hadoop-common-project_hadoop-common.html
hadoop-common-project/hadoop-common generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)

+1 :green_heart:
shadedclient
35m 56s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
19m 24s
/patch-unit-hadoop-common-project_hadoop-common.txt
hadoop-common in the patch passed.

+1 :green_heart:
asflicense
1m 12s

The patch does not generate ASF License warnings.

225m 50s

Reason
Tests

SpotBugs
module:hadoop-common-project/hadoop-common

org.apache.hadoop.security.token.delegation.ZKDelegationTokenSecretManager.incrementDelegationTokenSeqNum() does not release lock on all paths  At ZKDelegationTokenSecretManager.java:on all paths  At ZKDelegationTokenSecretManager.java:[line 527]

Failed junit tests
hadoop.security.token.delegation.TestZKDelegationTokenSecretManager

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6001/5/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/6001

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux 31c7383541ef 4.15.0-212-generic #223-Ubuntu SMP Tue May 23 13:09:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / da69485cbdb22310314aa1afe9168c8ae64ac04c

Default Java
Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-<IP_ADDRESS>+1-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6001/5/testReport/

Max. process+thread count
3149 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6001/5/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 59s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s

The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
47m 29s

trunk passed

+1 :green_heart:
compile
18m 37s

trunk passed with JDK Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04

+1 :green_heart:
compile
16m 57s

trunk passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
checkstyle
1m 15s

trunk passed

+1 :green_heart:
mvnsite
1m 37s

trunk passed

+1 :green_heart:
javadoc
1m 10s

trunk passed with JDK Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04

+1 :green_heart:
javadoc
0m 45s

trunk passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
spotbugs
2m 35s

trunk passed

+1 :green_heart:
shadedclient
39m 34s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 54s

the patch passed

+1 :green_heart:
compile
17m 20s

the patch passed with JDK Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04

+1 :green_heart:
javac
17m 20s

the patch passed

+1 :green_heart:
compile
20m 27s

the patch passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
javac
20m 27s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
1m 25s

the patch passed

+1 :green_heart:
mvnsite
1m 44s

the patch passed

+1 :green_heart:
javadoc
1m 20s

the patch passed with JDK Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04

+1 :green_heart:
javadoc
1m  4s

the patch passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
spotbugs
3m  9s

the patch passed

+1 :green_heart:
shadedclient
40m 57s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
18m 52s

hadoop-common in the patch passed.

+1 :green_heart:
asflicense
0m 55s

The patch does not generate ASF License warnings.

242m 15s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6001/4/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/6001

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux 4f676426ecde 4.15.0-212-generic #223-Ubuntu SMP Tue May 23 13:09:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 827b881ee969d1c90413980c168377b8257f70b8

Default Java
Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6001/4/testReport/

Max. process+thread count
3144 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6001/4/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
1m  3s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s

The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
57m 30s

trunk passed

+1 :green_heart:
compile
18m 40s

trunk passed with JDK Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04

+1 :green_heart:
compile
17m  3s

trunk passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
checkstyle
1m 14s

trunk passed

+1 :green_heart:
mvnsite
1m 36s

trunk passed

+1 :green_heart:
javadoc
1m  9s

trunk passed with JDK Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04

+1 :green_heart:
javadoc
0m 47s

trunk passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
spotbugs
2m 34s

trunk passed

+1 :green_heart:
shadedclient
40m  2s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 55s

the patch passed

+1 :green_heart:
compile
17m 39s

the patch passed with JDK Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04

+1 :green_heart:
javac
17m 39s

the patch passed

+1 :green_heart:
compile
16m 45s

the patch passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
javac
16m 45s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
1m 11s
/results-checkstyle-hadoop-common-project_hadoop-common.txt
hadoop-common-project/hadoop-common: The patch generated 3 new + 27 unchanged - 0 fixed = 30 total (was 27)

+1 :green_heart:
mvnsite
1m 34s

the patch passed

+1 :green_heart:
javadoc
1m  3s

the patch passed with JDK Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04

+1 :green_heart:
javadoc
0m 45s

the patch passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
spotbugs
2m 39s

the patch passed

+1 :green_heart:
shadedclient
41m 50s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
19m 20s

hadoop-common in the patch passed.

+1 :green_heart:
asflicense
0m 56s

The patch does not generate ASF License warnings.

249m 12s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6001/6/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/6001

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux b357d2e349cb 4.15.0-212-generic #223-Ubuntu SMP Tue May 23 13:09:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / ab7a3a697b898ac4ec717206bf875cd01d0919f1

Default Java
Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6001/6/testReport/

Max. process+thread count
3144 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6001/6/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

Hi @Hexiaoqiao , @jojochuang ,  I have incorporated all the review comments. Now CI pipeline is failing due to lack of test cases.
As this changes are logical and not changing any functional part, so I have not added any new test case. But I patched my KMS cluster with the built dev jar and executed our benchmarking test suite and it was working fine.
Please let me know if this sufficient , if not, please suggest further. Thanks.

It is OK for me. Please fix the checkstyle as Yetus reported before approve and checkin. Thanks.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 58s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+0 :ok:
detsecrets
0m  1s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s

The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
44m 28s

trunk passed

+1 :green_heart:
compile
17m  7s

trunk passed with JDK Ubuntu-<IP_ADDRESS>+1-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
compile
15m 59s

trunk passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
checkstyle
1m 23s

trunk passed

+1 :green_heart:
mvnsite
1m 47s

trunk passed

+1 :green_heart:
javadoc
1m 22s

trunk passed with JDK Ubuntu-<IP_ADDRESS>+1-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
0m 59s

trunk passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
spotbugs
2m 50s

trunk passed

+1 :green_heart:
shadedclient
37m 42s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m  0s

the patch passed

+1 :green_heart:
compile
17m 21s

the patch passed with JDK Ubuntu-<IP_ADDRESS>+1-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javac
17m 21s

the patch passed

+1 :green_heart:
compile
16m 16s

the patch passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
javac
16m 16s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
1m 13s

the patch passed

+1 :green_heart:
mvnsite
1m 41s

the patch passed

+1 :green_heart:
javadoc
1m 13s

the patch passed with JDK Ubuntu-<IP_ADDRESS>+1-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
0m 53s

the patch passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
spotbugs
2m 44s

the patch passed

+1 :green_heart:
shadedclient
38m 39s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
19m 38s

hadoop-common in the patch passed.

+1 :green_heart:
asflicense
1m  5s

The patch does not generate ASF License warnings.

230m 30s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6001/7/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/6001

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux a2e40121feb1 4.15.0-212-generic #223-Ubuntu SMP Tue May 23 13:09:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / d5eded867b72eb6d5018ea63ee20bde882f21b29

Default Java
Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-<IP_ADDRESS>+1-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6001/7/testReport/

Max. process+thread count
1278 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6001/7/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

@Hexiaoqiao , @jojochuang , are we good to merge this ? I can see one approval. If yes, then can anyone of you please do the needful. Thanks.

Committed to trunk. Thanks @vikaskr22 for your works and @jojochuang for your review!


original_exception is deprecated with Rails 5

I got these warning when integrating better_errors with Rails 5
DEPRECATION WARNING: #original_exception is deprecated. Use #cause instead. (called from initialize at /Users/hoanghoa/.rbenv/versions/2.3.0/lib/ruby/gems/2.3.0/gems/better_errors-2.1.1/lib/better_errors/raised_exception.rb:7)
DEPRECATION WARNING: #original_exception is deprecated. Use #cause instead. (called from initialize at /Users/hoanghoa/.rbenv/versions/2.3.0/lib/ruby/gems/2.3.0/gems/better_errors-2.1.1/lib/better_errors/raised_exception.rb:8)

+1

:+1: ran into the same issue

@charliesome any updates on fixing this?

+1

+1

fix looks good

FYI
config.active_support.deprecation = -> (message, _backtrace) do
  if message.include?("#original_exception is deprecated")
      # ignored until https://github.com/charliesome/better_errors/issues/333
    else
      raise message
    end
  end


TextFields always scroll when wordWrap is true

When a TextField has wordWrap set to true the mouse wheel always scrolls it up a single line, though it shouldn't need to scroll at all. Further, setting mouseWheelEnabled to false doesn't prevent this behaviour, though setting mouseEnabled to false does.
Easy to reproduce:
package;

import openfl.text.TextFormatAlign;
import openfl.text.TextFormat;
import openfl.text.TextField;
import openfl.display.Sprite;

class Main extends Sprite {
  public function new() {
    super();

    var text = new TextField();
    text.defaultTextFormat = new TextFormat('Times New Roman', 26, 0x000000, false, false, false, null, null, TextFormatAlign.LEFT);
    text.width = 400;
    text.autoSize = LEFT;
    text.wordWrap = true;
    text.selectable = false;
    text.mouseWheelEnabled = false;
    text.text = 'Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua. Mattis aliquam faucibus purus in massa tempor. Elit eget gravida cum sociis natoque. Odio facilisis mauris sit amet massa. Tempus quam pellentesque nec nam aliquam. Pellentesque sit amet porttitor eget dolor morbi non. Et leo duis ut diam. Sapien nec sagittis aliquam malesuada bibendum.';

    text.x = 100;
    text.y = 100;

    addChild(text);
  }
}

Which target are you testing on, and have you tried this on the latest OpenFL dev version? I just tried it, and nothing happened when I scrolled, even when I turned on mouseWheelEnabled (on Neko).

Sorry, I should have specified target! HTML5. OpenFL 8.9.5
On Wed., Dec. 18, 2019, 10:22 p.m. Nick<EMAIL_ADDRESS>wrote:

Which target are you testing on, and have you tried this on the latest
OpenFL dev version? I just tried it, and nothing happened when I scrolled,
even when I turned on mouseWheelEnabled (on Neko).
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/openfl/openfl/issues/2299?email_source=notifications&email_token=ABFIQA2G64VU34FLLTSML7LQZLSI5A5CNFSM4JW5P5F2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEHIINPY#issuecomment-567314111,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABFIQA44TRRDCOPXRCVCNUDQZLSI5ANCNFSM4JW5P5FQ
.

Which browser? Maybe related to #2301

Tested in Chrome 78.0.3904.97 (Official Build) (64-bit)
On Sat, 21 Dec 2019 at 12:12, Nick<EMAIL_ADDRESS>wrote:

Which browser? Maybe related to #2301
https://github.com/openfl/openfl/issues/2301
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/openfl/openfl/issues/2299?email_source=notifications&email_token=ABFIQA6VMWXJ3UQ2WWH4JVLQZZFBBA5CNFSM4JW5P5F2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEHO744Y#issuecomment-568196723,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABFIQAZJLFH44URXGC7BIXTQZZFBBANCNFSM4JW5P5FQ
.


Musings on how to make it easier to control the flow of data for updating your UI

originally brought up in https://github.com/HotCocoaTouch/DeclarativeLayout/issues/31

I also think this wrapper should think much harder about how to handle data to make updating state and having that trigger updates to the view easy.

Ignoring settings colors and non views/constraints, one possible direction is to build if statements into the layout:
ViewLayout(view: self.view) { (com) in
    com.stackView { (com) in
        com.if(/*some condition*/) { (com) in
            com.arrangedView(self.myView) { (com) in
                ...
            }
        }.elseif(/*some condition*/) { (com) in
            ...
        }.else(/*some condition*/) { (com) in
            ...
        }
    }
}

One part of this is that you'd no longer be explicitly calling to update your layout. You're describing it here. This function that describes the layout gets executed once.
So how could this work?
The condition statements inside of the if() function could require what is passed in to be a function. Something that we can store  and later re-evaluate.
One of the tricks already to this framework is that at the call site, no constraints have been activated and no constraints. It also stores all of the decisions about view hierarchy and constraints in a tree of components.
The if statements would mark components under it to be active or inactive. This could be used to get the active constraints and current view layout that could be re-run through the diffing algorithm.

The next thing to solve is how to know when to re-evaluate the layout to make adjustments. The simplest implementation of this is to have each view layout store a single "ViewState" or "ViewModel" object. Require that for this framework to work, the functions inside of if() functions use data from only the view model. When the view layout's view state changes, it can re-run the decision functions to find what components should be active and automatically update things.

What I see as the pros of this:

It's more declarative since you don't really control code inside this description. You don't get the opportunity for some other unknown state to cause differences in your UI. (I mean you could make that mistake, but it would be a mistake)
It doesn't require that during every call to layout that constraints be re-created. Also things like equatable could probably be sped up knowing there's a higher likelihood it actually gets the exact same constraint instance again (instead of comparing equatable to every property of the constraint)
In the future changes wouldn't require diffing the entire new layout to the entire old layout. could be smarter about what actually needs to be diffed.
I think that this whole thing could actually be its own subclass to set up strong barriers between the view function and data (so you'd have it in its own file since all data is dependent on this view state.

Some cons:

It doesn't feel quite right that i'm re-implementing build in swift control flow (like if statements). Do I need switches? ternary operators? etc
because the if statements require functions, you can't make some of those decisions on previous lines, you have to separate that to a function or pass in a closure. These lines could start to get long.

There are also a couple concerns:

How do things like animations work
Does navigation fit anywhere in this?

to handle the other UI stuff, we can probably make some kind of bindings interface: https://www.swiftbysundell.com/posts/bindable-values-in-swift
This doesn't work for all UIKit things because a lot has to be done with closures because UIKit sometimes relies on method calls. But a closure API could be tacked onto that.
I think this would work really well for UI configuration, but can it also work for deciding what path to go down for constraints/subviews being on screen? It's similar to the .if() I had there.

I think that if I go down this route I should remove the component returns from the APIs. The library will have strong enough opinions that making an opinionated library around it won't be easily possible.

There are also going to be times when you want to bind on multiple properties on a view state and we can't really do variadic generics in that way so you'd need some other type of API.

I think that going with a purely functional approach as I mocked up elsewhere with enums/structs, and using something like .if(


Compose export: add support for hosts/containers/secrets

Rancher Versions: Build from wagyu
Steps to reproduce the problem:
Create a stack .
Create a  standalone container in this stack.
Exported config file for this service does not include container information.

@sangeethah that would be done as a part of bigger change for export. So lets modify this ticket to keep track of all the expected changes.

Add export support for:

host
container
secret

Create top level keys for following service types:

loadBalancerService
dnsService
etc

Also, need to update so that export config is 1 compose.yml file instead of a rancher-compose.yml and docker-compose.yml.

secrets export supports are tracked in this issue. https://github.com/rancher/rancher/issues/9059

With the release of Tech Preview 2, the architecture behind 2.0 has significantly changed. Any issues with any release prior to v2.0.0-alpha12 is most likely invalid.
Please watch our Tech Preview 2 meetup to learn more about the changes in 2.0 in Tech Preview 2.
Please file new issues after using Tech Preview 2 (any release v2.0.0-alpha12+). As always, thanks for using Rancher!


Says could not publish video: LiveKit Exception TrackPublishException Failed to publish track

problem
could not publish video: LiveKit Exception TrackPublishException Failed to publish track
version

livekit_client: 0.5.9
iOS 14.4.2
iPhone 12
it was NOT happening on iOS 12.5.5 of iPhone 6

log
2022-04-22 13:33:02.387701+0800 Runner[3250:794315] flutter: could not publish video: LiveKit Exception TrackPublishException Failed to publish track
full log
2022-04-22 13:32:49.261230+0800 Runner[3250:794315] flutter: 13:32:49: Engine ConnectionState disconnected -> connecting
2022-04-22 13:32:49.264811+0800 Runner[3250:794315] flutter: 13:32:49: [EngineEvent] Engine#55839818 EngineConnectionStateUpdatedEvent(newState: connecting, didReconnect: false, disconnectReason: null)
2022-04-22 13:32:49.272098+0800 Runner[3250:794315] flutter: 13:32:49: SignalClient connecting with url: wss://hidden/rtc?access_token=hidden&auto_subscribe=1&protocol=7&sdk=flutter&version=0.5.9&os=iOS&os_version=14.4.2&device_model=iPhone13%2C2
2022-04-22 13:32:49.272261+0800 Runner[3250:794315] flutter: 13:32:49: SignalClient ConnectionState disconnected -> connecting
2022-04-22 13:32:49.272613+0800 Runner[3250:794315] flutter: 13:32:49: [SignalClient#782359492] cleanUp()
2022-04-22 13:32:49.272708+0800 Runner[3250:794315] flutter: 13:32:49: [SignalEvent] SignalConnectionStateUpdatedEvent(newState: connecting, didReconnect: false, disconnectReason: null)
2022-04-22 13:32:49.273946+0800 Runner[3250:794315] flutter: 13:32:49: [WebSocketIO] Connecting(uri: wss://hidden/rtc?access_token=hidden&auto_subscribe=1&protocol=7&sdk=flutter&version=0.5.9&os=iOS&os_version=14.4.2&device_model=iPhone13%2C2)...
2022-04-22 13:32:49.328255+0800 Runner[3250:794315] flutter: 13:32:49: [WebSocketIO] Connected
2022-04-22 13:32:49.328683+0800 Runner[3250:794315] flutter: 13:32:49: SignalClient ConnectionState connecting -> connected
2022-04-22 13:32:49.329019+0800 Runner[3250:794315] flutter: 13:32:49: [SignalEvent] SignalConnectionStateUpdatedEvent(newState: connected, didReconnect: false, disconnectReason: null)
2022-04-22 13:32:49.341584+0800 Runner[3250:794315] flutter: 13:32:49: [SignalEvent] Instance of 'SignalJoinResponseEvent'
2022-04-22 13:32:49.342976+0800 Runner[3250:794315] flutter: 13:32:49: onConnected subscriberPrimary: true, serverVersion: 0.15.6, iceServers: [urls: turn:hidden?transport=udp
urls: turns:hidden?transport=tcp
username: 2022-04-22T13:32:49.329420348+08:00
credential: xhsowe4BUGZoaYMVHnBibbu8Cv14CEBUXZqNkIeDjkS
]
2022-04-22 13:32:49.344564+0800 Runner[3250:794315] flutter: 13:32:49: [PCTransport] creating {sdpSemantics: unified-plan, iceServers: [{urls: [turn:hidden?transport=udp, turns:hidden?transport=tcp], username: 2022-04-22T13:32:49.329420348+08:00, credential: 2022-04-22T13:32:49.329420348+08:00}]}
2022-04-22 13:32:49.346311+0800 Runner[3250:794315] flutter: 13:32:49: [Engine] Received JoinResponse, serverVersion: 0.15.6
2022-04-22 13:32:49.348136+0800 Runner[3250:794315] flutter: 13:32:49: Room Connect completed
2022-04-22 13:32:49.348374+0800 Runner[3250:794315] flutter: 13:32:49: [ParticipantEvent] ParticipantMetadataUpdatedEvent(participant: LocalParticipant(sid: PA_VbHvhdGGzkmB, identity: player9)), will notifyListeners()
2022-04-22 13:32:49.348530+0800 Runner[3250:794315] flutter: 13:32:49: [RoomEvent] ParticipantMetadataUpdatedEvent(participant: LocalParticipant(sid: PA_VbHvhdGGzkmB, identity: player9)), will notifyListeners()
2022-04-22 13:32:49.348650+0800 Runner[3250:794315] flutter: 13:32:49: [ParticipantEvent] ParticipantPermissionsUpdatedEvent(participant: LocalParticipant(sid: PA_VbHvhdGGzkmB, identity: player9), permissions: Instance of 'ParticipantPermissions'), will notifyListeners()
2022-04-22 13:32:49.348686+0800 Runner[3250:794315] flutter: 13:32:49: [RoomEvent] ParticipantPermissionsUpdatedEvent(participant: LocalParticipant(sid: PA_VbHvhdGGzkmB, identity: player9), permissions: Instance of 'ParticipantPermissions'), will notifyListeners()
2022-04-22 13:32:49.349739+0800 Runner[3250:794315] flutter: 13:32:49: [SignalEvent] Instance of 'SignalTokenUpdatedEvent'
2022-04-22 13:32:49.358074+0800 Runner[3250:794315] flutter: 13:32:49: [PCTransport] creating {sdpSemantics: unified-plan, iceServers: [{urls: [turn:hidden?transport=udp, turns:hidden?transport=tcp], username: 2022-04-22T13:32:49.329420348+08:00, credential: 2022-04-22T13:32:49.329420348+08:00}]}
2022-04-22 13:32:49.363145+0800 Runner[3250:794315] flutter: 13:32:49: EventsListener<SignalEvent>#453412181 event was cancelled by func
2022-04-22 13:32:49.363216+0800 Runner[3250:794315] flutter: 13:32:49: Waiting for engine to connect...
2022-04-22 13:32:49.363335+0800 Runner[3250:794315] flutter: 13:32:49: Server refreshed the token
2022-04-22 13:32:49.476668+0800 Runner[3250:794315] flutter: 13:32:49: [SignalEvent] Instance of 'SignalOfferEvent'
2022-04-22 13:32:49.477488+0800 Runner[3250:794315] flutter: 13:32:49: [Engine#55839818] Received server offer(type: offer, null)
2022-04-22 13:32:49.480574+0800 Runner[3250:794315] flutter: 13:32:49: [SignalEvent] Instance of 'SignalTrickleEvent'
2022-04-22 13:32:49.481080+0800 Runner[3250:794315] flutter: 13:32:49: [SignalEvent] Instance of 'SignalTrickleEvent'
2022-04-22 13:32:49.481528+0800 Runner[3250:794315] flutter: 13:32:49: [SignalEvent] Instance of 'SignalTrickleEvent'
2022-04-22 13:32:49.482780+0800 Runner[3250:794315] flutter: 13:32:49: [SignalEvent] Instance of 'SignalTrickleEvent'
2022-04-22 13:32:49.483374+0800 Runner[3250:794315] flutter: 13:32:49: Created answer
2022-04-22 13:32:49.492582+0800 Runner[3250:794315] flutter: 13:32:49: got ICE candidate from peer
2022-04-22 13:32:49.493864+0800 Runner[3250:794315] flutter: 13:32:49: subscriber onIceCandidate
2022-04-22 13:32:49.494549+0800 Runner[3250:794315] flutter: 13:32:49: subscriber onIceCandidate
2022-04-22 13:32:49.494798+0800 Runner[3250:794315] flutter: 13:32:49: subscriber onIceCandidate
2022-04-22 13:32:49.495029+0800 Runner[3250:794315] flutter: 13:32:49: subscriber onIceCandidate
2022-04-22 13:32:49.495253+0800 Runner[3250:794315] flutter: 13:32:49: subscriber onIceCandidate
2022-04-22 13:32:49.495473+0800 Runner[3250:794315] flutter: 13:32:49: subscriber onIceCandidate
2022-04-22 13:32:49.495874+0800 Runner[3250:794315] flutter: 13:32:49: pc.getRemoteDescription Instance of 'RTCSessionDescription'
2022-04-22 13:32:49.496513+0800 Runner[3250:794315] flutter: 13:32:49: subscriber onIceCandidate
2022-04-22 13:32:49.496973+0800 Runner[3250:794315] flutter: 13:32:49: got ICE candidate from peer
2022-04-22 13:32:49.497626+0800 Runner[3250:794315] flutter: 13:32:49: [EngineEvent] Engine#55839818 EngineSubscriberPeerStateUpdatedEvent(state: RTCPeerConnectionState.RTCPeerConnectionStateConnecting, isPrimary: true)
2022-04-22 13:32:49.498159+0800 Runner[3250:794315] flutter: 13:32:49: pc.getRemoteDescription Instance of 'RTCSessionDescription'
2022-04-22 13:32:49.498533+0800 Runner[3250:794315] flutter: 13:32:49: got ICE candidate from peer
2022-04-22 13:32:49.498952+0800 Runner[3250:794315] flutter: 13:32:49: pc.getRemoteDescription Instance of 'RTCSessionDescription'
2022-04-22 13:32:49.499247+0800 Runner[3250:794315] flutter: 13:32:49: got ICE candidate from peer
2022-04-22 13:32:49.499455+0800 Runner[3250:794315] flutter: 13:32:49: pc.getRemoteDescription Instance of 'RTCSessionDescription'
2022-04-22 13:32:50.840162+0800 Runner[3250:794315] flutter: 13:32:50: [EngineEvent] Engine#55839818 EngineSubscriberPeerStateUpdatedEvent(state: RTCPeerConnectionState.RTCPeerConnectionStateConnected, isPrimary: true)
2022-04-22 13:32:50.841956+0800 Runner[3250:794315] flutter: 13:32:50: EventsEmitter<EngineEvent>#763088599 event was cancelled by func
2022-04-22 13:32:50.842513+0800 Runner[3250:794315] flutter: 13:32:50: Engine ConnectionState connecting -> connected
2022-04-22 13:32:50.860112+0800 Runner[3250:794315] flutter: 13:32:50: [EngineEvent] Engine#55839818 EngineConnectionStateUpdatedEvent(newState: connected, didReconnect: false, disconnectReason: null)
2022-04-22 13:32:50.941994+0800 Runner[3250:794315] flutter: 13:32:50: Server opened DC label: _reliable
2022-04-22 13:32:50.942190+0800 Runner[3250:794315] flutter: 13:32:50: Server opened DC label: _lossy
2022-04-22 13:32:52.331579+0800 Runner[3250:794315] flutter: 13:32:52: setSourceEnabled(source: TrackSource.camera, enabled: true)
2022-04-22 13:32:52.372524+0800 Runner[3250:794315] flutter: 13:32:52: Compute encodings with resolution: VideoDimensions(960x540), options: VideoPublishOptions(videoEncoding: null, simulcast: true)
2022-04-22 13:32:52.373563+0800 Runner[3250:794315] flutter: 13:32:52: using video encoding
2022-04-22 13:32:52.375971+0800 Runner[3250:794315] flutter: 13:32:52: Using encodings: ({active: true, rid: q, maxBitrate: 120000, maxFramerate: 15, scaleResolutionDownBy: 3.0}, {active: true, rid: h, maxBitrate: 300000, maxFramerate: 20, scaleResolutionDownBy: 1.5}, {active: true, rid: f, maxBitrate: 600000, maxFramerate: 25, scaleResolutionDownBy: 1.0})
2022-04-22 13:32:52.377250+0800 Runner[3250:794315] flutter: 13:32:52: Video layers: (quality: LOW
width: 320
height: 180
bitrate: 120000
, quality: MEDIUM
width: 640
height: 360
bitrate: 300000
, quality: HIGH
width: 960
height: 540
bitrate: 600000
)
2022-04-22 13:32:52.382618+0800 Runner[3250:794315] flutter: 13:32:52: SignalClient onSocketDispose ConnectionState.connected
2022-04-22 13:32:52.382688+0800 Runner[3250:794315] flutter: 13:32:52: SignalClient did disconnect ConnectionState.connected
2022-04-22 13:32:52.382729+0800 Runner[3250:794315] flutter: 13:32:52: SignalClient ConnectionState connected -> disconnected
2022-04-22 13:32:52.383331+0800 Runner[3250:794315] flutter: 13:32:52: [SignalEvent] SignalConnectionStateUpdatedEvent(newState: disconnected, didReconnect: false, disconnectReason: null)
2022-04-22 13:32:52.383762+0800 Runner[3250:794315] flutter: 13:32:52: onDisconnected state:ConnectionState.connected reason:signal
2022-04-22 13:32:52.383819+0800 Runner[3250:794315] flutter: 13:32:52: [Engine] Should attempt reconnect sequence...
2022-04-22 13:32:52.384233+0800 Runner[3250:794315] flutter: 13:32:52: Engine ConnectionState connected -> reconnecting
2022-04-22 13:32:52.384604+0800 Runner[3250:794315] flutter: 13:32:52: Retrying connect sequence remaining 2 tries...
2022-04-22 13:32:52.385164+0800 Runner[3250:794315] flutter: 13:32:52: [EngineEvent] Engine#55839818 EngineConnectionStateUpdatedEvent(newState: reconnecting, didReconnect: false, disconnectReason: null)
2022-04-22 13:32:52.385927+0800 Runner[3250:794315] flutter: 13:32:52: SignalClient connecting with url: wss://hidden/rtc?access_token=hidden&auto_subscribe=1&reconnect=1&protocol=7&sdk=flutter&version=0.5.9&os=iOS&os_version=14.4.2&device_model=iPhone13%2C2
2022-04-22 13:32:52.385978+0800 Runner[3250:794315] flutter: 13:32:52: SignalClient ConnectionState disconnected -> reconnecting
2022-04-22 13:32:52.386041+0800 Runner[3250:794315] flutter: 13:32:52: [SignalClient#782359492] cleanUp()
2022-04-22 13:32:52.386841+0800 Runner[3250:794315] flutter: 13:32:52: [RoomEvent] RoomReconnectingEvent(), will notifyListeners()
2022-04-22 13:32:52.387308+0800 Runner[3250:794315] flutter: 13:32:52: [SignalEvent] SignalConnectionStateUpdatedEvent(newState: reconnecting, didReconnect: false, disconnectReason: null)
2022-04-22 13:32:52.387438+0800 Runner[3250:794315] flutter: 13:32:52: [WebSocketIO] Connecting(uri: wss://hidden/rtc?access_token=hidden&auto_subscribe=1&reconnect=1&protocol=7&sdk=flutter&version=0.5.9&os=iOS&os_version=14.4.2&device_model=iPhone13%2C2)...
2022-04-22 13:32:52.433643+0800 Runner[3250:794315] flutter: 13:32:52: [WebSocketIO] Connected
2022-04-22 13:32:52.433757+0800 Runner[3250:794315] flutter: 13:32:52: SignalClient ConnectionState reconnecting -> connected
2022-04-22 13:32:52.434011+0800 Runner[3250:794315] flutter: 13:32:52: Reconnect: iceConnected: true
2022-04-22 13:32:52.434058+0800 Runner[3250:794315] flutter: 13:32:52: Engine ConnectionState reconnecting -> connected
2022-04-22 13:32:52.434126+0800 Runner[3250:794315] flutter: 13:32:52: [SignalEvent] SignalConnectionStateUpdatedEvent(newState: connected, didReconnect: true, disconnectReason: null)
2022-04-22 13:32:52.434196+0800 Runner[3250:794315] flutter: 13:32:52: Sending syncState
2022-04-22 13:32:52.436454+0800 Runner[3250:794315] flutter: 13:32:52: [EngineEvent] Engine#55839818 EngineConnectionStateUpdatedEvent(newState: connected, didReconnect: true, disconnectReason: null)
2022-04-22 13:32:52.436905+0800 Runner[3250:794315] flutter: 13:32:52: [RoomEvent] RoomReconnectedEvent(), will notifyListeners()
2022-04-22 13:32:52.439325+0800 Runner[3250:794315] flutter: 13:32:52: [SignalEvent] Instance of 'SignalParticipantUpdateEvent'
2022-04-22 13:32:52.439781+0800 Runner[3250:794315] flutter: 13:32:52: [ParticipantEvent] ParticipantPermissionsUpdatedEvent(participant: LocalParticipant(sid: PA_VbHvhdGGzkmB, identity: player9), permissions: Instance of 'ParticipantPermissions'), will notifyListeners()
2022-04-22 13:32:52.439919+0800 Runner[3250:794315] flutter: 13:32:52: [RoomEvent] ParticipantPermissionsUpdatedEvent(participant: LocalParticipant(sid: PA_VbHvhdGGzkmB, identity: player9), permissions: Instance of 'ParticipantPermissions'), will notifyListeners()
2022-04-22 13:32:52.440200+0800 Runner[3250:794315] flutter: 13:32:52: [SignalEvent] Instance of 'SignalOfferEvent'
2022-04-22 13:32:52.440363+0800 Runner[3250:794315] flutter: 13:32:52: [Engine#55839818] Received server offer(type: offer, RTCSignalingState.RTCSignalingStateStable)
2022-04-22 13:32:52.440668+0800 Runner[3250:794315] flutter: 13:32:52: [SignalEvent] Instance of 'SignalTrickleEvent'
2022-04-22 13:32:52.440849+0800 Runner[3250:794315] flutter: 13:32:52: [SignalEvent] Instance of 'SignalTrickleEvent'
2022-04-22 13:32:52.441212+0800 Runner[3250:794315] flutter: 13:32:52: [SignalEvent] Instance of 'SignalTrickleEvent'
2022-04-22 13:32:52.441353+0800 Runner[3250:794315] flutter: 13:32:52: Created answer
2022-04-22 13:32:52.441496+0800 Runner[3250:794315] flutter: 13:32:52: [SignalEvent] Instance of 'SignalTrickleEvent'
2022-04-22 13:32:52.441912+0800 Runner[3250:794315] flutter: 13:32:52: got ICE candidate from peer
2022-04-22 13:32:52.442141+0800 Runner[3250:794315] flutter: 13:32:52: subscriber onIceCandidate
2022-04-22 13:32:52.442342+0800 Runner[3250:794315] flutter: 13:32:52: subscriber onIceCandidate
2022-04-22 13:32:52.442489+0800 Runner[3250:794315] flutter: 13:32:52: subscriber onIceCandidate
2022-04-22 13:32:52.442634+0800 Runner[3250:794315] flutter: 13:32:52: subscriber onIceCandidate
2022-04-22 13:32:52.442784+0800 Runner[3250:794315] flutter: 13:32:52: subscriber onIceCandidate
2022-04-22 13:32:52.442971+0800 Runner[3250:794315] flutter: 13:32:52: subscriber onIceCandidate
2022-04-22 13:32:52.443163+0800 Runner[3250:794315] flutter: 13:32:52: pc.getRemoteDescription Instance of 'RTCSessionDescription'
2022-04-22 13:32:52.448282+0800 Runner[3250:794315] flutter: 13:32:52: got ICE candidate from peer
2022-04-22 13:32:52.448695+0800 Runner[3250:794315] flutter: 13:32:52: pc.getRemoteDescription Instance of 'RTCSessionDescription'
2022-04-22 13:32:52.448990+0800 Runner[3250:794315] flutter: 13:32:52: got ICE candidate from peer
2022-04-22 13:32:52.449212+0800 Runner[3250:794315] flutter: 13:32:52: pc.getRemoteDescription Instance of 'RTCSessionDescription'
2022-04-22 13:32:52.449506+0800 Runner[3250:794315] flutter: 13:32:52: got ICE candidate from peer
2022-04-22 13:32:52.449797+0800 Runner[3250:794315] flutter: 13:32:52: pc.getRemoteDescription Instance of 'RTCSessionDescription'
2022-04-22 13:32:52.451870+0800 Runner[3250:794315] flutter: 13:32:52: subscriber onIceCandidate
2022-04-22 13:32:52.506159+0800 Runner[3250:794315] flutter: 13:32:52: subscriber onIceCandidate
2022-04-22 13:32:54.333805+0800 Runner[3250:794315] flutter: 13:32:54: [SignalEvent] Instance of 'SignalConnectionQualityUpdateEvent'
2022-04-22 13:32:54.337294+0800 Runner[3250:794315] flutter: 13:32:54: [ParticipantEvent] ParticipantConnectionQualityUpdatedEvent(participant: LocalParticipant(sid: PA_VbHvhdGGzkmB, identity: player9), connectionQuality: ConnectionQuality.excellent), will notifyListeners()
2022-04-22 13:32:54.337662+0800 Runner[3250:794315] flutter: 13:32:54: [RoomEvent] ParticipantConnectionQualityUpdatedEvent(participant: LocalParticipant(sid: PA_VbHvhdGGzkmB, identity: player9), connectionQuality: ConnectionQuality.excellent), will notifyListeners()
2022-04-22 13:32:57.329438+0800 Runner[3250:794315] flutter: 13:32:57: SignalClient onSocketDispose ConnectionState.connected
2022-04-22 13:32:57.329774+0800 Runner[3250:794315] flutter: 13:32:57: SignalClient did disconnect ConnectionState.connected
2022-04-22 13:32:57.330014+0800 Runner[3250:794315] flutter: 13:32:57: SignalClient ConnectionState connected -> disconnected
2022-04-22 13:32:57.330736+0800 Runner[3250:794315] flutter: 13:32:57: [SignalEvent] SignalConnectionStateUpdatedEvent(newState: disconnected, didReconnect: false, disconnectReason: null)
2022-04-22 13:32:57.331730+0800 Runner[3250:794315] flutter: 13:32:57: onDisconnected state:ConnectionState.connected reason:signal
2022-04-22 13:32:57.332015+0800 Runner[3250:794315] flutter: 13:32:57: [Engine] Should attempt reconnect sequence...
2022-04-22 13:32:57.332250+0800 Runner[3250:794315] flutter: 13:32:57: Engine ConnectionState connected -> reconnecting
2022-04-22 13:32:57.332559+0800 Runner[3250:794315] flutter: 13:32:57: Retrying connect sequence remaining 2 tries...
2022-04-22 13:32:57.333524+0800 Runner[3250:794315] flutter: 13:32:57: [EngineEvent] Engine#55839818 EngineConnectionStateUpdatedEvent(newState: reconnecting, didReconnect: false, disconnectReason: null)
2022-04-22 13:32:57.334715+0800 Runner[3250:794315] flutter: 13:32:57: SignalClient connecting with url: wss://hidden/rtc?access_token=hidden&auto_subscribe=1&reconnect=1&protocol=7&sdk=flutter&version=0.5.9&os=iOS&os_version=14.4.2&device_model=iPhone13%2C2
2022-04-22 13:32:57.334912+0800 Runner[3250:794315] flutter: 13:32:57: SignalClient ConnectionState disconnected -> reconnecting
2022-04-22 13:32:57.335305+0800 Runner[3250:794315] flutter: 13:32:57: [SignalClient#782359492] cleanUp()
2022-04-22 13:32:57.335768+0800 Runner[3250:794315] flutter: 13:32:57: [RoomEvent] RoomReconnectingEvent(), will notifyListeners()
2022-04-22 13:32:57.336217+0800 Runner[3250:794315] flutter: 13:32:57: [SignalEvent] SignalConnectionStateUpdatedEvent(newState: reconnecting, didReconnect: false, disconnectReason: null)
2022-04-22 13:32:57.337263+0800 Runner[3250:794315] flutter: 13:32:57: [WebSocketIO] Connecting(uri: wss://hidden/rtc?access_token=hidden&auto_subscribe=1&reconnect=1&protocol=7&sdk=flutter&version=0.5.9&os=iOS&os_version=14.4.2&device_model=iPhone13%2C2)...
2022-04-22 13:32:57.406239+0800 Runner[3250:794315] flutter: 13:32:57: [WebSocketIO] Connected
2022-04-22 13:32:57.406425+0800 Runner[3250:794315] flutter: 13:32:57: SignalClient ConnectionState reconnecting -> connected
2022-04-22 13:32:57.406592+0800 Runner[3250:794315] flutter: 13:32:57: Reconnect: iceConnected: true
2022-04-22 13:32:57.406711+0800 Runner[3250:794315] flutter: 13:32:57: Engine ConnectionState reconnecting -> connected
2022-04-22 13:32:57.406889+0800 Runner[3250:794315] flutter: 13:32:57: [SignalEvent] SignalConnectionStateUpdatedEvent(newState: connected, didReconnect: true, disconnectReason: null)
2022-04-22 13:32:57.407071+0800 Runner[3250:794315] flutter: 13:32:57: Sending syncState
2022-04-22 13:32:57.407466+0800 Runner[3250:794315] flutter: 13:32:57: [EngineEvent] Engine#55839818 EngineConnectionStateUpdatedEvent(newState: connected, didReconnect: true, disconnectReason: null)
2022-04-22 13:32:57.407748+0800 Runner[3250:794315] flutter: 13:32:57: [RoomEvent] RoomReconnectedEvent(), will notifyListeners()
2022-04-22 13:32:57.410926+0800 Runner[3250:794315] flutter: 13:32:57: [SignalEvent] Instance of 'SignalParticipantUpdateEvent'
2022-04-22 13:32:57.411267+0800 Runner[3250:794315] flutter: 13:32:57: [ParticipantEvent] ParticipantPermissionsUpdatedEvent(participant: LocalParticipant(sid: PA_VbHvhdGGzkmB, identity: player9), permissions: Instance of 'ParticipantPermissions'), will notifyListeners()
2022-04-22 13:32:57.411401+0800 Runner[3250:794315] flutter: 13:32:57: [RoomEvent] ParticipantPermissionsUpdatedEvent(participant: LocalParticipant(sid: PA_VbHvhdGGzkmB, identity: player9), permissions: Instance of 'ParticipantPermissions'), will notifyListeners()
2022-04-22 13:32:57.412058+0800 Runner[3250:794315] flutter: 13:32:57: [SignalEvent] Instance of 'SignalOfferEvent'
2022-04-22 13:32:57.412332+0800 Runner[3250:794315] flutter: 13:32:57: [Engine#55839818] Received server offer(type: offer, RTCSignalingState.RTCSignalingStateStable)
2022-04-22 13:32:57.412972+0800 Runner[3250:794315] flutter: 13:32:57: [SignalEvent] Instance of 'SignalTrickleEvent'
2022-04-22 13:32:57.413653+0800 Runner[3250:794315] flutter: 13:32:57: [SignalEvent] Instance of 'SignalTrickleEvent'
2022-04-22 13:32:57.414482+0800 Runner[3250:794315] flutter: 13:32:57: [SignalEvent] Instance of 'SignalTrickleEvent'
2022-04-22 13:32:57.414871+0800 Runner[3250:794315] flutter: 13:32:57: Created answer
2022-04-22 13:32:57.415195+0800 Runner[3250:794315] flutter: 13:32:57: [SignalEvent] Instance of 'SignalTrickleEvent'
2022-04-22 13:32:57.416019+0800 Runner[3250:794315] flutter: 13:32:57: got ICE candidate from peer
2022-04-22 13:32:57.416554+0800 Runner[3250:794315] flutter: 13:32:57: subscriber onIceCandidate
2022-04-22 13:32:57.417016+0800 Runner[3250:794315] flutter: 13:32:57: subscriber onIceCandidate
2022-04-22 13:32:57.417364+0800 Runner[3250:794315] flutter: 13:32:57: subscriber onIceCandidate
2022-04-22 13:32:57.417687+0800 Runner[3250:794315] flutter: 13:32:57: subscriber onIceCandidate
2022-04-22 13:32:57.418007+0800 Runner[3250:794315] flutter: 13:32:57: subscriber onIceCandidate
2022-04-22 13:32:57.418336+0800 Runner[3250:794315] flutter: 13:32:57: pc.getRemoteDescription Instance of 'RTCSessionDescription'
2022-04-22 13:32:57.418581+0800 Runner[3250:794315] flutter: 13:32:57: subscriber onIceCandidate
2022-04-22 13:32:57.419217+0800 Runner[3250:794315] flutter: 13:32:57: got ICE candidate from peer
2022-04-22 13:32:57.419774+0800 Runner[3250:794315] flutter: 13:32:57: pc.getRemoteDescription Instance of 'RTCSessionDescription'
2022-04-22 13:32:57.428253+0800 Runner[3250:794315] flutter: 13:32:57: got ICE candidate from peer
2022-04-22 13:32:57.428580+0800 Runner[3250:794315] flutter: 13:32:57: subscriber onIceCandidate
2022-04-22 13:32:57.429124+0800 Runner[3250:794315] flutter: 13:32:57: pc.getRemoteDescription Instance of 'RTCSessionDescription'
2022-04-22 13:32:57.429623+0800 Runner[3250:794315] flutter: 13:32:57: got ICE candidate from peer
2022-04-22 13:32:57.429951+0800 Runner[3250:794315] flutter: 13:32:57: pc.getRemoteDescription Instance of 'RTCSessionDescription'
2022-04-22 13:32:57.476220+0800 Runner[3250:794315] flutter: 13:32:57: subscriber onIceCandidate
2022-04-22 13:32:57.523107+0800 Runner[3250:794315] flutter: 13:32:57: subscriber onIceCandidate
2022-04-22 13:32:57.524598+0800 Runner[3250:794315] flutter: 13:32:57: subscriber onIceCandidate
2022-04-22 13:32:57.525681+0800 Runner[3250:794315] flutter: 13:32:57: subscriber onIceCandidate
2022-04-22 13:32:57.526599+0800 Runner[3250:794315] flutter: 13:32:57: subscriber onIceCandidate
2022-04-22 13:32:57.527398+0800 Runner[3250:794315] flutter: 13:32:57: subscriber onIceCandidate
2022-04-22 13:32:57.528152+0800 Runner[3250:794315] flutter: 13:32:57: subscriber onIceCandidate
2022-04-22 13:32:59.432153+0800 Runner[3250:794315] flutter: 13:32:59: [SignalEvent] Instance of 'SignalConnectionQualityUpdateEvent'
2022-04-22 13:33:02.373931+0800 Runner[3250:794315] flutter: 13:33:02: SignalClient onSocketDispose ConnectionState.connected
2022-04-22 13:33:02.374373+0800 Runner[3250:794315] flutter: 13:33:02: SignalClient did disconnect ConnectionState.connected
2022-04-22 13:33:02.374718+0800 Runner[3250:794315] flutter: 13:33:02: SignalClient ConnectionState connected -> disconnected
2022-04-22 13:33:02.375763+0800 Runner[3250:794315] flutter: 13:33:02: [SignalEvent] SignalConnectionStateUpdatedEvent(newState: disconnected, didReconnect: false, disconnectReason: null)
2022-04-22 13:33:02.376753+0800 Runner[3250:794315] flutter: 13:33:02: onDisconnected state:ConnectionState.connected reason:signal
2022-04-22 13:33:02.377116+0800 Runner[3250:794315] flutter: 13:33:02: [Engine] Should attempt reconnect sequence...
2022-04-22 13:33:02.377412+0800 Runner[3250:794315] flutter: 13:33:02: Engine ConnectionState connected -> reconnecting
2022-04-22 13:33:02.377970+0800 Runner[3250:794315] flutter: 13:33:02: Retrying connect sequence remaining 2 tries...
2022-04-22 13:33:02.378547+0800 Runner[3250:794315] flutter: 13:33:02: [EngineEvent] Engine#55839818 EngineConnectionStateUpdatedEvent(newState: reconnecting, didReconnect: false, disconnectReason: null)
2022-04-22 13:33:02.379580+0800 Runner[3250:794315] flutter: 13:33:02: SignalClient connecting with url: wss://hidden/rtc?access_token=hidden&auto_subscribe=1&reconnect=1&protocol=7&sdk=flutter&version=0.5.9&os=iOS&os_version=14.4.2&device_model=iPhone13%2C2
2022-04-22 13:33:02.379798+0800 Runner[3250:794315] flutter: 13:33:02: SignalClient ConnectionState disconnected -> reconnecting
2022-04-22 13:33:02.380137+0800 Runner[3250:794315] flutter: 13:33:02: [SignalClient#782359492] cleanUp()
2022-04-22 13:33:02.380486+0800 Runner[3250:794315] flutter: 13:33:02: [RoomEvent] RoomReconnectingEvent(), will notifyListeners()
2022-04-22 13:33:02.380840+0800 Runner[3250:794315] flutter: 13:33:02: [SignalEvent] SignalConnectionStateUpdatedEvent(newState: reconnecting, didReconnect: false, disconnectReason: null)
2022-04-22 13:33:02.381354+0800 Runner[3250:794315] flutter: 13:33:02: [WebSocketIO] Connecting(uri: wss://hidden/rtc?access_token=hidden&auto_subscribe=1&reconnect=1&protocol=7&sdk=flutter&version=0.5.9&os=iOS&os_version=14.4.2&device_model=iPhone13%2C2)...
2022-04-22 13:33:02.386961+0800 Runner[3250:794315] flutter: 13:33:02: EventsListener<SignalEvent>#453412181 event was cancelled by func
2022-04-22 13:33:02.387701+0800 Runner[3250:794315] flutter: could not publish video: LiveKit Exception TrackPublishException Failed to publish track
2022-04-22 13:33:02.462208+0800 Runner[3250:794315] flutter: 13:33:02: [WebSocketIO] Connected
2022-04-22 13:33:02.462333+0800 Runner[3250:794315] flutter: 13:33:02: SignalClient ConnectionState reconnecting -> connected
2022-04-22 13:33:02.462426+0800 Runner[3250:794315] flutter: 13:33:02: Reconnect: iceConnected: true
2022-04-22 13:33:02.462481+0800 Runner[3250:794315] flutter: 13:33:02: Engine ConnectionState reconnecting -> connected
2022-04-22 13:33:02.462575+0800 Runner[3250:794315] flutter: 13:33:02: [SignalEvent] SignalConnectionStateUpdatedEvent(newState: connected, didReconnect: true, disconnectReason: null)
2022-04-22 13:33:02.462668+0800 Runner[3250:794315] flutter: 13:33:02: Sending syncState
2022-04-22 13:33:02.462906+0800 Runner[3250:794315] flutter: 13:33:02: [EngineEvent] Engine#55839818 EngineConnectionStateUpdatedEvent(newState: connected, didReconnect: true, disconnectReason: null)
2022-04-22 13:33:02.463021+0800 Runner[3250:794315] flutter: 13:33:02: [RoomEvent] RoomReconnectedEvent(), will notifyListeners()
2022-04-22 13:33:02.464580+0800 Runner[3250:794315] flutter: 13:33:02: [SignalEvent] Instance of 'SignalParticipantUpdateEvent'
2022-04-22 13:33:02.464717+0800 Runner[3250:794315] flutter: 13:33:02: [ParticipantEvent] ParticipantPermissionsUpdatedEvent(participant: LocalParticipant(sid: PA_VbHvhdGGzkmB, identity: player9), permissions: Instance of 'ParticipantPermissions'), will notifyListeners()
2022-04-22 13:33:02.464767+0800 Runner[3250:794315] flutter: 13:33:02: [RoomEvent] ParticipantPermissionsUpdatedEvent(participant: LocalParticipant(sid: PA_VbHvhdGGzkmB, identity: player9), permissions: Instance of 'ParticipantPermissions'), will notifyListeners()
2022-04-22 13:33:02.469530+0800 Runner[3250:794315] flutter: 13:33:02: [SignalEvent] Instance of 'SignalOfferEvent'
2022-04-22 13:33:02.469687+0800 Runner[3250:794315] flutter: 13:33:02: [Engine#55839818] Received server offer(type: offer, RTCSignalingState.RTCSignalingStateStable)
2022-04-22 13:33:02.473748+0800 Runner[3250:794315] flutter: 13:33:02: [SignalEvent] Instance of 'SignalTrickleEvent'
2022-04-22 13:33:02.475531+0800 Runner[3250:794315] flutter: 13:33:02: [SignalEvent] Instance of 'SignalTrickleEvent'
2022-04-22 13:33:02.476631+0800 Runner[3250:794315] flutter: 13:33:02: Created answer
2022-04-22 13:33:02.476955+0800 Runner[3250:794315] flutter: 13:33:02: [SignalEvent] Instance of 'SignalTrickleEvent'
2022-04-22 13:33:02.478268+0800 Runner[3250:794315] flutter: 13:33:02: got ICE candidate from peer
2022-04-22 13:33:02.478502+0800 Runner[3250:794315] flutter: 13:33:02: [SignalEvent] Instance of 'SignalTrickleEvent'
2022-04-22 13:33:02.478767+0800 Runner[3250:794315] flutter: 13:33:02: subscriber onIceCandidate
2022-04-22 13:33:02.479006+0800 Runner[3250:794315] flutter: 13:33:02: subscriber onIceCandidate
2022-04-22 13:33:02.479517+0800 Runner[3250:794315] flutter: 13:33:02: subscriber onIceCandidate
2022-04-22 13:33:02.479681+0800 Runner[3250:794315] flutter: 13:33:02: subscriber onIceCandidate
2022-04-22 13:33:02.479838+0800 Runner[3250:794315] flutter: 13:33:02: subscriber onIceCandidate
2022-04-22 13:33:02.479992+0800 Runner[3250:794315] flutter: 13:33:02: subscriber onIceCandidate
2022-04-22 13:33:02.480141+0800 Runner[3250:794315] flutter: 13:33:02: pc.getRemoteDescription Instance of 'RTCSessionDescription'
2022-04-22 13:33:02.480809+0800 Runner[3250:794315] flutter: 13:33:02: got ICE candidate from peer
2022-04-22 13:33:02.481125+0800 Runner[3250:794315] flutter: 13:33:02: pc.getRemoteDescription Instance of 'RTCSessionDescription'
2022-04-22 13:33:02.482592+0800 Runner[3250:794315] flutter: 13:33:02: got ICE candidate from peer
2022-04-22 13:33:02.482862+0800 Runner[3250:794315] flutter: 13:33:02: pc.getRemoteDescription Instance of 'RTCSessionDescription'
2022-04-22 13:33:02.483329+0800 Runner[3250:794315] flutter: 13:33:02: got ICE candidate from peer
2022-04-22 13:33:02.483934+0800 Runner[3250:794315] flutter: 13:33:02: pc.getRemoteDescription Instance of 'RTCSessionDescription'
2022-04-22 13:33:02.486181+0800 Runner[3250:794315] flutter: 13:33:02: subscriber onIceCandidate
2022-04-22 13:33:02.554100+0800 Runner[3250:794315] flutter: 13:33:02: subscriber onIceCandidate
2022-04-22 13:33:02.585243+0800 Runner[3250:794315] flutter: 13:33:02: subscriber onIceCandidate
2022-04-22 13:33:02.585654+0800 Runner[3250:794315] flutter: 13:33:02: subscriber onIceCandidate
2022-04-22 13:33:02.585915+0800 Runner[3250:794315] flutter: 13:33:02: subscriber onIceCandidate
2022-04-22 13:33:02.586168+0800 Runner[3250:794315] flutter: 13:33:02: subscriber onIceCandidate
2022-04-22 13:33:02.586405+0800 Runner[3250:794315] flutter: 13:33:02: subscriber onIceCandidate
2022-04-22 13:33:02.586640+0800 Runner[3250:794315] flutter: 13:33:02: subscriber onIceCandidate

I think the problem was
2022-04-22 13:33:02.381354+0800 Runner[3250:794315] flutter: 13:33:02: [WebSocketIO] Connecting(uri: wss://hidden/rtc?access_token=hidden&auto_subscribe=1&reconnect=1&protocol=7&sdk=flutter&version=0.5.9&os=iOS&os_version=14.4.2&device_model=iPhone13%2C2)...
2022-04-22 13:33:02.386961+0800 Runner[3250:794315] flutter: 13:33:02: EventsListener<SignalEvent>#453412181 event was cancelled by func
2022-04-22 13:33:02.387701+0800 Runner[3250:794315] flutter: could not publish video: LiveKit Exception TrackPublishException Failed to publish track
2022-04-22 13:33:02.462208+0800 Runner[3250:794315] flutter: 13:33:02: [WebSocketIO] Connected
2022-04-22 13:33:02.462333+0800 Runner[3250:794315] flutter: 13:33:02: SignalClient ConnectionState reconnecting -> connected
2022-04-22 13:33:02.462426+0800 Runner[3250:794315] flutter: 13:33:02: Reconnect: iceConnected: true
2022-04-22 13:33:02.462481+0800 Runner[3250:794315] flutter: 13:33:02: Engine ConnectionState reconnecting -> connected

too early to publish video track, it was happening before connection established, I think we need to wait or try again silently

I can see it's trying to reconnect. Can you try with stable network ?

As discussed in Slack, the initial connect needs to complete successfully before you can publish to the room. Closing the issue.


cli: set up testing

first idea: go with integration tests; update docker-compose-test to also include a rask_api service that rask_cli's tests can target

as part of this ticket i'm expecting to have to sort out updating the API_ROOT based on env vars


How to import validate/validate.proto into .proto file using python?

Getting error while importing.
syntax = "proto3";
import "google/protobuf/timestamp.proto";
import "validate/validate.proto";

Error:
Import "validate/validate.proto" was not found or had errors

What does return this error? You need to copy validate/validate.proto into your workspace to make it work. It's not a known type compared to "google/protobuf/timestamp.proto".
In my case, I have /code which is a root directory and inside it I have proto/ which contains my Protocol Buffer files. I also have protoc-gen-validate/ which contains validate/validate.proto.
For Go, you can handle it different, that is do go get -d github.com/envoyproxy/protoc-gen-validate and add -I=${GOPATH}/src/github.com/envoyproxy/protoc-gen-validate:
protoc \
    -I=/code/proto \
    -I=${GOPATH}/src/github.com/envoyproxy/protoc-gen-validate \
    --go_opt=paths=source_relative \
    --go_out=/gen \
    --go-grpc_opt=paths=source_relative \
    --go-grpc_out=/gen \
    --validate_out=paths=source_relative,lang=go:/gen \
    $(find /code/proto -name '*.proto')

For Python I have:
python -m grpc_tools.protoc \
    -I=/code/proto \
    -I=/code/protoc-gen-validate \
    --python_out=/gen \
    --grpc_python_out=/gen \
    $(find /code/proto -name '*.proto')

Generate the following tree structure.
validate/
├── __init__.py
├── validate
│   └── validate.proto
└── validator.py

Run the following command to compile the protos from outside of this structure. Output for ls command must be validate only.
python -m grpc_tools.protoc -I validate --python_out=. --grpc_python_out=. validate/validate.proto

This will give you the following tree
validate/
├── __init__.py
├── validate
│   └── validate.proto
├── validate_pb2.py
├── validate_pb2_grpc.py
└── validator.py

Add this directory to sitepackage or this directory must be in the python path for validate to work.

@adambabik ..
I use GoLand 2020.2 IDE for development. I have proto-gen-validate downloaded into GOPATH using go get -d github.com/envoyproxy/protoc-gen-validate. I am able to compile the proto without any issue. But I see the red lines for my import statements saying "Cannot import or resolve". The red lines are not causing any problem but its very annoying. Did you have to solve this problem? If so can you please share.
protoc -I proto/ proto/xyz.proto \
	-I ${GOPATH}/src/github.com/envoyproxy/protoc-gen-validate \
	-I ${GOPATH}/src/github.com/grpc-ecosystem/grpc-gateway/third_party/googleapis \
        -I ${GOPATH}/src/github.com/grpc-ecosystem/grpc-gateway \
	--validate_out="lang=go:./proto" \
	--go_out=plugins=grpc:proto \
        --include_imports --descriptor_set_out=proto/xyz.pb

@rishi-suresh-keshav do you mean the errors when editing a protobuf file in GoLand? If so, it's likely you need to add custom import paths to the Protocol Buffer Editor plugin in GoLand. Go to Language & Frameworks > Protocol Buffers and uncheck "Configure automatically". To the existing list of folders, add ${GOPATH}/src/github.com/envoyproxy/protoc-gen-validate and others.

@adambabik @munagekar care to share a link to repo with a working example?
it could even be better if i see how to generate the code and how to use it
thanks!

There's now a package on PyPI:  https://pypi.org/project/protoc-gen-validate

as @dkunitsk mentioned. issue was resolved in PR #433
thanks a lot!

@dkunitsk actually when i try now to use the package it still doesnt solve my folder structure issue.
this is my proto:
syntax = "proto3";

import "validate/validate.proto";

which generates the code with those imports:
from validate import validate_pb2 as validate_dot_validate__pb2

and get this error when trying to load it:
 from validate import validate_pb2 as validate_dot_validate__pb2
E   ImportError: cannot import name 'validate_pb2' from 'validate' (unknown location)

to solve it i still need to use that hack above
unless im missing something...

@buzzdan the process above described by @adambabik isn't a hack, it's the proper way to use this library. Sorry for not understanding your original question.
Importing validate.proto into your source proto file is the first step to annotate your source schemas. It will involve copy-pasting validate.proto locally, there's no way around this.

@dkunitsk ok so i didnt get it.
so first of all, if this is the official recommended way by this project i suggest to include this explanation in the projects readme (python section).
second, i would think of adding validate.proto to the pip package somehow, and , if possible, its generated version.
third, a working example (just a dummy hello world), would be great!

@dkunitsk just to be fully understood:
what @munagekar did is generate validate_pb2.py from validate/validate.proto
so when i get this generated code:
from validate import validate_pb2 as validate_dot_validate__pb2

it will have validate and validate_pb2 therefore it will not break

@buzzdan have you been able to use this at all in Python? Still stuck with broken imports while using the new package. Thanks in advance

I resolved de annoying error message of Import "validate/validate.proto" was not found or had errors on vscode and in my go project with a workround.
I just copied the folder<EMAIL_ADDRESS>to my root project (where my proto file was).

Generate the following tree structure.
validate/
├── __init__.py
├── validate
│   └── validate.proto
└── validator.py

Run the following command to compile the protos from outside of this structure. Output for ls command must be validate only.
python -m grpc_tools.protoc -I validate --python_out=. --grpc_python_out=. validate/validate.proto

This will give you the following tree
validate/
├── __init__.py
├── validate
│   └── validate.proto
├── validate_pb2.py
├── validate_pb2_grpc.py
└── validator.py

Add this directory to sitepackage or this directory must be in the python path for validate to work.

I'm not sure if this works anymore. I've done the above, and still get this error:
TypeError: Couldn't build proto file into descriptor pool!
Invalid proto descriptor for file "api/cple_service/v1/state_references.proto":
  validate/validate.proto: Import "validate/validate.proto" has not been loaded.

I've actually added validate/validate.proto into about a dozen different directories, and added a plethora of directories to sys.path, and it still gives this error.

Does that mean that it's looking for validate/validate.proto from the current working directory? (And not from any path??)

If anyone is stuck, and finds this thread, this solved the problem:
python3 -m pip install --upgrade pip
pip3 install grpcio
pip3 install google-api-python-client
pip3 install grpcio-tools

The error message seems like a misdirection. I traced the code into protobuf, so this actually had nothing to do with protoc-gen-validate

As far as I can tell, protoc-gen-validate is broken on python 3.8, using the latest grpc from pip3. If only there were a simple way to tell protobuf where to look for dependencies, when driven through the code gen in this project. I'm not an expert on protobuf... but this error is happening inside that code:
TypeError: Couldn't build proto file into descriptor pool

So maybe I'm just using it wrong.

This works on Ubuntu 20.04:
Install dependencies
python3 -m pip install --upgrade pip
python3 -m pip install PyYAML grpcio grpcio-tools yq protobuf protoc-gen-validate==0.4.1

Download pgv, and create dependency files
DIRECTORY=/path/to/files
mkdir -p "$DIRECTORY"
cd "$DIRECTORY"

wget https://github.com/envoyproxy/protoc-gen-validate/archive/main.zip
unzip main.zip
rm main.zip
mv protoc-gen-validate-* protoc-gen-validate

python3 -m grpc_tools.protoc                          \
            -I $DIRECTORY/protoc-gen-validate             \
            --python_out=.                                \
            --grpc_python_out=.                           \
	    $DIRECTORY/protoc-gen-validate/validate/*.proto

To run your code, you need to edit PYTHONPATH, something like this:
export PYTHONPATH="$DIRECTORY:$DIRECTORY/protoc-gen-validate"

Is there any chance you can show me an example of Java?


The generated code should be placed in a separate folder.

The generated code should be placed in a separate folder
Since the automatically generated code is not intended to be edited further. So the location for generated code should be placed together and in another folder or can be customized by the user .
This will make the project structure more clear.

Source_gen already does that. See their documentation :)


[FEATURE REQUEST] automaticaly saving files into a folder called "outputs"

Basically the title, instead of having to download the music generated one by one, I would like the files to be availble inside a folder called "outputs".

I personally did such option on my repo, it stores them inside output folder and separates to dates and file type.
If you're interested here is the repo: https://github.com/GrandaddyShmax/audiocraft_plus


feat(lobbies): add lobbies module

#110  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @NathanFlurry and the rest of your teammates on  Graphite

Merge activity

Aug 16, 8:51 AM EDT: @NathanFlurry started a stack merge that includes this pull request via Graphite.


ci: Update main project package-lock.json

:tada: This PR is included in version 1.32.3 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


tldextract tries to access a web page if email address is part of the analyzed text (Offline mode)

Describe the bug
I'm using presidio in an offline mode (without network). I'm assuming my machine has a pre-downloaded Spacy model. I'm loading it in the following way: https://github.com/microsoft/presidio/issues/1204#issuecomment-1792990076
I'm mostly interested in the analyzer. I've noticed that in some flows, the analyzer.analyze tries to access the web, specifically using tldextract it tries to access https://publicsuffix.org/list/public_suffix_list.dat
This flow only happens if the analyzed text contains email addresses. for example "Hello my email address is<EMAIL_ADDRESS>To Reproduce
Use the following code to setup: https://github.com/microsoft/presidio/issues/1204#issuecomment-1792990076
Inject an email address into the analyzed text.
Presidio will be stuck trying to access the .bat file with public suffixes and will Timeout after a few minutes
Expected behavior
Presidio should analyze the text without trying to access the internet
Screenshots

Thanks @restrictedalex96.
Here are some possible workarounds:

Remove the url and email recognizers, if you don't need emails and urls detected
Leverage the logic in the URL and email recognizers, without the tldextract validation, by inheriting their classes and overloading the validate method with return True
Handle the tldextract cache prior to running Presidio or monkeypatch tldextract

If you need more information on each of these, please let us know. We will look into finding alternative ways to validate emails and URLs without having to go online.

See more on tldextract caching here: https://github.com/john-kurkowski/tldextract#note-about-caching
You can pre-download the cache and avoid live http calls.

Thank you!


Swagger fails on response type of ObjectNode

Several of our REST APIs return ObjectNode as a free-form JSON object.  JAXRS handles this cleanly.  However, swagger fails to initialize in this scenario with the following error:
java.lang.IllegalArgumentException: Conflicting setter definitions for property "all": com.fasterxml.jackson.databind.node.ObjectNode#setAll(1 params) vs com.fasterxml.jackson.databind.node.ObjectNode#setAll(1 params)
    at com.fasterxml.jackson.databind.introspect.POJOPropertyBuilder.getSetter(POJOPropertyBuilder.java:320)
    at io.swagger.jackson.ModelResolver.resolve(ModelResolver.java:267)
    at io.swagger.jackson.ModelResolver.resolve(ModelResolver.java:149)

It would be nice for swagger to not to be completely unusable in this scenario.  For example, the implementation could special case ObjectNode response types and document as a schema-less response object.

Hi guys, Any workaround for this @sirianni?

@borillo
Today,I ran also into this problem by coincidence. Unfortunately I can`t spend lots of time atm looking for the correct fix, but as a quick workaround that seems to work is to manually override the version of the Jackson libraries using maven.
Maybe to need to try several versions. 2.7.4 didn`t work but 2.5.4 for some reason does. I will check later what the difference is in the source code.
The proper fix for this project would be to update the version of Jackson
e.g.
<dependencies>
   <dependency>
      <groupId>io.swagger</groupId>
      <artifactId>swagger-jaxrs</artifactId>
      <exclusions>
         <exclusion>
            <groupId>com.fasterxml.jackson.module</groupId>
            <artifactId>jackson-module-jaxb-annotations</artifactId>
         </exclusion>
         <exclusion>
            <groupId>com.fasterxml.jackson.dataformat</groupId>
            <artifactId>jackson-dataformat-xml</artifactId>
         </exclusion>
         <exclusion>
            <groupId>com.fasterxml.jackson.jaxrs</groupId>
            <artifactId>jackson-jaxrs-json-provider</artifactId>
         </exclusion>
         <exclusion>
            <groupId>com.fasterxml.jackson.dataformat</groupId>
            <artifactId>jackson-dataformat-yaml</artifactId>
         </exclusion>
         <exclusion>
            <groupId>com.fasterxml.jackson.core</groupId>
            <artifactId>jackson-annotations</artifactId>
         </exclusion>
         <exclusion>
            <groupId>com.fasterxml.jackson.core</groupId>
            <artifactId>jackson-databind</artifactId>
         </exclusion>
         <exclusion>
            <groupId>com.fasterxml.jackson.core</groupId>
            <artifactId>jackson-core</artifactId>
         </exclusion>
         <exclusion>
            <groupId>com.fasterxml.jackson.datatype</groupId>
            <artifactId>jackson-datatype-joda</artifactId>
         </exclusion>
         <exclusion>
            <groupId>com.fasterxml.jackson.jaxrs</groupId>
            <artifactId>jackson-jaxrs-base</artifactId>
         </exclusion>
      </exclusions>
   </dependency>
   <dependency>
      <groupId>com.fasterxml.jackson.module</groupId>
      <artifactId>jackson-module-jaxb-annotations</artifactId>
      <version>2.5.4</version>
   </dependency>
   <dependency>
      <groupId>com.fasterxml.jackson.dataformat</groupId>
      <artifactId>jackson-dataformat-xml</artifactId>
      <version>2.5.4</version>
   </dependency>
   <dependency>
      <groupId>com.fasterxml.jackson.jaxrs</groupId>
      <artifactId>jackson-jaxrs-json-provider</artifactId>
      <version>2.5.4</version>
   </dependency>
   <dependency>
      <groupId>com.fasterxml.jackson.dataformat</groupId>
      <artifactId>jackson-dataformat-yaml</artifactId>
      <version>2.5.4</version>
   </dependency>
   <dependency>
      <groupId>com.fasterxml.jackson.core</groupId>
      <artifactId>jackson-annotations</artifactId>
      <version>2.5.4</version>
   </dependency>
   <dependency>
      <groupId>com.fasterxml.jackson.core</groupId>
      <artifactId>jackson-databind</artifactId>
      <version>2.5.4</version>
   </dependency>
   <dependency>
      <groupId>com.fasterxml.jackson.core</groupId>
      <artifactId>jackson-core</artifactId>
      <version>2.5.4</version>
   </dependency>
   <dependency>
      <groupId>com.fasterxml.jackson.datatype</groupId>
      <artifactId>jackson-datatype-joda</artifactId>
      <version>2.5.4</version>
   </dependency>
   <dependency>
      <groupId>com.fasterxml.jackson.jaxrs</groupId>
      <artifactId>jackson-jaxrs-base</artifactId>
      <version>2.5.4</version>
   </dependency>
</dependencies>

Thx a lot for the workaround @StevenChoo!!

Try snapshot, we've updated the jackson version there.

I am trying to use this plugin:
https://github.com/gigaSproule/swagger-gradle-plugin
And I am seeing this error. Anyone know a clever way to work around it? Seems like the trick is getting the plugin to use the correct version of Jackson?

@StevenChoo looks like the problem is related to the method been overloaded and it can't pick one of them.

@fehguy  --

Try snapshot, we've updated the jackson version there.

i did this and same failure still exists. what was fixed in snapshot ?


Add package EntityX

I'm interested in package EntityX

Here is official site of package https://github.com/alecthomas/entityx

This package is using Git

Official GitHub repository: https://github.com/alecthomas/entityx

Used build system: CMake

This package has no dependencies

@ruslo This package sets compilation flags that need to be removed for proper Hunterization. I need a fork to push to.

This package sets compilation flags that need to be removed for proper Hunterization. I need a fork to push to.

Done: https://github.com/hunter-packages/entityx
Branch hunter-1.3.0 created from latest upstream tag 1.3.0.


Fix unit_test failure

Our most up-to-date test fails with the following error

The following line was not identified in the output:
                "compute.googleapis.com/quota/local_ssd_total_storage_per_vm_family/exceeded"

The following line was not identified in the output:
                "compute.googleapis.com/quota/local_ssd_total_storage_per_vm_family/usage"

The following line was not identified in the output:
                "file.googleapis.com/nfs/server/connections"

The following line was not identified in the output:
                "logging.googleapis.com/billing/ingested_bytes"

It seems like Compute Engine API, File and Logging has changed. We need to mark corresponding lines as volatile and check that test is passing.

it looks like more tests are failed since then, I just run a dry run in my local machine and two tests failed, which matches the latest test.
I can take on this issue if it's open

Thanks, assigning this one to you.

We have a lot of interest from other members of community. So, I will drop assignees for all bugs, so anyone can work on them.

I checked the GitHub Action Log here and discovered that we now have 27 projects rather than 26. Is this correct? If that's the case, I'll fix this issue first.


Don't combine ticked LedgerView and ChainDepState

This was leading to unnecessary error calls. Instead, if protocols need the ticked ledger view, they can include it in the ticked chain dep state.

bors merge


Prototype structured query representation in gRPC

A small experiment to see what it would look like to pass structured query representations instead of raw CQL strings in our gRPC API.
This models part of the SELECT statement (not including: SELECT JSON, GROUP BY, ORDER BY, LIMIT, PER PARTITION LIMIT, ALLOW FILTERING).
The server part is not implemented yet, but it would essentially boil down to: generating a CQL string from the representation, and then passing it to our existing execution code.
I believe the right approach is to work from the CQL grammar, to make sure we cover all possible cases (or at least leave the door open to implement them in the future). If something looks overly complicated, ask and I can show query examples.
Pros:

no need for a query builder on the client. The generated Java code is a bit verbose, but that can be improved with utility methods (see CqlHelper.java).
easier query introspection on the server (is this statement a read or a write? what is the primary key? etc).

Cons:

verbosity. This is only a small portion of the language and there is already a lot in the proto file.
possibly more complicated for users not familiar with CQL.
more sensitive to compatibility issues: if we get something wrong, or Cassandra changes the CQL language in an incompatible way, we might have to break the API in the future.

easier query introspection on the server (is this statement a read or a write? what is the primary key? etc).

easier query introspection on the server (is this statement a read or a write? what is the primary key? etc).

Are we trying to avoid parsing CQL to introspect? I'm pretty sure it's not too expensive and may not be too hard to reuse the existing grammar(s) that are widely available. Another advantage to parsing server-side is the CQL native protocol and the existing string query gRPC API can also introspect.
I understand going this route if the API is truly preferred by users and/or is easier to use, but not if it's to avoid parsing.

easier query introspection on the server (is this statement a read or a write? what is the primary key? etc).

Are we trying to avoid parsing CQL to introspect? I'm pretty sure it's not too expensive and may not be too hard to reuse the existing grammar(s) that are widely available. Another advantage to parsing server-side is the CQL native protocol and the existing string query gRPC API can also introspect.
I understand going this route if the API is truly preferred by users and/or is easier to use, but not if it's to avoid parsing.

It is about sequence of parsing, validating, using, generating/serializing queries; a series of no-value-add operations; keeping operations in a more usable form (CQL string can only really be used after it gets parsed, or somehow massaged).
So avoiding unnecessary back and forth processing which does add overhead, complexity and potentially flaws.
A secondary benefit is easier programmatic generation of queries via builders.
I agree that it is not necessarily a burning performance problem to solve: while CQL parsing is not free (I'd expect it to be slower, per character, than decoding json or xml, given syntax), query strings tend to be short, and much depends on kind of object model that is built on contents.
But no, I don't think the main reason is performance.

It is about sequence of parsing, validating, using, generating/serializing queries; a series of no-value-add operations; keeping operations in a more usable form (CQL string can only really be used after it gets parsed, or somehow massaged).

Closing this now since this is likely not the direction we are taking.


[sprint 3] recruiting for usability tests

[x] usability test w/ Marcela, card-based layout (schedule for Wed/Thursday 2/26 or 2/27)
[ ] folks from non-GSA privacy offices (see outreach spreadsheet for names).

[x] participant 1
[x] participant 2
[x] participant 3

[ ] Reach out to phase 2 participants just an email with link and feedback questions.
[ ] Identity PMO
[ ] Louis from Forms team.


[WIP] History Event Listeners

WIP.
Enable external HTTP endpoint subscriptions in Helios. Such endpoints would be POST-ed with a JSON made from each Job state transition event happening in the cluster, for example RUNNING -> STOPPED.

@evgeny-goldin

What's the deal with this? Should it still be an open pull request?

re @evgeny-goldin, do you think we should still keep this open considering that I've implemented Kafka event delivery thingie?

No, we shouldn't keep this PR.


SyntaxError causes cell to lock up

Describe the bug
In 0.7.6 I noticed that a SyntaxError is causing the cell to lock up. The cell output is dark, and if I fix the syntax error and rerun the cell, nothing happens. Reloading the page seems to make it responsive again. It still seems to be present on 0.7.7
This does not happen with a NameError, and does not happen on 0.7.5.

Environment
{
  "marimo": "0.7.7",
  "OS": "Darwin",
  "OS Version": "23.4.0",
  "Processor": "arm",
  "Python Version": "3.12.3",
  "Binaries": {
    "Browser": "102.0.5005.61",
    "Node": "v22.2.0"
  },
  "Requirements": {
    "click": "8.1.7",
    "importlib-resources": "missing",
    "jedi": "0.19.1",
    "markdown": "3.6",
    "pymdown-extensions": "10.8.1",
    "pygments": "2.18.0",
    "tomlkit": "0.13.0",
    "uvicorn": "0.30.1",
    "starlette": "0.37.2",
    "websockets": "12.0",
    "typing-extensions": "missing",
    "ruff": "0.5.2"
  }
}

Code to reproduce
A SyntaxError seems to be all it takes:
a[]

Thanks, working on a fix -- will release soon.

@seantur, we've just cut version 0.7.8 which includes the fix. It should be on PyPI momentarily. Please reopen this issue if you still run into problems, and thanks so much for reporting.


Merging master into add-driver-example branch

fix for  #557

IssueHunt Summary

Referenced issues
This pull request has been submitted to:

#557: Add-Driver fails to run

This PR needs to wait. I'm changing the way we add drivers, that's why I will wait a bit to merge it

@Alucard17 I'll merge branch lazy-tree tonight with some other changes, than I'll reach out to will and if you still want to fix #557 I can provide more info. Let me know


[Bug]: VectorStoreIndex.build_index_from_nodes() missing 1 required positional argument: 'self'

Bug Description
I've tracked this for a few versions. I thought it was a simple mistake and was going to be quickly fixed so didn't make a report, but I'm now on llama-index-core==0.10.66 off llama-index==0.10.65
Version
0.10.65
Steps to Reproduce
create a instance of VectorStoreIndex with nodes
Relevant Logs/Tracbacks
Traceback (most recent call last):
  File "K:\ComfyUI_win\execution.py", line 152, in recursive_execute
    output_data, output_ui = get_output_data(obj, input_data_all)
  File "K:\ComfyUI_win\execution.py", line 82, in get_output_data
    return_values = map_node_over_list(obj, input_data_all, obj.FUNCTION, allow_interrupt=True)
  File "K:\ComfyUI_win\execution.py", line 75, in map_node_over_list
    results.append(getattr(obj, func)(**slice_dict(input_data_all, i)))
  File "K:\ComfyUI_win\custom_nodes\SaltAI_Language_Toolkit\nodes\core.py", line 268, in index
    index = VectorStoreIndex.build_index_from_nodes(
TypeError: VectorStoreIndex.build_index_from_nodes() missing 1 required positional argument: 'self'

@WAS-PlaiLabs build_index_from_nodes is neither a class method nor a method that we expose to users anywhere in our documentation (except probably the API reference). It's not really meant to be used by users.
But also, it's not a bug either. If you wanted to use this method, you need an instance of the index. Dosu had the right idea above actually.
index = VectorStoreIndex(nodes=[], ...).build_index_from_nodes(nodes)

But at that point, I would just pass the nodes into the constructor 🤷🏻Or if you want to add nodes after the index is instantiated, index.insert_nodes(nodes) is also there

So basically -- it would be like adding nodes to a index already instantiated with documents?

Pretty much. It's actually called inside the constructor, which is probably why the method has that name

Well thanks for the clarification. It helps.

Thanks for the clarification. That helps. Makes sense.


Rename {name}-build-k8s-tests to {name}-build-kubernetes to fix density

and conformance tests.
https://hanjin.atlassian.net/browse/KRAK-353

good catch, shame jjb didn't validate this for us (I guess technically the job in question "existed" in jenkins prior to jjb deleting everything)


Bring-your own-plugins (BYOP), via --custom-plugins option

In case you wanted to make e.g. a new entropy plugin with different metacharacters, or a new keyword type detector, or a company-specific plugin, or use it/tune it privately before merging upstream.
To be used like so: detect-secrets scan  --custom-plugins custom_plugins/ test_data/each_secret.py
We had a "truffleHog vs. metasploit"  discussion internally. With the former, you can e.g. edit a config file with regexes in it like shhgit, with the latter you write your own modules.
Main reasons why this seems like a better fit for detect-secrets

More general purpose
We would still need verification functions written in Python if we put all our regexes in a config
This encourages writing tests

I need to edit the README in this PR still, but might do that after the review.

To be used like so: detect-secrets scan --custom-plugins custom_plugins/ test_data/each_secret.py

In general it sounds like a good idea. Have we thought about how to deal with things like additional pip packages required by new plugins?
Another thing is it would be nice to include a helloworld or sample plugin in the sample_custom_plugins folder, so others can easily follow and start developing new plugins.

Have we thought about how to deal with things like additional pip packages required by new plugins?

For the server-side case it's easy to include any packages you need next to e.g. detect-secrets( or -server). But for the pre-commit hook case, I don't think it's desirable to try to pip install packages dynamically when someone runs detect-secrets, since it's so unexpected.
I did include a couple custom plugins in the tests, but those are kind of too basic. Since we link to the plugins/ dir in the README right before we mention --custom-plugins I think most users will be able to look at that directory for inspiration.
We should also add a link to the right contributing.md section though](https://github.com/Yelp/detect-secrets/blob/master/CONTRIBUTING.md#writing-a-plugin), I can add that.

I did include a couple custom plugins in the tests, but those are kind of too basic. Since we link to the plugins/ dir in the README right before we mention --custom-plugins I think most users will be able to look at that directory for inspiration.

I think this should work. Given some of the relative imports might be broken (e.g. example) depends on who user structure their custom import folders.

We should also add a link to the right contributing.md section though](https://github.com/Yelp/detect-secrets/blob/master/CONTRIBUTING.md#writing-a-plugin), I can add that.

👍

I rebased with master so this should be ready to review now @OiCMudkips / @killuazhu 😁

Polite re-ping on this one 💟 I have some fun funemployed time at the moment.

Made new PR due to change in GitHub permissions. So closing this one.