Spelling

I haven't updated the commits to include the list of fixed words (I can do that, they're available via https://github.com/jsoref/ChakraCore/tree/spelling-full ), and I'm not really in a position to run any tests.
The first commits are intended to be fairly easy to review -- changes to comments, internal variables, and a build assert.
Other commits will change APIs, Output, and Test Output.
This request is for people like @dilijev to hang comments.

Hi @jsoref, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. I promise there's no faxing. https://cla.microsoft.com.

TTYL, MSBOT;

@jsoref , could you please fix the build and push another commit? Most likely has to do with not updating all the instances of a wrong spelling.

@jsoref Yep I was just looking at the logs. Definitely looks like multiple instances of variable renaming not propagating all the way through.

Sorry about those. I thought that my tools were properly replacing globally, apparently they were doing first instance only (oops). I've fixed that tool for the future.
I just wrote a tool to identify removed words (based on a diff), and I think that has identified the last stragglers. So far, it looks like there was one actual test whose output I changed (the alphabet one was using the string a couple of times), and I've now updated it.

I have a bone to pick w/ @msftclas: I've already played this game with @dnfclas here:
https://github.com/OpenLiveWriter/OpenLiveWriter/pull/134#event-491385573
How many of these bots do I have to appease?

@rajatd operations pushed. Thanks for reviewing. I know such things aren't the most enjoyable reading.

(admittedly, they can be rather amusing...)

@jsoref Thanks for fixing the build breaks.

@jsoref Thanks for the changes. Some of them were pretty funny :)

@jsoref  Can you please sign cla?

@jsoref sorry about the bots, but according to this one you haven't signed the CLA that applies to our project. Would you mind indulging us (to make the legal folks happy so we can merge your change)?

@dilijev shouldn't CLA be picked up by all MSFT repos?

@tcare one would think, but this one is saying it's not signed? Maybe it changed recently so a new version is needed? I'm not even sure who to ask about this.
If @jsoref tries to sign the CLA at the link provided above, and it doesn't work, then there's a problem I'll try to track down. (It has worked for others.)

@tcare @bterlson since there's no new IP in this PR, I suppose we could manually bypass the CLA since it's not actually required, but since the number of lines changed is so high, I'd feel better if the bot confirmed the CLA was signed. What do you think?

@dilijev @jsoref needs to make the CLA say signed, even if that means signing again.

@tcare I think the problem is that the DotNET Foundation has a different CLA than Microsoft repos.

Which is to say there's not actually a problem and once @jsoref makes @msftclas bot happy, that should be all he needs to do for our repo.

Sounds good

@jsoref, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR.
Thanks, MSBOT;

Thanks for signing, @jsoref!

Thank you @jsoref

Reviewed 93 of 122 files at r1, 27 of 32 files at r2, 147 of 148 files at r3, 4 of 4 files at r4.
Review status: all files reviewed at latest revision, 12 unresolved discussions.

lib/Backend/GlobOpt.cpp, line 9624 [r3] (raw file):
"if any one of the sources is an int"

lib/Backend/GlobOpt.cpp, line 9634 [r3] (raw file):
"if any one of the sources is a float"

lib/common/core/FaultInjection.cpp, line 373 [r3] (raw file):
In this case I think 'reproing' is better because we use the term 'repro' for 'reproducing an [error/bug/etc.]'

lib/common/core/FaultInjection.cpp, line 1021 [r3] (raw file):
Same comment about 'reproing' here

lib/common/Memory/Recycler.cpp, line 6128 [r3] (raw file):
@curtisman Was this supposed to be 'priority-boost--overridden' or 'priority boost overrode' or 'priority boost overrides' or something else? I'm not entirely sure this correction captures the meaning.

lib/Parser/parse.h, line 164 [r3] (raw file):
Change loss-less to lossless.

lib/Runtime/Library/InJavascript/Intl.js, line 364 [r3] (raw file):
Be more specific that you're talking about the "pronun" below.

lib/Runtime/Types/DynamicObject.cpp, line 674 [r3] (raw file):
I think you should change this to 're-enable' but since the meaning is clear, it's fine either way.

lib/Runtime/Types/TypeHandler.h, line 584 [r3] (raw file):
This should probably be inlineSlotIndexSlot.

test/Array/array_indexOf.js, line 79 [r3] (raw file):
These were actually fine the way they were (arr is an abbreviation for array), but this change is incorrect. If you want to change these, change to floatArray.

test/es5/Lex_u3.js, line 18 [r3] (raw file):
I'm guessing this comment was supposed to read <LS><PS>

Comments from the review on Reviewable.io

@jsoref I've reviewed this entire changeset. I've left some comments on reviewable (see my previous comment).
Before I merge this in, please address those comments, and if you could, reduce this change to a smaller set of commits, and please rebase your commits on top of the latest master to help history be more legible.
I'll merge it in shortly after your next iteration.
Thanks for your work on this, and looking forward to any future PRs you've got in the works to correct similar issues.

@dilijev: so, I could easily make this one commit, I don't really know what you want in terms of commits...

@jsoref One commit is fine, and is preferred as far as we're concerned. If you had good logical reasons to split your PR into multiple commits, that would be fine too, but we just ask that you only do that if there's a clear reason.
Thanks for doing that. I'll merge this in today.

I tend to split to help maintainers review/manage risk.
If you don't care, it's certainly easy enough for me not to bother.

Reviewed 73 of 79 files at r5.
Review status: all files reviewed at latest revision, 7 unresolved discussions.

lib/Backend/IRBuilder.cpp, line 6666 [r5] (raw file):
There's some grammar weirdness here. You can follow up in your next PR.

lib/common/Memory/SmallFinalizableHeapBlock.cpp, line 164 [r5] (raw file):
Somehow 3 spaces ended up in these comments. You can follow up later.

lib/Runtime/Library/JavascriptEnumeratorIterator.h, line 6 [r5] (raw file):
I think this meant for-in as in for (x in array)

lib/Runtime/Types/PathTypeHandler.cpp, line 981 [r5] (raw file):
Personal preference on this: ...have the IsPrototypeFlag set?

Comments from the review on Reviewable.io

Also previous unresolved discussions:

lib/Backend/GlobOpt.cpp, line 9624 [r3] (raw file):
"if any one of the sources is an int"

lib/Backend/GlobOpt.cpp, line 9634 [r3] (raw file):
"if any one of the sources is a float"

Yes to the for-in typo

@jsoref That's absolutely reasonable, and it can sometimes help in review to have commits split up into separate logical segments. In this particular case, my reasoning is that there are really only two kinds of changes in this PR:

Comment changes, which pose no risk.
Renaming variables in a mostly local scope, which poses only a small amount of risk, especially if the CI checks pass.

So there's only one set of "risky" changes to consider here, and any non-risky changes can be combined into it. But overall, every change in this PR is a spelling change, and so to me, it's logically a single commit.
During a code review, I personally sometimes find it helpful to have multiple smaller commits because it can act as sort of a guided tour of the review. For related logic changes in a large PR this can be very helpful, but when it comes time to merge it in, a single commit is often best, especially if you're already rebasing on top of master.
Still, it is author's discretion. If there's clear enough logical units that the author believes should be highlighted in the history, multiple commits are absolutely welcome.

Review status: all files reviewed at latest revision, 8 unresolved discussions.

lib/Backend/GlobOpt.cpp, line 9624 [r3] (raw file):
Oh, right, I was going to run through the repo and do a/an work. I've started it. It'd probably be helpful if that didn't block the rest of this. The an -> a side is fairly annoying/slow.

lib/Backend/IRBuilder.cpp, line 6666 [r5] (raw file):
s/pass/passing/ ?? It's weird, but, it's also hard to fix, because there's so little text, and the code is fairly opaque (necessitating a comment!)

test/Array/array_indexOf.js, line 79 [r3] (raw file):
Ok, the reason I was changing it was to have only a single spelling (both ary and arr were used), I'm aware that both are valid, but I find using a single abbreviation consistently is helpful.

Comments from the review on Reviewable.io

Review status: all files reviewed at latest revision, 7 unresolved discussions.

lib/Backend/GlobOpt.cpp, line 9624 [r3] (raw file):
Yeah, I don't want to block on this. I assumed you may have been working on additional changes in your other branch and I assume there will be another nice big spelling PR coming in.
Still these were omissions rather than a/an conversions and since I noticed them I figured I'd point them out. Feel free to address them in your other branch and I'll finish up merging in this PR.

lib/Backend/IRBuilder.cpp, line 6666 [r5] (raw file):
Hmm, yeah. Maybe just leave this one alone for now. We can consider it in your future PR. Maybe @curtisman knows more about the context here?

test/Array/array_indexOf.js, line 79 [r3] (raw file):
Ah, I see. It's such a small difference for the abbreviation I think spelling it out is better. Thanks for the change you made.

Comments from the review on Reviewable.io

Review status: all files reviewed at latest revision, 5 unresolved discussions.

lib/Runtime/Library/JavascriptEnumeratorIterator.h, line 6 [r5] (raw file):
This one should definitely be changed in this PR.

Comments from the review on Reviewable.io

Sure. From my perspective, if you're comfortable with it completely folded, I'm fine with it.
Comfort varies a lot by project and test coverage.
Some projects have API/ABI rules which means that changing a function name or commandline argument is more problematic than others. So I try to be cautious about how I deliver changes.
For TypeScript and another Microsoft project, I'm going to try tossing the series raw and see what they want instead of spending the time categorizing.
Note that I benefit from playing around w/ all of these segmentations, since I'm working on improving Mercurial (hg)'s UX, which means I'm forced to use more tools/paths and find bugs/improve edges as I go.

Review status: all files reviewed at latest revision, 5 unresolved discussions.

lib/Backend/GlobOpt.cpp, line 9624 [r3] (raw file):
https://github.com/jsoref/ChakraCore/commit/685932a28dd40270df0276493e4ede617c6a20c8 has the only changes I'm holding off.

lib/Backend/IRBuilder.cpp, line 6666 [r5] (raw file):
I can stash a passing change into my pending branch for once everything else goes in.

lib/common/Memory/Recycler.cpp, line 6128 [r3] (raw file):
Do we want me to keep an open thing for this?

Comments from the review on Reviewable.io

Cool. In the days before I was active on GitHub I used Mercurial a lot. Good to see there's an eye to continued improvement. (Of course that's totally off-topic =P)

Review status: all files reviewed at latest revision, 4 unresolved discussions.

lib/common/Memory/Recycler.cpp, line 6128 [r3] (raw file):
Considering the spelling changes are low-impact and there's no harm in making no change, I wouldn't worry about this unless it bothers you. I don't want to block on this.

Comments from the review on Reviewable.io

One thing to note about Git is that it handles tracking of file renames best if the rename does not include any other changes to the file in the same commit. If you wanted to split those out, there's a good case for that. Of course if you didn't make any other changes within those files, no need.

Grr. Yeah, I wondered about that. Since mercurial tracks renames as an action, that's less of a problem for me. I'm pretty sure there are changes in the renamed files.
I'm not quite sure how to deal with them, since the files reference themselves. Would you rather files renamed before or after tests or both?

all changes rename files
changes except file references rename files fix references to files
rename files all changes

Yep I confirmed that git-blame now lists you as the author of the whole file. Before you rebased, it had the right info. So somehow that worked out...
I think option 2 is the best one.
Luckily we don't need to worry about intermediate steps being broken due to the PR-and-merge process. There's a good case for it here.

Review status: 291 of 298 files reviewed at latest revision, 3 unresolved discussions.

lib/Backend/IRBuilder.cpp, line 6666 [r5] (raw file):
@curtisman I don't suppose it should be skipping instead?

Comments from the review on Reviewable.io

Alright, it'll take a minute or three, but no big deal. Again, I get to test tooling :)

Oh weird, actually the reason it's showing up as you is because after your rebase the rename wasn't preserved as a rename and you've simply added those files this time.
See:
ChakraCore (jsoref-spelling)
$ git ls-files | grep -i watson
lib/common/Memory/RecyclerWatsonTelemetry.h
lib/common/Memory/RecyclerWatsonTelemtry.h

I think git will use some heuristic on how much of a file changed in order to determine a rename. It doesn't need to match 100% but like 90%+ and you should be okay.

Yeah. I noticed that when I looked at one of my diff reviews, I was wondering if I lost the info... sigh, I'll need to see if my blackbox shows where it got lost...

Reviewed 7 of 7 files at r6.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from the review on Reviewable.io

Once you get the file rename info re-integrated I'll sign off and merge this PR. Thanks for bearing with me through this :)

Some projects have API/ABI rules which means that changing a function name or commandline argument is more problematic than others. So I try to be cautious about how I deliver changes.

This is a good policy. ChakraCore will have some of these limitations too when it comes to any function names / APIs that are exported, and possibly in JIT code generation or bytecode names. In this case, I don't think anything like that applied.

+1,022 −1,021

That looks right.

The +1 is the pronun comment.

One change that did happen is some error messages changed. Sometimes people (as in the tests) look for very specific error strings.
That said, I'm not sure how much sympathy should be allocated to that... Especially since each js engine is generally free to have its own error strings, or to localize them, resulting in far ranging messages.

@dilijev : Do I need to work around the rename, or is git now happy w/ me?

Looks like git is happy. I'll merge your change.

For the curious, the reason our tests look for specific error messages is so that we have better certainty that we are getting the expected error in our test, and not some other error with the same constructor.

@jsoref Looking for specific messages may be the easiest way to check whether a particular error path has been hit which is specific to our engine and our code base anyway, so I don't see a problem there. As long as all the tests have been updated properly it looks like the right thing to do.

@ianwjhalliday , @dilijev : yeah, I'm not saying your tests were written wrong, it was definitely the right way to write them, just noting that someone could be incredibly skittish and refuse to change even error messages -- because it could break code written expecting those messages. I'm glad you guys aren't that conservative :)

@jsoref It remains to be seen what might happen with internal testing (which I've just started). If there are any breakages, I'm sure it will be as easy to fix them as changing some more test messages, but I doubt there will be problems.

@jsoref FYI on the merge commit
 rename lib/common/Memory/{RecyclerWatsonTelemtry.h => RecyclerWatsonTelemetry.h} (100%)
 rename test/InlineCaches/{inlnieLocalCacheWithoutProperty.baseline => inlineLocalCacheWithoutProperty.baseline} (100%)
 rename test/InlineCaches/{inlnieLocalCacheWithoutProperty.js => inlineLocalCacheWithoutProperty.js} (100%)
 rename test/Object/{propertyIsEnumarable.js => propertyIsEnumerable.js} (100%)
 rename test/es5/{SemiCollonAfterBlockEs5.baseline => SemicolonAfterBlockEs5.baseline} (100%)
 rename test/es5/{SemiCollonAfterBlockEs5.js => SemicolonAfterBlockEs5.js} (100%)

@jsoref could you change your initial comment on this pull request to include any additional information you'd like to end up in the git history log (like which words were corrected, and so on).
Also please don't make any other changes to the commits in this PR as I'm integrating the changes into the internal code, which references some things that changed, and that will just make things more difficult.

Something like:
Fix various spelling errors.

Fixes misspellings of:
* a..z (the English alphabet sequence a..z with one pair of letters transposed)
* actual
* algorithm
* amount
* although
* argument
* array
* as
* assignment
* auxiliary
* availability
* avoiding
* because
* beginning
* built
* canonicalization
* canonical
* catch
* causes
* collection
* committed
* compare
* comparison
* compilation
* completed
* concurrent
* conditions
* constructor
* contain
* context
* contiguous
* conversion
* convert
* corresponding
* counterparts
* coverage
* covered
* current
* declaration
* default
* deferred
* delimiters
* dependencies
* descriptions
* descriptor
* diagonal
* dictionary
* differently
* different
* disposed
* dynamically
* dynamic
* earlier
* emitting
* empty
* emulated
* encodable
* enough
* entrypoint
* enumerable
* environment
* evaluate
* everything
* exactly
* exception
* exercised
* existing
* expandos
* explicitly
* extension
* floatarray
* for-in
* foreign
* function
* generate
* generator
* granularity
* identical
* implemented
* implicit
* inclusive
* index
* indicate
* indicating
* infinity
* initializer
* initial
* injection
* inlinable
* inline
* insertion
* instance
* instantiate
* interior
* interpreter
* interpret
* invalidation
* invoke
* iterable
* iterator
* javascript
* label
* lambda
* lane
* language
* left
* length
* manager
* maximum
* member
* memory
* message
* metadata
* necessarily
* occurrence
* offset
* offsets
* of lit (two word sequence)
* ofobj
* ofreturn
* optimization
* original
* outer
* output
* overridable
* overridden
* owning
* parameter
* participate
* perlargest
* physical
* pollute
* polyfill
* polymorphic
* popping
* possibility
* preceded
* precise
* precision
* preferenced
* primitive
* processed
* profiled
* profile
* program
* progress
* propagate
* prop'd
* properties
* property
* prototype
* recycler
* re-enable
* referenceable
* reference
* registers
* removed
* required
* result
* semantics
* semicolon
* separately
* separator
* sequences
* should
* sibling
* signature
* similar
* simultaneously
* source
* sources
* spec'd
* specialization
* statement
* store
* straight
* subtags
* succeed
* successful
* sufficient
* summation
* supplied
* supported
* support
* surrogate
* telemetry
* ternary
* testing
* then
* the
* though
* threshold
* timing
* transferred
* traversal
* truncation
* typespec'd
* underflow
* uninitialized
* unknown
* unless
* unregister
* unroll
* unscopable
* using
* value
* variable
* verifies
* verify
* visitor
* without
* zero

brand:
* ForceES5Array

grammar:
* a/an
* any one of the ... is
* as an input/output
* because
* be replaced
* different thresholds
* have
* is
* is a
* it is
* lossless
* not to report
* operations
* required by
* the
* true
* a tortured sentence involving interleaving

Tagging an ambiguous token with a guess
* pronunciation

Whitespace

@jsoref sure, LGTM. You can edit the PR description or I'll copy-paste that up there.

I've edited the commit message (I'm not sure if that's what you wanted me to do).

If it isn't, please just do the magic. Github is somewhat befuddling.

@jsoref I meant to edit the description of the PR on GitHub itself. But editing the commit message as well does no harm.

@dilijev Is this ready to get merged?

@abchatra yes, but due to the recent issues with the internal build system I haven't been able to get a clean build yet. I'm trying every so often.

@jsoref Thanks for the spelling changes! If you have any other related changes, feel free to open a new PR when ready. :)


Create LICENSE

Testing GitCop

There were the following issues with your Pull Request

Commit: 8690d1d8ba104c67b55c524e7fe4dc0e85c9e47e
Your commit message does not contain a body
Invalid signoff. Commit message must end with
Signed-off-by: . <.*>*

Guidelines are available at https://github.com/revi/dot

This message was auto-generated by https://gitcop.com


How to add Pin Change Interrupts

I am trying to attach a pin change interrupt to pin D2 of an Arduino Nano.
From reading the code I think I need a function called PCINT0, and need to call avr_device::interrupt::enable(); and from reading the data sheet for the ATmega328P I believe I need to set bit 0 of the PCICR to 1 and bit 2 of PCMSK2 to 1 however I can't figure out how to control those registers.
My interrupt function is below
#[avr_device::interrupt(atmega328p)]
fn PCINT0() {
    PCINT0_STORE.store(true, atomic::Ordering::SeqCst);
}

After spending the last 2 hours going through docs again I have it working.
The bit of code needed to control the registers is
peripherals.EXINT.pcicr.write(|w| unsafe { w.bits(0b100) });
peripherals.EXINT.pcmsk2.write(|w| unsafe { w.bits(0b100) });

and as pin D2 is in PCIE2 the interrupt function should be called PCINT2


Unexpected physics issues - box collider missing a corner

Here are the issues I'm experiencing: https://user-images.githubusercontent.com/5253130/136295955-51616d9b-be93-4e0e-b5de-3a589bba6006.mp4
Here is the source code:
tetra.zip

I notice there are differences in the ways our drawCollider functions render the shapes. My version seems to match the underlying physics simulation. You could try to switch between the two and see differences in collider orientations.
-- call lovr.math.setRandomSeed(0) before looping over colliders in lovr.draw()

function drawCollider(collider)
  local userData = collider:getUserData()
  local shade = 0.4 + 0.4 * lovr.math.random()
  lovr.graphics.setColor(shade, shade, shade)
  local shape = collider:getShapes()[1]
  if false and shape:isSensor() then
    local r,g,b = lovr.graphics.getColor()
    lovr.graphics.setColor(r,g,b,0.8)
  end
  for _, shape in ipairs(collider:getShapes()) do
    local shapeType = shape:getType()
    local pose = mat4(collider:getPose()):translate(shape:getPosition()):rotate(shape:getOrientation())
    local x,y,z, _,_,_, angle, ax,ay,az = pose:unpack()
    -- draw primitive at collider's position with correct dimensions
    if shapeType == 'box' and shape then
      local sx, sy, sz = shape:getDimensions()
      lovr.graphics.box('fill', x,y,z, sx,sy,sz, angle, ax,ay,az)
    elseif shapeType == 'sphere' then
      local r = shape:getRadius()
      lovr.graphics.sphere(x,y,z, r)
    elseif shapeType == 'cylinder' then
      local l, r = shape:getLength(), shape:getRadius()
      lovr.graphics.cylinder(x,y,z, l, angle, ax,ay,az, r, r, true, 10)
    elseif shapeType == 'capsule' then
      local l, r = shape:getLength(), shape:getRadius()
      local m = mat4(x,y,z, 1,1,1, angle, ax,ay,az)
      lovr.graphics.cylinder(x,y,z, l, angle, ax,ay,az, r, r, false)
      lovr.graphics.sphere(vec3(m:mul(0, 0,  l/2)), r)
      lovr.graphics.sphere(vec3(m:mul(0, 0, -l/2)), r)
    end
  end
end

I haven't checked your manual calculation of mass and inertia tensor, that will become obsolete once the #490 is solved.
Then, if I increase the collider mass to 10, the physics seem to work smoother although still not correctly. This is most likely because the inertia tensor is not correctly computed from all the shapes.
We should probably merge this issue with #490.

Oops! setAngularDamping(0.01) fixed it! My sphere colliders were apparently spinning very rapidly. The only remaining problem is that my table is missing a corner.

LÖVR uses Jolt instead of ODE now.  The mass APIs are improved so this should be fixed.


Question regarding social image

This might not be an issue but a problem on my end, I've changed the social image to a new one, rebuilt the project and uploaded to netlify, but the old one is still showing up. Am I forgetting to change some configuration on the template?

Did you edit astro.config.mjs? https://github.com/mhyfritz/astro-landing-page/blob/7fc9b493a273258ee0b4da5cac2f3b66f0bfd5e8/astro.config.mjs#L7
The image URL is constructed using this value as the base path: https://github.com/mhyfritz/astro-landing-page/blob/7fc9b493a273258ee0b4da5cac2f3b66f0bfd5e8/src/pages/index.astro#L13
Hope that help!

The change in astro.config.mjs is what was missing! Thank you so much! That fixed it.


[PE-D][Tester B] I can add the email without the .com . Shouldn't we restrict the user to be unable to add email if there is no .com

I'm not too sure about the formatting for emails. I apologise if this is the wrong info

Labels: type.FunctionalityBug severity.Low
original: UnwilledTangent/ped#2

(Intended behaviour) Valid emails can exist without the .xyz extensions (as long as domain is valid)


[Utility] Support online multi-player mode

In my implementation, the transmitted information is the users' input data, and all the computations are distributed to the clients.
You can start a server in the app window, or use
./battlegame --server [<port>]

where the default port is 8088.
Currently I've only tested the situation where one player is connected to localhost and the server is run in the command line only. Because it was for the first time that I wrote asynchronous program using multithread, I think it must contains many bugs (, so you are welcomed to rewrite the server/client parts). It seems that the servers and clients sometimes crash.
Something we can do later:

[ ] Test and debug thoroughly;
[ ] Document;
[ ] Support both Big Endian and Little Endian machines (currently conversion from glm::vec2 to bytes is directly using memcpy);
[ ] Capture user's input in the ImGui window;
[ ] Support both IPv4 and IPv6;
[ ] Pure server with less dependencies (i.e. we can build a server without Vulkan and etc.);
[ ] Any other utilities.

我讲讲我的理解看有没有问题：

客户端每个tick CaptureInput之后计入input_data_
客户端每个tick发送一次input_data_
服务端对每个client都循环接收input_data_
服务端每个tick读一次client的input_data_并broadcast
客户端收到broadcast的时候加进input_data_queue_
每个UpdateDrawCommands() flush一次queue，然后调用Update()

这个实现在当前框架中非常简单直接！Thanks for your great work!
当然，这种实现的主要缺点是对延迟和丢包率要求极高，延迟或丢包会导致input queue不同步，不同客户端渲染不一致。不过在局域网内跑都没问题，之后我们再慢慢整。


ff-test-3

SUMMARY

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TEST PLAN

ADDITIONAL INFORMATION

[ ] Has associated issue:
[ ] Changes UI
[ ] Includes DB Migration (follow approval process in SIP-59)

[ ] Migration is atomic, supports rollback & is backwards-compatible
[ ] Confirm DB migration upgrade and downgrade tested
[ ] Runtime estimates and downtime expectations provided

[ ] Introduces new feature or API
[ ] Removes existing feature or API

Codecov Report

Merging #13 (58757a4) into master (f8321f8) will decrease coverage by 11.55%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           master      #13       +/-   ##
===========================================
- Coverage   78.44%   66.88%   -11.56%
===========================================
  Files         935      842       -93
  Lines       47374    41920     -5454
  Branches     5783     4334     -1449
===========================================
- Hits        37162    28039     -9123
- Misses      10069    13881     +3812
+ Partials      143        0      -143

Flag
Coverage Δ

cypress
45.99% <ø> (-10.05%)
:arrow_down:

javascript
?

mysql
80.56% <ø> (ø)

postgres
80.59% <ø> (ø)

python
80.68% <ø> (ø)

sqlite
80.16% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f8321f8...58757a4. Read the comment docs.

/testenv up FEATURE-DASHBOARD_NATIVE_FILTERS=true


Static enabled spot lights do not light up the scene as expected

Scene: https://playcanvas.com/editor/scene/1122796
Forum thread: https://forum.playcanvas.com/t/issue-with-static-lights/19233/
Spotlight with static disabled

Spotlight with static enabled

maybe related to https://github.com/playcanvas/engine/issues/2079


Depend on inets and ssl

Elixir v1.15 will prune applications from the code path that are not listed as dependencies, so we need to explicitly depend on inets and ssl.

🍬 🍫 🍭 🍰 🍨


Updated service and version in auth.py to reflect upcoming Google API…

… changes
2 extra notes:

did not add the http=http parameter from the Google example to the discover.build() call, as I believe if it's None then some http handler is generated anyway (language probably all wrong there)
did not remove any existing parameters in that function call as Google seemed to say all other functionality will be the same

Thanks for this - looks great! I've run the tests in tests.py locally and everything looks good.

Thanks Josh -- quick work :+1:
Seems like there was an issue with CI but not sure how devastating this is:
https://travis-ci.org/github/joshcarty/google-searchconsole/builds/752204830

Yeah was unrelated but good to fix. All good now. Thanks again for your help with this!

Not at all, thanks for showing me the ropes a bit :+1:


QT5 without pypy or GTK3 with pypy?

QT5 and GTK3 is very good framework... GTK3 is more light (GTK3+python is ideal combination)... QT5 has many good widgets but now i use Webkit for widgets...

For now: QT5 is winer


Fix typo tranform; workaround non-ascii char

minor typos in documentations; and also related to #25427
Please add a meaningful description for your change here

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
[ ] Update CHANGES.md with noteworthy changes.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI.

Thanks @AnandInguva and @riteshghorse, yeah they are unrelated flakes


Adds an extra view controller when FloatingPanel is added to a UITabbarViewController

A black view controller is added when the FloatingPanel is added to the UITabbarViewController.
I think this happens because the panel is setting itself as a child in addPanel(toParent:) method

Just figured out that one way to overcome this issue is to call setViewControllers(_:animated:) on the UITabbarViewController after calling addPanel(toParent:) on FloatingPanelController. I think it just overrides current child view controllers. However, I am not sure of any side-effects due to this.

UITabBarController displays child view controllers with a radio-style selection interface. So FloatingPanelController doesn't work well when it's added into UITabBarViewController directly because FloatingPanelController is a chid view controller of a parent.
It's out of control from this library. Please add it to a child view controller(a tab) of UITabBarViewController or wrap UITabBarViewController with a view controller.


Response meta, links etc for pagination

Hi there, nice job on this project. Been using it for a week or so and its been great.
Is there any way to get the original jsonapi response from the server so I can access pagination and links?

@buckyflowers Glad you're seeing success with the library! Would attaching the original Axios response to the returned Object or Array suffice?

Yes, that would be great! Thanks. That’s how the Vuex-ORM axioms plugin I was using is doing it, and they have an entities member with the upserted records, and it worked well for me.
https://github.com/vuex-orm/plugin-axios/blob/master/src/api/Response.ts

For the time being, I solved it by using the axios response interceptor. I use this create method in my Vue component:
  created () {
    // Add pagination detection to json-api calls.
    Product.jsonApi().axios.interceptors.response.use((response) => {
      if (response.status === 200 && response.config.url.indexOf('/api/private/products?') > -1) {
        this.productsApiCallMeta = response.data.meta.page;
      }
      return response;
    });
  },

For the time being, I solved it by using the axios response interceptor. I use this create method in my Vue component:
  created () {
    // Add pagination detection to json-api calls.
    Product.jsonApi().axios.interceptors.response.use((response) => {
      if (response.status === 200 && response.config.url.indexOf('/api/private/products?') > -1) {
        this.productsApiCallMeta = response.data.meta.page;
      }
      return response;
    });
  },

@buckyflowers @ZachPerkitny Sorry for the long pause: Work got in the way. In the coming months, I will most likely be releasing a companion library for handling pagination in line with the JSON:API spec. I'd imagine that it would take some design cues from vuex-pagination, with the twist that Vuex ORM records will be carrying (mixed in) pagination information like context, page, and offset.

Closing this, because I just addressed this in version 0.99: https://github.com/scalient/vuex-orm-json-api/blob/main/CHANGELOG.md#099-2022-11-01.


Optional checkbox where default=True does not return False if checkbox not ticked

I think I may have found a bug for optional checkboxes where the default value is specified as True.

[x] OS: Windows 10

[x] Python Version: Python 3.7

[x] Gooey Version: master development branch

[x] Thorough description of problem
I wanted to have a True/False checkbox with a default value of True. However it seems that when you specify the default value as True, then Gooey doesn't recognize the input argument value correctly if you uncheck the box (i.e. set the value to False) and run the program.

[x] Expected Behavior
I expect the argument value to be True whenever the checkbox is ticked, and False whenever the checkbox is not ticked.

[x] Actual Behavior

Behaves as expected: When the default value is not specified the parsed argument is True if the checkbox is ticked, and False if the checkbox is not ticked.
Behaves as expected: When you specify default=False, the parsed argument is True if the checkbox is ticked, and False if the checkbox is not ticked.
Unexpected (possible bug?): When you specify default=True, the parsed argument value is given as True regardless of whether the checkbox was ticked or not.

[x] A minimal code example
If you run this code example,

from gooey import Gooey, GooeyParser

@Gooey
def main():
    parser = GooeyParser(description="Gooey example")
    parser.add_argument("-a", "--myargument", action="store_true", default=True)
    args = parser.parse_args()
    print(args)
    print(args.myargument)
    print(type(args.myargument))

if __name__=="__main__":
    main()

If you run this code example and uncheck the checkbox, we don't see an argument value of False like we expect. Instead we get this output:
Namespace(myargument=True)
True
<class 'bool'>

[ ] Screenshot (if visual quirk)
[ ] Anything else you may think will be helpful

Thanks! ^_^

This trips up everyone. The key thing to remember is that Gooey is just a layer for generating CLI arguments to your program.
In CLI land, you don't pass an explicit bool for flags. The true/false is determined entirely by its presence. So, store_true means, store true if this argument is present. If you do not pass the -a argument, the value of myargument will, naturally, be false. But! You've also added a default value of true. This means that if you pass the argument you get True and also if you do NOT pass the argument you also get True (due to the default).
In Gooey, when you click a checkbox, it includes the appropriate flag in the generated CLI string. When you deselect it, Gooey no longer sends it.
You can verify the bool behavior by running your program without Gooey.
Regardless of what you pass to parse_args() the value of myargument will always be True.
Hopefully that clears things up


Add forward compatibility with Altair 5

Adds forward compatibility with Altair 5 (which is not yet released)

Thanks for the comments @binste, that is much easier 👍


feat(editors/substation): add read-only l-node-editor

The second only was a bug. Sorry for that very obvious issue. The first one is resolved in an extra PR #752 adding an extra property to action-icon.


Fixed 'ImageDecoderCallback not found'

Fixed 'ImageDecoderCallback not found'
in updated version 'ImageDecoderCallback' is in 'dart:ui' it cannot be used directly

What Flutter version do you use? I've just upgraded to the new current 3.13.0 and I can't see this problem with it. Just the opposite, adding ui. would introduce an error:
'UiImageProvider.loadImage' ('ImageStreamCompleter Function(UiImageProvider, void Function(Image))') isn't a valid override of 'ImageProvider.loadImage' ('ImageStreamCompleter Function(UiImageProvider, Future<Codec> Function(ImmutableBuffer, {TargetImageSize Function(int, int)? getTargetSize}))').

hmm... strange
it could be because Im using flutter version 3.3.7
can we use both code with try catch?, it could fix the issue in both scenarios

No, we can't because it's a compiler error, not a runtime one.
Besides, considering that 3.3.x is not far from being one year old, I can't see any reason why we should. :-) Flutter stable is at 3.13.0 now and while I won't say you always need to upgrade as soon as it comes out but the old approach was deprecated around this January. That's about 7-8 months ago now.
So, I'm afraid I have to say it stays that way. If you really can't upgrade for some reason, you can always simply copy the package to your computer and use it locally from there.

yes I agree with you the flutter is stable enough
I think we can close this issue


Fix "Per App profiles not working on Android 13"

This fixed #7 and parse more optimization flags to the linker
Since Android 13, we can't monitor cgroups' changing by inotify.  So I create a new thread to monitor top app. This is not the best way to fix it but works for me.
The optimization flags comes from @asto18089 's idea. It is better to parst -fuse-ld=lld to clang, but we don't need it in NDK environment.

thread "Android13Worker" , seems to be killed? when screen is lock. (MIUI 14)
this cause per app profiles not working , need to restart the dfps to create "Android13Worker" again.

Fixed in cgroup_listener: Fix not working in Android 13


docs: fix typo in prisma.md should be "a" instead of "an"

Closes #
✅ Checklist

[x] I have followed every step in the contributing guide (updated 2022-10-06).
[x] The PR title follows the convention we established conventional-commit
[x] I performed a functional test on my final commit

Changelog
[Short description of what has changed]

Screenshots
[Screenshots]
💯

Is it called ess-q-lite or see-quel-lite?

@AyanavaKarmakar

The internet seems to have polarizing opinions on the pronunciation of SQL.
However, an seems to be "correct" if we go by the ISO/IEC site.

Also, refer: https://database.guide/is-it-pronounced-s-q-l-or-sequel/
@c-ehrlich @bill-li1

Looks SQLite docs itself uses an.

Looks like SQLite docs itself uses an.

Then we keep the an


Support atomic writes with FileWriter

Non-atomic writes are costlier. But also, having short-lives extra files in a directory may be wrong too, e.g. in directories like /etc/profile.d that could lead to errors or worse. We should probably stick to what is "normal" unless there are good reasons not to.


Non-custom checkboxes don't change with .is-invalid

When upgrading to 4.0.0.beta, I noticed that when I was trying to set up server side validation, inputs and custom checkboxes were working correctly when adding .is-invalid. However, non-custom checkboxes like the following were not.
<div class="form-check">
  <label class="form-check-label is-invalid">
    <input class="form-check-input is-invalid" required="required" type="checkbox">
    Text
  </label>
</div>

Is there a way to make regular (browser-styled) checkboxes look invalid with server-side validation (e.g. when not filled and required) or is this only reserved to custom checkboxes?
JS Bin: https://jsbin.com/ruzodunuqe/edit

I agree with this problem. I am reworking the validation HTML template as generated by Symfony together with BS 4 (see PR  symfony/symfony#21751).
There is no good way to set an invalid radio button/checkbox, because of the sibling selector which is required to show the .invalid-feedback block containing feedback to the user. Radio buttons and checkboxes are nested in their own <div>.
Adding was-validated to the whole form would not be a good option for my use case.

Ah crap, yeah, we might need to break the markup on the checkboxes :(.

Lol oh no... found this in the Sass file.

PR with potentially breaking change coming in #23444.


Update Composer dependencies (2024-03-15-00-08)

Visual regression test passed!
View the visual regression test report


Remove dependency of SILFunction in IRGenOptions

SILFunction::shouldBePreservedForDebugger checks if some optimizations are enabled to decide whether a function should be preserved so its accessible form the debugger or not. Some of these settings used to live only in IRGenOptions making SILFunction depend on IRGenOptions. This patch duplicates those settings into SILOptions to remove that dependency.

@swift-ci smoke test

@swift-ci smoke test

@swift-ci test

@swift-ci smoke test


Use JPA in Custom Logic

Tutorial URL: https://developers.sap.com/tutorials/cp-apm-05-using-jpa.html
Please specify the step you are referring to
Step 4: Change the runtime from Tomcat to TomEE
Hi, I cannot make it work after changing the application server to TomEE
I've got this error, any idea?
{
"written_at":"2019-06-11T12:53:37.255Z",
"written_ts":1612050934513860,
"component_type":"application",
"component_id":"61b04f12-fe6d-41a4-b524-c8f1a76ef26c",
"space_name":"dev",
"component_name":"5q7lPJIFxgXfMpfc-bookshop-srv",
"component_instance":"0",
"organization_id":"-",
"correlation_id":"-",
"organization_name":"-",
"space_id":"7db971e0-be06-4dcd-81da-06904695f9b8",
"container_id":"<IP_ADDRESS>",
"type":"log",
"logger":"com.sap.cloud.sdk.service.prov.v2.rt.core.web.ServletListener",
"thread":"localhost-startStop-1",
"level":"ERROR",
"categories":[
],
"msg":"No UserContext Class Found, Fallback to properties file"
}

Can you share your code? I can take a look to see where the problem is.

Thank you for your feedback. We haven't heard from you in a while, so we are closing the issue.
If you still have questions, feel free to reopen the issue.


docs: translate framework - customization to en.

Checklist

[ ] npm test passes
[ ] benchmarks are included
[ ] commit message follows commit guidelines
[x] documents are updated

Description of change

翻译进阶主题下，《在框架中使用》到《自定义》五篇文档为英文。
#5744

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 87.989%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
10033

Relevant Lines:
11044

💛  - Coveralls


Feature: Add Integer type and arithmetic methods.

 It seems this is basically ready for release :D

I think it's as ready as it's going to be haha.
Next stop is DecimalDigitList and Number.{Add,Subtract,Multiply}, which should make it easier to attempt Fractional.

@poteat Fixed the issue with the stress tests! Should be ready to go now.


Added multi-dimensional array support and some tests to lexer

issue #2
Should be able to parse multidimensional arrays now.
Added some tests as well, but those are probably not very exhaustive.

Thank you for finding and fixing the issue.


Add success alert to "application confirmation" page

Description
Please explain the changes you made here.
Release notes
The title of the pull request will be used as the default release notes description. If more detail is needed to communicate to partners the scope of the PR's changes, use this release notes section.
Checklist
General
Read the full guidelines for PRs here

[ ] Added the correct label: < feature | enhancement | bug | under-development | dependencies | infrastructure | ignore-for-release | database >
[ ] Assigned to a specific person, civiform/developers, or a more specific round-robin list
[ ] Added an additional reviewer from outside your organization as FYI (if the primary reviewer is in the same organization as you)
[ ] Created unit and/or browser tests which fail without the change (if possible)
[ ] Performed manual testing (Chrome and Firefox if it includes front-end changes)
[ ] Extended the README / documentation, if necessary

Database evolutions
Read the guidelines here

[ ] Assigned two reviewers
[ ] Guarded against already existing resources using IF NOT EXISTS and IF EXISTS
[ ] Downs created to undo changes in Ups

User visible changes

[ ] Followed steps to internationalize any new strings

[ ] Added context strings to new messages
[ ] Didn't use a message in applicant facing code that isn't translated yet (unless behind a flag)

[ ] Wrote browser tests using the validateAccessibility method
[ ] Made equivalent changes in Thymeleaf for applicant-facing features and changes (or created an issue in the Northstar epic to track that it's missing from Thymeleaf)
[ ] Tested on mobile view. See mobile device mode
[ ] Manually tested at 200% size
[ ] Manually evaluated tab order

New Features

[ ] Add new FeatureFlag env vars to server/conf/helper/feature-flags.conf
[ ] Conditioned new functionality on a FeatureFlag
[ ] Wrote browser tests with the feature flag off and on, etc.

Instructions for manual testing
If instructions are needed for manual testing by reviewers, include them here.
Issue(s) this completes
Fixes #<issue_number>; Fixes #<issue_number>...

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

#8294  👈
#8266
#8278
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @ssandbekkhaug and the rest of your teammates on  Graphite

Merge activity

Aug 9, 12:21 PM EDT: @ssandbekkhaug merged this pull request with Graphite.


Custom dataset

I don't understand how to change the code to fit my own dataset. My data includes squared RGB jpg files in one folder.

I don't understand how to change the code to fit my own dataset. My data includes squared RGB jpg files in one folder.

May I ask if you have resolved it? I have also encountered the same problem. Can you communicate with me


Update sbt to 1.3.0

Updates org.scala-sbt:sbt from 1.2.8 to 1.3.0.
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention @scala-steward in the comments below.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.scala-sbt", artifactId = "sbt" } ]

labels: semver-minor

Codecov Report

Merging #918 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #918   +/-   ##
=======================================
  Coverage   89.89%   89.89%
=======================================
  Files          34       34
  Lines        1464     1464
  Branches        1        1
=======================================
  Hits         1316     1316
  Misses        148      148

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b824f50...6a6e49c. Read the comment docs.

LGTM! Thanks @scala-steward ...


Support design library symbols and colors

Allow badges to use Jenkins symbols and color references. Update info/warn/error badges to use symbols by default.

Testing done
Used run-fast to create badges used in the screenshots.
### Submitter checklist
- [x] Make sure you are opening from a **topic/feature/bugfix branch** (right side) and not your main branch!
- [x] Ensure that the pull request title represents the desired changelog entry
- [x] Please describe what you did
- [x] Link to relevant issues in GitHub or Jira
- [x] Link to relevant pull requests, esp. upstream and downstream changes
- [x] Ensure you have provided tests - that demonstrates feature works or fixes the issue

Thanks for those enhancements.
The reason for adding color as a constructor instead of a setter was down to the fact that all the sub classes of AddBadgeStep don't support the color parameter, but the docs generator would include it. So in the interest of keeping the changes to a min I went the constructor route. Another option might be to adjust the Step type hierarchy a bit to get everything to align properly. I'll test some stuff out, maybe it's not as much additional change as I had originally thought.

@MarkEWaite I managed to rework the PR to move the color parameter to a setter and only apply it to the generic addBadge step. Was able to revert the doc generator changes as result.

Thanks @cronik!  I saw that there was no online help for the addBadge parameters, so I added online help for them and for a few other items.
Since the plugin is up for adoption, this pull request would be a great one for you to use to adopt the plugin.  Are you interested in adopting the plugin?  I'm happy to continue as a reviewer and tester, since I use the badge plugins and I maintain the embeddable build status plugin.

The online help that I added is working as expected on the addBadge step for all parameters except the color parameter.  I don't understand why the color parameter behaves differently in the online help than the help for the icon, id, link, and text parameters.  Unfortunately, I've run out of ideas to explore.  I've left the source file for the text help in the pull request, even though it is not displayed to the user from the "Pipeline syntax" page.
I think that it is an improvement to have online help, even if the help is not displayed for the color parameter.  The color parameter is well documented in the README.
The online help is visible from the "/pipeline-syntax" page when the addBaadge entry is selected in the dropdown menu and the "?" icon is clicked that is next to each parameter.  That text will be extracted into the "Pipeline steps reference" page after this pull request is merged and released.

While testing the combined pull request:

#133

I discovered that var(--yellow) does not change the icon color.  There is an example in the README that says:
addBadge(icon: 'symbol-star', text: 'A star', color: 'var(--yellow)')

Can you help me identify the mistake I am making when using that example?

The createSummary behavior has changed from the 1.9.1 release to this pull request.  The word "span" is incorrectly inserted into the message when I use appendText as suggested in one of the examples.
Before this change
When I use the following Pipeline:
def summary = createSummary(icon: 'green')
summary.appendText('Completed text added.', true)
summary.appendText(' Bold text added.', false, true, false, 'black')

After this change

The createSummary behavior has changed from the 1.9.1 release to this pull request. The word "span" is incorrectly inserted into the message when I use appendText as suggested in one of the examples.

Fixed in f3091b5f87adbc56b912ee4d641b08b98f51f451

@MarkEWaite Thanks for the collaboration on this PR!

I discovered that var(--yellow) does not change the icon color. There is an example in the README that says:

One issue is that the color style is not set on l:icon. But after some additional testing and digging I realized that even if  <l:icon style="${badgeStyle}" is set, l:icon does not respect it when the icon path starts with symbol-. So I think some revised docs are in order to indicate that only Jenkins palette and semantic color names and classes are support for symbol icon references. For other icon references those css references should work as expected with the update I just pushed.
It should be noted that var(--yellow) works with addShortText. I updated the help and docs to make this more clear.

Since the plugin is up for adoption, this pull request would be a great one for you to use to adopt the plugin. Are you interested in adopting the plugin? I'm happy to continue as a reviewer and tester, since I use the badge plugins and I maintain the embeddable build status plugin.

@MarkEWaite I'm not entirely sure what it means to adopt a plugin, but I suppose I could.

@strangelookingnerd thanks very much for adopting the plugin.  I'm willing to merge and release it if needed, but would prefer that you would do that as a new maintainer.  I'm happy to answer questions or provide other encouragement as needed.

@MarkEWaite I took the freedom of adding my remark from https://github.com/jenkinsci/badge-plugin/pull/130#discussion_r1590258007 to this PR.
This is by not appending plugin-ionicons-api to the icon name (in case they start with symbol-) and rather expect the icon name to follow the pattern of symbol-icon-name plugin-plugin-name as noted in https://weekly.ci.jenkins.io/design-library/Symbols.
I also updated the docs and pipeline syntax help. Let me know what you think and I'll gladly merge and release this PR.

@MarkEWaite I took the freedom of adding my remark from #130 (comment) to this PR. This is by not appending plugin-ionicons-api to the icon name (in case they start with symbol-) and rather expect the icon name to follow the pattern of symbol-icon-name plugin-plugin-name as noted in https://weekly.ci.jenkins.io/design-library/Symbols. I also updated the docs and pipeline syntax help. Let me know what you think and I'll gladly merge and release this PR.

That looks great to me.  I made minor changes to the documentation.  I think it is ready to be squash merged and released.
Thanks @cronik for the pull request and thanks @strangelookingnerd for adopting the plugin


Arm64 status

Hi,
I believe there was some work done towards porting mezzano to a qemu arm64 virtual machine. I was just wondering what the status of this was. I'm happy to put in the time to get it up and running, but if it doesn't work at the moment, I suppose I'll just stick to the amd64 version.
Thanks,
Shaun.

I believe the arm64 port was basically functional when I touched it last, capable of booting to the desktop and running swank. I was able to run it in qemu using hvf (macOS' hypervisor framework), I guess it would run under kvm on an arm Linux machine too, but I don't have a system like that to test on.
I've pushed my most recent changes, along with a note in MBuild/build-cold-image.lisp on how to build an arm64 image. There are makefile targets hvf-arm64 and qemu-arm64 to run qemu with an appropriate set of devices.
Major missing features would be image saving (the snapshot feature) and multicore support.

Ok. Thanks very much. I'll give it a go


ctrl-[d|u] does not move cursor

Hello,
In Vim, using CTRL-D and CTRL-U will move my cursor up and down.
It looks like in vim-mode only my view moves up and down, but the cursor does not move.

I was using an outdated version of vim-mode. My bad!


Adding Examples for Different RNN Structures

Hi,
I wanted to suggest adding examples for different architectures using Recurrent structures.
For example:
![Link to the blog] (http://karpathy.github.io/assets/rnn/diags.jpeg)
Image Link.
I've seen that you've added some example in some of the issues (#51,#21).
Maybe adding them explicitly in the examples folder can reduce confusion.
Siavash

This will certainly help the new starters a lot

@ssakhavi Examples for most of these have been added to the examples folder. If you need more, please let me know.


Revert changes to List body data handling

A previous change to improve the performance of binary uploads accidentally broke the functionality of uploading List<int> json bodies.
Fixes #1858

New Pull Request Checklist

[x] I have read the Documentation
[x] I have searched for a similar pull request in the project and found none
[x] I have updated this branch with the latest main branch to avoid conflicts (via merge from master or rebase)
[x] I have added the required tests to prove the fix/feature I'm adding
[x] I have updated the documentation (if necessary)
[x] I have run the tests without failures
[x] I have updated the CHANGELOG.md in the corresponding package

Additional context and info (if any)

I am thinking we should publish this as 5.2.0+2


Update pyhomematic 0.1.54 + small fixes

Description:
In pyhomematic:

Set SABOTAGE helper for HmIP devices to channel 0
Fix log-message for callbacks
Add support for HmIP-FBL, HmIP-SWDM, HmIP-SMI55

In Home Assistant:

Fix #19619
Ensure that the event we are processing is handeled by the correct entity. See this issue for further details: https://github.com/danielperna84/pyhomematic/issues/193
@pvizeli do you see anything wrong with this approach? So far it seems to work.

Related issue (if applicable): fixes #19619
Checklist:

[ ] The code change is tested and works locally.
[ ] Local tests pass with tox. Your PR cannot be merged unless tests pass
[ ] There is no commented out code in this PR.

If the code communicates with devices, web services, or third-party tools:

[x] New dependencies have been added to the REQUIREMENTS variable (example).
[x] New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.

The question would be, what is wrong on event subscription function they evaluate the correct channels and subscribe it. Theoretical, he should only subscribe to the right channel that we don't need to look every callback call like now

I think it's shomehow related to this particular device having STATE for the actor and also as a sensor.

You're right. I didn't notice that.
I think for the short term it would be best to leave out that fix from this PR and handle it separaely.

I think we can fix that there: https://github.com/home-assistant/home-assistant/blob/dev/homeassistant/components/homematic/init.py#L832-L836
My problem is, I can't remember why we do that. I think we should be fine always to use the channel or 0 and filter others out...


This PC icon from desktop should open Files App.

Can you make This PC icon from desktop open Files app instead of File Explorer from windows. Thanks..

I'm pretty sure that would be a windows limitation. You could try using the registry edit to make files the default explorer.
https://files-community.github.io/docs/#/articles/replace-file-explorer

You may look at the comment in #3090 for a way to do that. Note that there may be additional problems, eg you'll loose access to the control panel.

Merging with #6462.


FI-1870: Update instructions for running inferno

Summary
Updated the instructions for running inferno to match the new way to develop test kits.
Testing Guidance
bundle exec jekyll s in docs, then go to localhost:4000/inferno-core.

Codecov Report
Base: 73.72% // Head: 94.21% // Increases project coverage by +20.49% :tada:

Coverage data is based on head (a61da03) compared to base (fe74113).
Patch has no changes to coverable lines.

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #311       +/-   ##
===========================================
+ Coverage   73.72%   94.21%   +20.49%
===========================================
  Files         191      115       -76
  Lines        9305     3078     -6227
  Branches      771      357      -414
===========================================
- Hits         6860     2900     -3960
+ Misses       2037      178     -1859
+ Partials      408        0      -408

Flag
Coverage Δ

backend
94.21% <ø> (ø)

frontend
?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

client/src/components/Footer/styles.tsx

client/src/api/RequestsApi.ts

...c/components/InputsModal/InputOAuthCredentials.tsx

...components/LandingPage/__mocked_data__/mockData.ts

...lient/src/components/RequestDetailModal/styles.tsx

...mponents/RequestDetailModal/RequestDetailModal.tsx

...src/components/RequestDetailModal/helpers/index.ts

client/src/components/InputsModal/styles.tsx

client/src/components/Header/styles.tsx

...nfigMessagesDetails/ConfigMessagesDetailsPanel.tsx

... and 66 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


the window layout is messed up --crammed to the top left

Tested on Chrome and on Brave. Is there something i can do to fix this? Can i change a setting? It works ok if i make the window narrow and the tiddler opens below the menu area. But side by side seems to be unusable.

That is a little weird. What OS are you on? Chrome is the target browser so if you're getting this behavior there I would expect it to have something to do with the OS. Can you confirm you're running version 0.7? It says 0.6 in the settings, but the download should be 0.7.


Incorrect information in database

Navigate to https://hivemind.cloud.bbc.co.uk/api/devices/
API calls results in 500 internal server error.
Somehow hivemind database tables get incorrect information where device_type='Tv' and plugin_type='HiveMindHive::Plugin'.
For 'HiveMindHive::Plugin' and 'device_type=Tv', this was causing issue.
d = Device.includes(:ips, :macs, :brand, :plugin, :model => [:device_type] ).all.group_by { |d| d.model && d.model.device_type }.keys.first
@devices = = Device.includes(:ips, :macs, :brand, :plugin, :model => [:device_type] ).all.group_by { |d| d.model && d.model.device_type }

@devices[d].each do |dev|
    if dev.plugin_type == 'HiveMindHive::Plugin'
       puts [dev.device_type, dev.plugin_type, dev.inspect]
    end
end

I think this may happen if a device reregisters as a different type. This needs to be checked at registration to avoid a conflict.


Import dsfr/dsfr.module.min

Hi,
Working on a component, I've noticed that react-dsfr is importing dsfr/dsfr.module.min.js (the JS part of @gouvfr/dsfr).

(in the non-bundled version, it seems to be imported by src/start.ts line 47-48):
    // @ts-expect-error
    await import("./dsfr/dsfr.module.min");

From what I understand, we're expecting that this file can't be imported.
But it seems that it is imported at runtime because at runtime, start.jsimports ./dsfr/dsfr.module.min which is in dist folder.
Is this behavior (importing dsfr.module.min from react-dsfr) expected?

Hello @enguerranws,
Yes, the behavior you observed is expected, and here's why:

There's no urgent need for the JS code of the core DSFR to load early on.

To avoid white flashes in dark mode, certain operations must be executed both before and after the script is evaluated. Dynamically importing the script simplifies this process, eliminating the need to check its loading status elsewhere.

For user-specific configurations like Eulerian analytics, it's easier to manage these if the script is dynamically imported. This approach minimizes the risk of the script initializing incorrectly.

We aim to make the setup process as straightforward as possible. Whenever we can abstract away an import, we opt to do so for the sake of simplicity.

I hope this clarifies any questions you may have.
Best regards,

Ok, I get it.
I still have one question though: the script file is importing behavior related to components. For example, the tooltip relies on tooltip.module.js (bundled in dsfr.module.min) to handle tooltip's appearing / positionning logic. When implementing this component in react-dsfr, I thought we would get rid of pure JS logic and reimplement it fully in React?

Ah, I see where you're coming from with your question. react-dsfr serves as an integration toolkit for @gouvfr/dsfr, rather than a reimplementation of the DSFR framework. Maintaining this integration-as-is is crucial for securing continued approval from the SIG.
While adhering to this paradigm introduces notable challenges—such as implementing complex logic to simply indicate whether a modal is open or closed (See code)—it also offers significant advantages. For instance, this approach allows us to delegate the component behavior implementation and ensures compatibility with React Server Components. This is particularly compelling in 2023, given that many UI libraries are still overly reliant on "use client";, whereas most of our components are RSC ready.

@garronej So in the case of the Tooltip component, what should we do? Right now it's kinda hard to reimplement original JS tooltip logic in React because DSFR JS integration is overriding most of the things we could do (by adding event listeners, etc).

I think we shouldn't attemt to do anything more than what the @gouvfr/dsfr is doing.
We shounld NOT reimplement the logic in React.  We should never re-implement any logic already handled by the core library.
The way I see it should look something like:
import { useTooltip } from "@codegouvfr/react-dsfr/Tooltip";

...

const tooltip = useTooltip();

return (
<>

    Exemple

<tooltip.Component>
Lorem [...] elit ut.
</tooltip.Component>

);

Tooltip.tsx
import { useId, type ReactNode } from "react";

export function useTooltip() {

    const id = useId();

    return {
        id,
        "Component": (props: Omit<Props, "id">) => <TooltipComponent {...props} id={id} />
    }

}

type Props = {
    className?: string;
    children: ReactNode;
    id: string;
};

function TooltipComponent(props: Props) {
    const { id, className, children } = props;
    return (

            {children}

    );

}


Fix bug sources

Fix an error in the scripts

@jsitarek could you check this? I introduced a bug in the 'management' of the name of the sources, sorry!

@FedericoDevoto757, can you clean up the PR such that it only has the intended code changes inside? The basic fix is the source name bugfix, and this exist_ok is also harmless, but the changes in LST run list text file file name and Merged directory can be potentially disturbing the code (unless they were intended).
Afterwards we can merge it

Good morning, both of the changes to the directory path name and the list_LST file were intended.

Good morning, both of the changes to the directory path name and the list_LST file were intended.

thanks, I merged it now


Do not use Google-Analytics in non-production environment

Check the solution #172 Maybe we can do something similar there. See the article of how properly integrate GA and React: https://blog.saeloun.com/2022/02/17/how-to-integrate-react-app-with-google-analytics/

The link in the description is out-of-date. Here is the newer plugin: https://www.npmjs.com/package/react-ga4

Done.


ci(semantic-release): add new branch case

To Reviewers

[ ] Skipping review is not a problem (style, chore ONLY)
[x] Not that difficult

Type of Change

[ ] New feature
[ ] Bug fixes
[ ] Feature improvement

[ ] These changes require a usage change

[x] Others (performance improvement, refactoring, CI/CD, etc.)

Checklist

[ ] Updated Storybook documents for component
[ ] Wrote test codes for composable, utils and etc.
[ ] Tested with console(if usages are changed)

Description
SSIA
Things to Talk About

:tada: This PR is included in version 2.0.0-beta.39 :tada:
The release is available on:

npm package (@beta dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Installing wireguard

I'm installing wireguard per the Debian instructions from https://www.wireguard.com/install/ . It's a very nice cross-platform VPN client and server implemented as a kernel module.
After I do
sudo apt-get install  wireguard wireguard-dkms wireguard-tools

the kernel tries to compile a new module, but fails, as the build scripts are for x86 instead of armhf:
Building initial module for 4.4.50-hypriotos-v7+

./scripts/recordmcount: 1: ./scripts/recordmcount: Syntax error: "(" unexpected
scripts/Makefile.build:258: recipe for target '/var/lib/dkms/wireguard/0.0.20180513-1/build/main.o' failed

I've been hacking on this for a bit and tried to rebuild the build scripts, but then ran into other issues.
Suggestions on how to approach this would be welcome (I don't spend a lot of time in kernel-land).

Looks like the kernel was cross compiled. cd to the kernel directory, and then run make scripts.

I think this is the same issue fundamentally as https://github.com/hypriot/image-builder-rpi/issues/215

ok, some progress.
emv@parviflorus:/usr/src/linux-headers-4.4.50-hypriotos-v7+$ sudo make scripts
[... many things compile ...]
  HOSTCC  scripts/sortextable
scripts/sortextable.c:31:32: fatal error: tools/be_byteshift.h: No such file or directory
 #include <tools/be_byteshift.h>
                                ^
compilation terminated.
scripts/Makefile.host:91: recipe for target 'scripts/sortextable' failed
make[1]: *** [scripts/sortextable] Error 1

Turns out I didn't need sortextable or anything else that didn't build.
wireguard:
Running module version sanity check.
 - Original module
   - No original module exists within this kernel
 - Installation
   - Installing to /lib/modules/4.4.50-hypriotos-v7+/kernel/net/

depmod.....

DKMS: install completed.
Setting up wireguard-tools (0.0.20180513-1) ...
Setting up wireguard (0.0.20180513-1) ...
emv@parviflorus:~$ sudo wg
emv@parviflorus:~$ sudo modprobe wireguard
emv@parviflorus:~$ sudo lsmod | grep wireguard
wireguard             150422  0
ip6_udp_tunnel          1789  1 wireguard
udp_tunnel              2191  1 wireguard
ipv6                  349938  120 bridge,wireguard

Now to get a tunnel up to prove that it Actually Works.

tunnel up! the missing tools/be_byteshift.h header did not make a difference in the end.

Great that it's working now. @vielmetti Which steps were needed to fix you issue?

I installed the appropriate kernel headers and (per @zx2c4 suggestion) rebuilt the build scripts, with
emv@parviflorus:/usr/src/linux-headers-4.4.50-hypriotos-v7+$ sudo make scripts

After that, everything came up according to directions when I did
$ sudo apt-get install  wireguard wireguard-dkms wireguard-tools

Found this issue again, glad I opened it and solved my own problem.
The only request is that a next Hypriot release whenever that is should have wireguard shipped by default.

@vielmetti Getting the same issue as above. Which are the appropriate kernel headers?

Interesting.. I still got the problem where wireguard-dkms couldn't be built since the cross compiling. First I tried sudo make scripts in
/usr/src/linux-headers-4.14.34-hypriotos-v7+
sudo apt-get install  --reinstall wireguard wireguard-dkms wireguard-tools
same problem. Then I also did it in
/usr/src/linux-headers-4.14.34-hypriotos+
sudo apt-get install  --reinstall wireguard wireguard-dkms wireguard-tools
and now it worked 🚀. Moving on to see if I can get a tunnel up

Thanks for the update @stoffeastrom - glad you got it working.


Fix remote healing tests

Signed-off-by: Andrey Sobolev<EMAIL_ADDRESS>Fix NSM Remote healing handling.
Description
Fixes NSM Remote healing, also adds different handling of remote NSE and remote NSM die sitiations.
Motivation and Context

How Has This Been Tested?

[x] Covered by existing integration testing
[ ] Added integration testing to cover
[x] Tested locally
[ ] Have not tested

Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.

@haiodo If you rebase on master, I've temporarily disabled Azure testing to unblock everyone while I work with Azure support.

@nickolaev  Please take a look. Thanks.

@edwarnicke Could you please take a look. Thanks.


[5.5] add parameter & return type hints to the Arr class

Same approach as #17780

At this time, I don't have plans to adopt type-hints and return types. Explanation will require a full blog post, heh.

@taylorotwell any update/further explanation on this?


tasks/inspectors.js uses too much memory

There's some sort of memory leak in the indexing script. It appears that the Node process's memory usage goes up over time, (to >1GB resident) and then jumps down at the start of each inspector directory. This issue is most pronounced when setting the --since year in the distant past, of course. I even got a segmentation fault while indexing, which could be due to memory pressure or stack exhaustion.

Nevermind, I tried taking some heap snapshots, and it turns out that the memory consumption after garbage collection remains steady throughout. There's no memory leak, and Node is just waiting longer before garbage collection. This doesn't explain the segmentation fault, but I wasn't able to reliably reproduce that.

I tried running tasks/inspectors.js --since=2014 on the production server twice, and I eventually saw it exit with Killed both times. I presume this is the OOM killer at work. I ran tasks/inspectors.js --since=1 on my machine and graphed the memory usage over time, see below. (This is without any heap snapshots, so there are no artificially induced GCs) Near as I can tell, there is no memory leak, but the script does generate a lot of garbage, very fast. Is there something we need to do on the production server to tune Node's GC behavior? If Node accumulates a gigabyte of garbage without running GC, then the OOM killer will step in again, and cause more headaches.

Aha, there's a command line flag for that! https://github.com/nodejs/node/wiki/Frequently-Asked-Questions

I've tried this with --max_old_space_size=128 and --max_old_space_size=256 and I'm getting segmentation faults now. (Node version is v4.4.3)

A core file says the segmentation fault is happening during V8 GC. This V8 bug could be the cause. The workaround mentioned there is yet another command line flag, --no-use-allocation-folding, but that didn't work for me.

Okay, so it doesn't look like the GC is going to get better any time soon. As an interim measure, we could rewrite tasks/inspectors.js to spawn a new child process for each inspector directory. That way, we trade the overhead of ~50 child processes for not having to run the garbage collector on as many objects. This would hopefully limit peak memory consumption, while avoiding the GC crashes.

In the meantime, the Fabric deploy_reindex and deploy_cold_reindex tasks are a headache waiting to happen. See https://github.com/konklone/oversight.garden/blob/master/fabfile.py#L40


Update to Unicode 14.0.0

It seems the last char update was 2 years ago from the GitHub files display commit dates.
https://www.unicode.org/versions/latest/

It's already updated to Unicode 14 in 2.3.0: https://github.com/Mange/rofi-emoji/releases/tag/v2.3.0


Path Mapping

I need to run my unit tests from a virtual machine. I managed to get this extension to use the vagrant installation of PHPUnit by setting the phpunit.execPath to the following:
vagrant ssh -- /srv/api/vendor/bin/phpunit

but the path of the file I'm testing is relative to the host PC, and is not correct for my VM.
It would be great if I could specify path mapping.

Same for Docker

I agree, that would be neat. I just finally started working some on the extension again. Have been a bit busy. But I want to create drivers like "AbsolutePath", "Composer", "Phar", "GlobalPhpUnit", "Docker", "Ssh". And I have Docker and Ssh left to do (which are the trickier ones I guess). And I might try and do another release in between. Ppl seem to like colorized clickable output using tasks so that might come first.
I'll remember to write here again once I commit what I have to main so you're updated and free to help out and come with ideas.
Cheers

Hi.
For now you can just replace absolute path to relative here:
if (putFsPathIntoArgs)
{
    args.push(vscode.window.activeTextEditor.document.uri.fsPath);
}

it will already help a lot.

Hi, @yurevichcv.
I'm new to VSCode.  Where should I place that condition in the editor configuration?

There is a new version out v4.0.0. Check out the readme section about Advanced config.
Now you can use phpunit.command to set a custom command. And map paths with:
{
    "phpunit.paths": {
        "/local/path": "/virtual/path"
    }
}

Hope this fixes the issue.


WIP: Make tab content flex styled & views manage scroll

Apply only display: flex and flex: 1 (therefore, remove overflow: auto) to containers in meta navigator and tab-bar. This will expose a view to the child that is the full, available screen size that they can play with, no extra overflow attached. If the child needs to overflow, it can wrap it's contents in a normal Box/Div that has scrollable: auto (provided as globalStyles.scrollable). This separates the concerns of child overflow management away from the tab bar and meta navigator and provides more power to the children to maintain their scroll behavior/layout behavior in a marginally impactful SLOC manner. This also brings parity to how layouts are handled on native.
I attempted to fix all views that would be impacted by this change, the main ones being the dumb sheet, settings page, and devices list.
This arose out of a conversation with @MarcoPolo around layout goals and isolation of tab bar and meta navigator.
Ideally there would be no visual diffs, looking forward to what visdiff has to bring us.
@keybase/react-hackers

:mag_right: These commits introduced some visual changes:

Changed: Menubar-Public_Truncated (before) (after)

Changed: Menubar-Public_Normal (before) (after)

Changed: Menubar-Public_Menu_Showing (before) (after)

Changed: Menubar-Private_Truncated (before) (after)

Changed: Menubar-Private_Normal (before) (after)

Changed: Menubar-Private_Menu_Showing (before) (after)

:mag_right: These commits introduced some visual changes:

Changed: Menubar-Public_Truncated (before) (after)

Changed: Menubar-Public_Normal (before) (after)

Changed: Menubar-Public_Menu_Showing (before) (after)

Changed: Menubar-Private_Truncated (before) (after)

Changed: Menubar-Private_Normal (before) (after)

Changed: Menubar-Private_Menu_Showing (before) (after)

I'm looking into why the menubar now has a scrollbar, and how to revert this regression.

Bump @keybase/react-hackers

code seems fine. did you verify all the popups (tracker, pinentry, etc)

@chrisnojima, I verified some but I forgot about tracker. I'll double check those again.

@chrisnojima I've run through tracker, pinentry, the menubar, the login/registration flow, the settings screen, devices screen, folders screen, stylesheet, and dumb sheet and they all appear to be working fine now.

I'm rerunning visdiff to see if the aforementioned regressions have been fixed

code looks fine, if visdiff looks good :shipit:

Yeehaw!
Visdiff output:


HTTP Header Passed to ProcessPayloadFunc

I've added the functionality to both Github and Bitbucket to pass HTTP headers from each request to the ProcessPayloadFunc. This is especially useful with Github, where headers are where the webhook ID can be found in X-GitHub-Delivery.
This works with Github. I have not tested with Bitbucket. The existing tests are passing, but no tests have been added to verify the new functionality.
I can add tests if this looks like a reasonable solution to you. My feelings won't be hurt if you beat me to it.

I'll take a look as soon as I can, can't promise tonight but I will try and yes v2-development should be fine


Wrong syntax highlighting with division on new line

VSCode Version: 1.2.1
OS Version: Windows 10

Steps to Reproduce:

Start any valid arithmetic expression
Place / on new line

Screenshot:

@klinki what language are you in?

TypeScript but it is the same for JavaScript as well.

This issue was moved to Microsoft/TypeScript-TmLanguage#198


Improve management of fractional numeric values in Airbyte Glue integration

Description/Context
Airbyte has a representation of data types that all source connectors map their own types into, and which the destination connectors need to map from into their own types (reference). Numeric values that have fractional components are represented as a number. There are a handful of ways that this can be mapped into supported types in our Glue table definitions, each of which have their own tradeoffs.
We can map the numeric values to the compatible types available in the Hive language reference:

float - 4 byte floating point number
double - 8 byte floating point number
decimal - (this is what we currently use) - up to a 38 digit number with fixed precision (maximum digits) and scale (number of digits to the right of the decimal)

float and double types are flexible, but don't have any guarantees of accuracy in mathematical operations (problematic in financial contexts). decimal is precise and reliable for financial cases, but requires foreknowledge of how many digits to the right of the decimal are necessary.
We need to expose a configurable method of specifying the type of numeric value to use in the table definition, and for the decimal case we need to be able to specify the scale of the value so that we don't truncate the fractional portion of the numeric values.
Plan/Design

[ ] Add a way to specify which type to use for fractional numerics (double or decimal)
[ ] For decimal types add a means of specifying the scale of the type to be created in the table

This is a useful reference to confirm our thinking around preferring the decimal type https://data.solita.fi/to-float-or-not-to-float-choosing-correct-numeric-data-type-in-snowflake/

Made changes to the Airbyte S3 Glue destination connector to add a configuration setting to specify numeric type and scale (decimal only) for fractional values.
Created a new branch https://github.com/mitodl/airbyte/tree/709-fractional-numeric-options-s3-glue from the stringify option changes to leverage the MetastoreFormatConfig we created to handle these parameters.
Created an upstream PR to get these changes merged to the official Airbyte code https://github.com/airbytehq/airbyte/pull/26517/files#diff-38a9968e3b671a7139138a90221d68cc94233a2382b068bbe9b23983feec7506
Worked with Tobias to get get these changes deployed to QA for testing and point all of our QA connections to our Airbyte fork.
Once these changes are merged in our fork and we have updated our Prod connections to pull from our Airbyte fork, this work will be done.


Check identical files in bootstrap

At the moment, bootstrap.py data if run multiple times will generate duplicate data.
Avoid this by checking for identical files.

This will go away when we bootstrap via the /reaper endpoint.


Off by one problem rendering waterway area

When marking area's (that are erroneously tagged waterway), there always seems to be one node missing in the black line:
https://waterwaymap.org/loops/#map=17.03/50.478216/4.109867

The code uses tippecanoe to simplify the geometry. I wonder if that's what's going on here?

I think this is just a rendering issue with tippe canoe simplified geom.


Prevent backbutton pressed during the dialog show

I'm trying to solve this issue #10, please review this pull request

Please re-fork and make your changes, I forgot to update the latest code since last library update. That was my bad

Okay, i am sorry that i change the other files, I think that was automatically from git command. I will do this asap.


Nil pointer error if ContainerImageInfo.ID is not set

Description
API Server returns a 500 Internal Server error if the ContainerImageInfo.Id field is not set. This is caused by a nil pointer panic when the checkUniqueness function tries to deference it.
Expected Behavior
If ID is a required field, the code should check this and return a 400 bad request error.
Actual Behavior
API Server returns a 500 Internal Server error if the ContainerImageInfo.Id field is not set.
Affected Version
main
Steps to Reproduce
POST an asset with ContainerImageInfo.ID not set.
Checklist

[X] I have read the contributing guidelines
[X] I have verified this does not duplicate an existing issue

Hello! I'd like to work on this item. Could you assign it to me, please?


boards: add support for HiFive Unleashed

This patch adds new support for SiFive HiFive Unleashed which has
SiFive FU540 SoC, DDR and some peripherals.
First version is minimum only using UART, SPI and DDR memory area.

Yes, QEMU supported a part of Unleashed hardware and memory map.
But not supported all (Ex. SPI is not exist on QEMU).
qemu-system-riscv64 -machine sifive_u,dumpdtb=sifive_u.dtb
dtc sifive_u.dtb -I dtb -O dts -o sifive_u.dts

sifive_u.dts.txt

@katsuster I noticed that this board is discontinued. Is there another board in production with the same SoC?

@carlescufi Yes, already discontinued. And unfortunately I don't know another boards has FU540.
SiFive is moving next generation SoC FU740 (HiFive Unmatched).
If this support is not valuable for Zephyr, please drop it.

@galak Sorry, I got a mistake. QEMU emulates SPI and GPIO of Unleashed. And can boot from Flash.
https://qemu.readthedocs.io/en/latest/system/riscv/sifive_u.html

@galak @carlescufi
Sorry for ask again... If Zephyr project policy does not welcome the patch for a discontinued board as Unleashed, I will close this PR.
But if not, I want to progress this PR and continue to add supported device (or add driver if we need).

@katsuster - I'm not sure what zephyr policy is w.r.t. unsupported boards, but do you have access to an Unmatched? I'm sure a PR for that board would be quite welcome and likely some of the same code could be recycled.

@cfriedt @katsuster
According to their dtsi in linux kernel, I think most peripherals in Unleashed/Unmatched are highly compatible.
Use uart driver as example:

Unmatched compatible string is  "sifive,fu740-c000-uart", "sifive,uart0"
Unleashed compatible string is "sifive,fu540-c000-uart", "sifive,uart0"

And spi/i2c/gpio/pwm/eth are the same as uart.

@cfriedt
Yes, I also have HiFive Unmatched and want to send PR for Unmatched in next PR. So if this PR dropped, I copy and modify codes for next PR. But if accepted, I just add few codes and DTS for supporting Unmatched.
@cwshu
Thanks a lot for Linux information. I think we can reuse almost same driver codes for Unleashed and Unmatched :)

I found a issue of current OpenOCD that does not support large size SPI Flash so I'm trying to fix and upstream it.
Currently we cannot burn the Zephyr flash ROM image into SPI Flash of Unleashed and Unmatched.
After that I'll try to create patch for HiFive Unmatched.

@katsuster - Could you add support for both in this PR? I think that would sway anyone who might be hesitant to accept

Hi! I managed to get your code working in emulation on Renode (see attached patch). I had to rebase your branch onto upstream/main, though. Maybe it would be beneficial to run this board in simulation on Renode, as it supports Ethernet/QSPI/I²C/PWM for this board?

Add support for HiFive Unmatched.
And I will check build error of SPI flash sample.

@galak @carlescufi @cfriedt
I added HiFive Unmatched, it's currently available board.
Unleashed is discontinued but as @fkokosinski said this is useful on Renode environment (and also on QEMU?).

I would love to merge both / all 😉


Question: What is the difference between the HTML5 version and the server version?

They produce the same interface (at least for ClassicDSD). So what's the difference?

The HTML5 version is for deployment online and can run entirely in a browser, since it is compiled to JavaScript. The main downside is that Visual DSD model compilation and simulation will be noticeably slower for large models, due to the lower performance of JavaScript compared to Windows binaries. The main advantage is that users can try out the tool online without any installation requirements, including via a phone or tablet. I've just put the HTML5 tool back online at https://ph1ll1ps.github.io/visualdsd/ This runs entirely in the browser on the client, with no server-side component.

Thanks for redeploying the tool. This would have saved me quite some time if I hadn't already set it up myself :)
But others will benefit for sure...


Add "Fit to Window Lock" feature

This PR adds the ability for developers to lock the dimensions of the canvas to the window size, along with having additional padding constraints. The canvas will automatically shrink and expand depending on the size of the content when it changes.
@lupinitylabs

Awesome, you nailed it 👍
It's great that the setting is persisted, so this will go straight into my template 😃

Thanks @lupinitylabs! I appreciate that 😄


No scss-lint rule for separating similar blocks of styles

It does not seem to have rule for separating blocks of styles with empty lines. That was a nice one, made scss files look much cleaner and sensible.

I know that when I was integrating https://github.com/sasstools/sass-lint, it did not have this feature. I am investigating if it was added since; I remember there was a ticket for it.

It appears this feature does not exist at the moment. I have raised a feature request https://github.com/sasstools/sass-lint/issues/414


error on plugin load

[Server thread/CRITICAL]: TypeError: "Argument 4 passed to minereset\Mine::__construct() must be an instance of pocketmine\level\Level, null given, called in C:\Users\server\Desktop\New folder\plugins\MineReset-master\src\minereset\MineReset.php on line 188" (EXCEPTION) in "/plugins/MineReset-master/src/minereset/Mine" at line 13

Are you using a different software then pmmp this happens when the plugin doesn't load when using blue light Elywing ect

Only using PMMP. When the world is loaded from pocketmine.yml this error doesn't happen.

Worlds can only really be loaded from the pocketmine.yml or they won't be available in time for MineReset. There are many duplicates of this issue.


Error handling response: TypeError: Cannot read property 'replace' of undefined

I'm getting this on every page in the console. Because it is minified I don't know what variable it is.
Error handling response: TypeError: Cannot read property 'replace' of undefined
    at F (chrome-extension://gbagmkohmhcjgbepncmehejaljoclpil/javascripts/mousetrap.min.js:5:378)
    at Object.bind (chrome-extension://gbagmkohmhcjgbepncmehejaljoclpil/javascripts/mousetrap.min.js:7:488)
    at chrome-extension://gbagmkohmhcjgbepncmehejaljoclpil/javascripts/content_script.js:85:19

Screenshot:

Any news?

Whats your hotkey settings?

metoo

Looks like I didn't received the notification of your reply. I'm not sure what the question is about, I don't see any options about it.
Also don't see this error anymore, but it's also 2.5 years later :)


Doc links take to empty definitions

I'm trying to follow the repo documentation from:
Starting page:
https://docs.monai.io/projects/monai-deploy-app-sdk/en/latest/index.html
When I click the link for MODULES APIS -> Operators on the bottom of the page, it takes to this page:
https://docs.monai.io/projects/monai-deploy-app-sdk/en/latest/modules/index.html#operators
which has empty content for the API docs.  Seems like the actual content can be found here:
https://docs.monai.io/projects/monai-deploy-app-sdk/en/latest/modules/operators.html
Is the documentation build system broken?

Verified. It looks like it's not able to parse index.html#operators.
Assigned to @gigony


Question about edit performance

I'm confusing about the edit performance showed in README

Is IKE and ICE the same method?
Why do the results in two tables differ when using the llama-2-7b model and ZsRE dataset (eg. ROME)?

1 IKE and ICE is different method.
2 KnowEdit is constructed by re-organizing and extending exsiting datasests including WikiBio, ZsRE, WikiDataCounterfact, WikiDataRecent, convsent, Sanitation to make a comprehensive evaluation for knowledge editing. Special thanks to the builders and maintainers of the those datasets. You can find details at https://github.com/zjunlp/EasyEdit?tab=readme-ov-file#Dataset

Thanks for your reply, Is there a brief introduction or paper available regarding the ICE method?


request atomic write()

thanx for the simple and pythonic MQ base MongoDB;

commonly, karait had to accept multi-message-sender

so, duplicate message always happened

so, we realy need the karait.write() lilke as $upset :

point unique key
if there is't same message, write into new
else there is same message, cancel write, retuen None

hope result as:
queue.write({'pid':123, 'action': 'wget ...'},
    unique='pid')

this feature should append karait?

This sounds like a useful feature, and I would love to help solve your use-case better :) I will add this when I have a bit of time.

thanx for all ;-)
in fact, as one realy wokring TaskQueue,
the beanstalkd is the tiny and perfect:
https://github.com/kr/beanstalkd/blob/master/doc/protocol.txt#L81
of course, beanstalkd can not support serialized/distributed ...
so Karait base MongoDB,the perfect NoSQL works!
if Karait can support the TaskQueue Flow like beanstalkd;
that means wonderful!

I've been thinking about how you'd pull this functionality off:

An upsert doesn't do the trick, because the last writer to insert into the queue would overwrite the older insert.

Unless I'm crazy, I think the only way to pull this off in an atomic way would be using db.eval().

func = function() {r = db.messages.find_one({unique_field: unique_field}); if(r) { return }; db.messages.insert(document); }
db.eval(func, {unique_field: value, document: doc}})

Huuuu, simple is better ;-)
i believe in:"every problem can be resolve by plugin one more level!"
so unnecessary fight with one collections?
- add one uniqe seed collections, such as karait_uniqe
- document as:

{'routing_key':''
    ,'uniqu_key':''
    ,'inserted_var':['',]
    ,'_meta':{'ref_id':'point which doc. created the uniqe seed'
        ,'XXX':'others need meta info.'
    }

}

- so 1st insert with uniqe ref. , copy the var. into karait_uniqe.inserted_var
- the next insert try,check the var. if had inserted, breakout it!

I think I've added functionality that will support what you're looking for, when writing:
write will now return True if a write succeeds and false if it fails.
See this unit test: https://github.com/bcoe/karait/commit/e983f4644adcc05036dd2f3db794edee6e363e57#L1R203
Play with this, and if it does the trick I'll add the feature to the Ruby and Python libraries as well. I'm mostly interested in performance.

I have added this functionality to the Node.js and Ruby clients.


Update MSCS Default Properties File and Comments

Add missing $JVM_ARGS in mscs-default-server-command default property
Add info for properties that set replacement variables in mscs_defaults()
Moved property keys in global list to match per-world list
Add missing $JVM_ARGS in variables comment
Add missing $JVM_ARGS variable to mscs-default-server-command and mscs-server-command property keys

This looks good. Thanks for the work


fix(font): use Mozilla version of font to fix bugs associated with Fira Font

fixes #658
pointing styles at the mozilla cdn for Fira Sans font fixes all display issues. replacing the woff files that were included with the ones from the mozilla cdn didn't. so i assume that there are different formats being used to fix the bug here.
could probably pull everything in locally if we wanted, but it'd be bigger than what ya'll had before. lemme know if you'd like it local.

r? @aturon
(rust_highfive has picked a reviewer for you, use r? to override)

Removing the local versions seems fine for the website, but the equal fix in rustdoc would want the local files, I'd imagine.

ok i just added the local files. all come from here, fyi https://github.com/mozilla/Fira/blob/master/fira.css

@bors r+

Er


stamina/health/food bars gone in 2.3.0

What the title says.  They also don't appear in HUD edit mode.  I rolled back to 2.2.3, and it works again.  I made no changes in my config file.

They were moved to a different section in the config

sorry, there was a small miscommunication with the pull request. the backwards compatibility for the config didn't quite make it into the release. we are working on it