globalState does not rerender automatically; requires an action to refresh

Component visibility tied to globalState does not update correctly until an action is performed on the form.
For example, if a selectedRow is present, a button should be hidden. If there isn't a selectedRow, the button should be visible. However, the button’s visibility does not update as expected until something is entered in the configured text field
Steps to reproduce the behavior:

Go to 'pd-enterpriseproject-adminportal-test.shesha.dev/shesha/forms-designer?id=3d45b823-89c0-44be-89f7-a9788ce545c4'
Click on the checkbox of any record
Check the button if it is hidden
Actual Results: The button still shows
Enter something on the textfield and see how the button will respond
Actual Results: The button gets hidden

Expected behavior
The globalState should render accordingly when there is a state change

Testing form from Function: https://function-adminportal-test.shesha.dev/dynamic/testmodule/globalstate-test?mode=edit


Change 502 Bad Gateway to 504 Gateway Timeout

Is your feature request related to a problem? Please describe.
I'm am trying to understand why I'm getting 502.3 Bad Gateway responses when the real issue is a timeout.
Reference: HTTP Error 502.3 - Bad Gateway when timeout
Describe the solution you'd like
Change the response from 502 to 504.
Describe alternatives you've considered
None
Additional context
A few comments from the reference issue:

Looks like we should be returning a 504 instead of a 502

504 makes much more sense, since I just spent hours troubleshooting middleware and routing due to misleading Bad Gateway (it implies something's wrong with infrastructure or configuration instead of timeout error).

This is a pretty severe breaking change and we don't think the benefit is worth it. We don't have any plans to change this behavior at this point.


Add dependencies in setup.py

Parallel to iiasa/message_ix#139
Please confirm that this PR has done the following:
PR checklist:

[x] Tests added
[ ] Documentation added
[ ] Description in RELEASE_NOTES.md added

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Same question applies before this is ready to go: is cython a dependency here (where?), or of message_ix? In the latter case, delete it from the list.

@gidden replied on the other PR:

Cython is probably no longer a dependency (used to be)
…so I will try removing it.


Implementation called django-admin.py

for https://github.com/graphite-project/graphite-web/pull/622
@iksaif please review this pr!

Current coverage is 66.46% (diff: 100%)

Merging #1763 into master will not change coverage

@@             master      #1763   diff @@
==========================================
  Files            55         55
  Lines          6262       6262
  Methods           0          0
  Messages          0          0
  Branches       1243       1243
==========================================
  Hits           4162       4162
  Misses         1877       1877
  Partials        223        223

Powered by Codecov. Last update 7a5359d...0c7a204

LGTM


Add protection to Pinot upon reload of table

I experience this issue upon configuring my star tree index. I moved a high cardinality col from the top of the dimensionSplitOrder to the bottom which 3x my star tree. Upon reload of the table, my cluster faced high CPU and memory which killed my cluster. I couldn't stop the reload of the segments and the only way is to disable my table. It could be good if Pinot could stop the reload with warning/error messages telling me that reload has stopped as my star tree 3x in size.

Aborting a submitted reload request is a good feature to have, but even if we abort it, server will load the segments when it starts the next time, which will trigger the star-tree creation. One solution I can think of is to add a node limit to the star-tree index config, and not creating the star-tree when it hits that limit. Unfortunately in order to know star-tree is too large, each segment needs to try generating the star-tree once and realize it cannot be generated


Raw UDP over IPv4 traffic with incremented source and decremented destination ports

Config

Two back-to-back connected test ports

One for tx
Another for rx

One Flow with,

Fixed frame size of 256B
Rate of 50 PPS
Packet count 100
Packet headers ethernet, ipv4 and udp

UDP header with,

Increment source port
Decrement destination port

Validation

Push configuration
Start capture on rx port
Start transmit on tx port
Wait until following is as expected,

Frames tx/rx, bytes tx/rx and transmit state in flow metrics

Fetch capture and ensure following is as expected,

ethernet.ether_type
ipv4.protocol, ipv4.total_length
udp.src_port, udp.dst_port, udp.length
size of each frame
(best effort) checksum of all headers


proposal: log/slog: add an 'error' field to 'Record'

This proposal is to discuss adding an error field to Record, and potentially adding associated methods to slog and Logger.
Example adding error to Record:
type Record struct {
	// The time at which the output method (Log, Info, etc.) was called.
	Time time.Time

	// The log message.
	Message string

	// The level of the event.
	Level Level

	// The error associated with the event, if any.
	Err error // <-- this is new.  This could potentially be an `any` instead of an `error`.

// etc...
}

Possible new methods:
func (l *Logger) WithErr(err error) *Logger {
	// Returns a copy of Logger with the error field filled in
}

// Err returns an Attr for an error.
func Err(v error) Attr {
	return Attr{internalErrorKey, ErrValue(v)}
}

// internalErrorKey is private on purpose, and the string could be any unlikely string.
// When an Attr comes in with this key, the value replaces the Record's Err field instead of being added to the array of regular attributes.
const internalErrorKey = "!ERROR!!"

// ErrValue returns a Value for an error.
func ErrValue(v error) Value {
	return Value{any: v} // Could be optimized?
}

Advantages of doing this proposal:

Handlers can choose how to handle and display errors.
Handlers can choose whatever key they want, if any, and it will affect all errors.
Eliminates confusion for what key to use when adding an error.
Eliminates possibility of libraries choosing different keys. Instead there are no keys, and the handler chooses what if any key to use when displaying.

Other comments:

Custom error can still implment log.LogValuer, fmt.Stringer, and/or json.Marshaler, and the Handler can still choose how to handle that.
Deduplication of message keys can be handled in the exact same was as the existing Time, Level, and Message fields on Record.
Errors are just as important and special as messages and timestamps and levels.
By doing this proposal, we avoid a situation where 1 single application, that uses multiple libraries, ends up having log output looking like this because each library chose a different key to use for error types:

{
	"msg": "library1",
	"error": "db: bad connection"
}
{
	"msg": "library2",
	"err": "duplicate login detected"
}
{
	"msg": "library3",
	"_ERROR": "divide by zero"
}

With this proposal, the handler would choose what the key is, or if there even is a key.
This puts control back where it should be for something as important as errors.
If the log aggregation system I am using wants messages or errors to come in with a specific key or in a specific format, I can accomodate that with a custom handler.
This lets me have consistent logs, even for libraries and sub-libraries.  Like this:
{
	"msg": "library1",
	"err": "db: bad connection"
}
{
	"msg": "library2",
	"err": "duplicate login detected"
}
{
	"msg": "library3",
	"err": "divide by zero"
}

thanks,
Chris
https://github.com/golang/go/issues/56345 and @jba

It may be discussed in #56345, and removed.

It may be discussed in #56345, and removed.

Record has never had an Error field.  What was removed in previous discussions was a public ErrorKey, which this proposal does Not reintroduce.

This would be really nice. After coming from Logrus and Zap, I find myself missing a WithErr or even just a dedicated error attribute type, both for few key presses and the desire to make sure errors are always logged and aggregated the same way.
I have currently have a wrapper like this in every project using slog:
func ErrAttr(err error) slog.Attr {
	return slog.Any("error", err)
}

We discussed this on the main proposal and decided against it. Representative comment: https://github.com/golang/go/issues/56345#issuecomment-1464163489.

We discussed this on the main proposal and decided against it. Representative comment: #56345 (comment).

Record contains Time, Level, and Message, which lets the handler decide what to use for keys for those.
If Record also contained Err, it would let the handler easily decide on the key for that too.
This proposal does not force a key on anyone.

True, it doesn't export a key. But another way to look at it is that the Record.Err field isn't really necessary: if the key were exported, then anyone could look for it with Record.Attrs to get the error.
For that matter, anyone could look for a value of type error to find errors. The key doesn't matter. I could imagine a middleware handler or ReplaceAttr function that looks for error values and overrides the keys with err, err2, err3, etc. to make them uniform and unique.
Which brings up a question: how would your proposal handle multiple errors in a log call?

Which brings up a question: how would your proposal handle multiple errors in a log call?

I would say that the most recent error would be kept (ie: calling WithErr replaces any previous error).
This could depend on the answer to https://github.com/golang/go/issues/59365

This proposal has been added to the active column of the proposals project
and will now be reviewed at the weekly proposal review meetings.
— rsc for the proposal review group

I can be confusing if we have a record at error level with Err nil or a record not at error level but with an Err value.

I can be confusing if we have a record at error level with Err nil or a record not at error level but with an Err value.

I don't think that is related to this proposal.
You can have an error level log, without an error currently, and also can do it with this proposal too.  An example would be something that is a problem for the application (such as no more messages in the queue, or the user did something bad) that isn't caused by golang.  I have such log lines in my applications, usually at only the highest level.
You can have a non-error level log (such as debug level or warn level) that does include an error currently, and also can do that with this proposal too.  An example would be an error that is returned but mostly ignored, or otherwise dealt with in a way that doesn't need anyone to be woken up at night for (if you have pagerduty or something set to ping people if Error level logs lines are seen).  Such as a context cancellation, which I usually log at info level if it is being handled appropriately.  I have such log lines in my applications too.

I would say that the most recent error would be kept (ie: calling WithErr replaces any previous error).

But what if I want the last one? Or both?
My point is, I think it's too limiting to have a Record.Err field. There are too many ways to log errors for slog to take a position. That is not the case for the other built-in fields (except for the minor question of what to do with an empty message).

Based on the discussion above, this proposal seems like a likely decline.
— rsc for the proposal review group

No change in consensus, so declined.
— rsc for the proposal review group

My conclusion from reading the original log/slog proposal is that tying the error to slog.Error has been rejected for fair reasons. But I haven't been convinced about declining this proposal.

My point is, I think it's too limiting to have a Record.Err field. There are too many ways to log errors for slog to take a position. That is not the case for the other built-in fields (except for the minor question of what to do with an empty message).

This seems like a valid point, I personally have never had the need to do anything much different than using my own custom ErrAttr function, since usually errors are wrapped and propagated upwards, meaning, it's almost always a very clear case of how we're logging the error. My argument is that, considering that error is a first class citizen, and a primitive of the language, and the fact that so many people tried typing slog.Error() as the attribute and then we're left googling to figure out why this isn't included in the library. It goes against, at least to me, my mental model of the language. Also, considering many third-party libraries ( that we're the go-to standard prior to log/slog introduction, notably Zap and Zerolog ), indeed to function this way.

Which brings up a question: how would your proposal handle multiple errors in a log call?

Since the current proposal forces everyone, to write their own error attr in some way or form, why wouldn't the multiple errors be treated the same? I'd argue that the case for multiple errors can be treated like error attribute is treated at the moment, write your own solution for handling it.
Error attribute also does not tie the implementation to any logging level, so you're free to mix and match.
Having said all of that, I do agree that the error attribute does not have a clear cut solution like the others, but I cannot help but feel like I am hacking and piecing together what I would expect to be part of the library when writing my own error attributes, especially since I have to put it in some module and reach out for it every time, even though I have log/slog already imported in scope.
Please do correct me, and tell me if I am missing something, but this has been nagging me ever since I tried I tried the library some while ago. Can anyone point me to the current recommendation on how to approach error logging within the current iteration of the log/slog, are there any guidelines available?


chore: Update cog hooks

Add 'v' prefix to cog pre/post hook commands.

Codecov Report

Merging #48 (7817811) into main (0b7b5f1) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

@@            Coverage Diff            @@
##              main       #48   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files            1         1
  Lines           99        99
=========================================
  Hits            99        99


Cordial theme does not exist anymore in the last release

I recently upgraded to the latest release, and wanted to set my theme to Cordial but I get the warning :
no such file or directory: /Users/_X_/.oh-my-zsh/themes/cordial.zsh-theme
It seems this theme does not exist anymore, or may have been renamed?

This theme was never bundled with OMZ, it seems the author misplaced the theme information in the Themes wiki page instead of the External themes one. You can find more information over at the repository web: https://github.com/stevelacy/cordial-zsh-theme.


NIM-17263: Fix Security Vulnerabilities

Overview of Changes
Addresses 5 "Vulnerabilities" from Sonar.
Issues Fixed
src/.../nimbus/app/extension/config/WebConfig.java

Make this member "protected".

L53

src/.../oss/nimbus/domain/cmd/CommandElement.java

Make this member "protected".

L66

src/.../domain/model/config/internal/DefaultValidatorProvider.java

Make this "public static factory" field final

L30

Make factory a static final constant or non-public and provide accessors if needed.

L30

src/.../model/state/builder/internal/DefaultQuadModelBuilder.java

Make restTemplate a static final constant or non-public and provide accessors if needed.

L72

You did it @lopezton-anthem!
Thank you for signing the Anthem Opensource Software CLA.


Fixed typo in french shadow size

Because I die inside when I see it in the app :)
Great job!

Thank you!


Player statistics not displaying

Player statistics is currently empty - ServerMessageType isn't deserialized properly.

Statistics aren't showing for my profile, but for other player they do. Is this related to this old bug?


smem tab

Could you add a performance tab which gives a breakdown of what is using up the swap memory (using smem)

Hi,
Thank you for this suggestion.
But as far as smem is considered it is an extra piece of software which you gotta install with sysmontask as dependancies which some people might not find good as the size of total download get increased just for a system monitor.
But I will look at what can be done.


feat(gcp): add compute_instance_group_manager

Objective:
Add support for compute_instance_group_manager and compute_region_instance_group_manager.
Status:

[x] Added to registry.go
[x] Added resource file
[x] Added integration tests
[x] Added unit tests if applicable - Not applicable

Issues:
Currently as suggested by @tim775, only one apllication version is supported per instance group. Support for multiple version per instance group could be added in a separate PR.
Useful links:
Pricing:
https://cloud.google.com/compute/vm-instance-pricing
https://cloud.google.com/compute/disks-image-pricing#disk
https://cloud.google.com/compute/gpus-pricing
Terraform:
https://registry.terraform.io/providers/hashicorp/google/latest/docs/resources/compute_instance_group_manager
https://registry.terraform.io/providers/hashicorp/google/latest/docs/resources/compute_region_instance_group_manager
https://registry.terraform.io/providers/hashicorp/google/latest/docs/resources/compute_instance_template

This is great Kevin, thanks! Looks like it turned into a bit of a beast. I added a couple quick suggestions to note that we don't support multiple versions.

Thanks Tim! I've added the changes


Fix bug #454

Checklist

[x] npm test passes
[x] tests and/or benchmarks are included
[x] commit message follows commit guidelines

Description of change
forEach function should not be used for removing items, but use for-loop instead. forEach function can only remove the odd items. That's why bug #454 occurred.

Test case 'graph group remove' cannot be completed. Close this PR.

thx for contribution !


Option to ignore missing comment_file

We try to get output of a failed task in comment_file but sometimes the task fails such that no file is generated. We would like the option to ignore that and simply register the desired status.

Hi and thanks for the issue! I think if we implemented this we'd be silently ignoring errors when someone specifies the wrong path to a file. Since comment_file will only create a comment if the file is not empty, is it not possible for you to just touch the file before writing to it - iff nothing is written, no comment will be created?

Closing this due to lack of comments.


fix(engine/sqlite): Fix convert process for VALUES

close #2331

Based on endtoend test output this looks good to me, but I'd want @kyleconroy to make a final determination


Update configure-mdo-anti-phishing-policies.md

Fixed the note about maximum number of Protected users that can be specified in the policy. Defender GUI, page reads that 301/350 are protected.

issue#https://github.com/MicrosoftDocs/microsoft-365-docs/issues/10028

@JohanFreelancer9 Please copy review

Learn Build status updates of commit 57458bd:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

microsoft-365/security/office-365-security/configure-mdo-anti-phishing-policies.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel

Sorry. I didn't see the PR to fix this, so I made another, but mine includes everywhere the 350 number was described 17188.
Closing


Family Edition cards

Have you considered adding the CAH Family Edition deck to the service? It looks like the B&W cards would only need to be added to cards.json and add a deck type with indexes to those?
If I created a PR, could this be integrated and deployed to the .io website?

Hey! Yep, it'd just be a data ingress task entirely.
I'm happy to populate the data if you can generate it with the correct indicies & B&W cards as you pointed out.
Great idea!


ramp up slang features for vscode users

[x] Ship a new extension version, including the Slang binaries.
[x] Ramping up flags.json settings introduced in #523 to 100% gradually.
[x] Observing any errors/telemetry issues in Sentry, and report/fix as-needed.
[x] Report any Slang issues, and integrate fixes as they are released.

cc @Xanewok as the extension was recently upgraded to the latest Slang version in #545

@OmarTawfik should we close this one?

O

Looking into this, I suggest keeping it open until we eventually remove the flags.json usage and release a new version.


Split copr project into stable and latest

This is a followup to #3374 requiring creation of 2 new copr projects stable and release (mirroring the RTD configuration) which have the GH release builds and main branch builds respectively.
This allows to simplify the get-current-version as we can simply use the packit defaults and not have to worry about the ordering. Inside each project the builds are guaranteed to be in appropriate order.

/packit build

/packit build

Both failures seem to be related to inaccessible epel9 files:
Failure downloading https://dl.fedoraproject.org/pub/epel/epel-next-release-latest-9.noarch.rpm

Merging.


Free the reply in redisGetReply when passed NULL

We currently perform a NULL check in redisGetReply and don't push the
reply back to the caller, but we don't free any reply meaning that this
will leak memory:
redisGetReply(context, NULL);
This change simply frees the reply if we were passed NULL.
Addresses #740

This code hasn't been changed in almost ten years but it seems like we should free the reply especially since we're already doing a NULL check.
cc: @yossigo


draft-bweeks-acme-device-attest-01 server prototype

Hi @brandonweeks,
As you may have noticed, @smallstep we were made aware of the work you've done in this branch. Very exciting to see a merger between ACME and TPMs! 😄 We're looking forward to supporting ACME Device Attestation in step-ca, even though it's at an early stage of standardization.
Are you planning on creating a PR to upstream? If so, is there anything we can do to help?


MultiIndex DataFrame saving to csv and loading breaks its structure.

When you save MultiIndex DataFrame to csv and then loading it with no additional parameters pandas not able to read multiindices properly and reconstructed dataframe is incorrect, however all MultiIndices are stored. Creating MultiIndex DataFrame:
>>> import pandas as pd
>>> arrays = [np.array(['bar', 'bar', 'baz', 'baz', 'foo', 'foo', 'qux', 'qux']),
np.array(['one', 'two', 'one', 'two', 'one', 'two', 'one', 'two'])]
>>> tuples = list(zip(*arrays))
>>> index = pd.MultiIndex.from_tuples(tuples, names=['first', 'second'])
>>> df = pd.DataFrame(np.random.randn(6, 6), index=index[:6], columns=index[:6])

>>> df
first              bar                 baz                 foo
second             one       two       one       two       one       two
first second
bar   one     0.608879 -1.128122 -0.238610  1.089921  0.521766  1.116998
      two     1.161840  0.876528 -1.417781 -1.150305 -1.043776  0.458298
baz   one     1.761382  0.634688 -1.146492 -0.082379  0.414079 -0.520011
      two     1.079547  0.667917  0.122468 -1.112053  0.408232  0.703068
foo   one    -1.031256  1.439310  0.604550 -0.275087 -0.316610 -0.589309
      two     1.730061 -1.213560 -0.581617 -0.260879  0.069140  0.970397

Now saving to .csv
>>> df.to_csv('test.csv')

File content:
first,,bar,bar,baz,baz,foo,foo
second,,one,two,one,two,one,two
first,second,,,,,,
bar,one,-0.218970051706,-0.37813933444,-0.7634843365,-0.704262374956,-0.839464555892,0.541422908532
bar,two,0.681850126209,-0.12138626844,0.361273042684,0.143076786043,0.89542332917,-1.4010526032
baz,one,-0.818985292735,-1.09454292831,0.162462638192,-1.03231385607,0.553385654032,0.585854960842
baz,two,-1.54054784208,1.00696690064,0.976815889071,-1.39618300884,0.283526891003,-0.942377368698
foo,one,1.08113073993,-0.29494275034,0.738820962724,-1.62865612926,1.10227198603,-0.628396328368
foo,two,0.135391399079,0.410272615409,0.59806563553,0.172448276698,0.11403085441,1.47679237362

Loading file:
>>> df = pd.read_csv('test.csv')

    first Unnamed: 1             bar           bar.1              baz  \
0  second        NaN             one             two              one
1   first     second             NaN             NaN              NaN
2     bar        one  0.608879221531  -1.12812151143  -0.238610193059
3     bar        two   1.16184022363  0.876527615412   -1.41778054545
4     baz        one   1.76138211998  0.634687797737   -1.14649190565
5     baz        two    1.0795474718  0.667917354209   0.122468371132
6     foo        one  -1.03125632895   1.43930972259   0.604550496274
7     foo        two   1.73006141389  -1.21356047236  -0.581617481203

              baz.1              foo            foo.1
0               two              one              two
1               NaN              NaN              NaN
2     1.08992073325   0.521766323704    1.11699823915
3    -1.15030481312   -1.04377642582   0.458297920053
4  -0.0823790312557   0.414078987249  -0.520010569472
5    -1.11205302607    0.40823221543   0.703068488788
6    -0.27508709062  -0.316610246209  -0.589308900542
7   -0.260878563358  0.0691397545038     0.9703965012

Yes, I know that I need to specify columns and index parameters, but why I should do this? All information needed to restore original DataFrame with MultiIndex are already in the file. Is it possible to make it default to parse MultiIndices in csv, for example, using multiple separators in a row:
first,second,,,,,,

In your example (very clear, thanks!)
first,,bar,bar,baz,baz,foo,foo
second,,one,two,one,two,one,two
first,second,,,,,,
bar,one,-0.218970051706,-0.37813933444,-0.7634843365,-0.704262374956,-0.839464555892,0.541422908532

there's no way to reliably determine whether the first few rows are headers vs. names vs. missing values. There's a lot of things that generate CSVs, not just DataFrame.to_csv, and we need to accept them all.
Storing to a CSV is fundamentally lossy. Consider using HDF5 if you want to be able to roundtrip reliably.

Ok, thanks. Yes, HDF5 is great, but it has fundamental restrictions of not being able to store dataframes with duplicate column multiindeces (it's pytable's issue) which I usually have in omics data and workarounds seems ugly.

@aleksandrzenin duplicate column indexes are really really a performance drag, you should not use them; you would have to show an example of this, as nothing is a pytables issue, as that is just a storage format, pandas does the schematizing.


New Release Updates

Build the html pages from Tristans previous PRs
Add BI documentation to some areas
Add release notes

@mcooper LGTM, kindly merge!


Component.start() - loop argument is not propagated properly

Consider the following:
import asyncio
from autobahn.asyncio.component import Component

comp = Component()
loop = asyncio.new_event_loop()
f = comp.start(loop=loop)
print("passed loop id = ", id(loop))
print("retruned loop id = ", id(f._loop))
print("default loop id = ", id(asyncio.get_event_loop()))

Which results in
passed loop id =<PHONE_NUMBER>30696
retruned loop id =<PHONE_NUMBER>99416
default loop id =<PHONE_NUMBER>99416

I.e. somewhere down the road, Autobahn falls back to use the default loop.
It breaks on us while trying to run tests using asynctest module which tries to provide isolated loop for each test. For now we get away with setting use_default_loop to False, which is not ideal of course.

For some context here: yes, this should be fixed properly.
txaio is our library providing an asyncio + Twisted compatibility layer and as a "lowest common denominator" type library it uses ONE event-loop at a time (because Twisted only ever has one). So there are a couple edge-cases that need to be handled differently (definitely any "batched timer" usage, for example). To be completely proper, the loop= args should probably be pushed down to create_future_*() functions inside txaio..
For your tests, do either of the above-suggested solutions help?

Hi @meejah,
Sorry for late response. txaio.config.loop = x does help, though it's ugly to repeat this statement in every async test.

@meejah
Please note, that with Python 3.7 which issue becomes more severe as it breaks asyncio.run()  (which always creates new loop). That is, something as simple as
import asyncio
from autobahn.asyncio.component import Component

async def main():
    await Component().start()

asyncio.run(main())

Fails with:
Using default loop
Traceback (most recent call last):
  File "/tmp/bug.py", line 8, in <module>
    asyncio.run(main())
  File "/usr/lib/python3.7/asyncio/runners.py", line 43, in run
    return loop.run_until_complete(main)
  File "/usr/lib/python3.7/asyncio/base_events.py", line 573, in run_until_complete
    return future.result()
  File "/tmp/bug.py", line 6, in main
    await Component().start()
RuntimeError: Task <Task pending coro=<main() running at /tmp/bug.py:6> cb=[_run_until_complete_cb() at /usr/lib/python3.7/asyncio/base_events.py:158]> got Future <Future pending> attached to a different loop

Moving autobahn import inside async def main() makes it work - meaning that txaio grabs (wrong) default loop somewhere during import stage, IMHO.

Bump - has there been any resolution on this as basic asyncio.run() is broken with decorator-style applications without manually setting txaio.config.loop.
Oddly enough with the inadvisable ApplicationRunner/Component(ApplicationSession) style it somehow works without touching txaio.config.loop — in this case it manages to use the correct loop.

Okay, I can confirm that what asyncio 3.8 is doing here is changing the default loop after asyncio.run is called -- that is asyncio.get_event_loop() is something else between import and after asycnio.run() gets called. That's kind of unfortunate.
The "real" fix remains the same (although now that txaio has a .with_config() it might be a little easier): have each Component/session track its txaio context (instead of using the global one). A workaround for users of asyncio is to re-assign txaio.config.loop inside their main or (as pointed out in this thread) delay imports :/

Now that https://github.com/crossbario/txaio/pull/163 is merged in txaio this should be re-tested.

Thank you!
+@worroc @motinani


WIP: Translate concepts/services-networking/ingress-controllers/ in Japanese（#14886）

close https://github.com/kubernetes/website/issues/14886

^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Remember to delete this note before submitting your pull request.
For pull requests on 1.15 Features: set Milestone to 1.15 and Base Branch to dev-1.15
For pull requests on Chinese localization, set Base Branch to release-1.14
For pull requests on Korean Localization: set Base Branch to dev-1.14-ko.<latest team milestone>
If you need Help on editing and submitting pull requests, visit:
https://kubernetes.io/docs/contribute/start/#improve-existing-content.
If you need Help on choosing which branch to use, visit:
https://kubernetes.io/docs/contribute/start#choose-which-git-branch-to-use.
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

/assign @cstoku

@jkkitakita WIPがとれてからでいいので、CLAへのサインをお願いします

@jkkitakita I'm closing this PR because the CLA status check has not been resolved for over a month. Please

feel free to reopen this if you are still interested in getting it merged, and
try follow instructions here to debug your CLA status if you have already signed it, and
resolve the conflicts in your next commit.


net: gptp: Remove ref. to undef. CONFIG_NET_GPTP_STACK_SIZE

No Kconfig symbol called NET_GPTP_STACK_SIZE has ever been defined in
the Zephyr repo. Drop the CONFIG_* prefix from the #define.

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@1981eef). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master   #14056   +/-   ##
=========================================
  Coverage          ?   52.27%
=========================================
  Files             ?      307
  Lines             ?    45469
  Branches          ?    10526
=========================================
  Hits              ?    23769
  Misses            ?    16902
  Partials          ?     4798

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1981eef...9b867f3. Read the comment docs.


[SPARK-7577][ML][doc] add bucketizer doc

CC @jkbradley

Merged build triggered.

Merged build started.

Test build #33641 has started for   PR 6451 at commit e350e49.

Test build #33641 has finished for   PR 6451 at commit e350e49.

This patch passes all tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
public class JavaBucketizerSuite

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/33641/
Test PASSed.

@yinxusen Other than those comments, these look good.  Thanks!

@jkbradley Fixed.

Merged build triggered.

Merged build started.

Test build #33651 has started for   PR 6451 at commit e2dc32e.

Test build #33651 has finished for   PR 6451 at commit e2dc32e.

This patch passes all tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
public class JavaBucketizerSuite

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/33651/
Test PASSed.

LGTM, merging into master and branch-1.4  Thank you!


Title display for works (draft)

PR created just as an aid to discussion.
The issue this is trying to solve is to include the Work in the Track Title, but only if the Track Title doesn't already contain the Work. The background is that people (like me!) can have a mixture of tagging for classical works, as we have struggled to make something work for LMS (before the recent enhancements) and other servers. (That's without considering the inconsistencies in the tagging of tracks from online services).
For example, a classical track could be tagged either:
WORK="Violin Concerto in D Major Op.77"
TITLE="II. Adagio"
or
WORK="Violin Concerto in D Major Op.77"
TITLE="Violin Concerto in D Major Op.77: II. Adagio"
In the first case we need to concatenate the WORK and TITLE into the displayed track title, otherwise it makes no sense. In the second case we do not want to do this.
This PR demonstrates what I mean, in the playlist display. I have lower-cased and stripped non-alphanumeric characters out of the test, so that it's not thrown off course by minor typo differences (I do something similar in the Qobuz plugin).
Whatever change is made there will also need to apply to the browse listing, now playing and the central column of the (i) information (MAI?) display.
Thanks,
Darrell

I've now updated master for this - queue, now-playing, and browse. Can you please confirm (seems to work for me), and close this pull request if so.
Also, can you check if the other issues you opened are in fact fixed.

Yes it's fine - thanks.


Json assert name

see commit messages.
had to manually add code for all plugins and 1 dsl file, not sure what to do about it.

super old. closing.


Docs: Add example to use PydanticFactory with SQLAlchemy persistence

Summary
Hi,
I use FastAPI with a 'typical' structure: Pydantic schemas are converted to SQLAlchemy models.
For tests, currently, SQLAlchemy models are created in fixtures. Obviously, as the amount of models and validations grows, this doesn't scale. Therefore, I will use per-test objects created by factories.
polyfactory looks ideal, but one thing is missing: I would like to pass a Pydantic schema (PydanticFactory), then convert it to an SQLAlchemy model and create it, using a custom (CRUD layer) implementation.
Reason: Pydantic schemas validate business logic that should not be violated in tests (which happens by creating SQLAlchemy models with only data validation).
This looks relatively easy to implement by passing a custom handler to __sync_persistence__ on a factory (https://polyfactory.litestar.dev/latest/usage/configuration.html#persistence-handlers). (Still need to figure out how to subclass my factories from a base class so I don't have to repeat that...)
Instead of writing the implementation myself, would the maintainers be interested in adding a first-party supported example to the documentation? I could imagine this use case is quite common, as this is relevant for basically all larger FastAPI/Pydantic/SQLAlchemy projects.

[!NOTE]
While we are open for sponsoring on GitHub Sponsors and
OpenCollective, we also utilize Polar.sh to engage in pledge-based sponsorship.
Check out all issues funded or available for funding on our Polar.sh dashboard

If you would like to see an issue prioritized, make a pledge towards it!
We receive the pledge once the issue is completed & verified
This, along with engagement in the community, helps us know which features are a priority to our users.

If my understanding is correct, you want a way to convert pydantic models into sqla models? Could you show an example of what it is that you're trying to achieve?

If my understanding is correct, you want a way to convert pydantic models into sqla models? Could you show an example of what it is that you're trying to achieve?

I would like to use PydanticFactory, then save the corresponding SQLAlchemy model to the database. According to the documentation, this can be achieved by adding a persistence handler to PydanticFactory. I would then convert and save in the save method.

Aah gotcha. And how is that translation from pydantic model to SQL model happening?

Aah gotcha. And how is that translation from pydantic model to SQL model happening?

For SQLAlchemy to Pydantic: https://docs.pydantic.dev/latest/concepts/models/#arbitrary-class-instances
The other way around:
from pydantic import BaseModel, ConfigDict

from sqlalchemy import create_engine
from sqlalchemy.orm import Mapped, mapped_column
from sqlalchemy import Integer
from sqlalchemy.orm import declarative_base, sessionmaker

engine = create_engine("mysql+pymysql://username:password@host/database")
database_session = sessionmaker(bind=engine)()

Base = declarative_base()

class TableOrm(Base):
    __tablename__ = "table"

    id: Mapped[int] = mapped_column(Integer, primary_key=True)

class TablePydantic(BaseModel):
    model_config = ConfigDict(from_attributes=True)

    id: int

db_obj = TableOrm(**TablePydantic(id=1).model_dump(mode="json"))

database_session.add(db_obj)
database_session.commit()
database_session.refresh(db_obj)

Hm...I'm not a 100% sure on whether we should add this to the documentation. That being said, I do see the benefit of this and agree that it may be a relatively common use case (especially for those using FastAPI like you said). So I'm kind of 50/50 on this. Anyone have any opinions on this, @litestar-org/members?


is it valid for External users using Power Apps Portal?

is it valid for External users using Power Apps Portal?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: a8601a9f-ca1e-49e0-bdf8-383431829997
Version Independent ID: 488d4db7-a2de-b47e-5c1c-a28a5f8e046f
Content: Xrm.WebApi (Client API reference) in model-driven apps - Power Apps
Content Source: powerapps-docs/developer/model-driven-apps/clientapi/reference/xrm-webapi.md
Service: powerapps
GitHub Login: @KumarVivek
Microsoft Alias: kvivek

@aarohbits See the Portal Web API to know more about what you can achieve using the web API. Closing the issue.


Error with chat templates

I'm trying to use chat templates with swift-transformers, but I keep getting the runtime error Unknown left value type: Optional<RuntimeValue>, right value type: String, when I call applyChatTemplate. This is the node that is causing the error:
BinaryExpression(
  operation: Jinja.Token(
    value: "==",
    type: Jinja.TokenType.comparisonBinaryOperator
  ),
  left: Jinja.MemberExpression(
    object: Jinja.MemberExpression(
      object: Jinja.Identifier(value: "messages"),
      property: Jinja.NumericLiteral(value: 0),
      computed: true
    ),
    property: Jinja.StringLiteral(value: "role"),
    computed: true
  ),
  right: Jinja.StringLiteral(value: "system")
)

Sorry, this was due to my own mistake in formatting the chat messages.


Add SK locale

Adding complete slovak locale.

@modreoci I just realized you need to add entry in this file too: https://github.com/comfy/comfortable-mexican-sofa/blob/master/lib/comfortable_mexican_sofa/configuration.rb#L96


Movies not loading/not showing.

So, what I've done is "plugin-itised" the LoadingScreen widget, but it doesn't seem to show movies though I have it pointing to the movie I want to play(Which is the UE4 Logo) and I see a black screen, and that's it. Any thoughts?

Solved: Must be used in 720p, doesn't matter the framerate though.


kingstvis: init at 3.6.1

Description of changes
Kingstvis is a GUI for kingst logic analyzers (http://www.qdkingst.com/)
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Removed punctuation from meta.description.
And squashed the commits into a single one.


Add (kind of) unit tests

It's easy to run automated tests thanks to Github actions. Using Postgres as a service in test workflow is easy too (I used it recently here: https://github.com/SocialGouv/mano/blob/main/.github/workflows/end-to-end-tests.yaml#L14-L23).
Since this lib is used by various projects, we should add some tests in order to not break things when we release new features.

Fixed via https://github.com/rap2hpoutre/pg-anonymizer/pull/42 thanks to @jackall3n <3


fix(serde_conv): allow clippy::ptr_arg

This is https://github.com/jonasbb/serde_with/pull/320 again after the allow was removed in f3892d0.
This is the offending code that I have:
serde_with::serde_conv!(
    pub StringAsHtml,
    String,
    |string: &str| html_escape::encode_text(string).into_owned(),
    |html: String| -> Result<_, Infallible> {
        match html_escape::decode_html_entities(&html) {
            Cow::Owned(string) => Ok(string),
            Cow::Borrowed(_) => Ok(html),
        }
    }
);

This results in:
warning: writing `&String` instead of `&str` involves a new object where a slice will do
   --> serde_with/serde_with/src/serde_conv.rs:116:41
    |
107 |   macro_rules! serde_conv {
    |   ----------------------- in this expansion of `serde_with::serde_conv!`
...
116 |                   $vis fn serialize<S>(x: &$t, serializer: S) -> $crate::__private__::Result<S::Ok, S::Error>
    |                                           ^^^
    |
   ::: src/serde.rs:31:1
    |
31  | / serde_with::serde_conv!(
32  | |     pub StringAsHtml,
33  | |     String,
34  | |     |string: &str| html_escape::encode_text(string).into_owned(),
...   |
40  | |     }
41  | | );
    | |_- in this macro invocation
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
    = note: `#[warn(clippy::ptr_arg)]` on by default

I am not sure if there is a way to resolve the issue on my end.
What do you think?

Sorry that it regressed. I added a test in #731 such that it hopefully doesn't regress anymore.


Additional Fields for Ecowitt Sensors WN32 and WH31

Hello,
the log says:
No mapping found for dataelement: wh26batt
No mapping found for dataelement: batt1
I'm ussing two sensors, a WN32 and  WH31.
Could you please add these two dataelement to the adapter.
kind regards
Andy

Sure, I can look at this.

Hello,
I updatet to version 0.10.3. But I still could not see any data points under objects for the new states.
I am missing some thing?
kind regards

Weird... maybe ioB doesn't like to states with the same name. I changed that. Let's try again.

Closed with 0.10.5 (verified on local instance)


[Storage] Remove latest service version from blob as it's not released yet

We had previously added support for the latest service version in main but it's not released yet so Live tests were failing. Removing this from main and will leave in STG82 feature branch.

API change check for azure-storage-blob
API changes are not detected in this pull request for azure-storage-blob


recreate quoteservice-values.yaml for argocd

Their was some problem with argocd . It was unable to find the file quoteservice-values.yaml. so i deleted and recreated it. So that it will reflect on argocd

Code review complete

Done


feat: (EOA) Transaction execution

Feature Request
Describe the Feature Request
The EOAccount currently only validates the transaction in __validate__. We now need to actually call kakarot in the __execute__.
Describe Preferred Solution
At the end of the __execute__ function call the kakarot contract with the calldata previously validated by the __validate__ function.
Related Code
Solving this issue requires to:

add an execute function in the src/kakarot/accounts/eoa/aa/library.cairo library (path may have changed to src/kakarot/accounts/eoa/library.cairo depending on https://github.com/sayajin-labs/kakarot/issues/445
call this function in the corresponding src/kakarot/accounts/eoa/aa/externally_owned_account.cairo contract

You can take inspiration from @Flydexo own repo:

https://github.com/Flydexo/kakarot/blob/ce1c8b8528e6b3423923facb3806e08a90723615/src/kakarot/accounts/eoa/aa/externally_owned_account.cairo#L100
https://github.com/Flydexo/kakarot/blob/ce1c8b8528e6b3423923facb3806e08a90723615/src/kakarot/accounts/eoa/aa/library.cairo#L272

See also other (regular) implementations:

OpenZeppelin
ArgentX

Started work here: https://github.com/Flydexo/kakarot/tree/feat/legacy

Taking over task for TLV Hackathon


[1.19.2] Crash when viewing Every Compat's items

Log file (mclo.gs)
Minecraft 1.19.2 Quilt
EMI 1.0.5
It seems to be Every Compat's items causing the crash, from my testing.

Honestly it's not clear in this log what even is crashing, it seems to be a mod dealing with crash reports crashing when trying to map perhaps another log? Do you have any other examples without stackdeobf?

Sorry, didn't really take a detailed enough look at the log to notice the stackdeobf issue. It seems like a conflict with More Culling, but it happens specifically when looking at Every Compat's items.
Maybe this is a More Culling or Every Compat issue instead?
Log file without stackdeobf (mclo.gs)

Yeah this looks more like a moreculling issue, I don't think it's every compat's fault, gonna close this, feel free to reopen if something new is discovered

Alright! I'll make an issue on More Culling's repo, thanks!


[#100] fix spark sql client insert data failed

After #88 , spark sql client couldn't insert data, The spark configuration in #88 is not enough, should add hive metastore uri if setting spark.sql.hive.metastore.jars to path.  I'm not sure the root cause of problem, there're some thread level session cache in Spark/Hive, this PR optimize the configuration just affect hive_catalog.

@jerqi @danhuawang please help to review,thanks


Allow space supporter to get ssh_enabled app feature and to access apps in the stack

Allow space supporter to get ssh_enabled app feature and to access apps in the stack.
Endpoints:
GET /v3/apps/:guid/ssh_enabled
GET v3/stacks/:guid/apps
Issue #2410

[X] I have reviewed the contributing guide

[X] I have viewed, signed, and submitted the Contributor License Agreement

[X] I have made this pull request to the main branch

[X] I have run all the unit tests using bundle exec rake

[ ] I have run CF Acceptance Tests

Acceptance
Setup
Pushed app dora from cf-acceptance-tests repo as admin.
Behavior check
Running cf curl v3/stacks/:guid/apps as supporter user and developer user returns the same result.
Running cf curl v3/apps/$(cf app dora --guid)/ssh_enabled as supporter user and developer user returns the same result.
Additionally I tested that a stack associated with an app dora2 in a different space would not show dora2's info via
 cf curl v3/stacks/f4492bdc-2e16-43d9-a6f7-fb867035d6d3/apps
{
   "pagination": {
      "total_results": 0,
      "total_pages": 1,
      "first": {
         "href": "https://api.stream-dart.capi.land/v3/stacks/f4492bdc-2e16-43d9-a6f7-fb867035d6d3/apps?page=1&per_page=50"
      },
      "last": {
         "href": "https://api.stream-dart.capi.land/v3/stacks/f4492bdc-2e16-43d9-a6f7-fb867035d6d3/apps?page=1&per_page=50"
      },
      "next": null,
      "previous": null
   },
   "resources": []
}

LGTM!

Made one minor change, we needed to include the new stack endpoint in the docs index so it appears in the sidebar, but otherwise looks good. I'm going to let the checks run but otherwise this should be good to merge in!

D'oh! Thanks for catching that!


[dart2wasm] Miscompilation in async function with optional positional parameter

The setup is a bit convoluted but I couldn't simplify it further.
import 'dart:js_interop';
import 'dart:typed_data';

import 'package:web/helpers.dart';

Future<Uint8List> getBinaryTestProto() =>
    _readfileWeb("test.binarypb");

Future<Uint8List> _readfileWeb(String path) async {
  final response =
      await HttpRequest.request("/" + path, responseType: "arraybuffer");
  ByteBuffer bytes = (response.response as JSArrayBuffer).toDart;
  return Uint8List.fromList(Uint8List.view(bytes));
}

void runBench([Uint8List? data]) async {
  data ??= await getBinaryTestProto();
  print(data);
}

void main() async {
  Uint8List data = await getBinaryTestProto();
  print("File successfully read, contents: $data");
  runBench(data);
}

This needs to be run in a browser with a server serving a file at /test.binarypb, contents of the file does not matter.
It crashes with:
File successfully read, contents: [97, 97, 97, 10]
Uncaught RuntimeError: dereferencing a null pointer
    at runBench inner (test.wasm:0x26b56)
    at runBench (test.wasm:0x24503)
    at main inner (test.wasm:0x2440b)
    at _awaitHelper closure at org-dartlang-sdk:///lib/_internal/wasm/lib/async_patch.dart:82:16 (test.wasm:0x26bde)
    at closure wrapper at org-dartlang-sdk:///lib/_internal/wasm/lib/async_patch.dart:82:16 trampoline (test.wasm:0x26caa)
    at _RootZone.runUnary (test.wasm:0x257a9)
    at _FutureListener.handleValue (test.wasm:0x255d7)
    at _Future._propagateToListeners closure at org-dartlang-sdk:///lib/async/future_impl.dart:836:33 (test.wasm:0x24f07)
    at _Future._propagateToListeners (test.wasm:0x24aec)
    at _Future._completeWithValue (test.wasm:0x260cc)

(The debug print is there to demonstrate that it's not a JS exception not being properly handled, i.e. it's not #54024)
The failing null deref is generated here: https://github.com/dart-lang/sdk/blob/56a86e599e1a1537075f3dbe9b3f8d3cd61971bd/pkg/dart2wasm/lib/async.dart#L796
It's trying to read the async state completer field: https://github.com/dart-lang/sdk/blob/56a86e599e1a1537075f3dbe9b3f8d3cd61971bd/sdk/lib/_internal/wasm/lib/async_patch.dart#L36-L39
However in the generated code for runBench inner we set that field null a few instructions before the deref:
  (func $runBench inner (;891;) (param $var0 (ref $_AsyncSuspendState)) (param $var1 (ref null $#Top)) (param $var2 (ref null $#Top)) (param $var3 (ref null $Object)) (result (ref null $#Top))
    (local $var4 (ref null $<context>))
    (local $var5 i32)
    (local $var6 (ref null $<context>))
    (local $var7 (ref $Object))
    (local $var8 (ref $Object))
    (local $var9 (ref $#Top))
    local.get $var0
    struct.get $_AsyncSuspendState $field4
    local.set $var5
    try
      loop
        block $label1
          block $label0
            block $label2
              local.get $var5
              br_table $label0 $label1 $label2
            end $label2
            unreachable
          end $label0
          local.get $var0
          struct.get $_AsyncSuspendState $field3
          ref.cast null $<context>
          local.set $var4
          struct.new_default $<context>
          local.set $var6
          local.get $var6
          local.get $var4
          struct.get $<context> $field0
          struct.set $<context> $field0
          global.get $global62
          local.set $var7
          local.get $var6
          ref.null none
          struct.set $<context> $field1     ;; <----------- suspendState._completer = null
          local.get $var6
          struct.get $<context> $field1
          ref.as_non_null                   ;; <----------- failing deref of suspendState._completer
          drop
          local.get $var6
          struct.get $<context> $field0
          call $print
          drop
        end $label1
        local.get $var0
        struct.get $_AsyncSuspendState $field5
        ref.as_non_null
        ref.null $#Top
        call $_AsyncCompleter.complete
        return
      end
    catch $tag0
      local.set $var8
      local.set $var9
      local.get $var0
      struct.get $_AsyncSuspendState $field5
      ref.as_non_null
      local.get $var9
      local.get $var8
      call $_Completer.completeError
      return
    end
    unreachable)

When I trace where in the code generator we generate that ref.null that overrides suspendState._completer, it looks like a variable set with a null on the right-hand side, and there's one such statement in this function:
#runBench: runBench
void Function(Uint8List?)
Block({
  Uint8List :async_temporary_0;
  Uint8List :async_temporary_1;
  {
    :async_temporary_1 = null;
  }
  unsafeCast<dynamic>(:async_temporary_1);
  print(data{Uint8List});
})

Since that assignment is overriding the async suspend state, it looks like we're conflating async suspend state and the context of the state, and updating the suspend state instead of the context.

Full kernel of the function before the await transformation: (pkg/dart2wasm/lib/await_transformer.dart)
runBench([dart.typed_data::Uint8List? data = #C1]) → void async /* futureValueType= void */ {
  data == null ?{dart.typed_data::Uint8List} data = await #lib1::getBinaryTestProto() : null;
  dart.core::print(data{dart.typed_data::Uint8List});
}

After:
static method runBench([typ::Uint8List? data = #C1]) → void async /* futureValueType= void */ {
  typ::Uint8List :async_temporary_0;
  typ::Uint8List :async_temporary_1;
  if(data == null) {
    :async_temporary_0 = await test::getBinaryTestProto();
    :async_temporary_1 = data = :async_temporary_0 as{ForLegacy} dynamic;
  }
  else {
    :async_temporary_1 = null;
  }
  :async_temporary_1 as{ForLegacy} dynamic;
  core::print(data{typ::Uint8List});
}

It looks good before the transformation, but I think type of async_temporary_1 is not correct, it looks like it's non-nullable. I wonder if the printer is not printing ?s for nullable vars?

When I print the static type of the expression data == null ?{dart.typed_data::Uint8List} data = await #lib1::getBinaryTestProto() : null; it says non-nullable, even thought the else case returns null:
static type of ConditionalExpression(data == null ?{Uint8List} data = :async_temporary_0 as dynamic : null) : InterfaceType(Uint8List) (nullable: false)

The debug prints:
diff --git a/pkg/dart2wasm/lib/await_transformer.dart b/pkg/dart2wasm/lib/await_transformer.dart
index 3a2c36e4102..d70c3aa50b7 100644
--- a/pkg/dart2wasm/lib/await_transformer.dart
+++ b/pkg/dart2wasm/lib/await_transformer.dart
@@ -8,6 +8,7 @@ import 'package:kernel/ast.dart';
 import 'package:kernel/class_hierarchy.dart';
 import 'package:kernel/core_types.dart';
 import 'package:kernel/type_environment.dart';
+import 'package:kernel/text/ast_to_text.dart';

 /// This pass lifts `await` expressions to the top-level. After the pass, all
 /// `await` expressions will have the form:
@@ -69,6 +70,12 @@ class _AwaitTransformer extends Transformer {

   @override
   TreeNode visitProcedure(Procedure node) {
+    print(node.name);
+    final buffer = StringBuffer();
+    Printer(buffer, showOffsets: false, showMetadata: false)
+        .writeFunction(node.function);
+    print(buffer);
+
     staticTypeContext.enterMember(node);
     final result = node.isAbstract ? node : super.visitProcedure(node);
     staticTypeContext.leaveMember(node);
@@ -1150,6 +1157,7 @@ class _ExpressionTransformer extends Transformer {
     // } else {
     //   t = [right];
     // }
+    print("static type of $expr : ${expr.staticType} (nullable: ${expr.staticType.isPotentiallyNullable})");
     final result = allocateTemporary(nameIndex, expr.staticType);
     final thenBody = blockOf(thenStatements);
     final otherwiseBody = blockOf(otherwiseStatements);

The relevant part of the output:
runBench
([dart.typed_data::Uint8List? data = #C1]) → void async /* futureValueType= void */ {
  data == null ?{dart.typed_data::Uint8List} data = await #lib1::getBinaryTestProto() : null;
  dart.core::print(data{dart.typed_data::Uint8List});
}

static type of ConditionalExpression(data == null ?{Uint8List} data = :async_temporary_0 as dynamic : null) : InterfaceType(Uint8List) (nullable: false)

I wonder if there's a bug in kernel's ConditionalExpressions static type? cc @johnniwinther

The debug print above is after some transformations, but it looks like the type is incorrect before the transformations as well. If I move the debug print to the beginning of that transformer I see this:
static type of ConditionalExpression(data == null ?{Uint8List} data = await getBinaryTestProto() : null) : InterfaceType(Uint8List) (nullable: false)

I just confirmed that the larger app that I extracted the repro from is also fixed.


Made E::G1 and E::G2 generators input to groth16::generate_parameters

I need this change because I'd like to generate ProvingKeys and VerifyingKeys for different circuits while ensuring they all share alpha_g1, beta_g1, gamma_g1, and delta_g1 (and all the _g2 versions too ofc). This is for some aggregate proving technique I'm working on.
A simple non-solution is to just pass an RNG with a known seed to generate_parameters whenever I need this property, but the issue is that g1_generator and g2_generator are not the first elements to be generated from the RNG (t is first), and so if the circuit sizes were different, we would get different generators.
So this is a simple solution for me: pass in the generators explicitly, and then use a real RNG to select t. An alternative solution is to just sample g1_generator and g2_generator at the top of the function instead of later. But that solution may be worse for me, because it would result in identical t values across circuits of the same size (which is bad? I can't tell).
Open to suggestions!

Rebased

The code looks good. Sorry for the delay 👍

I forgot to update the CHANGELOG. Will do it soon.


Clarify the use of plan_fft!

The existing docstring refers to the array A that is used to construct the plan, but that array is irrelevant (other than its eltype and size) when using the plan later.  The old wording made it sound like the A in the constructor itself is used.

bump :)


Improve documentation static check infrastructure

As pointed out by @TWiStErRob kindly in #3928 , we have some defect in our documentation generation infrastructure:

While doing so I noticed that there are bigger issues at hand:

<sample id=" becomes an HTML section which should have a unique ID, but it looks like due to a lot of copy-paste there's roughly 2-3 IDs per file. This means that it's a lot of times impossible to link to a specific paragraph/section/code sample in the userguide, especially on the single page version.
Whatever tool is converting the <sample to HTML is probably using a Map keyed by id+title (solving the first would invalidate this problem).
If these are fixed, any similar regression should fail the build.

Using a slightly modified version of the above commands I found that there are 52 <sample> ids reused 161 times.

We need to improve the static checking mechanism in documentation generation to avoid such issues.
Thanks @TWiStErRob a lot!

Not stale, very likely still valid and needs work.

Can you point towards the code that needs to be changed to fail the build. I think it would be a good start to have a build failure list all the problems and then fix them.

Sorry for the late reply
This is still an issue despite samples being generated slightly differently.
@TWiStErRob if you still like to improve this, you can get the gist of what happening in our docs in this README.

Fixed in https://github.com/gradle/gradle/pull/3928


Unable to show modal dialog

What you are trying to do
I'm trying to show a very simple modal.
What you have already tried
I've the following source of my vue component:
<template lang="pug">
b-button(@click="modalShow = true") open
b-modal(v-model="modalShow") Hello World
</template>

<script>
export default {
  data() {
    return {
      modalShow: false
    }
  }
}
</script>

I can see a button "open" appears, but when I click on the button, nothing happens... no error message nor warning in the console. I also integrated the lines above into my vue component where I need it and there I'm getting the following warnings when I press "open":

I also checked out the documentation on https://cdmoro.github.io/bootstrap-vue-3/components/Modal.html but unfortunately it didn't helped me a lot on this problem. Any ideas what might cause the error?
Environment (please complete the following information):

OS: Windows 11
Version 0.4.14
Node.js: 18.12.1

First try deleting your node_modules folder, and reinstalling. If that doesn't work, please create a sandbox, I don't have much experience with pug and would like to play around with it

I was finally able to solve the issue by myself. I was missing the following line in my vue application (using the legacy installation method atm):
import 'bootstrap-vue-3/dist/bootstrap-vue-3.css'

After adding this line, the modal appears. Thank you @VividLemon for your support!

importing 'bootstrap-vue-next/src/styles/styles.scss' BModal doesn't work

@makroxyz I have imported bootstrap-vue-next/src/styles/styles.scss but the modal is not shown. The body get class modal-open and the modal itself has class modal show. But the .modal CSS class has display: none and there is no CSS that sets the modal to display: block if class show is present on the modal node.


chore: remove proof_wanted in HashMap.Lemmas

It would probably not be a good use of anyone's time to work on that sorry right now, and there was some confusion on Zulip today, so I suggest removing the proof_wanted.

awaiting-review

how about commenting it out and put a note saying why it's not wanted?

@digama0 Done.

Reading this without the request from Mario I would of course ask "what is the point of keeping the comment"?
But it's better than leaving it as is!


How to ignore files?

Hi, it seems that you've built support for ignore, but how do we implement it? Thank you.

click the config button (right next to the push button), you can add ignore pattern there

Thanks!


Fix the build

This project uses semver, please check the scope of this pr:

[ ] #none# - documentation fixes and/or test additions
[X] #patch# - backwards-compatible bug fix
[ ] #minor# - adding functionality in a backwards-compatible manner
[ ] #major# - incompatible API change

CHANGELOG

Fixed build by disable dependency snapshot which is causing build to fail and not publish.
Fixes from: https://github.com/ciena-blueplanet/ember-spread/pull/23
Updated to use latest pr-bumper with support for none
Updated sinon-chai to come from npm instead of bower
Updated chai-query to come from npm instead of bower
Updated ember-cli-code-coverage to version 0.3.5 until resolution of: https://github.com/kategengler/ember-cli-code-coverage/issues/75

Coverage remained the same at 97.674% when pulling 9cf70afcd21db1d48bbe356e83710eeb915fc1b4 on juwara0:fixBuild into 385cf2fa82927ebaca88a9abb1d7c26cb327b3b8 on ciena-blueplanet:master.

👍


⏪ Revert software.amazon.awssdk:apache-client dependency override

Fixes #3366

I can't reproduce those errors locally. As it is AWS2 related, it's maybe related to these changes ?

I can try to reproduce

Discovered unresolved method during parsing: org.apache.commons.logging.impl.LogFactoryImpl.handleThrowable(java.lang.Throwable)
A native build issue, I would expect it to be reproducible.
@zbendhiba Are you building locally with native-image 21.3.0 as CI does ?

Replaced by https://github.com/apache/camel-quarkus/pull/3406


PSCore -Passthru

This does not work in PSCore due to the use of Out-GridView. I wanted to use Microsoft.PowerShell.ConsoleGuiTools but they have removed the -Passthru parameter and made it the default behaviour: https://github.com/PowerShell/GraphicalTools/pull/81
If you replace the -Passthru parameter with -OutputMode Multiple it should work the same and also in PSCore (when using the module).
Indicates that the cmdlet sends items from the interactive window down the pipeline as input to other commands. By default, this cmdlet does not generate any output. This parameter is equivalent to using the Multiple value of the OutputMode parameter.
-Passthru

Thx for the feedback Anders
I will fix that asp
Med venlig hilsen | Best Regards
Morten Waltorp Knudsen
Security & Cloud Architect
+45 40 178 179
+45 88 74 13 53
@.***
www.2linkit.net
Blogmortenknudsen.net
TeamViewer QuickSupport
2LINKIT
Strandvejen 21A
6000Kolding
Denmark

Fra: Anders Spælling @.>
Sendt: Monday, August 14, 2023 9:53:41 PM
Til: KnudsenMorten/AzResourceGraphPS @.>
Cc: Subscribed @.***>
Emne: [EXT] [KnudsenMorten/AzResourceGraphPS] PSCore (Issue #2)
This does not work in PSCore due to the use of Out-GridView. I wanted to use Microsoft.PowerShell.ConsoleGuiToolshttps://github.com/PowerShell/GraphicalTools but they have removed the -Passthru parameter and made it the default behaviour: PowerShell/GraphicalTools#81https://github.com/PowerShell/GraphicalTools/pull/81
If you replace the -Passthru parameter with -OutputMode Multiple it should work the same and also in PSCore (when using the module).
Indicates that the cmdlet sends items from the interactive window down the pipeline as input to other commands. By default, this cmdlet does not generate any output. This parameter is equivalent to using the Multiple value of the OutputMode parameter.
-Passthruhttps://learn.microsoft.com/en-us/powershell/module/microsoft.powershell.utility/out-gridview?view=powershell-7.3#-passthru
—
Reply to this email directly, view it on GitHubhttps://github.com/KnudsenMorten/AzResourceGraphPS/issues/2, or unsubscribehttps://github.com/notifications/unsubscribe-auth/A45OWTXWHAGH6IR7YSO4M63XVJ64LANCNFSM6AAAAAA3QEY5ZU.
You are receiving this because you are subscribed to this thread.Message ID: @.***>


Enable configuring resource type and min_api/max_api in  command group and command

For some resource provider with multiapi in azure cli, e.g. storage, compute, network ..., we will hope we could config resource type for command group and command as below:
    with self.command_group('storage blob lease', blob_lease_client_sdk, resource_type=ResourceType.DATA_STORAGE_BLOB,
                            min_api='2019-02-02',
                            custom_command_type=get_custom_sdk('blob', client_factory=cf_blob_lease_client,
                                                               resource_type=ResourceType.DATA_STORAGE_BLOB)) as g:
        g.storage_custom_command_oauth('acquire', 'acquire_blob_lease')

For some new module to add with multiapi support, we will have the following configuration in init:
class StorageCommandsLoader(AzCommandsLoader):
    def __init__(self, cli_ctx=None):
        from azure.cli.core.commands import CliCommandType
        from azure.cli.core import ModExtensionSuppress
        storage_custom = CliCommandType(operations_tmpl='azure.cli.command_modules.storage.custom#{}')
        super(StorageCommandsLoader, self).__init__(cli_ctx=cli_ctx,
                                                    resource_type=ResourceType.DATA_STORAGE,
                                                    custom_command_type=storage_custom,
                                                    command_group_cls=StorageCommandGroup,

Dup with https://github.com/Azure/autorest.az/issues/583


Proxyrepo auth

fix #101
attention - has to be applied together with changes made to nexus_cli.

Sorry, it looks like this will need to be rebased.

@KAllan357 rebase done.


Fix NSRegularExpression on OS X

Fixes some instances of the stop pointer being rebound in the migration to RawPointer.

@swift-ci please test OS X platform

CI won't catch this.  Nonetheless
@swift-ci please test.

@dduan This will let your patch for corelibs-xctest pass.

cool!

Failure is unrelated.


Use released image for insights-chrome-rebrand

https://github.com/konflux-ci/konflux-ci/blob/main/konflux-ci/ui/core/kustomization.yaml#L11C67-L11C90

obsolete since we are not using the new ui which doesn't require this image - https://github.com/konflux-ci/konflux-ci/pull/815


Should the "site" command monolith be broken up?

Emerging from the discussion on PR #516, an interesting question: should we break up the site command (currently home to some 55 (!!) different operations, into smaller command files?
Here are some of the arguments in favor:

This would allow us to make use of the underlying CLI's framework of command/subcommand much better. Changing site backups get to backups get is much cleaner in terms of how the existing object structure works.
Better autocomplete coverage of actual operations.
Given that this is most of what people do with Terminus, it would eliminate a lot of wasted keystrokes.
Help pages would be more easily digested.
Fewer switch statements.
Break up the biggest individual file in the repo.

But it's a big change. Let's give it a full think-through before we decide one way or the other.

I've started a Google spreadsheet here with how I think the site command ought to be broken down.
https://docs.google.com/a/getpantheon.com/spreadsheets/d/1IEVrRbFY1Ekjs9Is_VF7fRYggRxjX_XB_2jum9jl4Jc/edit?usp=sharing

This proposal has been accepted and is in progress for Terminus 1.0.


Sending account.list to the admin room crashes the bridge if a timeline room doesn't exist

https://github.com/Half-Shot/matrix-appservice-twitter/blob/develop/src/handlers/AccountServices.js#L190 should be checking for null -_-

Looks fixed. Closing.


Use an autoclosure for the rhs of <|>

The nil coalescer operator already uses an autoclosure for the rhs
argument, so it makes sense to follow suit here.
Fixes #289

:+1:

I like this change :+1:


Cannot display with hemi="split"

Hi All,
I am trying to use Pysurfer to display results. However, it display well using hemi="lh" or "rh". However, with hemi="split", it display nothing. Also, with views=['lat','med'], it display nothing. I will be really appreciated if anyone has some suggestions?
When I input comand "from surfer import Brain", it displayed "Qt WebEngine seems to be initialized from a plugin. Please set Qt::AA_ShareOpenGLContexts using QCoreApplication::setAttribute before constructing QGuiApplication.".
Not sure if this is the reason?
Thank you so much.
Best
Zaixu

I'm also getting this exact same error (with version 0.9.0)

Alright, I was able to figure out a fix on MacOS, which I'll post here:

Make sure you have pyqt5>=5.12 installed (which is the most recent as of the time of this writing. I'm guessing >=5.10.2 would be sufficient based on what's mentioned here)

Set up the following environment variables (source):

export ETS_TOOLKIT=qt4
export QT_API=pyqt5

From here I was able to enter an ipython session as normal (running %gui qt) and run brain = Brain('fsaverage', 'split', 'inflated', views=['lat', 'med']) successfully. For reference this works with the following versions:
pysurfer                  0.9.0
mayavi                    4.6.2
vtk                       8.1.2
PyQt5                     5.12
pyqt                      5.9.2

Thanks @danjgale, closing as this is a mayavi/PyQt5 bug

Is it correct that the solution is to define qt4 for one variable and pyqt5 for another? That doesn't seem right...

@mwaskom I wondered that too... It does seem to do the trick, however. I took it from here: https://github.com/enthought/mayavi/issues/595#issue-293719209

Fascinating....


Tests failing because local image references through ARG are failing to resolve

$ docker build --build-arg BASE_IMAGE=micromamba:test-frolvlad-alpine-glibc-alpine-3.18 -f test/cli-invocations.Dockerfile .

[+] Building 0.8s (3/3) FINISHED                                                                                docker:desktop-linux
 => [internal] load build definition from cli-invocations.Dockerfile                                                                                0.0s
 => => transferring dockerfile: 266B                                                                                0.0s
 => ERROR [internal] load metadata for docker.io/library/micromamba:test-frolvlad-alpine-glibc-alpine-3.18                                                                      0.7s
 => [auth] library/micromamba:pull token for registry-1.docker.io                                                                                0.0s
------
 > [internal] load metadata for docker.io/library/micromamba:test-frolvlad-alpine-glibc-alpine-3.18:
------
cli-invocations.Dockerfile:3
--------------------
   1 |     ARG BASE_IMAGE=micromamba:test-debian12-slim
   2 |
   3 | >>> FROM $BASE_IMAGE
   4 |     RUN micromamba install -y -n base -c conda-forge \
   5 |            python=3.12.7  && \
--------------------
ERROR: failed to solve: micromamba:test-frolvlad-alpine-glibc-alpine-3.18: failed to resolve source metadata for docker.io/library/micromamba:test-frolvlad-alpine-glibc-alpine-3.18: pull access denied, repository does not exist or may require authorization: server message: insufficient_scope: authorization failed

View build details: docker-desktop://dashboard/build/desktop-linux/desktop-linux/l8ibzvkupmzupuncuw4uy05cv

But if I directly reference the image name on the FROM line (without using the ARG) then it works.
Might be related to this: https://www.reddit.com/r/docker/comments/1fhkela/referring_to_a_local_image_in_a_build_stage_fails/

The above diagnosis was completely wrong. The fix was in #570


Creating MacOS bundle throws error

Hi, I'm trying to create a MacOS bundle with this action but this error is thrown every time I execute the action:
  Error: dyld[4097]: Library not loaded: /usr/local/opt/gettext/lib/libintl.8.dylib
    Referenced from: <09857011-94D0-3FBA-9F9D-9FCE0E7366FF> /Users/
  Error: runner/hostedtoolcache/Python/3.10.14/x64/bin/python3.10
    Reason: tried: '/usr/local/opt/gettext/lib/libintl.8.dylib' (no such file), '/System/Volumes/Preboot/Cryptexes/OS/usr/local/opt/gettext/lib/libintl.8.dylib' (no such file), '/usr/local/opt/gettext/lib/libintl.8.dylib' (no such file), '/usr/local/lib/libintl.8.dylib' (no such file), '/usr/lib/libintl.8.dylib' (no such file, not in dyld cache)
  ./setup.sh: line 53:  4097 Abort trap: 6           ./python -m ensurepip
  Error: The process '/bin/bash' failed with exit code 134

Looking online I found that it might be the lib "gettext" missing and I also tried installing it at execution but nothing better comes out.
This is my workflow file:

on: push

jobs:
  build:
    strategy:
      matrix:
        os: [macos-latest] #, ubuntu-latest, windows-latest]

    runs-on: ${{ matrix.os }}

    steps:
      - name: Check-out repository
        uses: actions/checkout@v3

      - name: Setup Python
        uses: actions/setup-python@v4
        with:
          python-version: '3.10' # Version range or exact version of a Python version to use, using SemVer's version range syntax
          architecture: 'x64' # optional x64 or x86. Defaults to x64 if not specified            build/*.exe
          cache: 'pip'
          cache-dependency-path: |
            **/requirements*.txt

      - name: Install Dependencies
        run: |
          pip install -r requirements.txt

      - name: Build Executable
        uses: Nuitka/Nuitka-Action@main
        with:
          nuitka-version: main
          script-name: autocropper.py
          onefile: true
          macos-create-app-bundle: true

      - name: Upload Artifacts
        uses: actions/upload-artifact@v3
        with:
          name: ${{ runner.os }} Build
          path: |
            build/*.bin
            build/*.app/**/*```

The error is very incomplete. Probably you fail to run the Python you are trying to setup, would not be our business.

The error is very incomplete. Probably you fail to run the Python you are trying to setup, would not be our business.

But it work when I omit macos-create-app-bundle: true

Without a reproducer, there is nothing I can do here, the action works. If you think you have a Nuitka bug, report it in its repo and make sure to include the necessary information.


First try at updating "Subscribing to a Database" docs

Mainly just a syntax update, changing `register-sub' and adding a bit of explanation to a couple areas.
I think it needs more work, but this will at least give us a base to discuss.
Questions:

Can you check out the explanation for why we are using reg-sub-raw and see if it's accurate? Should we be using 'reg-sub-raw' there?
What needs to be done to update the undo-redo information? Is there a new link?
Is there anything we should add in terms of effectful handlers or that is specific to the http-fx library as in https://github.com/Day8/re-frame/blob/master/docs/Talking-To-Servers.md ?

@smahood I merge this and do a bit of massage.  Thanks!


Fix HeaderLen test

acm.HeaderLen must be a multiple of 4, not 64, see Software development guide, "Appendix A Intel ® TXT Execution Technology Authenticated Code Modules".

acm.HeaderLen is in units of 4 bytes. The "User Area" is modulo 64 bytes, but it's unclrear how to retrive the User Area Len.

acm.Header.Size - acm.Header.HeaderLen - acm.Header.ScatchSize = "User Area"?

Right now, we're 16byte off. Either we read to much, the ACM is not aligned correctly or the ACM ist just larger than 128kb. Need to dive into that.


Support reading from phoenix in nebula exchange

The nebula exchange can import data from hive or others, but no phoenix. So is there a plan to  carry this out?

The nebula exchange can import data from hive or others, but no phoenix. So is there a plan to carry this out?

please use spark connector to read from phoenix and write to nebula. Refer https://github.com/vesoft-inc/nebula-spark-connector/blob/master/example/src/main/scala/com/vesoft/nebula/examples/connector/NebulaSparkWriterExample.scala


docs(timesensitive): clarify takeActionEndDate

I got confused about how to configure takeActionEndDate such that MyUW Benefit Information widget prematurely told employees today was last day to enroll, whereas tomorrow is actual last day to enroll. Updating documentation with clarity that might have supported my correctly configuring the widget.

PR considerations checklist:

[x] Updates CHANGELOG.md to reflect this PR's change.
[x] This Contribution is under the terms of Individual Contributor License Agreements (and also Corporate Contributor License Agreements to the extent applicable) appearing in the Apereo CLA roster.

Tracked as MUMUP-3420 locally to MyUW.

Credit to @davidmsibley for f2f feedback that he'd have written 00:00, which feedback inspired 2712a6e, which I think made this a substantially better improvement to the docs.


[BigString] Fix accidentally quadratic BigString.init

When ingesting a String instance, BigString assumes that the input string has a reasonably efficient UTF-8 view.
Unfortunately, that is very much not the case when the input happens to be backed by a bridged NSString object — it appears that in this case, the ingester loop invokes some operation(s) with linear complexity in the size of the entire input, rendering the ingester’s overall complexity quadratic.
The BigString ingester is only expected to operate within a single chunk at the time. It’s unclear precisely which operation triggers the quadratic behavior; ideally we should figure it out and resolve it with a more targeted fix.
In the meantime, a blunt stopgap fix is to force-transcode the input string to UTF-8 at the time the ingester is initialized. This unnecessarily wastes some (temporary) memory on holding the transcoded string, but it avoids the quadratic cliff.
Before:

After:

rdar://131176282
Checklist

[X] I've read the Contribution Guidelines
[X] My contributions are licensed under the Swift license.
[X] I've followed the coding style of the rest of the project.
[ ] I've added tests covering all new code paths my change adds to the project (if appropriate).
[X] I've added benchmarks covering new functionality (if appropriate).
[X] I've verified that my change does not break any existing tests or introduce unexplained benchmark regressions.
[ ] I've updated the documentation if necessary.

@swift-ci test


Fix for groovy.lang.MissingPropertyException

Fixes #624

Looks good.  Will merge when travis passes.

Any chance that this could be merged, please? It fixes the issue that I am having.


chore: delete vite-plugin-mkcert

vite-plugin-mkcer prevented the project from starting

https://github.com/element-plus/element-plus-playground/issues/260

You don't need to delete the plugin. The problem you mentioned in #260 is the node’s warning message about importing JSON.

It has nothing to do with the warning. This plug-in is blocking the startup.

This plugin does not prevent the project from starting, it just adds https.


new docs for lab equipment

removed the need for password
config file for mgmt server

dhcp config
nftables config

updates to arista switch config file

1 test passes 2 fail.
login works
================================================================== short test summary info ==================================================================
FAILED demos/tgen/test_tgen_demo.py::test_server_to_dpuhost_via_dpu - Exception: code: 500
FAILED demos/tgen/test_tgen_demo.py::test_dpuhost_to_dpuhost_via_dpu - requests.exceptions.ConnectionError: HTTPSConnectionPool(host='<IP_ADDRESS>', port=8443): Max retries exceeded with url: /config (Caused by NewConnectionE...
=============================================================== 2 failed, 1 passed in 28.58s ================================================================
opi@tgen1:~/opi-poc$

DCO  fails, please use -s flag in the git commit -s

created many smaller  PRs

https://github.com/opiproject/opi-poc/pull/958
https://github.com/opiproject/opi-poc/pull/959
https://github.com/opiproject/opi-poc/pull/960
https://github.com/opiproject/opi-poc/pull/961
https://github.com/opiproject/opi-poc/pull/962
https://github.com/opiproject/opi-poc/pull/963
https://github.com/opiproject/opi-poc/pull/964


Disable wordexp for Android

Android does not have wordexp. I just tested tinygltf with this fix on Android and it does work.

Thanks!


[RFE] Harden Inspektor Gadget with Landlock

Current situation
Inspektor Gadget uses several hardening mechanism but not Landlock.
Particularly, the container image is set read-only, but this is not forcefully the case of mounted paths.
Impact
Landlock could be used to restrict which path can be read and write.
It could be used to workaround this limitation:
https://github.com/inspektor-gadget/inspektor-gadget/blob/49a2adc716f48591a220b11f9fe78ee22e002022/charts/gadget/templates/daemonset.yaml#L184-L194
Ideal future situation
Landlock is used to restrict which path Inspektor Gadget can read and write.
Implementation options
An initial attempt was done in https://github.com/inspektor-gadget/inspektor-gadget/commit/21e23e702cc54a8eb872ba5fcf95b07a70a143ad.
Sadly, using Landlock makes the call to os.Stat(/host/proc/1/ns/pid) fails with EPERM being returned:
(gdb) s
domain_scope_le (child=0x0 <fixed_percpu_data>, parent=0xffff888005cd73c0) at security/landlock/task.c:37
37              if (!parent)
(gdb) n
39              if (!child)
(gdb) p !child
$27 = 1
(gdb) bt
#0  domain_scope_le (child=0x0 <fixed_percpu_data>, parent=0xffff888005cd73c0) at security/landlock/task.c:39
#1  task_is_scoped (child=0xffff8880041c0000, parent=0xffff888007ad49c0) at security/landlock/task.c:59
#2  task_ptrace (child=0xffff8880041c0000, parent=0xffff888007ad49c0) at security/landlock/task.c:70
#3  task_ptrace (parent=0xffff888007ad49c0, child=0xffff8880041c0000) at security/landlock/task.c:64
#4  0xffffffff814febf7 in security_ptrace_access_check (child=child@entry=0xffff8880041c0000, mode=mode@entry=9) at security/security.c:956
#5  0xffffffff8109f2bf in __ptrace_may_access (task=task@entry=0xffff8880041c0000, mode=mode@entry=9) at kernel/ptrace.c:346
#6  0xffffffff8109f959 in ptrace_may_access (task=task@entry=0xffff8880041c0000, mode=mode@entry=9) at kernel/ptrace.c:353
#7  0xffffffff813b5864 in proc_ns_get_link (dentry=<optimized out>, inode=<optimized out>, done=<optimized out>) at fs/proc/namespaces.c:58
#8  0xffffffff8132c351 in pick_link (flags=<optimized out>, inode=0xffff888006ff02f0, link=0xffffc90000747c58, nd=0xffffc90000747ce0) at fs/namei.c:1806
#9  step_into (nd=0xffffc90000747ce0, flags=<optimized out>, dentry=<optimized out>) at fs/namei.c:1874
#10 0xffffffff8132d4c9 in lookup_last (nd=<optimized out>) at fs/namei.c:2461
#11 path_lookupat (nd=nd@entry=0xffffc90000747ce0, flags=flags@entry=65, path=path@entry=0xffffc90000747e08) at fs/namei.c:2485
#12 0xffffffff8132ea7c in filename_lookup (dfd=dfd@entry=-100, name=name@entry=0xffff88801296d000, flags=flags@entry=1, path=path@entry=0xffffc90000747e08, root=root@entry=0x0 <fixed_percpu_data>) at fs/namei.c:2514
#13 0xffffffff813208c4 in vfs_statx (dfd=dfd@entry=-100, filename=filename@entry=0xffff88801296d000, flags=flags@entry=2048, stat=stat@entry=0xffffc90000747e88, request_mask=request_mask@entry=2047) at fs/stat.c:244
#14 0xffffffff8132107d in vfs_fstatat (dfd=-100, filename=<optimized out>, stat=0xffffc90000747e88, flags=<optimized out>) at fs/stat.c:304
#15 0xffffffff813210d6 in __do_sys_newfstatat (dfd=<optimized out>, filename=<optimized out>, statbuf=0x7ffecc114380, flag=<optimized out>) at fs/stat.c:468
#16 0xffffffff81f87268 in do_syscall_x64 (nr=<optimized out>, regs=0xffffc90000747f58) at arch/x86/entry/common.c:52
#17 do_syscall_64 (regs=0xffffc90000747f58, nr=<optimized out>) at arch/x86/entry/common.c:83
#18 0xffffffff82000130 in entry_SYSCALL_64 () at arch/x86/entry/entry_64.S:121
#19 0x00007f0ce74d9020 in ?? ()
#20 0x00005644d5bf4da0 in ?? ()
#21 0x00007ffecc114548 in ?? ()
#22 0x0000000000000000 in ?? ()

Indeed, Landlock does not permit a Landlock'ed process, i.e. Inspektor Gadget, to trace a no Landlock'ed process, i.e. host PID 1 aka systemd.
There are two possible solutions:

Change Inspektor Gadget architecture to have two processes: one is not Landlock'ed and handles the "privileged" operations, the other is Landlock'ed and handles the current operations.
Add Landlock'ing later on in the code where no more "privileged" operations are run.

Trying to be a little creative, I'm wondering if we can achieve something similar by building a BPF LSM gadget that blocks which paths a program can read and write from and load as part of the initialization of IG.
This is a gadget I'd like to see anyhow, so maybe we could leverage it.


.NET process filtering is too restrictive

Currently, any process that is not named dotnet is filtered out:
https://github.com/Azure/vscode-kubernetes-tools/blob/268260093d0bd3265d981fb571261d3c4818c436/src/debug/dotNetDebugProvider.ts#L81-L84
Since .NET 3.1 (released 2 years back), .NET applications come with a native executable that launches the app. These apphost are not named dotnet.
$ dotnet new web -o web
$ cd web
$ dotnet build
$ bin/Debug/net6.0/web
info: Microsoft.Hosting.Lifetime[14]
      Now listening on: http://localhost:5000
info: Microsoft.Hosting.Lifetime[14]
      Now listening on: https://localhost:5001
info: Microsoft.Hosting.Lifetime[0]
      Application started. Press Ctrl+C to shut down.
info: Microsoft.Hosting.Lifetime[0]
      Hosting environment: Production
info: Microsoft.Hosting.Lifetime[0]
      Content root path: /tmp/web

A way of filtering .NET apps is to look at the /tmp/dotnet-diagnostic-<pid>-*-socket files.
$ pidof web
16873
$ ls /tmp/dotnet-diagnostic-$(pidof web)-*-socket
/tmp/dotnet-diagnostic-16873-1204654-socket

Alternatively, the filtering could be left out, since there are not that many processes expected to be running in a container anyhow.

cc @itowlson

Hmm, I'm not too familiar with the .NET debugging component.  @tedchamb you were the original author of this feature - are you able to take a look please?

@pantosha Sorry to pester you, but the original author of this code isn't responding right now, and I know you have some knowledge of this area.  Would you be able to take a look at this issue too?  Thanks ever so much!

@itowlson,  I will take a look

A way of filtering .NET apps is to look at the /tmp/dotnet-diagnostic--*-socket files.

@pantosha this is a good way to filter .NET apps. Though it has some complexity to it. Alternatives are to do no filtering, or another alternative would be to allow specifying the process name with a setting (which defaults to dotnet).

@pantosha are you still looking into the issue?
@itowlson the simplest fix may be to allow specifying the process name, and default to dotnet to match the current behavior.

@tmds yeah. I reviewed current implementation. I didn't find a way to use socket files without deeply rewriting not only .net debugger, but also debuggers for other languages.
I will prepare PR that removes restrictions within a week.


[P2] Configure configure job publish pypi for Open Data Hub

Transferring this issue to TGI's forked repo in ODH


Upgrade Failure in workers

Hello,
We are upgrading from Kismatic 1.6.1, Kubernetes 1.8.2 to Kismatic 1.9.1 with Kubernetes 1.9.4.
It made it through the upgrade of the master and etcd nodes with no problem, but in the first node, it throws this error:
- Task: fail if the node was not drained
  node.fqdn.com: Attempted to drain the node, but 'kubectl drain' returned an error:

"Error from server (Forbidden): nodes "node.fqdn.com" is forbidden: User "system:anonymous" cannot get nodes at the cluster scope"

I was able to drain the node myself with no problem by running the same command on the kismatic host. Not sure why it's using system:anonymous to try and drain.

Just took a look at generated/kubeconfig and compared it to the .kube/config I'm running with, and token is present in the new one. Going to try and remove that during the run to see how that works.

Just realized that error is coming from the worker nodes, duh. I can see that I can't run it from kubectl on the nodes themselves either, it has the same error.

OK, so the drain is failing because the new version generated new certificates and kubeconfig for workers, but it doesn't put them in place before it tries to do the drain.
I worked around this issue by redoing the ordering of the upgrade_nodes.yaml file like so:
  - include: _packages-repo.yaml
    when: allow_package_installation|bool == true

  - include: _certs.yaml upgrading=true
  - include: _certs-etcd.yaml upgrading=true

  - include: _kubeconfig.yaml upgrading=true

  - include: _kube-drain-node.yaml

OK, further issue I think is that I removed the password: field from my config file. I believe this got rid of ABAC. The 2 workers that got upgraded before I cancelled have pods that won't start up now because of RBAC issues. How can I get ABAC back and running on my api server?

To get around this, I added the password field back to my config, decremented my /etc/kismatic-version to 1.9.0 on my masters, and ran the upgrade process again.

I would recommend upgrading one minor version at a time as that is what we test. since you now have a v1.9 cluster with all the services upgraded to use RBAC you can remove the password in the next upgrade.


Documentation issue with @LoadBalanced WebClient

Describe the bug
Current version of documentation(https://docs.spring.io/spring-cloud-commons/docs/3.0.0-SNAPSHOT/reference/html) clearly states about using @LoadBalanced WebClient:
@Configuration
public class MyConfiguration {

    @Bean
    @LoadBalanced
    public WebClient.Builder loadBalancedWebClientBuilder() {
        return WebClient.builder();
    }
}

public class MyClass {
    @Autowired
    private WebClient.Builder webClientBuilder;

    public Mono<String> doOtherStuff() {
        return webClientBuilder.build().get().uri("http://stores/stores")
                        .retrieve().bodyToMono(String.class);
    }
}

However this code will not work if DiscoveryClientServiceInstanceListSupplier service supplier is used. Because it requires loadbalancer.client.name property initialized. I couldn't find any mentions about this property in the documentation.
Another thing is that creating new WebClient instance per request is quite expensive.  It's possible to declare a WebClient bean explicitly:
    @Bean
    public WebClient webClient(ReactorLoadBalancerExchangeFilterFunction loadBalancerExchangeFilterFunction) {
        return WebClient.builder()
                .filter(loadBalancerExchangeFilterFunction)
                .build();
    }

And it'd be nice to mention this use-case in the documentation as well.

The configuration does work out of the box with the LB starter. You can see this working sample as a reference. Also, the other setup is shown here.

The configuration does work out of the box with the LB starter. You can see this working sample as a reference. Also, the other setup is shown here.

The configuration does work out of the box with the LB starter. You can see this working sample as a reference. Also, the other setup is shown here.

Hi @OlgaMaciaszek
Thank you for the answer but the provided working sample is about RestTemplate and my question was about WebClient.
Regarding the proposed setup chapter  - that's fine. But again the code in the chapter will create new WebClient instance per HTTP request. This might be resource consuming so creating WebClient bean will be more efficient solution.

The configuration does work out of the box with the LB starter. You can see this working sample as a reference. Also, the other setup is shown here.

Hi @OlgaMaciaszek
Thank you for the answer but the provided working sample is about RestTemplate and my question was about WebClient.
Regarding the proposed setup chapter  - that's fine. But again the code in the chapter will create new WebClient instance per HTTP request. This might be resource consuming so creating WebClient bean will be more efficient solution.

@sergey-morenets feel free to provide a PR with the suggested documentation change and we will review it.

@sergey-morenets feel free to provide a PR with the suggested documentation change and we will review it.

If you would like us to look at this issue, please provide the requested information. If the information is not provided within the next 7 days this issue will be closed.

If you would like us to look at this issue, please provide the requested information. If the information is not provided within the next 7 days this issue will be closed.

Closing due to lack of requested feedback. If you would like us to look at this issue, please provide the requested information and we will re-open the issue.


Move Checkbox:Display speed limits mph from SpeedLimits.csv to Options.csv

Due to way CheckboxOption.AddUI() works, it can only pull localisation strings from Options.csv (which is fine).
However, Checkbox:Display speed limits mph locale string is currently residing in SpeedLimits.csv.

either we should decide to put all translations in options.csv or allow to modify translation delegate. either way its easy fix. changing translations can be annoying though!

@kianzarrin I've just noticed the mod checker has it's own translation file (Translation.ModConflicts ie. contents of ModConflicts.csv). So yeah, would be useful to be able to define which translation file we're dealing with (should default to Translation.Options as that's what most things currently use).
I was unsure of how best to reference a list - eg. if I just pass in the list and store that, what happens on hotload? Should it use nameof(Translation.Whatever) and then use GetField() to grab it as necessary? If you know of a good way to do that send a PR or just dump code in comment below. I'm currently working on updating all the checkboxes in General options to use CheckboxOption.

@kianzarrin I've just noticed the mod checker has it's own translation file (Translation.ModConflicts ie. contents of ModConflicts.csv). So yeah, would be useful to be able to define which translation file we're dealing with (should default to Translation.Options as that's what most things currently use).
I was unsure of how best to reference a list - eg. if I just pass in the list and store that, what happens on hotload? Should it use nameof(Translation.Whatever) and then use GetField() to grab it as necessary? If you know of a good way to do that send a PR or just dump code in comment below. I'm currently working on updating all the checkboxes in General options to use CheckboxOption.

For translations override we can pass delegate

Good call - works like a charm!