[FEAT] Improve module formattion

Instead of the meaningless {6}{7}{8}, {user-name-colored}{at-symbol-colored}{host-name-colored} should be supported

I totally agree the numbers are confusing, how are we supposed to know what each one means

$ fastfetch -h title-format
--title-format:
Sets the format string for Title output.
To see how a format string is constructed, take a look at "fastfetch --help format".
The following values are passed:
        {1}: User name
        {2}: Host name
        {3}: Home directory
        {4}: Executable path of current process
        {5}: User's default shell
        {6}: User name (colored)
        {7}: @ symbol (colored)
        {8}: Host name (colored)
The default is something similar to "{6}{7}{8}".


vscode/settings.json markdown added

Issue number 6354 resolved feedback required if any further changes are to be done.

@aadityaforwork you need to sign the Plone Contributor Agreement to merge this pull request.
Learn about the Plone Contributor Agreement: https://plone.org/foundation/contributors-agreement

@aadityaforwork you need to sign the Plone Contributor Agreement to merge this pull request.
Learn about the Plone Contributor Agreement: https://plone.org/foundation/contributors-agreement

@aadityaforwork please read and follow First-time contributors, Contributing to Plone, and Contributing to Volto.

@davisagli I noticed that Plone packages with plone/meta have this thingie called .editorconfig. Should this setting go in that file or .meta.toml?
I was about to port this to plone.api and plone.restapi, and this gave me pause.

@stevepiercy I don't see an .editorconfig setting available for requesting that autoformatting be entirely disabled.

@aadityaforwork Your PR still includes files that should not be here. I would expect changes only to vscodesettings.js, plus the file in packages/volto/news.

Hello @davisagli I have addressed the changes you asked if anything further is to be done please let me know!


On resave, field data is cleared

I have a custom post type that uses an  ACF MapMore field that I'm experiencing issues with. When a post has an ACF MapMore field with a value already set, this value is cleared/removed upon resave. After saving I have to go back and reinput the location, which can be quite time consuming if it's using a polygon.

So removing the json_encode from the hidden input in acf-mapmore-v5.php seems to have fixed the issue. Not sure if this would have a knockon effect on anything else but thought I'd mention!

@olivianicholls thank you very much for your input, i will hopefully get to test your solution and fix it on this repo as well

Hy, i try to remove json_encode from hidden input, but i have same issue, and in frontend no loading any polygon :( who know how to fixit ?

For frontend i do in thie mode:
$perimetru_cvatral = get_field('perimetru_cvatral');
<?php if(!EMPTY($perimetru_cvatral)) { ?>

<?php
switch ( $perimetru_cvatral['type'] ) {
	case 'rectangle':
	?>

	<?php
	break;

  	case 'polyline':
	?>

  	<?php
  	break;

  	case 'polygon':
	?>

  	<?php
  	break;

  	case 'circle':
	?>

  	<?php
  	break;

  	case 'marker':
	?>

  	<?php
  	break;

}
?>

				<?php } ?>

But maps not show, see screenshot :

@ezramod
I've fixed some issues in the plugin's code and also changed the API to get values from the field. Please update your plugin to current status of this repository's master branch.
Based on that and your code, it could work something like this:
<?php

// Get current map key
$key = '';
$keys = acf_get_setting('mapmore_google_api_key');
if (isset($keys[0])) {
    $key = $keys[0];
}

if (!empty($perimetru_cvatral)) { ?>

<?php switch ($perimetru_cvatral['type']) { case 'rectangle': ?>

    <?php break;case 'polyline': ?>

    <?php break;case 'polygon': ?>

    <?php break;case 'circle': ?>

    <?php break;case 'marker': ?>

    <?php break;} ?>

<?php }

after update appear this:
Fatal error: Uncaught Error: Class 'AcfFieldTypeMapMore\AcfPluginMapMore' not found in /home/propertyindex/public_html/wp-content/plugins/acf-field-type-mapmore/acf-field-type-mapmore.php:23 Stack trace: #0 /home/propertyindex/public_html/wp-includes/class-wp-hook.php(307): acf_field_type_mapmore('') #1 /home/propertyindex/public_html/wp-includes/class-wp-hook.php(331): WP_Hook->apply_filters(NULL, Array) #2 /home/propertyindex/public_html/wp-includes/plugin.php(476): WP_Hook->do_action(Array) #3 /home/propertyindex/public_html/wp-settings.php(598): do_action('init') #4 /home/propertyindex/public_html/wp-config.php(99): require_once('/home/propertyi...') #5 /home/propertyindex/public_html/wp-load.php(50): require_once('/home/propertyi...') #6 /home/propertyindex/public_html/wp-admin/admin.php(34): require_once('/home/propertyi...') #7 /home/propertyindex/public_html/wp-admin/plugins.php(10): require_once('/home/propertyi...') #8 {main} thrown in /home/propertyindex/public_html/wp-content/plugins/acf-field-type-mapmore/acf-field-type-mapmore.php on line 23
On Thursday, September 1, 2022 at 08:07:15 PM GMT+3, rozklad<EMAIL_ADDRESS>wrote:

@ezramod
I've fixed some issues in the plugin's code and also changed the API to get values from the field. Please update your plugin to current status of this repository's master branch.
Based on that and your code, it could work something like this:

@ezramod Sorry for inconvenience. The new update relied on composer autoloads. Please update the plugin once more, the issue is fixed now.

fix bug, with plugin but map not show on front end i try to understnad where is bug and i do this:

and value for center_lat and center_lng not work on frontend user.
can u help me? i try to create polygon

Fot a good work i do in this mode:

// Get current map key
$key = '';
$keys = acf_get_setting('mapmore_google_api_key');
if (isset($keys[0])) {
    $key = $keys[0];
}

if (!empty($perimetru_cvatral)) { ?>

but maps selection is delete if update post without click on maps, if you do change on map and update post, settings is not deleted.


vtable for BLESecurityCallbacks - Including workaround

Using example: SampleClient_authentication_numeric_confirmation.cpp
With: ESP-IDF and arduino-esp32
Creating exeption:
/home/osboxes/esp/test/m5_windsensor/build/main/libmain.a(main.o):(.literal._ZN10MySecurityD5Ev[MySecurity::~MySecurity()]+0x0): undefined reference to `vtable for BLESecurityCallbacks'
collect2: error: ld returned 1 exit status
/home/osboxes/esp/esp-idf/make/project.mk:410: recipe for target '/home/osboxes/esp/test/m5_windsensor/build/app-template.elf' failed
make: *** [/home/osboxes/esp/test/m5_windsensor/build/app-template.elf] Error 1
Also, there is an issue with the Task.h, that is not included in arduino-esp32
My workaround:

include cpp_utils in components
delete BLE from arduino-esp32

git clone https://github.com/nkolban/esp32-snippets.git
cp -r esp32-snippets/cpp_utils . && rm -rf esp32-snippets
rm -rf arduino-esp32/libraries/BLE/

Sorry, i cant reproduce this issue with esp-idf.
Could you check if you have turned on SMP in bluetooth settings in menuconfig? Also when did you update esp-idf and cpp_utils last time?

SMP is enabled.
When i get this error i'm not using cpp_utils directly, rather the arduino-esp32 with BLE. But fixed it by using cpp_utils.
I'm using the IDF project template from: https://github.com/wtakuo/M5Stack-IDF
Maybe i should make the IDF project from scratch.
What is your recommendations how to create a new esp-idf project?


Risk management of having the git repo on internet

How to manage the risk of having the git repo on internet, if for example a malicious user cracks admin paswords and delete the depo.

strict policy for passwords and authentification?
duplicating the depo with an internal Orange depo?
...

We could enable 2FA (2 Factor Authentication), but I do not know how that impacts the ergonomy
Replication in our gitlab its doable. @popescu-v , you already investigated this bit, any ideas ?

IMHO, one could use pull mirroring from GitHub to GitLab: the latter would pull from the former (the "canonical" repository) on a scheduled basis: https://docs.gitlab.com/ee/user/project/repository/mirror/pull.html .

I forgot to say that with git everyone has a copy of the full repository, so the risk if someone deletes the repo is very low.

Is that the case also for all the github management (issues, wiki...)?

As far as I know, the wikis are just (hidden) Git repositories and both platforms use the same format, hence synchronizing the wikis from GitHub to GitLab should be doable (scriptable) in a similar way to the main Git repository itself.
However, for issues, pull requests / merge requests, CI/CD pipeline execution logs, I am not aware of any automatic way of doing this synchronization easily. It should be doable to have periodic "migrations" from GitHub to GitLab, by reimporting the GitHub repository to GitLab (https://docs.gitlab.com/ee/user/project/import/github.html). But, this is a manual action which requires set-up and preparation.

Don't forget the GitHub REST API. For a start we can easily write a python script who write all issues on a csv file. It is already done on this repo. We can go further if needed (gitlab has a REST API too)

I suggest that

at least the 2 Factor Authentication is implemented
the role and acces permission is clearly defined for each contributor
the only permission granted to external user is to fork the repo

at least at the begining, we cannot scale to cope with external issues or contributions

We can enforce 2FA for the group KhiopsML but first we need that everyone configure it for its account. Note that this will be enforced by Github eventually.
More details:

https://docs.github.com/en/authentication/securing-your-account-with-two-factor-authentication-2fa/configuring-two-factor-authentication

For info, I have the github mobile app (especially useful in the doctor's waiting room) and the 2FA is automatically activated with it.


Server scripts aren't adapting to native Node ES environment (but full ES5 and CommonJS)

My classes and lambdas are transformed to ES5 constructs for server scripts(all files in .next/dist/**/*.js after next build), which is totally not acceptable despite it runs fine.
I'm using babel-register with env preset to still getting the latest ES features that doesn't come with native V8 support. I'm using Node v8.2.x, and most of the modern ES constructs are implemented, so I'm pretty confused why are my server scripts are being boiled down to primitive ES5.
And here's maybe the reason why.
I'm sorry if my wordings are kinda ambiguous, but English is not my mother tongue, heh

@stevefan1999 These code needs to run on the client. That's why we transpile them back to ES5.
In the future, we may accept a set of browsers and server version you need to support.
Based on that, we can transpile effectively.

I removed next/babel in presets in my .babelrc and instead installed react and env with specific versions of browsers back to presets.
Now it kinda works, I can finally have modern ES semantics, but both client and server packages are using it...
I wish I could still have ES5 for client bundle but ESnext in server.


Missing masterPassword input in post.go

Just start to try Key Transparency (just work-in-progress? I can't wait to use it)
I find that when I want to post a public key, there will be a notice "please enter a master key", but post.go does not accept the password -p as input.

A side question: is Key Transparency ready to an extent that a class project can launch a server and create a local key Merkle tree?

Codecov Report

Merging #971 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #971   +/-   ##
=======================================
  Coverage   47.34%   47.34%
=======================================
  Files          28       28
  Lines        2034     2034
=======================================
  Hits          963      963
  Misses        894      894
  Partials      177      177

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9701801...75b8aa2. Read the comment docs.

Hi @weikengchen, thanks for spotting and fixing this!
Key Transparency is ready for prototyping and classroom use.
Key Transparency is in the middle of polishing and tuning so it can be used in production.


Parent muzzle flashes to the shooter

I didn't do hitscan because it would look weird af unless someone has a better idea.


JavaScript BigInt / arbitrary precision number support

Per TC39: https://github.com/tc39/proposal-bigint
Though technically a proposal, this is shipped in Chrome stable and Node.js. The syntax change is an optional n postfix on literal numbers, like
let x = 10n;
let y = 0x10n;
let z = 0b0101n;

I think the change might be something like this ↓, and I'll tinker with rolling a PR to implement.
diff --git a/src/languages/javascript.js b/src/languages/javascript.js
index 24d4ae9a..d6a824a3 100644
--- a/src/languages/javascript.js
+++ b/src/languages/javascript.js
@@ -29,9 +29,9 @@ function(hljs) {
   var NUMBER = {
     className: 'number',
     variants: [
-      { begin: '\\b(0[bB][01]+)' },
-      { begin: '\\b(0[oO][0-7]+)' },
-      { begin: hljs.C_NUMBER_RE }
+      { begin: '\\b(0[bB][01]+)n?' },
+      { begin: '\\b(0[oO][0-7]+)n?' },
+      { begin: hljs.C_NUMBER_RE + 'n?' }
     ],
     relevance: 0
   };

Looks like about what I'd expect.  A PR would be nice.

@tmcw Great work!


Merged:  feature/lineup --> main

Modified:
File: index.astro
↳ (src/pages/index.astro)

Enabled #lineup navigation from the index page to the event page

File: liquid-dreams-volume-3.astro
↳ (src/pages/events/liquid-dreams-volume-3.astro)

Enabled #lineup on the event page
Released the <Features /> component for the lineup

Fixed MR's title


test: address a number of unused result warnings

Address the various set of unused result warnings in the test suite.  NFC.

ping

Overall the changes look reasonable to me. I will take a look at this later today to see if we can get it merged manually

Awesome!  Thanks!


AAFG9aEo3nV77Zan1AjdQoI5psjL0m6bRnA

Diagnostics
Request: GET https://api.teletype.atom.io/protocol-version

Versions
Teletype version: v0.13.4
Atom version: 1.53.0
Platform: win32

Thanks for reaching out!
We require the template to be filled out on all new issues and pull requests. We do this so that we can be certain we have all the information we need to address your submission efficiently. This allows the maintainers to spend more time fixing bugs, implementing enhancements, and reviewing and merging pull requests.
Thanks for understanding and meeting us half way :grinning:

Thanks for reaching out!
We require the template to be filled out on all new issues and pull requests. We do this so that we can be certain we have all the information we need to address your submission efficiently. This allows the maintainers to spend more time fixing bugs, implementing enhancements, and reviewing and merging pull requests.
Thanks for understanding and meeting us half way :grinning:


Added reflection code for shader uniforms

I've added reflection code to handle shader uniforms since I have this need.
One thing I didn't handle is the uniform binding location since, looking at the code, it seems it isn't handled by the compiler.

Thanks for your contribution.
There is an .editorconfig file to ensure consistent code formatting and indentation style.
If your IDE does not support it (I think it's only natively supported by Visual Studio 2017) please make sure you use 4 spaces instead of tabs.
Please adjust your formatting and then squash the commit.
Thanks and kind regards,
Lukas

Ok no problems :)

Do you still want this pull request to be merged into the master branch?
Because I'm still waiting for your formatting adjustment, i.e. conversion of tabs into 4 spaces.

Yes of course. Sorry for the delay but I had some issues at work and at the university. Just give me 2-3 hours and I'll make the changes.

No problem, I was just wondering if there was a misunderstanding.
I could have changed it quickly, but it would undo your contribution.

Well, I didn't do it for the credits :) If you need to make the changes right know you can do it of course, otherwise I'll make them in 2 or 3 hours :)

If it's all right, you'll do it.
Greetings,
Lukas

Done. It should be fine now :) Thanks for your understanding :)

Thanks for your contribution.
If you make a new commit where you add something to the public structs like ReflectionData,
please be so good to also update the C and C# wrappers,
e.g. XscReflectionData and XscCompiler.ReflectionData.
I'll do it this time.
Greetings,
Lukas

My apologies, since I never used the C and C# bindings it didn't even cross my mind. I'll keep it in mind for the next time :)


Need Help with Locally Signing "AccountSet" Operation

Hello,
I'm trying to locally sign an "AccountSet" operation to require a destination tag for an XRP address using the xyield/xrpl-go, but I'm encountering some difficulties.
What I'm trying to achieve:
I want to set the flag for "Require Destination Tags" on my XRP address.
What I've tried:
I've looked into the library but I haven't been able to identify which methods I should use to sign locally. I'm not very familiar with it.
How can I locally sign the "AccountSet" operation using this library?

Encode the transaction into json using the standard json encoding library, and pass it to the Sign method found in keypairs/keypairs.go


Rename HookQueue to hookQueue

This PR renamed HookQueue to hookQueue so that external package will not visit it. And after this, webhook invokes will become just PrepareWebhooks or PrepareWebhook. go webhook_module.HookQueue.Add is unnecessary.

Codecov Report

Merging #8778 into master will decrease coverage by 0.02%.
The diff coverage is 28.57%.

@@            Coverage Diff             @@
##           master    #8778      +/-   ##
==========================================
- Coverage    41.4%   41.37%   -0.03%
==========================================
  Files         541      541
  Lines       69522    69477      -45
==========================================
- Hits        28784    28747      -37
- Misses      37043    37047       +4
+ Partials     3695     3683      -12

Impacted Files
Coverage Δ

services/pull/pull.go
39.79% <ø> (-0.8%)
:arrow_down:

modules/notification/webhook/webhook.go
46.12% <ø> (-2.98%)
:arrow_down:

modules/repofiles/action.go
63.69% <ø> (-0.69%)
:arrow_down:

services/mirror/sync.go
0% <ø> (ø)
:arrow_up:

services/issue/label.go
36% <ø> (-1.67%)
:arrow_down:

services/release/release.go
25.71% <ø> (-1.69%)
:arrow_down:

routers/api/v1/repo/hook.go
18.39% <ø> (-0.39%)
:arrow_down:

services/milestone/milestone.go
0% <ø> (ø)
:arrow_up:

services/pull/merge.go
41.02% <ø> (-0.38%)
:arrow_down:

routers/repo/webhook.go
1.38% <ø> (ø)
:arrow_up:

... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0e7f7df...3827cf8. Read the comment docs.


This PR aim to support it and also update, cleanup and re-standardize some configs files.
List bellow, the changes made to the plugin.
Globally

[x] Remove Sylius 1.11 support.
[x] Cleanup .gitignore files.

Test application

[x] Use Symfony runtime.
[x] Update package.json with the latest version from sylius/sylius-standard.
[x] Cleanup Kernel.php
[x] Strange bug with Sylius 1.12, I fixed.yml file not loading because it needs to have .yaml extension.

Tests

[x] Update Behat config to use symfony/panther.
[x] Update Behat ChromeDriver reference to PantherDriver.
[x] Update PHPStan config (and remove outdated bitbag/coding-standard config import).
[x] Rename PHPStan neon config to phpstan.neon.dist (FYI: it allows to set an extra config into a developer env).
[x] Fix PHPSpec issue with TwigFunction being final.
[x] Update ECS config and avoid checking var and node_modules folders.
[x] Fix the Behat image uploader on Setup\PageContext  to avoid uploading image outside of the dedicated folder.

Hi,
I made some fixes to a copy of your branch and then deployed a new PR.
Details here:
https://github.com/BitBagCommerce/SyliusCmsPlugin/pull/498

Support for sylius 1.13 has been added https://github.com/BitBagCommerce/SyliusCmsPlugin/pull/498

@SzymonKostrubiec is there a reason on why you start a new PR instead of simply clone my repository branch and commit to it ? Or maybe you don't know it's something possible on GitHub ?


StoredProcedure using FOR JSON AUTO is not parsed as JSON

I am trying to query a Master table with nested array from Details table. I am using FOR JSON AUTO to convert the Details-records to an array property on the Master record.
The returned output is unparsed JSON like this:

And this is the relevant SQL in the stored procedure:

I would expect the output to be parsed JSON.
Am i missing a setting somewhere? I know in tedious there is a parseJSON option.

So the issue here is that the inner JSON (the "versions" field) is coming back as an escaped string from the SQL query itself, which the JSON deserializer can't automatically handle.
I'm not sure this is something we'd be able to fix on our end given that - we wouldn't be able to tell when a string is a JSON string versus just some other normal string.
But a workaround you could do is to manually convert the field after getting it from the server. So an example in C# using a property getter would be

Where inner is the JSON field from the query, e.g.
SELECT *, (SELECT * FROM PRODUCTS FOR JSON AUTO) AS [Inner] FROM Products
Would you be able to do something like that instead?

Yeah, that’s a manageable workaround. Thank you.
The tedious parseJSON option is probably applied on the javascript/client-side aswell.


[WIP] remotes/docker: protect secret with a mutex

Signed-off-by: Stephen J Day<EMAIL_ADDRESS>Closes #2273

Some double locking going on here that is locking up the test suite; the lock in setTokenAuth() then goes into a block which calls r.fetchTokenWithOAuth() or r.getToken() which both also attempt to acquire the lock

@estesp As I said, this is lazy effort. :)
I'm going to refactor this to move the auth into a protected object.

Codecov Report

Merging #2276 into master will increase coverage by 0.1%.
The diff coverage is 100%.

@@            Coverage Diff            @@
##           master    #2276     +/-   ##
=========================================
+ Coverage   45.41%   45.51%   +0.1%
=========================================
  Files          83       83
  Lines        9171     9188     +17
=========================================
+ Hits         4165     4182     +17
  Misses       4330     4330
  Partials      676      676

Flag
Coverage Δ

#linux
50.04% <100%> (+0.08%)
:arrow_up:

#windows
41.21% <100%> (+0.12%)
:arrow_up:

Impacted Files
Coverage Δ

remotes/docker/resolver.go
61.11% <100%> (+1.74%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f1cea3f...27a14f1. Read the comment docs.

LGTM


Add new_deployment option for serve

Objective: allow user to deploy and keep multiple model endpoints alive so that they can easily test and benchmark different models. (as current OpenAI compatible API server deployment will kill the previous deployment)

Changes:

add --new_deployment option to serve.py
if this option is enabled, the application name and route prefix will be using name as defined in the deployment config instead of router and /
for OpenAI compatible API deployment, the endpoint URL will become http://localhost:8000/{name}/v1 instead of http://localhost:8000/v1

enable option for deploying without overriding previous deployment

LGTM. Thanks @cheehook.


Warn about redundant brackets in class constraints

In the following class definition
class (Eq a) => Foo a where
  foo :: a -> a

the  current development version  of HLint didn't warn about the redundant brackets in the constraint (Eq a).

Happy for people to contribute off-by-default hints, but if they aren't being actively worked on, I'm not planning to leave a ticket for them. If someone does want to actively work on it raise a ticket.


Conventions : For loop - task fails to run on https://try.kotlinlang.org

There is an issue with this task:
https://try.kotlinlang.org/#/Kotlin Koans/Conventions/For loop/Task.kt
Trying to 'Check' the solution produces a 500, "SyntaxError: JSON.parse: unexpected end of data at line 1 column 1 of the JSON data"

Hello!
Please insert the solution:
class DateRange(val start: MyDate, val end: MyDate): Iterable<MyDate>{
    override fun iterator(): Iterator<MyDate> = DateIterator(this)
}

class DateIterator(val dateRange:DateRange) : Iterator<MyDate> {
    var current: MyDate = dateRange.start
    override fun next(): MyDate {
        val result = current
        current = current.nextDay()
        return result
    }
    override fun hasNext(): Boolean = current <= dateRange.end
}

fun iterateOverDateRange(firstDate: MyDate, secondDate: MyDate, handler: (MyDate) -> Unit) {
    for (date in firstDate..secondDate) {
        handler(date)
    }
}

works fine for me :)
Thanks.

Thanks @AlexanderPrendota. It looks like there was something else going on, producing the 500s, it's working fine now.


 It's not discovering the Broadlink device. Log as follows
11-19-2019 22:47:18.080 | INFO | Broadlink discover.... | com.bwssystems.HABridge.plugins.broadlink.BroadlinkHome
11-19-2019 22:47:19.110 | INFO | The requested route [/description.xml] has not been mapped in Spark for Accept: [application/json, text/plain, /] | spark.http.matching.MatcherFilter
11-19-2019 22:47:21.134 | INFO | The requested route [/description.xml] has not been mapped in Spark for Accept: [application/json, text/plain, /] | spark.http.matching.MatcherFilter
11-19-2019 22:47:23.108 | WARN | Did not discover any Broadlinks.
11-19-2019 22:47:23.109 | INFO | Broadlink Home created. | com.bwssystems.HABridge.plugins.broadlink.BroadlinkHome
Tried all the obvious so far. Vera controller discovered no problem.

Ok discovered this issue closed with no apparent solution https://github.com/bwssytems/ha-bridge/issues/984 As it was closed am I to assume that the poster solved their problem. Turning on WiFi which is a no brainer and setting static ip address for the RM made absolutely no difference. The question now is does the HA Bridge support the Broadlink RM Pro +. It has no problem learning RF and IR codes.

Contents of the service daemon. Couldn't find Broadlink. Looks like Discovery service is not working. I changed the Bridge to port 80 but it still makes no difference
ha-bridge.service
Loaded: loaded (/etc/systemd/system/ha-bridge.service; enabled; vendor preset: enabled)
Active: active (running) since Sat 2019-11-23 18:26:00 GMT; 3h 7min ago
Main PID: 896 (java)
Tasks: 24 (limit: 2200)
Memory: 39.4M
CGroup: /system.slice/ha-bridge.service
└─896 /usr/bin/java -jar -Dconfig.file=/home/pi/ha-bridge/data/habridge.config /home/pi/ha-bridge/ha-bridge-5.3.0.jar -Dserver.port=80
Nov 23 18:26:08 raspberrypi java[896]: 2019-11-23 18:26:08,282 [main] WARN  com.bwssystems.HABridge.plugins.broadlink.BroadlinkHome - Did not discover any Broadlinks.
Nov 23 18:26:08 raspberrypi java[896]: 2019-11-23 18:26:08,283 [main] INFO  com.bwssystems.HABridge.plugins.broadlink.BroadlinkHome - Broadlink Home created.
Nov 23 18:26:08 raspberrypi java[896]: 2019-11-23 18:26:08,290 [main] INFO  com.bwssystems.HABridge.plugins.moziot.MozIotHome - Mozilla IOT Home created. No Mozilla IOTs configured.
Nov 23 18:26:08 raspberrypi java[896]: 2019-11-23 18:26:08,421 [main] INFO  com.bwssystems.HABridge.devicemanagmeent.DeviceResource - HABridge device management service started....
Nov 23 18:26:08 raspberrypi java[896]: 2019-11-23 18:26:08,533 [main] INFO  com.bwssystems.HABridge.hue.HueMulator - Hue emulator service started....
Nov 23 18:26:08 raspberrypi java[896]: 2019-11-23 18:26:08,646 [main] INFO  com.bwssystems.HABridge.upnp.UpnpSettingsResource - Description xml service started....
Nov 23 18:26:08 raspberrypi java[896]: 2019-11-23 18:26:08,664 [main] INFO  com.bwssystems.HABridge.upnp.UpnpListener - UPNP Discovery Listener starting....
Nov 23 18:26:08 raspberrypi java[896]: 2019-11-23 18:26:08,666 [main] INFO  com.bwssystems.HABridge.upnp.UpnpListener - Create and run mDNS service.
Nov 23 18:26:08 raspberrypi java[896]: 2019-11-23 18:26:08,758 [main] INFO  com.bwssystems.HABridge.upnp.UpnpListener - UPNP Discovery Listener running and ready....

OK I'm assuming HA Bridge does not support my particular model of Broadlink RM Pro +
For anyone else experiencing similar difficulties my model details as follows
Broadlink RM Pro + IR+RF+WiFi
S/N 33222***************
Firmware v52
If anyone does indeed does find a solution I'll leave this issue open and maybe you could post the details.

Hi,
I have the same Problem:
Broadlink RM Pro + IR+RF+WiFi EU Model
Firmware: 57
12-14-2019 11:14:00.294	INFO	Broadlink discover....	com.bwssystems.HABridge.plugins.broadlink.BroadlinkHome
12-14-2019 11:14:05.307	WARN	Did not discover any Broadlinks.	com.bwssystems.HABridge.plugins.broadlink.BroadlinkHome

Yep, me too. Same device (RM Pro) with foxes IP. Port scan doesn’t show open ports for RM Pro, but shows 80 for Bridge. Don’t understand what’s going on.

I have the same problem.

Same problem I solved, via change code in broadlink_cli:
-parser.add_argument("data", nargs='', help="Data to send or convert")
+parser.add_argument("--data", nargs='', help="Data to send or convert")
Now it works perfectly: broadlink_cli --device @ac --send -data @t24

Same problem I solved, via change code in broadlink_cli:
-parser.add_argument("data", nargs='', help="Data to send or convert")
+parser.add_argument("--data", nargs='', help="Data to send or convert")
Now it works perfectly: broadlink_cli --device @ac --send -data @t24
Just received this email stating that the user had found the following solution but it’s not appearing here. Is it spam or factual.

Just received this email stating that the user had found the following solution but it’s not appearing here. Is it spam or factual.

It's my mistake, just messed thread https://github.com/mjg59/python-broadlink/issues/194

Just received this email stating that the user had found the following solution but it’s not appearing here. Is it spam or factual.

It's my mistake, just messed thread mjg59/python-broadlink#194

Ok. So you posted a solution to a different issue here in error. Understood.


curl: only enable psl support when libpsl is available

Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

What platform are you aiming for? Have you tried extending meta.platforms on libpsl to include it? Becaus interactive curl usage without libpsl can be problematic.
https://daniel.haxx.se/blog/2024/01/10/psl-in-curl/

What platform are you aiming for?

mingw32.


daemon: Disable BPF-masq if host-svc is disabled in tunnel mode

Currently, when running with --enable-bpf-masquerade=true, --tunnel!=disabled and --enable-host-reachable-services=false, accessing a remote backend from a host netns via ClusterIP is broken (reported in https://github.com/cilium/cilium/issues/12699).
This is because the DNAT is performed by an iptables rule installed by kube-proxy, which means that src IP addr is selected before the DNAT. So, the kernel picks the src IP addr of the iface with a IP default route, then does the DNAT, and finally sends the packet over the native device to the remote node. Everything is fine until a reply to the request is about to be sent by the remote backend. On the remote node, the reply (dst=the client node IP) gets masqueraded by the BPF-masq feature, because we masquerade pod -> remote host IP in the tunnel mode (see comment in the snat_v4_needed() for the reason), and currently we don't consult the CT map to see whether a packet is reply.
When the host-svc feature is enabled, the socket dst addr is rewritten before a related skb is even crafted. This makes the routing lookup to be performed with dst IP addr of the remote backend IP addr. So, in the tunnel mode the kernel will pick cilium_host's IP addr as the src IP addr, and the packet will be sent over the tunnel (and a reply). Therefore, the troublesome masquerading is avoided.
Disable the BPF-masq feature if the conditions are not met until we add a lookup in CT map (https://github.com/cilium/cilium/issues/12544).

test-me-please

(4.9 one w/ bookinfo unrelated)


Tree API bug when having highlight [[2, -1]]

Testing #62073
Code:
		label: <vscode.TreeItemLabel>{ label: key, highlights: key.length > 1 ? [[2, -1]] : void 0},

Behavior:

Same kind of bug when you have [[2, 1]]:

I think the desired behavior here is to have negative numbers count in from the end of the string (ex. 2,-1 would highlight from 2 up to, but not including, the last character in the string).


Django summernote unmaintained?

The last commit was done two years ago, looks like nobody is caring any longer for the package.
@lqez, @DiemenDesign, any news for future plan? Are you looking for help?

@claudep it's definitely abandoned, which is a shame as I added it to a new project and now have to rip it out.

There's no reason others can't contribute, that's the beauty of Open Source. I'm not a django use myself, hence why I don't do anything on this repository. If someone wanted to help maintain, I'm sure we could add them to do that upon the agreement of the other maintainers.

I would be OK to help maintain the package.

@lqez @hackerwins what's your thoughts on this?

Any news?

I'm actively using it. There's nothing else like it that's free....

I'm not sure, I should however be able to merge PR's, but I won't be able to test them, so I would be relying on those who submit PR's to do the right thing. So if anyone wants to fix issues, I'm more than happy to merge them. I guess if anyone wants to comment on PR's and indicate that they in fact do work, I could go from there, and if I can add people I will consider it, or at least advocate for them to the owners. I would also need to check commit history and quality of past PR's.

So what about starting with #466? I guess #484 is straightforward too. At some point, we'll need a new release, @DiemenDesign , do you think you would be ablte help for this too?

I've merged #466, only has there was confirmation that the fixes worked. #484 was just docs, so I merged that as well.
Future merges, until I get confirmation that it's ok to add maintainers, I'll require that another source confirms that the changes work, just so we can make sure, or at least reduce merging breaking changes.

Thanks :heart: . That makes sense, of course!

#492 is also an issue. I've just addressed it on my own fork, and will try to remember to submit a PR when the team gets around to testing it.

Is there any plan to create a new release on pypi for summernote, so the most basic thing would work again (especially 492)

I would love to, but currently no authorized person care for this package :sob:


Observation matrix - coding characters - moving "Description (generated)" and similar outputs to bottom of page

As a user, I am currently using the observation matrix tools to manage projects, so each column represents progress on a certain type of data.
For this use, in the model for coding characters, Description (generated), Diagnosis (generated), and Similar objects aren't informative; in the case of Similar objects, since the goal is for all the rows to be coded the same when the project is complete,  having a large block of text to scroll past to get to the character coding is a bit of a nuisance.
Would it be possible to put these in boxes that can be dragged to the bottom or rearranged, similar to how various fields can be moved in Browse OTU?

I completely agree- this is not the place for previewing data, those should be hidden and modal as required.  This task is the basic coding interface.

Why can't we just fix a bar to the top of matrix row coder, that floats on top of the scroll.  And add a "preview" button that shows the data.  You could link it to a hotkey, and toggle it super fast, or just make it clickable?

Hopefully I wasn't implying that the summary data in the row coder is completely useless; I did like it for coding morph characters, just not for project management. @proceps hide button (with saved user preference) is exactly what I would want.
I know there are other ways to track progress like tags and such, and maybe using the matrix model isn't the best (or appropriate) approach, but it seemed the best way to get quick overview of progress on a single project right now.

Closing, the top bar solve many issues.  Open new with single specifics.


update logo path

logo path update.
resolves #380

[X] other

Pull Request Test Coverage Report for Build 697

0 of 0   changed or added relevant lines in 0 files are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage decreased (-0.02%) to 71.32%

Files with Coverage Reduction
New Missed Lines
%

algorithms/sort/top_sort.py
1
92.31%

Totals

Change from base Build 685:
-0.02%

Covered Lines:
3852

Relevant Lines:
5401

💛  - Coveralls


Masonary: Update getDerivedStateFromProps  Flowtype

Summary
When testing migration from Flow to Typescript I get an error saying:

File: Masonry.ts - Error: Parameter 'props' of public static method from exported class has or is using private name 'T'.

It seems like the proper way to type Flow Generics is to declare the private name T after the function name getDerivedStateFromProps<Private Name Here>
Also I renamed T to K because I got an eslint error saying that T was already used

There's an issue in the Typescript project that references how to probably type getDerivedStateFromProps

Before the change, the type of props.items for getDerivedStateFromProps must be consistent with the one for componentDidUpdate. After the change, it no longer does? So the semantic is changed?
While it doesn’t seem ideal, it’s not a huge blocker because that’s really an internal API, not public API. I’m fine with this change even it turns out that it’s the only TypeScript-migration-friendly way. - Jack Hsu

What changed?
Just a tiny update to the Flow signature of the Masonry getDerivedStateFromProps method
Why?
When converting from Flow to Typescript, Typescript is not able to determine where T is coming from
Checklist

[x] Added unit and Flow Tests
[x] Added documentation + accessibility tests
[x] Verified accessibility: keyboard & screen reader interaction
[x] Checked dark mode, responsiveness, and right-to-left support
[x] Checked stakeholder feedback (e.g. Gestalt designers)

are you guys abandoning flow altogether?

are you guys abandoning flow altogether?

Not anytime soon. We would like to eventually migrate to TS, but that's dependent on a much larger internal migration. For now, we're looking to better support our users who are on TS while learning more about how to automate that migration.


"Failed to compile" error message in the new generated app

Type: Bug
Operating system: MacOS 10.15.7
Affects Version: 1.0.3
Priority: High
Severity: Critical
Preconditions: Generate the new application using janush command
Steps to reproduce:

Use command cd web
Use command npm run start or yarn start

Actual result:
After initial response there is an error message in terminal:
"Failed to compile.  'Router' cannot be used as a JSX component.   Its instance type 'BrowserRouter' is not a valid JSX element".
App is opening in default browser with index page of Janush, but no action can be performed on it.
Expected result:
The command finished running application correctly.
In default browser window is opening with index page of Janush and you can perform some action on it (for example can click sign in on the page and it will redirect to the sign in page).
Attachments:

The problem here is the wrong node version. You had node version 14 set and Janush has dependencies in package-lock.json for node v16.
Solution:
Reinstall the application from node v16


[BUG] Breaking change in Azure Data Tables 12.4.0 from 12.3.20 - column reported as string not DateTime

Describe the bug
Data in a TableEntity stored as OffsetDateTime is returned as String and not proper data type.
Exception or Stack Trace
N/A
To Reproduce
Store a OffsetDateTime in a TableEntity and try to obtain it.
Code Snippet
tableEntity.getProperty("latestEventTime") as OffsetDateTime
Expected behavior
tableEntity.getProperty("latestEventTime") as OffsetDateTime works.
Screenshots
N/A
Setup (please complete the following information):

Java 21
com.azure:azure-data-tables from 12.4.0

Information Checklist
Kindly make sure that you have added all the following information above and checkoff the required fields otherwise we will treat the issuer as an incomplete report

[x] Bug Description Added
[x] Repro Steps Added
[x] Setup information Added

@knubonrk I was unable to reproduce the issue you described with the information provided. I tested both version 12.4.0 and 12.3.20 of azure-data-tables and did not observe any changes is the return value of TableEntity.getProperty(String key) for an OffsetDateTime property.
One thing I'd like to note:
TableEntity.getProperty(String key) returns Object, not String. Any returned properties must be casted to their appropriate types.
So that I'm able to better assist you, please provide a detailed code snippet for the issue you encountered.

So after some digging in our code, we see that it is related to a query, and not simple get/set.
`    val tableClient = TableStoreClient(tableNamePrefix = "test",  tableNames = listOf("CastBug"))
val client = tableClient.getTableClient("CastBug")

//client.createTable()

//    val entity = TableEntity("default", "bug")
//    entity.addProperty("a_timestamp", OffsetDateTime.now())
//    client.createEntity(entity)
val options = ListEntitiesOptions()
    .setFilter("PartitionKey eq '$DEFAULT_PARTITION_KEY'")
    .setSelect(listOf("a_timestamp"))
    .setTop(1)

val entity = client.listEntities(options, null, null ).lastOrNull()

// val entity = client.getEntity("default", "bug")
val t: OffsetDateTime = entity?.getProperty("a_timestamp") as OffsetDateTime
println(t)

`
This code crashes. Using getEntity works.

Exception in thread "main" java.lang.ClassCastException: class java.lang.String cannot be cast to class java.time.OffsetDateTime (java.lang.String and java.time.OffsetDateTime are in module java.base of loader 'bootstrap')
at no.nrk.tjenesteplattform.common.core.tablestore.TableStoreCallerKt.main(TableStoreCaller.kt:28)
at no.nrk.tjenesteplattform.common.core.tablestore.TableStoreCallerKt.main(TableStoreCaller.kt)

Thank you @knubonrk for providing additional information, I will look into this and reply shortly.

@knubonrk Please note, the above code snippet that you have provided above is not valid Java 21 code using the standard libraries. I will do my best to make assumptions using the code snippet you have provided, but to be able to better assist you, I would ask that you provide a valid Java 21 codesnippet including import statements so that I can properly configure my testing environment to reflect your scenario.

@knubonrk I have been able to identify the issue. I will begin working on a resolution.

@knubonrk A fix for this issue has been included in azure-data-table 12.4.2. Please update to the latest SDK version. Thank you for reporting this issue to us.


[RFE] Add AS3/DO examples to TS examples tree

User would like to see all available examples for AS3/DO/TS in the "TS Examples" view.

Rename it from "TS Examples" -> "Example Declarations"
Setup parent item for each type (AS3/DO/TS)
Each parent would expand to show all example declarations for that type

DO examples are available for this now, so this work is in progress.
Submitted the following AS3 issue to get a single folder for examples, will add once available:

Provide as3 examples folder like do/ts #280

https://github.com/F5Networks/f5-appsvcs-extension/issues/280

Code has been updated to accommodate this, just waiting for the repo/url for as3 to close

functionality added in v2.0, released today

need to keep this open for visibility since we are still waiting on the as3 examples


Create ONBOARDING.md

Created a quick initial document for on-boarding new CommComm members. Wanted to throw something together so we can begin discussing and building upon it 👍

I think we should not make assumptions on how versed folks are with 1. Open source practices and 2. Node.js project practices for interacting and administrative duties related to our work, since many of the contributions for our work can live outside of the GitHub project workspace.

Agreed ^^ Added some material to start.

@chowdhurian @hackygolucky any thoughts on adding a small section about the "consensus seeking" model?

any thoughts on adding a small section about the "consensus seeking" model?

It's the cornerstone of the process here, crucial to buy-in and cooperation. Added!

should process around becoming a members get added in this document?

@codeekage nope, that belongs in other documentation. The explicit goal of this is to ensure that once we do accept a new member, that we have a laid out process to follow.

This document looks good overall to me. I think a helpful process to call out is the minimum amount of time required for review before we can merge a document. It isn't consistent across the project, so making sure it is known would be nice here.
This whole section is particularly helpful to mention but the hours specifically

Before landing pull requests, sufficient time should be left for input from other Collaborators. Leave at least 48 hours during the week and 72 hours over weekends to account for international time differences and work schedules. Trivial changes (e.g. typos or content changes) may be landed after a shorter delay.
Where there is no disagreement amongst Collaborators, a pull request may be landed given appropriate review. Where there is discussion amongst Collaborators, consensus should be sought if possible. The lack of consensus may indicate the need to elevate discussion to the Community Committee Members for resolution

We can discuss whether it should be consistent across the project in another issue :)

Copy/pasted that section @hackygolucky 👍
Going to land this. Let's iterate from here on! 🎊


[11.x] - Allow Prompt's multiselect prompt to be tested using expectsChoice

Dependent on another PR
This PR depends on https://github.com/laravel/framework/pull/51055 and should not be merged until it is merged.
Purpose
This PR will allow the expectsChoice method to be used when a Laravel Prompt multiselect is being used but when required is false.
Failing Test
I'm not quire sure how to approach the fix here so I first created a failing test;
https://github.com/laravel/framework/pull/51056/files#diff-2cba8279071f67c5fee6df1c8f5112974a28f48ef91fe0e821193ed27c6d8e1cR95-R101
Issue
The issue has to do with the fact that an additional option is being added when required === false;
https://github.com/laravel/framework/blob/48246da2320c95a17bfae922d36264105a917906/src/Illuminate/Console/Concerns/ConfiguresPrompts.php#L247-L253
Then, ALL options are being passed to the choice component;
https://github.com/laravel/framework/blob/48246da2320c95a17bfae922d36264105a917906/src/Illuminate/Console/Concerns/ConfiguresPrompts.php#L259
The expectsChoice assertion though does not cater for the additional choice that has been added. I assume this is because the expectsChoice method is interacting directly with the Symfony command that handles required internally on it's own.
Proposed Solutions
I'm unsure how to best handle this because I'm not sure why $options = [new PromptOption(null, 'None'), ...$options]; is required in the first place.
I was hoping @jessarcher could provide some insights as to how I could go about fixing this failing test.
Adjusting the expectation
If we add None to the expection, this makes the test pass but won't work if the user has actually defined None as an option in their arg list as well;
- ->expectsChoice('Which names do you like?', [], ['John', 'Jane', 'Sally', 'Jack'])
+ ->expectsChoice('Which names do you like?', [], ['John', 'Jane', 'Sally', 'Jack', 'None'])

Extract prompt options
This is what I initially tried in this PR but tests were then failing...

Hey @lioneaglesolutions, thanks for the PR!

I'm unsure how to best handle this because I'm not sure why $options = [new PromptOption(null, 'None'), ...$options]; is required in the first place.

The 'None' option is required because the multiselect prompt allows the user to select 0 or more options (when required: false); however, the Symfony choice component requires the user to select 1 or more options.
The fallbacks serve two purposes:

Provide a UI for users on Windows without WSL where Prompts is currently unable to work.
Allow the existing test assertions to work.

The 'None' option really only serves the first purpose, allowing Windows users to select 0 options.
The PromptOption class is required to work around some other behaviour that differs between Prompts and Symfony. Prompts will return the option value when a list is passed, otherwise, it returns the key. Symfony will return the value when any numerically-keyed array is passed and will only return the key when the array has at least one non-numeric key.
I think a short-term solution would be to not inject the 'None' option (and maybe not even use the PromptOption classes) when running unit tests, but there would probably still need to be some translation on how the default parameter is handled (Prompts expects an array, Symfony expects a comma-separated string).
I think a longer-term solution would be to build test assertions into the Prompts library itself so that Symfony is only used for the Windows fallbacks.

Hey @lioneaglesolutions,
I've created https://github.com/laravel/framework/pull/51078, which should solve this issue :+1:

Thanks @jessarcher good to see it fix - loved this $this->line('You like nobody.'); 😂


Issue #786

Bug
Long tooltip content makes wide and skinny tooltips
Solution
Added a max-width of max-w-xs to the tooltip
Screenshots
Screenshot of tooltip on desktop

Screenshot of tooltip on mobile

Closes https://github.com/PrefectHQ/prefect-design/issues/786


Support Petals

⚠ Please check that this feature request hasn't been suggested before.

[X] I searched previous Ideas in Discussions didn't find any similar feature requests.
[X] I searched previous Issues didn't find any similar feature requests.

🔖 Feature description
Super agent should support https://petals.dev/ by default and help bring users to petals, as the best way to give free users access to best-in-class OSS models.
📝 Additional Context
I envisage a system where directly from superagent.sh people can use petals and take advantage of this ecosystem.
Acknowledgements

[X] My issue title is concise and descriptive.
[X] I have searched the existing issues to make sure this feature has not been requested yet.
[X] I have provided enough information for the maintainers to understand and evaluate this request.

Hey @Sharpz7 would you be open to contributing this?

I don't know if I personally have the time right now, but happy to keep it on the back-burner for later.


add redirect article link

closes https://github.com/MicrosoftDocs/OfficeDocs-SharePoint/issues/4028

@MikePlumleyMSFT
PR has been copyedited and is ready for final review, could you please check and merge? Thanks!


Begin porting yanix to WASI

This is a series of patches which begin porting yanix to WASI, and which contain various other fixes needed for using yanix outside of Wasmtime in general.

Thanks for the review! I've now responded to all of the comments :-).

Closing, as this PR is out of date with my latest WASI porting work.


VehicleWeaponHash

Here's the complete list for VehicleWeaponHash:
public enum VehicleWeaponHash : uint
{
	Invalid = 0xFFFFFFFF,
	AkulaBarrage = 0x880D14F2,
	AkulaMinigun = 0x19B95679,
	AkulaMissile = 0x7CBE304C,
	AkulaTurretDual = 0x1C6D0842,
	AkulaTurretSingle = 0xB5B3B9AD,
	Annihilator2Barrage = 0x35D8CC90,
	Annihilator2Mini = 0xCAF6CD41,
	Annihilator2Missile = 0xC76BC6B7,
	ApcCannon = 0x138F71D8,
	ApcMg = 0xB56E4E4,
	ApcMissile = 0x44A56189,
	ArdentMg = 0xC44E4341,
	AvengerCannon = 0x9867203B,
	BarrageRearGl = 0xA44C228D,
	BarrageRearMg = 0x47894765,
	BarrageRearMinigun = 0x1F545F65,
	BarrageTopMg = 0xF7498994,
	BarrageTopMinigun = 0x3B9EBD01,
	BombushkaCannon = 0xD8443A59,
	BombushkaDualmg = 0x2C2B2D58,
	Bruiser250calLaser = 0x3D6A0196,
	Bruiser50cal = 0xD73DC601,
	Brutus250calLaser = 0x68C7A4C3,
	Brutus50cal = 0xEB5E5C0A,
	CannonBlazer = 0xEBF9FF3E,
	CaracaraMg = 0x6C516BA8,
	CaracaraMinigun = 0x4FCBDC7B,
	ChernoMissile = 0xA247D03E,
	CometMg = 0xEAA835F3,
	Deathbike2MinigunLaser = 0xE90C0BE9,
	DeathbikeDualminigun = 0x1D43CE24,
	DeluxoMg = 0x9AFF6376,
	DeluxoMissile = 0xB4F96934,
	DogfighterMg = 0x5F1834E2,
	DogfighterMissile = 0xCA46F87D,
	Dominator450cal = 0xF80C9B0F,
	Dominator550calLaser = 0xB4246A5F,
	DuneGrenadelauncher = 0xA0FC710D,
	DuneMg = 0xD11507CF,
	DuneMinigun = 0x54672A71,
	Flamethrower = 0xB300643A,
	FlamethrowerScifi = 0x8213B4A2,
	Granger2Mg = 0xEAE2E19A,
	HackerMissile = 0x766FF7B1,
	HackerMissileHoming = 0x77EACF96,
	HalftrackDualmg = 0x4F6384FB,
	HalftrackQuadmg = 0x491B2E74,
	HavokMinigun = 0x32FE9EEF,
	HunterBarrage = 0x2ED14835,
	HunterCannon = 0x2A00AB1A,
	HunterMg = 0x42BA80A7,
	HunterMissile = 0x924A5F5,
	Ignus2TurretMini = 0xE693725A,
	Impaler250cal = 0x5F565C09,
	Impaler350calLaser = 0x8CBDFC88,
	Imperator250calLaser = 0x7817C526,
	Imperator50cal = 0xB662C67B,
	InsurgentMinigun = 0xAA886DF8,
	Issi450cal = 0x7648E34D,
	Issi550calLaser = 0x767F6925,
	Jb700Mg = 0x373AD53C,
	KhanjaliCannon = 0x1E3ACFA0,
	KhanjaliCannonHeavy = 0x838B716D,
	KhanjaliGl = 0x178605E2,
	KhanjaliMg = 0x2A6F8E1D,
	KosatkaTorpedo = 0x62E2140E,
	MenacerMg = 0xDFCAF8A4,
	MicrolightMg = 0xC4E0216C,
	MobileopsCannon = 0xE53E69A4,
	MogulDualnose = 0xE5F3AE2F,
	MogulDualturret = 0xBA277C01,
	MogulNose = 0xF6189F4A,
	MogulTurret = 0xE2FD135E,
	Monster3Glkin = 0xE5AE53DD,
	MortarKinetic = 0x632A22FD,
	Mule4Mg = 0x84558727,
	Mule4Missile = 0x4772F84B,
	Mule4TurretGl = 0xDD124A65,
	NightsharkMg = 0xA61AC574,
	NoseTurretValkyrie = 0x4170E491,
	Oppressor2Cannon = 0xD64D3469,
	Oppressor2Mg = 0xE2451DD6,
	Oppressor2Missile = 0x753A78F1,
	OppressorMg = 0xD9322EDD,
	OppressorMissile = 0x8BB7C63E,
	Paragon2Mg = 0x2CAC4286,
	PatrolboatDualmg = 0x4C2FB4E9,
	PlaneRocket = 0xCF0896E0,
	PlayerBuzzard = 0x46B89C8E,
	PlayerLazer = 0xE2822A29,
	PlayerSavage = 0x61A31349,
	Pounder2Barrage = 0x926B8CE4,
	Pounder2Gl = 0x9318FF16,
	Pounder2Mini = 0x86E6F84E,
	Pounder2Missile = 0x9A8EA9A,
	Radar = 0xD276317E,
	RctankFlame = 0xF4EE498A,
	RctankGun = 0x52FCA619,
	RctankLazer = 0x57F22C50,
	RctankRocket = 0x76F744CB,
	RevolterMg = 0xBD5E626A,
	RogueCannon = 0xE72ABBC2,
	RogueMg = 0x97273CD,
	RogueMissile = 0x6C88E47D,
	RuinerBullet = 0x2FCC0F9,
	RuinerRocket = 0x50DC6AB,
	SavestraMg = 0xEB41E84E,
	Scarab250calLaser = 0xE22DEDCC,
	Scarab50cal = 0x217FEF28,
	ScramjetMg = 0xDCE6112,
	ScramjetMissile = 0xBCE908DB,
	SeabreezeMg = 0x51B8D4E8,
	Searchlight = 0xCDAC517D,
	Seasparrow2Minigun = 0x90F4C94C,
	Slamvan450cal = 0x3AAB6E6B,
	Slamvan550calLaser = 0x519543AE,
	SpaceRocket = 0xF8A3939F,
	Speedo4Mg = 0xC7FCF93C,
	Speedo4TurretMg = 0xD6561141,
	Speedo4TurretMini = 0x9EFE3EBA,
	StrikeforceBarrage = 0x39BC6683,
	StrikeforceCannon = 0x38F41EAB,
	StrikeforceMissile = 0x1EF01D8A,
	SubcarMg = 0x461DDDB0,
	SubcarMissile = 0xD4897C0E,
	SubcarTorpedo = 0xE783C3BA,
	TampaDualminigun = 0x67FDCFE4,
	TampaFixedminigun = 0xDAC57AAD,
	TampaMissile = 0x9E5840A2,
	TampaMortar = 0x3C83C410,
	Tank = 0x73F7C04B,
	TechnicalMinigun = 0xDB894608,
	ThrusterMg = 0x652E1D9D,
	ThrusterMissile = 0x4635DD15,
	TrailerDualaa = 0x808C4D4C,
	TrailerMissile = 0x145599F7,
	TrailerQuadmg = 0x4711B02C,
	TulaDualmg = 0xB0D15C0B,
	TulaMg = 0x488BD081,
	TulaMinigun = 0x1670C4A8,
	TulaNosemg = 0x419D8E15,
	TurretBoxville = 0xB54F4918,
	TurretDinghy550cal = 0xB3B155FD,
	TurretInsurgent = 0x44DB5498,
	TurretLimo = 0x2B796481,
	TurretPatrolboat50cal = 0xDF4EA041,
	TurretTechnical = 0x7FD2EA0B,
	TurretValkyrie = 0xA4513E35,
	VigilanteMg = 0xF4077EE7,
	VigilanteMissile = 0x504DA665,
	ViserisMg = 0x87A02E06,
	VolatolDualmg = 0x4497AC40,
	WaterCannon = 0x67D18297,
	Zr380250calLaser = 0x220093BC,
	Zr38050cal = 0x6AB93C82,
}

Parsed and formatted from https://raw.githubusercontent.com/DurtyFree/gta-v-data-dumps/master/vehicles.json

The game's implemtation of jenkins hash seems to be different, so the hash must be generated in-game.
Let me know if you're interested in the parser code

Maybe adding a parser for all enum/hash is a more viable and future-proof solution, I'll close this issue now.


Improvement: Overhaul arrays and objects DQL docs

Summary of the changes / Why this improves CrateDB
parent issue: https://github.com/crate/crate/issues/10110
I am leaving the commit history on this PR as-is in case it helps with the review. once I have feedback, I will update the branch and squash the commits
not sure how the commits should be squashed before merging. two options come to mind:

squash the whole thing into one commit
squash the changes to selects.html (along with other RST files and test data) as an update to the docs, and then squash the DepricationWarning fix (and any other related changes that might be necessary) into a separate commit as an update to the build system

maybe there are other ways of doing this? open to suggestions!
all of the changes on this PR result directly from my attempts to improve the arrays and objects SQL examples (and explanatory text) in selects.html
the changes on this PR do the following:

fix a DepricationWarning output by test_docs.py (see https://github.com/crate/crate/pull/10866/commits/6bda89c20d7d6a1d1d6002a3a4336041b7d6a028, https://github.com/crate/crate/pull/10866/commits/a905e065d7b37d21b1191732d054de4ea7119894, https://github.com/crate/crate/pull/10866/commits/1cd25a2f7575d6f2ef7f58f1f9fdf5a72416e13c) -- encountered while trying to fix the itests Gradle task

renames the locations column race to inhabitants (rationale here: https://github.com/crate/crate/issues/10110#issuecomment-744733672) -- appears in the SQL examples. fixing this necessitated small changes in other files to reflect the rename

fixes the test data's handling of ID values by removing the double quotes (see locations.json, locations_import_summary1.json, locations_import_summary2.json). inserting values as strings works, but it results in string sorting (as opposed to numerical sorting) when used in the examples. the previous sort order results in examples that list "1" followed by "10" (sort by id limit 2). with this change, the same example lists "1" followed by "2" (which I think is easier to understand, and is more in line with other test data)

alters the interests of two places in the locations test data (see locations.json) and adds a landmarks column (see test_docs.py) so that example queries in the ANY section more clearly demonstrate what is being shown

updates a reference in table-functions.rst to reflect some slight re-working of the sections in selects.html (plus zaps some trailing whitespaces -- an automatic thing my editor does. this is good style, so I left it in. but can remove, here and elsewhere, if requested)

updates any RST files that need updating to reflect the new locations test data (information-schema.rst, http.rst, value-expressions.rst)

for selects.html

rework the opening info (see line 7 onwards)
updates examples to match the test data in the introduction section (line 27)
rewraps some paras to fit 79 chars (line 67 and elsewhere)
changes the example output integer column formatting to right-align the value (to match the actual output) (line 191 and elsewhere)
moves link lists to the bottom of the file per the RST style guide (line 306)
removes a redundant example (line 494)
re-orders the section so that concepts are introduced gradually and each explanation builds upon the previous one. the new order: Arrays, Objects, Arrays within objects, Object within arrays, ANY (array), and Negating ANY -- NOTE: I adopted the phrases "arrays within objects" and "objects within arrays" because, in English, "object arrays" is ambiguous and could mean "arrays that belong to an object" or "arrays of objects". this ambiguity significantly adds to the confusion of the existing text
in the sections that cover arrays and objects, I reworked the examples so the reader is first shown the data and then shown how to operate on it in successively complex ways. this directly addresses @proddata's observation on https://github.com/crate/crate/issues/10110 that "it is not clear if [the] information [being operated on] is an object or array"
moved some info to admonition blocks and added new admonitions to clarify various points (as necessary)
changed the example queries to insert more places from the Hitchhikers Guide to the Galaxy universe (in keeping with the theme already established by the test data). as it was, inserting European placenames into this data set produced results that mix two different themes (which adds a small amount of confusion to an already confusing topic)
did my best to disambiguate what is happening when the examples query nested arrays and objects. I went through a bunch of iterations on this. it is difficult to explain without making someone dizzy. I think the approach I settled on works though. basically: be deliberate and verbose (e.g., the use of "child" and "parent")
added new admonitions (line 697) explaining that the child array index n must come before the parent object property name (e.g., my_column[n]['property']). this is so unintuitive that I was tempted to add a title to this admonition saying something like "SQL syntax Gotcha", but decided against it. I ended up trying to find out if it has been documented before in some sort of PostgreSQL "gotchas" list (e.g., https://sql-info.de/postgresql/postgres-gotchas.html). I couldn't find anything. I am also not clear why we do it this way. is it for compatibility with PostgreSQL? does PostgreSQL not support the inverse syntax? (I do not explain why we do it this way in the text. but if it is useful to do so, I can add that)
added notes about the fact that the my_column[n]['property'] syntax is polymorphic. at least, this is my understanding of it based on my experimentation. it is not mentioned in our docs, and I was unable to find anything useful on the web that would help me explain this. I am not sure polymorphic is the technically correct term to use here, but it seems to fit
added a note about the my_column['property']::text[][1] syntax mentioned by @jordi in https://github.com/crate/crate/issues/10110#issuecomment-647473814 -- this is a candidate for removal, imo. not sure if it's necessary or useful to add this or whether it just adds more complexity to one of the most complex sections in this document
reworked the examples in ANY and Negating ANY so that the examples better illustrate the purpose of the syntax being demonstrated

Checklist

[ ] Added an entry in CHANGES.txt for user facing changes
[ ] Updated documentation & sql_features table for user facing changes
[x] Touched code is covered by tests
[x] CLA is signed
[ ] This does not contain breaking changes, or if it does:

It is released within a major release
It is recorded in CHANGES.txt
It was marked as deprecated in an earlier release if possible
You've thought about the consequences and other components are adapted
(E.g. AdminUI)

this is (finally) passing on Jenkins but it is failing on my local machine and I cannot figure out why
I figured my incidental fix for the DepricationWarning output was the culprit so I backed out my changes to test_docs.py. still does not work
the two errors (that I have found so far -- the tests are randomized) are:
Failed example:
    pretty_print(sh("""curl -isSX PUT '<IP_ADDRESS>:4200/_blobs/myblobs/4a756ca07e9487f482465a99e8286abc86ba4dc7' -d 'contents'
    """).stdout.decode("utf-8"))
Expected:
    HTTP/1.1 201 Created
    content-length: 0
Got:
    HTTP/1.1 404 Not Found
    content-length: 0

    <BLANKLINE>

(a lot of others like this in the same file)
and:
File "/Users/nomi/GitHub/crate/crate/blackbox/docs/interfaces/http.rst", line 29, in http.rst
Failed example:
    pretty_print(sh(r"""curl -sS -H 'Content-Type: application/json' \
    -X POST '<IP_ADDRESS>:4200/_sql' \
    -d '{"stmt":"select name, position from locations order by id limit 2"}'
    """).stdout.decode("utf-8"))
Expected:
    {
      "cols": [
        "name",
        "position"
      ],
      "rows": [
        [
          "North West Ripple",
          1
        ],
        [
          "Outer Eastern Rim",
          2
        ]
      ],
      "rowcount": 2,
      "duration": ...
    }
Got:
    {
      "error": {
        "message": "RelationUnknown[Relation 'locations' unknown]",
        "code": 4041
      }
    }

(also many others in the same file)
judging by the nature of these failures, the test data is not being created properly, or else the tests themselves are being executed against a running CrateDB node that does not have the test data
I do not have any other instances of CrateDB running locally, so I think I can rule out the second explanation
both types of error fail when executing a shell command. that's why I thought it was my change that caused this. but the error persists even with the change reverted
running git clean -xdff $ ./gradlew and rm -rf blackbox/.venv do not fix the issue

I tried again on master as-is and the tests still fail in the same way. I figure this points to a local setup issue. I realized I was running Python 3.8 and that this may not be supported yet. I wiped my Python 3.8 install (to be absolutely sure it was gone) and re-installed Python 3.7. the issue persists. I am stumped

@seut I have updated the description to reflect the changes made. adding you for review specifically because some of the information I have added here is based on my understanding of CrateDB syntax based on experimentation alone. I am not 100% sure the way I have explained it is correct as these peculiarities of the syntax are not mentioned anywhere else in the docs (that I can find). for this reason, I would like some close technical scrutiny

@mechanomi In general I would really prefer that each commit just targets a dedicated topic and includes a verbose description of what it is changing. This would have also eliminated the need to describe your commits inside the PR description.
Additionally it helps a lot with reviewing, specially on PR's which lot of changes.
Having commits just titled with "Improve X..." without any description are not a good pattern...
By following this rule, questions on "what should I squash?" won't be necessary anymore.

@seut I have resolved all of your comments. took more work than I anticipated (lots of revisions and reworking) but I think the result is much better (flows better, more clarity, precision, and so on). thank you!!
I squashed everything into one commit and added a detailed commit message, per your request

@seut I have resolved all of your comments. took more work than I anticipated (lots of revisions and reworking) but I think the result is much better (flows better, more clarity, precision, and so on). thank you!!
I squashed everything into one commit and added a detailed commit message, per your request


How to let AntiDupl remember search and ignore paths?

Assume I setup 2 search paths and 2 ignore pathes.
Furthermore I removed the initail search path = AntiDupl installation folder
I click "ok" button and exit AntiDupl.
When I restart AntiDupl again the previously entered pathes are gone and the initial pathes (=installation folder) is listed.
How can I tell AntiDupl to remember these pathes?
The same happens with other values like Minimal+Maximal image width+height
Ben

I would check access rights (to write) for AntiDupl directory.
In operation, the program needs place to save your settings and results. By default, the program stores them in its directory (in subfolder user). If the user, for whatever reason wants to change the storage location of these files, he can do it using the option -s. The option has the following format:
-s Path
Here Path - full path to an existing directory selected by the user to store files. If the path contains spaces, it must always be quoted. Below is an example of using this option:
AntiDupl.NET.exe -s "C:\Documents and Settings\User\Application Data\AntiDupl.NET"

Sorry, your solution is NOT working.
Yes, I started AntiDupl v2.3.9 on 64bit Win7 with the folowing command
AntiDupl.exe -s G:\tools\dupes\AD\user"
then added a new folder, then exit and restarted the tool.
However the previously added folder was removed by AD.
Some files in"uder" fodler were updated (I can see it from the timestamp of these files).
So write access is possible.
It seems to me that AntiDupl does not change the
....
if this element is already existing
Furthermore I would appreciate if I could specify a RELATIVE path (like "./user) and
not an absolute path since I want to strat AntiDupl from USB flash drive where the drive lette could chnage from computer to computer.
Even better: AntiDupl should always at first automatically search for a subdirectory "user" even when no
"-s ..." paramter is specified.
Could you implement this?

Hello. I checked - the options (path and other) are saved and restored. I can't reproduce the bug on my computer.
The using of relative path to store user files is a good idea! I will implement the feature.

Ok ermig1979, just to show you that remembering pathes and min-max image resolution is NOT working I created a screencast recording.
Since this forum does not allow upload of videos I uploaded it to two file sharing services:
https://www12.zippyshare.com/v/k3YHnhAY/file.html
or
http://s000.tinyupload.com/index.php?file_id=58447777761621451454
Have a look at the  MP4 video which shows you in 2 steps that both values are NOT remembered beyond exit and restart. Maybe other values are not remembered as well.
AntiDupl should have a zero assumption strategy. If it does not find some values or options files it should create one with default values.
Could you re-check this problem?
I appreciate AntiDupl but need remembering
Thank you
Ben

May be I said not correct at all. But I meaned that I can't reproduce the bug on my computer. I belive that you really have the error. But if I can't reproduce the error then I can't fixed it.


[Enhancement] support dynamically change slot per path conf

What type of PR is this：

[ ] bug
[ ] feature
[x] enhancement
[ ] refactor
[ ] others

Which issues of this PR fixes ：

Fixes #8276
Problem Summary(Required) ：

[FE PR Coverage Check]
:heart_eyes: pass : 22 / 24 (91.67%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
com/starrocks/clone/TabletScheduler.java
22
24
91.67%
[1526, 1602]


client with multiple profiles

Describe the bug
I try to start my client application with multiple profiles by setting the active profile to: stage, support-stage
I even see this line in the log:
2021-07-01 17:20:20.236  INFO [springboot-no-ui-tests,,]  [  restartedMain] c.c.c.ConfigServicePropertySourceLocator : Located environment: name=springboot-no-ui-tests, profiles=[stage,support-stage], label=null, version=e9e9fda77b46039faa314499ba133f7af8411ef9, state=null
but for some reason only the first profile is being updated from the config server.
Does Spring cloud config knows how to handle multiple profiles coming from clients?

The reason behind it, is because we want to have two repositories in GIT one for developers to change for their configuration and one for support people. When the client will run we want it to read the configuration from both places for the same app.
for example here is the Spring cloud config server configuration for that:
repos:
cloud-waf-support:
pattern:
- 'springboot-no-ui-tests/support*'
cloneOnStart: true
uri: https://.../v1/repos/cloud-waf-support
default-label: main
cloud-waf:
pattern:
- 'springboot-no-ui-tests/*'
cloneOnStart: true
uri: https://.../v1/repos/cloud-waf
default-label: main
If you have another idea that will solve the issue it can be great

Eventually I solve this requirement: repo for support and repo for dev with the composite solution:
cloud:
config:
server:
composite:
-
type: git
uri: https://git-codecommit.eu-west-2.amazonaws.com/v1/repos/fallback-repo
default-label: main
force-pull: true
username: yyy
password: xxx
clone-on-start: true
repos:
springboot-no-ui-tests:
clone-on-start: true
pattern:
- 'springboot-no-ui-tests'
clone-submodules: false
uri: https://git-codecommit.eu-west-2.amazonaws.com/v1/repos/dev-repo
force-pull: true
default-label: main
username: yyy
password: xxx
-
type: git
uri: https://git-codecommit.eu-west-2.amazonaws.com/v1/repos/fallback-repo
default-label: main
force-pull: true
username: xxx
password: yyy
clone-on-start: true
repos:
springboot-no-ui-tests:
clone-on-start: true
pattern:
- 'springboot-no-ui-tests'
clone-submodules: false
uri: https://git-codecommit.eu-west-2.amazonaws.com/v1/repos/support-repo
force-pull: true
default-label: main
username: yyy
password: xxx

This can be closed.


Fix system call parameter for STDOUT to use :out

:out is the preferred way to redirect child process output.  The current
code is passing STDOUT which is actually passing the file descriptor,
and works most of the time, but it will not work if the parent process
has changed STDOUT to a file descriptor that the child cannot use.
[1] pry(main)> STDOUT = $stdout = StringIO.new
(pry):1: warning: already initialized constant STDOUT
=> #<StringIO:0x007fe119768610>
[2] pry(main)> system("echo 'hi'", STDOUT => "/dev/null")
ArgumentError: wrong exec option
from (pry):2:in `system'
(pry):2:in `<main>'
[3] pry(main)> system("echo 'hi'", :out => "/dev/null")
=> true

https://bugzilla.redhat.com/show_bug.cgi?id=1514618

@Fryguy Sorry this took me so long to get to! I just released 1.11.6 with this fix. Thanks for your contribution! 🎉


AOE - Workbook | Savings Plans Usage - Errors in tabs

🐛 Problem
Workbook | Savings Plans Usage reports 2 errors in 2 tabs.

Full Usage Report

'project' operator: Failed to resolve scalar expression named 'ExpiryDate_t'...

Unused Savings Plan Analysis - Used Savings Plan Details

'project' operator: Failed to resolve scalar expression named 'ExpiryDate_t'...
📷 Screenshots

ℹ Additional context

EA Customer
Single Savings Plan
Savings Plan in Expiring State

Thanks for reporting this issue, @psilantropy. There seems to be a schema difference between EA/MCA savings plans API responses. We will investigate a solution to normalize both and hopefully share a tentative fix soon.
Tagging @flanakin for awareness.

Hi, @psilantropy.
There is a PR (#1047) that will fix this issue. If you want to try out the fix before the release, you just have to make sure you are running AOE on the latest version (September release) and then update the Export-SavingsPlansUsageToBlobStorage runbook with this code. After the next Savings Plans export+ingest cycle, the Savings Plans workbook should load correctly.
If you are not on the latest AOE release, check here how to upgrade.

Thanks. Updated just now, but missed the job by 30 minutes. I will let it run as per schedule and give you an update tomorrow.
Appreciate it :)

Hi, @helderpinto  - This ended up generating an error. (I am on the latest AOE)
Last stage of runbook was Uploading CSV to Storage
The running command stopped because the preference variable "ErrorActionPreference" or common parameter is set to Stop: This request is not authorized to perform this operation using this permission. HTTP Status Code: 403 - HTTP Error Message: This request is not authorized to perform this operation using this permission. ErrorCode: AuthorizationPermissionMismatch ErrorMessage: This request is not authorized to perform this operation using this permission. RequestId:xxxxxxx

Just doing a few tests, checking logs now. But not getting much more info so far. Next run-time is in about 5 hours.

Hi, @psilantropy. As I stated above, before updating the runbook code, you must upgrade AOE to the latest release. Authentication to Storage by the Automation Account identity is now Entra ID-based. The error you got is because the AOE identity does not have the Storage Blob Data Contributor role on the Storage Account.

Yeah this is the only error I can pull;
ErrorCode: AuthorizationPermissionMismatch
ErrorMessage: This request is not authorized to perform this operation using this permission.

I was just trying to compare Export-ReservationsPriceToBlobStorage and Export-SavingsPlansUsageToBlobStorage but they seem a little different with how they handle auth/upload.

Hi, @psilantropy. As I stated above, before updating the runbook code, you must upgrade AOE to the latest release. Authentication to Storage by the Automation Account identity is now Entra ID-based. The error you got is because the AOE identity does not have the Storage Blob Data Contributor role on the Storage Account.

Sorry I misinterpreted that and thought I was on the latest version. I'll review now and let you know. Thank you.


Use RRDP exclusively to update local RPKI repository

I was playing around with routinator and noticed that there's no way to force it to update the local repository using RRDP exclusively. Does the option exist and I missed it?

This is probably not the right forum to ask how to use the tool. I'll reach out to the mailing list. Sorry.

Nono, this is absolutely the right place!
I believe --disable-rsync does what you want to do?


Fix TestApp compile errors

Problem
We cannot build TestApp now because of compile errors.
Screenshots

@googlebot I signed it!

@googlebot I signed it!

@miaout17 Can you please take a look on this PR? Thanks!

@yyoon can you review?

In fact, I just tried building the TestApp from master branch, and it's actually building fine for me.
@ken0nek Can you explain more about the exact steps you took, and what compile errors you saw?
I used the typical CocoaPods flow, by running pod install and then opening the TestApp.xcworkspace (NOTE: not the .xcodeproj file), and building the TestApp scheme from Xcode.

@ken0nek Can you please check @yyoon comments and keep us posted. Thanks!

It has been 14 days with no activity and the awaiting response label was assigned. Is this PR still valid? Assigning the stalled label. Please comment to reassure me that this is still being worked on.

@ken0nek Any update on this PR? Please. Thanks!

@gbaned Sorry for the late response. I checked this issue on master and there was no error any more. I will close this issue. Thank you for the review!


[PropTypes] Name PropTypes imports

[x] PR has tests / docs demo, and is linted.
[ ] Commit and PR titles begin with [ComponentName], and are in imperative form: "[Component] Fix leaky abstraction".
[ ] Description explains the issue / use-case resolved, and auto-closes the related issue(s) (http://tr.im/vFqem).

Would using named imports affect speed? Is there a compelling stylistic or architectural reason for using a named import of import {PropTypes} from 'react' or the alternative of repeatedly calling React.PropTypes.{...}?
For instance with a named import of import {PropType} from 'react', the PropTypes declaration would look like
propTypes: {
  location: PropTypes.object.isRequired,
  onRequestChangeList: PropTypes.func.isRequired,
  open: PropTypes.bool.isRequired,
}

and with a default export of import React from 'react' it would look like
propTypes: {
  location: React.PropTypes.object.isRequired,
  onRequestChangeList: React.PropTypes.func.isRequired,
  open: React.PropTypes.bool.isRequired,
}

In this excellent question from 2013 on import module vs. from module import function in Python, the answers seem to center mostly on stylistic and architectural reasons for choosing between default and named imports. Is this true in React as well or is there a difference in performance?
This PR reduces the size of the MUI source code by 7335 bytes using the named import over about 2,300 lines.
Make code cleaner by eliminating clutter of calling PropTypes from React default import. Use named import of {PropTypes}. Rename MUI custom PropTypes to MuiPropTypes to avoid conflict. Fix linting errors in src/svg-icons/index.js.
UPDATE: Both versions render in the same amount of time when averaged (2.4s). The new rendered version drops the package from 6.9mb to 6.8mb, with a difference in the size of app.js of 21.39kb.

Error text:
[execsync v1.0.2] Attempting to compile native extensions.

No output has been received in the last 10 minutes, this potentially indicates a stalled build or something wrong with the build itself.

Looks like it timed out, no reason why is immediately obvious. I looked over the diff again to see if there were any typos but wasn't able to find any.
On the Requests page, it's saying build 4412 was successful:

While on the actual build page it says it errored. https://travis-ci.org/callemall/material-ui/builds/116216257
I will look for the typo that may still be passing all the unit and lint tests but is failing the Travis build. Is it possible to try to run this again?
I am curious to see if this PR would affect the speed of the library in any way. It reduces size by about 10kb. On one hand, that's not much next to the total size of the library. On the other, there are some micro libraries out there that aren't much bigger than 10kb. The Redux src is 18kb.
One test I could run is going through the docs instance and selecting every component. If I can't find a typo, I will try that.

@stephenburgess8 Nothing to do with your code, travis crapped out.

Review aside, on hold pending https://github.com/callemall/material-ui/pull/3682.
Even though there's more to be done there, there's too much work in that PR to have this one merged first and create a ton of merge conflicts, when this one is just a simple global search and replace.

@stephenburgess8 I understand that your work has 2 steps: replace the current PropTypes with MuiPropTypes and then React.PropTypes with PropTypes. It would be best if you could break this down into 2 PR. This way it will be a lot easier to review and a lot easier to merge without conflicts.

I am curious to see if this PR would affect the speed of the library in any way. It reduces size by about [7.3kb].

If you are using a tool like https://github.com/oliviertassinari/babel-plugin-transform-react-remove-prop-types/ in production,
that may be doing more harm than it's helps. I'm not 100% sure. I would need to check if uglify can remove or not the extra PropTypes import.

Actually, the babel output is almost the same. I'm fine with this changes :+1:.
in
import React, {PropTypes} from 'react';

const contextTypes = {
    router: PropTypes.object,
    pushProfilesRoute: React.PropTypes.func
};

out
'use strict';

var _extends = Object.assign || function (target) { for (var i = 1; i < arguments.length; i++) { var source = arguments[i]; for (var key in source) { if (Object.prototype.hasOwnProperty.call(source, key)) { target[key] = source[key]; } } } return target; };

var _react = require('react');

var _react2 = _interopRequireDefault(_react);

function _interopRequireDefault(obj) { return obj && obj.__esModule ? obj : { default: obj }; }

var contextTypes = _extends({}, Component.contextTypes, {
     router: _react.PropTypes.object,
     pushProfilesRoute: _react2.default.PropTypes.func
});

This way it will be a lot easier to review and a lot easier to merge without conflicts.

#3682 touches imports on every component. There will be massive merge conflicts if this gets merged first, whether together or split. This is a novelty PR; let's park it and focus on the real work.

This PR is certainly of the lowest priority, though I wouldn't consider the attempt to reduce the size of a 7mb library to be novelty. I'll watch #3682 to see when it's done, then split this into two.

I think this a good idea. I haven't looked at the code changes, but I faintly remember there being a few cases where a PropTypes variable was used that pointed to an internal module. I'll look into that more closely later...

@newoga There is an internal PropTypes that I renamed mui-prop-types that serves to limit custom props to one of a few options, such as positioning and z-depth. This serves a slightly different function than React proptypes which serve to say what kind of variable it must be and doesn't enforce only certain options of that variable type. As such it would be good to differentiate between the two. You can mui-prop-types here . I didn't change the content, just the name. Thanks.

@stephenburgess8 Thanks for the follow up. It's probably safe to continue this effort since we got the ES6 classes PR merged.
Also @stephenburgess8, is there any benefit to using class MyComponent extends Component instead of class MyComponent extends React.Component?

@newoga I will try this again with the refactored code.
The major benefit of the change proposed in this PR is to reduce bytes as a result of character boilerplate. Doing a named import of component would likely result in a slight increase of characters due to a one-to-one relationship between referencing React.Component and components. For each component, React.Component is called once. On the other hand, for every component, React.PropTypes is called several times on average. That's where the savings in bytes would be coming from.
I'll get back to work on this. Thanks.

The major benefit of the change proposed in this PR is to reduce bytes as a result of character boilerplate.

As far as I have tested it, once Babel transpile the code, that doesn't make any difference in production.
I believe that the advantage is conceptual. You import what you need from packages.

@oliviertassinari @stephenburgess8 also -- don't spend too much time on this as I can automate it pretty easily.

@oliviertassinari especially using the transform :+1:

In my testing (previous version) it reduced the size of the rendered app.js by 21.39kb.

In my testing (previous version) it reduced the size of the rendered app.js by 21.39kb.

If you keep the propTypes that can be expexted.
Why not using https://github.com/oliviertassinari/babel-plugin-transform-react-remove-prop-types?

I see, so I assume that since I was in a development env that's why I was seeing the difference in size. If it were in production then all PropTypes would be removed?
In that case, seems like the change would be purely conceptual as you say. In that case, it seems like the majority including Dan Abramov are using
import React, {Component, PropTypes} from 'react' as per this discussion: https://discuss.reactjs.org/t/es6-import-as-react-vs-import-react/360/2

@stephenburgess8 Considering this comment, doing this change sounds like a good idea.

I just import React, { Component, PropTypes } because JSX wants React to be in scope. Once this is solved at some point, I won't even need React.

@nathanmarks Could you do this automatically?

Yup, will do it tonight or tomorrow

@stephenburgess8 No need - a coupe of global regex search-and-replaces will do the trick.

@mbrookes That's automating it 😄


Rename the currently implented plugins to correct names

...which still need to be determined.

CPAlien Forester v1.0 = "BenchExec XML"

SystemTAP v1.0 = "DejaGnu summary"

I'm not sure about the glibc - I would need to have a look if it's generic enough to be called Make, or is it glibc specific.


Solution import error: Plugin Types import: FAILURE (System.Xml.XmlElement caused an exception)

Expected behavior and actual behavior.
Trying to import the Dynamics365WorkflowTools_1_0_51_1_8.2_managed.zip into our production CRM fails and displays the below error.
Error Code: 0x80048012
Error Text:
Plugin Types import: FAILURE. Error: Plugin: msdyncrmWorkflowTools, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=416e876b9bee261e of PluginTypeName: Microsoft.Crm.Entities.PluginType and PluginTypeNode: System.Xml.XmlElement caused an
Steps to reproduce the problem (screenshots are really usefull)
CRM Version - online/onpremise - WorkflowTools version
Dynamics 365, v8.2
Version 1612 (<IP_ADDRESS>3) (DB <IP_ADDRESS>3) online

Hi donalmc, did already have the solution installed in your dev environment?
did you have a prevous version of the workflow tools?
do you have any workflow running using the workflow tools?
regards

Hi Damian,
Yes - the solution is installed in our dev environment.
Yes - previously we had 1.0.38 installed. I updated dev to 1.0.50 last week. Before I went to import my own updated unmanaged solution, I tried to update production to 1.0.51 and this failed. I realized that I should update dev and installed 1.0.51 this morning and this blocked access to all solutions. I rolled back my sandbox to the backup before installing 1.0.51 and regained access to my solutions. Currently we have 1.0.38 installed on Production.
Yes - should I deactivate all workflows before updating?
Thank you for your time and your marvellous workflow tools.

Hi Demian,
I am also experiencing this same import issue however I have not previously installed the solution in to my environment. DEV is currently 365 on premise with update 2.2
Any help or advice you can give would be greatly appreciated, this looks like a great solution and i'm excited to try it out!
Best wishes,

Hi Demian,
I'm having the same issue as mentioned earlier.
Version: 1612 (<IP_ADDRESS>) (DB <IP_ADDRESS>) On-premises.
I've tried importing the following versions of workflowtools:

Dynamics365WorkflowTools_1_0_51_1_8.2_managed
Dynamics365WorkflowTools_1_0_49_0_8.2_managed
Dynamics365WorkflowTools_1_0_46_0_8.2_managed
Dynamics365WorkflowTools_1_0_44_0_8.2_managed
Dynamics365WorkflowTools_1_0_42_1_8.2_managed
Dynamics365WorkflowTools_1_0_41_3_8.2_managed

Hard error:
Plugin Types import: FAILURE. Error: Plugin: msdyncrmWorkflowTools, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=416e876b9bee261e of PluginTypeName: Microsoft.Crm.Entities.PluginType and PluginTypeNode: System.Xml.XmlElement caused an exception.

Hi all,
I just trying to play and test for this issue, but cannot reproduce the error with the managed solution.
I just tried to import it on this version: versión 1612 (<IP_ADDRESS>9) (DB <IP_ADDRESS>9) online
and I tried installed previous versions and with running workflows...and every time I try it it works fine.
Please share with me the logs files (if you are onprem) to see if we can get more details about the error.
thanks!

Hello,
Thank you for your email!
Our customer DEV environment (where we had the issue) had to be rolled back last week. Since then I have been able to import the corresponding version of your solution into it without issue.
It seems it may have been a problem related to the environment
We hope to go back to the later 2.2 version very soon and I will of course let you know should we have any further import issue and a log file to go with it.
Best wishes,
Alberta
From: Demian Adolfo Raschkovan<EMAIL_ADDRESS>Sent: 19 March 2018 13:16
To: demianrasko/Dynamics-365-Workflow-Tools<EMAIL_ADDRESS>Cc: Alberta Seawright<EMAIL_ADDRESS>Comment<EMAIL_ADDRESS>Subject: Re: [demianrasko/Dynamics-365-Workflow-Tools] Solution import error: Plugin Types import: FAILURE (System.Xml.XmlElement caused an exception) (#63)
Hi all,
I just trying to play and test for this issue, but cannot reproduce the error with the managed solution.
I just tried to import it on this version: versión 1612 (<IP_ADDRESS>9) (DB <IP_ADDRESS>9) online
and I tried installed previous versions and with running workflows...and every time I try it it works fine.
Please share with me the logs files (if you are onprem) to see if we can get more details about the error.
thanks!
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHubhttps://github.com/demianrasko/Dynamics-365-Workflow-Tools/issues/63#issuecomment-374207437, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AT1bIZQ7-wxarqgdjGR4oiuSt06zSXJ_ks5tf6-DgaJpZM4SS2DP.

Hi Demian, any update on this issue?

sorry for the delay...hard days organizing the Dynamics Saturday in Madrid. Will see it this weekend.
thanks

Hi MohitMdd,
Maybe you need to follow this answer from Microsoft suuport to othernoe in the community: https://community.dynamics.com/crm/f/117/t/208497
remove it, and then reimport it...
thanks!

Hi Demian,
I don't see how that provides an answer to my issue :)


trocr - error in finetuning trocr text recognition model on SROIE dataset

I am trying to fine-tune trocr model on SROIE dataset as per steps given in readme file. I have downloaded and given path of SROIE dataset to DATA variable, but I am facing some issues in fine-tuning text recognition model.
Can you please give more details about dataset folder structure to finetune model?

Any update for this, I have the same issue, thanks

hi, where to get or pretrain the models for Japanese, Korean, etc<EMAIL_ADDRESS>


add a feature to the minidlna luci interface

This now sets force_sort_criteria option.  It would need translations that I haven't done.  source file is luci/applications/luci-app-minidlna/luasrc/model/cbi/minidlna.lua
luci-app-minidlna.diff.txt

Please open a regular PR for that.

If you have a GIT dev setup, please do so, thank you