[Bug]: onPress not working on Touchable Child component of MarkerView [iOS]

Mapbox Implementation
Mapbox
Mapbox Version
v10
Platform
iOS
@rnmapbox/maps version
10.0.0-rc.5
Standalone component to reproduce
import React from 'react';
import { View } from 'react-native';
import Mapbox from '@rnmapbox/maps';

const App = () => {

const markers = [
  { coordinate: [12.338, 45.4385] },
  { coordinate: [10.338, 47.4385] },
  { coordinate: [8.338, 43.4385] },
];

return (
<Mapbox.MapView style={styles.map}>
    <Mapbox.Camera zoomLevel={5} centerCoordinate={[12.338, 45.4385]} />
    {/* Rendering Markers */}
    {markers.map(marker => (
    <Mapbox.MarkerView coordinate={marker.coordinate} allowOverlap>
        <TouchableOpacity onPress={()=>console.log("pressed", marker.coordinate)}>
           <View style={{width: 10, height: 10, backgroundColor: 'red'}} />
        </TouchableOpacity>
    </Mapbox.MarkerView>
    ))}
</Mapbox.MapView>
)}

Observed behavior and steps to reproduce
Touchable Child component inside MarkerView, onPress is not working on iOS. But works on Android. Seems like Map layer is disabling the Markers onPress events
Expected behavior
Touchable Child component inside MarkerView, onPress to work on iOS
Notes / preliminary analysis
No response
Additional links and references
No response

@santhosh-umapathi-appymango please include a complete component.  markers, onPress  is not defined.

@santhosh-umapathi-appymango I wasn't able to reproduce the issue. I've trired on iOS simulator. And both feedback and both events worked fine.
Used the following component to try to reproduce:
import React from 'react';
import { View, TouchableOpacity } from 'react-native';
import Mapbox from '@rnmapbox/maps';

const App = () => {
  const markers = [
    { coordinate: [12.338, 45.4385], key: 'k1' },
    { coordinate: [10.338, 47.4385], key: 'k2' },
    { coordinate: [8.338, 43.4385], key: 'k3' },
  ];

  return (
    <Mapbox.MapView style={{ flex: 1 }}>
      <Mapbox.Camera zoomLevel={5} centerCoordinate={[12.338, 45.4385]} />
      {/* Rendering Markers */}
      {markers.map((marker) => (
        <Mapbox.MarkerView
          coordinate={marker.coordinate}
          allowOverlap
          key={marker.key}
        >
          <TouchableOpacity
            onPress={() => console.log('pressed', marker.coordinate)}
          >
            <View style={{ width: 10, height: 10, backgroundColor: 'red' }} />
          </TouchableOpacity>
        </Mapbox.MarkerView>
      ))}
    </Mapbox.MapView>
  );
};

export default App;

 LOG  pressed [10.338, 47.4385]
 LOG  pressed [12.338, 45.4385]
 LOG  pressed [10.338, 47.4385]
 LOG  pressed [12.338, 45.4385]
 LOG  pressed [10.338, 47.4385]
 LOG  pressed [12.338, 45.4385]
 LOG  pressed [10.338, 47.4385]
 LOG  pressed [10.338, 47.4385]
 LOG  pressed [10.338, 47.4385]

Closing as cannot reproduce

@trevorarmstrong thanks much for verifying the example app. I think our example app is rn 69.7. Will try in new app if I have time.

@mfazekas , @trevorarmstrong , Yes I forgot to update the versions I was using.
"react-native": "0.71.1"
iOS Simulator: 16.4
Hope this helps to pinpoint the issue.

Folks are you using mapbox v10 implementation?
Do you have
$RNMapboxMapsImpl = 'mapbox'

in your podfile?

RNMapboxMapsImpl

yes, I'm using v10 mapbox ("<EMAIL_ADDRESS>and "react-native": "0.71.5". I assume that problem in Mapbox Maps for iOS version 10.12.1, before it was 10.11.

I have
% cat ios/Podfile.lock| grep MapboxMaps
  - MapboxMaps (10.12.0):
    - MapboxMaps (~> 10.12.0)
    - MapboxMaps (~> 10.12.0)
    - MapboxMaps
  MapboxMaps: a9978d13d1cba0403c5bdd2ab3b71418924075d2

cat ios/Podfile.lock| grep MapboxMaps

cat ios/Podfile.lock| grep MapboxMaps
  - MapboxMaps (10.12.1):
    - MapboxMaps (~> 10.12.0)
    - MapboxMaps (~> 10.12.0)
    - MapboxMaps
  MapboxMaps: a673c0923f645dc6f90e40bdc034b8567d8dead4

can you try to update pod and run example?

@anfinil  it's working fine for me with 10.2.1 as well, I dog et touch feedback and:
 LOG  pressed [12.338, 45.4385]
 LOG  pressed [8.338, 43.4385]

% cat ios/Podfile.lock| grep MapboxMaps
  - MapboxMaps (10.12.1):
    - MapboxMaps (~> 10.12.0)
    - MapboxMaps (~> 10.12.0)
    - MapboxMaps
  MapboxMaps: a673c0923f645dc6f90e40bdc034b8567d8dead4

@Santhosh-Umapathi my pod file is:
require_relative '../node_modules/react-native/scripts/react_native_pods'
require_relative '../node_modules/@react-native-community/cli-platform-ios/native_modules'

platform :ios, min_ios_version_supported
prepare_react_native_project!

$RNMapboxMapsImpl = 'mapbox'

# If you are using a `react-native-flipper` your iOS build will fail when `NO_FLIPPER=1` is set.
# because `react-native-flipper` depends on (FlipperKit,...) that will be excluded
#
# To fix this you can also exclude `react-native-flipper` using a `react-native.config.js`
# ```js
# module.exports = {
#   dependencies: {
#     ...(process.env.NO_FLIPPER ? { 'react-native-flipper': { platforms: { ios: null } } } : {}),
# ```
flipper_config = ENV['NO_FLIPPER'] == "1" ? FlipperConfiguration.disabled : FlipperConfiguration.enabled

linkage = ENV['USE_FRAMEWORKS']
if linkage != nil
Pod::UI.puts "Configuring Pod with #{linkage}ally linked Frameworks".green
use_frameworks! :linkage => linkage.to_sym
end

target 'rnrnmapboxts' do
config = use_native_modules!

# Flags change depending on the env values.
flags = get_default_flags()

use_react_native!(
  :path => config[:reactNativePath],
  # Hermes is now enabled by default. Disable by setting this flag to false.
  # Upcoming versions of React Native may rely on get_default_flags(), but
  # we make it explicit here to aid in the React Native upgrade process.
  :hermes_enabled => flags[:hermes_enabled],
  :fabric_enabled => flags[:fabric_enabled],
  # Enables Flipper.
  #
  # Note that if you have use_frameworks! enabled, Flipper will not work and
  # you should disable the next line.
  :flipper_configuration => flipper_config,
  # An absolute path to your application root.
  :app_path => "#{Pod::Config.instance.installation_root}/.."
)

target 'rnrnmapboxtsTests' do
  inherit! :complete
  # Pods for testing
end

pre_install do |installer|
  $RNMapboxMaps.pre_install(installer)
end

post_install do |installer|
  $RNMapboxMaps.post_install(installer)
  react_native_post_install(
    installer,
    # Set `mac_catalyst_enabled` to `true` in order to apply patches
    # necessary for Mac Catalyst builds
    :mac_catalyst_enabled => false
  )
  __apply_Xcode_12_5_M1_post_install_workaround(installer)
end
end

@anfinil it's working fine for me with 10.2.1 as well, I do get touch feedback and:
 LOG  pressed [12.338, 45.4385]
 LOG  pressed [8.338, 43.4385]

% cat ios/Podfile.lock| grep MapboxMaps
  - MapboxMaps (10.12.1):
    - MapboxMaps (~> 10.12.0)
    - MapboxMaps (~> 10.12.0)
    - MapboxMaps
  MapboxMaps: a673c0923f645dc6f90e40bdc034b8567d8dead4

    "react-native": "0.71.1"

@Santhosh-Umapathi my pod file is:
require_relative '../node_modules/react-native/scripts/react_native_pods'
require_relative '../node_modules/@react-native-community/cli-platform-ios/native_modules'

platform :ios, min_ios_version_supported
prepare_react_native_project!

$RNMapboxMapsImpl = 'mapbox'

# If you are using a `react-native-flipper` your iOS build will fail when `NO_FLIPPER=1` is set.
# because `react-native-flipper` depends on (FlipperKit,...) that will be excluded
#
# To fix this you can also exclude `react-native-flipper` using a `react-native.config.js`
# ```js
# module.exports = {
#   dependencies: {
#     ...(process.env.NO_FLIPPER ? { 'react-native-flipper': { platforms: { ios: null } } } : {}),
# ```
flipper_config = ENV['NO_FLIPPER'] == "1" ? FlipperConfiguration.disabled : FlipperConfiguration.enabled

linkage = ENV['USE_FRAMEWORKS']
if linkage != nil
Pod::UI.puts "Configuring Pod with #{linkage}ally linked Frameworks".green
use_frameworks! :linkage => linkage.to_sym
end

target 'rnrnmapboxts' do
config = use_native_modules!

# Flags change depending on the env values.
flags = get_default_flags()

use_react_native!(
  :path => config[:reactNativePath],
  # Hermes is now enabled by default. Disable by setting this flag to false.
  # Upcoming versions of React Native may rely on get_default_flags(), but
  # we make it explicit here to aid in the React Native upgrade process.
  :hermes_enabled => flags[:hermes_enabled],
  :fabric_enabled => flags[:fabric_enabled],
  # Enables Flipper.
  #
  # Note that if you have use_frameworks! enabled, Flipper will not work and
  # you should disable the next line.
  :flipper_configuration => flipper_config,
  # An absolute path to your application root.
  :app_path => "#{Pod::Config.instance.installation_root}/.."
)

target 'rnrnmapboxtsTests' do
  inherit! :complete
  # Pods for testing
end

pre_install do |installer|
  $RNMapboxMaps.pre_install(installer)
end

post_install do |installer|
  $RNMapboxMaps.post_install(installer)
  react_native_post_install(
    installer,
    # Set `mac_catalyst_enabled` to `true` in order to apply patches
    # necessary for Mac Catalyst builds
    :mac_catalyst_enabled => false
  )
  __apply_Xcode_12_5_M1_post_install_workaround(installer)
end
end

can you push the example project in github? I'll try to test on my environment and check the difference.

@anfinil check out this repo:
https://github.com/mfazekas/rnmapbox-examples/

I've updated library to "^10.0.0-rc.11" and now it works.

Does not work for us still, I'm going to have to strip our app down to the bare bones and start building it back up to try to figure out what's wrong here

@mfazekas for us it's the react navigation drawer, if we render our component inside a drawer screen no press handlers are fired. Worked fine on v8.5.0.
@santhosh-umapathi-appymango any chance you're using a react navigation drawer?

Def seems react navigation related, which means it's going to be hit a lot once this goes to a wider release.
I've given up on MarkerView and ported my stuff to PointAnnotation, but that has it's own problems (broken shadows, janky refresh logic). Would love to go back to MarkerView when it's working again.

Our example app uses @react-navigation/native and @react-navigation/native-stack. It would be great if someone could post simplified app to reproduce.

Not a solution, but a possible workaround if you already include react-native-gesture-handle in your project.
I switched from a Pressable component to a TapGestureHandler and it seems to be stable.

@anfinil , upgrading the lib to ^10.0.0-rc.11 does not work in my case, I doubt navigation can be the reason for me as well. Need to check it as a nav free component.

Updating to rc.13 breaks things again. ) Update to MapboxMaps 10.12.2 (was 10.12.1) didn't help. Replacing TouchableOpacity inner component with TapGestureHandler helps.

JS
const onMarkerPress = () => {
if (active) {
navigationRef.navigate('poi');
}
};
const singleTap = Gesture.Tap().onEnd((e, success) => {
if (success) {
runOnJS(onMarkerPress)();
}
});
//

soved with this for now I hope this helps

Any update on if there is intention to fix this, whether it is an issue within MapBox's iOS sdk that they will fix, or one that this library would make?

@MichaelDanielTom see - https://github.com/rnmapbox/maps/issues/2751#issuecomment-1493315694 and https://github.com/rnmapbox/maps/issues/2751#issuecomment-1500795156
I wasn't able to reproduce the issue. Please try to figure out under what conditions does the issue happens. Then we can look into it, thanks for the understanding.

Fixed like this:
import {TapGestureHandler} from 'react-native-gesture-handler';

      <TapGestureHandler onActivated={handleTap}>
        <View style={styles.shadowWrapper1}>{CustomMarkerSwitch()}</View>
      </TapGestureHandler>

I have the same issue with the TouchableOpacity, and the workaround from @Ajmal0197 worked, thanks. In my case, I need to know when the marker is pressed. Otherwise, the event is mistakenly dispatched when the zooming gesture is performed. The versions I'm using for several core libraries of my app are:
"react-native": "0.72.4",
"@rnmapbox/maps": "10.0.15",
"react-native-reanimated": "3.3.0",
"@react-navigation/native": "^6.1.7",
"@react-navigation/native-stack": "^6.9.13"

The simplest marker implementation I tried:
import Mapbox from '@rnmapbox/maps';
import React from 'react';
import { View } from 'react-native';

import { TouchableOpacity } from 'react-native';
import { Geo } from '../../../types/geo';

type MarkerProps = {
  id: string;
  point: Geo.Point;
};

const Marker = ({ id, point }: MarkerProps) => {
  return (
    <Mapbox.MarkerView id={id} coordinate={point}>
      <TouchableOpacity onPress={() => console.log('pressed')}>
        <View style={{ width: 10, height: 10, backgroundColor: 'red' }} />
      </TouchableOpacity>
    </Mapbox.MarkerView>
  );
};

export default Marker;

Regarding the MapView, I tried a simple one without any props attached. If you need more details, I can prepare a more detailed example.


How do I decode g729

IMPORTANT: Be sure to replace all template sections {{ like this }} or your issue may be discarded.
Overview
I am attempting to write a simple g729 decoder using PyAV. However, the audio being outputted is of extremely poor audio quality and does not match that of CLI ffmpeg.
Expected behavior
Output an audible audio file from g729 input.
Actual behavior
audio being outputted is of extremely poor audio quality and does not match that of CLI ffmpeg. I am unable to attach a sample g729 file here to this ticket. The request here is to review the provided sample code for sensibleness.
Traceback:
No exceptions.

Investigation
Sample code:
    with open(path_to_g729_encoded_file, "rb") as f:
      buf = f.read()
      codec = av.CodecContext.create("g729", 'r')
      codec.channels = 1
      codec.bit_rate = 8000
      codec.sample_rate = 8000
      g729Packets = codec.parse(buf)
      fout = open("audio.s16p", "wb")
      for g729 in g729Packets:
         for frame in codec.decode(g729):
            for plane in frame.planes:
              fout.write(bytes(plane))
      fout.close()

Research
I have done the following:

[* ] Checked the PyAV documentation
[*] Searched on Google
[*] Searched on Stack Overflow
[*] Looked through old GitHub issues
[*] Asked on PyAV Gitter
[ ] ... and waited 72 hours for a response.

Your decoded frames probably have padding


feat(Portal|Modal|Confirm): Better uncontrolled usage support

Fixes #891
A few updates that I think will have a big impact in terms of usability of these components:

Adds a closeOnCloseClick to Portal which makes it so that if an element with the data-close attribute within the portal is clicked, it will close the portal.
Update the Confirm component so clicking confirm/cancel will close the modal (makes use of closeOnCloseClick). This enables uncontrolled usage and I've updated all of the Confirm examples to make use of that where possible.
Adds a closeIcon prop to Modal which renders an icon in the modal which, onClick, will trigger the modal to close (makes use of closeOnCloseClick). NOTE: With the default SUI styling, the icon appears outside of the modal. This is not an error on our side - the placement of the icon matches the SUI-core example and there are SUI CSS rules for .ui.modal > .close which intentionally put it out there. This seemed weird to me so I just wanted to call attention to it not being a bug:

Current coverage is 99.91% (diff: 92.00%)

No coverage report found for master at 2a6a730.

Powered by Codecov. Last update 2a6a730...e465d10

@levithomason - ping 😉

I'm hesitant on this one, I really don't think we should be reaching into the DOM for this.  I've considered a few solutions, but I believe it is best to leave this to a controlled pattern until we solve it using virtual DOM API.

@davezuko do you have any wise ideas on parent-child communication in this regard?  The only other thing I can think of is providing some Modal method that would return a wrapped "close" component.  It would intercept the click and close the Modal, but this requires an obtuse API like:
const { MyModal, Close } = Modal.createWithClose()

<MyModal>
  <Close />
</MyModal>

Where the parent-child relationship can be baked in when the create factory is invoked.  We have a very similar problem for Sidebars which have a related Pusher component.  The pattern is this need to have two components that can be placed anywhere in the tree but have a communication relationship established before they are rendered.

Given we've merged the Modal closeIcon in #932 it would be good so see what this PR looks like after having those changes implemented here.  This PR still has really great improvements outside of that.

Just rebased this. The updates to Confirm are making use of the data-close attribute. I think to keep the same functionality without we'll have to introduce shorthand for the Modal. I can take a stab at that, probably on a separate PR though. @levithomason - thoughts?

Blocked makes sense to me.  Modal shorthand would be awesome :D

We now support a close icon and there is a shorthand PR underway #1508.  Should be unblocked here soon, finally!

Modal shorthand is also now completed.  Unblocking this one.

Closing for #1599


handle verbose + jit and has_aux=True in gauss_newton

@mblondel @vroulet ,
Making some improvements and bug fixes for GaussNewton. In particular, I'm making some minor changes in the printing error section so that we can Jit functions while using verbose=True. This should also let other solvers be jittable while using verbose=True.

Hello Amir,
Sorry for the delay I wanted the previous PR on LM to be done.
Concerning this one:

Using jax.debug for the prints is great. It would probably be best to have this done outside of this PR and review all algorithms. For example, one may simplify the printing of the errors in the zoom linesearch too and revise all algorithms that give additional information when verbose=True. I can do that if you don't have the bandwidth.
For Gauss-Newton, I wasn't there when it was first implemented and I would have some generic questions before enhancing e.g. the jit possibilities:

Gauss-Newton needs a linesearch to converge otherwise it is well-known that it can diverge (see Wikipedia counter-example for example).
I don't really see any use-case for a GN method if we have a LM method that is functional. True Gauss-Newton has a quadratic local convergence but globally it can be pretty bad. On the other hand, LM can better behave globally. True LM with fixed regularization parameter only converges linearly but with varying regularization, I believe the quadratic convergence can be ensured. Overall I think LM is more general anyway. What do you think?

Sounds good, I moved it to https://github.com/google/jaxopt/pull/503

Thanks, that'll be a very useful addition!

This would then become an LM variant right?

Not exactly, LM uses a trust-region method. I was saying a simple linesearch. By the way, it would be interesting to have a generic trust-region method which could apply not only to LM.

I agree with you that LM would be preferred than GN ...

Ok! So shall we close this PR then for now if that's ok with you?

Thanks for the PR! I left you some comments.

Hello Amir,
If the comments above were fixed can you mark them as resolved and squash everything?
I'll add the pull ready tag.
Thanks for all!


Adding integrationv2 tests for HRR server side

Resolved issues:
resolves https://github.com/awslabs/s2n/issues/2050
Description of changes:
Adds integration tests for HRR server side in the integrationv2 framework.
Call-outs:
Migrate the existing integration test in tests/integration/s2n_tls13_handshake.py  to the new framework.  I have left the old test in integrationv1 for now and have not deleted it.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Codecov Report

Merging #2146 into master will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2146      +/-   ##
==========================================
+ Coverage   81.01%   81.02%   +0.01%
==========================================
  Files         247      247
  Lines       18404    18404
==========================================
+ Hits        14910    14912       +2
+ Misses       3494     3492       -2


Readme Update: Show Project Contributors automatically without having to add them manually

Is your feature request related to a problem? Please describe.
Display and feature project's awesome contributors automatically without having to add them manually.
Describe the solution you'd like

Using dynamic web app contributors-img
Display an clubbed image of top 100 awesome contributor's. This will display their avatars.
Takes less space and automatically adds up the contributors, without having to add them manually.
The count of avatars could be controlled with adding a single query parameter in the image URL.
max={count} ; count = 100 by default

Describe alternatives you've considered

Manually adding every contributor and feature them.
Increase number of commits with every contributor details added.

Additional context
Contributor's featurewall would look like below -

Hello everyone 👋
I hope this message finds you well. As you may know, the original repository for app ideas has not been updated in a while and is no longer actively maintained. However, I'm excited to let you know that a new repository has been created to continue this project (https://github.com/vincent0426/app-ideas).
The new repository aims to provide a comprehensive list of practical and achievable app ideas that developers of all levels can work on to improve their skills and build their portfolios. We welcome contributions from anyone who wants to add their own app ideas or improve the existing ones, and we are also looking for volunteers who can help maintain the repository and keep it up to date.
If you are interested in contributing or maintaining this project, please head over to the new repository (https://github.com/vincent0426/app-ideas) ⭐ and take a look at the existing issues and pull requests. Feel free to open a new issue if you have an app idea to suggest or if you have any questions about the project.
Thank you for your attention, and I hope to see you in the new repository soon! 💖

⚠ This message was generated by a robot 🤖, if this message reached you, consider leaving a star for this robot, repository link
⭐ https://github.com/aldairandre/github-bot ⭐

Hello everyone 👋
I hope this message finds you well. As you may know, the original repository for app ideas has not been updated in a while and is no longer actively maintained. However, I'm excited to let you know that a new repository has been created to continue this project (https://github.com/vincent0426/app-ideas).
The new repository aims to provide a comprehensive list of practical and achievable app ideas that developers of all levels can work on to improve their skills and build their portfolios. We welcome contributions from anyone who wants to add their own app ideas or improve the existing ones, and we are also looking for volunteers who can help maintain the repository and keep it up to date.
If you are interested in contributing or maintaining this project, please head over to the new repository (https://github.com/vincent0426/app-ideas) ⭐ and take a look at the existing issues and pull requests. Feel free to open a new issue if you have an app idea to suggest or if you have any questions about the project.
Thank you for your attention, and I hope to see you in the new repository soon! 💖

⚠ This message was generated by a robot 🤖, if this message reached you, consider leaving a star for this robot, repository link
⭐ https://github.com/aldairandre/github-bot ⭐

Hello everyone 👋
I hope this message finds you well. As you may know, the original repository for app ideas has not been updated in a while and is no longer actively maintained. However, I'm excited to let you know that a new repository has been created to continue this project (https://github.com/vincent0426/app-ideas).
The new repository aims to provide a comprehensive list of practical and achievable app ideas that developers of all levels can work on to improve their skills and build their portfolios. We welcome contributions from anyone who wants to add their own app ideas or improve the existing ones, and we are also looking for volunteers who can help maintain the repository and keep it up to date.
If you are interested in contributing or maintaining this project, please head over to the new repository (https://github.com/vincent0426/app-ideas) ⭐ and take a look at the existing issues and pull requests. Feel free to open a new issue if you have an app idea to suggest or if you have any questions about the project.
Thank you for your attention, and I hope to see you in the new repository soon! 💖

⚠ This message was generated by a robot 🤖, if this message reached you, consider leaving a star for this robot, repository link
⭐ https://github.com/aldairandre/github-bot ⭐


Add some kusto metric suggestions

This PR contains some initial kusto metric suggestions.

@hjscherer sorry, there was still an issue with an uppercase F in microsoft.web/serverFarms (which wasn't even touched in this PR). I've cleaned up my local clone now and fixed it here.


Add support for deeplinking into a repo -> tab

eg. overview / issues / prs / code. This will enable us to do some more advanced things in the future, and I think it would be a good think to tackle and get our feet wet in more deeplinking logic / architecture.

Linking #418


BUG: tf2zkp shows wrong comment for tf-function in s-domain

Describe your issue.
https://github.com/scipy/scipy/blob/v1.7.1/scipy/signal/filter_design.py#L1009-L1077
The comment of tf2zpk suggest b,a to be in "descendant order":
.. math::
        H(s) = \frac
        {b_0 s^M + b_1 s^{(M-1)} + \cdots + b_M}
        {a_0 s^N + a_1 s^{(N-1)} + \cdots + a_N}

This is not true for positive powers, only for given values in descendant negative powers.
Reproducing Code Example
no code needed

Error message
a

SciPy/NumPy/Python version information
1.7.2 1.21.2 sys.version_info(major=3, minor=9, micro=5, releaselevel='final', serial=0)

Could you explain more about what's wrong with the documentation?
It looks correct to me: the entries of b and a correspond to descending powers of s (or z); e.g., b=[1,2,3] and a=[7,0,9] correspond to a numerator of "s^2 + 2 * s + 3"  and a denominator of "7 * s^2 + 9".  This is the same convention as for np.roots.
In [9]: from scipy.signal import tf2zpk

In [10]: import numpy as np

In [11]: b = [1, 2, 3]; a = [7, 0, 9]

In [12]: print(f'{np.roots(b) = }, {np.roots(a) = }')
np.roots(b) = array([-1.+1.41421356j, -1.-1.41421356j]), np.roots(a) = array([-0.+1.13389342j,  0.-1.13389342j])

In [13]: tf2zpk(b, a)
Out[13]:
(array([-1.+1.41421356j, -1.-1.41421356j]),
 array([-0.+1.13389342j,  0.-1.13389342j]),
 0.14285714285714285)

This seems to be correct, but the DC gain is not k.
If you assume 1/((sT1+1)*2(sT2+1)**3) the DC gain should be 1 due to lim s->0, but the zpk gain is not the DC gain. Maybe this should be stated more clearly.


IDN expansion

Grab IDN information from IANA
Updated metadata for many many zones
Add a human-targetted "ASCII mandated by policy" tag, use for .vegas, .ai
Have an "IDN where ASCII blocked" domain, .рф
Add tooling for showing the codepoint ranges (-show-unicode)

@ydnar @case

@ydnar any further comments and/or work needed on this?

@case this currently has the prohibitIDN flag in metadata. Per thread elsewhere, this is ZoneDB state, not end-user state.

Do we cache IDN table files?
Where do we store hints about a given TLD like this?

Looks like -generate-go isn’t idempotent, which could lead to large unnecessary diffs.

Per offline conversation regarding IDN, code point tables, and LGRs: I wanted to sketch out an alternate vision for this, where we constrain ZoneDB’s responsibility to the locations or descriptions of LGRs per zone, rather than an actual copy or implementation. Implementation could be left to a separate library, like domainr/whois or domainr/epp.
Hypothetical changes to the metadata JSON:
{
  "...": "...",
  "labelGenerationRulesets": [
    {
      "script": "Latn",
      "url": "https://www.iana.org/domains/idn-tables/tables/com_latn_1.2.txt"
    },
    {
      "language": "ja",
      "url": "https://www.iana.org/domains/idn-tables/tables/com_ja_1.2.txt",
      "comment": "Japanese"
    }
  ]
}


urllib3 connection error

I am suddenly having issues with base maps timing out. Nothing has changed in my code but this is now happening from home and the office (so, not a location thing). Odd, any ideas? Have you seen this?
During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/home/jamie/reportgeneration/venv/lib/python3.8/site-packages/requests/adapters.py", line 439, in send
    resp = conn.urlopen(
  File "/home/jamie/reportgeneration/venv/lib/python3.8/site-packages/urllib3/connectionpool.py", line 755, in urlopen
    retries = retries.increment(
  File "/home/jamie/reportgeneration/venv/lib/python3.8/site-packages/urllib3/util/retry.py", line 574, in increment
    raise MaxRetryError(_pool, url, error or ResponseError(cause))
urllib3.exceptions.MaxRetryError: HTTPSConnectionPool(host='a.basemaps.cartocdn.com', port=443): Max retries exceeded with url: /light_all/14/8250/5410.png (Caused by NewConnectionError('<urllib3.connection.HTTPSConnection object at 0x7f7dd93c6850>: Failed to establish a new connection: [Errno 110] Connection timed out'))

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "code/app.py", line 38, in <module>
    landcoverMap(report, reportData)
  File "/home/jamie/reportgeneration/code/maps/landcover.py", line 8, in landcoverMap
    map1.addBasemap(None)
  File "/home/jamie/reportgeneration/code/map.py", line 64, in addBasemap
    cx.add_basemap(ax, source=baseimage, crs="EPSG:27700", zorder=1, alpha=1, attribution_size=2)
  File "/home/jamie/reportgeneration/venv/lib/python3.8/site-packages/contextily/plotting.py", line 143, in add_basemap
    image, extent = bounds2img(
  File "/home/jamie/reportgeneration/venv/lib/python3.8/site-packages/contextily/tile.py", line 248, in bounds2img
    image = _fetch_tile(tile_url, wait, max_retries)
  File "/home/jamie/reportgeneration/venv/lib/python3.8/site-packages/joblib/memory.py", line 591, in __call__
    return self._cached_call(args, kwargs)[0]
  File "/home/jamie/reportgeneration/venv/lib/python3.8/site-packages/joblib/memory.py", line 534, in _cached_call
    out, metadata = self.call(*args, **kwargs)
  File "/home/jamie/reportgeneration/venv/lib/python3.8/site-packages/joblib/memory.py", line 761, in call
    output = self.func(*args, **kwargs)
  File "/home/jamie/reportgeneration/venv/lib/python3.8/site-packages/contextily/tile.py", line 303, in _fetch_tile
    request = _retryer(tile_url, wait, max_retries)
  File "/home/jamie/reportgeneration/venv/lib/python3.8/site-packages/contextily/tile.py", line 446, in _retryer
    request = requests.get(tile_url, headers={"user-agent": USER_AGENT})
  File "/home/jamie/reportgeneration/venv/lib/python3.8/site-packages/requests/api.py", line 75, in get
    return request('get', url, params=params, **kwargs)
  File "/home/jamie/reportgeneration/venv/lib/python3.8/site-packages/requests/api.py", line 61, in request
    return session.request(method=method, url=url, **kwargs)
  File "/home/jamie/reportgeneration/venv/lib/python3.8/site-packages/requests/sessions.py", line 542, in request
    resp = self.send(prep, **send_kwargs)
  File "/home/jamie/reportgeneration/venv/lib/python3.8/site-packages/requests/sessions.py", line 655, in send
    r = adapter.send(request, **kwargs)
  File "/home/jamie/reportgeneration/venv/lib/python3.8/site-packages/requests/adapters.py", line 516, in send
    raise ConnectionError(e, request=request)
requests.exceptions.ConnectionError: HTTPSConnectionPool(host='a.basemaps.cartocdn.com', port=443): Max retries exceeded with url: /light_all/14/8250/5410.png (Caused by NewConnectionError('<urllib3.connection.HTTPSConnection object at 0x7f7dd93c6850>: Failed to establish a new connection: [Errno 110] Connection timed out'))

It looks like an issue with the fastly cdn, now and again it works for me but it is very rare.

Thanks for reporting @natcapresearch. As I understand, that is related to the provider rather than contextily. It might be worth to track availability over at xyzservices? I'm closing for now but feel free to open another issue over there.


poetryup selects newer package version than exists on PyPI

I am using Python 3.9 and Poetry 1.1.13 on macOS.
A minimal pyproject.toml:
[tool.poetry]
name = "poetry-test"
version = "0.1.0"
description = ""
authors = []

[tool.poetry.dependencies]
python = "^3.9"
uvicorn = { version = "^0.18.0", extras = ["standard"] }

[tool.poetry.dev-dependencies]
poetryup = "^0.8.1"

[build-system]
requires = ["poetry-core>=1.0.0"]
build-backend = "poetry.core.masonry.api"

Running
$ poetryup --latest
INFO:root:Updating dependencies to their latest version
Using version ^0.8.1 for poetryup

Updating dependencies
Resolving dependencies... (0.1s)

No dependencies to install or update
Resolving dependencies... (0.1s)

Writing lock file

Sets uvicorn to "^0.18.2"
[tool.poetry]
name = "poetry-test"
version = "0.1.0"
description = ""
authors = []

[tool.poetry.dependencies]
python = "^3.9"
uvicorn = { version = "^0.18.2", extras = ["standard"] }

[tool.poetry.dev-dependencies]
poetryup = "^0.8.1"

[build-system]
requires = ["poetry-core>=1.0.0"]
build-backend = "poetry.core.masonry.api"

But 0.18.2 doesn't exist on PyPI, so this seems quite strange: https://pypi.org/project/uvicorn/#history
Parts of poetry.lock that are relevant:
[[package]]
name = "uvicorn"
version = "0.18.2"
description = "The lightning-fast ASGI server."
category = "main"
optional = false
python-versions = ">=3.7"

...

uvicorn = [
    {file = "uvicorn-0.18.2-py3-none-any.whl", hash = "sha256:c19a057deb1c5bb060946e2e5c262fc01590c6529c0af2c3d9ce941e89bc30e0"},
    {file = "uvicorn-0.18.2.tar.gz", hash = "sha256:cade07c403c397f9fe275492a48c1b869efd175d5d8a692df649e6e7e2ed8f4e"},
]
...

Perhaps related to PyPI degraded performance?

https://status.python.org/incidents/l16ylxktn4r9

I don't think this is related to poetryup because it runs poetry commands in subprocesses to resolve packages. Could be related to the incident with PyPI mentioned above, it got resolved 2 hours ago.


Show the migration's file name when creating one

Pretty self-explanatory title :)
I searched the tests, and it appears that there are no tests for outputting to stdout. Thus, I didn't write it here as well. Please let me know if that's not the case.
Closes #138

Thanks!


feat: Add events to scale character

This PR refactors the adaptions for height changes to be tied to a new events: ScaleCharacterEvent.
Two events for slightly different sementics regarding the way an entity should be scaled:

ScaleByRequest(factor) an event to request that an entity should be scaled by the given factor. This is a semantic operation, and as such is consumable (to cancel the request).
ScaleToRequest(value) an event to request that an entity should be scaled to a given value. Again, this is a semantic operation and is consumable.

If the events are not cancelled, they'll eventually reach an event handler with low priority that "accepts" the request and turns it into a notification event for systems to react on:

OnScaleEvent(oldValue, newValue) is an immutable event that informs about a change. Systems should listen to this event in case they want to act upon scaling of characters.

This event is used by the debug command, and it is intended to be used by modules to trigger changes to a player's (or mob's) height. This could be a shrinking potion, or a magic effect.

There are some TODO comments in the code for follow-ups. Further adjustments to the functions for adjusting the values of the character component are also required.
These event also allow to react on scaling a character for more components, e.g., adjust the size of the floating cube in multiplayer, ...

Thinking even more about the way the event(s) are supposed be used I would like to propose the following.
Two events for slightly different sementics regarding the way an entity should be scaled:

ScaleByEvent(factor) to request or trigger that an entity should be scaled by the given factor. This is a semantic operation, and as such should be consumable (to cancel the request).
ScaleToEvent(value) to request that an entity should be scaled to a give value. Again, this is a semantic operation and should be consumable.

If the events are not cancelled, they'll eventually reach an event handler with low priority that "accepts" the request and turns it into a notification event for systems to react on:

ScaledEvent(oldValue, newValue) is an immutable event that informs about a change. Systems should listen to this event in case they want to act upon scaling of characters.

For instance, the GazeMountPointSystem will react by recalculating the mount point translation based on the new height. The CharacterSystem may adjust values such as speed or jump height by using the scaling factor.

The reason I'm over-engineering this slightly is because I would like understand how we envision the whole ECS to work with the game. I would like to establish best-practice patterns right in the engine and very core modules for reference.
The suggestion above takes different usages for the scaling event into account and tries to find a unified pattern that works well for all cases...
@jellysnake @Cervator @PS-Soundwave @pollend your input on this is highly appreciated!

are there some potential edge cases if we also have a third person camera or do we somehow split these two implementation in the logic. two separate systems with two separate ways to handle the view.

I managed to run this PR and everything seems to be in order. we should be pretty good in regards to merging this.

@skaldarnar - bit of a belated response here, but I wanted to add some more support for the idea of using events this way, marking it as a best practice 👍 Very much reminds me of what we did with the Health system, where healing effects can arise from multiple sources, get modified / cancelled, then eventually trigger an actual heal.


"type 1 conventional dendritic cell" is given as a synonym for "conventional dendritic cell", is that correct?

I am taking a look at duplicate CL mappings on Wikidata and stumbled upon this:
conventional dendritic cell
Go to external page http://purl.obolibrary.org/obo/CL_0000990
has exact synonym
DC1
cDC
type 1 DC
dendritic reticular cell
Is that correct?
It seems like "cDC" is a conceptually broader term (e.g. https://www.nature.com/subjects/myeloid-dendritic-cells) with some resources mentioning Type 2 CDCs (e.g. PMC9028336.
Maybe @addiehl can weigh in on that

The synonyms used for dendritic cells have shifted over the years.  "DC1" used to refer to conventional dendritic cells, and "DC2" used to refer to plasmacytoid dendritic cells. These are the synonyms that were captured in curation of the CL probably over a decade ago.  In recent years, different groups have started using DC1 and DC2 to refer to subtypes of conventional dendritic cells.  See issues #1026 and #1027 as well as #838 and #839.
As mentioned in earlier issues, we need to do a review of the dendritic cells to bring the representation in line with the current literature. I would like to do this, but have not found the time yet.


[nrf toup]: Improve existing clock control toup

Improves d875660a86418497a90e12185914eae902105e4c
With this change it is possible to share all configurations
related to CLOCK_CONTROL_NRF_K32SRC_RC_CALIBRATION without
including the clock calibration configurations.
Alternative temperature driver will be introduced with https://github.com/nrfconnect/sdk-nrf/pull/3022/
Ref: NCSIDB-180

Regarding our discussion on teams:
As I understand that the most desired situation is that the  d875660a86418497a90e12185914eae902105e4c would be squashed with this PR, but that would require reverting the d875660a86418497a90e12185914eae902105e4c  and bringing the changes that it introduces here.
The other possible solution would be to add information, into the commit message of this PR, that  commit from this PR, when passes to upstream, should be reverted with from NRF fork together with the d875660a86418497a90e12185914eae902105e4c .
I am in favor of not reverting and and on adding info to commit message.
@mbolivar What is your insight on this?

All checks passed.
checkpatch (informational only, not a failure)
-:80: WARNING:LONG_LINE: line length of 81 exceeds 80 columns
#80: FILE: drivers/clock_control/clock_control_nrf.c:584:
+		if (IS_ENABLED(CONFIG_CLOCK_CONTROL_NRF_K32SRC_RC_CALIBRATION) &&

-:88: WARNING:LONG_LINE: line length of 81 exceeds 80 columns
#88: FILE: drivers/clock_control/clock_control_nrf.c:591:
+		if (IS_ENABLED(CONFIG_CLOCK_CONTROL_NRF_K32SRC_RC_CALIBRATION) &&

- total: 0 errors, 2 warnings, 105 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

Your patch has style problems, please review.

NOTE: Ignored message types: AVOID_EXTERNS BRACES C99_COMMENT_TOLERANCE CONFIG_EXPERIMENTAL CONST_STRUCT DATE_TIME FILE_PATH_CHANGES MINMAX NETWORKING_BLOCK_COMMENT_STYLE PREFER_KERNEL_TYPES PREFER_SECTION PRINTK_WITHOUT_KERN_LEVEL REPEATED_WORD SPDX_LICENSE_TAG SPLIT_STRING VOLATILE

NOTE: If any of the errors are false positives, please report
      them to the maintainers.

Tip: The bot edits this comment instead of posting a new one, so you can check the comment's history to see earlier messages.

All checks passed.
checkpatch (informational only, not a failure)
-:80: WARNING:LONG_LINE: line length of 81 exceeds 80 columns
#80: FILE: drivers/clock_control/clock_control_nrf.c:584:
+		if (IS_ENABLED(CONFIG_CLOCK_CONTROL_NRF_K32SRC_RC_CALIBRATION) &&

-:88: WARNING:LONG_LINE: line length of 81 exceeds 80 columns
#88: FILE: drivers/clock_control/clock_control_nrf.c:591:
+		if (IS_ENABLED(CONFIG_CLOCK_CONTROL_NRF_K32SRC_RC_CALIBRATION) &&

- total: 0 errors, 2 warnings, 105 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

Your patch has style problems, please review.

NOTE: Ignored message types: AVOID_EXTERNS BRACES C99_COMMENT_TOLERANCE CONFIG_EXPERIMENTAL CONST_STRUCT DATE_TIME FILE_PATH_CHANGES MINMAX NETWORKING_BLOCK_COMMENT_STYLE PREFER_KERNEL_TYPES PREFER_SECTION PRINTK_WITHOUT_KERN_LEVEL REPEATED_WORD SPDX_LICENSE_TAG SPLIT_STRING VOLATILE

NOTE: If any of the errors are false positives, please report
      them to the maintainers.

Tip: The bot edits this comment instead of posting a new one, so you can check the comment's history to see earlier messages.

Regarding our discussion on teams:
As I understand that the most desired situation is that the d875660 would be squashed with this PR, but that would require reverting the d875660 and bringing the changes that it introduces here.
The other possible solution would be to add information, into the commit message of this PR, that commit from this PR, when passes to upstream, should be reverted with from NRF fork together with the d875660 .
I am in favor of not reverting and and on adding info to commit message.
@mbolivar What is your insight on this?

@mbolivar-nordic , can you provide some insight here?

Regarding our discussion on teams:
As I understand that the most desired situation is that the d875660 would be squashed with this PR, but that would require reverting the d875660 and bringing the changes that it introduces here.
The other possible solution would be to add information, into the commit message of this PR, that commit from this PR, when passes to upstream, should be reverted with from NRF fork together with the d875660 .
I am in favor of not reverting and and on adding info to commit message.
@mbolivar What is your insight on this?

@mbolivar-nordic , can you provide some insight here?

@de-nordic 's summary is correct in the two options.
It's just a matter of when you want the job done, and by whom. If you revert d875660 and merge its changes into this PR, then tools like west ncs-loot will know that d875660 is "gone" from the logical set of out of tree patches we are currently carrying.
I am the one who rebases our out of tree NCS patches into a linear history when NCS heads towards a release (the fact that we rebase is documented in https://developer.nordicsemi.com/nRF_Connect_SDK/doc/latest/nrf/dm_code_base.html#oss-repositories-downstream-project-history).
The way I do this uses west ncs-loot, so if you revert+reapply, it means less work for me and less work to do during release time.
If you just stack it on top and add commit messages, I will read them and do the squashing manually at release time.
Whatever you choose is fine with me; if you don't revert, please do write clear instructions.

@de-nordic 's summary is correct in the two options.
It's just a matter of when you want the job done, and by whom. If you revert d875660 and merge its changes into this PR, then tools like west ncs-loot will know that d875660 is "gone" from the logical set of out of tree patches we are currently carrying.
I am the one who rebases our out of tree NCS patches into a linear history when NCS heads towards a release (the fact that we rebase is documented in https://developer.nordicsemi.com/nRF_Connect_SDK/doc/latest/nrf/dm_code_base.html#oss-repositories-downstream-project-history).
The way I do this uses west ncs-loot, so if you revert+reapply, it means less work for me and less work to do during release time.
If you just stack it on top and add commit messages, I will read them and do the squashing manually at release time.
Whatever you choose is fine with me; if you don't revert, please do write clear instructions.

All checks passed.
checkpatch (informational only, not a failure)
-:80: WARNING:LONG_LINE: line length of 81 exceeds 80 columns
#80: FILE: drivers/clock_control/clock_control_nrf.c:584:
+		if (IS_ENABLED(CONFIG_CLOCK_CONTROL_NRF_K32SRC_RC_CALIBRATION) &&

-:88: WARNING:LONG_LINE: line length of 81 exceeds 80 columns
#88: FILE: drivers/clock_control/clock_control_nrf.c:591:
+		if (IS_ENABLED(CONFIG_CLOCK_CONTROL_NRF_K32SRC_RC_CALIBRATION) &&

- total: 0 errors, 2 warnings, 105 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

Your patch has style problems, please review.

NOTE: Ignored message types: AVOID_EXTERNS BRACES C99_COMMENT_TOLERANCE CONFIG_EXPERIMENTAL CONST_STRUCT DATE_TIME FILE_PATH_CHANGES MINMAX NETWORKING_BLOCK_COMMENT_STYLE PREFER_KERNEL_TYPES PREFER_SECTION PRINTK_WITHOUT_KERN_LEVEL REPEATED_WORD SPDX_LICENSE_TAG SPLIT_STRING VOLATILE

NOTE: If any of the errors are false positives, please report
      them to the maintainers.

Tip: The bot edits this comment instead of posting a new one, so you can check the comment's history to see earlier messages.

All checks passed.
checkpatch (informational only, not a failure)
-:80: WARNING:LONG_LINE: line length of 81 exceeds 80 columns
#80: FILE: drivers/clock_control/clock_control_nrf.c:584:
+		if (IS_ENABLED(CONFIG_CLOCK_CONTROL_NRF_K32SRC_RC_CALIBRATION) &&

-:88: WARNING:LONG_LINE: line length of 81 exceeds 80 columns
#88: FILE: drivers/clock_control/clock_control_nrf.c:591:
+		if (IS_ENABLED(CONFIG_CLOCK_CONTROL_NRF_K32SRC_RC_CALIBRATION) &&

- total: 0 errors, 2 warnings, 105 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

Your patch has style problems, please review.

NOTE: Ignored message types: AVOID_EXTERNS BRACES C99_COMMENT_TOLERANCE CONFIG_EXPERIMENTAL CONST_STRUCT DATE_TIME FILE_PATH_CHANGES MINMAX NETWORKING_BLOCK_COMMENT_STYLE PREFER_KERNEL_TYPES PREFER_SECTION PRINTK_WITHOUT_KERN_LEVEL REPEATED_WORD SPDX_LICENSE_TAG SPLIT_STRING VOLATILE

NOTE: If any of the errors are false positives, please report
      them to the maintainers.

Tip: The bot edits this comment instead of posting a new one, so you can check the comment's history to see earlier messages.

Reverted the commit this PR intends to improve and rebased on master

Reverted the commit this PR intends to improve and rebased on master

Some checks failed. Please fix and resubmit.
checkpatch (informational only, not a failure)
-:106: WARNING:LONG_LINE: line length of 81 exceeds 80 columns
#106: FILE: drivers/clock_control/clock_control_nrf.c:604:
+		if (IS_ENABLED(CONFIG_CLOCK_CONTROL_NRF_K32SRC_RC_CALIBRATION) &&

-:114: WARNING:LONG_LINE: line length of 81 exceeds 80 columns
#114: FILE: drivers/clock_control/clock_control_nrf.c:611:
+		if (IS_ENABLED(CONFIG_CLOCK_CONTROL_NRF_K32SRC_RC_CALIBRATION) &&

- total: 0 errors, 2 warnings, 130 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

Your patch has style problems, please review.

NOTE: Ignored message types: AVOID_EXTERNS BRACES C99_COMMENT_TOLERANCE CONFIG_EXPERIMENTAL CONST_STRUCT DATE_TIME FILE_PATH_CHANGES MINMAX NETWORKING_BLOCK_COMMENT_STYLE PREFER_KERNEL_TYPES PREFER_SECTION PRINTK_WITHOUT_KERN_LEVEL REPEATED_WORD SPDX_LICENSE_TAG SPLIT_STRING VOLATILE

NOTE: If any of the errors are false positives, please report
      them to the maintainers.

Identity/Emails issues
76b605e41c60d33b9557c74bef1c24e73a786a99: author email (Rubin Gerritsen<EMAIL_ADDRESS>needs to match one of the signed-off-by entries.
Tip: The bot edits this comment instead of posting a new one, so you can check the comment's history to see earlier messages.

Some checks failed. Please fix and resubmit.
checkpatch (informational only, not a failure)
-:106: WARNING:LONG_LINE: line length of 81 exceeds 80 columns
#106: FILE: drivers/clock_control/clock_control_nrf.c:604:
+		if (IS_ENABLED(CONFIG_CLOCK_CONTROL_NRF_K32SRC_RC_CALIBRATION) &&

-:114: WARNING:LONG_LINE: line length of 81 exceeds 80 columns
#114: FILE: drivers/clock_control/clock_control_nrf.c:611:
+		if (IS_ENABLED(CONFIG_CLOCK_CONTROL_NRF_K32SRC_RC_CALIBRATION) &&

- total: 0 errors, 2 warnings, 130 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

Your patch has style problems, please review.

NOTE: Ignored message types: AVOID_EXTERNS BRACES C99_COMMENT_TOLERANCE CONFIG_EXPERIMENTAL CONST_STRUCT DATE_TIME FILE_PATH_CHANGES MINMAX NETWORKING_BLOCK_COMMENT_STYLE PREFER_KERNEL_TYPES PREFER_SECTION PRINTK_WITHOUT_KERN_LEVEL REPEATED_WORD SPDX_LICENSE_TAG SPLIT_STRING VOLATILE

NOTE: If any of the errors are false positives, please report
      them to the maintainers.

Identity/Emails issues
76b605e41c60d33b9557c74bef1c24e73a786a99: author email (Rubin Gerritsen<EMAIL_ADDRESS>needs to match one of the signed-off-by entries.
Tip: The bot edits this comment instead of posting a new one, so you can check the comment's history to see earlier messages.

Added sign-off in the revert-commit

Added sign-off in the revert-commit

All checks passed.
checkpatch (informational only, not a failure)
-:106: WARNING:LONG_LINE: line length of 81 exceeds 80 columns
#106: FILE: drivers/clock_control/clock_control_nrf.c:604:
+		if (IS_ENABLED(CONFIG_CLOCK_CONTROL_NRF_K32SRC_RC_CALIBRATION) &&

-:114: WARNING:LONG_LINE: line length of 81 exceeds 80 columns
#114: FILE: drivers/clock_control/clock_control_nrf.c:611:
+		if (IS_ENABLED(CONFIG_CLOCK_CONTROL_NRF_K32SRC_RC_CALIBRATION) &&

- total: 0 errors, 2 warnings, 130 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

Your patch has style problems, please review.

NOTE: Ignored message types: AVOID_EXTERNS BRACES C99_COMMENT_TOLERANCE CONFIG_EXPERIMENTAL CONST_STRUCT DATE_TIME FILE_PATH_CHANGES MINMAX NETWORKING_BLOCK_COMMENT_STYLE PREFER_KERNEL_TYPES PREFER_SECTION PRINTK_WITHOUT_KERN_LEVEL REPEATED_WORD SPDX_LICENSE_TAG SPLIT_STRING VOLATILE

NOTE: If any of the errors are false positives, please report
      them to the maintainers.

Tip: The bot edits this comment instead of posting a new one, so you can check the comment's history to see earlier messages.

All checks passed.
checkpatch (informational only, not a failure)
-:106: WARNING:LONG_LINE: line length of 81 exceeds 80 columns
#106: FILE: drivers/clock_control/clock_control_nrf.c:604:
+		if (IS_ENABLED(CONFIG_CLOCK_CONTROL_NRF_K32SRC_RC_CALIBRATION) &&

-:114: WARNING:LONG_LINE: line length of 81 exceeds 80 columns
#114: FILE: drivers/clock_control/clock_control_nrf.c:611:
+		if (IS_ENABLED(CONFIG_CLOCK_CONTROL_NRF_K32SRC_RC_CALIBRATION) &&

- total: 0 errors, 2 warnings, 130 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

Your patch has style problems, please review.

NOTE: Ignored message types: AVOID_EXTERNS BRACES C99_COMMENT_TOLERANCE CONFIG_EXPERIMENTAL CONST_STRUCT DATE_TIME FILE_PATH_CHANGES MINMAX NETWORKING_BLOCK_COMMENT_STYLE PREFER_KERNEL_TYPES PREFER_SECTION PRINTK_WITHOUT_KERN_LEVEL REPEATED_WORD SPDX_LICENSE_TAG SPLIT_STRING VOLATILE

NOTE: If any of the errors are false positives, please report
      them to the maintainers.

Tip: The bot edits this comment instead of posting a new one, so you can check the comment's history to see earlier messages.

All checks passed.
checkpatch (informational only, not a failure)
-:96: WARNING:LONG_LINE: line length of 81 exceeds 80 columns
#96: FILE: drivers/clock_control/clock_control_nrf.c:604:
+		if (IS_ENABLED(CONFIG_CLOCK_CONTROL_NRF_K32SRC_RC_CALIBRATION) &&

-:104: WARNING:LONG_LINE: line length of 81 exceeds 80 columns
#104: FILE: drivers/clock_control/clock_control_nrf.c:611:
+		if (IS_ENABLED(CONFIG_CLOCK_CONTROL_NRF_K32SRC_RC_CALIBRATION) &&

- total: 0 errors, 2 warnings, 121 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

Your patch has style problems, please review.

NOTE: Ignored message types: AVOID_EXTERNS BRACES C99_COMMENT_TOLERANCE CONFIG_EXPERIMENTAL CONST_STRUCT DATE_TIME FILE_PATH_CHANGES MINMAX NETWORKING_BLOCK_COMMENT_STYLE PREFER_KERNEL_TYPES PREFER_SECTION PRINTK_WITHOUT_KERN_LEVEL REPEATED_WORD SPDX_LICENSE_TAG SPLIT_STRING VOLATILE

NOTE: If any of the errors are false positives, please report
      them to the maintainers.

Tip: The bot edits this comment instead of posting a new one, so you can check the comment's history to see earlier messages.

All checks passed.
checkpatch (informational only, not a failure)
-:96: WARNING:LONG_LINE: line length of 81 exceeds 80 columns
#96: FILE: drivers/clock_control/clock_control_nrf.c:604:
+		if (IS_ENABLED(CONFIG_CLOCK_CONTROL_NRF_K32SRC_RC_CALIBRATION) &&

-:104: WARNING:LONG_LINE: line length of 81 exceeds 80 columns
#104: FILE: drivers/clock_control/clock_control_nrf.c:611:
+		if (IS_ENABLED(CONFIG_CLOCK_CONTROL_NRF_K32SRC_RC_CALIBRATION) &&

- total: 0 errors, 2 warnings, 121 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

Your patch has style problems, please review.

NOTE: Ignored message types: AVOID_EXTERNS BRACES C99_COMMENT_TOLERANCE CONFIG_EXPERIMENTAL CONST_STRUCT DATE_TIME FILE_PATH_CHANGES MINMAX NETWORKING_BLOCK_COMMENT_STYLE PREFER_KERNEL_TYPES PREFER_SECTION PRINTK_WITHOUT_KERN_LEVEL REPEATED_WORD SPDX_LICENSE_TAG SPLIT_STRING VOLATILE

NOTE: If any of the errors are false positives, please report
      them to the maintainers.

Tip: The bot edits this comment instead of posting a new one, so you can check the comment's history to see earlier messages.

Hi @rugeGerritsen ,

Reverted the commit this PR intends to improve and rebased on master

This was not a clean revert; please don't do it like this in the future.
Any revert needs to be conflict-free; do not resolve conflicts in the revert commit. If you manually resolve conflicts, it breaks our scripts. That happened in this case.

But what I actually get is a conflict:
$ git revert d875660a86418497a90e12185914eae902105e4c
Auto-merging drivers/clock_control/Kconfig.nrf
CONFLICT (content): Merge conflict in drivers/clock_control/Kconfig.nrf
error: could not revert d875660a86... [nrf toup] drivers: clock_control: nrf: Change CLOCK_CONTROL_NRF_FORCE_A

The manual resolution of the conflict is tricking west ncs-loot into giving misleading output, which in turn requires extra manual steps in preparing a clean rebase of our out of tree patches.
TL;DR: next time if the revert is not clean, please don't resolve conflicts manually. Feel free to PM me off GitHub if you want more details on what to do instead and other rationale.

Hi @rugeGerritsen ,

Reverted the commit this PR intends to improve and rebased on master

This was not a clean revert; please don't do it like this in the future.
Any revert needs to be conflict-free; do not resolve conflicts in the revert commit. If you manually resolve conflicts, it breaks our scripts. That happened in this case.

But what I actually get is a conflict:
$ git revert d875660a86418497a90e12185914eae902105e4c
Auto-merging drivers/clock_control/Kconfig.nrf
CONFLICT (content): Merge conflict in drivers/clock_control/Kconfig.nrf
error: could not revert d875660a86... [nrf toup] drivers: clock_control: nrf: Change CLOCK_CONTROL_NRF_FORCE_A

The manual resolution of the conflict is tricking west ncs-loot into giving misleading output, which in turn requires extra manual steps in preparing a clean rebase of our out of tree patches.
TL;DR: next time if the revert is not clean, please don't resolve conflicts manually. Feel free to PM me off GitHub if you want more details on what to do instead and other rationale.

@rugeGerritsen Could you please send this PR upstream?

@rugeGerritsen Could you please send this PR upstream?


First pass at adding napari reader

This adds the napari reader as an optional napari plugin to this package. This is entireley optional, and I've configured most of the tests to check that the btrack can still be run fine without napari installed. To check that the optional napari bits work there is now an extra tox environment that runs the tests with napari installed. I've also added some docs on how users can install the dependencies needed for the napari plugin.
I anticipate we will add btrack-napari in a similar way in a separate PR in the future.
Fixes https://github.com/lowe-lab-ucl/napari-btrack/issues/7
Fixes https://github.com/lowe-lab-ucl/napari-btrack-reader/issues/3
TODO:

Add napari plugin GH bot
Add .napari
Work out how to deprecate and remove the original plugin napari-btrack-reader from the napari hub once this PR is merged and in a btrack release

Codecov Report

Merging #115 (9113c3f) into main (2d2c8bf) will increase coverage by 75.71%.
The diff coverage is 51.42%.

@@            Coverage Diff             @@
##            main     #115       +/-   ##
==========================================
+ Coverage   0.00%   75.71%   +75.71%
==========================================
  Files         12       14        +2
  Lines       1440     1478       +38
==========================================
+ Hits           0     1119     +1119
+ Misses      1440      359     -1081

Impacted Files
Coverage Δ

btrack/napari/reader.py
43.33% <43.33%> (ø)

btrack/napari/tests/test_btrack_reader.py
100.00% <100.00%> (ø)

btrack/datasets.py
58.82% <0.00%> (+58.82%)
:arrow_up:

btrack/dataio.py
63.02% <0.00%> (+63.02%)
:arrow_up:

btrack/utils.py
70.19% <0.00%> (+70.19%)
:arrow_up:

btrack/_localization.py
71.42% <0.00%> (+71.42%)
:arrow_up:

btrack/core.py
76.02% <0.00%> (+76.02%)
:arrow_up:

btrack/btypes.py
81.97% <0.00%> (+81.97%)
:arrow_up:

btrack/optimise/optimiser.py
82.14% <0.00%> (+82.14%)
:arrow_up:

btrack/models.py
89.58% <0.00%> (+89.58%)
:arrow_up:

... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2d2c8bf...9113c3f. Read the comment docs.

could you install the napari-hub preview app on this repository

Should be done now.

I have addressed the comments in the PR since I've reviewed so going to merge


ModuleNotFoundError: No module named 'bs4'

Any idea why I get this when I try to run the script?:
line 11, in
from bs4 import BeautifulSoup
ModuleNotFoundError: No module named 'bs4'

Sorry, I'm new at this.

You need to run pip install beautifulsoup4 from your commandline.
More instructions here:
https://pypi.org/project/beautifulsoup4/

thank you for your response. I installed beautifulsoup4 as per you instructions but it said "Requirement already satisfied" and when I ran the script again, it gave the same error message:


Enhances spo lisitem set, Closes #4167

This PR enhances spo listitem set, resolving the bug when trying to update multiple fields with systemUpdate.
Closes #4167

Thank you for the PR :clap:

merged manually


Support Fastify v5

Preliminary Checks

[X] I have reviewed the documentation: https://clerk.com/docs

[X] I have searched for existing issues: https://github.com/clerk/javascript/issues

[X] I have not already reached out to Clerk support via email or Discord (if you have, no need to open an issue here)

[X] This issue is not a question, general help request, or anything other than a bug report directly related to Clerk. Please ask questions in our Discord community: https://clerk.com/discord.

Reproduction

Publishable key
pk_test_Zml0dGluZy15YWstOTguY2xlcmsuYWNjb3VudHMuZGV2JA
Description
When installing fastify v5, the backend immediately crashes with the following error:
[08:51:11 UTC] ERROR: fastify-plugin: @clerk/fastify - expected '4.x' fastify version, '5.0.0' is installed
    err: {
      "type": "FastifyError",
      "message": "fastify-plugin: @clerk/fastify - expected '4.x' fastify version, '5.0.0' is installed",
      "stack":
          FastifyError: fastify-plugin: @clerk/fastify - expected '4.x' fastify version, '5.0.0' is installed
      "code": "FST_ERR_PLUGIN_VERSION_MISMATCH",
      "name": "FastifyError",
      "statusCode": 500
    }

Environment
-

Having the same issue

Hi, thanks for the issue. The error comes from https://github.com/clerk/javascript/blob/c49eaa7f3ab791c38b8a1dfebb3a05e21c29dfc4/packages/fastify/src/clerkPlugin.ts#L26-L29 so it's expected to happen. Currently the plugin is only compatible with Fastify v4.
The migration guide is here for reference: https://fastify.dev/docs/latest/Guides/Migration-Guide-V5/
For example, they now require Node.js 20 whereas the Clerk package allows 18.17.0 or later. So we'll need to cut a new major version in doing this upgrade. We'll work on it 👍

Support for Fastify v5 has been added in<EMAIL_ADDRESS>Please note that it's not backwards-compatible with Fastify v4, you will have to use Fastify v5.


Not building, help me, i'm completely a newbee

Getting this after running /bin/gbuild --commit dash=v0.12.0.x ../dash/contrib/gitian-descriptors/gitian-win.yml
`--- Building for trusty amd64 ---
Stopping target if it is up
Making a new image copy
sudo: unable to resolve host gitian
stdin: is not a tty
Reading package lists... Done
Building dependency tree... Done
The following packages will be REMOVED:
rsyslog ubuntu-minimal
0 upgraded, 0 newly installed, 2 to remove and 0 not upgraded.
After this operation, 1639 kB disk space will be freed.
(Reading database ... 16661 files and directories currently installed.)
Removing ubuntu-minimal (1.325) ...
Removing rsyslog (7.4.4-1ubuntu2) ...
initctl: Unable to connect to Upstart: Failed to connect to socket /com/ubuntu/upstart: Connection refused

Stopping enhanced syslogd rsyslogd
...done.
Adding 'local diversion of /sbin/initctl to /sbin/initctl.distrib'
Adding 'local diversion of /usr/bin/ischroot to /usr/bin/ischroot.distrib'
Adding 'local diversion of /usr/sbin/policy-rc.d to /usr/sbin/policy-rc.d.distrib'
Starting target
Checking if target is up
Preparing build environment
Updating apt-get repository (log in var/install.log)
Installing additional packages (log in var/install.log)
Upgrading system, may take a while
Creating package manifest
stdin: is not a tty
Creating build script (var/build-script)
Running build script (log in var/build.log)
./bin/gbuild:21:in system!': failed to run on-target setarch x86_64 bash -x < var/build-script > var/build.log 2>&1 (RuntimeError)      from ./bin/gbuild:149:in build_one_configuration'
from ./bin/gbuild:285:in block (2 levels) in <main>'      from ./bin/gbuild:280:in each'
from ./bin/gbuild:280:in block in <main>'      from ./bin/gbuild:278:in each'
from ./bin/gbuild:278:in <main>'

Getting this after running /bin/gbuild --commit dash=v0.12.0.x ../dash/contrib/gitian-descriptors/gitian-win.yml

try v0.12.1.x


Remove a phrase in the frontpage.

Hi, I just found this programming language and I'm really liking it
While reading the website, I found this phrase: No nazi bullsh*t in the front page, and I think it should be removed it.
As a newcomer It doesn't look good having cursing and the word nazi in the front page.
I think it goes against the meaning of being Friendly 💜 and because web indexing, the website could be ended related to that. I think it is better just stay away from that word

Hello! Thanks for your input! The wording on the homepage is carefully considered and is not changing at the present time.


New version: ImageMetadata v0.7.3

Registering package: ImageMetadata
Repository: https://github.com/JuliaImages/ImageMetadata.jl
Created by: @timholy
Version: v0.7.3
Commit: bca15e610204429e672829f2f2f9b9b84c504629
Reviewed by: @timholy
Reference: https://github.com/JuliaImages/ImageMetadata.jl/commit/bca15e610204429e672829f2f2f9b9b84c504629#commitcomment-36606257

Superseded by #7303, please close.


Updates for elasticsearch 2.0

 All committers of the pull request should sign our Contributor License Agreement in order to get your pull request merged.1 out of 2 committers have signed the CLA.:white_check_mark: niemyjski:x: yetanotherchris

Closing this pr as we will be migration to elastic search 5.x


Entity Facet doesn't show selection (when logged in)

This issue occurs infrequently, but I was able to see it one time today. Login first and then close this browser tab to prevent any caching.
https://dev.gudmap.org/chaise/recordset/#2/RNASeq:Replicate
Make sure you are logged in before navigating to this page with facets:
https://dev.gudmap.org/chaise/recordset/#2/RNASeq:Replicate/*::facets::N4IghgdgJiBcDaoDOB7ArgJwMYFM6JHQBcAjdafEAJQDkBBAZRwEcQAaanABwBsBLLGCI4A+gy44sfALY4IIqgEkAIiIBmAaxwBPEAF0AvhyXL9HLAAsUAnEkoBGAGwBaAMwBRALIBxfQcNAA@sort(RMT::desc::,RCT::desc::,RID)
What happens is a term is selected in the Specimen facet, but it's out of view. You can see a filter present that shows that selection is made.
This issue was first found on production, I pasted links to dev to be safe. I was able to reproduce on dev once, but more frequently on production.

Image of me replicating on dev:

Once the view is this way, you can search RBK and the option in the facet will be moved to the top of the list where it will remain even after the search box is cleared again.

This has been resolved. Assigning to @jrchudy for verification.

I can't reproduce this issue anymore after loading from cache and turning off the cache. Closing this issue.


Fix REPL completions

Fix #4178 Live completions in REPL not working
Fix REPL completions not respecting the "live completions only" option and not synchronizing the buffer.

It's a lot more reliable :)
Duplicated items in the results from analysis/live completions, but I'll take that over the previous unreliability.

I can fix that - the comparison is just using display name, but we should really check both display name and completion for equality.

Though in this case, it's not actually correct, since the current value is the datetime module which does not have that member. But that problem won't go away quite as easily (we'd need to carefully break analysis between REPL entries)


[core] Use GitHub issue forms

This is a continuation of https://github.com/mui-org/material-ui-x/pull/2468, with 3 major differences:

No order ID, it's only useful for the Pro features, not the MIT ones
No "Pro plan: support", it's for filling the whole the community can't fill on StackOverflow for commercial software
Removed the "Material Design" issue template, from what I understand, it was added in anticipation for need of the Google Material Design's team, they didn't use it in a year. I think that we can be lazy on this one. I would also challenge the new for a dedicated issue workflow, i.e. why the existing templates & free forms aren't good enough. (At the very least, the "material design system" label we try to add doesn't exist, we would need to fix this)

You can preview how it feels like on https://github.com/mui-org/material-ui-x/issues/new/choose.

It's missing a field for "Your environment" i.e. npx @material-ui/envinfo

Oops, where did it go? I have done something wrong, somewhere. Thanks for raising.

issue templates

It's in beta, maybe we should wait a week or so on MUI X to see how it goes before moving forward?

It's in beta, maybe we should wait a week or so on MUI X to see how it goes before moving forward here?

I would support that (especially considering the v5 timeline). I remember nextjs having broken issue templates that prevented opening an issue and I don't want that to happen here (https://github.com/vercel/next.js/discussions/24244).

@oliviertassinari  I would like to see this merged and just keep the old issue template around. We can add a description that one can use the old template if the form isn't working.

@eps1lon This PRs enable the blank issue form, would it be enough?

Which means in case of breakage the experience is degraded. Let's restore the old issue template for a couple of months. We'll see if this is problematic or not.

Let's restore the old issue template for a couple of months.

@eps1lon I'm not following the proposal. By restoring, do you mean in the git diff, keeping them? Do you know what will be the behavior in GitHub? I can think of three different outcomes:

GitHub will ignore the .md files (no effect)
GitHub will only take the .md file if .yml is broken (best case scenario)
GitHub will duplicate the issue options (confusing)

Sometimes, we link the issue template directly, to update, e.g. https://github.com/mui-org/material-ui/issues/new?assignees=&labels=status%3A+needs+triage&template=1.bug.md

No order ID, it's only useful for the Pro features, not the MIT ones

Well, coincidentally, this relates to my comments about the pricing page. That suggests that "premium" (or "priority" with the suggested revision) support is included for everything with Pro.

Well, coincidentally, this relates to my comments about the pricing page. That suggests that "premium" (or "priority" with the suggested revision) support is included for everything with Pro.

@mbrookes Agree, it's confusing, to fix.

Alright, it matches almost exactly with what MUI X uses.


MOBILE-1796 core: Updated to NodeJS v6.9.1

Supports building on NodeJS v6.9.1.
Had to replace ionic plugin cordova-plugin-local-notifications-mm with de.appplant.cordova.plugin.local-notification in order to make it buildable, but they appear to be the same as the previous one was a fork of the original plugin. de.appplant.cordova.plugin.local-notification was also previously used.

Dear,
@martinmine - I must download first the master one then i modify these files right?
Regards,

@martinmine - i got errors on ionic serve
$ ionic serve
TypeError: Cannot read property 'hasOwnProperty' of undefined
at Object.runr (C:\Users\MELAS\AppData\Roaming\npm\node_modules\ionic\lib\cli.js:191:19)
at C:\Users\MELAS\AppData\Roaming\npm\node_modules\ionic\lib\cli.js:54:9
at _fulfilled (C:\Users\MELAS\AppData\Roaming\npm\node_modules\ionic\node_modules\q\q.js:787:54)
at self.promiseDispatch.done (C:\Users\MELAS\AppData\Roaming\npm\node_modules\ionic\node_modules\q\q.js:816:30)
at Promise.promise.promiseDispatch (C:\Users\MELAS\AppData\Roaming\npm\node_modules\ionic\node_modules\q\q.js:749:13)
at C:\Users\MELAS\AppData\Roaming\npm\node_modules\ionic\node_modules\q\q.js:557:44
at flush (C:\Users\MELAS\AppData\Roaming\npm\node_modules\ionic\node_modules\q\q.js:108:17)
at _combinedTickCallback (internal/process/next_tick.js:67:7)
at process._tickCallback (internal/process/next_tick.js:98:9)
Cannot read property 'hasOwnProperty' of undefined (CLI v2.1.7)
Your system information:
ordova CLI: 6.4.0
Ionic CLI Version: 2.1.7
Ionic App Lib Version: 2.1.4
ios-deploy version: Not installed
ios-sim version: Not installed
OS: Windows 7
Node Version: v6.9.1
Xcode version: Not installed

Clone the Overwork repo then checkout on the MOBILE-1796 branch. I'm getting the same error message as of yesterday on an isolated test environment. It might be related to a missing Android SDK, I will try it out more later tomorrow and get back to you.

@MELAS007 you can try with Ionic CLI v. 2.1.1 as this is currently working fine on my setup. Run npm install<EMAIL_ADDRESS>then run ionic state restore again. This seems to be a known issue with Ionic CLI.

@martinmine - I am trying now and I will let you know
Thanks
On Sat, Nov 12, 2016 at 1:07 PM, martinmine<EMAIL_ADDRESS>wrote:

@MELAS007 https://github.com/MELAS007 you can try with Ionic CLI v.
2.1.1 as this is currently working fine on my setup. Run npm install
<EMAIL_ADDRESS>then run ionic state restore again. This seems to be a known
issue with Ionic CLI. https://github.com/driftyco/ionic-cli/issues/1648
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/moodlehq/moodlemobile2/pull/698#issuecomment-260115737,
or mute the thread
https://github.com/notifications/unsubscribe-auth/APuBAhvMXME5GrsRTQ_s_lkQYPJIbYjtks5q9Z3kgaJpZM4KcVvi
.

@martinmine - Thank you very much, It works. but I have a question : why cordova icons isn't changed to my icons... i did "ionic resources" it changed all and also in config.xml is with the correct path but it is still cordova icons...
Could you tell me how can i do this?

@MELAS007 you should ask somewhere else as this thread is for this pull request, not upgrading to Firebase from GCM. I advice you to look around on Google's resources and StackOverflow for advice on this.

Hi Martin,
I have ionic version 2.1.17, npm 4.0.5 and node 6.9.2 . It doesn't work...
$ cordova platform add android
Adding android project...
Creating Cordova project for the Android platform:
Path: platforms\android
Package: com.moodle.moodlemobile
Name: Moodle_Mobile
Activity: MainActivity
Android target: android-24
Subproject Path: CordovaLib
Android project created with<EMAIL_ADDRESS>Running command: "C:\Program Files (x86)\nodejs\node.exe" "D:\Mobile
apps\moodlemobile2-3.1.3\hooks\after_prepare\010_add_platform_class.js"
"D:/Mobile apps/moodlemobile2-3.1.3"
add to body class: platform-android
Running command: "C:\Program Files (x86)\nodejs\node.exe" "D:\Mobile
apps\moodlemobile2-3.1.3\hooks\after_prepare\020_add_ios_transport_security.js"
"D:/Mobile apps/moodlemobile2-3.1.3"
module.js:471
throw err;
^
Error: Cannot find module 'plist'
at Function.Module._resolveFilename (module.js:469:15)
at Function.Module._load (module.js:417:25)
at Module.require (module.js:497:17)
at require (internal/module.js:20:19)
at Object. (D:\Mobile
apps\moodlemobile2-3.1.3\hooks\after_prepare\020_add_ios_transport_security.js:10:13)
at Module._compile (module.js:570:32)
at Object.Module._extensions..js (module.js:579:10)
at Module.load (module.js:487:32)
at tryModuleLoad (module.js:446:12)
at Function.Module._load (module.js:438:3)
Error: Hook failed with error code 1: D:\Mobile
apps\moodlemobile2-3.1.3\hooks\after_prepare\020_add_ios_transport_security.js
and in ionic serve -l got blank !
any help will be appreciated
MELAS007
On Mon, Nov 14, 2016 at 1:57 PM, martinmine<EMAIL_ADDRESS>wrote:

@MELAS007 https://github.com/MELAS007 you should ask somewhere else as
this thread is for this pull request, not upgrading to Firebase from GCM. I
advice you to look around on Google's resources and StackOverflow for
advice on this.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/moodlehq/moodlemobile2/pull/698#issuecomment-260317416,
or mute the thread
https://github.com/notifications/unsubscribe-auth/APuBAsUPQ-Iz9HQ4krQwJf8o7w9r6uArks5q-EzDgaJpZM4KcVvi
.

@MELAS007 did you apply the version change for appium as specified in this pr?

Sorry I don't understand what you mean?
On 11 Jan 2017 21:46, "martinmine"<EMAIL_ADDRESS>wrote:

@MELAS007 https://github.com/MELAS007 did you apply the version change
for appium as specified in this
https://github.com/moodlehq/moodlemobile2/pull/709 pr?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/moodlehq/moodlemobile2/pull/698#issuecomment-271973860,
or mute the thread
https://github.com/notifications/unsubscribe-auth/APuBAjilZfLverQVhCu-10BZQjkeu2hKks5rRTGFgaJpZM4KcVvi
.

Apply the changes in the pull request I linked, then clean and try build the project again.

Where is the link?
On 11 Jan 2017 22:40, "martinmine"<EMAIL_ADDRESS>wrote:

Apply the changes in the pull request I linked, then clean and try build
the project again.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/moodlehq/moodlemobile2/pull/698#issuecomment-271987529,
or mute the thread
https://github.com/notifications/unsubscribe-auth/APuBAsv_QF805XnN-5Gx2T9RCtxgBAXOks5rRT5ZgaJpZM4KcVvi
.

I already linked the PR in my previous comment... However, I will leave it here as it may be a bit hard to see the links on GitHub.

Thanks but I am not using appium...
On 11 Jan 2017 22:45, "martinmine"<EMAIL_ADDRESS>wrote:

I already linked the PR in my previous comment... However, I will leave it
here https://github.com/moodlehq/moodlemobile2/pull/709 as it may be a
bit hard to see the links on GitHub.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/moodlehq/moodlemobile2/pull/698#issuecomment-271988618,
or mute the thread
https://github.com/notifications/unsubscribe-auth/APuBAnXfL6vDraRctzSPggah3euqxsXfks5rRT9RgaJpZM4KcVvi
.

@martinmine - i got errors after modifying this: <1.6.0 to appium.
MELAS@MELAS-PC MINGW64 /d/Mobile apps/moodlemobile2-3.2.0
$ npm install
npm WARN package.json<EMAIL_ADDRESS>No repository field.
npm WARN deprecated<EMAIL_ADDRESS>Please use gulp-clean-css
npm ERR! Windows_NT 6.1.7601
npm ERR! argv "C:\Program Files\nodejs\node.exe" "C:\Program Files\nodejs\node_modules\npm\bin\npm-cli.js" "install"
npm ERR! node v0.12.7
npm ERR! npm  v2.9.0
npm ERR! code ETARGET
npm ERR! notarget No compatible version found<EMAIL_ADDRESS>npm ERR! notarget Valid install targets:
npm ERR! notarget ["0.0.1","0.0.2","0.0.3","0.0.4","0.0.5","0.0.6","0.0.7","0.0.8","0.0.9","0.0.10","0.0.11","0.0.12","0.0.13","0.0.14","0.0.15","0.1.0","0.1.1","0.1.2","0.2.0","0.2.1","0.2.2","0.2.3","0.3.0","0.3.1","0.4.0","0.4.1","0.5.0","0.5.1","0.5.2","0.6.0","0.6.1","0.7.0","0.7.1","0.7.2","0.7.3","0.8.0","0.8.1","0.8.2","0.8.3","0.8.4","0.8.5","0.9.0","0.9.1","0.10.0","0.10.1","0.10.2","0.10.3","0.10.4","0.11.0","0.11.1","0.11.2","0.11.3","0.11.4","0.12.0","0.12.1-b","0.12.2","0.12.3","0.13.0","0.14.0","0.14.1","0.14.2","0.15.0","0.16.0","0.17.0","0.17.2","0.17.3","0.17.4","0.17.5","0.17.6","0.18.0","0.18.1","1.0.0-beta.1","0.18.2","1.0.0-beta.2","1.0.0","1.1.0","1.2.0","1.2.1","1.2.2","1.2.3","1.3.0-beta1","1.2.4","1.3.0","1.3.1","1.3.2-beta2","1.3.3","1.3.4-beta1","1.3.4","1.3.5-beta","1.3.5","1.3.6","1.3.7","1.4.0-beta","1.4.0","1.4.1","1.4.2","1.4.3-beta","1.4.3","1.4.4","1.4.5-beta","1.4.5","1.4.6-beta","1.4.6-beta2","1.4.6","1.4.7-beta","1.4.7-beta2","1.4.7-beta3","1.4.7","1.4.8-beta","1.4.8","1.4.9-beta","1.4.10","1.5.0-beta1","1.5.0-beta2","1.5.0-beta3","1.4.11","1.5.0-beta4","1.5.0-beta5","1.4.12","1.4.13","1.5.0-beta6","1.5.0-beta7","1.4.14","1.4.15","1.4.16","1.5.0-beta11","1.5.0-beta12","1.5.0-beta13","1.5.0-beta14","1.5.0-beta15","1.5.0-beta16","1.5.0","1.5.1","1.5.2","1.5.3","1.6.0-beta1","1.6.0-beta2","1.6.0-beta3","1.6.0","1.6.1-beta","1.6.1","1.6.2","1.6.3"]
npm ERR! notarget
npm ERR! notarget This is most likely not a problem with npm itself.
npm ERR! notarget In most cases you or one of your dependencies are requesting
npm ERR! notarget a package version that doesn't exist.
npm ERR! notarget
npm ERR! notarget It was specified as a dependency of 'mm2'
npm ERR! notarget
npm ERR! Please include the following file with any support request:
npm ERR!     D:\Mobile apps\moodlemobile2-3.2.0\npm-debug.log
what can i do?

@martinmine - i got errors after modifying this package.json file :
$ npm install
npm WARN deprecated<EMAIL_ADDRESS>Please use gulp-clean-css
npm WARN deprecated<EMAIL_ADDRESS>Please update to minimatch 3.0.2 or higher to avoid a RegExp DoS issue
npm WARN deprecated<EMAIL_ADDRESS>Please update to minimatch 3.0.2 or higher to avoid a RegExp DoS issue
npm WARN deprecated<EMAIL_ADDRESS>graceful-fs v3.0.0 and before will fail on node releases >= v7.0. Please update to<EMAIL_ADDRESS>as soon as possible. Use 'npm ls graceful-fs' to find it in the tree.
npm WARN deprecated<EMAIL_ADDRESS>use node-gyp@3+ instead
npm WARN deprecated<EMAIL_ADDRESS>this package has been reintegrated into npm and is now out of date with respect to npm
npm WARN deprecated<EMAIL_ADDRESS>to-iso-string has been deprecated, use @segment/to-iso-string instead.
npm WARN deprecated<EMAIL_ADDRESS>Jade has been renamed to pug, please install the latest version of pug instead of jade
npm WARN deprecated<EMAIL_ADDRESS>Please update to minimatch 3.0.2 or higher to avoid a RegExp DoS issue
npm WARN deprecated<EMAIL_ADDRESS>use uuid module instead
npm ERR! Windows_NT 6.1.7601
npm ERR! argv "C:\Program Files\nodejs\node.exe" "C:\Program Files\nodejs\node_modules\npm\bin\npm-cli.js" "install"
npm ERR! node v6.9.1
npm ERR! npm  v3.10.8
npm ERR! code ETARGET
npm ERR! notarget No compatible version found<EMAIL_ADDRESS>npm ERR! notarget Valid install targets:
npm ERR! notarget 1.6.3, 1.6.2, 1.6.1, 1.6.1-beta, 1.6.0, 1.6.0-beta3, 1.6.0-beta2, 1.6.0-beta1, 1.5.3, 1.5.2, 1.5.1, 1.5.0, 1.5.0-beta7, 1.5.0-beta6, 1.5.0-beta5, 1.5.0-beta4, 1.5.0-beta3, 1.5.0-beta2, 1.5.0-beta16, 1.5.0-beta15, 1.5.0-beta14, 1.5.0-beta13, 1.5.0-beta12, 1.5.0-beta11, 1.5.0-beta1, 1.4.16, 1.4.15, 1.4.14, 1.4.13, 1.4.12, 1.4.11, 1.4.10, 1.4.9-beta, 1.4.8, 1.4.8-beta, 1.4.7, 1.4.7-beta3, 1.4.7-beta2, 1.4.7-beta, 1.4.6, 1.4.6-beta2, 1.4.6-beta, 1.4.5, 1.4.5-beta, 1.4.4, 1.4.3, 1.4.3-beta, 1.4.2, 1.4.1, 1.4.0, 1.4.0-beta, 1.3.7, 1.3.6, 1.3.5, 1.3.5-beta, 1.3.4, 1.3.4-beta1, 1.3.3, 1.3.2-beta2, 1.3.1, 1.3.0, 1.3.0-beta1, 1.2.4, 1.2.3, 1.2.2, 1.2.1, 1.2.0, 1.1.0, 1.0.0, 1.0.0-beta.2, 1.0.0-beta.1, 0.18.2, 0.18.1, 0.18.0, 0.17.6, 0.17.5, 0.17.4, 0.17.3, 0.17.2, 0.17.0, 0.16.0, 0.15.0, 0.14.2, 0.14.1, 0.14.0, 0.13.0, 0.12.3, 0.12.2, 0.12.1-b, 0.12.0, 0.11.4, 0.11.3, 0.11.2, 0.11.1, 0.11.0, 0.10.4, 0.10.3, 0.10.2, 0.10.1, 0.10.0, 0.9.1, 0.9.0, 0.8.5, 0.8.4, 0.8.3, 0.8.2, 0.8.1, 0.8.0, 0.7.3, 0.7.2, 0.7.1, 0.7.0, 0.6.1, 0.6.0, 0.5.2, 0.5.1, 0.5.0, 0.4.1, 0.4.0, 0.3.1, 0.3.0, 0.2.3, 0.2.2, 0.2.1, 0.2.0, 0.1.2, 0.1.1, 0.1.0, 0.0.15, 0.0.14, 0.0.13, 0.0.12, 0.0.11, 0.0.10, 0.0.9, 0.0.8, 0.0.7, 0.0.6, 0.0.5, 0.0.4, 0.0.3, 0.0.2, 0.0.1
npm ERR! notarget
npm ERR! notarget This is most likely not a problem with npm itself.
npm ERR! notarget In most cases you or one of your dependencies are requesting
npm ERR! notarget a package version that doesn't exist.
npm ERR! notarget
npm ERR! notarget It was specified as a dependency of 'mm2'
npm ERR! notarget
npm ERR! Please include the following file with any support request:
npm ERR!     D:\Mobile apps\moodlemobile2-3.2.0\npm-debug.log
what can i do?

@martinmine - i did ionic state restore , it works but many errors in console logs see in attached.

@martinmine - Plz help ! I did what you said but it is not working!

Closing this as it has been already implemented. See https://tracker.moodle.org/browse/MOBILE-1796 for more information.

@martinmine @jleyva - PLEASE REMIND ME WHICH VERSION DO YOU USE FOR NODE AND IONIC 2?


Edited message disappears for few seconds when text copied from notepad and sent

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Copy 2,3 line of text from notepad
Open a chat > Paste that text and send it to the user
Edit that message with the same text after sending

Expected Result:
Text from Notepad, the message should not be temporarily removed when you edit it with the same text, It should stay there
Actual Result:
Text from Notepad, the message is temporarily removed when you edit it with the same text
Workaround:
Can the user still use Expensify without this being fixed? Have you informed them of the workaround?
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android / native
[ ] Android / Chrome
[ ] iOS / native
[ ] iOS / Safari
[x] MacOS / Chrome / Safari
[ ] MacOS / Desktop

Version Number: <IP_ADDRESS>
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
https://user-images.githubusercontent.com/43996225/235794299-a313a03c-73d5-4135-83cc-c12e73374bc2.mp4
https://user-images.githubusercontent.com/43996225/235794316-cd0e46e3-a6f3-4edf-adb2-836b37faf61c.mp4
Expensify/Expensify Issue URL:
Issue reported by: @ayazhussain79
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1683030295884089
View all open jobs on GitHub

Triggered auto assignment to @kadiealexander (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

Bug0 Triage Checklist (Main S/O)

[ ] This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
[ ] This bug is not a duplicate report (check E/App issues and #expensify-bugs)

If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead

[ ] This bug is reproducible using the reproduction steps in the OP. S/O

If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
If the reproduction steps aren't clear and you determine the correct steps, please update the OP.

[ ] This issue is filled out as thoroughly and clearly as possible

Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.

[ ] I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

Unable to reproduce on staging version of Chrome:
https://user-images.githubusercontent.com/59587260/235842890-c21e9764-3fb9-4e4b-ab3c-080232b8aecf.mp4
Please update the reproduction steps if this is still happening.

@kadiealexander There should be no spaces between messages when you edit a message.
Use Edit Message as in the screenshot.

@kadiealexander Are you able to reproduce this issue? As above I mentioned its last step.

@ayazhussain79 I was following the steps listed in the main post, you can see there were no spaces in between the lines I was copying and pasting from notes.
Could you please edit the below reproduction steps to match what you followed?

Copy 2,3 line of text from notepad
Open a chat > Paste that text and send it to the user
Edit that message with the same text after sending

@kadiealexander Steps are same but there were spaces when you edited the message Idk why, try copying the text from somewhere else.

For edit message text should be like that there should not be spaces between text

When you copy text, spaces are copied along with it

Copy the text like that

Still unable to reproduce this using a text editor that does not copy spaces:
https://user-images.githubusercontent.com/59587260/236994063-2ff9be35-d525-4628-87bb-dcbd18396509.mp4

@kadiealexander you are very close just wait for 5,6 second after sending message so you can see spaces between the message after sending then edit the message

I waited 20 seconds and the message did not disappear:
https://github.com/Expensify/App/assets/59587260/fb3ab0c7-dcbc-42a8-a0aa-edf04d28be18
@ayazhussain79 at this point could you please share new reproduction steps from scratch if you still believe this to be a bug? Please include all tips you've shared here, and anything else you think would help to reproduce this.

@kadiealexander
Actions Performed:

Copy this text

Test
Test1
Test2

And Send it to the user

Wait for a while after sending so spaces added between the text
The sent message will look like this.:

After that click on edit button
The message will look like this:

5.Now paste this text for edit message and click send

Test
Test1
Test2

Video:
https://github.com/Expensify/App/assets/56740856/bf4bfc04-568e-4b0f-b16a-0ea9b435eeda

I followed those exact steps here with no issue:
https://github.com/Expensify/App/issues/18308#issuecomment-1541182875
Do you have a mac you can test on, so we can work out if this is a windows-specific issue?

@kadiealexander Actually I don't have mac, can you please ask someone else to try to reproduce it, you can see Kawi's video that she also reproduced it

@kadiealexandersorry Sorry to mention you again, I asked a friend to reproduce it, he also couldn't reproduce it on Mac, so it will be on Window

Thanks for confirming @ayazhussain79! Have asked for some help internally on this one here.

Sorry for the delay! I should hopefully be able to test this via Browserstack but I had to request access for the Windows environment. Will follow up tomorrow, hopefully I should have access by then.

Finally tested this on a windows dev environment and the outcome was the same (unable to reproduce):
https://github.com/Expensify/App/assets/59587260/9b4ca3c1-cd4c-4e83-8a71-8b3c9b9aa3e0
@ayazhussain79 are you still able to reproduce this?

@kadiealexander  Yes I can still reproduce it 🙁
When I send the message there is space between them but when you send you don't have space
like that

https://github.com/Expensify/App/assets/56740856/a0a83058-e056-4317-b0e1-b13baa310bd7

Yeah, I followed these steps you provided but the spaces didn't happen for me. I wonder if our emulator isn't sufficient. 🤔

@kadiealexander spaces just happen on window not other platforms I also reported that
https://expensify.slack.com/archives/C049HHMV9SM/p1683030295884089
If space bug fixed then this will be fixed


Which version (tag?) for Node 0.4.12

Which version (tag?) of forever is stable with Node 0.4.12? I have to go back to that because of issues with Node 0.6

<EMAIL_ADDRESS>works with both<EMAIL_ADDRESS>and<EMAIL_ADDRESS>

I get this when on node0.4.12
node.js:134
throw e; // process.nextTick error, or 'error' event on first tick
^
Error: Cannot find module './daemon.v0.4.12'
at Function._resolveFilename (module.js:326:11)
at Function._load (module.js:271:25)
at require (module.js:355:19)
at Object. (/usr/local/lib/node_modules/forever/node_modules/daemon/lib/daemon.js:12:11)
at Module._compile (module.js:411:26)
at Object..js (module.js:417:10)
at Module.load (module.js:343:31)
at Function._load (module.js:302:12)
at require (module.js:355:19)
at Object. (/usr/local/lib/node_modules/forever/lib/forever.js:15:14)

You need to reinstall forever when you switch node versions

right, I redid npm install forever -g and that was the error I got though.

Hi, I'm on node 0.6.10 and installed forever 0.8.3. I came to this post as I was getting the error
Cannot find module './daemon.v0.6.10'
According to this post I downgraded forever to 0.8.2, but still I am getting the same error.
Is there any workaround ?


feat(snowflake-usage): add knob for direct objects accesssed vs base objects accessed

direct_objects_accessed will display the view in the case a view is used. base_objects_accessed will display the underlying table the view was built off of. For usage, it makes more sense to default to direct_objects_accessed. This also includes a knob to use base_objects_accessed in the case a user would prefer that.
Checklist

[ ] The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
[ ] Links to related issues (if applicable)
[ ] Tests for the changes have been added/updated (if applicable)
[ ] Docs related to the changes have been added/updated (if applicable)

merged since cypress failure is unrelated.


Docker is a good choice for easy distribution and deployment.
I'm not familiar with Java or mvn, but I just want to deploy this project and have a try with it.
So, can you provide a Dockerfile? Thanks a lot!

docker image is available now.
See here: https://github.com/zjlywjh001/phrackCTF-Personal-Docker


ocamlPackages.lwt: 5.6.1 → 5.7.0

Description of changes
https://github.com/ocsigen/lwt/releases/tag/5.7.0
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 259327 run on x86_64-linux 1

40 packages built:

acgtk
alt-ergo
coccinelle
comby
cvehound
cvehound.dist
dune-release
flitter
flow
framac
google-drive-ocamlfuse
gradescope-submit
haxe (haxe_4_2)
haxePackages.format
haxePackages.heaps
haxePackages.hlopenal
haxePackages.hlsdl
hxcpp (haxePackages.hxcpp)
haxePackages.hxcs
haxePackages.hxjava
haxePackages.hxnodejs_4
hol_light
jackline
ledit
libbap
ligo
liquidsoap
opam-publish
orpie
prooftree
python310Packages.bap
python310Packages.bap.dist
python311Packages.bap
python311Packages.bap.dist
reason
sail-riscv-rv32
sail-riscv-rv64
soupault
stog
wayland-proxy-virtwl


Cannot instantiate the igScheduler using the igniteui-angular-wrappers

Description
Add a simple igScheduler on the page using the Ignite Ui Angular wrappers:
<ig-scheduler
	#scheduler1
	widgetId = "scheduler1"
	height = "650px"
	width = "100%"
	[options] = "options">
</ig-scheduler>

Result
Trying to run it results in an error, check the browser dev tools console:
"TypeError: Cannot read property 'prototype' of undefined
    at IgSchedulerComponent.IgControlBase (VM4378 igcontrolbase.ts!transpiled:74)"

Can you make sure you have igScheduler refences included(infragistics.scheduler-bundled.js)?
I made a plunker and it seems to be working as expected.

Of course this missing reference is the reason, a rookie mistake, sorry ! L:0 Closing the issue.


Point README at correct link for monitoring API

Codecov Report

Merging #1091 into master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #1091   +/-   ##
=========================================
  Coverage     81.74%   81.74%
  Complexity     1174     1174
=========================================
  Files           184      184
  Lines          5512     5512
  Branches        510      510
=========================================
  Hits           4506     4506
  Misses          871      871
  Partials        135      135

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b6fb9bb...032bdb1. Read the comment docs.

/cc @songy23


[Identity] Add ClientAssertionCredential to the public API

What we know so far:

Here’s .Net’s PR: https://github.com/Azure/azure-sdk-for-net/pull/26620/files
Here’s Python’s version of this credential: https://github.com/Azure/azure-sdk-for-python/blob/main/sdk/identity/azure-identity/azure/identity/_credentials/client_assertion.py
Python uses it from their TokenExchangeCredential https://github.com/Azure/azure-sdk-for-python/blob/fff4d586eb5f348763189d3a278c245a8ffbb2f5/sdk/identity/azure-identity/azure/identity/_credentials/token_exchange.py
For us, we don’t have a TokenExchangeCredential, but we have a token exchange MSI here: https://github.com/Azure/azure-sdk-for-js/blob/main/sdk/identity/identity/src/credentials/managedIdentityCredential/tokenExchangeMsi.ts

What we do here:

We read the assertion from the file located at the AZURE_FEDERATED_TOKEN_FILE environment variable.
Then we send it with the identityClient.sendTokenRequest, where the body contains these two parameters:

client_assertion: clientAssertion,
client_assertion_type: "urn:ietf:params:oauth:client-assertion-type:jwt-bearer",

Besides that, we know that .NET uses MSAL directly. Do we have that option in Node? Yes!
As you can see here: https://github.com/AzureAD/microsoft-authentication-library-for-js/blob/dev/lib/msal-node/docs/initialize-confidential-client-application.md MSAL accepts a clientAssertion string property in the client configuration. It should be as easy as using this property instead of the client certificate 🙂
What we need to do:

Make a new credential.
Write an internal test.

Does the ClientAssertionCredential need persistence caching features?

This issue is blocked by https://github.com/AzureAD/microsoft-authentication-library-for-js/issues/4481