correct .details to .defaults

I think this was a typo?

Coverage remained the same at 100.0% when pulling bccd54f08bc4f5396f6888cc77e50e8cc5be0397 on SpyMaster356:patch-1 into da9e84a59d6cd041aae15dfc192c3483f3282a22 on njl07:master.

Thanks


grpcgen: inconsistent behavior with nil Service

https://github.com/istio/istio/blob/a902592004731b312c48c2503695e9c1939c0e14/pilot/pkg/networking/grpcgen/cds.go#L106
Here we allow missing svc. But later we assume its there and can get a nil pointer derefernce.
We should probably not generate a Cluster without a service. If we do, we should do it consistently. cc @costinm @stevenctl

Not sure what is best behavior if user attempts to make a request to an unknown destination. If it was not .cluster.local we would do a passthrough with DNS resolution. Maybe we can do the same here ?
We do support modes where istiod is not watching all namespaces - so may not know about everything.

/not-stale


Revert "Nina/unify gpu container yaml"

Reverts google/xpk#115
TPU workload doesn't finish properly

Fix is here: https://github.com/google/xpk/pull/119


Fix #373. Fix #358

This PR fixes #373 (a small change, as described on the issue), uses Pipeline  to stop the execution whenever an error occurs (showing the error message via vim.notify. Should I add some kind of option to override this?) fixing #358 (if a user doesn't enter a variable name o a file name, the pipeline is stopped and an error message is showed via vim.notify) and cleans/refactors some code.
For example, the issue solved by #355 was related to an old workaround on lsp_utils.lua (using the same start and end for an lsp_range used to cause problems. The issue is solved now, so the workaround is no longer needed). As a consecuense of this change, it's possible to differentitate between lsp_ranges where text is going to be inserted and where text is going to be replaced.

Hi @TheLeoP. Thanks for the PR - I will take a look ASAP and merge if it's good to go!

I'm not sure how code revision works on github. I made some changes on my local machine and commited them. While doing them, I also encountered some weird behaviour with extract to file, so I just copied all the changes on #380, but some errors where still there. In particular, when extracting a function which should receive local variables as arguments to a file, it didn't worked. It turned out that Region:contains was using the current bufnr as default (the newly created buffer), so it always returned false. I think that error wasn't caused by me in a past commit, but I'm not 100% sure. Nonetheless, I have fixed it.


When typing CA number, flag switches to US

Hi,
Each time I click on Canada flag, the US flag take place. How can I choose canada? I tested it with  react-telephone-input 3.5+ and 3.7+
My phone field:
const phoneField = <TelInput
      name='phone'
      defaultCountry='mt'
      flagsImagePath='/img/flags.png'
      onChange={(phone, country) => this.setState({ phone, country })}
      value={this.state.phone}
    />

Thanks

This is a "memoize" issue, as it saves "+1" country code in memory as US. If you typed, for example, +1 403 (iso + area code), at the moment the flag should change to CA (haven't checked current version, i have it little bit modified on my environment).
I'd say we should get rid of memoize there at all (guessSelectedCountry). But yes, i have the same issue and don't really like it.

@jurgenzz Aha! Maybe we should use memoize from npm (https://www.npmjs.com/package/memoizee)). Lodash's memoize only memoizes on one parameter.

scratch that. That memoization is on a single param only.

@jmaitrehenry I have removed the memoize wrapper for guessSelectedCountry now. But have not made a release. Can you please pull the latest code and check it out?

@jmaitrehenry @jurgenzz
I have removed memoize in v4.0.1.

I'm also experiencing this issue.


Batch registration updates

Require a parent email for users in the 13-17 age category
Provide generated account credentials as an updated version of the uploaded CSV rather than in an HTML table

@hiliang-cmu 👍should be handled w/ 47889381


Project key with hyphen support

Describe the bug
Project key with a hyphen is throwing an error.
@alexhung I am testing https://github.com/jfrog/terraform-provider-shared/issues/21.
The project provider does not have an issue with a project key with a hyphen.
The xray provider does not like it and throws a 500 error on the terraform apply.
500 POST https://artifactory-server.com/xray/api/v2/policies?projectKey=tst-test
{"error":"Failed to create Policy"}

Requirements for and issue
resource "project" "tst_project" {
  key          = "tst-test"
  display_name = "Test Project"

  admin_privileges {
    manage_members   = true
    manage_resources = true
    index_resources  = true
  }

}

resource "xray_security_policy" "tst_security_policy" {
  name        = "tst-security-policy"
  description = "Test Security Policy"
  type        = "security"
  project_key = "tst-test"

  rule {
    name     = "tst-severity-rule"
    priority = 1

    criteria {
      cvss_range {
        from = 7.0
        to   = 10.0
      }
    }

    actions {
      webhooks                          = []
      mails                             = []
      block_release_bundle_distribution = false
      fail_build                        = false
      notify_watch_recipients           = false
      notify_deployer                   = false
      create_ticket_enabled             = false // set to true only if Jira integration is enabled
      //build_failure_grace_period_in_days = 5     // use only if fail_build is enabled

      block_download {
        unscanned = false
        active    = false
      }
    }
  }

  depends_on = [
    project.tst_project
  ]
}

Expected behavior
Project key with a hyphen does not cause an error.

@oallauddin Which version of the xray provider are you using?
Version 1.5.1 is updated with the new hyphen support.

@alexhung
Looks like issue is with my version of Artifactory and Xray.
I see you tested on newer versions than what we have setup.
I will ask our admins when they plan to upgrade Artifactory and Xray.
Versions
Artifactory version: 7.35.2
Xray version: 3.32.2
Terraform version: 1.2.5
Xray Provider version: 1.5.1
Project Provider version: 1.1.6
Artifactory Provider: 6.14.1


error on create: unix_listener: ".... " too long for Unix domain socket

on macos, I  tried creating a new sync session and got this message:
unix_listener: "/Users/username11/.mutagen/connections/username11_myreallyextraalonghostname.example.net:_22.PKkx13g7IH0gvjis" too long for Unix domain socket

The length of the path for the socket above was 109 characters.  If I use the IPv4 address rather than the "myreallylonghostname..." fqdn,  the sync session is created as expected.
After a little experimentation,  I think the limit is 108.

I found this for reference:  https://serverfault.com/questions/641347/check-if-a-path-exceeds-maximum-for-unix-domain-socket

Thanks for the report.
This is due to Mutagen invoking SSH's ControlMaster support to multiplex SSH connections and avoid the re-entry of credentials.  I see a few ways to fix this:
First, we could drop the support for doing this, allowing users to specify this manually in their ~/.ssh/config, though this configuration is such a good default for Mutagen that I'm hesitant to drop this.
Second, we could change the ControlPath template given to SSH, but it really needs every component it currently has to work in the face of configuration changes.  It's not even possible to determine if the path is going to be too long in advance, due to SSH's support for aliases.
Third, maybe we could add an option to disable ControlMaster usage.  That's basically what Ansible did in ansible/ansible#12144.  I've tried to make Mutagen "configuration-free" so far, but I have other reasons for thinking that some configuration might need to be introduced.
Let me think about this for a few days and I'll come back with something, but I think that the third option looks the best at this point.

Thanks for checking on it!   Yes -- that's what I've found as well..
One other option I thought of is to shorten to a hash without the hostname as part of the file name,  perhaps doing that only if the length exceeds that limit.   I can see the hostname in the path might be important for troubleshooting, but in general shouldn't really be needed,  right?

Well the problem is that Mutagen doesn't (necessarily) have knowledge of the hostname or username or port that'll be used, so it can't compute a hash.  It passes SSH a ControlPath template (consisting of tokens like %h for hostname) that should be used it computing the path.  But when it provides the host specification to SSH, what it gives may be an SSH alias as configured in ~/.ssh/config.  Then you have the issue that users may set up a ProxyCommand in ~/.ssh/config, which SSH also figures into the fully realized ControlPath.  Basically there's just not a lot that can be done on Mutagen's side.

I think what I'll do here is add an option to disable ControlMaster usage in Mutagen.  I'll do this as part of the v0.3.0 release, though that may be several weeks away.  Whatever mechanism I set up to manage configuration (I'm currently thinking something like ~/.mutagen/configuration.toml), I'd like it to be relatively extensible, so I need to put some thought into it.

I've gone ahead and just disabled (default) ControlMaster usage.  After thinking about it a lot, I think it was the wrong way to go.  I've put more details in the commit message for 971db9b.


Issue with require-statement mutation in Gambit tool: Expression replacement not implemented

As a user of the Gambit tool, I have noticed an issue with the require-statement mutation, where the mutation is not fully implemented according to the documentation.
According to the Gambit documentation, the require-statement mutation is intended to negate or change the expression inside a require statement. The documentation suggests replacing the expression with "true" or "!".
However, I have observed that the mutation only replaces the expression with "!". The replacement with "true" is not implemented.
I believe that this is a significant limitation of the mutation. The replacement with "true" would be useful in cases where the require statement is used to check a condition that should always be true. This would allow this mutation to generate more varied and meaningful mutants.
I would like to suggest that the Gambit team review the implementation of the require-statement mutation and consider adding the ability to replace the expression with "true" or other values, as suggested in the documentation.
Thank you for your attention to this matter.

I will double check tomorrow, but I think this might be fixed in #14, so if you go to the ben/mutator-refactor branch it may be done? As I said in another issue, I'm going to be doing a fair amount of work on mutation operators in another PR coming soon, but if this is broken I'll get it up and running for you.

@Sta1400 I've merged #14 into master, this should be correctly implemented now.
I've changed the semantics of require mutation: instead of mutating to true and !c I'm mutating to true and false. The reason is that both of these mutations are harder to detect than !c, and any time !c is detected, one of either true or false would be detected. This makes !c an inefficient mutant with lower utility than one of the other two mutants.
I'm closing this issue, but let me know if you are still encountering issues and we can reopen it. Thanks for your patience!


manifest unknown: manifest unknown

docker pull quay.m.daocloud.io/iovisor/bcc:latest
Error response from daemon: manifest for quay.m.daocloud.io/iovisor/bcc:latest not found: manifest unknown: manifest unknown

Need to add the image to sync list
I made a PR #55 for you

It is expected to be synced tomorrow.


feat(analytics): add initial analytics reporting

What kind of change does this PR introduce?
Feature

Did you add tests for your changes?
No, maybe N/A

If relevant, link to documentation update:

Summary
Adds Analytics tracking to webpack. Is opt-in feature. Insight package will ignore CI by default.

Does this PR introduce a breaking change?
No

Other information

@sokra is a binCase worth it here? Otherwise I could just add more of a unit test style test.

Actually have to rework this a bit after some digging going to close for now.


Improve FastParseCommand performance & readability

Modified the code to use utf8 literals for improved readability and switched to using binary tree approach for finding the correct command.
This is a big perf win for .NET 8 (disabled PGO to make sure to not have bias) but .NET 6 lacks a bit behind or regresses slightly but all seems acceptable to me.
| Method | Runtime  | Value                   | Mean      | Error     | StdDev    | Median    | Ratio | RatioSD | Code Size |
|------- |--------- |------------------------ |----------:|----------:|----------:|----------:|------:|--------:|----------:|
| Main   | .NET 6.0 | *1\r\n$7\r\nUNWATCH\r\n |  7.579 ns | 0.2431 ns | 0.7054 ns |  7.596 ns |  1.00 |    0.00 |   1,940 B |
| Pr     | .NET 6.0 | *1\r\n$7\r\nUNWATCH\r\n |  8.283 ns | 0.2940 ns | 0.8670 ns |  8.326 ns |  1.00 |    0.00 |   3,518 B |
|        |          |                         |           |           |           |           |       |         |           |
| Main   | .NET 8.0 | *1\r\n$7\r\nUNWATCH\r\n |  7.018 ns | 0.4226 ns | 1.2327 ns |  7.036 ns |  0.93 |    0.18 |   1,924 B |
| Pr     | .NET 8.0 | *1\r\n$7\r\nUNWATCH\r\n |  4.047 ns | 0.1540 ns | 0.4540 ns |  4.083 ns |  0.49 |    0.08 |   2,610 B |
|        |          |                         |           |           |           |           |       |         |           |
| Main   | .NET 6.0 | *2\r\n$3\r\nGET\r\n$    |  5.821 ns | 0.2053 ns | 0.5892 ns |  5.659 ns |  1.00 |    0.00 |   1,940 B |
| Pr     | .NET 6.0 | *2\r\n$3\r\nGET\r\n$    |  6.792 ns | 0.1738 ns | 0.4198 ns |  6.830 ns |  1.00 |    0.00 |   3,518 B |
|        |          |                         |           |           |           |           |       |         |           |
| Main   | .NET 8.0 | *2\r\n$3\r\nGET\r\n$    |  6.305 ns | 0.1747 ns | 0.5041 ns |  6.280 ns |  1.09 |    0.14 |   1,924 B |
| Pr     | .NET 8.0 | *2\r\n$3\r\nGET\r\n$    |  3.869 ns | 0.1494 ns | 0.4407 ns |  3.885 ns |  0.57 |    0.08 |   2,610 B |
|        |          |                         |           |           |           |           |       |         |           |
| Main   | .NET 6.0 | *3\r\n$6APPEND\r\n      |  7.055 ns | 0.1865 ns | 0.5469 ns |  7.144 ns |  1.00 |    0.00 |   1,940 B |
| Pr     | .NET 6.0 | *3\r\n$6APPEND\r\n      | 15.372 ns | 0.4516 ns | 1.3315 ns | 15.393 ns |  1.00 |    0.00 |   3,518 B |
|        |          |                         |           |           |           |           |       |         |           |
| Main   | .NET 8.0 | *3\r\n$6APPEND\r\n      |  6.402 ns | 0.2331 ns | 0.6800 ns |  6.297 ns |  0.91 |    0.11 |   1,924 B |
| Pr     | .NET 8.0 | *3\r\n$6APPEND\r\n      |  3.608 ns | 0.1241 ns | 0.3660 ns |  3.627 ns |  0.24 |    0.03 |   2,610 B |
|        |          |                         |           |           |           |           |       |         |           |
| Main   | .NET 6.0 | *3\r\n$6INVALID         |  7.586 ns | 0.2431 ns | 0.7130 ns |  7.526 ns |  1.00 |    0.00 |   1,940 B |
| Pr     | .NET 6.0 | *3\r\n$6INVALID         | 17.306 ns | 0.6646 ns | 1.9595 ns | 17.236 ns |  1.00 |    0.00 |   3,518 B |
|        |          |                         |           |           |           |           |       |         |           |
| Main   | .NET 8.0 | *3\r\n$6INVALID         |  6.787 ns | 0.3323 ns | 0.9641 ns |  6.525 ns |  0.90 |    0.14 |   1,924 B |
| Pr     | .NET 8.0 | *3\r\n$6INVALID         |  3.440 ns | 0.1191 ns | 0.3360 ns |  3.446 ns |  0.20 |    0.03 |   2,610 B |
|        |          |                         |           |           |           |           |       |         |           |
| Main   | .NET 6.0 | PING\r\n                |  2.073 ns | 0.0989 ns | 0.2854 ns |  2.051 ns |  1.00 |    0.00 |   1,940 B |
| Pr     | .NET 6.0 | PING\r\n                | 12.594 ns | 0.3338 ns | 0.9790 ns | 12.674 ns |  1.00 |    0.00 |   3,518 B |
|        |          |                         |           |           |           |           |       |         |           |
| Main   | .NET 8.0 | PING\r\n                |  2.067 ns | 0.0968 ns | 0.2809 ns |  2.061 ns |  1.02 |    0.22 |   1,924 B |
| Pr     | .NET 8.0 | PING\r\n                |  1.021 ns | 0.0690 ns | 0.1889 ns |  1.039 ns |  0.08 |    0.02 |   2,610 B |

Benchmark code:
public unsafe class Benchmark
{
    [Params("*2\r\n$3\r\nGET\r\n$", "*1\r\n$7\r\nUNWATCH\r\n", "PING\r\n", "*3\r\n$6APPEND\r\n", "*3\r\n$6INVALID")]
    public string Value;

    private GCHandle handle;
    private byte* bytePointer;

    [GlobalSetup]
    public void GlobalSetup()
    {
        byte[] bytes = Encoding.ASCII.GetBytes(this.Value);

        this.handle = GCHandle.Alloc(bytes, GCHandleType.Pinned);
        this.bytePointer = (byte*)this.handle.AddrOfPinnedObject();
    }

    [Benchmark]
    public RespCommand Main() => OldFastParseCommand(this.Value.Length, this.bytePointer);

    [Benchmark]
    public RespCommand Pr() => NewFastParseCommand(this.Value.Length, this.bytePointer);

    [GlobalCleanup]
    public void GlobalCleanup() => this.handle.Free();
}

@microsoft-github-policy-service agree

Failures seem to be unrelated, other PRs are failing with same tests related to the TLS handshake.

Was actually able to find small workaround for the small regression on .NET 6. This is now a perf win all across the board.

Great job! Thank you for your diligent work on this. There's definitely a lot of room for performance optimization in the parsing loop, and your approach seems spot-on.
However, I am holding off on merging this pull request for now. We're currently in the process of refactoring the parsing logic, and we have made changes to the semantics of the FastParseCommand() function (see PR #164). The new version you've proposed aligns well with the new interface, and I appreciate the improved readability.
If you have the time, I’d appreciate it if you could review the PR and provide any comments. Once #164 is merged, we can proceed with integrating this one.

PS: Thanks also for the benchmark! This is super useful. Once we have command parsing and execution separated, we should think about adding a proper parsing benchmark that follows your example.

I see, glad someone was already working on larger clean up on this. Looks like we had similar ideas already. Seems to be a very nice clean up :)

Updated the PR on top of main as #164 is merged now. I didn't touch any of the FastParseArrayCommand as the mileage varies on how much benefit you get from there with this pattern.


Slicing of symbolic arrays

Element assignment via slicing to symbolic arrays does not seem to work, but only single element assignment:
julia> x = zeros(SymPy.Sym{PyCall.PyObject}, 2, 2)
2×2 Matrix{SymPyCore.Sym{PyCall.PyObject}}:
 0  0
 0  0

julia> x[1,1] = 1; x
2×2 Matrix{SymPyCore.Sym{PyCall.PyObject}}:
 1  0
 0  0

julia> x[2,:] .= 2; x
2×2 Matrix{SymPyCore.Sym{PyCall.PyObject}}:
 1  0
 0  0

This one seems to be a problem with view. I forget why now, but for some reason views were causing stackoverflows so I essentially disabled them. (https://github.com/jverzani/SymPyCore.jl/blob/main/src/matrix.jl#L11) I'll have to go back and trace over my steps to see if this can be addressed.


BalanceOf Impementation

Implementation Details

Added _balances and _hasWritten mappings, address => uint256 & address => bool, respectively
transferFrom(from, to, id). If it is the caller's first transfer ever, we set their balance to be the parent's balance + the balance in local storage - 1. Where the -1 represents the token that is moved from to to.
balanceOf(_owner), if _haswritten[_owner] is false, aka. has never transferred any token, we know that their balance in local storage has never been written to before by the _owner,  therefore we return parent.balanceOf(_owner) + _balances[_owner]  where _balances[owner] represents all the tokens that have been transferred to the owner by other addresses.  If _haswritter[_owner] is true, we just return the value in local storage return _balances[_owner]

Trade-off

gas used in TransferFrom is more on first-write, subsequent transfers are cheaper.

Hey @tommyliu9, appreciate you submitting a PR.
When originally building out this idea I also wanted the ability to include the balance calculation with the parent balance however we have the edge case where someone may have:

Holding 2 Parent tokens.
Transfers a child token lowering the balance to 1 and setting hasWritten to true.

Now, if we transfer the parent token out of that wallet, the balance when called from the child would be inaccurate. Adding a hook implementation to integrate the parent:child would fix that though and would allow balanceOf() to accurately reflect the state of balance without ever becoming out of sync. With that though, I think there would be a better way to implement the balance tracking that wouldn't require such a large overhead.

Upon looking further into this, there are a few simple solutions that would make this simpler to handle and offer a more obvious user experience for all participants.
In order to be able to rely on the stored local state we need a way to fire the balance changes even when the parent changes. Usually, we cannot do this, with a little refactor there can be a Backpack that contains the ownership records of each sub-collection while triggering events from throughout the parent tree.
There would be a maximum-depth that this could occur within as well as this could become extremely costly rather quickly.
I've pushed a change to the repository that addresses the missing balanceOf() implementation to how it was intended originally. Do you have any ideas how to enable the usage of balance mappings without having stale data when a parent token is transferred?

Hey @nftchance, thanks for pointing out that edge-case. The Backpack method seems like a good approach. I will continue to look into other possible implementations. However, I'm not sure if it is worth all the overhead until there are more  use-cases for balanceOf on-chain. I will close this PR and revisit this when the time comes.


Support for the new API features :-)

Hello from Twitter Developer Relations!
First of all: Thank You, for building on our API, and for supporting our developer communities! You, and many projects like this one, are among the reasons why Twitter data is much-appreciated by developers. We historically haven't built libraries and SDKs - the communities, YOU, have done so - and I'm here to tell you how much we appreciate that, and that we know you're around!
As you already know, we are currently building a brand new API platform that (over time) will replace the current one. I would love to connect with you on any plans to add support for Twitter Developer Labs to twitter-lite! We're looking to be much more focused on proper API versioning, and are basing our specification on OpenAPI.
We would really love to continue to work with you so as you continue to help the Java community. Thank you, again!

Hi @andypiper !
Thank you very for your message, of course it would be a pleasure to go further on this project and keep implementing the last twitter API features to help the community. Tell me what are the next steps !

We've just announced support for annotations in the v2 Tweets and search endpoints, and there will be more to come as we migrate more endpoints to v2 over the coming weeks. Longer term, of course, we'll be graduating these APIs to a production state, and having libraries available for developers to get started quickly will be appreciated.

We've just announced support for annotations in the v2 Tweets and search endpoints, and there will be more to come as we migrate more endpoints to v2 over the coming weeks. Longer term, of course, we'll be graduating these APIs to a production state, and having libraries available for developers to get started quickly will be appreciated.

Wow it looks awesome !! I'll try to check this topic this week and study its implementation.

Done @andypiper  ;)


[stackgl] Evaluate glsl-parser/deparser and gl-shader

Evaluate whether it makes sense to move the shader building structure to use glsl-parser and gl-shader to build the shaders in philogl. If it does make sense, then change it.

Moved to LumaGL


closes #68: use clang-tidy cmake arg instead of ici flag to lint head…

…er files.
closes #68

relevant changes implemented and working. now just need to fix the errors clang-tidy now catches in headers


Use structopt and refactor

This commit changes loop to use structopt. This is a wrapper around clap that serializes all of the matches into one static struct. This adds a lot of static typing benefits over using the traditional ArgMatches clap provides. This commit has 100% equivalent functionality with the loops before while simplifying the codebase.
Detailed changes
All of the design decisions for the commit are detailed in github comments here: https://github.com/Fierthraix/Loop/commit/1d1c0b037306355fa5fa107e6ec8bf5b35e80f60#diff-639fbc4ef05b315af92b4d836c31b023
structopt
Now everything that relies on parsing possibly faulty user input (like parse_rfc3339_weak) is handled behind the scenes, negating the need for a lot of user code. All standard library types (like float) are autoconverted, saving you from manually changing them from strings. bools are determined from the presence of a flag as well. Things likes regexes are compiled when parsed as well, saving you from doing it manually or forgetting and having it compile every loop iteration. This removes a lot of serialization code in the main function.
using Option
The code has also been refactored to a significant degree. The started with using Option<T> to encode the presence of a flag instead of having both a bool and a variable for the type (as mentioned here). As this is now parsed with structopt, all variables related to cli flags are now encoded in a single struct, making for far fewer variables actually declared.
Custom iterator
Instead of doing a C-style imperative for loop, this has been changed to a more rustic iterator struct. This struct had to be hand-rolled to handle floating point numbers passed with --count-by. The benefit of using the iterator is that the looping logic is separate from the loop, allowing you to check its veracity independently. As well, everything the iterator produces is immutable and prevents accidental iterator invalidation.

All of the design decisions for the commit are detailed in github comments here: https://github.com/Fierthraix/Loop/commit/1d1c0b037306355fa5fa107e6ec8bf5b35e80f60#diff-639fbc4ef05b315af92b4d836c31b023

Woah, this is huge! Awesome! It's gonna take me a little while to review and digest all this but looks good!


Automated cherry pick of #9500

Cherry pick of #9500 on release-6.2.
/cc  @M-ZubairAhmed
NONE

Will try to auto merge this PR once all tests and checks are passing. This might take up to an hour.

/update-branch

@M-ZubairAhmed The cherry-pick is failing.

Trying to auto merge this PR.

Pull Request successfully merged
SHA: 1da26f7c4ad3da78fe140a5b354ecab29576a219


chore(main): release 1.0.1

:robot: I have created a release beep boop
1.0.1 (2024-09-20)
Bug Fixes

discussion topic and speed grader detections (#5) (9f2617d)

This PR was generated with Release Please. See documentation.

:robot: Created releases:

v1.0.1
:sunflower:


About batch size on CIFAR

Paper said that the batch size for CIFAR is 128, but the code initialize batch size with 64:
https://github.com/LiJunnan1992/DivideMix/blob/d9d3058fa69a952463b896f84730378cdee6ec39/Train_cifar.py#L17
Since there are no scripts provided. I am confused, about whether 128 means two 64 batch augmentation? Should I set --batch_size 128 when I train on CIFAR?

Hi, you can use batch_size=64, because each batch contains 64 labeled samples and 64 unlabeled samples, which makes the total size 128.
Thanks

Thanks for the reply.


Fix Haxe requirement

People already successfully used the latest Haxe version with the latest commit of the FNF GitHub repository.

@AngelDTF can you check this

I would if I could test these changes myself, however I'm running out of storage space on my hard drive, and also my current Haxe configuration is working fine, so I'd rather not risk any issues by upgrading. I'll see if I can ask a friend later if they aren't busy.

im using haxe 4.2.4 since psych pretty much needs it, although compiling on other stuff like this works just fine, just need to update your libraries

just tried with 4.2.5, and couldn't even use git commands.

Was watching @Cheese-Curd's discord stream of her trying to set up the latest version of Haxe on a clean install of Windows 11. She is experiencing the same issues that are noted in the current README.md file, where gits are not working correctly. Therefore, I do not wish to update the readme and tell everyone to use latest when it has a bug that prevents users from even setting up Flixel itself.

Was watching @Cheese-Curd's discord stream of her trying to set up the latest version of Haxe on a clean install of Windows 11. She is experiencing the same issues that are noted in the current README.md file, where gits are not working correctly. Therefore, I do not wish to update the readme and tell everyone to use latest when it has a bug that prevents users from even setting up Flixel itself.

this bug was fixed long time ago in new flixel ver.
also, can you give me the link for that stream? maybe it is outdated now.
i never got any issues with git itself just by using latest haxe and flixel versions on a original fnf source code compilation (i can even tell you psych engine users need the latest version of haxe. try compiling it and you will see).

can you send a screenshot please? i need to see what's wrong so i can help you.

Sorry, I should've been more specific. I was watching her screen share while we were in a Discord call with each other, so it is not outdated. I saw it happen in real time, and the issue still occurs. It was not recorded on any websites, but if you really want to see, I could attempt contacting her and seeing if she would be willing to upload a video about this.

I'd be fine recording this, however like Angel and I have said, it doesn't seem to work.

I'd be fine recording this, however like Angel and I have said, it doesn't seem to work.

this wont be good for people who are compiling psych first time


Question: Is it possible to start the server without listhen?

Describe the change
I am currently building something where I want to "click" on a button or use the CLI to enter some parameter/variables to start the server. But for now, it seems that you need to run listhen. Is it possible to run the app without it?
URLs
No response
Additional information

[ ] Would you be willing to help?

Or how can I add parameters to the listhen ?

You can run h3 using the node:http adapter, it's documented here. You can also call listhen from code, that's documented here.

The first one is what I needed thanks @zusorio

You can run h3 using the node:http adapter, it's documented here. You can also call listhen from code, that's documented here.

If you want to start listhen programmatically with h3 and Node, would you pass in "toNodeListener(app) to listen?
I tried that but when I start my app, I get an error:
"ERROR  Make sure your server entrypoint exports a compatible handler, handle, app or default function export."
I also tried passing in app.handler but thats apparently the wrong thing


DRAFT: fix: Update dotnet samples to latest SDK usage

@janpieterz any opposition to me closing this PR since I already updated the samples to 1.11.0?


Add SNS fields to profile page

Fix #17.
目前大概長這樣

Current coverage is 94.35%

Merging #104 into master will decrease coverage by -0.31% as of cc3fb18

@@            master    #104   diff @@
======================================
  Files           28      28
  Stmts          881     886     +5
  Branches         0       0
  Methods          0       0
======================================
+ Hit            834     836     +2
  Partial          0       0
- Missed          47      50     +3

Review entire Coverage Diff as of cc3fb18

Powered by Codecov. Updated on successful CI builds.

@uranusjr 你用 URL field 可以過驗證嗎？
我輸入 flywindy 會要求我輸入 URL：

Copy-paste 欄位的時候忘了改… 好像也只有 Firefox 會真的 validate 所以沒發現。

剛剛我用的是 Chrome XD


Provide warnings if dimension unavailable (e.g. time)

Somewhat dealt with by #21 - with new errors='ignore' option


Getting around Static

I am not sure how I am going to pass common data between, well, everything! For example, in Morro you can just do Engine.DeltaTime or Engine.TotalTime or whatever you get it.
In pygine, I had a relay object that contained all this common data, so maybe something like that could end up working?
Or you could just bite the bullet and finally figure out this JS Static implementation thing

I just remembered how Morro and MonoGame in general and probably even more better frameworks have like a instance of the base class in its self (so in Morro's case, "Morro.Instance"). Maybe you could try that and make sure that the instance/reference? is 100% readonly.
I think it is kinda janky to have to pass in graphics and sceneManager to a Scene right now. Wouldn't it be cooler if you just passed in Sketch's instance of itself? 🤔🤔😎

okay so I ended up making it so a scene's constructor has a theater parameter. With that readonly reference you can basically do everything 😎😎
I am going to close this issue, but I am not entirely sure this is the best solution moving forward just yet. So I might come back to this later!


Bad request

When the plugin tries to upload the .ipa to Applivery shows this error:
[17:25:56]: ▸ {"status":false,"error":{"code":400,"msg":"Bad request","field":"slug"}}
The "field" parameter on error sometimes change. In this case is "slug".

Dear @movilidadSoporte, thank you for opening the ticket.
Could you please share the following information that will help us to clarify the problem:

Are you trying to deploy an iOS or Android App?
Can you please share your fastfile? (Please, do not include your ACCOUNT API KEY)

Thank you


Add CI support for the Surf CI server

This PR adds CI support for Surf, a toolkit for folx to create local build servers.
Refs https://github.com/surf-build/surf/pull/32, which adds Danger support for Surf (i.e. projects that have a Dangerfile will automatically be run if CI status will be posted)

          1 Error

:no_entry_sign:
Please include a CHANGELOG entry.
You can find it at CHANGELOG.md.

          1 Message

:book:
@paulcbetts is not a contributor yet, would you like to join the Danger org?

  Generated by :no_entry_sign: danger

Aside form the question about the build.sh - this looks great 👍

Alright, this looks cool - this is definitely a reminder that I need to start generating a list of things Danger supports programmatically ASAP in order to ensure the README/danger.systems is always up to date.
WRT to the build.sh, I'm not sure we're going to need to run our own Surf instance ( we are currently running Danger on Travis/Circle, as they are most used ( and Circle has custom code, due to some funky workarounds. ) so in the future, I may end up removing that file. However, this is a nice idea, and I'd like to see if people take it up.
Surf looks nice, well done there.

@orta Surf isn't necessarily something you run (like a service), it's just as easy to use it locally:
npm install -g surf-build

## Man, I wish I had a clean build of what I'm working on locally
git push
surf-build

Or
## Man, I wish I had CI on Windows, or whatever
surf-client

## Open a new console window
git commit
git push      # CI runs in other window

Interesting 👍

Surf 0.9.2 is now up on npm and has full Danger support, thanks all!


Tomopy methods to port for acceleration

We need to port:

remove_all_stripe, remove_large_stripe and remove_dead_stripe from here
retrieve_phase from here. This is so-called Paganin filter but we need to make it consistent with TomoPy implementation
Distortion correction as in here

Re: item 3 in the list.
An alternative distortion correction implementation has been added in 050ded9.
It is based on the implementation in Discorpy https://github.com/DiamondLightSource/discorpy/blob/67743842b60bf5dd45b21b8460e369d4a5e94d67/discorpy/post/postprocessing.py#L111-L148 rather than TomoPy https://github.com/tomopy/tomopy/blob/c236a2969074f5fc70189fb5545f0a165924f916/source/tomopy/prep/alignment.py#L950-L981.
This is because they are actually almost identical to each another, except that the Discorpy version is slightly more flexible by allowing users to pass the order  and mode parameters through to the map_coordinates() function from NumPy https://github.com/DiamondLightSource/discorpy/blob/67743842b60bf5dd45b21b8460e369d4a5e94d67/discorpy/post/postprocessing.py#L147.

It's not urgently needed to be ready for the GPU contractor's start date, but as a note, it was also previously discussed that the methods relating to 360 sinograms would be useful to make GPU ports of sometime, namely:

Conversion of a 360 degree sinogram to a 180 degree sinogram (from TomoPy): https://github.com/tomopy/tomopy/blob/master/source/tomopy/misc/morph.py#L314-L356
Finding the CoR of a 360 sinogram (from algotom): https://github.com/algotom/algotom/blob/96ec59e4ae49d937ae26be2e63aa6d0ec55da3a6/algotom/prep/calculation.py#L599-L649


Maven-like rolling output when the build happens to be linear

Fix #269

I am a bit more content with 385d77e:

Our custom SmartGraphBuilder is properly instantiated via Guice
The DependencyGraph now has a width field, that returns 1 if the graph is serial and Integer.MAX_VALUE otherwise. That's enough for the current feature. It can be enhanced later to return the proper width for other purposes.

Would it be possible to keep the DependencyGraph interface independent of maven ? The algorithm I have only depends on the upstream / downstream methods, so having to create MavenProject objects for nothing will make things harder to test.
See https://github.com/gnodet/mvnd/blob/dag-width/daemon/src/test/java/org/mvndaemon/mvnd/builder/DagWidthTest.java

Yeah, that's a valid point. Let me try that.

2708c12 keeps the DependencyGraph interface independent of Maven.

fe963d5: adapted your DagWidth implementation

c3ac2f6: DependencyGraph wraps ProjectDependencyGraph and stores it in session.getRequest().getData()
If this iteration is not good enough, I do not mind postponing this.

c3ac2f6: DependencyGraph wraps ProjectDependencyGraph and stores it in session.getRequest().getData()
If this iteration is not good enough, I do not mind postponing this.

Ok, let me check asap.

Could you just add the following change https://github.com/gnodet/mvnd/commit/b1d9bd5cd4ce2a25a527d435535ba6a0e3329d2d ?
Otherwise looks good !

Could you just add the following change gnodet@b1d9bd5 ?

Accepted in 1c5e086


Awkward "permission denied" when trying to open symblinked Kube Config

https://github.com/helm/helm/issues/11592
error: kubeconfig error: failed to load: failed to open file: open /home/user/.kube/config: permission denied

Is it only symlinked or is the symlink broken/not readable?

@ahmetb
I use the Kube Config, the symlink points to, all the time.
Still, despite that fact, I have checked the link & functionality after running this plugin and it worked, as expected.
However, the plugin seems to check the permissions of the symlink, instead of the ones from the actual file behind it.

I don't think any of these tools check the permissions of the symlink. But they need to be able to open+read the symlink to find the actual path. Permissions of the symlink matter. That's just how symlinks work.
I am going to need a more clear explanation from you about what's not working and under what circumstances. You said the plugin has worked so I am confused now.

Permissions of the symlink matter. That's just how symlinks work.

No, that's not how they work, though. The symlink's permissions does not matter at all, which is why it shows up as 777, when you look up its permissions.
The only way the permissions of the symlink itself matter, is if you are running macOS or some BSD.

I am going to need a more clear explanation from you about what's not working and under what circumstances. You said the plugin has worked so I am confused now.

I tried the plugin. Did not work.
Then, for this issue, I ran kubectl to check, whether the Kube Config permissions are fine. It worked without the plugin.
Again tried with plugin. Did not work, due to permission error.
Nothing works with the plugin. It won't run, because of permissions, which is objectively just wrong. It's a bug in the permission check's implementation.

@ahmetb
I found the culprit.
https://github.com/ahmetb/kubectx/blob/3504e66edbe51e1bcbb57cd02b2cf6972e9d501d/internal/kubeconfig/kubeconfigloader.go#L39
This asks for too many permissions.
...
...
O_RDONLY [int](https://pkg.go.dev/builtin#int) = [syscall](https://pkg.go.dev/syscall).[O_RDONLY](https://pkg.go.dev/syscall#O_RDONLY) // open the file read-only.
....
O_RDWR   [int](https://pkg.go.dev/builtin#int) = [syscall](https://pkg.go.dev/syscall).[O_RDWR](https://pkg.go.dev/syscall#O_RDWR)   // open the file read-write.
...
...

Source
The file has to be opened with read permissions, only. No application like Helm, kubectl, or whatever is popular, needs write permissions.
Therefore, the permission requested has to be reduced to O_RDONLY.
However, when trying out the patch, which fixes this issue, I found out, that this plugin rewrites the Kube Config file on each change.
Which means, if you cannot fix the implementation due to Kubernetes, you have to update the documentation for this plugin, since it needs to state, that the Kube Config needs to be writable by the user accessing the Kube Config file.
By default, the Kube Config file does not need to be writable and therefore should not be writable. No other popular app I have tried, like Helm, needs a writable Kube Config file, which is why all other apps worked fine.

Understood. Kubectl actually updates the kubeconfig files if you run various "kubectl config" commands as well. Do they work fine when the file is a symlink? If so, we can also fix it here.

Kubectl actually updates the kubeconfig files if you run various "kubectl config" commands as well. Do they work fine when the file is a symlink?

Well, as explained above, it's about the permission of the actual file behind the symbolic link(s).
The actual permission is read-only by default, so it may not be changed.
For this purpose, I have tested renaming a context via kube config rename-context and it did not work. Though, this command does not seem to be common and I never needed it.
Anyway, the default permissions are something like 400, which would be read-only. Which in turn means, this isn't anything uncommon.

If so, we can also fix it here.

This issue can only be truly fixed, if there is a way for changing the context/namespace without actually modifying the Kube Config file on the filesystem.
If that is impossible, this issue can only be worked around by allowing more permissions to the Kube Config file, like adding write access.
Therefore, if it cannot be truly fixed, the documentation needs to be updated, so it is clear, that this plugin needs a writable Kube Config.

I don't think that can be fixed since the main purpose for this tool is to modify kubeconfig files.
And I am not inclined to document it either since there are not a lot of people doing this (this=symlinking kubeconfig path to a readonly file). It came up for the first time after all these years.
A lot of users set KUBECONFIG env var or still use writable files even if they use symlinks, so I think this is a corner case.
Also it's not very hard to debug as "ls" shows to any user it's a symlink, and they can see it's readonly.

And I am not inclined to document it either since there are not a lot of people doing this (this=symlinking kubeconfig path to a readonly file).

By default, the Kube Config file does not need to be writable and therefore should not be writable. No other popular app I have tried, like Helm, needs a writable Kube Config file, which is why all other apps worked fine.

The actual permission is read-only by default, so the file may not be modified.

Anyway, the default permissions are something like 400, which would be read-only. Which in turn means, this isn't anything uncommon.

If that is impossible, this issue can only be worked around by allowing more permissions to the Kube Config file, like adding write access.

that this plugin needs a writable Kube Config.

Not sure how I can make it even more clear, that this is not related to symbolic links, at all. It's about the Kube Config file not having write permissions, which is the default.

It came up for the first time after all these years.

If people use the root user, then of course nobody will notice.

A lot of users set KUBECONFIG env var or still use writable files even if they use symlinks, so I think this is a corner case.

Again, not a symbolic link issue. It's a permission issue related to the Kube Config file, itself.

Also it's not very hard to debug as "ls" shows to any user it's a symlink, and they can see it's readonly.

Not sure how to make it more clear that symlinks don't have "permissions" the way you think. They are permissionless & show up as 777 when you ls -l it. The permissions are entirely based on what the actual file behind the symbolic links has. Symbolic links have no permissions on Linux.

they can see it's readonly.

Okay. Let me repeat for the 5th time.
Read-only is the default.
Read-write is not default.
Therefore, your plugin requires more access, than is usually needed.
Again, therefore, you need to document this, because it is important, that your plugin needs additional permissions, which are usually not needed. Kubernetes, Helm & all other popular tools run with a read-only Kube Config file.
One last time about the symbolic links, so we are on the same page, finally:
Symbolic links have no permissions on Linux. This is a Kube Config file permission issue. This is not an issue about symbolic linking.

By default, the Kube Config file does not need to be writable and therefore should not be writable. No other popular app I have tried, like Helm, needs a writable Kube Config file, which is why all other apps worked fine.

this is incorrect. Kubectl itself (when used with gcp, azure or oidc) store access tokens/refresh tokens in the kubeconfig file by updating the file.
I am not claiming the issue is with symlink permissions. But if you are a kubectl user and you get a permission error, it’s not too cryptic to see that the path referenced via the symlink is a readonly file (if that’s the case).

also just so you know

Symbolic links have no permissions on Linux.

This is not too relevant because symlinks do have permissions that matter on macOS. The semantics aren’t identical to Linux.

Again, therefore, you need to document this, because it is important

that’s what “you” think. As I said, this tool has a pretty significant user base and this came up for the first time over the past 5 years. So I am not inclined in documenting every single corner case caused by an odd set up —especially when running “ls” makes the situation clear— as something that everyone needs to read.

this is incorrect. Kubectl itself (when used with gcp, azure or oidc) store access tokens/refresh tokens in the kubeconfig file by updating the file.

Yes. So, how does that matter, when you point out non-default setups? Irrelevant.

I am not claiming the issue is with symlink permissions. But if you are a kubectl user and you get a permission error, it’s not too cryptic to see that the path referenced via the symlink is a readonly file (if that’s the case).

You were talking the entire time about symlinks, when it was clear pretty early, that this is about permission issues on the Kube Config file, itself.

This is not too relevant because symlinks do have permissions that matter on macOS. The semantics aren’t identical to Linux.

This proves, you have neither read nor understood anything I had said.
I literally repeated this at least 5 times (including the one in the Helm Github Issue) and you still were talking about symlink permissions on Linux. 😄
You literally just copied what I said several times earlier. Like what? Why?

that’s what “you” think.

No. That's what reality "thinks", if reality had a mind.
I just gave you like 20 objective reasons, why your tool is out of the ordinary and this needs to be pointed out, as let others avoid a waste of time I have experienced. Hence, I created this issue, so this can be solved, even if it cannot be truly solved, because then we can warn people about this issue.

As I said, this tool has a pretty significant user base and this came up for the first time over the past 5 years.

Absolutely irrelevant. Does matter about 0%. There are tons of entire toolsets, which become obsolete, because something changed in upstream or a new feature has been included in upstream. One of the most famous examples is docker-compose. It was a separate project back then.
So, just because "nothing came up" in all these years, it literally does not matter at all. Because, it came up just now!

I am not inclined in documenting every single corner case caused by an odd set up —especially when running “ls” makes the situation clear— as something that everyone needs to read.

Again, you have neither read nor understood a single thing I had said.
The case I was elaborating on is the DEFAULT case.
It's the DEFAULT.
The case you are covering is the actual edge case. You think, that the Kube Config file is normally readable. This is an edge case.
Whatever, as was evident along the entire conversation, you are neither willing nor able to accept actual facts representing the reality of how the Kube Config works by default. Not GCP or some weird edge case you are talking about. I am talking about the default setup. The default Kubernetes setup. Not some edge case cloud platform, making their own stuff.
P.S.:
ls does not show any permissions, except you run ls -l. Plus, it's never needed to check the permissions with any tool, except yours. So, your tool makes edge case assumptions.
 Actually, it does matter, because the largest user base is made out of Linux users. Nobody is running a Kubernetes server on macOS & only a minority manages Kubernetes from macOS.


Verify Compact mode for your adapter

We have detected that your adapter supports the compact mode. Please use the latest js-controller 2.0 and verify that everything works.
Some more information what is important to check can be found at https://github.com/ioBroker/ioBroker.js-controller/issues/512
On questions please answer to the linked issue. Please close this issue after your test and add the version number that you have tested please as a comment.
Thank you for your support.

Has someone tried this? Does it work?


Adding "provides" as a global member of the CouchDB environment

Just a minor thing I came across running my own tests for a CouchDB API I have.
provides is provided in the case of both _show and _list functions, so I added it as part of the couch environment. Included are also the applicable changes to the unit tests. :)

Thank you!


ebiten: unify NewImage and NewImageWithOptions

and the pair NewImageFromImage and NewImageFromImageWithOptions.
See also #2013, #2017, and #2124.

When unifying, we can remove NewImageFromImageOptions.PreserveBounds by making this a default behavior.


PIM RoleManagementPolicy Expiration_Admin_Assignment missing on create

Describe what happened
When I create a RoleManagementPolicy resource the expirationRequired: false configuration of the activeAssignmentRules is not forwarded to azure. This happens only on initial pulumi up.
The HTTP PATCH request content does not contain a rule with id - Expiration_Admin_Assignment, while it contains a rule with id - Expiration_Admin_Eligibility, which is set in similar way.
On a second pulumi up the  Expiration_Admin_Assignment is included in the request and is properly updated.
Sample program
  new RoleManagementPolicy(
    `pim-role-policy-jump-box-${roleDefinition.id}`,
    {
      scope: vm_fnd_jump_box.id,
      roleDefinitionId: `/subscriptions/${azureConfig.subscriptionId}/providers/Microsoft.Authorization/roleDefinitions/${roleDefinition.id}`,
      activeAssignmentRules: {
        expirationRequired: false
      },
      eligibleAssignmentRules: {
        expirationRequired: false
      },
      activationRules: {
        requireApproval: true,
        approvalStage: {
          primaryApprovers: policy.approvers.map((approver) => ({
            objectId: approver.objectId,
            type: approver.type
          }))
        }
      },
      notificationRules: {
        activeAssignments: {
          adminNotifications: {
            notificationLevel: policy.adminNotificationLevel,
            defaultRecipients: true
          }
        },
        eligibleAssignments: {
          adminNotifications: {
            notificationLevel: policy.adminNotificationLevel,
            defaultRecipients: true
          }
        },
        eligibleActivations: {
          adminNotifications: {
            notificationLevel: policy.adminNotificationLevel,
            defaultRecipients: true
          }
        }
      }
    }
  );

Log output
I1205 09:52:27.131762 2768753 eventsink.go:59] PATCH /subscriptions/<subscription-id>/resourceGroups/test-weu-fnd-jump-box-tmp0371/providers/Microsoft.Compute/virtualMachines/vm-test-weu-fnd-jump-box-tmp0371/providers/Microsoft.Authorization/roleManagementPolicies/1c0163c0-47e6-4577-8991-ea5c82e286e4?api-version=2020-10-01 HTTP/1.1
I1205 09:52:27.131792 2768753 eventsink.go:62] eventSink::Debug(<{%reset%}>PATCH /subscriptions/<subscription-id>/resourceGroups/test-weu-fnd-jump-box-tmp0371/providers/Microsoft.Compute/virtualMachines/vm-test-weu-fnd-jump-box-tmp0371/providers/Microsoft.Authorization/roleManagementPolicies/1c0163c0-47e6-4577-8991-ea5c82e286e4?api-version=2020-10-01 HTTP/1.1<{%reset%}>)
I1205 09:52:27.131979 2768753 eventsink.go:59] Host: management.azure.com
I1205 09:52:27.132002 2768753 eventsink.go:62] eventSink::Debug(<{%reset%}>Host: management.azure.com<{%reset%}>)
I1205 09:52:27.132211 2768753 eventsink.go:59] User-Agent: HashiCorp/go-azure-sdk (Go-http-Client/1.1 rolemanagementpolicies/2020-10-01) pulumi-azure/v6.11.0 pid-a90539d8-a7a6-5826-95c4-1fbef22d4b22
I1205 09:52:27.132236 2768753 eventsink.go:62] eventSink::Debug(<{%reset%}>User-Agent: HashiCorp/go-azure-sdk (Go-http-Client/1.1 rolemanagementpolicies/2020-10-01) pulumi-azure/v6.11.0 pid-a90539d8-a7a6-5826-95c4-1fbef22d4b22<{%reset%}>)
I1205 09:52:27.132424 2768753 eventsink.go:59] Content-Length: 2202
I1205 09:52:27.132448 2768753 eventsink.go:62] eventSink::Debug(<{%reset%}>Content-Length: 2202<{%reset%}>)
I1205 09:52:27.132645 2768753 eventsink.go:59] Content-Type: application/json; charset=utf-8
I1205 09:52:27.132672 2768753 eventsink.go:62] eventSink::Debug(<{%reset%}>Content-Type: application/json; charset=utf-8<{%reset%}>)
I1205 09:52:27.132863 2768753 eventsink.go:59] X-Ms-Correlation-Request-Id: b7ac1b5f-281e-857a-362c-60c6e06961ff
I1205 09:52:27.132887 2768753 eventsink.go:62] eventSink::Debug(<{%reset%}>X-Ms-Correlation-Request-Id: b7ac1b5f-281e-857a-362c-60c6e06961ff<{%reset%}>)
I1205 09:52:27.133082 2768753 eventsink.go:59] Accept-Encoding: gzip
I1205 09:52:27.133102 2768753 eventsink.go:62] eventSink::Debug(<{%reset%}>Accept-Encoding: gzip<{%reset%}>)
I1205 09:52:27.133296 2768753 eventsink.go:59]
I1205 09:52:27.133318 2768753 eventsink.go:62] eventSink::Debug(<{%reset%}><{%reset%}>)
I1205 09:52:27.133505 2768753 eventsink.go:59] {"id":"/subscriptions/<subscription-id>/resourceGroups/test-weu-fnd-jump-box-tmp0371/providers/Microsoft.Compute/virtualMachines/vm-test-weu-fnd-jump-box-tmp0371/providers/Microsoft.Authorization/roleManagementPolicies/1c0163c0-47e6-4577-8991-ea5c82e286e4","name":"1c0163c0-47e6-4577-8991-ea5c82e286e4","properties":{"rules":[{"id":"Expiration_Admin_Eligibility","isExpirationRequired":false,"maximumDuration":"P365D","ruleType":"RoleManagementPolicyExpirationRule","target":{"caller":"Admin","enforcedSettings":[],"inheritableSettings":[],"level":"Eligibility","operations":["All"],"targetObjects":[]}},{"id":"Approval_EndUser_Assignment","ruleType":"RoleManagementPolicyApprovalRule","setting":{"approvalMode":"SingleStage","approvalStages":[{"primaryApprovers":[{"id":"<group-id>","userType":"Group"}]}],"isApprovalRequired":true,"isApprovalRequiredForExtension":false,"isRequestorJustificationRequired":true},"target":{"caller":"EndUser","enforcedSettings":[],"inheritableSettings":[],"level":"Assignment","operations":["All"],"targetObjects":[]}},{"id":"Notification_Admin_Admin_Eligibility","isDefaultRecipientsEnabled":true,"notificationLevel":"Critical","notificationType":"Email","recipientType":"Admin","ruleType":"RoleManagementPolicyNotificationRule","target":{"caller":"Admin","enforcedSettings":[],"inheritableSettings":[],"level":"Eligibility","operations":["All"],"targetObjects":[]}},{"id":"Notification_Admin_Admin_Assignment","isDefaultRecipientsEnabled":true,"notificationLevel":"Critical","notificationType":"Email","recipientType":"Admin","ruleType":"RoleManagementPolicyNotificationRule","target":{"caller":"Admin","enforcedSettings":[],"inheritableSettings":[],"level":"Assignment","operations":["All"],"targetObjects":[]}},{"id":"Notification_Admin_EndUser_Assignment","isDefaultRecipientsEnabled":true,"notificationLevel":"Critical","notificationType":"Email","recipientType":"Admin","ruleType":"RoleManagementPolicyNotificationRule","target":{"caller":"EndUser","enforcedSettings":[],"inheritableSettings":[],"level":"Assignment","operations":["All"],"targetObjects":[]}}]},"type":"Microsoft.Authorization/roleManagementPolicies"}

Affected Resource(s)
RoleManagementPolicy
Output of pulumi about
CLI
Version      3.130.0
Go Version   go1.22.6
Go Compiler  gc
Plugins
KIND      NAME          VERSION
resource  azure         6.11.0
resource  azure-native  2.65.0
resource  azure-native  2.58.0
resource  command       1.0.1
language  nodejs        unknown
Host
OS       ubuntu
Version  22.04
Arch     x86_64
Additional context
No response
Contributing
Vote on this issue by adding a 👍 reaction.
To contribute a fix for this issue, leave a comment (and link to your pull request, if you've opened one already).

Hi @dimitar-dimitrow thanks for getting in touch.
It's not immediately obvious at which stage this information might be being dropped. I don't see any issues in the upstream TF provider repo, but it might just have not been spotted. The next state will likely be to have to run the provider under a debugger to step through the transformations.
For reference, here's the implementation of the create in the version you're using (6.11.0):
https://github.com/hashicorp/terraform-provider-azurerm/blob/391b165/internal/services/authorization/role_management_policy_resource.go#L364-L403

Here's what the values look like in the debugger after getting deserialized in the TF provider in the Create() method.

Looking closer at the upstream code, the codepaths for the create and the update are identical.

I'm going to have to park this for now. As far as I can see, the transformation from the values in the SDK is accurate to what we pass to the upstream provider. What's not clear is how the upstream provider turns that model into the go-azure-sdk update model. This is done in the buildRoleManagementPolicyForUpdate method.

Here's the source for deciding if to add the Expiration_Admin_Assignment entry:
https://github.com/hashicorp/terraform-provider-azurerm/blob/764d84dcbb987458e3a3c0f36dcb48d3d8936af9/internal/services/authorization/role_management_policy.go#L122-L125
When evaluating HasChange(""active_assignment_rules.0.expiration_required") it returns false because the existing value (o) is has a default value of false and the new value (n) is also false:

The Expiration_Admin_Eligibility doesn't have this issue because it's only checking for HasChange("eligible_assignment_rules").
It's most likely also an issue in the upstream provider. Alternatively, there could be a subtle difference between how the default value is populated by the pulumi-terraform-bridge.

@danielrbradley, thanks for the investigation!
Indeed the culprit is the terraform provider. Those policies are generated by azure and filled with default values. As they are not really created by pulumi(terraform) provider, my suggestion was that on create they are loaded(read) from azure and than checked for changes. However, this is not the case and the default/empty golang values are used for initial comparison.
Should I proceed with raising the issue to the terraform repo?
A workaround is to specify a non empty expireAfter field for the activeAssignmentRules. It is evaluated together with expirationRequired, will not match the default golang empty string and the activeAssignmentRules will be included to the PATCH call.

I think the next step will be to confirm if it's actually a bug when running the provider via Terraform as the bridging process for Pulumi sometimes has slightly different behaviour. If the same bug appears when running via Terraform then we can log this with the provider, otherwise we can log it as an issue in the pulumi-terraform-bridge.


Add assertions

Currently, some of the commands in InTrack do not use assertions. Let's add assertions to the code.

Codecov Report
Base: 71.42% // Head: 70.61% // Decreases project coverage by -0.81% :warning:

Coverage data is based on head (1a5a5f4) compared to base (3760992).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #219      +/-   ##
============================================
- Coverage     71.42%   70.61%   -0.82%
- Complexity      631      637       +6
============================================
  Files           106      106
  Lines          2009     2025      +16
  Branches        226      237      +11
============================================
- Hits           1435     1430       -5
  Misses          505      505
- Partials         69       90      +21

Impacted Files
Coverage Δ

...a/seedu/intrack/logic/commands/AddTaskCommand.java
90.90% <0.00%> (-9.10%)
:arrow_down:

...va/seedu/intrack/logic/commands/DeleteCommand.java
86.66% <0.00%> (-13.34%)
:arrow_down:

...edu/intrack/logic/parser/AddTaskCommandParser.java
61.90% <0.00%> (-8.10%)
:arrow_down:

...eedu/intrack/logic/parser/DeleteCommandParser.java
71.42% <0.00%> (-28.58%)
:arrow_down:

...eedu/intrack/logic/parser/SelectCommandParser.java
71.42% <0.00%> (-28.58%)
:arrow_down:

.../intrack/logic/parser/DeleteTaskCommandParser.java
71.42% <0.00%> (-28.58%)
:arrow_down:

...va/seedu/intrack/logic/commands/SelectCommand.java
86.66% <0.00%> (-13.34%)
:arrow_down:

...eedu/intrack/logic/parser/StatusCommandParser.java
60.00% <0.00%> (-11.43%)
:arrow_down:

...va/seedu/intrack/logic/commands/StatusCommand.java
64.00% <0.00%> (-8.73%)
:arrow_down:

... and 4 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


torch.compile each TransformerBlock instead of the whole model

This way we could temporarily enable 2-D parallel compile, and it might make sense to do transformer block compile in the future with PP (which we'll see).
We should figure out the dynamic shape issue though

Should we be able to close https://github.com/pytorch/torchtitan/issues/61 after this PR?
Also, do we need to run end-to-end numerics testing?

Should we be able to close #61 after this PR?
Also, do we need to run end-to-end numerics testing?

@awgu yeah I think it should resolve that, I'll do some e2e benchmarking before landing, so this would likely take a while

I'll break up some other changes to land them first

when PP is present, we may torch.compile the whole stage module, which is bigger than a transformer block, i.e.
pipe = pipeline(model, ...)
stage_mod = pipe.get_stage_module(stage_idx)
stage_mod = torch.compile(stage_mod)
stage = PipelineStage(stage_mod, ...)

It would also allow the code to be more model-agnostic -- there is no transformer_block, layer_id or model.layers here.

Apart from compiling each layer separately, you could also compile tok_embeddings, output and norm in the same way

In my case, enabling compilation in this way (per-layer) causes a memory leak

In my case, enabling compilation in this way (per-layer) causes a memory leak

🤔 interesting, how did you observe that?
fwiw this doesn't work out of box, as it trigger some non-trival numeric issues, I'm going to leave this PR here until I resolved it. Opening a new PR to turn dynamic shape off so that it works for both 1D and 2D compile

With each iteration, the memory usage increases and eventually results in OOM. However, just to be clear, I haven't tested this on your entire code, only on a part of it. Adding per-layer compilation causes a memory leak with each iteration. I know that the memory leak might be related to my implementation, so I just wanted to bring this issue to your attention. If you don't observe this in your code, then it's likely an issue on my end.
Meanwhile, I didn't observe the numerical issues you mentioned, unless they are a direct consequence of the memory leak. The loss function appears practically the same with layer compilation both enabled and disabled.

going to merge this given that:

2D compile currently broken and this PR work arounds it and make TP can be compiled again (we should separately figure out the full model compile issue) cc @bdhirsh
per-TransformerBlock compile would give us potential later once the cache reusing in torch.compile enabled, it would drastically improve the compile (code start and warm start) time.


Removed pinned/promoted code from finder frontend

What
We have introduced code to pin content to the top of each group in the finder. This is done by adding these content items to ordered_related_items on the finder itself.
Prepare a PR to remove the pinning code from finder-frontend (to remove the display of pinned content in the finder).
Do not merge until the change is approved by BEIS.
Why
This is tech debt that is only used by this finder. If users are not finding pinning useful, it should be removed.
https://trello.com/c/juwsyjhP/160-remove-pinning-code-from-finder-frontend

Search page examples to sanity check:

http://finder-frontend-pr-1202.herokuapp.com/search/all
http://finder-frontend-pr-1202.herokuapp.com/search/research-and-statistics
http://finder-frontend-pr-1202.herokuapp.com/search/advanced?group=guidance_and_regulation&topic=%2Feducation
http://finder-frontend-pr-1202.herokuapp.com/drug-device-alerts
http://finder-frontend-pr-1202.herokuapp.com/find-eu-exit-guidance-business

Other finders

@brucebolt - Tests are now passing, are you happy to approve?


Cleanup of legacy code

The aim of this PR is to remove stuff that was added by me and that I am sure that we don't use in the future.
Slight modification of the db.py code will be used in the future, but it will stay in the repository history, so no need to keep this unused code in the master branch.

The fact that tests fail is unfortunate - the only way how to make the test_start file PEP8-compliant is to remove blank lines and unused import, which is the same as removing the file. Which may cause issues with other PRs.


Check translatability of achievements

The achievements got merged to develop. It would be great if someone (@daPhipz?) could try to translate them and provide some feedback. This requires a lot of creativity, most of them cannot translated directly...
Spoiler Alert: You can use the dconf-Editor for cheating, ... uhm ... testing, I mean :wink:

Hey @Schneegans
Can you start to use https://weblate.org/? it's opensource and self-hostable tool but cloud service free for libreprojects https://hosted.weblate.org/hosting/ it's quite difficult to do that locally and there're proprietary platforms similar crowdin, transifex.

Thanks for the ping!
I am working this weekend, but may find some time here and there. So no promises ;)

@naDevi: I am kind of hesitant to use online tools because I used Zanata before and the experience was at best mediocre. My main issue was that basically all localizations had to be contributed via Zanata, else there would be massive conflicts.
However, I had a quick look at weblate and it seems to be much better in this regard. It seems to support automatic pull requests on GitHub which would solve the issue I had with Zanata. So thank you for the hint, I will test this!

Just tested it and the first PR was already created by the Weblate bot :D ... Seems to work quite nicely! I will play around some more. Here's the project:
https://hosted.weblate.org/projects/fly-pie/core/

So we should contribute translations exclusively over Weblate now, or are direct PRs to the repo still accepted? I'm not against that or anything, just wanted to know the "official" way ;)

I would like to support both. But we have to test this :). As long as the template is not updated too often, I could work, I guess.

Ok, i'll use Weblate then. If I have the time, I'll propose an update to the README docs on translating as well.

In fact, you could try to translate some of the strings with standard offline tools and make a PR and the other half using Weblate. Then we will see what happens :)

Good idea!

A difficulty with this approach is definitely that it's more involved for translators to actually test their localization. If you update the translation guide, @daPhipz, it would be great to describe how to test the translation.
Weblate seems to create a PR as soon as someone edits a translation (e.g. https://github.com/Schneegans/Fly-Pie/pull/104) and I would like to encourage translators to checkout the bot's branch (https://github.com/weblate/Fly-Pie/tree/weblate-fly-pie-core) and check how everything looks. Of course this is not necessary if someone 'just' fixes a string here and there but for entirely new translations, this would be a good practice, I guess.
Also, we should add more comments to help translators on their way. If you cannot easily test where the translated strings show up, this becomes even more important.

Thanks^^ @Schneegans
I like online tool because it reduce the fever fall into translator. It helps to track source string modifications, added new strings, provide instant translations to project, multiple translators able to contribute individually and simultaneously etc
eg: if i maintain 20 projects specific language translations then atlaest every few months i have to check for changes one by one.

So should we contribute translations exclusively over Weblate now, or are direct PRs to the repo still accepted? I'm not against that or anything, just wanted to know the "official" way ;)

@daPhipz you can upload offline translation directly to weblate then it's like alternative option to PR and it's possible to save translation as suggestion without login to account (but you need to login for direct saving)

@daPhipz: Maybe you could add this hint to the updated translation guide:

Most achievements have five tiers. In these cases, you can use a %i and / or a %s in the achievement's name. In English, %i will be replaced by the corresponding roman tier number (I, II, III, ...) and %s will be replaced by one of the attributes ('Novice', 'Master', ...). Both of these can be translated as well, so you may get quite creative here :).

I'll add a similar note to the Weblate UI. Currently it's a source code note which is not easy to find in Weblate. So I'll add it there as a manual explanation.

Fly-Pie just got approved as "libre" project on Weblate!
@daPhipz: If you haven't started on the translation guide update, I'll do this later today. So you can spend your time on the actual translation :)

I just updated the guide. Feel free to improve it!
https://github.com/Schneegans/Fly-Pie/blob/develop/docs/translating.md

Fly-Pie just got approved as "libre" project on Weblate!

Woop woop! 🎉
No, I didn't start yet. Had some veeery busy days at work, so I preferred relaxing over FOSS work in my free time 😓

Will you guys be able to work on the translations in the coming days? I plan to release Fly-Pie 6 on the 9th of May
@daPhipz, if you do not have the time until then, I can make an initial attempt on the German translation as well!

@daPhipz: I started working on the German translation via Weblate. Feel free to contribute there if you find the time. But you should not try to use offline tools now, else we'll get severe conflicts :smile:


⚠ Bofrost.at has degraded performance

In a2e59d1, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 909 ms

Resolved: Bofrost.at performance has improved in d9aedfa after 23 minutes.


ocamlPackages.melange: disable checks & disable for OCaml 5.0

This fixes current melange packages and makes them compatible with future update of dune.

melange-4.0.0-414 does not build with OCaml 5.0.0
test suite of melange-4.0.0-414 fails in nixpkgs with OCaml 4.14.2
test suite of melange-4.0.0-51 fails in nixpkgs with OCaml 5.1.1
test suite of melange-4.0.1-52 would fail in nixpkgs with OCaml 5.2.1 when updating dune to 3.17.0

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Gentle reminder

To whom?


Extension 'autopep8' is configured as formatter but it cannot format 'Pyton'-files

I have latest stable version of the autopep8 extension.
I have configured it exactly as requested:
"[python]": {
    "editor.defaultFormatter": "ms-python.autopep8"
},

There is no "python.formatting.provider" set anywhere. Not in user nor in workspace/folder settings.
I don't have autopep8 python package installed, so I expect the extension is using its own.
The formatting does not work, whatsoever. When trying to format manually using "Format Selection" command, I get this error:

The selection popup doesn't list autopep8 as available for formatting Python files:

Windows 11 22H2
VSCode 1.83.1
autopep8 v2023.6.0
Happens both with global environment as well as virtual environment.
Here's the log:
autopep8.log

This is fixed pre-release please give it a try.
Note that this happens when you try to format with selection. You should be able to still format whole documents using the "formatt Document " command.

I am still getting this issue currently


[Android][Linux] Replace launchChromeDevTools.applescript for Linux

Launching the Chrome DevTools from Android doesn't work on Linux because it requires applescript.
The launchChromeDevTools.applescript should be replaced by something cross-platform like bash.
I know that Linux isn't officially supported, but it works for the most part. :smile:  (I just tested the tutorial and live-reloading)

Thanks @ChristianHersevoort. We have a couple of people internally that use it on Linux. We prioritize smooth user experience with setting up sample project. Except from a couple of places where we use shell scripts it works fine on both linux and windows. Feel free to send PR, I'll leave this issue open

There is a PR open #2406. @ChristianHersevoort could you please take a look and check if it works for you?

#2406 only fixes applescript use to launch chrome devtools, there is another one we use in react-native run-android command that we use to start packager in new terminal window.

@frantic It works!

I only had too rebase it and change it to use chromium!

Merging to master linux support task #2693


download component not work under .net6

Describe the bug
download component not work under .net6
To Reproduce
change framework to .net6 . It reports error as Microsoft.JSInterop.JSException:"t.replace is not a funtion at Function.base64DecToArr"

Further technical details

BootstrapBlazor version 5.19
Include the output of dotnet --info
The IDE (VS / VS Code/ VS4Mac) you're running on, and its version 2022

@yuandongxiao thanks for contacting us. it fixed v6.0.1


ATS 10 HTTP/3 assertion failure on docs server

We noticed this crash on our docs server. It happened on an HTTP/3 QUIC connection.
Assertion Failure Message
(from traffic.out)
Fatal: /home/bneradt/src/trafficserver_10/src/proxy/http3/Http3Frame.cc:59: failed assertion `ret != 1`

Traceback
Thread 3814260, [ET_NET 6]:
0    0x00007fcbdaa03510 __interceptor_waitpid.part.0 + 0x40
1    0x00005633aa59c1c1 crash_logger_invoke(int, siginfo_t*, void*) + 0x12a
2    0x00007fcbd9c06420 funlockfile + 0x60
3    0x00007fcbd9a4300b gsignal + 0xcb
4    0x00007fcbd9a22859 abort + 0x12b
5    0x00005633aa613382 ink_abort(char const*, ...) + 0x126
6    0x00005633aa60d1f6 _ink_assert(char const*, char const*, int) + 0x3b
7    0x00005633aafcc03e Http3Frame::type(unsigned char const*, unsigned long) + 0x152
8    0x00005633aafd0644 Http3FrameFactory::fast_create(IOBufferReader&) + 0xf6
9    0x00005633aafa6963 Http3FrameDispatcher::on_read_ready(unsigned long, Http3StreamType, IOBufferReader&, unsigned long&) + 0x90d
10   0x00005633aaf9c134 Http3Transaction::_process_read_vio() + 0x47a
11   0x00005633aaf96ed8 HQTransaction::do_io_read(Continuation*, long, MIOBuffer*) + 0x1fc
12   0x00005633aa6f6122 HttpSM::attach_client_session(ProxyTransaction*) + 0x904
13   0x00005633aacc90c3 ProxyTransaction::new_transaction(bool) + 0x65d
14   0x00005633aaf877c8 Http3App::_handle_bidi_stream_on_read_ready(int, VIO*) + 0x412
15   0x00005633aaf857dc Http3App::main_event_handler(int, Event*) + 0x47c
16   0x00005633aa5aa84b Continuation::handleEvent(int, void*) + 0x1e3
17   0x00005633aaf194d5 EThread::process_event(Event*, int) + 0x347
18   0x00005633aaf19a29 EThread::process_queue(Queue<Event, Event::Link_link>*, int*, int*) + 0x1d5
19   0x00005633aaf19fc0 EThread::execute_regular() + 0x3d6
20   0x00005633aaf1aa6c EThread::execute() + 0x30c
21   0x00005633aaf1770d spawn_thread_internal(void*) + 0x14e
22   0x00007fcbd9bfa609 start_thread + 0xd9
23   0x00007fcbd9b1f353 clone + 0x43

Initial Investigation
src/http3/Http3Frame.cc
Http3FrameType
Http3Frame::type(const uint8_t *buf, size_t buf_len)
{
  uint64_t type              = 0;
  size_t   type_field_length = 0;
  int      ret               = QUICVariableInt::decode(type, type_field_length, buf, buf_len);
  // [ANNOTATION] This is the failing assertion.
  ink_assert(ret != 1);

src/iocore/net/quic/QUICIntUtil.cc
int
QUICVariableInt::decode(uint64_t &dst, size_t &len, const uint8_t *src, size_t src_len)
{
  if (src_len < 1) {
    return -1;
  }
  len = 1 << (src[0] >> 6);
  if (src_len < len) {
    // [ANNOTATION] This is where the unexpected return value originates.
    return 1;
  }

Analysis
Is it correct to assert for ret != 1 here, or did we intend to assert for ret != -1, for the error condition?

I discussed it with @maskit and we concluded that the 1 return code means not enough data was provided.

I have discovered the root cause of the crash (it wasn't as hard as I expected):
src/proxy/http3/Http3Frame.cc

std::shared_ptr<Http3Frame>
Http3FrameFactory::fast_create(IOBufferReader &reader)
{
  // FIXME Frame type can be longer than 1 byte
  uint8_t type_buf[1];
  reader.memcpy(type_buf, sizeof(type_buf));
  Http3FrameType type = Http3Frame::type(type_buf, sizeof(type_buf));

It could be anything. Bad stream data from a buggy client, bad stream data broken by other parts in ATS, bad stream data from an attacker, or a legit extension. In any case, what we have to do there is ignoring the frame. The thing is that the length of a frame type can be exa bytes.


Fix Running On Device guide for iOS

#10726 incorrectly shown Android instructions when iOS is selected (you can see it on the first screenshot in the pull-request). I removed those and added the old notice about WiFi and the hint to open the Developer Menu.
Doing this from web so won't be able to screenshot the results. (also inadvertently deleted a line, oh well...)

Wow, this is indeed incorrect: http://facebook.github.io/react-native/docs/running-on-device.html
Thanks!


Provide embedded icons for system buttons

The keyboard switcher, backspace button, enter button etc. have icons that should be added to the library, as embedded images.

I'm not so sure that this is a good idea. I'm closing this ticket until someone requests this feature.


[com.google.fonts/check/layout_valid_language_tags] RHG language tags causes a FAIL

Observed behaviour
A font with RHG language tag in a FAIL in com.google.fonts/check/layout_valid_language_tags even though the tag is valid according to OpenType language tag registry: https://docs.microsoft.com/en-us/typography/opentype/spec/languagetags
Expected behaviour
Font passes.
Resources and exact process needed to replicate
Scheherazade New
$ fontbakery check-profile fontbakery.profiles.layout ScheherazadeNew-Regular.ttf -C
Start ... running 3 individual check executions.
 >> com.google.fonts/check/layout_valid_language_tags
    Does the font have any invalid language tags?
    with /Users/khaled/Downloads/ScheherazadeNew-3.300/ScheherazadeNew-Regular.ttf

      Rationale:
      Incorrect language tags can be indications of typos, leftover debugging
      code or questionable approaches, or user error in the font editor. Such
      typos can cause features and language support to fail to work as intended.

     FAIL The following invalid language tags were found in the font: RHG
          [code: bad-language-tags]

    Result: FAIL

Total:

    ERROR: 0
    FAIL: 1
    WARN: 0
    INFO: 0
    SKIP: 0
    PASS: 2

[PPF] 100%

DONE!

    Meaning of check results:

    An ERROR is something wrong with FontBakery itself, possibly a bug.
    A FAIL is a problem with the font that must be fixed.
    A WARN is something that you should consider addressing.
    An INFO result simply prints something useful. Typically stats.
    A PASS means the font looks good for the given checking routine.
    And a SKIP happens when the check does not apply to the given font.

    If you get ERRORs, please help us improve the tool by reporting them at
    https://github.com/googlefonts/fontbakery/issues

    (but other kinds of bug reports and/or
     feature requests are also always welcome, of course!)

Thanks Khaled. This was an issue I should I have created months ago.
As it turns out, there are quite a number of langtags that have been recently added to the OpenType spec in recent months, RHG among them. IMO, FontBakery needs a process to regularly import registered tags (features, scripts, and languages) from the OpenType specification.

This would be fixed by simoncozens/opentypespec-py#2

This should now work.


Next branch deploy should redirect to the primary sub domain

Next branch deploys to
https://next.elegant.oncrashreboot.com
It also deploys to
https://next--pelicanelegant.netlify.com/
What we want is to redirect
https://next--pelicanelegant.netlify.com/ → https://next.elegant.oncrashreboot.com
I have added this line
https://github.com/Pelican-Elegant/elegant/blob/7cdb1554900e6fc59b54899dfbdd295ca78a40d1/documentation/content/extra/_redirects#L2
but it has no effect.

Close via 7cdb1554900e6fc59b54899dfbdd295ca78a40d1


How to assign consumer to listen to all partitions?

Hi,
From the example, I see that we only assign partition 0 to the consumer. if i have 10 partitions, do i need to i assign it like this:
var topics = [
{
topic: topic,
partition: 0
},
{
topic: topic,
partition: 1
},
{
topic: topic,
partition: 2
},
{
topic: topic,
partition: 3
},
{
topic: topic,
partition: 4
},{
topic: topic,
partition: 5
},{
topic: topic,
partition: 6
},{
topic: topic,
partition: 7
},{
topic: topic,
partition: 8
},{
topic: topic,
partition: 9
}
];

Hello,
Can you share your solution ??
Thank's


Feature request: Rune last seen equipped tracking

Hi Porksmash,
One thing I've been thinking would be nice for the last few months was a column to show when the a rune was last seen equipped (if ever). It would be great so I could at a glance see what runes haven't been used in a long time, and consider junking them.
I'm happy to have a go at making a pull request with this change, if you wouldn't mind pointing me in the right direction for columns on the runes page. (I have 0 familiarity with this project code so not sure where to start!)
Primax from Discord / RapnerSA(Global)

The rune model would be in herders/models.py with the actual fields starting at L1988. It's a ridiculously long file and the model is giant due to the number of constants I needed for runes, sorry.
For the implementation you're thinking, what datatype would this new column be? Datetime? Foreign key to the monster?


32

Codecov Report

Merging #33 (db38ca8) into main (fc415ee) will decrease coverage by 0.74%.
The diff coverage is 36.36%.

@@            Coverage Diff             @@
##             main      #33      +/-   ##
==========================================
- Coverage   71.46%   70.71%   -0.75%
==========================================
  Files          21       21
  Lines         771      782      +11
==========================================
+ Hits          551      553       +2
- Misses        220      229       +9

Impacted Files
Coverage Δ

controle_contas/ext/site/views.py
33.67% <30.00%> (-0.94%)
:arrow_down:

controle_contas/ext/db/models.py
90.47% <100.00%> (ø)

controle_contas/ext/site/forms.py
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fc415ee...db38ca8. Read the comment docs.


support  vhost-scsi-pci in centos7

Author Name: 海涛 肖 (海涛 肖)
Original Redmine Issue: 3027, https://dev.opennebula.org/issues/3027
Original Date: 2014-07-10

CentOS7 has supported LIO , vhost-scsi-pci can improve obvious disk performance.
This is the qemu parameter using vhost-scsi-pci:
-device vhost-scsi-pci,id=vhost-scsi0,wwpn=naa.50014051e81a1675

Original Redmine Comment
Author Name: Ruben S. Montero (@rsmontero)
Original Date: 2014-07-10T09:24:58Z

Moving it to backlog too evaluate its implementation in a future release.

Original Redmine Comment
Author Name: Ruben S. Montero (@rsmontero)
Original Date: 2014-07-10T09:28:08Z

Reassigning it to request to find out how it is exposed by libvirt.


Node 20 support

Hello, we are looking to upgrade our lambdas to node 20 but are currently blocked by this extension not supporting node 20.
It looks like the node layer version 100 added support for node 20 but when using the latest version 51 of the extension layer, the layers are not being added to our function.

Hi @sixfootsixdesigns, thanks for reaching out!
I'm not sure I understand your question, the lambda layer provided by dd-lambda-js is entirely independent of the Datadog Lambda extension provided by this project.
Neither layer adds the other.
Instead, development tools like our serverless framework plugin, cdk construct, or cloudformation macro will apply one or more layers depending on the configuration.
Depending on the tool you're using, you may need to upgrade the tool or follow along an open issue until support is added:
https://github.com/DataDog/serverless-plugin-datadog
https://github.com/DataDog/datadog-cdk-constructs
https://github.com/DataDog/datadog-cloudformation-macro
https://github.com/DataDog/datadog-ci
Thanks!

looking at this file: https://github.com/DataDog/datadog-lambda-extension/blob/main/build-tools/src/commands/deploy_function_command.rs#L172 there is no support for the nodejs20.x runtime. So when using this extension, the layers are not added to the lambda

Hi, sorry for the confusion.
The code in this repository (including what you've linked to) is not part of our extension. Instead these are build tools we use to compile and release our extension. The contents of the build-tools directory is only used for a github workflow we use in this project for testing new release candidates.
Our extension code lives here: https://github.com/DataDog/datadog-agent/tree/main/pkg/serverless
The extension logic is completely independent of any runtime. It doesn't add layers at all on its own.
We do that with IAC integrations. Depending on your chosen infrastructure-as-code integration, you may need to upgrade so you can use node20 with Datadog.
Please let me know if you have any questions.
Thanks!

ahh i got crossed up. the issues was with datadog-cdk-constructs and looks like 2.10.0 adds the support that was missing. Thanks!


⚠ ClamAV has degraded performance

In 9737418, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 68 ms

Resolved: ClamAV performance has improved in 3c71777 after 5 minutes.


Cloud Stub Runner Boot Application and Cloud Stream (Kafka) for Smoke Test doesn't work

In August i opened issue in  stack overflow. I have upgraded to the Finchley.SR2 and have the same problem. I have also seen that github-analytics-stub-runner-boot sample has been upgraded to the Finchley.SR1 and I use the same configuration that in the sample. I think the problem is still StreamsRelatedAutoConfiguration. It could be nice set @ConditionalOnProperty(     name = {"stubrunner.stream.test.enabled"},     havingValue = "true",     matchIfMissing = true ) to excude TestSupportBinderAutoConfiguration
Thanks

Can you file a pull request?

If you would like us to look at this issue, please provide the requested information. If the information is not provided within the next 7 days this issue will be closed.

Closing due to lack of requested feedback. If you would like us to look at this issue, please provide the requested information and we will re-open the issue.


[Impeller] Swapchain acquisition can time out on S10.

Noticed on wonderous when opening the menus.

maybe we should treat this error condition similar to an out of date result.

What is the error code returned? Presumably, this is on the acquireNextImage call?

eTimeout on acquireNextImage

Hmm, we specify an infinite timeout on that call. So didn't think this could happen. Reading up on the spec.

Ok, this answer seems to be instructive.

I guess this was running on my concurrent encode patch, and in theory we could definitely exhaust the swapchain images there...

Closing this for now but we can re-open when we move present to its own thread.


Add support for multiple languages

Hello, would it be possible to create something like lang.json file where you could edit every text used in GUI so it could be used to translate the script for another language(s)? Thanks

Hello o/
An interesting concept. Unfortunately, it's not easily doable in an automatic way. Translation would have to be an opt-in feature, that'd have to be manually targeted at every field that'd need to be translated - it'd just require work to design, code in and setup the translation backend.
What is the demand on this feature? Is this something you're interested in only, or is there more people who'd like the app to be translated? If anything, I'd appreciate some other people commenting on this issue if they'd be interested in this becoming a thing.

After some personal discussion with another user, I've decided to go ahead and implement this as a feature. Chinese translation will be available together with the v12 release.

This is now available as a feature in v12: https://github.com/DevilXD/TwitchDropsMiner/releases


Issue #9 correction

Correction in security requirements.

Issue #9 correction - no feedback for the last ten days, since this is a minor bug correction (2 lines in total), I am merging the PR.


Better thread identifiers

We currently use the identifiers provided by 3box. Ideally, there would be a way to register a better identifier for the threads. Maybe @3box supports that?

Done!


runtime: wasm: all goroutines asleep and no JavaScript callback pending - deadlock

I've seen a few trybot flakes on wasm like:
https://storage.googleapis.com/go-build-log/fd762fcb/js-wasm_280bcf2c.log (from wasm-unrelated https://go-review.googlesource.com/c/go/+/123779)
ok  	math/bits	1.768s
ok  	math/cmplx	1.762s
ok  	math/rand	4.233s
ok  	mime	1.705s
ok  	mime/multipart	6.236s
ok  	mime/quotedprintable	3.097s
ok  	net	2.596s
error: all goroutines asleep and no JavaScript callback pending - deadlock!
FAIL	net/http	15.608s
2018/07/13 22:17:40 Failed: exit status 1

I think I ran into the same issue with https://play.golang.org/p/Ymt6QgfYH93. Not sure if I'm underestimating the complexity of the fix.

@xudongzheng Your issue is unrelated to the flake above. Please see https://tip.golang.org/pkg/syscall/js/#NewCallback on why it happens.

@kaskavalci - You have successfully repeated the issue in https://github.com/golang/go/issues/26382#issuecomment-409898574. See the comment above.

Oh 🤦♂
For someone who is looking for a quick answer, just wrap your request in a go-routine because

A blocking callback should therefore explicitly start a new goroutine.

example := func(i []js.Value) {
	go func() {
		fmt.Println(http.Get("http://localhost:9276/"))
	}()
}
js.Global().Set("example", js.NewCallback(example))
select {}

@gopherbot please file this to be considered for backport to 1.11.

@bradfitz Is there a way to search the trybot logs for this flake?

https://github.com/aclements/go-misc/tree/master/greplogs

According to the logs, the last time this happened was on 2018/07/19. I'd say we can close this.

I'm getting a similar error after upgrading from Go 1.12 to 1.13:
fatal error: all goroutines are asleep - deadlock!

@danaugrs Please open a new issue, we don't track closed issues, and that's a pretty generic error.

@FiloSottile I figured it out, the problem was reading from the channel of a time.Timer inside the requestAnimationFrame callback. The behavior must have changed from 1.12 to 1.13 but I'm not sure which is correct. I'll open an issue if it turns out to be a blocker for me.

I attempted the solution of wrapping the request in a go-routine.
The same errors appears:
fatal error: all goroutines are asleep - deadlock!
wasm_exec.js:47 goroutine 1 [select (no cases)]:
go version go1.14.4 linux/amd64
func query(this js.Value, args []js.Value) interface{} {
	var rv interface{}

	c1 := make(chan string)
	go func() {
		c1 <- makeRequest()
	}()

	target:= fmt.Sprintf("%s", args[0]) + "Result"

	select {
	case color := <-c1:
		js.Global().Get("document").Call("getElementById", target).Set("innerHTML", color)
	}
	return rv
}

Any pointers?

if use goroutine, how return value to frontend ?

this still happens to me with go version go1.17 darwin/amd64
package main

import (
	"io/ioutil"
	"log"
	"net/http"
	"syscall/js"
)

func add(this js.Value, args []js.Value) interface{} {
	resp, err := http.Get("https://jsonplaceholder.typicode.com/posts")
	if err != nil {
		log.Fatalln(err)
	}
	//We Read the response body on the line below.
	body, err := ioutil.ReadAll(resp.Body)
	if err != nil {
		log.Fatalln(err)
	}
	//Convert the body to type string
	sb := string(body)
	log.Printf(sb)

	return nil
}

func main() {
	c := make(chan struct{}, 0)
	js.Global().Set("add", js.FuncOf(add))
	<-c
}

result: https://github.com/golang/go/issues/26382#issuecomment-416918384
running this in a goroutine works:
package main

import (
	"io/ioutil"
	"log"
	"net/http"
	"syscall/js"
)

func add(this js.Value, args []js.Value) interface{} {
	go func() {
		resp, err := http.Get("https://jsonplaceholder.typicode.com/posts")
		if err != nil {
			log.Fatalln(err)
		}
		//We Read the response body on the line below.
		body, err := ioutil.ReadAll(resp.Body)
		if err != nil {
			log.Fatalln(err)
		}
		//Convert the body to type string
		sb := string(body)
		log.Printf(sb)
	}()

	return nil
}

func main() {
	c := make(chan struct{}, 0)
	js.Global().Set("add", js.FuncOf(add))
	<-c
}

@loeffel-io Your issue is unrelated to the flake above. Please see https://pkg.go.dev/syscall/js@master#FuncOf on why it happens.

My fault - thanks! @neelance


pnpx svelte-add whatever doesn't work on Windows

EISDIR: illegal operation on a directory, read

Just FYI, seems completely broken on windows now

I think the problem lies way further down the road then this package, I will share my current thoughts below
I create and published svelte-add-test. This "package" essentially consists of two files:
// package.json
{
  "name": "svelte-add-test",
  "version": "0.0.1-alpha-4",
  "description": "",
  "main": "index.js",
  "bin": "index.js",
  "scripts": {
    "test": "echo \"Error: no test specified\" && exit 1"
  },
  "author": "",
  "license": "ISC",
  "dependencies": {}
}

// index.js
#! /usr/bin/env node
console.log("juhuu")

I have not uploaded to github or anything, because there really is not more.
Even with this, the error occurs. Currently looking into how to further debug pnpx

Thank you so much for your help investigating!!

Thank you so much for your help! This is now fixed permanently (hopefully).