Waiting for TaskCompletionSource blocks other requests

When waiting for a TaskCompletionSource in an async request handler it seems that all other requests are blocked until the TaskCompletionSource is completed.
Reproducer (tested with SelfHost):
public class SampleModule : Nancy.NancyModule
{
    public SampleModule()
    {
        // Should return after 10 seconds
        Get("/threader", async (p)=>
        {

            var resultSource = new TaskCompletionSource<DateTime>();

            var thread = new Thread(
                () =>
                {
                    Thread.Sleep(10000);
                    resultSource.SetResult(DateTime.Now);
                }
            );
            thread.Start();

            var finished = await resultSource.Task;

            return string.Format("Thread finished at: {0}", finished);
        });

        // Should return right away
        Get("/echo", (p) =>
        {
            return "Echo?";
        });
    }
}

If you navigate to /threader in a browser tab and then open another tab and navigate to /echo, /echo won't respond until /threader completes also.
My guess is that it's because the wrapped Task never transitions to the 'Running' state, see: http://stackoverflow.com/questions/14836995/is-there-a-way-of-setting-a-task-driven-via-taskcompletionsource-to-status-runn
Tested with 2.0.0-clinteastwood, apologies if it's fixed in head.

No, I just tried with a OwinHost and it does not seem to block other requests.
In fact, after some more testing it seems that all async requests blocks other requests when using Nancy.Hosting.Self. For example:
public class SampleModule : Nancy.NancyModule
{
    public SampleModule()
    {
        // Should return after 10 seconds
        Get("/threader", async (p, ct) =>
        {
            await Task.Delay(10000);

            return string.Format("Thread finished at: {0}", DateTime.Now);
        });

        // Should return right away
        Get("/echo", (p) =>
        {
            return "Echo?";
        });
    }
}

So I guess that core issue is that async blocks on Nancy SelfHost.

Thank you for checking.
On 9 Mar 2017 9:13 a.m., "Andreas Karlsson"<EMAIL_ADDRESS>wrote:

No, I just tried with a OwinHost and it does not seem to block other
requests.
In fact, after some more testing it seems that all async requests blocks
other requests when using Nancy.Hosting.Self. For example:
public class SampleModule : Nancy.NancyModule
{
public SampleModule()
{
// Should return after 10 seconds
Get("/threader", async (p, ct) =>
{
await Task.Delay(10000);
        return string.Format("Thread finished at: {0}", DateTime.Now);
    });

    // Should return right away
    Get("/echo", (p) =>
    {
        return "Echo?";
    });
}

}
So I guess that core issue is that async blocks on Nancy SelfHost.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/NancyFx/Nancy/issues/2714#issuecomment-285283879, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AADgXD8Pd_ZTaYtQw9SRzDUctaPGVJiZks5rj7TCgaJpZM4MWmO9
.

I think this might be because we're awaiting the request processing here. See this comment on the PR that introduced it. This is a pretty serious bug.

@khellang want me to send in a pr reverting that one line?

I think we should get #2697 in first :smile:

I just got #2697 fixed from my git gaffe, and we should be able to have this resolved soon:tm: .

@andreasjhkarlsson Would you be able to pull the latest NuGet package from the MyGet feed and see if you can reproduce this now?

2.0.0-Pre1846 still shows the same issue. Full reproducer solution here: https://minfil.org/l2sex6b4bd/reproducer.zip

ping @khellang @damianh

https://github.com/NancyFx/Nancy/blob/ceea69506b9270c94cba231e0bf459897077058b/src/Nancy.Hosting.Self/NancyHost.cs#L127-L142
^This looks fairly broken. It is handling one request at a time. It's not related to the TaskCompletionSource in OP's report per se.
https://github.com/aspnet/AspNetKatana/blob/dev/src/Microsoft.Owin.Host.HttpListener/OwinHttpListener.cs#L201-L202
^ Here you can see the MS Owin impl spawns a task for each request but it also does reference counting, "pump limits" etc.
I don't think I've ever used the Nancy.Hosting.Self; I've always used the MS Owin HttpListener host for my self hosting needs. (There is also OwinWebListenerHost).
@NancyFx/most-valued-minions My opinion is to kill Nancy.Hosting.Self package. If it stays it needs a rewrite.
@andreasjhkarlsson In the mean time, use the MSOWIN host. V4 is on the way, so there is some legs left in it.
There is a v4 of owin http listener https://github.com/aspnet/AspNetKatana/milestones

This must have been broken fairlyish recently, it never used to only process one request at a time, but last time I looked at the code was probably pre-asyncawait updates.

This is from #2548 which is what I had asked about reverting in https://github.com/NancyFx/Nancy/issues/2714#issuecomment-285353026

We actually changed Self Host earlier this year with this PR to resolve it only processing one request at a time with #2697.  I might be missing something here though :D

Kestrel is the way to go
On Sep 18, 2017 01:30, "David Young"<EMAIL_ADDRESS>wrote:

We actually changed Self Host earlier this year with this PR to resolve it
only processing one request at a time with #2697
https://github.com/NancyFx/Nancy/pull/2697. I might be missing
something here though :D
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/NancyFx/Nancy/issues/2714#issuecomment-330098645, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ABPNXx99hmxl8ngbMS92X2tuSisFtESAks5sjZ1ogaJpZM4MWmO9
.

Kestrel is nice, but the problem for use is that its public API is based on AspNet's HttpContext which is unfortunate.

@damianh https://github.com/khellang/KestrelPureOwin 😉

See the dependency graph? Not pure unfortunately.

That's nothing. Most of it isn't even used (the HTTP abstractions etc.). I bet you could trim some of the assemblies and it'd still run. And if you're targeting .NET Core 2.0, you already have it all on disk (it's not part of publish)

Depends how you publish ie standalone app
On 25 September 2017 at 22:39, Kristian Hellang<EMAIL_ADDRESS>wrote:

That's nothing. Most of it isn't even used (the HTTP abstractions etc.). I
bet you could trim some of the assemblies and it'd still run. And if you're
targeting .NET Core 2.0, you already have it all on disk (it's not part of
publish)
—
You are receiving this because you are on a team that was mentioned.
Reply to this email directly, view it on GitHub
https://github.com/NancyFx/Nancy/issues/2714#issuecomment-332021504, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAGapu8OWpZ50tWYiQJGlqCy4a7q8WIXks5smB2CgaJpZM4MWmO9
.

What's the path to fix this? Self-hosting is useful exactly because it has no dependencies.

Any news?

This has already been fixed in #2697

Yep, just tested with latest builds. When it will be published to nuget.org?

According to #2872, sometime this week or next.

Has this bug fix been released on NuGet?

Apparently not since the NancyHost options introduced in the commit are not available.
It would be really nice to have a snap 1.X release for Nancy.SelfHost since this is a major bug. The fix is already merged so hopefully releasing should be easy enough.

Pinging @thecodejunkie and @khellang

Just read in #2833 that apparently using the OWIN Self Host has been recommended "for a long time". Unfortunately I haven't seen this recommendation any in the documentation. We will try to switch to this SelfHost then.


add 'Open in Web' button

I use the extension every day. But almost always, when I copy a link, I want to open my browser and paste this to open it.
I added 'Open in Web' button when copying
maybe add an 'open/copy' option to the settings?

Great idea. Thanks for the contribution!

Great idea. Thanks for the contribution!


Viewer list does not load

Checklist

[X] I'm reporting a problem with Chatterino
[X] I've verified that I'm running the most recent nightly build or stable release
[X] I've looked for my problem on the wiki
[X] I've searched the issues and pull requests for similar looking reports

Describe your issue
This seems like it could be a network related issue. I have two separate portable Chatterino installations and both will occasionally simultaneously not allow me to load any viewer lists from any channels, it only shows 'Loading...'
This recent time it has stopped working for hours straight, usually it's only a number of minutes. It doesn't show chatter count either. This is for live and offline channels.
I have tried clearing the cache. The logs folder is empty. Launching each portable version independently of another doesn't fix it. Both installs are the same version. Everything else works fine, not sure what other info I can provide.
Screenshots
No response
OS and Chatterino Version
Chatterino 2.4.2 (commit c8204ef7) built with Qt 5.15.2, Windows SDK, MSVC 193431942, Crashpad Running on Windows 10 Version 2009, kernel: 10.0.19042

It's intentional see - https://discuss.dev.twitch.tv/t/legacy-chatters-endpoint-shutdown-details-and-timeline-april-2023/43161
Download the latest nightly build if you are a mod and require the viewerlist.
I'll add it to the pins at the top of issues later

Do you think they're ever going to allow non-moderators to use Get Chatters?

Probably not, it would likely require a major system implemented by us, and then opted into by basically every streamer, to properly restore functionality.

They even removed the ability for non-mods to see the full user list from their 1st party website, so I'd give the endpoint being available for normal chatters a practically nonexistent chance of happening.

Thank for for the responses. One more question: why would a moderator token be required for the API but not for the viewer list on their website?

Thank for for the responses. One more question: why would a moderator token be required for the API but not for the viewer list on their website?

Technically it is, you are given only a section of the viewer list as a pleb in browser chat, as a VIP or mod you can keep scrolling until you've loaded everybody


Use defaultdict for _UID_PREFIXES

The method get_uid on common.py first check if a prefix is in _UID_PREFIXED dict
and if it is not, a variable is added to the dict.
However, using a defaultdict, this check is no longer necessary.

Weird, I cannot understand the relation between the build failure and the code I have written.

I guess the rebase solved it

LGTM


Working with data structures in Python

Proposed title of article
Working with data structures in Python
Proposed article introduction
Data structures are a way of organizing and storing data so that they can be accessed and worked with efficiently. They define the relationship between the data, and the operations that can be performed on the data. There are many various kinds of data structures defined that make it easier for the data scientists and the computer engineers, alike to concentrate on the main picture of solving larger problems rather than getting lost in the details of data description and access.
In this tutorial, you'll learn about the various Python data structures and see how they are implemented:
Key takeaways
1.Abstract data types
2.Primitive data structure-integers,float, boolean and strings
3.Non primitive data structures-arrays,lists,tuples and files
4.Examples to understand and work with each data type.
5.Data type conversion.
Article quality
This article will provide an in-depth knowledge in data structures in Python . Since other blog sites only provide documentation for the data structures, I'll show the reader how to use primitive data non primitive data structures and Implementation using Python programming language. The article will also be written in an easy-to-understand manner to raise awareness of this open-source library among its users. The article will also be entertaining and expressed in a unique manner.
References
N/A

good topic @mbuthiajn  - approved. Thanks for submitting your article and we look forward to reviewing and hopefully publishing it. I’m sure our readers will enjoy and find your article very beneficial.


License model

Made changes on top of this. Please review this which is pointing this branch.

For the build issues, were you having the problem where you run pipenv run black app but no files change?
I started with a new repository and environment and I was able to at least fix those. Just pushed. Usually when that has happened locally with me I had to make sure to delete the pipenv environment, since sometimes it would import it rather than create a new one.

Commits included in #963 .


ReactiveSlider integer

I have an integer value that can either get edited in a ReactiveTextField or with a ReactiveSlider. The problem ist ReactiveSlider only accepts a FormControl<double>.
I'd like to create a ReactiveSlider with a FormControl<int>.

Hi @DevNico,
ReactiveSlider is using double because the Flutter Slider uses double by default.
Maybe we can add a control value accessor for ReactiveSlider for converting from int to double. I didn't include a value accessor for Slider, but I think is a good idea to add one. In the end, almost all other Reactive widgets have the control value accessor.
I will implement it and I will let you know
Thanks Best regards

Hi @DevNico,
I have just released a new version of Reactive Forms, version 10.3.0. In this version, you can Bind a FOrmControl of type int to a ReactiveSlider.
Don't hesitate to reopen the issue or create a new one if something is missing.
Best regards.


Update docs for proper installation of cli

got 3 errors installing cli
according to https://github.com/tauri-apps/tauri/issues/3050
the install line must be changed to pull from the next branch from github
Note: I did the cargo subcommand option when I had issues with yarn.  I got yarn running, but wanted to get docs updated for others.
I hope this makes sense.  I am just getting into tauri today.

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[x] Docs
[ ] New Binding issue #___
[ ] Code style update
[ ] Refactor
[ ] Build-related changes
[ ] Other, please describe:

Does this PR introduce a breaking change?

[ ] Yes, and the changes were approved in issue #___
[x] No

Checklist

[ ] N/A - When resolving issues, they are referenced in the PR's title (e.g fix #___, #___)
[ ] N/A - A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
[ ] N/A - I have added a convincing reason for adding this feature, if necessary

Other information

ah damn, i didn't save my comment...
Thanks for being considering contributing!
Unfortunately, this won't get merged for 2 reasons:

The next release is not that far off anymore, so it might just not be worth it, especially if we take into account that the rust cli is pretty unpopular, which is kinda sad if you ask me, but it is what it is.
The next branch of this repo will be copied into the docs repo only on new releases, so the doc change would be released together with the fix.

In theory we could do that change in the docs repo directly, but imo that's not worth because of 1)
You already turned this into a draft, but i'm gonna close it anyway. Thanks again.


missing field fee_payer_signer_index in initializer of ProgramCliCommand

I encountered this issue in crates/aqd-solana-contracts/src/solana_deploy.rs line 48

I'm unsure where the compiler sees this field because I did a project-wide search for the string "fee_payer_signer_index" and came up with nothing.

fee_payer_signer_index seems to be a field of ProgramCliCommand::Deploy in a newer version of Solana crates than v1.17.2


Added Hugging Face tools where applicable

Included a Hugging Face blog tutorial on how to train a new language model from scratch.
Created a new "Libraries and Tooling" section to allow more NLP contributors and added Hugging Face tools.

I've relocated the links to "Python" in 916d574. Let me know if you need anything else changed!


Unnecessary asking for github-token at first download settings

Visual Studio Code Version : 1.18.1
Code Settings Sync Version : 2.8.7
Operating System :  Ubuntu 16.04
Occurs On: Download
Proxy Enabled:   No
GIst Id: [ ID_HERE ]
Since the last update of this plugin to 2.8.7 I will be asked for Github-Token when doing the first download. This is really unnecessary. Before the last update we had one gist and each of us had only to enter the gist-id to get the current settings. That worked like a charme. Now, each of us must enter the github-token which is really not needed if you only want to download.
Please make that as default again.

Actually there are users which gets confused and put token in gist place in code and extension fails for them.
Either the documentation needs to improve or on boarding experience needs to improve.
thats the reason i had to do that.
I can add some setting which you can turn off in order to step asking token every time on download if you dont need to upload it.

I plead for some settings that anyone can turn on and the default should be off, alone because of compatibility reasons. The reason is that we build virtual machines for our developers via script. We only install this plugin via code --install-extension Shan.code-settings-sync and do the roll out. Each developer loads the settings from one gist and and has no need to have a github-token.

We only install this plugin via code --install-extension Shan.code-settings-sync and do the roll out.

How do you place the gist via script or just ask developers to place it manually  ?

Yep, the developers place it manually. So each developer has the possiblity to use  a gist containing his favorit settings or the settings of particular project or ....

Actually if the gist is public, there is no reason to ask for the token.
I'm currently maintaining a central gist where all the members of my team are using the same GIST, and they are only downloading the configs, not uploading.
And without a Token, the plugin is not working.

The solution i see is the users who only need to download the gist needs to enable some setting in syncLocalSetting.json file like allowUpload to false and it will only allow user to download the settings.

There is no reason to create another config item.
Only ask for the token when the user is trying to upload the configs and there is no previous token set.
This way, will be easier to the users that only wants  to download the configs from someone else, and requires no additional steps, only hit download and paste the GIST id.

can you guys set sync.anonymousGist to true and let me know if it worked.

@shanalikhan I already tried this on a new machine and it's still asking for the token

https://github.com/shanalikhan/code-settings-sync#customized-sync
Set downloadPublicGist to true and it will not ask for token.
Although this part was not required, but i had to write code intentionally.
From the version 2.0+ i kept GitHub token hidden when downloading the Gist as it was not required.
Since then I kept receiving many twitter messages, github issues and email that user are inserting github Token on GIST dialog in code when downloading and then Settings Sync fails for them.
To make the download process consistent with upload process ( Token and Gist ID ) i have to revert it.
If your processes are automated you can set this flag to true to let team members use Settings Sync for download only purposes.
To keep the details handy, I have written the detailed post on configurations
https://medium.com/@itsShanKhan/visual-studio-code-settings-sync-configurations-ed8dd6fd9753
let me know if you face this problem even setting configuration.

Duplicate of #487

I have then same problem.
error in developer tools
TypeError: Cannot read property 'gists' of null
    at module.exports.t.GitHubService.<anonymous> (C:\Users\R09857\.vscode\extensions\shan.code-settings-sync-3.2.7\out\extension.js:14:32313)

I have then same problem.
error in developer tools
TypeError: Cannot read property 'gists' of null
    at module.exports.t.GitHubService.<anonymous> (C:\Users\R09857\.vscode\extensions\shan.code-settings-sync-3.2.7\out\extension.js:14:32313)

version:3.2.7

Me too

I have then same problem.
error in developer tools
TypeError: Cannot read property 'gists' of null
    at module.exports.t.GitHubService.<anonymous> (C:\Users\R09857\.vscode\extensions\shan.code-settings-sync-3.2.7\out\extension.js:14:32313)

version:3.2.7

Me too, but in the current version 3.2.8 on Windows 10 and Linux.

It will be fixed in next version.
If you guys want to test the upcoming build.
Check from here
https://github.com/shanalikhan/code-settings-sync/issues/816#issuecomment-481623181

It will be fixed in next version.
If you guys want to test the upcoming build.
Check from here
#816 (comment)

Thank you very much but it is not working completely. Did not download all my synced plugins and did not remove the old ones. But you could help me here.
Waiting for the new release ...


Collect reference number when recording appointment summary

Updated with validation to ensure the entered string parses as a number. This is intended to be merged in master now so 9ac53fa may need to be cherry-picked.

@aduggin will drop in the changes to the output document to include the reference number


Gracefully handle neighbor-less LLDP devices

lldpd may be successful but empty

vill not #292  do the same ?

vill not #292 do the same ?

You could say both have similar intents, but #292 is about lshw while mine is about lldpd.
Also, one notable difference is that #292 uses placeholders while mine simply does nothing if there are no visible neighbors

Sorry mixed it up,  problem with working with 5 things simultaneously.


ProvidePlugin does not work when use AutodllPlugin

I try to use to simplify the dll config instead of webpack dllplugin，but I have gotten two problem，
the providePlugin doesn not，I use it to export $ and jQuery.
and there are many warning when bundle working， said can't find export **module in @angular/core . but it's work correctly in webpack-dev-server,  I use angular-webpack-starter btw.
please help me how can I fix that？

Hi @locotor,
I'm sorry you had to wait so long.
I bet you've found another solution by now.
If I understood you correctly, you added the providePlugin to the DLL config?
Is it work when you use it with webpack's own DllPlugin?

@asfktz I confirm this issue, but only from version 0.3.0. With 0.2.1 was working very good for me.
If you want an example that you can run, check this template that I created and try to force the update of autodll from 0.2.1 to 0.3.0.
When you'll run the application with 'npm start', you'll receive in browser's console this:
Uncaught ReferenceError: jQuery is not defined
    at Object.<anonymous> (vendor_56756dfdb5112bfaa5bb.js:133528)
    at __webpack_require__ (vendor_56756dfdb5112bfaa5bb.js:21)
    at Object.<anonymous> (vendor_56756dfdb5112bfaa5bb.js:133330)
    at __webpack_require__ (vendor_56756dfdb5112bfaa5bb.js:21)
    at Object.<anonymous> (vendor_56756dfdb5112bfaa5bb.js:132729)
    at __webpack_require__ (vendor_56756dfdb5112bfaa5bb.js:21)
    at Object.<anonymous> (vendor_56756dfdb5112bfaa5bb.js:132721)
    at __webpack_require__ (vendor_56756dfdb5112bfaa5bb.js:21)
    at Object../node_modules/bootstrap-loader/loader.js (loader.js from dll-reference vendor_56756dfdb5112bfaa5bb:1)
    at __webpack_require__ ((index):745)
    at fn ((index):150)
    at Object../src/app/app.module.ts (app.module.ts:33)
    at __webpack_require__ ((index):745)
    at fn ((index):150)
    at Object../src/main.ts (main.ts:35)
    at __webpack_require__ ((index):745)
    at fn ((index):150)
    at Object.2 (styles.scss?e304:26)
    at __webpack_require__ ((index):745)
    at webpackJsonpCallback ((index):58)
    at app.js:2

But blocking autodll version to 0.2.1 everything is ok.
I'm using ProvidePlugin with this way:
new AutoDllPlugin({
      debug: true,
      inject: true,
      context: __dirname,
      filename: '[name]_[hash].js',
      path: './dll',
      entry: {
        polyfills: [
          'core-js',
          'zone.js/dist/zone.js',
          'zone.js/dist/long-stack-trace-zone'
        ],
        vendor: [
          '@angular/platform-browser',
          '@angular/platform-browser-dynamic',
          '@angular/core',
          '@angular/common',
          '@angular/forms',
          '@angular/http',
          '@angular/router',
          '@angularclass/hmr',
          '@ngrx/store',
          '@ngrx/store-devtools',
          'rxjs',
          '@ng-bootstrap/ng-bootstrap',
          'style-loader',
          'jquery',
          'bootstrap-loader',
          'hammerjs',
          'lodash',
          'mousetrap',
          'ng2-validators',
          'reflect-metadata',
          'tether'
        ]
      }
    }),

Do you have any ideas?
Thank u.

Thanks for reporting @Ks89
I'll take a look at it

@Ks89 What OS do you use?

@asfktz
macOS 10.12.6
node 8.5.0
npm 5.3.0

Hi, @Ks89
I'm sorry my friend but I have only bad news for you.
Seem like the issue with ProvidePlugin is related to the webpack's DllPlugin itself (AutoDllPlugin is using it under the hood).
ProvidePlugin does not affect modules bundled inside the DLL, so when Bootstrap (which included in the DLL) expects jQuery to be present by the ProvidePlugin, it throws an errors.
I made a simple test to demonstrate the bug using webpack's DllPlugin:
https://github.com/asfktz/dllplugin-with-provide
You might wonder why it worked for you in version 0.2.1?
Well, the sad truth is that it didn't.
You set the context to __dirname
But since your webpack config is inside ./config it should have been path.join(__dirname, '..'), pointing to the root of your project.
The result of that is that your vendor modules are included
both in the DLL bundle: ./dist/dll/vendor_c3dde9f125018a7b63b3.js
and in you common chunk bundle: ./dist/vendor.js. This is bad.
Set the context to path.join(__dirname, '..') and your good to go (as long as you don't use the ProvidePlugin).
One why the solve the bug with ProvidePlugin & the DllPlugin is to expose jQuery globally, you can use expose-loader for that.
I really don't like it. But it will work.
Hope I could find a better solution.
Asaf.

Ok, understood.
Thank u very much for your time. I'll try with expose-loader.
I'll watch this issue :)

@asfktz I tried to modify your example (https://github.com/asfktz/dllplugin-with-provide) with expose-loader instead of ProvidePlugin but I'm still receiving the same error.
Please, could you create a branch with a working configuration?

I was able to use AutoDllPlugin together with jQuery and bootstrap by moving jQuery out of the dll bundle:
webpack.config.js:
const jqueryPath = require('fs').realpathSync(`${__dirname}/node_modules/jquery/dist/jquery.min.js`);

module.exports = {

    /* Entry points: vendor and app */
    entry: {
        'vendor': './vendor.ts',
        'app': './main.ts'
    },

    /* Point webpack to the jQuery script  */
    resolve: {
        alias: {
            jquery: jqueryPath
        }
    },

    /* Make jQuery globally available  */
    module: {
      rules: [{
        test: jqueryPath,
        use: [{
          loader: 'expose-loader',
          options: '$'
        },{
          loader: 'expose-loader',
          options: 'jQuery'
        }]
      }],
    },

    /* Auto-create dll bundle without jQuery */
    plugins: [
        new AutoDllPlugin({
           entry: { static: ['bootstrap'] }
        }),
    ]
}

vendor.ts:
import 'bootstrap';

main.ts:
import 'jquery';


Make ODB understand PubMed article pages

From @rossmounce on March 6, 2016 20:54
I just tried to ODB this page: http://www.ncbi.nlm.nih.gov/pubmed/25543783
My Citeulike bookmarklet usually gets PubMed pages like this where the DOI of the article is clearly displayed. I assume Mendeley and others do too.
Copied from original issue: OAButton/odb#45

This functionality will be moved to the back-end, so effort will be focused there to achieve this goal.

Closing this one, no longer related to plugin.

Can we move it, I know this is something people want for requesting Data?
On Mon, 29 Aug 2016 at 12:42 markmacgillivray<EMAIL_ADDRESS>wrote:

Closing this one, no longer related to plugin.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/OAButton/unified-extension/issues/18#issuecomment-243101502,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AEuWZwomoLOt_lbVSBFuH80FxqL9tkTsks5qksW8gaJpZM4JELDe
.

The backend will be able to understand pubmed pages anyway, we have already
previously parsed them. We have more complex issues with PLOS and
sciencedirect pages now, which may result in simplification of what data we
bother trying to parse, as a uniform experience may be better. But yeah can
move it to backend if you like.
On Mon, Aug 29, 2016 at 12:44 PM, Joseph McArthur<EMAIL_ADDRESS>wrote:

Can we move it, I know this is something people want for requesting Data?
On Mon, 29 Aug 2016 at 12:42 markmacgillivray<EMAIL_ADDRESS>wrote:

Closing this one, no longer related to plugin.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<https://github.com/OAButton/unified-extension/issues/18#
issuecomment-243101502>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AEuWZwomoLOt_
lbVSBFuH80FxqL9tkTsks5qksW8gaJpZM4JELDe>
.

—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/OAButton/unified-extension/issues/18#issuecomment-243101693,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAuXCHxg99wGCEhO81EJoqOPaJDkS-aSks5qksYAgaJpZM4JELDe
.

So, when you say "will be", do you mean this can just be closed because
it's done?
On Mon, 29 Aug 2016 at 12:48 markmacgillivray<EMAIL_ADDRESS>wrote:

The backend will be able to understand pubmed pages anyway, we have already
previously parsed them. We have more complex issues with PLOS and
sciencedirect pages now, which may result in simplification of what data we
bother trying to parse, as a uniform experience may be better. But yeah can
move it to backend if you like.
On Mon, Aug 29, 2016 at 12:44 PM, Joseph McArthur <
<EMAIL_ADDRESS>wrote:

Can we move it, I know this is something people want for requesting Data?
On Mon, 29 Aug 2016 at 12:42 markmacgillivray<EMAIL_ADDRESS>wrote:

Closing this one, no longer related to plugin.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<https://github.com/OAButton/unified-extension/issues/18#
issuecomment-243101502>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AEuWZwomoLOt_
lbVSBFuH80FxqL9tkTsks5qksW8gaJpZM4JELDe>
.

—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<
https://github.com/OAButton/unified-extension/issues/18#issuecomment-243101693
,
or mute the thread
<
https://github.com/notifications/unsubscribe-auth/AAuXCHxg99wGCEhO81EJoqOPaJDkS-aSks5qksYAgaJpZM4JELDe
.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/OAButton/unified-extension/issues/18#issuecomment-243102505,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AEuWZ83GlMFe3LwhJ8AOk5pV_qZJoTStks5qkschgaJpZM4JELDe
.

It is done in the backend dev version, yes. So the plugin will just get
pubmed metadata too, when it starts talking to the new backend to create
requests. So there is certainly nothing further to do from the plugin
perspective. From the backend it is still being tested before deployment,
but will be live before the next plugin version is released.
On Mon, Aug 29, 2016 at 12:51 PM, Joseph McArthur<EMAIL_ADDRESS>wrote:

So, when you say "will be", do you mean this can just be closed because
it's done?
On Mon, 29 Aug 2016 at 12:48 markmacgillivray<EMAIL_ADDRESS>wrote:

The backend will be able to understand pubmed pages anyway, we have
already
previously parsed them. We have more complex issues with PLOS and
sciencedirect pages now, which may result in simplification of what data
we
bother trying to parse, as a uniform experience may be better. But yeah
can
move it to backend if you like.
On Mon, Aug 29, 2016 at 12:44 PM, Joseph McArthur <
<EMAIL_ADDRESS>wrote:

Can we move it, I know this is something people want for requesting
Data?
On Mon, 29 Aug 2016 at 12:42 markmacgillivray <
<EMAIL_ADDRESS>wrote:

Closing this one, no longer related to plugin.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<https://github.com/OAButton/unified-extension/issues/18#
issuecomment-243101502>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AEuWZwomoLOt_
lbVSBFuH80FxqL9tkTsks5qksW8gaJpZM4JELDe>
.

—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<
https://github.com/OAButton/unified-extension/issues/18#
issuecomment-243101693
,
or mute the thread
<
https://github.com/notifications/unsubscribe-auth/
AAuXCHxg99wGCEhO81EJoqOPaJDkS-aSks5qksYAgaJpZM4JELDe
.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<https://github.com/OAButton/unified-extension/issues/18#
issuecomment-243102505>,
or mute the thread
<https://github.com/notifications/unsubscribe-
auth/AEuWZ83GlMFe3LwhJ8AOk5pV_qZJoTStks5qkschgaJpZM4JELDe>

.

—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/OAButton/unified-extension/issues/18#issuecomment-243102963,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAuXCMcws4XTvgMdSow4_kOjgQ3bmCuxks5qksfCgaJpZM4JELDe
.

Okay, so good to close before moving as it'll be in the next release.
On Mon, 29 Aug 2016 at 12:42 markmacgillivray<EMAIL_ADDRESS>wrote:

Closed #18 https://github.com/OAButton/unified-extension/issues/18.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/OAButton/unified-extension/issues/18#event-770564839,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AEuWZwomoLOt_lbVSBFuH80FxqL9tkTsks5qksW8gaJpZM4JELDe
.


fieldas does not support tags

Didn't think about this when requesting fieldas -- at the moment if the same alias is used between tags, the last specified fieldas is used. For example:
type structWithAsAndTags struct {
	T5 string `db:"t5" fieldas:"f4" fieldtag:"a"`
	T6 string `db:"t5" fieldas:"f5" fieldtag:"b"`
}

func TestStructFieldAsAndTagsA(t *testing.T) {
	a := assert.New(t)
	s := NewStruct(new(structWithAsAndTags))
	sb := s.SelectFromForTag("t", "a")
	b := Build(`COPY ($?)  TO '/path/to/file.csv' (FORMAT CSV, HEADER)`, sb)
	sql, _ := b.Build()
	a.Equal(string(sql), `COPY (SELECT t.t5 AS f5 FROM t) TO '/path/to/file.csv' (FORMAT CSV, HEADER)`)
}

At the moment the first test passes, but the second fails. The use-case being: to support a different fieldas per tag.
Do you think it would be worth refactoring to allow fieldas to support tags in this way?

Made a quick PR as a proof of concept -- didn't spend too much time on it, so it's ok if you don't like the approach.

The key issue is that the db is designed to be a unique key and should we break this design for fieldas?
In your case, the fieldas value should be unique instead of db. I'm thinking of whether I should make the fieldas as the preferred unique key and the db as the secondary key.
Your feedback is welcome.

That would work great (key = fieldas + db) -- thanks so much for responding. fieldas on it's own probably wouldn't be enough, because we do have the requirement for duplicate fieldas definitions from different db fields.

I did a thoroughly refactory to make fieldas work correctly. This fix is a bit more complex than I thought several days ago.


feat(data): update db-cli to push data to mariadb instead of mongo

Closes #1147
Notable changes
Same command: ping
Now, it pings the mariadb instance instead of Mongo

New command: list-dbs
Lists the available databases (filtered by *_service)

New command: list-tables <database>
Lists the available tables of a given database (will not list flyway_schema_history)

New command: drop-tables <database>
Drops all tables of a given database (except for flyway_schema_history)

Same-ish command: seed-database <database> <dir>
Seed a given database with JSON files from given directory.

This CLI looks good. How do set credentials to connect to the DB?
This CLI is actually timely for one more reason. I'm wondering how we could use it for MariaDB container healthcheck to not only ping the DB but also test that the required tables have been created. Do you have suggestions on how we could implemented this second test?

Do you have suggestions on how we could implemented this second test?

@tschaffter hmm, we could use the number of files that are located in the data/seed folder?  Either that or write a test that explicitly looks for the tables expected.  The only issue with the latter approach is that it'll require more maintenance, since we'll have to keep updating it while time we add/remove a table.

I think that the test should live in the service itself. One way could be to override/extend the existing health endpoints or implement a custom one. We could then use curl to send a request to this new healthcheck endpoint.

@tschaffter: How do we set credentials to connect to the DB?

It is using the same config file as before.  To set custom config values, I have re-added the CLI options to do so:

For future reference:
For seeding to work properly, we will need to prefix some JSON files with an underscore, so that they will be listed and read in first.  Given that some of the tables have reference constraints, the tables without constraints will need to be populated first.

For future reference:
For seeding to work properly, we will need to prefix some JSON files with an underscore, so that they will be listed and read in first. Some tables have reference constraints (see _create.txt for example), ergo the tables without constraints will need to be populated first.

@vpchung One test is failing for this PR.

@rrchai @tschaffter okay, I think the PR is officially ready~
Seems like a lot of file changes, but 30 of those files are related to the seed files (removed or modified) and model files (removed).  If it helps, the key files to review are:

app.ts
database.ts

I also attached screenshots above of the updated CLI.


python3Packages.pmdarima: init at 2.0.3

Description of changes

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Results of nixpkgs-review pr 255700 on x86_64-linux:
2 packages built:
python310Packages.pmdarima python311Packages.pmdarima

@GrahamcOfBorg build python310Packages.pmdarima python311Packages.pmdarima

Dependency of https://github.com/NixOS/nixpkgs/issues/247089

Result of nixpkgs-review pr 255700 run on x86_64-linux 1

4 packages built:

python310Packages.pmdarima
python310Packages.pmdarima.dist
python311Packages.pmdarima
python311Packages.pmdarima.dist


Feat/LDG-504--nano-app-add-support-for-2-derivation-paths

add two derivation paths
bump version, last version in old Concordium is 4.1.2

Ready for review


Updated directory to suit python's naming conventions

Would it be useful to include a few words about setting up private files from the README.md?

Yes - this is probably a good idea. I'll add it to the issues!


Why PartialEq everywhere and not Eq?

I am planning to use Point3<i32>, Point3<f32> inside structs in my code that need to be hashable.  For that, I understand they need to implement Hash + Eq, but they only implement Hash + PartialEq.
Is that just an oversight, or is there a reason?

Closing as answered.


PDH Metrics edits

What does this PR do?
Reformatted metrics section to highlight custom metrics only
Motivation
JIRA request
Review checklist (to be filled by reviewers)

[ ] Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
[ ] PR title must be written as a CHANGELOG entry (see why)
[ ] Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
[ ] PR must have changelog/ and integration/ labels attached

Thanks for the name change @ofek 😆Didn't realize I accidentally put PHD. All changes are now made, think we're good for final review. 👍


Do not apply send attempt limit to manual operations

I replied to an email in an area without data service. Several hours later, I returned to data coverage and began receiving emails again. The outbound message did not budge, despite repeated manual 'Send messages' operations.
I've had debug enabled so pulled the log and this is what's produced by Outbox > menu > 'Send messages':
04-13 19:59:04.828 I/k9      ( 2239): Running Foreground command 'getFolderUnread:Work:K9MAIL_INTERNAL_OUTBOX', seq = 3027
04-13 19:59:04.871 I/k9      ( 2239): Foreground Command 'getFolderUnread:Work:K9MAIL_INTERNAL_OUTBOX' completed
04-13 19:59:18.751 I/k9      ( 2239): Running Background command 'sendPendingMessages', seq = 3028
04-13 19:59:18.845 I/k9      ( 2239): Scanning folder 'K9MAIL_INTERNAL_OUTBOX' (4) for messages to send
04-13 19:59:18.846 I/k9      ( 2239): Send count for message K9LOCAL:f2c7725a-c0bd-404b-ad2e-942c35f41395 is 38
04-13 19:59:18.846 E/k9      ( 2239): Send count for message K9LOCAL:f2c7725a-c0bd-404b-ad2e-942c35f41395 can't be delivered after 5 attempts.
Having to restart the device seems unreasonable. Why have a hard limit at all? Shouldn't network availability be taken into consideration?
I think manual 'Send messages' operations should reset or ignore the attempt counter.

Actually we want to distinguish between network errors and errors reported by the server.

If it's only network errors we can retry with exponential backoff.
For temporary server errors we might want to do the same.
For permanent errors we want to display a proper error message.

The limit was added because of this: https://groups.google.com/forum/#!topic/k-9-mail/zmDJ1f2Cx9c

Hi,
my current experience is that i do not receive any notification from k9, therefore i had to go through the debug message.
since there is no notification on the user, i think that this should be considered a bug, at least for this portion of the issue.


2.0.2

2.0.2

Bumped up flutter_inappwebview which should fix Unhandled Exception: MissingPluginException.
Added useHybridComposition.
Added documentation on how to load thumbnails.
Fix #18.

Hey, incase you don't see my response in the issue #18. The fix did not work, I can still see the white line. Thank you again for looking into it!


Search tweets not working properly

after successful scraper login, I am trying to search tweets, but it's just returning empty object
here is my basic code
await this.scraper.login(
          process.env.TWITTER_USERNAME!,
          process.env.TWITTER_PASSWORD!,
          process.env.TWITTER_EMAIL!,
          process.env.TWITTER_2FA_SECRET!,
          process.env.TWITTER_API_KEY!,
          process.env.TWITTER_API_SECRET_KEY!,
          process.env.TWITTER_ACCESS_TOKEN!,
          process.env.TWITTER_ACCESS_TOKEN_SECRET!
        );
const mentions = await this.scraper.searchTweets(
          '#nodejs', 20, SearchMode.Latest
        );
console.log("mentions", mentions);

In my console, it's just mentions Object [AsyncGenerator] {}

https://github.com/ai16z/agent-twitter-client/blob/0920a6d2a2d1425590da23f7bf6c464ea3f3f740/src/timeline-async.ts#L59-L90
Because this function returns a Generator, so you have to iterate over it to get the result.
For example:
for (const mention of mentions) {
  console.log(mention);
};

@abcfy2
I tried that as well, and it's returning an error saying TypeError: mentions is not iterable

@abcfy2 I tried that as well, and it's returning an error saying TypeError: mentions is not iterable

Oh sorry, it's an AsyncGenerator, so you have to use await in your for loop iterator:
// remove await because 'await' has no effect on the type of this expression
const mentions = this.scraper.searchTweets(
          '#nodejs', 20, SearchMode.Latest
        );

for await (const mention of mentions) {
  console.log(mention);
};


When installed with CLI, bin points to non-existent path

I just noticed that when I scaffold a new module with CLI by using yo node --cli, in package.json bin points to non-existent path ("dist/cli.js").
As an example, I tried to link my new module with following result:
C:\Projects\testapp-node-cli
λ npm link
npm ERR! Windows_NT 6.1.7601
npm ERR! argv "C:\\Program Files\\nodejs\\\\node.exe" "C:\\Program Files\\nodejs\\node_modules\\npm\\bin\\npm-cli.js" "link"
npm ERR! node v0.12.5
npm ERR! npm  v2.11.2
npm ERR! path C:\Users\<user>\AppData\Roaming\npm\node_modules\testapp-node-cli\dist\cli.js
npm ERR! code ENOENT
npm ERR! errno -4058

And real dir structure:
...
├───lib
│       cli.js
│       index.js
│
├───node_modules
├───test

However, if I run yo node:cli this issue doesn't happen. Not sure about the specifics, but I think it originates from here https://github.com/yeoman/generator-node/blob/master/generators/cli/index.js#L14

Ugh, yeah.
That generator really isn't great. It needs to define patterns for options and arguments in it's constructor. And it need to be smarter.

I'll look into this. Try running gulp babel and npm link again?

That generator really isn't great. It needs to define patterns for options and arguments in it's constructor. And it need to be smarter.

Yep. I totally agree.

That creates the dist/cli.js, also npm link works. But when I try to run the module, this happens:
C:\Projects\testapp-node-cli
λ gulp babel
[23:14:11] Using gulpfile C:\Projects\testapp-node-cli\gulpfile.js
[23:14:11] Starting 'babel'...
[23:14:11] Finished 'babel' after 175 ms

C:\Projects\testapp-node-cli
λ npm link
C:\Users\<user>\AppData\Roaming\npm\testapp-node-cli -> C:\Users\<user>\AppData\Roaming\npm\node_modules\testapp-node-cli\dist\cli.js
C:\Users\<user>\AppData\Roaming\npm\node_modules\testapp-node-cli -> C:\Projects\testapp-node-cli

C:\Projects\testapp-node-cli
λ testapp-node-cli
C:\Projects\testapp-node-cli\lib\index.js:2
export default {};
 ^^^^^^
SyntaxError: Unexpected reserved word
    at exports.runInThisContext (vm.js:73:16)
    at Module._compile (module.js:443:25)
    at Object.Module._extensions..js (module.js:478:10)
    at Module.load (module.js:355:32)
    at Function.Module._load (module.js:310:12)
    at Module.require (module.js:365:17)
    at require (module.js:384:17)
    at Object.<anonymous> (C:\Projects\testapp-node-cli\dist\cli.js:15:10)
    at Module._compile (module.js:460:26)
    at Object.Module._extensions..js (module.js:478:10)

That creates the dist/cli.js, also npm link works.

Well, that's the expected behaviour. When using babel you of course have to compile your code first.

But when I try to run the module, this happens:

This is a bug not related to the CLI. The problem is that our main in the generated package.json points to lib/index.js, which is a problem when using babel as that's the source version not the compiled version.

I see, thanks for looking into this. :+1:
Also, I would like to mention that as a new user I was a bit confused by this issue since this wasn't happening when I ran yo node:cli (without --no-babel, doesn't it default to true?), it created only lib/cli.js and everything worked.

@petersandor This is not an issue on your side. This generator output is broke. We'll fix it.

@arthurvr You assigned yourself that ticket. I think it's working fine now, can you double check and close it if that's the case? Thanks :)

Looks alright now. Nice work @SBoudrias :)

:+1:


Log channels stack trace is inside the message as a string

Hi,
I recently started using the log channels from Laravel, and I noticed the stack trace is being sent over inside the message. Therefore it's not correctly parsed in Sentry, and error deduplication is broken.
It's related to #142 imo
Here's how the error looks inside of sentry without using log channels

Here with the log channels

My configuration is:
'sentry' => [
   'driver'  => 'sentry',
   'level'   => 'debug',
]

It might not be the most efficient solution, but I ended up tapping into an extended inlinelogger that just set a formatter that sanitised the context being sent to Sentry so that duplicates were picked up.
'sentry' => [
        'driver' => 'sentry',
        'tap' => [Somsip\BlcKnd\Logger\SentryInlineLogger::class],
        'level' => 'error',
 ],

Main code here, but this package contains other stuff so you're probably best just taking what you need:
https://github.com/markdwhite/blc_knd/tree/master/src/Logger

@sweet-greg are you doing this on the 0.x version or the 1.x version of the SDK? We changed the handler quite a bit in 1.x and possibly already fixed this issue so wanted to make sure where I need to look.

Hi @stayallive
I just tested it out with version 1.0.0
Result is the same as before sadly.

@sweet-greg many thanks for testing though, will see if we can figure it out!

@stayallive thank you! It's quite an annoying issue.
For the time being I had to create a global listener for a log event to send it over to sentry.

+1

We have the same issue with ^1.9

All my sentry issues have the message content displayed as text, even with last version (2.4.2). What do I do wrong (I have the default config) ? Thanks for your help !

@smknstd can you confirm what you have in config/logging.php?
And can you possible also show me how this particular exception was logged (where is the logger()->error() call or some other way of logging it)?
https://github.com/getsentry/sentry-laravel/blob/65ba0ea34ce124b48f50fb59b80c701bf76f4b12/src/Sentry/Laravel/SentryHandler.php#L209-L213
Because if everything went right captureException should be used... but possible the way this particular error is triggered doesnt meet the correct conditions.

As said it is with all issues, including laravel exceptions

I think i've got nothing special in config:
    'channels' => [
        'stack' => [
            'driver' => 'stack',
            'channels' => ['daily', 'sentry'],
        ],
        ...
        'sentry' => [
            'driver' => 'sentry',
            'level'  => env('SENTRY_LOG_LEVEL', 'error')
        ],
    ],

and sentry.php is the same as https://github.com/getsentry/sentry-laravel/blob/master/config/sentry.php

It is the same when I manually log something:
Log::error("An error occurred ...", [
   "context_data" => "...";
])

Just to confirm, because I think I'm seeing what you are seeing... but let me know:
I'm seeing this, I think just like you are:

But if I scroll past the wall of text I do get here:

This is also what is happening for you? The stack trace is there? It's just that the message is also containing the full string of it?

I confirm I see the Exception section with proper breadcrumb. Message section on top is misleading, not the greatest UX I guess ... Thanks for your help :)

Check out version 2.5.0 that was just released and let me know if that looks better 👌


Some fixes

Hello,
I've identified and fixed some bugs. The two most critial are bugs that caused Fragment.DataBlocks() and ParseDataBlock to fail in some cases.
Thanks for these excellent packages!

I've pushed a new commit fixing homebrew compatibility with BrandMeister 20190421-185653.

Thanks!


ci: add Python linter to check

Summary
Add Black, isort and Flake8 to check linter. This follows issues found in #14319 .
A previous modification was done on master #14176 but missed those packages.
Impact
Installs Python linter packages to this release.
Testing
Running tests on this PR.
@lupyuen @jerpelea

@jerpelea This PR is already targeting release. I can modify on master on a different PR is that's ok.

please add it to master and I will backport to the release branch

Done. I suspected some conflict may happen.


Level Order in BST

🚀 Feature
Implementing:
level order traversal
finding height of the BST
in C language and CPP language
Assignment
Hello maintainers!
As a participant/CA for GSSOC '21,
I wish to contribute & resolve this issue with proper indentation, comments & sample I/O in C++.
Kindly assign me these issues under GSSOC '21...

Hi, I am Hritik Khurana , I would like to work on this issue in C++ . Could you please assign it to me as a GSSOC'21 participant?
I have read Contributing Guidelines on Pull Requests.
Thanks!!

Hello @HarshCasper

I am a GSSOC21 participant I would like to contribute this issue by coding preorder, inorder , levelorder ,postorder traversal in c++

Hello maintainers! I checked out the repo and I found level order hasn't been included yet in C++  and in C. I request you to kindly assign me this issue. I have read contributing guidelines on pull requests.

I am a GSSOC'21 participant and want to work on issue.
I can provide the code in C++ with proper comment description .
please assign me this issue.

Greetings sir/Mam,
I would like to contribute the code for Bubble Sort Algorithm #933 in C++/CPP.
The code is ready. I have added the code , along with proper explanation of the algorithm , test cases , time complexity and space complexity of the same, as per the guidelines.
Kindly assign it to me.
This is regarding GSSOC'21.
Regards,
Hitain Kakkar

Hello I'm Disksha, I'm also a gssoc'21 participant.
I will work on this issue in C++
Thus,  I request @anushkrishnav to please /assign me this issue.

@Diksha-11 please make your own issue on what you think you should work and assign it using the bot but make sure its not already there

@Diksha-11 please make your own issue on what you think you should work and assign it using the bot but make sure its not already there

@anushkrishnav, you should really mention how beginners can do this, they wouldn't know the bot commands right? Add the commands to CONTRIBUTING.md

@Diksha-11 please make your own issue on what you think you should work and assign it using the bot but make sure its not already there

After creating an issue, comment /assign to assign the issue to yourself, GitHub actions not would assign you automatically.


module.exports

depending on node.js version adding the export line on the class line is invalid.

Thanks for the fix, I understand what you just said now :+1:

hm, I assume people migrated to 4.1+ already. Do you have a real reason to not to update?
Anyway, it's not a problem to merge this one.

This fix has been released under 1.1.5 tag.


[UX]: Mobile layout doesn't show all tabs

IMPACT

[ ] High
[X] Medium
[ ] Low

URGENCY

[ ] Critical
[ ] Major
[X] Medium
[ ] Minor

PRODUCT ENVIRONMENT
No response
DESCRIPTION OF ISSUE
Contract detail view has a lot of tabs: Transactions, Token Transfers, Tokens ERC-20, NFTs ERC-721, Code
When tabs don't fit on screen width they just disappear.
DEVICE / VIEWPORT

[ ] Desktop
[X] Mobile

STEPS TO REPRODUCE

open https://explorer.oasis.io/mainnet/sapphire/address/0x8Bc2B030b299964eEfb5e1e0b36991352E56D2D3/tokens/erc-721#tokens on small screen or mobile
try to see the bytecode tab

ALTERNATIVES AND SUGGESTIONS
Use https://mui.com/material-ui/react-tabs/#scrollable-tabs

@donouwens here's MUI option enabled for tab scrolling
https://7c8907c1.oasis-explorer.pages.dev/mainnet/sapphire/address/0x8Bc2B030b299964eEfb5e1e0b36991352E56D2D3/tokens/erc-721#tokens


ppl: place fallback groups and pins after placing the remaining pins

I'll squash this to get rid of the reverts when merging.

@eder-matheus @maliberty I tried it on my design where I had this problem and it now works :-)


Update CI config

Ugghh.. The addition of id attribute to hidden inputs is causing a ton of test failures.

Noice! Maybe we should add scheduled runs so that we get f'd in due time 😃

Also if we add the ids it will fail with  prefer-lowest. Personally I wouldn't mind dropping that build.

We could either drop the build, or like with the ARIA changes, implement adding the ID in a backwards compatible manner into the form helper, until we can bump the CakePHP version.

We could either drop the build, or like with the ARIA changes, implement adding the ID in a backwards compatible manner into the form helper, until we can bump the CakePHP version.

I have just ignored that failure for now.


ValidationError: 1 validation error for ChatMessage role   Input should be a valid string [type=string_type, input_value=None, input_type=NoneType]

[ ] I checked the documentation and related resources and couldn't find an answer to my question.
Your Question
Requesting help. I started running ragas last week and encountered errors. Later, when I used the example from the ragas documentation at "https://docs.ragas.io/en/stable/getstarted/rag_evaluation/" for evaluation testing, I encountered the same error.
The error is as follows:
/usr/local/lib/python3.10/dist-packages/huggingface_hub/utils/_token.py:89: UserWarning:
The secret `HF_TOKEN` does not exist in your Colab secrets.
To authenticate with the Hugging Face Hub, create a token in your settings tab (https://huggingface.co/settings/tokens), set it as secret in your Google Colab and restart your session.
You will be able to reuse this secret in all of your notebooks.
Please note that authentication is recommended but still optional to access public models or datasets.
  warnings.warn(
amnesty_qa.py: 100%
 6.82k/6.82k [00:00<00:00, 343kB/s]
README.md: 100%
 1.90k/1.90k [00:00<00:00, 127kB/s]
The repository for explodinggradients/amnesty_qa contains custom code which must be executed to correctly load the dataset. You can inspect the repository content at https://hf.co/datasets/explodinggradients/amnesty_qa.
You can avoid this prompt in future by passing the argument `trust_remote_code=True`.

Do you wish to run the custom code? [y/N] y
Repo card metadata block was not found. Setting CardData to empty.
WARNING:huggingface_hub.repocard:Repo card metadata block was not found. Setting CardData to empty.
english.json: 100%
 70.8k/70.8k [00:00<00:00, 1.31MB/s]
Generating eval split:
 20/0 [00:00<00:00, 246.48 examples/s]
DatasetDict({
    eval: Dataset({
        features: ['user_input', 'reference', 'response', 'retrieved_contexts'],
        num_rows: 20
    })
})
/usr/local/lib/python3.10/dist-packages/ragas/prompt/base.py:9: LangChainDeprecationWarning: As of langchain-core 0.3.0, LangChain uses pydantic v2 internally. The langchain_core.pydantic_v1 module was a compatibility shim for pydantic v1, and should no longer be used. Please update the code to import from Pydantic directly.

For example, replace imports like: `from langchain_core.pydantic_v1 import BaseModel`
with: `from pydantic import BaseModel`
or the v1 compatibility namespace if you are working in a code base that has not been fully upgraded to pydantic 2 yet. 	from pydantic.v1 import BaseModel

  from ragas.llms.prompt import PromptValue
Evaluating:   0%
 0/60 [00:04<?, ?it/s]
---------------------------------------------------------------------------
ValidationError                           Traceback (most recent call last)
<ipython-input-7-6864e4d138df> in <cell line: 14>()
     12 evaluator_llm = LangchainLLMWrapper(ChatOpenAI(model="gpt-4o-mini", temperature=0))
     13 metrics = [LLMContextRecall(), FactualCorrectness(), Faithfulness()]
---> 14 results = evaluate(dataset=eval_dataset, metrics=metrics, llm=evaluator_llm, raise_exceptions=True)
     15
     16 df = results.to_pandas()

50 frames
/usr/local/lib/python3.10/dist-packages/pydantic/main.py in __init__(self, **data)
    210         # `__tracebackhide__` tells pytest and some other tools to omit this function from tracebacks
    211         __tracebackhide__ = True
--> 212         validated_self = self.__pydantic_validator__.validate_python(data, self_instance=self)
    213         if self is not validated_self:
    214             warnings.warn(

ValidationError: 1 validation error for ChatMessage
role
  Input should be a valid string [type=string_type, input_value=None, input_type=NoneType]
    For further information visit https://errors.pydantic.dev/2.9/v/string_type

Code Examples
Here is the sample code I ran:
from dotenv import load_dotenv
load_dotenv()
from datasets import load_dataset
dataset = load_dataset("explodinggradients/amnesty_qa", "english_v3")
print(dataset)

from ragas import EvaluationDataset
eval_dataset = EvaluationDataset.from_hf_dataset(dataset["eval"])

from ragas.metrics import LLMContextRecall, Faithfulness, FactualCorrectness, SemanticSimilarity
from ragas import evaluate
from ragas.llms import LangchainLLMWrapper
from langchain_openai import ChatOpenAI
evaluator_llm = LangchainLLMWrapper(ChatOpenAI(model="gpt-4o-mini", temperature=0))
metrics = [LLMContextRecall(), FactualCorrectness(), Faithfulness()]
results = evaluate(dataset=eval_dataset, metrics=metrics, llm=evaluator_llm, raise_exceptions=True)

df = results.to_pandas()
df.head()

Additional context
The version I used is:
langchain                          0.3.4
langchain-community                0.3.3
langchain-core                     0.3.12
langchain-openai                   0.2.3
langchain-text-splitters           0.3.0
ragas                              0.2.1
pydantic                           2.9.2
pydantic_core                      2.23.4
pydantic-settings                  2.6.0

I have checked the dataset and there are no issues. Could it be a compatibility issue with some module versions?

@miaoxiaolv this could be because of a json decoding error - do you use any tracing tools?

I'm really sorry, but this error was mainly due to some issues with my OpenAI API key. After changing the API key, the error is gone. Thank you for your help.

@miaoxiaolv glad to hear it is solved - closing this now 🙂


Use with Grizzl-E smart charger

Hi, the Grizzl-E smart charger uses an ESP32 for Wi-Fi and it's application. Their firmware is a mess, and not very compliant to OCPP. What all would be required to see if ArduinoOcpp could control this box?
This issue has some pictures and details on the fw provided.
https://github.com/lbbrhzn/ocpp/issues/442
It may be possible to follow the traces on the esp32 daughter board there is an 8 pin header that connects is to the main pcb. There is a buzzer and led so I'm guessing those would be 2 of the gpio pins.
Appreciate any input
Thank you

Sounds like a great project! The first thing to find out is how the communication on their board works in detail and how to control the EVSE from an Arduino sketch. After that you can customize the SECC sketch to support that communication mechanism. Looking forward to hearing about the progress!

Feel free to reopen this issue in case you retrofit a charger using this project.


Fixing typo in content type.

Signed-off-by: Adam Avilla<EMAIL_ADDRESS>

gosh, I'm the worse, typing apppppppppplication. Thank you! :metal:


App crash

After creating a group conversation, I added my simulator as a participant from my actual phone, the app on the simulated crashes while starting. The error is
fatal error: unexpectedly found nil while unwrapping an Optional value
It is caused by the line
func conversationListViewController(conversationListViewController: ATLConversationListViewController!, avatarItemForConversation conversation: LYRConversation!) -> ATLAvatarItem! {
    let userID: String = conversation.lastMessage.sender.userID // <- this line throws nil pointer error
    if userID == PFUser.currentUser()!.objectId {
        return PFUser.currentUser()
    }
    let user: PFUser? = UserManager.sharedManager.cachedUserForUserID(userID)
    if user == nil {
        UserManager.sharedManager.queryAndCacheUsersWithIDs([userID], completion: { (participants, error) in
            if participants != nil && error == nil {
                self.reloadCellForConversation(conversation)
            } else {
                print("Error querying for users: \(error)")
            }
        })
    }
    return user;
}

There are 2 message in the conversation but this method call for 4 times, at the 4. step conversation.lastMessage is nil

    if conversation.lastMessage == nil {
        return nil
    }

after added this into the begging of  the function everything seems to be fine, I just started to play with Layer 5 mins ago maybe this is not the right solution :)

@isacikgoz Thanks for reporting the issue and your analysis. Recently, I'm a bit busy and don't really have time to contribute to the project. It would be great if you would like to submit a PR for fix. :-)

ok, i will :)


fix: Landing mobile option to zoom out

PR Type

[x] Bugfix
[ ] Feature
[ ] Refactoring

Context

[x] Closes #9357

Did your issue had any of the "$" label on it?

[x] Fill up your DOT address: Payout

Screenshot 📸

[ ] My fix has changed something on UI;

thanks!
pay 20 usd

😍 Perfect, I’ve sent the payout
💵 $20 @ 7.06 USD/DOT ~ 2.833 $DOT
🧗 16faLfsywwNATaEfbH2ah75dn6ZmctQWpMS5G4KFhbmj5hnD
🔗 0xf105d46bd38a9e882dbddbd5dc8d4b07b125f402cea42cc83a5e816852be78cb
🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues


adding what FAROS is and fix a typo

Added a description of what FAROS is in the beginning and fixed a typo (it refers to a figure that doesn't exist).

Look good,  rebased and merged.


Warnings when building the package.

Swift Collections 1.0.3 and 1.0.4 have warnings when incorporated into an Xcode 14.3.1 project. I see both:
swift-collections/Sources/OrderedCollections/HashTable/_HashTable+UnsafeHandle.swift:487:14: 'assign(repeating:count:)' is deprecated: renamed to 'update(repeating:count:)'
and
swift-collections/Sources/OrderedCollections/Utilities/_UnsafeBitset.swift:187:25: 'assign(repeating:count:)' is deprecated: renamed to 'update(repeating:count:)'
There's a fix available that looks reasonable to me, but I haven't tried applying it yet.
Information

Package version: Seen on both 1.0.3 & 1.0.4.
Platform version: macOS 13.4 (22F66) (Ventura)
Swift version:

swift-driver version: 1.75.2 Apple Swift version 5.8.1 (swiftlang-<IP_ADDRESS>.5 clang-14<IP_ADDRESS>.100)
Target: arm64-apple-macosx13.0

Checklist

[✅ ] If possible, I've reproduced the issue using the main branch of this package. (Well … I presume. I've only tried using the releases, but I'm presuming that the releases are the same code as in main.)
[ ✅] I've searched for existing GitHub issues.

Steps to Reproduce
These warnings are visible in Xcode after a build, but you have to drill into the build logs a bit to see them. I noticed them originally in the output from our command line build script. This runs xcodebuild archive on the project using the collections, and the errors are in the output seen there..
Expected behavior
I expected the Swift Package release to build without warnings.
Actual behavior
Any attempt to link this project creates the two warnings listed above.

This has been resolved in https://github.com/apple/swift-collections/pull/268. The fix is scheduled for the 1.0.5 milestone.

Well … I presume. I've only tried using the releases, but I'm presuming that the releases are the same code as in main

That is an incorrect assumption.


Theme Variations don't appear in Inspector

Tested versions

4.3.stable
Not in 4.2

System information
Godot v4.3.stable.mono - Ubuntu 24.04.1 LTS 24.04 - Wayland - Vulkan (Forward+) - integrated Intel(R) HD Graphics 4400 (HSW GT2) - Intel(R) Core(TM) i7-4600U CPU @ 2.10GHz (4 Threads)
Issue description
When creating a theme variation through Theme Editor > Type > + > Theme Name and overwriting the Base Type with another node (tested example: Button), the new variation does not appear under the dropdown in the inspector on buttons (See below images). The variation can still be used when editing the variation through the text prompt (see below).
Theme variation's existence:

Doesn't appear in inspector:

Doing this works though:

NOTE: The theme variant was called red_button, the first screenshot shows another theme that has RedButton instead. This issue still persists, I just posted the wrong screenshot.
Steps to reproduce

Open a new project
Create theme
Create theme variation
See it not appear in the inspector

Minimal reproduction project (MRP)
N/A

Duplicate of #96315


Problems about horovod run

Hello,Luke:
I think your excellent work is deserved to study.But when i'm running your code with horovod commands horovodrun -np 4 -H localhost,it says:
[mpiexec@esc8000-g4] match_arg (utils/args/args.c:163): unrecognized argument allow-run-as-root
[mpiexec@esc8000-g4] HYDU_parse_array (utils/args/args.c:178): argument matching returned error
[mpiexec@esc8000-g4] parse_args (ui/mpich/utils.c:1642): error parsing input array
[mpiexec@esc8000-g4] HYD_uii_mpx_get_parameters (ui/mpich/utils.c:1694): unable to parse user arguments
[mpiexec@esc8000-g4] main (ui/mpich/mpiexec.c:148): error parsing parameters
Seem it has something wrong with my mpi4py installing when following your instructions in README file pip install mpi4py == 3.1.4.But i can't fix it.I'd appreciate it if anyone can solve my problem!

My pytorch version is 1.9.0+cu111 as mentioned in the README file.But i dont have install cudatoolkit==11.1,can you provide your channels to install cudatoolkit==11.1?Thanks!

Another question is about your johnson algorithm,when i am training step 2 on INTERACTION dataset,an serious problem occurs that the program finding too much circles in the graph to continue running,maybe it costs too much in some cases.Have you noticed this in your training on INTERACTION dataset?Thanks!

The part with too many cycles should not be happening unless something went wrong with stage 1 training, or unless you have modified the code to try to repredict off of initial predictions in an autoregressive manner.

The part with too many cycles should not be happening unless something went wrong with stage 1 training, or unless you have modified the code to try to repredict off of initial predictions in an autoregressive manner.
Thank you for an immediate reply!I have fixed that problem just now.That's because when i am using a two stage training at stage 2,i didn't load the pretrained parameters in stage 1,which causes the DAG was constructed too much edges with inital parameters of relation heads and has too much circles to remove.
So i add some extra code to the origin code in fjmp.py in front of :"model._train(train_loader, val_loader, optimizer, starting_epoch, val_best, ade_best, fde_best, val_edge_acc_best)":
if (model.two_stage_training) and (model.training_stage == 2):
model.load_relation_header()
If i don't add into the origin code,it will use random initial parameter for relation head which will cause the endless circles problem.

Stage 2 training should automatically load stage 1 weights if you give it the right config name in the command. I reccomend reviewing the command line params at the top of fjmp.py, as well as the examples in the readme.

Stage 2 training should automatically load stage 1 weights if you give it the right config name in the command. I reccomend reviewing the command line params at the top of fjmp.py, as well as the examples in the readme.

Thanks,i have just found that i set the hyperparams 'learned_relation_header' default = Ture in fjmp.py.That settings will force to use pretrained_relation_header but inital random relation_header to generate edges in DAG.That is the reason to  cause my problem.

Stage 2 training should automatically load stage 1 weights if you give it the right config name in the command. I reccomend reviewing the command line params at the top of fjmp.py, as well as the examples in the readme.

But i still have a confusion to confirm.In the stage one of two stage training code,FJMP also train proposal decoder.But in your supplement materials,Feature Encoder 1 and Feature Encoder 2 / Proposal Decoder 1 and Proposal Decoder 2use separate weights.Why not use Feature Encoder 1/Proposal Decoder 1 as  pretrained weights for Feature Encoder 2/Proposal Decoder 2.Since proposal decoder loss is introduced to the total loss as a regularization,i think that might be useful?
Another question is about how to understand factorized?Does it means FJMP first encode the source agent (influencer)and encode the reactor based on the condition of source agents' encodes?This can be described as factorized?

I will leave the first parts of your question for Luke to answer since he will do it more accurately.
For the second part about the factorization, I will say that the factorization only happens in the decoder part of the network.

I will leave the first parts of your question for Luke to answer since he will do it more accurately.
For the second part about the factorization, I will say that the factorization only happens in the decoder part of the network.

Sorry,caused by the wrong understanding and distinguishing between encoder and decoder,what i presented are unaccurate.In fact,in trajectory prediction,encoder only happens to the past information.I used to think of that unless the finally MLP of trajectory decoder are all called encoder.But all networks except LaneGCN which models for the future interaction are called decoder.So factorization happens on the decoder part.

On the models picture of the paper,does the factorization means the aggregation approach of DAGNN are factorized,which means first calculate the green and yellow agents trajectory representation,secondly calculate the blue agent representation based on the condition of green and yellow agents?
I have seen some papers about trajectory papers,they also mentioned about 'factorized'.But their factorized means factorize attention models into three parts--"Temporal Attention","Map lane to agents" and "agents to agents".I think your novel idea about factorized is about influencer and reactor based on the topology of DAG but not factorize attention models into three parts.Does FJMP use factorized methods based on influencer and reactor to avoiding modeling the distribution of agents simultaneously？

Can you provide the preprocessing of test?I try to get the test result but the code now might be invalid.thanks!

Hi Chengkai,
Sorry for the late reply. Yes, by "factorized", we mean that the distribution of multi-agent future trajectories is factorized as in Equation (1) in the paper. What you described above is correct regarding how we calculate the trajectory representations of the green, yellow, and blue agents.
Thanks for making the other point! We define "factorized" here as factorization of a joint probability distribution, which is different from the "factorized" socio-temporal attention used in papers such as SceneTransformer, Wayformer, and AutoBots.

Stage 2 training should automatically load stage 1 weights if you give it the right config name in the command. I reccomend reviewing the command line params at the top of fjmp.py, as well as the examples in the readme.

But i still have a confusion to confirm.In the stage one of two stage training code,FJMP also train proposal decoder.But in your supplement materials,Feature Encoder 1 and Feature Encoder 2 / Proposal Decoder 1 and Proposal Decoder 2use separate weights.Why not use Feature Encoder 1/Proposal Decoder 1 as pretrained weights for Feature Encoder 2/Proposal Decoder 2.Since proposal decoder loss is introduced to the total loss as a regularization,i think that might be useful? Another question is about how to understand factorized?Does it means FJMP first encode the source agent (influencer)and encode the reactor based on the condition of source agents' encodes?This can be described as factorized?

Regarding using stage 1 weights as a pre-trained checkpoint for training stage 2, we did not try this ourselves but I agree it makes sense and could be an interesting experiment!
Yes, we first predict the futures of the influencer(s) and then encode their futures with an MLP. The reactor then conditions on the encoded predicted futures of the influencer(s) (via graph attention). Therefore, decoding becomes a sequential process, where the length of the sequence is the longest path length in the DAG. I hope this clarifies things!


Alphabetize partner list in filter options

Resolves #1705
Description

Type of change

New feature (non-breaking change which adds functionality)

How Has This Been Tested?
I manually tested the change via the UI. Due to the size of the change, I'm not sure this would require a test. I'm open to suggestions 😄
Screenshots

Looks great, thanks for making the change!


Report etcd errors more accurately.

Looks fine, will you squash?

Not very much; I've got bones.

I mean yes.


make:model not working

Hi @TilakPutta,
I am happy to find this package.
Running php artisan make:model ModelName creates the following ModelName.php file
`<?php
namespace App;
use Illuminate\Database\Eloquent\Model;
class ModelName extends Model
{
//
}I was expecting something like<?php
namespace App;
use Jenssegers\Mongodb\Eloquent\Model;
class ModelName extends Model
{
//
}`

Do you think the package is not replacing the make:model because it does not have a service provider yet?


Change Thales references to nCipher

Hello
References on this page ought to be changed from 'Thales' to 'nCipher' as the nShield product line that the article refers to for HSMs is now owned by nCipher Security.
This comment applies to any other pages where 'Thales HSMs' are referenced in the context of Azure Key Vault. These are now nCipher HSMs.
Thanks.

Document details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: a52b0724-6b3b-0daf-7749-d18104d6a40b
Version Independent ID: 56e5c7c4-f456-fc2e-99da-2771eb162947
Content: Azure Key Vault Overview - Azure Key Vault
Content Source: articles/key-vault/key-vault-overview.md
Service: key-vault
GitHub Login: @barclayn
Microsoft Alias: barclayn

@MPenny-nCipher Thank you for your feedback . We will review and get this updated.

@MPenny-nCipher As per the referenced pull requests above, I have updated most of the references that I can find and where I had access to update however , there may still be some which i might have missed. Please wait for 24-48 hours for the changes to show up as per next release cycle. If you still find references to Thales , please continue to report them on the page itself as document feedback as there are different teams and multiple repositories and no single team has access to them all . Hence I request you to continue to report them.
We will close this issue now. The changes should be visible on the main page in the next 24 hours or 48 hours maximum. Should you still have any query on this , feel free to tag me or @barclayn to your reply and we will happily help you . alternatively you can always open a new issue with us.
Thank you.


feat(plugins): implemented mbp plugin

Implemented and tested mbp plugin. Pretty cool, the value is calculated after the order is applied. Fisrt time since the start of the project that this is possible.

:tada: This PR is included in version 1.4.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Chocolatey Download signature Incorrect on Windows 2022 image

Description
The fix for chocolatey download has included in #9876 / #9891  was not included in the most recent windows 2022 release / tag. Any chance you could produce a new version?
Platforms affected

[ ] Azure DevOps
[ ] GitHub Actions - Standard Runners
[ ] GitHub Actions - Larger Runners

Runner images affected

[ ] Ubuntu 20.04
[ ] Ubuntu 22.04
[ ] Ubuntu 24.04
[ ] macOS 11
[ ] macOS 12
[ ] macOS 13
[ ] macOS 13 Arm64
[ ] macOS 14
[ ] macOS 14 Arm64
[ ] Windows Server 2019
[X] Windows Server 2022

Image version and build link
Win22/20240514.3
Is it regression?
No
Expected behavior
Chocolatey installs successfully when building the Windows images
Actual behavior
Chocolatey fails to install when building the Windows images with the following message: Signature thumbprint do not match expected.
Repro steps
Attempting to build Windows 2022 image will error out when attempting to install chocolatey.

Hi @JWHolding ,
Please provide us with repro steps for further investigation. It would be great if you could provide us with error logs.

I get the same error.
"stderr_lines": ["Signature thumbprint do not match expected.", "At C:\\Program Files\\WindowsPowerShell\\Modules\\ImageHelpers\\InstallHelpers.ps1:972 char:9", "+
         throw \"Signature thumbprint do not match expected.\"", "+
         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~", "    + CategoryInfo          : OperationStopped: (Signature thumb...match expected.:String) [], RuntimeException", "    + FullyQualifiedErrorId : Signature thumbprint do not match expected.", " "]

The signature is on line 16 of Install-Chocolatey.ps1.
I don't know if this is relevant, but on the Chocolatey security page it mentions the signature and that it is not valid after May 1st.

Hi @ymerej ,
we are unable to re-produce the error, we are requesting you , fork the latest main branch into your local and retry and kindly check the thumbprint value in the logs and script both are match ?

Hi @kishorekumar-anchala, the fix / PR that I mentioned has been merged into main, and I believe an new release was created for Server 2019 which consumes the fix.  But the issue also affected Server 2022 but no new release was created for it, and we depend on the release tags for version pining.

Hello @JWHolding, it is better to build images from the main branch only, please read the faq section https://github.com/actions/runner-images?tab=readme-ov-file#faqs.
If you have any other questions feel free to reach us.

Hi @ymerej ,
we are unable to re-produce the error, we are requesting you , fork the latest main branch into your local and retry and kindly check the thumbprint value in the logs and script both are match ?

Using the main branch fixed my issue.  Thank you for the suggestions everyone!


Redirects cause root route loader invocation but root route component does not receive loader data

What version of Remix are you using?
1.5.1
Steps to Reproduce
A repo with a minimal reproduction is available here: https://github.com/jangerhofer/remixRootRouteRedirectReproduction along with some directions.
Expected Behavior
I expect that a server-side redirect (whether performance only once or multiple times) would cause a fresh root route loader function invocation and that the (serialized) value returned from the loader would be made available to the root route component via the useLoaderData hook.
Actual Behavior
Instead, I see only the invocation the root route loader; the useLoaderData hook's value remains an empty object despite the loader returning data.

@jangerhofer did you maybe have any luck with this? running onto the same problem as well...

@amanolar94: I did not, unfortunately.
Instead, I moved around my route structure to avoid having to perform two redirects. I used a pathless layout route in the process.

I see..In our case pathless layout route won't do since it is a dynamic segment.

@jangerhofer I was having a similar bug, but in the opposite way, where a user that no longer was logged in was still showing up in the root navbar. Then I started digging and found this  post, and in your repo you say that it works if

"the login form redirects to /, but the / index route's loader does not redirect but rather renders a component itself"

so I tried your code and only changed a few things in the index.tsx, leaving the routing to the component:
export const loader: LoaderFunction = async ({ request }) => {
  const cookieHeader = request.headers.get('Cookie');
  const { email } = (await session.parse(cookieHeader)) || {};

  return { email };
};

export default function Index() {
  let { email } = useLoaderData();
  let navigate = useNavigate();

  useEffect(() => {
    if (email) {
      navigate('/content');
    } else {
      navigate('login');
    }
  }, [email]);
  return <></>;
}

which worked as intended.
So, after a bit more digging, I finally got to the remix page about resource routes https://remix.run/docs/en/v1/guides/resource-routes, which says:

If a route doesn't export a default component, it can be used as a Resource Route. If called with GET, the loader's response is returned and none of the parent route loaders are called either (because those are needed for the UI, but this is not the UI). If called with POST, the action's response is called.

Now, this could be an answer, if if wasn't for the fact that we know the root loader is running, but its the root useLoaderData() which isn't (?) So, I'm not sure if that's what the documentation means and that's what is indeed happening or if it's something entirely different.
Also, redirect is just an http wrapper that creates a new Response with a redirect status, so it would make sense that we only return it in a loader when it is in a resource route. Otherwise, it would be a Response to be read when the client is expecting data. The only time I see redirect being used in the loading stage is by the server throwing it for the client to handle, otherwise it's probably only used in actions.
It's my first time answering to a question, and I'm new to remix, so I'm sorry if it's a bit confusing but it was something that also puzzled me and I think I kinda got deeper and had some info that might help!

Definitely sounds like multi-redirect is the problem here. I'm pretty sure our new code over in React Router doesn't do this. @brophdawg11 you mind looking into this one, fixing in Remix and verifying we have a test for it in React Router?
Should be able to make a test case out of the repo² pretty easily (get it? reproduction repository, the repo squared?! ... yeah it's early).

What's happening is Remix is accidentally trying to optimize the transition by only calling the loaders of changing layouts. When an action is called, it's not supposed to do that (it calls all loaders) but the double redirect has a bug (it seems) that still tries to optimize and so the root loader isn't called.
You can work around this bug for now by using <Form reloadDocument> on the login page so that everything runs through full document requests (and therefore skips any of the client side optimization attempts).
Or you can add some junk to the url search params that'll trigger all loaders to be called:
redirect("/content?"+Date.now());

Closed by #3460


Decrease max remote path distance based on threat

-reduce by up to 20% or so

half completed. Connect use values to real action in remote logic.
added useSources to be used for room use consideration


SequencerScanner: write collected diff files to external repository

Functionality to write diff files containing one-line-fixes into an external repository.
Currently using repairnator/continuous-learning-data

Thanks for the PR. Could you add a test case to specify this new feature?

Thanks for the PR. Could you add a test case to specify this new feature?

Test case is now in place.

Activated CI on PR again. We have a failure to handle, partly due to #744. Fixing it now with #983.

CI Fixed. This PR introduces a regression, see https://travis-ci.org/eclipse/repairnator/jobs/621918221
  TestRTScanner.testDockerPipelineRunner:41 » NoSuchMethod org.apache.http.impl....
  TestSequencerCollector.initMocks:38 Mockito
Cannot instantiate @InjectMocks f...

This is likely due to the introduction of the new library which changes some versions in the underlying dependencies. Could you have a look?

OK. It is fixed now, there were 2 problems.

JGit package version created a dependency conflict.
Some local paths were not resolving when running the new test case.

Thanks a lot!


Adding a tag that begins with @ causes a FileNotFoundError

Describe the bug
What the title says. :P
To Reproduce
$ az group create --location canadacentral --resource-group sam-test-rg --tags 'Owner_Slack_Username=@sam' 'Owner=Sam' 'Environment=Dev'
[Errno 2] No such file or directory: 'Sam'
Traceback (most recent call last):
File "/usr/local/Cellar/azure-cli/2.0.31/libexec/lib/python3.6/site-packages/knack/cli.py", line 197, in invoke
cmd_result = self.invocation.execute(args)
File "/usr/local/Cellar/azure-cli/2.0.31/libexec/lib/python3.6/site-packages/azure/cli/core/commands/init.py", line 215, in execute
args = _pre_command_table_create(self.cli_ctx, args)
File "/usr/local/Cellar/azure-cli/2.0.31/libexec/lib/python3.6/site-packages/azure/cli/core/commands/init.py", line 109, in _pre_command_table_create
return _expand_file_prefixed_files(args)
File "/usr/local/Cellar/azure-cli/2.0.31/libexec/lib/python3.6/site-packages/azure/cli/core/commands/init.py", line 104, in _expand_file_prefixed_files
return list([_expand_file_prefix(arg) for arg in args])
File "/usr/local/Cellar/azure-cli/2.0.31/libexec/lib/python3.6/site-packages/azure/cli/core/commands/init.py", line 104, in
return list([_expand_file_prefix(arg) for arg in args])
File "/usr/local/Cellar/azure-cli/2.0.31/libexec/lib/python3.6/site-packages/azure/cli/core/commands/init.py", line 100, in _expand_file_prefix
return '='.join([arg_split[0], _maybe_load_file(arg_split[1])])
File "/usr/local/Cellar/azure-cli/2.0.31/libexec/lib/python3.6/site-packages/azure/cli/core/commands/init.py", line 92, in _maybe_load_file
return _load_file(poss_file)
File "/usr/local/Cellar/azure-cli/2.0.31/libexec/lib/python3.6/site-packages/azure/cli/core/commands/init.py", line 79, in _load_file
content = read_file_content(os.path.expanduser(path), allow_binary=True)
File "/usr/local/Cellar/azure-cli/2.0.31/libexec/lib/python3.6/site-packages/azure/cli/core/util.py", line 125, in read_file_content
with codecs_open(file_path, encoding=encoding) as f:
File "/Library/Frameworks/Python.framework/Versions/3.6/lib/python3.6/codecs.py", line 897, in open
file = builtins.open(filename, mode, buffering)
FileNotFoundError: [Errno 2] No such file or directory: 'Sam'

Expected behavior
The command should not fail, or should fail gracefully if this is not supported by Azure.
Environment summary
Unknown.
Additional context
From Azure/azure-docs-cli-python#790.

@samispurs, FYI.

//CC: @tjprescott @troydai, I would vote we proceed with the content instead of raising file not found, because  CLI has no firm ways to determine the user is indeed using a file here. Saw similar issue was reported before on passwords.

Whatever we do, a big funky stack trace isn't the right approach, but I think @yugangw-msft's idea is reasonable.

Nice turn around, all: thanks!


CORTX-34147: Add time stamp for consul process state updated in bq

Problem:
HARE bq messages in Support Bundle do not contain timestamps.
This is needed for effective offline debug using logs from Support bundle.
Solution:
Add timestamps to bq publisher; also add the consul kv dump so generated to
Support Bundle.
Signed-off-by: pavankrishnat<EMAIL_ADDRESS>

Deployed 3N setup with PR changes.

This is needed for effective offline debug using logs from Support bundle.
Solution:
Add timestamps to bq publisher; also add the consul kv dump so generated to Support Bundle.

retest this please


Indexable#find and #find! with start offsets

Indexable has overloads of Enumerable#index and #index! that accept an additional optional starting offset argument:
module Enumerable(T)
  def index(& : T ->) : Int32?; end
  def index(obj) : Int32?; end
  def index!(& : T ->) : Int32; end
  def index!(obj) : Int32; end
end

module Indexable(T)
  def index(offset : Int = 0, & : T ->); end
  def index(object, offset : Int = 0); end
  def index!(offset : Int = 0, & : T ->); end
  def index!(obj, offset : Int = 0); end
end

The same is not true for Enumerable#find:
module Enumerable(T)
  def find(if_none = nil, & : T ->); end
  def find!(& : T ->) : T; end
end

module Indexable(T)
  # no overloads for `#find` and `#find!`
end

If x : Indexable then it seems natural that:

x.find!(offset, &block) should be equivalent to x.unsafe_fetch(x.index!(offset, &block));
x.find(if_none, offset, &block) should be equivalent to x.index(offset, &block).try { |i| x.unsafe_fetch(i) }.

So I think those additional overloads should be available in Indexable as well, so that we don't have to write the above unsafe_fetch (or even a regular #[] call).

Hi! I'm a first time contributor to crystal and would like to try implementing this feature. Could you assign the issue to me please?


fix require("node:buffer") issue

I have noticed that in 13.3.1-canary.13 Next introduces require("node:buffer")s which break the build of next-on-pages apps, this change is a preemptive fix for that

We should look into exporting stuff like this from Wrangler so others things (like next-on-pages) can consume them.
e.g. list of node:* importables, list of compatibility flags, mapping of compatibility flags to compat date that they are on-by-default for etc. etc.
Probably only makes sense when we do the JS API, but worth keeping in mind.


Ternary operator crash

This simple code crashes:
string someStr;
json j = json::object();
// the next line crashes
j["someKey"] = someStr.empty() ? nullptr : someStr;
However, if I use standard if-else condition, everything is fine:
string someStr;
json j = json::object();
// the code below works ok
if (someStr.empty()) j["someKey"] = nullptr;
else j["someKey"] = someStr;
Also if S is not empty - both versions work.
Is it a bug or feature? :)
I'm using GNU C++ 14 compiler, IDE Xcode 9.3

The types in someStr.empty() ? nullptr : someStr seems to be treated as const char* then yields j["someKey"] = (const char*)nullptr; which calls std::string(nullptr) which yields the error.
I have no idea how to tell the compiler that someStr.empty() ? nullptr : someStr should be treated as json other than to make it explicit:
j["someKey"] = someStr.empty() ? json(nullptr) : json(someStr);

A single type is deduced based on the types of the two values of the ternary operator.  There is no type that works properly for nullptr and std::string here.  That requirement is not there for the if/else. If you want the type to be null for an empty someStr instead of an empty string, you need to use the if/else.  Otherwise, there's no point in even having the check, and you can simply do j["someKey"] = someStr;.

Yes, I indeed need the field being null for empty strings, and I was able to solve it.
Thank you, guys, for telling me two different solutions and for an information about how ternary operator works.


CONTRIBUTING requests copyright assignment, not merely a CLA

This seems a little strange for a fork of code from the Go project, and somewhat offputting for contributing bugfixes.

Hey :wave: I assume you're referring to https://github.com/ProtonMail/.github/blob/main/CONTRIBUTING.md. It was written with the ProtonMail apps in mind, I agree it doesn't make as much sense for this library. I'll see if I can get that changed.

I've modified the clause in https://github.com/ProtonMail/go-crypto/commit/1fde58898e96d4f9850d6948ed61091e8580108e.


SPFx extensions not working in Sharepoint Modern list default pages

Category

[X ] Question
[ ] Typo
[ ] Bug
[ ] Additional article idea

Expected or Desired Behavior
Hi Team,
We have created a SPFx extension with Top and Bottom placeholders. Both these placeholders have data manipulations which is fetched from external js file(loaded through SPComponentLoader inside Init method) uploded in the same SIte Collections.
After deploying and adding the app across Site Collection,the extensions are working fine across Site Pages. But when we tried creating a new Sharepoint list with Modern Experience, the Top and Bottom Placeholders are not loading in the list pages(AllItems.aspx).
Any ideas on why this is happening.
Thanks for your contribution! Sharing is caring.

@srisspfx says:

Any ideas on why this is happening.

Not without having more context (SPFx version used), browser, SharePoint environment & seeing some code... can you provide some additional context?

Sounds like it may be related to https://github.com/SharePoint/sp-dev-docs/issues/2779
The root cause on that was the application extension wasn't properly interacting with the placeholders. Due to using an older method of interaction. Updating to use: https://docs.microsoft.com/en-us/sharepoint/dev/spfx/extensions/get-started/using-page-placeholder-with-extensions instead fixed the issue

Sorry - misread the thread.  I thought Maarten was saying he fixed his code and the bug was gone, not that he solved it, so srisspfx might try the same thing.

@srisspfx says:

Any ideas on why this is happening.

Not without having more context (SPFx version used), browser, SharePoint environment & seeing some code... can you provide some additional context?

Hi Andrew,
Tried logging in console after the promise, below is the error that we are getting.

NOTE: We have noticed that the placeholder is loading properly, but components loaded through SPComponentLoader doesn't work. This is happening only in List pages and not on Site Pages.
Thanks in advance.

@srisspfx Can you provide a link to a GH repo that has a minimal repo of the issue? Would make for evaluating this as a bug a lot easier...

HelloWorldApplicationCustomizer.txt
Above is the source code for .ts file.
Its not passing beyond the below code:
SPComponentLoader.loadScript("https://ABC.sharepoint.com/sites/uatModern/SiteAssets/Modern/jquery-3.3.1.min.js")
So it fails to load the jquery plugin, because of which, none of the subsequent js files are loaded.
Thanks.

This happens only when we open the Modern list page(AllItems.aspx). If i create a normal Modern SitePage, its executing all .js files successfully.

any updates on the issue why it is happening?

According to the 1.8.2 release notes out today it appears MSFT is aware and "working on it"

@srisspfx - sorry for the super slow response here.  We just got around to looking at this and it appears that it is no longer reproing (on a list I am able to load a placeholder which in the oninit function calls SPComponentLoader.loadScript("https:///SiteAssets/Modern/jquery-3.4.1.min.js") and then have the promise resolve).  Are you still seeing this issue?