Alternate messaging

Current header messaging is "One hour, millions of kids, limitless possibilities.  Pick a game and step right up!"
Since our primary audience is students/kids, I might suggest something that is more descriptive of what they will be doing on this page.
Suggestion: "Code a fun Carnival Game in less than an hour!  Step right up and choose one of the three activities below!"

Alex should work on this with Catherine.  I don't see her in this repo so I can't tag her.


Why use text-builder instead of text's Builder ?

Hello!
I was on my way to make a PR to get rid of text-builder in favor of the builder API already available in text when I noticed:
https://github.com/mitchellwrosen/text-ansi/commit/b3bfa932155bd868ba074976d14bb2016180278c
and wondered what motivated this change? The commit doesn't say much, hence the issue.
Thanks for the clarification.

It's faster and doesn't take nearly as long to compile modules that use it.


Met error of CUDA out of memory.  How to split the model into multiple GPUs?

When loading the checkpoint, it comes out:
torch.cuda.OutOfMemoryError: CUDA out of memory. Tried to allocate 50.00 MiB (GPU 0; 15.90 GiB total capacity; 15.30 GiB already allocated; 31.81 MiB free; 15.30 GiB reserved in total by PyTorch) If reserved memory is >> allocated memory try setting max_split_size_mb to avoid fragmentation.  See documentation for Memory Management and PYTORCH_CUDA_ALLOC_CONF

Currently, the tensor parallel functionality is not supported. We will release the V2 version which includes vLLM inference server and tensor parallel recently. Stay tuned!

I know i'm too late on this issue as it's already closed but i cannot find the hardware requirements to run it. How much RAM and GPU RAM is needed or recommended for running openchat?

We recommend having a GPU with memory of at least 40GB (1x A100) to run the server

We recommend having a GPU with memory of at least 40GB (1x A100) to run the server

@imoneoi please add the clearly in readme.

We recommend having a GPU with memory of at least 40GB (1x A100) to run the server

This is super unclear in Readme.
Does this mean that this project can NOT be started as server on Tesla T4 16 GB or P40 24Gb ?


Issue 855

Description
Solve this issue https://github.com/PaloAltoNetworks/docusaurus-openapi-docs/issues/855

Hi @sserrata could you check this PR please?


Dart Analyzer Error while manually refactoring a child widget to a variable

Analyzer Feedback from IntelliJ
Version information

IDEA AI-171.4392136
1.25.0-dev.11.0
AI-171.4392136, JRE 1.8.0_152-release-915-b01x64 JetBrains s.r.o, OS Linux(amd64) v4.4.0-66-generic unknown, screens 1366x768

Exception
Please append the contents of:
file:///tmp/report.txt
report.txt
Dart analysis server, SDK version 1.25.0-dev.11.0, server version 1.18.4, error: Failed to handle completion domain request: {id: 565, method: completion.getSuggestions, params: {file: /home/sarah/IdeaProjects/horizontal_scaffold/lib/main.dart, offset: 5137}, clientRequestTime:<PHONE_NUMBER>345}
NoSuchMethodError: The getter 'name' was called on null.
Receiver: null
Tried calling: name
#0      Object._noSuchMethod (dart:core-patch/object_patch.dart:42)
#1      Object.noSuchMethod (dart:core-patch/object_patch.dart:46)
#2      _OpTypeAstVisitor.visitNamedExpression.<anonymous closure> (package:analyzer_plugin/src/utilities/completion/optype.dart:745)
#3      Object

I believe that this was fixed by https://dart-review.googlesource.com/11940. The fix should be included in the next dev release.


Mods Don't Load in 2.0

Good morning,
Using mods updated for 2.0 release. I see the mod-list.json file is still created/updated successfully, but the logs don't show the mods loading and the modlist when you connect to the server doesn't contain any mods.
e; This is for a server-created new save

Discovered the issue here, there was a local docker issue with WSL causing it to be unable to read the files


Fix compilation issue in SimpleStorageContract

The code does not compile, I made some modifications so that the beginners can make it compile without too much effort
By replacing "cheats" by "vm" at the right place in the code.
and "string public value;" by "uint256 public value;" in the smart contract SimpleStorageContract.

@all-contributoirs add @azanux for maintenance

@all-contributors add @azanux for maintenance


OpenMP does not work correctly on Linux

On my AlmaLinux 9 installation, OpenMP behaves erratically: the more threads that are requested, the slower the TOTAL running time will be.
I have a 14-core cpu with hyperthreading (28 threads); with the setting omp_num_threads='auto' indeed all threads are used (as proven by htop) but the total running time is 4 times slower than on a single core...
This does not happen on my mac, where the behaviour is as expected.
MWE:
import xtrack as xt
import xobjects as xo
import xpart as xp
import xcoll as xc

num_part = 200
num_turns = 1000
line = xt.Line.from_json(xc._pkg_root.parent / 'examples' / 'machines' / 'lhc_run3_b1.json')
line.build_tracker()

part_init = xp.generate_matched_gaussian_bunch(num_particles=num_part, nemitt_x=3.5e-6, nemitt_y=3.5e-6, sigma_z=0.08, line=line)
part_init._init_random_number_generator()

# This runs in a bit more than a minute on single core
part = part_init.copy()
line.track(part, num_turns=num_turns, time=True, with_progress=1)
print(f"Done tracking in {line.time_last_track:.1f}s ({len(part.x[part.state>0])}/{num_part} survived).")

# This uses all my threads (28 at 100% as proven by htop) but runs four times as slow IN TOTAL as single-core
# (a bit more than 4 minutes in total)
line.discard_tracker()
line.build_tracker(_context=xo.ContextCpu(omp_num_threads='auto'))
part = part_init.copy()
line.track(part, num_turns=num_turns, time=True, with_progress=1)
print(f"Done tracking in {line.time_last_track:.1f}s ({len(part.x[part.state>0])}/{num_part} survived).")

# This indeed uses 12 threads (as proven by htop), and is slightly faster than above but still slower than single-core
# (2.5 minutes in total)
line.discard_tracker()
line.build_tracker(_context=xo.ContextCpu(omp_num_threads=12))
part = part_init.copy()
line.track(part, num_turns=num_turns, time=True, with_progress=1)
print(f"Done tracking in {line.time_last_track:.1f}s ({len(part.x[part.state>0])}/{num_part} survived).")

# This indeed uses 4 threads (as proven by htop), and is faster than above but still slightlyslower than single-core
# (1.5 minutes in total)
line.discard_tracker()
line.build_tracker(_context=xo.ContextCpu(omp_num_threads=4))
part = part_init.copy()
line.track(part, num_turns=num_turns, time=True, with_progress=1)
print(f"Done tracking in {line.time_last_track:.1f}s ({len(part.x[part.state>0])}/{num_part} survived).")

Are particles being lost?


[@cosmos-kit/cosmos-extension-metamask]Coin type 60 is forbidden

Hey team,
We are running into a situation when building a dapp with cosmos-kit react wallet on Injective chain

@cosmos-kit/cosmos-extension-metamask
@cosmos-kit/react

import { wallets as metaMaskWallets } from '@cosmos-kit/cosmos-extension-metamask';
import { wallets as keplrWallets } from '@cosmos-kit/keplr';

export const CosmosWalletProvider: FC<PropsWithChildren> = ({ children }) => {

  return (
    <ChainProvider
      chains={[injChain]} // https://github.com/cosmos/chain-registry/blob/master/injective/chain.json
      assetLists={[assetList]}
      wallets={[...keplrWallets, ...metaMaskWallets]}
    >
      {children}
    </ChainProvider>
  );
};

Keplr is working like a charm, but Metamask is not working as expected. There are two scenarios:

The wallet is successfully connected, but the  "inj" address seems not correct. (different from the one showing in injective hub. See the video below):

https://github.com/cosmology-tech/cosmos-kit/assets/127958634/6bfdef5c-1d6f-4354-b5d9-f1b31504df73

The error Coin type 60 is forbidden is thrown when I try to use client.signArbitrary.

Code:
 const { client, status } = useWalletClient();
//...

        <div
          onClick={() => {
            if (client?.signArbitrary && client.getAccount) {
              client.getAccount('injective-1').then((account) => {
                // Along with the following 'arr', I also tried inj addr and eth hex addr. But still no luck
                const arr = Buffer.from(
                  new Uint8Array(Object.values(account.pubkey)),
                ).toString('base64');
                console.log({ addr: arr });
                client?.signArbitrary?.('injective-1', arr, 'test');
              });
            }
          }}
        >
          Sign with metamask
       </div>
//...

Not sure if it is caused by INJ chain's being not supported (or even the .signArbitrary is not support using Metamask?).
Please point me out if I miss anything.

@eric-notifi Hello! Thanks for this. The issue you are seeing is because Coin Type 60 is the coin type for all native Metamask addresses and they block Coin Type 60 in the Metamask Snap SDK. Thus any coin type 60 chains are supported natively by Metamask, not with the Cosmos Extension for Metamask.
Hope that clears it up!


[docker] refine Dockerfile

Current coverage is 91.14%

Merging #93 into master will not affect coverage as of 45e0d4f

@@            master     #93   diff @@
======================================
  Files          114     114
  Stmts        10578   10578
  Branches       363     363
  Methods          0       0
======================================
  Hit           9641    9641
  Partial        254     254
  Missed         683     683

Review entire Coverage Diff as of 45e0d4f

Powered by Codecov. Updated on successful CI builds.


Docs: Example usage?

It’d be good if the docs showed how you’d install/run this. Not sure what commands would need to be run and how to pair it to a rower?

Hopefully added enough info for most users to get up and running. Would be nice in future to include details/files.packaging enabling installation this as headless service, although this information in freely available elsewhere.


Merging Subtitles

Trying to merge subs with mkvs in batch fails with binary - works when running from npm start

Update: merging in batches actually works from both the binary and npm start. However, it fails with big batch sizes (failed with batch of 25 and batch of 10). It works with small batches (ie. batches of 5).

Update: batch of 10 worked - it appears that batches take longer proportional to the size of the batch (which is given). However, it appears that this rate is superlinear. More research required.
Suggestion: Add a "spinner" of sorts to inform user that program hasn't frozen and is merely merging batch.
Suggestion: Within the merge function, artificially create smaller batches to be run at a time

A batch of 25 files, each file ~20mins long took 22mins 17seconds to fully multiplex

Tested same batch of 25 files, each file ~20mins long but with Promise-Reducer pattern from Pipeline project: total running time was 4mins 36 secs. This takes advantage of Node.js single-threadedness.

Resolved with this commit. Will include in next release - closing.


Color coded output?

Is it possible to have the output on the terminal color coded? For example, any text that I type be in black while the AI's answer in blue?

Thank you for your feedback.
Currently the generated text is only in the default color (e.g. black text on a white background). We will look into color coding the output in our future releases.

The streamlit GUI addresses this issue. Now the user inputs are visually differentiated from the AI's text.


Don't use go get github.com/libvirt/libvirt-go

When I want use go get github.com/libvirt/libvirt-go, error return "No package 'libvirt' found"

I have to think you've got a local toolchain or network problem, as 'go get github.com/libvirt/libvirt-go' works fine when i test & we have automated tests doing the same too.


lyxal: Watch gene-rator.online

lyxal requests the watch of the watch_keyword gene-rator\.online. See the MS search here and the Stack Exchange search in text, in URLs, and in code.

gene-rator\.online has been seen in 1 true positive, 0 false positives, and 0 NAAs.

Approved by Cody Gray in Charcoal HQ


[Proposal] Add overridable collection handle generator

Currently, concrete5 creates a collection handle from request.
concrete5 allows multibyte collection handles with no maximum limit, but sometimes I want to change the rule (e.g. allow only alphanumeric characters).
This logic written in \Concrete\Core\Page\Page::update(), so develop can't override it.
So, how about creating a "Collection Handle Generator" class and make it overridable?
If it sounds reasonable, I'll try to implement it.

Makes sense.

I would like to see more enhancements like the current one. This would reduce the amount of the page mammoth and with this also the complexity/coupling.

@hissy Just recently was testing the current state of the core and I can't set page names on pages through composer any longer. I'm not 100% sure what the issue is but I figure it has to be related to this. Is this something that you've seen?

Ok, I'll test it ASAP.

Actually @hissy this is my mistake, my apologies. It's working just fine.

Alright, no problem.


[BUG] Make contributor page responsive

Is there any existing issue for this?

[X] I have searched the existing issues

Description
I worked with the page but while transitioning to talwind CSS from plain CSS, I forgot to make it fully responsive. Was planning to add some additional styling to the button as well
Screenshots
No response
Any additional information?
No response
What browser are you seeing the problem on?
No response

I would like to work on this issue under gssoc'23

And extremely sorry for the mistake

https://www.awesomescreenshot.com/video/18849652?key=678aa5df4e152d7b009f3933feb93f45
Clip of the responsive page, just did it, Will submit pr as soon as assigned

Submitting pr for review in a min


sideNav with edge=right broken

Hello,
I just upgraded from 0.97.3 to 0.97.6 and the first thing I noticed is that my mobile sidenav, which is on the right side of the screen is no longer playing nice.
I partially shows up when hidden and misplaced when showing.
I noticed the css includes right: auto under .side-nav.right-aligned
If I remove that, it works fine again.
A bug, I guess?

I think I realized what happen. I converted the css file to RTL (using rtlcss) and that changed the values from your original (it actually has left: auto on it).
I should not be coding at 4:30am...

Please provide a way to reproduce it. like a codepen or  a snippet
Closed due inactivity, feel free to reopen it if it is still necessary.


Documentation

Is there a reason why the pictures in the Documentation are all taking place in West US instead of a government region? We are looking into information on this and when the documentation doesn't follow what the article is about it doesn't give me a ton of confidence.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 0f2c35c7-0563-258b-b92e-6b87d8ba4834
Version Independent ID: e85653d1-5d9a-7a9f-3ae6-e8acbdd87dc3
Content: Deploy StorSimple 8000 series device in Government portal | Microsoft Docs
Content Source: articles/storsimple/storsimple-8000-deployment-walkthrough-gov-u2.md
Service: storsimple
GitHub Login: @alkohli
Microsoft Alias: alkohli

Hello JD, The actual difference in the deployment in the government region and the Azure public cloud is minimal. Only 2 steps are different, one is the service creation where the DC regions are different. The other initial configuration through setup wizard. This was tried multiple times in the Classic portal. It is hard to get the actual device set up in Government region for screenshots and hence the use of normal screenshots. The differences are explicitly called out in the doc. Thanks!

#in-progress

The current doc is good as-is. However to alleviate concerns, I can add a screenshot for step 1 in the deployment where you can see the difference. The screenshot does not exist as of now. This will however take some time. Getting a test bed and a govt subscription will take time. I will open a VSTS item and work on that. Will post a comment when this gets done. Thanks!


Usage with multiple treatments and controls

If I have ChIP experiments on multiple different treatment groups  (lets say dosage A B C D and a control group) how should I input into epic? Do I list the different treatment in a single command and epic treats them separately? Or should I run epic for each treatment vs a control.
Also that brings me to confusion in wordage for the control flag. Is it reads from an actual ChIP input (i.e no antibody chromatin DNA) or the IP of an untreated control group?

I would run the all files related to each dosage group separately.
so epic -t A1.bed A2.bed -c A_I1.bed A_I2.bed, then epic -t B1.bed B2.bed -c B_I1.bed B_I2.bed

The first, I was not thinking of control groups when writing that. If you could suggest a wording that sounds better to biologists, please help me :)

By the way, epic contains an option to print a gzipped-matrix of bin counts. These can be used to run linear models on your experiment afterwards. See --store-matrix.
Closing this, but feel free to ask more related questions here or start a new thread.


Revert pyhydroquebec version to 1.1.1

Description:
There is a bug in version 1.2.0 that breaks the component. I was unable to narrow down why i was getting an error on this line of version 1.2.0 (line 279: contract_data = {"balance": balances[balance_id]}) giving "index out of range exception". Reverting back to the old version solved the problem.
contract_data = {"balance": balances[balance_id]} IndexError: list index out of range

Related issue (if applicable): none

Hi @mderubertis,
It seems you haven't yet signed a CLA. Please do so here.
Once you do that we will be able to review and accept this pull request.
Thanks!

Please don't make PRs to master and first contact the maintainer of pyhydroquebec


Investigate iOS E2E timeouts

After the initial CI buildout and fixing #50 (upstream PR still in progress) ios e2e was working I thought
Then perhaps after the #54 I think it may have stopped getting reports for some reason and now cancels out
As a side project, it would be cost optimal if there was a way to run the E2E items in the open source repo vs the private core repo, but that is likely a separate thing - just mentioning it here

@mikehardyif we swap to detox, it's built-in.


manifest: clarify failure modes for unknown layer types

Per #803, there seems to be some confusion about how tools should fail when
they encounter unknown layer types. Container runtimes cannot satisfy the
bit about:
The final filesystem layout MUST match the result of
applying the layers to an empty
directory.
by ignoring layer types, so the spec is slightly in conflict with itself
here, by requiring runtimes both MUST apply all the layers and MUST ignore
layers that they cannot understand. Given that the behavior of runtimes
(and image tools like umoci) today is simply to fail if it gets a layer
type it doesn't understand here, let's clarify the behavior to that.
However, image transfer tools can safely ignore mime types they don't
understand (indeed, skopeo does this today); let's add the wiggle wording
about "cannot be processed" for all similar classes of tools which don't
actually need to inspect layer content.
Suggested-by: Sebastiaan van Stijn<EMAIL_ADDRESS>Signed-off-by: Tycho Andersen<EMAIL_ADDRESS>

Closing since I believe the concern was resolved, but feel free to update the PR and reopen if there are still gaps.


Add link to client in project details

Enhancement suggested by
@GauravGusain98
Describe the task
Good navigation helps to improve user experience in an application. In the projects details page, we show the client name to the user but if we want to see the details of the client then a user has to go to the client page and then search for the client and see his points. Instead of going through this long process, it would be better if a user can just go to a particular client by clicking on the client's name present in the project details page.

Expected behavior

We want to add link to client name so that on clicking it user is redirected to the client details page shown below. NOTE: You can go to client details page from client listing

Point of Contact for guidance
@GauravGusain98

Action Items
Basics - 1 pointer

[ ] Read about Models in Laravel. Share your understanding of why we use them in the task comment in your own language
[ ] Read about Views in Laravel. Share your understanding of why we use them in the task comment in your own language
[ ] Read about Routes in Laravel. Share your understanding of why we use them in the task comment in your own language
[ ] Read about Controller in Laravel. Share your understanding of why we use them in the task comment in your own language
[ ] Read about Services files in Laravel. Share your understanding of why we use them in the task comment in your own language
[ ] Read how we can print a value in Laravel using dd()
[ ] Try printing hello world using the dd function
[ ] On project details page print project data using dd function.

Models in Laravel.
The model is the database table which holds(store) the application data and logic. and the controller directly interacts with the model to modify or change the view.

Views in Laravel.
View is the part which shows the data to the user and also handles user interaction. View get its data from model and generates the presentation for the user. view files must have .blade.php extension and are created in View folder.

Routes in Laravel.
Routes are the urls which we create for the application routes are created inside the routes folder. They are created in the web.php file for websites.

Controller in Laravel.
Controller is like middleware of the application which interprets the input from the user and handles the user interaction by informing model and the view to change as appropriate. Controller is class based file in Controllers folder.

Services files in Laravel.
A service file is a class that provides the functionality that the class provides, that can be reused in multiple other parts of the application.

Print a value in Laravel using dd()
Laravel collection provides the wrapper for working with arrays of data. To print this collection we use the dd() function which is combination of dump() and die().
dump() to print the data and die() to halt the process.
Public function list(){  $data = task::all();  dd($data->toArray()); }


Build on linux, got "@local_config_cuda//crosstool:cc-compiler-windows" error

Built jax on master 78c804772e47f98721acd31a7e0953504aa504a8 gives
➜  jax git:(master) python build/build.py --enable_march_native --enable_mkl_dnn --enable_cuda

     _   _  __  __
    | | / \ \ \/ /
 _  | |/ _ \ \  /
| |_| / ___ \/  \
 \___/_/   \/_/\_\

Bazel binary path: /home/titan/bin/bazel
Python binary path: /home/titan/frameworks/miniconda3/envs/ml/bin/python
MKL-DNN enabled: yes
-march=native: yes
CUDA enabled: yes

Building XLA and installing it in the jaxlib source tree...
INFO: An error occurred during the fetch of repository 'local_config_python'
INFO: Call stack for the definition of repository 'local_config_python':
 - /home/titan/.cache/bazel/_bazel_titan/0fa25a5a75e40e18875f78640c2a6d59/external/org_tensorflow/tensorflow/workspace.bzl:69:5
 - /home/titan/resources/oss/machine-learning/Google/jax/WORKSPACE:41:1
ERROR: /home/titan/.cache/bazel/_bazel_titan/0fa25a5a75e40e18875f78640c2a6d59/external/local_config_cuda/crosstool/BUILD:64:1: in cc_toolchain rule @local_config_cuda//crosstool:cc-compiler-windows: attributes 'cpu' and 'compiler' have been deprecated, please remove them. See https://github.com/bazelbuild/bazel/issues/7075 for details.
ERROR: Analysis of target '//build:install_xla_in_source_tree' failed; build aborted: Analysis of target '@local_config_cuda//crosstool:cc-compiler-windows' failed; build aborted
INFO: Elapsed time: 0.095s
INFO: 0 processes.

I have successfully built jax before without encounter this error.

If I'm parsing the log correctly, it's picking up your own version of bazel (/home/titan/bin/bazel), rather than one it automatically downloads. What version of bazel is that?

Build label: 0.25.0
Build target: bazel-out/k8-opt/bin/src/main/java/com/google/devtools/build/lib/bazel/BazelServer_deploy.jar
Build time: Wed May 1 21:45:01 2019<PHONE_NUMBER>)
Build timestamp:<PHONE_NUMBER>
Build timestamp as int:<PHONE_NUMBER>

Also try to remove my local bazel to let jax use a download bazel, still an issue:
jax git:(master) python build/build.py --enable_march_native --enable_mkl_dnn --enable_cuda

     _   _  __  __
    | | / \ \ \/ /
 _  | |/ _ \ \  /
| |_| / ___ \/  \
 \___/_/   \/_/\_\

Downloading bazel from: https://github.com/bazelbuild/bazel/releases/download/0.25.1/bazel-0.25.1-linux-x86_64
bazel-0.25.1-linux-x86_64 [########################################] 100%
Extracting Bazel installation...
Starting local Bazel server and connecting to it...
Bazel binary path: ./bazel-0.25.1-linux-x86_64
Python binary path: /home/titan/frameworks/miniconda3/envs/ml/bin/python
MKL-DNN enabled: yes
-march=native: yes
CUDA enabled: yes

Building XLA and installing it in the jaxlib source tree...
ERROR: /home/titan/.cache/bazel/_bazel_titan/0fa25a5a75e40e18875f78640c2a6d59/external/local_config_cuda/crosstool/BUILD:34:1: in cc_toolchain rule @local_config_cuda//crosstool:cc-compiler-local: attributes 'cpu' and 'compiler' have been deprecated, please remove them. See https://github.com/bazelbuild/bazel/issues/7075 for details.
INFO: An error occurred during the fetch of repository 'local_config_python'
INFO: Call stack for the definition of repository 'local_config_python':
 - /home/titan/.cache/bazel/_bazel_titan/0fa25a5a75e40e18875f78640c2a6d59/external/org_tensorflow/tensorflow/workspace.bzl:69:5
 - /home/titan/resources/oss/machine-learning/Google/jax/WORKSPACE:41:1
INFO: An error occurred during the fetch of repository 'cython'
INFO: Call stack for the definition of repository 'cython':
 - /home/titan/.cache/bazel/_bazel_titan/0fa25a5a75e40e18875f78640c2a6d59/external/org_tensorflow/tensorflow/workspace.bzl:727:5
 - /home/titan/resources/oss/machine-learning/Google/jax/WORKSPACE:41:1
INFO: Repository 'cython' used the following cache hits instead of downloading the corresponding file.
 * Hash 'bccc9aa050ea02595b2440188813b936eaf345e85fb9692790cecfe095cf91aa' for http://mirror.tensorflow.org/github.com/cython/cython/archive/0.28.4.tar.gz
If the definition of 'cython' was updated, verify that the hashes were also updated.
ERROR: Analysis of target '//build:install_xla_in_source_tree' failed; build aborted: Analysis of target '@local_config_cuda//crosstool:cc-compiler-local' failed; build aborted
INFO: Elapsed time: 1.291s
INFO: 0 processes.
FAILED: Build did NOT complete successfully (27 packages loaded, 76 targets configured)
FAILED: Build did NOT complete successfully (27 packages loaded, 76 targets configured)
    currently loading: @org_tensorflow//tensorflow/core ... (5 packages)
Traceback (most recent call last):
  File "build/build.py", line 324, in <module>
    main()
  File "build/build.py", line 320, in main
    [":install_xla_in_source_tree", os.getcwd()])
  File "build/build.py", line 50, in shell
    output = subprocess.check_output(cmd)
  File "/home/titan/frameworks/miniconda3/envs/ml/lib/python3.6/subprocess.py", line 336, in check_output
    **kwargs).stdout
  File "/home/titan/frameworks/miniconda3/envs/ml/lib/python3.6/subprocess.py", line 418, in run
    output=stdout, stderr=stderr)
subprocess.CalledProcessError: Command '['./bazel-0.25.1-linux-x86_64', 'run', '--verbose_failures=true', '--config=opt', '--config=mkl_open_source_only', '--config=cuda', ':install_xla_in_source_tree', '/home/titan/resources/oss/machine-learning/Google/jax/build']' returned non-zero exit status 1.

I also tried to clean .cache/bazel, still the same error as above.

Thanks for raising this, and for looking into it so thoroughly! Sure looks like jaxlib's building process is broken.

I'm not very familiar with bazel, but this recent pr by @hawkinsp might have some clues. Presumably the build worked then...

7f9e1809bbd035b1998268cde68c1b9567c26a21 seems to be the issue. Hard reset to 60918077c285a787c697b694d8d7bb04da56a9e5 works for me.

It turned out I jumped the gun on the new Bazel version; we need to wait until the TF build supports it.
I reverted the required version back to 0.24.


Feature: Redesigning of Code Of Conduct Page

Description
I want to redesign the Code Of Conduct Page.

@sanjay-kv sir, u have merged my PR by adding label of level but the label of level is not showing there and also its points is not counted till now.
Please look into this


Round up in fee estimation

And add some fee estimation debug traces.
I decided to go back to U256 instead of f64 in some interfaces so that the rounding is an implementation detail that api users do not have to think about.
Test Plan
new unit test that highlights the issue

Codecov Report

Merging #1416 (a764d22) into main (b1afa07) will increase coverage by 0.05%.
The diff coverage is 98.80%.

@@            Coverage Diff             @@
##             main    #1416      +/-   ##
==========================================
+ Coverage   65.78%   65.84%   +0.05%
==========================================
  Files         154      154
  Lines       30284    30337      +53
==========================================
+ Hits        19921    19974      +53
  Misses      10363    10363


Add nbextensions support for Jupyter Notebooks

Feature: Notebook Editor, Interactive Window, Python Editor cells

Description
Would be great to have support for nbextensions since that would fully replace a notebooks instance.

Guessed at area path
Thanks for your feedback. This issue is addressed with new native support for editing notebooks starting with v1.59 of VS Code. However, VS Code's notebooks do not necessarily support the extensions known by nbextensions. Extensions that you find most useful may already exist for VS Code notebooks in their marketplace, or may simply already be supported with no extensions required.


Catch 22: SingleModel init checks suffix_to_model_mapping immediately after definition

I am trying to subclass SingleModel with another extension.
Before I call the SingleModel.__init__ there is suffix_to_model_mapping dict defined, so I cannot add the new extension. If I define it myself, the SingleModel.__init__ overrides it. If I do not create it, the super init executes __check_valid_suffix which fails because my extension is not registered.
Checkmate.

Hi Bastian, nice catch! Let's see how we can fix this. Do you already have a good solution in mind for this?
If it is a common format I would also be happy to add it to the suffix_to_model_mapping. We are trying to integrate numerblox processors and models more seamlessly with scikit-learn so happy to hear ideas.

One Idea I had was to have the init check if suffix_to_model_mapping is already present and update it if so

Good idea, happy to review a PR if you want to implement this and it passes tests. Also was thinking it would be solid to create a (_add_suffix) setter method so it's more straightforward to use custom suffixes and model loaders in the future.


Plugin not working with webpack require

Plugin is not working with webpack require or import.
After require $.fn.matchHeight not defined.
show-category.js:7 Uncaught TypeError: $(...).matchHeight is not a function

+1

I got around this by doing require('../../../node_modules/jquery-match-height/dist/jquery.matchHeight') 😬

FYI: This forked package works fine w/ webpack.
https://www.npmjs.com/package/jquery-match-height-browserify

I got this package working fine in my webpack setup with the following:
webpack.config.js:
const webpack = require('webpack')

module.exports = {
  externals: {
    'jquery': 'jQuery'
  },
  plugins: [
    new webpack.ProvidePlugin({
      $: 'jquery',
      jQuery: 'jquery',
      'window.jQuery': 'jquery'
    })
  ],
};

(Note that's just a fragment of my webpack setup, using it standalone wont work ⚠ )
app.js (where I wanted to include matchheight):
import 'jquery-match-height'

Hope it helps! 🙂

Awesome, this helped.

If what @breadadams says works, then maybe just this might also work in your webpack.config.js?
  externals: {
    'jquery': {
      commonjs: 'jquery',
      commonjs2: 'jquery',
      amd: 'jquery',
      root: 'jQuery'
    }
  }

Does anybody know if there's an easy change to the plugin that will mean this isn't needed?


Fix AbstractController::DoubleRenderError in ProviderUsersController

Context
find_provider_user was called directly in an action. We think this may have resulted in double rendering error as the action would not have halted at the first render. So we moved this method to a before filter.
If a "before" filter renders or redirects, the action will not run. If there are additional filters scheduled to run after that filter, they are also cancelled. https://guides.rubyonrails.org/action_controller_overview.html#filters
Changes proposed in this pull request
Make find_provider_user a before filter.
Guidance to review
The controller still works
Link to Trello card
https://trello.com/c/ibPX7YvE/2574-fix-abstractcontrollerdoublerendererror
Things to check

[ ] This code doesn't rely on migrations in the same Pull Request
[ ] If this code includes a migration adding or changing columns, it also backfills existing records for consistency
[ ] API release notes have been updated if necessary
[ ] New environment variables have been added to the Azure config

I couldn't find if rescue_from behaves like the before filter and stop rendering/redirecting.
I'll merge it as it is because I read that if a render or redirect is already in progress when the exception is raised, it's possible to get double render error from the rescue_from.


refactor sidecar/interface.rs into smaller files

What does this PR do?

Break up the various types and implementations in sidecar/interface.rs into separate files within a sidecar::service module. (I'm very open to a better name than "service").
Introduce some tests and some documentation. I only added some tests that didn't require much mocking or setup. APMSP-1079 has been created to track a more comprehensive unit testing solution.
Fixes some minor bugs uncovered through addition of tests.
Miscellaneous small fixes for typos, cleanup, and Rust idiomaticness.
As I am fairly new to the sidecar I made my best guesses at rustdoc comments, tests, and naming. Please call out any errors.

Motivation
Prep work for introducing retry logic sending traces via the sidecar
Additional Notes
This is a a fairly disruptive refactor. If there are non-critical things we can address in follow up PRs I would prefer to do that versus keeping this open for a long time. Obviously, any critical issues should be addressed ASAP.
How to test the change?
Unit tests are being added, but some sort of integration test with PHP is probably a good idea.
For Reviewers

[ ] If this PR touches code that signs or publishes builds or packages, or handles credentials of any kind, I've requested a review from @DataDog/security-design-and-guidance.
[x] This PR doesn't touch any of that.

Codecov Report
Attention: Patch coverage is 26.43541% with 615 lines in your changes are missing coverage. Please review.

:exclamation: No coverage uploaded for pull request base (main@ecc3759). Click here to learn what that means.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #395   +/-   ##
=======================================
  Coverage        ?   64.61%
=======================================
  Files           ?      176
  Lines           ?    22287
  Branches        ?        0
=======================================
  Hits            ?    14400
  Misses          ?     7887
  Partials        ?        0

Components
Coverage Δ

crashtracker
20.37% <0.00%> (?)

data-pipeline
51.45% <0.00%> (?)

data-pipeline-ffi
0.00% <0.00%> (?)

ddcommon
81.23% <0.00%> (?)

ddcommon-ffi
74.93% <0.00%> (?)

ddtelemetry
53.72% <0.00%> (?)

ipc
79.30% <0.00%> (?)

profiling
77.05% <0.00%> (?)

profiling-ffi
60.09% <0.00%> (?)

serverless
0.00% <0.00%> (?)

sidecar
25.89% <0.00%> (?)

sidecar-ffi
0.00% <0.00%> (?)

spawn-worker
50.49% <0.00%> (?)

trace-mini-agent
69.12% <0.00%> (?)

trace-normalization
97.79% <0.00%> (?)

trace-obfuscation
95.74% <0.00%> (?)

trace-protobuf
25.64% <0.00%> (?)

trace-utils
68.85% <0.00%> (?)

I’m a bit annoyed at big docblocks explaining obvious things. Like yes, obviously the fn add() of the Add trait impl on EnqueuedTelemetryStats will add two EnqueuedTelemetryStats together and return a new EnququedTelemetryStats instance which is the result of rhs and the instance. And this interrupts my reading flow with 10 lines of fat docblock.
There are a couple instances of such obvious docblocks, would you mind removing these? Thanks!

Is there a reason why you’ve aggressively put pub(crate) on everything instead of simply pub within the individual rust files?
Looks easier to read if it's just pub.
And I assume it’s enough to just make the modules then pub(crate) in the mod.rs files? What you’re anyway already doing.
Feels cleaner, and gives the ability to just toggle the visibility of a whole module from pub(crate) to pub when needed instead of touching every single codeline in that mod.

Is there a reason why you’ve aggressively put pub(crate) on everything instead of simply pub within the individual rust files?
Looks easier to read if it's just pub.

And I assume it’s enough to just make the modules then pub(crate) in the mod.rs files? What you’re anyway already doing.
Feels cleaner, and gives the ability to just toggle the visibility of a whole module from pub(crate) to pub when needed instead of touching every single codeline in that mod.

@bwoebi I did this for two reasons:

Consistency and safety (not rust "safety"). There are situations where we don't want to mark an entire file as pub(crate) but we do mix exposing certain functions, types, or struct members as either pub(crate) or just pub. In those cases we have no choice but to be verbose in the file. It seems awkward to me that sometimes we set pub(crate) on just the mod.rs level and sometimes we do it at the implementation. I also don't find it hard to read and I like knowing the access level with the implementation details. But if the consensus is that this is superfluous I can revert this in another PR.

It's related to reason 1, but I generally believe that we need to lock down the public surface area of the library as much as possible. We should only expose things publicly that we actually want public, and we're willing to support long-term and properly document. At the moment, I don't think we have any tools in place to help us not "leak" things we don't want public. Until we have something to do this for us (via static analysis or testing or something else) I'd prefer to err on the side of caution.

Your assumption is correct. Functionally, we don't need to be this verbose. If there is a general consensus against this, I can revert in a follow-up PR.


"Kernel died with exit code 1" fail in activating env (#5689 )

Hi community,
I got the error of "Kernel died with exit code 1" when executing codes on the interactive window. I see the similar issue #5689 reported, but it already closed and cannot reopen or comment. Sorry if it might be a duplicate
With thanks.
Environment data

VS Code version: 1.56.2
Jupyter Extension version (available under the Extensions sidebar): v2021.6
Python Extension version (available under the Extensions sidebar): v2021.5
OS (Windows | Mac | Linux distro) and version: Win10
Python and/or Anaconda version: 3.5.5/1.7.2
Type of virtual environment used (N/A | venv | virtualenv | conda | ...): conda
Jupyter server running: Local | Remote | Local

Expected behaviour
I would expect the env is right activated that enable me executing my jupyter lines of code
Actual behaviour
Kernel died with exit code 1. Traceback (most recent call last):
File "c:\Users\username.vscode\extensions\ms-toolsai.jupyter-2021.6.832593372\pythonFiles\vscode_datascience_helpers..\pyvsc-run-isolated.py", line 30, in  runpy.run_path(module, run_name="main") File "C:\Users\username\anaconda3\envs\env_name\lib\runpy.py", line 263, in run_path pkg_name=pkg_name, script_name=fname) File "C:\Users\username\anaconda3\envs\env_name\lib\runpy.py", line 96, in _run_module_code mod_name, mod_spec, pkg_name, script_name) File "C:\Users\username\anaconda3\envs\env_name\lib\runpy.py", line 85, in _run_code exec(code, run_globals) File "c:\Users\username.vscode\extensions\ms-toolsai.jupyter-2021.6.832593372\pythonFiles\vscode_datascience_helpers\kernel_prewarm_starter.py", line 31, in  runpy.run_module(module, run_name="main", alter_sys=False) File "C:\Users\username\anaconda3\envs\env_name\lib\runpy.py", line 208, in run_module retur...

@BinhKieu82 I'm sorry for not getting back to you, somehow I missed this issue.
We've been working on the code that starts kernels, and have removed the code pyvsc-run-isolated.py... hopefully that will resolve the issues.
Please could you install the latest insiders version of VS Code and then install Jupyter extension and let us know if this has been resolved.
Thanks

Hi DonJayamanne,
Here are my VScode info, it is the latest version with Jupyter extension version of v2021.6.832593372

Version: 1.56.2 (user setup)
Commit: 054a9295330880ed74ceaedda236253b4f39a335
Date: 2021-05-12T17:13:13.157Z
Electron: 12.0.4
Chrome: 89.0.4389.114
Node.js: 14.16.0
V8: <IP_ADDRESS>-electron.0
OS: Windows_NT x64 10.0.18362

I still got the similar outcome, it seems encountering the same issue:
Kernel died with exit code 1. Traceback (most recent call last):
  File "c:\Users\user_name\.vscode\extensions\ms-toolsai.jupyter-2021.6.832593372\pythonFiles\vscode_datascience_helpers\..\pyvsc-run-isolated.py", line 30, in <module>
    runpy.run_path(module, run_name="__main__")
  File "C:\Users\user_name\anaconda3\envs\env_name\lib\runpy.py", line 263, in run_path
    pkg_name=pkg_name, script_name=fname)
  File "C:\Users\user_name\anaconda3\envs\env_name\lib\runpy.py", line 96, in _run_module_code
    mod_name, mod_spec, pkg_name, script_name)
  File "C:\Users\user_name\anaconda3\envs\env_name\lib\runpy.py", line 85, in _run_code
    exec(code, run_globals)
  File "c:\Users\user_name\.vscode\extensions\ms-toolsai.jupyter-2021.6.832593372\pythonFiles\vscode_datascience_helpers\kernel_prewarm_starter.py", line 31, in <module>
    runpy.run_module(module, run_name="__main__", alter_sys=False)
  File "C:\Users\user_name\anaconda3\envs\env_name\lib\runpy.py", line 208, in run_module
    return _run_code(code, {}, init_globals, run_name, mod_spec)
  File "C:\Users\user_name\anaconda3\envs\env_name\lib\runpy.py", line 85, in _run_code
    exec(code, run_globals)
  File "C:\Users\user_name\anaconda3\envs\env_name\lib\site-packages\ipykernel_launcher.py", line 16, in <module>
    app.launch_new_instance()
  File "C:\Users\user_name\anaconda3\envs\env_name\lib\site-packages\traitlets\config\application.py", line 657, in launch_instance
    app.initialize(argv)
  File "C:\Users\user_name\anaconda3\envs\env_name\lib\site-packages\decorator.py", line 232, in fun
    return caller(func, *(extras + args), **kw)
  File "C:\Users\user_name\anaconda3\envs\env_name\lib\site-packages\traitlets\config\application.py", line 87, in catch_config_error
    return method(app, *args, **kwargs)
  File "C:\Users\user_name\anaconda3\envs\env_name\lib\site-packages\ipykernel\kernelapp.py", line 472, in initialize
    self.write_connection_file()
  File "C:\Users\user_name\anaconda3\envs\env_name\lib\site-packages\ipykernel\kernelapp.py", line 200, in write_connection_file
    iopub_port=self.iopub_port, control_port=self.control_port)
  File "C:\Users\user_name\anaconda3\envs\env_name\lib\site-packages\jupyter_client\connect.py", line 212, in write_connection_file
    with secure_write(fname) as f:
  File "C:\Users\user_name\anaconda3\envs\env_name\lib\contextlib.py", line 59, in __enter__
    return next(self.gen)
  File "C:\Users\user_name\anaconda3\envs\env_name\lib\site-packages\jupyter_client\connect.py", line 102, in secure_write
    with os.fdopen(os.open(fname, open_flag, 0o600), mode) as f:
PermissionError: [Errno 13] Permission denied: 'C:\\Users\\user_name\\AppData\\Local\\Temp\\tmp-92041JghRKurSHL4.json'

I've thought it's because of using python 3.5.5 but event with higher python version (3.6), switching between envs still encounter problems like this Error: Direct kernel connection broken
Kindly advise the solution, it stop me from working so long.
With thanks - Binh Kieu

@BinhKieu82 For some reason u don't have the right version. Please could you install the latest insiders version of the extension once again & try this out.

@DonJayamanne
What i have done so far:
installed VScode insider version:

Version: 1.57.0-insider (user setup)
Commit: fe1eafc80c07608de52a2f9c99fee103dea77f5e
Date: 2021-06-04T12:21:40.077Z
Electron: 12.0.9
Chrome: 89.0.4389.128
Node.js: 14.16.0
V8: <IP_ADDRESS>-electron.0
OS: Windows_NT x64 10.0.18362

install Jupyter extension version: v2021.6.905800020
installed python extension version: v2021.6.908196464-dev
But still not able to switch to env with python 3.5.5, the error message seems the same:

Kernel died with exit code 1. Traceback (most recent call last):
File "C:\Users\user_name\anaconda3\envs\env-p35\lib\runpy.py", line 193, in _run_module_as_main
"main", mod_spec)
File "C:\Users\user_name\anaconda3\envs\env-p35\lib\runpy.py", line 85, in _run_code
exec(code, run_globals)
File "C:\Users\user_name\anaconda3\envs\env-p35\lib\site-packages\ipykernel_launcher.py", line 16, in
app.launch_new_instance()
File "C:\Users\user_name\anaconda3\envs\env-p35\lib\site-packages\traitlets\config\application.py", line 657, in launch_instance
app.initialize(argv)
File "C:\Users\user_name\anaconda3\envs\env-p35\lib\site-packages\decorator.py", line 232, in fun
return caller(func, *(extras + args), **kw)
File "C:\Users\user_name\anaconda3\envs\env-p35\lib\site-packages\traitlets\config\application.py", line 87, in catch_config_error
return method(app, *args, **kwargs)
File "C:\Users\user_name\anaconda3\envs\env-p35\lib\site-packages\ipykernel\kernelapp.py", line 472, in initialize
self.write_connection_file()
File "C:\Users\user_name\anaconda3\envs\env-p35\lib\site-packages\ipykernel\kernelapp.py", line 200, in write_connection_file
iopub_port=self.iopub_port, control_port=self.control_port)
File "C:\Users\user_name\anaconda3\envs\env-p35\lib\site-packages\jupyter_client\connect.py", line 212, in write_connection_file
with secure_write(fname) as f:
File "C:\Users\user_name\anaconda3\envs\env-p35\lib\contextlib.py", line 59, in enter
return next(self.gen)
File "C:\Users\user_name\anaconda3\envs\env-p35\lib\site-packages\jupyter_client\connect.py", line 100, in secure_write
win32_restrict_file_to_user(fname)
File "C:\Users\user_name\anaconda3\envs\env-p35\lib\site-packages\jupyter_client\connect.py", line 53, in win32_restrict_file_to_user
import win32api
ImportError: No module named 'win32api'

I also updated the latest version of VScode, jupyter & python extensions on VSCode official platform, but still not able to switch to env with python 3.5.5
Kindly share your thought.
Regards - Binh Kieu

Please try running the following against your Conda environment after activating it
conda install ipykernel -U --force-reinstall

I already installed ipykernel before, however, after running your command, the error came as:

SafetyError: The package for ipykernel located at C:\Users\username\anaconda3\pkgs\ipykernel-4.10.0-py35_1
appears to be corrupted. The path 'Scripts/jupyter-kernel-script.py'
has an incorrect size.

Here is the ipykernel installed: ipykernel                 4.10.0                   py35_1    conda-forge
conda version is 4.8.4. I tried to upgrade to the latest 4.10.1 but no success.
The final outcome still the same, not able to switch to the env with python 3.5 in VScode.
BTW, i don't want to use VScode insider, then I've tried both conda install ipykernel --update-deps --force-reinstall and conda install ipykernel --update-all --force-reinstall  on VScode

Hmm, at this stage not sure what I can do.
Please could you try running Jupyter in that environment. Basically your python environment doesn't seem to be setup propertly for Jupyter Kernels.
Please could you confirm it works with classic Jupyter.
Else I'd suggest trying to create a new environment.

Hi, it seems envs switching work normal now. I don't know what exactly has been happened, but you can close this ticket.
Thank you for your great effort!


Auto update issues

Make it so issues auto update and you dont have to do it manually all the time when someone else closes them

I've now added a function that checks for updates every time the codeblock os rendered


Yikes! KeeperErrorCode = Unimplemented for /kafka-manager/mutex Try again.

hi,how to fix it？

I had the same error. When I replaced the config files with the old ones from version <IP_ADDRESS> everything worked again.

I had the same error. When I replaced the config files with the old <IP_ADDRESS> config files everything worked again. Maybe something is broken with the new "KMScheduleLeaderElectionFeature"?!

I can confirm removing KMScheduleLeaderElectionFeature from application.features fixed this for us on CMAK <IP_ADDRESS> (from latest master) and Kafka 2.4.0

I can confirm removing KMScheduleLeaderElectionFeature from application.features did not fix this for us on CMAK <IP_ADDRESS> (from latest master) and Kafka 2.4.0

We are running CMAK <IP_ADDRESS> (docker image hlebalbau/kafka-manager) and Kafka 2.0.1 (docker image wurstmeister/kafka). I replaced both "application.conf" and "routes" with the old config and no more errors.

Updating our Zookeeper version from 3.4.14 to 3.5.7 fixed this for us

@jamie-34254 how to update zookeeper version or how to replace config file with old one?

I had the same error. When I replaced the config files with the old <IP_ADDRESS> config files everything worked again. Maybe something is broken with the new "KMScheduleLeaderElectionFeature"?!

how to do that?

I can confirm removing KMScheduleLeaderElectionFeature from application.features did not fix this for us on CMAK <IP_ADDRESS> (from latest master) and Kafka 2.4.0

We are running CMAK <IP_ADDRESS> (docker image hlebalbau/kafka-manager) and Kafka 2.0.1 (docker image wurstmeister/kafka). I replaced both "application.conf" and "routes" with the old config and no more errors.

from where you found old config file

I have the same issue, and seems like it's related with unsupported zookeeper version. Since latest CMAK use Apache Curator 2.12.0 and it supported zookeeper 3.5.x version by default, and 3.4.x only with modifications in build.
It will be nice to add Zookeeper requirements in README.

Patch for anyone who wants it
diff --git a/build.sbt b/build.sbt
index 9ac7221..27528fc 100644
--- a/build.sbt
+++ b/build.sbt
@@ -33,21 +33,22 @@ libraryDependencies ++= Seq(
   "org.webjars" % "underscorejs" % "1.9.0",
   "org.webjars" % "dustjs-linkedin" % "2.7.2",
   "org.webjars" % "octicons" % "4.3.0",
-  "org.apache.curator" % "curator-framework" % "2.12.0" exclude("log4j","log4j") exclude("org.slf4j", "slf4j-log4j12") force(),
+  "org.apache.curator" % "curator-framework" % "2.12.0" exclude("org.apache.zookeeper","zookeeper") exclude("log4j","log4j") exclude("org.slf4j", "slf4j-log4j12") force(),
   "org.apache.curator" % "curator-recipes" % "2.12.0" exclude("log4j","log4j") exclude("org.slf4j", "slf4j-log4j12") force(),
+  "org.apache.zookeeper" % "zookeeper" % "3.4.14",
   "org.json4s" %% "json4s-jackson" % "3.6.5",
   "org.json4s" %% "json4s-scalaz" % "3.6.5",
   "org.slf4j" % "log4j-over-slf4j" % "1.7.25",
   "com.adrianhurt" %% "play-bootstrap" % "1.4-P26-B4" exclude("com.typesafe.play", "*"),
   "org.clapper" %% "grizzled-slf4j" % "1.3.3",
-  "org.apache.kafka" %% "kafka" % "2.4.0" exclude("log4j","log4j") exclude("org.slf4j", "slf4j-log4j12") force(),
+  "org.apache.kafka" %% "kafka" % "2.4.0" exclude("org.apache.zookeeper","zookeeper") exclude("log4j","log4j") exclude("org.slf4j", "slf4j-log4j12") force(),
   "org.apache.kafka" % "kafka-streams" % "2.2.0",
   "com.beachape" %% "enumeratum" % "1.5.13",
   "com.github.ben-manes.caffeine" % "caffeine" % "2.6.2",
   "com.typesafe.play" %% "play-logback" % "2.6.21",
   "org.scalatest" %% "scalatest" % "3.0.5" % "test",
   "org.scalatestplus.play" %% "scalatestplus-play" % "3.1.2" % "test",
-  "org.apache.curator" % "curator-test" % "2.12.0" % "test",
+  "org.apache.curator" % "curator-test" % "2.12.0" % "test" exclude("org.apache.zookeeper","zookeeper") force(),
   "org.mockito" % "mockito-core" % "1.10.19" % "test",
   "com.yammer.metrics" % "metrics-core" % "2.2.0" force(),
   "com.unboundid" % "unboundid-ldapsdk" % "4.0.9"

I have the same problem. I have installed zookeeper and kafka with docker images.
with  zookeeper v3.5.8 I get KeeperErrorCode = Unimplemented for /kafka-manager/mutex when I try to create a cluster.
Any help would be appreciated.

create /kafka-manager/mutex/locks and /kafka-manager/mutex/leases to fixed this, like this:
https://github.com/yahoo/CMAK/issues/731#issuecomment-643880544

Patch for anyone who wants it
diff --git a/build.sbt b/build.sbt
index 9ac7221..27528fc 100644
--- a/build.sbt
+++ b/build.sbt
@@ -33,21 +33,22 @@ libraryDependencies ++= Seq(
   "org.webjars" % "underscorejs" % "1.9.0",
   "org.webjars" % "dustjs-linkedin" % "2.7.2",
   "org.webjars" % "octicons" % "4.3.0",
-  "org.apache.curator" % "curator-framework" % "2.12.0" exclude("log4j","log4j") exclude("org.slf4j", "slf4j-log4j12") force(),
+  "org.apache.curator" % "curator-framework" % "2.12.0" exclude("org.apache.zookeeper","zookeeper") exclude("log4j","log4j") exclude("org.slf4j", "slf4j-log4j12") force(),
   "org.apache.curator" % "curator-recipes" % "2.12.0" exclude("log4j","log4j") exclude("org.slf4j", "slf4j-log4j12") force(),
+  "org.apache.zookeeper" % "zookeeper" % "3.4.14",
   "org.json4s" %% "json4s-jackson" % "3.6.5",
   "org.json4s" %% "json4s-scalaz" % "3.6.5",
   "org.slf4j" % "log4j-over-slf4j" % "1.7.25",
   "com.adrianhurt" %% "play-bootstrap" % "1.4-P26-B4" exclude("com.typesafe.play", "*"),
   "org.clapper" %% "grizzled-slf4j" % "1.3.3",
-  "org.apache.kafka" %% "kafka" % "2.4.0" exclude("log4j","log4j") exclude("org.slf4j", "slf4j-log4j12") force(),
+  "org.apache.kafka" %% "kafka" % "2.4.0" exclude("org.apache.zookeeper","zookeeper") exclude("log4j","log4j") exclude("org.slf4j", "slf4j-log4j12") force(),
   "org.apache.kafka" % "kafka-streams" % "2.2.0",
   "com.beachape" %% "enumeratum" % "1.5.13",
   "com.github.ben-manes.caffeine" % "caffeine" % "2.6.2",
   "com.typesafe.play" %% "play-logback" % "2.6.21",
   "org.scalatest" %% "scalatest" % "3.0.5" % "test",
   "org.scalatestplus.play" %% "scalatestplus-play" % "3.1.2" % "test",
-  "org.apache.curator" % "curator-test" % "2.12.0" % "test",
+  "org.apache.curator" % "curator-test" % "2.12.0" % "test" exclude("org.apache.zookeeper","zookeeper") force(),
   "org.mockito" % "mockito-core" % "1.10.19" % "test",
   "com.yammer.metrics" % "metrics-core" % "2.2.0" force(),
   "com.unboundid" % "unboundid-ldapsdk" % "4.0.9"

it works! thanks a lot

Patch for anyone who wants it
diff --git a/build.sbt b/build.sbt
index 9ac7221..27528fc 100644
--- a/build.sbt
+++ b/build.sbt
@@ -33,21 +33,22 @@ libraryDependencies ++= Seq(
   "org.webjars" % "underscorejs" % "1.9.0",
   "org.webjars" % "dustjs-linkedin" % "2.7.2",
   "org.webjars" % "octicons" % "4.3.0",
-  "org.apache.curator" % "curator-framework" % "2.12.0" exclude("log4j","log4j") exclude("org.slf4j", "slf4j-log4j12") force(),
+  "org.apache.curator" % "curator-framework" % "2.12.0" exclude("org.apache.zookeeper","zookeeper") exclude("log4j","log4j") exclude("org.slf4j", "slf4j-log4j12") force(),
   "org.apache.curator" % "curator-recipes" % "2.12.0" exclude("log4j","log4j") exclude("org.slf4j", "slf4j-log4j12") force(),
+  "org.apache.zookeeper" % "zookeeper" % "3.4.14",
   "org.json4s" %% "json4s-jackson" % "3.6.5",
   "org.json4s" %% "json4s-scalaz" % "3.6.5",
   "org.slf4j" % "log4j-over-slf4j" % "1.7.25",
   "com.adrianhurt" %% "play-bootstrap" % "1.4-P26-B4" exclude("com.typesafe.play", "*"),
   "org.clapper" %% "grizzled-slf4j" % "1.3.3",
-  "org.apache.kafka" %% "kafka" % "2.4.0" exclude("log4j","log4j") exclude("org.slf4j", "slf4j-log4j12") force(),
+  "org.apache.kafka" %% "kafka" % "2.4.0" exclude("org.apache.zookeeper","zookeeper") exclude("log4j","log4j") exclude("org.slf4j", "slf4j-log4j12") force(),
   "org.apache.kafka" % "kafka-streams" % "2.2.0",
   "com.beachape" %% "enumeratum" % "1.5.13",
   "com.github.ben-manes.caffeine" % "caffeine" % "2.6.2",
   "com.typesafe.play" %% "play-logback" % "2.6.21",
   "org.scalatest" %% "scalatest" % "3.0.5" % "test",
   "org.scalatestplus.play" %% "scalatestplus-play" % "3.1.2" % "test",
-  "org.apache.curator" % "curator-test" % "2.12.0" % "test",
+  "org.apache.curator" % "curator-test" % "2.12.0" % "test" exclude("org.apache.zookeeper","zookeeper") force(),
   "org.mockito" % "mockito-core" % "1.10.19" % "test",
   "com.yammer.metrics" % "metrics-core" % "2.2.0" force(),
   "com.unboundid" % "unboundid-ldapsdk" % "4.0.9"

It works, but maybe need some attention to "org.apache.zookeeper" % "zookeeper" % "3.4.14",,3.4.14 refering your zk version maybe? I modify my zk version 3.4.10 instead, and recompile it. Thanks a lot!

create /kafka-manager/mutex/locks and /kafka-manager/mutex/leases to fixed this, like this:
#731 (comment)

works for me . thank you

org.apache.zookeeper.KeeperException$UnimplementedException: KeeperErrorCode = Unimplemented for /debug
I am facing the same issue. Above resolutions shows that we are forcing zookeeper version 3.4.14 to be used. But my requirement is to use zookeeper version 3.5.7 with curator-framework version 2.12.0 or latest.
Any help would be appreciated.
ERROR org.apache.curator.framework.imps.CuratorFrameworkImpl - Ensure path threw exception org.apache.zookeeper.KeeperException$UnimplementedException: KeeperErrorCode = Unimplemented for /debug 	at org.apache.zookeeper.KeeperException.create(KeeperException.java:106) [CCB-globalCronExecutor-3-SendThread(zookeeper:2181)] INFO org.apache.zookeeper.ClientCnxn - Unable to read additional data from server sessionid 0x17fb5659c8f0056, likely server has closed socket, closing socket connection and attempting reconnect 	at org.apache.zookeeper.KeeperException.create(KeeperException.java:54) 	at org.apache.zookeeper.ZooKeeper.create(ZooKeeper.java:1538) 	at org.apache.curator.utils.ZKPaths.mkdirs(ZKPaths.java:291) 	at org.apache.curator.framework.imps.NamespaceImpl$1.call(NamespaceImpl.java:90) 	at org.apache.curator.RetryLoop.callWithRetry(RetryLoop.java:109) 	at org.apache.curator.framework.imps.NamespaceImpl.fixForNamespace(NamespaceImpl.java:83) 	at org.apache.curator.framework.imps.CuratorFrameworkImpl.fixForNamespace(CuratorFrameworkImpl.java:594) 	at org.apache.curator.framework.imps.ExistsBuilderImpl.forPath(ExistsBuilderImpl.java:158) 	at org.apache.curator.framework.imps.ExistsBuilderImpl.forPath(ExistsBuilderImpl.java:32) 	at com.santaba.server.util.cloud.Register2CloudZKTask._CreateDiagPathInZookeeper(Register2CloudZKTask.java:160) 	at com.santaba.server.util.cloud.Register2CloudZKTask._run(Register2CloudZKTask.java:177) 	at com.santaba.server.cron.Cron.run(Cron.java:72) 	at java.base/java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:515) 	at java.base/java.util.concurrent.FutureTask.runAndReset(FutureTask.java:305) 	at java.base/java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:305) 	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128) 	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628) 	at java.base/java.lang.Thread.run(Thread.java:834) [CCB-globalCronExecutor-3-EventThread] INFO org.apache.curator.framework.state.ConnectionStateManager - State change: SUSPENDED [2022-03-23 06:44:02.013 UTC] [MSG] [WARN] [CCB-globalCronExecutor-3:santaba:cron:] [Register2CloudZKTask._CreateDiagPathInZookeeper:163] something wrong when create the path of diagnosis, CONTEXT=connectString=zookeeper:2181, rootPath=debug, errMsg=KeeperErrorCode = ConnectionLoss for /debug

这是来自QQ邮箱的自动回复邮件。

您好，我已经收到你的邮件

这是来自QQ邮箱的自动回复邮件。

您好，我已经收到你的邮件


Add user preference "display node numbers"

Node numbers in the node tree view take up vertical space. Users may want to disable node numbers in certain scenarios, e.g.

On a smaller iPhone which does not have much screen space in general
On any device held in landscape where vertical space is scarce
Or simply because they don't see much value in node numbers

Consider adding a user preference that lets the user decide whether or not to display node numbers.
As usual, the reason for not adding such a user preference is that too many user preferences can make an app confusing.

NodeTreeViewModel already has a boolean property displayNodeNumbers. Implementing this feature would therefore likely consist of

Exposing the property as a user preference.
Making sure that the node tree is redrawn appropriately when the user preference is changed.


[CARBONDATA-4268][Doc][summer-2021] Add new dev mailing list (website) link and update the Nabble address.

Why is this PR needed?

The Nabble updated their service, so did the address of  our mailing list website.
Add new link of<EMAIL_ADDRESS>(https://lists.apache.org/list.html?dev@carbondata.apache.org), which is based on Pony Mail!.

What changes were proposed in this PR?
Does this PR introduce any user interface change?

No

Is any new testcase added?

No

JIRA Issue: https://issues.apache.org/jira/browse/CARBONDATA-4268

Build Success with Spark 2.4.5, Please check CI http://<IP_ADDRESS>:12602/job/ApacheCarbon_PR_Builder_2.4.5/4072/

Build Success with Spark 2.3.4, Please check CI http://<IP_ADDRESS>:12602/job/ApacheCarbonPRBuilder2.3/5816/

Build Success with Spark 3.1, Please check CI http://<IP_ADDRESS>:12602/job/ApacheCarbon_PR_Builder_3.1/219/

LGTM


Better CMakeLists.txt

Use modern cmake and avoid deprecated commands
Keep it Simple
Add support for Visual Studio Project
Make installation of the header files possible on Windows OS

NOTICE: Be sure to reconfigure the CI as well if you make any incompatible changes.

I would like to help with it except Windows-related work. I have no idea about Windows.

@light2yellow Yup. Go for it :) The library is header only anyways so windows users can just include the header files.

Another thing I would like to mention is if possible, remove the catch.hpp from the tests and download it automatically from its github repository before building the tests.

Another thing I would like to mention is if possible, remove the catch.hpp from the tests and download it automatically from its github repository before building the tests.

Oh, I completely forgot about it. I'll try to address it though.

@light2yellow If you can turn off building the doxygen documentation from the Dockerfile because I haven't found a way to install doxygen and graphviz into the docker image as well.

I'll try experimenting with CircleCI and Dockerfile on my fork and see if I can accomplish it (if not, I'll remove it).

I think the docker file should be modified like this
FROM quay.io/jlospinoso/cppbuild:v1.0.0

RUN mkdir forest
WORKDIR forest
COPY / ./
RUN mkdir build
WORKDIR build
RUN apt install -y doxygen
RUN apt install -y graphviz
RUN cmake -DFOREST_BUILD_EXAMPLES=ON -DFOREST_ENABLE_TESTING=ON -DFOREST_BUILD_DOCUMENTATION=ON ..
RUN make examples
RUN make check
RUN make doc

I don't have time to verify the validity of this right now because I am busy studying at the university this week.


Provide styled as a named export

Currently styled is only available as the default export: https://github.com/styled-components/styled-components/blob/master/packages/styled-components/src/index.js#L5
In transpiled/commonJS environments that works as expected, but breaks server-side ESM usage of styled components.
NodeJS does not support CommonJS modules have both a default and a named export: https://nodejs.org/api/esm.html#esm_import_statements
So for styled components to work server side instead of:
import styled from 'styled-components';

We must write:
import styledWrapper from 'styled-components';
styled = styledWrapper.default;

Which is confusing, and not a viable option for code that should run in both browser and server.
Adding styled as a named export allows environment agnostic access:
import { styled } from 'styled-components';

Happy to open a PR, should be a one liner.
But wanted to explain reasoning as well

We already have an ESM build so I don't see why the solution would be to provide a redundant export rather than to add the "exports" field to the package.json 🤔

The exports field IMHO is great for things like restricting what files can be imported, and changing behavior based on node/browser environments.
While it does support ESM vs CJS importing, that would actually break things further (in my case).
My use case is I use styled components in a NextJS environment. NextJS uses CJS internally, so there is nothing I can do to force them to import ESM version. My code however is pure ESM (I have a custom Webpack which stops NextJS from its usual CJS transpiling), which would result in an ESM import.
That would mean two different versions of styled-components would get imported into every project, with all the headaches that come along with that.
Being able to always import the CJS version is the best way to ensure I only get one version of styled-components, but then run into the issue described in this ticket

This is also a problem when trying to import /native

@JacobLey I think you misunderstood me, sorry for the confusion. Default exports are a thing. Next.js uses Webpack and does enable support of ESM, so I'm not sure what's going on here. However, adding a redundant export won't resolve the underlying issue you're probably experiencing here. But without details of the underlying issue, I can't really pin down what's going on here.
So, in other words, given that I don't think it makes sense to do this, and without another course of action, I'll have to close this, sorry!

Next.js does not use ESM. It uses webpack to transform ESM compliant code into CJS. Which is nice if you go all in on NextJS + CJS, but that is not my case. I want to continue using actual ESM where possible.
The final (transpiled and simplified) code for styled-components looks something like:
'use strict';
exports._esModule = true;
const css = () => {...};
const styled = () => {...};
exports.css = css;
exports.default = styled;

CJS does not actually have a concept of a "default" export. It simply flags the module as _esModule compatible, and libraries like Webpack synthetically detect that the CJS code can be used as if ESM.
If you look in a transpiled module, you will see import styled from 'styled-compnents' replaced by something like:
function _interopRequireDefault(obj) { return obj && obj.__esModule ? obj : { default: obj }; }
const { default: styled } = _interopRequireDefault(require("styled-components"));

This is the kind of code bundlers like Webpack inject into your code in order to simulate ESM support.
When I access styled-components from an ESM module (that is actually running ESM, not webpack transpiled CJS) that styled variable is now the entire exported module, not the specific styled method. Running into the issue described in this issue.
Because of the way NodeJS imports work https://nodejs.org/api/esm.html#esm_import_statements named exports are actually fully supported between CJS and ESM (assuming the CJS package is properly transpiled with exports._esModule = true). Hence adding styled to named exports would be a quick and easy way to resolve this issue.
Perhaps a better way for you to understand is try it yourself.
Create a directory with package.json:
{ "type": "module" }

Then a file styled-fail.js with content:
import styled from 'styled-components';

export const foo = styled.div`
   display: block;
`;

And a file styled-success.js with content:
import styled from 'styled-components';

export const foo = styled.default.div`
   display: block;
`;

In your repl, run the commands:
import('./styled-fail.js').catch(console.log); // Will print error message saying `div is not a function`
import('./styled-success.js').then(console.log); // Will print module with `foo` export

So summary:

My code is written and executed as ESM
styled-components is written as ESM but executed as CJS
An ESM-executable version exists, but it is tricky to force all consumers of styled-components to use same exact module (different imports in same environment is anti-pattern)
named exports is fully supported in all of CJS->ESM, CJS->CJS, and ESM->ESM import
default exports is only supported in ESM->ESM import. Libraries like Webpack simulate this functionality for CJS->CJS import.
In order to fully support CJS->ESM, do not do anti-pattern of default exports OR conditional exports. Rather add method as named export.

I would like to see this issue re-opened because the problem still exists. It sounds like there is confusion about what is natively supported by ESM+NodeJS, and what requires a transpiler like Webpack

it's not possible to currently convert any libraries to be ESM-native modules, with all that's involved however, if they use React, which isn't ESM-native. You can try that yourself, but I also maintain urql which explicitly can't use native-ESM on its React bindings package because of this.

I am not trying to make the styled-components library an ESM-native module. I am totally fine with it using CJS for maximum compatibility.
However the way it mixes named and default exports makes it incompatible with ESM native packages.
I am not sure I follow why React is a blocker to being ESM native? A package can use ESM while simultaneously using CJS packages (that is by design, so all CJS->ESM is backwards compatible, it is the opposite ESM->CJS that is not possible without the async import() command). And thanks to the JSX transform React avoids any default import problems described in this issue.
I personally use server-side React to render email templates in an ESM environment and it works just fine.

Current temporary workaround is to create own styled-components file exporting styled in a good way:
import styled from 'styled-components';

export * from 'styled-components';

const defaultStyled = typeof styled === 'function' ? styled : styled.default;

export { defaultStyled as default };

Then you either:

change imports from import styled from 'styled-components' to import styled, { css } from './my-styled-components'
or if you don't use webpack externals for styled-components just use alias to make it tansparent for other devs, without changing imports

Thank you Karol-f for that great workaround, but Stylerd Components maintainers ... why are you fighting so hard against this?  You're literally making life more difficult for a number of engineers all to avoid ... what?  One extra export line?

@karol-f thank you so much. Your approach resolved the issue I was having trying to bundle styled-components into an npm module.
This issue really should be resolved, or at the very least @karol-f's comment should be in the main FAQ.

It's 2023 now. Native ES module is more popular. Shall we reopen it?

It supported in v6.0.0-beta.7

Still it would be nice to have this backported.

Hi guys, I'm using Version 6.0.7, and I still encounter this issue, I'm wondering if there's additional configuration needed for this to make it work.
Thank you in advance

i'm experiencing the same issue. i've got a components library that uses styled-components which I bundle using vite into CJS. the components library then gets imported into an external Next JS app. my bundled components library code looks like this:
R=require("styled-components")
R.div.withConfig(...)

I get an error (Type Error: Cannot read property 'withConfig' of undefined) from that second line because div is inside of a default key. i appreciate the workaround above but is there any official response/suggestion from the styled-components maintainers? I'd really rather not add cruft/confusion into my org to accommodate this issue.


No keep audio option? (Target resault: video+audio file, audio only file)

At the moment, the "--keep-video" option saves both the video and audio files after they've been merged.
I would like the ability to save just the audio file with the merged file, producing the followings files:
Video+Audio (Merged) file
Audio file
Or am I blind and have missed the option somewhere?

Sorry, completely forgot I'd asked this here already.


feature: pre-commit hooks

As per discussion in #2226

This one is ready to go.

What is the difference between this husky release candidate and the last stable one?

In the RC version, you define hooks in the separate husky object. In previous stable version hooks were part of scripts. Not sure if there are any other improvements like performance etc but this is what they recommend to install now.
Here is the full changelog.

Thanks!

@byzyk If you have time, please add lint-staged too. We are losing time checking for files that shouldn't be linted, for example, bash scripts.

@montogeek sure man! will pick it up at the earliest, shouldn't take much time


High order types

Coverage decreased (-0.0005%) to 99.945% when pulling c47c8ccbee095d1376793fb0f8eab4fdb8ed305d on high-order into 1ec9ec45840efcb4a5b437a312c933dd684aa804 on master.


Disable actor isolation inference from property wrapper usage

Forum pitch here

Hi @bjhomer! I'll be the review manager for this. Are you around to answer questions on the review thread if I kick it off tomorrow through June 29th?

@hborla I should generally be available for that period, yes. Thanks!


Disconnect hang <IP_ADDRESS>

With the current nuget package the logic hangs on disconnect.
I have attached 2 test clients for this (WinForm, WPF)
Test.SuperSimpleTcp.zip

The originator of the error is from my point of view this call
https://github.com/jchristn/SuperSimpleTcp/blob/1e92103d7c5051f9e4308cddd932cd6d67cad360/SuperSimpleTcp/SimpleTcpClient.cs#L445
Also, the Register() should be before the while loop which was also wrong in my example.
https://github.com/jchristn/SuperSimpleTcp/blob/1e92103d7c5051f9e4308cddd932cd6d67cad360/SuperSimpleTcp/SimpleTcpClient.cs#L640

Hi @tinohager the reason for the .Wait() is to ensure the DataReceiver exits before allowing Disconnect to finish.  My concern is that (and this was happening to another user that filed a bug on it) the user can't immediately call Connect after calling Disconnect because the cancellation had not completed.
Adding the .Register change now!

Like this, correct?

I have now tested again with my own implementation. From my point of view the register must be executed at the initialize of the CancellationToken. A one-time registration should be enough as long as the CancellationToken is not triggered.
token.Register(() =>
{
	if (this._stream == null)
	{
		return;
	}

	this._stream.Close();
});

Just published v<IP_ADDRESS> to NuGet: https://www.nuget.org/packages/SuperSimpleTcp/<IP_ADDRESS>
Commit: https://github.com/jchristn/SuperSimpleTcp/commit/c54bb6433e701f25e53dbb166f903912071556b0
I tested on .NET 4.6.1, .NET 4.8, .NET Core 3.1, .NET 5.0, and .NET 6.0.  Everything seems to be working as it should.  Please re-open if you encounter this issue again!  Thanks again @tinohager for all of your help!

I'm having the same issue with the hanging on disconnect.  I'm using a test socket utility called Hercules since I don't have direct access to the PLC automation controller we use at our facility all the time.  Once the connection is established, I send some data back and forth which works well.  Then calling the Disconnect() method on SimpleTcpClient waits seemingly forever.  Even killing the connection on the socket side of the test utility makes no difference.


Add up-to-date screenshots

Another probably small issue 😉
Now that the extension's name has been updated, it'd be nice if there'd be at least one (or more) up-to-date screenshots of SAML-tracer at the Firefox Addons Page. Currently there's a really old screenshot. If I were new to SAML-tracer and I'd start it for the first time, I'd be surprised that the actual extension looked significantly other than shown on the screenshot.
Unfortunately I've no access to IDPs/SPs which I could use for demonstration screenshots. From the old screenshot I noticed that there's a test-SP at Feide (https://sp-test.feide.no/), but I've got no access to any of the IDPs. Anyways, I attached one screenshot with a few requests:

@jaimeperez or anybody else who's got no problem in disclosing somethin on a screenshot 😁 Do you think you could create some more interesting screenshots? E.g. one showing a SAMLresponse?
(Please note: I used the current master for the screenshot since there's already the updated title of the trace window in place)

The whole reponse is too big, but does this help?

Thanks @tvdijen! I think that one serves as a really good example since it shows a lot of content 👍

By the wat, you should still have access on my IdP @khlr..

Updated! I've also taken the chance to change the icon of the extension to match the one displayed in the toolbar.
Thanks a lot guys!


Test Failures on Fresh Clone

Issue Summary
yarn test results in test failures - updated with the latest commit e6f9fce99abd4e3cba06a35e21aed8920ccd7db3
I have made no updates to the code base.

@tryghost/slack-notifications:test
@tryghost/stats-service:test

Steps to Reproduce
yarn global add knex-migrator ember-cli
git clone --recurse-submodules git@github.com:TryGhost/Ghost && cd Ghost
yarn setup
yarn test
Ghost Version
5.44
Node.js Version
v16.19.1
How did you install Ghost?
Local Install
Database type
SQLite3
Browser & OS version
MacBook Pro 13" 2 GHz Quad-Core Intel Core i5
Relevant log / error output
1) SlackNotifications
              notifyMilestoneReceived
                Sends a notification to Slack for achieved ARR Milestone - no meta:

             AssertionError [ERR_ASSERTION]: The expression evaluated to a falsy value:

         assert(sendStub.calledWith(expectedResult, 'https://slack-webhook.example') === true)

             + expected - actual

             -false
             +true

             at Context.<anonymous> (test/SlackNotifications.test.js:104:13)

1) MembersStatsService
              getCountHistory
                Always returns at least one value:

             AssertionError [ERR_ASSERTION]: Expected values to be loosely deep-equal:

       {
         comped: 3,
         date: '2000-01-09',
         free: 2,
         paid: 1,
         paid_canceled: 0,
         paid_subscribed: 0
       }

       should loosely deep-equal

       {
         comped: 3,
         date: '2000-01-10',
         free: 2,
         paid: 1,
         paid_canceled: 0,
         paid_subscribed: 0
       }
             + expected - actual

              {
                "comped": 3
             -  "date": "2000-01-09"
             +  "date": "2000-01-10"
                "free": 2
                "paid": 1
                "paid_canceled": 0
                "paid_subscribed": 0

             at Context.<anonymous> (test/lib/members.test.js:132:20)

         2) MembersStatsService
              getCountHistory
                Passes paid_subscribers and paid_canceled:

             AssertionError [ERR_ASSERTION]: Expected values to be loosely deep-equal:

       [
         {
           comped: 3,
           date: '2000-01-09',
           free: 2,
           paid: 1,
           paid_canceled: 0,
           paid_subscribed: 0
         }
       ]

       should loosely deep-equal

       [
         {
           comped: 0,
           date: '2000-01-09',
           free: 0,
           paid: 0,
           paid_canceled: 0,
           paid_subscribed: 0
         },
         {
           comped: 3,
           date: '2000-01-10',
           free: 2,
           paid: 1,
           paid_canceled: 3,
           paid_subscribed: 4
         }
       ]
             + expected - actual

              [
                {
             -    "comped": 3
             +    "comped": 0
                  "date": "2000-01-09"
             -    "free": 2
             -    "paid": 1
             +    "free": 0
             +    "paid": 0
                  "paid_canceled": 0
                  "paid_subscribed": 0
                }
             +  {
             +    "comped": 3
             +    "date": "2000-01-10"
             +    "free": 2
             +    "paid": 1
             +    "paid_canceled": 3
             +    "paid_subscribed": 4
             +  }
              ]

             at Context.<anonymous> (test/lib/members.test.js:163:20)

         3) MembersStatsService
              getCountHistory
                Correctly resolves deltas:

             AssertionError [ERR_ASSERTION]: Expected values to be loosely deep-equal:

       [
         {
           comped: 4,
           date: '2000-01-08',
           free: 3,
           paid: 1,
           paid_canceled: 0,
           paid_subscribed: 0
         },
         {
           comped: 4,
           date: '2000-01-09',
           free: 3,
           paid: 2,
           paid_canceled: 1,
           paid_subscribed: 2
         }
       ]

       should loosely deep-equal

       [
         {
           comped: 1,
           date: '2000-01-08',
           free: 1,
           paid: 0,
           paid_canceled: 0,
           paid_subscribed: 0
         },
         {
           comped: 1,
           date: '2000-01-09',
           free: 1,
           paid: 1,
           paid_canceled: 1,
           paid_subscribed: 2
         },
         {
           comped: 4,
           date: '2000-01-10',
           free: 3,
           paid: 2,
           paid_canceled: 3,
           paid_subscribed: 4
         }
       ]
             + expected - actual

              [
                {
             -    "comped": 4
             +    "comped": 1
                  "date": "2000-01-08"
             -    "free": 3
             -    "paid": 1
             +    "free": 1
             +    "paid": 0
                  "paid_canceled": 0
                  "paid_subscribed": 0
                }
                {
             -    "comped": 4
             +    "comped": 1
                  "date": "2000-01-09"
             -    "free": 3
             -    "paid": 2
             +    "free": 1
             +    "paid": 1
                  "paid_canceled": 1
                  "paid_subscribed": 2
                }
             +  {
             +    "comped": 4
             +    "date": "2000-01-10"
             +    "free": 3
             +    "paid": 2
             +    "paid_canceled": 3
             +    "paid_subscribed": 4
             +  }
              ]

             at Context.<anonymous> (test/lib/members.test.js:211:20)

         4) MembersStatsService
              getCountHistory
                Correctly handles negative numbers:

             AssertionError [ERR_ASSERTION]: Expected values to be loosely deep-equal:

       [
         {
           comped: 0,
           date: '2000-01-07',
           free: 101,
           paid: 0,
           paid_canceled: 0,
           paid_subscribed: 0
         },
         {
           comped: 4,
           date: '2000-01-08',
           free: 103,
           paid: 1,
           paid_canceled: 1,
           paid_subscribed: 2
         },
         {
           comped: 4,
           date: '2000-01-09',
           free: 3,
           paid: 2,
           paid_canceled: 1,
           paid_subscribed: 2
         }
       ]

       should loosely deep-equal

       [
         {
           comped: 0,
           date: '2000-01-07',
           free: 1,
           paid: 0,
           paid_canceled: 0,
           paid_subscribed: 0
         },
         {
           comped: 1,
           date: '2000-01-08',
           free: 3,
           paid: 0,
           paid_canceled: 1,
           paid_subscribed: 2
         },
         {
           comped: 1,
           date: '2000-01-09',
           free: 0,
           paid: 1,
           paid_canceled: 1,
           paid_subscribed: 2
         },
         {
           comped: 4,
           date: '2000-01-10',
           free: 3,
           paid: 2,
           paid_canceled: 3,
           paid_subscribed: 4
         }
       ]
             + expected - actual

              [
                {
                  "comped": 0
                  "date": "2000-01-07"
             -    "free": 101
             +    "free": 1
                  "paid": 0
                  "paid_canceled": 0
                  "paid_subscribed": 0
                }
                {
             -    "comped": 4
             +    "comped": 1
                  "date": "2000-01-08"
             -    "free": 103
             +    "free": 3
             +    "paid": 0
             +    "paid_canceled": 1
             +    "paid_subscribed": 2
             +  }
             +  {
             +    "comped": 1
             +    "date": "2000-01-09"
             +    "free": 0
                  "paid": 1
                  "paid_canceled": 1
                  "paid_subscribed": 2
                }
                {
                  "comped": 4
             -    "date": "2000-01-09"
             +    "date": "2000-01-10"
                  "free": 3
                  "paid": 2
             -    "paid_canceled": 1
             -    "paid_subscribed": 2
             +    "paid_canceled": 3
             +    "paid_subscribed": 4
                }
              ]

             at Context.<anonymous> (test/lib/members.test.js:274:20)

         5) MembersStatsService
              getCountHistory
                Ignores events in the future:

             AssertionError [ERR_ASSERTION]: Expected values to be loosely deep-equal:

       [
         {
           comped: 3,
           date: '2000-01-08',
           free: 1,
           paid: 0,
           paid_canceled: 0,
           paid_subscribed: 0
         },
         {
           comped: 3,
           date: '2000-01-09',
           free: 2,
           paid: 1,
           paid_canceled: 0,
           paid_subscribed: 1
         }
       ]

       should loosely deep-equal

       [
         {
           comped: 0,
           date: '2000-01-08',
           free: 0,
           paid: 0,
           paid_canceled: 0,
           paid_subscribed: 0
         },
         {
           comped: 0,
           date: '2000-01-09',
           free: 0,
           paid: 0,
           paid_canceled: 0,
           paid_subscribed: 1
         },
         {
           comped: 3,
           date: '2000-01-10',
           free: 2,
           paid: 1,
           paid_canceled: 3,
           paid_subscribed: 4
         }
       ]
             + expected - actual

              [
                {
             -    "comped": 3
             +    "comped": 0
                  "date": "2000-01-08"
             -    "free": 1
             +    "free": 0
                  "paid": 0
                  "paid_canceled": 0
                  "paid_subscribed": 0
                }
                {
             -    "comped": 3
             +    "comped": 0
                  "date": "2000-01-09"
             -    "free": 2
             -    "paid": 1
             +    "free": 0
             +    "paid": 0
                  "paid_canceled": 0
                  "paid_subscribed": 1
                }
             +  {
             +    "comped": 3
             +    "date": "2000-01-10"
             +    "free": 2
             +    "paid": 1
             +    "paid_canceled": 3
             +    "paid_subscribed": 4
             +  }
              ]

             at Context.<anonymous> (test/lib/members.test.js:347:20)

Code of Conduct

[X] I agree to be friendly and polite to people in this repository

Even when I download https://github.com/TryGhost/Ghost/releases/tag/v5.44.0
Do
yarn setup
yarn test
I get the same failure.
The code for the tests haven't changed in months. What am I doing wrong here ?

Please help, this is still happening with the latest update from upstream

@a-amir01 That's strange! I don't get those errors locally nor in CI.

Hmm could it be the node version I am running ?
node: v16.19.1
The only thing I'm doing is
git clone --recurse-submodules [git@github.com](mailto:git@github.com):TryGhost/Ghost && cd Ghost
yarn setup
yarn test

@daniellockyer here is a video running yarn test on the latest version
Steps:
wget https://github.com/TryGhost/Ghost/archive/refs/tags/v5.46.1.zip
unzip v5.46.1.zip
cd Ghost-5.46.1
yarn && yarn workspace ghost run setup (essentially yarn setup without the git init part)
yarn test
Node Version: v16.13.0
https://user-images.githubusercontent.com/15374718/236050564-018ddedb-8024-4eae-8e49-ebfececacdc7.MP4

@allouis awesome! the timezone fixed the issue. I am now getting a different test failure.
ghost-admin:test
Launcher Chrome not found. Not installed?

Is there something extra I need to setup for headless chrome ?

Since I have the project forked, there are some pre-validations before you can push your changes to the forked origin.
So git push origin main will fail because of those test failures. Is there a way to force the timezone ?

Hi all, I am in CST timezone and I got the same errors related to timezones as reported here. This PR that attempts to make the code independant on the system timezone: https://github.com/TryGhost/Ghost/pull/17013
thanks for your review/comments in advance.


satellites turn into 'offline' frequently

Hi, I deployed a cluster and run for a period of time. I usually found some of the resources became 'unknown' state. Then I checked the satellites and the satellites were in 'offline' state. It recovers after I restore the satellites .
Does the satellites unstable or there is anything I missed? I use version 1.13.0.

the offline satellite log:
[SSLNetComService] ERROR LINSTOR/Satellite - SYSTEM - Unhandled IllegalStateException [Report number 60DD874D-1BB89-308894]

Hi, could you provide the error report `` from your node please?
/var/log/linstor-satellite/ErrorReport-60DD874D-1BB89-308894.log

I was reporting something similar on upstream: check it out https://github.com/LINBIT/linstor-server/issues/187 and https://github.com/piraeusdatastore/piraeus-operator/issues/181

I found a similar log while there are lots of similar error log in that directory, only error ID is different:
ERROR REPORT 60F0FF34-2C3CD-362993

============================================================

Application:                        LINBIT?

It seems like the ssl exception as the bug discribes from your links.

Im also periodically getting an exception causing the disconnection between controller and satellite
22:36:03.663 [SSLNetComService] ERROR LINSTOR/Satellite - SYSTEM - Unhandled IllegalStateException [Report number 61258B4F-F3736-923964]

ERROR REPORT 61258B4F-F3736-923964

============================================================

Application:                        LINBIT�� LINSTOR
Module:                             Satellite
Version:                            1.14.0
Build ID:                           26a99c32238e3801b43855ea5a7d34b2571f929f
Build time:                         2021-08-04T13:29:58+00:00
Error time:                         2021-12-09 22:36:03
Node:                               kube1
Peer:                               <IP_ADDRESS>:44286

============================================================

Reported error:
===============

Category:                           Error
Class name:                         ImplementationError
Class canonical name:               com.linbit.ImplementationError
Generated at:                       Method 'run', Source file 'TcpConnectorService.java', Line #734

Error message:                      Unhandled IllegalStateException

Call backtrace:

    Method                                   Native Class:Line number
    run                                      N      com.linbit.linstor.netcom.TcpConnectorService:734
    run                                      N      java.lang.Thread:829

Caused by:
==========

Category:                           RuntimeException
Class name:                         IllegalStateException
Class canonical name:               java.lang.IllegalStateException
Generated at:                       Method 'doHandshake', Source file 'SslTcpConnectorHandshaker.java', Line #104

Error message:                      com.linbit.linstor.netcom.ssl.SslTcpConnectorService indicates requiring a handshake, but the sun.security.ssl.SSLEngineImpl instance is not in handshake mode

Call backtrace:

    Method                                   Native Class:Line number
    doHandshake                              N      com.linbit.linstor.netcom.ssl.SslTcpConnectorHandshaker:104
    read                                     N      com.linbit.linstor.netcom.ssl.SslTcpConnectorPeer:162
    run                                      N      com.linbit.linstor.netcom.TcpConnectorService:543
    run                                      N      java.lang.Thread:829

END OF ERROR REPORT.


[Consensus] Decouple ConsensusModule and PacemakerModule

Objective
The pacemaker module and the consensus module are tightly coupled. By refactoring them and removing this inter-dependency, the codebase will be easier to maintain and update.
Origin Document
@gokutheengineer found a few opportunities to improve the codebase as a new engineer reading the consensus codebase

Goals

Decouple the Consensus & Pacemaker module implementations
Create a codebase that is easier to maintain and update

Deliverable

[ ] Create a dedicated package for the pacemaker module
[ ] Communication between the pacemaker module and the consensus module should happen via the bus
[ ] Updated documentation (code tree structures)

Non-goals / Non-deliverables

Business logic changes to the pacemaker or consensus modules

General issue deliverables

[ ] Update the appropriate CHANGELOG(s)
[ ] Update any relevant local/global README(s)
[ ] Update relevant source code tree explanations
[ ] Add or update any relevant or supporting mermaid diagrams

Testing Methodology

[ ] All tests: make test_all
[ ] LocalNet: verify a LocalNet is still functioning correctly by following the instructions at docs/development/README.md

Creator: @jessicadaugherty
Co-owner: @Olshansk

2 potential paths:

Remove direct access to consensus from pacemaker
Decoupling/making separate modules

Semantic issue; only needed in this version of consensus

Conclusion: option 2 because decoupling them in scope of consensus will be useful in state sync implementation


Want to change displaying account IDs to account names in transaction history

At the moment transferBalance takes the following parameters: (idFrom int, idTo int, amountToTransfer decimal)
Options:

Transfer idFrom and idTo into their account names using a join within the query.
Add the names to the parameters by receiving them from the form in an array when a value is picked. E.g. value="[1, "Nirvana"]"

Opted for option 1.


Build failing due to npm module with less files

I added "ant-design-pro": "^1.1.0" and my build started failing.
ERROR in ./node_modules/ant-design-pro/es/Login/index.js
Module parse failed: Unexpected character '@' (10:0)
You may need an appropriate loader to handle this file type.
| import styles from './index.less';
|
| @Form.create()
| class Login extends Component {
|   static defaultProps = {
 @ ./node_modules/ant-design-pro/es/index.js 19:0-28
 @ dll renderer

I added the following to webpack.config.renderer.dev.js,  webpack.config.renderer.dev.dll.js and  webpack.config.renderer.prod.js
{
        test: /\.less$/,
        use: ExtractTextPlugin.extract({
          use: [
            {
              loader: 'css-loader',
              options: {
                minimize: true
              }
            },
            {
              loader: 'less-loader'
            }
          ],
          fallback: 'style-loader'
        })
      },

I still get the same error.
Sample repo: https://github.com/oadeojo/electron-react-boilerplate

See https://github.com/amilajack/erb-ant-design-example

@amilajack antd works fine. Ant-Pro is the issue.

I didnt know there were differences in the libraries. It is because decorators are not supported by webpack's parser yet. This doesn't have to do with the boilerplate.

I can't make antd with less files work. Can you share your repo if it works?


GSB: Relax verify check some more in RequirementSignatureRequest

The GSB sometimes emits redundant same-type requirements here. Only
checking for a prefix would still trigger false positives, so relax
it all the way to only consider conformance requirements, which
are the important ones from an ABI standpoint.

@swift-ci Please smoke test

@swift-ci Please smoke test


👌 Improve need link tooltips

Currently, the tooltips in needs, for links to need IDs is a bit odd, it just says the current need ID with no context:

This seems not useful, so here I have changed them to provide a tooltip of the title of the linked need:

Will need to fix the tests for this, but would be good to get feedback first

This change is fine and makes total sense. :+1:


Add about page for acknowledgement of harmful content

Also added link to footer; link text is very long but we have no idea what to shorten it to.

coverage: 33.032% (+0.04%) from 32.988%
when pulling d101c98953ff14482a1196ac4ef6a660a9090f31 on ginger/aohc
into 86bb3ac0b14cd943e3ae80acff65da284880f6db on dev.


Laurie-Anne Parant

Hi,
Here is my technical challenge submission.
Have a good review and a nice days,
Laurie-Anne

Closing this. Thanks again!  :)


Windows: Add cred spec test with well form credentials

Signed-off-by: John Howard<EMAIL_ADDRESS>Adds a Windows-specific CI test with a well-formed credential spec.
@patricklang FYI.

@cpuguy83

@justincormack PTAL. Thanks :smile:


Double Quotes to Single Quotes

In reference to this comment.
Since this was essentially already CR'd I'm just gonna merge this after a day or so if no one has any issues with it.

No need to wait. LGTM!