New Crowdin updates

:tada: This PR is included in version 0.26.2 :tada:
The release is available on:

v0.26.2
GitHub release

Your semantic-release bot :package::rocket:


Fix builds from clean state

SessionManagerUniversal.UI dependes on code from CSharpWrapperAPI and the
DLL/PDB from ClientUnivseralCSharp, but was building before they were and
so would fail itself.
Fixes #31

Hi @jwittner, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

It looks like you're a Microsoft contributor (Josh Wittner). If you're full-time, we DON'T require a Contribution License Agreement. If you are a vendor, please DO sign the electronic Contribution License Agreement. It will take 2 minutes and there's no faxing! https://cla.microsoft.com.

TTYL, MSBOT;


os/exec: shell command can't be killed when output redirected with cmd.exe

When I run a shell command with cmd.exe and redirect either the stdout or the stderr, the command cannot be killed (it says that it has been killed once the command is done, but it keeps running).
Here's the code (try to comment out cmd.Stdout =... and cmd.Stderr =...):
package main

import "os/exec"
import "fmt"
import "time"
import "bytes"

func main() {
    cmd := exec.Command("cmd.exe", "/C", "sleep 2")
    var stdout bytes.Buffer
    var stderr bytes.Buffer

    cmd.Stdout = &stdout
    cmd.Stderr = &stderr

    start := time.Now()
    fmt.Println(cmd.Start())
    timer := time.AfterFunc(1 * time.Second, func () {
        fmt.Println("killed", cmd.Process.Kill())

    })
    fmt.Println(cmd.Wait())
    timer.Stop()
    fmt.Println(time.Since(start))
}

It outputs this:
<nil>
killed <nil>
exit status 1
2.0313611s

And without the redirects, the output is:
<nil>
killed <nil>
exit status 1
1.0205677s

System details

go version go1.9.1 windows/amd64
GOARCH="amd64"
GOBIN=""
GOEXE=".exe"
GOHOSTARCH="amd64"
GOHOSTOS="windows"
GOOS="windows"
GOPATH="C:\Users\Home\gopackages"
GORACE=""
GOROOT="C:\Go"
GOTOOLDIR="C:\Go\pkg\tool\windows_amd64"
GCCGO="gccgo"
CC="gcc"
GOGCCFLAGS="-m64 -mthreads -fmessage-length=0"
CXX="g++"
CGO_ENABLED="1"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOROOT/bin/go version: go version go1.9.1 windows/amd64
GOROOT/bin/go tool compile -V: compile version go1.9.1

The issue here is how Windows Named Pipes react to handles inheritence.
When you invoke cmd /c "sleep 2" you launch a cmd.exe which in turn launches sleep.exe (by the way, that's not a native Windows exectuable - it's from a MinGW and the likes).
Cmd.Start launches an I/O loop copying data from an internally-managed os.Pipe to the stdout/stderr io.Writers (the writerDescriptor function adds it to the queue).
The Named Pipe handle created by os.Pipe is inherited by the sleep.exe. When calling Process.Kill the cmd.exe is in fact killed, but the child sleep.exe isn't, and because it still has the inherited pipe it keeps on running until it's done.
So if we want it to properly work we have a couple of options:

Add a method: Cmd.Kill which will make sure we are properly closing the Pipe handle on our side (which would render the Pipe unusable)
Add a way to register extra handles (or fds) to close when calling Process.Kill

See #23019 and the issues to which it refers.  Closing as dup.


Can not load topography data of nanonis

When I load STM topography data of nanonis(.sxm file), igor 8 shows "ConvertTextEncoding gave error : Unknown text encoding" and I cannot open the topography data.
It can be caused by character code. My pc uses UTF-8.

This error occurs when DefaultTextEncoding of Igor Pro returns V_defaultTextEncoding=0. There are two ways to solve this problem.
(1) Choose the text encoding used by the Nanonis software (likely UTF-8 in your case) from Menubar > Misc > Text Encoding > Default Text Encoding
This changes the default text encoding of Igor Pro and may influence other experiment files. Another way is
(2) Change text_encoding = "" in SIDAM.default.toml to text_encoding = "UTF-8" , and save it as written in SIDAM.default.toml. The file is under Igor Pro 9 User Files\User Procedures\SIDAM\ . If you do not know where Igor Pro 9 User Files is, see how to install.
If you do not know what happens when you change the default text encoding of Igor Pro, the second way is better.


Added special error for single quotes

I've noticed people are often confused between single and double quotes in JSON. Let's add a specific error message instead of the cryptic Unexpected token '.

Great idea! :) If you could add the line info, lgtm

I've added error stack. What do you think?

As discussed offline, this doesn't work on Firefox and even on Chrome, some issues have the same error message but aren't solved with switching ' to ". I think we should instead show tips for JSON parsing errors and tell the developers the usual issues (ie. ' instead of " and ending comma).

Will add these tips today then.

Closing this PR and opening a new one.


CSS pseudo classes stopped working

Bug Description:
When I set a custom title bar on a window most CSS pseudo classes stop working.
Steps to reproduce the behavior:

Set any window with a custom title bar.
Assign a pseudo class style in CSS (like :hover).
Try to activate the event.
See that the style is not applied.

Expected behavior:
In the case of :hover the style should be applied when the mouse is hovering over the item, but the style is not being applied. This only happens when I include my 'titlebar.js' script inside a view of my project.
I haven't tested it, but I suspect that almost all mouse related events are not working properly.
Screenshots:
Button being hovered:

Expected style when hovered (applied by dev-console):

titlebar.js:

app.css:

main.html:

Desktop:

OS: Windows 8.1
Electron version: 11.1.0
Node Version: 14.15.1

After some tinkering I managed to find what was causing this issue: The '.container-after-titlebar' element was covering the whole window, basically taking a height of 100%.
So, I basically 'solved' this problem by modifying the class and overwriting the height to be 0. IDK if this will mess with anything from the library, but for now it'll do.

I faced the same problem and found the reason why it happens:
 element should have been loaded after "DOMContentLoaded" event.
take a look at this example:
https://github.com/AlexTorresSk/custom-electron-titlebar/blob/0e61605cae6b7721c04ef7f5ed68c9c64e1346e4/example/preload.js
Then,  element can wrap the other elements in  element.
I think it would be great to explain(warn) this in the document.


[WIP] Support WebTransport on quiche 0.12.0

https://www.ietf.org/id/draft-ietf-webtrans-http3-02.html

I'm so sorry.
I made a mistake trying to merge something that was not ready yet into my folk.


docs(readme): Add link to doc-gen documentation to readme

closes https://github.com/YannickMeeus/event-sauced-ts/issues/117

:tada: This PR is included in version 1.0.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This PR is included in version 1.0.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


No support for @SupressWarnings

Unused variables are still underlined even when SupressWarnings is applied. This did not happen when working with the RedHat extension.
@SuppressWarnings("unused")
public class Abstraction {

    public static void main(String[] args) {
        Object object = new Object();
    }
}

Findings from my testing:

@SuppressWarnings("unused") really is ignored, while others, like @SuppressWarnings("static-access") are correctly honored.
Unlike the Red Hat extension, this one doesn't seem to supply Quick Fix for adding/extending @SuppressWarnings for any type of suppressible problem.

PR raised on Netbeans side to fix this issue: https://github.com/apache/netbeans/pull/7548

PR merged would be available in NB-23


Move to rubocop-hq

s/pocke/rubocop-hq/
Add LICENSE
Move it
Release this gem to rubygems.org to apply the changes

@rubocop-hq/rubocop-core I've transferred this repository from https://github.com/pocke/rubocop-rubycw.


Added support for @script annotation tag

Hello,
I needed to create a style guide where I could be able to indicate whether that particular part (atom/molecule/structure) needed to be complemented with javascript code to run.
Therefore I added support for a @script tag that will render in a code block, just below the markup.
Example:
/**
 * Header bar with logo, navigation, and tool icons at the top of the page.
 *
 * @structure Header
 * @flag full-width
 * @markup
 *  <div class="SG-header">
 *    @{include:.SG-logo}
 *    @{include:.SG-nav-icons}
 *    @{include:.SG-nav}
 *  </div>
 * @script
 *    $('body').on('click','.SG-header',function(){
 *        $(this).doSomething();
 *    });
 */

Will make the styleguide render this

This can be applied to Atoms, Molecules and Structures. I think nuclides, and their special forms (mixins and colors) step out of this specific need so I intentionaly left them out of this feature.
Tested with Google Chrome 52.0.2743.116 (64-bit) on a MacOS OSX Yosemite (10.10)

Extended features and fixed tests not running successfuly
Ability to specify tag scripts in config.nucleus.json, pointing to javascript sources, needed to run javascript based componentes in the styleguide
Example config
{
  "title":  "Nucleus",
  "files":  [
    "assets/styles/**/*.scss",
    "assets/styles/nuclides/icons.css",
    "docs/src/styles/nuclides/icons.css",
    "docs/src/styles/**/*.scss"
  ],
  "css": "../docs/build/styles/app.css",
  "target"  : "./styleguide",
  "namespace": null,
  "scripts" : ["//ajax.googleapis.com/ajax/libs/jquery/1.9.1/jquery.min.js","./scripts/ui-kit.js"]
}

Will there be any development soon on this pull request? This feature would be really useful!

@memic84 ASAP I'll merge latest branch

If you'd resolve the conflicts, I'd be happy to merge this, too :)

I'll take a loot, as soon as i have time.

Sead Memić

2016-12-16 11:37 GMT+01:00 Michael Seibt<EMAIL_ADDRESS>
If you'd resolve the conflicts, I'd be happy to merge this, too :)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/holidaypirates/nucleus/pull/15#issuecomment-267565715,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AC5yAAFkBjDU3TJ1MBRxvj_iCntfTG22ks5rImnSgaJpZM4JsBtv
.

@michaelseibt, conflict resolved :)

Hi
@michaelseibt , any forecast on when this could be merged to master? I'm using a link to my github account in the npm packages, and would really like to have the official repo instead
Thanks!

I use the same workaround... ^^

Merged 🎉  thanks for the collaboration!

Bumped, you folks should upgrade to 1.1.0 👍


tessera release 22.1.8

fix CVEs
update PKIX

failed because of hsqldb https://nvd.nist.gov/vuln/detail/CVE-2022-41853
latest version of hsqldb does not resolve it:
hsqldb-2.7.0.jar<EMAIL_ADDRESS>: CVE-2022-41853

hsqldb issue is resolved


Support empty tag and additional tag for JS release build

Currently release job fails if tag or additional tag is not set. We should set default value for additional tag to empty instead of failing the job at release phase. Similarly we should set a default value for tag and allow user to update value at queue time.

Verified using @azure/template release pipeline to publish version 1.0.9-beta.798246 without changing tag:
https://dev.azure.com/azure-sdk/internal/_build/results?buildId=798246&view=logs&j=8a59aa26-f1cb-5dea-999b-76ab4b63e138&t=3aff0b02-11c2-52e1-59c8-fe61f5396ef2


Introduce golang-test image for Go 1.23 and remove the Go 1.21 version

How to categorize this PR?

/area ops-productivity
/kind enhancement
What this PR does / why we need it:
Golang 1.23.0 is available and the 1.21 branch is not maintained anymore. Thus, this PR replaces golang-test image 1.21 with 1.23.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Release note:

Introduce `golang-test` image for Go 1.23 and remove its Go 1.21 version.

/lgtm
/approve


feat: ResolveResponse::as_root

Closes https://github.com/denoland/deno_graph/issues/140

Not necessary anymore.


New Lightmapper renders black textures with PanoramaSky EXR in GLES 2. Godot_v3.2.4-rc3_win64

Godot version:
Godot_v3.2.4-rc3_win64
Issue description:
New Lightmapper renders black textures when the Environment Background is set to PanoramaSky EXR.
Issue appears to maybe only be present in GLES 2.
Setting LightMapper Environment to Custom Sky and loading the same PanoramaSky yields same result.
Steps to reproduce:

Create project with GLES2
Set Environment Background to PanoramaSky
Set EXR as Image
Set Environment in LightMapper to Scene.
Bake :)

Minimal reproduction project:
BUG_Bake.zip

I have traced back the origin of the problem to the usage of an HDR .exr texture as the environment texture. It seems like the GLES2 doesn't play nice with HDR textures (AFAIK it doesn't support HDR lighting, so it makes sense) and getting data from them gives scrambled data.
I try to find a way around the limitation, but in the meantime converting your EXR image to png should work fine.

@JFonS Thank you for taking a look! I guess this should be obvious since it is stated in the documentation that GLES 2 doesn't use HDR rendering features. https://docs.godotengine.org/en/stable/tutorials/misc/gles2_gles3_differences.html#hdr
My fault for not realizing this extends to all HDR related operations and not just the viewport.
Can confirm that the same image converted to PNG does appear to bake correctly.

However, @JFonS this does raise another question.
In the BakedLightmap node Inspector settings, there is an option to "Use HDR" which renders HDR EXR images for the lightmaps.
If the project is set to GLES2, wouldn't the previously mentioned issue also be present here as well?

Not really... From what I see, the only thing that is not working with HDR textures in GLES2 is getting the texture data from the GPU to the CPU (probably a bug somewhere, needs to be investigated).
So if you set an HDR texture as the environment panorama, when the lightmapper tries to read it, it gets invalid data. Just sending the lightmap texture as HDR to the GPU should work fine.
I debated disabling the "Use HDR" option in GLES2, since any light value over 1 will get clamped by the renderer anyway. But the increased precision reduces banding in the lightmap, so I decided to keep it.

Heh! So looking forward to the GPU lightmapper ;)
Actually, if I may humbly suggest, perhaps the pop up text on the "Use HDR" button could describe what is actually going on as to not confuse the user that they are actually rendering HDR lightmaps.
Lastly, would you suggest that an issue be created to explore that bug regarding getting HDR texture data from the GPU to the CPU?


Fix Avatar Image Uploading File Type Restrictions

Tried to find the part of the server that does image processing to make sure this was the right set of images, but I couldn't find what processes the images as the "kraken alternative".

Tried to find the part of the server that does image processing to make sure this was the right set of images, but I couldn't find what processes the images as the "kraken alternative".

I've used the same set of restrictions on file types that the web client for keybase.io uses :)


Why not add pattern to the output files?

Like pattern
random	/tmp/nvimVaVjop/1.py	/^import random$/;"	i	line:16
in python tags file.
Currently, i have a gotags file with line
EnvEnableProfiling	/tmp/nvimORpwWJ/1.go	45;"	c	access:public	line:45.
Normally this works with tagbar, but not this file https://github.com/ipfs/go-ipfs/blob/master/cmd/ipfs/main.go#L567, the special character '^C' break things.
Tagbar#JumpToTag always go to this line for whatever tags, this is because of the empty pattern, check https://github.com/majutsushi/tagbar/blob/master/autoload/tagbar.vim#L2483.

This is likely a bug in Tagbar (see #32). Jumping works correctly if you remove the ^ character and in both cases the gotags output is the same.

I think we should be simply push this problem to tagbar, because the consequences are not only from it. First, it's because gotags doesn't output standard pattern info to tags file, as a result tagbar can't go to the right line. And the reason tagbar can't go to right line is, tagbar always first jump to the line number of a tag specified in tags file, and then check whether the pattern is located at it, for gotags case there is no pattern, so tagbar think the file has been changed after tags file are generated, and try to search pattern to locate the real location, and also because pattern is empty, tagbar can not find the right line. I think what tagbar is doing is necessary, it's better for gotags to give pattern in the tags file.

This is a bit of a grey area. Technically what gotags does here is legal, as the tags file format only says that the tagaddress field should be a valid Ex command, which a simple line number is. Tagbar has so far assumed that the address is always a pattern, since it calls Ctags with the --excmd=pattern option and all the other ctags-compatible parsers I'm aware of also output a pattern.
So it's technically a bug that Tagbar doesn't properly handle line numbers (or any other kind of command) for that field, and I should probably fix that. On the other hand it would be very useful if gotags did output a pattern instead of a line number, mostly to make finding the tag after unsaved changes possible just as @apporc mentioned. The line number is already present in an extension field so doesn't add any information there.

I've fixed Tagbar so it doesn't fail if the tagaddress field is not a pattern, so normal jumping should work now. It would still be good if gotags actually output a pattern for the reasons mentioned in my previous comment.

Thanks @majutsushi for the update and fixing Tagbar! I originally used the ctags spec when creating gotags and back then outputting line numbers was the easiest thing to do. It does makes sense to output a pattern, but that would require significant code changes. I'll keep this issue open.


Analysis shows Harvest Moon was unused when it wasn't available.

Log: https://xivanalysis.com/fflogs/xYmQB6zy7vbqPKtN/3/9
The analysis shows only 1 out of 2 Harvest Moons were used but a 2nd Harvest Moon was never available.

In this case, it is expecting that you will be able to get a cast of Soulsow in during Kampeos Harma/Limit Cut. It can be tough, but it is very much possible.

I had blue squares so I had to swap with someone. Is it possible to cast Soul Sow in that timeframe?

It is, it just requires careful positioning and a little cooperation from your partner.


CI and Prod in single file

First of all thank you very much for this tool. It is truly the well deserving successor of dotenv. It has simplified a lot of stuff for me. That being said I need help with a particular scenario which I am sure is very normal one.
I have a github actions+docker setup to deploy a nextjs app where I am running docker build stage with
--build-arg DOTENV_PRIVATE_KEY_CI=${{ secrets.DOTENV_PRIVATE_KEY_CI }}

which automatically pickups, decrypts and loads .env.ci inside Dockerfile for which I am doing this inside dockerfile
ARG DOTENV_PRIVATE_KEY_CI=privatekey
ENV DOTENV_PRIVATE_KEY_CI=${DOTENV_PRIVATE_KEY_CI}
.
.
.
RUN pnpm dlx @dotenvx/dotenvx run -- pnpm run build
.
.
.
CMD HOSTNAME="<IP_ADDRESS>" pnpm dlx @dotenvx/dotenvx run -- node server.js

Now my issue is I have a branch based CI configuration where depending upon which branch has the commit, either dev instance will be build and deployed or prod instance will be build and deployed. I was able to setup rest of things just dotenvx setup is pending. My expectation is based on a boolean that I passed to dockerbuild command, dotenvx should load either .env.ci file or .enc.production (or just  .env) file so I can have same github action and Dockerfile in both branches. I tried few ways but not able to do so.

i believe you just need to extend your Dockerfile to optionally accept the DOTENV_PRIVATE_KEY_PRODUCTION, so something like this?
ENV DOTENV_PRIVATE_KEY_CI=${DOTENV_PRIVATE_KEY_CI}
ENV DOTENV_PRIVATE_KEY_PRODUCTION=${DOTENV_PRIVATE_KEY_PRODUCTION}
.
.
.
RUN pnpm dlx @dotenvx/dotenvx run -- pnpm run build
.
.
.
CMD HOSTNAME="<IP_ADDRESS>" pnpm dlx @dotenvx/dotenvx run -- node server.js

this way if _PRODUCTION is set run will look for the .env.production file. If _CI is set it will look for .env.ci.
see if that works?
if not, i am considering the option to pass --privateKey=<privatekey> directly as a flag to run. this way, you could write code to compose your run command however you wish:
$ dotenv run -f .env.production --privateKey=<prodPrivKey> -- node server.js
$ dotenv run -f .env.ci --privateKey=<ciPrivKey> -- node server.js
etc

going to close this, let me know if it doesn't work.

Apologies I was busy last week and couldn't check it. Github secret are repository level, (branch/tag level secrets require premium 🙂↔) so both CI and PRODUCTION secret would be set and dotenvx would decrypt both and load both. I am not sure which file will be loaded to env finally but still a little finicky approach.
Although second solution, Works like a charm. Exactly what I needed. I am creating two variables in docker like this
dotenv run -f $FILE_NAME --privateKey=$KEY -- node server.js

and based on the keyword dev in the commit tag I am passing either dev or production secrets in github actions to docker command.
if [ ${{ contains( github.ref_name,'dev') }} ]; then
           docker build --build-arg FILE_NAME=.env.ci  --build-arg KEY=${{ secrets.DOTENV_PRIVATE_KEY_PRODC }}  -t ${{ github.sha }} ./
         else
           docker build --build-arg FILE_NAME=.env.production--build-arg DOTENV_PRIVATE_KEY=${{ secrets.DOTENV_PRIVATE_KEY_PRODUCTION }} -t ${{ github.sha }} ./
         fi

Also great release last week. Now I can use actual names like .env.dev and .env.prod instead of CI and PRODUCTION. Thanks for all your work ✨


Incorrect comment in kubeadm manifest

The comment at https://github.com/projectcalico/calico/blob/47184e4c441ccd99931675eab43120634b501015/master/getting-started/kubernetes/installation/hosted/kubeadm/1.6/calico.yaml#L70
is incorrect.
It should be moved to the nodeSelector and a new comment added indicating that the toleration allows the pod to run on master.

@tmjd . I have tried to fix the issue  based on your inputs. Can you please review the PR and check if this is the change you were expecting and merge it based on what you think about it.


[Feature][UI Next] Add Udf resource manage

Purpose of the pull request
#7785

Brief change log
Resource Manage

list

add

upload

Codecov Report

Merging #8076 (bdf44cc) into dev (a5f4e3d) will increase coverage by 0.01%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##                dev    #8076      +/-   ##
============================================
+ Coverage     41.36%   41.38%   +0.01%
  Complexity     3722     3722
============================================
  Files           637      637
  Lines         27114    27113       -1
  Branches       3075     3073       -2
============================================
+ Hits          11217    11220       +3
+ Misses        14820    14816       -4
  Partials       1077     1077

Impacted Files
Coverage Δ

...er/master/dispatch/host/assign/RandomSelector.java
77.77% <0.00%> (-5.56%)
:arrow_down:

...inscheduler/common/task/sqoop/SqoopParameters.java
74.00% <0.00%> (-2.00%)
:arrow_down:

...dolphinscheduler/remote/future/ResponseFuture.java
81.96% <0.00%> (-1.64%)
:arrow_down:

...lphinscheduler/service/process/ProcessService.java
35.50% <0.00%> (+0.16%)
:arrow_up:

...er/server/master/runner/WorkflowExecuteThread.java
10.02% <0.00%> (+0.43%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a5f4e3d...bdf44cc. Read the comment docs.

PTAL @songjianet @labbomb


Update index.html

In browsers, md5( ArrayBuffer ) always returns<PHONE_NUMBER>08457705bf09a8ee3c1093 same as a hash of an empty ArrayBuffer. But if it cast to Int32Array before, it works correctly.
FYI: https://caniuse.com/#search=TypedArray

I also get the correct result if I cast to Int32Array, Uint32Array, Int16Array or Uint16Array, but not Int8Array or Uint8Array. If you can't guarantee the length will be divisible by two, casting doesn't seem reasonable. For other inputs it's correct, but for now it seems easiest for me to use js-md5 rather than reworking my input.


[WIP] Check enablement from values part as well

should help resolve https://github.com/istio/istio/issues/19799

@richardwxn: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

mandiff_operator
9c6e1007174e880556665e4294e647549c75af01
link
/test mandiff_operator

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@richardwxn: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

mandiff_operator
9c6e1007174e880556665e4294e647549c75af01
link
/test mandiff_operator

lint_operator
9c6e1007174e880556665e4294e647549c75af01
link
/test lint_operator

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@richardwxn: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

mandiff_operator
9c6e1007174e880556665e4294e647549c75af01
link
/test mandiff_operator

lint_operator
9c6e1007174e880556665e4294e647549c75af01
link
/test lint_operator

test_operator
9c6e1007174e880556665e4294e647549c75af01
link
/test test_operator

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@richardwxn: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

test_operator
4d0fd129744683005b6c78b1f7ea0f4bf0d011c6
link
/test test_operator

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Let's hold off merging this till https://github.com/istio/operator/pull/713 goes in - I'm concerned I may break something in this change if I merge into that PR.

@richardwxn please move this over to istio/istio since istio/operator has now been merged there.


update demo

Coverage remained the same at 75.549% when pulling 6638fa65de6584f93a2668b2ab47864be255bcc0 on update-demo into 0bef7f6e73a9d02d3b1ce96ffd34986a83564f39 on master.


match docs to default kwarg

Assuming the kwarg as specified in the code was intended

Ah, thanks, missed to update the docs, nice catch!


"Adventure Z" crashes when entering the world

Describe the bug
Game crashes when entering the world
Steps to reproduce

...
Logs
No response
Additional context
No response

错误报告-2023-11-26_14.37.35.zip


Dataset

Is it now convenient to open source the dataset？ We want to collect spectral images in our research. It's very kind of you to open source your data. Thanks!

Datasets and pre-trained models are now available. See the updated README for details. Not a problem, I hope the data can be put to good use!


RTMClient fails to automatically reconnect when getting connection reset error (WinError 10054)

When i use auto_reconnect=True as the parameter for rtm.start() in slackclient 2.9.3 i get
TypeError: start() got an unexpected keyword argument 'auto_reconnect'.
Python - 3.6

Hey @rish-lab , the option is only available in the class's constructor. https://github.com/slackapi/python-slack-sdk/blob/v2.9.3/slack/rtm/client.py#L108
Also, the default value for the options is True. If you intend to set it as True, it's not necessary to explicitly set the value.

Hey @rish-lab , the option is only available in the class's constructor. https://github.com/slackapi/python-slack-sdk/blob/v2.9.3/slack/rtm/client.py#L108
Also, the default value for the options is True. If you intend to set it as True, it's not necessary to explicitly set the value.

I have been getting WinError 10054 - An existing connection was forcibly closed by the remote host.
If auto reconnect is True by default, it should have reconnected right?

I have been getting WinError 10054 - An existing connection was forcibly closed by the remote host.
If auto reconnect is True by default, it should have reconnected right?

hmm, we've never received this type of feedback. If the error is not caught here, the auto reconnecting logic may not work. https://github.com/slackapi/python-slack-sdk/blob/v2.9.3/slack/rtm/client.py#L372-L376
If you can provide more information about the exception your app throws, we may be able to improve the logic.

hmm, we've never received this type of feedback. If the error is not caught here, the auto reconnecting logic may not work. https://github.com/slackapi/python-slack-sdk/blob/v2.9.3/slack/rtm/client.py#L372-L376
If you can provide more information about the exception your app throws, we may be able to improve the logic.

Hey @rish-lab,
we recently released a new RTMClient implementation - from slack_sdk.rtm.v2 import RTMClient. I'm sure that this new one should be doing better in auto-reconnecting logic. If you are fine to try switching to the new module, the module may work better for you.
Also, our latest recommendation is to use Socket Mode. You can use SocketModeClient for it.
As we, as maintainers of this project, do not have any further action to take there, please allow me to close this issue after waiting for your response for a few more business days.


Update README.md

Fixed broken link to README example

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Codecov Report

Merging #4801 into master will decrease coverage by 3.89%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4801      +/-   ##
==========================================
- Coverage   53.73%   49.83%    -3.9%
==========================================
  Files       10337     6211    -4126
  Lines      217236   174214   -43022
==========================================
- Hits       116738    86825   -29913
+ Misses     100498    87389   -13109

Impacted Files
Coverage Δ

...afactory/azure/mgmt/datafactory/models/__init__.py
50.67% <0%> (-49.33%)
:arrow_down:

...ights/azure/applicationinsights/models/__init__.py
51% <0%> (-49%)
:arrow_down:

...e/cognitiveservices/vision/face/models/__init__.py
51.08% <0%> (-48.92%)
:arrow_down:

...services/language/textanalytics/models/__init__.py
51.16% <0%> (-48.84%)
:arrow_down:

...iveservices/search/entitysearch/models/__init__.py
51.25% <0%> (-48.75%)
:arrow_down:

azure-eventgrid/azure/eventgrid/models/__init__.py
51.25% <0%> (-48.75%)
:arrow_down:

...ration/azure/mgmt/datamigration/models/__init__.py
51.27% <0%> (-48.73%)
:arrow_down:

...ure/mgmt/recoveryservicesbackup/models/__init__.py
51.46% <0%> (-48.54%)
:arrow_down:

...ce/azure/mgmt/containerinstance/models/__init__.py
51.8% <0%> (-48.2%)
:arrow_down:

...tiveservices/search/videosearch/models/__init__.py
52.08% <0%> (-47.92%)
:arrow_down:

... and 4211 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 51dd8c9...8832ef4. Read the comment docs.


Integrate Delete Functionality with API Service in Note Component

Issue: Integrate Delete Functionality with API Service in Note Component
Objective
Modify the note_component to ensure the delete button calls ApiService.deleteNoteFromAPI, effectively deleting the current note from the API upon user action.
Background
The note component currently lacks direct integration with the API for deleting notes. Users need a reliable and immediate way to delete notes, and this should be handled through the ApiService.deleteNoteFromAPI method to ensure consistency and reliability across the application.
Technical Requirements

Identify and modify the delete function or button event in the note_component.
Integrate the ApiService.deleteNoteFromAPI method into the delete functionality.
Ensure that the delete action is confirmed before executing to prevent accidental deletion.
Update any relevant state or UI components to reflect the deletion of the note.

Expected Outcome
After the integration:

Users will be able to delete notes, with the action directly interacting with the API.
The application will reflect the deletion immediately, removing the note from the user interface.
The overall user experience of note management will be more cohesive and reliable.

Acceptance Criteria

The delete button in the note_component successfully calls ApiService.deleteNoteFromAPI.
The application confirms deletion with the user before permanently removing the note.
Deletion of a note is reflected in the application immediately after the user confirms.
The delete functionality is robust, handling any potential errors or issues smoothly.

Files to be Modified

note_component

Additional Notes
As deletion is a critical functionality with permanent consequences, ensure that the user experience is clear and that there are safeguards against accidental deletions. Consider implementing a confirmation dialogue or a temporary "undo" option to enhance user control and prevent unintended loss of data.
Action Items

[x] Assign a developer to address the issue.
[x] Implement the delete functionality integration as per the requirements.
[x] Review and test the new delete feature.
[ ] Merge the changes after approval.

This is finished just needs merged, for now we are merging all changes into deliverable-2 branch to be merged into main later


rely on .catch() to invoke callback with Error

This is necessary to make sure the callback is invoked asynchronously.

LGTM.


Remove small bounding box on the witch in Halloween.html

Hey, I have fixed this issue.
Please find my PR here- https://github.com/sudz123/Happy_Hacking/pull/530

Good work!


actually use configserver values in mongos

so far as I can tell, the configserver nodes in mogodb_instance are entirely unused. This seems to be in error.

Moved to https://github.com/chef-brigade/mongodb-cookbook/issues/76


Refactor ExceptionHandling in StreamDao

Expected Behavior
Refactor Exception Handling for StreamDaoImpl. This issue is created out of PR comments of https://github.com/homeaway/stream-registry/pull/111

will spend some time in pair-programming to identify key parts of this and possibly break this down into smaller work-deliverables.

@neoword I think this one can be closed

@prabhakar1983 , can you reference the corresponding PR that closes this?


powerline fonts

Hello,
I would like to know if it is possible to use powerline fonts when using bufferline ?
I know there is an option for the delimiters, but to be more specific, is there something more automatic that can be done ?
Thank you in advance for any response

if you check the airline docs https://github.com/bling/vim-airline/blob/master/doc/airline.txt#L174 you can just copy paste the characters from there and modify g:bufferline_active_buffer_left and g:bufferline_active_buffer_right respectively.

Thank you very much :)


World loading

Anvil loading is complete, but requires an API. Marking this as done for now.

Maybe a "Done" label would be nice.

The issue is closed, that's the done label.

Mkay


Should we code-generate the Router type?

Currently, the conversion from RuntimeError into http::Response is in the aws-smithy-http-server runtime crate:
https://github.com/awslabs/smithy-rs/blob/430f4bf8b49f2b1827d9c1657a6d0a5096cad978/rust-runtime/aws-smithy-http-server/src/runtime_error.rs#L59-L97
This conversion is used both by the Router (that converts RuntimeError::UnknownOperation into an 404 HTTP response), and in the code-generated operation handlers' from_request functions (example below):
crate::operation_deser::parse_string_payload_request(req)
    .await
    .map(StringPayloadOperationInputWrapper)
    .map_err(|err| aws_smithy_http_server::runtime_error::RuntimeError {
        protocol: aws_smithy_http_server::protocols::Protocol::RestJson1,
        kind: err.into(),
    })

However, the conversion is protocol-specific: that is, each protocol converts the runtime error into an HTTP response in a different way. This means the conversion cannot live in the runtime: we want to support loading RustCodegenDecorators from the classpath that add support for protocols defined outside the smithy-rs project.
Say we code-generate a protocol-specific function fn runtime_error_to_response(err: RuntimeError) -> http::Response<BoxBody>. There is no problem in having an operation handler's from_request use said function to return the HTTP response. However, the Router is a runtime component, not a code-generated one. In order for it to call the function we would have to pass it to the constructor (which is called by the code-generated impl From<OperationRegistry> for Router):
#[derive(Debug)]
pub struct Router<F, B = Body> {
    routes: Routes<B>,
    runtime_error_fn: F,
}

(note that F does not have a default and needs to go first in the list of generic type parameters). This is a breaking change, users would need to at least type Router<_> in their code.

The act of routing the incoming HTTP request itself to an operation is also protocol-specific: each protocol defines its own routing rules. We currently match over all externally-supported protocols, when we only always exercise one branch. So this is another place where we need to be able to inject protocol-specific routing logic into the Router when constructing it, by passing in another closure.
It seems to me like after these breaking changes, there isn't much protocol-agnostic stuff in the Router type. This begs the question: should we entirely code-generate a protocol and service-specific Router in the generated sSDK?

Note that passing a trait object for the runtime error into response conversion closure:
type RuntimeErrorFn = Box<dyn Fn(RuntimeError) -> http::Response<BoxBody>>;

pub struct Router<B = Body> {
    routes: Routes<B>,
    runtime_error_fn: RuntimeErrorFn,
}

Would not break user code. However, we need RuntimeErrorFn to be Clone, which requires Sized, so it can't be made into a trait object. RuntimeErrorFn needs Clone for Router to be Clone, which is a requirement for IntoMakeService to work:
---- src/operation_registry.rs - operation_registry::OperationRegistry (line 29) stdout ----
error[E0277]: the trait bound `Router: Clone` is not satisfied
  --> src/operation_registry.rs:49:50
   |
22 |    let server = hyper::Server::bind(&bind).serve(app.into_make_service());
   |                                            ----- ^^^^^^^^^^^^^^^^^^^^^^^ the trait `Clone` is not implemented for `Router`
   |                                            |
   |                                            required by a bound introduced by this call
   |
   = note: required because of the requirements on the impl of `for<'a> Service<&'a AddrStream>` for `IntoMakeService<Router>`
   = note: required because of the requirements on the impl of `service::make::MakeServiceRef<AddrStream, Body>` for `IntoMakeService<Router>`

This failing idea is implemented in this davidpz/make-runtime-error-into-response-protocol-agnostic-via-trait-object branch.

Do we want to use class path based RustCodegenDecorators for version 1.0 or later? and are these known protocols that we are talking about or unknown protocols? If we are talking about unknown protocols, would it be sufficient to just move the router out or do we need to move the request / response into code generated part as well?

Are we going to convert the existing code generator into a class path loaded RustCodegenDecorator as well or there is no change in that?

By code generating the router, at a later stage, we can also try a trie like structure that is optimised for the URLs that are present in the smithy file. I am not sure how much of a speed gain, if any, that would give us but it might be worth trying out.

If we code generate router based on the protocol, can we simplify RuntimeError by removing pub protocol: Protocol from it, and all the match statements that we have inside into_response as well? If yes, that can definitely speed us up.

Does this affect how we generate logging commands inside the router? Will the customer be passing an argument at code generation time to have logging commands generated / enabled?

Will this scheme help us in skipping the logging commands inside a route if it has sensitive trait on it?

In the current scheme, any bug fix and enhancement to the router can easily be rolled out by pushing out a new version of the runtime. But in this new scheme, the customer will have to rerun the code generator to generate the new crate. Let's discuss the recommended deployment strategy in both cases and how future versions are to be rolled out under both.

Do we want to use class path based RustCodegenDecorators for version 1.0 or later?

We use them now, it's something that we already do.

and are these known protocols that we are talking about or unknown protocols?

Unknown protocols.

If we are talking about unknown protocols, would it be sufficient to just move the router out or do we need to move the request / response into code generated part as well?

Code-generating the Router would be sufficient.

Are we going to convert the existing code generator into a class path loaded RustCodegenDecorator as well or there is no change in that?

If by existing code generator, you mean either the rust-codegen or rust-server-codegen code generators, these are not decorators, but Smithy plugins. They are the entrypoint to code generation.

By code generating the router, at a later stage, we can also try a trie like structure that is optimised for the URLs that are present in the smithy file. I am not sure how much of a speed gain, if any, that would give us but it might be worth trying out.

I've already thought about this. I think performance improvements would only start being noticeable in services with a huge (100?) number of routes. However, the main problem with trie-based routing is that we can't use something off-the-shelf like matchit because of Smithy's routing requirements. It would be very challenging to implement, say, routing based on query string literals using a trie-like data structure, because they can appear anywhere in the request URI after the path.

If we code generate router based on the protocol, can we simplify RuntimeError by removing pub protocol: Protocol from it, and all the match statements that we have inside into_response as well? If yes, that can definitely speed us up.

Yes, the protocol field would go away.

Does this affect how we generate logging commands inside the router? Will the customer be passing an argument at code generation time to have logging commands generated / enabled?

This is unrelated to the fact of whether we code-generate the Router or not. Either way, users should be able to enable logging on their service by registering a layer.

Will this scheme help us in skipping the logging commands inside a route if it has sensitive trait on it?

Yes. At codegen time we have this information in the model and we can thus filter out the logging statements in any component that is code-generated.

In the current scheme, any bug fix and enhancement to the router can easily be rolled out by pushing out a new version of the runtime. But in this new scheme, the customer will have to rerun the code generator to generate the new crate. Let's discuss the recommended deployment strategy in both cases and how future versions are to be rolled out under both.

The assumption is that every time the user deploys, they are running the code generator.

Closed by https://github.com/awslabs/smithy-rs/pull/1666


Using Adguard 2 on a mac with more than one account

https://github.com/AdguardTeam/AdguardForMac/issues/509

core/pull-requests/1301


Problems with remaining time and bandwidth fields while downloading

Hi,
The bandwidth and remaining time of Download tasks are not being shown properly on gui, although it's being shown on the output terminal.
Could it be a problem on my machine or it is in the application itself?
Running AppImage v1.8.0 on Kubuntu 21.10.

Thx. I am aware of it and has patch already in testing. It will be fixed soon.
The problem is that rclone changed output formal and browser parsing fails.

This is the same as Issue #174

I think I will release new version tomorrow - so many issues will become history including this one.

I just want to let you know how much I enjoy using RB. It is an indispensable tool, and I use it constantly every day.
You’ve done a superb job making this the best GUI for rclone. Thank you.

From: kapitainsky @.***>
Sent: Saturday, November 13, 2021 11:32 AM
To: kapitainsky/RcloneBrowser
Cc: detatik; Comment
Subject: Re: [kapitainsky/RcloneBrowser] Problems with remaining time and bandwidth fields while downloading (Issue #182)
I think I will release new version tomorrow - so many issues will become history including this one.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHubhttps://github.com/kapitainsky/RcloneBrowser/issues/182#issuecomment-968105134, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AHBYWPD7VLD5XDHOEGX5UUTUL2OL3ANCNFSM5HEXZKNA.

I think I will release new version tomorrow - so many issues will become history including this one.

Hello dear kapitainsky!
I would ask please, when the new release will be available ?

I am ashamed of mine own missed deadlines... but always something made me stop to work on this. Now life here is getting a bit quieter so please wait few more days. Once more appologies for all delays. Sometimes not everything is under my control.

I am ashamed of mine own missed deadlines... but always something made me stop to work on this. Now life here is getting a bit quieter so please wait few more days. Once more appologies for all delays. Sometimes not everything is under my control.

Thanks for your answer.
Don't worry, we are waiting for your great work!
Have a nice day.

I am ashamed of mine own missed deadlines... but always something made me stop to work on this. Now life here is getting a bit quieter so please wait few more days. Once more appologies for all delays. Sometimes not everything is under my control.

Take your time, man
Thank you for your work, and have a awesome new year!

2021/12/19 12:22:52 INFO  :
Transferred:   	   31.238 MiB / 813.187 MiB, 4%, 580.032 KiB/s, ETA 23m
Transferred:            0 / 2, 0%
Elapsed time:       1m6.8s
Transferring:

                             YR31588W.MP4: 56% /16.033Mi, 177.761Ki/s, 40s

                             YR31783W.MP4:  2% /797.154Mi, 406.712Ki/s, 32m31s

2021/12/19 12:23:19 DEBUG : YR31588W.MP4: md5 = 49c4592d73c3ca7dc83a73dab3dd84a3 OK
2021/12/19 12:23:19 INFO  : YR31588W.MP4: Copied (new)
2021/12/19 12:23:52 INFO  :
Transferred:   	   72.273 MiB / 813.187 MiB, 9%, 622.846 KiB/s, ETA 20m18s
Transferred:            1 / 2, 50%
Elapsed time:       2m6.8s
Transferring:

                             YR31783W.MP4:  7% /797.154Mi, 586.709Ki/s, 21m33s

.......
.......
2021/12/19 12:52:58 INFO  :
Transferred:   	  631.077 MiB / 813.187 MiB, 78%, 702.382 KiB/s, ETA 4m25s
Transferred:            1 / 2, 50%
Elapsed time:      10m6.8s
Transferring:

                             YR31783W.MP4: 77% /797.154Mi, 702.382Ki/s, 4m25s

.......
.......
Waiting for this update, if you need some help to parse newly formatted data, i would love to try.

Is anyone else having slow download speeds recently with rclone, I have a gigabit connection and used to reach a max of 100mbps in rclone but now I can only reach 15-20mbps when downloading off a google drive mount?

Probably more related to rclone itself..

Waiting for this update, if you need some help to parse newly formatted data, i would love to try.

Thank you - I have already working fix. Testing it now and getting fingers excersised again with coding:)


Merged some changes from master branch

Luca fixed bug in list_by_country.
I fixed a bug in "rake lang".
I added some docs to en.txt to explain process of creating and setting up new language.

Coverage remained the same at 84.64% when pulling 1469f45de8a7a5fe87188d43bd27fadd11b4d26f on pellaea:ror4 into 7eba61fd3cfe5ab359bbf496f4e6ce474b8f4425 on MushroomObserver:ror4.


Update car.capnp

added support for outerBP timeBP delayBP and steerratecostBP

Is this ready to merge?

Is this ready to merge?

Outerbp and time bp should be good. Steerratecostbp and actuatordelaybp not ready.

Needs a new dbc for Corolla


Move vault and transferProxy settings into the Core constructor

First step is to move transfer proxy and vault setup to constructor.

Add constructor on Core
Update unit tests accordingly

Pull Request Test Coverage Report for Build 1321

2 of 2 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build 1315:
0.0%

Covered Lines:
341

Relevant Lines:
341

💛  - Coveralls


Fix getGriefingCollateral tests

Adding multi-collateral vaults to the tests have broken “should getGriefingCollateral” tests for both issue and replace.
It seems the running oracle is interfering with the artificially set exchange rate.
To fix: Look at oracle tests where we use mocks to fix the exchange rate for the scope of the test and re-use that pattern.
Additional note: Look at Greg’s comment here, and check if these tests can be reworked completely

Closed by https://github.com/interlay/interbtc-api/pull/578


Any options to override the Custom TagHelper class with new Custom Class?

Hi,
I have custom TagHelper class (GradeA from ProjectA) with set of properties, but some reasons i need to override my custom class to extend some set of new properties by another custom Tag Helper class in another one project (GradeB from ProjectB).
The GradeA class exists library, already have set of serialization to generate the Html element and script. So i need options to override my GradeA class with new GradeB class.
[HtmlTargetElement("cwd:Grade")]
public class GradeB : GradeA
{
//set of new properties
public override void Process(TagHelperContext context, TagHelperOutput output) {
//context - returns result from GradeA
//output - holds the result returns from GradeA
}
}
`
If there is any options exists for this way of override implementation?
Thanks,

If you want to override your own implementations you have two approaches:

Use TagHelpers from services (services.AddMvc().AddTagHelpersAsServices())and then override the appropriate TagHelper type registration.
@removeTagHelper OldTagHelperTypeName, OldTagHelperAssemblyName and then @addTagHelper NewTagHelperTypeName, NewTagHelperAssemblyName


Upgrade cosmos sdk to latest release.

Description

Motivation and Context

[ ] I have raised an issue to propose this change (required)
[ ] My issue has received approval from the maintainers or lead with the design/approved label

How Has This Been Tested?

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[ ] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I've read the CONTRIBUTION guide
[ ] I have signed-off my commits with git commit -s
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.

I think we may have to backport all the bug fixes I made into the "latest" version of cosmos SDK again

Akash: cosmos lib 0.43.0-rc2 upgrade

[x] Use new ibc repo: https://github.com/cosmos/ibc-go/blob/v1.0.0-rc3/docs/migrations/ibc-migration-043.md
[x] cosmos-sdk v0.43 changelog: https://github.com/cosmos/cosmos-sdk/blob/release/v0.43.x/CHANGELOG.md
[x] Some easy renaming changes (Marshaler -> Codec ones).
[x] sdkutil/broadcast.go: Private func PrepareFactory had to be copied from sdk out to Akash code :(
[x] BaseApp.SetAppVersion() -> BaseApp.SetVersion(). See: https://github.com/cosmos/cosmos-sdk/pull/8897
[x] AppModule now has a new ConsensusVersion() func that needs to be implemented by every akash module. Returning 1 by default for akash modules.
[x] Simulations for every module require a new arg cdc *codec.ProtoCodec in simtypes.NewOperationMsg(). Setting that to nil as all the messages are LegacyMsg which don't seem require the codec based on the implementation code.
[x] ibcclient.NewClientUpdateProposalHandler() -> ibcclient.NewClientProposalHandler. See: https://github.com/cosmos/cosmos-sdk/pull/8673
[ ] Need to correctly set x/audit/keeper/key.go:keyAddrPrefixLen which depended on the sdk.AddrLen which was fixed 20 bytes previously, but can be variable length now. See: https://github.com/cosmos/cosmos-sdk/pull/8363
[ ] Need to handle upgrades properly (in-place, chain, module upgrades). See: https://docs.cosmos.network/v0.43/migrations/chain-upgrade-guide-043.html#

For tendermint, the only changes I made are the following
diff --git a/rpc/client/http/http.go b/rpc/client/http/http.go
index 10fada8a6b..a825d9adec 100644
--- a/rpc/client/http/http.go
+++ b/rpc/client/http/http.go
@@ -737,15 +737,7 @@ func (w *WSEvents) eventListener() {

                        w.mtx.RLock()
                        if out, ok := w.subscriptions[result.Query]; ok {
-                               if cap(out) == 0 {
-                                       out <- *result
-                               } else {
-                                       select {
-                                       case out <- *result:
-                                       default:
-                                               w.Logger.Error("wanted to publish ResultEvent, but out channel is full", "result", result, "query", result.Query)
-                                       }
-                               }
+                               out <- *result
                        }
                        w.mtx.RUnlock()
                case <-w.Quit():
diff --git a/rpc/jsonrpc/client/ws_client.go b/rpc/jsonrpc/client/ws_client.go
index 1c7ade6578..d0cfd33a36 100644
--- a/rpc/jsonrpc/client/ws_client.go
+++ b/rpc/jsonrpc/client/ws_client.go
@@ -20,9 +20,9 @@ import (

 const (
        defaultMaxReconnectAttempts = 25
-       defaultWriteWait            = 0
-       defaultReadWait             = 0
-       defaultPingPeriod           = 0
+       defaultWriteWait            = 15 * time.Second
+       defaultReadWait             = 31 * time.Second
+       defaultPingPeriod           = 15 * time.Second
 )

 // WSClient is a JSON-RPC client, which uses WebSocket for communication with

The changes have not been made in the tendermint version you are targeting and needs to be backported by forking that tag and applying them in our repo.

For cosmos SDK, we made the following changes in our tag v0.41.4-akash-4
diff --git a/x/auth/legacy/v040/migrate.go b/x/auth/legacy/v040/migrate.go
index 363ec7ba82..f819a1a33d 100644
--- a/x/auth/legacy/v040/migrate.go
+++ b/x/auth/legacy/v040/migrate.go
@@ -2,6 +2,7 @@ package v040

 import (
        codectypes "github.com/cosmos/cosmos-sdk/codec/types"
+       multisigtypes "github.com/cosmos/cosmos-sdk/crypto/keys/multisig"
        sdkerrors "github.com/cosmos/cosmos-sdk/types/errors"
        v039auth "github.com/cosmos/cosmos-sdk/x/auth/legacy/v039"
        v040auth "github.com/cosmos/cosmos-sdk/x/auth/types"
@@ -11,9 +12,16 @@ import (
 // convertBaseAccount converts a 0.39 BaseAccount to a 0.40 BaseAccount.
 func convertBaseAccount(old *v039auth.BaseAccount) *v040auth.BaseAccount {
        var any *codectypes.Any
-       // If the old genesis had a pubkey, we pack it inside an Any. Or else, we
-       // just leave it nil.
-       if old.PubKey != nil {
+
+       _, ok := old.PubKey.(*multisigtypes.LegacyAminoPubKey)
+
+       // If pubkey is multisig type, then leave it as nil for now
+       // Ref: https://github.com/cosmos/cosmos-sdk/issues/8776#issuecomment-790552126
+       // Else if the old genesis had a pubkey, we pack it inside an Any.
+       // Or else, we just leave it nil.
+       if ok {
+               // TODO migrate multisig public_keys
+       } else if old.PubKey != nil {
                var err error
                any, err = codectypes.NewAnyWithValue(old.PubKey)
                if err != nil {

This change needs to be backported
diff --git a/x/bank/keeper/keeper.go b/x/bank/keeper/keeper.go
index 1a7d435841..6a1b7fc8e7 100644
--- a/x/bank/keeper/keeper.go
+++ b/x/bank/keeper/keeper.go
@@ -236,7 +236,8 @@ func (k BaseKeeper) SetDenomMetaData(ctx sdk.Context, denomMetaData types.Metada
 }

 // SendCoinsFromModuleToAccount transfers coins from a ModuleAccount to an AccAddress.
-// It will panic if the module account does not exist.
+// It will panic if the module account does not exist. An error is returned if
+// the recipient address is black-listed or if sending the tokens fails.
 func (k BaseKeeper) SendCoinsFromModuleToAccount(
        ctx sdk.Context, senderModule string, recipientAddr sdk.AccAddress, amt sdk.Coins,
 ) error {
@@ -246,6 +247,10 @@ func (k BaseKeeper) SendCoinsFromModuleToAccount(
                panic(sdkerrors.Wrapf(sdkerrors.ErrUnknownAddress, "module account %s does not exist", senderModule))
        }

+       if k.BlockedAddr(recipientAddr) {
+               return sdkerrors.Wrapf(sdkerrors.ErrUnauthorized, "%s is not allowed to receive funds", recipientAddr)
+       }
+
        return k.SendCoins(ctx, senderAddr, recipientAddr, amt)
 }

@@ -387,6 +392,7 @@ func (k BaseKeeper) trackDelegation(ctx sdk.Context, addr sdk.AccAddress, blockT
        if ok {
                // TODO: return error on account.TrackDelegation
                vacc.TrackDelegation(blockTime, balance, amt)
+               k.ak.SetAccount(ctx, acc)
        }

        return nil
@@ -402,6 +408,7 @@ func (k BaseKeeper) trackUndelegation(ctx sdk.Context, addr sdk.AccAddress, amt
        if ok {
                // TODO: return error on account.TrackUndelegation
                vacc.TrackUndelegation(amt)
+               k.ak.SetAccount(ctx, acc)
        }

        return nil

This change has been partially applied in the new version. The changes to the functions trackDelegation & trackUndelegation need to be applied.
diff --git a/x/evidence/types/evidence.go b/x/evidence/types/evidence.go
index 95705cc5b9..fca6126ec3 100644
--- a/x/evidence/types/evidence.go
+++ b/x/evidence/types/evidence.go
@@ -88,7 +88,8 @@ func (e Equivocation) GetTotalPower() int64 { return 0 }
 // FromABCIEvidence converts a Tendermint concrete Evidence type to
 // SDK Evidence using Equivocation as the concrete type.
 func FromABCIEvidence(e abci.Evidence) exported.Evidence {
-       consAddr, err := sdk.Bech32ifyAddressBytes(sdk.Bech32PrefixConsAddr, e.Validator.Address)
+       bech32PrefixConsAddr := sdk.GetConfig().GetBech32ConsensusAddrPrefix()
+       consAddr, err := sdk.Bech32ifyAddressBytes(bech32PrefixConsAddr, e.Validator.Address)
        if err != nil {
                panic(err)
        }

This change has been applied and does not need to be backported

x/auth/legacy/v040/migrate.go: we might as well migrate it, but it's not used anymore (we're past that migration)
x/bank/keeper/keeper.go: IIRC they've done some further refactoring, and this was fixed in another way (cosmos hub was upgraded for this security fix).

const (
	keyAddrPrefixLen = 1 + 20 // TODO: discuss and find a proper fix for this
)

https://github.com/ovrclk/akash/pull/1343/files#diff-d2cc399939acd1af527a3fed7af83beab3993932f4f6e12cd44c307e6cba014eR13
We need to correctly set x/cert/keeper/key.go:keyAddrPrefixLen which depended on the sdk.AddrLen which was fixed to 20 bytes previously, but can be variable length now (20 or 32).
We need to write migration for address if we are storing the address in a module similar to this code. https://github.com/cosmos/cosmos-sdk/blob/0ab5726a7aa5c2d66916b14becb696e6e19a1efb/x/bank/legacy/v043/store.go#L51
I suspect cert module might be storing the address. https://github.com/ovrclk/akash/blob/04e7a7667dd94b5a15fa039e4f7df5c9ad93be4f/x/cert/keeper/key.go#L42
Can someone verify? Also, if there are other modules using address?
Ref:

https://github.com/cosmos/cosmos-sdk/blob/master/docs/architecture/adr-028-public-key-addresses.md
https://github.com/cosmos/cosmos-sdk/issues/8041
https://github.com/cosmos/cosmos-sdk/pull/8363

@arijitAD yes, cert modules uses address and we need migration there.
it seems we need to add extra byte after prefix to identify address length (unless there is a univocal way identifying address length by first 20bytes) and migration should set it as 20bytes key for all existing certificates.

@arijitAD does new address format have prefix defining address length in it?

@arijitAD does new address format have prefix defining address length in it?

From this migration, it seems that 1-byte prefix is allocated for length. https://github.com/cosmos/cosmos-sdk/blob/0ab5726a7aa5c2d66916b14becb696e6e19a1efb/x/bank/legacy/v043/store.go#L55

i see, then we have to set it same way by adding extra byte for address type

@arijitAD yes, cert modules uses address and we need migration there.
it seems we need to add extra byte after prefix to identify address length (unless there is a univocal way identifying address length by first 20bytes) and migration should set it as 20bytes key for all existing certificates.

Let's use type instead of length for the prefix if possible.
Also, if we're going to go and rewrite our indexes, we should use the binary/packed address instead of the base 16 ascii representation representation.

@arijitAD yes, cert modules uses address and we need migration there.
it seems we need to add extra byte after prefix to identify address length (unless there is a univocal way identifying address length by first 20bytes) and migration should set it as 20bytes key for all existing certificates.

Let's use type instead of length for the prefix if possible.
Also, if we're going to go and rewrite our indexes, we should use the binary/packed address instead of the base 16 ascii representation representation.

yah, sorry, i meant to say extra byte as address type but was also curious if new address has any sort of meta information in it to determine it's length. it's not a case anyways and extra byte for type is only option


Bio-Formats 5.7.2 release

See https://trello.com/c/9Y0PGqsf/28-open-pr-against-wwwopenmicroscopyorg and https://github.com/openmicroscopy/bioformats/pull/3002
N.B. 5.7.2 links (docs & downloads) won't work until the release build is run

See https://snoopycrimecop.github.io/www.openmicroscopy.org/2017/11/21/bio-formats-5-7-2.html and https://snoopycrimecop.github.io/www.openmicroscopy.org/bio-formats/downloads/ for staging

Looks good otherwise

Merging ready for release this pm


import  freezes for a number of milliseconds

Environment data

VS Code version: 1.32.3
Extension version: 2019.3.6215
OS and version: Arch Linux - 4.20.8-arch1-1-ARCH
Python version: 3.7.2
Virtual environment: N/A

Expected behaviour
Being able to type import <module> or from <module> import ... without interruptions / freezings
Actual behaviour
Every time I write import <module> it freezes for half a second or so during which I can't type and the cpu spikes for a bit during that time. It bothers the workflow.
Steps to reproduce:
Open a .py and type import <module>

Do you have auto-save turned on by any chance? And are you using Jedi or the language server?

I'm sorry I should have mentioned it. I'm not using the Jedi language server, I'm using the python language server and file.autoSave: off. I've been using the new python language server since it became an option, this started happening after the last major update that I did a few days ago.

@alexdreptu thanks for the clarification! Looks like you're hitting a known issue (see the referenced issue on the language server repo).

Closing in favour of https://github.com/microsoft/python-language-server/issues/864


FlutterWebAuth2.authenticate() is returning SAML consume url when authenticating via Google with 2FA code.

Describe the bug
I'm currently implementing SSO for my company's mobile flutter app. Our service provider's server is an Elixir/Phoenix app using Samly (https://hexdocs.pm/samly/readme.html) to implement SAML. Right now we're internally testing using our Google org as an IdP.
While using Google SSO to login with an authenticator code as the 2FA method, the url being returned from await FlutterWebAuth2.authenticate(...) is the SAML consumer url https://staging.our-app.com/saml/sp/consume/foo-uuid rather than our-app-mobile://?token=foo. Oddly, when using Google Prompts as the 2FA method, the correct url is returned and the app is able to sign in. Our web implementation also has no issues signing in via Google with any 2FA method.
To Reproduce
Steps to reproduce the behavior:

Follow iOS steps to implement the library for a SAML service provider.

final result = await FlutterWebAuth2.authenticate(
        url: 'https://staging.our-app.com/saml/auth/signin/some-uuid',
        callbackUrlScheme: "our-app-mobile",
        preferEphemeral: true
      );

Sign in using Google SSO and 2FA code.
see error parsing the url params
print result and see https://staging.our-app.com/saml/sp/consume/foo-uuid instead of our-app-mobile://?token=foo

Expected behavior
The library should allow our app to sign in regardless of 2FA method.
Screenshots
If applicable, add screenshots to help explain your problem.
Device (please complete the following information!)

Device: IPhone 15 Pro Max
OS: iOS 17.0
flutter_web_auth_2 version: 2.2.1
sdks flutter: ">=3.10.0", dart: ">=3.0.0 <4.0.0"

Additional context
Add any other context about the problem here.
Checklist

[x] I have read and followed the entire troubleshooting guide and it has not provided the solution I need.
[x] I have provided all the information I can (incl. auth URL etc.)

Thanks for the detailed bug report!
However, I think that either Apple or Google is actually at fault here (most probably Apple).
The internal code of flutter_web_auth_2 uses a completion handler which returns the URL that is being provided by the relevant authentication session object (which knows about the callback URL scheme).

Thanks for the quick reply @ThexXTURBOXx. We tried using Azure as an IdP and got the issue regardless of 2FA method, so then we tried the app on Android and were able to sign in with Google and Azure. Like you said, Apple is the most probable culprit.
Do you have any suggestions to work around this issue? I am looking into using an html ("go back to app") landing page, or possibly Universal Links, but was wondering if you had any more guidance to give.
Thanks again,
Tiffany

You're welcome! But that's a good question. You could certainly try setting up Universal links, you could also try whether versions ^3.0.0-alpha.4 of this package work (most certainly they also don't, but it's worth a try)
Otherwise, such a landing page would probably best. It does not even need to show "go back to app", but just needs to redirect by itself to some URL that can be caught by flutter_web_auth_2.

We went down a few paths investigating our SAML service implementation, IdP configs, and the landing page, all to no avail. I also wasn't able to get our app to build with ^3.0.0-alpha.4.
  flutter_web_auth_2:
    dependency: "direct main"
    description:
      name: flutter_web_auth_2
      sha256: "2620dd23521e17c98343e0c5967f3b77456c171e9032622852a9bc1034f8be4e"
      url: "https://pub.dev"
    source: hosted
    version: "3.0.0-alpha.4"
  flutter_web_auth_2_platform_interface:
    dependency: transitive
    description:
      name: flutter_web_auth_2_platform_interface
      sha256: "0a6d726eddd07fe4ef809a4472f5dd92d90526334c49aced517eb4a6f8aa34f7"
      url: "https://pub.dev"
    source: hosted
    version: "3.0.0-alpha.3"
...
sdks:
  dart: ">=3.0.0 <4.0.0"
  flutter: ">=3.10.0"

Launching lib/main.dart on iPhone 15 Pro in debug mode...
Running pod install...                                              4.4s
Running Xcode build...
Xcode build done.                                           39.6s
Failed to build iOS app
Swift Compiler Error (Xcode): Value of optional type 'Bool?' must be unwrapped to a value of type 'Bool'
/Users/tiffany/.pub-cache/hosted/pub.dev/flutter_web_auth_2-3.0.0-alpha.4/ios/Classes/SwiftFlutterWebAuth2Plugin.swift:94:71

Swift Compiler Error (Xcode): Cannot find 'completionHandler' in scope
/Users/tiffany/.pub-cache/hosted/pub.dev/flutter_web_auth_2-3.0.0-alpha.4/ios/Classes/SwiftFlutterWebAuth2Plugin.swift:121:81

Swift Compiler Error (Xcode): 'nil' requires a contextual type
/Users/tiffany/.pub-cache/hosted/pub.dev/flutter_web_auth_2-3.0.0-alpha.4/ios/Classes/SwiftFlutterWebAuth2Plugin.swift:124:39

Could not build the application for the simulator.
Error launching application on iPhone 15 Pro.

We have a fairly vested interest in getting this working, so I'm happy to continue helping test this library as an iOS user.

Thank you very much! Since I do not have any apple device, I cannot check for compile errors and hence rely on information given by others to deal with them.
I will try to push a fix within the next few hours. I will keep you updated.

I have now released 3.0.0-alpha.5. Feel free to report back if it works now :)

Perfect, nice to hear that everything is working fine now!
And thanks for sharing your solution, it might help other people in the future if they have a similar or even the same issue!
Also, thanks for sharing the compile error; I hope that I fixed it in the 3.0.0-alpha.6 release.
I am sorry for needing so many tries - I am trying to get my hands on some Apple hardware, but it just costs too much for my needs (just this package basically - and that's not really worth 300 € or something)

I was finally able to get a macOS VM running (basically, I run an iOS simulator in a macOS QEMU VM running in WSL on my Windows 11 system).
Sadly, my poor PC crashed 4 times already because something was happening which it did not really like (too much power consumption for the power supply, I don't know (?)).
However, no compile errors exist anymore and hence I closed this issue as all of the current issues have been fixed as far as I can tell :)
The new fixes will be available shortly in 3.0.0-alpha.7


Fixed nullability conflict or file parameter for DDLogMessage creation.

New Pull Request Checklist

[x] I have read and understood the CONTRIBUTING guide

[x] I have read the Documentation

[x] I have searched for a similar pull request in the project and found none

[x] I have updated this branch with the latest master to avoid conflicts (via merge from master or rebase)

[x] I have added the required tests to prove the fix/feature I am adding

[x] I have updated the documentation (if necessary)

[x] I have run the tests and they pass

[x] I have run the lint and it passes (pod lib lint)

Pull Request Description
In PR #1280, @(file) could now return nil value. I fixed the nullability conflict by setting file parameter to empty string in that case. Maybe we could use another constant string for that like @"unknown"?

Do you know what [NSString stringWithFormat:@"%s", file] would have returned in this case? Best case would be to restore that behavior.

[NSString stringWithFormat:@"%s", file] should have returned (null) string.

I wonder if we should just make the parameter optional - or on the other hand, if we can enforce it being non-null.
Especially since file should always be there. function might not, but it's hard to have source code, that isn't in some kind of file 🙂

Of course, file is a non null parameter but it is just indicative and you can always initialize a message with file set to nil. For robustness, we must be prepared for that and handle it correctly.

@sushichop I think it is relevant to keep #1280:

[NSString stringWithUTF8String] is faster than [NSString stringWithFormat:]
Adding parameters validation in [DDLogMessage -initWithMessage:] is a good point for robustness of the code

[NSString stringWithUTF8String] is faster than [NSString stringWithFormat:]

I see🙂 I didn't know that.


[PROPOSAL] Document security reviews done before releases

What are you proposing?
In https://github.com/opensearch-project/opensearch-build/issues/2051#issuecomment-1185966560 we communicated that part of the release of .NET client we performed a security review. Add a section to RELEASING.md describing this process, including when it's performed, and for which released components.

https://github.com/opensearch-project/.github/pull/119


Fixing HIP CMake issue

Setting AMDGPU_TARGETS before find_package(HIP) call - fixes HIP issues

@SundarRajan28 same comment as mentioned in MIVisionX. We cannot add this to top level. It is used to set audio flag, but #156 resolves that altogether. Please remove from this file

@kiritigowda @SundarRajan28 I have made the required changes in PR156 itself. Let us close this PR

this should be closed after merging 156 (incorporated in that)

Closing this PR since the change is added in PR #156


Socket.send has two optional arguments in the middle

This is likely the least-bad way to support this.
https://nodejs.org/api/dgram.html#dgram_socket_send_msg_offset_length_port_address_callback

@sdwilsh - why not use overloading? Given the docs specify
socket.send(msg, [offset, length,] port, address[, callback])

we could just write
send(
  msg: Buffer,
  port: number,
  address: string,
  callback?: (err: ?Error, bytes: any) => mixed,
): void
send(
  msg: Buffer,
  offset: number,
  length: number,
  port: number,
  address: string,
  callback?: (err: ?Error, bytes: any) => mixed,
): void


[Monitor] SavedSearchProperties definition is different between swagger and real API response

In swagger, it is defined with lower case, such as category, query which is consistent with the real API response from version 2020-03-01-preview.
https://github.com/Azure/azure-rest-api-specs/blob/master/specification/operationalinsights/resource-manager/Microsoft.OperationalInsights/stable/2020-08-01/SavedSearches.json#L223-L250
"SavedSearchProperties": {
      "properties": {
        "category": {
          "type": "string",
          "description": "The category of the saved search. This helps the user to find a saved search faster. "
        },
        "displayName": {
          "type": "string",
          "description": "Saved search display name."
        },
        "query": {
          "type": "string",
          "description": "The query expression for the saved search."
        },
        "functionAlias": {
          "type": "string",
          "description": "The function alias if query serves as a function."
        },
        "functionParameters": {
          "type": "string",
          "description": "The optional function parameters if query serves as a function. Value should be in the following format: 'param-name1:type1 = default_value1, param-name2:type2 = default_value2'. For more examples and proper syntax please refer to https://docs.microsoft.com/en-us/azure/kusto/query/functions/user-defined-functions."
        },
        "version": {
          "type": "integer",
          "format": "int64",
          "description": "The version number of the query language. The current version is 2 and is the default."
        }
}

but in real API response in version 2020-08-01, it is defined with upper case, such as Category, Query.
{
  "id": "subscriptions/0b1f6471-1bf0-4dda-aec3-cb9272f09590/resourceGroups/azure-cli-test-rg/providers/Microsoft.OperationalInsights/workspaces/myws0230/savedSearches/clitestsavedsearch1234",
  "etag": "W/\"datetime'2021-01-11T09%3A11%3A52.2145523Z'\"",
  "properties": {
    "Category": "cli",
    "DisplayName": "myclitestsa13",
    "Query": "Heartbeat | getschema",
    "Tags": [
      {
        "Name": "a",
        "Value": "b"
      },
      {
        "Name": "c",
        "Value": "d"
      }
    ],
    "FunctionAlias": "myfun",
    "FunctionParameters": "a:string = value",
    "Version": 2
  }
}

So in the latest Python mgmt. SDK (using 2020-08-01), the deserialization will be failed because the case between swagger (lower case) and real API response (Upper case) are different.

This issue was already labeled and triaged.

This issue was already labeled and triaged.


Add an INDEX to the Instance trait

This PR introduces a simple const INDEX: u8; to the Instance trait used for Pallets.
This is useful for getting a minimal unique identifier for different instances, for example using it as a seed to some unique account generation.
The DefaultInstance uses index == 0, so we deprecate Instance0 (which wasn't used anywhere) and instead use instances 1 ..= 16.

bot merge

note that pallet macro doesn't make use of instance trait anymore, instance trait was created in order to give different prefix to each instances, now that prefix is given by PalletInfo, the instance trait had no purpose so it was removed.
In order to have a INDEX identifier in pallet defines with pallet macro I think ppl should add it to the Config trait or we can add one in PalletInfo. (actually adding one in PalletInfo seems the best strategy to me).

FYI this is moving to the next polkadot release very soon, didn't we decide to revert this? cc @s3krit

(It doesn't have a big impact and we can remove it any point anyhow, but I just saw it in the release notes and thought better do it soon than later.)

The Instance trait will be deprecated alongside decl_storage macro.
It is not used in the pallet macro.
So for me it doesn't matter, we are not creating code debt here.
But if a revert PR opens I'll also approve.

will be deprecated alongside decl_storage macro

Then I am also neutral, whatever @shawntabrizi prefers.

i dont think it matters if we keep it.


No such file or directory: 'mmdet/version.py'

Building roi align op... compile.sh: line 6: cd: mmdet/ops/roi_align: No such file or directory Traceback (most recent call last): File "setup.py", line 83, in <module> write_version_py() File "setup.py", line 72, in write_version_py with open(version_file, 'w') as f: IOError: [Errno 2] No such file or directory: 'mmdet/version.py' Building roi pool op... compile.sh: line 13: cd: ../roi_pool: No such file or directory Traceback (most recent call last): File "setup.py", line 83, in <module> write_version_py() File "setup.py", line 72, in write_version_py with open(version_file, 'w') as f: IOError: [Errno 2] No such file or directory: 'mmdet/version.py'
i have
timm                          0.4.9
torch                         1.8.0+cu111
torchaudio                    0.8.0
torchsummary                  1.5.1
torchvision                   0.9.0+cu111
mmcv-full                     1.3.6
mmdet                         2.13.0

The ops have been migrated to MMCV.
So, why you can compile the ops in mmdet 2.13.0?


Package request: iVentoy

Project description
Ventoy, but over PXE! Lets you boot generic ISO's over the network, Windows and Linux.
Metadata

homepage URL: https://www.iventoy.com/en/index.html
source URL: https://github.com/ventoy/PXE
license: GPL2/UBDL? The open source part is based on iPXE.
platforms: Linux for the host at least.

If it is modified from ipxe, can they only release the original code (just taken from one commit) related to it? If it is not, why would they put a copy of the ipxe code in the repo and pretend to be open source?
Anyway I don't recommend this software. Ipxe is already in nixpkgs repo.
Not a blocker for anyone really wants this.


Fix the issue that LastQuery lack MergeNode in some FI

Description
After this change, it is ensured that every LastQueryScanNode will belong to a LastQueryMergeNode in one Fragment Instance, even though there is only one child for the parent LastQueryMergeNode

Coverage increased (+0.02%) to 44.6% when pulling dd273f85aac68fe492d06883d4b0fbe5ced59dda on xingtanzjr/fix_last_merge into 8a8e727a2071118d05a4f4d0727f27082cd69d7a on master.


Simplify gam version

The goal here was to only see pre-releases if it's a force check. This allows pushing "beta-ish" features without notifying everyone. I haven't used it in awhile but would like to keep it so that scheduled checks don't see pre-release versions but forced checks do.

OK


Implement custom variables

For the obvious stuff.
Do this first https://github.com/KaiEkkrin/ThirteenIsh/issues/4 which would give us custom counters.

I think that as part of my changes for https://github.com/KaiEkkrin/ThirteenIsh/issues/4 this is actually already done


WIP tests

I think the docker image in the circle config may need to be changed to something like circleci/node:8-browsers in order for this to run.

@zarsky-broad can you remind me why we're holding merge on this?

Because it's unfinished. At this point, given what @ndbolliger is working on, it can probably be closed.


Enable HRM for the main process

We decided we won't attempt this for now as it's complex and the ROI isn't high enough, pushing to the backlog.

Punting this. HMR seems fragile


Does puppeteer support IPv6?

Just tried loading a page http://[::]:<port>/ and page through the following error:

/node_modules/puppeteer/lib/Page.js:520
Rejected promise returned by test. Reason:
Error {
message: 'net::ERR_ADDRESS_INVALID',
}

Can you share you code? I couldn't reproduce with this code:
const puppeteer = require('puppeteer');

puppeteer.launch().then(async browser => {
  const page = await browser.newPage();
  await page.goto('http://[::]:80/');
  await browser.close();
});


Feat: Permit Multiple Addresses Per Node

Description:
It is now possible to add multiple addresses to the same node to a network via setNetwork() or forNetwork().
The forTestnet() and forMainnet() constructed clients now include all of the addresses for the testnet and mainnet nodes.
Related issue(s):
Fixes #754
Checklist

[X] Documented (Code comments, README, etc.)
[X] Tested (unit, integration tests on previewnet.)

Ignoring Sonarcloud because hardcoded IPs are not an issue here.


Use StandardCharsets constant instead.

Impact

[ ] Bug fix (non-breaking change which fixes expected existing functionality)
[X] Enhancement/New feature (adds functionality without impacting existing logic)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Description
I honestly didn't realize it when I did the PR 3568

Initial/Pre-Review Thoughts
Less magic strings, thanks!
Questions I have:

None

Potential risks:

None

What could make the full review difficult:

Nothing


Fix #209 - clean up zombies of 'onevent' programs

This doesn't fix anything related to zombies, moreover it's going to cause new thread created for each program launched, piling up memory usage.
wait() on Child does effectively the same job as status() does on Command. Be advised not to merge this.
Proper fix should include allowed configurable timeout of execution of the program launched as result of the event, and then delay in thread for that timeout, then try_wait() and:

if Ok(Some(status)) is returned log at Debug level and finish the thread gracefully
if Ok(None) is returned, then the thread should log at Error level the program hasn't been finished in desired time and should make attempt to kill() with proper handling of result and logging; leave the thread in case of failed kill attempt as there is nothing we can do.

Otherwise it's going to mask the problem, not solve it.

A proper fix would use some better communication mechanism than firing up external programs to notify about events. This pull request is a quick fix for the current situation - a complete lack of child handling and piling up zombie processes - while retaining the non-blocking behaviour. When this basic thing is fixed, any improvements are welcome.

Another option is to make a custom Future that calls waitpid with the WNOHANG option, and only resolves when the child exits. Then spawn that onto the main event loop whenever a child process is spawned, and it'll periodically check if it exited.

Closing this in favor of #255


Allow content selection via attribute

With this change it is possible to create a component which can be used as the sidebar
if the component is marked with an ng-sidebar attribute
Fixes #145

Nice, thanks!


[NixIO] huge runtime and file size when saving long channel indexes

It seems that in particular ChannelIndex objects are not saved very efficiently by the IO.
To illustrate this I create minimal neo structures with an increasing number of channels in a ChannelIndex.
import neo
import quantities as pq
import numpy as np

for N in [10, 100, 1000, 10000, 100000]:
    chidx = neo.ChannelIndex(name='chidx',
                             index=np.arange(N),
                             coordinates=np.zeros((N,2))*pq.mm)
    blk = neo.Block()
    blk.channel_indexes = [chidx]
    with neo.NixIO('temp_N{}.nix'.format(N)) as io:
        io.write(blk)

Here, the time it took to create the files and the corresponding file sizes compared to other formats/IOs (Matlab, python pickle):
NIX
N: 10		 000.16s  677 kB
N: 100		 000.88s    5 MB
N: 1000		 008.44s   48 MB
N: 10000	 084.09s  480 MB
N: 100000	 923.70s  2.4 GB

MAT
N: 10		 0.0016s  272 B
N: 100		 0.0014s  272 B
N: 1000		 0.0010s  272 B
N: 10000	 0.0010s  272 B
N: 100000	 0.0029s  272 B

Pickle
N: 10		 0.0010s  1.5 KB
N: 100		 0.0005s  3.7 KB
N: 1000		 0.0006s   25 KB
N: 10000	 0.0011s  240 KB
N: 100000	 0.0042s  2.4 MB

neo: 0.9.0.dev
nixio: v1.5.0b4
I know that it is unusual to have this many channels, but as for example with the new functionalities for imaging data, this issue would become more relevant when interpreting each pixel as a channel, which then easily adds up to 10k.

This has been a long running issue that can't easily be solved (if at all).  I've investigated ways to shrink both the write times and the file sizes in the past.
With file sizes, a big part of what we see here is the size overhead of HDF5 Group objects.  Each index in a ChannelIndex object gets converted to an individual Source object in NIX, which in turn is an HDF5 Group.  Each of these holds the information for a given channel in the ChannelIndex (index, name, ID, coordinates).  The mapping was designed this way because we considered that semantically this was the closest interpretation of what a Neo ChannelIndex means in terms of NIX objects.  We could store these in the metadata of the top-level Source object that's mapped to the ChannelIndex, but even these new metadata properties would be HDF5 Groups at the end of the day (though there's smaller overhead).  A quick test of this solution shows the file size reduces to about half of the original (using your test).  I haven't measured write times.
When it came up in the past, we discussed the possibility of using HDF5 Attributes to represent metadata properties.  This would remove the Group overhead but wouldn't allow us to store things like units alongside a property value.  It's also something that would need to change in the NIX specification so it's a very big decision and it would need major changes in all NIX libraries.
The write time seems to scale with the file size (and object count) so I assume any reduction in the number of objects being created will affect write time as well.  I imagine we could shave off a few seconds with some optimisations in the object conversion, but I don't expect any dramatic reduction there.


Add support for CDI devices to ctr run command

This change adds support for requesting CDI devices to ctr command line.
This means that, assuming the relevant CDI specification exists, the following command can be used to run a container with access to the required device:
crt run --rm -ti --device=nvidia.com/gpu=all {{CONTAINER_ID}}

The requested devices are injected directly into the generated OCI runtime specification as ctr does not use the CRI.
This mirrors how device nodes are handled in that they are resolved locally and the edits are applied to the container config before calling the Create API.
Some minor cleanup / refactoring that makes this addition simpler was also done.
This builds on the work to add CDI support to the containerd server:

https://github.com/containerd/containerd/pull/6654
https://github.com/containerd/containerd/pull/8252

And replaces previous attempts here:

https://github.com/containerd/containerd/pull/6195
https://github.com/containerd/containerd/pull/6204

@mikebrow @AkihiroSuda @dmcgowan could you please take a look.

/cc @AkihiroSuda @dmcgowan

Please consider squashing commits

OK. Let me rebase and do so.

Commits have been squashed. Thanks for the review.

Did this make it into 1.7.2 (released Jun 3, whereas this was merged in May 31)? Or a later 1.7.x version (and if so, which one)?

Or maybe the flags changed? I tried following the example in the OP comment:
root@ubuntu:/home/zededa# ctr run --rm --device=nvidia.com/gpu=all docker.io/library/hello-world:latest helloworld /hello
ctr: error stating device path: stat nvidia.com/gpu=all: no such file or directory

I am moderately sure I configured it correctly in config.toml:
[plugins]
  [plugins."io.containerd.grpc.v1.cri"]
    enable_cdi = true
    cdi_spec_dirs = ["/etc/cdi", "/var/run/cdi"]

although oddly, config dump gives:
  [plugins."io.containerd.grpc.v1.cri"]
    cdi_spec_dirs = ["/etc/cdi", "/var/run/cdi"]
    enable_cdi = false

Either way, can I request that this be part of docs somewhere?

Did this make it into 1.7.2 (released Jun 3, whereas this was merged in May 31)? Or a later 1.7.x version (and if so, which one)?

No, this is for v2.0.
Patch releases do not receive new features.

Ah that explains why I could not get it to work.
What are my options for now, then? Build off master branch?
When is 2.0 ETA?


[Doc] Clarify that either label or job_id are needed to filter from information_schema.load_tracking_logs

Based on reader feedback, this page does not provide enough information to succeed.
What type of PR is this:

[ ] BugFix
[ ] Feature
[ ] Enhancement
[ ] Refactor
[ ] UT
[x] Doc
[ ] Tool

Does this PR entail a change in behavior?

[ ] Yes, this PR will result in a change in behavior.
[x] No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

[ ] Interface/UI changes: syntax, type conversion, expression evaluation, display information
[ ] Parameter changes: default values, similar parameters but with different default values
[ ] Policy changes: use new policy to replace old one, functionality automatically enabled
[ ] Feature removed
[ ] Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

[ ] I have added test cases for my bug fix or my new feature
[ ] This pr needs user documentation (for new or modified features or behaviors)

[ ] I have added documentation for my new feature or new function

[ ] This is a backport pr

Bugfix cherry-pick branch check:

[x] I have checked the version labels which the pr will be auto-backported to the target branch

[x] 3.2
[x] 3.1
[ ] 3.0
[ ] 2.5

@mergify backport branch-3.2 branch-3.1


Google Cloud - Amazon SES Porting

Hi, I really appreciate this image and am now trying to get it working on my Google Cloud VPS.  As you may already know, they block the normal outgoing ports for SMTP.  As I was figuring this out, I ran across this stackof:  http://stackoverflow.com/questions/24834047/amazon-ses-on-google-cloud-computing-instance-vm-using-postfix
Is this possible to include in your .sh?

Hello @rjpalermo1, have you tried switching the docker host port? I mean instead of doing docker run -p 25:25 namshi/smtp, you can try docker run -p 2587:25 namshi/smtp to see if it works out for you.
Thanks.

I'm not the original reporter, but we had a similar issue in our setup: our service discovery tools look at the "internal" port number in the container, and expose that on every machine in our cluster. This allows all machines to connect to : on their host.
We run a separate SMTP daemon for incoming mail on port 25, which works great, but I can't also run this container on port 25 (even if I use "-p 2525:25", our service discovery tools expose "25" on the cluster).
I've submitted a pull request to allow setting the port Exim listens on using something like "--env=PORT=2525" on the "docker run" commandline, which should help handle this problem

Thanks @MartijnVdS for the https://github.com/namshi/docker-smtp/pull/11, good to merge once we remove the expose option in the dockerfile

@rjpalermo1 pls can u test if this PR https://github.com/namshi/docker-smtp/pull/11 resolves this issue

Hi and thank you for your attention.  I am out of country right now and
will be back May 18th.  Will check then and report back.
Best regards and thank you again,
Russ Palermo
Founder | TekTango LLC
office:<PHONE_NUMBER> x700
mobile:<PHONE_NUMBER>
On Tue, May 10, 2016 at 6:26 AM, Oluwaseun Obajobi<EMAIL_ADDRESS>
wrote:

@rjpalermo1 https://github.com/rjpalermo1 pls can u test if this PR #11
https://github.com/namshi/docker-smtp/pull/11 resolves this issue
—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
https://github.com/namshi/docker-smtp/issues/7#issuecomment-218118588


Version and feature matching with daisy

Do you have plans to match daisy version by version?

Is your code base auto generated from daisy or is there much manual effort needed?
Thanks very much for the contribution!

Do you have plans to match daisy version by version?

Good question. There are still a couple of pending changes before I can claim this "done", then we may try something like automated updates.

Is your code base auto generated from daisy or is there much manual effort needed?

It's generated by build.ts, which honestly doesn't do much.

If you go to auto generated, i guess it makes sense to match the version tags from daisy, right?
Are you looking for help with any of the finishing touches?

So I finally got around to trying out this implementation in my demo app.
Unfortunately, it doesn't work, because i am using daisyui full.css from cdn
I assume this is generated via the build job in package.json
Can you imagine to include a build step that will also publish full.css in the format that fits with your unocss preset?
Actually what are the advantages to use the daisy uno preset over the cdn version?

Unfortunately, it doesn't work, because i am using daisyui full.css from cdn

daisyUI's CDN version already have everything compiled, unocss-preset-daisy isn't designed to work with it. It's not an issue with this package either.

Can you imagine to include a build step that will also publish full.css in the format that fits with your unocss preset?

This package can not be consumed as-is, it must be compiled by UnoCSS. I don't see the benefit of including a full.css, unless you want to fetch it and do compile yourself.

Actually what are the advantages to use the daisy uno preset over the cdn version?

The CDN version doesn't allow customizing or selective import, while being 10x large compared to a full build using UnoCSS.

runtime version

I am using the runtime version... And although bigger, i have the opinion that the bloated size can be offset if many developers use the same CDN so that the libs get well cached in the wild.
Runtime compilation with transformer directives could be cool. Thanks for that link.
I am curious how the size of a full.css with all the @apply directives intact will compare to the daisy full.css that is shipping now.
Thanks for the exchange!

the bloated size can be offset if many developers use the same CDN so that the libs get well cached in the wild.

I don't know your target users, but most websites nowadays rarely use public CDNs for libraries other than the most popular ones (jQuery etc.), let alone niche ones like UnoCSS

I am curious how the size of a full.css with all the @apply directives intact will compare to the daisy full.css that is shipping now.

I just added a full build (and a minified one), the latter is 111k and 22.1k after gzipping.

Hi @kidonng I forked this repo and made a quick sync up with daisyui 2.41.0 and when I tried to make a pull request, it seems I can't do so.
I must admit I never really worked with repos including submodules so maybe the issue lies there? Don't know :)
Cheers

I didn't block anything, I was just absent. I'm doing the sync work now.

Good news! Since unocss-preset-daisy 3.0.0, you no longer need this package (@kidonng/daisyui). Instead, just install and upgrade the official daisyui package to keep up-to-date.