Add Description to ResourceDeclaration

Changes
Add Description to ResourceDeclaration

Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:

[ ] Includes tests (if functionality changed/added)
[ ] Includes docs (if user facing)
[ ] Commit messages follow commit message best practices

See the contribution guide for more details.
Double check this list of stuff that's easy to miss:

If you are adding a new binary/image to the cmd dir, please update
the release Task to build and release this image.

Reviewer Notes
If API changes are included, additive changes must be approved by at least two OWNERS and backwards incompatible changes must be approved by more than 50% of the OWNERS, and they must first be added in a backwards compatible way.
Release Notes
we can see description in task resource

test
kaniko.yaml
apiVersion: tekton.dev/v1alpha1
kind: Task
metadata:
  name: kaniko
spec:
  inputs:
    params:
      - name: DOCKERFILE
        description: Path to the Dockerfile to build.
        default: ./Dockerfile
      - name: CONTEXT
        description: The build context used by Kaniko.
        default: ./
      - name: EXTRA_ARGS
        default: ""
      - name: BUILDER_IMAGE
        description: The image on which builds will run
        default: gcr.io/kaniko-project/executor:v0.13.0
    resources:
      - name: source
        type: git
        description: description for git  # added

  outputs:
    resources:
      - name: image
        type: image
        description: description for image # added

  steps:
    - name: build-and-push
      workingdir: /workspace/source
      image: $(inputs.params.BUILDER_IMAGE)
      # specifying DOCKER_CONFIG is required to allow kaniko to detect docker credential
      # https://github.com/tektoncd/pipeline/pull/706
      env:
        - name: DOCKER_CONFIG
          value: /builder/home/.docker
      command:
        - /kaniko/executor
        - $(inputs.params.EXTRA_ARGS)
        - --dockerfile=$(inputs.params.DOCKERFILE)
        - --context=/workspace/source/$(inputs.params.CONTEXT)  # The user does not need to care the workspace and the source.
        - --destination=$(outputs.resources.image.url)
      securityContext:
        runAsUser: 0

apply
$ kubectl apply -f kaniko.yaml

describe
$ kubectl describe task kaniko
Name:         kaniko
Namespace:    default
Labels:       <none>
Annotations:  kubectl.kubernetes.io/last-applied-configuration:
                {"apiVersion":"tekton.dev/v1alpha1","kind":"Task","metadata":{"annotations":{},"name":"kaniko","namespace":"default"},"spec":{"inputs":{"p...
API Version:  tekton.dev/v1alpha1
Kind:         Task
Metadata:
  Creation Timestamp:  2020-01-13T03:44:32Z
  Generation:          1
  Resource Version:    33618597
  Self Link:           /apis/tekton.dev/v1alpha1/namespaces/default/tasks/kaniko
  UID:                 0259500c-35b7-11ea-b47e-42010a9200b8
Spec:
  Workspaces:  <nil>
  Inputs:
    Params:
      Default:      ./Dockerfile
      Description:  Path to the Dockerfile to build.
      Name:         DOCKERFILE
      Type:         string
      Default:      ./
      Description:  The build context used by Kaniko.
      Name:         CONTEXT
      Type:         string
      Default:
      Name:         EXTRA_ARGS
      Type:         string
      Default:      gcr.io/kaniko-project/executor:v0.13.0
      Description:  The image on which builds will run
      Name:         BUILDER_IMAGE
      Type:         string
    Resources:
      Description:  description for git
      Name:         source
      Type:         git
  Outputs:
    Resources:
      Description:  description for image
      Name:         image
      Type:         image
  Steps:
    Command:
      /kaniko/executor
      $(inputs.params.EXTRA_ARGS)
      --dockerfile=$(inputs.params.DOCKERFILE)
      --context=/workspace/source/$(inputs.params.CONTEXT)
      --destination=$(outputs.resources.image.url)
    Env:
      Name:   DOCKER_CONFIG
      Value:  /builder/home/.docker
    Image:    $(inputs.params.BUILDER_IMAGE)
    Name:     build-and-push
    Resources:
    Security Context:
      Run As User:  0
    Working Dir:    /workspace/source
Events:             <none>

issue
https://github.com/tektoncd/pipeline/issues/1389

/ok-to-test
Addin a unit/yaml test should be pretty easy, isnt it ?

@chmouel Thank you for review! Are you referencing run_yaml_tests and is what I have to do adding fields to example/taskruns/optional-resources (and fixing conflicts) ?

yes, i mean adding a taskrun example with a pipelineresource which has a description in this directory :
https://github.com/tektoncd/pipeline/tree/3ae789c25831b3240721437d6570b58097cd55d9/examples/taskruns
CI will run those example to make sure it can supports it.

@chmouel Thank you! added


Windows 10: Device does not support this function

The problem
examples/server.py does not work on an ASUS BT400 BLE dongle
Reproduction
On windows 10: ..\examples\server.py
Expected behavior
I hop server.py willl work, allowing to understand how to proceed.
Screenshots
Z:\Github\WouterJD\bless\wd-StartUp>..\examples\server.py
DEBUG:asyncio:Using proactor: IocpProactor
DEBUG:bless.backends.winrt.server:Creating a new service with uuid: A07498CA-AD5B-474E-940D-16F1FBE7E8CD
DEBUG:bless.backends.winrt.server:Adding service to server with uuid A07498CA-AD5B-474E-940D-16F1FBE7E8CD
DEBUG:__main__:51ff12bb-3ed8-46e5-b4f9-d64e2fec021b:
Traceback (most recent call last):
  File "Z:\Github\WouterJD\bless\examples\server.py", line 93, in <module>
    loop.run_until_complete(run(loop))
  File "C:\Users\Wouter Dubbeldam\AppData\Local\Programs\Python\Python38\lib\asyncio\base_events.py", line 612, in run_until_complete
    return future.result()
  File "Z:\Github\WouterJD\bless\examples\server.py", line 79, in run
    await server.start()
  File "\\lt-entertain\cdisk$\github\wouterjd\bless\bless\backends\winrt\server.py", line 91, in start
    service.service_provider.start_advertising(adv_parameters)
**OSError: [WinError -2147024580] Het apparaat ondersteunt de opdrachtfunctie niet**

Desktop (please complete the following information):

OS: Windows 10

Additional context
No additional information, using server.py out of the box.
Question though: at what moment does bless search-and-find a BLE-dongle and what messages/errors can be expected if there is no dongle or an incompatible one?

Thanks @WouterJD,
What is your goal for using the dongle? Are you wanting to connect to other devices through it? For example, perhaps you're interested in connecting to a keyboard, mouse, phone, etc.? In which case you'd want to use bleak.
Bless uses WinRT to access windows API to broadcast bluetooth services that are searched for and picked up by other devices.
It's an interesting question though, I haven't investigated using a dongle to broadcast over if that is what you're attempting to do. Bless attempts to access your machine's bluetooth hardware here
One place to start looking is to determine if WinRT can detect the device for advertising.

Hi @kevincar,
I want to create a trainer service to communicate with trainer software; advertise a Tacx trainer and then communicate with Zwift.
To understand bless, I execute examples/server.py which should - if I understand correctly - should educate me how to build such a server.
I started with Std Bluetooth on my laptop, but other windows implementations (node.js) require a separate dongle.
Both give same result.
PS. What OS do you primarily work with?

I will study the links provided asap (today)

Should e server.py run out-of-the-box?

One place to start looking is to determine if WinRT can detect the device for advertising

I've checked the links but did not find an answer yet.
Physically the devices are correct, I can use them with node.js through the zadig device driver.
On the system where I test, I use the std builtin hw OR the BLE dongle, which all results in the same error:
"OSError: [WinError -2147024580]"

@kevincar Raising an issue on bleak https://github.com/hbldh/bleak/issues/739 did not help either.
@dlech says: "I would suspect that the error message is telling you that the hardware is not capable of being a peripheral."
Central question is (if I may ask): on what systems do you expect (did you test) examples/server.py?

@WouterJD

I want to create a trainer service to communicate with trainer software; advertise a Tacx trainer and then communicate with Zwift.

So to clarify, Zwift acts as the central device and Tacx acts as the peripheral device and you're attempting to use bless to broadcast/advertize Tacx from a Windows machine using the ASUS BT400 BLE dongle? You need to ensure that the ASUS BT400 is capable of broadcasting/advertising.
According to this, the ASUS BT400 is Bluetooth 4.0 compatible. It is unlikely this device is capable of what you want. I ran into this issue quite a bit 1-2 summers ago. Bluetooth Peripheral role support for seems to be a rather recent feature for laptops and desktop computers, as of Bluetooth 4.2. Checkout this  to see if your bluetooth adapter supports the peripheral role. As this stackover flow answer suggests, it's best to ensure that your device is Bluetooth 5.0 compatible.

Should e server.py run out-of-the-box? on what systems do you expect (did you test) examples/server.py?

Yes, if you're running on a system with peripheral role support. I've tested Bless on macOS, Windows 10, and Linux (Ubuntu on Raspberry Pi 4) and the examples/server.py run fine as long as bless is installed.
One way to check that you're actually able to do what you want is to try and run the following code on your windows machine.
# requires pip install winrt

import asyncio

from winrt.windows.devices.bluetooth import BluetoothAdapter

async def main():
    adapter = await BluetoothAdapter.get_default_async()
    print(adapter.is_peripheral_role_supported)

asyncio.run(main())

It's possible, though I haven't tested, that if your primary bluetooth adapter on your laptop does not support the peripheral role, that you can potentially access a dongle that does support it by looking up the device identifier under device manager. Then you can modify the code as such
# requires pip install winrt

import asyncio

from winrt.windows.devices.bluetooth import BluetoothAdapter

async def main():

    # Example ID
    id = "\\\\?\\USB#VID_8087&PID_0026#5&e4436ea&0&14#{92383b0e-f90e-4ac9-8d44-8c2d0d0ebda2}"
    adapter = await BluetoothAdapter.from_id_async(id)
    print(adapter.is_peripheral_role_supported)

asyncio.run(main())

Thanks for staying with me in this; I will do the tests as soon as I can.
Currently, FortiusAnt has a BLE-implementation using node.js which uses the zadig device driver and that works; hence the device itself is capable of doing the job....
I'll be back!

Looking at the dependency tree for your project it's likely that node is able to do what you need because of this line here.
Notice how that in this case, the code is connecting directly to a USB device and not the native Bluetooth hardware.
Unfortunately, Bless doesn't yet support BLE from USB devices, but that would be a great feature to potentially add.

@kevincar thanks for this analysis.
Initially, FortiusAnt broadcasts ANT+ devices and because of upcoming importance of BLE, especially because ANT+ dongles are expensive and hard-to-come-by BLE has been added.
Since there is no python library to access Bluetooth, a node.js server is built. This requires a complex installation.
I was pointed to your library, which seemed to provide a solution. Looking at the provided functions, that is the case.
The standard Bluetooth devices cannot be used by node.js through the zadig driver) but the Asus dongle can be used.
What would be required for bless to use the Asus dongle?

Yes, if you're running on a system with peripheral role support. I've tested Bless on macOS, Windows 10, and Linux (Ubuntu on Raspberry Pi 4) and the examples/server.py run fine as long as bless is installed.

Apart from the reason why, this is all I try: run server.py.
So: what do I miss on my windows 10 system?

# requires pip install winrt

import asyncio

from winrt.windows.devices.bluetooth import BluetoothAdapter

async def main():
    adapter = await BluetoothAdapter.get_default_async()
    print(adapter.is_peripheral_role_supported)

asyncio.run(main())

Returns False for both the builtin bluetooth device as the ASUS BLE dongle

Reading the microsoft docs GATT and GAP roles were introduced in Windows 10 version 1703.
My system is:
Windows 10 Pro
Version 20H2
Installation date 29-12-2020
Build of OS 19042.1466
Experience Windows feature experience pack 120.2212.3920.0
My system is:
20H2 is newer than the mentioned 1703, so that should not be the case either

Extending the sample code as follows

# requires pip install winrt

import asyncio

from winrt.windows.devices.bluetooth import BluetoothAdapter

async def main():
    adapter = await BluetoothAdapter.get_default_async()
    # https://docs.microsoft.com/en-us/uwp/api/windows.devices.bluetooth.bluetoothadapter?view=winrt-22000
    print("are_classic_secure_connections_supported",       adapter.are_classic_secure_connections_supported)
    print("are_low_energy_secure_connections_supported",    adapter.are_low_energy_secure_connections_supported)
    print("bluetooth_address",                              adapter.bluetooth_address)
    print("device_id",                                      adapter.device_id)
    print("is_advertisement_offload_supported",             adapter.is_advertisement_offload_supported)
    print("is_central_role_supported",                      adapter.is_central_role_supported)
    print("is_classic_supported",                           adapter.is_classic_supported)
    #print("is_extended_advertising_supported",             adapter.is_extended_advertising_supported)
    print("is_low_energy_supported",                        adapter.is_low_energy_supported)
    print("is_peripheral_role_supported",                   adapter.is_peripheral_role_supported)
    #print("max_advertisement_data_length",                 adapter.max_advertisement_data_length)

asyncio.run(main())

**Produces for the Builtin Bluetooth device:**
are_classic_secure_connections_supported=False
are_low_energy_secure_connections_supported=True
bluetooth_address=9064778070595
device_id=\\?\USB#VID_0A5C&PID_21E6#083E8EE07A43#{92383b0e-f90e-4ac9-8d44-8c2d0d0ebda2}
is_advertisement_offload_supported=False
is_central_role_supported=True
is_classic_supported=True
is_low_energy_supported=True
is_peripheral_role_supported=False

And for the ASUS BT400:
are_classic_secure_connections_supported=False
are_low_energy_secure_connections_supported=True
bluetooth_address=102200636312728
device_id=\\?\USB#VID_0B05&PID_17CB#5CF3709F8C98#{92383b0e-f90e-4ac9-8d44-8c2d0d0ebda2}
is_advertisement_offload_supported=False
is_central_role_supported=True
is_classic_supported=True
is_low_energy_supported=True
is_peripheral_role_supported=False

which is equal for both devices (apart from the address and id)

According to this, the ASUS BT400 is Bluetooth 4.0 compatible. It is unlikely this device is capable of what you want. I ran into this issue quite a bit 1-2 summers ago. Bluetooth Peripheral role support seems to be a rather recent feature for laptops and desktop computers, as of Bluetooth 4.2. Checkout this to see if your bluetooth adapter supports the peripheral role. As this stack overflow answer suggests, it's best to ensure that your device is Bluetooth 5.0 compatible.

Very good advice; I have ordered a "Vues Bluetooth 5.0 USB Adapter - Bluetooth Dongle - Audio Receiver - Transmitter - Bluetooth ontvanger - Windows 10 / 8.1 / 8/7 / XP" which by reviews is confirmed to be a Bluetooth 5.0 adapter.
[How node.js manages to make the ASUS BT400 work will remain their secret]
I'll be back as soon as I have tested the new adapter.

It's best to ensure that your device is Bluetooth 5.0 compatible

I have received the mentioned dongle and it works.
Sorry for having bothered so much; I learned a lot in the meantime.
Thanks for patience and support


Do not append duplicated lines

Hi @trinhngocthuyen
First of all I want to thank you for this plugin. It saved me a lot of time and gave me a kick start with my Cocoapods to SPM migration.
When I was trying to add a dynamic SPM package as a dependency for some targets some lines where added to *.xcfilelist files every pods install run. This PR fixes that edge case.

@ixrevo Thank you for using the plugin and for the PR.
I'd love to know more about this issue.
Actually, the current example project does have a dynamic SPM product (SnapKit-Dynamic).
I'm trying to reproduce the issue from my end by running pod install multiple times but the xcfilelist's contents do not seem duplicated. I'm referring to Pods/Target Support Files/Pods-EX/Pods-EX-frameworks-Debug-input-files.xcfilelist btw.
For the record, CocoaPods overwrites xcfilelists upon each installation. So their contents should not be affected by previous installations.
I'm wondering whether there's a sample project that demonstrates this issue.
Thank you!

Hi there. I'm closing this PR as it's no longer in use. Thank you!


FFI example not working as given in documentation

Description
I am trying to create a custom C extension for JAX and was trying out the example given in the documentation. But when I try to run the example, I get the following error:
jax.errors.SimplifiedTraceback: For simplicity, JAX has removed its internal frames from the traceback of the following exception. Set JAX_TRACEBACK_FILTERING=off to include these.

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "/home/test/test.py", line 54, in <module>
    np.testing.assert_allclose(rms_norm(x), rms_norm_ref(x), rtol=1e-5)
  File "/home/test/test.py", line 35, in rms_norm
    return jex.ffi.ffi_call(
  File "/usr/local/lib/python3.10/dist-packages/jax/_src/extend/ffi.py", line 240, in ffi_call
    results = ffi_call_p.bind(
  File "/usr/local/lib/python3.10/dist-packages/jax/_src/core.py", line 439, in bind
    return self.bind_with_trace(find_top_trace(args), args, params)
  File "/usr/local/lib/python3.10/dist-packages/jax/_src/core.py", line 443, in bind_with_trace
    out = trace.process_primitive(self, map(trace.full_raise, args), params)
  File "/usr/local/lib/python3.10/dist-packages/jax/_src/core.py", line 949, in process_primitive
    return primitive.impl(*tracers, **params)
  File "/usr/local/lib/python3.10/dist-packages/jax/_src/dispatch.py", line 88, in apply_primitive
    outs = fun(*args)
jaxlib.xla_extension.XlaRuntimeError: INTERNAL: Wrong number of attributes: expected 1 but got 2

System info (python version, jaxlib version, accelerator, etc.)
An NVIDIA GPU may be present on this machine, but a CUDA-enabled jaxlib is not installed. Falling back to cpu.
jax:    0.4.33
jaxlib: 0.4.33
numpy:  2.1.1
python: 3.10.12 (main, Sep 11 2024, 15:47:36) [GCC 11.4.0]
jax.devices (1 total, 1 local): [CpuDevice(id=0)]
process_count: 1
platform: uname_result(system='Linux', node='027b41159048', release='6.8.0-40-generic', version='#40~22.04.3-Ubuntu SMP PREEMPT_DYNAMIC Tue Jul 30 17:30:19 UTC 2', machine='x86_64')
$ nvidia-smi
Fri Oct  4 18:19:24 2024
+---------------------------------------------------------------------------------------+
| NVIDIA-SMI 535.183.01             Driver Version: 535.183.01   CUDA Version: 12.2     |
|-----------------------------------------+----------------------+----------------------+
| GPU  Name                 Persistence-M | Bus-Id        Disp.A | Volatile Uncorr. ECC |
| Fan  Temp   Perf          Pwr:Usage/Cap |         Memory-Usage | GPU-Util  Compute M. |
|                                         |                      |               MIG M. |
|=========================================+======================+======================|
|   0  NVIDIA TITAN X (Pascal)        Off | 00000000:01:00.0  On |                  N/A |
| 33%   57C    P0              62W / 250W |   3731MiB / 12288MiB |      7%      Default |
|                                         |                      |                  N/A |
+-----------------------------------------+----------------------+----------------------+
+---------------------------------------------------------------------------------------+
| Processes:                                                                            |
|  GPU   GI   CI        PID   Type   Process name                            GPU Memory |
|        ID   ID                                                             Usage      |
|=======================================================================================|
+---------------------------------------------------------------------------------------+

Thanks for this report! That example is being run as part of CI so I expect there's something different in your setup. Can you share the exact C++ and Python code that you're running?

Thanks the example helps! I tried to copy the parts from the documentation in order.
// rms_norm.cc
#include <functional>
#include <numeric>
#include <utility>

#include "xla/ffi/api/c_api.h"
#include "xla/ffi/api/ffi.h"

namespace ffi = xla::ffi;

#include <cmath>
#include <cstdint>

float ComputeRmsNorm(float eps, int64_t size, const float *x, float *y) {
  float sm = 0.0f;
  for (int64_t n = 0; n < size; ++n) {
    sm += x[n] * x[n];
  }
  float scale = 1.0f / std::sqrt(sm / float(size) + eps);
  for (int64_t n = 0; n < size; ++n) {
    y[n] = x[n] * scale;
  }
  return scale;
}

// A helper function for extracting the relevant dimensions from `ffi::Buffer`s.
// In this example, we treat all leading dimensions as batch dimensions, so this
// function returns the total number of elements in the buffer, and the size of
// the last dimension.
template <ffi::DataType T>
std::pair<int64_t, int64_t> GetDims(const ffi::Buffer<T> &buffer) {
  auto dims = buffer.dimensions();
  if (dims.size() == 0) {
    return std::make_pair(0, 0);
  }
  return std::make_pair(buffer.element_count(), dims.back());
}

// A wrapper function providing the interface between the XLA FFI call and our
// library function `ComputeRmsNorm` above. This function handles the batch
// dimensions by calling `ComputeRmsNorm` within a loop.
ffi::Error RmsNormImpl(float eps, ffi::Buffer<ffi::DataType::F32> x,
                       ffi::Result<ffi::Buffer<ffi::DataType::F32>> y) {
  auto [totalSize, lastDim] = GetDims(x);
  if (lastDim == 0) {
    return ffi::Error(ffi::ErrorCode::kInvalidArgument,
                      "RmsNorm input must be an array");
  }
  for (int64_t n = 0; n < totalSize; n += lastDim) {
    ComputeRmsNorm(eps, lastDim, &(x.typed_data()[n]), &(y->typed_data()[n]));
  }
  return ffi::Error::Success();
}

// Wrap `RmsNormImpl` and specify the interface to XLA. If you need to declare
// this handler in a header, you can use the `XLA_FFI_DECLASE_HANDLER_SYMBOL`
// macro: `XLA_FFI_DECLASE_HANDLER_SYMBOL(RmsNorm)`.
XLA_FFI_DEFINE_HANDLER_SYMBOL(
    RmsNorm, RmsNormImpl,
    ffi::Ffi::Bind()
        .Attr<float>("eps")
        .Arg<ffi::Buffer<ffi::DataType::F32>>()  // x
        .Ret<ffi::Buffer<ffi::DataType::F32>>()  // y
);

Was able to generate librms_norm.so and install it.
import jax
import jax.numpy as jnp

def rms_norm_ref(x, eps=1e-5):
  scale = jnp.sqrt(jnp.mean(jnp.square(x), axis=-1, keepdims=True) + eps)
  return x / scale

import ctypes
from pathlib import Path
import jax.extend as jex

path = next(Path("ffi").glob("librms_norm*"))
rms_norm_lib = ctypes.cdll.LoadLibrary(path)
jex.ffi.register_ffi_target(
    "rms_norm", jex.ffi.pycapsule(rms_norm_lib.RmsNorm), platform="cpu")

import numpy as np

def rms_norm(x, eps=1e-5):
  # We only implemented the `float32` version of this function, so we start by
  # checking the dtype. This check isn't strictly necessary because type
  # checking is also performed by the FFI when decoding input and output
  # buffers, but it can be useful to check types in Python to raise more
  # informative errors.
  if x.dtype != jnp.float32:
    raise ValueError("Only the float32 dtype is implemented by rms_norm")

  # In this case, the output of our FFI function is just a single array with the
  # same shape and dtype as the input. We discuss a case with a more interesting
  # output type below.
  out_type = jax.ShapeDtypeStruct(x.shape, x.dtype)

  return jex.ffi.ffi_call(
    # The target name must be the same string as we used to register the target
    # above in `register_custom_call_target`
    "rms_norm",
    out_type,
    x,
    # Note that here we're use `numpy` (not `jax.numpy`) to specify a dtype for
    # the attribute `eps`. Our FFI function expects this to have the C++ `float`
    # type (which corresponds to numpy's `float32` type), and it must be a
    # static parameter (i.e. not a JAX array).
    eps=np.float32(eps),
    # The `vmap_method` parameter controls this function's behavior under `vmap`
    # as discussed below.
    vmap_method="broadcast_fullrank",
  )

# Test that this gives the same result as our reference implementation
x = jnp.linspace(-0.5, 0.5, 15).reshape((3, 5))
np.testing.assert_allclose(rms_norm(x), rms_norm_ref(x), rtol=1e-5)

Hope this helps answer the issue. There are decorators on top of the example you provided so maybe the documentation has not been updated?

Oh I see what's happening here! The decorators are actually a red herring.
The issue is actually the vmap_method parameter. That was only added in JAX v0.4.34, so in the earlier version that you're using the vmap_method input is being interpreted as an attribute that you want to pass to the FFI handler. So, in JAX v0.4.33, you should use vectorized=True instead of vmap_method, although that behavior is deprecated going forward.
Hope this helps!

That was the issue. Thanks!


How to contribute to hosts file?

Hi, I would like to add 280 more subdomains of cdninstagram.com to this project's sources, I have already added them to my personal hosts file. How could I contribute to this project so that these might be added to the generator sources when a user selects the social extension?

Hi @me-ch I'm guessing that cdninstagram.com is social media-related?
If so, then you can contact one of our social media curated sources.  Either @Sinfonietta here or @tiuxo here.
Thanks!
Closing.


stable = Istio 1.5 + Helm

stable = Istio 1.5 + Helm
latest = Istio 1.5 + istioctl

/assign @JRBANCEL
I'd like to keep this running over night to see if things are good.

Both are passing. Retrying one more time.
/test pull-knative-sandbox-net-istio-integration-tests
/test pull-knative-sandbox-net-istio-latest

/lgtm

/hold

As soon as we cut 0.17 I will update Serving to use this.
One other thing I notice is that in knative-sandbox/net-istio we use parallel 12 while having no default parallel in knative/serving e2e.

/unhold


Python 3.9.7x64 and gVim 8.2.3582_x64

Steps to reproduce
I have:
+python/dyn
+python3/dyn
DDYNAMIC_PYTHONDLL="python27.dll"
DDYNAMIC_PYTHONDLL="python39.dll"
And C:\Python39 as well as C:\Python27 in the PATH.
Also PYTHONPATH and PYTHON3_HOME pointing to the same path.
let g:python3_host_prog="C:/Python39"
set pythonthreedll="C:/Python39/python39.dll"
Is in my .vimrc
Still
echo has("python") gives 1, but
echo has("python3") gives 0
Expected behaviour
I was trying to enable Youcompleteme, which was compiling fine, but finds no python when getting startet.
Any hint, that the two versions in the title are maybe not compatible?
What's the best version to use?
Operating system
Windows10
Version of Vim
gVim 8.2.3582_x64
Logs and stack traces
No response

Does it look different if you first do:
echo has("python3")
echo has("python")

Did you get the binary from vim-win32-installer, or compile it by yourself?
Do you use the 64-bit version of python3?

@chrisbra  what do you mean, if i do the python3 first? That gives the same, why should it be different? Possible reason?
@k-takata Yes the binary, and yes python3 is 64bit.
I will try a binary from tuxproject next, but I'm still curious if this is really the problem of compatibility.

I have asked, because on some systems, it won't be possible to load both python and python3 into the same process. See e.g. this answer on stackoverflow: https://vi.stackexchange.com/questions/779/how-do-i-get-vim-to-be-able-to-run-both-python-and-python3-on-a-linux-system-in/2231#2231
I am not sure, what the situation is on Windows, so I figured asking for a different order is the easiest way to rule that one out :)
So do you need both python for Vim? Can you say where you downloaded both python versions from? BTW: I just noticed:

let g:python3_host_prog="C:/Python39"
set pythonthreedll="C:/Python39/python39.dll"

please use :let &pythonthreedll="<path>". When using :setthe"is considered a comment character. So please from within your vim, check the output of:set pythondll? pythonthreedll? ` and make sure it points to the correct dll.

set => let g:
Did the trick, thanks for that one. I should have seen that, I was just copy pasting it without thinking :-(
Now ycm shows up, but there are still errors.
About the two installs. I'm unshure if vim still needs python2 for some reason.
I for myself don't. So is it still, that python should point to python27 and python3 to python39?
But hey so far this can be closed, thanks much for lending me a third eye ;-)


[JENKINS-27013] Added support for the Jenkins credentials plugin

This PR adds support for the Jenkins credentials plugin

Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests

@vimil  Please review this when you get a chance

@jamesggraf
The PR does nothing if I understand correctly.
You just inject the mandatory dependency to the plugin, but don't use it in your code. What do you try to achieve?

@oleg-nenashev In order to utilize classes from the credentials plugin in my Groovy scripts, I needed to add this dependency. I was going to bundle this with this change: https://github.com/jenkinsci/extended-choice-parameter-plugin/pull/13 but I decided to separate this out since the groovy/classloading change in PR #13 can be merged separately from this

In order to utilize classes from the credentials plugin in my Groovy scripts

Just install Groovy/Credentials plugins to your installation.
There's no need to add plugin dependencies if you use plugins in your personal scripts

@oleg-nenashev Again, this change only makes sense in the context of PR #13

@oleg-nenashev And of course, I am open to suggestions on how to handle PR #13 without changing the plugin class loading strategy

:-1:  if you need any plugin to be available in jenkins - then install it in your jenkins.


added skillinator +3

updated skillinator, jamie's dev shed, & a few other things
Changes proposed in this pull request

added skillinator
added indian skill store
added dev link for echo show
added java & ruby SDKs

„Be quick, but don't hurry“ - John Wooden
@GetStoryline/awesome-alexa/

Thanks for the submission, @TheDreamSaver! I've left a couple of comments, I'll merge it as soon as you fix them :)

updated them.


11/12/2020 Publish

Docs Build status updates of commit b50758f:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

2017-03-09-profile/docs-ref-autogen/ext/azure-cli-ml/ml/datastore.yml
:white_check_mark:Succeeded
View (azure-cli-2017-03-09-profile)

2018-03-01-hybrid/docs-ref-autogen/ext/azure-cli-ml/ml/datastore.yml
:white_check_mark:Succeeded
View (azure-cli-2018-03-01-hybrid)

2019-03-01-hybrid/docs-ref-autogen/ext/azure-cli-ml/ml/datastore.yml
:white_check_mark:Succeeded

latest/docs-ref-autogen/acr/scope-map.yml
:white_check_mark:Succeeded
View (azure-cli-latest)

latest/docs-ref-autogen/acr/token.yml
:white_check_mark:Succeeded
View (azure-cli-latest)

latest/docs-ref-autogen/ams/asset.yml
:white_check_mark:Succeeded
View (azure-cli-latest)

latest/docs-ref-autogen/ext/azure-cli-ml/ml/datastore.yml
:white_check_mark:Succeeded
View (azure-cli-latest)

latest/docs-ref-autogen/mariadb/server.yml
:white_check_mark:Succeeded
View (azure-cli-latest)

latest/docs-ref-autogen/mysql/flexible-server.yml
:white_check_mark:Succeeded
View (azure-cli-latest)

latest/docs-ref-autogen/mysql/server.yml
:white_check_mark:Succeeded
View (azure-cli-latest)

latest/docs-ref-autogen/postgres/flexible-server.yml
:white_check_mark:Succeeded
View (azure-cli-latest)

latest/docs-ref-autogen/postgres/server.yml
:white_check_mark:Succeeded
View (azure-cli-latest)

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel


listing: add i18n labels for datarange filters

PR needs rebase.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.


Update Activity - API Check, and other Bug Fix

Overview
Be able to edit a submitted record if it's your own record OR if you are an admin along with some refactoring.
This PR includes the following proposed change(s):

Server side check where the activity is grabbed from the database to check with the authContext based on the preferred username and created by name
Commented out code where you can click on map to draw a small invisible box because the popup disrupts the activity drawing on the map

Does not remove the feature to click on specific IAPP Marker and should be added to when clicking on activity marker

Type of change

[x] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[x] Refactoring / Documentation
[ ] Version change

if your change is a breaking change, please add breaking change label to this PR
How Has This Been Tested?
Please describe the tests that you ran to verify your changes.
Screenshots
Thrown error when not authorized to update (save) record

This was tested by reversing the requirements for throwing an error
e.g. if (!admin) becomes if (admin) for testing purposes

Checklist:

[ ] My code follows the style guidelines of this project
[ ] I have performed a self-review of my own code
[ ] I have made corresponding changes to the documentation
[ ] New and existing unit tests pass locally with my changes

Changes in new branch based on more recent version of dev


Should command names have underscores, or dashes?

pestle.phar magento2:generate:ui:add-column-actions

vs.
pestle.phar magento2:generate:controller_edit_acl

My opinion: dashes.
I'm unfamiliar with the layout of other locales, but an en_US keyboard requires shift for _ but not for -.  - is the easier to type glyph in that case.

My opinion: -

As dashes don't require modifier key to use, I prefer dashes.
Underscores make more sense to me for class paths, as paths are written with capitals to separate folders, so shift key is already pressed in preparation for next capital letter.

Thanks all -- poll come out to be 70% in favor of dashes.  For pestle the pestle:generate_command command will default to generating commands with dashes, but internally we'll normalize the command names so those already with underscores (like pestle:generate_command itself) are interpreted as (pestle:generate-command).  This will let the other 30% do what they want without too much trauma.

OK, dash/underscore interchangeableness happened here
https://github.com/astorm/pestle/commit/106c0c484a4a5c79c23c7965efafb1b73a2f3bb1

Alright, we've converted all the _ command names to - command names, but old underscore names will still be recgonized.  One downside of our approach is something like pulsestorm:md_to-say -- a command that mixes dashes and underscores is not supported.  I'm OK with that weirdness not being possible, but have opened a new issue for adding a warning if that situation comes up.
https://github.com/astorm/pestle/issues/217


install issue

Laravel Version:5.3.*
Voyager Version:^0.10.10
PHP Version: 7.0.9
Database Driver & Version: mysqlnd 5.0.12-dev & Ver 15.1 Distrib 10.1.16-MariaDB

Description:
when i want to upgrade voyager version and edit composor to new version i run the php artisan voyager:install --with-dummy
result with :
[Illuminate\Database\QueryException]
SQLSTATE[42S22]: Column not found: 1054 Unknown column 'generate_permissions' in 'data_types' (SQL: alter table data_types add server_side tinyint not null default '
0' after generate_permissions)
[Doctrine\DBAL\Driver\PDOException]
SQLSTATE[42S22]: Column not found: 1054 Unknown column 'generate_permissions' in 'data_types'
[PDOException]
SQLSTATE[42S22]: Column not found: 1054 Unknown column 'generate_permissions' in 'data_types'
Steps To Reproduce:
1- php artisan voyager:install --with-dummy

Does this also happens on v0.10.13?

Have you already check in check table  data_types and check whether column, server_side exists?
If that is exist, can you drop that column and run
php artisan migrate

Closing due to inactivity.


[HOLD for payment 2024-09-27][Search v2.3] - Same saved search can be created at most twice

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 9.0.35-0
Reproducible in staging?: Y
Reproducible in production?: N/A - new feature, doesn't exist in prod
Email or phone of affected tester (no customers<EMAIL_ADDRESS>Issue reported by: Applause Internal Team
Action Performed:

Go to staging.new.expensify.com
Go to Search.
Click Filters.
Select Merchant and add search query (issue is reproducible with Merchant filter and not Date, Total filter).
Click Save search.
Click 3-dot menu next to the saved search > Rename.
Enter a custom name and save it.
Click Filters > Save search.
Note that it creates another saved search.
Rename the second saved search.
Go back to the first saved search.
Click Filters > Save search.
Note that it does not create a new search but changes the name of second saved search back to default.

Expected Result:
In Step 9, it will not create another same saved search because the filters are not modified.
Actual Result:
In Step 9, it creates another same saved search when the filters are not modified.
If Step 9 is the correct behavior, Step 13 shows a different result because user cannot create the same third saved from the first saved search as it changes the name of second saved search back to default.
This issue is not reproducible when Date and Total filter are used.
Workaround:
Unknown
Platforms:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

Screenshots/Videos
https://github.com/user-attachments/assets/46e041c2-abf9-4dd0-a0a5-1c22a85ce0be

View all open jobs on GitHub
Issue OwnerCurrent Issue Owner: @OfstadC

This is coming from this PR. Gonna demote it to NAB, since it's not breaking any functionality. @lakchote we need to figure out why the hashes are different in this case.

Not overdue. Awaiting payment.

Payment Summary

@allroundexperts due $250 via Manual request in New Expensify

$250 approved for @allroundexperts


Add dtrace-http4s and dtrace-akka-http modules

Add modules to support injecting (on the client side) and extracting (on the server side) http headers to propagate traces over http (via either / both b3 and money formatted headers).  This will support / is related to #19

Also following https://github.com/w3c/distributed-tracing/blob/master/trace_context/HTTP_HEADER_FORMAT.md.  To the extent we can given our implementation, we should also provide the means to generate/parse w3c headers at some point, though I think at this stage, it's too premature.

WIP  https://github.com/sbuzzard/cedi-dtrace/tree/add-http-modules

Added in #19


⚠ Samsung has degraded performance

In 11693dc, Samsung (https://samsung.com) experienced degraded performance:

HTTP code: 200
Response time: 2413 ms

Resolved: Samsung performance has improved in 9e0be2c.


RqCookies must be an interface

RqCookies must be an interface and its implementation must be in its nested class RqCookies.Base. Let's refactor it accordingly. The interface should look like:
public interface RqCookies extends Request {
  Iterable<String> cookie(String name);
  Iterable<String> names();
}

@yegor256 thanks, I added the "bug" tag

@yegor256 many thanks for the report, I topped your account for 15 mins, transaction 000-ac9d227c

Can I take this task?

@dmzaytsev the task is yours,please go ahead

Ohh I am sorry , I didn't know this task has been assigned , and I don't know how to remove my commit .

@YamStranger @MohandAndel
According to our quality rules:

Messages in a ticket always start with a name of a user they are addressed to.

please fix your messages, thank you

@yegor256 #162  is fixing this issue, please close  if that's all here, thank you

@dmzaytsev thanks!

@davvd could you please schedule QA review for the task, thank you

@elenavolokhova please, review this task for compliance with our quality rules

@dmzaytsev Thank you for work on the quality of this ticket, but it is still not perfect. Not all comments contain user name. Be more persistent next time.

@davvd Quality is acceptable.

@elenavolokhova @yegor256 how I can fulfill the requirements of quality, except ask someone to change a comment? What should I do if someone does not comply with the request?

@davvd Quality is acceptable.

@elenavolokhova thanks a lot, next time everybody should try to make it better

@dmzaytsev just added 10 mins to @elenavolokhova (for QA), payment ID is 55983587; 45 mins sent to your balance (ID 55983615), many thanks! It took 157 hours and 39 mins.; the bonus for fast delivery (age=1469); +45 added to your rating, current score is: +896


Spot oa chord diagram

Optimized the query that populates the chord diagram files by removing unused columns. Also changed the MAX function to now obtain the sum of bytes and packets transferred.

LGTM 👍


How do I do pagination on search suggestion?

I was wondering if I can do pagination on search suggestions? I am trying like this but getting an error message when calling it. Is it possible at all on this method?
 $suggestions = $bot->suggestions->searchFor($argv[1]) -> skip(20);

Error: Call to a member function skip() on array in C:\dev\github\php-pinterest-bot\examples\suggestions.php
on line 13

It is not implemented. You get only the first 20 or something results. Feel free to provide a pull request with this implementation 👍

@seregazhuk I would love to do that. Can you please point me a direction to a working paging code that I can follow, please? I am very new to PHP with lot of background in C#, so this can be a great learning experience for me. :)


fix(divider): add dark mode variables

Describe pull-request
Dark mode variables
Solving issue
Fixes: AB#2927#

This one is copied from Victors branch but I would like to discuss this on some product checkin. I don't understand where the theme color values comes from.

Tried a bunch of different background solutions for the divider, but if you change back and forth it gets weird, and it would also get weird for the non-border types. So I just put the border in a divider with padding and colors that works for demonstration with both modes. Not pretty. But good enough maybe.
Light mode:


Add an headerBlacklist option

Hello !
The use case here is to prevent logging some sensitive content stored in headers (such as cookies or authorization bearer tokens)
I know this is already achievable using requestFilter option, but it seems to me that obfuscating headers is a common practice which should not require extra code in requestFilter.
What do you think ?
Content of this PR :

new option : headerBlacklist
default option value : []
tests
deletion of one duplicated test

Thanks for reviewing this PR, let me know what do you think, I tried to ship production code ready but any comments is appreciated.
:)

Hi, @golopot @bithavoc
Did you get a chance to review this PR ?
Thanks !

@maxday Sorry I missed this. looks good, I see multiple commits though, want me to squash and merge or do you prefer to squash them yourself?

@bithavoc no worries, you can squash and merge from your side !
thanks

Released<EMAIL_ADDRESS>Thank you @maxday

Think the typescript def for this really useful LoggerOption was missed. @bithavoc I've added a PR #228. Would you be able to help release it, if it looks fine?
Thanks for the wonderful PR @maxday. ( and @bithavoc ofcourse- for the package itself!


CKEditor integration failing for applications deployed under a subdir (relative_url_root)

Hi,
I have deployed a rails 4.2 app using rails_admin 0.7 on a server, under host/poi_database.
In config/environments/production.rb I set config.relative_url_root = '/poi_database'.
When I visit the rails_admin backend, assets are properly loaded, with one exception:
my CKEditor fields are not being loaded (see picture).
Chrome's console logs a 404 host/assets/ckeditor/ckeditor.js
but the correct URL would be
host/**poi_database/**assets/ckeditor/ckeditor.js
I precompiled the assets with
RAILS_ENV=production RAILS_RELATIVE_URL_ROOT=/poi_database bundle exec rake assets:precompile
and the ckeditor assets have been compiled.
relative_url_root is ignored.
Am I missing something?
Could this be hardcoded path somewhere in the code?

I found the cause: a bug in lib/rails_admin/config/fileds/types/ck_editor.rb:24
"#{Rails.application.config.assets.prefix}/ckeditor/"
is ignoring the relative_url_root configuration.
I made a PR #2422 let me know if this is ok for you guys

Just setting config.assets.prefix to desired value in config/environments/production.rb should be enough.

@mshibuya it is enough indeed.
The reason why I looked for another way is that in the past I had trouble using config.relative_url_root and config.assets.prefix together (I was getting urls with a double relative_root), but this it not the case anymore.
Thank you


Tidying Up Code.

Problems:

"filter == null || filter.equals("") ? null : filter" If filter was null, it would return null anyways. So removed that conditional
"commitCurrentSuggestion()", used once, just pointed to commitCurrentSuggestion(true) so I changed the 1 usage and removed this parameter-less function.
learned that the correct situation to add a space after a word is:
a. When "Automatic Space" is on in settings
b. User presses OK
The function to check whether to add a space was called in many other scenarios, such as when the user types in a certain digitSequence and then 0. We are already committing to the previous word in this scenario, so it is not needed.
We also were calling it in onText, and if a user types in * and it's not a hotkey, for example, then we are again already committing the previous word and inserting *. I don't see a need to add a space after the * here.
Lastly, we are calling it in handleSuggestions, but if we are inserting a symbol in our digitSequence, we don't want it to add a space as well at the time of pressing since we are again committing the previous word. Only if the user presses OK on the symbol (which is handled anyway).
Speaking of handling suggestions, we already check in shouldAcceptPreviousSuggestion() if the sequence has 1 and another digit besides 1, so when it comes to clearLastAcceptedWord(), some of our checks here are always going to pass: lastAcceptedWord wont be empty, suggestions wont be empty, and a suggestion's length will always be greater than the previous word's length.
You changed the algorithm for apostrophes to be able to remove apostrophe (English) words in the dictionary, so I see insertPunctuationCompletions() as an unnecessary function now.
This one could be debated, but I thought it would be better to just use 1 character for learning "previousChars". In using 2 characters for the use cases of typing " -" or " /", I thought it was inaccurate to consider them a part of a digitSequence. If I was typing "and / or", I would not expect to be able to type 164 and for there to be a space added in between the "/" and "or", but rather I would consider inserting a "/" between two sequences/words.

Hope I explained these things well but if not let's discuss.

There are so many issues with this PR that I must reject it. The title says "tidying up the code", but it actually changes the application behaviour in many cases, sometimes causing bugs, sometimes neglecting scenarios which will become very difficult or even fail from user perspective, with the new code.
Please, consider TT9 is used by many people on many different devices, in many different configurations, while you seem to be concentrated on optimizing everything for your language and phone. The code may not be perfect, but I've done many things for a reason.

Rejecting this due to so many issues described above.


add back pytorch-lightning dependency

Closes #2893

Can we document this dependency somehow?
Otherwise we're likely to repeat my mistake the next time someone runs pip-extra-reqs to clear the crud out of our dependencies.

Can we document this dependency somehow?
Otherwise we're likely to repeat my mistake the next time someone runs pip-extra-reqs to clear the crud out of our dependencies.

wouldn't it be possible to catch stuff like this via pytests?


Turn off auto crop white background

hello, can you turn off the auto crop white background? or give a option to turn it on/off?, it messup the page when I convert it to epub, here the original image https://imgur.com/4q50jCB, and after converting https://imgur.com/8k1P4ia, and can I keep the same size images all page after converting into epub file? very sorry for my bad english, thank you in advance, your app its awesome.

Only CLI version have options for that.


[WIP][TF] Support test cases in echotest framework

Introduces a new TestCase structure that just performs call customization. The framework now creates a CallOptions with default values, allowing the call customizer to update it as appropriate for each TestCase.
Please provide a description of this PR:

@nmittler: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

lint_istio
196a9c4aef7233b884cfb547508f3f4416bee519
link
true
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@nmittler: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

lint_istio
196a9c4aef7233b884cfb547508f3f4416bee519
link
true
/test lint_istio

gencheck_istio
196a9c4aef7233b884cfb547508f3f4416bee519
link
true
/test gencheck_istio

integ-security_istio
196a9c4aef7233b884cfb547508f3f4416bee519
link
true
/test integ-security_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@nmittler: PR needs rebase.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.


NativeSelect dropdown arrow mark not changing after opening the values

I wonder why the arrow mark in the NativeSelect is not changing when the dropdown values are open. The same is working fine for the Select component.
Is there any way, we can make it work like the Select component? Kindly review the screenshot.
NativeSelect

Select

I checked the Select component code. I see It doesn't have this  functionality for native-select component.  Please check the screenshot below.

I'm taking a look!.


Rails timezone should be EST

Rails created_at and updated_at attributes are currently in UTC I think. Make them into EST.
Here's something to get you started: http://danilenko.org/2012/7/6/rails_timezones.

whoops; closed the wrong issue.

resolved.


[Bug] 2.0.5 version compilation problem

Search before asking

[X] I had searched in the issues and found no similar issues.

What happened

基于2.0.5-release版本进行编译后的项目，在lib包中的jar格式不正常
What you expected to happen
我期望可以打出正常格式的jar包
How to reproduce
拉取2.0.5-release版本的代码进行下打包，就会出现打出的包不正常的情况
Anything else
No response
Version
2.0.5
Are you willing to submit PR?

[ ] Yes I am willing to submit a PR!

Code of Conduct

[X] I agree to follow this project's Code of Conduct

Is there an error log?

Is there an error log?

This is not an error log, the name in the picture is the name of the jar package in the lib directory after I compiled, now I am not sure why the packaging is normal, but the jar in the lib directory in the compiled project is displayed in the wrong format

Is there an error log?

I have already verified that it is in this problem

Is there an error log?

How can I solve this problem now

Please delete this error jar and try to run mvn clean install -Prelease -Dmaven.test.skip=true again.

请删除此错误 jar 并尝试再次运行。mvn clean install -Prelease -Dmaven.test.skip=true

Please delete this error jar and try to run mvn clean install -Prelease -Dmaven.test.skip=true again.
The problem remains unsolved

Please delete this error jar and try to run mvn clean install -Prelease -Dmaven.test.skip=true again.

The problem remains unsolved

Please delete this error jar and try to run mvn clean install -Prelease -Dmaven.test.skip=true again.
The problem is not solved
Maybe there was a problem with the dolphinScheduler-dist configuration file

Please delete this error jar and try to run mvn clean install -Prelease -Dmaven.test.skip=true again.

This problem only occurs when compiling on Windows, but works fine on Ubuntu

Hi @ITBOX-ITBOY  it is recommended to compile and package on linux or mac. If you want to develop and test in local, you can run the standalone model, which can cover most scenarios.


Add DESTROY to API for audio_recordings endpoint

We need to periodically destroy audio_recordings - add that functionality to the API

Should only be accessible by admin
Should enqueue a job to clean up resources
clear audio cache
clear spectrogram cache
clear cached analysis_results for the system job
Should be well tested
Should honour the archive policy

I figured this issue might appear at some point. :disappointed: Fair enough.

lol - I figured I'd be good and not database hack... but API non-functional so :smiling_imp:


delivery: Explicit environment in terraform configuration

Background
The current Terraform implementation has two root modules: ops and app. For each application environment, we expect the developer to remove local state and re-run with a different project ID.
Proposal
Switch to a more conventional model, where our reusable modules are in one directory, and our "root modules" are in an environments directory. Each root module maps to a dedicated environment. ops is special because it's handles environment-spanning infrastructure, such as Artifact Registry.
.
├── modules
│   ├── app
│   └── delivery
└── environments
    ├── ops
    ├── stage
    └── prod

Once this is done, we add a new environment by copying stage or prod and tweaking. (note, we have some special case logic in a Cloud Build stage to prod handoff.)
In setup.sh, we might setup this terraform structure like so:
gsutil mb gs://${OPS_PROJECT}-tf-state
for d in {'ops','stage','prod'}
do
  pushd $d
  terraform init \
    --backend-config "bucket=${OPS_PROJECT}-tf-state"
    --backend-config "prefix=${d}"
  terraform apply
  popd
done

Terraform-based operations we want to run across environments later could use a script like so:
for d in {'ops','stage','prod'}
do
  terraform -chdir=$d output -raw project_number
done

Problems this will solve

This will simplify our state management, which currently doesn't have a way to simultaneously track multiple app environments
This will remove the naming confusion of an app root module containing an application supporting module
We will have an approach to minimal duplication of terraform config for environments that still allows environment-based special casing

Additional context
This plan was initially outlined during the prototyping of the last refactor: https://github.com/GoogleCloudPlatform/emblem/tree/main/experimental/flex-env-tf#limitations-of-this-approach

The experiment has a fairly complete pass in:

#365
#374
#376

Migrating the experiment to live code:

[ ] Add a prod environment
[ ] Revisit: Why are we making enable_apis a config option?
[ ] Modify setup.sh to terraform apply with this folder structure
[ ] Revise terraform/cleanup.sh to terraform destroy with this folder structure (after #97 we can remove most of that script)
[ ] Add decision record on adopting this directory/module structure

Revisit: Why are we making enable_apis a config option?

Providing an enable_apis variable as a best practice as referenced here.

Everything that can be done on this issue has been completed. There are several decision records to be added related to terraform structure and usage, but they can be pursued in a follow-up. Thank you!


RFE - Provide a 'storage' option that allows me to set the specific StorageClass for the registry

I'm deploying Openshift 4.2 pre-release.  For storage, i'm deploying rook-ceph v1.1.1 (csi-cephfs & csi-rbd).  I want to set my rook-ceph-block(rbd) StorageClass to default.  But, csi-cephfs is the only storage that supports RWX (for registry pod).  I need a way to tell the registry operator to use a specific storageclass (not the default).  Right now, i have to do something less elegant to get the storage carved out the way i need it.  For instance:

$OC_CLIENT patch storageclass csi-cephfs -p '{"metadata": {"annotations": {"storageclass.kubernetes.io/is-default-class": "true"}}}'
sleep 15
$OC_CLIENT patch configs.imageregistry.operator.openshift.io cluster --type merge --patch '{"spec":{"storage":{"pvc":{"claim":""}}}}'
sleep 30
$OC_CLIENT patch storageclass csi-cephfs -p '{"metadata": {"annotations": {"storageclass.kubernetes.io/is-default-class": "false"}}}'
$OC_CLIENT patch storageclass rook-ceph-block -p '{"metadata": {"annotations": {"storageclass.kubernetes.io/is-default-class": "true"}}}'
sleep 30
$OC_CLIENT create -f ../prometheus-rook.yml`

This is hack-ish and makes me sad.  I would love an option to specify the storageclass for my registry pvc.

@nnachefski you can create your own PVC in the openshift-image-registry namespace and use its name in spec.storage.pvc.claim. Have you tried it?

@dmage I think there may be a larger issue here. If pvc.claim is not set, does the registry operator assume the default storage class will provision RWX storage? If so, is this assumption true on most providers?

@adambkaplan RWX is not an assumption, it is a requirement. The operator doesn't assign any storage classes, there is another component that sets the storage class to our PVC. The storage class isn't the only option than customers may want to change in PVC, there are also storage requests, selectors. And the bootstrapped PVC is read-only and can't be changed, so there is no reason to add parts of PVC to our configuration resource.

I think @adambkaplan is referring to the case where the operator creates the PVC itself.  When it does so, it sets RWX as required:
https://github.com/openshift/cluster-image-registry-operator/blob/master/pkg/storage/pvc/pvc.go#L132-L134
so i believe we are fine on that front.

Could something similar be done like with the Prometheus stack?  It uses a config map to configure the cluster-monitoring operator.
Ex:
apiVersion: v1
kind: ConfigMap
metadata:
name: cluster-monitoring-config
namespace: openshift-monitoring
data:
config.yaml: |
prometheusK8s:
volumeClaimTemplate:
spec:
storageClassName: rook-ceph-block
resources:
requests:
storage: 40Gi

we generally have a preference for first class config apis (CRDs) over configmaps that are harder to validate, provide api documentation for, and enforce rbac rules around.

How is RWX a requirement when for years Docker said not to use NFS (commonly used RWX backend) at the risk of getting a corrupted registry? At least there should be a warning in the doc not to use NFS but CephFS or GlusterFS.

@tux-o-matic do you have a link where Docker says not to use NFS?
RWX is a requirement to avoid downtime during upgrades. In general, you should use an object storage (S3, GCS, etc.). PVC is an option when you don't have any object storage.
In 4.4 you can provide a RWO volume if you don't need a high available cluster.

@dmage One such warning in 3.1 doc
And another caution

@tux-o-matic NFSv3 might have such issue, but I believed NFSv4 already fixed those cache and other issue to make NFS more reliable when RWX mounted on many nodes.

@aizuddin85 , if that's the case then I think it should be mentioned in the documentation because I believe most people still stuck with NFS in their infrastructure are likely stuck with v3.x

@tux-o-matic In the documentation it mentioned both. I agree we probably can make it clearer,  caveats between NFSv3 vs NFSv4.

The expected way to use a custom storage class is to provide your own PVC:
$ cat pvc.yaml
  apiVersion: v1
  kind: PersistentVolumeClaim
  metadata:
    name: cephfs-storage
    namespace: openshift-image-registry
  spec:
    accessModes:
    - ReadWriteMany
    resources:
      requests:
        storage: 100Gi
    storageClassName: csi-cephfs
    volumeMode: Filesystem
$ oc apply -f pvc.yaml
persistentvolumeclaim/cephfs-storage created
$ oc patch configs.imageregistry.operator.openshift.io/cluster --type merge --patch '{"spec":{"storage":{"pvc":{"claim":"cephfs-storage"}}}}'
config.imageregistry.operator.openshift.io/cluster patched

You can delete the default pvc/image-registry-storage after that if it has been created.


[BUG] Dark Mode Tradingview Banner doesnt Change

Enable dark mode, go to dex, check dis

Potentially a bug with TradingView, there is no override occurring for this.


Any plans get and confirm phone numbers from users?

Are there any plans to prompt the user to enter their phone number and otp?
That's how TraceTogether works, and it gives the local authority more possibilities when deciding on their protocol. IE they can call potentially infected people or send them texts, instead of just hoping they check the app or respond to push notifications.
I understand that takes away from users' privacy and that's an argument against doing this.

Sorry, but no, there are no plans for this.  It's been made pretty clear by the specs from both companies that this data should not in any way link personally identifiable information with the Temporary Exposure Keys.  The idea is that there's no need to send texts because the app will handle download and checking keys from positively diagnosed people against a local database of keys observed to anonymously inform the user of potentially exposure.


[fix] remove name parameter

that'll break links...

Not sure how this one ended up in there. Thanks.

Released as version 1.1.1 https://github.com/rknightuk/TrackerZapper/releases/tag/1.1.1

Thank you @rknightuk


Completely replace perfect-scrollbar with SimpleBar

perfect-scrollbar replaces both the appearance and the behavior of the scrollbar, and its emulated behavior will never feel native on most platforms.  SimpleBar customizes the appearance while preserving the native behavior.
Testing Plan: I found and fixed a number of obvious issues just by clicking around, but there could easily be more. We should make sure to carefully test every element that uses set_up_scrollbar.

I posted a few questions, and am about to do some QA.  If that goes well, we can test-deploy on chat.zulip.org today.  While we're thinking about this, we should also review this list: https://github.com/zulip/zulip/issues?utf8=✓&q=is%3Aissue+is%3Aopen+scrollbar to see if we can clean out other scrollbar-related issues while we're at it.

Found this while doing QA (click a stream inside "manage streams"):

I think this will as a side effect fix another bug I noticed today, so probably worth giving this some priority.

Actually, make that 2 bugs that I discovered yesterday.

This should be ready for a second round of QA.

Did a quick partial round of QA. I didn't do a diff with the current behavior, so possible some of these are existing issues.
Settings

Scrollbar is too narrow / hard to click on. I would make it wider (and correspondingly adjust the color to be a little lighter).

I think the rightmost scrollbar should just be persistent (on tabs where we need it), and not fade out on a timer.

I think the left scrollbar could be persistent. But another option: when you're hovering over the left sidebar, we show it, and when you're not, we remove it (again, no fade out on timer).

The left scrollbar goes up too high (it goes to the top of the modal, rather than the top of "Your account").

Ideally the scrollbar darken when you click on it (low priority if hard)

On "Your bots", if you create a bunch of bots, we correctly show the scroll bar on the "Active bots" subtab, and incorrectly show the scrollbar on "Add a new bot". (low priority if hard)

On "Users", if you make the window short we incorrectly show a scrollbar when there isn't anything to scroll to (low priority if hard)

(did not check the attachments tab)
Right sidebar
ah, a few similar comments as with Settings. The scrollbar is too narrow / hard to click on, and also there should be a persistent scrollbar that doesn't fade out. I like how it's currently done on master; not sure if that's possible to achieve with simplebar. If not, we can think of a workaround.
Emoji picker
Scrollbar seems to be missing for me.

I think the rightmost scrollbar should just be persistent (on tabs where we need it), and not fade out on a timer.

We discussed this and it is out of scope for this PR -- there's a flag for this in simplebar, we're just not dealing with feature changes.

Settings

Scrollbar is too narrow / hard to click on. I would make it wider (and correspondingly adjust the color to be a little lighter).

I think we just need to override .simplebar-scrollbar:hover { width } in CSS for this.

I think the rightmost scrollbar should just be persistent (on tabs where we need it), and not fade out on a timer.

Addressed by Tim above. Actually the timeout is a change from perfect-scrollbar. We can disable autoHide, or we can lengthen timeout, but I don’t think we want either of those on every SimpleBar, so I’m inclined to leave this for future work if it isn’t critical.

I think the left scrollbar could be persistent. But another option: when you're hovering over the left sidebar, we show it, and when you're not, we remove it (again, no fade out on timer).

See above.

The left scrollbar goes up too high (it goes to the top of the modal, rather than the top of "Your account").

Matches old behavior.

Ideally the scrollbar darken when you click on it (low priority if hard)

Old behavior has no darkening on click, and weird inconsistent flashing between dark and light while dragging.

On "Users", if you make the window short we incorrectly show a scrollbar when there isn't anything to scroll to (low priority if hard)

I can’t seem to reproduce?

(did not check the attachments tab)
Right sidebar
ah, a few similar comments as with Settings. The scrollbar is too narrow / hard to click on, and also there should be a persistent scrollbar that doesn't fade out. I like how it's currently done on master; not sure if that's possible to achieve with simplebar. If not, we can think of a workaround.

See above.

Emoji picker
Scrollbar seems to be missing for me.

Yep, that’s a bug. Added an easy CSS fix. (SimpleBar requires overflow: auto or overflow-y: auto.)

OK, I test-deployed this on chat.zulip.org for feedback.  I think we should start building on top of this branch fixes for any scrollbar things we want to change, under the assumption that we're merging this migration:

There's a bug on chat.zulip.org where the right-sidebar scrollbar is the entire height of the sidebar.  I believe this is likely a bad interaction with the right sidebar paginated rendering strategy we use.  @showell may be able to help debug.
We should go ahead and add the persistent scrollbars in the places we've mentioned in this thread in a new commit, since it's likely easy and will probably help avoid distractions in the discussion
Worth trying to fix the "update_scrollbar" issue with bots.
Worth doing a pass on editing the scrollbar's styling

And then we can iteratively test-deploy this on chat.zulip.org over the next couple days.

I did some restyling to match the widen-on-hover behavior of perfect-scrollbar and lighten the color to a gray that works in day and night modes.
Are there any other reproducible regressions?

Just to keep this updated with current state, I found and fixed what I think was causing the right sidebar problems (missing ui.get_scroll_element calls).

OK, doing a new deploy on chat.zulip.org now.

So our last deployment of this was on chat.zulip.org for like a week (just pulled it off last night because I didn't want to deal with a merge conflict; re-deploying to chat.zulip.org now).  Do we have other open issues with this PR that should block merging?  I think in any case it'd be useful to add additional commits on top to add permanent scrollbars in the places we want them as discussed in @rishig's comments above.
@rishig FYI.

There's https://chat.zulip.org/#narrow/stream/9-issues/topic/scroll.20bar.20on.20USERS from recent memory.

Hrm, OK, hopefully we'll get a quick merge for that upstream.

The next simplebar release should make all the recalculate/update_scrollbar calls unnecessary (Grsmto/simplebar#282), so that’s also worth waiting for.

Hey, just saw you guys are implementing SimpleBar. FYI I'll be doing a release in the next few days. As it's a breaking change (due to DOM structure change, shouldn't impact most users) I'm stacking a few bug fixes with it so it takes a big longer!

I was working on this scrollbar as I worked on #11694. I wanted to know if it is required to set autoHide to false regards to the issue I mentioned or the current behavior is fine.
I also tried to fix the buggy behavior in user_profile_modal, towards which I would like to draw your attention. There is an issue with the rendering of this scrollbar, the scrollbar is not present and the margin/padding on the right side (where the scrollbar should be) vanishes.

The margin/padding is fine for the browser rendered scrollbar through.

@TheCelestial25 Thanks for the report. I’ve tracked this down to a SimpleBar issue that I filed as Grsmto/simplebar#305.

I'm testing the first 3 commits to make sure /help/ works, and then should be able to merge those.

Merged just the first 2 commits, because the simplebar upgrade seems to not have correct scroll-reset behavior when switching articles on /help/.

Merged just the first 2 commits, because the simplebar upgrade seems to not have correct scroll-reset behavior when switching articles on /help/.

This is a regression in SimpleBar.getScrollElement() between 4.0.0-alpha.3 and .4, filed as Grsmto/simplebar#308.

I merged the simplebar upgrade commit, yay!  I think @rishig had a couple things he noticed doing a QA pass of the other commit on chat.zulip.org that I'll mention here:

Two things I noticed:

it's a little disconcerting that clicking on the scrollbar doesn't darken it, partly because the non-simplebar ones do darken. (Also on /help, it's on a non-white background so it's not that easy to see if not darkened.)
on the settings pages, if you click on the scrollbar, drag it down, and then release your click when the mouse is outside the settings modal (e.g. below it or to the right), it closes the settings modal. I don't know if this is an existing thing or a regression, but I ran into it a bunch of times when testing even after knowing the behavior.

I can reproduce the second thing as not a regression, but it is potentially worth looking into as a follow up.
So possibly we get to merge the migration commit too soon.
(Does simplebar support that sort of darken-on-click/hover as an option?)

it's a little disconcerting that clicking on the scrollbar doesn't darken it, partly because the non-simplebar ones do darken. (Also on /help, it's on a non-white background so it's not that easy to see if not darkened.)

(“Non-simplebar” = perfect-scrollbar?)
I think we could do this with some custom CSS, but we’d need to be careful because naïvely darkening them would make them harder rather than easier to see in night mode.

on the settings pages, if you click on the scrollbar, drag it down, and then release your click when the mouse is outside the settings modal (e.g. below it or to the right), it closes the settings modal. I don't know if this is an existing thing or a regression, but I ran into it a bunch of times when testing even after knowing the behavior.

PR sent to Grsmto/simplebar#312.

PR sent to Grsmto/simplebar#312.

Thanks!

(“Non-simplebar” = perfect-scrollbar?)

I guess I just meant the browser scrollbar, at least on Chrome.

on the settings pages, if you click on the scrollbar, drag it down, and then release your click when the mouse is outside the settings modal (e.g. below it or to the right), it closes the settings modal.

Further upstream PR: Grsmto/simplebar#317. (Still not a regression though.)

Merged, huge thanks for your work on this @andersk!  I think we can fix-forward any further issues from here.
We should open follow-up issues for the remaining items discussed above that don't have their own issue (or maybe just a master scrollbar follow-ups issue with little checkboxes?).  @andersk can you take care of that?  I don't have a great handle on which of the things @rishig and I mentioned above are fixed in the current state.
Also there's a bunch of random scrollbar issues we should check if are fixed and if not, consider clearing out while we're thinking about scrollbars:

https://github.com/zulip/zulip/issues/11694
https://github.com/zulip/zulip/issues/10544
https://github.com/zulip/zulip/issues/10421
https://github.com/zulip/zulip/issues/8851
https://github.com/zulip/zulip/issues/9039
Possibly most other things in https://github.com/zulip/zulip/issues?utf8=✓&q=is%3Aissue+is%3Aopen+scrollbar, though some of them are UI changes I'm not sure we want to do.


ForgetCache for single Instance

Hi all,
Sometimes I have DB queries running which are not detected by the Model Caching. For that I would need a function which forget the cache for a single model. E.g. $user->forgetModelCache(); What do you think about that?
Thank you.

You can call the artisan command to do that:
app("artisan")->call("cache:clear", ["--model" => "App\User"]);

You might have to play around with double- or single-backslash, not sure. :) Let me know how that works.

Yes, but this deletes the cache for all, which is in my case of thousands of users a performance gap. I like just to delete one single instance of a model, not all models.

No, there is no way to clear the cache for just one instance of a model at this point. Sorry.

I know, question is if we should have a look into. Any idea where to best start when looking into PR?

@Nowi5 What I'm saying is that it's not possible with how the cache is set up. If you want to have a stab at creating a PR, by all means, but I'm sure you will find that it won't work without rewriting the caching logic completely. :)


Can the breaking change tooling NOT flag changes to common-types?

For example, this PR https://github.com/Azure/azure-rest-api-specs-pr/pull/14898/checks?check_run_id=17310807991 has many format changes due to the swagger adopting V5 of common-types and these are not truly breaking.

Acknowledged. common-types is also being excluded by Avocado.


Fix header inclusion logic

This fixes a recent regression following the merge of SHA3/SIMD256.
With this PR, SHA3 depends on Hacl_SHA2_Types.h, since the latter file contains general-purpose definitions (e.g., a quadruple of pointers) that are now used by both SHA2 and SHA3, since SHA3 is now SIMD too.
I could rename Hacl_SHA2_Types.h into Hacl_Multibuf_Types.h or something, but this might break some clients like Python, so I'm not sure how judicious that would be.
In the meanwhile, that fixes the issue reported by Franziskus.

xcode-select: error: invalid developer directory '/Applications/Xcode_13.4.app'

@pnmadelaine @W95Psp would any of you know what's going on with github actions on osx? the latest error seems pretty cryptic

https://github.com/actions/runner-images/blob/main/images/macos/macos-14-Readme.md looks like the version of XCode that we select is no longer supported

Thanks. I can confirm that this fixes the issue locally for me.
hacl-packages CI is failing on this because it needs changes in tests (the API changed).
Here's a draft with fixes https://github.com/cryspen/hacl-packages/pull/461

Let me kick another dist refresh


[HANA] wrong alter table add column syntax

System information:

DBeaver 21.2.1 CE
Sap Hana

Describe the problem you're observing:
If you perform import/export into table and it require column creation you'll catch SQL error.
Correct syntax: ALTER TABLE SCHEMA.TABLE ADD (COLUMNNAME INTEGER)
Actual query:

Include any warning/errors/backtraces from the logs
Error occurred during Create target metadata
Reason:
SQL Error [257] [HY000]: SAP DBTech JDBC: [257] (at 37): sql syntax error: incorrect syntax near "COLUMN5": line 1 col 37 (at pos 37)

verified


Truncate tag names at 50 chars

Want to truncate the "related tags" shown in the expandable area of each details table. Currently, when the number of tag characters is greater than the allowed, a tag may not be shown at all.
Fixes https://github.com/project-koku/koku-ui/issues/1018

Hold merge until after the EMEA conference

Codecov Report

Merging #1019 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1019   +/-   ##
=======================================
  Coverage   75.59%   75.59%
=======================================
  Files         227      227
  Lines        4360     4360
  Branches      812      812
=======================================
  Hits         3296     3296
  Misses        951      951
  Partials      113      113

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 38bfc85...d9d2ac8. Read the comment docs.


set-env command has been removed from github/actions and breaks build.

Describe the Bug
Github have withdrawn the set-env command which is used by actions/core js package this seems to break things for running over the matrix of tests and we get the following error:
Error: Unable to process command '::set-env name=PUPPET_GEM_VERSION::~> 5.0' successfully.
Error: The set-env command is disabled. Please upgrade to using Environment Files or opt into unsecure command execution by setting the ACTIONS_ALLOW_UNSECURE_COMMANDS environment variable to true. For more information see: https://github.blog/changelog/2020-10-01-github-actions-deprecating-set-env-and-add-path-commands/
I think this is a bug in the upstream actions/core package as linked to below so will need to bump the version when that one is fixed.
Expected Behavior
Test run without error.
Steps to Reproduce
This is our actions file:
This is a basic workflow to help you get started with Actions
name: CI

# Trigger the workflow on push or pull request
on: [push, pull_request]

# A workflow run is made up of one or more jobs that can run sequentially or in parallel
jobs:

  spec:
    runs-on: ubuntu-18.04
    strategy:
      matrix:
        check: [parallel_spec, 'syntax lint metadata_lint check:symlinks check:git_ignore check:dot_underscore check:test_file rubocop']
        ruby_version: [2.4.x,2.5.x]
        puppet_gem_version: [~> 5.0, ~> 6.0]
        exclude:
            # Don't repeat the linting on both puppet versions
          - puppet_gem_version: ~> 5.0
            check: 'syntax lint metadata_lint check:symlinks check:git_ignore check:dot_underscore check:test_file rubocop'
            # Use ruby versions appropriate for the puppet version
          - ruby_version: 2.4.x
            puppet_gem_version: ~> 6.0
          - ruby_version: 2.5.x
            puppet_gem_version: ~> 5.0
    steps:
      - uses: actions/checkout@v2
      - uses: actions/setup-ruby@v1
        with:
          ruby-version: ${{matrix.ruby_version}}
      - name: Spec Tests
        uses: puppetlabs/action-litmus_spec@master
        with:
          puppet_gem_version: ${{ matrix.puppet_gem_version }}
          check: ${{ matrix.check }}

Environment

Version [e.g. 1.27.0]
Platform [e.g. Ubuntu 18.04]

Additional Context
Upstream github action bug looks to be here:
https://github.com/actions/toolkit/issues/643

Fixed in PR: https://github.com/puppetlabs/action-litmus_spec/pull/60/commits


image inside $form->table doesn't work

Laravel Version: 5.5.45
PHP Version: 7.0.33
Laravel-admin: 1.6.15

Description:
  $form->table('home_slides', '', function ($table) {
    $table->textarea('title_en', '名稱');
    $table->textarea('title_hk', '名稱 (中文)');
    $table->image('image', '圖片');
   });
})

Can't upload image if it is inside table, as it would always display validation errors.

Steps To Reproduce:

I found the problem. The generated form tag doesn't have enctype="multipart/form-data"
Once I added an image field outside table, the problem is fixed.

            $form->tab('首頁', function ($form) {
                $form->table('home_slides', '', function ($table) {
                    $table->textarea('title_en', '名稱');
                    $table->textarea('title_hk', '名稱 (中文)');
                    $table->file('image', '圖片');
                });
            });

            $form->image('placeholder_image', '圖片');

            $form->disableCreatingCheck();
            $form->disableEditingCheck();
            $form->disableViewCheck();

        });`


Code Quality: Move platform-depends classes from Shared to Core

Code Quality: Move platform-depends classes from Shared to Core
cc: @d2dyno1
Motivation & Context

Improved readability

WarningPlease do not review code lines that I did not changed. I cannot make more diff. If there're more codes that are preferred to change, I will do that and mark that PR as the final one for that stage.

PR Checklist

[x] Were these changes approved in an issue or discussion with the project maintainers? In order to prevent extra work, feature requests and changes to the codebase must be approved before the pull request will be reviewed. This prevents extra work for the contributors and maintainers.
Related #4180
[x] Did you build the app and test your changes?
[ ] Did you check for accessibility? You can use Accessibility Insights for this.
[ ] Did you remove any strings from the en-us resource file?

[ ] Did you search the solution to see if the string is still being used?

[ ] Did you implement any design changes to an existing feature?

[ ] Was this change approved?

[ ] Are there any other steps that were used to validate these changes?

Screenshots

Looks like the pipeline is failing

@0x5bfa can you resolve the merge conflicts?

Fixed conflicts


White background in logo in readme in dark mode

[Cosmetic] Change to transparent background for compatibility with dark mode

Thanks for reporting this. PRs welcome.

Hello @MikeRalphson  , I could resolve this issue . Can you make me Assignees?

We can change to a transparent background for the image.
I'm facing an issue i.e. the image is attached via URL and I can't make changes to it; so for trial purposes, I downloaded and edited the image and got a URL from a website and the issue seems to be resolved in dark mode.

@MikeRalphson , @handrews  given the PR has been merged , looks we can close the issue isn't it ?

@LasneF yup, not sure how I missed your comment earlier.  Closing as complete!


Use layers digest for CacheID in FROM step

Using layers digest for calculating cacheID allows to use cache between different image tags. This can be very useful if there's a lot of similar images with different tags, for example, in a CI/CD pipeline where each feature branch produces different image tag.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.Vladimir Krumshtein seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

 All committers have signed the CLA.

I think the best approach should be using SHA256 hash of manifest content.


Feature Request: more control over, better information about disk space utilization

In an embedded system or a handheld computer like an iPhone, space is at a
premium. It's often important to maintain strict control over database size
growth.

Please enhance leveldb to provide better runtime control over the amount of
disk space used and/or provide more complete, up-to-date information about how
much space is bing used, so that it's possible to remove entries to make more
space. The current size estimate functionality is often dramatically wrong,
even after closing and re-opening the database (I see values off by 75% or more
versus file system measurements).

Also, please provide a reliable compaction interface for mere mortals who don't
know how the Internals work. The current DB::Compact() method has the opposite
to the intended effect: the database grows dramatically each time it's invoked.
The only way to get actual compaction behaviour seems to be to close and
re-open the database.

Original issue reported on code.google.com by<EMAIL_ADDRESS>on 3 Nov 2011 at 8:46

After uncovering a bug in my own code where an Iterator was being leaked, I'm
seeing improvements in the behaviour of the memory size reporting, as well as
more reliable automatic compaction in the background. It apparently relates to
Versions being kept alive by the Iterators.

Some additional discussion in the documentation, to the effect that live
Iterators may impact various database functions (including deletion) would be
desirable. Alternately, could each Version be owned by the Iterator responsible
for its creation, instead of all Versions being owned by the database? Or since
the database maintains ownership of Versions, should it not maintain ownership
of Iterators, too?

Original comment by<EMAIL_ADDRESS>on 4 Nov 2011 at 3:47


GH patch release not possible due to branch protection rules

Description
GH action "create-release" should be allowed to commit and push into release branch (bypassing branch protection rules)
Reason
https://github.com/kyma-project/serverless/actions/runs/7569655019/job/20613434034
Run git config --local user.email<EMAIL_ADDRESS>[release-1.3 fe06e12] upgrade dependencies
remote: error: GH006: Protected branch update failed for refs/heads/release-1.3.
remote: error: Changes must be made through a pull request. 2 of 2 required status checks are expected.
To https://github.com/kyma-project/serverless
 ! [remote rejected] release-1.3 -> release-1.3 (protected branch hook declined)
error: failed to push some refs to 'https://github.com/kyma-project/serverless'
Error: Process completed with exit code 1.

Attachments
hint

GH Action cannot be added as exception to the branch protection rule: https://github.com/orgs/community/discussions/13836

It's not possible to change branch protectino rules with the default GH Action user, even with write-all permissions:
{
  "data": {
    "updateBranchProtectionRule": null
  },
  "errors": [
    {
      "type": "FORBIDDEN",
      "path": [
        "updateBranchProtectionRule"
      ],
      "extensions": {
        "saml_failure": false
      },
      "locations": [
        {
          "line": 2,
          "column": 3
        }
      ],
      "message": "Resource not accessible by integration"
    }
  ]
}

A service account is required

Service account was created, and branch protection rules updated accordingly, to a allow the bot to skip PR


forceNiceScale for xAxis

Is your feature request related to a problem? Please describe.
yaxis has forceNiceScale option. Needed a similar one for xaxis. See https://github.com/apexcharts/apexcharts.js/commit/64cca3b16765f11bfa8043f0f7058672e0dc9c31

Describe the solution you'd like
xaxis: {
  forceNiceScale: true
}

Describe alternatives you've considered
Rounding via labels.formatter but this causes inconsistencies and mismatch between xaxis label and tool-tip values.
Additional context
Looking for a way to force xaxis labels to numbers either ending in 0 or in 5, no other numbers. But forceNiceScale behavior also works. Also not sure if this works well if tickAmount is specified.

🥲

😒

junedchhipa
any assistance here? i'm using ReactApexCharts type="line" and my x-axis looks very weird. would be great if there is a forceNiceScale option.

@junedchhipa
any assistance here? i'm using ReactApexCharts type="line" and my x-axis looks very weird. would be great if there is a forceNiceScale option.


[Readme] Clarification please, what are the hardware/software requirements?

Hello!
This looks super nifty, and I am interested in seeing if it works for my project.
Just a nitpick about the readme, I see in the description this is GPU accelerated. I have found recently this usually means Nvidia + WIndows only. Could you please clairfy the system/software requirements to run this?
Unity versions, if specific hardware is needed, if Windows is needed.
Thanks!

Good call! It should run on just about any GPU as long as it supports floating point + shadow map render textures.  I'll add a "Requirements" section to the readme. I'm not sure about platform limitations, but I don't see why it would be limited to Windows. If anyone can test this I'll gladly add the info. Thanks!

Added the mentioned info in 8db78aa165f0038903376d4e2da6fbb6395d912f


Video glitches when extension is enabled

When extension is enabled, some videos look like this.

Firefox version 78.0.1
Extension version 1.6.0

To be fair, I had the same issue for a while now :D


Make bisect the default search strategy

is there a reason this isn't the default?
Originally posted by @danieleades in https://github.com/foresterre/cargo-msrv/issues/45#issuecomment-922481683

Hi @danieleades, thanks for your question.
I think there are two reasons at the moment why it isn't the default:
1. The bisect implementation has not been battle tested and aside from my own use, I've received no feedback on how well the implementation performs. On the flip side, having it as the default may very well generate such feedback.

2. At the time of implementation there were some issues regarding different versions of `Cargo.lock` files. Older Cargo versions did not support newer lock files. When using bisection, this issue become much more prominent, as we would now install much older toolchains, while currently, most often the MSRV is a much more recent version of Rust which have support for the newer lock file. This issue can be alleviated by running `cargo msrv` with the `--ignore-lockfile` flag, but it also changes the behaviour since we now run a toolchain against unfrozen dependency versions.

However, a binary search can significantly reduce the time necessary to determine the MSRV, especially when you also reduce the search space further by setting --minimum <version> (e.g. 1.31.0 for Rust edition 2018), so it's definitely a worth to think about, and to start a conversation about.
What would be the primary reason(s) for you to have --bisect as the default?

i'm using 'bisect' to find the msrv on new projects. it's significantly faster than the linear search.
I'm also using the 2018 edition as a minimum. perhaps the edition set in cargo.toml should be respected as a minimum? or at least, the editions could be used as aliases with the --min argument. That's a different issue of course.


Switch to async/await syntax

Switch from Promise.then syntax to async/await syntax. I had put this off since babel was throwing errors I couldn't fix. I now found a solution using runtime transforms.

Nice! LGTM


Issue #41 - Fix popover rendering onscreen when target is long gone

Fixes issue #41 where popover is rendered onscreen despite the target already being out of bounds.
Also fixes a an unrelated code issue (absoluteLeft being added to absoluteTopOffset).
Thank you for the great library!

Discovered issue in reverse scrolling, so fixing that up now.


Support for unregistering a custom function

As I understand it today a custom function can at most be overridden, potentially with a function that throws, but it can't just be deleted.
IMO for anything that can be added it tends to be nice to have a way of removing it also, so I think it would be nice if custom functions could be deleted also.

Duplicate of https://github.com/WiseLibs/better-sqlite3/issues/773


Some ways where parking lanes were added manually are not displayed

Not sure why this happens.
E.g.

https://www.openstreetmap.org/edit?editor=id#map=18/53.71482/23.85540

Need to add parking:condition:<side> tag

So, the viewer/editor will completely ignore these ways until tags are manually added?

Understood, fixed, thanks you

Fixed, thanks!


Implement dropout choice

Add the --dropout option to the train task in order to fix the dropout hyperparameter applied to the dropout layers.

Hello @14thibea! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

In the file clinicadl/clinicadl/cli.py:

Line 588:13: E126 continuation line over-indented for hanging indent

In the file clinicadl/clinicadl/slice_level/train_CNN_bad_data_split.py:

Line 135:9: E126 continuation line over-indented for hanging indent

Thanks @14thibea !
Everything seems ok. I'll merge this one!

I'll fix the style issues after merge.


Remapping a key

Microsoft PowerToys version
v0.74.1
Installation method
Microsoft Store
Running as admin
Yes
Area(s) with issue?
Keyboard Manager
Steps to reproduce
My key "ý7" on the Czech keyboard does not work. Therefore, I need to remap the key

to

". I suppose I need to choose VK 253 (lower key ý), which is impossible because the application offers codes only up to VK 252

. How shall I do it?
✔ Expected Behavior
I expected to press

and write

❌ Actual Behavior
It writes "7", which is upper key, not "ý". To write  this I need to press

and then "y".
Other Software
PowerToys
Windows 11

/dup https://github.com/microsoft/PowerToys/issues/14120
in progress with pull request


fix e2e operator default config params

What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #
Special notes for your reviewer:
Documentation:

Does this PR introduce a user-facing change?:

NONE

/lgtm


How to filter with joda datetimes?

This template isn't a strict requirement to open issues, but please try to provide as much information as possible.
Version: "io.getquill" %% "quill-jdbc" % "0.8.0"
I got simple query in my schema to retrive rows depending on the 2 dates and an id.
My traits:
trait BaseSchema {
  lazy val ctx = new JdbcContext[MySQLDialect, SnakeCase]("ctx") with ImplicitQuery
  import ctx._
  implicit val decodeLocalTime = mappedEncoding[Date, DateTime](date => new DateTime(date.getTime))
  implicit val encodeLocalTime = mappedEncoding[DateTime, Date](time => new Date(time.getMillis))
  trait Quotes {
    this: JdbcContext[_, _] =>
    implicit class DateTimeQuotes(left: DateTime) {
      def >(right: DateTime) = quote(infix"$left > $right".as[Boolean])
      def <(right: DateTime) = quote(infix"$left < $right}".as[Boolean])
    }
  }
}
trait EntitySchema extends BaseSchema {
  val findByEntityAndDates = quote {
    (id: Long, start: DateTime, end: DateTime) =>
      query[Entity].filter(x => x.id == id &&
        x.date > start &&
        x.date < end)
  }
}

got me to an error saying: "value > is not a member of org.joda.time.DateTime" which is quite obvious for joda.
going further:
val findByEntityAndDates = quote {
    (id: Long, start: DateTime, end: DateTime) =>
      query[Entity].filter(x => x.measurementDeviceSensorId == id &&
        x.measurementTime.getMillis > start.getMillis &&
        x.measurementTime.getMillis < end.getMillis)
  }

got me to an error saying: "Tree 'x.measurementTime.getMillis()' can't be parsed to 'Ast'"
I tried to write something like:

trait Quotes {
    this: JdbcContext[_, _] =>
    implicit class DateTimeQuotes(left: DateTime) {
      def >(right: DateTime) = quote(infix"$left > $right".as[Boolean])
      def <(right: DateTime) = quote(infix"$left < $right}".as[Boolean])
    }

but it didnt work either (error: value > is not a member of org.joda.time.DateTime which is quite obvious - joda doesnt support logical operators on datetimes).
Tryint to use nscala time(wrapper for joda, that gives you logical operations by implicits) got me error:
Tree 'com.github.nscala_time.time.Imports.richReadableInstant(x.measurementTime).>(start)' can't be parsed to 'Ast'
I consider myself rather newbie scala programmer so it might be really easy one for you guys. To be honest I actually dont ask for an complete answer rather than pointing where to search for an explanation how to solve this issue. Im just tackling my head with this issue for like a day or two and didnt come with anything that could work any way.

@dezet You forgot to extend JdbcContext with Quotes:
lazy val ctx = new JdbcContext[MySQLDialect, SnakeCase]("ctx") with ImplicitQuery with Quotes

Next time if your question is not an issue (bug or feature suggestion) it's better to post it on stackoverflow.com and share a link to https://gitter.im/getquill/quill or send it directly to me ;-)

That was indeed easy one, should have taken longer break before writing the issue - it was really obvious, haha 👯  Well, stackoverflow didnt seem active and I actually didnt know about gitter channel - thats obviously better place to get help than here. Thanks again for the help and will try to get post my questions on gitter now. :) cheers!

@mxl,
Do you know how to deal with this? https://github.com/getquill/quill/issues/1406