Runner hangs when error occurs (Error in Role initializer) in reusable role

What is your Test Scenario?

Using a simple role before each test to prepare the environment.
What is the Current behavior?

From time to time, connection to tested service fails (internet problem, server restart, application restart etc). When it fails, the whole tests runner pipeline hangs.
Looks like it is a similar issue to https://github.com/DevExpress/testcafe/issues/4297 (@TauPan) and https://github.com/DevExpress/testcafe/issues/4892 (@sijosyn).
What is the Expected behavior?

When such error in role occurs, the test should be marked as failed and the test runner should continue execution.
Further in quarantine mode:

the tests should be retried
Would be great to define some delay between failures in such a case - a bit longer than in case of quarantine mode?

Steps to Reproduce:

I was able to reproduce it - you can find the code in my fork branch. Use yarn runner or npm run runner to run the tests.
I use a URL that does not exist to test it (there is no server running at http://localhost:1234/`.
reuse Role
const url = "http://localhost:1234/";
// Here is the important line - create role which is reused for all tests
const role = Role(url, () => {}, { preserveUrl: true });

fixture`A set of examples that illustrate how to use TestCafe API`
.beforeEach(
    async (t) => {
        await t.useRole(role);
    }
)

Quarantine mode - no warning, just hangs...

➜  basic git:(master) ✗ yarn runner
yarn run v1.22.4
$ node runner.js
 Running tests in:
 - Chrome 83.0.4103.116 / macOS 10.15.5

 A set of examples that illustrate how to use TestCafe API
^C

Normal mode: there is just one warning that connection failed.

➜  basic git:(master) ✗ yarn runner
yarn run v1.22.4
$ node runner.js
 Running tests in:
 - Chrome 83.0.4103.116 / macOS 10.15.5

 A set of examples that illustrate how to use TestCafe API
 ✖ Text typing basics

   1) - Error in Role initializer -
      A request to "http://localhost:1234/" has failed.
      Use quarantine mode to perform additional attempts to execute this test.
      You can find troubleshooting information for this issue at "https://go.devexpress.com/TestCafe_FAQ_ARequestHasFailed.aspx".

      Error details:
      Failed to find a DNS-record for the resource at "http://localhost:1234/".

      Browser: Chrome 83.0.4103.116 / macOS 10.15.5

^C

New Role for each test
const url = "http://localhost:1234/";

fixture`A set of examples that illustrate how to use TestCafe API`
.beforeEach(
    async (t) => {
        await t.useRole(Role(url, () => {}, { preserveUrl: true }));
    }
)

In this case, the result is different and, I would say, expected. For each test, the role is executed:

See tests log:
➜  basic git:(hanging-reproduction-issue) ✗ yarn runner
yarn run v1.22.4
$ node runner.js
 Running tests in:
 - Chrome 83.0.4103.116 / macOS 10.15.5

 A set of examples that illustrate how to use TestCafe API
 ✖ Text typing basics

   1) - Error in Role initializer -
      A request to "http://localhost:1234/" has failed.
      Use quarantine mode to perform additional attempts to execute this test.
      You can find troubleshooting information for this issue at "https://go.devexpress.com/TestCafe_FAQ_ARequestHasFailed.aspx".

      Error details:
      Failed to find a DNS-record for the resource at "http://localhost:1234/".

      Browser: Chrome 83.0.4103.116 / macOS 10.15.5

 ✖ Click an array of labels and then check their states

   1) - Error in Role initializer -
      A request to "http://localhost:1234/" has failed.
      Use quarantine mode to perform additional attempts to execute this test.
      You can find troubleshooting information for this issue at "https://go.devexpress.com/TestCafe_FAQ_ARequestHasFailed.aspx".

      Error details:
      Failed to find a DNS-record for the resource at "http://localhost:1234/".

      Browser: Chrome 83.0.4103.116 / macOS 10.15.5

 ✖ Dealing with text using keyboard

   1) - Error in Role initializer -
      A request to "http://localhost:1234/" has failed.
      Use quarantine mode to perform additional attempts to execute this test.
      You can find troubleshooting information for this issue at "https://go.devexpress.com/TestCafe_FAQ_ARequestHasFailed.aspx".

      Error details:
      Failed to find a DNS-record for the resource at "http://localhost:1234/".

      Browser: Chrome 83.0.4103.116 / macOS 10.15.5

 3/3 failed (16s)
✨  Done in 35.67s.

Your Environment details:

testcafe version:                   latest - 1.8.7
node.js version:                    v12.14.1
command-line arguments:  See runner in reproduction example
browser name and version: Chrome 83.0.4103.116
platform and version:          macOS 10.15.5

Hello,
Thank you for pointing out to this problem. We've reproduced it in your example.
We will update this thread once it's fixed.

Test
Master
Test branch
Time execution difference [%]

batch 1
18min21s
25min28s
39

batch 2
18min55s
28min17s
50

batch 3
17min39s
25min45s
46

batch 4
18min9s
26min27s
46

storybook 1
15min22s
20min15s
32

storobook 2
15min27s
20min24s
32

I just wanted to point out that applying the workaround to generate the new role for each test to avoid test cafe hanging in quarantine mode is quite expensive - the time to execute all the tests increases significantly :/

Thanks for sharing your finding. Yes, creating a new role for every test actually diminishes all the performance increment that the roles feature should provide. We would not consider this workaround as a permanent solution. Please bear with us.


Added a spec_helper which supports docker

Since serverspec is not the default test framework, we do not supply
helper files.  We simply use rake to act as an executer.  This will
serve as an example implementation for others.
Special thanks to @kireledan, who actually figured this out, but I sent
him on a wild goose hunt, thinking we needed to change the Rakefile.

Wow, awesome work! 👍 👍


bootstrap_target & windows

In features/support/fs.rs: bootstrap_target
cp command is not available in Windows.
I'm trying to fix the TODO soon.

Hopefully some useful background for you:
That method copies the current executables "target" directory into mock project so it doesn't need to recompile the shared dependencies.
If you can find a cargo crate for this, that would be awesome. When I wrote this, I coudn't find an easy solution that didn't require me to manually recurse down the file tree. Bleh.

Ah, right! That rings a bell... Doesn't seem like there is a crate even now ...
Might take me a bit longer than expected.

burntsushi pulling through as always with a directory walking crate, walkdir
It still looks a bit involved, but that's a great start.

Thats the crate I tried to [use here](https://github.com/pJunger/cucumber/commit/8c8eb34deacc5f0228d0fedcac82c47a843a10b4).  I still dont really know what goes wrong there - I hope I`ll get to it on the weekend.

Feel free to put up a PR here even if its giving you more trouble than expected. I've got a little bit of experience doing fiddly file things in rust and might be able to help.

Thanks for the offer! Opened #46.


Add --gc-between-run flag for TPC* benchmarks.

Signed-off-by: Peter Rudenko<EMAIL_ADDRESS>Add --gc-between-runs parameter when submitting benchmark with spark-submit. Useful to trigger unregister shuffle when running many iterations.

@petro-rudenko changes look good, but it seems you do need to push force after signing off, this should work:
git commit -s --amend

then force push this to your branch.

build

build


Add react-page-name

Adds react-page-name which is a simple utility hook to manage page names for React apps.

Thanks


Update select size variants to two

Update select size variants to two: small, large (BREAKING). Make large variant the default one (without the need for a class).
Design: https://www.figma.com/file/xZ0IW0MJO0vnFicmrHiKaY/branch/MVANE2KzNGq2et3q6T15PC/Components-Post?node-id=7802%3A33963&mode=dev

Closing in favor of #3271


Support postcss v6

:+1:

Seems repo abandoned. Feel free to reopen.

I'll may take a look over the weekend dude. I'm not using postcss at the moment so I'm a little out of the loop


Inaccurate hash rate calculation for some cryptocurrencies

It has been observed that the hash rate calculations for some cryptocurrencies are not accurate. This may lead to misleading information or incorrect estimations for mining efficiency. Please investigate the issue and provide a solution to ensure precise calculations for all supported cryptocurrencies.

Yes, this is because the difficulty of the mine pool changes so that the calculated hash is not accurate, we will try to fix this problem in the future version


add promoteBuffers option to deserialize

deserializes Binary data directly into node.js Buffer object

fixed in 1.0 branch


Handling Arbitrary on structs containing the Never type (!)

Hello! Here's a motivating example
fn main() {
    let x = any::<Wrapper<!>>();
}

#[derive(proptest_derive::Arbitrary, Debug)]
enum Wrapper<T> {
    A(T),
    B,
    C,
}

I'd like to be able to create such a Wrapper struct such that for Wrapper<!>, the proptest arbitrary picks between the other two options. This of course fails with
the trait `Arbitrary` is not implemented for `!`

Which makes sense! Impling arbitrary on ! doesn't particularly make sense since it can't be instantiated. Perhaps I can implement Arbitrary manually with separate impls for <T: Arbitrary> and T = !.
type WrapperStrategy<T: Arbitrary> = impl Strategy<Value = Wrapper<T>>;
impl<T: Arbitrary> Arbitrary for Wrapper<T> {
    type Parameters = T::Parameters;
    type Strategy = WrapperStrategy<T>;

    fn arbitrary_with(args: Self::Parameters) -> Self::Strategy {
        unimplemented!()
    }
}

impl Arbitrary for Wrapper<!> {
    type Parameters = ();
    type Strategy = WrapperStrategy<!>;

    fn arbitrary_with(args: Self::Parameters) -> Self::Strategy {
        unimplemented!()
    }
}

Unfortunately, this also doesn't work because
19 | impl<T: Arbitrary> Arbitrary for Wrapper<T> {
   | ------------------------------------------- first implementation here
...
28 | impl Arbitrary for Wrapper<!> {
   | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ conflicting implementation for `Wrapper<!>`
   |
   = note: upstream crates may add a new impl of trait `_IMPL_ARBITRARY_FOR_Wrapper::_proptest::arbitrary::Arbitrary` for type `!` in future versions

I briefly tried using https://doc.rust-lang.org/beta/unstable-book/language-features/negative-impls.html to impl !Arbitrary for ! {} - but this does not work for avoiding this coherence detection.
Any ideas on how this could work?
Perhaps proptest_derive could be augmented to detect this scenario and loosen the requirement that T: Arbitrary. Another idea could be something in the same vein as #[proptest(skip)] on Wrapper::A(T) that only skips it for the uninhabited case.

I think you're looking to restrict generation to just the two variants that don't contain a T which can be done via
╰─⠠⠵ cat src/main.rs

#![feature(never_type)]

#[derive(proptest_derive::Arbitrary, Debug)]
enum Wrapper<T> {
    A(T),
    B,
    C,
}

fn main() {
    let x = proptest::prop_oneof![
        Wrapper::<!>::B,
        Wrapper::<!>::C,
    ];
}

does this address your use case or is there some dependency between Arbitrary and the use of ! for your use case?

Ideally, we're able to instantiate both Wrapper<!> and an inhabited variant (eg Wrapper<String>).
For the Wrapper<String> - I'd want arbitrary to pick from all of the choices, and for the Wrapper<!> - I'd want it to pick from the two inhabited choices.
It is possible (as you mentioned) to make two different strategies, but it doesn't seem possible to impl Arbitrary for Wrapper<!>. My codebase uses both Wrapper<String> and Wrapper<!> in many places. It would be possible (but annoying) to override the arbitrary strategy - but it would be nicer to be able to impl Arbitrary.
One workaround is to make our own never type - then it allows impling arbitrary.
#[derive(Clone, Debug)]
enum Never {}
impl Arbitrary for Wrapper<Never> {
    type Parameters = ();
    type Strategy = impl Strategy<Value = Self>;

    fn arbitrary_with(args: Self::Parameters) -> Self::Strategy {
        proptest::sample::select(vec![
            Wrapper::<Never>::B,
            Wrapper::<Never>::C,
        ])
    }
}

I think it would be nice if we could get proptest-rs to work nicely with coherence rules to allow for impl Arbitrary for Wrapper<!>. I think this could be possible with both

https://github.com/rust-lang/negative-impls-initiative/issues/1
Adding a negative trait impl - impl !Arbitrary for ! to the proptest-rs crate, thus promising that proptest-rs will never impl Arbitrary for !.

I also additionally think it would be nice if #[derive(Arbitrary)] supported cases where ! was a type param, though I suspect that would be difficult to implement.

I see. I think a negative impl for ! is reasonable given its impossible to generate a value.

I also additionally think it would be nice if #[derive(Arbitrary)] supported cases where ! was a type param, though I suspect that would be difficult to implement.

I'm not as convinced on adding this to the derive impl at the moment but I'll think it over a bit more

Let me know if this works for you. you'll need to use proptest with features unstable and never-arbitrary


Constructed Airlocks Don't Power Up

How to Reproduce:

Build an airlock frame
Go through the airlock construction process
The airlock will be unpowered even if it's in an area where there is power.
The airlock also won't show the red indicator light for the bolts being down, though cutting or pulsing the bolt wire does work as expected.

Edit: Bolts are also broken. If you bolt the new airlock, you will be unable to remove the bolts by any means.

I should add that constructed airlocks apparently do work in certain places, but I know I tried to replace the vault door with one and it was unpowered even though the vault is powered.


Fix NxN transmission

Fixed an issue where monitors did not always monitor the right mode
Added NxN unittest that checks waveguide transmission

Doc notebook is now sensible:

TODO:

I removed the dataframe_regression check because it didn't immediately work when I pulled, needs to be put back

The conflicts relate to my TODO item but don't seem to alter the fix functionality, so arrange as you see fit @joamatab

Awesome!
thank you Simon!
I merged and regenerated the regression tests
pytest gdsfactory/simulation/gmeep  --lf --force-regen


Title block doesn't respect "Disable new blocks" restriction from DX Layout

Describe the bug
Title-Layout.webm
To Reproduce

Go to ControlPanel > Content Types
Add new content type: Book
Go to Layout for Book and enable editable blocks
Click on Title block and then on Settings in the Sidebar
Select "Disable new blocks" you will notice the "+" disappears and Save
Go to Home Page and add a new Book
Fill the Title block and press Enter.

Expected behavior
A new block should not be created when you press Enter in the Title block if it has "Disable new blocks"
Screenshots
If applicable, add screenshots to help explain your problem.
Software (please complete the following information):

OS: macOS
Browser Chrome
Volto Version 18.0.0-alpha.43
Plone Version 6.0.13
Plone REST API Version 9.7.2

Additional context

Hi @avoinea , i came across the same issue! you got any lead on fixing it?

@MAX-786 Here is a starting point
https://github.com/plone/volto/blob/157df05e5da7cc4349f2fefaa6e3566da56a8213/packages/volto/src/components/manage/Blocks/Block/Edit.jsx#L176-L186

vs
https://github.com/plone/volto/blob/157df05e5da7cc4349f2fefaa6e3566da56a8213/packages/volto/src/components/manage/Blocks/Title/Edit.jsx#L151

thanks @avoinea  and I looked briefly and i think problem for Title Block lies here:
https://github.com/plone/volto/blob/157df05e5da7cc4349f2fefaa6e3566da56a8213/packages/volto/src/components/manage/Blocks/Title/Edit.jsx#L71
So, i don't have solid idea about 'detached' but i think it checks for 'blockHasOwnFocusManagement', i might be wrong but doesn't matter and the solution would be simple with jsut adding new flag like 'disableNewBlocksByDefault' and check for both flags like
  const disableNewBlocksByDefault = useMemo(() => data?.disableNewBlocks, [data?.disableNewBlocks]);

And check for it here:
https://github.com/plone/volto/blob/157df05e5da7cc4349f2fefaa6e3566da56a8213/packages/volto/src/components/manage/Blocks/Title/Edit.jsx#L107-L111
Now for Text Block, i think it has to do with slate because if you enter when its empty and 'disableNewBlocks' is true, it removes the block itself instead of doing 'nothing' and when you type in something and press enter it adds new block which it should not.
This might be because slate is overriding the 'data' prop of 'Block/Edit' compnent which contains 'disableNewBlocks' flag and removes it.
So the fix for this might be more than one line fix but IG we can open new ticket  targeting that issue and I can open a PR for fixing title issue separately?


Please invite me to the Recode-Hive GitHub Community Organization

Name
Payal Kumari
Discord Username (if applicable)
payalkumari_
Additional Context
What I Like About This Community:
I admire Recode-Hive’s strong commitment to fostering open-source collaboration and learning. It’s incredible how this community provides such a welcoming space for contributors of all levels, encouraging participation through issues, pull requests, and shared ideas. I particularly appreciate the focus on helping members improve their skills while making meaningful contributions to open-source projects. The combination of learning resources like the GitHub profile course and the practice repo for Hacktoberfest participants shows how dedicated the community is to growth and inclusivity.
Why I Want to Join:
As someone passionate about open source and continuously learning, I’m eager to join this dynamic community to contribute, collaborate, and expand my skills. The structure of Recode-Hive, with its open discussions, good first issues, and supportive network, aligns with my goals of improving as a developer and giving back to the open-source ecosystem. I’m excited to be part of a group that values helping others and driving impactful innovations together.

Invitation sent to join the GitHub Organisation. Welcome to the community 🎉
Don't forget after accepting to make it public so it appears on your GitHub profile for everyone else to see. You can do this by finding your name in the GitHub organisation list and change the dropdown to public https://github.com/orgs/recodehive/people


NYC taxi example: Plot something more interesting

I'll rename it to something more apt (duckdb_nyc_taxi_dataset.py maybe) and will add some docs. Produces this:

Will continue working on this


[ERROR] with "get_csv" imported from opennyai.ner

System Information
opennyai 0.0.10
Python 3.9.13
Ubuntu 22.04.1 LTS
Description
The following code led to an error:
from opennyai.ner import get_csv get_csv(ner_doc_1,'sample_judgement1_NER.csv', save_path=r"/home/krishna/NLP_Justice/POCSO/sample_judgement1_NER.csv")

KeyError                                  Traceback (most recent call last)
/tmp/ipykernel_27488/2496738980.py in
1 # Saving NER Results
2 from opennyai.ner import get_csv
----> 3 get_csv(ner_doc_1,'sample_judgement1_NER.csv', save_path=r"/home/krishna/NLP_Justice/POCSO/sample_judgement1_NER.csv")
~/anaconda3/lib/python3.9/site-packages/opennyai/ner/ner_utils.py in get_csv(doc, f_name, save_path)
99         label.append('PROVISION')
100         normalised_entities.append(pro_ent[2] + ' of ' + pro_ent[3])
--> 101     for pre_head in doc.user_data['precedent_clusters'].keys():
102
103         for ent in doc.user_data['precedent_clusters'][pre_head]:
KeyError: 'precedent_clusters'
Same error is repeated when I check for precednet clusters.
ner_doc_1.user_data['precedent_clusters']
There are PRECEDENTS entities recognized in the judgement.

Hi @d-saikrishna
I have pushed a fix on git for this issue. You can reinstall the library and try the document again. In case issue still remain please share the file so we can replicate and fix the code.
To install the library from source
git clone https://github.com/OpenNyAI/Opennyai.git
cd Opennyai
pip install .

In case you're trying to export the identified entities and clusters. It is highly preferred to do that in form of json as json carry all necessary information such as span and normalised entity for each entity .
To do so you can use the code given in our documentation. where we create a pipeline  and it return the json result of that document.
To export that json to a file you can use this sample code:
import opennyai.ner as InLegalNER
from opennyai.utils import Data
import urllib

###### Get court judgment texts on which to run the AI models
text1 = urllib.request.urlopen('https://raw.githubusercontent.com/OpenNyAI/Opennyai/master/samples/sample_judgment1.txt').read().decode()
text2 = urllib.request.urlopen('https://raw.githubusercontent.com/OpenNyAI/Opennyai/master/samples/sample_judgment2.txt').read().decode()
texts_to_process = [text1,text2] ### you can also load your text files directly into this
data = Data(texts_to_process)  #### create Data object for data  preprocessing before running ML models

pipeline = Pipeline(components=['NER'], use_gpu=use_gpu, verbose=True,ner_model_name='en_legal_ner_trf',
             ner_mini_batch_size=40000, ner_do_sentence_level=True, ner_do_postprocess=True,
             ner_statute_shortforms_path='')

results = pipeline(data)

# Export the results to a json file
import json
with open('output.json','w') as f:
     json.dumps(results,f,indent=4)

Hi @amant555, Thank you for the prompt response.
Yes, there is no error in using "get_csv" after re-installation of the library from github. But, one problem persists:
When I run this identified_entites = [(ent, ent.label_) for ent in ner_doc_1.ents], I can see PRECEDENT entities identified in the judgement text.
But when I run InLegalNER.get_unique_precedent_count(ner_doc_1), I am no able to see the frequency count of PRECEDENTS. Similarly ner_doc_1.user_data['precedent_clusters'] throws a null dictionary.
Sharing the judgement copy on which I faced the issue - PFA
sample.txt


Interpolation symbols are now considered

Angular provides a special $interpolateProvider that you can use to change interpolation symbols from default: {{, }} to something else, e.g.: {~, ~}. The hardcoded template was breaking this functionality in projects that are using custom interpolation symbols. Now it is fixed.

Hello! Could you please merge this PR and create an immediate release? We are looking forward to use your great module in our project = )
Thank you!


Authentication is not working after upgrading to react 18

I have upgraded to React 18. after that when I load the page, it is not coming out of the loading spinner, authentication is not working.
const root = createRoot(document.getElementById('root'));
root.render(
<React.StrictMode>
<AuthProvider {...oidcConfig} >

</React.StrictMode>
);
If I comment <React.StrictMode> then it is working
could you please help me on this
Thankyou.
Regards,
Vijaya

@VijayaSaiRam - can confirm that this library works okay with react 18. See:
https://github.com/authts/sample-keycloak-react-oidc-context/blob/079d739d46521693d55a869e1e0d7109edcf81b8/react/package.json#L19-L20
Your issue may be elsewhere, but it's hard to tell from the snippet you provided.
Can you provide a minimal reproducible example?

I have upgraded to
"react": "^18.3.1",
"react-dom": "^18.3.1",
and to fix the warning [Deprecation notice: ReactDOM.render is no longer supported in React 18]
I have changed code in index.js  to as follows.
import React, {StrictMode} from 'react';
import ReactDOM from 'react-dom';
import { createRoot } from 'react-dom/client';
const root = createRoot(document.getElementById('root'));
root.render(

<AuthProvider {...oidcConfig} >

);
After that authentication is not progressing further.
it is always in the sprinner loading
If I comment  it is working..
Even if I don't fix the warning  [Deprecation notice: ReactDOM.render is no longer supported in React 18] and leave the code as such
ReactDOM.render(
React.StrictMode>
<AuthProvider {...oidcConfig} >

</React.StrictMode>,
document.getElementById('root')
); then also it is working.

After that authentication is not progressing further.
it is always in the sprinner loading

Is this "spinner" from Keycloak, or from your React app?
If it's from your React app, what is the code that toggles this spinner?

Hi,
I stumbled upon the same issue but with oidc-client-ts.
I moved the Provider above the StrictMode and now it works.
Found this issue as well: https://github.com/react-keycloak/react-keycloak/issues/182
Funny thing is, this only happened with Firefox for me. Chrome works fine without doing the workaround.

Hi @Skezzowski - the sample repo uses react 18.x in strict mode and works fine.
Are you able to reproduce your issue there?


FR: Feed cfn-python-lint with JSON Schema of Third-Party Cloudformation resources

TLDR; Add support to import Third-Party CF Resource  JSON Schema specification into cfn-lint (and not just AWS Resources)

cfn-lint version: (cfn-lint --version)
cfn-lint --version
cfn-lint 0.28.3

Description of issue.
Feature request:

I am trying to use recently announced Third-Party resources in CloudFormation.
The early adopter on this concept was DataDog, and resource I am trying to use is Datadog::Monitors::Monitor in one of my CloudFormation stacks.
After importing this TP resource JSON Schema specification in CloudFormation Registry, had no issues stacking stacks with Datadog::Monitors::Monitor resource within.
My IDE (Pycharm) and my CI/CD both use cfn-lint. My CI/CD pipeline uses cfn-lint for validation in the build phase.
I would like to extend cfn-lint to:

not throw errors for unknown (Third-Party) resource, such as below:

not fail build in CI/CD pipeline because it doesn't recognize Datadog::Monitors::Monitor (or any other Third-Party) resource.

The schema of the resource I am interested in (Datadog::Monitors::Monitor) is published at this repo link.

I am curious if this is currently supported and how can I pull that schema in ? Is this configurable via
cfn-lint --update-specs or will I need to re-build cfn-lint by feeding it this TP JSON Schema? Is that even supported?

Cfn-lint uses the [CloudFormation Resource Specifications]
(https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/cfn-resource-specification.html) >as the base to do validation. These files are included as part of the application version. Please update to >the latest version of cfn-lint or update the spec files manually (cfn-lint -u)

Duh, how do I expand them or add external JSON Schema for non-AWS resources...?
Thanks!

Not sure if appropriate label is spec bug ?

being tracked in https://github.com/aws-cloudformation/cfn-python-lint/issues/1277


Chapter 1 supermarket example

Hello there,
While reading the ch1, I was reminded of a little comment that might be of use.
On page 13 at the end of Unsupervised Learning, it is stated, "Running an association rule on your sales logs may reveal that people who purchase barbecue sauce and potato chips also tend to buy steak. Thus, you may want to place these items close to one another."
What I have learned is that supermarkets tend to place items they know people buy together as far apart as possible. This is in order to get customers to walk down as many extra isles as possible, looking at and picking up other non-essential items along the way.
This is only one of many strategies that supermarkets use to "get people to buy more than they planned."
Hope this is useful!
-Kab

Haha, thanks for pointing this out, I assumed supermarkets wanted to improve their service, but I guess I was a bit too optimist: they'd rather improve their sales instead! That said, I'm not sure I want to mention this fact in the book: I'd rather encourage readers to imagine positive applications of Machine Learning. I must be a dreamer...


Review of this wonderful VPN

Great VPN, works stably, and most importantly - for free.
Anechka top)

Do you want any features to be added in future? You can request them here!


WASM through reqwest?

https://github.com/seanmonstar/reqwest/pull/630
Could this be achieved easily?

I haven't tested it yet, but postgrest-rs is a thin wrapper around reqwest so I don't see why it shouldn't work


remove survey for human moderator in human moderator setting

it doesn't make sense to have a human moderator fill out the survey unless we have a separate survey for moderators.

specific to darma, close for boteval


Add SkipExtraFilesOnServer as parameter

To prevent the action to delete folders with static files that were uploaded by a user.
Opened PR here but not a PS expert

Thank you @Samuel8000 for your contribution! Your pull request is merged and the new version is now available 🎉


[zh-cn] sync docs/concepts/scheduling-eviction/topology-spread-constr…

…aints.md

Description

Issue

Closes: #

/lgtm
/approve


Rq Pixel should only be fired in SERP Header removal experiment

Task/Issue URL: https://app.asana.com/0/488551667048375/1182605057307457
Description:
As part of Test improvements to the double search header we added a new pixel because. We should have only added this for the SERP Header Removal Experiment Variant, but it was enabled for all experiments.
Objective
Fix this, so the Pixel is only fired in this variant
Steps to test this PR:
SERP Header Removal Variant

Enable variant zi
Open the app
Type a query in the native toolbar
Check that pixel rq_1 has been fired
Type the same query again
Check that the pixel rq_0 has been fired

Control group

Enable variant zg
Open the app
Type a query in the native toolbar
Check that pixel rq_1 has not been fired
Type the same query again
Check that the pixel rq_0 has not been fired

Internal references:
Software Engineering Expectations
Technical Design Template

❤ those two last commits


Better GraalVM support

While migrating an application to GraalVM I found several issues with the GetStream Java client.
I had to manually include the stream-java2.info file into the binary. Also I had to register several classes for reflection: io.getstream.core.models.serialization.DataDeserializer and 11 anonymous classes of io.getstream.core.Stream.
All these procedures took a lot of time to figure out. It would be great if you could solve them on the library side so that the clients wouldn't have to spend time resolving incompatibilities.

We don't have the expertise for GraalVM so if you want to contribute a how-to doc, we're happy to integrate. Thanks!


CRITICAL | WSServerHandshakeError: 429 message='Invalid response status'

Experiencing the following error in logs after deploying on Azure Cloud using "az up" command in GitHub Codespace.
`2024-11-20T20:08:25.88930  Connecting to the container 'main'...
2024-11-20T20:08:25.94451  Successfully Connected to container: 'main' [Revision: 'capps-backend-xxx--azd-1732091844-6c9995f49b-fnl55', Replica: 'capps-backend-xxx--azd-1732091844']
Closing OpenAI's realtime socket connection.
[2024-11-20 20:07:55 +0000] [7] [ERROR] Error handling request
Traceback (most recent call last):
File "/usr/local/lib/python3.12/site-packages/aiohttp/web_protocol.py", line 452, in _handle_request
resp = await request_handler(request)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/local/lib/python3.12/site-packages/aiohttp/web_app.py", line 543, in _handle
resp = await handler(request)
       ^^^^^^^^^^^^^^^^^^^^^^

File "/app/rtmt.py", line 224, in _websocket_handler
await self._forward_messages(ws)
File "/app/rtmt.py", line 191, in _forward_messages
async with session.ws_connect("/openai/realtime", headers=headers, params=params) as target_ws:
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/local/lib/python3.12/site-packages/aiohttp/client.py", line 1194, in aenter
self._resp = await self._coro
^^^^^^^^^^^^^^^^
File "/usr/local/lib/python3.12/site-packages/aiohttp/client.py", line 848, in _ws_connect
raise WSServerHandshakeError(
aiohttp.client_exceptions.WSServerHandshakeError: 429, message='Invalid response status', url=URL('https://cog-xxx.openai.azure.com/openai/realtime?api-version=2024-10-01-preview&deployment=gpt-4o-realtime-preview')
`

429 is a rate-limit error generally - can you make sure you've closed your tabs using the real-time API and don't have any colleagues using that deployment? With only 1K TPM, it's easy to exceed it.

Connecting...
2024-11-20T20:25:35.16089  Connecting to the container 'main'...
2024-11-20T20:25:35.23117  Successfully Connected to container: 'main' [Revision: 'capps-backend-xxxxxxxxxxx--azd-1732091844-6c9995f49b-fnl55', Replica: 'capps-backend-xxxxxxxxxxx--azd-1732091844']
{"title":"PodrPodOrContainerNotFound","status":404,"detail":"Pod or container main not found.","loggerContext":{"centurionRoleId":"lgn-hostrole-northeurope-001_1406","hostExternalIpv4Address":"<IP_ADDRESS>","legionStampName":"northeurope-001","nestedRoleId":"lgn-hostrole-northeurope-001_1406-nestedvm_2","nestedRoleIpv4Address":"<IP_ADDRESS>","podName":"capps-backend-xxxxxxxxxxxxx--azd-1732091844-6c9995f49b-fnl55","resourceNamespace":"mangowater-e1781041","vmPlatformFaultDomain":"0","vmZone":"2"},"genevaTraceId":"74470fd706e16e30af7d08336e5445fb","callerMemberName":"GetContainerLog","callerFilePath":"C:\__w\1\s\src\Legion\Common.Podr\Services\PodrK8sService.cs"}

@pamelafox, if you can provide assistance.
Really appreciate it.

Yes, No one is using the app.
No error on frontend console.
Mic button is accessible, means front end loading smoothly. Cannot hear any response from OpenAI Realtime API. Indeed 429 suggests rate-limit. But since, no one is accessing the app, I think there's more to look into.

@pamelafox, I cannot click the "Start Listening" button:


Replace fluidSize mixin instances with mobile-first CSS

A SCSS mixin is used in many Svelte files across the project. I used it to help with implementing the design, but they really should all be converted into mobile-first CSS solutions for better maintainability and structure.
Example:
@include fluidSize(18, 48, $propName: "font-size");

Here is an example of fluidSize being used. 18 is the value in pixels for the mobile design and 48 is the value in pixels for the desktop design. "font-size" is the CSS property that is being targeted. A mobile-first CSS alternative is more long-winded, but will be more maintainable over time.
p {
  font-size: 18px;
}

@media screen and (min-width: $breakpoint) {
  p {
    font-size: 48px;
   }
}

💡 Use your best judgement when messing around with the CSS.

Is falling back to @media for font-size a really good idea? Perhaps em could be used as a relative font size instead, combined with the viewport meta tag, which wouldn't need edge cases with @media.

I agree that the font-size property should use em units 👍.
The above code is just an example for converting from the fluidSize mixin in general. In the codebase, there are instances of fluidSize where this conversion would make sense.
For example, when the property is width instead of font-size.

It seems like a CSS var can't be used on a @media like so:
  @media screen and (min-width: var(--desktop-breakpoint)) { /* <-- does not work */
	.screen-wyd div {
	  padding-left: var(--max-padding);
	  padding-right: var(--max-padding);
	  padding-bottom: var(--max-p-font-size);
	}

	.screen-wyd p,
	.screen-wyd h2 {
	  font-size: var(--max-h-font-size-med);
	  padding-bottom: var(--max-p-font-size);
	};
  };

I suppose we still have to keep that specific part SCSS, though I'm not sure if I should still convert all other variables to CSS.

In the future, I think it'll be better if we move all the common attributes like font-size: var(--min-p-font-size) to global.css.


Oppo a16 doesn't show

Hello! as the title says i have this problem that despite enabling USB debuging

https://github.com/Genymobile/scrcpy/blob/master/FAQ.md#device-not-detected
Also check that your USB cable transmits data.


set_microros_wifi_transports() invocation hangs with provided example

Issue template

Hardware description: esp32dev
RTOS: arduino
Installation type: pio
Version or commit hash: main

Steps to reproduce the issue
I'm trying to get the publisher example working over wifi, with the following platformio.ini file contents:
[env]
monitor_speed = 115200
upload_speed = 921600

[env:esp32dev]
platform = espressif32
board = esp32dev
framework = arduino
board_microros_transport = wifi
lib_deps =
    https://github.com/micro-ROS/micro_ros_platformio

The code in Main.cpp is mostly unchanged, except for the wifi setup steps as instructed in the micro_ros_platformio documentation:
const char* ssid = "My-Wifi-Network";
const char* password = "My-Wifi-Password";
const size_t agent_port = 8888;
IPAddress agent_ip(192, 168, 1, 219);
...

void setup() {
    Serial.begin(115200);
    Serial.print("Initializing...");
    set_microros_wifi_transports((char*)ssid, (char*)password, agent_ip, agent_port);
    Serial.print("Done!");
}
...

I'm also running the agent on the host using docker, as follows:
> docker run -it --rm --net=host microros/micro-ros-agent:galactic udp4 -p 8888 -v 6

...with output:
[1653609707.462781] info     | UDPv4AgentLinux.cpp | init                     | running...             | port: 8888
[1653609707.463000] info     | Root.cpp           | set_verbose_level        | logger setup           | verbose_level: 6

I then ran the following steps to build and upload the uros client:
> pio lib install
    <Succeeded>
> pio run
    <Succeeded>
> pio run -t upload
   <Succeeded>
> pio device monitor

Expected behavior
I should start seeing messages being published to a ROS2 topic.
Actual behavior
set_microros_wifi_transports() hangs, and there is nothing printed to the serial monitor after that point:
--- Available filters and text transformations: colorize, debug, default, direct, esp32_exception_decoder, hexlify, log2file, nocontrol, printable, send_on_enter, time
--- More details at https://bit.ly/pio-monitor-filters
--- Miniterm on /dev/ttyUSB0  115200,8,N,1 ---
--- Quit: Ctrl+C | Menu: Ctrl+T | Help: Ctrl+T followed by Ctrl+H ---
Initializing...

As per the code, a Done! should be printed after the transport initialization. However, it never gets to that point.
Also, on the agent, no additional logs show up beyond the two lines that were printed at agent startup:

> docker run -it --rm --net=host microros/micro-ros-agent:galactic udp4 -p 8888 -v 6
[1653609707.462781] info     | UDPv4AgentLinux.cpp | init                     | running...             | port: 8888
[1653609707.463000] info     | Root.cpp           | set_verbose_level        | logger setup           | verbose_level: 6

What am I missing?
Additional information
The host computer (on which the agent is running) has the following ifconfig output (which I have reflected in the wifi connection params in Main.cpp):
wlp4s0: flags=4163<UP,BROADCAST,RUNNING,MULTICAST>  mtu 1500
        inet <IP_ADDRESS>  netmask <IP_ADDRESS>  broadcast <IP_ADDRESS>
        inet6 fe80::65cb:1978:7797:6d81  prefixlen 64  scopeid 0x20<link>
        ether f8:63:3f:df:fe:ad  txqueuelen 1000  (Ethernet)
        RX packets 1865460  bytes<PHONE_NUMBER> (1.4 GB)
        RX errors 0  dropped 6  overruns 0  frame 0
        TX packets 530456  bytes 108092270 (108.0 MB)
        TX errors 0  dropped 0 overruns 0  carrier 0  collisions 0

I've separately verified that the ESP32 board's wifi IS working (using the Wifi.h library):
Connecting to wifi........
WiFi connected!
Assigned IP Address: <IP_ADDRESS>

My environment settings on the agent/host are:
RMW_IMPLEMENTATION=rmw_fastrtps_cpp
ROS_VERSION=2
ROS_PYTHON_VERSION=3
ROS_LOCALHOST_ONLY=0
ROS_DISTRO=galactic

Please try with this fix: https://github.com/micro-ROS/micro_ros_platformio/issues/28

Closing, reopen if the problem persist after the fix


Rw cdn bundle

We need a bundle that can be loaded via a script tag
Description
I propose a bundle that can be loaded via script tag that doesnt mess with our current prod files. We should really take a look at reworking our webpack stuff but for now i think this will work for people who want to load britecharts NOW.
Motivation and Context
cdns are cool!
How Has This Been Tested?
cdn.html in demos
Screenshots (if appropriate):

hi,I am trying to show the tooltip on barchart but could not make it done,please help.
I am using Jquery,CDN LINKS for britecharts .Here is my code......


[WIP] Configure lints in Cargo.toml

Implements #5034
This PR adds a [lints] section to Cargo.toml using the following format:
[lints]
allow_unused = "allow"
non_snake_case = "allow"

Progress

[X] Add lints section to manifest
[X] Pass -W/-A/-D flags to rustc
[ ] Allow specifying lints in workspaces (package level lints take precedence over workspace level)
[ ] Unknown lints are a warning (currently flags are directly passed to rustc which results in an error)
[ ] Support feature syntax: [lints.'cfg(feature = "clippy")']

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon.
If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.
Please see the contribution instructions for more information.

@detrumi I saw your message on Discord, did you figure out the virtual manifest distinction?  There are two manifest types, Manifest and VirtualManifest.  You can look at profiles as an example of something that can be specified in both.  The virtual one is usually accessed via the Workspace.
I'd caution about having packages override the workspace, since that's the opposite precedence of other workspace settings.  I'm not sure how that should work.
Also, just a heads up, rustdoc lint settings will probably be stabilized soon (rust-lang/rust#52354), and will probably want to reuse these for rustdoc.  (Which will also probably need cap-lint support, but I imagine that will land separately.)  One tricky bit is that rustdoc is used in two places (one for doc, and one for tests).
This will likely need a feature flag (see features.rs).

:umbrella: The latest upstream changes (presumably #5726) made this pull request unmergeable. Please resolve the merge conflicts.

@ehuss Thanks for pointing me to profiles, seeing how that's done clears it up a lot.
The package override direction was taken from the proposal text in #5034, but maybe I read that wrong or there was a mistake in that, since you're right that having workspaces override packages makes more sense.
I'll look into the rustdoc flags.

I don't think you misread it, different people will have different expectations.  I'm not sure which way is the right way.  I'm just cautioning that it may not be clear how it should work, and that someone on the cargo team might want to clarify it.

ping @detrumi, have you had a chance to handle some of the follow up comments here?

Some questions:

How should -F (forbid) flags be handled? Workspace lints normally override package lints, but that seems kind of weird for forbidden lints. One option is to let -F flags in packages take priority over workspace lints too. However, this would mean that you can't override that lint in the workspace any more, which might be unpractical.
There was an idea to warn if you specify an unknown lint name. However, I don't know how to check against that, as we don't have a list of known lints. At the moment, passing an unknown lint results in rustc erroring out when Cargo calls it with the lint flags.
Looking at the Appveyor build of my last commit, an import in the test file I added failed to resolve:
use cargotest::support::{execs, project};
This same line is also used in other test files, and locally I can run the test fine. Am I doing something wrong here?

Others may have a better idea how to handle the flags and such but for the test at least it's been tweaked I think since this started, you should be able to just drop the leading cargotest::

Hiya @detrumi, are you still working on this?
It would be an awesome feature to have!

This is unfortunately pretty old at this point so I'm going to close this (and we also have a soft feature freeze right now with Cargo). The Cargo team, however, will hopefully be able to allocate resources for this in early 2019!

@detrumi Would you mind if I pick up this PR in the next days? I would really like to see this implemented in 2019.

@phansch We discussed lint configs at the Cargo meeting yesterday. We would like to see more discussion on the design before continuing. Would you be interested in helping to hash this out on IRLO? The following needs a closer look:

Need a clear description of the motivation and use cases.
Is there a more general solution? How does this relate to other tool configurations such as rustfmt.toml?
Is Cargo.toml really the best place? Need to clarify why to choose one approach over the others.

If the use case is for large organizations to share common settings, then this assumes they have a monolithic workspace which may not be true for everyone.
The counter argument for something like lints.toml is the proliferation of many config files for a Cargo project (rustfmt.toml, lints.toml, .cargo/config, etc.).

How does precedence work? Can packages override workspaces, or the other way around? Or maybe based on strictness (workspaces can make lints more restrictive, not less)?
How much of an issue is errors for unknown lints? My feeling is that it should be OK, but it does set a floor for the minimum supported rustc for something that is not really critical.
How important is it to report the location of the lint? Currently rustc will tell you it's in the command-line. Finding the correct location for the lint may be tricky in a large project. I personally think it would be good to have the intent to implement location reporting in rustc before stabilization.

We don't really feel this needs a full RFC process, but we would at least like to see the content/questions that arise during that process to be addressed.

@ehuss Makes sense. I'm going to try to write something up based on https://github.com/rust-lang/cargo/issues/5034 and incorporate all the different aspects this potentially touches. I will create a post on IRLO in the coming days :+1:

@detrumi Would you mind if I pick up this PR in the next days? I would really like to see this implemented in 2019. (I would probably start with a fresh PR)

Yes, feel free to work on this. Creating a post on IRLO seems like a good way to push this forward, as there are too many open questions.


Make kerberos optional

There are issues with building snakebite since the dependency is on python-krbV, which in it's turn needs the header files for kerberos. This makes kerberos support optional and installable through pip install "snakebite[kerberos]"

@ravwojdyla

Should fix #168


[#1179] feat(build): Make Gravitino build and run against JDK8, 11, 17

What changes were proposed in this pull request?
This PR proposes to add multiple JDK version support for building and running Gravitino server, including JDK8, 11, and 17.
Users could specify the version they want to build in gradle.properties, like:
jdkVersion = 8

or

jdkVersion = 11

or

jdkVersion = 17

Or users could specify the version by ./gradlew build -PjdkVersion=8.
Our generated jars are JDK 8 version compatible, so it can run against Java runtime 8, 11, and 17.
Why are the changes needed?
To make Gravitino build, test and run against multiple JDK versions.
Fix: #1179
Does this PR introduce any user-facing change?
No.
How was this patch tested?
This was compiled, tested, run on JDK8, 11, and 17 locally.

How do we ensure the PRs by other development works for JDK  11 and 17 since GitHub action runs with JDK 8. Do we verify it before a release?

I will change the CI to support running on JDK11 and 17 in the next PR.

I will change the CI to support running on JDK11 and 17 in the next PR.

I'm afraid of CI time bombs, I prefer to test on JDK 11 and 17 before release

I will make the

I will change the CI to support running on JDK11 and 17 in the next PR.

I'm afraid of CI time bombs, I prefer to test on JDK 11 and 17 before release since there're few JDK compatiable issues.

Agreed, we can test locally and make sure it's okay to use 8, 11, and 17. Adding them to CI may make it difficult to develop in Git Hub.

I will take a try to enable all the CI matrix, if it is too long, I'll see how to handle this.


[Bug(Serious)-FE][UI Next][V1.0.0-Alpha]Failed to save a workflow containing a child workflow node

Search before asking

[X] I had searched in the issues and found no similar issues.

What happened
Failed to save a workflow containing a child workflow node

What you expected to happen
Successfully saved and ready to run
How to reproduce
1、First complete a new workflow
2、Create a new workflow that is being edited
3、Drag a sub-workflow component
4、Set the sub-workflow as the first new workflow completed
5、Click Save Workflow to report an error
The front end does not pass information about the child node to the back end
Anything else
No response
Version
dev
Are you willing to submit PR?

[ ] Yes I am willing to submit a PR!

Code of Conduct

[X] I agree to follow this project's Code of Conduct

I will fix it.


chore(deps): upgrade configuration

Upgrades project dependencies. See details in workflow run.

Automatically created by projen via the "upgrade-configuration-k8s-27-main" workflow

⚪ Backport skipped
The pull request was not backported as there were no branches to backport to. If this is a mistake, please apply the desired version labels or run the backport tool manually.
Manual backport
To create the backport manually run:
backport --pr 3000

Questions ?
Please refer to the Backport tool documentation


Update index.html

It will look enhance in button icon and good for user

Please take me in Octoberfeast

what changes you have done?
favicon is already there

No there is no favicon is there


Use a generic class for model validation in validator class

refactor validator class to use a generic validation method instead of multiple validation

Close by This PR


How to uninstall?

How can I uninstall themekit?

If you are on linux/macOS just run rm $(which theme) and if you are on windows you can remove it from where you put it (usually C:\Program Files\Theme Kit

Thanks.


App image doesn't build within the TRE

The Dockerfile needs to be updated to use the TRE package mirror in order to build inside the TRE. Likely needs a conditional copy if /etc/apt/sources.list exists etc.

Even using the TRE sources I get. Maybe not easily resolvable


The version setting for the docs-integration-sdk artifact in the Java Spring example code is incorrect

<dependency>
			<groupId>com.onlyoffice</groupId>
			<artifactId>docs-integration-sdk</artifactId>
			<version>1.2.1-SNAPSHOT</version>
</dependency>

in pom.xml,but

Hi @Akchth
This is unexpected
The release was posted earlier https://github.com/ONLYOFFICE/docs-integration-sdk-java/actions/runs/11066921369/job/30749166093#step:7:14

Re-posted version 1.2.1-snapshot


tests/hassh Add test cases for hassh

This commit adds test cases for the ssh.hassh, ssh.hassh.string, ssh.hassh.server, ssh.hassh.server.string keywords.
Modifies https://github.com/OISF/suricata-verify/pull/257 by

Added testing for ssh banners only session.
Added testing for ssh session without reaching NewKeys message.

https://github.com/OISF/suricata/pull/5105

https://github.com/OISF/suricata-verify/pull/262


perf: use par_sort on TxLookup stage

Use rayon par_sort instead before inserting

Codecov Report

Merging #2137 (aac1973) into main (843efe8) will decrease coverage by 29.91%.
The diff coverage is 100.00%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@             Coverage Diff             @@
##             main    #2137       +/-   ##
===========================================
- Coverage   71.97%   42.06%   -29.91%
===========================================
  Files         440      440
  Lines       53796    53796
===========================================
- Hits        38718    22631    -16087
- Misses      15078    31165    +16087

Flag
Coverage Δ

integration-tests
15.66% <0.00%> (-3.77%)
:arrow_down:

unit-tests
35.43% <100.00%> (-30.52%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

crates/stages/src/stages/tx_lookup.rs
55.49% <100.00%> (-37.18%)
:arrow_down:

... and 240 files with indirect coverage changes
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Frequent error reporting

What's your problem?

First of all, thank you for your contribution in making such an excellent plug-in. But after I installed it, every time I opened it, I was prompted that there were duplicates in the "reading history", as shown in the picture.

Did them duplicates again after you merged them?

Yes

It still appears after closing the software and reopening it.

In addition, I noticed that issue #48 still exists.

It still appears after closing the software and reopening it.

Disable the plugin Chartero
Merge the duplicate items
Restart Zotero
Enable Chartero

In addition, I noticed that issue #48 still exists.

Please clearly indicate which specific issue is it.

Disable the plugin Chartero
Merge the duplicate items
Restart Zotero
Enable Chartero

Sorry， it does not work.

It still appears after closing the software and reopening it.

Disable the plugin Chartero
Merge the duplicate items
Restart Zotero
Enable Chartero

When you switch the literatures, this bug will occur again.

In addition, I noticed that issue #48 still exists.

Please clearly indicate which specific issue is it.

Reading has no record

It feels like a new reading record will be generated every time you read it, instead of continuing the original reading record.

If you operate on the same computer and read different documents each time, the record will increase as the number of operations increases.

check your scanPeriod preference
disable all other plugins and submit debug log here


feat: implementing solve another button and separating logic for redi…

Closes #99
At first this may seem like a lot of changes but it is just moving components to its own files and creating a few new functions.
Let me address what I've done:

Added a small eslint configuration just to match prettier with proper linting
Likewise added .editorconfig
Removed obvious comments such as // Get Problem List from leetcode graphql API from function getProblemListFromLeetCodeAPI() as the name is pretty self descriptive
Moved the global variables to a single variable called state so it is easier to get intellisense on what we have as state
Moved HyperTortureMode to its own component
Moved Permission Checking logic to its own component.
Separated updateStorage into 2 functions (now we have updateProblemState) which only updates which problem we are solving, this is used in solveAnother() logic so that we can just fetch a new problem for the user without necessarily re-enabling the redirects
Created a function to handle whether or not we should redirect on additional problems (aka: solveAnother()) based on a new setting: "should redirect on additional problems"

Great PR really cleaned everything up and made it way easier for future modifications thanks so much for this!


[W6.2b][T09-2]Tay Ran Tian

W6.2b LO: added a polymorphic isMutating method

@arty9
Please ensure that tests are updated accordingly as you make changes in the code.


Create FizzBuzz.cs

Just added a csharp version :)

C# FizzBuzz. Thanks, Rob! If possible please modify it so it prints 1-100, thanks.

Should work now hopefully


bug fix vscan node compile error

Proposed changes
Issue Number: close #xxx
Problem summary
conflict merge of #15604 and #15618
Checklist(Required)

Does it affect the original behavior:

[ ] Yes
[x] No
[ ] I don't know

Has unit tests been added:

[ ] Yes
[x] No
[ ] No Need

Has document been added or modified:

[ ] Yes
[x] No
[ ] No Need

Does it need to update dependencies:

[ ] Yes
[x] No

Are there any changes that cannot be rolled back:

[ ] Yes (If Yes, please explain WHY)
[x] No

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 37.19 seconds
load time: 526 seconds
storage size:<PHONE_NUMBER>0 Bytes
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230111044323_clickbench_pr_77341.html


Difference with HR inside UL between MarkdownExtra and ParsedownExtra

This code:
* a
* b
  ---
* c

Gives different results in MarkdownExtra and ParsedownExtra.
MDE parses the line as a HR, PDE makes b into a header.
When using *** for HR, MDE and PDE render the same.

This is expected and in compliance with the CommonMark spec. It happens because it recognises a setext header.


Adding button to move to next and previous blog

Added the blog navigation option to move to "next" and "previous" posts from the blog page itself.

Screenshot

Yeah, that's nice. Just perhaps only "« Previous" and "Next »"?
And perhaps use the same button style as for "Read More" on the main blog
page (same question for the "Older" and "Newer" links there).

Yeah, that's nice. Just perhaps only "« Previous" and "Next »"? And perhaps use the same button style as for "Read More" on the main blog page (same question for the "Older" and "Newer" links there).
…

I think design-wise having these buttons as secondary(not solid) were good option, attached screenshot

I think design-wise having these buttons as secondary(not solid) were good option, attached screenshot
image

Ok, so you preferred the original design, correct, @indraraj?

I think design-wise having these buttons as secondary(not solid) were good option, attached screenshot
image

Ok, so you preferred the original design, correct, @indraraj?

Yes

Thx!


Fix mutating extant resources not forcing new

Replacement for #157 rebased onto current main history
@OJford

Fixes #154, https://github.com/fly-apps/terraform-provider-fly/issues/19#issuecomment-1435082902.

I'd have happily rebased, no need for a new PR, this one needs it again now anyway.
Is there anything else needed to get this merged?


tooltop

I have bootstraps tooltip in element with hidden overflow. When i hover button with tooltip, part of tooltip is hidden by parent div.

Tooltiptip component defined in ui-bootstap-tpls.js
What can i try?

You haven't read the issue template, am I right?


Is it possible to use Arduino SDK?

Hi,
Last night I googled about homekit on esp32 using arduino sdk. I have to say I didnt find much. This project seems solid and to work. I didnt find out if it is possible to run it with arduino sdk. My program uses few arduino libraries which are dependent on arduino sdk. I would like to add homekit feature without homebridge.
Is it possible? Is there any example/tutorial?
Thanks

@maximkulkin Does it possible to make integration with arduino ide without open rtos? I thought, you only need to confirm the HAProtocol?

I do not care. Supporting other platforms is possible in Arduino IDE, but apart to having a button to upload compiled firmware, Arduino is a pretty shitty IDE targeted mostly to write 20 line sketches. So nothing I would miss about it.

@Rjayone I managed to get it running in Arduino IDE

@Rjayone I managed to get it running in Arduino IDE

Could you describe the process or give any information how i to do this?

@Rjayone I managed to get it running in Arduino IDE

Could you describe the process or give any information how i to do this?

I created it from scratch. But it might be easier to grab it from here https://github.com/Yurik72/ESPHap


Update chassis COTS components

Updated battery dims, and (accordingly) battery brackets
Updated bus bar dims
Added ODrive brake resistors (Closes #41)
Added Jetson power regulator (Closes #38)

Brake resistors can be seen here:

Jetson regulator can be seen here:

my god u actually modelled the whole brake resistor instead of just a box

Only thing i have concerns for is routing of the encoder cables. we should probably try to run them farther from the power lines and if its still bad, then buy some shielding

Only thing i have concerns for is routing of the encoder cables. we should probably try to run them farther from the power lines and if its still bad, then buy some shielding

Ye I agree

Only thing i have concerns for is routing of the encoder cables. we should probably try to run them farther from the power lines and if its still bad, then buy some shielding

Ye I agree

could we run the encoder cables seperate of the power ones and have them go under the chassis up a hole?

Only thing i have concerns for is routing of the encoder cables. we should probably try to run them farther from the power lines and if its still bad, then buy some shielding

Ye I agree

could we run the encoder cables seperate of the power ones and have them go under the chassis up a hole?

The bottom of the odrive panel is too full I think. tbh I think just running them straight across the top of the odrives, rather than off to the sides in the same bundles as the motor lines, would probably suffice.


Implement UserDataHolder for EditorDataContext

This PR fixes Hannah-Sten/TeXiFy-IDEA#2230
How to reproduce the issue

In build.gradle.kts, add a dependency on plugin TeXiFy-IDEA: nl.rubensten.texifyidea:0.7.14
runIde
Go to Settings > Editor > Code Style, set Hard wrap at to 120 characters and enable Wrap on typing.
Create a LaTeX file (.tex) and paste the following content:

\begin{itemize}
    \item This is the first item: pressing enter at the end of this line will insert an \verb|\item| on the next line.
    \item This line should hard-wrap to a next line without inserting an \verb|\item| in front of it, when typing here:
\end{itemize}

Continue typing after ... when typing here:
Expected behaviour, and this is what happens when IdeaVim is not installed: the text is wrapped to the next line, no \item is inserted.
Actual behaviour with IdeaVim installed: \item is inserted at the beginning of the next line.

Issue description

The AutoHardWrapHandler:188 saves data for a custom key to the data context. Without IdeaVim, the data context is an EdtDataContext, with IdeaVim the EditorDataContext which has as contextDelegate the EdtDataContext.
TeXiFy implements a typed handler, which checks for this data key in order to determine whether an auto hard wrap is in progress.
Without IdeaVim, TeXiFy can retrieve the data from the context. With IdeaVim, the data cannot be retrieved from the context (DataManager#loadFromDataContext) because the context is not a UserDataHolder.

Issue fix
This PR fixes that last point, so that the IdeaVim data context now correctly delegates the user data.
I verified that it fixes the problem, but please check if this doesn't break something else.

Hi there! Thank you for your contribution.
That seems to be a save fix, so I'll merge this without additional checks.

Great, thanks a lot!


fn: introducing lb placer basic metrics

This change adds basic metrics to naive and consistent
hash LB placers. The stats show how many times we scanned
the full runner list, if runner pool failed to return a
runner list or if runner pool returned an empty list.
Placed and not placed status are also tracked along with
if TryExec returned an error or not. Most common error
code, Too-Busy is specifically tracked.
If client cancels/times out, this is also tracked as
a client cancel metric.
For placer latency, we would like to know how much time
the placer spent on searching for a runner until it
successfully places a call. This includes round-trip
times for NACK responses from the runners until a successful
TryExec() call. By excluding last successful TryExec() latency,
we try to exclude function execution & runner container
startup time from this metric in an attempt to isolate
Placer only latency.

@kppk @kmjohansen Does it look better now?
One important, but unrelated with metrics change here is rp.Runners(call) error return
action. I've changed the semantics here a bit and documented it in the interface. That is,
if an error is returned, we do not need to retry-loop.


"TypeError: res is undefined" when i tried to sign in

I did everything according to the instructions from GitHub. When I try to login, I get an error "TypeError: res is undefined". Please, help me to resolve that problem

Can you show me the logs of master node?

Can you show me the logs of master node?

Sorry, can you tell me where i can found that logs?

Can you show me the logs of master node?
admin:///var/lib/docker/containers/3c2a86430ee99ec57bdc3ee90472c1153fa0a328f152d6b7a6dadd9127f05edf/3c2a86430ee99ec57bdc3ee90472c1153fa0a328f152d6b7a6dadd9127f05edf-json.log

Can you show me the logs of master node?

Can you show me the logs of master node?

I checked a lite version, everything is working fine. But i still have an issue with full version

The issue seems to be from your mongo connection shown in the logs. Can you check if your mongo is running okay.

The issue seems to be from your mongo connection shown in the logs. Can you check if your mongo is running okay.

I installed oldest version of mongod 4.2, now master is started succesfully. Mongo is working, but exception is still here

I can see from your docker ps results that the mongo container is restarting, so something is definitely off there.

I can see from your docker ps results that the mongo container is restarting, so something is definitely off there.

I reinstall my OS to Ubuntu 18.04 because i though the problem is something with Ubuntu 20. I tried to install mongodb from official site, tried to install mongodb 4.4, 4.2 and 5.0 (5.0 isn't works because there is troubles with avx support, my cpu dont support it). I tried to check the connection, i think everything is good. What i should try to fix that?

I can see from your docker ps results that the mongo container is restarting, so something is definitely off there.

It's decided. The whole problem was that in docker-compose.yml specified mongo:latest, so mongo 5.0 was used, and it is not supported on my CPU. Changed to mongo:3.6.3 and everything worked. Thank you so much for your help!


Ensure storing is finished before exiting application

There is still finishStoring in the Solver class. Maybe its useful for this case

would be useful for autosave


Event utilities throw an error when window.parent.postMessage is called

VM745:642 Uncaught TypeError: undefined is not iterable (cannot read property Symbol(Symbol.iterator))
    at window.onmessage (<anonymous>:642:35)

Fixed in 2.1.6


Additional authentication methods via HTTP headers

Currently we only support http basic auth, but there could be systems that require a token (oauth). What about adding an option to let you define custom request headers like:
$headers = [
    'X-Some-Header' => 'Value'
];
$resource = $reader->download('http://linuxfr.org/news.atom', $last_modified, $etag, $user, $password, $headers);

Since the method signature becomes kinda big we should probably reduce it or create a buidler like:
$reader = new ReaderBuilder();
$reader->target($url)
    ->withCache($etag, $lastModified)
    ->withBasicAuth($user, $pass)
    ->withHeaders($headers)
    ->download();

Seems to be a good idea.
However, I'm thinking if having a custom http library in picoFeed is a good idea after all. Maybe we should just use an external library like Guzzle? that will probably simplify a lot the code base of PicoFeed.

Guzzle seems like a good idea, the commit history is very active https://github.com/guzzle/guzzle/commits/master and afaik it seems to be a widely used lib. It would be interesting to see how much code we could ditch.

I'm thinking about refactoring PicoFeed completely. There are too many features in this library:

Parsing feeds
Generating feeds
OPML import/export
Generate item contents
Filtering HTML
Scrapping websites
2 different HTTP clients

The library should focus only on RSS/Atom feeds (parsing, syndication and OPML).
Filtering HTML and web scraping can be split into other libraries. PicoFeed should not even worry about making HTTP requests. Only the HTTP body can be passed to the parser.
In this way, the code can be simplified a lot, easier to maintain, easy to unit test. Any thoughts?

Offloading stuff to guzzle is a good idea, in unsure however how easy it will be to split out filtering. If the result will be that users are vulnerable to XSS when omitting the filtering part this is probably the wrong way.
Things that are from my perspective totally unrelated:

parsing and creating opml
creating RSS/atom feeds

Those could be moved to a separate repo.
My main complaints stem concerning maintainability stem from the following points:

too much state. There should almost never be a reason to write to properties in a class unless it's a pure data object. A good rule of thumb is to check if there could be race conditions if the same instantiated object is used by different threads. This keeps me from actively committing code btw since things are close to impossible to refractor
too many public methods, too hard to unit test: this point will go away if you are using dependency injection consistently. Also smaller classes can help.

PS: If you would require a newer PHP version (like 5.5 or 5.6) we could probably get rid of zendxml since the bug is fixed already

Another thing that comes to my mind: PHP is absolutely fucked up in terms of library isolation and autoloaders are basically a giant hack.
Let's say picoFeed would require guzzle 1.x but ownCloud ships 0.5. Then whatever requires guzzle first in owncloud would dictate the library version. Even worse: it could be that both libraries would be mixed depending on the order of usage and autoloader registering.
ownCloud actually ships guzzle :D

Adding a headers option would be nice!
GitHub feeds are accessible with the Header Accept:application/atom+xml (example URL: https://github.com/CodeBrauer)


[curl] fix linkage type control

There are at least five variables to control linkage type in curl CMakeLists.
BUILD_SHARED_LIBS is an option and depending on its value each of CURL_STATICLIB, ENABLE_SHARED, ENABLE_STATIC, CPPFLAG_CURL_STATICLIB are set in different files.
The portfile tries to control the linkage type with cmake options but it sets CURL_STATICLIB rather than BUILD_SHARED_LIBS. CURL_STATICLIB is then overwritten by curl cmakes. However vcpkg doesn’t know anything about it and changes curl.h header file directly, setting wrong linkage type:
https://github.com/microsoft/vcpkg/blob/b03f62e0ebc1b5515bc8a1f41f3bfe9eca6589d4/ports/curl/portfile.cmake#L152
This leads to crushes of programs which use curl in certain build configurations.

Thanks for the PR and sorry for the long delay!
Can you please provide a repro project that demonstrates the failure without this change?
Additionally, vcpkg_configure_cmake() will automatically pass in BUILD_SHARED_LIBS based on VCPKG_LIBRARY_LINKAGE, so that part of this change is not needed.

I can't repro this issue.


⚠ Bofrost.be has degraded performance

In e1ec22e, Bofrost.be (https://www.bofrost.be) experienced degraded performance:

HTTP code: 200
Response time: 1125 ms

Resolved: Bofrost.be performance has improved in 2f4beff.


Merge two keywords

Coverage remained the same at 64.774% when pulling c8073a4559b7eee2f38f63f182fda73c4bd65a81 on iBug:patch-2 into 447ce232d743f7ad1cfd5200ff8d56807804fe07 on Charcoal-SE:master.

Was the removal of testoram accidental?

@angussidney Take a look at the very line directly under the removal.

!!/approve


Array-instances of modules naming doesn't match verilator's VCDs

When a module is instanced multiple times:
flop flop_instances[3:0] (
  .clk (clk),
  .d (d),
  .q (q)
);

Surelog names these instances flop_instances0 flop_instances1, ..., but verilator puts parentheses around the instance number when writing VCD files.
It would be nice if they matched, seeing as they should be compatible within the chipsalliance projects.

flop_instances(0) ?
What we really need is what the Standard says, can you check the commercial simulators in EdaPlayground?

That's what I figured, but I couldn't find any language in the IEEE1800-2017 standard that says what it should be named. This is unlike the generate blocks with genblk0 etc.
I checked both vcs and metrics, they use square brackets, flop_instances[0]. I have also seen tools use square brackets and  also prepend the escape character \flop_instances[0] since those brackets are technically not legal identifier characters if they were to appear in manually unrolled source code. So it's not totally consistent, but having surelog and verilator both use square brackets is probably closer to what we want.

Fixed by #1622

I see you used the leading escape. Section 5.6.1 of the IEEE1800 spec says "Neither the leading backslash character nor the terminating white space is considered to be part of the identifier", but it would be there in source code. So I don't know if the UHDM should include the backslash or not. What do you think?

Also - would it make sense to file a bug against verilator to match it? I imagine that could be pretty disruptive.

I have 0 preference, these are tool arbitrary choices, I'd rather we stay close to the consensus from commercial simulators and get verilator to follow.Can you submit a put request with the naming scheme you prefer and update the logs?Modify the same code I changed,
makemake regressioncd build../tests/regression.tcl update
Sent from Yahoo Mail on Android
On Sat, Aug 7, 2021 at 15:08, Pieter @.***> wrote:
Also - would it make sense to file a bug against verilator to match it? I imagine that could be pretty disruptive.
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.

Will do.

Hmm - When I run update, tons of the logs get polluted with my local
working directory, e.g.:
_class_defn: @.***) /home/pieter/work/pieter3
${SURELOG_DIR}/build/bin/sv/builtin.sv:4:1:
On Sat, Aug 7, 2021 at 3:15 PM alaindargelas @.***>
wrote:

I have 0 preference, these are tool arbitrary choices, I'd rather we stay
close to the consensus from commercial simulators and get verilator to
follow.Can you submit a put request with the naming scheme you prefer and
update the logs?Modify the same code I changed,
makemake regressioncd build../tests/regression.tcl update
Sent from Yahoo Mail on Android
On Sat, Aug 7, 2021 at 15:08, Pieter @.***> wrote:
Also - would it make sense to file a bug against verilator to match it? I
imagine that could be pretty disruptive.
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/chipsalliance/Surelog/issues/1614#issuecomment-894712500,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAESBZTJK7WEL3DA7RI3WQDT3WWANANCNFSM5BW54JFQ
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email
.


Refinement should work across different property types

In general when refining types, you must refine using a === undefined vs a == null even though the latter is technically a superset of the other.
https://flow.org/try/#0KYDwDg9gTgLgBDAnmYcDiUIFcwEEswAW0AyjNMACICGM1cAvHAN4CWAzgPIDuAdsFAD8ALjgAjCBAA2warwA0cKQBNqYDNjCj2MKK14BzAL4BuAFChIsBMlQl9BmfiKlyUKrXpNm1AsSgAqlisytq6DoocPPxCohLSsrymZhbg0PBIKHDO-mQUNHSMZnBwAD5wACQAoiDUAMYwADwVAEqyypy8UoiN9oZOfq75ngB8I8VllTX1Ta3tnd2NGjg5Q+4F1GPmZgBmWLwNrBC8cAbAMACSygCMABS+LlCiq1B5654AlGF6hiwT7jAsFATg9-AA6FRqZZgOAAQgYTH2ymAO30wGUcEEcFB0AhqnUmBwcFEOKgYNJQRC5iMKQA9LS4Bd2LwAOQZQioOoQAC2YGoUFo0DgHPc2Lg7BwAnY5zgEB2p3OV2uLPYgl2+0OxwVl2UACZ7oMntlDW8PHQvuLwr9mP9zkCQYa8VDCTD4XBeFgpFJMdjHZCCZpib7HuTDZTlNS6Qymaz2ZyeXyBW5hQJUPQJSgoNL4HLtUqVWq9gcYEcTmcdQBmA2PZ4mtxm6gWnQ-Ax-EoA+3B8H+6GMJger0+0mhx7hoPDnsu6lAA

Taking a closer look at this, I believe this is a general issue of disjoint union refinements. They don't work across separate property types (like number vs string).
type N = {| prop: number |};
type S = {| prop: string |};
declare var user: S | N;
if (typeof user.prop === 'number') {
  (user: N); // Error?!
}

[try flow]
vs
type N = {| prop: 'n' |};
type S = {| prop: 's' |};
declare var user: S | N;
if (user.prop === 'n') {
  (user: N); // Error?!
}

[try flow]

This now works


Refactor forkHomework function and add forking tests for gitlab module

I moved the HTTP request from the forkHomework function into its own function. I also added unit tests for the new forkProject function, including a test for forkHomework when forking fails.

Was merged through cloning


BUG: Allow Superbuild options to be passed to subprojects

CMake options specified when configuring superbuild are now passed
down to the BRAINSTools-build sub directory.

@hjmjohnson @jcfr
I think that this fixes the problem.

Nice.
That said, this should not be needed. It looks like mark_as_superbuild does not play its role. Having a look now.

Yeah, the solution feels kind of like a hack. I'll check out mark_as_superbuild as well.

@jcfr Thank you for reviewing.  I'm busy with grants with week and can not spend too much time on it.

For reference, see https://github.com/BRAINSia/BRAINSTools/pull/284#issuecomment-227870086
My last commit fixes the issue.

Fixed by #288

Great work.   The same issues probably exist in ants an NAMICExternalProject since they share a common code genesis.
Sent from my iPhone

On Jun 22, 2016, at 2:57 PM, ajjl<EMAIL_ADDRESS>wrote:
@hjmjohnson @jcfr
I think that this fixes the problem.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.


[Suggestion] Make cursor blink toggleable

Currently, I have a fork that disables cursor blink. It would be preferable if the blink was a feature that could be toggled in a configuration option.
I can implement this, but I won't get around to it until the weekend.

👍 Yes, I totally agree. This should be toggeable to not override user preferences or force users to use this feature.
I'll go for it tomorrow evening.

👍 excellent! Thanks 😄

I've implemented a configuration attribute to set the cursor blinking feature.
It can be tested by checking out  🌱 feature/ghi-#7-make-cursor-blink-toggleable.
Information on how to configure Nord Hyper can be found in the configuration section in the README.

Excellent! When will this be released?

I'll prepare the next release version now to push it to NPM.

🚢 Shipped in release version 🏷  0.3.0 and pushed as NPM :package: package update.

I think hyper just released a new version that includes some built in option for cursor blinking. Maybe it would make sense to check that option instead?


Added post-build commands for copying Vulkan .dlls to output directory

Describe the issue
After pulling the repository, if we try running Hazelnut, the application crashes because the required .dll files at vendor\VulkanSDK\Bin are not in proper place.
PR impact
List of related issues/PRs this will solve:

Impact
Issue/PR

Issues this solves
None

Other PRs this solves
None

Proposed fix
A hacky solution without changing any implementation is to manually copy and paste the files in the output directory.
A somewhat automated solution is to use the premake's postbuildcommand to copy the files.
Additional context
Not the most robust or optimal solution, could be better.

Similar to previous attempts at using the post build command, we need to make sure the directory exists to prevent crashes. Since this is not entirely the same, can you confirm this works for a clean build?

Similar to previous attempts at using the post build command, we need to make sure the directory exists to prevent crashes. Since this is not entirely the same, can you confirm this works for a clean build?

The premake {COPY} token expands to something that does check directory existence (at least, it does on Windows).  I have checked (on my fork) that a clean checkout works (where "works" means that after building Hazelnut, the vulkan debug libs are there in the Hazelnut bin folder)


enable reading of pbfs with node location for ways

Fixes #110

Uff. I don't remember. I would have to check it. But I think you are right.
On Tue 27 Jun 2023, 17:26 Sergiu Pantiru, @.***> wrote:

@.**** commented on this pull request.
On
core/src/test/resources/com/acervera/osm4scala/primitives/way/way-with-geo
https://github.com/simplexspatial/osm4scala/pull/111#discussion_r1244028044
:
I kept it the same as the other file (way). It's a serialized protobuf no?
—
Reply to this email directly, view it on GitHub
https://github.com/simplexspatial/osm4scala/pull/111#discussion_r1244028044,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AACHURA5NFRPNGBQTUM4SF3XNMCSTANCNFSM6AAAAAAZVF5GQU
.
You are receiving this because you commented.Message ID:
@.***>

Hi @sergiupantiru Tests are still failing. Do you need help?

Hi @sergiupantiru Tests are still failing. Do you need help?

Hey, if you have time I always welcome help. I'm not close to a computer for the next 3 weeks.

Hi @sergiupantiru Tests are still failing. Do you need help?

Hey, if you have time I always welcome help. I'm not close to a computer for the next 3 weeks.

No rush, take your time.

can you please take another look?

hey, any updates on this?

@sergiupantiru All looks fine. I remember that I checked it locally as well, but I want to be sure.Next week I will expend time on it.


Fix data race on migrate repository

The data race occupied when both two go routines run repo.getOwner and it will set repo.Owner. Since UpdateRepoIndexer(repo) will send the repo pointer to another goroutine, this PR lets it runs after all other operations finished to resolve the data race.  A complete solution to resolve this like problem is to change UpdateRepoIndexer(neededRepoInfo) to only copy needed information from repo.

partially fix #5189

Codecov Report

Merging #5224 into master will decrease coverage by 0.04%.
The diff coverage is 57.14%.

@@            Coverage Diff             @@
##           master    #5224      +/-   ##
==========================================
- Coverage   37.49%   37.45%   -0.05%
==========================================
  Files         309      309
  Lines       45827    45836       +9
==========================================
- Hits        17185    17169      -16
- Misses      26179    26197      +18
- Partials     2463     2470       +7

Impacted Files
Coverage Δ

models/repo.go
43.55% <57.14%> (-0.02%)
:arrow_down:

models/repo_indexer.go
44.49% <0%> (-6.36%)
:arrow_down:

modules/process/manager.go
76.81% <0%> (-4.35%)
:arrow_down:

modules/base/tool.go
74.12% <0%> (-0.41%)
:arrow_down:

routers/repo/view.go
44.78% <0%> (-0.28%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 735b12e...16cbaac. Read the comment docs.

@lunny LGTM.
To prevent such bugs in the future, are the following rules correct (required)?

the values of Repository should not be copied.
the pointers of Repository should not be passed across the boundary of gourintes.

@lunny regarding data race, 1. is not required. I made that assumption to be easier to reason about it. I thought the Repository is supposed to be immutable after loaded, but it's not. If I understand correctly, the code updates the Repository objects, and all changes of the objects would be synced back to the database.
If we have two copies of Repository objects for the same git repo and one of them is updated, then the two copies of Repository objects would be inconsistent, which I think would be a problem.


Stdlib template

Add string.Template substitution for both os.environ and --var key:value command line args with the --var setting taking precendence
Cleaned up test suite
Cleaned up command line parsing
Removed dead code and tests
Moved tests into suitable modules
Added release notes to begin to log all of the various changes
Next PR will be remove --directory and update docs to reflect its removal

https://forest-informaticslab.readthedocs.io/en/stdlib-template/release-notes.html

I think this has gone as far as it can and is now a bottleneck for downstream developments


Feature Request: Export container settings to dockerfile

I have a series of containers that I have set up and been using with Kitematic and would like to share them with my team. I'd love to send them a dockerfile with all the configurations that I currently have ready to go.
As far as I'm aware, I can't find a way to export the configurations of my containers in Kitematic to a Dockerfile. Is such a thing possible?

There isn't such feature unfortunately - However, you can inspect the containers and save the JSON file provided. This will have the configuration you want.
If you can implement it, it'd be great to see this show up as a feature in Kitematic :P

Awesome. I would love to give this a shot later this week. I've been doing lots of work in react/redux lately, and this would be a great way for me to learn about electron and contribute to an open source project.

@glyif @agiron123  Yeah I guess we would have to inspect the container and then generate the Dockerfile from the JSON. Currently we are using dockerode https://github.com/docker/kitematic/blob/ec955fc6263e63c2d76e49dd06bf94c13e11095d/src/utils/DockerUtil.js#L53. We could therefore do something like
this.client.getContainer(CONTAINER_ID).inspect((err, data) => {
  if(!err){
     // generate Dockerfile from data
  }
}

@collin5 looking forward to your PR 🌮

@FrenchBen Will submit a PR for this soon 👍