Readme fixes

What was wrong with wrapping? I tried to do 80 symbols. Is it too many?

I do 72, but that's irrelevant. The point is that there were some very long lines, which I wrapped.

I see. I was thinking about README.md. For consistency, what is the standard wrapping requirement ( 80 or 72)?

Some people do 72, some do 78, some do 80. I personally prefer 72 since that's what most people use for git (commit messages are padded by 4 spaces on either side, so 80-8).
Consistency in wrapping is not a big deal as long as lines are wrapped somewhere between 70 and 80 chars, I'd say.


pip install modin.  ERROR: Could not find a version that satisfies the requirement ray==0.6.6 (from modin) (from versions: none) ERROR: No matching distribution found for ray==0.6.6 (from modin)

System information

OS Platform and Distribution (e.g., Linux Ubuntu 16.04):
Modin installed from (source or binary):
Modin version:
Python version:
Exact command to reproduce:

Describe the problem

Source code / logs

Hi @halesantosh, it looks like you might be using Windows. Read here for how to install from Windows: https://modin.readthedocs.io/en/latest/installation.html#windows
If you are not using Windows, please let me know your OS/Python version and which Modin version you are trying to install. Thanks!

Note, we do have an active effort on Windows support, see #657.

Closing this. Feel free to reopen if the discussion should continue or if issue was not resolved.

Hi @halesantosh, it looks like you might be using Windows. Read here for how to install from Windows: https://modin.readthedocs.io/en/latest/installation.html#windows
If you are not using Windows, please let me know your OS/Python version and which Modin version you are trying to install. Thanks!

I need to install ray[rllib]==0.7.6 on python 3.8 ubuntu 20.04 but having issues. could someone please help?

@jerrybaba2 Ray is on release 1.2 and we dropped support for ray < 1.0 because of some API changes.


[editor]: Support project in preview

Please add support for .project files to the editor preview.
Generated by adamraichu.zip-viewer

Done. 👍🏻


Create RecHit and PFRecHit SoA formats and PFRecHitProducerAlpaka

PR description:

PR validation:

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Before submitting your pull requests, make sure you followed this checklist:

verify that the PR is really intended for the chosen branch
verify that changes follow CMS Naming, Coding, And Style Rules
verify that the PR passes the basic test procedure suggested in the CMSSW PR instructions

Merged on other PR with cleaner commits.


Invalid dictionary construct

When I run a pdf through a locally hosted api I receive the following error:
Invalid dictionary construct: [/'Color', [20224, 32768, 32768], /'Dimmed', False, /'Editable', True, /'Preview', /b'tru', /b'e', /'Printed', True, /'Title', b'Layer 1', /'Visible', True]"}

I can't seem to find that error anywhere in the code base so don't even know where to get started on how to address.  Can anyone tell me what this means and how to address?

@drewB this appears to be a known (for three years now) problem with pdfminer for certain documents like yours that have invalid content but I expect still render using a reader application.
How frequently are you encountering this and do you know the provenance of the affected documents (like published via Word SaveAs PDF, etc.)?

Thanks for your reply and pointing to the pdfminer issue.  I was trying to fix an issue that I was running into with a different pdf lib  so only tried a couple pdfs.  As a result, can't really speak to the provenance.   This pdf was a book proof from the author but don't know how it was created.  I ended up switching to adobe's pdf extract api and that provided the solution I was looking for which was a more structured pdf output so I could exclude repeated things like page headers.  It also had no trouble with the pdf.

Researching a little more I did find this https://github.com/paperless-ngx/paperless-ngx/issues/900#issuecomment-1199358633.  I haven't tried the suggestion but might help others who run into this problem.

Thanks @drewB, that's good insight :)
I'm going to close this for now but feel free to reopen if you think there's something we can do :)

I had the same issue and was able to resolve it using ghostscript to repair the pdf
gs -o output.pdf -sDEVICE=pdfwrite -dPDFSETTINGS=/prepress input.pdf


Add extensive testing for zero-width Logics and LogicValues

Motivation
There have been multiple bugs found related to zero-width Logics and LogicValues.
Desired solution
Add a bunch of tests covering behavior of things when the are zero-width, both functionally and for synthesis.

See #57

Some things to consider:

Unary operations (in gates and on LogicValues) need to probably throw an error when called on a 0-width signal

I can take this

It would also be convenient to have isEmpty  for Logic and LogicValue.

It would also be convenient to have isEmpty for Logic and LogicValue.

You mean just as automation for .width == 0?

Yes.

Additionally, swizzling of no signals (or only zero-width signals) should throw an exception.


Guest Access - Splash : Can't save the splash page designer until the page is reloaded.

Visit the splash page > click design.
A red button appears bottom right. This does not work until the page has been reloaded.

Fixed by this: https://github.com/cucumber-tony/cucumber-frontend/commit/eeacc58b8d53bf6bfe762010631de06b6efb6be3
Had to remove the fab speed dial as it wasn't playing with the side-nav.


RAC-1984 (somewhat) Removal of node/:id/workflows POST CIT test

This CIT test fails when run against the fix for GET node/:id/workflows (https://github.com/RackHD/on-http/pull/613)
The POST for node/id/workflows works with master and the above GET fix. However, the CIT test breaks and blocks the GET fix from getting merged. I propose that this test be temporarily removed so the GET API fix can be moved in. Meanwhile a new ticket will be added for correcting the CIT test for POST.
What I have in the pipes at the moment is this test removal, the API fix, and a new GET CIT test.

@hohene and @johren, can you both take a look at this and see if my reasoning checks out?
It seems to me that a test built to succeed with a flawed API is not a test worth keeping. This is why I just commented the whole thing out.

@RackHD/corecommitters, Any eyes would be appreciated

@RackHD/corecommitters
Can this be merged please?


Added step to delete AAD B2C tenant

Registered applications must also be deleted first before you can delete the tenant.

@jelledruyts : Thanks for your contribution! The author, @davidmu1, has been notified to review your proposed change.

Hi @jelledruyts
Microsoft authors and contributors need to make content contributions through the private repository so the content can be staged and validated by the current validation rules.
After you review staging and fix all validation issues, you can add the sign-off comment to let PR reviewers know that the updates are ready to be merged.
For more information, see Should I work in a private or a public repo?
If you need help getting set up to work in the private repo, see Set up Git repository locally for documentation. You can contact the<EMAIL_ADDRESS>alias for peer support, if needed.
Would you create a pull request in the private repo to make these updates? We'll close this PR. Thank you.


Spinner - integer overflow on 32-bit systems

Deployer version: 7.0.0-beta.5
Deployment OS: Armbian 20.08

dep deploy

fails with error

In Master.php line 28:
Undefined offset: -5

On 32-bit systems, integer range overflows when trying to calculate microtime(true)*10
https://github.com/deployphp/deployer/blob/master/src/Executor/Master.php#L28

Please, check what next code will solve it:
function spinner(string $message = ''): string
{
-    $frame = FRAMES[(int)(microtime(true) * 10) % count(FRAMES)];
+    $frame = FRAMES[(int)(microtime(true) * 10) % count(FRAMES)];
    return "  $frame $message\r";
}

It seems working fine now. Great job!


change "account ID" to "public key"

For internal consistency with docs. @irisli is this okay?

Technically, the correct term is public key and I originally did that. But then I switched to "Account ID" because it's the more relevant term. For the same reason I labelled the page as "Account Creator" instead of "Keypair Generator (with friendbot)" since 95% of the uses of this page will be for accounts.
Though with the public key vs account ID, I'm kinda wavering. Public key is the more broadly recognized term but Account ID is the more relevant term.

I hear ya. I don't mind "Account creator" at the top - that's correct, because a keypair = an account. But account id will be confusing, since we refer to it in the docs (and everywhere else) as a public key. I strongly vote for changing it. @jessica-collier ?

Account ID and public key are often synonymous, as I understand them, but then there are cases when they're not. I think that we need to make it clearer what each term means and surface the appropriate one when necessary. In this instance, I'm not sure that I understand the logic at play. @irisli, how is Account ID more relevant (because it refers explicitly to an "account"?) even though public key is technically correct and more recognizable, and why is "relevance" the better option?

I sat "relevance" because it is more related to what it will be used for.
However, after thinking about it, I believe that it might be better to change it to public key so that it is easily recognizable.


try to use dask to solve memory issue when doing association rules

I am trying dask to solve the memory issue when doing assoication rules which need to transfer trasaction data into large scale one hot data. But somehow, I did not how to make it. This is what I have tried.
For memory issue, I have to save te_arry as sparse matrix, but I still need to transfer back  to array to generate dask dataframe, it will be still memory issue.
from mlxtend.preprocessing import TransactionEncoder
import dask.array as da
import dask.dataframe as dd
from mlxtend.frequent_patterns import apriori

dataset = [['Milk', 'Onion', 'Nutmeg', 'Kidney Beans', 'Eggs', 'Yogurt'],
           ['Dill', 'Onion', 'Nutmeg', 'Kidney Beans', 'Eggs', 'Yogurt'],
           ['Milk', 'Apple', 'Kidney Beans', 'Eggs'],
           ['Milk', 'Unicorn', 'Corn', 'Kidney Beans', 'Yogurt'],
           ['Corn', 'Onion', 'Onion', 'Kidney Beans', 'Ice cream', 'Eggs']]
te = TransactionEncoder()
te_ary = te.fit(dataset).transform(dataset, sparse=True)
test = dd.from_dask_array(da.from_array(te_ary.toarry(), chunks=2), columns=te.columns_)
ddf_out = test.map_partitions(lambda df: df.assign(result=apriori(df, use_colnames=True)))

Traceback:
File "/home/ubuntu/anaconda3/envs/tensorflow_p36/lib/python3.6/site-packages/dask/dataframe/utils.py", line 137, in raise_on_meta_error
yield
File "/home/ubuntu/anaconda3/envs/tensorflow_p36/lib/python3.6/site-packages/dask/dataframe/core.py", line 3453, in _emulate
return func(*_extract_meta(args, True), **_extract_meta(kwargs, True))
File "", line 1, in
ddf_out = test.map_partitions(lambda df: df.assign(result=apriori(df, use_colnames=True)))
File "/home/ubuntu/anaconda3/envs/tensorflow_p36/lib/python3.6/site-packages/pandas/core/frame.py", line 3649, in assign
data[k] = com.apply_if_callable(v, data)
File "/home/ubuntu/anaconda3/envs/tensorflow_p36/lib/python3.6/site-packages/pandas/core/frame.py", line 3467, in setitem
self._set_item(key, value)
File "/home/ubuntu/anaconda3/envs/tensorflow_p36/lib/python3.6/site-packages/pandas/core/frame.py", line 3545, in _set_item
NDFrame._set_item(self, key, value)
File "/home/ubuntu/anaconda3/envs/tensorflow_p36/lib/python3.6/site-packages/pandas/core/generic.py", line 3382, in _set_item
self._data.set(key, value)
File "/home/ubuntu/anaconda3/envs/tensorflow_p36/lib/python3.6/site-packages/pandas/core/internals/managers.py", line 1071, in set
self.insert(len(self.items), item, value)
File "/home/ubuntu/anaconda3/envs/tensorflow_p36/lib/python3.6/site-packages/pandas/core/internals/managers.py", line 1180, in insert
block = make_block(values=value, ndim=self.ndim, placement=slice(loc, loc + 1))
File "/home/ubuntu/anaconda3/envs/tensorflow_p36/lib/python3.6/site-packages/pandas/core/internals/blocks.py", line 3265, in make_block
return klass(values, ndim=ndim, placement=placement)
File "/home/ubuntu/anaconda3/envs/tensorflow_p36/lib/python3.6/site-packages/pandas/core/internals/blocks.py", line 2773, in init
super().init(values, ndim=ndim, placement=placement)
File "/home/ubuntu/anaconda3/envs/tensorflow_p36/lib/python3.6/site-packages/pandas/core/internals/blocks.py", line 128, in init
"{mgr}".format(val=len(self.values), mgr=len(self.mgr_locs))

Thanks for filing an issue. In general when reporting issues you want to provide:

a reproducible example (something we can just copy-paste and run)
information about what went wrong. What happens when you run the above code? Does it error? What's the full traceback.

Please read the following blogpost for more information about crafting good issue reports: https://blog.dask.org/2018/02/28/minimal-bug-reports

@ywzhang188 in the last line in your example
ddf_out = test.map_partitions(lambda df: df.assign(result=apriori(df, use_colnames=True)))

I think apriori(df, use_colnames=True) is returning a Pandas DataFrame with two columns, however df.assign needs a Series as input.
I don't think this is an issue with Dask.

Closing as this doesn't seem to be an issue with Dask


Disable colored console output when standard output isn't a TTY

This prevents Godot from writing ANSI escape codes when redirecting stdout and stderr to a file (like we already do in SCons). This is generally the expected behavior of programs on UNIX-like platforms.
I suppose we should eventually add a --color CLI argument to force colored output (e.g. for use in CI systems that support displaying ANSI escape codes).
TODO

Implement this on Windows if possible

I tested this on Windows and it seems the problem doesn't occur in the first place (due to how text is colored on Windows). Therefore, I consider this PR to be ready.

Thanks!


Add penalized loss function and integrate with fit/update

PR to master - do not merge.

Codecov Report

Merging #178 (52b987d) into master (a40bdfd) will increase coverage by 0.60%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #178      +/-   ##
==========================================
+ Coverage   90.74%   91.34%   +0.60%
==========================================
  Files           8        9       +1
  Lines         216      231      +15
==========================================
+ Hits          196      211      +15
  Misses         20       20

Impacted Files
Coverage Δ

src/common.jl
96.77% <100.00%> (+0.22%)
:arrow_up:

src/core.jl
90.00% <100.00%> (-0.79%)
:arrow_down:

src/penalized_losses.jl
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a40bdfd...52b987d. Read the comment docs.


Add simple calculator

Title and Issue number

Title :
Issue No. : #288
Code Stack :
Close #288

Checklist:

[] I have mentioned the issue number in my Pull Request.
[] I have commented my code, particularly in hard-to-understand areas
[] I have created a helpful and easy to understand README.md
[] I have updated the Index.html file for my contribution

@AnshMeshram Calculator is already a part of the Mini challenges


Allow custom fallback languages when translation is missing

[x] I have read the contributing guidelines and I agree with the Code of Conduct
[x] Have you checked that there aren't other open pull requests for the same changes?
[x] Have you tested that the committed code can be executed without errors?

Relates to #1752
I have added infrastructure to make it possible for devs to manually add languages that the translation can fall back on if the translation for a language is missing. The only fallbacks I've implemented by now are if translation to Norwegian Nynorsk is missing, the translation to Norwegian Bokmål will be shown (and the other way around).
It would be helpful to take the fallbacks automatically from the windows setting, but I haven't found any way to do that yet.
5dc39a8 is there for no reason other than VScode not allowing me to sync changes unless I commit a change where the difference is none.
e8f2ac0 contains the changes I've made.

I will need to modify the code a little bit to prevent performance impacts.
Anyway, thanks for the PR!


wrong number of arguments (given 1, expected 2) in snapshot runner.rb:200

Issue Description
Complete output when running fastlane, including the stack trace and command used
WARN [2016-09-01 17:28:33.32]: Erasing iPhone 6 Plus...
DEBUG [2016-09-01 17:28:33.39]: Fetching available simulator devices
ERROR [2016-09-01 17:28:33.48]: wrong number of arguments (given 1, expected 2)
ERROR [2016-09-01 17:28:33.48]: Backtrace:
       	/usr/local/lib/ruby/gems/2.3.0/gems/snapshot-1.14.0/lib/snapshot/test_command_generator.rb:67:in `find_device'
       	/usr/local/lib/ruby/gems/2.3.0/gems/snapshot-1.14.0/lib/snapshot/runner.rb:200:in `open_simulator_for_device'
       	/usr/local/lib/ruby/gems/2.3.0/gems/snapshot-1.14.0/lib/snapshot/runner.rb:151:in `launch'
       	/usr/local/lib/ruby/gems/2.3.0/gems/snapshot-1.14.0/lib/snapshot/runner.rb:70:in `run_for_device_and_language'
       	/usr/local/lib/ruby/gems/2.3.0/gems/snapshot-1.14.0/lib/snapshot/runner.rb:76:in `rescue in run_for_device_and_language'
       	/usr/local/lib/ruby/gems/2.3.0/gems/snapshot-1.14.0/lib/snapshot/runner.rb:70:in `run_for_device_and_language'
       	/usr/local/lib/ruby/gems/2.3.0/gems/snapshot-1.14.0/lib/snapshot/runner.rb:49:in `block (3 levels) in work'
       	/usr/local/lib/ruby/gems/2.3.0/gems/snapshot-1.14.0/lib/snapshot/runner.rb:37:in `each'
       	/usr/local/lib/ruby/gems/2.3.0/gems/snapshot-1.14.0/lib/snapshot/runner.rb:37:in `each_with_index'
       	/usr/local/lib/ruby/gems/2.3.0/gems/snapshot-1.14.0/lib/snapshot/runner.rb:37:in `block (2 levels) in work'
       	/usr/local/lib/ruby/gems/2.3.0/gems/snapshot-1.14.0/lib/snapshot/runner.rb:36:in `each'
       	/usr/local/lib/ruby/gems/2.3.0/gems/snapshot-1.14.0/lib/snapshot/runner.rb:36:in `block in work'
       	/usr/local/lib/ruby/gems/2.3.0/gems/snapshot-1.14.0/lib/snapshot/runner.rb:35:in `each'
       	/usr/local/lib/ruby/gems/2.3.0/gems/snapshot-1.14.0/lib/snapshot/runner.rb:35:in `each_with_index'
       	/usr/local/lib/ruby/gems/2.3.0/gems/snapshot-1.14.0/lib/snapshot/runner.rb:35:in `work'
       	/usr/local/lib/ruby/gems/2.3.0/gems/fastlane-1.102.0/lib/fastlane/actions/snapshot.rb:17:in `run'
       	/usr/local/lib/ruby/gems/2.3.0/gems/fastlane-1.102.0/lib/fastlane/runner.rb:190:in `block (2 levels) in execute_action'
       	/usr/local/lib/ruby/gems/2.3.0/gems/fastlane-1.102.0/lib/fastlane/actions/actions_helper.rb:35:in `execute_action'
       	/usr/local/lib/ruby/gems/2.3.0/gems/fastlane-1.102.0/lib/fastlane/runner.rb:175:in `block in execute_action'
       	/usr/local/lib/ruby/gems/2.3.0/gems/fastlane-1.102.0/lib/fastlane/runner.rb:174:in `chdir'
       	/usr/local/lib/ruby/gems/2.3.0/gems/fastlane-1.102.0/lib/fastlane/runner.rb:174:in `execute_action'
       	/usr/local/lib/ruby/gems/2.3.0/gems/fastlane-1.102.0/lib/fastlane/runner.rb:100:in `trigger_action_by_name'
       	/usr/local/lib/ruby/gems/2.3.0/gems/fastlane-1.102.0/lib/fastlane/fast_file.rb:140:in `method_missing'
       	../../../../../../../../../../../var/folders/_7/x9hx93w16lz4y5clj8g44xx40000gn/T/fl_clone20160901-32843-h2y4jo/fastlane.git/fastlane/Fastfile.ios:101:in `block (4 levels) in parsing_binding'
       	../../../../../../../../../../../var/folders/_7/x9hx93w16lz4y5clj8g44xx40000gn/T/fl_clone20160901-32843-h2y4jo/fastlane.git/fastlane/Fastfile.ios:92:in `each'
       	../../../../../../../../../../../var/folders/_7/x9hx93w16lz4y5clj8g44xx40000gn/T/fl_clone20160901-32843-h2y4jo/fastlane.git/fastlane/Fastfile.ios:92:in `block (3 levels) in parsing_binding'
       	../../../../../../../../../../../var/folders/_7/x9hx93w16lz4y5clj8g44xx40000gn/T/fl_clone20160901-32843-h2y4jo/fastlane.git/fastlane/Fastfile.ios:91:in `each'
       	../../../../../../../../../../../var/folders/_7/x9hx93w16lz4y5clj8g44xx40000gn/T/fl_clone20160901-32843-h2y4jo/fastlane.git/fastlane/Fastfile.ios:91:in `block (2 levels) in parsing_binding'
       	../../../../../../../../../../../var/folders/_7/x9hx93w16lz4y5clj8g44xx40000gn/T/fl_clone20160901-32843-h2y4jo/fastlane.git/fastlane/Fastfile.ios:89:in `loop'
       	../../../../../../../../../../../var/folders/_7/x9hx93w16lz4y5clj8g44xx40000gn/T/fl_clone20160901-32843-h2y4jo/fastlane.git/fastlane/Fastfile.ios:89:in `block in parsing_binding'
       	/usr/local/lib/ruby/gems/2.3.0/gems/fastlane-1.102.0/lib/fastlane/lane.rb:33:in `call'
       	/usr/local/lib/ruby/gems/2.3.0/gems/fastlane-1.102.0/lib/fastlane/runner.rb:153:in `try_switch_to_lane'
       	/usr/local/lib/ruby/gems/2.3.0/gems/fastlane-1.102.0/lib/fastlane/runner.rb:108:in `trigger_action_by_name'
       	/usr/local/lib/ruby/gems/2.3.0/gems/fastlane-1.102.0/lib/fastlane/fast_file.rb:140:in `method_missing'
       	../../../../../../../../../../../var/folders/_7/x9hx93w16lz4y5clj8g44xx40000gn/T/fl_clone20160901-32843-h2y4jo/fastlane.git/fastlane/Fastfile.ios:33:in `block (2 levels) in parsing_binding'
       	/usr/local/lib/ruby/gems/2.3.0/gems/fastlane-1.102.0/lib/fastlane/lane.rb:33:in `call'
       	/usr/local/lib/ruby/gems/2.3.0/gems/fastlane-1.102.0/lib/fastlane/runner.rb:49:in `block in execute'
       	/usr/local/lib/ruby/gems/2.3.0/gems/fastlane-1.102.0/lib/fastlane/runner.rb:45:in `chdir'
       	/usr/local/lib/ruby/gems/2.3.0/gems/fastlane-1.102.0/lib/fastlane/runner.rb:45:in `execute'
       	/usr/local/lib/ruby/gems/2.3.0/gems/fastlane-1.102.0/lib/fastlane/lane_manager.rb:46:in `cruise_lane'
       	/usr/local/lib/ruby/gems/2.3.0/gems/fastlane-1.102.0/lib/fastlane/command_line_handler.rb:30:in `handle'
       	/usr/local/lib/ruby/gems/2.3.0/gems/fastlane-1.102.0/lib/fastlane/commands_generator.rb:49:in `block (2 levels) in run'
       	/usr/local/lib/ruby/gems/2.3.0/gems/commander-4.4.0/lib/commander/command.rb:178:in `call'
       	/usr/local/lib/ruby/gems/2.3.0/gems/commander-4.4.0/lib/commander/command.rb:153:in `run'
       	/usr/local/lib/ruby/gems/2.3.0/gems/commander-4.4.0/lib/commander/runner.rb:444:in `run_active_command'
       	/usr/local/lib/ruby/gems/2.3.0/gems/fastlane_core-0.50.3/lib/fastlane_core/ui/fastlane_runner.rb:36:in `run!'
       	/usr/local/lib/ruby/gems/2.3.0/gems/commander-4.4.0/lib/commander/delegates.rb:15:in `run!'
       	/usr/local/lib/ruby/gems/2.3.0/gems/fastlane-1.102.0/lib/fastlane/commands_generator.rb:246:in `run'
       	/usr/local/lib/ruby/gems/2.3.0/gems/fastlane-1.102.0/lib/fastlane/commands_generator.rb:20:in `start'
       	/usr/local/lib/ruby/gems/2.3.0/gems/fastlane-1.102.0/lib/fastlane/cli_tools_distributor.rb:58:in `take_off'
       	/usr/local/lib/ruby/gems/2.3.0/gems/fastlane-1.102.0/bin/fastlane:5:in `<top (required)>'
       	/usr/local/bin/fastlane:23:in `load'
       	/usr/local/bin/fastlane:23:in `<main>'

Environment
fastlane 1.102.0

Hi @cwilhelm Thanks for the PR. Can you add testing to it so we can merge faster? We'll work with you there 👍 Thanks!

Perfect, thanks @cwilhelm. I saw that the parameter was missing, however I couldn't cause a crash locally. In what use-cases did this cause an issue? Should we do a release for this change?

My call of snapshot is
snapshot(
    app_identifier: app_identifier,
    reinstall_app: true,
    localize_simulator: true,
   skip_open_summary: true
)

which fastlane outputs as
+----------------------------+-----------------------------------------------------------------+
|                                   Summary for snapshot 1.14.0                                    |
+----------------------------+-----------------------------------------------------------------+
| app_identifier             | com.ieffects.xxx.demo.dev                                       |
| reinstall_app              | true                                                                |
| localize_simulator         | true                                                                |
| skip_open_summary          | true                                                                |
| devices                    | ["iPhone 6s", "iPhone 6s Plus", "iPhone 5s"]                        |
| languages                  | ["en-US", "de-DE"]                                                  |
| scheme                     | xxxDemo-dev                                                     |
| workspace                  | ./xxxDemo.xcworkspace                                           |
| output_directory           | /Users/cwilhelm/Documents/workspace/ifxshop/shops/iphone/xxx... |
| launch_arguments           | [""]                                                                |
| clear_previous_screenshots | false                                                               |
| erase_simulator            | false                                                               |
| buildlog_path              | ~/Library/Logs/snapshot                                             |
| clean                      | false                                                               |
| number_of_retries          | 1                                                                   |
| stop_after_first_error     | false                                                               |
+----------------------------+------------------------------------------------------------------+

and the before mentioned backtrace. Do you need more information?

I tried running it with the exact same parameters and it's working just as expected for me. Could you upload a demo project or get it to fail on the snapshot sample project?

👍 for newer releases.


Alluxio's async through mode cause inconsistencies in ufs

Alluxio Version:
2.6.1
Describe the bug
In async through mode, create file b then delete file b, from the perspective of ufs, it may see delete b then create b.
To Reproduce
add code below in PersistDefinition, before "        bytesWritten = IOUtils.copyLarge(in, out, new byte[8 * Constants.MB]);"
        Runtime runtime = Runtime.getRuntime();         Process proc = runtime.exec("/home/adol/works2/alluxio/bin/alluxio fs rm /ufsMountPoint/myFile11");         proc.waitFor();         LOG.info("eeeeeeeeeeeeeeeeeeeeeeeeeeeeee|" + proc.exitValue());
then compile code, start alluxio,
create file /ufsMountPoint/myFile11, you will see /ufsMountPoint/myFile11 is deleted, but synchronized to ufs
Expected behavior
persist in strict order

do you see eeeeee in your log? our code should have cancelled the persist job when it sees the delete call. so if you do see eeeeee then it might be something wrong with our cancellation logic. @adol001

do you see eeeeee in your log? our code should have cancelled the persist job when it sees the delete call. so if you do see eeeeee then it might be something wrong with our cancellation logic. @adol001

Yes, I see, and exitValue is 0.
Delete action will cancel persist job. But in the actual test, most of the persist job was completed
"
Starting job Id=1636508935502 Config=PersistConfig{filePath=
Job completed Id=1636508935502 Config=PersistConfig{filePath=
"
And even if the cancellation is successful, it cannot interfere with the persist job executed on job_worker, because the next step of the delete action in the Reproduce instance is bytesWritten = IOUtils.copyLarge(in, out, new byte[8 * Constants.MB]);, it’s too late

@adol001 any reason why you closed this? seems like an important issue to address?

@adol001 any reason why you closed this? seems like an important issue to address?

@yuzhu
The issue was closed because of two issues. First, our ufs system delete was actually delete -rf before, and second, the local file ufs seemed to be no problem.
However, it was discovered today that if the ufs file is not persisted, it will not trigger the ufs deletion. Even if it is a local file ufs, there will still be residual files in the .alluxio_ufs_persistence directory, and the object file system, because of MASTER_UNSAFE_DIRECT_PERSIST_OBJECT_ENABLED, will leave non-hidden files in the target directory
So, Alluxio's async through mode cause inconsistencies in ufs, the problem still exists


(maint) Test with Java 17

This is similar to the Puppet Server version.
I assume when merged up to main we will want to move all the main testing cells to Java 17 & move Java 11 to the legacy cell now occupied by Java 8.

https://github.com/puppetlabs/puppetserver/pull/2659


Claims requested through scope parameter should not be available in the ID Token for flows issuing an Access Token

Describe the issue:
For requests where an access token is issued, the requested claims through the scope parameter are currently available in the id_token which is considered as an unintended exposure of user data by the OIDC Conformance Suite.
According to the OIDC Specification - Section 5.4, the claims requested by the scope parameter are returned from the User info endpoint, when a response_type value is used that results in an Access Token being issued (All the flows except id_token). However, when no Access Token is issued (which is the case for the response_type value id_token), the resulting Claims are returned in the ID Token because it is not possible to obtain them through the user info endpoint.
How to reproduce:

Send an authorization request with response_type=code id_token and scope=openid email
Example request:
https://localhost.com:9443/oauth2/authorize?client_id=qLczTJrGUomvnypu88RLoZbEX2Ia&redirect_uri=https://localhost.emobix.co.uk:8443/test/a/test/callback&scope=openid%20email&state=bGyRRmzjTQ&nonce=KKawgq6XTP&response_type=code%20id_token
Login using admin admin credentials.
Extract the id_token from the response url.
Decode the ID Token using jwt.io and check the list of claims.

Expected behavior:
For the above response_type, since an authorization code is issued which can be used to obtain an access token, the requested claims can be obtained through the userinfo endpoint. Therefore email claim should not be returned through the id_token.

@ImalshaG To get a better understanding, here we will get email in the id token as we have added the email as a scope is that the case? In that case if we map claims country and email for the scope email, the claims country and email will be added to the id token right? Can you please elaborate on this ?

In this case, since the response_type is code id_token, we can obtain the email claim using the user info endpoint (using the code to get an access token and then using this access token to call the user info endpoint). Therefore we should not send the email claim inside the id_token here. If there is a possibility to call the user info endpoint, the requested claims should only the retrieved using that. These claims should be available in id_token only if we can't retrieve them through the user info endpoint (for response_type=id_token).

This issue is being closed due to extended inactivity. Please feel free to reopen it if further attention is needed. Thank you for helping us keep the issue list relevant and focused!


not doing anything for me

I've installed the tabs-to-spaces package and enabled it in Atom 1.9.7. I've loaded a javascript file that mixes spaces and tabs at the beginning of lines. When I run tabify it doesn't appear to do anything. Neither does untabify or untabify all.
I would expect this to just operate on the open file (the docs aren't clear about this), but I've also tried highlighting bits of code, and it doesn't seem to make any changes there either. Do you know if there are compatibility issues with nuclide or esformatter?

It shouldn't make any visible changes at all if you don't have Show Invisibles enabled. Everything should maintain the same visual alignment but the underlying characters change from spaces to tabs or vice versa.
So far, it sounds like things are working as expected.  Perhaps some steps to reproduce the problem? What do you expect to happen? What is actually happening?

Please let me know if you have any more questions. If there is something going wrong, I'd like to fix it. If you can give me some more details, I'll reopen the issue.


Upstream merge for nilrt/kirkstone

Sustaining 2657887: Regular NILRT distro upstream merge (i05)
With this PR, the latest changes of meta-virtualization will be merged to nilrt/master/kirkstone. There were no merge conflicts.
Testing:
Ran the following to generate images:
bitbake packagefeed-ni-core
bitbake nilrt-safemode-rootfs
bitbake nilrt-base-system-image
bitbake nilrt-recovery-media
Installed the newly built nilrt-base-system-image-x64.tar on a VM and verified the target boots into run-mode without any problems.
@rajendra-desai-ni, @prasanna-nib, please review the changes.
Note: Maintainers, please complete this merge manually (i.e. to avoid upstream hashes being changed by GH).

I ran the script again, and I have force pushed the commits. Please check if this is fine.


build: adopt static linking for Yams on Windows toolchain

Windows now partially supports static linking of Swift libraries (non-swiftCore targets).  Use this to enable static linking of Yams as there is a single user (swift-driver).  This allows us to save ~256KB due to the internalisation.

Please test with following PRs:
https://github.com/apple/swift-installer-scripts/pull/155
https://github.com/apple/swift-llbuild/pull/852
https://github.com/apple/swift-installer-scripts/pull/158
@swift-ci please build toolchain Windows platform

Please test with following PRs:
https://github.com/apple/swift-installer-scripts/pull/155
@swift-ci please build toolchain Windows platform

Please test with following PRs:
https://github.com/apple/swift-installer-scripts/pull/155
@swift-ci please smoke test


How to support multiple Docker versions and not mess up vendoring

it is not clear how we would handle supporting misc. Docker versions - engine API is in ./vendor... so will we keep multiple versions there ? How would we test ?

We will always support the latest release in master and that has to be backward compatible. So far we have not encountered a problem. Is this still an issue?

@msterin What needs to be done here?

nothing. We rely on docker keeping reasonable (current and one prior) API compatibility


Authentication Problem

Hello ,
First Thanks for the Platform ,
After following the installation guide  i note that two tables added to the database chosen users and migrations .
But after the graphical installation step , there is no line added to the DB
and when i try to login , this process failed with These credentials do not match our records.
any help ?
Thanks .

Same problem here

Hello ,
After doing some research , i found the issue source :
Migration is failed due to key error (key is too long than 1000 bytes )
so to fix this  :
add to the boot function in app/Providers/AppServiceProvider.php
Schema::defaultStringLength(191);
don't foget to  include the necessary use statement at the top of the file:
use Illuminate\Support\Facades\Schema;
Hope this helps solving the issue .

Hello, please check if all migrations have been installed, if not, run artisan vendor: publish & artisan migrate. After that, you can also create a user using the artisan make: admin command.
Also, please specify that your database (MySQL v 5.7 or PostgreSQL) must support JSON.
I have encountered such cases if the graphical installer was started using artisan serve. It does not have the ability to update .env in the process.


In-App Review Modal

What type of PR is this? (check all applicable)

[ ] Refactor
[x] Feature
[ ] Bug Fix
[ ] Optimization
[ ] Documentation Update

Description
Added code to exit the note page after saving. The in-app review modal is shown before exiting. Additionally, a log file was added to capture any errors while fetching the app review popup.
Features Covered in this PR

[x] Added In-App Review Popup

Related Tickets & Documents

Related Issue #216
Closes #216

Tested Feature

Was unable to test it as it requires the app to be published on the Playstore to work.

Thanks for contributing!

There are some formatting issues, please run dart format --line-length 80 --set-exit-if-changed --output none . once


gradlew: use readlink to read a link instead of attempting to parse ls

Parsing ls is notoriously fragile and should be avoided when possible.
Let's use readlink (part of coreutils, just like printf which is
already used in this file) to read links instead of a fragile parsing of
ls.
The current code breaks if any part of the link or its derefs contains
->  (uncommon, granted). You can test that breakage with:
$ ln -s 'bar -> baz' foo

@marcphilipp done :+1:

Please fix ApplicationIntegrationSpec and UnixStartScriptGeneratorTest (see the build for details) and rebase on master. 🙂

I'm not sure I understand... is the CI actually complaining that the script is one line shorter than it used to be? How is that a problem? :thinking:

Thanks for your contribution. I'm sorry we didn't get back to you in a reasonable amount of time.  If someone thinks this change is still valuable, please submit a new PR.
Thanks again!


Assignee_id must be nullable

A primary IP can be unassigned and therefore assignee_id will be null, which led to an exception.
Fatal error:  Uncaught TypeError: Argument 12 passed to LKDev\HetznerCloud\Models\PrimaryIps\PrimaryIp::__construct() must be of the type integer, null given, called in /opt/ops-ip-lister/vendor/lkdevelopment/hetzner-cloud-php-sdk/src/Models/PrimaryIps/PrimaryIp.php on line 166 and defined in /opt/ops-ip-lister/vendor/lkdevelopment/hetzner-cloud-php-sdk/src/Models/PrimaryIps/PrimaryIp.php:96
Stack trace:
#0 /opt/ops-ip-lister/vendor/lkdevelopment/hetzner-cloud-php-sdk/src/Models/PrimaryIps/PrimaryIp.php(166): LKDev\HetznerCloud\Models\PrimaryIps\PrimaryIp->__construct(0000, 'base-image', '2023-12-23T02:0...', '<IP_ADDRESS>', 'ipv4', Array, false, Object(LKDev\HetznerCloud\Models\Protection), Array, Object(LKDev\HetznerCloud\Models\Datacenters\Datacenter), 'server', NULL, false)
#1 /opt/ops-ip-lister/vendor/lkdevelopment/hetzner-cloud-php-sdk/src/Models/PrimaryIps/PrimaryIps.php(163): LKDev\HetznerCloud\Models\PrimaryIps\PrimaryIp::parse(Object(stdClass))
#2 [internal function]: LKDev\HetznerCloud\Models\PrimaryIps\Prim in /opt/ops-ip-lister/vendor/lkdevelopment/hetzner-cloud-php-sdk/src/Models/PrimaryIps/PrimaryIp.php on line 96

Please merge this....

Thank you @tanji (& @DGINXREAL)


There is no guarantee all vertices for a material has the same format

There are actually instances were materials can reference vertices with varying vertex formats.
A cheap way to fix this could be split those vertices into a different material for now. It could also be rare enough that it's not really a big issue?

@einarf have you encountered this before? If so, a test case plus handler code would IMHO be worthwhile and useful.

I have mostly seen it in technical drawings of products. Typically the same material is used for the entire model, but some objects suddenly switch uvs for normals. So far this is extremely rare, but you never know with obj files.
Another case is obj files not using materials at all. It's just lots of geometry that will be stuffed into the same "None"/Default material. Objects may vary on having normals, so the issue triggers.
A simple way to solve it could be creating a copy of the material adding the vertex format as a suffix. I'll see if I can find a decent example.

I will add a fallback for this with a log.warn if I stumble over more files like this.

Is this resolved per #54, or does it need more work?

Not resolved yet. We need a way to handle this problem:
https://github.com/greenmoss/PyWavefront/blob/ea28844c4851ac8777e617bec96ad060106994c3/pywavefront/obj.py#L322-L327

I got some error when using "pywavefront.Wavefront(cad_file,collect_faces=True, parse=True) "
ValueError: Trying to merge vertex data with different format: T2F_N3F_V3F.Material material_1_24 has vertex format N3F_V3F
so what should i do to aviod this error, thx


Update useExternalOpenvswitch description

In prior releases this field was used to tell the CNO not to deploy the
opevswitch daemonset for development purposes. In 4.7 we don't deploy
openvswitch with the cluster network operator at all, so we're ignoring
the field, although we keep it to avoid breaking compatibility.
/assign @danwinship

/lgtm
/assign knobunc

/hold
This is depends on https://github.com/openshift/cluster-network-operator/pull/876 which was delayed to 4.8.

This is depends on openshift/cluster-network-operator#876 which was delayed to 4.8.

It's not. We no longer support running OVS in pods. The docs should not imply that we do. (It's true that if we wanted we could clarify that this controls whether or not we run a dummy pod that just shows the OVS logs, but that's not really worth clarifying. The PR is fine as is, even if the CNO PR doesn't go in.)
/hold cancel

@knobunc can you lgtm? We delayed this so that it got in 4.8.

updated in #942
/close


Add undeploy ant target

Add undeploy target to ant build file to remove all DLRS metadata.

Thanks for this.
Just wondering if you have seen the dynamic undeploy over here...
https://github.com/financialforcedev/df12-deployment-tools

Thanks for the pointer.  I hadn't seen that, but it definitely looks useful.
In my case, I would have needed a dynamic undeploy that builds the destructiveChanges.xml from the files in the src directory rather than from all of the metadata in the org so I could just undeploy the DLRS metadata.  This probably wouldn't be too much work since the undeploy and generatePackage targets already exist, but given the infrequency with which I need to do something like this, I probably won't spend the time to contribute such an enhancement.

Thanks, lets go with this for now! :+1:


Save model with pre-trained backbone weights

Have trained nanodet 1.5x model. Noticed that when I evaluate the model predictor = Predictor(cfg, args.model, logger, device="cuda:0"), then it downloads and adds shufflenet weights. So, this means that the trained model file, for example nanodet_model_best.pth, is missing the pre-trained weights for the backbone.
I would like to store the shufflenet backbone pre-trained weights directly in my model pth-file - is it possible?
Or, are the pre-trained backbone weights are stored already in the model pth file? It's just that init of Predictor is set to load pre-trained weights (pretrain=true in the init of class ShuffleNetV2()). Tested setting pretrain=False and predictions are still correct.

"Or, are the pre-trained backbone weights are stored already in the model pth file? It's just that init of Predictor is set to load pre-trained weights (pretrain=true in the init of class ShuffleNetV2()). Tested setting pretrain=False and predictions are still correct." - Yes, pre-trained backbone weights are stored already in the model pth file


Adding support for option --squash in docker build

FEATURE REQUEST: Adding support for option --squash in docker build
Description
Docker has an experimental option --squash=true that, once the image is built, squash the new layers into a new image with a single new layer.
Example: docker build -t image_name -f Dockerfile . --squash
Examples
Example 1 (configuration with POM plugin):
<plugin>
  <groupId>com.spotify</groupId>
  <artifactId>dockerfile-maven-plugin</artifactId>
  <version>1.4.4</version>
  <executions>
    <execution>
      <id>default</id>
      <goals>
        <goal>build</goal>
        <goal>push</goal>
      </goals>
    </execution>
  </executions>
  <configuration>
    <squash>true</squash>
  </configuration>
</plugin>

Example 2 (configuration by command line):
mvn dockerfile:build -Ddockerfile.build.squash
Could you integrate this option into the plugin ?
Thanks!

Hey stale-bot give me time to solve this by myself if nobody else is interested!


BAU test capture queue behaviour when DB is restarted

Testing the capture process scheduler

Closed as testing is finished


build: add swift-inspect to the build

This is part of the default toolchain distribution and needs to be built for packaging as well as development.  Add this to the build set.

lgtm


Release 0.4.8

@JuliaRegistrator register(branch=release)

Registration pull request created: JuliaRegistries/General/7534
After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.
This will be done automatically if Julia TagBot is installed, or can be done manually through the github interface, or via:
git tag -a v0.4.8 -m "<description of version>" a36c6ba1062c0295b728582e605963650fccb0f6
git push origin v0.4.8


No support for handleCardSetup

Summary
react-stripe-elements has support for the PaymentIntents API but not for the SetupIntents API.
The method handleCardSetup seems to pass straight through to vanilla stripe.js and it's not clear to me how to get an Elements object to pass that call.
Other information
It'd be great to have full support for handleCardSetup or to have workaround instructions for how to continue using this ace library, get hold of an Elements object in my JS code, and pass that to the normal handleCardSetup on Stripe.js.

Hi @hcarver, we are definitely planning to add this. For now you can use the Element's onReady prop to get access to the underlying Element as a work around. Here's an example:
class CheckoutForm extends React.Component {
  handleSubmit = (ev) => {
    ev.preventDefault();
    this.props.stripe
      .handleCardSetup(this.props.clientSecret, this.element)
      .then((payload) => console.log('[SetupIntent]', payload));
  };

  handleReady = (element) => {
    this.element = element;
  }

  render() {
    return (
      <form onSubmit={this.handleSubmit}>
          <CardElement onReady={this.handleReady} />
        <button>Pay</button>
      </form>
    );
  }
}

Let me know if you have any questions, but hopefully this helps for now!

Hi @dweedon-stripe do you have en ETA for that?

Thanks @dweedon-stripe, your fast reply has made my day. The onReady callback was the thing I was missing, and now I'm all set for the SCA changes. 👍

@marco-gagliardi @andreaValenzi
Soon: #372

hi @hcarver how would i get the element, if i have the elements in separate components e.g.
Not using cardElements.
But CardNumberElement, CardExpiryElement and CardCVCElement
Thanks

@JayHalai I was able to use the onReady callback on the CardNumberElement and it seems to be working fine. It validates the CardExpiryElement and CardCVCElement if they exist as well.
However I noticed that handleCardSetup goes through successfully even if there is no CardExpiryElement and CardCVCElement elements on the page at all which seems a bit fishy.

@aryamohan I am not seeing this issue. If you are using the CardNumberElement without a CardExpiryElement and CardCVCElement in the same Elements context then when you call props.stripe.handleCardSetup you should get the error: Setup failed: Missing required param: payment_method_data[card][exp_month].

handleCardSetup support has been released in v4.0.0
https://github.com/stripe/react-stripe-elements/releases


attribute sha256 missing

Thanks for implementing and publishing the library.
I've run into an issue when trying to use it with dart-sass-emebedded project.
       at /nix/store/rqwcgd6ia6n5ws2axl4ib4w14z4z6dyv-source/build.nix:41:36:

           40|           ];
           41|           nixStorePath = fetchzip {
             |                                    ^
           42|             inherit (package) sha256;

I'm using:

nix (Nix) 2.13.2
flake-utils 5aed5285a952e0b949eb3ba02c12fa4fcfef535f
nix-dart 6f686ddf984306d944e9b5adf9f35f3a0a0a70b7

That might happen if your dependency isn't a pub.dev public dependency, but points at a path or a git repo.


add disable timeouts to protractor onPrepare

For wixstores,  it reduced the tests runtime by half.

Yes! how did I missed it? :
I changed mockTimeout to support all $timeout arguments like you said.
I tested it and it works.


What's the rule for version numbers?

TLDR
SDK1.4.0 has some breaking changes, which seems to contradict semantic versioning.
Can someone tell me what the versioning rules are?
long version
The raspberry pi team had done an excellent job for the SDK1.4.0, and I'm really excited about it!
But before trying it out, I found some problems in the release note.
The problem
In the miscellaneous section of pico-sdk 1.4.0 release note, there was this line:

The minimum PLL frequency has been increased from 400Mhz to 750Mhz to improve stability across operating conditions. This should not affect the majority of users in any way, but may impact those trying to set particularly low clock frequencies. If you do wish to return to the previous minimum, you can set PICO_PLL_VCO_MIN_FREQ_MHZ back to 400. There is also a new PICO_PLL_VCO_MAX_FREQ_MHZ which defaults to 1600.

Although minor, this seems like a breaking change. i.e. A project using SDK1.3.1 might fail to build or run on SDK1.4.0.
While I'm not affected by this change, someone might by assuming that pico-sdk is based on semantic versioning.
The question/request

What's the rule for pico-sdk's versioning?
Is it is semantic versioning, I highly recommend changing 1.4.0 to 2.0.0, and add a 1.4.1 that reverts the breaking changes.
The first line in the release note's miscellaneous section, it stated a function has moved from one file to another. It should be noted that this isn't a breaking change, since hardware/sync.h includes pico/platform.h.

@aallan
I'm fine with closing so long as there is a proper reason, can you explain to me?


Enable testing only if CATKIN_ENABLE_TESTING is set

Thanks @laurent-george, I wasn't familiar with this check. Do you know which version of ROS the CATKIN_ENABLE_TESTING was introduced (hydro, indigo, jade, etc.)?


It is possible to cache image and using the 'if-modified-since' keep synchronization with the server

In my program, each user can have a avatar, for example: http://www.mywebserver/avatar/username.jpg
When a user request  http://www.mywebserver/avatar/username.jpg， my server will check the request headers last-modified(and I need add cached image's last-modifiled at request header) ,
if the cached image's last-modified time is equal to the server save tiem, the server will return 304 and do not return the image data.
otherwise, the server will return image data and rn app need remove last cached image and cache new image for same url(http://www.mywebserver/avatar/username.jpg).
Is there any way that I can to do?

@Micjoyce Hey,
Looks like you have 2 separate issues here.

You would need to clear the currently cached image for the user avatar url, otherwise a request would not be made to your server and the local image would be used.
You need to let your server know that it needs to return a new image data and not a 304.

Actually you only need to solve one of them to get the functionality you want.
If you let the client manage the cache, the server can always return a fresh image and you can count on the client to not make unnecessary requests.
If you let the server manage the cache you can use a normal Image and manage the last modified somewhere in your client data store.
I would go with the first approach, of letting the clients manage the cache, so there isn't really a need to send the last modified timestamp.
However, you still need to know the avatar has changed so you could clear the cached image.
Not sure how your app works, but if you give me more info I'd be happy to help :)

@kfiroo
Very thank you for your reply；
there is my backend handles for request avatar.

// example: http://www.mywebsiteserver.com/avatar/username.jpg

return WebApp.connectHandlers.use('/avatar/', Meteor.bindEnvironment(function(req, res /*, next*/) {
    const params = {
      username: decodeURIComponent(req.url.replace(/^\//, '').replace(/\?.*$/, ''))
    };

    let username = params.username.replace(/\.jpg$/, '').replace(/^@/, '');

    if (_.isEmpty(params.username)) {
      res.writeHead(403);
      res.write('Forbidden');
      res.end();
      return;
    }

    // get file from gridfs by username + filetype
    let file = SeerlineFileAvatarInstance.getFileWithReadStream(encodeURIComponent(`${ username }.jpg`));
    res.setHeader('Content-Disposition', 'inline');

    // if user not set avatar file, we return a default one
    if (!file) {
      res.setHeader('Content-Type', 'image/jpeg');
      res.setHeader('Cache-Control', 'public, max-age=0');
      res.setHeader('Expires', '-1');
      res.setHeader('Last-Modified', 'Thu, 01 Jan 2015 00:00:00 GMT');

      const reqModifiedHeader = req.headers['if-modified-since'];

      if (reqModifiedHeader) {
        if (reqModifiedHeader === 'Thu, 01 Jan 2015 00:00:00 GMT') {
          res.writeHead(304);
          res.end();
          return;
        }
      }

      let lastLetterCode = Number(username.slice(-1).charCodeAt().toString().slice(-1)) % 6;
      if (isNaN(lastLetterCode) || lastLetterCode === 0) {
        lastLetterCode = 1;
      }
      // get a default avatar, before we had seted
      file = SeerlineFileAvatarInstance.getFileWithReadStream(encodeURIComponent(`${lastLetterCode}.png`));
      file.readStream.pipe(res);
      res.end();

      return;
    }

    // if client has cached and request with ['if-modified-since']
    // we will compare with server save time
    // if equal return 304 status code
    const reqModifiedHeader = req.headers['if-modified-since'];
    if (reqModifiedHeader) {
      if (reqModifiedHeader === (file.uploadDate && file.uploadDate.toUTCString())) {
        res.setHeader('Last-Modified', reqModifiedHeader);
        res.writeHead(304);
        res.end();
        return;
      }
    }
    // ready return file data
    res.setHeader('Cache-Control', 'public, max-age=0');
    res.setHeader('Expires', '-1');
    res.setHeader('Last-Modified', (file.uploadDate && file.uploadDate.toUTCString()) || new Date().toUTCString());
    res.setHeader('Content-Length', file.length);

    if (file.contentType) {
      res.setHeader('Content-Type', file.contentType);
    } else {
      file.readStream.once('data', function(chunk) {
        const fileType = getFileType(chunk);
        if (fileType) {
          return res.setHeader('Content-Type', fileType.mime);
        } else {
          return res.setHeader('Content-Type', 'image/jpeg');
        }
      });
    }
    file.readStream.pipe(res);
  }));
});

@Micjoyce Hey, as I said before, if you use this module (or any other) for client side caching, the if-modified-since header is not needed. The client would not send any requests to the server if it has a cached version.
I guess you server code might be serving other platforms (such as a web platform) so I wouldn't change it, but I wouldn't worry about it in your RN app.
The only thing you need to take care of is clearing the cache when the user changes his profile picture so that the cache would be updated.

@kfiroo Thank you for your advice


Update favicons, add new resolutions and support for webmanifest and apple touch icon

Also:

fix tag that should be head and was header
fix tab width of index.ejs to 2 spaces

Resolve  #145

I have a question, Why are we not only change the favicon file? The favicon has been defined in this line:
https://github.com/ResultadosDigitais/matrix/blob/38048371b7453f3a6f3b5c749b713d40a316d6da/app.server.js#L19

@juliemar I have changed the main file too, but the issue also recommended the other favicons.


consider bailing out on download if installing inside cloned repo

In prebuild we added the following check to force a compile when developing:
if (rc.install) {
  if (!(typeof pkg._from === 'string')) {
    // From Git directly
    rc.compile = true
  } else if (pkg._from.length > 4 && pkg._from.substr(0, 4) === 'git+') {
    // From npm install git+
    rc.compile = true
  } else {
    // From npm repository
    rc.download = rc.install
  }
}

from https://github.com/mafintosh/prebuild/blob/master/bin.js#L48-L59
Now, since this module doesn't have the code for compiling, it could basically just do process.exit(1) (instead of setting rc.compile etc) and tack on a .. || node-gyp rebuild just like the README shows to make this work.

I pushed a PR but I want to mention that developer could also use the --no-prebuild flag while developing, so I have no strong opinion on this one.


Add cert controller config

testing...

Codecov Report

Merging #47 (3b2e49e) into main (bb5bdbb) will decrease coverage by 0.02%.
The diff coverage is 40.00%.

:exclamation: Current head 3b2e49e differs from pull request most recent head bd33baa. Consider uploading reports for the commit bd33baa to get more accurate results

@@            Coverage Diff             @@
##             main      #47      +/-   ##
==========================================
- Coverage   87.06%   87.03%   -0.03%
==========================================
  Files         197      197
  Lines       14439    14439
==========================================
- Hits        12571    12567       -4
- Misses       1576     1578       +2
- Partials      292      294       +2

Impacted Files
Coverage Δ

cmd/activator/main.go
0.00% <0.00%> (ø)

cmd/controller/main.go
0.00% <ø> (ø)

cmd/queue/main.go
0.64% <ø> (ø)

pkg/reconciler/autoscaling/kpa/kpa.go
95.21% <ø> (-0.06%)
:arrow_down:

pkg/reconciler/revision/resources/deploy.go
90.10% <0.00%> (ø)

pkg/reconciler/route/resources/ingress.go
96.18% <100.00%> (ø)

pkg/reconciler/revision/background.go
90.90% <0.00%> (-1.82%)
:arrow_down:

pkg/reconciler/configuration/configuration.go
83.67% <0.00%> (-1.54%)
:arrow_down:

pkg/activator/net/revision_backends.go
92.77% <0.00%> (+0.57%)
:arrow_up:

pkg/autoscaler/statserver/server.go
79.25% <0.00%> (+1.48%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bb5bdbb...bd33baa. Read the comment docs.


Update Sandbox2 to use Vitest VS Code Extension 0.6.0

The current code base works only with Vitest VS Code Extension 0.4.1.
The reason is twofold:

The latest extension requires vitest 1.5.0 and this version has new command line options
After the update to vitest 1.5.0 all tests work with via command line, but the VS Code Extension 0.6.0 throws these errors:

NJS-512: invalid connection string parameters.
NJS-514: syntax error in connection string

These errors are thrown only via the extension.

Vitest config has to be set according to CLI settings in package.json. - VS Code extension v1.4.1 is working. But 1.6.0 is throwing NJS errors. CLI is working. Looks like a Vitest VS Code bug to me. Going to merge it.


Error detected in the development configuration.

$ docker run -it -v "/home/blog/ghost/content:/var/lib/ghost/content" --rm ghost:latest ghost start --development

✖ Validating config
A ConfigError occurred.

Error detected in the development configuration.

Message: Config file is not valid JSON

Debug Information:
    Node Version: v6.11.3
    Ghost-CLI Version: 1.1.1
    Environment: development
    Command: 'ghost start --development'

Please refer to https://docs.ghost.org/v1/docs/troubleshooting#section-cli-errors for troubleshooting.

This is likely because the image does not include a development mode
configuration file at all (we only supply a "production" mode configuration
file).

That would do it. Is there a specific reason why you don't support a dev mode? It's far easier to just load up a docker container than to manually install a bunch of stuff to develop on. I really think a simple dev mode would be very useful, even if it is not the default run mode.

@karai17 so the docker image has been configured not to use ghost start, because ghost start would launch ghost in a child process, and then exit, which would stop the container.
If you're wanting to use the docker image to start ghost in development, what you could do is specify things with environment variables, e.g.
docker run -it -v "/home/blog/ghost/content:/var/lib/ghost/content" -e NODE_ENV=development --rm ghost:latest

Thanks for the info. I just learned about using the env variables last night after spending hours trying to mess with this image to do my bidding (the url was showing up as localhost:2368 despite my best efforts) only to find the answer buried in a github issue.
I highly recommend adding info about using the end variables to the readme so that people new to ghost/node/etc are able to configure things a bit quicker. :)

See https://github.com/docker-library/docs/pull/1018/files#diff-d5b3640a478d2d85406ab914762265a5 :+1:


Add attached_images to projects

Create a media endpoint for attaching images to projects for help text. We should probably limit the number of images would 20 or so sound reasonable?

20 seems like plenty for a help/faq (though if this includes logos of project collaborators maybe not so much...) On the off-chance people have more, can we manually increase this limit for them? (I doubt this would happen much.)

I could see people going over that pretty fast if they try to build a
spotter's guide. Then again if the limit is number of images, not total
disk space used etc., they could just make a big image mosaic and then it
counts as 1...

Yeah I might just leave this uncapped for now, then if it becomes a problem we can talk to people.

FWIW, we use ~40 images for help.


Docs/k8saudit changelogs

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area plugins

/area registry

/area build

/area documentation

What this PR does / why we need it:
Which issue(s) this PR fixes:

Fixes #
Special notes for your reviewer:

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: leogr
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

plugins/k8saudit-eks/OWNERS [leogr]
plugins/k8saudit-gke/OWNERS [leogr]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: jasondellaluce, leogr
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

plugins/k8saudit-eks/OWNERS [jasondellaluce,leogr]
plugins/k8saudit-gke/OWNERS [jasondellaluce,leogr]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


Feature suggestion: automatic fade out

Long-time user. Love the app.
Currently, when you click on a sound, it starts playing and will play until the end of the clip or until you hit pause or the "X" which stops the sound abruptly and removes it from the playlist.
An improvement would be if it were possible to have the sound clip fade out over some length of time.
Use case: I use the app to do the music at my kids' hockey games. Whenever there's a break in the action, I play music. But as soon as the referee drops the puck on a faceoff to restart play, I have to end the music. Currently I end the sound clip by either tapping pause or the "X" and that stops the clip abruptly. It would be better to be able to set a fade-out time of about a half a second somewhere and have that apply to the pause and/or the "X". Or maybe you could add a button next to the "X" that does a quick fade + close.
Thanks for considering!

Hi Jared, thank you for your feedback and your kind words!
This comes at a convenient time, as I am currently planning the next update. I will see what I can do about that.

Awesome, thanks!
I'm doing the music for my son's hockey game tomorrow. If I get a
chance, I'll have someone take a photo so you can see your software in
action :-)
Cheers,
Jared

Jared Rhoads
@.***
978-335-8428
On 2023-10-20 7:35 pm, David Zurek wrote:

Hi Jared, thank you for your feedback and your kind words!
This comes at a convenient time, as I am currently planning the next
update. I will see what I can do about that.
--
Reply to this email directly, view it on GitHub [1], or unsubscribe
[2].
You are receiving this because you authored the thread.Message ID:
@.***>

Links:
[1]
https://github.com/dav-apps/UniversalSoundboard/issues/19#issuecomment-1773522842
[2]
https://github.com/notifications/unsubscribe-auth/BDNOMVRM4EWFJCT7PAW6NUDYAMDCTAVCNFSM6AAAAAA6JFA62OVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONZTGUZDEOBUGI

I'd love to see that!

Hey Jared, I just released v2.4, which contains some basic sound effects, including fade in and fade out. I hope you like it!
Read more here: https://blog.dav-apps.tech/universalsoundboard-2-4/

That's awesome, thanks! I'm going to download it... can't wait!
Sent from my mobile.
Please excuse brevity and typos.
On Jan 5, 2024, 11:53 AM, at 11:53 AM, David Zurek @.***> wrote:

Hey Jared, I just released v2.4, which contains some basic sound
effects, including fade in and fade out. I hope you like it!
Read more here: https://blog.dav-apps.tech/universalsoundboard-2-4/
--
Reply to this email directly or view it on GitHub:
https://github.com/dav-apps/UniversalSoundboard/issues/19#issuecomment-1879051403
You are receiving this because you authored the thread.
Message ID:
@.***>

Hmm, I can't figure out how to update the app.
-Jared

Jared Rhoads
@.***
978-335-8428
On 2024-01-05 12:52 pm, David Zurek wrote:

Closed #19 [1] as completed.
--
Reply to this email directly, view it on GitHub [2], or unsubscribe
[3].
You are receiving this because you authored the thread.Message ID:
@.***>

Links:
[1] https://github.com/dav-apps/UniversalSoundboard/issues/19
[2]
https://github.com/dav-apps/UniversalSoundboard/issues/19#event-11403751321
[3]
https://github.com/notifications/unsubscribe-auth/BDNOMVU6XPGGYOIJ5JHOE3LYNA4XPAVCNFSM6AAAAAA6JFA62OVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJRGQYDGNZVGEZTEMI

Hey Jared, I had to pull the new version because of an issue. The new update with the fix is now stuck in Microsoft's certification process.
I'm sorry for that! I will let you know when the update is available again.

No worries! (I thought I was doing something wrong in updating or downloading it!)
Sent from my mobile.
Please excuse brevity and typos.
On Jan 7, 2024, 8:03 AM, at 8:03 AM, David Zurek @.***> wrote:

Hey Jared, I had to pull the new version because of an issue. The new
update with the fix is now stuck in Microsoft's certification process.
I'm sorry for that! I will let you know when the update is available
again.
--
Reply to this email directly or view it on GitHub:
https://github.com/dav-apps/UniversalSoundboard/issues/19#issuecomment-1880054146
You are receiving this because you authored the thread.
Message ID:
@.***>

The update is now available again. I hope you like it :)


IEC 61360 DataType Inconsistency INTEGER and INTEGER_MEASURE

Hello,
it looks like the string enumeration in IEC61360.xsd contains "INTEGER" and not "INTEGER_MEASURE", while for JSON and RDF "INTEGER_MEASURE" and not "INTEGER" are listed.
I don't know about that IEC 61630 datatype but i think the string representation should be consistent regardless of the used format.
XML
<simpleType name="dataTypeIEC61360_t">
	<restriction base="string">
		<enumeration value="" />
		<enumeration value="BOOLEAN" />
		<enumeration value="DATE" />
		<enumeration value="RATIONAL" />
		<enumeration value="RATIONAL_MEASURE" />
		<enumeration value="REAL_COUNT" />
		<enumeration value="REAL_CURRENCY" />
		<enumeration value="REAL_MEASURE" />
		<enumeration value="STRING" />
		<enumeration value="STRING_TRANSLATABLE" />
		<enumeration value="TIME" />
		<enumeration value="TIMESTAMP" />
		<enumeration value="URL" />
		<enumeration value="INTEGER" />
		<enumeration value="INTEGER_COUNT" />
		<enumeration value="INTEGER_CURRENCY" />
	</restriction>
</simpleType>

RDF
    owl:oneOf (
    iec61360:DATE
    iec61360:STRING
    iec61360:STRING_TRANSLATABLE
    iec61360:INTEGER_MEASURE
    iec61360:INTEGER_COUNT
    iec61360:INTEGER_CURRENCY
    iec61360:REAL_MEASURE
    iec61360:REAL_COUNT
    iec61360:REAL_CURRENCY
    iec61360:BOOLEAN
    iec61360:URL
    iec61360:RATIONAL
    iec61360:RATIONAL_MEASURE
    iec61360:TIME
    iec61360:TIMESTAMP
) ;

JSON
             "enum": [
            "DATE",
            "STRING",
            "STRING_TRANSLATABLE",
            "REAL_MEASURE",
            "REAL_COUNT",
            "REAL_CURRENCY",
            "BOOLEAN",
            "URL",
            "RATIONAL",
            "RATIONAL_MEASURE",
            "TIME",
            "TIMESTAMP",
            "INTEGER_COUNT",
            "INTEGER_MEASURE",
            "INTEGER_CURRENCY"
          ]

need to check with the JSON / RDF guys ...

ok ... my turn


Fix AugmentedMemoizationPolicy max history bug.

Proposed changes:
The tracker event sequence is truncated at the most recent ActionExecuted("action_listen") event before before the max_history-th action, preserving the user utterance after the action_listen so that it can be correctly included in the tracker state creation. Otherwise, if the number of actions is greater that max_history, AugmentedMemoizationPolicy will not be able to recognize them.
Problem Description:
Consider the following training story:
- story: training example
  steps:
    - intent: customer_service
    - action: action_check_login
    - slot_was_set:
      - login: true
    - action: action_check_queue
    - slot_was_set:
      - routing_queue: "xyz"
    - action: action_check_price_of_doge_coin
    - action: utter_helpful_message1

The following training states would be created from the training story above:
state1 = {}
state2 = {"prev_action": {"action_name": "action_listen"}, "user": {"intent": "customer_service"}}
state3 = {"prev_action": {"action_name": "action_check_login"}, "user": {"intent": "customer_service"}, "slots": {"login": (1.0, 1.0)}}
state4 = {"prev_action": {"action_name": "action_check_queue"}, "user": {"intent": "customer_service"}, "slots": {"login": (1.0, 1.0), "routing_queue": (0.0, 1.0, 0.0)}}
state5 = {"prev_action": {"action_name": "action_check_price_of_doge_coin"}, "user": {"intent": "customer_service"}, "slots": {"login": (1.0, 1.0), "routing_queue": (0.0, 1.0, 0.0)}}
state6 = {"prev_action": {"action_name": "action_utter_helpful_message1"}, "user": {"intent": "customer_service"}, "slots": {"login": (1.0, 1.0), "routing_queue": (0.0, 1.0, 0.0)}}

Assume that max_history == 3 for the AugmentedMemoizationPolicy.
From this training state sequence we would create the following state sequence / action label mappings:
    (state1) - > "action_listen"
    (state1, state2) -> "action_check_login"
    (state1, state2, state3) -> "action_check_queue"
    (state2, state3, state4) -> "action_check_price_of_doge_coin"
    (state3, state4, state5) -> "action_utter_helpful_message1"
    (state4, state5, state6) -> "action_listen"

However, at test time, if we had the following event sequence:
- action: action_listen
- intent: blah_blah_blah
- action: action_some_bot_action
- action: utter_some_bot_speak
- action: action_listen
- intent: customer_service
- action: action_check_login
- slot_was_set:
  - login: true
- action: action_check_queue
- slot_was_set:
  - routing_queue: "xyz"
- action: action_check_price_of_doge_coin

AugmentedMemoizationPolicy first computes where to truncate the events according to the most recent max_history events. In this case it would truncate the event sequence to:
- action: action_check_login
- slot_was_set:
  - login: true
- action: action_check_queue
- slot_was_set:
  - routing_queue: "xyz"
- action: action_check_price_of_doge_coin

This sequence when turned into prediction states, looks like this:
bad_state1 = {"prev_action": {"action_name": "action_check_login"}, "slots": {"login": (1.0, 1.0)}}
bad_state2 = {"prev_action": {"action_name": "action_check_queue"}, "slots": {"login": (1.0, 1.0), "routing_queue": (0.0, 1.0, 0.0)}}
bad_state3 = {"prev_action": {"action_name": "action_check_price_of_doge_coin"}, "slots": {"login": (1.0, 1.0), "routing_queue": (0.0, 1.0, 0.0)}}

Crucially, the user intent information is lost so looking up (bad_state1, bad_state2, bad_state3) yields a miss and policy prediction is handed off to TED.
Instead, this PR changes the truncation behavior, to truncate the tracker events on the most recent action_listen before where max_history would originally imply truncating. For example:
- action: action_listen
- intent: blah_blah_blah
- action: action_some_bot_action
- action: utter_some_bot_speak
- action: action_listen       # <- where this PR now truncates
- intent: customer_service
- action: action_check_login         # <- where to truncate according to `max_history`
- slot_was_set:
  - login: true
- action: action_check_queue
- slot_was_set:
  - routing_queue: "xyz"
- action: action_check_price_of_doge_coin

Even though this new event sequence contains more than max_history events, when handed off to the MaxHistoryTrackerFeaturizer, it will first create the states (with the correct user info) and then truncate to max_history states, which AugmentedMemoizationPolicy will use to lookup.
Status (please check what you already did):

[x] added some tests for the functionality
[ ] ~updated the documentation~
[x] updated the changelog (please check changelog for instructions)
[x] reformat files using black (please check Readme for instructions)

/modeltest

include:
  - dataset: ["all"]
    config: ["all-core"]

@kedz I'm re-running the regression tests after making some fixes to the training data repo on the rasa-v2.x branch (this commit) to correctly use 2.x domain files. This should fix the failing regression tests and produce meaningful numbers 🙂

/modeltest
dataset_branch: "rasa-v2.x"
include:

dataset: ["Sara"]
config: ["Rules + AugMemo"]

/modeltest
dataset_branch: "rasa-v2.x"
include:
  - dataset: ["Sara"]
    config: ["Rules + AugMemo"]

@samsucik

Out of curiosity: Does this bug affect 3.x as well? I'm thinking not but I also don't know much about the relevant changes in 3.x (maybe @ka-bu will know). If this affected 3.x too, then an interesting question is how to handle the fix -- usually, we'd fix things in the newer version and back-port, but maybe this doesn't work if we want to release fixes for customers in an older version very quickly?

It does affect 3.x as well. Working on a PR for that now. (I also found a another bug in the 3.0 tests unrelated to the ones here 🤦🏻 )

/modeltest
dataset_branch: "rasa-v2.x"
include:
  - dataset: ["retail-demo", "Sara"]
    config: ["all-core"]

@samsucik @JEM-Mosig regression tests might be working here (but still kinda flaky) but the full sweet ran without issue on the 3.0 PR here.

@kedz Great analysis in the issue! But I'm a bit worried that we make the meaning of max_history even more fuzzy with this. For all other policies max_history refers to the number of actions (including action_listen) to take into account. This may already be confusing, but with this change it would be different for just AugMemo. Can one not just increase the max_history parameter to 20 or something to resolve the issue?

@kedz Great analysis in the issue! But I'm a bit worried that we make the meaning of max_history even more fuzzy with this. For all other policies max_history refers to the number of actions (including action_listen) to take into account.

In the MaxHistoryTrackerFeaturizer the max_history refers to the states, which should correspond to actions (!= action_listen), no? So the meaning here seems consistent to me (given that the _prediction_states uses the max history featurizer under the hood which will get rid of any extra states obtained by including ActionExecuted events between the first ActionExecuted inside the max_history window and the ActionListen before that). Or are you thinking of something else here?

confusing

What I found really confusing is that the context is also pruned within the max history window. I would've assumed that AugMemo just cuts off history prior to the max_history boundary. But the truncation happens successively and the fix undoes that "just a little bit" each time to just include the prior utterance. ...

Can one not just increase the max_history parameter to 20 or something to resolve the issue?

Yep, seems to me like it would solve the example above. But I think one problem that we can't get rid of because it happens by design is that: If we want our lookup table to contain combinations of "older" slots and recent actions, then we can't achieve that by increasing the history because aug memo will successively cutoff every prefix inside that window.
... Is that also an issue (and wouldn't the approach with "cutoff everything before max_history and then behave like MaxHistoryTrackerFeaturizer be an option then)? 🤔  @kedz ?

Great points, Johannes and Kathrin! I'll let Chris react but I just wanted to highlight that this issue has now definitely out-grown an on-point task and we should make this more transparent -- e.g. by properly determining the priority of the issue and/or assigning it to someone who is on the reactive team (unless Chris wants to keep it, of course!).

@samsucik I rewrote the tests with more realistic trackers (action_listen precedes user utterances and is the final action), and renamed some private methods at your suggestion. If we are expecting trackers to be realistic we don't need the changes I made to _strip_leading_events_until_action_executed (formerly _back_to_the_future 😱 ) (the change being to try truncating that tracker at both actions and user uttered events), so I reverted those changes.
@JEM-Mosig

But I'm a bit worried that we make the meaning of max_history even more fuzzy with this. For all other policies max_history refers to the number of actions (including action_listen) to take into account.

I would agree with @ka-bu that max_history is referring to the number of states considered which this PR doesn't change. It only extends the tracker event history truncation marginally so that the states are created correctly before max_history state sequence truncation is performed.
The tracker event history truncation was only introduced because of this issue to handle the case where in production a tracker might grow arbitrarily long and it was slowing down inference time significantly; max_history actions would be the minimum we could truncate to and preserve the correct behavior (modulo this bug) but where we truncate the tracker event sequence, assuming it doesn't hurt inference time noticeably, is somewhat arbitrary.
I suspect that increasing the max_history of AugMemo would be a solution but then it creates a discrepancy between how states are created at training time and test time, which could be confusing to us and others. I think not fixing this bug and just saying to extend the window as a solution would warrant a docs update to say that your max_history window should be at least as long as the longest number of actions between user responses + 1 (a rule I suspect many will forget even if they read the docs). But if everyone else feels like going this route, I can create the docs modification and revert these changes.
Let me know on how I should proceed.
@ka-bu  Regarding this:

But I think one problem that we can't get rid of because it happens by design is that: If we want our lookup table to contain combinations of "older" slots and recent actions, then we can't achieve that by increasing the history because aug memo will successively cutoff every prefix inside that window.

I think that AugMemo is intended to be use explicitly to ignore older slots. But maybe I am not understanding exactly what you mean here.

@ka-bu Regarding this:

But I think one problem that we can't get rid of because it happens by design is that: If we want our lookup table to contain combinations of "older" slots and recent actions, then we can't achieve that by increasing the history because aug memo will successively cutoff every prefix inside that window.

I think that AugMemo is intended to be use explicitly to ignore older slots. But maybe I am not understanding exactly what you mean here.

Not sure this is really relevant, but I would've expected the  "ignore older slots" to only mean: ignore slot sets that happened more than max_history states before. But it seems to me that we also remove slot sets within that max_history window, because we  states = self._prediction_states(truncated_tracker, domain,) with the truncated_tracker from which we remove the leading events. So I think we won't have a lookup for "(slot set that happened x steps ago inside max_history window but more than n states before current state) + (last m states with m <<n" via AugMemo, no?

@ka-bu ah ok I think I understand now. Yeah this doesn't change the behavior within the max_history window of states. Slots will be progressively be discarded, regardless of whether there is a matching prefix in the training that would keep them. I think that is out of scope for this issue but point me to that notion page you mentioned. Sounds interesting.

@kedz could you run the relevant reg. tests one last time, if/once you're done adding commits?


Update docs for .NET Live Resource Tool with guidance/info if service team needs to create their own resources for setting up tests

Update docs for .NET Live Resource Tool:

[ ]  Explain that user's need to use existing or create new resources vs requesting access to the Azure Developer Playground
[ ]  Guidance/instructions if service team needs to create their own resources for setting up tests
Requirement to address confusion, see screenshot below from service partner.

This comes from feedback we got from a user that was following https://github.com/Azure/azure-sdk-for-net/blob/main/eng/common/TestResources/README.md and got confused about the subscription.


Update mis.h

"Assertion failed: q2 >= T(0.0), file N:\appleseed\appleseed\src\appleseed\foundation/math/mis.h, line 145 "
resolved

This makes no sense at all; in fact it's borderline insulting.

NDEBUG is defined in the build configuration for optimized builds, you're not supposed to define it yourself.
Defining NDEBUG in a header file means that not only assertions are disabled in that header file, they're also disabled in all header files that include this one. Ouch!
The parentheses around q1 + q2 are useless, precedence was correct.

The problem is not in mis_power2() which is fully correct; there's a logic error in calling code.


Use new Expeditor config format

Update the .expeditor/config.yml to use the new-style merge-action declaration syntax.
Signed-off-by: Tom Duffield<EMAIL_ADDRESS>cc @schisamo @thommay @lamont-granquist

@thommay Not sure what is up with the Appveyor failures, obviously this change shouldn't affect any of the application code. I did rebase this branch onto master just to ensure we weren't missing some recent fix.

Appveyor is a mess, although I thought the change of image had fixed it. Regardless, if this is ready to merge we'll get it merged.


Issue about read_10x_mtx function

Hi all,
I am analysing some 10x samples generated in my lab and I noticed that there could be some problems with your read_10x_mtx function. So, I opened 4 times the pbmc3k dataset used in your tutorial by using the following lines of code:
adata = sc.read_10x_mtx(sample, var_names='gene_symbols', cache=True)
adata.var_names_make_unique()
sc.pp.filter_cells(adata, min_genes=200)
sc.pp.filter_genes(adata, min_cells=3)
mito_genes = adata.var_names.str.startswith('MT-')
adata.obs['percent_mito'] = np.sum(adata[:, mito_genes].X, axis=1).A1 / np.sum(adata.X, axis=1).A1
adata.obs['n_counts'] = adata.X.sum(axis=1).A1
I generated the violin plots showing the n_genes, n_counts, and percent_mito for each test and they are different in each test (see attached picture).

Do you have any suggestions to solve this problem?
Thank you in advance,
Simone

Hi,
I don't think the data is actually different. Only the jitter in the violin plot places the dots in different places. The value is still the same. You can check if adata.obs['n_counts'] is the same in the 4 objects you load.

Hi,
Thank you for your prompt reply and suggestions.
I checked the adata.obs["n_counts] and adata.X comparing them among the different tests and they are actually identical.
I also identified why there was a stochastic effect in the jitter plots inside the violin plots.
It is due to the numpy random seed; indeed, if you call numpy.random.seed(N) before calling the scanpy.pl.violin function, you obtain the same violin plots.
Notice that you have to call it before every call of  scanpy.pl.violin.
It seems that the seed is reset somewhere in the code.
Best wishes,
Simone


Want seedless biometric wallets

The wallets got 2fa thats good but ,thats still not safe as one can easily forget or lose the 2fa ,it will be better if our seeds will be intrgrated with out fingureprint..that way it will be safe also convinient

hello, this is not relevant to Starknet.js!


Actually fixes QUOTA_EXCEEDED_ERR error in private Safari window.

@alexgorbatchev's fix in #24 is almost, but not quite, complete. Safari will still throw an exception:
TypeError: 'undefined' is not a function (evaluating 'webStorage.setItem('ngStorage-' + k, angular.toJson(v))')

...because we explicitly set webStorage to an empty object {} earlier.
See #24 for more information about this bug, which can be reproduced only in OSX Safari or iOS Safari running in "private browsing" mode.

There is no reason. @gsklee seems to have 	abandoned this project.
I hope someone will fork and maintain this project.

This is in place. Closing.


[Automated] Update eventing-kafka-broker-eventing nightly

/assign @knative-extensions/eventing-wg-leads
/cc @knative-extensions/eventing-wg-leads
Produced via:
for x in eventing-crds.yaml eventing-core.yaml eventing-tls-networking.yaml; do
  curl https://storage.googleapis.com/knative-nightly/eventing/latest/$x > ${GITHUB_WORKSPACE}/./third_party/eventing-latest/$x
done

Details:
bumping knative.dev/eventing e3b7970...7a645f8:
  > 7a645f8 Add the test setup in the install script (# 7418)
  > 8d8e0fe Increase Ready timeout for TestChannelConformance to 4 minutes (# 7433)
  > a118938 Use input channels audience as audience of Parallel (# 7431)
  > 9431ce9 Add e2e test if channel implementation exposes OIDC audience (# 7381)
  > 0fa1bbc [main] Upgrade to latest dependencies (# 7432)

/test reconciler-tests-namespaced-broker

/retest
/lgtm

/retest
Sent from Gmail Mobile
On Thu 16. Nov 2023 at 18:44, knative-prow[bot] @.***>
wrote:

@knative-automation https://github.com/knative-automation: The
following test failed, say /retest to rerun all failed tests or
/retest-required to rerun all mandatory failed tests:
Test name Commit Details Required Rerun command
reconciler-tests-namespaced-broker_eventing-kafka-broker_main 4c32979
https://github.com/knative-extensions/eventing-kafka-broker/commit/4c329795a6568b18f28513abc818fac8ac50f470
link
https://prow.knative.dev/view/gs/knative-prow/pr-logs/pull/knative-extensions_eventing-kafka-broker/3469/reconciler-tests-namespaced-broker_eventing-kafka-broker_main/1725188771550334976
true /test reconciler-tests-namespaced-broker
Your PR dashboard https://prow.knative.dev/pr.
Instructions for interacting with me using PR comments are available here
https://git.k8s.io/community/contributors/guide/pull-requests.md. If
you have questions or suggestions related to my behavior, please file an
issue against the kubernetes/test-infra
https://github.com/kubernetes/test-infra/issues/new?title=Prow issue:
repository. I understand the commands that are listed here
https://go.k8s.io/bot-commands.
—
Reply to this email directly, view it on GitHub
https://github.com/knative-extensions/eventing-kafka-broker/pull/3469#issuecomment-1814936109,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AABGPTT3AVV2JRGRIWUFOOLYEZGITAVCNFSM6AAAAAA7MJXYR2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMJUHEZTMMJQHE
.
You are receiving this because you were assigned.Message ID:
@.***
com>


Some fixes

Ethers.js expects 'gasLimit', but web3 will generate a transaction with 'gas'
Ethers.js expects an array when signing hex encoded messages

Awesome! 👍Thanks for submitting this PR @Arctek


CLI rework

There seems to be a need to rework the CLI, as mentioned in #51, #131 and #281 to add options in the future.
I could try to implement that.

Looks like this should be done now :+1:
(I forgot to link the issue)


\not problem with unicode-math

Processing with xelatex, $\not\propto$ just prints 6 before $\propto$, rather than overlaying combining solidus.

Just came here to report the same thing; I asked about it at https://tex.stackexchange.com/questions/324427/unicode-math-replaces-not-by-the-number-6

The “6” is due to the fact that, in the case of \not\propto, \__um_oldnot: is used, which is defined as the legacy \not mathchar, so \mathchar"3236. Since in math family 2 the unicode math font is used, character U+0036 is used (which is a 6).

@eg9 Thanks! Do you want to write a response to that question? That would be very useful :)

The "6" instead of a sensible slash is due to the fact, dass the definition of \not is not correctly saved when unicode-math-tables is processed. With e.g. this here it works again:
\ExplSyntaxOn
\cs_set:Nn \__um_input_math_symbol_table: {\g__um_mathtable_tl
                                           \cs_set_eq:NN\__um_oldnot:\not
                                           }
\ExplSyntaxOff

But this alone doesn't lead to a good \not. Imho the mathaccent definition is wrong, one need the overlay  key word for the correct placement.
\documentclass{article}

\usepackage{fontspec}
\usepackage{amsmath,amssymb}

\usepackage{unicode-math}

\ExplSyntaxOn
\cs_set:Nn \__um_input_math_symbol_table: {\g__um_mathtable_tl
                                           \cs_set_eq:NN\__um_oldnot:\not
                                           }
\ExplSyntaxOff

\begin{document}
Bad:  $A \not\approxeq B $

\newcommand\napproxeq{\Umathaccent overlay fixed  7\symoperators "00338 \approxeq}

Good: $A \not\approxeq B $

\end{document}

Does XeTeX support the overly keyword? It seems like a new LuaTeX addition.

Ups, I didn't realize that the question started with a reference to xelatex. My comments/code were meant for lualatex which knows the overlay keyword. For xelatex I don't know if there is a way to better place the solidus.

Ideally XeTeX should add support for the overlay keyword, because AFAIK there was no clean way to place such overlay accents in math mode at the engine level.


Setting org-hide-leading-stars to nil is overriden

What did you expect to happen?
Setting org-hide-leading-stars to nil as mentioned in the FAQ results in org-mode not hiding leading stars.
My config:
(after! org
  (setq org-hide-leading-stars nil
        org-hide-leading-stars-before-indent-mode nil
        org-startup-indented nil))

What actually happened?
It seems to get overriden by something else, maybe +org-init-appearance-h ?
Using M-x describe variable shows it is set to t. Org-mode still hides leading stars

emacs   version    26.3
        features   XPM JPEG TIFF GIF PNG RSVG IMAGEMAGICK SOUND GPM DBUS GSETTINGS GLIB NOTIFY ACL GNUTLS LIBXML2 FREETYPE M17N_FLT LIBOTF XFT ZLIB TOOLKIT_SCROLL_BARS GTK3 X11 XDBE XIM MODULES THREADS LIBSYSTEMD LCMS2
        build      Aug 29, 2019
        buildopts  (--prefix=/usr --sysconfdir=/etc --libexecdir=/usr/lib --localstatedir=/var --with-x-toolkit=gtk3 --with-xft --with-modules 'CFLAGS=-march=x86-64 -mtune=generic -O2 -pipe -fno-plt' CPPFLAGS=-D_FORTIFY_SOURCE=2 LDFLAGS=-Wl,-O1,--sort-common,--as-needed,-z,relro,-z,now)
        windowsys  x
        daemonp    daemon
doom    version    2.0.9
        build      HEAD -> develop c0d208965 2020-05-09 02:24:19 -0400
        dir        ~/.doom.d/
system  type       gnu/linux
        config     x86_64-pc-linux-gnu
        shell      /usr/bin/zsh
        uname      Linux 5.4.39-1-lts #1 SMP Wed, 06 May 2020 17:32:42 +0000 x86_64
        path       (/usr/local/texlive/2019/bin/x86_64-linux ~/.local/gcc-arm/bin ~/.node_modules/bin /usr/local/sbin /usr/local/bin /usr/bin /opt/flutter/bin /usr/lib/jvm/default/bin /usr/bin/site_perl /usr/bin/vendor_perl /usr/bin/core_perl ~/.local/bin ~/.cargo/bin ~/.local/bin ~/go/bin /usr/lib/emacs/26.3/x86_64-pc-linux-gnu/)
config  envfile    envvar-file
        elc-files  0
        modules    (:completion company (ivy +icons) :ui doom fill-column hl-todo (modeline +light) (popup +defaults) vc-gutter :editor (evil +everywhere) fold snippets :emacs dired undo vc :checkers syntax :tools lookup lsp magit rgb :lang cc emacs-lisp (go +lsp) haskell latex markdown nix ocaml (org +journal +roam) (rust +lsp) sh yaml :config literate (default +bindings +smartparens))
        packages   ((solaire-mode :disable t))
        unpin      (n/a)
        elpa       (n/a)

Have you disabled org-superstar-mode?

Yes, I have :/

I cannot reproduce this issue with the following in ~/.doom.d/config.el:
(after! org
  (setq org-hide-leading-stars nil
        org-startup-indented nil))
(remove-hook 'org-mode-hook #'org-superstar-mode)

org-hide-leading-stars is nil in org-mode buffers, as expected.
Does that match your config?

Okay, so, very strange: here's the relevant part of my config
With this, it still hides leading stars, however if I remove the org-hide-leading-stars-before-indent-mode nil it does work! Thanks for taking the time to investigate :) I guess that line should  be removed from the FAQ

Odd that its presence should have any effect. org-hide-leading-stars-before-indent-mode isn't used upstream anymore. You'd be setting a dead variable (which should have no effect on anything). Ah well. I've removed the line in 7e621e3 in any case. Glad we could figure it out!

After more testing, it seems to be some kind of "race condition" while loading modules ?
During testing I'd restart my daemon and immediately open an org file to check for the stars: in that case they're not hidden, respecting my config.
However if I restart my daemon and wait for 10 seconds, then open an org file, it still hides leading stars, while my config is
(remove-hook 'org-mode-hook #'org-superstar-mode)
(after! org
  (setq org-hide-leading-stars nil
        org-startup-indented nil))

Are you able to reproduce, knowing you have to wait for the daemon to load before opening a frame and an org file?

@hlissner friendly ping in case you haven't seen my comment on the closed issue :)

This appears to be involved: https://github.com/hlissner/emacs-doom-themes/blob/master/doom-themes-ext-org.el#L72-L73
I need to unwind my debugging I've done to confirm that org-indent-mode isn't getting pulled in as well (this was a rabbit hole I also went down) and also causing org-hide-leading-stars to be set to t.
I was able to work around it by adding my own doom-themes-ext-org.el file on my load path. It's just a copy of the original, sans star related settings.

Looks like I also had to advice +org-init-appearance-h to exclude those variables like @alarsyo suggested earlier. Both this and my prior post's work were required to get the desired visible-stars.

I think I understand the issue now. Removing +org-init-appearance-h is not necessary. doom-themes-ext-org.el is the issue, and only for daemon users. Those settings don't take effect until the theme is loaded, and for daemon users, the theme is deferred until the first frame is opened (which is usually longer after your config has been read).
As always, the daemon always complicates things. I'll look into a fix soon.

Sorry for the late response. This was fixed in https://github.com/hlissner/emacs-doom-themes/commit/5c12834e724869993e1fa62cb3be29fda994a0d6, and was pulled into Doom when :ui doom was bumped a couple days ago, so I'll consider this resolved. Thanks for bringing it to my attention!


Catch SIGTERM signal to gracefully terminate

While dockerizing the app, I've found that it ignores SIGTERM signals from both CTRL+C and docker stop commands (it just gets killed after 10 seconds in the later case).
Trapping SIGTERM signal to terminate gracefully would prevent this annoyance.
Thank you for this useful app.

I tried to manage this, but without success. Seams like Socket.IO is a bit nasty when an immediate shutdown is desired. If you want, you can try with branch https://github.com/hgoebl/nerdshow/tree/0.5.0-sigterm-and-upgrade-dep and create PR then. Don't have enough time currently.

Tested it and works OK, thank you.
Successfully viewed "About" demo slideshow and used remote without problem.
Excerpt from stdout:
´´´
Starting src_app_1
Attaching to src_app_1
app_1  | No argument given for folder - taking examples...
app_1  | Express serving nerdshow at http://localhost:8008/
app_1  | Process ID: 1
app_1  | Serving files in /usr/src/app/examples
app_1  | Socket connected! id: IJLvPL_ENvRnqJFdAAAA
app_1  | Socket connected! id: n7IyzoaLD_eRuFBsAAAB
app_1  | SIGTERM received, shutting down...
app_1  | express closed
app_1  | io closed
src_app_1 exited with code 0
PR sent as instructed.

Thanks for contributing @pataquets
npm published minutes ago.


[WIP] Replace AsContiguous

Per the comments on #341 , this PR removes the AsContiguousFn trait and as_contiguous function entirely, and instead pushes the relevant details into the implementation of ArrayFlatten::flatten for the ChunkedArray type.
A few questions I've bumped into while doing this refactor:

Can DType::List only reference primitive types? I see ListScalar, but it’s not clear to me how Vortex would encode e.g. List or List
How should this work for ExtensionArray?

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Just pushed one more patch

Fix SparseArray's flatten implementation. Previously it only worked for primitive types, but SparseArray's logicalvalidity is a bool sparsearray. Flattening on that works as expected now
Add AsArrowArray impl for ConstantArray so that we can send a flattened null ConstantArray to arrow like the other Flattened variants