Export classes and functions from library for Windows & Linux

The DLL exporting of classes and methods on Windows requires them to be exported using:
#ifndef CLIPPER2_DLL
#  if defined(_WIN32)
#    ifdef CLIPPER2_DLL_EXPORT
#      define CLIPPER2_DLL __declspec(dllexport)
#    else
#      define CLIPPER2_DLL __declspec(dllimport)
#    endif
#  else
#    if __GNUC__ >= 4
#      define CLIPPER2_DLL __attribute__((visibility("default")))
#    else
#      define CLIPPER2_DLL
#    endif
#  endif
#endif

The above should be in a header file on its own and included as needed.
With classes defined:
class CLIPPER2_DLL Clipper2Class ....

When building the define CLIPPER2_DLL_EXPORT is declared. When linking to a library the define is not set.
On Linux the classes and methods will also be exported correctly when the option -fvisibility=hidden is used when creating a shared library.
Also see #169

Following up on my question here... I'm still not persuaded that exporting classes is better that exporting well designed functions.
For example ISTM that the following function would provide all the functionality of directly accessing a Clipper64 object:
  static const unsigned CLIP_FLAG_REVERSE_SOLUTION = 1;
  static const unsigned CLIP_FLAG_REMOVE_COLLINEAR = 2;

  inline bool BooleanOp(ClipType cliptype, FillRule fillrule,
    const Paths64& subjects, const Paths64& open_subjects, const Paths64& clips,
    Paths64& closed_solutions, Paths64& open_solutions, unsigned clip_flags = 0)
  {
    Paths64 result;
    Clipper64 clipper;
    clipper.AddSubject(subjects);
    clipper.AddOpenSubject(open_subjects);
    clipper.AddClip(clips);
    clipper.PreserveCollinear = !(clip_flags & 2);
    clipper.ReverseSolution = (clip_flags & 1);
    return clipper.Execute(cliptype, fillrule, closed_solutions, open_solutions);
  }

Of course there would need to be a similar function that returned PolyTree64, and the same for ClipperD.

May I add my two cents, please?
I don't know how/is the version compatibility check is done in Windows world nowadays and was it ever implemented in MS C++ compiler system-wide. so to say (last time I coded something for Windows in the beginning of zeroes).
Nevertheless, I don't see a problem to implement such a check: there is a number of ways to call a function before Main in C++. So that function defined inside clipper2.hpp and only compiled during builds of 'importing' applications (#ifdef-ed), so it calls a getVersion function from the dll and aborts the app execution on version mismatch.
For the unix world this is done by .so versioning, thus no need for runtime check.
As for defining wrappers - it would only increase code maintenance difficulty: every time you change any method declaration to be exported you have to change the interface function. So, this is really unnecessary level of indirection.

As for defining wrappers - it would only increase code maintenance difficulty

Well I'm certainly motivated to avoid code maintenance as much as possible. And part of that is keeping the code as simple as possible, part of which is minimizing compiler directives. Anyhow, I'm not against exporting classes in principle, I'm just hoping for a dll/so solution that works well on all platforms.

When Clipper has a permissive license and compiles to a reasonably small binary, what exactly is the use case for a Clipper.dll on Windows?

The C implementation is the fastest. You could convert this into a DLL. Delphi people can then just use these dll and take advantage of the speed.

But Delphi surely can't import C++ classes? So for that use case, there should be a plain C API, right?

Yep!

But Delphi surely can't import C++ classes? So for that use case, there should be a plain C API, right?

And why I'm still (very slightly) leaning toward function wrappers instead of exposing classes.

But Delphi surely can't import C++ classes? So for that use case, there should be a plain C API, right?

And why I'm still (very slightly) leaning toward function wrappers instead of exposing classes.

Yes, this changes the picture.
Btw, the same dll may expose C and C++ symbols at the same time, so basically, Delphi library becomes just a binding...

http://rvelthuis.de/articles/articles-cppobjs.html

I've just added a new clipper.export.h file to create DLL/so files and a sample delphi app to test.
I see this file as a proof of concept rather than a definitive response to the above discussion.

Seems to be a 32 bit problem.

I can't duplicate this. Are you using the latest commit?
procedure DoRandomStressTest(maxCnt: integer);
var
  i: integer;
  sub, clp: TPathsD;
  csub_local, cclp_local: CPathsD;
  csol_extern, csolo_extern: CPathsD;
begin
  csolo_extern := nil;
  SetLength(sub, 1);
  SetLength(clp, 1);

  for i := 1 to maxCnt do
  begin
    sub[0] := MakeRandomPathD(400, 400, 50);
    clp[0] := MakeRandomPathD(400, 400, 50);
    csub_local := TPathsDToCPathsD(sub);
    cclp_local := TPathsDToCPathsD(clp);

    BooleanOpD(Uint8(TClipType.ctIntersection),
      Uint8(TFillRule.frNonZero),
      csub_local, nil, cclp_local,
      csol_extern, csolo_extern);

    DisposeLocalCPathsD(csub_local);
    DisposeLocalCPathsD(cclp_local);
    DisposeExportedCPathsD(csol_extern);
    DisposeExportedCPathsD(csolo_extern);
    if i mod 100 = 0 then Write('.');
  end;
  WriteLn(#10'Passed!');
end;

var
  s: string;
begin
  Randomize;
  DoRandomStressTest(10000);
  ReadLn(s);
end;

Yes, I do
Clipper2_32.zip

Seems to be a 32 bit problem.

OK, I missed that bit.

Fix just uploaded.

Hi Angus, thanks for the correction. Does the benchmark mean (4000 edges) that the C implementation is 6x faster than Delphi? Bad time for Delphi? :-(

Hi Angus, thanks for the correction. Does the benchmark mean (4000 edges) that the C implementation is 6x faster than Delphi? Bad time for Delphi? :-(

Firstly, the performance test I've coded in the sample apps intentionally creates multiple intersections at the same locations as a kind of stress test of the clipping algorithm, and also significantly slows clipping. This is important to understand because it's not just the number of edges that affects timing, but the size of the random polygons too. Larger polygons will have fewer co-located intersections so clipping will be faster). This is especially important when comparing ClipperD with Clipper64 objects. ClipperD performance will usually appearing much faster than Clipper64 but this is simply because ClipperD by default scale paths *100 (so polygons are much bigger with fewer co-located intersections). So make sure you're comparing Clipper64 with Clipper64 (or comparing ClipperD with ClipperD without scaling) and make sure the random polygons are generated with the same regions.

Okay, understood, of course I have to take that into account.


Card on edge Mobile not showing properly

Describe the bug
While browsing on Edge Mobile the cards don't show the vip/edit/copy command line at the bottom of the card
To Reproduce
Steps to reproduce the behavior:

Use Edge mobile
open a card
the command is not showing up at the bottom of the card

Expected behavior
the command and the edition buttons should show up
Smartphone :

Device: Huawei p8 lite 2017
OS: android
Browser: edge mobile

this issue was fixed in v1.2 with the rework of the music items


cmake.parallelJobs ignored in workspace's .vscode/settings.json

Brief Issue Summary
When cmake.parallelJobs is set the the user's main settings.json and is also set in workspace's .vscode/settings.json, then the workspace value is ignored and only the main user's setting is used. (I thought this worked in the past but noticed it does not today).
user's settings.json
"cmake.parallelJobs": 14,

workspace .vscode/settings.json
"cmake.parallelJobs": 1,

Result
a cmake build in vscode of...
[proc] Executing command: "C:\Program Files\CMake\bin\cmake.exe" --build c:/njs/depthai-core/build --config Debug --target all -j 14 --
[build] [14/50   2% :: 0.140] cmd.exe /C "cmd.exe /C "...

Workaround
Don't use the workspace settings file for this cmt setting. Instead, set the desired parallelJobs in the main user settings.json
CMake Tools Diagnostics
{
  "os": "win32",
  "vscodeVersion": "1.79.0",
  "cmtVersion": "1.14.33",
  "configurations": [
    {
      "folder": "c:\\njs\\depthai-core",
      "cmakeVersion": "3.26.4",
      "configured": true,
      "generator": "Ninja",
      "usesPresets": false,
      "compilers": {
        "C": "C:/Program Files (x86)/Microsoft Visual Studio/2019/Community/VC/Tools/MSVC/14.29.30133/bin/Hostx64/x64/cl.exe",
        "CXX": "C:/Program Files (x86)/Microsoft Visual Studio/2019/Community/VC/Tools/MSVC/14.29.30133/bin/Hostx64/x64/cl.exe"
      }
    }
  ],
  "cpptoolsIntegration": {
    "isReady": true,
    "hasCodeModel": true,
    "activeBuildType": "Debug",
    "buildTypesSeen": [
      "Debug"
    ],
    "requests": [],
    "responses": [],
    "partialMatches": [],
    "targetCount": 144,
    "executablesCount": 112,
    "librariesCount": 4,
    "targets": []
  },
  "settings": [
    {
      "communicationMode": "automatic",
      "useCMakePresets": "auto",
      "configureOnOpen": false
    }
  ]
}

Debug Log
No response
Additional Information
No response

Thanks for the report! We'll try to reproduce this issue and let you know if we have any additional questions.

👍

I am unsure whether this issue has been completely resolved. I can reproduce this issue by setting different parallel jobs in remote and workspace.
If I set cmake.parallelJobs to 12 in remote settings and set 16 in workspace, then cmake build will get:
[proc] Executing command: /usr/bin/cmake --build /repo/build --config Debug --target all -j 12 --


Envoy HCM RDS Update Not Reflected in Config Dump Without Restart

Hi all,
I use go-control-plane (delta_grpc, ads, snapshot, envoy_v1.31.0). In my setup, I have two distinct listeners, each with its own HTTP Connection Manager (HCM) filter. Both HCM filters are linked to an RDS named “v28rds.”
When I attempt to update the route for one of the HCM filters by changing the RDS configuration to use a new route configuration named “route_for_ccc” the RDS definition of the relevant HCM in the config_dump reflects this change like that:
"rds": {
    "config_source": {
        "ads": {},
        "initial_fetch_timeout": "10s",
        "resource_api_version": "V3"
    },
    "route_config_name": "route_for_ccc"
},

However, the new route configuration does not appear in the config_dump. But it is present in the snapshot in go-control-plane, envoy does not request to get the configuration.
This indicates that the updated route is not being applied correctly, as it doesn’t even show up in the config_dump. Could you provide insight into whether this is a known limitation or suggest any steps to ensure that Envoy properly updates and applies the new route configuration without requiring a restart?
Except restart, when I remove the hcm filter from the listener and add it, all configuration comes complete.
Note: I encountered a similar issue with EDS, which was resolved by setting a runtime flag: envoy.restart_features.use_eds_cache_for_ads. This flag allowed Envoy to use cached resources when the initial fetch timed out. Starting from Envoy version v1.31.0, this flag is enabled by default, and I am currently using v1.31.0. However, a similar flag or approach does not appear to be available for RDS.
[2024-09-13 10:43:04.594][37022954][debug][main] [source/server/server.cc:237] flushing stats
[2024-09-13 10:43:09.292][37022954][debug][http2] [source/common/http/http2/codec_impl.cc:1803] [Tags: "ConnectionId":"0"] Http2Visitor::OnFrameHeader(1, 497, 0, 0)
[2024-09-13 10:43:09.292][37022954][debug][http2] [source/common/http/http2/codec_impl.cc:1855] [Tags: "ConnectionId":"0"] Http2Visitor::OnBeginDataForStream(1, 497)
[2024-09-13 10:43:09.292][37022954][debug][http2] [source/common/http/http2/codec_impl.cc:1867] [Tags: "ConnectionId":"0"] Http2Visitor: remaining data payload: 497, end_stream: false
[2024-09-13 10:43:09.292][37022954][debug][http2] [source/common/http/http2/codec_impl.cc:1896] [Tags: "ConnectionId":"0"] Http2Visitor dispatching DATA for stream 1
[2024-09-13 10:43:09.293][37022954][debug][config] [source/extensions/config_subscription/grpc/new_grpc_mux_impl.cc:143] Received DeltaDiscoveryResponse for type.googleapis.com/envoy.config.core.v3.TypedExtensionConfig at version 10
[2024-09-13 10:43:09.293][37022954][debug][filter] [source/common/filter/config_discovery_impl.cc:132] Updated filter config eeeeeeeoHADD-fcjyJPtD-filter accepted, posting to workers
[2024-09-13 10:43:09.293][37022954][debug][init] [source/common/init/manager_impl.cc:24] added target RdsRouteConfigSubscription RDS local-init-target route_for_ccc to init manager RDS local-init-manager route_for_ccc
[2024-09-13 10:43:09.293][37022954][debug][config] [./source/common/http/filter_chain_helper.h:111]     http filter #0
[2024-09-13 10:43:09.293][37022954][debug][config] [./source/common/http/filter_chain_helper.h:173]       dynamic filter name: http-filters-bgBMRm
[2024-09-13 10:43:09.293][37022954][debug][filter] [source/common/filter/config_discovery_impl.cc:146] Updated filter config eeeeeeeoHADD-fcjyJPtD-filter created, warming done
[2024-09-13 10:43:09.293][37022954][debug][config] [source/extensions/config_subscription/grpc/delta_subscription_state.cc:262] Delta config for type.googleapis.com/envoy.config.core.v3.TypedExtensionConfig accepted with 1 resources added, 0 removed
[2024-09-13 10:43:09.300][37022954][debug][init] [source/common/init/watcher_impl.cc:31] init manager RDS local-init-manager v28rds destroyed
[2024-09-13 10:43:09.300][37022954][debug][init] [source/common/init/target_impl.cc:34] target RdsRouteConfigSubscription RDS local-init-target v28rds destroyed
[2024-09-13 10:43:09.300][37022954][debug][init] [source/common/init/watcher_impl.cc:31] RDS local-init-watcher v28rds destroyed
[2024-09-13 10:43:09.300][37022954][debug][init] [source/common/init/target_impl.cc:68] shared target RdsRouteConfigSubscription RDS init v28rds destroyed
[2024-09-13 10:43:09.300][37022954][debug][init] [source/common/init/target_impl.cc:34] target DynamicFilterConfigProviderImpl destroyed
[2024-09-13 10:43:09.300][37022954][debug][filter] [source/common/filter/config_discovery_impl.cc:181] Filter config eeeeeeeoHADD-fcjyJPtD-filter worker update complete

cc @adisuissa

I don't see the RDS request in the logs you supplied.
Before digging into this further, you are saying that if there are 2 distinct listeners, you observe a problem. If there's a single listener do you still observe a problem? If the 2 listeners use a different RDS resource, do you still observe a problem?
Also, can you supply more info about the what is being updated? I'm assuming you update the listener and it is updated correctly, but just want to make sure.

I followed your suggestions and tested with a single listener. I updated the RDS configuration within the HCM by changing the RDS name. Even though the new RDS configuration is present in the snapshot, Envoy does not request the updated RDS.
In the initial config_dump, if you search for “v28rds,” you will find it in two locations: one under “ecds_filters” and the other under “dynamic_route_configs.”
However, after updating the HCM to replace “v28rds” with “route_for_ccc,” I updated the snapshot accordingly. Despite this, Envoy does not fetch the route configuration from the updated snapshot. In the updated config_dump, if you search for “route_for_ccc,” you will see it within the RDS definition under “ecds_filters,” but it does not appear under “dynamic_route_configs.”
Below, you can find the initial snapshot configurations and the Envoy config_dump output. I have also included the snapshots and config_dump outputs after the update.


paperjam: init at 1.2

Description of changes
Paperjam is a simple command line tool for manipulating PDF files (rotate pages, reorder them, put multiple pages on one for cheaper printing…). It is similar to pspdftool, but maintained (can correctly handle compressed PDFs for example).
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 216782 run on x86_64-linux 1

1 package built:

paperjam

Sorry for the delay, can we merge now?

Fix the merge conflicts.
Because of some dark magic under the corners, the doc generation is failing over all Nixpkgs. Please wait a little more until the issue  is solved.

Apologies for the failure.

Now you can restart, @vojta001

Thank you, rebased to master.

@vojta001 are you still interested pushing this forward? It would be nice to have :+1:
FTR, some previous work: https://github.com/jvns/nixpkgs/blob/22b70a48a797538c76b04261b3043165896d8f69/paperjam.nix (blog post: https://jvns.ca/blog/2023/02/28/some-notes-on-using-nix/)

Closing as dead.


Render side nav server-side

Currently the left side nav is rendered on the client side in response to the final JS chunk file being downloaded from the page (thereby enabling page hydration). The absence of this content on the first paint negatively impacts SEO because the cross linking between pages is greatly reduced for what a search engine would see.
This issue is the work to render the side nav server-side instead so it is available on first paint.
The piece that can remain dynamic and dependent on a context or hook is the actively selected entries from the nav.

This will be a great UX improvement. In the future when we're using next/link again for anchors and not doing full page reloads at page navigation, will the side nav be rendered server-side for just the initial request? And then hydrated as a normal React component that receives context updates to get updated at page navigation?
Another way to ask this - once we're using the Next.js Link component, will the side nav flash with a new side nav coming in server side each new page? Or can we keep the side nav on the page and just feed it new content?

I'm not entirely convinced of the SEO implications here.
Per https://nextjs.org/blog/next-12#bot-aware-isr-fallback, Next.js ISR pages won't let crawlers index loading states.
I can't test this because we're currently blocking crawlers while we're on a subdomain. What I want to do is simulate the Googlebot user agent and look at what links are available on the first network request:

I trust that test over anything else, but a couple sites that I tried. The side nav links don't show up here, but I don't know if this test uses a crawler user agent:

Regarding SEO, I think we should do this issue for UX reasons and if it helps SEO, great. My understanding is that crawlers don't only index what's available on first paint.

Another way to ask this - once we're using the Next.js Link component, will the side nav flash with a new side nav coming in server side each new page? Or can we keep the side nav on the page and just feed it new content?

@mattrosno There definitely won't be a flash because the nav + page content will all be part of the generated html for a given route, so it'll all come across the wire together. Based on what we saw during the performance testing of the route preloading, the "next" page is downloaded async in the background, and once ready, the route switches and the content updates. Assuming that's the case, the new side nav plus the new page content will all be updated as a single unit.

Hey team! Please add your planning poker estimate with Zenhub @andreancardona @francinelucca @jdharvey-ibm


fix #3034 use %n format

What changes were proposed in this pull request?
String.format() change \n to %n
Why are the changes needed?
Fix: #3034
Does this PR introduce any user-facing change?
no
How was this patch tested?
no

@yuqi1129 hello, can help review


chore: simplify changes for OS bundle PR

What problem does this PR solve?:
Some improvements to https://github.com/mesosphere/konvoy-image-builder/pull/167

Reverts versionlock changes as its only being used in 1 place again
Cleanup unused offline vars
Change the remote location to /opt/dkp/packages
Move offline repo config to the same role as the rest of the repo config code

I was not able to test because I can't build or run these Makefile targets on a Mac.
Which issue(s) does this PR fix?:

https://jira.d2iq.com/browse/D2IQ-NUMBER

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Closing in-favor of https://github.com/mesosphere/konvoy-image-builder/pull/176


Update fileHandling.js

this may result in XML Parsing Error
example: http://localhost:8080/posts//upload

Ah yes, someone pointed that out earlier. I've already corrected that, I'll be pushing it soon


React Native SDK broken. Unable to resolve "thirdweb/pay" from<EMAIL_ADDRESS>

If I try installing adding react-native sdk, either in a bare react-native project or in an expo project I get the following error. The error happens as soon as you add ThirdWebProvider component to your app.
ERROR  [Error: undefined Unable to resolve module thirdweb/pay from<EMAIL_ADDRESS>thirdweb/pay could not be found within the project or in these directories:
  node_modules/@thirdweb-dev/sdk/node_modules
  node_modules
  111 | require('uuid');
  112 | require('thirdweb');
> 113 | require('thirdweb/pay');
      |          ^
  114 | require('thirdweb/utils');
  115 | require('fast-deep-equal');
  116 | require('./marketplace-bc46f8c3.cjs.prod.js');]

There are also other users on discord having this issue: https://discord.com/channels/834227967404146718/1229386961018425444
I have tried different versions of expo, thirdweb's packages, and react-native without luck.

hi @jrhe we are working on this one, in the meantime you should be able to solve this by temporarily pinning @thirdweb-dev/react-native to version 0.73.1: https://github.com/thirdweb-dev/js/releases/tag/%40thirdweb-dev%2Freact-native%400.7.31

Also running into the same issue here. Looking forward for it to be resolved soon :+1:

Hi @jnsdls, I have tried to downgrade to older version but i don't know why it still has the same issue.

Hi @jnsdls, I have tried to downgrade to older version but i don't know why it still has the same issue.

can you try deleting your node_modules and reinstalling? most likely you have ended up with a cached dependency of some sort

We're targeting a minimal version of the react-native overhaul (first version) by end of this week or early next week. It will likely come with less pre-configured wallet support out of the box initially (since the wallet libraries are (mostly) the things that force us into bad DX (having to eject out of expo, installing tens of polyfills etc)

hi @jrhe we are working on this one, in the meantime you should be able to solve this by temporarily pinning @thirdweb-dev/react-native to version 0.73.1

<EMAIL_ADDRESS>does not exist.  I did try 0.7.31 but it still has the same issue. Or I may have not cleaned, deleted builds and stuff enough? Though I did verify that is the package being used

<EMAIL_ADDRESS>does not exist. I did try 0.7.31 but it still has the same issue. Or I may have not cleaned, deleted builds and stuff enough? Though I did verify that is the package being used

Yeah I also think there maybe some mistake here, I have tried 0.7.31 -> 0.5.xx but it still has the same error, also tried to create a new React Native Project form scratch too but still the same.

I will be trying a few more versions and try to track it down

I reverted to 0.7.31 and the issue went away:
"@thirdweb-dev/react-native": "^0.7.31",
"@thirdweb-dev/react-native-compat": "^0.7.31",
Maybe delete the cache and rebuild.
I've had a lot of issues with the React Native SDK.
I will probably put my mobile app on hold until the overhaul is available.
The v5 React SDK is so much better.

While waiting for the fix i tried this (little hacky) solution:
const { getDefaultConfig, mergeConfig } = require('@react-native/metro-config')
const extraNodeModules = require('node-libs-browser')

/**
 * Metro configuration
 * https://facebook.github.io/metro/docs/configuration
 *
 * @type {import('metro-config').MetroConfig}
 */
const config = {
  resolver: {
    extraNodeModules,
    resolveRequest: (ctx, moduleName, platform) => {
      if (moduleName.startsWith('thirdweb')) {
        return {
          filePath: `${__dirname}/node_modules/thirdweb/dist/esm/`,
          type: 'sourceFile',
        }
      }

      // Optionally, chain to the standard Metro resolver.
      return ctx.resolveRequest(ctx, moduleName, platform)
    },
  },
}

module.exports = mergeConfig(getDefaultConfig(__dirname), config)

unfortunately, I got another error Invariant Violation: Unexpectedly escaped traversal but maybe it's just because my stack/setup, you can try it on your setups guys and wait till official fix.

unfortunately, I got another error Invariant Violation: Unexpectedly escaped traversal but maybe it's just because my stack/setup, you can try it on your setups guys and wait till official fix.
I have tried your method but also get the error like you, my project is new set up, sadly right now i cant find any way to run thirdweb in my react native project with any version

I have added the react-native-compat library as well, but then it looked for different other packages that I added. At the end of it, it couldn't find the "Button" component from react-native itself.

hey, was anyone able to find any resolution to this?

Don't think so @theweb3kid . Until this bug is resolved, there doesn't seem to be any way to make thirdweb work with React Native.

Hay Guys are you still facing this issue if you got it please share

same issue here. Still waiting for fix. Thanks.

We're targeting a minimal version of the react-native overhaul (first version) by end of this week or early next week. It will likely come with less pre-configured wallet support out of the box initially (since the wallet libraries are (mostly) the things that force us into bad DX (having to eject out of expo, installing tens of polyfills etc)

Is there any update on this? I only need inApp wallet and smart wallet support.

we released a patch 0.8.0 of the @thirdweb-dev/react-native package which should resolve this issue - can you all confirm?
In the meantime, we're working on a completely revamped react native package based on the v5 typescript/react web SDK, will be more performant and much lighter than the current one - stay tuned for updates!

Still not working for me unfortunately, I removed node_modules and did a metro reset of the cache. Latest working version for me is 0.7.21

Still getting the same error. I can fix it by removing all references to 'thirdweb', 'thirdweb/pay' and 'thirdweb/utils'. And removing all the functions associated with 'getBuyWithCrypto'.

Still getting the error

Ended up switching to privy as although I got it running after a load of time and fiddling, I then ran into further errors.

hey all, we've been hard at work making v5 work in react native projects.
We've got it mostly working, just working on docs now and putting in the last finishing touches.
will post the docs links here as soon as they're up

Kudos for the hard work, team! Let us know if you need any help with testing. We're excited to integrate as soon as possible!

Latest release is out V5.23.0 now works with react native with the additional @thirdweb-dev/react-native-adapter and a few other dependencies.
Appart from installation, everything works the same as on the web with the same imports.
Docs: https://portal.thirdweb.com/typescript/v5/react-native
Demo repo: https://github.com/thirdweb-example/expo-starter
Let us know what you think!

Thanks for the update.
My react native app uses<EMAIL_ADDRESS>I'm getting this error installing thirdweb:
Conflicting peer dependency<EMAIL_ADDRESS>Is it possible to use thirdweb with the latest version of amplify?

Also getting this error when building on android:
Cannot locate tasks that match ':coinbase-wallet-mobile-sdk:assembleDebug' as project 'coinbase-wallet-mobile-sdk' not found in root project.

Thanks for the update.
My react native app uses<EMAIL_ADDRESS>I'm getting this error installing thirdweb:
Conflicting peer dependency<EMAIL_ADDRESS>Is it possible to use thirdweb with the latest version of amplify?

It's on our todo lost to upgrade to v6, but it's a hard dependency of react-native-adapter so it shouldn't cause issues? What error do you see?

Also getting this error when building on android:
Cannot locate tasks that match ':coinbase-wallet-mobile-sdk:assembleDebug' as project 'coinbase-wallet-mobile-sdk' not found in root project.

The V5 SDK does not have/use Coinbase wallet SDK yet. Might need to remove it from your project

I managed to get the App to build by converting my React Native CLI project to an Expo project.
I followed the expo-starter example to create a custom wallet connect button, but I'm receiving these errors when I click the inApp sign in buttons:
ERROR  TypeError: Cannot read property 'loginWith' of undefined, js engine: hermes
ERROR  [TypeError: Cannot read property 'InAppNativeConnector' of undefined]
The InApp buttons show a continuous loading state and fail to connect.
The MetaMask button successfully connects but still shows the errors.

The fix for this is to just install thirdweb 5. You don't have to use it since some modules aren't supported yet, but just install it to resolve the requirements.
npm install thirdweb

Closing this issue.
Everyone should migrate to the latest thirdweb V5 SDK for react native moving forward to get support and updates.
If you run into any issue with thirdweb SDK V5 on react native feel free to open a new issue!


Local development setup using Docker Compose or Testcontainers

I will work on this

Completed https://github.com/sivaprasadreddy/spring-blog/commit/0716115c99148c2c99d11e95cd7aadbd2ecc32b8


discoverd/server: Run a single etcd server for all tests

Instead of booting a new server, we can just use a different prefix for each test case.
This shaves ~20s off of the test runtime.

LGTM


Display player name if only one player is affected in history tab

In history tab, directly display player name instead of "multiple" if only one player is affected.

Nice! In lua local variables only live inside their scope.
Try defining the local variable outside the if statement (without a value). Inside the if statement you can then use the variable without local prefix.


Drive letter is lowercase

OS: Windows 10

When starting windows terminal I have a path with small letter of drive.

I fixed it, but I think it is not good solution.
let cwd = uri.fsPath
cwd = cwd.substring(0, 0) + cwd.charAt(0).toUpperCase() + cwd.substring(0 + 1)

console.log(cwd)

vs code issue

Hey, it would be great to make this the default since (for example) NextJS throws a warning if the Drive Letter is lowercase


Remove rest/spread operation of objects from js

Currently babel plugin for these operation does not work in drone-ci

[03:14:15] Plumber found unhandled error:
SyntaxError in plugin "gulp-babel"
Message:
/usr/app/deps/ecommerce/front/main.js: Unexpected token (37:8)

Block #129


HIstorical data compatibility

Hey!
Fantastic project, i must say. Surprised by the lack of discussions even as raised issues, given the scope and features of the project.
I was wondering, if it is possible to somehow integrate data from Tardis (cryptocurrency historical data provider) into this framework and run simulations?

Hi @artiko88,
Thanks a lot for your interest in rl4mm! Unfortunately, the repository is optimised for Nasdaq orderflow (ITCH) data. Tardis only deals in trade-and-quote (TAQ) data, so whilst it would be possible to modify rl4mm to use TAQ, there might be faster ways to run a simulator by making certain assumptions (since you need to make assumptions about order cancellations, etc, with TAQ anyway). If you are working with Tardis data and decide to extend compatibility to their datasets, please open a PR though, I am sure there are other users that would like this functionality!
All the best


When the path of lib contains @, the type of the submodule cannot be obtained in monaco-editor

Does this issue occur when all extensions are disabled?: Yes/No

monaco-editor Version: 0.52.0

Steps to Reproduce:

open this monaco-editor playground
hover Typography and click to peek definition, and then you can't see OriginTypography type.

If rename @scope/myLib to myLib, then it can get type when peek definition, so I think there must be some problems when use addExtraLib to add some lib that its path has @, most of lib may have scope, so @ can't be avoided.

Please help?

@chrmarti Please help? Could you give some advice to solve this problem?

This is not supported at the moment.

@hediet Excuse me, What do you mean by not supporting it? It is a bug that resolve typescript model file path.


Does this library still support JAVA??

Doesn't seem to have message setter in java

No, most of the library's functions work through extension functions.


bug: Seems like deterministic test will occasionally panic when broken fifo_channel error happens

Describe the bug
Known issue: Our batch engine can not propate errors between different executor now, see #3908 . Now we just throw broken channel error up.
However, for deterministic e2e test, it seems like sometimes we will crash/panic on some node and lead to test failed. I guess madsim somehow process this kind of error wrongly and lead to the crash?
The broken error should init from here:
https://github.com/singularity-data/risingwave/blob/b64d8294c091413fa517eb70a0659ae3c6bcd3d0/src/batch/src/task/fifo_channel.rs#L47-L59
To Reproduce
create a slt file in e2e_test/batch/, (My is named b2.slt) content
statement ok
create table t(v int);

statement ok
insert into t values(0);

statement ok
flush;

statement error
select (1/v) from t;

statement ok
drop table t;

For madsim:
MADSIM_TEST_NUM=100 ./risedev sslt -- "e2e_test/batch/b2.slt"
(Did not provide a constant madsim seed here cuz I can not reproduce with that seed...)
If everything goes right, you should get
2022-11-27T20:26:07.389264Z ERROR node{id=3 name="frontend-2"}:task{id=27296}: risingwave_frontend::session: failed to handle sql:
select (1/v) from t;:
Scheduler error: Task fail
2022-11-27T20:26:07.389264Z ERROR node{id=3 name="frontend-2"}:task{id=27296}: pgwire::pg_protocol: Error: QueryError: Scheduler error: Task fail
2022-11-27T20:26:07.404476Z ERROR node{id=5 name="compute-2"}:task{id=27677}: risingwave_batch::task::task_execution: Execution failed [TaskId { task_id: 0, stage_id: 0, query_id: "fad59924-fbff-41a4-9e2a-cd3f5dbe5c8c" }]: Invalid Parameter Value: Division by zero
disabled backtrace
thread '<unnamed>' panicked at 'called `Result::unwrap()` on an `Err` value: Custom { kind: ConnectionReset, error: "connection reset" }', /Users/bowen/.cargo/registry/src/github.com-1ecc6299db9ec823/madsim-tonic-0.2.1/src/transport/server.rs:249:50
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
note: run with `MADSIM_TEST_SEED=1661163288` environment variable to reproduce this error
      and make sure `MADSIM_CONFIG_HASH=C2F7CAF3EA64B636`
[cargo-make] ERROR - Unable to execute script.
[cargo-make] WARN - Build Failed.

For playground:
./risedev p
./risedev slt -p 4566 -d dev './e2e_test/batch/b2.slt'
Expected behavior
Expect deterministic e2e test do not panic and succeed. (Or there is some bug in our current server...)
Additional context
Add any other context about the problem here.

cc @KveinAxel @wangrunji0408, thanks!

I think backtrack is disabled.

Based on the panic location, it seems like a bug caused by madsim. This will happen when a tonic client drops a response stream, but the server is still trying to send a response.
I also failed to reproduce this error in risingwave. But I'll have a try to construct a minimal example in madsim.
Thanks for your catch! 🥰


Standardize escaping of ! parameters: "Never" option?

I noticed there is no Never option available for this rule.

Is it truly required to escape parameters that match ABAP keywords? I have been removing these for some time without issue. Perhaps we could add a Never option?

Hi Josh,
you're right, you can hardly find an example where this goes wrong. However, try this case (which is complete nonsense, of course) :
    METHODS any_method
      IMPORTING
        exporting TYPE i OPTIONAL
      EXPORTING
        changing  TYPE string
      CHANGING
        raising   TYPE i.

Kind regards,
Jörg-Michael

Thanks for the example. So it seems importing/exporting/changing/returning/raising are the only cases where it's truly a syntax error.
Perhaps this could be one of the configuration options? Or become the behavior for only if parameter name is ABAP word setting?

Hi Josh,
I think adding "never" as a fourth option would be a good solution – or maybe it could be called "only to avoid syntax errors" or "almost never" :-)
Please let me know if you find more examples of parameter names that trigger syntax errors. Apart from "exporting", "changing" and "raising", ! is apparently also needed for "default", "optional" and "preferred" (and "default" would be a parameter name that I could even imagine to be used in real life). By contrast, "importing", "value" and "reference" work fine.
Kind regards,
Jörg-Michael

Hi Josh,
I think adding "never" as a fourth option would be a good solution – or maybe it could be called "only to avoid syntax errors" or "almost never" :-)
Please let me know if you find more examples of parameter names that trigger syntax errors. Apart from "exporting", "changing" and "raising", ! is apparently also needed for "default", "optional" and "preferred" (and "default" would be a parameter name that I could even imagine to be used in real life). By contrast, "importing", "value" and "reference" work fine.
Kind regards, Jörg-Michael

I would support either solution. "Never" should be sufficient; engineers would be already alerted to an issue with the parameter name due to the syntax error, so cleanup really shouldn't be necessary.

Hi Josh,
okay, in the next release, this option will look as follows:

The example now shows all critical keywords that I am aware of:

Kind regards,
Jörg-Michael

Hi Josh,
this new option is now released with version 1.3.0!
Kind regards,
Jörg-Michael


Bug in sockaddr_to_network_addr

on any platform other than android, this function is not working at all like intended.
the transmute is not working and the sockaddr_dl it produces is invalid: check any member of it, they are all wrong. the only part that is ok is sdl_data that contains sa_data, which is not what was expected anyway.
fix is here:
https://git.nextgraph.org/NextGraph/default-net/commit/a06134963af02c415fda83a9d270499118ff6570

Thanks for the report and providing the fix.
This fixes will be included in the next release.


MODELIX-569 Implement model-adapters for tree elements

Will be merged into main instead. Superseded by #292


Convert geocaching urls to archive.org

Geocaching is removing all of its benchmark data. I'll try my best to move the pages over to archive.org

Fixed in fdc8b50


purify() doesn't work on IE and Safari

In the profanity.js file, line 79 fails on both Safari and IE if you pass in a string to the purify function. That's because Object.keys() in ES5 doesn't support passing in a string and those browsers haven't updated yet to the ES6 standard which does.

I don't think this needs to be patched in the official version of profanity-utils. But since I'm working with an older version of node js on an application, I was forced to make a fix. My fork is at https://github.com/skliffmueller/nodejs-profanity-util if you are interested.

Sorry for the late reply @dshorowitz - @skliffmueller just merged your fork and re-published the npm package. Thank you both.

It works, problem solved!


BUG: index-contigs fails if any input files are empty

If no contigs are formed for any samples during assembly, and a SampleData[Contigs] with some .fa files of size zero is therefore passed as input to index-contigs, index-contigs fails with a fairly uninformative error message:
  An error was encountered while running Bowtie2, (return code 1), please inspect stdout and stderr to learn more.

The --verbose output was more useful, but still only "warned" about an empty fasta file:
Input files DNA, FASTA:
  /scratch/gcaporaso/temp/qiime2/gcaporaso/data/b1c35261-68ee-4d73-864e-80ca50a04069/data/NEC-EF_contigs.fa
Warning: Empty fasta file: '/scratch/gcaporaso/temp/qiime2/gcaporaso/data/b1c35261-68ee-4d73-864e-80ca50a04069/data/NEC-EF_contigs.fa'
Warning: All fasta inputs were empty
Total time for call to driver() for forward index: 00:00:00
Error: Encountered internal Bowtie 2 exception (#1)
Command: /home/gcaporaso/mambaforge/envs/q2dev-20235-shotgun/bin/bowtie2-build-s --wrapper basic-0 --bmaxdivn 4 --dcv 1024 --offrate 5 --ftabchars 10 --threads 40 /scratch/gcaporaso/temp/qiime2/gcaporaso/data/b1c35261-68ee-4d73-864e-80ca50a04069/data/NEC-EF_contigs.fa /scratch/gcaporaso/temp/q2-Bowtie2IndexDirFmt-35dkmvkk/NEC-EF/index
Traceback (most recent call last):
  File "/home/gcaporaso/4-git-repos/qiime2/q2-assembly/q2_assembly/bowtie2/indexing.py", line 50, in _index_seqs
    run_command(cmd, verbose=True)
  File "/home/gcaporaso/4-git-repos/qiime2/q2-assembly/q2_assembly/_utils.py", line 28, in run_command
    subprocess.run(cmd, check=True)
  File "/home/gcaporaso/mambaforge/envs/q2dev-20235-shotgun/lib/python3.8/subprocess.py", line 516, in run
    raise CalledProcessError(retcode, process.args,
subprocess.CalledProcessError: Command '['bowtie2-build', '--bmaxdivn', '4', '--dcv', '1024', '--offrate', '5', '--ftabchars', '10', '--threads', '40', '/scratch/gcaporaso/temp/qiime2/gcaporaso/data/b1c35261-68ee-4d73-864e-80ca50a04069/data/NEC-EF_contigs.fa', '/scratch/gcaporaso/temp/q2-Bowtie2IndexDirFmt-35dkmvkk/NEC-EF/index']' returned non-zero exit status 1.

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/home/gcaporaso/mambaforge/envs/q2dev-20235-shotgun/lib/python3.8/site-packages/q2cli/commands.py", line 468, in __call__
    results = action(**arguments)
  File "<decorator-gen-736>", line 2, in index_contigs
  File "/home/gcaporaso/mambaforge/envs/q2dev-20235-shotgun/lib/python3.8/site-packages/qiime2/sdk/action.py", line 274, in bound_callable
    outputs = self._callable_executor_(
  File "/home/gcaporaso/mambaforge/envs/q2dev-20235-shotgun/lib/python3.8/site-packages/qiime2/sdk/action.py", line 509, in _callable_executor_
    output_views = self._callable(**view_args)
  File "/home/gcaporaso/4-git-repos/qiime2/q2-assembly/q2_assembly/bowtie2/indexing.py", line 85, in index_contigs
    _index_seqs(contig_fps, str(result), common_args, "contigs")
  File "/home/gcaporaso/4-git-repos/qiime2/q2-assembly/q2_assembly/bowtie2/indexing.py", line 52, in _index_seqs
    raise Exception(
Exception: An error was encountered while running Bowtie2, (return code 1), please inspect stdout and stderr to learn more.

Plugin error from assembly:

  An error was encountered while running Bowtie2, (return code 1), please inspect stdout and stderr to learn more.

See above for debug info.
Running external command line application(s). This may print messages to stdout and/or stderr.
The command(s) being run are below. These commands cannot be manually re-run as they will depend on temporary files that no longer exist.

I came across this because I had a couple of control samples which had very few (<10) demultiplexed sequences in my input to assemble-megahit, and these unsurprisingly didn't form any contigs. When I ran index-contigs I got the error.
I'm not sure what the best pathway forward is for this - at the very least we probably want a more informative error message, but we also might want a way to filter the SampleData[Contigs] so the user doesn't have to generate contigs again (which can take a while). I got around it this time by filtering my input to assemble-megahit to drop the two samples that were causing problems with qiime demux filter.
EDIT: I just hit this again, on a different data set. (Aug 21 2023)

@colinvwood, @misialq, looks like this was addressed with a more informative error message in #63. What's the work-around if a user gets that error message? I think we should have a work-around that doesn't require re-running assembly, and once we have that this can be closed out.

Hey @gregcaporaso, should we add a filter-contigs action which would allow us to do filtering similar to the demux-filter action? We could also then add an option to filter out all empty contig files (rather than provide a list of filtering criteria). What do you think?

I like that idea @misialq.

Closing this - there is a new issue to track the development of contig filtering (#84).


Uncaught IndexError in fun.py line 98

Aider version: 0.54.7
An uncaught exception occurred:
Traceback (most recent call last):
  File "<frozen runpy>", line 198, in _run_module_as_main
  File "<frozen runpy>", line 88, in _run_code
  File "__main__.py", line 7, in <module>
    sys.exit(main())
             ^^^^^^
  File "main.py", line 550, in main
    coder.show_announcements()
  File "base_coder.py", line 444, in show_announcements
    for line in self.get_announcements():
                ^^^^^^^^^^^^^^^^^^^^^^^^
  File "base_coder.py", line 192, in get_announcements
    num_files = len(self.repo.get_tracked_files())
                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "repo.py", line 258, in get_tracked_files
    for blob in commit.tree.traverse():
  File "util.py", line 575, in _traverse
    addToStack(stack, item, branch_first, nd)
  File "util.py", line 535, in addToStack
    lst = self._get_intermediate_items(item)
          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "tree.py", line 207, in _get_intermediate_items
    return tuple(index_object._iter_convert_to_object(index_object._cache))
                                                      ^^^^^^^^^^^^^^^^^^^
  File "util.py", line 253, in __getattr__
    self._set_cache_(attr)
  File "tree.py", line 214, in _set_cache_
    self._cache: List[TreeCacheTup] = tree_entries_from_data(ostream.read())
                                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "fun.py", line 98, in tree_entries_from_data
    while data[i] != space_ord:
          ~~~~^^^
IndexError: index out of range

Thanks for trying aider and filing this issue.
The fix is available in the main branch. You can get it by installing the latest version from github:
aider --install-main-branch

# or...

python -m pip install --upgrade git+https://github.com/paul-gauthier/aider.git

If you have a chance to try it, let me know if it works better for you.


Replace usage of Material UI and Grommet

[ ] Replace any usage of Material UI icons with the icons provided on Figma (instructions in README).
[ ] Replace any usage of Material UI fonts and with the current fonts used.
[ ] Replace any usage of Grommet components with styled-components or antd components.

I think I've already removed Grommet in a previous issue, might have been reverted by some other merge, Quick search just shows entry in package.json https://github.com/FightPandemics/FightPandemics/search?q=grommet&unscoped_q=grommet

I think I've already removed Grommet in a previous issue, might have been reverted by some other merge, Quick search just shows entry in package.json https://github.com/FightPandemics/FightPandemics/search?q=grommet&unscoped_q=grommet

Hmm interesting.. Looks there are some Grommet remains in the code base right now:

The Grommet icons in the current code base are being commented so they are not in use @anniegiang


How to require and validate user profile fields?

Unlike the OP in #467, my use case actually requires the user to specify a first and last name. I understand that with email sign-in (and most of the other sign in methods), the user's displayName is enabled by default (looks like since v3.2). However, most providers (Gmail, Twitter, etc) don't require their users to have a particular name format, so parsing the displayName by splitting on space, etc doesn't seem like a robust way to gather and validate the user's names.
Is there a way to do this with Firebase (or FirebaseUI), or must I implement my own custom views to request and validate the user input?

@kiptoomm we don't have anything in FirebaseUI to make sure that the profiles from social providers are filled out.  So yes you'd have to build this yourself.
One of the features we've had on the roadmap since forever is to build in an account management UI:
https://github.com/firebase/FirebaseUI-Android/issues/235
So I think if this request ever gets done, it will be part of that effort.  Thanks for the suggestion!


Carthage Support?

Im really excited for this repo, but I am wondering if there will be Carthage support anytime soon?

+1

If you know how to implement it feel free to do it and send a pull request. If not I'll check it out, probably this weekend.

Guys I pushed the commit by @bcylin , it works fine with me. Please try it out and see if there are any problems
https://github.com/goktugyil/EZSwiftExtensions/pull/9

Yea worked for me! 👍🏼


[test-triage] chip_sw_otbn_mem_scramble

Hierarchy of regression failure
Chip Level
Failure Description
Test chip_sw_otbn_mem_scramble has 3 failures.

0.chip_sw_otbn_mem_scramble.71168331
Line 489, in log /container/opentitan-public/scratch/os_regression/chip_earlgrey_asic-sim-vcs/0.chip_sw_otbn_mem_scramble/latest/run.log

      Offending 'alert_tx_o[2].alert_p'
  UVM_ERROR @ 3845.293040 us: (rv_core_ibex.sv:989) [ASSERT FAILED] FpvSecCmIbexLoadRespIntgErrCheck_A
  UVM_INFO @ 3845.293040 us: (uvm_report_catcher.svh:705) [UVM/REPORT/CATCHER]
  --- UVM Report catcher Summary ---

1.chip_sw_otbn_mem_scramble.575997993
Line 485, in log /container/opentitan-public/scratch/os_regression/chip_earlgrey_asic-sim-vcs/1.chip_sw_otbn_mem_scramble/latest/run.log

      Offending 'alert_tx_o[2].alert_p'
  UVM_ERROR @ 3499.178950 us: (rv_core_ibex.sv:989) [ASSERT FAILED] FpvSecCmIbexLoadRespIntgErrCheck_A
  UVM_INFO @ 3499.178950 us: (uvm_report_catcher.svh:705) [UVM/REPORT/CATCHER]
  --- UVM Report catcher Summary ---

... and 1 more failures.

Steps to Reproduce

GitHub Revision: feb3d3a15
dvsim invocation command to reproduce the failure, inclusive of build and run seeds:
./util/dvsim/dvsim.py hw/top_earlgrey/dv/chip_sim_cfg.hjson -i chip_sw_otbn_mem_scramble --build-seed<PHONE_NUMBER> --fixed-seed 71168331 --waves fsdb

Tests with similar or related failures

[ ] chip_sw_otbn_mem_scramble
[ ] chip_sw_otp_ctrl_keys
[ ] chip_sw_otp_ctrl_entropy

There is potentially related working going on in https://github.com/lowRISC/opentitan/issues/16416 that may have affected this.
Flagging for awareness and highlighting degradation in a previously passing test.

Tests
2022-11-16 08:14:00
2022-11-15 08:11:58
2022-11-14 08:10:42
2022-11-13 08:12:54
2022-11-12 08:04:45
2022-11-11 08:07:48
2022-11-10 08:10:06
2022-11-09 08:04:06
2022-11-08 08:03:42
2022-11-07 08:08:10
2022-11-06 07:11:02
2022-11-05 07:11:23
2022-11-04 07:12:05
2022-11-03 07:11:23
Suite

127
chip_sw_otbn_mem_scramble
0
100
100
100
100
100
100
100
100
100
100
100
100
100
chip_sw_otbn_mem_scramble, chip_sw_otp_ctrl_keys, chip_sw_otp_ctrl_entropy

Different error to that highlighted in https://github.com//lowRISC/opentitan/issues/16416

Looks like this issue duplicates https://github.com/lowRISC/opentitan/issues/16416
Same
Offending 'alert_tx_o[2].alert_p'

error. Closing as duplicated.


Replace cppnetlib with Oat++

Unfortunately, cppnetlib is a poor choice for a web server:

Does not support Boost >= 1.70
Does not support C++ standards >= 17
Does not support websockets
Is no longer being developed
Has no package on Conan Center

Some of these issues, especially the top two, are increasingly making development with and on Cloe difficult.
After a survey of the different C++ network libraries I settled on Oat++ as probably the best candidate for our use. This PR reflects the minimum amount of changes required to integrate Oat++. A redesign of the server architecture may be warranted in the future, but right now we just need to unblock development without completely invalidating the Web UI.

Rebased on master to remove ubuntu-18.04 runner from build. Otherwise no changes.


Import Taproot Wallet

Task Description
Given that we now support Taproot, we should give user an option to import their Taproot wallet.

Verified this issue on dev app v 1.1.14(317)


note mapping of OriginalFile.repo property

https://github.com/openmicroscopy/openmicroscopy/pull/5054/commits/2e1c7828455440016fad5411deac3101e09bb2f2 maps the OriginalFile.repo property into the OMERO object model so there should be a corresponding update at http://www.openmicroscopy.org/site/support/omero5.3-staging/developers/Model/EveryObject.html#originalfile.

@mtbc sorry I missed the change when I prepared m8

No problem: the PRs that introduce it aren't yet merged to mainline anyway which is why I've yet to list this PR for review.

Not for 5.3.

If we're making a space, then the target branch for all of the related PRs can be switched from "develop" to "newrole" (or similar).

Looks like we still need to open new PRs to achieve that, bah.

When I click "Edit" beside the title of the PR, I can change the target branch.

Thank you, great tip! I thought that the "Edit" beside the title was only for editing the title. (!)

Do we need a separate branch on the docs or can this just have an 'on-hold' label and not be merged into develop until the code branch is rebased? Are we likely to have conflict with other 5.3 updates? Because if not, it'd be easier docs-side to just have this on develop.

Probably no conflict. On-hold on develop is fine.

I'll leave you to reopen when you're ready then.

Happy to rebase this too if we find we need to move https://github.com/openmicroscopy/ome-documentation/pull/1617 or something.

Because if not, it'd be easier docs-side to just have this on develop.

For this change, that's true, @hflynn. But getting the sum of the docs in that Petr et al are proposing could likely profit from having a proper merge build with link checks in place before time for 5.4.

I'd assumed this was for 5.3.x until further discussion with JM, if the target is actually 5.4.0 then yes, a new docs branch will be needed, although presumably it's more likely we'll branch off a dev_5_3 and keep the latest work on develop?

Apparently develop is now 5.4.x.

builds and reads OK
Ready to merge FMPOV


[FEATURE] Update Workflow API

Is your feature request related to a problem?
Coming from here.
Currently we have a basic update functionality where we update the entire doc in the global-context index and workflow-state index whenever an update is made. However this doesn't take into account a few things. If we are updating while provisioning is going on we will have to potentially rollback the current steps that were executed. Another caveat is that if provisioning is already done, and users just want to update the query flow for example we probably don't want to create a whole new doc and rollback.
Update failures also are currently a little tricky right now.  If we fail to update the state doc for whatever reason, the information regarding provisioning time and more could be wrong here but the global context doc will be updates causes the two not to be synced. In AD when we update a detector for example we need to stop the task beforehand anyways for example so the task is anyways gone before we update. Maybe we should do something similar for us too where we stop the workflow before updating and then that means we either reset or state document there or we delete it completely. When we update and restart the workflow we can create a new state document after handling any failures in stopping.
What solution would you like?
t?

@amitgalitz can you verify if this is addressed in https://github.com/opensearch-project/flow-framework/pull/416?

@amitgalitz can you verify if this is addressed in #416?

#416 addresses some of the issue by only allowing updates on non-provisioned workflows. However I think we should continue to aim for an update API that can do more than then. Not sure if 2.13 or even later. Think its still good to call this out as future enhancement, I will update title to reflect that unless you think what we have is good enough for long term.

Will be addressed with issue: #526


protocol/mdns: Use SO_REUSEPORT for the mDNS socket

On macOS, failure to use SO_REUSEPORT would result in mDNS not being able to bind to the socket, causing Litep2p::new() to exit with EADDRINUSE.

On macOS, failure to use SO_REUSEPORT would result in mDNS not being able to bind to the socket, causing Litep2p::new() to exit with EADDRINUSE.

Is there an explanation for macOS behaving this way?

On macOS, failure to use SO_REUSEPORT would result in mDNS not being able to bind to the socket, causing Litep2p::new() to exit with EADDRINUSE.

Is there an explanation for macOS behaving this way?

This is the best reference I could find after a quick search. Looks like there are subtle differences between the operating systems which makes mDNS work on Linux despite not enabling SO_REUSEPORT


Unit test generated by RoostGPT

Please pull these awesome changes in!
Test Name - openAIConnector
AI Type   - Open AI
AI Model  - gpt-4-1106-preview
Test Type - Unit test
Use Type  - ui
Test Framework - jest

Access Logs At - https://dev.roost.ai/roostgpt/logs?trigger_id=a28cacc3-bee2-462f-9ece-387eb57df9bd

`● Validation Error:
Test environment jest-environment-jsdom cannot be found. Make sure the testEnvironment configuration option points to an existing node module.
Configuration Documentation:
https://jestjs.io/docs/configuration
As of Jest 28 "jest-environment-jsdom" is no longer shipped by default, make sure to install it separately`

 Cannot find module 'babel-plugin-styled-components' from 'C:\Users\amank\Birthday-Wisher'


shell: directive is buggy...

I've been trying to get alacritty to run many different programs and most (all?) have some buggy behavior. Here's what the relevant section of the config:
shell: /home/manny/bin/alacrity-shell

(it'd be great for alacrity to expand ~ here)
And the contents of alacrity-shell have been trying to start tmux, nvim (with term://$SHELL), and $SHELL to some sort of woe. The worst has been nvim which for some reason can sometimes lock up my system quite badly.
I'll be calling alacritty from pangoterm for all the examples.
First up is tmux. I have my tmux.conf setup to create a new session so that alacritty-shell can just be tmux attach
❯ cat bin/alacritty-shell
#!/usr/bin/env bash

tmux attach -t default
#zsh --login -i
#$SHELL --login -i
#nvim term://zsh

new-session -s default
set -g prefix C-s
unbind C-b
...

❯ killall tmux
tmux: no process found

~
❯ alacritty
device_pixel_ratio: 1
width: 1144, height: 1394
Initializing glyph cache
num fonts = 244
num fonts = 244
num fonts = 244
Finished initializing glyph cache in 0.071625394
set_inner_size: 804px × 436px
width: 804, height: 436
Cell Size: (10 x 18)
PTY Dimensions: Line(24) x Column(80)
num_cols, num_lines = 114, 77
width: 1144, height: 1394
[unhandled] esc_dispatch params=[], ints=[40], byte='B' (42)
[Unhandled CSI] action='l', args=[1005], intermediates=[63]
[unhandled osc_start]
[unhandled osc_put] byte='1'
[unhandled osc_put] byte='1'
[unhandled osc_put] byte='2'
[unhandled osc_end] byte=0
[unhandled] esc_dispatch params=[], ints=[40], byte='B' (42)
[unhandled] esc_dispatch params=[], ints=[40], byte='B' (42)
[unhandled] esc_dispatch params=[], ints=[40], byte='B' (42)
[unhandled osc_start]
[unhandled osc_put] byte='1'
[unhandled osc_put] byte='1'
[unhandled osc_put] byte='2'
[unhandled osc_end] byte=0
[Unhandled CSI] action='l', args=[1005], intermediates=[63]
thread 'pty reader' panicked at 'unexpected read err: Error { repr: Os { code: 5, message: "Input/output error" }
}', src/event_loop.rs:227
note: Run with `RUST_BACKTRACE=1` for a backtrace.
Goodbye

~
❯ bin/alacritty-shell
[exited]

so alacritty exits/fails, but when I called alacritty-shell manually I was able to exit cleanly. Now, if I run tmux and detach, alacritty works just fine.
~
❯ bin/alacritty-shell
[detached (from session default)]

~ 1529ms
❯ alacritty
device_pixel_ratio: 1
width: 1144, height: 1394
Initializing glyph cache
num fonts = 244
num fonts = 244
num fonts = 244
Finished initializing glyph cache in 0.072823565
set_inner_size: 804px × 436px
width: 804, height: 436
Cell Size: (10 x 18)
PTY Dimensions: Line(24) x Column(80)
num_cols, num_lines = 114, 77
width: 1144, height: 1394
[unhandled] esc_dispatch params=[], ints=[40], byte='B' (42)
[Unhandled CSI] action='l', args=[1005], intermediates=[63]
[unhandled osc_start]
[unhandled osc_put] byte='1'
[unhandled osc_put] byte='1'
[unhandled osc_put] byte='2'
[unhandled osc_end] byte=0
[unhandled] esc_dispatch params=[], ints=[40], byte='B' (42)
[unhandled] esc_dispatch params=[], ints=[40], byte='B' (42)
[unhandled] esc_dispatch params=[], ints=[40], byte='B' (42)
[unhandled] esc_dispatch params=[], ints=[40], byte='B' (42)
[unhandled] esc_dispatch params=[], ints=[40], byte='B' (42)
[unhandled] esc_dispatch params=[], ints=[40], byte='B' (42)
[unhandled] esc_dispatch params=[], ints=[40], byte='B' (42)
[unhandled] esc_dispatch params=[], ints=[40], byte='B' (42)
[unhandled] esc_dispatch params=[], ints=[40], byte='B' (42)
[unhandled] esc_dispatch params=[], ints=[40], byte='B' (42)
[unhandled] esc_dispatch params=[], ints=[40], byte='B' (42)
[unhandled osc_start]
[unhandled osc_put] byte='1'
[unhandled osc_put] byte='1'
[unhandled osc_put] byte='2'
[unhandled osc_end] byte=0
[Unhandled CSI] action='l', args=[1005], intermediates=[63]
Goodbye

I'm having a worse time with nvim (my preferred multiplexer), but figured I'd go with tmux since that should work only to find this situation.
When I try with the nvim line I get:
❯ alacritty
device_pixel_ratio: 1
width: 1144, height: 1394
Initializing glyph cache
num fonts = 244
num fonts = 244
num fonts = 244
Finished initializing glyph cache in 0.072128687
set_inner_size: 804px × 436px
width: 804, height: 436
Cell Size: (10 x 18)
PTY Dimensions: Line(24) x Column(80)
num_cols, num_lines = 114, 77
width: 1144, height: 1394
[Unhandled CSI] action='h', args=[1004], intermediates=[63]
[Unhandled CSI] action='t', args=[8, 77, 114], intermediates=[]
[unhandled] esc_dispatch params=[], ints=[40], byte='B' (42)
^C

So I just noticed that alacritty sets $SHELL with whatever is in the shell:  directive and that's what was messing up my $SHELL --login -i attempt along with my (not shown here) nvim term://$SHELL. I don't think alacritty should be setting the $SHELL var...
For the $SHELL --login -i case bash comes back with a recursion error message:
bash : warning: shell level (1000) too high, resetting to 1
bash : warning: shell level (1000) too high, resetting to 1
bash : warning: shell level (1000) too high, resetting to 1
...

so looks like 2 possibly 3 bugs...
$SHELL
plain nvim term://zsh
and w/e is going on with tmux...
Should I create separate issues?

I think just having the one issue is fine. We can fix all of these problems at once.
I don't quite understand the 2nd/3rd bugs - it sounds like not setting $SHELL may fix everything?

not setting shell should fix the case of when $SHELL is used within shell binary/script. My original file had
nvim term://$SHELL

and that was horrible, probably because of the interaction of $SHELL and nvim.
nvim term://zsh

still does not work but it may be due to something in neovim reading $SHELL internally (I'll check my nvimrc file and see if I can find anything in nvim docs or code)
Thanks for alacritty btw this looks great!

I think this should be fixed since 5b079f6d437c567a1533a719194f6e579a7eedae

Agree @NickeZ; thanks!


syntax error: operand expected (error token is ".")

Sorry for reporting this here but there is no other way to reach out to the scala team (support ticket) as I have a free heroku app
scala sbt builds on jdk11 hit this bug
https://github.com/paulp/sbt-extras/issues/212
see also https://github.com/sbt/sbt/issues/5342
So I guess Heroku should update it's scala pipeline to use the new sbt-extras?

Hello @francisdb!
Thank you for researching this and bringing this to our attention! This will be fixed soon, see https://github.com/heroku/heroku-buildpack-scala/pull/144

Great, thanks


fix: tooltips on X11/Sway not working after moving a split

This needs testing on all platforms
Fixes #5432
Fixes #5521

What I need tested:

Do tooltips work (not the bounds checking) before & after moving a split?
Does the Input Completion Popup work (not the bounds checking) before & after moving a split?
Does the Search popup work (i.e. not closing or being moved into the split somehow) before & after moving a split?

https://github.com/user-attachments/assets/16aa4154-80aa-40e0-9655-df68f588daab
Works on Windows.

Works as expected on my mac mini (except the search popup X button randomly closed the entire app without it being a crash - it happened 3 times then never again. I think there's a fairy somewhere in my macmini that caused it to do that to make me go insane)
Works as expected on X11 with i3. The only weird thing is that when I move the split, it moves up & to the left by ~1 pixel.


[SPARK-38419][SQL] change spark.sessionstate.conf.getConf/setConf operation to spark.conf.get/set

Why are the changes needed?
In the sql module, we provide SparkSession.conf as a unified entry for SQLConf.set/get, which can prevent users or logic from modifying StaticSQLConf and Spark configs. However, I found SparkSession.sessionstate.conf is used in some code to getConf or setConf, which can skip the check of RuntimeConfig.
In this PR, we want to unify the behavior of SQLConf.getConf/setConf to SparkSession.conf.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Origin GA

cc @srowen @cloud-fan @HyukjinKwon

I don't know this part well, but it seems reasonable to unify the checks here

Can one of the admins verify this patch?

@cloud-fan @HyukjinKwon Any more question about this pr?
BTW, can we remove the AmplabJenkins report Since we won't use Jenkins any more?

cc @srowen @cloud-fan @HyukjinKwon

thanks, merging to master!

@jackylee-ch seems you link to the wrong JIRA ticket?

@jackylee-ch seems you link to the wrong JIRA ticket?

This is a minor change, thus I didn't create a JIRA for it.

At least we shouldn't link to an unrelated JIRA... Please create a new one for this PR as it's not a minor one-line change.

At least we shouldn't link to an unrelated JIRA... Please create a new one for this PR as it's not a minor one-line change.

Sorry, I will create one inmediatly.

https://issues.apache.org/jira/browse/SPARK-38713
This is the new Created Jira. @cloud-fan


Properly sort consul configuration

Simple sort compare key & values. It fails for hash values.
For instance:
{:data_dir=>"/var/lib/consul",
 :client_addr=>"<IP_ADDRESS>",
 :ports=>{"dns"=>-1, "http"=>8500, "rpc"=>8400, "serf_lan"=>8301, "serf_wan"=>8302, "server"=>8300},
 :enable_syslog=>false,
 :retry_join=>["consul01-par.kitchen"],
 :node_name=>"ip-10-0-64-236.us-west-2.compute.internal",
 :server=>false,
 :datacenter=>"par",
 :domain=>"consul",
 :addresses=>{"http"=>"<IP_ADDRESS>"},
 :acl_datacenter=>"par",
 :disable_update_check=>true,
 :leave_on_terminate=>false,
 :advertise_addr=>"<IP_ADDRESS>",
 :encrypt=>"/AKlGGZMMSUsJLit/+etBw==",
 :verify_incoming=>false,
 :verify_outgoing=>false,
 "node_meta"=>{"rack"=>nil}}

will raise ArgumentError: comparison of Array with Array failed.
Sorting by keys is sufficient
Fix #410
Change-Id: Ieaf05a019c4d636ae8457046ee4e3bf8f697296a

I've fixed tests

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@3cbc7ab). Click here to learn what that means.

@@            Coverage Diff            @@
##             master     #411   +/-   ##
=========================================
  Coverage          ?   55.13%
=========================================
  Files             ?        7
  Lines             ?      341
  Branches          ?        0
=========================================
  Hits              ?      188
  Misses            ?      153
  Partials          ?        0

Impacted Files
Coverage Δ

libraries/consul_config.rb
76.52% <ø> (ø)

libraries/helpers.rb
48.64% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3cbc7ab...f478d74. Read the comment docs.

tests are really flaky, I'll try to make them pass but they should be corrected.

@kamaradclimber I've just tried to rebase your branch onto current master state to get everything fixed. Don't you mind I finish it and merge this PR then?

go ahead @legal90. I was quite suprised my branch has been rebased actually :)
Thanks for your help

Thank you for the contribution!


On-premise Install Failing

On-premise install is failing.  I have checked with our network team to confirm nothing is being blocked.  I am looking for the download link for the VSIX to download upload the extension as suggested in Issue #177, but can't find that.  Please help.

@bmaster this seems an issue with VS Marketplace itself. Our AzDevOps task extension still has the same metadata as before, still allowing for separate download.
I can partially repro that red error box when I select an AzDevOps where I have no admin rights. But at least, the button still appears:

What I can offer is a workaround: starting with the August refresh 2.0.7 that was published to VS Marketplace earlier today, I'm also publishing the .vsix as a GH release, with the .vsix attached as asset:
https://github.com/microsoft/powerplatform-build-tools/releases/
CC: @kkanakas


Kindly request for inclusion of a new MIA paper

Found a new paper on MIA that achieves current SOTA performance. Please consider adding it to the section "membership inference attack".
Link of the paper: https://arxiv.org/abs/2409.03363

Thank you! The paper was added.


[Question]: What is the custom tokenizer used for ?

Describe your problem
I'm pretty new to AI so this question might stem from a simple misunderstanding, but AFAIK, embedding models can only be used in conjunction with the tokenizer they were trained with (i.e. tiktoken for ChatGPT4o, SentencePiece for LLama, etc).
With that in mind, what is the use of this project tokenizer since the output is going to go through the embedding model tokenizer anyway ? From a few tests, it seems it would actually even remove some details before feeding the content to the embedding model

This tokenizer is for search engine to build reverted index. RAGFlow primarily uses keywords to do retrieval.


Add ModernFlyouts as a Power toy

📝 Provide a description of the new feature
https://github.com/ModernFlyouts-Community/ModernFlyouts
If you'd like to see this feature implemented, add a 👍 reaction to this post.

Duplicate of  #6273


words_alpha has dashes (-)

jean-christophe
jean-pierre

@HarshaLaxman occasionally people spell these names with the dash. 🙄
see: https://en.wikipedia.org/wiki/Jean-Christophe_(given_name) and https://en.wikipedia.org/wiki/Jean-Pierre_(given_name)
👍

@nelsonic
That is great, I love unique names, but they don't belong in this list unless I am misunderstanding [[:alpha:]]
https://www.hscripts.com/tutorials/regular-expression/character-classes/alpha.php

@HarshaLaxman the question of whether "proper" name should be in the dictionary,
is not one I'm qualified to answer.
If you want to submit a Pull Request to remove them, we will accept it. 👍

There are 41,733 strings in words.txt where a hyphen is embedded among letters (i.e. has only letters and hyphens, and begins and ends with letters). Of those, 38,570 have no capital letters -- that doesn't mean they aren't proper nouns, but most proper English nouns are capitalized, so it suggests that there are tens of thousands of legitimately hyphenated strings. Some examples:

anti-emetic
bilge-water
coarse-grained
dead-center
electro-osmotically
yellow-tipped

Perhaps "dead-center" shouldn't be counted as a word, because both "dead" and "center" are words and are already listed. What about "anti-emetic" and "electro-osmotically"?


[FRE-1314] fix: filter available wallets in RenderWalletList component

also found some unnecessary hook deps

Not working for solana wallets

This is as intended if only one wallet option is available then we should all available options. I could refine the code so this is only the case with walletconnect and not any length === 1 available wallet list. Its a design question if we're ok with this modal having just a single option.

Ok nice, lgtm if the hook deps fixed


Task/TUI-3 - Add UIPatterns and associated components

Overview:
Dropped in UIPatterns, but needs to be pared back if possible.
PR Status:

[ ] Ready.
[X] Work in Progress.
[ ] Hold.

UI Photos:

The linting and unit tests pass locally, but do not seem to pass in the repo. Still need to figure out a couple more formatting issues with the sidebar navigation.


Prevention of duplication of apps

There should be a dialog box alert that pops up when a user creates a new app before completing the older one. It should say:
"Alert! You already have one application  in process. Are you sure you want to create another one?"
The options should be "Yes" or "No"

@prajectory @PelinSmines I will reach out re this issue and #30 to define some details of this enhancement


Updated to clarify SSO and WPJ

Updated to clarify SSO only occurs if the user has WPJed their device.

Microsoft authors of articles need to make updates through the private repository so the updates can be staged and validated by the current validation rules. After you review staging and fix all validation issues, you can add the sign-off comment to let the PR reviewers know the updates are ready to be merged.It's easy to access the private repo version of your articles in GitHub. Just add -pr to the URL, as follows:
Public repo URL: https://github.com/Microsoft/azure-docs/blob/master/articles/azure-portal-overview.md
Private repo URL: https://github.com/Microsoft/azure-docs-pr/blob/master/articles/azure-portal-overview.md
We have closed this pull request. Please resubmit the updates through the private repo. If you need perms to the private repo, see the contributor guide instructions


map2model Stratigraphy/igneous contacts wrongly called intrusive

map2model igneous/strat contacts need to be coded as strat if igneous is older than strat unit.

fixed in latest version (20/6/2020)


CI: "spec test on nuttx" riscv job is failing frequently

it's often "const" of "call_indirect" test failing it seems. but it doesn't seem very consistent.
failure logs i looked at were all ILP32F.
https://github.com/bytecodealliance/wasm-micro-runtime/actions/runs/10764321632/job/29847058408
============> run const failed with a non-zero return code 101

Running: /__w/wasm-micro-runtime/wasm-micro-runtime/apps/interpreters/wamr/wamr/tests/wamr-test-suites/workspace/../../../wamr-compiler/build/wamrc --target=riscv32 --target-abi=ilp32f --cpu=generic-rv32 --cpu-features=+m,+a,+c,+f --disable-simd --disable-llvm-lto --bounds-checks=1 -o /tmp/tmppauwm0qx.aot /tmp/tmpp6zgci1d.wasm
Started with:
Create AoT compiler with:
  target:        riscv32
  target cpu:    generic-rv32
  target triple: riscv32-pc-linux-ilp32f
  cpu features:  +m,+a,+c,+f
  opt level:     3
  size level:    3
  output format: AoT file

Starting interpreter for module '/tmp/tmppauwm0qx.aot'
Running: qemu-system-riscv32 -semihosting -M virt,aclint=on -cpu rv32 -smp 1 -nographic -bios none -kernel /__w/wasm-micro-runtime/wasm-micro-runtime/nuttx/nuttx
Started with:
iwasm --heap-size=0 --repl --stack-size=1 /tmp/tmppauwm0qx.aot

Testing(return) f  = -1.797693e+308:f64
THE FINAL EXCEPTION IS Failed:
 Result 0 incorrect:
 expected: '-1.797693e+308:f64'
  got: '-inf:f64'

https://github.com/bytecodealliance/wasm-micro-runtime/actions/runs/10755545345/job/29827427650
============> run call_indirect failed with a non-zero return code 101

https://github.com/bytecodealliance/wasm-micro-runtime/actions/runs/10746972440/job/29808995646
============> run call_indirect failed with a non-zero return code 101

https://github.com/bytecodealliance/wasm-micro-runtime/actions/runs/10730191223/job/29758313644
============> run call_indirect failed with a non-zero return code 101

https://github.com/bytecodealliance/wasm-micro-runtime/actions/runs/10711568587/job/29710199664
============> run call_indirect failed with a non-zero return code 101

https://github.com/bytecodealliance/wasm-micro-runtime/actions/runs/10692765583/job/29641885907
============> run call_indirect failed with a non-zero return code 101

@no1wudi any idea?

I though @wenyongh is working on it too. https://github.com/bytecodealliance/wasm-micro-runtime/pull/3771

I have no good idea yet, at first I think it may be caused by the timeout to wait for compiling wasm to aot is a little small, but it doesn't work even when I increases it. And it may report several errors:
(1) THE FINAL EXCEPTION IS compile wasm to aot failed
(2) THE FINAL EXCEPTION IS argument of type 'NoneType' is not iterable
(3)
Testing(return) f  = -1.797693e+308:f64
THE FINAL EXCEPTION IS Failed:
Result 0 incorrect:
expected: '-1.797693e+308:f64'
got: '-inf:f64'
It fails frequently, I have to re-run it manually many times.

🤔 I am thinking about "sequential" instead of "parallel" by removing -P from https://github.com/bytecodealliance/wasm-micro-runtime/actions/runs/10764321632/workflow#L333

🤔 I am thinking about "sequential" instead of "parallel" by removing -P from https://github.com/bytecodealliance/wasm-micro-runtime/actions/runs/10764321632/workflow#L333

Shutting down parallel testing may reduce or even prevent the problem from continuing to occur, but it may lead to excessively long testing times; perhaps we can give it a try.

Speed of "sequential" test seems acceptable: #3780
Maybe we can try it fist
@wenyongh @lum1n0us @yamt

it's still failing.
https://github.com/bytecodealliance/wasm-micro-runtime/actions/runs/10775274630/job/29879549182

It's more like an issue related to riscv32_ilp32f, the CI ran failed most on config "riscv32_ilp32f, fp, -t aot -X" and "riscv32_ilp32f, fp, -t aot":
https://github.com/bytecodealliance/wasm-micro-runtime/actions/runs/10775274630/job/29906929175#step:25:7726
https://github.com/bytecodealliance/wasm-micro-runtime/actions/runs/10775274630/job/29906623580
https://github.com/bytecodealliance/wasm-micro-runtime/actions/runs/10783438239/job/29906934331
https://github.com/bytecodealliance/wasm-micro-runtime/actions/runs/10783852668/job/29906610576
https://github.com/bytecodealliance/wasm-micro-runtime/actions/runs/10784036686/job/29907065645

How about re-opening #3777 and merging it?

I agree. It has blocked several PRs.

How about re-opening #3777 and merging it?

re-opened and rebased.

It's more like an issue related to riscv32_ilp32f, the CI ran failed most on config "riscv32_ilp32f, fp, -t aot -X" and "riscv32_ilp32f, fp, -t aot": https://github.com/bytecodealliance/wasm-micro-runtime/actions/runs/10775274630/job/29906929175#step:25:7726 https://github.com/bytecodealliance/wasm-micro-runtime/actions/runs/10775274630/job/29906623580 https://github.com/bytecodealliance/wasm-micro-runtime/actions/runs/10783438239/job/29906934331 https://github.com/bytecodealliance/wasm-micro-runtime/actions/runs/10783852668/job/29906610576 https://github.com/bytecodealliance/wasm-micro-runtime/actions/runs/10784036686/job/29907065645

at least riscv64 was failing with similar symptoms too.
i agree riscv32_ilp32f was failing more frequently though.


Yarn deploy is failing

Hi everyone, I am just getting started with scaffold-eth but I have some problems with the installation, I am following the quickstart steps but my yarn deploy is failing:

Did anyone have a similar issue before?
Thanks!

To clarify, both the others steps work fine and I can access the localhost

I experienced a different error while deploying the contract. I tried running the command with sudo and it deployed successfully.
sudo yarn deploy

Wanted to chime in that this is happening for me as well. Running the command with sudo has no effect on my end. Still receive the Error HH108: Cannot connect to the network localhost. Please make sure your node is running, and check your internet connection and networks config error.
I'm able to get around it by running node v16 in this window (I'm using n to easily switch node versions) but having to juggle node versions is a pain because start doesn't work with n16 due to the --openssl-legacy-provider flag.
My current flow to get this working across 3 terminal windows:
window 1:
n 18
yarn install
yarn chain

window 2:
n 18
yarn start

window 3:
n 16
yarn deploy

Would be great to be able to just set-and-forget node v18. Would love to hear if anyone is able to get the deploy command working on v18.

For me, the scripts in packages/hardhat/packages.json were creating a network named hardhat, but in packages/hardhat/hardhat.config.js the defaultNetwork variable was localhost. I changed localhost to hardhat in hardhat config and that seemed to work. I then got an error that packages/hardhat/deployements directory did not exist, so I created and I can now see my contract on the frontend.

Notice -- network hardhat throughout these scripts

But here defaultNetwork variable was localhost - I think it should be hardhat

And then I created this deployments folder after the CLI yelled at me for not having it

I still just see this on the frontend, though, so maybe more needs to be done

Actually, looking at App.jsx, the frontend doesn't appear to be built to display any custom contracts you write, so maybe thats doing exactly what it's supposed to

The fix for this is to change the address in hardhat.config.js for localhost to <IP_ADDRESS>
See
https://github.com/scaffold-eth/scaffold-eth/pull/950/commits/bea2a492f5c4221cb2545b9907404a65d0f3459d


[incubator/jaeger] Adding agent sidecar for query and OWNERS file

What this PR does / why we need it:

Adding OWNERS file as this is needed
Adding an optional agent sidecar for query as per https://github.com/jaegertracing/jaeger-kubernetes/issues/112#issuecomment-458042080

Which issue this PR fixes
(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)

fixes #

Special notes for your reviewer:
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

[x] DCO signed
[x] Chart Version bumped
[x] Variables are documented in the README.md
[x] title of the PR contains starts with chart name e.g. [stable/chart]

bump

/assign
/ok-to-test
please add yourselves to the Chart.yaml file as well :)

/lgtm
thanks and good luck!

Thanks @maorfr !


Locate the location of the source file according to node_info

If my source file is a pdf, how should I locate the page and line of the source file according to node_info={'start':32444,'end':33918}.

Hi @mingxin-yang,  I believe the node_info shows the start and end position in terms of character count.
So yes, it's currently difficult to locate the page and line of the source file.
We hope to add better source referencing, but probably won't get to it soon.
If you have ideas on how to make this better, feel free to open a PR to help the community!


Issue with extra_views for InlineFormSet

I am using extra_views in conjunction with floppyform forms.
import floppyforms.__future__ as forms

class QuoteItemForm(forms.ModelForm):
    class Meta:
        model = QuoteItem
        fields = ['section_number', 'section_description', 'variation', 'bar_description', 'length', 'nos_in_1', 'multiplier', 'supply_price_rate', 'placing_price_rate']

    supply_price_rate = forms.DecimalField(widget=forms.widgets.Input(attrs={'size': 10}), required=False)
    placing_price_rate = forms.DecimalField(widget=forms.widgets.Input(attrs={'size': 10}), required=False)

class QuoteItemInline(InlineFormSet):
    model = QuoteItem
    form_class = QuoteItemForm

class UpdateSheet(LoginRequiredMixin, UpdateWithInlinesView):
    model = Sheet
    form_class = SheetUpdateForm
    template_name = 'quotations/sheets/update.html'
    slug_url_kwarg = 'sheet_uuid'
    slug_field = 'uuid'
    inlines = [QuoteItemInline]

So this generates the inline forms, but the extra empty forms will have the html5 attribute "required" added to required fields. This results empty inline forms cannot be saved.
To solve this issue, I just needed to change from
class QuoteItemForm(forms.ModelForm):

to
from django import forms as django_forms
class QuoteItemForm(django_forms.ModelForm):

This looks like the ModelForm from floppyform package is not doing exactly the same stuff as the vanila django ModelForm.

Hi. Yes, floppyforms behaves different there as it wants to output HTML5 forms in all it's facets. The differences are documented here: http://django-floppyforms.readthedocs.org/en/latest/differences.html?highlight=novalidate
Please make sure to read the section about novalidate to see how you can avoid the client side (in-browser) validation.


Catch all exceptions thrown while sending an event

This fixes an issue if Sentry replies with 429 error code that we no longer throw an exception.
PHP Fatal error:  Uncaught Http\Client\Common\Exception\ClientErrorException: TOO MANY REQUESTS in /Users/haza/Projects/demo-projects/php/demo-php/vendor/php-http/client-common/src/Plugin/ErrorPlugin.php:83
Stack trace:
#0 /Users/haza/Projects/demo-projects/php/demo-php/vendor/php-http/client-common/src/Plugin/ErrorPlugin.php(65): Http\Client\Common\Plugin\ErrorPlugin->transformResponseToException(Object(GuzzleHttp\Psr7\Request), Object(Zend\Diactoros\Response))
#1 [internal function]: Http\Client\Common\Plugin\ErrorPlugin->Http\Client\Common\Plugin\{closure}(Object(Zend\Diactoros\Response))
#2 /Users/haza/Projects/demo-projects/php/demo-php/vendor/php-http/curl-client/src/PromiseCore.php(215): call_user_func(Object(Closure), Object(Zend\Diactoros\Response))
#3 /Users/haza/Projects/demo-projects/php/demo-php/vendor/php-http/curl-client/src/MultiRunner.php(99): Http\Client\Curl\PromiseCore->fulfill()
#4 /Users/haza/Projects/demo-projects/php/demo-php/vendor/php-http/curl-client/src/CurlPromise.php(99): Http\Client\Curl\MultiRun in /Users/haza/Projects/demo-projects/php/demo-php/vendor/php-http/client-common/src/Plugin/ErrorPlugin.php on line 83

Fatal error: Uncaught Http\Client\Common\Exception\ClientErrorException: TOO MANY REQUESTS in /Users/haza/Projects/demo-projects/php/demo-php/vendor/php-http/client-common/src/Plugin/ErrorPlugin.php on line 83

Http\Client\Common\Exception\ClientErrorException: TOO MANY REQUESTS in /Users/haza/Projects/demo-projects/php/demo-php/vendor/php-http/client-common/src/Plugin/ErrorPlugin.php on line 83

Call Stack:
    0.9151    3181944   1. Sentry\ErrorHandler->handleException() /Users/haza/Projects/demo-projects/php/demo-php/vendor/sentry/sentry/src/ErrorHandler.php:0

Hey folks. From my perspective of being an author of a custom sentry integration, this change is a breaking change.
In the integration I have code like this:
try {
    $hub->captureEvent($payload);
} catch (\Throwable $e) {
    // Avoid hard failure in case connection to sentry failed
    if ($this->fallbackWriter) {
        $this->fallbackWriter->writeLog(
            new LogRecord(
                'Sentry.Writer',
                LogLevel::ERROR,
                'Failed to write to Sentry',
                ['exception' => $e],
                $record->getRequestId()
            )
        );
    }
}

It means that I rely on the exception being throw to be able to handle that case and use a fallback strategy to capture the event, to make sure it is not silently discarded.
With this change, there is no way to detect such failure, except of course, by implementing my own HttpTransport.
Any thoughts?

Technically speaking I think that we can consider this a BC indeed... However, please note that before 2.2.0 we were even more strict about catching and this PR is just going to fix a regression since wait(false) should never throw according to the documentation, but for some reason out of our control it did... :no_good:

@ste93cry You are right, thanks. I missed that my code actually never did what I expected, as requests have been sent on shutdown only before 2.2.0. So In fact, there is no change in behavior here and I'm now onto implementing my own HttpTransport to be able to have a fallback feature in my integration.
Thanks a gain for the quick response!


Error: Inappropriate ioctl for device setting custom baud rate of 9600

My HS1+ is set up on my HiveOS rig was running fine for the last couple of weeks, miner crashed last night and now whenever I try to start the miner with HandyMiner it looks like it connects but the dashboard never opens up.
Using "npm start" I did see the following error:

Using "npm run dashboard" I get the following, it looks like its connected and receives new work:

Easiest fix would be to just uninstall the miner, and reinstall. If issue continues, check and ensure it's not a hardware or pool related issue with ViaBTC (seems that's the stratum you're trying to connect to).

I have tried to delete the entire HandyMiner directory, git clone, npm install... same issue.
I switched the same miner with the same pool config over to my windows machine with the windows goldshell miner and it starts hashing immediately.


make grpcmux pause/resume come in pair by returning a RAII obj which resumes requests on destruction.

make api pause/resume in pair by returning a RAII obj which resumes requests on destruction.
At present, the pause/resume appear in pair in most call sites, besides the clusterManagerImpl::updateClusterCounts(). this PR add some constraint to pause caller that they need to take care of the resume or the paused type-urls auto resume when the returned Cleanup is out of scope.
Ideally caller of Pause should always resume the resource when it's done, this is a step towards that goal.
Commit Message:
Additional Description:
Risk Level: low, mostly refactoring.
Testing: unit tests adjusted
Docs Changes: N/A
Release Notes:  N/A
[Optional Runtime guard:]
[Optional Fixes #Issue] #11674

/assign @htuch PTAL

/assign @htuch

thanks

/retest

@stevenzzzz approved, but master merges are blocked until the security release tomorrow. I'm going to leave #11674 open still until we sort out the story with cluster manager and refcounts (can you comment there? thanks).

sounds good
On Mon, Jun 29, 2020 at 3:21 PM htuch<EMAIL_ADDRESS>wrote:

@stevenzzzz https://github.com/stevenzzzz approved, but master merges
are blocked until the security release tomorrow. I'm going to leave #11674
https://github.com/envoyproxy/envoy/issues/11674 open still until we
sort out the story with cluster manager and refcounts (can you comment
there? thanks).
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/envoyproxy/envoy/pull/11739#issuecomment-651310616,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AA2I6TC3WUHVPGMTDZ2JQSDRZDSSFANCNFSM4OHKXBEQ
.

--
Xin Zhuang

@stevenzzzz can you merge master? Thanks.

sorry, had a git problem locally, had to force push.
Synced to upstream head, and addressed harvey's last round review comments.

seems like a clang version problem, formatted using "tools/code_format/check_format.py fix" with clang10 now.

/retest
(I dont know if it works)


chore: fix github warnings about node12 and set-output

Problem / Context
GitHub has been giving warnings about

node12 (which is out of support)

Warning: The set-output command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

set-output being upgraded to be safer

Node.js 12 actions are deprecated. For more information see: https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/. Please update the following actions to use Node.js 16<EMAIL_ADDRESS>
Solution

Update action.yml to use node16 instead of node12
Update package.json to use @actions/core ^1.10.0 instead of ^1.6.0
Add devcontainer.json so it's easy to use node16 to build the dist folder.

Testing
I haven't done anything too thorough, but I started using my fork uses: CarltonHenderson/get-persistent-value@patch-1 and it seems to be working.

Awesome! Thank you for the PR, I'll find some time soon to have a better look at it.

Thanks again @CarltonHenderson, I've finally merged your changes. :sweat_smile:
https://github.com/aaimio/get-persistent-value/pull/5


Specifying peer dependency on NPM package does not work

Hello
I noticed that NPM imports inside deno.json cannot be specified as a peer dependency using @deno/dnt and always end up inside dependencies. When specifying the import using esm.sh/ it works, however.
Minimal example using Blockly as dependency:
deno.json:
{
  "exports": {
    ".": "./mod.ts"
  },
  "imports": {
    "@deno/dnt": "jsr<EMAIL_ADDRESS>    "blockly"<EMAIL_ADDRESS>    // "blockly"<EMAIL_ADDRESS>  }
}

mod.ts:
import "blockly";

build_npm.ts:
import { build, emptyDir } from "@deno/dnt";

await emptyDir("./npm");

await build({
  entryPoints: ["./mod.ts"],
  outDir: "./npm",
  shims: {
    deno: true,
  },
  typeCheck: "both",
  mappings: {
<EMAIL_ADDRESS>{
    //<EMAIL_ADDRESS>{
      name: "blockly",
      version: "^11.1.1",
      peerDependency: true,
    },
  },
  package: {
    name: "pure-deno",
    version: "0.0.1",
  },
  importMap: "./deno.json",
});

Replacing the import with the esm.sh/ version correctly transforms blockly as peer dependency while using the npm: version keeps it as direct dependency.
As a workaround one has to keep a separate import map or manually specify dependencies inside package in the build script.

If anyone is running into the same problem right now, my current workaround is the following code snippet to (dirtily) cut out peer dependencies:
const importMap = JSON.parse(Deno.readTextFileSync("./deno.json"));
const blocklyVersion = (<string>importMap["imports"]["blockly"]).split("@")[1];
delete importMap["imports"]["blockly"];
Deno.writeTextFileSync("./deno-npm.json", JSON.stringify(importMap, null, 2));

/// ...
await build({
  // ...
  package: {
    // ...
    peerDependencies: {
      blockly: blocklyVersion,
    },
  }
});

I'm running into the same problem. For now solving it with a different approach. I overwrite the generated package.json with the unintentional dependencies as dev dependencies.
import type { SpecifierMappings } from "@deno/dnt/transform"

const mappings: SpecifierMappings = {
  "npm<EMAIL_ADDRESS>{
    name: "@anthropic-ai",
    version: "^0.32.1",
    peerDependency: true,
  },
<EMAIL_ADDRESS>{
    name: "openai",
    version: "^4.76.0",
    peerDependency: true,
  },
}

await build({
  // ...
  mappings,
})

const packageJsonPath = path.join(outDir, "package.json")
await Deno.readTextFile(packageJsonPath).then(async (v) => {
  const initial = JSON.parse(v)
  const {
    "@anthropic-ai/sdk": anthropic,
    openai,
  } = initial.dependencies
  delete initial.dependencies
  initial.peerDependencies = {
    "@anthropic-ai/sdk": anthropic,
    openai,
  }
  await Deno.writeTextFile(packageJsonPath, JSON.stringify(initial, null, 2))
})


[owasp] make CI fails if distribution/offloaders check does not pass

Motivation
Offloaders now passes the OWASP check. Let make the CI fails if a new vulnerability comes out. This let us to quickly notice there's a fix to do
Modifications

Added -DfailBuildOnAnyVulnerability=true to the distribution/offloaders command (only for master)

Documentation

[x] no-need-doc

/pulsarbot run-failure-checks

/pulsarbot run-failure-checks

/pulsarbot run-failure-checks

@lhotari @dlg99 could we get this merged ?

I rebased and integrated it with the OWASP check PR validator

/pulsarbot run-failure-checks

the owasp check doesn't pass against file-system offloader, so we can merge this PR only when the check will be green

Closed as stale and conflict. Please rebase and resubmit the patch if it's still relevant.


Upgrade bigquery v1.3.0 -> v1.45.0

Hiya! I'm trying to use this project while making use of google's identity federation. Upgrading this package enables support for the necessary configuration file.

This change is

Pull Request Test Coverage Report for Build 143

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build 139:
0.0%

Covered Lines:
261

Relevant Lines:
261

💛  - Coveralls


Remove unneeded callback.

Leftover from 4dad3f9.
@jmervine: I'm trying to split as many things as possible from #1000 so that it's easier to review.

👍🏽


Create an app specific password for the iOS build

What

[ ] Create an app specific password for the iOS build

Logs
[14:30:04]: Transporter transfer failed.
[14:30:04]:
[14:30:04]: Please sign in with an app-specific password. You can create one at appleid.apple.com. (-22910)
[14:30:04]:
[14:30:04]: Application specific password you provided using
[14:30:04]: environment variable FASTLANE_APPLE_APPLICATION_SPECIFIC_PASSWORD
[14:30:04]: is invalid, please make sure it's correct

done