💡[FEATURE]: Dark Mode Feature

Allow users to toggle light and dark mode
I am a GSSOC '24 Contributor and I have just finished working on this feature in another project so I am confident I can solve this. Please assign this to me

I agree to follow this project's Code of Conduct
I'm a GSSOC'24 contributor
I want to work on this issue.

Could you please add the GSSOC tag to this issue?

@sanika391 Can you assign this issue to me?

Sure!
On Sun, May 19, 2024 at 4:50 PM SumitPareek2401 @.***>
wrote:

@sanika391 https://github.com/sanika391 Can you assign this issue to me?
—
Reply to this email directly, view it on GitHub
https://github.com/sanika391/SpoonShare/issues/18#issuecomment-2119198772,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/A34TW26Z6NRR2VEFEWEJM2DZDCDIBAVCNFSM6AAAAABHWWPQXKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMJZGE4TQNZXGI
.
You are receiving this because you were mentioned.Message ID:
@.***>

Did it
On Sun, May 19, 2024, 9:36 PM SumitPareek2401 @.***>
wrote:

Sure!
… <#m_-2470649898831896041_>
On Sun, May 19, 2024 at 4:50 PM SumitPareek2401 @.> wrote: @sanika391
https://github.com/sanika391 https://github.com/sanika391
https://github.com/sanika391 Can you assign this issue to me? — Reply to
this email directly, view it on GitHub <#18 (comment)
https://github.com/sanika391/SpoonShare/issues/18#issuecomment-2119198772>,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/A34TW26Z6NRR2VEFEWEJM2DZDCDIBAVCNFSM6AAAAABHWWPQXKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMJZGE4TQNZXGI
https://github.com/notifications/unsubscribe-auth/A34TW26Z6NRR2VEFEWEJM2DZDCDIBAVCNFSM6AAAAABHWWPQXKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMJZGE4TQNZXGI
. You are receiving this because you were mentioned.Message ID: @.>
Assign me?
—
Reply to this email directly, view it on GitHub
https://github.com/sanika391/SpoonShare/issues/18#issuecomment-2119287256,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/A34TW2ZHIAGQZSK6WVWMJVTZDDEZTAVCNFSM6AAAAABHWWPQXKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMJZGI4DOMRVGY
.
You are receiving this because you were mentioned.Message ID:
@.***>

@sanika391 can you label the GSSoC to this issue? So that I can merge under it.

I have labelled it
On Mon, May 20, 2024, 5:50 PM SumitPareek2401 @.***>
wrote:

@sanika391 https://github.com/sanika391 Will you label it or should I
have to merge without it?
—
Reply to this email directly, view it on GitHub
https://github.com/sanika391/SpoonShare/issues/18#issuecomment-2120349556,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/A34TW23ZN3KSZUCRIWDHRVLZDHTAHAVCNFSM6AAAAABHWWPQXKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMRQGM2DSNJVGY
.
You are receiving this because you were mentioned.Message ID:
@.***>

@sanika391 please GSSoC label to this issue.


⚠ Cioos National CKAN Sitemap has degraded performance

In 371d61e, Cioos National CKAN Sitemap (https://catalogue.cioos.ca/sitemap/sitemap-1.xml) experienced degraded performance:

HTTP code: 200
Response time: 20664 ms

Resolved: Cioos National CKAN Sitemap performance has improved in 0ce9c19 after 6 minutes.


Support Symfony 6

Pull Request
What does this PR do?
Adds support for Symfony 6 and fixes tests
PR checklist
Please check if your PR fulfills the following requirements:

[ ] Does this PR fix an existing issue?
[x] Have you read the contributing guidelines?
[x] Have you made sure that the title is accurate and descriptive of the changes?

Maybe we could also increase lowest constraint from Symfony 4.0 to 4.4? which is lowest maintained version

Maybe we could also increase lowest constraint from Symfony 4.0 to 4.4? which is lowest maintained version

Let's fix the CI first.
We'll add lower version support if asked by the community, and in another PR, what do you think?

OK

@norkunas, I realized I did not get well first your question about Symfony 4.0, my bad, I've just opened an issue: https://github.com/meilisearch/meilisearch-symfony/issues/141

Failing to find a way to support both php 7 and 8 worlds :/

Thanks for having tried!!
I close this PR in favor of this issue #143
Feel free to re-open another PR if you have a solution, or want to try something!

Dont have more time now,will try on monday :)


Add AdvisoryVerifier

Add AdvisoryVerifier type which can be used to ensure the available
advisories do not exceed the allowed advisories.

Motivation

Current dependencies on/for this PR:

main

PR #83

PR #84

PR #85

PR #86

PR #87

PR #48

PR #89

PR #90   👈

PR #88

This comment was auto-generated by Graphite.

Current dependencies on/for this PR:

main

PR #83

PR #84

PR #85

PR #86

PR #87

PR #48

PR #89

PR #90   👈

PR #88

This comment was auto-generated by Graphite.

Current dependencies on/for this PR:

main

PR #83

PR #84

PR #85

PR #86

PR #87

PR #48

PR #89

PR #90   👈

PR #88

This comment was auto-generated by Graphite.

looks okay to me, the use of PartialOrd on AdvisoryStatus is a bit wonky though

@cbeck88 The PartialOrd is needed for
        if self.status > other.status {
            return false;
        }

Or are you saying this comparison is wonky behavior?
I agree it's a bit odd and maybe I'm letting my C enum experience creep in here.
Maybe I need to document more on the AdvisoryStatus enum, from https://api.portal.trustedservices.intel.com/documentation#pcs-tcb-info-v4

Go over the sorted collection of TCB Levels retrieved from TCB Info starting from the first item on the list:

The levels are sorted from best to worse, based on status and active advisories

@nick-mobilecoin started a stack merge that includes this pull request via Graphite.

@nick-mobilecoin merged this pull request with Graphite.


chore(master): release 1.4.0

:robot: I have created a release beep boop
1.4.0 (2024-02-20)
Features

support hot words tag (7fbe055)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/Justin3go/usesora/releases/tag/v1.4.0 :sunflower:


Wepback tree-shaking and vue-components package

version: 3.8.1
Reproduction link
https://github.com/qiyuan-wang/vue-tree-shaking-example
Steps to reproduce
I have a package, named like 'Cards', including several vue components, its structure is likes:
| - components
  | - NoteCard.vue
  | - ItemCard.vue
  | - UserCard.vue
| - index.js
| - package.json

I exports all components in the index.js file.
So, I can use those components in my business package:
<template>
  <div>
    <note-card />
  </div>
</template>
<script>
  import { NoteCard } from 'cards'

  export default {
   ...
  }
</script>

I try to use the feature ‘Tree shaking’.
I thought the output bundle would contain the components I import in my business package. For example, it would contain NoteCard only for the codes above.
But the reality is, all components would be in the bundle, that makes the bundle size huge.
So, my question is, what makes ‘tree-shaking’ not work?
What is expected?
Codes from ItemCard and UserCard should not be included in the output bundle.
What is actually happening?
Codes from ItemCard and UserCard are included in the output bundle.

So, my question is, what makes ‘tree-shaking’ not work?

The ESM spec.
It say that every imported module must be evaluated.
You import all modules:
export { default as NoteCard } from './components/NoteCard.vue'
export { default as ItemCard } from './components/ItemCard.vue'
export { default as UserCard } from './components/UserCard.vue'

webpack 4 will come with a new feature to opt-in into non-spec-comform behavior that can eliminate these reexports.

ok, I see.

@sokra it is still not work on<EMAIL_ADDRESS>

I had the same problem. I tried configuring the uglifyJSPlugin plug-in. But it didn't work

Any news on this ?


Fix TrackPendingOperation

@EricSten-MSFT,
Thanks for having already signed the Contribution License Agreement. Your agreement was validated by .NET Foundation. We will now review your pull request.
Thanks,
.NET Foundation Pull Request Bot


Update borders.h

not simple but versatile

@dixitS05 Beautiful bro but would it be copying
Sent from my HUAWEI MHA-L29 using FastHub

hmm.. not sure about that


Sort benchmark results in REAMDE.md by column: Mean

As the maintainer of Friflo.Engine.ECS I want to ask if the benchmark results in README.md can be ordered by column: Mean.
Every Component benchmark have now 44 rows. So you are lost in numbers.
As a result you go with Arch assuming the tables are already sorted.
This assumption comes from the coincidence that Arch have good results in average.
Morpeh & SveltoECS are at the bottom caused by the alphabetical sort order.
So there is no real incentive to improve performance.
You never got on the Top caused by the selected project Name.
Alternatively we could rename our projects to "Abc-..." 😊
Any thoughts?

well it wasn't really supposed to become a score board but I get you haha. It could probably come with the next PR #36

Ah,
did not read through this PR. Too much text for me :)
But the idea is the same.

Speaking of leaderboard.
This is the reference 😊
https://www.techempower.com/benchmarks/#hw=ph&test=fortune&section=data-r22
Best C# implementation: aspcore-ado-pg
Looser! 😁

Hi @thygrrr!
Challenge accepted 😊
I don't think I can beat this number. It would require dropping features.
I am already looking where I can improve performance. Found already one hotspot.
There are two more candidates for improvement.
I checked your implementation. I guess you should add a Reserve() or EnsureCapacity() like Arch or Friflo ECS.
I assume that gives a speedup of 20%.
@Doraku Is it okay to reuse a World in the benchmark to avoid the cost for memory allocations?
Arch is doing this indirectly as World.Create() recycle disposed worlds.

... Carmack-style indentation ...

Far too much praise but I appreciate.
I like indentation it helps me parsing code into my few synapses faster.
btw: Arch is very good in selling his ECS. Even if I don't like this exaggerated wording.

I'm warming up my queries for the benchmark (because of how ThreadPool.UnsafeQueueUserWorkItem works) and I'm (now) also pre-sizing Worlds based on the number of entities to expect.
This saves unnecessary dictionary and storage array resizes, etc. that on repeat runs would also not occur.
This is common sense and practice for any expected ECS real work use as well.
Otherwise I'd just set the default capacities from 4K to 128K in the next release. ;)

Otherwise I'd just set the default capacities from 4K to 128K in the next release. ;)

LOL

Hi @thygrrr,
finished optimization of create entities. See: https://github.com/Doraku/Ecs.CSharp.Benchmark/pull/38
The main optimization was to minimize the administration memory footprint used for an entity
from 48 byte to 16 bytes required by the struct EntityNode.
The counterpart in your lib is called Meta I guess.
Now I don't see any significant optimization possibilities.
Create entities could be optimized a little to but delete entities will get slower.
Viele Grüße,
Ulli


Bug parsing qualified record ending in {delimiter}{qualifier}

In ParserUtils.isMultiLine a check is made to see if the line ends with the qualifier character. If so, the preceding character is compared to the delimiter and if it matches it is assumed the content is multiline data and the two characters (<{delimiter}{qualifier}) are the beginning of the multiline field.
Consider the case though where there is data,data,qualifieddata i.e. comma delimited double quote qualified content such as: some data,some other data,"some,qualified,data,".
The result is that the ending ," are assumed to be the beginning of a multiline field which consumes the rest of the records until some closing {delimiter}{qualifier} is encountered?
I first encountered this in 3.2.0 but confirm the behavior in 4.0.0 as well.

Would you have a coded test case/JUnit so we could add it to the suite?
Thanks

I do not have one convenient at the moment but I can put one together.

I have added for tests to ParserUtilsTest.java.
test qualified non multiline
test qualified multiline
test non qualified non multiline
test non qualified multiline
All pass but the qualified multiline.
Not sure how best to get this incorporated in github?

I also have taken a first swipe at correcting the issue. I would be happy to share this and receive any feedback on it.

By all means, that would be great.
You could fork Master and then create a pull request that incorporate your changes.
@ks-appendium is this correct?
Thanks

Important Notice
This communication contains information that is considered
confidential and may also be privileged. It is for the exclusive use of the intended recipient(s). If you are not the intended recipient(s) please note that any form of distribution, copying or use of this communication or the
information in it is strictly prohibited and may be unlawful. If you have received this communication in error please return it to the sender and
delete the original

On 2 Aug 2015, at 05:40, icemanltd<EMAIL_ADDRESS>wrote:
I also have taken a first swipe at correcting the issue. I would be happy to share this and receive any feedback on it.
—
Reply to this email directly or view it on GitHub.

Yes, I am new to Git but I forked from https://github.com/ks-appendium/flatpack master.
I will hopefully be able to push them tonight and submit a pull request.

Sorry for the delay but I have created the pull request. Please let me know if there is more I can do. Thank you.

integrated in 3_4 and master.
Thank you for the patch.


Robust parsing and raising exceptions on HTTP errors

#338, in an effort to fix event stream parsing, lost the ability to grab the error JSON returned in the body.
I'm working on this draft to extend that implementation and make a breaking change in ruby-openai to actually raise exceptions on errors.
All Submissions:

[ ] Have you followed the guidelines in our Contributing document?
[ ] Have you checked to ensure there aren't other open Pull Requests for the same update/change?
[ ] Have you added an explanation of what your changes do and why you'd like us to include them?

Superseded by #344


[Question] Quality improvement using different generator parameters

I was wondering if it is possible to further improve quality by adjusting the generators parameters in the MRF, like the hidden dimension or the kernel sizes. Ideally it would get rid of even more artifacts. Has anybody tried this?

@george-roussos
I've tested upsample_initial_channel of 768, discriminator_periods with lots of extra discriminators, using and not-using the 2 period with 44khz.
And I could only hear a consistent difference early into training.

What would you/we use/do to verify the results?
I find it hard to hear the artefacts in single speaker HiFi-GAN models already (thought this might just be my hearing going?), if you have something that consistently fails then that would make testing the params much easier.

It is that breathing problem I mentioned on the other thread, when constructing a TTS spectrogram. I just cannot seem to get rid of it. The voice itself sounds great and natural, especially after finetuning on ground truth mels from my Taco2 model. But whenever my speaker breathes, it sounds very metallic. I tried a run in which I used the ParallelWaveGAN generator and the HiFiGAN discriminators. The quality was much worse than HiFiGAN, however the breathing problem was completely eliminated. So I am kind of at a loss.

@george-roussos
https://96ad295d3358.ngrok.io/
Open this link and test the "Nancy" voice (at the top of the speaker list).
Does this speaker have the voice affect you're referring too?

Audio samples please?

Yes, sure. As I said my speaker has not given me consent so I cannot provide with actual voice, but for reference, here is the same breath mark from the same TTS spectrogram. The first breath mark is from HiFiGAN generator and the other one is from PWGAN generator.
https://drive.google.com/file/d/1jAaTtM6b2_QQ6EsEesYg4SVBwBglY7fE/view?usp=sharing

Hmmm, I want to blame the tacotron2 model but I'm not sure. I don't use the same spectrogram config so I don't think I'll be doing any testing using my own models on your data. I guess good luck?

No worries mate, I appreciate you looking into it either way

have you encounter the high frequency artifact? @george-roussos @CookiePPP

@hdmjdp
I noticed it though I couldn't hear it clearly enough to worry me.
The reconstruction loss fmax wasn't configured so fmax_for_loss was still at 11025. I haven't tested with this value configured to 16000 or higher.
I did try the 2 period discriminator but that didn't improve things to my ears, either needed to wait longer for training or human ears can't tell periodicity above 11Khz with high accuracy.

@thanks for repying. I trained 48k. So if fmax_for_loss=null, the fmax will be 24000.  I have trained 120k steps. How many steps have you trained to get a good wav?
below is librosa api:
"fmax      : float >= 0 [scalar]
highest frequency (in Hz).
If None, use fmax = sr / 2.0"

@hdmjdp I also did not encounter it enough, but I think it depends on the speaker in general. At around 800K steps for me the speech sounded great.
@CookiePPP could you please tell me how you implemented 2 period discriminator and more discriminators in general, as you mentioned?

@george-roussos @CookiePPP  this is my config:
"upsample_rates": [10,5,3,2,2],
"upsample_kernel_sizes": [20,11,7,4,4],
"upsample_initial_channel": 384,
"resblock_kernel_sizes": [3,7,11],
"resblock_dilation_sizes": [[1,3,5], [1,3,5], [1,3,5]],
"segment_size": 19200,
"num_mels": 128,
"num_freq": 1025,
"n_fft": 4096,
"hop_size": 600,
"win_size": 2400,

"sampling_rate": 48000,

"fmin": 0,
"fmax": 12000,
"fmax_for_loss": null,

@hdmjdp

I trained 48k. So if fmax_for_loss=null, the fmax will be 24000.

Hmmm, I'm not sure then.

To use custom periods. line 164
class MultiPeriodDiscriminator(torch.nn.Module):
    def __init__(self):
        super(MultiPeriodDiscriminator, self).__init__()
        self.discriminators = nn.ModuleList([
            DiscriminatorP(2),
            DiscriminatorP(3),
            DiscriminatorP(5),
            DiscriminatorP(7),
            DiscriminatorP(11),
        ])

to
class MultiPeriodDiscriminator(torch.nn.Module):
    def __init__(self, periods=None):
        super(MultiPeriodDiscriminator, self).__init__()
        self.periods = periods if periods is not None else [2, 3, 5, 7, 11]
        self.discriminators = nn.ModuleList()
        for period in self.periods:
            self.discriminators.append(DiscriminatorP(period))

and line 33
    mpd = MultiPeriodDiscriminator().to(device)

to
    mpd = MultiPeriodDiscriminator(h["discriminator_periods"] if "discriminator_periods" in h.keys() else None).to(device)

@CookiePPP
Actually, I have use your period config, just write using hardcode in models.py. Such as below:
class MultiPeriodDiscriminator(torch.nn.Module):
def init(self):
super(MultiPeriodDiscriminator, self).init()
self.discriminators = nn.ModuleList([
#DiscriminatorP(2),
DiscriminatorP(3),
DiscriminatorP(5),
DiscriminatorP(7),
DiscriminatorP(11),
DiscriminatorP(17),
DiscriminatorP(23),
#DiscriminatorP(37),
])

@hdmjdp
Then I don't know, dataset or training time I suppose.

@CookiePPP
I will train more steps. And another question,  whether more peroids can improve the quanlity of audio?

 Have you encountered the high frequency artifact? @george-roussos @CookiePPP

Hi, @hdmjdp.
I have the same problem, did you solve the high frequency artifact?
Can increasing the number of training steps solve the problem?

Hi @LqNoob @hdmjdp , did you figure out how to solve the high frequency artifact? i'm facing it too, thanks!


Upgrade dependencies

The maud upgrade is needed to compile on the latest nightlies. Everything else is optional. Let me know if you want me to split the PR up!

Hi there, thank you for your PR!
The project is now in the process of becoming maintained again. Parts of #44 solved the dependency issue you addressed with your Pull Request, so I will close this. I see that you made other changes as well, so if you want, you can resubmit them again or become a contributor to the project. Just give us a heads up at #40 if you're interested!


call __init__ during precompilation to make sure it gets precompiled

The __init__ method does not run during precompilation but it is attempted to get compiled. However, for this package it seems that there is some dynamic dispatch which means that precompilation cannot follow the call chain all the way. Calling the method explicitly helps and since it is quite expensive, gives a good improvement to load time.
Before:
julia> @time using Enzyme
[ Info: Precompiling Enzyme [7da242da-08ed-463a-9acd-ee780be4f1d9]
 44.283140 seconds (8.50 M allocations: 585.708 MiB, 0.36% gc time, 11.54% compilation time)

 julia> @time using Enzyme
 5.449457 seconds (8.47 M allocations: 583.942 MiB, 3.33% gc time, 92.65% compilation time)

After:
julia> @time using Enzyme
[ Info: Precompiling Enzyme [7da242da-08ed-463a-9acd-ee780be4f1d9]
 47.372864 seconds (798.57 k allocations: 49.376 MiB, 0.06% gc time, 0.08% compilation time)

julia> @time using Enzyme
  0.420285 seconds (775.94 k allocations: 47.622 MiB, 4.59% gc time, 3.96% compilation time)

I don't think the __init__ method caches anything that will end up in the precompile file. Another way to fix this might be to improve the type inference for the methods in __init__.

@wsmoses we could just do:
    current_task_offset()
@static if VERSION < v"1.7.0"
else
    current_ptls_offset()
end

During precompilation instead of running it in __init__. Ideally Julia would just expose an API for us to use.


Add support for "delete" events (or elaborate more on why not possible)

I know this isn't currently built, however is it possible to propagate notifications on file deletions? I noticed that the documentation pointed out this limitation but I'd like to know if it's due to some issue out of the control of this library or maybe just due to time constraints.

Upon further research, it looks like an impossibility to do cleanly, since from what I can tell, the only way you can trigger an inotify event for a file deletion is to actually perform the file deletion from within the container itself. One workaround I'm thinking of could be an enormous hack, but:
Say we have C:\volume\ mounted in our container at /var/www/html:

Receive notification that file C:\volume\file.txt was deleted in Windows
Re-create empty file again at C:\volume\file.txt (again in Windows)
Delete the file in the container via rm -f /var/www/html/file.txt (which would then trigger inotify).

What do you think? Too hacky? Too magical? 🎩✨


⚠ Bofrost.lu has degraded performance

In 91e478a, Bofrost.lu (https://www.bofrost.lu) experienced degraded performance:

HTTP code: 200
Response time: 2032 ms

Resolved: Bofrost.lu performance has improved in 7344779 after 20 minutes.


Fix typo in documentation example code

Hey, thanks for the contribution, could you make this exact change to DOC.md instead? luasnip.txt is generated from it :sweat_smile:

Hey, NP - and thanks for an AMAZING plugin.
Clever, with the doc ;) I noticed it in neovim itself when I was browsing the docs.
Fixed on my patch branch (force pushed to get rid of the useless commits).

TYTY :)
Nice little fix, thanks!


Unable to fetch vendor

I'm trying to fetch vendor and I obtain this error
[Error] bower                                     ECONFLICT Unable to find suitable version for jquery
Debug info

Component
Version

Symfony version
3.3.6

node version
6.11.0

npm version
3.10.10

Bower version
1.8.0

AdminThemeBundle
1.3.5

I can confirm.
@thibmonier  Did you find a workaround ?

not really. I don't know why it was working a few days after.
I didn't try recently

Thanks.
following #174 advice , with a "resolution" block I went around this issue.
I have yet to test if latest AdminThemeBundle has the same issue. That's for another day :-)


Apply specific addon instead of the whole template

Currently, the template doesn't support to apply only specific addon yet, someone might use the template to add a few add-ons instead of the whole template.
For example:
mix nimble.phx.gen.template addon=credo # applying only credo addon to an existing project
mix nimble.phx.gen.template addon=wallaby # applying only wallaby addon to an existing project

As the existing project's structure might differ from the original project, so it will be challenging to apply the addon to that. We can implement this one by 2 phrases

Phrase 1: Instead of applying the addon, we can render the step-by-step how to integrate the addon like a guide so the user can add it manually regardless of their existing structure.
eg: with the Oban addon

Step 1: add Oban into the mix.ex file
Step 2: Create the migration file with the following content ....
Step 3: ....

Phrase 2: Apply to any existing structure, this would be a hard task.


Issue whilr importing the ndjson file

We are getting and issue when we import the export.ndjson file in kibana
Error Message:
"dashboard" which belongs to a more recent version of Kibana [7.15.0]. The last known version is [7.14.0]:

I ran into the same issue. To fix this, you have to update the versions inside your docker-compose.yml.
image: docker.elastic.co/elasticsearch/elasticsearch:7.14.2 -> image: docker.elastic.co/elasticsearch/elasticsearch:7.15.0
image: docker.elastic.co/kibana/kibana:7.14.2 -> image: docker.elastic.co/kibana/kibana:7.15.0

@hieronymusma thanks for the update ... I will investigate and get back to you shortly.

Thank you for resolving this issue sir.
Regards,
Hiren Vikhram S
On Mon, Jun 27, 2022 at 10:46 PM Maurice Hieronymus <
@.***> wrote:

I ran into the same issue. To fix this, you have to update the versions
inside your docker-compose.yml.
docker.elastic.co/elasticsearch/elasticsearch:7.14.2 ->
docker.elastic.co/elasticsearch/elasticsearch:7.15.0
docker.elastic.co/kibana/kibana:7.14.2 ->
docker.elastic.co/kibana/kibana:7.15.0
—
Reply to this email directly, view it on GitHub
https://github.com/punk-security/SMBeagle/issues/66#issuecomment-1167630904,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AUPH7KZPWZI2H5DFYDEAHSLVRHOWRANCNFSM5YMSEZKQ
.
You are receiving this because you authored the thread.Message ID:
@.***>

Confirmed and I will update the docker-compose file.


[Firewall] Fix #26592: az network firewall policy: Unhashable --identity

This checklist is used to make sure that common guidelines for a pull request are followed.

For new extensions:

[ ] My extension description/summary conforms to the Extension Summary Guidelines.

About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Firewall


chore: move helm-backstage repo to redhat-developer/rhdh-chart

What does this PR do?
chore: move https://github.com/janus-idp/helm-backstage -> https://github.com/redhat-developer/rhdh-chart [ci skip]
Signed-off-by: Nick Boldt<EMAIL_ADDRESS>Screenshot/screencast of this PR
N/A
What issues does this PR fix or reference?
https://issues.redhat.com/browse/RHIDP-1020
How to test this PR?
N/A
PR Checklist
As the author of this Pull Request I made sure that:

[x] The Eclipse Contributor Agreement is valid
[x] Code produced is complete
[x] Code builds without errors
[ ] Tests are covering the bugfix
[x] The repository devfile is up to date and works, if one exists
[x] Sections What issues does this PR fix or reference and How to test this PR completed
[x] Relevant user documentation updated
[x] Relevant contributing documentation updated
[x] CI/CD changes implemented, documented and communicated

Reviewers
Reviewers, please comment how you tested the PR when approving it.

See also #946


Add multiple backend support to cinder_service_check.py

When the host argument is supplied and the host has multiple cinder
backends configured, duplicate status metrics are returned. MaaS
currently only checks the last value during alarm evaluation. If the
last backend metric is 1 (up) but previous backend metrics are 0 (down),
no MaaS alert will be fired.
This change addresses this by evaluating all services for a host first,
and then aggregating the results into one status metric.
Additionally, each backend on the host now has its own status metric to
aid in troubleshooting and allow for alarms to be set on individual
backends.
Issue #836
(cherry picked from commit ef3f99fb909da4c16adbc5dd33a21d22be5a38ca)

RPC-AIO Ceph failure on Tempest/Cirros:
20:16:37 TASK: [os_tempest | Ensure cirros image] **************************************
20:16:37 failed: [jrpcaioiad-40d_utility_container-27282c8c] => {"failed": true, "parsed": false}
20:16:37 OpenSSH_6.6.1, OpenSSL 1.0.1f 6 Jan 2014
20:16:37 debug1: Reading configuration data /etc/ssh/ssh_config
20:16:37 debug1: /etc/ssh/ssh_config line 19: Applying options for *
20:16:37 debug1: auto-mux: Trying existing master
20:16:37 debug1: mux_client_request_session: master session id: 2
20:16:37 Traceback (most recent call last):
20:16:37   File "<stdin>", line 1848, in <module>
20:16:37   File "<stdin>", line 1845, in main
20:16:37   File "<stdin>", line 1765, in route
20:16:37   File "<stdin>", line 1818, in create_image
20:16:37   File "/usr/local/lib/python2.7/dist-packages/glanceclient/v1/images.py", line 319, in create
20:16:37     data=image_data)
20:16:37   File "/usr/local/lib/python2.7/dist-packages/glanceclient/common/http.py", line 265, in post
20:16:37     return self._request('POST', url, **kwargs)
20:16:37   File "/usr/local/lib/python2.7/dist-packages/glanceclient/common/http.py", line 230, in _request
20:16:37     raise exc.from_response(resp, resp.text)
20:16:37 glanceclient.exc.HTTPException: 504 Gateway Time-out: The server didn't respond in time. (HTTP N/A)

recheck

Straightforward backport :+1:


3_coreLayerContracts: fix typo

Simple fix.

Closing, as there's another PR that's more comprehensive that I didn't see beforehand.


Content is blinking in the hydrogen-may project

Some content is blinking/reloading/rerendering (remounting?) on all different kinds of interactions. E.g. see the tote bag here blinking on resizing something next to it:
https://screenshot.click/05-00-j4ybz-2nr75.mp4
Or simply when we switch editor mode:
https://screenshot.click/05-07-nwvug-d7e4g.gif
This may be connected to: https://github.com/concrete-utopia/utopia/issues/5834
It is suspicious that this is connected to live data coming from the loader. I also experienced that the mutation/resize observer fires in cases when there are no changes (e.g. during scrolling), that may be connected to this issue too.

@seanparsons is it just rerendering, or remounting? because I think a rerender where React doesn't remove-re-add the DOM node should not result in an image being reloaded. I have a feeling (but not verified) that this is a remount happening somewhere, maybe because of a botched key, or something way more abstract, like the React.element.type losing reference because of a re-evaluation of arbitrary js

Superseded by https://github.com/concrete-utopia/utopia/issues/5834


nixos/jotta-cli: init jotta-cli

Description of changes
To complement the existing jotta-cli package, add a NixOS module with a user service that runs jottad. The module also adds jotta-cli to system packages. See https://github.com/NixOS/nixpkgs/issues/300063.

Things done

Checklist for new NixOS modules

[x] module path fits the guidelines
[x] module tests succeed on x86_64-linux
[x] options have appropriate types
[x] options have default
[x] options have example
[x] options have descriptions
[x] No unneeded package is added to environment.systemPackages
[x] meta.maintainers is set
[x] module documentation is declared in meta.doc

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[x] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Would programs.jotta-cli be a better fit than services.jotta-cli, since this both runs a service and installs a package?

@SuperSandro2000 Requested changes have been addressed, could you mark as resolved?

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-already-reviewed/2617/1613

Would programs.jotta-cli be a better fit than services.jotta-cli, since this both runs a service and installs a package?

Since it runs a daemon, services it probably more correct but it does not matter that much. programs is mostly used for desktop applications requiring services or clis being executed or similar things.

Hey,
I just tried updating my system and stumbled upon a cryptic error mentioning this pkg :
error: The option `user' in module `/nix/store/<my configuration>-source' would be a parent of the following options, but its type `attribute set' does not support nested options.
        - option(s) with prefix `user.services' in module `/nix/store/<nixpkgs>-source/nixos/modules/services/networking/jotta-cli.nix'

Turns out this is the first pkg in nixpkgs that declares the user option, if I'm not mistaken.
My configuration is based on https://github.com/hlissner/dotfiles and already declares the user option as an alias for users.<username>.
Of course, I'm not asking to change anything in this pkg here, but https://github.com/hlissner/dotfiles are pretty popular and I bet a lot of people will get a similar error when trying to update their system so it's more of a heads up 🙈
🫡

I had the exact same issue. Had to rename the module option to just services.jotta-cli on my fork of nixpkgs to work-around this.

I've overlooked this and we should move that option, probably without a mkRenameOption to prevent further issues.

@Moonlight-Angel Thanks! Opened https://github.com/NixOS/nixpkgs/pull/309324.

Hi, after two days, I still meet this issue:
error: The option `user' in module `/nix/store/yp4xjx4z6pw00sy0fkx3ixjrahkyqa7x-source' would be a parent of the following options, but its type `attribute set' does not support nested options.
        - option(s) with prefix `user.services' in module `/nix/store/3pif36ks3f56py4wb1dkq6sh0nkf3ygj-source/nixos/modules/services/networking/jotta-cli.nix

I don't know how to fix it manually.

@alienzj You can use disabledModules.
disabledModules  = [
  "services/networking/jotta-cli.nix"
]

@alienzj You can use disabledModules.
disabledModules  = [
  "services/networking/jotta-cli.nix"
]

Thanks so much! It works.

Thanks. This is a good way for me to understand it.


Code quality check

[ ] Connect to sonarCloud with GitHub account
[ ] Setup your project on sonarCloud
[ ] Create new GitHub secret with sonarCloud token
[ ] Edit build.gradle file with information given by sonarCloud
[ ] Create new GitHub action for sonarCloud


add a mobile preview as well

what a wonderful project. I gave it a try and was amazed. I wanted a mobile view also so I changed Preview.tsx to return 2 iframes like so:
  return (

  );
}

Thanks for this! Will add this in.

Added now, thanks.

I also encountered the same issue.


Can't Compile GDNative C++ game for Windows under Linux (Zorin OS and Ubuntu).

Godot version:

3.23 stable (Standard)
OS/device including version:

Linux Zorin OS and Ubuntu (Not Graphics related)
Issue description:

What happened was that i was making a GDNative C++ game and i can compile for Linux just fine but when i tried for Windows (I installed mingw and the environment variables are set correctly) it failed giving an error that the compiler options or command line options are not found. The Same thing happened under Zorin OS and Ubuntu. Is there anything i must change in the Sconstruct file or this is a bug?
The Project :
C++ Testing.zip
I was expecting it to compile without problems.
Steps to reproduce:
You can try to compile your own GDNative C++ Example for Windows under Linux (Ubuntu or Zorin OS) and see if it works.
Minimal reproduction project:

This repository is only used to track core engine bugs.
Please report issues related to the C++ binding on godot-cpp after searching for duplicates.


[App Service] Fix #21133: az webapp/functionapp config ssl bind/unbind: Search for matching certificates in the subscription by App Service Plan Id

Related command

az webapp config ssl bind
az webapp config ssl unbind
az functionapp config ssl bind
az functionapp config ssl unbind
Description

Fixes #21133 & fixes #13929. Currently the CLI only searches for matching certificates in the web app's resource group and the resource group for the app service plan. This change would add logic to search for a matching cert in the user's subscription as well (filtering on the web app's App Service Plan / serverfarmId)  if no match was found using the previous logic.
Issue_Close: #21133 #13929
Testing Guide

History Notes

This checklist is used to make sure that common guidelines for a pull request are followed.

[ ] The PR title and description has followed the guideline in Submitting Pull Requests.

[ ] I adhere to the Command Guidelines.

[ ] I adhere to the Error Handling Guidelines.

App Service

/azp run


Swift version (3) no longer supported in XCode

I tried installing this pod but I get the following error in XCode:
SWIFT_VERSION '3.0' is unsupported, supported versions are: 4.0, 4.2, 5.0.

Could you please add support for the newer Swift versions?

Hey @salqadri, thanks for reporting the issue. Unfortunately, I haven't kept up with the Swift updates and won't have time to upgrade this library in the neat future.

Ok np; fwiw I copied the file over into my project and it works fine without any code changes in the latest swift.

Great, glad it worked out!


Parallelism assumes direct west.h5 file access

Currently, some parallelized sections of msm_we still assume they'll have direct access to the west.h5 files being analyzed.
For example, taking the discretization: in do_stratified_ray_discretization, I pass an iteration to the remote worker, and the remote worker is responsible for retrieving the data.
This was an intentional decision, to avoid having to send lots of data. However, this means we assume direct access to the west.h5 files... This prevents you from using a remote cluster for Ray work.
To me, it seems like the options are:

Copy all the west.h5 files to the remote worker, maybe in the restart plugin? Ray supports this in init via runtime_env argument, but it has pretty conservative limits on file size.
This has the drawback of requiring a large file copy.
Send iteration data directly, rather than having each worker read it.
This, on the other hand, has the drawback of requiring lots of data to be sent over the network.

This is  partially addressed in #39 which provides an explicit base path to west.h5 files. As long as the same path is available on the remote workers, everything is fine.
This is in contrast to assuming the relative path is available, which depends entirely on the working directory of your Ray workers (and probably isn't generally true)


Add back quick submit button (with draft work around explanation on content chooser page)

Add a grey box with the following text at the top of the content chooser page, and put the quick submit button back on the site:

We apologize that due to spam bot attacks, the publishing and editing features on our platform are not currently available. We are working on a solution. In the meantime, if you would like to publish your entry as a draft, here is how you may do so:
Anyone can create draft entries and use the preview feature to review them. Draft entries are saved automatically. Drafts show up on your profile page under the 'drafts' tab, and also on this page below the content type selection options. There is a 'preview' button at the bottom of all entry forms, beside the temporarily disabled publish button.
Students taking courses can do an entry as a draft, then create a temporary password on their account so that teachers can login and use the preview feature to mark their draft entries.
All drafts can be published quickly once the site is back to normal.
Please direct any questions to<EMAIL_ADDRESS>

@paninee this was the main take away from the meeting with Bonny today. He'd like us to add this as soon as possible, when you are back at work. Thanks!


Retry request on error

I have a React HTTP server that has a persistent connection to a MongoDB server. When the MongoDB server restarts, the React HTTP server still has the old connection in memory. When a request comes in, React gives an http->on('error', ...) error.
I want to listen for this error, correct the MongoDB connection, & resend the request, which will use the new connection & not error out the second time.
I try to do:
 $http->on('error', function (Exception $error) use ($request, $response, $other_variables) {
    $error_message = $error->getMessage();
    // Recover from MongoDB connection errors.
    if (strpos($error_message, 'ailed to send') !== FALSE || strpos($error_message, 'o suitable servers') !== FALSE || strpos($error_message, 'onnection closed') !== FALSE) {
      // Establish new MongoDB connection.
      mongodb();
      // Retry the request.
      daemonchild_finish($request, $response, $other_variables);
    }
  });

However, it appears the $request & $response that are available in the other $http listeners are not available in the error listener, for when I pass them into a function to resend the request (the same function I use in the 'end' listener to handle the request/response when there are no errors) I get the following error:
|Error: Call to a member function writeHead() on null in {closure}()
That's $response->writeHead($status_code, $output_headers);, so $response is null when I try to pass it into the function, but it's available in the other listeners.
Is there any way to access the request & response objects inside the 'error' listener?

I think you are mixing a few things here.
An error event will be emitted by the server if the request of the client is invalid.
A Response object will be emitted via the request event, not on an error event. If an error occures the request event will never be emitted.
I hope this helps.

It's quite likely I am mixing something up.
However, if the MongoDB server has been restarted, & then a client make a valid request that normally works, & I get an error in the error listener. I log the error in that listener. Why would that be? The error is: Failed to send "find" command with database "example": socket error or timeout'
Thanks for your help.


Use browserify to handle browser-specific code

Remove lib/index.js and rename lib/node.js to lib/index.js

We need to have an ability to specify the entry point in bitcore-build, it will use the index.js file.

Coverage increased (+0.19%) when pulling dfbdedfd52ac9778a1945e347184543ce651e0b7 on yemel:browserify into 2bb12c1f27ca1c79cbcb1a3f2884f47538e9953d on bitpay:master.

Coverage increased (+0.19%) when pulling abbe879512b2250f81e4c3569995c3da4786ad73 on yemel:browserify into bce05d86f78d77b95a442bf8d4f78fdbcc8b08cc on bitpay:master.

LGTM


Add linuxArm64 target

This PR adds the linuxArm64 target. It's compiled on CI, but not tested to run, which is in line with its Tier 2 support
Fixes #146

@FirstTimeInForever Could you please provide some input on this PR? Thanks


Arrow comparison LIKE/ILIKE/NLIKE kernels do not escape all special characters

Describe the bug
Characters such as [ and . are sometimes treated as regular expressions rather than literals in regular expressions
The arrow regular expression kernels such as like_utf8 https://github.com/apache/arrow-rs/blob/master/arrow/src/compute/kernels/comparison.rs#L311-L323 take limited SQL style string matching patterns (e.g. %).
However, under the covers a regular expression matching library is used but special regular expression characters are not escaped. @ovr  added code to handle ( and ) in https://github.com/apache/arrow-rs/pull/1042 but there are other special characters as well
To Reproduce
    let array: StringArray = vec!["foo", "bar", "baz"]
        .into_iter()
        .map(Some)
        .collect();

    let comparison = arrow::compute::like_utf8_scalar(&array, "foo%.*").unwrap();

    let expected: BooleanArray = vec![false, false, false]
        .into_iter()
        .map(Some)
        .collect();

    assert_eq!(comparison, expected);

Expected behavior
This test should pass (is what postgres produces)
alamb=# select * from foo;
  x
-----
 foo
 bar
 baz
(3 rows)

alamb=# select x, x like 'foo%.*' from foo;
  x  | ?column?
-----+----------
 foo | f
 bar | f
 baz | f
(3 rows)

Additional context
Follow on to https://github.com/apache/arrow-rs/pull/1042 where @ovr  fixed the parenthesis issue

@jwdeitch  suggests the use of escape here: https://github.com/apache/arrow-rs/pull/1042#discussion_r768188149

Fixing this bug is likely a matter of using the code suggested by @jwdeitch  and writing some tests. 🙏  thank you to whoever picks it up

I am working on this - was annoyed by this already. Using escape seems like a great solution.


Remove deprecated code for 3.0

There are numerous parts of the code that are marked with [Obsolete] attributes. Additionally there is code that may or may not any longer be in use, such as NDC (src/log4net/NDC.cs). Ideally with the major version change the deprecations should be removed.

I agree with removing the obsolete classes and methods.
I'm not sure about NDC. Looking at the code it seems to be explicitly un-deprecated and there are many uses
https://github.com/search?q=NDC.Push+path%3A*.cs+language%3AC%23&type=Code&ref=advsearch&l=C%23&l=
The class is just a wrapper around ThreadContext.Stacks["NDC"], so the gain for removing it would be small against the anger we could cause ;-)
When we DO want to remove it, we would do it later and first mak it (again) as deprecated.
@fluffynuts what do you think?

I agree - something marked [Obsolete] can go, something that still works, even if it's only for a few users, can stay. And we should be very judicial about deprecations - I'd much rather keep the library useful for as many people as possible, so even if some part looks unused, if it works, leave it in until there's no other option but to lose it.

OK. I would propose releasing the first 3.0.0 preview with the obsolete classes, so that we could deploy this version in our company and to other "willing" users. Then we remove those classes in the next preview for 3.0.0.

Deleted obsolete API:

obsolete since 1.2.14 - 2015

log4net.Appender.BufferingAppenderSkeleton.OnlyFixPartialEventData
log4net.Appender.ColoredConsoleAppender.ctor(ILayout)
log4net.Appender.ColoredConsoleAppender.ctor(ILayout, bool)
log4net.Appender.ConsoleAppender.ctor(ILayout)
log4net.Appender.ConsoleAppender.ctor(ILayout, bool)
log4net.Appender.DebugAppender.ctor(ILayout)
log4net.Appender.EventLogAppender.ctor(ILayout)
log4net.Appender.FileAppender.ctor(ILayout, string)
log4net.Appender.FileAppender.ctor(ILayout, string, bool)
log4net.Appender.MemoryAppender.OnlyFixPartialEventData
log4net.Appender.SmtpAppender.LocationInfo
log4net.Appender.TextWriterAppender.ctor(ILayout, Stream)
log4net.Appender.TextWriterAppender.ctor(ILayout, TextWriter)
log4net.Appender.TraceAppender.ctor(ILayout)
log4net.Config.DOMConfigurator
log4net.Config.AliasDomainAttribute
log4net.Config.DomainAttribute
log4net.Config.DOMConfiguratorAttribute
log4net.Core.LoggerManager.GetLoggerRepository
log4net.Core.LoggerManager.CreateDomain
log4net.Core.LoggingEventData.TimeStamp
log4net.Core.LoggingEvent.GetExceptionStrRep
log4net.Core.LoggingEvent.FixVolatileData
log4net.LogManager.GetLoggerRepository
log4net.LogManager.CreateDomain

obsolete since 2.0.6 - 2016

log4net.Util.SystemInfo.ProcessStartTime


RFE: wording change to Inf in the documentation

#https://docs.perl6.org/type/Num#Inf
Proposed addition to "Inf":
 The "value" Inf (Infinity) represents "without bound" or  "no limit" (meaning "all possible values") when used as an argument.  It is typically used in as an argument in routines where it represents "everything" or " no bounds", depending on the context that it is used.

Proposed removal:
 The value Inf is an instance of Num and represents value that's too large to represent in 64-bit
 double-precision floating point number (roughly, above 1.7976931348623158e308 for positive
 Inf and below -1.7976931348623157e308 for negative Inf) as well as returned from certain
 operations as defined by the IEEE 754-2008 standard.

Reason:
In the "context" that "Inf" is for in Perl 6, it falls into the category of "unicorns":  things that do not really exist.  "Inf" shares this with "Nil".  The proposed addition will quickly clue the reader into what "Inf" actually is used for.  It also conforms to the mathematical definition of "infinity".
The removed text is just a distraction and not actually even how Inf (or Nil) is used in Perl.  (Inf is used with string too and other things too.)  Leave the definition of how to create numbers to the developers.   Including this only confuses the reader.

It represents "no limits" independently of being used as an argument.
The current definition could be (slightly) improved by grounding it to the common, or mathematical, definition, but I fail to see how a precisely worded definition as it is now would help anyone.

On 10/2/18 11:14 PM, Juan Julián Merelo Guervós wrote:

It represents "no limits" independently of being used as an argument.
The current definition could be (slightly) improved by grounding it to
the common, or mathematical, definition, but I fail to see how a
precisely worded definition as it is now would help anyone.

That is one of those "if you already know it, you don't need
to know it, again".  Don't always presume everyone knows what
they are doing when they are looking for wisdom.  Picture me
in your mind when you are trying to figure out if you have
given enough of an explanation.
The mathematical definition was what make me realize what you
guys were getting at. And you know me, I can be thick as a rock
at times.  So, if it worked for me, it should work for most
everyone else arriving there looking for wisdom.
And the definition of an over-run real number really confused things.
A little off the subject, but since you told me ~70% are coming from
Perl 5 to Perl 6, don't always presume they realize everything starts
counting from zero.  (p5's m/ starts at $1)


Do we get comments from ohm?

I try to get comments on code, but its CST looks like can't get these.

Comments should definitely be included in your CST. Unfortunately, without seeing at least a snippet from your grammar, I can't tell you what's going on.
A common thing for people to do is to extend the space rule with whatever syntax they have for comments. As an example:
  space
   += comment

  comment
    = "/*" (~"*/" any)* "*/"  -- multiLine
    | "//" (~"\n" any)*       -- singleLine

Here, you'd be able to get to the comments by writing semantic actions for comment_multiLine and comment_singleLine.
Hope that helps!

Comments should definitely be included in your CST. Unfortunately, without seeing at least a snippet from your grammar, I can't tell you what's going on.
A common thing for people to do is to extend the space rule with whatever syntax they have for comments. As an example:
  space
   += comment

  comment
    = "/*" (~"*/" any)* "*/"  -- multiLine
    | "//" (~"\n" any)*       -- singleLine

Here, you'd be able to get to the comments by writing semantic actions for comment_multiLine and comment_singleLine.
Hope that helps!

Now I set this:
    ProgramItem = Struct
                | Contract
                | Primitive
                | StaticFunction
                | NativeFunction
                | ProgramImport
                | Trait
                | Constant
                | Comment

    Statement = StatementLet
              | StatementBlock
              | StatementReturn
              | StatementExpression
              | StatementAssign
              | StatementAugmentedAssign
              | StatementCondition
              | StatementWhile
              | StatementRepeat
              | StatementUntil
              | StatementTry
              | StatementForEach
              | Comment
    // Comments
  lineTerminator = "\n" | "\r\n" | "\r" | "\u2028" | "\u2029"
  Comment = MultiLineComment | SingleLineComment | SingleLineDocComment | SingleLineImportantComment
  MultiLineComment = "/*" (~"*/" any)* "*/"
  SingleLineComment = "//" ~(("!" | "/") any) (~lineTerminator any)*
  SingleLineDocComment = "///" (~lineTerminator any)*
  SingleLineImportantComment = "//!" (~lineTerminator any)*

Then set it:
semantics.addOperation<ASTNode>('resolve_program_item', {
   MultiLineComment(_open, commentText, _close) {
       return createNode({
           kind: 'multiLineComment',
           value: commentText.sourceString.trim(),
           ref: createRef(this),
       });
   },
   SingleLineComment(_open, commentText) {
       return createNode({
           kind: 'singleLineComment',
           value: commentText.sourceString,
           ref: createRef(this),
       });
   },
   SingleLineDocComment(_open, commentText) {
       return createNode({
           kind: 'singleLineDocComment',
           value: commentText.sourceString.trim(),
           ref: createRef(this),
       });
   },
   SingleLineImportantComment(_open, commentText) {
       return createNode({
           kind: 'singleLineImportantComment',
           value: commentText.sourceString.trim(),
           ref: createRef(this),
       });
   },

But finally got the result:
{
 id: 3,
 kind: 'program',
 entries: [
   {
     id: 1,
     kind: 'multiLineComment',
     value: 'This is a multi-line comment',
     ref: ASTRef {}
   },
   {
     id: 2,
     kind: 'singleLineComment',
     value: 'This is a single line comment\n' +
       '                    //! This is a single line important comment\n' +
       '                    /// This is a single line doc comment\n' +
       '            fun testFunc(a: Int): Int {\n' +
       '                let b: Int = a == 123 ? 1 : 2;\n' +
       '                return b;\n' +
       '            }',
     ref: ASTRef {}
   }
 ]
}

Please take a look at this page, which discusses the difference between syntactic and lexical rules: https://ohmjs.org/docs/syntax-reference#syntactic-lexical
Your comment rules are syntactic (their names begin w/ a capital letter) which means they're implicitly skipping spaces. I don't think that's what you want.
(The idiom that I showed you in my first message, where you extend the space rule is a good one to use for this sort of thing.)

Please take a look at this page, which discusses the difference between syntactic and lexical rules: https://ohmjs.org/docs/syntax-reference#syntactic-lexical
Your comment rules are syntactic (their names begin w/ a capital letter) which means they're implicitly skipping spaces. I don't think that's what you want.
(The idiom that I showed you in my first message, where you extend the space rule is a good one to use for this sort of thing.)

I use this:
Comment {
    space += comment
    comment = "//" (~lineTerminator any)* -- singleLine
        | "/*" (~"*/" any)* "*/"  -- multiLine
    lineTerminator = "\n" | "\r\n" | "\r" | "\u2028" | "\u2029"
}

But it still throw error:
const grammar = rawGrammar.createSemantics();
            const semantics = grammar.addOperation('extractComment', {
                comment(arg0) {
                    return arg0.sourceString;
                },
            });
            const matchResult = rawGrammar.match(`// This is a single line comment
1211
            const a = 1;
            `);
            if (matchResult.failed()) {
                console.log('Error:', matchResult.message, matchResult.shortMessage);
            }
            const comment = semantics(matchResult).extractComment();

I'm trying to process comments too, and I'm a bit baffled by the comments from @alexwarth: as far as I can tell, anything under space is skipped, as per the comment in #448; certainly, whatever I do I can't seem to get a rule for a comment that is itself part of space to trigger.


[fix/aut945] Chromatogram/Spectrum: Handled too much points to display…

[fix/aut945] Chromatogram/Spectrum: Handled too many points to display error

instead of returning success, the session handler method set the error in the result data structure, which makes it more convenient to use from the widgets.
Also the number of point as been decreased (it was 9000 but I had the exception from around 6800
In this PR also, c++ 17 is enabled since OpenMS now requires it

Seems that OpenMS requires now C++17, I think it looks okay

yes, compiles now, and just in case i launched and test the app. no problem


Add sentiment results to view all comments page

As a user I want the ability to see the sentiment results on the view comments page with the option to overwrite in case the model prediction does not look correct. This will help to measure the model accuracy at any point in time by comparing the model output to the overridden records.
Please refer below designs:
https://xd.adobe.com/view/65ea110d-ea8c-496c-919b-10e890cdea9e-30b9/screen/6771d552-b63a-4ae3-a238-354adad0e184/
https://xd.adobe.com/view/65ea110d-ea8c-496c-919b-10e890cdea9e-30b9/screen/dba613d7-059a-4e52-be78-61feeabd9b57/

Hey team! Please add your planning poker estimate with Zenhub @djnunez-aot @jadmsaadaot @saravanpa-aot @VineetBala-AOT

Please refer to this card if anyone wants to complete Sentiment Analysis stories.


itest: refactor, add more assertions

This PR adds more assertions after refactoring out some common code.
The new assertions discovered the following bugs:

https://github.com/lightninglabs/taproot-assets/pull/984
https://github.com/lightninglabs/taproot-assets/issues/985

Made this PR to fix the import issue: https://github.com/lightninglabs/taproot-assets/pull/987
Will update this with the latest commit to rerun the itests.


Commands Other Than /seedcracker cracker Not Working

When entering commands other than /seedcracker cracker it will automatically default to an general Minecraft "command not valid message in chat" and after installation basic features also stopped working like Xray. Rendering the mod useless I saw that the 1.19 version works for 1.19x as well which should mean it works for 1.19.3 as well but light loader for that version 1.19 specifically does not load any mods. Even after tinkering either it is a versional issue or a broader issue in unknown to me. Please either patch this or release a newer version for 1.19.3
Thee-Aweseomeman

There is a version for 1.19.3 -_-


staggered pinky like kyria with kailh choc

staggered pinky like kyria. it can turn out to take as a basis?
will it be possible to use kailh choc without hot swap for this keyboard which is based on the crkbd (I would try to do it myself - but I have no knowledge) ?

and can you explain what these holes are for?

@foostan maybe it won't take you long

In your first picture, no, that will require redesign for choc specific sockets.
In your second picture, the 3 holes you have circled are for MX, Alps, and the rightmost is the extra leg for choc v2 switches.

In your first picture, no, that will require redesign for choc specific sockets.

Is it possible, on the basis of the second board, to make a staggered for the pinky as in the first photo? (no sockets - to solder the switch to the board)

It wouldn't be a crkbd then...
Its open source for a reason :) modify away.

It wouldn't be a crkbd then...

I wore here because I like crkbd) but I would like a little improvement

Its open source for a reason :) modify away.

I have no knowledge (

I would invite you to come and talk on the low profile keyboards server, we have a #design channel https://discord.gg/69UM9sQF8q

I would invite you to come and talk on the low profile keyboards server, we have a #design channel https://discord.gg/69UM9sQF8q

oh, interesting. I'll take a look)

@rnPlanet Thank you for sharing your design, I hole you challenge yourself to design your own 👍
@keyboard-magpie Thank you for everything 🙏

I hole you challenge yourself to design your own

thanks😁  could you look with one eye and tell me if it will work?) https://github.com/pashutk/chocofi/pull/2, @keyboard-magpie or maybe you have knowledge)