ENH: Podman Pod commands

Libpod now has the ability to create and manage pods. We'd like to expose this through the Podman CLI to allow the management of pods. Our proposed command line is described below
Creating and joining pods

Pods are created and joined like containers, via podman run
To create a new pod: podman run --pod new
To create a new pod with a specific name: podman run --pod new=a_specific_name
To join an existing pod by name or ID: podman run --pod pod:name_or_id
To join the pod of an existing container: podman run --pod ctr:name_or_id

Managing pods

We will add a podman pod subcommand with several management commands under it
To list pods, podman pod list (or perhaps podman pod ps?)
To start all containers in a pod: podman pod start name_or_id
To stop all containers in a pod: podman pod stop name_or_id
To send a signal to all containers in a pod: podman kill name_or_id signal

Open Questions:

Does creating empty pods make sense? Do we need a podman pod create command?

My initial feedback:

on creating a new pod with run, i would drop the "new" and if the pod doesn't exist, we create it.
to join an existing pod, just give the name or id

I'm also having second thoughts on the pod subcommand. I think it would be cool if podman could take the responsibility of determining if it is a pod or container away from the user.  What would you think if we did something like:
podman start pod_name|pod_id|container_name|container_id

but also added a --type pod|container for name collision?
And that abstraction would be applied to the rest of the pod commands?

Name collision shouldn't be an issue, names and IDs have to be globally unique - no pod and container can share a name or ID.

On reusing start/stop/kill: I wouldn't mind it. It has the advantage of simplicity.

Yes I like that idea.  The tough one is run, but that could take a pod command
podman run --pod new -ti fedora sh
Would create a new pod with a container attached.
If we use --pod new --name test
Would we create a name for the pod as test_pod?
podman run --pod UUID -ti fedora sh
podman run --pod test_pod -ti fedora sh
Would join the new container to the existing POD

I think the arguement to the pod would be used like:

if now pod exists named that, it would create it.
if a pod with that name exists, it will run the container there.

Does urfave/cli support flags with optional arguments? I can see things working like this:

--pod to make a new pod with a randomly-generated name
--pod NAME to make a new pod with the given name, or join the given pod if it exists
--pod-from CONTAINER to join the pod from another container

The only potential issue would be not knowing for sure whether you created or joined a pod with --pod NAME -- maybe hvae a --pod-join ID flag that will only join and error if the pod doesn't exist?

I would rather have a keyword like "new" or "scratch" to give --pod to cause it to create a new pod.
I really don't want additional options.  And I don't want pod to magically get created on a typo.

+1 to the scratch idea.  I was looking for that the other day.

Bumping this up.
@haircommander PTAL

@haircommander Are there remaining open items for this issue or can we close it? I am under the impression that all desired functionality has been implemented but I may be totally wrong :)

@vrothburg pod top is the last one and should be done today! I'll close once it's upstream

Should be good to close via https://github.com/containers/libpod/pull/1298 !


Clarify the number of bugs

Can you also please update the script that produces the table.
To make this more discoverable in the future, we probably want to either (1) add a footnote for the generated table, indicated how it was generated, or (2) document the process of updating it in a dedicated developer documentation.
I don't have a strong preference, but (1) could be accomplished in this PR. For (2), we should tack an issue for now.

@rjust Done (including non-user-visible footnote, which serves as documentation).


Form styling

changed the tweeki.css and timeless.css overwrites according to co-site's guide
header image and fonts should work once they're uploaded (see #24 )

--

@baillyk is it possible to set the default skin to the one the Wkadmin account uses (Timeless)? right now users who aren't logged in see the tweeki skin, which has a few things not yet styled -- i can change them of course, but maybe we don't need two styles anyway

Hi @calnfynn - Can you add some styling to the following form: https://climatekg.semanticclimate.net/index.php?title=Begriff_hinzufügen
It needs spacing and alignment. Importantly the Description field needs to be made much larger - it can fit 400 characters in the end.
How the form looks here is good. https://climatekg.semanticclimate.net/index.php?title=Annotated_Texts
Would this be OK for you to do?


client send 2 clienthello.

Your environment.

Version: b4bc4798b938775e640c7d70d9c877c1096c24d0
Browser: chrome 71.0.3578.98
Other Information - use sfu-ws example

What did you do?

click the publish button
What did you expect?
There will be one client hello
What happened?
There are 2 client hello in wireshark. Maybe the timer bug.

some log
dtls-package TRACE: 19:20:53.007194 client_handlers.go:202: flight1
dtls-package TRACE: 19:20:53.007248 client_handlers.go:205: flight3
(string) (len=44) "----------------send client hello-----------"
dtls-package TRACE: 19:20:53.017797 client_handlers.go:23: ServerHello
dtls-package TRACE: 19:20:53.017888 client_handlers.go:205: flight3
(string) (len=44) "----------------send client hello-----------"

Any suggestion？

Also seeing this on v1.3.3

sending a ClientHello during flight3 isn't an issue currently (@maxhawkins sending a malformed one is though)

During flight3 we send a ClientHello every second until the client has enough state to move onto flight5

If the server sends a handshakeTypeHelloVerifyRequest we also should send a ClientHello but with a Cookie and increment the local SequenceNumber once.

@maxhawkins your issue is that the SequenceNumber was improperly incremented. The only time it should be 1 during a flight3 is when we have a cookie. The possible bugs that could be happening here.

Incorrectly assuming a packet is a handshakeTypeHelloVerifyRequest
Incrementing the SequenceNumber used by ClientHello (a race or just bad logic)

It seems not an issue. Closed for now


refine behavior of mock mode

@karima662 can you please test this against the most recent dev {tfrmt}. Things to try:
- tfrmtbuilder(tfrmt = NULL, data, mockmode = TRUE/FALSE)
- tfrmtbuilder(tfrmt, data = NULL, mockmode = TRUE/FALSE)
- tfrmtbuilder(tfrmt, data, mockmode)


Investigate the idea of modules that are not files

Complex modules can be a folder that has all the dependencies as part of the module directory. The entry point of such module should be an 'exec' script. Can bundle dependencies of the module as part of its directory.
Requires changes in the executor to figure out if the module being executed is a file or a directory.

Right now we are using a tar and untar method.
Current implementation issues:

modules folder is created in ${HOME}/.henchman (maybe move all modules to a module folder?)
does not work with current local: true implementation

Rsync

Current implementation of using Tar will not work with multiple hosts.

Issue fixed.  Modules with .tar were being removed/created at the "same time".  Need to find a way to clean up tar modules after a plan finishes executing.

Moving all necessary modules to all remote machines before plans are even executed.  plan.Setup() does this.


openjdk-bin update sources.json

11.0.16 -> 11.0.17,
11.0.14 -> 11.0.17,
17.0.4 -> 17.0.5,
17.0.2 -> 17.0.5,
8.0.345 -> 8.0.352,
8.0.322 -> 8.0.352
Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[ ] Fits CONTRIBUTING.md.

This PR rebuilds a lot of packages which means we must target staging. Please follow the contributing guide to not potentially ping a lot of people.

As no one wanted to review this here for a long time, #237667 sneaked by and deprecated this PR


Missing alr build step either in instructions or in Makefile

Using Alire 2.0.1 and following the steps in the development guide I got these errors:
mgr@mgr-B50-80:~/src/github/AdaCore/RecordFlux$ make install_devel
gprbuild -p -j0 -Pgenerated/librflxlang.gpr \
	-XLIBRARY_TYPE=static-pic \
	-XLIBRFLXLANG_LIBRARY_TYPE=relocatable \
	-XLIBRFLXLANG_STANDALONE=encapsulated
librflxlang.gpr:6:06: imported project file "gnatcoll" not found
gnatcoll_gmp.gpr:24:06: imported project file "gnatcoll" not found
gnatcoll_gmp.gpr:24:06: imported by "/home/mgr/src/github/AdaCore/RecordFlux/generated/gnatcoll-bindings/gmp/gnatcoll_gmp.gpr"
gnatcoll_gmp.gpr:24:06: imported by "/home/mgr/src/github/AdaCore/RecordFlux/generated/librflxlang.gpr"
gnatcoll_gmp.gpr:45:43: unknown package or project "Gnatcoll"
gnatcoll_iconv.gpr:24:06: imported project file "gnatcoll" not found
gnatcoll_iconv.gpr:24:06: imported by "/home/mgr/src/github/AdaCore/RecordFlux/generated/gnatcoll-bindings/iconv/gnatcoll_iconv.gpr"
gnatcoll_iconv.gpr:24:06: imported by "/home/mgr/src/github/AdaCore/RecordFlux/generated/librflxlang.gpr"
gnatcoll_iconv.gpr:45:43: unknown package or project "Gnatcoll"
langkit_support.gpr:1:06: imported project file "gnatcoll" not found
langkit_support.gpr:1:06: imported by "/home/mgr/src/github/AdaCore/RecordFlux/generated/langkit/langkit/support/langkit_support.gpr"
langkit_support.gpr:1:06: imported by "/home/mgr/src/github/AdaCore/RecordFlux/generated/librflxlang.gpr"
gprbuild: "generated/librflxlang.gpr" processing failed
make: *** [Makefile:212: generated/lib/relocatable/dev/librflxlang.so] Error 4

The problem was, that the project files did not exist in the directories present in GPR_PROJECT_PATH generated by Alire in the eval $(make printenv_gnat) step.
To continue building, I had to run:
cd build/alire
alr build
cd -
make install_devel
``

Thank you for the report! This problem is caused by a behavior change in Alire 2.0. It worked fine with previous Alire versions. We will update the Makefile accordingly.

Apparently, some of the steps done for working around #1300 has solved this problem and now make parser and make test pass, so maybe it was my problem understanding the steps in the development guide.
make test has ended with this error, by the way:
  + Exception ignored in: <module 'threading' from '/usr/lib/python3.10/threading.py'>
  + Traceback (most recent call last):
  +   File "/usr/lib/python3.10/threading.py", line 1537, in _shutdown
  +     atexit_call()
  +   File "/usr/lib/python3.10/concurrent/futures/process.py", line 93, in _python_exit
  +     thread_wakeup.wakeup()
  +   File "/usr/lib/python3.10/concurrent/futures/process.py", line 79, in wakeup
  +     self._writer.send_bytes(b"")
  +   File "/usr/lib/python3.10/multiprocessing/connection.py", line 200, in send_bytes
  +     self._send_bytes(m[offset:offset + size])
  +   File "/usr/lib/python3.10/multiprocessing/connection.py", line 411, in _send_bytes
  +     self._send(header + buf)
  +   File "/usr/lib/python3.10/multiprocessing/connection.py", line 368, in _send
  +     n = write(self._handle, buf)
  + OSError: [Errno 9] Bad file descriptor
======================================================================== 1 failed, 10 passed, 25 warnings in 19.62s =========================================================================
make: *** [Makefile:432: test_end_to_end] Error 1

The original issue has been fixed in f9ce6841824629552c60a8e3e46159ff5411022b. If you can reproduce the issue with the current main, please reopen this ticket.
The error for make test is a transient error which we only have seen a couple of times in our CI so far. The error shouldn't occur if you rerun the tests. It looks like a bug in Python's multiprocessing implementation. Unfortunately, we were not able to reproduce the error locally. If you can reproduce it, please open a new ticket.

I rerun make test and the former problem was not reproduced. It ended in this way:
===================================================== 50 failed, 2959 passed, 20 skipped, 1 xfailed, 30 warnings in 1096.09s (0:18:16) ======================================================
make: *** [Makefile:447: test_optimized] Error 1

I don't know if that is expected or not, so I simply put this message here for your information. I can open a new ticket if desired.


released apk

Hash key generated is not working for released apk. Do we have different keys for released and debug mode. What changes in program we need to make to get the key for released mode.

I'm also facing the same issue. I've generated the haskey using AppSignatureHelper class and it is working fine in release mode also. But when I downloaded the apk from playstore, it is not working

Go to build gradient ->and change debugging mode to release mode -> now again run the code and you will get a new key.

keep log for playstore build and check hash key generated.Because signed apk,debug apk and playstore build apk have different hash keys.Give that hash key of playstore build to backend folks.

Yeah this is working for me....

@PemmasaniRajesh Are you generating Hash key using  AppSignatureHelper class ?

I'm facing the same issue. It is working fine in debug build as I'm using AppSignatureHelper for hash key. I used the following command to generate the hash for signed build:
keytool -exportcert -alias MyAndroidKey -keystore MyProductionKeys.keystore | xxd -p | tr -d "[:space:]" | echo -n com.example.myapp cat | sha256sum | tr -d "[:space:]-" | xxd -r -p | base64 | cut -c1-11`
But SMS is not getting auto retrieved. Is there any solution for the issue?

I'm facing the same issue. It is working fine in debug build as I'm using AppSignatureHelper for hash key. I used the following command to generate the hash for signed build:
keytool -exportcert -alias MyAndroidKey -keystore MyProductionKeys.keystore | xxd -p | tr -d "[:space:]" | echo -n com.example.myapp cat | sha256sum | tr -d "[:space:]-" | xxd -r -p | base64 | cut -c1-11`
But SMS is not getting auto retrieved. Is there any solution for the issue?

Use this ruby script and get hash key it worked fine for me
https://github.com/michalbrz/sms-retriever-hash-generator/blob/master/google_play_sign.rb

Facing same issue the API is working fine for release and debug build and does not work when i downloaded from Play Store.

I am using SMS API for read OTP, I have uploaded build on play store and install in mobile from play store, first time message was not read but when i kill application and  run again it is work, Why?

I'm facing the same issue. It is working fine in debug build as I'm using AppSignatureHelper for hash key. I used the following command to generate the hash for signed build:
keytool -exportcert -alias MyAndroidKey -keystore MyProductionKeys.keystore | xxd -p | tr -d "[:space:]" | echo -n com.example.myapp cat | sha256sum | tr -d "[:space:]-" | xxd -r -p | base64 | cut -c1-11`
But SMS is not getting auto retrieved. Is there any solution for the issue?

Use this ruby script and get hash key it worked fine for me
https://github.com/michalbrz/sms-retriever-hash-generator/blob/master/google_play_sign.rb

How to run this file?

Change the build variant setting to release mode and regenerate your key.
Use this key for verification and everything will work fine.
On Wed, Mar 27, 2019, 5:10 PM Taufik Hussain<EMAIL_ADDRESS>wrote:

I'm facing the same issue. It is working fine in debug build as I'm using
AppSignatureHelper for hash key. I used the following command to generate
the hash for signed build:
keytool -exportcert -alias MyAndroidKey -keystore
MyProductionKeys.keystore | xxd -p | tr -d "[:space:]" | echo -n
com.example.myapp cat | sha256sum | tr -d "[:space:]-" | xxd -r -p |
base64 | cut -c1-11`
But SMS is not getting auto retrieved. Is there any solution for the issue?
Use this ruby script and get hash key it worked fine for me
https://github.com/michalbrz/sms-retriever-hash-generator/blob/master/google_play_sign.rb
How to run this file?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/googlesamples/android-credentials/issues/30#issuecomment-477111777,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AbPHx4UfeXeFH2_YtcLJ6NwUW0bnER9fks5va1izgaJpZM4ZVxqA
.

Change the build variant setting to release mode and regenerate your key. Use this key for verification and everything will work fine.
…
On Wed, Mar 27, 2019, 5:10 PM Taufik Hussain @.***> wrote: I'm facing the same issue. It is working fine in debug build as I'm using AppSignatureHelper for hash key. I used the following command to generate the hash for signed build: keytool -exportcert -alias MyAndroidKey -keystore MyProductionKeys.keystore | xxd -p | tr -d "[:space:]" | echo -n com.example.myapp cat | sha256sum | tr -d "[:space:]-" | xxd -r -p | base64 | cut -c1-11` But SMS is not getting auto retrieved. Is there any solution for the issue? Use this ruby script and get hash key it worked fine for me https://github.com/michalbrz/sms-retriever-hash-generator/blob/master/google_play_sign.rb How to run this file? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#30 (comment)>, or mute the thread https://github.com/notifications/unsubscribe-auth/AbPHx4UfeXeFH2_YtcLJ6NwUW0bnER9fks5va1izgaJpZM4ZVxqA .

I have changed build variant but getting same issue first time message was not read but when i kill application and run again its work why??
If i am wrong please suggest me.

keep log for playstore build and check hash key generated.Because signed apk,debug apk and playstore build apk have different hash keys.Give that hash key of playstore build to backend folks.

First time message was not read but when i kill application and run again its work why??

keep log for playstore build and check hash key generated.Because signed apk,debug apk and playstore build apk have different hash keys.Give that hash key of playstore build to backend folks.

Yeah this is working for me....

@PemmasaniRajesh Are you generating Hash key using AppSignatureHelper class ?
I am using AppSignatureHelper to generate hash and facing the same issue.any suggestions? I'm kind running late from my deadline!

Yes, I'm using the AppSignatureHelper class only....

Yes, I'm using the AppSignatureHelper class only....

does it work for you?

Yup....

I'm using this link to generate a app hash. https://github.com/googlesamples/android-credentials/blob/master/sms-verification/android/app/src/main/java/com/google/samples/smartlock/sms_verify/AppSignatureHelper.java. am i missing something?.Since this implementation is working on release and debug app but not the app downloaded from playstore.

Yeah, I'm also using the same class. I don't know how you're generating the hashkey in release mode.
The hashkey is different for release build and playstore build. First release the app in playstore by generating the hashkey in some screen of your app as toast message.  Once you download the app from playstore, you can get the hashkey and save it. After this, release the app once again in playstore with the new hashkey.

I'm using this link to generate a app hash. https://github.com/googlesamples/android-credentials/blob/master/sms-verification/android/app/src/main/java/com/google/samples/smartlock/sms_verify/AppSignatureHelper.java. am i missing something?.Since this implementation is working on release and debug app but not the app downloaded from playstore.

I facing same issue but when i have registered my BroadcastReciever class inside AndroidManifast.xml It's working fine for me.

Yeah, I'm also using the same class. I don't know how you're generating the hashkey in release mode.
The hashkey is different for release build and playstore build. First release the app in playstore by generating the hashkey in some screen of your app as toast message. Once you download the app from playstore, you can get the hashkey and save it. After this, release the app once again in playstore with the new hashkey.
Thanks i shall try this method although i will have to create an internal release first since its also stated in the documentation that the AppSignatureHelper class has to be removed before releasing it for production.However will the keys change for alpha and production builds?

I'm not sure about this. I've tried in production only and it worked. I hope it will not change for alpha and production builds.

Yeah, I'm also using the same class. I don't know how you're generating the hashkey in release mode.
The hashkey is different for release build and playstore build. First release the app in playstore by generating the hashkey in some screen of your app as toast message. Once you download the app from playstore, you can get the hashkey and save it. After this, release the app once again in playstore with the new hashkey.

But I can't go for a sample play store release just to get the hash. Can someone help in providing an offline way to generate the hash

Guys, Found the perfect solution for the issue "SMS retriever API is working for release build but not for the app downloaded from the play store"
This is because of the process that Google does to sign the app. The key that you have (key.jks) is not a app sign in key rather it is an upload key to the play store console, The play store decodes the app with the upload key and signs the app again with the signing key which is stored in the play store console.
That is the reason why we are not able to use the SMS retriever API as there will be a key mismatch.
You can use this resource to download the deployment_cert.der and convert it to its jks and the use that to generate the 11 digit hash.
https://stackoverflow.com/questions/51365778/how-to-generate-11-char-hash-key-for-sms-retriever-with-google-app-signing/51375789

Guys, Found the perfect solution for the issue "SMS retriever API is working for release build but not for the app downloaded from the play store"
This is because of the process that Google does to sign the app. The key that you have (key.jks) is not a app sign in key rather it is an upload key to the play store console, The play store decodes the app with the upload key and signs the app again with the signing key which is stored in the play store console.
That is the reason why we are not able to use the SMS retriever API as there will be a key mismatch.
You can use this resource to download the deployment_cert.der and convert it to its jks and the use that to generate the 11 digit hash.
https://stackoverflow.com/questions/51365778/how-to-generate-11-char-hash-key-for-sms-retriever-with-google-app-signing/51375789

@Developer101253  Same thread solved my issue.

Add this code in your app Computing app's hash string code. then you will get hash key for a specific device (debug device). Add verbose logs for hashkey like Log.v("Hashkey ",  hash);  then upload this apk into play store after download it from store then log it you will get hash key for production apk.  Update that hash key into your server it will work

Thanks to everyone in this thread for raising this, and providing solutions. We've updated the documentation accordingly:
https://developers.google.com/identity/sms-retriever/verify#computing_your_apps_hash_string

I am closing this issue/PR, as it has been migrated to the new repo linked above in the comments. Thank you!


Added Tado SU02 and SwitchBot Bot

Added Tado SU02 (Wireless Thermostat) and SwitchBot Bot (Called woHand when imported by the SwitchBot Bluetooth integration)

Thanks


Issue 500 diagonal scroll trackpad

Issue Number: 500
Link to issue
I have added a small bit of code so that when clicking inside the calendar component it can be dragged on the X and Y axis. I restored the code from v0.21.0 and it has restored the functionality of touch pad diagonal scrolling. It does seem that on most browser you must initially move your fingers in a diagonal motion  because scrolling seems to be locked to the initial direction of scrolling per event.
To do this I turned dragStartPosition into an object containing  x and y  scroll values. I then use dragStartPosition.y to update the windows scroll position.

there seems to be a property for traditionalZoom but it doesn't seem to be needed. The traditionalScroll prop mentioned in the issue seems to be undefined

oops, this was supposed to be a draft!


It's strange on spinner.getItems()

hy jaredrummler, it's strange on getItems() methods,i fille three items on adapter but when i call getItems(), just get the two of items, so i can't use spinner.getItems.get(spinner.selectedIndex) cause get the wrong text , but spinner.getText is right. on activity is show the three of items.
can't you help me

OK, it's beacuse i use custom adapter and using spinner.setAdapter(adapter) methods, when i use spinner.setItems(List), it's work and get the three of items.... :)


Fix possible overflow when creating ip_info_json

This closes #72
JSON_IP_INFO_SIZE has been increased to a true worst-case

I also have a way over-engineered solution if you like this, but think it's too simple. https://github.com/tonyp7/esp32-wifi-manager/compare/master...Skinner927:fix-json-overflow


Scaffold-GS metrics only uses 7 scenes.

The Scaffold-GS PSNR of 28.84 is across 7 scenes, not 9 as used by the rest of the table. It should be 27.50 as reported by the HAC paper which uses all 9 scenes.
https://github.com/w-m/3dgs-compression-survey/blob/5b1b110a899c44482c2ace0758bcdfcfeba5a4bc/results/MipNeRF360.csv#L12
Screenshots from Scaffold-GS paper.

Screenshots from HAC paper.

Thanks, Jeffrey, for the report!
@paulbzm then please use the numbers from the HAC paper for Scaffold-GS in the table
@myla maybe highlight this point in the author mailing to the Scaffold-GS authors

@w-m For your awareness, I also opened this issue.
https://github.com/YihangChen-ee/HAC/issues/14

@paulbzm The HAC authors responded to my issue. You can use the new HAC numbers in the survey. Also, the Scaffold-GS numbers are likely incorrect because they do not consider MipNeRF's data factor.

Thanks again @jefequien !


Add support for Android/iOS (and react-native)

I want to add op-sqlite support for sqlite-vec. In order to do this I need to compile sqlite-vec to Android and iOS. Once that is done, bridging the functionality for react-native is 0 cost.
Takes care of #68 and #69.
Feedback is of course welcome.

I got Android running. Tomorrow I will try to compile for iOS.

Hey @ospfranco , thanks for your work here, would love to get this inside op-sqlite!
Thanks for the insight on android/ios release assets as well. This is something I want to get into the official release process, compiled on Github Actions on every release.
For android, it seems like the best approach would be new sqlite-vec-$VERSION-loadable-x86_64-linux-android.tar.gz tarballs for x86_64/aarch/armv7/i686, each with their own libsqlite_vec.so file. I can work on making some github actions for that.
For iOS, would individual xcframework files for x86_64/aarch64/sim be sufficient? I haven't made these by hand before, but they look straightforward to make.
Does this approach make sense, pubishing these tarballed .so and xcframework files to github releases? Or is there some npm package convention that react native folks use for native libraries?
I think ideally most of this code will move into Github Actions, ie not in the Makefile. Ideally we can keep the make loadable command and overwrite CC/CFLAGS as needed. But I'm definitely referencing this while I try to figure out github actions for this

@asg017 yeah, that's exactly what is needed. The github actions instead of the makefile sounds good to me.
For generating the xcframework you only need a couple of commands. You can find them in this Rust guide I created. Again the process is similar, compile the library into .a for the different architectures. Then generate a fat lib for clashing archs and then finally roll them into a single xcframework.
mkdir -p simulator_fat
  lipo -create target/x86_64-apple-ios/release/$(LIB) target/aarch64-apple-ios-sim/release/$(LIB) -output simulator_fat/$(LIB)
  xcodebuild -create-xcframework -library target/aarch64-apple-ios/release/$(LIB) -headers include -library simulator_fat/$(LIB) -headers include -output $@
  cp -r $@ ../ios/$@

I will for now compile iOS and update the makefile so you have all the commands and then close this PR.

Ok, here are more detailed compilation steps for iOS:

OMIT_SIMD=1 make ios will compile the library for all the necessary iOS archs as a dylib (forget what I said about a static .a, sqlite extensions need to be dylibs)
It is then necessary to combine x86_64 and arm64 simulators (for m1 and intel machines) into a fat lib. You might get some errors depending on which folder you run the commands, just try it creating different folders but the commands should be the same: lipo -create ./x86_64/sqlitevec ./arm64_simulator/sqlitevec -output ./sim_fat/sqlitevec
One you have the libraries you need to create a .xcframework with .frameworks inside. You can copy the structure and the plist contents from op-sqlite. Don't forget to change the bundle ID, I just used my own com.ospfranco.sqlitevec because it needs to be referenced when loading the dylib in iOS.
After you have the .xcframework (hand created is fine, no need to use CLI tools), you do need to use install_name_tool on each of the frameworks to change the rpath of the dylibs to point to themselves: install_name_tool -id @rpath/sqlitevec.framework/sqlitevec sqlitevec.framework/sqlitevec (run it for arm64 and x86_64_arm64_simulator)
Afterwards you can just publish the artifacts in github releases and it will be a matter of downloading them.

I just had a report when submitting to the app store the compiled binary does not correctly match the minOS version on the Info.plist. I might have forgotten setting the min-iOS version when compiling. I've modified the makefile to add the flag:
MIN_IOS_VERSION = 8.0

IOS_ARM64_FLAGS = -target arm64-apple-ios -miphoneos-version-min=$(MIN_IOS_VERSION)
IOS_ARM64_SIM_FLAGS = -target arm64-apple-ios-simulator -miphoneos-version-min=$(MIN_IOS_VERSION)
IOS_X86_64_FLAGS = -target x86_64-apple-ios-simulator -miphoneos-version-min=$(MIN_IOS_VERSION)

@asg017 just FYI when you publish your own artifacts

The rpath was not properly set. I've written more extensively what the process is to correctly generate an .xcframework. I saw there are now pure releases of the compiled binary but that's not enough to load sqlite-vec in iOS.
Here is the full tutorial


AL allows/suggests "Enum Name"::"First Value Name"::"Another Value Name"::"Etc"::"Etc"

Title says it all. Only "Enum Name"::"First Value Name" should be valid; the rest make no sense.
I think the last one ends up getting used, but this simply should not build, nor be suggested/autocompleted!

Name: AL Language
Id: ms-dynamics-smb.al
Description: AL development tools for Dynamics 365 Business Central
Version: 9.0.615906
Publisher: Microsoft
VS Marketplace Link: https://marketplace.visualstudio.com/items?itemName=ms-dynamics-smb.al

Thanks as always!

The fix for this issue has been checked in to the master branch. It will be available in the bcinsider.azurecr.io/bcsandbox-master Docker image starting from platform build number 22.0.47719.0 and VS Code Extension Version 11.0.693297.
If you don’t have access to these images you need to become part of the Ready2Go program: aka.ms/readytogo
For more details on code branches and docker images please read:
https://blogs.msdn.microsoft.com/nav/2018/05/03/al-developer-previews-multiple-releases-and-github/
https://freddysblog.com/2020/06/25/working-with-artifacts/


Make OTP installation optional

closes #79

@michallepicki, thanks for this. Let me check the changes and get back to you.

Only a couple minor changes and we're almost there.

Not sure what this failure is about? https://github.com/erlef/setup-beam/runs/4762594908?check_suite_focus=true

Don't worry if the build is only failing for Check if build left artifacts, since this was not introduced by you.

Not sure what this failure is about? https://github.com/erlef/setup-beam/runs/4762594908?check_suite_focus=true

It's because the 3rd party licenses we're using were updated remotely but not locally (then the action updates them, checks against what you pushed, and errors out).

I approve the current set of changes. Thanks much for your contribution 👍. I'd like to wait for @starbelly to review this, too, and maybe handle #76 before releasing a new minor.

@michallepicki You should be able to rebase and we'll get a full passing build.

I left 2 comments and 2 code change suggestions. I'd wondered about the document changes, but had thought making the option visible would only bring more confusion. As is (current pull request), it might not.

Rebased from main to resolve conflict

@michallepicki, so it's easier for me to follow up on what was request/done, resolve conversations only after you push the code changes (or even don't resolve them and let the one who opened them do). 👍

I'm re-running all actions, after which I think we're good to merge.

I believe the incomplete action runs are due to us still using ubuntu-16.04, but that's been handled in a different pull request, soon to be merged to main. I'm squash merging this, and once we have all the open pull requests merged and no more action issues we're good to release a new minor. Thanks much.

Hm... it seems I can't merge since @starbelly has requested changes and these need to be approved (I even tried to remove him as reviewer to speed this up, but no good). We'll have to wait.


Use mattn's go-isatty, go-runewidth and go-shellwords

Category

[x] fzf binary

OS

[x] Linux

I'm a big fan of fzf, and so am currently packaging fzf for Debian: https://github.com/tomfitzhenry/pkg-fzf
It's working, but there's a slight issue.
fzf depends on:

https://github.com/junegunn/go-isatty
https://github.com/junegunn/go-runewidth
https://github.com/junegunn/go-shellwords

This isn't necessarily a problem, but I noticed that:

each of those libraries is a fork: go-isatty, go-runewidth, go-shellwords
your forks seem to have no commits that aren't in upstream
upstream has commits that aren't in your forks
Debian has already packaged the three upstreams: golang-github-mattn-go-isatty-dev, https://packages.debian.org/sid/golang-github-mattn-go-runewidth-dev, https://packages.debian.org/sid/golang-github-mattn-go-shellwords-dev

Consequently does it make more sense to have fzf depend on mattn's libraries?

I just wanted to secure the correctness of the build by using my own forks. When I started rewriting fzf in Go, there was no good way to manage the dependencies and that was my choice. Theoretically, upstream repositories can make breaking changes at any time that might affect the behaviour of fzf and they can even be deleted from GitHub by their authors. By using my own forks, I can be always be sure that fzf is unaffected by such events.
I know that those events are probably not going to happen, and now I use a script (https://github.com/junegunn/fzf/blob/master/src/deps) for checking out the exact revisions, but with forks, simple go get build will always be reproducible.

Thanks for the prompt response.
I can see the benefits to depending only on your code, especially if  upstream starts making breaking changes.
But there are ways to depend on upstream, and maintain reproducible builds. Godep allows you to depend on a particular revision of a dependency, which handles the breaking change issue you mentioned. See pgweb's Godeps.json as an example.
Advantages of using mattn's packages rather than your forks:

Contributors to isatty/runewidth/shellwords will only have one
Distributions only have to package on version of isatty (if every app forked all their dependencies, that'd be a lot of packaging!)

Advantages of using Godep rather than your forks+scripts:

Contributors will be more familiar dependency management
Easier for packagers
Ability to version golang.com/x/crypto, without having to fork that
Option to use dynamic linking, thus allowing for easier security updates

Advantages of having this packaged in Debian and Ubuntu:

Exposure to more users. More users = more bugs! Err, I mean... more users = woo!
Better experience for Debian/Ubuntu users, and more likely for fzf to make its way onto production boxes. There's already been a few people interested in fzf being on Debian over the years. https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=783307
Benefit from Debian's infrastructure on Reproducible Builds (binary-bit-for-bit reproducible, rather than buildable-from-source reproducible)

What are your thoughts on these?
Are you open to a PR switching to godeps?

I would choose a proper dependency tool if I'm going to start developing fzf today so I'm open to pull requests (make sure to base it on devel branch). FYI, I tried Godeps a few months ago, but I had some issues that I was unable to resolve, so I just decided to write my own script.

Glide it is.


created homepage text on display, grabbed from api that returns hardc…

…oded set of phrases

@weslayer @steeevin88


IndexError in builder_runner.py:194, _parse_fuzz_cov_info_from_libfuzzer_logs()

Traceback (most recent call last):
  File "/experiment/experiment/evaluator.py", line 209, in check_target
    return self.do_check_target(ai_binary, target_path)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/experiment/experiment/evaluator.py", line 259, in do_check_target
    build_result, run_result = self.builder_runner.build_and_run(
                               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/experiment/experiment/builder_runner.py", line 721, in build_and_run
    run_result.semantic_check = self._parse_libfuzzer_logs(f)
                                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/experiment/experiment/builder_runner.py", line 239, in _parse_libfuzzer_logs
    initcov, donecov, lastround = self._parse_fuzz_cov_info_from_libfuzzer_logs(
                                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/experiment/experiment/builder_runner.py", line 194, in _parse_fuzz_cov_info_from_libfuzzer_logs
    initcov = int(line.split('cov: ')[1].split(' ft:')[0])
                  ~~~~~~~~~~~~~~~~~~~^^^
IndexError: list index out of range

Full experiment log available here

run log triggered this error: gs://oss-fuzz-gcb-experiment-run-logs/Result-reports/ofg-pr/2024-05-01-238-jim-comparison/results/output-hiredis-rediscommand/logs/run/04.c-F0.log
#2	INITED exec/s: 0 rss: 34Mb

Should have been fixed by https://github.com/google/oss-fuzz-gen/pull/276/files.
@cjx10 could you please double-check the latest exp log (05-19) and close this?
Thanks!

Confirm fixed, thanks Dongge :)


Fix timeout setting in milliseconds

Closes #4666

There are two way to solve #4666

S1: Keep the original help tip, make timeout multiply 1000 to fix.
S2: Correct help tip, update seconds to milliseconds, set step to 100 make user easy to use.
I choose S2 to solve this issue, S1 can only support integer seconds, it's unfreindly.

Great first PR @tangweikun hope to see more! You are eligible to receive a contributor t-shirt!
Go ahead and fill out the contributor submission form.


FIX union calculation in hungarian_miou

Hey there, we found a small bug in the calculation of the union in the hungarian_miou method.
Your code uses addition instead of sum and logical_or which results in an upper bound of 0.5 for perfect predictions. For instance, if true_oh == pred_oh, the intersections are simply the sizes of the instances and so should the unions be as well. With the addition however, you count the instance sizes twice which results in the upper bound of 0.5 in this case. An easy fix is to subtract the intersection from this calculation.
Importantly, this bug is most likely only a scaling issue and should not change published results beyond this point.
Best, Johannes

Thanks a lot for the fix! Yes, I agree the bug isn't likely to change the order of the benchmarked methods. I'll try to update the manuscript after re-running the evaluation.

Hi, the new SlotFormer result is updated in PR#8 now.


Finish "How To" guide

Finish the sections outlined in the how-to guide.

[ ] Issues and pull requests
[ ] Maintainer responsibilities
[x] Communications/Discord info

Also need to move over our more concrete how to for Rust projects here and updated them. https://github.com/EmbarkStudios/rust-ecosystem/blob/main/open-sourcing.md

Also need to update the how-to guide steps to include:

updating embark.dev
updating embark.rs
announcing on Discord (and maybe other channels like r/rust)

Don't think this is documented anywhere which @davidpdrsn ran into now with releasing tryhard

Another thing, all of our open source repos should have the EmbarkStudios / Open Source Admins added as admin to them also, this can be done at any time by an admin but nicest if the author makes sure to do this from get go so can be in the instructions as well

Example from cargo-deny:
https://github.com/EmbarkStudios/cargo-deny/settings/access

Maintenance guide is in: https://github.com/EmbarkStudios/opensource/blob/main/content/maintenance-guidelines.md
Anything else we would like to include here?

I think this is done 🚢


In Host details, pods in status "Failed" are listed first

In the Explore →Hosts view of socks-shop in WC, upon clicking on a particular host, I can see a truncated list of pods on the host in the host details dialog. All of the ones shown in the collapsed list are status: "Failed".
While this might be useful debugging information to see which ones failed in the past, it might be more reassuring to see the ones which are currently running. Expanding the list, I can see the expected list of running pods just fine.

Perhaps we shouldn't show Failed pods at all; in general Scope only shows what's running.

Nice one!


edit khi_rs013n_moveit_config/package.xml: fix version

Bloom requires that all package.xml files bear the same dotted-triplet version string.

https://github.com/Kawasaki-Robotics/khi_robot/issues/56 , since it requires a fresh bloom for the new rosdistro foxy, would require this patch.


Peer to peer backend

why not make a peer to peer backend to have asynchronous messages across machines?

That's pretty far outside the scope of this project, to be honest


Format on save undoes all changes in file

I think the logic of the plugin it to before saving to format the file. But the file that is being formatted is the one without the changes and this is what is being saved.
Probably related to the above is the fact that the undo history gets deleted for the file in question after saving, even if set hidden is present.

This might be relevant to the undo history issue
https://stackoverflow.com/questions/24690441/call-a-function-without-adding-to-undo-list
I am at my limits of vimscript here to move further.

@tterranigma Thanks for the report, and sorry about the delay in getting to this. I have just updated master (#3) with your change, and it is still working for me. I don't really know how to handle the undo history problem right now, but I have been looking at other similar plugins which also don't handle this well, so not sure how best to solve that one.
CC: @sublimino @radioinmyhead


[US] As a user, I want to consult the general ranking of players

User Story
As a user,
I want to consult the ranking of all players,
so that I can see how I rank against other players.
Expected Behavior / Acceptance criteria
When I play, my rank is updated according to my Elo score.
When I haven't played yet, my Elo score is 0 and I'm ranked ex aequo with all other not playing users
When two players have the Elo score, they're ranked ex aequo
When players are ex aequo, they're ranked by alphabetical order (simpler than the oldest record being first ?)
Additional information
No response

Not done


Window doesn't retain location and moves down on subsequent launches in Linux

Issue Type: Bug
As you can see from the GIF below, whenever I close VS Code and then open it again, it moves the position lower and lower until it finally covers my dock instead of sticking to the last window position I closed it at.

As you can expect, this is really annoying because I have to move t up every time when it shouldn't be occurring in the first place.
I don't have a multi-monitor setup either.
VS Code version: Code 1.39.2 (6ab598523be7a800d7f3eb4d92d7ab9a66069390, 2019-10-15T15:33:40.634Z)
OS version: Linux x64 4.15.0-66-generic
Extensions: none

VSCode is built on top of a large number of components that are not maintained by the VSCode team directly. This includes:

Electron as the cross platform UI framework
node.js for most integration into the OS
Chromium as runtime and rendering engine (HTML, CSS, JS)
and after all, the operating system VSCode is running on

Reading this issue, it seems to originate not from VSCode itself but rather one of these upstream components. As such, in order to resolve it, it would need to get fixed in the upstream component. I will go ahead and close this issue and kindly ask to report this issue to the upstream component if possible:

for UI, OS integration: https://github.com/electron/electron
for Rendering: https://bugs.chromium.org/p/chromium/issues/list
for file IO: https://github.com/nodejs/node

Thanks for understanding.


Add dynamic_typing optional argument to auto_declare

Need dynamic_typing for params that need to be able to be undeclared

As discussed earlier, undeclaring parameters is actually obsolete and bad-design. See ros-controls/ros2_controllers#222


Chore: Bump to 0.7.1

Description
Bump to 0.7.1
Issue ticket number
closes #xx
Additional Context

Codecov Report
Patch and project coverage have no change.

Comparison is base (0da0d51) 90.24% compared to head (74b0353) 90.24%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #257   +/-   ##
========================================
  Coverage    90.24%   90.24%
========================================
  Files          340      340
  Lines         5692     5692
  Branches       761      761
========================================
  Hits          5137     5137
  Misses         403      403
  Partials       152      152

Flag
Coverage Δ

build
89.57% <ø> (ø)

cli
75.85% <ø> (ø)

extension-authenticator-canner
78.37% <ø> (ø)

extension-dbt
97.43% <ø> (ø)

extension-debug-tools
98.11% <ø> (ø)

extension-driver-bq
85.41% <ø> (ø)

extension-driver-canner
84.65% <ø> (ø)

extension-driver-clickhouse
88.09% <ø> (ø)

extension-driver-duckdb
92.94% <ø> (ø)

extension-driver-pg
96.11% <ø> (ø)

extension-driver-snowflake
96.26% <ø> (ø)

extension-huggingface
85.71% <ø> (ø)

extension-store-canner
98.30% <ø> (ø)

integration-testing
90.27% <ø> (ø)

serve
87.17% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Cannot subscribe to the example service when running the OSCM Docker container

I just run the newest OSCM Docker container from Dockerhub and I cannot subscribe to the test services in the marketplace. I get an error saying that the technical service the marketplace offerings are based upon is not running.
Presumable cause: as I see in the output of the docker run command, the master-indexer-domain and the bes-domain Glassfish domains are started, but not the example-domain (where the example/mock service runs). For an inexperienced OSCM user though this would not be obvious, preventing her/him to test the capabilities of OSCM, as the Docker container is intended for - from this point of view I rather consider this issue as major.
Could somebody please check and fix the Docker container on Dockerhub?

If the wrong ports issue is priority/P1, than also this one is P1. Because to subscribe on a service is a key function of a service catalog/marketplace. For the ports, there is a workaround, to configure them correctly. But starting the example-domain is not so straight forward.

I agree. Will be fixed asap.

OSCM docker image is not using the example domain for mock service. It is deployed on the bes-domain.
I have just finished investigation of the problem with subscribing to service. It was caused by technical service definition which is imported with playground dataset during building the image. I have updated it with proper values.

Ok, I understand the cause.
Could you please tell me: have you updated it only in the source code? Or did you also uploaded a new & fixed Docker container on Dockerhub?

I have just updated the source code. Building and uploading of the Docker image is done by Jenkins.

Before, please check #256. Maybe is duplicate.


fix: use base64 URL encoding for config/secrets

This solves an issue with outputting invalid URLs that were unable to be round-tripped back into the Go URL structure.

Leaving a reminder here that when we bump PFI, we'll need to run a little script to decode all the inline secrets and re-encode using the new base64 encoder


Why do we have "content" directory inside the "_site"?

Curious,

why do we have a copy of content inside _site? Is it for download of markdowns and notebooks?
Why do we have duplicate htmls inside _site/content dir?

Thanks

Whoops I totally missed this issue. You're correct, the reason that content is in there is to have the ability to download the notebook (e.g. see the download button here: https://jupyter.org/jupyter-book/features/notebooks.html).
re: duplicate HTML, I bet it's because Jekyll is catching some of the markdown files that are inside the content directory and trying to build them. Do you only notice HTML for the markdown files and not the ipynb files? If so then this might be a bug we should fix

thanks for the reply.
I notice them for markdown files.
I haven't used ipynb files so far,
I just created a sample .ipynb file and rebuilt the project.
and noticed no duplicate .html inside content dir for ipynb.
Why I was concerned
I am building  site locally and pushing the _site directory to github repo.
since HTML files get modified every time I re-build, there is unnecessary tracking of redundant HTMLs.
I figured I can find all of them  find _site/content/  -name "*.html"  and remove them before adding to git. 👍


Removing All Exceptions and Adding XboxLiveDebugManager

Changed all thrown exceptions to Debug Logs
Added XboxLiveDebugManager to enable developers to turn on and off Xbox Live Prefab Debug Logs

@MSFT-Heba,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot

rename XboxLiveDebugManager to XboxLiveServicesSettings
rename prefab to XboxLiveServices containing this script XboxLiveServicesSettings.cs script


CloudBrigadierManager brigadierSourceMapper maybe is null

When I use cloud v2, I got
java.lang.NullPointerException: brigadierSourceMapper
	at java.util.Objects.requireNonNull(Objects.java:235) ~[?:?]
	at cloud.commandframework.brigadier.CloudBrigadierManager.<init>(CloudBrigadierManager.java:103) ~[?:?]
	at cloud.commandframework.velocity.VelocityPluginRegistrationHandler.initialize(VelocityPluginRegistrationHandler.java:53) ~[?:?]
	at cloud.commandframework.velocity.VelocityCommandManager.<init>(VelocityCommandManager.java:112) ~[?:?]
	at bluesea.aquautils.AquaUtilsVelocity.onProxyInitialization(AquaUtilsVelocity.kt:85) ~[?:?]
	at bluesea.aquautils.Lmbda$4.execute(Unknown Source) ~[?:?]
	at com.velocitypowered.proxy.event.UntargetedEventHandler$VoidHandler.lambda$buildHandler$0(UntargetedEventHandler.java:56) ~[velocity.jar:3.3.0-SNAPSHOT (git-8949e1e8)]
	at com.velocitypowered.proxy.event.VelocityEventManager.fire(VelocityEventManager.java:597) ~[velocity.jar:3.3.0-SNAPSHOT (git-8949e1e8)]
	at com.velocitypowered.proxy.event.VelocityEventManager.lambda$fire$5(VelocityEventManager.java:478) ~[velocity.jar:3.3.0-SNAPSHOT (git-8949e1e8)]
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136) ~[?:?]
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635) ~[?:?]
	at java.lang.Thread.run(Thread.java:840) [?:?]

It seem because some CommandManager set this.senderMapper = senderMapper; after initialize.

https://github.com/Incendo/cloud/commit/9d95fc0c7d1df96ea7a32314ed8babbc4c920085

I didn't try, but maybe BukkitCommandManager, BungeeCommandManager, CloudburstCommandManager having this problem too?


Do not show deleted/disabled resources

What this PR does / why we need it:
And also re-arranged to unify MySQL indexes.
Which issue(s) this PR fixes:
Fixes https://github.com/pipe-cd/pipe/issues/2038
Fixes https://github.com/pipe-cd/pipe/issues/2039
Does this PR introduce a user-facing change?:

NONE

/hold

/hold cancel

The PR title should use "environments" instead of "resources".

For sure it can be confusing. I just mean environments/pipeds so let me fix.

As far as I see, this PR does not touch the ListPipeds RPC, so not sure why pipeds should be included in the PR title.

This patch contains the fix for https://github.com/pipe-cd/pipe/issues/2039, that's the reason.

https://github.com/pipe-cd/pipe/pull/2040/files#diff-de965e19dc71ecfcaec8cde1d2deebcc289b8b1e55db8ead99e2b5e4c03ebaf0R219 got modified, but I don't feel strong about the PR title, so feel free to change it 👍

Got it. The disabled pipeds are included in the error message. 👍

That's the case.

/lgtm

/approve


require tcl-tk in Brewfile

Fixes building on a mac using brew for dependancies which was missing tcl-tk at linker time:
$ brew bundle
$ make
...
[ 88%] Building techlibs/intel/synth_intel.o
[ 88%] Building techlibs/sf2/synth_sf2.o
[ 89%] Building techlibs/sf2/sf2_iobs.o
[ 89%] Building techlibs/xilinx/synth_xilinx.o
[100%] Building yosys
ld: library not found for -ltcl8.6
clang: error: linker command failed with exit code 1 (use -v to see invocation)
make: *** [yosys] Error 1

Fixed by installing tcl-tk:
$ brew install tcl-tk
Updating Homebrew...
==> Auto-updated Homebrew!
Updated 1 tap (homebrew/cask).
No changes to formulae.

==> Downloading https://homebrew.bintray.com/bottles/tcl-tk-8.6.9.mojave.bottle.1.tar.gz
==> Downloading from https://akamai.bintray.com/26/26ee537a07be3494a321daeee3a1e3fa29c3564cd7fc3f7261dfa2526be82634?__gda__=exp=1566488485~hmac=f0f48d582d8246dd222b8e5
######################################################################## 100.0%
==> Pouring tcl-tk-8.6.9.mojave.bottle.1.tar.gz

$ make
$BREW_PREFIX is [/usr/local/opt]
[Makefile.conf] CONFIG := clang
[100%] Building yosys
[100%] Building yosys-config
[100%] Building abc/abc-5776ad0
Pulling ABC from https://github.com/berkeley-abc/abc:
...

@mmicko Can you update the README.md as well?

README.md is for MacPorts, that looks like it will not work since
pkg-config will search for things defined by Homebrew, so would leave it as
is, since 99% of users is on Homebrew
On Thu, Aug 22, 2019 at 8:32 PM Eddie Hung<EMAIL_ADDRESS>wrote:

@mmicko https://github.com/mmicko Can you update the README.md as well?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/YosysHQ/yosys/pull/1319?email_source=notifications&email_token=AA3UUSF2QUYYQWIP4DIYUF3QF3LVJA5CNFSM4IOWPFG2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD457W5Q#issuecomment-524024694,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AA3UUSHKOPPIE5CJ6VSV4XLQF3LVJANCNFSM4IOWPFGQ
.

Thanks for the merge! I'm guessing a lot of folks have tcl-tk installed for other purposes but this might help someone.


Incorrect version

Hi I'm not sure if it's me but, I think in an earlier version of the app is uploaded, I downloaded the git contents and the admin app has the old UI and no options for configuring the time slots

@charlesosj Can you please check now?

@yashrajmungale  It seems to be the correct version now , thanks for the great work!!


安装完成后启动报Invalid IPv6 URL错误

File "/home/themis-test/python-project/bin/celery", line 11, in
sys.exit(main())
File "/home/themis-test/python-project/lib/python2.7/site-packages/celery/main.py", line 30, in main
main()
File "/home/themis-test/python-project/lib/python2.7/site-packages/celery/bin/celery.py", line 81, in main
cmd.execute_from_commandline(argv)
File "/home/themis-test/python-project/lib/python2.7/site-packages/celery/bin/celery.py", line 769, in execute_from_commandline
super(CeleryCommand, self).execute_from_commandline(argv)))
File "/home/themis-test/python-project/lib/python2.7/site-packages/celery/bin/base.py", line 311, in execute_from_commandline
return self.handle_argv(self.prog_name, argv[1:])
File "/home/themis-test/python-project/lib/python2.7/site-packages/celery/bin/celery.py", line 761, in handle_argv
return self.execute(command, argv)
File "/home/themis-test/python-project/lib/python2.7/site-packages/celery/bin/celery.py", line 693, in execute
).run_from_argv(self.prog_name, argv[1:], command=argv[0])
File "/home/themis-test/python-project/lib/python2.7/site-packages/celery/bin/worker.py", line 179, in run_from_argv
return self(*args, **options)
File "/home/themis-test/python-project/lib/python2.7/site-packages/celery/bin/base.py", line 274, in call
ret = self.run(*args, **kwargs)
File "/home/themis-test/python-project/lib/python2.7/site-packages/celery/bin/worker.py", line 212, in run
state_db=self.node_format(state_db, hostname), **kwargs
File "/home/themis-test/python-project/lib/python2.7/site-packages/celery/worker/init.py", line 100, in init
self.setup_instance(**self.prepare_args(**kwargs))
File "/home/themis-test/python-project/lib/python2.7/site-packages/celery/worker/init.py", line 124, in setup_instance
self._conninfo = self.app.connection()
File "/home/themis-test/python-project/lib/python2.7/site-packages/celery/app/base.py", line 385, in connection
'BROKER_CONNECTION_TIMEOUT', connect_timeout
File "/home/themis-test/python-project/lib/python2.7/site-packages/kombu/connection.py", line 164, in init
transport = transport or urlparse(hostname).scheme
File "/usr/lib64/python2.7/urlparse.py", line 142, in urlparse
tuple = urlsplit(url, scheme, allow_fragments)
File "/usr/lib64/python2.7/urlparse.py", line 213, in urlsplit
raise ValueError("Invalid IPv6 URL")
ValueError: Invalid IPv6 URL
安装完成后启动后报如上错误，服务器上面没有启用ipv6

看一下你的celery中broker的配置，redis的密码中是否有特殊字符
参考这里 https://github.com/celery/celery/issues/1553

已解决，确实有特殊字符，去掉后就可以了，非常感谢


Fix python -m isort ... under python 2

Resolves #616

For those following along at home:
Because isort/isort.py exists -- a from isort inside isort/*.py without absolute_import will attempt to import from isort/isort.py.  Adding absolute_import restores the sanity that python3 gives us wrt imports 🎉


enable extra css links for techdocs

Signed-off-by: Rico Pahlisch<EMAIL_ADDRESS>Hey, I just made a Pull Request!
Add an option to enable extra links inside the mkdocs html.
Relates to #12302
:heavy_check_mark: Checklist

[x] A changeset describing the change and affected packages. (more info)
[x] Added or updated documentation
[x] Tests for new functionality and regression tests for bug fixes
[ ] Screenshots attached (for UI changes)
[x] All your commits have a Signed-off-by line in the message. (more info)

@Rugvip can you pls. have a look at this PR.


fix: Select a query from History and Run

SUMMARY
Fix an issue that SQL Lab didn't run correct sql after user pick a query from History. The root cause is that after update selected sql in redux store, component state is out of sync from props.
The proposed solution for this PR is to remove sql from component local state, and always use props which sync from redux store.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Step to reproduce:

open sql lab
run a sql statement
pick a query from History tab
you will see SQL Editor updated with the picked query
Click Run button
The query result is not correct: query result is actually from the previous sql statement.

TESTING INSTRUCTIONS
CI and manual test.
@jinghua-qa It's a little troublesome to add unit test for this bug. Could you add a test case for this flow?
ADDITIONAL INFORMATION

[ ] Has associated issue:
[ ] Changes UI
[ ] Includes DB Migration (follow approval process in SIP-59)

[ ] Migration is atomic, supports rollback & is backwards-compatible
[ ] Confirm DB migration upgrade and downgrade tested
[ ] Runtime estimates and downtime expectations provided

[ ] Introduces new feature or API
[ ] Removes existing feature or API

cc @etr2460 @ktmud

/testenv up


Activating Open Collective

Hi, I'm making updates for Open Collective. Either you or another core contributor signed this repository up for Open Collective. This pull request adds financial contributors from your Open Collective https://opencollective.com/yarte ❤
What it does:

adds a badge to show the latest number of financial contributors
adds a banner displaying contributors to the project on GitHub
adds a banner displaying all individuals contributing financially on Open Collective
adds a section displaying all organizations contributing financially on Open Collective, with their logo and a link to their website

P.S: As with any pull request, feel free to comment or suggest changes.
Thank you for your great contribution to the Open Source community. You are awesome! 🙌
And welcome to the Open Collective community! 😊
Come chat with us in the #opensource channel on https://slack.opencollective.com - great place to ask questions and share best practices with other Open Source sustainers!

Merged in c5cc707


Fix sequence bug and remove unnecessary sql query

Fix rank sequence bug for top 5 order trend by order number.
Remove unnecessary redundant top 5 query and optimize flow to speed up response time

@ch2ohch2oh


fix: move npm root to try/catch block and make it async

Closes #486

Codecov Report

:exclamation: No coverage uploaded for pull request base (development@10b1928). Click here to learn what that means.
The diff coverage is n/a.

:exclamation: Current head 792d477 differs from pull request most recent head a5ce7e4. Consider uploading reports for the commit a5ce7e4 to get more accurate results

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
@@              Coverage Diff               @@
##             development     #493   +/-   ##
==============================================
  Coverage               ?   53.22%
==============================================
  Files                  ?      188
  Lines                  ?     4825
  Branches               ?      793
==============================================
  Hits                   ?     2568
  Misses                 ?     2020
  Partials               ?      237


Block TSR library's place and place_on should be renamed.

While reviewing for personalrobotics/magi#2, I realized that block tsr library has 'place' and 'place_on' tsrs, and it's 'place_on' serves as 'place' in many other object tsrs. For consistency across tsrs (so that same tsr name can be used for motion planning across multiple objects), 'place' should be changed to something like 'place_at' and 'place_on' should be changed to 'place'.

I renamed 'place' to 'place_at' and 'place_on' to 'place'. The changes are in block.py in the feature/MoveUntilTouch branch


Db : CheckNeighbours Create Duplicate

Start with commit Update Display
cty.update trigger neighbour dbcheck who doesn't seem to work as supposed


AutoComplete Does Not Recognise Common Names

Something has broken with the change to window.coredata setup, which means that the Account Name AutoComplete function has just a fraction of the names that it should. This needs to be fixed.

This has been resolved with the 15H230 release. Closing Ticket.


Download Page: Ability to specify Analytics adapters.

The Download page has been modified to support specifying Analytics Adapters to be packaged into prebid.js file. This is just the UI changes, the server side handling done on this endpoint is not part of this PR.

This is on hold until we can update the backend process to build adapters. To do that we need to move analytics adapters out of package.json into it's own file. Feel free to contribute to prebid.js for that if you want to help with this effort :)

@mkendall07 - please check the PR https://github.com/prebid/Prebid.js/pull/1021. Let me know if this helps.


It didn't stop after 3 tries in captcha

Did you send the buy command when the captcha appeared?

is there any way to solve this? I've had this problem too. If a captcha appears and you have no balls, it'll do the shop command and then always be 1 captcha behind which leads to failing the captcha.

oh great, thanks so much!

Thank you too!


Is there a sendEmail() method?

Salesforce's SOAP API has a sendEmail method and I can't find a similar one in jsforce. Is there a way to send emails using jsforce? My use case is I have a contact form on my website for users to send a quick message to customer service. I want to create a new lead and send an email message to customer service with tracking.

any update on this?

We partially support soap methods, but not for sendEmail yet.

Whats the status on this? Is this dead in the water?

Has anyone had any success in getting the sendMail to work with Node?

It's 2021 - SalesForce is massive, WHY is there no official NPM package from them to do something as basic as send an email 🤣
Did this ever get implemented with JSForce?

You can cobble together a SOAP request using jsforce as is, just like you can do any SOAP request with a fair amount of elbow grease.
Request
const jsforce = require('jsforce');
require('dotenv').config();

async function run() {
  const conn = new jsforce.Connection({
    loginUrl: process.env.SF_URL,
  });
  await conn.login(process.env.SF_USERNAME, process.env.SF_PASSWORD);

  const body = `
<soapenv:Envelope xmlns:soapenv="http://schemas.xmlsoap.org/soap/envelope/" xmlns:urn="urn:enterprise.soap.sforce.com" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance">
  <soapenv:Header>
     <urn:SessionHeader>
        <urn:sessionId>${conn.accessToken}</urn:sessionId>
     </urn:SessionHeader>
  </soapenv:Header>
  <soapenv:Body>
     <urn:sendEmail>
        <urn:messages xsi:type="urn:SingleEmailMessage">
           <urn:subject>Example</urn:subject>
           <urn:plainTextBody>${sanitizeForXml('This is my <plain text> body that is safe for use within XML')}</urn:plainTextBody>
           <urn:toAddresses>test-jsforce-136@mailinator.com</urn:toAddresses>
        </urn:messages>
     </urn:sendEmail>
  </soapenv:Body>
</soapenv:Envelope>
`;

  const response = await conn.request(
    {
      method: 'POST',
      url: `${conn.instanceUrl}/services/Soap/c/${conn.version}`,
      body,
      headers: {
        'Content-Type': 'text/xml;charset=utf-8',
        Accept: 'text/xml;charset=utf-8',
        SOAPAction: '""',
      },
    },
    { responseType: 'text/xml' }
  );

  console.log(JSON.stringify(response, null, 2));
}

function sanitizeForXml(value) {
  return String(value).replace(/&/g, '&').replace(/</g, '<').replace(/>/g, '>').replace(/"/g, '"').replace(/'/g, ''');
}

run();

Response
❯ node src/index.js
{
  "soapenv:Envelope": {
    "$": {
      "xmlns:soapenv": "http://schemas.xmlsoap.org/soap/envelope/",
      "xmlns": "urn:enterprise.soap.sforce.com"
    },
    "soapenv:Header": {
      "LimitInfoHeader": {
        "limitInfo": {
          "current": "34",
          "limit": "15000",
          "type": "API REQUESTS"
        }
      }
    },
    "soapenv:Body": {
      "sendEmailResponse": {
        "result": {
          "success": "true"
        }
      }
    }
  }
}

Awesome work @paustint !  Confirmed this works


[BZ1189053] Missing deprecated attribute on both subsystem root resources

https://bugzilla.redhat.com/show_bug.cgi?id=1189053

Linux with security manager Build 972 is now running using a merge of 5d16272ebb343cae7a3c4ecc5180032c44fa2cdd

Windows Build 1106 is now running using a merge of 5d16272ebb343cae7a3c4ecc5180032c44fa2cdd

Linux Build 5993 is now running using a merge of 5d16272ebb343cae7a3c4ecc5180032c44fa2cdd

Linux with security manager Build 972 outcome was SUCCESS using a merge of 5d16272ebb343cae7a3c4ecc5180032c44fa2cdd
Summary: Tests passed: 840, ignored: 319 Build time: 0:04:58

Linux Build 5993 outcome was SUCCESS using a merge of 5d16272ebb343cae7a3c4ecc5180032c44fa2cdd
Summary: Tests passed: 2928, ignored: 314, muted: 1 Build time: 0:46:49

Windows Build 1106 outcome was SUCCESS using a merge of 5d16272ebb343cae7a3c4ecc5180032c44fa2cdd
Summary: Tests passed: 2929, ignored: 314 Build time: 0:47:15


READY FOR REVIEW - Fix #2741. Add support for alternate Vagrant providers: ...

...VMWare Fusion, VMWare Workstation, and Parallels. (Replaces #6879. Tagging #2741. Cc: @erictune, @derekwaynecarr, @jameskyle.)
I tried to mirror the Vagrant philosophy and do the right thing in most cases without tweaking configuration (unless you really wanted to override something). The fall-back order is:

VMWare Fusion
VMWare Workstation
Parallels (Thanks @rickard-von-essen for chef/bento#255 and for maintaining your repository!)
VirtualBox

If any of these are installed properly (including any required Vagrant plugins), KUBERNETES_PROVIDER=vagrant .../cluster/kube-up.sh should just work. :grin: CAVEAT*: I do not have a license to VMWare Fusion. I'm pretty sure it will function, but I have only tested Parallels.*
To override, you can set VAGRANT_DEFAULT_PROVIDER (e.g., if you have both VMWare and Parallels installed, but want to use Parallels):
export KUBERNETES_PROVIDER=vagrant
export VAGRANT_DEFAULT_PROVIDER=parallels
.../cluster/kube-up.sh

You can override the box (by name):
export KUBERNETES_PROVIDER=vagrant
export VAGRANT_DEFAULT_PROVIDER=parallels
export KUBERNETES_BOX_NAME=rickard-von-essen/opscode_fedora-20 # will fetch from atlas
.../cluster/kube-up.sh

And even specify a version:
export KUBERNETES_PROVIDER=vagrant
export VAGRANT_DEFAULT_PROVIDER=parallels
export KUBERNETES_BOX_NAME=rickard-von-essen/opscode_fedora-20 # will fetch from atlas...
export KUBERNETES_BOX_VERSION=0.3.0 # ...with this version
.../cluster/kube-up.sh

Or specify a URL for the box itself, in which case you now must provide your own name:
export KUBERNETES_PROVIDER=vagrant
export VAGRANT_DEFAULT_PROVIDER=parallels
export KUBERNETES_BOX_NAME=rickard-von-essen-fedora20 # will set the name to this value (with version 0)...
export KUBERNETES_BOX_URL=https://atlas.hashicorp.com/rickard-von-essen/boxes/opscode_fedora-20/versions/0.4.0/providers/parallels.box # ...and download the box from here
.../cluster/kube-up.sh

WARNING: This breaks the existing behavior of KUBERNETES_BOX_URL, which is now ignored unless KUBERNETES_BOX_NAME is also set. Previously that name was fixed for everything (default or specified by URL) as fedora20, irrespective of underlying OS/version. Now if a default box is used, the name is set internally (currently only kube-fedora20), but users who specify their own box URL are now forced to name it. To avoid clashes or confusion, it is recommended (but not enforced) that the name distinguish the box from the defaults (e.g., posita-fedora21, kickass-custom-centos, etc.).
This PR also introduces the ability to set the master memory size independently of the minions (it is included with this PR instead of a separate one because memory configuration is Vagrant provider-specific; see, e.g., this vs. this):
export KUBERNETES_PROVIDER=vagrant
export KUBERNETES_MASTER_MEMORY=1024
export KUBERNETES_MINION_MEMORY=2048
.../cluster/kube-up.sh

KUBERNETES_MEMORY is maintained for backward compatibility. The following are equivalent to the previous example:
export KUBERNETES_PROVIDER=vagrant
export KUBERNETES_MEMORY=1024 # sets both
export KUBERNETES_MINION_MEMORY=2048 # overrides minion
.../cluster/kube-up.sh

export KUBERNETES_PROVIDER=vagrant
export KUBERNETES_MEMORY=2048 # sets both
export KUBERNETES_MASTER_MEMORY=1024 # overrides master
.../cluster/kube-up.sh

Thanks for the pull request.  Testing this now to ensure it does not regress VirtualBox.

The cluster comes up, but I am getting this in the terminal output when invoking cluster/kube-up at start
Starting cluster using provider: vagrant
... calling verify-prereqs
Usage: sed [OPTION]... {script-only-if-no-other-script} [input-file]...

  -n, --quiet, --silent
                 suppress automatic printing of pattern space
  -e script, --expression=script
                 add the script to the commands to be executed
  -f script-file, --file=script-file
                 add the contents of script-file to the commands to be executed
  --follow-symlinks
                 follow symlinks when processing in place
  -i[SUFFIX], --in-place[=SUFFIX]
                 edit files in place (makes backup if SUFFIX supplied)
  -c, --copy
                 use copy instead of rename when shuffling files in -i mode
  -b, --binary
                 does nothing; for compatibility with WIN32/CYGWIN/MSDOS/EMX (
                 open files in binary mode (CR+LFs are not treated specially))
  -l N, --line-length=N
                 specify the desired line-wrap length for the `l' command
  --posix
                 disable all GNU extensions.
  -r, --regexp-extended
                 use extended regular expressions in the script.
  -s, --separate
                 consider files as separate rather than as a single continuous
                 long stream.
  -u, --unbuffered
                 load minimal amounts of data from the input files and flush
                 the output buffers more often
  -z, --null-data
                 separate lines by NUL characters
  --help
                 display this help and exit
  --version
                 output version information and exit

If no -e, --expression, -f, or --file option is given, then the first
non-option argument is taken as the sed script to interpret.  All
remaining arguments are names of input files; if no input files are
specified, then the standard input is read.

GNU sed home page: <http://www.gnu.org/software/sed/>.
General help using GNU software: <http://www.gnu.org/gethelp/>.
which: no vmrun in (/home/decarr/google-cloud-sdk/bin:/home/decarr/go/src/github.com/openshift/origin/_output/local/go/bin:/home/decarr/go/bin:/home/decarr/.rbenv/shims:/home/decarr/.rbenv/bin:/home/decarr/google-cloud-sdk/bin:/usr/lib64/qt-3.3/bin:/usr/local/bin:/usr/bin:/bin:/usr/local/go/bin:/usr/local/sbin:/usr/sbin:/home/decarr/.local/bin:/home/decarr/bin:/home/decarr/.rvm/bin:/home/decarr/.rvm/bin)
which: no vmrun in (/home/decarr/google-cloud-sdk/bin:/home/decarr/go/src/github.com/openshift/origin/_output/local/go/bin:/home/decarr/go/bin:/home/decarr/.rbenv/shims:/home/decarr/.rbenv/bin:/home/decarr/google-cloud-sdk/bin:/usr/lib64/qt-3.3/bin:/usr/local/bin:/usr/bin:/bin:/usr/local/go/bin:/usr/local/sbin:/usr/sbin:/home/decarr/.local/bin:/home/decarr/bin:/home/decarr/.rvm/bin:/home/decarr/.rvm/bin)
which: no prlctl in (/home/decarr/google-cloud-sdk/bin:/home/decarr/go/src/github.com/openshift/origin/_output/local/go/bin:/home/decarr/go/bin:/home/decarr/.rbenv/shims:/home/decarr/.rbenv/bin:/home/decarr/google-cloud-sdk/bin:/usr/lib64/qt-3.3/bin:/usr/local/bin:/usr/bin:/bin:/usr/local/go/bin:/usr/local/sbin:/usr/sbin:/home/decarr/.local/bin:/home/decarr/bin:/home/decarr/.rvm/bin:/home/decarr/.rvm/bin)
... calling kube-up

Not sure where this is coming from in your branch, but noting so I can remember to look in more detail.

The cluster comes up, but I am getting this in the terminal output when invoking cluster/kube-up at start ... Not sure where this is coming from in your branch, but noting so I can remember to look in more detail.

I'm pretty sure it's this. I should have remembered that some platforms' seds don't support the -E option (meaning extended regular expressions). I will fix this right now.

A few issues noted in the PR.  Please resolve, squash commits, and I will then merge.

LGTM - thanks!


[core] Automatically tweet about good first issues

Maybe we can reduce the backlog of open "good first issue"s and gain more active contributors by increasing engagement on twitter.
The idea is to tweet out issues that are marked as "good first issues" once they receive that label. For now it tweets every time the label gets added on open issues.
I think we should do this from a separate account. This may be too spammy for existing followers.
Proof-of-concept:

label added in https://github.com/eps1lon/mui-scripts-incubator/issues/599
tweet sent: https://twitter.com/MuiContrib/status/1285670876915077121

Just need to add the secrets accordingly if we decide to  merge it. It will only use the workflow on the default branch.
Future ideas:

signal-boost twitter accounts from people:

resolving "good first issue"s (leave a comment with the twitter account of the PR author and let GH actions pick it up)
We might want to do it from the main account for maximum boosting to not spam people waiting for new issues to pop up

tweet out RFCs (though they're rare enough that a manual tweet might suffice)
GitHub discussions might open up a bit more (tweeting Support issues that were moved to discussions)

While I have some doubt about the good first issue tweet (Are the incentives right? Why would somebody follow the Twitter account in the first place? I guess it's worth trying out to see!), the item under:

tweet out RFCs (though they're rare enough that a manual tweet might suffice)

seems promising 🙌 (to be tweeted from an account dedicated to RFC?)

Let's see if this works. Only took an hour to set up so I don't have big expectations.


Small Change: Corrected attribute in example

Had to look into source code to find the correct one. It was a small annoyance but may be an issue for beginners.

onClose handler wasn't working. I added that too.

@ishansharma Thanks!


transformer_engine: clear_collection doesn't clear the tensors saved by transformer_engine_ex ops for backward.

clear_collection only clears a list, but transformer_engine_ex saves a collection of dict which holds a tuple of tensor. Because of this we hold onto to the tensors longer leading to higher memory usage.
https://github.com/Lightning-AI/lightning-thunder/blob/40e9c3ec7530cfc109a86301cb58ea62309da28b/thunder/executors/pythonex.py#L228-L230
cc: @IvanYashchuk

Per offline discussion:

We should update clear_collection to also clear dictionary.
We should update the name clear_collection to clear_mutable_collection to make it clear that this won't do anything if tuple or other immutable collection is passed.


import_bulk with on_duplicate="update" requires _to and _from fields for preexisting edge

My Environment

ArangoDB Version:        3.4.6
Storage Engine:             RocksDB
Deployment Mode:       Single Server
Deployment Strategy:   Manual Start
Configuration:               Nothing special
Infrastructure:               My laptop
Operating System:        Ubuntu 18.04
Total RAM in your machine:        10Gb in VM, 32GB total
Disks in use:        SSD
Used Package:             tar

Component, Query & Data
Affected feature:
bulk update
AQL query (if applicable):
n/a
AQL explain (if applicable):
n/a
Dataset:
included in example
Size of your Dataset on disk:
n/a
Replication Factor & Number of Shards (Cluster only):
n/a
Steps to reproduce
$ ipython
Python 3.6.7 (default, Oct 22 2018, 11:32:17)
Type 'copyright', 'credits' or 'license' for more information
IPython 7.4.0 -- An enhanced Interactive Python. Type '?' for help.

In [1]: import arango

In [2]: acli = arango.ArangoClient(protocol='http', host='localhost', port=8529)
   ...:

In [3]: ardb = acli.db('test_edge_bulk_update', verify=True)

In [4]: edges = ardb.collection('edges')

In [5]: edges.import_bulk([{'_key': 'k', '_from': 'verts/f', '_to': 'verts/t'}])
   ...:
Out[5]:
{'error': False,
 'created': 1,
 'errors': 0,
 'empty': 0,
 'updated': 0,
 'ignored': 0,
 'details': []}

In [6]: edges.import_bulk([{'_key': 'k', 'data': 'whoo'}], on_duplicate="update"
   ...: )
---------------------------------------------------------------------------
DocumentInsertError                       Traceback (most recent call last)
<ipython-input-6-400ce1c1bf8a> in <module>
----> 1 edges.import_bulk([{'_key': 'k', 'data': 'whoo'}], on_duplicate="update")

*snip*

DocumentInsertError: [HTTP 400][ERR 1233] edge attribute missing or invalid

In [7]: edges.import_bulk([{'_key': 'k', '_from': 'verts/f', '_to': 'verts/t', '
   ...: data': 'whoo'}], on_duplicate="update")
Out[7]:
{'error': False,
 'created': 0,
 'errors': 0,
 'empty': 0,
 'updated': 1,
 'ignored': 0,
 'details': []}

Problem:
The _to and _from keys are required to update a document that already contains the _to and _from keys, and those keys are not part of the update. If only the _key is known (as in my case), then the edge needs to be retrieved from the DB prior to the update in order to perform said update, which is a waste of resources.
Expected result:
Edges can be updated via import_bulk without requiring knowledge of the _to and _from edges if the edge already exists.

The 'get then update' stragety required here also makes race conditions possible on the _to and _from edges.

Any updates on this issue?

Hi,
for Edge-Documents the _from and _to attributes are mandatory on top of the _key attribute for regular documents.
Pointing _from or _to to nowhere will make the edge invalid.
So there is no easy workaround, you have to know _from and _to beforehand.
Otoh, the _from and _to don't have to be uniq for a collection - unless you force it so by adding another index.

for Edge-Documents the _from and _to attributes are mandatory on top of the _key attribute for regular documents.

Since this is an update, the _to_ and _from attributes are already there.


Mutliple performers

Different color for different players? And eventually, even overlapping parts?

this has been implemented


[ideas] MultiOption Validation

Thx to ITypeConverter we have a very good way to do validation for one option input.  :+1:
Coupled with a #1407 it is even possible to display only the help usage corresponding to the error.
But in some cases we need more complex multi option validation mechanism. Especially because using ArgGroup to build complex rules could be quickly verbose and reveal some corner case issue. ( e.g. #1409 )

When I create my commands I would like be able to make it inherit some kind of Validable interface with a validate() method which will be called before the run() or call() method (and obviously after the args parsing)
The validate()  raise exception if there was any invalid input and will be handled by IParameterExceptionHandler.
The exception could concern several options and maybe IParameterExceptionHandler wanted to know each options are concerns to display target help usage (e.g. display only help for option in error or maybe only the ArgGroup in error)
So we probably need a kind of MultiParameterException.
We can imagine that we could also make validation as ArgGroup level by making it implement Validable too.
If an exception is raised, it could be catch in a ArgGroupParameterException. (something like this)

As this mechanism does not exist for now, I workaround this by using run() or call() like if it was a validate method. Consequently, I need to execute my command out of the Command definition class but in my use case this is not an issue.
Then I create an IExecutionExceptionHandler which acts like a IParameterExceptionHandler.
I share some code :
/**
 * An exception raised to warn about invalid CLI options. <br>
 * Generally this exception concern validation about more than 1 options.
 */
public class MultiParameterException extends RuntimeException {

    private static final long serialVersionUID = 1L;

    private String[] options;

    /**
     * @param msg the error message
     * @param options list of option concerned by the exception
     */
    public MultiParameterException(String msg, String... options) {
        super(msg);
        this.options = options;
    }

    /**
     * @param msg the error message
     * @param options list of option concerned by the exception
     */
    public MultiParameterException(String msg, Exception cause, String... options) {
        super(msg, cause);
        this.options = options;
    }

    public String[] getOptions() {
        return options;
    }
}

ublic class ExecutionExceptionHandler implements IExecutionExceptionHandler {

    @Override
    public int handleExecutionException(Exception ex, CommandLine cmd, ParseResult parseResult) throws Exception {
        PrintWriter writer = cmd.getErr();
        if (ex.getMessage() != null)
            writer.print(cmd.getColorScheme().errorText(ex.getMessage()));
        else
            writer.print(cmd.getColorScheme().errorText(ex.getClass().getSimpleName()));
        writer.printf("%n");

        if (ex instanceof InvalidOptionsException) {
            writer.printf("%n");
            Help help = cmd.getHelpFactory().create(cmd.getCommandSpec(), cmd.getColorScheme());
            Layout layout = help.createDefaultLayout();
            for (String optionName : ((InvalidOptionsException) ex).getOptions()) {
                OptionSpec option = cmd.getCommandSpec().findOption(optionName);
                if (option != null) {
                    layout.addOption(option, help.createDefaultParamLabelRenderer());
                }
            }
            writer.print(layout.toString());
        } else {
            writer.print(cmd.getColorScheme().stackTraceText(ex));
        }

        writer.printf("%n");
        CommandSpec spec = cmd.getCommandSpec();
        writer.printf("Try '%s --help' for more information.%n", spec.qualifiedName());

        return AutoComplete.EXIT_CODE_INVALID_INPUT;
    }
}

Example of validations :
    @Override
    public void run() {
        // Some post-validation which imply several options.
        // For validation about only one option just ITypeConverter instead
        if (identity.isx509()) {
            if (identity.getX509().certUsage == CertificateUsage.SERVICE_CERTIFICATE_CONSTRAINT
                    && identity.getX509().trustStore.isEmpty()) {
                throw new InvalidOptionsException(
                        "You need to set a truststore when you are using \"service certificate constraint\" usage",
                        "-cu", "-ts");
            }
        }
    }

You can achieve the desired outcome by throwing a ParameterException instead of a InvalidOptionsException from the run/call method.
See the user manual section on custom validation: https://picocli.info/#_custom_validation

Thx to pointing this :pray: (I will be able to remove my custom ExecutionExceptionHandler)
I feel there is maybe still good point in ideas above.

Separating execution from validation sounds cleaner too me, so I feel that the Validatable interface could be pretty good way to achieve this. (but I guess you could consider this as just cosmetics)
I think it could make sense to add a MultiParameterException or a ArgGroupParameterException which could be used in ShortErrorMessageHandler example. (#1407)
I also feel that being able "to write a ArgGroup Validation in the class which defined it" could be very cool. This allow to implement an ArgGroup in a separated class with its validation to make it resuable

e.g :
public class mySection implements ValidatableArgGroup{

    @Option(names = { "-a", "--option-a" }, defaultValue = "Default A", description = "Should be 4th")
    private String a;

    @Option(names = { "-b", "--option-b" }, defaultValue = "Default B", description = "Should be 3rd")
    private String b;

   public void validate(CommandSpec cmd, ArgGroup ArgGroup) throws ParameterException {
       // Do some validation
       if (!valid)
          throw new ArgGroupParameterException(cmd, Argroup, "this is not valid because ....");
   }
}

and then can be reusable like this :
Command(name = "myCommand",
         mixinStandardHelpOptions = true,
         description = "A command with not well ordered option.",
         sortOptions = false)
public class Example {

    @ArgGroup(validate = false,
              heading = "%n@|italic " //
                      + "A reused Section with custom validation." //
                      + "|@%n")
    public mySection reusedSection = new mySection();

    public static void main(String... args) {
        Example example = new Example();
        int exitCode = new CommandLine(example).execute(args);

        System.exit(exitCode);
    }
}

There is nothing blocking to me here but I feel this kind of modification could make the API better and fit very well with #1407.

You can achieve the desired outcome by throwing a ParameterException instead of a InvalidOptionsException from the run/call method.

Just to precise that I need a custom ParameterException to be able to "attached" all the option which is concerned to be able to  display it in ShortErrorMessageHandler with
if (ex instanceof /*InvalidOptionsException*/ MultiParameterException) {
            writer.printf("%n");
            Help help = cmd.getHelpFactory().create(cmd.getCommandSpec(), cmd.getColorScheme());
            Layout layout = help.createDefaultLayout();
            for (String optionName : ((/*InvalidOptionsException*/ MultiParameterException) ex).getOptions()) {
                OptionSpec option = cmd.getCommandSpec().findOption(optionName);
                if (option != null) {
                    layout.addOption(option, help.createDefaultParamLabelRenderer());
                }
            }
            writer.print(layout.toString());
        }

You can obtain the group via ParameterException.getArgSpec().group(), from which you can get all details of the group.

Overall, I feel that picocli as a library should be very minimalistic about validation.
The user manual covers validation in some common scenarios, and I have always felt that for picocli to provide a validation API would not add much value...
The ArgGroup validation idea is interesting, I can see that. But then for picocli to implement just that, without also providing something similar for general Commands, would be imbalanced/incomplete.
So we are back where we started: I think picocli should not provide validation API, but instead have documentation that shows how applications can do validation in different scenarios.
If you found a new scenario or a way to do things with the existing API that belongs in the docs or in the picocli-examples module, PRs are welcome!

Good discussions, many thanks!


Old Norse prosody

I updated docs and added doctests.

My code works on https://github.com/clemsciences/cltkv1/tree/non-prosody-check https://travis-ci.org/github/clemsciences/cltkv1/jobs/715202249 (sorry for the multiple commits).
@free-variation, if you need someone else to work with you on code refactor, I may join.


Wrong reply

When I hit r to reply after selecting, as the chat moves it replies the next message or to the next number of message defined by how many new messages have been send.


Azure image list

Can now select an image from a drop-down list for creating a server group.

LGTM


android stuck in landscape mode after exiting with back button

As reported before an android app is stuck in landscape mode after exiting a fullscreen player with the back button, this is a pretty big issue obviously, so I'm opening a new one here since the old ones were closed. It seems there was a PR #133 forthcoming that never got ready. I'll look into it and possibly provide a new PR.

@MrLoh As far as I remember I fixed it somewhere down the road. I just tested on the example app and It looked fine for me. Can you be more specific about the behavior you describe?

yes, it seems to be fixed now. I'm very confused as to why it was broken before, but I just reloaded the app for the 101th time and it was working. Sometimes React Native is a mysterie to me. Thanks for the awesome YouTube Component.


Add scheduling affinity towards nodes labeled enmasse and support storage class parameter

Closing this until an actual use case is presented


Wfac for perspex

I built a perspex casing for my sensor. Will this also fall under a wfac of 1 or should it be higher?

@MarinusPretorius for UV perspex is not the best material, since it does not transmit UV radiation well, the best material is quartz
In any case, the coefficient must be found experimentally.


M3-1843 For release: Ensure link text on breadcrumbs does not wrap

Coverage remained the same at 30.548% when pulling 2c1cbffc63216ba842aafc4a2ca2957dd931a671 on WilkinsKa1:M3-1843-breadcrumb-wrap-fix into 39ff50cb1f4fb8e72b73246bebce41da75ae58ac on linode:release-0.39.0.


searx: 0.9.0 -> 0.10.0

Built on platform(s)

[x] NixOS

[x] tested service

With a patch to loosen up searx pip dependency requirements.
Also includes a minor version bump of pysocks.

cc @fpletz

in the future when you update multiple packages please use multiple commits.

Will do


Command Palette still shows View: Show Debug

VSCode Version: 1.43 Insiders
OS Version: Windows 10

Steps to Reproduce:

Open Command Palette and filter on view

Should probably say View: Show Run to match new Activity Bar text and view name

For backward compatibility decided to rename this on to
Show Run and Debug


Logging keyboard error.

I compiled the file, and I'm running the test on local computer, and configured to save the logs to a file. Recompiling a script multiple times after the problem, but the same error persisted in all tests, and no log file was generated.
The following tests are performed on virtual machines on the Windows 10 and Windows 7 operating systems. The following error is displayed by the Puffader log:
`Exception in thread Thread-5:
Traceback (most recent call last):
File "threading.pyc", line 801, in __bootstrap_inner
File "threading.pyc", line 754, in run
TypeError: StoreMessagesLocal() takes exactly 1 argument (138 given)
Exception in thread Thread-7:
Traceback (most recent call last):
File "threading.pyc", line 801, in __bootstrap_inner
File "threading.pyc", line 754, in run
TypeError: StoreMessagesLocal() takes exactly 1 argument (185 given)
Exception in thread Thread-11:
Traceback (most recent call last):
File "threading.pyc", line 801, in __bootstrap_inner
File "threading.pyc", line 754, in run
TypeError: StoreMessagesLocal() takes exactly 1 argument (349 given)`

I have seen this before, for some reason it is passing in all of the characters as arguments.

Try the latest commit.

Both of the virtual machines I used for the test are clean. I have installed only the pr requirements necessary to compile the project. I even installed everything software to do a quick search on the machine for this executable spbkhost.exe, but it does not exist.

I still have the same problem, I just configured a virtual machine with windows 10 from the beginning, installed all the prerequisites, recompiled the puffader again, and the same error I described above occurs.


Is there a mapping list between ijbc_face_tid_mid.txt and original-dataset-from-Janus's file ijbc_metadata_with_age.csv

Hi Irving/All,
Is there image name mapping between the two files  ijbc_face_tid_mid.txt  and  ijbc_metadata_with_age.csv? The reason is, for the same image, I want alignment coordinates from the file ijbc_face_tid_mid.txt metadata from the ijbc_metadat_with_age.csv file.  Template_id/Sighting_id isn't helping alone as multiple sighting_ids are possible.
Thanks,

While such a mapping above would be nice, I moved ahead by abandoning my need for landmarks provided in ijbc_name_5pts_score.txt  , instead getting my own landmarks for the cropped images using mtcnn, and thus performing alignment over the original IJB-C data/meta-data (ijbc_metadat_with_age.csv)


Suggestions

Hey, I like this module a lot and wanted to add a suggestion. It would be awesome to have scale bars (or a few size options) for fine tuning the size of the scenes at the top of the screen, icons on the left side of the screen, macro bar at the bottom of the screen. Thanks for considering!

Multiple sizes and options improved :)
Please feel free to open new issues for new more specific requests.
Thanks