attributes for users?

hi,
this is a great library. thank you for pulling this together.
I understand, at the moment, the package supports resource attributes but not user attributes? If this is correct, would it be possible to consider introducing user attributes in the future?
many thanks,
Lucas

If I understand correctly, and it is the problem that I am facing.
What he means is a limited access to a resource, for a specific user/role.
The same way you have control over which attributes will be sent back to the user (using filter), it makes sense to have control over what subset of resource instances will be sent back, according the role.
e.g If I have a "salesManager" role, I should only be able to see my team's sales and not the entire company's. I should still see sales, hence denying access to the entire resource (sales) wouldn't work.

apologies for a slow response!
I was thinking about the following scenario:
you want to control access depending on both a role as well as an attribute of a user. For example, you have a role "registered user" with an attribute "credits", where "credits" is an integer number greater than zero representing a balance of some points that change over time.
You want to give access to certain resources, say "movies" based on whether a user is a "registered user" and how many "credits" they have. For example "movies" that are "new" would only be accessible to "registered users" with over 1,000 "credits".. etc..
I may be over complicating this, but I was looking for something where attributes of users can be used to control access. Other obvious examples of relevant user attributes could be age, location, number of likes on their profile... etc...
hope that helps?
thanks!

@yohairosen for your use case, what you need to do is define 2 different roles. What's wrong with this implementation:
ac.grant('salesTeamManager')
  .readOwn('teamSales')
  .grant('salesManager')
  .readAny('teamSales');

Both roles are granted permissions for the teamSales resource.
We'll now fetch the resource representation/instance by a team identifier.
REST Endpoint:
GET /team/:teamId/sales

SQL (if fetching from a database):
SELECT * FROM sales WHERE teamId = :teamId;

Node/Express App Handler:
app.get('/team/:teamId/sales', (req, res) => {
  const user = req.user;
  const targetTeamId = req.params.teamId;
  const userTeamInfo = service.getUserTeamInfo(user.id);

  const can = ac.can(user.role);
  // permission by possession
  const permission = (userTeamInfo.id === targetTeamId)
    ? can.readOwn('teamSales')
    : can.readAny('teamSales');

  if (permission.granted) {
    const data = service.getTeamSales(targetTeamId);
    res.json(permission.filter(data));
  } else {
    res.status(403).end();
  }
});

Bottom line; it's not -only- how you control access, it's important how you design the application in the first place.
Hope this answers your question.

@lucasmike no problems but you're getting this wrong. You cannot/should not mix your business model or logic with any kind of access control.
Store the credits amount and other info in your session variables instead. For example, in express.js this could be the user property of the request object.
  const user = req.user;
  const movieId = Number(req.params.movieId);
  const minCreditsRequired = 1000;
  const permission = ac.can(user.role).read('movies');

  if (permission.granted) {
    const movie = service.getMovie(movieId);
    if (!movie) return res.status(404).end(); // not found

    const creditsOK = !movie.isNew || user.credits >= minCreditsRequired;
    if (creditsOK) return res.json(movieData);
  }

  // otherwise, forbidden
  res.status(403).end();

Also see Single Responsibility Principle.

@onury Thanks for the quick response.
This still doesn't solve my use case. Let me explain further.

Company's CEO : should be able to see sales across the whole company (all teams)
Sales Team Manager : should only be able to see sales made by his team members
Sales Man - should only be able to see sales made by him

All user roles logs in to the same dashboard (always making the same api call) where they can see the appropriate sales for their role.
GET api/sales
I don't want to check for the specific roles as it breaks scalability and generally not a good idea.
I'm thinking something like fallback permissions.
The only way I was be able to implement this is defining another resource for teamSales, but it feels kind of hacky...
ac
    .grant('companyCEO')
    .readAny('sales')
    .grant('salesTeamManager')
    .readOwn('teamSales')
    .grant('salesman')
    .readOwn('sales');

app.get('/sales', (req, res) => {
    const user = req.user

    const can = ac.can(user.role)

    let data
    let permission = can.readAny('sales')

    if (permission.granted) { //CEO
        data = service.getAllSales()
        return res.json(permission.filter(data));
    }

    permission = can.readOwn('teamSales')

    if (permission.granted) { // team manager
        data = service.getTeamSales(user.id)
        return res.json(permission.filter(data));
    }

    permission = can.readOwn('sales')

    if (permission.granted) { // salesman
        data = service.getUserSales(user.id)
        return res.json(permission.filter(data));
    }

    return res.status(403).end();
});

What do you think?

That's perfectly meaningful. Why do you feel it's hacky? If you think this is a bit complex, it's actually your application logic which is quite legit and alright.
A resource does not necessarily mean a database table. If you need to distinguish control of access, you can define a separate resource in your app-logic.
See the FAQ section on "What is a resource?".


Move HTTP1 request flood checks from response encode to request decode.

Description: Move HTTP1 request flood checks from response encode to request decode.
Decode of a new request is guaranteed to happen on a shallow call stack under HCM, which makes it a better choice for flood checks since it reduces the number of unique call stacks under which FrameFloodException may be thrown.
Fixes several cases where FrameFloodException was thrown outside a try/catch block, resulting in an Envoy crash.
Risk Level: low
Testing: unit and integration
Docs Changes: n/a
Release Notes: n/a

+1 I prefer this solution. I think we will need to make similar changes to HTTP/2 but I'm not sure? cc @yanavlasov.

Cool, I think moving this is much simpler than the try / catch PR, but I think you need to update some comments and probably docs. The logs, thrown error message and stats all talk about too many responses, where now we're reacting to an incoming request when there are too many responses.

I went through "git show f5b0294f0a7c2d143f6d4d94afae9a0e6f9dacf7" and updated relevant comments and exception strings.

+1 I prefer this solution. I think we will need to make similar changes to HTTP/2 but I'm not sure? cc @yanavlasov.

The "throws FrameFloodException" in the H2 codec are protected by either dispatching_downstream_data_ or dispatching_, so I think uncaught exception shouldn't be a problem.  I need to look into this further but I think we have the problem of  incrementOutboundFrameCount only throwing when dispatching_downstream_data_ is true.  Calls to ConnectionImpl::addOutboundFrameFragment under an upstream read callback will buffer infinitely (up to flow control limits).

@antoniovicente it looks like on TSAN IpVersions/IntegrationTest.TestFloodUpstreamErrors/IPv6 hung. Can you maybe try locally with --runs_per_test just to see if we now have a flake? Thank you.
/wait

@antoniovicente it looks like on TSAN IpVersions/IntegrationTest.TestFloodUpstreamErrors/IPv6 hung. Can you maybe try locally with --runs_per_test just to see if we now have a flake? Thank you.
/wait

It is a consistent failure.  The test case I added takes requires processing over a thousand tiny responses before it fills the TCP connection buffer.  Setting SO_RCVBUF to 1024 on the client connection reduces the time until the socket backs up.  In opt mode the test case runs in about 2 seconds, but under tsan it takes 20 seconds for each of ipv4/ipv6 (down from 120 secs each before the SO_RCVBUF change).


The training script on SOP dataset

Hello~
I find the repo lack the runing script of SOP dataset in 'language_guidance_benchmark_runs.sh'. Is it convenient to provide the corresponding script? Thanks a lot!

As benefits on finegrained datasets are somewhat limited using the standard language guidance setup, we have primarily included sample runs for datasets with a more usable class separation.
To make it work, simply replace the training dataset in either one of the sample runs for cub200 or cars196 with online_products, though you do need to account for the specific weighting of the language regularization.
I'll make sure to include some sample runs for SOP in the near future just as a reference :).


Add a lot of functions by Dinghow

I've done a lot of work to the hexo theme. You can see the details in README

Add Disqus
Add livere
Add Addthis
Add About page
Add Friend link page
Add multi-language support
Add inner math type support (install hexo-math at first and may need proxy)
Support edit favicon in _config.yml
Fix some syntax error

Firstly，thanks for your good work！
Secondly, I am refactoring this project recently. （Including its css, ejs...）
Thirdly，I will refer to your ‘commits’ and indicate the contribution of you.

Fine, I hope this project could be better and better~

@Dinghow
Hello, maybe you need to redo About-page and  Friend-link-page，describe in detail how to use the gitalk script！
If you are willing to do the work, it would be wonderful.
Surely，thanks for you contributions of  Add-livere，Add-multi-language-support，Add-math-type-support and Fix-some-syntax-error. The related code has been added to the project

@Dinghow
Hello, maybe you need to redo About-page and Friend-link-page，describe in detail how to use the gitalk script！
If you are willing to do the work, it would be wonderful.
Surely，thanks for you contributions of Add-livere，Add-multi-language-support，Add-math-type-support and Fix-some-syntax-error. The related code has been added to the project

OK, It's glad to see your update. I will do those jobs after this busy semester.


Android Basics: tip-calculator

URL of codelab
URL
In which task and step of the codelab can this issue be found?
The problem is in the "Calculate the tip" task, step 4.
Describe the problem
This line:
binding.tipResult.text = getString(R.string.tip_amount, formattedTip)

doesn't work. This just sets binding.tipResult.text to simply "Tip Amount", and does not include formattedTip.
Steps to reproduce?
N/A? Or just follow the codelab.
Versions
Android Studio version: 4.0.1
API version of the emulator:  23
Additional information
I am a beginner in Kotlin and Android Studio but I think I've solved it.
getString() is supposed to convert an integer to string (I'm not really sure how, all I know is that R.string.tip_amount is an integer) but the codelab is trying to feed an integer and a string into it.
I've got it to work properly using this:
binding.tipResult.text = "${getString(R.string.tip_amount)} $formattedTip"

If you're curious, this is my strings.xml:
<resources>
    <string name="app_name">tip calculator</string>
    <string name="round_up_tip">Round up tip?</string>
    <string name="ok_15">OK (15%)</string>
    <string name="good_18">Good (18%)</string>
    <string name="amazing_20">Amazing (20%)</string>
    <string name="how_was_the_service">How was the service?</string>
    <string name="cost_of_service">Cost of Service</string>
    <string name="calculate">Calculate</string>
    <string name="tip_amount">Tip Amount</string>
</resources>

@kerphloo
Thank you for reaching out to us.
In the task 4 Calculate Tip -> Display the tip
You are supposed to update your strings.xml. I don't see your file is updated.

<string name="tip_amount">Tip Amount: %s</string>

If you update your file, the following code given in the  in the codelab should work as expected.

val formattedTip = NumberFormat.getCurrencyInstance().format(tip)
binding.tipResult.text = getString(R.string.tip_amount, formattedTip)


Aasveen/myprerelease

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

Skype/Trusted-Application-API/docs/Samples.md
:white_check_mark:Succeeded

Skype/Trusted-Application-API/samples/readme.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

:warning: Validation status: warnings

File
Status
Preview URL
Details

Skype/Trusted-Application-API/samples/AzureWebSamples/readme.md
:warning:Warning

Details

Skype/TOC.md
:warning:Warning

Details

Skype/Trusted-Application-API/docs/AquireServiceNumber.md
:white_check_mark:Succeeded

Skype/Trusted-Application-API/docs/AssignServiceNumber.md
:white_check_mark:Succeeded

Skype/Trusted-Application-API/docs/Samples.md
:white_check_mark:Succeeded

Skype/Trusted-Application-API/docs/TrustedApplicationEndpoint.md
:white_check_mark:Succeeded

Skype/Trusted-Application-API/samples/readme.md
:white_check_mark:Succeeded

Skype/Trusted-Application-API/samples/AzureWebSamples/readme.md

Line 13: [Warning] Invalid file link:(~/Trusted-Application-API/samples/AzureWebSamples/TODO).
Line 29: [Warning] Invalid file link:(~/Trusted-Application-API/samples/AzureWebSamples/TODO).
Line 52: [Warning] Invalid file link:(~/Trusted-Application-API/samples/AzureWebSamples/TODO).
Line 58: [Warning] Invalid file link:(~/Trusted-Application-API/samples/AzureWebSamples/TrustedApplicationEndpoint.md).

Skype/TOC.md

[Warning] Invalid file link:(~/Trusted-Application-API/docs/AssignServiceNumber.md).

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

:warning: Validation status: warnings

File
Status
Preview URL
Details

Skype/Trusted-Application-API/samples/AzureWebSamples/readme.md
:warning:Warning

Details

Skype/TOC.md
:warning:Warning

Details

Skype/Trusted-Application-API/docs/AquireServiceNumber.md
:white_check_mark:Succeeded

Skype/Trusted-Application-API/docs/AssignServiceNumber.md
:white_check_mark:Succeeded

Skype/Trusted-Application-API/docs/Samples.md
:white_check_mark:Succeeded

Skype/Trusted-Application-API/docs/TrustedApplicationEndpoint.md
:white_check_mark:Succeeded

Skype/Trusted-Application-API/samples/readme.md
:white_check_mark:Succeeded

Skype/Trusted-Application-API/samples/AzureWebSamples/readme.md

Line 58: [Warning] Invalid file link:(~/Trusted-Application-API/samples/AzureWebSamples/TrustedApplicationEndpoint.md).

Skype/TOC.md

[Warning] Invalid file link:(~/Trusted-Application-API/docs/AssignServiceNumber.md).

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

Skype/TOC.md
:white_check_mark:Succeeded

Skype/Trusted-Application-API/docs/AquireServiceNumber.md
:white_check_mark:Succeeded

Skype/Trusted-Application-API/docs/AssignServiceNumber.md
:white_check_mark:Succeeded

Skype/Trusted-Application-API/docs/Samples.md
:white_check_mark:Succeeded

Skype/Trusted-Application-API/docs/TrustedApplicationEndpoint.md
:white_check_mark:Succeeded

Skype/Trusted-Application-API/samples/AzureWebSamples/readme.md
:white_check_mark:Succeeded

Skype/Trusted-Application-API/samples/readme.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

Skype/TOC.md
:white_check_mark:Succeeded

Skype/Trusted-Application-API/docs/AquireServiceNumber.md
:white_check_mark:Succeeded

Skype/Trusted-Application-API/docs/AssignServiceNumber.md
:white_check_mark:Succeeded

Skype/Trusted-Application-API/docs/Samples.md
:white_check_mark:Succeeded

Skype/Trusted-Application-API/docs/TrustedApplicationEndpoint.md
:white_check_mark:Succeeded

Skype/Trusted-Application-API/samples/AzureWebSamples/readme.md
:white_check_mark:Succeeded

Skype/Trusted-Application-API/samples/readme.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

Skype/TOC.md
:white_check_mark:Succeeded

Skype/Trusted-Application-API/docs/AquireServiceNumber.md
:white_check_mark:Succeeded

Skype/Trusted-Application-API/docs/AssignServiceNumber.md
:white_check_mark:Succeeded

Skype/Trusted-Application-API/docs/Samples.md
:white_check_mark:Succeeded

Skype/Trusted-Application-API/docs/TrustedApplicationEndpoint.md
:white_check_mark:Succeeded

Skype/Trusted-Application-API/samples/AzureWebSamples/readme.md
:white_check_mark:Succeeded

Skype/Trusted-Application-API/samples/readme.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

Skype/TOC.md
:white_check_mark:Succeeded

Skype/Trusted-Application-API/docs/AquireServiceNumber.md
:white_check_mark:Succeeded

Skype/Trusted-Application-API/docs/AssignServiceNumber.md
:white_check_mark:Succeeded

Skype/Trusted-Application-API/docs/Samples.md
:white_check_mark:Succeeded

Skype/Trusted-Application-API/docs/TrustedApplicationEndpoint.md
:white_check_mark:Succeeded

Skype/Trusted-Application-API/samples/AzureWebSamples/readme.md
:white_check_mark:Succeeded

Skype/Trusted-Application-API/samples/readme.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

Skype/TOC.md
:white_check_mark:Succeeded

Skype/Trusted-Application-API/docs/AquireServiceNumber.md
:white_check_mark:Succeeded

Skype/Trusted-Application-API/docs/AssignServiceNumber.md
:white_check_mark:Succeeded

Skype/Trusted-Application-API/docs/Samples.md
:white_check_mark:Succeeded

Skype/Trusted-Application-API/docs/TrustedApplicationEndpoint.md
:white_check_mark:Succeeded

Skype/Trusted-Application-API/samples/AzureWebSamples/readme.md
:white_check_mark:Succeeded

Skype/Trusted-Application-API/samples/readme.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

Skype/TOC.md
:white_check_mark:Succeeded

Skype/Trusted-Application-API/docs/AquireServiceNumber.md
:white_check_mark:Succeeded

Skype/Trusted-Application-API/docs/AssignServiceNumber.md
:white_check_mark:Succeeded

Skype/Trusted-Application-API/docs/Samples.md
:white_check_mark:Succeeded

Skype/Trusted-Application-API/docs/TenantAdminConsent.md
:white_check_mark:Succeeded

Skype/Trusted-Application-API/docs/TrustedApplicationEndpoint.md
:white_check_mark:Succeeded

Skype/Trusted-Application-API/samples/AzureWebSamples/readme.md
:white_check_mark:Succeeded

Skype/Trusted-Application-API/samples/readme.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

:x: Validation status: errors

File
Status
Preview URL
Details

:x:Error

Details

Line 16: [Error] Restore nuget package W:\ky21-s.optemp\packages\opbuild.scripts.1.32.2\tools\packages.config in folder:W:\ky21-s.optemp\packages failed, possibly due to transient errors from nuget servers. Please retry building your content. If the issue still happens, open a ticket in http://SiteHelp. Detailed error: Unable to read package from path 'docfx.console.2.17.1.nupkg'.

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

Skype/TOC.md
:white_check_mark:Succeeded

Skype/Trusted-Application-API/docs/AquireServiceNumber.md
:white_check_mark:Succeeded

Skype/Trusted-Application-API/docs/AssignServiceNumber.md
:white_check_mark:Succeeded

Skype/Trusted-Application-API/docs/Samples.md
:white_check_mark:Succeeded

Skype/Trusted-Application-API/docs/TenantAdminConsent.md
:white_check_mark:Succeeded

Skype/Trusted-Application-API/docs/TrustedApplicationEndpoint.md
:white_check_mark:Succeeded

Skype/Trusted-Application-API/docs/images/AzureWebAppPic1.PNG
:white_check_mark:Succeeded

Skype/Trusted-Application-API/samples/AzureWebSamples/readme.md
:white_check_mark:Succeeded

Skype/Trusted-Application-API/samples/readme.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

Skype/TOC.md
:white_check_mark:Succeeded

Skype/Trusted-Application-API/docs/AquireServiceNumber.md
:white_check_mark:Succeeded

Skype/Trusted-Application-API/docs/AssignServiceNumber.md
:white_check_mark:Succeeded

Skype/Trusted-Application-API/docs/Samples.md
:white_check_mark:Succeeded

Skype/Trusted-Application-API/docs/TenantAdminConsent.md
:white_check_mark:Succeeded

Skype/Trusted-Application-API/docs/TrustedApplicationEndpoint.md
:white_check_mark:Succeeded

Skype/Trusted-Application-API/docs/images/AzureWebAppPic1.PNG
:white_check_mark:Succeeded

Skype/Trusted-Application-API/samples/AzureWebSamples/readme.md
:white_check_mark:Succeeded

Skype/Trusted-Application-API/samples/readme.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

Skype/TOC.md
:white_check_mark:Succeeded

Skype/Trusted-Application-API/docs/AquireServiceNumber.md
:white_check_mark:Succeeded

Skype/Trusted-Application-API/docs/AssignServiceNumber.md
:white_check_mark:Succeeded

Skype/Trusted-Application-API/docs/Samples.md
:white_check_mark:Succeeded

Skype/Trusted-Application-API/docs/TenantAdminConsent.md
:white_check_mark:Succeeded

Skype/Trusted-Application-API/docs/TrustedApplicationEndpoint.md
:white_check_mark:Succeeded

Skype/Trusted-Application-API/docs/images/AzureWebAppPic1.PNG
:white_check_mark:Succeeded

Skype/Trusted-Application-API/samples/AzureWebSamples/readme.md
:white_check_mark:Succeeded

Skype/Trusted-Application-API/samples/readme.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

Skype/TOC.md
:white_check_mark:Succeeded

Skype/Trusted-Application-API/docs/AquireServiceNumber.md
:white_check_mark:Succeeded

Skype/Trusted-Application-API/docs/AssignServiceNumber.md
:white_check_mark:Succeeded

Skype/Trusted-Application-API/docs/Samples.md
:white_check_mark:Succeeded

Skype/Trusted-Application-API/docs/TenantAdminConsent.md
:white_check_mark:Succeeded

Skype/Trusted-Application-API/docs/TrustedApplicationEndpoint.md
:white_check_mark:Succeeded

Skype/Trusted-Application-API/docs/images/AzureWebAppPic1.PNG
:white_check_mark:Succeeded

Skype/Trusted-Application-API/samples/AzureWebSamples/readme.md
:white_check_mark:Succeeded

Skype/Trusted-Application-API/samples/readme.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Implement support for optional objects in openapi 3.1.0

Currently mapping from openapi 3.1.0 nullable types only works with the types array which does not support object. This pr provides mapping for oneOf (object | null) to the legacy style mapping. See the following input openapi spec:
openapi: 3.1.0
components:
  schemas:
    NullableObject:
      type: object
      properties:
        field:
          oneOf:
            - type: 'null'
            - $ref: '#/components/schemas/TheObject'
    TheObject:
      properties:
        name:
          type: string

It would be updated to this openapi spec after this pr:
openapi: 3.1.0
components:
  schemas:
    NullableObject:
      type: object
      properties:
        field:
          allOf:
            - $ref: '#/components/schemas/TheObject'
          nullable: true
    TheObject:
      properties:
        name:
          type: string

Nice one. Thanks for the contribution


[FLINK-28975][connector/base] Add IdlenessManager for main and per-split output in source operator to mark idleness only if both outputs are idle

Unchanged backport of #20760 on release-1.16

@flinkbot run azure


Delete tar option

I feel it is useful to have the delete tar file option when extract or check with zstash. This function is particularly useful for simulations with large data size. I recently ran an ensemble simulations. Each member has over 30 tar files. Checking them almost used up all my scratch space.

This has been merged: https://github.com/E3SM-Project/zstash/commit/1961c45aad02fc03377e714c6766e9fb7241d55f


Deep debugging with symbols in VS

I want to debug asp net source code (i use nuget)
I try some source server urls. Unsuccessfully.
Add please .PDB files on any symbol server if it not exists.
Thanks.

@lobster2012-user, we have symbols for our RTM builds available on  https://dotnet.myget.org/F/aspnetcore-master/symbols/. An alternative to using symbols is to use global.json to link to the cloned Mvc repo. This will compile your application against Mvc's sources which would help in cases where the compiler has optimized away chunks of code. https://blogs.msdn.microsoft.com/webdev/2015/02/06/debugging-asp-net-5-framework-code-using-visual-studio-2015/ is a blog post that uses RC1 + DNX, but you should be able to do something similar with RTM + dotnet.

Follow up work item to enable this for nightlies is here - https://github.com/aspnet/Coherence/issues/124

@pranavkm
Hm, Routing Hosting StaticFiles missed in
https://dotnet.myget.org/F/aspnetcore-master/symbols/.

They same to be there

https://dotnet.myget.org/feed/aspnetcore-master/package/nuget/Microsoft.AspNetCore.Routing
https://dotnet.myget.org/feed/aspnetcore-master/package/nuget/Microsoft.AspNetCore.Routing.Abstractions
https://dotnet.myget.org/feed/aspnetcore-master/package/nuget/Microsoft.AspNetCore.StaticFiles

etc (check the symbols node)

@pranavkm
Yes, all ok. Thanks!


Update references to hankchizljaw

Hi Andy, thanks for the excellent hylia.
in package.json there are four references to andybelldesign. Need to replace those with hankchizljaw.
There are other references in README.md too.
Thanks. Andrew

Good catch! They all redirect, but still worth doing.


Update get-clients.md

https://github.com/MicrosoftDocs/OfficeDocs-SkypeForBusiness/issues/5088
Edited wording.

@JohanFreelancer9 Copy editing is needed for this PR. Thanks.

@SerdarSoysal PR has been copyedited and is ready for final review, could you please check and merge? Thanks!

@SerdarSoysal


player.getOpenInventory() returning unexpected values (never an empty optional)

I've been working on inventory stuff lately and I've encountered a somewhat unexpected behavior when using "player.getOpenInventory()". Since it returns an optional, I'd assume it'd be an empty optional if the player doesn't have an open inventory.
What I've noticed, on the other hand, weirdly enough, is that the optional is never empty, even when the player is not currently seeing any inventory. In this case (the player not having an open inventory), the method returns the player's own inventory.
I feel this is pretty weird, since it gives me no way of knowing if the player is actually seeing an inventory or not. Is this intended? Could it be changed or fixed?
Thanks for your time and support beforehand.

See #1011.


Document Framework option for install command

https://github.com/NuGet/NuGet.Client/pull/1634 introduced a Framework option for the install command.

@hickford,
Thanks for having already signed the Contribution License Agreement. Your agreement was validated by .NET Foundation. We will now review your pull request.
Thanks,
.NET Foundation Pull Request Bot

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/Tools/cli-ref-install.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Thanks for adding that!


Parallax effect and Merged AppBar problems

I have had problems with the parallax effect (BackdropBottomSheetBehavior) and the (MergedAppBarLayoutBehavior) in some specific devices: LG K20 Android 7.0 and Samsung Note 8 Android 7.0 The Backdrop element doesn't move always, some times it freezes anywhere in the middle when changing from COLLAPSED to ANCHOR_POINT and reverse. In addition the MergedAppBarLayoutBehavior behaves similar when changing from EXPANDED to ANCHOR_POINT.
Watch this video to see better: https://mega.nz/#!NJVWQASD!LU7CMAHwDy0CiAyD14dCygUVPoiK8G3owR5G22O3Zmg
I don't understand why this is happening.

Neither I but I'm guessing it's related to Android 7.0 . Have you tried with devices with another SO version? like 5.0, 6.0, 7.1.1, 8
It would be good if we can know in which OS is happening.
At this moment I'm too bussy, so I can't help you in the search, if you can found the problem and create a pull request with the solution, the community will say thank you :)

I have tested all that versions, even custom and stock in devices like Samsung, HTC, LG, Xiaomi, BLU, Sony and only this 2 devices shows the problem, I think is something related to a firmware customization by OEM  because I have tested in Note 8 but diferent android version and works fine, then after update OS, the problem shows again

So can we say it's happening only in LG K20 Android 7.0 and Samsung Note 8 Android 7.0 as you said before right?
If so we have 2 options:

you can debug the library using those device in order to find whats going on and create a pull request.
if you don't have time for it, you can leave the steps needed to reproduce the issue and I hope some day I can have free time to check it. Besides I will change the tilte of the issue for something more accurated to this issue.

I wouldn't like to say only in LG K20 and Note 8 Android 7.0 because there are lots of devices I have not tested but it is a start point. I had the chance to debug the lib in the LG K20 (a friend's phone) but it was too little time and I didn't get anything wrong.
I have the apk lib sample installed in my phone (S7 in which works perfectly) and every time I can I test it in other devices in order to know if there is any pattern or whatever.
The steps to reproduce the issue is very simple just run the sample you provide, that's all I did in the video I shared (the device of the video is the LG K20)

I don't understand about the LG K20, can you reproduce the issue in the real device or not?

The steps to reproduce the issue is very simple just run the sample you provide, that's all I did in the video I shared (the device of the video is the LG K20)

Of course the issue can be reproduced in a real device that's what I have been talking all the time specifically the LG K20 and Note 8. (Sorry if I wasn't clear about this) To reproduce the issue just clone this lib, open it with Android Studio and click Run... The issue appears only in LG K20 and Note 8 with Android 7.0 AFAIK.

I had the chance to debug the lib in the LG K20 (a friend's phone) but it was too little time and I didn't get anything wrong.
I mean I didn't find any bug debugging but the lib behaves wrong.

Like you I don't have too much time right now, but it will be really nice to fix this because I had used this lib in some projects and I recommended it to some friends to use it too.
Thanks in advance

oh I got it! well first of all thank you for sharing what you found.
Second, you are right, we need to found what's going on in those devices.
and third, thank you for recommend the library :D.


TypeError upon executing any verb

Receiving a TypeError upon executing any very or plain bugzoo (v 2.1.24):
bugzoo build --help
Traceback (most recent call last):
  File "/home/user/bugzoo_venv/bin/bugzoo", line 6, in <module>
    from bugzoo.cli.app import main
  File "/home/user/bugzoo_venv/lib/python3.5/site-packages/bugzoo/__init__.py", line 2, in <module>
    from bugzoo.client import Client
  File "/home/user/bugzoo_venv/lib/python3.5/site-packages/bugzoo/client/__init__.py", line 4, in <module>
    from .bug import BugManager
  File "/home/user/bugzoo_venv/lib/python3.5/site-packages/bugzoo/client/bug.py", line 5, in <module>
    from ..core.bug import Bug
  File "/home/user/bugzoo_venv/lib/python3.5/site-packages/bugzoo/core/__init__.py", line 1, in <module>
    from .bug import Bug
  File "/home/user/bugzoo_venv/lib/python3.5/site-packages/bugzoo/core/bug.py", line 12, in <module>
    from .coverage import CoverageInstructions
  File "/home/user/bugzoo_venv/lib/python3.5/site-packages/bugzoo/core/coverage.py", line 29, in <module>
    class CoverageInstructions(object):
  File "/home/user/bugzoo_venv/lib/python3.5/site-packages/bugzoo/core/coverage.py", line 42, in CoverageInstructions
    ) -> Optional[Type['CoverageInstructions']]:
  File "/usr/lib/python3.5/typing.py", line 649, in __getitem__
    return Union[arg, type(None)]
  File "/usr/lib/python3.5/typing.py", line 552, in __getitem__
    dict(self.__dict__), parameters, _root=True)
  File "/usr/lib/python3.5/typing.py", line 512, in __new__
    for t2 in all_params - {t1} if not isinstance(t2, TypeVar)):
  File "/usr/lib/python3.5/typing.py", line 512, in <genexpr>
    for t2 in all_params - {t1} if not isinstance(t2, TypeVar)):
  File "/usr/lib/python3.5/typing.py", line 1077, in __subclasscheck__
    if super().__subclasscheck__(cls):
  File "/home/user/bugzoo_venv/lib/python3.5/abc.py", line 225, in __subclasscheck__
    for scls in cls.__subclasses__():
TypeError: descriptor '__subclasses__' of 'type' object needs an argument

Installed on an Ubuntu Xenial (16.04, amd64) machine "with the latest updates" using the following commands:
sudo apt install python3-dev
virtualenv --python=python3 $HOME/bugzoo_venv
source $HOME/bugzoo_venv/bin/activate
pip3 install bugzoo

Tried v2.1.16, just to see if this is something with the latest release only. But then I get:
Traceback (most recent call last):
  File "/home/user/bugzoo_venv/lib/python3.5/site-packages/urllib3/connectionpool.py", line 600, in urlopen
    chunked=chunked)
  File "/home/user/bugzoo_venv/lib/python3.5/site-packages/urllib3/connectionpool.py", line 354, in _make_request
    conn.request(method, url, **httplib_request_kw)
  File "/usr/lib/python3.5/http/client.py", line 1106, in request
    self._send_request(method, url, body, headers)
  File "/usr/lib/python3.5/http/client.py", line 1151, in _send_request
    self.endheaders(body)
  File "/usr/lib/python3.5/http/client.py", line 1102, in endheaders
    self._send_output(message_body)
  File "/usr/lib/python3.5/http/client.py", line 934, in _send_output
    self.send(msg)
  File "/usr/lib/python3.5/http/client.py", line 877, in send
    self.connect()
  File "/home/user/bugzoo_venv/lib/python3.5/site-packages/docker/transport/unixconn.py", line 42, in connect
    sock.connect(self.unix_socket)
PermissionError: [Errno 13] Permission denied

and a bunch more of those. Not sure what is going on.
On this machine my user is not a member of the docker group. Could that be related somehow?

2.1.20 throws TypeErrors at me again.

Do you mind sharing your $ pip list with me?

With the venv active, or not?

With venv active:
Package          Version
---------------- ----------
attrs            18.2.0
bugzoo           2.1.24
cement           3.0.2
certifi          2018.11.29
chardet          3.0.4
Click            7.0
docker           3.7.0
docker-pycreds   0.4.0
dockerpty        0.4.1
Flask            1.0.2
gitdb2           2.0.5
GitPython        2.1.11
idna             2.8
itsdangerous     1.1.0
Jinja2           2.10
MarkupSafe       1.1.0
mypy-extensions  0.4.1
pip              19.0.1
pkg-resources    0.0.0
psutil           5.5.0
PyYAML           3.13
requests         2.21.0
setuptools       40.8.0
six              1.12.0
smmap2           2.0.5
tabulate         0.8.3
urllib3          1.24.1
websocket-client 0.54.0
Werkzeug         0.14.1
wheel            0.32.3

Just tried a different system (also Ubuntu Xenial (16.04, amd64) with the same procedure, and 2.1.24 also throws a TypeError.

Ok, just found Optional[Type[Foo]] raises TypeError in Python 3.5.2 on SO:

This is a bug in Python 3.5.2.

and sure enough:
$ python3 --version
Python 3.5.2

Installed Python 3.6 (from this ppa; couldn't quickly find any more sanctioned way to upgrade the 3.5.x Xenial comes with) the normal installation steps result in a venv with a working BugZoo.
Or at least: I now get a (probably expected) Permission denied error ($USER is not a member of docker group).
@ChrisTimperley: are you on Xenial on not using Ubuntu at all?

Seeing as this is a bug in Python and not BugZoo, I'll close this.
@ChrisTimperley: might be something to mention in the documentation / readme?


Optional field missing in the generated docs

In the genearated docs, optional is missing for attachments: https://github.com/bioimage-io/spec-bioimage-io/blob/gh-pages/rdf_spec_latest.md
In addition, I think we should add required for every field that is not optional, it will make the docs easier to read. Especially when searching for a certain keyword, it's not intuitive to remember "no optional means required".

@FynnBe Could you please look into this when you got some time?

should be fixed by https://github.com/bioimage-io/spec-bioimage-io/pull/386

@FynnBe Thanks for fixing it!
Now, looking at the generated docs in main branch, why there are some fields such as cite did not mark as optional (nor required), is that intended? I think maybe better to make it always explicit.
Another minor suggestion to improve the readablity is to put option/required and type to a bracket.
For example:

icon optional String an icon for the resource

It would be more readable if it's something like this:

icon: (optional, String) an icon for the resource

Now, looking at the generated docs in main branch, why there are some fields such as cite did not mark as optional (nor required), is that intended? I think maybe better to make it always explicit.

no, that was not intended. I did want to remove the required/optional from inner types, such as the CiteEntry in cite: (required List[CiteEntry]).... I'll try to fix that

Another minor suggestion to improve the readablity is to put option/required and type to a bracket.

good idea 👍

fixed/implemented in https://github.com/bioimage-io/spec-bioimage-io/pull/387


redesign team (to api)

redesign team to api

add new fields: country, city and university

team was removed


Plugin Updates May 2023

Plugins updates for (advanced-custom-fields-pro,forms-for-campaign-monitor,iframely,newspack-newsletters,pantheon-advanced-page-cache,rss-importer,wordpress-importer,wordpress-seo)

@rpeterman-gp Can you take a look? Thanks!!!


API Insights

How did you obtain all the function offsets in TomCruise/dllmain.cpp : ComputeFunctionOffsets?
Would it be possible to extract more game statistics (e.g. number of factories on island, ship unload statistics - as displayed in the storage tab)?

Hi,
Thank you for your interest!
How did you obtain all the function offsets in TomCruise/dllmain.cpp : ComputeFunctionOffsets?
I'm not using a particular method. I try to collect information wherever I can and string it together.

Would it be possible to extract more game statistics (e.g. number of factories on island, ship unload statistics - as displayed in the storage tab)?

Most likely. It's quite hit-and-miss what is easy and what is not in this context. We'd have to try out the particular thing you're looking for. Some things might seem hard, but is in reality easy and vice versa.
Send me a private message if you want more info.
Cheers


Feature/core update

Updating to build against netstandard1.6 and work with NET Core. Upgraded references to Nito.AsyncEx.* and adjust the rest of the build and related code.

You can completely remove AsyncReaderWriterLockDictionary.UpgradeableReaderKey, it isn't referenced anymore. I also left 3 line comments about how to document CancellationToken parameters.

It looks like the unit tests didn't actually run:
https://ci.appveyor.com/project/timothy-shields/async-data-structures/build/1.0.6

The checks are going to fail because AppVeyor does not currently provide a build profile for MSBuild 15.


Update all major base images to have libgbm library

To be able to run Cypress v5.0.0 on cypress/base:10, cypress/base:12, and cypress/base:14

cypress/base:12.18.3 is cypress/base:12 and cypress/base:latest

All these images should be able to run Cypress v5

Hi there, sorry to dig out this issue.
I still have this issue concerning Cypress v5 (more details here: https://github.com/cypress-io/circleci-orb/issues/308) when trying to use the cypress/base:14 image  into circle-ci pipeline.
Since there is no closing comment, I wonder if anyone has found a solution for this ?


Could you share dev instructions?

Would love to look at how I could contribute to this!
Specific questions:

Do you need to run the wasm things locally and how do you do so?
I cloned the repo locally, in client ran yarn and then yarn start, and I'm getting some TS errors:

Compiled with problems:X

ERROR in src/components/Panels/Side/Right/Test/Function.tsx:62:5

TS2322: Type 'never[]' is not assignable to type 'KV'.
  Index signature for type 'string' is missing in type 'never[]'.
    60 |   const [txVals, setTxVals] = useState<TxVals>({
    61 |     name: ixs.name,
  > 62 |     additionalSigners: [],
       |     ^^^^^^^^^^^^^^^^^
    63 |   });
    64 |   const [errors, setErrors] = useState<{ [key: string]: number }>({});
    65 |   const [loading, setLoading] = useState(false);

ERROR in src/utils/pg/test.ts:298:54

TS2345: Argument of type '(string | number | PublicKey | Signer | BN)[]' is not assignable to parameter of type 'Signer[]'.
  Type 'string | number | PublicKey | Signer | BN' is not assignable to type 'Signer'.
    Type 'string' is not assignable to type 'Signer'.
    296 |     }
    297 |
  > 298 |     const txHash = await PgTx.send(tx, conn, wallet, additionalSigners);
        |                                                      ^^^^^^^^^^^^^^^^^
    299 |     return txHash;
    300 |   }
    301 | }

Is there something else I need to do/some specific config I could be missing to get it running locally? I'm using Node v16.16.0 (latest LTS).

Thank you for your interest in contributing!

Do you need to run the wasm things locally and how do you do so?

You don't need to do anything specific as the repo includes pre-built packages for easier builds locally. Running yarn would suffice.

I cloned the repo locally, in client ran yarn and then yarn start, and I'm getting some TS errors:

Not sure how that error occurs for you but not for me even though we are using the same version. But if that's the only error it should be pretty easy to fix. PR for the fix is welcome.


Kylel/semeval2017

just the NER portion

I have trained the model with the semeval2017 data and evaluated it afterwards with semeval2017 evaluation script. I'am confused why I get so different results:
"best_validation_f1-measure-overall": 0.5288376220052742
"test_f1-measure-overall": 0.4320540671010848,
Results reported by the semeval2017 evaluation script on test set:
precision   recall f1-score  support
Material     0.44     0.43     0.44      904
Process     0.41     0.36     0.38      954
Task     0.17     0.15     0.16      193
avg / total     0.40     0.37     0.39     2051
So F1 is 0.39.
Do you have maybe a reasonable explanation for this difference?

hey @arthurbra thanks for your interest!  i've been looking into this difference as well, and it looks like the task definitions are different between what we've implemented here & the original semeval2017 task.
specifically, the 3 tasks in semeval2017 are (1) entity identification, (2) entity type classification, and (3) relation extraction.  what we've implemented here combines both (1) and (2) into a single task (we're both extraction & tagging w/ the type at the same time).  this will affect how f1 scoring is performed.
instead of using the sequence tagging model we have here, my plan is to adapt an existing model made for the semeval2017 task, and substitute in the various bert variants to replace glove/w2v embeddings.

Hey @kyleclo thanks for your reply and explanation. I am really impressed by your results and want to learn more.
It is right, you perform entity identification and classification in one task. In my understanding this is task B in semeval 2017. In calculateMeasures of semeval2017 evaluation script you can pass the parameter remove_anno="rel" which should ignore relations during evaluation (as far as I understand the code). I already used this parameter in the evaluation of my prev. post. So I assume there should be an another explanation.
It would be great if you could apply the code of the semeval 2017 winner with BERT. Unfortunatelly I was not able to find it (AI2 system of Ammar et. al.).

Hi Kyle,
I think I have found the problem: in the prediction script model.eval() is not called, so that dropout is active during prediction.
Regards
Arthur


Refactor models and migration

code refactor
errors fix
improve VSCode debugging by Nodemon
improve package.json scripts
replace TSLint with ESLint
add ESLint rules
fix ESLint errors

budget-api/database.db.bak - I guess this file should not be committed and instead should be added to .gitignore


added some log messages during wait for problem event

To avoid a timeout on travis (which occurs after 10m of no console output), I've added some echoes during the waiting period until the problem.open event occurs

Codecov Report

Merging #2006 into master will decrease coverage by 0.08%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2006      +/-   ##
==========================================
- Coverage   34.08%   33.99%   -0.09%
==========================================
  Files         146      146
  Lines        9304     9304
  Branches      132      132
==========================================
- Hits         3171     3163       -8
- Misses       5709     5715       +6
- Partials      424      426       +2

Flag
Coverage Δ

#moduleA
35.17% <ø> (ø)

Impacted Files
Coverage Δ

api/ws/hub.go
62.50% <0.00%> (-14.29%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b3f1778...c739d06. Read the comment docs.


Updates to signature specification

Moves signed attributes out of payload
Defines new signed attributes and marks them as critical/informational
Introduces signature scheme to support different trust models

Signed-off-by: Milind Gokarn<EMAIL_ADDRESS>cc: roywill for review.

@roywill @shizhMSFT made minor changes to address your feedback. Let me know if more changes are required.


Update geth-entrypoint

use env var for GETH_DATA_DIR if set

🟡 Heimdall Review Status

Requirement
Status
More Info

Reviews

🟡
0/1

Denominator calculation

Show calculation

1 if user is bot
0

1 if user is external
0

From .codeflow.yml

1

Additional review requirements

Show calculation

Max
0

0

From CODEOWNERS

0

Global minimum
0

Max

1

1

1 if commit is unverified
0

Sum
1


Fix legacy multiline

We discovered that commas in legacy multiline options are replaced by newline which produced errors on configurations for bump2version.
Debug lead me to autocast which doesn't expect strings with both commas and newlines.

@ziima Just a warning, I will be removing the legacy stuff soon for version 1.0

How soon is soon?

Within a month, probably. I'm hoping to get it nearly there next week, since I have some time off.
Is there anything keeping you from switching to TOML (other than you have plenty of other things to do :) )?

We have quite a number of projects and we tend to upgrade project configuration only with major or minor releases. So I'd prefer longer period to transition all the projects' configuration while keeping an option to just do a patch without the need to upgrade the configuration. I guess I could handle that with <1 version of bump-my-version for some time.
Generally speaking, I'd suggest to keep the ability to read the INI configuration for some time, despite all the problems. I guess there's a number of projects which use bump2version or bumpversion and the configuration is basically part of its API. I believe keeping the compatibility would help users in transition to bump-my-version.

An idea I was throwing around in my head was to provide various hooks for plugins via Pluggy.
One of the hooks I could provide is for configuration reading. That would allow me to move "legacy" stuff to plugins.
What do you think?

OK, that seems reasonable. Plugins may be tricky though.


[local-volume] Bootstrapper uses default path for PV local path

I have setup three directories in the node to be used as local storage. The directories are /mnt/sda1/disks/vol<n>. But when i launch the bootstrapper, it detects the directories and creates a PV for each. But it incorrectly assigns the local path to be /mnt/disks/vol<n>. For some reason it is not using the path /mnt/sda1/disks/vol<n>.
This is seen in the provisioner logs:
I1115 23:40:23.180737       1 discovery.go:141] Found new volume at host path "/mnt/disks/vol1" with capacity<PHONE_NUMBER>, creating Local PV "local-pv-d0592836"
I1115 23:40:23.185020       1 discovery.go:156] Created PV "local-pv-d0592836" for volume at "/mnt/disks/vol1"
I1115 23:40:23.185088       1 cache.go:55] Added pv "local-pv-d0592836" to cache

This is what the local-volume configmaps looks like
$ kubectl -n kube-system get configmaps local-volume-config -o yaml
apiVersion: v1
data:
  storageClassMap: |
    local-storage:
      hostDir: "/mnt/sda1/disks"
      mountDir: "/local-disks"
kind: ConfigMap
metadata:
  creationTimestamp: 2017-11-15T23:40:02Z
  name: local-volume-config
  namespace: kube-system
  resourceVersion: "495"
  selfLink: /api/v1/namespaces/kube-system/configmaps/local-volume-config
  uid: 4d067a97-ca5e-11e7-9c4a-080027f80648

I am using minikube.

Did you launch the bootstrapper with the argument to your configmap name?

i just created the bootstrapper.yaml. Im assuming this is passing the config name argument in https://github.com/kubernetes-incubator/external-storage/blob/master/local-volume/bootstrapper/deployment/kubernetes/bootstrapper.yaml#L23. Is that correct?

Oh are you using the latest version of the provisioner?  We recently made a change to convert the configmap from json to yaml.  So if you're using the latest configmap yaml, then the v1.0.x provisioner is going to fail parsing the configmap and fallback to the defaults.

So I would use the yaml examples from this tag:
https://github.com/kubernetes-incubator/external-storage/tree/local-volume-provisioner-v1.0.1

Regardless, we should improve this by failing the provisioner bootup if we fail to parse the configmap, instead of falling back to defaults.  Only fallback to defaults if the configmap doesn't exist.
/area local-volume
/assign

Ah OK ill try it with the json config map. Do you think #463 is also related to config map data not being correct? Thanks @msau42

yeah I think they're related

Hi @msau42, the bootstrapper is still not using the values in the configmaps. I deployed with bootstrapper v1.0.0 and v1.0.1 to no avail.
Here is my configmap named local-volume-config:
$ kubectl -n kube-system get configmaps local-volume-config -o yaml
apiVersion: v1
data:
  local-storage: |
    {
      "hostDir": "/mnt/sda1/disks"
    }
kind: ConfigMap
metadata:
  creationTimestamp: 2017-11-16T19:22:35Z
  name: local-volume-config
  namespace: kube-system
  resourceVersion: "1963"
  selfLink: /api/v1/namespaces/kube-system/configmaps/local-volume-config
  uid: 80801d33-cb03-11e7-8585-080027adef5b

Logs from the bootstrapper pod:
$ kubectl -n kube-system logs local-volume-provisioner-bootstrap -f
I1116 19:26:31.358395       1 bootstrapper.go:356] Running bootstrap pod with config local-volume-config: {StorageClassConfig:map[] NodeLabelsForPV:[]}
I1116 19:26:31.367735       1 bootstrapper.go:368] Successfully created local volume provisioner

Logs from the provisioner:
$ kubectl -n kube-system logs local-volume-provisioner-9pftj -f
I1116 19:26:32.102249       1 main.go:58] Starting controller
I1116 19:26:32.102303       1 main.go:76] Could not get config map due to: resource name may not be empty, using default configmap
I1116 19:26:32.102309       1 main.go:79] Running provisioner with config map[local-storage:{HostDir:/mnt/disks MountDir:/local-disks}]
I1116 19:26:32.102318       1 controller.go:37] Initializing volume cache
I1116 19:26:32.102329       1 populator.go:85] Starting Informer controller
I1116 19:26:32.102660       1 populator.go:89] Waiting for Informer initial sync
I1116 19:26:33.103315       1 controller.go:58] Controller started
E1116 19:26:33.103352       1 discovery.go:91] Error reading directory: open /local-disks: no such file or directory

From the provisioner log, it seems that it is using the default HostDir.
I am using this to create the bootstrapper: https://github.com/kubernetes-incubator/external-storage/blob/local-volume-provisioner-v1.0.1/local-volume/bootstrapper/deployment/kubernetes/bootstrapper.yaml
Thanks.

You should also use bootstrapper:v1.0.1

Thanks @msau42. Using v1.0.1 instead of latest for both the bootstrapper and the provisioner did it for me. Feel free to close this issue.

Btw, any plans of when local-volume would be promoted to alpha? Currently i have to enable it via the feature-gates and restart kube-api which is a bit of a hassle.

I'll keep this issue open to come up with some better way to maintain the yamls in terms of versioning, and also deal with compatibility with K8s versions too.
cc @dhirajh

Regarding local storage going to beta, I'm hoping 1.10 if I can get the scheduler work merged in 1.9.

Also, regarding feature gates, you cannot directly pass in the feature gate when you initially bring up the cluster?

to summarize, some action items from this issue:

In provisioner bootup, fail if we can't parse the configmap, instead of falling back to defaults.  Maybe we should not even have defaults.
Provide versioned yamls for the boostrapper and provisioner.
Start a compatibility matrix for boostrapper/provisioner version vs K8s versions.

@msau42 i could pass the feature-gate when bringing up the cluster. But im more concerned with the case where k8s is setup and ready. Such as GKE, Azure Container Engine, CoreOS tectonic etc.
I am trying to integrate local-volume with Rook and ideally, i would like for Rook users to not have to do anything to their running k8s cluster to deploy Rook. It just should work like any other app :)

At least for GKE, you use the "--kubernetes-alpha" flag to bring up alpha clusters.  And because you don't have access to the master in GKE, the users can't enable specific alpha features after the fact.

Also for local volume, you need to enable the feature gate on all kubelets too, not just the master components.

/assign

/assign

/close


VotingPrinciple permissions

If you project a motion and voting shares are not enabled you get this error:

@FinnStutzenstein Can you look into this please? If voting shares are not enabled a client must not request voting principles. Alternatively, change permissions:
PrinciplesPermissionMixin

Will be fixed with #97

Not fixed in current master! To reproduce:

create new motion
create analog voting poll and enter some values for YNA
project the motion
open the projector
-> Projector shows error in JS console

GET /rest/openslides_voting/voting-principle/ 400 (Bad Request)
FAILED: Thu, 06 Sep 2018 11:04:07 GMT - GET /rest/openslides_voting/voting-principle/
[...]
detail: "Voting principles and shares are not enabled."

activate config "Enable voting shares"
reload projector => no error


Add path to shuttle map

API: https://api.syncromatics.com/routes/{id}/shapes
This is undocumented by Syncromatics, but was obtained from their support team. Returns coordinates to draw polyline for a route.

Polylines for the routes we need are not available per Syncromatics. We will continue to push for this feature and reopen this issue when that happens in the future.

Polylines for base routes are now available.
From Kevin @ Syncromatics:

The polyline information is now available via the API, but I'm still waiting on it to get documented in Apiary.  In the meantime, you should be able to start using the URL.  Here is the link:
https://api.syncromatics.com/portal/routes/[[route_id]]/shapes
You put in the base route ID and will get back pattern ID's with lines.  Note that this will only return lines that are currently visible to the public.  If a route pattern is enabled for operations, but not public, you won't see it.
Let me know if you have any questions about base routes (containers) vs patterns (individual routes), etc.

Sample response from https://api.syncromatics.com/portal/routes/748/shapes:
[
    {
        "patternId": 3440,
        "line": "mrvgEvxqjUx@Rr@^h@RdANfCR`BBLAtKCb@QnBNxAB~FEfEB@yHDMLCbAA`@@^@zA@Bt@Jl@?~@DrJBPLPN@lC@tD@bBA~D]f@QX[XWZGRC\\B^FVXb@X`BDlH?p@Ob@i@PaA?m@?mCHyA?w@LaEGi@K]o@k@c@]O_@Wu@c@_@k@[u@_@w@sAi@TcDfBy@f@q@Pu@@kA]q@e@i@gAUkAI_A@gL?iEBiBXaCE]h@uBv@yFFiA?gAc@}Aq@aA[Wg@UoCe@_GaAyC[iBOm@@_@HgB~@lBvFJf@P\\~@rDTfBGbAc@bAaBiBm@Ck@VeBpBm@^qAdBsAfBQ|@?bAX`CFr@A|@{@jDy@vDGbCmCCs@Ao@?mFHyOd@SDMHIPEVD|CM~AA`@YZB|BAfB"
    }
]

Polylines for base routes are now available.
From Kevin @ Syncromatics:

The polyline information is now available via the API, but I'm still waiting on it to get documented in Apiary. In the meantime, you should be able to start using the URL. Here is the link:
https://api.syncromatics.com/portal/routes/[[route_id]]/shapes
You put in the base route ID and will get back pattern ID's with lines. Note that this will only return lines that are currently visible to the public. If a route pattern is enabled for operations, but not public, you won't see it.
Let me know if you have any questions about base routes (containers) vs patterns (individual routes), etc.

Sample response from https://api.syncromatics.com/portal/routes/748/shapes:
[
    {
        "patternId": 3440,
        "line": "mrvgEvxqjUx@Rr@^h@RdANfCR`BBLAtKCb@QnBNxAB~FEfEB@yHDMLCbAA`@@^@zA@Bt@Jl@?~@DrJBPLPN@lC@tD@bBA~D]f@QX[XWZGRC\\B^FVXb@X`BDlH?p@Ob@i@PaA?m@?mCHyA?w@LaEGi@K]o@k@c@]O_@Wu@c@_@k@[u@_@w@sAi@TcDfBy@f@q@Pu@@kA]q@e@i@gAUkAI_A@gL?iEBiBXaCE]h@uBv@yFFiA?gAc@}Aq@aA[Wg@UoCe@_GaAyC[iBOm@@_@HgB~@lBvFJf@P\\~@rDTfBGbAc@bAaBiBm@Ck@VeBpBm@^qAdBsAfBQ|@?bAX`CFr@A|@{@jDy@vDGbCmCCs@Ao@?mFHyOd@SDMHIPEVD|CM~AA`@YZB|BAfB"
    }
]

Commit 7c01122 adds this functionality

This issue is being closed due to platform migration and may be revisited at a later date.


set max_local_storage_nodes to 1

@dannyroberts - this will prevent the machine from accidentally booting multiple versions of elasticsearch

i noticed some problems with this so closing for now (it's been undone on the india server)


Register transition in builder

In order to let the users execute code on a transition it could be encapsulated in a class
TODO add usage

@sylvainfilteau How would you see the usage for this case?

Implemented in #6


Isi data ulasan tiap provinsi biar ga nol

done. some inconsistency is expected due to manual input.


New package: Blushyes.Sofast version 0.2.6

Checklist for Pull Requests

[x] Have you signed the Contributor License Agreement?
[ ] Is there a linked Issue?

Manifests

[x] Have you checked that there aren't other open pull requests for the same manifest update/change?
[x] This PR only modifies one (1) manifest
[x] Have you validated your manifest locally with winget validate --manifest <path>?
[ ] Have you tested your manifest locally with winget install --manifest <path>?
[x] Does your manifest conform to the 1.6 schema?

Note: <path> is the directory's name containing the manifest you're submitting.

Microsoft Reviewers: Open in CodeFlow

Automatic Validation ended with:

Installation failed with exit code -1978335187
2024-11-21 00:59:11.008 [FAIL] Installer failed security check. Url: https://github.com/Blushyes/sofast-release/releases/download/v0.2.6/sofast_windows_v0.2.6_setup.exe Result: 0x80004005

Automated error analysis suggests -1978335187 may mean Installer failed security check. Another script should retry this every 18 hours.
Automated error analysis suggests 80004005 may mean Resource missing
(Automated response - build 899.)


[Bug]: jest-resolve activates resolution optimization that should not happen according to the code comments and semantics

Version
26.4.2
Steps to reproduce

put a a breakpoint on import/require line in test that will not be satisfied by moduleNameMapper
start jest in debuger
when breakpoint hit, put breakpoint on the problematic line: https://github.com/facebook/jest/blob/7dd17d541bcdb4d17d96b53586949fb195294040/packages/jest-resolve/src/resolver.ts#L181
jest runs to the line

Expected behavior
The code line should tries to do some optimization only if the moduleName does not contain a path separator;
Actual behavior
The optimization will be taken even if the moduleName contains path seperator.
Additional context
https://github.com/facebook/jest/blob/7dd17d541bcdb4d17d96b53586949fb195294040/packages/jest-resolve/src/resolver.ts#L174-L181
moduleName is taken "as is" from the require call/import statement, it will likely follow "URL conventions" (use forward slashes) so it might not match the current system env path().sep (on windows - back slash).
Environment
Windows 10

Wanna send a PR?

hard coding / sounds reasonable 🙂


WebViewWidget stops loading the url if its inside IndexedStack in IOS

Steps to reproduce
Using ios device do the following:

Initialize a WebViewController controller
Create a IndexedStack with index that is not pointing to WebViewWidget
Try to load the url in IOS device you will notice the progress stops immediately at value 11/100 or less

Expected results
Should load the url normally even when IndexedStack is not pointing to WebViewWidget
Actual results
8 out of 10 times it won't load the url
Code sample
Code sample
IndexedStack(
        index: 0,
        sizing: StackFit.expand,
        children: [
          const Center(
            child: CircularProgressIndicator(
              valueColor: AlwaysStoppedAnimation(Colors.white),
            ),
          ),
          WebViewWidget(controller: _controller),
          Center(
            child: Column(
              mainAxisAlignment: MainAxisAlignment.center,
              children: [
                Text(
                  locale.sorry,
                  style: const TextStyle(
                    fontSize: 40,
                    fontWeight: FontWeight.bold,
                    color: Colors.white,
                  ),
                ),
                const SizedBox(height: 5),
                Text(
                  locale.couldNotReachThePage,
                  style: const TextStyle(
                    fontSize: ConstantFonts.large,
                    fontWeight: FontWeight.bold,
                    color: Colors.white,
                  ),
                ),
                const SizedBox(height: 25),
                PrimaryButton(
                  text: locale.tryAgain,
                  width: 200,
                  onTap: _controller.reload,
                ),
              ],
            ),
          ),
        ],
      )

Flutter Doctor output
Doctor output
[✓] Flutter (Channel stable, 3.19.4, on macOS 14.4 23E214 darwin-arm64, locale en-KW)
    • Flutter version 3.19.4 on channel stable at /Users/yousefalmutairi/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 68bfaea224 (25 hours ago), 2024-03-20 15:36:31 -0700
    • Engine revision a5c24f538d
    • Dart version 3.3.2
    • DevTools version 2.31.1

[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.3)
    • Android SDK at /Users/yousefalmutairi/Library/Android/sdk
    • Platform android-34, build-tools 30.0.3
    • Java binary at: /Applications/Android Studio.app/Contents/jbr/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 17.0.6+0-17.0.6b802.4-9586694)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 15.3)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Build 15E204a
    • CocoaPods version 1.15.2

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2022.2)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • android-studio-dir = /Applications/Android Studio.app
    • Java version OpenJDK Runtime Environment (build 17.0.6+0-17.0.6b802.4-9586694)

[✓] VS Code (version 1.87.2)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.84.0

[✓] Connected device (4 available)
    • SM S711B (mobile) • <IP_ADDRESS>:5555        • android-arm64  • Android 14 (API 34)
    • iPhone (mobile)   • 00008130-000158AE3498001C • ios            • iOS 17.4 21E219
    • macOS (desktop)   • macos                     • darwin-arm64   • macOS 14.4 23E214 darwin-arm64
    • Chrome (web)      • chrome                    • web-javascript • Google Chrome 123.0.6312.59
    ! Error: Browsing on the local area network for iPhone 11 Pro Max. Ensure the device is unlocked and attached with a cable or associated with the same local area network as this Mac.
      The device must be opted into Developer Mode to connect wirelessly. (code -27)

[✓] Network resources
    • All expected network resources are available.

• No issues found!

Hi @YDA93, what version of webview_flutter & webview_flutter_wkwebview are you experiencing this issue with?
Does this work as expected on android?

@danagbemava-nc
Works perfectly on android. Never fails to load the url.
While in ios most of the time fails because the widget is not visible on the screen maybe.
I noticed the issue also persist when using PageView.
Currently my workaround is to wrap WebViewWidget with stack and show loading indicator above it instead of using IndexedStack or PageView.

workaround
Stack(
        children: [
          WebViewWidget(controller: _controller),
          IgnorePointer(
            ignoring: !_isLoading,
            child: Opacity(
              opacity: _isLoading ? 1 : 0,
              child: const Material(
                color: Colors.black54,
                child: Center(
                  child: LoadingIndicator(
                    color: Colors.white,
                    loadingIndicatorType: LoadingIndicatorType.fourRotatingDots,
                  ),
                ),
              ),
            ),
          ),
        ],
      )

pubspec.lock
  webview_flutter:
    dependency: "direct main"
    description:
      name: webview_flutter
      sha256: "25e1b6e839e8cbfbd708abc6f85ed09d1727e24e08e08c6b8590d7c65c9a8932"
      url: "https://pub.dev"
    source: hosted
    version: "4.7.0"
  webview_flutter_android:
    dependency: transitive
    description:
      name: webview_flutter_android
      sha256: f038ee2fae73b509dde1bc9d2c5a50ca92054282de17631a9a3d515883740934
      url: "https://pub.dev"
    source: hosted
    version: "3.16.0"
  webview_flutter_platform_interface:
    dependency: transitive
    description:
      name: webview_flutter_platform_interface
      sha256: d937581d6e558908d7ae3dc1989c4f87b786891ab47bb9df7de548a151779d8d
      url: "https://pub.dev"
    source: hosted
    version: "2.10.0"
  webview_flutter_wkwebview:
    dependency: transitive
    description:
      name: webview_flutter_wkwebview
      sha256: f12f8d8a99784b863e8b85e4a9a5e3cf1839d6803d2c0c3e0533a8f3c5a992a7
      url: "https://pub.dev"
    source: hosted
    version: "3.13.0"

Hi @YDA93, thanks for the update.
What were you trying to achieve by putting the Webview inside the IndexedStack? Please also share a complete minimal reproducible code sample.
Thank you


Make Sure Only root users can Create Updates

Related to https://github.com/opencollective/opencollective/issues/4325
Thanks for pointing this out @Betree. 😉

Looking great! Looks like we need to adapt a test as well

@Betree : Thanks, I've missed the test. Just corrected that. 😄

Why decide that "only root users can create changelog entries" instead of "changelog entries can only be created on the opencollective account"?

@znarf We may want to enable posting changelog entries from https://opencollective.com/engineering/updates (and similar) in the future, so that makes things a bit more flexible.

Why decide that "only root users can create changelog entries" instead of "changelog entries can only be created on the opencollective account"?

@znarf We may want to enable posting changelog entries from https://opencollective.com/engineering/updates (and similar) in the future, so that makes things a bit more flexible.

@Betree : Correct me if I am wrong @Betree , but my thinking is that on the API side we didn't have a check; so when creating a changelog update we only used to check on the front-end side whether the collective is indeed opencollective. So adding root user on the api makes sense for now, until we add this support for adding changelog updates for other collectives such as engineering. So I'll keep this as is for now? 🤔

Why decide that "only root users can create changelog entries" instead of "changelog entries can only be created on the opencollective account"?

@znarf We may want to enable posting changelog entries from https://opencollective.com/engineering/updates (and similar) in the future, so that makes things a bit more flexible.

@Betree : Correct me if I am wrong @Betree , but my thinking is that on the API side we didn't have a check; so when creating a changelog update we only used to check on the front-end side whether the collective is indeed opencollective. So adding root user on the api makes sense for now, until we add this support for adding changelog updates for other collectives such as engineering. So I'll keep this as is for now? thinking

I think so. For me, the main goal of this was purely to have a security fix, we don't want anyone to be able to publish to our changelog. After that, I'm not strongly for one approach or the other.

I think so. For me, the main goal of this was purely to have a security fix, we don't want anyone to be able to publish to our changelog.

@Betree : Exactly my thoughts;
So @znarf if you don't have any objections I'll be merging this one.


feat: change npm package name for risc-plugin

Endrer fra pakke @bekk-spire til @kartverket for risc-plugin🪴

Nice! Changes look good, but something is off as it does not currently compile. That should be solved before merge

The npm-package was built with the wrong node-version, they have fixed this now - and some other stuff 🤠 But now it seems to work


Enhancement: Possible Splash Arrows when pressing sick the same on week 7

###If possible "put the splash arrows" when you press splash from week7 'I don't know the correct name'
the files of the splash ta here I have no idea if you can put it.
the download ta on mediafire was where I managed to put:
https://www.mediafire.com/folder/lrw8ozp9j0uwp/NoteSplash

maybe
epic week 7 asset stealing, week 7 assets aren't gonna be used until week 7 releases

maybe
epic week 7 asset stealing, week 7 assets aren't gonna be used until week 7 releases

Actually, MtH told me we CAN use non-week 7 related assets introduced in the update!

Options > Appearance > Note Splashing
cool option idea

maybe
epic week 7 asset stealing, week 7 assets aren't gonna be used until week 7 releases

Actually, MtH told me we CAN use non-week 7 related assets introduced in the week 7 update!

seems like a good idea to add them then

i am no authority but like the shit's out there already soooo


FileNotFoundError: [Errno 2] No such file or directory: 'idenprof/train' while it is in the right directionary

File structure:
AI
I- KilluaAI.py
I- idenprof
I- train
I- Killua
I- test
I- Killua
Running KilluaAI.py I get the error FileNotFoundError: [Errno 2] No such file or directory: 'idenprof/train' while it clearly is in the right directionary, I am not sure what I did wrong

Okay sorry my file structure got messed up with the formatting, here's an image

Okay sorry my file structure got messed up with the formatting, here's an image

Fixed by moving files

Fixed by moving files


Driving/Flying transition animation

Please fix the car transformation later down the road when you can. As you know, currently the wheels just pop back in. I have multiple ideas regarding this, some easier some more difficult. But please do something about it.

I tweaked these a little in v0.0.10 - need to do the intro animation of the wheels yet still.

Will you consider to bring back the wheels and tires of the motorcycles too when in flight? How about turning them horizontal so that the forks disappear in them, and the blue flame coming out of them?
Thank you very much for this awesome mod.

I haven't worked on/used the motorcycles in flight very much yet, but from the tests I did earlier, it seemed like each is going to need a custom configuration of thrusters & animations that make sense for them.

Very curious what you'll bring. Especially like the rims of the Yaiba that I've been flying a lot with, lately. Hope you'll leave them on during flight. Here's a pic.

I'm new to GitHub, but how can I best relay 3 suggestions to you? 1 suggestion in 3 separate threads, or all 3 in 1 thread? Or can I post them all 3 in this thread?

I'm new to GitHub, but how can I best relay 3 suggestions to you? 1 suggestion in 3 separate threads, or all 3 in 1 thread? Or can I post them all 3 in this thread?

If you could make a new issue for each topic (or find a related one to post in), that'd be great :)


Setup mlflow before KedroContext

Hello,
I have a custom KedroContext (where I initialise a Spark session) and I would like to log things into mlflow at this moment.
But if I log things there, it doesn't take into consideration my mlflow.yml parameters.
I tried to call in my KedroContext:
        mlflow_config = get_mlflow_config()
        mlflow_config.setup()

But I got the following error:
RuntimeError: There is no active Kedro session

If you have any idea for a workaround, feel free to share it!

Hi @stephanecollot,
sorry for the response delay. Actually this is a tricky question and I don't have a clear solution, but I might guide you to find a workaround which may suits your use case.
A bit of history
In earlier kedro versions (e.g. 0.15.X), the KedroContext was the only place where you could add custom code to interact with kedro during the execution (e.g. when you launch kedro run). This was not convenient because :

it created cluttered and hard to maintain custom ProjectContext
different logic where hard to compose: if I created a MlflowContext and you a SparkContext, one should inherit from the other to enable to compose the 2 logic. If we have more than 2 custom logic, it became completly intractable in practice.

With kedro=0.16.X, kedro introduced hooks. This adds the possibility to compose and distribute easily different custom code ; in return we lost the ability to inject code anywhere during the run but rather at some predefined places (especially before / after pipeline and node execution).
In general, it is no longer recommended to add custom logic inside the context BUT their documentation still suggest that it is the recommended way to initialise a spark context. I think it is no longer the case, but the reason while they are doing this instead of a hook is because they need to access a spark.yml config file, which is hard to retrieve inside hooks, even if there are solutions for this from kedro>=0.17.X.
On execution order
When launching kedro run, the KedroSession is instantiated first, and during its instantation the ProjectContext is instantiated. This explains why you will never be able to retrieve configuration (and "setup" mlflow here) because the Session simply does not exist at this moment, and obviously is not activated yet.
Potential solutions
Solution 1: Keep your custom context and log in mlflow in a hook
Create a custom hook:
class MyMlflowHook:
    """Namespace for grouping all model-tracking hooks with MLflow together."""

    @hook_impl
    def before_pipeline_run(self, run_params: Dict[str, Any]) -> None:
        """Hook implementation to start an MLflow run
        with the same run_id as the Kedro pipeline run.
        """
        mlflow.log_xxx("<whatever>")

You can register it in settings.py
This will be triggered after the ProjectContext initialisation, but it may feels a uncomfortable to navigate between the context and the hook to log what you need.
Solution 2: Move everything inside a hook
class SparkMlflowHook:
    """Namespace for grouping all model-tracking hooks with MLflow together."""

    @hook_impl
    def before_pipeline_run(self, run_params: Dict[str, Any]) -> None:
        """Hook implementation to start an MLflow run
        with the same run_id as the Kedro pipeline run.
        """
       # FIRST, get the session
        session = get_current_session()
        context= session.load_context()
        config_loader= context.config_loader()

       # SECOND, initialize the spark session
        # Load the spark configuration in spark.yaml using the config loader
        parameters = config_loader.get("spark*", "spark*/**")
        spark_conf = SparkConf().setAll(parameters.items())

        # Initialise the spark session
        spark_session_conf = (
            SparkSession.builder.appName(self.package_name)
            .enableHiveSupport()
            .config(conf=spark_conf)
        )
        _spark_session = spark_session_conf.getOrCreate()
        _spark_session.sparkContext.setLogLevel("WARN")

       # THIRD, log in mlflow (no need to use "start_run" since kedro-mlflow hook has already be executed just before
        mlflow.log_xxx("xxx")

This implies recreating the context, but can you tell me it it suits your need?

Thanks for this very detailed and interesting answer.
To be more specific I would like to log in MLflow the spark configuration and spark application id.
I'm going to try your solution 2.
I'm using kedro==0.17.4

Hi @stephanecollot did you manage to make it work? As stated above, this is not really a bug and I can't do anything so I'll close this issue, but I can help you to achieve what you want.

Hi,
Thank you a lot, it works like a charm!
Cheers


Fixing leak of prepared statements in prepareCall(String sql)

The current implementation of prepareCall(String sql) leaks prepared statements, as we make two calls to connection.prepareCall(sql)
https://github.com/opentracing-contrib/java-jdbc/blob/ecd42903149c88fb8e735376718e1e8a60cd5a4a/src/main/java/io/opentracing/contrib/jdbc/TracingConnection.java#L125-L131
This PR contains a simple one-line fix for this.

We just built the latest jar and validated manually, this definitely fixes the leaking prepared statements we encountered.

FYI @malafeev

Thanks for the quick merge @malafeev, can you also release a new version tag?

@malafeev It would be great to get this released as soon as feasible!

Any update on when this can be released @malafeev  ?? It would be great if this can be released soon , please

I'm not involved in java-jdbc anymore.
@carlosalberto @tedsuo  please provide status of the repository, who takes ownership?


App crashes on minimumDate

Setting minimum date crash app
<DateTimePicker
    isVisible={this.state.isDateTimePickerVisibleTo}
    onConfirm={this._handleDatePickedTo}
    onCancel={this._hideDateTimePickerTo}
    minimumDate={this.state.dateFrom}
    maximumDate={new Date()}
     />

this.state.dateFrom cames from another date picker
and the code was working before when I commented minimumDate every thing works fine

Hi!
What version of RN are you using? Does the bug happens on both iOS and Android?
It sounds more like a bug of react-native's own pickers, could you try to use them and see if they work correctly?
Thanks!

Hi,
I use react native 0.43.3
it crashes on both android and ios
when i setted datePickerModeAndroid as spinner works fine on android
also the datePicker android works fine with both calendar and spinner with minDate
I didn't try it yet on ios after i setted datePickerModeAndroid

same here on 0.43.4

Does the following example work for you?
Here I'm setting minimumDate with the last picked date from the picker and it is working fine for me (iOS).  🤔
import React, { Component } from 'react';
import { Text, TouchableOpacity, View } from 'react-native';
import DateTimePicker from 'react-native-modal-datetime-picker';
import styles from './app.style';

export default class DateTimePickerTester extends Component {
  state = {
    isDateTimePickerVisible: false,
    minimumDate: new Date(),
  };

  _showDateTimePicker = () => this.setState({ isDateTimePickerVisible: true });

  _hideDateTimePicker = () => this.setState({ isDateTimePickerVisible: false });

  _handleDatePicked = date => {
    console.log('A date has been picked: ', date);
    // Setting the minimumDate as the last picked date
    this.setState({ minimumDate: date });
    this._hideDateTimePicker();
  };

  render() {
    return (
      <View style={styles.container}>
        <TouchableOpacity onPress={this._showDateTimePicker}>
          <View style={styles.button}>
            <Text>Show DatePicker</Text>
          </View>
        </TouchableOpacity>
        <DateTimePicker
          isVisible={this.state.isDateTimePickerVisible}
          onConfirm={this._handleDatePicked}
          onCancel={this._hideDateTimePicker}
          minimumDate={this.state.minimumDate}
        />
      </View>
    );
  }
}

Try with setting maximumDate with minimumDate

my code works on ios and android  after i setted datePickerModeAndroid as spinner

Try with setting maximumDate with minimumDate

I did, it's working fine.

my code works on ios and android after i setted datePickerModeAndroid as spinner

That's weird, because datePickerModeAndroid is not even checked by iOS, maybe it was a caching issue?

My code still gives error when I remove datePickerModeAndroid on android and ios
but I can't reproduce and I tried Your code is working fine
I tried it with resetting minimumDate dynamically and also work fine
so thank You a lot if You want You can close this issue

Feel free to re-open if you'll be able to reproduce it!

Hello, @arabscimitar Actually I am  using this module .
My  ```
"react": "16.0.0-alpha.12",
"react-native": "0.46.1",
But, **you are saying that to change react-native version 0.43.3**. But I am using another module **urban airship But it's accepts  react-native-version>= 0.44.0,**
what can I do But i want to show an ,
datePickerModeAndroid={'spinner'}

i could not reproduce i am not sure why it is happens

But I want Spinner Mode in android but it shows default mode

Need to reopen this issue as its still persist
Having the same issue only on Android with mode "date"
if you  try to add the minimumDate props with mode "date" on android App is crashed
working fine on Ios and also working fine with other mode like datetime,time
this will only happen if we passed minimumDate prop on date mode (Android)
"react-native-modal-datetime-picker": "^9.0.0",
"react-native": "0.63.3",


Cannot link operation not supported when using replication

I've been following the steps in this file: https://github.com/Altinity/clickhouse-operator/blob/master/docs/replication_setup.md. The only change I made is to pull the latest image for clickhouse-server instead of <IP_ADDRESS>.
I have zookeeper and clickhouse-operator set up as per the guides. I'm running this on AKS, I have PVCs setup for my zookeeper instances and for my clickhouseinstallations.
When I run the INSERT I get this error:
Code: 424. DB::Exception: Received from clickhouse-blah:9000. DB::Exception: Cannot link /var/lib/clickhouse/data/default/events/shard1_all_replicas/tmp/2.bin to /var/lib/clickhouse/data/default/events/shard1_all_replicas/2.bin, errno: 95, stderror: Operation not supported.

Hi @a-dot , this error is from file system. It complains that hard links are not supported. ClickHouse users hard links very extensively, so it can not work without them.
Could you elaborate with a couple of things:

Does it work if you setup a single node ClickHouse?  (no ZK and replication at all)
What is your storage class and file system?

Hello! I just managed to get this fixed by using the managed-premium instead of default storage class in AKS. shrug
Thanks for the help!

Excellent!


Source maps inclusion yields warnings

Hi,
Thank you very much for this great plugin which works fine :)
This is a low priority issue, but in some apps using webpack, it yields a warning because of the source maps:
WARNING in ./node_modules/capacitor-rate-app/dist/esm/web.js
Module Warning (from ./node_modules/source-map-loader/dist/cjs.js):
Failed to parse source map from '/path/to/app/node_modules/capacitor-rate-app/src/web.ts' file: Error: ENOENT: no such file or directory, open '/path/to/app/node_modules/capacitor-rate-app/src/web.ts'
...

This is because the .js.map point to source files from src folder which is not bundled.
For example, dist/esm/web.js.map references ../../src/web.ts which does not exist because folder src is not bundled.
The warnings go away if removing the sourceMappingURL comments (+ updating the package version to avoid any particular caching).
Maybe the source mapping should be disabled for bundled releases ?

Should be fixed in v6


pylyzer: init at 0.0.23

Description of changes
A fast static code analyzer & language server for Python
https://github.com/mtshiba/pylyzer

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 229114 run on x86_64-linux 1

1 package built:

pylyzer


Styling the page - Container

Please add a container to display all of the sections on the page.

We will be updating the UI of our application to match this Figma design on page "Prototype web".
To accomplish this, we need to wrap our Home page component in a div with the following styles:

Flexbox: true
Max width: 1440px

This will allow the components inside to fit the shape we expect in our designs.
This design is desktop-first, so we will review mobile designs later in the week.

Oswald font: https://fonts.google.com/specimen/Oswald
Roboto font: https://fonts.google.com/specimen/Roboto


Fixing Primary to work with jitfcl

Hi @oksuzian,
You have proposed changes to files in these packages:

Scripts
CampaignConfig

which require these tests: build.
@Mu2e/fnalbuild-users, @Mu2e/write have access to CI actions on main.
:hourglass: The following tests have been triggered for cbe293e33bf8b6a91d5f608abe0426607cac161a: build  (Build queue is empty)
About FNALbuild. Code review on Mu2e/Offline.

:sunny: The build tests passed at cbe293e33bf8b6a91d5f608abe0426607cac161a.

Test
Result
Details

test with
:white_check_mark:
Command did not list any other PRs to include

merge
:white_check_mark:
Merged cbe293e33bf8b6a91d5f608abe0426607cac161a at f1c07b4d8c04b74f88b5a978e62fa729b4977680

build (prof)
:white_check_mark:
Log file. Build time: 08 min 27 sec

ceSimReco
:white_check_mark:
Log file.

g4test_03MT
:white_check_mark:
Log file.

transportOnly
:white_check_mark:
Log file.

POT
:white_check_mark:
Log file.

g4study
:white_check_mark:
Log file.

cosmicSimReco
:white_check_mark:
Log file.

cosmicOffSpill
:white_check_mark:
Log file.

ceSteps
:white_check_mark:
Log file.

ceDigi
:white_check_mark:
Log file.

muDauSteps
:white_check_mark:
Log file.

ceMix
:white_check_mark:
Log file.

rootOverlaps
:white_check_mark:
Log file.

g4surfaceCheck
:white_check_mark:
Log file.

FIXME, TODO
:white_check_mark:
TODO (0) FIXME (0) in 0 files

clang-tidy
:white_check_mark:
0 errors 0 warnings

N.B. These results were obtained from a build of this Pull Request at cbe293e33bf8b6a91d5f608abe0426607cac161a after being merged into the base branch at f1c07b4d8c04b74f88b5a978e62fa729b4977680.
For more information, please check the job page here.
Build artifacts are deleted after 5 days. If this is not desired, select Keep this build forever on the job page.

@brownd1978 can we merge this? I want to get the MDS1 samples made this week


id may be string too

First, thank you for creating this lib it has been pretty useful, one thing it can help me a lot is that I use string ids in my objects, I think adding number | string won't harm and can add more extensibility.

thanks for the contribution!


feat: Move cross filters to Dashboard

SUMMARY
This PR does the following:

Removes the ability to emit cross filters from Explore
Moves the emission of cross filters at the Dashboard level
Removes the cross filter target name introduced in https://github.com/apache/superset/issues/13966
Moves the filter bar location settings in a submenu

AFTER
https://user-images.githubusercontent.com/60598000/213498463-4b990134-247b-4033-9061-cbd617e7be13.mp4
TESTING INSTRUCTIONS

Go to a Dashboard
Open the filter bar on the left
Click on the settings icon
Make sure the checkbox to enable/disable cross filters is appearing
Verify that cross filters are enabled by default (requires Feature Flag DASHBOARD_CROSS_FILTERS)
Disable cross filtering and make sure the change takes effect
Verify that the filter bar orientation settings are appearing in a submenu and working as intended

ADDITIONAL INFORMATION

[ ] Has associated issue:
[x] Required feature flags: DASHBOARD_CROSS_FILTERS
[ ] Changes UI
[ ] Includes DB Migration (follow approval process in SIP-59)

[ ] Migration is atomic, supports rollback & is backwards-compatible
[ ] Confirm DB migration upgrade and downgrade tested
[ ] Runtime estimates and downtime expectations provided

[ ] Introduces new feature or API
[ ] Removes existing feature or API

This is a great improvement, happy to see the control moving from Explore to Dashboard!

/testev up FEATURE_DASHBOARD_CROSS_FILTERS=true

/testenv up FEATURE_DASHBOARD_CROSS_FILTERS=true

Probably not related to this PR but clicking on a search icon if filter indicator (which is supposed to highlight the cross filter source chart) grays out everything, including the source chart, and you can't do anything except for reloading the page
https://user-images.githubusercontent.com/15073128/214035830-e49dca5b-8ca5-4ab3-bcd3-7a569f6707bb.mov

Another bug, not sure if related to this PR:

Create a new dashboard
Add some charts
Save
Try to apply cross filter
There are no filter indicators in target charts and the source chart also filters itself (it shouldn't) - see screenshot
Refresh the page - you're back in the edit mode (probably shouldn't?). If you click discard and try to apply cross filter, now it works as expected

Thanks @kgabryje both bugs exist in master. I will create separate tickets for those.

/testenv up FEATURE_DASHBOARD_CROSS_FILTERS=true

There might be a few small styling issues around the checkbox:

I think it's too big - 18x18px vs 16x16 from the designs
It's not centered (see screenshot)
I think the spacing between checkbox and text is too small

/testenv up FEATURE_DASHBOARD_CROSS_FILTERS=true

The spacing's missing now :(

The spacing's missing now :(

@kgabryje are you able to reproduce that consistently? I am not able to reproduce it locally

The spacing's missing now :(

Nice catch. This happening when the FF HORIZONTAL_FILTER_BAR is off which was always on in my environment. It should be fixed now.

Thanks @kgabryje both bugs exist in master. I will create separate tickets for those.

Hi @kgabryje, can you link these tickets here?

Thanks @kgabryje both bugs exist in master. I will create separate tickets for those.

Hi @kgabryje, can you link these tickets here?

@kgabryje ^


Expand docs sidenav by default

This would make our categorizations a lot more intuitive.

This should probably wait until we kickoff our broader docs refresh with design.

hey, following up on this as part of the redesign.
Does this refer to the navigation sidenav? would like to explore alternative navigation patterns instead of expanding by default.
One question I have around the sidenav is whether we think there is value in removing the automatic collapse that happens as I navigate through different sections. That way a user could expand all sections and Ctrl+F. Thoughts?
cc @lnhsingh

Yes, this is about the sidenav. Excited to get your input here. I don't want this issue to dictate our solution, especially if we change our navigation in more substantial ways.

sounds good. thinking it would be helpful if we could change this issue into a descriptor of what the challenges you experience with the current navigation is. otherwise perhaps we should just close out?

Let's just close. I think the motive here is to give users a more intuitive sense of what's available. Our categories are collapsed by default, in contrast to a lot of other docs. So there are clicks involved in discovering content or verifying instincts. I know some users prefer the docs landing page, for example, since it lists a lot more topics.


Page creation should only fail after all elements have been checked instead of failing after the first failed check

Is your feature request related to a problem? Please describe.
I'm always frustrated when elements on a page get changed and a page creation only fails on the first change instead of pointing out all changes.
Describe the solution you'd like
Page creation should check all elements that are annotated with @Check and if it fails give a list of all elements where the check failed.
Describe alternatives you've considered
If this can't or shouldn't be done implicitly for some reason then make it available via an extra parameter on the existing @Check annotation or a new annotation (maybe for the page class).

Duplicate of https://github.com/telekom/testerra/issues/207


How to allow HTML in ORG chart

Below are the two fiddle samples one from google chart and other on react google chart:
https://jsfiddle.net/mq2216d3/1/
https://jsfiddle.net/f8zpr8uc/48/
Here there are two issues
1.The root node is not display the text in F field as compared to non react  Google Chart
2. The html's are not getting encoded.
Thansk,
Venu

You need to set the allowHtml option:
                 options={{allowHtml: true}}

Example : https://codesandbox.io/s/q3pxx760n9