chore: release  mp-spdz 0.1.4

:package: Staging a new release
0.1.4 (2023-03-15)
Bug Fixes

mp-spdz: trigger workflow (5ab6139)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/carbynestack/klyshko/releases/tag/mp-spdz-v0.1.4 :sunflower:


Feature request: symbol meanings on hover

For some instruments where there is a choice of > 2 sounds (rep, timba), it might help to have the meaning of the symbol appear on hovering, or something similar. (A full legend to explain all symbols would be irritating to more experienced users, and besides there is probably not the space for it)

Interesting! There's a lot to think about here.
First off, can I ask what made you think of this? I am trying to understand who this an issue for, and what problems it causes. I can see that maybe a new player will be intrigued by the various things you can do with, eg, a repinique, but be frustrated not to be given any words. It makes it hard to look things up or talk about them.
I'm always extremely hesitant to add anything to the UI. I want the user interface to be simple, playful, and inviting. A tooltip is nice because it doesn't add clutter, but I generally find tooltips annoying. It's visual noise, distraction. I also think that the text-free presentation of Banana Drum is part of its charm and purpose.
I do think there may be a place for explaining the different sounds, but I don't think I know the answer yet.
Ableton Live (to me, a rare example of amazing software) has a nice solution for this. They have a panel in a bottom corner that you can open up if you want, and it will show an explanation of whatever you mouse over. This is overkill for Banana Drum, Ableton Live does millions of things.
I'm thinking maybe we solve this incidentally in a future change. For example, I will probably overhaul the "add instrument" UI at some point, and more instrument info could go there. Or, I'm thinking of a quick-compose feature where you can type out a rhythm. This will involve some graphical stuff that could contain the names of the sounds.

I am new to samba, and the various different sounds for the rep and timba
are a bit of  mystery.  I understand the appeal of a symbol.
My particular use case is "new player trying to transcribe a whole section
from a chart to practice", which is perhaps a bit niche, but I am not sure
if there are well-understood conventions for symbols for the different
sounds on timba and hep.
Big X and little x, and open and closed circle for other instruments are
easy to get, likewise /// for a buzz.
I figured the symbols out which I didn't understand by looking in the
source on github, so I suppose I have solved my own problem, but I still
think there might be room for some  symbols to be misunderstood. Some
people for example may be more familiar with letters. Maybe worth asking
the band the question about how things are represented on a chart ?
On Sat, 25 May 2024 at 19:24, James @.***> wrote:

Interesting! There's a lot to think about here.
First off, can I ask what made you think of this? I am trying to
understand who this an issue for, and what problems it causes. I can see
that maybe a new player will be intrigued by the various things you can do
with, eg, a repinique, but be frustrated not to be given any words. It
makes it hard to look things up or talk about them.
I'm always extremely hesitant to add anything to the UI. I want the user
interface to be simple, playful, and inviting. A tooltip is nice because it
doesn't add clutter, but I generally find tooltips annoying. It's visual
noise, distraction. I also think that the text-free presentation of Banana
Drum is part of its charm and purpose.
I do think there may be a place for explaining the different sounds, but I
don't think I know the answer yet.
Ableton Live (to me, a rare example of amazing software) has a nice
solution for this. They have a panel in a bottom corner that you can open
up if you want, and it will show an explanation of whatever you mouse over.
This is overkill for Banana Drum, Ableton Live does millions of things.
I'm thinking maybe we solve this incidentally in a future change. For
example, I will probably overhaul the "add instrument" UI at some point,
and more instrument info could go there. Or, I'm thinking of a
quick-compose feature where you can type out a rhythm. This will involve
some graphical stuff that could contain the names of the sounds.
—
Reply to this email directly, view it on GitHub
https://github.com/mooseling/BananaDrum/issues/8#issuecomment-2131384581,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/BBOSDZRCATK2OD3TNEQKNJDZEDJPBAVCNFSM6AAAAABIIGGEKWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMZRGM4DINJYGE
.
You are receiving this because you authored the thread.Message ID:
@.***>

Aha, I see! That's a very valid use case. Interesting. I think you're right that this should be solved.
At Arco Iris, the charts tend to use letters representing English words or sounds. I think I've seen "O" for open-tone (on timbau, but also rep with the left hand), "S" for slap (ditto), "Zz" for buzz. I decided not to take this direction with banana drum because not everyone speaks English! As far as I know, banana drum is being used in at least the UK, Germany, and Brazil :D
I've added the issue to Trello and will give it a think. I will close this feature request for now. Thanks!

you could maybe alter the symbols to include common letter abbreviations, but as you say, that would be anglo-centric....


TiC items not castable when no input items are defined

When there is no valid input item defined in the whitelist section, the TiC parts and items are created (shown in JEI and cheatable) but they are all missing a casting recipe.
I know it may not have been your intention using InfiniTic without specifying a valid input item, but as ModTweaker recently readded TiC support it would be a great help if that would work so i can define my own alloys and use InfiniTic just to create the liquid + TiC items without any ore/ingot/block being added.
"whitelist": { 		"__comment": "Everything in the whitelist will be added to the OreDictionary with the above name.", 		"oredict": [], 		"ingots": [], 		"nuggets": [], 		"dusts": [], 		"gems": [], 		"blocks": [], 		"ores": [] 	},

I can look into this but one of the required calls to the Tinkers API requires a physical material.  Have you considered how your players would repair their tools in the tool station if no solid item is associated as per your request?

Good point with the repair. In the meantime i anyway found a way to bypass the metadata problem in #21 which also solved this issue for me:

Using Romimocos ore mod i added dummy ingots (with similar itemname so it works, see #21 bug 2nd comment) that i specified in whitelist input (ore nit generated)
With Modtweaker i then removed the TiC smelting from those dummy ingots and added smelting from the real ingots (e.g. Botanias Elementium, Gaia Spirit) and blocks.

So as i needed anyway to add custom ingots i then just added ingots and blocks for my own alloys too.
So if you say this isn't doable anyway because of TiC restrictions i think this issue can be closed.

Could you not use shards cast shards out of that material and use those to repair your tools?
You'd have to add a way to smelt thise though.

You could repair stuff with shards, if you add a way to cast those.

@Mike-U5  i added ingots then with another mod so the tools should be repairable now ;)

If you add ingots with another mod then you should be able to add that ingot to the ingot whitelist.  Then Infini-TiC has a solid and it should all work nicely.
The shard idea is how Tinker's deals with repairing materials without ingots.  Shards should always be cast-able or craft-able for any material.


backwards merge

:tada: This PR is included in version 9.7.5 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:

:tada: This PR is included in version 9.7.6 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Enable camera.replay() function

As asked today on the Discord chat #monocle

I need to get my FPGA up again...


need more Multimodal Large Model support

Are you thinking another mode? Similar to #86, this can be added if someone wants to make a PR

Assuming this is the same as #86 I'll close it for now


Result . . . . 2 out of 8 correct . . .

I do not quite understand is that we are not getting enough correct answers to call it much of an accomplishment . . .  Take this last line in the code:
output = neural_network.think(np.array([1, 0, 0]))
This is the resulting output for each corresponding input :
Input         Output
0 [0, 0, 0] --> [ 0.5]
1 [1, 0, 0] --> [ 0.99993704]
2 [0, 1, 0] --> [ 0.44822538]
3 [1, 1, 0] --> [ 0.9999225]
4 [0, 0, 1] --> [ 0.009664]
5 [1, 0, 1] --> [ 0.99358931]
6 [0, 1, 1] --> [ 0.00786466]
7 [1, 1, 1] --> [ 0.99211997]
This is for the XOR function:
INPUT OUTPUT
A B      A XOR B
0 0             0
0 1             1
1 0             1
1 1             0
So we need to consider . . . . are we XORing all three values or just the first two values. . . . but nevertheless, when we plug in 1, 0, 0 we get the outcome 0.99993704, . . (1), and that is correct, however, look at all the other values! 0, 2, 3, 4, 5, 6 would be wrong, using the first two or all three, and I am not sure why we would bother with the rest if only the first two digits matter.   This is pretty serious,
given that only 1 and 7 give a correct answer . . .

I know this is an old issue, but I do want to comment on it...
I do not see why these answers are incorrect. As described somewhere on this page, the outcome should be equal to the first value, which is at all inputs kind of correct (except for zero).


Vegetarian food filter issues

It doesn't filter the following food:

[ ] gyros
[ ] chicken
[ ] grillhaxe
[ ] soljanka

Comment below if you find any non-vegetarian food when "Vegetarian only" is on.

We could also just replace the vegetarian filter with a machine-learned approach.


fix(job-run): fix leaking jobs with wrong param order

Changes

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

#815  👈
#813
#812
#811
#810
#807
#806
#804
#803
#802
#801
#805
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @NathanFlurry and the rest of your teammates on  Graphite


Response time limits [LIMITS]

Context
There is no restrictions about the kind of queries that a user can run against his database, complex SQL can cause outages in the platform with potential consequences for other users. In order to ensure stability and to avoid overuse of resources we need set a fine grained maximum SQL query time.
Things to do

[x] Catch timeout error from database and respond with custom message:

{
  errors: ['timeout: you are over the limits, please contact ...]
}

[x] ~In case of we need to tune the user's database timeout (after kickoff we talked about having a different timeout because in SQL-API users want to run expensive queries), we need to fetch user's metadata from Redis get its configuration and apply his timeout before executing the query.~

cc @rochoa @jorgesancha @saleiva

Deployed in production: https://github.com/CartoDB/CartoDB-SQL-API/releases/tag/1.47.0


Bumped up Flask and Jinja2 version to fix issue with markupsafe update

Description

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Documentation (non-breaking change with enhancements to documentation)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist

[ ] I have checked that unit tests pass locally with my changes
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] I have added necessary documentation (if appropriate)

Further comments

Fixes #335


Follow-up fix to #43

Resolves the problem that @axic found in #43

Fxed in #63 too

With #63 merged, this PR is now redundant.


Provide html2text

I'm currently migrating the many microservices I have floating around on my server into individual docker containers and found your Dockerfile for urlwatch. What I'm missing in your container is (py)html2text which I'm suing in many of my (over 30) watch filters. I found it gives superior results to using the standard html2text plugin.
Example:
name: "Gemeinde Grafschaft: Aktuelles"
url: "https://www.gemeinde-grafschaft.de/aktuelles/2022/"
filter:
  - css: div.xhtmlcomponent:nth-child(1)
  - html2text: pyhtml2text
  - strip

Thank you very much!


Bottomsheet background breaks if used with alpha

Is there an existing issue for this?

[X] I have searched the existing issues
[X] I have read the guide to filing a bug

Steps to reproduce
On latest flutter version if you Create a modalBottomSheet with a background color using alpha
    showModalBottomSheet(
        backgroundColor: Theme.of(context).colorScheme.error.withAlpha(200),
        context: context,
        isScrollControlled: true,
        builder: (BuildContext context) {
          return Container(
            child: Center(child: Text("hello")),
          ) ;
        });

The bottom sheet it will "break" and weird behaviour with the on back screen will happen.

you might appreciate the arrow at the bottom that is an animated widget from the screen is behind the modal and it should not appearing like this moving.
Not only that seems the way it is managing the alpha has changed from previous version as it might appreciated below with the colours,
NOTE: All test has been performed in iOS17 the ones that are the expected and the ones failing.
Devices tested:
Simulator iPhone 15 Pro Max
Simulator iPhone SE
Real device iPhone XR
Real device Xiaomi RedMi
Expected results
if you remove the alpha everything works as expected

In the real application without examples you might well notice the difference between them
Here is the real application with the stable version of flutter of July:

Here the real application with the latest flutter version:

Actual results
The bottom sheet it will "break" and weird behaviour with the on back screen will happen.

Code sample
Code sample
import 'package:flutter/material.dart';
import 'package:font_awesome_flutter/font_awesome_flutter.dart';

//import 'package:flutter_gen/gen_l10n/app_localizations.dart';
class FlutterIssue extends StatelessWidget {
  const FlutterIssue({super.key});

  @override
  Widget build(BuildContext context) {
    return Stack(
      children: [
        Container(
          width: MediaQuery.of(context).size.width,
          height: MediaQuery.of(context).size.height,
          child: Center(
            child: TextButton(
                onPressed: () {
                  showModal(context);
                },
                child: Text("OPEN ME")),
          ),
        ),
        SwipeUp_flutterIssue()
      ],
    );
  }

  showModal(context) {
    showModalBottomSheet(
        backgroundColor: Colors.amber.withAlpha(200),
        context: context,
        isScrollControlled: true,
        builder: (BuildContext context) {
          return Container(
            child: Center(child: Text("hello")),
          ) /*const VideoManager()*/;
        });
  }
}

class SwipeUp_flutterIssue extends StatefulWidget {
  const SwipeUp_flutterIssue(
      {Key? key,
      /*required this.onModifyUserResult*/
      this.color})
      : super(key: key);
  final Color? color;
  @override
  SwipeUp_flutterIssueState createState() => SwipeUp_flutterIssueState();
}

class SwipeUp_flutterIssueState extends State<SwipeUp_flutterIssue>
    with SingleTickerProviderStateMixin {
  /*late AnimationController controller;
  late Animation<Offset> offset;
*/

  late final AnimationController _controller = AnimationController(
    duration: const Duration(seconds: 2),
    vsync: this,
  )..repeat(reverse: true);
  late final Animation<Offset> _offsetAnimation = Tween<Offset>(
    begin: const Offset(0, 0.2),
    end: const Offset(0, 0),
  ).animate(CurvedAnimation(
    parent: _controller,
    curve: Curves.elasticIn,
  ));
  Color color = Colors.white; // Colors.transparent;
  bool _visible = false;
  @override
  void initState() {
    super.initState();
    Future.delayed(const Duration(milliseconds: 2000), () {
      // color = Colors.white;
      _visible = true;
      setState(() {});
    });
  }

  @override
  void dispose() {
    _controller.dispose();
    super.dispose();
  }

  @override
  Widget build(BuildContext context) {
//    controller.forward();
    color = widget.color ?? Colors.white;
    return SizedBox(
        height: 100,
        child: SlideTransition(
            position: _offsetAnimation,
            child: AnimatedOpacity(
              // If the widget is visible, animate to 0.0 (invisible).
              // If the widget is hidden, animate to 1.0 (fully visible).
              opacity: _visible ? 1.0 : 0.0,
              duration: const Duration(milliseconds: 2500),
              child: Icon(
                FontAwesomeIcons.anglesUp,
                color: color,
                size: 25,
              ),
            )));
  }
}

Screenshots or Video

Screenshots / Video demonstration
Adding videos for better clarifications:
Actual result with flutter 3.13.5 and the code sample provided.
https://github.com/flutter/flutter/assets/9969839/497b1846-be25-4ad4-925b-a335dd5bf4de
Actual result with flutter 3.13.5 and real application
https://github.com/flutter/flutter/assets/9969839/5832f91d-c4e5-4212-ae77-9ec3b2920bc9
Expected behaviour with flutter stable version of July, real app in production:
https://github.com/flutter/flutter/assets/9969839/9029ca56-0c4c-4c81-aebc-57f2db3afe45

Logs
Logs
No errors shown on logs it is just UI behaviour

Flutter Doctor output
Doctor output
[✓] Flutter (Channel stable, 3.13.5, on macOS 13.5.2 22G91
    darwin-arm64, locale en-GB)
[✓] Android toolchain - develop for Android devices (Android SDK
    version 33.0.2)
[✓] Xcode - develop for iOS and macOS (Xcode 15.0)
[✓] Chrome - develop for the web
[✓] Android Studio (version 2022.1)
[!] Android Studio (version unknown)
    ✗ Unable to determine Android Studio version.
    ✗ Unable to find bundled Java version.
[✓] VS Code (version 1.82.2)
[✓] VS Code (version 1.79.0-insider)
[✓] Connected device (4 available)
    ! Error: Browsing on the local area network for Pablo’s
      Apple Watch. Ensure the device is unlocked and
      discoverable via Bluetooth. (code -27)
[✓] Network resources

EDIT: I've managed to tested in 3.10.6 and works as usual. I've seen releases notes and recently has been introduced some changes on the bottomsheet that could affect but didn't managed to confirm it: https://github.com/flutter/flutter/pull/128455/commits/37b265290f3858ac8a588079c96c0428209f8d2d

Hi @Pablo-Aldana. Thanks for filing this. I can't seem to reproduce this on my end (Testing on iOS 16.4), does this occur only with iOS 17? Tested on Android as well but can't seem to reproduce it.

Code Sample Used

import 'package:flutter/material.dart';
import 'package:font_awesome_flutter/font_awesome_flutter.dart';

void main() {
  runApp(const MyApp());
}

class MyApp extends StatelessWidget {
  const MyApp({super.key});

  // This widget is the root of your application.
  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      title: 'Flutter Demo',
      home: const MyHomePage(),
    );
  }
}

class MyHomePage extends StatefulWidget {
  const MyHomePage({super.key});

  @override
  State<MyHomePage> createState() => _MyHomePageState();
}

class _MyHomePageState extends State<MyHomePage> {
  @override
  Widget build(BuildContext context) {
    return Scaffold(body: FlutterIssue());
  }
}

//import 'package:flutter_gen/gen_l10n/app_localizations.dart';
class FlutterIssue extends StatelessWidget {
  const FlutterIssue({super.key});

  @override
  Widget build(BuildContext context) {
    return Stack(
      children: [
        Container(
          width: MediaQuery.of(context).size.width,
          height: MediaQuery.of(context).size.height,
          child: Center(
            child: TextButton(
                onPressed: () {
                  showModal(context);
                },
                child: Text("OPEN ME")),
          ),
        ),
        SwipeUp_flutterIssue()
      ],
    );
  }

  showModal(context) {
    showModalBottomSheet(
        backgroundColor: Colors.amber.withAlpha(200),
        context: context,
        isScrollControlled: true,
        builder: (BuildContext context) {
          return Container(
            child: Center(child: Text("hello")),
          ) /*const VideoManager()*/;
        });
  }
}

class SwipeUp_flutterIssue extends StatefulWidget {
  const SwipeUp_flutterIssue(
      {Key? key,
      /*required this.onModifyUserResult*/
      this.color})
      : super(key: key);
  final Color? color;
  @override
  SwipeUp_flutterIssueState createState() => SwipeUp_flutterIssueState();
}

class SwipeUp_flutterIssueState extends State<SwipeUp_flutterIssue>
    with SingleTickerProviderStateMixin {
  /*late AnimationController controller;
  late Animation<Offset> offset;
*/

  late final AnimationController _controller = AnimationController(
    duration: const Duration(seconds: 2),
    vsync: this,
  )..repeat(reverse: true);
  late final Animation<Offset> _offsetAnimation = Tween<Offset>(
    begin: const Offset(0, 0.2),
    end: const Offset(0, 0),
  ).animate(CurvedAnimation(
    parent: _controller,
    curve: Curves.elasticIn,
  ));
  Color color = Colors.white; // Colors.transparent;
  bool _visible = false;
  @override
  void initState() {
    super.initState();
    Future.delayed(const Duration(milliseconds: 2000), () {
      // color = Colors.white;
      _visible = true;
      setState(() {});
    });
  }

  @override
  void dispose() {
    _controller.dispose();
    super.dispose();
  }

  @override
  Widget build(BuildContext context) {
//    controller.forward();
    color = widget.color ?? Colors.white;
    return SizedBox(
        height: 100,
        child: SlideTransition(
            position: _offsetAnimation,
            child: AnimatedOpacity(
              // If the widget is visible, animate to 0.0 (invisible).
              // If the widget is hidden, animate to 1.0 (fully visible).
              opacity: _visible ? 1.0 : 0.0,
              duration: const Duration(milliseconds: 2500),
              child: Icon(
                FontAwesomeIcons.anglesUp,
                color: color,
                size: 25,
              ),
            )));
  }
}

flutter doctor -v

[✓] Flutter (Channel stable, 3.13.6, on macOS 13.0 22A380 darwin-arm64, locale
    en-NG)
    • Flutter version 3.13.6 on channel stable at
      /Users/damilolaalimi/sdks/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision ead455963c (30 hours ago), 2023-09-26 18:28:17 -0700
    • Engine revision a794cf2681
    • Dart version 3.1.3
    • DevTools version 2.25.0

[✓] Android toolchain - develop for Android devices (Android SDK version 34.0.0)
    • Android SDK at /Users/damilolaalimi/Library/Android/sdk
    • Platform android-34, build-tools 34.0.0
    • ANDROID_HOME = /Users/damilolaalimi/Library/Android/sdk
    • Java binary at: /Applications/Android
      Studio.app/Contents/jbr/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build
      17.0.6+0-17.0.6b802.4-9586694)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 14.3.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Build 14E300c
    • CocoaPods version 1.12.1

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2022.2)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build
      17.0.6+0-17.0.6b802.4-9586694)

[✓] VS Code (version 1.82.2)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.50.0

[✓] Connected device (5 available)
    • sdk gphone64 arm64 (mobile) • emulator-5554                        •
      android-arm64  • Android 14 (API 34) (emulator)
    • iPhone 14 Pro (mobile)      • 6548B0D1-7674-4306-9852-198C465F1104 • ios
      • com.apple.CoreSimulator.SimRuntime.iOS-16-4 (simulator)
    • iPhone 14 Pro Max (mobile)  • BB55E997-7F31-462D-B3B1-6B177D9B40C7 • ios
      • com.apple.CoreSimulator.SimRuntime.iOS-16-4 (simulator)
    • macOS (desktop)             • macos                                •
      darwin-arm64   • macOS 13.0 22A380 darwin-arm64
    • Chrome (web)                • chrome                               •
      web-javascript • Google Chrome 117.0.5938.132

[✓] Network resources
    • All expected network resources are available.

• No issues found!

Hi @dam-ease
Thanks in advance for the super quick answer!! 🚀
You are right I have tested it in an android simulator and it does not happen but it does on iOS 17.0 simulator and real device
Digging a bit more I've seen that the issue occurs with elevation > 0 (a parameter I have omitted in the pass) if elevation is 0 it does work as expected.
In order to facilitate the debug I have created a repo with a dummy project https://github.com/Pablo-Aldana/flutter_bottom_sheet_issue
In the meantime I will set elevation:0 on the showModalBottomSheet to achieve the desired behaviour
Thanks a lot again

Hi @Pablo-Aldana. Thanks for explaining further. We tested this on a device with iOS 17 and can see this works as expected. Also, testing with the minimal sample code below:
Code Sample

import 'package:flutter/material.dart';

void main() {
  runApp(const MyApp());
}

class MyApp extends StatelessWidget {
  const MyApp({super.key});

  // This widget is the root of your application.
  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      title: 'Flutter Demo',
      home: const MyHomePage(),
    );
  }
}

class MyHomePage extends StatefulWidget {
  const MyHomePage({super.key});

  @override
  State<MyHomePage> createState() => _MyHomePageState();
}

class _MyHomePageState extends State<MyHomePage> {
  @override
  Widget build(BuildContext context) {
    return Scaffold(body: FlutterIssue());
  }
}

//import 'package:flutter_gen/gen_l10n/app_localizations.dart';
class FlutterIssue extends StatelessWidget {
  const FlutterIssue({super.key});

  @override
  Widget build(BuildContext context) {
    return Stack(
      children: [
        Container(
          width: MediaQuery.of(context).size.width,
          height: MediaQuery.of(context).size.height,
          child: Center(
            child: TextButton(
                onPressed: () {
                  showModal(context);
                },
                child: Text("OPEN ME")),
          ),
        ),
        SwipeUp_flutterIssue()
      ],
    );
  }

  showModal(context) {
    showModalBottomSheet(
        backgroundColor: Colors.amber.withAlpha(200),
        context: context,
        isScrollControlled: true,
        builder: (BuildContext context) {
          return Container(
            child: Center(child: Text("hello")),
          ) /*const VideoManager()*/;
        });
  }
}

class SwipeUp_flutterIssue extends StatefulWidget {
  const SwipeUp_flutterIssue(
      {Key? key,
      /*required this.onModifyUserResult*/
      this.color})
      : super(key: key);
  final Color? color;
  @override
  SwipeUp_flutterIssueState createState() => SwipeUp_flutterIssueState();
}

class SwipeUp_flutterIssueState extends State<SwipeUp_flutterIssue>
    with SingleTickerProviderStateMixin {
  /*late AnimationController controller;
  late Animation<Offset> offset;
*/

  late final AnimationController _controller = AnimationController(
    duration: const Duration(seconds: 2),
    vsync: this,
  )..repeat(reverse: true);
  late final Animation<Offset> _offsetAnimation = Tween<Offset>(
    begin: const Offset(0, 0.2),
    end: const Offset(0, 0),
  ).animate(CurvedAnimation(
    parent: _controller,
    curve: Curves.elasticIn,
  ));
  Color color = Colors.white; // Colors.transparent;
  bool _visible = false;
  @override
  void initState() {
    super.initState();
    Future.delayed(const Duration(milliseconds: 2000), () {
      // color = Colors.white;
      _visible = true;
      setState(() {});
    });
  }

  @override
  void dispose() {
    _controller.dispose();
    super.dispose();
  }

  @override
  Widget build(BuildContext context) {
//    controller.forward();
    color = widget.color ?? Colors.white;
    return SizedBox(
        height: 100,
        child: SlideTransition(
            position: _offsetAnimation,
            child: AnimatedOpacity(
              // If the widget is visible, animate to 0.0 (invisible).
              // If the widget is hidden, animate to 1.0 (fully visible).
              opacity: _visible ? 1.0 : 0.0,
              duration: const Duration(milliseconds: 2500),
              child: Icon(
                Icons.arrow_upward,
                color: color,
                size: 25,
              ),
            )));
  }
}

Please can you share a demo video as well describing where the bug is and if possible the expected behaviour to help understand this issue better?

From Repo
Code above

Hi, if I can share my own experience. It seems to be an issue with impeler, I use a bottomSheet with margin around the modal, and on android you can see the dark transparant background around, but on ios it bleed white color as if it was a blured shadow. I found 2 fix wich are

Hi @Pablo-Aldana. Thanks for your input. Can you please provide a minimal complete reproducible code sample that doesn’t include 3rd party plugins or complex production code that can reproduce this?

Is there an existing issue for this?

[x]  I have searched the existing issues
[x]  I have read the guide to filing a bug

Steps to reproduce
On latest flutter version if you Create a modalBottomSheet with a background color using alpha
    showModalBottomSheet(
        backgroundColor: Theme.of(context).colorScheme.error.withAlpha(200),
        context: context,
        isScrollControlled: true,
        builder: (BuildContext context) {
          return Container(
            child: Center(child: Text("hello")),
          ) ;
        });

The bottom sheet it will "break" and weird behaviour with the on back screen will happen.

you might appreciate the arrow at the bottom that is an animated widget from the screen is behind the modal and it should not appearing like this moving.
Not only that seems the way it is managing the alpha has changed from previous version as it might appreciated below with the colours,
NOTE: All test has been performed in iOS17 the ones that are the expected and the ones failing. Devices tested:
Simulator iPhone 15 Pro Max Simulator iPhone SE
Real device iPhone XR Real device Xiaomi RedMi
Expected results
if you remove the alpha everything works as expected

In the real application without examples you might well notice the difference between them Here is the real application with the stable version of flutter of July:

Here the real application with the latest flutter version:

### Actual results
The bottom sheet it will "break" and weird behaviour with the on back screen will happen.

### Code sample
Code sample
### Screenshots or Video
Screenshots / Video demonstration
### Logs
Logs
### Flutter Doctor output
Doctor output
EDIT: I've managed to tested in 3.10.6 and works as usual. I've seen releases notes and recently has been introduced some changes on the bottomsheet that could affect but didn't managed to confirm it: [37b2652](https://github.com/flutter/flutter/commit/37b265290f3858ac8a588079c96c0428209f8d2d)

It even breaks with Colors.transparent

Hi @tirth-multipl. Thanks for your input. Can you please provide a minimal complete reproducible code sample that doesn’t include 3rd party plugins or complex production code that can reproduce this?


Proposal: Captains' Huddle

I think we should have a "Captains' Huddle": a (bi)weekly meeting for wg captains to exchange updates, surface needs, and discuss complex cross-wg efforts/decisions. This would be (best effort) required attendance for wg representatives to make sure we had full coverage over project workstreams.
Example content:

Status update on the main focus/actions of each working group (packaged and posted for the entire project to gain visibility)

Plan to fill this out async ahead of time so we can focus our updates on blockers / discussion topics

Request from cluster to go-ipfs for a feature to unblock desired functionality
An important cross-wg decision on an "awesome endeavor" or how a feature should work across js and go

Proposed agenda / notes format: https://docs.google.com/document/d/1LcDSGmOLx_GfQSPF-rA4q8gST6H98UZrKJJgO3LQ3Jk/
Why not in the IPFS Project WG Weekly Meeting?
Right now, our ipfs project wg weekly meeting is focused on roadmapping and creating efficient project processes. That focus is important, time sensitive, and already running over our hour-long weekly meeting. I think trying to combine that with a more tactical status update meeting would likely cause us to run out of time for one of the two objectives. I don't think the "captains' huddle" (what I'm calling this) and the "project WG weekly" (planning, tools, vision) have to necessarily be the same thing if there is both more content than a single meeting and not all captains want to be involved in the latter.
However, if everyone is planning to attend both every week - then we might as well have a single longer meeting (1.5 hrs).
Feedback
Captains, I'd love your feedback on this proposal! @olizilla @diasdavid @Stebalien @eingenito @meiqimichelle @hsanjuan @lidel @pgte @mikeal @eefahy @alanshaw
Comments welcome! Please vote with "thumbs up" for 2 separate meetings, "heart" for one single long meeting, and "thumbs down" for not having a "captains' huddle" at all. You may use "celebration confetti" as pure excitement without any form of voting. ;)

@ipfs/working-group-captains

Hello, I am critic of throwing general meetings on the table. I can elaborate but very shortly I'll just say we have many alternative avenues (sync, async, written ones) to achieve these goals and I've been using them without any issues so far. This are my two cents, I know it may not apply to everyone.

I feel ambivalent on this. I agree with Hector that there are async ways of signaling needs, but at the same time the call could produce a neat record of condensed status updates across all WGs for entire community.
Some notes on having a separate Captains' Huddle call:

Updates: if we have ~1h call with ~10 captains that realistically gives us ~5 minutes per WG

Thats good, WG updates will be brief, just highlights + links.

easy to prepare: captains pick the most interesting updates from their weekly syncs
easy to digest: recording or notes could be good alternatives to following meeting calls/notes of all WGs (will recording land on YouTube?)

Rule of thumb: every WG gets max 5 minutes. Additional time needs to be added to agenda beforehand to ensure we don't run out of time if someone wants additional time to discuss something cross-wg

Maximizing value, minimizing pain: if we choose to do it, the huddle should occur less often than sync calls of  individual WGs  to keep meeting count low and updates exciting. This means bi- or even tri-weekly.

Thank you for raising this @momack2 for discussion! My first thought was yes, a coordination call would be helpful because I would like a better way to understand what's going on across WGs and share status and raise blockers. Then, heard @lidel 's point that in an hour, that means we'll only get 5 minutes each. There won't be time for all the things @momack2 suggested as potential topics.
So, out of the things @momack2 suggested such a meeting would be helpful for, how do we do these things now? How might we do them better? Here's where my thoughts are (and I'm looking forward to @hsanjuan 's further elaboration).

Status update on the main focus/actions of each working group (packaged and posted for the entire project to gain visibility)
I'd like to know how people do this now -- if there is no place for a succinct, written update that could be shared broadly, then I think this would be valuable, like @lidel was talking about. (The info could also feed the community newsletter Jenn is working on, so we get a two-for-one out of it.)

Request from cluster to go-ipfs for a feature to unblock desired functionality
Same question -- how do we do this now, and is it adequate? I think whatever we do now, this could be improved. We should have a place all WG Captains or community members can go to review this in case we can help remove these. There may be a way to get this without the meeting -- could we align on a GH tag across repos that we can pull into one Waffle board? And/or! Is that then the most useful thing to do in a Captain Huddle? Review that board, and plan actions together on how to address the blockers, instead of status updates.

An important cross-wg decision on an "awesome endeavor" or how a feature should work across js and go
After @lidel 's calculation, it's clear we don't have time for this, unless this is the entire meeting every week/two weeks/x-cadence. It seems like this would be better done in ad-hoc sync or async discussions. Raising which things we should discuss (much like the blocker suggestion above) -- maybe that would be useful to consolidate somehow. I'm not convinced one way or the other here -- perhaps what we do day-to-day already raises these conversations enough. Things that aren't moving would get raised as blockers, if we can improve that type of tracking.

I'd like to know how people do this now

We open issues where they should be open, and we keep tabs on repositories, issues, discussions, keywords that affect us, and include those that may help in them. We scan IRC logs and remain available. We ping people when we are waiting for something (through different available channels).
Not everyone is on top of everything. I don't think captains are on top of everything either. There are different people on top of different "interest/responsability" areas.
Then every project does releases, changelogs, blogs, updates in IPFS weekly, tweets etc. so that when something happens we kind of hear about it some way or another, along the rest of the community.
I think from the outside it seems like the IPFS world is a big mess with no coordination, but it's not so. [Engineering wise at least], we are generally very well coordinated across projects because we keep tabs on all the different channels and bring discussions to their right forums (decentralized fashion), including libp2p. It may not work all the time for everyone, but I also don't think a general captain's sync meeting brings any added value to the mix (it may make things worse by adding yet one more channel).
As I said, just my two cents :).

I had thought the IPFS Project WG meeting would be that; open to all captains and those interesed in co-ordinating the streams, and chance for anyone who felt their cross-cutting concern wasn't getting enough traction through the usual channels, to discuss that.
I'm keen for more face-time, and I hear you on the point about the project meeting being fully eaten up by roadmapping right now, but my hope is that will settle down. I'd rather not have 2 parallel co-ordination meetings, but that we make good use of the one.
I think we should think about the roadmap as seperate task that needs a lot of calls for us to work through the details, and move it out of the Project WG meeting slot.
Also I take @hsanjuan point that we are following a bunch of streams right now. I'm in favour of a regular check-in being available on the schedule, but I think folks should only feel they should join if it is useful for them.
The recurring friction is finding a balance. Calls with a small number of participants who get to share how they really feel about things seem to be hugely valuable at unblocking things and highlighting issues that only get allude on github issues. Large calls with five minute slots of "what happend last week, what's next" feel like admin to me.
I feel there is a broader issue here of the friction around asking tech-leads to adopt practices that would be natural for a project management role.

Summary

Everyone agrees we don't want to spend a whole meeting giving status updates between captains (feel that async is more effective for that exchange and this feels like admin)
Like the option of a regular check-in being available on the schedule, but folks should only feel they should join if it is useful for them.
"Huddle should occur less often than sync calls of individual WGs to keep meeting count low and updates exciting"
It'd be nice have a place all WG Captains or community members can go to review asks and cross-wg blockers - and make sure we review and unblock them regularly
There are different people on top of different "interest/responsibility" areas - captains aren't on top of everything
We'd rather avoid 2 parallel co-ordination meetings and just make good use of the one.

Proposed Next Steps

Let's avoid doing a synchronous "around the room" status update between captains (this would be time consuming!) - but there is value to collecting and disseminating cross-team updates separately

To that end, let's try an async captains' log that we fill out prior to weekly meetings (starting Nov 13) with any notable accomplishments / blockers / at risk items from our individual wgs
To track and check in on cross-team efforts/blockers - let's create issues on a single repo (like ipfs/pm?) for any large/important cross-wg endeavors (like https://github.com/ipfs/js-ipfs/issues/1670) so that the project wg can check in on progress and help unblock as needed

Let's use our existing working group weekly for this huddle and pull additional discussions about the roadmap process into a separate forum with invested parties (as we've already been doing)
Let's make the huddle optional for busy captains, but do our best to source async updates across all different IPFS wgs to effectively notify the community and help captains follow up async

Plan is to discuss this (and any async comments) in the IPFS Project WG sync tomorrow - notes from that conversation and thoughts about next steps will be documented here!

Thanks again to everyone on this thread for their thoughts! We discussed this in the Project WG Weekly this week (notes) and decided to move forward with a more organic/distributed peer-to-peer model for updates and alignment for the time being and check back in next quarter to see if we need anything more structured.
New Proposal
Project WG members will organically find time in existing weekly team meetings and 1:1s to onboard on needs, status, and struggles for the working group(s) they are liaison to. Liaisons will help highlight areas of overlap or risk by opening issues on this repo, and if needed scheduling a time in the weekly project wg meeting for all relevant parties to attend, discuss, and decide on a path forward. The project wg weekly will also continue to be an open forum for all wg captains bring any thorny cross-wg issues about coordination, priorities, execution, or strategy.


[Magento] basic files that must be ignored

Reasons for making this change:
The actual other files, such as IDEs files, third-party files, and system files must be added in the gitignore global of the system, not in the project scope.

@rafaelstz i like this cleanup! Do you have a link to some documentation or project which indicates this is a "good enough" setup for a default Magento project?

Also, does this replace #1840? Can we just assume people aren't making Magento Classic projects and are using this new layout?

Hey @shiftkey, that's the reason because gitignore_global exist, files and folders of the system, IDEs and other. I don't found article or documentation, the base of my conclusion are the files generated during and after the installation, today has the Magento Core files.
Magento 1 doesn't was discontinued and is totally different, has many people that download and use this version yet.

I'll take this in and see what is left to do about the Magento2 situation.
@rafaelstz thanks!

Great @shiftkey , if you have any question please let me know!


Runtime ignoring

In 0.5, Outcome was made private and callers lost the ability to mark a test as ignored/skipped at runtime.  This is very useful for test runners built on top that support runtime skipping to communicate what happened to the user.

Could you provide an example of using that in 0.4? If you have an actual project doing that, you can just link it here. A minimal example is fine, too.

Having thought it through, my more immediate needs can be worked around

snapboxs wrapper which takes an action environment variable can instead set ignore upfront
If I were to switch trycmd to using libtest-mimic, I could pre-parse everything and track which cases are ignored.

I do know of other places where runtime ignoring is needed by a test case.  For example, cargo's tests have nightly and git dependencies and are skipped otherwise.  That logic all lives in test function and libtest just sees "pass".  If a case like this were moved to libtest-mimic, it would have the same deficiency.

I'm still slightly confused by the "runtime" part of it because the list of Trials is constructed at runtime too. So you can do whatever check you want to perform while constructing the list of tests, right?

Sometimes you can bake conditionals into the framework around a test.  Sometimes you can't and want to allow the test the flexibility when it can be skipped.
For example, in my python days I used pytest to test hardware.  To know which hardware to test, I injected some test fixtures using command line variables.  The tests could then decide if the hardware had the needed capabilities and skip themselves if not.

I would also like to be able to have tests decide at runtime whether to be ignored. In the environment I'm working in, tests are built (along with the rest of the system) on a build server, and then run on various different devices. Some tests require particular hardware support, and so should be skipped on devices which don't have that hardware. I'd like to make this check as part of the test rather than the runner, so the test can decide partway through that it should be ignored, rather than pass or fail. This seems to be a fairly common feature in test frameworks for other languages, such as Java and C++.

Just chiming in to say that I’d also love to be able to return Ignored dynamically from a test function. Maybe tests could return Result<Success, Failure>, where Success is defined as:
enum Success {
    Passed,
    Ignored,
}

We've switched to this library too and this is very much a feature we'd love to have as well, it takes more time calculating upfront if a test will be ignored which slows down creation of the entire runner, vs making every test and letting it figure out if it can run or not.

I think I have a better understanding of this feature request now. I will look into this! (No promises as to when though, sorry!).

Piling on to this request. If there is a branch somewhere, maybe I can look at finishing it?

How does the feature described here differ from what with_ignored_flag provides? (I have not yet used this library but need to switch over soon if it provides a way to skip tests at runtime).

@tgross35 with_ignored_flag allows skipping the test while building the test object. This can sometimes be enough (for instance, if you want to skip the test when running on a particular linux distribution). However, in some cases the decision to skip the test may require running a significant portion of the test itself to make a decision, or may be linked to the test function in a way that's hard to dissociate. In those cases, with_ignored_flag isn't quite enough.

Thanks, that is indeed what I need. Put up a refreshed version of #38 that should fix this https://github.com/LukasKalbertodt/libtest-mimic/pull/52.


Fix broken headings in Markdown files

GitHub changed the way Markdown headings are parsed, so this change fixes it.
See bryant1410/readmesfix for more information.
Tackles bryant1410/readmesfix#1

This list is not maintained as of now and will be updated soon. Thanks anyways for your PR


When 'delete user' is available in Stroom...

Have the User delete button call the API to delete the actual user.

Depends on https://github.com/gchq/stroom/issues/1052


Docblock interpreted as File-level instead of Class-level with readonly class

Describe the bug
A class docblock is interpreted as a file docblock depending on how the class is declared (final, readonly)
phpcs version used : 3.7.2
# Way to reproduce
<?php

namespace MyNameSpace;

use MyOtherClass;

/**
 * blabla
 */
class MyClass
{

is correctly interpreted as class docblock
<?php

namespace MyNameSpace;

use MyOtherClass;

/**
 * blabla
 */
final readonly class MyClass
{

is correctly interpreted as class docblock
<?php

namespace MyNameSpace;

use MyOtherClass;

/**
 * blabla
 */
readonly class MyClass
{

is wrongly interpreted as file docblock

@benjaminciottisonergia Closing as invalid.
Please use an up to date version of PHPCS. The latest version is 3.8.1.
Also please follow the bug report template properly as it is now completely unclear what sniffs are involved in this and what the problem is you are reporting.
I have presumed the problem was with the PEAR.Commenting.ClassComment sniff or the Squiz.Commenting.ClassComment sniff and in both cases, this was already fixed in PHPCS 3.8.0.


[Workspace] Improve pinAll logic

This correctly computes the pinning logic when there are managed
dependencies which are not required in the package graph.

@swift-ci smoke test


feat(metrics): add metrics for delete path

Record metrics for:

Delete requests (req/sec)
Bytes requested to delete (bytes/sec)

This is based on RSM metadata, and not actual deletes. Those would be measured at the storage layer.

It's worth adding the total metrics, too. If you prefer, we can merge this first


Update style.css

🛠 Fixes Issue
Closes #428
👨💻 Changes proposed

change the help button
font style of site heading
background color
search bar modification

✔ Check List (Check all the applicable boxes)

[x] My code follows the code style of this project.
[x] This PR does not contain plagiarized content.
[x] The title of my pull request is a short description of the requested changes.

📄 Note to reviewers
📷 Screenshots
https://user-images.githubusercontent.com/96954912/171128514-de222de0-6123-4335-8936-344174ff11be.mp4

@ridsuteri sir please review the PR. And merge it bcz very less time is there.
Thankyou.

@ridsuteri  sir!!


Can I use triton server tensorrtllm backend to host other tensorrt built models? If not what do you suggest if our models stack is mixed of LLM and non-LLM models

Hello,
so our current models stack consists of a set of models built in TensorRT  and  the whisper ASR model.
I'd like to use triton server to host all these models.   Since whisper can be converted using TensoRT LLM. I tried to host all models with the triton server with tensorrtLLM backends and I see the error.
And I'm seeing this error
E1220 20:46:48.038714 1 model_lifecycle.cc:621] failed to load 'fer_2' version 1: Invalid argument: unable to find 'libtriton_tensorrt.so' or 'tensorrt/model.py' for model 'fer_2', in /opt/tritonserver/backends/tensorrt

I think this suggests that the triton server tensorrtllm backend do not support tensorrt models. Is it the case?
If so, what should I do? Or what do you recommand if we have a large models stack mixed of LLM and non-LLM models.
Thank you.

Hi,
I understand you might want to provide a full response.  But if it's possible, for now I really just need a quick confirmation on if triton server tensorrtllm backend do not support tensorrt models.
Also if it's the case, some general advices so I can know what to plan for next year for my team and infrastructure wise

If you plan to release a general triton server that include tensorrtllm backend, then i will just wait.

Otherwise I can try to convert whisper to tensorrt engine.  I foresee two challenges are 1. kv cache.   2. beam search...  I see you guys have examples to convert T5 model,  so I suppose I can replicate for whisper.

Thank you

@zmy1116
Hi,
The error message consisting of libtriton_tensorrt.so indicates that you are trying to use the TensorRT backend to serve a specific model. And in TensorRT-LLM backend repo we haven't provided the direct TensorRT backend support.
May I understand more of your concrete scenarios? So here you have bunch of models to be served, some of them to be served with TensorRT-LLM, while for others of them you still want to serve with TensorRT backend? Is this the case?
Is it possible for you to use two Triton backends in your production environment, i.e. the TensorRT-LLM backend and the TensorRT backend, such as using two different docker images for different models' deployment purpose?
June

hello,

And in TensorRT-LLM backend repo we haven't provided the direct TensorRT backend support

Do you have a plan to have a triton server that can handle both tensorrt-llm backand and tensorrt backend?   Or there is technical difficulties to have a backend handling both LLM  and no LLM models.

some of them to be served with TensorRT-LLM, while for others of them you still want to serve with TensorRT backend

Yes

the TensorRT-LLM backend and the TensorRT backend, such as using two different docker images for different models' deployment

If I launch 2 triton server backend,  can they point to the same set of GPUs or they have to point to different sets (For instance, LLM points to gpu 0,1 ,   normal triton points to gpu 2,3 )?
Is there specific reason why operations like flash-attention/ kv cache / beam serach  are not ported to the standard TensorRT?
Thanks

It would be great if tensorrtllm_backend can be used in Triton Inference Server, is this in the roadmap? However, using two docker images to run LLM and non-LLM models not seems like a bad solution because Tensorrt-LLM is quite specific to LLM, involve many technique to speed up LLM, so I guess managing GPU memory will be challenging.

We do not recommend sharing GPUs between TRT-LLM model and anything else. LLMs tend to be memory constrained and sharing GPU memory across different models, though technically possible, can cause perf degradation in both.

We have the use case of currently running TensorRT variants of object detection models and would now like to run TensorRT variants of LLM models such as Llama 2 in production.
Our existing Triton server Docker image is running TensorRT, Python and DALI backends, we can't have TensorRT-LLM within the same image?
We understand performance implications of running the different workloads, we'd prefer to have everything Triton in a single image.

We do not recommend sharing GPUs between TRT-LLM model and anything else. LLMs tend to be memory constrained and sharing GPU memory across different models, though technically possible, can cause perf degradation in both.

If I understand well, does this mean that you have no plan in near future to release a triton server that include LLM backends and TRT backends due to the technical difficulties you described?

See https://github.com/triton-inference-server/tensorrtllm_backend/blob/main/docs/whisper.md

Revisiting this issue:
I do see from tensorrt_llm api documentation that almost all the deep learning operators (such as convolution layer, fc, pooling) are handled.    Say we have a detection model based on efficientnet, I think I can rewrite the network using the tensorrt_llm layer. Is there any risk of putting this model with an llm model together in the model_repository and let tritonserver serve them both using tensorrt_llm backend?


Table as markdown output

Would love for the output to be a table like this other coverage comment:

https://github.com/MishaKav/pytest-coverage-comment
Probably a bit more readable?

I wonder if it would make sense to post permalinks such as:
https://github.com/py-cov-action/python-coverage-comment-action/blob/v3/coverage_comment/badge.py#L18-L19

For reference, here's the GitHub Flavored Markdown comment source mentionned in the other ticket:
https://github.com/MishaKav/pytest-coverage-comment/blob/6d191ad55c294ec27fcc37ec2b98c6e68e4fa66e/README.md?plain=1#L83-L87
Coverage ReportFileStmtsMissCoverMissingfunctions/example_completed   example_completed.py641970%33, 39–45, 48–51, 55–58, 65–70, 91–92functions/example_manager   example_manager.py441175%31–33, 49–55, 67–69   example_static.py40295%60–61functions/my_exampels   example.py20200%1–31functions/resources   resources.py26260%1–37TOTAL105573930%

Tests
Skipped
Failures
Errors
Time

109
2 :zzz:
1 :x:
0 :fire:
0.583s :stopwatch:

It seems nice (and maybe we can "borrow" it). Licence is MIT, so we probably need to add their copyright notice (Copyright (c) 2021 Misha Kav in the licence file. Also, maybe an opportunity to have all major authors of this action listed there.
Things we may want to change may include:

adapting it to diff-cover if need be
add permalinks to the line misses like this

Missing

/

6-7

Details
https://github.com/ewjoachim/ignoreme/blob/cef6a36220366932ffc1338528752bf15b8f1e68/README.md?plain=1#L6-L7

For reference, here's the GitHub Flavored Markdown comment source mentionned in the other ticket:
https://github.com/MishaKav/pytest-coverage-comment/blob/6d191ad55c294ec27fcc37ec2b98c6e68e4fa66e/README.md?plain=1#L83-L87
Coverage ReportFileStmtsMissCoverMissingfunctions/example_completed   example_completed.py641970%33, 39–45, 48–51, 55–58, 65–70, 91–92functions/example_manager   example_manager.py441175%31–33, 49–55, 67–69   example_static.py40295%60–61functions/my_exampels   example.py20200%1–31functions/resources   resources.py26260%1–37TOTAL105573930%

Tests
Skipped
Failures
Errors
Time

109
2 :zzz:
1 :x:
0 :fire:
0.583s :stopwatch:

It seems nice (and maybe we can "borrow" it). Licence is MIT, so we probably need to add their copyright notice (Copyright (c) 2021 Misha Kav in the licence file. Also, maybe an opportunity to have all major authors of this action listed there.
Things we may want to change may include:

adapting it to diff-cover if need be
add permalinks to the line misses like this

Missing

[6-7](https://github.com/py-cov-action/python-coverage-comment-action/blob/11fde97cecc399d9c19790cbb337993559be2e7d/action.yml#L6-L7)

See lines
https://github.com/py-cov-action/python-coverage-comment-action/blob/11fde97cecc399d9c19790cbb337993559be2e7d/action.yml#L6-L7

@MartinBernstorff we've done our best :) Please give it a try and tell use what you think !


Packwiz not identifying server properly

I am running packwiz-installer-bootstrap via java -jar packwiz-installer-bootstrap.jar -g https://path/to/pack.toml and I have client mods side = "client" and both sides mods but yet, I see the server is downloading the client side mods as well, is this expected behavior (if so what is the point of settings the side)? And if not, what determines if the machine is a server or a client? If it is unreliable perhaps there should be a flag added to manually identify the machine as a server or a client? I am running packwiz inside a docker container and am running it through pterodactyl panel (Java 8 image ghcr.io/pterodactyl/yolks:java_8).

Yeah, I'll transfer it now.
oooo, that is a cool GitHub feature

Hmmm, could you send the .pw.toml of one of the files that doesn't work? Also try deleting packwiz.json.

I just did a fresh run and apparently it did not download the client side mods but due to an unrelated network error, it is throwing an error but this could be a bug, packwiz does try to download every mod even if labeled as client side which to me sounds like a bug but maybe it is an intentional design decision?

Hmm... are you definitely passing the -s server flag? It should be after java -jar packwiz-installer-bootstrap.jar since arguments before -jar are read by Java and not passed to the launched flag. What's the exact URL you're trying to download from that fails?

Hmm... are you definitely passing the -s server flag? It should be after java -jar packwiz-installer-bootstrap.jar since arguments before -jar are read by Java and not passed to the launched flag.

I did pass the -s server flag properly, and I am happy and sad to report that it was user error and not a bug (or maybe you may deem it as a bug), I was using a bashism to run packwiz then run the server which apparently specifically messed up the last download (it may still be considered the bug because it doesn't flat out fail but strangely fails at the last download
java -jar packwiz-installer-bootstrap.jar -s server -g https://path/to/pack.toml; java -Xms128M -XX:MaxRAMPercentage=95.0 -Dterminal.jline=false -Dterminal.ansi=true $( [[ ! -f unix_args.txt ]] && printf %s "-jar server.jar" || printf %s<EMAIL_ADDRESS>)

What's the exact URL you're trying to download from that fails?
https://jordanplayz158.xyz/JordanPlayz158/23smp/-/raw/master/mods/optifine.pw.toml

Hmm... the problem seems to be with your server: https://jordanplayz158.xyz/JordanPlayz158/23smp/-/raw/master/nonDistributedMods/OptiFine_1.12.2_HD_U_G5_MOD.jar doesn't download for me in Firefox or curl. The reason it is also downloaded on the server side is because any files you put in a packwiz modpack are included, even if they don't have .pw.toml files, so all your nonDistributedMods files are downloaded to a folder with the same name - you'll want to add a .packwizignore file excluding the nonDistributedMods folder.

Very fascinating, so my assumption that is a network issue was correct, wonder what the cause is because ChickenASM has not reported an error once and it is downloaded from the same source. (And I'm not doing anything fancy to my knowledge, if you are on IPv4, the GitLab instance is proxy passed through nginx but if you are on IPv6 you get a direct line to the GitLab) Also thank you for talking about .packwizignore forgot about that and will fix that. But as it sounds like a network error i.e user error on my end, it is my fault and thus, I am sorry for wasting your time without performing (thorough enough) due dilligence and thank you for all the help and guidance


[BUG] 无法部署

Office Tool Plus Version, e.g. <IP_ADDRESS>:

Write down here

Operating System, e.g. Windows 10 20H2 or Windows 7 SP1:

Write down here

Error description (required):

Write down here

Reproduction steps (suggested):
Screenshot (suggested):

Additional information (optional):

没见过这种错误，也暂时不知道解决办法


Species detail page

The species detail page discussions have included:

Consider carefully top of fold information for accuracy (e.g. marine, non-marine etc)
Use e.g. IUCN Redlist, CITES etc APIs to bring in accurate information on official species status
Consider if we want to show species images from checklists or occurrence images
Do not include harvested wikipedia info, but consider showing Wikipedia info in branded iFrame (@MortenHofft has ideas to use a pane sliding in from right)

DH and others will be keen to see iterations early to help offer direction

The names of higher taxonomic levels (family and up) shouldn't be italicized, right?

Indeed not

Still to be done:

[x] display species descriptions
[x] show image gallery

We do not want wikipedia descriptions for the backbone, but the ones coming from Plazi or Pensoft journals are well curated and received information. I would suggest to modify the clb-ws to exclude wikipedia datasets for backbone extensions. Or maybe remove wikipedia datasets alltogether from CLB?
As for images we face similar issues. I would say we should show all images but the wikipedia ones. Again we can modify the clb-ws to ignore those datasets or remove them completely

Related outstanding issue showing taxonomy hierarchy - https://github.com/gbif/portal16/issues/281 Also part of this blocker @MortenHofft?

See also #338 and #137

A nice example of species descriptions we have indexed: http://www.gbif.org/species/8585062#description

Working on gbif/checklistbank#27 to filter backbone extension data

The Species detail page have been reworked and the issues reffered to in this thread arwe closed. I am closing this, but new issues targetting the current version of the page are welcome.


release raiwidgets and responsibleai 0.24.0

Description
v0.24.0

educational materials

Add more linting instructions to CONTRIBUTING.md by @gaugup in https://github.com/microsoft/responsible-ai-toolbox/pull/1810
Update some sample notebooks to include dropped_features by @tongyu-microsoft in https://github.com/microsoft/responsible-ai-toolbox/pull/1836

new features

Responsible AI Dashboard

add binary classification support for RAI text and vision scenarios by @imatiach-msft in https://github.com/microsoft/responsible-ai-toolbox/pull/1778
add multilabel support to RAI dashboard and multilabel text classification covid events dataset by @imatiach-msft in https://github.com/microsoft/responsible-ai-toolbox/pull/1811
Enable dropped_features for error analysis, data explorer and explainer, counterfactual and causal managers by @tongyu-microsoft in https://github.com/microsoft/responsible-ai-toolbox/pull/1824

Error Analysis

Always display tree branching decisions by @tongyu-microsoft in https://github.com/microsoft/responsible-ai-toolbox/pull/1870
Show branching decisions on hover over on unselected tree nodes by @tongyu-microsoft in https://github.com/microsoft/responsible-ai-toolbox/pull/1881

NLP Feature Extractors

RAI test utils

Add rai_test_utils package by @gaugup in https://github.com/microsoft/responsible-ai-toolbox/pull/1777
Add release-rai-test-utils.yml to release rai_test_utils package by @gaugup in https://github.com/microsoft/responsible-ai-toolbox/pull/1797

bug fixes and tests

Responsible AI Dashboard

Update e2e visit() function to not refresh the page if provided name doesn't exist in RAINotebookNames by @tongyu-microsoft in https://github.com/microsoft/responsible-ai-toolbox/pull/1792
Fix TypeError: Cannot read properties of undefined (reading 'sort') by @vinuthakaranth in https://github.com/microsoft/responsible-ai-toolbox/pull/1798
Fix multiple Scroll bars appear on Model demo page after setting the page to 320*256px viewport by @vinuthakaranth in https://github.com/microsoft/responsible-ai-toolbox/pull/1796
Fix ‘Close button’ and ‘Spin button’ present in new cohort dialog does not have any title or aria-label by @vinuthakaranth in https://github.com/microsoft/responsible-ai-toolbox/pull/1806
Fix fast pass accessibility bugs by @vinuthakaranth in https://github.com/microsoft/responsible-ai-toolbox/pull/1817
Add min-width for highchart and fix padding by @vinuthakaranth in https://github.com/microsoft/responsible-ai-toolbox/pull/1818
Add user feature name to box plot hover over by @gaugup in https://github.com/microsoft/responsible-ai-toolbox/pull/1819
update to latest 16.x node version for tests by @imatiach-msft in https://github.com/microsoft/responsible-ai-toolbox/pull/1809
Simplify route generation logic for testing with flights by @romanlutz in https://github.com/microsoft/responsible-ai-toolbox/pull/1530
Use "lower whisker" and "upper whisker" instead of misleading "minimum" and "maximum" on boxplot tooltips by @romanlutz in https://github.com/microsoft/responsible-ai-toolbox/pull/1825
Remove unused flight "newSdkEndpoints" by @gaugup in https://github.com/microsoft/responsible-ai-toolbox/pull/1831
Gate call to probability distribution end point by @gaugup in https://github.com/microsoft/responsible-ai-toolbox/pull/1839
Disable partial dependence plots for large data scenarios by @gaugup in https://github.com/microsoft/responsible-ai-toolbox/pull/1843
add multilabel text example and fix correct and incorrect groups in data analysis by @imatiach-msft in https://github.com/microsoft/responsible-ai-toolbox/pull/1848
Add number of cohort samples inside generateMetrics() by @gaugup in https://github.com/microsoft/responsible-ai-toolbox/pull/1849
add multilabel RAI vision example for fridge multilabel dataset by @imatiach-msft in https://github.com/microsoft/responsible-ai-toolbox/pull/1844
update raiwidgets to rai-core-flask v0.5.0 by @imatiach-msft in https://github.com/microsoft/responsible-ai-toolbox/pull/1851
Remove warning for 'dropped_features are not in use currently.' by @tongyu-microsoft in https://github.com/microsoft/responsible-ai-toolbox/pull/1871
add multilabel model overview metrics by @imatiach-msft in https://github.com/microsoft/responsible-ai-toolbox/pull/1882
Populate probability box chart data on mount by @romanlutz in https://github.com/microsoft/responsible-ai-toolbox/pull/1883
Improve spacing in RAI dashboard by @romanlutz in https://github.com/microsoft/responsible-ai-toolbox/pull/1875

RAIInsights

Update requirements.txt to pin econml to 0.14.0 by @gaugup in https://github.com/microsoft/responsible-ai-toolbox/pull/1813
Remove pip pinning to unblock RAI gates by @gaugup in https://github.com/microsoft/responsible-ai-toolbox/pull/1826
Update requirements-linting.txt to pin isort by @gaugup in https://github.com/microsoft/responsible-ai-toolbox/pull/1847
fix loading older versions of RAIInsights due to _FEATURE_METADATA key error by @imatiach-msft in https://github.com/microsoft/responsible-ai-toolbox/pull/1857
Add better error message if all features are dropped from dataset by @tongyu-microsoft in https://github.com/microsoft/responsible-ai-toolbox/pull/1867

Counterfactual

[Metadata] Fix counterfactual error on unable to update feature value by @tongyu-microsoft in https://github.com/microsoft/responsible-ai-toolbox/pull/1842

Causal

Add e2e for dependency plot Avg of abs value option by @vinuthakaranth in https://github.com/microsoft/responsible-ai-toolbox/pull/1768
Remove redundant call to serialize_json_safe() in raiwidgets causal tests by @gaugup in https://github.com/microsoft/responsible-ai-toolbox/pull/1840
Fetching global causal effects and global policy from SDK backend by @gaugup in https://github.com/microsoft/responsible-ai-toolbox/pull/1753
Remove typo casual and correcting it to causal by @gaugup in https://github.com/microsoft/responsible-ai-toolbox/pull/1846
Disable local causal chart for large data support by @gaugup in https://github.com/microsoft/responsible-ai-toolbox/pull/1845
Add better error message if causal treatment features contain dropped features by @tongyu-microsoft in https://github.com/microsoft/responsible-ai-toolbox/pull/1868

Error Analysis

Update erroranalysis tests to use new rai_test_utils package by @gaugup in https://github.com/microsoft/responsible-ai-toolbox/pull/1800
Fix Heatmap tooltip theme by @vinuthakaranth in https://github.com/microsoft/responsible-ai-toolbox/pull/1808
impute missing values prior to calculating mutual information in erroranalysis by @imatiach-msft in https://github.com/microsoft/responsible-ai-toolbox/pull/1807
update raiwidgets and responsibleai to erroranalysis 0.3.13 by @imatiach-msft in https://github.com/microsoft/responsible-ai-toolbox/pull/1822
Migrate debug_ml and matrix endpoints to compute_error_tree_on_dataset() and compute_matrix_on_dataset() by @gaugup in https://github.com/microsoft/responsible-ai-toolbox/pull/1795
in error analysis, refactor error rate metric into function by @imatiach-msft in https://github.com/microsoft/responsible-ai-toolbox/pull/1742
fix error in erroranalysis heatmap caused by max value over right side of max bin by @imatiach-msft in https://github.com/microsoft/responsible-ai-toolbox/pull/1866

Dataset Explorer

Add dataset analysis chart view for large data by @gaugup in https://github.com/microsoft/responsible-ai-toolbox/pull/1829

Model Overview

Fix Model overview - Dataset cohorts]: At 320*256 viewport content is getting truncated and graph is not visible. by @vinuthakaranth in https://github.com/microsoft/responsible-ai-toolbox/pull/1801
Model overview: add box plot in the regression case by @romanlutz in https://github.com/microsoft/responsible-ai-toolbox/pull/1532
Send the correct column name to SDK backend for model overview distribution charts by @gaugup in https://github.com/microsoft/responsible-ai-toolbox/pull/1835
Derive fairness metrics from metric stats instead of cohort stats by @gaugup in https://github.com/microsoft/responsible-ai-toolbox/pull/1854
Add common APIs for model overview metrics by @gaugup in https://github.com/microsoft/responsible-ai-toolbox/pull/1862

Interpret

Get global explanations from SDK if endpoint available by @gaugup in https://github.com/microsoft/responsible-ai-toolbox/pull/1820
Disabling local feature importance view for large data scenario by @gaugup in https://github.com/microsoft/responsible-ai-toolbox/pull/1828
Remove dead space in aggregate feature importance by @tongyu-microsoft in https://github.com/microsoft/responsible-ai-toolbox/pull/1869

NLP Feature Extractors

remove the unnecessary dependency pins in nlp-feature-extractors package by @imatiach-msft in https://github.com/microsoft/responsible-ai-toolbox/pull/1759
release nlp-feature-extractors 0.1.0 by @imatiach-msft in https://github.com/microsoft/responsible-ai-toolbox/pull/1821
remove unused dependency and method in nlp-feature-extractors package by @imatiach-msft in https://github.com/microsoft/responsible-ai-toolbox/pull/1823

RAI Utils

Port cohort.py from raiwidgets to raiutils by @gaugup in https://github.com/microsoft/responsible-ai-toolbox/pull/1859
Update raiutils to 0.3.0 in raiwidgets, responsibleai, erroranalysis and nlp_feature_extractors by @gaugup in https://github.com/microsoft/responsible-ai-toolbox/pull/1873

other

Add Ke as code owner to remaining folders by @vinuthakaranth in https://github.com/microsoft/responsible-ai-toolbox/pull/1799
Update CODEOWNERS by @tongyu-microsoft in https://github.com/microsoft/responsible-ai-toolbox/pull/1805
merge postga branch into main by @gaugup in https://github.com/microsoft/responsible-ai-toolbox/pull/1815
Remove postga build trigger by @gaugup in https://github.com/microsoft/responsible-ai-toolbox/pull/1816
upgrade setup-python github action from v2 to v4 and pin to older ubuntu image for python 3.6 to fix build error by @imatiach-msft in https://github.com/microsoft/responsible-ai-toolbox/pull/1838
Revert "Update some sample notebooks to include dropped_features" by @tongyu-microsoft in https://github.com/microsoft/responsible-ai-toolbox/pull/1837
fix install command for speech to text example by @imatiach-msft in https://github.com/microsoft/responsible-ai-toolbox/pull/1856
update rai-core-flask by closing WSGIServer on separate thread to fix segfault errors and get the rai-core-flask release builds working again by @imatiach-msft in https://github.com/microsoft/responsible-ai-toolbox/pull/1852
Update maintainers by @romanlutz in https://github.com/microsoft/responsible-ai-toolbox/pull/1860
Update requirements.txt in raiwidgets and responsibleai to pin numpy upper bound by @gaugup in https://github.com/microsoft/responsible-ai-toolbox/pull/1864
Update requirements-linting.txt to remove pin on isort by @gaugup in https://github.com/microsoft/responsible-ai-toolbox/pull/1861
Turn off fail-fast for python tests by @romanlutz in https://github.com/microsoft/responsible-ai-toolbox/pull/1878
Separate out rai_core_flask CI and add paths filter by @romanlutz in https://github.com/microsoft/responsible-ai-toolbox/pull/1884
Remove unused definitions, commented out code, etc. by @romanlutz in https://github.com/microsoft/responsible-ai-toolbox/pull/1876
Update CI-raiwidgets-pytest.yml to skip windows 3.8 tests by @gaugup in https://github.com/microsoft/responsible-ai-toolbox/pull/1890

Checklist

[ ] I have added screenshots above for all UI changes.
[ ] I have added e2e tests for all UI changes.
[ ] Documentation was updated if it was needed.

Codecov Report

Merging #1891 (58d52fc) into main (89995e5) will decrease coverage by 6.59%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1891      +/-   ##
==========================================
- Coverage   92.44%   85.85%   -6.60%
==========================================
  Files         103       29      -74
  Lines        4830      523    -4307
==========================================
- Hits         4465      449    -4016
+ Misses        365       74     -291

Flag
Coverage Δ

unittests
85.85% <ø> (-6.60%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

...nalysis/erroranalysis/_internal/version_checker.py

erroranalysis/erroranalysis/_internal/__init__.py

...ai_core_flask/environments/azure_nb_environment.py

...sibleai/responsibleai/_tools/shared/base_result.py

responsibleai/responsibleai/_internal/constants.py

..._core_flask/environments/databricks_environment.py

...tools/counterfactual/dashboard_schemas/__init__.py

...eai/responsibleai/managers/data_balance_manager.py

erroranalysis/erroranalysis/report/error_report.py

responsibleai/responsibleai/_tools/__init__.py

... and 64 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Windows App and Linux Subsystem Database interactions

Question / Feature request

If I have an app on the Windows host and a database (say even a Json file) installed into the Linux Subsystem, how can the Win-hosted app access this database?

Expected result -- Some form of path or connection string in the feature documentation?

Actual results -- not sure, no idea if this is even possible.

Your Windows build number -- 14393.222

If it's network-based, yes. It even shares IP (and localhost).

Could you give an example? For example, if a MySQL db is installed, it would be accessible as windows-hostname:port ?

Ok, I got it by experimenting. I installed mysql-server on my WSL. Had to set it up to bind to all ip addresses (bind-address=<IP_ADDRESS> in /etc/mysql/my.cnf and then service mysql restart). After opening port 3306 in the Windows Firewall (using Advance Security MMC), I am able to remote-connect to the instance from other boxes using "mysql -h  -u  -p".
Of course, don't forget to grant remote login privs to the !


Use global writer

currently we create a new writer for each renderer call, a global writer without memory alloc/free in each render should have better perfermance.

just tried, no help


Aladin Positional Layer

Add layer to Aladin plot such that you can see all the positions of the objects (and then click on that object to open that page)

Doesn't make sense for the current layout


data prep for migration and population

Cool! I have the following suggestions:

[ ] put all your notebooks under a directory with your name - as it is done for Eszti & Evelyn
[ ] save into csv/tsv... (sg human readable) instead of pickle
[ ] ciaFactBook.ipynb: filter for Europe
[ ] dataprep.ipynb and immigration.ipynb look like the same, probably delete dataprep.ipynb?
[ ] immigration.ipynb: name diagram and use 1.600.000 etc. instead of 1.6 + 1e6
[ ] emigration.ipynb: name diagram
[ ] population.ipynb: the orange country (RU?) seems to have quite an unbelievable curve. Any reasons for that? + diagram naming and full number representation (not 1e6)
[ ] populationProject.ipynb: I think, there's a problem with the numbers. Germany has around 80M population, not 42M. Hungary ~10M, not 5M 🤔 The data in the linked source (https://ec.europa.eu/eurostat/databrowser/view/PROJ_19NP/default/table?lang=en) seems to be correct, though.

PR covers all review requests except for axes without scientific notation, which I could not figure out how it works


Replace type "switch" statements with KindVisitor

Time commitment: 5-10 hours (assuming knowledge of Go)
These sorts of type switches are brittle and break when new groups are added.
https://github.com/kubernetes/kubernetes/blob/28857a2f02ef1490bb6b0109dc1fd7fa5ecae11b/pkg/kubectl/history.go#L56
Instead we should use a common library that is updated, so we don't have to update the code in a dozen places:
https://github.com/kubernetes/kubernetes/blob/e8e617f31dfbfe2ad8ad4743cfcc17ebd6f283a1/pkg/kubectl/apps/kind_visitor.go#L27

@mahdix can you take this one?

cc @mengqiy @seans3

Sure.

These should all be behind the factory interface, not exposed to kubectl directly.  How will someone extend these for non core resources?

These should all be behind the factory interface, not exposed to kubectl directly. How will someone extend these for non core resources?

We shouldn't be compiling into types to kubectl at all, but instead use a combination of duck-typing (via discovery API and openapi) and polymorphic subresources to support dynamic types.  This approach will provide support for CRDs and version skew in addition to other non-core types.
If we need to support compiling in non core resources before this, I expect that is complex enough to warrant its own issue to discuss what the factory interface might look like, how the factories are initialized, and how they are injected.
We should move forward with removing these without blocking on introducing support for non-core types as these are problematic for the following reasons:

they are brittle and break when existing resources are introduced into new groups
they have dependencies on internal kubernetes types preventing us from move code outside of k/k

These sorts of type switches are brittle and break when new groups are added.
https://github.com/kubernetes/kubernetes/blob/28857a2f02ef1490bb6b0109dc1fd7fa5ecae11b/pkg/kubectl/history.go#L56

The type switches in GroupKindElement.Accept() are brittle too:
https://github.com/kubernetes/kubernetes/blob/33f873dbbee58caffcff9e7b44f174a32ec1df92/pkg/kubectl/apps/kind_visitor.go#L51-L52
ReplicaSet exists in "apps" group as well.

These sorts of type switches are brittle and break when new groups are added.
https://github.com/kubernetes/kubernetes/blob/28857a2f02ef1490bb6b0109dc1fd7fa5ecae11b/pkg/kubectl/history.go#L56

The type switches in GroupKindElement.Accept() are brittle too:
https://github.com/kubernetes/kubernetes/blob/33f873dbbee58caffcff9e7b44f174a32ec1df92/pkg/kubectl/apps/kind_visitor.go#L51-L52
ReplicaSet exists in "apps" group as well.

@janetkuo AS these two (ReplicaSet and CronJob) are not used in HistoryViewerFor method, can we do these fixes in another PR?

AS these two (ReplicaSet and CronJob) are not used in HistoryViewerFor method, can we do these fixes in another PR?

Yes, that's a separate issue (a bug in KindVisitor, instead of replacing something with KindVisitor) and should be fixed in a another PR.
Btw, based on the description, this issue is more general than just HistoryViewer? For example, rollback.go uses type switches too: https://github.com/kubernetes/kubernetes/blob/33f873dbbee58caffcff9e7b44f174a32ec1df92/pkg/kubectl/rollback.go#L59-L69

I would suggest we keep this issue open and after PR#55257 was merged, open refactor rollback in a follow-up PR. Then close this issue.


Introduce improving variable

ELO   | 8.57 +- 5.93 (95%)
SPRT  | 8.0+0.08s Threads=1 Hash=64MB
LLR   | 2.95 (-2.94, 2.94) [0.00, 5.00]
GAMES | N: 7824 W: 2425 L: 2232 D: 3167

Readme size TBD

A variant of this was merged in #111. Thanks.


[Girl By Moonlight] Added custom playbook support

Submission Checklist
Required

[x] The pull request title clearly contains the name of the sheet I am editing.
[x] The pull request title clearly states the type of change I am submitting (New Sheet/New Feature/Bugfix/etc.).
[x] The pull request makes changes to files in only one sub-folder.
[x] The pull request does not contain changes to any json files in the translations folder (translation.json is permitted)

Changes / Description
When you select the (Custom) playbook from the selector, sheet now gives a blank playbook with the ability to name the playbook (top of sheet), describe what happens when you Eclipse (Stress section, left side), and add custom abilities to the Special Abilities and Transcendent Abilities blocks.
(Also trimmed off the replication of translation.json JSON object contents from the end of the HTML file as that's an artifact of code development — hence the large number of reported deleted lines. No functionality lost, there!)

Character Sheet Info Roll20 Internal Use only.


Add support for User Federation Mappers

After a first look at the keycloak api I think I'm able to implement a basic version for User Federation Mappers.
This change would make it possible to create User Federation Mappers for AD LDAP User Federations.
But you will have to use the browser and the Network Analysis Tool to provide the right config for needed mappers.
Maybe you can give me some important mappers for you to begin, than I could provide a more convenient command to add an User Federation Mapper.

Hi @klg71 take a look at this: https://www.keycloak.org/docs/latest/server_admin/index.html#adding-mappers

Hi @thomasdarimont I released version 0.1.30 with the convenience actions for the mappers in the link you provided. Also there is an action to create a custom mapper with custom configurations. Can you please check if this fits your needs? :)


GraphQL - Post Lock

What

Allow posts to be locked. When a post is locked only admin will be able to make comments.
Locking/Unlocking a post will be done through a GraphQL Mutation.
Why

Certain people don't know how to be nice to others. 🖕 them.
Checklist

[ ] All files pass Rubocop
[ ] Any complex logic is commented
[ ] Any new systems have thorough documentation
[ ] Any user-facing changes are behind a feature flag (or: explain why they can't be)

[ ] All the tests pass
[ ] Tests have been added to cover the new code

Will need to be adjusted for https://github.com/hummingbird-me/kitsu-server/pull/874

Will need to be adjusted for #874

Yup, will let @NuckChorris merge in first and then fix mine up.


Error: "Failed to activate the linter-pycodestyle package"

I'm getting the following error when I open Atom. "Failed to activate the linter-pycodestyle package"
/home/amanda/.atom/packages/linter-pycodestyle/node_modules/atom-package-deps/node_modules/sb-fs/node_modules/strip-bom-buf/index.js:4
module.exports = x => {
                   ^^
Unexpected token =>

If I view the full stack trace I see the following:
/home/amanda/.atom/packages/linter-pycodestyle/node_modules/atom-package-deps/node_modules/sb-fs/node_modules/strip-bom-buf/index.js:4
module.exports = x => {
                   ^^
SyntaxError: Unexpected token =>
    at exports.runInThisContext (vm.js:53:16)
    at Module._compile (module.js:435:25)
    at Object.loadFile [as .js] (/opt/atom/resources/app.asar/src/babel.js:162:21)
    at Module.load (module.js:347:32)
    at Function.Module._load (module.js:302:12)
    at Module.require (module.js:357:17)
    at require (module.js:376:17)
    at Object.<anonymous> (/home/amanda/.atom/packages/linter-pycodestyle/node_modules/atom-package-deps/node_modules/sb-fs/lib/index.js:11:20)
    at Module._compile (module.js:452:26)
    at Object.loadFile [as .js] (/opt/atom/resources/app.asar/src/babel.js:162:21)

I'm guessing you are running a very old version of Atom, please update to the latest version and try again 😉.

Indeed. I was relying on a ppa that has been disabled for quite some time without my noticing. Upgrading now.


.EPUB Support

Description of the new feature / enhancement
To Read novels.
Scenario when this would be used?
No response
Supporting information
No response

Thanks for enhancement request.
I have had this in plans but its totally different from displaying images. Even if I'm able to make it well it won't be as good as other epub like there like Freda, which provides too many settings just for epub.
I will be working on it but might take a long time.

@omodia Thanks

Will this affect RAM usage?

It might but not any noticeable amount. epub format is not supported on web so I will have to use some other tool to read its data and display it.
You can expect this feature and other issues in about a month as Im busy right now.

Yes, Im currently working on #75. And you can expect it in few days but might have some bugs because I cant test everything, so please report any you encounter.

Sorry but i have tried my best to get a good epub reader in app but cant seem to do it, as of now at least. I will keep trying and learn mre about epub format.
You can try my personal favorite app "Freda" which is available on Microsoft store for free. It has all the necessary features needed for a comfortable read.

Thanks, I will try my best to implement epub in it.


Integration with the latest Angular 2 Applications

Anytime I import this module in the Ionic 2 / Angular 2 using the ngModule decorator, I get the
"angular is not a function".
Is there a way around this or is there an angular2 version of this module?

@uchgames you got any idea on this? If yes, will u pls share that..

Hey @uchgames @suriyaprakash-rivet this has been completed: https://github.com/rvalenciano/ngx-cron-jobs/tree/master


Task - Unclaimed job grid

Resolves #1936
Notes:

Added a grid component, which takes a list of UnclaimedJob objects.
The grid component can be viewed in Storybook under "Unclaimed Job Card" story.

Everything's good, good-wise. But now that we can see how simple UnclaimedJobGrid is, I wonder if its worth giving it its own component. Given that its just a map function inside a single div, I think it might be clearer to include that directly in whatever parent component this eventually ends up in. @yonikid15 Thoughts?
edit: here's how it could look https://github.com/GCTC-NTGC/TalentCloud/tree/task/unclaimed-job-grid-componentless

I think it's a matter of preference at this point. I was thinking maybe we can extend/build the use of the UncliamedJobGrid component in the future if needed. Or if the shape of the grid changes in the future we only need to change the logic in one place (if we end up using it more then once). However, right now we can use your branch instead and change it later if need be.


Fix typo in docs/install.rst

py --> python

IMO py stands for Py launcher shipped with Python 3(Windows only). So the original statement looks good to me.

@frostming Thanks! I didn't know it before. Does it ship with Python 2?

@greyli No. The Py launcher aims at managing multiple Python versions FYI. Glad to help.


QuickJS fork

Hello! I've seen that you have applied some bugfixes and improvements to QuickJS, which seems to be abandoned. Would you please consider forking the original repository yourself and applying your changes on top? I would be happy to use your fork and possibly contribute with more improvements.
Thanks!

I want to do that too, I think you're talking about this: https://github.com/HarlonWang/quickjs


Does it works with Hot Module Replacement?

Try to use it with HMR:
config['entry']['nod.html'] = ['webpack/hot/dev-server', '/Users/nod/www/ps_whmcs/assets/_site/nod.html'];
...
config['plugins'].push(new IndexHtmlPlugin('nod.html', 'nod.html'));

In html file add

When I change the html file, it rebuilds in terminal.
In browser console:
[WDS] App updated. Recompiling...
[WDS] App hot update...

But automatic page refresh does not apply.
Can you advise correct config for HMR?

Hi @nodkz,
unfortunately the internals of HMR are even more obscure than the rest of webpack, and the docs are a bit contradictory.
I don't have any mention of HMR in my files or webpack config, I just start the dev server with
webpack-dev-server --hot --inline

and keep some other options (like contentBase and port) in the devServer section of the webpack.config.js:
devServer: {
    contentBase: './build',
    port: 8081
}

I tried adding hot: true, inline: true there too, but it doesn't seem to work the same way as with the command line parameters.
At the moment I have little idea of what's actually going on when a live reload happens. My guess is that live-reloading HTML (or even CSS) would require quite a different mechanism than live-reloading JS. The architecture of webpack seems to be very much focused on Javascript, so all plugins dealing with other file types in some way seem like a bit of a workaround. So I'm not sure if live-reloading the other stuff is even possible.
I'll be happy to investigate further on this when I get some time :-)

Yep, Webpack documentation is very hard and has many white spaces.
A spend a lot of time to make it work achieved through trial and error.
Now if I change data in entry html, browser automatically refresh page. Hooray!
But solution is not so good, as I want. So I provide here my config, may be some make better solution.
package.json
{
   scripts: {
      "hot": "webpack-dev-server",
      ...
   }
   ...
}

which I start via terminal npm run hot
Full configuration of dev server I pass to webpack.config.js:
  config['devServer'] = {
        contentBase: './',
        colors: true,
        historyApiFallback: false,  // when false, dev server make directory listing, good feature to navigate in project
        hot: true,
        inline: true,
        progress: true,
        port: 8008
    };

Also in plugins I add
config['plugins'].push(new webpack.HotModuleReplacementPlugin());

Now dev server has configured.
So let configure entry points.
config['entry']['nod.html'] = '/Users/nod/www/ps_whmcs/assets/_site/nod.html';
config['entry']['dev-hot-module-replacement'] = ['webpack/hot/only-dev-server', '/Users/nod/www/ps_whmcs/assets/_site/nod.html'];

As you can see, first line is simple. But second line create dev-hot-module-replacement.js with WDS, HRM and html file itself. This hack let WDS to track changes in entry html file. But HRM can not implement changes [HMR] Cannot apply update. Need to do a full reload!. Because html which packed in js module not connected to page or another module.
So last point is my html file:
<!DOCTYPE html>

344

Here we add dev-hot-module-replacement.js which entry point described above.
Now if we change content in entry html file, browser produces page reload.