Pydantic V2 warning

SDK Version (required)
Provide the version you are using.
❯ python
Python 3.11.4 (main, Feb  2 2024, 19:01:43) [Clang 14.0.0 (clang-14<IP_ADDRESS>)] on darwin
Type "help", "copyright", "credits" or "license" for more information.
>>> import cohere
/user/home/.venv/lib/python3.11/site-packages/pydantic/_internal/_config.py:341: UserWarning: Valid config keys have changed in V2:
* 'allow_population_by_field_name' has been renamed to 'populate_by_name'
* 'smart_union' has been removed
  warnings.warn(message, UserWarning)
>>> print(cohere.__version__)
5.8.0
>>> import pydantic
>>> pydantic.VERSION
'2.8.2'

Describe the bug
I am getting this warning while trying to use the library.
.venv/lib/python3.11/site-packages/pydantic/_internal/_config.py:341: UserWarning: Valid config keys have changed in V2:
* 'allow_population_by_field_name' has been renamed to 'populate_by_name'
* 'smart_union' has been removed
  warnings.warn(message, UserWarning)

This warning is triggering from the code below:

https://github.com/cohere-ai/cohere-python/blob/540207821d15fcf933935e44f76a07cd69e53465/src/cohere/core/pydantic_utilities.py#L85-L90

I proposed a PR, please review

https://github.com/cohere-ai/cohere-python/pull/560

Thanks @n1lanjan we are looking into this!

This is now fixed in the latest version of the sdk! thanks @n1lanjan

The latest version still triggers deprecation warnings with Pydantic V2. You can see this if you import the Cohere library while elevating warnings to errors (like we do in our test suite):
$ python -W all -c 'import cohere'
<path>/.venv/lib/python3.12/site-packages/pydantic/_internal/_generate_schema.py:273: PydanticDeprecatedSince20: `json_encoders` is deprecated. See https://docs.pydantic.dev/2.8/concepts/serialization/#custom-serializers for alternatives. Deprecated in Pydantic V2.0 to be removed in V3.0. See Pydantic V2 Migration Guide at https://errors.pydantic.dev/2.8/migration/
  warnings.warn(
<path>/.venv/lib/python3.12/site-packages/pydantic/_internal/_generate_schema.py:273: PydanticDeprecatedSince20: `json_encoders` is deprecated. See https://docs.pydantic.dev/2.8/concepts/serialization/#custom-serializers for alternatives. Deprecated in Pydantic V2.0 to be removed in V3.0. See Pydantic V2 Migration Guide at https://errors.pydantic.dev/2.8/migration/
  warnings.warn(
<path>/.venv/lib/python3.12/site-packages/pydantic/_internal/_generate_schema.py:273: PydanticDeprecatedSince20: `json_encoders` is deprecated. See https://docs.pydantic.dev/2.8/concepts/serialization/#custom-serializers for alternatives. Deprecated in Pydantic V2.0 to be removed in V3.0. See Pydantic V2 Migration Guide at https://errors.pydantic.dev/2.8/migration/
  warnings.warn(
<path>/.venv/lib/python3.12/site-packages/pydantic/_internal/_generate_schema.py:273: PydanticDeprecatedSince20: `json_encoders` is deprecated. See https://docs.pydantic.dev/2.8/concepts/serialization/#custom-serializers for alternatives. Deprecated in Pydantic V2.0 to be removed in V3.0. See Pydantic V2 Migration Guide at https://errors.pydantic.dev/2.8/migration/
  warnings.warn(
<path>/.venv/lib/python3.12/site-packages/pydantic/_internal/_generate_schema.py:273: PydanticDeprecatedSince20: `json_encoders` is deprecated. See https://docs.pydantic.dev/2.8/concepts/serialization/#custom-serializers for alternatives. Deprecated in Pydantic V2.0 to be removed in V3.0. See Pydantic V2 Migration Guide at https://errors.pydantic.dev/2.8/migration/
  warnings.warn(
<path>/.venv/lib/python3.12/site-packages/pydantic/_internal/_generate_schema.py:273: PydanticDeprecatedSince20: `json_encoders` is deprecated. See https://docs.pydantic.dev/2.8/concepts/serialization/#custom-serializers for alternatives. Deprecated in Pydantic V2.0 to be removed in V3.0. See Pydantic V2 Migration Guide at https://errors.pydantic.dev/2.8/migration/
  warnings.warn(
<path>/.venv/lib/python3.12/site-packages/pydantic/_internal/_generate_schema.py:273: PydanticDeprecatedSince20: `json_encoders` is deprecated. See https://docs.pydantic.dev/2.8/concepts/serialization/#custom-serializers for alternatives. Deprecated in Pydantic V2.0 to be removed in V3.0. See Pydantic V2 Migration Guide at https://errors.pydantic.dev/2.8/migration/
  warnings.warn(
<path>/.venv/lib/python3.12/site-packages/pydantic/_internal/_generate_schema.py:273: PydanticDeprecatedSince20: `json_encoders` is deprecated. See https://docs.pydantic.dev/2.8/concepts/serialization/#custom-serializers for alternatives. Deprecated in Pydantic V2.0 to be removed in V3.0. See Pydantic V2 Migration Guide at https://errors.pydantic.dev/2.8/migration/
  warnings.warn(
<path>/.venv/lib/python3.12/site-packages/pydantic/_internal/_generate_schema.py:273: PydanticDeprecatedSince20: `json_encoders` is deprecated. See https://docs.pydantic.dev/2.8/concepts/serialization/#custom-serializers for alternatives. Deprecated in Pydantic V2.0 to be removed in V3.0. See Pydantic V2 Migration Guide at https://errors.pydantic.dev/2.8/migration/
  warnings.warn(
<path>/.venv/lib/python3.12/site-packages/pydantic/_internal/_generate_schema.py:273: PydanticDeprecatedSince20: `json_encoders` is deprecated. See https://docs.pydantic.dev/2.8/concepts/serialization/#custom-serializers for alternatives. Deprecated in Pydantic V2.0 to be removed in V3.0. See Pydantic V2 Migration Guide at https://errors.pydantic.dev/2.8/migration/
  warnings.warn(
<path>/.venv/lib/python3.12/site-packages/pydantic/_internal/_generate_schema.py:273: PydanticDeprecatedSince20: `json_encoders` is deprecated. See https://docs.pydantic.dev/2.8/concepts/serialization/#custom-serializers for alternatives. Deprecated in Pydantic V2.0 to be removed in V3.0. See Pydantic V2 Migration Guide at https://errors.pydantic.dev/2.8/migration/
  warnings.warn(


The API will need to pay attention to redirected IDs from ES

Part of https://github.com/wellcometrust/platform/issues/1010
Depends on https://github.com/wellcometrust/platform/issues/1384

In order that the API can quickly respond with the correct version we'll need to decide how to implement the redirection strategy in the API.

Closing as out of date.


introduction of opinionated autoformating? (prettier)

Hi, Would you accept a PR introduced prettier to auto-format the all the code? This would reduce PR review cost? So including all the .js, configs and examples?

I just added the pre-commit hook myself, thanks for the tip.) https://github.com/pyatyispyatil/flame-chart-js/commit/37497887392fad95d6faadcb866f1e4579c8e489 https://github.com/pyatyispyatil/flame-chart-js/commit/9087d924e0c560a5047dc97b55cdcdbbd87e41a6


Task/rhornung67/v0.10.0 rc

Summary

This PR prepares for v0.10.0 Axom release.
It includes version updates and updated host-configs for new versions of TPLs

With commit 3f1fa72, I successfully built TPLs using vcpkg on my laptop, built Axom (both Debug and Release), and ran the test suite with no failures.
Note that this is without MPI and without Fortran, but with OpenMP.

woops, there was a test failure on Release: slic_macros.

woops, there was a test failure on Release: slic_macros.

Hm, I did run into an error on Windows with removing files in Azure Pipelines, and tried to guard against it:
https://github.com/LLNL/axom/blob/842a62463b413493bc459e52274c9c7c5d16a6d9/src/axom/slic/tests/slic_macros.cpp#L470-L474
Is it possibly related to that, or something else?

woops, there was a test failure on Release: slic_macros.

Hm, I did run into an error on Windows with removing files in Azure Pipelines, and tried to guard against it:
https://github.com/LLNL/axom/blob/842a62463b413493bc459e52274c9c7c5d16a6d9/src/axom/slic/tests/slic_macros.cpp#L470-L474
Is it possibly related to that, or something else?

It is certainly related.  The errors I see are from that test: the files already exist (from a previous run) because they were not cleaned up.  If I delete file_no_fmt.txt and file_with_fmt.txt by hand (i.e. do the job from lines 472 and 473 that you disabled on Windows), the test succeeds and leaves those files behind.

It is certainly related. The errors I see are from that test: the files already exist (from a previous run) because they were not cleaned up. If I delete file_no_fmt.txt and file_with_fmt.txt by hand (i.e. do the job from lines 472 and 473 that you disabled on Windows), the test succeeds and leaves those files behind.

Darn. Removing the check worked for Azure because every job run is a fresh build. Just realizing makes sense it would fail running the unit tests again. I'll try to debug this in the Windows Azure build, should hopefully fix things on your desktop as well.

It is certainly related. The errors I see are from that test: the files already exist (from a previous run) because they were not cleaned up. If I delete file_no_fmt.txt and file_with_fmt.txt by hand (i.e. do the job from lines 472 and 473 that you disabled on Windows), the test succeeds and leaves those files behind.

Darn. Removing the check worked for Azure because every job run is a fresh build. Just realizing makes sense it would fail running the unit tests again. I'll try to debug this in the Windows Azure build, should hopefully fix things on your desktop as well.

What is happening is that the program still has handles open to the file: they haven't been closed.  On Windows, that causes the _unlink to fail.  On Linux, it doesn't care: it just deletes the file.  If you want to delete a file on Windows you have to close all open handles.

What is happening is that the program still has handles open to the file: they haven't been closed. I confirmed this by running Process Explorer.
🤦  I didn't close the files prior to attempting to delete. Trying that now.

@bmhan12 if you have changes to make related to closing files, feel free to do that on this RC branch or on a separate PR. Whichever you prefer.

So in order for axom::utilities::filesystem::Unlink() https://github.com/LLNL/axom/blob/develop/src/axom/core/utilities/FileUtilities.cpp#L126 to succeed, you will need to first call std::ofstream::close() wherever applicable.
I see that GenericOutputStream is built to deal with ostream, which is an abstraction level above ofstream.  The ofstream gets closed in its destructor (https://en.cppreference.com/w/cpp/io/basic_ofstream/close, see "Notes") and the GenericOutputStream deletes its ostream in ~GenericOutputStream, so before deleting the files, we could tell slic to delete all output streams.  @white238 , what do you think?

So in order for axom::utilities::filesystem::Unlink() https://github.com/LLNL/axom/blob/develop/src/axom/core/utilities/FileUtilities.cpp#L126 to succeed, you will need to first call std::ofstream::close() wherever applicable.
I see that GenericOutputStream is built to deal with ostream, which is an abstraction level above ofstream. The ofstream gets closed in its destructor (https://en.cppreference.com/w/cpp/io/basic_ofstream/close, see "Notes") and the GenericOutputStream deletes its ostream in ~GenericOutputStream, so before deleting the files, we could tell slic to delete all output streams. @white238 , what do you think?

Really nice find @agcapps!
Can we please add a note about this in the doxygen for removeFile?
https://github.com/LLNL/axom/blob/24751dd2a06152f0bb6d057377b0674c837b0390/src/axom/core/utilities/FileUtilities.hpp#L86-L92
@bmhan12 -- perhaps this should be added to #1424 ?


satisfy test: if the user logs in, and they are not mapped to an address, notify them through discobot (1 day)

[ ] Generate a system message that says that the user does not have an address registered
[ ] Encourage them to link one if they have one
[ ] Create route and page for web3.addresses[0] to be passed to the backend plugin
[ ] Plugin has an interface called plugin_store that will persist the address


"Automatically enable and disable charging separation at customizable battery levels" is not working for me

Hello, first of all, thank you very much for developing this app!
I don't know if I'm doing something wrong, but "Automatically enable and disable charging separation at customizable battery levels" is not working on my Odin 2. The charging separation works well, but if I choose between 40% and 60% in Odin Tools, it ignores it and charges up to 87%.
My Odin 2 is on the latest update, and I'm using OdinTools 1.3.1.
I would like to be able to keep the Odin 2 always in the dock, but limit the charging to 60%. Is this possible?
Thank you very much in advance!

Apologies. It's become apparent that charging separation does not behaves as expected in the Odin 2.
If the battery level is less than 85% when the device goes to sleep with charge separation on, it will charge anyways. Please see original discord comment below.

From my personal testing, setting charge limit to 90% works okay. Anything below 90% will result in the scenario you described.

Thank you for the response! Unfortunately, leaving it at 90% didn't work for me. I left it on the dock yesterday at 88% (even though it wasn't charging while I was awake and checking the charge), and when I woke up, it was at 100% battery (it possibly started charging during the night). Now I'm not sure if keeping the Odin 2 always on the dock could be bad for the battery's lifespan.
Do you think in a future update they might implement charging separation for sleep mode as well?


cannot ssh to vm when in masquerade mode

Is this a BUG REPORT or FEATURE REQUEST?:

Uncomment only one, leave it on its own line:
/kind bug

What happened:
Can not ssh to vm when the vm in masquerade mode.
And the VM cannot access the Internet and cannot connect to the node.
What you expected to happen:
How to reproduce it (as minimally and precisely as possible):
spec:
      domain:
        devices:
          disks:
            - disk:
                bus: virtio
              name: rootfs
            - disk: {}
              name: cloudinitdisk
          interfaces:
            - masquerade: {}
              name: default
              ports:
                - port: 22
        machine:
          type: q35
        resources:
          limits:
            cpu: '1'
            memory: 2Gi
          requests:
            cpu: '1'
            memory: 2Gi
      networks:
        - name: default
          pod: {}

But I got the result is:
ssh<EMAIL_ADDRESS>ssh: connect to host <IP_ADDRESS> port 22: Connection refused

Anything else we need to know?:
This problem exists with both the kube-ovn and calico network CNI plugin.
On the same network CNI plugin, when I dropped the kubevirt version down to 0.36.0, it worked and the above problem disappeared
Environment:

KubeVirt version (use virtctl version): v0.44.1+
Kubernetes version (use kubectl version): v1.21.4
VM or VMI specifications: as above
Cloud provider or hardware configuration:
OS (e.g. from /etc/os-release): centos7
Kernel (e.g. uname -a):3.10.0
Install tools:
Others:
The same problem exists in version kubevirt v0.48.x

Is it a bug in 0.44.1 version of kubevirt?
Is it the same issue with this issue? https://github.com/kubevirt/kubevirt/issues/6620

This problem persists when kubevirt is upgraded to the latest version.
Can anyone answer this question?
@rmohr

@zhhray can you verify that other pods can reach the internet, and in addition, can you try connecting to the vm via virtctl console (serial console) or virtctl vnc (remote desktop) and check its network setup? Maybe it does not run dhcp by default?

@zhhray can you verify that other pods can reach the internet, and in addition, can you try connecting to the vm via virtctl console (serial console) or virtctl vnc (remote desktop) and check its network setup? Maybe it does not run dhcp by default?

I can reach the internet and nodes in virt-launcher Pod. But I can’t in VM when I connect to the vm via virtctl vnc.
Ping the IP address of the node in the VM, the source IP address is <IP_ADDRESS>, which is a private NAT network address.
I think the source IP address should be the IP address of the Virt-Launcher Pod.
So  I guess that, the code of virt-Launcher Pod is having problems configuring the network for the VM.

Is there any key information or log that I can provide?

I'm interested in the VMI status (just making sure you're sshing to the correct address). Can you show us the interface status of the VM ?
kubectl get vmi <vm name> -ojsonpath="{ @.status.interfaces }"
Also, does the issue persist if your VMI spec does not feature the list of allowed ports ? (i.e. drop the ports key from the interface spec portion).

Hello @zhhray, this does seem to be the same issue as described here: https://github.com/kubevirt/kubevirt/issues/6620
Could you please provides us with the virt-handler logs (collected from the virt-handler pod that runs on the same node as your VM is scheduled on) and NAT table as described in this comment? https://github.com/kubevirt/kubevirt/issues/6620#issuecomment-1008942320

I'm interested in the VMI status (just making sure you're sshing to the correct address). Can you show us the interface status of the VM ? kubectl get vmi <vm name> -ojsonpath="{ @.status.interfaces }"
Also, does the issue persist if your VMI spec does not feature the list of allowed ports ? (i.e. drop the ports key from the interface spec portion).

Firstly, the interfaces of vmi status are:

kubectl get vmi -n kubevirt-test natcentos -o yaml -ojsonpath="{ @.status.interfaces }"
[{"interfaceName":"eth0","ipAddress":"<IP_ADDRESS>","ipAddresses":["<IP_ADDRESS>"],"mac":"02:73:44:00:00:01","name":"default"}]

2.Secondly,I modified my YAML content as follows:
spec:
      domain:
        devices:
          disks:
            - disk:
                bus: virtio
              name: rootfs
            - disk:
                bus: virtio
              name: cloudinitdisk
          interfaces:
            - name: default
              masquerade: {}

But the problems mentioned above still exist.

Hello @zhhray, this does seem to be the same issue as described here: #6620
Could you please provides us with the virt-handler logs (collected from the virt-handler pod that runs on the same node as your VM is scheduled on) and NAT table as described in this comment? #6620 (comment)

THX.
ssh to the node where the VM is running
Run $ docker ps or $ crictl ps and finc the container ID for a virt-launcher pod
Run $ docker inspect <the container ID> | grep pid to get the PID of the virt-launcher process
Run $ sudo nsenter -t <PID> -n
Run nft list table nat

The result is :
nft list table nat
table ip nat {
	chain prerouting {
		type nat hook prerouting priority -100; policy accept;
		iifname "eth0" counter packets 0 bytes 0 jump KUBEVIRT_PREINBOUND
	}

	chain input {
		type nat hook input priority 100; policy accept;
	}

	chain output {
		type nat hook output priority -100; policy accept;
		ip daddr { <IP_ADDRESS> } counter packets 0 bytes 0 dnat to <IP_ADDRESS>
	}

	chain postrouting {
		type nat hook postrouting priority 100; policy accept;
		ip saddr <IP_ADDRESS> counter packets 0 bytes 0 masquerade
		oifname "k6t-eth0" counter packets 0 bytes 0 jump KUBEVIRT_POSTINBOUND
	}

	chain KUBEVIRT_PREINBOUND {
		counter packets 0 bytes 0 dnat to <IP_ADDRESS>
	}

	chain KUBEVIRT_POSTINBOUND {
		ip saddr { <IP_ADDRESS> } counter packets 0 bytes 0 snat to <IP_ADDRESS>
	}
}

By the way, my configuration in Kubevirt's CR is already like this. However, the startup argument -v of all virt-xxx components still has a value of 2. I killed all pods in kubevirt namespace.But it didn't work.
 spec:
    configuration:
      developerConfiguration:
        logVerbosity:
          virtAPI: 4
          virtController: 4
          virtHandler: 4
          virtLauncher: 4
          virtOperator: 4

I looked through virt-handler's logs and didn't get any valuable error messages.

Hello @zhhray, thanks for the info.

I looked through virt-handler's logs and didn't get any valuable error messages.

I can confirm that the NAT table rules is correct, so nothing bad happened in the virt-handler.
So traffic entering the virt-launcher pod should be delivered to the VM, and traffic coming out of the VM should
have source address set to the IP of the pod.
@zhhray you mentioned:

Ping the IP address of the node in the VM, the source IP address is <IP_ADDRESS>, which is a private NAT network address.
I think the source IP address should be the IP address of the Virt-Launcher Pod.

Where did you see that <IP_ADDRESS> source address? it's okay to see it in the VM or in the virt-launcher, but if you captured
traffic on the node, then you should not see this source address leave the virt-launcher pod.
Could you please confirm the following:

in the Virtual machine (virtctl console or vnc)

ip route
ping -c 2 <IP_ADDRESS>
ping -c 2 NODE_IP
ping -c 2 <IP_ADDRESS>

In the virt-launcher pod (by switching to the network namespace, the same procedure used to collect nftable nat table)

ip route
ping -c 2 <IP_ADDRESS>
ping -c 2 NODE_IP
ping -c 2 <IP_ADDRESS>

Thank you

/kind bug

may be node's kernel version too low(<3.15), which leads to nftables not working

may be node's kernel version too low(<3.15), which leads to nftables not working

Thanks for your replay.
This promblem still exists when my kernel is 4.14.
uname -a
Linux cp-dev-0 4.14.105-19-0023 #1 SMP Mon Jan 10 17:53:54 CST 2022 x86_64 x86_64 x86_64 GNU/Linux

I came across the same problem for kernel 3.10,  after I update node os to kernel 4.18, it works all right.

may be node's kernel version too low(<3.15), which leads to nftables not working

@qyzhaoxun @SimpCosm
Thanks very much, I tried to upgrade the Kernel version of node to the newest(5.4.190-1.el7.elrepo.x86_64) and it really works.
@rhrazdil
Could you please explain that there used to be no kernel version limitation, but now there is?

Interesting, thanks @qyzhaoxun @SimpCosm for pointing this out!
It appears our CI is kept up-to-date, so this issue has completely flew under the radar.
@zhhray This change on kubevirt side is then most likely related to a switch to prefer nftables, when nftables are available. https://github.com/kubevirt/kubevirt/blob/245c67cf1055a53ad0e8beb2fc3556474c86d822/pkg/network/infraconfigurators/masquerade.go#L225-L229
I can't tell what is the reason behind nftables not working on older kernels.
Is there a reason why you need to stay on older kernel? If so, a workaround may be removing nftables so that kubevirt uses iptables instead. But I would discourage from going this way, since kubevirt may drop iptables support in the future, and there are already features that don't work on iptables (i.e. Istio).

Interesting, thanks @qyzhaoxun @SimpCosm for pointing this out! It appears our CI is kept up-to-date, so this issue has completely flew under the radar.
@zhhray This change on kubevirt side is then most likely related to a switch to prefer nftables, when nftables are available.
https://github.com/kubevirt/kubevirt/blob/245c67cf1055a53ad0e8beb2fc3556474c86d822/pkg/network/infraconfigurators/masquerade.go#L225-L229
I can't tell what is the reason behind nftables not working on older kernels.
Is there a reason why you need to stay on older kernel? If so, a workaround may be removing nftables so that kubevirt uses iptables instead. But I would discourage from going this way, since kubevirt may drop iptables support in the future, and there are already features that don't work on iptables (i.e. Istio).

In fact, many times the host kernel version is not kept up to date, but for this problem, is it possible to add a switch in the code to configure whether to use nftables or iptables？nftables was installed in virt-handler container image, so  uninstalling it is not a good way.

In fact, many times the host kernel version is not kept up to date, but for this problem, is it possible to add a switch in the code to configure whether to use nftables or iptables？

We prefer not to add such tweaks, especially when iptables are de-factor considered deprecated.
The iptables which existed in the past have actually been just wrappers, the backend was for years nftables.

nftables was installed in virt-handler container image, so uninstalling it is not a good way.

I agree that this is a bad workaround, but just because we eventually will drop iptables support eventually (we should have sent a deprecation note already).
I would suggest investigating how the kernel has an impact on this at all.
We are running Kubevirt on older kernels (e.g. 4.18) on downstream and this has not been observed AFAIK.

In fact, many times the host kernel version is not kept up to date, but for this problem, is it possible to add a switch in the code to configure whether to use nftables or iptables？

We prefer not to add such tweaks, especially when iptables are de-factor considered deprecated. The iptables which existed in the past have actually been just wrappers, the backend was for years nftables.

nftables was installed in virt-handler container image, so uninstalling it is not a good way.

I agree that this is a bad workaround, but just because we eventually will drop iptables support eventually (we should have sent a deprecation note already).
I would suggest investigating how the kernel has an impact on this at all. We are running Kubevirt on older kernels (e.g. 4.18) on downstream and this has not been observed AFAIK.

I tracked the same issue for days, this is what i found:

nft's masquerade mode is available starting with Linux Kernel 3.18.
centos 8's iptables tool has drop the iptables-legacy and after that iptables command still call nftables kernel API.

In this case, kubevirt will add a requirement for Kernel version or not?

:ping_pong: @EdDev

A depreciation notice has been sent for iptables a few months back.
We plan to remove it very soon from the codebase.
Regarding the minimum kernel version, I think the policy is that kubevirt supports formally the version which the e2e tests run with. Maybe we should document a version matrix, but at the moment it is lacking.


Detecting when a stream connection is lost

Other question : from the current implementation of the streaming (of new conversations & messages), is there a way to know when the connection is “lost” somehow?
It’s important to us for 2 things:
show the user that we’re currently trying to reconnect
resync information that might have been lost during this disconnect period
We already have a way to detect full disconnect on the phone (the OS tells us internet is not reachable anymore) but it’s not the same as connection failing for a short while

@nplasterer Does this error not show during a disconnect? https://github.com/xmtp/libxmtp/blob/v2/bindings_swift/src/lib.rs#L136
I'm wondering if the keepalive we added will automatically address this issue

@richardhuaaa just adding here: my goal is to get back in real time that information directly in the RN SDK to show something to the user (a loader / a "connecting..." message)

@nmalzieu The grpc keepalive is being reduced to 3s here: https://github.com/xmtp/libxmtp/pull/267. I'm becoming more confident that this is a reasonable approach given this description in the docs: https://grpc.io/docs/guides/keepalive/#common-situations-where-keepalives-can-be-useful
With a 3s timeout, most disconnects should recover near instantly, depending where in the 3s cycle the disconnect happens, and if the disconnect itself was longer than 3s.
Once that change is deployed, I'm wondering if this error will show near instantly on disconnect: https://github.com/xmtp/libxmtp/blob/v2/bindings_swift/src/lib.rs#L136

@richardhuaaa yes I saw, thanks a lot for this!
"most disconnects should recover near instantly" => well, not if you have a bad connection!
The grpc keepaliv task is great to recover streaming fast when connection comes back - but my goal here is to also handle the moment when the connection doesn't come back just now - I need my users to know thei're currently not receiving messages and adapt the UI.
For the subscription_closed error => well I didn't see it before and don't know how the React Native SDK can catch it easily, but I'm happy to test it out - @nplasterer what do you think?


(PUP-6856) Catch :no_such_key during interpolation sub_lookup

An interpolation that uses dotted keys that in turn results in a
:no_such_key being thrown (because the key is missing), would not catch the
throw and hence, yield strange results. This commit ensures that the thrown
symbol :no_such_key is caught so that the call instead results in an empty
string.

CLA signed by all contributors.


Include best practice for clientlib CSS support files

Hi, just a small request, as there is no easy consensus on how clientlibs work. And probably this archetype would be the best way to provide best practice
It is suggested to use Component-Level clientlibs, these are all grouped up by a clientlib at the /etc/design level, which guarantees they are not being exposed from the /apps level
However, this gets a bit blurry when there are images or fonts involved. If lets say component A has the following CSS rule
.bg {
background-image: url(../img/cloud-img.png);}
That resolves to
background-image: url(../../../apps/my-project/components/content/componentA/clientlib/img/cloud-img.png);
despite of the clientlib being offered via /etc/clientlib-all
Whats your take on this case?
Could you add an image folder to the archetype and provide a nice read-me suggesting best practice?

@pmminov images should not be stored with your clientlibs. They should be stored in etc/designs.

@pmminov With the latest AEM 6.3 release you also have the possibility to serve a clientlib via a proxy servlet, which bypasses the ACL restrictions. You can also access static resources like images and fonts, if they are located in a resources subdirectory.
For more information please have a look to the related documentation at https://adobe.ly/2fOb5Tl


Error "Cannot install a messenger instance twice"

I am trying to use autoname module but keep getting the error in the title.
import torch.nn as nn
from pyro.contrib import autoname

class A(nn.Module):
    @autoname.name_count
    def __call__(self, *args, **kwargs):
        return super(A, self).__call__(*args, **kwargs)

class B(A):
    def forward(self, x):
        return x

class C(A):
    def __init__(self, b):
        super(C, self).__init__()
        self.b = b

    def forward(self, x):
        return x + self.b(x)

b = B()
c = C(b)
c(1)  # error

I am not sure how to solve this problem. There is a note about raising this error in the messenger.py file and the following script does not raise any error
@autoname.name_count
def c(x):
    @autoname.name_count
    def b(x):
        return x
    return x + b(x)

c(1)  # no error

I appreciate any help!

Your two scenarios are not equivalent.  This error is caused by the way decorators work: the decorator is called once at class definition, not each time a new instance is created.  A version of the second scenario that should raise the same error as the first is:
nc = autoname.name_count()

@nc
def c(x):
    @nc
    def b(x):
        return x
    return x + b(x)

c(1)  # error

The safest way to get around this is to use name_count as a context manager:
class A(nn.Module):
    def __call__(self, *args, **kwargs):
        with autoname.name_count():
            return super(A, self).__call__(*args, **kwargs)

Thank you so much @eb8680 ! Your solution works like a charm.


to_netcdf Documentation

I found this SO thread reply very helpful when I had to create some netcdf files with many attributes.
http://stackoverflow.com/questions/22933855/convert-csv-to-netcdf/28914767#28914767
I thought to bring it to your attention.
The documentation on http://xarray.pydata.org/en/stable/io.html#netcdf
could use a more detailed example and this is very clear.

If you have concrete suggestions for improving the IO docs page (even if only to add a link to that StackOverflow post), a PR would be greatly appreciated!
You can find the source code for that doc page here:
https://github.com/pydata/xarray/blob/master/doc/io.rst

I will be happy to add these info to the documentation.


Example-specific fixes for: MoltenVK config, OpenMP build, UBO size alignment, descriptorindexing memory bounds error

This is a set of example-specific fixes:

Set MoltenVK configuration for descriptorindexing (enable Metal argument buffers for descriptor indexing on macOS, not available on iOS), oit (use VK_IMAGE_TILING_LINEAR vs. VK_IMAGE_TILING_OPTIMAL for atomic image access on macOS/iOS), and computeraytracing / specializationcontants (disable Metal argument buffers for macOS)
Optimize CMakeLists for OpenMP build - only run find_package(OpenMP) for texture3d example, minimizing per-example cmake build overhead which is significant when OpenMP is not installed, applies to all platforms
Fix vertex memory bounds error in descriptorindexing - this appeared as graphics corruption when testing on Apple M1, but is a generic problem.  The indices list (index buffer) was constructed incorrectly and was referencing beyond the end of the cube vertices list (vertex buffer).  The solution is a simple reordering of the fill loop, and results in the correct number of cubes being generated (loop count now set to 5 instead of 6, with 5 cubes + indices correctly generated)
Fix UBO buffer size inconsistency between code and shaders for computeraytracing, ssao, and texturearray examples.  I noticed this when testing on macOS where Xcode performs Metal API argument validation by default.  The fixes are generic, and perhaps may be helpful for Vulkan API argument validators (??) on other platforms.

Tested on macOS, iOS, Windows, and Linux.
This is likely my last pull request for a while, as I have exhausted what I can do for the macOS/iOS platforms without further improvements in MoltenVK and/or Metal (e.g. 1.2 API, geometry shaders, ray tracing).  At least for the moment I have 65 of the 79 examples running cleanly (no validation errors) on macOS with MoltenVK 1.1.10 (SDK 1.3.216) using my test rigs (Intel Mac/AMD GPU with Big Sur, MacBook Air M1 with Monterey).
This is a very useful project and thanks to @SaschaWillems for originating and maintaining it.

Just for reference, I thought I would list the missing extensions and device features that would be required for MoltenVK/Metal to support the remaining 14 examples:
VK_EXT_conditional_rendering (for conditionalrender example)
VK_EXT_conservative_rasterization (for conservativeraster example)
VK_KHR_pipeline_library (for graphicspipelinelibrary example)
VK_EXT_graphics_pipeline_library (for graphicspipelinelibrary example)
VK_KHR_acceleration_structure (for all ray* examples)
VK_KHR_buffer_device_address (for all ray* examples) - now supported by MoltenVK/Metal 3 on macOS 13/iOS 16
VK_KHR_spirv_1_4 (for all ray* examples)
VK_KHR_shader_float_controls (for all ray* examples)
VK_KHR_ray_tracing_pipeline (for all ray* examples except for rayquery)
VK_KHR_deferred_host_operations (for all ray* examples except for rayquery)
VK_KHR_ray_query (for rayquery example)
VK_NV_shading_rate_image (for variablerateshading example)
VkPhysicalDeviceFeatures::geometryShader (for deferredshadows, geometryshader, viewportarray examples)
VkPhysicalDeviceFeatures::pipelineStatisticsQuery (for pipelinestatistics example)
VkPhysicalDeviceFeatures::sparseBinding (for texturesparseresidency example)
VkPhysicalDeviceFeatures::sparseResidencyImage2D (for texturesparseresidency example)

Once again thank you very much for this PR. I really appreciate your fixes.
Will try to review this asap.


Unit test case

Implementation of the unit test case has not been completed.

I make unit test case and close this issue


Is there already an open topic for this issue? Don't think so
Please include the following information.

OS Version: High Sierra 10.13.5
Mac model: MBP early 2011 (Hackintosh Thinkpad T420)
Dongle or replaced card?: replaced card (60y3303)
Used dongle/card: new

Your Issue:
After CAT installation: reboot doesn't complete and enters bootloop. Wasn't able to get a log of the verbose, as boot process restarts abruptly.
Notes:

CAT installation runs smoothly, with one exception:
IOBluetoothFamily.kext backup failed. IO80211Family.kext backup failed.

Steps done to try to fix the issue:

disabling SIP
re-enabling SIP on reboot after installation
nothing changed

Edit: renamed kext correctly.

Got same issue on MacBookPro7.1(no hackintosh with gmyle bluetooth dongle) 10.13.5
I don’t know how to fix it please fix it

@iMonZ

What do you mean with this?

Edit: renamed kext correctly.

Just that I edited my post to contain the correct kext name (IO80211.kext prior to edit)

@MarekLg

Just that I edited my post to contain the correct kext name (IO80211.kext prior to edit)
and then it works?
can you maybe help me how I can do that please?
I need to edit the script right? which kext I need to edit in the script and where?
That were great when you can say that to me
Thanks. Cheers

Im sorry but that’s not the solution as I was just correcting my spelling mistake.
Again: just to show why I edited the post.
The problem still persists

Hey sorry I didn't get your last post.
Unfortunately I was running CAT on a macbook pro model, not a Hackintosh - I just ran it and it worked, so unfortunately I can't help :(

Oh no worries!
Was worth a try :)

Thinkpad X220, same model MBP Early 2011, still bootloop after patch, with macOS 10.14 DP.


[Warning:PlanBuild.Plans.PlanDB] Warning for mod developers

Seen in console on startup:
[Warning:PlanBuild.Plans.PlanDB] Warning for mod developers:
Multiple pieces with the same m_name but different resourcerequirements, this will cause issues with Player.m_knownRecipes!
Piece.m_name: $tool_cart
Requirements:$item_wood:20, $item_bronzenails:10
Pieces: Cart
Requirements:$item_bronzenails:60, $item_finewood:40
Pieces: rae_HorseCart

That can be ignored. Just a warning for mod devs (or iron gate in this case, i guess :)).


[Question] [Skywalking]When I add a new children dashboard in dolphinscheduler.yml,it  doesn't take effect after i restart the skywalking-webapp(I have emptied the browser cache and made sure the local-endpoint exists)

Search before asking

[X] I had searched in the issues and found no similar feature requirement.

Description
Search before asking
I had searched in the issues and found no similar feature requirement.
https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue+skywalking
What happened
I add a child dashboard in the ${SKYWALKING_HOME}/config/ui-initialized-templates/dolphinscheduler.yml
{
              "name":"Worker Task",
              "children":[
                {
                  "width":3,
                  "title":"AbstractTask handle Load",
                  "height":350,
                  "entityType":"Endpoint",
                  "independentSelector":true,
                  "metricType":"REGULAR_VALUE",
                  "metricName":"endpoint_cpm",
                  "queryMetricType":"readMetricsValues",
                  "chartType":"ChartLine",
                  "currentService":"dolphinscheduler::worker-server",
                  "currentEndpoint":"worker/SHELL/handle"
                }
}

Then I make sure i have the local endpoint that i want to watch

But the web ui still doesn't take effect

Additional context
No response
DolphinScheduler Version
1.3.8-release
Additional context
No response
Code of Conduct

[X] I agree to follow this project's Code of Conduct

https://github.com/apache/skywalking/discussions/7751 Successfully resolved!


Fix RHEL based Ansible installation

It is now on its own channel, not extras.

@mykaul could you please add a sign-off in your commit?
thanks!

Will add SoB line, though I was hoping that there would be a commit hook for it...


add engines to package.json

What this PR does:
Fix #50. Warn user if they install stargate-mongoose with Node < 14
Which issue(s) this PR fixes:
Fixes #
Checklist

[ ] Changes manually tested
[ ] Automated Tests added/updated
[ ] Documentation added/updated
[ ] CLA Signed: DataStax CLA

@vkarpov15
I tested this by running npm install on the netlify ecommerce sample app project with node version 13 and I see below warning message along with a bunch of other warnings.
npm WARN notsup Unsupported engine for<EMAIL_ADDRESS>wanted: {"node":">=14.0.0"} (current: {"node":"13.14.0","npm":"6.14.4"})
npm WARN notsup Not compatible with your version of node/npm<EMAIL_ADDRESS>
A couple of questions?

Should we generate package-lock.json file by running npm install and check in that as well?
I tested this with another sample NodeJS project (with node version < 14). I don't see the warning message. Here's the log. Am I missing something?

kathiresan.selvaraj@kselvaraj-rmbp16 CartsApi % node -v
v13.14.0
kathiresan.selvaraj@kselvaraj-rmbp16 CartsApi % npm install
npm WARN read-shrinkwrap This version of npm is compatible with lockfileVersion@1, but package-lock.json was generated for lockfileVersion@2. I'll try to do my best with it!

> stargate-mongoose@file:stargate-mongoose-0.2.0-ALPHA-2.tgz preinstall /Users/kathiresan.selvaraj/Documents/workspace/CartsApi/node_modules/stargate-mongoose
> node -p "'export const LIB_NAME = ' + JSON.stringify(require('./package.json').name) + ';'" > src/version.ts && node -p "'export const LIB_VERSION = ' + JSON.stringify(require('./package.json').version) + ';'" >> src/version.ts

npm WARN<EMAIL_ADDRESS>No description
npm WARN<EMAIL_ADDRESS>No repository field.

updated 63 packages and audited 63 packages in 1.893s
4 packages are looking for funding
  run `npm fund` for details
found 0 vulnerabilities
kathiresan.selvaraj@kselvaraj-rmbp16 CartsApi %

I would advise against committing and using a package-lock.json for the stargate-mongoose repo. The issue is that npm ignores individual packages' package-lock.json files, the installing project's package-lock.json takes precedence. So at best package-lock.json is useless in this repo, and at worst it may hide errors that developers doing a fresh install will see.
Can you please show me the repo you're working with? It also looks like you have a package-lock.json in that repo, my best guess is that the package-lock.json is causing you to npm install a cached version of stargate-mongoose. To confirm, try adding a console.log() in global scope somewhere in stargate-mongoose, and see if that log shows up when you run your project. To fix, you can just remove your package-lock.json.

FWIW, the netlify-functions-ecommerce example explicitly disables package-lock.json currently. That is primarily to avoid any sort of caching issues when working with local tarballs of stargate-mongoose.


vue 3 - Uncaught TypeError: Cannot set property '$cable' of undefined

I am trying to add actioncable-vue to vue 3 but I get "Uncaught TypeError: Cannot set property '$cable' of undefined"
My main.js file is something like:
`
import ActionCableVue from 'actioncable-vue';
const app = createApp(App).use(store).use(router).use(i18n);
app.use(ActionCableVue, {
debug: true,
debugLevel: 'error',
connectionUrl: 'ws://localhost:3000/challenges', // or function which returns a string with your JWT appended to your server URL as a query parameter
connectImmediately: true
});
app.mount('#app')
`

This library currently only works with Vue 2.x. I'll spend this weekend looking into adding Vue 3 support.

Seems like I can't make the library work with both Vue 2.x and Vue 3. Closing this now.

If you're having trouble getting it to work on both versions, can you please make a branch where this only works on Vue 3? I'd like to help and see if I can get it working on both @mclintprojects

@andrescastillodf Vue 3.x support has been added now thanks to #37. Kindly update to actioncable-vue v2.4.0


Add landscape badge

see #89

Coverage remained the same at 92.771% when pulling 3ce087dccc44197e0268ed4a66247c4340f13d43 on cgabard-ladscape-io into 17f46cbb7735763b30f648bb2bc79c8295485636 on master-zds.


Discovery of existing object will overwrite some elements.

Device xyz-sw1, discover from yaml.
Interface type of existing device QFX28 (100GE) changes to Other. This seems to happen on each run.  Fix the interface type, rediscover, and the type will change back to Other.
Rack, position / face delete (but not seemingly in subsequent runs).
Potentially, some extra debug levels would show information on these cases.

hey @ekrichbaum, thanks for you finding. It was a issue on agent side that was passing it hardcoded to diode-server. But keep in mind that if the Interface type does not exist in Netbox type list It will be added as other

hey @ekrichbaum, thanks for you finding. It is a issue on agent side that is passing the type hardcoded to diode-server and we will fix it.


POST method missing on route /directory/administrativeUnits/{administrativeUnit-id}/members

OpenAPI specification misses POST method on route /directory/administrativeUnits/{administrativeUnit-id}/members, despite it is documented here.
I could add member by plain http request.
The result is that proper method is not generated in Graph API client (clients?) microsoftgraph/msgraph-sdk-dotnet#1828 .

Resolved via https://github.com/microsoftgraph/msgraph-metadata/pull/368


Release 23/08

Summary

The following components were released:

<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>

What was changed:
Why it was changed:
Testing

This change was tested using:

[ ] WDIO
[ ] Jest
[ ] Visual testing (please attach a screenshot or recording)
[ ] Other (please describe below)
[ ] No tests are needed

Reviews
In addition to engineering reviews, this PR needs:

[ ] UX review
[ ] Accessibility review
[ ] Functional review

Additional Details

This PR resolves:
UXPLATFORM-XXXX

Thank you for contributing to Terra.
@cerner/terra

Can you resolve conflicts add include the latest merged components


New feature in leshan-client-demo (shortServerId customizable in CLI)

Question
I prepared simple code modification on leshan-client-demo side in which is possible set shortServerId via CLI.
This feature is very important  for one of our colleagues who performs ETS tests.
What do you think about adding such a feature to Leshan ?

I'm not sure, I feel this is a pretty specific need :thinking: .  If we add this kind of feature in that way the number of option will increase a lot. (I already think there is too much options :sweat_smile: )
If we want to add more flexibility to leshan client demo maybe we should find a way to provide custom value for any resources.
I don't know exactly how ?
maybe

an option which takes a list of key pair path/value. E.g. : --init-ressources path1=value1, path2=value2
OR it an options which takes a files which contains a kind of object tree. (but that means define a format for this tree)

But clearly this is more work.
(I don't know if this is really a priority ? :thinking:)

I'm not sure, I feel this is a pretty specific need 🤔 . If we add this kind of feature in that way the number of option will increase a lot. (I already think there is too much options 😅 )
If we want to add more flexibility to leshan client demo maybe we should find a way to provide custom value for any resources. I don't know exactly how ? maybe
* an option which takes a list of key pair path/value. E.g. : --init-ressources path1=value1, path2=value2

* OR it an options which takes a files which contains a kind of object tree. (but that means define a format for this tree)

But clearly this is more work.
(I don't know if this is really a priority ? 🤔)

I will discuss it internally with the team in this week and get back to you with an answer

Here is a proposal how we can implement this case.
https://github.com/eclipse-leshan/leshan/compare/master...JaroslawLegierski:leshan:cli_initial_resources
I've add new map called initialResources in LeshanClientDemoCLI, so now when we run client we can add path to object, whose value we want to change and it's value. This is implemented for many resources like shortServerId or resources from Device.

@mgdlkundera I looked at it and not sure this is the right way.
Maybe we can go for a more generic way, like :
For each "path" in InitResource
  objectEnabler  = client.getObjectTree().getObjectEnabler(objectId))
  objectEnabler.write(LwM2mServer.SYSTEM, new WriteRequest(path, your value)

This is not so clear pseudo code, let me know if this is not clear enough I can produce more readable code next week.

@sbernard31 I've made changes as you write but values don't update even if objects are writeable. There is another problem most of objects aren't writeable, like shortServerId, se we can't change it's values this way.

@mgdlkundera, I made some tests and

I've made changes as you write but values don't update even if objects are writeable.

I tested with BootstrapWriteRequest instead of WriteRequest and it works better.
With that code I was able to change shortServerId
final LeshanClient client = builder.build();

BootstrapWriteResponse response = client.getObjectTree().getObjectEnabler(0).write(LwM2mServer.SYSTEM,
        new BootstrapWriteRequest(new LwM2mPath(0, 0, 10), LwM2mSingleResource.newIntegerResource(0, 124l),
                ContentFormat.TEXT));
System.out.println(response);
response = client.getObjectTree().getObjectEnabler(1).write(LwM2mServer.SYSTEM, new BootstrapWriteRequest(
        new LwM2mPath(1, 0, 0), LwM2mSingleResource.newIntegerResource(0, 124l), ContentFormat.TEXT));
System.out.println(response);

There is another problem most of objects aren't writeable, like shortServerId, se we can't change it's values this way.

Using BootstrapWriteRequest we will be able to write any resource which can be changed at bootstrap. I think it's a good first step. If needed we can modify some ObjectEnabler used in Client Demo to add more support to write but not sure this is really needed.
Let me know if you think this is the right way to do.

@sbernard31
Using BootstrapWriteRequest it works better but I must do changes in write and read methods in MyDevice, MyLocation and RandomTemperatureSensor classes. Althought write was working on all of objects new value wasn't save anywere and while reading methods returned old constant values.
After changes new value is save and properly displayed.
Below is link to changes:
https://github.com/eclipse-leshan/leshan/compare/master...JaroslawLegierski:leshan:opl/cli_initial_resources_bootstrap

Do you think this is good enough way to go ?

I must do changes in write and read methods in MyDevice, MyLocation and RandomTemperatureSensor classes

Should we limit this to writable object  at bootstrap (e.g. Security, Server, OSCORE ...)  and we call the option factory bootstrap ? (and we will see later if someone need more, this will be easy to modify)

@sbernard31
I rolled back changes related to MyDevice, MyLocation and RandomTemperatureSensor classes. Is this solution good now?
https://github.com/eclipse-leshan/leshan/compare/master...JaroslawLegierski:leshan:opl/cli_initial_resources_bootstrap

Hard to get your opinion about this idea :sweat_smile:.

Is this solution good now?

I feel this is not so bad. If you agree with that way to go you can open a PR, then I could review/comment the code.
(I see some little part which should be improved)

I think this is a good way to go. I open PR for this issue:
https://github.com/eclipse-leshan/leshan/pull/1512

This is now integrated in master and will be available in 2.0.0-M14.
Thx all for you contribution.

Thank you too


Implement automated tests for DDEV Quickstart docs

It's really hard to keep all the Quickstarts properly updated as the upstream projects change.
Describe your solution
Implement either

Automated tests for the quickstarts (include them into the docs as scripts?) or
Create parallel automated tests that are intended to match each quickstart, and then carefully maintain them.

Describe alternatives
No response
Additional context
No response

👏👏 Will be awesome!
My two cents:
Personally I would argue against docs integration, because this can get messy fast with different versions + the quickstart docs currently are not focused on no-interaction / non-interactive install (which would be needed for automated testing).
I'm not a technical expert on setting up such tests, but I could imagine that we could put 1 cms in 1 test file and delete/clean between cms versions - if this is meant to be executed with ddev/github-action-setup-ddev@v1?
Happy to help/contribute!

I agree that docs integration will probably be too hard. I'm thinking we could have a single golang test (or bats, or ...) for each quickstart, and just maintain them in parallel with the quickstarts, so by process a change to the quickstart requires an update to the test.


precompile train step

Oh is it the same as this change https://github.com/google/maxdiffusion/pull/44/files?

Oh is it the same as this change https://github.com/google/maxdiffusion/pull/44/files?

Ah it looks like @suexu1025 implemented this also on her branch. We can discuss which one we want to use.


Could not find project - on every project after 24h

Describe the bug

All my projects can't be found anymore when I return to work with bolt the next day. When I start a new project, i an work on it with no problem but get the same error "could not find project" when i want to go on working on the project on the next day. Happens to all my projects, not bound to any size or browser. Also the "close" Button on that alert doesn't work by the way.
Link to the Bolt URL that caused the error
https://bolt.new/~/sb1-u2aupu
Steps to reproduce

work on a project
come back to your project the next day
get the error on all projects

Expected behavior
When i want to continue my project it would be nice to have at least the possibility to make changes and then deploy it instead of getting stuck at the error
Screen Recording / Screenshot
No response
Platform
Browser name = Chrome
Full version = <IP_ADDRESS>
Major version = 130
navigator.appName = Netscape
navigator.userAgent = Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/<IP_ADDRESS> Safari/537.36
performance.memory = {
  "totalJSHeapSize": 69228203,
  "usedJSHeapSize": 59376259,
  "jsHeapSizeLimit":<PHONE_NUMBER>
}
Username = Timo1002
Chat ID = 11e18b7b7db6

Additional context
No response

Hi @Timo1002,
Are you able to find your past Bolt projects by navigating to stackblitz.com, logging in (same credentials as Bolt), opening Collections on the left-hand side of the page, and then opening Bolt Collection?

hi @endocytosis,
i can find the projects under collections and can also open them in bolt but the preview and deploy still get the same error.

Hi @Timo1002,
Are you able to able to set your project permission to "Private (accessible by URL)" so we can take a closer look? The blank preview is a known issue that is being tracked here: #1791. Regarding that, you can try typing “npm run dev” in the Bolt console to see if that resolves the issue. Also, selectively disable browser extensions, especially ad blockers, to see if that resolves the issue.
If your project has private URL access we can see if there is anything else going on. Thanks!


docs(API): Renamed Ionic 2 to just Ionic

Renamed Ionic 2 to Ionic

Similarly to the storage docs, this is generated from src, and would need to be changed here
https://github.com/driftyco/ionic/blob/master/scripts/docs/templates/api_index.template.html


Improve code coverage for uiconv package

Signed-off-by: Ashmita Bohara<EMAIL_ADDRESS>
Which problem is this PR solving?
Increase code coverage for uiconv package
Short description of the changes
Added coverage for two missing if conditions.

Thank you @yurishkuro I was also wondering why we were doing that. I have updated the PR removing those.

Codecov Report

Merging #3 (4628dbb) into fix-2556 (784b9d0) will increase coverage by 0.04%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##           fix-2556       #3      +/-   ##
============================================
+ Coverage     95.04%   95.08%   +0.04%
============================================
  Files           213      213
  Lines          9496     9492       -4
============================================
  Hits           9025     9025
+ Misses          392      390       -2
+ Partials         79       77       -2

Impacted Files
Coverage Δ

cmd/anonymizer/app/uiconv/reader.go
100.00% <ø> (+10.00%)
:arrow_up:

cmd/query/app/server.go
88.52% <0.00%> (-1.64%)
:arrow_down:

cmd/query/app/static_handler.go
84.82% <0.00%> (+1.78%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 784b9d0...4628dbb. Read the comment docs.


App Doesn't Show the Tweet That was Replied To

Steps to Reproduce:

Find a reply that appears in your feed.
Tap on it.
You'll see the tweet (the reply) you opened but not the tweet that was replied to, thus causing a loss of context.

Screenshots:
Here's a reply that showed up in my Group feed:

After I tapped on it:

App Version: 2.3.0

The missing link between the tweet/thread and the reply is indeed the feature I'm missing the most. I kind of like the style of twitter:
tweet 1
|
tweet 2
|
tweet 3
|
Reply I clicked on
|
All other replies to the original tweet/thread
Second post for me on github, sorry if I disregard some kind of etiquette. And nice work on Fritter, I love it, thanks!

Even a link to the parent tweet without explicitly loading it would be enough. Currently tapping on the replying to button takes to the profile page

Yes, simply being able to view the parent tweet – the same way you can view replies now – would be sufficient.

Sorry for the long wait on this one - it should be implemented and will go out in v2.11.0!


Bug report: 2 follow system themes

Expected behavior: What did you expect to happen when performing these steps?
There should be only one Follow system theme option
Observed behavior: What actually happened and why is it a problem? If applicable, consider adding screenshots to help explain.
Currently there are 2 follow system themes. If a the follows system, it should be accordingly, it doesn't need 2 options.
Device information: Include your device operating system and version.
Zenfone 6, Android 11

Closing as duplicate of issue #98.


fix: add missing icons to supported platforms

Before:

After:

This is looking great, thanks for the additions! 🙏
One small request - can we also move the visionOS before, watchOS, Web and Windows so the alphabetical order of platforms is retained?

One small request - can we also move the visionOS before, watchOS, Web and Windows so the alphabetical order of platforms is retained?

Done ✅

nit: Windows icon is not correct, we should be using this instead: https://fontawesome.com/icons/microsoft?f=brands&s=solid

nit: Windows icon is not correct, we should be using this instead: https://fontawesome.com/icons/microsoft?f=brands&s=solid

ah, right. https://github.com/facebook/react-native-website/pull/4135


Isomorphic-fetch Typescript setup

After installing the types and isomorphic-fetch from npm, I get the following error in Typescript:
TS2349:  (TS) This expression is not callable.
  Type '{ default: (input: RequestInfo, init?: RequestInit | undefined) => Promise<Response>; }' has no call signatures.

In my Saga, I simply call fetch normally:
yield fetch(someInterpolatedApiCall);
Forgive me, I've read as much as I can without giving myself an aneurysm - I'm having difficulty understanding what the fix normally is for Typescript. I import the lib using "import * as fetch from 'isomorphic-fetch'". As far as I can tell, the error may be valid because of default-importing, but I don't know what I need to do to satisfy TS. The call does work, but I'm trying to remove the persistent error.

Gave it a shot - I've abandoned using isomorphic-fetch for the time being

What do you use instead?


discussion: needed labels

What labels are you missing? Which ones do we need and which colors would you recommend?
@materializecss/members

Maybe we can "create" 3 types of labels : type, status and priority
I would propose:
Type labels

Type: Bug (color #f44336)
Type: Enhancement (color #2196f3)
Type: Question (color #9c27b0)

Status labels

Status: Pending (color #607d8b)
Status: In progress (color #009688)
Status: Blocked (color #ff5722)
Status: Review needed (color #ffc107)
Status: Completed (color #4caf50)
Status: Abandoned (color #212121)

Priority labels

Priority: Low (color #4caf50)
Priority: Medium (color #ffeb3b)
Priority: High (color #ff5722)
Priority: Critical (color #f44336)

in general: this is a bit too verbose and status is covered by the project status (in progress, ..., done).
Type should be covered by issue templates, title and the existing labels.
Not sure about priority, we have to check what each priority means then to see if this would be helpful. For this we can also use a project board maybe like we do for webpack.
I thought about labels per component, code type (js, scss), scope (doc, build, test, feature, fix, ...), similar to several commit rules. So we and users can easily filter by these and find relevant issues and PRs. This is more user-focused than some priority or status label as from my experience they will still ask when things will get fixed and released (assign milestones).

In general: this is a bit too verbose and status is covered by the assigned project status board (in progress, ..., done).
Type should be covered by issue templates, title and the existing labels.
Not sure about priority, we have to check what each priority means then to see if this would be helpful. For this we can also use a project board maybe like we do for webpack.
I thought about labels per component, code type (js, scss), scope (doc, build, test, feature, fix, ...), similar to several commit rules. So we and users can easily filter by these and find relevant issues and PRs. This is more user-focused than some priority or status label as from my experience they will still ask when things will get fixed and released (assign milestones).

I like the idea of labels per component, code type and scope.
As for the status, yes it is covered by the assigned project status board (maybe we should define some more or different status there) but when you are consulting the issue, I find it difficult in one look to see it's status. That's why I proposed a status label.
Same for issue's prioritization. While you can prioritize issues in the project board, I find it helpful to have a prioritization label. It improves readability (as many people will not consult the project board at all).

I think we need labels by component so we can filter by them when we work on a component.
What do you think @materializecss/members?

So each component gets its own coloured label?

So each component gets its own coloured label?

Probably the same color (some grey?) for components.

My two cents would be that labels by component would help for sure.

Agreed, sounds like it would be very useful!

Agreed, especially for grey for every component 👍

I have created a few labels for existing issues and PRs. Feel free to recommend more in the relevant issues and PRs.
Users with write access (currently @Smankusors) should be able to create new ones.


Unhandled exception when fast scroll map very far away

Fast scrolling map really far sometimes cause following unhandled exception:
"type '(HttpException) => Null' is not a subtype of type '(dynamic) => dynamic'"
Call stack:
Response.fromStream (e:\Projects\_Flutter\.pub-cache\hosted\pub.dartlang.org\http-0.12.0+4\lib\src\response.dart:64)
<asynchronous gap> (Unknown Source:0)
BaseClient._sendUnstreamed (e:\Projects\_Flutter\.pub-cache\hosted\pub.dartlang.org\http-0.12.0+4\lib\src\base_client.dart:176)
<asynchronous gap> (Unknown Source:0)
BaseClient.get (e:\Projects\_Flutter\.pub-cache\hosted\pub.dartlang.org\http-0.12.0+4\lib\src\base_client.dart:35)
get.<anonymous closure> (e:\Projects\_Flutter\.pub-cache\hosted\pub.dartlang.org\http-0.12.0+4\lib\http.dart:46)
_Closure.call (dart:core-patch/function.dart:0)
_withClient (e:\Projects\_Flutter\.pub-cache\hosted\pub.dartlang.org\http-0.12.0+4\lib\http.dart:166)
get (e:\Projects\_Flutter\.pub-cache\hosted\pub.dartlang.org\http-0.12.0+4\lib\http.dart:46)
WebHelper._defaultHttpGetter (e:\Projects\_Flutter\.pub-cache\hosted\pub.dartlang.org\flutter_cache_manager-1.1.3\lib\src\web_helper.dart:86)
WebHelper._defaultHttpGetter (e:\Projects\_Flutter\.pub-cache\hosted\pub.dartlang.org\flutter_cache_manager-1.1.3\lib\src\web_helper.dart:0)
_Closure.call (dart:core-patch/function.dart:0)
WebHelper._fileFetcher (e:\Projects\_Flutter\.pub-cache\hosted\pub.dartlang.org\flutter_cache_manager-1.1.3\lib\src\web_helper.dart:0)
WebHelper._downloadRemoteFile (e:\Projects\_Flutter\.pub-cache\hosted\pub.dartlang.org\flutter_cache_manager-1.1.3\lib\src\web_helper.dart:69)
<asynchronous gap> (Unknown Source:0)
WebHelper.downloadFile.<anonymous closure> (e:\Projects\_Flutter\.pub-cache\hosted\pub.dartlang.org\flutter_cache_manager-1.1.3\lib\src\web_helper.dart:36)
_Closure.call (dart:core-patch/function.dart:0)
WebHelper.downloadFile (e:\Projects\_Flutter\.pub-cache\hosted\pub.dartlang.org\flutter_cache_manager-1.1.3\lib\src\web_helper.dart:43)
BaseCacheManager.getSingleFile (e:\Projects\_Flutter\.pub-cache\hosted\pub.dartlang.org\flutter_cache_manager-1.1.3\lib\src\cache_manager.dart:96)
<asynchronous gap> (Unknown Source:0)
CachedNetworkImageProvider._loadAsync (e:\Projects\_Flutter\.pub-cache\hosted\pub.dartlang.org\cached_network_image-2.0.0\lib\src\cached_network_image_provider.dart:59)
CachedNetworkImageProvider.load (e:\Projects\_Flutter\.pub-cache\hosted\pub.dartlang.org\cached_network_image-2.0.0\lib\src\cached_network_image_provider.dart:45)
ImageProvider.resolve.<anonymous closure>.<anonymous closure>.<anonymous closure> (e:\Projects\_Flutter\packages\flutter\lib\src\painting\image_provider.dart:327)
_Closure.call (dart:core-patch/function.dart:0)
ImageCache.putIfAbsent (e:\Projects\_Flutter\packages\flutter\lib\src\painting\image_cache.dart:160)
ImageProvider.resolve.<anonymous closure>.<anonymous closure> (e:\Projects\_Flutter\packages\flutter\lib\src\painting\image_provider.dart:325)
_Closure.call (dart:core-patch/function.dart:0)
SynchronousFuture.then (e:\Projects\_Flutter\packages\flutter\lib\src\foundation\synchronous_future.dart:38)
ImageProvider.resolve.<anonymous closure> (e:\Projects\_Flutter\packages\flutter\lib\src\painting\image_provider.dart:323)
_rootRun (dart:async/zone.dart:1126)
_rootRun (dart:async/zone.dart:0)
_CustomZone.run (dart:async/zone.dart:1023)
_CustomZone.runGuarded (dart:async/zone.dart:925)
ImageProvider.resolve (e:\Projects\_Flutter\packages\flutter\lib\src\painting\image_provider.dart:315)
new Tile (e:\Projects\_Flutter\.pub-cache\hosted\pub.dartlang.org\flutter_map-0.9.0\lib\src\layer\tile_layer.dart:933)
_TileLayerState._addTile (e:\Projects\_Flutter\.pub-cache\hosted\pub.dartlang.org\flutter_map-0.9.0\lib\src\layer\tile_layer.dart:808)
_TileLayerState._update (e:\Projects\_Flutter\.pub-cache\hosted\pub.dartlang.org\flutter_map-0.9.0\lib\src\layer\tile_layer.dart:762)
_TileLayerState._update (e:\Projects\_Flutter\.pub-cache\hosted\pub.dartlang.org\flutter_map-0.9.0\lib\src\layer\tile_layer.dart:0)
_rootRunUnary (dart:async/zone.dart:1134)
_rootRunUnary (dart:async/zone.dart:0)

flutter_map 0.9.0

Does the app crash?
I think this exception is handled since error is just printed:
"type '(HttpException) => Null' is not a subtype of type '(dynamic) => dynamic'"
Maybe your IDE is configured to stop at All Dart excpetion (not at Uncaught Exception).
I see the ImageProvider.resolve on stackTrace which is guarded with extra care (maybe this call shouldn't happen in the constructor :open_mouth: but his isn't a problem)
What is your configured minZoom / maxZoom on MapOptions?

Does the app crash?

Nope, app still working, but tiles wont display or load after that exception.

Maybe your IDE is configured to stop at All Dart excpetion

My IDE is configured to stop only on Uncaught exceptions.

What is your configured minZoom / maxZoom on MapOptions?
default values

We cannot fix this at this level we attached an onError listener and wrapped the whole thing with try catch however this is too deep in flutter itself where Response.fromStream didn't propogate up the exception to our onError listener.
CachedNetworkImageProvider._loadAsync from this point try{} catch{} cannot do anything because next method calls will run on other event loops.
You may create a new issue to flutter team like this.
I think the problem is your phone opens too many connections because you scroll through the entire map. There is a updateInterval settings in TileLayerOptions which may help if you increase it because now it search after new Tiles to download at every 200ms while scrolling. If this is the problem then _abortLoading() should handle it and ask TileProvider to drop connections if a Tile is still in loading phase and when dispose is called, however there no way to ask CachedNetworkImageProvider / NetworkImage to abort downloading this may be the second issue to flutter team :smiley:.

Nope, app still working, but tiles wont display or load after that exception.

Error tile images are also cached by NetworkImage / CachedNetworkImageProvider so there is no way to redownload error tiles, #577 tries to eliminate this, see #576 for more info.


Add MYSQL, MariaDB and Mongo DB support

This is needed when you want to use this panel when you are bigger hosting.
Right now with SQLite you cannot backup the database remotely.
And you cannot integrate other app which are not supporting api

I'll think about making it. I don't know how MongoDB works, but I'll definitely try to add MySQL support.

I'm probably not going to do this, because Dashactyl 1.0 uses MySQL. I'll keep this for the side for now.

Dashactyl is using MySQL / MariaDB ?


public async Task Put(DeviceInstallation deviceUpdate)

The documentation (https://docs.microsoft.com/en-us/azure/notification-hubs/notification-hubs-push-notification-registration-management) for the "Put" calls does not specify where the values held in DeviceInstallation come from for iOS. I have been able to guess for FCM, but can't get this working for iOS. Also, there is not such class PushNotificationChannelManager outside of UWP. Also, I got "installation" type registration working for FCM without using non-existent class PushNotificationChannelManager.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 1fe12c8b-5f7b-be6f-9db0-1009a27ceef8
Version Independent ID: 5bb28d30-3240-7354-9f58-e9e51da7f3ae
Content: Registration Management
Content Source: articles/notification-hubs/notification-hubs-push-notification-registration-management.md
Service: notification-hubs
GitHub Login: @jwargo
Microsoft Alias: jowargo

Thanks for the feedback! We are currently investigating and will update you shortly.

I found a fix for this. Take the iOS device token (received via RegisteredForRemoteNotifications) and strip spaces and angle brackets (send to your server) and use it as the PushChannel. You can also use it for the InstallationId, or you can create a GUID.
And delete anything related to PushNotificationChannelManager, that class is not needed.

Awesome that you were able to find a solution @GerryOnGithub. Appreciate the feedback as well.
I have assigned the issue to the content author to take your feedback into consideration.

@GerryOnGithub thanks, we'll take a look at making this more clear.

I found a fix for this. Take the iOS device token (received via RegisteredForRemoteNotifications) and strip spaces and angle brackets (send to your server) and use it as the PushChannel. You can also use it for the InstallationId, or you can create a GUID.
Delete anything in the docs related to PushNotificationChannelManager, that class is not needed.
I am performing tag "Installation" on my server and receiving notifications on both my Android and iOS devices now.

I want to implement installation in React Native code, how would I create SASToken??

@MayurBar in the Azure Portal - it's the Access Policies.

We updated the docs for this last week, #please-close


Add paragraph sequence field

To support a downstream feature in the USGS project, we need to add a field in Weaviate to indicate paragraph order within a document. The required changes are:

Redefine the Weaviate schema.
Update the preprocessor to include paragraph_order.
Update the ingest pipeline.
Rebuild Weaviate (if necessary).

Assuming the raw text remains unchanged, we can likely skip re-embedding by using the old embeddings with paragraph_hash. this should be safe and efficient.

Additional step 0: Clear space by dropping Passage class (plus clean up other junk on that machine) and backup existing collection. Backup started as of 2024-07-29 10:45.
To support a downstream feature in the USGS project
Is there an issue outlining this that we could link to here?
On Mon, Jul 29, 2024 at 10:32 AM, Jason Lo<EMAIL_ADDRESS>wrote:
Discussed the update should be as follow:
Steps:

Gather a master list of docid.
Subset docid from Geoarchive, CriticalMASS.
For each docid, call preprocessorv2 (v1 + paragraph ordering).
Compare hashed_text for each paragraph. If unchanged, retrieve embedding data from existing Weaviate.
If changed, drop paragraphs with the same docid and reprocess everything in it.

—
Reply to this email directly, view it on GitHubhttps://urldefense.com/v3/__https://github.com/UW-Madison-DSI/ask-xDD/issues/118*issuecomment-2256251219__;Iw!!Mak6IKo!PL9rapn_OyN8f9_T1HYbHS4_UD2ujRmQ93dVOZMvNpTS-qZmzXmec58buNezGInKYgr7OXbgO06k1k8XnfMBX1mx$, or unsubscribehttps://urldefense.com/v3/__https://github.com/notifications/unsubscribe-auth/AALAW7KBE4NKLWS5Y3AGTNDZOZOBPAVCNFSM6AAAAABLO3LRX6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENJWGI2TCMRRHE__;!!Mak6IKo!PL9rapn_OyN8f9_T1HYbHS4_UD2ujRmQ93dVOZMvNpTS-qZmzXmec58buNezGInKYgr7OXbgO06k1k8XnSCKNJuZ$.
You are receiving this because you are subscribed to this thread.Message ID: @.***>

https://github.com/UW-xDD/text2graph_llm/issues/20

@ilmcconnell , @iross
Started the patch for paragraph order, but it's slower than expected due to the lack of a batch update function. Estimated completion time: 4-5 days. Will check progress on 8/7.

#119
The patch has been completed ahead of schedule.


Adding my name

This PR added my name to the AltSchool Student List

Please I am sorry for all the trouble we have caused you but count it all joy. Your PR is about to be merged and you will be able to see your name on this url.
To enable me to do this, READ the README again carefully, update your code with the latest and push the update. I am here for you for the next 6 hours before I close the PR so you can initiate a fresh PR which will be easier to merge.


feat: add isEditable to the condition on bubble menu

https://tiptap.dev/api/extensions/bubble-menu
The default behavior of the bubble menu seems to hide it when 'editable' is falsy.
However, in the current implementation, it appears to be overridden by shouldShow.
I have modified it within the PR to also consider editor.isEditable.
https://github.com/steven-tey/novel/issues/153
https://github.com/steven-tey/novel/assets/38897355/ddddd26b-bc12-4ac9-9c82-29877cdfbf8a

This one is the sole reason why I had to create a custom renderer. If we can make this work, then we can render the editor where we are only supposed to show the content.

please merge this PR, this is a much needed feature

0.2.0-canary.0 With the new packages you can just hide the bubble menu from the component tree.
https://novel.sh/docs/quickstart#anatomy


Swiper Element not rendering with Vue 3

Check that this is really a bug

[X] I confirm

Reproduction link
https://pastebin.com/kVmqjFfp
Bug description
I am writing a Vue 3 application with Ionic. I am trying to replicate this demo, but the swiper component is not rendering. From my understanding, Swiper Element should be used over Swiper Vue going forward. However, I think my Vue project is not playing nice with this new approach.
I've included:
import { register } from "swiper/element/bundle"; register();
which I assume should have registered the swiper-container and swiper-slide components with Vue. However, I am getting the following warnings in console.
[Vue warn]: Failed to resolve component: swiper-slide
[Vue warn]: Failed to resolve component: swiper-container
I assume this is related to my problem, but I could be wrong.
Expected Behavior
A swiper vertical component is rendered.
Actual Behavior
The swiper vertical component is not rendering.
Swiper version
8.19.3
Platform/Target and Browser Versions
Chrome
Validations

[X] Follow our Code of Conduct
[X] Read the docs.
[X] Check that there isn't already an issue that request the same feature to avoid creating a duplicate.
[X] Make sure this is a Swiper issue and not a framework-specific issue

Would you like to open a PR for this bug?

[ ] I'm willing to open a PR

Do you want to ask a question? Are you looking for support? Stack Overflow or Swiper Discussions is the best places for getting support

Please, don't use GitHub issues for questions


Make the middleware compatible with nREPL 0.4.x+

As nREPL 0.4 uses a different namespace than 0.2.x and 0.3.x you'll have to do some trivial changes to support them both. Something along the lines of what is done here https://github.com/nrepl/piggieback/pull/92/files

@bbatsov thanks for the tip


Generic SPARQL endpoint driver

A generic SPARQL endpoint jdbc driver would be a nice addition to DBeaver.
Jena is one such implementation:

https://jena.apache.org/documentation/jdbc/
http://events17.linuxfoundation.org/sites/events/files/slides/Introducing JDBC for SPARQL.pdf

Some alternatives to jena referenced in the links above.
Also of interest - existing Virtuoso driver.

@gregid
Thank you for the good idea

I use DBeaver on daily basis, and start to explore a GUI for SPARQL. I would love it if DBeaver supports it.


The demo is not working

Expected behavior:
Login Successful
Actual behavior:
Login failed with a message saying website is offline
Steps to reproduce:
Try to login with any user
Screenshots (if applicable):
OS and Browser:
Any

We know. I’m working on it.
Typed or dictated imperfectly on my iPhone<PHONE_NUMBER>)

On May 30, 2018, at 5:51 PM, aalmangour<EMAIL_ADDRESS>wrote:
Expected behavior:
Login Successful
Actual behavior:
Login failed with a message saying website is offline
Steps to reproduce:
Try to login with any user
Screenshots (if applicable):
OS and Browser:
Any
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

Closed for #1470


Improve: TextInt

TextInt.Numerals should be public.
TextInt and TextInt.Numerals initializers should accept some BinaryInteger.
TextInt and TextInt.Numerals need a dynamic TextInt.Letters transformation.
TextInt and TextInt.Numerals should use TextInt.Letters.lowercase by default.
TextInt.Letters need an init(uppercase: Bool) constructor.
TextInt.Error.overflow should really be TextInt.Error.lossy or some such.
The preferred radix input is UX and the preferred radix output is U8 (validation reasons).
Integer literals should use the preferred radix input type, so there must be two initializers.

init(radix:letters:) should also have a default radix of 10 for convenience.

I might as well make the TextInt/numerals field public too, now that TextInt.Numerals is public.


BUG: edit page in CMS in splitmode, then archive it versioned.mode remains archived

Affected Version
SS3.6
Description
Versioned mode stays on (e.g. DataObject::get_one('Page') results in Select * from SiteTree_versions rather than SiteTree_Live) while you are logged in and while you are in split mode in a tab.  This results in the site doing crazy stuff, because you browse the site in a "previous version" mode.
Content editor will panic, because all pages will be outdated and may not work (e.g. pages without versions - i.e. we delete all versions older than year ... so all of a sudden page are missing (the ones that have not been edited for more than a year ).
Steps to Reproduce

edit page in split mode
archive it
browse the site in a seperate tab while keeping the "archiving tab && split mode tab" open

Note
This may seem far fetched, but it is actually pretty common (i.e. we often delete pages and we often preview site in a separate tab).

Have you tried 3.7.0 with session-based stage selection disabled? https://docs.silverstripe.org/en/3/changelogs/3.7.0/#disable-session-based-stage-setting
If that new API doesn’t solve things for you, I think you may be out of luck. Changes to things like staging modes have a high risk of regression, and 3.x is only receiving security fixes now anyway

Thank you for looking into this. We will leave it for now.

If it's not a problem in v4 we should either close it as fixed in 4 or wontfix in 3

Closing as this is non-security SS3 issue.


Style/GuardClause triggered for complex elsif conditions

The most recent version of RuboCop as well as current git master trigger this GuardClause errors for my if/elsif/else branches. Example file:
def process_file file
  if file.video?
    puts file.video_info
  elsif file.image?
    puts file.image_info
  else
    raise "unsupported file type"
  end

  puts file.general_info
end

Output:
asd.rb:4:3: C: Use a guard clause instead of wrapping the code inside a conditional expression.
  elsif file.image?
  ^^^^^

I think it doesn't make sense. The guard condition would have to be very complex, the more complex the more elsif clauses there are. Below is – in my opinion – worse code that Rubocop likes:
def process_file file
  raise "unsupported file type" unless file.video? || file.image?

  if file.video?
    puts file.video_info
  elsif file.image?
    puts file.image_info
  end

  puts file.general_info
end

If this looks OK to you then consider the same example, but with 5 elsif checks.

Using case will pass the cop:
def process_file file
  case
  when file.video?
    puts file.video_info
  when file.image?
    puts file.image_info
  else
    raise "unsupported file type"
  end

  puts file.general_info
end

Using case will pass the cop:

That's true, but is the behavior of this cop desirable as re: elsif?

No, I think @amw 's original example is preferable when using elsif

This cop already has a clause which catches elsifs, but it does it wrongly.


Human performance regression testing

http://dl.acm.org/citation.cfm?id=2486809

To:
<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>Subject:
Data used in paper: Human Performance Regression Testing
Body:
To whom it may concern,
We noticed that the link to the data used in the paper (http://www.cse.unl.edu/∼myra/artifacts/HPRT-2013/) is broken. Could you direct us to the proper link or somehow send us a copy of the data so we can add it to our repository?
Thanks


Ibl suggestions

Here are some suggestions for the image based lighting PR. Feel free to cherry pick what you like or merge this into #323 if you like all of it.

Thanks so much for putting this together! I've broadly incorporated these changes in #314 !


TST: add appveyor.yml

Hello,
I put together a appveyor.yml if you would like to use it.
This built successfully for me here:
https://ci.appveyor.com/project/thequackdaddy/blaze
A few caveats:

mysql doesn't seem to work well on win32. I think the problem has something to do with loading data. (in most documentations that I've seen, mysql on win32 uses pathnames like C:\mydir\myfile.csv while I think the way the test suite and odo work is that they send pathnames like C:\\mydir\\myfile.csv. So I've skipped all those tests.
mongodb fails a handful of tests. I've xfailed them in this version for now.

Here's a sample mongo fail...
bank = Collection(Database(MongoClient('localhost', 27017), 'test_db'), 'bank')
    def test_summary_arith_max(bank):
        expr = by(t.name, add_one_and_sum=(t.amount + 1).max())
        result = compute(expr, bank)
>       assert result == [('Bob', 301), ('Alice', 201)]
E       assert [('Alice', 201), ('Bob', 301)] == [('Bob', 301), ('Alice', 201)]
E         At index 0 diff: ('Alice', 201) != ('Bob', 301)
E         Full diff:
E         - [('Alice', 201), ('Bob', 301)]
E         + [('Bob', 301), ('Alice', 201)]

A more detailed fail is available here:
https://ci.appveyor.com/project/thequackdaddy/blaze/build/1.0.5
Ultimately (in a separate PR) I'd like to get mssql testing added which is why I'm submitting this.
Thanks!

Could you push another commit so that the project starts building on AppVeyor?

Could you push another commit so that the project starts building on AppVeyor?

Coverage remained the same at 87.209% when pulling 1ffe4dea9b3347cbea91a257d20ca405c9a97c8e on thequackdaddy:appveyor into 88573387c6dab483f682c01b6bec1b5ba989de1d on blaze:master.

Coverage remained the same at 87.209% when pulling 1ffe4dea9b3347cbea91a257d20ca405c9a97c8e on thequackdaddy:appveyor into 88573387c6dab483f682c01b6bec1b5ba989de1d on blaze:master.

Coverage remained the same at 87.209% when pulling 1ffe4dea9b3347cbea91a257d20ca405c9a97c8e on thequackdaddy:appveyor into 88573387c6dab483f682c01b6bec1b5ba989de1d on blaze:master.

Coverage remained the same at 87.209% when pulling 1ffe4dea9b3347cbea91a257d20ca405c9a97c8e on thequackdaddy:appveyor into 88573387c6dab483f682c01b6bec1b5ba989de1d on blaze:master.

@necaris re-pushed. all green, with the caveats above.

@necaris re-pushed. all green, with the caveats above.

Thanks @thequackdaddy ! I'm happy to merge this as an overall improvement and a prelude to further work -- thoughts @llllllllll ?

Amazing! Thanks for adding this!

Made the change you requested.
Looks like dask 0.13 (released today) broke some things.
@mrocklin do you have any ideas ?

The [ci] dependencies should be frozen so that we can update this when needed.

Closing to cleanup old PRs. Feel free to submit a new PR.


Custom attribute not used

https://github.com/github/github-team-sync/blob/2f317527b753c0a98210f0adfcd3f4cb14b0b9d1/githubapp/okta.py#L66
The hardcoded value github_username is used instead of the custom attribute USERNAME_ATTRIBUTE. This line should be "username": getattr(user.profile, self.USERNAME_ATTRIBUTE),

Hi @primetheus, I'm Rishabh from India, Can we contribute in this issue ?

@anonymousr007 yes, pull requests to this are open and encouraged. This seems like a simple fix, but I need to fix my Okta account before I can implement a fix myself


README.md: Update API_LEVEL branches

Description
README.md: Update API_LEVEL branches
Changes include

[ ] Bugfix (non-breaking change that solves an issue)
[ ] New feature (non-breaking change that adds functionality)
[ ] Breaking change (change that is not backwards-compatible and/or changes current functionality)
[ ] Tests
[x] Documentation
[ ] Other (for changes that might not fit in any category)

Codecov Report
All modified lines are covered by tests :white_check_mark:

Comparison is base (5402367) 69.33% compared to head (921fda5) 69.33%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #448   +/-   ##
=======================================
  Coverage   69.33%   69.33%
=======================================
  Files          11       11
  Lines         874      874
=======================================
  Hits          606      606
  Misses        268      268

Flag
Coverage Δ

unittests
69.33% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


+smartparens breaks scala-mode scaladoc indentation

First of all, thanks for doom-emacs - I'm really enjoying it as a long time emacs user.
I'm running into a small minor snag with scala-mode.
When +smartparens is in my ~/.doom.d/init.el, scaladoc indentation doesn't seem to work properly. E.g. when I try to do a multiline doc, it does this:
/** MyClass
/** <broken>
class MyClass {

When it should do
/** MyClass
  * next line
  */
class MyClass {

This seems to be caused by https://github.com/hlissner/doom-emacs/blob/81cf6080bf800e74be5b218b71e1cdf90c222c04/modules/config/default/config.el#L141
Which causes the indent to duplicate the prior /** incorrectly.
For now I've disabled it completely by adding to my .doom.d/config.el:
;; Disable smartparens comment continuation behaviour
(after! smartparens
  (advice-remove #'newline-and-indent #'+default*newline-indent-and-continue-comments))

I wonder if there is a better way though? Is there a benefit to this has over just letting the major mode do its work? It doesn't seem related to smartparens either. Thanks!

+default*newline-indent-and-continue-comments marries newline-and-indent and comment-indent-and-newline, which leaves it up to the major mode to best decide how to continue and indent comments. It consults comment-line-break-function under the assumption that the major mode has set one and, if it has, it does it's job correctly.
For the majority of C-style languages (that are derived from the cc-mode family) this is the case, but scala-mode does not define a comment-line-break-function, so it falls back to the generic comment-indent-new-line function, which produces the undesirable behavior you're seeing.
Therefore, we either need a better comment-line-break-function or make do with standard newline-and-indent behavior, which produces this:
/**
  next line
 */

Which we want
/**
 * next line
 */

So, here's my quick stab at a solution. Please try inserting the following into your ~/.doom.d/config.el and let me know if it resolves your issue:
(defun +scala-comment-indent-new-line (&rest _)
  "TODO"
  (let* ((state (syntax-ppss))
         (comment-start-pos (nth 8 state))
         prev-line)
    (save-match-data
      (cond ((and (integerp (nth 4 state))
                  ;; Ensure that we're inside a scaladoc comment
                  (string-match-p "^/\\*\\*?[^\\*]?"
                                  (buffer-substring-no-properties
                                   comment-start-pos
                                   (min (+ comment-start-pos 4)
                                        (point-max))))
                  (progn
                    (setq prev-line (buffer-substring-no-properties
                                     (line-beginning-position 0)
                                     (line-end-position 0)))
                    (or (string-match "^\\s-*\\*" prev-line)
                        (string-match "\\s-*/*" prev-line))))
             (newline)
             (indent-according-to-mode)
             (insert (make-string (max 0 (- (1- (match-end 0))
                                            (match-beginning 0)))
                                  ? )
                     "*")
             (scala-indent:indent-on-scaladoc-asterisk))
            ((sp-point-in-comment)
             (call-interactively #'comment-indent-new-line))))))

(setq-hook! 'scala-mode-hook comment-line-break-function #'+scala-comment-indent-new-line)

I'm not sure if this is something that should be merged upstream. Probably so, but it'd have to be generalized. This solution depends too much on smartparens.

Yes, that works great! Although I had to change it to (setq scala-indent:use-javadoc-style nil) to get scaladoc style.
I also tried something like:
(setq-hook! 'scala-mode-hook comment-line-break-function #'(lambda (&rest _)
                                                              (progn
                                                                (newline)
                                                                (scala-indent:insert-asterisk-on-multiline-comment))))

But it doesn't handle // then. I'm guessing this is close to how we could generalize it in scala-mode itself.

But with scala-indent:use-javadoc-style set to nil, it indents like so:
/**
  *
  */

Rather than
/**
 *
 */

Is that what you wanted?

I've merged the above suggestion (plus a few tweaks) in 08e125d. Let me know if it doesn't resolve your issue and I will reopen this. In any case, thanks for helping me figure it out and for bringing it to my attention!


Tracing data always filtered to 0 events

Checklist

[X] I've read the contribution guidelines.
[X] I've read document and no solution were found.

Step where the question is related to
Recording, Visualization
Description
I follow the instruction about caret and caret report to trace the performance of Autoware.Universe with AWSIM. I can record the data and the size of the data files are correct. But when I started creating architecture file, the loading data is filtered to 0 events. And the jupyter-lab will outputs that all the records are lost.

I reinstall ros2 humble and caret again, and install the caret demo for testing, the tracing data of caret demo is also filtered to 0.

Hi @ZiweiSong96.
It appears that the trace data is lost.
Please refer to the following link.

lttng document: https://lttng.org/docs/v2.13/#doc-channel-overwrite-mode-vs-discard-mode
caret document: https://tier4.github.io/caret_doc/latest/recording/validating/#tracer-discarded

Hi @ZiweiSong96.
It appears that the trace data is lost. Please refer to the following link.
* lttng document: https://lttng.org/docs/v2.13/#doc-channel-overwrite-mode-vs-discard-mode

* caret document: https://tier4.github.io/caret_doc/latest/recording/validating/#tracer-discarded

Thank you for your kind help, I followed the mentioned documents and increased the size of ring-buffer in CARET (8*4096), but the issues are still appeared. When I visualized the latency of node chain with message flow for caret demo, warnings appeared and the figure seems not correct.

Actually when I started the Autoware AWSIM tracing and caret demo tracing, I applied the trace filter at the beginning. But it doesn't seem to work (I use the CLI command to create the architecture file and the warnings appeared.).

Hi. I'm also working on applying CARET on Autoware and encountered a lot of bugs. I didn't realize some of the problems may caused by the 'filtered to 0 events'. So thank you for the post. Have you solved the problem of filtering events and gained some meaningful results? They seem to be not very active and responsive to the issues. I figure we could work on this together.

Hi @ZiweiSong96
I apologize for the delayed response.  I will address each issue separately.

filtered to 0 events

This is a bug in v0.4.23.
The problem can be avoided by downgrading to v0.4.22.

Message flow not rendering correctly

It seems that the data link between the first and second nodes is not functioning properly.
The available DDS implementations are FastDDS or CycloneDDS.  If you are using a different DDS, analysis might not be possible. If you could share the trace data from the tutorial, we can confirm if the necessary events are recorded.

Warning: Cannot generate a safe runtime search path

The issue seems to occur when referencing the system's rclcpp instead of Caret's rclcpp.
If the build is done following the links below, warnings can be ignored.

Build Reference
Systems rclcpp Reference

If you have any further questions or need clarification, feel free to ask.

Hi. I'm also working on applying CARET on Autoware and encountered a lot of bugs. I didn't realize some of the problems may caused by the 'filtered to 0 events'. So thank you for the post. Have you solved the problem of filtering events and gained some meaningful results? They seem to be not very active and responsive to the issues. I figure we could work on this together.

Actually during the last few weeks I tried to solve the problem, I copied the whole src files from another PC (where CARET is working well) and then CARET can work at sometimes, it seems the main branch of CARET cannot work well. But anoter person (He also works on CARET) build CARET main branch successfully and can trace the Autoware. I must say it is really confuse me
o(╥﹏╥)o

@ZiweiSong96
I would like to provide additional details regarding the issue of the "filtered to 0 events" message that is displayed during the creation of the Lttng object. It appears that although the output suggests that all data is lost, the internal data is still retained. The message is misleading and does not seem to affect functionality.
I appreciate your reporting. We have plans to address this bug in the near future.

Hi @ZiweiSong96 I apologize for the delayed response. I will address each issue separately.

filtered to 0 events

This is a bug in v0.4.23.
The problem can be avoided by downgrading to ~v0.4.22~ v0.4.21.

Message flow not rendering correctly

It seems that the data link between the first and second nodes is not functioning properly.
The available DDS implementations are FastDDS or CycloneDDS.  If you are using a different DDS, analysis might not be possible. If you could share the trace data from the tutorial, we can confirm if the necessary events are recorded.

Warning: Cannot generate a safe runtime search path

The issue seems to occur when referencing the system's rclcpp instead of Caret's rclcpp.

If the build is done following the links below, warnings can be ignored.

Build Reference
Systems rclcpp Reference

If you have any further questions or need clarification, feel free to ask.

Thank you very much for your help, I will try these methods to fix the caret on my device.