Is this project still alive?

There hasn't been a commit in many months. Is this still the recommended way to create a graphql-server, or is there a better recommendation now like nexus or typegraphql?

Also, can we update some of the dependencies? apollo-server-express is on a really old version (1.3.6) when latest is at (2.12.0).

The last thing I heard was that it isn't being maintained anymore.

Probably could write a mail or join the slack channel and ask about the status of this project.

This project should be maintained indeed!

For serverless, I've found that Apollo Server Lambda is even simpler than this. I've already migrated an API to it in under an hour and without mayor issues while keeping perfect compatibility.

I also wondered whether this project is still going to be maintained (as it certainly doesn't seem like it is) so I did some searching on the Prisma Slack and saw this from last week:

As for GraphQL Yoga, there won't be any new features added as the team is actively working on the Nexus framework.

I also wondered whether this project is still going to be maintained (as it certainly doesn't seem like it is) so I did some searching on the Prisma Slack and saw this from last week:

As for GraphQL Yoga, there won't be any new features added as the team is actively working on the Nexus framework.

I also settled down to Nexus framework. It's built by Prisma Labs so has great integration with Prisma.

So far I have great impression on the new Nexus framework. There aren't much differences from old Nexus in a way of defining GraphQL schema, but the main difference is that it now serves the api by it self and has neat CLI features.
These are the main factors for me to move from old @nexus/schema to Nexus framework.

First, I would definitely recommend to move from Prisma v1 to v2. Prisma 2 with Nexus framework have better integration through nexus-plugin-prisma.
graphql-yoga project seems outdated. Currently the best alternative is Apollo Server.
But since Nexus framework serves its own server and planning to do so in future you can just use it.
The CLI feature, dev mode, is amazing. It automatically creates and updates the typescript definitions and SDL schema while you're developing.

If you're already familiar with code-first GraphQL schema definition through Nexus and Prisma 2, then there's almost no barrier to Nexus framework.
Here are some links:
https://www.prisma.io/docs/guides/upgrade-from-prisma-1/upgrading-nexus-prisma-to-nexus
https://www.prisma.io/docs/guides/upgrade-from-prisma-1/upgrading-prisma-binding-to-nexus
https://www.nexusjs.org/#/tutorial/introduction

So far I have great impression on the new Nexus framework. There aren't much differences from old Nexus in a way of defining GraphQL schema, but the main difference is that it now serves the api by it self and has neat CLI features.
These are the main factors for me to move from old @nexus/schema to Nexus framework.

First, I would definitely recommend to move from Prisma v1 to v2. Prisma 2 with Nexus framework have better integration through nexus-plugin-prisma.
graphql-yoga project seems outdated. Currently the best alternative is Apollo Server.
But since Nexus framework serves its own server and planning to do so in future you can just use it.
The CLI feature, dev mode, is amazing. It automatically creates and updates the typescript definitions and SDL schema while you're developing.

If you're already familiar with code-first GraphQL schema definition through Nexus and Prisma 2, then there's almost no barrier to Nexus framework.
Here are some links:
https://www.prisma.io/docs/guides/upgrade-from-prisma-1/upgrading-nexus-prisma-to-nexus
https://www.prisma.io/docs/guides/upgrade-from-prisma-1/upgrading-prisma-binding-to-nexus
https://www.nexusjs.org/#/tutorial/introduction

@Jinsung-L Hey, I just started looking at Nexus! Quick question as I'm familiar with Prisma and GraphQL but not so much Nexus. Is Nexus a replacement for the possibly deprecated graphql-yoga?

@tedlin182 Yes. Nexus framework can completely replace graphql-yoga.
But keep in mind that Nexus framework only supports code-first development.
If you don't like code-first approach I suggest using Apollo Server.
Code-first vs. schema-first development in GraphQL
To be clear I'm talking about the new Nexus framework. Previous GraphQL Nexus only supports GraphQL schema definition and can work with graphql-yoga or Apollo Server but can't replace either.

@tedlin182 Yes. Nexus framework can completely replace graphql-yoga.
But keep in mind that Nexus framework only supports code-first development.
If you don't like code-first approach I suggest using Apollo Server.
Code-first vs. schema-first development in GraphQL
To be clear I'm talking about the new Nexus framework. Previous GraphQL Nexus only supports GraphQL schema definition and can work with graphql-yoga or Apollo Server but can't replace either.

@Jinsung-L Yup, the new Nexus Framework is what I'm looking at. I remembered the GraphQL Nexus and initially was confused, but I'm following the new framework now. Thanks for the article and info!

Thank you for all of that information, @Jinsung-L. It's very much appreciated.

This project is awsome but very outdated. I think it will be better to migrate from it to apollo-server or Nexus.
If you need subscriptions (like i do), you must use apollo-server untill Nexus 0.27 release

Yeah, I recently migrated to Apollo Server. It didn't take long and I've had no issues. 👍

If someone needs help to migrate from Yoga, here is my migration code. Hope it can help you ;)
I use @nexus/schema, prisma and graphql-shield and subscriptions but you can easily omit it
server.ts
import { ApolloServer } from 'apollo-server'
import { applyMiddleware } from 'graphql-middleware'
import { createContext } from './context'
import { permissions } from './permissions'
import { schema } from './schema'

const port = process.env.PORT || 4000

new ApolloServer({
  schema: applyMiddleware(schema, permissions),
  context: createContext,
}).listen({ port }, () =>
  console.log(`🚀 Server ready at: http://localhost:${port}/`),
)

context.ts
import { PrismaClient } from '@prisma/client'
import { PubSub } from 'apollo-server'
import { Request, Response } from 'express'
import { ExecutionParams } from 'subscriptions-transport-ws'

const prisma = new PrismaClient()
const pubSub = new PubSub()

// See [Export 'ExpressContext' out of the main module. #3699](https://github.com/apollographql/apollo-server/issues/3699)
export interface ExpressContext {
  req: Request
  res: Response
  connection?: ExecutionParams
}

export interface Context extends ExpressContext {
  prisma: PrismaClient
  pubSub: PubSub
}

export function createContext(context: ExpressContext): Context {
  return {
    ...context,
    prisma,
    pubSub,
  }
}

Hey! we The Guild are going to maintain this library : ) and we triaged all the issues to address them in next major release #704. We will publish the alpha next week. Once we stabilize the API we plan to land stable version in Q1-2022. If there are any feature you would like to see please let us know!

Hey all! Here are the new docs https://www.graphql-yoga.com (still WIP) would love to get your feedback on beta release @graphql-yoga/node@beta


Skip Offsets in gtc:gt:* Backends Where Possible

Description
Skip accessor offsets in gtc:gt:* backends where possible. This decreases code size, increases readability of generated code (especially physics code with many point-wise operations) and might simplify the work for compilers.
Requirements
Before submitting this PR, please make sure:

[x] The code builds cleanly without new errors or warnings
[x] The code passes all the existing tests
[x] If this PR adds a new feature, new tests have been added to test these
new features
[x] All relevant documentation has been updated or added

Additionally, if this PR contains code authored by new contributors:

[x] All the authors are covered by a valid contributor assignment agreement,
signed by the employer if needed, provided to ETH Zurich
[x] The names of all the new contributors have been added to an updated
version of the AUTHORS.rst file included in the PR

bors try


Show trial error message

Currently, the storage full message is only able to be got from the trial-jobs RESTful API, would like to expose it to the WEBUI.

@lvybriage @yangou1988 - seems this one is a good one to merge with the warning message. we can show error/warning message in one style somehow. cc @QuanluZhang

This issue had fixed in PR https://github.com/microsoft/nni/pull/2424
WebUI will show /trial-jobs error message if /trial-jobs return error filed. And website will stop refreshing page.

in 1.6.


Why it does that
Briefly state why the change was necessary.
Further notes
List other areas of code that have changed but are not necessarily linked to the main feature. This could be method
signature changes, package declarations, bugs that were encountered and were fixed inline, etc.
Linked Issue(s)
Closes #3990

Codecov Report
Attention: Patch coverage is 1.44928% with 68 lines in your changes are missing coverage. Please review.

Project coverage is 4.79%. Comparing base (7f20ba5) to head (00c1a41).
Report is 138 commits behind head on main.

Files
Patch %
Lines

...aplane/framework/manager/DataPlaneManagerImpl.java
0.00%
34 Missing :warning:

...controller/v1/DataPlaneSignalingApiController.java
0.00%
8 Missing :warning:

.../eclipse/edc/connector/dataplane/spi/DataFlow.java
0.00%
6 Missing :warning:

...lane/client/DataPlaneSignalingClientExtension.java
0.00%
5 Missing :warning:

...taplane/framework/DataPlaneFrameworkExtension.java
0.00%
4 Missing :warning:

...ctor/dataplane/client/EmbeddedDataPlaneClient.java
0.00%
4 Missing :warning:

...nnector/dataplane/store/sql/SqlDataPlaneStore.java
0.00%
4 Missing :warning:

...e/store/sql/schema/BaseSqlDataPlaneStatements.java
0.00%
2 Missing :warning:

...ataplane/store/sql/schema/DataPlaneStatements.java
0.00%
1 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #3996       +/-   ##
==========================================
- Coverage   71.74%   4.79%   -66.95%
==========================================
  Files         919     975       +56
  Lines       18457   19691     +1234
  Branches     1037    1108       +71
==========================================
- Hits        13242     945    -12297
- Misses       4756   18725    +13969
+ Partials      459      21      -438

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Enhancing Table Size API to return table size per replica

PR contains following changes :

Enhancing Table Size API to return table size per replica in bytes
Code Clean up & removing unused param "detailed" in REST API
Adding & Improving the UT's

Related Discussion : https://apache-pinot.slack.com/archives/C011C9JHN7R/p1684396114803769
cc : @mayankshriv

Codecov Report

Merging #10812 (895f708) into master (2e6f1e6) will decrease coverage by 46.28%.
The diff coverage is 88.57%.

@@              Coverage Diff              @@
##             master   #10812       +/-   ##
=============================================
- Coverage     70.26%   23.99%   -46.28%
+ Complexity     6517       49     -6468
=============================================
  Files          2164     2148       -16
  Lines        116312   115959      -353
  Branches      17590    17549       -41
=============================================
- Hits          81731    27823    -53908
- Misses        28869    85203    +56334
+ Partials       5712     2933     -2779

Flag
Coverage Δ

integration1
23.99% <88.57%> (-0.20%)
:arrow_down:

integration2
?

unittests1
?

unittests2
?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

...ache/pinot/controller/api/resources/TableSize.java
0.00% <ø> (-66.67%)
:arrow_down:

.../apache/pinot/controller/util/TableSizeReader.java
77.93% <88.57%> (-21.25%)
:arrow_down:

... and 1624 files with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

Not required in the PR, but I feel, enhancing the api to also report the compressed size in deepstore would be quite useful.

Sure @mayankshriv  . Yes , this would be useful.  Created a issue for this https://github.com/apache/pinot/issues/10828

This PR breaks the PinotTaskManagerStatelessTest.


UI - View Blockchain - View Addresses

This feature will not be present in this current project, it is planned for another context


Add a conda installation option

I believe, adding a conda installation option for gradsflow will be helpful for growth and adoption of the library. I have started the work on it already. Once the :bulb: PR gets approved and merged, you will have gradsflow on conda-forge.
conda install -c conda-forge gradsflow

:no_entry: :fire: Roadblock to conda-forge packaging
However, there seems to be a problem: it appears that this library is somewhat tightly coupled with comet_ml (which has a proprietary license -- NOT OpenSource). If you could work on making this a weak coupling, or better yet make comet_ml optional (even for tests), that would allow us to make gradsflow available on conda-forge.

cc: @aniketmaurya

Thanks for the Great suggestion @sugatoray 😄
Would you like to work on making comet_ml optional?

@aniketmaurya Although, I would like to, I may not have time to do that now. So, if you, or someone else wants to work on it, please go ahead.

No issues! Let me prioritize this.

@aniketmaurya I believe this issue should be left open until gradsflow is made available on conda-forge. Once it is available I will push a fresh PR to update the docs, readme, etc.

@aniketmaurya Also, please push a new release to PyPI. The conda-forge version is built/updated based on the official PyPI release version(s).

hi @sugatoray, I have made a post-release on PyPI for Gradsflow https://pypi.org/project/gradsflow/.
is there any blocker in conda-forge integration?

@aniketmaurya GradsFlow is now available on conda-forge. :100: :sparkles:

Link to LinkedIn announcement :arrow_upper_right: .


Make patientHeader a component so its bindings will be $watched automaticaly

 Transfer patient between POC applications is not working

Coverage increased (+0.01%) to 55.016% when pulling ffd0354f12dbd2b856613d7891a35686a73a1d4a on ynurmahomed:fix-patient-header into 1b023bd1f134e2148f7ed828ff7d14e984403ab8 on esaude:master.


Minor refinements to initial ui tests.

Can one of the admins verify this patch?

@michaelkleinhenz @nimishamukherjee @naina-verma @sanbornsen @SMahil
Please review this PR.


Add link to config section

Motivation for this change
Add link to "Configuration" chapter from "Changing the Configuration" section.
Also, fix grammar error.
Question: If this gets merged, will it be forward-ported to master at some point?
Things done

[ ] Tested using sandboxing
(nix.useSandbox on NixOS,
or option build-use-sandbox in nix.conf
on non-NixOS)
Built on platform(s)

[ ] NixOS
[ ] macOS
[ ] Linux

[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Fits CONTRIBUTING.md.

Forward-ported.  It's typical to do it the other way, but OK.


TSO support fix

If using TSO(TCP Segmentation Offload), the packet length will be zero.
But gopacket considers the packet as an invalid packet.
This PR will check the TSO packets, and change to the actual data length.
I sent to this PR to upstream. ( https://github.com/google/gopacket/pull/220 ) and it was merged.
Therefore, I request to approve this PR to fix a bug for packetbeat.
Thanks.

Thanks @noricube, LGTM.


Checking COLA condition in istft should be optional (or omitted)

There is some confusion in the literature about the constant-overlap add (COLA) constraint and its relevance to the STFT and ISTFT. I have written this blog post to clarify it. The gist of it is that (1) the COLA constraint is sufficient but not necessary for the STFT to be invertible, and (2) the appropriate COLA constraint for the STFT is on the square of the window, not the window itself.
In SciPy, the istft function enforces COLA on the window (not its square) when nperseg and noverlap are specified. This is unnecessary, incorrect, and prevents the use of many useful windows. If you just comment out the check_COLA lines then istft perfectly inverts the STFT for all but the most pathological windows.
Reproducing code example:
import numpy as np
from scipy import signal

nperseg = 256
hop = 32
noverlap = nperseg - hop
x = np.random.randn(8 * 256)
w = signal.hann(nperseg)
w = np.sqrt(w)
f, t, Zxx = signal.stft(x, window=w, nperseg=nperseg, noverlap=noverlap)
_, y = signal.istft(Zxx, window=w, nperseg=nperseg, noverlap=noverlap)
print(f'allclose: {np.allclose(x, y)}')

Error message:
With the istft code in its current form:
Traceback (most recent call last):
  File "eda_cola.py", line 11, in <module>
    _, y = signal.istft(Zxx, window=w, nperseg=nperseg, noverlap=noverlap)
  File "C:\Users\bruce\Anaconda3\lib\site-packages\scipy\signal\spectral.py", line 1053, in istft
    raise ValueError('Window, STFT shape and noverlap do not satisfy the '
ValueError: Window, STFT shape and noverlap do not satisfy the COLA constraint.

If the check_COLA lines are commented out, the output is
allclose: True

The example is for root Hann, but almost any not-crazy combination of window, nperseg, and noverlap will work.
Scipy/Numpy/Python version information:
1.0.1 1.14.2 sys.version_info(major=3, minor=6, micro=3, releaselevel='final', serial=0)

@e-q you have mostly worked on the COLA code, do you have time to look into this? It does sound like a bug to me.

Interesting! I appreciate the time you've taken to look into this. I haven't gone through the math in your blog post in much detail, but there seem to be two actionable items here:

We could relax the check_COLA into a function that checks that all window values are nonzero and that noverlap>=0.
We allow for bypassing of any window checking in istft, perhaps through a new keyword argument.

If you have the time, it would be really helpful to see a pull request that implements these changes. In particular, it would be useful to see additions of windows that satisfy these relaxed conditions but not COLA in the "roundtrip" tests for istft:
https://github.com/scipy/scipy/blob/61efbf03d23fd3c4117f210becf6153c1cd6ddd9/scipy/signal/tests/test_spectral.py#L1063

As you've noted, a related issue is that can be OK to have noverlap==0  but the code enforces noverlap>0.
Since use of COLA seems widespread (not sure why though!), I'd be inclined to leave check_COLA alone and make a new function check _invertible or something like that.
I'll think about it some more and see if I can make a pull request in the next day or two.

I do agree on one very important point :
The COLA needs to be checked for the square of the window if ultimately you divide by the square of the window here.
What do you think is better : check_COLA takes a window and computes the OLA for the square of it or check_COLA remains unchanged and is called for istft with a square window as argument?

I think check_COLA should remain as is. You may want to check with power 1, or 2, or something else altogether depending on your application. The caller of check_COLA can have access to all possibilities by keeping the function basic and letting the caller raise the window to the desired power before calling it.

I am strongly advocating that check_COLA not be called at all from istft. If someone wants to check COLA, there is a function for that. If someone wants to use istft and doesn't care about COLA, they should be able to do so.

It looks like this is closed by #8870. Thanks for putting in the time and effort to set this straight @gauss256!


Pure IP address in hosts file (the same issue as #1004)

https://github.com/StevenBlack/hosts/blob/0a4d2661e1e45dfecec8019e7bb5cd26e42da5ff/extensions/porn/clefspeare13/hosts#L129
This has IP address only.

Who block forum?

Ping Niclas @Clefspeare13, from line 129 in clefspeare13/hosts.   Thanks!

Ping Niclas @Clefspeare13, from line 129 in clefspeare13/hosts. Thanks!

fixed, sorry

which is why I'm inclined to add it back

@Clefspeare13  as Steven @StevenBlack  already clarified it ,no dns resolver will block IP addresses. The lists here is for blocking domains and domains only.
If you don't mind stop adding them as it will create more and more issues here. Thank you for your understanding.

Thanks Niclas @Clefspeare13.  Please don't add IP addresses as domains in hosts file.  It's completely ineffective.  IP addresses aren't routed through Hosts mechanisms.  Rather, it's domains that route through Hosts, in order to resolve the domain's IP address.

This is fixed and included in Release 2.4.13.
Closing.

Thanks Niclas @Clefspeare13. Please don't add IP addresses as domains in hosts file. It's completely ineffective. IP addresses aren't routed through Hosts mechanisms. Rather, it's domains that route through Hosts, in order to resolve the domain's IP address.

Ah I wasn't aware of this. Well, you learn new things every day, I'll be sure to avoid pure IP addresses going forward.

#1004

https://github.com/FiltersHeroes/KADhosts/issues/56


Game crash when changing noteskin

Game crashes when you change the noteskin in player options and change songs while having the file preview on.
Steps to reproduce the behavior:

Toggle Preview
Go to Player options using the button
Change noteskin and save
Change song
Crash

build d25f4e5b73
Crashinfo.txt

Weak fix but does not solve the problem completely: #396

Tagging this as mantainance since it's "fixed"

Rewrites to chart preview and other previous changes fixed this


AutoSize: outdated doc comment

I guess this comment is outdated?
https://github.com/bvaughn/react-virtualized/blob/04d1221133a1c59be24c8af90ae09e46000372b5/source/AutoSizer/AutoSizer.js#L10

I guess it is. 😄  Please feel free to submit a PR with a fix!


[Stdlib] For Collections, the SubSequence of a Subsequence is SubSequence

Part of ABI FIXME #99, this gives us some nice consistency that
ensures that slicing a SubSequence gives us another SubSequence. There
are two source-compatibility implications to this change:

Collections now need to satisfy this property, which could not be
expressed in Swift 3. There might be some Collections that don't
satisfy this property, and will break with the Swift 4 compiler
even in Swift 3 compatibility mode. Case in point...
The Lazy collection types were formulated as a lazy collection of
the base slice (e.g., LazyCollection<ArraySlice<T>>) rather than as
a slice of the lazy collection (e.g.,
Slice<LazyCollection<Array<T>>). The former doesn't meet the new
requirements, so change to the latter.

@swift-ci please smoke test

@dabrahams and @airspeedswift , you'll be interested in this because it affects compatibility

@airspeedswift specifically, it changes the SubSequence type of the lazy collections.  How serious a compatibility break this is, we'll have to see.


Possible to bypass a certain trait?

Wondering if it's possible to bypass a certain trait?
Iv'e tried modifying the loop in CreateNfts but was unable to have certain attributes skipped if another was detected

Its possible but we aren focussing on update the code ATM. Try using some data structures like a dict/map where the key is the item that you want and the values are a list with rejected items. So basically you check every time your dict/map if the item that you choose has some rejected items


Add support for user details.

👋🏾
This pull request adds a User struct and a method to retrieve a user details.
Let me know if I should update things / add more tests.
Thanks!

This is great! - Thanks 💜

🙌🏾 Cool, thanks for merging! Do you think you could also bump the package version and update it on hex.pm?

Yep, Will try and get a release out today

Released 0.1.0 🎉 🎊  https://hex.pm/packages/bees/0.1.0

Coooool thanks!


Add Natchez Trace Parkway shield

This one was fun. Supporting historic roads like this helps emphasize the "Americana" aspect of the project. In any case, a 444-mile limited-access route deserves some love. This might be a case where we'd want to show the name label as well as the shield at high zooms, not sure if that's a blocker.
https://www.openstreetmap.org/relation/3300032
https://en.wikipedia.org/wiki/Natchez_Trace_Parkway
https://commons.wikimedia.org/wiki/File:Natchez_Trace_Parkway_Logo.gif
The shield was a bit tricky to condense, but I think focusing on the rider captures the essence. I ignored the brown outer border present on some signs since three layers of borders is too many, and the yellow makes it pop more.

2x:

1x:

Pics from the web:

Related to the possible shield restrictions raised in #1101, NPS has also registered the shield for the "Natchez Trace National Scenic Trail". While this is technically separate from the Natchez Trace Parkway shield, the core graphic is identical. Not sure if this is something to worry about.


Wire cypress into ci

Description of PR...
Changes

Item 1
Item 2

PR Template Checklist

[ ] Grammar
[ ] Spelling
[ ] Clarity

Fixes #85, Fixes #22, Fixes username/repo#123
Connects #123

I'm not this good with cypress to approve or not but it's an interesting PR !

The branch is called wire-cypress-into-CI - there are tests that only run on feature/** or fix/** branches so I can do housekeeping on the docker images. It'll be worth changing the (remote) branch name

Few general thoughts:

The branch is called wire-cypress-into-CI - there are tests that only run on feature/** or fix/** branches so I can do housekeeping on the docker images. It'll be worth changing the (remote) branch name
Definitely worth adding linting to the tests.
Worth adding the e2e-tests to the APPS variable in the Makefile - that'll mean you can avoid having to npm install them separately.
Quite a lot of commented out code - fine with that at the moment, but that should be removed before merging to master
Same with the file formats - some empty spaces at end of line and some files missing the empty line at end. Fine for moment, but should be addressed before going to master


Denoising

Hi,
Which of the methods would you use for simple and fast Image Denoising?
Thank You.

BM3D

Well,
Though it is certainly better from any of the operators in this repository, it is not simple or fast.
From those on this repository, what would you chose?
Thank You.


Repo sync for protected CLA branch

The pull request is created from privateToPublic-push-CLA-specifyPeople637607113268886465 to privateToPublic-push-CLA-specifyPeople to fix git push error for protected CLA branch

Docs Build status updates of commit 9cd3c40:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.

File
Status
Preview URL
Details

:x:Error

Details

[Error-GitBranchDeletedOrForcePushed] Cannot sync git repo to specified commit because branch privateToPublic-push-CLA-specifyPeople637607113268886465 has been deleted or has been force pushed

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


Update AC satellite website

Todo:

[x] Define navbar
[x] Choose directories or files for guides
[x] Setup homepage (e.g. introduction.md)
[ ] Use definition lists for guide metadata
[x] Check links to images
[x] Decide if site should also live at http://rs.tdwg.org/ac or rather new https://ac.tdwg.org/

Pages that should return something:

[x] http://rs.tdwg.org/ac/introduction/
[x] http://rs.tdwg.org/ac/guide/
[x] http://rs.tdwg.org/ac/ (currently empty)
[x] http://rs.tdwg.org/ac/structure/
[x] http://rs.tdwg.org/ac/termlist/

(Markdown) files that can be removed:

[ ] 404.html
[ ] about.md
[ ] posts/2018-08-13-welcome-to-jekyll.markdown

@baskaufs @nielsklazenga: some feedback required for the new AC website:

It’s a bit odd to have a homepage (currently blank) and an introduction page. Should the introduction page disappear and become the homepage?
Do you want terms/ or termlist/ for the terms?
Is the order in the navbar ok?
Do you want to maintain files guide.md (current setup) or directories guide/index.md (dwc setup). Both work equally fine: first one is jekyll like, second one allows to organize related files.

@peterdesmet I had it as 'home/' (index.md) and 'terms/' (terms.md), but @baskaufs wanted to keep the old names. I think it's mainly a matter of keeping existing urls alive. I would like it to be consistent with what other standards, e.g. Darwin Core, do.
Order of the nav. bar is fine.
Also for the choice between files or directories, I'd like to follow whatever you decide to do for Darwin Core.

@peterdesmet Look at all the URLs in https://tdwg.github.io/ac/termlist/. They are from the original standard and I think should be kept alive. If they could be redirected to the current pages, I think we can use the URLs that make sense now for these pages.

IRI dereferencing documents in the http://rs.tdwg.org/ is now working and the IRIs given in the header sections of those documents now actually dereference to those documents. The some of the IRIs given in the todo section above are wrong, but the right ones work.

I am checking the box for "Decide if site should also live at http://rs.tdwg.org/ac or rather new https://ac.tdwg.org/". It cannot live at http://rs.tdwg.org/ac because that IRI denotes the Audubon Core vocabulary itself dereferences to the technical metadata about the vocabulary. I'm not sure how much it matters where the "site" lives. The two things that matter are whether the permanent IRIs for the documents dereference somewhere (they do) and that we have some place to archive AC records (we do: it's the GitHub repo for AC). The important thing is that both of this things are linked to the Audubon Core landing page (https://www.tdwg.org/standards/ac/, and they are). So I think this is a moot point.

Similarly, I'm not sure that "Choose directories or files for guides" is important. Any citation of the guides should be their permanent IRIs, not the page to which they are redirected. Given that outlook, I'm not sure that there is any reason why they can't just have the URLs that they have.

@peterdesmet With regards to "Setup homepage (e.g. introduction.md)", can we just set "Home" in the navbar to link to the Audubon Core landing page: https://www.tdwg.org/standards/ac/ ?

@peterdesmet I don't know about the three Markdown documents to be removed. I don't see them anywhere in the docs folder where the website lists. The remaining checkboxes "Define navbar" and "Use definition lists for guide metadata" are technical things I don't understand. It seems like the only real thing here that needs to be done is to make the "Home" link on the Navbar point to the AC landing page. If we do that, can we close this issue?

I missed this comment in September:

I'm not sure how much it matters where the "site" lives. The two things that matter are whether the permanent IRIs for the documents dereference somewhere (they do) and that we have some place to archive AC records (we do: it's the GitHub repo for AC). The important thing is that both of this things are linked to the Audubon Core landing page (https://www.tdwg.org/standards/ac/, and they are). So I think this is a moot point.

The point of using https://ac.tdwg.org/ or similar rather than https://tdwg.github.io/ac/ is to allow for an easier migration if we should decide to stop using GitHub – we have full control of the former, and control only as far as GitHub allow for the latter.

If people have actually linked to the rs.tdwg.org permanent doc URLs, we could move to the ac.tdwg.org subdomain without breaking anything; it would just require changing the redirect URLs. I think most of the links within the website are relative, so they would be fine. The question is how many other places link to the existing tdwg.github.io/ac/ paths. I suppose we could search out the ones in TDWG sites and change them, but I don't know how many other places will end up with broken links.
I guess my inclination would be to leave things as they are. If we move from GitHub in the future, there will be exactly the same number of broken links as there would be if we changed to ac.tdwg.org now. So I can't think of an advantage of switching now.
When we set up the website, I didn't know that the tdwg.org subdomain was an option. We should make sure that any new standards websites don't make the same mistake.

Hi @baskaufs , changing to https://ac.tdwg.org will not break the https://tdwg.github.io/ac paths. As long as the site is in GitHub, those paths will always be there. Try, for example, http://tdwg.github.io/dwc/terms.
So, if we change now, there will be no broken links, but, if we wait until we move the site from GitHub, there will be. I have the AVH website in the Azure CDN, which sets me back about $2 AU per year, so the cost is not really a factor. The site is still managed in GitHub. However, if I ever want to use anything else than Jekyll to create the site, GitHub is not the best option for the site anymore. The TDWG website itself is maintained, but not hosted (I think) in GitHub.
We did not make a mistake. Sites in development always have different URLs from sites in production.

Alright, that makes sense @nielsklazenga. I wasn't thinking about that. @MattBlissett do you control the mapping of the tdwg.org domain? Can you map ac.tdwg.org to https://tdwg.github.io/ac/ ? If so, I don't see any reason not to switch over and start changing any links.

I've set up the DNS for ac.tdwg.org, but I don't have admin access on this repository.  Could you go to Settings->Pages https://github.com/tdwg/ac/settings/pages and set the custom domain to ac.tdwg.org, and tick "Enforce HTTPS" too.
(Alternatively, add me as an administrator to the repository.)

@MattBlissett I have made the setting change. It seems to be working now, except that I get a big ugly warning screen from my browser and the error message:

Websites prove their identity via certificates. Firefox does not trust this site because it uses a certificate that is not valid for ac.tdwg.org. The certificate is only valid for the following names: www.github.com, *.github.com, github.com, *.github.io, github.io, *.githubusercontent.com, githubusercontent.com

That may go away because it said there might be a delay of up to a day for the certificate to work its way through the system. I'll try again tomorrow to see if it's gone away then.
I also tried to add you as a member of the AC team, but it says "this person is not a member of this organization". I'm unclear about what that means. However, I had no problem adding you as an individual with admin access. So I suppose that's good enough, although not clean. @stanblum or another site admin may know how to fix this.

https://ac.tdwg.org/ works fine for me (no warning), so I think it was just a short delay.
I don't seem to be an admin on this repository, but it doesn't matter. The setup is fine.

I don't see the warning any more, so I think we are good to go. Thanks, @MattBlissett !

And you did invite me correctly, the email from GitHub had gone to my personal address.

Although I don't see that every item in the list of the first comment have been completed, I don't actually know what needs to be done with respect to them. If they are a burning issue for anyone, they can re-open this issue, or better yet, open a different issue the addresses the specific problem to be solved.


Cursor position is displayed on the left edge when textAlign is set to center in BasicTextField

Describe the bug
When setting textAlign to TextAlign.Center in BasicTextField (and TextField) on iOS, the cursor position is displayed on the left edge when focused. On Android, it is displayed in the center as expected.
Affected platforms

iOS

Versions

Kotlin version: 1.9.23
Compose Multiplatform version: 1.6.2
OS version(s): iOS 17.4
Device: iPhone 15 Pro Simulator

To Reproduce

Create a new Compose Multiplatform project
Add the following code:

@Composable
@Preview
fun App() {
    var text by remember { mutableStateOf("") }

    MaterialTheme {
        BasicTextField(
            value = text,
            onValueChange = { text = it },
            modifier = Modifier
                .fillMaxWidth()
                .background(Color.LightGray)
                .padding(18.dp),
            maxLines = Int.MAX_VALUE,
            textStyle = TextStyle.Default.copy(
                textAlign = TextAlign.Center,
            ),
        )
    }
}

Run the app on an iOS Simulator
Tap the BasicTextField to focus it
The cursor is displayed on the left edge

Expected behavior
Since textAlign in BasicTextField is set to TextAlign.Center, the cursor should be displayed in the center of the text field on iOS, just like on Android.
Screenshots
Android
https://github.com/JetBrains/compose-multiplatform/assets/32157797/a968c4a8-57a9-4962-8170-a5d4f115a6af
iOS
https://github.com/JetBrains/compose-multiplatform/assets/32157797/27ef6fd2-bb40-4714-99b9-3b6c510301d9
Additional context
The same behavior was observed when using TextField. Regardless of the textAlign value, the cursor is always displayed on the left edge on iOS.
A reproducible project is available at https://github.com/blackcat-carnival/compose-bugreport-202404-01

I reproduced it on a JVM as well
CursorIssue-all.zip

Please check the following ticket on YouTrack for follow-ups to this issue. GitHub issues will be closed in the coming weeks.


upd() improvements

I agree with the proposed changes.
If you use exit xx in a shell alias or function (not an external script), it will terminate the current shell session.
This will cause most terminals to close.
Therefore, using exit inside an alias is probably not the optimal solution.


Change Publication Filename Format

Change publication filename format for PDFs, PowerPoints, etc. to Camel Case and affix pub venue at end with year. Follow same standard as: http://www.cs.umd.edu/~jonf/publications.html
Here's an example of how it's currently done (which I want changed)w:

We need to wait to do this until website has moved over to UW in case it breaks legacy links.

This has been addressed.


[PLAT-5055] Support macOS E2E tests

Goal
Part 1 of the addition of MacOS e2e tests to CI by @nickdowell
Enables standard e2e test features to be run on MacOS through an appium server.
Tests that won't run in this format are tagged with @skip_macos, and will be skipped using --tags='not @skip_macos' in test invocations.
Part 2 will be a basic WIP pipeline running these tests using our existing infrastructure
TODO:

Have iOS only values be tested using @skip on macOS.
Update to Maze-runner v4 syntax

@nickdowell I realise you made most of the initial changes, so if you could just do a feedback review and I'll wait for @twometresteve for approval

@nickdowell I realise you made most of the initial changes, so if you could just do a feedback review and I'll wait for @twometresteve for approval


Make 😯 initialiser and 😀 method of the 🔡 type print no newline by default.

Sometimes it makes sense to avoid the newline and if you want a newline, nothing is stopping you from adding one using 🍪. Tested on 0.5, but it should probably be introduced in 0.6, together with the rest of non-compatible changes.

Not against this per se, but I'd like to see where we go in terms of overloading or default arguments in 0.6 before making any s package decision.

Overloading or the like will certainly not be part of the next version of Emojiode. Furthermore, I'd like to add these features to 0.5 in 0.5.4, which will be released in the next days.
I therefore think the addition of the following methods is reasonable:

👄 to print a string without newline.
👂🏼to wait for the user to input text and hit return. Does not print anything.

These methods will also be included in the next version of Emojicode but

😯 will be removed (unnecessary as it is equal to 😀 &👂🏼)
😀 might be renamed.

These methods/initializers will probably be moved to 🖥 in the future.


Added explicit error message when tsconfig.json is not found

Previous behavior was not very clear: the only error message was "package.json not found in path" and I did not have any idea what does it mean.
The behavior proposed in this PR assumes catching the error of the find-root module and throwing a more meaningful error.

Sweet, that looks good! Thanks! :bow:


[redhat-satellite] Set up automation

See https://github.com/endoflife-date/release-data/pull/110.

See https://github.com/endoflife-date/release-data/pull/110.


Upsample2d for Unet

Is your feature request related to a problem? Please describe.
Add upsample2d support for unet model
Describe the solution you'd like
input shapes to upsample2D:
input shape is N C H W
[2, 64, 66, 10],
[2, 32, 132, 20],
[2, 32, 264, 40],
[2, 16, 528, 80],
Describe alternatives you've considered
bigger batch size support would be great but given the convs for UNet are currently supported for batch size of 2 only, I think 2 should be fine for now.
Additional context
Add any other context or screenshots about the feature request here.

yes we can close this one.


Russian translation: improvements of start-looking-ahead

Q
A

Is bugfix?
yes (doc)

New feature?
no

Breaks BC?
no

Tests pass?
--

Fixed issues
--

Спасибо


Working with query in resolve()

I am stuck with how to work with the incoming query.  I want to be able to pass the requested fields from the graphql query and pass them to my controller which ultimately down the line sends those to my mySQL find() function which does a select id, name  from Company.
I need to be able to send id, name (or whatever the fields from the graph is that is requested) which I get from the graphql query that's incoming so that my find() can dynamically return requested fields per the graphql query.
I wrote this test:
it.only('returns company data', async () => {
    const stub = {
        data: {
          Company: {
            id: 1,
            name: 'Pivotal'
          }
        }
      },
      query = queryString({
        query: `{
          company {
            id,
            name
          }
        }`
      }),
      url = `/graphql?${query}`,
      response = await request
        .get(url),
      reponseData = JSON.parse(response.text);

    expect(reponseData).to.deep.equal(stub);
  });

and it's using one of your helpers I found in your tests (I renamed it to queryString):
function queryString(urlParams?: ?{ [param: string]: mixed }) {
  let querystring
  if (urlParams) {
    querystring = stringify(urlParams);
  }
  return querystring;
}

When I run this test, I see the following being passed to superagent:

On the koa service side, using koa-graphql, I have it setup like this:
import {
  graphql,
  GraphQLSchema,
  GraphQLObjectType,
  GraphQLID,
  GraphQLString
} from 'graphql';

import Companies from '../controllers/Company';

const Company = new GraphQLObjectType({
    name: 'Company',
    fields: () => ({
      id: {
        type: GraphQLID
      },
      name: {
        type: GraphQLString
      }
    })
  }),

  Query = new GraphQLObjectType({
    name: 'Query',
    fields: () => ({
      company: {
        type: Company,
        resolve(parentValue, args, ctx) {
          //not quite sure what to do here.  I need filter to represent an array of requested fields (in this case it's id and name)  from the graphql query or something like that
          const company = async () => Companies.find(filter);
          return company;
        }
      }
    })
  }),

/*  resolve() {
  return {
    id: 1,
    name: 'Pivotal'
  };
}*/

  mySqlSchema = new GraphQLSchema({
    query: Query
  });

export default mySqlSchema;

or am I going about this the wrong way?

You should take id argument in your queries:
# = GET /companies
companies: [Company!]!

# = GET /companies/:id
company(id: Int!): Company

Instead of a hard-coded id: 1 in your resolver:
# = GET /company
company: Company

So then you can get it from second argument args:
resolve(parentValue, args, ctx) {
  return Companies.find({ id: args.id });
}

Or using async resole function:
async resolve(parentValue, args, ctx) {
   const company = await Companies.find({ id: args.id });
   // .....
   return company;
}

If company id is not enough to construct your db queries, feel free to use fourth argument info which is a GraphQLResolveInfo. (fieldName, fieldNodes are included)
type GraphQLFieldResolveFn = (
  source?: any,
  args?: {[argName: string]: any},
  context?: any,
  info?: GraphQLResolveInfo
) => any

type GraphQLResolveInfo = {
  fieldName: string,
  fieldNodes: Array<Field>,
  returnType: GraphQLOutputType,
  parentType: GraphQLCompositeType,
  schema: GraphQLSchema,
  fragments: { [fragmentName: string]: FragmentDefinition },
  rootValue: any,
  operation: OperationDefinition,
  variableValues: { [variableName: string]: any },
}

hard-coded id: 1
that was just for testing at first


RabbitMQ.Client 7 and async

Required a pretty intense rewrite for async support and the heavy API changes of RabbitMQ.Client 7.
I have used it for our applications' test suites, which are quite realistic and in-depth.

Ping @odalet ! Hoping you're willing to do some work on this repo! 😁

Hi @patrikwlund! It seems you've been busy on this and it's probably a great addition to FakeRabbitMQ.
Sadly, because of unfortunate professional circumstances, I won't be able to keep on maintaining projects in this organization.
I could grant you a committer access on this porject, but I'm not sure it is a good idea: this organization (and most of the projects it hosts) is named after a real company. This was all good while I was maintaining things on their behalf, but this is not the case any more.
If you feel up to the task, you can establish your fork as the official successor of this project (renaming it, so as to get rid of the AddUp naming, or not, that's up to you).
If this is ok with you, I'll be happy to place a notice in the Readme file indicating your fork is now the place to go for an up-to-date FakeRabbitMQ library, just before I archive the repository. Just tell me so.
Sorry for leting you down.

Hi @patrikwlund! It seems you've been busy on this and it's probably a great addition to FakeRabbitMQ.
Sadly, because of unfortunate professional circumstances, I won't be able to keep on maintaining projects in this organization.

No worries @odalet, I understand 😊 Thank you for maintaining it previously.
I will probably fork it after the holidays. We'll see.


fix(schema): :bug: add missing sitename in json schema

Why this PR?

This PR adds a missing sitename in the Homepage and Post schema
Currently, Ghost blog doesn't have a sitename by default, instead it just shows the domain name.

Reference: https://developers.google.com/search/docs/appearance/site-names

[x] There's a clear use-case for this code change, explained below
[x] Commit message has a short title & references relevant issues
[x] The build will pass (run yarn test:all and yarn lint)

🤖 Generated by Copilot at e746277
This change adds the name property to the home schema object in schema.js, which helps generate better JSON-LD metadata for the home page. This improves the SEO and accessibility of Ghost sites by providing more structured data.

Hi @binary-koan Did you check this already?

Hi @binary-koan can you look into this PR. Thanks

Hey @mcnaveen, really sorry we didn't review this PR in a timely fashion. Looks like there's probably some great changes here. If you're still interested in working on this please re-raise your PR and we'll work through it. Thank you 🙏


Stages are not reloaded when file is edited in VSCode

I’ve noticed that the extension has a bug when editing the pipeline in VSCode and re-running it from the Extension.
The extension UI should listen to changes to the pipeline file and reload the stages/steps.

As discussed on the Slack, with extension API capabilities I see it's not possible to have daemon running to watch the files. I will keep this open, when extension API adds capabilities I will fix this issue. Also currently the Drone Server Web UI does not sync dynamically when .drone.yml changes. So I feel we are good giving the same Ux.


Key prefixing with blpop returns prefixed key

When you use the keyPrefix option you should be getting back the "un-prefixed" version of the key when using multiple keys in blpop.
Example:
redis = new Redis({keyPrefix: "test:"})

var actionOneKey = "case:1",
    actionTwoKey = "case:2";

redis.blpop([actionOneKey, actionTwoKey], 0, function(err, msg){
    console.log(msg[0]); // Is "test:case:1", but really should be "case:1"

    // Fails
    if (msg[0] === actionOneKey){}
});

redis.lpush("test:case:1", "Hello World");

keyPrefix is only applied to the keys when sending commands to Redis.
It's pretty similar to another issue https://github.com/luin/ioredis/issues/239.

It is not really about multiple applications, its more about being able to programatically use set of keys and handle them without having to hard code them at any point.

@Tomino2112 Yeah, I know there are some use cases where the support for namespace become very useful. However it's a little difficult to implement that.
The support for keyPrefix option is achieved with the benefit of the Redis command API so we could be able to know which arguments of a command are keys. However, there's no such API for replies, which means we have to hardcode a list recording which replies should be transformed. This way is far from reliable IMO and requires a lot of work.

I think I understand, Its no problem to just not use it. THanks

I just added a link to this issue to the README. Thank you for pointing this out!


Implement mechanism for hydrating SSR-generated content

The whole enabling SSR through extendDelay() idea seems unworkable. Need to have a specific SSR mode, forcing the correct behavior, depending on whether we're rendering server sider, hydrating, or rendering normally.

Closed by mistake :-p


Add service account key to Register API response

This change adds a new field to the v0.RegisterResponse structure for Credentials. The first field of this structure is the ServiceAccountKey which will be base64 encoded, as it is returned from the IAM CreateKey API.
This change includes updates to the Register handler, and setup for the Server structure in the autojoin main.go setup. Finally, this change includes updates to the register command to save the service account credentials to a local file.
The combination of these changes should make it easier to deploy new
TODO: command for new organization setup to ensure that the service account and secrets exist for Register to use.

This change is

Pull Request Test Coverage Report for Build<PHONE_NUMBER>5
Details

18 of 18 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.03%) to 98.595%

Totals

Change from base Build<PHONE_NUMBER>3:
0.03%

Covered Lines:
912

Relevant Lines:
925

💛  - Coveralls


Fix minor release docs

⚠⚠⚠ IMPORTANT: You still have to make these changes before you run this make command ⚠⚠⚠

Description of changes:

Fixed bug in generation (--generateChangelogChanges should have been false)
Added override number ability for generating docs

Changed github-release used the same logic as ^ this, as it already had this functionality

Renamed variables to better fit what they were, though I don't particularly like any of the names

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

/lgtm

/approve


Modular Forms: Fix incorrect type in example

Overview

What is it?

[ ] Feature / enhancement
[ ] Bug
[x] Docs / tests / types / typos

Description
Fixes a typo / incorrect type in the Modular Forms docs.
Use cases and why

One use case

Another use case

Checklist:

[ ] My code follows the developer guidelines of this project
[ ] I have performed a self-review of my own code
[ ] I have made corresponding changes to the documentation
[ ] Added new tests to cover the fix / functionality

thx @RaeesBhatti 🙏
pinging @fabian-hiller for a quick approval 👼 🙏

Looks good! Thank you! @RaeesBhatti are you interested in replacing Zod with Valibot in another PR?


plz, how to use?

It seemed the sql file is empty

It hasn't been updated yet. You can create a sql based on the struct in entity


Manual cherry pick of autoscaler cve fixes for release 0.14

Manual cherry pick of #1744 and #1756 due to merge conflict with #1767

/approve


Validate uri format

Adds a Validator for the string format 'uri' similar to the Validators for IPv4 and IPv6

I've added more testcases with a separate PR at https://github.com/json-schema-org/JSON-Schema-Test-Suite/pull/189

Awesome, thanks for this @blackivory86. Now that https://github.com/json-schema-org/JSON-Schema-Test-Suite/pull/189 is merged, would you like to update the submodule in this PR so we can see it works and then I'll merge and cut a release.

I've fixed some formatting issues and merged in 50c180b along with 3d0c638 enabling the uri tests.


Move ftl-go into ftl.

I was wondering about this
@alecthomas what was the original reason for splitting the functionality out? Once moving ftl-go into ftl will that change the existing ftl or just extend it's functionality?

It will just extend the functionality of ftl.


Problem with alpine 3.9.1

Hi, had problems with the modals after alpine released the new version 3.9.1, not sure if the error its caused by an error of them, or if its an error on this package.
Basically the error its that the first time the modal its opened it worked correctly, but if you hided and click again it started failing and showing only an empty popup.
Fixed the problem just changing to alpine 3.9.0
Send this just for inform you. Regards

Already fixed (https://github.com/wire-elements/modal/issues/192, https://github.com/wire-elements/modal/discussions/191)


Add support for sparse LQ dynamic optimization

Added functions to DynamicNLPModels.jl to enable building a QuadraticModel from a Q, R, A, and B matrix with optional x0, Qf, and lower/upper bounds on state and input variables.
3 functions were added:

build_H: builds a sparse matrix from the Q and R (and optional Qf) matrices such that $z^T H z = \Sigma_{i=1}^N(x_i^T Q x_i) + \Sigma_{i=1}^N(u_i^T R u_i) + x_N^T Qf x_N$ (where $Qf$ defaults to $Q$ if not defined). This is the format QuadraticModels.jl expects
build_A: builds a sparse matrix that is equivalent to $x_(t+1) = Ax_t + Bu_t,$ for $t = 1, ...., N-1$. The new matrix has the form $ 0 \le Az \le 0$, which is the format QuadraticModels.jl expects.
get_QM: Constructs a QuadraticModel from the Q, R, A, and B matrices along with the number of time steps, nt. Returns a QuadraticModel.

Also added scripts to test/ that includes a script building an equivalent JuMP.jl model of the above quadratic programs and tests that the solution fo the QuadraticModel is the same as the JuMP.jl model. The runtests.jl file runs the JuMP.jl model with Ipopt and compares it to the QuadraticModel solved with Ipopt and with MadNLP

and another minor comment. I find it confusing to use x as the symbol for state variables, because x is used for primal variable for NLP. I suggest changing the symbols for state variables to s

Codecov Report

Merging #1 (fd6f5f1) into main (2c1e986) will increase coverage by 91.93%.
The diff coverage is 96.61%.

@@            Coverage Diff             @@
##            main       #1       +/-   ##
==========================================
+ Coverage   0.00%   91.93%   +91.93%
==========================================
  Files          1        1
  Lines          4       62       +58
==========================================
+ Hits           0       57       +57
- Misses         4        5        +1

Impacted Files
Coverage Δ

src/DynamicNLPModels.jl
91.93% <96.61%> (+91.93%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2c1e986...fd6f5f1. Read the comment docs.


⚠ Bofrost.de has degraded performance

In 7593ba1, Bofrost.de (https://www.bofrost.de) experienced degraded performance:

HTTP code: 200
Response time: 1541 ms

Resolved: Bofrost.de performance has improved in 6561386 after 17 minutes.


2 ➡ 3

The INTEGRATION_versioned_symbols test is failing on actions but they pass on Jenkins. I just realized these tests don't get generated for me locally, I'm not sure why.

a879629 fixes the INTEGRATION_versioned_sym tests

@osrf-jenkins run tests please


gz_ros2_control: 1.1.2-1 in 'iron/distribution.yaml' [bloom]

Increasing version of package(s) in repository gz_ros2_control to 1.1.2-1:

upstream repository: https://github.com/ros-controls/gz_ros2_control
release repository: https://github.com/ros2-gbp/ign_ros2_control-release.git
distro file: iron/distribution.yaml
bloom version: 0.11.2
previous version for package: 1.1.1-1

gz_ros2_control
* Catch pluginlib exceptions (#175 <https://github.com/ros-controls/gz_ros2_control/issues/175>)
* Contributors: Alejandro Hernández Cordero

gz_ros2_control_demos
* Set C++ version to 17 (#171 <https://github.com/ros-controls/gz_ros2_control/issues/171>)
* Update diff_drive_controller_velocity.yaml (#172 <https://github.com/ros-controls/gz_ros2_control/issues/172>)
* Contributors: Alejandro Hernández Cordero

Holding for Iron sync


Multiple Running Containers End Up with the Same External IP Address

Hi,
Experienced an issue yesterday and today where multiple running containers end up with the same external IP address assigned to them. The IP address works to call into one of the containers and the other is left without inbound network access.
The containers were created around the same time. I have 6 VSTS release environments that each create 20 containers through an ARM template. The 6 environments are all triggered at the same time to deploy. I use 2 different subscriptions and 3 resource groups within each subscription (1 for each supported aci region). In total trying to create 120 containers.
The containers in the example attached with the same IP were created in different azure subscriptions but both in West Europe.

Thanks
Nathan

Thanks for reporting this. We will roll out a fix in the next week or so.


Change button text zumachen to schließen

Describe the bug
Please change the text in button to close the window from "zumachen" to "schließen"

To Reproduce
Steps to reproduce the behavior:

Open dialog e.g. "Projekte verwalten"

Expected behavior
Wording of button text in german is "schließen"
Versions:

Adapter version: vis2-beta: 2.0.7

is fixed with v2.0.8


Does this repository include the designer UI?

I'm confused, does this repo contain the designer UI to build the pages?

It currently doesn't; will add clarification on this.
Are you looking to reuse the visual editor in a different product?

Yes, I thought this could come in handy for letting users customizing a subset of an app.

Just following up, I am very curious how it is build. Will it be open sourced?

@iSuslov Not currently, but we will be sharing technical deep-dives related to Plasmic in the new year (will announce these on Twitter).


Package cannot be installed with optional dependencies when using Python 3.13

Solution to issue cannot be found in the documentation.

[x] I checked the documentation.

Issue
serialite formally added support for Python 3.13 in v0.3.5. Unfortunately, it seems most of the optional dependencies can't be installed when using Python 3.13.
The following pixi.toml fails to solve the environment (tested under osx-64):
[project]
channels = ["conda-forge"]
name = "test_serialite"
platforms = ["osx-64", "linux-64"]

[dependencies]
python = "3.13.*"
serialite = "0.3.5"
pydantic = "1.*"

× failed to solve the conda requirements of 'default' 'osx-64'
  ╰─▶ Cannot solve the request because of: pydantic 1.* cannot be installed because there are no viable options:
      └─ pydantic 1.0 | 1.0 | 1.1 | 1.1 | 1.1.1 | 1.1.1 | 1.2 | 1.2 | 1.2 | 1.3 | 1.3 | 1.3 | 1.4 | 1.4 | 1.4 | 1.5 | 1.5 | 1.5 | 1.5.1 | 1.5.1 | 1.5.1 | 1.6 | 1.6 | 1.6 | 1.6.1 | 1.6.1 | 1.6.1 | 1.6.1 | 1.6.1 | 1.6.1 | 1.6.1 | 1.7 | 1.7 | 1.7 | 1.7 | 1.7.1 | 1.7.1 | 1.7.1 | 1.7.1 | 1.7.2 | 1.7.2 |
      1.7.2 | 1.7.2 | 1.7.2 | 1.7.2 | 1.7.2 | 1.7.2 | 1.7.3 | 1.7.3 | 1.7.3 | 1.7.3 | 1.7.3 | 1.7.3 | 1.7.3 | 1.7.3 | 1.7.3 | 1.7.3 | 1.7.3 | 1.7.3 | 1.7.3 | 1.8 | 1.8 | 1.8 | 1.8 | 1.8 | 1.8.1 | 1.8.1 | 1.8.1 | 1.8.1 | 1.8.1 | 1.8.2 | 1.8.2 | 1.8.2 | 1.8.2 | 1.8.2 | 1.8.2 | 1.8.2 | 1.8.2 | 1.8.2 |
      1.8.2 | 1.8.2 | 1.8.2 | 1.8.2 | 1.8.2 | 1.8.2 | 1.9.0 | 1.9.0 | 1.9.0 | 1.9.0 | 1.9.0 | 1.9.0 | 1.9.0 | 1.9.0 | 1.9.0 | 1.9.0 | 1.9.0 | 1.9.1 | 1.9.1 | 1.9.1 | 1.9.1 | 1.9.1 | 1.9.1 | 1.9.2 | 1.9.2 | 1.9.2 | 1.9.2 | 1.9.2 | 1.9.2 | 1.10.0 | 1.10.0 | 1.10.0 | 1.10.0 | 1.10.0 | 1.10.0 | 1.10.1 |
      1.10.1 | 1.10.1 | 1.10.1 | 1.10.1 | 1.10.1 | 1.10.1 | 1.10.1 | 1.10.1 | 1.10.1 | 1.10.1 | 1.10.1 | 1.10.2 | 1.10.2 | 1.10.2 | 1.10.2 | 1.10.2 | 1.10.2 | 1.10.2 | 1.10.2 | 1.10.2 | 1.10.2 | 1.10.2 | 1.10.2 | 1.10.3 | 1.10.3 | 1.10.3 | 1.10.3 | 1.10.3 | 1.10.3 | 1.10.4 | 1.10.4 | 1.10.4 | 1.10.4
      | 1.10.4 | 1.10.4 | 1.10.4 | 1.10.4 | 1.10.4 | 1.10.4 | 1.10.4 | 1.10.4 | 1.10.5 | 1.10.5 | 1.10.5 | 1.10.5 | 1.10.5 | 1.10.5 | 1.10.6 | 1.10.6 | 1.10.6 | 1.10.6 | 1.10.6 | 1.10.6 | 1.10.7 | 1.10.7 | 1.10.7 | 1.10.7 | 1.10.7 | 1.10.7 | 1.10.8 | 1.10.8 | 1.10.8 | 1.10.8 | 1.10.8 | 1.10.8 |
      1.10.9 | 1.10.9 | 1.10.9 | 1.10.9 | 1.10.9 | 1.10.9 | 1.10.10 | 1.10.10 | 1.10.10 | 1.10.10 | 1.10.10 | 1.10.10 | 1.10.11 | 1.10.11 | 1.10.11 | 1.10.11 | 1.10.11 | 1.10.11 | 1.10.12 | 1.10.12 | 1.10.12 | 1.10.12 | 1.10.12 | 1.10.12 | 1.10.13 | 1.10.13 | 1.10.13 | 1.10.13 | 1.10.13 | 1.10.13 |
      1.10.13 | 1.10.13 | 1.10.13 | 1.10.13 | 1.10.13 | 1.10.14 | 1.10.14 | 1.10.14 | 1.10.14 | 1.10.14 | 1.10.14 | 1.10.16 | 1.10.16 | 1.10.16 | 1.10.16 | 1.10.16 | 1.10.16 | 1.10.17 | 1.10.17 | 1.10.17 | 1.10.17 | 1.10.17 | 1.10.17 would require
         └─ python >=3.7,<3.8.0a0, for which no candidates were found.

This seems to happen because there's no Python 3.13 conda-forge package for Pydantic 1.*. Looking at PyPI, there are no 3.13 wheels either for 1.* Pydantic. Maybe it is building Cython binaries from source or falling back to pure Python, but I'm not sure. Pydantic 2.* can't be installed either because of the run_constrained entry in the recipe.
This also happens to numpy in a very similar way. And fastapi can't be installed either because of its dependency on pydantic.
Installed packages
N/A

Environment info
N/A

Well, that's an unfortunate failure mode. PyPI presumably muddled through by compiling the sdist, but conda doesn't do that. My inclination is to take this course of action:

Figure out how to test this in conda forge.
Figure out how to prevent the use of sdists from PyPI, at least in CI.
Do not yank the current builds. Someone could build Pydantic and NumPy 1.0 for Python 3.13.

The long term solution is to release Serialite 0.4 which has been updated to use Pydantic 2 and NumPy 2, but that is a much bigger lift, especially for Pydantic because Serialite engages in wild monkey patching in order to work.


[Draft] Replaces flask with fastapi monitor

Adds first draft for FastAPI ocrd monitor implementation.
There are still several things that are still very WIP.
Settings
Until settings are finalized, I have hardcoded them in the monitor's init.sh. Eventually they should be parsed from existing variables or new variables that can be added to the main .env file.
When reviewing, please check if I got all the paths to workspaces and so on correctly.
I intended to use pydantic's automatic settings management that is able to automatically parse environment variables or an env file into a settings object (see pydantic docs). Unfortunately it doesn't handle environment variables that are named exactly like sub settings classes very well. Therefore I had to prefix my new setting environment variables with OCRD_, since we already had variables starting with CONTROLLER.
Jobs page
I'm not sure I got all the links on the jobs page correctly. Especially, the links to the log files were a bit wonky in my testing, but could be because of all the changes I made during the implementation.
Testing
While I've written some tests for core logic, I'd like to expand tests for the web application a bit more in the future. This will probably involve setting up some dummy workspaces and mocking out the controller.
Documentation
Since the end user will probably only have to deal with setting up some new variables, I haven't added any documentation for that until we finalize all the settings we need.

See https://github.com/SvenMarcus/ocrd_manager/pull/1

workspaces are not listet atm

should be fixed now

request of workflow from inactive jobs results in not found http://localhost:5000/workflows/detail/ocr-workflow-default.sh

The problem here is that the workflow files are only in ocrd_manager (e.g. /usr/bin/ocr-workflow-default.sh), not in ocrd_monitor.
Since we want to make all of these editable and perhaps even version-control them, IMO we have to introduce an additional volume, shared by both the Manager and the Monitor.

request of log from inactive jobs results in not found http://localhost:5000/logs/view/ocr-d/data/3

should be fixed now

linking of dozzle logs from home is missing

should be fixed now

maybe small documentation of how to run test in Readme.md
adjustment of enviroment variables in base repro -> separate PR maybe after current PR is merged
documentation of components in base documentation -> separate PR maybe after current PR is merged

I agree.

With the latest commits, I believe this PR should be ready to be merged now. While the code is not perfect yet, we should be able to further improve it from the main branch.

Thx! 👍🏻
Unfortunately I get a 404 when I try to open the default workflow because the path is assembled incorrectly http://localhost:5000/workflows/detail//usr/bin/ocr-workflow-default.sh

While the code is not perfect yet, we should be able to further improve it from the main branch.

Can you open a issue to see what specifically needs to be changed? This would also have to be taken into account in further implementation.

Unfortunately I get a 404 when I try to open the default workflow because the path is assembled incorrectly http://localhost:5000/workflows/detail//usr/bin/ocr-workflow-default.sh

Like I said above, the reason for this is not in the Monitor (code), but in the way we currently set up the division of labour between containers. The workflows are only in the Manager. We'd first have to define a shared volume.

Can you open a issue to see what specifically needs to be changed?

Here's one: https://github.com/slub/ocrd_manager/issues/46

One thing that must be updated before merging though: the ports section of docker-compose.yml!

Like I said above, the reason for this is not in the Monitor (code), but in the way we currently set up the division of labour between containers. The workflows are only in the Manager. We'd first have to define a shared volume.

Ok I overlooked this. I think the adjustment is divided into OCR-D Manager and Monitor Repo and it is one repo atm. How had we made the workflows visible in the monitor before?

Ok I overlooked this. I think the adjustment is divided into OCR-D Manager and Monitor Repo and it is one repo atm.

That's independent, though. Containers/volumes are one thing, repos another.

How had we made the workflows visible in the monitor before?

We had a copy of the workflow in the process directory.

Ok I overlooked this. I think the adjustment is divided into OCR-D Manager and Monitor Repo and it is one repo atm.

That's independent, though. Containers/volumes are one thing, repos another.

How had we made the workflows visible in the monitor before?

We had a copy of the workflow in the process directory.

Ah ok then it just happened to work because our demo data brings the workflow. By default, there is no workflow in the process dir, but only if it is configured in Kitodo.Production.
Then we fix that separately.

How were we left with the Python test? Should a image or container be created with e.g. DockerfileTest here which contains the dependencies or should the version dependency to Python 10 be adjusted?
In my case test do not run through yet.
weigelt@LDV163:~/Work/OCR-D/test/ocrd_kitodo/_modules/ocrd_manager/ocrd_monitor$ nox
nox > Running session mypy-3.9
nox > Missing interpreters will error by default on CI systems.
nox > Session mypy-3.9 skipped: Python interpreter 3.9 not found.
nox > Running session mypy-3.10
nox > Creating virtual environment (virtualenv) using python3.10 in .nox/mypy-3-10
nox > python -m pip install -r requirements.txt
nox > Command python -m pip install -r requirements.txt failed with exit code 1:
Traceback (most recent call last):
  File "/usr/lib/python3.10/runpy.py", line 196, in _run_module_as_main
    return _run_code(code, main_globals, None,
  File "/usr/lib/python3.10/runpy.py", line 86, in _run_code
    exec(code, run_globals)
  File "/home/weigelt/Work/OCR-D/test/ocrd_kitodo/_modules/ocrd_manager/ocrd_monitor/.nox/mypy-3-10/lib/python3.10/site-packages/pip/__main__.py", line 19, in <module>
    sys.exit(_main())
  File "/home/weigelt/Work/OCR-D/test/ocrd_kitodo/_modules/ocrd_manager/ocrd_monitor/.nox/mypy-3-10/lib/python3.10/site-packages/pip/_internal/cli/main.py", line 73, in main
    command = create_command(cmd_name, isolated=("--isolated" in cmd_args))
  File "/home/weigelt/Work/OCR-D/test/ocrd_kitodo/_modules/ocrd_manager/ocrd_monitor/.nox/mypy-3-10/lib/python3.10/site-packages/pip/_internal/commands/__init__.py", line 96, in create_command
    module = importlib.import_module(module_path)
  File "/usr/lib/python3.10/importlib/__init__.py", line 126, in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
  File "<frozen importlib._bootstrap>", line 1050, in _gcd_import
  File "<frozen importlib._bootstrap>", line 1027, in _find_and_load
  File "<frozen importlib._bootstrap>", line 1006, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 688, in _load_unlocked
  File "<frozen importlib._bootstrap_external>", line 883, in exec_module
  File "<frozen importlib._bootstrap>", line 241, in _call_with_frames_removed
  File "/home/weigelt/Work/OCR-D/test/ocrd_kitodo/_modules/ocrd_manager/ocrd_monitor/.nox/mypy-3-10/lib/python3.10/site-packages/pip/_internal/commands/install.py", line 24, in <module>
    from pip._internal.cli.req_command import RequirementCommand
  File "/home/weigelt/Work/OCR-D/test/ocrd_kitodo/_modules/ocrd_manager/ocrd_monitor/.nox/mypy-3-10/lib/python3.10/site-packages/pip/_internal/cli/req_command.py", line 15, in <module>
    from pip._internal.index.package_finder import PackageFinder
  File "/home/weigelt/Work/OCR-D/test/ocrd_kitodo/_modules/ocrd_manager/ocrd_monitor/.nox/mypy-3-10/lib/python3.10/site-packages/pip/_internal/index/package_finder.py", line 21, in <module>
    from pip._internal.index.collector import parse_links
  File "/home/weigelt/Work/OCR-D/test/ocrd_kitodo/_modules/ocrd_manager/ocrd_monitor/.nox/mypy-3-10/lib/python3.10/site-packages/pip/_internal/index/collector.py", line 12, in <module>
    from pip._vendor import html5lib, requests
ImportError: cannot import name 'html5lib' from 'pip._vendor' (/home/weigelt/Work/OCR-D/test/ocrd_kitodo/_modules/ocrd_manager/ocrd_monitor/.nox/mypy-3-10/lib/python3.10/site-packages/pip/_vendor/__init__.py)

A small docu would be helpful here to perform the tests (https://github.com/slub/ocrd_manager/pull/45#issuecomment-1403451106) so that not everything is assumed or you have to orientate yourself on the source.
From my point of view, we can solve the runnability of the tests later, because initially the Flask application came even without tests.

How were we left with the Python test? Should a image or container be created with e.g. DockerfileTest here which contains the dependencies or should the depended code to Python 10 be adjusted?
In my case test do not run through yet.

I think this may be a problem with an outdated pip installation on your system: https://stackoverflow.com/questions/69503329/pip-is-not-working-for-python-3-10-on-ubuntu/69527217#69527217

Unfortunately this did not help. Have the latest version and before that the previous bugfix version.

The noxfile runs mypy and the tests for python versions 3.9, 3.10, and 3.11 and all of them are passing when I run it.

My question was also whether we should install all the requirements for the test on the host or whether we should just build an image temporarily and start it as a container.

my locale side-packages directory has the html5lib. But nox opens virtual environments which contains an older pip version and in the .nox/.../side-packages/ the html5lib is not available.

As workaround i can run the test with following command docker run --rm -it -v $(pwd):/src thekevjames/nox:2022.11.21 nox -f src/noxfile.py however a few still fail. Probably it is because they are running in the container and not on the host.

@SvenMarcus if you still make the discussed documentation adjustment we can merge the branch. :rocket:


RHIROS-573,574,575,601 - Historical data support

[x] DB schema change
[x] Population & fixing existing data as per new schema in performance_profile as well as performance_profile_history tables
[x] Fixed existing model and APIs.  (RHIROS-575)
[x] Populate time information along with date for report_date column (RHIROS-601)
[x] Pulled @r14chandra's commit related consumers from PR https://github.com/RedHatInsights/ros-backend/pull/200 and made new changes to consumers files. These changes make sure performance_profile ONLY includes latest reported record per system (RHIROS-574)
[x] Fixed the broken tests

Important Note:
If you are planning to run these DB migration locally, I would suggest to take DB dump first for Postgres docker container and restore it once you finish with testing.
Though there are lot of references available online, sharing few links:

https://simplebackups.com/blog/docker-postgres-backup-restore-guide-with-examples/
https://medium.com/codex/how-to-persist-and-backup-data-of-a-postgresql-docker-container-9fe269ff4334

Ran smoothly DB migrations against stage DB dump. Refer below logs from local:
Migrations ran against stage DB dump:

2022-04-01 15:16:26,718 - INFO  - _log - <IP_ADDRESS> - - [01/Apr/2022 15:16:26] "GET /metrics HTTP/1.1" 200 -
[localhost ros-backend]$ pipenv run python3 -m manage db upgrade
INFO  [alembic.runtime.migration] Context impl PostgresqlImpl.
INFO  [alembic.runtime.migration] Will assume transactional DDL.
INFO  [alembic.runtime.migration] Running upgrade 605a688d0cd2 -> 015d7d1fea52, update performance profile table
INFO  [alembic.runtime.migration] Running upgrade 015d7d1fea52 -> 3d3a1981593c, populate fields from systems to performance profile
INFO  [alembic.runtime.migration] Running upgrade 3d3a1981593c -> 26a16593ec96, remove columns from systems
INFO  [alembic.runtime.migration] Running upgrade 26a16593ec96 -> 8c6f4554d24d, create performance profile history
INFO  [alembic.runtime.migration] Running upgrade 8c6f4554d24d -> 457844090fad, set keys on performance profile history
INFO  [alembic.runtime.migration] Running upgrade 457844090fad -> ccf59577aca2, keep last reported in perf profile
Rows deleted from PerformanceProfile table=0
INFO  [alembic.runtime.migration] Running upgrade ccf59577aca2 -> 77fdc857c94f, alter pk on performance profile

API server log:
[kavita@localhost ros-backend]$ pipenv run python3 -m ros.api.main
2022-04-01 15:17:50,156 - WARNING  - commence_cw_log_streaming - CLOUDWATCH LOGGING - Disabled
 * Serving Flask app "ros.lib.app" (lazy loading)
 * Environment: production
   WARNING: This is a development server. Do not use it in a production deployment.
   Use a production WSGI server instead.
 * Debug mode: off
2022-04-01 15:23:16,719 - INFO  - _log - <IP_ADDRESS> - - [01/Apr/2022 15:23:16] "GET /metrics HTTP/1.1" 200 -
2022-04-01 15:23:19,524 - INFO  - _log - <IP_ADDRESS> - - [01/Apr/2022 15:23:19] "GET /api/ros/v1/systems?limit=2 HTTP/1.1" 200 -

Response:
{
    "meta": {
        "count": 21,
        "limit": 2,
        "offset": 0
    },
    "links": {
        "first": "/api/ros/v1/systems?limit=2&offset=0",
        "last": "/api/ros/v1/systems?limit=2&offset=19",
        "next": "/api/ros/v1/systems?limit=2&offset=2",
        "previous": null
    },
    "data": [
        {
            "fqdn": "iqe-ros-003b98b0-6fd1-4691-9fa1-5d868f71ef2c",
            "display_name": "iqe-ros-003b98b0-6fd1-4691-9fa1-5d868f71ef2c",
            "inventory_id": "5c673539-353f-486a-89d4-e2ba8fc9a24f",
            "account": "6089719",
            "number_of_suggestions": 1,
            "state": "Idling",
            "performance_utilization": {
                "cpu": 0,
                "memory": 0,
                "max_io": 0.314,
                "io_all": {
                    "xvda": 0.314
                }
            },
            "cloud_provider": "aws",
            "instance_type": "t2.micro",
            "idling_time": "199.70",
            "os": "RHEL 8.4",
            "report_date": "2022-03-23 00:00:00+00:00"
        },
        {
            "fqdn": "iqe-ros-142213d3-4aaf-43bf-b418-5508e8088f30",
            "display_name": "iqe-ros-142213d3-4aaf-43bf-b418-5508e8088f30",
            "inventory_id": "b23eeede-3914-428f-aaf5-3efded93c8e7",
            "account": "6089719",
            "number_of_suggestions": 1,
            "state": "Undersized",
            "performance_utilization": {
                "cpu": 90,
                "memory": 97,
                "max_io": 0.314,
                "io_all": {
                    "xvda": 0.314
                }
            },
            "cloud_provider": "aws",
            "instance_type": "t2.micro",
            "idling_time": "19.70",
            "os": "RHEL 8.4",
            "report_date": "2022-03-23 00:00:00+00:00"
        }
    ]
}

Just thinking if we can do code refactoring (api dir) for endpoints whenever required? Should we consider in this PR or create another card for it?
api/v1/hosts.py#L121-L127
api/v1/hosts.py#L276
api/v1/call_to_action.py#L16

Just thinking if we can do code refactoring (api dir) for endpoints whenever required? Should we consider in this PR or create another card for it? api/v1/hosts.py#L121-L127 api/v1/hosts.py#L276 api/v1/call_to_action.py#L16

Yes, I am working on refactoring the existing query to fetch records from performance profile table.

One more change needed on query refactoring. We can remove distinct from here.
api/v1/call_to_action.py#L16

@kgaikwad Can we create a new file for test_garbage_collector.py and add a couple of relevant tests to the same?

@kgaikwad Can we create a new file for test_garbage_collector.py and add a couple of relevant tests to the same?

Yes, working on it - https://issues.redhat.com/browse/RHIROS-577.

@kgaikwad Rest of the changes look good to me. Thanks for the changes @kgaikwad!
Good stuff! :100: :+1:

Hello @nik @rchandra - Thank you for review and approval for historical data PR.
There are total 17 commits, doing squashing manually for few small commits so that one can perform rebase + merge instead squashing into single commit.

Hello @nik @RChandra - Thank you for review and approval for historical data PR. There are total 17 commits, doing squashing manually for few small commits so that one can perform rebase + merge instead squashing into single commit.

Done with squashing!

All changes approved, re-based then merged.


Add declaration map for source code viewing

While looking at declaration for withoutTrailingSlash because it was undocumented, it lead me to the d.ts file. This does not help at all for DX
https://www.typescriptlang.org/tsconfig#declarationMap

Thanks for the pr but this option has no effect on the dist build (using unbuild and rollup-plugin-typescript)


Payments - Selecting "Add PayPal.me" modifies the existing PayPal.me username

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

On a user with a existing Paypal.me username set up
Navigate to Payments
Click on add payment method
Click on Paypal option.

Expected Result:
The modal should say something like "Modify existing Paypal.me".
Actual Result:
Add Paypal.me button navigates the user to modify existing Paypal.me username.
Workaround:
User can add an edit the Paypal.me username so I don't think a workaround is needed.
Platform:

Where is this issue occurring?

Web
iOS
Android
Desktop App
Mobile Web

Version Number: 1.1.1-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Expensify/Expensify Issue URL:
Issue reported by: @Santhosh-Sellavel
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1632167181469900
View all open jobs on GitHub

Triggered auto assignment to @tylerkaraszewski (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

Should we just remove the option to add a paypal.me method if there already is one?

@tylerkaraszewski
Yup, I think we should remove the option to add a PayPal.me if there is one, and instead allow modifying the PayPal.me username by directly clicking the thing outlined in green:

cc @isagoico

@jasperhuangg  wont Add payment method option be weird now? Without any options?

Well just hide it if there are no options right?

Yes, correct we will just hide it.

Watch out! I have already removed paypal from these options in https://github.com/Expensify/App/pull/4177#issuecomment-917226851.
PR is under review thus this would be duplicate work. It was removed days ago  even before this issue was reported.

Watch out! I have already removed paypal from these options in #4177 (comment).

This comment is about not allowing wallet transfer to Paypal, not removing Paypal from Add Payment Methods.
@parasharrajat I just checked out your branch.  this issue is not handled in PR #4177, I verified it in look image below.

But add PayPal route is broken.  I see your PR is ready for review. Please fix this before it gets merged.
https://user-images.githubusercontent.com/85645967/134441850-507f01f2-659f-4c00-b024-daf0ec5606e8.mov
cc: @jasperhuangg

In the next comments I have asked question to either remove it or disable it. But either of those should be sufficient to cover this issue.
That PR is still in progress and I waiting to get answers and finish it.

@parasharrajat
I saw the follow up comments, remove paypal option question alone was not answered there.
So there is no clear answer regarding remove paypal option from add payment methods. Let's wait for @stitesExpensify to answer this question.

I think we should wait on this because otherwise we'll do some work that doesn't need to be done. We're about to merge a PR for adding a debit card which you can have unlimited of so we will never not have options in the "Add payment method" dropdown and therefore no need to hide it.

This comment is about not allowing wallet transfer to Paypal, not removing Paypal from Add Payment Methods.
@Santhosh-Sellavel is correct here. We still want paypal as an option here because you can send money from paypal, but you can't transfer money from your wallet to paypal.

I agree that the solution here is just to hide it from the dropdown when there is already a paypal.

Thanks @stitesExpensify for clarity. I agree with you here Let's wait for the PR to get merged.

@tylerkaraszewski Huh... This is 4 days overdue. Who can take care of this?

Does anyone want to take this? I"m assigned as triage and would like to hand off to someone with more knowledge on the subject.

I'll take it

thanks!

Posted!
Internal - https://www.upwork.com/ab/applicants/1447759095553306624/job-details
External - https://www.upwork.com/jobs/~01d69c9e6a77a717cd

just to confirm: I'll make the Upworks job and invite @Santhosh-Sellavel?

Yep. Thanks!

The solution for this issue has been :rocket: deployed to production :rocket: in version 1.1.11-1 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

https://github.com/Expensify/App/pull/5806

If no regressions arise, payment will be issued on 2021-11-05. :confetti_ball:

Paid in Upwork (happened to have this open), added $250 for reporting bonus and $250 for n6-hold bonus.  Thanks @Santhosh-Sellavel !

TY @mallenexpensify - I actually jumped on to pay this today, and was wondering why it disappeared from my Assigned list haha.

Welcome @jliexpensify , figured it was Saturday for ya so thought I'd take care of.


Move from coveralls to codecov

Closing this issue as it doesn't require to be tracked or even switched.


Mautic can't connect to server on localhost

You need to raise this upstream.
https://github.com/Lissy93/portainer-templates?tab=readme-ov-file#raising-issues


Make second tier of main menu visible on wide touch devices

The switch from menu button to horizontal menu with hover drop-downs occurs at 44em(704px). Many touch devices are wider. They can't hover to see second level.
Options

Show the drop-down on touch briefly before going to destination to give users a chance to tap on another item
Show drop-down on first tap and require another tap to go to location
Use modernizr to test for touch and use the menu button for all touch users

@jonraedeke Any interest in working on this?

Yep, still working on this one. Thanks for checking.
Sent from my iPhone

On Apr 12, 2015, at 12:32 PM, Tim Wood<EMAIL_ADDRESS>wrote:
@jonraedeke Any interest in working on this?
—
Reply to this email directly or view it on GitHub.

Here's the solution I came up with:
Detect touch events with Modernizr and repurpose the mobile menu for touch devices. Committed the styling and Modernizr module, enabled with dgc_deploy.

Great solution. Thanks.


helm: sort crd files by name

When validating the differences between deployed manifests, I've found that the output from VFS-embedded CRD files is not completely stable between different compilations of istioctl. In particular, the CRDs appear to be in different orders depending on the particular binary I use (or maybe something else at runtime). For non-CRD files, the output is sorted by filename, but the CRD files are not sorted.
This only becomes an issue when a chart has multiple CRD files. This occurs in Istio in the base chart. This appears to only happen occasionally, I've observed unstable ordering on several Istio release binaries.
This PR sorts the CRD files before writing them to the output strings.Builder to achieve stable output.
And to help us figure out who should review this PR, please
put an X in all the areas that this PR affects.
[ ] Configuration Infrastructure
[ ] Docs
[X] Installation
[ ] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure
Pull Request Attributes
Please check any characteristics that apply to this pull request.
[X] Does not have any changes that may affect Istio users.

@brianwolfe: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
c23ad34fb3eb5431ff37e6c714ea5ed0d8761c68
link
/test release-notes_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test release-notes_istio

In response to a cherrypick label: new pull request created: #28199


Include option to upload only new files

Add only_newer option.
Use like this:
pipeline:
  deploy:
    image: cschlosser/drone-ftps
    hostname: example.com:21
    secrets: [ ftp_username, ftp_password ]
    only_newer: true

This should fix #12

Maybe you could give it a try?

I tried the -e option as well and no luck.

Do you have any other idea?

I used all the flags. The -R was there before already but maybe it needs to be in this order so I added it twice. Also added the ignore time option

Sorry, for the delay. Do I still use the -e in the only_newer: option?

The only_newer: true results in -Rne --ignore-time to be added to the string

I might be a late to this post but I was looking at using drone to deploy php projects which do not require a build and only the changed files to be updated using FTP.
This plugin fits the purpose if the only-newer flag works.
by looking at the conversation above, I was just wondering how lftp detects which files are new or modified, maybe by the date-time?
upon reading the drone docs, drone creates a temporary directory and clones the repo which means all the files are always newly created, so can this be the reason that lftp might be uploading all the files again?

Thanks for the suggestion @hussainb ,
Yes, lftp uses the timestamp of the files to detect what changed.
A git clone keeps the timestamps correctly in sync with the remote repository.
This is not the cause of the problem.

Didn't know that!
Thanks!

If I can help to anyone with my experience, I was able to get this working using -Rn --ignore-time
The -e was not helpful in my case, because in remote server there are generated file that I dont want to delete in each deploy

just tried this PR and I nearly collapsed as after uploading all the files it started with deleting of my whole FTP :D this PR ignored my PLUGIN_DEST_DIR and used root. Or does "latest" use PLUGIN_DEST_DIR while "only-newer" uses dest_dir ?

This branch is quite out of date.
Did you merge it with master?

I only used .drone.yml with cschlosser/drone-ftps:only-newer .. would be really nice if it worked. Later I found out the FTP was nearly fully deleted but I had a backup so no data loss :)

The example configuration from the master readme no longer matches this branch.
I may be able to take a look at this in the next few days but we had problems getting this to work reliably so I'm not too hopeful right now.

Should be included in #31, hopefully.


Error handing issue when reconnecting with expired session token

Package: 0.15.9
class: HTTP.cs
method: public async Task Request
Conditions: using secure protocol only
Problem: In case of expired reconnection token, the error should return : "Reconnection token invalid or expired". But instead, it tries to use unsecure protocol and completely forgets about original error message and returns :  " Unexpected end of JSON input".
It would be nice to have this fallback optional or the original error.

Hi @guntarsbeetroot, thank you for reporting. This behaviour of switching from secure to insecure protocol must be removed soon. If you can send a PR I really appreciate it, I'll be able to check this out only next month I think.


Add hbase tableName to hbase plugin

Hbase tableName is very useful when we fast location the hbase problem. So we can record the tableName to the table trace.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.shuijing seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

@aalinyu
Hello, Could you give me permission to edit the PR?
Please check maintainer permissions
https://docs.github.com/en/github/collaborating-with-pull-requests/working-with-forks/allowing-changes-to-a-pull-request-branch-created-from-a-fork#enabling-repository-maintainer-permissions-on-existing-pull-requests

@emeroad
I have checked maintainer permissions,Do  you have  permissions to make changes on this PR by now?

Perhaps the master branch is protected.
I created a new PR.
https://github.com/pinpoint-apm/pinpoint/pull/8104


Update PQ fuzz tests

Resolved issues:
Makes progress toward https://github.com/awslabs/s2n/issues/2285 and https://github.com/awslabs/s2n/issues/1952
Description of changes:

PQ fuzz tests will now run whether or not PQ crypto is enabled. This is the desired behavior to ensure we are testing the higher level parsing/receiving/wrapper functions regardless of which low-level PQ KEM functions may be defined.

Because this update runs the PQ fuzz tests when PQ crypto is disabled, we no longer directly fuzz the low-level PQ KEM functions, instead just fuzzing the high-level wrappers. This is fine, as the fuzzer should still reach the crypto KEM functions through the wrapper when PQ is enabled.

Removes the S2N_NO_PQ ifdefs in the fuzz tests

Call-outs:
N/A
Testing:
How is this change tested (unit tests, fuzz tests, etc.)? Are there any testing steps to be verified by the reviewer?
Is this a refactor change? If so, how have you proved that the intended behavior hasn't changed?

This is a test change

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

When you merge this, you might want to try to make the commit message more descriptive. Maybe "Update PQ fuzz tests to run when PQ is not enabled"?

Will do

When you merge this, you might want to try to make the commit message more descriptive. Maybe "Update PQ fuzz tests to run when PQ is not enabled"?

Will do