pylint: Fix some newly reported issues

This PR fixes some newly reported pylint issues:
pylint 2.15.10
astroid 2.13.3
Python 3.9.10 (main, Jan 17 2022, 00:00:00)
[GCC 11.2.1 20210728 (Red Hat 11.2.1-1)]
************* Module keylime.db.verifier_db
keylime/db/verifier_db.py:10:0: R0901: Too many ancestors (9/7) (too-many-ancestors)
************* Module keylime.db.registrar_db
keylime/db/registrar_db.py:9:0: R0901: Too many ancestors (9/7) (too-many-ancestors)
************* Module keylime.migrations.versions.8c0f8ded1f90_convert_allowlists_to_ima_policies
keylime/migrations/versions/8c0f8ded1f90_convert_allowlists_to_ima_policies.py:47:11: E1123: Unexpected keyword argument 'bind' in constructor call (unexpected-keyword-arg)
keylime/migrations/versions/8c0f8ded1f90_convert_allowlists_to_ima_policies.py:48:4: E1120: No value for argument 'bind' in method call (no-value-for-parameter)
keylime/migrations/versions/8c0f8ded1f90_convert_allowlists_to_ima_policies.py:92:11: E1123: Unexpected keyword argument 'bind' in constructor call (unexpected-keyword-arg)
keylime/migrations/versions/8c0f8ded1f90_convert_allowlists_to_ima_policies.py:93:4: E1120: No value for argument 'bind' in method call (no-value-for-parameter)
************* Module keylime.migrations.versions.a72aec03d720_migrate_allowlists_to_separate_table
keylime/migrations/versions/a72aec03d720_migrate_allowlists_to_separate_table.py:44:11: E1123: Unexpected keyword argument 'bind' in constructor call (unexpected-keyword-arg)
keylime/migrations/versions/a72aec03d720_migrate_allowlists_to_separate_table.py:45:4: E1120: No value for argument 'bind' in method call (no-value-for-parameter)
keylime/migrations/versions/a72aec03d720_migrate_allowlists_to_separate_table.py:60:11: E1123: Unexpected keyword argument 'bind' in constructor call (unexpected-keyword-arg)
keylime/migrations/versions/a72aec03d720_migrate_allowlists_to_separate_table.py:61:4: E1120: No value for argument 'bind' in method call (no-value-for-parameter)
************* Module keylime.migrations.versions.4329e2d14944_associate_moved_allowlists_to_agents
keylime/migrations/versions/4329e2d14944_associate_moved_allowlists_to_agents.py:37:11: E1123: Unexpected keyword argument 'bind' in constructor call (unexpected-keyword-arg)
keylime/migrations/versions/4329e2d14944_associate_moved_allowlists_to_agents.py:38:4: E1120: No value for argument 'bind' in method call (no-value-for-parameter)

It looks like one of the bind  related issues is due to pylint reacting to this here in SQLAlchemy's sql/schema.py.
    @util.deprecated_params(
        bind=(
            "2.0",
            "The :paramref:`_schema.MetaData.bind` argument is deprecated and "
            "will be removed in SQLAlchemy 2.0.",
        ),
    )

https://docs.sqlalchemy.org/en/14/changelog/migration_20.html
Moving the parameter from Metadata() to reflect() seems to be a solution.

/packit retest-failed

/packit retest-failed


[Enhancement] Refactor Middleware

Jira Link:
Description
Optimize code line and algorithm for middleware. Create NodeControl class for providing Middleware class to process node marker that is controlling the joint manager.
Type of Change

[ ] Bugfix
[x] Enhancement
[ ] New feature
[ ] Breaking change (fix or feature that would cause the existing functionality to not work as expected)

How Has This Been Tested?

[ ] New unit tests added.
[ ] Manual tested.

Checklist:

[ ] Using Branch Name Convention

feature/JIRA-ID-SHORT-DESCRIPTION if has a JIRA ticket
enhancement/SHORT-DESCRIPTION if has/has no JIRA ticket and contain enhancement
hotfix/SHORT-DESCRIPTION if the change doesn't need to be tested (urgent)

[ ] I have commented on my code, particularly in hard-to-understand areas.
[ ] I have made the documentation for the corresponding changes.

I'm so sorry @threeal for creating this branch rather than use the branch that you've provided for all this change.


[Improvement] add alert script path check

Purpose of the pull request

add alert script path check.

Brief change log

dolphinscheduler-alert/dolphinscheduler-alert-plugins/dolphinscheduler-alert-script/src/main/java/org/apache/dolphinscheduler/plugin/alert/script/ScriptSender.java

Verify this pull request

Added UT to verify the change.

@caishunfeng @ruanwenjun @SbloodyS What about we deprecate alert script plugin?

@caishunfeng @ruanwenjun @SbloodyS What about we deprecate alert script plugin?

Not necessarily in next release, maybe sometime in the future.

@caishunfeng @ruanwenjun @SbloodyS What about we deprecate alert script plugin?

LGTM, user can add their own plugins if needed.


Citation on the CANVAS locus page not being converted to a number

[pmid:38627134] isn't being converted to a numerical citation.
It looks like it's correctly formatted in STRchive-loci.json in both the details and the references, but it's not present in STRchive-citations.json.
Ideally, the fallback should still produce a numerical citation. And then I also need to figure out why it's missing from STRchive-citations.json.

I think it's because it doesn't have an @, it needs the @, alas

created a pull request

Duh! Thank you. I missed that.


Providing a default value for selection parameter causes view to be unscrollable

Providing anything except nil as the default value for a selection binding, will cause the view to be non scrollable until the user taps another date.

@bstillitano Sorry for the slow response.
I tried to reproduce the issue you described. See below. But all versions work fine (tested with version 2.1.0 on iOS 17.5)
struct ContentView: View {
    @State private var selection: DateComponents?

    var body: some View {
        CalendarView(selection: $selection)
    }
}

struct ContentView: View {
    @State private var selection: DateComponents? = DateComponents(year: 2024, month: 8, day: 16)

    var body: some View {
        CalendarView(selection: $selection)
    }
}

struct ContentView: View {
    @State private var selection: DateComponents?

    var body: some View {
        CalendarView(selection: $selection)
            .onAppear {
                selection = DateComponents(year: 2024, month: 8, day: 16)
            }
    }
}

Would you be able to share a code sample with me that causes the scrolling issues you're experiencing?

Thank you @lishuhao! This demonstrates the issue nicely. I'll get this fixed.

@lishuhao @bstillitano This issue should now be fixed in version 2.1.2.


Switch to using a team assignment for changelogs

The first cut of the codeowners specified each reviewer individually. This has lead to a large number of reviewers on every PR.
To try and reduce this I've updated many of the sections with GH Teams instead.  This will allow us to manage who is added based on review assignment which will automatically pick 1-2 people (can be configured) from each team to be added to a PR.
I setup the @imodeljs/admins Team to round robin 2 assignees and then it will be up to those 2 people to either review/approve or assign it to the correct person to review a change.
A couple of things to keep in mind;

Just because someone in the team is not added as a reviewer does not mean they cannot review and approve
Not everyone on the team will be notified of the PR, only the individuals add (this can be configured)

The following teams were already in place so I used them initially (we can always create more if necessary),

@imodeljs/devs
@imodeljs/admins
@imodeljs/display
@imodeljs/presentation
@imodeljs/ui

Note: I have only configured the round robin style assignment for @imodeljs/admins, if anyone else wants to configure it and doesn't know how please let me know.

@mgooding @NancyMcCallB @DanEastBentley @bsteinbk @grigasp, please take a read through the above since it directly impacts how reviewers work and you're member and/or admins of some of the teams.

The comment and the team mentioned don't match

The comment and the team mentioned don't match

@scsewall based on the documentation for adding a team as a reviewer, I thought that if I added the high level "devs" team and just set it so no one gets notified it would work.  However, I did some testing in a test GitHub Org and it doesn't seem to be working the way I want it to be.  I'll do some more testing and figure out a different way since it's annoying the way it's currently setup.

The comment and the team mentioned don't match

@scsewall just took another swing at it.  Mind taking a look?

I removed myself as a code owner from bentleyjs-core and ui. I hope @imodeljs/ui team don't mind having a look at our ui-related changes from time to time.


Added regex module option.

Added regex module option (optional alternative to re module).
I believe we should also add a test configuration to make sure all tests pass with pip install lark-parser[regex], but was unsure of where to add it in the tox.ini file; please do let me know if you have any pointers. I could then also add a conditional test with a grammar containing a regex module-specific terminal definition that only activates when the [regex] optional dependency is enabled.
Please let me know what you think!

Will close #590.

Well, it's good that the tests pass.
If you want to add regex-specific tests, the place to do it is in the tests folder. Just don't run the tests if the import fails (look at the nearley test).

@erezsh I think what @julienmalard means that we add an additional pull-request check that also installs the regex modules.

@MegaIng Yes, I think that that is what I meant. I was referring to adding a test matrix option that runs all tests with regex installed, so that we can check that everything works when regex is used instead of re (the tests run now run without regex installed, so, effectively, with no changes as compared to the master branch).

If regex already have tests that ensure that it's fully backwards-compatible with re, I'm not sure there's a point of also doing those tests on our end. At least not more than once in a long while.

All right, sure then! Should I include regex module-specific tests, or is all fine?

Yes, you should include module-specific tests.

I have tried adding tests as test_regex.py. I do think that I need help for a few points:

I am not too sure how to tell tox to install regex. I added a regex-requirements.txt file and also
There is a problematic line in utils.py: sre_parse.parse(regexp).getwidth(). The problem is that sre_parse will not accept character classes from regex (the \w bugfix works a charm, though!). The effect of that, for the moment, is that any grammars including character class regexes will fail to compile (which at least is not a regression from current behaviour).
I wasn't sure how to make sure the test_regex.py tests are run. Is including the file in the tests directory enough, or do I need to specify it somewhere?

Many thanks!

I'm worried about adding this as the default, as users might experience performance degradation. It would be much better, imho, if this was opt-in rather than "always on"

Hello,
Sure, I think I could change that quickly enough. Do you think it would be best to have it as a global option, e.g.,
import lark
from lark import Lark

lark.use_regex = True
parser = Lark('my grammar.lark', 'lalr')

Or as an option specific to each parser:
from lark import Lark
parser = Lark('my grammar.lark', 'lalr', regex=True)

Option #2 sounds good.

That looks good. Just make sure that the tests pass.

Thanks! It was a missing tox dependency for regex. Testing it again now.

Looks like this will take a bit of trial and error! Do you know how I can tell tox to install regex prior to running tests? All works well locally, but not on GitHub builds. Thanks!

See .github/workflows/tests.yml
Basically copy whatever we did for nearley-requirements. Maybe we can even merge them (for the tests)

Thanks! I updated stubs and the README to match changes. Please let me know if all was done well!

There is a reason that all the parser tests sit in test_parser.py. There is an automated process there that runs each test for every parser and lexer. For example, your tests fail when parser="lalr".
Put your tests there and make sure that they pass.
Also, you forgot to update tox.ini
And lexer.py still imports regex for some reason, although it shouldn't (and probably shouldn't import re either)

Thanks! Hope this works. I changed the tests, fixed the problems with lalr, and updated tox.ini. I also removed the regex import from lexer.py, but line 48 still requires re, so I left that one in.
Please let me know how it looks now!

Notice that pypy3 fails for some reason. Any chance you can figure out why?

Hmm looks like most of the tests failed..

That is odd! It seems that pypy3 failed and that the rest aborted for some reason (without printing out error messages). Is it possible that the pypy3 failure caused the rest to stop running?
I am not sure what problems is occuring with pypy3 (all runs well locally with regular python), so I'll unfortunately probably have to debug remotely here with lots of commits and print statements...I hope you wouldn't mind?

It shouldn't be that difficult to install - https://www.pypy.org/download.html#python-3-6-compatible-pypy3-6-v7-3-1

I think it worked!

Congrats on a great PR 👍

Many thanks for your help and guidance throughout the process!


Replace broken device API

Suppose my device dies and I buy another identical device. In my current home system you would use the "Replace Device" button to copy the state of the broken device into the new device.  So how do you save the state of a Matter device so that you can restore it later?  The key part here is saving multiple fabrics and device IDs and then restoring them. But there is a lot of other state - bindings, scenes, subscriptions, default values, etc. All per fabric.  Another use of this is when the device is misbehaving and you factory reset it, and then restore it.
Also need to track when this global device state changes to know when the state has to be backed up again. My current system maintains a log of past states and I can roll back to previous states for the entire system. This is really useful if you try building a new, complex automation that doesn't work out. You can just roll back to the point before you started changing things. Right now I'd settle for just a 'Replace Device' button with Matter.

The key part here is saving multiple fabrics and device IDs and then restoring them.

Where do you save the state? Matter talks only about local control and hence there may be some devices that do not have internet connectivity at all.

A controller would save the state. ie the app with the "Replace Device" button.
I have this button in my existing home automation system and I have used it at least 30 times to replace dead devices. Consider how much of a pain it is to replace a dead device without it. You will have to manually recommission back onto each fabric and then individually rebuild the device state for each fabric. Very user unfriendly.
Since Matter has punted on this, the vendor apps have to implement it.

I also use that button when my devices are behaving flaky.  I manually factory reset them, then use the 'Replace Device' button to restore their state.  I think this is undoing corruption in the flash.

Since Matter has punted on this, the vendor apps have to implement it.  ... as in Espressif makes me a nice vendor API I can call to get the device state as a blob, and another API which I can use to restore it.  And some way to know if it has changed since last save call.

If a device is a part of multiple fabrics, then this implies that the device will have to share information of the other fabrics (like operational cert, private key) to the controller of some other fabric, which doesn't seem right?

The blob the device passes back can be encrypted.
The people designing Matter are laser focused on the "Alexa, turn the light off" use case with banker level security.  They are not paying any attention to the problems they are causing the owners of the devices.  For example they have ignored scenes which are probably the number one feature in a real home automation system.  And one of my big complaints, they are ignoring 3-way light switches which is probably a fifth of all light switches.  I can list a hundred things they are ignoring. And they put WAY too much effort into security.
Multi-admin is not a management system, it just creates a VPN for each controller allowing each controller to completely ignore any other controllers. Consider the impact of this on the home owner. The home owner design scenes, but given the way multi-admin is designed those scenes can't be shared among admins. The home owner is going to have to reenter them into each controller.  What about automations?  Again they can't be shared.
Your objection is correct, the problem is that Matter has not planned for use cases as simple as "Replace Device".
Here's another question for you. Has Matter tested opening a commissioning window and going through a minute of setup transactions while another controller is hitting the same device with normal commands?

The blob the device passes back can be encrypted.

I had thought of this. But then again, which key do we use for encryption? If it is specific to the device, then how and with whom do we share this?

Here's another question for you. Has Matter tested opening a commissioning window and going through a minute of setup transactions while another controller is hitting the same device with normal commands?

This can be tested

The only key you have available is the key for the controller doing the backup.

So, the same problem, multiple ecosystem data with the controller now.

As per the discussion above, I don't see a solution to this for now.


Measurements don't wok with Microscopy Slides

Before Creating an issue

Are you running the latest version?

I checked that the behavior is substantially the same for 3.7.1

Are you reporting to the correct repository?

Not sure

Did you search existing issues?

Yes, couldn't find anything relevant under SM, Slide or Microscopy
Bug Report
Describe the Bug
When a SM image is displayed (see for instance) measurements don't work.
What steps can we follow to reproduce the bug?
See https://viewer.ohif.org/viewer/1.2.392.200<IP_ADDRESS>.1.2.799008771.3960.1519719403.819

:warning: Reports we cannot reproduce are at risk of being marked stale and
closed. The more information you can provide, the more likely we are to look
into and address your issue.

This is less of a bug and more of a feature request. We currently do not have support (or financing) for this feature short or long-term. If you're interested in seeing whole slide microscopy use cases expanded, I recommend reaching out to an OHIF consultant or working with the community to create the features you need in an OHIF extension.


ZeroDivisionError

When generating thumbnail for a small image (1x54 px) sorl raises ZeroDivisionError. For some reason PIL and pgmagic thinks that image has 0x54 dimensions. Even if the problem with an image i think calculate_scaling_factor must prevent such situations.
Exception Type: ZeroDivisionError
Exception Value:    integer division or modulo by zero
sorl/thumbnail/engines/base.py in calculate_scaling_factor

...
54     factors = (geometry[0] / x_image, geometry[1] / y_image)
...
y_image 16
geometry    (16, 16)
self    <sorl.thumbnail.engines.pil_engine.Engine object at 0xacd1ccc>
crop    False
x_image 0
options
{'colorspace': 'RGB',
'crop': False,
'cropbox': None,
'format': 'JPEG',
'image_info': {'Software': 'Adobe ImageReady', 'gamma': 0.45},
'padding': False,
'padding_color': '#ffffff',
'quality': 95,
'rounded': None,
'upscale': True}

I've experienced the same error. It disappeared after I made an update from Pillow==3.0.0 to Pillow==4.0.0.


Error: undefined method `ip' for nil:NilClass

OR "Error: Invalid argument"
I'm not a ruby guy, more of a JavaScript/PHP guy. So I'm not too excited to dig deeper here...
but it seems there is a simple semantic error for most of the commands.
The only thing that works (works great!)  is --on and --off.   Everything else results in a syntax error.
ledenet-ufo <IP_ADDRESS> --status
Error: Invalid argument
C:/Ruby22-x64/lib/ruby/gems/2.2.0/gems/bindata-2.4.0/lib/bindata/io.rb:31:in pos' C:/Ruby22-x64/lib/ruby/gems/2.2.0/gems/bindata-2.4.0/lib/bindata/io.rb:31:in seekable?'
C:/Ruby22-x64/lib/ruby/gems/2.2.0/gems/bindata-2.4.0/lib/bindata/io.rb:23:in initialize' C:/Ruby22-x64/lib/ruby/gems/2.2.0/gems/bindata-2.4.0/lib/bindata/io.rb:240:in initialize'
C:/Ruby22-x64/lib/ruby/gems/2.2.0/gems/bindata-2.4.0/lib/bindata/base.rb:143:in new' C:/Ruby22-x64/lib/ruby/gems/2.2.0/gems/bindata-2.4.0/lib/bindata/base.rb:143:in read'
C:/Ruby22-x64/lib/ruby/gems/2.2.0/gems/bindata-2.4.0/lib/bindata/base.rb:21:in read' C:/Ruby22-x64/lib/ruby/gems/2.2.0/gems/ledenet_api-1.4.2/lib/ledenet/api.rb:116:in block in send_packet'
C:/Ruby22-x64/lib/ruby/gems/2.2.0/gems/ledenet_api-1.4.2/lib/ledenet/api.rb:142:in socket_action' C:/Ruby22-x64/lib/ruby/gems/2.2.0/gems/ledenet_api-1.4.2/lib/ledenet/api.rb:112:in send_packet'
C:/Ruby22-x64/lib/ruby/gems/2.2.0/gems/ledenet_api-1.4.2/lib/ledenet/api.rb:130:in request_status' C:/Ruby22-x64/lib/ruby/gems/2.2.0/gems/ledenet_api-1.4.2/lib/ledenet/api.rb:20:in status'
C:/Ruby22-x64/lib/ruby/gems/2.2.0/gems/ledenet_api-1.4.2/bin/ledenet-ufo:156:in <top (required)>' C:/Ruby22-x64/bin/ledenet-ufo:23:in load'
C:/Ruby22-x64/bin/ledenet-ufo:23:in <main>
PS C:\Users\Noah\downloads> ledenet-ufo --on -r 200 -g 0 -b 255 --warm-white 0 --status
Error: undefined method `ip' for nil:NilClass
C:/Ruby22-x64/lib/ruby/gems/2.2.0/gems/ledenet_api-1.4.2/bin/ledenet-ufo:130:in <top (required)>' C:/Ruby22-x64/bin/ledenet-ufo:23:in load'
C:/Ruby22-x64/bin/ledenet-ufo:23:in <main>
Any ideas? :-)
(using window 10 and Ruby 2.2 and also tried with 2.3.x )

Ah, yeah. I've heard that other people have had trouble with this library on Windows.
The second problem you're seeing sounds like it's not finding a device through discovery. There should be better error handling around that in the script.
The first one unfortunately seems closer to a fundamental incompatibility with Windows. Seems like it's nested deep in the library I used to define packet structures (bindata).
I'm burning most of my project time on a different effort right now, but I'll try to poke at this when I get time.

  Thanks, hope you can find the issue.


quick and dirty custom category template

@timbeardshear Use this to test custom site category templates
Create view files at app/views/categories/templates/:site.slug/:category.slug
Example: A custom template for the GRIT "Insight" category would be stored at app/views/categories/templates/grit/insight.html.slim

This looks good to me. I'm not sure why the error, it looks like it is coming from elasticsearch.

@jesilz Thanks. What's the best way to get this up on staging at the same time as my updates on the "grit_updates" branch? Can this be merged into master?

@timbeardshear it looks like you merged this into your Grit branch. If that's the case, can we close and delete this branch?

@jesilz Yes, I think this branch can be removed.


Query strings should be modeled as a multimap

As indicated by the Wikipedia page Query string:

While there is no definitive standard, most web frameworks allow multiple values to be associated with a single field (e.g. field1=value1&field1=value2&field2=value3).

And indeed, many web frameworks I have used adopt this approach:

Django: https://docs.djangoproject.com/en/3.2/ref/request-response/#django.http.QueryDict.getlist
Starlette: https://www.starlette.io/requests/#query-parameters
nodejs/querystring: https://nodejs.org/api/querystring.html#querystringparsestr-sep-eq-options

Therefore, I suggest itty-router follow the same convention.
Currently, itty-router models query strings as a Obj:
https://github.com/kwhitley/itty-router/blob/e8e76c9be5496ce2494743fb20dff802c41eb176/src/itty-router.d.ts#L22
where Obj is actually a map from some string to some string:
https://github.com/kwhitley/itty-router/blob/e8e76c9be5496ce2494743fb20dff802c41eb176/src/itty-router.d.ts#L1-L3
I suggest introducing MultiObj as the data model of query strings:
export type MultiObj = {
    [propName: string]: string | Array<string>
}

I'd like to help if you @kwhitley are interested in this :)

Would it not be better to stick to web standard APIs, since CF Workers/itty already rely on Request, Response etc? The URLSearchParams interface is specifically designed for this:
let query = new URLSearchParams("field1=value1&field1=value2&field2=value3");

query.get("field2"); // "value3"
query.get("field1") // "value1" (picks the first)
query.getAll("field1"); // ["value1", "value2"] (array of all matches)
query.getAll("field2"); // ["value3"] (always an array for type consistency)

for (let [name, value] of query) {
  console.log(name, value);
}
// field1 value1
// field1 value2
// field2 value3

Well folks great point you've brought up... but a couple issues with this...

The option @queensferryme suggests would be non-standard, but technically compatible with the existing API, thus probably not require a major version bump.  The downside is, it would also add a chunk of code to the code-golfed itty to support this.  In this case, I'd recommend middleware to do this for you (certainly for now anyway), as you can still access the request.url yourself and write over the convenience object request.query that itty creates for you.

I do agree with @oliverjam re. sticking to web standards as much as possible, although I didn't do that with the original itty as I was trying to more closely mirror some of the nice/light express API.  The problem with switching to this approach, while adding essentially no characters (nice!), is that it definitely is a breaking change.

I think an easier short term answer is to add an upstream middleware to itty-router-extras that tackles one of the above approaches, with could be implemented like this in your code:

import { Router } from itty-router
import { withQuery } from 'itty-router-extras'

const router = Router()

router
  .all('*', withQuery)
  .get('/foo', ({ query }) => {
    // query now has altered shape
  })

I'd be happy with the opt-in middleware approach.
Alternatively you could leave query as is (and maybe deprecate for removal in a future major release), then add a search or searchParams property with the new searchParams interface. That's what it's called for the web standard URL object (new URL("blah.com?test=5").searchParams). I guess that would add precious bytes though 😅

So...where are we on this?

I believe accepting PR 105 -- https://github.com/kwhitley/itty-router/pull/105 -- is the correct approach to giving developers access to the spec-compliant searchParams.
I don't see the risk in continuing to mutate the request to have the itty-specific params property. If developers want to disregard the non-compliant params, they can do so. Developers can also use JSDoc or Typescript to specify the request type as a standard Request parameter to their handler functions, easy peasey!
From a 'correctness' standpoint, I have an itch to see the params removed in a major version, but I think it makes more sense to treat it as legacy. There are other non-standard properties that Itty adds, this seems appropriate in that context.
These are just my two cents, of course. Thanks!

I believe accepting PR 105 -- #105 -- is the correct approach to giving developers access to the spec-compliant searchParams.

I see the allure, but nothing about itty is spec-compliant.  It (intentionally) doesn't require a real Request, and nor does it just spit you back out a native Request.  It embeds helpers (e.g. params, query) with a single purpose in mind:

Make downstream code lighter.

This does, of course, mean that it won't always follow spec or even traditional paths.  It's great when it can, but if spec = verbose, I change the internal path.  In the end, I want route handlers to be as lightweight and human-readable as possible, even if that means breaking some conventions.
Now, to the original point of this issue, I see the point, and I think I can have "query" behave in the intended way.  That was more of an oversight from myself than an intended effect, and as it would only "fix" people's code that had previously been affected by said pattern, I wouldn't classify it as a major bump - as in, no one should currently be relying on the unexpected way of it discarding multiple values on the same param, because that would really just not make sense.
Yes it'll add some bytes, but it's about to grow a tiny bit anyway as I wrap the itty-router-extras into the core lib (all for the sake of a single, simple solution to "tiny code").  Definitely tired of seeing the raw Response building code in the itty docs, as well as tutorials/blogs around the web.  Itty was never intended to be used as a standalone, but was released as such to achieve the code-golfing-esque ~400bytes (at the time).  In the end, that was a useless vanity metric, and it's time I made it more generically useful to serve the broader audience.

From a 'correctness' standpoint, I have an itch to see the params removed in a major version, but I think it makes more sense to treat it as legacy. There are other non-standard properties that Itty adds, this seems appropriate in that context.

request.params is a familiarity thing... and is in not only Express, but virtually all Express-inspired routers (itty included)... it references route params, not searchParams.

... it references route params, not searchParams.

Slip of the keyboard there, thanks for correctly reading into what I meant to say! Awesome feedback, this is helpful as an 'itty manifesto.' For example, I didn't know itty intentionally avoided Request objects.

This will be included in the next major release :)

Closing this, as #131 addresses it :)


Crypted Titel of OSCM Administration page

OSCM Titel gets overwritten "by Enterprise Service Catalog Manager"

@uhu133
This looks weird indeed. Where does this is an enterprise branding source from? Did you install OSCM or ESCM containers? Or mixed both?  Does it look same with private browsing? I just think, it might be also a browser caching effect.

no branding source
out of the box oscm:latest
.env:
IMAGE_DB=servicecatalog/oscm-db:latest
IMAGE_CORE=servicecatalog/oscm-core:latest
IMAGE_APP=servicecatalog/oscm-app:latest
IMAGE_BIRT=servicecatalog/oscm-birt:latest
IMAGE_BRANDING=servicecatalog/oscm-branding:latest
IMAGE_INITDB=servicecatalog/oscm-initdb:latest
IMAGE_PROXY=servicecatalog/oscm-proxy:latest
IMAGE_HELP=servicecatalog/oscm-help:latest

It was a cache issue - closed


SQL Saturday Atlanta 2024

Hello,
Requesting new event to be set up for Atlanta 2024.  Event specifics are:
Event Title | SQL Saturday Atlanta 2024
Event Date | April 20, 2024
Event Time | 8:00 AM
Event Capacity | 700
CFP URL | https://sessionize.com/sql-saturday-atlanta-2024/
CFP End Date | February 10, 2024
Event Location | Innovation Academy, 125 Milton Ave, Alpharetta, GA 30009
Have also filled out Excel workbook and attached to this issue with additional details. Please let me know if you need this information in another format.
-Rob Volk

No XLSX attached. Test site here: https://sqlsaturday.com/2024-04-20-sqlsaturday1072/
Feel free to attach here or email<EMAIL_ADDRESS>

Apologies, I attached it to this reply.
-Rob Volk
On Mon, Nov 6, 2023 at 1:57 PM Steve Jones @.***> wrote:

No XLSX attached. Test site here:
https://sqlsaturday.com/2024-04-20-sqlsaturday1072/
Feel free to attach here or email @.***
—
Reply to this email directly, view it on GitHub
https://github.com/sqlsaturday/sqlsatwebsite/issues/263#issuecomment-1795946157,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AEA36QA753YEXQJDDMAKXITYDEXJNAVCNFSM6AAAAAA66UEVSCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTOOJVHE2DMMJVG4
.
You are receiving this because you authored the thread.Message ID:
@.***>

Trying attachment one more time, will also try sending via other means.
Our Call for Speakers doesn't open until November 12, so no need to publish
before then.
Thanks.
-Rob Volk
On Tue, Nov 7, 2023 at 11:38 AM Steve Jones @.***>
wrote:

Hmm, I don't see it. email it please. Let me know as well when you want
this to go live.
—
Reply to this email directly, view it on GitHub
https://github.com/sqlsaturday/sqlsatwebsite/issues/263#issuecomment-1799140759,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AEA36QBNVOWY26OGYDS5I6DYDJPXRAVCNFSM6AAAAAA66UEVSCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTOOJZGE2DANZVHE
.
You are receiving this because you authored the thread.Message ID:
@.***>

Updated and live based on the XLS. If you need changes, please feel free to reach out. I'll post the CFS in a few places.

event complete


CORE-8700: Combined Worker Configurable MessageBus

Update combined-worker build configuration file to allow switching the
message bus implementation library dependency through project
properties instead of requiring manual updates to the file itself.

I've approved under the assumption the instructions work (which I haven't actually tried).


performance fix

Description

[!TIP]
Add a TL;DR when the description is longer than 500 words or extremely technical (helps the content, marketing, and DevRel team).
Please also include relevant motivation and context. List any dependencies that are required for this change. Add links to Notion, Figma or any other documents that might be relevant to the PR.

Fixes #Issue Number
or
Fixes Issue URL

[!WARNING]
If no issue exists, please create an issue first, and check with the maintainers if the issue is valid.

Automation
/ok-to-test<EMAIL_ADDRESS>:mag: Cypress test results

[!IMPORTANT]
🟣 🟣 🟣 Your tests are running.
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/11653827896
Commit: a5b03607d4fb6b170ccf789d9aaf72e362dfc1d0
Workflow: PR Automation test suite
Tags: @tag.All
Spec: ``
Sun, 03 Nov 2024 18:48:49 UTC

Communication
Should the DevRel and Marketing teams inform users about this change?

[ ] Yes
[ ] No

Summary by CodeRabbit

Bug Fixes

Improved state management by preventing unnecessary updates to loading entities, enhancing app performance.

Refactor

Updated the loadingEntitiesReducer to include an equality check for loading entities before state updates.

/ci-test-limit

/ci-test-limit

/ci-test-limit

/ci-test-limit

/build-deploy-preview skip-tests=true


Disable Slider Ribble

I wanted to disable ribble on the Slider component.  Using #13805 PR will not prevent the ribble.

[x] This is not a v0.x issue.
[x] I have searched the issues of this repository and believe that this is not a duplicate.

Expected Behavior 🤔
This should disable the ribble when applied to the root component.
const theme = createMuiTheme({
  props: {
        // Name of the component ⚛
        MuiButtonBase: {
          // The properties to apply
        disableRipple: true, // No more ripple, on the whole application 💣!
      },
    },
    transitions: {
      // So we have `transition: none;` everywhere
      create: () => 'none',
    }
  })

Current Behavior 😯
The only way i could disable the ribble was to override the slider theme.
const theme = createMuiTheme({
  overrides:{
    MuiSlider:{
      thumb: {
        '&$focused, &$activated, &$jumped, &:hover':{
          boxShadow:'none',
        }
      }
    }
  }
})

Examples 🌈

Context 🔦
Is there is another way of disabling the ribble for the slide?

The Slider doesn't have a ripple. I'm guessing you are talking about the pressed shadow? The only way to disable that is to override the boxShadow.

@joshwooding yeah you are right. Do you know any way to disable the boxShadow for all buttons?

@crazywire  Sounds like you already solved this in your Current behavior example. What do you mean by "all buttons"?

@eps1lon I mean how do you disable the boxShadow for all button elements. I tried this but it is not working.
const theme = createMuiTheme({
  shadows = ['none']
  })

You were already on the right track in your initial post. Just use a similar approach for for the other button components.


OCR0046: Adding ligature replacement for stack with Tibetan vowels glyphs and fine tune the font.

Description:

We have Derge font with single variant of each glyphs, in the font we have   ེ    ོ      ི  as glyphs and these glyphs don't have a ligature replacement for their respective ligature. They are being used as individual glyphs.
This is creating an issue where in the font, the glyphs for    ེ    ོ      ི are not perfecting aligned with the tibetan consonants and also there is no variation in these glyphs.

Implementation:

in order to solve this we have to replace the stacks with    ེ    ོ      ི, with their respective ligatures. so that the vowel glyphs will be aligned with their consonants and we could have different variation of vowel glyphs.

in this image the glyph for   ོ   is not properly aligned with its consonants.

Subtask:

[x] write a script to extract all the ligature with the vowels glyphs
[x] Check if the ligature are present or scan the OPF E-text if they are not present
[ ] Modify the pipeline for font creation by adding ligature replacement rule for these stacks
[ ] Fine-tune the font when all the stacks and glyphs have been replaced.

Completion Criteria:
To obtain a font with ligature replacement for stacks with the Tibetan vowel glyphs.

@ta4tsering kindly review this card as per discussion

Img.1: Pecha Image of first page of Derge Kangyur

Img.2: Text created from E-text using generated Derge Font

0F90 | ྐ | Tibetan Subjoined Letter Ka
0F91 | ྑ | Tibetan Subjoined Letter Kha
0F92 | ྒ | Tibetan Subjoined Letter Ga
0F93 | ྒྷ | Tibetan Subjoined Letter Gha
0F94 | ྔ | Tibetan Subjoined Letter Nga
0F95 | ྕ | Tibetan Subjoined Letter Ca
0F96 | ྖ | Tibetan Subjoined Letter Cha
0F97 | ྗ | Tibetan Subjoined Letter Ja
0F99 | ྙ | Tibetan Subjoined Letter Nya
0F9A | ྚ | Tibetan Subjoined Letter Tta
0F9B | ྛ | Tibetan Subjoined Letter Ttha
0F9C | ྜ | Tibetan Subjoined Letter Dda
0F9D | ྜྷ | Tibetan Subjoined Letter Ddha
0F9E | ྞ | Tibetan Subjoined Letter Nna
0F9F | ྟ | Tibetan Subjoined Letter Ta
0FA0 | ྠ | Tibetan Subjoined Letter Tha
0FA1 | ྡ | Tibetan Subjoined Letter Da
0FA2 | ྡྷ | Tibetan Subjoined Letter Dha
0FA3 | ྣ | Tibetan Subjoined Letter Na
0FA4 | ྤ | Tibetan Subjoined Letter Pa
0FA5 | ྥ | Tibetan Subjoined Letter Pha
0FA6 | ྦ | Tibetan Subjoined Letter Ba
0FA7 | ྦྷ | Tibetan Subjoined Letter Bha
0FA8 | ྨ | Tibetan Subjoined Letter Ma
0FA9 | ྩ | Tibetan Subjoined Letter Tsa
0FAA | ྪ | Tibetan Subjoined Letter Tsha
0FAB | ྫ | Tibetan Subjoined Letter Dza
0FAC | ྫྷ | Tibetan Subjoined Letter Dzha
0FAD | ྭ | Tibetan Subjoined Letter Wa
0FAE | ྮ | Tibetan Subjoined Letter Zha
0FAF | ྯ | Tibetan Subjoined Letter Za
0FB0 | ྰ | Tibetan Subjoined Letter -A
0FB1 | ྱ | Tibetan Subjoined Letter Ya
0FB2 | ྲ | Tibetan Subjoined Letter Ra
0FB3 | ླ | Tibetan Subjoined Letter La
0FB4 | ྴ | Tibetan Subjoined Letter Sha
0FB5 | ྵ | Tibetan Subjoined Letter Ssa
0FB6 | ྶ | Tibetan Subjoined Letter Sa
0FB7 | ྷ | Tibetan Subjoined Letter Ha
0FB8 | ྸ | Tibetan Subjoined Letter A
0FB9 | ྐྵ | Tibetan Subjoined Letter Kssa

img.3 Fixed vowel displacement for derge font

Tibetan Scripts

There are 30 tibetan consonants and 4 vowel marks
Tibetan consonants can be written as consonants or in other forms such as Superscript or Subscripts
When constants are written as superscripts or subscripts, or with vowel letters, there are known as Ligatures
The image is a basic representation of ligatures structure.

Ligatures
-When creating fonts, we have ligature replacement. when certain letters are typed in sequence according to their unicode value, their respective ligature will be replaced.
-In font creation, the superscript vowels (   ི    ོ     ེ) are independent of the glyphs, meaning they don't require ligature replacement as they will sit on top of whichever glyphs it is typed with. On the other hand the subscript vowel ( ུ ) is heavily dependent on the glyphs and require ligature replacement.
-So, If we were to introduce ligature replacement for the superscript vowel, it would require us to crop a whole lot of extra glyphs with all the combination of the above structure.
Tibetan Glyph Count with vowel with 3 superscripts vowels
Consonants
30 consonants: 30 x 3 = 90 glyphs (all the glyphs for this are already present)
Superscripts
ར (12 letters): 12 x 3 = 36
ལ (10 letters): 10 x 3 = 30
ས (11 letters): 11 x 3 = 33
Total superscripts glyphs = 99 glyphs
Subscripts
ཡ (7 letters): 7 x 3 = 21
ར (13 letters): 13 x 3 = 39
ལ (6 letters): 6 x 3 = 18
ཝ (16 letters): 16 x 3 = 48
Total Subscripts glyphs = 126 glyphs
Combination of super scripts and subscripts
རྐྱ་ རྒྱ་ རྨྱ་ སྐྱ་ སྒྱ་ སྤྱ་ སྦྱ་ སྨྱ་ སྐྲ་ སྒྲ་ སྤྲ་ སྦྲ་ སྨྲ་ སྣྲ་ གྲྭ་ དྲྭ་ ཕྱྭ་ རྒྭ་ རྩྭ.
19 glyphs x 3 = 57 glyphs
glyphs required for superscript vowels = 372 glyphs
we already have 90 glyphs
Total Glyphs required = 282 glyphs

I just tried and don't get the vowels at the right place.

Can you add versioning tags to the font names? Both the file name and inside the font, this way we can be sure we don't have miscommunication.

@ngawangtrinley can you try this
https://github.com/OpenPecha/create-font-from-glyph/tree/feature/font-from-scratch/fonts/derge_font

@10kalden if this ttf is the one that you send me then, it is the same one that @ngawangtrinley has tested.

The font requires several adjustments as discussed yesterday

reduce the spacing between lines to match that of Pecha
fix vowel placements for  ི
baseline for characters ཙ ཚ ཛ
check glyphs which showing unnecessary strokes due annotation
fixed glyphs which are not replaced by ligatures
fix the placement of  །
fix the placement of tsek

latest font, not perfect
https://github.com/OpenPecha/create-font-from-glyph/tree/feature/font-from-scratch/fonts/derge_font
pecha image

font image

The generated font glyphs strokes looks thicker, that is due to the vectorization of png images, converting png to svg can help keep the font sharp at any size but it will also smooth out the pecha images glyphs which will cause the fonts to look visuallly different from the source text.

Any thoughts on this @ngawangtrinley

there are some glyphs which has noise due to incorrect annotation, for that, there is a approach to clean the glyphs using https://github.com/orgs/OpenPecha/projects/56/views/7?pane=issue&itemId=72223820

as per @ngawangtrinley suggestion, resized the the png 10 times, and the resultant svg show less smoothing of glyphs

updated font with reduction in smoothing of glyphs
previous font:

updated font:

latest font, not perfect
https://github.com/OpenPecha/create-font-from-glyph/tree/feature/font-from-scratch/fonts/derge_font
pecha image

1st iteration font

2nd iteration font

3rd iteration font


opentelemetry directives unknown

Describe your environment
Running nginx in a kubernetes pod to serve static content and proxy dynamic requests.
Steps to reproduce
Nginx pod was build with this dockerfile:
# Take an upstream docker image as an argument
# build the static directory there

# SRC_IMG will be the `web` container, with the assets collected in /app/static-collected
ARG SRC_IMG

FROM ${SRC_IMG} AS static_source

# When updating nginx also make sure to check otel module compatibility matrix and update otel version accordingly
FROM nginx:1.23.1
ADD https://github.com/open-telemetry/opentelemetry-cpp-contrib/releases/download/webserver%2Fv1.0.3/opentelemetry-webserver-sdk-x64-linux.tgz /opt
RUN cd /opt; tar xvfz opentelemetry-webserver-sdk-x64-linux.tgz
RUN cd /opt/opentelemetry-webserver-sdk; ./install.sh
ENV LD_LIBRARY_PATH=$LD_LIBRARY_PATH:/opt/opentelemetry-webserver-sdk/sdk_lib/lib
RUN mkdir /app/
COPY --from=static_source /app/static-collected /app/static/

adding in static content is probably not necessary to reproduce.
nginx.conf, otel-nginx.toml and also opentelemetry_module.conf are loaded into the pod via configmap:
data:
  nginx.template.conf: |-
    load_module /opt/opentelemetry-webserver-sdk/WebServerModule/Nginx/${NGINX_VERSION}/ngx_http_opentelemetry_module.so;

    user www-data;
    worker_processes 8;
    error_log  /var/log/nginx/error.log warn;
    pid        /var/run/nginx.pid;

    # https://serverfault.com/questions/787919/optimal-value-for-nginx-worker-connections
    events {
      worker_connections 10240;
    }

    http {
      opentelemetry_config /conf/otel-nginx.toml;

      upstream varnish_upstream {
        server ${VARNISH_HOST}:8040;
        keepalive 32;
      }

      server {
        listen 80 default_server;
        listen [::]:80;
        server_name _;

        location / {
            proxy_send_timeout  300;
            proxy_read_timeout  300;
            proxy_set_header Host $host;
            proxy_set_header X-Real-IP $remote_addr;
            proxy_set_header X-Forwarded-For $proxy_add_x_forwarded_for;
            proxy_set_header X-Forwarded-Proto https;
            proxy_set_header X-Forwarded-Port 443;
            proxy_pass http://varnish_upstream;
        }

      } # server
    } # http
  opentelemetry_module.conf: |-
    NginxModuleEnabled ON;
    NginxModuleOtelSpanExporter otlp;
    NginxModuleOtelExporterEndpoint http://otel-collector-collector.monitoring:4317;
    NginxModuleServiceName nginx-instrumentation;
    NginxModuleServiceNamespace default;
    NginxModuleServiceInstanceId nginx-instrumentation-test;
    NginxModuleResolveBackends ON;
    NginxModuleTraceAsError OFF;
  otel-nginx.toml: |-
    exporter = "otlp"
    processor = "batch"

    [exporters.otlp]

    host = "otel-collector-collector.monitoring.svc.cluster.local"
    port = 4317

    [processors.batch]
    max_queue_size = 2048
    schedule_delay_millis = 5000
    max_export_batch_size = 512

    [service]
    name = instrumentation-nginx

and the nginx.conf file is templated with the varnish and nginx version values before nginx starts.
What is the expected behavior?
Nginx starts correctly and sends traces to the otel collector
What is the actual behavior?
nginx crashes with the message:
nginx: [emerg] unknown directive "opentelemetry_config" in /nginx.conf:14

Additional context
I have also tried using the instructions in the opentelemetry blog which configure the module using include /etc/nginx/config.d/*.conf instead of the opentelemetry_config directive.  In that case nginx starts up and I see the error I describe in !255.  Traces appear in Jaeger, but seemingly without propagation configured.  If I try add opentelemetry directives, such as opentelemetry_propogation or opentelemetry_trust_upstream_traces, nginx crashes as described above

Hello, what is the status of this issue ?
I have the same problem with Nginx 1.22.0 and OpenTelemetry Nginx module v1.0.3.
It doesnt recognize the opentelemetry_* instructions:
unknown directive "opentelemetry_config" in /etc/nginx/nginx.conf:73

same issue.
OpenTelemetry module is otherwise working and sending traces to the oltp enpoints for collection.
Neither opentelemetry_propagate nor opentelemetry_attribute are recognized.

Same issue.

Same issue with "unknown directive"
opentelemetry_operation_name _;
opentelemetry_propagate;
https://opentelemetry.io/blog/2022/instrument-nginx/

Same issue with "unknown directive"

Update:
I have found the nginx official module that are more optimized (they say that not me)
And it work very well : http://nginx.org/en/docs/ngx_otel_module.html


 and  tags aren't rendered when you submit

So I wrote my code and did the standard:
<!DOCTYPE html>
<html>
<head>
    <title>Document</title>
    ...
</head>
<body>
   ...
</body>
</html>

...but when the page finally rendered, it didn't actually render the <body> tag, so when I styled body { ... }, none of that showed up. <head> wasn't rendered either.
But, all other tags were, so that's what really matters. :)

Closed by #3


Installation Error

Hi, i got this error during the installation. Does anyone have a idea how i can fix that?
Thank you

update nodejs > 16


Update README.adoc

note the username and password

Thanks for the PR @joshlong ! This is now in main.


BUG: Fix GitHub community template syntax errors.

Fix GitHub community template syntax errors.

Let's see if this makes the trick.
I found some valuable examples here to enlighten the way:
https://github.com/PowerShell/PowerShell/tree/master/.github/ISSUE_TEMPLATE
https://github.com/PowerShell/PowerShell/issues/new/choose
A few comments:

I removed the title. I finally understood what it means, and I think it is better to leave it blank to force users to fill it (although I ignore whether it can be left blank). But I'm open to suggestions.
The quotes are not necessary in our case/for the strings were are using (ref here).
Looking at the PowerShell repository we could add some more templates. I'm open to suggestions.
I am in two minds about changing the filenames to be all lower case. Any preferences?

Thanks.

Not sure what's wrong with the PR template. This PR does not modify the template, and thus no change is expected.
Did a few tests in a mock private repository concerning the PR template (changed the case in case the PR template, in contrast to the issue templates, is case sensitive; removed the white
space at the beginning of the file) without finding the cause, though.
However, the issue templates should be working with the changes introduced in this PR according to the tests I did in the same private, mock repository.
A feature I found is that enclosing the guidelines in the <!-- --> markup makes them visible only at the time the issue is being opened, but not once they are open. So I think that is an improvement that is worthwhile. May be in another PR.
Also I guess the PR template is only used when opening one from the web interface, and not the command line. Not sure anything can be done about it.
Suggestions are welcome.

CDash failure looks like a false positive ?

Looking at the PowerShell repository we could add some more templates. I'm open to suggestions.

The first two are nice. We could could have one that corresponds to each type:XYZ label...

I am in two minds about changing the filenames to be all lower case. Any preferences?

LESS SHOUTING sounds good to me :-).

Thanks for the review @thewtex !
The issue templates are working :tada: .
In a subsequent PR I will

Change the case.
Enclose the guidelines in <!-- --> so that they are only visible at the time the user writes the issue/PR.

And I will add a few more templates on a separate PR. Some may not fit well into a template. Will think about it/propose something.
Still two issues ahead:

The PR template is still not being displayed. I run out of ideas to look at.
Using the git alias to open the PR will not display the template. May be we can use the GitHub API to query and get it displayed?

@jhlegarreta awesome!
Maybe the PR template is only used when files for the PR are edited through the web interface?

👍

Maybe the PR template is only used when files for the PR are edited through the web interface?

I'd dare to say that that will be the case unless we do dome fancy stuff to use the GitHub queries/API to get the PR templates when using our aliases to open a PR. Not sure it is even possible. We may want to have a look at it at a later time.


Make sure not necessary to reference name.

Just experimenting with some YAML features.

/azp run net - appconfiguration


EV-4084 Doc changes for typha metrics - remote_cluster_connection_status

Federation metrics in typha EV-4084 #6654 changes
Calico-private changes are part of master, 3.15,3.16,3.17,3.18

Product Version(s):

Issue:

Link to docs preview:

SME review:

[ ] An SME has approved this change.

DOCS review:

[ ] A member of the docs team has approved this change.

Additional information:

Merge checklist:

[ ] Deploy preview inspected wherever changes were made
[ ] Build completed successfully
[ ] Test have passed

Merged all the PR and cherry-picks
3.15 - https://github.com/tigera/calico-private/pull/6620
3.16 - https://github.com/tigera/calico-private/pull/6623
3.17 - https://github.com/tigera/calico-private/pull/6622
3.18 - https://github.com/tigera/calico-private/pull/6654


we should be able to use a real client to talk to external sites.

To be specific, I want to stick automatic fuzzing jobs inside of kubernetes clusters.


Anime and Dorama source

Source name
Taled Fansub (Dorama) and Anix (Anime)
Source link
https://taledfansub.forumeiros.com/  |  https://anix.to/home
Source language
Portuguese (BR)
Other details
No response
Acknowledgements

[X] I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open or closed issue.
[X] I have written a title with source name.
[X] I have checked that the extension does not already exist on the website extensions list or the app.
[X] I have checked that the extension does not already exist by searching the GitHub repository and verified it does not appear in the code base.
[X] I will fill out all of the requested information in this form.

As we were hit with a dmca takedown notice, we will not accept new source requests, unless they're for self-hosted stuff.


Vertical-Padding CSS var

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
For components such as <mwc-textfield> and <mwc-button>, exposing a CSS variable --vertical-padding would enhance the customisation potential.
Describe the solution you'd like
A clear and concise description of what you want to happen.
Adding a new CSS variable to apply arbitrary vertical padding to relevant components, e.g. buttons and textfields.
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.

This sounds more like a request to change the density and height of a component, which is an upcoming feature that you can track in https://github.com/material-components/material-components-web-components/issues/841.
The Material Design spec allows for some padding values to be customized, and those are exposed as custom properties where that is allowed. However, there won't be an arbitrary variable exposed to change the overall padding of all components. This is outside the scope of what is allowed to be customized in Material Design.
What you could do is extend the components and add another stylesheet with customizations to make Material-inspired components that aren't as strict to adhering to the spec.
@customElement('my-button')
class MyButton extends Button {
  static styles = [
    Button.styles,
    css`
      /* overriding styles and customizations */
    `
  ];
}

I wasn't aware that I could extend existing components this way, this is worth adding to the doc. 😇

While it's possible, this isn't something we directly support right now. This is essentially "forking" at runtime, you'll be susceptible to breaking changes in the DOM structure with minor version updates.
So, proceed with caution!


Update README

This should probably be seen in context of broader meta-issue on documentation but opening this after changes in #11. My plan is to:

[ ] Switch from .Rmd source to .qmd for source to reduce dependencies
[ ] Explain and demonstrate with a reproducible example the use of new subpoints arguments using the schools dataset

Can work on this later today but happy to hold horses if other features, e.g. addition of weight_key_origins and weight_key_destinations arguments, are in the pipeline. Note to self: most recent version of the pkg has the following arguments:
odjitter --help
odjitter 0.1.0
Dustin Carlino<EMAIL_ADDRESS>Disaggregate origin/destination data from zones to points

USAGE:
    odjitter [OPTIONS] --od-csv-path <OD_CSV_PATH> --zones-path <ZONES_PATH> --output-path <OUTPUT_PATH> --disaggregation-threshold <DISAGGREGATION_THRESHOLD>

OPTIONS:
        --destination-key <DESTINATION_KEY>
            Which column in the OD row specifies the zone where trips ends? [default: geo_code2]

        --disaggregation-key <DISAGGREGATION_KEY>
            Which column in the OD row specifies the total number of trips to disaggregate?
            [default: all]

        --disaggregation-threshold <DISAGGREGATION_THRESHOLD>
            What's the maximum number of trips per output OD row that's allowed? If an input OD row
            contains less than this, it will appear in the output without transformation. Otherwise,
            the input row is repeated until the sum matches the original value, but each output row
            obeys this maximum

    -h, --help
            Print help information

        --min-distance-meters <MIN_DISTANCE_METERS>
            Guarantee that jittered points are at least this distance apart [default: 1.0]

        --od-csv-path <OD_CSV_PATH>
            The path to a CSV file with aggregated origin/destination data

        --origin-key <ORIGIN_KEY>
            Which column in the OD row specifies the zone where trips originate? [default:
            geo_code1]

        --output-path <OUTPUT_PATH>
            The path to a GeoJSON file where the disaggregated output will be written

        --rng-seed <RNG_SEED>
            By default, the output will be different every time the tool is run, based on a
            different random number generator seed. Specify this to get deterministic behavior,
            given the same input

        --subpoints-destinations-path <SUBPOINTS_DESTINATIONS_PATH>
            The path to a GeoJSON file to use for sampling subpoints for destination zones. If this
            isn't specified, random points within each zone will be used instead

        --subpoints-origins-path <SUBPOINTS_ORIGINS_PATH>
            The path to a GeoJSON file to use for sampling subpoints for origin zones. If this isn't
            specified, random points within each zone will be used instead

    -V, --version
            Print version information

        --zone-name-key <ZONE_NAME_KEY>
            In the zones GeoJSON file, which property is the name of a zone [default: InterZone]

        --zones-path <ZONES_PATH>
            The path to a GeoJSON file with named zones

Weighted subpoints and a second disaggregation command are coming, but maybe not by today. I'd guess both are additive to the docs, so switching to qmd shouldn't get in the way of anything

Looking into it now.

Discovery: after rebuilding the source doc in the commit above I get this:

It's html, could be basis of a nice website, but working on getting the .md updated...

Looking at the docs: https://quarto.org/docs/authoring/markdown-basics.html

format: gfm

In the header will solve it I think. https://quarto.org/docs/output-formats/gfm.html#gfm-format

Update while writing the this: great error message with clear fix:
Error: data/od_schools.csv doesn't have a all column or the value isn't numeric; set disaggregation_key properly

And another one, this is good:
Error: data/od_schools.csv doesn't have a geo_code1 column; set origin_key properly

Glad the error messages are proving useful! Very frustratingly, all filesystem errors in Rust by default are next to worthless -- they just say "no such file or directory" without including the path. So if you're ever working on a Rust project, I'd recommend https://crates.io/crates/fs-err as a workaround

Good visualisation for the docs, may remove from README but here as a placeholder to tidy up:


Add supported Siddhi version information on extension API docs

Description:
With each extension add the supported Siddhi version in the API to give a hint on which Siddhi version the extension was created and will work

Fixed in https://github.com/siddhi-io/siddhi/pull/1361


Create Device with an Adapter Index on WinMLRunner

I'm submitting a…

Sample app request
Request that WinMLRunner be able to create a device with a passed in Adapter Index.  Enable targeted debug on specific device.  Not worried if the device is created in WinMLRunner or by WinML itself.

Current behavior

Expected behavior

Minimal reproduction of the problem with instructions

Environment
Windows Build Number:
App min and target version:
OS Version (Server, IoT Core, Desktop, etc):
Graphics Driver version:
DxDiag:
WinMLTools specific:
- Source training framework: (e.g. CoreML, Scikit-learn, …)
- WinMLTools version
Visual Studio

[ ] 2017 (version: )
[ ] 2017 Preview (version: )

@pmbrown1055 - we added the GPUAdapterName parameter a while ago that should address this. I believe indices can change between boot sessions, so we decided to choose by specifying the name.


feat: jetpack-l4t based llama.cpp container

User Story
As a user
I want to run accelerated models on Jetson AGX Orins
So that I can take advantage of the device's NPUs
Additional context
Compiling using the l4t-jetpack nvidia container: https://catalog.ngc.nvidia.com/orgs/nvidia/containers/l4t-jetpack
Example of building containerized with all build tools: https://github.com/dusty-nv/jetson-containers/tree/dev
Containers don't seem to need --gpus=all, and the Jetson + Jetpack comes with it's own nvidia container toolkit ready to go. It looks like this is a combination of the CPU UDS bundle with the inferencing containers being built on the jetpack image.

I have a Jetson available on Tailscale as needed for testing, need to upgrade the storage on it before we can iterate.


Updated Italian localization

I noticed another branch (upstream/tutstuff), but I work on mater branch anyway. Is it ok?
Now the translation of this string is more precise.

Thanks for submitting this early! I'll merge this PR once the tutstuff branch is merged to master


Merge master into release-3.0

Merge master into release-3.0

Please also carry changes from https://github.com/tikv/tikv/pull/4752 after it is merged. Thanks!

Please fix the DCO?

/run-all-tests


duplicated MB1 convention edition data

there seems to be duplicated information for MB1
CMB1 has "Mystery Booster Booster Box Convention Edition 2021" with a proper tcg identifier
MB1 has "Mystery Booster Booster Box (Convention Edition - 2021)" with no identifier
same goes for packs
i think logically they belong to MB1 but they got put in CMB1 because of the playtest cards maybe?

This is an issue with the parent data.
We're pulling data from both TCGPlayer and Card Kingdom, and they don't always put products in the same set.
It looks like TCGPlayer has it in CMB1, and Card Kingdom has it in MB1. I don't have a good way to manually change that right now besides reaching out to the upstream and seeing if they can update the data.

perhaps we can make a list of redundant sealed product and skip some, manually adding the identifiers as needed?

That could be a reasonable approach. It would need to be done in MTGJson, since it's modifying the data directly from the upstream sources. You should open an issue there and work with Zach to determine the best path forward. I'm happy to do data entry as needed but I don't have the capacity to build the framework right now.

moving to https://github.com/mtgjson/mtgjson/issues/1102


Please make a macro to derive Prisma schema from Rust structs

Problem
I like Rust lately and want to use it. But I also want to use Prisma to migrate the DB. Problem is, then I have two sources of truth on my schema. Both extremely similar purpose. Rust structs and  Prisma schema... this causes maintenance issues (we all know how that can be...)
Suggested solution
If Prisma had a simple Rust crate with 1 macro, to #[derive(prisma)] from structs. It can just loop over the fields and map the rust types onto the prisma types and write them to a file.
Indeed, more ways to codegen Prisma schema from various languages' type systems, would make your project much more compelling
Alternatives
Suck it up and maintain rust structs for the server, a prisma schema for SQL and typescript types for front end. Yikes
Additional context
https://doc.rust-lang.org/rust-by-example/custom_types/structs.html
https://doc.rust-lang.org/book/ch19-06-macros.html

Hey @bionicles, we don't think this would be a good match for Prisma itself.
Prisma ORM uses components written in Rust, but that is an internal implementation details. Your request might be better suited as a standalone project (which might or might not user any of our internal API from prisma-engines) or maybe as part of a custom client, like e.g. Prisma Client Rust.
I am closing this issue now to signal that we are not considering building this. Thanks for opening it though!


SchemaValidateFunction requires certain types of ErrorObjects that we don't want to specify.

What version of Ajv are you using? Does the issue happen if you use the latest version?
Your typescript code
v6.12.5
import Ajv from "ajv";
import bytes from "bytes";

const ajv = new Ajv({
  // some properties
});

const maxFileSize = (maxBytes: number, data: string) => maxBytes >= data.length;

const validateMaxFileSize: Ajv.SchemaValidateFunction = (
  schema: string,
  data: string
) => {
  // schema: max file size like "512KB" or 123 (in bytes)
  // data: path to the file
  const maxBytes = bytes.parse(schema);
  const valid = maxFileSize(maxBytes, data);
  if (!valid) {
    validateMaxFileSize.errors = [
      {
        keyword: "maxFileSize",
        params: {
          limit: maxBytes,
        },
        message: `file size should be <= ${schema}`,
      },
    ];
  }
  return valid;
};

ajv.addKeyword("maxFileSize", {
  validate: validateMaxFileSize,
});

Typescript compiler error messages
Type '{ keyword: string; params: { limit: number; }; message: string; }' is missing the following properties from type 'ErrorObject': dataPath, schemaPathts(2739)

Describe the change that should be made to address the issue?
The problem is that some properties that we don't want to specify directly are required.
So, Ajv.ErrorObject needs to allow for partials properties in SchemaValidateFunction.
Are you going to resolve the issue?
I'll do it if necessary.

I think it's addressed in v7 - can you have a look please?

Thank you for the response.
I'd like to see this feature available before support for draft 4 is discontinued for personal reasons.
But I'll close this issue If you don't think you need it.

We can add to v6, in the same way.

I understand.
This issue doesn't seem to be necessary, so I'll close it.
Good luck with the development!


Open terminal button not working anymore

Starting today, the open terminal button has stopped working.
In the console, I see the following:
[brackets-git] cmd-execute: {workingdir} -> C:\cygwin64\bin\mintty.exe /bin/env CHERE_INVOKING=1 /bin/bash -l
[brackets-git] cmd-execute-out (2ms;ID=26)

Executing this command (through an existing terminal or the Windows Run dialog) works fine.
I tried replacing the terminal command with touch, which seems to confirm that the command is not being executed.

Did you install new version of Git or something? There was no change to this functionality in a very long time.

No, I didn't change anything in my system.
git commands work fine by the way, it's just the terminal button that has stopped working.

No idea, try debugging this method in debug tools of Brackets: https://github.com/zaggino/brackets-git/blob/3bafdb06c7b06f48e826ef2b1daeaa450c344459/src/utils/Terminal.js#L45

The problem seems to be inside Cli.executeCommand.
The promised returned there never resolves or rejects.
Stepping through that function, I noticed that here: https://github.com/zaggino/brackets-git/blob/3bafdb06c7b06f48e826ef2b1daeaa450c344459/src/Cli.js#L210
resolved is false, but out is empty.
I'm not really sure what that means but I'm guessing that nodeConnection.domains[domainName][method](opts.cwd, cmd, args, domainOpts) is the thing that actually executes the command?

That look fine, out should be empty there because terminal command doesn't return anything. Promise gets resolved so the line was executed. Weird that it doesn't open the terminal on your machine. Maybe it's something with cygwin? Have you tried using the default mintty which comes with Git? The one in C:\Program Files\Git\git-bash.exe (the default for the extension)

But shouldn't resolved be true if the command executed successfully?
I don't have git-bash installed but I'll give that a try.
Note however that it also doesn't work with any other program (for instance cmd.exe).
All options I've tried pass the 'validation' stage where the plugin figures out if the executable actually exists.
All commands also work fine if I try to execute them as a system call (or through another terminal or the windows run dialog).

resolved variable holds the boolean information about the promise and false means it was not yet resolved (by timeout or task cancellation)

Try executing some bat file (echo helloworld) which returns some text and see if that text gets through I guess.

Oh I see, that's the status for the promise returned by the main function, not nodeConnection.domains[domainName][method]
I'll dig deeper into that function.

Try executing some bat file (echo helloworld) which returns some text and see if that text gets through I guess.

I've already tried that (and something like touch) but it really looks like it's not being executed.

It's weird that this doesn't work and the git commands do ... they share the odeConnection.domains[domainName][method] part ...

I just tried setting my terminal command to my git path, with as arg init.
If I execute that, the nodeConnection.domains[domainName][method] function is executed with correect\path\to\git.exe, ["init"], after which nothing happens.
While trying to reproduce what happened when I clicked the Init button in the UI, I discovered that that, too, didn't do anything.
Most of the other commands (at least committing, branching, pulling, pushing) work fine.
I think I'll try to reinstall Brackets, the plugin, clean my preferences file and see where that gets me.

Okay, my button just started working again.
I have no idea what changed, but I'm going to assume this plugin had nothing to do with the actual problem.

Well, I definitely didn't change any codes :) Closing this then...


A bit of Danish translation

Perhaps this can raise the percentage a bit :)

Hello, @Zleep-Dogg! Thank you for contributing :+1:


fix(shim-plugin): Skip source maps when shimming

Closes #11

Codecov Report

Merging #14 (7393712) into main (665a948) will increase coverage by 0.08%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #14      +/-   ##
==========================================
+ Coverage   93.07%   93.15%   +0.08%
==========================================
  Files          21       21
  Lines         491      497       +6
  Branches       43       45       +2
==========================================
+ Hits          457      463       +6
  Misses         34       34

Impacted Files
Coverage Δ

src/lib/plugins/shim.plugin.ts
100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


OpenAPI 3.1 SpecFilter.removeBrokenReferenceDefinitions breakes WebHooks processing

When using io.swagger.v3.core.filter.SpecFilter.removeBrokenReferenceDefinitions on the provided OpenAPI 3.1.0 specification, the function is incorrectly removing the RequestDto schema definition from the components.schemas section. The schema is still referenced in the webhook newPet request body, but the actual schema definition is removed from the OpenAPI spec, resulting in a broken reference.
Input OpenAPI Spec:
The original OpenAPI specification includes a schema definition RequestDto under the components.schemas, which is referenced by the newPet webhook's request body schema.
openapi: 3.1.0
info:
  title: OpenAPI definition
  version: v0
servers:
  - url: http://localhost
    description: Generated server url
paths: {}
components:
  schemas:
    RequestDto:
      properties:
        personalNumber:
          type: string
webhooks:
  newPet:
    post:
      requestBody:
        description: Information about a new pet in the system
        content:
          application/json:
            schema:
              $ref: '#/components/schemas/RequestDto'
              description: Webhook Pet
      responses:
        '200':
          description: >-
            Return a 200 status to indicate that the data was received
            successfully

Generated OpenAPI Spec:
After using the removeBrokenReferenceDefinitions method, the resulting OpenAPI spec incorrectly removes the RequestDto schema from the components.schemas section, even though it is still referenced. This causes a broken reference in the generated spec:
openapi: 3.1.0
info:
  title: OpenAPI definition
  version: v0
servers:
  - url: http://localhost
    description: Generated server url
paths: {}
components:
  schemas: {}
webhooks:
  newPet:
    post:
      requestBody:
        description: Information about a new pet in the system
        content:
          application/json:
            schema:
              $ref: '#/components/schemas/RequestDto'
              description: Webhook Pet
      responses:
        '200':
          description: >-
            Return a 200 status to indicate that the data was received
            successfully

Expected Result
The SpecFilter.removeBrokenReferenceDefinitions method should retain schema definitions that are referenced in other parts of the OpenAPI specification (such as in webhooks, request bodies, or responses). In this case, since the RequestDto schema is being referenced in the newPet webhook, the method should not remove the RequestDto schema from the components.schemas section.
The expected behavior is as follows:
The RequestDto schema should remain in the components.schemas section, as it is actively referenced in the webhook newPet.

Hi @bnasslahsen thank you for reporting the issue ! It should be solved by: https://github.com/swagger-api/swagger-core/pull/4762, I am closing this ticket for now, If there will be still any questions feel free to reopen.


[BUG] NotificationFailed event not fired when a notification fails

Laravel Version: 8.x
PHP Version: 7.4
Database Driver & Version: N/A

Description:
Laravel fires a list of events when sending notifications through different channels. as documented here: https://laravel.com/docs/8.x/notifications#notification-events
The bug is related to the notifications events, not being fired properly, more precisely the NotificationFailed event not being fired at all, and the class not being used at all inside laravel core code.
The NotificationFailed class was added in this PR https://github.com/laravel/framework/pull/14874 but it seems that the implementation was not complete or for some reason, the class was just added as a placeholder.
Steps To Reproduce:

Step 1: Add the following to the EventServiceProvider

  /**
   * Track notification sending events.
   * @see https://laravel.com/docs/8.x/mail#events
   */
  NotificationSending::class => [
      LogSendingNotification::class,
  ],
  NotificationSent::class => [
      LogSentNotification::class,
  ],
  NotificationFailed::class => [
      LogFailedNotification::class,
  ],

Step 2: Create the following Listeners LogSendingNotification,LogSentNotification,LogFailedNotification

Step 2: Add some wrong SMTP credentials

Step 3: Dispatch any email notification. ex (WelcomeEmailNotification)

Outcome:
The NotificationFailed event will not fire, even though the notification has been failed.
if you put a correct SMTP credential and fire the same notification, the NotificationSent & NotificationSending events will fire properly.

The code in question is :
NotificationSender::class
    /**
     * Send the given notification to the given notifiable via a channel.
     *
     * @param  mixed  $notifiable
     * @param  string  $id
     * @param  mixed  $notification
     * @param  string  $channel
     * @return void
     */
    protected function sendToNotifiable($notifiable, $id, $notification, $channel)
    {
        if (! $notification->id) {
            $notification->id = $id;
        }

        if (! $this->shouldSendNotification($notifiable, $notification, $channel)) {
            return;
        }

        $response = $this->manager->driver($channel)->send($notifiable, $notification);

        $this->events->dispatch(
            new NotificationSent($notifiable, $notification, $channel, $response)
        );
    }

I have opened a pull request (https://github.com/laravel/framework/pull/37722) that explores a way of solving this issue, but it has been closed by @taylorotwell

I'm sorry but your PR was closed. We won't be doing any changes in this area for now.

@mohammed-elhaouari hi, I have encountered same problem, but I have made workaround. You need to override MailChannel with your own implementation with try/catch block. A lot of work needs to be done for achieving simple behavior but hey, it works.
// app/Providers/AppServiceProvider.php

namespace App\Providers;

use App\Support\Notifications\MailChannel;
use Illuminate\Notifications\Channels\MailChannel as BaseMailChannel;

class AppServiceProvider extends ServiceProvider
{
    public function boot()
    {
        // other code...

        // Replace base mail channel implementation.
        $this->app->bind(BaseMailChannel::class, MailChannel::class);
    }
}

// app/Support/Notifications/MailChannel.php

namespace App\Support\Notifications;

use Illuminate\Contracts\Events\Dispatcher;
use Illuminate\Contracts\Mail\Factory as MailFactory;
use Illuminate\Mail\Markdown;
use Illuminate\Notifications\Channels\MailChannel as BaseMailChannel;
use Illuminate\Notifications\Events\NotificationFailed;
use Illuminate\Notifications\Notification;
use Throwable;

class MailChannel extends BaseMailChannel
{
    protected Dispatcher $dispatcher;

    /**
     * Create a new mail channel instance.
     *
     * @param \Illuminate\Contracts\Events\Dispatcher $dispatcher
     * @param \Illuminate\Contracts\Mail\Factory      $mailer
     * @param \Illuminate\Mail\Markdown               $markdown
     */
    public function __construct(
        Dispatcher $dispatcher,
        MailFactory $mailer,
        Markdown $markdown
    ) {
        $this->dispatcher = $dispatcher;
        $this->mailer     = $mailer;
        $this->markdown   = $markdown;
    }

    /**
     * Send the given notification.
     *
     * @param mixed                                  $notifiable
     * @param \Illuminate\Notifications\Notification $notification
     *
     * @return bool
     */
    public function send($notifiable, Notification $notification): bool
    {
        try {
            parent::send($notifiable, $notification);
        } catch (Throwable $e) {
            $this->dispatcher->dispatch(
                new NotificationFailed($notifiable, $notification, 'mail')
            );

            return false;
        }

        return true;
    }
}

Now is tricky part. You cannot throw exception in MailChannel::send method, because it will stop executing other channels. You cannot prevent dispatching NotificationSent event, but you can use $event->response in your NotificationSent listener to prevent it's logic to execute.
namespace App\Listeners;

use Illuminate\Notifications\Events\NotificationSent;

class NotificationSentListener
{
    /**
     * Handle the event.
     *
     * @param \Illuminate\Notifications\Events\NotificationSent $event
     *
     * @return void
     */
    public function handle(NotificationSent $event)
    {
        /*
         * Do not store sent notification log if response from
         * channel `send` method returns false.
         */
        if ($event->response === false) {
            return;
        }

        // rest of your logic...
    }
}

It's a pity that this wasn't merged. Hope that my solution will help.

Thanks, @Dartui. Yeah, I think the notification's system needs a revamp for a better multichannel support.

The code that @Dartui provided works well, but not in combination with Queue. When checking the execution through queue:listen, it shows as that the job completed successfully and it's not failing it. Because of this, the job is then not moved into failed_jobs table and can't be re-tried at later time. I tried a lot of combinations on how to fail a job (since the send() method in MailChannel is an extension of original, was expecting that this would work), but failed.
Any ideas on how to forward the same response from send() method that MailChannel extends? Since if I remove the try-catch block, then the job fails properly and can then be re-tried at later time.


fix use of undefined constant evaluating expression

This minor fix prevents PHP Notice "Use of undefined constant FOO - assumed 'FOO'" when eval "$name = $v[FOO]"

Thank you :+1:


talks.godoc.org still links to go-talks.appspot.com

The syntax for URLs is:
http://go-talks.appspot.com/github.com/owner/project/file.ext
http://go-talks.appspot.com/github.com/owner/project/sub/directory/file.ext

I realise that both work, but talks.godoc.org is more likely to survive in the long term and it's a better URL to suggest to users.

Gerrit doesn't seem to cross post, but I opened a fix for this here:
https://go-review.googlesource.com/#/c/gddo/+/95256
While I think that it might be nice to display whatever the hostname is, it's simpler and less logic to simply update the domain with the canonical location.

Reopening for tracking when the fix has been deployed.

Deployed now.


apply cube updates to cpp version

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

Merged.


Fix depth plane clipping

Fixes https://github.com/AnalyticalGraphicsInc/cesium/issues/7879
Pushes the depth plane farther from the camera so that the depth plane does not render above primitives in the scene.
This is a lot like existing code that used to push the depth plane below classification primitives to avoid rendering artifacts. https://github.com/AnalyticalGraphicsInc/cesium/commit/1fda8c0ce8a95e13df150bd686fbfc957823908f
Don't merge until https://github.com/AnalyticalGraphicsInc/cesium/issues/8179 is fixed, otherwise pickPosition will be extremely wrong when scene.depthTestAgainstTerrain is false.

Thanks for the pull request @lilleyse!

:heavy_check_mark: Signed CLA found.
:grey_question: CHANGES.md was not updated.

If this change updates the public API in any way, please add a bullet point to CHANGES.md.

:grey_question: Unit tests were not updated.

Make sure you've updated tests to reflect your changes, added tests for any new code, and ran the code coverage tool.

Reviewers, don't forget to make sure that:

[ ] Cesium Viewer works.
[ ] Works in 2D/CV.
[ ] Works (or fails gracefully) in IE11.

@lilleyse who should review this, @IanLilleyT?

@lilleyse Hello. Could you please look at this question? 8181

Thanks again for your contribution @lilleyse!
No one has commented on this pull request in 30 days. Maintainers, can you review, merge or close to keep things tidy?
I'm going to re-bump this in 30 days. If you'd like me to stop, just comment with @cesium-concierge stop. If you want me to start again, just delete the comment.

Thanks again for your contribution @lilleyse!
No one has commented on this pull request in 30 days. Maintainers, can you review, merge or close to keep things tidy?
I'm going to re-bump this in 30 days. If you'd like me to stop, just comment with @cesium-concierge stop. If you want me to start again, just delete the comment.

Closing this, it's too Earth-centric. A better approach will involving finding the min/max heights based on the loaded terrain tiles / 3D Tiles kind of like https://github.com/AnalyticalGraphicsInc/cesium/pull/8398


Text is manipulated

Hi,
the textbox unfortunately manipulates the text that it is supposed to print. When lines start with blanks it  removes them. Would be nice if the textbox would just print the text and leave the manipulations to the user.
Great add on.

And is also applies the same manipulations as streamlit.text()

Not sure where this comes from:


New Error in file Download mode.

The file is still there, but Telegrm-cloud can not download more than 23%.
.
..
...
Downloaded 35389440 out of 149803769 bytes: 23.62%
Downloaded 35651584 out of 149803769 bytes: 23.80%
Traceback (most recent call last):
File "e:\telegram_download\lib\runpy.py", line 194, in run_module_as_main
return run_code(code, main_globals, None,
File "e:\telegram_download\lib\runpy.py", line 87, in run_code
exec(code, run_globals)
File "E:\telegram_download\Scripts\tgcloud.exe_main.py", line 7, in
File "e:\telegram_download\lib\site-packages\telegramcloud_main.py", line 56, in cli
client.loop.run_until_complete(main())
File "e:\telegram_download\lib\asyncio\base_events.py", line 616, in run_until_complete
return future.result()
File "e:\telegram_download\lib\site-packages\telegramcloud_main.py", line 46, in main
await client.download_media(message, args.path, progress_callback=download_callback)
File "e:\telegram_download\lib\site-packages\telethon\client\downloads.py", line 367, in download_media
return await self._download_document(
File "e:\telegram_download\lib\site-packages\telethon\client\downloads.py", line 771, in _download_document
result = await self.download_file(
File "e:\telegram_download\lib\site-packages\telethon\client\downloads.py", line 467, in download_file
async for chunk in self.iter_download(
File "e:\telegram_download\lib\site-packages\telethon\requestiter.py", line 74, in anext
if await self._load_next_chunk():
File "e:\telegram_download\lib\site-packages\telethon\client\downloads.py", line 61, in _load_next_chunk
cur = await self._request()
File "e:\telegram_download\lib\site-packages\telethon\client\downloads.py", line 71, in _request
result = await self.client._call(self._sender, self.request)
File "e:\telegram_download\lib\site-packages\telethon\client\users.py", line 77, in _call
result = await future
telethon.errors.rpcerrorlist.FileReferenceExpiredError: The file reference has expired and is no longer valid or it belongs to self-destructing media and cannot be resent (caused by GetFileRequest)
Task was destroyed but it is pending!
task: <Task pending name='Task-11' coro=<MTProtoSender._send_loop() running at e:\telegram_download\lib\site-packages\telethon\network\mtprotosender.py:422> wait_for=<Future pending cb=[<TaskWakeupMethWrapper object at 0x000002BBD406A9A0>()]>>
Task was destroyed but it is pending!
task: <Task pending name='Task-12' coro=<MTProtoSender._recv_loop() running at e:\telegram_download\lib\site-packages\telethon\network\mtprotosender.py:459> wait_for=<Future pending cb=[<TaskWakeupMethWrapper object at 0x000002BBD40A4A90>()]>>
Task was destroyed but it is pending!
task: <Task pending name='Task-9' coro=<Connection._send_loop() running at e:\telegram_download\lib\site-packages\telethon\network\connection\connection.py:159> wait_for=<Future pending cb=[<TaskWakeupMethWrapper object at 0x000002BBD406A4C0>()]>>
Task was destroyed but it is pending!
task: <Task pending name='Task-10' coro=<Connection._recv_loop() running at e:\telegram_download\lib\site-packages\telethon\network\connection\connection.py:177> wait_for=<Future pending cb=[<TaskWakeupMethWrapper object at 0x000002BBD406ADC0>()]>>

I downloaded more than 50 PDFs without any problem, also I add some error handler. please install the latest version and try again.


9anime changed their API again

Once again, 9anime changed their API. Can't download or watch anything.

Oh my god. I think they are testing something new with their site. Might be one or two days before things cool down.

Could they be doing it intentionally? So that people don't rely on stuff like this and instead directly use the website more?

I read somewhere in the issues page of DxCc's 9anime plugin (where the DD parameter is taken from) that these changes could be part of an attempt to subvert the aggressive ads on their site. It seems they succeeded in doing that this time because the ads no longer show through my ad blocker. Also, @vn-ki , I skimmed through their commits and issues and at no point does it seem like they elaborate on what DD is derived from, what it does, or what it's needed for. Any time anyone asks about it it looks like they just ignore the question, so trade secret, I guess?

Does that mean now the focus is gonna be on other websites? Or are you guys gonna delve deeper into 9anime?

Also, @vn-ki , I skimmed through their commits and issues and at no point does it seem like they elaborate on what DD is derived from, what it does, or what it's needed for. Any time anyone asks about it it looks like they just ignore the question, so trade secret, I guess?

I know. I remember doing it once before. Maybe it's a trade secret. I came very close to finding it today but then I had a lot of other things to do too. If you are feeling adventurous, I'll share what I know.
Since we are taking advantage of the ajax api of 9anime, the relevant code should centered around the ajax call. It is in frontend/min/all.min.js. (Checkout sources tab of developer tools). The problem is that the minified js is highly obfuscated. This makes the job a lot harder. (There was something else too, but I forgot now)

Does that mean now the focus is gonna be on other websites? Or are you guys gonna delve deeper into 9anime?

Once 9anime stops changing, we can fix it. In the mean time, I am working on a fallback approach so that we can continue watching our dearest anime.

9anime has been fixed for now.
I have changed the watch command a lot. So your old watch lists will no longer work. Sorry for this. Hope you guys understand. Hopefully this will not repeat again.

I like the changes. The watch file wasn't plaintext with pickle, so I wasn't able to edit my watch list from my IDE. This should make things much easier to test.


RGB Headset support?

I dont know why rgb headset support for like the G935 is not already in it but that would be fantastic, its really annoying the fact i cant use the rgb part of my headset because aurora takes control of ALL illumination for logitech and making the rgb headsets not rgb whatsoever and i cant disable just the headset being controlled either

https://github.com/antonpup/Aurora/issues/1548


[Bug]: When connect wallet is rejected from wallet, do not auto-set wallets again

Current Behavior
Sumbitted through discord by L03TJ3
Where I try to connect a users previously connected wallet.
(which is just based on the docs explaining connecting a existing wallet).
Steps to reproduce:

Connect a wallet to the app and store the connected wallet data in local-storage
Close the app-window
Clear connected-sites in metamask
Revisit app
Onboard tries to connect based on local-storage
Connection request pops-up in metamask
Reject
Onboard modal shows connection rejected

The issue?

Clicking 'back to wallets' retriggers auto-select (where a user might want to use a different wallet to connect?)
No event is triggered to catch any rejection error/event, and the connect promise is only resolved when closing the modal (so a user is forced to close the modal, with no explanation)

basically there is no action that can be taken upon user rejecting an auto-select request
Expected Behavior
If connection is rejected by the user in the wallet and the 'Back to Wallets' button is clicked there is not an attempt to auto connect wallets
Steps To Reproduce
Steps to reproduce:

Connect a wallet to the app and store the connected wallet data in local-storage
Close the app-window
Clear connected-sites in metamask
Revisit app
Onboard tries to connect based on local-storage
Connection request pops-up in metamask
Reject
Onboard modal shows connection rejected

Onboard Version
Core - 2.2.0
Node Version
16.13.2
What browsers are you seeing the problem on?
No response
Relevant log output
No response
Anything else?
No response

Tracking this issue with PR here

L03TJ3 This update has been merged and is live now - thank you for reporting!


SyntaxError when running python run_pretrained_interactive.py

The aforementioned command leads to the following output
File "run_pretrained_interactive.py", line 29
sess_path = f'session_{str(uuid.uuid4())[:8]}'
SyntaxError: invalid syntax

Are you using a recent version of python? fstrings need >=3.6. I've only tested this project with 3.10

Ah I see. Running it as python3 run_pretrained_interactive.py worked


[Add device] Do not clear device id information

If you click continue in the above screen, the device ID information is lost.
Improve this flow and show it when presenting the credentials.

Thanks @maxd-nordic for bringing this up. The device Id is in the email you receive to confirm it:

[hello.nrfcloud.com] › Verify device ownership for device map-66ba2df5-9754-4dbf-8d59-dd3489d00c10: 3GUJRJ

But I think it would be good to send the user an email with the certificate and all device details. How does that sound?

That sounds like a good idea. Putting the relevant info in a mail is effective in making sure it doesn't get lost. Maybe combine it with #149.


Can not get the same results of the papar by using your best model

Dear Tsun-An
Your paper--"Improving Perceptual Quality by Phone-Fortified Perceptual Loss using Wasserstein Distance for Speech Enhancement," is awesome and amazing. I'm interested in this paper and wanna re-implement it on my machine. But I have some trouble with it. Here are some questions about your great work. I am looking forward to your reply.
1.When loaded your best model provided from this link https://drive.google.com/file/d/1QP2bcmnn1yHybsmUbCj9f0xjUyRvrqJa/view, I  get different metric values for whole-utterance enhanced speeches, but the same values for noisy utterances  by running  the 'generate.py' I wonder if this best model is not updated, here are test results:
whole-utterance enhanced speeches:

Average pesq    : 2.846962058139079
Average csig     : 3.9676540338137944
Average cbak    : 2.9871194883025654
Average covl     : 3.4079030461812705
Average stoi     : 0.9265973010366857
whole-utterence noisy speeches:
Average pesq   : 1.9747030872453764
Average csig    : 3.347364207853613
Average cbak   : 2.4455921510844965
Average covl    : 2.6344466824578245
Average stoi    : 0.921240744938685
2.I noticed that speeches are clipped to 16384 samples to save Vram in the training and validation process. If noisy utterances are also clipped in the test process?
3.It is claimed that Wasserstein distance is utilized in your paper. But,  I found only L1 loss between c = Φwav2vec (y) and ĉ = Φwav2vec (ŷ) are provided in your GitHub repository. Would you like to tell me how you calculate the Wasserstein distance between c and ĉ without learnable parameters serving as the f function. In my opinion, all learnable parameters are in DCUnet that can not be the k-Lipschitz functions f(c)  to the clean. I will be very appreciative if you can reply or send the related codes for me at<EMAIL_ADDRESS>Thanks a lot,
Zack Guo

Hi, we are glad to have your appreciation.
Sorry for the late update for this repo, and the current version provides the model weights matching the best result reported in our paper.
I've tested it again using the provided weights and still obtain the same result as written in the paper.

Would you mind tell me where I can find the evaluation metrics you are using?  My results are from pesq in url, and Csig, Cbak, Covl in url
Thanks, again

Hi, we are glad to have your appreciation.
Sorry for the late update for this repo, and the current version provides the model weights matching the best result reported in our paper.
I've tested it again using the provided weights and still obtain the same result as written in the paper.

Sorry for asking again, I think there are no model weights,  only config (.json) files in the link you provide. I thought they are the same as those in your GitHub repository, please check it again.
Thanks a lot

The link below is the source of evaluation metrics we used:
https://ecs.utdallas.edu/loizou/speech/software.htm
I've uploaded the weights, check again please, thx!

Hello, I have a similar problem with testing, I notice in the generator.py, one should write the dataset themselves. I want to use the dataset from dataset.py. But in that case, all audio will be cut to one second, is the model able to process variable length audio? And is the score mentioned in the paper based on one second or whole track?

Hello, I have a similar problem with testing, I notice in the generator.py, one should write the dataset themselves. I want to use the dataset from dataset.py. But in that case, all audio will be cut to one second, is the model able to process variable length audio? And is the score mentioned in the paper based on one second or whole track?

You can obtain full-length utterances by removing the truncating in dataset.py during testing.

Hello, I have a similar problem with testing, I notice in the generator.py, one should write the dataset themselves. I want to use the dataset from dataset.py. But in that case, all audio will be cut to one second, is the model able to process variable length audio? And is the score mentioned in the paper based on one second or whole track?

You can obtain full-length utterances by removing the truncating in dataset.py during testing.

Thank you very much!


The encoding of pillar

Thank you for excellent work. I'm a begginer. In your pillar encoder, has the number of points per pillar been limited by applying random sampling? Is it not dynamic encoding？

We follow the pillar encoder, we do not use dynamic encoding.


update helm chart to use inbucket version 2.0.0

What this PR does / why we need it:
Update charts to use inbucket version 2
Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #
n/a
Special notes for your reviewer:

/assign

/ok-to-test

@unguiculus all review comments seems to have been fixed - is it good to go?
I'll just assign it myself so I remember if you are not around atm. so we can merge it in a couple of days - hope that is OK - if not - let me know!
/assign

/lgtm


Update to React 0.14.0

Thoughts @jklein @kellegous?
Also going to do some other UI things but this seemed like a good place to start

Also working on updating everything to work with React 0.14.0. Bunch of places need to be updated to the new React API.

Updated the file includes to reflect the Dev vs Prod environment.