fix(core): 🐛 StateWriter should auto unsubscribe when read only #532

Purpose of this Pull Request
release subscribe callback when State become read only
Checklist Before Merging
Please ensure the following are completed before merging:

[x] If this is linked to an issue, include the link in your description.
[x] If you've made changes to the code or documentation, make sure these are updated in the CHANGELOG.md file.
[x] If you've introduced any break changes, briefly describe them in the Breaking section of the CHANGELOG.md file.

Additional Information
If you're unsure about which branch to submit your Pull Request to, or when it will be released after being merged, please refer to our Release Guide.
If you're working on a widget and need help writing test cases, we have some macros that can assist you. Please refer to the Ribir Dev Helper documentation.

I think this is not the best solution. It's not only the split reader issue, it's a more general problem that "uses a state self in its subscribe downstream introduce cycle reference".

I think this is not the best solution. It's not only the split reader issue, it's a more general problem that "uses a state self in its subscribe downstream introduce cycle reference".

I don't think this is the same question. Just see the example below
let writer = Stateful::new(());
let data = Data{};
writer.subscribe(move |_| {
   data.do_something()
   ....
});
...
let reader = writer.clone_writer();
drop(writer);
// reader is live
.....

the data will be alive although the subscribe would not be  trigger again until all the reader be drop.

I think this is not the best solution. It's not only the split reader issue, it's a more general problem that "uses a state self in its subscribe downstream introduce cycle reference".

I also encounter the self cycle reference at when subscribe  now, and I prefer the writer can export api to clone writer will not inc_writer().

I think this is not the best solution. It's not only the split reader issue, it's a more general problem that "uses a state self in its subscribe downstream introduce cycle reference".

I don't think this is the same question. Just see the example below
let writer = Stateful::new(());
let data = Data{};
writer.subscribe(move |_| {
   data.do_something()
   ....
});
...
let reader = writer.clone_writer();
drop(writer);
// reader is live
.....

the data will be alive although the subscribe would not be trigger again until all the reader be drop.

Only Stateful in the example, the same operation is already performed in Stateful::drop, are you referring to the "split_reader"?
This seems to be more of an optimization rather than a memory leak issue. Perhaps the title could be revised to "Unsubscribe when no writer exists" for clarity. The current title might be misleading.

the code example has a typo, the  *** let reader = writer.clone_writer() *** should be *** let reader = writer.clone_reader() ***,
And in this example, the data may not be release until the reader drop  is not be cause by self cycle reference
in some sense,  if the reader is keep through the app life, the data in subscribe closure will not be released, I think this is a memory leak too.

Both the reader and writer support the subscribe function. If the reader is not dropped, retaining the data is acceptable and does not constitute a memory leak. However, since we know the data will not change, we can unsubscribe earlier as an optimization.


[Docs] add this extension to Meshery.io/extensions

Current State
This is a new extension and it is not represented in the project website under the extensions collection.
Desired State
Given a brief description of the plugin and it’s functionality, this a new card can be made and added to the extensions collection on meshery.io

Contributor Guides and Handbook

📚 Instructions for contributing to documentation

Meshery documentation site and source

🛠 Meshery Build & Release Strategy
🎨 Wireframes and designs for Meshery UI in Figma (open invite)
🙋🏾🙋🏼 Questions: Discussion Forum and Community Slack

assign it to me please
@leecalcote

@MU5A, is this done?

There's no activity, it seems. I can handle this...

@fitzergerald its done already I will be pushing a PR
@winkletinkle

meshery.io/extensions now has this card. 👍


TP command returns player has no cordiniates

When using tp command the command returns a player coordinates not found.

Fixed.


Excute coco_object_detection:preprocess_coco_minival error(ImportError: cannot import name preprocessing_steps_pb2)

@tensorflow/micro
System information

Host OS Platform and Distribution (e.g., Linux Ubuntu 16.04): Linux Ubuntu 16.04
TensorFlow installed from (source or binary): source
Tensorflow version (commit SHA if source): master
Target platform (e.g. Arm Mbed OS, Arduino Nano 33 etc.):

Describe the problem
INFO: Analyzed target //tensorflow/lite/tools/evaluation/tasks/coco_object_detection:preprocess_coco_minival (0 packages loaded, 0 targets configured).
INFO: Found 1 target...
Target //tensorflow/lite/tools/evaluation/tasks/coco_object_detection:preprocess_coco_minival up-to-date:
  bazel-bin/tensorflow/lite/tools/evaluation/tasks/coco_object_detection/preprocess_coco_minival
INFO: Elapsed time: 0.242s, Critical Path: 0.01s
INFO: 0 processes.
INFO: Build completed successfully, 1 total action
INFO: Running command line: bazel-bin/tensorflow/lite/tools/evaluation/tasks/coco_object_detection/preprocess_coco_minival '--images_folder=/paddle/data/coco/INFO: Build completed successfully, 1 total action
Traceback (most recent call last):
  File "/root/.cache/bazel/_bazel_root/71ecaedffe808614528ea8e9600b0716/execroot/org_tensorflow/bazel-out/k8-opt/bin/tensorflow/lite/tools/evaluation/tasks/coco_object_detection/preprocess_coco_minival.runfiles/org_tensorflow/tensorflow/lite/tools/evaluation/tasks/coco_object_detection/preprocess_coco_minival.py", line 39, in <module>
    from tensorflow.lite.tools.evaluation.proto import evaluation_stages_pb2
  File "/root/.cache/bazel/_bazel_root/71ecaedffe808614528ea8e9600b0716/execroot/org_tensorflow/bazel-out/k8-opt/bin/tensorflow/lite/tools/evaluation/tasks/coco_object_detection/preprocess_coco_minival.runfiles/org_tensorflow/tensorflow/lite/tools/evaluation/proto/evaluation_stages_pb2.py", line 16, in <module>
    from tensorflow.lite.tools.evaluation.proto import preprocessing_steps_pb2 as tensorflow_dot_lite_dot_tools_dot_evaluation_dot_proto_dot_preprocessing__steps__pb2
ImportError: cannot import name preprocessing_steps_pb2

Please provide the exact sequence of commands/steps when you ran into the problem
bazel run //tensorflow/lite/tools/evaluation/tasks/coco_object_detection:preprocess_coco_minival --  \
--images_folder=/paddle/data/coco/val2017  \
--instances_file=/paddle/data/coco/annotations/instances_val2017.json  \
--output_folder=../models/research/coco_data/

I try commend:
wget -O protobuf.zip https://github.com/google/protobuf/releases/download/v3.0.0/protoc-3.0.0-linux-x86_64.zip
./bin/protoc tensorflow/lite/tools/evaluation/proto/*.proto --python_out=.

But not useful.

I am handling this issue.
Was able to reproduce it.

@still-wait it should be fixed in the master branch. please take a look. I'll close this issue.
Please reopen if it still happen.


Update descriptions of how flags are pushed/popped

The document stated that flags are unaffected by pop af, which is outright wrong. This also adds a description of how flags are written to memory, for example to assist in debugging, or for 31337 programmerz who push af ; pop de.

Thanks for this! The dangers of copy paste are real... :P
Just a small detail, could you sign off your commit?

Here you go!

Thanks.


Segmentation fault (core dumped)

Getting a Segmentation fault (core dumped) error when running the code:analyse. Just running phpstan analyse app seems to work fine.
With php artisan code:analyse:
vagrant@homestead:~/code$ php artisan code:analyse
  24/410 [▓░░░░░░░░░░░░░░░░░░░░░░░░░░░]   5%Segmentation fault (core dumped)
vagrant@homestead:~/code$ php artisan code:analyse
PHPStan crashed in the previous run probably because of excessive memory consumption.
It consumed around 32 MB of memory.

To avoid this issue, allow to use more memory with the --memory-limit option.
  24/410 [▓░░░░░░░░░░░░░░░░░░░░░░░░░░░]   5%Segmentation fault (core dumped)

With phpstan analyse app:
vagrant@homestead:~/code$ phpstan analyse app
PHPStan crashed in the previous run probably because of excessive memory consumption.
It consumed around 32 MB of memory.

To avoid this issue, allow to use more memory with the --memory-limit option.
 410/410 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%

vagrant@homestead:~/code$ phpstan analyse app
 410/410 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%

Seems like limiting the number of files works:
Works:
vagrant@homestead:~/code$ php artisan code:analyse --paths=app/Http/Requests/Article
7/7 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%

Breaks:
vagrant@homestead:~/code$ php artisan code:analyse --paths=app/Http/Requests/
  72/130 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓░░░░░░░░░░░░░]  55%Segmentation fault (core dumped)

Run PHPStan with --debug to find out which file causes it.

extension.neon:
bootstrap: %rootDir%/../../nunomaduro/larastan/bootstrap.php
bootstrap.php:
$app->make(\Illuminate\Contracts\Console\Kernel::class)->bootstrap();
Makes it fail.

@phh That's strange. Besides "Segmentation fault (core dumped)". You don't have any other feedback?

Sorry, not really getting that much:
vagrant@homestead:~/code$ art code:analyse --debug
PHPStan crashed in the previous run probably because of excessive memory consumption.
It consumed around 10 MB of memory.

To avoid this issue, allow to use more memory with the --memory-limit option.
/home/vagrant/code/app/Api/Auth/Token.php
/home/vagrant/code/app/Api/Transformers/Brands/BrandTransformer.php
...
Segmentation fault (core dumped)

Just really a scan on the files and then a Segmentation fault in the end.

Sorry, I didnt list all the classes. But it just keeps going going through a few classes and then it breaks:
vagrant@homestead:~/code$ php artisan code:analyse --debug
PHPStan crashed in the previous run probably because of excessive memory consumption.
It consumed around 32 MB of memory.

To avoid this issue, allow to use more memory with the --memory-limit option.
/home/vagrant/code/app/Api/Auth/Token.php
/home/vagrant/code/app/Api/Transformers/Brands/BrandTransformer.php
/home/vagrant/code/app/Api/Transformers/Foods/AllergyTransformer.php
/home/vagrant/code/app/Api/Transformers/Foods/PreferenceTransformer.php
/home/vagrant/code/app/Api/Transformers/Ingredients/AllergyTransformer.php
/home/vagrant/code/app/Api/Transformers/Ingredients/CategoryTransformer.php
/home/vagrant/code/app/Api/Transformers/Ingredients/IngredientTransformer.php
/home/vagrant/code/app/Api/Transformers/Ingredients/NutritionTransformer.php
/home/vagrant/code/app/Api/Transformers/Ingredients/OriginTransformer.php
/home/vagrant/code/app/Api/Transformers/Ingredients/PreferenceTransformer.php
/home/vagrant/code/app/Api/Transformers/Ingredients/SeasonTransformer.php
/home/vagrant/code/app/Api/Transformers/Ingredients/StorageTypeTransformer.php
/home/vagrant/code/app/Api/Transformers/Media/MediaTransformer.php
/home/vagrant/code/app/Api/Transformers/Recipes/GroupedEquipmentTransformer.php
/home/vagrant/code/app/Api/Transformers/Recipes/GroupedIngredientsTransformer.php
/home/vagrant/code/app/Api/Transformers/Recipes/GroupedInstructionsTransformer.php
/home/vagrant/code/app/Api/Transformers/Recipes/Groups/EquipmentTransformer.php
/home/vagrant/code/app/Api/Transformers/Recipes/Groups/IngredientTransformer.php
/home/vagrant/code/app/Api/Transformers/Recipes/Groups/InstructionTransformer.php
/home/vagrant/code/app/Api/Transformers/Recipes/MediaTransformer.php
/home/vagrant/code/app/Api/Transformers/Recipes/RecipeTransformer.php
/home/vagrant/code/app/Api/Transformers/Recipes/ServingTypeTransformer.php
/home/vagrant/code/app/Api/Transformers/Units/UnitTransformer.php
/home/vagrant/code/app/Console/Commands/CommandExport.php
/home/vagrant/code/app/Console/Commands/ExportIngredientsToExcel.php
Segmentation fault (core dumped)

If I for instance remove the last file that failed ExportIngredientsToExcel it just goes to the next file and fails there.

Okay I've reset my dependencies and it seems to work. I will spend some time to see if I can find the cause of this.

Seems like version 0.1.1 fixes this.
Thanks!

@phh Great news! Thanks for your help! 💪


Any detailed schedule to release code?

Hi, there. Thanks for contributing an interesting work. I am wondering do you have any detailed plans about open source. Before ICLR or after?

Hi @wjc2830, we are going to release the full code around 1 week as we need to go through the company's review process.

Cool! Thanks for your prompt reply.

Hi @wjc2830, we have released the complete code and models of ControlAR.


_ Patch Compile Tests _

+1 :green_heart:
mvninstall
3m 54s
the patch passed

+1 :green_heart:
compile
0m 20s
the patch passed

+1 :green_heart:
javac
0m 20s
the patch passed

+1 :green_heart:
shadedjars
5m 22s
patch has no errors when building our shaded downstream artifacts.

-0 :warning:
javadoc
0m 17s
hbase-http in the patch failed.

_ Other Tests _

+1 :green_heart:
unit
0m 39s
hbase-http in the patch passed.

22m 28s

Subsystem
Report/Notes

Docker
Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1524/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1524

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux fa1b0a6323ef 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 38954edb25

Default Java
2020-01-14

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1524/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-http.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1524/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-http.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1524/1/testReport/

Max. process+thread count
477 (vs. ulimit of 12500)

modules
C: hbase-http U: hbase-http

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1524/1/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 39s
Docker mode activated.


fix: restore mac arm64 build

Switch macos arm64 to native build using macos-14 runner
Free up a bunch of disk space on the macos-14 runner before building, the build seems to take up at least ~30GB at peak

@faulpeltz sorry missed your feedback here 😅


Codelab Building beautiful UIs with Flutter mistake on page 4 (Build the main user interface)

Under the heading Build the chat screen, the first sub-heading (Create the FriendlyChatApp widget:)

Start typing ChatScreen, and select ChatScreen() from the popup. (Choose the ChatScreen entry that is marked with an equal sign inside the yellow circle. This gives you a class with empty parentheses, rather than a constant.)

The popup will only appear if the ChatScreen widget has already been created (which is done in the next sub-section).
So the steps of the next sub-section should be done before this step.

Under the FriendlyChatApp class, around line 27, start typing stless. The editor asks if you want to create a Stateless widget. Press Return to accept. The boilerplate code appears, and the cursor is positioned for you to enter the name of your stateless widget.

Enter ChatScreen.

Hi, I would like to work on the issue. Would appreciate if you could give me instructions on the same.

Hey@mbilalakmal I am very new to contributing It will be very nice of you if you can help me how to proceed

@TahaTesser could you  please point me out to the source code of this codelab I dont see it in flutter/website repo

@maheshmnj  https://github.com/flutter/codelabs

I am working on this issue.

@maheshmnj https://github.com/flutter/codelabs

I tried twice to find a particular file where I have to make the changes. But was unable to find.
Can you please help me to find it?

@Roshan13046 I searched a bit back then and found that the source code is not public for that codelab as mentioned here https://github.com/flutter/friendlychat-steps/issues/89

@Roshan13046 I searched a bit back then and found that the source code is not public for that codelab as mentioned here flutter/friendlychat-steps#89

Thanks!

@Roshan13046 I searched a bit back then and found that the source code is not public for that codelab as mentioned here flutter/friendlychat-steps#89

Does this mean none of the codelabs issues can be fixed as their source code repo is not open source?

cc @domesticmouse

@Roshan13046 the source code for Flutter codelabs is in the flutter/codelabs repository. However, the text content of the codelabs is internal because we utilise Google internal infrastructure to publish it.

I ran into this same issue 2 years after the issue was first reported.  I believe the instructions are incomplete. Step 4 of the instructions read:

Select the block of text after home:. Start with Scaffold( and end with the Scaffold's closing parenthesis, ). Do not include the ending comma.

Step 5 should be reworked to read:

Right-click, and select Refactor > Extract > Extract Flutter widget. Enter ChatScreen into the ExtractWidget dialog, and click the Refactor button. The Scaffold code is placed in a new stateless widget called ChatScreen, and MaterialApp( home: is updated to call that class when MaterialApp() is called from the FriendlyChat build() function.

By performing the revised step 5, it produced the ChatScreen class exactly as shown in the sample:
https://github.com/flutter/codelabs/blob/master/friendly_chat/step_04/lib/main.dart

Friendly chat has been retired in favour of Take your Flutter app from boring to beautiful.


August 2023 has passed and the table can be simplified

August 2023 has passed and the table can be simplified based on that.

Raised PR #45.
Sadly, it'll never get simpler, the row just moves:
https://support.google.com/googleplay/android-developer/answer/11926878


Not an issue, but a question

For the record, I love what you have done. Love the simplicity and easy of use. Much kudos.
So now to my question - the langchain examples only use langchainJS. Are there plans (or a current solution I failed to RTFM) for Python?

Please do RTFM, though.
A cursory search uncovered this documentation here:
https://github.com/ollama/ollama/blob/main/docs/tutorials/langchainpy.md
I've only tried out ollama recently, but it's an LLM server with a web API, so why wouldn't you use it from both JS and Python in the same way?  No language bindings are needed.

@pedrocassalpacheco This might help you if you want to use ollama with langchain python, https://python.langchain.com/docs/integrations/llms/ollama

FWIW there are official JS and Python Ollama client libraries if you want a quick and simple of interactiving with Ollama programmatically


config.EnableRegExFunctions() doesn't indicate that these functions are Preview

IsMatch, Match, and MatchAll functions are not finished, we need to reconcile the regular expression language here with what is in Canvas.
We need some way to indicate to a host that these functions are not GA.  Currently, all a host needs to do is call config.EnableRegExFunctions() which looks like config.EnableSetFunction(); and config.EnableParseJSONFunction(); which are GA.
Either a Engine.Features flag needs to be used, or the name of the enable function needs to be descriptive, something like config.EnableRegExFunctions_Experimental();

We currently require the pattern is a string literal - that's good.
But we:

allow more things in C# than we allow in PA
handle some cases differently between C# and PA

So we will need to change semantics of the pattern to ensure C#/PA behave the same.


some languages are part of language families and should be interchangeable.

From 5e PHB, p. 123
Some of these languages are actually families of languages with many dialects. For example, the Primordial language includes the Auran, Aquan, Ignan, and Terran dialects, one for each of the four elemental planes. Creatures that speak different dialects of the same language can communicate with one another.

See #11


Huntingdon HUN

The parishes have been entered without the place name before them. I have made the correct entries available.
Please move the search records from the individual parishes to the full place name and delete the parishes without a place name.
Geoff

which piece(s)?

Rhoda
The parishes that are entered as alternative names without Huntingdon before them.
 If so it will take a long time for me to do each one manually (It's not a spreadsheet). Or is there meant to be an attachment showing me which piece(s) this refers to? When you say you have "made the correct entries available" where do I find them please?

I think I understand now - for all years, these 4 Huntingdon parishes - All Saints, St Mary, St Benedict, St John, rename them with the name Huntingdon in front of them and make sure they have, eg, Huntingdon St Mary as their place name? As they are all alternate placenames under the umbrella of Huntingdon, do you me to make the 4 place names into 4 primary placenames or can they stay under Huntingdon?

Done


Revision already exists should yield 409 instead of 403

For the case where a revision already exists for a given published Collection when the curator tries to create a revision via POST /collections/{collection_id}/revision, I think a 409 would make a lot more sense than a 403.
Although I'm open to considering another error code. I just think Forbidden is the wrong choice, esp given that it implies permanence.

There's a related note in https://github.com/chanzuckerberg/single-cell-data-portal/issues/2161
For POST .../revision, the 409 failure case is poorly documented as "File conflict" instead of documenting that there is an existing revision and only one revision for a public collection is allowed to be in progress at a time. If a curator attempts to revise a revision, the 403 (Forbidden) failure cause is NOT documented in the current swagger. Why is there not one common status code used for these cases?

6.5.3.  403 Forbidden
The 403 (Forbidden) status code indicates that the server understood
the request but refuses to authorize it.  A server that wishes to
make public why the request has been forbidden can describe that
reason in the response payload (if any).

Also see curation-api


PNPiechart description label overlapping

when pnpiechart having 91%, 3% , 3%, 2%,1% with description label it's overlapping.
It will be good  if i can make marker for description around pie chart,
I need your help

@ZhangHang Do you have time to keep up?

0.8.7 don't have hideValues property?


Add example SAS program to create large (5Gb) XPT file

Added a program (examples\big_xpt\create_big_xpt.sas) that can create a very large XPT file for testing.

Lex, thank you for the updates. I have approved the PR, could you please merge it.


fix: mix tasks should generally prompt user for args

Per #71
This changes some of the formatting of the generated mix task parameters so that users will be prompted to input any args. This preserves the programmatic functionality of run_template({name = "mix", params = {args = {'taskname', '--flag', '-o', 'option'}}})

this works great! affects only the mix case, and lets the user enter the parameters. i didn't think it was possible just by modifying the mix plugin!
i would have only two minor extra wishlist items, but already as it is, it's a real progress compared to the previous situation. you can totally ignore this.

the way it works, in case that task doesn't require any parameter, the user must press enter twice: first to validate the args, then the subcmd (which we just picked). it would be great if we had to press enter once. but.. detail
it would be great if it was possible to override for a specific task in the user's config, to say, "for this task no need to ask for parameters". again.. detail wishlist

all in all, i would really like to thank you for the time you invested in this! much appreciated.

There isn't a way to completely override, but you could for example define your own task that has the same name with a lower priority. That should functionally do nearly the same thing.


[i2c, rtl] Initial incomplete implementation of i2c target mode

Added registers for i2c target mode
Added target tx and acq fifos
Added target ports to FSM (FSM not functional in target mode yet)

Signed-off-by: Igor Kouznetsov<EMAIL_ADDRESS>

@igk8 it's LGTM although there is CI error since DV has not updated to adopt new RTL. Once this PR is approved, I will submit another PR for DV to fix the CI error.

LGTM from my side.
however, we need to approach merging a bit differently here. we can't just merge the PR as-is, since that would break CI on the master branch (and hence all other PRs would start to fail in CI).
@tunghoang290780 can you make a quick DV fix in a separate commit that we could pile onto this PR such that CI passes? It does not have to be the complete DV update, we can also just disable a particular check for the time being.

@msfschaffner Agree. let hold this one until my up-coming DV PR


[vscode] Support workbench.action.debug.start and workbench.action.debug.run

Currently, there is Run | Debug above fn main() {, which works well, but is kind of annoying as it is always visible.
It would be better if the built-in commands could be used (without configuring launch.json), same as what was described in https://github.com/rust-lang/rls-vscode/issues/557#issuecomment-479969903

"editor.codeLens" in settings.json will disable Run | Debug (and X implementations lens for structs as well)
It's wrong to use workbench.action.debug.start or workbench.action.debug.run since it is private vscode API. Public one is startDebugging and it is used in the Debug Lens internally.
BTW, https://github.com/rust-analyzer/rust-analyzer/pull/4448 made launch.json configuration pretty trivial. Might be it will work for you?

"editor.codeLens" in settings.json will disable Run | Debug

That's the nuclear option. I do want code lens, just not this code lens (because running / debugging the program is something that the debug / run commands are for, I don't see why they should be triggered through a code lens). But it's a minor thing that I can live with.

It's wrong to use workbench.action.debug.start or workbench.action.debug.run since it is private vscode API. Public one is startDebugging and it is used in the Debug Lens internally.

That's not what I meant at all. Let me clarify. There are different providers (I don't know what the correct term is) when you try to use the debug / run commands, including Node.js (built-in one). I understand that "debugger extensions" can add providers to that list: https://code.visualstudio.com/api/extension-guides/debugger-extension - for example, the C/C++ extension adds a provider there - it's the same idea mentioned in https://github.com/rust-lang/rls-vscode/issues/557#issuecomment-479969903

That's the nuclear option.

Agreed. We can have a separate configuration option to hide Run | Debug. Easy to add.

There are different providers...

I see. You are talking about  DebugConfigurationProvider (DCP) . There are two difficulties with them:

At the moment there is no way to export a debug configuration from a DCP to the launch.json.

There might be numerous debug targets (hundreds of tests for example) and it takes significant time to find them all and make available via the DCP. The current solution, on the other side, looks for runnables only in the current file. It is much faster.

The former scheduled to be fixed in the next vscode milestone. But the latter stops me from implementing DCP.

Hmm, though it should be possible to dynamically update DCP and show only runnables from the current file. It's a DCP new feature from the April vscode (version 1.45). I'll take a stab at this.

I'm very new to Rust, but is it not possible to just support cargo run? For an end user like me, it seems correct that that's what the debug / run commands should do.

just support cargo run

This is exactly what rust-analyzer.run command does (obviously it uses cargo test for tests). rust-analyzer.debug is a bit trickier, but in the end it also uses cargo commands.

We can have a separate configuration option to hide Run | Debug. Easy to add.

Done in #4499

I believe we need API from LSP/VS Code to make this work really nice: https://github.com/microsoft/language-server-protocol/issues/944


Commit of the results of ant updateMetaXml

Warning
Info

This release now requires Contacts & Organizations (npe01) version 3.1 and Recurring Donations (npe03) version 3.2

Issues

Closing this pull request since it stripped newlines from all meta.xml files.  A separate pull request will include the same changes without the stripped newlines.


Failure when compiling packages named the same, with the same package/blob checksums, from two releases

Tried deploying these two releases together in the same deployment today on my bosh-lite:
releases:
- name: cf-rabbitmq
  version: 215.9.0
- name: rabbitmq-metrics
  version: 1.29.0

They both have a golang package, and each package's packaging and golang/go1.6.1.linux-amd64.tar.gz files have the same checksums:
2614edf1b19b46a86272be883eb1d1bffb3c1c76  golang-rmq-metrics/packaging
2614edf1b19b46a86272be883eb1d1bffb3c1c76  golang-rmq/packaging
c73492474dcc7a233772d27e948b74468d9f1849  golang-rmq-metrics/golang/go1.6.1.linux-amd64.tar.gz
c73492474dcc7a233772d27e948b74468d9f1849  golang-rmq/golang/go1.6.1.linux-amd64.tar.gz

When I deployed, I got the following error from BOSH:
E, [2016-10-14 17:58:29 #7597] [task:535] ERROR -- DirectorJobRunner: object id golang-1a4729b73e51c23d864b5af2b73c406ce857c7c7 is already in use
/var/vcap/packages/director/gem_home/ruby/2.1.0/gems/blobstore_client-1.3232.2.0/lib/blobstore_client/local_client.rb:20:in `create_file'
/var/vcap/packages/director/gem_home/ruby/2.1.0/gems/blobstore_client-1.3232.2.0/lib/blobstore_client/base.rb:27:in `create'
/var/vcap/packages/director/gem_home/ruby/2.1.0/gems/bosh-director-1.3232.2.0/lib/bosh/director/blob_util.rb:44:in `block (2 levels) in save_to_global_cache'
/var/vcap/packages/director/gem_home/ruby/2.1.0/gems/bosh-director-1.3232.2.0/lib/bosh/director/blob_util.rb:43:in `open'
/var/vcap/packages/director/gem_home/ruby/2.1.0/gems/bosh-director-1.3232.2.0/lib/bosh/director/blob_util.rb:43:in `block in save_to_global_cache'
/var/vcap/packages/ruby/lib/ruby/2.1.0/tmpdir.rb:88:in `mktmpdir'
/var/vcap/packages/director/gem_home/ruby/2.1.0/gems/bosh-director-1.3232.2.0/lib/bosh/director/blob_util.rb:37:in `save_to_global_cache'
/var/vcap/packages/director/gem_home/ruby/2.1.0/gems/bosh-director-1.3232.2.0/lib/bosh/director/deployment_plan/steps/package_compile_step.rb:95:in `block in compile_package'
/var/vcap/packages/director/gem_home/ruby/2.1.0/gems/bosh-director-1.3232.2.0/lib/bosh/director/lock_helper.rb:48:in `block in with_compile_lock'
/var/vcap/packages/director/gem_home/ruby/2.1.0/gems/bosh-director-1.3232.2.0/lib/bosh/director/lock.rb:53:in `lock'
/var/vcap/packages/director/gem_home/ruby/2.1.0/gems/bosh-director-1.3232.2.0/lib/bosh/director/lock_helper.rb:48:in `with_compile_lock'
/var/vcap/packages/director/gem_home/ruby/2.1.0/gems/bosh-director-1.3232.2.0/lib/bosh/director/deployment_plan/steps/package_compile_step.rb:59:in `compile_package'
/var/vcap/packages/director/gem_home/ruby/2.1.0/gems/bosh-director-1.3232.2.0/lib/bosh/director/deployment_plan/steps/package_compile_step.rb:204:in `block (2 levels) in process_task'
/var/vcap/packages/director/gem_home/ruby/2.1.0/gems/bosh-director-1.3232.2.0/lib/bosh/director/event_log.rb:91:in `call'
/var/vcap/packages/director/gem_home/ruby/2.1.0/gems/bosh-director-1.3232.2.0/lib/bosh/director/event_log.rb:91:in `advance_and_track'
/var/vcap/packages/director/gem_home/ruby/2.1.0/gems/bosh-director-1.3232.2.0/lib/bosh/director/deployment_plan/steps/package_compile_step.rb:202:in `block in process_task'
/var/vcap/packages/director/gem_home/ruby/2.1.0/gems/bosh_common-1.3232.2.0/lib/common/thread_formatter.rb:49:in `with_thread_name'
/var/vcap/packages/director/gem_home/ruby/2.1.0/gems/bosh-director-1.3232.2.0/lib/bosh/director/deployment_plan/steps/package_compile_step.rb:198:in `process_task'
/var/vcap/packages/director/gem_home/ruby/2.1.0/gems/bosh-director-1.3232.2.0/lib/bosh/director/deployment_plan/steps/package_compile_step.rb:162:in `block (4 levels) in compile_packages'
/var/vcap/packages/director/gem_home/ruby/2.1.0/gems/bosh_common-1.3232.2.0/lib/common/thread_pool.rb:77:in `call'
/var/vcap/packages/director/gem_home/ruby/2.1.0/gems/bosh_common-1.3232.2.0/lib/common/thread_pool.rb:77:in `block (2 levels) in create_thread'
/var/vcap/packages/director/gem_home/ruby/2.1.0/gems/bosh_common-1.3232.2.0/lib/common/thread_pool.rb:63:in `loop'
/var/vcap/packages/director/gem_home/ruby/2.1.0/gems/bosh_common-1.3232.2.0/lib/common/thread_pool.rb:63:in `block in create_thread'
/var/vcap/packages/director/gem_home/ruby/2.1.0/gems/logging-1.8.2/lib/logging/diagnostic_context.rb:323:in `call'
/var/vcap/packages/director/gem_home/ruby/2.1.0/gems/logging-1.8.2/lib/logging/diagnostic_context.rb:323:in `block in create_with_logging_context'

This may be bosh-lite specific due to its global package cache features?

From @cppforlife on https://github.com/cloudfoundry/bosh-init/issues/114#issuecomment-253893358...

definitely related to global cache

Same problem here. Multiple workers compiling the same packages, together with global cache leads to that error. Was that introduced some time recently or why is this showing up right now?

We're looking to remove the global package cache in the mid-future in favor of a push towards more compiled releases. As a result, I don't see us prioritizing this work, so I'm going to close this issue.


Babelify only test files

I think we should apply babel only to test files, e.g test.js, test/test-something.js.
Currently, if you have this common code:
const test = require('ava');

const mylib = require('./');

mylib will also be run through babel and that is not good, because that way AVA transforms library's source code. This behavior could be fixed by setting a regex for require('babel/register') to whitelist only test files.

:+1:


[chore](dynamic schema) throw exception when property contains dynami…

…c schema
Proposed changes
Issue Number: close #xxx

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall

run buildall


Support data-* attributes

Received request via email:

I have a big request. Can you the HTML attributes (like
mag-zoomed-containers) to the standard data-mag... change? The HTML is
not valid.
Thank you and best regards,
Torsten

Released in version 2.2.0.


numbers not matching in the screenshot

[Enter feedback here]

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 1fd3e188-c59c-c204-fa15-d5ec7b7deebd
Version Independent ID: f5d79338-4296-c9b1-9979-762101d2976a
Content: Status and trend work item, query-based charts - Azure DevOps
Content Source: docs/report/dashboards/charts.md
Service: azure-devops
Sub-service: azure-devops-analytics
GitHub Login: @KathrynEE
Microsoft Alias: kaelli

@martinman-hrbl -- thank you for catching this discrepancy.  This is an example, and while the numbers should match, the intent is clear.
cc @KathrynEE for awareness
I am closing this issue now.  You are welcome to @ mention me for any followup.  We hope to hear from you again.

@martinman-hrbl - The image is correct as is. The Legend shows the Priority values which are defined as Priority 1, 2, and 3. So there are 4 Priority 2 items, 3 Priority 1 items, and 1 Priority 3 item.  This adds up to 8 items total.


Config option to start disabled

This seems like a really useful plugin. Would it be possible to have an option to start disabled?  I use blamer.nvim very occasionally. It's indispensible when I want it turned on, but I don't want it turned on very often. It seems I would want nvim_context_vt turned on more often, but still not all the time (and not by default at startup).

Thanks for the suggestion! I'll implement this ASAP.

You should now be able to do:
require('nvim_context_vt').setup({
  enabled = false,
})

And then :NvimContextVtToggle to manually enable on demand.

Thanks for the quick implementation!


how to bind some arg to all actions ?

hi everyone, i have a problem.
i want to send some objects to actions before component render. how can i do that ?
my currently solution:
<Button onClick={actions.bind(null, data)} label="OK"/>
but this i have to bind each action on my component, that's too bad.
how can i bind data object to all actions in once?
thanks so much !

I believe you need a container component to link actions down to presentational components. I've found it pretty consistent to have a related container component for practically every single presentation component that needs to manage a state or link up an action. Then, you pass the actions as props using useDeps. It seems like overkill in theory, but in practice just about all of the container components are needed to properly manage the data aspect of the components.
Hope this helps? 😬


Disable cups printf functions on build flags if can build .

As for as know , cups that print server for like-unix system , but now we could not  need it ,Hope you choose enable or disable it , for web browser , cups is unuseal for many people that use browse world wide web  contents .
Thanks!

when i not install cups and run thorimum it depend on libcups that cups software .

@funymeleehao @meleehao Chromium based browsers will not run without cups installed. The code inside it for printing expects it to be there.


table Creator - Web design #34

https://images01.nicepagecdn.com/page/96/20/html-template-96208.jpg Design a table like the above image
Create a file "table_NUM_by_(YourName).html" in the modules/table folder.
Use simple HTML and CSS and JAVASCRIPT to create the table animation. You can use the interface development https://kwickerhub.com/ (This project) or you can write the lines of code yourself.
Step by Step Guide.
Fork this project(Use the 'fork' button in the top right corner) and Clone your Fork.
git clone https://github.com/YOUR_USERNAME/frontend
Open your code Editor and Create a file "table_NUM_YOUR_NAME_.html" in the "modules/table" folder of this project you just cloned. No need to create head, title and body tags, Just Add a div tag with some embedded style(i.e use the style tag) and the script tag where necessary.
If you want to add an image resource, please add it in the folder ••
"modules/table/images_and_icons"
We recommend you use an svg for your image/icon.
Push your Code: You need to push your recent changes back to the cloud. Use the command below in the main directory of this Repository
git push origin dev
or use a GUI tool to avoid mistakes or complexity. LOL.
Then make you Pull Request...
Below is a example of the code structure we need:
'''

'''
For more examples:
modules->buttons
modules->cards
for examples of contributions or Pull request accepted in to the project.
And please do not wait for this issue to be assigned to you as we have limited hands but have a lot to do/cover. Please send in your PR.
Good-luck.

@NtemKenyor hey want to work on this issue.
Can you assign it to me?

Hey @NtemKenyor, I have been working in frontend development for a while now, and I have experience in developing numerous web tables. Could you please assign this task to me?

i have some experiance in HTML CSS. Could you please assign to me.

yea please go on. We also have many other issues...
On Sat, Sep 30, 2023, 23:17 Himank Patidar @.***> wrote:

i have some experiance in HTML CSS. Could you please assign to me.
—
Reply to this email directly, view it on GitHub
https://github.com/KwickerHub/frontend/issues/385#issuecomment-1741871113,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AOKWIBOTG5ULP6DL5EBPUFTX5CLAXANCNFSM6AAAAAA5NVZZLU
.
You are receiving this because you were mentioned.Message ID:
@.***>

please assign me this issue, I am a beginner  in the field of open source but have sufficient knowledge of frontend developement

hey @NtemKenyor can you assign this issue to me, you can view my projects in the field of web development on my GitHub account, awaiting for the issue to get assigned to me...

hey,@myself-vishwajeet I want to work on this issue .
Can you assign it to me?

Can I work with this issue?

I will work up to your expectation , assign it to me...

Can you assign it to me? Actually, make it
https://github.com/TARANjee/frontend
You can check it.

Hello @NtemKenyor , I see that many people have committed to work on this PR but they haven't delivered yet. Could you please assign it to me? I'll resolve the issue and push a PR within a week. Please let me know.

Hi @NtemKenyor ,
I have added table_by_36_Jagathi.html file to the modules/table folder. Can you please review and merge it. PR-https://github.com/KwickerHub/WebCraftifyAI/pull/833
Thanks,
Jagathi


feat: add Bedrock support

Hi !
I have the issue below from bedrock-init_1. It seems something is wrong with the connection to download bedrock file

bedrock-init_1    | curl: (56) OpenSSL SSL_read: Connection reset by peer, errno 104
simple-optimism-node_bedrock-init_1 exited with code 56

bedrock-init_1    | Downloading bedrock.tar...
healthcheck_1     | {"level":30,"time":1686366721760,"msg":"starting app server"}
healthcheck_1     | {"level":30,"time":1686366721773,"port":7300,"hostname":"<IP_ADDRESS>","msg":"app server started"}
healthcheck_1     | {"level":30,"time":1686366721773,"msg":"starting main loop"}
healthcheck_1     | {"level":50,"time":1686366721788,"msg":"target client not connected"}
fault-detector_1  | {"level":30,"time":1686366722574,"msg":"starting app server"}
fault-detector_1  | {"level":30,"time":1686366722593,"port":7300,"hostname":"<IP_ADDRESS>","msg":"app server started"}
fault-detector_1  | {"level":30,"time":1686366722593,"msg":"initializing service"}
fault-detector_1  | {"level":30,"time":1686366722593,"msg":"waiting for L1 provider..."}
fault-detector_1  | {"level":30,"time":1686366723470,"msg":"L1 provider connected"}
fault-detector_1  | {"level":30,"time":1686366723470,"msg":"waiting for L2 provider..."}
fault-detector_1  | {"level":30,"time":1686366723473,"msg":"L2 provider not connected, retrying..."}
bedrock-init_1    | curl: (33) HTTP server doesn't seem to support byte ranges. Cannot resume.
simple-optimism-node_bedrock-init_1 exited with code 33

Hmmm weird sounds like Cloudflare R2 isn't handling the byte range request that would be needed to resume the download. Gonna see if that's something I can fix on the Cloudflare side or if I need some other mechanism to resume downloads.

Hmmm weird sounds like Cloudflare R2 isn't handling the byte range request that would be needed to resume the download. Gonna see if that's something I can fix on the Cloudflare side or if I need some other mechanism to resume downloads.
Edit: I ran the curl command locally and resuming the download seems to work fine. Gonna dig in more... Edit: I wasn't able to reproduce this. Can you try changing set -eou to set -exu at the top of init-bedrock.sh to get more detailed output about what's being executed?

Is this the file mainnet_bedrock.rar that we're gonna download ?
It's good if we can have an option to in .env to extract a local file. That could save time.
I'll test the command above and come back later

After downloading the file for 285gb. bedrock init is dead. We need a mechanism to resume the download process

bedrock-init_1    | ++ ls -l /downloads/bedrock.tar
' Wed, $'Accept-Encoding\r' $'max-age=14400\r' $'MISS\r' '{"endpoints":[{"url":"https:\/\/a.nel.cloudflare.com\/report\/v3?s=IxMvEzP2GRNh3Kr7WD73y066J2PhYV2YU62HiPNOIiRQzlmG7ni%2BjL9inaBSKcuzJKr3wRy%2FYgrD7Y809J' $'cloudflare\r' $'7d53ec398b49f138-CDG\r' 'h3=":443";' '{printf "Download Progress: %.2f%%\n", $5/size*100}'
bedrock-init_1    | awk: line 2: syntax error at or near end of file
bedrock-init_1    |
bedrock-init_1    | + echo ''
bedrock-init_1    | + true
bedrock-init_1    | + sleep 60
bedrock-init_1    | ++ ls -l /downloads/bedrock.tar
' Wed, $'Accept-Encoding\r' $'max-age=14400\r' $'MISS\r' '{"endpoints":[{"url":"https:\/\/a.nel.cloudflare.com\/report\/v3?s=IxMvEzP2GRNh3Kr7WD73y066J2PhYV2YU62HiPNOIiRQzlmG7ni%2BjL9inaBSKcuzJKr3wRy%2FYgrD7Y809J' $'cloudflare\r' $'7d53ec398b49f138-CDG\r' 'h3=":443";' '{printf "Download Progress: %.2f%%\n", $5/size*100}'
bedrock-init_1    | awk: line 2: syntax error at or near end of file
bedrock-init_1    | + echo ''
bedrock-init_1    | + true
bedrock-init_1    | + sleep 60
bedrock-init_1    |
bedrock-init_1    | curl: (92) HTTP/2 stream 0 was not closed cleanly: INTERNAL_ERROR (err 2)

@smartcontracts using wget instead of curl will do. We experienced the same problem for r2, too 😭

@smartcontracts using wget instead of curl will do. We experienced the same problem for r2, too 😭

You can download the file with the link above and then use symbolic link to link it into the docker file.
ln -s path_to_source/mainnet_bedrock.rar path_to_docker/simple-optimism-node_torrent_downloads/_data/bedrock.tar
Simply disable the download part from bash script from file simple-optimism-node/scripts/init-bedrock.sh
echo "Fetching download link..."
#BEDROCK_TAR_DOWNLOAD=$(config "bedrock/$NETWORK_NAME/bedrock-download")
#echo $BEDROCK_TAR_DOWNLOAD

Re-run the docker and it should work :D
However the speed is slow. You might need to add --snapshot=false for start-op-geth.sh to speed up the process.

Hi hi, getting back to this. I just fixed the issue with the broken l2geth init script. Need to investigate the curl issue further.

curl with -C - is supposed to resume the download if possible, I wonder why it's breaking

Going to push an update that uses wget instead of curl

Ok pushed an update to use wget instead of curl

Gm, this branch works with Bedrock? Or still needs some fixes/features

Gm, this branch works with Bedrock? Or still needs some fixes/features

I confirm, it works with Bedrock


Add support for searching genre stations.

Backwards compatible implementation of API features documented in https://github.com/PromyLOPh/pandora-apidoc/pull/17.

575e1c5e89e16058aaa5d0d10412cec5f4718c69 fixes the PEP8 violations.

Two minor issues otherwise LGTM. Reviewing on my phone so I will cut a release tonight when I get home.

8cebc88561efd90cce3646363f7df9929962d172 addresses the comments to this PR - thank you for reviewing.

Released as 1.7.3


LANG-1680 Add support for standalone month formats

Contributed on behalf of the @opencastsoftware open source team

Interesting. two unicode issues - both easy to fix, and one issue that seems to work on Java 11, but 8

After investigating I have determined the Java 8, 11, and 17 all return different standalone short months for September in German which makes my tests unstable

Why not use code like java.time.Month.APRIL.getDisplayName(TextStyle.FULL, Locale.GERMAN)?

Is it safe to that only locales with 12 months are supported? In theory some locales can have thirteen months, although I am not sure there are any supported by Locales in the standard Java library.

Safe? I'm not sure how this is a security issue but an enum seems "safer" than open ended code...

Unfortunately there appears to be a bug in Java 8 (I have 1.8_0332) around getDisplayName of standalone values
This
Month.MARCH.getDisplayName(TextStyle.FULL_STANDALONE, Locale.GERMAN)

returns "3" using Java 8, but using Java 11 it returns "März"

Odd, I seem to have encountered a version of https://bugs.java.com/bugdatabase/view_bug.do?bug_id=JDK-8146356 but that claims to have been fixed in an earlier version of the 1.8 JDK than the one I'm running


Ability to implement on GCP with cloud storage interoperability

Any ETA on this? we're databricks customers who'd love to use this on GCS/GCP

@darrenhaken this will unfortunately sit in the issues list until somebody steps up to add GCP support similar to #136 which was recently contributed for Azure support

@rtyler @darrenhaken With  #136 merged, it may be as simple as adding gcs to the features. Then, according to the object store code, users just need to change there uri to gs:// instead of an s3 or azure prefix. It will require testing, but it may be an easy lift.

One of the things that I recently learned is that GCS supports S3 compatibility through their "Interoperability" feature, so it would technically be possible to just configure kafka-delta-ingest using the S3-compatible APIs for GCS.

Is a simple repoint of the S3 URI using AWS_ENDPOINT_URL enough for this change?


MAPEM Notebook results explode

Originally posted by @ashgillman in https://github.com/SyneRBI/SIRF-Exercises/issues/94#issuecomment-856709022

@KrisThielemans I'm confused again looking at this after the meeting. I think you had a different notebook open up? https://github.com/SyneRBI/SIRF-Exercises/blob/master/notebooks/PET/MAPEM.ipynb

Ah wait, maybe you meant to implement de Pierro per the synergistic notebook. Yes, that fixes the notebook.


Update multi-master docs to use location name constants

Update multi-master docs to use location name constants instead of hard-coded strings.

@rmarskell : Thanks for your contribution! The author, @markjbrown, has been notified to review your proposed change.

#sign-off


Add a keyboard shortcut or button that moves the focused window to another monitor

Description of the new feature / enhancement
(Feature like from DisplayFusion from Binary Fortress Software)
For a keyboard shortcut, when applying the keyboard shortcut, the focused/active window should be moved to the next monitor, same position on that monitor.
For a mouse button, it could be in the title bar, next to the minimize, maximize close button.  When clicked, the focused/active window should be moved to the next monitor, same position on that monitor.
Could be integrated into FancyZones.
Scenario when this would be used?
Whenever a user wants to move a window to another monitor.
It could be for sharing the window through a Teams call.
It could be for showing it to a colleague on another monitor that's more legible, or closer to his chair.
It could be a window containing documentation, that should be shown a longer time on a different monitor, while he works on something else on the main monitor.
Supporting information
No response

this already exists in Windows. Win+Shift+(left or right arrow keys). Are you describing something different here? /needinfo

When one is at the keyboard, the functionality in Windows is the easiest to use indeed.
When one is working with the mouse, moving to the keyboard is an extra action.
Think about this: When I would minimize a window and I am holding the mouse, would I use Alt-space and then _ ?
There's multiple ways to handle many actions.  One of them is easiest.  It depends on what you are doing at that moment.
So I'm suggesting to add another button in the top window bar, to switch a window to another screen.
The key shortcuts you suggest is not exactly the same as suggested though.  It moves a window to the next screen zone.  But keyboard-wise, it boils down to performing this shortcut a few times - all in all not so bad.
Not the ideal solution for mouse work though.  Hence my suggestion.

Since the keyboard shortcut exists, I would recommend updating your title and description to focus on the mouse behavior.


Update menu tab name

Fast Flags tab -> Engine Settings tab

Haven't touched Visual Studio in about four days but thank you for saving me the 8 seconds of effort it would've taken me to do this


Allow only mgf scans, update latest version of jar

Update: mztosqlite executor.awaitTermination flow modified to better handle large data sets processed in low resource environments. Especially when run with only 1 thread. This updates to revised recipe version

|  /tmp/tmp_82jwx2i/job_working_directory/000/4/tool_script.sh: line 9: mz_to_sqlite: command not found

You are too fast @tmcgowan - amazing. Conda package is not yet ready. We need to restart this one in ~20min.

@bgruening
Yes, I wanted to get this done before I started some other work this morning. I'll get back to this in the late afternoon.


Added: Test Interacts With Database

Implements assertions to check data in the database (assertDatabaseHas and assertDatabaseMissing).
Examples:
$this->assertDatabaseHas('users', ['id' => $userId, 'nickname' => 'John']);
$this->assertDatabaseMissing('users', ['id' => $userId, 'nickname' => 'John']);

You can also specify other comparison operators:
// Selects a user's orders that have a defined score
$this->assertDatabaseHas('orders', ['user_id' => $user_id, ['score', '<>', null]]);

How many other ways can you make up for it in laravel testing?

How many other ways can you make up for it in laravel testing?

It would be possible to directly check the model or utilize the query builder.
// Model
$user = User::where('nickname', 'John')->first();
$this->assertNotNull($user);

// Query Builder
$userExists = DB::table('users')->where('nickname', 'John')->exists();
$this->assertTrue($userExists);

The benefit of these suggested assertions is a simpler syntax and improved readability of the automated test.

LGTM


fix: disallow using duplicate chars for jumpy.primaryCharset

This is an improvement over https://github.com/krnik/vscode-jumpy/commit/6a95264b0f73cc1a835488e572999c9a24299874, since we only need to deduplicate user-provided primary chars, we can restrict the user input when setting jumpy.primaryCharset.

@krnik Oops mistyped the commit message, you can amend jump.primaryCharset to jumpy.primaryCharset.

It's fine ;]


Mocks with the same verifiable invocation setup multiple times

const m = Mock.ofInstance(a => { });
m.setup(x => x(It.isValue(0))).returns(() => 0).verifiable();
m.setup(x => x(It.isValue(0))).returns(() => 0).verifiable();
m.object(0);
m.object(0);

m.verifyAll();

This fails with Verify Exception: Expected invocation on the mock 2 times, invoked 1 times. Is this not a supported scenario? I have a test where I set up several invocations, and a couple of them end up with the same expected signature. Is it expected that I only register each one once, then verify that it was called the correct number of times?

And is there any way to specify a different return value on later calls?
m.setup(x => x()).returns(() => 0);
m.setup(x => x()).returns(() => 1);
m.setup(x => x()).returns(() => 2);

always returns 2.

These two are indeed related scenarios.
Starting with the latter, it always returns 2 because until now only the newest setup was being considered. This also explains why the first verifiable is failing in the former case.
I've just added some support for record/replay scenarios such that:

if there is a single registered setup then it is always matched
if there are more registered setups then they are matched in the reversed registration order

So now the invocations in your first scenario should get verified and for the second scenario:
mock.setup(x => x()).returns(() => 0);
mock.setup(x => x()).returns(() => 1);
mock.setup(x => x()).returns(() => 2);

expect(mock.object()).to.eq(2);
expect(mock.object()).to.eq(1);
expect(mock.object()).to.eq(0);
expect(() => mock.object()).to.throw(MockException);

Let me know what you think.

Cool, thanks! Why in reverse order though, what do you think about replaying in the same order that the record happened?
mock.setup(x => x()).returns(() => 0);
mock.setup(x => x()).returns(() => 1);
mock.setup(x => x()).returns(() => 2);

expect(mock.object()).to.eq(0);
expect(mock.object()).to.eq(1);
expect(mock.object()).to.eq(2);
expect(() => mock.object()).to.throw(MockException);

I guess it does make more sense to replay them in the order they were recorded. I've made the necessary changes.
Typemoq ver 0.1.1 is available and it includes these changes.
Please give it a try and let me know if you have any comments.

Hi, would you be able to verify if multiple registered setups work with Mock.ofType<Interface>  when the matcher is exactly the same, please?
From the docs and the above example I expected that it would.
I have code that looks like this:
const mock = TypeMoq.Mock.ofType<MyInterface>();
// setup for first call
mock
    .setup(f => f.funcThatReturnsPromise())
    .returns(() => Promise.resolve(valueA));
// setup for second call
mock
    .setup(f => f.funcThatReturnsPromise())
    .returns(() => Promise.resolve(valueB));

What happens is that the second setup trumps the first; so the first call receives valueB but the second call receives undefined.
I found it interesting that all subsequent calls after the first return undefined and not valueB - though naturally both of those outcomes are undesirable as we want callA -> valueA & callB -> valueB.
If I remove the second setup then all calls to funcThatReturnsPromise returns valueA as expected.
Previously this test setup code differed in that the setups were both different because funcThatReturnsPromise was receiving a value, so:
mock
    .setup(f => f.funcThatReturnsPromise(inputA))
    .returns(() => Promise.resolve(valueA));
mock
    .setup(f => f.funcThatReturnsPromise(inputB))
    .returns(() => Promise.resolve(valueB));

This worked fine, so a call using inputA returned valueA and so on.
Any help would be much appreciated, thanks.


Xuabble

"A Xuabble of Xeets is the responses or quote xeets that spawn from an especially hot/unpleasant take."
I think Quabble should stay thought

@gingerchew I was also wondering if Quabble should maybe stay but remove Twitter references and instead reference "a social media post" which is more generic. WDYT?

I like that idea!


Added [] as alias for get in attributes class

ditto

@AlfonsoUceda This looks great, thank you! :+1:

Coverage increased (+0.0%) to 97.9% when pulling ee004681159fd2c162e3892ccd036a8c40208c2f on AlfonsoUceda:master into d1240cbea270e41c61a66f7b911426e318009d31 on lotus:master.


Add ability to bulk select cards from the same bank in the Card filter on the Search page

We're in the final implementation phase for card feeds in NewDot, and as part of that initiative, we need to add a way for admins to bulk select all cards from a certain feed.
Rather than add two separate filters (and the accompanying search syntax), we're going to add a way to bulk select a whole series of cards in the Card filter. The benefit of this is that we prevent search "collisions" on two separate filters. For example, imagine that we had a filter for Feed. If you selected Chase for that option, you would also be selecting all Card numbers that also belonged to the same feed. However, in our current logic the Card filter would be empty.
Long story story, a feed is just a way of bulk selecting cards. Similarly, the Card filter is already by design a way to select one or more cards. As a result, we're going to do the following:

Keep the name of the Card filter
Within the Card filter, admins will see two sections: Card feeds and Individual cards (note for emphasis: the workspace role for member never sees the Card feeds section)
Further, within the Card feeds section, if a user has more than one feed, then we'll append either the domain name or the workspace name (e.g. All Expensify - [workspace name] or All Expensify - [domain]. The domain name only applies for domain feeds, and the workspace feed only applies for workspace feeds. These names are truncated where applicable.
When a value is selected in the Card feeds section, that's equivalent to a user individually selecting all individual cards. However, we don't do that when a feed is selected, as the card feed is it's own distinct selection.
It's also worth noting that it's possible to select an entire feed as well as individual cards that may not be part of the same feed. Similarly, if a feed is chosen and individual cards within the same feed are also chosen, that's the same as just selecting the feed.
Finally as a reminder, the search input only appears when a given list has more than 8 options. This is our standard for when the search input is shown versus not, though I'm including this as a reminder.

Taken together, the updated filter will look like this.

@Kicu would you or someone from SWM want to take this one?

Taking assignment on this one

Hey! I’m Jakub Szymczak from Software Mansion, an expert agency, and I’d like to work on this issue!

Awesome, let us know if you have any questions.

Are there any designs for this? I don't see the image that Carlos posted :( @JmillsExpensify

@SzymczakJ you can find the Figma file here

For testing purposes, how to create a domain feed?

For testing purposes, how to create a domain feed?

For information, @SzymczakJ was able to get through this based on this comment

Sorry I was OOO on Friday and I forgot to mention it. I should be able to put up a draft PR today.

Now when I think of it, in case a user is a workspace admin, shouldn't he be able to see all workspace cards, not only the cards that he is assigned to(he has an onyx data of that).

Yea, I think admins should see all cards. Please confirm @JmillsExpensify

Currently, we are fetching all card feeds data on WorkspaceExpensifyCardPage and WorkspaceCompanyCardsPage by the use of Policy.openPolicyExpensifyCardsPage and CompanyCards.openPolicyCompanyCardsFeed.
I think we need to have a distinct API command that will fetch all the expensify and company cards while entering card filter. Not only these commands have sligthly different use, but they also only fetch single workspace cards and we have a need for command that fetches all of it in one call. @luacmartins

Yes, admins should see all cards.

Curious what Carlos thinks, though adding my thoughts for two of the questions:

what should we show in AdvancedSearchFilters card title? Should we print all cards that we'll send on BE, or maybe print only the card feed(All Expensify - Some workspace name).

Given that this is simply a way to bulk select cards, I would think that we'd print all cards. Basically as if someone entered all the cards in the search router manually.

what should we show in SearchPage input? Is showing all the searched cards is enough?

Yes, similar to above, let's show all the cards as if you searched them

I know that you wanted cardFeeds selection and indvidual card selection to be separate(according to the description quote)

When a value is selected in the Card feeds section, that's equivalent to a user individually selecting all individual cards. However, we don't do that when a feed is selected, as the card feed is it's own distinct selection.

But wouldn't it make more sense to indicate the user which cards are already chosen, so he knows that he doesn't need to tick them. That's how it would look like:
https://github.com/user-attachments/assets/27e2f13a-2f3f-4e74-9261-dae0efe2da7a
@JmillsExpensify @luacmartins

Currently, we are fetching all card feeds data on WorkspaceExpensifyCardPage and WorkspaceCompanyCardsPage by the use of Policy.openPolicyExpensifyCardsPage and CompanyCards.openPolicyCompanyCardsFeed.
I think we need to have a distinct API command that will fetch all the expensify and company cards while entering card filter. Not only these commands have sligthly different use, but they also only fetch single workspace cards and we have a need for command that fetches all of it in one call. @luacmartins

That makes sense. I can work on creating that command.

what should we show in AdvancedSearchFilters card title? Should we print all cards that we'll send on BE, or maybe print only the card feed(All Expensify - Some workspace name).

I agree with Jason, I think we'd just show all the selected cards.

what should we show in SearchPage input? Is showing all the searched cards is enough?

Same as above. Although, I wonder if we'll run into performance issues if a user selects a feed with a huge list of cards.

we are won't be able to view results and then come back to advanced filters with card feeds selected, unless we also save them on BE

For this, I think we can just add a condition to check if every card on a feed is selected and if so, also select the feed in the list

But wouldn't it make more sense to indicate the user which cards are already chosen, so he knows that he doesn't need to tick them. That's how it would look like:

I agree with this. @JmillsExpensify wdyt?

Created an issue to create the read command here

I'll put the PR into internal review tomorrow.

Nice! @SzymczakJ I'm starting to work on the command to fetch the card/feeds. Which Onyx keys are you subscribing to? Just cardList?

I'm basing my work on cardList and cards_ onyx keys. cardList object is always prefetched, but I need to fetch cards_ obejct that would contain all cards from workspaces that a user is admin of.

Btw, catching up now on the above

But wouldn't it make more sense to indicate the user which cards are already chosen, so he knows that he doesn't need to tick them.

This consideration is a bit tricky, as consider this case:

You choose All Expensify...
All cards below are selected
Then you unselect one of the Expensify cards individually

In this case, you actually didn't unselect the card, because All Expensify is selected above. Basically, the card you unselected above would still be in the query, even though you thought you removed it.

That's the way I'm currently handling this:
https://github.com/user-attachments/assets/01e715b9-5c14-4f52-9ea2-dc684b60a650
When user selects card feed -> we select all the cards
When user unselects at least one card from the feed -> we also unselect the feed, to indicate that not every card is selected
When user unselects a feed -> we also unselect all the cards from that feed
Is this the behaviour you expected @JmillsExpensify?

@Expensify/design we had chatted about this one last week, and I believe some of you had concerns with this approach.

When user selects card feed -> we select all the cards
When user unselects at least one card from the feed -> we also unselect the feed, to indicate that not every card is selected
When user unselects a feed -> we also unselect all the cards from that feed

Is that still the case, or we're good to move forward with this?

Personally, this is what I expected and I think it's fine. Curious for design team's thoughts as well!

I feel like I was the one who originally pushed back on that idea. I still think it's weird having a radio option that controls other, separate radio options below it. But maybe that's just me—if everyone else is happy with that behavior I'm fine to move forward with it. Let's wait for @Expensify/design to weigh in though.

This behaviour is also my expectation

I don't feel too strongly really, I see Danny's point but I also think what I am seeing in the video doesn't feel terribly weird and seems to make sense to me.

Ok cool - we can wait for @dubielzyk-expensify to chime in but it sounds like everyone is cool with the behavior shown in the video.

Yeah, I kinda think the video is what's expected too.

Thanks for chiming in!
@luacmartins do we have an ETA for backend API call?

@SzymczakJ the PRs are in review. I'm hoping to get them merged early next week and fully deployed by mid-next week.

FYI I noticed bugs in using card filter:
https://github.com/user-attachments/assets/25c4d991-caa8-4908-9c79-1a3de48eb2e0
All cards except of "Expensify Cards" were shown with a BE value of a bank and same bank cards were indistinguishable. I've fixed it and changed them to human readable form and added descriptor as we do in Search Input:
https://github.com/user-attachments/assets/17aa3e37-4802-47b2-92aa-ca2d435a461b
I guess nobody was really testing this with real cards and that's why this wasn't noticed, but is it the right way to fix it? @luacmartins

That looks good to me. cc @Expensify/design for another opinion

Looks good to me too. What does the query look like if you choose "All" on a card feed that has a ton of cards?

We settled on showing all the cards, that the user selected, by selecting a big card feed.
Even if we group cards in cards feeds in query, the user will be able to make really big query consisting of many cards, if he doesn't exactly select the whole feed. What's more putting card feeds in query would mean big changes all over backend, parser and frontend.

Can I see an example mockup of that? I'm just worried that it's going to look pretty brutal in the query bar, and it will make it harder to extend the query to search for anything specific. Like if you wanted to search for the merchant "McDonald's" across all of your Visa commercial cards... it feels like doing so manually via the query would be rough. That being said, it would be easy to do it via advanced filters in the RHP so maybe it's not a huge concern.

Here's example of 2 card feeds selected(total of 7 cards):

Yup, this screenshot here:

...illustrates my point - that query bar is virtually unusable. Maybe that's fine for now though? Curious what @JmillsExpensify thinks.

We had previously agreed on showing all cards. I also agree that changing that behaviour would require bigger changes to the backend/parser logic.

Okay cool, I think we can leave it for now but I wonder if we'll want to revisit in the future for things like reconciliation.

Bump me when BE is deployed @luacmartins
No hurry though because I'll be OOO tomorrow

PR was merged. Waiting on deploy.

What will be the API command name then?

@SzymczakJ command name is OpenSearchFiltersCardPage and it doesn't take any params (just the authToken, which is already included in the requests)

PR ready for C+ review.
When I was testing this I realised that we probably should download cards_ data, in OpenApp command just like we do it with cardList, if we want the SearchRouter to suggest all the cards that admin can see.
This is more of a polish to this issue and BE improvement and we merge this PR without it. Sorry for realising it so late though 😅.
WDYT about it @luacmartins?

Hmm is it possible to use cardList when providing router suggestions? I'm not sure if we need an option to select the feed from the input vs just the UI. @JmillsExpensify what do you think?

I'm not talking about selecting feeds(I think that we shouldn't have ability to select whole feed from router input). I'm talking about this because, when we base our suggestions on cardList(like we do at the moment), then admin users won't see all cards that they can see on Workspace Expensify card/Company card page(cardList contains only current user assigned cards and cards_ contains every card connected to workspace, that admin can see)
So when we don't include cards_ object in OpenApp command then admin users won't see all the cards in card suggestion, only their own.

It's affecting only admin users, so we might also pass on this search router functionality. I think that most admin users will use advanced filters to select cards since it gives bulk select feature.

@mountiny thoughts on the above since you worked on workspace feeds?

Yeah that is right, i guess we just need to decide how to handle this from ux perspe, its tricky because we have to dynamically and intuitively handle both the admin and user experience at once
The admin cards are loaded only once you go to the card settings as they have not been needed elsewhere
I am not sure how much time it would add to load it in openApp probably depends on the indexes on the cards tables

I can look into returning them in open app for admins if we want it for the ux

That'd be great. Thanks!

I have started on the PR https://github.com/Expensify/Auth/pull/13625


Give SilkSpawners the possibility to only let certain custom items drop mob spawners

The SilkSpawners plug-in makes it possible to mine mob spawners if players use the right tool to break it. It would be nice if this could also be a custom tool from this plug-in.

Currently awaiting https://github.com/timbru31/SilkSpawners/pull/443

The PR has been approved, so I should document this new support before releasing KCI 13.


Please add v4 to this chart

[Enter feedback here]
Can you please add v4 to this chart? It's not clear if you can mix v3 and v4 in the same availability set.
Thanks!

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: b1c853c1-2d43-1694-08e5-5e1f16a0510f
Version Independent ID: 9e54cc6e-a87b-64bb-96f3-9ce20290136f
Content: Supportability of adding Azure VMs to an existing availability set - Virtual Machines
Content Source: support/azure/virtual-machines/virtual-machines-availability-set-supportability.md
Service: virtual-machines
GitHub Login: @Deland-Han
Microsoft Alias: delhan

@pgbfnf  Thanks for the commend. We will update the article.

@pgbfnf You can use folowing service/tool to query all the supported VM for the existing availability set:
Availability Sets - List Available Sizes - REST API (Azure Compute) | Microsoft Docs

Understood.
But if you have a chart/matrix that includes some, but not all possible options, it can be misleading.
Peter Bollwerk
Azure Cloud Engineer
Fidelity National Financial
<EMAIL_ADDRESS>Mobile:<PHONE_NUMBER>
From: Thomas Lin @.>
Sent: Tuesday, December 7, 2021 12:57 AM
To: MicrosoftDocs/SupportArticles-docs @.>
Cc: Bollwerk, Pete @.>; Mention @.>
Subject: Re: [MicrosoftDocs/SupportArticles-docs] Please add v4 to this chart (Issue #350)
IMPORTANT NOTICE - This message sourced from an external mail server outside of the Company.
@pgbfnfhttps://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fpgbfnf&data=04|01|pete.bollwerk%40fnf.com|439f9fbdb29d4cde458f08d9b95f7e7e|8a807b9b02da47f3a903791a42a2285c|0|0|637744642062790642|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000&sdata=MaI2kRRPwtmQvGm569aMZWsYBq98HhrL8tX86jZwvKs%3D&reserved=0 You can use folowing service/tool to query all the supported VM for the existing availability set:
Availability Sets - List Available Sizes - REST API (Azure Compute) | Microsoft Docs

You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMicrosoftDocs%2FSupportArticles-docs%2Fissues%2F350%23issuecomment-987706380&data=04|01|pete.bollwerk%40fnf.com|439f9fbdb29d4cde458f08d9b95f7e7e|8a807b9b02da47f3a903791a42a2285c|0|0|637744642062800597|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000&sdata=Hu20IOWrOslFKgVbL%2FISCguZ1j00BQJRJOnAq65O%2Baw%3D&reserved=0, or unsubscribehttps://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAVMDM2GBNWY4JMZDAHYQW2TUPXD4XANCNFSM5HOMLEJA&data=04|01|pete.bollwerk%40fnf.com|439f9fbdb29d4cde458f08d9b95f7e7e|8a807b9b02da47f3a903791a42a2285c|0|0|637744642062810552|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000&sdata=K41QGlknyG5iAV0TGiMWj%2BiAD8zWDiTaLCivxFndESA%3D&reserved=0.
Triage notifications on the go with GitHub Mobile for iOShttps://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fapps.apple.com%2Fapp%2Fapple-store%2Fid1477376905%3Fct%3Dnotification-email%26mt%3D8%26pt%3D524675&data=04|01|pete.bollwerk%40fnf.com|439f9fbdb29d4cde458f08d9b95f7e7e|8a807b9b02da47f3a903791a42a2285c|0|0|637744642062810552|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000&sdata=1RsLeyKeWc1ba45kpKT90Umqjen9GllxWzyo1C8O9QI%3D&reserved=0 or Androidhttps://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fplay.google.com%2Fstore%2Fapps%2Fdetails%3Fid%3Dcom.github.android%26referrer%3Dutm_campaign%253Dnotification-email%2526utm_medium%253Demail%2526utm_source%253Dgithub&data=04|01|pete.bollwerk%40fnf.com|439f9fbdb29d4cde458f08d9b95f7e7e|8a807b9b02da47f3a903791a42a2285c|0|0|637744642062820514|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000&sdata=OwK%2FdJXz%2FITY1IBu3TzSWJU7X7VjIRFtIb1EJnG0joY%3D&reserved=0.

NOTICE: The information contained in this message is proprietary and/or confidential and may be privileged. If you are not the intended recipient of this communication, you are hereby notified to: (i) delete the message and all copies; (ii) do not disclose, distribute or use the message in any manner; and (iii) notify the sender immediately.

This message was secured by Zix(R).

@pgbfnf, I aggreed with you. I have moved the chart to a r"eference" section, and call it out that this chart just lists some commom scenarios.


Make python dependencies in Dockerfile versionless

Recently we had some problems with building the Docker container.
This is caused by an updated of the python packages in the alipine repository that this addon builds on top of.
Since the Dockerfile mentions explicit versions, these versions are no longer available after the update of the external repository, causing this build problem.
Since the only way to fix the problem, is to update the Dockerfile with the new version, I do not see the added value of explicitly naming the version.

I'll try it out on local dev and test.


tinygo: Upgrade to version 0.26.0

Upgrade tinygo to version 0.26.0. We need to add //export directives
the Go function declarations for JavaScript implementations, according
to a tinygo commit message. And when you do that, you can no longer use
those functions as a value in the evaluator.Runtime struct. So wrap
the function references in anonymous funcs to make them Go functions.
The symbols in the Go environment for WebAssembly no longer have the
main. prefix, so drop them from the JS/Go/WebAssembly binding setup.
This may be because exported functions never had the Go package name
prefix?
Link: https://github.com/tinygo-org/tinygo/commit/8bbfb1ee68245a967081165c7161cd3421f97823

Maybe a comment on the purpose of the bounce functions?

I've removed the bounce functions and used anonymous functions instead. Added a comment as to why. Is this better?


Union uses field default value instead of raising a ValidationError

Initial Checks

[X] I confirm that I'm using Pydantic V2

Description
When using a default value or default_factory for a field that is a union between two (or more) Pydantic models, model_validate does not raise a ValidationError when all members of the union fail to match the data. Instead, it populates the field with its default value, silently dropping the data that was passed in and passing validation. Please see the example below.
The expected behaviour would be for model_validate to raise a ValidationError if none of the members match the data.
Adding the strict=True flag to model_validate does nothing.
Example Code
import pydantic

class A(pydantic.BaseModel):
    a: str = 'a'

class B(pydantic.BaseModel):
    b: int = 1

class C(pydantic.BaseModel):
    u: A | B = A()

print(C.model_validate({'u': {'a': 'valid'}}))      # gives u=A(a='valid'), as expected
print(C.model_validate({'u': {'b': 'invalid'}}))    # gives u=A(a='a'), expected ValidationError

try:
    print(C(u=B.model_validate({'b': 'invalid'})))  # ValidationError, as expected
except pydantic.ValidationError as e:
    print(e)

Python, Pydantic & OS Version
pydantic version: 2.5.2
        pydantic-core version: 2.14.5
          pydantic-core build: profile=release pgo=true
                 install path: /home/nf/.local/lib/python3.10/site-packages/pydantic
               python version: 3.10.13 (main, Aug 25 2023, 13:20:03) [GCC 9.4.0]
                     platform: Linux-5.15.0-88-generic-x86_64-with-glibc2.31
             related packages: mypy-1.4.1 typing_extensions-4.7.1

EDIT:
After some playing around, providing a default on the union (i.e. C's u field) is not the cause of the behaviour. If no default is provided, Pydantic simply choses the first member of the union, provided it has defaults, as in the example. Removing the defaults from the union member types (i.e. A and B in the example) results in a ValidationError, as expected.

This is intended behavior — A allows extra data so it does pass validation and just grabs the default value.
If you want to disallow extra fields, you can put extra='forbid' in the model config and you'll get the error I think you are expecting:
import pydantic

class A(pydantic.BaseModel, extra='forbid'):
    a: str = 'a'

class B(pydantic.BaseModel):
    b: int = 1

class C(pydantic.BaseModel):
    u: A | B = A()

print(C.model_validate({'u': {'b': 'invalid'}}))
"""
pydantic_core._pydantic_core.ValidationError: 2 validation errors for C
u.A.b
  Extra inputs are not permitted [type=extra_forbidden, input_value='invalid', input_type=str]
    For further information visit https://errors.pydantic.dev/2.4/v/extra_forbidden
u.B.b
  Input should be a valid integer, unable to parse string as an integer [type=int_parsing, input_value='invalid', input_type=str]
    For further information visit https://errors.pydantic.dev/2.4/v/int_parsing
"""

This isn't an issue due to the use of Union — the crux of the issue is that the following works because extra inputs are ignored by default:
import pydantic

class A(pydantic.BaseModel):
    a: str = 'a'

print(A.model_validate({'b': 'invalid'}))
#> a='a'

There is no way to automatically say "if I'm using a union and I get a field that matches one of the cases, only check against that case, not the others that might be ignoring it". But I'll note that you could implement something more careful along these lines using a callable discriminator.
Of course you can also just forbid extra inputs if that works for your use case; if you want to do that for all models you can just create a common base class:
from pydantic import BaseModel

class MyBaseModel(BaseModel):
    model_config = {'extra': 'forbid'}

and then inherit from MyBaseModel with all your custom models.

Great answer, thank you @dmontagu.

Thank you very much @dmontagu ! I now see where that behaviour comes from. Obvious in hindsight, thanks to a good explanation :)


Luacheck

Fix some issues found by Luacheck and create a luacheckrc file with some settings I think are appropriate.
Also tell editorconfig about 80 columns maximum line length, so we can at least avoid creating more long lines in the code. (Changing existing code to 80 columns is left for another day)

Codecov Report

Merging #152 into lablua will decrease coverage by 0.2%.
The diff coverage is 84.37%.

Impacted Files
Coverage Δ

titan-compiler/types.lua
86.36% <ø> (-0.21%)
:arrow_down:

titan-compiler/syntax_errors.lua
100% <100%> (ø)
:arrow_up:

titan-compiler/lexer.lua
98.34% <100%> (+0.01%)
:arrow_up:

titan-compiler/checker.lua
88.96% <25%> (-0.51%)
:arrow_down:

titan-compiler/scope_analysis.lua
88.17% <50%> (-0.07%)
:arrow_down:

titan-compiler/parser.lua
94.06% <80%> (-0.05%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9a6c600...0d81156. Read the comment docs.


Cow: Watch art-of-brass.com

Cow requests the watch of the watch_keyword art-of-brass\.com. See the MS search here and the Stack Exchange search in text, in URLs, and in code.

art-of-brass\.com has been seen in 1 true positive, 0 false positives, and 0 NAAs.


Specefied eunit suites in test dir

Project file tree.
$ tree .
├── src
│   ├── a.app.src
│   └── a.erl
└── test
    └── a_tests.erl

This command I could not be executed. I fix this.
$ rebar3 eunit --suite a_tests

("a" can be specified as a suite)
Fixes:

_build/test/lib/APP/ebin/APP.app include *_tests modules in test folder.
create "_build/test/lib/APP/ebin/APP.app" before eunit run.

what would be the difference between rebar3 eunit --suite a and rebar3 eunit --suite a_tests? do you have some tests in a and some in a_tests and only want to run those in a_tests?
currently modules in test are not included in the app specification because generally tests are not considered part of the application and the tools that work with the app specification do not want or need to know about test files. if your test files are part of the application and should be included in the app specification you could put them in src or another dir and use {src_dirs, ["src", "path_to_tests"]} in your config file to include them
i could (and should) add a way to specify an eunit test set either via command line or the config file. then you could do rebar3 eunit --test {file,"test/a_tests"}. would that do what you need?

what would be the difference between rebar3 eunit --suite a and rebar3 eunit --suite a_tests? do you have some tests in a and some in a_tests and only want to run those in a_tests?

Yes. I want to do it.

currently modules in test are not included in the app specification because generally tests are not considered part of the application and the tools that work with the app specification do not want or need to know about test files.

That's right.  a_tests is not part of the application.
However, currently, module that can be specified in --suite must include in the app.
So, modification on this PR is that *_tests modules include in the app only for test.

then you could do rebar3 eunit --test {file,"test/a_tests"}. would that do what you need?

When I executed this command, invalid option has been returned. Is it the correct command?

$ cat _build/default/lib/APP/ebin/a.app  | grep modules
              {modules,[a]}]}.
$ cat _build/test/lib/APP/ebin/a.app  | grep modules
              {modules,[a, a_tests]}]}.

right now rebar3 eunit uses {application, App} to run tests. if you have modules a and a_tests in the app spec it will run the tests for a_tests twice. also, there's no way to run just the tests in a with your patch
i think a better approach would be to add a --file=test/foo,test/bar,test/baz flag that uses [{file, "test/foo"}, {file,"test/bar"}, {file, "test/baz"}] as the test argument to eunit. most of the functionality already exists in the ct provider

Oh, I see.
I try to add --file options.


Enable filtering by language

If collections could be filtered by language, the overview over the collections would be more neat.
You could use an arrangement like in the sketch below, which has buttons (with flags) with which a language can be chosen. An additional button for showing all languages would also be possible.

Further it would be helpful, if the language selection would also restrict the choosable collections to those with the selceted language when adding a word.
This would also solve the problem described in issue #9, except when no specific language is selected (all languages are shown).


Refactoring ipynb

Find the different parts of the code from the notebook and put them under different modules.

Can I work on this?

@lkdmttg7 sure

While making a PR, reference this issue with {hashtag}{issue_number}

@lkdmttg7 What is the status?

It will be done by tomorrow. Is it fine?

Ok.

Open to everyone


Fixing the validation and raw max size bug. Adding custom PrepareRequest

Coverage increased (+0.01%) to 99.186% when pulling edc5456655519949d59bcb5d3d12bec0f5d228ca on acking-and-bug-fixes into 4fb218bb5683eeb8d0a5cd5f29d041a09cf5e2a9 on master.


error: routes creation takes at least three arguments: app name, route path and image name

When I execute fn routes create myapp /hello following the steps and example from the README file it fails with the message: error: routes creation takes at least three arguments: app name, route path and image name
Docker version:
Client:
 Version:      1.13.1
 API version:  1.26
 Go version:   go1.7.5
 Git commit:   092cba3
 Built:        Wed Feb  8 08:47:51 2017
 OS/Arch:      darwin/amd64

Server:
 Version:      1.13.1
 API version:  1.26 (minimum version 1.12)
 Go version:   go1.7.5
 Git commit:   092cba3
 Built:        Wed Feb  8 08:47:51 2017
 OS/Arch:      linux/amd64
 Experimental: true

Workaround

Execute docker ps check for the image name and TAG and run fn routes create myapp /hello $USER/hello:$TAG. For example fn routes create myapp /hello nesterran/hello:0.0.1

Oh, looks like we need to merge a PR: https://github.com/iron-io/functions/pull/526
Once that's in, this should be fixed.

Great !


Add libturbojpeg0-dev to install instructions

kvm's build depends on libturbojpeg0-dev, so adding it to the README install instructions.
Fixes #2

Nice

Nice


Preview cache html

VSCode Version:1.7.2
OS Version: Windows7

Steps to Reproduce:

Write a html file with bootstrap

Panel Heading
Suppression des pièces jointes
2. Preview with shortcut Ctrl+Shift+V
3. Display correctly
4. Modify the text of the link button
5. Should display the new text on a new preview command but stay the same
6. Preview another file
7. Come back to the previous one and the change shows..

@albu77 What command palette command do you use.  Can you pls go to Command Palette > Help:Report Issue can copy the list of extensions from the pre-populated issue into this one? Thanks.

VSCode Version: Code 1.7.2 (7ba55c5860b152d999dda59393ca3ebeb1b5c85f, 2016-11-21T22:06:37.428Z)
OS Version: Windows_NT ia32 6.1.7601
Extensions:

Extension
Author
Version

project-manager
alefragnani
0.7.1

phpmd
linyang95
1.1.1

csharp
ms-vscode
1.2.2

debugger-for-chrome
msjsdiag
2.1.1

[Microsoft/vscode] Preview cache html (#17074)
Steps to Reproduce:
1.Ok, Sorry, I was using Ctrl+Shift+V which Toggle MarkDown Preview and wasUsing it againt a Html File which in some case give a close result and that's why I thought it was a bug.
I understabnd that for Html I need an extension
2.Regards
Alain

@albu77 Thanks!


Update the Vietnamese translation

Summary:

update template.json for #369
update es6.md for #384
update faq.md for #357

ping @particle4dev for review

+1

+1


fix cursors overlay crash

Hello @BitPhinix I made a temporary solution that seems to fix cursor crashes and they work as they should. It is clear that this is not a targeted solution, but at the moment I think it's better than not being able to use them at all in react 18. #372

Merging this as a temporary fix! Would love for someone to dig into this further and fix a proper fix

@BitPhinix I added changeset. And I also had to add "try catch" in one more place, the original fix fixed repository example, but in my project with a more complex editor structure, cursors could still be broken


Zend 20170823 170555

Добавление модуля

Is this accidental commit?
(Это случайный комит?)

Closing.
Reporter provides no rationale for the changes, and most of them are destructive (removal of installer prompts, in particular).


multicast is not work on network

Describe the bug
multicat operates only in local loop.
If chip-tool and OTBR run on one device.
My end device (nrf52840) receives multicast packets.
and mroute set by both direction
wlan0 -> wpan0
wpan0 -> wlan0
ip -6 mroute
(fd5b:35de:ad5b:beef:e3a0:6290:dab7:e37a,ff35:40:fd00::100:1) Iif: wlan0      Oifs: wpan0  State: resolved
(fd11:35::782d:5b46:d438:5761,ff35:40:fd00::100:1) Iif: wpan0      Oifs: wlan0  State: resolved
But If I work chip-tool in rpi4 - 1 and OTRBR running ont rpi4 - 2
only 1 mroute are add
ubuntu@ubuntu:~/chip-certification-tool/scripts/OTBR$ ip -6 mroute
(fd5b:35de:ad5b:beef:5c0a:7aeb:fd9c:55e1,ff35:40:fd00::100:1) Iif: wlan0      Oifs: wpan0  State: resolved
I checked tcpdump at wlan0 and wpan0.
If I try on same board, I see the wlan0 and wpan0 get almost same pkt.
So I guess OTBR forwarding the packet from  wlan0 to wpan0.
But, If I try on rpi4 1/2, OTBR wlan0 get packet but, wpan0 isn't
I can ping from rpi4-1 to end device, I thinks connection is well.
I can onoff toggle end device by unicast, connection is also well I guess
"./chip-tool onoff toggle 2 1"
I tested with below command set.
./chip-tool pairing ble-thread 2  hex:0e08000000000001000035060004001fffe00708fdabbc98c27896b90c0402a0f7f800030000110102123402081111111122222222030e4f70656e54687265616444656d6f051000112233445566778899aabbccddeeff0410445f2b5ca6f2a93a55ce570a70efeecb   20202021 3840

./chip-tool accesscontrol write acl '[{"fabricIndex": 1, "privilege": 5, "authMode": 2, "subjects": [112233], "targets": null },{"fabricIndex": 1, "privilege": 4, "authMode": 3, "subjects": null, "targets": [{"cluster": 6, "endpoint": 1, "deviceType": null}, {"cluster": 8, "endpoint": 1, "deviceType": null}] }]' 2 0

./chip-tool groupkeymanagement key-set-write '{"groupKeySetID": 4, "groupKeySecurityPolicy": 0, "epochKey0": "d0d1d2d3d4d5d6d7d8d9dadbdcdddedf", "epochStartTime0": 2220000,"epochKey1": "d1d1d2d3d4d5d6d7d8d9dadbdcdddedf", "epochStartTime1": 2220001,"epochKey2": "d2d1d2d3d4d5d6d7d8d9dadbdcdddedf", "epochStartTime2": 2220002 }' 2 0
./chip-tool groupkeymanagement write group-key-map '[{"groupId": 1, "groupKeySetID": 4, "fabricIndex": 1}]' 2 0
./chip-tool groupkeymanagement read group-key-map 2 0

./chip-tool accesscontrol read acl 2 0

./chip-tool groupsettings add-group grp1      0x0001
./chip-tool groupsettings add-keysets 4  0  0x000000000021dfe0  hex:d0d1d2d3d4d5d6d7d8d9dadbdcdddedf
./chip-tool groupsettings bind-keyset 0x0001 4

./chip-tool groupsettings show-groups
./chip-tool groupsettings show-keysets

./chip-tool groups add-group 0x0001 grp1 2 1
./chip-tool onoff toggle 2 1
./chip-tool onoff toggle 0xffffffffffff0001 1

And I build my otbr with below config.
./script/cmake-build -DBUILD_TESTING=OFF
-DOTBR_DBUS=ON
-DOTBR_REST=ON
-DOTBR_WEB=OFF
-DOTBR_MDNS=avahi
-DOTBR_BACKBONE_ROUTER=ON
-DOTBR_BORDER_ROUTING=ON
-DOTBR_SRP_ADVERTISING_PROXY=ON
-DOTBR_BORDER_AGENT=ON
-DOT_SPINEL_RESET_CONNECTION=ON
-DOT_TREL=ON
-DOT_MLR=ON
-DOT_SRP_SERVER=ON
-DOT_ECDSA=ON
-DOT_SERVICE=ON
-DOTBR_DUA_ROUTING=ON
-DOT_DUA=ON
-DOT_BORDER_ROUTING_NAT64=ON
-DOTBR_DNSSD_DISCOVERY_PROXY=ON
-DOTBR_INFRA_IF_NAME=eth0
-DOTBR_NO_AUTO_ATTACH=1
-DOT_REFERENCE_DEVICE=ON
-DOT_DHCP6_CLIENT=ON
-DOT_DHCP6_SERVER=ON
could you help me, how to check multicast?
To Reproduce Information to reproduce the behavior, including:

Git commit id
IEEE 802.15.4 hardware platform
Build steps
Network topology
RPi4-1 ( chip-tool)  <--> RPi4 2 ( OTBR ) with nrf52840 dongle <---> End device ( nrf52840DK )

Expected behavior A clear and concise description of what you expected to happen.
Console/log output If applicable, add console/log output to help explain your problem.
Additional context Add any other context about the problem here.

But If I work chip-tool in rpi4 - 1 and OTRBR running ont rpi4 - 2
only 1 mroute are add
ubuntu@ubuntu:~/chip-certification-tool/scripts/OTBR$ ip -6 mroute
(fd5b:35de:ad5b:beef:5c0a:7aeb:fd9c:55e1,ff35:40:fd00::100:1) Iif: wlan0 Oifs: wpan0 State: resolved

Could you confirm if ping Rpi4-1 -> ED multicast group is working?
On the other hand, could you share the result of ping from ED to Rpi4-1's multicast group?
i.e. on ED run this command:
> ping <Rpi's multicast group> 100 10 1

See this codelab for some background: https://openthread.io/codelabs/openthread-border-router-ipv6-multicast#6

It is not ping to Rpi4-1 -> ED multicast group addr.
But, Multicast group work well after remove all otbr-ingress-* configure
Thanks

Normally otbr-ingress-* rules shouldn't drop such kind of multicast packets. Not sure what could go wrong here.


Update rawtherapee to 4.2.1025

Checklist

[x] The commit message includes the cask’s name and version.
[x] brew cask audit --download {{cask_file}} is error-free.
[x] brew cask style --fix {{cask_file}} left no offenses.

Closes https://github.com/caskroom/homebrew-cask/issues/24960.

Thank you.


Debug compilation flag

Would be helpful to implement something like rusts's cargo build --release for filament as it would be nice to preserve component/port names in the compiler if a flag is enabled and the info is present, for example when debugging through gtkwave or through looking at the resultant calyx/verilog code.

@rachitnigam I'll go ahead and implement this in compile as I think it is a useful feature nonetheless, but if this would be better enabled in a different way we could look into that as well.

Yeah! I think this is a good idea. I was going to mention that we should probably try to preserve as many source-level names as possible anyways (especially with component signatures). Storing and using this information in the ir::Info seems feasible to me (in fact, it already is stored there) but let me know if you had a different design in mind.