Can you provide somewhere to customize some index?

For example, I always use this:
import * as path from 'path';

However, it can't auto import path when I typed path.
I'm not sure if this is a common demand, but think it will be really useful if somewhere I can add some customize index. (Just like the dump index file)
And another problem is that , once use ts-importer, I found that some hint of basic type disappeared.
e.g. I type this:
let a: string;

Code hint of string can not work. While I disable ts-importer it could.

You can specify the order importance of ts-importer: tsimporter.lowImportance


Distribution of SecurityIntents.

We need to prepare bundles of intents based on Vertical - such as ORAN

https://docs.google.com/document/d/14ospxaiiXTcyZ47aWfUt0_OW9jbqc2xQmyM17Q1zp9A/edit


Option to not symlink kubectl

Is your feature request related to a problem? Please describe.
I already have kubectl in my path, and also all the kube contexts that I normally use. When I install kind, it symlinks kubectl to k3s, and it uses k3s config by default.
Ideally, k3s would just update my existing kube context. But short of that, I can also just update KUBE_CONFIG to contain both my regular config, and also the k3s config.
Describe the solution you'd like
When installing k3s via install.sh, give an option to not create kubectl symlink.
Describe alternatives you've considered
Considered setting KUBE_CONFIG when I want use different set of contexts. But this becomes hard to keep track. Also, most other tooling default the config path to $HOME/.kube/config, but k3s is reading it from else where. While other tooling is working w/ one cluster, k3s kubectl is working w/ kind cluster. It's hard to keep them in sync.

Duplicate of #521

thnx!


MB-6281 Orders and Allowance Table Missing Information State

Description
This branch does the following:

refactors error state styling for the Stacked Table component to include the td as well as the exsisting th styling, and moves the class assignment to the tr so that the class can be conditionally added/removed in one spot.
adds an example of implementation on the Allowances Table
adds a storybook page for a missing info state of the Orders Table, but does not implement the styling

Reviewer Notes
Setup
Add any steps or code to run in this section to help others prepare to run your code:
yarn storybook

http://localhost:6006/?path=/story/office-components-orderstable--missing-info
http://localhost:6006/?path=/story/office-components-allowancestable--default
Code Review Verification Steps

[x] There are no aXe warnings for UI.
[ ] This works in Supported Browsers and their phone views (Chrome, Firefox, IE, Edge).
[ ] Tested in the Experimental environment (for changes to containers, app startup, or connection to data stores)
[ ] User facing changes have been reviewed by design.
[ ] Request review from a member of a different team.
[ ] Have the Jira acceptance criteria been met for this change?

References

Jira story for this change

Screenshots

Warnings

:warning:
This PR does not include changes to unit tests, even though it affects app code.

:warning:

Files located in legacy directories (src/shared or src/scenes) have
been edited. Are you sure you don’t want to also relocate them to the new file structure?
View the frontend file org ADR for more information

Messages

:book:
:link: MB-6281

  Generated by :no_entry_sign: dangerJS against a5430b29c70b825162f66efca9e86a4de30124dd

Warnings

:warning:
This PR does not include changes to unit tests, even though it affects app code.

:warning:

Files located in legacy directories (src/shared or src/scenes) have
been edited. Are you sure you don’t want to also relocate them to the new file structure?
View the frontend file org ADR for more information

Messages

:book:
:link: MB-6281

  Generated by :no_entry_sign: dangerJS against a5430b29c70b825162f66efca9e86a4de30124dd


css changes made again

css changes made to all buttons

Resolve merge conflicts @deepbeatz

How can I do that?

How can I do that?

Check the conflicting files and edit the file

hover effect is not working on buttons please recheck


Jdbcstore does not persist feature status

I tried to use FF4j with a jdbc store.
While enabling  / disabling features I found that the jdbc store lacks a commit in the update method.
If this is found true, I will provide a pull request.
Can anyone check this issue ?
Thank you.

I successfully merged the PR,


Appointment scheduled in diversity visa lottery 2021. Case number 2021AF31351 Ethiopia, Addis Abeba,ADD. First Name Habtamu Biru Ayalew.

Describe the bug
(Write your answer here.)
Did you try recovering your dependencies?

(Write your answer here.)
Which terms did you search for in User Guide?

(Write your answer here if relevant.)
Environment

(paste the output of the command here.)
Steps to reproduce

(Write your steps here:)

Expected behavior

(Write what you thought would happen.)
Actual behavior

(Write what happened. Please add screenshots!)
Reproducible demo

(Paste the link to an example project and exact instructions to reproduce the issue.)

Any Guineas made appointment to me. Thank you.


Publish the repo on Open Exchange

Hi!
It's a great example! Could you please publish it on Open Exchange?
https://openexchange.intersystems.com/

Hi Evgeny,
I was kind of waiting feedback from my customer who is developing new interfaces between their existing system by using these apis (so far, so good).
I guess I've waited enough. I will publish it.
/Iwamoto
(2020/11/06 16:55), Evgeny Shvarov wrote:

Hi!
It's a great example! Could you please publish it on Open Exchange?
https://openexchange.intersystems.com/
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub https://github.com/IRISMeister/iris-c-language/issues/1, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADA7HWT3RVNTNUVYNSMQ76LSOOTVNANCNFSM4TMLITLQ.

--

Thank you very much!
пт, 6 нояб. 2020 г. в 11:12, IRISMeister<EMAIL_ADDRESS>
Hi Evgeny,
I was kind of waiting feedback from my customer who is developing new
interfaces between their existing system by using these apis (so far, so
good).
I guess I've waited enough. I will publish it.
/Iwamoto
(2020/11/06 16:55), Evgeny Shvarov wrote:

Hi!
It's a great example! Could you please publish it on Open Exchange?
https://openexchange.intersystems.com/
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub <
https://github.com/IRISMeister/iris-c-language/issues/1>, or unsubscribe <
https://github.com/notifications/unsubscribe-auth/ADA7HWT3RVNTNUVYNSMQ76LSOOTVNANCNFSM4TMLITLQ
.

--
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/IRISMeister/iris-c-language/issues/1#issuecomment-722941436,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAVHEP3WV2LFKVGT6RBPRKTSOOVXTANCNFSM4TMLITLQ
.

done

Perfect! Thanks!
On Fri, Nov 6, 2020 at 6:50 PM IRISMeister<EMAIL_ADDRESS>wrote:

done
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/IRISMeister/iris-c-language/issues/1#issuecomment-723152169,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAVHEPZUIO6YOHWBGXTM2KTSOQLLNANCNFSM4TMLITLQ
.


Release v2 artifacts to dart-internal

Release artifacts from release candidate branches need to be build exclusively in dart internal for SLSA compliance. This requires removing targets in .ci.yaml with a release_build property to true from the targets scheduled by cocoon.

There are two more failures:

Branches are not being created correctly.
Still need to validate the results publishing to flutter dashboard.

This is now complete.


Make compression robust against special characters in field names

And extend test files accordingly.
Fixes #44

Hello @JuliaSprenger! Thanks for opening this PR.

In the file redcap_bridge/utils.py:

Line 92:40: W605 invalid escape sequence '|'

Do see the Hitchhiker's guide to code style

@killianrochet Can you have a look at this PR? It fixes an issue I just discovered in the compression feature.
Do you see how I first extended the test (files) to cover the offending case (first two commits) and then implemented the fix (third commit)?


Demo is broken

Demo http://domoritz.github.com/vbb-coverage/ doesn't work, because of the page redirecting to https with nosafe jquery including.

Thanks for the report. I fixed it.


Fix minor stuff (and add dialyxir to CI)

The individual commits are presented in a way that their content should help with the review.
The Dialyzer issues we'll see are fixed by changes in another pull request (edit: ... which means I can pull that in once/if it's approved+merged+tag/released).

@benwilson512, is there a chance this gets reviewed? Thanks.

Ah, this still needs the absinthe tag/release to be effective (otherwise it won't fetch the new dep.).

Got it. Let me get that out here shortly.

@benwilson512, anything I can do to help unblocked that release/tag? (we're so close 😄)

v1.7.2 of Absinthe has been published.

Force pushed to resolve merge conflicts...

I'm gonna adapt this lib.s base versions (Elixir + Erlang) to what absinthe's using.

CI results at https://github.com/paulo-ferraz-oliveira/absinthe_plug/actions/runs/5426470445

Thanks!


Typedefinition lacks Promise definition

Hi,
I noticed that mithril.d.ts relies on Promise definition provided by system definition files. Unfortunately, this breaks compilation if project targets ES5. With this target no Promise definition is provided and the compilation fails with error TS2693: 'Promise' only refers to a type, but is being used as a value here. error.
The problem can be solved in tsconfig.json with lib option as below:
{
  "compilerOptions": {
    ...
    "target": "ES5",
    "lib": [
      "dom",
      "es2015.promise",
      "es5",
      "scripthost"
    ]
    ...
  },
  ...
}

"dom", "es5" and "scripthost" are default values for the lib when target is "ES5". Adding  "es2015.promise" solves compilation errors.
I believe a notice about that change in readme.md will benefit newcomers trying to use Mithril with TypeScript.

Thanks for reporting. I have added a note to the Install section.


Create an RFC/docs about tenant state management

And clean up state machine.

Is this done?

RFC is not present, states are but would require more refactoring if we somehow work on https://github.com/neondatabase/neon/pull/2595#discussion_r993518016 and then an RFC would be beneficial.

I'm closing this one in favour of #2736


Would it be possible to create a readonly version, as to reduce the scopes needed?

My admin is being a bit iffy about granting write rights to the organization, just for an automated backup.
I was looking at the scopes and I noticed that https://www.googleapis.com/auth/gmail.readonly exists, would it be possible to make a version that only does read-only requests? or is that a large undertaking?

When you set it up for the first time, I'm pretty sure it asks for exactly which scopes you want to authorize. Can't promise, because I set this up ages ago...

Yup: https://github.com/GAM-team/got-your-back/blob/493ddf9d1cc0229577f043c36c267a87e1e84f37/gyb.py#L470-L489

aah, my bad, I should have used the force and read the source.

@hudcap
I now remember, I was reading the wiki and here is says:

For API Scopes, enter exactly:
https://mail.google.com/,https://www.googleapis.com/auth/apps.groups.migration,https://www.googleapis.com/auth/drive.appdata

So that what got me on the wrong foot. I'll see if it indeed also works for service accounts to be on .readonly scope.


Find inconsistencies between the intel intrinsics XML file and the Rust code

XSLT (data.xsl):
<?xml version="1.0"?>
<xsl:stylesheet version="1.0" xmlns:xsl="http://www.w3.org/1999/XSL/Transform">
    <xsl:output method="text" omit-xml-declaration="yes"/>

    <xsl:variable name="line">
        <xsl:text>
</xsl:text>
    </xsl:variable>
    <xsl:variable name="sep">
        <xsl:text>;</xsl:text>
    </xsl:variable>

    <xsl:template match="/">
        <xsl:for-each select="intrinsics_list/intrinsic">
            <xsl:variable name="name" select="@name"/>
            <xsl:variable name="cpuid" select="CPUID"/>
            <xsl:variable name="instruction" select="instruction/@name"/>
            <xsl:value-of select="concat($name, $sep, $cpuid, $sep, $instruction, $line)"/>
        </xsl:for-each>
    </xsl:template>
</xsl:stylesheet>

And a script:
# Extract instrinsics from XML file
xsltproc data.xsl intel-intrinsics-3.3.15.xml > intel-intrinsics-3.3.15.csv
# Load intel intrinsics into an SQLite db
rm -f intrinsics.db
sqlite3 -batch intrinsics.db 2> /dev/null <<EOF
CREATE TABLE intrinsics(name TEXT NOT NULL UNIQUE, cpuid TEXT, instruction TEXT);
.separator ';'
.import intel-intrinsics-3.3.15.csv intrinsics
EOF

# Extract implemented intrinsics from Rust files
for cpuid in abm avx avx2 bmi bmi2 sse sse2 sse3 sse41 sse42 ssse3; do

rm -f $cpuid.csv
find coresimd/ -type f -name $cpuid.rs -print0 | xargs -0 grep -h '^#\[cfg_attr(.*assert_instr(\|pub unsafe fn' | sed -e 's/^#\[cfg_attr(.*assert_instr(\([^),]*\)[,)].*$/\1/' | sed -e 's/^pub unsafe fn \([^(]*\)(.*$/\1/' | awk '/^_/{print $0";"p; p=""}!/^_/{p=$0}' > $cpuid.csv
# Load them the SQLite db
sqlite3 -batch intrinsics.db <<EOF
CREATE TABLE $cpuid(name TEXT NOT NULL UNIQUE, instruction TEXT);
.separator ';'
.import $cpuid.csv $cpuid
-- find inconsistencies (or missing implementation)
select i.name, i.cpuid, i.instruction, s.instruction
from intrinsics i
left outer join $cpuid s on s.name = i.name
where i.cpuid like '$cpuid'
and i.instruction <> s.instruction
order by 1;
EOF

done

Could you upload the files as a gist (it lets you specify different files with filenames, extensions, etc), and also the results?
I've tried to keep #40 updated with all the recent commits but I haven't checked that the lists maintained there are complete or accurate.
To generate the lists in #148 and #170 I used some python scripts that basically scan the reference documentation and output the intrinsics as "rust functions" (e.g. fn foo(f32x2, f32x2) -> f32x4;). I had in mind that once we implement these intrinsics we can just scan the source code like you are doing to see if all the intrinsics are implemented and the type arguments match.
I've been toying with the idea of doing the same for the Intel Intrinsics Guide, but while one can produce the same type of file with rust signatures, the types wouldn't tell us as much (but we would still be able to check whether we have implemented all intrinsics or not).
The cool thing about getting this set up in ci somehow (once the intrinsics are done, but maybe we could start doing it already) is that at least Intel's and ARM's online data-bases are automatically updated, so we would be warned once new intrinsics for these targets are added (new intrinsics are typically supported by the Linux kernel and GCC and LLVM before the data-bases are updated).

Ok, the files are here


support concurrency for unary operator

That is better than mine. I will improve my code.

@taiyang-li
Actually, the configuration method Stream.WithConcurrency simply updates and store the concurrency value (default = 1) to be used by the next downstream processor operator.
For instance, in the following example:

strm.WithConcurrency(4).Filter sets the concurrency for Filter to 4
strm.WithConcurrency(2).Map sets concurrency of 2 for Map

func main() {
	strm := stream.New([]rune("B世!ぽ@opq...XѬYZbcef7ghijCklrAstvw"))

	strm.WithConcurrency(4).Filter(func(item rune) bool {
		return item >= 65 && item < (65+26)
	}).WithConcurrency(2).Map(func(item rune) string {
		return string(item)
	}).Batch().Sort()
	strm.Into(collectors.Writer(os.Stdout))

	if err := <-strm.Open(); err != nil {
		fmt.Println(err)
		return
	}
}

Method WithConcurrency can be defined here - https://github.com/vladimirvivien/automi/blob/464abb800463bcf784287f182f929f3a2fb8244e/stream/stream.go#L42
And when here in the following location
https://github.com/vladimirvivien/automi/blob/464abb800463bcf784287f182f929f3a2fb8244e/stream/stream_unaryop.go#L11
Add logic to set the concurrency on the operator (inside the Transform method)
func (s *Stream) Transform(op api.UnOperation) *Stream {
  operator := unary.New()
  operator.SetOperation(op)
  operator.SetConcurrency(s.concurr)
  s.concurr = 1 // reset to default
  s.ops = append(s.ops, operator)
  return s
}

It looks like I started work on that a while back but removed it:
https://github.com/vladimirvivien/automi/blob/c9e7f649bd79026a094a5666e309823b543a5d6b/operators/unary/unaryop.go
Let me know if that makes sense.

Thanks for you detailed explanation. I think I totally understand what you mean and that is a very good design. I will improve my PR in recently 1-2 weeks.


Cannot Launch Files With Spaces

Marimo VSCode extension will not launch files with spaces in their filenames.
Solution: Add quotes around file path before passing to terminal
Command Prompt output:
marimo -d run Examples\Normal Stress.py --port=2718 --headless
Error: Got unexpected extra argument (Stress.py)
Marimo Info:
Version: v0.1.11
VSCode Info:
Version: 1.86.0 (user setup)
Commit: 05047486b6df5eb8d44b2ecd70ea3bdf775fd937
Date: 2024-01-31T10:28:19.990Z
Electron: 27.2.3
ElectronBuildId: 26495564
Chromium: 118.0.5993.159
Node.js: 18.17.1
V8: <IP_ADDRESS>-electron.0
OS: Windows_NT x64 10.0.22621

@mscolnick wow that was quick! New bug noted: on windows the filename has to be surrounded by "double quotes", 'single quotes' gives me the error Error: Invalid NAME - '.\HW3\Q2.py' is not a Python file

just released v0.1.13. with the fix

Thanks, it works now! Impressively quick turn around!

Not sure if this is worth the mental overhead right now but I've found a library to do CI testing for VSCode extensions.
You could have GitHub actions run the extension in windows mac and linux runners to catch this kind of issue
https://github.com/redhat-developer/vscode-extension-tester

@memtech3 thank you for the pointer - i hadn't seen this before. I'll look into it if the extension starts to grow in scope / needs e2e testing


⚠ Site ANTS has degraded performance

In c5df094, Site ANTS (https://ants.gouv.fr) experienced degraded performance:

HTTP code: 200
Response time: 10364 ms

Resolved: Site ANTS performance has improved in 8992f20.


[material-ui][AvatarGroup] Even with null results the avatar is still counted

Duplicates

[X] I have searched the existing issues

Latest version

[X] I have tested the latest version

Steps to reproduce 🕹

Use the AvatarGroup component and loop an array of avatars inside.
Don't directly do the condition inside the AvatarGroup, instead, render a child component and pass the current avatar data.
On the Child component, create a condition to either render the avatar or return null instead, so that the avatar won't be rendered.

Here is the Live Demo: SANDBOX-MATERIALUI-AVATAR-GROUP
Current behavior 😯
In some cases, I need to do the condition inside the child component to either render the avatar or not after fetching some data by using a hook which needs to be on the top level.
However, returning null to not render the avatar is still being counted by the avatargroup causing it to still render the + icon.
Expected behavior 🤔
Do not count the null avatars that are being returned so that the + icon will not be rendered.
Context 🔦
This makes the component look a bit buggy a it renders the + icon even without avatars. I'm not sure if this is a limitation in which we should not do it this way or if there is another approach we should be doing instead. Thank you!

  Output from `npx @mui/envinfo` goes here.

The issue arises because in AvatarGroup, the calculation for extra avatars is based on the number of children (children.length). Your custom AvatarChecker component is treated as a valid child before the condition is applied. I'm uncertain if we should officially support custom components inside AvatarGroup. I view this more as an enhancement rather than a bug. I'll keep this issue open, though I'm unsure if it's feasible.

@paoloLigsay
as @ZeeshanTamboli mentioned he sees this an enhancement rather than a bug.
in the meantime you can use below code to achieve what you want
put below code above the component
const notThese = ["W", "E", "H", "N"];
<AvatarGroup max={2}>
  {avatars
    .filter((f) => {
      if (notThese.includes(f.name)) {
        return false;
      }
      return true;
    })
    .map((avatar) => (
      <Avatar sx={{ bgcolor: "primary.main" }}>{avatar.name}</Avatar>
    ))}
</AvatarGroup>

let's see what happens next

Hi @ZeeshanTamboli @PunitSoniME I agree viewing this as an enhancement, since doing it without the custom component works perfectly fine. Thanks for your input!


Can't open offline skill tree

There seems to be a bug in my "PersistentData.xml" file as when it's in the folder of the exe the program crashes when I try to open it, whereas when I take it out the program works fine. Both the xml and debug.txt can be downloaded here: https://www.mediafire.com/folder/1pmjywfwv5mt7/Error

This should work.
https://drive.google.com/file/d/0B-ktjUGcKZUmTzZVYzZQOW5LdVk/view?usp=sharing
By some reason there was no closing tags after a note text. Seems it crashes in the middle of saving file.
Could you elaborate what symbols you've been trying to put into the note? (it's starting with "Maligaro's, LC, Atziri's")

That's very strange, it's a build I haven't touched in months and I use the
offline tree almost every day, so it's that it started acting up now. I
don't remember what the sybols would have been but I can't imagine it would
have been anything other than a link/basic symbols (?, +, brackets, etc) I
use in other build notes.
On 3 March 2015 at 23:58, Aliaksei Paulouski<EMAIL_ADDRESS>wrote:

This should work.
https://drive.google.com/file/d/0B-ktjUGcKZUmTzZVYzZQOW5LdVk/view?usp=sharing
By some reason there was no closing tags after a note text. Seems it
crashes in the middle of saving file.
Could you elaborate what symbols you've been trying to put into the note?
(it's starting with "Maligaro's, LC, Atziri's")
—
Reply to this email directly or view it on GitHub
https://github.com/EmmittJ/PoESkillTree/issues/102#issuecomment-76940529
.

It looks like, from the debug file, that the app wasn't able to fully write to the file for some unknown reason. Which really doesn't make sense because there isn't anything else that should be writing or reading to it. Could have been an improper shutdown of the application (was killed before completely finishing write to file at close).
Symbols shouldn't matter unless you were writting xml within the note.

Oh that makes sense, I thought some builds were missing, I guess it cut
some of them off. I had a count-down to turn off my computer at some point,
I guess the app didn't react too well to that.
On 4 March 2015 at 19:35, Emmitt Johnson<EMAIL_ADDRESS>wrote:

It looks like, from the debug file, that the app wasn't able to fully
write to the file for some unknown reason. Which really doesn't make sense
because there isn't anything else that should be writing or reading to it.
Could have been an improper shutdown of the application (was killed before
completely finishing write to file at close).
Symbols shouldn't matter unless you were writting xml within the note.
—
Reply to this email directly or view it on GitHub
https://github.com/EmmittJ/PoESkillTree/issues/102#issuecomment-77116484
.

No apps really have a good response to being terminated without closure.  I did it with a couple of other things like data updating. Just store a temp file then overwrite if all went well

I did some testing on Note content, and you can write there anything
(XML reserved chars, non-printable chars) and it's properly serialized.
Just there is issue with non-printable characters during deserialization
(it crashes during read on � for instance), but that's another issue.
The exception in debug.txt about not being able to access file is due to
race condition during shutdown+crash. As shutdown wants to save data,
then it crashes and crash handler wants to save data as well.

Alright, I am not at a computer to test things but that makes sense.
Confirms my speculation about the shutdown condition as well as the note
thing (and probably any of the fields).


Create quick-access button

It would be great to have a quick access button for dimming. Press once for minimum, again for half, then full, off, etc.
Would also be great to get it as a quick-tap setting for the pixel 7, maybe the double tap loads a preset user-defined brightness level?

The quick settings tile already exists.
Implementing the 4-step dimmer into quick settings could be possible.
But overriding the double tap on P7 with Android 13 is currently not possible I think.
If you have ideas how to implement it, please let me know :)

Oh sweet, hadn't noticed it till now. The 4-step dim would be great to see as quick settings tile. It appears the double tap uses a CHRE nanoapp that is native to the pixel line? (Info on it seems to be quite sparse) Antenna pod uses the backtapp gesture to open the app, refresh or launch straight into various options. Personally I'm currently using the backtapp to open straight to flashdim

Thanks for the links, didn't know you could detect the double tap signal.
How can you activate the double tab feature for Antenna pod? Didn't found it.
Also let's split the 4-step dim and the backtap feature into multiple issues.
Do you mind opening another one specificially for the 4-step dim? :)

Not sure myself, I'll see if I can do some looking into it. It may be worth lodging an issue with the antenna pod guys to figure out their technique. I'll open up a new issue for the 4-part dim switch also

I think you misunderstood, it's not about how to implement it.
I rather would like to know how to use the tap feature in the Antenna pod app.

Ah, I've included a screenshot of how it is used on my pixel 7. It is an option within the phone settings to open an app with the quick tap, and then antenna pod has options to open to a specific part of the app.

I get it now how it's working.
You can configure app shortcuts to be executed on quick tapping.
So I would just need to add these shortcuts. I'm thinking of Off, Minimum, Half, Maximum, Initial Level.

Awesome! Those shortcuts seem great also. Would it be possible to get a cycle shortcut to cycle between each of those modes?

Shortcuts are now available in Version 2.3.0.
With my effort to keep it as simple as possible. at the moment there are the options "Minimum", "Half" and "Maximum".


Add VpcAssociationPolicy CRD

Which issue does this PR fix: Add VpcAssociationPolicy CRD to support SNVA security Group API
What does this PR do / Why do we need it: Add VpcAssociationPolicy CRD to support SNVA security Group API
If an issue # is not available please add repro steps and logs from aws-gateway-controller showing the issue:
Testing done on this change:
Installed this CRD in my own cluster succeeded by kubectl apply -f config/crds/bases/application-networking.k8s.aws_vpcassociationpolicies.yaml
Automation added to e2e:

Will this PR introduce any new dependencies?:

Will this break upgrades or downgrades. Has updating a running cluster been tested?:
Does this PR introduce any user-facing change?:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Shall we use a different name, e.g. GatewayAWSPolicy?   And we can add other parameters to them, e.g.

enable/disable access log

Shall we use a different name, e.g. GatewayAWSPolicy? And we can add other parameters to them, e.g.
* enable/disable access log

I think we decide to do them in 2 CRDs,

one CRD for access log and authpolicy that can apply to both Gateway and Route
Another one VpcAssociationPolicy CRD that can only apply to Gateway

For the name of VpcAssociationPolicy we could discuss, GatewayAWSPolicy can be a option

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 39.061%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
4008

Relevant Lines:
10261

💛  - Coveralls


Bitwarden.Bitwarden version 2022.8.0

[x] Have you signed the Contributor License Agreement?
[x] Have you checked that there aren't other open pull requests for the same manifest update/change?

[ ] Have you tested your manifest locally with winget install --manifest <path>?
[x] Does your manifest conform to the 1.1 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.

Microsoft Reviewers: Open in CodeFlow

Hello @mivsvit, The package manager bot determined that the metadata was not compliant.

Failing validation due to
https://github.com/microsoft/winget-create/issues/297
Using the latest wingetcreate results in manifest version 1.2.0.


Dialog to insert / edit links should be easier to use for relative links

The dialog should prompt an autocomplete of summary articles and headings (anchors in the page).
For example, here is what it looks like in Google Docs:

There's room for improvement, but the main feature is done


NewsBlur: ability to sync read stories

Hi there! I've recently switched feed providers to NewsBlur, it seems NetNewsWire has good support!
However, whether it be for performance reasoning or otherwise, I've noticed it only syncs unread stories. Once an unread story is retrieved, it remains cached on the device and the read status of the story syncs appropriately, as expected. When I first configured NetNewsWire against the NewsBlur account I was actually under the impression that the integration was broken, as all my stories on the account were marked as read, and therefor nothing was showing in NewsBlur.
If I recall correctly (the last feed provider I used was Feedbin,) this is not the behaviour for other integrations; an amount of days of articles are synced regardless of the read status. Would it be possible to have this behaviour with NewsBlur as well? Happy to have an attempt at fixing this but a quick look at the relevant classes makes it look like the logic is quite centered around syncing unread posts; it may be difficult.

I’m not sure I understand what you’re seeing. Say a feed has ten articles in it, and five are read. Which articles appear in NetNewsWire? Which articles appear in NewsBlur?

Hi Brent, many thanks for the quick response! All ten articles would appear in NewsBlur, with five marked as unread. However, NNW will only show the five unread articles, regardless if 'unread only' is selected in the NNW view. The expected behaviour here would be that all ten articles also show in NNW, with the read status of the articles reflecting NewsBlur appropriately.
One thing to note: once NNW sees an article, it seems to persist to the local cache, as expected, and it's read status syncs with NewsBlur, also as expected. This means that if NNW is used as the sole means to access the NewsBlur account, then everything pretty much works OK; the articles aren't being marked as read before NNW sees them, thus NNW syncs the whole account. However, if NewsBlur on web is used to read articles before NNW is opened, then those read articles never show up in NNW, unless they are explicitly marked as Unread again so NNW pulls them down, and is able to cache them.


SMTP authentication failing

Description
I am running Gitea as a docker container.
In the past I have been able to use a SMTP server with authentication successfully.
I have recently had to change SMTP providers and now am getting this error message when I am testing email:
Failed to send a testing email to "<redacted>": gomail: could not send email 1: failed to authenticate SMTP: 535 5.7.8 Error: authentication failed: authentication failure

I have looked into the debugs, but there are not many around the email process.
I have also tried another go based CLI mail program (github.com/kiwimic/mailCLI) to see if the SMTP service is working with the same SMTP credentials as I have configured for Gitea.
That CLI worked.
I also tested with the swaks CLI tool with the same SMTP credentials, and it worked too.
So, I am wondering why Gitea isn't working.  Is there a way to get more debugging information out of Gitea?  I have set the log level to DEBUG, but it isn't including things like what attributes it is passing to the SMTP service or anything like that.
I am wondering if it is a string encoding issue or something that is causing the SMTP server to say authentication failure.
Any assistance would be fantastic - I'm happy to diagnose further, I am not as familiar with go as with other languages.
Gitea Version
1.20.0+dev-888-g64e0672e3
Can you reproduce the bug on the Gitea demo site?
No
Log Gist
No response
Screenshots
This is the only console log about the test email:
gitea     | 2023/05/24 15:41:13 ...eb/routing/logger.go:102:func1() [I] router: completed POST /admin/config/test_mail for []:0, 303 See Other in 2924.0ms @ admin/config.go:31(admin.SendTestMail)
Git Version
git version 2.40.1
Operating System
Docker container
How are you running Gitea?
Within a Docker container using the gitea/gitea:nightly release.
I used nightly to see if the isn't had been resolved in the latest version.
docker-compose.yml contains:
...
      - GITEA__mailer__PROTOCOL=smtp+starttls
      - GITEA__mailer__SMTP_PORT=587
      - GITEA__mailer__IS_TLS_ENABLED=true
      # shouldn't need this but giving it a try
      - GITEA__mailer__FORCE_TRUST_SERVER_CERT=false
      - GITEA__mailer__FROM=<redacted>
      - GITEA__mailer__USER=<redacted>
      - 'GITEA__mailer__SUBJECT_PREFIX=GITEA: '
      - GITEA__mailer__PASSWD=`<redacted>`
...

Database
MySQL

Can you manually check your "app.ini" to see whether the options are right there?
gitea.com is also using the nightly and it also sends emails, it works there.

G'day @wxiaoguang,
Thanks for the prompt response.
I was able to check that and had found that the environment variables from the docker-compose.yml hadn't come through correctly.
I have made some adjustments and I think it may be working now.
I will update for sure once I can confirm.


Can I achieve this type of header animation with this library?

initial state:

After scrolling until specific height:

No, and I don't think this module can support it anytime soon but I will write a comment here when it's possible.

No, and I don't think this module can support it anytime soon but I will write a comment here when it's possible.

Alright, thank you for fast reply and this library too.

I opened https://github.com/benevbright/react-navigation-collapsible/pull/159 to resolve this issue. (WIP)
There is still one blocker. On Android, react-navigation's backgroundHeader is non-touchable. I may open a PR there and see how they think about it.


[App Service] az webapp create Add new parameter --acr-use-identity to configure pull image from ACR using MSI when creating a container web app

Related command
az webapp create
Description
Add new parameter --acr-use-identity to configure pull image from ACR using MSI when creating a container web app. It allows user to update siteconfig acrUseManagedIdentityCreds while creating webapp, this can significantly reduce steps user needs to have to create a container webapp which pulls image from ACR using MSI.
Testing Guide

Create webapps by running az webapp create command with and without --acr-use-identity to make sure webapp can be created successfully with new parameter also changes don't break webapp creation without this new parameter. And check the config of new created webapp by using az webapp config show to make sure siteconfig acrUseManagedIdentityCreds is updated as expected.
Create test methods test_webapp_hyperv_acr_use_identity and test_webapp_linux_acr_use_identity to test az webapp create with this parameter

History Notes

[Component Name 1] BREAKING CHANGE: az command a: Make some customer-facing breaking change
[Component Name 2] az command b: Add some customer-facing feature

This checklist is used to make sure that common guidelines for a pull request are followed.

[x] The PR title and description has followed the guideline in Submitting Pull Requests.

[x] I adhere to the Command Guidelines.

[x] I adhere to the Error Handling Guidelines.

App Service


OpenAITransformer

Adds a Transformer that leverages the OpenAI API for completitions

I still need to add the API_KEY to this but I'm curious if code_review workflow will catch that.

@fxchen Interesting feedback from the code_review workflow. It missed that I didn't set up the API_KEY, and some of it's suggestions it didn't even follow (and they weren't particularly good), but some decent stuff in there (catching the copy pasted unspecified-encoding pylint disable, breaking out the separate methods). I'd say it was like 3/9 in terms of good suggestions.


undefined is not an object (evaluating 'BarcodeManager.barCodeTypes')

是编译不成功导致的吗

<Barcode style={{ flex: 1, alignSelf: 'stretch', }}
	ref={component => this._barCode = component}
	barCodeTypes={['qr']}
	onBarCodeRead={(event) => this._onBarCodeRead(event)} />

<Barcode style={{ flex: 1, alignSelf: 'stretch', }}
	ref={component => this._barCode = component}
	barCodeTypes={['org.iso.QRCode']}  // add this prop
	onBarCodeRead={(event) => this._onBarCodeRead(event)} />

barCodeTypes=oneOf([
0: "org.gs1.EAN-8"
1: "org.gs1.EAN-13"
2: "org.iso.Aztec"
3: "org.iso.QRCode"
4: "org.iso.PDF417"
5: "org.iso.Code128"
6: "org.iso.Code39"
7: "com.intermec.Code93"
8: "org.gs1.UPC-E"
9: "org.iso.Code39Mod43"
])

I add  ” barCodeTypes={['org.iso.QRCode']}  // add this prop “，but it also does not work。
It seems like to be short of .podspec file when I use RN0.60.4 with CocoaPods。
I am an iOS developer。My colleague maked it work On Android without CocoaPods。

On RN 0.60.4, When I cd  ios directory and use "pod install"。The following prompt appears：
[!] use_native_modules! skipped the react-native dependency 'react-native-smart-barcode'. No podspec file was found.
    - Check to see if there is an updated version that contains the necessary podspec file
    - Contact the library maintainers or send them a PR to add a podspec. The react-native-webview podspec is a good example of a package.json driven
    podspec. See https://github.com/react-native-community/react-native-webview/blob/master/react-native-webview.podspec
    - If necessary, you can disable autolinking for the dependency and link it manually. See
    https://github.com/react-native-community/cli/blob/master/docs/autolinking.md#how-can-i-disable-autolinking-for-unsupported-library

And the following Error on screen when I run the demo
undefined is not an object (evaluating 'BarcodeManager.barCodeTypes')


Split common Github Actions into reusable workflows

We want to do PR branch deployments and most of the steps are the same as the Production deployment workflow
Keep workflows DRY

.deploy noop

.deploy to staging

.deploy to staging


fix: multiple changes in the Jupyter notebooks

Changes

Replaces references to code to src
Adds language attributes to fenced code blocks
Updates output of setup.cfg in notebook 2.
Fixes spelling and grammar errors
Standardised the README using the template
Edits the Introduction to include instructions on how to clone the repo
Adds Learning Outcomes
Renames the conda venv from recode to mcmc to avoid conflicts with other (future and present) ReCoDE exemplars

Looks good! Can you add a little section mentioning how to enable Mathjax to the documentation chapter?

Looks good! Can you add a little section mentioning how to enable Mathjax to the documentation chapter?

Sure, for .rst files or for Jupyter notebooks, parsed with sphinx? For some reason the latter requires you to dig through the settings of myst-nb instead of working out of the box. In contrast, nbsphinx just worked by I thought I would stick with the Jupyter parser you chose.

@TomHodson I think we should move the API docs section at the end of the Table of Contents. As it currently stands it interferes with the flow of the exemplar. Quickstart --> Intro --> ... seems much smoother than Quickstart --> API Docs --> Intro -->...

Yeah I agree

@TomHodson Is there somewhere a list of the Learning Outcomes of the exemplar?

No but Jeremy and I can come up with some tomorrow

All looks good!

Thanks @jcohen02 for the review! I have gone ahead and committed all the requested changes. It would appear that my "smart" machine learning spell checker is not that smart after all.
Two things that we might want to address before we merge are:

[ ] collapsable sections in Jupyter notebooks for the solutions, haven't found any great solutions to this yet. Jupyter book, has an implementation but that would require swapping the Sphinx docs, with Jupyter book which I would not recommend.
[ ] Making sure that the Binder link works. I have been trouble getting the environment to initialise. It could be just me, but it would be good if we could verify.

I wouldn’t have any problem with you swapping nbsphinx in. the fact that
myst doesn’t support Mathjax by default is pretty weird.
On Tue, 19 Jul 2022 at 09:27, gnikit @.***> wrote:

Looks good! Can you add a little section mentioning how to enable Mathjax
to the documentation chapter?
Sure, for .rst files or for Jupyter notebooks, parsed with sphinx? For
some reason the latter requires you to dig through the settings of myst-nb
instead of working out of the box. In contrast, nbsphinx
https://nbsphinx.readthedocs.io/en/0.8.9/ just worked by I thought I
would stick with the Jupyter parser you chose.
—
Reply to this email directly, view it on GitHub
https://github.com/ImperialCollegeLondon/ReCoDE_MCMCFF/pull/5#issuecomment-1188755190,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAPX4SCABEYSU4M7662ZDW3VUZRH5ANCNFSM53572MRA
.
You are receiving this because you commented.Message ID:
@.***>

Ah I see there are some comments waiting my input, I'll take a look when I'm on my desktop.
I do find binder a bit hit and miss, they cache the environments but delete them after a period of time so if you spin one up when the environment has aged out of the cache it takes absolutely ages to initialise.

I wouldn’t have any problem with you swapping nbsphinx in. the fact that myst doesn’t support Mathjax by default is pretty weird.

It's working now so I wouldn't bother. I think it's more like, myst-nb does not support $$ by default. My guess is that they are doing so to avoid triggering the Mathjax parser erroneously.
I can commit the suggested changes for you if you want.

@TomHodson good to merge this one?

Yeah!
Did that typo that Jeremy pointed out make its way into this? Or should I click the "commit suggestion" button?
For the collapsible answers, Jing's suggestion to use HTML summary tags could work but it means the use has to copy past the code to run it, so the notebooks wouldn't actually run to completion without manual intervention.

@TomHodson, re collapsible cells with answers, does this help by any chance? https://github.com/aquirdTurtle/Collapsible_Headings. Assuming there's a way to tell some content to be collapsed by default, I wonder if this might give you what you want?

Yeah!
Did that typo that Jeremy pointed out make its way into this? Or should I click the "commit suggestion" button?

I think you need to commit the changes for those.

For the collapsible answers, Jing's suggestion to use HTML summary tags could work but it means the use has to copy past the code to run it, so the notebooks wouldn't actually run to completion without manual intervention.

I would leave the collapsible sections for the another PR. I think we've added too many changes on this one. I am of the opinion that the Jupyter notebooks should be able to run, so the HTML solution is not idea.

@TomHodson, re collapsible cells with answers, does this help by any chance? https://github.com/aquirdTurtle/Collapsible_Headings. Assuming there's a way to tell some content to be collapsed by default, I wonder if this might give you what you want?

There are other extensions out there:

https://jupyter-contrib-nbextensions.readthedocs.io/en/latest/nbextensions/collapsible_headings/readme.html
https://stackoverflow.com/questions/33159518/collapse-cell-in-jupyter-notebook


Add WorkloadIdentityCredential to the DefaultAzureCredential.

Fixes https://github.com/Azure/azure-sdk-for-cpp/issues/4906
Left to do:

Update the unit test so it passes, although they should be re-written a bit more generically: https://github.com/Azure/azure-sdk-for-cpp/issues/4939
This PR depends on the simplified ctor updated in https://github.com/Azure/azure-sdk-for-cpp/pull/4893

Regarding #4939, I think it is totally ok to test the order of messages - the tests come with the specific SDK version, so they can be updated together with the code to ensure the order intended, it is actually a plus. And it is easy to update the test as we rearrange or add new credentials.


green_or_brown is no longer sufficient with new scenarios

Methodologically
If a 2-degree aligned scenario states that a technology should increase, we colloquially refer to it as "green", and associate to it a sector-market share target.
conversely, if the 2-degree aligned scenario states that this technology should decrease, we call it "brown", and associate to it a technology-market share target
It is important to note, that these definitions are not necessarily consistent across scenarios. For example, the WEO2020 SDS scenario (which is a 2-degree aligned scenario) would have nuclearcap increasing (thus we would call it a "green" technology), however in the Net-Zero Asset Owners Alliance ISF 1.5 degree scenario, nuclearcap is set to decrease.
In practice
The static file r2dii.data::green_or_brown is used to dictate if a technology should increase or decrease:
library(r2dii.data)

green_or_brown
#> # A tibble: 20 x 3
#>    sector       technology    green_or_brown
#>    <chr>        <chr>         <chr>
#>  1 automotive   electric      green
#>  2 automotive   hybrid        green
#>  3 automotive   ice           brown
#>  4 automotive   fuelcell      green
#>  5 power        hydrocap      green
#>  6 power        renewablescap green
#>  7 power        coalcap       brown
#>  8 power        gascap        brown
#>  9 power        oilcap        brown
#> 10 power        nuclearcap    green
#> 11 oil and gas  oil           brown
#> 12 oil and gas  gas           brown
#> 13 coal         coal          brown
#> 14 fossil fuels oil           brown
#> 15 fossil fuels gas           brown
#> 16 fossil fuels coal          brown
#> 17 hdv          electric      green
#> 18 hdv          hybrid        green
#> 19 hdv          ice           brown
#> 20 hdv          fuelcell      green

Created on 2021-07-05 by the reprex package (v2.0.0)
Using this file alone, would set a "green" target for nuclearcap, regardless of what scenario is used.
Solution
We either need to:
a) Extend the file green_or_brown to include a column source, which dictates, per scenario, if the technology should increase or decrease
b) Calculate if the technology should increase or decrease programatically in r2dii.analysis (this would require the user to flag which scenario(s) are actually 2-degree aligned).
My preference would be a), which is the more bulky/ time-consuming solution on our part, but relies on less, potentially confusing, input from the user

@jdhoffa If I understand correctly, different scenarios have different definitions of green/brown techs. Does this mean that we would need one of these files for each scenario? And if so, what happens if a particular scenario doesn't comment on a particular tech? Do we have default fall-back positions?
This seems like an analyst/methodology question for now, and once that's decided, we can figure out what the best plan for implementation is.

a) Extend the file green_or_brown to include a column source, which dictates, per scenario, if the technology should increase or decrease

this seems a bit wonky to me... if we let the scenario determine green_or_brown then there's no sense in maintaining a list of them which will need to be up to date and will break whenever a new scenario is added, when it could easily be inferred from the scenario data

b) Calculate if the technology should increase or decrease programatically in r2dii.analysis (this would require the user to flag which scenario(s) are actually 2-degree aligned).

This has problems because whether a technology is increasing or decreasing in a given scenario is easily affected by what time horizon you're looking at, particularly because the default for PACTA is 5 years and the scenarios typical project far beyond that.

@AlexAxthelm you understand mostly correctly, it isn't even really a definition per se, it's actually inferred directly from if the scenario increases or decreases production in a 2-degree aligned pathway. Let's take an example to see:
Consider the WEO 2020. It is a scenario provider, which contains a few different scenarios:

Current Policies Scenario (CPS): Projects what will happen if all current policies proceed as expected (NOT 2-Degree Aligned)
Stated Policies Scenario (SPS): Projects what will happen if all state policies proceed as expected (NOT 2-Degree Aligned)
Sustainable Development Scenario (SDS): The only 2-Degree Aligned Scenario from the WEO.

In principle, what we would do, is:

Take the 2-degree aligned scenario (in the example, the SDS)
Determine overall if production in any technology is increasing or decreasing, across it's ENTIRE time-horizon (all years for which the scenario projects production values)
Label each technology as "increasing/ green" or "decreasing/ brown"
Apply targets accordingly

a) Extend the file green_or_brown to include a column source, which dictates, per scenario, if the technology should increase or decrease

this seems a bit wonky to me... if we let the scenario determine green_or_brown then there's no sense in maintaining a list of them which will need to be up to date and will break whenever a new scenario is added, when it could easily be inferred from the scenario data

I agree, except it isn't necessarily "easily" inferred from the scenario. As you point out later, it is very important that we:
a) Include the entire time-horizon of the scenario
b) Determine the increasing/ decreasing flag ONLY from 2-degree aligned scenario. (In the example above, it doesn't matter if renewablescap is decreasing in the CPS, all that matters is what happens in the SDS)
From a user-perspective, there are a few solutions we could approach that would avoid us having to maintain the green_or_brown list:

Allow the user to manually specify which scenario is 2-degree aligned (per scenario source). This seems risky, and prone to mistakes
Specify in the input scenario dataset which scenario is 2-degree aligned, and which isn't, and calculate increasing/ decreasing on the fly. This also seems risky to me, since if they happened to not input the full time-horizon of the scenario, they may miscalculate the flag.
Have an analyst determine if the technology is increasing or decreasing prior to shipping the scenario data, and include it as an extra column in the provided dataset. (This is basically just shifting the "maintenance onus" from r2dii.data to the scenario data preparation stage.

As for option b), there are many reasons that I think this would be delicate/ prone to mistakes (as I somewhat outlined above)

To be clear, I'm not exactly thrilled about any of these solutions, and happy for further input!

I think option 3 (analysts make a determination) is the right call, but is this issue a blocker for the 2.0 release?

It is a blocker for the inclusion of the NZAOA scenarios yes.

Can we get analyst time to calculate the flags for that scenario for this release, and go back and include the other scenarios in later releases?

Yes, I think we could add the column, calculate it for NZAOA, take the definition from that column (if it exists) and otherwise fallback to the green_or_brown definition for now.
Not ideal, but I think it should work. And then we move towards deprecating green_or_brown, and having all definitions come from the column?

An open question is if the scenarios have already been sent to users (without the column) for this release. I will clarify with George at 1pm

I'm only skimming -- sorry if this makes little sense.
@jdhoffa,
I sense one good solution is becomes less attractive because of maintenance costs. If so, can we engineer something to lower that cost?
r2dii.data already refreshes all data/ by sourcing files in data-raw/ -- automatically on CI.

Would it be possible to build some other script that solves this problem automatically for every commit?
If so, is this the best solution of other solutions discussed above are better?

Hey @maurolepore
This is in principle a very good idea, however to fully automate this would require access to all of the actual scenario datasets, which is outside of the scope of r2dii.data (or it is for now at least).

Need to assess this again, against 2022 scenarios

If I understand this issue correctly, it is solved by https://github.com/RMI-PACTA/r2dii.analysis/issues/426
@jdhoffa

Sounds good!


[BEAM-7275] ParDoLifeCycleTest: collect lifecycle info for DoFn insta…

…nces
The latest changes done in https://issues.apache.org/jira/browse/BEAM-7197 seem to have caused some flakiness on spark runner, see https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark/buildTimeTrend
Of course that static boolean tracking the call to teardown (https://github.com/apache/beam/blob/80e2cef1bcdb7e92bc2f9cf974fc87804cd4b2ad/sdks/java/core/src/test/java/org/apache/beam/sdk/transforms/ParDoLifecycleTest.java#L290) is bogus.
This PR replace this single static var by a map collecting on instances. We expect for every instance which had any lifecycle method invoked that the runner calls teardown.

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Choose reviewer(s) and mention them in a comment (R: @username).
[ ] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

Deleted a leftover commented out line of code as fixup commit.


Ruby gem home

Motivation for this change
Initially started by trying to solve #18784 but then I hit a ruby version heuristic bug so I refactored that as well.
/cc @manveru
Things done

[x] Tested using sandboxing
(nix.useSandbox on NixOS,
or option build-use-sandbox in nix.conf
on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] OS X
[ ] Linux

[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[x] Fits CONTRIBUTING.md.

This causes a lot of rebuilds but it might be worth having in 16.09 as well.

Still testing this out with all the scenarios I have in mind, it might take a while...

It looks like it's not the right approach. When changing the default gem dir, the ruby-installed gems like json don't appear anymore.

Related discussion: https://github.com/rubygems/rubygems/issues/1394

This second approach patches rubygems to install gems with --user-install by default. Bundler still tries to install gems in the Gem.default_dir which is inside the derivation.

Okay, bundle install is working as expected now.
I found another issue where the ~/.gem/ruby/2.3.0/bin shebangs are pointing to the absolute /nix/store path of the ruby installation. So if ruby is updated those will still point to the old version that was activated at the time of the ruby install.

After these changes rubygems doesn't seem to respect the GEM_HOME anymore. !!!! I need to make a matrix of all the possible combinations.

This looks really nice. Will make a lot of users happy, me included. thanks a lot!

I got it all working! The rubygems patches: https://github.com/rubygems/rubygems/compare/v2.6.6...zimbatm:v2.6.6-nix

[x] gem install with GEM_HOME
[x] gem install without GEM_HOME defaults to user
[x] bundle install with GEM_HOME
[x] bundle install without GEM_HOME defaults to user

So now it works like a RVM install for the user.
On the derivation side, buildRubyGem uses --no-shebang and so isn't affected by the change. The only potential issue is if a package calls gem install directly.

Your changes works for me. I would solve testing as the following: https://github.com/Mic92/nixpkgs/commit/42bae4e753a39b385db4f18bc8b7258bfc363fb8

Running nox-review on this, if it passes and don't get objections by then I'll merge this.

still works.

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/fedeback-on-ruby-setup/8070/3


Cannot use get_entity_groups_by_type() method

Version 1.3.2
Running method
dashboard_groups = rest_client.get_entity_groups_by_type('DASHBOARD')
Resulting error
Traceback (most recent call last):
  File "C:\Users\JacksonBowe\Envs\myinsightplatform\lib\site-packages\tb_rest_client\api_client.py", line 338, in __deserialize
    found_class = getattr(tb_rest_client.models.models_ce, klass)
AttributeError: module 'tb_rest_client.models.models_ce' has no attribute 'EntityGroupInfo'

I'm noticing this error is fairly common, where the CE and PE clients are so intertwined that some methods are defaulting to CE without being possible. E.g. same issue happens with get_integrations_get() method.

Did some digging, below is the problem
File api_client.py line 333ish. Looking for the below line
if sorted(list(found_class.attribute_map.values())) == sorted(list(data.keys())):
Printing these out shows the following
print(sorted(list(found_class.attribute_map.values())))
> ['additionalInfo', 'configuration', 'createdTime', 'edgeGroupAll', 'groupAll', 'id', 'name', 'ownerId', 'ownerIds', 'type']

print(sorted(list(data.keys())))
> ['additionalInfo', 'configuration', 'createdTime', 'groupAll', 'id', 'name', 'ownerId', 'ownerIds', 'type']

The only key different is edgeGroupAll. This is possibly because I'm trying to pull data from an installation of TB3.1.1PE.
To resolve this issue I tried uncommenting the following lines (see <<<<<<)
found_class = getattr(tb_rest_client.models.models_pe, klass)
if sorted(list(found_class.attribute_map.values())) == sorted(list(data.keys())):
    klass = found_class
    print('here')
# if all(attr in list(found_class.attribute_map.values()) for attr in list(data.keys())): <<<<<<<<<<
#     klass = found_class <<<<<<<<<<
else:
    found_class = getattr(tb_rest_client.models.models_ce, klass)
    # if sorted(list(found_class.attribute_map.values())) == sorted(list(data.keys())):
    klass = found_class

Uncommenting the above lines worked. Is there a reason that they were commented out? I don't want to be introducing errors back into my code that have already been handled, but for now I think I will keep it. When I upgrade my deployment to TB3.3PE I will revert back.

Hi @JacksonBowe, the latest version of rest-client is for ThingsBoard v.3.3-v.3.X, for this reason, attributes can be different.
Please update your ThingsBoard to the latest version.


Load browser meta only when browser opens

Before

After

@ivy-edp this will clash with https://github.com/axonivy/dataclass-editor-client/pull/50
Ether you merge first and I adapt or umgekehrt :D


chore(main): release 0.2.1

:robot: I have created a release beep boop
0.2.1 (2023-11-02)
Bug Fixes

deps: update all non-major dependencies (f42e233)
deps: update rust crate anyhow to 1.0.72 (0056c6f)
deps: update rust crate anyhow to 1.0.73 (abc244d)
deps: update rust crate anyhow to 1.0.74 (088035f)
deps: update rust crate anyhow to 1.0.75 (26391f8)
deps: update rust crate clap to 4.3.0 (cec50ea)
deps: update rust crate clap to 4.3.1 (e6cf3ec)
deps: update rust crate clap to 4.3.10 (fa517e4)
deps: update rust crate clap to 4.3.11 (0d56fdf)
deps: update rust crate clap to 4.3.12 (1beb67c)
deps: update rust crate clap to 4.3.14 (9f0f06b)
deps: update rust crate clap to 4.3.15 (8372c53)
deps: update rust crate clap to 4.3.16 (d25b6ec)
deps: update rust crate clap to 4.3.17 (7bb7111)
deps: update rust crate clap to 4.3.19 (08a14bf)
deps: update rust crate clap to 4.3.2 (b06e277)
deps: update rust crate clap to 4.3.21 (54a0d24)
deps: update rust crate clap to 4.3.22 (74ccd3d)
deps: update rust crate clap to 4.3.23 (6b80fee)
deps: update rust crate clap to 4.3.24 (d185b4f)
deps: update rust crate clap to 4.3.3 (89d5ba8)
deps: update rust crate clap to 4.3.4 (f158d2e)
deps: update rust crate clap to 4.3.5 (610b827)
deps: update rust crate clap to 4.3.8 (6f9b914)
deps: update rust crate clap to 4.3.9 (fc48b80)
deps: update rust crate clap to 4.4.1 (b4a9f1c)
deps: update rust crate clap to 4.4.2 (6ced44e)
deps: update rust crate clap to 4.4.3 (1e319ae)
deps: update rust crate clap to 4.4.4 (8ad2d99)
deps: update rust crate clap to 4.4.5 (c515db5)
deps: update rust crate clap to v4.4.7 (67a1aca)
deps: update rust crate indexmap to 2.1.0 (f5c616e)
deps: update rust crate indexmap to v2 (dd32716)
deps: update rust crate pretty_env_logger to 0.5 (3efb6d5)
deps: update rust crate tokio to 1.29 (89e0c0c)
deps: update rust crate tokio to 1.30 (c2e50ae)
deps: update rust crate tokio to 1.31 (df7c9ad)
deps: update rust crate tokio to 1.32 (91a7c58)
deps: update rust crate tokio to 1.33 (a88adac)
remove dead code and fix deprecations (e614cc7)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/FruitieX/add-bot-rs/releases/tag/v0.2.1 :sunflower:


302 error when hitting chp in dev

Describe the bug
I get a 302 http error message when I send queries to http://chp.thayer.dartmouth.edu/query
To Reproduce
Steps to reproduce the behavior:

Open a terminal
Run:

curl -X 'POST' \
  'http://chp.thayer.dartmouth.edu/query' \
  -H 'accept: */*' \
  -H 'Content-Type: application/json' \
  -d '{
  "message": {
    "query_graph": {
      "nodes": {
        "n0": {
          "ids": null,
          "categories": [
            "biolink:Gene"
          ],
          "constraints": []
        },
        "n1": {
          "ids": [
            "UBERON:0009835"
          ],
          "categories": [
            "biolink:GrossAnatomicalStructure"
          ],
          "constraints": []
        }
      },
      "edges": {
        "e0": {
          "predicates": [
            "biolink:expressed_in"
          ],
          "relation": null,
          "subject": "n0",
          "object": "n1",
          "constraints": []
        }
      }
    }
  }
}'

Expected behavior
I get a 200 response back with a valid TRAPI response

@maximusunc can you try rerunning this now? I believe the issue is resolved. Let me know if it is not on your end.


Improve module docstring for Set.lean

I'm still convinced that Kevin insisting to call elements of Set X "subsets of X" is only confusing people.

I'm happy with this change :-) I have noticed that Patrick and I have different mental models of a type, but this has never particularly concerned me.


docs: change Rust dependencies to specify exact prerelease version

This changes every occurrence of the soroban-sdk to specify exactly that it should use version =20.0.0-rc2.2 to avoid conflicts with current Testnet software.

Preview is available here:http://soroban-docs-pr671.previews.kube001.services.stellar-ops.com/

Preview is available here:http://soroban-docs-pr671.previews.kube001.services.stellar-ops.com/


feat: Added batch analysis feedback set command

Changed ´lime-js´ package version, to use new ContentType reference;
Added missing ´$´ at the start of some parameters;
Added set batch analysis feedback command.

:tada: This PR is included in version 6.8.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


GitHub Action sometimes does not clean up the environment

Describe the bug

A clear and concise description of what the bug is.
To Reproduce
Steps to reproduce the behavior:

Configure GitHub Static Apps with included workflow
Create a PR to integration branch
Merge the PR into integration branch
Look for the environment in Static Web Apps.

Expected behavior
The environment is always cleaned up after its PR is closed.
Observed behavior
Inconsistently, the Action runs with seemingly successful output (see below), but the PR branch environment remains in Static Apps.
Screenshots
N/A
Device info (if applicable):
N/A
Additional context
I don't recall observing this behavior prior to using environment branches.
Failure to cleanup environments causes us to hit our limit on environments (10), which causes Static Web App deployments to fail, which causes more PRs to queue up, which exacerbates the problem and takes much time to resolve on a frequent basis (between weekly to daily).
workflow config
name: Storybook CI/CD

on:
  push:
    branches:
      - integration
  pull_request:
    types: [opened, synchronize, reopened, closed]
    branches:
      - integration

jobs:
  build_and_deploy_job:
    if: github.event_name == 'push' || (github.event_name == 'pull_request' && github.event.action != 'closed')
    runs-on: ubuntu-latest
    name: Build and Deploy Job
    outputs:
      url: ${{ steps.builddeploy.outputs.static_web_app_url }}
    steps:
      - uses: actions/checkout@v2
      - uses: actions/setup-node@v3
        with:
          node-version: 16
          cache: npm
          cache-dependency-path: web-client/package-lock.json
          registry-url: https://npm.pkg.github.com
      - name: Login to NPM
        run: echo "//npm.pkg.github.com/:_authToken=$NPM_TOKEN" >> .npmrc
        env:
          NPM_TOKEN: ${{ secrets.READ_PAT }}
      - name: Install dependencies
        shell: bash
        run: |
          cd web-client
          npm ci
      - name: Build
        shell: bash
        run: |
          cd web-client
          npm run build-storybook
          cp staticwebapp.storybook.config.json storybook-static/staticwebapp.storybook.config.json
        env:
          NODE_OPTIONS: "--max_old_space_size=4096"
      # TODO: https://docs.microsoft.com/en-us/azure/static-web-apps/build-configuration?tabs=github-actions#monorepo-support
      - name: Deploy
        id: builddeploy
        uses: Azure/static-web-apps-deploy@v1
        with:
          azure_static_web_apps_api_token: ${{ secrets.WEB_CLIENT_STORYBOOK_DEPLOYMENT_TOKEN }}
          repo_token: ${{ secrets.GITHUB_TOKEN }} # Used for Github integrations (i.e. PR comments)
          action: "upload"
          ###### Repository/Build Configurations - These values can be configured to match your app requirements. ######
          # For more information regarding Static Web App workflow configurations, please visit: https://aka.ms/swaworkflowconfig
          skip_app_build: true
          app_location: "/web-client/storybook-static"
          production_branch: integration
          ###### End of Repository/Build Configurations ######

  close_pull_request_job:
    if: github.event_name == 'pull_request' && github.event.action == 'closed'
    runs-on: ubuntu-latest
    name: Close Pull Request Job
    steps:
      - name: Close Pull Request
        id: closepullrequest
        uses: Azure/static-web-apps-deploy@v1
        with:
          azure_static_web_apps_api_token: ${{ secrets.WEB_CLIENT_STORYBOOK_DEPLOYMENT_TOKEN }}
          action: "close"

Output from the cleanup GitHub Action
/usr/bin/docker run --name cd98f85f4fb1b5a3747cb950c13e166a55cb8_950b85 --label 4cd98f --workdir /github/workspace --rm -e INPUT_AZURE_STATIC_WEB_APPS_API_TOKEN -e INPUT_ACTION -e INPUT_APP_LOCATION -e INPUT_API_BUILD_COMMAND -e INPUT_API_LOCATION -e INPUT_APP_ARTIFACT_LOCATION -e INPUT_OUTPUT_LOCATION -e INPUT_APP_BUILD_COMMAND -e INPUT_REPO_TOKEN -e INPUT_ROUTES_LOCATION -e INPUT_SKIP_APP_BUILD -e INPUT_CONFIG_FILE_LOCATION -e INPUT_SKIP_API_BUILD -e INPUT_PRODUCTION_BRANCH -e INPUT_DEPLOYMENT_ENVIRONMENT -e INPUT_IS_STATIC_EXPORT -e HOME -e GITHUB_JOB -e GITHUB_REF -e GITHUB_SHA -e GITHUB_REPOSITORY -e GITHUB_REPOSITORY_OWNER -e GITHUB_RUN_ID -e GITHUB_RUN_NUMBER -e GITHUB_RETENTION_DAYS -e GITHUB_RUN_ATTEMPT -e GITHUB_ACTOR -e GITHUB_TRIGGERING_ACTOR -e GITHUB_WORKFLOW -e GITHUB_HEAD_REF -e GITHUB_BASE_REF -e GITHUB_EVENT_NAME -e GITHUB_SERVER_URL -e GITHUB_API_URL -e GITHUB_GRAPHQL_URL -e GITHUB_REF_NAME -e GITHUB_REF_PROTECTED -e GITHUB_REF_TYPE -e GITHUB_WORKSPACE -e GITHUB_ACTION -e GITHUB_EVENT_PATH -e GITHUB_ACTION_REPOSITORY -e GITHUB_ACTION_REF -e GITHUB_PATH -e GITHUB_ENV -e GITHUB_STEP_SUMMARY -e RUNNER_OS -e RUNNER_ARCH -e RUNNER_NAME -e RUNNER_TOOL_CACHE -e RUNNER_TEMP -e RUNNER_WORKSPACE -e ACTIONS_RUNTIME_URL -e ACTIONS_RUNTIME_TOKEN -e ACTIONS_CACHE_URL -e GITHUB_ACTIONS=true -e CI=true -v "/var/run/docker.sock":"/var/run/docker.sock" -v "/home/runner/work/_temp/_github_home":"/github/home" -v "/home/runner/work/_temp/_github_workflow":"/github/workflow" -v "/home/runner/work/_temp/_runner_file_commands":"/github/file_commands" -v "/home/runner/work/monorepo/monorepo":"/github/workspace" 4cd98f:85f4fb1b5a3747cb950c13e166a55cb8
DeploymentId: f9[6](https://github.com/*****/*****/runs/7665220681?check_suite_focus=true#step:3:7)61ffa-[7](https://github.com/*****/*****/runs/7665220681?check_suite_focus=true#step:3:8)55a-413e-[8](https://github.com/*****/*****/runs/7665220681?check_suite_focus=true#step:3:9)e96-79aa6b403b2a

Looking for event info
Thanks for using Azure Static Web Apps!
Exiting

Hi @chriskuech, could you add some more details like the hostname of the static web app and when you have experienced the issue so I can investigate what is happening. Thank you!

Hi @annikel,
Thanks for the followup. My Azure-provided hostname is kind-ocean-05541841e.1.azurestaticapps.net. I had to delete environments as recently as today.  If you email me I can provide more info privately.

Hi @annikel, not sure if this is directly related or not, but I just received an Internal Server Error

@chriskuech Thanks! Still looking into it

One thing that may cause this is that the PR has a new push, but is merged before the last build from Azure Static WebApp is done. This seems to re-open the PR environment when the build is done, but the PR is already merged by then. So there will be no "Close PR" action happening after.
Maybe the action should check if the PR already is closed before re-deploying a new environment in the SWA?

Hey just as a data point, this has occurred again.

It happened to me as well and I suspect in my case at least the action closed a different preview environment. Could the action print the environment that it's about to close in the log? I.e. something like:
Looking for event info
Closing environment 'staging'
Thanks for using Azure Static Web Apps!
Exiting

This happens to me to. We opened 5 PRs yesterday and got the message that we hit the max number of staging environments. When logging into the portal, the staging environments listed included several from "old" PRs that were merged and closed a while ago. How does the github action identify the correct staging environment to close, could changing the name of the PR before closing it cause this?


Bump up testssl.sh to v3.0.7

bump testssl.sh from v3.0.2 to v3.0.7

That ain't gonna do much until you rebuild the install script... see e4b538a6fe771482f9a5c2612690cc47093328f4 in #282


fix(modals): Buttons position

Changes description 🧑💻

fix modal buttons position
add paparazzi tests for modals

Context 🤔

Closes #82
Closes #88
Closes #115
Closes #116
Checklist ✅

[x] Make sure you are requesting to pull a topic/feature/bugfix branch. Please, don't request directly from your main!
[x] Check commits & PR names matches our requested structure. It must follow the https://www.conventionalcommits.org pattern.
[x] Check compose contract convention. It must follow conventions described here.
[x] Check your code additions will fail neither code linting checks.
[x] I have reviewed the submitted code.
[x] I have tested on a phone device/emulator.
[x] I have tested on a tablet device/emulator.
[x] I have tested on a large screen device/emulator.
[x] If it includes design changes, please ask for a review design-system-core-team-design GitHub team.

You can download the apk here :

You can download the apk here :

You can download the apk here :
sample-debug.apk :
https://app.bitrise.io/app/e9ae480151be4514/build/7b025a55-73b6-476c-ad14-59840742de1c/artifact/881e64456e079a30/p/09916dec744020bbba39dfa3e6bfcdcd

You can download the apk here :

You can download the apk here :
sample-debug.apk :
https://app.bitrise.io/app/e9ae480151be4514/build/1c613f77-fff3-4c25-8d65-e2328e232ccf/artifact/75c204f0abbae497/p/4849bf574602f40fd854aee13af3dc98

You can download the apk here :
sample-debug.apk :
https://app.bitrise.io/app/e9ae480151be4514/build/bc7e7897-44a5-45b7-8a6c-cf6e4f2614c2/artifact/36697f8babeae741/p/ccc0134bbdcefc376bfece21b3e2137d

You can download the apk here :
sample-debug.apk :
https://app.bitrise.io/app/e9ae480151be4514/build/25fa0917-a117-4945-b3fa-796964493cfa/artifact/7b3017a24b090036/p/b07db4d72dcc86b7a9df705b3ba6ce77

You can download the apk here :

You can download the apk here :

You can download the apk here :
sample-debug.apk :
https://app.bitrise.io/app/e9ae480151be4514/build/85c0d56b-60ce-4915-8f39-f0e540c6f34b/artifact/e01d1af806e31ae8/p/ec8311d8ff8e78fcfa32351626fdbdac

You can download the apk here :
sample-debug.apk :
https://app.bitrise.io/app/e9ae480151be4514/build/947811f3-7cf4-40fd-8ca3-a76799b5879d/artifact/6f12a8f9c306a313/p/7fda7b568dcca227c26056562df6a1d1

You can download the apk here :
sample-debug.apk :
https://app.bitrise.io/app/e9ae480151be4514/build/a2d60035-5f58-4179-bbc3-d82607912576/artifact/37ec0f17d4a7e377/p/16dc9d0e2eb427347828e071b8cfd2e0

You can download the apk here :

You can download the apk here :
sample-debug.apk :
https://app.bitrise.io/app/e9ae480151be4514/build/6a500604-2369-46ed-ad8e-b21608dc299c/artifact/d73a57247d30eba8/p/2df7ff8672c8ebbe59622d05a955d596

You can download the apk here :
sample-debug.apk :
https://app.bitrise.io/app/e9ae480151be4514/build/8a2790ba-4c65-4ec2-8558-67d1655da30c/artifact/6a795e1086d513fa/p/6fad8ee2b52f4fb57ec167b5fb70432a

You can download the apk here :
sample-debug.apk :
https://app.bitrise.io/app/e9ae480151be4514/build/4e1f7c31-d78a-49ef-bdd6-f0bd0d47fdd0/artifact/0652abec811447b5/p/6584609b8e553a2208e77b89caad10b2

You can download the apk here :
sample-debug.apk :
https://app.bitrise.io/app/e9ae480151be4514/build/829328ec-05c8-442b-acee-833ccc36408b/artifact/da718c9410cd4f04/p/28f3388cbb51c3ab6a5aad12e9bf8ab3


Sprite.getBounds innacurate when sprite is scaled with negative values

Say you've an image loaded, then:
var testSprite = game.add.sprite(200,0,"test")
testSprite.getBounds()
---> Object { x: 200, y: 0, width: 300, height: 300, type: 22 }
testSprite.scale.x = -1;
testSprite.getBounds()
---> Object { x: 200, y: 0, width: 300, height: 300, type: 22 }

The getBounds() should be returning the x as being -100, since being scaled negatively should make 200 be the rightmost boundary of the sprite, not the leftmost boundary.
Fortunately, I found out how to fix this problem (I know I should be submitting a pull request but for now this works easier for me).
At the PIXI.Sprite.prototype.getBounds line at 15277, replace:
    if (a < 0) a *= -1;

with:
    if (a < 0) {
        a *= -1;
        var temp = w0;
        w0 = -w1;
        w1 = -temp;
    }

This updates the boundaries of sprite when the scaling flips the sprite horizontally so the correct bounds are calculated.
You'll also need to do the same for the vertical flipping. On the next line down from the above, replace:
    if (d < 0) d *= -1;

with:
    if (d < 0) {
        d *= -1;
        var temp = h0;
        h0 = -h1;
        h1 = -temp;
    }

I found this bug because generateTexture was generating textures with sides cut off because this bug meant it didn't have the correct area to crop from.
This is my first reported Phaser bug, thank you very much for creating an excellent HTML5 game engine!

Sure you don't want to learn some gitfu? Pull requests are fun!
I wonder if there was any edge case that relied on not-flipping.. since this appears to be a pixi issue, make sure they get notification as well.

Hmm let me check this with Mat first. It's a tiny change, but one of those things that could have catastrophic effects elsewhere :)

Discussed it over with him and we feel it should be a relatively safe change, so have made it and will test for 2.4.4 RC1.


"exports" support backport

This is a backport of https://github.com/microsoft/tslib/pull/121 since the 1.0 version of tslib is still being used in many ES packages such as material etc.
//cc @weswigham @DanielRosenwasser

ping 🙏🏻

Any chance of movement here @DanielRosenwasser @weswigham?

Hey folks, lets try get this moving. I've taken a look at this PR, but I can't get it to work in a way that I expected.
Haven't built an esmodules codebase before, so I cloned https://github.com/Urigo/typescript-node-es-modules-example as a reference using node esmodules and made some edits to make it use tslib for a function.
When I changed the tslib's package json to be the same as this lib running the code still failed with the same error:
$ node --experimental-specifier-resolution=node dist/index.js
file:///Users/ortatherox/dev/typescript/typescript-node-es-modules-example/dist/anotherFile.js:1
import { __awaiter } from "tslib";
         ^^^^^^^^^
SyntaxError: The requested module 'tslib' is expected to be of type CommonJS, which does not support named exports. CommonJS modules can be imported by importing the default export.
For example:
import pkg from 'tslib';
const { __awaiter } = pkg;
    at ModuleJob._instantiate (internal/modules/esm/module_job.js:98:21)
    at async ModuleJob.run (internal/modules/esm/module_job.js:137:5)
    at async Loader.import (internal/modules/esm/loader.js:162:24)
error Command failed with exit code 1.

But when I switched the tslib setup to replicate #119 it ran fine:
❯ yarn start
yarn run v1.22.4
$ node --experimental-specifier-resolution=node dist/index.js
hello world
Inside new string from function in another file

Considering you are a domain expert, and I'm an hour or two into researching. Am I missing something important, or is there a use case I've overlooked?

Can please you undo the rename to .cjs?

Yeah, bit of a rock & hard place here - "module": true will mean JS files are a module by default ( e.g. .js files) and in that context .cjs is commonjs.
@guybedford  checked on npm and no-one is using tslib/tslib.js but I think there's probably just too many private codebase who are probably doing weird things which we don't want to break unintentionally
I think the only answer is duplication of either tslib.es6.js -> tslib.mjs or tslib.js -> tslib.cjs with module: true TBH

Why is type: module needed at all? It's totally fine to use the default behavior, that .mjs is ESM and .js is CJS.

That was to avoid a duplicate file - @ljharb see #126 for an evolution of this PR

Thanks folks, the new backport PR is here #127 - I'm going to close this


[FR] Plot axes names on another scale

Sometimes it is useful to plot the data points and the axes names on a different scale, like e.g.

where the data is shown on the black scale and the axes names on the red scale.
Would this be easy to add as a feature?

Can you clarify what exactly is the feature request? Which keyword argument
is missing that should be forwarded to the internal Makie functions?
Em seg., 5 de fev. de 2024 14:21, jbrea @.***> escreveu:

Sometimes it is useful to plot the data points and the axes names on a
different scale, like e.g.
https://camo.githubusercontent.com/5bcd2bfcf503cbf460614d75a2c5e67945e39d1928b4cb026f3f556caa767390/68747470733a2f2f73746174697374696373676c6f62652e636f6d2f77702d636f6e74656e742f75706c6f6164732f323032332f30332f6269706c6f745f62617365525f312d312e706e67
where the data is shown on the black scale and the axes names on the red
scale.
Would this be easy to add as a feature?
—
Reply to this email directly, view it on GitHub
https://github.com/MakieOrg/Biplots.jl/issues/10, or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAZQW3LCB6LSPFABB5LMHHLYSEILDAVCNFSM6AAAAABC2Q5YLWVHI2DSMVQWIX3LMV43ASLTON2WKOZSGEYTSMBXGI2DANA
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

Not sure this can be done simply by forwarding a keyword argument to an internal Makie function. As you can see in the example, the axes names are plotted on a separate axis (the red one), which shares with the black one the origin, but has a different scale. I dont't even know, how to implement this in Makie. A new keyword argument for biplot could be axescale with default :auto (to plot on a separate scale) and :same (to plot on the same scale as the data; current behavior).

I don't know if I understand it. Do you know that we provide options to control the red axes already, right? The other black axes is the normal Makie axes that you can set with normal Makie functions such as ax.aspect = ..., ax.xlabel = ...

EDIT: you mean the ticks on the right and upper parts of the axes?

Yes.


Update to node20

node16 is eol, thus updating. See also https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/
Many popular actions (like checkout) already updated and everything should work fine.
The entire package-lock.json was regenerated via node20.
Also explicitly setting the node version in the lint action.

Looks good 🚀 , thanks!


Enhance deploy workflow

Let me premise that I still have no idea why putting the animal sniffer plugin caused maven to crash. I swear that there are times when maven behaves like an annoying child lol
To fix the problem I took a more radical approach: I created several profiles to slice the test modules. This way maven can autonomously decide which test to run depending on the java version used. A similar set of profiles regulates the dependencies of the jacoco aggregate. This way if some test modules are excluded from the compilation, jacoco won't need them for its aggregate and maven finally shuts up about not finding its precious missing dependencies.
A nice side effect of not needing to manually exclude the test modules is that it becomes very simple to create a matrix workflow to verify the snaphots. As a reference I put all the currently supported jdk versions, but maybe it's unnecessary. I don't know the billing time constraint, so I'll update the matrix on what you @armandino think is best. I'm also fine removing the matrix altogether if you think it's not needed anymore, this was just to demonstrate that now it's very easy to do :D
Bye!

Thank you @EvaristeGalois11. Having to exclude modules in the Deploy Snapshots workflow was a bit of a code smell IMO. It's good that you've refactored that. Hopefully this also fixes the issue introduced in #585. The matrix is a nice bonus too. 3 birds with one stone here - nicely done!

Thanks :)
It's indeed very satisfying when everything falls into place


Typo fix in chartmuseum/README.md

a small typo in line 25

/assign @unguiculus

/ok-to-test

/lgtm
Thanks @AdamDang !

welcome! @jdolitsky
I am very happy to attend the  Charts project.


Fastqc checking

This change corrects the path of fastqc.cwl when called to run from fastqc_workflow.cwl; and also renames the output folder name to fastqc.

Thanks @zo0z  - can you please comment on your VQSR related changes? What was wrong that is now fixed?

Yes,

For snps, the omni database is well curated, so it should be specified as: truth=true,  also, the ``1000G` is recommended to be a resource. I also changed the prior probablity for dbsnp to 2 (as per the recommendations here)
For indels, only Mills and dbsnp should be used as resources for the recalibration, and also the annotations specified in the file were for snps. A slightly different annotations were recommended by the GATK forum.

The cwlviewer has been really handy in picking up these


Directive Does Not Save Value When Highlighting and Deleteing Input or When Value is Entered and Then Deleted

I'm having trouble with the directive. It works except for certain cases where input is entered, highlighted, and deleted using the backspace key. Also, when value is entered and then backspaced to be deleted it saves the first character.
Any idea what is going on?

Perhaps this can be fixed by using $watch in the directive?

@TimeTravelersHackedMe Sounds like a legit bug to me, I'll take a peek. Feel free to PR if you find a fix before me!


Device Registration Service Service Principal suspicious activity on the AADPasswordProtectionProxy Service Principal

Customers report that the Device Registration Service Service Principal is creating and updating certificates on the AADPasswordProtectionProxy Service Principal. Events show in the audit logs and look suspicious.
We know that this is expected because these are the Password Protection "credentials to communicate with Microsoft Entra ID", which are managed in fact by the Device Registration Service Service Principal.
However, this is not mentioned anywhere in the public documentation. Please consider adding this information into the public doc.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 23e000f0-84ce-7ec7-e5ed-4bd9c49f5d49
Version Independent ID: e636b9d1-be81-0f00-97c4-ff4fa9078be3
Content: Deploy on-premises Microsoft Entra Password Protection - Microsoft Entra ID
Content Source: docs/identity/authentication/howto-password-ban-bad-on-premises-deploy.md
Service: active-directory
Sub-service: authentication
GitHub Login: @Justinha
Microsoft Alias: justinha

@sopopa2
Thanks for your feedback! We will investigate and update as appropriate.

@sopopa2
Thanks for bringing this to our attention.
I'm going to assign this to the document author so they can take a look at it accordingly.

@sopopa2 thanks for the suggestion and sorry for delay. This point has been added to the key considerations section. #please-close


Stacks and System Stacks pages are not namespace specific in k8s environment

Rancher Version: v1.2.0-pre1-rc1
Steps to Reproduce:

Create kubernetes environment and setup fully
Add wordpress catalog
Create a separate namespace
Go to new namespace and go to Stacks page or System Stacks apge

Results: Notice that it has the default namespace services in it.
Expected: Should not have default namespace services in them.

Version - v1.2.0-pre1-rc4
Verified fixed


Save Layout Mode/Sorting for folders

Problem:
If I open a folder, set a different Layout Mode, sort by different column, then move to a different folder/close tab and reopen folder, the layout mode will be reset.
Solution:
It should save a preferred Layout Mode and sorting for each folder, like Windows Explorer does.

Do you have this option enabled?

Do you have this option enabled?
Settings > Files and folders

Hmm, I actually do. So this is a bug I guess. I reproduced this with option enabled: I go to Downloads folder, set layout and sorting, open an new tab, open Downloads folder. The layout and sorting is reset. Logs in attachment.
debug.txt

Files version? I believe we added this after version <IP_ADDRESS>

Files version? I believe we added this after version <IP_ADDRESS>

Yea, it's that version, downloaded from Store. But as I explained above, this is a bug.

Thanks for confirming, this is fixed in latest code.


Incorrect results for negative intervals

          To me this doesn't look right. The previous test seems correct. When putting a negation in front of interval I believe it should negate the entire interval statement.

interval '5' - '1' - '2' year is one interval statement.
I think the statement
select -interval '5' - '1' - '2' year;

Should be interpreted as:
select - (interval '5' - '1' - '2' year);

Rather than
select (- interval '5') - '1' - '2' year;

If the user wants to negate only 5, they should write it as follows (below are all equivalents):
select interval '-5' - '1' - '2' year;
select interval - '5' - '1' - '2' year;
select - interval '5' year - interval '1' year - interval '2' year;

Originally posted by @aprimadi in https://github.com/apache/arrow-datafusion/pull/6698#discussion_r1232607304

However, note the current datafusion behavior is consistent with postgres as explained by @waitingkuo  in https://github.com/apache/arrow-datafusion/pull/6698#pullrequestreview-1485187142:

looks good to me, thanks.
in postgrseql
select -interval '5' - '1' - '2';

is intepreted as
select (-interval '5') - '1' - '2';

willy=# select -interval '5' - '1' - '2';
 ?column?
-----------
 -00:00:08
(1 row)

note that select -interval '5' - '1' - '2' hour doesn't work in postgresql
willy=# select -interval '5' - '1' - '2' hour;
ERROR:  syntax error at or near "hour"
LINE 1: select -interval '5' - '1' - '2' hour;

I don't think this ticket is tracking anything actionable now, so closing


feat: enable high-dpi scaling

BTW, I believe we should sync our progress with https://github.com/simplefoc/SimpleFOCStudio

Thank you for your contribution 👍


Create PR primary buttons are quite far away now

I think the main button used to be more to the top, but now the text area seems to stretch all the way down.

We did make the text area larger. @hbons has looked into moving the buttons to the top.

I've increased the size of the changes views and given them all new IDs. This will make the webview smaller.


Discover repository class from #[Entity] attribute on PHP 8

By doing it like this, we don't need to instantiate the object manager at all which makes PHPStan run faster and more reliable. Very often I had to manually clear my Symfony cache and re-run PHPStan.
Unfortunately, BetterReflection doesn't support attributes yet so therefore we need to use native ReflectionClass.
See https://github.com/phpstan/phpstan/discussions/5863#discussioncomment-1823297

Hmm, I don't understand why on PHP 8.0 it fails.

Please try the nice way via ClassReflection::getNativeReflection() and require phpstan/phpstan: "^1.3" here.

The fact that PHPStan reports an error like that is weird and I should look into it, but it might still work correctly. Hard to tell without a test.

For some reason I cannot install the dependencies for this project anymore:

  Problem 1
    - Root composer.json requires doctrine/mongodb-odm ^1.3 || ^2.1 -> satisfiable by doctrine/mongodb-odm[1.3.0-RC1, ..., 1.3.x-dev, 2.1.0, ..., 2.3.x-dev].
    - doctrine/orm[2.9.1, ..., 2.11.x-dev] require doctrine/common ^3.0.3 -> satisfiable by doctrine/common[3.0.3, ..., 3.2.x-dev].
    - Conclusion: don't install doctrine/common 3.2.0 (conflict analysis result)
    - Root composer.json requires doctrine/orm ^2.9.1 -> satisfiable by doctrine/orm[2.9.1, ..., 2.11.x-dev].

Weird that it just works on CI.

Yeah, you need --ignore-platform-reqs if you don't have the mongodb PHP extension installed locally.

I really don't know, it works in the playground: https://phpstan.org/r/fa2489cc-dfd7-4a61-8865-c29e83a8a2a6

\PHPStan\dumpType($this->reflectionProvider->getClass($className));
		\PHPStan\dumpType($this->reflectionProvider->getClass($className)->getNativeReflection());
		\PHPStan\dumpType($this->reflectionProvider->getClass($className)->getNativeReflection()->getAttributes());

  101    Dumped type: PHPStan\Reflection\ClassReflection
  102    Dumped type: ReflectionClass
  103    Call to an undefined method ReflectionClass::getAttributes().

🤷

I know! It's caused by config.platform.php here: https://github.com/phpstan/phpstan-doctrine/blob/04cace0bfd8d72cd5af13d90180d15fcb459d1ca/composer.json#L36-L41

I removed the php platform and now phpunit fails. Shouldn't PHPunit be installed differently on PHP < 7.3?
I fixed the name of the mongodb extension, as it was wrong.

Oke, so the only problem left seems to be a bug in PHPStan, am I right?
https://phpstan.org/r/a34ea8cd-2986-4bbf-82e2-a1041cb4a6de
If so, I can report it on phpstan/phpstan

@ondrejmirtes I hoped that PHPStan 1.3 would solve the problem with attributes, as the release notes mention this:

This brings plenty of bugfixes, for example PHP 8.0 Attributes can now be read in static reflection context

but I still cannot solve the problem.
Any idea how to proceed?

What PHPStan 1.3 fixed was an internal PHP error when accessing ClassReflection::getNativeReflection()->getAttributes() in some cases.
Are you trying to solve the problem on PHP 7.x from this example? https://phpstan.org/r/a34ea8cd-2986-4bbf-82e2-a1041cb4a6de This is usually solved by having different PHPStan configs for different PHP versions (when a project is analysed on different PHP cersions).
One notable example is PHPStan itself: https://github.com/phpstan/phpstan-src/blob/master/build/ignore-by-php-version.neon.php
This file is included in phpstan.neon: https://github.com/phpstan/phpstan-src/blob/b614f4af90b26e24d653b9d11a27679ee9b459ad/build/phpstan.neon#L10

@ondrejmirtes It worked 🎉  Ready for review.

While writing some tests, I notice that $this->reflectionProvider->hasClass($className) returns false, and therefore it skips my code. Isn't it possible to reflect unknown classes?

Looks like I'm gonna solve this in a general way for all the rules :) https://github.com/phpstan/phpstan-doctrine/pull/253


Videos in MLPs are not loading - reference error

PROVISIONING NOTE: If you are having issues with the SharePoint look book while trying to provision M365 learning pathways please do not post that issue to this repo as we cannot help you here. Please post all questions and issues for the SharePoint look book to SharePoint/sp-provisioning-service GitHub Issues List.

WEB PART NOT LOADING: If you are getting the error: "Microsoft 365 learning pathways has a configuration issue. Ask your administrator for assistance". Please review the Diagnosing Pre-Check guidance before submitting your bug.

Describe the bug
Any Video of the standard MLPs do not show up - any reference error
To Reproduce
Try to do MLP "Microsoft Teams" for example - first step is "Teams Quick Start" and "What is Microsoft Teams" there should show up a video which wont be presented
Expected behavior
The video should load and shouldbe playable
Screenshots
below you can take a look at the error which shows up instead of the video

Learning Pathways version number

Please share the version number of learning pathways in your tenant app catalog.
App is <IP_ADDRESS>

Additional context

Add any other context about the problem here.

@Take4aWalk  this is a duplicate of #767. Please keep an eye on that issue when the issue is resolved. Closing this one as a duplicate