Introduce tslint npm script task

Since tslint is a dev dependency, we might as well make use of it.
This PR introduces an npm script task names tslint.
Running it reveals a flood of rather trivial "typos".
I corrected most of them, they are included in this PR.
After applying this PR, the output of npm run tslint is 25 cases of camelcase/uppercase and one usage of evil eval (down from 147 cases):
(variable-name) addon/ng2/commands/doc.ts[4, 7]: variable name must be in camelcase or uppercase
(variable-name) addon/ng2/commands/generate.ts[9, 7]: variable name must be in camelcase or uppercase
(variable-name) addon/ng2/commands/get.ts[6, 7]: variable name must be in camelcase or uppercase
(variable-name) addon/ng2/commands/new.ts[8, 7]: variable name must be in camelcase or uppercase
(variable-name) addon/ng2/commands/new.ts[10, 7]: variable name must be in camelcase or uppercase
(variable-name) addon/ng2/commands/set.ts[6, 7]: variable name must be in camelcase or uppercase
(variable-name) addon/ng2/commands/version.ts[5, 7]: variable name must be in camelcase or uppercase
(variable-name) addon/ng2/models/config/config.ts[18, 11]: variable name must be in camelcase or uppercase
(variable-name) addon/ng2/models/config/config.ts[20, 31]: variable name must be in camelcase or uppercase
(no-eval) addon/ng2/models/find-lazy-modules.ts[49, 14]: forbidden eval
(variable-name) addon/ng2/models/json-schema/schema-tree.ts[32, 13]: variable name must be in camelcase or uppercase
(variable-name) addon/ng2/models/json-schema/schema-tree.ts[34, 13]: variable name must be in camelcase or uppercase
(variable-name) addon/ng2/models/json-schema/schema-tree.ts[35, 13]: variable name must be in camelcase or uppercase
(variable-name) addon/ng2/models/json-schema/schema-tree.ts[37, 13]: variable name must be in camelcase or uppercase
(variable-name) addon/ng2/models/json-schema/schema-tree.ts[38, 13]: variable name must be in camelcase or uppercase
(variable-name) addon/ng2/models/json-schema/schema-tree.ts[40, 13]: variable name must be in camelcase or uppercase
(variable-name) addon/ng2/models/json-schema/schema-tree.ts[41, 13]: variable name must be in camelcase or uppercase
(variable-name) addon/ng2/models/json-schema/schema-tree.ts[160, 13]: variable name must be in camelcase or uppercase
(variable-name) addon/ng2/models/json-schema/schema-tree.ts[221, 13]: variable name must be in camelcase or uppercase
(variable-name) addon/ng2/models/json-schema/schema-tree.ts[281, 11]: variable name must be in camelcase or uppercase
(variable-name) addon/ng2/models/json-schema/serializer.ts[27, 9]: variable name must be in camelcase or uppercase
(variable-name) addon/ng2/models/json-schema/serializer.ts[40, 11]: variable name must be in camelcase or uppercase
(variable-name) addon/ng2/models/json-schema/serializer.ts[42, 23]: variable name must be in camelcase or uppercase
(variable-name) addon/ng2/models/json-schema/serializer.ts[42, 50]: variable name must be in camelcase or uppercase
(variable-name) addon/ng2/tasks/build-webpack.ts[24, 11]: variable name must be in camelcase or uppercase
(variable-name) addon/ng2/tasks/doc.ts[4, 7]: variable name must be in camelcase or uppercase

We already fixed those and already added tslint.


[New_project] Added a quick word cloud project

Type of change

[x] Added new project
[ ] Bug fix
[ ] New features
[ ] Enhanced documentation

Changes proposed in this pull request

Project name :
QuickWordCloud

Short description :
Its small project that reads a text file and creates a word cloud for analysis.

Checklist

[x] The code is Python 3 compatible
[x] I have added relevant comments in my file to make code understandable
[x] I have added my project in a folder which includes all the necessary files

@Mrinank-Bhowmick could you please look into the PR and approve it.

Looks good thank


Can't monitor Tcp client connection

Having the following code (notice the explicit monitor being added):
open Core.Std
open Async.Std

let con host_and_port =
  let connect () =
    let host = Host_and_port.host host_and_port in
    let port = Host_and_port.port host_and_port in
    Tcp.connect (Tcp.to_host_and_port host port)
  in
  connect () >>= (fun _ ->
    Deferred.return ("done"))

let () =
  let monitored () =
    let monitor = Monitor.create ~name:"My simple monitor" () in
    within' ~monitor (fun () -> con (Host_and_port.create "localhost" 5555)) in
  ignore (monitored ());
  never_returns (Scheduler.go ~raise_unhandled_exn:true ())

When the connection fails, I'm getting the following error:
Uncaught exception:

  ("unhandled exception"
   ((src/monitor.ml.Error_
     ((exn (Unix.Unix_error "Connection refused" connect <IP_ADDRESS>:5555))
      (backtrace
       ("Raised by primitive operation at file \"src/unix_syscalls.ml\", line 863, characters 17-74"
        "Called from file \"src/deferred1.ml\", line 14, characters 63-68"
        "Called from file \"src/job_queue.ml\", line 160, characters 6-47"
        ""))
      (monitor
       (((name Tcp.close_sock_on_error) (here ()) (id 3)
         (has_seen_error true) (is_detached true))))))
    ((pid 3706) (thread_id 0))))

Raised at file "src/error.ml" (inlined), line 7, characters 14-30
Called from file "src/raw_scheduler.ml", line 756, characters 7-24
Called from file "test_tcp_mon.ml", line 18, characters 16-59

which from what I can tell, doesn't say anything about my monitor.
Is there something I'm doing wrong here?
Apologies if this is the wrong channel for addressing such questions, but I wasn't able to find a proper mailing list, or something similar to that.
Thanks.

Hmm. Your monitor is included in the path, but I suspect the name doesn't show up in the monitor trace because we slimmed them down at some point to make them easier to read. Here's how you can tell it's there:
open Core
open Async

let con host_and_port =
  let connect () =
    let host = Host_and_port.host host_and_port in
    let port = Host_and_port.port host_and_port in
    Tcp.connect (Tcp.to_host_and_port host port)
  in
  let%bind _writer = connect () in
  Deferred.return ("done")

let () =
  let monitored () =
    let monitor = Monitor.create ~name:"My simple monitor" () in
    Monitor.detach_and_iter_errors monitor ~f:(fun exn ->
        Debug.ams [%here] "Caught it!" exn Exn.sexp_of_t;
        raise exn
      );
    let%map string =
      Scheduler.within' ~monitor (fun () ->
          con (Host_and_port.create ~host:"localhost" ~port:5555))
    in
    printf "%s\n" string;
  in
  don't_wait_for (monitored ());
  never_returns (Scheduler.go ~raise_unhandled_exn:true ())

@sliquister, do you know if there's a way of seeing monitor names in exception traces now?

@yminsky I didn't remove the monitor names. Your monitor errors actually say "Caught by monitor Tcp.close_sock_on_error". But in any case, @alinpopa has teh ugly errors from before my changes.
I am not familiar with Monitor.within', but I suspect the problem is that Monitor.send_exn ignores the current execution context if the exception being sent is already a Monitor.Error_, for some reason. Ie I would expect the following:
Monitor.protect ~name:"a" ~finally:return (fun () ->
  Monitor.protect ~name:"b" ~finally:return) (fun () ->
    failwith "asd")

to show monitor "b" only.

(as a side note, it seems that jbuilder breaks the code that filters out useless stack frames, by adding these "src/" in the filenames. The stack traces should not show job_queue.ml and deferred1.ml)

Odd. I guess this is just an issue with how errors are reported, rather than something about the actual structure of the monitors?
CC @diml on the jbuilder issue, and in case he understands the somewhat odd error generation here.

Thanks for the feedback, guys; sort of helped me understanding what's going on; I was a bit confused as I thought I misunderstood all the monitors concept, and I was applying it wrong.

It's not a jbuilder issue, it's a feature. In general people want paths relative to the project root to show up in backtraces, otherwise it's hard to know what files backtraces are talking about. Technically it's not really good enough when compiling projects separately since paths might still clash but it's better than just using basenames.
My understanding is that this is what we want in our jenga rules as well, see ppx/unify-filename and the corresponding ticket. We sould probably update the async code to deal with this.

Based on the discussion and its age, I think this is safe to close.


local_vars_dump with recursive data structures causes infinite recursion

Unfortunately some of our parameters are recursive. Here is a super simplified example:
$obj = [
  'key1' => 'value',
  'key2' => 'value'
];

$obj['key3'] => &$obj;

This causes Utility::serialize($obj) to enter an infinite recursion. So if local_vars_dump is on, errors can cause infinite recursion.
I kind of think a simple fix is to implement a maximum depth for the serialize method. Maybe a configurable one, with a default of somewhere between 5 and 10? If that solution sounds ok, I'd be willing to put together a PR for it.

@jlesueur thanks for reporting this issue.
@ArturMoczulski what do you think about the proposal to set a maximum depth for the serialize() method?  I imagine we'd want to have it be a configurable setting...

We also need the serialization code to detect loops. See the other sdks for a reference implementation.

@jessewgibbs yeah I think that's good
@jlesueur if you want to prepare a PR that would be awesome
@coryvirok I'll check out other SDKs, although I believe introducing default max depth should solve the problem

It might solve it in terms of the specific bug but the serialization will
be incorrect due to loops. Also, it will have another effect for nested
objects of increasing the payload size.
On Fri, Sep 28, 2018, 12:33 PM Artur Moczulski<EMAIL_ADDRESS>wrote:

@jessewgibbs https://github.com/jessewgibbs yeah I think that's good
@jlesueur https://github.com/jlesueur if you want to prepare a PR that
would be awesome
@coryvirok https://github.com/coryvirok I'll check out other SDKs,
although I believe introducing default max depth should solve the problem
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/rollbar/rollbar-php/issues/410#issuecomment-425493044,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAu9K_PxKDgcFV6-ZcAd2mZ4L7D-3kAvks5ufk9ZgaJpZM4W7iqC
.

Issue has been resolved with PR #414


ugly message when cancelling input

[ /home/tim ] $ shexter send
You must specify a Contact Name for Send and Read and SetPref commands. Enter one now:
Enter a new contact name (CTRL + C to give up): ^C
Traceback (most recent call last):
File "/opt/shexter/shexter.py", line 416, in
main(sys.argv[1:])
File "/opt/shexter/shexter.py", line 402, in main
command, request = build_request(args)
TypeError: 'NoneType' object is not iterable
[ /home/tim ] $

trivial to fix this by catching and passing the exception


Implement malware check backfill functionality

This issue is part of the work defined by 2019-Q4-PyPI Milestone 2.
Implement the functionality to backfill data for a malware check. This functionality should include the ability to:

Run a check on the entire corpus of PyPI data
Run a check on a sampled subset of files to evaluate the efficacy of a check

What was settled upon was punting on the full backfill functionality for now, and instead running an evaluation on a fixed subset of each object type for hooked checks. Currently, the subset is limited to 10k elements: https://github.com/pypa/warehouse/blob/master/warehouse/admin/views/checks.py#L20


Limit the alias name to N-characters

I suggest to add a new option in "Settings": Limit the alias name to N-characters (generate not more than N first characters).
If user set N = 3, the result alias will be limited with the first 3 symbols after pressing Tab with option to generate AS alias automatically.
Steps:

execute code:
create table "ProdAttrParamValueInfoDescrAddrPtr" (column1 int);

refresh tables so that auto-complete will see a newly created table (F5 in Database navigator)

start typing: SELECT * from proda

in a list of suggestions, choose the brand new table

Expected:
SELECT * FROM "ProdAttrParamValueInfoDescrAddrPtr" AS pap;
Actual:
SELECT * FROM "ProdAttrParamValueInfoDescrAddrPtr" AS papvidap;
Why?
Usually, aliases are easier to use when they are short.
I don't think many users need 8-character alias.
Most of users will have to rename it manually.
I suggest to do it automatically keeping user's time.
It is ok that the name of the generatd alias could be the same as another alias in the query.
It is expected that user will see it and fix it.

Thank you for idea


bit_select and word_select behave differently

The commented-out word_select shoud behave the same as the bit_select but the bit_select throws a "IndexError: Cannot stop slice 9 bits into 8-bit value" while the word_select compiles just fine.
class Test(Elaboratable):
    def elaborate(self, platform):
        m = Module()
        datain = Signal(4)
        dataout = Signal(8)
        assert len(dataout) % len(datain) == 0
        counter = Signal()
        #m.d.sync += dataout.word_select(counter, 4).eq(datain)
        m.d.sync += dataout.bit_select(counter * 4, 4).eq(datain)
        return m

FPGA.ECP55GEVNPlatform().build(Test())

Interestingly the codegen for word_select appears to be broken too.


Comprehensive statistics integration in txsim

For the purpose of testing, it would be advantageous to gather a more comprehensive set of statistics related to the transactions generated within txsim. This task involves tracking this supplementary data and implementing the requisite enhancements to seamlessly integrate them into the txsim system.
The following data points are envisioned so far:

tx hashes
tx rate
tx sizes

mind elaborating on the data we need here? Do you think it would be possible to get that data by tracking at the mempool or even after the blocks have been committed?

The analysis of transaction rates derived from the committed block provides insights into network transaction throughput, while monitoring the transaction rate within the txsim allows us to ascertain the generated transaction rate (hence they serve two different purposes). These two metrics then shall be compared to assess the overall health of the network and to pinpoint potential bottlenecks and issues.
There are several other advantages to collecting metrics on the txsim side:

Enhanced Observability: Given that the txsim operates as a standalone component, it proves beneficial to gain observability into its operational state independently from other network entities.

Communication Reliability: Recognizing that communication between the txsim and the receiving node is susceptible to failures and instability, monitoring metrics on the txsim enables us to more effectively troubleshoot and debug communication issues between the txsim and the receiving validator. This includes the detection of message loss and the identification of problems with the receiving endpoint.

Precise Testing: In testing scenarios, metrics collection in the txsim allows for the accurate identification of the test initiation time or other essential metadata, such as the starting block height of the test.

Sustainability: Although some current metrics may be extractable from the receiving endpoint, it's important to note that future metrics requirements may not be adequately met by the receiving endpoint alone. Integrating metrics into the txsim represents a more sustainable and easily extensible approach.

Efficiency in Multiple Instances: In a testing environment where multiple instances of txsim are employed, each targeting different nodes, obtaining the produced transaction rate becomes a more streamlined process when metrics collection is incorporated into the txsim. This eliminates the need to manage and track all the receiving validators individually. Additionally, as previously mentioned, it ensures the timely identification of potential bugs in the validators endpoints.


Does not work in IE8

I am using Spin.js 1.3.2 and it seems the VML fallback does not work for IE8. My code for dynamically adding a spinner inside a jQuery dialog:
(function ($) {
    $(function() {
        var $loadingDialog = $("#loading-dialog").dialog(settings.loadingDialogSettings),
            spinner = new Spinner({
                top: "10px",
                left: "10px"
            });

        $.ajaxSetup({
            cache: false
        });

        $(document).ajaxStart(function() {
            spinner.spin($loadingDialog[0]);
            $loadingDialog.dialog("open");
        }).ajaxStop(function() {
            spinner.stop();
            $loadingDialog.dialog("close");
        });
    });
}(jQuery));

From the debugging window, I can see the initVML() function being called. However nothing is created inside the jQuery dialog (content <div> has no children).
On other browsers, the spinner is rendered perfectly without problems.

Closing since IE 8 is no longer supported anyway.


Change picOrderCnt to 2

changes the picOrderCnt field to 2 (which means the output order
is the same as the decode order) which is more suited to realtime
usage and allows the decoder to immediately decode a frame without
waiting for out-of-order frames. This reduces the decoding latency
on Qualcomm hardware decoders which do not honor the VUI parameter
max_num_reorder_frames

Looks like the ASAN test is running some tests that are not run by the normal test suite, see the commit titled "bump asan hashes"? And fixing the hashes for ASAN breaks them for the normal tests locally (on Linux)?! Reverting and make clean fixed this so this seems to be a minor issue with the test build deps; as long as the CI catches it all is well.

@fippo Could you pls submit a new PR and I will start CI.

@BenzhengZhang now that I have had a change merged github considers me to be a friendly person so starts the CI automatically! Builds passed :tada:, would you like me to squash all the hash updates?


Ignore gcc-10 warning

This warning trigger build errors, those pragma are a bit ugly but they prevent the build error.
In file included from /home/benjamin.sergeant/src/ALHttp-Cpp/build/_deps/cxxopts-src/src/example.cpp:27:
/home/benjamin.sergeant/src/ALHttp-Cpp/build/_deps/cxxopts-src/include/cxxopts.hpp: In member function ‘size_t cxxopts::ParseResult::count(const string&) const’:
/home/benjamin.sergeant/src/ALHttp-Cpp/build/_deps/cxxopts-src/include/cxxopts.hpp:1027:14: error: potential null pointer dereference [-Werror=null-dereference]
 1027 |       return m_count;
      |              ^~~~~~~

This should fix https://github.com/jarro2783/cxxopts/issues/263

This change is

This looks like a bug. If this is a null pointer dereference, then so is any member function.
I'm happy with the fix for now, but I will revisit if it is fixed.
Do you have a bug reference for GCC?

This looks like a bug. If this is a null pointer dereference, then so is any member function.
I'm happy with the fix for now, but I will revisit if it is fixed.
Do you have a bug reference for GCC?

@bsergean which version of GCC was this for. It looks like for later versions of GCC this warning doesn't even exist.

@bsergean which version of GCC was this for. It looks like for later versions of GCC this warning doesn't even exist.

$ gcc --version
gcc (Ubuntu 10.1.0-2ubuntu1~18.04) 10.1.0
Copyright (C) 2020 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.  There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

On Jan 22, 2021, at 6:53 PM, jarro2783<EMAIL_ADDRESS>wrote:
@bsergean https://github.com/bsergean which version of GCC was this for? It looks like for later versions of GCC this warning doesn't even exist.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub https://github.com/jarro2783/cxxopts/pull/273#issuecomment-765834043, or unsubscribe https://github.com/notifications/unsubscribe-auth/AC2O6UL763M2TGSRVPG6P6LS3I22ZANCNFSM4VZZ4GMA.

$ gcc --version
gcc (Ubuntu 10.1.0-2ubuntu1~18.04) 10.1.0
Copyright (C) 2020 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.  There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

On Jan 22, 2021, at 6:53 PM, jarro2783<EMAIL_ADDRESS>wrote:
@bsergean https://github.com/bsergean which version of GCC was this for? It looks like for later versions of GCC this warning doesn't even exist.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub https://github.com/jarro2783/cxxopts/pull/273#issuecomment-765834043, or unsubscribe https://github.com/notifications/unsubscribe-auth/AC2O6UL763M2TGSRVPG6P6LS3I22ZANCNFSM4VZZ4GMA.

I have this 10.2.0 and it fails with the same error as #276, so I'll have to try disable it globally.

I have this 10.2.0 and it fails with the same error as #276, so I'll have to try disable it globally.

I don't see the error on the cxxopts build, do you have a specific flag turned on that produces this?

I don't see the error on the cxxopts build, do you have a specific flag turned on that produces this?

I think we see this when we make a release build

On Jan 22, 2021, at 7:01 PM, jarro2783<EMAIL_ADDRESS>wrote:
I have this 10.2.0 and it fails with the same error as #276 https://github.com/jarro2783/cxxopts/issues/276, so I'll have to try disable it globally.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub https://github.com/jarro2783/cxxopts/pull/273#issuecomment-765838915, or unsubscribe https://github.com/notifications/unsubscribe-auth/AC2O6ULCAFXOCHKKIIYLFALS3I32HANCNFSM4VZZ4GMA.

I think we see this when we make a release build

On Jan 22, 2021, at 7:01 PM, jarro2783<EMAIL_ADDRESS>wrote:
I have this 10.2.0 and it fails with the same error as #276 https://github.com/jarro2783/cxxopts/issues/276, so I'll have to try disable it globally.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub https://github.com/jarro2783/cxxopts/pull/273#issuecomment-765838915, or unsubscribe https://github.com/notifications/unsubscribe-auth/AC2O6ULCAFXOCHKKIIYLFALS3I32HANCNFSM4VZZ4GMA.

Maybe we can add another check around it for the compiler version.

Maybe we can add another check around it for the compiler version.

https://gcc.gnu.org/onlinedocs/cpp/Common-Predefined-Macros.html

On Jan 22, 2021, at 7:06 PM, jarro2783<EMAIL_ADDRESS>wrote:
Maybe we can add another check around it for the compiler version.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub https://github.com/jarro2783/cxxopts/pull/273#issuecomment-765840373, or unsubscribe https://github.com/notifications/unsubscribe-auth/AC2O6UK342EVFRBNQ7XIO33S3I4LXANCNFSM4VZZ4GMA.

https://gcc.gnu.org/onlinedocs/cpp/Common-Predefined-Macros.html

On Jan 22, 2021, at 7:06 PM, jarro2783<EMAIL_ADDRESS>wrote:
Maybe we can add another check around it for the compiler version.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub https://github.com/jarro2783/cxxopts/pull/273#issuecomment-765840373, or unsubscribe https://github.com/notifications/unsubscribe-auth/AC2O6UK342EVFRBNQ7XIO33S3I4LXANCNFSM4VZZ4GMA.

btw the #pragma will disappear link appears to be a '-fpermissive' option will disappear which is different.

On Jan 22, 2021, at 7:06 PM, jarro2783<EMAIL_ADDRESS>wrote:
Maybe we can add another check around it for the compiler version.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub https://github.com/jarro2783/cxxopts/pull/273#issuecomment-765840373, or unsubscribe https://github.com/notifications/unsubscribe-auth/AC2O6UK342EVFRBNQ7XIO33S3I4LXANCNFSM4VZZ4GMA.

btw the #pragma will disappear link appears to be a '-fpermissive' option will disappear which is different.

On Jan 22, 2021, at 7:06 PM, jarro2783<EMAIL_ADDRESS>wrote:
Maybe we can add another check around it for the compiler version.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub https://github.com/jarro2783/cxxopts/pull/273#issuecomment-765840373, or unsubscribe https://github.com/notifications/unsubscribe-auth/AC2O6UK342EVFRBNQ7XIO33S3I4LXANCNFSM4VZZ4GMA.


allow to render named parameters

I love how small of a change it actually was in Mojo.pm :) Lovely, thank you!


Unable to pushtx over Tor

Seems like Bitindex3 may not be working. bchsvexplorer.com has Cloudflare and isn't configured to not block Tor.

Bitindex3 Testnet is buggy, our tests are failing. I contacted them.
Don't know who runs bchsvexplorer.com, but I emailed the technical contact on the whois through Godaddy.

Bitindex3 pushtx seemed to just come back. I didn't get any logs from it but maybe they addressed it already.

Is this settled now with our main API back online?

Yes, it is
On Sun., Nov. 24, 2019, 4:54 p.m. AustEcon [SV]<EMAIL_ADDRESS>wrote:

Is this settled now with our main API back online?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/AustEcon/bitsv/issues/57?email_source=notifications&email_token=AAG6TRR65DHOUT3QMYLQRM3QVJFNLA5CNFSM4JQYCHL2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEFAHSTI#issuecomment-557873485,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAG6TRQQVNURSDSF4QM7TM3QVJFNLANCNFSM4JQYCHLQ
.

Thank you!


Skip telemetry testing when the agent never mentions it.

This should only happen when the agent is too old to support telemetry.
/cc @elicriffield @drewhli

/lgtm


⚠ Bofrost.at has degraded performance

In 6ffb0c0, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 975 ms

Resolved: Bofrost.at performance has improved in d876ac4 after 6 minutes.


Multiple Kibana deployment support

Hi, we're thinking to create two kibana instances within one cluster. I was trying to have two kibana sections in resource "ec_deployment" but it says only one is allowed. is multiple kibana instances supported by ec provider?

increase zone_count in kibana.topology
kibana {
topology {
zone_count: 2
}
}

Hi @milesqi, we do not support multiple Kibana instances with different endpoints on Elastic Cloud or the Terraform provider.


Enabled translated routes and a new helper function

Fixes #
Proposed Changes

Added possibility to translate routes (en: home, fr: domicile)
Added new helper to get localized routes

Havent updated tests as it all depends on translations.

Hi @elkebirmed,
I made another Pull Request for your package to enable localisation of routes.
When you have the time, could you please look at it?
Have a nice sunday.


[OnoneSimplification] Fixed isDestroyed(after:)

The previous implementation just checked that a value's only uses besides the begin_borrow were destroys.  That's insufficient to say the value is destroyed after the borrow (i.e. that all its destroys are dominated by the borrow).  Add the relevant dominance check.
It would be better not to compute the dominance tree here, but that compile-time issue can be fixed separately.
rdar://119873930

@swift-ci please test

@swift-ci please build toolchain

Here is another PR which fixes the problem: https://github.com/apple/swift/pull/70559


[Snyk] Security upgrade puppeteer from 10.2.0 to 22.6.4

This PR was automatically created by Snyk using the credentials of a real user.![snyk-top-banner](https://github.com/andygongea/OWASP-Benchmark/assets/818805/c518c423-16fe-447e-b67f-ad5a49b5d123)
Snyk has created this PR to fix 1 vulnerabilities in the npm dependencies of this project.
Snyk changed the following file(s):

packages/node/base/package.json
packages/node/base/package-lock.json

Vulnerabilities that will be fixed with an upgrade:

Issue
Score

Denial of Service (DoS) SNYK-JS-WS-7266574
  170

[!IMPORTANT]

Check the changes in this PR to ensure they won't cause issues with your project.
Max score is 1000. Note that the real score may have changed since the PR was raised.
This PR was automatically created by Snyk using the credentials of a real user.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.
For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic

Learn how to fix vulnerabilities with free interactive lessons:
🦉 Denial of Service (DoS)

Checkmarx One – Scan Summary & Details – dd707595-2dfa-4e0d-ada8-891cc5ba34da
New Issues

Severity
Issue
Source File / Package
Checkmarx Insight

Aurora With Disabled at Rest Encryption
/rds.tf: [1](https://github.com/ACN-APPSAS/terragoat/blob/snyk-fix-1115b76628621bc00226f431f83871c0//terraform/aws/rds.tf# L1)
Amazon Aurora does not have encryption for data at rest enabled. To prevent such a scenario, update the attribute 'StorageEncrypted' to 'true'.

Aurora With Disabled at Rest Encryption
/rds.tf: [81](https://github.com/ACN-APPSAS/terragoat/blob/snyk-fix-1115b76628621bc00226f431f83871c0//terraform/aws/rds.tf# L81)
Amazon Aurora does not have encryption for data at rest enabled. To prevent such a scenario, update the attribute 'StorageEncrypted' to 'true'.

Aurora With Disabled at Rest Encryption
/rds.tf: [17](https://github.com/ACN-APPSAS/terragoat/blob/snyk-fix-1115b76628621bc00226f431f83871c0//terraform/aws/rds.tf# L17)
Amazon Aurora does not have encryption for data at rest enabled. To prevent such a scenario, update the attribute 'StorageEncrypted' to 'true'.

Aurora With Disabled at Rest Encryption
/rds.tf: [113](https://github.com/ACN-APPSAS/terragoat/blob/snyk-fix-1115b76628621bc00226f431f83871c0//terraform/aws/rds.tf# L113)
Amazon Aurora does not have encryption for data at rest enabled. To prevent such a scenario, update the attribute 'StorageEncrypted' to 'true'.

Aurora With Disabled at Rest Encryption
/rds.tf: [130](https://github.com/ACN-APPSAS/terragoat/blob/snyk-fix-1115b76628621bc00226f431f83871c0//terraform/aws/rds.tf# L130)
Amazon Aurora does not have encryption for data at rest enabled. To prevent such a scenario, update the attribute 'StorageEncrypted' to 'true'.

Aurora With Disabled at Rest Encryption
/rds.tf: [49](https://github.com/ACN-APPSAS/terragoat/blob/snyk-fix-1115b76628621bc00226f431f83871c0//terraform/aws/rds.tf# L49)
Amazon Aurora does not have encryption for data at rest enabled. To prevent such a scenario, update the attribute 'StorageEncrypted' to 'true'.

Aurora With Disabled at Rest Encryption
/rds.tf: [65](https://github.com/ACN-APPSAS/terragoat/blob/snyk-fix-1115b76628621bc00226f431f83871c0//terraform/aws/rds.tf# L65)
Amazon Aurora does not have encryption for data at rest enabled. To prevent such a scenario, update the attribute 'StorageEncrypted' to 'true'.

Aurora With Disabled at Rest Encryption
/rds.tf: [97](https://github.com/ACN-APPSAS/terragoat/blob/snyk-fix-1115b76628621bc00226f431f83871c0//terraform/aws/rds.tf# L97)
Amazon Aurora does not have encryption for data at rest enabled. To prevent such a scenario, update the attribute 'StorageEncrypted' to 'true'.

Aurora With Disabled at Rest Encryption
/rds.tf: [33](https://github.com/ACN-APPSAS/terragoat/blob/snyk-fix-1115b76628621bc00226f431f83871c0//terraform/aws/rds.tf# L33)
Amazon Aurora does not have encryption for data at rest enabled. To prevent such a scenario, update the attribute 'StorageEncrypted' to 'true'.

CVE-2023-42282
Npm-ip-1.1.5
Vulnerable Package

CVE-2023-45133
<EMAIL_ADDRESS>Vulnerable Package

CVE-2023-45133
<EMAIL_ADDRESS>Vulnerable Package

CVE-2024-27088
Npm-es5-ext-0.10.53
Vulnerable Package

CVE-2024-27351
Python-Django-1.2
Vulnerable Package

CVE-2024-29180
Npm-webpack-dev-middleware-5.2.1
Vulnerable Package

CVE-2024-4068
Npm-braces-2.3.2
Vulnerable Package

CVE-2024-4068
Npm-braces-3.0.2
Vulnerable Package

Cx37f28a21-b2a7
Npm-angular-1.8-1.8.2
Vulnerable Package

Cx94a5c81d-63b1
Npm-angular-1.8-1.8.2
Vulnerable Package

Cx9eb96c9b-eb45
Npm-angular-mocks-1.8-1.8.2
Vulnerable Package

Cxcf770dcb-fd21
Npm-angular-1.8-1.8.2
Vulnerable Package

Passwords And Secrets - Generic Access Key
/lambda.tf: [45](https://github.com/ACN-APPSAS/terragoat/blob/snyk-fix-1115b76628621bc00226f431f83871c0//terraform/aws/lambda.tf# L45)
Query to find passwords and secrets in infrastructure code.

Passwords And Secrets - Generic Access Key
/providers.tf: [10](https://github.com/ACN-APPSAS/terragoat/blob/snyk-fix-1115b76628621bc00226f431f83871c0//terraform/aws/providers.tf# L10)
Query to find passwords and secrets in infrastructure code.

Passwords And Secrets - Generic Password
/instance.tf: [45](https://github.com/ACN-APPSAS/terragoat/blob/snyk-fix-1115b76628621bc00226f431f83871c0//terraform/azure/instance.tf# L45)
Query to find passwords and secrets in infrastructure code.

Passwords And Secrets - Generic Password
/sql.tf: [50](https://github.com/ACN-APPSAS/terragoat/blob/snyk-fix-1115b76628621bc00226f431f83871c0//terraform/azure/sql.tf# L50)
Query to find passwords and secrets in infrastructure code.

Passwords And Secrets - Generic Password
/instance.tf: [11](https://github.com/ACN-APPSAS/terragoat/blob/snyk-fix-1115b76628621bc00226f431f83871c0//terraform/azure/instance.tf# L11)
Query to find passwords and secrets in infrastructure code.

Sensitive Port Is Exposed To Entire Network
/ec2.tf: [83](https://github.com/ACN-APPSAS/terragoat/blob/snyk-fix-1115b76628621bc00226f431f83871c0//terraform/aws/ec2.tf# L83)
A sensitive port, such as port 23 or port 110, is open for the whole network in either TCP or UDP protocol

Sensitive Port Is Exposed To Entire Network
/ec2.tf: [83](https://github.com/ACN-APPSAS/terragoat/blob/snyk-fix-1115b76628621bc00226f431f83871c0//terraform/aws/ec2.tf# L83)
A sensitive port, such as port 23 or port 110, is open for the whole network in either TCP or UDP protocol

CVE-2023-26159
Npm-follow-redirects-1.14.6
Vulnerable Package

CVE-2023-44270
Npm-postcss-7.0.39
Vulnerable Package

CVE-2023-44270
Npm-postcss-8.3.11
Vulnerable Package

CVE-2024-25710
Maven-org.apache.commons:commons-compress-1.15
Vulnerable Package

CVE-2024-25710
Maven-org.apache.commons:commons-compress-1.20
Vulnerable Package

CVE-2024-28849
Npm-follow-redirects-1.14.6
Vulnerable Package

CVE-2024-28863
Npm-tar-4.4.19
Vulnerable Package

CVE-2024-28863
Npm-tar-6.1.11
Vulnerable Package

CVE-2024-29041
Npm-express-4.17.1
Vulnerable Package

CVE-2024-4067
Npm-micromatch-3.1.10
Vulnerable Package

CVE-2024-4067
Npm-micromatch-4.0.4
Vulnerable Package

Unpinned Actions Full Length Commit SHA
/build.yaml: [15](https://github.com/ACN-APPSAS/terragoat/blob/snyk-fix-1115b76628621bc00226f431f83871c0//.github/workflows/build.yaml# L15)
Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...

Unpinned Actions Full Length Commit SHA
/semgrep.yml: [14](https://github.com/ACN-APPSAS/terragoat/blob/snyk-fix-1115b76628621bc00226f431f83871c0//.github/workflows/semgrep.yml# L14)
Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...

Unpinned Actions Full Length Commit SHA
/pull_request.yaml: [14](https://github.com/ACN-APPSAS/terragoat/blob/snyk-fix-1115b76628621bc00226f431f83871c0//.github/workflows/pull_request.yaml# L14)
Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...

IAM Access Analyzer Not Enabled
/random.tf: [1](https://github.com/ACN-APPSAS/terragoat/blob/snyk-fix-1115b76628621bc00226f431f83871c0//terraform/azure/random.tf# L1)
IAM Access Analyzer should be enabled and configured to continuously monitor resource permissions

IAM Access Analyzer Not Enabled
/instances.tf: [3](https://github.com/ACN-APPSAS/terragoat/blob/snyk-fix-1115b76628621bc00226f431f83871c0//terraform/gcp/instances.tf# L3)
IAM Access Analyzer should be enabled and configured to continuously monitor resource permissions

IAM Access Analyzer Not Enabled
/storage.tf: [1](https://github.com/ACN-APPSAS/terragoat/blob/snyk-fix-1115b76628621bc00226f431f83871c0//terraform/azure/storage.tf# L1)
IAM Access Analyzer should be enabled and configured to continuously monitor resource permissions

IAM Access Analyzer Not Enabled
/neptune.tf: [1](https://github.com/ACN-APPSAS/terragoat/blob/snyk-fix-1115b76628621bc00226f431f83871c0//terraform/aws/neptune.tf# L1)
IAM Access Analyzer should be enabled and configured to continuously monitor resource permissions

IAM Access Analyzer Not Enabled
/gke.tf: [6](https://github.com/ACN-APPSAS/terragoat/blob/snyk-fix-1115b76628621bc00226f431f83871c0//terraform/gcp/gke.tf# L6)
IAM Access Analyzer should be enabled and configured to continuously monitor resource permissions

IAM Access Analyzer Not Enabled
/policies.tf: [1](https://github.com/ACN-APPSAS/terragoat/blob/snyk-fix-1115b76628621bc00226f431f83871c0//terraform/azure/policies.tf# L1)
IAM Access Analyzer should be enabled and configured to continuously monitor resource permissions

IAM Access Analyzer Not Enabled
/iam.tf: [1](https://github.com/ACN-APPSAS/terragoat/blob/snyk-fix-1115b76628621bc00226f431f83871c0//terraform/aws/iam.tf# L1)
IAM Access Analyzer should be enabled and configured to continuously monitor resource permissions

IAM Access Analyzer Not Enabled
/sql.tf: [1](https://github.com/ACN-APPSAS/terragoat/blob/snyk-fix-1115b76628621bc00226f431f83871c0//terraform/azure/sql.tf# L1)
IAM Access Analyzer should be enabled and configured to continuously monitor resource permissions

IAM Access Analyzer Not Enabled
/db-app.tf: [1](https://github.com/ACN-APPSAS/terragoat/blob/snyk-fix-1115b76628621bc00226f431f83871c0//terraform/aws/db-app.tf# L1)
IAM Access Analyzer should be enabled and configured to continuously monitor resource permissions

IAM Access Analyzer Not Enabled
/eks.tf: [19](https://github.com/ACN-APPSAS/terragoat/blob/snyk-fix-1115b76628621bc00226f431f83871c0//terraform/aws/eks.tf# L19)
IAM Access Analyzer should be enabled and configured to continuously monitor resource permissions

IAM Access Analyzer Not Enabled
/compartment.tf: [1](https://github.com/ACN-APPSAS/terragoat/blob/snyk-fix-1115b76628621bc00226f431f83871c0//terraform/oracle/compartment.tf# L1)
IAM Access Analyzer should be enabled and configured to continuously monitor resource permissions

IAM Access Analyzer Not Enabled
/s3.tf: [1](https://github.com/ACN-APPSAS/terragoat/blob/snyk-fix-1115b76628621bc00226f431f83871c0//terraform/aws/s3.tf# L1)
IAM Access Analyzer should be enabled and configured to continuously monitor resource permissions

IAM Access Analyzer Not Enabled
/resource_group.tf: [1](https://github.com/ACN-APPSAS/terragoat/blob/snyk-fix-1115b76628621bc00226f431f83871c0//terraform/azure/resource_group.tf# L1)
IAM Access Analyzer should be enabled and configured to continuously monitor resource permissions

IAM Access Analyzer Not Enabled
/networking.tf: [1](https://github.com/ACN-APPSAS/terragoat/blob/snyk-fix-1115b76628621bc00226f431f83871c0//terraform/azure/networking.tf# L1)
IAM Access Analyzer should be enabled and configured to continuously monitor resource permissions

IAM Access Analyzer Not Enabled
/logging.tf: [1](https://github.com/ACN-APPSAS/terragoat/blob/snyk-fix-1115b76628621bc00226f431f83871c0//terraform/azure/logging.tf# L1)
IAM Access Analyzer should be enabled and configured to continuously monitor resource permissions

IAM Access Analyzer Not Enabled
/application_gateway.tf: [1](https://github.com/ACN-APPSAS/terragoat/blob/snyk-fix-1115b76628621bc00226f431f83871c0//terraform/azure/application_gateway.tf# L1)
IAM Access Analyzer should be enabled and configured to continuously monitor resource permissions

IAM Access Analyzer Not Enabled
/trail.tf: [1](https://github.com/ACN-APPSAS/terragoat/blob/snyk-fix-1115b76628621bc00226f431f83871c0//terraform/alicloud/trail.tf# L1)
IAM Access Analyzer should be enabled and configured to continuously monitor resource permissions

IAM Access Analyzer Not Enabled
/rds.tf: [1](https://github.com/ACN-APPSAS/terragoat/blob/snyk-fix-1115b76628621bc00226f431f83871c0//terraform/alicloud/rds.tf# L1)
IAM Access Analyzer should be enabled and configured to continuously monitor resource permissions

IAM Access Analyzer Not Enabled
/ec2.tf: [1](https://github.com/ACN-APPSAS/terragoat/blob/snyk-fix-1115b76628621bc00226f431f83871c0//terraform/aws/ec2.tf# L1)
IAM Access Analyzer should be enabled and configured to continuously monitor resource permissions

IAM Access Analyzer Not Enabled
/ecr.tf: [1](https://github.com/ACN-APPSAS/terragoat/blob/snyk-fix-1115b76628621bc00226f431f83871c0//terraform/aws/ecr.tf# L1)
IAM Access Analyzer should be enabled and configured to continuously monitor resource permissions

IAM Access Analyzer Not Enabled
/key_vault.tf: [1](https://github.com/ACN-APPSAS/terragoat/blob/snyk-fix-1115b76628621bc00226f431f83871c0//terraform/azure/key_vault.tf# L1)
IAM Access Analyzer should be enabled and configured to continuously monitor resource permissions

IAM Access Analyzer Not Enabled
/roles.tf: [3](https://github.com/ACN-APPSAS/terragoat/blob/snyk-fix-1115b76628621bc00226f431f83871c0//terraform/azure/roles.tf# L3)
IAM Access Analyzer should be enabled and configured to continuously monitor resource permissions

IAM Access Analyzer Not Enabled
/bucket.tf: [1](https://github.com/ACN-APPSAS/terragoat/blob/snyk-fix-1115b76628621bc00226f431f83871c0//terraform/oracle/bucket.tf# L1)
IAM Access Analyzer should be enabled and configured to continuously monitor resource permissions

IAM Access Analyzer Not Enabled
/app_service.tf: [1](https://github.com/ACN-APPSAS/terragoat/blob/snyk-fix-1115b76628621bc00226f431f83871c0//terraform/azure/app_service.tf# L1)
IAM Access Analyzer should be enabled and configured to continuously monitor resource permissions

IAM Access Analyzer Not Enabled
/rds.tf: [1](https://github.com/ACN-APPSAS/terragoat/blob/snyk-fix-1115b76628621bc00226f431f83871c0//terraform/aws/rds.tf# L1)
IAM Access Analyzer should be enabled and configured to continuously monitor resource permissions

IAM Access Analyzer Not Enabled
/elb.tf: [2](https://github.com/ACN-APPSAS/terragoat/blob/snyk-fix-1115b76628621bc00226f431f83871c0//terraform/aws/elb.tf# L2)
IAM Access Analyzer should be enabled and configured to continuously monitor resource permissions

IAM Access Analyzer Not Enabled
/es.tf: [1](https://github.com/ACN-APPSAS/terragoat/blob/snyk-fix-1115b76628621bc00226f431f83871c0//terraform/aws/es.tf# L1)
IAM Access Analyzer should be enabled and configured to continuously monitor resource permissions

IAM Access Analyzer Not Enabled
/gcs.tf: [1](https://github.com/ACN-APPSAS/terragoat/blob/snyk-fix-1115b76628621bc00226f431f83871c0//terraform/gcp/gcs.tf# L1)
IAM Access Analyzer should be enabled and configured to continuously monitor resource permissions

IAM Access Analyzer Not Enabled
/kms.tf: [1](https://github.com/ACN-APPSAS/terragoat/blob/snyk-fix-1115b76628621bc00226f431f83871c0//terraform/aws/kms.tf# L1)
IAM Access Analyzer should be enabled and configured to continuously monitor resource permissions

IAM Access Analyzer Not Enabled
/mssql.tf: [1](https://github.com/ACN-APPSAS/terragoat/blob/snyk-fix-1115b76628621bc00226f431f83871c0//terraform/azure/mssql.tf# L1)
IAM Access Analyzer should be enabled and configured to continuously monitor resource permissions

IAM Access Analyzer Not Enabled
/aks.tf: [1](https://github.com/ACN-APPSAS/terragoat/blob/snyk-fix-1115b76628621bc00226f431f83871c0//terraform/azure/aks.tf# L1)
IAM Access Analyzer should be enabled and configured to continuously monitor resource permissions

IAM Access Analyzer Not Enabled
/big_data.tf: [1](https://github.com/ACN-APPSAS/terragoat/blob/snyk-fix-1115b76628621bc00226f431f83871c0//terraform/gcp/big_data.tf# L1)
IAM Access Analyzer should be enabled and configured to continuously monitor resource permissions

IAM Access Analyzer Not Enabled
/instance.tf: [1](https://github.com/ACN-APPSAS/terragoat/blob/snyk-fix-1115b76628621bc00226f431f83871c0//terraform/azure/instance.tf# L1)
IAM Access Analyzer should be enabled and configured to continuously monitor resource permissions

IAM Access Analyzer Not Enabled
/security_center.tf: [1](https://github.com/ACN-APPSAS/terragoat/blob/snyk-fix-1115b76628621bc00226f431f83871c0//terraform/azure/security_center.tf# L1)
IAM Access Analyzer should be enabled and configured to continuously monitor resource permissions

IAM Access Analyzer Not Enabled
/lambda.tf: [1](https://github.com/ACN-APPSAS/terragoat/blob/snyk-fix-1115b76628621bc00226f431f83871c0//terraform/aws/lambda.tf# L1)
IAM Access Analyzer should be enabled and configured to continuously monitor resource permissions

IAM Access Analyzer Not Enabled
/networks.tf: [1](https://github.com/ACN-APPSAS/terragoat/blob/snyk-fix-1115b76628621bc00226f431f83871c0//terraform/gcp/networks.tf# L1)
IAM Access Analyzer should be enabled and configured to continuously monitor resource permissions

Fixed Issues

Severity
Issue
Source File / Package

Cx6b921f00-d395
Npm-vm2-3.9.5

S3 Bucket SSE Disabled
/ec2.tf: [271](https://github.com/ACN-APPSAS/terragoat/blob/snyk-fix-1115b76628621bc00226f431f83871c0//terraform/aws/ec2.tf# L271)

S3 Bucket SSE Disabled
/s3.tf: [65](https://github.com/ACN-APPSAS/terragoat/blob/snyk-fix-1115b76628621bc00226f431f83871c0//terraform/aws/s3.tf# L65)

S3 Bucket SSE Disabled
/s3.tf: [89](https://github.com/ACN-APPSAS/terragoat/blob/snyk-fix-1115b76628621bc00226f431f83871c0//terraform/aws/s3.tf# L89)

S3 Bucket SSE Disabled
/s3.tf: [42](https://github.com/ACN-APPSAS/terragoat/blob/snyk-fix-1115b76628621bc00226f431f83871c0//terraform/aws/s3.tf# L42)

S3 Bucket SSE Disabled
/s3.tf: [1](https://github.com/ACN-APPSAS/terragoat/blob/snyk-fix-1115b76628621bc00226f431f83871c0//terraform/aws/s3.tf# L1)

CVE-2007-2379
Npm-jquery-3.6.0

CVE-2014-6071
Npm-jquery-3.6.0

CVE-2023-2251
Npm-yaml-1.10.2


Documentation page gives 404

The GitHub pages site @ https://ibm-swift.github.io/swift-html-entities/ returns a 404 error.

Hi @ccamaisa
The links for all the Kitura sites are in the process of being updated.
You can access the docs at https://kitura.github.io/swift-html-entities/

@ccamaisa Where did you find that URL, so we can update it? Thanks.

@mbarnach all the Kitura repos that have docs as github pages have links on their main pages. This is on the right just under About. e.g. on this repo https://ibm-swift.github.io/swift-html-entities/
This is not in code and has to be manually changed in the repos settings pages.

This is changed using the gear icon to the right of About

I see. Unfortunately, I don't have write access to this repo. @dannys42 Could you either grant me access or do it? I assume many Kitura repository have the issue. @futurejones thanks!

There weren't many repos that needed fixing, but they should all be fixed now.


fix: runner_features added in runner.py and tests modified

A function runner_features is added as an abstract method to the runner class. This methods provides the features required by an implementation to Lnprototest. This makes Lnprototest compatible with other implementations.
The tests are also modified to use this function in connect_to_node_helper.

I have made the suggested changes :)

Sorry for the delay. The PR looks good. Thanks for the changes.
Can we rework the commit in two?
1. Make the change to the lnprototest package by describing the commit and why we need it in the commit body;

2. Make the change to the tests and describe it inside the commit body

Actually there are no changes in the tests, it just formats it when I run make fmt. The only changes are present in ln_spec_utils.py and runner.py. So should I make it in a single commit?

Actually there are no changes in the tests, it just formats it when I run make fmt. The only changes are present in ln_spec_utils.py and runner.py. So should I make it in a single commit?

Yeah I just noted, maybe the new black version is formatting the things in a different way! Good to go in a single block

I have made the changes

Ok margin this because with lnprototest and bitcoin 24 it is working fine, I think there is some problem with bitcoin 25 but this is not related to this PR


Zombie process when failing to run external code editor

Godot version
v4.1.1.stable.official [bd6af8e0e]
System information
Debian 12
Issue description
When setting a non-existent extern code editor godot will leave behind a zombie process every time you try to edit a file.
Steps to reproduce

Set Text Editor > External > Exec Path to a non-existent executable.
Attempt to edit a source file.

 ERROR: Could not create child process: code
     at: create_process (drivers/unix/os_unix.cpp:583)

is logged to stdout.
A zombie process called Godot_v4.1.1-st is left behind. (This is Godot_v4.1.1-stable_linux.x86_64 truncated to 15 bytes + nul terminator.)

Minimal reproduction project
The FPS template.

The Linux/BSD create_process and execute functions (uses the base OS_Unix impl) really need work.
They assume the path they are given is valid and there is nothing attempting to manage the child processes.
There are several related issues stemming from this. See #49946.

This also happens when the run is successful:
Use External Editor: true
Exec Path: nvim
Exec Flags: --server /tmp/godot.pipe --remote-send "<C-\><C-N>:n {file}<CR>:{line}<CR>0{col}l"

It does work, but creates a nvim zombie process each time a file is clicked.
Godot version
v4.3.stable.mono.official [77dcf97d8]
System information
Pop!_OS 22.04 LTS x86_64

This also happens when the run is successful:
Use External Editor: true
Exec Path: nvim
Exec Flags: --server /tmp/godot.pipe --remote-send "<C-\><C-N>:n {file}<CR>:{line}<CR>0{col}l"

It does work, but creates a nvim zombie process each time a file is clicked.
Godot version
v4.3.stable.mono.official [77dcf97]
System information
Pop!_OS 22.04 LTS x86_64

I can confirm the exact same issue when trying to integrate with neovim although in my case I'm setting the exec path to a shell script which handles the rest. I made sure to have proper exits and to tie up loose ends though--I think it's definitely an issue with the Godot editor. Do we know where this lies in terms of priority?
System information
Pop!_OS 24.04 LTS x86_64


Add structlog to replace loguru

Closes #3724
Closes #3725
Description Of Changes
Replacing loguru with structlog to enable more advanced logging features and improvements that we want to make in the near-future. They behave very similarly so other than mass import changes there shouldn't be much else that needs to get changed here
The Finalized format will be the following:
Dev Mode:

Human-readable logging format (non JSON)
Colorized
Include file/function/line number in the log

Prod Mode:

JSON formatting

Code Changes

[x] add structlog as a requirement
[x] update imports
[x] remove loguru as a requirement
[ ] update failing tests (some larger rewrites are required here, but should end up in better tests)
[ ] update the logging format

Steps to Confirm

[ ] list any manual steps for reviewers to confirm the changes

Pre-Merge Checklist

[ ] All CI Pipelines Succeeded
Documentation:

[ ] documentation complete, PR opened in fidesdocs
[ ] documentation issue created in fidesdocs

[ ] Issue Requirements are Met
[ ] Relevant Follow-Up Issues Created
[ ] Update CHANGELOG.md
[ ] For API changes, the Postman collection has been updated

Dev Mode

Prod (Not Dev Mode)

@RobertKeyser @seanpreston curious to get your thoughts here on including things like the file/function/line number in the logs
This should technically make things much easier to debug, but I also don't know if it crosses the line of "leaking implementation details". It is trivial to remove so wanted some second opinions

@RobertKeyser @seanpreston curious to get your thoughts here on including things like the file/function/line number in the logs
This should technically make things much easier to debug, but I also don't know if it crosses the line of "leaking implementation details". It is trivial to remove so wanted some second opinions

I'm not worried about leaking implementation details in open source Fides; however, that might have a very minor risk for Fidesplus. However, I think that it might add extra noise to the logs with only minor value, so I think we can go without including the filename/line number.

Given the extreme complexity of untangling loguru in favor of structlog, I'm going to close this PR and instead opt for getting the functionality we want working in loguru, which should be possible


Graphiql typescript migration

For #1189 - Convert GraphiQL to Typescript with minimal production changes. True refactor is ideal.

Looks like next week is going to be much more realistic for me to dive in on this. Lots of planning this week

@rohit-gohri we merged your PR, thanks for your suggestions they were very helpful and important!

@rohit-gohri we merged your PR, thanks for your suggestions they were very helpful and important!

Glad to be of any help :D

@ryan-m-walker I think we're done for this pass :laughing:


Refactor "/logout" Route for Improved Code Structure

Title: Refactor "/logout" Route for Improved Code Structure
Description:
This GitHub issue is dedicated to refactoring the "/logout" route within the packages/server/src/api_auth/index.ts file. The primary goal is to enhance the code structure by using res.locals.reqClientData as the source for client data, removing direct accesses to req.body, req.query, and req.params. Additionally, this refactoring will introduce a try-catch block for effective error handling, following the approach in the "login" route within the same folder.
Tasks:

Code Refactoring:

[ ] Review the existing "/logout" route in packages/server/src/api_auth/index.ts.
[ ] Replace direct accesses to req.body, req.query, and req.params with res.locals.reqClientData.
[ ] Ensure consistent retrieval of client data from res.locals.reqClientData.

Error Handling:

[ ] Implement a try-catch block to handle errors gracefully.
[ ] Customize error messages and responses for meaningful feedback.

Testing:

[ ] Test the refactored "/logout" route to ensure correct functionality.
[ ] Verify that error handling is effective in different scenarios.

Documentation:

[ ] Update any relevant documentation to reflect the changes made to the "/logout" route.

Acceptance Criteria:

The "/logout" route is successfully refactored to use res.locals.reqClientData.
Direct accesses to req.body, req.query, and req.params are eliminated in favor of res.locals.reqClientData.
The refactored code includes a try-catch block for effective error handling.
Testing confirms the correct functionality of the refactored route.
Documentation accurately reflects the changes made to the "/logout" route.

Additional Information:

Utilizing res.locals.reqClientData improves code structure and reduces dependencies on direct request access.
Effective error handling enhances the robustness of the route.

@Rachit1313  I am reaching out to inquire about the current status of the issue you are addressing. Could you please provide an update on your progress and, if feasible, an estimated timeline for resolution?
Given the urgency of the matter, it is crucial for us to ensure a swift resolution. If, for any reason, completion within the next two days seems challenging, please inform me promptly. In such a scenario, we may need to reassign the task to ensure timely resolution.
Your cooperation is highly valued, and I appreciate your attention to this matter.

Hi @prasenjeet-symon , Sorry for the delay... just got busy with some other issue and school stuff. didn't even receive a notification for this urgency. Let me know if any changes are required.


customer_testing failures

In the last few days, I've been noticing that a few PRs have been failing the *customer_testing checks, just like this: https://github.com/flutter/flutter/pull/69562/checks?check_run_id=1344873525
Initially, I recommended merging/rebasing with the latest master since the test failures seem unrelated to the changes. However, this does not work and the only way it has worked for me is by deleting my copy of flutter and reforking a fresh copy of the framework.
Maybe this doesn't require a fix anywhere, but does anybody have a recommendation for how to resolve the check failures in a different way?

This issue should be fixed by https://github.com/flutter/flutter/pull/69726. The underlying issue was that when merging upstream, the tool would not consider version tags from the merged in branch. A rebase would have solved (but can be difficult).


[AIRFLOW-1095]  ldap_auth memberOf should come from configuration

if the key ldap/group_member_attr is set in the airflow.cfg, the this value is used
to lookup groups for the user.

Codecov Report

Merging #2232 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2232   +/-   ##
=======================================
  Coverage   68.17%   68.17%
=======================================
  Files         142      142
  Lines       10957    10957
=======================================
  Hits         7470     7470
  Misses       3487     3487

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 177d341...c29612b. Read the comment docs.

Should update docs to mention this feature. Somewhere like here maybe:
https://airflow.incubator.apache.org/security.html?highlight=ldap#ldap
Also, might consider updating the default configs to include group_member_attr = memberOf just to help people be aware that this exists.

LGTM

In future, please follow template when opening PR.
https://issues.apache.org/jira/browse/AIRFLOW-1095


Cycle Finder Task Exit with Failure

Cycle Finder Task Exit with Failure. I am not sure if this is fixable, but so far I had the same problem when I created the cycle finder task.
Works correct but gives a Failure output.
BUILD SUCCESSFUL

Total time: 3.293 secs
http-server:TestJ2Objc mg$ gradle j2objcCycleFinder
:addAptCompilerArgs
:compileJava
:processResources UP-TO-DATE
:classes
:compileTestJava UP-TO-DATE
:processTestResources UP-TO-DATE
:testClasses UP-TO-DATE
:test UP-TO-DATE
:j2objcCycleFinder

***** Found reference cycle *****
NumberIncrementer -> (field x with type JSNIExample)
JSNIExample -> (field x with type NumberIncrementer)
----- Full Types -----
Lcom/example/incrementer/shared/NumberIncrementer;
Lcom/example/incrementer/shared/JSNIExample;

1 CYCLES FOUND.
:j2objcCycleFinder FAILED

FAILURE: Build failed with an exception.

* Where:
Script '/Users/mg/Documents/Grails/GGTS3.6.2/TestJ2Objc/j2objc.gradle' line: 277

* What went wrong:
Execution failed for task ':j2objcCycleFinder'.
> Process 'command '/Applications/J2Objc/j2objc-0.9.6/cycle_finder'' finished with non-zero exit value 1

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output.

BUILD FAILED

Total time: 17.552 secs

It's designed to fail in this way. If you enable cycleFinder and it finds a
cycle, it will fail the build. My code currently runs clean with no cycles,
so I want it to alert on all new cycles.
What I'll do is add a "cycleFinderMaxCycles" integer value, that in this
case you could set to 1. So the build will work if there's only one cycle,
then fail if a new cycle is added (that's what you want to know about).
On Tue Feb 10 2015 at 8:11:26 AM Confile<EMAIL_ADDRESS>wrote:

Cycle Finder Task Exit with Failure. I am not sure if this is fixable, but
so far I had the same problem when I created the cycle finder task.
Works correct but gives a Failure output.
BUILD SUCCESSFUL
Total time: 3.293 secs
http-server:TestJ2Objc mg$ gradle j2objcCycleFinder
:addAptCompilerArgs
:compileJava
:processResources UP-TO-DATE
:classes
:compileTestJava UP-TO-DATE
:processTestResources UP-TO-DATE
:testClasses UP-TO-DATE
:test UP-TO-DATE
:j2objcCycleFinder
***** Found reference cycle *****
NumberIncrementer -> (field x with type JSNIExample)
JSNIExample -> (field x with type NumberIncrementer)
----- Full Types -----
Lcom/example/incrementer/shared/NumberIncrementer;
Lcom/example/incrementer/shared/JSNIExample;
1 CYCLES FOUND.
:j2objcCycleFinder FAILED
FAILURE: Build failed with an exception.

Where:
Script '/Users/mg/Documents/Grails/GGTS3.6.2/TestJ2Objc/j2objc.gradle' line: 277

What went wrong:
Execution failed for task ':j2objcCycleFinder'.

Process 'command '/Applications/J2Objc/j2objc-0.9.6/cycle_finder'' finished with non-zero exit value 1

Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output.

BUILD FAILED
Total time: 17.552 secs
—
Reply to this email directly or view it on GitHub
https://github.com/brunobowden/j2objc-gradle/issues/5.

See this code for "testExecutedCheck" which has similar logic, happy to accept a patch from you. It's not that hard to change. Otherwise I'll get to it later today...
https://github.com/brunobowden/j2objc-gradle/blob/master/j2objc.gradle#L482

You can now fix it with the latest version and following config:
j2objcConfig {
cycleFinder true
cycleFinderExpectedCycles 1
}

LGTM


[REVIEW] mrdanishsaleem

GitHub Profile Link
https://github.com/mrdanishsaleem

Like it!

Thank you so much for you feedback.


fix: Make worktree compliant

Mergify-cli stack change-Id: I1b263e4ca6cbc7ffc109843d8e5e68c8b25f17cd:
Depends-On: #21

This pull request is part of a stack:

chore: rename git_push_stack to mergify_cli (#21)
fix: Make worktree compliant (#22)
feat: get token through gh auth token if not provided by --token or GITHUB_TOKEN env var (#23)
fix: convert coroutine to task (#24)
feat: Add control on draft or open status through a param (#25)
feat: Define trunk through param --trunk/-t or git config mergify-cli.stack-trunk (#26)
fix: Improve hook (#27)


Split stack checks

Some RISC-V implementations will be more dependent on static branch prediction.  We can be friendlier to them by moving the morestack call to the end of the function, so that the initial ld; bgeu is a not-taken forward branch.  Look at what cmd/internal/obj/x86.stacksplit is doing, there are subtleties with pcdata and stack adjustment that need to be handled to keep GC happy (just copying the original x86 commit is not enough).

It would probably be easier to copy pcdata/spadj code from arm or mips or another architecture with a link register.

cc @cherrymui

All issues should be re-opened upstream if still relevant (unlikely).


feat(cronjob): introduce CronJob construct (#1052)

Backport
This will backport the following commits from k8s-24/main to k8s-22/main:

feat(cronjob): introduce CronJob construct (#1052)

Questions ?
Please refer to the Backport tool documentation

⚪ Backport skipped
The pull request was not backported as there were no branches to backport to. If this is a mistake, please apply the desired version labels or run the backport tool manually.
Manual backport
To create the backport manually run:
backport --pr 1122

Questions ?
Please refer to the Backport tool documentation


Adding simplebar js file breaks my app

When I add the .js file in my app, it breaks the layout/behaviour. The file is loaded successfully but no error in console is shown though. I don't know how I can reproduce a valid live demo, as the app uses proprietary template (Inspinia).
Below the before/after screenshot of the result of adding the .js file:

This is line which is causing the issue:
<script<EMAIL_ADDRESS>
Keeping css file only doens't affects the app at all. It seems that SimpleBar is conflicting with some other js, but I can't figure out without an error. I'm using latest Chrome (77.0.3865.120) 64 bits version.
Any idea how can I isolate it or event figure out what is causing the issue?
Thanks in advance

Thank you for the quick response.
I managed it to work. Not sure why but the point here is that when I add data-simplebar in the element (a menu li in this case), it breaks the style to that on the screenshot. Even if I start it programatically on the element with new SimpleBar($0) on the console, it does the same. It works actually, the SimpleBar's scrollbar is there, but the element styles gets wierd.
Inspecting it's styles in dev tools, it seems that SimpleBar only adds the following styles:
position: relative;
flex-direction: column;
flex-wrap: wrap;
justify-content: flex-start;
align-content: flex-start;
align-items: flex-start;

Which is ok, I think. There is anything else the new SimpleBar(...) does behind the scenes? I know any style changes in the element by the js would be reflected in the inspection as well, but I'm asking cause I have no clue anymore.


adding sticky scripts to make elements stay in place

adds a table of contents to the patient details sidebar for navigating the page
adds a script to the site to allow for sticky elements based on scroll height. Just add the .sticky class to something and when it hits the top it will start scrolling!

Going to close this for two reasons:

Rethinking navigation and how the patient details page works
Adds unnecessary javascript to the page


enhancement: optionally use content-location

When writing output files, currently Content-Disposition is used to create the output filname. With this change you can specify --uselocation so that the content-location header is also checked. Chrome and others save their mht files with this header set.

Here is a revision that lets callers provide a custom name function, I think this is the best approach for now.

Sorry to very late. I've not had enough time to look into your comments and changes.

If I didn't put it behind an option, it would change the output for existing users of the code, and I'm not sure what the right output names would be anyways.
Paths in content-location can take different forms. For example, saving google.com to mhtml in Chrome gives these:...

This is exactly what I was concerned about and your latest version looks very nice.I merged it.


Preserve class of preview images

I use class names to style the image. I learn that this library will remove the class entirely.
I'm proposing small changes where I copy the class list of the preview image and paste it into the full image so the class list is preserved.
Regards 😊

Thanks @virkillz
Sorry, but I'm not keen on copying the thumbnail classes to the full image. No one else has had your issue and it seems unnecessary when you can target either image using a class applied to any parent, e.g.

CSS:
.myclass img {
  /* full image */
}

.myclass img.preview {
  /* preview image */
}

If you really need this, I suggest forking the code and creating a custom version.


Fix remove duplicate transaction promise

Fixes second issue from #3309.

Would it be possible to add test case for the bug it fixes?

As i said in the issue - your tests are already sufficient. You can see it in tests logs.
Look: logs for PR that introduced the problem (there are 260 UnhandledPromiseRejectionWarning), logs for this PR (there are none of those).
If you want tests to show rejections more clearly you should force tests to exit with non-zero status on unhandled rejections. How to do it i wrote in the issue. But you need to eliminate other unhandled rejections (there are around ten of them) before you do so.

Thanks! I'll release a fixed version shortly.


Date not accepted in yyyy. MM. dd. on Firefox on hungarian locale

Bug, feature request, or proposal:
Bug
What is the expected behavior?
Date typed in yyyy. mm. dd. format should be accepted, when locale set to hu-HU on Firefox
What is the current behavior?
Date typed in the required format accepted on Chrome but not in Firefox
What are the steps to reproduce?
https://angular-material2-issue-vgvnzv.stackblitz.io

Type for example 2018. 12. 13.
On Chrome, the date is selected, but on Firefox isn't

Which versions of Angular, Material, OS, TypeScript, browsers are affected?
Angular: 6.1.3
Material: 6.4.5
Chrome: 69.0.3497.92
Firefox: 62.0

Can anyone confirm this bug?

See https://material.angular.io/components/datepicker/overview#internationalization
The i18n is handled either by the browser itself (NativeDateAdapter) or by a 3rd party library (e.g. MomentDateAdapter). The component itself doesn't know anything about timezones or localization.


fix(forking): wrap forking initialization errors with contextual info

This resolves #476 by adding some contextual information on errors. See my comment for more details: https://github.com/trufflesuite/ganache-core/issues/476#issuecomment-677979429

Coverage increased (+0.004%) to 82.586% when pulling ee0e361c0c9bbd14c63abbb2e0ba88f47514c056 on fix/forking-add-more-context-to-errors into a8a4d8f04a357380963c62110fc7659b4f03c4ec on develop.

Alright I pushed a change
Before:
mike@darwin:~/work/truffle/ganache-cli$ node cli.js -f https://mainnet.infura.io
Ganache CLI v6.10.1-beta.2 (ganache-core: 2.11.2)
Error: The fork provider errored when checking net_version: Returned error: project ID is required
    at Object.ErrorResponse (/home/mike/work/truffle/ganache-core/node_modules/web3-core-helpers/src/errors.js:29:16)
    at /home/mike/work/truffle/ganache-core/node_modules/web3-core-requestmanager/src/index.js:140:36
    at Promise.all.then (/home/mike/work/truffle/ganache-core/lib/forking/forked_blockchain.js:135:11)
    at process._tickCallback (internal/process/next_tick.js:68:7)

After:
mike@darwin:~/work/truffle/ganache-cli$ node cli.js -f https://mainnet.infura.io
Ganache CLI v6.10.1-beta.2 (ganache-core: 2.11.2)
Error: The fork provider errored when checking net_version: Returned error: project ID is required
    at web3.eth.net.getId (/home/mike/work/truffle/ganache-core/lib/forking/forked_blockchain.js:172:17)
    at Object._fireError (/home/mike/work/truffle/ganache-core/node_modules/web3-utils/src/index.js:61:9)
    at sendTxCallback (/home/mike/work/truffle/ganache-core/node_modules/web3-core-method/src/index.js:558:30)
    at /home/mike/work/truffle/ganache-core/node_modules/web3-core-requestmanager/src/index.js:140:20
    at Promise.all.then (/home/mike/work/truffle/ganache-core/lib/forking/forked_blockchain.js:135:11)
    at process._tickCallback (internal/process/next_tick.js:68:7)


Should the new "Pending" state be on the Charge Mode instead of Status?

Is your feature request related to a problem? Please describe.
Release 2.0.x has just added a new Pending state for the main Status, and I've been reviewing my automation triggers to see what needs to change.
Adding Pending to the main Status makes it harder to be specific about transitions like from "Connected Waiting" to "Charging" because the Pending state could interrupt that transition.
Describe the solution you'd like
The Pending state is intended to show when API requests are waiting to be actioned, and these affect the charge scheduling - isn't Pending more relevant to the Charge Mode than the status of the cable and charge delivery?
Describe alternatives you've considered
I can ignore the "From" transition when triggering on states, and can use "not_from" and "not_to" in the trigger if I edit the yaml.
I can use the Cable Status for Unplugged vs Plugged In.
Additional context
Add any other context or screenshots about the feature request here.

Sorry, I was misunderstanding the information I read in the release note - I originally thought that Pending applied to the Cable Status as well as the main Status. While Pending feels more like a Charge Mode state to me, it's not affecting my use of the integration.
I also originally assumed that Pending was a state introduced by this integration to indicate waiting for a response from the Pod Point API, but now I understand that is actually a state from the API indicating waiting for the individual Pod Point to respond (and so the state in Home Assistant might go to Pending if I request a change via the app, although I've not see that happen yet).

Hi @busywait, thanks for raising this!
The pending state is a strange one, it is present in the mobile app and through observation (as there is no documentation for these endpoints) appears to be the following:

As a user, when I change a setting that affects my Pod (charge mode, schedules, etc) I would like to understand when the change has taken place

The app appears to keep track of the date/time a request was made (request_time) to change a setting, then compares this to the 'last message received from pod' date/time (update_time).
When request_time > update_time state = pending
As the pod and api are not aware of a message that has been sent to a pod, the api (which only reports the last state of the pod) doesnt DIRECTLY return pending. I have recreated the observed behaviour from the Pod Point app by implementing the same logic described above.
If you make a change to your pod VIA home assistant (stop charging, start charging, start charge now, stop charge now) I store the date/time of that request. Then there is a check which compares that date/time to the last message received from the pod. If the pod has not send at update after request_time, the assumption can be made that the pod has not yet received the update. Changing the state to pending highlights to users that their change has not yet been accepted/implemented by the pod.
This will only take place when the request for change happens within Home Assistant as all requests 'external' to the integration are transparent.
I hope this helps to clear up why your integration does not show pending when you make a change in the app.
If you can think of a better way to hande this/want this to be an option feature, I can look into this for a future release

Thanks for the clarification. I think that Pending makes more sense in the Pod Point app which is designed for interactive control than it does in your integration API, which will more typically be used in automation (I think). Thanks for clarifying that it is a state that is local to the calling app. Personally it doesn't help me, but I've modified my triggers to account for it.
In case it's interesting, here are the ways that I'm using your Pod Point integration:

Trigger status update requests to my car on real events (unplugged, finished charging, ...) to see up-to-date information in Home Assistant without stopping the car from "sleeping" because of polling the car API for status updates
See that the car is setup to charge overnight, is charging and has charged
Use the "Schedule override" service (+ Car API) with a shortcut button inside the house to work as a "boost" button to start charging the car to 100% now regardless of schedules or limits that were set in the car
Check the status histories (Status, Charge Mode, Cable Status) to work out what happened if the car didn't charge as I expected

Next time I change my electricity tariff I'll try and use the "schedule override" service to make use of dynamic electric tariffs like Agile Octopus.


Can't install ngrok

I think it's a bug because I can't install ngrok from your tools (Tunnel) always show the output 'Turn On Internet Pls.....!'

Sorry My Bad You Should Make The Script auto delete ngrok from home directory


How to get rid of trailing forward slashes after nuxt generate?

When I use nuxt generate, dynamic links with an index.vue in the route's last folder creates a link like this:
https://mydomain.com/mypath/index.html
After deploying to S3, there is a redirect if the trailing forward slash is missing after mypath/.  So https://mydomain.com/mypath redirects to https://mydomain.com/mypath/.
Is there any way around this, or is this a necessary evil of static sites?  Thanks.

I believe this is outside the scope of nuxt and directly depends on the configuration of the static host you are using. In your case AWS S3. Check out this: https://forums.aws.amazon.com/thread.jspa?threadID=168000


Vulkan API driver missing.

Hi, when I run python main.py --query "a living room" --openai_api_key "xxxx" on the server in the lab, the following error occurs. When I after follow his instructions and execute "sudo apt-get -y install libvulkan1", the same error is still reported. Can you help me?

I have solved this problem, thank you!


Use CL/cl2.hpp for rotate_opencl_plugin

Since v2.0.12 KronosGroup removed outdated cl.h header.
This change introduce minimal compatibility fix. According to https://github.com/intel/compute-runtime/blob/master/README.md
supported OpenCL API version on Apollo Lake and Gemini Lake platforms is 1.2
Fixes #2190

Well in this one too: #2197. HEVC FEI tests shouldn't be affected by this commit. I believe, that some latest changes in text box configurations cause those fails.

yeah, indeed. @eponomar : fyi

Problem occurs after driver backmerge of [Decode] Add common render command packet commit and was fixed in [Decode] Partially revert common render packet. Please rebase your commit, but builds for some last backmerged commits still in progress, so I am not sure that we will not face with new issues.


Integrate a cell type ontology from NIF and OpenKnowledgeSpace/methodsOntology

Cell type annotation is crucial to BBP data annotation. A lot of work already happened in collaboration with NIF and in the context of HBP :

OpenKnowledgeSpace/methodsOntology which is imported in NIF

hbp_cells.py from NIF

cell type from the 2015 cell paper -neuron_ma2015.py

Now we need to consolidate all this work in one cell type ontology. A prerequisite would be to have competency questions ready (see #103).

The neuron_ma2015.py code needs to be adapted to export into the new format described below.
The full cell types ontology work is best documented here. There is also the phenotypes namespaces file, which has a namespace for bbp. The definitions in that file not correct because they currently use species general identifiers where they should be using species specific identifiers, but that is blocked by the need to finish the parcellation schemes work. If there are new definitions that you all need one easy place to start is by adding them to the bbp namespace and I can make sure that the required phenotypes are incorporated into the core of the neuron/phenotype ontology.

Thank you for sharing this documentation. I'll quickly review the  phenotypes namespaces and see if there are new needed definitions.
@srjimenez : it would be great if you can have a look too.


rviz dae file Collada: File came out empty. Something is wrong here.

Describe your issue here and explain how to reproduce it.
Your environment

OS Version: Ubuntu 16.04
ROS Distro: Kinetic
RViz, Qt, OGRE, OpenGl version as printed by rviz:

[ INFO] [1597549634.471718284]: rviz version 1.12.17
[ INFO] [1597549634.471928315]: compiled against Qt version 5.5.1
[ INFO] [1597549634.471963392]: compiled against OGRE version 1.9.0 (Ghadamon)
[ INFO] [1597549634.990012145]: Stereo is NOT SUPPORTED
[ INFO] [1597549634.990159050]: OpenGl version: 3 (GLSL 1.3).

Description
Here is the complete run
$ roslaunch urdf_tutorial display.launch model:=/home/jamesn/Documents/Dexter.urdf
... logging to xxxx
Checking log directory for disk usage. This may take awhile.
Press Ctrl-C to interrupt
Done checking log file disk usage. Usage is <1GB.

xacro: Traditional processing is deprecated. Switch to --inorder processing!
To check for compatibility of your document, use option --check-order.
For more infos, see http://wiki.ros.org/xacro#Processing_Order
xacro.py is deprecated; please use xacro instead
started roslaunch server http://<IP_ADDRESS>:39389/

SUMMARY
========

PARAMETERS
 * /robot_description: <?xml version="1....
 * /rosdistro: kinetic
 * /rosversion: 1.12.14
 * /use_gui: True

NODES
  /
    joint_state_publisher (joint_state_publisher/joint_state_publisher)
    robot_state_publisher (robot_state_publisher/state_publisher)
    rviz (rviz/rviz)

ROS_MASTER_URI=http://localhost:11311

process[joint_state_publisher-1]: started with pid [2505]
process[robot_state_publisher-2]: started with pid [2506]
process[rviz-3]: started with pid [2507]
[WARN] [1597548587.898550]: The 'use_gui' parameter was specified, which is deprecated.  We'll attempt to find and run the GUI, but if this fails you should install the 'joint_state_publisher_gui' package instead and run that.  This backwards compatibility option will be removed in Noetic.
[ERROR] [1597548589.274097388]: Could not load resource [LowRes_DexterHDIKinematic_Link1_Bottom.dae]: Collada: File came out empty. Something is wrong here.
[ERROR] [1597548589.274555027]: Could not load model 'LowRes_DexterHDIKinematic_Link1_Bottom.dae' for link 'base_link': OGRE EXCEPTION(6:FileNotFoundException): Cannot locate resource LowRes_DexterHDIKinematic_Link1_Bottom.dae in resource group Autodetect or any other group. in ResourceGroupManager::openResource at /build/ogre-1.9-mqY1wq/ogre-1.9-1.9.0+dfsg1/OgreMain/src/OgreResourceGroupManager.cpp (line 756)
[ERROR] [1597548589.274796288]: Could not load model 'LowRes_DexterHDIKinematic_Link1_Bottom.dae' for link 'base_link': OGRE EXCEPTION(6:FileNotFoundException): Cannot locate resource LowRes_DexterHDIKinematic_Link1_Bottom.dae in resource group Autodetect or any other group. in ResourceGroupManager::openResource at /build/ogre-1.9-mqY1wq/ogre-1.9-1.9.0+dfsg1/OgreMain/src/OgreResourceGroupManager.cpp (line 756)
================================================================================REQUIRED process [rviz-3] has died!
process has finished cleanly
log file: /home/jamesn/.ros/log/0aa1d05c-df47-11ea-a068-1c4bd6cf810c/rviz-3*.log
Initiating shutdown!
================================================================================
[rviz-3] killing on exit
[robot_state_publisher-2] killing on exit
[joint_state_publisher-1] killing on exit
shutting down processing monitor...
... shutting down processing monitor complete
done

I've attached the dae file and the urdf file
LowRes_DexterHDIKinematic_Link1_Bottom.dae.zip
Dexter.urdf.zip

I cannot reproduce this issue in the Melodic release of rviz:

Do you mind updating? Alternatively, use git bisect to figure out which commit fixed the issue and I will backport it.

Please pardon the ROS newbie questions but:

I don't think I can update past Kinetic on Ubuntu 16.04, but maybe I can update only rviz? Is that going to work?
bisecting would be actual work, which I have enough of at the moment. I feel bad saying that but... If you tell me it should be ok to update only rviz, I'll update one release at a time and tell you where it starts working. Hopefully that will narrow it down.

Yes, I'm talking about source builds. Just clone rviz into your private ROS overlay workspace and build. All packages in Kinetic and later build with catkin. Building the latest meloic-devel branch of rviz should work on Kinetic as well.

Followed the workspace overlaying tutorial.
Cloned rviz at current default (which is melodic-devel right? yeah, git status says On branch melodic-devel) and catkin-make says a lot, but ends up with this:
[ 16%] Building CXX object rviz/src/rviz/CMakeFiles/rviz.dir/frame_manager.cpp.o
[ 16%] Built target rviz_default_plugin_automoc
In file included from /home/jamesn/overlay_ws/src/rviz/src/rviz/frame_manager.cpp:30:0:
/home/jamesn/overlay_ws/src/rviz/src/rviz/frame_manager.h: In member function ‘const std::shared_ptr<tf2_ros::Buffer> rviz::FrameManager::getTF2BufferPtr()’:
/home/jamesn/overlay_ws/src/rviz/src/rviz/frame_manager.h:259:17: error: ‘class tf::TransformListener’ has no member named ‘getTF2BufferPtr’
     return tf_->getTF2BufferPtr();
                 ^
rviz/src/rviz/CMakeFiles/rviz.dir/build.make:302: recipe for target 'rviz/src/rviz/CMakeFiles/rviz.dir/frame_manager.cpp.o' failed
make[2]: *** [rviz/src/rviz/CMakeFiles/rviz.dir/frame_manager.cpp.o] Error 1
CMakeFiles/Makefile2:3318: recipe for target 'rviz/src/rviz/CMakeFiles/rviz.dir/all' failed
make[1]: *** [rviz/src/rviz/CMakeFiles/rviz.dir/all] Error 2
Makefile:138: recipe for target 'all' failed
make: *** [all] Error 2
Invoking "make -j8 -l8" failed

Did some binary search on what tag versions will build under Kinetic on Ubuntu 16.04: Was NOT able to build 1.13.4. Was able to build 1.12.17, but it still reports the exact same problem.

Sorry, I forgot about the tf2 migration issue. You also need to clone a recent tf2 version into your catkin workspace and build it together with rviz:
git clone --branch=melodic-devel https://github.com/ros/geometry2

CMake Error at geometry2/tf2_bullet/CMakeLists.txt:11 (find_package):
  By not providing "Findbullet.cmake" in CMAKE_MODULE_PATH this project has
  asked CMake to find a package configuration file provided by "bullet", but
  CMake did not find one.
```
As per:
https://www.programmersought.com/article/7841263710/
`sudo apt-get install libbullet-dev`
Seems better..

Hm. This is strange. Looks like the headers are found in /opt/ros first... Need to investigate myself...
Note, you can easily install all upstream dependencies for your src folder via:
rosdep install --from-paths src --ignore-src --rosdistro $ROS_DISTRO

Sorry, my fault: I was referring you to the wrong TF version. You need to clone TF1 into your catkin workspace:
git clone --branch=melodic-devel https://github.com/ros/geometry

Removed geometry2 and cloned geometry as indicated.
-- ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
-- ~~  traversing 6 packages in topological order:
-- ~~  - geometry (metapackage)
WARNING: The CMakeLists.txt of the metapackage 'geometry' contains non standard content. Use the content of the following file instead: /home/jamesn/overlay_ws/build/catkin_generated/metapackages/geometry/CMakeLists.txt
-- ~~  - eigen_conversions
-- ~~  - kdl_conversions
-- ~~  - tf
-- ~~  - tf_conversions
-- ~~  - rviz
-- ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
CMake Error at /opt/ros/kinetic/share/catkin/cmake/catkin_workspace.cmake:95 (message):
  This workspace contains non-catkin packages in it, and catkin cannot build
  a non-homogeneous workspace without isolation.  Try the
  'catkin_make_isolated' command instead.
Call Stack (most recent call first):
  CMakeLists.txt:67 (catkin_workspace)

I'm not sure how to "Use the content of the following file instead: /home/jamesn/overlay_ws/build/catkin_generated/metapackages/geometry/CMakeLists.txt"
Trying "catkin_make_isolated"

Does catkin provide details on which package is non-catkin? I'm usually building using catkin tools.

Yeah, it says in the output I posted above: "The CMakeLists.txt of the metapackage 'geometry' contains non standard content." Anyway, individual build might have fixed that, but I'm not sure what's going on with the version. See above.

What's the content of your ROS_PACKAGE_PATH? Is your local rviz devel folder listed before /opt/ros?
If not, rebuild from scratch. Something went wrong..

Ah... I should have source ~/overlay_ws/devel_isolated/setup.bash. And then I got confused for a while because 1.13.13 is the melodic top, and the 1.14 must be neodic.
Anyway, it built and ran! Woo hooo!!!!
And I have /exactly/ the same error with 1.13.13:
 roslaunch urdf_tutorial display.launch model:=/home/jamesn/Documents/Dexter.urdf
... logging to /home/jamesn/.ros/log/f8d14f3c-e29e-11ea-a138-1c4bd6cf810c/roslaunch-jamesn-G73Sw2-11307.log
Checking log directory for disk usage. This may take awhile.
Press Ctrl-C to interrupt
Done checking log file disk usage. Usage is <1GB.

xacro: Traditional processing is deprecated. Switch to --inorder processing!
To check for compatibility of your document, use option --check-order.
For more infos, see http://wiki.ros.org/xacro#Processing_Order
xacro.py is deprecated; please use xacro instead
started roslaunch server http://jamesn-G73Sw2:42801/

SUMMARY
========

PARAMETERS
 * /robot_description: <?xml version="1....
 * /rosdistro: kinetic
 * /rosversion: 1.12.14
 * /use_gui: True

NODES
  /
    joint_state_publisher (joint_state_publisher/joint_state_publisher)
    robot_state_publisher (robot_state_publisher/state_publisher)
    rviz (rviz/rviz)

auto-starting new master
process[master]: started with pid [11323]
ROS_MASTER_URI=http://localhost:11311

setting /run_id to f8d14f3c-e29e-11ea-a138-1c4bd6cf810c
process[rosout-1]: started with pid [11336]
started core service [/rosout]
process[joint_state_publisher-2]: started with pid [11343]
process[robot_state_publisher-3]: started with pid [11354]
process[rviz-4]: started with pid [11356]
[WARN] [1597898301.933789]: The 'use_gui' parameter was specified, which is deprecated.  We'll attempt to find and run the GUI, but if this fails you should install the 'joint_state_publisher_gui' package instead and run that.  This backwards compatibility option will be removed in Noetic.
[ERROR] [1597898303.941354921]: Could not load resource [LowRes_DexterHDIKinematic_Link1_Bottom.dae]: Collada: File came out empty. Something is wrong here.
[ERROR] [1597898303.958299646]: Could not load model 'LowRes_DexterHDIKinematic_Link1_Bottom.dae' for link 'base_link': OGRE EXCEPTION(6:FileNotFoundException): Cannot locate resource LowRes_DexterHDIKinematic_Link1_Bottom.dae in resource group Autodetect or any other group. in ResourceGroupManager::openResource at /build/ogre-1.9-mqY1wq/ogre-1.9-1.9.0+dfsg1/OgreMain/src/OgreResourceGroupManager.cpp (line 756)
[ERROR] [1597898303.958730460]: Could not load model 'LowRes_DexterHDIKinematic_Link1_Bottom.dae' for link 'base_link': OGRE EXCEPTION(6:FileNotFoundException): Cannot locate resource LowRes_DexterHDIKinematic_Link1_Bottom.dae in resource group Autodetect or any other group. in ResourceGroupManager::openResource at /build/ogre-1.9-mqY1wq/ogre-1.9-1.9.0+dfsg1/OgreMain/src/OgreResourceGroupManager.cpp (line 756)

The error message Collada: File came out empty. Something is wrong here. is generated by assimp, which is used to parse those files. Looks like the issue is in libassimp. Try to update this one. Closing here as this seems to be an upstream issue.

So apparently this has been a known bug in assimp since 2017... and is still open? How are you getting that file to work on your computer if it's still a known issue? @rhaschke may I ask what version of the OS you are running, since the issue seems less related to ROS version and more related to OS / assimp.
https://github.com/assimp/assimp/issues/1278

The entire issue here has been that the CAD files were not being found.
The urdf file was in the ~/Documents folder, with the CAD files, but despite the documentation indicating that the mesh file "must be a local file." this does not (apparently) mean local to the urdf file. As soon as I put it in a package path, the file was loaded and displayed.
The lack of a package: prefix is clear in the urdf file I attached to the original report.
The error messages do NOT indicate that the file is not found. They say "File came out empty." or "Cannot locate resource"
I would recommend better error messages.

Again, that's an issue of upstream assimp. In my newer version (4.1 from stock Ubuntu 18.04), I get the following error:
[ERROR] ros.rviz: Could not load resource [LowRes_DexterHDIKinematic_Link1_Bottom.dae]: Unable to open file "LowRes_DexterHDIKinematic_Link1_Bottom.dae".


Some networking modules are not compatible with Windows 7

I noticed in a run I did on a Win 7 host, some PowerShell cmdlets are only available to Windows 8.1 / Server 2012 family of operating systems.  Below is a copy of the error message.
Get-NetRoutes reports error on localhost: "The term 'Get-NetRoute' is not recognized as the name of a cmdlet, function, script file, or operable program. Check the spelling of the name, or if a path was included, verify that the path is correct and try again."
Get-NetIPInterfaces reports error on localhost: "The term 'Get-NetIPInterface' is not recognized as the name of a cmdlet, function, script file, or operable program. Check the spelling of the name, or if a path was included, verify that the path is correct and try again."
This article here mentions the use of Net TCP/IP cmdlets:
https://technet.microsoft.com/en-us/library/hh826123(v=wps.630).aspx#feedback
My suspicion is that this may affect Windows 2008 Server OSes also if you try to run those modules.  I'm sure there are other ways of getting this information, but wanted to highlight the issue.  YMMV.

I believe these cmdlets are PSv3 and later, I don't think it's an OS version issue. Ymmv. In general, we've tried to avoid requiring anything later than PSv2, but obviously there are some exceptions.

I've got PSv4 on my Win7 box but the cmdlets there don't run.  The modules do not show up with Get-Command either.

PS version specific cmdlets, OS specific cmdlets, third-party cmdlets... I can't keep them all straight. Linux's RPM has a --whatprovides so you can find out where a file comes from. It would be nice if PowerShell had something similar.

Add to that, I think PSv5 will only run on Windows 8.1/2012 family OSs too.

Make sure you are including the ".ps1" extension at the end of the cmdlet name.

Some Windows 8+ modules are CDXML based. They can’t be made available on Windows 7 because the underlying WMI classes aren’t available; NetTCPIP is one of those modules.
Here is a list of modules that might not work on Windows 7 due to the classes not being available.
BranchCache
DirectAccessClientComponents
DnsClient
iSCSI
MsDtc
NetAdapter
NetConnection
NetLbfo
NetQos
NetSecurity
NetSwitchTeam
NetTCPIP
NetworkConnectivityStatus
NetworkTransition
PrintManagement
ScheduledTasks
SmbShare
SmbWitness
Storage
VpnClient
Wdac


Unable to program device -- Fast blink of blue LED

I've just received three T-PIcoC3 boards, new from factory. I'm unable to program any of them.
When connecting the USB cable, the blue LED blinks quickly. When reversing the cable, the green one blinks. In any case, I'm unable to flash anything to the device. I'm not even able to see a serial/COM port available. Also, the TFT is blank, not showing the factory demo upon connecting.

Small update: I've tried a number of different USB-C cables (including original Mac USB-C cables). Doesn't work. But when I connect these devices using a cable that has a USB Type-A connector on one side and a USB Type-C connector on the other everything works correctly on all the boards.
I'm using MacOS 13.5 (Ventura). Not sure if that has anything to do with it.

I am experiencing this same issue on Somona 14.1.1.  Any updates?

Using an USB-A <-> USB-C cable worked for me too... crazy. I don't think that this is a Mac-related because plugin-in on a power bank resulted in the same issue.

To confirm, USB-C to USB-A/B works for me as well on my newer PC. I find this to be the case with multiple microntrollers (I don't recall why). It might be worth a mention in the instructions.


hack/test-go: Remove -i flag to allow running tests without root

This PR allows running make check without using root and without having the go compiler recompile and test the standard library installed in system paths.
/cc @jhernand

@elad661 make check works for without this patch. What is the error that you see?

This is the output of PERMISSIVE_GO=y make check
{ \
hack/verify-gofmt.sh ||r=1;\
hack/verify-govet.sh ||r=1;\
hack/verify-imports.sh ||r=1;\
exit $r ;\
}
[INFO] Detected go version: go version go1.10.1 linux/amd64.
[WARNING] Detected golang version doesn't match required Go version.
[WARNING] This version mismatch could lead to differences in execution between this run and the CI systems.
[INFO] hack/verify-gofmt.sh exited with code 0 after 00h 00m 00s
[INFO] Detected go version: go version go1.10.1 linux/amd64.
[WARNING] Detected golang version doesn't match required Go version.
[WARNING] This version mismatch could lead to differences in execution between this run and the CI systems.
[INFO] hack/verify-govet.sh exited with code 0 after 00h 00m 00s
SUCCESS after 0.008s: hack/verify-imports.sh:18: executing 'import-verifier /home/elad/Projects/autoheal/hack/import-restrictions.json' expecting success
[INFO] hack/verify-imports.sh exited with code 0 after 00h 00m 00s
GOTEST_FLAGS="" hack/test-go.sh
[INFO] [CLEANUP] Cleaning up temporary directories
go test errors: open /usr/lib/golang/pkg/linux_amd64_race/errors.a: permission denied
go test runtime/internal/sys: mkdir /usr/lib/golang/pkg/linux_amd64_race/runtime: permission denied
go test sync/atomic: mkdir /usr/lib/golang/pkg/linux_amd64_race/sync/: permission denied
go test unicode: open /usr/lib/golang/pkg/linux_amd64_race/unicode.a: permission denied
go test encoding: open /usr/lib/golang/pkg/linux_amd64_race/encoding.a: permission denied
go test unicode/utf16: mkdir /usr/lib/golang/pkg/linux_amd64_race/unicode/: permission denied
go test internal/cpu: mkdir /usr/lib/golang/pkg/linux_amd64_race/internal/: permission denied
go test math/bits: mkdir /usr/lib/golang/pkg/linux_amd64_race/math/: permission denied
go test unicode/utf8: open /usr/lib/golang/pkg/linux_amd64_race/unicode/utf8.a: no such file or directory
go test internal/nettrace: open /usr/lib/golang/pkg/linux_amd64_race/internal/nettrace.a: no such file or directory
go test container/list: mkdir /usr/lib/golang/pkg/linux_amd64_race/container/: permission denied
go test runtime/internal/atomic: open /usr/lib/golang/pkg/linux_amd64_race/runtime/internal/atomic.a: no such file or directory
go test crypto/subtle: mkdir /usr/lib/golang/pkg/linux_amd64_race/crypto/: permission denied
go test crypto/internal/cipherhw: mkdir /usr/lib/golang/pkg/linux_amd64_race/crypto: permission denied
go test vendor/golang_org/x/crypto/cryptobyte/asn1: mkdir /usr/lib/golang/pkg/linux_amd64_race/vendor: permission denied
go test vendor/golang_org/x/crypto/curve25519: mkdir /usr/lib/golang/pkg/linux_amd64_race/vendor: permission denied
go test runtime/cgo: mkdir /usr/lib/golang/pkg/linux_amd64_race/runtime/: permission denied
[ERROR] PID 18184: hack/test-go.sh:190: `go test -i ${gotest_flags} ${test_packages}` exited with status 1.
[INFO] 		Stack Trace:
[INFO] 		  1: hack/test-go.sh:190: `go test -i ${gotest_flags} ${test_packages}`
[INFO]   Exiting with code 1.
make: *** [Makefile:92: test-unit] Error 1

And obviously a non-root user can't write to /usr/lib
You might not see this error on your machine if your GOROOT is set to something else.

What distro and what version of Go are you using? In my Fedora 27 with Go 1.9.5 this doesn't happen, and I don't have a ' GOROOT` environment variable.
Anyhow, that is just curiosity, I don't have any objection to merge this patch.

I'm using Fedora 28 beta with Go 1.10.1

I had the same problem (f28) this fixed it :+1:


Adopt rows format on client-side to fit new design of Neon API

A few points:

string-row doesn't have anymore embedded data (position, source, etc)
source id (tag) should be delivered separately
remove from the interface of row (on client-side) globals refs (references to controllers like bookmarks, session and so on)

covered  via https://github.com/esrlabs/chipmunk/commit/2c598dea128ff894f77131649d9f37990760eedd

covered  via https://github.com/esrlabs/chipmunk/commit/2c598dea128ff894f77131649d9f37990760eedd