CLAHE filter crashes with pixel values > 12bit and behaves very different compared to 8bit

I am using OpenCV 3.1 with 16bit tiff files (pixel values raning from 0 to 2^16) but any 16bit array with values > 2^12 will do.
Reading the image with imread and flag CV_LOAD_IMAGE_GRAYSCALE works fine. The CLAHE result is comparable to other CLAHE implementations (e.g. jimage).
However, using flag CV_LOAD_IMAGE_UNCHANGED the application crashes in the moment clahe.appy() is being called.
If CLAHE input pixel values are scaled down to 12bit, the application does not crash and some kind of CLAHE filtering is applied but I highly doubt that CLAHE processing is done correctly in this case because the behaviour of the filter is very different compared to 8 bit input data (uint8). E.g. inceasing clip factor or tile number lets the image become way too bright.
The 16bit processing was added with
https://github.com/Itseez/opencv/pull/3033 resulting in https://github.com/Itseez/opencv/commit/563200fbf63525ad64952a481f896e4551154dc7

Here is a python script that shows the problem:
The script creates an input and an output window and a third window with trackers to adjust clip/grid parameters.

PROC_8BIT=1: CLAHE works fine with 8bit data
PROC_8BIT=0, CLAHE_WIDTH=12: CLAHE works with 12bit data but differently
PROC_8BIT=0, CLAHE_WIDTH=16 (or >12): CLAHE crashes

Same is true for c++ or c#.
#!/opt/local/bin/python

import numpy as np
from scipy import misc
from scipy import ndimage
import cv2

PROC_8BIT = 1     # 1|0: Limit CLAHE Processing to 8 bit input data
CLAHE_WIDTH = 12  # bit width for CLAHE algorithm
                  # values > 12 will make clahe crash!

if (PROC_8BIT):
   clahe_scale = 1
else:
   clahe_scale = 2**(16 - CLAHE_WIDTH)

def on_trackbar(x):
   global rows, cols
   global input_image
   global clip, grid

   # Read trackbar values
   clip = cv2.getTrackbarPos('clip','Params')
   grid = cv2.getTrackbarPos('grid','Params')

   if grid < 1:
       grid = 1

   # CLAHE
   if clip == 0:
       output_image = input_image
   else:
       clahe = cv2.createCLAHE(clip, (grid, grid))
       # sclae input values,
       # limit to CLAHE_WIDTH (more than 12 bit will lead to crash)
       clahe_input = input_image / clahe_scale
       output_image = clahe.apply(clahe_input)
       # clahe_scale back from CLAHE_WIDTH to 16 bit
       output_image = output_image * clahe_scale

   cv2.imshow("Output", output_image)

if __name__ == "__main__":

   input_image =  misc.lena()

   if (PROC_8BIT):
      # force data type
      input_image = input_image.astype(np.uint8)
   else:
      # dito and fake 16 bit data
      input_image = input_image.astype(np.uint16) * 2**8

   print input_image
   rows,cols = input_image.shape
   print "Image is %d x %d, %s" % (cols, rows, input_image.dtype)

   # create windows
   cv2.namedWindow("Input", 1)
   cv2.imshow("Input", input_image)

   cv2.namedWindow("Output", 1)
   cv2.imshow("Output", input_image)

   cv2.namedWindow("Params", 1)
   # Hack to set tracker window size:
   blank_image = np.zeros((2,800,1), dtype=np.uint8)
   cv2.imshow("Params", blank_image)

   # add trackbars
   cv2.createTrackbar('grid', 'Params', 16, 64, on_trackbar)
   cv2.createTrackbar('clip', 'Params',3, 64, on_trackbar)

   on_trackbar(0)
   key = cv2.waitKey(0)
   cv2.destroyAllWindows()


Import pynndescent lazily to speed up import

Importing umap tended to take long; pynndescent is the culprit. This moves the substantial cost of importing pynndescent from import time to the first use. Among other things, this is likely to make it much nicer to run script.py --help and other operations that actually do not use UMAP on programs that nevertheless import UMAP.

Related old issue: #631

I understand that import time can be annoying. On the other hand I'm not convinced that punting it to first use necessarily improves the experience. Long term I would like to have caching work better in numba and then pynndescent will take less time to load (as we can safely cache more) but that's a different problem.
I'm not entirely averse to this proposal, but would it be possible to pitch me on why you think this approach will be better?

Thank you for giving me the opportunity to pitch!
It's likely not uncommon for libraries using UMAP either conditionally or unconditionally to import it in a module; generally, it requires work (similar to the patch I proposed here) to do things more lazily. For example, I come from using BERTopic, which by default uses UMAP when fitting a model, but I'm not sure it needs it when just loading and using a model.
I view it as more of an interactivity and iteration time issue. When I execute a script that indirectly imports UMAP, I only get to see any trivial error messages before getting to the point where UMAP would be used after several seconds due to the import time. Just running python script.py --help takes several seconds.
With this change, I'd assume most such scripts would be able to perform the error-prone steps of command line argument parsing, data loading etc. without having to spend the time it takes to import pynndescent.
In the case where UMAP is actually not needed (like I think with BERTopic when loading a model), the execution time of the import is, of course, saved entirely.
Now, it would obviously be possible for all such modules to do the same thing to lazily import UMAP, but then each of them would need to do it separately. Generally, I agree with you that the ideal case would be fixing things in numba so that pynndescent can be loaded faster; failing that, pushing the laziness as deep in the chain as possible results in the most generally useful fix in the sense that every user of it will automatically get the benefits. That is, the second nicest thing would be if pynndescent could only do its compilation lazily, but I understand that due to numba limitations this is not currently feasible without, I think, a more involved wrapping there. Having said that, if you wish, I can try to develop a similar workaround for pynndescent.

You do make a decent case. On the other hand it will result in a significantly slower first run of UMAP because it will be deferring the import to that point, and as that import is hidden the delay won't be obvious to users. Let me think about it for a bit.


This created very problematic regression for parsing Guid values.

    This created very problematic regression for parsing Guid values.

Convert.ChangeType("{08d15efd-bd4f-4244-b46e-2238964e0e36}", typeof(Guid), System.Globalization.CultureInfo.InvariantCulture) throws
Originally posted by @maw136 in https://github.com/microsoft/playwright-dotnet/issues/2178#issuecomment-1306371464

Can you provide us a repro which we can run locally?

I have discovered the issue with the usage of IPage.EvaluateAsync<Guid> method with a JS script body that returns proper Guid string.

This then calls ScriptsHelper which calls the changed EvaluateArgumentValueConverter
Previously I have used 1.22 and today I upgraded to 1.27.2 and then I have analyzed the repo to find when the change in the implementation happened.

Full repro:
`
using System;
using System.Threading.Tasks;
using Microsoft.Playwright;
public class Program
{
public static async Task Main()
{
using var playwright = await Playwright.CreateAsync();
await using var browser = await playwright.Chromium.LaunchAsync(new BrowserTypeLaunchOptions{ Channel = "msedge", Headless = true});
var page = await browser.NewPageAsync();
await page.GotoAsync("https://www.microsoft.com/en-us");
var guid = await page.EvaluateAsync("{ document.evaluate('/html/body/div[5]/div/div/main/div/div[2]/div/div/a', document, null, XPathResult.FIRST_ORDERED_NODE_TYPE, null).singleNodeValue.id }");
}
}
`


[go_router_builder] The default location of a StatefulShellBranch cannot be a parameterized route

Steps to reproduce

using go_router: ^14.6.1 and  go_router_builder: ^2.7.1
Run on platform web

Expected results
Working as normal
Actual results
got execption
Code sample
Router

class Routes {
  Routes._();

  static const login = '/login';

  // operation
  static const location = '/location';
  static const banner = '/banner';
  static const category = '/category';
  static const notice = '/notice';

  // management
  static const post = '/post/:category/:location/:gender/:age/:totalExp';
  static const member = '/member';
  static const report = '/report';
  static const withdraw = '/withdraw';

  // etc
  static const toc = '/terms-of-conditions';
  static const pp = '/privacy-policy';
  static const adminHistory = '/admin-history';
}

class AppRouter {
  AppRouter._();

  static final rootKey = GlobalKey<NavigatorState>();

  static BuildContext get currentContext {
    final context = router.routerDelegate.navigatorKey.currentContext;
    if (context?.mounted ?? false) {
      return router.routerDelegate.navigatorKey.currentContext!;
    }
    throw FlutterError('AppRouter [currentContext] cannot null');
  }

  static String get currentRouterName {
    final route = router.routerDelegate.currentConfiguration.last.route;
    return route.name ?? route.path;
  }

  static final router = GoRouter(
    debugLogDiagnostics: true,
    navigatorKey: rootKey,
    errorPageBuilder: (context, state) {
      return NoTransitionPage(
        child: UndefineRouteScreen(
          text: '${state.error}',
        ),
      );
    },
    refreshListenable: StorageValue.token,
    initialLocation: const LocationRoute().location,
    routes: $appRoutes,
    redirect: (context, state) {
      final isLogin = StorageValue.token.value?.isNotEmpty ?? false;
      if (!isLogin) return const LoginRoute().location;

      if (state.topRoute?.path == const LoginRoute().location && isLogin) {
        return const LocationRoute().location;
      }

      return null;
    },
    extraCodec: const MyExtraCodec(),
  );

  static void go(String location, {Object? extra}) {
    router.go(location, extra: extra);
  }

  static Future<T?> push<T>(String location, {Object? extra}) {
    return router.push<T>(location, extra: extra);
  }

  static Future<T?> replace<T>(String location, {Object? extra}) {
    return router.replace<T>(location, extra: extra);
  }
}

StatefulShellRouteData

part of '../app_routes.dart';

@TypedStatefulShellRoute<DashboardRoute>(
  branches: [
    // Operation
    TypedStatefulShellBranch(
      routes: [
        TypedGoRoute<LocationRoute>(
          path: Routes.location,
        ),
      ],
    ),
    TypedStatefulShellBranch(
      routes: [
        TypedGoRoute<BannerRoute>(
          path: Routes.banner,
        ),
      ],
    ),
    TypedStatefulShellBranch(
      routes: [
        TypedGoRoute<CategoryRoute>(
          path: Routes.category,
        ),
      ],
    ),
    TypedStatefulShellBranch(
      routes: [
        TypedGoRoute<NoticeRoute>(
          path: Routes.notice,
        ),
      ],
    ),
    // Management
    TypedStatefulShellBranch(
      routes: [
        TypedGoRoute<MemberRoute>(
          path: Routes.member,
        ),
      ],
    ),
    TypedStatefulShellBranch(
      routes: [
        TypedGoRoute<PostRoute>(
          path: Routes.post,
        ),
      ],
    ),
    TypedStatefulShellBranch(
      routes: [
        TypedGoRoute<ReportRoute>(
          path: Routes.report,
        ),
      ],
    ),
    TypedStatefulShellBranch(
      routes: [
        TypedGoRoute<WithdrawRoute>(
          path: Routes.withdraw,
        ),
      ],
    ),
    // ETC
    TypedStatefulShellBranch(
      routes: [
        TypedGoRoute<TocRoute>(
          path: Routes.toc,
        ),
      ],
    ),
    TypedStatefulShellBranch(
      routes: [
        TypedGoRoute<PPRoute>(
          path: Routes.pp,
        ),
      ],
    ),
    TypedStatefulShellBranch(
      routes: [
        TypedGoRoute<AdminHistoryRoute>(
          path: Routes.adminHistory,
        ),
      ],
    ),
  ],
)
class DashboardRoute extends StatefulShellRouteData {
  const DashboardRoute();

  @override
  Widget builder(
    BuildContext context,
    GoRouterState state,
    StatefulNavigationShell navigationShell,
  ) {
    return navigationShell;
  }

  static Widget $navigatorContainerBuilder(
    BuildContext context,
    StatefulNavigationShell navigationShell,
    List<Widget> children,
  ) {
    return ChangeNotifierProvider(
      create: (context) => DashboardProvider(),
      child: DashboardScreen(
        navigationShell: navigationShell,
        children: children,
      ),
    );
  }
}

Error route

class PostRoute extends GoRouteDataCustom {
  const PostRoute({
    this.category,
    this.location,
    this.age,
    this.totalExp,
    this.gender,
  });

  final int? category, location, age, totalExp;
  final Gender? gender;

  @override
  Widget build(BuildContext context, GoRouterState state) {
    return ChangeNotifierProvider(
      create: (context) => PostProvider(),
      child: const PostScreen(),
    );
  }
}

other router dont have query params
Screenshots or Video

Screenshots / Video demonstration
[Upload media here]

Logs
Logs
══╡ EXCEPTION CAUGHT BY WIDGETS LIBRARY ╞═══════════════════════════════════════════════════════════
The following assertion was thrown building Consumer2<ThemeProvider, AppProvider>(dirty,
dependencies: [_InheritedProviderScope<AppProvider?>, _InheritedProviderScope<ThemeProvider?>]):
Assertion failed:
file:///D:/Pub/Cache/hosted/pub.dev/go_router-14.6.1/lib/src/configuration.dart:146:17
configuration.dart:146
route!.pathParameters.isEmpty
"The default location of a StatefulShellBranch cannot be a parameterized route"

The relevant error-causing widget was:
  Consumer2<ThemeProvider, AppProvider>
  Consumer2:file:///D:/freelance/sayyo_admin/lib/presentation/root.dart:36:14

When the exception was thrown, this was the stack:
dart-sdk/lib/_internal/js_dev_runtime/private/ddc_runtime/errors.dart 296:3       throw_
errors.dart:296
dart-sdk/lib/_internal/js_dev_runtime/private/ddc_runtime/errors.dart 29:3        assertFailed
errors.dart:29
packages/go_router/src/configuration.dart 146:22                                  [_debugCheckStatefulShellBranchDefaultLocations]
configuration.dart:146
packages/go_router/src/configuration.dart 198:12                                  [_onRoutingTableChanged]
configuration.dart:198
packages/go_router/src/configuration.dart 31:5                                    new
configuration.dart:31
packages/go_router/src/router.dart 205:21                                         routingConfig
router.dart:205
packages/go_router/src/router.dart 142:21                                         new
router.dart:142
packages/sayyo_admin/presentation/router/app_routes.dart 89:25                    get router
app_routes.dart:89
dart-sdk/lib/_internal/js_dev_runtime/private/ddc_runtime/operations.dart 1091:8  get
operations.dart:1091
packages/sayyo_admin/presentation/root.dart 60:40                                 <fn>
root.dart:60
packages/provider/src/consumer.dart 206:19                                        buildWithChild
consumer.dart:206
packages/nested/nested.dart 259:41                                                build
nested.dart:259
packages/flutter/src/widgets/framework.dart 5687:22                               build
framework.dart:5687
packages/nested/nested.dart 279:18                                                build
nested.dart:279
packages/flutter/src/widgets/framework.dart 5617:15                               performRebuild
framework.dart:5617
packages/flutter/src/widgets/framework.dart 5333:7                                rebuild
framework.dart:5333

Flutter Doctor output
Doctor output
[√] Flutter (Channel stable, 3.24.4, on Microsoft Windows [Version 10.0.19045.5131], locale en-US)
    • Flutter version 3.24.4 on channel stable at D:\flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 603104015d (6 weeks ago), 2024-10-24 08:01:25 -0700
    • Engine revision db49896cf2
    • Dart version 3.5.4
    • DevTools version 2.37.3

[√] Windows Version (Installed version of Windows is version 10 or higher)

[√] Android toolchain - develop for Android devices (Android SDK version 34.0.0)
    • Android SDK at C:\Users\caogi\AppData\Local\Android\sdk
    • Platform android-34, build-tools 34.0.0
    • Java binary at: C:\Program Files\Android\Android Studio\jbr\bin\java
    • Java version OpenJDK Runtime Environment (build 17.0.10+0--11609105)
    • All Android licenses accepted.

[√] Chrome - develop for the web
    • Chrome at C:\Program Files\Google\Chrome\Application\chrome.exe

[√] Visual Studio - develop Windows apps (Visual Studio Community 2022 17.7.4)
    • Visual Studio at C:\Program Files\Microsoft Visual Studio\2022\Community
    • Visual Studio Community 2022 version 17.7.34031.279
    • Windows 10 SDK version 10.0.22621.0

[!] Android Studio (version 2023.2)
    • Android Studio at D:\android studio
    • Flutter plugin can be installed from:
       https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
       https://plugins.jetbrains.com/plugin/6351-dart
    X Unable to determine bundled Java version.
    • Try updating or re-installing Android Studio.

[√] Android Studio (version 2024.1)
    • Android Studio at C:\Program Files\Android\Android Studio
    • Flutter plugin can be installed from:
       https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
       https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 17.0.10+0--11609105)

[√] Connected device (3 available)
    • Windows (desktop) • windows • windows-x64    • Microsoft Windows [Version 10.0.19045.5131]
    • Chrome (web)      • chrome  • web-javascript • Google Chrome 131.0.6778.86
    • Edge (web)        • edge    • web-javascript • Microsoft Edge 129.0.2792.79

[√] Network resources
    • All expected network resources are available.

! Doctor found issues in 1 category.

@CaoGiaHieu-dev
Check if this helps in your case or not.

@CaoGiaHieu-dev Check if this helps in your case or not.

I was able to resolve my issue by not define query in route path ,

Does it mean this can be closed as resolved ?

yes .


Supports getting a specific version of a secret

This change adds the ability to get a secret by version to unicreds.
The GetSecret function is renamed to GetHighestVersionSecret, and a new GetSecret function uses the GetItem DynamoDB call.
Additionally, this adds environment variables and a make target for the integration test, and updates the KMS mocks.

Great work, thanks a lot for also taking the time to add more documentation.


HSEARCH-2028

Some doc fixes

regarding the sorting issue: did you see the user's comment?
https://hibernate.atlassian.net/browse/HSEARCH-2021?focusedCommentId=73504&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-73504
I'm afraid he's right. He can add the fields, but we don't allow the sorting to be defined as it fails validation vs the metadata which we know of.

Ah, didn't see his comment, but I suppose he has a valid point there :/ I think we would allow sorting but would transparently bring in the uninverting reader. Seems there is no easy work-around then (besides of relying on the uninverting reader, but then no field for that reader must be marked as sortable).

I'll push the first commit only, which resolves HSEARCH-2028 nicely. With the second commit you're sneaking in an unrelated task ;-)
Don't delete the commit yet though, it's a nice one for HSEARCH-2021, we just need some more step to figure how it should be done properly.

HSEARCH-2028 is merged; let's repurpose the remaining part?

Going to close this one; I will send the doc update for HSEARCH-2021 as part of #949.


Suggestion: Sites to ignore or custom shortcut

When composing email on gmail, the shortcut cmd+k (mac) is used to add a link to the selected text. When chrome-kill-sticky is installed, its use of cmd+k takes precedence.
Options to remedy:

Add user option to define a list of sites to ignore (start with chrome guidelines on user options in extension)
Add user option to choose a different keyboard shortcut

Have you tried to customise the shortcut using the instructions from the readme?

To change the keyboard shortcut, visit the page chrome://extensions/shortcuts.


[Dropdown] Security Vulnerability with data-text

When adding the data-text option to dropdown item's, when the user clicks on them the contents are executed.  Here is a simple JSFiddle with two dropdowns: http://jsfiddle.net/daneren2005/7x4jqbe7/2/.  The top one uses data-text and you will get a popup XSS when you select the only option.  The second does not use it and isn't vulnerable.

This is still an open security vulnerability

Although there is currently no volunteer to work on any of this, but it would be nice to have a whole section dedicated to security on the Semantic-UI web site, and for each module, a sub-section on the secure use of that particular module.

https://github.com/Semantic-Org/Semantic-UI/issues/6570

Honestly I would probably hit it myself if it wasn't for all of the open PRs and it seeming to be a waste of time to try to add to this project.

I know what you mean.
Meanwhile, if you have the time and feel so inclined,  you can always try submitting a PR to Fomantic-UI, https://github.com/fomantic/Fomantic-UI which is an active fork of this project...

I will have to take a look at it.  I am still using 2.2 so I would need a decent chunk of time to upgrade to a fork like that to validate all of the changes don't break the crap ton of custom css I use on top of Semantic.  Thanks for the link though.

This is not a security issue, removing html execution is already a setting
$('.ui.dropdown.selection').dropdown({preserveHTML: false});

http://jsfiddle.net/15pw0Lku/

We implemented data sanitizing and added a security page to the docs
https://fomantic-ui.com/modules/dropdown.html#/security


First project not working

Just downloaded and set everything up using the Codepen example.  I see the Left button and the para text I put in the aside display immediately on page load and clicking the button does nothing.  No console error and the css and js files are where they're supposed to be.
Help please, html is below.  This on OSX Catalina running Chrome.
`

    <meta charset="UTF-8">
    <meta name="viewport" content="width=device-width, initial-scale=1.0">
    <meta http-equiv="X-UA-Compatible" content="ie=edge">
    <title>Offcanvas</title>
    <link rel="stylesheet" href="https://cdn.kleenedge.com/dev/css/js-offcanvas.css">

        <button class="c-button js-offcanvas-trigger" data-offcanvas-trigger="off-canvas-left">Left</button>

Here it is!

`

Hi @lcsqlpete
you missed a closing tag (>)

Duh! Sorry to bother you, that fixed it.
Sent with Shift
https://tryshift.com/?utm_source=SentWithShift&utm_campaign=Sent with Shift Signature&utm_medium=Email Signature&utm_content=General Email Group
On Tue, Jan 7, 2020 at 3:43 AM Vasileios Mitsaras<EMAIL_ADDRESS>wrote:

Hi @lcsqlpete https://github.com/lcsqlpete
you missed a closing tag (>)

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/vmitsaras/js-offcanvas/issues/50?email_source=notifications&email_token=ACA2CFGETW2W3JBUG4PIIJ3Q4RTGPA5CNFSM4KDOPUSKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEIITNRY#issuecomment-571553479,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ACA2CFE664OAUZKTVGGMQS3Q4RTGPANCNFSM4KDOPUSA
.


Razor pages global functions

Use case: Write static functions which can be accessed by all razor pages.
The goal: Use razor page just like php
It is written in "razor page" and not controller.cs or dll because I want it to be automatic recompile when I change the code during runtime
In the older version, we can create functions and put it on app_code folder, what is our option in asp.net core 2?

use c# scripting api instead of razor page functions


Armor bug

i dont know what is going on here
https://user-images.githubusercontent.com/76173715/131213654-93db8416-cb6d-4ae9-81ac-47d2a1c729a8.mp4

Please test it with 0.1.0a if the issue still exists please post your project file.

sorry for the wait, i forgot about this!
when i clear their frames, everything seems to work!


Refactor site components to use handlebars input

To allow for proper handling of the new Handlebars components, we needed to update the GeneratedSource and Preview site components.
resolves #143

Sounds good. Will do!


Filename color with "errors" not red anymore when currently selected / opened

In this example both, Config.js and index.js have linting errors but because index.js is currently selected (or hovered over) the red text color is overwritten by the text color for selected / hovered elements.

I did not notice that at all, thanks!

Well I think the hover issue is gone in my build, but for selected that does happen, even VSCode's Dark+ theme changes the foreground colour to that white/grey, hence I can't do much. Marking as fixed.


about multi-gpu acceleration

Hello,
Following the document, I set the flag "--pipeline.ip2p-device cuda:1"  to utilize two GPUs to train the in2n model. But I found that the training speed did not improve. Is this normal? Hoping for your advice!

Hi!
I'm not sure why training speed did not improve. Could you share some screenshots of your nvidia-smi on the two GPUs as well as the training logs from nerfstudio? That'll help us figure it out.

I noticed that during the training process, the value of the GPU-Util of the two GPU increases from 0 to 100 alternatively, which means there is just one GPU working at the same time.
For example:
Time 1:
|===============================+======================+======================|
|   0  NVIDIA A100-PCI...  Off  | 00000000:36:00.0 Off |                    0 |
| N/A   33C    P0    61W / 250W |   9267MiB / 40960MiB |      0%      Default |
|                               |                      |             Disabled |
+-------------------------------+----------------------+----------------------+
|   1  NVIDIA A100-PCI...  Off  | 00000000:37:00.0 Off |                    0 |
| N/A   57C    P0   247W / 250W |  12997MiB / 40960MiB |    100%      Default |
|                               |                      |             Disabled |
+-------------------------------+----------------------+----------------------+
Time 2:
|===============================+======================+======================|
|   0  NVIDIA A100-PCI...  Off  | 00000000:36:00.0 Off |                    0 |
| N/A   38C    P0   242W / 250W |  13231MiB / 40960MiB |     99%      Default |
|                               |                      |             Disabled |
+-------------------------------+----------------------+----------------------+
|   1  NVIDIA A100-PCI...  Off  | 00000000:37:00.0 Off |                    0 |
| N/A   48C    P0    63W / 250W |  12997MiB / 40960MiB |      0%      Default |
|                               |                      |             Disabled |
+-------------------------------+----------------------+----------------------+
And here are some logs from the nerfstudio:
Step (% Done)       Train Iter (time)    ETA (time)           Train Rays / Sec
-----------------------------------------------------------------------------------
30020 (100.07%)     1 s, 16.704 ms       23 h, 59 m, 40 s     277.02 K
30030 (100.10%)     961.287 ms           23 h, 59 m, 32 s     286.20 K
30040 (100.13%)     957.287 ms           23 h, 59 m, 22 s     296.96 K
30050 (100.17%)     953.794 ms           23 h, 59 m, 13 s     292.95 K
30060 (100.20%)     957.893 ms           23 h, 59 m, 3 s      281.41 K
30070 (100.23%)     953.860 ms           23 h, 58 m, 54 s     287.69 K
30080 (100.27%)     952.990 ms           23 h, 58 m, 44 s     285.33 K
30090 (100.30%)     957.117 ms           23 h, 58 m, 34 s     282.15 K
30100 (100.33%)     957.164 ms           23 h, 58 m, 25 s     289.42 K
30110 (100.37%)     960.392 ms           23 h, 58 m, 15 s     286.27 K
I installed in2n inside the official docker image of nerfstudio.

Ah yes sorry, they do only run alternately, so it won't speed up training by running the two processes in parallel. The reason we say it will increase speed is if your GPU util is near max, it slows down overall training. Hopefully that makes sense.


fix: use full URL for workspace OG image

Description

Generates a full URL for the workspace OG image instead of just the path

Related Tickets & Documents

Fixes #2994
Mobile & Desktop Screenshots/Recordings

Steps to QA

Find a public workspace URL
Paste the deploy preview into X to compose a post
Note that OG image is displayed in the preview

Tier (staff will fill in)

[ ] Tier 1
[ ] Tier 2
[ ] Tier 3
[x] Tier 4

[optional] Are there any post-deployment tasks we need to perform?
[optional] What gif best describes this PR or how it makes you feel?

It works! Full URL ftw!

Works for me too! I used a similar pattern we've been using in other places.


Cob3-6 twist controller configuration

Merge this pull request with this one: https://github.com/ipa320/schunk_modular_robotics/pull/176

finalized in #564 - the self-collision-links were not correct for cob3-6...
As this feature is only beta, it's ok to have an empty file


Permissions for az role assignment create

The "Configure ACR Authentication" section has a command "az role assignment create ..." that requires the permission "Microsoft.Authorization/roleAssignments/write".  This permission, to my knowledge, only exists for owners of the subscription/resource group/resource.  Can we add a callout in this section to make sure the user executing the command has the "Microsoft.Authorization/roleAssignments/write" or "Microsoft.Authorization/*/write" permission?  We could also suggest using PIM to set up a workflow to elevate privileges if the user is restricted from the "Owner" role in their subscription.
Thanks!

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: d4af71a4-648e-580f-7e86-94ce05196de5
Version Independent ID: 134b8ba0-b085-076a-d2e1-16d0ddff5586
Content: Kubernetes on Azure tutorial - Deploy a cluster
Content Source: articles/aks/tutorial-kubernetes-deploy-cluster.md
Service: container-service
GitHub Login: @iainfoulds
Microsoft Alias: iainfou

Thanks for the feedback! I have assigned the issue to the content author to investigate further and update the document as appropriate.

You also can't create a service principal (SP) without similar elevated permissions. That's partly why an SP would be created ahead of time, as az aks create will fail if the user doesn't have the required permissions to create it themselves. The expectation is that in this tutorial series you'd be doing this in a testing environment / subscription where you have permissions to az ad sp create and az role assignment create, or that you'd be engaging the required identity teams to prepare these for you.
I can look to include this in a future doc if there's additional feedback on this.
For now, @Karishma-Tiwari-MSFT, #please-close

This is a very confusing construct to many users, the creation of a SP is an AAD construct managed outside the subscription...I could be an owner of my resource and not be able to create the SP (if my org locks that capability down).  The perfect storm is when I'm a contributor to my resources and I can't do either.
I think a link to these docs would clear up any confusion.
https://docs.microsoft.com/en-us/powershell/azure/create-azure-service-principal-azureps?view=azps-1.7.0
https://docs.microsoft.com/en-us/azure/active-directory/develop/howto-create-service-principal-portal#required-permissions


Why is the median survival time infinite

Hi @woshigemi, because the survival curve never passes y=0.5.

ok,Thank you very much


create more questions

🚀 What is the feature?
Create more questions, such that we can further improve the capabilities of our app.
For now, create 3 more questions.
Note: if you are not sure where to add the questions, scroll through the available files in the repository.
ℹ Additional info
Add a screenshot of your changes - if helpful.
Make sure the app works, otherwise the PR cannot be approved.
Link the PR with this issue (in the right panel "Development" -> select issue).

Can I try working on this one ?

Yes please! There you go 🕺

Hey, just a small doubt, you have mentioned to add a screenshot, Should I add a screenshot of the Webpage or my code ?

Normally as you see fit, but for this one, it's not necessary.

@nithindante where did you get the questions?

@mdiab1  I just got some random info from google


Drag and Drop Overhaul

Drag and drop for Tidy 5e Sheets could use some updates.
There is not a specific plan in place yet, but these are some suggestions that have come up when working on other efforts:
Dragging and Dropping Between Sheets: Move, Don't Copy
When dragging items from a vehicle to a character sheet or a character sheet to a group sheet, for example, it would be ideal if the item were moved rather than copied over, from a user standpoint. The implementation details of this will need to be carefully specified such that we are not attempting to remove items on Compendia or other places.
Dragging an Item With More Than 1 in Quantity, Show Quantity Dialog
Sometimes, party members want to drag a certain quantity of a particular item to another sheet. When a user drags more than one of an item, show a dialog prompting the quantity, defaulted to the max amount available. Some careful consideration should be made for validating input and ensuring the dialog handles when item quantity changes for unrelated reasons.
Drag Over Should Preview Changes
When dragging an item over a list or table, it would be ideal if there were a visual preview system in place, similar to Pathfinder 2e in Foundry.
Under the Hood: Drag and Drop Management / Specifications
Tidy currently defers a nontrivial amount of technical implementation of drag-and-drop to the underlying 5e default sheets. Unfortunately, this has the side effect of requiring Tidy to occasionally override the drag/drop behaviors because of HTML structure not being in the expected place. Rather than continue in this override-based approach, it would be ideal to identify all drag-and-drop scenarios, form a specification for Tidy, and implement Tidy drag and drop handling all its own, allowing for more involved and elaborate implementations of drag and drop behaviors. These specs can then be transformed into automated tests to ensure Tidy is adhering to the specifications set out.
These specs could be stored on the Tidy github wiki and maintained there. All of the improvements set out in this github issue would appear in the specs as expectations of functionality.

Pinging @nolorfin related to #229
I had a chance to look at how Pathfinder 2e does its sheets. They indeed move items when dragging and dropping between sheets. I have concluded that Tidy can and should take your advice about actually moving items instead of duplicating them on drag and drop.
This represents a rather sizable upgrade that is honestly needed for my sheets module, if I am to provide a better/stabler user experience.
There are a lot of projects on the table right now, and I have to get the rewrite to v1 and overtake original Tidy.
This will be a post-v1 project, but I add it here so that I can be sure to further plan it out, leading up to the day when I can do this project.


During pipx install shortnames.conf is not being installed

Ensure the file is installed and working for client-side shortnames

pipx is dropping this file for some reason.

pip install installs it.

.local//pipx/venvs/ramalama/share/ramalama/shortnames.conf
This is an easy fix, I'll open a PR


Python / RuntimeError: No device connected

Hello,
everything worked fine 3 month ago...
Now i am getting this error message even on the easiest way to implement the camera.
The software "RealSense Viewer" can find the camera and shows all streams.
Does anybody have an idea?
|librealsense|2.54.2 RELEASE|
Inten RealSense L515
Firmware <IP_ADDRESS>
Windows
Python 3.11.9
Traceback (most recent call last):
File "C:\Daten\OneDrive\Python\Objekterkennung\515Test.py", line 3, in
profile = pipe.start()
^^^^^^^^^^^^
RuntimeError: No device connected
import pyrealsense2 as rs
pipe = rs.pipeline()
profile = pipe.start()
try:
for i in range(0, 100):
frames = pipe.wait_for_frames()
for f in frames:
print(f.profile)
finally:
pipe.stop()
Same problem with this coding:
self.pipeline = rs.pipeline()
    config = rs.config()
#    config.enable_stream(rs.stream.color, 1280, 720, rs.format.bgr8, 30)
#    config.enable_stream(rs.stream.depth, 640, 480, rs.format.z16, 30)

    config.enable_stream(rs.stream.color, 640, 480, rs.format.bgr8, 20)
    config.enable_stream(rs.stream.depth, 640, 480, rs.format.z16, 20)

    self.color_frame = True
    self.depth = None

    # Start streaming
    self.pipeline.start(config)

Hi @frankahland  In your config instructions in the script above, the FPS is set to 20.  It should be 30.  I note that you have the same camera detection problem with the simple test script though.
Is the RealSense Viewer closed down when you launch your script, please?
Have you changed your Python 3 version since the last time that the script worked for you?
Is the L515 detected in Python if you unplug the micro-sized end of the USB cable from the base of the camera, turn the connector around the other way and re-insert it?

Thanks for your answer!
Sorry, the 20fps was only one of many tries to get it working. Also 30fps does not work as it was set this morning - the same code that used to work 3 month ago and which i find in any examples in google.
yes, RealSense Viewer is closed.
3 month ago i ran Python 3.11.4 (or so).
One week ago i deinstalled Python and installed 3.7 first and then 3.11 (because of another project).
So this morning i started it with python 3.11.
When today it did not work with the RealSense i upgraded to 3.11.9 (the latest 3.11 version)
And still not working.
The package pyrealsense2 was installed smoothly after the installation.

I turned the connector and still the same problem.

Thank you very much for the information.
Can you confirm whether you installed from a package with the pip install pyrealsense2 installation method, please?
Did you uninstall Python 3.7 before installing Python 11 to ensure that you do not have two Python versions on the same computer that might confuse pyrealsense2 about which one one to use?
If you are okay with using Python 3.7, installing the 2.54.2 RealSense SDK on Windows with the Intel. RealSense.SDK-WIN10 installer file will also install the pyrealsense2 wrapper for use with 3.7.

Thanks a lot Marty,
I installed it in the IDE PyCharm with right mouse click on the missing import. Now deleted it and installed it again with
pip install pyrealsense2.
It installed this version. Is this correct for Python 3.11.9?
PS C:\Daten\OneDrive\Python\Objekterkennung> pip install pyrealsense2
Collecting pyrealsense2
Using cached pyrealsense2-<IP_ADDRESS>86-cp311-cp311-win_amd64.whl.metadata (1.9 kB)
Using cached pyrealsense2-<IP_ADDRESS>86-cp311-cp311-win_amd64.whl (2.8 MB)
Installing collected packages: pyrealsense2
Successfully installed pyrealsense2-<IP_ADDRESS>86
Yes, i used uninstaller to remove Python 3.7. But after your idea i searched for files and found pyrealsense2 in other directories. I deleted them.
I need to go for Python 3.11.+, so 3.7 would not be an option.
I restarted Windows, used different USB ports,
Still the same error.
Maybe of interest: After starting the python script it takes 10 seconds to get the error message "RuntimeError: No device connected"
Do you have another idea?

The device manager shows a very old driver...

I uninstalled the SDK and reinstalled it - now the viewer does not find the camera anymore.

I note that your RealSense Viewer version is 2.55.1.  Support for the L515 camera model has been removed from 2.55.1 onwards as L515 is a retired camera model.  You can install the 2.54.2 version of the SDK and Viewer that still supports L515 using the Intel.RealSense.SDK-WIN10 installer file at the link below.
https://github.com/IntelRealSense/librealsense/releases/tag/v2.54.2

If you only want the RealSense Viewer, download and run Intel.RealSense.Viewer.exe from the Assets list.  This Viewer must be run from the location that you downloaded the .exe file to and not with a Windows desktop launch shortcut icon.

Hello Marty,
thanks a lot. That version verion hepled. The viewer is viewing again.
And it was the same reason for python not to run anymore. The new installation of python made me install the latest pyrealsense2 which also does not support the L515 anymore.
pip install pyrealsense2==
showed the available packages:
versions: <IP_ADDRESS>16, <IP_ADDRESS>17, <IP_ADDRESS>84, <IP_ADDRESS>86)
So i installed the version before the newest and it works!
pip install pyrealsense2==<IP_ADDRESS>84

It would be great to raise an error message if a once supported device is found but not supported anymore.
I searched for hours.

You are very welcome.  I'm pleased to hear that 2.54.2 is working for you.  Thanks very much for the update!
The Intel RealSense team has already received a request to display a message about L515 not being supported so that RealSense users do not lose time.  They are working on it.


Fixed null pointer

caused when non penis person use strap on in scene

Good catch, thank you ^^. If you know any scenes where that happens, tell me :o


Feature request

Is your feature request related to a problem? Please describe.
In the win11 system, it is very troublesome to click on the software interface every time you share a file.  So it will be very convenient if you can share the file when you select it in 'explorer.exe'.
Describe the solution you'd like
I hope that in the win11 system, the software supports the sharing mode in the pop-up sharing box when you select a file in the 'Explorer.exe' and right-click the share button.
At present, the same type of software named intel unison already supports this function.
Describe alternatives you've considered
No response
Additional context

Duplicate of #115


Allow to provide defaults and overwrite for ProbotOctokit instantiation

Feature Request
Is your feature request related to a problem? Please describe.
I would like use probot with a custom github enterprise version that still require prview mode for check api.
The used octokit does not have preview enabled by default anymore for checks api but would allow to enable it,
by using the previews parameter in the contructor.
Probot docu describes how to provide custom ProbotOctokit.
But when I create a custom ProbotOctokit I loose every plugin provided by probot.
Describe the solution you'd like
Probot has a function has the createProbot to allow to instantiate createProbot with defaults and overwrites.
The same way ProbotOctokit could be created. Please can you provide a kind of createProbotOctokit function
that allows to provide overrides and default values and instantiate Oktokit in the usual probot way?
createProbotOktokit.ts in src/octokit
export function createProbotOktokit({
    overrides = {},
    env = process.env,
}: CreateProbotOktokitOptions = {}) {

    const defaultOptions = {
        authStrategy: createProbotAuth,
        throttle: {
            onAbuseLimit: (
                retryAfter: number,
                options: RequestOptions,
                octokit: Octokit
            ) => {
                octokit.log.warn(
                    `Abuse limit hit with "${options.method} ${options.url}", retrying in ${retryAfter} seconds.`
                );
                return true;
            },
            onRateLimit: (
                retryAfter: number,
                options: RequestOptions,
                octokit: Octokit
            ) => {
                octokit.log.warn(
                    `Rate limit hit with "${options.method} ${options.url}", retrying in ${retryAfter} seconds.`
                );
                return true;
            },
        },
        userAgent: `probot/${VERSION}`,
    };

    const probotOktokitOptions = {
        ...defaultOptions,
        ...overrides,
    };

    return Octokit.plugin(
        throttling,
        retry,
        paginateRest,
        legacyRestEndpointMethods,
        enterpriseCompatibility,
        probotRequestLogging,
        config
    ).defaults((instanceOptions: any) => {
        // merge throttle options deeply
        const options = Object.assign({}, probotOktokitOptions, instanceOptions, {
            throttle: instanceOptions.throttle
                ? Object.assign({}, defaultOptions.throttle, instanceOptions.throttle)
                : defaultOptions.throttle,
        });

        return options;
    });

I would like use probot with a custom github enterprise version that still require prview mode for check api.
The used octokit does not have preview enabled by default anymore for checks api but would allow to enable it,
by using the previews parameter in the contructor.

as an alternative, you can also set the preview per request. You can pass
  mediaType: {
    previews: ["preview-name-here"],
  },

along other request options to enable a preview

Probot docu describes how to provide custom ProbotOctokit.
But when I create a custom ProbotOctokit I loose every plugin provided by probot.

You can extend ProbotOctokit
import { ProbotOctokit } from "probot"
const MyOctokit = ProbotOctokit.plugins(myPlugin1, myPlugin2, ...).defaults(myDefaults)


Swift version 5.7.2 package is broken on Ubuntu 20.04 LTS

I just tried out the Swift 5.7.2 release package for Ubuntu 20.04 LTS and it seems to be missing some lldb stuff.
Traceback (most recent call last):
  File "<string>", line 1, in <module>
ModuleNotFoundError: No module named 'lldb'
lldb version 13.0.0 (https://github.com/apple/llvm-project.git revision c41f13252ed4b49f246729b4d91ff521d5a6bf9d)
Swift version 5.7.2 (swift-5.7.2-RELEASE)

All the required dependencies for Ubuntu 20.04 LTS as per download instructions are installed.
So either the documentation is missing information for additional packages, or the tarball is missing contents.

Same result for Swift 5.8.1.  Ubuntu 20.04 (LTS) has python 3.10, not 3.8.
(Should bug be renamed? e.g.,In Swift on ubuntu 20.04, lldb expects python 3.8 instead of the available 3.10?)
(1) lldb error when looking for libpython 3.8 (when 3.10 is installed):
libpython3.8.so.1.0: cannot open shared object file: No such file or directory
(2) apt-get reports python3.8 as likely obsoleted
(3) Using ln to alias 3.8 to 3.10 makes lldb library workable
albeit with module errors from CLI
Workaround from vscode-swift 318
export libRoot='/usr/lib/x86_64-linux-gnu/libpython'
sudo ln -s "${libRoot}3.10.so.1.0" "${libRoot}3.8.so.1.0"

After ln, errors do show in CLI:
Traceback (most recent call last):
  File "<string>", line 1, in <module>
ModuleNotFoundError: No module named 'lldb'
lldb version 13.0.0git (https://github.com/apple/llvm-project.git revision f0fb631dd1a3a2988b23ba5057cd9106713cd0b4)
Swift version 5.8.1 (swift-5.8.1-RELEASE)

But with this workaround VSCode is able to use lldb (via library?), albeit likely with bugs.
See also swift 60255 comment

I think this issue should be resolved in the latest toolchains (I think It's related to addition of installation of python3-lldb-13 or another python lib into the toolchains and Dockerfiles and all).


Not able to install Models, Install of mtb in ComfyUI still shows missing nodes[bug]

Describe the bug
I'm trying to use the mtb nodes.  I've installed through the manager, but ComfyUI still shows the following nodes missing.
When loading the graph, the following node types were not found:
Face Swap (mtb)
Load Face Enhance Model (mtb)
Load Face Analysis Model (mtb)
Load Face Swap Model (mtb)
Restore Face (mtb)
Nodes that have failed to load will show as red on the graph
I've tried uninstalling and reinstalling mtb, but received the same error each time.
I thought perhaps that it was because the models were missing so I tried the python download_models.py script in the script folder, but I received the following error message:
ModuleNotFoundError: No module named 'requests'
I also tried to install the dependencies, but received this error when running python get_deps.py
\ComfyUI\custom_nodes\comfy_mtb\scripts\get_deps.py", line 5, in
from rich.console import Console
ModuleNotFoundError: No module named 'rich'
Reproduction
No response
Expected behavior
No response
Platform and versions
Windows

Console output
[comfy_mtb] | INFO -> Some nodes failed to load:
        Failed to import module faceenhance because ModuleNotFoundError: No module named 'gfpgan'
        Failed to import module faceswap because ModuleNotFoundError: No module named 'insightface'
        Failed to import module image_interpolation because ModuleNotFoundError: No module named 'frame_interpolation.eval'

Check that you properly installed the dependencies.
If you think this is a bug, please report it on the github page (https://github.com/melMass/comfy_mtb/issues)

Additional context
No response

I've been having the same issue. I hope that some solution is eventually attained.

@s-marcelle Also using the manager?
Because all of the logs from the OPs report suggest that not, gfpgan and frame_interpolation are shipped with mtb (in the extern folder), you must clone the repository with submodules (comfy manager does it all for you)

Yes I installed via the manager as instructed....
And I am also experiencing the same as the person who raised the issue.

And I am also experiencing the same as the person who raised the issue.

The OP has multiple issues:

none of the script they run manually should be (get_deps, model_downloads), they are there useful for people who can simply read them, but not mentioned in the base instructions for this reason. (I'm pretty sure request comes with comfy portable btw). The models can be downloaded from the comfy manager directly.
The project gets downloaded without the submodules (gfpgan and frame_interpolation), this is apparently a thing on very old git, I just learned that from DataIt after this issue was posted on the element board.

That's why I usually suggest openining dedicated issues with your own log unless it's not a generic issue but "not able to install" is too broad and it's unclear what you mean by "same" here

Ok I will share my issues

I'm not sure if a solution has been found?  You never responded to my request.  Would you clarify what you want me to do to install this extension?  I initially used control manager and installed Mtb.  I looked at the download_models script, but I'm not sure if you're asking me to manually download each one?  You say that the control manager automatically downloads all the models, but that's not happening for me.  Help would be appreciated.

You are having multiple unrelated things happening, I did address your points in my answers...
Here you can click Install models and look for the ones you need, I plan to add a new UI in /mtb's endpoint for those who can't either run my model download script or Comfy Manager's download ui.

Just check my previous answers but something went wrong during your install and it did not pull the submodules (gfpgan, frame_interpolation)
For insightface you can try to manually running this, but the install script handle much more:
pip install https://github.com/melMass/comfy_mtb/releases/download/v0.1.3/insightface-0.7.3-cp310-cp310-win_amd64.whl

Just did a fresh install of comfy and installed the node from manager and still does not install properly.
here is the cmd text.
g:\ComfyUI_windows_portable>.\python_embeded\python.exe -s ComfyUI\main.py --windows-standalone-build
** ComfyUI start up time: 2023-08-25 12:32:42.819610
#######################################################################
[ComfyUI-Manager] Starting dependency installation/(de)activation for the extension
ComfyUI-Manager: EXECUTE => ['g:\ComfyUI_windows_portable\python_embeded\python.exe', 'install.py']
Execute install/(de)activation script for 'g:\ComfyUI_windows_portable\ComfyUI\custom_nodes\comfy_mtb'
[!] Traceback (most recent call last):
[!]   File "g:\ComfyUI_windows_portable\ComfyUI\custom_nodes\comfy_mtb\install.py", line 26, in
[!]     elif "python_embeded" in executable:
[!] TypeError: argument of type 'WindowsPath' is not iterable
install/(de)activation script failed: g:\ComfyUI_windows_portable\ComfyUI\custom_nodes\comfy_mtb
[ComfyUI-Manager] Startup script completed.
#######################################################################
Prestartup times for custom nodes:
0.2 seconds: G:\ComfyUI_windows_portable\ComfyUI\custom_nodes\ComfyUI-Manager
Total VRAM 12288 MB, total RAM 32669 MB
xformers version: 0.0.21
Set vram state to: NORMAL_VRAM
Device: cuda:0 NVIDIA GeForce RTX 3060 : cudaMallocAsync
Using xformers cross attention
Web extensions folder found at G:\ComfyUI_windows_portable\ComfyUI\web\extensions\ComfyLiterals
Loading: ComfyUI-Impact-Pack (V3.24.5)
Loading: ComfyUI-Impact-Pack (Subpack: V0.2)
Loading: ComfyUI-Manager (V0.26.2)
ComfyUI Revision: 1338 [e3d0a9a4]
Failed to auto update Quality of Life Suit
QualityOfLifeSuit_Omar92_DIR: G:\ComfyUI_windows_portable\ComfyUI\custom_nodes\ComfyUI-QualityOfLifeSuit_Omar92
Traceback (most recent call last):
File "g:\ComfyUI_windows_portable\ComfyUI\nodes.py", line 1693, in load_custom_node
module_spec.loader.exec_module(module)
File "", line 883, in exec_module
File "", line 241, in call_with_frames_removed
File "G:\ComfyUI_windows_portable\ComfyUI\custom_nodes\comfyui-reactor-node_init.py", line 24, in
from .nodes import NODE_CLASS_MAPPINGS, NODE_DISPLAY_NAME_MAPPINGS
File "G:\ComfyUI_windows_portable\ComfyUI\custom_nodes\comfyui-reactor-node\nodes.py", line 3, in
from scripts.faceswap import FaceSwapScript, get_models
File "G:\ComfyUI_windows_portable\ComfyUI\custom_nodes\comfyui-reactor-node\scripts\faceswap.py", line 13, in
from scripts.swapper import UpscaleOptions, swap_face
File "G:\ComfyUI_windows_portable\ComfyUI\custom_nodes\comfyui-reactor-node\scripts\swapper.py", line 10, in
import insightface
ModuleNotFoundError: No module named 'insightface'
Cannot import G:\ComfyUI_windows_portable\ComfyUI\custom_nodes\comfyui-reactor-node module for custom nodes: No module named 'insightface'
[comfy_mtb] | WARNING -> Web extensions folder at G:\ComfyUI_windows_portable\ComfyUI\web\extensions\mtb is not a symlink, if updating please delete it before
[comfy_mtb] | STATUS -> Some nodes failed to load:
Failed to import module faceenhance because ModuleNotFoundError: No module named 'basicsr'
Failed to import module faceswap because ModuleNotFoundError: No module named 'insightface'
Failed to import module generate because ModuleNotFoundError: No module named 'qrcode'
Failed to import module image_interpolation because ModuleNotFoundError: No module named 'tensorflow'
Check that you properly installed the dependencies.
If you think this is a bug, please report it on the github page (https://github.com/melMass/comfy_mtb/issues)
[comfy_mtb] | STATUS -> Loaded the following nodes:
Animation Builder (mtb): Convenient way to manage basic animation maths at the core of many of my workflows
Smart Step (mtb): Utils to control the steps start/stop of the KAdvancedSampler in percentage
Styles Loader (mtb): Load csv files and populate a dropdown from the rows (à la A111)
Interpolate Clip Sequential (mtb): -
Bbox From Mask (mtb): From a mask extract the bounding box
Bbox (mtb): The bounding box (BBOX) custom type used by other nodes
Crop (mtb): Crops an image and an optional mask to a given bounding box
Uncrop (mtb): Uncrops an image to a given bounding box
Debug (mtb): Experimental node to debug any Comfy values, support for more types and widgets is planned
Save Tensors (mtb): Save torch tensors (image, mask or latent) to disk, useful to debug things outside comfy
Deep Bump (mtb): Normal & height maps generation from single pictures
String Replace (mtb): Basic string replacement
Fit Number (mtb): Fit the input float using a source and target range
Get Batch From History (mtb): Very experimental node to load images from the history of the server.
Any To String (mtb): Tries to take any input and convert it to a string
Color Correct (mtb): Various color correction methods
Image Compare (mtb): Compare two images and return a difference image
Blur (mtb): Blur an image using a Gaussian filter.
Mask To Image (mtb): Converts a mask (alpha) to an RGB image with a color and background
Colored Image (mtb): Constant color image of given size
Image Premultiply (mtb): Premultiply image with mask
Image Resize Factor (mtb): Extracted mostly from WAS Node Suite, with a few edits (most notably multiple image support) and less features.
Save Image Grid (mtb): Save all the images in the input batch as a grid of images.
Load Image From Url (mtb): Load an image from the given URL
Save Gif (mtb): Save the images from the batch as a GIF
Export With Ffmpeg (mtb): Export with FFmpeg (Experimental)
Latent Lerp (mtb): Linear interpolation (blend) between two latent vectors
Image Remove Background Rembg (mtb): Removes the background from the input using Rembg.
Float To Number (mtb): Node addon for the WAS Suite. Converts a "comfy" FLOAT to a NUMBER.
Int To Bool (mtb): Basic int to bool conversion
Int To Number (mtb): Node addon for the WAS Suite. Converts a "comfy" INT to a NUMBER.
Transform Image (mtb): Save torch tensors (image, mask or latent) to disk, useful to debug things outside comfy
Load Image Sequence (mtb): Load an image sequence from a folder. The current frame is used to determine which image to load.
Save Image Sequence (mtb): Save an image sequence to a folder. The current frame is used to determine which image to save.
Traceback (most recent call last):
File "g:\ComfyUI_windows_portable\ComfyUI\nodes.py", line 1693, in load_custom_node
module_spec.loader.exec_module(module)
File "", line 883, in exec_module
File "", line 241, in call_with_frames_removed
File "G:\ComfyUI_windows_portable\ComfyUI\custom_nodes\comfy_mtb_init.py", line 183, in
from .endpoint import endlog
File "G:\ComfyUI_windows_portable\ComfyUI\custom_nodes\comfy_mtb\endpoint.py", line 9, in
import requirements
ModuleNotFoundError: No module named 'requirements'
Cannot import G:\ComfyUI_windows_portable\ComfyUI\custom_nodes\comfy_mtb module for custom nodes: No module named 'requirements'
Total VRAM 12288 MB, total RAM 32669 MB
xformers version: 0.0.21
Set vram state to: NORMAL_VRAM
Device: cuda:0 NVIDIA GeForce RTX 3060 : cudaMallocAsync
WAS Node Suite: OpenCV Python FFMPEG support is enabled
WAS Node Suite Warning: ffmpeg_bin_path is not set in G:\ComfyUI_windows_portable\ComfyUI\custom_nodes\was-node-suite-comfyui\was_suite_config.json config file. Will attempt to use system ffmpeg binaries if available.
WAS Node Suite: Finished. Loaded 192 nodes successfully.
    "The future depends on what you do today." - Mahatma Gandhi

Import times for custom nodes:
0.0 seconds: G:\ComfyUI_windows_portable\ComfyUI\custom_nodes\ComfyLiterals
0.0 seconds: G:\ComfyUI_windows_portable\ComfyUI\custom_nodes\ComfyUI-QualityOfLifeSuit_Omar92
0.0 seconds: G:\ComfyUI_windows_portable\ComfyUI\custom_nodes\ComfyUI-Custom-Scripts
0.0 seconds (IMPORT FAILED): G:\ComfyUI_windows_portable\ComfyUI\custom_nodes\comfyui-reactor-node
0.0 seconds: G:\ComfyUI_windows_portable\ComfyUI\custom_nodes\Derfuu_ComfyUI_ModdedNodes
0.3 seconds: G:\ComfyUI_windows_portable\ComfyUI\custom_nodes\ComfyUI-Manager
0.6 seconds (IMPORT FAILED): G:\ComfyUI_windows_portable\ComfyUI\custom_nodes\comfy_mtb
0.9 seconds: G:\ComfyUI_windows_portable\ComfyUI\custom_nodes\was-node-suite-comfyui
6.6 seconds: G:\ComfyUI_windows_portable\ComfyUI\custom_nodes\ComfyUI-Impact-Pack
Starting server
To see the GUI go to: http://<IP_ADDRESS>:8188
FETCH DATA from: G:\ComfyUI_windows_portable\ComfyUI\custom_nodes\ComfyUI-Manager\extension-node-map.json
Error: OpenAI API key is invalid OpenAI features wont work for you
QualityOfLifeSuit_Omar92::NSP ready

I introduced this issue when trying to handle space in path (#73)
I just fixed it

Did it work :) ?

No, unfortunately I've given up hope for now. I've tried clean installs, manually installing each component or/and using the custom manager. I'm going to try again in a few weeks in hopes that an updated version may help. Ty for trying to fix it.

Understandable! I will gather the recent feedbacks to try and fix some of these, I linked other projects for the faceswap and facerestore nodes in the README since most recent errors seems related to that, i think my install script is doing something that trip Comfy Manager

Anyone got a solution for this? I tried almost a dozen clean install, always the same error.

@cn112cn Please open a dedicated issue, both points from the OP's issue have been addressed in https://github.com/melMass/comfy_mtb/issues/71#issuecomment-1689690343 and https://github.com/melMass/comfy_mtb/issues/71#issuecomment-1692945975. The unrelated issue reported by  that has also been fixed since.
Since I still can't mind-read don't hesitate to join some log and informations about you system / Comfy install it saves time for spotting issues

So i was able to fix this issue on my install by uninstalling the modules that are not found and reinstalling them with the install script.
My error was:
Failed to import module image_interpolation because ModuleNotFoundError: No module named 'insightface'
So i went to custom_nodes\comfy_mtb, open PowerShell
Uninstall insightface
enter path\to\python_embeded\python.exe -m pip uninstall insightface
Reinstall using install.py
enter path\to\python_embeded\python.exe install.py
I did this for every ModuleNotFoundError Comfy threw out and was able to fix and load all mtb modules.
I do have a local Python as well as the embedded. The removed modules were installed under my local and now reinstalled under the embedded. So could it be some kind of PATH issue?

Mine was working up until 6 7 hours ago. Manager updated itself and MiT and boom, there is no faceswap anymore and all the nods shows missing.

Hi,
The problematic nodes are removed in the next version as comfy portable is now on python 11, more precisely they are optional, you can learn more about it in the readme where I link to alternatives: https://github.com/melMass/comfy_mtb#optional-nodes


set an element with `Modal.setAppElement(el) to element in virtual dom

I don't want to attach this to an element that exists on in the html.  I want to attach it to a div that is being created in a render (we are using react grid layout).  The message is saying that the element does not exist and when I look at the console it is true, it does not.
How do I make this wait until the component is actually rendered?

It's been a while since there was any traction on this issue.  I'm going to close it assuming it's no longer an issue.  If it is feel free to re-open.  I'm hoping the changes we are discussin gin #287 might be of use here.


Do not log a period after an image URL

Description

Airflow across all browsers will render a URL at the end of a sentence as a URL with a period at the end. I encountered this while looking into #759. In the logs, the message [2022-10-01, 00:17:59 UTC] {requester.py:69} WARNING - Unable to request URL: https://cdn.stocksnap.io/img-thumbs/960w/MF8LSXR049.jpg.  Status code: 403 will create a URL with the value https://cdn.stocksnap.io/img-thumbs/960w/AMEYDHBGJF.jpg., which will fail to resolve. However, the URL https://cdn.stocksnap.io/img-thumbs/960w/AMEYDHBGJF.jpg (note the missing period at the end) does resolve.
We should remove the period after the URL in this log line:
https://github.com/WordPress/openverse-catalog/blob/0072114ea479b378a94e1144340935023acbdf3d/openverse_catalog/dags/common/requester.py#L69-L72
Ideally, we'd also try to remove any other instances of this from the repo. A cursory search I did brought up a few more cases:
$ rg -e "url.*?}\."
archive/providers/commoncrawl/Provider.py
354:                    logging.warning('Content not found for url: {}, warc file: {}, offset: {}, length: {}.'.format(data[0].strip(), data[1].strip(), data[2].strip(), data[3].strip()))

openverse_catalog/dags/common/requester.py
70:                    f"Unable to request URL: {response.url}.  "
85:            logger.error(f"Error with the request for URL: {url}.")

openverse_catalog/dags/common/urls.py
57:            f"Invalid url {url_string}, attempted upgrade: {upgraded_url}."

openverse_catalog/dags/providers/provider_api_scripts/stocksnap.py
122:        image_url = f"{IMAGE_CDN}/{img_id}.jpg"

openverse_catalog/dags/providers/provider_api_scripts/rawpixel.py
34:                f"Unable to request URL: {url}. Status code: " f"{response.status_code}"

openverse_catalog/dags/providers/provider_api_scripts/modules/etlMods.py
158:                f"Unable to request URL: {_url}. Status code:" f"{response.status_code}"

openverse_catalog/dags/common/licenses/licenses.py
225:        raise InvalidLicenseURLException(f"Failed to rewrite {derived_url}.")

openverse_catalog/dags/common/etl/scripts/ExtractCCLinks.py
59:        self.url = "https://{}.s3.amazonaws.com/crawl-data/{}/wat.paths.gz".format(

tests/factories/github/pull.json
47:      "compare_url": "https://api.github.com/repos/WordPress/openverse-frontend/compare/{base}...{head}",
192:      "compare_url": "https://api.github.com/repos/helpful-contributor/openverse-frontend/compare/{base}...{head}",

Notably:
https://github.com/WordPress/openverse-catalog/blob/0072114ea479b378a94e1144340935023acbdf3d/openverse_catalog/dags/common/requester.py#L85
https://github.com/WordPress/openverse-catalog/blob/0072114ea479b378a94e1144340935023acbdf3d/openverse_catalog/dags/common/urls.py#L57
https://github.com/WordPress/openverse-catalog/blob/0072114ea479b378a94e1144340935023acbdf3d/openverse_catalog/dags/providers/provider_api_scripts/rawpixel.py#L34
https://github.com/WordPress/openverse-catalog/blob/88322d2da852324f1147417ff8da332721a9002a/openverse_catalog/dags/providers/provider_api_scripts/modules/etlMods.py#L158
https://github.com/WordPress/openverse-catalog/blob/0072114ea479b378a94e1144340935023acbdf3d/openverse_catalog/dags/common/licenses/licenses.py#L225
Resolution

[ ] 🙋 I would be interested in resolving this bug.

Hi, I'd be interested in resolving this!

Hey @kamiwis! I'll assign it to you 😄 Let us know if you have any questions about this issue 🙂

Thank you! I submitted a PR that resolves the 6 instances you mentioned. I'm new to open-source contribution so please let me know if I can do anything differently! 🙂

The PR was perfect, thanks again for your contribution and welcome to open source! 😄


Re-enable OS verification.

This PR re-enables OS verification for test legs. Need this PR to be merged first:
https://github.com/Azure/azure-sdk-tools/pull/1371

/azp run python - core - ci

/azp run python - storage - tests


Clear page contents after dataset switch

After a user selects a new dataset, data should be reloaded on the page. Currently on the Sample Analysis page, old data persists and can be seen by the user. We should try to clear and reload all page contents after a dataset change.

https://github.com/CanDIG/ga4gh-server/pull/63 closing issue!


Shopware doesn't seem to work with AWS Elasticsearch Service (or Opendistro)

PHP Version
7.4.22
Shopware Version
<IP_ADDRESS>
Expected behaviour
I've got Shopware6 to work with Elasticsearch running in Docker (https://hub.docker.com/_/elasticsearch)
Actual behaviour
When it comes to be using AWS Elasticsearch Service or OpenDistro, I always end up with the following:
`./bin/console es:status
In StaticNoPingConnectionPool.php line 64:
No alive nodes found in your cluster
es:status
`
I can confirm Elasticsearch is running and accepting requests from the instance where Shopware is running. Config is also correct as far as I can tell.
curl<EMAIL_ADDRESS>{   "name" : "221258ba665d4c66a54ad535a94dfe7d",   "cluster_name" : "xyz...",   "cluster_uuid" : "uAHMm6Q_SXCu0M1VIB7p3Q",   "version" : {     "number" : "7.10.2",     "build_flavor" : "oss",     "build_type" : "tar",     "build_hash" : "unknown",     "build_date" : "2021-05-21T20:25:46.519671Z",     "build_snapshot" : false,     "lucene_version" : "8.7.0",     "minimum_wire_compatibility_version" : "6.8.0",     "minimum_index_compatibility_version" : "6.0.0-beta1"   },   "tagline" : "You Know, for Search" }
Config .env for Shopware as follows:
<EMAIL_ADDRESS>SHOPWARE_ES_ENABLED="1" SHOPWARE_ES_INDEXING_ENABLED="1" ...
How to reproduce
Use opendistro and/or AWS Elasticsearch Service instead of plain/pure Elasticsearch.

Tested open distro and OpenSearch. No problem so far
dev@653ee4884d4b /var/www/html/sw6 $ ./bin/console es:status
+-----------------+-----------+
| Name            | Status    |
+-----------------+-----------+
| Cluster Status  | yellow    |
| Available Nodes | 1         |
| Indexing        | completed |
+-----------------+-----------+

{
"name": "a7a349e0b372",
"cluster_name": "docker-cluster",
"cluster_uuid": "DPjmxTQpQCGkQH52WydRmw",
"version": {
"distribution": "opensearch",
"number": "1.0.0",
"build_type": "tar",
"build_hash": "34550c5b17124ddc59458ef774f6b43a086522e3",
"build_date": "2021-07-02T23:22:21.383695Z",
"build_snapshot": false,
"lucene_version": "8.8.2",
"minimum_wire_compatibility_version": "6.8.0",
"minimum_index_compatibility_version": "6.0.0-beta1"
},
"tagline": "The OpenSearch Project: https://opensearch.org/"
}

Interesting... what's the config for your container?
Have you ever gotten Shopware to work with AWS Elasticsearch Service?
The interesting part is: ES is responding via HTTP(S), so I guess no issues with that. I suppose the issue lies in my configuration. I wonder what needs to be set to make Shopware accepting Elasticsearch with authentication, but in different flavours (opendistro, opensearch) in my case.

Your URL example should work by default in the PHP client. https://www.elastic.co/guide/en/elasticsearch/client/php-api/current/host-config.html .
I would suggest you debug by own with an empty PHP project by just installing https://github.com/elastic/elasticsearch-php

It has been confirmed Shopware was not tested before with OpenSearch or the Elasticsearch Service on AWS.
Hence, an issue has been created just recently, following up a discussion on Slack:
https://issues.shopware.com/issues/NEXT-16942

Hey,
We currently don't test it on Gitlab automatically. Have you a local configuration set (best with Docker) for your Setup? I am pretty sure it is an configuration error and not an actual problem

Should be solved with https://github.com/shopware/platform/commit/d7db506d8b44264996efc169ddb3b0f3d0244c25#diff-7a31977ec68728f37d290e489c2fb803eac1fabd064f1c33a4fc0351beaac0e1

You added the option for not verifying the SSL cert, which is nice to have.
Still, Shopware doesn't work with the Elasticsearch Service on AWS, which was the reason to raise this ticket. Please have a look into the matters. In case you need more information, please get back to me any time.

In addition to that, the ticket on your end has recently been closed for being a duplicate -> https://issues.shopware.com/issues/NEXT-16942

We have another ticket NEXT-16636 which adds Opensearch to the CI currently located at the DevOps team.  From code it works

@shyim any progress to support OpenSearch and/or the AWS OpenSearch service?

Both work already

The root issue is still present. <IP_ADDRESS> and 19.0 do not connect to AWS, neither to an instance running Elasticsearch, nor to one running OpenSearch.
Would love to get into details to find a solution.

Both are working we are using AWS Opensearch in our Cloud product

I very much doubt they are. Definitely not when set up as documented, definitely not for self-hosted.
Maybe lend a helping hand ... ?
But that'll not drive money to your "Cloud product".


Question: take items from stream while value is less than a max value

Hi, I've got a quick quesiton about how to take items from an infinite stream - I'd like to be able to do something like below.
_(infiniteNumberGenerator)
  .takeWhile( (count) => {
    return count < max;
  })
  .map(...)

Is this supported with the methods or would I have to implement something?  Take does this by using slice.  I could estimate how many i need using some maths but I thought it would be nice just to have a clause that stops the stream after enough has been pulled.  Is this doable?
Thanks
Neil

Sorry, figured it out
var takeWhile = function (f) {
  return (err, x, push, next) => {
    if (err) {
      // pass errors along the stream and consume next value
      push(err);
      next();
    }
    else if (x === _.nil) {
      // pass nil (end event) along the stream
      push(null, x);
    }
    else {
      // pass on the value only if the value passes the predicate
      if (f(x)) {
        push(null, x);
        next();
      } else {
        push(null, _.nil)
      }
    }
  }
}

paired with
.consume(takeWhile((x) => {
      return x < max
    }))

Glad you worked this out, and with pure highland you're spot on what you're looking for. One note to be aware of - transducer support was added in https://github.com/caolan/highland/pull/223 and takeWhile is available as a transducer (see also https://github.com/cognitect-labs/transducers-js), so you can use that to avoid writing your own takeWhile implementation if you so prefer.

@LewisJEllis - is this something that you'd like as a pull request for highland?  Happy to add it with tests.

Probably not now, but almost definitely after 3.0 and the module system. We try to keep the core lib from becoming a 'kitchen sink', but takeWhile could easily fit in a module after 3.0. For now, we access the kitchen sink via transducers.

@LewisJEllis thanks for that, is there a ballpark for the 3.0 release?

Soon™ :wink:
Not committing to anything here, but possibly some time in the next 6 months?

PR with takeWhile #677 , thanks!


Clippy all crates

#177

Codecov Report

Merging #261 into develop will increase coverage by 0.02%.
The diff coverage is 43.03%.

@@             Coverage Diff             @@
##           develop     #261      +/-   ##
===========================================
+ Coverage    48.98%   49.01%   +0.02%
===========================================
  Files          117      116       -1
  Lines        17359    17356       -3
===========================================
+ Hits          8504     8507       +3
+ Misses        8855     8849       -6

Impacted Files
Coverage Δ

libproto/src/protos/executor.rs
0% <ø> (ø)
:arrow_up:

libproto/src/protos/snapshot.rs
0% <ø> (ø)
:arrow_up:

libproto/src/protos/blockchain.rs
13.86% <ø> (ø)
:arrow_up:

libproto/src/protos/sync.rs
0% <ø> (ø)
:arrow_up:

libproto/src/protos/response.rs
7.96% <ø> (+0.11%)
:arrow_up:

libproto/src/protos/auth.rs
0% <ø> (ø)
:arrow_up:

libproto/src/protos/communication.rs
10.86% <ø> (ø)
:arrow_up:

libproto/src/protos/consensus.rs
0% <ø> (ø)
:arrow_up:

libproto/src/protos/compact_block.rs
0% <ø> (ø)
:arrow_up:

libproto/src/protos/request.rs
3.66% <ø> (ø)
:arrow_up:

... and 61 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 150b59c...65d6c8d. Read the comment docs.

Unit tests failed.

Unit tests failed.

ok


Add downstream tester

Fixes #20.
I decided not to use --pre since it pulls in prereleases of all packages, not just the one specified.

I'm not sure how to test this other than to release and try it with jupyter_client, which will exercise all these options.

Actually, I can do that as a PR to client itself with this action included, converting this to draft


lgogdownloader: fix build

Motivation for this change
fixes https://github.com/NixOS/nixpkgs/issues/75836
cc: @alexarice
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[X] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
[X] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[X] Fits CONTRIBUTING.md.

Notify maintainers
cc @

maybe sthg to report upstream ```
Testing MemberTemplateIs/BehavesSameAsNamedIs: OK

Detail of EscapeSequenceTest/writeEscapeSequence test failure:
/build/source/src/test_lib_json/main.cpp(3370): expected == result
Expected: '[""","\","\b","\f","\n","\r","\t","\u0278","\ud852\udf62"]
'
Actual  : '[""","\","\b","\f","\n","\r","\t","ɸ","𤭢"]
'
101/102 tests passed (1 failure(s))
make[2]: *** [src/test_lib_json/CMakeFiles/jsoncpp_test.dir/build.make:117: src/test_lib_json

upstream issue https://github.com/open-source-parsers/jsoncpp/pull/1120

seems like a patch is already available for jsoncpp in the issue you mentioned. You can update the jsonccp package here or contact the maintainers.

sure! I've added the patch for aarch64

thanks !


error:   FRAMES_MISSING_FOR_TRACK

Hi,
I  uploaded the video an audio to KVS and had a error.
error:    "ErrorCode":"FRAMES_MISSING_FOR_TRACK","ErrorId":4011
what's the reason make it ?

Hi @cigiled ,
Can you confirm if the media has both audio and video stream?
Also, could you provide the following details:

Which sample application or gst-launch-1.0 command you are using to send the media stream?
what is the type of media you are trying to send to KVS? Is it RTSP, webcam or file?

Thanks

Hi,  Thanks.
I create 2 pthreads for video and audio and uploading them to KVS, I do not call the gstreamer interface.
the video format is h264, the  audio format is aac.  i get them form a MP4 file and by runing ffmpeg order to  extract .
what's the reason make it ?

Hi @cigiled
Were you able to refer the audio video sample kinesis_video_gstreamer_audio_video_sample_app.cpp
that demonstrates how to send frames to KVS SDK using the putFrame helper

data->putFrameHelper->putFrameMultiTrack(frame, track_id == DEFAULT_VIDEO_TRACKID);

Can you send the logs also?  Thanks

Hi,
Thank you very much.
The log at the attachment.
I refered the kinesis_video_gstreamer_audio_video_sample_app.cpp and changed it, I don't call the gstremer interface.
log.txt

Hi @unicornss
Thank you very much you can help me.
My code file in the attachment.
kinesis_audio_video.txt
Thanks.

Thanks for the logs. In the meantime, could you confirm if you are able to test video only streaming (h264 frames) as in kinesis_video_gstreamer_sample_app.cpp using the putFrame .
In addition to the sample, you can also refer to the test which sends dummy frame data.
Note: Please ensure no keys are included in the logs and snippets.

Any updates on this issue you guys?

Closing the issue for now. Please reopen or create a new issue if needed.


Wrong error is thrown by ByteData.view constructor on dart2js and dartdevk

According to the ByteData.view constructor documentation

Throws RangeError if offsetInBytes or length are negative, or if offsetInBytes + (length * elementSizeInBytes) is greater than the length of buffer.

In fact, ArgumentError is thrown on dart2js and JSRangeError on dartdevk
The same issue exists for any ByteData getXXX/setXXX methods. For example
var byteData = new ByteData(5);
byteData.setUint16( 4, 0);

Produces ArgumentError instead of RangeError
Upd. This is true for any XXXList.view constructor from typed_data library as well. For example Float32x4List.view()

In DDC the JSRangeError is an ArgumentError.
@sgrekhov Can you take a look at co19/LibTest/typed_data/Float32List/Float32List.view_A06_t01.dart and co19/LibTest/typed_data/Int32List/Int32List.view_A06_t01.dart help me clarify the expectations?
According to the comments in the test file and .view() methods the expected error should be ArgumentError but the tests expects a RangeError.
cc @fishythefish These tests are also failing in dart2js for a similar reason.

@alexmarkov The tests I mentioned above are passing in the VM. Is it throwing the wrong type of error based on the comment in the view() methods?

@nshahan These expectations were wrong. According to the documentation there must be an ArgumentError. Fixed by https://github.com/dart-lang/co19/commit/28c6cdf1ca543d07662ac4dec227f2881302db40. Thank you for pointing

The documentation should he changed to not specify which Error is thrown.
The format we typically use for documenting error conditions is "must"-clauses:

The [offsetInBytes] and [length] must be non-negative,
and offsetInBytes + (length * elementSizeInBytes) must be no greater than the length of the buffer.

@sgrekhov Given that you updated the tests, is this still an issue? Was the original issue tied to the same tests?

@nshahan it is still an issue. Only
LibTest/typed_data/Float32List/Float32List.view_A06_t01.dart
LibTest/typed_data/Int32List/Int32List.view_A06_t01.dart

were updated in https://github.com/dart-lang/co19/commit/28c6cdf1ca543d07662ac4dec227f2881302db40 to expect ArgumentError instead of RangeError according to Float32List.view and Int32List.view documentation (documentation for these constructors states ArgumentError). The issue is still actual for the following tests (theyr documentation states RangeError)
ByteData.view_A05_t01.dart
ByteData.view_A05_t02.dart
ByteData.view_A05_t03.dart
Float32List.view_A05_t01.dart
Float32List.view_A05_t02.dart
Float32List.view_A05_t03.dart
Float32List.view_A06_t01.dart
Float32x4List.view_A05_t01.dart
Float32x4List.view_A05_t02.dart
Float32x4List.view_A05_t03.dart
Float64List.view_A05_t01.dart
Float64List.view_A05_t02.dart
Float64List.view_A05_t03.dart
Float64x2List.view_A05_t03.dart
getFloat32_A02_t01.dart
getFloat32_A02_t02.dart
getFloat64_A02_t01.dart
getFloat64_A02_t02.dart
getInt16_A02_t01.dart
getInt16_A02_t02.dart
getInt32_A02_t01.dart
getInt32_A02_t02.dart
getInt8_A02_t01.dart
getInt8_A02_t02.dart
getUint16_A02_t01.dart
getUint16_A02_t02.dart
getUint32_A02_t01.dart
getUint32_A02_t02.dart
getUint8_A02_t01.dart
getUint8_A02_t02.dart
Int16List.view_A05_t01.dart
Int16List.view_A05_t02.dart
Int16List.view_A05_t03.dart
Int32List.view_A05_t01.dart
Int32List.view_A05_t02.dart
Int32List.view_A05_t03.dart
Int32x4List.view_A05_t01.dart
Int32x4List.view_A05_t02.dart
Int32x4List.view_A05_t03.dart
Int8List.view_A05_t01.dart
Int8List.view_A05_t02.dart
Int8List.view_A05_t03.dart
setFloat32_A02_t01.dart
setFloat32_A02_t02.dart
setFloat64_A02_t01.dart
setFloat64_A02_t02.dart
setInt16_A02_t01.dart
setInt16_A02_t02.dart
setInt32_A02_t01.dart
setInt32_A02_t02.dart
setInt8_A02_t01.dart
setInt8_A02_t02.dart
setUint16_A02_t01.dart
setUint16_A02_t02.dart
setUint32_A02_t01.dart
setUint32_A02_t02.dart
setUint8_A02_t01.dart
setUint8_A02_t02.dart
Uint16List.view_A05_t01.dart
Uint16List.view_A05_t02.dart
Uint16List.view_A05_t03.dart
Uint32List.view_A05_t01.dart
Uint32List.view_A05_t02.dart
Uint32List.view_A05_t03.dart
Uint8ClampedList.view_A05_t01.dart
Uint8ClampedList.view_A05_t02.dart
Uint8ClampedList.view_A05_t03.dart
Uint8List.view_A05_t01.dart
Uint8List.view_A05_t02.dart
Uint8List.view_A05_t03.dart

@sgrekhov Thanks for the list of failing tests. I'll take a look and see if there is a simple fix that would bring DDC closer to the other implementations.
@lrhn Do you feel the same way about the entire typed_data API? Should we be updating the comments throughout the library so that they don't mention a specific error/exception class?

@nshahan I feel that way about the entire SDK. We shouldn't specify which Error is thrown. It's something I often fix when I touch code for other reasons, but I haven't made it a priority to fix everything once and for all. It's not a big issue, just a slight annoyance.
Errors shouldn't happen. When they do, it doesn't matter which class we use to report the error, that's just a convenience to get better and more consistent error messages (and maybe make debugging a little easier).
Specifying precisely which error is thrown is unnecessary and restrictive, and has caused us unnecessary extra work when JS compiled code needs to convert a JS exception to a specific Dart error.
We should specify exactly which Exceptions are thrown, because users are expected to catch those precisely by name.

The documentation has been updated in the typed data library to be more general. I'll close this issue since we are not planning on updating the web backends to throw these specific errors.
I opened https://github.com/dart-lang/co19/issues/955 to track updating the tests accordingly.


CI: Remove notebook metadata in pre-commit

Description
This removes all notebook metadata as a pre-commit hook.
Having the metadata in the notebooks is undesirable as stuff like the python version or the name of the used kernel are included. Different developers on different machines will create different metadata and thus merge conflicts happen.
This gets rid of that.
Implemented changes

[x] Added https://github.com/datarootsio/databooks as pre-commit hook
[x] Removed all metadata from notebooks

Type of change

[x] New feature (non-breaking change which adds functionality)

How Has This Been Tested?

[x] WorksOnMyMachine™

Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[x] Any dependent changes have been merged and published in downstream modules
[x] I have checked my code and corrected any misspellings

Codecov Report

:exclamation: No coverage uploaded for pull request base (main@c5999f0). Click here to learn what that means.
 Consider uploading reports for the commit 0662f1a to get more accurate results

Additional details and impacted files
@@           Coverage Diff            @@
##             main      #311   +/-   ##
========================================
  Coverage        ?   100.00%
========================================
  Files           ?        40
  Lines           ?      1561
  Branches        ?       346
========================================
  Hits            ?      1561
  Misses          ?         0
  Partials        ?         0

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Move to io.dropwizard.metrics dependency

The dependency (not the package) is now (in version 3.1) io.dropwizard.metrics (http://mvnrepository.com/artifact/io.dropwizard.metrics). Would you be able to upgrade?

+1

+1


Load fused model with transformers

Was unable to load the fused model on an ubuntu environment. Was able to load it when I changed save_safetensors metadata to 'pt' (there was a related GH issue I believe) and produced model.safetensors.index.json. If this patch is not optimal, would still be better imo to let users know about this incompatibility, until it's fixed.

I should work if the format is mlx https://github.com/huggingface/transformers/blob/main/src/transformers/modeling_utils.py#L510
So can you remove the need to specify the format and just hard code it to MLX?

I can do it for sure, but I couldn't load it with mlx format, I got
ValueError: Incompatible safetensors file. File metadata is not ['pt', 'tf', 'flax'] but mlx

transformers==4.38.2 in google colab with
import torch
from transformers import AutoModelForCausalLM, AutoTokenizer
MODEL_PATH = "/content/drive/MyDrive/mlx_test/lora_fused_model"
tokenizer = AutoTokenizer.from_pretrained(MODEL_PATH)
model = AutoModelForCausalLM.from_pretrained(
    MODEL_PATH,
    device_map="auto",
    torch_dtype="auto",
    trust_remote_code=True,
    use_safetensors=True
)

where lora_fused_model is the fuse.py output with mlx format. Not sure if I'm missing something

Oh maybe you need to upgrade transformers:
pip install -U transformers

Can you run the pre-commit hooks, looks like your code failed the linting.

transformers==4.40.0 solves it, hardcoding "mlx" is enough for users to load models on linux. The argument is not needed indeed as colab / kaggle / whatever else is out there transitions to transformers==4.40.0 by default.
ps. sorry my bad, missed it, should be good


Passing 0 to the functions throws error.

I passed a value 0 to the function and it threw error.
toWords(0)
Rather I expected the library to give me a result as ZERO

Fixed in version 2.0.0
Kindly help check.

Yes, it's working. Thanks for the fix. I'll close this issue then.


update dbt-postgres to support py3.12

resolves #
docs dbt-labs/docs.getdbt.com/#

Problem

Solution

Checklist

[ ] I have read the contributing guide and understand what's expected of me
[ ] I have run this code in development and it appears to resolve the stated issue
[ ] This PR includes tests, or tests are not required/relevant for this PR
[ ] This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX

We need a changelog for this, and we need to verify that it builds. CI only checked unit tests and integration tests with editable installs.


Rustup

@bors r+

:pushpin: Commit aba29d80498344fd47a241ffb8181fd8d5327b86 has been approved by RalfJung
It is now in the queue for this repository.

:hourglass: Testing commit aba29d80498344fd47a241ffb8181fd8d5327b86 with merge beb8a81756ac53533fd48dc655ffe7db7866b06a...

:sunny: Test successful - checks-actions
Approved by: RalfJung
Pushing beb8a81756ac53533fd48dc655ffe7db7866b06a to master...


Update ko_build repo location and use wolfi static image in IAC modules

Giving this update another try, this time using a variable in each IAC module to define the location of the ko_build repo.
I think it should prevent CI failures that have KO_DOCKER_REPO set, since the computed value ends up equaling the environment variable version.

Here's the ko_build id from a local run of this:
module.slack-webhook.ko_build.image: Creation complete after 17s [id=gcr.io/jamon-chainguard/github.com/chainguard-dev/enforce-events/slack-webhook/cmd/app@sha256:4fbbfac4afc13e6fefb63c233e3742448a579d2b3abf05729cd6eb97add0af9f]

How does this look to you now @mattmoor?

I think this is ready for one last review when you've got a moment @mattmoor


why many Visual Shader lacks (3.2)

Godot version:
b7cf4c2050dfd51521522c874676e96d2e5c4762
Issue description:
I did not understand why added boolean where is the connection for the visual shader?
missing list:
IF
Switch (uniform) (it looks like boolean)
Clamp
Invert (OneMinus)
Create Function
DEPTH_TEXTURE
godot 3.2 VShader interpolation disappeared
Steps to reproduce:

UE4 materials screenshot:

OneMinus (Invert)

only noise for visual shader (function)

fresnel  for visual shader (function)

Only the Visual shader needs a bit more diverse function. The user will be easier to make the shader look like UE4 materials.

godot 3.2 VShader interpolation disappeared

its a mix now
Clamp - exist

IF, Switch

The implementation of boolean was a first step to it

okay
not yet added a comment for Visual shader

for example visual script comment

why many Visual Shader lacks

Because nobody is wanted to implement it yet, or do not have the time to do it. Godot has
the almost purely volunteer-based developer team, which mostly work on what they want, and when they want. If you have a skill you can also contribute to Godot and add the functions which you want.

@Chaosus I understand that I did not learn C++ sorry, only Python (I will probably go to study C++ in the future) :)

Yeah, thanks for notice anyways, I can look at further improvements to this system.
Also, note that Godot is not necessarily should follow UE4 (as I see in the provided screenshots) and implement whatever it's contains.

@Chaosus perfectly lighter :+1:

@ilyafuu Glad, that all worked fine!
Then about the other - I can easily implement OneMinus and Noise, but the Fresnel requires research how to do it correctly and what the algorithm stay behind it, while the Comment requires to write different kind of visual shader Node, simular to one in visual script. I may start to prepare a new pack of enhancement, where to include them, but not now, I want a rest and work on my projects..

wanted to mask invert for Visual Shader

okay :)

https://www.youtube.com/watch?v=kN7TvPWtypk
http://kylehalladay.com/blog/tutorial/2014/02/18/Fresnel-Shaders-From-The-Ground-Up.html


API 'BaseVariant.getApplicationIdTextResource' is obsolete and has been replaced with 'VariantProperties.applicationId'. It will be removed in version 5.0 of the Android Gradle plugin. For more information, see TBD. To determine what is calling BaseVariant.getApplicationIdTextResource, use -Pandroid.debug.obsoleteApi=true on the command line to display more information. Affected Modules: app

my AS version is 4.1.3

my AS version is 4.1.3

app #714


Bug in PooledThreadExecutor when using OverflowPolicy::REJECT_IMMEDIATELY

The code has this if:
if (m_overflowPolicy == OverflowPolicy::REJECT_IMMEDIATELY && m_poolSize >= m_tasks.size())
        {
            return false;
        }

The normal situation is that the new task is rejected if the current queue already contains m_poolSize items. So the condition must be inverted to:
m_tasks.size() >= m_poolSize

Thanks for noticing this; we pushed a fix for it recently.


Add BAEL-2272 persisting DDD aggregates examples

Add persisting DDD aggregates examples (BAEL-2272). I created a completely new "ddd" module, which will contain all examples from the DDD series (BAEL-2271). I'm not really sure about the profiles in the parent module and the modules organization policy, so I simply used spring-boot parent. Let me know if that's acceptable.

Your code looks great, just one question; why do all of your unit tests throw an Exception?  It doesn't seem necessary?

Alright sounds good. I am going to merge your PR in and update the github link in the article


Preliminary code review

Requesting a preliminary code review now that docstrings have been finished.
** NOTE ** : The code is not feature complete. The intent is for a high-level review in terms of coding standards and/or general design smell.
@diranged @siminm

https://github.com/Nextdoor/rightscale_rightlink10_rightscripts/blob/master/tasks.py#L67-L70:
There is some pretty ugly formatting going on here. Check in with @siminm  on the proper style-guide-approved way to handle this.
https://github.com/Nextdoor/rightscale_rightlink10_rightscripts/blob/master/nextdoor/metadata.rb#L14:
Lets re-organize the inputs so they are alphabetical. Since the inputs can be used by many different scripts, there is no real good way to organize them on a per-usage basis.
https://github.com/Nextdoor/rightscale_rightlink10_rightscripts/blob/master/nextdoor/metadata.rb#L126:
Rename DEFAULT_DOMAIN to DOMAIN -- as there is no real concept of a second domain name for the host (other than search order).
https://github.com/Nextdoor/rightscale_rightlink10_rightscripts/blob/master/nextdoor/metadata.rb#L171:
Reformat all long strings (over 80char) so that they are multi line.  You could try bringing that module into this as a submodule and see if RightScale recursively pulls submodules -- that would be nifty.
https://github.com/Nextdoor/rightscale_rightlink10_rightscripts/blob/master/nextdoor/lib/kingpin/kingpin.zip:
I get why we're doing this -- but it kind of sucks. Lets at least version the zip so that we know exactly what SHA1 it was built with. (Also, I suggest updating to our latest pre_release kingpin zip)
https://github.com/Nextdoor/rightscale_rightlink10_rightscripts/blob/master/nextdoor/hostname.py#L82:
Why is htop a dependency here?
https://github.com/Nextdoor/rightscale_rightlink10_rightscripts/blob/master/nextdoor/hostname.py#L34:
You are nly doing a few of the checks we had in our old code -- there is some work to do here to make sure that the total FQDN isn't too long, the hostname isnt too long, and that if the hostname IS too long, that we ensure the instance-ID is not clobbered.
https://github.com/Nextdoor/rightscale_rightlink10_rightscripts/blob/master/nextdoor/puppet-install.py#L43:
Doing an apt-get update on every script invocation is going to be really slow (30-60 seconds per) ... can we just move this into its own startup script and have it run first?
https://github.com/Nextdoor/rightscale_rightlink10_rightscripts/blob/master/nextdoor/puppet-install.py#L67:

Line length ..
Can you use a shorter file name? :)

https://github.com/Nextdoor/rightscale_rightlink10_rightscripts/blob/master/nextdoor/puppet-install.py#L88:
Not sure why you're doing the if statement here? Lets talk in person about this.
https://github.com/Nextdoor/rightscale_rightlink10_rightscripts/blob/master/nextdoor/puppet-install.py#L121:
Not pythonic -- look at the style guide.
https://github.com/Nextdoor/rightscale_rightlink10_rightscripts/blob/master/nextdoor/puppet-install.py#L126:
style guide... we don't use the .format() commadn typically. We use the "foo bar %s" % (var) mechanism.


[Breadth Coverage] Onboard Azure Stack HCI Commands

Spec Link
https://microsoft.sharepoint.com/:w:/t/AzureManagementExperience/ESUpnBLbm3xEvFpNLxn25kYB3X7hHr10LNZlpDcT9OFJ3Q?e=XYCASy
ADO Work Item Link
https://dev.azure.com/azure-mgmt-ex/Onboarding/_workitems/edit/2757
Resource Provider
What is the Azure resource provider your feature is part of?
Microsoft.AzureStackHCI
Description of Feature or Work Requested
Support Azure CLI commands for AzureStackHCI
Minimum API Version Required
2020-03-01-preview
Swagger Link
https://github.com/Azure/azure-rest-api-specs-pr/pull/1102
Python SDK Link
Not necessary, CodeGen will generate it automatically when generating CLI code.
Target Date
09/21/2020
Addtional context
We'll use autorest.az from code gen team to auto-generate the code first and may need update some code manually if the generated code doesn't meet your requirements.

for Ignite