delete old backups

because google drive storage is not bottomless, we should take care of deleting old files

how? maybe not storing more than a certain quantity of backups and always throwing out the older ones?

checkout the remove branch

So you will need to perform the following in the remove_old_files method:

List all files on the remote folder

Order this files by creation date

Delete all files except the most N recent ones, where N is a plugin setting.

from falco

no matter what, the files don't get deleted from the drive account. I don't know why, I posted the question on stackoverflow


dotnet: emit features for object instantiation via newobj instruction

sub task of #982.
for each newobj instruction  emit namespace, class, and api features where api is in the format <namespace>.<class>::ctor where ctor is capa's way to identify object instantiation via a call to the object's constructor. For example,
CIL:
...
... newobj System.Threading.Mutex::.ctor
...

features:
- namespace: System.Threading
- class: System.Thread.Mutex
- api: System.Threading.Mutex::ctor

tasks:

[ ] namespace extraction
[ ] class extraction
[ ] api extraction
[ ] update documentation

see here for more discussion

The newobj instruction creates a new object or a new instance of a value type. Ctor is a metadata token (a methodref or methoddef that must be marked as a constructor) that indicates the name, class and signature of the constructor to call.


fetchgit: add git signature verification

Description of changes
This makes it possible to include git commit and tag signature verification when using fetchgit.
The motivation for this is to enable maintainers to ensure an update to the source code was authorized by the developers.
As signing keys are supposed to stay the same over multiple versions, they should remain unchanged when updating to a new revision of a given source code.
The verification is done in a non-fixed-output derivation so it will always be executed.
The pr mimics the behaviior of  the verified-fetches experimental feature introduced by https://github.com/NixOS/nix/pull/8848.

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Requesting a review from myself to look later. I like this idea, but the hacks make me think there ought to be precursor patches that (say) make the callers of fetchgit tell you whether something is a tag or not.

rebased to master

@philiptaron Thank you so much for your review!
I would need some elaboration on the nativeBuildInputs idea.

I also wonder if you need to copy the contents from fetchresult, and whether you could just make out be a symlink to the fetchresult.
yes, except when leaveDotGit = false.


Initial TF apply updates and adjust service account name for character length constraints

This PR adds minor changes related to an initial terraform apply used through the state management and operations directories. A minor manual adjustment to the service account was required to stay within character limits for the name. These changes will help accurately reflect the state of the source and the now applied resources on GCP.
Thanks for any thoughts or suggestions you may have!
CC @MikeLippincott

Thank you @falquaddoomi ! Merging this in.


ICE Gathering mysteriously fail on MRWRTC 2.0

After upgrading our project to MRWRTC 2.0 we have stared to experience some strange behaviur during the ICE gathering stage. We are currently using a custome solution for signaling based on websockets. However, this solution was working greate when using MRWRTC 1.0.3. Sometimes the connection succeeds as expected, but very often it gets stuck in the Checking stage of the ICE process. If we wait long enough it received a fail ICE stage event. Is this something that we could be doing wrong? Or is it a problem with the API ?

There have been a few reports of frequent ICE failures, especially across different networks, but the cause is unclear. Thanks for the report, it's useful to narrow it down to 2.0. Will investigate.

Hi @fiban, thank you very much for investigating this issue. I have logs from the debug version of Mixed reality WebRTC 2.0.2 that we have compiled with our project. I have one log for a suceeded call performed on the local network and on log for a call that have failed performed with peers on different networks.
mrwebrtc2_0_2_win32_successCall_log.txt
mrwebrtc2_0_2_win32_failCall_log.txt

Thanks, this helps! I'll have a look.

I looked at the logs, in the success case the connection seems to be established on local network:

(p2ptransportchannel.cc:1789): Channel[0|1|__]: New selected connection: Conn[3a0b1900:0:Net[TP-Link:<IP_ADDRESS>/32:Wifi:id=3]:bRvlQFm7:1:0:local:udp:<IP_ADDRESS>:54226->uK2JeQtx:1:2122260223:local:udp:<IP_ADDRESS>:42006|CRWS|S|0|0|9114756780654476798|69]

while in the failure case the peer attempts to establish a UDP connection to what seems a private address, fails 151 times, then gives up:

(port.cc:1726): Conn[962b5d10:0:Net[Hyper-V:<IP_ADDRESS>/32:Ethernet:id=4]:WiGfgoGJ:1:0:local:udp:<IP_ADDRESS>:61185->wv6APIhA:1:2122194687:local:udp:<IP_ADDRESS>:42083|C--I|-|0|0|9114756780654476799|-]: Sent STUN ping, id=796643316b4f43647273492b, use_candidate=1, nomination=0
(port.cc:1726): Conn[483eca30:0:Net[TP-Link:<IP_ADDRESS>/32:Wifi:id=3]:yKQSDaM7:1:0:local:udp:<IP_ADDRESS>:61186->wv6APIhA:1:2122194687:local:udp:<IP_ADDRESS>:42083|C--I|-|0|0|9114756780654345726|-]: Sent STUN ping, id=5666535a744b6a6f4851334b, use_candidate=1, nomination=0
(port.cc:1220): Conn[962b5d10:0:Net[Hyper-V:<IP_ADDRESS>/32:Ethernet:id=4]:WiGfgoGJ:1:0:local:udp:<IP_ADDRESS>:61185->wv6APIhA:1:2122194687:local:udp:<IP_ADDRESS>:42083|C--I|-|0|0|9114756780654476799|-]: Failed to send STUN ping  err=-1 id=524e385075494e6231656665
...
(port.cc:1773): Connection deleted with number of pings sent: 151

The problem here seems to be that the peer does not receive any STUN ICE candidates (srflx), so it has effectively no viable candidate. The peer does sends some STUN candidates itself, which seems to suggest that the other peer cannot use/reach any STUN server, or that those messages are dropped for some reason:

Candidates sent

candidate:1387532568 1 udp<PHONE_NUMBER> <IP_ADDRESS> 61185 typ host generation 0 ufrag H3qP network-id 4
candidate:3690124833 1 udp<PHONE_NUMBER> <IP_ADDRESS> 61186 typ host generation 0 ufrag H3qP network-id 3 network-cost 10
candidate:1387532568 1 udp<PHONE_NUMBER> <IP_ADDRESS> 61187 typ host generation 0 ufrag H3qP network-id 4
candidate:3690124833 1 udp<PHONE_NUMBER> <IP_ADDRESS> 61188 typ host generation 0 ufrag H3qP network-id 3 network-cost 10
candidate:1522192533 1 udp<PHONE_NUMBER> <IP_ADDRESS> 7172 typ srflx raddr <IP_ADDRESS> rport 61186 generation 0 ufrag H3qP network-id 3 network-cost 10
candidate:1522192533 1 udp<PHONE_NUMBER> <IP_ADDRESS> 7175 typ srflx raddr <IP_ADDRESS> rport 61188 generation 0 ufrag H3qP network-id 3 network-cost 10
candidate:473427432 1 tcp<PHONE_NUMBER> <IP_ADDRESS> 60737 typ host tcptype passive generation 0 ufrag H3qP network-id 4
candidate:2507221713 1 tcp<PHONE_NUMBER> <IP_ADDRESS> 60738 typ host tcptype passive generation 0 ufrag H3qP network-id 3 network-cost 10
candidate:473427432 1 tcp<PHONE_NUMBER> <IP_ADDRESS> 60739 typ host tcptype passive generation 0 ufrag H3qP network-id 4
candidate:2507221713 1 tcp<PHONE_NUMBER> <IP_ADDRESS> 60740 typ host tcptype passive generation 0 ufrag H3qP network-id 3 network-cost 10

Candidates received

candidate:3772129433 1 udp<PHONE_NUMBER> 2804:214:8590:c0d7:757:b50:bce7:d0f8 48446 typ host generation 0 ufrag c8gK network-id 2 network-cost 900
candidate:1249779211 1 udp<PHONE_NUMBER> <IP_ADDRESS> 42083 typ host generation 0 ufrag c8gK network-id 1 network-cost 900
candidate:2924862569 1 tcp<PHONE_NUMBER> 2804:214:8590:c0d7:757:b50:bce7:d0f8 9 typ host tcptype active generation 0 ufrag c8gK network-id 2 network-cost 900
candidate:83747579 1 tcp<PHONE_NUMBER> <IP_ADDRESS> 9 typ host tcptype active generation 0 ufrag c8gK network-id 1 network-cost 900

What's the other peer? Can you check why it is not generating STUN ICE candidates?
You mentioned that the same app used to work fine with MR-WebRTC 1.0.3, can you provide logs for a successful connection across networks for 1.0.3?

Hi @fibann, Thank you very much for taking a look at our issue. The other peer is a web application running on google chrome. Our signaling solution is based on websockets. I will create the same logs running version 1.0.3 and post it here, I will also post the logs from our web application.

@fibann, I was collecting the logs to send you and we decided to test our project using multiple setups. We were able to communicate using devices in different networks when both devices are connected to wifi using Ipv4. However, our main scenario will be for the Hololens to be used on a 4G network on the field. When we try to make a call with one of the peers using a 4G network we seam to get ICE messages mixing Ipv6 and Ipv4, our STUN server always return the IP adress using IPv4 since we are using google`s STUN server.
I found an open issue relating Ipv6 networks and Ipv4 STUN serves: https://github.com/pion/webrtc/issues/810
Do you think this can be the issue? The change from MRWRTC version 1.0.3 to 2.0.0 could just be matching the period when we have started taking the device to the field and receiving this errors.

The last fail log you attached does contain a STUN candidate sent by Chrome. But without any more detailed logs for that instance it's difficult to know why that's not being used. You can try doing that again, ensuring that both sides send and receive srflx candidate, and check both the MR-WebRTC debug logs and chrome://webrtc-internals on the browser to try to understand what's going wrong (see https://rollout.io/blog/webrtc-issues-and-how-to-debug-them/ for example to get started).
Note that since connections work over wifi, this might not be due to something in (MR-)WebRTC but to some limitation from your 4G provider rather.

Thank you very much for your feedback @fibann , I will investigate that and post here anything that I may find.

Hey @SergioMasson. I have similar problem. Do you find any solution?

Hey @SergioMasson. I have similar problem. Do you find any solution?


Custom element generator

Wouldn't be something that fyord would support, or need to since it's a standard, but say you're working with in a fyord project and need an element you can use outside and inside fyord, a CE would be perfect.
Having a cli command to generate one could be a nice way to support and encourage CEs when they make sense.

Going to close this for now, as it's not really related to fyord.


dwm: cleanup

Motivation for this change
Dropped dwm-git since it hasn't been updated for years even thought it's meant to be trailing master
If people want dwm-git (or dmenu-git & st-git) I've made a neovim-nightly style overlay https://github.com/06kellyjac/suckless-git-overlay
LMK if the throw message needs changing
Cleaned up dwm
Things done

[X] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[X] NixOS (x86_64)
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[x] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[X] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[X] Ensured that relevant documentation is up to date
[X] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 112299 run on x86_64-linux 1

1 package built:

dwm

If the git version is not being updated in 2 years, then it looks more logical to me it is the true stable one.

I haven't seen any stability concerns over 6.2 and it's not exactly a new release coming out 2019-02-02, and there are a lot of projects based off dwm at some point or another.
If it is a stable version it should be called dwm-stable-DATE IMO
@xeji would probably remember but they've not been active on GH for a while

I haven't seen any stability concerns over 6.2 and it's not exactly a new release coming out 2019-02-02, and there are a lot of projects based off dwm at some point or another.
If it is a stable version it should be called dwm-stable-DATE IMO
@xeji would probably remember but they've not been active on GH for a while

I think this was meant as a joke.

@06kellyjac ping

Hi Jack, I switched to i3, not interested in maintaining dwm* packages as of now. Thanks.

No worries :+1:


[stable/postgresql] Allow templating of extra env vars

What this PR does / why we need it:
This runs extraEnvs through tpl so that they can refer to release specific
environment variables that are obtained from secrets or configmaps.
Otherwise, it is not possible to pass env vars as follows, and must use
a hardcoded keyref.
  extraEnv:
    - name: MY_CUSTOM_PARAM
      valueFrom:
        secretKeyRef:
          name: "{{ .Release.Name }}-my-var"
          key: my-custom-key

Which issue this PR fixes
This is a workaround for issue: https://github.com/helm/helm/issues/2492
and follows similar solutions used elsewhere:
https://github.com/helm/charts/issues/10342
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

[x] DCO signed
[x] Chart Version bumped
[x] Variables are documented in the README.md
[x] Title of the PR starts with chart name (e.g. [stable/chart])

Thanks for the PR. Could you fix the lint issue?

/ok-to-test


Use fork of Apache Thrift

Temporarily use a personal fork of Apache Thrift, tagged with 1.13.1, which includes the fix for THRIFT-5322 (apache/thrift#2292).
Fixes #2638 and #2452.
The issue to track the reversion of this PR is #2781.
Signed-off-by: Juraci Paixão Kröhling<EMAIL_ADDRESS>

@jpkrohling Would be good to create an issue to revert the change once an official version is available, and link within the description of this PR.

@Mario-Hofstaetter, @zigmund, would you be open to testing an image with this PR, to confirm that your problems will get fixed?

@jpkrohling Will do, hope to get it done by friday.

I thought we wanted the fork to be in github.com/jaegertracing. Why is personal fork?

I can push my fork to the jaegertracing organization, but it makes that somewhat too "official". I really want this to be temporary.

We can reflect that in the forked repo description. Btw pushing to a new repo from yours will not establish the forked link on GitHub.

@jpkrohling yes, I can test image in few days.

Btw pushing to a new repo from yours will not establish the forked link on GitHub

Yes, sorry, I meant that I would fork Apache Thrift to jaegertracing org and push the tag there.

PR updated to use the fork from the jaegertracing organization.


Use ES6 & WebPack? Bring Back UMD!

You said to open a ticket if I needed UMD, so here I am :).
We're looking at integrating what-input for helping with some accessibility issues we're having. However, we're developing everything internally in ES6, loading via modules, and compiling with webpack. Given that, I really dislike the idea of importing something that adds a global, as we've already had problems with these sorts of "implicit" dependencies on the global scope that we weren't aware of and caused issues, and would make it difficult for us long-term to to maintain.
I don't know how open you are to changes in your process, but I do know webpack can handle compiling to umd so that may help eliminate the overhead of maintaining the UMD wrapper yourself, deferring it to webpack instead.
And since we're using ES6, the static analysis of ES6 modules has been very helpful for us, so might also suggest updating to use ES6 modules as well so ES6 consumers like us can use the module rather than the compiled build.
I'm not the type to drop in on an OS project and suggest a bunch of work and walk away, so I will also say that if these are changes you might be open to, I'd be willing to work on and open a PR to implement them as well. That said, you're still going to end up being the one to maintain this long-term, so it's up to you.
Let me know what you think!

Hi James,
Thanks for adding the ticket and offering to help! I pulled the UMD wrapper out of frustration in trying to find something workable across different situations. Since this whole thing started with Foundation transpiling all JavaScript through Babel (why oh why would they do that to vendor scripts), how would you recommend supporting ES6 and ES5? Two versions?

Here's what I'm thinking for supporting both:
Convert the library to ES6 code and save it as src/index.js. It will export default the main object. Then you add "jsnext:main": "src/index.js" to the package.json. While it's not exactly a "standard", it is commonly used for that purpose, and even if the user's build tool doesn't use it by default, both browserify and webpack allow you to configure additional mains to use.
Will the ES6 code in place, you can compile it to an ES5-compliant UMD file in dist/index.js. Both webpack and browserify have library or standalone mode where they will compile and emit a UMD-library. That build step can be integrated into your gulp build or just handled via npm scripts.
Going forward, you would just need to maintain the ES6 src/index.js file and let the build process handle the UMD wrapping. If you still want to support bower, you would need to commit the dist/index.js file to the repo, since bower is basically just a thin wrapper around GitHub, and fortunately, since this is a browser-only plugin, we don't have to worry about node builds either.
I think that should cover it. If this sounds good to you, let me know whether you'd prefer browserify or webpack (or some other tool) and I'll see about pulling this together over the next few days.

Sounds good! I'm more familiar with Browserify but Webpack had become so popular it's probably worth using and the implementation should be simple enough that it's be a good opportunity for me to pick it up 😄
I just committed some updates with a version bump to 2.1.0 that consolidates the Gulp tasks into a single file and, more notably, changes the input switching behavior when interacting with form elements.

Hi @mAAdhaTTah! Have you had any time to make progress on this? I'm having other people ask about this as well.

I have not, as the project that involves this change got delayed. If you need it, I'll see if I can take a pass at it today.

Thanks for the update! No rush unless you have the time.


net: lwm2m: Implement Bootstrap discovery

Bootstrap discovery was not implemented properly in the LwM2M engine.
Although, there were some indications in the source code that it is implemented, it was not done according to spec (and actually broken).
Given that Bootstrap Discovery procedure differs a lot from the regular Device Management Discovery (different permissions, different information returned), it's easier to implement it as a separate function (bootstrap_discovery()) instead of making the existing do_discovery_op() function even more complicated.
Additionally fix the spec inconsistencies in the existing do_discovery_op().
Based on https://github.com/zephyrproject-rtos/zephyr/pull/30200, DNM until merged.

@jukkar I've addressed your feedback.

Dependency got merged and I've rebased - removing DNM.

@jukkar could you take a look please?

@jukkar could you take a look please?


Use new config format for LuckyRecord::Repo

LuckyRecord::Repo.configure do
  settings.url = LuckyRecord::PostgresURL.build(
    hostname: "localhost",
    database: "project_name"
  )
end

Closed by https://github.com/luckyframework/cli/commit/0d8c3ea5726aa2d278e93b18cfe59fd42a678b8c


Use PEM file if provided

the variable public_key_pem_file was not used anymore. Create an implementation to load a public SSH key if provided and don't automatically create a pair of key if provided.

conflict were not resolved, closing. I will create a new one with conflicts solved


rebase: use minikube v1.18

Minikube v1.18 has been released. This conains a fix for our losetup
workaround, so that can be removed now.
Updates: #1840

Show available bot commands
These commands are normally not required, but in case of issues, leave any of
the following bot commands in an otherwise empty comment in this PR:

/retest ci/centos/<job-name>: retest the <job-name> after unrelated
failure (please report the failure too!)
/retest all: run this in case the CentOS CI failed to start/report any test
progress or results

ci/centos/containerized-tests failed while building the image with dependencies for testing:
cd /opt/build/go/src/github.com/ceph/ceph-csi && make containerized-test TARGET=mod-check CONTAINER_CMD=podman ENV_CSI_IMAGE_NAME=registry-ceph-csi.apps.ocp.ci.centos.org/ceph-csi USE_PULLED_IMAGE=no'
Warning: Permanently added 'n28.crusty.ci.centos.org,<IP_ADDRESS>' (ECDSA) to the list of known hosts.
cephcsi image settings: registry-ceph-csi.apps.ocp.ci.centos.org/ceph-csi version canary
[ ! -f .test-container-id ] || podman rmi registry-ceph-csi.apps.ocp.ci.centos.org/ceph-csi:test
podman build  -t registry-ceph-csi.apps.ocp.ci.centos.org/ceph-csi:test -f ./scripts/Dockerfile.test .
STEP 1: FROM registry.fedoraproject.org/fedora:latest
Getting image source signatures
Copying blob sha256:157ab801145489f145f258148bd135102a3294e420f1859a39e824e7cda56b2f
Copying config sha256:9f2a56037643a68ea81711a8eeb4501428eefd40b000c866ad9745a581c0464d
Writing manifest to image destination
Storing signatures
STEP 2: ARG GOPATH=/go
--> Using cache 31de5ecfc421c7d12748a3c3cf48a2cd6bbd77b588e4b753e1d79d3cf39ceb2e
--> 31de5ecfc42
STEP 3: ENV  GOPATH=${GOPATH}  GO111MODULE=on  PATH="${GOPATH}/bin:/opt/commitlint/node_modules/.bin:${PATH}"
Error: error checking if cached image exists from a previous build: error getting history of "4770638bf2e01c123662b7dade27aaf1925fc2fe473628834729a4309b2d4131": error creating new image from reference to image "4770638bf2e01c123662b7dade27aaf1925fc2fe473628834729a4309b2d4131": error locating item named "manifest" for image with ID "4770638bf2e01c123662b7dade27aaf1925fc2fe473628834729a4309b2d4131": file does not exist
make: *** [Makefile:207: .test-container-id] Error 125
script returned exit code 2

/retest ci/centos/containerized-tests

ci/centos/containerized-tests failed while building the image with dependencies for testing:
cd /opt/build/go/src/github.com/ceph/ceph-csi && make containerized-test TARGET=mod-check CONTAINER_CMD=podman ENV_CSI_IMAGE_NAME=registry-ceph-csi.apps.ocp.ci.centos.org/ceph-csi USE_PULLED_IMAGE=no'
Warning: Permanently added 'n28.crusty.ci.centos.org,<IP_ADDRESS>' (ECDSA) to the list of known hosts.
cephcsi image settings: registry-ceph-csi.apps.ocp.ci.centos.org/ceph-csi version canary
[ ! -f .test-container-id ] || podman rmi registry-ceph-csi.apps.ocp.ci.centos.org/ceph-csi:test
podman build  -t registry-ceph-csi.apps.ocp.ci.centos.org/ceph-csi:test -f ./scripts/Dockerfile.test .
STEP 1: FROM registry.fedoraproject.org/fedora:latest
Getting image source signatures
Copying blob sha256:157ab801145489f145f258148bd135102a3294e420f1859a39e824e7cda56b2f
Copying config sha256:9f2a56037643a68ea81711a8eeb4501428eefd40b000c866ad9745a581c0464d
Writing manifest to image destination
Storing signatures
STEP 2: ARG GOPATH=/go
--> Using cache 31de5ecfc421c7d12748a3c3cf48a2cd6bbd77b588e4b753e1d79d3cf39ceb2e
--> 31de5ecfc42
STEP 3: ENV  GOPATH=${GOPATH}  GO111MODULE=on  PATH="${GOPATH}/bin:/opt/commitlint/node_modules/.bin:${PATH}"
Error: error checking if cached image exists from a previous build: error getting history of "4770638bf2e01c123662b7dade27aaf1925fc2fe473628834729a4309b2d4131": error creating new image from reference to image "4770638bf2e01c123662b7dade27aaf1925fc2fe473628834729a4309b2d4131": error locating item named "manifest" for image with ID "4770638bf2e01c123662b7dade27aaf1925fc2fe473628834729a4309b2d4131": file does not exist
make: *** [Makefile:207: .test-container-id] Error 125
script returned exit code 2

Not sure what the problem can be, it seems something related to podman or maybe the fedora image?

This problem should get addressed with #1900 . Once that one is merged and the CI jobs are updated, a /retest can be attempted.

/retest ci/centos/containerized-tests

/test ci/centos/containerized-tests


Option to update vector layers while animating

With this option, vector batches will be recreated with every frame.
For animations, this means that vector data won't be clipped to the
extent at which the animation started.

I updated this pull request by adding an updateVectorsWhileAnimating option on the map. I think this is in line with the loadTilesWhileAnimating and loadTilesWhileInteracting options, which we also have on the map.

Previously, we said that would be a per-layer option. What is the reason for using a map option instead?

@elemoine: you said that. @tschaub was just asking. The reason was to make it work the same as loadTilesWhileAnimating. But other than with tiles (which are managed by the map), it would be possible to make it a layer setting. It would also be possible to have both: layer setting overrides map setting.

I'll also make this work with the other renderers. @elemoine: do you want it on both map and layer, or just layer? You wish we code :smile:.

I just think that a layer option would be more flexible.

Cool. Will change.

Pull request updated. updateWhileAnimating is now a layer option.

LGTM, thanks Andreas

Please merge.


Question about mini-cheetah initial state

Hi, I am working on mini-cheetah's way point following in a height map built by realsense. I want to initialize the robot at a specific location in the height map. The init robot pose seems to be hard coded here: https://github.com/ganlumomo/Cheetah-Software/blob/simulation/sim/src/Simulation.cpp#L135, so I have set the value to (x, y, height_map(x, y) + 0.05), (Do I need to consider the height at the location when I set init state?). However, the robot state estimator seems did not get the correct z value. It looks like the following image. Could you give me a hint how to make the robot estimator working properly?
Thank you so much!

Okay, I am able to make the two aligned by tuning the z value in left_corner_loc of the loaded hightmap. Anyone have suggestions on how this value should be set instead of tuning? Thanks!

Hi, i wanted to ask about the simple plane simulator not using the height map. i wonder if you know how to change the initial position of the robot not using any height maps and where exactly the world coordinate axis are defined?


Loading files from the classpath throws FileSystemNotFoundException

I have a test-resource folder where my data sits for testing purpose. I have to load the testdata as File because this is what my API excepts. I thought i could easily load a File from my Resource path with
assert (exists Resource resource = `module test.space.smarquardt.csvparser`.resourceByPath("TestNormal.csv"));
value csvPath = parseURI(resource.uri);

But this will trow an FileSystemNotFoundException.
Is there a better way to load resources as Files? I thought this would work like in Java with
new File(this.getClass().getResource("foo.txt").toUri());

that would give me a File.

ok this was the wrong place for this bug i will move this to the ceylon-sdk.


adds NSObject to the list of allowedJSONTypes

Why would this be supported by JSONModel? How could it deserialize into an arbitrary object?
Before we can consider merging this, we need:

rationalization for the change
examples of how it would be used
test cases

Okay I'm going to close this for now. If you provide all of the above, I'll reopen it and we can consider whether this should be merged.


Can I change DataSourceMetaData's pattern ?

i have 128 databases, if i use druid for database pool, it will create 256 threads for these databases, but these threads are useless, maybe 2 threads is enough.
so i use my company database pool called "caelus", it can change the database dynamic, and its core call like this:
String jdbcUrl = "jdbc:mysql://<IP_ADDRESS>:3306?useUnicode=true";
Connection connection = DriverManager.getDriver(jdbcUrl).connect(jdbcUrl, driverProperties);
connection.setCatalog("database001");
caelus use setCatalog to change the actual database
when i use druid , the connection may like this
String jdbcUrl = "jdbc:mysql://<IP_ADDRESS>:3306/database001?useUnicode=true";
Connection connection = DriverManager.getDriver(jdbcUrl).connect(jdbcUrl, driverProperties);
at lastest shardingsphere version , MySQLDataSourceMetaData will check the jdbcUrl the pattern like
private final Pattern pattern = Pattern.compile("jdbc:mysql:(\\w*:)?//([\\w\\-\\.]+):?([0-9]*)/([\\w\\-]+);?\\S*", Pattern.CASE_INSENSITIVE);
so when i use the lastest version , my jdbcUrl is invalid because the metaData url is
jdbc:mysql://<IP_ADDRESS>:3306?useUnicode=true
finally i found no way to change this pattern , so i can only use the old version 2.0.3

ShardingSphere just ref MySQL's official URL format, FYI: https://dev.mysql.com/doc/connector-j/8.0/en/connector-j-reference-jdbc-url-format.html
So URL without database name is invalid.
If you want do your customized feature, please change the code as you want, but please note, we will not merge un-official URL format into ShardingSphere

OK,
i means can i set the pattern in code as i want ? or maybe ShardingSphere can provide a setting to uncheck this pattern ?
thank you


Removed the outdated dual-screen flag info

The dual-screen CSS and JS APIs have been available by default since Edge 97.
There is no reason to keep mentioning this in the docs, since 97 is a retired release.
There's no need for users to keep on enabling the web platform features flag to uses these APIs anymore.
Fixes #1983.

Docs Build status updates of commit 2d0f113:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

microsoft-edge/devtools-guide-chromium/device-mode/dual-screen-and-foldables.md
:white_check_mark:Succeeded
View

microsoft-edge/devtools-guide-chromium/media/experiments-dual-screen-emulation-edge-flags.msft.png
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


Update data set to reflect new renewable energy guidance for AWS Regions

Following the release of the Amazon annual sustainability report the Amazon public website was updated and now details an expanded list of AWS Regions that were powered by over 95% renewable energy in 2021.
"
To achieve our goal of powering our operations with 100% renewable energy by 2025—five years ahead of our original 2030 target—Amazon contracts for renewable power from utility scale wind and solar projects that add clean energy to the grid. These new renewable projects support hundreds of jobs while providing hundreds of millions of dollars of investment in local communities. We also may choose to support these grids through the purchase of environmental attributes, like Renewable Energy Certificates and Guarantees of Origin, in line with our Renewable Energy Methodology.
As a result, in 2021, the following AWS Regions were powered by over 95% renewable energy:
US East (Northern Virginia)
GovCloud (US-East)
US East (Ohio)
US West (Oregon)
GovCloud (US-West)
US West (Northern California)
Canada (Central)
Europe (Ireland)
Europe (Frankfurt)
Europe (London)
Europe (Milan)
Europe (Paris)
Europe (Stockholm)
"
https://sustainability.aboutamazon.com/environment/the-cloud?energyType=true

thanks for opening this @sissonbs . I've created a matching issue on the relevant repo, where we have a built an importer that we would need to update to account for these changes.


Advertise on specific IP address / multiple IP addresses on one interface

I am currently working on a system that can be active via DHCP and link-local at the same time and over the same interface, therefore having two valid IPv4 addresses on one interface. For what I have seen so far it only seems to be possible to make an advertisement per interface, not per address. Is this correct?
If you can only advertise per interface, does mmupnp automatically take all addresses for the given interface into account? If not, how can I tell the library to advertise on multiple IP addresses at the same time?

Such special circumstances are not taken into account. MulticastSocket binds to Interface, but I've never checked how it behaves when you have multiple link-local addresses. I don't have such an environment, so I can't check. The source code is here, so I would appreciate it if you could check it out and modify it if necessary.

Okay, thank you for the quick response. I will check it as soon as I have the time and resources available.


Allow properties to have a default value

To avoid properties evaluated as nil when it does not make sense, or nil checks like
isClassSide
    ^ classSide ifNil: [ ^ false ]

---> create FmxMBBehavior>#property:type:defaultValue:

seems more a Famix issue to handle in generator: https://github.com/moosetechnology/Famix/issues/228


Edit button in RenderChan panels

Request from @morevnaproject:

Recently I've come up with one more request. It would be really nice to add "Edit" button, right under the "Rerender" button. So, user can select a strip, click "Edit" and the source file is opened in the corresponding editor (i.e. Synfig Studio opened for sifz files, Krita for kra, etc.) I am not sure where to store the associations yet. One possibility is to store them within RenderChan (because it can be useful if we implement its GUI in the future). Another opportunity is to get associations from desktop, but this wouldn't work well for sound files (usually they are associated with music players).

I think the associations should be stored in RenderChan as a module function to open the editor, and have os.startfile or a subprocess call as a fallback. What do you think about this?

That's great. I like the idea!


How can I check if my mouse is compatible ?

Hello, my gamer mouse uses: Steelseries Engine pilot. It's an Acer Predator Gaming Mouse - product: PMW510 - but it's build by the same company then Rival. Steelseries says they don't support its pilot but I think it is same pilot, as any past and future version of this pilot works well on Windows, and as Acer uses the pilot from their website - this download address was written on the box, I no more have -, so I usually use the latest.
sudo apt-get install build-essential python-dev libusb-1.0-0-dev libudev-dev
sudo apt install python-pip
pip install rivalcfg
→ Installing collected packages: setuptools, hidapi, rivalcfg
→ Successfully installed hidapi-0.7.99.post21 rivalcfg-3.1.0 setuptools-40.6.3
rivalcfg --version
3.1.0

Actual Steelseries engine version is: Download Engine 3.13.3
How can I test to know if your pilot works on my mouse ?
You may need to know I was on Windows 10 before, so inside the mouse already has its configuration and works well. But now I am on Ubuntu Studio 18.04. For its shape it has 2 left buttons, one roll on top, plus one click button I never knew use. And forward the left and right click buttons. So it's 6 features plus the light that is OK in red and the rolling with light on horizontal plastic material that should have fine pixels.

Hello,
I looked at some photos of your mouse, it seems to be a Rival 300 (rebranded for Acer), so it should be compatible with rivalcfg... once we know its product id.
Can you give me the result of th efollowing command:
lsusb | grep 1038:

:)

Also, can you confirm it is this one : https://www.ldlc.com/fiche/PB00199792.html ?

Hello, here it is:
dracchingan@earendil-light:~$ lsusb | grep 1038: Bus 003 Device 005: ID 1038:1714 SteelSeries ApS
Yes it's the same. I bought mine a few years ago, maybe 4years ago, but I don't think they changed it.

Ok,
so can you try the following command (as root):
RIVALCFG_PROFILE=1038:1710 RIVALCFG_DEVICE=1038:1714  rivalcfg -c red

The light of your mouse should become red
If this work, it will be easy to add support for this mouse :)

Hello, my USB does loop, and the inner pilot must have a few differences with the Rival 300 although I used to use same engine to change colour. I'll also post some information that may help you:
`dracchingan@earendil-light:~$ RIVALCFG_PROFILE=1038:1710 RIVALCFG_DEVICE=1038:1714  rivalcfg -c red
[DEBUG] Rivalcfg 3.1.0
[DEBUG] Python version: 2.7.15rc1
[DEBUG] OS: Linux
[DEBUG] Linux distribution: Ubuntu 18.04 bionic
[DEBUG] Forced profile: 1038:1710
[DEBUG] Targeted device: 1038:1714
W: The following mouse was found but rivalcfg was not able to open it:

mouse: SteelSeries Rival 300 (1038:1710)
error: Unable to find the requested device: 1038:1710:00

Please check that no other application is controlling this mouse and try to:

unplug the mouse from the USB port,
wait few seconds,
and plug the mouse to the USB port again.

[DEBUG] Selected mouse: None
Usage: rivalcfg [options]
rivalcfg: error: no such option: -c
dracchingan@earendil-light:~$ lsusb -v | grep -A117 1038:
Couldn't open device, some information will be missing
Couldn't open device, some information will be missing
Couldn't open device, some information will be missing
Bus 002 Device 003: ID 1038:1714 SteelSeries ApS
Device Descriptor:
bLength                18
bDescriptorType         1
bcdUSB               1.10
bDeviceClass            0 (Defined at Interface level)
bDeviceSubClass         0
bDeviceProtocol         0
bMaxPacketSize0        64
idVendor           0x1038 SteelSeries ApS
idProduct          0x1714
bcdDevice            0.68
iManufacturer           1
iProduct                2
iSerial                 0
bNumConfigurations      1
Configuration Descriptor:
bLength                 9
bDescriptorType         2
wTotalLength           84
bNumInterfaces          3
bConfigurationValue     1
iConfiguration          0
bmAttributes         0xa0
(Bus Powered)
Remote Wakeup
MaxPower              200mA
Interface Descriptor:
Couldn't open device, some information will be missing
bLength                 9
bDescriptorType         4
bInterfaceNumber        0
bAlternateSetting       0
bNumEndpoints           1
bInterfaceClass         3 Human Interface Device
bInterfaceSubClass      0 No Subclass
bInterfaceProtocol      0 None
iInterface              0
HID Device Descriptor:
bLength                 9
bDescriptorType        33
bcdHID               1.11
bCountryCode            0 Not supported
bNumDescriptors         1
bDescriptorType        34 Report
wDescriptorLength      37
Report Descriptors:
** UNAVAILABLE **
Endpoint Descriptor:
bLength                 7
bDescriptorType         5
bEndpointAddress     0x81  EP 1 IN
bmAttributes            3
Transfer Type            Interrupt
Synch Type               None
Usage Type               Data
wMaxPacketSize     0x0020  1x 32 bytes
bInterval               1
Interface Descriptor:
bLength                 9
bDescriptorType         4
bInterfaceNumber        1
bAlternateSetting       0
bNumEndpoints           1
bInterfaceClass         3 Human Interface Device
bInterfaceSubClass      1 Boot Interface Subclass
bInterfaceProtocol      2 Mouse
iInterface              0
HID Device Descriptor:
bLength                 9
bDescriptorType        33
bcdHID               1.11
bCountryCode            0 Not supported
bNumDescriptors         1
bDescriptorType        34 Report
wDescriptorLength      74
Report Descriptors:
** UNAVAILABLE **
Endpoint Descriptor:
bLength                 7
bDescriptorType         5
bEndpointAddress     0x82  EP 2 IN
bmAttributes            3
Transfer Type            Interrupt
Synch Type               None
Usage Type               Data
wMaxPacketSize     0x0008  1x 8 bytes
bInterval               1
Interface Descriptor:
bLength                 9
bDescriptorType         4
bInterfaceNumber        2
bAlternateSetting       0
bNumEndpoints           1
bInterfaceClass         3 Human Interface Device
bInterfaceSubClass      0 No Subclass
bInterfaceProtocol      0 None
iInterface              0
HID Device Descriptor:
bLength                 9
bDescriptorType        33
bcdHID               1.11
bCountryCode            0 Not supported
bNumDescriptors         1
bDescriptorType        34 Report
wDescriptorLength      76
Report Descriptors:
** UNAVAILABLE **
Endpoint Descriptor:
bLength                 7
bDescriptorType         5
bEndpointAddress     0x83  EP 3 IN
bmAttributes            3
Transfer Type            Interrupt
Synch Type               None
Usage Type               Data
wMaxPacketSize     0x0009  1x 9 bytes
bInterval               1
Couldn't open device, some information will be missing
Couldn't open device, some information will be missing
Couldn't open device, some information will be missing
Couldn't open device, some information will be missing
Couldn't open device, some information will be missing
dracchingan@earendil-light:~$
`
There is no pilot download option in the Acer website, there was Steelseries Engine in the box that works for anything that has to do with customization. And plus, this might be a website that took something different then what the Rival website proposes. https://drivers.softpedia.com/get/KEYBOARD-and-MOUSE/Steelseries/SteelSeries-Predator-Gaming-Mouse-Driver-2320-64-bit.shtml
But anyway, my mouse works, it's not this the problem. I just wanted to know how far compatibility was =)

Hello, it seems there is a small bug in one of the debug functions... Anyway, I implemented the support of your mouse too let you try if it work...
Please run the following commands to test:
# Install git if you do not already have it
sudo apt install git

# Clone the rivalcfg repository and go in its directory
git clone https://github.com/flozz/rivalcfg.git
cd rivalcfg

# Switch to the branch where I implemented support for your mouse
git checkout acer-predator-gaming-mouse
git pull

# Try if it work (this must be run as root as udev permission are not yet properly configured)
sudo python -m rivalcfg -c red

Hello,
Thank you very much for this fantastic work, your driver is now perfectly configured for the Acer Predator Gaming Mouse - NP.MCE11.005 - 6500 dpi, a mouse deeply inspired on the Steelseries Rival 300 mouse as the configuration tissue is the same, the light can change colour =)
First I did:
 pip uninstall rivalcfg
Then I did follow your commands to install it again =)
It said in french that the branch 'acer-predator-gaming-mouse' has the parameter of following the far away branch 'acer-predator-gaming-mouse' starting from 'origin'.
Then it said that pull is already up to date.
sudo python -m rivalcfg -c red
sudo python -m rivalcfg -c yellow
sudo python -m rivalcfg -c blue
sudo python -m rivalcfg -c green
sudo python -m rivalcfg -c orange (orange doesn't exist)
Usage: rivalcfg [options]
__main__.py: error: option -c: invalid color: 'orange'
sudo python -m rivalcfg -c white
sudo python -m rivalcfg -c black (black is lights off)
sudo python -m rivalcfg -c red

I have 2 entrances in 'souris et pavé tactile' (mouse and touchpad) in Ubuntu Studio 18.04, but I think it's due to the fact that I can plugin the mouse in 2 different USB ports. I did put both acceleration and sensibility at max. It's just my mouse carpet that is not perfect. But I think I feel everything all right =)
Testing sensibility:
sudo python -m rivalcfg -s 6500 (that gives ballet feeling, it is too many pixels) sudo python -m rivalcfg -s 3500 (that is fast but it's good)
So all works =) =) =) Thank you very much =) =) =) =) =) =) =) =) =)

Thank you very much for your issue and your feedbacks. The support of the Acer Predator Gamin Mouse is now released in rivalcfg 3.3.0 :)

Should I close issue ?

I prefer closing it myself once everything is done (so now as I released the new rivalcfg version) ;)


Bluetooth: Host: Fix issue where uninitialized value was used

This change makes sure that when a call to bt_id_set_scan_own_addr is sucessful, i.e., the return value is 0, the own_addr_type will be set by the bt_id_set_scan_own_addr.
Not setting the own_addr_type in a successful call to bt_id_set_scan_own_addr causes, for example, the start_le_scan_ext method in scan.c to use an uninitialized own_addr_type.
Eventually this results in an unexpected failure further down in start_le_scan_ext, when sending HCI command to controller with an uninitialized own_addr_type.

Had to update PR to fix a failing unittest. Decided to remove the check in unittest. As I understand it the own_addr_type is not used if err != 0, so setting the value of own_addr_type should not matter when err != 0. Let me know if you think differently

I did consider that.
Typically when a function returns an error, the [out] values are unchanged. That is not the case in this PR, where the *own_addr_type is still changed on error, which is what caused the test to fail.
Perhaps instead of removing the test check, the function should only modify *own_addr_type when the return value is 0?

I think that if a function return an error code, the output value should not be considered at all by the caller. It's safer and may avoid users reusing the output value for something even if the function return an error.

[a] function should only modify [*out_paramter] when the return value is 0?

The above, as a potential general rule, is too restrictive I think. Like in the case of https://github.com/zephyrproject-rtos/zephyr/blob/main/tests/bluetooth/common/testlib/include/testlib/conn.h#L26-L28


uniform distribution [-1,1]

Hi @timueh,
I tried to se a new default OrthoPoly to denote uniform distribution [-1,1].
I met an issue as follows.
using PolyChaos

Type_for_domain = Tuple{Float64, Float64}
struct Uniform_11Measure <: AbstractCanonicalMeasure
    w::Function
    dom::Type_for_domain
    symmetric::Bool

    function Uniform_11Measure()
        new(x->0.5, (-1,1), true)
    end
end

struct Uniform_11OrthoPoly{V, M, Q} <: AbstractCanonicalOrthoPoly#{V, M, Q}
    deg::Int          # maximum degree
    α::V  # recurrence coefficients
    β::V  # recurrence coefficients
    measure::M
    quad::Q

    # inner constructor
    function Uniform_11OrthoPoly(deg::Int;Nrec::Int=deg+1, addQuadrature::Bool = true)
        #_checkConsistency(deg, Nrec)
        α, β = r_scale(1., rm_legendre(Nrec)...)
        quadrature = addQuadrature ?  Quad(length(α)-1,α,β) : EmptyQuad()
        new{promote_type(typeof(α), typeof(β)), Uniform_11Measure, typeof(quadrature)}(deg, α, β, Uniform_11Measure(), quadrature)
    end
end

a = Uniform_11OrthoPoly(5);
showpoly(0:5,a)

1
x
x^2 - 0.33
x^3 - 0.6x
x^4 - 0.86x^2 + 0.09
x^5 - 1.11x^3 + 0.24x

It's okay up to now. However, when I examined the recurrence coefficient, I found there might be something wrong. The variance
var([0,1],a)
0.6666666666666666

of a uniform distribution [-1,1] doesn't equal to its correct value 1/3.
I thins it's due to the coefficient,
a.β
2.0
 0.3333333333333333
 0.26666666666666666
 0.2571428571428571
 0.25396825396825395
 0.25252525252525254

where the first element should be equal to 1.
Could we try to fix it?

This way works.
using PolyChaos
supp = (-1,1)
uni_meas = Measure("uni_meas", x->0.5, supp, true)
b = OrthoPoly("uni_op", 5, uni_meas);

var([0,1],b)
0.3333333333333332

I might have misused the function rm_jacobi, not sure about it yet.

Hi there,
the problem with your first attempt is that you don't normalize the measure when computing the recurrence coefficients. That's what the function r_scale() is for.
Instead of
α, β = r_scale(1., rm_legendre(Nrec)...)

write
α, β = r_scale(0.5, rm_legendre(Nrec)...)

Note: your first approach is definitely cleaner and numerically more stable because you compute the recurrence coefficients based on rm_legendre(). Put differently: you exploit the fact that we have a closed form of the recurrence coefficients.
The second approach is more intuitive from a coding-point-of-view, but does not exploit the fact that we have a closed form of the recurrence coefficients.

Maybe I should spend some time catching up polynomials... : )
Anyway I finished the support for uniform distribution [-1,1], and created a pull request.


speed-up - plot_route_folium

The PR addresses issue #586. It will replace graph_to_gdfs(G, nodes=False, fill_edge_geometry=True) by   graph_to_gdfs(G.subgraph(route), nodes=False, fill_edge_geometry=True)  as only the edges from the path are required to plot the route.
The speed is significantly improved, the computation time for a graph with 90000 edges and a path of 430 nodes is:
Current version: 23.7146 s
Enhanced version: 0.9569 s

Coverage remained the same at 92.23% when pulling f0d9cb215fca210a443853463ab03b3e718a9ba3 on Labulitiolle:speed-up/plot_route_folium into c1d402601c739108bcdc86523dabd3c0d71dbac4 on gboeing:master.

I have done additional refactoring to the folium module in #595 and #596 for further speed and memory improvements.


Delegate as Clousure

This project is good to go but it lack some feature since integrating ad cleverly will increase revenue also. This is my suggestion:

implement delegate of admob(interstitial & reward) as clousure, make it most handy as it can
option to add the banner below the safe area

Great!

Hey,
thank you for your comment. I have actually removed the delegate and replaced it with closures for the upcoming v11 version (see develop branch).
Also good idea about the banner ads ignoring the safe area, I will add this feature as well in v11. Thanks
I am planning to release this very soon.

Hey,
I will be releasing version 11 with closures today or latest tomorrow. I need to double check some GDPR stuff and than I will push the update.


Response body null when Request contains body (For 401 responses)

Describe the bug
Using  <spring-cloud.version>2023.0.3</spring-cloud.version>
When I make a OpenFeign client that does not have a body, the 401 response contains a not null body but if I add a body parameter the returned Response.Body comes empty.
Sample
@FeignClient(name = "example", url = "http://localhost:8080")
public interface Example {
    @PostMapping(value = "/post", consumes = MediaType.APPLICATION_JSON_VALUE, produces = MediaType.APPLICATION_JSON_VALUE)
    ResponseEntity<String> exec(
            @RequestHeader("X-A") String a,
            @RequestBody String jsonBody
    );

this produces
feign.FeignException$Unauthorized: [401] during [POST] to [http://localhost:8080/post] [example#exec(String,String)]: []

but after removing the jasonBody attribute, I get:
feign.FeignException$Unauthorized: [401] during [POST] to [http://localhost:8080/post] [example#exec(String)]: [RETURNED BODY]

This is the controller I used to test it:
    @PostMapping(path = "/post", consumes = MediaType.APPLICATION_JSON_VALUE, produces = MediaType.APPLICATION_JSON_VALUE)
    ResponseEntity<String> post(@RequestHeader("X-A") String A,String body) {
        System.out.println("request received, header " + A + " body: " + body);
        return new ResponseEntity<>("RETURNED BODY", HttpStatus.UNAUTHORIZED);

    }

It seems like the controller problem.  The parameter of  jsonBody don't have  @RequestBody annatation.

@pxpy  You are right! I guess the service I'm making a request to, has the same fault on their controllers. Thanks!


Fixes clang error: cast from pointer to smaller type 'unsigned int' l…

…oose information
This PR fixes the following clang++ error:
[ 16%] Building CXX object CMakeFiles/example.dir/imgui-sfml/imgui-SFML.cpp.o
/Users/eidheim/test/ifud1048/game/imgui-sfml/imgui-SFML.cpp:385:54: error: cast from pointer to smaller type 'unsigned int' loses
      information
                glBindTexture(GL_TEXTURE_2D, (GLuint)(unsigned int)pcmd->TextureId);
                                                     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 error generated.

Sorry, but I won't accept this PR, because size_t isn't an unsigned int on most platforms (it's mostly unsigned long). And pcmd->TextureId is an unsigned int in a void*.
I know that there's a problem with that (and a bunch of other) cast and I'll try to fix it soon.

No worries, and thank you.


chore(build): uplift webpack-related packages to v5

chore(build): uplift webpack-related packages to webpack5-supported version
SUMMARY

Uplift the webpack-related packages to webpack5-supported version for currency and fix any associated vulnerabilities.
There's a small config refactor in superset-frontend's webpack.config.js made by following webpack-dev-server's migration guide
I run npm run dev, npm run build and npm run dev-server and all things look good.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

N/A
TESTING INSTRUCTIONS

Run npm run dev, npm run build-dev and npm run dev-server
ADDITIONAL INFORMATION

[ ] Has associated issue:
[ ] Required feature flags:
[ ] Changes UI
[ ] Includes DB Migration (follow approval process in SIP-59)

[ ] Migration is atomic, supports rollback & is backwards-compatible
[ ] Confirm DB migration upgrade and downgrade tested
[ ] Runtime estimates and downtime expectations provided

[ ] Introduces new feature or API
[ ] Removes existing feature or API

@hainenber @kgabryje It looks like the correct way of implementing the desired behavior is to use the afterEmit compiler hook instead of a middleware.


onCancel method not working

I've searched everywhere in your code and saw that u used onCancelEditing.
but its not working in my project
Can u solve this for me?
Thanks :)

I'm not sure but isn't onEndEditing the prop you want to use?

Works thanks!


PX4 integration

This Pull Request integrates PX4 specific modes and commands into mavlink_vehicles and also implement some other general changes. The commits specifically related to PX4 are prefixed with PX4.
Currently, the flight stack (PX4 or APM-ardupilot) needs to be selected statically into mavlink_vehicles.hh, but a commit that implements the auto-detection of the flight stack will be submitted soon.

Reviewed and separated into two patches.


[SPARK-28586][INFRA] Make merge-spark-pr script compatible with Python 3

What changes were proposed in this pull request?
This PR proposes to make merge_spark_pr.py script Python 3 compatible.
How was this patch tested?
Manually tested against my forked remote with the PR and JIRA below:
https://github.com/apache/spark/pull/25321
https://github.com/apache/spark/pull/25286
https://issues.apache.org/jira/browse/SPARK-28153

We still need to keep the Python2 support?

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/13597/
Test PASSed.

Yea, it's deprecated but not removed out yet.

Test build #108503 has started for PR 25322 at commit 0d0fdc9.

Let me cc Spark committers to inform although it might be a bit of noise .. because I know it's annoying to use Python 2 in Mac due to some pre-installed lib issues. After this PR, we can now use Python 3 for this script. cc @apache/spark-committers.

Nice, @HyukjinKwon !

Test build #108504 has started for PR 25322 at commit 9e139db.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/13598/
Test PASSed.

Test build #108506 has started for PR 25322 at commit 11c3c7f.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/13600/
Test PASSed.

Test build #108503 has finished for PR 25322 at commit 0d0fdc9.

This patch fails PySpark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/108503/
Test FAILed.

Test build #108504 has finished for PR 25322 at commit 9e139db.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/108504/
Test PASSed.

Test build #108506 has finished for PR 25322 at commit 11c3c7f.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/108506/
Test PASSed.

Great! thanks @HyukjinKwon


Muzei usually stuck for a while when I skip a wallpaper.

Muzei usually stuck for a while when I skip a wallpaper.
It also killed almost all background apps process.
Logcat:
Performing pause of activity that is not resumed: {net.nurik.roman.muzei/com.google.android.apps.muzei.MuzeiActivity}
java.lang.RuntimeException: Performing pause of activity that is not resumed: {net.nurik.roman.muzei/com.google.android.apps.muzei.MuzeiActivity}
	at android.app.ActivityThread.performPauseActivity(ActivityThread.java:3865)
	at android.app.ActivityThread.performPauseActivity(ActivityThread.java:3853)
	at android.app.ActivityThread.handlePauseActivity(ActivityThread.java:3827)
	at android.app.ActivityThread.-wrap15(Unknown Source:0)
	at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1602)
	at android.os.Handler.dispatchMessage(Handler.java:106)
	at android.os.Looper.loop(Looper.java:164)
	at android.app.ActivityThread.main(ActivityThread.java:6499)
	at java.lang.reflect.Method.invoke(Native Method)
	at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:440)
	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:807)

Performing stop of activity that is already stopped: {net.nurik.roman.muzei/com.google.android.apps.muzei.MuzeiActivity}
java.lang.RuntimeException: Performing stop of activity that is already stopped: {net.nurik.roman.muzei/com.google.android.apps.muzei.MuzeiActivity}
	at android.app.ActivityThread.performStopActivityInner(ActivityThread.java:3997)
	at android.app.ActivityThread.handleStopActivity(ActivityThread.java:4085)
	at android.app.ActivityThread.-wrap24(Unknown Source:0)
	at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1623)
	at android.os.Handler.dispatchMessage(Handler.java:106)
	at android.os.Looper.loop(Looper.java:164)
	at android.app.ActivityThread.main(ActivityThread.java:6499)
	at java.lang.reflect.Method.invoke(Native Method)
	at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:440)
	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:807)

I'll need a little more information as those stack traces don't say anything about what is actually going on.

What version of Muzei are you using?
What source do you have selected?
What version of Android are you using?

Muzei: 2.5.2
Source: https://play.google.com/store/apps/details?id=moe.democyann.pixivformuzeiplus
Android: 8.1.0

The current Muzei API requires that you disable Battery Optimizations on third party sources (such as Pixiv for Muzei Plus) for them to continue to have network connectivity to load more wallpapers. Work is being done on a new API that removes this requirement.

@ianhanniballake In the interim, could a message perhaps be added to the app to inform users of this?  I'm aware a note has been added to the description but believe it can easily be missed (see Play store reviews as a good example).  Perhaps the note could also be moved further up the description?

A warning was added in f5f62b5 and will be available in a future Muzei 3.0 alpha


Enable docker style logging for wasm

Docker currently writes its logs to disk, enabling us to pick them up again during the lifetime of the container.  This PR implements some of the same functionality for wasm so that we can stream its logs in the same fashion as docker.

Closed in favour of #2301 which takes a slightly different approach in how the data is written to a buffer before syncing to disk.


NotAuthorizedNodeType fails when authorized? is defined in base class

For implementations that use a more generic approach defined in a base class authorized?, this new cop fails. Any objection to loosening this up a bit to allow for base class implementation?
Original PR: https://github.com/DmitryTsepelev/rubocop-graphql/pull/115

Hey! Well, Rubocop has issues with checking other classes while inspecting a specific file, so I'd suggest the following:

add a config option for SafeBaseClasses: []
change a cop to check if class is implementing authorized? or inherits from one of those base ones

WDYT?

@DmitryTsepelev Thanks so much for the quick response. I didn't realize Rubocop has trouble in that way. I don't think I'm knowledgeable enough with Rubocop to give an opinion, but if that seems like the best way to you, I believe you. 😄

Thank you so much 😊


Fix build using GCC

The first commit fixes warnings like the following when compiled on Linux GCC:
winmd/impl/winmd_reader/flags.h:306:28: error: declaration of ‘constexpr winmd::reader::CodeType winmd::reader::MethodImplAttributes::CodeType() const’ changes meaning of ‘CodeTy
pe’ [-fpermissive]
  306 |         constexpr CodeType CodeType() const noexcept
      |                            ^~~~~~~~
In file included from winmd/winmd_reader.h:6:
winmd/impl/winmd_reader/enum.h:188:16: note: ‘CodeType’ declared here as ‘enum class winmd::reader::CodeType’
  188 |     enum class CodeType : uint16_t
      |                ^~~~~~~~

(See also: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=41039, https://www.open-std.org/jtc1/sc22/wg21/docs/papers/2019/p1697r0.html)
The second commit fixes https://github.com/microsoft/winmd/issues/27.

Unfortunately, there's currently no CI build for this repo. We need to validate the change in cppwinrt before merging.

Historically, the winmd reader was just a part of cppwinrt but then some other projects wanted to use it and here we are. It's a bit more work this way unfortunately.

No problem, it is tested in the checks of this PR: https://github.com/microsoft/cppwinrt/pull/1239

Ran into some issues publishing the nuget package for this project. It may be simpler just to roll this into the cppwinrt repo (where it originated) and avoid the nuget dependency...

These changes only affects building with GCC, so only the CMake build of cppwinrt will need the update. We can have the CMake build clone the latest source from this repo instead of downloading the nuget package.
MSVC and Clang don't require these changes, so the VS project can continue to use the current winmd nuget dependency.
This way we don't need to vendor the winmd headers into the cppwinrt repo. Does this sound good to you?

Sounds good.
cc @DefaultRyan in case he knows how to get the nuget package updated.


Fileview doesn't show page file extensions

In 5.x we've stopped surpressing file extensions, but the fileview doesn't seem to show them. Preferably we would fix this and have a different way of showing the difference between pages and files (in case of the 'all files' view).

Nice idea. 👍

This would still be an option for the new Overview page.

This is fixed on 5.x


Cache directory structure when using credentials

Hi,
I noticed that when using credentials to access repository, fetched artifacts are saved to the directory .coursier/cache/v1/https/USERNAME%40REPOSITORY_HOSTNAME
Is there a rationale behind creating separate directories for the same REPOSITORY_HOSTNAME but different USERNAME?

Yep, the rationale is not to mix up things fetched while authenticated with those fetched while not authenticated.

Ok, thx for reply!

I'm facing a really annoying problem caused by this issue.
The %40 in the path will cause escaping when transfers to URI and then to URL instance. Which is used quite a lot in Spark.  %40 will be escaped to %2540 which does not exists.


Invalid URL string.

I have an issue with my worktop project. I upgraded from 0.4.2 to v0.8.0-next.8 and now I am getting this error:
Invalid URL string.

Running wrangler dev (or even wrangler publish).
I have also tried without using webpack as suggested @lukeed, but to no avail, since I'll be getting the error:
Can't import the named export 'parse' from non EcmaScript module (only default export is available)

Anyhow, I tried to see if the issue was related to my project, so I copied the index file from here: https://github.com/lukeed/worktop/tree/master/examples/workers/basic and I can see I am still getting "Invalid URL string".
This is my wrangler.toml file:
name = "workers-proxy"
type = "webpack"
account_id = "<someid>"
workers_dev = true
kv-namespaces = []
vars = { ApiHostName = 'd661-185-10-223-75.ngrok.io', FrontendHostName = 'somehostname.com', cacheEnabled = 0, cacheTtl = '86400', DEBUG = 1 }
compatibility_date = "2021-11-24"
webpack_config = "webpack.config.js"

This is my package.json:
{
  "private": true,
  "name": "workers-proxy",
  "version": "1.0.0",
  "description": "",
  "main": "index.js",
  "scripts": {
    "test": "echo \"Error: no test specified\" && exit 1",
    "format": "prettier --write '**/*.{js,css,json,md}'"
  },
  "license": "MIT",
  "devDependencies": {
    "eslint": "^7.32.0",
    "eslint-config-airbnb-base": "^14.2.1",
    "eslint-plugin-import": "^2.24.2",
    "prettier": "^1.18.2"
  },
  "dependencies": {
    "worktop": "^v0.8.0-next.8"
  }
}

What am I missing here?
Update
Reverting to 0.7.3 seemed to fix the issue locally when running wrangler dev or when you publish and access the .workers.dev domain, however, on my own primary domain, I still get the error Invalid URL string - but only one the main route that matches for this path: /.* the path I have at /api.* works.
Update 2
Going into Cloudflare Dashboard and purging the caches solved the issue. But I am still kinda back where I started; trying to solve a 522 Connection timed out issue that made me upgrade to latest worktop in the first place. I just found a thread online, and I see you've been having the same issue as me  😄 https://community.cloudflare.com/t/issue-with-worker-to-worker-https-request/94472/21

Hi, it'd help if you actually shared your source code that's what is throwing the error.
If you're using type=webpack, you need to add a custom webpack_config= config key to add the relevant configuration changes. This is because webpack (especially webpack@4 that wrangler includes) has a resolver that's not spec compliant.


pi output in file

Launching the computation with input files, we expect the code to generate yaml files with the outcomes of each pi, as described in the documentation
After launching your program, I did not get any result stored.
Is it because the code is still Work in Progress?

Solved


Update RainbowSixSiegeBridge

This bridge, which I created, no longer works because articles are now loaded after the page loading with Javascript.

Is this bridge no longer needed ?
Because if it is not the case, the latest content can be fetched via https://prod-tridionservice.ubisoft.com/live/v1/News/Latest?templateId=tcm%3A152-76778-32&pageIndex=0&pageSize=5&language=en-US&detailPageId=tcm%3A152-194572-64&keywordList=175426&siteId=undefined&useSeoFriendlyUrl=true

I may look into it then, but I don't really like using a private API when creating bridges

I fixed the bridge using the API, it can now be merged I think.

Merged, thanks !


3d image carousel

Is your feature request related to a problem? Please describe.
It is not related to any problem
Describe the solution you'd like
A CSS only 3d image carousel
Additional context
https://user-images.githubusercontent.com/66325953/135749263-448c93df-4610-4b11-ad83-428aaec4773c.mp4

Assigning it to you🎊🎊🎊🎊🎊


Add 2013 base on MapProxy URL

This adds the 2013 image layer based on an URL by the MapProxy
https://github.com/codeforberlin/mapproxy-config/pull/5

This is not needed anymore.


CLI 3.22.0 - Tuscan Sun Vienna - November 2022 does not work on Ubuntu 20.04.03

Downloaded the  3.22.0 - Tuscan Sun Vienna - November 2022 Linux executable of mc-linux and installed on my WSL2 version of Ubuntu 20.04.03.
Started with
./mc-linux
got this error
qemu-aarch64: Could not open '/lib/ld-linux-aarch64.so.1': No such file or directory
Previous versions started without error
Regards Thomas
P.S. We are collegues in MindSphere ;)

as a workaround please install the nodejs version ,i will look into it

I exchanged the version in the release, the previous version was built on mac using qemu, this should hopefully work:

@sn0wcat - yes, works on my WSL2 version of Ubuntu 20.04.03
Thanks


Fix compilation errors in clang

It will occur in ubuntu-latest of GitHub Actions:
In file included from /home/runner/work/lua-cgemma/lua-cgemma/lua-cgemma/build/_deps/gemma-src/backprop/optimizer.cc:23:
/home/runner/work/lua-cgemma/lua-cgemma/lua-cgemma/build/_deps/gemma-src/./gemma/weights.h:235:57: error: unknown type name 'nullptr_t'; did you mean 'std::nullptr_t'?
  constexpr bool kHaveRaw = !hwy::IsSame<RawWeightsPtr, nullptr_t>();
                                                        ^~~~~~~~~
                                                        std::nullptr_t
/usr/bin/../lib/gcc/x86_64-linux-gnu/12/../../../../include/x86_64-linux-gnu/c++/12/bits/c++config.h:302:29: note: 'std::nullptr_t' declared here
  typedef decltype(nullptr)     nullptr_t;
                                ^
In file included from /home/runner/work/lua-cgemma/lua-cgemma/lua-cgemma/build/_deps/gemma-src/./backprop/backward.cc:27:
In file included from /home/runner/work/lua-cgemma/lua-cgemma/lua-cgemma/build/_deps/highway-src/hwy/foreach_target.h:72:
In file included from /home/runner/work/lua-cgemma/lua-cgemma/lua-cgemma/build/_deps/gemma-src/./backprop/backward.cc:32:
/home/runner/work/lua-cgemma/lua-cgemma/lua-cgemma/build/_deps/gemma-src/./gemma/weights.h:235:57: error: unknown type name 'nullptr_t'; did you mean 'std::nullptr_t'?
  constexpr bool kHaveRaw = !hwy::IsSame<RawWeightsPtr, nullptr_t>();
                                                        ^~~~~~~~~
                                                        std::nullptr_t
/usr/bin/../lib/gcc/x86_64-linux-gnu/12/../../../../include/x86_64-linux-gnu/c++/12/bits/c++config.h:302:29: note: 'std::nullptr_t' declared here
  typedef decltype(nullptr)     nullptr_t;
                                ^
In file included from /home/runner/work/lua-cgemma/lua-cgemma/lua-cgemma/build/_deps/gemma-src/./backprop/forward.cc:27:
In file included from /home/runner/work/lua-cgemma/lua-cgemma/lua-cgemma/build/_deps/highway-src/hwy/foreach_target.h:72:
In file included from /home/runner/work/lua-cgemma/lua-cgemma/lua-cgemma/build/_deps/gemma-src/./backprop/forward.cc:32:
/home/runner/work/lua-cgemma/lua-cgemma/lua-cgemma/build/_deps/gemma-src/./gemma/weights.h:235:57: error: unknown type name 'nullptr_t'; did you mean 'std::nullptr_t'?
  constexpr bool kHaveRaw = !hwy::IsSame<RawWeightsPtr, nullptr_t>();
                                                        ^~~~~~~~~
                                                        std::nullptr_t
/usr/bin/../lib/gcc/x86_64-linux-gnu/12/../../../../include/x86_64-linux-gnu/c++/12/bits/c++config.h:302:29: note: 'std::nullptr_t' declared here
  typedef decltype(nullptr)     nullptr_t;
                                ^
1 error generated.
make[2]: *** [_deps/gemma-build/CMakeFiles/libgemma.dir/build.make:146: _deps/gemma-build/CMakeFiles/libgemma.dir/backprop/optimizer.cc.o] Error 1
make[2]: *** Waiting for unfinished jobs....
1 error generated.
make[2]: *** [_deps/gemma-build/CMakeFiles/libgemma.dir/build.make:[118](https://github.com/ufownl/lua-cgemma/actions/runs/9608690735/job/26501927754#step:6:119): _deps/gemma-build/CMakeFiles/libgemma.dir/backprop/backward.cc.o] Error 1
1 error generated.
make[2]: *** [_deps/gemma-build/CMakeFiles/libgemma.dir/build.make:132: _deps/gemma-build/CMakeFiles/libgemma.dir/backprop/forward.cc.o] Error 1
make[1]: *** [CMakeFiles/Makefile2:600: _deps/gemma-build/CMakeFiles/libgemma.dir/all] Error 2
make: *** [Makefile:156: all] Error 2
Error: Process completed with exit code 2.

Oops, thank you :) Strange that our internal clang accepted this.

Indeed, MacOS Clang also accepted, whether it was GitHub Actions or my own Macbook.


README.md typo

second sentence -- This project has 3 components, a consumer project and two service providers, one Dropwizard and one Springboot service that the consumer will interaction with.

interact with

fixed


GCM Deprecated Methods

register() & unregister() methods are now deprecated. Consider using new methods.
https://developers.google.com/cloud-messaging/android/legacy-regid

@ritdaw  We have ongoing work to replace the deprecated methods.

@ritdaw We have updated our new SDK to delete these deprecated methods for currently supported ones at https://github.com/Azure/azure-mobile-apps-android-client.


Improve test suite

There's a test suite in the form of some basic TravisCI sanity (and code style) checks but the architecture of 2.x gives us plenty more in the way of testability.
As for feature demo - I've already tested and can confirm that you can dump a Kint render in a file and display it on a static site such as github pages so that will ideally provide a live feature demo that's easier to access than a test suite.

We have an actual test suite now! (Yay!)
Now all we need to do is write tests!... Yuck that sounds boring. I'll do it later. (Probably)


Problem with redis and docker.io limits. How to overwrite redis image url in 0.4.0?

I did not install this operator. I just got a task to upgrade whole OKD cluster. Upgrades go well but redis got stuck during redeployment because default redis image is set to docker.io repository (unlike other images from this operator which are set to quay.io).
https://github.com/argoproj-labs/argocd-operator/blob/master/common/defaults.go
And docker.io has pull limits.
https://docs.docker.com/docker-hub/download-rate-limit/
I would prefer to point to other image (like to quay.io or our own registry). How to do that? I don't see anything related in documentation
https://argocd-operator.readthedocs.io/en/latest/

You can set ARGOCD_REDIS_IMAGE in operator subscription with your image. This will make the changes at global level, i.e all ArgoCD instances will use the new image.
apiVersion: operators.coreos.com/v1alpha1
kind: Subscription
metadata:
  name: argocd-operator
spec:
  config:
    env:
      - name: ARGOCD_REDIS_IMAGE
         value: 'public.ecr.aws/docker/library/redis:5'

Alternatively, you can modify .spec.redis.image & .spec.redis.version in ArgoCD CR. This will make the changes at instance level.
apiVersion: argoproj.io/v1alpha1
kind: ArgoCD
metadata:
  name: example-argocd
spec:
  redis:
    image: public.ecr.aws/docker/library/redis
    version: 5

Docs:

https://argocd-operator.readthedocs.io/en/stable/usage/environment_variables/
https://argocd-operator.readthedocs.io/en/latest/reference/argocd/#redis-options


Update Leafdoc

Latest Leafdoc is still unpublished on npm, so Leaflet documentation is building with outdated Leafdoc.
The issue is already reported a year ago.
Besides of functionality, outdated Leafdoc currently is the source of critical vulnerabilities reported by npm during install (see https://github.com/Leaflet/Leaflet/pull/7133#issuecomment-625873697).

I think that this pull can be merged to remove a security vulnerability during install.
This Leaflet issue has been closed but the error persists with current Leaflet master because Leafdoc has not been released after removing sander dependency, that was the source of the error.
So yes, we need a new Leafdoc version published in NPM:

Bump Leafdoc version to 1.6.0.
Publish it on NPM.
Bump Leafdoc version dependency in Leaflet package.json.

I've been working on some (IMO much-needed) cleanup of the leafdoc regexes. Before publishing a new Leafdoc version, I'd appreciate any review of https://github.com/Leaflet/Leafdoc/pull/52

Version 2.3.0 of Leafdoc released on npm: https://www.npmjs.com/package/leafdoc


[top/dv] Add exit_test_unlock test.

The primary difference between this test and the existing unlock test is that this sequence tries to simulate the liklihood system usage.
Specifically, the ROM_EXEC_EN and the advance to PROD are done in the same power cycle.  Upon reboot, an image is then bootstrap into the device to ensure the behavior is correct.
The bootstrap portion for this test is still missing.
Signed-off-by: Timothy Chen<EMAIL_ADDRESS>

i probably need to rename this..it's actually test_unlock_exit..

i can go back and address some of the comments. I don't agree with all of them, but I do some are good feedback.

Hey @tjaychen, I know this PR has been merged, but I couldn't help myself from adding review comments. PTAL, thanks!

Do you prefer I no longer add top level tests? It seems in general you feel the quality of the test is pretty poor?

Need to circle back to this PR to address comments.


Add gitter badge to README and link to CONTRIBUTING

Replacement for #171, putting the badge with other badges and adding a link to CONTRIBUTING.

👍


Wrong error message when user is not given permission to create Settings.toml

Description:
When the user does not have permission to create the Settings.toml file, the error message displayed is "ballerina: unable to create the file system cache of Ballerina Central repository". An error message similar to "failed to create /home/user/.ballerina/Settings.toml: permission denied" should be displayed instead.
Steps to reproduce:
Revoke permissions from the user for '/home/user/.ballerina/'
Run ballerina code using the bal run command.

https://github.com/ballerina-platform/ballerina-update-tool/issues/147


Add support for docker build args

Codecov Report

Merging #6 into master will decrease coverage by 0.01%.
The diff coverage is 80%.

@@            Coverage Diff             @@
##           master       #6      +/-   ##
==========================================
- Coverage   75.97%   75.96%   -0.02%
==========================================
  Files           8        8
  Lines         383      387       +4
==========================================
+ Hits          291      294       +3
- Misses         92       93       +1

Impacted Files
Coverage Δ

bgkube/__main__.py
70% <100%> (+0.61%)
:arrow_up:

bgkube/bg.py
72.26% <75%> (-0.13%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3103c11...31b6678. Read the comment docs.


Test execution page

added to measure test execution page: error reporting table, product test information, ability to download CAT 1 zip file, ability to upload CAT 1 zip file for C1 tests, separate tabs for CAT 1 vs CAT 3 executions if C1 and C2 are selected at the product level.

@thecristen @jaebird123  That "found two elements" thing has popped up again


Add docker image to dockerhub

Together with truffle integration lets create a proper account on dockerhub for autoritative securify images

Last I tried, there were some problems with the ownership of the repo, basically you have to be an admin of the github repo or something (so that you can link the dockerhub account with the github account), so I could not do it, maybe @ptsankov could. That begs the question of which namespace we want on Dockerhub, do we want a eth-sri (that Petar controls?), or do we want a chainsecurity namespace?
For the chainsecurity namespace, we would have to fork the repo to our github namespace (and sync it whenever we want to build the docker image again).
Also see https://github.com/eth-sri/securify/pull/34#issuecomment-435806099

Lets create one from our chainsecurity account for now: https://github.com/ChainSecurity/securify

Actually I worked around the limitation I had encountered, it was enough to convert the chainsecurity namespace on dockerhub to an organization, so it works now with the eth-sri repo.


Can running garden instance commit to a docker image?

Hi, We all know garden supports running docker images, can running garden instance commit to a docker image?
Thanks.

Hi, @egarle,
Although garden-linux has support for running containers based on Docker images, the current implementation does not run the Docker daemon itself, and hence does not support the full range of operations available on Docker images and containers. I don't believe there's any way to take a garden container and commit it to a Docker image, much less to push it out to a Docker registry so it can be used elsewhere.
Thanks,
Eric, CF Runtime Diego PM

Hi, @ematpl,
I find that Garden setup Container rootfs by itself, code here, And Docker have command like "docker save" or "docker export", it will save the container's rootfs and get a "xx.tar" file. so I think it will not be very hard to save Garden container to be a new docker image, is that ritht? maybe just copy the code from docker about the file system operation.

Hi, @tsjsdbd,
Yes, one could theoretically extract a tarball containing the filesystem contents of a particular Garden container, similar to what docker export produces, although the Garden API does not support this operation explicitly. Implementing docker save or docker commit would be more complicated, as there is additional Docker-specific image metadata that must be preserved for existing layers and created for a new layer. I don't see that Diego has a particular need for any of these operations, although if you are interested in adding these capabilities to garden-linux itself you should discuss that with the Garden team via the https://github.com/cloudfoundry-incubator/garden-linux repository.
Thanks,
Eric

Closing due to inactivity.


Could not find password on Ubuntu

Hi awesome work,
however I noticed on Linux (Ubuntu 18 LTS) throws the error : ERROR: Cound not find password. This happens because it looks in /etc/NetworkManager/.../ for files with name {ssid}.nmconnection, whereas in my case those files are just named as {ssid}. Changing {ssid}.nmconnection to  just {ssid} solved my issue.

Thank you for letting me know about this issue. I have temporarily removed support for Linux because there seems to be a lot of problems. As @littlediobolic mentioned in #21:

Unfortunately network management can vary from device to device making it hard to account for everything. For instance, the Raspberry Pi doesnt even use NetworkManager at all to manager Wifi AFAIK

Thank you for letting me know about this issue. I have temporarily removed support for Linux because there seems to be a lot of problems. As @littlediobolic mentioned in #21:

Unfortunately network management can vary from device to device making it hard to account for everything. For instance, the Raspberry Pi doesnt even use NetworkManager at all to manager Wifi AFAIK


Support for bower

I understand how react itself uses browserify, but we have a repo that uses other stack and we use bower to manage dependencies.

+1

+1

+1

I use with bower+rails so bower is so much more convenient to track versions etc

well, seems like it was stopped being maintained

Probably , I was made my own small react infinite scroll mixin , which really super simple and stupid. Need only extract to bower component :)


Improvereplace function_cast from_string to serde

Proposed changes
Issue Number: close #xxx
Now we can not support streamload with column which is map/array nested map/array
serde can do this now , so we can replace it
Notice. if item data in complex type data is empty  we just return error, instead of makeup default value , because now we can not define right default for complex type

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall

run buildall

run buildall

run buildall

run buildall

run p0

run buildall

run buildall


Splitter documentation update.

I hereby agree to the terms of the Knot.x Contributor License Agreement.

All comments fixed, approved.


Clean cf templates

Issue #, if available:
continuation of https://github.com/aws-solutions/aws-media-insights-engine/pull/624
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Skipping review for trivial change.


Add Post Execute Delegate

Add postExecute delegate, as the cacheable datasource works primarily with DatasourcePreExecute at which point it generates the datasource. Association output only appends the data within DatasourcePostExecute running a delegate to check for a difference in XML output is highly inefficient, it's better to have Association Output trigger a delegate when it actually adds data to a datasource.
Also added check for addedAssociationOutput datasource param prior to adding any association data. This is used as a flag to confirm if the data is/has been generated. If the XML is a string, it does not mean that the output is cached, or vice versa, an extension might load the cache and serve an object anyway, so some kind of flag is required. I'm aware my suggestion might not be the best but not sure what would be most suitable.

LGTM, but I'll let @nilshoerrmann merge it since he's the expert with associations.

Feels free to merge it, if it's looking good to you, Nicolas.

@jonmifsud could you create a new version in the xml file since this will be merged directly into master please ?

I thought I did bump the version in the XML. did I not?
On Wed, 26 Aug 2015 at 19:23 Nicolas Brassard<EMAIL_ADDRESS>wrote:

@jonmifsud https://github.com/jonmifsud could you create a new version
in the xml file since this will be merged directly into master please ?
—
Reply to this email directly or view it on GitHub
https://github.com/hananils/association_output/pull/12#issuecomment-135114272
.

Sorry I must have not scrolled enough.


Add copyright notices to files

dbt-core and other adapters don't put license headers to their code, updating only main LICENSE file for now


[core] Add support for iOS Safari 12

Seems like I forgot ios_safari 12.2 in #22814. The other changes are due to new version releases (mainly Firefox ESR moving to 78).
Safari 12 sits at 2% global usage. But other than IE 11 where we argue that this browser is mostly used in corporate enviornments (with an LTS license) iOS Safari 12 is used by actual people that would need to buy a new phone in order to upgrade to Safari 13. So I don't think the usage stats can solely be used as justification to drop it.
The unfortunate part is that this won't allow an all-in usage of PointerEvent. But we'll get there eventually.
The good part is that ImageList should function perfectly well in iOS Safari 12 looking at gap and column-gap support

Shouldn't we update next--material-ui.netlify.app/getting-started/supported-platforms/#browser in this case?

Yes, I forgot :+1:

What's the difference between Safari on iOS and macOS? I thought they were using the same engine.

Kind of depends what you mean by "engine". I just treat them as different browsers because they are. How similar they are under the hood is not really a concern for me. Why are you asking?

Why are you asking?

I'm asking regarding what we should document

Seems like they are in fact different: https://stackoverflow.com/questions/3006647/list-of-known-safari-on-ipad-differences-over-desktop-safari
Maybe that's just historical but I'd treat them differently.

Maybe that's just historical but I'd treat them differently.

Same for Chrome?

If it has a different name it's a different browser in my book. Not sure what we are discussing here?

My point is that if we are handling Safari differently based on mobile vs desktop, shouldn't we do the same for chrome?

My point is that if we are handling Safari differently based on mobile vs desktop, shouldn't we do the same for chrome?

Haven't thought about it. If you're aware of inconsistencies then we should probably include it. Though it might be ok to ignore 1 version differences for evergreen browsers.


feat: add warning for prompts without variables

Implement variable detection in readPrompts function
Add warning for prompts without variables
Add PROMPTFOO_DISABLE_NO_VARIABLE_WARNING to EnvVars type
Add tests for new warning functionality

Closing for now. Have to rethink when someone wants to compare prompts without any vars in their tests.


Bug Fixes in 3CP

Fixed a bug where the rebet button wasn't working after player folded once.
Fixed a bug where, when the Player earns an Ante Bonus, but the Dealer wins the hand, the wager chips (red) showed the amount won rather than the win chips (green).

I'm leaving this comment here instead of directly on the file since it's not related to a change that was made in this PR: In three-card-poker.js I'd like you to get rid of the concept of a global totalWagerAmount. We're introducing unnecessary complexity because this amount is simply the sum of the three individual wager counters, so at any point in the code where you need to know that sum, simply calculate it at that moment. We'll reduce the chances of a bug because now we have only one source of truth of what the "total amount wagered" is instead of a redundant second variable tracking this through manual (and error-prone) manipulation in the code.

Re: Total Wager Amount -- This has been fixed and refactored, still working on chip delays w/r/t Rebet button.


How to show two toasts with different layout options at the same time

How to show two(or more) different toats with different UI settings (ex: container position) at the same time. Currently, if you show two toasts with different options both will inherit one set of options,
ex: if you go to the demo page  and set the duration to 1min and then click on 'Launch Toast' it will appear at the position you selected, now select different position and also select full width option on. and click on 'Launch Toast' you will see all the toasts (previously shown and the new one) will be full width and will also be moved to the new position. Ideally already shown toasts should keep there settings and positions regardless of the new toast settings.
This is very useful in asynchronous calls to back and show different messages to the UI.
It, however, retain the theme without affecting so I think you can make it work for other options (such as position and full-width) as well.
Use case:
we want to show action based toast at the center of the screen without full-width and other error and notifications at the bottom of the screen with full-width, but in current if a notification comes up while user action toast is visible, both will go to the bottom of the screen and will be full-width which is not user experience as suddenly it changes where user needs to click on.

group support is available now !


Logic bug about ionViewDidEnter?

Short description of the problem:
As mentioned in #7843。the ui related things should put in the ionViewDidEnter event. but i'm not sure is these scene had been talk about?
1: When enter a new page(like a list page), i will init data from my server with a loading component, so i put this logic in ionViewDidEnter event
2: after going to another page(like a detail page), i will back to the list page, at this time i don't need to refresh the data. when put the init logic in ngOnInit event, it won't progress again, but when in ionViewDidEnter enent the logic progress again.
3: now i solved these just with a tag
What behavior are you expecting?
when back to the list page, the init logic won't progress again
Tips: please forget my pool english`(∩_∩)′

Well, from the issue you referenced you can see the link to the ionic 2 lifecycle events and there you can see that it is recommended to put setup code in the ionViewLoaded if you want that code to run only once. In the other issue ionViewDidEnter was mentioned because that was more suitable for that application.
Also this seems more like a support question so it is a good idea to ask it in the ionic forum instead.

Hello! Thanks for opening an issue with us! As this seems like more of a support question i will urge that you ask this question on our forum. Thanks for using Ionic!


No Color in Resoponse View

Hi
first of all I LOVE this tool. On the screenshot of bagel it looks like there is some
color highlighting, in the response view. In mine everything is just white.
Any idea ?

@K4stor
This is just the overview. Color highlighting is enabled only for json format.

Hi @yagiz,
I'm using macOS Monterey, but the JSON from the response is all white, no colors there:

Do I missed a configuration step?


Inner Array Attributes

Is there an easy way to add attributes to the inner array field in ReorderableArray?
So far the options I've come up with are:

Use a List<> with my own attributes applied and create a custom editor that uses a ReorderableList.
Create a copy of the ReorderableArray class with my own attributes applied.
Refactor ReorderableArray so that it is extensible i.e. make array an abstract property and child classes can apply their own attributes as needed.

I'm curious if you've come across this problem and know of an alternate solution or if one of the above is the best way to go.

I made a class that wraps the original class. then use the new class as the template of ReorderableArray.
'''
[Serializable]
private class ActionTypeReferenceList : ReorderableArray { }
[Serializable]
public class ActionTypeReference
{
[SerializeField, ClassExtends(typeof(Action), Grouping = ClassGrouping.ByNamespace)]
private ClassTypeReference _reference
}
'''
And i also made a drawer for ActionTypeReference for better look (avoid that collapsing toggle)

You can use any custom class which contains an "array" property to render as a ReorderableList.
The "ReorderableDrawer", which draws the "Reorderable" attribute simply needs an "array" field to supply the ReorderableList with a SerializedProperty.
so if you want a custom attribute on your array field, I would create your own ReorderableArray class, something like this perhaps:
class MyClass : MonoBehaviour {

	[SerializeField, Reorderable] MyArray objects = new MyArray();

	[System.Serializable]
	private class MyArray {

		[SerializeField, SomeCustomAttribute]
		private Object[] array = new Object[0];
	}
}

Great, thank you!


net/freeradius: accounts management

I do not have understand if in OPNsense is possible to managed freeradius accounts, if there is or there will be the possibility to view and modify it's users definitions

Hi, ATM only the attributes available when adding a user can be managed.
Do you need some additional attributes?

hi @mimugmail thank you very much for your attention, at the moment I do not need any additional attribute. If needed, we could develop it in OPN but I did not understand, sincerely, how to manage freeRadius users (or ldap users as well) in OPNsense, I mean in the way that it could let me view, search, create, modify and delete a user or a group of user... And watch who's actually logged (accounting log).
If I'm doing a mess tell me how to explore this funcionality, if some other feature are needed we could start to think how to develop them :) (first of all: "why" we are developing them!)

My intention to build this plugin was WPA2/Enterprise for home use, so no need fro group management.
If you have some practical examples please post, I dont think it's too hard to build groups.
Accouting on a firewall is not that good since most systems don't have much diskspace. Also most applications using radius have their own user mgmt where connect time is displayed.

For WPA2 home use, and also office use, I'm using openWRT/LEDE on AccessPoints and a standalone freeradius with mysql. Now I'm looking to introduce a good freeradius web interface for a general purpose user management.
Someone of my collegues tolds me that in pfSense there was the possibility to manage Radius accounts and we are looking how to to that in a common way, if possibile, in OPNsense.
If there are no way to have this feature in OPNsense I will have to develop a freeRadius accounting manager using Django Framework.
Talking about embedded devices: Disk space doesn't worry me because my freeRadius configuration always have mysql and this, as you know, could be deployed on another server too (and logs with NFS). But, as I tolds you, now I'm looking for a general purpose common way to do that, without any hardcoding. Do I miss how to create freeradius user in OPNsense?

If you need a general purpose FR then OPN is the wrong place. The pfsense plugin is way more feature complete. We wont setup MySQL on OPN, so this not the right place.
What do you mean with createing freeradius users?  Really thank you, I now have the answer: "Yes, we also have a freeRadius plugin to do this".

There is an early plugin with essential features by @mimugmail, yes. So far, not a lot of requests additional functionality which does not mean it out of the question to extend the current scope. I don't think a database is off the table as well if somebody is doing the work. The packages already have mysql and postgresql as packages in addition to the "standard" sqlite.

@fichtner good news. I'm going to see if the pluging can do our needs, if everything is good and just something is needed I can give you an help.
brilliant