Allow GPG files to be loaded from the local file

What does this PR change?
This PR adds possibility to import gpg files from local file.
Test coverage

No tests: add explanation

No tests: already covered

Unit tests were added

[ ] DONE

Links
Issue(s): https://github.com/SUSE/spacewalk/issues/24712

[X] DONE

Changelogs
Make sure the changelogs entries you are adding are compliant with https://github.com/uyuni-project/uyuni/wiki/Contributing#changelogs and https://github.com/uyuni-project/uyuni/wiki/Contributing#uyuni-projectuyuni-repository
If you don't need a changelog check, please mark this checkbox:

[ ] No changelog needed

If you uncheck the checkbox after the PR is created, you will need to re-run changelog_test (see below)
Before you merge
Check How to branch and merge properly!

Found a small bug:
manager:~ # mgradm gpg add Release.key
1:28PM INF Welcome to mgradm
1:28PM INF Executing command: add
1:28PM INF /var/spacewalk/gpg/customer-build-keys.gpg
------------------------------------------
pub   rsa2048 2022-08-08 [SC] [expires: 2024-10-16]
      7DD5 0531 2601 307D 8BCD  7DD1 E45D C198 6DE5 6376
uid           [ unknown] Devel:Galaxy OBS Project<EMAIL_ADDRESS>
pub   rsa2048 2018-06-19 [SC] [expires: 2026-02-13]
      50E6 0431 5448 5D99 0732  B5D6 ACAA 9CF7 E6E5 A213
uid           [ unknown] systemsmanagement OBS Project<EMAIL_ADDRESS>
pub   rsa2048 2014-05-26 [SC] [expires: 2025-05-02]
      AAF3EB044C49C402A9E7B9AE69D1B2AAEE3D166A
uid                      security OBS Project<EMAIL_ADDRESS>
Do you really want to trust this key [y/N]?

It show all keys in the keyring and not only the one I really want to trust.
Also the keys I trusted before are shown.

Fixed in latest commit


Add Github Action to lint and link check the README

Create a separate workflow called markdown-lint.yml do not use an existing workflow if found

Hey @booyaa
Just to confirm you are looking to add a GH action to run lint checks on the README file?

Hey @booyaa
Just to confirm you are looking to add a GH action to run lint checks on the README file?

A link checker would be fine (there's a few actions available that do the job). I'll update issue to reflect this.


[REQ] Can I get some help understanding how to run this next to HA as a container?

Is your feature request related to a problem? Please describe.
Seems like this being an addon makes it impossible for HA to run properly. I would like to be able to run this as a docker container next to it so that I can use it!
Describe the solution you'd like
Guidance on how to make that work or for someone to do so for me. I can make the dockerfile and setup the service, I just need to know what to expose.

I am no expert on docker at all, so not sure. It is designed to be installed as a custom component to HA through HACS or manually. So you should be able to run it just fine as part of HA. So not sure why that is not an option for your install but I am afraid I can't help you with running this in a container as it's really not built for that.

I appreciate the response! I think my confusion is coming from the setup process. It doesn't seem to show up in the sidebar so I assumed that it must need to be run separately. I'll see if I can figure it out and will post what I find here.


Refactor PropTypes to use prop-types package

This PR switches out all occurences of React.PropTypes with PropTypes of prop-types.

[x] Explain the motivation for making this change.
[x] Provide a test plan demonstrating that the code is solid.
[x] Match the code formatting of the rest of the codebase.
[x] Target the master branch, NOT a "stable" branch.

Motivation (required)
To remove the warnings caused by React 16.
React.PropTypes is deprecated and should be migrated to the prop-types package.
Test Plan (required)
No more tests are failing than on the master branch.
The prop types package should have an equal API with React.PropTypes, with only two exceptions:

Validator functions cannot be called, which there seem to be none.
React.checkPropTypes  is now PropTypes.checkPropTypes. Two occurences were updated.

looks good. @hramos

I think all of the remaining callsites have been fixed in https://github.com/facebook/react-native/commit/50b11aa09b479e5ce8b06de98e02ba1dd6a8cca3


Divide signal to epochs

Hi
I want to divide raw EEG signals into shorter frames using a standard overlapping window approach. How can I do in MNE python

This appears to be a question about usage, not a bug report or a new feature request. Please use the MNE mailing list or the gitter channel for usage questions.


Posting array of strings in multipart location

Is it possible to post array of multipart strings (files)? Right now I have to list each parameter manually, which isn't very flexible:
"parameters": {
    "files[0]": {
        "location": "multipart",
        "type": "any",
        "required": false
    },
    "files[1]": {
        "location": "multipart",
        "type": "any",
        "required": false
    },
}

I've also tried this:
"files": {
    "location": "multipart",
    "type": "array",
    "items": { "type": "string" },
},

but it doesn't work, because MultiPartLocation or Psr7\MultipartStream doesn't handle array properly.
Multipart additionalParameters would probably solve my issue, but I guess it hasn't been implemented yet. https://github.com/guzzle/guzzle-services/issues/125

Closing since stale - I'm doing a cleanup across the whole organization, to enable us to focus on the tickets that are still live and have interest. Please feel free to open a new issue if this still is important to you. :)


Unable to login - Extension failed activating

Extension version: 0.52.0
VSCode Version: 1.72.2
OS: Ubuntu (via SSH, host is Windows_NT x64)

Steps to Reproduce:

Install extension
Try to login

Eventually the login is established (I cannot confirm that) but got a blank content (no PR, no issue). In the debug log of the extension I got this

@gandroz it looks like you're on old versions of VS Code and the extension. Are you able to reproduce the issue with the latest versions of VS Code and the extension?

Sadly no, I dont have control on vscode deployment neither on the version of the extension. Maybe I am looking at a workaround ?

Based on the stack trace, it's failing when it tries to parse the URI you have set for the setting "github-enterprise.uri". Specifically, the scheme of the URI is invalid. Are you using GitHub Enterprise? What do you have "github-enterprise.uri" set to?

Yes I use Github enterprise with a URI like « git@github.my.url:Lab/my_repo.git »

I'm pretty sure that the scheme of a your URI can't contain @. The URI should be similar to what you'd put in your browser URL bar if you wanted to view your repo in the browser. In this case, it looks like you should just remove the<EMAIL_ADDRESS>


Translation not work

As it, the translation doesn't work on the bundle

@nicodmf Could you please give me some more details? Environment? Installed packages? Steps to reproduce?
I can't do anything with just a "doesn't work" message, sorry.

I understand, but at this moment, i didn't have time to be precise. In my memory, the problem was :

the translation message doesn't show up
i should write my own tranlation file and the problem was correct

@nicodmf Could you please provide:
The composer show command result from your project?
The code part using the not working assert?
Thanks.

beberlei/DoctrineExtensions              v1.0.15
behat/behat                              v3.3.0
behat/gherkin                            v4.4.5
behat/mink                               v1.7.1
behat/mink-browserkit-driver             v1.3.2
behat/mink-extension                     v2.2
behat/mink-goutte-driver                 v1.2.1
behat/mink-selenium2-driver              v1.3.1
behat/symfony2-extension                 2.1.1
behat/transliterator                     v1.2.0
behatch/contexts                         2.6.1
cocur/slugify                            v2.5
composer/ca-bundle                       1.0.7
container-interop/container-interop      1.2.0
doctrine/annotations                     v1.4.0
doctrine/cache                           v1.6.1
doctrine/collections                     v1.4.0
doctrine/common                          v2.7.2
doctrine/data-fixtures                   v1.2.2
doctrine/dbal                            v2.5.12
doctrine/doctrine-bundle                 1.6.7
doctrine/doctrine-cache-bundle           1.3.0
doctrine/inflector                       v1.1.0
doctrine/instantiator                    1.0.5
doctrine/lexer                           v1.0.1
doctrine/orm                             v2.5.6
ezsystems/privacy-cookie-bundle          dev-master c967a14
fabpot/goutte                            v3.2.1
fresh/doctrine-enum-bundle               v5.0.0
friendsofsymfony/user-bundle             v2.0.0
fzaninotto/faker                         v1.6.0
gedmo/doctrine-extensions                v2.4.27
giggsey/libphonenumber-for-php           8.4.2
giggsey/locale                           1.3
guzzlehttp/guzzle                        6.2.3
guzzlehttp/promises                      v1.3.1
guzzlehttp/psr7                          1.4.2
hautelook/alice-bundle                   v1.4.1
incenteev/composer-parameter-handler     v2.1.2
instaclick/php-webdriver                 1.4.3
jdorn/sql-formatter                      v1.2.17
jms/i18n-routing-bundle                  2.0.0
jms/metadata                             1.6.0
justinrainbow/json-schema                1.6.1
knplabs/knp-menu                         2.2.0
knplabs/knp-menu-bundle                  2.1.3
kriswallsmith/assetic                    v1.4.0
lexik/translation-bundle                 v4.0.2
monolog/monolog                          1.22.1
nelmio/alice                             v2.3.1
ocramius/proxy-manager                   1.0.2
paragonie/random_compat                  v2.0.10
psr/cache                                1.0.1
psr/container                            1.0.0
psr/http-message                         1.0.1
psr/log                                  1.0.2
ronanguilloux/isocodes                   2.1.1
sensio/distribution-bundle               v5.0.18
sensio/framework-extra-bundle            v3.0.25
sensio/generator-bundle                  v3.1.4
sensiolabs/security-checker              v4.0.4
simplethings/entity-audit-bundle         v1.0.4
sllh/iso-codes-validator                 v3.0.0
sonata-project/admin-bundle              3.16.0
sonata-project/block-bundle              3.3.2
sonata-project/cache                     1.0.7
sonata-project/core-bundle               3.3.0
sonata-project/datagrid-bundle           2.2.1
sonata-project/doctrine-orm-admin-bundle 3.1.4
sonata-project/exporter                  1.7.1
swiftmailer/swiftmailer                  v5.4.7
symfony/assetic-bundle                   v2.8.1
symfony/monolog-bundle                   v3.1.0
symfony/phpunit-bridge                   v3.2.7
symfony/polyfill-apcu                    v1.3.0
symfony/polyfill-intl-icu                v1.3.0
symfony/polyfill-mbstring                v1.3.0
symfony/polyfill-php56                   v1.3.0
symfony/polyfill-php70                   v1.3.0
symfony/polyfill-util                    v1.3.0
symfony/security-acl                     v3.0.0
symfony/swiftmailer-bundle               v2.5.4
symfony/symfony                          v3.2.7
true/punycode                            v2.1.1
twig/extensions                          v1.4.1
twig/twig                                v1.33.2
vich/uploader-bundle                     1.4.0
webfactory/exceptions-bundle             4.3.1
zendframework/zend-code                  2.6.3
zendframework/zend-eventmanager          3.1.0
form type
<?php
//...
class WorkCouncilType extends AbstractType
{
    /**
     * {@inheritdoc}
     */
    public function buildForm(FormBuilderInterface $builder, array $options)
    {
        $builder
             //...
            ->add('company_registration_number', null, ['required'=>true])
        ;
    }

Resources/config/validation.yml
AppBundle\Entity\WorkCouncil:
    properties:
        company_registration_number:
            - SLLH\IsoCodesValidator\Constraints\Siret: ~

translation/validators.fr.yml
This value is not a valid SIRET.: Ce code n'est pas un numéro SIRET valide.

So if I understand right, you are trying to override the translation? And this is what is not working.

If i don't override translation, the translations doesn't work

I just tried with the last 3.1.0 version, it's working:

The issue can't be reproduced and seems to be linked to your env.
Please empty your cache, remove your translations overrides and update to the last version.
If the problem persist and you have more clue to provide, feel free to re-open.


Data from the paper DOI not found

Dear Authors,
It looks like the zenodo link has expired, when I try to access it it shows an error page with DOI NOT FOUND. Would you mind kindly fix it? Thank you!
Thanks,
Curtis(Yuchen) Wu

I also encountered this issue


Debug console fails to render if debug starts before revealing debug console

Uncovered by the smoke test on Linux:

Open workbench on a debuggable workspace, make sure Debug Console is not visible
F5 to Debug

Debug console comes up but empty.
If I open the Debug Console before starting to debug, everything works fine. This can be verified by adding the following snippet before this line in the smoketest:
await app.workbench.quickopen.runCommand('View: Debug Console');

Once that line is in, smoke test goes happy. Not suggesting that as a fix. :laughing:

To reproduce this issue outside of the smoketest:

make sure to have "debug.internalConsoleOptions" set to "openOnFirstSessionStart"
close panel with debug console, terminal etc. in workspace
quit VS Code
start VS Code
start debugging with F5

Observe:

the panel opens with debug console but stays empty
clicking in the REPL text box shows the message to start a debug session

@weinand thanks for nice repro steps. Good catch, thank god for the smoke test :)
Will fix later today / tomorrow


Turn EME test 6 into audio only

In some embedded platforms test number 6 creates a bunch of video sessions that can lead to exhausting video memory because of hardware limitations. I think the spirit of the test would be the same if we turned it to audio instead of video as you could still create several sessions without involving video memory.

Thanks reporting, we will create an internal bug for this.

Thanks reporting, we will create an internal bug for this.


Separate CMDlet to create CertMaster App Service

Takes App ID and Tenant ID as input. Also resource group, SCEPman URL, etc. as required.

Required if you don't want to use Managed Identities for SCEPman


Change how reserved columns work to have an underscore prefix

Right now I've implemented it such that id and commit and version and item are reserved columns, and any user-provided data with those columns gets renamed to commit_ and id_ and so-on - see #8.
I've changed my mind. I think this tool's columns should all have a _ prefix instead (like semi-private class properties in Python).
I'm even going to do that for the _id column, mainly so I don't have to explain a special case for id.

I'm also going to change how "banned" columns work. Currently if your data has a item_ column the tool raises an error. The new reserved column will be _item but my rule will be that if your column is reserved I'll add a trailing _ to it - and if you also have a _item_ column I'll rename that to _item__ and so-on.

I'm going to split out some of this logic into a utils.py module, and write some separate tests for it.

Well this was a mistake... Datasette treats columns that start with an underscore as querystring parameters it should ignore!
Switching to underscore suffixes instead.

... I do like underscore prefixes though. I'm tempted to fix the bug I filed in Datasette instead and keep this:

https://github.com/simonw/datasette/issues/1506

I released Datasette 0.59.2 with a fix for this, so I'm free to use _id and friends here.


Dictionary API

Brief Description 🤓
Dictionary API is use for any english literature project of any geammer project which is used to find the meaning of words and where you can search for words and it outputs word meaning, word pronunciation, audio pronunciation and usage example
Provide reference!
https://dictionaryapi.dev/
Select the open source program you are contributing to
Other
Code of Conduct

[X] I follow CONTRIBUTING GUIDELINES of this project.

Greetings @kartikmehta18🎀 ! , We are excited to have you dive into another issue with us!🚀
Your involvement in our project has been invaluable, and we're confident that your skills and insights will help us conquer this challenge😇.  Use command /gssoc24 to self assign the issue.  This issue represents an exciting opportunity for us to improve and enhance our project, and we are thrilled to have you on board.
We request you to follow CONTRIBUTING GUIDELINES.
Looking for your PR soon!
In case of any issues, you can contact us on Discord.❣

/gssoc24


Update BASE_VERSION to master-2022-04-27T16-55-55

2022-04-27T16:55:50.374Z	INFO	Need to update DB
2022-04-27T16:55:50.374Z	INFO	DB Repository: ghcr.io/aquasecurity/trivy-db
2022-04-27T16:55:50.374Z	INFO	Downloading DB...
2022-04-27T16:55:55.438Z	INFO	Detected OS: ubuntu
2022-04-27T16:55:55.438Z	INFO	Detecting Ubuntu vulnerabilities...
2022-04-27T16:55:55.442Z	INFO	Number of language-specific files: 0

istio/base:master-2022-04-25T20-21-10 (ubuntu 20.04)
====================================================
Total: 0 (UNKNOWN: 0, LOW: 0, MEDIUM: 0, HIGH: 0, CRITICAL: 0)

@istio-testing: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-distroless_istio
4bddc4b190ce2ae77fea6c1fc46540c3d2efca28
link
unknown
/test integ-distroless_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest


WalletLink insert HTML outside of body

By using walletlink like this (on demand)
const WalletLink = (await import('walletlink')).default;
const walletLink = new WalletLink({ appName: '...', appLogoUrl: '...' });

It seems to insert it's style and html outside of body, which breaks stuff as it's not valid HTML.

Using latest<EMAIL_ADDRESS>Walletlink have to insert it's HTML & STYLE only inside of BODY. Otherwise it will produce incorrect HTML which might not work.

This was to prevent web frameworks that try to re-render the entire content of the body from removing walletlink's html, most browsers are forgiving and this shouldn't result in issues though. Are you running into any issues?

This was to prevent web frameworks that try to re-render the entire content of the body from removing walletlink's html, most browsers are forgiving and this shouldn't result in issues though. Are you running into any issues?

hi. sorry for the belated response. we are marking stale issues closed for now. please try our latest version 3.6.0. feel free to open a new one if needed. thanks.


Automate version bump

Automating version bumps may be tedious to get right in a fully automated
way.
Instead we could add a Travis step that checks that the semver number has
changed, and fail the build if it hasn't.
This step would only be enabled when travis is triggered for Pull-Requests
builds over master as we don't want to be bothered at every commit on dev
branches.
In that way if a developer forgot to change the version in his PR, it's PR
status will remain Failed as long as the version hasn't changed. BUT we
still keep the possibility to merge the PR without changing the semver
number (for ex for a cosmetics only branch), even if the PR build is
failed, the master status would still be Passed because the check would not
be active on the Travis build triggered after having merged the PR
Le 13 avr. 2017 17:11, "Matteo Bertini"<EMAIL_ADDRESS>a écrit :

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/develersrl/git-externals/issues/35, or mute the
thread
https://github.com/notifications/unsubscribe-auth/AAdF6pZeHeLJ26cnV42fJ3Hk2u4H9fKGks5rvjs0gaJpZM4M80-k
.

The main reason for this issue is to let users know if the current version they have installed on the computer is up to date with the current master. So incrementing manually the patch number could be enough.


[SMI] SMI Conformance Testing Support

Enhancement Description
Verify the SMI-compatibility of Consul against the standard suite of compliance tests.

Hi @kumarabd, I've had a look at the OSM adapter wrt SMI conformance testing to gain an overview.
If I understand correctly, labels and annotations defined here osm/smi_conformance.go:12 are for namespaces, and the deployments used in the tests are e.g. smi-conformance/test-gen/test-yamls/traffic-access/02-install.yaml.
Is it possible to either specify mesh specific deployments, and/or specify pod specific annotations?

Uhmm if its insisting on pod specific annotations then I'm afraid we don't have that ability at the moment. @leecalcote  Can we discuss over it once before we move forward for consul? Thanks for highlighting @mgfeller

@mgfeller will you make a comment in reference to this issue in https://docs.google.com/document/d/1HL8Sk7NSLLj-9PRqoHYVIGyU6fZxUQFotrxbmfFtjwc/edit#?

@mgfeller will you make a comment in reference to this issue in https://docs.google.com/document/d/1HL8Sk7NSLLj-9PRqoHYVIGyU6fZxUQFotrxbmfFtjwc/edit#?

https://docs.google.com/document/d/1HL8Sk7NSLLj-9PRqoHYVIGyU6fZxUQFotrxbmfFtjwc/edit?disco=AAAAKwf2IiE
Consul deployment: https://github.com/layer5io/learn-layer5/blob/master/deploy/k8s-consul.yaml
I should most probably look more closely at SMI and how it is supposed to work exactly :-)

https://github.com/hashicorp/consul-smi-controller
https://www.hashicorp.com/blog/hashicorp-consul-supports-microsoft-s-new-service-mesh-framework
https://youtu.be/e5kv9E48Bac
https://youtu.be/nlg3yiCNmY8
https://youtu.be/YgFoAdeMooM

Copied from Slack conversation, omitting mentions.
Michael Gfeller Dec 9th at 9:09 PM
Consul required a controller for SMI (https://github.com/hashicorp/consul-smi-controller).
As far as I can make out, this is still the case. The corresponding repository hasn't been updated in a while, and appears to cover a subset of the spec only.
What is the state and plan for the controller? Does it work with Consul 1.8+?
As discussed in our SMI doc, the deployment manifest for learn-layer5 needs to be adjusted for Consul. (A future release of Consul might make this unnecessary.)
This leads to a significant change in the SMI conformance testing code; the extent depends on the approach chosen. AFAIK, it is also being considered to re-implement the SMI conformance tool.
What should we do?

wait for new version of Consul, updated controller, redesigned SMI conformance tool?
deciding on and implementing Consul specific adjustments of the conformance tool, testing the controller, etc?
other?

See also https://github.com/layer5io/meshery-consul/issues/106
Lee Abishek Kumar
blake  1 day ago
As far as I know this controller has not been tested with Consul 1.8.
It was originally built when SMI was fairly new, and had not yet been adopted much in the industry. Now that its gaining traction and other service meshes like OSM, NGINX SM, etc are using it we are looking at opportunities to build out further support in Consul.
To be honest though, this will be driven by requests from our customers and community. At the moment, folks seem more interested in us building out other capabilities over SMI.
Michael Gfeller  1 day ago
Thanks for the feedback and clarification, blake!
Nic Jackson  21 hours ago
If we get approval to update the SMI spec i will pick this up again but SMI is pretty light on features at the mo
Lee  11 hours ago
Thank you, gents. We’re meeting with NGINX on SMI Conformance tomorrow. Michael Gfeller let’s opt for # 1.
Michael Gfeller  < 1 minute ago
Thanks!
I copy this conversation to the issue for doc purposes :slightly_smiling_face:

Consul 1.10 is out (https://www.consul.io/docs/release-notes/1-10-0), now supporting transparent proxies. Once this version is supported in the adapter, we could have a look at this issue again.


Change the "Based on work" link

The source as is displays the single link on the browser (tested on Firefox and Chrome)  "[https://github.com/HaxeFoundation/HaxeManual](https://github.com/HaxeFoundation/HaxeManual)". So, as expected, this redirects the user to a 404 page on github. I don't think this is intendend.
I changed the link description to "Haxe Manual on GitHub", but it's just a suggestion. You may have a better description for it.

I don't understand what this is supposed to address. Where does a 404 happen?

On the page http://haxe.org/manual/introduction-license.html when you click the link "Based on a work at "
You should try this on your browser.

Hmm, the generated markdown is fine: https://github.com/HaxeFoundation/HaxeManual/blob/master/output/HaxeManual/website/introduction-license.md
This might be an issue with haxe-markdown @dpeek.

Were you able to see the issue in the page?
Probably happens when you give another link as the target link's display name

Yes but I don't think it should happen, it's likely a problem with the haxe-markdown conversion and your change merely sidesteps the issue. I prefer the current version so I'll go ahead and close this.

Yep, that makes sense. Hope this helps fixing the issue.

Yes, thanks for letting me know about the 404!


session in core 1.1 framework

Moved from https://github.com/aspnet/EntityFrameworkCore/issues/13687 filed by @IsaaasI
I am trying to use session in core 1.1 framework but not work.
Any one please give me the best suitable way to use session in c# Core 1.1 solution .
The below error I face in my solution.

Also I tried to install Install-Package Microsoft.AspNet.WebApi.Owin -Version 5.2.6
and give me the below error

Any suggestion please .
Further technical details
Operating system:
IDE: (e.g. Visual Studio 2017 15.7.2)

Please read the session state chapter of the documentation. In order to access the session, you need to access the Session property on the HttpContext which is an ISession object.
So inside a controller, you need to do for example: HttpContext.Session.Get("Name")


Differentiating trigonometric functions with KernelGradients and CUDAKernels

The following code errors with
cannot handle (augmented) unknown intrinsic
  %1 = call i32 @llvm.nvvm.d2i.hi(double %a) #14

when dispatched on a CUDADevice. So far confirmed for sin and cos.
using CUDA
using KernelAbstractions
using CUDAKernels
using KernelGradients
using Enzyme

@kernel function cos_kernel!(y, x)
    I = @index(Global, Linear)

    y[I] = cos(x[I])
end

x = ones(10)
dx = zeros(10)
y = zeros(10)
dy = zeros(10)
cux = CuArray(x)
cuy = CuArray(y)
cudx = CuArray(dx)
cudy = CuArray(dy)

ev = autodiff(cos_kernel!(CPU()))(
    Duplicated(y, dy), Duplicated(x, dx), ndrange=length(x)
)
wait(ev)

# Breaks
ev = autodiff(cos_kernel!(CUDADevice()))(
    Duplicated(cuy, cudy), Duplicated(cux, cudx), ndrange=length(x)
)
wait(ev)

Similarly, I'm encountering problems for:

max (Float32):cannot handle (reverse) unknown intrinsic
llvm.nvvm.fmax.ftz.f
   %47 = call float @llvm.nvvm.fmax.ftz.f(float %44, float noundef 0.000000e+00) #6, !dbg !158

abs (Float32):cannot handle (reverse) unknown intrinsic
llvm.nvvm.fabs.ftz.f
   %47 = call float @llvm.nvvm.fabs.ftz.f(float %44) #6, !dbg !158

exp (Float32):cannot handle (reverse) unknown intrinsic
llvm.nvvm.fma.rn.ftz.f
  %49 = call float @llvm.nvvm.fma.rn.ftz.f(float %46, float noundef 0x3F777313A0000000, float noundef 5.000000e-01) #7, !dbg !209

@vchuravy fixing this basically just requires running the preservenvvm pass prior to enzyme for the libbc like we do in clang for other languages.
I can take a stab at this next week.

Should be fixed by #379

Will be fixed by*** not currently fixed by.

Having potentially similar issue with differentiating power function ^ with Enzyme.jl and CUDA.jl. Original issue is in
https://github.com/PTsolvers/PT-AD/blob/c697e809330be1e1aecf05c2a8505d3041546a62/scripts/adjoint_nonlin_diff_1D_cuda.jl#L7
and an MWE attempt is following:
using Enzyme
using CUDA

@inbounds function my_fun!(R,H,N)
    ix = (blockIdx().x-1) * blockDim().x + threadIdx().x
    if ix<=length(R)  R[ix] = H[ix]^N[ix]  end # fails <- targeted operation
    # if ix<=length(R)  R[ix] = H[ix]^2.0  end # fails
    # if ix<=length(R)  R[ix] = H[ix]^2  end # works
    return
end

function compute!(R,dR,H,dH,N)
    Enzyme.autodiff_deferred(my_fun!,Const,Duplicated(R,dR),Duplicated(H,dH),Const(N))
    return
end

function mwe()
    R  = CUDA.rand(10)
    dR = CUDA.zeros(10)
    H  = CUDA.rand(10)
    dH = CUDA.zeros(10)
    N  = CUDA.rand(10)
    threads = 10

    @cuda threads=threads compute!(R,dR,H,dH,N); synchronize()

    return
end

mwe()

That PR should presently handle pow/exp/sqrt/etc if you want to try it.
However, it does not yet handle sin/cos, which requires further thought of GPUCompiler pipeline ordering.
As for abs/max, those will work when a JLL bump containing https://github.com/EnzymeAD/Enzyme/pull/740 lands.

That PR should presently handle pow/exp/sqrt/etc if you want to try it.

It indeed fixes the ^ issue wrt to this call:
https://github.com/PTsolvers/PT-AD/blob/c697e809330be1e1aecf05c2a8505d3041546a62/scripts/adjoint_nonlin_diff_1D_cuda.jl#L115
But now it fails on this call:
https://github.com/PTsolvers/PT-AD/blob/c697e809330be1e1aecf05c2a8505d3041546a62/scripts/adjoint_nonlin_diff_1D_cuda.jl#L133
with
ERROR: LLVM error: Undefined external symbol "log"
Stacktrace:
  [1] handle_error(reason::Cstring)
    @ LLVM ~/.julia/packages/LLVM/WjSQG/src/core/context.jl:105
  [2] LLVMTargetMachineEmitToMemoryBuffer
    @ ~/.julia/packages/LLVM/WjSQG/lib/12/libLLVM_h.jl:965 [inlined]
  [3] emit(tm::LLVM.TargetMachine, mod::LLVM.Module, filetype::LLVM.API.LLVMCodeGenFileType)
    @ LLVM ~/.julia/packages/LLVM/WjSQG/src/targetmachine.jl:45
  [4] mcgen(job::GPUCompiler.CompilerJob, mod::LLVM.Module, format::LLVM.API.LLVMCodeGenFileType)
    @ GPUCompiler ~/.julia/packages/GPUCompiler/iaKrd/src/mcgen.jl:73
  [5] macro expansion
    @ ~/.julia/packages/TimerOutputs/jgSVI/src/TimerOutput.jl:252 [inlined]
  [6] macro expansion
    @ ~/.julia/packages/GPUCompiler/iaKrd/src/driver.jl:426 [inlined]
  [7] macro expansion
    @ ~/.julia/packages/TimerOutputs/jgSVI/src/TimerOutput.jl:252 [inlined]
  [8] macro expansion
    @ ~/.julia/packages/GPUCompiler/iaKrd/src/driver.jl:423 [inlined]
  [9] emit_asm(job::GPUCompiler.CompilerJob, ir::LLVM.Module; strip::Bool, validate::Bool, format::LLVM.API.LLVMCodeGenFileType)
    @ GPUCompiler ~/.julia/packages/GPUCompiler/iaKrd/src/utils.jl:64
 [10] cufunction_compile(job::GPUCompiler.CompilerJob, ctx::LLVM.Context)
    @ CUDA ~/.julia/packages/CUDA/tTK8Y/src/compiler/execution.jl:354
 [11] #224
    @ ~/.julia/packages/CUDA/tTK8Y/src/compiler/execution.jl:347 [inlined]
 [12] JuliaContext(f::CUDA.var"#224#225"{GPUCompiler.CompilerJob{GPUCompiler.PTXCompilerTarget, CUDA.CUDACompilerParams, GPUCompiler.FunctionSpec{typeof(cost_grad!), Tuple{CuDeviceVector{Float64, 1}, CuDeviceVector{Float64, 1}, CuDeviceVector{Float64, 1}, CuDeviceVector{Float64, 1}, CuDeviceVector{Float64, 1}, Float64}}}})
    @ GPUCompiler ~/.julia/packages/GPUCompiler/iaKrd/src/driver.jl:74
 [13] cufunction_compile(job::GPUCompiler.CompilerJob)
    @ CUDA ~/.julia/packages/CUDA/tTK8Y/src/compiler/execution.jl:346
 [14] cached_compilation(cache::Dict{UInt64, Any}, job::GPUCompiler.CompilerJob, compiler::typeof(CUDA.cufunction_compile), linker::typeof(CUDA.cufunction_link))
    @ GPUCompiler ~/.julia/packages/GPUCompiler/iaKrd/src/cache.jl:90
 [15] cufunction(f::typeof(cost_grad!), tt::Type{Tuple{CuDeviceVector{Float64, 1}, CuDeviceVector{Float64, 1}, CuDeviceVector{Float64, 1}, CuDeviceVector{Float64, 1}, CuDeviceVector{Float64, 1}, Float64}}; name::Nothing, kwargs::Base.Pairs{Symbol, Union{}, Tuple{}, NamedTuple{(), Tuple{}}})
    @ CUDA ~/.julia/packages/CUDA/tTK8Y/src/compiler/execution.jl:299
 [16] cufunction
    @ ~/.julia/packages/CUDA/tTK8Y/src/compiler/execution.jl:293 [inlined]
 [17] macro expansion
    @ ~/.julia/packages/CUDA/tTK8Y/src/compiler/execution.jl:102 [inlined]
 [18] main()
    @ Main /scratch-1/luraess/PT-AD/scripts/adjoint_nonlin_diff_1D_cuda.jl:133
 [19] top-level scope
    @ /scratch-1/luraess/PT-AD/scripts/adjoint_nonlin_diff_1D_cuda.jl:142

Yeah in that case pow will also require the same pipeline work as sin/cos.
In essence the extra required work is that GPUCompiler drops the definitions of other CUDA math functions, except for the ones used in the kernel being compiled. For functions like sqrt/exp where the derivatives only use those functions, that's fine. However as d/dx sin => cos and likewise you need log to compute the derivative of pow, some extra pipeline work in GPUCompiler is needed to have those be preserved.

I see, thanks for the insights!
Any possibility to get something fixed in the coming week? I was preparing some demo to feature GPU AD in a JuliaCon minisymposium talk the weak after 😅

These should be fixed upon landing of https://github.com/JuliaGPU/GPUCompiler.jl/pull/349 in GPUCompiler and https://github.com/EnzymeAD/Enzyme/pull/741 in Enzyme proper with corresponding jll bump.

Thanks for the quick responses and the fix @wsmoses!

Any ETA for landing, or is there a way to test these changes before landing? Unfortunately, my Julia package-fu is not the greatest...

It’s basically just waiting on https://github.com/JuliaGPU/GPUCompiler.jl/pull/349 to be merged and propagated in a version bump which is unfortunately out of my control
cc @vchuravy

This has now landed on main

@wsmoses As a follow up, the above code now throws:
ERROR: LoadError: LLVM error: Cannot select: 0xa4fdc20: f64 = fsin nnan ninf nsz arcp contract afn reassoc 0xa4fe6b0
  0xa4fe6b0: f64,ch = CopyFromReg 0x3176db8, Register:f64 %27
    0x9c11230: f64 = Register %27
In function: _Z13julia_df_511916CompilerMetadataI11DynamicSize12DynamicCheckv16CartesianIndicesILi1E5TupleI5OneToI5Int64EEE7NDRangeILi1ES0_S0_S2_ILi1ES3_IS4_IS5_EEES2_ILi1ES3_IS4_IS5_EEEEE10DuplicatedI13CuDeviceArrayI7Float64Li1ELi1EEES7_IS8_IS9_Li1ELi1EEE

This has now landed on main

GPUCompiler changes got released. What's needed on Enzyme.jl's side to get the fixes incorporated?

Try main again now and reopen if not resolved @michel2323


[Auto-generated] Update dependencies

Update dependencies
Automatically created PR from ci/dependabot-updates.
The PR is based on the 'CI - Update dependencies PR' workflow in SINTEF/ci-cd.
To do

[ ] Check that the diff is sensible, and that tests and builds pass with the new dependency versions.
[ ] Make sure that the PR is squash merged, with a sensible commit message.

Codecov Report

Merging #505 (1e7858e) into master (c414377) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #505   +/-   ##
=======================================
  Coverage   63.06%   63.06%
=======================================
  Files          16       16
  Lines        3081     3081
=======================================
  Hits         1943     1943
  Misses       1138     1138

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Add support to read from CNAB/Distribution API

OCI Distribution Specification: https://github.com/opencontainers/distribution-spec/blob/main/spec.md

Not very useful either. Closing.


Show URL title in article list

From 20200729
We can display URL's title text in article list.
Figma:

Desktop https://www.figma.com/file/DvmAQjMJCncuPORWKnljM1/Cofacts-website-MrOrz-s-copy?node-id=2675%3A221
Mobile https://www.figma.com/file/DvmAQjMJCncuPORWKnljM1/Cofacts-website-MrOrz-s-copy?node-id=2673%3A220

I'll try to do this one


[WIP] UI homepage  prototype

UI mock

This is just a static mock. @blrchen

Landing page already added


No FileSystem for scheme: gs

I am trying to add dependency in SparkApplication specification. I got the following error and no pod is created.
Here is the error by using "kubectl -n spark-namespace describe sparkapplication":
  Warning  SparkApplicationSubmissionFailed  5s (x5 over 107s)   spark-operator  failed to submit SparkApplication spark-k8s-poc: failed to run spark-submit for SparkApplication vrds-spark/spark-k8s-poc: Exception in thread "main" java.io.IOException: No FileSystem for scheme: gs
           at org.apache.hadoop.fs.FileSystem.getFileSystemClass(FileSystem.java:2660)
           at org.apache.hadoop.fs.FileSystem.createFileSystem(FileSystem.java:2667)
           at org.apache.hadoop.fs.FileSystem.access$200(FileSystem.java:94)
           at org.apache.hadoop.fs.FileSystem$Cache.getInternal(FileSystem.java:2703)
           at org.apache.hadoop.fs.FileSystem$Cache.get(FileSystem.java:2685)
           at org.apache.hadoop.fs.FileSystem.get(FileSystem.java:373)
           at org.apache.spark.deploy.DependencyUtils$.org$apache$spark$deploy$DependencyUtils$$resolveGlobPath(DependencyUtils.scala:190)
           at org.apache.spark.deploy.DependencyUtils$$anonfun$resolveGlobPaths$2.apply(DependencyUtils.scala:146)
           at org.apache.spark.deploy.DependencyUtils$$anonfun$resolveGlobPaths$2.apply(DependencyUtils.scala:144)
           at scala.collection.TraversableLike$$anonfun$flatMap$1.apply(TraversableLike.scala:241)
           at scala.collection.TraversableLike$$anonfun$flatMap$1.apply(TraversableLike.scala:241)
           at scala.collection.IndexedSeqOptimized$class.foreach(IndexedSeqOptimized.scala:33)
           at scala.collection.mutable.WrappedArray.foreach(WrappedArray.scala:35)
           at scala.collection.TraversableLike$class.flatMap(TraversableLike.scala:241)
           at scala.collection.AbstractTraversable.flatMap(Traversable.scala:104)
           at org.apache.spark.deploy.DependencyUtils$.resolveGlobPaths(DependencyUtils.scala:144)
           at org.apache.spark.deploy.SparkSubmit$$anonfun$prepareSubmitEnvironment$5.apply(SparkSubmit.scala:356)
           at org.apache.spark.deploy.SparkSubmit$$anonfun$prepareSubmitEnvironment$5.apply(SparkSubmit.scala:356)
           at scala.Option.map(Option.scala:146)
           at org.apache.spark.deploy.SparkSubmit.prepareSubmitEnvironment(SparkSubmit.scala:356)
           at org.apache.spark.deploy.SparkSubmit.submit(SparkSubmit.scala:143)
           at org.apache.spark.deploy.SparkSubmit.doSubmit(SparkSubmit.scala:86)
           at org.apache.spark.deploy.SparkSubmit$$anon$2.doSubmit(SparkSubmit.scala:924)
           at org.apache.spark.deploy.SparkSubmit$.main(SparkSubmit.scala:933)
           at org.apache.spark.deploy.SparkSubmit.main(SparkSubmit.scala)

Here is my SparkApplication specification yaml:
apiVersion: "sparkoperator.k8s.io/v1beta1"
kind: SparkApplication
metadata:
  name: spark-k8s-poc
  namespace: vrds-spark
spec:
  type: Python
  pythonVersion: "3"
  mode: cluster
  image: "ks-docker.maven.dev.abc.com/test/spark-k8s/spark-py:2.4.4"
  imagePullPolicy: Always
  mainApplicationFile: "local:///opt/spark/examples/src/main/python/pi.py"
  deps:
    jars:
      - gs://spark-lib/bigquery/spark-bigquery-latest.jar
  sparkVersion: "2.4.4"
  restartPolicy:
    type: Never
  driver:
    cores: 1
    coreLimit: "2000m"
    memory: "1024m"
    labels:
      version: 2.4.4
    serviceAccount: spark-sa
  executor:
    cores: 1
    coreLimit: "3000m"
    instances: 2
    memory: "1024m"
    labels:
      version: 2.4.4

I have configured core-site.xml correctly and verify there is no issue to access/download files from google cloud storage within python main file (I modified pi.py to access gs files). However,  it does not work if downloading dependency in the SparkApplication yaml (gs://spark-lib/bigquery/spark-bigquery-latest.jar).

How did you configure core-site.xml, did you add it to the driver container?

Yes, I did. As I mentioned above, I verified the configuration appears to be good, since I can access files from google cloud storage. for  example, it works if I write a code:
spark.read.csv('gs://temp_abc-dev/bbq_6d7518ae6a43470f96c6291a6b201053', header=True, inferSchema=True)
Otherwise, I don't think it will work without correct configuration in core-site.xml.
Below is my gs access configuration part in core-site.xml.

fs.gs.impl
com.google.cloud.hadoop.fs.gcs.GoogleHadoopFileSystem
The FileSystem for gs: (GCS) uris.

fs.AbstractFileSystem.gs.impl
com.google.cloud.hadoop.fs.gcs.GoogleHadoopFS
The AbstractFileSystem for gs: uris.

fs.gs.project.id
abc-dev

      Optional. Google Cloud Project ID with access to GCS buckets.
      Required only for list buckets and create bucket operations.

google.cloud.auth.service.account.enable
true

      Whether to use a service account for GCS authorization.
      Setting this property to `false` will disable use of service accounts for
      authentication.

google.cloud.auth.service.account.json.keyfile
/opt/spark/hdfs_spark_conf/servicekey.json

      The JSON key file of the service account used for GCS
      access when google.cloud.auth.service.account.enable is true.

Is this still an issue? The error seems thrown by the submission client invoked by the operator. I remember others reported similar issues. The solution seems to add necessary Hadoop configuration in the operator pod to make the Spark submission client to be aware of the gs:// FileSystem scheme.

The error shown above is caused by this code invoked by spark-submit: https://github.com/apache/spark/blob/87bd9c75df6b67bef903751269a4fd381f9140d9/core/src/main/scala/org/apache/spark/deploy/DependencyUtils.scala#L191.

Yeah, I still have the issue.  You confirm it is a bug?

It's not a bug. The default docker image for the operator doesn't have the necessary jar and config to resolve gs:// jars and files. If you have gs:// files or jars under spec.deps, spark-submit invoked within the operator container will fail to resolve them. I'm building a new operator image with the GCS connector jar and necessary Hadoop config.

Can you try this image for the operator: gcr.io/spark-operator/spark-operator:v2.4.5-SNAPSHOT-v1beta2-latest-gcp? If you install the operator through the Helm chart, you can change the image used by setting the following:
--set operatorVersion=gcr.io/spark-operator/spark-operator:v2.4.5-SNAPSHOT-v1beta2-latest-gcp

Closing this as it has been inactive. Feel free to reopen or create a new one if necessary.

@liyinan926 using --set operatorVersion=gcr.io/spark-operator/spark-operator:v1beta2-latest-gcp causes jobs to run with image gcr.io/spark-operator/spark:v2.4.4 but they still fail to pull from gs:// schema


How to use request queue

I want to take 3 request into a queue.  Do you have any idea?

You'll need to provide more detail for anyone to be able to answer your question. You'll also have better luck asking such a question on StackOverflow and tagging Alamofire.
Asking Questions
We don't use GitHub as a support forum. For any usage questions that are not specific to the project itself, please ask on Stack Overflow instead. By doing so, you'll be more likely to quickly solve your problem, and you'll allow anyone else with the same question to find the answer. This also allows maintainers to focus on improving the project for others.


Removes unused templates

I couldn't find a reference to these two templates. Appears they are unused?
Removals

organisms/blog_introduction.html
organisms/layout-two-columns.html

Testing

Search for use of blog_introduction.html and layout-two-columns.html and verify they are unused.

@anselmbradford, this was the PR: https://github.com/cfpb/cfgov-refresh/pull/1945. I would go through it.

Looks like it may have been accidentally added as a duplicate of item-introduction.html


how make Character Counter count 2 character in newlines

Hello.
Please Help.
How I make the Character Counter count 2 characters in newlines?
The string It is stored in a database, and i need this function.
Thx.

This is something you need to write yourself if you want a new line to count twice. You can take a look at our code or look online to see how to do this.

thanks for answering.
I made a small change in the code and is now counting correctly.
Please, in the future consider adding this feature.
It will help many programmers who need to insert a textarea in the database.
And thanks for the amazing css. :)


Media message sometimes keep loading with SDWebImage

General information

Library version(s): 7.3.4
iOS version(s): 9.3
Devices/Simulators affected: iPhone and Simulator both affected
Reproducible in the demo project? (Yes/No): Yes if SD web is used
Related issues:

Bug report
Expected behavior
When sending media images or receiving I should have the images eventually load (there's a loading animation on the images). After it loads, I should easily see it next time I go on without loading since it's cached.
Actual behavior
When receiving media images, sometimes it loads right away but sometimes if it tries to load it will load indefinitely. I know it is done downloading because if I trigger a reload of collection view either through messaging something or going back to main view and coming back to the same viewcontroller it will show up. If I close my app and restart it, the pictures I have finished downloading should show up instead it will show up as loading again for indefinitely. It only happens to the ones most recent, the old ones are all okay.
Steps to reproduce

Use SD image to download images for media bubbles
Send images possibly on a slower internet where it takes more than a few milliseconds to load

Crash log? Screenshots? Videos? Sample project?
The way I did this was I would receive a message containing a url and I download it and return back a JSQMessage that contains a media bubble. I tried reloading the collectionview at that index or reloading entire collectionview with a completion block in SD web but it ends up with a endless loop.
I'm not sure if this is currently a fault of SDweb or JSQMessageController. I have tried using Kingfisher as an image caching and downloading with relatively the same results.
Here's the code:
    override func collectionView(collectionView: JSQMessagesCollectionView!, messageDataForItemAtIndexPath indexPath: NSIndexPath!) -> JSQMessageData! {
        let message = self.messages[indexPath.item]

        if (message.body!.rangeOfString ("An image https://x.com/uploads/") != nil) {

            let types: NSTextCheckingType = .Link

            let detector = try? NSDataDetector(types: types.rawValue)

            guard let detect = detector else {
                let JSQTypeMessage = JSQMessage(senderId: message.from, senderDisplayName: message.from, date: message.date, text: message.body)

                return JSQTypeMessage
            }

            let matches = detect.matchesInString(message.body!, options: .ReportCompletion, range: NSMakeRange(0, message.body!.characters.count))

            var stringUrl:NSURL?

            stringUrl = matches[0].URL!

            let tempImageView = UIImageView(image: nil)
            tempImageView.sd_setImageWithURL(stringUrl, completed: nil)

            let photoImage = JSQPhotoMediaItem(image: tempImageView.image)

            // This makes it so the bubble can be incoming rather than just all outgoing.
            if !(message.from == self.senderId) {
                photoImage.appliesMediaViewMaskAsOutgoing = false
            }

            let message = JSQMessage(senderId: message.from, displayName: self.senderDisplayName, media: photoImage)
            return message
        }

        let JSQTypeMessage = JSQMessage(senderId: message.from, senderDisplayName: message.from, date: message.date, text: message.body)

        return JSQTypeMessage
    }

Thanks @alberttai1 ! :smile:
This doesn't seem specific to the library. StackOverflow is a more appropriate place to ask this question. :blush:
We can't provide support for SDWebImage, only JSQ 😊 Sorry!
I'm going to close this issue, but the community should feel free to continue the discussion here.
Other ways to get help:

Ask on StackOverflow with the jsqmessagesviewcontroller tag
See the FAQ
Search previous questions

Thanks @jessesquires I'll post on there. I just wasn't sure if it was a JSQ problem since it has a loading view for media as well (which I'm not totally sure how to use).

@alberttai1 did you solved this issue ever.?

I believe we did, it's quite fuzzy cause we paused the image sharing feature for the time being

any workaround for this? I have wasted 4 days on this issue not getting anywhere


Zulu w/o colon

To support formats that don't incude the final colon in the time zone offset, you need to change the regex:
$.format.date("2011-09-22T05:02:55.889+0000", "dd/mm/yyyy hh:mm:ss")
// fails because "+0000" doesn't include a colon, but this is a valid alternate format for ISO 8601
"The following times all refer to the same moment: "18:30Z", "22:30+04", "1130-0700", and "15:00-03:30" (http://en.wikipedia.org/wiki/ISO_8601#Time_zone_designators)
It's a single character fix:
line 93:
} else if (value.search(/\d{4}-\d{2}-\d{2}T\d{2}:\d{2}:\d{2}.?\d{0,3}[-+]?\d{2}:\d{2}/) != -1) { /* 2009-04-19T16:11:05+02:00 /
should be:
} else if (value.search(/\d{4}-\d{2}-\d{2}T\d{2}:\d{2}:\d{2}.?\d{0,3}[-+]?\d{2}:?\d{2}/) != -1) { / 2009-04-19T16:11:05+02:00 */
(there's a question mark after the final colon to match zero or one colon).

Thank you. I added your code. :)


Fix compaction not working for system topic

Motivation
If a topic only have non-durable subscriptions but not durable subscriptions,
and the non-durable subscription reaches the end of the topic, we will get 0 estimated backlog size
So that the compaction will never be triggered.
The expected behavior is if we have no durable subscriptions, we should use the total size for triggering
the compaction.
Verifying this change
New tests added for ensuring the system topic been compacted.
Does this pull request potentially affect one of the following parts:
If yes was chosen, please highlight the changes

Dependencies (does it add or upgrade a dependency): (no)
The public API: (no)
The schema: (no)
The default values of configurations: (no)
The wire protocol: (no)
The rest endpoints: (no)
The admin cli options: (no)
Anything that affects deployment: (no)

Documentation

Does this pull request introduces a new feature? (no)

@315157973 No, the topic policy already created a reader for reading data from the system topic, so in the test I have
check the cacheIsInitialized first to make sure the reader been created.


Relaxed DST field ordering

Summary
Relax the requirements on struct field ordering for dynamically sized fields:

for repr(Rust), ?Sized fields can be anywhere in the field list, as long as there is only one
for repr(C), ?Sized fields only have to be the last non-ZST field, and can be followed by ZST fields
for repr(transparent), apply both rules, since only one non-ZST field is allowed anyway

Rendered

Also going to pre-empt this because, while it's not mentioned in the RFC because I genuinely could not find any info in the reference about it, it will probably come up:
What do we do about references to ZST fields after the DST in repr(C) structs? I'll be honest, I have no idea if references to ZST fields are even meaningful/useful or used, but right now there appears to be no documentation on it.
If people actually use references to ZST fields in repr(C) structs, I propose defining fields after the DST field to always have the same offset as the DST field itself, i.e., if said field were zero. We can treat this internally be reordering the ZSTs right before the DST.
But I had been effectively treating this RFC as if every reference to a ZST doesn't matter, and if people use ptr::eq for them they're doing something wrong and unspecified. Although I'm sure this is interesting enough to give a few people a headache!

[in repr(C) structs] I propose defining fields after the DST field to always have the same offset as the DST field itself, i.e., if said field were zero. We can treat this internally be reordering the ZSTs right before the DST.

I don't think we should allow putting fields after the DST tail in a repr(C) struct if they are just going to be reordered anyway. IMO the field order should be consistent[^1]; either we don't allow fields after the DST tail in repr(C) structs, or we allow them and they are at an appropriate (dynamic) offset after the DST tail (though it's IMO fine if this is restricted to ZST fields, for now).

But I had been effectively treating this RFC as if every reference to a ZST doesn't matter, and if people use ptr::eq for them they're doing something wrong and unspecified.

I'm not sure what you mean here, but I don't think it is reasonable to assume that std::ptr::eq is unspecified or wrong for ZSTs; the documentation for that function does not currently have any exceptions for ZSTs.
[^1]: i.e. in a repr(C) struct, each field should be at offset prev_field_offset + prev_field_size, rounded up to this field's alignment, with the first field at offset 0.

I'm not sure what you mean here, but I don't think it is reasonable to assume that std::ptr::eq is unspecified or wrong for ZSTs; the documentation for that function does not currently have any exceptions for ZSTs.

You're right that you can make two ZST pointers (and indeed, *const () is a common pointer), but what I'm specifically talking about is whether taking a reference to a ZST ever creates a pointer inside its struct at all. Yeah, the lifetime rules seem to imply that, but if let value = (); takes up zero memory and does literally nothing, then how can I be certain that &value actually refers to a location on the stack at all?

whether taking a reference to a ZST ever creates a pointer inside its struct at all.

Yes, &struct.field will give a pointer that is inbounds of struct[^1].

but if let value = (); takes up zero memory and does literally nothing, then how can I be certain that &value actually refers to a location on the stack at all?

Formally, you can't assume that let value = (); exists on the stack because the stack is not a concept that exists in the context of the Rust Abstract Machine, but this is not specific to ZSTs. It might even be valid for rustc to put let value = [1, 2, 3]; into static memory, for example[^2]. AFAICT, rustc currently never makes locals into statics, so currently let value = (); will have an address on the stack.

ZST statics all point to the same dangling value

While this would be valid, this is not how rustc currently works AFAICT. Currently static X: () = (); will have an address in the same area as other (immutable) statics, and may or may not have the same address as other statics.

For more info: see https://github.com/rust-lang/unsafe-code-guidelines/issues/503
[^1]: assuming no autoderefing
[^2]:  assuming that it is decided that non-mut locals are not mutable (which is not yet decided IIUC), and/or it is never mutated, and/or possibly other requirements

I don't really understand the motivation for this change. In general, it's nice that I don't have to worry about what's the most space-efficient field order in my types (especially if it depends on type parameters) unless I already care about their layout and therefore add repr attributes. However, in the rare case when I author (or even just look at the implementation of) a type wrapping a DST, I already have to be consciously thinking about memory layout to some degree. It's especially prominent if there are other (size > 0 or align > 1) fields in the mix because the only useful way to think of such a type is "some fixed-size header data followed by the DST". Reflecting this in the source code doesn't seem unnatural or like a chore that I'd want to delegate to the compiler. For example, consider the custom Arc-likes in rowan and triomphe.
I don't want to rule out that there's code where this RFC might be nice to have. But is a "nice to have" feature worth the can of worms w.r.t. ZST addresses and the repr(C) rules? Whatever the solution to that will be, I expect it will cast some doubt on the "simplifies the language" motivation.

I guess that my biggest motivation for this change is specifically for the ZST change: it's extremely common to put PhantomData markers at the end of a struct, but a DST disrupts this for what feels like no reason.
For repr(transparent), I feel like it'd be appropriate to just put all ZST offsets at the beginning, since the layout is supposed to be equivalent to the one non-ZST inside it. But I guess that I was overzealous with repr(C) and we really should just keep the requirement for that.

Since it seems too contentious, I've removed repr(C) and updated the reference-level explanation to allow reordering of ZSTs for repr(transparent). Since repr(transparent) is intended to treat the entire struct layout like it's the singular sized field, this makes sense, since it means that the offsets of all fields are zero.
I do apologise for kind of rushing this RFC out— it's been something that has come up a few times as being inconsistent (imho), and I kind of just wanted to start a discussion on it rather than opening a pre-RFC on internals, since it feels like said discussion wouldn't substantially impact the RFC contents.
I probably should have thought about repr(C) more and just been extra conservative to exclude it from these new rules at first, so, I've done that now.

I've not read the RFC in detail, just skimmed the OP, but I do think the rules regarding field ordering are somewhat silly given that (apart from #[repr(C)], etc) we don't guarantee field order so we can opt to reorder if we want to.
That said, I'd have to review, I seem to recall that rustc at least took advantage of this rule for a much more optimized sized check -- and maybe there are other details I've forgotten about.

Would love to know how those checks work, since my impression of how repr(Rust) worked is that it would sort fields by alignment and then just order them from least to most alignment, then put the DST at the end if there was one. By this model, it doesn't really matter where the DST is in the list since it has to be separated out anyway, but I guess that it being the last index already is mildly useful.

What about tuples? We often treat them like repr(Rust) structs, but the fact that the last field of a tuple can be resized actually has profound consequences: it means that in (T, U, V) we actually only reorder the first two fields, and the last field stays last. This is required to support tuple unsizing coercions.
The RFC should probably state explicitly that tuples still only support the last field to be unsized, and explain why.

This RFC also makes error reporting harder, since currently we can simply fire off a trait query ensuring all but the last field are sized. But with this RFC we'll have to somehow fire off a query for all fields, process the results, and if more than 1 returns "might not be sized" we have to figure out a good way to report the error. That should maybe be listed as a drawback.


Update documentation of tf.debugging.assert_shapes

@amitkumarj441 Can you please resolve conflicts? Thanks!

@amitkumarj441 Could you please address the reviewer comments and resolve conflicts? Thanks!

@amitkumarj441: I'm really sorry but I think I had a typo in my previous review. My comment should have read Though we accept tuples in v2 we only allow dictionaries in v1. Oops.
As the code has changed quite a bit, it seems like the v2 documentation has already been fixed. If you want you can go ahead and change the v1 documentation https://github.com/tensorflow/tensorflow/blob/master/tensorflow/python/ops/check_ops.py#L1661 to:
  tf.assert_shapes([
    (x, ('N', 'Q')),
    (y, ('N', 'D')),
    (param, ('Q',)),
    (scalar, ())
  ])

Sorry again for the confusion.

@amitkumarj441: I'm really sorry but I think I had a typo in my previous review. My comment should have read Though we accept tuples in v2 we only allow dictionaries in v1. Oops.
As the code has changed quite a bit, it seems like the v2 documentation has already been fixed. If you want you can go ahead and change the v1 documentation https://github.com/tensorflow/tensorflow/blob/master/tensorflow/python/ops/check_ops.py#L1661 to:
  tf.assert_shapes([
    (x, ('N', 'Q')),
    (y, ('N', 'D')),
    (param, ('Q',)),
    (scalar, ())
  ])

Sorry again for the confusion.

I have seen the changes in code, and I guess we need a fix here at L1602/L1609. Isn't it?

@amitkumarj441 Could you please address the reviewer comments and resolve conflicts? Thanks!

@gbaned @jaingaurav Any update?

I'll investigate why it didn't get automatically merged


ENOTCACHED error on bumped homepage-dashboard NPM package

Describe the bug
I'm trying to do a version bump on a package I maintain, homepage-dashboard. I've gone through a couple of iterations with the package already, but this time I'm bumping into a build issue I can't seem to get around.
Steps To Reproduce
Steps to reproduce the behavior:

Checkout my fork: git clone -b homepage-dashboard-0.6.25 https://github.com/jnsgruk/nixpkgs
Try to build the package: nix build -L .#legacyPackages.homepage-dashboard

The commit where I've bumped the version is here: https://github.com/jnsgruk/nixpkgs/commit/98f05d22e91972306764ecde63ac2752138ca991
Expected behavior
Rebuild the package with the new version.
Screenshots
@nix { "action": "setPhase", "phase": "unpackPhase" }
unpacking sources
unpacking source archive /nix/store/8m4cw906wq85xzdm4xd34388wblr8aix-source
source root is source
@nix { "action": "setPhase", "phase": "patchPhase" }
patching sources
Executing npmConfigHook
Configuring npm
Validating consistency between /build/source/package-lock.json and /nix/store/20db4b2zy71y20s01liq7r8xw381zxbj-homepage-dashboard-0.6.25-npm-deps/package-lock.json
Installing dependencies
npm ERR! code ENOTCACHED
npm ERR! request to https://registry.npmjs.org/gamedig failed: cache mode is 'only-if-cached' but no cached response is available.

npm ERR! Log files were not written due to an error writing to the directory: /nix/store/20db4b2zy71y20s01liq7r8xw381zxbj-homepage-dashboard-0.6.25-npm-deps/_logs
npm ERR! You can rerun the command with `--loglevel=verbose` to see the logs in your terminal

ERROR: npm failed to install dependencies

Here are a few things you can try, depending on the error:
1. Set `makeCacheWritable = true`
  Note that this won't help if npm is complaining about not being able to write to the logs directory -- look above that for the actual error.
2. Set `npmFlags = [ "--legacy-peer-deps" ]`

Notify maintainers
@NixOS/node
Metadata
Please run nix-shell -p nix-info --run "nix-info -m" and paste the result.
❯ nix-shell -p nix-info --run "nix-info -m"
these 2 paths will be fetched (0.02 MiB download, 0.05 MiB unpacked):
  /nix/store/jlx0nh7j7lfsi1sfjlvsp7f0bfjgnnaf-nix-info
  /nix/store/vfdg65hiv4bwls48588msw8la7452w2q-stdenv-linux
copying path '/nix/store/jlx0nh7j7lfsi1sfjlvsp7f0bfjgnnaf-nix-info' from 'https://cache.nixos.org'...
copying path '/nix/store/vfdg65hiv4bwls48588msw8la7452w2q-stdenv-linux' from 'https://cache.nixos.org'...
 - system: `"x86_64-linux"`
 - host os: `Linux 6.4.6, NixOS, 23.11 (Tapir), 23.11.20230731.fb94249`
 - multi-user?: `yes`
 - sandbox: `yes`
 - version: `nix-env (Nix) 2.15.1`
 - nixpkgs: `/nix/store/qxgp86sdhxwzj0k89kz2aaw0xw7d8f6i-source`

Ah interesting, thanks for the heads up. FTR I've filed a PR upstream and will bump on the next release :) https://github.com/benphelps/homepage/pull/1763


Resharper is having issues with finding views

Microsoft Visual Studio Enterprise 2017
Version 15.1 (26403.7) Release
In the controllers, Resharper highlights "View()" as red and says "Cannot resolve View 'ViewName'.
I target ".NETCoreApp 1.1" while AddFeatureFolders project targets "v4.5.2". Resharper doesn't have any issues when I open and run AddFeatureFolders.
Everything else works except that Resharper can't find views. I know this is a Resharper specific issue but I saw that you used Resharper inspection comments and that you might already have a fix for it.

I haven't tried it out but the issue you describe seems to be fixed according to ReSharper's issue tracker: https://youtrack.jetbrains.com/issue/RSRP-461882

My properties folder doesn't have a AspMvcViewLocationFormatAttribute.cs. I tried adding one but still didn't clear it up.

I think you need to install JetBrains ReSharper Annotations NuGet.

Updating to Resharper 2017.1.1 fixed it.


Remove version: FreeCiv.FreeCiv version 2.6.5

[Automated] It returns code over 400 in all urls
Microsoft Reviewers: Open in CodeFlow

Close with reason: Removal appears to be automated and in error;


Bug in toString a CometArray

I got a panic after using toString(anArray), because the builtin function toString is not supported for CometArray
>> var cc = [1, 2, 3]
CometNop
>> cc
[CometInt(1), CometInt(2), CometInt(3)]
>> println(cc)
&{3 [0xc0001020b0 0xc0001020b8 0xc0001020c0]}
CometNop
>> toString(cc)
panic: All types should have been exhausted!!

goroutine 1 [running]:
github.com/chermehdi/comet/std.ToString(0x667a58, 0xc0001042a0, 0x1)

I think, We have to implement two functions to represent objects as strings, for example:

A debug function should return: CometArray[CometInt(1), CometInt(2), CometInt(3)]
The toString function should return just [1, 2, 3]

As far as I remember the toString implementation is not complete, feel free to create a PR for this.


Adding $loop->run(); to the documentation

Adding $loop->run(); to the documentation, otherwise nothing happens. Took me a while to figure this out. Might be helpful for other people too.

Thanks for spotting, that's a nasty one :)
Refs #19.


Interrupted startup: "Windows protected your PC. Microsoft Defender SmartScreen prevented unrecognized app from starting..."

Steps: Double click an icon to start Sparrow.
Actual Result:

More info must be clicked for the "Run anyway" button to appear.
Expected result:
Sparrow's start/main screen instead of the warning on the blue background.
Environment:
Sparrow 1.8.1 standalone @ Windows 11.

This is completely out of the developers' control. It is Microsoft Windows heuristic-based security to warn about "unknown" programs.
This is based on Microsoft heuristics and from my experience will go away when a lot of people have ignored this warning and installed the software on their PC.
It just takes time for Microsoft to see this as a recognized app.

I have reported the incorrect classification as an uncrecognized app to Microsoft at "https://www.microsoft.com/en-us/wdsi/filesubmission".

Thanks. The Windows .exe is signed, so not much more I can do here.


Added the flame icon

I have read the CONTRIBUTING.md file.
YES
What kind of change does this PR introduce?
Added the flame icon from Lucide, with a fun little animation
What is the new behavior?
New Icon available for the library
Demo
https://github.com/user-attachments/assets/6891d496-8e77-4bf8-b581-3c6d16f29fc0
Additional context
Add any other context or screenshots.

hmm, don't know about this animation for the fire. it looks too bold for hover, maybe you should just leave the animation for pathLength. what do you think?


[Excel] Add Building block

[ ] Handle Input/Output columns
[ ] Handle Term columns
[ ] Handle Unit columns
[ ] Create logic in a way to allow adding multiple building blocks at once

Create annotation table ->

Building blocks adapt existing annotation table
Only one input and output and everything under more per table

Potential process:
Read current annotation table in excel, adapt it with building blocks and write it anew

Helper function -> toNumberFormat & ofNumberFormat in Shared for help


New package.json script to start server and protractor concurrently

I'm submitting a ...
[ ] bug report
[x ] feature request
[ ] question about the decisions made in the repository

What is the current behavior?
Currently you have to start the app server and protractor from separate terminals.
This makes it difficult to run the protractor tests from a Maven build.

What is the desired behavior?
Have the server and protractor started from Maven directly.

What is the motivation / use case for changing the behavior?
Run CI tests directly from Maven in an integration server, e.g. Jenkins.

Please tell us about your environment:
Latest version of this project as of 2016/09/02.
Using Maven Plugin:

			<plugin>
				<groupId>com.github.eirslett</groupId>
				<artifactId>frontend-maven-plugin</artifactId>
			</plugin>

CI is run under Linux, development is under Windows.

Other information

I found an npm package called concurrently https://www.npmjs.com/package/concurrently.
I added the following to package.json:
    "e2e": "concurrently -s first --names \"appserver,protractor\" -p \"{name}--{pid}\" -k \"npm run server\" \"npm run protractor\"",

   "concurrently": "^2.0.0",

Works like a charm!!

That is a good one. Another way on Windows environment is to prefix any command with start
Example: start npm run appserver && start npm run protractor
This will launch both programs in a new console window, on a different thread that isn't connected to each other. Works for free without any extra packages :-)


[docker] Add user and expose the memcached port

These changes aim to improve our memcached devtools images to allow us to reuse them during development stages.
These changes create a memcached user for all the images, switch to this user by default once memcached have been configured for building, expose the memcached port 11211 by default.
That allow to run the memcached server directly when the containers are started, else, without the user the run will fail as we try to execute memcached as root user.
Also we should notice that the alpine image has been fixed by adding git to the list of the requirements to install. Else the build will fails.

Thanks!
Given light of past security issues, I don't think we're able to ship something that will expose the network port by default here. The rest I will look into as soon as I can.

No problem concerning the expose. Anyway the ports can be published by using the command line --publish 11211:11211 so I'll drop the related lines.

Done.

Out in 1.6.10

Thanks


[scripts] Updates to the dependency-checking script

mentions removed deps in commit msg,
test all features

Test
script only

I had no idea this existed. You mention cargo-outdated, but that does not appear to be used. Can you put in a comment explaining what the awk regex is trying to do?

@metajack Sorry, I brain-farted on cargo-outdated, which is not used here (but in anothe neighboring script)
I added the comment as requested.

@bors-libra retry

@huitseeker: :key: Insufficient privileges: not in try users

What is/was the default-features and version stuff doing? Why filter out those lines?

@bors-libra r+

:pushpin: Commit 8e07cf6 has been approved by metajack

@metajack we used to have 'unrolled' dependency specifications, with a block for a single dependency in the Cargo.toml, which would lead us to cargo-edit the versioning of the "version" and "default-features" thought-to-be packages.
Of course now that's not quite the format of our Cargo.toml files, so I've removed the grep -v portion referring to that.

@bors-libra retry

@bors-libra retry

@bors-libra r+

:pushpin: Commit 0d13c7d has been approved by metajack

:hourglass: Testing commit 0d13c7d3979ba54a54b4c8d5b01c9e71739180a1 with merge e93d3b88d2fe3a883b8cd066742c8b2086466bdd...

:sunny: Test successful - checks-circle_commit_workflow
Approved by: metajack
Pushing e93d3b88d2fe3a883b8cd066742c8b2086466bdd to master...


maven build fails

I'm trying to build the jar file from source using maven on RedHat with openJDK 11 and it's failing the initial unit tests.  Any suggestions on how to do this properly?
mvn build output:
https://pastebin.com/tbqwuxHP

I was building in an nfs mounted home directory and the scanner skips nfs filesystems. The unit tests failed because of that. The maven worked fine when i moved the build dir to a local filesystem.


Multiple smart bots

How do I add multiple bots?
I cant just repeat like this
accounts: [
	{
		c_user: "c_user1",
		datr: "datr1",
		xs: "xs1"

        c_user: "c_user2",
		datr: "datr2",
		xs: "xs2"
	}
],

What should I do? #noob ? xD

Read the README.md at the start page, it shows how to have multiple accounts. :)

@Cr4xy thank you.


regFun3 does not always define its outputs

Reported by sjoelund.se on 1 Oct 2012 15:02 UTC
In Modelica.Fluid.Utilities.regFun3, the c output variable looks like it is not always defined (if y1=y0). The following is a snippet of what the instantiated code looks like.
function Modelica.Fluid.Utilities.regFun3
  ...
  output Real c \"Slope of linear section between two cubic polynomials or dummy linear section slope if single cubic is used\";
  ...
algorithm
  assert(x0 < x1, ...);
  h0 := x1 - x0;
  Delta0 := (y1 - y0) / h0;
  if abs(Delta0) <= 0.0 then
    y := y0;
  else
    ...
    if ... then
      c := ...;
    else
      c := ...;
    end if;
  end if;
end Modelica.Fluid.Utilities.regFun3;

If it is intended that y1<>y0, add an assertion and remove the if-condition and the first branch. Else add some value for c (even if it is not meaningful, make it deterministic).

Migrated-From: https://trac.modelica.org/Modelica/ticket/848

Comment by hansolsson on 1 Oct 2012 16:07 UTC
There is also a more subtle issue with that if-branch; the function specifies smoothOrder=1 which is intended to allow AD (algorithmic/automatic differentation).
However, AD is known to fail for singular points - i.e. exactly tests such as this.

Comment by hansolsson on 17 Dec 2012 13:50 UTC
This should probably be a blocker; note that to handle the AD-issue we should probably do something like:
if abs(Delta0) <= 0.0 then
  y:=y0+Delta0*firstValue;
  c:=secondValue;
else

with suitable values for firstValue and secondValue.
Yes, for Delta0=0 we will get y:=y0, the point of firstValue is to allow AD to compute the derivative of y.

Comment by hansolsson on 17 Dec 2012 13:57 UTC
Change to blocker, as discussed at phone-meeting for MAP.

Modified by fcasella on 5 Mar 2013 23:31 UTC

Comment by anonymous on 7 Mar 2013 08:31 UTC
Fixed in 00c266436ebb01175b026fa71dce9021b4d34d6d
I chose to maintain the if-branch due to backward compatibility. Thus, I added the return value for c as suggested by Martin S.
Also, I followed Hans suggestion with firstValue = x-x0 and secondValue=0.

Modified by msielemann on 7 Mar 2013 08:31 UTC

Comment by dietmarw on 7 Mar 2013 08:40 UTC
Michael,
please remove the <p>...</p> around any other environment (e.g., <ul>) since this is illegal HTML and do not use the Dymola info editor for this.

Comment by msielemann on 7 Mar 2013 08:49 UTC
Fixed in f3c96ebaa1dc7606de628f55e954152dbc62ca63


More info at: https://travis-ci.com/Qiskit/qiskit-terra/jobs/334663037

Fixed by: https://github.com/Qiskit/qiskit-terra/pull/4296


wingetcreate new if PackageIdentifier exists

Description of the new feature/enhancement
if wingetcreate new detects a duplicate/existing PackageIdentifier it should use the Metadata from the newest Manifest.

Proposed technical implementation details (optional)
Use the Metadata from the newest Manifest like wingetcreate update. And add the missing Metadata.

@mdanish-kh another task in your task list :)


update-source-mongodb

Signed-off-by: gauravmnjwr<EMAIL_ADDRESS>Changes:
Removed the line please see [Event Structure](#Event Structure) to understanding it

Hey there I've edited the doc, please check the pull request. Thankyou

Thank you for your commit! Please make sure to join the Slack so we can reach you for the event.


Plug Idea: Webhooks

I don't know the full capability of silverbullet at the moment but I think a webhook plug would be useful for automation of external applications.
For example:
The creation of a task (such as #327 and #323) fires a webhook with a JSON blob of the task data. That blob makes its way to an application like https://github.com/Casvt/Noted that handles notification scheduling through the users preferred service.
Another example. The creation of an external link is detected. That webhook is used to automated the archiving of the webpage in something like https://github.com/go-shiori/shiori. I think that would work nicely with #247
Perhaps the better approach would be dedicated plugs for each of these things. I've been using n8n recently to do simple API re-mappings so that's kind of where my head is right now.

I like the idea of adding other ways to easily extend SilverBullet in new ways and web hooks make sense to add from that perspective. What is less clear to me is when a web hook should be triggered. Your example of creating tasks seems hard, because when do we consider a task added? In a task manager there’s usually a “Add” button that you push when done, but SB doesn’t have this. There’s explicit “and hereby I consider this task ready” point in time. Since pages are constantly saved (with perhaps a 1-2s lag) it’s really not clear when the webhook should be triggered. This would be more clear for events like ticking a task as completed. Any thoughts on this?

An incoming webhook would be great too -- would allow for a scenario like starring a message in Slack turning into a task in Silverbullet.

This is also doable (technically already possible if you’d know how — but no docs on this 😉 ). However, it would require your SB instance to be accessible directly from whatever is triggering the webhook (in you Slack example: the public internet). Most of us (I would say: probably almost everybody) run SB locally or, a local network or VPN, and while there’s ways to get the outside internet to call back into SB this is usually not straight forward.

This is also doable (technically already possible if you’d know how — but no docs on this 😉 )
👀 well now I'm interested! (I can make a separate issue for this if it's useful btw...)

Like nnarain, I have n8n running and publicly accessible, it's connected to Slack and listening for events and it would have internal network access to SB, which is where my interest comes in.
Totally understand if that scenario isn't a high priority to support since it's likely to be so rare.

I should really document this, but in a plug you can do this:
name: myplug
myHTTPFunction:
  path: ./http.ts:myHTTPFunction
  http:
     path: /hook

This would result in any HTTP get, post, options request sent to http://yoursilverbulletinstance:3000/_/myplug/hook (so your SB instance /_/PLUGNAME/PATH) and invoke myHTTPFunction on it, where that function then has to return a HTTP result. For instance:
export async function myHTTPFunction(req: any) {
  return { status: 200, body: "Hello world" };
}

Shape of the request and response objects can be found here: https://github.com/silverbulletmd/silverbullet/blob/main/plugos/hooks/endpoint.ts
Test here: https://github.com/silverbulletmd/silverbullet/blob/main/plugos/hooks/endpoint.test.ts

Thank you!

That's a good point on when a task webhook would fire. I'd have to think about that. I suppose I'd settle for a semi-automatic process where I could trigger an update from the command palette.


[stable/percona-xtradb-cluster] Scrape metrics service

Signed-off-by: Matej Hasul<EMAIL_ADDRESS>
What this PR does / why we need it:
We use plain prometheus without prometheus operator. Set prometheus
annotations for metrics service when exporter is enabled but
prometheus operator is not. This cause prometheus to scrape the exported metrics.
Which issue this PR fixes
None
Special notes for your reviewer:
Nope
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

[x] DCO signed
[x] Chart Version bumped
[x] Variables are documented in the README.md
[x] Title of the PR starts with chart name (e.g. [stable/chart])

/assign @maver1ck


table designer - rename a table will cause the table to disappear in the sql proj scripts

it turns out a new file is added to the project's folder but not in the sql project files view. the expected behavior is the current file gets updated and the new table should appear at the same line as the previous table definition.

There are 2 main scenarios here:

The table is the only object in the file and the file has the same name as the table.
expected: File is not renamed (?) and the old table definition gets replaced with the new one
actual: old file with table definition gets deleted and a new file gets created containing the new table definition and the file name is the new table's name.

The table is one of many objects in the file
expected: current file is updated with the table name on the same line as the previous table definition.
actual: previous table definition is removed and a new file is created with the table new table definition

For sdk-style projects, the newly created file will be added to the sql projects view because of the *.sql glob include. For legacy style projects, the newly created file needs to be added to the .sqlproj and is not currently.

Question:
Do we only rename the table or do we also need to update any references to the table?
A couple options I can think of for adding support for table rename:
Quick/hackier option: if references don't need to be updated, just replace the table name in the file after the schema compare publish is finished. Estimate 1 day to do this.
Longer option: if references need to be updated and this is more of a refactor so that it's a table rename statement instead of a drop and recreate when the project gets published to the db, then this is a much bigger task. The refactor feature has been requested in https://github.com/microsoft/azuredatastudio/issues/13920. AFAIK all the refactor logic is in SSDT, not in DacFx. This work hasn't been scoped out yet, so just a rough time estimate is optimistically around 1 month for an engineer to add support for refactoring and hook it up with table designer, but it could easily go longer.

Question: Do we only rename the table or do we also need to update any references to the table?
A couple options I can think of for adding support for table rename: Quick/hackier option: if references don't need to be updated, just replace the table name in the file after the schema compare publish is finished. Estimate 1 day to do this.
Longer option: if references need to be updated and this is more of a refactor so that it's a table rename statement instead of a drop and recreate when the project gets published to the db, then this is a much bigger task. The refactor feature has been requested in #13920. AFAIK all the refactor logic is in SSDT, not in DacFx. This work hasn't been scoped out yet, so just a rough time estimate is optimistically around 1 month for an engineer to add support for refactoring and hook it up with table designer, but it could easily go longer.

My 2c is that the longer option, for full refactoring should be a separate implementation from the table designer.  A strict rename for the reference(s) in the single table definition file
@alanrenmsft @kisantia

Summarizing discussion from https://github.com/microsoft/sqltoolsservice/pull/1687 here:

until refactoring in sql projects is supported, we will keep changing table name and schema disabled for offline sql projects table designer:

The approach taken in https://github.com/microsoft/sqltoolsservice/pull/1687 only changed the name/schema in the CREATE TABLE statement, not any dependencies, which can potentially result in build errors. Additionally, since sql projects in ADS does not currently support refactoring, a table "rename" actually drops the old table and creates a new one, rather than using sp_rename .
TODO: document how to make table rename or schema change in script for offline table designer. @erinstellato-ms can you please help this?


improved process_fasta.py

Addressed issues #39 and #40 . @tkosciol @sjanssen2

Coverage increased (+0.3%) to 93.895% when pulling 59b0f6b3498b7dafc4b2a9e9ce91712dbffdce43 on qiyunzhu:process into 2dc3a7f548b07f74734eba3517b87c48c619240f on biocore:master.

@sjanssen2 thanks for flattering^^

resolves issues #39 #40

@tkosciol My pleasure!


Using tmp branch of j-b-a for support 2.9

We need to tmp support Juju 2.9, and charm need to use j-b-a python package with libjuju 2.9.
fixes: #53

This PR is blocked until the https://github.com/canonical/juju-backup-all/pull/58 is not merged to tmp branch.


[tests/core] Updated with BoringModel and added BoringDataModule

What does this PR do?

Part of #4501
Updated tests/core with BoringModel. Added BoringDataModule.
Before submitting

[x] Was this discussed/approved via a GitHub issue? (not for typos and docs)
[x] Did you read the contributor guideline, Pull Request section?
[x] Did you make sure your PR does only one thing, instead of bundling different changes together?
[ ] Did you make sure to update the documentation with your changes? (if necessary)
[ ] Did you write any new necessary tests? (not for typos and docs)
[x] Did you verify new and existing tests pass locally with your changes?
[ ] Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review
Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

[x] Is this pull request ready for review? (if not, please submit in draft mode)
[x] Check that all items from Before submitting are resolved
[x] Make sure the title is self-explanatory and the description concisely explains the PR
[x] Add labels and milestones (and optionally projects) to the PR so it can be classified
[x] Check that target branch and milestone match!

Did you have fun?
Make sure you had fun coding 🙃

@williamFalcon mind review?

@williamFalcon mind review?


[11.x] Feat: requires Helper

Although we have helpers like value, which in addition to being widely used and useful, deals with standard value situations, the requires helper introduced by this PR aims to perform a different task. Given a closure, if the value as the result of the closure is null, then we return the fallback value, hence the name requires - for situations where we want to work with a value, not null.
When null:
requires(fn () => null, 'Taylor Otwell'); // Taylor Otwell

When non-null:
requires(fn () => true, 'Taylor Otwell'); // true

According to the helper concept, the second parameter of the helper is not optional, but mandatory to determine the fallback value when the callable result is not null.

The null check seems a bit arbitrary. Why is false considered a good value for the callback? Furthermore i cant think of a concrete recurring usecase for this function off the top of my head.

The null check seems a bit arbitrary. Why is false considered a good value for the callback? Furthermore i cant think of a concrete recurring usecase for this function off the top of my head.

Null is not exactly a type of variable, but rather a special value that represents the absence of a value or the lack of a variable. The requires auxiliary proposes a concept where we work with the mandatory determination of a value.
I think there are millions of situations to apply the requires helper based on the concept it proposes, the main ones I can imagine are situations where we are dealing with ternary operations, null coalescing, and most important: database operations on not-null columns.

This would probably be a good candidate for a function you just define in your own application.

Isn't that what the null coalescing operator is for?
value(fn () => null) ?? 'Taylor Otwell'; // Taylor Otwell
value(fn () => true) ?? 'Taylor Otwell'; // true

Isn't that what the null coalescing operator is for?
value(fn () => null) ?? 'Taylor Otwell'; // Taylor Otwell
value(fn () => true) ?? 'Taylor Otwell'; // true

Just to be clear, you read my comment above, right?

Sure, and still can't see the point.

for situations where we want to work with a value, not null.

Also, the description, and the implementation is precisely what the null coalesce operator was introduced.

https://www.php.net/manual/en/language.operators.comparison.php#language.operators.comparison.coalesce

And by the way, null is not a "special value" in PHP. It is a type, a unit type.

https://www.php.net/manual/en/language.types.null.php
https://www.php.net/manual/en/language.types.type-system.php

Just to be clear, you might have an example where this helper couldn't be replaced by the null coalescing operator, right?
Can you share it with us?

Just to be clear, you might have an example where this helper couldn't be replaced by the null coalescing operator, right?
Can you share it with us?

Excuse me, but are you from the Laravel team? There's no point discussing this after Taylor has closed the PR. The decision is always up to him. If the PR was closed, it was not relevant to the framework.


Typed jit decorator

When running mypy on my typed functions which are using the jit decorator I get the following error: Untyped decorator makes function "f" untyped

Thanks for the report – this is actually a shortcoming in mypy; see https://github.com/python/mypy/issues/3157. mypy currently lacks type annotation support for decorators like jax.jit that are able to decorate arbitrary functions. I'm going to close this issue because it's being tracked there.

Thanks for the report – this is actually a shortcoming in mypy; see https://github.com/python/mypy/issues/3157. mypy currently lacks type annotation support for decorators like jax.jit that are able to decorate arbitrary functions. I'm going to close this issue because it's being tracked there.


CI

Continuous Integration, such as with the free TravisCI system, could catch many issues earlier. Can we setup CI for node-gyp to test how it installs and runs in macOS, Windows, and Linux?

https://github.com/nodejs/node-gyp/blob/master/.travis.yml
https://travis-ci.com/nodejs/node-gyp
more tests would help, you're welcome to contribute


Switch exercise 2 to composition gateway

implementation

[x] before
[x] after

test

[x] before
[x] after

[x] review exercise documentation
[x] attempt exercise

@Particular/microservices-workshop-maintainers this is ready for review


fix: fixed sc not working with siwe

Decided to go with infura
Will need an api key in our env vars for this
Tested with argent

Waiting on infura key
Needs to be added to gh env before merging or siwe will be broken


System Bridge fails setup with new processes module

Description
Per the issue in Home Assistant: https://github.com/home-assistant/core/issues/105664
What Platform / OS are you running?
Linux
What version are you running?
Windows 10
Anything in the logs or a references that might be useful?
No response
Additional information
system-bridge.log

Your logs show you are running version 3.8.2. Please update to the latest version


Swift SDK appears to generate incorrect URL for transforms

pod 'FilestackSDK', '2.3.1'
I'm trying to use your SDK to resize an image I previously successfully uploaded to S3 (via the upload call) and from which I got a handle.
func transform(path: String, filename: String, handle: String, completion: @escaping (String, String) -> Void) {

        let transformable = filestackClient.transformable(handle: handle)
        transformable.add(transform: ResizeTransform().width(150).height(200))
        let storeOptions = StorageOptions(location: .s3, path: "a", filename: "b", mimeType: "image/jpeg", access: .private)

        transformable.store(using: storeOptions, base64Decode: false) { (handle, response) in

        if let json = response.json,
            let key = json["key"] as? String,
            let url = json["url"] as? String {
            completion(key, url)
        } else {
            completion("", "")
        }

        }

    }

This generates a URL like
https://www.filestackapi.com/api/store=location:S3,path:a,filename:b,access:private,base64decode:false/security=policy:[policy],signature:[sig]
which returns HTTP 404 as the result of the POST call. I know my client is configured correctly (policy/sig) since the upload call works.
It appears that something like https://www.filestackapi.com/api/store/S3?xyz would be valid.
Am I doing something wrong?

@brynjar Hi. You're not doing anything wrong, the base URL should be https://cdn.filestackcontent.com instead of https://www.filestackapi.com/api, hence that's a bug in our code.
I'll prepare a new release with this fix and close this issue. Feel free to reopen if you still experience any issues!
Thanks!


Add bicycle map POIs

Bicycle POIs:

[x] shop=bicycle
[ ] min zoom = 15 for shop=bicycle
[x]  amenity=bicycle_rental
[ ] min zoom = 16 for bicycle_rental
[ ] add more properties for bicycle_rental: network, operator, ref, capacity
[x] amenity=bicycle_parking at zoom 17
[ ] add more properties for bicycle_parking: capacity, covered, access, fee, operator, cyclestreets_id, maxstay, surveillance
[ ] rcn_ref nodes - min_zoom = 16 (was 15)
[ ] cycle_barrier at zoom 17

We can split off the extra properties (later) from the zoom range changes (now).

Adjustments to the above recommendations after reviewing the data more:

If a bicycle_rental is a shop, min zoom = 16
If a bicycle_rental is bike share station, min zoom = 17
cycle_barrier at zoom 18
several new attributes for bicycle_rental were added, but not all. Ref was already present:

network:  {col: tags->network}
operator: {col: operator}
capacity: {col: tags->capacity}

several new attributes for bicycle_parking were added, but not all:

operator: {col: operator}
capacity: {col: tags->capacity}
covered: {col: tags->covered}

@zerebubuth I'm okay calling the bicycle_guidepost and walking_guidepost something else, more like bicycle_junction or bicycle_network_node. Use your best judgement.

Looking good.


the MIT license requires that reuse of the code contain the original copyright line and permission notice

https://github.com/bmacnaughton/debug-custom/blob/master/LICENSE
contains
MIT License

Copyright (c) 2019 Bruce MacNaughton

Permission is hereby granted, free of charge, to any person obtaining a copy
of this software and associated documentation files (the "Software"), to deal
in the Software without restriction, including without limitation the rights
to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
copies of the Software, and to permit persons to whom the Software is
furnished to do so, subject to the following conditions:

The above copyright notice and this permission notice shall be included in all
copies or substantial portions of the Software.

 IN NO EVENT SHALL THE
AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
SOFTWARE.

@bmacnaughton where should this be included? in https://github.com/appoptics/appoptics-apm-node/blob/master/LICENSE or a separate file?

@bmacnaughton where should this be included? in https://github.com/appoptics/appoptics-apm-node/blob/master/LICENSE or a separate file?

Or just at the top of: https://github.com/appoptics/appoptics-apm-node/blob/nh-main/lib/debug-custom.js ???

i believe it is appropriate to place it in the file.

thank you; i appreciate the fast turnaround. and, as a general comment, you're doing great work.


When installing with Linuxbrew: Failed to download resource "tact"

Hi there,
Thanks again for the awesome software!
I've got a working Docker version of TACT on another machine, but I wanted to install TACT on my home WSL machine.  But I ran into a problem when trying to install with brew:
myusrname:~$ brew install jonchang/biology/tact
==> Installing tact from jonchang/biology
... (other preqs downloading here) ...
==> Downloading https://dl.bintray.com/jonchang/bottles-biology/tact-0.3.4.x86_64_linux.bottle.tar.gz

curl: (22) The requested URL returned error: 403 Forbidden
Error: Failed to download resource "tact"
Download failed: https://dl.bintray.com/jonchang/bottles-biology/tact-0.3.4.x86_64_linux.bottle.tar.gz

I've truncated the full install messages, because there's just a lot of downloading of other files successfully.  I can add them in if you think they might be a problem, but no errors were indicated before attempting to download TACT

Hi John, I'm tracking this in https://github.com/jonchang/homebrew-biology/issues/44.

This should be fixed now.


Replace kotlinx-cli with clikt

According to https://github.com/Kotlin/kotlinx-cli:

This library is obsolete
It is effectively unmaintained. Please consider using other libraries.

Let's replace it with other library. https://github.com/ajalt/clikt seems to be the most popular one.
https://github.com/platan/tests-execution-chart/blob/34a6d657e4e69a744065b9fb4706bb536ffecea1/src/functionalTest/kotlin/io/github/platan/tests_execution_chart/JsonToHtmlReportApp.kt uses kotlinx-cli.
JsonToHtmlReportApp is used by createRegressionHtmlReporttask. The task is defined in https://github.com/platan/tests-execution-chart/blob/main/build.gradle.kts. Regression tests [use](https://github.com/platan/tests-execution-chart/blob/main/.github/workflows/ci.yml)createRegressionHtmlReport`.
If required, JsonToHtmlReportApp cli parameters can be changed.

I will check it


As a developer, I want to be alerted during key incidents in production via Cloudwatch events.

[ ] High Latency on join
[ ] Crashing and continuous restarts alerting

We are going to wait for the production planning meeting this week! Stay tuned on this ticket...