Make clear that all API's are JSON/HTTP

Tag @matthieu, @Catheryne for discussion:
I think the language can/should be tweaked so that it's more clear that we support any language that can make JSON HTTP calls (every modern language), and that the API is just JSON over http.
For me, this is most prominent in two places:

"Official" language support: maybe weaken this, we don't want to make it seem like other languages aren't going to work for some reason. My suggestion: change to "BlockCypher Supported Language SDKs" or "Officially Supported Language SDKs" to make it clear that the support is for the language library, not the language itself. Maybe additionally, make it explicit that we support any language that can make HTTP calls and parse JSON.

Frequent use of "cURL" : to experienced readers, curl is more or less a synonym for "GET over HTTP", but for inexperienced readers this may seem like some magic tool and the connection may not be obvious.

For example:
If not, or you’d rather write your own bindings, we always support cURLing endpoints directly, which is the default code sample you’ll see to the right.

My suggestion would be something along the lines of:
Of course, all our API's are standard HTTP endpoints using JSON formatted responses, so any language (or cURL from the command-line) will work just fine.

Great feedback @hbcheng, many thanks. Both 1) and 2) make sense to change immediately (will do that now). I'll keep this issue open for now, and once I've got the skeleton done for the rest of the documentation, I'll modify the language in the introduction to make it clearer that the API is just JSON over HTTP.

Thanks! And great work so far, it's really shaping up nicely.

Closing this out for now Bryan---think I did a decent job making this explicitly clear for the rest of the docs, but if you think it can be sharpened up let me know by re-opening and I'll take another pass at it.


IGAPP-1084: Add dutch translations

This pull request belongs to an issue on our bugtracker.
You can find it there by looking for an issue with the key which is mentioned in the title of this pull request.
It starts with the keyword IGAPP.

Is it intentional that Dutch/Nederlands is not (yet?) a selectable language on web? (However, visiting /testumgebung/nl shows the Language not Found Error page with the vertical language selector, even though the error message itself is in Dutch.)
In the native version, Nederlands is a selectable language, but selecting it doesn't appear to have any effect.

There are two different language concepts in Integreat:

Available langugaes in the languages menu: If a city translates a content to e.g. Dutch, you can select Dutch in the menu and see the translated content of the page.
Languages of the app: We support some languages of the app, which is set depending on your device system language. When you change your devices system language, the texts of the app, which are not content (e.g. "Change location", "Maps", "News", "Show PDF") are translated.

In this PR Steffen did the second for Dutch.


Cleanup after #176

Removing all the logger.info() calls used to debug #176. I've left the logger there although it's not imported anywhere so won't be used, but will still be there for future issues. :-)

Message field is correct and layout post and other add fields are gone. It still says false with a conflict on submission but it posts the comment, working the same on both api.staticman and dev.staticman.
`//<PHONE_NUMBER>4627
// https://dev.staticman.net/v2/entry/donaldboulton/DWB/gh-pages/reviews
//<PHONE_NUMBER>4627
// https://dev.staticman.net/v2/entry/donaldboulton/DWB/gh-pages/reviews
{
{
"success": false,
"rawError": {
"code": 409,
"status": "Conflict",
"message": "{"message":"is at 59ffdd028f1e3611179e9177574f9d600477f473 but expected 5c6d559a30f40fd5a7e0be559340cd1d641fe4eb","documentation_url":"https://developer.github.com/v3/repos/contents/#update-a-file\"}"
},
"errorCode": "GITHUB_WRITING_FILE"
}`
My Fork has the 1000+ js-lint - js-hint errors Fixed, and now I do not get node eslint errors now. Could be related to the travis build errors. Will try to test travis for build errors that were node related from to many js errors.

@donaldboulton Interested in submitting a PR to fix the linting errors? I noticed that travis was failing, but haven't looked into how to fix it yet.

Doing some tests to see if I know what I am talking about, and if the eslint node build errors I was getting were of any real consequence. Will respond A.S.A.P. My above errors are simply pull request commit "message" errors as stated in Update a file. The two line of numbers are the SHA of the message and I seems to be the conflict. No filled in, "message", in the pull request or the SHA is ??? Did Github changed something we don't know about???
Here is my repo with the js errors fixed in the lib folder dwb-staticman. All other js files fixed in the repo.
Never done a PR and on my first one I need to make sure I am correct.


Pattern:  CTA section - remove the horizontal rule when no content items are given

This epic will contain a description of the overall scope, development instructions and links to all of the issues required to complete the work.
Additional Information

Acceptance criteria

[ ] Additional stories are created, if needed, for any work to be done in future sprints.
[ ] Designs and functional specs are reviewed with the DDS developers for sizing and issue refinement.

@photodow Here is the epic for the CTA section functional specs.

Updated functional specs to be more explicit in how the horizontal rule functions depending on how many items are below it.
https://ibm.ent.box.com/file/680498050634


[Python] Enable Python 3.11 packaging where available for CPU builds

Python 3.11 have been available for a while now. This patch enables support for 3.11 to be built where available.
cc @tqchen @areusch @Liam-Sturge for reviews

Merging my own patch, as it is very small and not risky.


Refreshing examples

Adding and editing examples as per request by Ian liu

Docs Build status updates of commit d32cfbc:
:clock10: Full build: the average full build time is 14 min(s) 44 sec(s), this is based on the last 1000 build(s) for this repository.

Docs Build status updates of commit d32cfbc:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

exchange/exchange-ps/exchange/federation-and-hybrid/Set-FederationTrust.md
:white_check_mark:Succeeded
View (exchange-ps)

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

@kenwith Do i need to do anything else to make these changes appear in the doc

@mukeshHCW - nope, this is great! Thank you for the contributions, it is very much appreciated. Since this is Exchange I let @chrisda merge it. The process is that it is merged to master branch and then master branch is merged to live branch. The docs.microsoft.com site pulls from the live branch here. The master branch is an interim branch but we generally just keep them in sync. It is a manual merge though so once something is merged into master someone needs to merge from master to live.. and that can take a little time depending on when we get to it.. we try to do it right away though.

Docs Build status updates of commit b3b3356:
:clock10: Full build: the average full build time is 14 min(s) 53 sec(s), this is based on the last 1000 build(s) for this repository.

Docs Build status updates of commit b3b3356:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

exchange/exchange-ps/exchange/federation-and-hybrid/Set-FederationTrust.md
:white_check_mark:Succeeded
View (exchange-ps)

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Docs Build status updates of commit d535958:
:clock10: Full build: the average full build time is 14 min(s) 55 sec(s), this is based on the last 1000 build(s) for this repository.

Docs Build status updates of commit d535958:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

exchange/exchange-ps/exchange/federation-and-hybrid/Set-FederationTrust.md
:white_check_mark:Succeeded
View (exchange-ps)

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Docs Build status updates of commit 01cf76d:
:clock10: Full build: the average full build time is 14 min(s) 59 sec(s), this is based on the last 1000 build(s) for this repository.

Docs Build status updates of commit 01cf76d:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

exchange/exchange-ps/exchange/federation-and-hybrid/Set-FederationTrust.md
:white_check_mark:Succeeded
View (exchange-ps)

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Docs Build status updates of commit 6675a14:
:clock10: Full build: the average full build time is 15 min(s) 6 sec(s), this is based on the last 1000 build(s) for this repository.

Docs Build status updates of commit 6675a14:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

exchange/exchange-ps/exchange/federation-and-hybrid/Set-FederationTrust.md
:white_check_mark:Succeeded
View (exchange-ps)

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Docs Build status updates of commit 47732c1:
:clock10: Full build: the average full build time is 15 min(s) 9 sec(s), this is based on the last 1000 build(s) for this repository.

Docs Build status updates of commit 47732c1:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

exchange/exchange-ps/exchange/federation-and-hybrid/Set-FederationTrust.md
:white_check_mark:Succeeded
View (exchange-ps)

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Docs Build status updates of commit df47a3c:
:clock10: Full build: the average full build time is 15 min(s) 12 sec(s), this is based on the last 1000 build(s) for this repository.

Docs Build status updates of commit df47a3c:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

exchange/exchange-ps/exchange/federation-and-hybrid/Set-FederationTrust.md
:white_check_mark:Succeeded
View (exchange-ps)

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Docs Build status updates of commit e7e4258:
:clock10: Full build: the average full build time is 15 min(s) 17 sec(s), this is based on the last 1000 build(s) for this repository.

Docs Build status updates of commit e7e4258:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

exchange/exchange-ps/exchange/federation-and-hybrid/Set-FederationTrust.md
:white_check_mark:Succeeded
View (exchange-ps)

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


ansiblels ansible.validation.lint.arguments not working as intended

Description
I'm trying to pass a custom ansible-lint configuration file to ansiblels. From the vscode documentation for the LS, there should be a "arguments" setting for the linter. Configuring this like below, still uses the repository local configuration file though, instead of the one provided in the argument.
LSP Related Setup:
return {

    {
        'neovim/nvim-lspconfig',
        dependencies = {
            { 'williamboman/mason-lspconfig.nvim', config = function() end },
            { 'williamboman/mason.nvim', config = true },
        },
        config = function()
            require 'lspconfig'.ansiblels.setup {
                settings = {
                    {
                        ansible = {
                            ansible = {
                                path = 'ansible'
                            },
                            executionEnvironment = {
                                enabled = false
                            },
                            python = {
                                interpreterPath = 'python'
                            },
                            validation = {
                                enabled = true,
                                lint = {
                                    enabled = true,
                                    path = 'ansible-lint',
                                    arguments = '-c /home/dosa/.config/ansible-lint.yml'
                                }
                            }
                        }
                    }
                }
            }
        end,
    },
}

This should result in ansible-lint using the configuration in my home folder, but instead it still looks for the one in the repository and uses that.

lua=require('lspconfig').ansiblels is not same as your config ?


[discuss] Don't generate shortcuts for list functions

Changes
The ListByZZZ functions don't use the same pagination as the main functions.
By definition, the shortcut functions are generated only if there are required request parameters. Therefore, they should either return the same paginator, or not exist at all.
Tests
n/a

Codecov Report
Attention: Patch coverage is 0% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 7.13%. Comparing base (29bdcf3) to head (515ea4c).
Report is 1 commits behind head on main.

Files
Patch %
Lines

service/compute/library_utilities.go
0.00%
4 Missing :warning:

openapi/code/method.go
0.00%
1 Missing and 1 partial :warning:

Additional details and impacted files
@@           Coverage Diff            @@
##            main    #935      +/-   ##
========================================
- Coverage   7.13%   7.13%   -0.01%
========================================
  Files        281     281
  Lines      64583   64596      +13
========================================
  Hits        4609    4609
- Misses     59666   59677      +11
- Partials     308     310       +2

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Nicole’s photo is wrong

looks like nicolo's photo is a copy of jim's

Thank you! It has been fixed now.


How to get coordinates from Plane?

Hi. I iterate through all planes that are tracking:
for (Plane plane : frame.getUpdatedTrackables(Plane.class)) {
                    if (plane.getTrackingState() == TrackingState.TRACKING) {

After this i want to place a model on tracking plane. How to get coordinates or an anchor to have an ability to place a model on this plane/pose/anchor?

try plane.getCenterPose() to get the pose
and then session.createAnchor(pose) to create an anchor


Calendar

Calendar
User Story
AS A person who travels often
I WANT to see the flight information for destination cities
And exchange rates for different currencies
SO THAT I can find a flight
And Plan how much money I will need
Acceptance Criteria
GIVEN an application that provides flight information
AND provides current exchange rates for currencies
WHEN I select dates for my flights
THEN I am able to add those dates to a calendar

The calendar has been incorporated into the travel application.  Flight data is being written to the corresponding dates.


Enforce 500k tile limit at the source, fail in serialization.

/cc @rclark for the review

@rclark @tmcw hrm do we want to limit this to serialtiles? I think last I thought about this I'd thought it best to limit at the put stream: https://github.com/mapbox/tilelive.js/blob/master/lib/stream-put.js

@yhahn i'm planning on moving this to mapbox-upload-validate instead and using it within mapbox-upload, so it isn't in non-mapbox-specific code.

This use case is now covered by https://github.com/mapbox/tilelive.js/pull/132


no-callback-in-async-function rule?

Putting callback code inside of async functions like this can lead to a lot of trouble:
async function bigProbs() {
    doSomething(function(err) {
        if (err) throw err; // won't be caught by the parent
        // ...
    })
}

Would something like this address the issue:
async function bigProbs() {
	try
	{
		doSomething(function(err) {
			if (err) throw err; // won't be caught by the parent
			// ...
		})
	}
	catch(e)
	{
		throw(e);
	}
}
If so, can you not warn when the try catch is throwing to the parent?

Would something like this address the issue:
async function bigProbs() {
	try
	{
		doSomething(function(err) {
			if (err) throw err; // won't be caught by the parent
			// ...
		})
	}
	catch(e)
	{
		throw(e);
	}
}

If so, can you not warn when the try catch is throwing to the parent?

No, your example is equivalent.
I think the intent is to avoid confusion by preventing what could admittedly even be synchronous callbacks (whose errors could actually work here). But it avoids confusion for cases where it really is asynchronous and then the error won't be caught.


WeDo: 'play no port frequency Hz' block causes a server error

Describe the bug

When the buzzer action in the robot configuration is removed, and the 'play frequency Hz' block is used, the user receives a server error.

To Reproduce
Steps to reproduce the behavior:

Create a new WeDo program.
Go to the 'Robot Configuration' section.
Delete the 'Buzzer' block.
Go to the Program NEPOProg section and click on the 'Sounds' category.
Use the 'play frequency Hz' block.
Open the source code view.

Expected behavior

In such a scenario when the corresponding block in the Robot Configuration is deleted, the 'play frequency Hz' should demonstrate behaviour similar to the the other blocks.
Instead of the server error, a warning that says 'The actuator is not set to the port'  and an alert that says "There are errors in your program. Please check the messages" should be displayed.

Screenshots

Expected behaviour(as in the Arduino robot)

Device information

Type : Desktop
OS: MacOS
Browser : Chrome

Resolved by a GCI student.


What is the term for this ambient declaration format?

All of these are ambient module declarations:
// top-level import/export declaration format
export function foo(): void;

// Also top-level import/export declaration format?
declare namespace boo {
  export function foo(): void;
}
export = boo;

// What is the term for this format?
declare namespace boo {
  export function foo(): void;
}

declare module "boo" {
  export = boo;
}

The first two is how we write ambient module declaration for https://github.com/typings/typings. It is also what tsc -d produce if you don't perform bundling.
The last one is how people write ambient module declaration in DefinitelyTyped and subject to name conflict and resolvability issue (as described in https://github.com/typings/typings/blob/master/docs/external-modules.md)

This file is a module, as it has at least one top-level export or import declaration. the file is ambient as it does not have a body, and uses the declare keywrd.
export declare function foo(): void;

This is the same. it is a module. and it is ambient.
declare namespace boo {
  export function foo(): void;
}
export = boo;

This one is not a module. it is a script. it contains an ambient module declaration. but other than that it lives in the global declaration.
declare namespace boo {
  export function foo(): void;
}

declare module "boo" {
  export = boo;
}

So can I say that it is a script with ambient module declaration?

yes. an "ambient module declaration" is declare module "foo" { .. }.
a module (regardless of being ambient or not) is something of the form import .. ; export ..;

Thanks! :rose:


Fixing the PowerBI Performance Report

Changed a script that was having issues when collecting perfmon data from FCI instances. To get the machine name and find the counter, instead of using SERVERPROPERTY('ComputerNamePhysicalNetBIOS'), it was using SERVERPROPERTY('MachineName'), which returns the SQL virtual name. The perfmon counters have the physical machine name always, even if this is a FCI.
Also changed a script that was causing issues when the instance where the nexus database is created doesn't have the collation  SQL_Latin1_General_CP1_CI_AS. Now it should work with any collation
How to test:
1 - Perfmon data issue with FCI instances

Open nexus

Open the PowerBI Performance Report

Connect to a nexus database that has data from a FCI instance (before the fix, multiple charts don't open with an error about an inexistent counter)

2 - Collation Issue
In case you have a nexus database created on a SQL instance that doesn't have the collation SQL_Latin1_General_CP1_CI_AS, run the PowerBI Performance Report against it. In the current version, it will fail with a conflict collation error when running the DatabaseFiles report. With this version, it should work with any instance collation

Tested this and indeed all the Perfmon reports are loading successfully! Great work. Thank you


Add: handle international invoices

handle international invoices data as per base country/currency

[x] Add currency drop-down in settings
[x] Treat invoice as international if client and business base currency is different
[ ] Save totals in base currency

Closed via 3eec7a859fcd3d38a6d016af7d0ab0a3c44d5279


use proper update function if jQuery is present

Fixes TypeError 'undefined is not a function' when using with jQuery and calling .wookmark more than once on a jQuery object.

Thanks!


LB service state shows "?" and the project status as " Degraded"

Server Version - Built from master 05/31
Steps to reproduce the problem:
Create Environment.
Create a service S1 and activate it.
Create  LB service , link it to service S1 and activate it.
Notice that the LB service state shows "?" and the project status says " Degraded".

Tested with v0.23.0-rc1
This issue is not seen anymore.


Ice Cream Joker + Play Hand

At this point, since you have the Play Hand button, you might as well increase Ice Cream Joker when you use it.

I got all of the ones that have the text "(Currently ___)" but missed a few others. I believe:
Loyalty Card, The Idol, and Ice Cream.
I suppose Turtle Bean could also be tracked.

Loyalty Card too maybe?

I said loyalty card

My fault.

Ice Cream, Popcorn, and Turtle bean will become disabled when in-game they'd disappear. I think that's helps make it clear enough what's going on where suddenly having the cards disappear might be confusing.


nest-next test suite

From #92:

@yakovlev-alexey
I would start by introducing a test suite testing the following:

static pages
getServerSideProps, getInitialProps, etc with context checking (values returned from controlled should end up in query)
paths with single and multiple route params, nested and at the root
static paths beside paths with routes params like in https://github.com/kyle-mccarthy/nest-next/issues/93
usage with baseUrl and other next.config.js options (asset url I believe also needs testing)
dev mode and production builds
It would also make sense to develop tests in such a way that would allow us to run them with specific Next versions (a new Nest version is unlikely in my opinion so no need to specify that). This will also open up the possibility to run CI in a matrix to effortlessly make sure all supported versions work.

Actually while there is no need to specify Nest version Nest adapter should be specified (fastify/express)


quicktemplate: unstable-2019-07-08 -> 1.6.3

Motivation for this change
Related to #67666
Things done

[X] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[X] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[X] Tested execution of all binary files (usually in ./result/bin/)
[X] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[X] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 107823 run on x86_64-linux 1

2 packages built:

hydron
quicktemplate

Result of nixpkgs-review pr 107823 run on x86_64-darwin 1

2 packages built:

hydron
quicktemplate


Moved the excluded dependencies from the dependencies block...

and formatted the dependencies in a more uniform way

Coverage remained the same at 68.856% when pulling b3c5cf3aa1b1b2490ba674213c921868ef3e06b0 on Heliozoa:gradle-build-cleaning into bf85f431b646dd790fbb3d21da46b1ce3a103b21 on tdd-pingis:master.

Coverage decreased (-0.05%) to 68.805% when pulling 10c1286543860d8aec2f2e9df6157d560c3fb539 on Heliozoa:gradle-build-cleaning into bf85f431b646dd790fbb3d21da46b1ce3a103b21 on tdd-pingis:master.


Add Veggies to the showcase

Adding Veggies, a simple app to help you find fruits and vegetables in season right now. It is entirely built in React Native.

@facebook-github-bot shipit

@mkonicek thanks! :)


Hints on test result report HTML

https://github.com/xspec/xspec/pull/662#pullrequestreview-301002574

Added a Wiki page as a starting point. (Incomplete. Not added to the sidebar yet.)

I've filled in the missing parts of the Wiki page including https://github.com/xspec/xspec/pull/662#pullrequestreview-301002574. @galtm, please feel free to edit it further directly in Wiki or improve any linguistic/technical points.
And I added Understanding Test Results to the Wiki sidebar.

@AirQuick , the wiki page is really good. Thanks for clarifying so many things there! I made just a few minor edits directly in the wiki.
I changed "dim" to "grey" because naming the color seemed more direct. The page refers to colors by name in other spots. If you had a good reason for not saying grey here, it's OK to change it back to dim.

Thanks @galtm for polishing it.
There was no reason for selecting "dim". Indeed "grey" looks better.


2.0.0 dev device state

get/set/delete for the subcategories of state. Please check the forms they take, especially metadata, because I'm not really sure what that one is supposed to give back

nice job! Merged into dev. Also fixed deviceId and ajax arguments issues with the merge


Neko Application Closes

Steps to reproduce
Loading the Neko app should be faster without allowing it to close automatically.
Expected behavior
Improve the loading sequence within the Neko manga app since some chapters loads to the next automatically without letting the user manually do it own their own.
Actual behavior
Neko frequency crashes whenever I read any type of manga that suits my taste it suddenly kicks me out of the Neko application for no reason.
Crash logs
neko_crash_logs.txt
Neko version
2.10.11
Android version
Android 11
Device
SM-S124DL
Other details
Library and manga updates sometimes takes it's time to load whenever I plan to read or scroll to look for another manga to read.
Acknowledgements

[X] I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open issue.
[X] I have written a short but informative title.
[X] I have tried the troubleshooting guide.
[X] I have updated the app to the newest version Latest.
[X] I have filled out all of the requested information in this form.

Based on #1142 I also encountered the same issue as well whenever I try to filter out other scanlators groups to locate the correct order of chapters they always appear to be missing, especially when I had done what #1142 did as well.

Let me know how 2.10.12 goes


Is there an option to define item limit or paging?

I would like to retrieve a number of items at a time. Is this depend on FeedUrl or there is available option to define it in RSS Parser?

The HTTP request will always retrieve everything in the specified URL, so I don't think it makes sense to add pagination the library (you'll still have the overhead of a large network request and memory usage when parsing the XML).
I don't know of any feeds that offer pagination, but if it's a query parameter you can always pass as part of the URL.


ESP32C6 analog read working wonky

The analog abstraction does not seem to work correctly.
When using Any other Attenuation than 0db, the reported mv values are way off. (This seem to be both the case with calibration=true or not). read_raw might be correct. Additionally the 11db attenuation does not exist for the c6 but it uses a 12db attenuation instead.
The issue sounds similar to this one. https://www.esp32.com/viewtopic.php?t=33015.

 We have wrappers for the legacy adc api and the oneshort / continouse measurement api? I assume you only used the legacy api? What esp-idf version where you using? How did your test-code look like?

Ok finally got time to go further here:
Basically it is just a devboard, with a adjustable power supply connected with GND and GPIO5.
Useing the legacy api I guess (see code at end):
ESP32C6 Power supply at 0V:
All Attunations: Valie is 0 raw is 0
ESP32C6 Power supply at 1.0V (switching calibration to true did not seem to do a difference here):

NONE: Valie is 685 raw is 3808
attenuation::DB_2_5: Valie is 726 raw is 2833
attenuation::DB_6: Valie is 609 raw is 1905
attenuation::DB_11: Valie is 615 raw is 1008
Note: if i half the voltage the raw value roughly halfes as well, so it is actually measuring something, but it is strangly offsetted.

ESP32C3 Power supply at 1.0V (needed to switch to adc2 for this one):

NONE: Valie is 750 raw is 4095
attenuation::DB_2_5: Valie is 904 raw is 3519
attenuation::DB_6: Valie is 807 raw is 2603
attenuation::DB_11: Valie is 815 raw is 1307

ESP32 (M5 Echo) Power supply at 1.0V (needed to switch gpio to 21):

NONE: Valie is 950 raw is 4095
attenuation::DB_2_5: Valie is 952 raw is 3099
attenuation::DB_6:Valie is 957 raw is 2117
attenuation::DB_11: Valie is 700 raw is 1168 (using calibration=true improved to Valie is 1024 raw is 1115)

code for the c6 is this:```
use esp_idf_hal::{adc::{attenuation, AdcChannelDriver, AdcDriver}, delay::Delay, gpio::{ADCPin, Gpio5}, peripherals::Peripherals};
fn main() {
esp_idf_svc::sys::link_patches();
// Bind the log crate to the ESP Logging facilities
esp_idf_svc::log::EspLogger::initialize_default();

let peripherals = Peripherals::take().unwrap();
let adc_config = esp_idf_hal::adc::config::Config {
    resolution: esp_idf_hal::adc::config::Resolution::Resolution12Bit,
    calibration: false,
};
let mut tank_driver = AdcDriver::new(peripherals.adc1, &adc_config).unwrap();
let mut tank_channel: AdcChannelDriver<'_, { attenuation::DB_2_5 }, Gpio5> =
    AdcChannelDriver::new(peripherals.pins.gpio5).unwrap();

let delay = Delay::new(1);
loop {
    delay.delay_ms(500);
    let value = tank_driver.read(&mut tank_channel).unwrap();
    let raw_value = tank_driver.read_raw(&mut tank_channel).unwrap();
    println!("Valie is {} raw is {}",  value, raw_value);
}

}

After this I tested with the oneshot:

**ESP32C6 Power supply at 1.0V**:
- [NONE](attenuation::NONE): Valie is 1005 raw is 3744
- attenuation::DB_2_5: Valie is 989 raw is 2833
- attenuation::DB_6: Valie is 995 raw is 1921
- attenuation::DB_11: Valie is 1031 raw is 993

I guess it is pretty safe to say, that the legacy api does not seem to work for the ESP32C6 (and C3). The raw values seem to be similar but the calculated voltage is way off, while it does seem to be ok with oneshot. Is this a bug or a issue with the legacy api?

oneshot code here:

use esp_idf_hal::{adc::{attenuation, oneshot::{config::AdcChannelConfig, AdcChannelDriver, AdcDriver}}, delay::Delay, peripherals::Peripherals};
fn main() {
// It is necessary to call this function once. Otherwise some patches to the runtime
// implemented by esp-idf-sys might not link properly. See https://github.com/esp-rs/esp-idf-template/issues/71
esp_idf_svc::sys::link_patches();
// Bind the log crate to the ESP Logging facilities
esp_idf_svc::log::EspLogger::initialize_default();

log::info!("Hello, world!");

let peripherals = Peripherals::take().unwrap();
let tank_driver = AdcDriver::new(peripherals.adc1).unwrap();
let config = AdcChannelConfig {
    attenuation:attenuation::DB_11,
    resolution : esp_idf_hal::adc::config::Resolution::Resolution12Bit,
    calibration: false
};

let mut tank_channel_driver = AdcChannelDriver::new(tank_driver, peripherals.pins.gpio5, &config).unwrap();

let delay = Delay::new(1);
loop {
    delay.delay_ms(500);
    let value = tank_channel_driver.read().unwrap();
    let raw_value = tank_channel_driver.read_raw().unwrap();
    println!("Valie is {} raw is {}",  value, raw_value);
}

}

if you have a look at the official supported version schema for esp-idf and the mcu's you see that since the c6 is a fairly new esp and its only supported since 5.1. And since they deprecated the old api with v5 they did not put any development into it for there newer chip. So they only work on a best effort way. So for newer esp's i would try to only use the oneshot/continuous newer api.

I see, a bit disappointing that they care so little but at least not a bug then. I added a comment for others in the first post, so others that end up here see it.


Add checkstyle plugin version

Purpose
Add checkstyle plugin version to the root pom to fix the Maven import issue in IntelliJ Idea.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


The system cannot find the path specified

Hi I get the error "The system cannot find the path specified" after starting the .bat file. What should I do?
Thanks

Take a look at #98
Maybe that helps.

I got it working after changing and deleting the whole bat file and keeping only this

@echo off
start "cheat" "C:\php\php.exe" -f C:\php\SalienCheat\cheat.php


[IOTDB-343] Add test method in session

Add test method in session

the code is fine...I just wonder is it necessary

This feature is designed for helping our user to analyze the time consuming about their code. User can change almost nothing to analyze the performance about preprocessing.


Develop TypeScript library

The Axolotl TypeScript library will be used to:

Provide Solana/Rust types to the user's TypeScript code
Provide helper functions that are useful for developing Solana programs

Types
Since Axolotl programs are written with TypeScript, we can provide types to the users. For Seahorse programs, the types are included in a static file next to your Anchor program.
Rust data types
Refer to the Rust documentation for data types.
Anchor has defined JavaScript --> Rust types. We'll be taking as much inspiration from their implementation as possible. Integers greater than 32 bytes will utilize bn.js, common for both Anchor and Solana.
Solana types

[ ] Pubkey

32-byte account identifier
Source

[ ] AccountInfo

Account information
Source

[ ] Signer
[ ] Program

Used for CPI
Source

[ ] Clock

Information about the network's time
Source

[ ] TokenAccount
[ ] TokenMint

@solana/web3.js has a lot of classes and types that we will likely be able to utilize/export from Axolotl.
Anchor types

[ ] Accounts struct

Source

[ ] Context

Source

[ ] Errors

Helper functions

[ ] declare_id / ID helpers

Generated by Anchor
Instead of a user dealing with this, let's programmatically manage it with .env or something similar

[ ] Helpers related to lamports?

Release

[ ] Released under @axolotl/sol.js

There's a lot of great work done on @polkadot/types-codec that can help develop the Rust data types.


Flatpak Packaging

Considering that Patchmatrix works so well with Pipewire, it would be great to package it up with Flatpak and publish it to Flathub. More and more pro-audio applications are landing on Flathub, and Patchmatrix would be a perfect complement.
I am totally new to Flatpak packaging, but I would be more than happy to help.

thanks, but no, I consider flatpak and its consorts pure atrocities.


Fix for: IOU has pin option in LHN

Details

Fixed Issues

$ https://github.com/Expensify/App/issues/20255
PROPOSAL: https://github.com/Expensify/App/issues/20255#issuecomment-1578488672
Tests

Open FAB menu -> Request money and follow the steps to create a new money request.
Right-click on the IOU thread (the one with a green-light) in the LHN.
Verify that there is no pin option.

[ ] Verify that no errors appear in the JS console

Offline tests

Open FAB menu -> Request money and follow the steps to create a new money request.
Right-click on the IOU thread (the one with a green-light) in the LHN.
Verify that there is no pin option.

QA Steps

Open FAB menu -> Request money and follow the steps to create a new money request.
Right-click on the IOU thread (the one with a green-light) in the LHN.
Verify that there is no pin option.

[ ] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web
https://github.com/Expensify/App/assets/11609254/cd87602f-e7bd-40a9-9de3-50c792acde3f

Mobile Web - Chrome

Mobile Web - Safari
https://github.com/Expensify/App/assets/11609254/b160d437-42c5-4d64-81a6-fe2225686f74

Desktop
https://github.com/Expensify/App/assets/11609254/3bc7fc20-8692-43b3-a22d-6a2b4a3db3c9

iOS
https://github.com/Expensify/App/assets/11609254/4d2bec7b-a1b8-4b8d-90a4-5920afba273a

Android
https://github.com/Expensify/App/assets/11609254/0ded921f-edb2-403e-b6db-d9e838db71a5

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by https://github.com/amyevans in version: 1.3.32-1 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/thienlnam in version: 1.3.32-5 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


App crash on splash screen in iOS (Xcode) on react-native (0.61.5) version

package.json
{
"name": "AwesomeProject",
"version": "0.0.1",
"private": true,
"scripts": {
"android": "react-native run-android",
"ios": "react-native run-ios",
"start": "react-native start",
"test": "jest",
"lint": "eslint ."
},
"dependencies": {
"react": "16.9.0",
"react-native": "0.61.5"
},
"devDependencies": {
"@babel/core": "^7.8.4",
"@babel/runtime": "^7.8.4",
"@react-native-community/eslint-config": "^0.0.7",
"babel-jest": "^25.1.0",
"eslint": "^6.8.0",
"jest": "^25.1.0",
"metro-react-native-babel-preset": "^0.58.0",
"react-test-renderer": "16.9.0"
},
"jest": {
"preset": "react-native"
}
}
Output

Having the same issue here. This happens when using CLI after installing a few navigator libraries even on creating a new project (without expo).


Fix Bugzilla 14945 - unions are missing from the ABI page

Also list empty struct size and add example.

Rebased, tests now passing.


Auto Effects:  Kalashtar Race

The feature Mind Link, could honestly be a blank active effect duration 1 hour and be considered automated if you felt like doing a simple one.  Also maybe add Telepathy as a custom language.  Because its range scales I would either just not put a range in the item, I doubt the range field takes scale values.  Make sure you set the item details duration and also set 3600 seconds in the duration tab of the active effect.

Thanks, and in new release.


JSONPATH for Full Object

Is it possible to get the JSONPATH for full object tree in one shot?

Could you please provide a minimal example of your input and what output/result you'd expect?


Attempt at integrating ode solvers.

The options are passed as a Dictionary. Also an outer construct defaults only to accepting the method parameter. @acroy thoughts ?
WIP :

[x] Docs
[x] Tests

@acroy thoughts on the design would be helpful.

Cool. Looks very reasonable! Can't try it now but will do so asap. (The Travis error is due to ode45 not knowing about points in ODE.jl v0.2; maybe we should enforce using the latest version instead via Pkg.checkout()).

@acroy the tests seem to pass :)

Could you put the ODE stuff into a separate file? I think it is better to have several small files instead of a a very large one with different things mixed up. You could actually separate the general things, like QuPropagator etc, from the actual solvers (QuEuler ...).

@acroy how about we have separate files for Propagator types & Iterator methods, Step propagators, Integrated solvers from other packages ?

Sounds good.

@acroy Docs, Tests and file creation done! A review would be helpful.

@acroy done, is this ready for the merge ?

I would say this looks good. Please squash and merge :-)


NSLayoutConstraint with VisualFormat not working

From @alexrainman on November 9, 2016 15:20
Trying to add a UIPageControl programmatically with this code:
var viewsDictionary = NSDictionary.dictionaryWithObjectForKey(this._pageControl, "pageControl");

this._ios.addConstraints(NSLayoutConstraint.constraintsWithVisualFormatOptionsMetricsViews("H:|[pageControl]|", NSLayoutFormatOptions.NSLayoutFormatAlignAllCenterX, <any>[], viewsDictionary));

this._ios.addConstraints(NSLayoutConstraint.constraintsWithVisualFormatOptionsMetricsViews("V:[pageControl]|", 0, <any>[], viewsDictionary));

But the UIPageControl doesn't goes to bottom as expected, instead is at the top half hidden behind navigation bar.
Any ideas?
Copied from original issue: NativeScript/NativeScript#3052

From @alexrainman on November 9, 2016 15:37
I need this or any other way to apply constraints to a view so i can keep it at the bottom but resizable when screen rotates.

Hey @alexrainman
Can you please share a bit more information about this case!? Or even better - a sample project to reproduce this case.
For example from the snippet above , we are not sure what _this._pageControl_ is and what this means as well.

@NickIliev i am trying to add UIPageControl to the bottom of UIView that acts as container for UIPageViewController. I did the same thing in the Xamarin.Forms version of my plugin and it works like a charm. I also verified that the UIView container has the right size but the UIPageControl doesn't stick to the bottom.
Please, take a look at iOS version of the plugin https://github.com/alexrainman/nativescript-carousel-view/blob/master/carousel-view.ios.ts
I am trying to add the UIPageControll onLoaded() after line 58.
I don't have issues in Android dough, so solving this will allow me to update the plugin including page indicators in both platforms vertically and horizontally.

@alexrainman I don't see any call to the addConstraints method in your code. Please, could you send us a sample project that demonstrates the issue. In the demo project from your git repo everything looks normal?

@tzraikov i will create a different repo implementing this.

Thanks!

@tzraikov take a look at this repo:
https://github.com/alexrainman/nativescript-carousel-view-dev
Notice that page indicators are working in Android already but i cannot make it work in iOS because of this issue.
Thanks

@tzraikov please review this file https://github.com/alexrainman/nativescript-carousel-view-dev/blob/master/app/carousel-view/carousel-view.ios.ts line 63 to 100.

Look where UIPageControl shows no matter how i add the constraints

@alexrainman I found the issue. You should not set the translatesAutoresizingMaskIntoConstraints this way:
this._pageControl.translatesAutoresizingMaskIntoConstraints = () => false;
Use this code instead:
(<any>this._pageControl).translatesAutoresizingMaskIntoConstraints = false;
This code centers the view horizontally:
this._ios.addConstraints(NSLayoutConstraint.constraintsWithVisualFormatOptionsMetricsViews("H:|-[pageControl]-|", NSLayoutFormatOptions.NSLayoutFormatAlignAllCenterY, null, viewsDictionary));
Use this one to center it at the top of the page:
this._ios.addConstraints(NSLayoutConstraint.constraintsWithVisualFormatOptionsMetricsViews("V:|-[pageControl]", 0, null, viewsDictionary));
This one will center the view at the bottom of the page:
this._ios.addConstraints(NSLayoutConstraint.constraintsWithVisualFormatOptionsMetricsViews("V:[pageControl]-|", 0, null, viewsDictionary));

It works. Just released a new version of the plugin with page indicators included. Thanks

Basically it was one line of code issue. Thanks.


:book: Add introduction videos and media section to our docs

Is your feature request related to a problem? Please describe.
We do have few videos and blog posts that can be helpful to our docs:

https://www.youtube.com/watch?v=kiDQujibz2k
https://www.youtube.com/watch?v=doXT1jxyZe0
https://thenewstack.io/livin-kubernetes-on-the-immutable-edge-with-kairos-project/

Aside, also the slides used in the video should be public as well
Describe the solution you'd like
The introduction video sounds a great fit for our quickstart. I think we should also have a separate section with media resources, blog posts, howtos, etc.

@mudler I wasn't able to find the slides, could you please share them?


boards/esp32s3_lan9250: configure ethernet universally MAC address

Summary
boards/esp32s3_lan9250: configure the number of universally administered (by IEEE) MAC addresses.
This PR refers to PR#8993
Impact
Provide universal mac addresses support for esp32s3 LAN9250
Testing
esp32s3-devkit:eth_lan9250

[Experimental Bot, please feedback here]
The PR summary is missing key information like:

Why is this change necessary?  What problem does it solve? Is there a bug report or feature request driving this?
What functional part of the code is being changed? Be specific - mention files, modules, or functions affected.
How does the change work? Provide a more technical explanation of the implementation.

The Impact section is somewhat vague:

Is new feature added? Is existing feature changed? Be explicit. This seems like a new feature, state that clearly.
Impact on user: "Provide universal mac addresses support" is not descriptive enough. How will users benefit? Will they need to change configurations, use new APIs, etc.?

The Testing section needs significant improvement:

Build Host(s):  Provide specific details about your development environment (OS version, compiler version, etc.).
Testing logs before change / after change: These are placeholders. You need to include actual log snippets demonstrating the issue before the change and the improvement after.

In its current state, the PR would likely not meet NuttX requirements.  You need to provide more context, details about the implementation, and clear evidence of testing.


core: Add @go.select_option function and demo

While starting to write my first "real" application/plugin, I realized that this function would eliminate a lot of repetitive boilerplate between scripts for the common single-option selection case.

Coverage increased (+0.05%) to 95.205% when pulling 73d36b3cb6ecf43a2ea6ed307c0204a080eb8c07 on select-option into a9079ee027ff728dad4c62607857fe8ed0c35528 on master.


Add missing Pressure function

This PR adds the missing Pressure kernel when melt fraction is in the args but thermal stresses are missing

Codecov Report
Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Files with missing lines
Patch %
Lines

src/stokes/PressureKernels.jl
0.00%
4 Missing :warning:

Additional details and impacted files

:loudspeaker: Thoughts on this report? Let us know!


Remove notifications before sending another

Fixes https://github.com/PuppyBongos/standing-desk-app/issues/36#issuecomment-161822154. Also keeps notification center clean and simple.

Thanks! This will work just fine.


Add option to only delete the default labels

This way, if we're working with a repo that already has some tickets labeled, they can add the new labels, swap tickets over to the new label system, and then delete the old labels.

Completed in 57da269


Upgrade actions/upload-artifact v4.4.3 -> v4.5.0

This PR contains the following updates:

Package
Type
Update
Change

actions/upload-artifact
action
minor
v4.4.3 -> v4.5.0

Release Notes

actions/upload-artifact (actions/upload-artifact)
v4.5.0
Compare Source
What's Changed

fix: deprecated Node.js version in action by @hamirmahal in https://github.com/actions/upload-artifact/pull/578
Add new artifact-digest output by @bdehamer in https://github.com/actions/upload-artifact/pull/656

New Contributors

@hamirmahal made their first contribution in https://github.com/actions/upload-artifact/pull/578
@bdehamer made their first contribution in https://github.com/actions/upload-artifact/pull/656

Full Changelog: https://github.com/actions/upload-artifact/compare/v4.4.3...v4.5.0

[ ] If you want to rebase/retry this PR, check this box

Suggested commit message:
Upgrade actions/upload-artifact v4.4.3 -> v4.5.0

See:
- https://github.com/actions/upload-artifact/releases/tag/v4.5.0


add tests

Summary by CodeRabbit

Tests

Introduced new test cases for sync protocol operations, message encoding, message decoding, and sync protocol v2 operations, enhancing coverage and validating functionality.

coverage: 95.556% (+0.8%) from 94.722%
when pulling a6a2bbf8453478691ea97238ebd835ec893aac8b on add_tests
into d9b3d71d76fb3070e8f436fdcb86107d0ca06de3 on main.


HowTo start a multi adb wireless connection for scrcpy at windows. by .bat .cmd script

@echo off

SET IPAddress=<IP_ADDRESS>
SET SERIAL=W3D7G16BA25014572
SET NOCONSOLEVBS=scrcpy-noconsole-phone1.vbs

:Start
echo "*** Test TCP/IP connection"
adb -s %IPAddress% shell ip route && goto RunScrCpy || goto ReConnectWiFiConnection

:RunScrCpy
echo "*** RunScrCpy"
start /B %NOCONSOLEVBS%
goto TheEnd

:ReConnectWiFiConnection
echo "*** ReConnectWiFiConnection"
adb -s %SERIAL% connect %IPAddress%:5555 |findstr /C:"cannot connect to" && goto CheckUSBConnection
adb -s %SERIAL% connect %IPAddress%:5555 |findstr /C:"connected to" && goto Start || (echo "Error1" & goto TheEnd)
goto TheEnd

:CheckUSBConnection
echo "*** CheckUSBConnection"
adb -s %SERIAL% shell ip route && goto StartTCPIP || (echo "Connect phone to USB in Debug mode" & goto TheEnd)
goto TheEnd

:StartTCPIP
echo "*** StartTCPIP"
adb -s %SERIAL% tcpip 5555 && (timeout /t 15 & goto ReConnectWiFiConnection) || (echo Error2 & goto TheEnd)
goto TheEnd

:TheEnd

I use 3 phones and run that script when phone is rebooted and all other problems like wifi reconnection is done by script.
This way is super cool, because it's easy logic from cmd output, the AutoAdb cannot do that logic :( and script rescue my life.


Add Profiling tools for Onnx Engine

Description
DJL has profiler support for MXNet and PyTorch [REF]. I would like to request to extend this profiler support for ONNX engine also.
References

https://djl.ai/docs/development/profiler.html
https://onnxruntime.ai/docs/performance/tune-performance/profiling-tools.html#in-code-performance-profiling

You can enable onnxruntime profiler using the following code:
            Path modelDir = Paths.get("YOUR_MODEL_DIR");
            Model model = Model.newInstance("my_model");
            OrtSession.SessionOptions ortOptions = new OrtSession.SessionOptions();
            ortOptions.enableProfiling("out.txt");
            Map<String, Object> options = new ConcurrentHashMap<>();
            options.put("sessionOptions", ortOptions);
            model.load(modelDir, "mymodel.onnx", options);

See: https://github.com/deepjavalibrary/djl/pull/2472
With this PR, you can enable profiler in a more elegant way:
Criteria<Image, Classifications> criteria =
        Criteria.builder()
            .optOption("profilerOutput", "build/testOrtProfiling")
            ...
            .build()


Bug: Pipette not attempting tip pickup during labware calibration

Currently, pipette is not attempting tip pickup during labware calibration
Issue:
Expected: Pipette moves to tip rack and attempts to pick up tip
Observed: Pipette d/n move, and Run App asks user to confirm pipette picked up tip
Environment:
Robot: Small Smoke (commit 321538)
Run App: v3.0.0-mac-2018-02-07_20-18-v3a-3210538
Protocol:
Serial_dilution_OT2_ekker_v2.txt

Closing -- unable to recreate after #621 (Mike's calibration story.


Array observer called twice whenobserving with .* (star) and using .push

http://jsbin.com/tobaloceva/edit?html,output
Is this the expected behavior?

This is expected. If you check the change record, you'll see it's getting notified for two different paths: arr.splices and arr.length.
arrChanged_(cR) {
  console.info('called for ' + cR.path);
},

Yeah, I was expecting that, thanks for the explanation. This is still a bit confusing: What would be the use case for being notified twice? I would think you would always only want one notification?

Polymer sends array.length notifications for array mutations that modify the length so that bindings to e.g. <div>{{array.length}}</div> will update.  This is separate from the array.splices, whose notified value carries the actual mutation information.  Since they are two separate pieces of information, it results in two notifications.


add place_guess for observations without it

If an observation has coordinates but no place_guess on creation, add a place guess based on the iNat system places, a la https://github.com/inaturalist/inaturalist/blob/master/app/models/local_photo.rb#L177. If possible and performative, this should not occur in a delayed jobs and all obs returned from ObservationsController#create should have this set, but if this is going to seriously bog down the obs creation process even more, consider scrapping it.
Part of the solution to https://github.com/inaturalist/INaturalistIOS/issues/257

For the record, this does had something between 1-5 ms of time to observation creation, but given that only about 16.5 % of existing iNat observations are lacking a place_guess, I think the performance cost is probably worth it.


Grid not being responsive within List

If I have a grid for overall layout, and that page frame has a list in it with several items and each item has an inner grid to manage the layout of the item and I want it to response to smaller screen by having the contents of the ListItem be either horizontal with each other on larger screen or stack vertically on smaller, the grid system is not working within ListItem.
Is ListItem specifically forcing/preventing this or some other way to do it???
<Grid container direction="row"
                justify="center"
                alignItems="center"
                spacing={8} >
                <Grid item xs={11}>
                    <List>
                        {doctorsResult.map(doc => (

                                <Divider />
                                <ListItem className={classes.listItem}>
                                    <Grid container direction="row"
                                        justify="center"
                                        alignItems="center"
                                        spacing={8} >
                                        <Grid item xs={2}>
                                            <Avatar alt={doc.name} src={doc.profile_img_url} style={{ minWidth: "146px", minHeight: "146px" }} />
                                        </Grid>
                                        <Grid item xs={4} >

                                                <ListItemText primary={doc.name} classes={{ primary: classes.listheader }} />

                                            <Divider />
                                            <ListItemText primary={doc.doc_type} style={{ fontSize: "14pt", fontWeight: "Bold" }} />

                                                ({doc.num_ratings})

                                            <ListItemText primary={`"${doc.example_comment}"`} style={{ fontStyle: "italic" }} />

                                            <ListItemText primary={doc.address.street1} />
                                            <ListItemText primary={` ${doc.address.city}, ${doc.address.state} ${doc.address.zip}`} />
                                        </Grid>
                                        <Grid item xs={6}>
                                            <Button variant="fab" color="secondary" aria-label="Edit" className={classes.button}>
                                                <Icon>edit_icon</Icon>
                                            </Button> Message
                                        </Grid>
                                    </Grid>
                                </ListItem>

                        ))}
                    </List>
                </Grid>
            </Grid>

Please provide a full reproduction test case. This would help a lot 👷 .
A live example would be perfect. This codesandbox.io template may be a good starting point. Thank you!

Here ya go https://codesandbox.io/s/z2qzx1jxp4

@bjm88 I would discourage you to mix the Grid and the List component, use one or the other. They weren't meant to be mixed.

Ok, it would be nice to have that documented and perhaps explain how using grid inside a loop differs from list... Is list just adding that rollover style to it or I assume doing more...
Is list not meant to be responsive by itself then?

The list isn't meant to be responsive. But I'm sure you can find some way to do it with breakpoints.


about tf.app.flags and argparse

Thank you ! You did a great job.
I was a beginner who has just started learning to Python, TensorFlow and Capsule. I read the code and was confused about the tf.app.flags and argparse, they seem to do the same job, but why you used both of them. Do you have some particular reason to use both of them?

@EigenvectorOfFate Thanks for pointing that out.
This project is actually a part of a larger project which relies heavily on tf.app.FLAGS. To avoid confusion, I have removed argparser from this repository.


Update/Fix Get-Started with ES6 standard import

Changed
import _ from 'lodash';

to
import * as _ from 'lodash';

It should work both ways: https://github.com/lodash/lodash/blob/4.17.2-es/lodash.js. Why change it?

@asapach It should but for some reason doesn't when you follow the guide. My guess is it's trying to find '_' in the package to import.

@Sieabah That sounds like a webpack bug esp. if it works through Babel. Any thoughts on the import issue @sokra?

Can you rebase against master? The development happens against it now (faster deployments).

Can you rebase against master? The development happens against it now (faster deployments).

@Sieabah I've changed the PR to be applied against master. I think you need to do something like this:
git rebase master
git push --force

It is possible you may have to pull the latest master.

Ah, it's looking pretty good already. You could squash the commits, but apart from that it's fine.

import _ from 'lodash'; works for me against the current RC. Can you verify?

Given import _ from 'lodash'; should work, I'm going to close this one. Note that with lodash, the recommended way seems to be import { omit } from 'lodash';. There are also specific plugins that can help with it etc.


Build "app" grails Docker container

mama-ng-scheduler (build included dockerfile)

Ready for review.
I'm not doing any fancy stuff here - just building the Dockerfile in the repo. Don't want to mess with grails.

Not sure whether to do this here or in the mama-ng-scheduler repo itself?

:+1:
Let's keep the build stuff together for now.


Sync eng/common directory with azure-sdk-tools for PR 9331

Sync eng/common directory with azure-sdk-tools for PR https://github.com/Azure/azure-sdk-tools/pull/9331  See eng/common workflow

The Mac failures in the c - client - ci run are not the result of this PR. Those started failing on 10/31/2024.


CSOAR-1149: Add csoar-automation-bridge on Docker documentation

Signed-off-by: Fabio Felici<EMAIL_ADDRESS>PLEASE READ
Following a recent back-end update, all contributors with a local clone or fork of our repository are required to run yarn install. This does not apply to direct page edits.

[x] Yes, I've run yarn install
[ ] No, does not apply to me

Purpose of this pull request
This pull request introduce the documentation for CSOAR Automation Bridge on Docker for teach how to run a dockerized version of cloud soar automation bridge.

Select the type of change:

[ ] Minor Changes - Typos, formatting, slight revisions, .clabot
[ ] Update Content - Revisions, updating sections
[x] New Content - New features, sections, pages, tutorials
[ ] Site and Tools - Updates, maintenance, dependencies, new packages for the site (Docusaurus, Gatsby, React, etc.)

Changes are perfect, thanks!


prost-build lib.rs: Minor doc comment edits

Fix the indentation of the example .proto file. Fix build.rs compile error.
Fixes:
error[E0107]: wrong number of type arguments: expected 2, found 1
Feel free to reject this, I am extremely new to Rust so maybe I'm not understanding something. I'm trying to fix the documentation on crates.io here: https://docs.rs/prost-build/0.7.0/prost_build/

for some reason the PR here is bugged and won't let me merge but I've merged it via https://github.com/tokio-rs/prost/pull/498 thanks for the contribution!


PHP: wrong inlay hints

Description:

Method Definition:

Extension settings (default overriden):
"inline-parameters.php.suppressWhenArgumentMatchesName": false
Inlay settings:
"editor.inlayHints.enabled": "offUnlessPressed"
If there is some additional info, feel free to ask.

What parameters do you see when you hover your mouse over the $this->paymentCreatorService->createPayment? I use those parameters (from intelephense) to determine the hints to show

What parameters do you see when you hover your mouse over the $this->paymentCreatorService->createPayment? I use those parameters (from intelephense) to determine the hints to show

This is the output from hints by pressing Parameter hint (CTRL+SHIFT+SPACE)

I have unfortunately been unable to recreate this issue. Are you able to recreate this in a file such as the test/example.php in this repository? If so, that would be helpful for me to see and fix the issue.

@RobertOstermann,
I was able to reproduce it and it seems annotations handling issue(if there are no annotations, everything works fine). The issue is with call of PaymentServiceInterface::transfer() method in testInterface function.
This code show one more issue with parameter name if parameter has brackets: check $currency argument and hint locations (in my opinion, it should be outside of brackets)
Code of example:
<?php

class Account
{
    private int $minorUnits = 0;

    public function getMinorUnits(): int
    {
        return $this->minorUnits;
    }

    public function setMinorUnits(int $minorUnits): self
    {
        $this->minorUnits = $minorUnits;

        return $this;
    }
}

class Currency
{
    private string $currencyCode = 'USD';

    public function getCurrencyCode(): int
    {
        return $this->currencyCode;
    }

    public function setCurrencyCode(int $currencyCode): self
    {
        $this->currencyCode = $currencyCode;

        return $this;
    }
}

class Payment
{
    private ?Currency $currency = null;

    public function getCurrency(): ?Currency
    {
        return $this->currency;
    }

    public function setCurrencyCode(Currency $currency): self
    {
        $this->currency = $currency;

        return $this;
    }
}

interface PaymentServiceInterface
{
    /**
     * @param callable $minorUnitsCallback (Account $sourceAccount, Account $destAccount): int
     * @param callable|null $beforePaymentIsBuild (Account $sourceAccount, Account $destAccount, int $minorUnits): void
     * @param callable|null $whenPaymentIsCreated (Payment $payment, Account $sourceAccount, Account $destAccount): void
     * @param callable|null $whenMoneyAreTransferred (Payment $payment, Account $sourceAccount, Account $destAccount): void
     */
    public function transfer(
        int $sourceAccountId,
        int $destinationAccountId,
        Currency $currency,
        callable $minorUnitsCallback,
        string $paymentReference,
        int $paymentType,
        ?Payment $parent = null,
        callable $beforePaymentIsBuild = null,
        callable $whenPaymentIsCreated = null,
        callable $whenMoneyAreTransferred = null
    ): Payment;
}

function testInterface(PaymentServiceInterface $p)
{
    return $p->transfer(
        1,
        2,
        ((new Currency())->setCurrencyCode('USD')),
        fn () => 1,
        'qqq',
        1,
        null,
    );
}

@AndreiOrmanji You are correct, seems to be an issue with handling annotations. I use the hover provided by PHP Intelephense to determine the parameters and display them. When annotations are present, it seems the hover has a different order the parameters are presented in.

I am currently just using a regex to parse the parameters and return them. It will probably require parsing the function part of the hover (definition) to determine the correct order of the parameters and reordering them after I grab them from the definition.

I am busy with other projects and it might be some time before I am able to work on this. If you wanted to work on this and provide a pull request I would get that merged and published. Or you can workaround it by providing annotations for all the variables (in the correct order) or not using annotations at all, though in this case that is probably not ideal.


EditorWindow.focusedWindow is null on Ubuntu 16.04

Hi,
First of all, thanks for this plugin, was what I was looking for. But when trying it on my ubuntu 16.04 the following line EditorWindow.focusedWindow.SendEvent(typeReferenceUpdatedEvent);, after selecting a type from the drop down, fails with a nullpointer, e.g. focusedWindow. Seems that the window does not have proper focus or unity linux doesn't support it all that well. Perhaps there are other ways to get the event to its destination?
Kind regards,
Dries

EditorWindow focusedWindow = null;             EditorWindow[] allWindows = Resources.FindObjectsOfTypeAll<EditorWindow>();             for (int i = 0; i < allWindows.Length; i++)             {                 if (allWindows[i].titleContent.text == "Inspector")                 {                     focusedWindow = allWindows[i];                 }             }
I've replaced it with this, pretty dirty hack but makes it work for me until Unity/Ubuntu resolves the focus issue I suppose.

Had the same issue with Unity 2018.2.4f1 on Linux.
The workaround helped, thx!


Cubemap demo bug

I mention it in both the main README TODO list and the demo README description.  Basically the sky wobbles when you look around but is fine when you move.  Most likely a bug in the demo not in PortableGL but anything's possible.
I'm putting this here to motivate me to fix it sometime this year hopefully.

Fixed with commit ee89b19.
It really was the dumbest bug ever.  I just never looked at it and I have no idea why I was using noperspective in the first place.  I vaguely recall that there might have been several bugs when I first wrote it and I switched to that seeing if it fixed the other ones and then never switched it back.  Who knows.


Revert "Wrap PopupMenu with SafeArea to respect status bar"

Reverts flutter/flutter#64678
test/material/popup_menu_test.dart:1596:37: Error: A value of type 'int?' can't be assigned to a variable of type 'int'.
    int _selectedValue = choices[0].value;
                                    ^
test/material/popup_menu_test.dart:1600:18: Error: The argument type 'MediaQuery Function(BuildContext, Widget)' can't be assigned to the parameter type 'Widget Function(BuildContext, Widget?)?'.
 - 'MediaQuery' is from 'package:flutter/src/widgets/media_query.dart' ('lib/src/widgets/media_query.dart').
 - 'BuildContext' is from 'package:flutter/src/widgets/framework.dart' ('lib/src/widgets/framework.dart').
 - 'Widget' is from 'package:flutter/src/widgets/framework.dart' ('lib/src/widgets/framework.dart').
        builder: (BuildContext context, Widget child) {
                 ^
test/material/popup_menu_test.dart:1654:18: Error: The argument type 'MediaQuery Function(BuildContext, Widget)' can't be assigned to the parameter type 'Widget Function(BuildContext, Widget?)?'.
 - 'MediaQuery' is from 'package:flutter/src/widgets/media_query.dart' ('lib/src/widgets/media_query.dart').
 - 'BuildContext' is from 'package:flutter/src/widgets/framework.dart' ('lib/src/widgets/framework.dart').
 - 'Widget' is from 'package:flutter/src/widgets/framework.dart' ('lib/src/widgets/framework.dart').
        builder: (BuildContext context, Widget child) {
                 ^
02:14 +2967 ~12: /b/s/w/ir/k/flutter/packages/flutter/test/material/dropdown_test.dart: Having a focused element doesn't interrupt scroll when flung by touch
02:14 +2968 ~12: /b/s/w/ir/k/flutter/packages

TBR @Piinks


Workorder "Claim" / "Done" buttons go out of view as screen width increases

Describe the bug
Workorder "Claim" / "Done" buttons go out of view as screen width increases.
To Reproduce

Use any incident.
Navigate to the map (Work page) and click any worksite.
Ensure your browse window is set to full width (Greater than 1280px)
The "Claim" and "Done" button text will be out of view and it's not possible to scroll to see them.
Increasing and decreasing the browser window will not cause the buttons to fully appear.

Screenshots

Desktop (please complete the following information):

MacOS
Chrome

Possible regression of #558


Error reading NIFTI file

Im getting this error when validating this file  (on the command line):
/Users/filo/drive/workspace/bids-validator/node_modules/nifti-js/nifti.js:25
    throw new Error("The buffer is not even large enough to contain the minimal header I would expect from a NIfTI file!")
    ^

Error: The buffer is not even large enough to contain the minimal header I would expect from a NIfTI file!
    at Object.parseNIfTIHeader (/Users/filo/drive/workspace/bids-validator/node_modules/nifti-js/nifti.js:25:11)
    at /Users/filo/drive/workspace/bids-validator/utils/files.js:125:36
    at Gunzip.onEnd (zlib.js:227:5)
    at emitNone (events.js:72:20)
    at Gunzip.emit (events.js:166:7)
    at endReadableNT (_stream_readable.js:903:12)
    at doNTCallback2 (node.js:439:9)
    at process._tickCallback (node.js:353:17)
orange:bids-validator filo$ open /tmp/AA//sub-S2529LVY1263171/func/sub-S2529LVY1263171_task-rest_acq-RL_run-2_sbref.nii.gz

The file you sent me is failing because it's not gzipped. Do we need to account for reading unzipped niftis and did we lose our check for niftis without the .gz extension? I'm not seeing it anymore.

Ignore that I believe I unzipped it by opening it from my downloads.

I haven't been able to reproduce this one. I was able to get it to validate by adding it to a dataset and testing w/ the CLI. I also created a quick script to log the contents. If you want to test it you can save it in the root of the validator repo and run it like node nameOfFile.js /path/to/single/scan/file.nii.gz
var files = require('./utils/files');
var file = {path: process.argv[2]};

files.readNiftiHeader(file, function (header) {
	console.log(header);
});

Is it possible your validator or node modules are out of date?

This is weird - I could not replicate the error with the code you provided running on individual nifti files. However when running on the whole dataset it still appears. I created a simple stripped down dataset to replicate the bug: https://docs.google.com/uc?id=0B77zr9yIiKOTRnZzVDN4akQweXM&export=download

Thanks. I'll test this out.

When I pulled that same file out of the dataset linked above I was able to reproduce the error with even the minimal test. It looks like that particular file shrunk during decompression.
My header reading strategy was to read the number of bytes equal to the nifti header size (348) then decompress it and run the binary reading. I was assuming that headers would generally grow in size during decompression. This particular file shrunk so I increased the overall number of bytes we're reading for each scan from 348 to 500. I'm also looking to see if there are strategies for predicting decompression sizes or at least establishing a sane limit of bytes we need to read.


Fixed early release of stubs that use andReturn() in ARC.

This fixes issue #192.
This was happening because in ARC, when you create a temporary value, it defaults to being __strong, meaning it will be released as soon as the scope ends. Because of the GCC statement expression there the code between (({ ... })), the scope in which the temporary value was created was being destroyed before being passed to the andReturn block.
We fix this by using a GCC/clang extension, __builtin_choose_expr, to add an associated object to the NSValue returned by the temporary scope, only if the type of the value is an object, so that it will also work for primitive types/structs.
Thanks to @nlutsenko for helping me construct this crazy solution!

:octocat:

It would appear that __builtin_choose_expr is not doing as I had initially tested. I'll work on fixing it and get back.

Remove __builtin_choose_expr, now using a pointer typecast to prevent build errors.

@erikdoe Ping?

To be honest I had a quick look at this when you first opened the PR but I didn't understand it right away. I've now spend more time with it and it looks pretty good. I just have one question: What is the reason to use the value object as the association key? Couldn't you just use a dummy C-String as key?

@erikdoe Yep, we definitely could do that. I used the address as the key as it's unlikely to be recycled for the object, and we never need to read from it again. If you'd prefer a dummy string that's no issue at all.

I've merged this now, making the change with the constant for the association key and I renamed the variables a little bit to make the code slightly more understandable. Github doesn't seem to see that it's merged so closing this manually.


Scheduler: logging interval is broken

I've noticed that "log value" function doesn't work properly for Interval. Once you select for example Repeat: hourly, every: 4 hours Interval is set to 4. After change to Repeat: every minute - Interval is still 4. Do you know why ? It should be registered as 4.

Here you can find JSON log with "Interval=1" for "PER MINUTE" option: http://postimg.org/image/quu6d73nn/


add slide on comparison vs venv and conda

Fixed in https://github.com/AndreaPi/docker-training-2019-public/commit/b40adf666099d015e34865a3a27a458d0c4620e5


ImportError: cannot import name lookup_ops

  File "nmt/inference.py", line 25, in <module>
    from tensorflow.python.ops import lookup_ops

my tensorflow is v1.1

upgrading it to 1.2.1 fixed this


Fire stick 4k customised subtitles

Hi. There is no way to customise subtitles on Fire Stick 4K. When long pressing the gear icon then scrolling to caption preferences, the screen goes to blank video playing screen. Any workaround for this or just a shortcoming of Fire OS?

According to this video it looks like there's setting for customizing subtitles: https://www.youtube.com/watch?v=V1KorM8A9kw

Thanks pal. I thought you had to customise within the player settings. Didn't realise you could customise with the fire stick settings and it would work within app. Do you know how to make the player stop playing when you exit a stream? For me the audio can be heard for about 5-10 seconds after stopping. Thanks.


Add Stephanie Douglas to list of Contributors

Thanks for this! The contributors list is out of date.


System clock not synced

Version (k3OS / kernel)
v0.20.7-k3s1r0
5.4.0-73-generic #82 SMP Thu Jun 3 02:29:43 UTC 2021
Architecture
x86_64
Describe the bug
I checked both date and hwclock command, the system current time is not correct.
In my case, it was 3 minus advanced.
Expected behavior
It should be sync via a NTP daemon.
Actual behavior
It seems time is not synced.

ntpd is not started by default because connman is supposed to take care of clock skew. Depending on your configuration and network (can it access the internet?), this can be easy to break. I like to start ntpd with a run_cmd in my config.yaml, e.g.:
run_cmd:
- rc-service ntpd start

If your network is isolated from the public internet you will of course need to add a write_files entry to properly configure /etc/conf.d/ntpd

Thanks @dweomer, I tested this method works great!


[v1.5.x] fix LinearRegressionOutput with empty label (#15620)

Description
This PR intends to cherry pick #15620 from the master branch to v1.5.x branch to fix issue https://github.com/apache/incubator-mxnet/issues/15784
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.

[ ] The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
[ ] Changes are complete (i.e. I finished coding on this PR)
[ ] All changes have test coverage:
Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
[ ] Code is well-documented:
For user-facing API changes, API doc string has been updated.
For new C++ functions in header files, their functionalities and arguments are documented.
For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
[ ] To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

[ ] Feature1, tests, (and when applicable, API doc)
[ ] Feature2, tests, (and when applicable, API doc)

Comments

If this change is a backward incompatible change, why must this change be made.
Interesting edge cases to note here

@samskalicky Please help to review. Hope it can fix your issue of 1.5.0.


warning in conda install

$ conda env create -f environment.yml
/data/birna01/Software/miniconda3-2024/lib/python3.12/argparse.py:2006: FutureWarning: `remote_definition` is deprecated and will be removed in 25.9. Use `conda env create --file=URL` instead.
  action(self, namespace, argument_values, option_string)
Retrieving notices: ...working... done
Warning: you have pip-installed dependencies in your environment file, but you do not list pip itself as one of your conda dependencies.  Conda may not use the correct pip to install your packages, and they may end up in the wrong place.  Please add an explicit pip dependency.  I'm adding one for you, but still nagging you.
[...]

maybe extend respectively, to get rid of the warning..


Add alert control to dogshell

Alerts are supported by our API. Add it to dogshell.

Fixed in datadogpy. Closing.


proposal: context: add context.Reader/context.Writer

Proposal Details
The stdlib has a fair amount of readers/writers that block until more content is available. For example:

io.Pipe()
os.Pipe()
net.TCPConn

It can be tricky to handle context cancellation promptly when a goroutine is waiting for a blocking read/write.
Existing workarounds
Let's look at some workarounds to implement a version of io.Copy that accepts a context and closes the writer when it's done.
Putting cleanup code in context.AfterFunc()
func CopyAndClose(ctx context.Context, r io.Reader, w io.WriteCloser) error {
	stop := context.AfterFunc(ctx, func() {
		_ = w.Close()
	})
	defer func() {
		if stop() {
			_ = w.Close()
		}
	}()
	buf := make([]byte, 1024)
	for {
		if err := context.Cause(ctx); err != nil {
			return err
		}

		n, err := r.Read(buf)
		if errors.Is(err, io.EOF) {
			return nil
		}

		if err := context.Cause(ctx); err != nil {
			return err
		}

		_, err = w.Write(buf[:n])
		if err != nil {
			return err
		}
	}
}

Problems:

Doesn't return immediately if it's blocked on a read/write call
Requires even more synchronization than in the example in order to guarantee the function will never attempt to call w.Write after w has been closed.

Using additional goroutines and channels to unblock function return
func CopyAndClose(ctx context.Context, r io.Reader, w io.WriteCloser) error {
	eg := &errgroup.Group{}
	c := make(chan []byte)

	eg.Go(func() error {
		defer close(c)
		buf := make([]byte, 1024)
		buf2 := make([]byte, 1024)
		for {
			n, err := r.Read(buf)
			if errors.Is(err, io.EOF) {
				return nil
			}
			select {
			case <-ctx.Done():
				return context.Cause(ctx)
			case c <- buf[:n]:
			}
			buf, buf2 = buf2, buf
		}
	})
	eg.Go(func() error {
		defer w.Close()
		for {
			select {
			case <-ctx.Done():
				return context.Cause(ctx)
			case buf, ok := <-c:
				if !ok {
					return nil
				}
				_, err := w.Write(buf)
				if err != nil {
					return err
				}
			}
		}
	})

	done := make(chan error)
	go func() {
		done <- eg.Wait()
		close(done)
	}()

	select {
	case err := <-done:
		return err
	case <-ctx.Done():
		go func() {
			<-done
		}()
		return context.Cause(ctx)
	}
}

Problems:

Doesn't guarantee that w has been closed when the function returns
Leaves several dangling goroutines that won't finish until the blocking Read/Write calls finish

Proposal
Add something like this to context:
type Reader interface {
	io.Reader
	ContextRead(ctx Context, p []byte) (n int, err error)
}

func Read(ctx Context, r io.Reader, p []byte) (n int, err error) {
	if r, ok := r.(Reader); ok {
		return r.ContextRead(ctx, p)
	}
	if err := Cause(ctx); err != nil {
		return 0, err
	}
	return r.Read(p)
}

type Writer interface {
	io.Writer
	ContextWrite(ctx Context, p []byte) (n int, err error)
}

func Write(ctx Context, w io.Writer, p []byte) (n int, err error) {
	if w, ok := w.(Writer); ok {
		return w.ContextWrite(ctx, p)
	}
	if err := Cause(ctx); err != nil {
		return 0, err
	}
	return w.Write(p)
}

This would allow every reader/writer to implement their own ContextRead/ContextWrite methods as possible/necessary in order to unblock their calls on context cancellation. Having it in the stdlib would be especially beneficial because many of the readers/writers that folks would want to use this with are in the stdlib.
With these proposed changes, CopyAndClose would look like this:
func CopyAndClose(ctx context.Context, r io.Reader, w io.WriteCloser) error {
	defer w.Close()

	buf := make([]byte, 1024)
	for {
		n, err := context.Read(ctx, r, buf)
		if errors.Is(err, io.EOF) {
			return nil
		} else if err != nil {
			return err
		}

		_, err = context.Write(ctx, w, buf[:n])
		if err != nil {
			return err
		}
	}
}

There's a lot of overlap with #20280 here.

Wow, GitHub search has completely fallen on its face for me. My search keywords were "context" and "reader", yet that proposal didn't show up on the first page of results.

On the other hand it's the top result when I do a Google search for "site:github.com golang issue context reader".
I also find GitHub issue search to be suboptimal.

Two initial reactions:

It feels more reasonable for package io to import package context than the other way around, if one has to import the other. Also these operations feel more "I/O-related" than "Context-related". Therefore I'd suggest placing these new declarations in package io.
Elsewhere in standard library a late-added variant of a function that takes a context has been named with Context as a suffix, rather than as a prefix. For example, signal.Notify was augmented as signal.NotifyContext to support the additional context argument. Therefore I'd suggest naming the interface methods ReadContext and WriteContext, and (continuing the previous point) the functions io.ReadContext and io.WriteContext.

Aside from those to minor (bikesheddy) points, this does seem like a plausible way to retrofit the io interfaces with optional context support.

It feels more reasonable for package io to import package context than the other way around, if one has to import the other. Also these operations feel more "I/O-related" than "Context-related". Therefore I'd suggest placing these new declarations in package io.

I put io.Reader and io.Writer in the example for expediency, but it'd probably make sense for the actual implementation to use its own definition of those interfaces to avoid importing io. Since those interface definitions are the only dependencies, there's no hard requirement to import io when defining them in the context package.

Elsewhere in standard library a late-added variant of a function that takes a context has been named with Context as a suffix, rather than as a prefix. For example, signal.Notify was augmented as signal.NotifyContext to support the additional context argument. Therefore I'd suggest naming the interface methods ReadContext and WriteContext, and (continuing the previous point) the functions io.ReadContext and io.WriteContext.

Yeah, that makes sense. I originally deviated from the "context suffix" naming convention because my first concept put it in io and my choices (when observing the "-er" interface naming convention) were between:
type ContextReader interface {
    Reader
    ContextRead(ctx context.Context, p []byte) (n int, err error)
}

or
type ReadContexter interface {
    Reader
    ReadContext(ctx context.Context, p []byte) (n int, err error)
}

If the interfaces are defined as context.Reader/context.Writer, that concern is no longer relevant.

A problem with io.ReaderFrom and WriterTo is there is no way to compose the objects that wrap something that may or may not have the method. context.Reader/Writer should preempt this mistake by using errors.ErrUnsupported.
func Read(ctx Context, r io.Reader, p []byte) (n int, err error) {
	if r, ok := r.(Reader); ok {
		n, err := r.ContextRead(ctx, p)
		if err != errors.ErrUnsupported {
		    return n, err
		} // else fallthrough
	}
	if err := Cause(ctx); err != nil {
		return 0, err
	}
	return r.Read(p)
}

@earthboundkid I'm not sure I understand how that problem would apply here? If a context.Reader wraps an io.Reader, wouldn't you get the most intuitive result by having the wrapper invoke context.Read on the io.Reader?
For example:
type InverseByteReader struct {
    r io.Reader
}

func (ibr *InverseByteReader) ReadContext(ctx context.Context, p []byte) (int, error) {
    n, err := context.Read(ctx, ibr.r, p)
    if err != nil {
        return n, err
    }
    for i, b := range p[:n] {
        p[i] = b^0b11111111
    }
    return n, err
}


Concatenating files doesn't produce a URL-encoded CDN address

I'm using Express CDN with the SWIG templating engine, but I don't think that is impacting my result here.
When I concatenate files based on the documentation, I am getting a properly concatenated file that is uploaded to S3. That part works fine. It is given an object name on S3 of something like "file1+file2+file3.js".
When it inserts the new fully-formed script tag into the HTML, it is providing a URL matching this exact string (".../file1+file2+file3.js"). However, S3 is rejecting this request as denied, because S3 expects the request to be URL encoded. The examples in the documentation even indicate that the resulting URL should be something like "https://cdn.your-site.com/plugins%2Bscript.1341382571.js", with the "+" encoded to "%2B".
What am I missing here?
In the meantime, I am writing a custom filter for SWIG that will do the URL encoding that is needed, after the fact.

For anyone that stumbles across this, here's the custom SWIG filter I wrote:
swig.setFilter("url_encode_tag", function(tag){
    var hrefRegex = /href=["'](http.*cloudfront.net\/)(.*?)(\?.*?)["']/i;
    var srcRegex = /src=["'](http.*cloudfront.net\/)(.*?)(\?.*?)["']/i;

    if(tag.indexOf("src") >= 0)
    {
        var root = tag.match(srcRegex)[1];
        var src = tag.match(srcRegex)[2];
        var tail = tag.match(srcRegex)[3];
        var encoded = encodeURIComponent(src);
        tag = tag.replace(srcRegex, "src='" + root + encoded + tail + "'");
    }
    else if(tag.indexOf("href") >= 0)
    {
        var root = tag.match(hrefRegex)[1];
        var href = tag.match(hrefRegex)[2];
        var tail = tag.match(hrefRegex)[3];
        var encoded = encodeURIComponent(href);
        tag = tag.replace(hrefRegex, "href='" + root + encoded + tail + "'");
    }

    return tag;
});

Use it like this:
{{ CDN(['/css/first.css',
                '/css/second.css',
                '/css/third.css',
                '/css/fourth.css'])|url_encode_tag }}

released in v0.3.1, sorry didn't see this till now 😞
npm install express-cdn@latest or yarn add express-cdn@latest


docs: Improve RedeliverUnacknowledgedMessages binary protocol docs

Motivation
This updates the binary protocol documentation to mention the varying
behavior of RedeliverUnacknowledgedMessages, depending on the
subscription type.
An unrelated typo and whitespace fixes are also included.
Closes apache/incubator-pulsar#2003
Principal Change
- The protobuf object accepts a list of message ids that the consumer
- wants to be redelivered. If the list is empty, the broker will redeliver
- all the pending messages.
+ The protobuf object accepts a list of message ids that the consumer
+ wants to be redelivered. The message ids will be honored by the broker
+ only if the subscription type is shared. For other subscription types or if
+ the list is empty, the broker will redeliver all the pending messages.

Great contribution! Thank you @awilliams


Setting scale and precision for MySQL float column

I believe I've found an undocumented way to correctly set the float(scale,precision) column type for MySQL using Phinx, but before I make a PR to add it to the documentation, I figured I'd better ask here if this is intended correct behavior, or lucky happenstance.
Example
I have a column with definition float(3,2) and I need to expand it to be float(4,2).
The following appears to work, but is undocumented in both the Phinx and CakePHP documentation.
public function up(): void
{
    $this->table('my_table')
        ->changeColumn('my_column', 'float', ['scale' => 2, 'precision' => 4])
        ->save();
}

Refs open https://github.com/cakephp/migrations/issues/314

Also note that as of MySQL 8.0.17, the nonstandard FLOAT(M,D) and DOUBLE(M,D) syntax is deprecated and you should expect support for it to be removed in a future version of MySQL.
Depending on usage, you should use DECIMAL(M,D) to store exact numeric data values when it is important to preserve exact precision, for example with monetary data.
If you need store approximate numeric data values, use FLOAT without precision and format number to necessary precision in application code instead.

Postgres is actually already failing on this:
LINE 1: ... "sort" INTEGER NOT NULL  DEFAULT '0', "lat" REAL (10) NULL,...

So, yeah, scale and precision should be omitted for float, or decimal should be used.
We should probably clarify in docs.


Apply some changes suggested by golint

Not changed:
$ golint ./...
bucket.go:77:25: exported method Root returns unexported type bolt.pgid, which can be annoying to use
page.go:138:1: receiver name a should be consistent with previous receiver name s for pgids
cmd/bolt/main.go:1354:41: exported func ReadPage returns unexported type *main.page, which can be annoying to use

I think the bucket.Root() method should probably have a different signature, but it was added over a year ago and I wonder how many people we'd be breaking. It's not used in the current code base.
The receiver name in page.go:138:1 seems just fine in its context, and cmd/bolt/main.go:1354:41 is not a big deal as cmd/bolt is not meant to be imported (but we could make functions there unexported anyway if wanted).
I'm also not changing tests and benchmark function names that have underscores, but we could as well.
Looking forward for some feedback on these changes :smile:

Closing due to age.


Cameras overlap the hotbar

This should mostly speak for itself. Using the latest Foundry v9 version. This only happens with Minimal UI turned on.

Fixed. Thanks @dhorkin
I hope Foundry stops changing style names between minor updates.