Func (s * Server) Publish (topic string, payload [] byte, retain bool) error method Is the v2 version not available?

Func (s * Server) Publish (topic string, payload [] byte, retain bool) error method Is the v2 version not available?

Hi @morebuff! I can see how this would be useful. Restored as a convenience function with new signature Publish(topic string, payload []byte, retain bool, qos byte) error in v2.0.4 :)


Push-Namespace not listed in FunctionsToExport in the PSD

The current version of the PSD lists the following:
FunctionsToExport = @(
    'Format-Checklist',
    'Format-Verbose',
    'Invoke-Requirement',
    'New-Requirement',
    'Set-Requirement',
    'Test-Requirement'
)

Note, Push-Namespace is not listed and thus not available when module is imported to a PS session.
Unless this is currently intentional, recommend updating the PSD to the following so Push-Namespace is provided:
FunctionsToExport = @(
    'Format-Checklist',
    'Format-Verbose',
    'Invoke-Requirement',
    'New-Requirement',
    'Set-Requirement',
    'Test-Requirement',
    'Push-Namespace'
)

Thanks for reporting!

Thanks for resolving it!
Sent from my iPhone

On Nov 20, 2019, at 11:18, Chris Kuech<EMAIL_ADDRESS>wrote:

Thanks for reporting!
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.


Better support for tags

Tag assignment through AWS occurs many ways.  Some tags need to be formatted differently, some can only be uploaded through the client, the 'Name' tag is special, etc.
Lets introduce an aws_taggable module that can be applied to a resource.  This will introduce hook methods for reading tags, formatting them, updating them and deleting them.  Then the AwsProvider can leverage this logic and individual resources can overwrite the hooks.
We should also see if we can clean up the tagging duplication in the driver.rb

When this is done we could add back tags that were removed in https://github.com/chef/chef-provisioning-aws/pull/276


Run scenarios at 22:00

Introduction
Currently the scenarios run at 02:00. This means that often not all scenarios have finished when people start working.
Solution
Start the scenarios at 22:00 instead of 02:00.

This is possible as long as we do not test against nightly builds (which haven't been built by 22:00h).

Moving the bf scenarios to SP1 would be another option

Set the nightlies to run at 22:00, as opposed to 01:45.


venv environments are not detected until folder is opened

Environment data

VS Code version: 1.80.1 (User Setup)
Jupyter Extension version (available under the Extensions sidebar): v2023.6.1101941928
Python Extension version (available under the Extensions sidebar): v2023.12.0
OS (Windows | Mac | Linux distro) and version: Windows 10, V10.0.19045 Build 19045
Python and/or Anaconda version: 3.11.4
Type of virtual environment used (N/A | venv | virtualenv | conda | ...): venv
Jupyter server running: Local

Expected behaviour
Environments in the same folder are detected under select kernels
Actual behaviour
Only the system interpreter is detected
Steps to reproduce:
[NOTE: Self-contained, minimal reproducing code samples are extremely helpful and will expedite addressing your issue]

Create an ipynb file with some code in a folder and initialize a venv in the same.
Try to open that file without opening the folder from your explorer.

Output for Jupyter in the Output panel (View→Output, change the drop-down the upper-right of the Output panel to Jupyter)

Please provide the debug logs which can help diagnose the issue:

Run Developer: Set log level command

Select Python -> Select Trace

Run Developer: Reload Window command

Provide the output:

Output for Python in the Output panel (View→Output, change the drop-down the upper-right of the Output panel to Python)

XXX

note that the company name has been changed due to privacy reasons along with some other minor edits
log.txt

Does venv environments show up when using Python: Select Interpreter command?

Thanks for the bug report! We investigate issues in order based on priority and severity, which includes the impact it has on your ability to use the extension to do productive work, and the number of people affected. If other users come forward and leave a comment demonstrating they are seeing/reproducing the problem then we will raise this issue's priority. Thanks for understanding and the patience!

Does venv environments show up when using Python: Select Interpreter command?

As mentioned previously, no it does not

Also this issue may also be related to [(https://github.com/microsoft/vscode-python/discussions/21633)] although I'm not a 100% sure on that

Try to open that file without opening the folder from your explorer.

It seems to be that no workspace folder is opened, is that the case?

Yeah

You need a workspace folder to be opened for workspace specific environments to be discovered. There is no way for us to know which project to look for environments in otherwise.

Try 'File-> Open folder...' option

Closing as this seems to be the intended behavior.

Try 'File-> Open folder...' option

You need a workspace folder to be opened for workspace specific environments to be discovered. There is no way for us to know which project to look for environments in otherwise.

So is it intended that environments that are present in such folders do not show up?

Since it kind of limits functionality so i thought it'd at least look in the same folder as the opened file


use ::bind instead of bind

While building glvis-js I get the following error:
general/isockstream.cpp:92:50: error: invalid operands to binary expression ('__bind<int &, sockaddr *&, unsigned int &>' and 'int')
   92 |       if (bind(sfd, rp->ai_addr, rp->ai_addrlen) < 0)
      |           ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^ ~

I believe this is because we have use namespace std at the top, which means it is trying to use std::bind instead of bind. The fix is just to replace instances of bind() with ::bind() to make sure it uses the intended function. This fixes this compilation error, for me.

PR
Author
Editor
Reviewers
Assignment
Approval
Merge

#4453
@justinlaughlin
@tzanio
@tzanio + @najlkin
8/21/24
8/25/24
⌛due 9/11/24

PR Checklist

[ ] Code builds.
[ ] Code passes make style.
[ ] Update CHANGELOG:

[ ] Is this a new feature users need to be aware of? New or updated example or miniapp?
[ ] Does it make sense to create a new section in the CHANGELOG to group with other related features?

[ ] Update INSTALL:

[ ] Had a new optional library been added? If so, what range of versions of this library are required? (Make sure the external library is compatible with our BSD license, e.g. it is not licensed under GPL!)
[ ] Have the version ranges for any required or optional libraries changed?
[ ] Does make or cmake have a new target?
[ ] Did the requirements or the installation process change? (rare)

[ ] Update continuous integration server configurations if necessary (e.g. with new version requirements for each of MFEM's dependencies)

[ ] .github
[ ] .appveyor.yml

[ ] Update .gitignore:

[ ] Check if make distclean; git status shows any files that were generated from the source by the project (not an IDE) but we don't want to track in the repository.
[ ] Add new patterns (just for the new files above) and re-run the above test.

[ ] New examples:

[ ] All sample runs at the top of the example source file work.
[ ] Update examples/makefile:

[ ] Add the example code to the appropriate SEQ_EXAMPLES and PAR_EXAMPLES variables.
[ ] Add any files generated by it to the clean target.
[ ] Add the example binary and any files generated by it to the top-level .gitignore file.

[ ] Update examples/CMakeLists.txt:

[ ] Add the example code to the ALL_EXE_SRCS variable.
[ ] Make sure THIS_TEST_OPTIONS is set correctly for the new example.

[ ] List the new example in doc/CodeDocumentation.dox.
[ ] If new examples directory (e.g.examples/pumi), list it in doc/CodeDocumentation.conf.in
[ ] Companion pull request for documentation in mfem/web repo:

[ ] Update or add example-specific documentation, see e.g. the src/examples.md.
[ ] Add the description, labels and screenshots in src/examples.md and src/img.
[ ] In examples.md, list the example under the appropriate categories, add new categories if necessary.
[ ] Add a short description of the example in the "Extensive Examples" section of features.md.

[ ] New miniapps:

[ ] All sample runs at the top of the miniapp source file work.
[ ] Update top-level makefile and makefile in corresponding miniapp directory.
[ ] Add the miniapp binary and any files generated by it to the top-level .gitignore file.
[ ] Update CMake build system:

[ ] Update the CMakeLists.txt file in the miniapps directory, if the new miniapp is in a new directory.
[ ] Add/update the CMakeLists.txt file in the new miniapp directory.
[ ] Consider adding a new test for the new miniapp.

[ ] List the new miniapp in doc/CodeDocumentation.dox
[ ] If new miniapps directory (e.g.miniapps/nurbs), add it to MINIAPP_SUBDIRS in the makefile.
[ ] If new miniapps directory (e.g.miniapps/nurbs), list it in doc/CodeDocumentation.conf.in
[ ] Companion pull request for documentation in mfem/web repo:

[ ] Update or add miniapp-specific documentation, see e.g. the src/meshing.md and src/electromagnetics.md files.
[ ] Add the description, labels and screenshots in src/examples.md and src/img.
[ ] The miniapps go at the end of the page, and are usually listed only under a specific "Application (PDE)" category.
[ ] Add a short description of the miniapp in the "Extensive Examples" section of features.md.

[ ] New capability:

[ ] All new public, protected, and private classes, methods, data members, and functions have full Doxygen-style documentation in source comments. Documentation should include descriptions of member data, function arguments and return values, template parameters, and prerequisites for calling new functions.
[ ] Pointer arguments and return values must specify whether ownership is being transferred or lent with the call.
[ ] Any new functions should include descriptions of their intended use e.g. for internal use only, user-facing, etc., along with references to example code whenever possible/appropriate.
[ ] Consider adding new sample runs in existing examples to highlight the new capability.
[ ] Consider saving cool simulation pictures with the new capability in the Confluence gallery (LLNL only) or submitting them, via pull request, to the gallery section of the mfem/web repo.
[ ] If this is a major new feature, consider mentioning it in the short summary inside README (rare).
[ ] List major new classes in doc/CodeDocumentation.dox (rare).

[ ] Update this checklist, if the new pull request affects it.
[ ] Run make unittest to make sure all unit tests pass.
[ ] Run the tests in tests/scripts.
[ ] (LLNL only) After merging:

[ ] Update internal tests to include the new features.

I wonder why it was not a problem before? 🤔 Has something changed? I do not see anything like that...

std::bind() takes a function as the first argument/template parameter, so I do not understand how int can be recognized as a candidate 🤪 .

In any case, I think the right thing to do is to remove using namespace std from isockstream.cpp. It is a bad practice and its uses are minimized in MFEM. There are just a few std::endl and one std::istringstream 😉 .

I wonder why it was not a problem before? 🤔 Has something changed? I do not see anything like that...

I can compile if I use an older version of emscripten (probably related to this static linking issue?). I still think this is worth making explicit - I agree that removing using namespace std is the proper way 👍

Just to confirm: both the regular and JS build of GLVis work with this change?

This PR is now under review (see the table in the PR description). To help with the review process, please do not force push to the branch.

Just to confirm: both the regular and JS build of GLVis work with this change?

Using an older version of emscripten is sufficient for building

Merged in next for testing...


[pcre] Export cmake targets

Export cmake targets for pcre
Related to https://github.com/microsoft/vcpkg/pull/10326#discussion_r483215122

Thanks for your contribution!


Mozilla Learn + SOO Kenya + CC transition brainstorm session

arrange with Michelle, Simeon
see: https://mozilla.github.io/webmaker-curriculum/

pull in P2PU, CC network

Session held, notes here: https://docs.google.com/document/d/1azQAubD__19lz6K0hL_4k3Zg2s76wBUbdQdVkRmmH88/edit
Simeon to draft call and key elements for temp splash page for website in next two weeks, work with Jane to get it up and running.


Option to add caption

I saw there's a way of adding the alt value into the options, is there also a way to include captions?

It's not supported. Sorry.


Support path_length(), vertices(), edges()

Instead of only supporting element_id(p) which returns rowids, we could extend the functionality to also support the following functions:
Namings are not final

path_length() returns the path length
vertices() returns the rowids of all vertices (under the hood it would be list_slice(1, len(list), 2))
edges() returns the rowids of all edges (under the hood it would be list_slice(2, len(list), 2))

Implemented as of https://github.com/cwida/duckpgq-extension/pull/69


Rename variable.

https://github.com/DarkFlorist/PetalLock/blob/7a9697593bc929f7902ee81928b975517cd92866/solidity/contracts/PetalLock.sol#L6
Recommend renaming to ENS_NAME_WRAPPER to match public docs and contract name on EtherScan and elsewhere.

Also here: https://github.com/DarkFlorist/PetalLock/blob/7a9697593bc929f7902ee81928b975517cd92866/solidity/contracts/PetalLock.sol#L59C1-L59C81

Also here: https://github.com/DarkFlorist/PetalLock/blob/7a9697593bc929f7902ee81928b975517cd92866/solidity/contracts/OpenRenewalManager.sol#L27

Also the text in the error messages (ENS tokens => ENS Names):
https://github.com/DarkFlorist/PetalLock/blob/7a9697593bc929f7902ee81928b975517cd92866/solidity/contracts/OpenRenewalManager.sol#L38
https://github.com/DarkFlorist/PetalLock/blob/7a9697593bc929f7902ee81928b975517cd92866/solidity/contracts/OpenRenewalManager.sol#L44

Another error message that should be changed:
https://github.com/DarkFlorist/PetalLock/blob/7a9697593bc929f7902ee81928b975517cd92866/solidity/contracts/PetalLock.sol#L193


Python libraries licenses are not gathered

What happened:
syft shows python packages, but doesn't collect licenses.
What you expected to happen:
I want to see licenses for packages
Steps to reproduce the issue:
I run
anchore_syft packages . -o cyclonedx-xml=bom.xml
Anything else we need to know?:
unsure
Environment:

Output of syft version:

Application:        syft
Version:            0.76.0
JsonSchemaVersion:  7.0.1
BuildDate:          2023-03-31T15:11:44Z
GitCommit:          dfcc07e5122217ca9e2fc75817c593356fc0c405
GitDescription:     v0.76.0
Platform:           linux/amd64
GoVersion:          go1.19.7
Compiler:           gc

OS (e.g: cat /etc/os-release or similar):

PRETTY_NAME="Ubuntu 22.04.4 LTS"
NAME="Ubuntu"
VERSION_ID="22.04"
VERSION="22.04.4 LTS (Jammy Jellyfish)"
VERSION_CODENAME=jammy
ID=ubuntu
ID_LIKE=debian
HOME_URL="https://www.ubuntu.com/"
SUPPORT_URL="https://help.ubuntu.com/"
BUG_REPORT_URL="https://bugs.launchpad.net/ubuntu/"
PRIVACY_POLICY_URL="https://www.ubuntu.com/legal/terms-and-policies/privacy-policy"
UBUNTU_CODENAME=jammy

Hi @templier2, what type of python packages are you scanning? It looks like today Syft is only able to find licenses from wheel/egg files, and perhaps the license information isn't present in other packaging formats? Could you provide a reproducible case, such as a public docker image we could look at to help understand what's there and let us know what you expect?

Hi @templier2, what type of python packages are you scanning? It looks like today Syft is only able to find licenses from wheel/egg files, and perhaps the license information isn't present in other packaging formats? Could you provide a reproducible case, such as a public docker image we could look at to help understand what's there and let us know what you expect?

Hi,
It is a list of libraries from requirements.txt, I suppose that every library has appropriate information about the license at pypi.org (i.e. https://pypi.org/project/rdflib/)
databricks-connect==14.3.2
rdflib==7.0.0
SPARQLWrapper==2.0.0
azure-search-documents==11.4.0
pyspark==3.5.1
lxml==5.2.2

Ahh I see, so that is being scanned is purely the source code directory (finding the requirements.txt?) and not against installed packages.

I'm going to recategorize this is a feature request, since it sounds like what you're asking for is for syft to be able to remotely gather information about the package declared locally against package registries and enrich the SBOM. Is this accurate @templier2 ?

I'm going to recategorize this is a feature request, since it sounds like what you're asking for is for syft to be able to remotely gather information about the package declared locally against package registries and enrich the SBOM. Is this accurate @templier2 ?

Yes, but it seems that your option with installing it within a venv environment is ok for us too.
Thank you.


Fix hashing issues for messages/groups in arrays.

The original code here landed in f9972067d75361cd37e02723c5ec076c30da077a,
but because of SR-7993 and not having yet landed a Package.swift that
enabled 4.2 support, we weren't hitting this code yet.
Since the visitor api uses Message, it doesn't know they messages are
Hashable, the maps work because they get more complete type info to
pick up the conformance declared on the Base used by for generated
messages.
So...
Going back to manually mixing in the for Arrays, adding a Todo
to revisit this. But this gets master back to working if someone
tries to pull the code into a compiling context that is 4.2+.

I plan on revisiting this with hash(into:) but this is just to fix what was landed in a broken state, but I didn't realized it because of the SwiftPM issue.


Example using maturin publish or maturin upload with a pypi token

Currently, all examples use twine for the pypi upload instead of maturin publish. It would be cool to have an example with maturin publish or maturin upload that uses a pypi token similar to https://github.com/entity-neural-network/ragged-buffer/blob/78657b4603d8dc9680e3d166064f73b289aa2ac1/.github/workflows/publish-wheel.yaml#L52-L59

👍
We should also update the maturin new's template to use it too: https://github.com/PyO3/maturin/blob/fa66292d3c2a29389bbfa24c54820db5b5d4a5c8/src/templates/CI.yml.j2#L63-L69

An example is modified to use maturin: https://github.com/messense/rjmespath-py/blob/59ba98e1d0e366681713290f70f2db705bb31d79/.github/workflows/CI.yml#L159-L165


How to use JSDoc syntax with JS/TS

I apologize for my ignorance in advance. I'm not up-to-snuff on how tree-sitter works and am struggling a bit with my Googling/reading to find a solution.
I can't seem to get JSDoc highlighting with tree-sitter in Emacs. The debugger just says the whole block is a comment:. I have tree-sitter-languages installed. I tried adding jsdoc to typescript mode in the languages alist and it broke tree-sitter for TS entirely.
I'm sure this might be some sort of configuration problem. Any insight would be appreciated.

elisp-tree-sitter doesn't support multi-language buffers at the moment, so JSDoc fragments inside JS/TS are not recognized, since it's a separate jsdoc grammar.


Ability to show address of contract before deployment

For development purposes of identity proxy contracts we need to know the address of a given smart contract before it is deployed on the network. Also the ability for counterfactual deploy will be useful.

Any updates on this?


Identity: log unauthorized context

Coverage: 82.623% (-0.03%) from 82.65% when pulling a1756a15c48a38231538ca9ad0ce745885d6d80a on dissoupov into 22ddbb5d73d4b67816c6336deed331267151df99 on main.


Add .codeclimate.yml

Added .codeclimate.yml to stop Code climate from tracking tests, ZeroBin scripts and vendor scripts.

Thanks for the PR! I am going to merge this, but I hope either you or @opg7371 will make another pull request with a more complete exclusion list.


Include kernel upgrade and reboot of compute nodes

This combines the QEMU 2.0 backport from the Ubuntu cloud archive and kernel upgrade into to a single maintenance window.

These changes look good.

Update qemu-kvm packages has been released into Ubuntu cloud archive: http://ubuntu-cloud.archive.canonical.com/ubuntu/pool/main/q/qemu/

Closing this, the branch this is targeting is a closed PR as well.


Compatibility with two systems with different Python versions

Good afternoon,
I want to control two robots through the same computer, in which the computer and one of the robots have ROS Noetic installed, which uses Python3, and the other robot uses ROS Kinetic, which uses Python2. Since the Python grpcio library is used in your framework, which version should be used to make it compatible with all devices? The messages are compatible with Python2 and Python3?
Thanks
Best Regards

Hi,
grpc library is only used for communication between the daemon and the Node Manager. I can't say anything directly about the compatibility of the grpc libraries. I'm afraid you'll have to try it out.
The messages for synchronisation (master_discovery and master_sync) have not changed, so it should work.
However, the corresponding ROS topic must also be compatible.
regards


primary vs secondary db connection

the pg cluster has three nodes: 1 master, 2 replicas. the replicas are exposed separately from the master, however, replication might be delayed. how much replication delay can we tolerate? can we connect the worker to the master and the api to the replicas so that we can scale better?

The icon block time is 2 seconds, the delay needs to be less than that in order for the replicas to catch up.
Sub 1 second will be ideal if we separate the API and worker db connections


Added Geode mods topic

Please confirm this pull request meets the following requirements:

[x] I followed the contributing guidelines: https://github.com/github/explore/blob/main/CONTRIBUTING.md.
[x] I have no affiliation with the project I am suggesting (as a maintainer, creator, contractor, or employee).

Which change are you proposing?

[ ] Suggesting edits to an existing topic or collection
[x] Curating a new topic or collection
[ ] Something that does not neatly fit into the binary options above

Editing an existing topic or collection
I'm suggesting these edits to an existing topic or collection:

[ ] Image (and my file is *.png, square, dimensions 288x288, size <= 75 kB)
[ ] Content (and my changes are in index.md)

Please replace this line with an explanation of why you think these changes should be made.

Curating a new topic or collection

[x] I've formatted my changes as a new folder directory, named for the topic or collection as it appears in the URL on GitHub (e.g. https://github.com/topics/[NAME] or https://github.com/collections/[NAME])
[x] My folder contains a *.png image (if applicable) and index.md
[x] All required fields in my index.md conform to the Style Guide and API docs: https://github.com/github/explore/tree/main/docs

Geode has as of late become a huge part of the GD community, so of course, people have been uploading Geode mods to GitHub as a way to get them out to people. But I've noticed this stupid apache geode thing overshadowing the entire Geode topic, so I thought it would be cool to make one specific to the GD mod loader so that people could more easily get the mods to more people

Something that does not neatly fit into the binary options above

[ ] My suggested edits are not about an existing topic or collection, or at least not a single one
[ ] My suggested edits are not about curating a new topic or collection, or at least not a single one
[ ] My suggested edits conform to the Style Guide and API docs: https://github.com/github/explore/tree/main/docs

Please replace this line with an explanation of your proposed changes.

Please note: we will close your PR without comment if you do not check the boxes above and provide ALL requested information.

 Thanks for the new topic.

lol no problem


Changing assignee while transistioning not possible

There is an error in your api/issue.js line 1099.
I'm trying to use https://docs.atlassian.com/jira/REST/server/#api/2/issue-doTransition and assign a new person to the issue while I transicion it.
According to the doc I have to send the fields like this:
 params.fields = {                 assignee:{                     name: person                 }             }
params.fields.forEach is not a function in that case though.

Not sure if I get this but as per Jira documentation during a transition only certain fields can be set

If a field is not configured to appear on the transition screen, then it will not be in the transition metadata, and a field validation error will occur if it is submitted.

I see it in the aforementioned example but I don't see the assignee one as able to be set in a transition in a Jira I work on. You can check them as in the documentation /rest/api/2/issue/{issueIdOrKey}/transitions?expand=transitions.fields
I can, for instance, set another value present in a transition screen using something like
var transition = {
        'fields': {
            'customfield_10320': { name: 'Release Manager' },
        },
        'transition': '11',
    };

 jira.issue.transitionIssue({issueId: myIssue.id, transition}, function (statusUpdate) {...


CFFL

CFFL

Linter check found the following problems:
The following problems have been found:
ERROR: /tmp/abs_d5564ppsw6/clone/recipe/meta.yaml:25: missing_wheel: For pypi packages, wheel should be present in the host section
ERROR: /tmp/abs_d5564ppsw6/clone/recipe/meta.yaml:25: host_section_needs_exact_pinnings: Packages in host must have exact version pinnings, except python build tools.
ERROR: /tmp/abs_d5564ppsw6/clone/recipe/meta.yaml:31: missing_pip_check: For pypi packages, pip check should be present in the test commands
ERROR: /tmp/abs_d5564ppsw6/clone/recipe/meta.yaml:35: incorrect_license: The recipe's about/license key is not an SPDX compliant license or license exception, closest match: 0BSD
WARNING: /tmp/abs_d5564ppsw6/clone/recipe/meta.yaml:37: missing_description: The recipe is missing a description
ERROR: /tmp/abs_d5564ppsw6/clone/recipe/meta.yaml:37: missing_dev_url: The recipe is missing a dev_url
ERROR: /tmp/abs_d5564ppsw6/clone/recipe/meta.yaml:37: missing_documentation: The recipe is missing a doc_url or doc_source_url
ERROR: /tmp/abs_d5564ppsw6/clone/recipe/meta.yaml:37: missing_license_family: The recipe is missing the about/license_family key.
Errors were found


How to resolve name clashes of collections?

In particular, List and Stream have name conflicts with their java.util and java.util.stream counterparts. An attempt to prefix a 'J' resulted in a name conflict with javax.swing.{JList}.
How to name things is relatively opinionated. From the technical perspective name clashes are distracting.
How about prefixing an underscore '_', i.e. _List and _Stream? I like that. They are no AList, BList, ..., ZList etc. This looks ugly. Also lower case chars aList, bList, ..., zList are not Java conform. '$' has another meaning and is internally used in conjunction with inner classes.
Personally I use underscore to solve naming conflicts. I.e. my Reddit name is '_danieldietrich' and the Twitter account of this projects is named '_Javaslang' because of name clashes. Underscore does not get in the way while reading, it has no meaning, like other characters.
Also consistency is a point. There are many collection types without name clashes, i.e. Tree, BinaryTree, RoseTree, Seq, ... Do we need to prefix them also to be consistent?
Note: There are also upcoming _Set and _Map.

I personally don't mind the clashes. I like Scala's import renaming but I don't mind using FQN in Java when needed.
Here is another solution: add _Name as an alias of Name, e.g.:
package javaslang.list;
public class List {
...
}

package javaslang.list;
public class _List extends javaslang.List {}

This way people can import the _Name if they prefer it.

Great idea! Have to think about providing aliases. Most collections are interfaces with static factory methods to get concrete instances. Static interface methods are not inherited.
I agree, FQN are arguable. Javaslang collections play well together with the Iterable interface, this can also be used instead of the specific class names.
Here is a (currently broken) example of bundling aliases per package. Here an experimental alias interface is used, starting with a lower case. This could be seen as a kind of module which is both, a class and a package.
package javaslang.collection;

interface alias {
    interface _List<T> extends List<T> {
        // duplicate all static List methods here
        static <T> _List of(T... elements) {
            // BROKEN: Need a _List instead of a List
            return List.of(elements);
        }
    }
    interface _Stream<T> extends Stream<T> {
        // duplicate all static Stream methods here
    }
}

Usage:
import javaslang.collection.alias.*;

// ...

_List.of(1, 2, 3);

...thinking of an alias generator which follows the scheme mentioned above. Alias modules containg _Original interfaces can be theoretically generated automatically using reflection with overridden methods _Original method(args) where necessary (modulo generics?). Proxy will do the rest?

I am the reddit commentor who objected to the name clashes.  Big fan of the library, looking forward to trying it!  I have lots of List and Stream in my code, and I didn't like that there would be ambiguity about which List and Stream.
As I was looking at this, I just realized that the gui toolkit that I use (SWT) has a "List" class, but it's used so differently from a java.lang.List that I don't ever recall any confusion.  On the other hand, that toolkit also has a "Color" class, and I frequently have 10 seconds of confusion as I realize my IDE grabbed the Swing/AWT Color instead of the SWT Color, because they are harder to distinguish in context.
In your case, your Stream and List will be used similarly to the java.lang versions, so it seems like a name change might be worthwhile. I would have guessed that the prefix for your library would be "S" for Slang, or possibly "F" for functional, but I see "J" as defacto the JDK's prefix.
Having aliases seems to violate the "simplest possible solution".  IMO, library version numbers are arbitrary, and there's nothing wrong with bumping a major version to indicate a name change.  A lot of libraries seem to spend a lot of time in 0.x, and don't want to go to 1.x or 2.x unless there's some major redesign.  I think library version numbers are most valuable if they are used exclusively and ruthlessly as semantic indicators.
I recently encountered almost the same problem in an open source library that I maintain, here was my reasoning, FWIW. (aside: the class referenced in this commit is in serious risk of being deprecated for your excellent Try class :)

Hey! Of course you're right - we search the simplest solution possible, there will be no aliases using reflection voodoo magic proxy mechanisms lingering around in Javaslang :-)
The control package is fixed, so are the collections. The only experimental feature is the match API. With #227 it will be also fixed in the next release, too. I should have been started with a 0.x version but now we are at 1.x and can't move back. I think this is ok. The monadic types and collections are already battle-hardened. I do not expect much API movement.
Back to your question, I'm still not convinced prefixing the collections. Mostly because the Java collections are outdated IMO. New code should not rely on them any more. Javaslang's collections are replacements and not considered as alternatives. I'm aware of the fact that java util collections will be among us for many years, maybe the rest of our lives, but my vision is to go to the next level. I think this is the Slang part of Javaslang :-)

There are 3 groups you can optimize your library for:
A) People who are already using Javaslang
B) People who are starting a brand new project, and want to jettison java.lang.List, and any library that uses java.lang.List
For these people, it is better if you don't change the names.
C) People who are developing and improving an existing project, or starting a brand new project that will need libraries that use java.lang.List
For these people, it is easier to adopt your project if you do change names.
You are in groups A and B, and probably so are most of the people you talk to about your project.  But of all the programmers out there who might use your project, the vast majority are in group C.
Guava has ~1,000 libraries in MavenCentral that depend on it, and has java.lang.List all over its API.
Javaslang has 0 libraries in MavenCentral that depend on it, which means you can still change API without breaking things for 1000's of people.
I would consider my company to be an "early-ish adopter" of functional programming, but we've gotta keep shipping a new version to our real-life users every couple weeks, and they don't care about functional programming (or even programming at all, really).  There's no way I could budget a "stop the world" and replace all of our List.  And even if I did, I definitely couldn't rewrite all of our dependencies so that they don't use java.lang.List either (including transitive dependencies, we have literally 100's).
When Java 8 came out, we were able to incrementally add lambdas and a functional-style to our code, updating as we went, and it never caused any confusion.  Giant projects like Eclipse are starting to undertake the same effort.  If we wanted to adopt the advantages of Javaslang, it would be quite confusing when our project gradually reached the state that half of our "List" weren't actually "java.lang.List", especially for a new team member.
I think it's great that you're rejecting the problems with List and Stream, and creating the kernel of a newer, cleaner java.  But I think you'll have more users if you optimize for gradual adoption, rather than optimizing for clean-slates.
But of course, it is your project, and a great one at that, so I look forward to using it in some capacity regardless of your decision :)

Yes, I know what you are talking about :-) At $work we have a legacy Java system with gigabytes of transitive dependencies. Our vendor started development in the 90s. A big amount of classes is still not typed with generics - it's a nightmare.
Here is a List of possibilities to name things:
// import javaslang.collection.List;
List<T> compute(List<T> input) {
    // this is the preferred way - use Javaslang collections!
    return List.of(input).filter(...).map(...);
}

// import javaslang.collection.List;
java.util.List<T> compute(java.util.List<T> input) {
    // this is the preferred way to interoperate with Java
    return List.of(input).filter(...).map(...).toJavaList();
}

// import java.util.List;
List<T> compute(List<T> input) {
    // too long package name
    return javaslang.collection.List.of(input).filter(...).map(...).toJavaList();
}

// import java.util.List;
// import javaslang.collection._List;
List<T> compute(List<T> input) {
    // ugly prefix
    return _List.of(input).filter(...).map(...).toJavaList();
}

// import java.util.List;
// import javaslang.collection.SList;
List<T> compute(List<T> input) {
    // Aaahhhrg! HList would be a SHList
    return SList.of(input).filter(...).map(...).toJavaList();
}

_ is currently the only prefix that does not make me jump out of the window but it is ugly though. I will stick with List.

So...
classes in javaslang.collection are not intended to be used as java.util.stream.Stream++.
It is highly recommended to design programs or new parts of programs from the ground up to use immutable data structures. It is recommended to fully qualify java util collections, if used with javaslang collections side-by-side.
When things should change we need to change s.th. otherwise nothing will change.

Sounds good!  JavaSlang has lots of great ideas, I'm sure it will be successful no matter how you call them :)
In case you ever revisit this, here is an example of using prefixing to allow easy interoperability, and here are more detailed thoughts on optimizing for conservative users versus the ones you already have.

Thx!


some easy doc fixes

Update readme to use docs on kubescape.io; change some governance wording from heblish.
Signed-off-by: Craig Box<EMAIL_ADDRESS>

@craigbox can you remove the git2go submodule from your PR, as we no longer need it

@craigbox please update this PR

done


[vcpkg-tool] Tool sometimes segfaults in manifest mode

Describe the bug
On rare occasions vcpkg-tool will crash during a CMake configure. It crashes right after calculatng the installation plan in popen syscall, from what I can tell this is where it tries to restore packages from cache.
Environment

OS: macOS 12.0.1
Compiler: AppleClang 13.0

To Reproduce
Steps to reproduce the behavior:

Create a vcpkg.json
Create a CMake project that uses manifest mode
Start configure
See error

Expected behavior
vcpkg-tool should not crash
I've attached a crash log, it crashes in Thread 46 which does not really seem to start, it doesn't get to the posix_spawn_file_actions_addclose like the other threads. My gut feeling tells me that it's because one of the input arguments is bogus and it's trying to read invalid memory because of it.
vcpkg-crash.txt

I think the reason for this is that cmd_execute_and_stream_data uses std::function<void(StringView)> data_cb, instead of std::function<void(const std::string&)> data_cb,. I recently had a similar issue when using string views in a multithreaded context.
How reliably can you reproduce the bug and what inputs do you use, i.e. what are the contents of your vcpkg.json?

It's quite hard to reproduce. It happens maybe once or twice, but only on our CI, I'm not having any success reproducing it, otherwise I'd be able to attach a debugger.
I've even tried to build vcpkg-tool with ASAN and TSAN enabled. Even like that, I couldn't trigger a failure. I added some logging to get the command that is executed, for me it's something like this:
/Users/martijn/git/software2/vcpkg/vcpkg install --triplet x64-osx --vcpkg-root /Users/martijn/git/software2/vcpkg --x-wait-for-lock --x-manifest-root=/Users/martijn/git/software2 --x-install-root=/Users/martijn/git/software2/build/vcpkg_installed  --overlay-triplets=/Users/martijn/git/software2/vcpkg-triplet

I guess this is related to the second sub-item in #21905.

@dg0yt @omartijn I think I found the reason for the crash. Because this is currently the only place where multithreading is in use, there should be no crashes anymore in CI.
@omartijn Thanks again for providing debug information!

Thread 46 Crashed:
0   libsystem_c.dylib             	    0x7ff8197edd22 popen + 478
1   vcpkg                         	       0x10a10ca3d vcpkg::cmd_execute_and_stream_data(vcpkg::Command const&, std::__1::function<void (vcpkg::StringView)>, vcpkg::WorkingDirectory const&, vcpkg::Environment const&, vcpkg::Encoding) + 1037
2   vcpkg                         	       0x10a10bc86 vcpkg::cmd_execute_and_capture_output(vcpkg::Command const&, vcpkg::WorkingDirectory const&, vcpkg::Environment const&, vcpkg::Encoding, vcpkg::EchoInDebug) + 118
3   vcpkg                         	       0x10a10da60 std::__1::__async_func<vcpkg::cmd_execute_and_capture_output_parallel(vcpkg::Span<vcpkg::Command const>, vcpkg::WorkingDirectory const&, vcpkg::Environment const&)::$_2>::operator()() + 128
4   vcpkg                         	       0x10a10d97a std::__1::__async_assoc_state<void, std::__1::__async_func<vcpkg::cmd_execute_and_capture_output_parallel(vcpkg::Span<vcpkg::Command const>, vcpkg::WorkingDirectory const&, vcpkg::Environment const&)::$_2> >::__execute() + 26
5   vcpkg                         	       0x10a10daee void* std::__1::__thread_proxy<std::__1::tuple<std::__1::unique_ptr<std::__1::__thread_struct, std::__1::default_delete<std::__1::__thread_struct> >, void (std::__1::__async_assoc_state<void, std::__1::__async_func<vcpkg::cmd_execute_and_capture_output_parallel(vcpkg::Span<vcpkg::Command const>, vcpkg::WorkingDirectory const&, vcpkg::Environment const&)::$_2> >::*)(), std::__1::__async_assoc_state<void, std::__1::__async_func<vcpkg::cmd_execute_and_capture_output_parallel(vcpkg::Span<vcpkg::Command const>, vcpkg::WorkingDirectory const&, vcpkg::Environment const&)::$_2> >*> >(void*) + 62
6   libsystem_pthread.dylib       	    0x7ff8198cf514 _pthread_start + 125
7   libsystem_pthread.dylib       	    0x7ff8198cb02f thread_start + 15
...
"termination" : {"flags":0,"code":11,"namespace":"SIGNAL","indicator":"Segmentation fault: 11","byProc":"exc handler","byPid":87602},

The crash occurs in popen. This is most likely an issue with Xcode. Compiling vcpkg with a new version of Xcode should fix the issue.

CI logs: https://dev.azure.com/vcpkg/public/_build/results?buildId=77580&view=logs&jobId=cf796865-97b7-5cd1-be8e-6e00ce4fd8cf&j=cf796865-97b7-5cd1-be8e-6e00ce4fd8cf&t=6d56bf67-9f63-54b3-7bd2-1eeca5f88481
I did some further debugging and it seems like there is some null termination missing. The difficulty is to debug this issue as I don't have a Mac and the issue seems to depend on code generation because adding more print statements makes it disappear. Since the issue reproduces 100% in CI runs with the current setup @omartijn can you please try to debug this on your Mac using the linked PR branch (https://github.com/microsoft/vcpkg-tool/pull/695)?
That being said my new theory is that there is some wrong code generation/ optimization going on and that it is not caused by vcpkg.
@BillyONeal What do you think about this? Is this issue worth to add fuzzing to it?

Alright, with all the work you'd done to be able to explicitly trigger this bug, I managed to find a source of undefined behaviour.
vcpkg-tool uses a vcpkg::StringView class, which, as the name suggests, gives you a view over some string-data. It's of course expected that the source remains available as long as the vcpkg::StringView is used. This is violated, however, in places where the output of Strings::concat is directly used as an argument to a function that accepts a vcpkg::StringView.
What happens in that case is that a temporary std::string is created, then an implicit string view is created, the std::string gets discarded and the string view is now pointing to invalid memory. To fix this, we should add a deleted constructor to the vcpkg::StringView class:
StringView(std::string&&) = delete;
This way, it'll still work if there is an existing string, but not when a temporary is passed. This leads to many compile errors - which are all bugs triggering UB.

cc @BillyONeal

BTW: If I compile this example program:
#include <string_view>
#include <string>

int main()
{
    std::string_view bla = std::string{"Hello, world!"};
}

and compile it with clang, even without specifying warning flags, I get the following warning:
string_view.cpp:6:28: warning: object backing the pointer will be destroyed at the end of the full-expression [-Wdangling-gsl]
    std::string_view bla = std::string{"Hello, world!"};
                           ^~~~~~~~~~~~~~~~~~~~~~~~~~~~

which is really helpful in diagnosing this particular class of bug. This warning doesn't come when using the home-grown StringView class (and I don't think you can enable this for your own classes yet, unfortunately).
I guess this class was made to avoid requiring c++17? Is that really important nowadays that the tool is provided pre-built to vcpkg? If so, could we maybe check whether c++17 is available and then simply alias vcpkg::StringView to std::string_view? That way we get the advantages of useful lifetime checks.

Alright, with all the work you'd done to be able to explicitly trigger this bug, I managed to find a source of undefined behaviour.
vcpkg-tool uses a vcpkg::StringView class, which, as the name suggests, gives you a view over some string-data. It's of course expected that the source remains available as long as the vcpkg::StringView is used. This is violated, however, in places where the output of Strings::concat is directly used as an argument to a function that accepts a vcpkg::StringView.
What happens in that case is that a temporary std::string is created, then an implicit string view is created, the std::string gets discarded and the string view is now pointing to invalid memory. To fix this, we should add a deleted constructor to the vcpkg::StringView class:
StringView(std::string&&) = delete;
This way, it'll still work if there is an existing string, but not when a temporary is passed. This leads to many compile errors - which are all bugs triggering UB.

Thanks a lot for reproducing and explaining the bug. It finally turns out that my initial guess that StringView caused the bug was actually right.

If so, could we maybe check whether c++17 is available and then simply alias vcpkg::StringView to std::string_view?

C++ 17 is already in use. I really don't know why StringView wasn't already replaced by std::string_view. This is something else that @BillyONeal has to answer.
[To avoid any confusion: I'm not working for Microsoft]

vcpkg-tool uses a vcpkg::StringView class, which, as the name suggests, gives you a view over some string-data. It's of course expected that the source remains available as long as the vcpkg::StringView is used. This is violated, however, in places where the output of Strings::concat is directly used as an argument to a function that accepts a vcpkg::StringView.

That's not true: Strings::concat returns a prvalue, which goes through a temporary materialization conversion in order to call StringView's ctor, materializing a temporary which dies at the end of the full-expression. You would have to show a StringView handed such a temporary outliving it; plain
f(StringView);
int main() {
    f(Strings::concat("a", "b"));
}

does not do that. (Both the materialized temporary std::string and the StringView die at the ; in reverse order)

StringView(std::string&&) = delete;
This way, it'll still work if there is an existing string, but not when a temporary is passed. This leads to many compile errors - which are all bugs triggering UB.

No, StringView is explicitly intended to replace const std::string& and adding such a ctor would break that.

Standard references for the above:

http://eel.is/c++draft/dcl.init#ref-5.3 explicitly says that the temporary materialization conversion is applied.
http://eel.is/c++draft/class.temporary#4 says that the resulting temporary lives to the end of the full expression and not to any particular subexpression.

Ah, you're right about that. So the issue is (luckily) confined to places where the StringView outlives the temporary std::string, like in vcpkg::parse_download_configuration, where an AssetSourcesParser is constructed taking a temporary std::string that's then used to create a StringView.
The parser is then used a line later - in anothre full-expression - when the temporary is destructed. In this case, clang would've caught the bug had we used std::string_view instead.


pip install django-dirtyfields doesn't pull the most up-to-date code

pip install django-dirtyfields
doesn't pull the correct codebase.
For instance, is_dirty doesn't even have the check_relationship param as per the code downloaded. For now I am working around this by making pip download from head of master branch.

Hi @prathapsridharan ,
We have not yet released the latest version on pypi. @smn , I think it can be good to talk about when releasing a new version.

Thank you! I figured that might have been the case but just wanted to let you know if there was indeed some other issue.
Cheers,
Prathap

@romgar if you follow the Git flow release process it'll result in a new release on Pypi. Just make sure to update the version number and have it conform with semver.org's recommendations on what the next reasonable version number is?

Ok !!

wanted to ask the same actually. Any short term plans for a new version release? that'd be great, indeed the check_relationship improvement would be quite helpful for a task I'm working on right now. Keep up the good work, by the way!

Hi @angelo-romano , I expect to spend some time really soon (days).

@angelo-romano version 0.4 (with check_relationship) is released, enjoy !

nice work @romgar, thank you.


Fix command name in example

👍
@yuppie-flu do you mind filling out the CLA here? http://druid.io/community/cla.html

@fjy done

:+1:


Validate job files for syntax errors

Intended to resolve: https://github.com/kittoframework/kitto/issues/34

Coverage decreased (-2.05%) to 79.293% when pulling c8e356e50f233e5631af45cc0ab2ab20c885a825 on job-validator into 80aabaea32e6106ebc5fa680e74cbd93998e7584 on master.

Coverage decreased (-2.05%) to 79.293% when pulling 080673c8acab76796f5a9b389410c14794422e44 on job-validator into 80aabaea32e6106ebc5fa680e74cbd93998e7584 on master.

Coverage decreased (-0.008%) to 80.303% when pulling 3842ba23738fe867b7506e5e30cf2ba2cbc08139 on job-validator into 3f013d8c014910c1f92523c2db823b2fc56e61b5 on master.

Coverage decreased (-0.2%) to 80.1% when pulling c9d3f9e81ba0743b99cf63c118c37d9747cd4f84 on job-validator into 3f013d8c014910c1f92523c2db823b2fc56e61b5 on master.

Coverage decreased (-0.2%) to 80.1% when pulling c68ea7975ad189daf7b6cc54f5f52f37173cf7cc on job-validator into 3f013d8c014910c1f92523c2db823b2fc56e61b5 on master.

Coverage decreased (-1.2%) to 80.1% when pulling ccb47d00c2f259cfde231f3cda91c1e309173821 on job-validator into 3f013d8c014910c1f92523c2db823b2fc56e61b5 on master.

Coverage increased (+3.7%) to 85.075% when pulling 6f3f59f8a166c5952ab095fa4fc1aabd31665093 on job-validator into 3f013d8c014910c1f92523c2db823b2fc56e61b5 on master.

Coverage increased (+3.7%) to 85.075% when pulling 4bfbf863581c376fd827008bb9cd62a82a6f60b0 on job-validator into 3f013d8c014910c1f92523c2db823b2fc56e61b5 on master.


Not able to find variable for NSObject

Hi Everyone,
I'm in the process of building a plugin for nativescript. It is wrapping the https://github.com/MobilePayDev/MobilePay-AppSwitch-SDK which I'll use for payments in the app.
Everything works beautifully on Android but I am having trouble on iOS. I can build and everything but on runtime i see an error (c/p of the error is further down). The plugin can be seen here: https://github.com/blaur/nativescript-mobilepay
In the SDK, i'm wanting to use the MobilePayManager which is a NSObject. It is defined like this in the SDK:
@interface MobilePayManager : NSObject
I've added this to my ios typings like this:
declare class MobilePayManager extends NSObject {
    static alloc(): MobilePayManager;

    mobilePayAppStoreLinkDK: any;

    isMobilePayInstalled(country: MobilePayCountry): boolean;

    setupWithMerchantId(setupWithMerchantId: string, merchantUrlScheme: string, country: MobilePayCountry);

    initWithOrderId(orderId: string, price: number): MobilePayPayment;

    beginMobilePaymentWithPayment(payment: MobilePayPayment, error: any);

    handleMobilePayCallbacksWithUrl(url: any, success: any, cancel: any);

    handleMobilePayPaymentWithUrl(url: string): any;

    setTimeoutSeconds(seconds: number);
}

This is then used in my mobilepay.ios.ts like this:
/// <reference path="./node_modules/tns-platform-declarations/ios.d.ts" />
/// <reference path="./platforms/ios/typings/MobilePayManager.d.ts" />

import { MobilePayBase } from './mobilepay.common';
export class MobilePay extends MobilePayBase {
    public mobilePayManager: MobilePayManager;
    public paymentCallback: any;
    private static MOBILEPAY_PAYMENT_REQUEST_CODE = 1337;

    createMobilePayInstance(merchantId: string): any {
        //console.log(MobilePayCountry.MobilePayCountry_Denmark);
        this.mobilePayManager = MobilePayManager.alloc().setupWithMerchantId(
            merchantId, 'nativescriptmobilepay',
            MobilePayCountry.MobilePayCountry_Denmark
        );
        this.mobilePayManager.setTimeoutSeconds(90);

        return this.mobilePayManager;
    }
  ......

I'm getting the following error in the createMobilePayInstance above which indicates that I am doing something wrong. I get this on runtime:
CONSOLE ERROR [native code]: ERROR ReferenceError: Can't find variable: MobilePayManager
I've validated that the Podfile is indeed downloaded and installed in my demo app and the MobilePayManager is available.
Dependencies are:
"devDependencies": {
<EMAIL_ADDRESS>"^4.0.5",
		"prompt": "^1.0.0",
		"rimraf": "^2.6.3",
		"semver": "^5.6.0",
		"tns-core-modules": "^5.0.0",
		"tns-platform-declarations": "^5.0.0",
		"tslint": "^5.12.1",
		"typescript": "~3.3.3"
	}

Any ideas would be greatly appreciated!!

Any feedback from the NativeScript team would be very much appreciated.

Docs on the SDK can be seen here: https://github.com/MobilePayDev/MobilePay-AppSwitch-SDK/wiki/Getting-started-on-iPhone

I found out what the problem was. It was related to the static library and pointing to the right headers....


Policy validation

I want to implement a policy validation for entities where i can pre check if a user can insert/update/delete/query an entity, but i dont see anything at ef core level, at db command level maybe in IUpdateSqlGenerator for insert/update/delete but i think this is not right because is not on top of all specific database providers (implementations), is there something at core level or something at tree level like IDbCommandTreeInterceptor (EF6) ?
My motive to make this question is because i need to implement a web application with owasp security controls in mind, specialy  A4 – Insecure Direct Object References. A policy validation is usefull to add a security level to data access.
Thanks.

Authorizing requests coming from the web should really be done in the application layer, not the database.  Here's a framework that's very useful for authentication & authorization which integrates with EF Core and ASP.NET MVC, and is also written by the same .NET teams at Microsoft.  So try checking out aspnet/Identity or some other framework first.

I know that framework, but some security validations are in database layer like i can only query/create/delete/update some entities with specific values because my user profile must have that specific value, for example i can only query records from a organization in which my user profile has been asigned.

In general it should be possible to perform this kind of validation at the application level if there are controller actions that map to CUD operations on specific tables. The controller actions could then inspect values and execute additional logic to decide whether the operation is allowed for the specific user.
But if the mapping between the controller action and the database objects and operations isn't 1:1 then I agree there would be value in having a way to achieve this kind of validation in the data layer.
We currently don't have any feature we have designed to do this. E.g. there is no IDbCommandTreeInterceptor in EF Core and update commands are not represented as expressions that can be parsed and reasoned about.
Currently it should be possible to satisfy some validation needs by overriding the SaveChanges() method as described in the blog post at https://blogs.msdn.microsoft.com/dotnet/2016/09/29/implementing-seeding-custom-conventions-and-interceptors-in-ef-core-1-0/.
Deeper support for this scenario could be added as part of lifecycle hooks (see #626).

Note for triage: I think this can be closed as a dupe of lifecycle hooks #626. I added a comment there about this scenario.


Unable to run project in my local system

Please guide me how can i run this project in local system

As written in the readme, if you are on windows each of the commands in the startAll script need to be run separately in prompt/terminal window...
startAll
(cd ./sveltepod && npm run podiumstart)
(cd ./reactpod && npm run podiumstart)
(cd ./reactnav && npm run podiumstart)
(cd ./htmlpod && npm run podiumstart)
(cd ./htmlbuspod && npm run podiumstart)
(cd ./vuepod && npm run podiumstart)
(cd ./angularpod && npm run podiumstart)
(cd ./fullapp && npm run start)
A different solution might be to separate the commands in their own scripts and then use a package such as run-all to run them all in parallel.

I recommend this repo where several front-end frameworks & libraries are combined:
https://github.com/Jozzeh/podium-mixed-example
It is accompanied by this article:
https://medium.com/swlh/react-vue-svelte-on-one-page-with-micro-frontends-f740b3ee6979


Area selection should use two distinct actions for the corners

Currently, the area selection is done via
__on_player_swings_hand(player, hand) ->
(
    if(player~'holds':0==global_wand,
        if (global_selection && length(global_selection)>1, clear_selection() );
        if (!global_selection, _set_start_point(player), _set_end_point(player) );
    )
);

but this means that when making a selection, if the user misclicks the second corner, they have to fly back to the first position to set it again. Having two distinct actions for each corner makes it easier to make the selections.
We currently have four actions at our disposal: right and left click while sneaking or not seneaking. Do we need to save them for some use, or should they me used mainly for area selection (and maybe movement?).

Alternative: right click sets the corners, lef click grabs a corner, in case the user wants to set that one corner again. Detecting the left click on the corner is a bit cumbersome, since the armour stands ar markers and have no hitbox, but it's an idea.
Another idea is using sift left click to move the selection forward, shift right click to move it back and maybe even move the corners if we do implement selecting them. Of course any combination of these is usable: right click and shift right click to set corners, left and whift left to move, whatever.

Since many players already know the WorldEdit/Litematica selection input, I think it would be a nice idea to keep this method aviable via config anyway.

agree that breaking the selection should be harder to do, rather than easier to do.
I like the use of rightclicking of the element as operation to grab it, and left click to set it. The reason I used marker armorstands is because their sticks are not glowing, but selection of 'points' in the canvas should be possible. We can do that by projecting the look to 4 blocks in front and grabbing the closest hook within lets say 3-4 blocks.
we will need to have some 'markers' in the canvas area anyways, since having things like this would be really nice to have
https://www.youtube.com/watch?v=igmKphb7B2A

how selection is done in WE/LM? @BisUmTo

Common inputs:
Left click -> Pos1 -> first corner of a cuboid selection
Right click -> Pos2 -> second corner of a cuboid selection
Litematica only inputs:
You can select a corner and use the scroll weal to move the selected corner in the direction you're looking (if scrolled up) or in the reverse direction (if scrolled down)

done ig


test build server pr

:+1:

Result of Integration 2
Duration: 8 seconds
Result: 1 error, failing state: build-errors

Result of Integration 1
Duration: 13 seconds
Result: 1 error, failing state: build-errors


Make log4javascript load in node, with a test appender.

Also, add a barebones Jasmine test to make sure this works.

The Jasmine test in spec/node/log4javascript.js is supposed to be a starting point.  I would suggest that other fixes for log4javascript, as a npm module, add more tests to this file.  I expect other uses of log4javascript are not yet fixed with my very basic patch.


Initial support for printing BTF as C headers

coverage: 89.47% (-5.6%) from 95.054% when pulling 5420d27b2cccfd159bae12cde4781d5fdd7fb193 on btf_dump_c_header into e532c3f53bdc4a99d506052abdedafdf14e7ebcd on main.


Update projection docs for DGP story

Closes https://github.com/Azure/typespec-azure/issues/2395

Closed in favor of https://github.com/Azure/typespec-azure/pull/2801


Support code tabs in rst files

The following snippet renders as normal text, not as code:
.. tab:: curl

    $ curl http://example.com

.. tab:: wget

    $ wget http://example.com

The demo for code tabs in this project is written in markdown. Wow would one flag this as code so that it renders properly?

I think this issue can be closed, the following is works just fine:
.. tab::  Tab1

    .. code-block:: python

        output = f"Firstname: {user.first_name}, Lastname: {user.last_name}, Age: {user.age}"

.. tab:: Tab2

    .. code-block:: python

        output = "Firstname: {}, Lastname: {}, Age: {}".format(
            user.first_name,
            user.last_name,
            user.age
        )


Toolz dropin API for dask.bag

@wrobstory suggested that dask.bag actually follow the toolz API directly.  Additionally it might be nice to have functions that could work equally well on dask.bag objects as on normal Python Iterators and Iterables.
@eriknw might find this interesting.

Good idea.  I'd like to tackle this, and the earliest I can do so is during my flight this Sunday.
Do you envision the toolz API wrapping and using the current dask.Bag, or do you think dask.Bag should be broken apart?

I think that we probably want to keep the existing bag API as well.  I'm not sure if this answers your question.

In hindsight I wish I had written dask.bag in a more toolzy way from the start.   I wouldn't be opposed to a full rewrite that put logic in a more pure functional style but kept the current API as a wrapping.  This is probably far more expensive though.

When matching the toolz API, you would keep the monad-esque method chaining, right?  That's something I think dask.bag/spark/javascript all got right.  Most programmers have trouble unpacking code of the map(filter(reduce(something, map(filter(source))))) style.

Toolz generally uses bare functions.  We tend to use currying and a pipe function for repeated function composition.

This doesn't seem like its going to happen.  I suspect that there is already sufficient inertia behind dask.bag so that this is more likely a fun project than an essential project.  Closing.


Put the Support Interface behind DfE Sign-in

DO NOT MERGE UNTIL WE HAVE SET UP DfE Sign-in SUPPORT USERS ON QA/STAGING/PRODUCTION
Context
Currently the support interface is authenticated with basic auth. This is not very secure and means that we cannot grant access to individuals or audit their activity.
Changes proposed in this pull request

[x] Authenticate users of the support interface with DfE Sign-in. Users can log in with one DfE Sign-in account that could have access to the provider interface, support interface or both.
[x] Authorise users of the support interface by looking up their email address on a list stored in the database. For authenticated users that are not authorized we render a new 'Not authorized' template (because the one for providers isn't appropriate). (Copy needs to be reviewed).
[x] Change the DfE Sign-in callback action so that it can serve both interfaces. To do this we now store the 'target' path that the unauthenticated user originally attempted to access in the user session and redirect them here following a successful login. Previously they were redirected to a hard-coded path in the provider interface.
[x] Handle the situation in which the user went straight to the login page for the support or provider interface (without setting the target path session variable).
[x] Ensure that we still handle the situation in which a provider can log in but has not yet been granted access.
[x] Add a rake task to create a support user (or just update it's email address if it already exists). Usage: bundle exec rails "create_support_user[alice<EMAIL_ADDRESS>where alice is the DfE Sign-in UID and<EMAIL_ADDRESS>is the email address.
[x] Update README?
[ ] Work out a list of email addresses that require access and configure these before we deploy to production. (We can add these using the rake task above or direct DB access).

Guidance to review

Are there any loopholes that would allow users to access the support interface unauthenticated or without the correct authorisation?
Are the tests covering everything they should? e.g. failed login as well as success
What are the challenges with rolling this out other than having to configure the list of users that should have access? Based on what we discussed at the incident review this should have been broken up somehow and/or feature flagged. Not sure how that would work exactly.
Content review for the 'Not authorized' page

Link to Trello card
1307 - Put support behind DfE Sign-in
Env vars

no new env vars

👏 @steve


Error while code execution in default setting

I am getting the following error while executing the code in default setting.
`Traceback (most recent call last):
File "/home/sapto/Desktop/Translation/seq2seq_translation_tutorial.py", line 812, in
trainEpochs(encoder1, attn_decoder1, 75000, print_every=5000)
File "/home/sapto/Desktop/Translation/seq2seq_translation_tutorial.py", line 678, in trainEpochs
decoder, encoder_optimizer, decoder_optimizer, criterion)
File "/home/sapto/Desktop/Translation/seq2seq_translation_tutorial.py", line 584, in train
input_variable[ei], encoder_hidden)
File "/home/sapto/anaconda3/lib/python3.6/site-packages/torch/nn/modules/module.py", line 206, in call
result = self.forward(*input, **kwargs)
File "/home/sapto/Desktop/Translation/seq2seq_translation_tutorial.py", line 355, in forward
output, hidden = self.lstm(output, hidden)
File "/home/sapto/anaconda3/lib/python3.6/site-packages/torch/nn/modules/module.py", line 206, in call
result = self.forward(*input, **kwargs)
File "/home/sapto/anaconda3/lib/python3.6/site-packages/torch/nn/modules/rnn.py", line 91, in forward
output, hidden = func(input, self.all_weights, hx)
File "/home/sapto/anaconda3/lib/python3.6/site-packages/torch/nn/_functions/rnn.py", line 327, in forward
return func(input, *fargs, **fkwargs)
File "/home/sapto/anaconda3/lib/python3.6/site-packages/torch/autograd/function.py", line 202, in _do_forward
flat_output = super(NestedIOFunction, self)._do_forward(*flat_input)
File "/home/sapto/anaconda3/lib/python3.6/site-packages/torch/autograd/function.py", line 224, in forward
result = self.forward_extended(*nested_tensors)
File "/home/sapto/anaconda3/lib/python3.6/site-packages/torch/nn/_functions/rnn.py", line 269, in forward_extended
cudnn.rnn.forward(self, input, hx, weight, output, hy)
File "/home/sapto/anaconda3/lib/python3.6/site-packages/torch/backends/cudnn/rnn.py", line 195, in forward
hx, cx = hx
ValueError: not enough values to unpack (expected 2, got 1)
Process finished with exit code 1`

I haven't seen this error before - are you using an up-to-date version of PyTorch?

yep.. I am using the latest version of PyTorch..
Regards,
Saptakatha Adak
Visualization and Perception Lab
Department of Computer Science and Engineering
Indian Institute of Technology Madras
இந்தியா தொழில்நுட்ப கழகம் சென்னை
Chennai - 600036
Tamil Nadu
India
On 2 May 2017 at 22:01, Sean Robertson<EMAIL_ADDRESS>wrote:

I haven't seen this error before - are you using an up-to-date version of
PyTorch?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/spro/practical-pytorch/issues/12#issuecomment-298688146,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AaGiPgI-jFsRGo1HylIGdmIFwL13VWK8ks5r11pEgaJpZM4M7zOe
.

Looking closer it seems you switched the GRU to a LSTM, which has slightly different inputs and outputs. The LSTM hidden states are stored as a tuple of tensors (hx, cx) whereas the GRU hidden state is a single tensor.

Ok.. Thank you..
On May 20, 2017 11:24 PM, "Sean Robertson"<EMAIL_ADDRESS>wrote:

Looking closer it seems you switched the GRU to a LSTM, which has slightly
different inputs and outputs. The LSTM hidden states are stored as a tuple
of tensors (hx, cx) whereas the GRU hidden state is a single tensor.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/spro/practical-pytorch/issues/12#issuecomment-302888583,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AaGiPsd9IbeZeucLHc8eYZ571DRwQ04fks5r7yjwgaJpZM4M7zOe
.


Remove a bunch of TODOs

We should use issues to track TODOs and we have issues or don't care about these.

/lgtm

/approve


support browser refresh and multiple tab?

I cam from another oidc lib since I am hitting a few bugs with it. I am trying to evaluate this lib see if it works for my scenario.
first question is, does this lib work after the browser refresh e.g. how the session info is stored to survive the refresh.
second question is does it support multiple tab. though it's a SPA app but my client has this requirement to open the app in another tab, so on the new tab, the app should still works without re-login.
third question is after closing the browser without logout, the user reopen the site, two cases here, the session does not expired yet, then would the lib pickup where it's left off and continue without re-login? when the session expired, would it prompt the user for login?
thx

Have a look at the docs for:

OAuthStorage
SessionChecks (if your IDS supports it)

Or check the annotated wrapper service I wrote that handles most things you mention, in an opinionated way.

@jeroenheijmans just looking at your example. but it's an example for implicit flow. could change it to PKCE. so with localstorage, I guess the session data will be stored in the localstorage which will survive the browser refresh, correct? identityserver4 supports sessionchecks, so no issue there.

seems like the example does not work in IE. does the lib not support IE?

just wondering how is the client checking for PKCE idtoken timeout, does it have a heard beat doing the checking or it's done in the http interceptor?

also for SPA, implicit flow is not recommended. PKCE is a better flow.

is it possible to have an example of PKCE code flow with the lib? thx

never mind, I update the app to use PKCE code flow. it works.

everything works except silent refresh.

looks like the silent refresh got the code back to failed to process it.

It would look pretty much the same with code flow. Meanwhile the readme shows this.
There where issues with IE in version 9. Today, I'll ship 9.1 which solves this issues.
Also, before version 9.1 (which ships today), silent refresh was not supported for code flow + PKCE.


TextEditor.onDidChangeScrollTop is deprecated.

This is now a view method. Call TextEditorElement::onDidChangeScrollTop instead.
TextEditor.onDidChangeScrollTop (<embedded>:11:9378)
registerEvents (C:\Users\Administrator\.atom\packages\jshint\index.js:324:32)
Function.simpleDispatch (<embedded>:11:1172354)
Emitter.emit (<embedded>:11:1173795)
Workspace.didActivatePaneContainer (<embedded>:11:424001)
WorkspaceCenter.paneContainer.onDidActivatePane (<embedded>:14:38543)

Thanks for contributing!
It appears that this is being caused by the https://atom.io/packages/atom-jshint package, not Atom itself. It may be that there is still a bug in Atom. If so, we'll need the maintainer of the package that is causing the problem to help track that down. You should file this issue on their repository so they can either fix the problem or tell us where the problem is coming from. The Atom FAQ has information on how to contact the maintainers of any Atom community package or theme.


[HOLD for payment 2023-04-28] [$1000] Feature request : add some bottom padding to the copy link bottom-docked dialog on mobile

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Problem:
Incorrect bottom padding in the copy URL bottom-docked modal
Solution:
Increase the bottom padding to match the top padding.
Context/Examples/Screenshots/Notes:

Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Expensify/Expensify Issue URL:
Issue reported by: @puneetlath
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1681313186606359
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01b61ef9ad2019e632
Upwork Job ID:<PHONE_NUMBER>878363648
Last Price Increase: 2023-04-13

Triggered auto assignment to @trjExpensify (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero process steps for feature requests for more details.

@puneetlath @shawnborton can we firm up the OP on this one a bit before I move it along to guide the proposal? How much bottom padding do we want to add etc?

It should match the same padding that is on the top... so that might be either like 12px or 16px?

Current assignee @trjExpensify is eligible for the External assigner, not assigning anyone new.

Triggered auto assignment to Contributor-plus team member for initial proposal review - @thesahindia (External)

Contributor details
Your Expensify account email<EMAIL_ADDRESS>Upwork Profile Link: https://www.upwork.com/freelancers/~01517205235949d8f7

Proposal
Please re-state the problem that we are trying to solve in this issue.
add some bottom padding to the copy link bottom-docked dialog on mobile
What is the root cause of that problem?
in modal container view we depond on home bar notch to add padding by using safeArea bottom, but in devices dos't have home bar there is no bottom margin is set.
What changes do you think we should make in order to solve the problem?
if no safeArea bottom add margin bottom 12
const modalPaddingStyles = StyleUtils.getModalPaddingStyles({
      safeAreaPaddingTop,
      safeAreaPaddingBottom,
      safeAreaPaddingLeft,
      safeAreaPaddingRight,
      shouldAddBottomSafeAreaMargin,
      shouldAddTopSafeAreaMargin,
      shouldAddBottomSafeAreaPadding,
      shouldAddTopSafeAreaPadding,
      modalContainerStyleMarginTop: modalContainerStyle.marginTop,
      //change the below line <<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<
      modalContainerStyleMarginBottom: insets.bottom === 0 ? 12 : modalContainerStyle.marginBottom,
      modalContainerStylePaddingTop: modalContainerStyle.paddingTop,
      modalContainerStylePaddingBottom: modalContainerStyle.paddingBottom,
  });

What alternative solutions did you explore? (Optional)

Proposal
Please re-state the problem that we are trying to solve in this issue.
To add some bottom padding to the copy link bottom-docked dialog on mobile
What is the root cause of that problem?
Padding-bottom for "bottom-docked" modal in mobile is not defined in code!
What changes do you think we should make in order to solve the problem?
To add bottom padding to the copy link bottom-docked dialog on mobile, you can add the following style to the modalContainerStyle object inside the "CONST.MODAL.MODAL_TYPE.BOTTOM_DOCKED" switch case:
modalContainerStyle = {
width: '100%',
borderTopLeftRadius: 20,
borderTopRightRadius: 20,
paddingTop: 12,
paddingBottom: 16, // add bottom padding
justifyContent: 'center',
overflow: 'hidden',
};
What alternative solutions did you explore?
Alternative to add some bottom padding to the BOTTOM_DOCKED modal type, we can modify the modalContainerStyle object for this case in the switch statement. We can add a paddingBottom property with the desired value of padding (for example, 16):
case CONST.MODAL.MODAL_TYPE.BOTTOM_DOCKED:
modalStyle = {
...modalStyle,
...{
alignItems: 'center',
justifyContent: 'flex-end',
},
};
modalContainerStyle = {
width: '100%',
borderTopLeftRadius: 20,
borderTopRightRadius: 20,
paddingTop: 12,
justifyContent: 'center',
overflow: 'hidden',
paddingBottom: 16, // add bottom padding here
};
shouldAddBottomSafeAreaPadding = true;
swipeDirection = undefined;
animationIn = 'slideInUp';
animationOut = 'slideOutDown';
break;

This will add a 16 point bottom padding to the BOTTOM_DOCKED modal type. You can adjust the value to whatever padding you need.

@thesahindia
I think we need to add this margin only in screens dosn't have home bar like the second image but first image with home bar don't need extra margin, and if we add to it, it will be shown inconsistent.

Their proposal looks good to me as well. Good catch about the safe area view impacting this as well. Assigning them!

📣 @ahmedGaber93 You have been assigned to this job by @alex-mechler!
Please apply to this job in Upwork and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑💻
Keep in mind: Code of Conduct | Contributing 📖

@alex-mechler @thesahindia PR is ready for review.

@trjExpensify, @alex-mechler, @ahmedGaber93, @thesahindia Whoops! This issue is 2 days overdue. Let's get this updated quick!

The solution for this issue has been :rocket: deployed to production :rocket: in version 1.3.3-2 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

https://github.com/Expensify/App/pull/17495

If no regressions arise, payment will be issued on 2023-04-28. :confetti_ball:
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

[ ] External issue reporter
[ ] Contributor that fixed the issue
[ ] Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

Merged PR within 3 business days of assignment - 50% bonus
Merged PR more than 9 business days after assignment - 50% penalty

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[ ] [@thesahindia] The PR that introduced the bug has been identified. Link to the PR:
[ ] [@thesahindia] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[ ] [@thesahindia] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[ ] [@trjExpensify] Determine if we should create a regression test for this bug.
[ ] [@thesahindia] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[ ] [@trjExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

Not sure why automation failed, thats the comments that should have been posted though!

Agreed. I think this would be classed as a visual bug, so we wouldn't have a regression test case written up for it.
I've sent the below offers. No #urgency bonus applies here because the issue was assigned on the 14th and approved/merged on the 19th. Let me know if you disagree with that though:

$1,000 to @thesahindia for C+ review
$1,000 to @ahmedGaber93 for the fix

@trjExpensify

the issue was assigned on the 14th and approved/merged on the 19th.

The dates mentioned are correct, but this period includes 2 days weekend, so I think the PR merged within 3 business days

Yup, the 15th and the 16th were weekends, so that would be exactly 3 business days.

Hm, why are we discounting Friday as a business day, when the issue was assigned on that day? Assigned on the 14th at 7:29 UTC, merged on the 19th at 7:31 UTC.

😕 not sure why I miscounted there, but yeah, that is correct. That would be just over the 3 day mark

Settled up with you both, closing!


Patch methods : Data never populated

Steps to reproduce
calling a patch service method doesn't update the record in question.
When i do something like this
await this.patchPost([postId, { postContent : this.postContent}, {}])

I dont get an error.
I can see the time stamps in my mongodb do get "patched"
I notice that postContent property inside my mongodb record NEVER gets "patched" with what i send.
When i put a console log inside the before patch hook within my feathers backend the data object is completely empty!

I've tested my backend with postman/curl and it successfully patches and shows the data, this leads me to think its nothing to do with feathers. Perhaps the feathers-vuex plugin is not correctly sending data out?
System configuration
Module versions
Front end
"@feathersjs/authentication-client": "^4.3.0",
    "@feathersjs/commons": "4.0.0",
    "@feathersjs/feathers": "^4.3.0",
    "@feathersjs/socketio-client": "^4.3.0",
    "casl": "^1.1.0",
    "core-js": "^2.6.5",
    "date-fns": "^2.0.1",
    "feathers-vuex": "^2.0.0-pre.75",
    "jwt-decode": "^2.2.0",
    "lodash": "^4.17.15",
    "register-service-worker": "^1.6.2",
    "socket.io-client": "^2.2.0",
    "uuid": "^3.3.3",
    "vue": "^2.6.10",
    "vue-router": "^3.0.3",
    "vuelidate": "^0.7.4",
    "vuetify": "^2.0.0",
    "vuex": "^3.1.1"

Back end
    "@feathersjs/authentication": "^4.3.0",
    "@feathersjs/authentication-local": "^4.3.0",
    "@feathersjs/authentication-oauth": "^4.3.0",
    "@feathersjs/configuration": "^4.3.0",
    "@feathersjs/errors": "^4.3.0",
    "@feathersjs/express": "^4.3.0",
    "@feathersjs/feathers": "^4.3.0",
    "@feathersjs/socketio": "^4.3.0",
    "compression": "^1.7.4",
    "cors": "^2.8.5",
    "feathers-mongoose": "^8.0.2",
    "helmet": "^3.20.1",
    "lodash": "^4.17.15",
    "mongodb": "^3.3.2",
    "mongoose": "^5.6.11",
    "serve-favicon": "^2.5.0",
    "winston": "^3.2.1"

NodeJS version: v10.15.0
Operating System: Windows 10 PRO
Browser Version: Chrome

hmm looks similar to https://github.com/feathers-plus/feathers-vuex/issues/237 . Trying this fix

https://github.com/feathers-plus/feathers-vuex/issues/237 resolved it for me. I had a ^ in my package json for feathers-vuex, resulting in npm getting the 2.0.0 version


Test: Add more arg testing for asn1_codec.py and common.py

Add more arg testing for asn1_codec.py and common.py
and exclude a couple of lines from coverage metrics since they're
only there to try to be helpful if there is a faulty installation
or if the code changes and impossible things become possible.

Coverage increased (+0.7%) to 96.733% when pulling fa895d7286cfc33208c7a9561b9d32e7d025f327 on awwad:additional_coverage into 709e780f6c0e322c798584fe808075870051d441 on uptane:develop.


[Feature Request] Posibility of mat-prefix and mat-suffix icons in textfield

It would be nice if we could add material icons to the textfield

Just in case someone still needs this. Not sure if this is the right way to do it tho. Tested on Android 9 - NS 6.x
Code

import { android as androidApp } from 'tns-core-modules/application'

...

// loaded event
textFieldLoaded({ object }) {
    // Grab Native view
    const inputLayout = object.android
    // Grab icon from res (replace "com.example.app" with your package name. "ic_add" with your icon name)
    const icon = com.example.app.R.drawable.ic_add
    // Convert it into a drawable for android
    const iconDrawable = androidApp.context.getResources().getDrawable(icon)

    inputLayout.setPrefixText("+63 ")
    inputLayout.setStartIconDrawable(iconDrawable)
}

Result

@kryoware I think it is the right way. Want to make a PR to add that both on iOS and Android ?


Reduced performance while building on bind mount outside of docker

Host and Guest: 12.04.3
Docker: 0.6.6
lxc: 0.7.5
Kernel: 3.8.0-29
Hardware: Dual 6C Xeon with 64GB RAM and 100GB root SSD and dual 3TB RAID0
Docker is installed on the SSD using deb packages.
I created a docker image based off the base ubuntu in the registry. This image is located in /var/lib/docker on the SSD. I created a world writable directory on the RAID0 drive and bind mounted into the docker image. All the source code and builds were done in the bind mounted directory on RAID0 drive. I launched /bin/bash inside the container and then ran the build.
Builds not using docker on RAID0 take 30-40 minutes. Inside docker the builds on RAID0 bind mount were consistently 55-65 minutes (not at the same time of course).
I then ran 'docker export' and placed rootfs on RAID0 drive. I copied most of lxc config from docker and ran lxc directly using lxc-start. The build directory was again bind mounted into the lxc container. The build using lxc directly completed in 32 min. In docker and lxc the bind mount has the same options: rw,relatime,data=ordered.
I then tried docker again and bind mounted host /tmp to a container /tmp. I did the same with /var/tmp because docker diff showed changes on /var/tmp. No change in build times.
I don't know what is going on here. The rootfs is essentially read only and on ssd. I would expect the aufs overhead only when writing, not when reading. It seems that if the rootfs is aufs, a build on a mount outside of the aufs filesystem is still affected.
If there is some option/configuration I missed let me know, otherwise I will wait until the device-mapper implementation is ready and try again.
Thanks for a great tool.

can you see if this is a still an issue with the latest version of docker

Docker 1.5 on Ubuntu 14.04 with 3.16 utopic LTS kernel.
The current stable poky release is dizzy:
cd <buildarea>
mkdir downloads
chmod 777 downloads
git clone --branch dizzy git://git.yoctoproject.org/poky
source poky/oe-init-build-env mybuild
ln -s ../downloads .
bitbake -c fetchall core-image-minimal
time bitbake core-image-minimal

There is no need to set the parallel packages and jobs now in
local.conf because bitbake now chooses reasonable defaults.
Bare Metal:
real    29m59.190s
user    278m0.988s
sys     59m47.379s

Devicemapper:
real    32m21.074s
user    281m53.994s
sys     68m45.554s

AUFS:
real    37m14.612s
user    259m19.226s
sys     85m50.269s

I only ran each build once so this is not an authoritative
benchmark. It shows that there is a performance overhead of approx 20% when using the
aufs backend even if the IO is done on a bind mount.

@kscherer Docker 1.6 will have direct io support for aufs and it should be faster. How did you set up devicemapper? I'm asking about devicemapper because I know some people are using it in production, but the way it's set up matters.

On 15-04-06 11:04 AM, unclejack wrote:

@kscherer https://github.com/kscherer Docker 1.6 will have direct io
support for aufs and it should be faster. How did you set up
devicemapper? I'm asking about devicemapper because I know some people
are using it in production, but the way it's set up matters.
—
Reply to this email directly or view it on GitHub
https://github.com/docker/docker/issues/2891#issuecomment-90093183.

That is good news and I look forward to rerunning my tests.
I am using the devicemapper backend in loopback mode. This has been
working well enough, although the instance creation fails sometimes
(Issue #4096). I will look into the devicemapper direct-lvm mode.

Update for Docker 1.7

Ubuntu 14.04.2
Vivid kernel 3.19.0-21-generic
Dual 6C Xeon with 64GB RAM and 100GB root SSD and dual 3TB RAID0

Building poky, fido release, core-image-minimal on a ext4 bind mount with the docker
image using different storage backends.
cd <buildarea>
mkdir downloads
git clone --branch fido git://git.yoctoproject.org/poky
source poky/oe-init-build-env mybuild
ln -s ../downloads .
sed -i 's/#MACHINE ?= "qemux86-64"/MACHINE ?= "qemux86-64"/' conf/local.conf
bitbake -c fetchall core-image-minimal
time bitbake core-image-minimal

Bare-metal:
real    33m5.260s
user    289m41.356s
sys     27m23.488s

Aufs:
real    40m24.416s
user    258m48.932s
sys     56m29.284s

Devicemapper with official binary in loopback mode:
real    35m24.415s
user    289m10.660s
sys     34m21.168s

Devicemapper with my own compiled dynamic binary:
real    34m18.387s
user    294m1.720s
sys     31m43.764s

Overlayfs:
real    33m46.890s
user    293m40.084s
sys     35m31.480s

See http://kscherer.github.io/docker/2015/07/09/benchmarking-docker-storage-backends/ for the Dockerfile used.
The performance of the aufs backend in this scenario has improved, but the overhead is still significant. With the udev sync requirements for devicemapper on docker 1.7, it is clear to me that overlayfs is my best option on Ubuntu now.
Since I now have two options for storage backends with acceptable performance, there isn't much point to keeping the issue open.
Thanks again for the amazing work on Docker!


⚠ SceneTime has degraded performance

In c943b3a, SceneTime ($ST) experienced degraded performance:

HTTP code: 200
Response time: 2756 ms

Resolved: SceneTime performance has improved in 909c464 after 6 minutes.


[SPARK-22340][PYTHON] Save localProperties in thread.local

What changes were proposed in this pull request?

Add threading.local() in SparkContext
Save the value to thread local variables when calling setLocalProperty, setJobGroup,  and setJobDescription
Add new API getLocalProperties
Send local properties to jvm side when calling collect
On jvm side setLocalProperty in collectAndServe

How was this patch tested?
Add one unit test in test_rdd.py
Please review https://spark.apache.org/contributing.html before opening a pull request.

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Can one of the admins verify this patch?

add to whitelist

CC @ueshin

Test build #105775 has started for PR 24705 at commit 937a4a6.

Test build #105775 has finished for PR 24705 at commit 937a4a6.

This patch fails Python style tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/105775/
Test FAILed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/11030/
Test PASSed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/11135/
Test PASSed.

Test build #105878 has started for PR 24705 at commit 892d4ef.

Test build #105878 has finished for PR 24705 at commit 892d4ef.

This patch fails PySpark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/105878/
Test FAILed.

Close this PR now. We will design this more carefully.


Implement data model

Implements the base data model and split-up of this system. The goal is for it to be modular, so not specific to Azure.

THANK YOUUUUU


suggest adding crosslink to Ref Arc page

@danielleodean Do you want to make the same change to the updated readme?

re-did on updated readme


Refactor country notes to CountryManager

Description
Country Notes were stored previously in Country class.
I have refactored Country such that the country notes will be stored in CountryManager instead.
This would be a better design choice since we do not need to update Client every time a country note is added / deleted. Client can just store a Country that is basically a representation of the country code and country name.
On the UI side, country notes can be retrieved from the CountryManager given the specific country.
Fixes #130
Testing
Mainly fixed failing tests. No new tests were added.
Remarks
NIL.

Codecov Report

Merging #151 into master will decrease coverage by 0.13%.
The diff coverage is 66.66%.

@@             Coverage Diff              @@
##             master     #151      +/-   ##
============================================
- Coverage     71.12%   70.99%   -0.14%
+ Complexity      523      519       -4
============================================
  Files            90       90
  Lines          1673     1665       -8
  Branches        171      171
============================================
- Hits           1190     1182       -8
  Misses          421      421
  Partials         62       62

Impacted Files
Coverage Δ
Complexity Δ

...main/java/seedu/address/model/country/Country.java
100.00% <ø> (+5.00%)
8.00 <0.00> (-2.00)
:arrow_up:

...va/seedu/address/model/country/CountryManager.java
78.94% <66.66%> (-6.77%)
9.00 <4.00> (-2.00)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5203c8e...bd4fe5a. Read the comment docs.


DOC more docstrings

open_file vs open is rather confusing when using from shell, so I added more docstrings

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@761cc7b). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master      #10   +/-   ##
=========================================
  Coverage          ?   97.82%
=========================================
  Files             ?        3
  Lines             ?       92
  Branches          ?       12
=========================================
  Hits              ?       90
  Misses            ?        1
  Partials          ?        1

Impacted Files
Coverage Δ

json_lines/_lib.py
97.26% <ø> (ø)

It would probably break some code, but I'm fine with that, as it will make library easier to use - let me make this change. We removed open_file from docs in 0.2 release.

Ah cool, thanks for checking! +1 to make this change as well 👍

@lopuhin could you please check it again?


Wedo: Comment blocks not working

Describe the bug

Comment block does not generate comment in source code

To Reproduce
Steps to reproduce the behavior:

Go to Wedo
Type anything into a comment block
Go to source code view
See error

Expected behavior

A generated comment in the source code

Screenshots

Usually a comment is generated automatically, see EV3 example:

Device information

Desktop
Windows10
Chrome

tested with both simulation and a real wedo: works as expected


Versioned documentation

Currently the website is always describing master.
On one hand, this is great because it allows us to add documentation to features as we add them. Missing or inadequate documentation has been a big problem for us in the past.
On the other hand, people using the latest release might find something that isn't released yet and will be very confused. In addition, people who are using older versions don't have any way of finding the documentation that applies to the version they're using.
React Native has solved this problem. We should do what they are doing.

@samwgoldman I’d like to give this a try but I’ll need your guidance on the next steps. I looked into this a little bit. react-native has a separate repository for documentation, react-native-website and it’s using Facebook’s Docusaurus. A few things to consider in terms of feasibility are:

How do we make sure that existing docs hyperlinks redirect appropriately?
Do we also create a new flow-website repository?
If yes, then how do migrate over the existing docs to the new repository?
What about in-flight pull-requests inside the website directory? If we move the underlying directory, then it’ll lead to merge conflicts.
... anything else that I may have missed...

We don't have the bandwidth to add such functionality. We now add "since version" and "until version" badges various sections which helps.


roslynanalyzers failing

Hi, I'm trying to set this action up for a project I'm working on to analyze the code.
However every build fails with
Error:      Error running roslynanalyzers job: 1 of 1
Error:      GuardianErrorExitCodeException: roslynanalyzers completed with an Error exit code: 17.
Error:      Error running tool 1 of 1: roslynanalyzers
Error:      Error running roslynanalyzers job: 1 of 1
Error:      GuardianErrorExitCodeException: roslynanalyzers completed with an Error exit code: 17.

And I have no clue why. Below is my .yml file:
# sample-workflow-windows-latest
# docs are in the repo

# DISABLED for now - we do not support Ubuntu yet

name: .NET Code Analysis windows-latest
on:
  push:
    branches:
      - master

jobs:
  build:
    name: .NET Code Analysis runner

    # .NET Code Analysis runs on windows-latest.
    # ubuntu-latest and macos-latest supporting coming soon
    runs-on: windows-latest

    steps:

      # Checkout your code repository to scan
    - uses: actions/checkout@v2

    # Ensure compatible versions of dotnet are installed.
    # The [Microsoft Code Analysis CLI](https://aka.ms/mscadocs) is built with dotnet v3.1.201.
    # A version greater than or equal to v3.1.201 of dotnet must be installed on the agent in order to run this action.
    # Remote agents already have a compatible version of dotnet installed and this step may be skipped.
    # For local agents, ensure dotnet version 3.1.201 or later is installed by including this action:
    # - uses: actions/setup-dotnet@v1
    #   with:
    #     dotnet-version: '3.1.x'

    # Run NuGet restore for the solution at repo root
    - name: Run NuGet restore
      run: dotnet restore .\C2TT.sln

    # Run code analysis for the solution at repo root
    - name: Run .NET Code Analysis
      uses: dotnet/code-analysis@main
      id: code-analysis
      with:
        project: .\C2TT.sln
        build-breaking: false
        all-categories: all

    # Upload the analysis results file
    - name: Upload analysis results
      uses: actions/upload-artifact@v2
      with:
        name: analysis_results.sarif
        path: ${{ steps.code-analysis.outputs.sarifFile }}

This is a repeat of this https://github.com/dotnet/code-analysis/issues/16


cleanup tests after run

I was wondering why i was running out of space on my laptop, turns out that the tests were creating a ton of hatch environments that were taking up 9GB, and it seemed like every run was creating new environments.
So this PR just temporarily sets the HATCH_DATA_DIR to a tmpdir and cleans it up after the test run. pytest removes temporary directories itself, but it keeps them around for a bit, and since they are big i just manually removed them.
I added a --reuse-envs flag like nox in case someone wanted to keep those around for some reason. Note that these are not the envs created to run the tests in, but the envs that are created when running the tests for the generated packages.

i think it ends up being a lot of space because when developing locally you run the tests a bunch of times as you make changes to the package, so the hashes (i'm assuming) of the pyproject keep changing, so i had like 30 envs for the package