"p has already been declared" error when using @threlte/core with Svelte 5 and esbuild

When building a project using @threlte/core with esbuild-svelte, multiple "p has already been declared" errors are occurring in the Canvas.svelte and T.svelte components from the @threlte/core package.
`✘ [ERROR] "p" has already been declared
https://svelte.dev/e/declaration_duplicate [plugin esbuild-svelte]
node_modules/.pnpm/@threlte+core@8.0.0-next.31_svelte@5.12.0_three@0.171.0/node_modules/@threlte/core/dist/components/T/T.svelte:9:24:
  9 │ import { useIs } from './utils/useIs';
    ╵                         ^

The plugin "esbuild-svelte" was triggered by this import
node_modules/.pnpm/@threlte+core@8.0.0-next.31_svelte@5.12.0_three@0.171.0/node_modules/@threlte/core/dist/components/T/T.js:2:18:
  2 │ import TComp from './T.svelte';
    ╵                   ~~~~~~~~~~~~

✘ [ERROR] p has already been declared
https://svelte.dev/e/declaration_duplicate [plugin esbuild-svelte]
node_modules/.pnpm/@threlte+core@8.0.0-next.31_svelte@5.12.0_three@0.171.0/node_modules/@threlte/core/dist/Canvas.svelte:6:9:
  6 │ </script>
    ╵          ^

The plugin "esbuild-svelte" was triggered by this import
node_modules/.pnpm/@threlte+core@8.0.0-next.31_svelte@5.12.0_three@0.171.0/node_modules/@threlte/core/dist/index.js:4:34:
  4 │ export { default as Canvas } from './Canvas.svelte';
    ╵                                   ~~~~~~~~~~~~~~~~`

Can you show the contents of your package.json file?

{   "dependencies": {     "@number-flow/svelte": "^0.2.2",     "@threlte/core": "8.0.0-next.31",     "@threlte/extras": "9.0.0-next.39",     "canvas-confetti": "^1.9.3",     "countup.js": "^2.8.0",     "easytimer.js": "^4.6.0",     "esbuild": "^0.24.0",     "esbuild-plugin-glsl": "^1.2.2",     "esbuild-plugin-import-glob": "^0.1.1",     "esbuild-svelte": "^0.9.0",     "gsap": "^3.12.5",     "live_svelte": "file:../deps/live_svelte",     "lodash": "^4.17.21",     "number-to-arabic-words": "^1.5.3",     "phoenix": "file:../deps/phoenix",     "phoenix_html": "file:../deps/phoenix_html",     "phoenix_live_view": "file:../deps/phoenix_live_view",     "stats.js": "^0.17.0",     "svelte": "^5.12.0",     "svelte-preprocess": "^6.0.3",     "three": "^0.171.0",     "typescript": "^5.7.2",     "dat.gui": "^0.7.9"   } }

I’ve created this repository for reference: https://github.com/hussienliban/svelte-esbuild-test/


Sun automation with LIFX Virtual Light integration with offsets- Group 7

Breaking change

This PR does not introduce a breaking change for existing users.
Existing users should not experience any disruptions, but they will benefit from the new features added.
Proposed change

This pull request introduces a custom LIFX card for Home Assistant that allows users to control their LIFX lights based on sunrise and sunset times.
Users can enable or disable the automation for sunrise and sunset and set offsets (in minutes) to trigger light switches before or after the actual sunrise/sunset times.
This functionality enhances the usability of LIFX lights by aligning them with natural light cycles.
Type of change

[x] Dependency upgrade
[ x] Bugfix (non-breaking change which fixes an issue)
[x] New integration (thank you!)
[ x] New feature (which adds functionality to an existing integration)
[ ] Deprecation (breaking change to happen in the future)
[ ] Breaking change (fix/feature causing existing functionality to break)
[ ] Code quality improvements to existing code or addition of tests

Additional information

This PR fixes or closes issue: fixes #
This PR is related to issue:
Link to documentation pull request:

Checklist

[ x] The code change is tested and works locally.
[ ]x Local tests pass. Your PR cannot be merged unless tests pass
[ x] There is no commented out code in this PR.
[ x] I have followed the development checklist
[ x] I have followed the perfect PR recommendations
[ x] The code has been formatted using Ruff (ruff format homeassistant tests)
[ x] Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

[ ] Documentation added/updated for www.home-assistant.io

If the code communicates with devices, web services, or third-party tools:

[ x] The manifest file has all fields filled out correctly.
Updated and included derived files by running: python3 -m script.hassfest.
[ ] New or updated dependencies have been added to requirements_all.txt.
Updated by running python3 -m script.gen_requirements_all.
[ ] For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

[ ] I have reviewed two other open pull requests in this repository.

How to find and run the modifications

Locate the CustomLifxCard Code: The modified code can be found in your local repository where you cloned the Home Assistant repository. Look for the component responsible for the Lifx card, www/config/CustomLifxCard.js`.

Run Home Assistant: Start your Home Assistant instance using the standard method (e.g., docker-compose up, hass, or whichever method you typically use). Ensure your browser's console is open to view any potential errors or console logs.

Test the Functionality: Navigate to your Home Assistant UI and add the CustomLifxCard to your dashboard. Use the card to adjust sunrise/sunset settings and ensure the offsets are applied correctly.

Check Console Logs: Monitor the console logs for the current time, sunrise time, and sunset time to confirm that the features are functioning as intended.

Feel free to customize any part of the pull request template or instructions to better fit your project or modifications!

This PR introduces a long HTML snippet that should belong to the frontend side. Can you move it?


python2Packages.pygments: add patch for CVE-2021-27291

Motivation for this change
https://nvd.nist.gov/vuln/detail/CVE-2021-27291
Akin to #117810, except for pygments 2.5, and master. Again I have built successfully with tests temporarily enabled.
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[ ] NixOS
[ ] macOS
[x] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[ ] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 117826 at 306c4657 run on x86_64-linux 1

2 packages marked as broken and skipped:

couchdb
mailpile

1 package failed to build:

opae

14 packages skipped due to time constraints:

fmbt
gnuradio3_7
gnuradio3_7Packages.ais
gnuradio3_7Packages.gnuradio
gnuradio3_7Packages.gsm
gnuradio3_7Packages.limesdr
gnuradio3_7Packages.nacl
gnuradio3_7Packages.osmosdr
gnuradio3_7Packages.rds
hplipWithPlugin_3_18_5
...

28 packages built successfully:

blastem
cloudmonkey
csound-manual
curaByDagoma
cura_stable
ddar
displaycal
dockbarx
global
grass
hplipWithPlugin_3_16_11
hplip_3_16_11
impressive
loxodo
metamorphose2
nixops
ocropus
pdfread
plover.stable
rainbowstream
roundup
scyther
shocco
torchat
trac
tsung
winpdb
xfce.xfce4-dockbarx-plugin (xfce.xfce4_dockbarx_plugin)

Note that build failures may predate this PR, and could be nondeterministic or hardware dependent.
Please exercise your independent judgement.

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.
Result of nixpkgs-review pr 117826 run on x86_64-linux 1

2 packages marked as broken and skipped:

couchdb
mailpile

1 package failed to build and already failed to build on hydra master:

opae: log was empty

42 packages built:

blastem
cloudmonkey
csound-manual
curaByDagoma
cura_stable
ddar
displaycal
dockbarx
fmbt
global
gnuradio3_7
gnuradio3_7Packages.ais
gnuradio3_7Packages.gnuradio
gnuradio3_7Packages.gsm
gnuradio3_7Packages.limesdr
gnuradio3_7Packages.nacl
gnuradio3_7Packages.osmosdr
gnuradio3_7Packages.rds
grass
hplipWithPlugin_3_16_11
hplipWithPlugin_3_18_5
hplip_3_16_11
hplip_3_18_5
impressive
loxodo
metamorphose2
natron
nixops
ocropus
odpdown
pdfread
plover.stable
rainbowstream
roundup
scribus
scyther
shocco
torchat
trac
tsung
winpdb
xfce.xfce4-dockbarx-plugin (xfce.xfce4_dockbarx_plugin)


SFTP write error

Describe the bug
The write file example produces an error:
2024-04-16T13:21:15+0400 info nl.orlandos.citadel.sftp : [Citadel] SFTP connection opened and ready
2024-04-16T13:21:15+0400 info nl.orlandos.citadel.sftp : [Citadel] SFTP requesting to open file at '/flightbriefing/file.txt' with flags 0x00000023
(lldb) po error
▿ {1}(code: SSH_FX_NO_SUCH_FILE, #'No such file')

requestId : 1
errorCode : SSH_FX_NO_SUCH_FILE
message : "No such file"
languageTag : ""

Reproducer Sample
 func testDirectWriting() async throws {
        guard let data = "Hello world".data(using: .utf8) else {
            XCTFail()
            return
        }

        do {
            let file = try await sut?.sftp?.openFile(filePath: "/flightbriefing/file.txt", flags: [.read, .write, .forceCreate])
            try await file?.write(ByteBuffer(data: data), at: 0)
            try await file?.close()
        } catch {
            print(error)
            XCTFail()
        }
    }

(Where sftp is an SSHClient.SFTPClient)
Expected behavior
The file should be written (even if it does not exist as the .forceCreate flag is there). No error should be thrown.
Client (please complete the following information):

Xcode 15.3
Client: Citadel via SPM
Version of Citadel, if applicable: 0.7.1

I expect this to be a documentation issue. Can you try removing the .read flag?

Disregard!
If anybody ever has this problem, please be aware that when writing to (or reading from) a subdirectory, the path must not start with a slash "/"!

Happy to hear you've found it! Thanks for making issues, and also for updating the issue, so that I don't crack my brain on this.

I'm running into the same issue, however I'm confused about what "the path must not start with a slash" means.
My code:
func uploadUsingSFTP(content: String, remoteHost: String, remotePath: String, username: String, password: String) async throws {
    let client = try await SSHClient.connect(
        host: remoteHost,
        authenticationMethod: .passwordBased(username: username, password: password),
        hostKeyValidator: .acceptAnything(), // TODO: Use a secure validator in production
        reconnect: .never
    )

    let sftp = try await client.openSFTP()

    // Open or create a remote file for writing
    let remoteFile = try await sftp.openFile(filePath: remotePath, flags: [.create, .truncate])

    try await remoteFile.write(ByteBuffer(data: content.data(using: .utf8)!), at: 0)

    try await remoteFile.close()
    try await client.close()
}

I tried passing anything to remotePath: /home/user/file.html, file.html -- everything results in the same error:
2024-10-01T03:58:20-0500 info nl.orlandos.citadel.sftp : [Citadel] SFTP connection opened and ready
2024-10-01T03:58:20-0500 info nl.orlandos.citadel.sftp : [Citadel] SFTP requesting to open file at 'file.html' with flags 0x00000018
2024-10-01T03:58:38-0500 warning nl.orlandos.citadel.sftp : [Citadel] SFTPFile deallocated without being closed first
Error uploading HTML file: {2}(code: SSH_FX_NO_SUCH_FILE, #'No such file')

What am I missing?

The .write flag was missing from the openFile call


escaping html in description of rss feed

After getting the latest code as mentioned in https://github.com/joeaudette/cloudscribe.SimpleContent/issues/7 a rss feed is generated but I noticed that the generated feed data is not valid according to W3C Feed Validation Service, for Atom and RSS.

hmm, when I view the source of my feed it is already html encoded so your changes I think would double encode. only validation error I got was about the self link not matching the doc location but that is because I posted it as direct input not as an url. when I remove that it validates but gives a warning that no self link is present.
In SimpleContent the metadescription is not supposed to include html anyway since it is also used for the meta tag. I think rather then doing encoding in the SimpleContent RssChannelProvider it would probably be better in the DefaultXmlFormatter to wrap a CDATA around the description.
Did you try using an actual feed reader after adding the additional encoding? Does it render properly in a feed reader?
I do notice my feed is not sorted correctly, so there is a bug there that I need to look into today along with this issue.

I'm very sorry for bothering you. Yes, you are right it would be double encoded.
I was tricked into this because I only looked at the output using Chrome. Looking at the source of the feed just now I can confirm that everything is escaped in the right way.

I think it might not have actually double encoded. I'm guessing that
new XElement(Rss20Constants.DescriptionTag, item.Description)

probably automatically encodes it if it has characters that need to be encoded and maybe not if you pass in something already encoded.
I'm still going to try wrapping it with CData which I think may be a better solution


Add shard keys to upsert query filter

MongoDB 4.2 requires full shard keys in the filter of upsert query.
https://docs.mongodb.com/v4.2/release-notes/4.2-compatibility/#sharded-collections-and-replace-documents
If we call Model#save to update an existing document on a sharded MongoDB 4.2 cluster without this update, we get the following error:

Failed to target upsert by query :: could not extract exact shard key

So this PR introduces shard_key DSL for document classes to declare shard keys, and add filters for the keys to upsert queries.
shard_key DSL
We can declare shard keys of a document class with shard_key DSL.
For example, if we have User model and make it sharded with age key, we can declare it like the following:
class User
  include MongoMapper::Document

  key :name, String
  key :age, Time

  shard_key :age
end

Its declaration adds { :age => user.age } to filter parameters of upsert query issued on updating existing document like user.save, user.update_attribute(age: 42), or so.
If we use multiple shard keys, we can declare shard_key :key1, :key2, :key3 or so.
Note that if you don't declare shard_key, the behavior doesn't change.
Notes
Note 1:  this PR doesn't touch MongoMapper::Plugins::Modifiers::ClassMethods#upsert.
It is because it is a class method and doesn't have any information about a document. So we can't determine shard keys.
Note 2: this PR doesn't run tests against a sharded cluster because we don't have it on CI now. However, I think we can build it with https://hub.docker.com/r/bitnami/mongodb-sharded/. Please let me know if I should do it.
Note 3: this PR doesn't introduce any DSL to declare indexes of document classes. We need to make indexes with shard keys at first, and have to do that manually for now. This PR is just for sharding, not indexing.

@smtlaissezfaire
Could you review and merge this PR, and consider releasing v0.15.5?
If I have any documents to update, please let me know.

LGTM 👍

Thanks a lot!!!


charts: Move left over prom queries from reporting-operator chart to openshift-reporting chart

CC @EmilyM1 for review

jenkins rebuild

jenkins rebuild

E2E is failing because the Prometheus pod got recreated, and apparently storage settings got reverted. So I'm merging without e2e since integration is working.


Unsupported Vendor XG

Hello,
I'm trying to add my alarm system through the HACS integration but I'm getting the following issue:
Logger: ultrasync
Source: /usr/local/lib/python3.8/site-packages/ultrasync/main.py:184
First occurred: 10:21:33 (1 occurrences)
Last logged: 10:21:33

Unsupported vendor XG

My model is the: NXG64IP
With firmware version: A56P002005-18
Is this platform not supported or am I doing something wrong?

 I've added 2 models now, I was not aware of yours until now.
In order to add you system too, I will need your help (as you're the only one who can test it). I hope that's okay?
To start off, I'll need you to log into the web based page of your alarm panel and save the html file for me to disk. I will probably need a few more things, but the main login page will be a fantastic start. The HTML code is what this tool scraps. I need to see what yours looks like and see how it differs from the other models.
Just to clarify, I want the HTML code, not a picture/screenshot 🙂
If you're uncomfortable posting the contents publicly here, just send it to my email at<EMAIL_ADDRESS>

Hello,
here are login.html (screen before I log in) and index.html (main page).
If you need any more info, please let me know.
html-files.zip

@33Fraise33 I finally merged all of our changes into this Home Assistant main branch. Your xGen support should be good to go! :+1:

@33Fraise33 I finally merged all of our changes into this Home Assistant main branch. Your xGen support should be good to go! :+1:

Thanks I'll give it a try ! I should be able to pull it through hacs now?

Thanks I'll give it a try ! I should be able to pull it through hacs now?

Yup! Pull in the latest updates and give it a go! Let me know how it goes :+1:

Yup! Pull in the latest updates and give it a go! Let me know how it goes :+1:


Could you please compile a PL dictionary?

This is related to the discussion about #20266.
I started digging into cspell-tools but then, at the very beginning, decided to ask you: Could you please compile Polish dictionary for me? You can download it here, both DIC and AFF files. Beware, it's big: 300K word roots plus large affixes base.
I would love to see how does your implementation compare to hunspell.

I just now setup a package on npm:
https://www.npmjs.com/package/cspell-dict-pl_pl
See if that works for you.

It seems like it has installed correctly a aside cspell, cspell-lib, cspell-trie etc. What should I put in "cSpell.language" to make it spell in polish? Seems that neither "pl_pl" nor "Polish" work.

The way I described it, Polish is always on.
If it doesn't load, you will see something like this in the VSCode Output:
[Error - 5:10:59 PM] Request textDocument/codeAction failed.
  Message: Request textDocument/codeAction failed with message: Unknown file format
  Code: -32603

Yes, it is a poor error message.  That needs some work.
If you do a:
npm install -g cspell-dict-pl_pl

Then something like this can be added to your user settings:
"cSpell.dictionaryDefinitions": [
    { "name": "Polish", "path": "/usr/local/lib/node_modules/cspell-dict-pl_pl/pl_pl.trie.gz"}
],
"cSpell.dictionaries": [
    "Polish"
],

You will need to change the path to match the location on your machine.

Example of what it looks like for me:

I don't know what the words mean, so please forgive me if it is something strange.

I am working on a way to make this easier, but for now only edit .json is possible.
I would like to have some UI that allows you to pick which dictionaries you want active.

OK, it is working fine. Thanks. I will try to perform some tests.
Is this compiled dictionary  created using all of the affixes?

All the affixes should be included.
On Fri, 24 Mar 2017 at 19:12, bartosz-antosik<EMAIL_ADDRESS>wrote:

OK, it is working fine. Thanks. I will try to perform some tests.
Is this compiled dictionary created using all of the affixes?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/Jason-Rev/vscode-spell-checker/issues/79#issuecomment-289103394,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AEoDjQHK0HEkq5WhsGwC7hhOOR6INhnEks5rpAeWgaJpZM4MncPV
.

I'm going to close this.  Let me know if you see any issues.


MHC region filtering does not filter MHC region

The preprocessing script (make_finemap_inputs.py) includes a flag to filter out the MHC region from possible credible set regions. However, it only filters out lead variants. If a lead variant is right on the edge of the MHC region ( e.g. 34.1MB), then the window to finemap extends up to half the window to MHC region, so the MHC region effectively gets finemapped.
Is this intended behaviour? In some autoimmune-related phenotypes, about half of the credible sets can have their causal variant/causal variants with largest PIP in the excluded region, so this does pollute the finemapping results somewhat.
If it is not, one solution would be to clamp the regions so that given an MHC region chr6:25e6-34e6 and a possible finemappable region chr6:33e6-36e6 (from lead variant in chr6:34.5e6) the resulting region would be chr6:34e6-36e6.

@Fedja @mkanai what do you think?

Great catch @Lipastomies. This is not intended and indeed we removed the flag in UKBB/BBJ fine-mapping after recognizing this issue. Instead, we're currently removing the region containing MHC post-hoc after the preprocessing process. I will fix this and make an PR soon.

resolved in #45


Removed duplicate line

Fixed https://github.com/Semantic-Org/Semantic-UI-CSS/issues/2

Forgot about that


fix redis cache chat model

Redis cache currently stores model outputs as strings. Chat generations have Messages which contain more information than just a string. Until Redis cache supports fully storing messages, cache should not interact with chat generations.

related to #7722


Lab 15 - Upgrading Defender reverts back

Lab: 15
Task: 01
Step: 03
Description of issue: The step initially allows you to upgrade Defender. However, when you try to save the changes, the upgrade reverts back.

The first requirement is to upgrade your subscription. See example at this link: https://microsoftlearning.github.io/Secure-Azure-services-and-workloads-with-Microsoft-Defender-for-Cloud-regulatory-compliance-controls/Instructions/Labs/LAB_03a_Enable Defender for Cloud on your Azure subscription.html


Discord

What is your discord, or something i could contact you on?

<EMAIL_ADDRESS>

@NexSqaud Please do not post email addresses in issues to prevent spam bots.


Error on start

Following the quick start guide, once I run the last command, I just get this error:
00h00m00s 0/0: : ERROR: [Errno 2] No such file or directory: 'start'
Assistance would be appreciated, this looks like EXACTLY the project I've been hunting for WEEKS, and I'd really like it to work, lol.

Unfortunately, there are multiple programs called 'yarn' and the Ubuntu repositories have favored a different one. Their version of the yarn package manager for node is called 'yarnpkg'. Alternatively, you could install npm first, then use npm to install yarn: 'sudo npm install -g yarn'


Having issues using this library

I was hoping to use this library to build an abnf "parser generator". I was going to use this library to parse the abnf, then use the types from this library to generate a parser for the given abnf language. However, I've been unable to parse a relatively simple statement from an abnf language I'm trying to parse to test with:
    let rule = match rulelist("idl = ws control_section metadata_section shape_section\n") {
        Ok(rule) => rule,
        Err(err) => { eprintln!("{:?}", err); return Err(anyhow::Error::new(err))}
    };
    println!("{:#?}", rule);

I'm getting:
Error: Error(VerboseError { errors: [("idl = ws control_section metadata_section shape_section\n", Nom(CrLf)), ("idl = ws control_section metadata_section shape_section\n", Nom(Alt)), ("idl = ws control_section metadata_section shape_section\n", Nom(Alt)), ("idl = ws control_section metadata_section shape_section\n", Nom(Many1))] })
ParseError { message: "Error(VerboseError { errors: [(\"idl = ws control_section metadata_section shape_section\\n\", Nom(CrLf)), (\"idl = ws control_section metadata_section shape_section\\n\", Nom(Alt)), (\"idl = ws control_section metadata_section shape_section\\n\", Nom(Alt)), (\"idl = ws control_section metadata_section shape_section\\n\", Nom(Many1))] })" }

I'm using linux to run this code, so maybe there is something going on there? It seems like it doesn't ever find a newline character? I like what you're doing with this library and would love to leverage it for my own project, but I'm new to parsing and not sure what's going on here.

Hey, the reason why you get an error is because ABNF does not allow _ in non-terminals.
rulename = ALPHA *(ALPHA / DIGIT / "-")

Using idl = ws control-section metadata-section shape-section\n yields the correct result:
[
    Rule {
        name: "idl",
        node: Concatenation(
            [
                Rulename(
                    "ws",
                ),
                Rulename(
                    "control-section",
                ),
                Rulename(
                    "metadata-section",
                ),
                Rulename(
                    "shape-section",
                ),
            ],
        ),
        kind: Basic,
    },
]

You should also Display the error in line 3 and not Debug it. When you change {:?} to {}, it will print
0: at line 1, in CrLf:
idl = ws control_section metadata_section shape_section
^

1: at line 1, in Alt:
idl = ws control_section metadata_section shape_section
^

2: at line 1, in Alt:
idl = ws control_section metadata_section shape_section
^

3: at line 1, in Many1:
idl = ws control_section metadata_section shape_section
^

Still, this is a bad error message and I understand why you thought it is related to newline. I do not have much time to work on this library currently, but do you mind if I include your test as a unit test? I think that I want to change two things in the future: 1) first accepting - in non-terminals and then yielding a better error message and 2) reworking how errors are displayed altogether. This is a painpoint, because I have not fully understood how Nom works here :-)


fix: ignores some tests if opencl not present.

Codecov Report

Merging #65 into master will decrease coverage by 3.59%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             master      #65     +/-   ##
===========================================
- Coverage     50.22%   46.63%   -3.6%
+ Complexity      949      830    -119
===========================================
  Files            57       57
  Lines          9358     9358
  Branches       1510     1510
===========================================
- Hits           4700     4364    -336
- Misses         4148     4552    +404
+ Partials        510      442     -68


Fixed arguments documentation

Just two two tiny fixes.

Thanks! I did that api change hastily. :+1:


ValueConstants are not JSON serializable

In [1]: from constantly import Values, ValueConstant

In [2]: class Foo(Values):
   ...:     foo = ValueConstant('foo')
   ...:     bar = ValueConstant('bar')
   ...:

In [3]: import json

In [4]: json.dumps([Foo.foo, Foo.bar])
---------------------------------------------------------------------------
TypeError                                 Traceback (most recent call last)
<ipython-input-4-5375b22f7626> in <module>()
----> 1 json.dumps([Foo.foo, Foo.bar])

/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/json/__init__.pyc in dumps(obj, skipkeys, ensure_ascii, check_circular, allow_nan, cls, indent, separators, encoding, default, sort_keys, **kw)
    241         cls is None and indent is None and separators is None and
    242         encoding == 'utf-8' and default is None and not sort_keys and not kw):
--> 243         return _default_encoder.encode(obj)
    244     if cls is None:
    245         cls = JSONEncoder

/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/json/encoder.pyc in encode(self, o)
    205         # exceptions aren't as detailed.  The list call should be roughly
    206         # equivalent to the PySequence_Fast that ''.join() would do.
--> 207         chunks = self.iterencode(o, _one_shot=True)
    208         if not isinstance(chunks, (list, tuple)):
    209             chunks = list(chunks)

/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/json/encoder.pyc in iterencode(self, o, _one_shot)
    268                 self.key_separator, self.item_separator, self.sort_keys,
    269                 self.skipkeys, _one_shot)
--> 270         return _iterencode(o, 0)
    271
    272 def _make_iterencode(markers, _default, _encoder, _indent, _floatstr,

/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/json/encoder.pyc in default(self, o)
    182
    183         """
--> 184         raise TypeError(repr(o) + " is not JSON serializable")
    185
    186     def encode(self, o):

TypeError: <Foo=foo> is not JSON serializable

I would expect Foo.foo to serialize to "foo", Foo.bar to serialize to "bar". In general, for a ValueConstant to serialize to whatever its value serializes to.

I don't think the batteries-included json module supports this.  This answer supports my hunch.  You'd need to provide a custom serializer, json.dumps(.., cls=..).  That's not something that the ValueConstants class can do; it's something that must be done everywhere json.dumps is called.


update recommended CI snippet, add GHA example

If this snippet works as expected in https://github.com/rust-lang/portable-simd/pull/255 (which we can test tomorrow), then this adjusts our README to that nicer script.

Yes this seems to work fine, thanks @bjorn3 for the suggestion. :)
@bors r+

:pushpin: Commit c03575275a56112edacd1c5cd26a8eb2d4763b74 has been approved by RalfJung

:hourglass: Testing commit c03575275a56112edacd1c5cd26a8eb2d4763b74 with merge 5aeff5d9ef3032c6ab618cd346f6cdcfaa46c258...

:sunny: Test successful - checks-actions
Approved by: RalfJung
Pushing 5aeff5d9ef3032c6ab618cd346f6cdcfaa46c258 to master...


Mint reduce_responses doesn't handle all possible responses

Mint's adapter reduce_responses/3 https://github.com/teamon/tesla/blob/cc18e12226ef5b61f19daf7cc85cb8f94ae428b1/lib/tesla/adapter/mint.ex#L327-L340 doesn't handle all possible returns HTTP.stream/2 can return.
The returns missing are:
{:error, request_ref(), reason :: term()}
{:pong, request_ref()}
{:push_promise, request_ref(), promised_request_ref :: request_ref(), headers()}
The last two are just for HTTP2 streams.
More information here: https://hexdocs.pm/mint/1.2.1/Mint.Types.html#t:response/0

@sezaru Thanks for reporting this. Would you be able to provide a PR to fix this?

Hello everyone.
@teamon , in a project I'm working on we bumped on this issue, specifically the missing clause for {:push_promise, request_ref(), promised_request_ref :: request_ref(), headers()}.
To be honest, I'm somewhat lost on how to properly fix this but I would be happy to provide a PR handling those 3 cases if you're willing to enlighten me a bit.
For now, I managed to get our project working with the patch you can see on this branch. Your test suite still pass, but I'm not certain if this is how things were supposed to be done, that's why I didn't open a PR (and because I'm only handling one of the 3 missing cases right now).
Thanks for your effort on this library and let me know if there is anything else I can help with.

@crova Could you open a PR against current tesla master with the necessary changes?

Sure @teamon , the same one I linked above?

Yes, with the patch that fixes the issue :)

I'll open it by tomorrow.
This week has been rough.


Add Not operator for flag enums

Hello. I would request to add Not operator for flag enums.
I hope to be able to write like this code:
style &= !WINDOW_STYLE::WS_THICKFRAME;

@LNSEAB This is now supported 🥳 Let us know if you run into any issues.


Enhance some horse related search results

It seems that a lot of Riding Arenas  are mapped as Horseback Riding Facilities. This may be because some horse related searches don't list Riding Arenas.
I don't know how the feature search exactly works. Therefore, I list here some horse related search results and explain what I think is missing or is wrong with them and how it can possibly be improved:

horseback riding
search result (en)

What is wrong?

Riding Arena is missing, see also more general description

How to fix? (assumption)

Add alias Horseback Riding Arena to presets/leisure/pitch/equestrian.json (already contains terms horseback and riding but this doesn't seem to be enough to get it listed when searching for horseback riding)

horse riding
search result (same for en and en-GB)

What is wrong?

Riding Arena is missing, see also more general description
Horse Racing Track shouldn't be listed here; at least it shouldn't be listed before Riding Arena or Horseback Riding Facility.

How to fix? (assumption)

Add alias Horseback Riding Arena to presets/leisure/pitch/equestrian.json (already contains terms horse and riding but this doesn't seem to be enough to get it listed when searching for horse riding). (Horseback Riding Arena has to be translated to Horse Riding Arena for en-GB.)
Don't know why Horse Racing Track is listed here, see presets/leisure/track/horse_racing.json. Perhaps adding alias Horseback Riding Arena (see point 1) can help to move if below Riding Arena, I am not sure.

horse
search result

What is wrong?

Riding Arena is only at 9th position, should rather be listed near or before Horseback Riding Facility

How to fix? (assumption)

Addng alias Horseback Riding Arena to presets/leisure/pitch/equestrian.json may improve this, I am not sure.

horse racing
search result

What is wrong?

Horseback Riding Facility shouldn't be listed here, but at least Horce Racing Track is listed before Horseback Riding Facility, so this may still be accepable.

How to fix? (assumption)

Don't know, horse racing isn't in presets/leisure/horse_riding.json

horseback
search result

What is wrong?

Horse Racing Track shouldn't be listed here
Motocross Racetrack shouldn't be listed here
Motorsport Racetrack shouldn't be listed here

How to fix? (assumption)

Don't know why these racetracks are listed here

riding
search result

What is wrong?

Nothing :1st_place_medal:

EDIT / ADDITION
horse stable
search result

What is wrong?

Stable (presets/building/stable.json) not listed, see also more general description

How to fix? (assumption)

Add alias Horse Stable to preset Stable

barn & shed
search result

(similar for shed)
What is wrong?

Stable (for horses) not listed. It seems that in the US they sometimes call a horse stable "barn" or "shed", see websites: here and here

How to fix? (assumption)

Add terms horse barn and horse shed to presets/building/stable.json, compare presets/building/cowshed.json and presets/building/sty.json

AFAIK, it is  Horse Riding in British English,  Horseback Riding in US English and  Horse Racing in both, British and US English (see also wikipedia: horse racing). But I'm not a native English speaker either.
Please also note:

The preset for type=route+ route=horse is currently named Horse Riding Route. (Until Dec 2020 it was just Ridng Route.) Maybe it should be Horseback Riding Route in US English, compare  webpage; but I am not sure.
In related issue https://github.com/openstreetmap/id-tagging-schema/issues/437 I suggest using the name Horseback Riding Center instead of Horseback Riding Facility because Facility is too general and ambiguous (e.g. a riding arena can also be seen as a facility), and this probably contributed to many mistaggings.

In summary, if you want to use the long versions of the names, I would suggest:

tag
US English
British English

leisure=pitch + sport=equestrian
Horseback Riding Arena
Horse Riding Arena

leisure=horse_riding
Horseback Riding Center
Horse Riding Centre

type=route+ route=horse
Horseback Riding Route
Horse Riding Route

leisure=track + sport=horse_racing
Horse Racing Track
unchanged

Maybe using the British names as aliases in the presets can improve the search results in case someone searches just for "horse" (instead of "horseback"). I don't know.

leisure=pitch sport=equestrian is one of these outdoor enclosures, right? I think “(horseback) riding ring” or “pen” is the more common term for those in American English, at least among laypeople. “Riding arena” isn’t wrong. However, if a user unfamiliar with equestrian sports sees “arena” and “center” options, I’m not sure they could distinguish between them. They might associate “arena” with a large indoor facility. That said, equestrianism has its own lingo so maybe it’s best to stick to that.
For leisure=track sport=horse_racing, “horse racing track” is perfectly understandable, though “horse racetrack” is the more common term.

Thank you for the clarifications.

if you want to use the long versions of the names

My main intention was to use the a single "prefix" for all horse riding related presets, because  it would solve at least some of the sorting issues listed above: A partial match on a preset name will always be preferred over a match of one of the preset terms.

Would the following make sense?

tag
preset name (US English)
preset alias(es) (US English)
additional preset terms

leisure=pitch + sport=equestrian
Horseback Riding Ring
Horseback Riding Arena
[round] pen, [horse] riding ring/arena

leisure=horse_riding
Horseback Riding Center
Equestrian Facility?
[horse] riding facility

type=route+ route=horse
Horseback Riding Route
/
[horse] riding route

leisure=track + sport=horse_racing
Horse Racetrack
Horse Racing Track
[horse] raceway, [horse] racecourse

Some change / enhancement requests for the new table:

leisure=pitch + sport=equestrian

I would swap name and alias (name=Arena, alias=Ring) because

this article  (linked above by @1ec5 ) correctly says: "Arena This is the most universal term for the location where people ride horses."
according to Google Trends the term "riding arena" is searched for on average about twice as often as "riding ring", not only worldwide but also in the US (in most regiones)
wikipedia calls them mainly "arenas" (or "pens")
the OSM wiki calls them riding arenas, and this cannot be changed to "ring" because British English is used there
all websites which I have listed in https://github.com/openstreetmap/id-tagging-schema/issues/437#issue-1197438977 call them "arenas" and not "ring", see also here (already mentioned above)
in the search results name Horseback Riding Arena will probably be listed before Horseback Riding Center while Horseback Riding Ring would probably be listed after Horseback Riding Center (A before C before R), which may help avoid mistaggings, since mostly riding arenas are mapped
it is easier for British translators to translate Horseback Riding Arena to Horse Riding Arena than to translate Horseback Riding Ring to Horse Riding Arena

possible additional terms: longeing, jumping/dressage arena/ring

leisure=horse_riding

I wouldn't use Facility anymore because it is too general (explained in https://github.com/openstreetmap/id-tagging-schema/issues/437#issue-1197438977)
better aliases or search terms may be

riding stable / stables
horse farm/ranch/park

type=route + route=horse

possible terms: "horse trail", "trail riding" (compare mtb)

I’m not an expert at equestrian sports, so I would be happy to defer to someone who is. The article I linked equates arenas with rings, but the two words are different in other sports, hence my hesitation. There probably isn’t a 100% perfect way to accommodate both experts and laypeople, so either way is fine by me.
The article also distinguishes round pens from arenas, but it’s unclear to me if OSM does. I’ve seen them both mapped as leisure=pitch sport=equestrian – is that correct?

in the search results name Horseback Riding Arena will probably be listed before Horseback Riding Center while Horseback Riding Ring would probably be listed after Horseback Riding Center (A before C before R), which may help avoid mistaggings, since mostly riding arenas are mapped

(Maybe in some regions, but there’s a lot of room for improvement in North America. I probably skip over dozens of unmapped round pens every week for lack of time.)
Preset search results are ranked by edit distance (that is, similarity to the search term) and would only be alphabetized in the event of a tie.

The article I linked equates arenas with rings, but the two words are different in other sports, hence my hesitation.

I admit that this is a problem. But when I looked around the web, I always had the impression that "arena" is used more often than "ring", example page. And I would not make the less used word the main name in iD. (But maybe this was selective perception).

The article also distinguishes round pens from arenas, but it’s unclear to me if OSM does. I’ve seen them both mapped as leisure=pitch sport=equestrian – is that correct?

There is a proposal for leisure=practice_pitch which could be used for [round] pens, but it isn't used for any of them yet (in combination wirh sport=equestrian).

I've now included the proposed name changes (including the suggestions from https://github.com/openstreetmap/id-tagging-schema/issues/413#issuecomment-1129425366). As far as I can tell, this fixes all the issued listed in the original post, except for the racetrack presets showing up when searching for horseback. I'm not 100% sure why exactly these show up (I would assume because they share enough letters to be classified as a partial match), but fixing that would need to be done in iD's code.

Thanks.
https://github.com/openstreetmap/id-tagging-schema/blob/2be67fdc9dffa30e58288af479f62d8f38b001f3/data/presets/leisure/horse_riding.json#L32
should actually be "riding stables". It could also be moved to the aliases as "Horseback Riding Stables".
What I do not understand is that for en_GB "Horse Riding Stables" was added as an alias, but the preset is still not listed when searching for "riding stables":

Why is that?

Support for searching by an alias was added very recently, after the latest v2.20.4 release: openstreetmap/iD@8796a412f8098cde968817e47db928d3cc9d4595. openstreetmap/iD#6139 remains open to track displaying the alias as the name of the matching search result.


storage/datalakestore: Path_Create has duplicate headers with x-ms- prefix

For storage/data-plane/Microsoft.StorageDataLake/preview/2018-06-17
Path_Create the following headers have a duplicate header with x-ms- prefix

Cache-Control
Content-Encoding
Content-Language
Content-Disposition

The documentation for each of these is the same for the corresponding X-MS- header.
This shows up on the documentation reference page too, is this intentional and does setting both of them matter?

cc @ThomasMarquardt


Add first commit for Jaeger auto-configuration module

This is the first attempt to move the code from https://github.com/snowdrop/opentracing-tracer to this repo.
I have various questions about this:

What should the module be named?

I have currently chosen opentracing-spring-cloud-starter-jaeger

What should the module dependencies be?

Currently I only added a single module that depends on opentracing-spring-cloud.
Although this is sensible, it might be overkill for users that just want to introduce instrumentation into plain old Spring MVC apps (with no dependencies on Spring Cloud).
The original code contained separate starter modules, one that depended on opentracing-spring-web-autoconfigure and one that depended on java-spring-cloud.

What is the approach we should follow for "integration" tests?

I have only added Spring tests in the commit, but the original code contained higher level tests in separate Maven modules.
I am looking forward to hearing your input :)
Regards
Fixes: #110

I have currently chosen opentracing-spring-cloud-starter-jaeger

what is the naming convention with starters? Shouldn't -starter be the last word?

Although this is sensible, it might be overkill for users that just want to introduce instrumentation into plain old Spring MVC apps (with no dependencies on Spring Cloud).

do plain old Spring MVC apps work with auto-configuration. To my knowledge auto-configuration works only in spring boot.

What is the approach we should follow for "integration" tests?

Verify that (jaeger) tracer is configured properly

On Tue, Mar 27, 2018 at 6:04 PM, Pavol Loffay<EMAIL_ADDRESS>wrote:

I have currently chosen opentracing-spring-cloud-starter-jaeger
what is the naming convention with starters? Shouldn't -starter be the
last word?

Most likely yes, I'll update it.

Although this is sensible, it might be overkill for users that just want
to introduce instrumentation into plain old Spring MVC apps (with no
dependencies on Spring Cloud).
do plain old Spring MVC apps work with auto-configuration. To my knowledge
auto-configuration works only in spring boot.

That is correct, however I was referring to the fact that there might be
Spring Boot applications that only have use Spring MVC and not Spring
Cloud. In that case it wouldn't make sense to force those users to pull
down all the Spring Cloud dependencies just to get instrumentation of web
requests working.

What is the approach we should follow for "integration" tests?
Verify that (jaeger) tracer is configured properly

I'll need time to check what has been done in the other projects as far as
setting up everything properly.
Thanks!

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/opentracing-contrib/java-spring-cloud/pull/113#issuecomment-376559274,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AELBv-_7xN1EpCE0ktfALI-6wRvK-Ujaks5tilT2gaJpZM4S8zw0
.

Also what is the default reporter? Logging/udp/http?

In that case it wouldn't make sense to force those users to pull
down all the Spring Cloud dependencies just to get instrumentation of web
requests working.

This project should not pull any additional dependencies. But I see your point. Jaeger auto-config does not have to depend on ot-cloud and it should still work, however users have to add both dependencies to  the classpath.

@pavolloffay Sorry I haven't been able to follow up on your review yet... I'm hoping I will be able to do so tomorrow :)

@pavolloffay I addressed most of the points and commented on other :)


There is an animation glitch when zooming from one contentMode to another

I know it's not easy to implement, but older ObjC libraries have these functionality. Right now it doesn't look good when you zooming from scaleAspectFill, to GS.aspectFit. What do you think about this feature?

+1, I have a collection view with a bunch of images (like the Photos app) that have square UIImageViews in aspect fill. When tapping them, I want them to go fullscreen using this lib in aspect fit. But now when tapping them, it's like they go to aspect fit in the source UIImageView and then zoom in. Same with zooming out, they go back to the source UIImageView to aspect fit and then switch to aspect fill after the transition is done.

This problem has been solved, and update to the new version 1.6.1.


validation of set value happens before applying set_parser

I am not sure if this is a bug since I don't fully know what the set_parser function of a parameter is supposed to do. Therefore, a small example below.
Steps to reproduce
Let's imagine we have a parameter class with set_parser=int and vals=validators.Ints(min_value=0)
class test_param(Parameter):
    def __init__(self, name):
        # only name is required
        super().__init__(name, label='test_parameter',
                         vals=validators.Ints(min_value=0),
                        get_parser = int,
                        set_parser = int)
        self._count = 0

    # you must provide a get method, a set method, or both.
    def get_raw(self):
        self._count += 1
        return self._count

    def set_raw(self, val):
        self._count = val

and that we create a parameter:
test = test_param('t1')
Expected behaviour when setting an integer value, like test(2)
setting works as expected
Expected behaviour when setting a float value, like test(2.0)
Same behaviour as for test(2) since the set_parsesr should ensure that 2.0 is cast into 2.
Actual behaviour when setting a float vlaue, like 'test(2.0)'
An error is produced since the validator is not happy.
---------------------------------------------------------------------------
TypeError                                 Traceback (most recent call last)
<ipython-input-11-9027be1cd919> in <module>
----> 1 test(2.0)

~\AppData\Roaming\Python\Python38\site-packages\qcodes\instrument\parameter.py in __call__(self, *args, **kwargs)
    403         else:
    404             if self.settable:
--> 405                 self.set(*args, **kwargs)
    406                 return None
    407             else:

~\AppData\Roaming\Python\Python38\site-packages\qcodes\instrument\parameter.py in set_wrapper(value, **kwargs)
    643             except Exception as e:
    644                 e.args = e.args + (f'setting {self} to {value}',)
--> 645                 raise e
    646
    647         return set_wrapper

~\AppData\Roaming\Python\Python38\site-packages\qcodes\instrument\parameter.py in set_wrapper(value, **kwargs)
    603                                     " that is not settable.")
    604
--> 605                 self.validate(value)
    606
    607                 # In some cases intermediate sweep values must be used.

~\AppData\Roaming\Python\Python38\site-packages\qcodes\instrument\parameter.py in validate(self, value)
    702             context = self.name
    703         if self.vals is not None:
--> 704             self.vals.validate(value, 'Parameter: ' + context)
    705
    706     @property

~\AppData\Roaming\Python\Python38\site-packages\qcodes\utils\validators.py in validate(self, value, context)
    341         """
    342         if not isinstance(value, self.validtypes):
--> 343             raise TypeError(
    344                 '{} is not an int; {}'.format(repr(value), context))
    345

TypeError: ('2.0 is not an int; Parameter: t1', 'setting t1 to 2.0')

I know that it is a bit a weird example. But I came across it when trying to use the built-in do1d function to sweep an integer parameter of an instrument (like number of points of a VNA trace)
As said in the beginning, I am not fully sure what to expect.

Hmn, this is a good question. I can see it going both ways.
On one hand is it dangerous to pass a float to a parameter that expects an int. Its fine in the case of 2.0 but what if one passes 2.5 ?
On the other hand I do see your issue trying to sweep over this using dond as a limitation. Perhaps it would be better to open dond slightly so that one can pass a list or generator of numbers in rather than generating them

I agree that it is not clear what should happen if you try to pass 2.5 to a parameters that expects an integer.
However, my point is rather about the set_parser. What is it used for in general?
Concerning the doNd, I am not so sure how often people would like to sweep an integer value in reality. As mentioned above, the example is not so meaningful.

Hello @simonzihlmann , I am here to try to answer your question What is set_parser used for in general?
set_parser allows you to set a function to transform the input set value to an encoded value sent to the instrument.
Let's take a hypothetical case, without involving an instrument first. Say there are 15 steps in a process, and those can be categorized as 1-9 being initialization, 10-14 being process ongoing and finally 15th is closing. And you want to have a parameter to know which category the process is on and not exactly the step number. This kind of parameter can be written very easily with a set_parser without creating a cumbersome val_mapping.

def set_state(val: int) -> str:
    if val in range(1,10):
        return 'initializing'
    elif val in range(10,15):
        return 'process ongoing'
    else:
        return 'closed'

p = Parameter(name='test',
             set_parser=set_state,
             vals=Ints(min_value=1, max_value=15),
             set_cmd=None)

Within the process code this parameter can be set with integer values and when you want to know weather process is initializing, ongoing or closed you can call this param to check.
This analogy can be extended, when an instrument needs to be set to some particular states for multiple different input values. I can't think of a very concrete example involving as instrument right away but I hope you get a gist of what are the possibilities involving set_parser.

Dear @Akshita07, thanks for the explanation. I see what it is used for thanks to your example. Then it is very similar to a val_mapping?
I think one can close this issue.

Hello @simonzihlmann,
No set_parser is not really similar to val_mapping. Function of set_parser is to perform parsing for the input set values while that of val_mapping is to map the values which either comes from the getting or during setting of the Parameter.
Please feel free to close the issue, if you are satisfied.

Thanks @Akshita07 for the clarification. I clos this issue.


Solve the security issues

Whats wrong
There are two automaticly detected seucrity issues on develop right now

Issue 1
Issue 2

They should be fixed as soon as possible

I think they should be fixed otherwise I will open a new issue for it


added npm-publish.yml file for github actions

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[ ] I have signed the Adobe Open Source CLA.
[ ] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.

@AjazSumaiya let's make sure that this merged to main after the OpenSource team adds the NPM_TOKEN to the repo

Caution -
This Branch shouldn't be merged to main until and unless we have the NPM Token get added to this repository


invalid default value for rust-analyzer.debug.sourceFileMap

I'm seeing this warning from LSP-json:

Is sublime-package.json incorrect or is the default value incorrect?

this was the default value not sure, lemme check

Doesn't seem to be a reason.
"rust-analyzer.debug.sourceFileMap": {

                              "const": "auto",

                              "default": {

                                "/rustc/<id>": "${env:USERPROFILE}/.rustup/toolchains/<toolchain-id>/lib/rustlib/src/rust"

                              },

                              "description": "Optional source file mappings passed to the debug engine.",

                              "type": [

                                "object",

                                "string"

                              ]

                            },

Thats the schema. The type is object or string.

But const ensures that only that value is allowed. See https://json-schema.org/understanding-json-schema/reference/generic.html#constant-values
Not sure what's the reason it's there but removing it should be fine.

I'll remove the const 👍🏽

Fixed in https://github.com/sublimelsp/LSP-rust-analyzer/commit/6b89292c6313efa13c59d06285d48a0e25804b2a


Create pdsb.txt

@Ashpanr Thank you for your request. Could you please give us a reference to a page on the official school website where we can see that the schools offer educational programs which are somehow related to IT and last longer than 1 year. Please, confirm that the email domains pdsb.net is used by students of certain school(s) only, and if there are several schools using the same email domain, please tell us which schools they will be.

@Ashpanr I am sorry, but this request remains unanswered for a while, and with no new information regarding the question above I have to close it without merging. Please reopen if you have the new info. Thank you!


Traceback handling realm_bot update event

This traceback happens in production and happened for basically all the users in the organization:
Message:
Failed to process an event
Cannot read property 'owner' of undefined

Stacktrace:
TypeError: Cannot read property 'owner' of undefined
    at f (static/min/app.577e414b325c.js:1625:565)
       = static/js/bot_data.js line 16 column 20
    at Object.h.update (static/min/app.577e414b325c.js:1626:30)
       = static/js/bot_data.js line 38 column 9
    at h (static/min/app.577e414b325c.js:1520:431)
       = static/js/server_events.js line 94 column 13
    at static/min/app.577e414b325c.js:1527:96
       = static/js/server_events.js line 295 column 20
    at Function.h.each.h.forEach (static/min/common.531c9c89c089.js:219:291)
       = static/third/underscore/underscore.js line 153 column 9
    at k (static/min/app.577e414b325c.js:1526:362)
       = static/js/server_events.js line 299 column 5
    at success (static/min/app.577e414b325c.js:1529:242)
       = static/js/server_events.js line 376 column 17
    at Object.a.success (static/min/app.577e414b325c.js:1008:348)
       = static/js/channel.js line 68 column 16

I can reproduce this by opening two browser windows (one as an admin, the other not), and then editing a bot's name in the admin window.

@timabbott Is this something that can be addressed by someone new to zulip? If yes, where should i look to fix this?
Thanks

Possibly; it's at least reproducible.  You should read the developer tutorials to get a feel for how this sort of real-time sync thing should work.
My guess is that the problem is that we're sending this event too broadly; i.e. it's sending this update to bot_data to non-admin users who don't have bot_data in their initial page_params data in the first place.

Update: The mentioned traceback has been fixed. There is a new error being thrown now:
bot_data__set_can_admin@http://<IP_ADDRESS>:9991/static/js/bot_data.js:19:1
bot_data__update@http://<IP_ADDRESS>:9991/static/js/bot_data.js:47:9
dispatch_normal_event@http://<IP_ADDRESS>:9991/static/js/server_events.js:109:13
dispatch_event@http://<IP_ADDRESS>:9991/static/js/server_events.js:374:20
get_events_success/<@http://<IP_ADDRESS>:9991/static/js/server_events.js:380:13
_.forEach@http://<IP_ADDRESS>:9991/static/node_modules/underscore/underscore.js:153:9
get_events_success@http://<IP_ADDRESS>:9991/static/js/server_events.js:378:5
get_events/get_events_xhr<.success@http://<IP_ADDRESS>:9991/static/js/server_events.js:455:17
wrapped_success@http://<IP_ADDRESS>:9991/static/js/channel.js:68:16
blueslip_wrapper@http://<IP_ADDRESS>:9991/static/js/blueslip.js:217:20
jQuery.Callbacks/fire@http://<IP_ADDRESS>:9991/static/node_modules/jquery/dist/jquery.js:3232:11
jQuery.Callbacks/self.fireWith@http://<IP_ADDRESS>:9991/static/node_modules/jquery/dist/jquery.js:3362:7
done@http://<IP_ADDRESS>:9991/static/node_modules/jquery/dist/jquery.js:9836:5
.send/callback@http://<IP_ADDRESS>:9991/static/node_modules/jquery/dist/jquery.js:10302:8
  blueslip.js:386:9
BlueslipError@http://<IP_ADDRESS>:9991/static/js/blueslip.js:184:16
blueslip_error@http://<IP_ADDRESS>:9991/static/js/blueslip.js:387:15
get_events_success/<@http://<IP_ADDRESS>:9991/static/js/server_events.js:382:13
_.forEach@http://<IP_ADDRESS>:9991/static/node_modules/underscore/underscore.js:153:9
get_events_success@http://<IP_ADDRESS>:9991/static/js/server_events.js:378:5
get_events/get_events_xhr<.success@http://<IP_ADDRESS>:9991/static/js/server_events.js:455:17
wrapped_success@http://<IP_ADDRESS>:9991/static/js/channel.js:68:16
blueslip_wrapper@http://<IP_ADDRESS>:9991/static/js/blueslip.js:217:20
jQuery.Callbacks/fire@http://<IP_ADDRESS>:9991/static/node_modules/jquery/dist/jquery.js:3232:11
jQuery.Callbacks/self.fireWith@http://<IP_ADDRESS>:9991/static/node_modules/jquery/dist/jquery.js:3362:7
done@http://<IP_ADDRESS>:9991/static/node_modules/jquery/dist/jquery.js:9836:5
.send/callback@http://<IP_ADDRESS>:9991/static/node_modules/jquery/dist/jquery.js:10302:8
  blueslip.js:386:9
Error: Failed to handle get_events success
Failed to process an event
bot is undefined at http://<IP_ADDRESS>:9991/static/js/bot_data.js:19 at http://<IP_ADDRESS>:9991/static/js/blueslip.js:184  blueslip.js:184:16

This is so because on receiving a bot update event we try to access the relevant bot but it is not there in the bot_data.js.

I think here we are sending the update event too broadly, am I right @timabbott?

Yeah that seems likely to me.  I guess only the owner and admins should get it?

@zulipbot claim


Models next

This isn't quite ready to merge yet, but I'd like to start getting more eyeballs on this as we move towards merging.

I want to merge this because it's in danger of become the "fix everything" PR, and I want to move back to smaller PRs.


Pixi v6 refacto ts notifications WIP

already exist in the pixi-v6 branch (no change ? @QuentinMallen checked)


Can't find a an option to change Local Machine default from cmd to PowerShell (or PowerShell Core)

I tried removing and readding as well.

What exactly are you trying to accomplish with a switch?

When I interact with my local Windows system, I prefer working with PowerShell, not cmd.
Wanted that to be the default.

Can't you just click on the Powershell connections then to open in your terminal and in the file browser?
The actual reason why cmd is designated as the default on Windows is that Powershell takes forever to start up. All connections that are children of the local machine entry always have to start up the local machine shell first and if that would be Powershell, every action to open any connection would take around one second longer.

May I ask if implementing a 'default sub connection' might be an option.
This would be a more generic approach, in which on clicking on parent connection, you can choose a child that will be executed instead.

I guess if you don't want to use the desktop shortcut functionality for a connection, I could also implement some sort of favorite system where you can mark certain connections as favorites and they are listed somewhere prominently.

Put it on the bottom of the list, this looks like it goes against the grain of the design. Drop it until someone else makes a better argument for this.

Do you make use of the create desktop shortcut functionality for connections?

No, I do not use desktop shortcuts at all - for anything. My screen is usually covered with windows anyway, never found it convenient.
At rare occasions I create shortcuts that I launch using Start Menu / Launcher / PowerToys Run or pin to the taskbar, but mostly I find how to customize the applications I use to do the job I want.

Another aspect to consider is that right now I don't think it would be technically possible to replace cmd with powershell as it is required to launch cmd first anyways to properly configure the UTF8 CHCP mode that will then be used by powershell.
So I will close this issue then


Issues: Added Issue templates

Summary
-Template
Bug report
Report a bug to improve NuttX stability
Feature request
Request an enhancement for NuttX
General Help
Get general support regarding NuttX
Of course, others can be added. !!! :)
-Action
An action for automatically labelling issues
Keywords
Keywords are present in the dropdowns (the user can select more than one option) of the form Bug report and are:
- Linux, Mac, Windows, Other
- all, arm, arm64, avr, ceva, hc, mips, misoc, openrisc, renesas, risc-v, simulator, sparc, tricore, x86, x86_64, xtensa, z16, z80
- Applications, Api, Board support, Build System, Configuring, Debugging, Drivers, File System, Installing, Kconfig, Kernel, Memory Management, Native port, Networking, OS Components, Posix, Sensors, Specific Peripheral

To work, the labels must have the same name as the keywords !!!
So before the merge it is necessary to add them.
Of course these keywords are examples so you can add, edit or delete them.
Creating a label
see https://github.com/apache/nuttx/issues/12748
Impact
none
Testing
CI

@simbit18 done! I think it is working!
https://github.com/apache/nuttx/issues/12842


Training time compare to PyBullet

Hi all, I am new to the dm_control suite. I am doing transfer learning on dm_control since it provides different tasks for a same robot. However, I found that it takes way longer time to train an agent on 'hopper-hop' than on 'Hopper-V2'. Usually, td3 can converge within 1e6 steps on 'Hopper-V2', but it still performs very poorly on 'hopper-hop' after the same amount of steps, what is the intuition behind this? Aren't 'hopper-hop' and 'Hopper-V2' similar kind of problem?

They are superficially similar, but hopper in the Control Suite is a much harder task by design, mainly because it has a lot more variability in the initial state between episodes.
In HopperV2 a tiny amount of uniform noise is added to the joint positions and velocities, whereas in hopper we sample the initial position of each hinge joint uniformly between its limits:

(I don't have a copy of Gym installed that I can easily compare to, but if you do the same you'll see that with Hopper-v2 the initial configuration is much less varied)
Increasing the variability in the initial states makes learning more difficult, but also tends to result in policies that are more robust to perturbations. There are also differences in the reward functions and episode durations that may contribute, but I suspect it's the initial state randomization that accounts for most of the difference you're seeing.


Unable to autoplay on Google Chrome

It cannot be played automatically on Google Chrome, but autoplay worked on Internet Explorer and Edge.

<div class="swiper-wrapper">
  <!-- swiper -->
  <swiper :options="swiperOption" ref="mySwiper" v-if="slideList.length>0">
    <swiper-slide v-for="(slide,index) in slideList" :key="index"><img :src= getImgUrl(slide) class="slide-img"/></swiper-slide>
  </swiper>
</div>

Try change autoplay.delay to 1sec and it will work.
seems like in Chrome autoplay with 0 delay fails because the whole document hasn't been loaded yet.


Failed to read from server connection=&discovery.Typha

I have a issue right below with calico-node in AKS
All the calico pod still running fine but sometimes have some issue below
Error message:
2024-05-26 13:55:01.598 [ERROR][82] status-reporter/sync_client.go 387: Failed to read from server connection=&discovery.Typha{Addr:"<IP_ADDRESS>:5473", IP:"<IP_ADDRESS>", NodeName:(*string)(0xc00080cf20)} error=read tcp <IP_ADDRESS>:35830-><IP_ADDRESS>:5473: i/o timeout myID=0x1 serverConnID=0x11 type="node-status"

2024-05-26 13:55:00.715 [ERROR][80] felix/sync_client.go 387: Failed to read from server connection=&discovery.Typha{Addr:"<IP_ADDRESS>:5473", IP:"<IP_ADDRESS>", NodeName:(*string)(0xc0003083e0)} error=read tcp <IP_ADDRESS>:35844-><IP_ADDRESS>:5473: i/o timeout myID=0x1 serverConnID=0x12 type=""

Your Environment

Calico version: 3.26.3
Orchestrator version (e.g. kubernetes, mesos, rkt): AKS
Operating System and version: 1.29. 2

Here're the logs collect from typha pod and calico-node pod with the related IP <IP_ADDRESS> and <IP_ADDRESS>:
calico- typha ip.11.log
calico-node ip .11.log
calico- typha ip.16.log
calico-node ip.16.log

@fasaxc @caseydavenport
sorry for ping like this but i need help

@nhattien147 Looks like a problem with calico/node being unable to talk to Typha - double check that your network meets Calico's requirements and that the necessary ports are open in the host's firewall: https://docs.tigera.io/calico/latest/getting-started/kubernetes/requirements#network-requirements

@nhattien147 Looks like a problem with calico/node being unable to talk to Typha - double check that your network meets Calico's requirements and that the necessary ports are open in the host's firewall: https://docs.tigera.io/calico/latest/getting-started/kubernetes/requirements#network-requirements

thank for your insight, i will check and get back to you ASAP

@nhattien147 Looks like a problem with calico/node being unable to talk to Typha - double check that your network meets Calico's requirements and that the necessary ports are open in the host's firewall: https://docs.tigera.io/calico/latest/getting-started/kubernetes/requirements#network-requirements

@nhattien147 Looks like a problem with calico/node being unable to talk to Typha - double check that your network meets Calico's requirements and that the necessary ports are open in the host's firewall: https://docs.tigera.io/calico/latest/getting-started/kubernetes/requirements#network-requirements

@caseydavenport Hello, I forgot to mention that this issue occurs intermittently, so I don't think it's related to the firewall or network requests.

this issue occurs intermittently
Sounds like there's something wrong with the networking between your nodes?  calico-node and typha have to run in the host's network (because that's all there is before they set up the pod-network).   Calico can't help you with your node network :)

this issue occurs intermittently

Sounds like there's something wrong with the networking between your nodes? calico-node and typha have to run in the host's network (because that's all there is before they set up the pod-network). Calico can't help you with your node network :)

Hi @lwr20, thanks for your response, Everything is working normally even though we are not doing anything.
Not sure when the issue will happen again.

Shall we close this for now then?  Since:

we don't have a clear repro
we don't think its a calico issue

Shall we close this for now then? Since:

we don't have a clear repro
we don't think its a calico issue

Sure
We can close right now
I will reopen if needed


Gemspec disallows use of the gem with Rails 5

As per the subject: trying to install the gem for Rails 5 application brings out errors:
Bundler could not find compatible versions for gem "rails":
  In Gemfile:
    rails (~> 5.0.0)

    bitpay-rails was resolved to 0.0.2, which depends on
      rails (~> 4.2.1)

Hey @silverdr sorry for the delay getting back to you. I've not been at BitPay for a while now and so have not been managing their code libraries & plugins like before. The person who could probably help you with this is @pieterpoorthuis or @ajp8164 . Best of luck to you with your project!

@ionux - thanks for coming back anyway! Is anyone actually maintaining this code? The repo seems to belong to "bitpay" but nobody responded except you. Judging by the fact that Rails 5 is out there for quite some time - it doesn't look too promising :-(

any update? can we add bitpay to stuff and use it? (nobody devs in rails 4)

@azeemh @silverdr  You can check out my fork over at https://github.com/btcpayserver/bitpay-rails  which should work for Rails 5.  Should work for BTCPay server or Bitpay.
I was able to get it working using this guide: https://github.com/btcpayserver/bitpay-rails/blob/master/GUIDE.md


Drop support for python 3.9.

Suggest to drop support for python 3.9.
Looks like ctapipe has dropped the support for 3.9 and we have failures of unit tests using ctapipe (see https://github.com/gammasim/simtools/actions/runs/8632455850/job/23663893773).
I've tested this locally and everything works fine on 3.11.

OK - this is actually not related but to an issue with mac os packages, see https://github.com/gammasim/simtools/actions/runs/8633310074/job/23666068631#step:11:1328

Done with #860 (forgot to connect this issue with the PR).


Split - Empty merchant field can't be saved when expense can be split in room without merchant

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 1.4.74-1
Reproducible in staging?: Y
Reproducible in production?: Y
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team
Action Performed:

Go to staging.new.expensify.com
Go to #announce room that has members.
Split an expense without merchant.
Note that expense can be split in #room without merchant.
Start another split expense flow.
On confirmation page, click Merchant.
Without entering Merchant, hit Save.

Expected Result:
Empty merchant field can be saved because merchant is not a requirement in room expense (Step 4).
Actual Result:
Empty merchant field cannot be saved when expense can be split in room without merchant.
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

Screenshots/Videos
https://github.com/Expensify/App/assets/115492554/acb7cea9-87f7-412a-9447-1b84f8f5cee2

View all open jobs on GitHub

We think this issue might be related to the #vip-split.

Proposal
Please re-state the problem that we are trying to solve in this issue.
Can't save empty string as the merchant when splitting bills in an announce room.
What is the root cause of that problem?
The merchant is required if the transaction contains a participant with isPolicyExpenseChat property or if the report is in group policy.
https://github.com/Expensify/App/blob/a03fecc80e5326a24644254f682441aa50585347/src/pages/iou/request/step/IOURequestStepMerchant.tsx#L66
In case of announce room, the report is in group policy, so the merchant is required, but the merchant is only required if it's a policy expense chat, so the condition is not 100% correct.
What changes do you think we should make in order to solve the problem?

We can use ReportUtils.isPolicyExpenseChat and ReportUtils.getRootParentReport to check whether the root report is a policy expense chat or not.
const isMerchantRequired = ReportUtils.isPolicyExpenseChat(ReportUtils.getRootParentReport(report)) || transaction?.participants?.some((participant) => Boolean(participant.isPolicyExpenseChat));

We can apply the fix for other pages if it has the same issue.

Splits shouldn't be allowed in Announce. Closing this one, will open another issue to correct that problem once we have consensus.


Utilization of Arrow/Rust Datafusion

Hi, I just read about Datafusion:
https://github.com/apache/arrow/tree/master/rust/datafusion
Would the SQL query planning, etc. be helpful for native_spark?

Of course. SQL is the next big step and I am deciding on the internal data structure of Dataframes. It is most likely going to be an array of arrays. Public API should be the same as Spark or at least should be as close as possible. I have decided to not go with Arrow for base types. However, it will act as intermediate when interacting with other languages like Python, Java, etc.,


Minor change in description (ENGLISH)

fixed one sentence to a more natural form.

[x] I have read freeCodeCamp's contribution guidelines.
[x] My pull request has a descriptive title (not a vague title like Update index.md)
[x] My pull request targets the master branch of freeCodeCamp.
[x] None of my changes are plagiarized from another source without proper attribution.
[x] My article does not contain shortened URLs or affiliate links.

If your pull request closes a GitHub issue, replace the XXXXX below with the issue number.
Closes #XXXXX

Thank you for your contribution.  At this time we have decided not to merge your pull request.  We welcome future pull requests from you.
Happy Coding!


This project is unmaintained, or what?

I see lots of open PRs, no responses. more than 1k downloads/day via npm.

Thanks for writing!!! We've been making an effort to triage new issues as they come up, but haven't had the resources to go through the backlog of old issues yet. https://github.com/mixpanel/mixpanel-node/issues/54 is probably the appropriate place to complain, as it was here first and offers an actual suggestion.

aight, thanks :)

Sorry if that was a bit snarky! We do read and prioritize feature requests, but the best way to get something implemented and released quickly is with a pull request. Code is always welcome.

No problem.
My PR is failing and I'd like some feedback on that: #78

Haha, that sounded snarky too. I think we're all eager here to get some stuff fixed in this module, so let's get crackin'

Cool, taking it over to https://github.com/mixpanel/mixpanel-node/pull/78


odb: log unsupported LEF properties

Don't silently ignore unsupported LEF properties.

You'll have a lot of tests to update


scripts/testing: add a simple e2e-runner script.

Add a simple script which can be used to periodically run e2e tests, for instance from a cron job. The script simply clones or fetches a remote/branch, runs a given set of tests, then collects and publishes the results in a directory.

This is cool
@klihub feel free to drop the set -e plus related || : if you want. I didn't realize -e might not be that good idea here. I'm fine with either approach
LGTM

Okay, I dropped those. It feels safer to make changes in the future without breaking stuff.


dyld extraction failed on IOS 16 ipsw

Hi.
Thanks a lot for all of your work here !
Are you going to add support to the new compression method (LZBITMAP) ?
I'm failing extracting /root/System/Library/Caches/com.apple.dyld/dyld_shared_cache_arm64e.28.dyldlinkedit..

That's the plan, but if Apple doesn't open source the lzbitmap code I'll have to RE it and that will be very difficult due to the vector instructions.

OK
Waiting for updates here :)

That's the plan, but if Apple doesn't open source the lzbitmap code I'll have to RE it and that will be very difficult due to the vector instructions.


Provide (albeit internal/unstable) reference documentation for Internal API

Continuing from reading #2660, could it be possible to add a documentation pattern somewhere on the main website that lists (with a big banner notifying about the instability) the current Internal API?
This way, even rudimentary automation can be done without digging into the source code, some hacking can be achieved, and some velocity can be achieved to start "proper" creation of a user-facing API (using active_workflow's REST API feature as a reference point)

The only thing that comes to mind is the output of rake routes.

Another option is to use the developer tools of your browser to see which requests are made to the server.


File cleanup 2

This is to do some cleanup and simplification of frontend assets for clarity as we start to update third party resources, will be cleaner and reduce possibility of making oversight. Also ever so slightly easier as new devs join the codebase.
Positive Test Case

jQuery UI works (My Resources page works)
Create NetCDF Resource works

GitHub Issues
Fixes https://github.com/hydroshare/hydroshare/issues/3229

@Maurier could you take a look at this PR?

@mrao can you review this PR?


dns/bind: add 3 new DNSBLs

PornAll lets the file grow to 125MB, but Bind performs this very well (about 2GB additional RAM)

@mimugmail this looks finished, safe to merge?

Merge to master is fine, thx :)


DRAFT Build overloads R.Pi / Ubuntu 22

Followed the procedure(s) for building PyZMQ with DRAFT features:
https://github.com/zeromq/pyzmq/blob/main/examples/draft/install.sh
https://pyzmq.readthedocs.io/en/latest/howto/draft.html
Previously a DRAFT-mode v4.3.4 build worked fine under Ubuntu 20 on the Raspberry Pi 4B 4Meg with Python 3.9.6.
Upgraded in-place to Ubuntu 22.04 recently, and it installed Python 3.10.6 removing most installed modules.
Re-installed everything else, then re-ran the procedures documented above.
  Modified Make through progressively lower job limits until Make -j 8 succeeded in compiling libzmq.
You did know that the recommended command encourages Make to generate jobs without limit?
make -j && make install      # --- Did someone accidentally leave out the numeric value for the -j arg?

Yup, make -j should indeed get a number (no number will work on most systems except those extremely resource limited like an rPi, but always good). It would be nice if there were a reliable, portable way to count cpus, but python's os.cpu_count() is probably the best.


Evaluation Form: Evaluation Criteria

User Story
As a challenge manager, in order to inform what evaluators should evaluate the submissions on, I would like to setup evaluation criteria.
Acceptance criteria:

[ ] A challenge manager can setup one scoring criteria at the time in Evaluation Form Creation workflow by providing the following criteria information:

[ ] A checkbox to require evaluators to provide feedback/comments for each criteria

[ ] if checked will display a required open text area for the evaluator

[ ] Radio buttons to indicate scale type, #69 (required field)
[ ] An input field for Criteria title (required field)
[ ] A text field for Criteria details / description (required field)
[ ] A numerical input field for Criteria Points / weight (required field)

[ ] The system validates if an input provided by a challenge manager is a whole number
[ ] The input is used to calculate the criteria score and total score, https://github.com/GSA/Challenge_platform/issues/71

[ ] Radio buttons for scoring type and conditional fields for rating scale options, #68 (required field)

[ ] A challenge manager can add additional criteria and go through criteria setup steps as outlined above for each one
[ ] Created criteria options can be edited and/or deleted before evaluation period starts

Development tasks:

[ ] Task 1
[ ] Task 2

Definition of Done
Doing (dev team)

[ ] Code complete
[ ] Code is organized appropriately
[ ] Any known trade offs are documented in the associated GH issue
[ ] Code is documented, modules, shared functions, etc.
[ ] Automated testing has been added or updated in response to changes in this PR
[ ] The feature is smoke tested to confirm it meets requirements
[ ] Database changes have been peer reviewed for index changes and performance bottlenecks
[ ] PR that changes or adds UI

[ ] include a screenshot of the WAVE report for the altered pages
[ ] Confirm changes were validated for mobile responsiveness

[ ] PR approved / Peer reviewed
[ ] Security scans passed
[ ] Automate accessibility tests passed
[ ] Build process and deployment is automated and repeatable
[ ] Feature toggles if appropriate
[ ] Deploy to staging
[ ] Move card to testing column in the board

Staging

[ ] Usability testing: mobile and desktop (Tracy or Marni)
[ ] Accessibility tested (Marni)

[ ]  Keyboard navigation
[ ]  Focus confirmed
[ ] Color contrast compliance
[ ] Screen reader testing

[ ] Cross browser testing - UI rendering is performant on below listed devices/browsers (Tracy or Marni)

[ ] Windows/Chrome
[ ] Windows/Edge
[ ] Mac/Chrome
[ ] Mac/Safari
[ ] iOS/Safari

[ ] AC review (Renata)
[ ] Deploy to production (production-like environment for eval capability) (dev team)
[ ] Move to production column in the board

Production

[ ] User and security documentation has been reviewed for necessary updates (Renata/Tracy/Dev team)
[ ] PO / PM approved (Jarah or Renata)
[ ] AC is met and it works as expected (Jarah or Renata)
[ ] Move to done column in the board (Jarah or Renata)

Figma link (see CM Evaluation): https://www.figma.com/design/VfdBFG8ShVnOStdSNYy9fR/Challenge.Gov-Component-Library?node-id=909-27788&t=bN3FSfpATePzF43T-0

10/21/24 Backlog Refinement Discussion:

Criteria title field and criteria delete button will be pulled out from the accordion button as separate components:

Accordion button label will say: Criteria 1, Criteria 2, etc
Criteria title field will be the first field within expanded accordion
Delete button will be at the bottom of expanded accordion, above Add Another Criteria button

If there are any field validation errors within accordion, it will not allow to collapse and will show an error message indicating the error

Moving testing feedback from #61 to this appropriate user story:

When another criteria is added auto-collapse the previous criteria

@r-bartlett-gsa
Usability Feedback

Change page title to "Editing Evaluation Form"
Form element titles should be bold.
Should the criteria accordion default to open when it's only one or on the most recent one?
Currently, you can add new criteria without completing the original. Should this be allowed?
Criteria Points/Weight and Scoring Type should have same font type and style as Criteria Description, Criteria Title etc.
Criteria Points/Weight text box should sit below title.
Scoring Type should list horizontal like Scale Type radio buttons.

Feature Specific A11y Feedback

Guidance (?) is missing some fields and it's functioning.
When keyboard is focused on any form elements and the user clicks Enter on keyboard, the form saves and takes the user to the confirmation page. For example: Keyboard tab to Step 2 / Require evaluators...check box. If user clicks Enter on the keyboard, the form saves and goes to confirmation page. Move guidance outside of  or else is functions as the checkbox selector and not guidance.
Add back breadcrumb above page title.

Thank you @mhotch24
Can you please provide some additional information for the following:

When keyboard is focused on any form elements and the user clicks Enter on keyboard, the form saves and takes the user to the confirmation page. For example: Keyboard tab to Step 2 / Require evaluators...check box. If user clicks Enter on the keyboard, the form saves and goes to confirmation page.

What should happen instead when the user clicks enter?

Move guidance outside of or else is functions as the checkbox selector and not guidance.

Should the tooltip icon be moved outside of checkbox selector?
Besides those items, most of your feedback will be moved to Fit & Finish work.

@r-bartlett-gsa

It depends on what item they are focused on. But currently, most times when I press enter it will save. Happy to demonstrate.
Correct, the tooltip icon should be moved outside the checkbox selector.

@stepchud Please address the following feedback:

When keyboard is focused on any form elements and the user clicks Enter on keyboard, the form saves and takes the user to the confirmation page. Instead when the user clicks enter it would allow the user to do the specific task they are focused on, for example:

Select a challenge would activate the dropdown
The checkbox would activate or deactivate the checkmark

Move the tooltip icon outside of checkbox selector
When another criteria is added auto-collapse the previous criteria
Criteria Points/Weight text box should sit below title

@r-bartlett-gsa updates on fails in the document for your review.

@stepchud Please address the following feedback:

✅ Move the tooltip icon outside of checkbox selector
✅ When another criteria is added auto-collapse the previous criteria
✅ Criteria Points/Weight input field should sit below title
✅ Remove criteria points field placeholder text, it's not necessary
✅ ~Removing a criteria requires a removal confirmation modal~

@r-bartlett-gsa all of these tasks are now ready to test


Create a new branch oh-pages

We need a new branch for deployment to the production stack.
cc @batpad

This was done


Numpad Enter/Return activates normal Enter/Return events

What are you experiencing an issue with?

[ ] Aurora
[ ] Aurora supported game, (Fill in the game)
[ ] Aurora Wrapper
[ ] Aurora Profile
[ ] Aurora supported device, (Fill in problematic devices)
[ ] Aurora Scripts
[ ] Aurora Updater
[x] Aurora Lighting issue
[ ] Other, (Fill in another issue here)

What kind of an issue is it?

[ ] Crash
[ ] Performance problems
[x] Visual bug
[ ] Localization issue
[ ] Enhancement suggestion
[ ] Device issue
[ ] Other, (Fill in another type of issue here)

Expected behavior:
Numpad Enter/Return is getting used.
Actual behavior:
Enter/Return is getting used.
How often does this problem occur?
Every time
Please describe the steps to reproduce this issue:
The issue can be reproduced by doing following steps:

Enable Interactive Layer with e.g. Key Fade
Press Numpad Enter/Return

What is the version of Aurora you are experiencing this issue with?
My version is... beta 0.6.1
Does the previous version of Aurora have this issue?
The previous version, (beta 0.6.0b), did have this issue.
Please include any logs, screenshots, or files that are related to this issue:
N/A

This is something we cannot do anything about as all the information we get when the key is pressed in this case is that enter has been pressed. There is no way to differentiate between the numpad enter and the normal enter.

@simon-wh Well it is possible, because the hook have an flag set for that. So I need to create an pull request in the GlobalMouseKeyHook repo, so the API expose the flags?

If you can get it working then go for it. I was just going with what I was aware of before as currently I'm not able to do any investigation into it right now.

Do you prefer to include the repo like ColorBox or updating the original?

@DogeAmazed Well, do you want to setup a PR for the original repo and include the project here until the changes are merged?


You know, the kw=value syntax isn't too bad, maybe put it in place when stuff is easily readable with it

I'm just gonna close this since it feels unneccessary and I can't find any instance of this style not being used anymore (in single line function calls, that is; in multi-line ones it still looks ugly)


Unknown HTML attributes passed to the DOM (v4.0.3)

## System:
 - OS: macOS 10.14.1
 - CPU: x64 Intel(R) Core(TM) i9-8950HK CPU @ 2.90GHz
 - Memory: 2.02 GB / 16.00 GB
 - Shell: 5.3 - /bin/zsh
## Binaries:
 - Node: 10.12.0 - ~/.nvm/versions/node/v10.12.0/bin/node
 - Yarn: 1.10.1 - /usr/local/bin/yarn
 - npm: 6.4.1 - ~/.nvm/versions/node/v10.12.0/bin/npm
## npmPackages:
 - babel-plugin-styled-components: ^1.8.0 => 1.8.0
 - styled-components: ^4.0.0 => 4.0.3

Reproduction
https://codesandbox.io/s/o15z2r013y
Steps to reproduce
I haven't really had time to dig down into what causes this exactly, my best guess is that it's the React.forwardRef?
Edit: Was not because of forwardRef but seems to because of React.createElement? 🤔
Expected Behavior
Unknown attributes/props should not be passed to the DOM element
Actual Behavior
Unknown attributes are added on the DOM element which causes React to log errors

This is intended behaviour :) when a component is wrapped instead of an element being used we don't filter your props.
I'd recommend you to always create element StyledComponents by default as best practice and wrap components only when necessary.
When you then wrap a component you'll have to take care of filtering props yourself.

Huh interesting... didn't know that!
What would be the best strategy if you want to exclude known props from being passed to the DOM element? Eg. <Div textAlign="center" width="50%" />

Any update here? Don't want to create a custom component to wrap my styled-components only for filtering the props. So, what is the easiest way? My divs are spamming my source code.

@alexandernanberg @iDuuck
If I'm understanding you both correctly, there is already a solution to this. I had to go digging in the issues to find it but it is already answered elsewhere.
See https://codesandbox.io/s/wkxq1v5ozw for amended code to your original question.
In short, you can do something like the following to avoid passing down the justifyContent prop.
const Grid = styled(({ justifyContent, ...props }) => <Tag {...props} />)({
  display: "flex",
  flexWrap: "wrap"
});


Add log file so that user can share it when app crashes

Check out https://www.npmjs.com/package/electron-log

Added in 0.1.6


Write a transformer to create better type names for configurations using LLM

Currently autogenerated configurations can sometimes have not-so-readable type names. We want to use LLMs to produce more meaningful type-names
Before
type T1 {
  name: String
  age: Int
  gender: Gender
}

type T2 {
  name: String
  address: Address
  reviews: [Review]
}

After
A simple instruction like below to chat gpt can produce a more meaningful configuration

Generate better names for T1 and T2 and produce a new schema file with the new names.

type Person {
  name: String
  age: Int
  gender: Gender
}

type Business {
  name: String
  address: Address
  reviews: [Review]
}

Technical Requirements

It should work with very large configurations.
It should ensure there are no conflicts.
No information should be lost, such as comments, directives etc.
Should be able to plug any LLM API

Additional Information

Transformers are written over here: 	https://github.com/tailcallhq/tailcall/blob/main/src/core/config/transformer/improve_type_names.rs
Start Locally by using Ollama: https://ollama.com/
Use APIs documented here https://github.com/ollama/ollama/blob/main/docs/api.md

Proposed Solution

Update improve_type_names transformer to also take in additional "hints" for each type name.
The hints are going to be in the form of:type OriginalName: String; // Like T1
type AIGeneratedName: String; // Like Business or Person
HashMap<OriginalName, Vec<AIGeneratedName>>

At the time of name resolution or a name conflict, if a name hint is provided that name is going to be preferred over its own name resolution algorithm.

Sample Prompt for OLLAMA
{
  "model": "llama3",
  "system": "Given the GraphQL type definition below, provide a response in the form of a JSONP callback. The function should be named \"callback\" and should return JSON suggesting at least five suitable alternative names for the type. Each suggested name should be concise, preferably a single word, and capture the essence of the data it represents based on the roles and relationships implied by the field names. \n\n```graphql\ntype T {\n  name: String,\n  age: Int,\n  website: String\n}\n```\n\n**Expected JSONP Format:**\n\n```javascript\ncallback({\n  \"originalTypeName\": \"T\",\n  \"suggestedTypeNames\": [\"Person\",\"Profile\",\"Member\",\"Individual\",\"Contact\"\n  ]\n});\n```",
  "prompt": "type T {title: String, body: String, userId: Int}"
}

/bounty 200

/attempt #2200

/attempt #2200

Canceling my attempt the model isn't as reliable and it's slow with generating responses, developing this require more time waiting for responses and making sure that the model is always responding with the correct format specially with large configs.
If anyone want to build on my closed PR feel free.

@tusharmath Can we use services that already host llama for quick development, for example:

https://openrouter.ai
https://www.lepton.ai/playground/chat/llama3-70b

The only drawback of those services is that they use the OpenAPI ChatGPT API format. But you can use the API with other services or local hosted versions in the future.

Yes. We could.

/attempt #2200


Add aws_cloudformation_stack_set_instance resource

Description of your changes
Fixes #1078
Related #26
This PR adds aws_cloudformation_stack_set_instance resource.
I have:

[x] Run make reviewable test to ensure this PR is ready for review.

How has this code been tested
Tested locally and via Uptest.

/test-examples="examples/cloudformation/v1beta1/stacksetinstance.yaml"

/test-examples="examples/cloudformation/v1beta1/stacksetinstance.yaml"

/test-examples="examples/cloudformation/v1beta1/stacksetinstance.yaml"

Thanks @sergenyalcin, lgtm.
My understanding is that we have also validated this resource via upjet, right? If so, could you please also update the description with a reference to the successful uptest run?

Added to the description.


[WIP] HTTP/1.1

This pull request tracks development of hyper's HTTP/1.1 implementation. Note that much of this is really, really early work, and is likely to change substantially before release. However, this is open-source, so the least I can do is do this development work in public.
Feedback always appreciated!
Here's the bare minimum of outstanding things I need to do before I want to merge this:

[x] Connection management. We should understand Connection: close and friends.
[x] Sending generators for bodies (chunked upload!)
[x] Sending files for bodies (maybe chunked upload, who knows!)
[x] Chunked responses
[x] TLS
[x] Certificate verification
[x] Send the 'Host' header automatically!
[x] 100% test coverage, including integration tests

Some other stuff we need, but not necessarily right away:

Plaintext proxy support
CONNECT proxy support
TLS-encrypted proxy support
Basically any goddamn thing to do with stupid proxies
Upgrade handling
Socket extraction (an acceptable API for releasing a socket from a HTTP response or connection)
Expect: 100 continue processing.

The outstanding chunked work can be completed by extending the read_chunked function to take an amt parameter that provides an upper bound on the size of the read. This is just like the stuff that got implemented in urllib3, which will turn out to work really well.

Alright, I think I have completed all my tickboxes.
I want to write some release tests before I merge this, but I'm beginning to think this is nearly done. There are still some outstanding work items for cleaning up:

[ ] We reach into hyper.http20 for a few things (exceptions etc). These should be moved to hyper.common instead.
[ ] Some of the methods aren't quite named the same (getresponse() vs get_response()). For now, let's move to the slightly better names on the HTTP/1.1 classes.
[ ] HTTP/1.1 responses have a few extra methods that I should really support on HTTP/2 for the purposes of the abstraction layer. The obvious one here is read_chunked, which should at least be easy to implement for H2.

These failures are difficulties with rabbitmq's APT repository, which we only hit when we try to build nghttp2. They're intermittent, and annoying.

Sadly, at this point I need to reconcile the different header handling logic between the HTTP/2 layer and the HTTP/1.1 layer.

This turns out to be really painful, because the HTTP/2 layer deals with headers as unicode strings and the HTTP/1.1 layer currently does so with bytestrings. I think I can make this work by adding a unicode interface to the HTTPHeaderMap, but it's really painful. =(

Ok, I think the series of commits I just put up solves that problem. It simultaneously cleans and dirties the API, which is weird.

@sigmavirus24 @shazow Is there any advantage in merging-and-releasing this block of code before I put a compatibility layer in front of it?

No dis-advantage. :)
You're infinitely more likely to never release it if you wait, vs if you release.

Without the compatibility layer, people might start testing it and using it so you get feedback sooner. That's the only advantage I can think of.

Ok, screw it, I'm going to merge this. I'll make a release that contains only this change on top of v0.2.2 (which I've just released), so people will always have a previous-stable-version to move to if for some reason this breaks them.
Deep breath people, let's merge this 71-commit monster!