VERY minor mistake in Poetry Club Door Policy exercise

Hi guys, this is a very minor thing, but I noticed 2 of the test descriptions have a small mistake. I actually did correct it locally in my code, but I'm not yet comfortable sending a PR and I haven't even set my Node environment up, so I'll just list the descriptions in question with my suggestions:

Test
Current Description
Suggestion

Test 2
"it outputs takes the first characters"
"it takes the first characters"

Test 8
"it outputs takes the first characters"
"it takes the first characters"

If you just want to fix typos like this, you can navigate to the file on GitHub and click on the edit button (pencil icon). It will automatically do all the needed things for you and point you towards submitting the PR after you are done editing. Want to give it a try?

Oh, I'm so sorry, I went out to try it and just realized that the repository version is a bit ahead of the website, and that the problem is already taken care of in it.
So I guess the site should update soon, right? Again, not really comfortable closing the issue myself since I'm not 100% I understand how things work, lol. I'm sorry if this was just a waste of time.

Yes, there was an update to the exercise recently. You can get the new version on the website, when you click on the "outdated" warning sign or the "see what changed" banner.
It's perfectly fine if you close an issue that you opened and that is no longer relevant. I will do this now.


Where is the packet of the little pellets?

What packet is for the little pellets? the 1 mass cells?

Can you explain your question little more? There is no special packets for any little cells, not sure what you mean.

https://gyazo.com/fb276832a09cf9a4de1ce92acaf53ac3 those ones

There is no any special packets for them.


Add initial unit test framework, MappedDict tests

Platformio uses the Unity test framework:

http://www.throwtheswitch.org/unity
https://github.com/ThrowTheSwitch/Unity

I've added some basic tests to the MappedDict utility as a reference and starting point.
Command to run unit tests locally: pio test -e native -v. I've also added unit tests to the GitHub workflow so they run automatically.

I had to move MappedDict.hpp from  src/ to src/libs/MappedDict/, it's the simplest option to how platformio sets up the unit test environment: https://docs.platformio.org/en/latest/plus/unit-testing.html#shared-code
i.e. we don't want to compile the entire firmware to test a simple header file, and the firmware won't compile under the native architecture

i just saw it uses "String" from Ardiuno... maybe add a copy of WString.h/cpp in tests/ and include conditionally?

It would make writing tests just so much faster when you don't have to upload each time...

Yeah, with a bit of more targeted includes this would work:
//#include "inc/Globals.hpp" // we don't need globals in util classes
#include "../Configuration.hpp" // we probably shouldn't require this in util classes
#include "Utility.hpp" // this is should be split in math+debug stuff
#include "DayTime.hpp"
#include <WString.h> // just load String, not ardiuno
#include <stdlib.h> // strcat etc
#include <math.h> // floating point

@anjok

It's best practice to keep PRs small and with only one major change (or a couple minor changes bundled together). That way they are easily reviewable and there is less change for conflicts when rebasing/merging. We appreciate the suggestions, perhaps we can incorporate them into a future change!
Native tests are really only useful for testing general code, most/all tests should be run on HW to ensure that we get the correct functionality with the HW that we are targeting. As you have seen 8 bit AVR can sometimes differ quite significantly from x86_64!
If possible, could you try to avoid having multiple comments in quick succession to another? It's much preferable to have each comment represent a single idea/suggestion rather than stream-of-conscious comments. Thanks :smile:


update python build to use src instead of sample-apps

Remove the collector as part of the build as well.

@codeboten it is not working fix


Metadata breaks when paging is just %d / %d

Description
Metadata gets interpreted as a slide when the paging field starts directly with %d (and other chars).
How to Reproduce

Put this at the top of some p.md file:

---
author: You
date: 2023 07 06
paging: %d / %d
---

Save it and run it with slides p.md
You should see author: You date: 2023 07 06 paging: %d / %d as the first slide, and the default Slide 1 / 1 at the bottom.

OS: Arch Linux
slides Version: 0.9.0-2

workaround: use double-quotes: "%d / %d"


[SDS-934] no wires fails for hw backends

When no wires are given initially, we do not add dummy wires for hardware backends, otherwise we end up with only dummy wires
Added unit test for this case

Close because branch was renamed


[tests-only] [full-ci]Adjust expected to fail for file target issue

Description
This PR

adjusts the tests related to file_target issue
adds failing tests to correct issue
adjusts line number changed by this PR https://github.com/owncloud/core/pull/39137

Related Issue

https://github.com/owncloud/ocis/issues/2133

Motivation and Context

How Has This Been Tested?

locally
CI

Screenshots (if appropriate):
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Technical debt
[x] Tests only (no source changes)

Checklist:

[ ] Code changes
[ ] Unit tests added
[ ] Acceptance tests added
[ ] Documentation ticket raised:

@SwikritiT this looks good and CI is going to pass.
Please squash the commits - we don't want to have commits that add the accidental file and then delete it.


run selected text

Does this issue occur when all extensions are disabled?: Yes/No

VS Code Version:
OS Version:

Steps to Reproduce:

type the code in any file

Node
import puppeteer from "puppeteer";
const fs = require('fs');
2. selected all code.and then ( run selected text )
3. error in terminal:

this is an example
if a commandline need much time.
the code after will lost.
### Tasks

I run it in win10 vscode

Thanks for creating this issue! To help narrow it down, please take the time to follow below steps. Thanks a lot and happy coding 🙏
Is the issue caused by an Extension?
Stop VS Code and from the command line (NOT the integrated terminal in Code), execute: code --disable-extensions and try your steps again to see if it reproduces. If it still reproduces, jump to the next chapter.
If you see it is an issue with the extension, please run the command Start Extension Bisect and follow the instructions to find the extension that is causing this issue.

Please report the issue to the extension causing this.
Is the issue caused by VS Code Core?
If the issue is not caused by an extension, it is maybe caused by your configuration. Try to run code --disable-extensions --user-data-dir <directory> where <directory> is an empty folder. This will ensure Code is starting with a fresh data directory, e.g. no specific settings and without any extensions running.
If it still reproduces, it was maybe fixed already in our nightly release. Please download from https://code.visualstudio.com/insiders/ and see if you can reproduce the issue.
Finally, to help us narrow down what change caused the issue, please run the following command to find the build. It will start previous releases of VS Code insiders to see where the regression was introduced:

npx --yes vscode-bisect@latest
follow the instructions until you found the offending build
report back the commit range in this issue

Thanks!

Thanks for you reply
error persists
I run the code in node.exe(not in vscode)
I paste the follow code and run many times, no error
searchSelector = "div.MmsUiMaterialModal___tab___1dQI92-24-0 > div.MmsUiMaterialModal___search___1pW_I2-24-0 > div > div > div > div > div.IPT_inputBlockCell_5-66-0 > input"

I start vscode by your sugguest
code --disable-extensions --user-data-dir G:\gitsrv\pdd

type node in terminal
copy the code and paste in terminal,sometimes may be have error.
let searchSelector = "div.MmsUiMaterialModal___tab___1dQI92-24-0 > div.MmsUiMaterialModal___search___1pW_I2-24-0 > div > div > div > div > div.IPT_inputBlockCell_5-66-0 > input"
if above not error.
copy the follow code and paste ,run many times. you will see error.
searchSelector = "div.MmsUiMaterialModal___tab___1dQI92-24-0 > div.MmsUiMaterialModal___search___1pW_I2-24-0 > div > div > div > div > div.IPT_inputBlockCell_5-66-0 > input"

environment

The error only in node.
python,powershell,cmd ... all is ok.

my version is up to date

i create  a new environment
setup win10,nodejs,vscode in vmware
and then test.
i find error less.  but have.
eg.
node 1.js  is ok in terminal
type node in terminal, copy 1.js content .you will find error.
the code runnning is not same as 1.js

eg.

here's what happens for me:

it indicates what to do about this:
Uncaught:
SyntaxError: Cannot use import statement inside the Node.js REPL, alternatively use dynamic import
> const fs = require('fs');

I think javascript like this.
const puppeteer = require('puppeteer');
node terminal must use javascript
You use TypeScript
import puppeteer from "puppeteer"

Sorry, i'm having a hard time understanding what your issue is.
Is it that you have certain text selected and that text isn't fully pasted / run in the terminal?

Sorry, I asked this question twice,
This one is the same as the link below.
Can this question be closed？
https://github.com/microsoft/vscode/issues/185591


Macros in generated changelog should be escaped

Here is a snippet from a failed SRPM build log:
2022-03-18 15:41:39.918 commands.py       DEBUG  Command: git log --no-merges --pretty=format:- %s (%an) 0.26.0..HEAD --
2022-03-18 15:41:39.976 logging.py        DEBUG  - Add workaround for broken documentation builds (Nikola Forró)
2022-03-18 15:41:39.976 logging.py        DEBUG  - Fix typo in valid section name (Nikola Forró)
2022-03-18 15:41:39.976 logging.py        DEBUG  - Fix parsing issue in rpmdiff checker (Nikola Forró)
2022-03-18 15:41:39.976 logging.py        DEBUG  - Improve usage example (Nikola Forró)
2022-03-18 15:41:39.976 logging.py        DEBUG  - Fix parsing of %dump output (Nikola Forró)
2022-03-18 15:41:39.976 logging.py        DEBUG  - Remove workaround for docker in Github Actions (Nikola Forró)
2022-03-18 15:41:39.976 logging.py        DEBUG  - Warn the user about a potential rename (František Nečas)
2022-03-18 15:41:39.976 logging.py        DEBUG  - Fix typos in section names (Nikola Forró)
2022-03-18 15:41:39.976 logging.py        DEBUG  - Replace hardcoded references to master (Nikola Forró)
2022-03-18 15:41:39.996 commands.py       DEBUG  Command: git describe --tags --long --match *
2022-03-18 15:41:40.006 logging.py        DEBUG  0.26.0-9-g7d1c996
2022-03-18 15:41:40.012 changelog_helper.py DEBUG  Setting Release in spec to '1.20220318154140012289.pr886.9.g7d1c996'.
2022-03-18 15:41:42.480 specfile.py       ERROR  Rebase-helper failed to change the spec file: Failed to parse SPEC file: error: /tmp/tmpzg6j_lqn: line 110: %dump: unexpected argument

Note that the generated changelog contains %dump (rather than %%dump) and that leads to unparseable spec.

Closing as duplicate of #1521 (even this one was opened first :-) )

Thanks for reporting @nforro, sorry I didn't notice your issue before I created mine.


chore: improve eslint setup

The aim of this PR is the solve the following points:

get rid of WARNING: You are currently running a version of TypeScript which is not officially supported by @typescript-eslint/typescript-estree. warning
allow for type linting
remove blacklisted packages https://github.com/dendronhq/dendron/blob/master/.eslintignore#L6-L8
maybe add https://github.com/supermacro/neverthrow#recommended-use-eslint-plugin-neverthrow

Pull Request Checklist
If you are a community contributor, copy and paste the PR template from Dendron Community PR Checklist and add it to the body of the pull request.
If you are a team member, copy and paste the template from Dendron Extended PR Checklist.
To copy the template, click on the Raw button on the gist to copy the plaintext version of the template to this PR.

@kevinslin yarn lint reports now:
✖ 166 problems (124 errors, 42 warnings)
  35 errors and 0 warnings potentially fixable with the `--fix` option.

I still need to fix some errors to make the ci work. additionality to that shall I take on the next step and cleanup all the rest of the erros from the lint command?.

I still need to fix some errors to make the ci work. additionality to that shall I take on the next step and cleanup all the rest of the erros from the lint command?. And further, are there plans to use the lint command somewhere like inside CI e.g. https://github.com/facebook/docusaurus/blob/main/.github/workflows/lint.yml

first tenant is to not add more friction to the dev process. would not introduce the lint command unless it can reliably detect new issues.
do lint errors currently prevent commit/push hooks? if so, then we'll need to fix. if not, would also split that off into a separate pr


Logs default behaviour - warning + error logs enabled for all channels

At the moment we dont see error and warning logs if nor explicitly enabled by channel config...
Enable error and warning logs for all channels as default behaviour. If channel config is provided, it would override default behaviour...

My suggestion is use current configuration but with different behavior:
"logging": {
    "configurations": [
      {
        "name": "standard",
        "on": true,
        "verbosity": "ERROR",
        "channels": [
          {
            "name": "SUMMARY",
            "verbosity": "INFO"
          }
        ],

let's use verbosity as default one for all channels and then we can use channels configuration to override it for specific channel.


python-itk: module 'itk' has no attribute 'GPUImage'

I want to use the GPU based itk for registrdation. Thus, I compile the itk from the source code, and set the ITK_USE_GPU to ON. The compiling is OK.

The itk can be imported in python:

import itk
itk.Image[itk.F, 3]
<class 'itkImagePython.itkImageF3'>

However, when I want to import the GPU module, bug is reported:

itk.GPUImage[itk.F, 3]
Traceback (most recent call last):
File "", line 1, in
File "D:\Anaconda3\envs\ITK_gpu\lib\site-packages\itkLazy.py", line 48, in getattribute
value = types.ModuleType.getattribute(self, attr)
AttributeError: module 'itk' has no attribute 'GPUImage'

Also, module 'itk' has no attribute 'GPUDemonsRegistrationFilter'.
How can I use GPU based itk for registration in python? Could somebody provide a demo?

There are alpha Python packages available on Linux as described here and demo here.


Local cside

@freddydk Hi, do you think you could accept something similar to be present in the foundation?
I am using it as an override on daily basis. It works really great. I would like to have it available by default and to be able to say just -e exportClientFolder=Y (and eventually specify also -e exportClientFolderPath=[some_path]) and export the client folder automatically and add the preconfigured exe file. Actually, this is where I have doubts - I expect you won`t like it as I am creating a new exe file.
Please, I would like to hear your opinion.

Sorry Jakub, I am not going to merge this PR
Any increased support for CSide will have to be done outside the images.

OK


Please add the ability to view Github raw files

Is there a reason for not supporting github? I couldn't find where in your code github is restricted, but for some reason this extension doesn't work for Github raw files

Hello 👋🏻
This limitation is documented in the readme. Feel free to upvote the linked bugs on the Firefox and Chrome issue trackers. 😉

That's unfortunate
Thanks for the update. Guess we'll just have to sit tight and wait...


Build error with build id #8538507

Details

Read the Docs project URL: https://readthedocs.org/projects/novosparc-nukappa

Actual Result
Build fails when it tries to import/compile POT with the following error
Collecting POT (from -r requirements.txt (line 8))   Using cached https://files.pythonhosted.org/packages/28/4b/7aaa1f840a359f5953dd378e0237fa8faf9b0a415ff7282b7375fbe68d27/POT-0.5.1.tar.gz     Complete output from command python setup.py egg_info:     Traceback (most recent call last):       File "<string>", line 1, in <module>       File "/tmp/pip-install-ig3rvxtc/POT/setup.py", line 7, in <module>         from Cython.Build import cythonize     ModuleNotFoundError: No module named 'Cython'
Cython is stated in the requirements.txt file, which is read normally before:
Collecting Cython (from -r requirements.txt (line 2))   Using cached https://files.pythonhosted.org/packages/7c/29/f93ddb609d9f81eade237d36c102fd1d3838da7847b45a2cae0fde9db76a/Cython-0.29.4-cp37-cp37m-manylinux1_x86_64.whl

Maybe this can help https://github.com/rtfd/readthedocs.org/issues/5297#issuecomment-464495686

Solved this by adding a requirements.txt file inside the docs and omitting any library that needs to be C++ compiled.


New style log_softmax

This PR implements new-style version of F.log_softmax as a part of #3147. This function will be used to make F.softmax_cross_entropy double-backpropable.

Thank you for your comments. Updated.

Jenkins, test this please

LGTM

Thanks!


Rust bookshelf

rendered
Create a "Rust Bookshelf" of learning resources for Rust.

Pull the book out of tree into rust-lang/book, which holds the second edition, currently.
Pull the nomicon and the reference out of tree and convert them to mdBook.
Pull the cargo docs out of tree and convert them to mdBook.
Create a new "Nightly Book" in-tree.
Provide a path forward for more long-form documentation to be maintained by the project.

/cc @rust-lang/core, @rust-lang/docs , @brson

How should the first and second editions of the book live in the same repository?

I think this should depend on what happens to the first edition when the second one is released? Does the first edition stay as it is warts and all? Then it should probably be a git tag, something that easy to reference, but hidden a bit away so new people don't accidentally get linked it. However if the first edition will still see stuff like correcting typos, then it should exist on a seperate branch.

@Aaronepower this is a good point. I think my inclination is to let both of them stay visible, and while not doing any work on the first edition, accept PRs for minor things like that. I'm open to suggestions, though.

If one could add The Little Book of Macros ref to the list?
I'm aware it is out of tree, and not official but it is a solid reference for intermediate to advanced Rust Programmers. It seems any book shelf of Rust reference material would be wanting without that.
(Or maybe Rust Book 2.0 covers that subject sufficiently?)

What about a list of Rust-related blogs as well? There are plenty of those too (recent example: 24 days of Rust).

@valarauca if @danielkeep is interested; I am: macros documentation has always been very weak.
@ticki blog posts are too contemporary usually; 24 days of Rust is amazing, but not really suitable as official documentation; we try not to play favorites with the ecosystem, and so don't link to any external crates not in the rust-lang org in official docs. (With the small exception of rand because when we made the decision, we thought it would be out of the nursery by now, but that's an exception and it will make it there eventually.)

Yet a planet.rust-lang.org would be appreciated

A ton of smaller repos can make it harder to find what goes where.

This sort of moves the problem up, what about a seperate GitHub org? eg. rust-lang-bookshelf which contains  all the resources for learning rust. This might add more administrative work though.
I was also wondering about translations of these books, and how they might fit into this?

This might add more administrative work though.

Yes, I'm not 100% sure what a separate org buys us. Other "related" orgs are usually because they're not quite "official" yet, but all of this stuff is considered hosted by the project.

I was also wondering about translations of these books, and how they might fit into this?

https://github.com/azerupi/mdBook/issues/5

Has pulling them out into a single "bookshelf" repo been considered, rather than one repo per book?

@sgrif I'll add that as an alternative soon. I prefer per-repo as it's easier to track issues individually, but this would work with tags too.

I left something out of the RFC that I forgot, since it was a holiday, so I'll write a simple version here to remind myself to add it later:
the nightly book has to be in-tree because it will be run as tests more often, and is more likely to break. The out-of-repo stuff will be run on travis per commit to rust-lang/rust. So this is kinda like how we run the most common tests on travis + buildbot, but the full test suite on only buildbot today: nightly book will run as part of the compiler's tests, but the full bookshelf will be tested when trying to land PRs.

It's wonderful the Rust Book, Standard Library Reference, and Nomicon are installed with the compiler so that people can refer to them while offline.  This should be preserved.
If anything, more should be installed locally, like documentation for nursery crates, links to documentation for crates built locally, and the playpen, at least until Rust gets a REPL.  All this is a property of rustup.sh, etc. though, not the repository layout.

This would definitely still be true after these changes.
On Sun, Dec 25, 2016 at 2:43 PM, Jeff Burdges<EMAIL_ADDRESS>wrote:

It's wonderful the Rust Book, Standard Library Reference, and Nomicon are
installed with the compiler so that people can refer to them while offline.
This should be preserved.
If anything, more should be installed locally, like documentation for
nursery crates, links to documentation for crates built locally, and the
playpen, at least until Rust gets a REPL. All this is a property of
rustup.sh, etc. though, not the repository layout.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/rust-lang/rfcs/pull/1828#issuecomment-269134995, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AABsimBAvIcMs6YvhIYFVs3JeKBeAxaTks5rLsdJgaJpZM4LVbkR
.

This looks good to me. Thanks for taking action on this.
It might be worth considering putting all the docs into one repository, instead of multiple. It could make Rust docs a more cohesive project, a single repo for Rust doc enthusiasts to rally around. One build system and issue tracker for the entire bookshelf. One place to go to improve the Rust documentation.
The RFC could make it more clean what "the bookshelf" is. It sounds like a product, but the RFC is mostly talking about how the documentation source is organized. "A landing page on doc.rust-lang.org will show the full bookshelf". So that landing page seems to be how the bookshelf is manifested, but that page already exists, so what's different?
One way to clarify what the bookshelf is is to clarify how it is defined. I might expect the bookshelf to be an independent product with its own build system, at rust-lang/rust-bookshelf. Perhaps what it outputs is what's ultimately presented at doc.rust-lang.org. Then the rust build system can build the bookshelf and package it as rust-docs.
There would be some questions about how to integrate nightly docs and std docs into the rust-bookshelf build and/or the rust-docs package.

Pull the nomicon and the reference out of tree

Maybe I'm misunderstanding, but this doesn't sound like a good idea to me. The Rust Reference should be updated by every RFC PR and/or implementation PR that changes the language. Pulling it out of the tree would create friction and make it more likely that the reference isn't updated in sync with the code.
Similarly, my understanding is that the nomicon is basically a sketch of the memory model and it should be updated by code change PRs that make assumptions about and/or define the memory model.

I wonder if having everything in one repo would makes it easier for separate books to reference/hyperlink to each other?
To add a follow-up to @briansmith 's question :  rust-lang.org describes the reference manual as "It tends to be out of date".   Is there anything we can do to improve this book to a point where we'd feel comfortable removing the "tends to be out of date" disclaimer?

There was a recent RFC requiring documentation updates for other changes to the Rust language though I admit that I didn't read it.
I think it makes a lot of sense to keep the reference in-tree and require any semantic changes merged into Rust also have the reference updated to match.
Otherwise you run into a problem of keeping docs in sync with rust versions.  This RFC should probably propose how to do that, if the reference is kept out of tree.

@briansmith
The job of the book is to teach the language, while the job of a language specification is to allow somebody to implement the language.
In an ideal world I would expect "the Rust spec" to be in the rust-lang/rust repo, and as you mention be updated with any code change that alters the spec.
However, minor language changes to the spec might have a huge impact in how the language is taught, possibly requiring large reworks to the book.
Since Rust does not have a spec, the book currently sits a bit in between both roles. As long as this is the case I agree with you in that the "Rust reference" should be kept in repo and updated accordingly, but I don't expect this to be the long term plan for the book.

@briansmith @eminence @mcpherrinm
So, to be clear about the process here again:

We now have an RFC that says that documentation must be updated before a feature becomes stable.
This RFC proposes that this documentation should land in the Unstable Book.
That book is in-tree, so that examples run as part of the regular test suite, so breakage should be caught early.
Part of the stabilization process is moving those docs out of the unstable book and into the reference.
Once it's stable, it should not have incompatible changes, and so it's really about catching bugs. That's why it's still run by CI for every commit.

Does that make sense?
@brson

One place to go to improve the Rust documentation.

This is still not true; Rust by Example and the standard library API docs wouldn't be in this repository, for example. That's one reason why I favor independent repos; it lets them grow independently. I don't like two repositories with multiple things in them very much; of course, the tricky bit is how you define "thing"...

The notion of "Nightly book" is relatively vague in the RFC, it may be worth detailing a bit?
Is it supposed to be an in-tree copy of the TRPL with extra chapters for unstable features, or is it a completely separate book which only covers unstable features? I assume it's the latter one.

I assume it's the latter one.

Yes, your assumption is correct. I'll try to clarify.

Oh, @eminence , sorry, I forgot this:

I wonder if having everything in one repo would makes it easier for separate books to reference/hyperlink to each other?

It does not make anything easier or harder, given that they both end up in the same place for the final artifact, regardless of the situation with the repositories.

I think the notion of a nightly book that lives in-tree is an interesting idea. That sounds like the reference should not contain any notion of nightly features, though, which is debatable. There is probably still a RFC to be written about refactoring the reference in a unified style anyway (with structured and concise descriptions, and tested grammar code examples).

Where do these new repos live? Did I miss this? Directly in the rust-lang orga? Do they move through the orgas like other crates, i.e., start out in rust-lang-nursery? How about creating a new Github organization rust-bookshelf where all community-written books can have a place?

As an aside, I'm looking at mdBook every now and then and always think to myself, "I should help out and do something to make the rendered HTML nicer", or "maybe I can add a subcommand to make it output markdown that is easy for pandoc to parse and convert to {HTML, PDF, EPUB}". There are a lot of opportunities there, and everything from @azerupi I've seen so far has been quite good! I think with a bit of concentrated effort we can make this into a really powerful tool. Sadly, I don't think I have any time to help out any time soon unless someone actually hires me to do this. :(

That sounds like the reference should not contain any notion of nightly features, though, which is debatable.

Yes, this is proposing that it should not. Or at least, it should explain the concept of nightly, but not any of the actual nightly stuff.

Where do these new repos live? Did I miss this?

I didn't spell it out, but I should have. The answer is rust-lang, in my estimation. They're already in the org.
The idea of a unified repo or organization was mentioned upthread; I could maybe see what a unified repo would get us, but I don't see what a separate organization would.

I prefer the reference be left in-tree, and get updated every time a language change stabilises. Separating the two will cause friction... having to update a reference on one repository and then stabilising a feature on another.

The nomicon can be pulled out given that it's long-form, relaxed writing, akin to a (long) blog post. Maybe it's core parts should be used in the language reference, and presented in a cold and terse style I expect a reference should be.

If there is a "nightly book" in tree for rust, I feel there should be something similar in tree for Cargo, especially with Cargo getting unstable features (as is/was the tentative plan for std-aware Cargo).

@tshepang

Maybe it's core parts should be used in the language reference, and presented in a cold and terse style I expect a reference should be.

Just like the book presents information from the reference, but in an easier way to learn it, so should the nomicon. If there's stuff missing from the reference, then it should be added to the reference, but I don't think that changing the feel of the nomicon is the right path forward for it as a text.
@Ericson2314

I feel there should be something similar in tree for Cargo,

Given that cargo and rust are distributed together, I assumed that nightly cargo stuff would also go in the nightly book. I should update the RFC to be explicit about this, thanks!

@steveklabnik I don't want the nomicon style to be changed either

This is a great RFC!
After reading the thread, I think a few different issues are conflated. Here is my best attempt to understand the questions at hand:

Is the rust reference (currently docs.rust-lang.org) distinct from the bookshelf?
I would argue that is not. They are both forms of documentation. I would also agree with previous comments that the RFC process should involve updating any documentation appropriately. Another point that was raised is that nightly documentation should organized by #[feature] attributes. This sounds like a good idea, but are feature attributes sufficient to categorize all RFCs?

Should the reference/books contain nightly stuff? If not, how to manage the separation?
Now that I have read the explanation here, I am beginning to like the idea of keeping nightly documentation in-tree and moving documentation of stable things to the official "stable reference". I think this should be added to the text of this RFC, as it clarifies how this suggestion in the RFC relates to the motivation. I would also be interested in hearing other alternatives to accomplish the goal of stabilizing documentation with features.

How do we choose what qualifies to be in the bookshelf? What is guaranteed about books in the bookshelf? Is the bookshelf considered a specification for Rust? Or is it a useful but official reference? Or is it a useful but unofficial reference? Are documents in the bookshelf supposed to be 100% correct? Or close enough? Or just "reasonable" for building an intuition? For example, the "nomicon" is a really useful rust book, but there are parts of it that are admittedly not formally correct.
For my part, I think that the bookshelf should contain two parts which are clearly labeled:

Official: Should be 100% correct; can be treated as a spec for rust; is maintained through the RFC process; lives in the rust-lang organization somewhere (depending on the answers of the previous two questions). The rust documentation (currently doc.rust-lang.org) would live here.

Unofficial: A curated list of books that are considered extremely useful by the community and are approved by the rust docs team via an RFC. These would live wherever they currently live. Included would be classics like the "nomicon", "Too many lists", "Rust by Example", etc. They would be managed by whoever the current owners are.

Where should books live? Especially third-party/unofficial books? Should they adopted by an official rust GitHub organization? Should they all go in the same repo?
The way I see it, there are a few possible options:
a) Leave them where they are in whatever third-party repos currently house them. The bookshelf would then only contain links to them.

pros: Easier maintenance; less work on the rust team. Also, this may allow more books to be added to the library quickly.
cons: Harder to maintain correctness. Community may have less control?

b) Move them all to the same repo

pros: Community has lots of control over the content, can make changes easily (for example, when the language changes). Also, we don't have to worry about whether an owner will let a book become stale or outdated.
cons: Lots of maintenance work because it is no longer distributed.

c) Some hybrid: This is approach I prefer. In particular, if the scheme I proposed above is used, official documentation can be maintained using (a) and unofficial documentation can be maintained using (b).

Just another idea: a thing I would like to have in the bookshelf is consistent manuals for each command-line tool. Maybe generated from the same source as the (usually out of date) man pages.

@steveklabnik

Given that cargo and rust are distributed together, I assumed that nightly cargo stuff would also go in the nightly book. I should update the RFC to be explicit about this, thanks!

I'm not sure this is a good idea. The big advantage of the nightly book being in tree is keeping the docs in sync, right? AFIAK the current Cargo release process of just taking whatever master happens to point to at the time of a Rust release is probably not sustainable, and I assume a proper release train for Cargo would be part of doing unstable features right. Cargo and Rust would probably still be published together, but not necessarily developed in tandem.
Granted, all this stuff is up in the air, but until its sorted out, I think keeping the docs in place as a cargo nightly book is a good path of lease resistance. The docs can still be rendered together, after all, I assume.

https://github.com/rust-lang/cargo/pull/3345 is at least some steps towards release trains for cargo.
I am not aware of any significant aspect of Cargo's docs that are actually tested. So keeping them in-tree as a "test suite" doesn't really happen. That said, if it's significant enough, we could do the "nightly cargo" split just as easily.

If I understand this proposal correctly, the Book will have separate stable/out-of-tree and unstable/in-tree versions, whereas the Reference will have only the stable/out-of-tree version. In my mind it makes more sense to have stable and unstable versions of both documents, given the Book and Reference are both very likely to need an update for the majority of language changes (unlike more targeted documents like the 'nomicon). In particular, because the Reference is often seen as out of date or incomplete, I would hope having a "nightly reference" that gets updated more regularly would be a great way to fix that problem in the long-term.
Is there a reason this RFC does not propose having an unstable/in-tree Reference?

Is there a reason this RFC does not propose having an unstable/in-tree Reference?

I envision that each chapter of the Unstable Book contains both kinds of materials; this is something worth clarifying in the text!

I would like all docs to be pulled out of the main repo and into their own repos. We now have the facility to run tests in the CI which are in other repos (e.g., we run all the Cargo tests), so there is no technical reason for docs to be in the main repo. I believe smaller repos will be less intimidating to contribute to and easier to track (GH is still pretty terrible at handling big repos, and Rust suffers for this).

I've pushed updates that hopefully answer everything above. Please let me know if I've missed something.

I have two niggling questions that I think aren't answered in the RFC.
How do we keep out-of-tree books synced with Rust releases?  Follow the same release trains? Tag them the same way?
How does content move from the nightly book to the out-of-tree books?  Does that happen in a separate PR after the features are stabilized?  How do we ensure this doesn't get forgotten or overseen?

How do we keep out-of-tree books synced with Rust releases? Follow the same release trains? Tag them the same way?

I envisioned them working like Cargo does today. That is, we tag which release they went in.

How does content move from the nightly book to the out-of-tree books? Does that happen in a separate PR after the features are stabilized? How do we ensure this doesn't get forgotten or overseen?

The docs have to land in order to stabilize, thanks to RFC 1636. That is, they move into the stable docs in order to make the features stable.

@steveklabnik kind of like the above, for a cargo book, even if we don't test the doc, if a PR gets reverted or backported, its nice for the doc to be backported or reverted with it for no extra effort.

(btw the rendered link is fixed to the original commit)

Has anyone talked with @danielkeep about making The Little Book of Macros part of the bookshelf? I'm interested because if it is a part of the bookshelf, we might cut macro writing out of the new version of the book entirely, but if it does not become more official, I think we should cover macro writing in the book :)

@carols10cents I mentioned that above; it's something I'd like, but @danielkeep hasn't weighed in yet.

@steveklabnik Yes, it'd be awesome if he would :)

@rfcbot fcp merge
We've discussed this at several recent docs team meetings, and since discussion has died down, I'm moving to merge this RFC.

@steveklabnik Were there any changes to the proposal made from those meetings that isn't in the document?

@Aaronepower nope. Was there something from the discussion that didn't end up reflected in the RFC?

@steveklabnik I wouldn't know. When people say they have a meeting about something it usually comes with changes. 😂

I hear you! It was mostly just a check-in: did everyone see this RFC, did you read it, etc.

@rfcbot fcp merge
@dikaiosune says I should do this again 😄

@rfcbot fcp merge
@dikaiosune says I should do this again 😄

@rfcbot fcp merge
@dikaiosune says I should do this again 😄

@peschkaj is taking some time off from the docs team, so I've checked their box.

[x] @frewsxcv

;)

@frewsxcv already working on fixing that ❤

I don't know how to use rfcbot, but 👍 from me.

@jonathandturner you can either check the box or say "@rfcbot: reviewed" in a comment
@frewsxcv i have confirmed with @dikaiosune that this is fixed, and you'll be in for the next one 😄

@rfcbot: reviewed

Hooray! this RFC has been accepted.
Tracking issue: https://github.com/rust-lang/rust/issues/39588


Url with only slug doesn't work

If i use url like this
    routes['search/:query'] = function(params) {
        let page = new SearchPage(params.query);
        pageStore.showPage(page);
        page.showSearchMenu(params.query);
    }; // WORKS

then this one works but if i use as following it doesn't work,
    routes[':query'] = function(params) {
        let page = new SearchPage(params.query);
        pageStore.showPage(page);
        page.showSearchMenu(params.query);
    }; // NOT WORKING - This one redirecting me to Home Page

There is a new version 8.0.0 where this works and it is covered with a unit test https://github.com/krasimir/navigo/blob/big-rewrite/src/tests/basic.spec.ts#L239-L246
P.S.
Version 8.0.0 is not officially released but can be installed via npm install navigo@beta or yarn add navigo@beta. Migration guide is available here https://github.com/krasimir/navigo/blob/big-rewrite/CHANGELOG.md#migration-guide and the new documentation here https://github.com/krasimir/navigo/blob/big-rewrite/DOCUMENTATION.md.


RLMResult's notification is getting slower when the RLMResult count is getting bigger

!!! MANDATORY TO FILL OUT !!!
Recently, I faced a problem that RLMResult's notification is quite slow when the RLMResult's count is large.
Is there any way to solve this issue?
The situation is that I have 100 conversation objects and each one of them has 10,000 message objects.
It takes at least 1.6s to get a notification when I add 1 message into a conversation.
Goals
Hope the RLMResult's notification can get faster.
Expected Results
1.6s -> less than 1s
Actual Results
At least 1.6s
Steps for others to Reproduce
Add 1 message into a conversation
Code Sample
class Conversation: RLMObject {
    @objc dynamic private(set) var ID = ""
    @objc dynamic var messages = RLMArray<ChatMessage>(objectClassName: ChatMessage.className())
}

class ChatMessage: RLMObject {
     @objc dynamic var ID = ""
     @objc dynamic var text: String?
}

Version of Realm and Tooling
Realm framework version: 4.4.1
Xcode version: 11.5
iOS/OSX version: 13.5

I'm not too sure about the expected notification times with a RLMArray containing +10,000 objects. Another team-member who knows more about that would have to comment.

Is there any way to solve this issue?

Where are you measuring the 1.6 seconds? Is it from the notification callback or the UI. It's possible the notification returns promptly but is not dispatched to the main UI thread. This would be the first thing to check.

@MuJuiLin From our documentation: 'Since notifications are delivered using a run loop, the delivery of notifications might be delayed by other activity on the run loop. When notifications can’t be delivered immediately, changes from multiple write transactions may be coalesced into a single notification.'
https://realm.io/docs/swift/latest/#notifications

Closing this issue due to inactivity. If you have any other questions please open a new issue.
Thanks.


Add feature: Switch hides banner image in list

Adds the functionality for a user to include an extra parameter in their post header to hide the banner image in a post list.
Currently, if an image is defined in the header, like image = "example.png", then the banner image will appear in both the post and the post list. It is not possible (to my knowledge) to remove the image from the post list, but keep it in the actual post. This change would add this functionality.
With this change, the user could have the following line in their post header...
+++
image = "banners/example.png"
hide_banner_in_list = true
+++

... and the banner image will show on the post but not in the post list.
The naming I used for this new switch probably isn't great. It's a little long. However, I couldn't think of anything much better that would still be descriptive and understandable. Please change if you think of something better.
Cheers!

I am interested to understand your use case and why you want this feature. Do you only want to hide one (or some) thumbnail, or do you wish to hide all thumbnails in the post list?

I wanted to be able to hide/mute the header/banner image in the Recent Posts area on the front page. I like look of the banner image on the post itself. It's nice and wide and puts some more color on the page, even when the post itself doesn't have any.
I was thinking about using one common header image for multiple posts. Something that keeps the nice look of the image above the post. But because it would be common to many posts, I don't like the idea of showing in the Recent Posts list, because the images are not unique to the post and would be taking up space in the list. I'd rather have the list only have information that is unique to the post.
So, yes, I'm looking to selectively hide thumbnails in the post list.
A working usage example, shown in the screen shots.

Based on your suggestion, I added a preview parameter to the new header image system. You can now set preview = false under [header] to hide a post's thumbnail on homepage. For example, the end of a post's frontmatter will become something like:
[header]
image = "headers/bubbles-wide.jpg"
caption = "My caption :smile:"
preview = false

Awesome. The preview parameter makes more sense.
Thanks for taking me up on my suggestion.
Cheers!


Ability to compare analytics for two episodes

[ ] Select two episodes (react-select?)
[ ] Show react-analytics-dash with series for both episodes

Should be available to Starter for two episodes, three or more requires Pro

In hindsight, this feature doesn't add much value. This is especially true now that there is CSV export on most analytics types.


kafka-manager-<IP_ADDRESS> not displaying anything consumers tab

I've installed confluent-5.1.2 with Apache Kafka 2.1.x version, still we wont be able to see anything under 'Consumers' tabs and 'Consumers consuming from this topic' in Kafka-Manager.
We have already enabled below configurations:

Poll consumer information (Not recommended for large # of consumers if ZK is used for offsets tracking on older Kafka versions)
Enable Active OffsetCache (Not recommended for large # of consumers)

Appreciate your help here.
Thanks,
Amol

+1

Having the same issue.

Same issue

same issue

+1

Having the same issue. DHas anyone resolved the issue
Kafka 2.2.0
Kafka Manager <IP_ADDRESS>

+1

You need to set the client.id on your consumers. If you are using a spring based consumer, the spring.application.name can be set as well.

Having the same issue.
confluent-5.3.0-ce
Apache Kafka 2.3
Kafka Manager <IP_ADDRESS>
Does anyone managed to resolve the issue?

+1.
By the way, is this project still supported?

+1

By the way, is this project still "actively" supported? If not, I'll look towards something else.

@jeisea
Came here by Google and sry I have to say this, but...
...that's not the spirit of open source software. If a project is only valuable for you if and as long others spent their time to maintain it, then please use something else. At least to me your statement sounds like a threat: Work in it or I will leave.
In case I got this wrong I apologize in advance.

We are using
Kafka 2.2.0
Kafka Manager/CMAK <IP_ADDRESS> and had the same behavior
But I guess we figured it out...
Is anybody of you using SASL/SSL?
We do and it turns out, that we need to set the security protocol and mechanism accordingly. In our case:

"Default" as SASL mechanism did not work. Using "plain" here, did the trick. Does help anybody else?

@byteSamurai   thanks, it works.


chore(deps): update terraform terraform-ibm-modules/observability-agents/ibm to v2.3.0

This PR contains the following updates:

Package
Type
Update
Change

terraform-ibm-modules/observability-agents/ibm (source)
module
minor
2.1.0 -> 2.3.0

Release Notes

terraform-ibm-modules/terraform-ibm-observability-agents (terraform-ibm-modules/observability-agents/ibm)
v2.3.0
Compare Source
Features

deps: update icr.io/ext/sysdig/agent docker tag to v13.5.0 (#420) (75778ce)

v2.2.0
Compare Source
Features

added ability to set wait_til and wait_till_timeout (#425) (03135f1)

Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.

[ ] If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

/run pipeline

:tada: This PR is included in version 3.35.3 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Fix the TabTests?

Summary of the Pull Request
This is a draft PR to see if the tests actually also magic work in CI now too. I'll update the description after lunch.
References
PR Checklist

[x] Closes wait there's no issue for this is there
[x] I work here
[x] Tests added/passed - you better believe it
[n/a] Requires documentation to be updated

Detailed Description of the Pull Request / Additional comments
Validation Steps Performed

(draft PRs don't run the CI but treat this as a draft)

(this guy is ready for review now)

I love these commit messages.

@miniksa @carlos-zamora @DHowett-MSFT @leonMSFT
Heads up, if you want to run the LocalTests after merging this - you'll need to manually delete the old App.xbf out of the bin\x64\Debug\LocalTests_TerminalApp directory. It won't get cleaned up automatically, and if it's there, the TabTests will fail. Fortunately the rest of the tests will still pass.


system_syncState hangs while the node is syncing

We received a bug report that when Karura node is syncing, system_syncState hangs forever.
# curl -s -H "Content-Type: application/json" -d '{"id":1, "jsonrpc":"2.0", "method": "system_syncState"}' http://localhost:30510
^C

Works for me :thinking:

FWIW, I tried this on my laptop with a debug build. But yeah, was probably still not low spec enough :D


calico-kube-controllers: Run as non-root by default for the arm64 image

Description

This PR adapts the arm64 image of calico-kube-controllers to run as non-root by default. Similar to https://github.com/projectcalico/kube-controllers/pull/565 (the change that adapted the amd64 image to run as non-root).
Related issues/PRs

Fixes https://github.com/projectcalico/calico/issues/5713
Todos

[ ] Tests
[ ] Documentation
[x] Release note

Release Note

The arm64 image of calico-kube-controllers now runs as non-root by default (similar to the amd64 image).

Reminder for the reviewer
Make sure that this PR has the correct labels and milestone set.
Every PR needs one docs-* label.

docs-pr-required: This change requires a change to the documentation that has not been completed yet.
docs-completed: This change has all necessary documentation completed.
docs-not-required: This change has no user-facing impact and requires no docs.

Every PR needs one release-note-* label.

release-note-required: This PR has user-facing changes. Most PRs should have this label.
release-note-not-required: This PR has no user-facing changes.

Other optional labels:

cherry-pick-candidate: This PR should be cherry-picked to an earlier release. For bug fixes only.
needs-operator-pr: This PR is related to install and requires a corresponding change to the operator.

/sem-approve

@caseydavenport , I see that the ci/semaphoreci/pr check failed with:
==== Command make ci FAILED (PID=3429).  Full command output in artifacts/ci.log.05:45
==== Done, exiting with RC=1

Do you have idea about this failure? Any hint about it would be appreciated.

Tail end of that log file shows:
chmod +x bin/kubectl-arm64
docker buildx build --pull --build-arg QEMU_IMAGE=calico/go-build:v0.73 --build-arg UBI_IMAGE=registry.access.redhat.com/ubi8/ubi-minimal:8.5 --build-arg GIT_VERSION=v3.24.0-0.dev-414-g316b05f56cc1 --platform=linux/arm64/v8 -t kube-controllers:latest-arm64 -f Dockerfile.arm64 . --load

<SNIP>

 => [ubi 1/3] FROM registry.access.redhat.com/ubi8/ubi-minimal:8.5@sha256  4.4s
 => => sha256:85106a04d38caea3157af93a99fc944ccff961724b8 1.75kB / 1.75kB  0.2s
 => => sha256:3f32ebba0cbf3849a48372d4fc3a4ce70816f248d39 1.47kB / 1.47kB  0.0s
 => => sha256:5bdfc925531cbb20d526a69af0ff54be3ef50a44f6bf95d 737B / 737B  0.0s
 => => sha256:c9957244e13e90852b3d74d3f5a1b9b7fe94c8d3b62 4.32kB / 4.32kB  0.0s
 => => extracting sha256:4c06f8f064d963a6fb653c3dc181bb39bb67557e193c2f9c  1.1s
 => => extracting sha256:85106a04d38caea3157af93a99fc944ccff961724b8d1451  0.0s
 => [ubi 2/3] RUN mkdir /status                                            0.1s
[+] Building 5.1s (4/10)
 => [ubi 1/3] FROM registry.access.redhat.com/ubi8/ubi-minimal:8.5@sha256  4.5s
 => => sha256:85106a04d38caea3157af93a99fc944ccff961724b8 1.75kB / 1.75kB  0.2s
 => => sha256:3f32ebba0cbf3849a48372d4fc3a4ce70816f248d39 1.47kB / 1.47kB  0.0s
 => => sha256:5bdfc925531cbb20d526a69af0ff54be3ef50a44f6bf95d 737B / 737B  0.0s
 => => sha256:c9957244e13e90852b3d74d3f5a1b9b7fe94c8d3b62 4.32kB / 4.32kB  0.0s
 => => extracting sha256:4c06f8f064d963a6fb653c3dc181bb39bb67557e193c2f9c  1.1s
 => => extracting sha256:85106a04d38caea3157af93a99fc944ccff961724b8d1451  0.0s
 => [ubi 2/3] RUN mkdir /status                                            0.3s
[+] Building 5.1s (5/10)
 => [internal] load build definition from Dockerfile.arm64                 0.0s
 => => transferring dockerfile: 1.07kB                                     0.0s
 => [internal] load .dockerignore                                          0.0s
 => => transferring context: 2B                                            0.0s
 => [internal] load metadata for registry.access.redhat.com/ubi8/ubi-mini  0.5s
 => [internal] load build context                                          0.4s
 => => transferring context: 64.14MB                                       0.4s
 => [ubi 1/3] FROM registry.access.redhat.com/ubi8/ubi-minimal:8.5@sha256  4.5s
 => => resolve registry.access.redhat.com/ubi8/ubi-minimal:8.5@sha256:3f3  0.0s
 => => sha256:4c06f8f064d963a6fb653c3dc181bb39bb67557e1 39.18MB / 39.18MB  3.0s
 => => sha256:85106a04d38caea3157af93a99fc944ccff961724b8 1.75kB / 1.75kB  0.2s
 => => sha256:3f32ebba0cbf3849a48372d4fc3a4ce70816f248d39 1.47kB / 1.47kB  0.0s
 => => sha256:5bdfc925531cbb20d526a69af0ff54be3ef50a44f6bf95d 737B / 737B  0.0s
 => => sha256:c9957244e13e90852b3d74d3f5a1b9b7fe94c8d3b62 4.32kB / 4.32kB  0.0s
 => => extracting sha256:4c06f8f064d963a6fb653c3dc181bb39bb67557e193c2f9c  1.1s
 => => extracting sha256:85106a04d38caea3157af93a99fc944ccff961724b8d1451  0.0s
 => ERROR [ubi 2/3] RUN mkdir /status                                      0.3s
------
 > [ubi 2/3] RUN mkdir /status:
#0 0.190 exec /bin/sh: exec format error
------
error: failed to solve: executor failed running [/bin/sh -c mkdir /status]: exit code: 1
Makefile:83: recipe for target 'image.created-arm64' failed
make[1]: *** [image.created-arm64] Error 1

/sem-approve

2022-07-11 13:44:41 (59.7 MB/s) - ‘bin/kubectl-arm64’ saved [46202880/46202880]

chmod +x bin/kubectl-arm64
docker buildx build --pull --build-arg QEMU_IMAGE=calico/go-build:v0.73 --build-arg UBI_IMAGE=registry.access.redhat.com/ubi8/ubi-minimal:8.6 --build-arg GIT_VERSION=v3.24.0-0.dev-421-g43516973a9e7 --platform=linux/arm64/v8 -t kube-controllers:latest-arm64 -f Dockerfile.arm64 . --load

<SNIP>

 => [internal] load build context                                          0.6s
 => => transferring context: 64.14MB                                       0.6s
 => [ubi 1/4] FROM registry.access.redhat.com/ubi8/ubi-minimal:8.6@sha25  10.1s
 => => resolve registry.access.redhat.com/ubi8/ubi-minimal:8.6@sha256:c7b  0.0s
 => => sha256:c7b45019f4db32e536e69e102c4028b66bf5cde173c 1.47kB / 1.47kB  0.0s
 => => sha256:bd1efe41f8f7d8ea3ed0c04b48818a1695037eeb586a7fd 737B / 737B  0.0s
 => => sha256:ef5147c7a007d7d6adcf467c44199e7e1aa573ebea3 4.28kB / 4.28kB  0.0s
 => => sha256:96fb404a82ee59a2279a059f18a7084cb991676f1 35.06MB / 35.06MB  7.7s
 => => sha256:b898cebac917ed7374d750bb6a469fd65a0c2848803 1.74kB / 1.74kB  7.4s
 => => extracting sha256:96fb404a82ee59a2279a059f18a7084cb991676f1b452fb8  2.0s
 => => extracting sha256:b898cebac917ed7374d750bb6a469fd65a0c2848803249a7  0.0s
 => [ubi 2/4] COPY --from=qemu /usr/bin/qemu-aarch64-static /usr/bin/      0.0s
 => ERROR [ubi 3/4] RUN mkdir /status                                      0.2s
------
 > [ubi 3/4] RUN mkdir /status:
#0 0.190 exec /bin/sh: exec format error
------
error: failed to solve: executor failed running [/bin/sh -c mkdir /status]: exit code: 1
Makefile:83: recipe for target 'image.created-arm64' failed
make[1]: *** [image.created-arm64] Error 1
make[1]: Leaving directory '/home/semaphore/calico/kube-controllers'
Makefile:80: recipe for target 'sub-image-arm64' failed
make: *** [sub-image-arm64] Error 2

@caseydavenport @lwr20 I believe I found the error. Can you help retriggering the ci/semaphoreci/pr check?

/sem approve

@lwr20 , I assume it should be /sem-approve (and not /sem approve)? Otherwise, I cannot explain why the ci/cd is not started.

/sem-approve

Thank you for pointing that out!

The image build is now successful!  🎉

Awesome, thank you @ialidzhikov !


WebChimera high CPU usage

Added WebChimera.js's close method:
https://github.com/RSATom/WebChimera.js/issues/90
A possible solution?


Ability to configure scrolling behaviour

Hey,
first of all, thank you for open-sourcing this neat library!
Secondly, I wanted to ask you: would you consider adding some kind of ability to configure scrolling behaviour (perhaps to MonthsLayout enum via LayoutOptions)? Because I wanted to implement horizontal calendar with snapping like behaviour (where you have single month shown on the screen and then using swipe gesture or buttons move to next/previous month) and the only way how I managed to achieve that was by going into view hierarchy and disabling scroll on NoContentInsetAdjustmentScrollView which feels kinda hacky as it would stop working if at some point you decide to move scrollview somewhere else.
Also, I was curious: does HorizonCalendar support RTL layout? Because in order to achieve proper scrolling on RTL I had to change transform of CalendarView
Thanks

Hi @Pattio - this is definitely a feature that we want to add support for! And I agree, manually messing with that internal scroll view is probably not a good idea.
I think we could probably support the programatic scrolling via buttons by having your code call:
public func scroll(
    toMonthContaining dateInTargetMonth: Date,
    scrollPosition: CalendarViewScrollPosition,
    animated: Bool)

But we'd still need the snapping behavior. I'll get around to working on this in the next few weeks!

As for RTL layout, I wonder what that would look like? Would the order of months change for the horizontal layout? I guess we don't support that right now, but that's a great callout. PRs are welcome if you'd like to tackle that one, but otherwise I'll leave this open so it's being tracked.

Awesome, thank you for the response. Yeah programmatic scroll works pretty nice, just the fact that I need to mess with the scrollview to disable the scroll on it, rubs me the wrong way 😄
Regarding RTL it the biggest issues for me was the scroll animation as it should be performed in the opposite direction. I managed to solve it by transforming CalendarView by setting its transform to CGAffineTransform(scaleX: -1, y: 1) it's definitely not the best solution, but it works for me.
Anyway, once again thank you for your work!

@bryankeller First of all thanks for the incredible work on this, the amount of work and customization possible in this library is insane !
I'd like to ask if there's an update on the snapping behavior ? Is it coming anytime soon ?

@tareksabry1337 I'm working on snapping behavior next (just finished fixing a few bugs and adding RTL support cc @Pattio) ... stay tuned 🙂

@bryankeller Thanks for working hard on this amazing calendar.
Any updates on the snapping behavior?
Looking forward to this feature!

@OttoFI @Pattio @tareksabry1337 thanks all for your patience. v1.7.0 is now live with support for horizontal pagination.

@OttoFI @Pattio @tareksabry1337 thanks all for your patience. v1.7.0 is now live with support for horizontal pagination.


Fix "tap to continue" in bold

Description
The goal of this PR is to fix a regression that made "tap to continue" displayed in bold font instead of regular one.
Changes include

[*] Bugfix (non-breaking change that solves an issue)
[ ] New feature (non-breaking change that adds functionality)
[ ] Breaking change (change that is not backwards-compatible and/or changes current functionality)
[ ] Tests
[ ] Documentation
[ ] Other (for changes that might not fit in any category)

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 60.19%. Comparing base (7583aee) to head (8ce343a).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #700   +/-   ##
=======================================
  Coverage   60.19%   60.19%
=======================================
  Files          12       12
  Lines        1726     1726
=======================================
  Hits         1039     1039
  Misses        687      687

Flag
Coverage Δ

unittests
60.19% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Poetry for dependency management

We're currently using both requirements.txt and setup.py to specify our dependencies. Let's get rid of both of those and unify them with poetry.
After installing poetry, you can install the main and dev dependencies with:
poetry install

To only install the main dependencies (as users will when they pip install the library), use:
poetry install --only main

To install docs dependencies too, use:
poetry install --with docs

To install extra dependencies for validators, use:
poetry install --all-extras

This is equivalent to:
poetry install --extras="sql summary vectordb profanity detect-secrets manifest critique"

Upon our next release, to use the extras, users will need to install the package as with the corresponding extras they wish to use, eg:
pip install "guardrails-ai[sql]"

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

:exclamation: No coverage uploaded for pull request base (main@c7cb998). Click here to learn what that means.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #436   +/-   ##
=======================================
  Coverage        ?   81.42%
=======================================
  Files           ?       36
  Lines           ?     3940
  Branches        ?        0
=======================================
  Hits            ?     3208
  Misses          ?      732
  Partials        ?        0

Flag
Coverage Δ

unittests
81.42% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Added support for more types

Added support for around 40 IfcEntity types and subtypes

Hey, a little more detailed explanation of what's been done. We've added support for around 40 types and all of its subtypes (if any). You can view the list in the file ElementType.cs. There are over 200 cases now for the integer input for type. To make the process of choosing the correct type from Grasshopper easy, I have made another component that takes your input in text form of which type you wish to choose and sends the correct number for it to the respective component. You can see the picture below to see how it works.

Hey!
Thank you for contribution!
Could you also Commit this additional component for choosing proper enum?

Sure, I'd love to share that component as well. But there was a small issue we faced. In this code in the repository, we are only able to make changes to the backend. Building the solution in Visual Studio does not generate a gha file. Hence, I had to make the component separately.

Have you changed the .csproj post-built events, so it fits your machine? This way you should be able to compile also .gha.
I'm using Rider, but I don't think it makes any difference there.

I'll have a look at it and see what I can do

Hey, I've committed the additional component. I've also added another feature of generating IFC files only when pressing a button to do so.

Hey,
I've tried it, and it looks great. I will need some time to read it more, and reorganize some stuff there, functionality itself is really good.
Do you have some kind of a list of these types somewhere, so I can attach it inside documentation?
I think also that maybe we should just convert a string to an enum in the first component, and this first component would create an object called IfcType with 2 properties: type and subtype, so it will pass this object to Mesh To Elements and Profile To Elements this way, so we could get rid of these integers, what do you think?

Hey,
Yes, here is a text file with all the types mentioned.
Ifc Types.txt
I've also modified the MeshToElements and ProfileToElements components to directly take in the strings of the type and subtype to avoid having any extra component for this.

Hey, it is better right now, cause there is no redundant integers in between, but still there is too much logic there. Totally this pull request has something like 2000 new lines of code (while the whole project is 1000) just to properly attach the type and subtype, so xBim will recognize it. I think we should find a way to do it without these if statements, I hope we can make it less than 200 lines. One idea is to insist that the user will need to input correct enum for Element Type, so he will need to input a string, for example: "ElementAssembly_AccessoryAssembly" - we will only convert this string to enum automatically. That will remove many lines of code. If you have any other ideas to simplify whole code let me know.


Problem with TLSCertVerify ?

Is there option to not check TLS cert in case of SSL or STARTTLS ?

@jadjay as long as you don't tell the library to not check the certs by setting SkipInsecureVerify in tls.Config TLS certs are automatically checked.
See for example this test with go-sendxmpp (which is using this library):
date|./go-sendxmpp -u<EMAIL_ADDRESS>-p test<EMAIL_ADDRESS>2024/02/25 13:01:26 failed to connect to server: starttls handshake: tls: failed to verify certificate: x509: certificate has expired or is not yet valid: current time 2024-02-25T13:01:26+01:00 is after 2023-12-25T23:39:44Z


Could not find package lokielse/aliyun-open-api-sls at any version for your minimum-stability

Solved by upgrade composer.


Markdown Links Broken

Details

Project URL: http://docs.pachyderm.io/en/latest/pachctl/pachctl.html

Expected Result
An example page is here which includes a link (to a subcommand 'archive-all') that should point to here
Actual Result
Instead, the link on this page to the 'archive-all' subcommand points here

I'm hoping I've just done something silly and can use markdown in this way.
For convenience, here are links to:

the conf.py file
the index.rst file
the source file pachctl.md

In the past we had this working by having a mirror of the pachctl.md file that was an rst file.
However, these files are emitted by cobra, a standard golang command line utility, so I don't have control over the output format. And, I think markdown files are supposed to work in this way on RTD. Maybe I'm wrong.

@sjezewski I was able to reproduce the issue that you mentioned. Were you able to fix it by yourself?

No, I believe we still manually curate the .rst file to match the contents of the .md file. This is a manual process and often we find our docs out of date / mismatched.

Sorry, I made a mistakes. I wanted to say that "I wasn't able to reproduce it". What I should do reproduce it? What are the steps I have to follow? Thanks.

Closing due to inactivity.


Kalyani

would please check my code lawyers site

@kadarikalyani there are no file changes ...
seems like you dint commit the changes from your local ... or may be you forgot to push changes from your kalyani local branch to origin/kalyani

adding lawyer search forms

@kadarikalyani review comments and make appropriate changes

removed all whatever you comment the changes


SlidingTimeWindowMovingAverages returns counts instead of rates

When using Meters or Timers backed by the SlidingTimeWindowMovingAverages implementation, the reported OneMinuteRate, FiveMinuteRate and FifteenMinuteRate values are the number of events that occurred during the time window.
I would have expected the average number of events per second during the time window to be reported so that the moving average values are consistent with MeanRate and with the output of the ExponentialMovingAverages implementation.
Fixing the issue is simply a matter of dividing the number of events by the number of seconds in the time window. However it would be a breaking change as the reported values would not have the same meaning as with the current version. Would it be acceptable to submit a pull request with such a fix?

Yes indeed, this article explains very well the difference between the exponential moving average and the sliding time window moving average. What looks like a bug to me is that Dropwizard's sliding time window moving average implementation returns the number of events that occurred in the time window instead of the rate at which the events occurred. That is to say in the last experiment of the article with the simulated workload of 100 events per second, I would have expected the graph to peak at 100 (events / seconds) instead of 3000 (events).
A consequence of this behavior is a poor interaction with ScheduledReporter's rate unit conversion feature. If the reporter is configured to export the rates in events/minute instead of the default events/second, then the output of SlidingTimeWindowMovingAverages is multiplied by 60 which doesn't make a lot of sense.

This issue is stale because it has been open 180 days with no activity. Remove the "stale" label or comment or this will be closed in 14 days.

Commenting to remove the stale label as this issue has not been resolved.

This issue is stale because it has been open 180 days with no activity. Remove the "stale" label or comment or this will be closed in 14 days.

Commenting to remove the stale label as this issue has not been resolved.

This took me by surprise as well.

This issue is stale because it has been open 180 days with no activity. Remove the "stale" label or comment or this will be closed in 14 days.

Commenting to remove the stale label as this issue has not been resolved.


add LynxLiteralExpression

What changes were proposed in this pull request?
as title
Why are the changes needed?
De-Cypher
Does this PR introduce any user-facing change?
No
How was this patch tested?
Not yet

see pr358


Build Web Apps with Expressjs Installation uses deprecated packages and has a missing module

Challenge Name

https://www.freecodecamp.org/challenges/build-web-apps-with-expressjs
Issue Description

Following the challenge's directions, I ran the clone command 'git clone https://github.com/FreeCodeCamp/fcc-expressworks.git && chmod 744 fcc-expressworks/setup.sh && fcc-expressworks/setup.sh && source ~/.profile'.
The install showed that there is a missing package 'uninstall' and showed that this challenge is using deprecated packages.
Browser Information

Browser Name, Version: Google Chrome  Version 59.0.3071.115 (Official Build) (64-bit)
Operating System: Windows 10 Home
Mobile, Desktop, or Tablet: Laptop

Your Code

#### Screenshot
<!-- Add a screenshot of your issue -->
<pre>
timmr99:~ $ git clone https://github.com/FreeCodeCamp/fcc-expressworks.git && chmod 744 fcc-expressworks/setup.sh && fcc-expressworks/setup.sh && source ~/.profile
Cloning into 'fcc-expressworks'...
remote: Counting objects: 28, done.
remote: Total 28 (delta 0), reused 0 (delta 0), pack-reused 28
Unpacking objects: 100% (28/28), done.
Setting up nvm...

Cloning into 'expressworks'...
remote: Counting objects: 688, done.
remote: Total 688 (delta 0), reused 0 (delta 0), pack-reused 688
Receiving objects: 100% (688/688), 247.66 KiB | 0 bytes/s, done.
Resolving deltas: 100% (335/335), done.
npm WARN deprecated<EMAIL_ADDRESS>Jade has been renamed to pug, please install the latest version of pug instead of jade
npm WARN deprecated<EMAIL_ADDRESS>Deprecated, use jstransformer
npm WARN deprecated<EMAIL_ADDRESS>Please update to minimatch 3.0.2 or higher to avoid a RegExp DoS issue
/home/ubuntu/.nvm/versions/node/v4.1.2/bin/expressworks -> /home/ubuntu/.nvm/versions/node/v4.1.2/lib/node_modules/expressworks/expressworks.js
<EMAIL_ADDRESS>/home/ubuntu/.nvm/versions/node/v4.1.2/lib/node_modules/expressworks
├──<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>├──<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>├──<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>├──<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>├──<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>├──<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>├──<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>└──<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>Done.
timmr99:~ $
</pre>

npm install express should do it.

I am intrested in this issue can this be assigned to me and can you direct me to the files that need to be changed.

I just looked into this issue and it seems the bash script used to set up Express is outdated. That would be something to look into, @knrt10.

@moyamanuel Can you please direct me to the files to look at.

setup.sh

I'm closing this issue as stale since it hasn't been active lately. If you think this is still relevant to the newly updated platform, please explain why, then reopen it.


Add option to use percent change plot instead of difference plots when applicable

New feature type
New plot and/or plot enhancement
What is this new feature?
This feature would allow the difference plot that is included in several of the plotting types to be a percent change plot instead.  This would be more useful than a difference plot for composition variables.
Assistance required?
Yes, I am requesting a new feature but won't have time to develop it
Extra info
May have time to work on this - I do have a prototype rough version of this feature that works to some degree.

Closed with PR #339


Sequelize.logging typings are incorrect

Versions

sequelize: ^5.21.2
sequelize-typescript: ^1.0.0
typescript: ^3.6.3

I'm submitting a ...
[x] bug report
[ ] feature request
Actual behavior:
SequelizeOptions->logging provides the Sequelize Object instead of timing: number as second parameter
Expected behavior:
SequelizeOptions->logging should provide the typed Sequelize Object or the execution time of the query as stated in the current typing
Steps to reproduce:
Use logging for queries and see the result
Related code:
import {
  Sequelize,
  SequelizeOptions,
  Model,
  ModelCtor,
} from 'sequelize-typescript';
// ...
    this.dbConnection = new Sequelize({
      dialect: 'mysql',
      ...(cfg as SequelizeOptions),
      // logging: Logging.logging?: boolean | ((sql: string, timing?: number) => void)
      logging: console.debug,
    });

// cfg uses the following interface:
/**
 * Database connection options
 */
export interface DatabaseOptions {
  /**
   * Database host
   */
  host: string;

  /**
   * Database port
   */
  port: number | string;

  /**
   * Database user
   */
  username: string;

  /**
   * Database users password
   */
  password: string;

  /**
   * Database name
   */
  database: string;
}

{
  "compilerOptions": {
    "module": "commonjs",
    "declaration": true,
    "removeComments": true,
    "emitDecoratorMetadata": true,
    "experimentalDecorators": true,
    "target": "es6",
    "sourceMap": true,
    "outDir": "./dist",
    "baseUrl": "./",
    "incremental": true
  },
  "exclude": ["node_modules", "dist"]
}

Output:
Executing (default): SELECT `id`, `createdAt`, `updatedAt` FROM `invoicePackages` AS `InvoicePackage`; { plain: false,
  raw: false,
  logging: [Function: bound consoleCall],
  showWarnings: false,
  hooks: true,
  rejectOnEmpty: false,
  originalAttributes: [ 'id', 'createdAt', 'updatedAt' ],
  attributes: [ 'id', 'createdAt', 'updatedAt' ],
  tableNames: [ 'invoicePackages' ],
  type: 'SELECT',
  model: InvoicePackage }

Hey @Kagu-chan, thanks for reporting, but this is a sequelize issue. Since the typings are defined there https://github.com/sequelize/sequelize/blob/master/types/lib/model.d.ts#L18, can you report it in the sequelize repo instead?

Thanks for the link - i didn't exactly look into the code at this point (:
For other users who may find this it's worth mentioning, that the parameter logging.benchmark: boolean enables exactly this behavior.
Since it's resolved in this case, i'll close the issue (:


Update UniqueCcaList in model class diagram

Fixes https://github.com/AY2324S2-CS2103T-W11-2/tp/issues/61

I'm confused, Jia Jie did not implement UniqueCcaList, it is part of a proposed better classed diagram. Regardless I think it's something that we should implement in v1.3 so I'm going to approve this change.

I'm confused, Jia Jie did not implement UniqueCcaList, it is part of a proposed better classed diagram. Regardless I think it's something that we should implement in v1.3 so I'm going to approve this change.

UniqueCcaList is essentially Set ccas no? Theres a UniqueTagList also that doesnt exist in the cose but is part of pre existing docs received from ab3, and i think its describing Set


Mobility doesn't automate

I dogmas Mobility, and my opponent had exactly two top non-red 9s (neither with factories), and it didn't automate. See screenshot, where no cards have been transferred yet.

Ah I see the problem. This interaction is implemented as two back to back interactions instead of a single one where two cards are  chosen. I can change that, which will also simplify the implementation.

So I tried the following:
// id 78, age 8: Mobility
        case "78D1A":
            if (self::getGameStateValue('release_version') >= 2)  {
                // I demand you transfer the two highest non-red top cards without a factory from your board to my score pile! If you transferred any cards, draw an 8!
                $top_cards = self::getTopCardsOnBoard($player_id);
                $color_array = array();
                for ($age = 11; $age >= 1; $age--) {
                    foreach ($top_cards as $top_card) {
                        if ($top_card['faceup_age'] == $age && $top_card['color'] != 1 && !self::hasRessource($top_card, 5)) {
                            $color_array[] = $top_card['color'];
                        }
                    }
                    if (count($color_array) >= 2) {
                        break;
                    }
                }
                $options = array(
                    'player_id' => $player_id,
                    'n' => 2,

                    'owner_from' => $player_id,
                    'location_from' => 'board',
                    'owner_to' => $launcher_id,
                    'location_to' => 'score',

                    'color' =>  $color_array
                );
                break;
            }

But I forgot about this edge case:

There's possible workarounds but it makes things more complicated. I'll probably punt this for now.

I think the best way to do this would be automatically score the cards when there are two uniquely high values...otherwise proceed with the individual transfers.

Oh good idea. I think that's only a small adjustment from the above.

I think the logic could be put in the first entry point for the demand action...that should work I think.


Create communication samples

API change check for azure-monitor-opentelemetry-exporter
API changes are not detected in this pull request for azure-monitor-opentelemetry-exporter


APP_URL (paths to assets broken)

Latest version.
APP_URL=http://localhost/bookstack/
CSS and other assets have broken paths.
example asset path (404):
http://localhost/bookstack/css/styles.css?version=v0.18.2
APP_URL=http://localhost/bookstack/public/
CSS and other assets have correct paths, but other things (such as login redirection) seem to be broken (redirection doubles path to bookstack/public/bookstack/public).
example asset path (correct):
http://localhost/bookstack/public/css/styles.css?version=v0.18.2
I have also checked other Laravel projects I have installed (or developed) and public folder is never required in the APP_URL path.

I have also checked other Laravel projects I have installed (or developed) and public folder is never required in the APP_URL path.

Yeah, public is not required in the APP_URL for BookStack either unless you want it to be there. Your first configuration is correct (Assuming you want http://localhost/bookstack/ as the main URL) and the CSS path for that looks correct. I'd imagine you're getting 404's due to how the webserver is configured with BookStack.
 Could you post your server config? Apache config or Nginx config or other...

.htacess in public/:
<IfModule mod_rewrite.c>
    <IfModule mod_negotiation.c>
        Options -MultiViews
    </IfModule>

    RewriteEngine On

    # Redirect Trailing Slashes If Not A Folder...
    RewriteCond %{REQUEST_FILENAME} !-d
    RewriteRule ^(.*)/$ /$1 [L,R=301]

    # Handle Front Controller...
    RewriteCond %{REQUEST_FILENAME} !-d
    RewriteCond %{REQUEST_FILENAME} !-f
    RewriteRule ^ index.php [L]
</IfModule>

apache2/sites-enabled/000-default.conf:
<Directory /var/www/html>
                Options Indexes FollowSymLinks MultiViews
                AllowOverride All
                Order allow,deny
                allow from all
</Directory>

apache2/apache2.conf:
<Directory /var/www/>
        Options Indexes FollowSymLinks
        AllowOverride All
        Require all granted
</Directory>

nothing else much that should be related.

@nekromoff Ah, Okay, From the above I'm assuming you're just putting the BookStack install within /var/www and then trying to access at http://example.com/bookstack-folder.
For BookStack that kind of setup is not recommended as it exposes loads of PHP files and has the potential to expose private configuration files easily. Ideally you want to put the BookStack folder somewhere else that's not directly accessible by apache.
The easiest method is to put BookStack on the root of your domain (eg. http://example.com) instead of putting it on a sub-path (http://example.com/docs) but it is possible to use a subpath if required:
I got this working on apache with the below config. You'll need to change /bookstack/install/path below to where you put your BookStack install, the /public part should stay. Advise below is at your own risk. Ensure you make backups.
Add this to your server (Within apache2/apache2.conf) or VirtualHost config:
Alias /docs /bookstack/install/path/public

You'll need to change /docs to the url path you want. This will change any requests starting with a path /docs to target the your BookStack install instead of the normal server DocumentRoot.
Add the following directory block (Can be in apache2/apache2.conf or apache2/sites-enabled/000-default.conf I think):
<Directory "/bookstack/install/path/public">
	AllowOverride None
	Require all granted
	<IfModule mod_rewrite.c>
		Options -MultiViews

		RewriteEngine On

		# Redirect Trailing Slashes If Not A Folder...
		RewriteCond %{REQUEST_FILENAME} !-d
		RewriteRule ^(.*)/$ /$1 [L,R=301]

		# Handle Front Controller...
		RewriteCond %{REQUEST_FILENAME} !-d
		RewriteCond %{REQUEST_FILENAME} !-f
		RewriteRule ^ index.php [L]
	</IfModule>
</Directory>

This block handles the requests to the BookStack install folder and prevents the need to use the .htaccess file which will improve performance and security.
Let me know if any of the above makes no sense or you need further help.

Thanks for that explanation. The thing is I want to run  Bookstack on a shared hosting, where such config changes are not easy, if not impossible at all.
Also, as I have mentioned other Laravael applications I use (or have developed) don't have these path issues, so I think this is maybe a conceptual problem with Bookstack.

Indeed, it is conceptual difference:
another anonymous Laravel app:
        <!-- Styles -->
        <link href="{{ asset('css/datatables.min.css') }}" rel="stylesheet">
        <link href="{{ asset('css/buttons.dataTables.min.css') }}" rel="stylesheet">
        <link href="{{ asset('css/bootstrap.min.css') }}" rel="stylesheet">
        <link href="{{ asset('css/main.css') }}" rel="stylesheet">

        <!-- Latest compiled and minified JavaScript -->
        <script src="{{ asset('js/jquery-3.1.1.slim.min.js') }}"></script>
        <script src="{{ asset('js/bootstrap.min.js') }}"></script>
        <script src="{{ asset('js/datatables.min.js') }}"></script>
        <script src="{{ asset('js/dataTables.buttons.min.js') }}"></script>
        <script src="{{ asset('js/buttons.html5.min.js') }}"></script>

@ssddanbrown thanks for your suggestions, I am still having issues with my setup though. This is the full config at /etc/apache2/sites-enabled/bookstack.conf(there are no other files in sites-enabled):
<VirtualHost *:80>
  ServerName bookstack.dev
  DocumentRoot /var/www/bookstack

  <Directory "/var/www/bookstack/">
    Options FollowSymLinks MultiViews
    AllowOverride All
    Require all granted
  </Directory>

  Alias /bookstack /var/www/bookstack/public

  <Directory "/var/www/bookstack/public/">
    AllowOverride None
    Require all granted
    <IfModule mod_rewrite.c>

      RewriteEngine On

      # Redirect Trailing Slashes If Not A Folder...
      RewriteCond %{REQUEST_FILENAME} !-d
      RewriteRule ^(.*)/$ /$1 [L,R=301]

      # Handle Front Controller...
      RewriteCond %{REQUEST_FILENAME} !-d
      RewriteCond %{REQUEST_FILENAME} !-f
      RewriteRule ^ index.php [L]
    </IfModule>
  </Directory>
</VirtualHost>

I am running in docker, mostly based on https://github.com/solidnerd/docker-bookstack, except for the config above and that the .htaccess file is removed. It's running behind HAProxy that directs any /bookstack requests to the docker container. APP_URL is set to http://myhost/bookstack
When I browse to http://myhost/bookstack, it redirects to http://myhost/bookstack/login, but that gives a Bookstack styled 'page not found page' (with css assets etc loaded correctly). http://myhost/bookstack/index.php/login does load the login page. It seems the rewrite rules are not the correct one, also because if I add a trailing slash, e.g. http://myhost/bookstack/login/, it gets redirected to http://myhost/login. I have tried several combinations, but my apache knowledge is limited and I haven't been able to get it to work properly.

Thank you for opening this issue. As part of an issue clean-up we're closing off older support issues that may be outdated or irrelevant so therefore I am closing this issue.
If the issue remains and it is one you are still seeking to actively solve please ensure it is still not apparent on the latest version of BookStack then open up a new issue referencing this one.
Sorry if we were not able to solve your original request.


Option for override MIN_CONFIRMATIONS

The zCash network allows sending at least two shielded transactions without waiting for 10 confirmations, but the available balance and pending balance are calculated incorrectly. I made this adjustment, and now transactions can be sent more frequently than once every 10 confirmations.
https://github.com/piratecash/pcash-wallet-android/commit/14861ae5a8bc46a848b73fed906506ef3e2f531a

Also, ywallet allow override this option to:

Hi @gades. Thank you for submitting the issue. The shielded transaction confirmations number is set to 1 in the SDK, but due to a Rust side issue, we need to wait for the upcoming update.


Add removeAllItems function

Add removeAllItems function to allow for creation of a "Clear all" button.
To use, add ref to MultiSelect component in parent component, then call method against reference.
i.e. <MultiSelect
ref={c => this._multiSelect = c}
...
/>
clearSelectedCategories = () => {
this._multiSelect.removeAllItems();
}

@pwoltman you should probably update the README alongside the PR to reflect the change in component usage. Thanks


Format Eidolon using Prettier Swift plugin

Plugin at https://github.com/prettier/prettier-swift (WIP)

Hello! I just wanted to follow up: how are things going with Prettier for Swift? Thanks again for all your work!

Now that Swift 4.1 is out, I don't think it needs a custom toolchain version of Swift. It might be more feasible to make it production worthy.

Hey Orta,
Indeed the toolchain problem should now be gone. I checked a few weeks ago
and sadly libSyntax changed quite a bit and I need to invest in some
tooling to find out what broke exactly and how to fix it. I'll update as
soon as I have something working with 4.1!
Thanks for following up,
Marcel
On Thu 29. Mar 2018 at 21:56, Orta<EMAIL_ADDRESS>wrote:

Now that Swift 4.1 is out, I don't think it needs a custom toolchain
version of Swift. It might be more feasible to make it production worthy.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/sirlantis/eidolon/pull/1#issuecomment-377353602, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AADd50Ov7qZ70X_vuyCn-ULB1THQIl59ks5tjTyDgaJpZM4RT3CC
.

Cool! Really excited to see this come to fruition!

Quick update - sadly 4.1 has a bug which swallows some newlines, so I'm stuck with 4.2 snapshots for now (🤞 for 4.2 being a better candidate).


Update Readme.md file and tried to make it as comprehensive as much as possible.

PR Checklist
Please check if your PR fulfills the following requirements:

[x] The commit message follows our guidelines: https://github.com/graycoreio/daffodil/blob/develop/CONTRIBUTING.md#commit
[x] Tests for the changes have been added (for bug fixes / features)
[x] Docs have been added / updated (for bug fixes / features)

PR Type
What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Fixes: N/A
What is the new behavior?
Does this PR introduce a breaking change?
[ ] Yes
[ ] No

Other information

@shadow0500 create a feature branch for every different PR. This PR includes way too many unrelated changes. Please familiarize yourself with our contribution guidelines.
Pay attention to the section about commit messages. The same rules apply to PR titles as those eventually become the merged, squashed commit message.
Please take a look at some of my past PRs as an example.
Closing as too broad

Okay @griest024 , I am sorry for the mess up but I will not do anything wrong from the next time .


CMSCouch shouldn't override the built in id function

id is used as an argument in a few API calls, should be replaced with doc_id and dependent code updated to reflect the change.

@ticoann any idea about this one?

id is built in function in python but we are using id as parameter as well. (in some case file too). We shouldn't do that. I will move this issue to  "When proper compensation is paid by Eric" milestone.

I am deleting this one. Whenever we get pylint warnings we can fix it gradually.


Changes required for upcoming CoffeeScript upgrade

Hi! Thanks for maintaining the remote-sync package!
In Atom v1.12, we are going to upgrade CoffeeScript to the latest version. This upgrade entails one potentially breaking change to the language:

Changed strategy for the generation of internal compiler variable names. Note that this means that @example function parameters are no longer available as naked example variables within the function body.

We think your package may be affected by this upgrade, in the following places:

The configPath variable here

These findings are based on linting packages with coffeescope. We could be wrong about some of them. When we release v1.12 beta, please test your package against it to make sure that it works. Let me know if you have any further questions; I will be happy to help!

@maxbrunsfeld thanks.


Don't get windows username in .NET Standard 2.0

Running the .NET Standard 2.0 version on Linux throws PlatformNotSupportedException
See https://issues.apache.org/jira/browse/LOG4NET-652

Thanks for the contribution. This has been resolved in master and I have a release pending a vote on the dev lists for 2.0.12. I'm closing this out as people are looking for the fix. I would have preferred to have had your work & commit history so that the change would be attributed to you.


Performance Benchmarking Tips

We should create a page in the docs to collect tips for benchmarking performance:

Start by measuring your JS, and confirming that it's slow in a way that Rust/Wasm will be faster in (with rough estimates of how much faster, and a link to a benchmark):

parsing - yes (2.5x faster)
matrix math - yes
generating vertex shaders - yes
dom manipulation - no
When in doubt, ask the Slack if the slowness in your app can be improved by Zaplib before you invest time into writing a port!

Use performance.now in JS & Instant::now() in Rust
Run the tests a couple of times and take an average
Run the wasm tests with the browser devtools closed (open after or use HTML to see results)

I think Instant::now() won't work in Rust when compiled into wasm. Probably better use zaplib::UniversalInstant::now() instead?

Oh damn! That's what I was using... What's the problem with it?

Hm it seems like it infers to use UniversalInstant from this: https://github.com/Zaplib/zaplib/pull/166/files#diff-6ab2609914bb3aa54a94aa7d90dc83537e41efed475d85ddbb31ed3e413f5aadR44 I guess since we define and implement an Instant trait for UniversalInstant. We probably shouldn't do that to avoid confusion with std::time::Instant..

Ah, yes! That's quite confusing usage. I suspect if you remove type annotation on UniversalInstant then it won't compile/work anymore - so you are indeed using UniverstalInstant not the typical std::time::Instant.

Oh fascinating! It did error and suggested I add that type annotation, so that's how the code ended up in that state.

Maybe we link to resources like this https://nnethercote.github.io/perf-book/introduction.html